diff --git a/_toc.yml b/_toc.yml
index 9a55b3b..9d4f64e 100644
--- a/_toc.yml
+++ b/_toc.yml
@@ -4,6 +4,7 @@
 format: jb-book
 root: docs/intro
 chapters:
-- file: notebooks/1_crawl_reviews
+- file: notebooks/1_collect_reviews
 - file: notebooks/2_inference
 - file: notebooks/3_evaluation
+- file: docs/conclusion
diff --git a/data/JetBrains_kotlin_1000.csv b/data/JetBrains_kotlin_1000.csv
new file mode 100644
index 0000000..e079917
--- /dev/null
+++ b/data/JetBrains_kotlin_1000.csv
@@ -0,0 +1,60511 @@
+,diff_hunk,human_review,created_at
+946,"@@ -0,0 +1 @@
++org.jetbrains.kotlin.idea.inspections.RemoveRedundantBackticksInspection",Please add a test to verify that the quickfix is not offered when an actual keyword is in backticks.,2017-08-03 11:03:49
+46,"@@ -0,0 +1 @@
++throw Exception(""not implemented"") //To change body of created methods use File | Settings | File Templates.","`UnsupportedOperationException` would be a better choice
+",2013-04-26 11:06:35
+51,"@@ -0,0 +1,10 @@
++// ""Create class object from usage"" ""true""
++// ERROR: Expression 'T' of type '<class-object-for-T>' cannot be invoked as a function
++trait T {
++    class object {
++    }","Can you come up with better use case for quick fix creating class object? This one from the test doesn't seem useful.
+
+Creating class object via intetion could be useful in case of T.foo() call, but in this case foo() function should be created as well (actually, it should be ""create function from usage"" quick fix, not ""create class object from usage"").
+",2013-04-26 11:16:26
+958,"@@ -0,0 +1,10 @@
++open class Foo {
++    open fun arguments(arg1: Int, arg2: Long) {
++    }
++}
++
++class Bar : Foo() {
++    override <caret>fun arguments(arg1: Int, arg2: Long) {","I should mention that overridden function is not redundant if it has some other modifiers. For example, sometimes is reasonable to add `final` here, so function itself is not changed, but derived classes are made unable to override it. Also, I think that any annotation here makes the function not redundant. The same for any visibility modifier when you make overridden function more visible then original one. Please consider these cases, fix inspection, and add tests for them.",2017-08-14 10:22:17
+190,"@@ -0,0 +1,101 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        //val expectedType = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element.getFunctionLiteral()]
++        //println(""expected type of the function literal is "" + expectedType)
++        //val expectedType2 = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element]
++        //println(""expected type of the function literal exp is "" + expectedType2)
++
++        if (hasExplicitReturnType(element)) return true
++        if (hasExplicitReceiverType(element)) return true
++        if (hasExplicitParamType(element)) return true
++        return false","A one-liner would be nicer in my opinion:
+`return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)`
+",2014-04-21 19:05:28
+189,"@@ -0,0 +1,101 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        //val expectedType = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element.getFunctionLiteral()]
++        //println(""expected type of the function literal is "" + expectedType)
++        //val expectedType2 = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element]
++        //println(""expected type of the function literal exp is "" + expectedType2)
++
++        if (hasExplicitReturnType(element)) return true
++        if (hasExplicitReceiverType(element)) return true
++        if (hasExplicitParamType(element)) return true
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()?.getText() ?: parameter.getText() ?: """"","Are all three sub-expressions of this elvis expression tested?
+",2014-04-21 19:02:50
+188,"@@ -0,0 +1,101 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        //val expectedType = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element.getFunctionLiteral()]
++        //println(""expected type of the function literal is "" + expectedType)
++        //val expectedType2 = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element]
++        //println(""expected type of the function literal exp is "" + expectedType2)
++
++        if (hasExplicitReturnType(element)) return true
++        if (hasExplicitReceiverType(element)) return true
++        if (hasExplicitParamType(element)) return true
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()?.getText() ?: parameter.getText() ?: """"
++                                              }).makeString("", "", ""("", "")"")
++            println(""parameterString is "" + parameterString)","Don't forget to delete all debug output from your changeset
+",2014-04-21 19:00:15
+191,"@@ -0,0 +1,101 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        //val expectedType = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element.getFunctionLiteral()]
++        //println(""expected type of the function literal is "" + expectedType)
++        //val expectedType2 = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element]
++        //println(""expected type of the function literal exp is "" + expectedType2)
++
++        if (hasExplicitReturnType(element)) return true
++        if (hasExplicitReceiverType(element)) return true
++        if (hasExplicitParamType(element)) return true
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()?.getText() ?: parameter.getText() ?: """"
++                                              }).makeString("", "", ""("", "")"")
++            println(""parameterString is "" + parameterString)
++            val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++            oldParameterList.replace(newParameterList)
++        }
++
++        if (!hasExplicitParamType(element)) {
++            val currentParamList = element.getFunctionLiteral().getValueParameterList()
++            val firstChild = currentParamList?.getFirstChild()
++            if (firstChild?.getText() == ""("") firstChild!!.delete()","It's not very acceptable to compare text of nodes, especially when you can do the same structurally:
+`firstChild.getElementType() == JetTokens.LPAR`
+",2014-04-21 19:11:58
+192,"@@ -0,0 +1,101 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        //val expectedType = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element.getFunctionLiteral()]
++        //println(""expected type of the function literal is "" + expectedType)
++        //val expectedType2 = context[BindingContext.EXPECTED_EXPRESSION_TYPE, element]
++        //println(""expected type of the function literal exp is "" + expectedType2)
++
++        if (hasExplicitReturnType(element)) return true
++        if (hasExplicitReceiverType(element)) return true
++        if (hasExplicitParamType(element)) return true
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()?.getText() ?: parameter.getText() ?: """"
++                                              }).makeString("", "", ""("", "")"")
++            println(""parameterString is "" + parameterString)
++            val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++            oldParameterList.replace(newParameterList)
++        }
++
++        if (!hasExplicitParamType(element)) {
++            val currentParamList = element.getFunctionLiteral().getValueParameterList()
++            val firstChild = currentParamList?.getFirstChild()
++            if (firstChild?.getText() == ""("") firstChild!!.delete()
++            val lastChild = currentParamList?.getLastChild()
++            if (lastChild?.getText() == "")"") lastChild!!.delete()","Ditto (`JetTokens.RPAR`)
+",2014-04-21 19:12:11
+987,"@@ -0,0 +1,102 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.effectsystem.impls.*
++import org.jetbrains.kotlin.effectsystem.structure.ESClause
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.structure.ESExpressionVisitor
++
++class InfoCollector(private val observedEffect: ESEffect) : ESExpressionVisitor<MutableContextInfo> {
++    private var isInverted: Boolean = false
++
++    fun collectFromSchema(schema: EffectSchema): MutableContextInfo =
++            schema.clauses.mapNotNull { collectFromClause(it) }.fold(MutableContextInfo.EMPTY, { resultingInfo, clauseInfo -> resultingInfo.and(clauseInfo) })
++
++    private fun collectFromClause(clause: ESClause): MutableContextInfo? {
++        val premise = clause.condition",This name contradicts with real semantics,2017-08-15 16:57:17
+986,"@@ -0,0 +1,102 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.effectsystem.impls.*
++import org.jetbrains.kotlin.effectsystem.structure.ESClause
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.structure.ESExpressionVisitor
++
++class InfoCollector(private val observedEffect: ESEffect) : ESExpressionVisitor<MutableContextInfo> {
++    private var isInverted: Boolean = false
++
++    fun collectFromSchema(schema: EffectSchema): MutableContextInfo =
++            schema.clauses.mapNotNull { collectFromClause(it) }.fold(MutableContextInfo.EMPTY, { resultingInfo, clauseInfo -> resultingInfo.and(clauseInfo) })
++
++    private fun collectFromClause(clause: ESClause): MutableContextInfo? {
++        val premise = clause.condition
++
++        // Check for non-conditional effects
++        if (premise is ESBooleanConstant && premise.value) {
++            return MutableContextInfo.EMPTY.fire(clause.effect)","As we have discussed, logically this conclusion is erroneous. I strongly recommend to fix this, because you can create true clause condition in some other context thus getting really wrong conclusion",2017-08-15 16:56:49
+989,"@@ -0,0 +1,102 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.effectsystem.impls.*
++import org.jetbrains.kotlin.effectsystem.structure.ESClause
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.structure.ESExpressionVisitor
++
++class InfoCollector(private val observedEffect: ESEffect) : ESExpressionVisitor<MutableContextInfo> {
++    private var isInverted: Boolean = false
++
++    fun collectFromSchema(schema: EffectSchema): MutableContextInfo =
++            schema.clauses.mapNotNull { collectFromClause(it) }.fold(MutableContextInfo.EMPTY, { resultingInfo, clauseInfo -> resultingInfo.and(clauseInfo) })
++
++    private fun collectFromClause(clause: ESClause): MutableContextInfo? {
++        val premise = clause.condition
++
++        // Check for non-conditional effects
++        if (premise is ESBooleanConstant && premise.value) {
++            return MutableContextInfo.EMPTY.fire(clause.effect)
++        }
++
++        // Check for information from conditional effects
++        return when (observedEffect.isImplies(clause.effect)) {
++            // observed effect implies clause's effect => clause's effect was fired => clause's condition is true
++            true -> clause.condition.accept(this)
++
++            // Observed effect *may* or *doesn't* implies clause's - no useful information
++            null, false -> null
++        }
++    }
++
++    override fun visitIs(isOperator: ESIs): MutableContextInfo = with(isOperator) {
++        if (isNegated != isInverted) MutableContextInfo.EMPTY.notSubtype(left, type) else MutableContextInfo.EMPTY.subtype(left, type)
++    }
++
++    override fun visitEqual(equal: ESEqual): MutableContextInfo = with(equal) {
++        if (isNegated != isInverted) MutableContextInfo.EMPTY.notEqual(left, right) else MutableContextInfo.EMPTY.equal(left, right)
++    }
++
++    override fun visitAnd(and: ESAnd): MutableContextInfo {
++        val leftInfo = and.left.accept(this)
++        val rightInfo = and.right.accept(this)
++
++        return if (isInverted) leftInfo.or(rightInfo) else leftInfo.and(rightInfo)
++    }
++
++    override fun visitNot(not: ESNot): MutableContextInfo = inverted { not.arg.accept(this) }
++
++    override fun visitOr(or: ESOr): MutableContextInfo {
++        val leftInfo = or.left.accept(this)
++        val rightInfo = or.right.accept(this)
++        return if (isInverted) leftInfo.and(rightInfo) else leftInfo.or(rightInfo)
++    }
++
++    override fun visitVariable(esVariable: ESVariable): MutableContextInfo {
++        throw IllegalStateException(""InfoCollector shouldn't visit non-boolean values"")
++    }
++
++    override fun visitBooleanVariable(esBooleanVariable: ESBooleanVariable): MutableContextInfo =
++            if (isInverted)
++                MutableContextInfo.EMPTY.equal(esBooleanVariable, false.lift())
++            else
++                MutableContextInfo.EMPTY.equal(esBooleanVariable, true.lift())
++
++    override fun visitBooleanConstant(esBooleanConstant: ESBooleanConstant): MutableContextInfo {
++        throw IllegalStateException(""InfoCollector shouldn't visit constants"")
++    }
++
++    override fun visitConstant(esConstant: ESConstant): MutableContextInfo {
++        throw IllegalStateException(""InfoCollector shouldn't visit constants"")
++    }
++
++    override fun visitLambda(esLambda: ESLambda): MutableContextInfo {
++        throw IllegalStateException(""InfoCollector shouldn't visit non-boolean values"")
++    }
++
++    private fun <R> inverted(block: () -> R): R {
++        isInverted = isInverted.not()
++        val result = block()
++        isInverted = isInverted.not()",Ugly construction. Are you sure it's really needed?,2017-08-15 17:03:26
+999,"@@ -0,0 +1,102 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.getCallNameExpression
++
++class KotlinRedundantOverrideInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitNamedFunction(function: KtNamedFunction) {
++                    super.visitNamedFunction(function)
++                    if (!function.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return
++                    if (function.containsOtherModifier()) return",I'd inline this function,2017-08-18 08:16:24
+998,"@@ -0,0 +1,102 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.getCallNameExpression
++
++class KotlinRedundantOverrideInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitNamedFunction(function: KtNamedFunction) {
++                    super.visitNamedFunction(function)
++                    if (!function.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return
++                    if (function.containsOtherModifier()) return
++                    if (function.annotationEntries.size != 0) return
++
++                    val bodyExpression = function.bodyExpression
++                    bodyExpression ?: return",This and previous can be written in one line,2017-08-18 08:16:15
+483,"@@ -0,0 +1,103 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.resolve
++
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.descriptors.*
++import org.jetbrains.kotlin.descriptors.annotations.AnnotationDescriptor
++import org.jetbrains.kotlin.descriptors.annotations.AnnotationUseSiteTarget
++import org.jetbrains.kotlin.descriptors.annotations.Annotations
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.annotations.argumentValue
++
++private val JAVA_DEPRECATED = FqName(Deprecated::class.java.name)","This was corrupted by the refactoring and is now in fact ""kotlin.Deprecated"". Let's use a hard-coded string instead.
+",2015-10-10 20:41:17
+979,"@@ -0,0 +1,103 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.visitors
++
++import org.jetbrains.kotlin.effectsystem.factories.boundSchemaFromClauses
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.factories.negated
++import org.jetbrains.kotlin.effectsystem.impls.*
++import org.jetbrains.kotlin.effectsystem.structure.*
++import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf
++
++/**
++ * Reduces given effect schema by evaluating constant expressions,
++ * throwing away senseless checks and infeasible clauses, etc.
++ */
++class Reducer : ESExpressionVisitor<ESExpression?> {
++    fun reduceSchema(schema: EffectSchema): EffectSchema =
++            boundSchemaFromClauses(schema.clauses.mapNotNull { reduceClause(it) })
++
++    private fun reduceClause(clause: org.jetbrains.kotlin.effectsystem.structure.ESClause): org.jetbrains.kotlin.effectsystem.structure.ESClause? {",Fully qualified names for some reason,2017-08-15 16:39:16
+980,"@@ -0,0 +1,103 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.visitors
++
++import org.jetbrains.kotlin.effectsystem.factories.boundSchemaFromClauses
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.factories.negated
++import org.jetbrains.kotlin.effectsystem.impls.*
++import org.jetbrains.kotlin.effectsystem.structure.*
++import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf
++
++/**
++ * Reduces given effect schema by evaluating constant expressions,
++ * throwing away senseless checks and infeasible clauses, etc.
++ */
++class Reducer : ESExpressionVisitor<ESExpression?> {
++    fun reduceSchema(schema: EffectSchema): EffectSchema =
++            boundSchemaFromClauses(schema.clauses.mapNotNull { reduceClause(it) })
++
++    private fun reduceClause(clause: org.jetbrains.kotlin.effectsystem.structure.ESClause): org.jetbrains.kotlin.effectsystem.structure.ESClause? {
++        val reducedPremise = clause.condition.accept(this) as ESBooleanExpression
++
++        // Filter never executed premises
++        return if (reducedPremise is ESBooleanConstant && !reducedPremise.value) null else ESClause(reducedPremise, clause.effect)",I don't like this `null` because its meaning is unclear. It's better to introduce thing like `ESFalseClause`.,2017-08-15 16:42:36
+981,"@@ -0,0 +1,103 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.visitors
++
++import org.jetbrains.kotlin.effectsystem.factories.boundSchemaFromClauses
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.factories.negated
++import org.jetbrains.kotlin.effectsystem.impls.*
++import org.jetbrains.kotlin.effectsystem.structure.*
++import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf
++
++/**
++ * Reduces given effect schema by evaluating constant expressions,
++ * throwing away senseless checks and infeasible clauses, etc.
++ */
++class Reducer : ESExpressionVisitor<ESExpression?> {
++    fun reduceSchema(schema: EffectSchema): EffectSchema =
++            boundSchemaFromClauses(schema.clauses.mapNotNull { reduceClause(it) })
++
++    private fun reduceClause(clause: org.jetbrains.kotlin.effectsystem.structure.ESClause): org.jetbrains.kotlin.effectsystem.structure.ESClause? {
++        val reducedPremise = clause.condition.accept(this) as ESBooleanExpression
++
++        // Filter never executed premises
++        return if (reducedPremise is ESBooleanConstant && !reducedPremise.value) null else ESClause(reducedPremise, clause.effect)
++    }
++
++    override fun visitIs(isOperator: ESIs): ESBooleanExpression {
++        val reducedArg = isOperator.left.accept(this) as ESValue
++
++        val result = when (reducedArg) {
++            is ESConstant -> reducedArg.type.isSubtypeOf(isOperator.functor.type)
++            is ESVariable -> if (reducedArg.type.isSubtypeOf(isOperator.functor.type)) true else null
++            else -> throw IllegalStateException(""Unknown subtype of ESValue: $reducedArg"")
++        }
++
++        // Result is unknown, do not evaluate
++        result ?: return ESIs(reducedArg, isOperator.functor)
++
++        return result.xor(isOperator.functor.isNegated).lift()
++    }
++
++    override fun visitEqual(equal: ESEqual): ESBooleanExpression {
++        val reducedLeft = equal.left.accept(this) as ESValue
++        val reducedRight = equal.right
++
++        if (reducedLeft is ESConstant) return (reducedLeft.value == reducedRight.value).xor(equal.functor.isNegated).lift()","Just to ask: how does it work with different kinds of comparisons (`==`, `===`)?",2017-08-15 16:44:06
+711,"@@ -0,0 +1,104 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import com.intellij.psi.CommonClassNames
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.ElementKind
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++import javax.lang.model.element.VariableElement
++import javax.lang.model.type.NoType
++import javax.lang.model.type.TypeKind
++
++class JavacClass<T : TypeElement>(element: T,
++                                  javac: Javac) : JavacClassifier<TypeElement>(element, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())
++
++    override val isAbstract
++        get() = element.isAbstract
++
++    override val isStatic
++        get() = element.isStatic
++
++    override val isFinal
++        get() = element.isFinal
++
++    override val visibility
++        get() = element.getVisibility()
++
++    override val typeParameters: List<JavaTypeParameter>
++        get() = element.typeParameters.map { JavacTypeParameter(it, javac) }
++
++    override val fqName
++        get() = FqName(element.qualifiedName.toString())
++
++    override val supertypes
++        get() = element.interfaces.toMutableList().apply {
++            if (element.superclass !is NoType) add(element.superclass)
++
++            val hasObject = !none { it.toString() == CommonClassNames.JAVA_LANG_OBJECT }
++            if (!hasObject && element.toString() != CommonClassNames.JAVA_LANG_OBJECT) {
++                javac.JAVA_LANG_OBJECT?.let { add(it.element.asType()) }",Should we do it if a class already has a super class?,2017-04-05 14:49:17
+712,"@@ -0,0 +1,104 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import com.intellij.psi.CommonClassNames
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.ElementKind
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++import javax.lang.model.element.VariableElement
++import javax.lang.model.type.NoType
++import javax.lang.model.type.TypeKind
++
++class JavacClass<T : TypeElement>(element: T,
++                                  javac: Javac) : JavacClassifier<TypeElement>(element, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())
++
++    override val isAbstract
++        get() = element.isAbstract
++
++    override val isStatic
++        get() = element.isStatic
++
++    override val isFinal
++        get() = element.isFinal
++
++    override val visibility
++        get() = element.getVisibility()
++
++    override val typeParameters: List<JavaTypeParameter>
++        get() = element.typeParameters.map { JavacTypeParameter(it, javac) }
++
++    override val fqName
++        get() = FqName(element.qualifiedName.toString())
++
++    override val supertypes
++        get() = element.interfaces.toMutableList().apply {
++            if (element.superclass !is NoType) add(element.superclass)
++
++            val hasObject = !none { it.toString() == CommonClassNames.JAVA_LANG_OBJECT }
++            if (!hasObject && element.toString() != CommonClassNames.JAVA_LANG_OBJECT) {
++                javac.JAVA_LANG_OBJECT?.let { add(it.element.asType()) }
++            }
++        }.map { JavacClassifierType(it, javac) }
++
++    override val innerClasses
++        get() = element.enclosedElements
++                .filter { it.asType().kind == TypeKind.DECLARED }
++                .filterIsInstance(TypeElement::class.java)
++                .map { JavacClass(it, javac) }
++
++    override val outerClass: JavaClass?
++        get() = element.enclosingElement?.let {
++            if (it.asType().kind != TypeKind.DECLARED) null else JavacClass(it as TypeElement, javac)
++        }
++
++    override val isInterface
++        get() = element.kind == ElementKind.INTERFACE
++
++    override val isAnnotationType
++        get() = element.kind == ElementKind.ANNOTATION_TYPE
++
++    override val isEnum
++        get() = element.kind == ElementKind.ENUM
++
++    override val lightClassOriginKind = null
++
++    override val methods: Collection<JavaMethod>
++        get() = element.enclosedElements","Here (and for many other properties) getters are in use. Are you sure this property is read just a few times and we do not spend too much time here? As a possible alternative, you can use `by lazy`.",2017-04-05 14:53:38
+31,"@@ -0,0 +1,105 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.TemplateBuilder;
++import com.intellij.codeInsight.template.TemplateBuilderFactory;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.plugin.JetBundle;
++
++import java.util.Collection;
++import java.util.LinkedHashSet;
++
++public class MapPlatformClassToKotlinFix extends JetIntentionAction<JetUserType> {
++    LinkedHashSet<String> possibleTypes;
++
++    public MapPlatformClassToKotlinFix(@NotNull JetUserType element, LinkedHashSet<String> possibleTypes) {
++        super(element);
++        this.possibleTypes = possibleTypes;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return possibleTypes.size() == 1
++               ? JetBundle.message(""map.platform.class.to.kotlin"", element.getText(), possibleTypes.iterator().next())
++               : JetBundle.message(""map.platform.class.to.kotlin.multiple"", element.getText());
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""map.platform.class.to.kotlin.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        JetTypeReference newType = JetPsiFactory.createType(project, possibleTypes.iterator().next());
++        JetTypeElement newTypeElement = newType.getTypeElement();
++        assert newTypeElement != null;
++        PsiElement replacedElement = element.replace(newTypeElement);
++
++        if (possibleTypes.size() > 1) {
++            PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(editor.getDocument());
++            TemplateBuilder builder = TemplateBuilderFactory.getInstance().createTemplateBuilder(replacedElement);
++            builder.replaceElement(replacedElement, new MyLookupExpression(replacedElement.getText(), possibleTypes, null, false, getText()));
++            builder.run(editor, true);
++        }
++    }
++
++    public static JetIntentionActionFactory createFactory() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetUserType type = QuickFixUtil.getParentElementOfType(diagnostic, JetUserType.class);
++                if (type == null) return null;
++
++                if (!(diagnostic instanceof DiagnosticWithParameters1)) return null;","It would be better to assert type of diagnostic.getFactory() at the begining, and cast diagnostic to DiagnosticWithParameters1<JetElement, Collection<ClassDescriptor>>. See AddStarProjectionsFix. Don't forget to supress unchecked warning in this case.
+",2013-02-21 13:43:35
+3,"@@ -0,0 +1,105 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<project xmlns=""http://maven.apache.org/POM/4.0.0""
++         xmlns:xsi=""http://www.w3.org/2001/XMLSchema-instance""
++         xsi:schemaLocation=""http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"">
++    <modelVersion>4.0.0</modelVersion>
++
++    <groupId>org.jetbrains.kotlin.it</groupId>
++    <artifactId>test-helloworld</artifactId>
++    <version>1.0</version>
++    <name>Test Hello World project</name>
++
++    <description>
++        Test the kotlin-maven-plugin:compile goal on HelloWorld project.
++    </description>
++
++    <properties>
++        <kotlin.version>0.1-SNAPSHOT</kotlin.version>
++    </properties>
++
++    <dependencies>
++        <dependency>
++            <groupId>junit</groupId>
++            <artifactId>junit</artifactId>
++            <version>4.9</version>
++        </dependency>
++    </dependencies>
++
++    <build>
++        <!--suppress MavenModelInspection -->
++        <sourceDirectory>${project.basedir}/src/main/kotlin</sourceDirectory>
++        <!--suppress MavenModelInspection -->
++        <!--testSourceDirectory>${project.basedir}/src/test/kotlin</testSourceDirectory-->
++        <plugins>
++            <plugin>
++                <artifactId>kotlin-maven-plugin</artifactId>
++                <groupId>org.jetbrains.kotlin</groupId>
++                <version>${kotlin.version}</version>
++                <executions>
++                    <execution>
++                        <id>compile</id>
++                        <phase>process-sources</phase>
++                        <goals>
++                            <goal>compile</goal>
++                        </goals>
++                    </execution>
++                    <execution>
++                        <id>test-compile</id>
++                        <phase>process-test-sources</phase>
++                        <goals>
++                            <goal>test-compile</goal>
++                        </goals>
++                    </execution>
++                </executions>
++            </plugin>
++        </plugins>
++    </build>
++
++
++    <repositories>
++        <repository>
++            <id>jetbrains-release</id>
++            <url>http://repository.jetbrains.com/releases</url>
++            <releases>
++                <enabled>true</enabled>
++            </releases>
++            <snapshots>
++                <enabled>false</enabled>
++            </snapshots>
++        </repository>
++        <repository>
++            <id>jetbrains-snapshots</id>
++            <url>http://repository.jetbrains.com/kotlin-snapshots</url>
++            <releases>
++                <enabled>false</enabled>
++            </releases>
++            <snapshots>
++                <enabled>true</enabled>
++            </snapshots>
++        </repository>
++    </repositories>
++
++    <pluginRepositories>
++        <pluginRepository>","Do we need all those repositories here?
+",2012-05-08 15:33:08
+390,"@@ -0,0 +1,107 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.findUsages.handlers
++
++import com.intellij.find.findUsages.FindUsagesHandler
++import com.intellij.find.findUsages.FindUsagesOptions
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiReference
++import com.intellij.psi.search.GlobalSearchScope
++import com.intellij.psi.search.SearchScope
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.kotlin.idea.findUsages.KotlinFindUsagesHandlerFactory
++import org.jetbrains.kotlin.idea.util.application.runReadAction
++
++import java.util.ArrayList
++import java.util.Collections
++
++public abstract class KotlinFindUsagesHandler<T : PsiElement>(psiElement: T,
++                                                              private val elementsToSearch: Collection<PsiElement>,
++                                                              public val factory: KotlinFindUsagesHandlerFactory)
++    : FindUsagesHandler(psiElement) {
++
++    @suppress(""UNCHECKED_CAST"")
++    public fun getElement(): T {
++        return getPsiElement() as T
++    }
++
++    public constructor(psiElement: T, factory: KotlinFindUsagesHandlerFactory) : this(psiElement, emptyList(), factory) {
++    }
++
++    override fun getPrimaryElements(): Array<PsiElement> {
++        return if (elementsToSearch.isEmpty())
++            arrayOf(getPsiElement())
++        else
++            elementsToSearch.toTypedArray()
++    }
++
++    protected fun searchTextOccurrences(element: PsiElement, processor: Processor<UsageInfo>, options: FindUsagesOptions): Boolean {
++        val scope = options.searchScope
++
++        val searchText = options.isSearchForTextOccurrences && scope is GlobalSearchScope","If you inline this variable, you can get rid of `as` operators below.
+",2015-07-13 20:54:57
+391,"@@ -0,0 +1,107 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.findUsages.handlers
++
++import com.intellij.find.findUsages.FindUsagesHandler
++import com.intellij.find.findUsages.FindUsagesOptions
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiReference
++import com.intellij.psi.search.GlobalSearchScope
++import com.intellij.psi.search.SearchScope
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.kotlin.idea.findUsages.KotlinFindUsagesHandlerFactory
++import org.jetbrains.kotlin.idea.util.application.runReadAction
++
++import java.util.ArrayList
++import java.util.Collections
++
++public abstract class KotlinFindUsagesHandler<T : PsiElement>(psiElement: T,
++                                                              private val elementsToSearch: Collection<PsiElement>,
++                                                              public val factory: KotlinFindUsagesHandlerFactory)
++    : FindUsagesHandler(psiElement) {
++
++    @suppress(""UNCHECKED_CAST"")
++    public fun getElement(): T {
++        return getPsiElement() as T
++    }
++
++    public constructor(psiElement: T, factory: KotlinFindUsagesHandlerFactory) : this(psiElement, emptyList(), factory) {
++    }
++
++    override fun getPrimaryElements(): Array<PsiElement> {
++        return if (elementsToSearch.isEmpty())
++            arrayOf(getPsiElement())
++        else
++            elementsToSearch.toTypedArray()
++    }
++
++    protected fun searchTextOccurrences(element: PsiElement, processor: Processor<UsageInfo>, options: FindUsagesOptions): Boolean {
++        val scope = options.searchScope
++
++        val searchText = options.isSearchForTextOccurrences && scope is GlobalSearchScope
++
++        if (searchText) {
++            if (options.fastTrack != null) {","If you revert this condition, you can get rid of `else`.
+",2015-07-13 20:56:29
+27,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.JetClass;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lexer.JetKeywordToken;
++import org.jetbrains.jet.lexer.JetToken;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManager;
++
++import static org.jetbrains.jet.lexer.JetTokens.FINAL_KEYWORD;
++import static org.jetbrains.jet.lexer.JetTokens.OPEN_KEYWORD;
++
++public class FinalSupertypeFix extends JetIntentionAction<JetClass> {
++    private final JetClass childClass;
++    private JetClass superClass;
++
++    public FinalSupertypeFix(@NotNull JetClass childClass) {
++        super(childClass);
++        this.childClass = childClass;
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        if (!super.isAvailable(project, editor, file)) {
++            return false;
++        }
++
++        BindingContext context = KotlinCacheManager.getInstance(project).getDeclarationsFromProject(project).getBindingContext();
++        ClassDescriptor childClassDescriptor = context.get(BindingContext.CLASS, childClass);
++        if (childClassDescriptor == null) {
++            return false;
++        }
++        for (JetType supertype: childClassDescriptor.getTypeConstructor().getSupertypes()) {
++            ClassDescriptor superClassDescriptor = (ClassDescriptor) supertype.getConstructor().getDeclarationDescriptor();
++            if (superClassDescriptor == null) {
++                continue;
++            }
++            PsiElement boundElement = BindingContextUtils.descriptorToDeclaration(context, superClassDescriptor);
++            if (boundElement instanceof JetClass) {","Why do you call it ""bound element""?
+",2013-01-29 14:11:30
+28,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.JetClass;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lexer.JetKeywordToken;
++import org.jetbrains.jet.lexer.JetToken;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManager;
++
++import static org.jetbrains.jet.lexer.JetTokens.FINAL_KEYWORD;
++import static org.jetbrains.jet.lexer.JetTokens.OPEN_KEYWORD;
++
++public class FinalSupertypeFix extends JetIntentionAction<JetClass> {
++    private final JetClass childClass;
++    private JetClass superClass;
++
++    public FinalSupertypeFix(@NotNull JetClass childClass) {
++        super(childClass);
++        this.childClass = childClass;
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        if (!super.isAvailable(project, editor, file)) {
++            return false;
++        }
++
++        BindingContext context = KotlinCacheManager.getInstance(project).getDeclarationsFromProject(project).getBindingContext();
++        ClassDescriptor childClassDescriptor = context.get(BindingContext.CLASS, childClass);
++        if (childClassDescriptor == null) {
++            return false;
++        }
++        for (JetType supertype: childClassDescriptor.getTypeConstructor().getSupertypes()) {
++            ClassDescriptor superClassDescriptor = (ClassDescriptor) supertype.getConstructor().getDeclarationDescriptor();
++            if (superClassDescriptor == null) {
++                continue;
++            }
++            PsiElement boundElement = BindingContextUtils.descriptorToDeclaration(context, superClassDescriptor);
++            if (boundElement instanceof JetClass) {
++                superClass = (JetClass) boundElement;
++                if (!superClass.isTrait() && !superClass.isEnum() && superClass.getContainingFile().isWritable()) {
++                    return true;
++                }
++            }
++        }
++        return false;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""add.supertype.modifier"", ""open"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""add.supertype.modifier.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert superClass != null;
++        JetToken[] modifiersThanCanBeReplaced = new JetKeywordToken[] { FINAL_KEYWORD };
++        superClass.replace(AddModifierFix.addModifier(superClass, OPEN_KEYWORD, modifiersThanCanBeReplaced, project, false));
++    }
++
++    @Nullable","Why is this method nullable?
+",2013-01-29 14:13:59
+168,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++","Please declare all variables exactly before they are needed. It's usually a bad idea to declare all variables at once and then write the whole logic. A reader might think that the following behavior somehow depends on values of all these variables, while in reality your code should look more like: if doesn't have declared param types, return true; **else** if doesn't have declared return type, return true; **else** and so on. That's a lot easier to grasp, since you don't have to carry a lot of context while reading the code
+",2014-04-09 16:03:44
+155,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())","There's an inspection here saying that you should use `[]` instead of `get`
+",2014-04-09 15:27:00
+157,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()","There are warnings saying that `!!` is useless on `func`, since it's been already checked to be non-null.
+
+Also these variables don't add much to the readability, it may be a good idea to inline them
+",2014-04-09 15:28:01
+158,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true","There's a warning saying that `getValueParameters` never returns null. Maybe you meant to check if it's non-empty?
+",2014-04-09 15:28:26
+161,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val params = element.getFunctionLiteral().getValueParameterList()","You call `element.getFunctionLiteral()` **a lot** in this function. Why not extract it to a named variable?
+",2014-04-09 15:39:27
+156,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val params = element.getFunctionLiteral().getValueParameterList()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())!!","Ditto (`[]` instead of `get`)
+",2014-04-09 15:27:22
+166,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val params = element.getFunctionLiteral().getValueParameterList()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())!!
++        val valueParameters = func!!.getValueParameters()
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()","Again, please declare all variables exactly before they are needed. In this function, `expectedReturnType` is only needed in Step 2, so declare it there. `expectedReceiverType` is only needed in Step 3, and so on
+",2014-04-09 15:53:33
+160,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val params = element.getFunctionLiteral().getValueParameterList()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())!!
++        val valueParameters = func!!.getValueParameters()
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++        val parameterString = StringUtil.join(valueParameters,
++                                              {(descriptor: ValueParameterDescriptor?): String ->
++                                                  """" + descriptor!!.getName() +
++                                                  "": "" + DescriptorRenderer.TEXT.renderType(descriptor!!.getType())","There's a warning here about a useless `!!`: you've already asserted that `descriptor` is non-null on the previous line
+",2014-04-09 15:37:48
+165,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val params = element.getFunctionLiteral().getValueParameterList()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())!!
++        val valueParameters = func!!.getValueParameters()
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++        val parameterString = StringUtil.join(valueParameters,
++                                              {(descriptor: ValueParameterDescriptor?): String ->
++                                                  """" + descriptor!!.getName() +
++                                                  "": "" + DescriptorRenderer.TEXT.renderType(descriptor!!.getType())
++                                              },
++                                              "", "");
++
++        // Step 1: make the parameters types explicit
++        val newParameterList = JetPsiFactory.createParameterList(element.getProject(), ""("" + parameterString + "")"")","A nicer way would be to use `makeString`, which allows to pass a prefix and a postfix:
+`val parameterString = valueParameters.map { ... }.makeString("", "", ""("", "")"")`
+",2014-04-09 15:53:16
+159,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import com.intellij.openapi.util.text.StringUtil
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++
++        if (!hasDeclaredReturnType && expectedReturnType != null) return true
++        if (!hasDeclaredReceiverType && expectedReceiverType != null) return true
++        if (!hasDeclaredParamsType && func!!.getValueParameters() != null) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val params = element.getFunctionLiteral().getValueParameterList()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context.get(BindingContext.FUNCTION, element.getFunctionLiteral())!!
++        val valueParameters = func!!.getValueParameters()
++        val expectedReturnType = func!!.getReturnType()
++        val expectedReceiverType = func!!.getReceiverParameter()?.getType()
++        val parameterString = StringUtil.join(valueParameters,
++                                              {(descriptor: ValueParameterDescriptor?): String ->
++                                                  """" + descriptor!!.getName() +
++                                                  "": "" + DescriptorRenderer.TEXT.renderType(descriptor!!.getType())
++                                              },
++                                              "", "");
++
++        // Step 1: make the parameters types explicit
++        val newParameterList = JetPsiFactory.createParameterList(element.getProject(), ""("" + parameterString + "")"")
++        if (params != null) {
++            params.replace(newParameterList)
++        }
++        else {
++            val openBraceElement = element.getFunctionLiteral().getOpenBraceNode().getPsi()
++            val nextSibling = openBraceElement?.getNextSibling()
++            val whitespaceToAdd = (if (nextSibling is PsiWhiteSpace && nextSibling?.getText()?.contains(""\n"")?: false)
++                nextSibling?.copy()","There's a warning here and on the previous line about a useless `?:`
+",2014-04-09 15:37:15
+794,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import com.intellij.psi.CommonClassNames
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.ElementKind
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++import javax.lang.model.element.VariableElement
++import javax.lang.model.type.NoType
++import javax.lang.model.type.TypeKind
++
++class SymbolBasedClass<T : TypeElement>(element: T,",Looks like generic parameter `T` can de dropped here and `element` could just have the type `TypeElement`,2017-04-25 11:08:53
+792,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import com.intellij.psi.CommonClassNames
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.ElementKind
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++import javax.lang.model.element.VariableElement
++import javax.lang.model.type.NoType
++import javax.lang.model.type.TypeKind
++
++class SymbolBasedClass<T : TypeElement>(element: T,
++                                        javac: JavacWrapper) : SymbolBasedClassifier<TypeElement>(element, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())","There's no point in calling `safeIdentifier` on a non-null string, it's the same as simply `Name.identifier`. Maybe you meant to handle the case of anonymous classes? The docs say an empty string will be returned in that case.",2017-04-25 11:05:28
+795,"@@ -0,0 +1,108 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import com.intellij.psi.CommonClassNames
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.ElementKind
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++import javax.lang.model.element.VariableElement
++import javax.lang.model.type.NoType
++import javax.lang.model.type.TypeKind
++
++class SymbolBasedClass<T : TypeElement>(element: T,
++                                        javac: JavacWrapper) : SymbolBasedClassifier<TypeElement>(element, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())
++
++    override val isAbstract
++        get() = element.isAbstract
++
++    override val isStatic
++        get() = element.isStatic
++
++    override val isFinal
++        get() = element.isFinal
++
++    override val visibility
++        get() = element.getVisibility()
++
++    override val typeParameters
++        get() = element.typeParameters.map { SymbolBasedTypeParameter(it, javac) }
++
++    override val fqName
++        get() = FqName(element.qualifiedName.toString())
++
++    override val supertypes","To be honest, I prefer properties and functions with explicit return type, unless omitting it makes code substantially more readable, which is not the case here, I think (I mean not only this file, but all files added in these commits).",2017-04-25 11:37:42
+965,"@@ -0,0 +1,11 @@
++// !DIAGNOSTICS: -INVISIBLE_MEMBER -INVISIBLE_REFERENCE -UNUSED_PARAMETER
++// !LANGUAGE: +CalledInPlaceEffect
++
++import kotlin.internal.*
++
++inline fun myRun(@CalledInPlace(InvocationCount.EXACTLY_ONCE) block: () -> Unit) = block()
++
++fun throwInLambda(): Int {
++    val x = myRun { throw java.lang.IllegalArgumentException() }
++    return <!TYPE_MISMATCH!>x<!>","Unclear place. First, why `TYPE_MISMATCH`? In this context, `x` should probably have `Nothing` type. Second, `UNREACHABLE_CODE` is expected here. Third, I don't quite understand why it appears after introduction of language features (the last but one commit).",2017-08-15 15:43:47
+233,"@@ -0,0 +1,11 @@
++// WITH_RUNTIME
++// IS_APPLICABLE: FALSE
++import java.util.LinkedList
++
++fun Int.withIndices(): List<Pair<Int, Int>> = LinkedList<Pair<Int, Int>>()
++
++fun foo(s: Int) {
++    for ((index<caret>, a) in s.withIndices()) {
++
++    }
++}","Also please rename this test
+",2014-05-12 13:12:46
+206,"@@ -0,0 +1,110 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++import org.jetbrains.jet.lang.psi.JetCallableReferenceExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++import kotlin.properties.Delegates
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.plugin.intentions.branchedTransformations.extractExpressionIfSingle
++import org.jetbrains.jet.lang.psi.JetThrowExpression
++import org.jetbrains.jet.lang.resolve.calls.model.ResolvedCall
++import org.jetbrains.jet.lang.descriptors.CallableDescriptor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import com.intellij.psi.PsiElement
++import org.jetbrains.jet.lang.resolve.calls.model.ResolvedValueArgument
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetUserType
++
++public class ConvertIfWithThrowToAssertIntention : JetSelfTargetingIntention<JetIfExpression>(
++        ""convert.if.with.throw.to.assert"", javaClass()) {
++
++    private var resolvedCall: ResolvedCall<out CallableDescriptor> by Delegates.notNull()
++    private var param: ResolvedValueArgument by Delegates.notNull()
++
++    override fun isApplicableTo(element: JetIfExpression): Boolean {
++        if (element.getElse() != null) return false
++
++        val thenExpr = element.getThen()?.extractExpressionIfSingle()
++        if (thenExpr !is JetThrowExpression) return false
++
++        val thrownExpr = getSelector(thenExpr.getThrownExpression())
++        if (thrownExpr !is JetCallExpression) return false
++
++        if (thrownExpr.getCalleeExpression()?.getText() != ""AssertionError"") return false
++
++        val context = AnalyzerFacadeWithCache.getContextForElement(thrownExpr)
++        val nullableResolvedCall = context[BindingContext.RESOLVED_CALL, thrownExpr.getCalleeExpression()]
++        if (nullableResolvedCall == null) return false
++        resolvedCall = nullableResolvedCall
++
++        val paramAmount = resolvedCall.getValueArguments().size
++        if (paramAmount != 1) return false
++
++        val paramDescriptor = resolvedCall.getResultingDescriptor().getValueParameters()[0]
++        param = resolvedCall.getValueArguments()[paramDescriptor]!!
++        if (param.toString() == ""null"") return false
++
++        return DescriptorUtils.getFqName(resolvedCall.getResultingDescriptor()).toString() == ""java.lang.AssertionError.<init>""
++    }
++
++    private fun getSelector(element: JetExpression?): JetExpression? {
++        if (element is JetDotQualifiedExpression) {
++            return element.getSelectorExpression()
++        }
++        return element
++    }
++
++    override fun applyTo(element: JetIfExpression, editor: Editor) {
++        val condition = element.getCondition()
++        if (condition == null) return
++
++        val negatedCondition = JetPsiFactory.createExpression(element.getProject(), ""!true"") as JetPrefixExpression
++        negatedCondition.getBaseExpression()!!.replace(condition)
++        condition.replace(negatedCondition)
++
++        val newCondition = element.getCondition() as JetPrefixExpression
++        val simplifier = SimplifyNegatedBinaryExpressionIntention()
++        if (simplifier.isApplicableTo(newCondition)) {
++            simplifier.applyTo(newCondition, editor)
++        }
++
++        val assertText = ""assert(${element.getCondition()?.getText()}, $param)""
++        val assertExpr = JetPsiFactory.createExpression(element.getProject(), assertText)
++
++        val newExpr = element.replace(assertExpr) as JetCallExpression
++        if (isCalResolvedToKotlinAssert(newExpr)) return","ShortenReferences was not working for ""kotlin.assert"" it would always process it back to the full ""kotlin.assert"", i tried debugging it for a couple of days but when i couldn't i figured this method should be just as good, I create the element with the short name ""assert"" and then get the resolved call, if it doesn't resolve to ""kotlin.assert"" i replace it with the dot qualified call
+",2014-04-23 02:33:29
+685,"@@ -0,0 +1,111 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.android.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++import org.jetbrains.android.facet.AndroidFacet
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors.SUPERTYPE_NOT_INITIALIZED
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.quickfix.KotlinQuickFixAction
++import org.jetbrains.kotlin.idea.quickfix.KotlinSingleIntentionActionFactory
++import org.jetbrains.kotlin.idea.util.IdeDescriptorRenderers
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.makeNotNullable
++import org.jetbrains.kotlin.types.typeUtil.supertypes
++
++class KotlinAndroidViewConstructorFix(element: KtSuperTypeEntry) : KotlinQuickFixAction<KtSuperTypeEntry>(element) {
++
++    override fun getText() = ""Add Android View constructors using '@JvmOverloads'""
++    override fun getFamilyName() = text
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (AndroidFacet.getInstance(file) == null) return false
++        return super.isAvailable(project, editor, file)
++    }
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val element = element ?: return
++        val ktClass = element.containingClass() ?: return
++
++        val factory = KtPsiFactory(element)
++
++        val newPrimaryConstructor = factory.createDeclarationByPattern<KtClass>(
++                ""class A constructor(\n $0, $1, $2\n)"",
++                factory.createParameter(""context: android.content.Context""),
++                factory.createParameter(""attrs: android.util.AttributeSet? = null""),
++                factory.createParameter(""defStyleAttr: Int = 0"")
++        ).primaryConstructor ?: return
++
++        val primaryConstructor = ktClass.createPrimaryConstructorIfAbsent().replaced(newPrimaryConstructor)
++        primaryConstructor.valueParameterList?.let { ShortenReferences.DEFAULT.process(it) }
++
++        primaryConstructor.addAnnotation(fqNameAnnotation, whiteSpaceText = "" "")
++
++        element.replace(factory.createSuperTypeCallEntry(element.text + ""(context, attrs, defStyleAttr)""))
++    }
++
++    companion object Factory : KotlinSingleIntentionActionFactory() {
++
++        private val fqNameAnnotation = FqName(""kotlin.jvm.JvmOverloads"")
++
++        private val requiredConstructorParameterTypes =
++                listOf(""android.content.Context"", ""android.util.AttributeSet"", ""kotlin.Int"")
++
++        override fun createAction(diagnostic: Diagnostic): IntentionAction? {
++            val superTypeEntry = SUPERTYPE_NOT_INITIALIZED.cast(diagnostic).psiElement
++
++            val ktClass = superTypeEntry.containingClass() ?: return null
++            if (ktClass.primaryConstructor != null) return null
++
++            val context = superTypeEntry.analyze()
++            val type = superTypeEntry.typeReference?.let { context[BindingContext.TYPE, it] } ?: return null
++
++            if (!type.isAndroidView() && type.supertypes().none { it.isAndroidView() }) return null
++
++            val names = type.constructorParameters() ?: return null
++            if (requiredConstructorParameterTypes !in names) return null
++
++            return KotlinAndroidViewConstructorFix(superTypeEntry)
++        }
++
++        private fun KotlinType.isAndroidView(): Boolean {
++            return constructor.declarationDescriptor?.fqNameUnsafe?.asString() == ""android.view.View""
++        }
++
++        private fun KotlinType.constructorParameters(): List<List<String?>>? {
++            val classDescriptor = constructor.declarationDescriptor as? ClassDescriptor ?: return null
++            return classDescriptor.constructors.map {
++                it.valueParameters.map { IdeDescriptorRenderers.SOURCE_CODE_NOT_NULL_TYPE_APPROXIMATION.renderType(it.type.makeNotNullable()) }
++            }
++        }
++    }","I suggest minor refactoring
+```kotlin
+private fun KotlinType.getFqNameAsString() = constructor.declarationDescriptor?.fqNameUnsafe?.asString()
+
+private fun KotlinType.isAndroidView() = getFqNameAsString() == ""android.view.View""
+
+// and we can avoid IdeDescriptorRenderers
+// ...
+    it.valueParameters.map { it.type.getFqNameAsString() }
+// ...
+}
+```
+",2017-01-25 15:22:48
+93,"@@ -0,0 +1,115 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions.attributeCallReplacements
++
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.JetBundle
++import com.intellij.psi.PsiFile
++import org.jetbrains.jet.lang.psi.psiUtil.getParentByTypesAndPredicate
++import com.intellij.openapi.project.Project
++import com.intellij.codeInsight.intention.impl.BaseIntentionAction
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public abstract class AttributeCallReplacementIntention(val name: String) : BaseIntentionAction() {
++    {
++        setText(getFamilyName())
++    }
++
++    protected class Replacement(val target: JetExpression, val text: String)
++
++    private val elementType = javaClass<JetDotQualifiedExpression>()
++
++    abstract protected fun isApplicableToCall(call: JetCallExpression) : Boolean
++    abstract protected fun makeReplacement(element: JetQualifiedExpression, call: JetCallExpression, receiver: JetExpression) : Replacement
++
++    protected fun getTarget(editor: Editor, file: PsiFile): JetDotQualifiedExpression? {
++        val offset = editor.getCaretModel().getOffset()
++        return file.findElementAt(offset)?.getParentByTypesAndPredicate(false, elementType) {
++            element -> with (element.getSelectorExpression()) {","Is this kosher?
+",2014-01-23 23:44:53
+94,"@@ -0,0 +1,115 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions.attributeCallReplacements
++
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.JetBundle
++import com.intellij.psi.PsiFile
++import org.jetbrains.jet.lang.psi.psiUtil.getParentByTypesAndPredicate
++import com.intellij.openapi.project.Project
++import com.intellij.codeInsight.intention.impl.BaseIntentionAction
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public abstract class AttributeCallReplacementIntention(val name: String) : BaseIntentionAction() {
++    {
++        setText(getFamilyName())
++    }
++
++    protected class Replacement(val target: JetExpression, val text: String)
++
++    private val elementType = javaClass<JetDotQualifiedExpression>()
++
++    abstract protected fun isApplicableToCall(call: JetCallExpression) : Boolean
++    abstract protected fun makeReplacement(element: JetQualifiedExpression, call: JetCallExpression, receiver: JetExpression) : Replacement
++
++    protected fun getTarget(editor: Editor, file: PsiFile): JetDotQualifiedExpression? {
++        val offset = editor.getCaretModel().getOffset()
++        return file.findElementAt(offset)?.getParentByTypesAndPredicate(false, elementType) {
++            element -> with (element.getSelectorExpression()) {
++                when (this) {
++                    is JetCallExpression -> isApplicableToCall(this)
++                    else -> false
++                }
++            }
++        }
++    }
++
++    public override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        return with (getTarget(editor, file)) {
++            when(this) {
++                null -> false
++                else -> {
++                    updateText(this, this.getSelectorExpression() as JetCallExpression, this.getReceiverExpression())
++                    true
++                }
++            }
++        }
++    }
++
++    // Override this to manually specify the intention text.
++    protected open fun updateText(element: JetQualifiedExpression, call: JetCallExpression, receiver: JetExpression) {
++        val replacement = makeReplacement(element, call, receiver)
++        val before = replacement.target.getText()
++        val after = replacement.text
++        if (before != null)
++            setText(before, after)
++    }
++
++    protected fun setText(before: String, after: String) {
++        setText(JetBundle.message(""replace.attribute.call"", before, after))
++    }
++
++
++    public override fun getFamilyName() : String {
++        return JetBundle.message(""replace.attribute.call.family"", name)
++    }
++
++    public override fun invoke(project: Project, editor: Editor, file: PsiFile): Unit {
++        val target = getTarget(editor, file)
++        assert(target != null, ""Intention is not applicable"")
++        target!! // It matches","There has to be a better way to do this.
+",2014-01-23 23:46:15
+727,"@@ -0,0 +1,117 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.jvm.compiler
++
++import com.intellij.openapi.Disposable
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.cli.jvm.compiler.EnvironmentConfigFiles
++import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
++import org.jetbrains.kotlin.config.JVMConfigurationKeys
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.renderer.*
++import org.jetbrains.kotlin.resolve.lazy.JvmResolveUtil
++import org.jetbrains.kotlin.test.ConfigurationKind
++import org.jetbrains.kotlin.test.KotlinTestUtils
++import org.jetbrains.kotlin.test.TestCaseWithTmpdir
++import org.jetbrains.kotlin.test.TestJdkKind
++import org.junit.Assert
++
++import java.io.File
++import java.io.IOException
++import java.lang.annotation.Retention
++
++import org.jetbrains.kotlin.test.KotlinTestUtils.*
++import org.jetbrains.kotlin.test.util.RecursiveDescriptorComparator.validateAndCompareDescriptorWithFile
++
++abstract class AbstractCompileJavaAgainstKotlinTest : TestCaseWithTmpdir() {
++
++    @Throws(IOException::class)
++    protected fun doTest(ktFilePath: String) {
++        Assert.assertTrue(ktFilePath.endsWith("".kt""))
++        val ktFile = File(ktFilePath)
++        val javaFile = File(ktFilePath.replaceFirst(""\\.kt$"".toRegex(), "".java""))
++
++        val javaErrorFile = File(ktFilePath.replaceFirst(""\\.kt$"".toRegex(), "".javaerr.txt""))
++
++        val useJavac = true","I'd make this a class property, set it into `false` for old tests and `true` for new tests.",2017-04-05 15:31:36
+731,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()",Why?,2017-04-05 15:47:11
+732,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }",What do you want to find in the empty list (see above)?,2017-04-05 15:47:30
+730,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract","Is it true for interfaces? They are abstract without a modifier. I'm not sure should we return `abstract = true` for them, but probably yes.",2017-04-05 15:46:09
+741,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic",Probably false if class is nested in interface (see JCField),2017-04-05 16:03:31
+740,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = tree.modifiers.visibility",Probably false if class is nested in interface (see JCField),2017-04-05 16:02:55
+736,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { JCTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes
++        get() = arrayListOf<JavaClassifierType>().apply {
++            fun JCTree.mapToJavaClassifierType() = when {
++                this is JCTree.JCExpression -> JCClassifierType(this, TreePath(treePath, this), javac)",Don't quite understand this branch. Do you have some example?,2017-04-05 15:53:36
+733,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { JCTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes
++        get() = arrayListOf<JavaClassifierType>().apply {
++            fun JCTree.mapToJavaClassifierType() = when {
++                this is JCTree.JCExpression -> JCClassifierType(this, TreePath(treePath, this), javac)
++                this is JCTree.JCTypeApply -> JCClassifierTypeWithTypeArgument(this, TreePath(treePath, this), javac)
++                else -> null
++            }
++
++            tree.extending?.mapToJavaClassifierType()?.let(this::add)
++            tree.implementing?.map { it.mapToJavaClassifierType() }?.filterNotNull()?.let(this::addAll)
++
++            if (find { it.canonicalText == CommonClassNames.JAVA_LANG_OBJECT } == null) {
++                javac.JAVA_LANG_OBJECT?.let { add(JavacClassifierType(it.element.asType(), javac)) }","Again, do we need it if super class is given explicitly?",2017-04-05 15:48:23
+734,"@@ -0,0 +1,118 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: Javac) : JCClassifier<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { JCTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes
++        get() = arrayListOf<JavaClassifierType>().apply {
++            fun JCTree.mapToJavaClassifierType() = when {
++                this is JCTree.JCExpression -> JCClassifierType(this, TreePath(treePath, this), javac)
++                this is JCTree.JCTypeApply -> JCClassifierTypeWithTypeArgument(this, TreePath(treePath, this), javac)
++                else -> null
++            }
++
++            tree.extending?.mapToJavaClassifierType()?.let(this::add)
++            tree.implementing?.map { it.mapToJavaClassifierType() }?.filterNotNull()?.let(this::addAll)
++
++            if (find { it.canonicalText == CommonClassNames.JAVA_LANG_OBJECT } == null) {
++                javac.JAVA_LANG_OBJECT?.let { add(JavacClassifierType(it.element.asType(), javac)) }
++            }
++        }
++
++    override val innerClasses
++        get() = tree.members
++                .filterIsInstance(JCTree.JCClassDecl::class.java)
++                .map { JCClass(it, TreePath(treePath, it), javac) }
++
++    override val outerClass
++        get() = (treePath.parentPath.leaf as? JCTree.JCClassDecl)?.let { JCClass(it, treePath.parentPath, javac) }
++
++    override val isInterface by lazy { tree.modifiers.flags and Flags.INTERFACE.toLong() != 0L }","Here you're using `by lazy` instead of `get`. Why here, and why just here?",2017-04-05 15:49:22
+764,"@@ -0,0 +1,12 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<project version=""4"">
++  <component name=""SaveActionSettings"">
++    <option name=""actions"">
++      <set>
++        <option value=""organizeImports"" />
++        <option value=""reformat"" />
++        <option value=""reformatChangedCode"" />
++      </set>
++    </option>
++  </component>
++</project>",Not needed,2017-04-18 06:50:54
+541,"@@ -0,0 +1,12 @@
++class A {
++    val a = """"
++    val b = """"
++}
++
++fun box(): String {
++    val a = A::a.name
++    if (a != ""a"") return ""Fail $a""
++    val b = A::`b`.name
++    if (b != ""b"") return ""Fail $b""
++    return ""OK""","This test doesn't check that no classes were generated for the property reference. I don't think it's possible in a `box` test, please try a bytecode listing test instead (`compiler/testData/codegen/bytecodeListing`).
+
+Also please test constructors and functions
+",2016-04-22 19:46:08
+185,"@@ -0,0 +1,12 @@
++public class TestingUse {
++    fun test6(funcLitfunc: ((x: Int) -> Int) -> Boolean, innerfunc: (y: Int) -> Int): Unit {
++        val result = funcLitfunc(innerfunc)
++        var num = 0
++        if (result == true) num = 1
++        else num = 2","This is a nice test case, but is this code really needed to test your intention? I think it's just confusing...
+",2014-04-16 19:00:48
+876,"@@ -0,0 +1,120 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.unwrapBlockOrParenthesis
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.bindingContextUtil.isUsedAsExpression
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++import org.jetbrains.kotlin.resolve.constants.evaluate.ConstantExpressionEvaluator
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++
++class ConstantConditionIfInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitIfExpression(expression: KtIfExpression) {
++                super.visitIfExpression(expression)
++
++                val condition = expression.condition ?: return
++
++                val context = condition.analyze(BodyResolveMode.PARTIAL)
++                val constantValue = condition.constantBooleanValue(context) ?: return
++
++                val fixes = mutableListOf<LocalQuickFix>()
++
++                if (expression.branch(constantValue) != null) {
++                    fixes += SimplifyFix(constantValue, expression.isUsedAsExpression(context))
++                }
++
++                if (!constantValue && expression.`else` == null) {
++                    fixes += RemoveFix()
++                }
++
++                holder.registerProblem(expression, ""Condition of 'if' expression is constant"", *fixes.toTypedArray())
++            }
++        }
++    }
++
++    private class SimplifyFix(
++            private val conditionValue: Boolean,
++            private val isUsedAsExpression: Boolean
++    ) : LocalQuickFix {
++        override fun getFamilyName() = ""Simplify expression""
++
++        override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
++            val ifExpression = descriptor.psiElement as? KtIfExpression ?: return
++            val caretModel = ifExpression.findExistingEditor()?.caretModel
++
++            val branch = ifExpression.branch(conditionValue)?.unwrapBlockOrParenthesis() ?: return
++
++            val lastExpression =
++                    if (branch !is KtBlockExpression) {",Probably with `when` it will be more readable,2017-06-29 12:51:34
+175,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false","Please don't store any information in mutable `var`s inside your intention: it might cause problems with concurrency. E.g. see what problems Gavin encountered in #411
+",2014-04-16 16:49:58
+176,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {","This can be simplified to `paramsTextRange != null && caretLocation in paramsTextRange` or `paramsTextRange?.contains(caretLocation) ?: false`, whichever you like the most
+",2014-04-16 17:36:06
+181,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false","Please convert this to `&&` by DeMorgan, it'll be more readable that way
+",2014-04-16 18:25:42
+178,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        hasImplicitReturnType = !element.hasDeclaredReturnType()
++        hasImplicitReceiverType = element.getFunctionLiteral().getReceiverTypeRef() == null
++        if (hasImplicitReturnType && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.any { it.getTypeReference() == null } || params.isEmpty()) return true","This is rather minor, but you should always strive to do simple checks first and complex checks later. It increases both readability and performance. Here `params.isEmpty()` is obviously very cheap compared to the other condition which involves looping over a collection
+",2014-04-16 17:50:33
+177,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        hasImplicitReturnType = !element.hasDeclaredReturnType()
++        hasImplicitReceiverType = element.getFunctionLiteral().getReceiverTypeRef() == null
++        if (hasImplicitReturnType && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.any { it.getTypeReference() == null } || params.isEmpty()) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, functionLiteral]!!
++
++        // Step 1: make the parameters types explicit
++        val valueParameters = func.getValueParameters()
++        val parameterString = valueParameters.map({(descriptor: ValueParameterDescriptor?): String ->","Type of `descriptor` can be a non-null `ValueParameterDescriptor` here, because Kotlin sees Java generic types with non-null type arguments by default, so `valueParameters` is actually `List<ValueParameterDescriptor>`, not `List<ValueParameterDescriptor?>`
+",2014-04-16 17:48:39
+179,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        hasImplicitReturnType = !element.hasDeclaredReturnType()
++        hasImplicitReceiverType = element.getFunctionLiteral().getReceiverTypeRef() == null
++        if (hasImplicitReturnType && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.any { it.getTypeReference() == null } || params.isEmpty()) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, functionLiteral]!!
++
++        // Step 1: make the parameters types explicit
++        val valueParameters = func.getValueParameters()
++        val parameterString = valueParameters.map({(descriptor: ValueParameterDescriptor?): String ->
++                                                      """" + descriptor!!.getName() +
++                                                      "": "" + DescriptorRenderer.TEXT.renderType(descriptor.getType())
++                                                  }).makeString("", "", ""("", "")"")
++        val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++        val params = functionLiteral.getValueParameterList()","I think `params` should have been named `oldParameterList`, to oppose `newParameterList`
+",2014-04-16 17:52:19
+180,"@@ -0,0 +1,121 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++    private var hasImplicitReturnType = false
++    private var hasImplicitReceiverType = false
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        hasImplicitReturnType = !element.hasDeclaredReturnType()
++        hasImplicitReceiverType = element.getFunctionLiteral().getReceiverTypeRef() == null
++        if (hasImplicitReturnType && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.any { it.getTypeReference() == null } || params.isEmpty()) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, functionLiteral]!!
++
++        // Step 1: make the parameters types explicit
++        val valueParameters = func.getValueParameters()
++        val parameterString = valueParameters.map({(descriptor: ValueParameterDescriptor?): String ->
++                                                      """" + descriptor!!.getName() +
++                                                      "": "" + DescriptorRenderer.TEXT.renderType(descriptor.getType())
++                                                  }).makeString("", "", ""("", "")"")
++        val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++        val params = functionLiteral.getValueParameterList()
++        if (params != null) {
++            params.replace(newParameterList)
++        }
++        else {
++            val openBraceElement = functionLiteral.getOpenBraceNode().getPsi()
++            val nextSibling = openBraceElement?.getNextSibling()
++            val whitespaceToAdd = (if (nextSibling is PsiWhiteSpace && nextSibling?.getText()?.contains(""\n"")?: false)","There's a warning on `?.` here :) If you're not sure whether or not your code has warnings, check the small box in IntelliJ's top-right corner, it should be green
+",2014-04-16 17:53:51
+201,"@@ -0,0 +1,122 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++            caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        if (hasImplicitReturnType(element) && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType(element) && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.isEmpty() || params.any { it.getTypeReference() == null }) return true
++
++        return false","Please collapse these two lines. `if (condition) return true; return false` can be simplified to `return condition`
+",2014-04-22 22:33:06
+200,"@@ -0,0 +1,122 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++            caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        if (hasImplicitReturnType(element) && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType(element) && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.isEmpty() || params.any { it.getTypeReference() == null }) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, functionLiteral]!!
++
++        // Step 1: make the parameters types explicit
++        val valueParameters = func.getValueParameters()
++        val parameterString = valueParameters.map({(descriptor: ValueParameterDescriptor): String ->","Ditto: I don't think types are needed here
+",2014-04-22 22:31:08
+199,"@@ -0,0 +1,122 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++            caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        if (hasImplicitReturnType(element) && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType(element) && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.isEmpty() || params.any { it.getTypeReference() == null }) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, functionLiteral]!!
++
++        // Step 1: make the parameters types explicit
++        val valueParameters = func.getValueParameters()
++        val parameterString = valueParameters.map({(descriptor: ValueParameterDescriptor): String ->
++                                                      """" + descriptor.getName() +
++                                                      "": "" + DescriptorRenderer.TEXT.renderType(descriptor.getType())
++                                                  }).makeString("", "", ""("", "")"")
++        val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++        val oldParameterList = functionLiteral.getValueParameterList()
++        if (oldParameterList != null) {
++            oldParameterList.replace(newParameterList)
++        }
++        else {
++            val openBraceElement = functionLiteral.getOpenBraceNode().getPsi()
++            val nextSibling = openBraceElement?.getNextSibling()
++            val whitespaceToAdd = (if (nextSibling is PsiWhiteSpace && nextSibling.getText()?.contains(""\n"")?: false)","I couldn't find tests on this code, am I missing something? It looks kind of complex
+",2014-04-22 22:30:41
+197,"@@ -0,0 +1,122 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.descriptors.ValueParameterDescriptor
++import org.jetbrains.jet.renderer.DescriptorRenderer
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++
++public class MakeTypeExplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.explicit.in.lambda"", javaClass()) {
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++            caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, element.getFunctionLiteral()]
++        if (func == null || ErrorUtils.containsErrorType(func)) return false
++
++        if (hasImplicitReturnType(element) && func.getReturnType() != null) return true
++        if (hasImplicitReceiverType(element) && func.getReceiverParameter()?.getType() != null) return true
++
++        val params = element.getValueParameters()
++        if (params.isEmpty() || params.any { it.getTypeReference() == null }) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val func = context[BindingContext.FUNCTION, functionLiteral]!!
++
++        // Step 1: make the parameters types explicit
++        val valueParameters = func.getValueParameters()
++        val parameterString = valueParameters.map({(descriptor: ValueParameterDescriptor): String ->
++                                                      """" + descriptor.getName() +
++                                                      "": "" + DescriptorRenderer.TEXT.renderType(descriptor.getType())
++                                                  }).makeString("", "", ""("", "")"")
++        val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++        val oldParameterList = functionLiteral.getValueParameterList()
++        if (oldParameterList != null) {
++            oldParameterList.replace(newParameterList)
++        }
++        else {
++            val openBraceElement = functionLiteral.getOpenBraceNode().getPsi()
++            val nextSibling = openBraceElement?.getNextSibling()
++            val whitespaceToAdd = (if (nextSibling is PsiWhiteSpace && nextSibling.getText()?.contains(""\n"")?: false)
++                nextSibling.copy()
++            else
++                null)
++            val whitespaceAndArrow = JetPsiFactory.createWhitespaceAndArrow(element.getProject())
++            functionLiteral.addRangeAfter(whitespaceAndArrow.first, whitespaceAndArrow.second, openBraceElement)
++            functionLiteral.addAfter(newParameterList, openBraceElement)
++            if (whitespaceToAdd != null) {
++                functionLiteral.addAfter(whitespaceToAdd, openBraceElement)
++            }
++        }
++        ShortenReferences.process(element.getValueParameters())
++
++
++        // Step 2: make the return type explicit
++        val expectedReturnType = func.getReturnType()
++        if (hasImplicitReturnType(element) && expectedReturnType != null) {
++            val paramList = functionLiteral.getValueParameterList()
++            val returnTypeColon = JetPsiFactory.createColon(element.getProject())
++            val returnTypeExpr = JetPsiFactory.createType(element.getProject(), DescriptorRenderer.TEXT.renderType(expectedReturnType))
++            ShortenReferences.process(returnTypeExpr)
++            functionLiteral.addAfter(returnTypeExpr, paramList)
++            functionLiteral.addAfter(returnTypeColon, paramList)
++        }
++
++        // Step 3: make the receiver type explicit
++        val expectedReceiverType = func.getReceiverParameter()?.getType()
++        if (hasImplicitReceiverType(element) && expectedReceiverType != null) {
++            val receiverTypeString = DescriptorRenderer.TEXT.renderType(expectedReceiverType)
++            val paramListString = functionLiteral.getValueParameterList()?.getText()
++            val paramListWithReceiver = JetPsiFactory.createExpression(element.getProject(), receiverTypeString + ""."" + paramListString)
++            ShortenReferences.process(paramListWithReceiver)
++            functionLiteral.getValueParameterList()?.replace(paramListWithReceiver)
++        }
++    }
++
++    fun hasImplicitReturnType(element: JetFunctionLiteralExpression): Boolean {
++        return !element.hasDeclaredReturnType()
++    }
++
++    fun hasImplicitReceiverType(element: JetFunctionLiteralExpression): Boolean {
++        return element.getFunctionLiteral().getReceiverTypeRef() == null
++    }","The last 2 functions in this file should be `private`
+",2014-04-22 22:25:42
+656,"@@ -0,0 +1,124 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.evaluatesTo
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++
++class ConvertTwoComparisonsToRangeCheckIntention : SelfTargetingOffsetIndependentIntention<KtBinaryExpression>(KtBinaryExpression::class.java, ""Convert to range check"") {
++
++    private data class RangeExpressionData(val value: String, val min: String, val max: String)
++
++    override fun isApplicableTo(condition: KtBinaryExpression) = generateRangeExpressionData(condition) != null
++
++    override fun applyTo(condition: KtBinaryExpression, editor: Editor?) {
++        val rangeData = generateRangeExpressionData(condition) ?: return
++        condition.replace(KtPsiFactory(condition).createExpressionByPattern(""$0 in $1..$2"", rangeData.value, rangeData.min, rangeData.max))
++    }
++
++    private fun generateRangeExpressionData(condition: KtBinaryExpression): RangeExpressionData? {
++        if (condition.operationToken != KtTokens.ANDAND) return null
++        val firstCondition = condition.left as? KtBinaryExpression ?: return null
++        val secondCondition = condition.right as? KtBinaryExpression ?: return null
++        val firstOpToken = firstCondition.operationToken
++        val secondOpToken = secondCondition.operationToken
++        val firstLeft = firstCondition.left ?: return null
++        val firstRight = firstCondition.right ?: return null
++        val secondLeft = secondCondition.left ?: return null
++        val secondRight = secondCondition.right ?: return null
++
++        return when (firstOpToken) {","This `when` is written in a very straight-forward way. Please, think a bit how to make it shorter. All branches are very like one another.",2016-12-13 10:28:53
+658,"@@ -0,0 +1,124 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.evaluatesTo
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++
++class ConvertTwoComparisonsToRangeCheckIntention : SelfTargetingOffsetIndependentIntention<KtBinaryExpression>(KtBinaryExpression::class.java, ""Convert to range check"") {
++
++    private data class RangeExpressionData(val value: String, val min: String, val max: String)
++
++    override fun isApplicableTo(condition: KtBinaryExpression) = generateRangeExpressionData(condition) != null
++
++    override fun applyTo(condition: KtBinaryExpression, editor: Editor?) {
++        val rangeData = generateRangeExpressionData(condition) ?: return
++        condition.replace(KtPsiFactory(condition).createExpressionByPattern(""$0 in $1..$2"", rangeData.value, rangeData.min, rangeData.max))
++    }
++
++    private fun generateRangeExpressionData(condition: KtBinaryExpression): RangeExpressionData? {
++        if (condition.operationToken != KtTokens.ANDAND) return null
++        val firstCondition = condition.left as? KtBinaryExpression ?: return null
++        val secondCondition = condition.right as? KtBinaryExpression ?: return null
++        val firstOpToken = firstCondition.operationToken
++        val secondOpToken = secondCondition.operationToken
++        val firstLeft = firstCondition.left ?: return null
++        val firstRight = firstCondition.right ?: return null
++        val secondLeft = secondCondition.left ?: return null
++        val secondRight = secondCondition.right ?: return null
++
++        return when (firstOpToken) {
++            KtTokens.GTEQ, KtTokens.GT -> {
++                when (secondOpToken) {
++                    KtTokens.GTEQ, KtTokens.GT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstLeft, firstRight, secondLeft, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstRight, secondRight, firstLeft, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        else -> null
++                    }
++                    KtTokens.LTEQ, KtTokens.LT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstLeft, firstRight, secondRight, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstRight, secondLeft, firstLeft, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        else -> null
++                    }
++                    else -> null
++                }
++            }
++            KtTokens.LTEQ, KtTokens.LT -> {
++                when (secondOpToken) {
++                    KtTokens.GTEQ, KtTokens.GT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstLeft, secondRight, firstRight, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstRight, firstLeft, secondLeft, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        else -> null
++                    }
++                    KtTokens.LTEQ, KtTokens.LT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstLeft, secondLeft, firstRight, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstRight, firstLeft, secondRight, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        else -> null
++                    }
++                    else -> null
++                }
++            }
++            else -> null
++        }
++    }
++
++    private fun generateRangeExpressionData(value: KtExpression, min: KtExpression, max: KtExpression, minDecrementByOne: Boolean = false, maxDecrementByOne: Boolean = false): RangeExpressionData? {
++        if (minDecrementByOne || maxDecrementByOne) {
++            val type = value.getType(value.analyze()) ?: return null
++            if (!KotlinBuiltIns.isInt(type) && !KotlinBuiltIns.isLong(type) && !KotlinBuiltIns.isShort(type) && !KotlinBuiltIns.isChar(type)) return null
++        }
++
++        val minText = if (minDecrementByOne) min.getDecrementByOneString() else min.text
++        val maxText = if (maxDecrementByOne) max.getDecrementByOneString() else max.text
++        return RangeExpressionData(value.text, minText ?: return null, maxText ?: return null)
++    }
++
++    private fun KtExpression.getDecrementByOneString(): String? {
++        val type = getType(analyze()) ?: return null
++
++        when (this) {
++            is KtConstantExpression -> {
++                val number: Number = when {
++                    KotlinBuiltIns.isInt(type) -> text.toInt() - 1
++                    KotlinBuiltIns.isLong(type) -> {
++                        val text = text
++                        val longText = if (text.endsWith(""l"") || text.endsWith(""L"")) text.substring(0, text.length - 1) else text
++                        longText.toLong() - 1
++                    }
++                    KotlinBuiltIns.isShort(type) -> java.lang.Short.parseShort(text) - 1
++                    KotlinBuiltIns.isChar(type) -> text[0].toInt() - 1","I think it is better to replace character with character, either explicit e.g. `'z' - 1` or implicit `'y'`",2016-12-13 10:34:59
+657,"@@ -0,0 +1,124 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.evaluatesTo
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++
++class ConvertTwoComparisonsToRangeCheckIntention : SelfTargetingOffsetIndependentIntention<KtBinaryExpression>(KtBinaryExpression::class.java, ""Convert to range check"") {
++
++    private data class RangeExpressionData(val value: String, val min: String, val max: String)
++
++    override fun isApplicableTo(condition: KtBinaryExpression) = generateRangeExpressionData(condition) != null
++
++    override fun applyTo(condition: KtBinaryExpression, editor: Editor?) {
++        val rangeData = generateRangeExpressionData(condition) ?: return
++        condition.replace(KtPsiFactory(condition).createExpressionByPattern(""$0 in $1..$2"", rangeData.value, rangeData.min, rangeData.max))
++    }
++
++    private fun generateRangeExpressionData(condition: KtBinaryExpression): RangeExpressionData? {
++        if (condition.operationToken != KtTokens.ANDAND) return null
++        val firstCondition = condition.left as? KtBinaryExpression ?: return null
++        val secondCondition = condition.right as? KtBinaryExpression ?: return null
++        val firstOpToken = firstCondition.operationToken
++        val secondOpToken = secondCondition.operationToken
++        val firstLeft = firstCondition.left ?: return null
++        val firstRight = firstCondition.right ?: return null
++        val secondLeft = secondCondition.left ?: return null
++        val secondRight = secondCondition.right ?: return null
++
++        return when (firstOpToken) {
++            KtTokens.GTEQ, KtTokens.GT -> {
++                when (secondOpToken) {
++                    KtTokens.GTEQ, KtTokens.GT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstLeft, firstRight, secondLeft, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstRight, secondRight, firstLeft, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        else -> null
++                    }
++                    KtTokens.LTEQ, KtTokens.LT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstLeft, firstRight, secondRight, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstRight, secondLeft, firstLeft, minDecrementByOne = firstOpToken == KtTokens.GT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        else -> null
++                    }
++                    else -> null
++                }
++            }
++            KtTokens.LTEQ, KtTokens.LT -> {
++                when (secondOpToken) {
++                    KtTokens.GTEQ, KtTokens.GT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstLeft, secondRight, firstRight, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstRight, firstLeft, secondLeft, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.GT)
++                        else -> null
++                    }
++                    KtTokens.LTEQ, KtTokens.LT -> when {
++                        firstLeft !is KtConstantExpression && firstLeft.evaluatesTo(secondRight) ->
++                            generateRangeExpressionData(firstLeft, secondLeft, firstRight, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        firstRight !is KtConstantExpression && firstRight.evaluatesTo(secondLeft) ->
++                            generateRangeExpressionData(firstRight, firstLeft, secondRight, minDecrementByOne = firstOpToken == KtTokens.LT, maxDecrementByOne = secondOpToken == KtTokens.LT)
++                        else -> null
++                    }
++                    else -> null
++                }
++            }
++            else -> null
++        }
++    }
++
++    private fun generateRangeExpressionData(value: KtExpression, min: KtExpression, max: KtExpression, minDecrementByOne: Boolean = false, maxDecrementByOne: Boolean = false): RangeExpressionData? {
++        if (minDecrementByOne || maxDecrementByOne) {
++            val type = value.getType(value.analyze()) ?: return null
++            if (!KotlinBuiltIns.isInt(type) && !KotlinBuiltIns.isLong(type) && !KotlinBuiltIns.isShort(type) && !KotlinBuiltIns.isChar(type)) return null
++        }
++
++        val minText = if (minDecrementByOne) min.getDecrementByOneString() else min.text
++        val maxText = if (maxDecrementByOne) max.getDecrementByOneString() else max.text
++        return RangeExpressionData(value.text, minText ?: return null, maxText ?: return null)
++    }
++
++    private fun KtExpression.getDecrementByOneString(): String? {
++        val type = getType(analyze()) ?: return null
++
++        when (this) {
++            is KtConstantExpression -> {
++                val number: Number = when {
++                    KotlinBuiltIns.isInt(type) -> text.toInt() - 1
++                    KotlinBuiltIns.isLong(type) -> {
++                        val text = text
++                        val longText = if (text.endsWith(""l"") || text.endsWith(""L"")) text.substring(0, text.length - 1) else text
++                        longText.toLong() - 1
++                    }
++                    KotlinBuiltIns.isShort(type) -> java.lang.Short.parseShort(text) - 1
++                    KotlinBuiltIns.isChar(type) -> text[0].toInt() - 1
++                    else -> return null
++                }
++                return number.toString()
++            }
++            else -> return ""($text - 1)""","This is very controversial. What if expression is a `String`, for example?",2016-12-13 10:33:10
+757,"@@ -0,0 +1,124 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: JavacWrapper) : JCElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { JCAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic",What about interface member classes? (they're always static as I know),2017-04-11 10:22:16
+758,"@@ -0,0 +1,124 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.intellij.psi.CommonClassNames
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.JavacClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class JCClass<out T : JCTree.JCClassDecl>(tree: T,
++                                          treePath: TreePath,
++                                          javac: JavacWrapper) : JCElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { JCAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = tree.modifiers.visibility",What about interface member classes? (they're always public as I know),2017-04-11 10:22:49
+680,"@@ -0,0 +1,126 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.android.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.*
++import com.intellij.psi.util.PsiTypesUtil
++import org.jetbrains.android.facet.AndroidFacet
++import org.jetbrains.kotlin.asJava.toLightClass
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors.SUPERTYPE_NOT_INITIALIZED
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.quickfix.KotlinQuickFixAction
++import org.jetbrains.kotlin.idea.quickfix.KotlinSingleIntentionActionFactory
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.supertypes
++
++class KotlinAndroidViewConstructorFix(element: KtSuperTypeEntry) : KotlinQuickFixAction<KtSuperTypeEntry>(element) {
++
++    override fun getText() = ""Add Android View constructors using '@JvmOverloads'""
++    override fun getFamilyName() = text
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (AndroidFacet.getInstance(file) == null) return false
++        return super.isAvailable(project, editor, file)
++    }
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val element = element ?: return
++        val ktClass = element.containingClass() ?: return
++
++        val factory = KtPsiFactory(element)
++
++        val newPrimaryConstructor = factory.createDeclarationByPattern<KtClass>(
++                ""class A constructor(\n $0, $1, $2\n)"",
++                factory.createParameter(""context: android.content.Context""),
++                factory.createParameter(""attrs: android.util.AttributeSet? = null""),
++                factory.createParameter(""defStyleAttr: Int = 0"")
++        ).primaryConstructor!!",i think `?: return` will be better,2017-01-25 12:41:42
+681,"@@ -0,0 +1,126 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.android.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.*
++import com.intellij.psi.util.PsiTypesUtil
++import org.jetbrains.android.facet.AndroidFacet
++import org.jetbrains.kotlin.asJava.toLightClass
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors.SUPERTYPE_NOT_INITIALIZED
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.quickfix.KotlinQuickFixAction
++import org.jetbrains.kotlin.idea.quickfix.KotlinSingleIntentionActionFactory
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.supertypes
++
++class KotlinAndroidViewConstructorFix(element: KtSuperTypeEntry) : KotlinQuickFixAction<KtSuperTypeEntry>(element) {
++
++    override fun getText() = ""Add Android View constructors using '@JvmOverloads'""
++    override fun getFamilyName() = text
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (AndroidFacet.getInstance(file) == null) return false
++        return super.isAvailable(project, editor, file)
++    }
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val element = element ?: return
++        val ktClass = element.containingClass() ?: return
++
++        val factory = KtPsiFactory(element)
++
++        val newPrimaryConstructor = factory.createDeclarationByPattern<KtClass>(
++                ""class A constructor(\n $0, $1, $2\n)"",
++                factory.createParameter(""context: android.content.Context""),
++                factory.createParameter(""attrs: android.util.AttributeSet? = null""),
++                factory.createParameter(""defStyleAttr: Int = 0"")
++        ).primaryConstructor!!
++
++        val primaryConstructor = ktClass.createPrimaryConstructorIfAbsent().replaced(newPrimaryConstructor)
++        ShortenReferences.DEFAULT.process(primaryConstructor.valueParameterList!!)",`primaryConstructor.valueParameterList?.apply { ShortenReferences.DEFAULT.process(this) }`,2017-01-25 12:42:55
+682,"@@ -0,0 +1,126 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.android.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.*
++import com.intellij.psi.util.PsiTypesUtil
++import org.jetbrains.android.facet.AndroidFacet
++import org.jetbrains.kotlin.asJava.toLightClass
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors.SUPERTYPE_NOT_INITIALIZED
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.quickfix.KotlinQuickFixAction
++import org.jetbrains.kotlin.idea.quickfix.KotlinSingleIntentionActionFactory
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.supertypes
++
++class KotlinAndroidViewConstructorFix(element: KtSuperTypeEntry) : KotlinQuickFixAction<KtSuperTypeEntry>(element) {
++
++    override fun getText() = ""Add Android View constructors using '@JvmOverloads'""
++    override fun getFamilyName() = text
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (AndroidFacet.getInstance(file) == null) return false
++        return super.isAvailable(project, editor, file)
++    }
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val element = element ?: return
++        val ktClass = element.containingClass() ?: return
++
++        val factory = KtPsiFactory(element)
++
++        val newPrimaryConstructor = factory.createDeclarationByPattern<KtClass>(
++                ""class A constructor(\n $0, $1, $2\n)"",
++                factory.createParameter(""context: android.content.Context""),
++                factory.createParameter(""attrs: android.util.AttributeSet? = null""),
++                factory.createParameter(""defStyleAttr: Int = 0"")
++        ).primaryConstructor!!
++
++        val primaryConstructor = ktClass.createPrimaryConstructorIfAbsent().replaced(newPrimaryConstructor)
++        ShortenReferences.DEFAULT.process(primaryConstructor.valueParameterList!!)
++
++        primaryConstructor.addAnnotation(fqNameAnnotation, whiteSpaceText = "" "")
++
++        element.replace(factory.createSuperTypeCallEntry(element.text + ""(context, attrs, defStyleAttr)""))
++    }
++
++    companion object Factory : KotlinSingleIntentionActionFactory() {
++
++        private val fqNameAnnotation = FqName(""kotlin.jvm.JvmOverloads"")
++
++        private val requireConstructorParameterTypes = listOf(","I think we may check only for a presence of the third one `""android.content.Context"", ""android.util.AttributeSet"", ""int""`, since we are using only it, if I understood correctly",2017-01-25 12:45:15
+683,"@@ -0,0 +1,126 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.android.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.*
++import com.intellij.psi.util.PsiTypesUtil
++import org.jetbrains.android.facet.AndroidFacet
++import org.jetbrains.kotlin.asJava.toLightClass
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors.SUPERTYPE_NOT_INITIALIZED
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.quickfix.KotlinQuickFixAction
++import org.jetbrains.kotlin.idea.quickfix.KotlinSingleIntentionActionFactory
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.supertypes
++
++class KotlinAndroidViewConstructorFix(element: KtSuperTypeEntry) : KotlinQuickFixAction<KtSuperTypeEntry>(element) {
++
++    override fun getText() = ""Add Android View constructors using '@JvmOverloads'""
++    override fun getFamilyName() = text
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (AndroidFacet.getInstance(file) == null) return false
++        return super.isAvailable(project, editor, file)
++    }
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val element = element ?: return
++        val ktClass = element.containingClass() ?: return
++
++        val factory = KtPsiFactory(element)
++
++        val newPrimaryConstructor = factory.createDeclarationByPattern<KtClass>(
++                ""class A constructor(\n $0, $1, $2\n)"",
++                factory.createParameter(""context: android.content.Context""),
++                factory.createParameter(""attrs: android.util.AttributeSet? = null""),
++                factory.createParameter(""defStyleAttr: Int = 0"")
++        ).primaryConstructor!!
++
++        val primaryConstructor = ktClass.createPrimaryConstructorIfAbsent().replaced(newPrimaryConstructor)
++        ShortenReferences.DEFAULT.process(primaryConstructor.valueParameterList!!)
++
++        primaryConstructor.addAnnotation(fqNameAnnotation, whiteSpaceText = "" "")
++
++        element.replace(factory.createSuperTypeCallEntry(element.text + ""(context, attrs, defStyleAttr)""))
++    }
++
++    companion object Factory : KotlinSingleIntentionActionFactory() {
++
++        private val fqNameAnnotation = FqName(""kotlin.jvm.JvmOverloads"")
++
++        private val requireConstructorParameterTypes = listOf(
++                listOf(""android.content.Context""),
++                listOf(""android.content.Context"", ""android.util.AttributeSet""),
++                listOf(""android.content.Context"", ""android.util.AttributeSet"", ""int"")
++        )
++
++        override fun createAction(diagnostic: Diagnostic): IntentionAction? {
++            val superTypeEntry = SUPERTYPE_NOT_INITIALIZED.cast(diagnostic).psiElement
++
++            val ktClass = superTypeEntry.containingClass() ?: return null
++            if (ktClass.primaryConstructor != null) return null
++
++            val context = superTypeEntry.analyze()
++            val type = superTypeEntry.typeReference?.let { context[BindingContext.TYPE, it] } ?: return null
++
++            if (!type.isAndroidView() && type.supertypes().none { it.isAndroidView() }) return null
++
++            var declaration = type.getDeclaration()
++
++            if (declaration is KtClass) {
++                declaration = declaration.toLightClass()","I think it could be implemented without light classes, they are pretty heavy and should be avoided if possible 
+Try to get everything you need from descriptor
+```Kotlin
+val classDescriptor = type.constructor.declarationDescriptor as? ClassDescriptor ?: return null
+val constructorParameters = classDescriptor.constructors.forEach {
+    it.valueParameters... // some checking stuff
+}
+```",2017-01-25 12:47:17
+8,"@@ -0,0 +1,13 @@","What is this file? Is it for manual testing?
+",2012-06-05 15:04:48
+787,"@@ -0,0 +1,132 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.jvm.compiler
++
++import com.intellij.openapi.Disposable
++import org.jetbrains.kotlin.cli.jvm.compiler.EnvironmentConfigFiles
++import org.jetbrains.kotlin.cli.jvm.compiler.KotlinCoreEnvironment
++import org.jetbrains.kotlin.config.JVMConfigurationKeys
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.renderer.*
++import org.jetbrains.kotlin.resolve.lazy.JvmResolveUtil
++import org.jetbrains.kotlin.test.ConfigurationKind
++import org.jetbrains.kotlin.test.KotlinTestUtils
++import org.jetbrains.kotlin.test.TestCaseWithTmpdir
++import org.jetbrains.kotlin.test.TestJdkKind
++import org.junit.Assert
++
++import java.io.File
++import java.io.IOException
++import java.lang.annotation.Retention
++
++import org.jetbrains.kotlin.test.KotlinTestUtils.*
++import org.jetbrains.kotlin.test.util.RecursiveDescriptorComparator.validateAndCompareDescriptorWithFile
++
++abstract class AbstractCompileJavaAgainstKotlinTest : TestCaseWithTmpdir() {
++
++    @Throws(IOException::class)
++    protected fun doTest(ktFilePath: String) {
++        Assert.assertTrue(ktFilePath.endsWith("".kt""))
++        val ktFile = File(ktFilePath)
++        val javaFile = File(ktFilePath.replaceFirst(""\\.kt$"".toRegex(), "".java""))
++
++        val javaErrorFile = File(ktFilePath.replaceFirst(""\\.kt$"".toRegex(), "".javaerr.txt""))
++
++        val out = File(tmpdir, ""out"")
++
++        val useJavac = this::class.java.name.contains(""WithJavac"")",This is too hacky. We normally use a bunch of protected methods to inject custom behavior in abstract test class,2017-04-25 09:59:13
+793,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())","Ditto, replace with `Name.identifier`",2017-04-25 11:06:11
+820,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract","Note that there's a corner case of enums with abstract members, which are considered abstract in Java but do not require (and even prohibit) the `abstract` keyword. Please add a test and ensure that it works",2017-04-25 13:32:10
+821,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic",Also please add a test on a nested enum (enum is never inner in Java),2017-04-25 13:35:09
+823,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = (outerClass?.isInterface ?: false) || tree.modifiers.isStatic","Not sure if `isInterface` returns true for annotations, please check and call `isAnnotation` if needed (a test would be nice in any case)",2017-04-25 13:41:01
+824,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = (outerClass?.isInterface ?: false) || tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = if (outerClass?.isInterface ?: false) PUBLIC else tree.modifiers.visibility",Also test annotations in addition to interfaces here,2017-04-25 13:41:49
+825,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = (outerClass?.isInterface ?: false) || tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = if (outerClass?.isInterface ?: false) PUBLIC else tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { TreeBasedTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes",There's also an implicit supertype `java.lang.annotation.Annotation` for all annotations,2017-04-25 13:42:38
+822,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = (outerClass?.isInterface ?: false) || tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = if (outerClass?.isInterface ?: false) PUBLIC else tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { TreeBasedTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes
++        get() = arrayListOf<JavaClassifierType>().apply {
++            fun JCTree.mapToJavaClassifierType() = when {
++                this is JCTree.JCTypeApply -> TreeBasedClassifierTypeWithTypeArgument(this, TreePath(treePath, this), javac)
++                this is JCTree.JCExpression -> TreeBasedClassifierTypeWithoutTypeArgument(this, TreePath(treePath, this), javac)
++                else -> null
++            }
++
++            if (isEnum) {
++                (javac.findClass(FqName(""java.lang.Enum"")) as? SymbolBasedClass<*>)
++                        ?.let { SymbolBasedType.create(it.element.asType(), javac) as? JavaClassifierType }
++                        ?.let { add(it) }
++            }
++
++            tree.implementing?.map { it.mapToJavaClassifierType() }?.filterNotNull()?.let(this::addAll)",`map` + `filterNotNull` = `mapNotNull`,2017-04-25 13:39:08
+826,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = (outerClass?.isInterface ?: false) || tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = if (outerClass?.isInterface ?: false) PUBLIC else tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { TreeBasedTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes
++        get() = arrayListOf<JavaClassifierType>().apply {
++            fun JCTree.mapToJavaClassifierType() = when {
++                this is JCTree.JCTypeApply -> TreeBasedClassifierTypeWithTypeArgument(this, TreePath(treePath, this), javac)
++                this is JCTree.JCExpression -> TreeBasedClassifierTypeWithoutTypeArgument(this, TreePath(treePath, this), javac)
++                else -> null
++            }
++
++            if (isEnum) {
++                (javac.findClass(FqName(""java.lang.Enum"")) as? SymbolBasedClass<*>)
++                        ?.let { SymbolBasedType.create(it.element.asType(), javac) as? JavaClassifierType }
++                        ?.let { add(it) }
++            }
++
++            tree.implementing?.map { it.mapToJavaClassifierType() }?.filterNotNull()?.let(this::addAll)
++            tree.extending?.let { it.mapToJavaClassifierType()?.let(this::add) }
++
++            if (isEmpty()) {
++                javac.JAVA_LANG_OBJECT?.let { add(SymbolBasedClassifierType(it.element.asType(), javac)) }
++            }
++        }
++
++    val innerClasses by lazy {",Please also call `.associateBy { it.name }` to make this a map from name to class. This will allow `innerClassNames` and `findInnerClass` to work in O(1),2017-04-25 13:46:06
+827,"@@ -0,0 +1,134 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.tree.TreeInfo
++import org.jetbrains.kotlin.descriptors.Visibilities.PUBLIC
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClassifierType
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedType
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedClass<out T : JCTree.JCClassDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaClass {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.simpleName.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.find { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = (outerClass?.isInterface ?: false) || tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility
++        get() = if (outerClass?.isInterface ?: false) PUBLIC else tree.modifiers.visibility
++
++    override val typeParameters
++        get() = tree.typeParameters.map { TreeBasedTypeParameter(it, TreePath(treePath, it), javac) }
++
++    override val fqName = treePath.reversed()
++            .joinToString(separator = ""."") {
++                (it as? JCTree.JCCompilationUnit)?.packageName?.toString()
++                ?: (it as JCTree.JCClassDecl).name
++            }
++            .let(::FqName)
++
++    override val supertypes
++        get() = arrayListOf<JavaClassifierType>().apply {
++            fun JCTree.mapToJavaClassifierType() = when {
++                this is JCTree.JCTypeApply -> TreeBasedClassifierTypeWithTypeArgument(this, TreePath(treePath, this), javac)
++                this is JCTree.JCExpression -> TreeBasedClassifierTypeWithoutTypeArgument(this, TreePath(treePath, this), javac)
++                else -> null
++            }
++
++            if (isEnum) {
++                (javac.findClass(FqName(""java.lang.Enum"")) as? SymbolBasedClass<*>)
++                        ?.let { SymbolBasedType.create(it.element.asType(), javac) as? JavaClassifierType }
++                        ?.let { add(it) }
++            }
++
++            tree.implementing?.map { it.mapToJavaClassifierType() }?.filterNotNull()?.let(this::addAll)
++            tree.extending?.let { it.mapToJavaClassifierType()?.let(this::add) }
++
++            if (isEmpty()) {
++                javac.JAVA_LANG_OBJECT?.let { add(SymbolBasedClassifierType(it.element.asType(), javac)) }
++            }
++        }
++
++    val innerClasses by lazy {
++        tree.members
++                .filterIsInstance(JCTree.JCClassDecl::class.java)
++                .map { TreeBasedClass(it, TreePath(treePath, it), javac) }
++    }
++
++    override val outerClass by lazy {
++        (treePath.parentPath.leaf as? JCTree.JCClassDecl)?.let { TreeBasedClass(it, treePath.parentPath, javac) }
++    }
++
++    override val isInterface
++        get() = tree.modifiers.flags and Flags.INTERFACE.toLong() != 0L
++
++    override val isAnnotationType
++        get() = tree.modifiers.flags and Flags.ANNOTATION.toLong() != 0L
++
++    override val isEnum
++        get() = tree.modifiers.flags and Flags.ENUM.toLong() != 0L
++
++    override val lightClassOriginKind = null",`get() = null`,2017-04-25 13:46:35
+53,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }","Five constructors for non-API constructor seems to be too much. Maybe provide default values manually on call sites?
+",2013-04-26 11:40:10
+54,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;","Use ArrayList instead of array. This won't take much extra memory, but will simplify code.
+",2013-04-26 11:40:40
+55,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {","I don't understand what this method does.
+",2013-04-26 11:42:59
+56,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options","What does mean ""applied""?
+",2013-04-26 11:43:15
+57,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];","Use list, and `Collections.reverse()` afterwards.
+",2013-04-26 11:43:41
+58,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {","We already have class called `TypeSubstitution` in Kotlin codebase, so, this name is too confusing.
+",2013-04-26 11:44:34
+59,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++","Make popup look the same as for Java, see screenshot:
+![Screen Shot 2013-04-24 at 18 17 37](https://f.cloud.github.com/assets/145855/430367/d8c2a7be-ae66-11e2-8886-ee07159d98d6.png)
+",2013-04-26 11:45:17
+60,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);","Why not use TypeCandidate instances as list elements? This would make it possible to avoid having String → TypeCandidate map.
+",2013-04-26 11:47:58
+61,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();","Why not check `getSelectedValue()` for null, if we access it anyway?
+",2013-04-26 11:48:23
+62,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {","`doInvoke` is not a good name, because it doesn't explain how it differs from simple `invoke`. Rename it to `addFunctionToSelectedOwner` or something like that.
+",2013-04-26 11:48:53
+63,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);","It's class declaration, not type declaration. Please rename.
+",2013-04-26 11:50:12
+64,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {","Checking for null is redundant when checking for `instanceof`.
+",2013-04-26 11:50:32
+65,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();","This code relies on implementation details. What if actual type of `ownerClassDescriptor` is `LazyClassDescriptor`? Replace it with `receiverType.getMemberScope()`
+",2013-04-26 11:51:51
+66,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {","`project` parameter is redundant, see above.
+",2013-04-26 11:52:20
+67,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);","Return immediately to avoid reassignment.
+",2013-04-26 11:52:53
+68,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);","Return immediately to avoid reassignment.
+",2013-04-26 11:52:59
+69,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {","Don't use such names, please. Even if parameter is not used.
+",2013-04-26 11:54:36
+70,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {
++                // file templates
++                int offset = template.getSegmentOffset(0);
++                final JetNamedFunction func = PsiTreeUtil.findElementOfClassAtOffset(containingFile, offset, JetNamedFunction.class, false);
++                assert func != null;
++                final List<JetTypeReference> typeRefsToShorten = new ArrayList<JetTypeReference>();
++
++                ApplicationManager.getApplication().runWriteAction(new Runnable() {
++                    @Override
++                    public void run() {
++                        // file templates
++                        setupFunctionBody(project, func);
++
++                        // change short type names to fully qualified ones (to be shortened below)
++                        setupTypeReferencesForShortening(project, func, typeRefsToShorten, parameterTypeExpressions, returnTypeExpression);
++                    }
++                });
++
++                ReferenceToClassesShortening.compactReferenceToClasses(typeRefsToShorten);
++            }
++        });
++    }
++
++    private Map<TypeParameterDescriptor, String> getTypeParameterRenames(JetScope scope) {
++        TypeParameterDescriptor[] receiverTypeParametersNotInScope = selectedReceiverType.getTypeParameters();
++        Set<TypeParameterDescriptor> allTypeParametersNotInScope = new LinkedHashSet<TypeParameterDescriptor>();
++        allTypeParametersNotInScope.addAll(Arrays.asList(receiverTypeParametersNotInScope));
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(parameterTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        if (!isUnit) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(returnTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(allTypeParametersNotInScope);
++        List<String> typeParameterNames = new ArrayList<String>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            typeParameterNames.add(getNextAvailableName(typeParameter.getName().getName(), typeParameterNames, scope));
++        }
++        assert typeParameters.size() == typeParameterNames.size();
++        Map<TypeParameterDescriptor, String> typeParameterNameMap = new HashMap<TypeParameterDescriptor, String>();
++        for (int i = 0; i < typeParameters.size(); i++) {
++            typeParameterNameMap.put(typeParameters.get(i), typeParameterNames.get(i));
++        }
++
++        return typeParameterNameMap;
++    }
++
++    private void setupTypeReferencesForShortening(
++            @NotNull Project project,
++            @NotNull JetNamedFunction func,
++            @NotNull List<JetTypeReference> typeRefsToShorten,
++            @NotNull TypeExpression[] parameterTypeExpressions,
++            @Nullable TypeExpression returnTypeExpression
++    ) {
++        if (isExtension) {
++            JetTypeReference receiverTypeRef =
++                    JetPsiFactory.createType(project, renderTypeLong(selectedReceiverType.getType(), typeParameterNameMap));
++            replaceWithLongerName(project, receiverTypeRef, selectedReceiverType.getType());
++
++            receiverTypeRef = func.getReceiverTypeRef();
++            if (receiverTypeRef != null) {
++                typeRefsToShorten.add(receiverTypeRef);
++            }
++        }
++
++        if (!isUnit) {
++            assert returnTypeExpression != null;
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                JetType returnType = returnTypeExpression.getTypeFromSelection(returnTypeRef.getText());
++                if (returnType != null) { // user selected a given type
++                    replaceWithLongerName(project, returnTypeRef, returnType);
++                    returnTypeRef = func.getReturnTypeRef();
++                    assert returnTypeRef != null;
++                    typeRefsToShorten.add(returnTypeRef);
++                }
++            }
++        }
++
++        List<JetParameter> valueParameters = func.getValueParameters();
++        List<Integer> parameterIndicesToShorten = new ArrayList<Integer>();
++        assert valueParameters.size() == parameterTypeExpressions.length;
++        for (int i = 0; i < valueParameters.size(); i++) {
++            JetParameter parameter = valueParameters.get(i);
++            JetTypeReference parameterTypeRef = parameter.getTypeReference();
++            if (parameterTypeRef != null) {
++                JetType parameterType = parameterTypeExpressions[i].getTypeFromSelection(parameterTypeRef.getText());
++                if (parameterType != null) {
++                    replaceWithLongerName(project, parameterTypeRef, parameterType);
++                    parameterIndicesToShorten.add(i);
++                }
++            }
++        }
++        valueParameters = func.getValueParameters();
++        for (int i : parameterIndicesToShorten) {
++            JetTypeReference parameterTypeRef = valueParameters.get(i).getTypeReference();
++            if (parameterTypeRef != null) {
++                typeRefsToShorten.add(parameterTypeRef);
++            }
++        }
++    }
++
++    private void setupFunctionBody(@NotNull Project project, @NotNull JetNamedFunction func) {
++        FileTemplate fileTemplate = FileTemplateManager.getInstance().getCodeTemplate(TEMPLATE_FROM_USAGE_METHOD_BODY);
++        Properties properties = new Properties();
++        if (isUnit) {
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, ""Unit"");
++        } else {
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            assert returnTypeRef != null;
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, returnTypeRef.getText());
++        }
++        properties.setProperty(FileTemplate.ATTRIBUTE_CLASS_NAME, DescriptorUtils.getFQName(ownerClassDescriptor).getFqName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_SIMPLE_CLASS_NAME, ownerClassDescriptor.getName().getName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_METHOD_NAME, methodName);
++
++        @NonNls String bodyText;
++        try {
++            bodyText = fileTemplate.getText(properties);
++        } catch (ProcessCanceledException e) {
++            throw e;
++        } catch (Exception e) {
++            throw new IncorrectOperationException(""Failed to parse file template"", e);
++        }
++        JetExpression newBodyExpression = JetPsiFactory.createFunctionBody(project, bodyText);
++        JetExpression oldBodyExpression = func.getBodyExpression();
++        assert oldBodyExpression != null;
++        oldBodyExpression.replace(newBodyExpression);
++    }
++
++    @NotNull
++    private TypeExpression setupReturnTypeTemplate(@NotNull TemplateBuilder builder, @NotNull JetNamedFunction func) {
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        assert returnTypeRef != null;
++        TypeExpression returnTypeExpression = new TypeExpression(returnType);
++        builder.replaceElement(returnTypeRef, returnTypeExpression);
++        return returnTypeExpression;
++    }
++
++    @NotNull
++    private TypeParameterListExpression setupTypeParameterListTemplate(@NotNull TemplateBuilderImpl builder, @NotNull JetNamedFunction func) {
++        Map<String, String[]> typeParameterMap = new HashMap<String, String[]>();
++        String[] receiverTypeParameterNames = selectedReceiverType.getTypeParameterNames();
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                typeParameterMap.put(parameterTypeCandidate.getRenderedType(), parameterTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        if (returnTypeRef != null) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                typeParameterMap.put(returnTypeCandidate.getRenderedType(), returnTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        builder.replaceElement(func, TextRange.create(3, 3), TYPE_PARAMETER_LIST_VARIABLE_NAME, null, false); // ((3, 3) is after ""fun"")
++        return new TypeParameterListExpression(receiverTypeParameterNames, typeParameterMap);
++    }
++
++    private TypeExpression[] setupParameterTypeTemplates(@NotNull Project project, @NotNull TemplateBuilder builder,
++            @NotNull JetParameterList parameterList) {
++        List<JetParameter> jetParameters = parameterList.getParameters();
++        assert jetParameters.size() == parameters.size();
++        TypeExpression[] parameterTypeExpressions = new TypeExpression[parameters.size()];
++        JetNameValidator dummyValidator = new DummyJetNameValidator(project);
++        for (int i = 0; i < parameters.size(); i++) {
++            Parameter parameter = parameters.get(i);
++            JetParameter jetParameter = jetParameters.get(i);
++
++            // add parameter type to the template
++            parameterTypeExpressions[i] = new TypeExpression(parameter.getType());
++            JetTypeReference parameterTypeRef = jetParameter.getTypeReference();
++            assert parameterTypeRef != null;
++            builder.replaceElement(parameterTypeRef, parameterTypeExpressions[i]);
++
++            // add parameter name to the template
++            String[] possibleNamesFromExpression = parameter.getType().getPossibleNamesFromExpression();
++            String preferredName = parameter.getPreferredName();
++            String[] possibleNames;
++            if (preferredName != null) {
++                possibleNames = new String[possibleNamesFromExpression.length + 1];
++                possibleNames[0] = preferredName;
++                System.arraycopy(possibleNamesFromExpression, 0, possibleNames, 1, possibleNamesFromExpression.length);
++            } else {
++                possibleNames = possibleNamesFromExpression;
++            }
++
++            // figure out suggested names for each type option
++            Map<String, String[]> parameterTypeToNamesMap = new HashMap<String, String[]>();
++            for (TypeCandidate typeCandidate : parameter.getType().getTypeCandidates()) {
++                String[] suggestedNames = JetNameSuggester.suggestNamesForType(typeCandidate.getType(), dummyValidator);
++                parameterTypeToNamesMap.put(typeCandidate.getRenderedType(), suggestedNames);
++            }
++
++            // add expression to builder
++            Expression parameterNameExpression = new ParameterNameExpression(possibleNames, parameterTypeToNamesMap);
++            PsiElement parameterNameIdentifier = jetParameter.getNameIdentifier();
++            assert parameterNameIdentifier != null;
++            builder.replaceElement(parameterNameIdentifier, parameterNameExpression);
++        }
++        return parameterTypeExpressions;
++    }
++
++    private void replaceWithLongerName(@NotNull Project project, @NotNull JetTypeReference typeRef, @NotNull JetType type) {
++        JetTypeReference fullyQualifiedReceiverTypeRef = JetPsiFactory.createType(project, renderTypeLong(type, typeParameterNameMap));
++        typeRef.replace(fullyQualifiedReceiverTypeRef);
++    }
++
++    @NotNull
++    private static JetType substituteType(@NotNull JetType type, @NotNull TypeSubstitution substitution, @NotNull Variance variance) {","I don't understand what does this method do, but I feel that it can be replaced with using already existing `TypeSubstitutor` mechanism. Please check it.
+",2013-04-26 11:55:18
+71,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {
++                // file templates
++                int offset = template.getSegmentOffset(0);
++                final JetNamedFunction func = PsiTreeUtil.findElementOfClassAtOffset(containingFile, offset, JetNamedFunction.class, false);
++                assert func != null;
++                final List<JetTypeReference> typeRefsToShorten = new ArrayList<JetTypeReference>();
++
++                ApplicationManager.getApplication().runWriteAction(new Runnable() {
++                    @Override
++                    public void run() {
++                        // file templates
++                        setupFunctionBody(project, func);
++
++                        // change short type names to fully qualified ones (to be shortened below)
++                        setupTypeReferencesForShortening(project, func, typeRefsToShorten, parameterTypeExpressions, returnTypeExpression);
++                    }
++                });
++
++                ReferenceToClassesShortening.compactReferenceToClasses(typeRefsToShorten);
++            }
++        });
++    }
++
++    private Map<TypeParameterDescriptor, String> getTypeParameterRenames(JetScope scope) {
++        TypeParameterDescriptor[] receiverTypeParametersNotInScope = selectedReceiverType.getTypeParameters();
++        Set<TypeParameterDescriptor> allTypeParametersNotInScope = new LinkedHashSet<TypeParameterDescriptor>();
++        allTypeParametersNotInScope.addAll(Arrays.asList(receiverTypeParametersNotInScope));
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(parameterTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        if (!isUnit) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(returnTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(allTypeParametersNotInScope);
++        List<String> typeParameterNames = new ArrayList<String>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            typeParameterNames.add(getNextAvailableName(typeParameter.getName().getName(), typeParameterNames, scope));
++        }
++        assert typeParameters.size() == typeParameterNames.size();
++        Map<TypeParameterDescriptor, String> typeParameterNameMap = new HashMap<TypeParameterDescriptor, String>();
++        for (int i = 0; i < typeParameters.size(); i++) {
++            typeParameterNameMap.put(typeParameters.get(i), typeParameterNames.get(i));
++        }
++
++        return typeParameterNameMap;
++    }
++
++    private void setupTypeReferencesForShortening(
++            @NotNull Project project,
++            @NotNull JetNamedFunction func,
++            @NotNull List<JetTypeReference> typeRefsToShorten,
++            @NotNull TypeExpression[] parameterTypeExpressions,
++            @Nullable TypeExpression returnTypeExpression
++    ) {
++        if (isExtension) {
++            JetTypeReference receiverTypeRef =
++                    JetPsiFactory.createType(project, renderTypeLong(selectedReceiverType.getType(), typeParameterNameMap));
++            replaceWithLongerName(project, receiverTypeRef, selectedReceiverType.getType());
++
++            receiverTypeRef = func.getReceiverTypeRef();
++            if (receiverTypeRef != null) {
++                typeRefsToShorten.add(receiverTypeRef);
++            }
++        }
++
++        if (!isUnit) {
++            assert returnTypeExpression != null;
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                JetType returnType = returnTypeExpression.getTypeFromSelection(returnTypeRef.getText());
++                if (returnType != null) { // user selected a given type
++                    replaceWithLongerName(project, returnTypeRef, returnType);
++                    returnTypeRef = func.getReturnTypeRef();
++                    assert returnTypeRef != null;
++                    typeRefsToShorten.add(returnTypeRef);
++                }
++            }
++        }
++
++        List<JetParameter> valueParameters = func.getValueParameters();
++        List<Integer> parameterIndicesToShorten = new ArrayList<Integer>();
++        assert valueParameters.size() == parameterTypeExpressions.length;
++        for (int i = 0; i < valueParameters.size(); i++) {
++            JetParameter parameter = valueParameters.get(i);
++            JetTypeReference parameterTypeRef = parameter.getTypeReference();
++            if (parameterTypeRef != null) {
++                JetType parameterType = parameterTypeExpressions[i].getTypeFromSelection(parameterTypeRef.getText());
++                if (parameterType != null) {
++                    replaceWithLongerName(project, parameterTypeRef, parameterType);
++                    parameterIndicesToShorten.add(i);
++                }
++            }
++        }
++        valueParameters = func.getValueParameters();
++        for (int i : parameterIndicesToShorten) {
++            JetTypeReference parameterTypeRef = valueParameters.get(i).getTypeReference();
++            if (parameterTypeRef != null) {
++                typeRefsToShorten.add(parameterTypeRef);
++            }
++        }
++    }
++
++    private void setupFunctionBody(@NotNull Project project, @NotNull JetNamedFunction func) {
++        FileTemplate fileTemplate = FileTemplateManager.getInstance().getCodeTemplate(TEMPLATE_FROM_USAGE_METHOD_BODY);
++        Properties properties = new Properties();
++        if (isUnit) {
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, ""Unit"");
++        } else {
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            assert returnTypeRef != null;
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, returnTypeRef.getText());
++        }
++        properties.setProperty(FileTemplate.ATTRIBUTE_CLASS_NAME, DescriptorUtils.getFQName(ownerClassDescriptor).getFqName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_SIMPLE_CLASS_NAME, ownerClassDescriptor.getName().getName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_METHOD_NAME, methodName);
++
++        @NonNls String bodyText;
++        try {
++            bodyText = fileTemplate.getText(properties);
++        } catch (ProcessCanceledException e) {
++            throw e;
++        } catch (Exception e) {
++            throw new IncorrectOperationException(""Failed to parse file template"", e);
++        }
++        JetExpression newBodyExpression = JetPsiFactory.createFunctionBody(project, bodyText);
++        JetExpression oldBodyExpression = func.getBodyExpression();
++        assert oldBodyExpression != null;
++        oldBodyExpression.replace(newBodyExpression);
++    }
++
++    @NotNull
++    private TypeExpression setupReturnTypeTemplate(@NotNull TemplateBuilder builder, @NotNull JetNamedFunction func) {
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        assert returnTypeRef != null;
++        TypeExpression returnTypeExpression = new TypeExpression(returnType);
++        builder.replaceElement(returnTypeRef, returnTypeExpression);
++        return returnTypeExpression;
++    }
++
++    @NotNull
++    private TypeParameterListExpression setupTypeParameterListTemplate(@NotNull TemplateBuilderImpl builder, @NotNull JetNamedFunction func) {
++        Map<String, String[]> typeParameterMap = new HashMap<String, String[]>();
++        String[] receiverTypeParameterNames = selectedReceiverType.getTypeParameterNames();
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                typeParameterMap.put(parameterTypeCandidate.getRenderedType(), parameterTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        if (returnTypeRef != null) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                typeParameterMap.put(returnTypeCandidate.getRenderedType(), returnTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        builder.replaceElement(func, TextRange.create(3, 3), TYPE_PARAMETER_LIST_VARIABLE_NAME, null, false); // ((3, 3) is after ""fun"")
++        return new TypeParameterListExpression(receiverTypeParameterNames, typeParameterMap);
++    }
++
++    private TypeExpression[] setupParameterTypeTemplates(@NotNull Project project, @NotNull TemplateBuilder builder,
++            @NotNull JetParameterList parameterList) {
++        List<JetParameter> jetParameters = parameterList.getParameters();
++        assert jetParameters.size() == parameters.size();
++        TypeExpression[] parameterTypeExpressions = new TypeExpression[parameters.size()];
++        JetNameValidator dummyValidator = new DummyJetNameValidator(project);
++        for (int i = 0; i < parameters.size(); i++) {
++            Parameter parameter = parameters.get(i);
++            JetParameter jetParameter = jetParameters.get(i);
++
++            // add parameter type to the template
++            parameterTypeExpressions[i] = new TypeExpression(parameter.getType());
++            JetTypeReference parameterTypeRef = jetParameter.getTypeReference();
++            assert parameterTypeRef != null;
++            builder.replaceElement(parameterTypeRef, parameterTypeExpressions[i]);
++
++            // add parameter name to the template
++            String[] possibleNamesFromExpression = parameter.getType().getPossibleNamesFromExpression();
++            String preferredName = parameter.getPreferredName();
++            String[] possibleNames;
++            if (preferredName != null) {
++                possibleNames = new String[possibleNamesFromExpression.length + 1];
++                possibleNames[0] = preferredName;
++                System.arraycopy(possibleNamesFromExpression, 0, possibleNames, 1, possibleNamesFromExpression.length);
++            } else {
++                possibleNames = possibleNamesFromExpression;
++            }
++
++            // figure out suggested names for each type option
++            Map<String, String[]> parameterTypeToNamesMap = new HashMap<String, String[]>();
++            for (TypeCandidate typeCandidate : parameter.getType().getTypeCandidates()) {
++                String[] suggestedNames = JetNameSuggester.suggestNamesForType(typeCandidate.getType(), dummyValidator);
++                parameterTypeToNamesMap.put(typeCandidate.getRenderedType(), suggestedNames);
++            }
++
++            // add expression to builder
++            Expression parameterNameExpression = new ParameterNameExpression(possibleNames, parameterTypeToNamesMap);
++            PsiElement parameterNameIdentifier = jetParameter.getNameIdentifier();
++            assert parameterNameIdentifier != null;
++            builder.replaceElement(parameterNameIdentifier, parameterNameExpression);
++        }
++        return parameterTypeExpressions;
++    }
++
++    private void replaceWithLongerName(@NotNull Project project, @NotNull JetTypeReference typeRef, @NotNull JetType type) {
++        JetTypeReference fullyQualifiedReceiverTypeRef = JetPsiFactory.createType(project, renderTypeLong(type, typeParameterNameMap));
++        typeRef.replace(fullyQualifiedReceiverTypeRef);
++    }
++
++    @NotNull
++    private static JetType substituteType(@NotNull JetType type, @NotNull TypeSubstitution substitution, @NotNull Variance variance) {
++        switch (variance) {
++            case INVARIANT:
++                // for invariant, can replace only when they're equal
++                if (type.equals(substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case IN_VARIANCE:
++                // for covariant (e.g. function parameter), can replace type with any of its supertypes","You seem to mix up ""co"" and ""contra"" prefixes.
+",2013-04-26 11:55:52
+72,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {
++                // file templates
++                int offset = template.getSegmentOffset(0);
++                final JetNamedFunction func = PsiTreeUtil.findElementOfClassAtOffset(containingFile, offset, JetNamedFunction.class, false);
++                assert func != null;
++                final List<JetTypeReference> typeRefsToShorten = new ArrayList<JetTypeReference>();
++
++                ApplicationManager.getApplication().runWriteAction(new Runnable() {
++                    @Override
++                    public void run() {
++                        // file templates
++                        setupFunctionBody(project, func);
++
++                        // change short type names to fully qualified ones (to be shortened below)
++                        setupTypeReferencesForShortening(project, func, typeRefsToShorten, parameterTypeExpressions, returnTypeExpression);
++                    }
++                });
++
++                ReferenceToClassesShortening.compactReferenceToClasses(typeRefsToShorten);
++            }
++        });
++    }
++
++    private Map<TypeParameterDescriptor, String> getTypeParameterRenames(JetScope scope) {
++        TypeParameterDescriptor[] receiverTypeParametersNotInScope = selectedReceiverType.getTypeParameters();
++        Set<TypeParameterDescriptor> allTypeParametersNotInScope = new LinkedHashSet<TypeParameterDescriptor>();
++        allTypeParametersNotInScope.addAll(Arrays.asList(receiverTypeParametersNotInScope));
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(parameterTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        if (!isUnit) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(returnTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(allTypeParametersNotInScope);
++        List<String> typeParameterNames = new ArrayList<String>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            typeParameterNames.add(getNextAvailableName(typeParameter.getName().getName(), typeParameterNames, scope));
++        }
++        assert typeParameters.size() == typeParameterNames.size();
++        Map<TypeParameterDescriptor, String> typeParameterNameMap = new HashMap<TypeParameterDescriptor, String>();
++        for (int i = 0; i < typeParameters.size(); i++) {
++            typeParameterNameMap.put(typeParameters.get(i), typeParameterNames.get(i));
++        }
++
++        return typeParameterNameMap;
++    }
++
++    private void setupTypeReferencesForShortening(
++            @NotNull Project project,
++            @NotNull JetNamedFunction func,
++            @NotNull List<JetTypeReference> typeRefsToShorten,
++            @NotNull TypeExpression[] parameterTypeExpressions,
++            @Nullable TypeExpression returnTypeExpression
++    ) {
++        if (isExtension) {
++            JetTypeReference receiverTypeRef =
++                    JetPsiFactory.createType(project, renderTypeLong(selectedReceiverType.getType(), typeParameterNameMap));
++            replaceWithLongerName(project, receiverTypeRef, selectedReceiverType.getType());
++
++            receiverTypeRef = func.getReceiverTypeRef();
++            if (receiverTypeRef != null) {
++                typeRefsToShorten.add(receiverTypeRef);
++            }
++        }
++
++        if (!isUnit) {
++            assert returnTypeExpression != null;
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                JetType returnType = returnTypeExpression.getTypeFromSelection(returnTypeRef.getText());
++                if (returnType != null) { // user selected a given type
++                    replaceWithLongerName(project, returnTypeRef, returnType);
++                    returnTypeRef = func.getReturnTypeRef();
++                    assert returnTypeRef != null;
++                    typeRefsToShorten.add(returnTypeRef);
++                }
++            }
++        }
++
++        List<JetParameter> valueParameters = func.getValueParameters();
++        List<Integer> parameterIndicesToShorten = new ArrayList<Integer>();
++        assert valueParameters.size() == parameterTypeExpressions.length;
++        for (int i = 0; i < valueParameters.size(); i++) {
++            JetParameter parameter = valueParameters.get(i);
++            JetTypeReference parameterTypeRef = parameter.getTypeReference();
++            if (parameterTypeRef != null) {
++                JetType parameterType = parameterTypeExpressions[i].getTypeFromSelection(parameterTypeRef.getText());
++                if (parameterType != null) {
++                    replaceWithLongerName(project, parameterTypeRef, parameterType);
++                    parameterIndicesToShorten.add(i);
++                }
++            }
++        }
++        valueParameters = func.getValueParameters();
++        for (int i : parameterIndicesToShorten) {
++            JetTypeReference parameterTypeRef = valueParameters.get(i).getTypeReference();
++            if (parameterTypeRef != null) {
++                typeRefsToShorten.add(parameterTypeRef);
++            }
++        }
++    }
++
++    private void setupFunctionBody(@NotNull Project project, @NotNull JetNamedFunction func) {
++        FileTemplate fileTemplate = FileTemplateManager.getInstance().getCodeTemplate(TEMPLATE_FROM_USAGE_METHOD_BODY);
++        Properties properties = new Properties();
++        if (isUnit) {
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, ""Unit"");
++        } else {
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            assert returnTypeRef != null;
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, returnTypeRef.getText());
++        }
++        properties.setProperty(FileTemplate.ATTRIBUTE_CLASS_NAME, DescriptorUtils.getFQName(ownerClassDescriptor).getFqName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_SIMPLE_CLASS_NAME, ownerClassDescriptor.getName().getName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_METHOD_NAME, methodName);
++
++        @NonNls String bodyText;
++        try {
++            bodyText = fileTemplate.getText(properties);
++        } catch (ProcessCanceledException e) {
++            throw e;
++        } catch (Exception e) {
++            throw new IncorrectOperationException(""Failed to parse file template"", e);
++        }
++        JetExpression newBodyExpression = JetPsiFactory.createFunctionBody(project, bodyText);
++        JetExpression oldBodyExpression = func.getBodyExpression();
++        assert oldBodyExpression != null;
++        oldBodyExpression.replace(newBodyExpression);
++    }
++
++    @NotNull
++    private TypeExpression setupReturnTypeTemplate(@NotNull TemplateBuilder builder, @NotNull JetNamedFunction func) {
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        assert returnTypeRef != null;
++        TypeExpression returnTypeExpression = new TypeExpression(returnType);
++        builder.replaceElement(returnTypeRef, returnTypeExpression);
++        return returnTypeExpression;
++    }
++
++    @NotNull
++    private TypeParameterListExpression setupTypeParameterListTemplate(@NotNull TemplateBuilderImpl builder, @NotNull JetNamedFunction func) {
++        Map<String, String[]> typeParameterMap = new HashMap<String, String[]>();
++        String[] receiverTypeParameterNames = selectedReceiverType.getTypeParameterNames();
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                typeParameterMap.put(parameterTypeCandidate.getRenderedType(), parameterTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        if (returnTypeRef != null) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                typeParameterMap.put(returnTypeCandidate.getRenderedType(), returnTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        builder.replaceElement(func, TextRange.create(3, 3), TYPE_PARAMETER_LIST_VARIABLE_NAME, null, false); // ((3, 3) is after ""fun"")
++        return new TypeParameterListExpression(receiverTypeParameterNames, typeParameterMap);
++    }
++
++    private TypeExpression[] setupParameterTypeTemplates(@NotNull Project project, @NotNull TemplateBuilder builder,
++            @NotNull JetParameterList parameterList) {
++        List<JetParameter> jetParameters = parameterList.getParameters();
++        assert jetParameters.size() == parameters.size();
++        TypeExpression[] parameterTypeExpressions = new TypeExpression[parameters.size()];
++        JetNameValidator dummyValidator = new DummyJetNameValidator(project);
++        for (int i = 0; i < parameters.size(); i++) {
++            Parameter parameter = parameters.get(i);
++            JetParameter jetParameter = jetParameters.get(i);
++
++            // add parameter type to the template
++            parameterTypeExpressions[i] = new TypeExpression(parameter.getType());
++            JetTypeReference parameterTypeRef = jetParameter.getTypeReference();
++            assert parameterTypeRef != null;
++            builder.replaceElement(parameterTypeRef, parameterTypeExpressions[i]);
++
++            // add parameter name to the template
++            String[] possibleNamesFromExpression = parameter.getType().getPossibleNamesFromExpression();
++            String preferredName = parameter.getPreferredName();
++            String[] possibleNames;
++            if (preferredName != null) {
++                possibleNames = new String[possibleNamesFromExpression.length + 1];
++                possibleNames[0] = preferredName;
++                System.arraycopy(possibleNamesFromExpression, 0, possibleNames, 1, possibleNamesFromExpression.length);
++            } else {
++                possibleNames = possibleNamesFromExpression;
++            }
++
++            // figure out suggested names for each type option
++            Map<String, String[]> parameterTypeToNamesMap = new HashMap<String, String[]>();
++            for (TypeCandidate typeCandidate : parameter.getType().getTypeCandidates()) {
++                String[] suggestedNames = JetNameSuggester.suggestNamesForType(typeCandidate.getType(), dummyValidator);
++                parameterTypeToNamesMap.put(typeCandidate.getRenderedType(), suggestedNames);
++            }
++
++            // add expression to builder
++            Expression parameterNameExpression = new ParameterNameExpression(possibleNames, parameterTypeToNamesMap);
++            PsiElement parameterNameIdentifier = jetParameter.getNameIdentifier();
++            assert parameterNameIdentifier != null;
++            builder.replaceElement(parameterNameIdentifier, parameterNameExpression);
++        }
++        return parameterTypeExpressions;
++    }
++
++    private void replaceWithLongerName(@NotNull Project project, @NotNull JetTypeReference typeRef, @NotNull JetType type) {
++        JetTypeReference fullyQualifiedReceiverTypeRef = JetPsiFactory.createType(project, renderTypeLong(type, typeParameterNameMap));
++        typeRef.replace(fullyQualifiedReceiverTypeRef);
++    }
++
++    @NotNull
++    private static JetType substituteType(@NotNull JetType type, @NotNull TypeSubstitution substitution, @NotNull Variance variance) {
++        switch (variance) {
++            case INVARIANT:
++                // for invariant, can replace only when they're equal
++                if (type.equals(substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case IN_VARIANCE:
++                // for covariant (e.g. function parameter), can replace type with any of its supertypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(type, substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case OUT_VARIANCE:
++                // for contravariant (e.g. function return value), can replace type with any of its subtypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(substitution.getForType(), type)) {
++                    return substitution.getByType();
++                }
++                break;
++        }
++
++        List<TypeProjection> newArguments = new ArrayList<TypeProjection>();
++        List<TypeParameterDescriptor> typeParameters = type.getConstructor().getParameters();
++        int i = 0;
++        for (TypeProjection projection : type.getArguments()) {
++            TypeParameterDescriptor typeParameter = typeParameters.get(i);
++            JetType newArgument = substituteType(projection.getType(), substitution, typeParameter.getVariance());
++            newArguments.add(new TypeProjection(Variance.INVARIANT, newArgument));
++            i++;
++        }
++        return new JetTypeImpl(type.getAnnotations(), type.getConstructor(),
++                               type.isNullable(), newArguments, type.getMemberScope());
++    }
++
++    private static boolean containsType(JetType outer, JetType inner) {
++        if (outer.equals(inner)) {
++            return true;
++        }
++
++        for (TypeProjection projection : outer.getArguments()) {
++            if (containsType(projection.getType(), inner)) {
++                return true;
++            }
++        }
++
++        return false;
++    }
++
++    @NotNull
++    private static String renderDescriptor(
++            @NotNull DeclarationDescriptor declarationDescriptor,
++            @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap,
++            boolean fq
++    ) {
++        if (declarationDescriptor instanceof TypeParameterDescriptor) {
++            String replacement = typeParameterNameMap.get(declarationDescriptor);
++            return replacement == null ? declarationDescriptor.getName().getName() : replacement;
++        } else {
++            return fq ? DescriptorUtils.getFQName(declarationDescriptor).getFqName() : declarationDescriptor.getName().getName();
++        }
++    }
++
++    @NotNull
++    private static String renderDescriptor(@NotNull DeclarationDescriptor declarationDescriptor, boolean fq) {
++        return renderDescriptor(declarationDescriptor, Collections.<TypeParameterDescriptor, String>emptyMap(), fq);
++    }
++
++    private static String renderType(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap, boolean fq) {
++        List<TypeProjection> projections = type.getArguments();
++        DeclarationDescriptor declarationDescriptor = type.getConstructor().getDeclarationDescriptor();
++        assert declarationDescriptor != null;
++        if (projections.isEmpty()) {
++            return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq);
++        }
++
++        List<String> arguments = new ArrayList<String>();
++        for (TypeProjection projection : projections) {
++            arguments.add(renderType(projection.getType(), typeParameterNameMap, fq));
++        }
++        return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq) + ""<"" + StringUtil.join(arguments, "", "") + "">"";
++    }
++
++    @NotNull
++    private static String renderTypeShort(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, false);
++    }
++
++    @NotNull
++    private static String renderTypeLong(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, true);
++    }
++
++    @NotNull
++    private static TypeParameterDescriptor[] getTypeParameterNamesNotInScope(
++            @NotNull Collection<? extends TypeParameterDescriptor> typeParameters,
++            @NotNull JetScope scope
++    ) {
++        List<TypeParameterDescriptor> typeParameterNames = new ArrayList<TypeParameterDescriptor>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            ClassifierDescriptor classifier = scope.getClassifier(typeParameter.getName());
++            if (classifier == null || !classifier.equals(typeParameter)) {
++                typeParameterNames.add(typeParameter);
++            }
++        }
++        return typeParameterNames.toArray(new TypeParameterDescriptor[typeParameterNames.size()]);
++    }
++
++    @NotNull
++    private static Set<TypeParameterDescriptor> getTypeParametersInType(@NotNull JetType type) {
++        Set<TypeParameterDescriptor> typeParameters = new LinkedHashSet<TypeParameterDescriptor>();
++        List<TypeProjection> arguments = type.getArguments();
++        if (arguments.isEmpty()) {
++            ClassifierDescriptor descriptor = type.getConstructor().getDeclarationDescriptor();
++            if (descriptor instanceof TypeParameterDescriptor) {
++                typeParameters.add((TypeParameterDescriptor) descriptor);
++            }
++        } else {
++            for (TypeProjection projection : arguments) {
++                typeParameters.addAll(getTypeParametersInType(projection.getType()));
++            }
++        }
++        return typeParameters;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames) {","I think, it's better to merge this and next method (with `@Nullable` scope)
+Add comment, that for Foo name from parameter it returns itself, if it is available, and Foo1, Foo2, .. if it's not.
+",2013-04-26 11:56:49
+73,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {
++                // file templates
++                int offset = template.getSegmentOffset(0);
++                final JetNamedFunction func = PsiTreeUtil.findElementOfClassAtOffset(containingFile, offset, JetNamedFunction.class, false);
++                assert func != null;
++                final List<JetTypeReference> typeRefsToShorten = new ArrayList<JetTypeReference>();
++
++                ApplicationManager.getApplication().runWriteAction(new Runnable() {
++                    @Override
++                    public void run() {
++                        // file templates
++                        setupFunctionBody(project, func);
++
++                        // change short type names to fully qualified ones (to be shortened below)
++                        setupTypeReferencesForShortening(project, func, typeRefsToShorten, parameterTypeExpressions, returnTypeExpression);
++                    }
++                });
++
++                ReferenceToClassesShortening.compactReferenceToClasses(typeRefsToShorten);
++            }
++        });
++    }
++
++    private Map<TypeParameterDescriptor, String> getTypeParameterRenames(JetScope scope) {
++        TypeParameterDescriptor[] receiverTypeParametersNotInScope = selectedReceiverType.getTypeParameters();
++        Set<TypeParameterDescriptor> allTypeParametersNotInScope = new LinkedHashSet<TypeParameterDescriptor>();
++        allTypeParametersNotInScope.addAll(Arrays.asList(receiverTypeParametersNotInScope));
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(parameterTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        if (!isUnit) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(returnTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(allTypeParametersNotInScope);
++        List<String> typeParameterNames = new ArrayList<String>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            typeParameterNames.add(getNextAvailableName(typeParameter.getName().getName(), typeParameterNames, scope));
++        }
++        assert typeParameters.size() == typeParameterNames.size();
++        Map<TypeParameterDescriptor, String> typeParameterNameMap = new HashMap<TypeParameterDescriptor, String>();
++        for (int i = 0; i < typeParameters.size(); i++) {
++            typeParameterNameMap.put(typeParameters.get(i), typeParameterNames.get(i));
++        }
++
++        return typeParameterNameMap;
++    }
++
++    private void setupTypeReferencesForShortening(
++            @NotNull Project project,
++            @NotNull JetNamedFunction func,
++            @NotNull List<JetTypeReference> typeRefsToShorten,
++            @NotNull TypeExpression[] parameterTypeExpressions,
++            @Nullable TypeExpression returnTypeExpression
++    ) {
++        if (isExtension) {
++            JetTypeReference receiverTypeRef =
++                    JetPsiFactory.createType(project, renderTypeLong(selectedReceiverType.getType(), typeParameterNameMap));
++            replaceWithLongerName(project, receiverTypeRef, selectedReceiverType.getType());
++
++            receiverTypeRef = func.getReceiverTypeRef();
++            if (receiverTypeRef != null) {
++                typeRefsToShorten.add(receiverTypeRef);
++            }
++        }
++
++        if (!isUnit) {
++            assert returnTypeExpression != null;
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                JetType returnType = returnTypeExpression.getTypeFromSelection(returnTypeRef.getText());
++                if (returnType != null) { // user selected a given type
++                    replaceWithLongerName(project, returnTypeRef, returnType);
++                    returnTypeRef = func.getReturnTypeRef();
++                    assert returnTypeRef != null;
++                    typeRefsToShorten.add(returnTypeRef);
++                }
++            }
++        }
++
++        List<JetParameter> valueParameters = func.getValueParameters();
++        List<Integer> parameterIndicesToShorten = new ArrayList<Integer>();
++        assert valueParameters.size() == parameterTypeExpressions.length;
++        for (int i = 0; i < valueParameters.size(); i++) {
++            JetParameter parameter = valueParameters.get(i);
++            JetTypeReference parameterTypeRef = parameter.getTypeReference();
++            if (parameterTypeRef != null) {
++                JetType parameterType = parameterTypeExpressions[i].getTypeFromSelection(parameterTypeRef.getText());
++                if (parameterType != null) {
++                    replaceWithLongerName(project, parameterTypeRef, parameterType);
++                    parameterIndicesToShorten.add(i);
++                }
++            }
++        }
++        valueParameters = func.getValueParameters();
++        for (int i : parameterIndicesToShorten) {
++            JetTypeReference parameterTypeRef = valueParameters.get(i).getTypeReference();
++            if (parameterTypeRef != null) {
++                typeRefsToShorten.add(parameterTypeRef);
++            }
++        }
++    }
++
++    private void setupFunctionBody(@NotNull Project project, @NotNull JetNamedFunction func) {
++        FileTemplate fileTemplate = FileTemplateManager.getInstance().getCodeTemplate(TEMPLATE_FROM_USAGE_METHOD_BODY);
++        Properties properties = new Properties();
++        if (isUnit) {
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, ""Unit"");
++        } else {
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            assert returnTypeRef != null;
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, returnTypeRef.getText());
++        }
++        properties.setProperty(FileTemplate.ATTRIBUTE_CLASS_NAME, DescriptorUtils.getFQName(ownerClassDescriptor).getFqName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_SIMPLE_CLASS_NAME, ownerClassDescriptor.getName().getName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_METHOD_NAME, methodName);
++
++        @NonNls String bodyText;
++        try {
++            bodyText = fileTemplate.getText(properties);
++        } catch (ProcessCanceledException e) {
++            throw e;
++        } catch (Exception e) {
++            throw new IncorrectOperationException(""Failed to parse file template"", e);
++        }
++        JetExpression newBodyExpression = JetPsiFactory.createFunctionBody(project, bodyText);
++        JetExpression oldBodyExpression = func.getBodyExpression();
++        assert oldBodyExpression != null;
++        oldBodyExpression.replace(newBodyExpression);
++    }
++
++    @NotNull
++    private TypeExpression setupReturnTypeTemplate(@NotNull TemplateBuilder builder, @NotNull JetNamedFunction func) {
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        assert returnTypeRef != null;
++        TypeExpression returnTypeExpression = new TypeExpression(returnType);
++        builder.replaceElement(returnTypeRef, returnTypeExpression);
++        return returnTypeExpression;
++    }
++
++    @NotNull
++    private TypeParameterListExpression setupTypeParameterListTemplate(@NotNull TemplateBuilderImpl builder, @NotNull JetNamedFunction func) {
++        Map<String, String[]> typeParameterMap = new HashMap<String, String[]>();
++        String[] receiverTypeParameterNames = selectedReceiverType.getTypeParameterNames();
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                typeParameterMap.put(parameterTypeCandidate.getRenderedType(), parameterTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        if (returnTypeRef != null) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                typeParameterMap.put(returnTypeCandidate.getRenderedType(), returnTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        builder.replaceElement(func, TextRange.create(3, 3), TYPE_PARAMETER_LIST_VARIABLE_NAME, null, false); // ((3, 3) is after ""fun"")
++        return new TypeParameterListExpression(receiverTypeParameterNames, typeParameterMap);
++    }
++
++    private TypeExpression[] setupParameterTypeTemplates(@NotNull Project project, @NotNull TemplateBuilder builder,
++            @NotNull JetParameterList parameterList) {
++        List<JetParameter> jetParameters = parameterList.getParameters();
++        assert jetParameters.size() == parameters.size();
++        TypeExpression[] parameterTypeExpressions = new TypeExpression[parameters.size()];
++        JetNameValidator dummyValidator = new DummyJetNameValidator(project);
++        for (int i = 0; i < parameters.size(); i++) {
++            Parameter parameter = parameters.get(i);
++            JetParameter jetParameter = jetParameters.get(i);
++
++            // add parameter type to the template
++            parameterTypeExpressions[i] = new TypeExpression(parameter.getType());
++            JetTypeReference parameterTypeRef = jetParameter.getTypeReference();
++            assert parameterTypeRef != null;
++            builder.replaceElement(parameterTypeRef, parameterTypeExpressions[i]);
++
++            // add parameter name to the template
++            String[] possibleNamesFromExpression = parameter.getType().getPossibleNamesFromExpression();
++            String preferredName = parameter.getPreferredName();
++            String[] possibleNames;
++            if (preferredName != null) {
++                possibleNames = new String[possibleNamesFromExpression.length + 1];
++                possibleNames[0] = preferredName;
++                System.arraycopy(possibleNamesFromExpression, 0, possibleNames, 1, possibleNamesFromExpression.length);
++            } else {
++                possibleNames = possibleNamesFromExpression;
++            }
++
++            // figure out suggested names for each type option
++            Map<String, String[]> parameterTypeToNamesMap = new HashMap<String, String[]>();
++            for (TypeCandidate typeCandidate : parameter.getType().getTypeCandidates()) {
++                String[] suggestedNames = JetNameSuggester.suggestNamesForType(typeCandidate.getType(), dummyValidator);
++                parameterTypeToNamesMap.put(typeCandidate.getRenderedType(), suggestedNames);
++            }
++
++            // add expression to builder
++            Expression parameterNameExpression = new ParameterNameExpression(possibleNames, parameterTypeToNamesMap);
++            PsiElement parameterNameIdentifier = jetParameter.getNameIdentifier();
++            assert parameterNameIdentifier != null;
++            builder.replaceElement(parameterNameIdentifier, parameterNameExpression);
++        }
++        return parameterTypeExpressions;
++    }
++
++    private void replaceWithLongerName(@NotNull Project project, @NotNull JetTypeReference typeRef, @NotNull JetType type) {
++        JetTypeReference fullyQualifiedReceiverTypeRef = JetPsiFactory.createType(project, renderTypeLong(type, typeParameterNameMap));
++        typeRef.replace(fullyQualifiedReceiverTypeRef);
++    }
++
++    @NotNull
++    private static JetType substituteType(@NotNull JetType type, @NotNull TypeSubstitution substitution, @NotNull Variance variance) {
++        switch (variance) {
++            case INVARIANT:
++                // for invariant, can replace only when they're equal
++                if (type.equals(substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case IN_VARIANCE:
++                // for covariant (e.g. function parameter), can replace type with any of its supertypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(type, substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case OUT_VARIANCE:
++                // for contravariant (e.g. function return value), can replace type with any of its subtypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(substitution.getForType(), type)) {
++                    return substitution.getByType();
++                }
++                break;
++        }
++
++        List<TypeProjection> newArguments = new ArrayList<TypeProjection>();
++        List<TypeParameterDescriptor> typeParameters = type.getConstructor().getParameters();
++        int i = 0;
++        for (TypeProjection projection : type.getArguments()) {
++            TypeParameterDescriptor typeParameter = typeParameters.get(i);
++            JetType newArgument = substituteType(projection.getType(), substitution, typeParameter.getVariance());
++            newArguments.add(new TypeProjection(Variance.INVARIANT, newArgument));
++            i++;
++        }
++        return new JetTypeImpl(type.getAnnotations(), type.getConstructor(),
++                               type.isNullable(), newArguments, type.getMemberScope());
++    }
++
++    private static boolean containsType(JetType outer, JetType inner) {
++        if (outer.equals(inner)) {
++            return true;
++        }
++
++        for (TypeProjection projection : outer.getArguments()) {
++            if (containsType(projection.getType(), inner)) {
++                return true;
++            }
++        }
++
++        return false;
++    }
++
++    @NotNull
++    private static String renderDescriptor(
++            @NotNull DeclarationDescriptor declarationDescriptor,
++            @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap,
++            boolean fq
++    ) {
++        if (declarationDescriptor instanceof TypeParameterDescriptor) {
++            String replacement = typeParameterNameMap.get(declarationDescriptor);
++            return replacement == null ? declarationDescriptor.getName().getName() : replacement;
++        } else {
++            return fq ? DescriptorUtils.getFQName(declarationDescriptor).getFqName() : declarationDescriptor.getName().getName();
++        }
++    }
++
++    @NotNull
++    private static String renderDescriptor(@NotNull DeclarationDescriptor declarationDescriptor, boolean fq) {
++        return renderDescriptor(declarationDescriptor, Collections.<TypeParameterDescriptor, String>emptyMap(), fq);
++    }
++
++    private static String renderType(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap, boolean fq) {
++        List<TypeProjection> projections = type.getArguments();
++        DeclarationDescriptor declarationDescriptor = type.getConstructor().getDeclarationDescriptor();
++        assert declarationDescriptor != null;
++        if (projections.isEmpty()) {
++            return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq);
++        }
++
++        List<String> arguments = new ArrayList<String>();
++        for (TypeProjection projection : projections) {
++            arguments.add(renderType(projection.getType(), typeParameterNameMap, fq));
++        }
++        return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq) + ""<"" + StringUtil.join(arguments, "", "") + "">"";
++    }
++
++    @NotNull
++    private static String renderTypeShort(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, false);
++    }
++
++    @NotNull
++    private static String renderTypeLong(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, true);
++    }
++
++    @NotNull
++    private static TypeParameterDescriptor[] getTypeParameterNamesNotInScope(
++            @NotNull Collection<? extends TypeParameterDescriptor> typeParameters,
++            @NotNull JetScope scope
++    ) {
++        List<TypeParameterDescriptor> typeParameterNames = new ArrayList<TypeParameterDescriptor>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            ClassifierDescriptor classifier = scope.getClassifier(typeParameter.getName());
++            if (classifier == null || !classifier.equals(typeParameter)) {
++                typeParameterNames.add(typeParameter);
++            }
++        }
++        return typeParameterNames.toArray(new TypeParameterDescriptor[typeParameterNames.size()]);
++    }
++
++    @NotNull
++    private static Set<TypeParameterDescriptor> getTypeParametersInType(@NotNull JetType type) {
++        Set<TypeParameterDescriptor> typeParameters = new LinkedHashSet<TypeParameterDescriptor>();
++        List<TypeProjection> arguments = type.getArguments();
++        if (arguments.isEmpty()) {
++            ClassifierDescriptor descriptor = type.getConstructor().getDeclarationDescriptor();
++            if (descriptor instanceof TypeParameterDescriptor) {
++                typeParameters.add((TypeParameterDescriptor) descriptor);
++            }
++        } else {
++            for (TypeProjection projection : arguments) {
++                typeParameters.addAll(getTypeParametersInType(projection.getType()));
++            }
++        }
++        return typeParameters;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames) {
++        if (existingNames.contains(name)) {
++            int j = 1;
++            while (existingNames.contains(name + j)) j++;
++            name += j;
++        }
++        return name;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames, @NotNull JetScope scope) {
++        if (existingNames.contains(name) || scope.getClassifier(Name.identifier(name)) != null) {
++            int j = 1;
++            while (existingNames.contains(name + j) || scope.getClassifier(Name.identifier(name + j)) != null) j++;
++            name += j;
++        }
++        return name;
++    }
++
++    @NotNull
++    private static JetType[] guessTypeForExpression(@NotNull JetExpression expr, @NotNull BindingContext context) {","If this method returns several types, maybe it should be named `guessTypes...`?
+
+The method is very complex.
+- Reassigning local variables is usually a bad style, because it makes code harder to comprehend and refactor.
+- Combination of reassignments and deep if-else-if is even worse.
+  I offer extracting method guessTypesForDeclaration and use it immediately instead of assigning to declaration. This will allow removing reassigned variable and make each `if` end with `return`, and `else`s will be unnecessary.
+",2013-04-26 11:58:12
+74,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {
++                // file templates
++                int offset = template.getSegmentOffset(0);
++                final JetNamedFunction func = PsiTreeUtil.findElementOfClassAtOffset(containingFile, offset, JetNamedFunction.class, false);
++                assert func != null;
++                final List<JetTypeReference> typeRefsToShorten = new ArrayList<JetTypeReference>();
++
++                ApplicationManager.getApplication().runWriteAction(new Runnable() {
++                    @Override
++                    public void run() {
++                        // file templates
++                        setupFunctionBody(project, func);
++
++                        // change short type names to fully qualified ones (to be shortened below)
++                        setupTypeReferencesForShortening(project, func, typeRefsToShorten, parameterTypeExpressions, returnTypeExpression);
++                    }
++                });
++
++                ReferenceToClassesShortening.compactReferenceToClasses(typeRefsToShorten);
++            }
++        });
++    }
++
++    private Map<TypeParameterDescriptor, String> getTypeParameterRenames(JetScope scope) {
++        TypeParameterDescriptor[] receiverTypeParametersNotInScope = selectedReceiverType.getTypeParameters();
++        Set<TypeParameterDescriptor> allTypeParametersNotInScope = new LinkedHashSet<TypeParameterDescriptor>();
++        allTypeParametersNotInScope.addAll(Arrays.asList(receiverTypeParametersNotInScope));
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(parameterTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        if (!isUnit) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(returnTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(allTypeParametersNotInScope);
++        List<String> typeParameterNames = new ArrayList<String>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            typeParameterNames.add(getNextAvailableName(typeParameter.getName().getName(), typeParameterNames, scope));
++        }
++        assert typeParameters.size() == typeParameterNames.size();
++        Map<TypeParameterDescriptor, String> typeParameterNameMap = new HashMap<TypeParameterDescriptor, String>();
++        for (int i = 0; i < typeParameters.size(); i++) {
++            typeParameterNameMap.put(typeParameters.get(i), typeParameterNames.get(i));
++        }
++
++        return typeParameterNameMap;
++    }
++
++    private void setupTypeReferencesForShortening(
++            @NotNull Project project,
++            @NotNull JetNamedFunction func,
++            @NotNull List<JetTypeReference> typeRefsToShorten,
++            @NotNull TypeExpression[] parameterTypeExpressions,
++            @Nullable TypeExpression returnTypeExpression
++    ) {
++        if (isExtension) {
++            JetTypeReference receiverTypeRef =
++                    JetPsiFactory.createType(project, renderTypeLong(selectedReceiverType.getType(), typeParameterNameMap));
++            replaceWithLongerName(project, receiverTypeRef, selectedReceiverType.getType());
++
++            receiverTypeRef = func.getReceiverTypeRef();
++            if (receiverTypeRef != null) {
++                typeRefsToShorten.add(receiverTypeRef);
++            }
++        }
++
++        if (!isUnit) {
++            assert returnTypeExpression != null;
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                JetType returnType = returnTypeExpression.getTypeFromSelection(returnTypeRef.getText());
++                if (returnType != null) { // user selected a given type
++                    replaceWithLongerName(project, returnTypeRef, returnType);
++                    returnTypeRef = func.getReturnTypeRef();
++                    assert returnTypeRef != null;
++                    typeRefsToShorten.add(returnTypeRef);
++                }
++            }
++        }
++
++        List<JetParameter> valueParameters = func.getValueParameters();
++        List<Integer> parameterIndicesToShorten = new ArrayList<Integer>();
++        assert valueParameters.size() == parameterTypeExpressions.length;
++        for (int i = 0; i < valueParameters.size(); i++) {
++            JetParameter parameter = valueParameters.get(i);
++            JetTypeReference parameterTypeRef = parameter.getTypeReference();
++            if (parameterTypeRef != null) {
++                JetType parameterType = parameterTypeExpressions[i].getTypeFromSelection(parameterTypeRef.getText());
++                if (parameterType != null) {
++                    replaceWithLongerName(project, parameterTypeRef, parameterType);
++                    parameterIndicesToShorten.add(i);
++                }
++            }
++        }
++        valueParameters = func.getValueParameters();
++        for (int i : parameterIndicesToShorten) {
++            JetTypeReference parameterTypeRef = valueParameters.get(i).getTypeReference();
++            if (parameterTypeRef != null) {
++                typeRefsToShorten.add(parameterTypeRef);
++            }
++        }
++    }
++
++    private void setupFunctionBody(@NotNull Project project, @NotNull JetNamedFunction func) {
++        FileTemplate fileTemplate = FileTemplateManager.getInstance().getCodeTemplate(TEMPLATE_FROM_USAGE_METHOD_BODY);
++        Properties properties = new Properties();
++        if (isUnit) {
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, ""Unit"");
++        } else {
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            assert returnTypeRef != null;
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, returnTypeRef.getText());
++        }
++        properties.setProperty(FileTemplate.ATTRIBUTE_CLASS_NAME, DescriptorUtils.getFQName(ownerClassDescriptor).getFqName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_SIMPLE_CLASS_NAME, ownerClassDescriptor.getName().getName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_METHOD_NAME, methodName);
++
++        @NonNls String bodyText;
++        try {
++            bodyText = fileTemplate.getText(properties);
++        } catch (ProcessCanceledException e) {
++            throw e;
++        } catch (Exception e) {
++            throw new IncorrectOperationException(""Failed to parse file template"", e);
++        }
++        JetExpression newBodyExpression = JetPsiFactory.createFunctionBody(project, bodyText);
++        JetExpression oldBodyExpression = func.getBodyExpression();
++        assert oldBodyExpression != null;
++        oldBodyExpression.replace(newBodyExpression);
++    }
++
++    @NotNull
++    private TypeExpression setupReturnTypeTemplate(@NotNull TemplateBuilder builder, @NotNull JetNamedFunction func) {
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        assert returnTypeRef != null;
++        TypeExpression returnTypeExpression = new TypeExpression(returnType);
++        builder.replaceElement(returnTypeRef, returnTypeExpression);
++        return returnTypeExpression;
++    }
++
++    @NotNull
++    private TypeParameterListExpression setupTypeParameterListTemplate(@NotNull TemplateBuilderImpl builder, @NotNull JetNamedFunction func) {
++        Map<String, String[]> typeParameterMap = new HashMap<String, String[]>();
++        String[] receiverTypeParameterNames = selectedReceiverType.getTypeParameterNames();
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                typeParameterMap.put(parameterTypeCandidate.getRenderedType(), parameterTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        if (returnTypeRef != null) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                typeParameterMap.put(returnTypeCandidate.getRenderedType(), returnTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        builder.replaceElement(func, TextRange.create(3, 3), TYPE_PARAMETER_LIST_VARIABLE_NAME, null, false); // ((3, 3) is after ""fun"")
++        return new TypeParameterListExpression(receiverTypeParameterNames, typeParameterMap);
++    }
++
++    private TypeExpression[] setupParameterTypeTemplates(@NotNull Project project, @NotNull TemplateBuilder builder,
++            @NotNull JetParameterList parameterList) {
++        List<JetParameter> jetParameters = parameterList.getParameters();
++        assert jetParameters.size() == parameters.size();
++        TypeExpression[] parameterTypeExpressions = new TypeExpression[parameters.size()];
++        JetNameValidator dummyValidator = new DummyJetNameValidator(project);
++        for (int i = 0; i < parameters.size(); i++) {
++            Parameter parameter = parameters.get(i);
++            JetParameter jetParameter = jetParameters.get(i);
++
++            // add parameter type to the template
++            parameterTypeExpressions[i] = new TypeExpression(parameter.getType());
++            JetTypeReference parameterTypeRef = jetParameter.getTypeReference();
++            assert parameterTypeRef != null;
++            builder.replaceElement(parameterTypeRef, parameterTypeExpressions[i]);
++
++            // add parameter name to the template
++            String[] possibleNamesFromExpression = parameter.getType().getPossibleNamesFromExpression();
++            String preferredName = parameter.getPreferredName();
++            String[] possibleNames;
++            if (preferredName != null) {
++                possibleNames = new String[possibleNamesFromExpression.length + 1];
++                possibleNames[0] = preferredName;
++                System.arraycopy(possibleNamesFromExpression, 0, possibleNames, 1, possibleNamesFromExpression.length);
++            } else {
++                possibleNames = possibleNamesFromExpression;
++            }
++
++            // figure out suggested names for each type option
++            Map<String, String[]> parameterTypeToNamesMap = new HashMap<String, String[]>();
++            for (TypeCandidate typeCandidate : parameter.getType().getTypeCandidates()) {
++                String[] suggestedNames = JetNameSuggester.suggestNamesForType(typeCandidate.getType(), dummyValidator);
++                parameterTypeToNamesMap.put(typeCandidate.getRenderedType(), suggestedNames);
++            }
++
++            // add expression to builder
++            Expression parameterNameExpression = new ParameterNameExpression(possibleNames, parameterTypeToNamesMap);
++            PsiElement parameterNameIdentifier = jetParameter.getNameIdentifier();
++            assert parameterNameIdentifier != null;
++            builder.replaceElement(parameterNameIdentifier, parameterNameExpression);
++        }
++        return parameterTypeExpressions;
++    }
++
++    private void replaceWithLongerName(@NotNull Project project, @NotNull JetTypeReference typeRef, @NotNull JetType type) {
++        JetTypeReference fullyQualifiedReceiverTypeRef = JetPsiFactory.createType(project, renderTypeLong(type, typeParameterNameMap));
++        typeRef.replace(fullyQualifiedReceiverTypeRef);
++    }
++
++    @NotNull
++    private static JetType substituteType(@NotNull JetType type, @NotNull TypeSubstitution substitution, @NotNull Variance variance) {
++        switch (variance) {
++            case INVARIANT:
++                // for invariant, can replace only when they're equal
++                if (type.equals(substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case IN_VARIANCE:
++                // for covariant (e.g. function parameter), can replace type with any of its supertypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(type, substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case OUT_VARIANCE:
++                // for contravariant (e.g. function return value), can replace type with any of its subtypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(substitution.getForType(), type)) {
++                    return substitution.getByType();
++                }
++                break;
++        }
++
++        List<TypeProjection> newArguments = new ArrayList<TypeProjection>();
++        List<TypeParameterDescriptor> typeParameters = type.getConstructor().getParameters();
++        int i = 0;
++        for (TypeProjection projection : type.getArguments()) {
++            TypeParameterDescriptor typeParameter = typeParameters.get(i);
++            JetType newArgument = substituteType(projection.getType(), substitution, typeParameter.getVariance());
++            newArguments.add(new TypeProjection(Variance.INVARIANT, newArgument));
++            i++;
++        }
++        return new JetTypeImpl(type.getAnnotations(), type.getConstructor(),
++                               type.isNullable(), newArguments, type.getMemberScope());
++    }
++
++    private static boolean containsType(JetType outer, JetType inner) {
++        if (outer.equals(inner)) {
++            return true;
++        }
++
++        for (TypeProjection projection : outer.getArguments()) {
++            if (containsType(projection.getType(), inner)) {
++                return true;
++            }
++        }
++
++        return false;
++    }
++
++    @NotNull
++    private static String renderDescriptor(
++            @NotNull DeclarationDescriptor declarationDescriptor,
++            @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap,
++            boolean fq
++    ) {
++        if (declarationDescriptor instanceof TypeParameterDescriptor) {
++            String replacement = typeParameterNameMap.get(declarationDescriptor);
++            return replacement == null ? declarationDescriptor.getName().getName() : replacement;
++        } else {
++            return fq ? DescriptorUtils.getFQName(declarationDescriptor).getFqName() : declarationDescriptor.getName().getName();
++        }
++    }
++
++    @NotNull
++    private static String renderDescriptor(@NotNull DeclarationDescriptor declarationDescriptor, boolean fq) {
++        return renderDescriptor(declarationDescriptor, Collections.<TypeParameterDescriptor, String>emptyMap(), fq);
++    }
++
++    private static String renderType(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap, boolean fq) {
++        List<TypeProjection> projections = type.getArguments();
++        DeclarationDescriptor declarationDescriptor = type.getConstructor().getDeclarationDescriptor();
++        assert declarationDescriptor != null;
++        if (projections.isEmpty()) {
++            return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq);
++        }
++
++        List<String> arguments = new ArrayList<String>();
++        for (TypeProjection projection : projections) {
++            arguments.add(renderType(projection.getType(), typeParameterNameMap, fq));
++        }
++        return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq) + ""<"" + StringUtil.join(arguments, "", "") + "">"";
++    }
++
++    @NotNull
++    private static String renderTypeShort(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, false);
++    }
++
++    @NotNull
++    private static String renderTypeLong(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, true);
++    }
++
++    @NotNull
++    private static TypeParameterDescriptor[] getTypeParameterNamesNotInScope(
++            @NotNull Collection<? extends TypeParameterDescriptor> typeParameters,
++            @NotNull JetScope scope
++    ) {
++        List<TypeParameterDescriptor> typeParameterNames = new ArrayList<TypeParameterDescriptor>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            ClassifierDescriptor classifier = scope.getClassifier(typeParameter.getName());
++            if (classifier == null || !classifier.equals(typeParameter)) {
++                typeParameterNames.add(typeParameter);
++            }
++        }
++        return typeParameterNames.toArray(new TypeParameterDescriptor[typeParameterNames.size()]);
++    }
++
++    @NotNull
++    private static Set<TypeParameterDescriptor> getTypeParametersInType(@NotNull JetType type) {
++        Set<TypeParameterDescriptor> typeParameters = new LinkedHashSet<TypeParameterDescriptor>();
++        List<TypeProjection> arguments = type.getArguments();
++        if (arguments.isEmpty()) {
++            ClassifierDescriptor descriptor = type.getConstructor().getDeclarationDescriptor();
++            if (descriptor instanceof TypeParameterDescriptor) {
++                typeParameters.add((TypeParameterDescriptor) descriptor);
++            }
++        } else {
++            for (TypeProjection projection : arguments) {
++                typeParameters.addAll(getTypeParametersInType(projection.getType()));
++            }
++        }
++        return typeParameters;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames) {
++        if (existingNames.contains(name)) {
++            int j = 1;
++            while (existingNames.contains(name + j)) j++;
++            name += j;
++        }
++        return name;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames, @NotNull JetScope scope) {
++        if (existingNames.contains(name) || scope.getClassifier(Name.identifier(name)) != null) {
++            int j = 1;
++            while (existingNames.contains(name + j) || scope.getClassifier(Name.identifier(name + j)) != null) j++;
++            name += j;
++        }
++        return name;
++    }
++
++    @NotNull
++    private static JetType[] guessTypeForExpression(@NotNull JetExpression expr, @NotNull BindingContext context) {
++        JetType type = context.get(BindingContext.EXPRESSION_TYPE, expr);
++        JetNamedDeclaration declaration = null;
++
++        // if we know the actual type of the expression
++        if (type != null) {
++            return new JetType[] {type};
++        }
++
++        // expression has an expected type
++        else if ((type = context.get(BindingContext.EXPECTED_EXPRESSION_TYPE, expr)) != null) {
++            return new JetType[] {type};
++        }
++
++        // expression itself is a type assertion
++        else if (expr instanceof JetTypeConstraint) { // expression itself is a type assertion
++            JetTypeConstraint constraint = (JetTypeConstraint) expr;
++            return new JetType[] {context.get(BindingContext.TYPE, constraint.getBoundTypeReference())};
++        }
++
++        // expression is on the left side of a type assertion
++        else if (expr.getParent() instanceof JetTypeConstraint) {
++            JetTypeConstraint constraint = (JetTypeConstraint) expr.getParent();
++            return new JetType[] {context.get(BindingContext.TYPE, constraint.getBoundTypeReference())};
++        }
++
++        // expression is on the lhs of a multi-declaration
++        else if (expr instanceof JetMultiDeclarationEntry) {
++            JetMultiDeclarationEntry entry = (JetMultiDeclarationEntry) expr;
++            JetTypeReference typeRef = entry.getTypeRef();
++            if (typeRef != null) { // and has a specified type
++                return new JetType[] {context.get(BindingContext.TYPE, typeRef)};","Why not just guess by declaration immediately, without checking `BindingContext.TYPE`? Wouldn't it be enough?
+",2013-04-26 11:58:54
+75,"@@ -0,0 +1,1391 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.lookup.LookupElement;
++import com.intellij.codeInsight.lookup.LookupElementBuilder;
++import com.intellij.codeInsight.template.*;
++import com.intellij.codeInsight.template.impl.TemplateImpl;
++import com.intellij.codeInsight.template.impl.Variable;
++import com.intellij.ide.fileTemplates.FileTemplate;
++import com.intellij.ide.fileTemplates.FileTemplateManager;
++import com.intellij.ide.util.PsiElementListCellRenderer;
++import com.intellij.openapi.application.ApplicationManager;
++import com.intellij.openapi.command.CommandProcessor;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.progress.ProcessCanceledException;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.ui.popup.PopupChooserBuilder;
++import com.intellij.openapi.util.TextRange;
++import com.intellij.openapi.util.text.StringUtil;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.psi.search.SearchScope;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.psi.SearchUtils;
++import com.intellij.ui.components.JBList;
++import com.intellij.util.ArrayUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NonNls;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.descriptors.impl.MutableClassDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.BindingContextUtils;
++import org.jetbrains.jet.lang.resolve.DescriptorUtils;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.resolve.scopes.JetScope;
++import org.jetbrains.jet.lang.types.*;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.codeInsight.ReferenceToClassesShortening;
++import org.jetbrains.jet.plugin.presentation.JetLightClassListCellRenderer;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++import org.jetbrains.jet.plugin.refactoring.JetNameSuggester;
++import org.jetbrains.jet.plugin.refactoring.JetNameValidator;
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import javax.swing.*;
++import java.util.*;
++import java.util.regex.Matcher;
++import java.util.regex.Pattern;
++
++public class CreateMethodFromUsageFix extends CreateFromUsageFixBase {
++    private static final String TYPE_PARAMETER_LIST_VARIABLE_NAME = ""typeParameterList"";
++    private static final String TEMPLATE_FROM_USAGE_METHOD_BODY = ""New Kotlin Method Body.kt"";
++    private static final Pattern COMPONENT_FUNCTION_PATTERN = Pattern.compile(""^component(\\d+)$"");
++
++    /**
++     * Represents a single choice for a type (e.g. parameter type or return type).
++     */
++    private static class TypeCandidate {
++        private final JetType type;
++        private final TypeParameterDescriptor[] typeParameters;
++        private String renderedType;
++        private String[] typeParameterNames;
++
++        public TypeCandidate(@NotNull JetType type) {
++            this.type = type;
++            Set<TypeParameterDescriptor> typeParametersInType = getTypeParametersInType(type);
++            typeParameters = typeParametersInType.toArray(new TypeParameterDescriptor[typeParametersInType.size()]);
++            renderedType = renderTypeShort(type, Collections.<TypeParameterDescriptor, String>emptyMap());
++        }
++
++        public TypeCandidate(@NotNull JetType type, @NotNull JetScope scope) {
++            this.type = type;
++            typeParameters = getTypeParameterNamesNotInScope(getTypeParametersInType(type), scope);
++        }
++
++        public void render(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            renderedType = renderTypeShort(type, typeParameterNameMap);
++            typeParameterNames = new String[typeParameters.length];
++            int i = 0;
++            for (TypeParameterDescriptor typeParameter : typeParameters) {
++                typeParameterNames[i] = typeParameterNameMap.get(typeParameter);
++                i++;
++            }
++        }
++
++        @NotNull JetType getType() {
++            return type;
++        }
++
++        @NotNull
++        public String getRenderedType() {
++            assert renderedType != null : ""call render() first"";
++            return renderedType;
++        }
++
++        @NotNull
++        public String[] getTypeParameterNames() {
++            assert typeParameterNames != null : ""call render() first"";
++            return typeParameterNames;
++        }
++
++        @NotNull
++        public TypeParameterDescriptor[] getTypeParameters() {
++            return typeParameters;
++        }
++    }
++
++    /**
++     * Represents a concrete type or a set of types yet to be inferred from an expression.
++     */
++    private static class TypeOrExpressionThereof {
++        private final JetExpression expressionOfType;
++        private final JetType type;
++        private final Variance variance;
++        private TypeCandidate[] typeCandidates;
++        private String[] cachedNameCandidatesFromExpression;
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType) {
++            this(expressionOfType, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetExpression expressionOfType, Variance variance) {
++            this(expressionOfType, null, variance);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type) {
++            this(type, Variance.IN_VARIANCE);
++        }
++
++        public TypeOrExpressionThereof(@NotNull JetType type, Variance variance) {
++            this(null, type, variance);
++        }
++
++        private TypeOrExpressionThereof(@Nullable JetExpression expressionOfType, @Nullable JetType type, Variance variance) {
++            this.expressionOfType = expressionOfType;
++            this.type = type;
++            this.variance = variance;
++        }
++
++        public boolean isType() {
++            return this.type != null;
++        }
++
++        @NotNull
++        public JetType getType() {
++            assert this.type != null;
++            return this.type;
++        }
++
++        @NotNull
++        private List<JetType> getPossibleTypes(BindingContext context) {
++            List<JetType> types = new ArrayList<JetType>();
++            if (isType()) {
++                assert type != null : ""!isType() means type == null && expressionOfType != null"";
++                types.add(type);
++                if (variance == Variance.IN_VARIANCE) {
++                    types.addAll(TypeUtils.getAllSupertypes(type));
++                }
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                for (JetType type : guessTypeForExpression(expressionOfType, context)) {
++                    types.add(type);
++                    if (variance == Variance.IN_VARIANCE) {
++                        types.addAll(TypeUtils.getAllSupertypes(type));
++                    }
++                }
++            }
++            return types;
++        }
++
++        public void computeTypeCandidates(@NotNull BindingContext context) {
++            Collection<JetType> types = getPossibleTypes(context);
++
++            typeCandidates = new TypeCandidate[types.size()];
++            int i = 0;
++            for (JetType type : types) {
++                typeCandidates[i] = new TypeCandidate(type);
++                i++;
++            }
++        }
++
++        public void computeTypeCandidates(
++                @NotNull BindingContext context,
++                @NotNull TypeSubstitution[] substitutions,
++                @NotNull JetScope scope
++        ) {
++            List<JetType> types = getPossibleTypes(context);
++            Collections.reverse(types); // reverse and reverse back later, so that things added below are added at the front
++
++            Set<JetType> newTypes = new LinkedHashSet<JetType>(types);
++            for (TypeSubstitution substitution : substitutions) { // each substitution can be applied or not, so we offer all options
++                List<JetType> toAdd = new ArrayList<JetType>();
++                List<JetType> toRemove = new ArrayList<JetType>();
++                for (JetType type : newTypes) {
++                    toAdd.add(substituteType(type, substitution, variance));
++                    // substitution.byType are type arguments, but they cannot already occur in the type before substitution
++                    if (containsType(type, substitution.getByType())) {
++                        toRemove.add(type);
++                    }
++                }
++                newTypes.addAll(toAdd);
++                newTypes.removeAll(toRemove);
++            }
++
++            if (newTypes.isEmpty()) {
++                newTypes.add(KotlinBuiltIns.getInstance().getAnyType());
++            }
++
++            typeCandidates = new TypeCandidate[newTypes.size()];
++            int i = typeCandidates.length - 1; // reverse order (see explanation above)
++            for (JetType type : newTypes) {
++                typeCandidates[i] = new TypeCandidate(type, scope);
++                i--;
++            }
++        }
++
++        @NotNull
++        public TypeCandidate[] getTypeCandidates() {
++            assert typeCandidates != null : ""call computeTypeCandidates() first"";
++            return typeCandidates;
++        }
++
++        public void renderTypeCandidates(@NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++            for (TypeCandidate candidate : typeCandidates) {
++                candidate.render(typeParameterNameMap);
++            }
++        }
++
++        @NotNull
++        public String[] getPossibleNamesFromExpression() {
++            if (cachedNameCandidatesFromExpression != null) return cachedNameCandidatesFromExpression;
++            if (isType()) {
++                cachedNameCandidatesFromExpression = ArrayUtil.EMPTY_STRING_ARRAY;
++            } else {
++                assert expressionOfType != null : ""!isType() means type == null && expressionOfType != null"";
++                JetNameValidator dummyValidator = new DummyJetNameValidator(expressionOfType.getProject());
++                cachedNameCandidatesFromExpression = JetNameSuggester.suggestNamesForExpression(expressionOfType, dummyValidator);
++            }
++            return cachedNameCandidatesFromExpression;
++        }
++    }
++
++    /**
++     * Encapsulates information about a method parameter that is going to be created.
++     */
++    private static class Parameter {
++        private final String preferredName;
++        private final TypeOrExpressionThereof type;
++
++        public Parameter(@Nullable(""no preferred name"") String preferredName, TypeOrExpressionThereof type) {
++            this.preferredName = preferredName;
++            this.type = type;
++        }
++
++        public String getPreferredName() {
++            return preferredName;
++        }
++
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++    }
++
++    /**
++     * Special <code>Expression</code> for parameter names based on its type.
++     */
++    private static class ParameterNameExpression extends Expression {
++        private final String[] names;
++        private final Map<String, String[]> parameterTypeToNamesMap;
++
++        public ParameterNameExpression(@NotNull String[] names, @NotNull Map<String, String[]> parameterTypeToNamesMap) {
++            for (String name : names) {
++                assert name != null && !name.isEmpty();
++            }
++            this.names = names;
++            this.parameterTypeToNamesMap = parameterTypeToNamesMap;
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            Set<String> names = new LinkedHashSet<String>();
++            Collections.addAll(names, this.names);
++
++            // find the parameter list
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) return new LookupElement[0];
++            JetParameterList parameterList = func.getValueParameterList();
++            assert parameterList != null;
++
++            // add names based on selected type
++            JetParameter parameter = PsiTreeUtil.getParentOfType(elementAt, JetParameter.class);
++            if (parameter != null) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] suggestedNamesBasedOnType = parameterTypeToNamesMap.get(parameterTypeRef.getText());
++                    if (suggestedNamesBasedOnType != null) {
++                        Collections.addAll(names, suggestedNamesBasedOnType);
++                    }
++                }
++            }
++
++            // remember other parameter names for later use
++            Set<String> parameterNames = new HashSet<String>();
++            for (JetParameter jetParameter : parameterList.getParameters()) {
++                if (jetParameter == parameter || jetParameter.getName() == null) continue;
++                parameterNames.add(jetParameter.getName());
++            }
++
++            // add fallback parameter name
++            if (names.isEmpty()) {
++                names.add(""arg"");
++            }
++
++            // ensure there are no conflicts
++            List<LookupElement> lookupElements = new ArrayList<LookupElement>();
++            for (String name : names) {
++                name = getNextAvailableName(name, parameterNames);
++                lookupElements.add(LookupElementBuilder.create(name));
++            }
++
++            // create and return
++            return lookupElements.toArray(new LookupElement[lookupElements.size()]);
++        }
++    }
++
++    /**
++     * An <code>Expression</code> for type references.
++     */
++    private static class TypeExpression extends Expression {
++        private final TypeOrExpressionThereof type;
++        private @NotNull LookupElement[] cachedLookupElements;
++
++        public TypeExpression(@NotNull TypeOrExpressionThereof type) {
++            this.type = type;
++            TypeCandidate[] candidates = type.getTypeCandidates();
++            cachedLookupElements = new LookupElement[candidates.length];
++            for (int i = 0; i < candidates.length; i++) {
++                cachedLookupElements[i] = LookupElementBuilder.create(candidates[i], candidates[i].getRenderedType());
++            }
++        }
++
++        @Nullable
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            LookupElement[] lookupItems = calculateLookupItems(context);
++            if (lookupItems.length == 0) return new TextResult("""");
++
++            return new TextResult(lookupItems[0].getLookupString());
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return cachedLookupElements;
++        }
++
++        @NotNull
++        public TypeOrExpressionThereof getType() {
++            return type;
++        }
++
++        @Nullable(""can't be found"")
++        public JetType getTypeFromSelection(@NotNull String selection) {
++            TypeCandidate[] options = type.getTypeCandidates();
++            for (TypeCandidate option : options) {
++                if (option.getRenderedType().equals(selection)) {
++                    return option.getType();
++                }
++            }
++            return null;
++        }
++    }
++
++    /**
++     * A sort-of dummy <code>Expression</code> for parameter lists, to allow us to update the parameter list as the user makes selections.
++     */
++    private static class TypeParameterListExpression extends Expression {
++        private final String[] typeParameterNamesFromReceiverType;
++        private final Map<String, String[]> parameterTypeToTypeParameterNamesMap;
++
++        public TypeParameterListExpression(
++                @NotNull String[] typeParameterNamesFromReceiverType,
++                @NotNull Map<String, String[]> typeParametersMap
++        ) {
++            this.typeParameterNamesFromReceiverType = typeParameterNamesFromReceiverType;
++            this.parameterTypeToTypeParameterNamesMap = typeParametersMap;
++        }
++
++        @NotNull
++        @Override
++        public Result calculateResult(ExpressionContext context) {
++            Project project = context.getProject();
++            int offset = context.getStartOffset();
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            Editor editor = context.getEditor();
++            assert editor != null;
++            PsiFile file = PsiDocumentManager.getInstance(project).getPsiFile(editor.getDocument());
++            assert file != null && file instanceof JetFile;
++            PsiElement elementAt = file.findElementAt(offset);
++            JetFunction func = PsiTreeUtil.getParentOfType(elementAt, JetFunction.class);
++            if (func == null) {
++                return new TextResult("""");
++            }
++            List<JetParameter> parameters = func.getValueParameters();
++
++            Set<String> typeParameterNames = new LinkedHashSet<String>();
++            Collections.addAll(typeParameterNames, typeParameterNamesFromReceiverType);
++            for (JetParameter parameter : parameters) {
++                JetTypeReference parameterTypeRef = parameter.getTypeReference();
++                if (parameterTypeRef != null) {
++                    String[] typeParameterNamesFromParameter = parameterTypeToTypeParameterNamesMap.get(parameterTypeRef.getText());
++                    if (typeParameterNamesFromParameter != null) {
++                        Collections.addAll(typeParameterNames, typeParameterNamesFromParameter);
++                    }
++                }
++            }
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                String[] typeParameterNamesFromReturnType = parameterTypeToTypeParameterNamesMap.get(returnTypeRef.getText());
++                if (typeParameterNamesFromReturnType != null) {
++                    Collections.addAll(typeParameterNames, typeParameterNamesFromReturnType);
++                }
++            }
++
++            return typeParameterNames.isEmpty()
++                    ? new TextResult("""")
++                    : new TextResult("" <"" + StringUtil.join(typeParameterNames, "", "") + "">"");
++        }
++
++        @Nullable
++        @Override
++        public Result calculateQuickResult(ExpressionContext context) {
++            return calculateResult(context);
++        }
++
++        @NotNull
++        @Override
++        public LookupElement[] calculateLookupItems(ExpressionContext context) {
++            return new LookupElement[0]; // do not offer the user any choices
++        }
++    }
++
++    /**
++     * A <code>JetNameValidator</code> that always succeeds.
++     */
++    private static class DummyJetNameValidator implements JetNameValidator {
++        private final Project project;
++
++        public DummyJetNameValidator(Project project) {
++            this.project = project;
++        }
++
++        @Nullable
++        @Override
++        public String validateName(String name) {
++            return name;
++        }
++
++        @Override
++        public Project getProject() {
++            return project;
++        }
++    }
++
++    /**
++     * Encapsulates a single type substitution of a <code>JetType</code> by another <code>JetType</code>.
++     */
++    private static class TypeSubstitution {
++        private final JetType forType;
++        private final JetType byType;
++
++        private TypeSubstitution(JetType forType, JetType byType) {
++            this.forType = forType;
++            this.byType = byType;
++        }
++
++        private JetType getForType() {
++            return forType;
++        }
++
++        private JetType getByType() {
++            return byType;
++        }
++    }
++
++    private final String methodName;
++    private final TypeOrExpressionThereof ownerType;
++    private final TypeOrExpressionThereof returnType;
++    private final List<Parameter> parameters;
++
++    private boolean isUnit;
++    private boolean isExtension;
++    private JetFile currentFile;
++    private JetFile containingFile;
++    private Editor currentFileEditor;
++    private Editor containingFileEditor;
++    private BindingContext currentFileContext;
++    private JetClass ownerClass;
++    private ClassDescriptor ownerClassDescriptor;
++    private TypeCandidate selectedReceiverType;
++    private Map<TypeParameterDescriptor, String> typeParameterNameMap;
++
++    public CreateMethodFromUsageFix(@NotNull PsiElement element, @NotNull TypeOrExpressionThereof ownerType, @NotNull String methodName,
++            @NotNull TypeOrExpressionThereof returnType, @NotNull List<Parameter> parameters) {
++        super(element);
++        this.methodName = methodName;
++        this.ownerType = ownerType;
++        this.returnType = returnType;
++        this.parameters = parameters;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.method.from.usage"", methodName);
++    }
++
++    @Override
++    public void invoke(@NotNull final Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        assert file != null && file instanceof JetFile;
++        currentFile = (JetFile) file;
++        currentFileEditor = editor;
++        currentFileContext = AnalyzerFacadeWithCache.analyzeFileWithCache(currentFile).getBindingContext();
++
++        ownerType.computeTypeCandidates(currentFileContext);
++        TypeCandidate[] ownerTypeCandidates = ownerType.getTypeCandidates();
++        assert ownerTypeCandidates.length > 0;
++        if (ownerTypeCandidates.length == 1 || ApplicationManager.getApplication().isUnitTestMode()) {
++            selectedReceiverType = ownerTypeCandidates[0];
++            doInvoke(project);
++        } else {
++            // class selection
++            List<String> options = new ArrayList<String>();
++            final Map<String, TypeCandidate> optionToTypeMap = new HashMap<String, TypeCandidate>();
++            for (TypeCandidate ownerTypeCandidate : ownerTypeCandidates) {
++                ClassifierDescriptor possibleClassDescriptor = ownerTypeCandidate.getType().getConstructor().getDeclarationDescriptor();
++                if (possibleClassDescriptor != null) {
++                    String className = DescriptorRenderer.SHORT_NAMES_IN_TYPES.renderType(possibleClassDescriptor.getDefaultType());
++                    DeclarationDescriptor namespaceDescriptor = possibleClassDescriptor.getContainingDeclaration();
++                    String namespace = renderDescriptor(namespaceDescriptor, true);
++                    String option = className + "" ("" + namespace + "")"";
++                    options.add(option);
++                    optionToTypeMap.put(option, ownerTypeCandidate);
++                }
++            }
++
++            final JList list = new JBList(options);
++            PsiElementListCellRenderer renderer = new JetLightClassListCellRenderer();
++            list.setSelectionMode(ListSelectionModel.SINGLE_SELECTION);
++            list.setCellRenderer(renderer);
++            PopupChooserBuilder builder = new PopupChooserBuilder(list);
++            renderer.installSpeedSearch(builder);
++
++            Runnable runnable = new Runnable() {
++                @Override
++                public void run() {
++                    int index = list.getSelectedIndex();
++                    if (index < 0) return;
++                    String option = (String) list.getSelectedValue();
++                    selectedReceiverType = optionToTypeMap.get(option);
++                    CommandProcessor.getInstance().executeCommand(project, new Runnable() {
++                        @Override
++                        public void run() {
++                            doInvoke(project);
++                        }
++                    }, getText(), null);
++                }
++            };
++
++            builder.setTitle(JetBundle.message(""choose.target.class.or.trait.title""))
++                   .setItemChoosenCallback(runnable)
++                   .createPopup()
++                   .showInBestPositionFor(currentFileEditor);
++        }
++    }
++
++    private void doInvoke(@NotNull final Project project) {
++        // gather relevant information
++        ClassifierDescriptor ownerTypeDescriptor = selectedReceiverType.getType().getConstructor().getDeclarationDescriptor();
++        assert ownerTypeDescriptor != null && ownerTypeDescriptor instanceof ClassDescriptor;
++        ownerClassDescriptor = (ClassDescriptor) ownerTypeDescriptor;
++        JetType receiverType = ownerClassDescriptor.getDefaultType();
++        PsiElement typeDeclaration = BindingContextUtils.classDescriptorToDeclaration(currentFileContext, ownerClassDescriptor);
++        if (typeDeclaration != null && typeDeclaration instanceof JetClass) {
++            ownerClass = (JetClass) typeDeclaration;
++            isExtension = !ownerClass.isWritable();
++        } else {
++            isExtension = true;
++        }
++        isUnit = returnType.isType() && isUnit(returnType.getType());
++
++        JetScope scope;
++        if (isExtension) {
++            NamespaceDescriptor namespaceDescriptor = currentFileContext.get(BindingContext.FILE_TO_NAMESPACE, currentFile);
++            assert namespaceDescriptor != null;
++            scope = namespaceDescriptor.getMemberScope();
++        } else {
++            assert ownerClassDescriptor instanceof MutableClassDescriptor;
++            scope = ((MutableClassDescriptor) ownerClassDescriptor).getScopeForMemberResolution();
++        }
++
++        // figure out type substitutions for type parameters
++        List<TypeProjection> classTypeParameters = receiverType.getArguments();
++        List<TypeProjection> ownerTypeArguments = selectedReceiverType.getType().getArguments();
++        assert ownerTypeArguments.size() == classTypeParameters.size();
++        TypeSubstitution[] substitutions = new TypeSubstitution[classTypeParameters.size()];
++        for (int i = 0; i < substitutions.length; i++) {
++            substitutions[i] = new TypeSubstitution(ownerTypeArguments.get(i).getType(), classTypeParameters.get(i).getType());
++        }
++        for (Parameter parameter : parameters) {
++            parameter.getType().computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++        if (!isUnit) {
++            returnType.computeTypeCandidates(currentFileContext, substitutions, scope);
++        }
++
++        // now that we have done substitutions, we can throw it away
++        selectedReceiverType = new TypeCandidate(receiverType, scope);
++
++        // figure out type parameter renames to avoid conflicts
++        typeParameterNameMap = getTypeParameterRenames(scope);
++        for (Parameter parameter : parameters) {
++            parameter.getType().renderTypeCandidates(typeParameterNameMap);
++        }
++        if (!isUnit) {
++            returnType.renderTypeCandidates(typeParameterNameMap);
++        }
++        selectedReceiverType.render(typeParameterNameMap);
++
++        ApplicationManager.getApplication().runWriteAction(new Runnable() {
++            @Override
++            public void run() {
++                JetNamedFunction func = createFunctionSkeleton(project);
++                buildAndRunTemplate(project, func);
++            }
++        });
++    }
++
++    private JetNamedFunction createFunctionSkeleton(@NotNull Project project) {
++        JetNamedFunction func;
++        String[] parameterStrings = new String[parameters.size()];
++        for (int i = 0; i < parameterStrings.length; i++) {
++            parameterStrings[i] = ""p"" + i + "": Any"";
++        }
++        String parametersString = StringUtil.join(parameterStrings,"", "");
++        String returnTypeString = isUnit ? """" : "": Any"";
++        if (isExtension) { // create as extension function
++            String ownerTypeString = selectedReceiverType.getRenderedType();
++            String methodText = String.format(""fun %s.%s(%s)%s { }"", ownerTypeString, methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            containingFile = currentFile;
++            containingFileEditor = currentFileEditor;
++            func = (JetNamedFunction) currentFile.add(func);
++        } else { // create as method
++            String methodText = String.format(""fun %s(%s)%s { }"", methodName, parametersString, returnTypeString);
++            func = JetPsiFactory.createFunction(project, methodText);
++            PsiFile classContainingFile = ownerClass.getContainingFile();
++            assert classContainingFile instanceof JetFile;
++            containingFile = (JetFile) classContainingFile;
++
++            VirtualFile virtualFile = containingFile.getVirtualFile();
++            assert virtualFile != null;
++            FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++            fileEditorManager.openFile(virtualFile, true);
++            containingFileEditor = fileEditorManager.getSelectedTextEditor();
++
++            JetClassBody classBody = ownerClass.getBody();
++            if (classBody == null) {
++                classBody = (JetClassBody) ownerClass.add(JetPsiFactory.createEmptyClassBody(project));
++                ownerClass.addBefore(JetPsiFactory.createWhiteSpace(project), classBody);
++            }
++            PsiElement rBrace = classBody.getRBrace();
++            assert rBrace != null;
++            func = (JetNamedFunction) classBody.addBefore(func, rBrace);
++        }
++
++        return func;
++    }
++
++    private void buildAndRunTemplate(@NotNull final Project project, @NotNull JetNamedFunction func) {
++        JetParameterList parameterList = func.getValueParameterList();
++        assert parameterList != null;
++
++        // build templates
++        PsiDocumentManager.getInstance(project).commitAllDocuments();
++        PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(containingFileEditor.getDocument());
++
++        CaretModel caretModel = containingFileEditor.getCaretModel();
++        caretModel.moveToOffset(containingFile.getNode().getStartOffset());
++
++        TemplateBuilderImpl builder = new TemplateBuilderImpl(containingFile);
++        final TypeExpression returnTypeExpression = isUnit ? null : setupReturnTypeTemplate(builder, func);
++        final TypeExpression[] parameterTypeExpressions = setupParameterTypeTemplates(project, builder, parameterList);
++
++        // add a segment for the parameter list
++        // Note: because TemplateBuilderImpl does not have a replaceElement overload that takes in both a TextRange and alwaysStopAt, we
++        // need to create the segment first and then hack the Expression into the template later. We use this template to update the type
++        // parameter list as the user makes selections in the parameter types, and we need alwaysStopAt to be false so the user can't tab to
++        // it.
++        TypeParameterListExpression expression = setupTypeParameterListTemplate(builder, func);
++
++        // the template built by TemplateBuilderImpl is ordered by element position, but we want types to be first, so hack it
++        final TemplateImpl template = (TemplateImpl) builder.buildInlineTemplate();
++        ArrayList<Variable> variables = template.getVariables();
++        for (int i = 0; i < parameters.size(); i++) {
++            Collections.swap(variables, i * 2, i * 2 + 1);
++        }
++
++        // fix up the template to include the expression for the type parameter list
++        variables.add(new Variable(TYPE_PARAMETER_LIST_VARIABLE_NAME, expression, expression, false, true));
++
++        // run the template
++        TemplateManager.getInstance(project).startTemplate(containingFileEditor, template, new TemplateEditingAdapter() {
++            @Override
++            public void templateFinished(Template _, boolean brokenOff) {
++                // file templates
++                int offset = template.getSegmentOffset(0);
++                final JetNamedFunction func = PsiTreeUtil.findElementOfClassAtOffset(containingFile, offset, JetNamedFunction.class, false);
++                assert func != null;
++                final List<JetTypeReference> typeRefsToShorten = new ArrayList<JetTypeReference>();
++
++                ApplicationManager.getApplication().runWriteAction(new Runnable() {
++                    @Override
++                    public void run() {
++                        // file templates
++                        setupFunctionBody(project, func);
++
++                        // change short type names to fully qualified ones (to be shortened below)
++                        setupTypeReferencesForShortening(project, func, typeRefsToShorten, parameterTypeExpressions, returnTypeExpression);
++                    }
++                });
++
++                ReferenceToClassesShortening.compactReferenceToClasses(typeRefsToShorten);
++            }
++        });
++    }
++
++    private Map<TypeParameterDescriptor, String> getTypeParameterRenames(JetScope scope) {
++        TypeParameterDescriptor[] receiverTypeParametersNotInScope = selectedReceiverType.getTypeParameters();
++        Set<TypeParameterDescriptor> allTypeParametersNotInScope = new LinkedHashSet<TypeParameterDescriptor>();
++        allTypeParametersNotInScope.addAll(Arrays.asList(receiverTypeParametersNotInScope));
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(parameterTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        if (!isUnit) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                allTypeParametersNotInScope.addAll(Arrays.asList(returnTypeCandidate.getTypeParameters()));
++            }
++        }
++
++        List<TypeParameterDescriptor> typeParameters = new ArrayList<TypeParameterDescriptor>(allTypeParametersNotInScope);
++        List<String> typeParameterNames = new ArrayList<String>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            typeParameterNames.add(getNextAvailableName(typeParameter.getName().getName(), typeParameterNames, scope));
++        }
++        assert typeParameters.size() == typeParameterNames.size();
++        Map<TypeParameterDescriptor, String> typeParameterNameMap = new HashMap<TypeParameterDescriptor, String>();
++        for (int i = 0; i < typeParameters.size(); i++) {
++            typeParameterNameMap.put(typeParameters.get(i), typeParameterNames.get(i));
++        }
++
++        return typeParameterNameMap;
++    }
++
++    private void setupTypeReferencesForShortening(
++            @NotNull Project project,
++            @NotNull JetNamedFunction func,
++            @NotNull List<JetTypeReference> typeRefsToShorten,
++            @NotNull TypeExpression[] parameterTypeExpressions,
++            @Nullable TypeExpression returnTypeExpression
++    ) {
++        if (isExtension) {
++            JetTypeReference receiverTypeRef =
++                    JetPsiFactory.createType(project, renderTypeLong(selectedReceiverType.getType(), typeParameterNameMap));
++            replaceWithLongerName(project, receiverTypeRef, selectedReceiverType.getType());
++
++            receiverTypeRef = func.getReceiverTypeRef();
++            if (receiverTypeRef != null) {
++                typeRefsToShorten.add(receiverTypeRef);
++            }
++        }
++
++        if (!isUnit) {
++            assert returnTypeExpression != null;
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            if (returnTypeRef != null) {
++                JetType returnType = returnTypeExpression.getTypeFromSelection(returnTypeRef.getText());
++                if (returnType != null) { // user selected a given type
++                    replaceWithLongerName(project, returnTypeRef, returnType);
++                    returnTypeRef = func.getReturnTypeRef();
++                    assert returnTypeRef != null;
++                    typeRefsToShorten.add(returnTypeRef);
++                }
++            }
++        }
++
++        List<JetParameter> valueParameters = func.getValueParameters();
++        List<Integer> parameterIndicesToShorten = new ArrayList<Integer>();
++        assert valueParameters.size() == parameterTypeExpressions.length;
++        for (int i = 0; i < valueParameters.size(); i++) {
++            JetParameter parameter = valueParameters.get(i);
++            JetTypeReference parameterTypeRef = parameter.getTypeReference();
++            if (parameterTypeRef != null) {
++                JetType parameterType = parameterTypeExpressions[i].getTypeFromSelection(parameterTypeRef.getText());
++                if (parameterType != null) {
++                    replaceWithLongerName(project, parameterTypeRef, parameterType);
++                    parameterIndicesToShorten.add(i);
++                }
++            }
++        }
++        valueParameters = func.getValueParameters();
++        for (int i : parameterIndicesToShorten) {
++            JetTypeReference parameterTypeRef = valueParameters.get(i).getTypeReference();
++            if (parameterTypeRef != null) {
++                typeRefsToShorten.add(parameterTypeRef);
++            }
++        }
++    }
++
++    private void setupFunctionBody(@NotNull Project project, @NotNull JetNamedFunction func) {
++        FileTemplate fileTemplate = FileTemplateManager.getInstance().getCodeTemplate(TEMPLATE_FROM_USAGE_METHOD_BODY);
++        Properties properties = new Properties();
++        if (isUnit) {
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, ""Unit"");
++        } else {
++            JetTypeReference returnTypeRef = func.getReturnTypeRef();
++            assert returnTypeRef != null;
++            properties.setProperty(FileTemplate.ATTRIBUTE_RETURN_TYPE, returnTypeRef.getText());
++        }
++        properties.setProperty(FileTemplate.ATTRIBUTE_CLASS_NAME, DescriptorUtils.getFQName(ownerClassDescriptor).getFqName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_SIMPLE_CLASS_NAME, ownerClassDescriptor.getName().getName());
++        properties.setProperty(FileTemplate.ATTRIBUTE_METHOD_NAME, methodName);
++
++        @NonNls String bodyText;
++        try {
++            bodyText = fileTemplate.getText(properties);
++        } catch (ProcessCanceledException e) {
++            throw e;
++        } catch (Exception e) {
++            throw new IncorrectOperationException(""Failed to parse file template"", e);
++        }
++        JetExpression newBodyExpression = JetPsiFactory.createFunctionBody(project, bodyText);
++        JetExpression oldBodyExpression = func.getBodyExpression();
++        assert oldBodyExpression != null;
++        oldBodyExpression.replace(newBodyExpression);
++    }
++
++    @NotNull
++    private TypeExpression setupReturnTypeTemplate(@NotNull TemplateBuilder builder, @NotNull JetNamedFunction func) {
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        assert returnTypeRef != null;
++        TypeExpression returnTypeExpression = new TypeExpression(returnType);
++        builder.replaceElement(returnTypeRef, returnTypeExpression);
++        return returnTypeExpression;
++    }
++
++    @NotNull
++    private TypeParameterListExpression setupTypeParameterListTemplate(@NotNull TemplateBuilderImpl builder, @NotNull JetNamedFunction func) {
++        Map<String, String[]> typeParameterMap = new HashMap<String, String[]>();
++        String[] receiverTypeParameterNames = selectedReceiverType.getTypeParameterNames();
++
++        for (Parameter parameter : parameters) {
++            TypeCandidate[] parameterTypeCandidates = parameter.getType().getTypeCandidates();
++            for (TypeCandidate parameterTypeCandidate : parameterTypeCandidates) {
++                typeParameterMap.put(parameterTypeCandidate.getRenderedType(), parameterTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        JetTypeReference returnTypeRef = func.getReturnTypeRef();
++        if (returnTypeRef != null) {
++            TypeCandidate[] returnTypeCandidates = returnType.getTypeCandidates();
++            for (TypeCandidate returnTypeCandidate : returnTypeCandidates) {
++                typeParameterMap.put(returnTypeCandidate.getRenderedType(), returnTypeCandidate.getTypeParameterNames());
++            }
++        }
++
++        builder.replaceElement(func, TextRange.create(3, 3), TYPE_PARAMETER_LIST_VARIABLE_NAME, null, false); // ((3, 3) is after ""fun"")
++        return new TypeParameterListExpression(receiverTypeParameterNames, typeParameterMap);
++    }
++
++    private TypeExpression[] setupParameterTypeTemplates(@NotNull Project project, @NotNull TemplateBuilder builder,
++            @NotNull JetParameterList parameterList) {
++        List<JetParameter> jetParameters = parameterList.getParameters();
++        assert jetParameters.size() == parameters.size();
++        TypeExpression[] parameterTypeExpressions = new TypeExpression[parameters.size()];
++        JetNameValidator dummyValidator = new DummyJetNameValidator(project);
++        for (int i = 0; i < parameters.size(); i++) {
++            Parameter parameter = parameters.get(i);
++            JetParameter jetParameter = jetParameters.get(i);
++
++            // add parameter type to the template
++            parameterTypeExpressions[i] = new TypeExpression(parameter.getType());
++            JetTypeReference parameterTypeRef = jetParameter.getTypeReference();
++            assert parameterTypeRef != null;
++            builder.replaceElement(parameterTypeRef, parameterTypeExpressions[i]);
++
++            // add parameter name to the template
++            String[] possibleNamesFromExpression = parameter.getType().getPossibleNamesFromExpression();
++            String preferredName = parameter.getPreferredName();
++            String[] possibleNames;
++            if (preferredName != null) {
++                possibleNames = new String[possibleNamesFromExpression.length + 1];
++                possibleNames[0] = preferredName;
++                System.arraycopy(possibleNamesFromExpression, 0, possibleNames, 1, possibleNamesFromExpression.length);
++            } else {
++                possibleNames = possibleNamesFromExpression;
++            }
++
++            // figure out suggested names for each type option
++            Map<String, String[]> parameterTypeToNamesMap = new HashMap<String, String[]>();
++            for (TypeCandidate typeCandidate : parameter.getType().getTypeCandidates()) {
++                String[] suggestedNames = JetNameSuggester.suggestNamesForType(typeCandidate.getType(), dummyValidator);
++                parameterTypeToNamesMap.put(typeCandidate.getRenderedType(), suggestedNames);
++            }
++
++            // add expression to builder
++            Expression parameterNameExpression = new ParameterNameExpression(possibleNames, parameterTypeToNamesMap);
++            PsiElement parameterNameIdentifier = jetParameter.getNameIdentifier();
++            assert parameterNameIdentifier != null;
++            builder.replaceElement(parameterNameIdentifier, parameterNameExpression);
++        }
++        return parameterTypeExpressions;
++    }
++
++    private void replaceWithLongerName(@NotNull Project project, @NotNull JetTypeReference typeRef, @NotNull JetType type) {
++        JetTypeReference fullyQualifiedReceiverTypeRef = JetPsiFactory.createType(project, renderTypeLong(type, typeParameterNameMap));
++        typeRef.replace(fullyQualifiedReceiverTypeRef);
++    }
++
++    @NotNull
++    private static JetType substituteType(@NotNull JetType type, @NotNull TypeSubstitution substitution, @NotNull Variance variance) {
++        switch (variance) {
++            case INVARIANT:
++                // for invariant, can replace only when they're equal
++                if (type.equals(substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case IN_VARIANCE:
++                // for covariant (e.g. function parameter), can replace type with any of its supertypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(type, substitution.getForType())) {
++                    return substitution.getByType();
++                }
++                break;
++            case OUT_VARIANCE:
++                // for contravariant (e.g. function return value), can replace type with any of its subtypes
++                if (JetTypeChecker.INSTANCE.isSubtypeOf(substitution.getForType(), type)) {
++                    return substitution.getByType();
++                }
++                break;
++        }
++
++        List<TypeProjection> newArguments = new ArrayList<TypeProjection>();
++        List<TypeParameterDescriptor> typeParameters = type.getConstructor().getParameters();
++        int i = 0;
++        for (TypeProjection projection : type.getArguments()) {
++            TypeParameterDescriptor typeParameter = typeParameters.get(i);
++            JetType newArgument = substituteType(projection.getType(), substitution, typeParameter.getVariance());
++            newArguments.add(new TypeProjection(Variance.INVARIANT, newArgument));
++            i++;
++        }
++        return new JetTypeImpl(type.getAnnotations(), type.getConstructor(),
++                               type.isNullable(), newArguments, type.getMemberScope());
++    }
++
++    private static boolean containsType(JetType outer, JetType inner) {
++        if (outer.equals(inner)) {
++            return true;
++        }
++
++        for (TypeProjection projection : outer.getArguments()) {
++            if (containsType(projection.getType(), inner)) {
++                return true;
++            }
++        }
++
++        return false;
++    }
++
++    @NotNull
++    private static String renderDescriptor(
++            @NotNull DeclarationDescriptor declarationDescriptor,
++            @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap,
++            boolean fq
++    ) {
++        if (declarationDescriptor instanceof TypeParameterDescriptor) {
++            String replacement = typeParameterNameMap.get(declarationDescriptor);
++            return replacement == null ? declarationDescriptor.getName().getName() : replacement;
++        } else {
++            return fq ? DescriptorUtils.getFQName(declarationDescriptor).getFqName() : declarationDescriptor.getName().getName();
++        }
++    }
++
++    @NotNull
++    private static String renderDescriptor(@NotNull DeclarationDescriptor declarationDescriptor, boolean fq) {
++        return renderDescriptor(declarationDescriptor, Collections.<TypeParameterDescriptor, String>emptyMap(), fq);
++    }
++
++    private static String renderType(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap, boolean fq) {
++        List<TypeProjection> projections = type.getArguments();
++        DeclarationDescriptor declarationDescriptor = type.getConstructor().getDeclarationDescriptor();
++        assert declarationDescriptor != null;
++        if (projections.isEmpty()) {
++            return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq);
++        }
++
++        List<String> arguments = new ArrayList<String>();
++        for (TypeProjection projection : projections) {
++            arguments.add(renderType(projection.getType(), typeParameterNameMap, fq));
++        }
++        return renderDescriptor(declarationDescriptor, typeParameterNameMap, fq) + ""<"" + StringUtil.join(arguments, "", "") + "">"";
++    }
++
++    @NotNull
++    private static String renderTypeShort(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, false);
++    }
++
++    @NotNull
++    private static String renderTypeLong(@NotNull JetType type, @NotNull Map<TypeParameterDescriptor, String> typeParameterNameMap) {
++        return renderType(type, typeParameterNameMap, true);
++    }
++
++    @NotNull
++    private static TypeParameterDescriptor[] getTypeParameterNamesNotInScope(
++            @NotNull Collection<? extends TypeParameterDescriptor> typeParameters,
++            @NotNull JetScope scope
++    ) {
++        List<TypeParameterDescriptor> typeParameterNames = new ArrayList<TypeParameterDescriptor>();
++        for (TypeParameterDescriptor typeParameter : typeParameters) {
++            ClassifierDescriptor classifier = scope.getClassifier(typeParameter.getName());
++            if (classifier == null || !classifier.equals(typeParameter)) {
++                typeParameterNames.add(typeParameter);
++            }
++        }
++        return typeParameterNames.toArray(new TypeParameterDescriptor[typeParameterNames.size()]);
++    }
++
++    @NotNull
++    private static Set<TypeParameterDescriptor> getTypeParametersInType(@NotNull JetType type) {
++        Set<TypeParameterDescriptor> typeParameters = new LinkedHashSet<TypeParameterDescriptor>();
++        List<TypeProjection> arguments = type.getArguments();
++        if (arguments.isEmpty()) {
++            ClassifierDescriptor descriptor = type.getConstructor().getDeclarationDescriptor();
++            if (descriptor instanceof TypeParameterDescriptor) {
++                typeParameters.add((TypeParameterDescriptor) descriptor);
++            }
++        } else {
++            for (TypeProjection projection : arguments) {
++                typeParameters.addAll(getTypeParametersInType(projection.getType()));
++            }
++        }
++        return typeParameters;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames) {
++        if (existingNames.contains(name)) {
++            int j = 1;
++            while (existingNames.contains(name + j)) j++;
++            name += j;
++        }
++        return name;
++    }
++
++    @NotNull
++    private static String getNextAvailableName(@NotNull String name, @NotNull Collection<String> existingNames, @NotNull JetScope scope) {
++        if (existingNames.contains(name) || scope.getClassifier(Name.identifier(name)) != null) {
++            int j = 1;
++            while (existingNames.contains(name + j) || scope.getClassifier(Name.identifier(name + j)) != null) j++;
++            name += j;
++        }
++        return name;
++    }
++
++    @NotNull
++    private static JetType[] guessTypeForExpression(@NotNull JetExpression expr, @NotNull BindingContext context) {
++        JetType type = context.get(BindingContext.EXPRESSION_TYPE, expr);
++        JetNamedDeclaration declaration = null;
++
++        // if we know the actual type of the expression
++        if (type != null) {
++            return new JetType[] {type};
++        }
++
++        // expression has an expected type
++        else if ((type = context.get(BindingContext.EXPECTED_EXPRESSION_TYPE, expr)) != null) {
++            return new JetType[] {type};
++        }
++
++        // expression itself is a type assertion
++        else if (expr instanceof JetTypeConstraint) { // expression itself is a type assertion
++            JetTypeConstraint constraint = (JetTypeConstraint) expr;
++            return new JetType[] {context.get(BindingContext.TYPE, constraint.getBoundTypeReference())};
++        }
++
++        // expression is on the left side of a type assertion
++        else if (expr.getParent() instanceof JetTypeConstraint) {
++            JetTypeConstraint constraint = (JetTypeConstraint) expr.getParent();
++            return new JetType[] {context.get(BindingContext.TYPE, constraint.getBoundTypeReference())};
++        }
++
++        // expression is on the lhs of a multi-declaration
++        else if (expr instanceof JetMultiDeclarationEntry) {
++            JetMultiDeclarationEntry entry = (JetMultiDeclarationEntry) expr;
++            JetTypeReference typeRef = entry.getTypeRef();
++            if (typeRef != null) { // and has a specified type
++                return new JetType[] {context.get(BindingContext.TYPE, typeRef)};
++            }
++            declaration = entry; // otherwise fall through and guess
++        }
++
++        // expression is a parameter (e.g. declared in a for-loop)
++        else if (expr instanceof JetParameter) {
++            JetParameter parameter = (JetParameter) expr;
++            JetTypeReference typeRef = parameter.getTypeReference();
++            if (typeRef != null) { // and has a specified type
++                return new JetType[] {context.get(BindingContext.TYPE, typeRef)};
++            }
++            declaration = parameter; // otherwise fall through and guess
++        }
++
++        // the expression is the RHS of a variable assignment with a specified type
++        else if (expr.getParent() instanceof JetVariableDeclaration) {
++            JetVariableDeclaration variable = (JetVariableDeclaration) expr.getParent();
++            JetTypeReference typeRef = variable.getTypeRef();
++            if (typeRef != null) { // and has a specified type
++                return new JetType[] {context.get(BindingContext.TYPE, typeRef)};
++            }
++            declaration = variable; // otherwise fall through and guess, based on LHS
++        }
++
++        // guess based on declaration
++        SearchScope scope = expr.getContainingFile().getUseScope();
++        Set<JetType> expectedTypes = new HashSet<JetType>();
++        if (declaration != null) {
++            for (PsiReference ref : SearchUtils.findAllReferences(declaration, scope)) {
++                if (ref instanceof JetSimpleNameReference) {
++                    JetSimpleNameReference simpleNameRef = (JetSimpleNameReference) ref;
++                    JetType expectedType = context.get(BindingContext.EXPECTED_EXPRESSION_TYPE, simpleNameRef.getExpression());
++                    if (expectedType != null) {
++                        expectedTypes.add(expectedType);
++                    }
++                }
++            }
++        }
++        if (expectedTypes.isEmpty()) {
++            return new JetType[0];
++        }
++        type = TypeUtils.intersect(JetTypeChecker.INSTANCE, expectedTypes);
++        if (type != null) {
++            return new JetType[] {type};
++        } else { // intersection doesn't exist; let user make an imperfect choice
++            return expectedTypes.toArray(new JetType[expectedTypes.size()]);
++        }
++    }
++
++    private static boolean isUnit(@NotNull JetType type) {","Method is trivial and used once. It's redundant.
+",2013-04-26 11:59:27
+862,"@@ -0,0 +1,147 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.codeInsight.intention.JvmCommonIntentionActionsFactory
++import com.intellij.codeInspection.LocalQuickFixAndIntentionActionOnPsiElement
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import com.intellij.psi.PsiModifier
++import com.intellij.psi.PsiType
++import org.jetbrains.kotlin.asJava.elements.KtLightElement
++import org.jetbrains.kotlin.builtins.DefaultBuiltIns
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.idea.core.insertMembersAfter
++import org.jetbrains.kotlin.idea.quickfix.AddModifierFix
++import org.jetbrains.kotlin.idea.quickfix.RemoveModifierFix
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.platform.JavaToKotlinClassMap
++import org.jetbrains.kotlin.psi.KtClassOrObject
++import org.jetbrains.kotlin.psi.KtElement
++import org.jetbrains.kotlin.psi.KtModifierListOwner
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.uast.UClass
++import org.jetbrains.uast.UDeclaration
++import org.jetbrains.uast.UElement
++
++
++class KotlinCommonIntentionActionsFactory : JvmCommonIntentionActionsFactory() {
++    override fun createChangeModifierAction(declaration: UDeclaration, modifier: String, shouldPresent: Boolean): IntentionAction? {
++        val kModifierOwner = declaration.asKtElement<KtModifierListOwner>()
++                             ?: throw IllegalArgumentException(""$declaration is expected to contain KtLightElement with KtModifierListOwner"")
++
++        val (kToken, shouldPresentMapped) = if (PsiModifier.FINAL == modifier)
++            KtTokens.OPEN_KEYWORD to !shouldPresent
++        else
++            javaPsiModifiersMapping[modifier] to shouldPresent
++
++        if (kToken == null) return null
++        return if (shouldPresentMapped)
++            AddModifierFix.createIfApplicable(kModifierOwner, kToken)
++        else
++            RemoveModifierFix(kModifierOwner, kToken, false)
++    }
++
++    private inline fun <reified T : KtElement> UElement.asKtElement(): T? =
++            (psi as? KtLightElement<*, *>?)?.kotlinOrigin as? T
++
++    companion object {
++        val javaPsiModifiersMapping = mapOf(
++                PsiModifier.PRIVATE to KtTokens.PRIVATE_KEYWORD,
++                PsiModifier.PUBLIC to KtTokens.PUBLIC_KEYWORD,
++                PsiModifier.PROTECTED to KtTokens.PUBLIC_KEYWORD,
++                PsiModifier.ABSTRACT to KtTokens.ABSTRACT_KEYWORD
++        )
++
++        val javaVisibilityMapping: Map<String, String> = mapOf(
++                PsiModifier.PRIVATE to Visibilities.PRIVATE.displayName,
++                PsiModifier.PUBLIC to """",
++                PsiModifier.PROTECTED to Visibilities.PROTECTED.displayName,
++                PsiModifier.PACKAGE_LOCAL to Visibilities.INTERNAL.displayName
++        ).withDefault { Visibilities.DEFAULT_VISIBILITY.displayName }
++    }
++
++    override fun createAddMethodAction(uClass: UClass, methodName: String, visibilityModifier: String, returnType: PsiType, vararg parameters: PsiType): IntentionAction? {
++        val returnTypeString: String = typeString(returnType).let {
++            when {
++                it.isEmpty() -> """"
++                else -> "": $it""
++            }
++        }
++        val paramsStr = parameters.mapIndexed { index, psiType -> ""arg${index + 1}: ${typeString(psiType)}"" }.joinToString()
++        return object : LocalQuickFixAndIntentionActionOnPsiElement(uClass) {
++            override fun getFamilyName(): String = ""Add method""
++
++            private val text = ""Add method '$methodName' to '${uClass.name}'""
++
++            override fun getText(): String = text
++
++            override fun invoke(project: Project, file: PsiFile, editor: Editor?, startElement: PsiElement, endElement: PsiElement) {
++                val visibilityStr = javaVisibilityMapping.getValue(visibilityModifier)
++                val psiFactory = KtPsiFactory(uClass)
++                val function = psiFactory.createFunction(""$visibilityStr fun $methodName($paramsStr)$returnTypeString{}"")",You should use `KtPsiFactory.CallableBuilder` instead of building the text manually.,2017-05-23 16:43:17
+861,"@@ -0,0 +1,15 @@
++// ""Replace with safe (?.) call"" ""false""
++// ACTION: Add non-null asserted (!!) call
++// ACTION: Convert to expression body
++// ACTION: Replace with safe (this?.) call
++// ACTION: Wrap with '?.let { ... }' call
++// ERROR: Only safe (?.) or non-null asserted (!!.) calls are allowed on a nullable receiver of type A?
++
++class A {
++    fun foo() {
++    }
++}
++
++fun A?.bar() {
++    <caret>foo()
++}","Why does this test have so strange name? I see no `invoke` here, either safe or unsafe",2017-05-23 12:28:05
+636,"@@ -0,0 +1,15 @@
++// WITH_RUNTIME
++
++fun contains(set: Set<Any>, x: Int): Boolean = when {
++    set.size == 0 -> false
++    else -> x in set as Set<Int>
++}
++
++fun box(): String {
++    val set = setOf(1)
++    if (contains(set, 1)) {
++        return ""OK""
++    }
++
++    return ""Fail""
++}","This test in not related to Range#contains, but at some point I had implementation which passed all tests (without this one), but ant build was failed.
+",2016-10-11 19:02:08
+170,"@@ -0,0 +1,15 @@
++class TestingUse {
++    fun test(sum: Int.(a: Int) -> Int, b: Int): Int {
++        return b.sum(b)
++    }
++    fun test2(sum: (a: Int, b: Int) -> Int, c: Int): Int {","Basically you've used the same test data file in all tests on `makeTypeExplicitInLambda`, altering the calling function in each case. This is not a good idea, because once one of such tests fails, the investigating person might think that the fact that there are several functions in this file is relevant to the test case, while in reality it's not.
+
+Please try to make your tests as minimal as possible, i.e. only include relevant data in each test.
+",2014-04-09 16:19:26
+840,"@@ -0,0 +1,15 @@
++data class Foo(val a: String) {
++    fun copy(i: Int) {}
++}
++
++class Foo2() {
++    fun copy(i: Int) {}
++}
++","I'd add an example that clearly shows all should be named, like this:
+```
+data class SomeName(a: Int, b: Int, c: String)
+f.copy(2, c = """")
+```",2017-05-03 09:49:34
+968,"@@ -0,0 +1,150 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.config.LanguageFeature
++import org.jetbrains.kotlin.config.LanguageVersionSettings
++import org.jetbrains.kotlin.descriptors.ModuleDescriptor
++import org.jetbrains.kotlin.effectsystem.effects.ESCalls
++import org.jetbrains.kotlin.effectsystem.effects.ESReturns
++import org.jetbrains.kotlin.effectsystem.factories.UNKNOWN_CONSTANT
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.resolving.FunctorResolver
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.visitors.Reducer
++import org.jetbrains.kotlin.effectsystem.visitors.SchemaBuilder
++import org.jetbrains.kotlin.psi.KtCallExpression
++import org.jetbrains.kotlin.psi.KtDeclaration
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowInfo
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValueFactory
++
++class EffectSystem(val languageVersionSettings: LanguageVersionSettings) {
++    private val functorResolver = FunctorResolver()
++
++    fun getResultDataFlowInfo(
++            resolvedCall: ResolvedCall<*>,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++
++        // Prevent launch of effect system machinery on pointless cases (constants/enums/constructors/etc.)
++        val callExpression = resolvedCall.call.callElement as? KtCallExpression ?: return DataFlowInfo.EMPTY
++        if (callExpression is KtDeclaration) return DataFlowInfo.EMPTY
++
++        val resultContextInfo = getContextInfoWhen(ESReturns(UNKNOWN_CONSTANT), callExpression, bindingTrace, moduleDescriptor)
++
++        return resultContextInfo.toDataFlowInfo(languageVersionSettings)
++    }
++
++    fun recordDefiniteInvocations(resolvedCall: ResolvedCall<*>, bindingTrace: BindingTrace, moduleDescriptor: ModuleDescriptor) {",In this function we have some strange combination of `getResultDataFlowInfo` and `checkAndRecordDefiniteInvocations`. I think some refactoring is needed here.,2017-08-15 15:52:13
+970,"@@ -0,0 +1,150 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.config.LanguageFeature
++import org.jetbrains.kotlin.config.LanguageVersionSettings
++import org.jetbrains.kotlin.descriptors.ModuleDescriptor
++import org.jetbrains.kotlin.effectsystem.effects.ESCalls
++import org.jetbrains.kotlin.effectsystem.effects.ESReturns
++import org.jetbrains.kotlin.effectsystem.factories.UNKNOWN_CONSTANT
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.resolving.FunctorResolver
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.visitors.Reducer
++import org.jetbrains.kotlin.effectsystem.visitors.SchemaBuilder
++import org.jetbrains.kotlin.psi.KtCallExpression
++import org.jetbrains.kotlin.psi.KtDeclaration
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowInfo
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValueFactory
++
++class EffectSystem(val languageVersionSettings: LanguageVersionSettings) {
++    private val functorResolver = FunctorResolver()
++
++    fun getResultDataFlowInfo(
++            resolvedCall: ResolvedCall<*>,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++
++        // Prevent launch of effect system machinery on pointless cases (constants/enums/constructors/etc.)
++        val callExpression = resolvedCall.call.callElement as? KtCallExpression ?: return DataFlowInfo.EMPTY
++        if (callExpression is KtDeclaration) return DataFlowInfo.EMPTY
++
++        val resultContextInfo = getContextInfoWhen(ESReturns(UNKNOWN_CONSTANT), callExpression, bindingTrace, moduleDescriptor)
++
++        return resultContextInfo.toDataFlowInfo(languageVersionSettings)
++    }
++
++    fun recordDefiniteInvocations(resolvedCall: ResolvedCall<*>, bindingTrace: BindingTrace, moduleDescriptor: ModuleDescriptor) {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.CalledInPlaceEffect)) return
++
++        // Prevent launch of effect system machinery on pointless cases (constants/enums/constructors/etc.)
++        val callExpression = resolvedCall.call.callElement as? KtCallExpression ?: return
++        if (callExpression is KtDeclaration) return
++
++        val resultingContextInfo = getContextInfoWhen(ESReturns(UNKNOWN_CONSTANT), callExpression, bindingTrace, moduleDescriptor)
++        for (effect in resultingContextInfo.firedEffects) {
++            val callsEffect = effect as? ESCalls ?: continue
++            val id = callsEffect.callable.id as DataFlowValueID
++
++            // Could be also IdentifierInfo.Variable when call passes non-anonymous lambda for callable parameter
++            val lambdaExpr = (id.dfv.identifierInfo as? DataFlowValueFactory.ExpressionIdentifierInfo)?.expression ?: continue
++            assert(lambdaExpr is KtLambdaExpression) { ""Unexpected argument of Calls-effect: expected KtLambdaExpression, got $lambdaExpr"" }
++
++            bindingTrace.record(BindingContext.LAMBDA_INVOCATIONS, lambdaExpr as KtLambdaExpression, callsEffect.kind)
++        }
++    }
++
++    fun getConditionalInfoForThenBranch(
++            condition: KtExpression?,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++        if (condition == null) return DataFlowInfo.EMPTY
++
++        return getContextInfoWhen(ESReturns(true.lift()), condition, bindingTrace, moduleDescriptor)
++                .toDataFlowInfo(languageVersionSettings)
++    }
++
++    fun getConditionalInfoForElseBranch(
++            condition: KtExpression?,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++        if (condition == null) return DataFlowInfo.EMPTY
++
++        return getContextInfoWhen(ESReturns(false.lift()), condition, bindingTrace, moduleDescriptor)
++                .toDataFlowInfo(languageVersionSettings)
++    }
++
++    private fun getContextInfoWhen(
++            observedEffect: ESEffect,
++            expression: KtExpression,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): MutableContextInfo {
++        val schema = getSchema(expression, bindingTrace, moduleDescriptor) ?: return MutableContextInfo.EMPTY
++
++        val extractedContextInfo = InfoCollector(observedEffect).collectFromSchema(schema)
++
++        return extractedContextInfo
++    }
++
++    private fun getSchema(expression: KtExpression, bindingTrace: BindingTrace, moduleDescriptor: ModuleDescriptor): EffectSchema? {
++        if (bindingTrace[BindingContext.EXPRESSION_EFFECTS, expression] == null) {
++            val evaluatedSchema = evaluateSchema(expression, bindingTrace.bindingContext, moduleDescriptor) ?: return null
++            bindingTrace.record(BindingContext.EXPRESSION_EFFECTS, expression, evaluatedSchema)
++        }
++
++        return bindingTrace[BindingContext.EXPRESSION_EFFECTS, expression]",I'd try to avoid repeated access to `bindingTrace` here.,2017-08-15 16:01:33
+982,"@@ -0,0 +1,150 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.config.LanguageFeature
++import org.jetbrains.kotlin.config.LanguageVersionSettings
++import org.jetbrains.kotlin.descriptors.ModuleDescriptor
++import org.jetbrains.kotlin.effectsystem.effects.ESCalls
++import org.jetbrains.kotlin.effectsystem.effects.ESReturns
++import org.jetbrains.kotlin.effectsystem.factories.UNKNOWN_CONSTANT
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.resolving.FunctorResolver
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.visitors.Reducer
++import org.jetbrains.kotlin.effectsystem.visitors.SchemaBuilder
++import org.jetbrains.kotlin.psi.KtCallExpression
++import org.jetbrains.kotlin.psi.KtDeclaration
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowInfo
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValueFactory
++
++class EffectSystem(val languageVersionSettings: LanguageVersionSettings) {
++    private val functorResolver = FunctorResolver()
++
++    fun getResultDataFlowInfo(
++            resolvedCall: ResolvedCall<*>,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++
++        // Prevent launch of effect system machinery on pointless cases (constants/enums/constructors/etc.)
++        val callExpression = resolvedCall.call.callElement as? KtCallExpression ?: return DataFlowInfo.EMPTY
++        if (callExpression is KtDeclaration) return DataFlowInfo.EMPTY
++
++        val resultContextInfo = getContextInfoWhen(ESReturns(UNKNOWN_CONSTANT), callExpression, bindingTrace, moduleDescriptor)
++
++        return resultContextInfo.toDataFlowInfo(languageVersionSettings)
++    }
++
++    fun recordDefiniteInvocations(resolvedCall: ResolvedCall<*>, bindingTrace: BindingTrace, moduleDescriptor: ModuleDescriptor) {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.CalledInPlaceEffect)) return
++
++        // Prevent launch of effect system machinery on pointless cases (constants/enums/constructors/etc.)
++        val callExpression = resolvedCall.call.callElement as? KtCallExpression ?: return
++        if (callExpression is KtDeclaration) return
++
++        val resultingContextInfo = getContextInfoWhen(ESReturns(UNKNOWN_CONSTANT), callExpression, bindingTrace, moduleDescriptor)
++        for (effect in resultingContextInfo.firedEffects) {
++            val callsEffect = effect as? ESCalls ?: continue
++            val id = callsEffect.callable.id as DataFlowValueID
++
++            // Could be also IdentifierInfo.Variable when call passes non-anonymous lambda for callable parameter
++            val lambdaExpr = (id.dfv.identifierInfo as? DataFlowValueFactory.ExpressionIdentifierInfo)?.expression ?: continue
++            assert(lambdaExpr is KtLambdaExpression) { ""Unexpected argument of Calls-effect: expected KtLambdaExpression, got $lambdaExpr"" }
++
++            bindingTrace.record(BindingContext.LAMBDA_INVOCATIONS, lambdaExpr as KtLambdaExpression, callsEffect.kind)
++        }
++    }
++
++    fun getConditionalInfoForThenBranch(
++            condition: KtExpression?,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++        if (condition == null) return DataFlowInfo.EMPTY
++
++        return getContextInfoWhen(ESReturns(true.lift()), condition, bindingTrace, moduleDescriptor)
++                .toDataFlowInfo(languageVersionSettings)
++    }
++
++    fun getConditionalInfoForElseBranch(
++            condition: KtExpression?,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): DataFlowInfo {
++        if (!languageVersionSettings.supportsFeature(LanguageFeature.ContractEffects)) return DataFlowInfo.EMPTY
++        if (condition == null) return DataFlowInfo.EMPTY
++
++        return getContextInfoWhen(ESReturns(false.lift()), condition, bindingTrace, moduleDescriptor)
++                .toDataFlowInfo(languageVersionSettings)
++    }
++
++    private fun getContextInfoWhen(
++            observedEffect: ESEffect,
++            expression: KtExpression,
++            bindingTrace: BindingTrace,
++            moduleDescriptor: ModuleDescriptor
++    ): MutableContextInfo {
++        val schema = getSchema(expression, bindingTrace, moduleDescriptor) ?: return MutableContextInfo.EMPTY
++
++        val extractedContextInfo = InfoCollector(observedEffect).collectFromSchema(schema)
++
++        return extractedContextInfo
++    }
++
++    private fun getSchema(expression: KtExpression, bindingTrace: BindingTrace, moduleDescriptor: ModuleDescriptor): EffectSchema? {
++        if (bindingTrace[BindingContext.EXPRESSION_EFFECTS, expression] == null) {
++            val evaluatedSchema = evaluateSchema(expression, bindingTrace.bindingContext, moduleDescriptor) ?: return null
++            bindingTrace.record(BindingContext.EXPRESSION_EFFECTS, expression, evaluatedSchema)
++        }
++
++        return bindingTrace[BindingContext.EXPRESSION_EFFECTS, expression]
++    }
++
++    private fun evaluateSchema(expression: KtExpression, bindingContext: BindingContext, moduleDescriptor: ModuleDescriptor): EffectSchema? {
++        val ctBuilder = CallTreeBuilder(bindingContext, moduleDescriptor, functorResolver)
++        val callTree = expression.accept(ctBuilder, Unit)
++
++        val esBuilder = SchemaBuilder()
++        val schema = callTree.accept(esBuilder) ?: return null
++
++        val reducedSchema = Reducer().reduceSchema(schema)
++
++        return reducedSchema
++    }
++
++    private fun checkAndRecordDefiniteInvocations(bindingTrace: BindingTrace, contextInfo: MutableContextInfo) {",BTW this guy is not in use now,2017-08-15 16:48:43
+972,"@@ -0,0 +1,16 @@
++fun testIsNullOrBlank(x: String?) {","This test has no annotation of some language feature on. Looks strange. I'd check all new tests, and most probably all of them should have some annotation. Otherwise backward compatibility can be broken",2017-08-15 16:06:51
+737,"@@ -0,0 +1,160 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.descriptors.Visibility
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++
++abstract class ClassifierType<out T : JCTree>(tree: T,",May be it should be `sealed`,2017-04-05 15:54:03
+735,"@@ -0,0 +1,160 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.descriptors.Visibility
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++
++abstract class ClassifierType<out T : JCTree>(tree: T,
++                                              treePath: TreePath,
++                                              javac: Javac) : JCType<T>(tree, treePath, javac), JavaClassifierType {
++    override val classifier by lazy { getClassifier(treePath, javac) }
++
++    override val canonicalText
++        get() = (classifier as? JavaClass)?.fqName?.asString() ?: treePath.leaf.toString()
++
++    override val presentableText
++        get() = canonicalText
++
++    private val typeParameter by lazy {
++        treePath.filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }
++                .flatMap {
++                    when (it) {
++                        is JCTree.JCClassDecl -> it.typarams
++                        is JCTree.JCMethodDecl -> it.typarams
++                        else -> emptyList<JCTypeParameter<*>>()",May be throw an exception here? We should not achieve this point,2017-04-05 15:51:26
+738,"@@ -0,0 +1,160 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.descriptors.Visibility
++import org.jetbrains.kotlin.load.java.structure.*
++import org.jetbrains.kotlin.name.FqName
++
++abstract class ClassifierType<out T : JCTree>(tree: T,
++                                              treePath: TreePath,
++                                              javac: Javac) : JCType<T>(tree, treePath, javac), JavaClassifierType {
++    override val classifier by lazy { getClassifier(treePath, javac) }
++
++    override val canonicalText
++        get() = (classifier as? JavaClass)?.fqName?.asString() ?: treePath.leaf.toString()
++
++    override val presentableText
++        get() = canonicalText
++
++    private val typeParameter by lazy {
++        treePath.filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }
++                .flatMap {
++                    when (it) {
++                        is JCTree.JCClassDecl -> it.typarams
++                        is JCTree.JCMethodDecl -> it.typarams
++                        else -> emptyList<JCTypeParameter<*>>()
++                    }
++                }
++                .find { it.toString().substringBefore("" "") == treePath.leaf.toString() }
++    }
++
++}
++
++class JCClassifierType<out T : JCTree.JCExpression>(tree: T,
++                                                    treePath: TreePath,
++                                                    javac: Javac) : ClassifierType<T>(tree, treePath, javac) {
++
++    override val typeArguments: List<JavaType>
++        get() = emptyList()
++
++    override val isRaw: Boolean
++        get() = (classifier as? JavaClass)?.typeParameters?.isNotEmpty() ?: false
++
++}
++
++class JCClassifierTypeWithTypeArgument<out T : JCTree.JCTypeApply>(tree: T,
++                                                                   treePath: TreePath,
++                                                                   javac: Javac) : ClassifierType<T>(tree, treePath, javac) {
++
++    override val typeArguments: List<JavaType>
++        get() = tree.arguments.map { create(it, treePath, javac) }
++
++    override val isRaw: Boolean
++        get() = false
++
++}
++
++private fun getClassifier(treePath: TreePath, javac: Javac) = treePath.resolve(javac).let {
++    it.second
++    ?: stubs[it.first]
++    ?: typeParameter(treePath, javac)
++    ?: createStubClassifier(it.first)
++}
++
++private fun typeParameter(treePath: TreePath, javac: Javac) = treePath
++        .filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }
++        .flatMap {
++            when (it) {
++                is JCTree.JCClassDecl -> it.typarams
++                is JCTree.JCMethodDecl -> it.typarams
++                else -> emptyList<JCTree.JCTypeParameter>()
++            }
++        }
++        .find { it.toString().substringBefore("" "") == treePath.leaf.toString() }
++        ?.let { JCTypeParameter(it,
++                                javac.getTreePath(it, treePath.compilationUnit),
++                                javac)
++        }
++
++private val stubs = hashMapOf<FqName, JavaClass>()","Is it true we have some stub cache here? If yes, consider creating some class / object and integrate both `stubs` and `createStubClassifier` inside. I do not like mutable global properties, even private.",2017-04-05 15:57:50
+375,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and targeting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |","Is it ok that it called the same as other Java constant? Can it mislead?
+",2015-04-10 12:14:58
+374,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and targeting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |
++| EXPRESSION | \<no analog> |
++","What about a file as target?
+",2015-04-09 10:49:39
+361,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and trageting","Typo: trageting -> targeting
+",2015-04-04 22:08:29
+362,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and trageting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |
++| EXPRESSION | \<no analog> |
++
++Putting an annotation on an element that is not allowed by the specified target is a compile-time error.
++No targets specified means that all targets are accepted.
++
++> NOTE: Java has the following [targets](https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html):
++
++
++**TODO** Open question: what about traits/classes/objects?  
++**TODO** local variables are just like properties, but local  
++
++> Possbile platform-specific targets","Typo: Possbile -> Possible 
+",2015-04-04 22:24:09
+363,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and trageting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |
++| EXPRESSION | \<no analog> |
++
++Putting an annotation on an element that is not allowed by the specified target is a compile-time error.
++No targets specified means that all targets are accepted.
++
++> NOTE: Java has the following [targets](https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html):
++
++
++**TODO** Open question: what about traits/classes/objects?  
++**TODO** local variables are just like properties, but local  
++
++> Possbile platform-specific targets
++* SINGLETON_FIELD for objects
++* PROPERTY_FIELD
++* (?) DEFAULT_FUNCTION
++* (?) LAMBDA_METHOD
++* PACKAGE_FACADE
++* PACKAGE_PART
++
++### Mapping onto Java
++
++Kotlin has more possible targets than Java, so there's an issue of mapping back and forth. The table above give a correspondence.","give -> gives
+",2015-04-04 22:25:20
+364,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and trageting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |
++| EXPRESSION | \<no analog> |
++
++Putting an annotation on an element that is not allowed by the specified target is a compile-time error.
++No targets specified means that all targets are accepted.
++
++> NOTE: Java has the following [targets](https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html):
++
++
++**TODO** Open question: what about traits/classes/objects?  
++**TODO** local variables are just like properties, but local  
++
++> Possbile platform-specific targets
++* SINGLETON_FIELD for objects
++* PROPERTY_FIELD
++* (?) DEFAULT_FUNCTION
++* (?) LAMBDA_METHOD
++* PACKAGE_FACADE
++* PACKAGE_PART
++
++### Mapping onto Java
++
++Kotlin has more possible targets than Java, so there's an issue of mapping back and forth. The table above give a correspondence.
++
++When we compile a Kotlin class to Java, we write a `@java.lang.annotation.Target` annotation that reflects the targets. For targets having no correspondent ones in Java (e.g. `EXPRESSION`) nothing is written to `j.l.a.Target`. If the set of Java targets is empy, `j.l.a.Target` is not written to the class file. 
++
++In addition to `java.lang.annotation.Target`, a Kotlin-specific annotation `kotlin.target` is written containing all the Kotlin targets listed:
++
++``` kotlin
++package kotlin
++
++enum class AnnotationTarget {
++    PACKAGE
++    ...
++}
++
++target(ANNOTATION_CLASS)
++annotation(RUNTIME) class target(vararg targets: AnnotationTarget)
++```
++
++When loading an annotation, we only read `kotlin.target`. When `kotlin.target` is missing, on the JVM, we read `j.l.a.Target` and map its values to Kotlin ones according to the table above. This implies that we can load pure Java annotations that know nothing about Kotlin, and that an annotation written in Java can be targeted, e.g. for Kotlin expressions, because one can simply manually specify `kotlin.target` for it.
++
++### Syntax
++
++It makes sense to use `kotlin.target` explicitly in Kotlin code:
++
++``` kotlin
++target(EXPRESSION, TYPE)
++annotation class MyAnn
++```
++
++> An alternative would be to make target a aproperty of `kotlin.annotation`, but then we'd","aproperty -> property
+",2015-04-04 22:29:18
+365,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and trageting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |
++| EXPRESSION | \<no analog> |
++
++Putting an annotation on an element that is not allowed by the specified target is a compile-time error.
++No targets specified means that all targets are accepted.
++
++> NOTE: Java has the following [targets](https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html):
++
++
++**TODO** Open question: what about traits/classes/objects?  
++**TODO** local variables are just like properties, but local  
++
++> Possbile platform-specific targets
++* SINGLETON_FIELD for objects
++* PROPERTY_FIELD
++* (?) DEFAULT_FUNCTION
++* (?) LAMBDA_METHOD
++* PACKAGE_FACADE
++* PACKAGE_PART
++
++### Mapping onto Java
++
++Kotlin has more possible targets than Java, so there's an issue of mapping back and forth. The table above give a correspondence.
++
++When we compile a Kotlin class to Java, we write a `@java.lang.annotation.Target` annotation that reflects the targets. For targets having no correspondent ones in Java (e.g. `EXPRESSION`) nothing is written to `j.l.a.Target`. If the set of Java targets is empy, `j.l.a.Target` is not written to the class file. 
++
++In addition to `java.lang.annotation.Target`, a Kotlin-specific annotation `kotlin.target` is written containing all the Kotlin targets listed:
++
++``` kotlin
++package kotlin
++
++enum class AnnotationTarget {
++    PACKAGE
++    ...
++}
++
++target(ANNOTATION_CLASS)
++annotation(RUNTIME) class target(vararg targets: AnnotationTarget)
++```
++
++When loading an annotation, we only read `kotlin.target`. When `kotlin.target` is missing, on the JVM, we read `j.l.a.Target` and map its values to Kotlin ones according to the table above. This implies that we can load pure Java annotations that know nothing about Kotlin, and that an annotation written in Java can be targeted, e.g. for Kotlin expressions, because one can simply manually specify `kotlin.target` for it.
++
++### Syntax
++
++It makes sense to use `kotlin.target` explicitly in Kotlin code:
++
++``` kotlin
++target(EXPRESSION, TYPE)
++annotation class MyAnn
++```
++
++> An alternative would be to make target a aproperty of `kotlin.annotation`, but then we'd
++* lose the advantage of varargs, because there are more optional parameters
++* be non-uniform with Java, thus making it harder to figure how to make a Java annotation Kotlin-friendly
++
++## Retention
++
++> NOTE: Retention is a Java-specific concern, more or less. CLR retains all attributes at runtime, and JS too
++
++It makes a lot of sense to make `RUNTIME` the default retention.
++
++Since `RetentionPolicy.CLASS` is not a good fit for Kotlin that has functions outside any class, it's better to have `BINARY` instead. Also, we could have use `java.lang.annotation.RetentionPolicy` anyways, since it's platform-specific. Thus, we need to have our own enum:
++","could have use -> could not use (?)
+",2015-04-04 22:31:40
+359,"@@ -0,0 +1,169 @@
++# Annotation Options
++
++Goals:
++* Support annotation options, such as retention policy and trageting
++
++See [related discussion about Scala](http://lampwww.epfl.ch/~mihaylov/attributes.html).
++
++## Discussion
++
++For each option of annotations there's a general dichotomy of how it can be specified in code.
++
++Option 0: Separate annotations
++
++``` kotlin
++retention(SOURCE)
++target(CLASSIFIER, FIELD)
++annotation class example
++```
++
++Option 1: Make `annotation` into an annotation, and use its properties
++
++``` kotlin
++annotation(
++    retention = SOURCE, 
++    targets = array(CLASSIFIER, FIELD)
++) 
++class example
++```
++
++A variation of this is
++
++``` kotlin
++annotation(target(CLASSIFIER, FIELD), retention = SOURCE) class example
++```
++
++Annotations can be parameters to other annotations.
++
++Having option as separate annotation is what Java has and seems more extensible, although it actually isn't (adding new parameters to one annotation is no better or worse than adding new annotation recognized by the compiler).
++
++Having those as parameters is more discoverable, but has some syntactic shortcomings: no varargs can be used.
++
++## Targeting
++
++To check applicability, we can use the following constants:
++
++| Kotlin constant | Java constant | 
++|-----------------|---------------|
++| PACKAGE | \<same> |
++| CLASSIFIER | TYPE |
++| ANNOTATION_CLASS | ANNOTATION_TYPE |
++| TYPE_PARAMETER | \<same>
++| PROPERTY | \<no analog> |
++| FIELD | \<same>
++| LOCAL_VARIABLE | \<same> |
++| VALUE_PARAMETER | PARAMETER |
++| CONSTRUCTOR | \<same> |
++| FUNCITON | METHOD |
++| PROPERTY_GETTER | METHOD |
++| PROPERTY_SETTER | METHOD |
++| TYPE | TYPE_USE |
++| EXPRESSION | \<no analog> |
++
++Putting an annotation on an element that is not allowed by the specified target is a compile-time error.
++No targets specified means that all targets are accepted.
++
++> NOTE: Java has the following [targets](https://docs.oracle.com/javase/8/docs/api/java/lang/annotation/ElementType.html):
++
++
++**TODO** Open question: what about traits/classes/objects?  
++**TODO** local variables are just like properties, but local  
++
++> Possbile platform-specific targets
++* SINGLETON_FIELD for objects
++* PROPERTY_FIELD
++* (?) DEFAULT_FUNCTION
++* (?) LAMBDA_METHOD
++* PACKAGE_FACADE
++* PACKAGE_PART
++
++### Mapping onto Java
++
++Kotlin has more possible targets than Java, so there's an issue of mapping back and forth. The table above give a correspondence.
++
++When we compile a Kotlin class to Java, we write a `@java.lang.annotation.Target` annotation that reflects the targets. For targets having no correspondent ones in Java (e.g. `EXPRESSION`) nothing is written to `j.l.a.Target`. If the set of Java targets is empy, `j.l.a.Target` is not written to the class file. 
++
++In addition to `java.lang.annotation.Target`, a Kotlin-specific annotation `kotlin.target` is written containing all the Kotlin targets listed:
++
++``` kotlin
++package kotlin
++
++enum class AnnotationTarget {
++    PACKAGE
++    ...
++}
++
++target(ANNOTATION_CLASS)
++annotation(RUNTIME) class target(vararg targets: AnnotationTarget)
++```
++
++When loading an annotation, we only read `kotlin.target`. When `kotlin.target` is missing, on the JVM, we read `j.l.a.Target` and map its values to Kotlin ones according to the table above. This implies that we can load pure Java annotations that know nothing about Kotlin, and that an annotation written in Java can be targeted, e.g. for Kotlin expressions, because one can simply manually specify `kotlin.target` for it.
++
++### Syntax
++
++It makes sense to use `kotlin.target` explicitly in Kotlin code:
++
++``` kotlin
++target(EXPRESSION, TYPE)
++annotation class MyAnn
++```
++
++> An alternative would be to make target a aproperty of `kotlin.annotation`, but then we'd
++* lose the advantage of varargs, because there are more optional parameters
++* be non-uniform with Java, thus making it harder to figure how to make a Java annotation Kotlin-friendly
++
++## Retention
++
++> NOTE: Retention is a Java-specific concern, more or less. CLR retains all attributes at runtime, and JS too
++
++It makes a lot of sense to make `RUNTIME` the default retention.
++
++Since `RetentionPolicy.CLASS` is not a good fit for Kotlin that has functions outside any class, it's better to have `BINARY` instead. Also, we could have use `java.lang.annotation.RetentionPolicy` anyways, since it's platform-specific. Thus, we need to have our own enum:
++
++``` kotlin
++package kotlin
++
++enum class AnnotationRetention {
++    SOURCE
++    BINARY
++    RUNTIME
++}
++```
++
++> Now, we could map `java.lang.annotation.Retention` and `RetentionPolicy` to `kotlin.retention` and `kotlin.AnnotationRetention`, and then map `CLASS` to `BINARY`, but that is a little too much
++
++Then, it makes sense to make `retention` a property of `kotlin.annotation`:
++
++``` kotlin
++target(TYPE)
++annotation(SOURCE) class MyAnn
++```
++
++The following checks must be performed at compile time:
++* `EXPRESSION`-targeted annotations can only have retention `SOURCE`
++
++## Repeatable
++
++> Java has `Repeatable` as an annotation, but we cannot map a Kotlin type to it, because it is only present since JDK 8, and cannot be written to class files with version lower than 8.
++
++We make `repeatable` a boolean property of `kotlin.annotation`, with default value `false` (as in Java and C#).
++
++If a non-repeatable annotation is used multiple times on the same element, it is a compile-time error.
++
++If a repeatable annotation is used multiple times on the same element, but the target byte code version is lower than Java 8, it is a compile-time error.
++
++## Inherited and Documented
++
++These two options have ratehr unclear value, and we do not supprt them in Kotlin. One can use platform-specific annotations to express them.
++
++## Appendix. Definition of kotlin.annotation
++
++``` kotlin
++package kotlin
++
++target(CLASSIFIER)","Should it be `ANNOTATION_CLASS`?
+",2015-04-03 15:25:27
+358,"@@ -0,0 +1,17 @@
++// !DIAGNOSTICS: -UNUSED_PARAMETER
++class C {
++    <!OVERLOADS_PRIVATE!>[kotlin.jvm.overloads] private fun foo(s: String = ""OK"")<!> {
++    }
++}
++
++fun foo() {
++    class D {
++        <!OVERLOADS_PRIVATE!>[kotlin.jvm.overloads] fun foo(s: String = ""OK"")<!> {
++        }
++    }
++
++    val <!UNUSED_VARIABLE!>x<!> = object {
++        <!OVERLOADS_PRIVATE!>[kotlin.jvm.overloads] fun foo(s: String = ""OK"")<!> {
++    }
++    }
++}","Please also add an `internal` member with `overloads` here, to ensure the warning is not reported on it
+",2015-04-01 14:28:30
+33,"@@ -0,0 +1,17 @@
++package test
++open class Foo() {
++open fun execute() : Unit {
++}
++}
++open class Bar() {
++var fooNotNull : Foo = Foo()
++var fooNullable : Foo? = null
++}
++open class Test() {
++public open fun test(barNotNull : Bar, barNullable : Bar?) : Unit {
++barNotNull.fooNotNull.execute()
++barNotNull.fooNullable?.execute()
++barNullable?.fooNotNull?.execute()
++barNullable?.fooNullable?.execute()
++}
++}
+\ No newline at end of file","Please fix code formatting in this test
+",2013-02-21 14:56:11
+835,"@@ -0,0 +1,181 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.tree.Tree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaClassifier
++import org.jetbrains.kotlin.name.FqName
++
++class TreePathResolverCache(private val javac: JavacWrapper) {
++
++    private val cache = hashMapOf<Tree, JavaClassifier?>()
++
++    fun resolve(treePath: TreePath): JavaClassifier? = with(treePath) {
++        if (cache.containsKey(leaf)) return cache[leaf]
++
++        return tryToGetClassifier().apply { cache[leaf] = this }
++    }
++
++    private fun TreePath.tryToGetClassifier(): JavaClassifier? {
++        val name = leaf.toString().substringBefore(""<"").substringAfter(""@"")
++        val nameParts = name.split(""."")
++
++        with(compilationUnit as JCTree.JCCompilationUnit) {
++            tryToResolveInner(name, javac, nameParts)?.let { return it }
++            tryToResolvePackageClass(name, javac, nameParts)?.let { return it }
++            tryToResolveByFqName(name, javac)?.let { return it }
++            tryToResolveSingleTypeImport(name, javac, nameParts)?.let { return it }
++            tryToResolveTypeImportOnDemand(name, javac, nameParts)?.let { return it }
++            tryToResolveInJavaLang(name, javac)?.let { return it }
++        }
++
++        return tryToResolveTypeParameter(javac)
++    }
++
++    private fun TreePath.tryToResolveInner(name: String,
++                                           javac: JavacWrapper,
++                                           nameParts: List<String> = emptyList()): JavaClass? = findEnclosingClasses(javac)
++            ?.forEach {
++                it.findInner(name, javac, nameParts)?.let { return it }
++            }.let { return null }
++
++    private fun TreePath.findEnclosingClasses(javac: JavacWrapper) = filterIsInstance<JCTree.JCClassDecl>()
++            .filter { it.extending != leaf && !it.implementing.contains(leaf) }
++            .reversed()
++            .joinToString(separator = ""."", prefix = ""${compilationUnit.packageName}."") { it.simpleName }
++            .let { javac.findClass(FqName(it)) }
++            ?.let {
++                arrayListOf(it).apply {
++                    var enclosingClass = it.outerClass
++                    while (enclosingClass != null) {
++                        add(enclosingClass)
++                        enclosingClass = enclosingClass.outerClass
++                    }
++                }
++            }
++
++    private fun JCTree.JCCompilationUnit.tryToResolveSingleTypeImport(name: String,
++                                                                      javac: JavacWrapper,
++                                                                      nameParts: List<String> = emptyList()): JavaClass? {
++        nameParts.size
++                .takeIf { it > 1 }
++                ?.let {
++                    imports.filter { it.qualifiedIdentifier.toString().endsWith("".${nameParts.first()}"") }
++                            .forEach { find(FqName(""${it.qualifiedIdentifier}""), javac, nameParts)?.let { return it } }
++                            .let { return null }
++                }
++
++        return imports
++                .find { it.qualifiedIdentifier.toString().endsWith("".$name"") }
++                ?.let {
++                    FqName(it.qualifiedIdentifier.toString())
++                            .let { javac.findClass(it) ?: javac.getKotlinClassifier(it) }
++                }
++    }
++
++    private fun JCTree.JCCompilationUnit.tryToResolvePackageClass(name: String,
++                                                                  javac: JavacWrapper,
++                                                                  nameParts: List<String> = emptyList()): JavaClass? {
++        return nameParts.size
++                .takeIf { it > 1 }
++                ?.let {
++                    find(FqName(""$packageName.${nameParts.first()}""), javac, nameParts)
++                } ?: javac.findClass(FqName(""$packageName.$name"")) ?: javac.getKotlinClassifier(FqName(""$packageName.$name""))
++    }
++
++    private fun JCTree.JCCompilationUnit.tryToResolveTypeImportOnDemand(name: String,
++                                                                        javac: JavacWrapper,
++                                                                        nameParts: List<String> = emptyList()): JavaClass? {
++        with(imports.filter { it.qualifiedIdentifier.toString().endsWith(""*"") }) {
++            nameParts.size
++                    .takeIf { it > 1 }
++                    ?.let {
++                        forEach { pack ->
++                            find(FqName(""${pack.qualifiedIdentifier.toString().substringBefore(""*"")}${nameParts.first()}""), javac, nameParts)
++                                    ?.let { return it }
++                        }.let { return null }
++                    }
++
++            forEach {
++                val fqName = ""${it.qualifiedIdentifier.toString().substringBefore(""*"")}$name"".let(::FqName)
++                (javac.findClass(fqName) ?: javac.getKotlinClassifier(fqName))?.let { return it }
++            }.let { return null }
++        }
++    }
++
++    private fun TreePath.tryToResolveTypeParameter(javac: JavacWrapper) =
++            filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }",This `filter` is not needed,2017-04-25 16:43:49
+410,"@@ -0,0 +1,183 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++
++
++fun<C, V, P: KProperty1<C,V>> C.propToParams(p: P, conv: ((v: V) -> String) = { it.toString() } ) =
++        listOf(""--daemon-"" + p.name, conv(p.get(this)))
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C, val prop: P, val parse: (s: String) -> V) {
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++fun Iterable<String>.propParseFilter(parsers: List<PropParser<*,*,*>>) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    return filter { param ->
++        if (currentParser == null) {
++            currentParser = parsers.find { param.equals(""--daemon-"" + it.prop.name) }
++            if (currentParser != null) {
++                if (currentParser is BoolPropParser<*,*>) {
++                    currentParser!!.apply("""")
++                    currentParser = null
++                }
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++public interface CmdlineParams : Serializable {
++    public val asParams: Iterable<String>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.propParseFilter(vararg cs: CmdlineParams) : Iterable<String> =
++    propParseFilter(cs.flatMap { it.parsers })
++
++
++public data class DaemonLaunchingOptions(
++        public var jvmParams: List<String> = listOf()
++) : CmdlineParams {
++
++    override val asParams: Iterable<String>
++        get() =
++            propToParams(::jvmParams, { it.joinToString(""##"") }) // TODO: consider some other options rather than using potentially dangerous delimiter
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::jvmParams, { it.split(""##"")})) // TODO: see appropriate comment in asParams
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val asParams: Iterable<String>
++        get() =
++            propToParams(::port) +
++            propToParams(::autoshutdownMemoryThreshold) +
++            propToParams(::autoshutdownIdleSeconds) +
++            propToParams(::startEcho)
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++
++fun updateSingleFileDigest(file: File, md: MessageDigest) {
++    val stream = DigestInputStream(file.inputStream(), md)
++    val buf = ByteArray(1024)
++    while (stream.read(buf) == buf.size()) {}","It is not guaranteed that the `read` operation reads the same amount of bytes as buffer can contain and it even may read zero bytes even if the file pointer is not at the end 
+",2015-08-19 22:36:30
+411,"@@ -0,0 +1,183 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++
++
++fun<C, V, P: KProperty1<C,V>> C.propToParams(p: P, conv: ((v: V) -> String) = { it.toString() } ) =
++        listOf(""--daemon-"" + p.name, conv(p.get(this)))
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C, val prop: P, val parse: (s: String) -> V) {
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++fun Iterable<String>.propParseFilter(parsers: List<PropParser<*,*,*>>) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    return filter { param ->
++        if (currentParser == null) {
++            currentParser = parsers.find { param.equals(""--daemon-"" + it.prop.name) }
++            if (currentParser != null) {
++                if (currentParser is BoolPropParser<*,*>) {
++                    currentParser!!.apply("""")
++                    currentParser = null
++                }
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++public interface CmdlineParams : Serializable {
++    public val asParams: Iterable<String>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.propParseFilter(vararg cs: CmdlineParams) : Iterable<String> =
++    propParseFilter(cs.flatMap { it.parsers })
++
++
++public data class DaemonLaunchingOptions(
++        public var jvmParams: List<String> = listOf()
++) : CmdlineParams {
++
++    override val asParams: Iterable<String>
++        get() =
++            propToParams(::jvmParams, { it.joinToString(""##"") }) // TODO: consider some other options rather than using potentially dangerous delimiter
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::jvmParams, { it.split(""##"")})) // TODO: see appropriate comment in asParams
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val asParams: Iterable<String>
++        get() =
++            propToParams(::port) +
++            propToParams(::autoshutdownMemoryThreshold) +
++            propToParams(::autoshutdownIdleSeconds) +
++            propToParams(::startEcho)
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++
++fun updateSingleFileDigest(file: File, md: MessageDigest) {
++    val stream = DigestInputStream(file.inputStream(), md)
++    val buf = ByteArray(1024)
++    while (stream.read(buf) == buf.size()) {}
++    stream.close()","shouldn't we use [`use` function](http://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io/use.html) here:
+
+```
+DigestInputStream(file.inputStream(), md).use { stream ->
+    // do stuff
+}
+```
+",2015-08-19 22:38:52
+144,"@@ -0,0 +1,185 @@
++/*
++* Copyright 2010-2014 JetBrains s.r.o.
++*
++* Licensed under the Apache License, Version 2.0 (the ""License"");
++* you may not use this file except in compliance with the License.
++* You may obtain a copy of the License at
++*
++* http://www.apache.org/licenses/LICENSE-2.0
++*
++* Unless required by applicable law or agreed to in writing, software
++* distributed under the License is distributed on an ""AS IS"" BASIS,
++* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++* See the License for the specific language governing permissions and
++* limitations under the License.
++*/
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetPostfixExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetElement
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.psiUtil.getQualifiedElementSelector
++
++public class OperatorToFunctionIntention : JetSelfTargetingIntention<JetExpression>(""operator.to.function"", javaClass()) {
++    fun isApplicablePrefix(element: JetPrefixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.PLUSPLUS, JetTokens.MINUSMINUS, JetTokens.EXCL -> true
++            else -> false
++        }
++    }
++
++    fun isApplicablePostfix(element: JetPostfixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUSPLUS, JetTokens.MINUSMINUS -> true
++            else -> false
++        }
++    }
++
++    fun isApplicableBinary(element: JetBinaryExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.MUL, JetTokens.DIV, JetTokens.PERC, JetTokens.RANGE, JetTokens.IN_KEYWORD, JetTokens.NOT_IN, JetTokens.PLUSEQ, JetTokens.MINUSEQ, JetTokens.MULTEQ, JetTokens.DIVEQ, JetTokens.PERCEQ, JetTokens.EQEQ, JetTokens.EXCLEQ, JetTokens.GT, JetTokens.LT, JetTokens.GTEQ, JetTokens.LTEQ -> true
++            JetTokens.EQ -> element.getLeft() is JetArrayAccessExpression
++            else -> false
++        }
++    }
++
++    fun isApplicableArrayAccess(element: JetArrayAccessExpression): Boolean {
++        return true
++    }
++
++    fun isApplicableCall(element: JetCallExpression): Boolean {
++        return element.getParent() !is JetDotQualifiedExpression && element.getValueArgumentList() != null
++    }
++
++    override fun isApplicableTo(element: JetExpression): Boolean {
++        return when (element) {
++            is JetPrefixExpression -> isApplicablePrefix(element)
++            // is JetPostfixExpression -> isApplicablePostfix(element)
++            is JetBinaryExpression -> isApplicableBinary(element)
++            is JetArrayAccessExpression -> isApplicableArrayAccess(element)
++            is JetCallExpression -> isApplicableCall(element)
++            else -> false
++        }
++    }
++
++
++    fun convertPrefix(element: JetPrefixExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val base = element.getBaseExpression()!!.getText()
++
++        val call = when (op) {
++            JetTokens.PLUS -> ""plus()""
++            JetTokens.MINUS -> ""minus()""
++            JetTokens.PLUSPLUS -> ""inc()""
++            JetTokens.MINUSMINUS -> ""dec()""
++            JetTokens.EXCL -> ""not()""
++            else -> return
++        }
++
++        val transformation = ""$base.$call""
++        val transformed = JetPsiFactory.createExpression(element.getProject(), transformation)
++        element.replace(transformed)
++    }
++
++    fun convertBinary(element: JetBinaryExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val left = element.getLeft()!!
++        val right = element.getRight()!!
++        val leftText = left.getText()
++        val rightText = right.getText()
++
++        if (op == JetTokens.EQ) {
++            if (left is JetArrayAccessExpression) {
++                convertArrayAccess(left as JetArrayAccessExpression)
++            }
++            return
++        }
++
++        val transformation = when (op) {
++            JetTokens.PLUS -> ""$leftText.plus($rightText)""
++            JetTokens.MINUS -> ""$leftText.minus($rightText)""
++            JetTokens.MUL -> ""$leftText.times($rightText)""
++            JetTokens.DIV -> ""$leftText.div($rightText)""
++            JetTokens.PERC -> ""$leftText.mod($rightText)""
++            JetTokens.RANGE -> ""$leftText.rangeTo($rightText)""
++            JetTokens.IN_KEYWORD -> ""$rightText.contains($leftText)""
++            JetTokens.NOT_IN -> ""!$rightText.contains($leftText)""
++            JetTokens.PLUSEQ -> ""$leftText.plusAssign($rightText)""
++            JetTokens.MINUSEQ -> ""$leftText.minusAssign($rightText)""
++            JetTokens.MULTEQ -> ""$leftText.timesAssign($rightText)""
++            JetTokens.DIVEQ -> ""$leftText.divAssign($rightText)""
++            JetTokens.PERCEQ -> ""$leftText.modAssign($rightText)""
++            JetTokens.EQEQ -> ""$leftText?.equals($rightText) ?: $rightText.identityEquals(null)""
++            JetTokens.EXCLEQ -> ""!($leftText?.equals($rightText) ?: $rightText.identityEquals(null))""
++            JetTokens.GT -> ""$leftText.compareTo($rightText) > 0""
++            JetTokens.LT -> ""$leftText.compareTo($rightText) < 0""
++            JetTokens.GTEQ -> ""$leftText.compareTo($rightText) >= 0""
++            JetTokens.LTEQ -> ""$leftText.compareTo($rightText) <= 0""
++            else -> return
++        }
++
++        val transformed = JetPsiFactory.createExpression(element.getProject(), transformation)
++
++        val newCalleeExpression = left
++        val context = AnalyzerFacadeWithCache.getContextForElement(newCalleeExpression)
++        val functionCandidates = context[BindingContext.AMBIGUOUS_REFERENCE_TARGET, newCalleeExpression]","`functionCandidates` is always null for me here. I think it has to do with me using a the `PsiElement` `left` rather than a `JetElement`. I can't seem to figure out what it is, though. Is there a way to create a `JetElement` from a string?
+",2014-04-07 07:49:29
+422,"@@ -0,0 +1,192 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.service
++
++import org.jetbrains.kotlin.cli.common.CLICompiler
++import org.jetbrains.kotlin.cli.jvm.K2JVMCompiler
++import org.jetbrains.kotlin.config.Services
++import org.jetbrains.kotlin.incremental.components.LookupTracker
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.rmi.*
++import org.jetbrains.kotlin.rmi.service.RemoteIncrementalCacheClient
++import org.jetbrains.kotlin.rmi.service.RemoteOutputStreamClient
++import java.io.File
++import java.io.FileNotFoundException
++import java.io.IOException
++import java.io.PrintStream
++import java.net.URLClassLoader
++import java.rmi.registry.Registry
++import java.rmi.server.UnicastRemoteObject
++import java.util.*
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import java.util.jar.Manifest
++import java.util.logging.Logger
++import kotlin.concurrent.read
++import kotlin.concurrent.write
++
++
++class CompileServiceImpl<Compiler: CLICompiler<*>>(
++        val registry: Registry,
++        val compiler: Compiler,
++        val selfCompilerId: CompilerId,
++        val daemonOptions: DaemonOptions
++) : CompileService, UnicastRemoteObject() {
++
++    val log by lazy { Logger.getLogger(""compiler"") }
++
++    private val rwlock = ReentrantReadWriteLock()
++    private var alive = false
++
++    // TODO: consider matching compilerId coming from outside with actual one
++//    private val selfCompilerId by lazy {
++//        CompilerId(
++//                compilerClasspath = System.getProperty(""java.class.path"")
++//                                            ?.split(File.pathSeparator)
++//                                            ?.map { File(it) }
++//                                            ?.filter { it.exists() }
++//                                            ?.map { it.absolutePath }
++//                                    ?: listOf(),
++//                compilerVersion = loadKotlinVersionFromResource()
++//        )
++//    }
++
++    init {
++        // assuming logically synchronized
++        try {
++            // cleanup for the case of incorrect restart
++            UnicastRemoteObject.unexportObject(this, false)
++        }
++        catch (e: java.rmi.NoSuchObjectException) {
++            // ignoring if object already exported
++        }
++
++        val stub = UnicastRemoteObject.exportObject(this, 0) as CompileService
++        // TODO: use version-specific name
++        registry.rebind (COMPILER_SERVICE_RMI_NAME, stub);
++        alive = true
++    }
++
++    public class IncrementalCompilationComponentsImpl(val idToCache: Map<String, CompileService.RemoteIncrementalCache>): IncrementalCompilationComponents {
++        // perf: cheap object, but still the pattern may be costly if there are too many calls to cache with the same id (which seems not to be the case now)
++        override fun getIncrementalCache(moduleId: String): IncrementalCache = RemoteIncrementalCacheClient(idToCache[moduleId]!!)
++        override fun getLookupTracker(): LookupTracker = LookupTracker.DO_NOTHING
++    }
++
++    private fun createCompileServices(incrementalCaches: Map<String, CompileService.RemoteIncrementalCache>): Services =
++        Services.Builder()
++                .register(javaClass<IncrementalCompilationComponents>(), IncrementalCompilationComponentsImpl(incrementalCaches))
++//                .register(javaClass<CompilationCanceledStatus>(), object: CompilationCanceledStatus {
++//                    override fun checkCanceled(): Unit = if (context.getCancelStatus().isCanceled()) throw CompilationCanceledException()
++//                })
++                .build()
++
++
++    fun usedMemory(): Long {
++        System.gc()
++        val rt = Runtime.getRuntime()
++        return (rt.totalMemory() - rt.freeMemory())","I think you can get more accurate information using the MemoryMXBean class.
+",2015-08-20 14:41:14
+983,"@@ -0,0 +1,194 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.builtins.DefaultBuiltIns
++import org.jetbrains.kotlin.descriptors.ModuleDescriptor
++import org.jetbrains.kotlin.effectsystem.factories.createConstant
++import org.jetbrains.kotlin.effectsystem.functors.*
++import org.jetbrains.kotlin.effectsystem.resolving.FunctorResolver
++import org.jetbrains.kotlin.effectsystem.structure.ESFunctor
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.structure.UNIT_ID
++import org.jetbrains.kotlin.effectsystem.structure.calltree.*
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.calls.model.ExpressionValueArgument
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValue
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValueFactory
++import org.jetbrains.kotlin.resolve.constants.CompileTimeConstant
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.utils.addToStdlib.cast
++import org.jetbrains.kotlin.utils.ifEmpty
++
++/**
++ * Visits Psi-tree and builds Call Tree
++ */
++class CallTreeBuilder(
++        private val bindingContext: BindingContext,
++        private val moduleDescriptor: ModuleDescriptor,
++        private val functorResolver: FunctorResolver
++) : KtVisitor<CTNode, Unit>() {
++
++    override fun visitKtElement(element: KtElement, data: Unit): CTNode = UNKNOWN_CALL
++
++    override fun visitConstantExpression(expression: KtConstantExpression, data: Unit): CTNode {
++        val bindingContext = bindingContext
++
++        val type: KotlinType = bindingContext.getType(expression) ?: return UNKNOWN_CALL
++
++        val compileTimeConstant: CompileTimeConstant<*>
++                = bindingContext.get(BindingContext.COMPILE_TIME_VALUE, expression) ?: return UNKNOWN_CALL
++        val value: Any? = compileTimeConstant.getValue(type)
++        return CTConstant(ValueIdsFactory.idForConstant(value), type, value)
++    }
++
++    override fun visitSimpleNameExpression(expression: KtSimpleNameExpression, data: Unit): CTNode {
++        // TODO: make proper resolving
++        if (expression.text == ""Unit"") return CTConstant(UNIT_ID, DefaultBuiltIns.Instance.unitType, Unit)
++        return tryCreateVariable(expression)
++    }
++
++    override fun visitParenthesizedExpression(expression: KtParenthesizedExpression, data: Unit): CTNode {
++        val deparenthesized = KtPsiUtil.safeDeparenthesize(expression)
++        return if (deparenthesized == expression) UNKNOWN_CALL else deparenthesized.accept(this, data)
++    }
++
++    override fun visitUnaryExpression(expression: KtUnaryExpression, data: Unit): CTCall {
++        tryGetCachedCall(expression)?.let { return it }
++
++        val argNode = expression.baseExpression?.accept(this, data) ?: return UNKNOWN_CALL
++        return when (expression.operationToken) {
++            KtTokens.EXCL -> CTCall(NotFunctor(), listOf(argNode))
++            else -> return UNKNOWN_CALL
++        }
++    }
++
++    override fun visitDotQualifiedExpression(expression: KtDotQualifiedExpression, data: Unit): CTCall {
++        tryGetCachedCall(expression)?.let { return it }
++
++        val receiver = expression.receiverExpression.accept(this, data)
++
++        val resolvedCall = expression.selectorExpression.getResolvedCall(bindingContext) ?: return UNKNOWN_CALL
++        val argNodes = resolvedCall.valueArgumentsByIndex?.map {
++            (it as? ExpressionValueArgument)?.valueArgument?.getArgumentExpression()?.accept(this, data) ?: return UNKNOWN_CALL
++        } ?: return UNKNOWN_CALL
++
++        val functor = functorResolver.resolveFunctor(resolvedCall) ?: return UNKNOWN_CALL
++        return CTCall(functor, listOf(receiver) + argNodes)
++    }
++
++    override fun visitThisExpression(expression: KtThisExpression, data: Unit?): CTNode {
++        val dfv = expression.createDataFlowValue() ?: return UNKNOWN_CALL // Could be possible for unavailable/incorrect this
++        return CTVariable(ValueIdsFactory.dfvBased(dfv), dfv.type)
++    }
++
++    override fun visitClassLiteralExpression(expression: KtClassLiteralExpression, data: Unit?): CTNode = tryCreateVariable(expression)
++
++    override fun visitLabeledExpression(expression: KtLabeledExpression, data: Unit): CTNode = expression.baseExpression?.accept(this, data) ?: UNKNOWN_CALL
++
++    override fun visitBinaryExpression(expression: KtBinaryExpression, data: Unit): CTCall {
++        tryGetCachedCall(expression)?.let { return it }
++
++        val leftNode = expression.left?.accept(this, data) ?: return UNKNOWN_CALL
++        val rightNode = expression.right?.accept(this, data) ?: return UNKNOWN_CALL
++
++        val functor = when (expression.operationToken) {
++            KtTokens.EQEQ, KtTokens.EQEQEQ -> {",Not quite sure should reference comparison be here.,2017-08-15 16:50:22
+30,"@@ -0,0 +1,2 @@
++// ""Change type argument list to <*>"" ""true""
++fun isStringList(list : Any?) = list is (List<<caret>String>)","At first, I've added the parentheses because this way it's more readable to me. But as I was trying to implement the quickfix I realised that it would be possible to make mistake in this case: change ""(List<String>)"" to ""List<*>"". That's why I left the parentheses in one test case.
+",2013-02-21 09:21:48
+370,"@@ -0,0 +1,202 @@
++# @-based Syntax For Annotations
++
++Goals:
++* Spare `[...]` in expression position for future use
++* Support targeting for annotations (`field`, `getter` etc)
++* Preserve affected/clashing functionality (`@labels`)
++* Support `open` and other modifiers on local classes
++
++## Examples
++
++Annotation:
++``` kotlin
++@AnnotationName(args)
++class Foo
++```
++
++Targeted annotation:
++``` kotlin
++class C(@field:Foo val x: Int, @field,parameter:Bar val y: Int)
++```
++
++another option (like in Scala):
++``` kotlin
++class C(@(Foo@field) val x: Int, @(Bar@(field,parameter)) val y: Int)
++```
++
++yet another option (requires allowing annotation arrays at least in source-retained annotations):
++
++``` kotlin
++class C(@field(@Foo) val x: Int, @field(@Bar) @parameter(@Bar) val y: Int)
++```
++
++Labels:
++``` kotlin
++loop@ // declaring a label
++for (x in foo) {
++    if (x > 0) continue@loop // using a label
++}
++```
++
++## Syntactic Disambiguation
++
++How can we avoid confusion between `continue@loop` and
++
++``` kotlin
++if (foo) continue
++@ann val x = 1
++```
++
++or `return@label (x + 1) + 5` and `return @ann(x + 1) +5`
++
++Rules:
++* no newline allowed between `continue`/`break`/`this`/`super`/`return` and `@label`
++* only one label allowed after these keywords, everything after the first label is an annotation
++* for `return` we prefer `return@label` to `return @ann expr`, so one should say `return (@ann expr)`
++
++## Targeting 
++
++Possible targets are
++* `field`
++* `get`
++* `set`
++* `property`
++* `parameter` - for constructor parameters that are also properties
++
++Reasonable defaults would probably be:
++* `field` if there's a backing field
++* `get` otherwise","Maybe it's worth to mention default target for constructor parameters? Will it be `parameter` for simple parameters and for fields? 
+",2015-04-05 22:23:49
+371,"@@ -0,0 +1,202 @@
++# @-based Syntax For Annotations
++
++Goals:
++* Spare `[...]` in expression position for future use
++* Support targeting for annotations (`field`, `getter` etc)
++* Preserve affected/clashing functionality (`@labels`)
++* Support `open` and other modifiers on local classes
++
++## Examples
++
++Annotation:
++``` kotlin
++@AnnotationName(args)
++class Foo
++```
++
++Targeted annotation:
++``` kotlin
++class C(@field:Foo val x: Int, @field,parameter:Bar val y: Int)
++```
++
++another option (like in Scala):
++``` kotlin
++class C(@(Foo@field) val x: Int, @(Bar@(field,parameter)) val y: Int)
++```
++
++yet another option (requires allowing annotation arrays at least in source-retained annotations):
++
++``` kotlin
++class C(@field(@Foo) val x: Int, @field(@Bar) @parameter(@Bar) val y: Int)
++```
++
++Labels:
++``` kotlin
++loop@ // declaring a label
++for (x in foo) {
++    if (x > 0) continue@loop // using a label
++}
++```
++
++## Syntactic Disambiguation
++
++How can we avoid confusion between `continue@loop` and
++
++``` kotlin
++if (foo) continue
++@ann val x = 1
++```
++
++or `return@label (x + 1) + 5` and `return @ann(x + 1) +5`
++
++Rules:
++* no newline allowed between `continue`/`break`/`this`/`super`/`return` and `@label`
++* only one label allowed after these keywords, everything after the first label is an annotation
++* for `return` we prefer `return@label` to `return @ann expr`, so one should say `return (@ann expr)`
++
++## Targeting 
++
++Possible targets are
++* `field`
++* `get`
++* `set`
++* `property`
++* `parameter` - for constructor parameters that are also properties
++
++Reasonable defaults would probably be:
++* `field` if there's a backing field
++* `get` otherwise
++
++Otherwise, determined by the settings of the annotation itself (applicable to fields only -> goes to a field)","Shall we really allow omitting the non-default target in code? It's a clear message with quick-fix for a code writter and possible source of misunderstanding for a reader that can't be resolved without navigating to annotation declaration. And annotation target settings modification can lead to unexpected tools failures without any compiler messages on rebuild.  
+",2015-04-05 22:36:55
+369,"@@ -0,0 +1,202 @@
++# @-based Syntax For Annotations
++
++Goals:
++* Spare `[...]` in expression position for future use
++* Support targeting for annotations (`field`, `getter` etc)
++* Preserve affected/clashing functionality (`@labels`)
++* Support `open` and other modifiers on local classes
++
++## Examples
++
++Annotation:
++``` kotlin
++@AnnotationName(args)
++class Foo
++```
++
++Targeted annotation:
++``` kotlin
++class C(@field:Foo val x: Int, @field,parameter:Bar val y: Int)
++```
++
++another option (like in Scala):
++``` kotlin
++class C(@(Foo@field) val x: Int, @(Bar@(field,parameter)) val y: Int)
++```
++
++yet another option (requires allowing annotation arrays at least in source-retained annotations):
++
++``` kotlin
++class C(@field(@Foo) val x: Int, @field(@Bar) @parameter(@Bar) val y: Int)
++```
++
++Labels:
++``` kotlin
++loop@ // declaring a label
++for (x in foo) {
++    if (x > 0) continue@loop // using a label
++}
++```
++
++## Syntactic Disambiguation
++
++How can we avoid confusion between `continue@loop` and
++
++``` kotlin
++if (foo) continue
++@ann val x = 1
++```
++
++or `return@label (x + 1) + 5` and `return @ann(x + 1) +5`
++
++Rules:
++* no newline allowed between `continue`/`break`/`this`/`super`/`return` and `@label`
++* only one label allowed after these keywords, everything after the first label is an annotation
++* for `return` we prefer `return@label` to `return @ann expr`, so one should say `return (@ann expr)`
++
++## Targeting 
++
++Possible targets are
++* `field`
++* `get`
++* `set`
++* `property`
++* `parameter` - for constructor parameters that are also properties
++
++Reasonable defaults would probably be:
++* `field` if there's a backing field
++* `get` otherwise
++
++Otherwise, determined by the settings of the annotation itself (applicable to fields only -> goes to a field)
++
++### Possible Syntax for Targeting
++
++Special syntax:
++
++``` kotlin
++class C(@field:Ann(""arg"") var foo: Int)
++```
++
++This is a rather limited dedicated solution: it is unclear, for example, how you define a new target, also this syntax can not be used for anything else but targeting.
++
++Scala-like syntax:
++
++``` kotlin
++class C(@(Ann@field)(""arg"") var foo: Int)
++```
++
++Too many parentheses, but the mechanism is generic.
++
++Annotation-array-based syntax:
++
++``` kotlin
++class C(@field(@Ann1(""arg""), @Ann2) var foo: Int)
++```
++
++Downside: to put the same annotation on two targets, we'd need to duplicate it.
++
++For this, we need to allow annotation attributes of type `Array<Annotation>`:
++
++``` kotlin
++annotation class field(vararg val annotations: Annotation)
++```
++**NOTE**: This is only relatively easilty achievable for source-retained annotations, for class- or runtime-retained it's a lot more involved and relies on an undocumented features of JVM.","eastlty -> easily
+",2015-04-05 22:18:54
+459,"@@ -0,0 +1,202 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.service
++
++import org.jetbrains.kotlin.cli.common.CLICompiler
++import org.jetbrains.kotlin.config.Services
++import org.jetbrains.kotlin.incremental.components.LookupTracker
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.rmi.*
++import org.jetbrains.kotlin.rmi.service.RemoteIncrementalCacheClient
++import org.jetbrains.kotlin.rmi.service.RemoteOutputStreamClient
++import java.io.IOException
++import java.io.PrintStream
++import java.lang.management.ManagementFactory
++import java.net.URLClassLoader
++import java.rmi.registry.Registry
++import java.rmi.server.UnicastRemoteObject
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import java.util.jar.Manifest
++import java.util.logging.Logger
++import kotlin.concurrent.read
++import kotlin.concurrent.write
++
++
++class CompileServiceImpl<Compiler: CLICompiler<*>>(
++        val registry: Registry,
++        val compiler: Compiler,
++        val selfCompilerId: CompilerId,
++        val daemonOptions: DaemonOptions
++) : CompileService, UnicastRemoteObject() {
++
++    val log by lazy { Logger.getLogger(""compiler"") }
++
++    private val rwlock = ReentrantReadWriteLock()
++    private var alive = false
++
++    // TODO: consider matching compilerId coming from outside with actual one
++//    private val selfCompilerId by lazy {
++//        CompilerId(
++//                compilerClasspath = System.getProperty(""java.class.path"")
++//                                            ?.split(File.pathSeparator)
++//                                            ?.map { File(it) }
++//                                            ?.filter { it.exists() }
++//                                            ?.map { it.absolutePath }
++//                                    ?: listOf(),
++//                compilerVersion = loadKotlinVersionFromResource()
++//        )
++//    }
++
++    init {
++        // assuming logically synchronized
++        try {
++            // cleanup for the case of incorrect restart
++            UnicastRemoteObject.unexportObject(this, false)
++        }
++        catch (e: java.rmi.NoSuchObjectException) {
++            // ignoring if object already exported
++        }
++
++        val stub = UnicastRemoteObject.exportObject(this, 0) as CompileService
++        // TODO: use version-specific name
++        registry.rebind (COMPILER_SERVICE_RMI_NAME, stub);
++        alive = true
++    }
++
++    public class IncrementalCompilationComponentsImpl(val idToCache: Map<String, CompileService.RemoteIncrementalCache>): IncrementalCompilationComponents {
++        // perf: cheap object, but still the pattern may be costly if there are too many calls to cache with the same id (which seems not to be the case now)
++        override fun getIncrementalCache(moduleId: String): IncrementalCache = RemoteIncrementalCacheClient(idToCache[moduleId]!!)
++        // TODO: add appropriate proxy into interaction when lookup tracker is needed
++        override fun getLookupTracker(): LookupTracker = LookupTracker.DO_NOTHING
++    }
++
++    private fun createCompileServices(incrementalCaches: Map<String, CompileService.RemoteIncrementalCache>): Services =
++        Services.Builder()
++                .register(IncrementalCompilationComponents::class.java, IncrementalCompilationComponentsImpl(incrementalCaches))
++                // TODO: add remote proxy for cancellation status tracking
++//                .register(javaClass<CompilationCanceledStatus>(), object: CompilationCanceledStatus {
++//                    override fun checkCanceled(): Unit = if (context.getCancelStatus().isCanceled()) throw CompilationCanceledException()
++//                })
++                .build()
++
++
++    fun usedMemory(): Long {
++        System.gc()
++        val rt = Runtime.getRuntime()
++        return (rt.totalMemory() - rt.freeMemory())
++    }
++
++    fun usedMemoryMX(): Long {
++        System.gc()
++        val memoryMXBean= ManagementFactory.getMemoryMXBean()
++        val memHeap=memoryMXBean.getHeapMemoryUsage()
++        return memHeap.used
++    }
++
++    // TODO: consider using version as a part of compiler ID or drop this function
++    private fun loadKotlinVersionFromResource(): String {
++        (javaClass.classLoader as? URLClassLoader)
++        ?.findResource(""META-INF/MANIFEST.MF"")
++        ?.let {
++            try {
++                return Manifest(it.openStream()).mainAttributes.getValue(""Implementation-Version"") ?: """"
++            }
++            catch (e: IOException) {}
++        }
++        return """"
++    }
++
++
++    fun<R> checkedCompile(args: Array<out String>, body: () -> R): R {
++        try {
++            if (args.none())
++                throw IllegalArgumentException(""Error: empty arguments list."")
++            log.info(""Starting compilation with args: "" + args.joinToString("" ""))
++            val startMemMX = usedMemoryMX() / 1024
++            val startMem = usedMemory() / 1024
++            val startTime = System.nanoTime()
++            val res = body()
++            val endTime = System.nanoTime()
++            val endMem = usedMemory() / 1024
++            val endMemMX = usedMemoryMX() / 1024
++            log.info(""Done with result "" + res.toString())
++            log.info(""Elapsed time: "" + TimeUnit.NANOSECONDS.toMillis(endTime - startTime) + "" ms"")
++            log.info(""Used memory: $endMem kb (${""%+d"".format(endMem - startMem)} kb)"")
++            log.info(""Used memory (from MemoryMXBean): $endMemMX kb (${""%+d"".format(endMemMX - startMemMX)} kb)"")
++            return res
++        }
++        catch (e: Exception) {
++            log.info(""Error: $e"")
++            throw e
++        }
++    }
++
++    fun<R> ifAlive(body: () -> R): R = rwlock.read {
++        if (!alive) throw IllegalStateException(""Kotlin Compiler Service is not in alive state"")
++        else body()
++    }
++
++    fun<R> ifAliveExclusive(body: () -> R): R = rwlock.write {
++        if (!alive) throw IllegalStateException(""Kotlin Compiler Service is not in alive state"")
++        else body()
++    }
++
++    // sometimes used for debugging
++    fun<R> spy(msg: String, body: () -> R): R {
++        val res = body()
++        log.info(msg + "" = "" + res.toString())
++        return res
++    }
++
++    override fun getCompilerId(): CompilerId = ifAlive { selfCompilerId }
++
++    override fun getUsedMemory(): Long = ifAlive { usedMemory() }
++
++    override fun shutdown() {
++        ifAliveExclusive {
++            log.info(""Shutdown started"")
++            alive = false
++            UnicastRemoteObject.unexportObject(this, true)
++            log.info(""Shutdown complete"")
++        }
++    }
++
++    override fun remoteCompile(args: Array<out String>, errStream: RemoteOutputStream, outputFormat: CompileService.OutputFormat): Int =
++        doCompile(args, errStream) { printStream ->
++            when (outputFormat) {
++                CompileService.OutputFormat.PLAIN -> compiler.exec(printStream, *args)
++                CompileService.OutputFormat.XML -> compiler.execAndOutputXml(printStream, Services.EMPTY, *args)
++            }.code
++        }
++
++    override fun remoteIncrementalCompile(args: Array<out String>, caches: Map<String, CompileService.RemoteIncrementalCache>, outputStream: RemoteOutputStream, outputFormat: CompileService.OutputFormat): Int =
++        doCompile(args, outputStream) { printStream ->
++            when (outputFormat) {
++                CompileService.OutputFormat.PLAIN -> throw NotImplementedError(""Only XML output is supported in remote incremental compilation"")
++                CompileService.OutputFormat.XML -> compiler.execAndOutputXml(printStream, createCompileServices(caches), *args)
++            }.code
++        }
++
++    fun doCompile(args: Array<out String>, errStream: RemoteOutputStream, body: (PrintStream) -> Int): Int =","I'd write something like:
+
+``` kotlin
+    override fun remoteCompile(args: Array<out String>, errStream: RemoteOutputStream, outputFormat: CompileService.OutputFormat): Int =
+        doCompile(args, errStream, outputFormat) { compiler.exec(it, *args) }
+
+    override fun remoteIncrementalCompile(args: Array<out String>, caches: Map<String, CompileService.RemoteIncrementalCache>, outputStream: RemoteOutputStream, outputFormat: CompileService.OutputFormat): Int =
+        doCompile(args, outputStream, outputFormat) { throw NotImplementedError(""Only XML output is supported in remote incremental compilation"") }
+
+    fun doCompile(args: Array<out String>, errStream: RemoteOutputStream, outputFormat: CompileService.OutputFormat, compileWithPlainOut: (PrintStream) -> ExitCode): Int =
+            ifAlive {
+                checkedCompile(args) {
+                    val remoteStreamClient = RemoteOutputStreamClient(errStream)
+                    val printStream = PrintStream(remoteStreamClient)
+                    when (outputFormat) {
+                        CompileService.OutputFormat.PLAIN -> compileWithPlainOut(printStream)
+                        CompileService.OutputFormat.XML -> compiler.execAndOutputXml(printStream, Services.EMPTY, *args)
+                    }.code
+                }
+            }
+```
+",2015-08-31 11:34:37
+501,"@@ -0,0 +1,203 @@
++/*","As far as I understand these functions are copies of functions at KotlinBuilder. Why not to reuse them at KotlinBuilder? I mean, these functions are in build common, so their originals from KotlinBuilder can be removed.
+",2016-02-02 15:18:00
+350,"@@ -0,0 +1,204 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.codegen
++
++import org.jetbrains.kotlin.codegen.binding.CodegenBinding
++import org.jetbrains.kotlin.codegen.context.CodegenContext
++import org.jetbrains.kotlin.codegen.state.GenerationState
++import org.jetbrains.kotlin.descriptors.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.JetClass
++import org.jetbrains.kotlin.psi.JetClassOrObject
++import org.jetbrains.kotlin.psi.JetElement
++import org.jetbrains.kotlin.psi.JetNamedFunction
++import org.jetbrains.kotlin.resolve.jvm.AsmTypes
++import org.jetbrains.kotlin.resolve.jvm.diagnostics.OtherOrigin
++import org.jetbrains.org.objectweb.asm.Opcodes
++import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter
++
++/**
++ * Generates Java overloads for functions and constructors that have the default
++ * parameter values substituted.
++ */
++public class DefaultParameterValueSubstitutor(val state: GenerationState) {
++    /**
++     * If all of the parameters of the specified constructor declare default values,
++     * generates a no-argument constructor that passes default values for all arguments.
++     */
++    fun generateDefaultConstructorIfNeeded(constructorDescriptor: ConstructorDescriptor,
++                                           classBuilder: ClassBuilder,
++                                           context: CodegenContext<*>,
++                                           classOrObject: JetClassOrObject) {
++        if (!isEmptyConstructorNeeded(constructorDescriptor, classOrObject)) {
++            return
++        }
++
++        generateOverloadWithSubstitutedParameters(constructorDescriptor, constructorDescriptor, classBuilder, classOrObject,
++                                                  context,
++                                                  constructorDescriptor.countDefaultParameters())
++    }
++
++    /**
++     * If the function is annotated with [kotlin.jvm.overloads], generates Java methods that
++     * have the default parameter values substituted. If a method has N parameters and M of which
++     * have default values, M overloads are generated: the first one takes N-1 parameters (all but
++     * the last one that takes a default value), the second takes N-2 parameters, and so on.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     */
++    fun generateOverloadsIfNeeded(function: JetNamedFunction,
++                                  functionDescriptor: FunctionDescriptor,
++                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                  owner: CodegenContext<*>,
++                                  classBuilder: ClassBuilder) {
++        val overloadsFqName = FqName.fromSegments(listOf(""kotlin"", ""jvm"", ""overloads""))","`FqName(""kotlin.jvm.overloads"")` would be more grep-friendly. Also I would make it a constant (either top-level or in the companion)
+",2015-03-31 09:00:41
+351,"@@ -0,0 +1,204 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.codegen
++
++import org.jetbrains.kotlin.codegen.binding.CodegenBinding
++import org.jetbrains.kotlin.codegen.context.CodegenContext
++import org.jetbrains.kotlin.codegen.state.GenerationState
++import org.jetbrains.kotlin.descriptors.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.JetClass
++import org.jetbrains.kotlin.psi.JetClassOrObject
++import org.jetbrains.kotlin.psi.JetElement
++import org.jetbrains.kotlin.psi.JetNamedFunction
++import org.jetbrains.kotlin.resolve.jvm.AsmTypes
++import org.jetbrains.kotlin.resolve.jvm.diagnostics.OtherOrigin
++import org.jetbrains.org.objectweb.asm.Opcodes
++import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter
++
++/**
++ * Generates Java overloads for functions and constructors that have the default
++ * parameter values substituted.
++ */
++public class DefaultParameterValueSubstitutor(val state: GenerationState) {
++    /**
++     * If all of the parameters of the specified constructor declare default values,
++     * generates a no-argument constructor that passes default values for all arguments.
++     */
++    fun generateDefaultConstructorIfNeeded(constructorDescriptor: ConstructorDescriptor,
++                                           classBuilder: ClassBuilder,
++                                           context: CodegenContext<*>,
++                                           classOrObject: JetClassOrObject) {
++        if (!isEmptyConstructorNeeded(constructorDescriptor, classOrObject)) {
++            return
++        }
++
++        generateOverloadWithSubstitutedParameters(constructorDescriptor, constructorDescriptor, classBuilder, classOrObject,
++                                                  context,
++                                                  constructorDescriptor.countDefaultParameters())
++    }
++
++    /**
++     * If the function is annotated with [kotlin.jvm.overloads], generates Java methods that
++     * have the default parameter values substituted. If a method has N parameters and M of which
++     * have default values, M overloads are generated: the first one takes N-1 parameters (all but
++     * the last one that takes a default value), the second takes N-2 parameters, and so on.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     */
++    fun generateOverloadsIfNeeded(function: JetNamedFunction,
++                                  functionDescriptor: FunctionDescriptor,
++                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                  owner: CodegenContext<*>,
++                                  classBuilder: ClassBuilder) {
++        val overloadsFqName = FqName.fromSegments(listOf(""kotlin"", ""jvm"", ""overloads""))
++        if (functionDescriptor.getAnnotations().findAnnotation(overloadsFqName) == null) return
++
++        val count = functionDescriptor.countDefaultParameters()
++        val context = owner.intoFunction(functionDescriptor)
++
++        for (i in 1..count) {
++            generateOverloadWithSubstitutedParameters(functionDescriptor, delegateFunctionDescriptor, classBuilder, function, context, i)
++        }
++    }
++
++    private fun FunctionDescriptor.countDefaultParameters() =
++        getValueParameters().count { it.hasDefaultValue() }
++
++    /**
++     * Generates an overload for [functionDescriptor] that substitutes default values for the last
++     * [substituteCount] parameters that have default values.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     * @param methodElement the PSI element for the method implementation (used in diagnostic messages only)
++     */
++    fun generateOverloadWithSubstitutedParameters(functionDescriptor: FunctionDescriptor,
++                                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                                  classBuilder: ClassBuilder,
++                                                  methodElement: JetElement?,
++                                                  context: CodegenContext<*>,
++                                                  substituteCount: Int) {
++        val isStatic = AsmUtil.isStaticMethod(context.getContextKind(), functionDescriptor)
++        val flags = AsmUtil.getVisibilityAccessFlag(functionDescriptor) or (if (isStatic) Opcodes.ACC_STATIC else 0)
++        val remainingParameters = getRemainingParameters(functionDescriptor.getOriginal(), substituteCount)
++        val signature = state.getTypeMapper().mapSignature(functionDescriptor, context.getContextKind(),","Please extract `state.getTypeMapper()` to a property
+",2015-03-31 09:15:22
+354,"@@ -0,0 +1,204 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.codegen
++
++import org.jetbrains.kotlin.codegen.binding.CodegenBinding
++import org.jetbrains.kotlin.codegen.context.CodegenContext
++import org.jetbrains.kotlin.codegen.state.GenerationState
++import org.jetbrains.kotlin.descriptors.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.JetClass
++import org.jetbrains.kotlin.psi.JetClassOrObject
++import org.jetbrains.kotlin.psi.JetElement
++import org.jetbrains.kotlin.psi.JetNamedFunction
++import org.jetbrains.kotlin.resolve.jvm.AsmTypes
++import org.jetbrains.kotlin.resolve.jvm.diagnostics.OtherOrigin
++import org.jetbrains.org.objectweb.asm.Opcodes
++import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter
++
++/**
++ * Generates Java overloads for functions and constructors that have the default
++ * parameter values substituted.
++ */
++public class DefaultParameterValueSubstitutor(val state: GenerationState) {
++    /**
++     * If all of the parameters of the specified constructor declare default values,
++     * generates a no-argument constructor that passes default values for all arguments.
++     */
++    fun generateDefaultConstructorIfNeeded(constructorDescriptor: ConstructorDescriptor,
++                                           classBuilder: ClassBuilder,
++                                           context: CodegenContext<*>,
++                                           classOrObject: JetClassOrObject) {
++        if (!isEmptyConstructorNeeded(constructorDescriptor, classOrObject)) {
++            return
++        }
++
++        generateOverloadWithSubstitutedParameters(constructorDescriptor, constructorDescriptor, classBuilder, classOrObject,
++                                                  context,
++                                                  constructorDescriptor.countDefaultParameters())
++    }
++
++    /**
++     * If the function is annotated with [kotlin.jvm.overloads], generates Java methods that
++     * have the default parameter values substituted. If a method has N parameters and M of which
++     * have default values, M overloads are generated: the first one takes N-1 parameters (all but
++     * the last one that takes a default value), the second takes N-2 parameters, and so on.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     */
++    fun generateOverloadsIfNeeded(function: JetNamedFunction,
++                                  functionDescriptor: FunctionDescriptor,
++                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                  owner: CodegenContext<*>,
++                                  classBuilder: ClassBuilder) {
++        val overloadsFqName = FqName.fromSegments(listOf(""kotlin"", ""jvm"", ""overloads""))
++        if (functionDescriptor.getAnnotations().findAnnotation(overloadsFqName) == null) return
++
++        val count = functionDescriptor.countDefaultParameters()
++        val context = owner.intoFunction(functionDescriptor)
++
++        for (i in 1..count) {
++            generateOverloadWithSubstitutedParameters(functionDescriptor, delegateFunctionDescriptor, classBuilder, function, context, i)
++        }
++    }
++
++    private fun FunctionDescriptor.countDefaultParameters() =
++        getValueParameters().count { it.hasDefaultValue() }
++
++    /**
++     * Generates an overload for [functionDescriptor] that substitutes default values for the last
++     * [substituteCount] parameters that have default values.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     * @param methodElement the PSI element for the method implementation (used in diagnostic messages only)
++     */
++    fun generateOverloadWithSubstitutedParameters(functionDescriptor: FunctionDescriptor,
++                                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                                  classBuilder: ClassBuilder,
++                                                  methodElement: JetElement?,
++                                                  context: CodegenContext<*>,
++                                                  substituteCount: Int) {
++        val isStatic = AsmUtil.isStaticMethod(context.getContextKind(), functionDescriptor)
++        val flags = AsmUtil.getVisibilityAccessFlag(functionDescriptor) or (if (isStatic) Opcodes.ACC_STATIC else 0)
++        val remainingParameters = getRemainingParameters(functionDescriptor.getOriginal(), substituteCount)
++        val signature = state.getTypeMapper().mapSignature(functionDescriptor, context.getContextKind(),
++                                                           remainingParameters)
++        val mv = classBuilder.newMethod(OtherOrigin(functionDescriptor), flags,
++                                        signature.getAsmMethod().getName(),
++                                        signature.getAsmMethod().getDescriptor(), null,
++                                        FunctionCodegen.getThrownExceptions(functionDescriptor, state.getTypeMapper()))
++
++        if (state.getClassBuilderMode() == ClassBuilderMode.LIGHT_CLASSES) return
++
++        val frameMap = FrameMap()
++        val v = InstructionAdapter(mv)
++        mv.visitCode()
++
++        val methodOwner = state.getTypeMapper().mapToCallableMethod(delegateFunctionDescriptor, false, context).getOwner()
++        if (!isStatic) {
++            frameMap.enterTemp(AsmTypes.OBJECT_TYPE)
++            v.load(0, methodOwner) // Load this on stack","Maybe use the value returned by `enterTemp` instead of `0` for better readability
+",2015-03-31 09:38:38
+352,"@@ -0,0 +1,204 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.codegen
++
++import org.jetbrains.kotlin.codegen.binding.CodegenBinding
++import org.jetbrains.kotlin.codegen.context.CodegenContext
++import org.jetbrains.kotlin.codegen.state.GenerationState
++import org.jetbrains.kotlin.descriptors.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.JetClass
++import org.jetbrains.kotlin.psi.JetClassOrObject
++import org.jetbrains.kotlin.psi.JetElement
++import org.jetbrains.kotlin.psi.JetNamedFunction
++import org.jetbrains.kotlin.resolve.jvm.AsmTypes
++import org.jetbrains.kotlin.resolve.jvm.diagnostics.OtherOrigin
++import org.jetbrains.org.objectweb.asm.Opcodes
++import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter
++
++/**
++ * Generates Java overloads for functions and constructors that have the default
++ * parameter values substituted.
++ */
++public class DefaultParameterValueSubstitutor(val state: GenerationState) {
++    /**
++     * If all of the parameters of the specified constructor declare default values,
++     * generates a no-argument constructor that passes default values for all arguments.
++     */
++    fun generateDefaultConstructorIfNeeded(constructorDescriptor: ConstructorDescriptor,
++                                           classBuilder: ClassBuilder,
++                                           context: CodegenContext<*>,
++                                           classOrObject: JetClassOrObject) {
++        if (!isEmptyConstructorNeeded(constructorDescriptor, classOrObject)) {
++            return
++        }
++
++        generateOverloadWithSubstitutedParameters(constructorDescriptor, constructorDescriptor, classBuilder, classOrObject,
++                                                  context,
++                                                  constructorDescriptor.countDefaultParameters())
++    }
++
++    /**
++     * If the function is annotated with [kotlin.jvm.overloads], generates Java methods that
++     * have the default parameter values substituted. If a method has N parameters and M of which
++     * have default values, M overloads are generated: the first one takes N-1 parameters (all but
++     * the last one that takes a default value), the second takes N-2 parameters, and so on.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     */
++    fun generateOverloadsIfNeeded(function: JetNamedFunction,
++                                  functionDescriptor: FunctionDescriptor,
++                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                  owner: CodegenContext<*>,
++                                  classBuilder: ClassBuilder) {
++        val overloadsFqName = FqName.fromSegments(listOf(""kotlin"", ""jvm"", ""overloads""))
++        if (functionDescriptor.getAnnotations().findAnnotation(overloadsFqName) == null) return
++
++        val count = functionDescriptor.countDefaultParameters()
++        val context = owner.intoFunction(functionDescriptor)
++
++        for (i in 1..count) {
++            generateOverloadWithSubstitutedParameters(functionDescriptor, delegateFunctionDescriptor, classBuilder, function, context, i)
++        }
++    }
++
++    private fun FunctionDescriptor.countDefaultParameters() =
++        getValueParameters().count { it.hasDefaultValue() }
++
++    /**
++     * Generates an overload for [functionDescriptor] that substitutes default values for the last
++     * [substituteCount] parameters that have default values.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     * @param methodElement the PSI element for the method implementation (used in diagnostic messages only)
++     */
++    fun generateOverloadWithSubstitutedParameters(functionDescriptor: FunctionDescriptor,
++                                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                                  classBuilder: ClassBuilder,
++                                                  methodElement: JetElement?,
++                                                  context: CodegenContext<*>,
++                                                  substituteCount: Int) {
++        val isStatic = AsmUtil.isStaticMethod(context.getContextKind(), functionDescriptor)
++        val flags = AsmUtil.getVisibilityAccessFlag(functionDescriptor) or (if (isStatic) Opcodes.ACC_STATIC else 0)
++        val remainingParameters = getRemainingParameters(functionDescriptor.getOriginal(), substituteCount)
++        val signature = state.getTypeMapper().mapSignature(functionDescriptor, context.getContextKind(),
++                                                           remainingParameters)
++        val mv = classBuilder.newMethod(OtherOrigin(functionDescriptor), flags,
++                                        signature.getAsmMethod().getName(),
++                                        signature.getAsmMethod().getDescriptor(), null,
++                                        FunctionCodegen.getThrownExceptions(functionDescriptor, state.getTypeMapper()))
++
++        if (state.getClassBuilderMode() == ClassBuilderMode.LIGHT_CLASSES) return
++
++        val frameMap = FrameMap()
++        val v = InstructionAdapter(mv)
++        mv.visitCode()
++
++        val methodOwner = state.getTypeMapper().mapToCallableMethod(delegateFunctionDescriptor, false, context).getOwner()
++        if (!isStatic) {
++            frameMap.enterTemp(AsmTypes.OBJECT_TYPE)
++            v.load(0, methodOwner) // Load this on stack
++        } else {","`else` should be on the next line :) Several times in this file
+",2015-03-31 09:16:13
+353,"@@ -0,0 +1,204 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.codegen
++
++import org.jetbrains.kotlin.codegen.binding.CodegenBinding
++import org.jetbrains.kotlin.codegen.context.CodegenContext
++import org.jetbrains.kotlin.codegen.state.GenerationState
++import org.jetbrains.kotlin.descriptors.*
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.JetClass
++import org.jetbrains.kotlin.psi.JetClassOrObject
++import org.jetbrains.kotlin.psi.JetElement
++import org.jetbrains.kotlin.psi.JetNamedFunction
++import org.jetbrains.kotlin.resolve.jvm.AsmTypes
++import org.jetbrains.kotlin.resolve.jvm.diagnostics.OtherOrigin
++import org.jetbrains.org.objectweb.asm.Opcodes
++import org.jetbrains.org.objectweb.asm.commons.InstructionAdapter
++
++/**
++ * Generates Java overloads for functions and constructors that have the default
++ * parameter values substituted.
++ */
++public class DefaultParameterValueSubstitutor(val state: GenerationState) {
++    /**
++     * If all of the parameters of the specified constructor declare default values,
++     * generates a no-argument constructor that passes default values for all arguments.
++     */
++    fun generateDefaultConstructorIfNeeded(constructorDescriptor: ConstructorDescriptor,
++                                           classBuilder: ClassBuilder,
++                                           context: CodegenContext<*>,
++                                           classOrObject: JetClassOrObject) {
++        if (!isEmptyConstructorNeeded(constructorDescriptor, classOrObject)) {
++            return
++        }
++
++        generateOverloadWithSubstitutedParameters(constructorDescriptor, constructorDescriptor, classBuilder, classOrObject,
++                                                  context,
++                                                  constructorDescriptor.countDefaultParameters())
++    }
++
++    /**
++     * If the function is annotated with [kotlin.jvm.overloads], generates Java methods that
++     * have the default parameter values substituted. If a method has N parameters and M of which
++     * have default values, M overloads are generated: the first one takes N-1 parameters (all but
++     * the last one that takes a default value), the second takes N-2 parameters, and so on.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     */
++    fun generateOverloadsIfNeeded(function: JetNamedFunction,
++                                  functionDescriptor: FunctionDescriptor,
++                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                  owner: CodegenContext<*>,
++                                  classBuilder: ClassBuilder) {
++        val overloadsFqName = FqName.fromSegments(listOf(""kotlin"", ""jvm"", ""overloads""))
++        if (functionDescriptor.getAnnotations().findAnnotation(overloadsFqName) == null) return
++
++        val count = functionDescriptor.countDefaultParameters()
++        val context = owner.intoFunction(functionDescriptor)
++
++        for (i in 1..count) {
++            generateOverloadWithSubstitutedParameters(functionDescriptor, delegateFunctionDescriptor, classBuilder, function, context, i)
++        }
++    }
++
++    private fun FunctionDescriptor.countDefaultParameters() =
++        getValueParameters().count { it.hasDefaultValue() }
++
++    /**
++     * Generates an overload for [functionDescriptor] that substitutes default values for the last
++     * [substituteCount] parameters that have default values.
++     *
++     * @param functionDescriptor the method for which the overloads are generated
++     * @param delegateFunctionDescriptor the method descriptor for the implementation that we need to call
++     *     (same as [functionDescriptor] in all cases except for companion object methods annotated with [platformStatic],
++     *     where [functionDescriptor] is the static method in the main class and [delegateFunctionDescriptor] is the
++     *     implementation in the companion object class)
++     * @param methodElement the PSI element for the method implementation (used in diagnostic messages only)
++     */
++    fun generateOverloadWithSubstitutedParameters(functionDescriptor: FunctionDescriptor,
++                                                  delegateFunctionDescriptor: FunctionDescriptor,
++                                                  classBuilder: ClassBuilder,
++                                                  methodElement: JetElement?,
++                                                  context: CodegenContext<*>,
++                                                  substituteCount: Int) {
++        val isStatic = AsmUtil.isStaticMethod(context.getContextKind(), functionDescriptor)
++        val flags = AsmUtil.getVisibilityAccessFlag(functionDescriptor) or (if (isStatic) Opcodes.ACC_STATIC else 0)
++        val remainingParameters = getRemainingParameters(functionDescriptor.getOriginal(), substituteCount)
++        val signature = state.getTypeMapper().mapSignature(functionDescriptor, context.getContextKind(),
++                                                           remainingParameters)
++        val mv = classBuilder.newMethod(OtherOrigin(functionDescriptor), flags,
++                                        signature.getAsmMethod().getName(),
++                                        signature.getAsmMethod().getDescriptor(), null,
++                                        FunctionCodegen.getThrownExceptions(functionDescriptor, state.getTypeMapper()))
++
++        if (state.getClassBuilderMode() == ClassBuilderMode.LIGHT_CLASSES) return
++
++        val frameMap = FrameMap()
++        val v = InstructionAdapter(mv)
++        mv.visitCode()
++
++        val methodOwner = state.getTypeMapper().mapToCallableMethod(delegateFunctionDescriptor, false, context).getOwner()
++        if (!isStatic) {
++            frameMap.enterTemp(AsmTypes.OBJECT_TYPE)
++            v.load(0, methodOwner) // Load this on stack
++        } else {
++            val delegateOwner = delegateFunctionDescriptor.getContainingDeclaration()
++            if (delegateOwner is ClassDescriptor && delegateOwner.isCompanionObject()) {
++                val singletonValue = StackValue.singleton(delegateOwner, state.getTypeMapper())
++                singletonValue.put(singletonValue.type, v);
++            }
++        }
++
++        val receiver = functionDescriptor.getExtensionReceiverParameter()
++        if (receiver != null) {
++            val receiverType = state.getTypeMapper().mapType(receiver)
++            val receiverIndex = frameMap.enter(receiver, receiverType)
++            StackValue.local(receiverIndex, receiverType).put(receiverType, v)
++        }
++        remainingParameters.forEach {
++            frameMap.enter(it, state.getTypeMapper().mapType(it))
++        }
++
++        var mask = 0
++        val masks = arrayListOf<Int>()
++        for (parameterDescriptor in functionDescriptor.getValueParameters()) {
++            val paramType = state.getTypeMapper().mapType(parameterDescriptor.getType())
++            if (parameterDescriptor in remainingParameters) {
++                val index = frameMap.getIndex(parameterDescriptor)
++                val type = state.getTypeMapper().mapType(parameterDescriptor)","Already calculated a little earlier (`paramType`)
+",2015-03-31 09:18:17
+728,"@@ -0,0 +1,205 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.jvm.compiler
++
++import com.intellij.testFramework.TestDataPath
++import org.jetbrains.kotlin.test.JUnit3RunnerWithInners
++import org.jetbrains.kotlin.test.KotlinTestUtils
++import org.jetbrains.kotlin.test.TestMetadata
++import org.junit.runner.RunWith
++
++@SuppressWarnings(""all"")
++@TestMetadata(""compiler/testData/compileKotlinAgainstJava"")
++@TestDataPath(""\$PROJECT_ROOT"")
++@RunWith(JUnit3RunnerWithInners::class)
++class CompileKotlinAgainstJavaTest : AbstractCompileJavaAgainstKotlinTest() {",`CompileKotlinAgainstJava` but `AbstractCompilerJavaAgainstKotlin`? Looks very strange,2017-04-05 15:33:28
+39,"@@ -0,0 +1,207 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticFactory1;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManager;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class MapPlatformClassToKotlinFix extends JetIntentionAction<JetReferenceExpression> {
++    private static final String PRIMARY_USAGE = ""PrimaryUsage"";
++    private static final String OTHER_USAGE = ""OtherUsage"";
++
++    private final ClassDescriptor platformClass;
++    private final Collection<ClassDescriptor> possibleClasses;
++
++    public MapPlatformClassToKotlinFix(@NotNull JetReferenceExpression element, @NotNull ClassDescriptor platformClass,
++            @NotNull Collection<ClassDescriptor> possibleClasses) {
++        super(element);
++        this.platformClass = platformClass;
++        this.possibleClasses = possibleClasses;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++
++        String platformClassQualifiedName = DescriptorRenderer.TEXT.renderType(platformClass.getDefaultType());
++        return possibleClasses.size() == 1
++               ? JetBundle.message(""map.platform.class.to.kotlin"", platformClassQualifiedName,
++                                   DescriptorRenderer.TEXT.renderType(possibleClasses.iterator().next().getDefaultType()))
++               : JetBundle.message(""map.platform.class.to.kotlin.multiple"", platformClassQualifiedName);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""map.platform.class.to.kotlin.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {","This method is pretty long. Consider extracting methods for it. First candidate for extracting is code about live template in the end of the method.
+",2013-02-28 14:33:59
+37,"@@ -0,0 +1,207 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticFactory1;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManager;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class MapPlatformClassToKotlinFix extends JetIntentionAction<JetReferenceExpression> {
++    private static final String PRIMARY_USAGE = ""PrimaryUsage"";
++    private static final String OTHER_USAGE = ""OtherUsage"";
++
++    private final ClassDescriptor platformClass;
++    private final Collection<ClassDescriptor> possibleClasses;
++
++    public MapPlatformClassToKotlinFix(@NotNull JetReferenceExpression element, @NotNull ClassDescriptor platformClass,
++            @NotNull Collection<ClassDescriptor> possibleClasses) {
++        super(element);
++        this.platformClass = platformClass;
++        this.possibleClasses = possibleClasses;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++
++        String platformClassQualifiedName = DescriptorRenderer.TEXT.renderType(platformClass.getDefaultType());
++        return possibleClasses.size() == 1
++               ? JetBundle.message(""map.platform.class.to.kotlin"", platformClassQualifiedName,
++                                   DescriptorRenderer.TEXT.renderType(possibleClasses.iterator().next().getDefaultType()))
++               : JetBundle.message(""map.platform.class.to.kotlin.multiple"", platformClassQualifiedName);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""map.platform.class.to.kotlin.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        BindingContext context = KotlinCacheManager.getInstance(project).getDeclarationsFromProject().getBindingContext();
++        Collection<Diagnostic> diagnostics = context.getDiagnostics();
++        List<JetImportDirective> imports = new ArrayList<JetImportDirective>();
++        List<JetUserType> usages = new ArrayList<JetUserType>();
++
++        for (Diagnostic diagnostic : diagnostics) {
++            if (diagnostic.getFactory() != Errors.PLATFORM_CLASS_MAPPED_TO_KOTLIN) continue;
++            JetReferenceExpression refExpr = getImportOrUsageFromDiagnostic(diagnostic);
++            if (refExpr == null) continue;
++            DeclarationDescriptor descriptor = context.get(BindingContext.REFERENCE_TARGET, refExpr);
++            if (descriptor == null || !(descriptor.equals(platformClass))) continue;","Is this check necessary? Maybe remove it or replace with assert?
+",2013-02-28 14:17:57
+38,"@@ -0,0 +1,207 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticFactory1;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManager;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class MapPlatformClassToKotlinFix extends JetIntentionAction<JetReferenceExpression> {
++    private static final String PRIMARY_USAGE = ""PrimaryUsage"";
++    private static final String OTHER_USAGE = ""OtherUsage"";
++
++    private final ClassDescriptor platformClass;
++    private final Collection<ClassDescriptor> possibleClasses;
++
++    public MapPlatformClassToKotlinFix(@NotNull JetReferenceExpression element, @NotNull ClassDescriptor platformClass,
++            @NotNull Collection<ClassDescriptor> possibleClasses) {
++        super(element);
++        this.platformClass = platformClass;
++        this.possibleClasses = possibleClasses;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++
++        String platformClassQualifiedName = DescriptorRenderer.TEXT.renderType(platformClass.getDefaultType());
++        return possibleClasses.size() == 1
++               ? JetBundle.message(""map.platform.class.to.kotlin"", platformClassQualifiedName,
++                                   DescriptorRenderer.TEXT.renderType(possibleClasses.iterator().next().getDefaultType()))
++               : JetBundle.message(""map.platform.class.to.kotlin.multiple"", platformClassQualifiedName);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""map.platform.class.to.kotlin.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        BindingContext context = KotlinCacheManager.getInstance(project).getDeclarationsFromProject().getBindingContext();
++        Collection<Diagnostic> diagnostics = context.getDiagnostics();
++        List<JetImportDirective> imports = new ArrayList<JetImportDirective>();
++        List<JetUserType> usages = new ArrayList<JetUserType>();
++
++        for (Diagnostic diagnostic : diagnostics) {
++            if (diagnostic.getFactory() != Errors.PLATFORM_CLASS_MAPPED_TO_KOTLIN) continue;
++            JetReferenceExpression refExpr = getImportOrUsageFromDiagnostic(diagnostic);
++            if (refExpr == null) continue;
++            DeclarationDescriptor descriptor = context.get(BindingContext.REFERENCE_TARGET, refExpr);
++            if (descriptor == null || !(descriptor.equals(platformClass))) continue;
++            JetImportDirective imp = PsiTreeUtil.getParentOfType(refExpr, JetImportDirective.class);
++            if (imp == null) {
++                JetUserType type = PsiTreeUtil.getParentOfType(refExpr, JetUserType.class);
++                if (type == null) continue;
++                usages.add(type);
++            } else {
++                imports.add(imp);
++            }
++        }
++
++        ClassDescriptor replacementClass = possibleClasses.iterator().next();
++        String replacementClassName = replacementClass.getName().getName();
++        List<JetExpression> replacedExpressions = new ArrayList<JetExpression>();
++        for (JetImportDirective imp : imports) {
++            imp.delete();
++        }
++        for (JetUserType usage : usages) {
++            JetTypeArgumentList typeArguments = usage.getTypeArgumentList();
++            String typeArgumentsString = typeArguments == null ? """" : typeArguments.getText();
++            JetTypeReference replacementType = JetPsiFactory.createType(project, replacementClassName + typeArgumentsString);
++            JetTypeElement replacementTypeElement = replacementType.getTypeElement();
++            assert replacementTypeElement != null;
++            PsiElement replacedElement = usage.replace(replacementTypeElement);
++            PsiElement replacedExpression = replacedElement.getFirstChild();
++            assert replacedExpression instanceof JetSimpleNameExpression; // assumption: the Kotlin class requires no imports
++            replacedExpressions.add((JetExpression) replacedExpression);
++        }
++
++        if (replacedExpressions.size() == 0) { // if we didn't replace any usages, there's no reason to even give a choice","This condition is equivalent to usages.isEmpty(), which is more straightforward and can be checked before loop.
+",2013-02-28 14:22:46
+36,"@@ -0,0 +1,207 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.ClassDescriptor;
++import org.jetbrains.jet.lang.descriptors.DeclarationDescriptor;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticFactory1;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.diagnostics.Errors;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManager;
++import org.jetbrains.jet.renderer.DescriptorRenderer;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class MapPlatformClassToKotlinFix extends JetIntentionAction<JetReferenceExpression> {
++    private static final String PRIMARY_USAGE = ""PrimaryUsage"";
++    private static final String OTHER_USAGE = ""OtherUsage"";
++
++    private final ClassDescriptor platformClass;
++    private final Collection<ClassDescriptor> possibleClasses;
++
++    public MapPlatformClassToKotlinFix(@NotNull JetReferenceExpression element, @NotNull ClassDescriptor platformClass,
++            @NotNull Collection<ClassDescriptor> possibleClasses) {
++        super(element);
++        this.platformClass = platformClass;
++        this.possibleClasses = possibleClasses;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++
++        String platformClassQualifiedName = DescriptorRenderer.TEXT.renderType(platformClass.getDefaultType());
++        return possibleClasses.size() == 1
++               ? JetBundle.message(""map.platform.class.to.kotlin"", platformClassQualifiedName,
++                                   DescriptorRenderer.TEXT.renderType(possibleClasses.iterator().next().getDefaultType()))
++               : JetBundle.message(""map.platform.class.to.kotlin.multiple"", platformClassQualifiedName);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""map.platform.class.to.kotlin.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        BindingContext context = KotlinCacheManager.getInstance(project).getDeclarationsFromProject().getBindingContext();
++        Collection<Diagnostic> diagnostics = context.getDiagnostics();
++        List<JetImportDirective> imports = new ArrayList<JetImportDirective>();
++        List<JetUserType> usages = new ArrayList<JetUserType>();
++
++        for (Diagnostic diagnostic : diagnostics) {
++            if (diagnostic.getFactory() != Errors.PLATFORM_CLASS_MAPPED_TO_KOTLIN) continue;
++            JetReferenceExpression refExpr = getImportOrUsageFromDiagnostic(diagnostic);
++            if (refExpr == null) continue;
++            DeclarationDescriptor descriptor = context.get(BindingContext.REFERENCE_TARGET, refExpr);
++            if (descriptor == null || !(descriptor.equals(platformClass))) continue;
++            JetImportDirective imp = PsiTreeUtil.getParentOfType(refExpr, JetImportDirective.class);
++            if (imp == null) {
++                JetUserType type = PsiTreeUtil.getParentOfType(refExpr, JetUserType.class);
++                if (type == null) continue;
++                usages.add(type);
++            } else {
++                imports.add(imp);
++            }
++        }
++
++        ClassDescriptor replacementClass = possibleClasses.iterator().next();
++        String replacementClassName = replacementClass.getName().getName();
++        List<JetExpression> replacedExpressions = new ArrayList<JetExpression>();
++        for (JetImportDirective imp : imports) {
++            imp.delete();
++        }
++        for (JetUserType usage : usages) {
++            JetTypeArgumentList typeArguments = usage.getTypeArgumentList();
++            String typeArgumentsString = typeArguments == null ? """" : typeArguments.getText();
++            JetTypeReference replacementType = JetPsiFactory.createType(project, replacementClassName + typeArgumentsString);
++            JetTypeElement replacementTypeElement = replacementType.getTypeElement();
++            assert replacementTypeElement != null;
++            PsiElement replacedElement = usage.replace(replacementTypeElement);
++            PsiElement replacedExpression = replacedElement.getFirstChild();
++            assert replacedExpression instanceof JetSimpleNameExpression; // assumption: the Kotlin class requires no imports
++            replacedExpressions.add((JetExpression) replacedExpression);
++        }
++
++        if (replacedExpressions.size() == 0) { // if we didn't replace any usages, there's no reason to even give a choice
++            return;
++        }
++
++        if (possibleClasses.size() > 1) {
++            PsiDocumentManager.getInstance(project).commitAllDocuments();
++            PsiDocumentManager.getInstance(project).doPostponedOperationsAndUnblockDocument(editor.getDocument());
++
++            PsiElement primaryReplacedExpression = replacedExpressions.iterator().next();
++
++            final CaretModel caretModel = editor.getCaretModel();
++            final int oldOffset = caretModel.getOffset();
++            caretModel.moveToOffset(file.getNode().getStartOffset());
++
++            LinkedHashSet<String> possibleTypes = new LinkedHashSet<String>();
++            for (ClassDescriptor klass : possibleClasses) {
++                possibleTypes.add(klass.getName().getName());
++            }
++
++            TemplateBuilderImpl builder = new TemplateBuilderImpl(file);
++            Expression expression = new MyLookupExpression(primaryReplacedExpression.getText(), possibleTypes, null, false,
++                                                           JetBundle.message(""map.platform.class.to.kotlin.advertisement""));
++
++            builder.replaceElement(primaryReplacedExpression, PRIMARY_USAGE, expression, true);
++            for (PsiElement replacedExpression : replacedExpressions) {
++                if (replacedExpression == primaryReplacedExpression) continue;
++                builder.replaceElement(replacedExpression, OTHER_USAGE, PRIMARY_USAGE, false);
++            }
++            TemplateManager.getInstance(project).startTemplate(editor, builder.buildInlineTemplate(), new TemplateEditingAdapter() {
++                @Override
++                public void templateFinished(Template template, boolean brokenOff) {
++                    caretModel.moveToOffset(oldOffset);
++                }
++            });
++        }
++    }
++
++    private static JetReferenceExpression getImportOrUsageFromDiagnostic(@NotNull Diagnostic diagnostic) {
++        JetImportDirective imp = QuickFixUtil.getParentElementOfType(diagnostic, JetImportDirective.class);
++        JetReferenceExpression typeExpr;
++        if (imp == null) {
++            JetUserType type = QuickFixUtil.getParentElementOfType(diagnostic, JetUserType.class);
++            if (type == null) return null;
++            typeExpr = type.getReferenceExpression();
++        } else {
++            JetExpression importRef = imp.getImportedReference();
++            if (importRef == null || !(importRef instanceof JetDotQualifiedExpression)) return null;
++            JetExpression refExpr = ((JetDotQualifiedExpression) importRef).getSelectorExpression();
++            if (refExpr == null || !(refExpr instanceof JetReferenceExpression)) return null;
++            typeExpr = (JetReferenceExpression) refExpr;
++        }
++        return typeExpr;
++    }
++
++    public static JetIntentionActionFactory createFactory() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                assert diagnostic.getFactory() instanceof DiagnosticFactory1;
++
++                JetReferenceExpression typeExpr = getImportOrUsageFromDiagnostic(diagnostic);
++                if (typeExpr == null) return null;
++
++                BindingContext context = KotlinCacheManager.getInstance(diagnostic.getPsiFile().getProject()).getDeclarationsFromProject().getBindingContext();
++                DeclarationDescriptor descriptor = context.get(BindingContext.REFERENCE_TARGET, typeExpr);
++                if (descriptor == null || !(descriptor instanceof ClassDescriptor)) return null;
++                ClassDescriptor platformClass = (ClassDescriptor) descriptor;
++
++                @SuppressWarnings(""unchecked"")
++                DiagnosticWithParameters1 parametrizedDiagnostic = (DiagnosticWithParameters1) diagnostic;","All the boilerplate starting from this line can be avoided by casting to DiagnosticWithParameters1<JetElement, Collection<ClassDescriptor>> instead of raw type.
+",2013-02-28 14:15:00
+663,"@@ -0,0 +1,208 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.j2k
++
++import com.intellij.psi.CommonClassNames.*
++import com.intellij.psi.PsiField
++import org.jetbrains.kotlin.builtins.PrimitiveType
++import org.jetbrains.kotlin.j2k.ast.Expression
++import org.jetbrains.kotlin.j2k.ast.Identifier
++import org.jetbrains.kotlin.j2k.ast.QualifiedExpression
++
++enum class SpecialFiled(val qualifiedClassName: String?, val fieldName: String) {","SpecialField
+",2016-12-27 11:41:21
+664,"@@ -0,0 +1,208 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.j2k
++
++import com.intellij.psi.CommonClassNames.*
++import com.intellij.psi.PsiField
++import org.jetbrains.kotlin.builtins.PrimitiveType
++import org.jetbrains.kotlin.j2k.ast.Expression
++import org.jetbrains.kotlin.j2k.ast.Identifier
++import org.jetbrains.kotlin.j2k.ast.QualifiedExpression
++
++enum class SpecialFiled(val qualifiedClassName: String?, val fieldName: String) {
++
++    BYTE_MAX_VALUE(JAVA_LANG_BYTE, ""MAX_VALUE"") {","You should not hard-code all possible constants.
+",2016-12-27 11:43:40
+605,"@@ -0,0 +1,21 @@
++//method","You need to include the generated test class into your commit.
+",2016-09-12 18:37:57
+604,"@@ -0,0 +1,21 @@
++//method
++void foo() {","Please try to ensure that testdata files are valid Java code. This file does not compile ('status' is undefined, the types do not match, etc.)
+",2016-09-12 18:37:39
+607,"@@ -0,0 +1,21 @@
++//method
++void foo() {
++	switch (status) {
++	    case ""init"":
++	    case ""dial"":
++	    case ""transmit"":
++		return Color.BLACK;
++
++	    case ""ok"":
++		return 0xFF006600;
++
++	    case ""cancel"":
++		return 0xFF666666;
++
++	    case ""fail"":
++	    case ""busy"":
++	    case ""error"":","Please add a test for the case when 'default' is in the middle of the list of other cases (`case ""error"": default: case ""busy:""`) and make sure that this test passes.
+",2016-09-12 18:40:50
+210,"@@ -0,0 +1,212 @@
++/*
++* Copyright 2010-2014 JetBrains s.r.o.
++*
++* Licensed under the Apache License, Version 2.0 (the ""License"");
++* you may not use this file except in compliance with the License.
++* You may obtain a copy of the License at
++*
++* http://www.apache.org/licenses/LICENSE-2.0
++*
++* Unless required by applicable law or agreed to in writing, software
++* distributed under the License is distributed on an ""AS IS"" BASIS,
++* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++* See the License for the specific language governing permissions and
++* limitations under the License.
++*/
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetPostfixExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetElement
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.psiUtil.getQualifiedElementSelector
++import com.intellij.psi.util.PsiTreeUtil
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns
++import org.jetbrains.jet.lang.psi.JetFile
++
++public class OperatorToFunctionIntention : JetSelfTargetingIntention<JetExpression>(""operator.to.function"", javaClass()) {
++    fun isApplicablePrefix(element: JetPrefixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.PLUSPLUS, JetTokens.MINUSMINUS, JetTokens.EXCL -> true
++            else -> false
++        }
++    }
++
++    fun isApplicablePostfix(element: JetPostfixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUSPLUS, JetTokens.MINUSMINUS -> true
++            else -> false
++        }
++    }
++
++    fun isApplicableBinary(element: JetBinaryExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.MUL, JetTokens.DIV, JetTokens.PERC, JetTokens.RANGE, JetTokens.IN_KEYWORD, JetTokens.NOT_IN, JetTokens.PLUSEQ, JetTokens.MINUSEQ, JetTokens.MULTEQ, JetTokens.DIVEQ, JetTokens.PERCEQ, JetTokens.EQEQ, JetTokens.EXCLEQ, JetTokens.GT, JetTokens.LT, JetTokens.GTEQ, JetTokens.LTEQ -> true
++            JetTokens.EQ -> element.getLeft() is JetArrayAccessExpression
++            else -> false
++        }
++    }
++
++    fun isApplicableArrayAccess(element: JetArrayAccessExpression): Boolean {
++        return true
++    }
++
++    fun isApplicableCall(element: JetCallExpression): Boolean {
++        //element.getCalleeExpression()?.getClass()?.getMethods()?.forEach{println(""element has method "" + it.getName())}
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val calleeClass = context[BindingContext.CLASS, element.getCalleeExpression()]
++        //println(""calleeClass is "" + calleeClass?.getName())
++        //calleeClass.javaClass.getMethods().forEach { println(""element has method "" + it.getName()) }
++        return element.getParent() !is JetDotQualifiedExpression && element.getValueArgumentList() != null","Basically, we need to retrieve ResolvedCall corresponding to call of interest and check if resulting function is `invoke`.
+
+```
+val resolvedCall = AnalyzerFacadeWithCache.getContextForElement(element)[BindingContext.RESOLVED_CALL, element.getCalleeExpression()]
+val descriptor = resolvedCall?.getResultingDescriptor()
+if (descriptor is FunctionDescriptor && descriptor.getName().asString == ""invoke"") {
+    // do whatever we need
+}
+```
+",2014-04-23 14:19:59
+209,"@@ -0,0 +1,212 @@
++/*
++* Copyright 2010-2014 JetBrains s.r.o.
++*
++* Licensed under the Apache License, Version 2.0 (the ""License"");
++* you may not use this file except in compliance with the License.
++* You may obtain a copy of the License at
++*
++* http://www.apache.org/licenses/LICENSE-2.0
++*
++* Unless required by applicable law or agreed to in writing, software
++* distributed under the License is distributed on an ""AS IS"" BASIS,
++* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++* See the License for the specific language governing permissions and
++* limitations under the License.
++*/
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetPostfixExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetElement
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.psiUtil.getQualifiedElementSelector
++import com.intellij.psi.util.PsiTreeUtil
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns
++import org.jetbrains.jet.lang.psi.JetFile
++
++public class OperatorToFunctionIntention : JetSelfTargetingIntention<JetExpression>(""operator.to.function"", javaClass()) {
++    fun isApplicablePrefix(element: JetPrefixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.PLUSPLUS, JetTokens.MINUSMINUS, JetTokens.EXCL -> true
++            else -> false
++        }
++    }
++
++    fun isApplicablePostfix(element: JetPostfixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUSPLUS, JetTokens.MINUSMINUS -> true
++            else -> false
++        }
++    }
++
++    fun isApplicableBinary(element: JetBinaryExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.MUL, JetTokens.DIV, JetTokens.PERC, JetTokens.RANGE, JetTokens.IN_KEYWORD, JetTokens.NOT_IN, JetTokens.PLUSEQ, JetTokens.MINUSEQ, JetTokens.MULTEQ, JetTokens.DIVEQ, JetTokens.PERCEQ, JetTokens.EQEQ, JetTokens.EXCLEQ, JetTokens.GT, JetTokens.LT, JetTokens.GTEQ, JetTokens.LTEQ -> true
++            JetTokens.EQ -> element.getLeft() is JetArrayAccessExpression
++            else -> false
++        }
++    }
++
++    fun isApplicableArrayAccess(element: JetArrayAccessExpression): Boolean {
++        return true
++    }
++
++    fun isApplicableCall(element: JetCallExpression): Boolean {
++        //element.getCalleeExpression()?.getClass()?.getMethods()?.forEach{println(""element has method "" + it.getName())}
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val calleeClass = context[BindingContext.CLASS, element.getCalleeExpression()]
++        //println(""calleeClass is "" + calleeClass?.getName())
++        //calleeClass.javaClass.getMethods().forEach { println(""element has method "" + it.getName()) }
++        return element.getParent() !is JetDotQualifiedExpression && element.getValueArgumentList() != null
++    }
++
++    override fun isApplicableTo(element: JetExpression): Boolean {
++        return when (element) {
++            is JetPrefixExpression -> isApplicablePrefix(element)
++            is JetPostfixExpression -> isApplicablePostfix(element)
++            is JetBinaryExpression -> isApplicableBinary(element)
++            is JetArrayAccessExpression -> isApplicableArrayAccess(element)
++            is JetCallExpression -> isApplicableCall(element)
++            else -> false
++        }
++    }
++
++
++    fun convertPrefix(element: JetPrefixExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val base = element.getBaseExpression()!!.getText()
++
++        val call = when (op) {
++            JetTokens.PLUS -> ""plus()""
++            JetTokens.MINUS -> ""minus()""
++            JetTokens.PLUSPLUS -> ""inc()""
++            JetTokens.MINUSMINUS -> ""dec()""
++            JetTokens.EXCL -> ""not()""
++            else -> return
++        }
++
++        val transformation = ""$base.$call""
++        val transformed = JetPsiFactory.createExpression(element.getProject(), transformation)
++        element.replace(transformed)
++    }
++
++    fun convertPostFix(element: JetPostfixExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val base = element.getBaseExpression()!!.getText()
++
++        val call = when (op) {
++            JetTokens.PLUSPLUS -> ""inc()""
++            JetTokens.MINUSMINUS -> ""dec()""
++            else -> return
++        }
++
++        val transformation = ""$base.$call""
++        val transformed = JetPsiFactory.createExpression(element.getProject(), transformation)
++        element.replace(transformed)
++    }
++
++    fun convertBinary(element: JetBinaryExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val left = element.getLeft()!!
++        val right = element.getRight()!!
++        val leftText = left.getText()
++        val rightText = right.getText()
++
++        if (op == JetTokens.EQ) {
++            if (left is JetArrayAccessExpression) {
++                convertArrayAccess(left as JetArrayAccessExpression)
++            }
++            return
++        }
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()","This function is not available anymore. Please, rebase against current master and use `AnalyzerFacadeWithCache.getContextForElement(element)` instead
+",2014-04-23 13:44:30
+208,"@@ -0,0 +1,212 @@
++/*
++* Copyright 2010-2014 JetBrains s.r.o.
++*
++* Licensed under the Apache License, Version 2.0 (the ""License"");
++* you may not use this file except in compliance with the License.
++* You may obtain a copy of the License at
++*
++* http://www.apache.org/licenses/LICENSE-2.0
++*
++* Unless required by applicable law or agreed to in writing, software
++* distributed under the License is distributed on an ""AS IS"" BASIS,
++* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++* See the License for the specific language governing permissions and
++* limitations under the License.
++*/
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetPostfixExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetElement
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.psiUtil.getQualifiedElementSelector
++import com.intellij.psi.util.PsiTreeUtil
++import org.jetbrains.jet.lang.types.lang.KotlinBuiltIns
++import org.jetbrains.jet.lang.psi.JetFile
++
++public class OperatorToFunctionIntention : JetSelfTargetingIntention<JetExpression>(""operator.to.function"", javaClass()) {
++    fun isApplicablePrefix(element: JetPrefixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.PLUSPLUS, JetTokens.MINUSMINUS, JetTokens.EXCL -> true
++            else -> false
++        }
++    }
++
++    fun isApplicablePostfix(element: JetPostfixExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUSPLUS, JetTokens.MINUSMINUS -> true
++            else -> false
++        }
++    }
++
++    fun isApplicableBinary(element: JetBinaryExpression): Boolean {
++        return when (element.getOperationReference().getReferencedNameElementType()) {
++            JetTokens.PLUS, JetTokens.MINUS, JetTokens.MUL, JetTokens.DIV, JetTokens.PERC, JetTokens.RANGE, JetTokens.IN_KEYWORD, JetTokens.NOT_IN, JetTokens.PLUSEQ, JetTokens.MINUSEQ, JetTokens.MULTEQ, JetTokens.DIVEQ, JetTokens.PERCEQ, JetTokens.EQEQ, JetTokens.EXCLEQ, JetTokens.GT, JetTokens.LT, JetTokens.GTEQ, JetTokens.LTEQ -> true
++            JetTokens.EQ -> element.getLeft() is JetArrayAccessExpression
++            else -> false
++        }
++    }
++
++    fun isApplicableArrayAccess(element: JetArrayAccessExpression): Boolean {
++        return true
++    }
++
++    fun isApplicableCall(element: JetCallExpression): Boolean {
++        //element.getCalleeExpression()?.getClass()?.getMethods()?.forEach{println(""element has method "" + it.getName())}
++        //val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        //val calleeClass = context[BindingContext.CLASS, element.getCalleeExpression()]
++        //println(""calleeClass is "" + calleeClass?.getName())
++        //calleeClass.javaClass.getMethods().forEach { println(""element has method "" + it.getName()) }
++        return element.getParent() !is JetDotQualifiedExpression && element.getValueArgumentList() != null
++    }
++
++    override fun isApplicableTo(element: JetExpression): Boolean {
++        return when (element) {
++            is JetPrefixExpression -> isApplicablePrefix(element)
++            is JetPostfixExpression -> isApplicablePostfix(element)
++            is JetBinaryExpression -> isApplicableBinary(element)
++            is JetArrayAccessExpression -> isApplicableArrayAccess(element)
++            is JetCallExpression -> isApplicableCall(element)
++            else -> false
++        }
++    }
++
++
++    fun convertPrefix(element: JetPrefixExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val base = element.getBaseExpression()!!.getText()
++
++        val call = when (op) {
++            JetTokens.PLUS -> ""plus()""
++            JetTokens.MINUS -> ""minus()""
++            JetTokens.PLUSPLUS -> ""inc()""
++            JetTokens.MINUSMINUS -> ""dec()""
++            JetTokens.EXCL -> ""not()""
++            else -> return
++        }
++
++        val transformation = ""$base.$call""
++        val transformed = JetPsiFactory.createExpression(element.getProject(), transformation)
++        element.replace(transformed)
++    }
++
++    fun convertPostFix(element: JetPostfixExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val base = element.getBaseExpression()!!.getText()
++
++        val call = when (op) {
++            JetTokens.PLUSPLUS -> ""inc()""
++            JetTokens.MINUSMINUS -> ""dec()""
++            else -> return
++        }
++
++        val transformation = ""$base.$call""
++        val transformed = JetPsiFactory.createExpression(element.getProject(), transformation)
++        element.replace(transformed)
++    }
++
++    fun convertBinary(element: JetBinaryExpression) {
++        val op = element.getOperationReference().getReferencedNameElementType()
++        val left = element.getLeft()!!
++        val right = element.getRight()!!
++        val leftText = left.getText()
++        val rightText = right.getText()
++
++        if (op == JetTokens.EQ) {
++            if (left is JetArrayAccessExpression) {
++                convertArrayAccess(left as JetArrayAccessExpression)
++            }
++            return
++        }
++
++        val context = AnalyzerFacadeWithCache.analyzeFileWithCache(element.getContainingFile() as JetFile).getBindingContext()
++        val functionCandidate = context[BindingContext.RESOLVED_CALL, element.getOperationReference()]
++        val functionName = functionCandidate?.getCandidateDescriptor()?.getName().toString()
++
++        val elemType = context[BindingContext.EXPRESSION_TYPE, left]
++
++
++        val transformation = when (op) {
++            JetTokens.PLUS -> ""$leftText.plus($rightText)""
++            JetTokens.MINUS -> ""$leftText.minus($rightText)""
++            JetTokens.MUL -> ""$leftText.times($rightText)""
++            JetTokens.DIV -> ""$leftText.div($rightText)""
++            JetTokens.PERC -> ""$leftText.mod($rightText)""
++            JetTokens.RANGE -> ""$leftText.rangeTo($rightText)""
++            JetTokens.IN_KEYWORD -> ""$rightText.contains($leftText)""
++            JetTokens.NOT_IN -> ""!$rightText.contains($leftText)""
++            JetTokens.PLUSEQ -> if (functionName == ""plusAssign"") ""$leftText.plusAssign($rightText)"" else ""$leftText = $leftText.plus($rightText)""
++            JetTokens.MINUSEQ -> if (functionName == ""minusAssign"") ""$leftText.minusAssign($rightText)"" else ""$leftText = $leftText.minus($rightText)""
++            JetTokens.MULTEQ -> if (functionName == ""multAssign"") ""$leftText.multAssign($rightText)"" else ""$leftText = $leftText.mult($rightText)""
++            JetTokens.DIVEQ -> if (functionName == ""divAssign"") ""$leftText.divAssign($rightText)"" else ""$leftText = $leftText.div($rightText)""
++            JetTokens.PERCEQ -> if (functionName == ""modAssign"") ""$leftText.modAssign($rightText)"" else ""$leftText = $leftText.mod($rightText)""
++            JetTokens.EQEQ -> (if (elemType?.isNullable() ?: true) ""$leftText?."" else ""$leftText."") + ""equals($rightText) ?: $rightText.identityEquals(null)""","It still produces unnecessary code. If `a` has a non-nullable type, `a == b` should be replaced by `a.equals(b)`, not `a.equals(b) ?: b.identityEquals(null)`
+",2014-04-23 13:40:13
+486,"@@ -0,0 +1,22 @@
++package demo
++
++import com.google.common.primitives.Ints
++import com.google.common.base.Joiner
++import java.util.ArrayList
++
++class KotlinGreetingJoiner(val greeter : Greeter) {
++
++    val names = ArrayList<String?>()
++
++    fun addName(name : String?): Unit{
++        names.add(name)
++    }
++
++    fun getJoinedGreeting() : String? {
++        val joiner = Joiner.on("" and "").skipNulls();","why do we need guava in such simple example? we can replace ugly `Joiner.on("" and "").skipNulls().join(names)` with `names.filterNotNull().joinToString("" and "")`. We also don't need `com.google.common.primitives.Ints` at all...
+",2015-10-28 13:11:42
+705,"@@ -0,0 +1,227 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.JavacClass
++import org.jetbrains.kotlin.wrappers.symbols.JavacPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.wrappers.trees.JCClass
++import org.jetbrains.kotlin.wrappers.trees.JCPackage
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.TypeElement
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class Javac(javaFiles: Collection<File>,",May be `JavaCompilerWrapper`?,2017-04-05 13:04:43
+706,"@@ -0,0 +1,227 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.JavacClass
++import org.jetbrains.kotlin.wrappers.symbols.JavacPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.wrappers.trees.JCClass
++import org.jetbrains.kotlin.wrappers.trees.JCPackage
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.TypeElement
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class Javac(javaFiles: Collection<File>,
++            classPathRoots: List<File>,
++            outDir: File?,
++            private val messageCollector: MessageCollector?,
++            arguments: Array<String>?) : Closeable {
++
++    companion object {
++        fun getInstance(project: Project): Javac = ServiceManager.getService(project, Javac::class.java)
++    }
++
++    val JAVA_LANG_OBJECT by lazy { findClassInSymbols(CommonClassNames.JAVA_LANG_OBJECT) }
++
++    private val context = Context()
++
++    init {
++        messageCollector?.let { JavacLogger.preRegister(context, it) }
++        arguments?.toList()?.let { JavacOptionsMapper.map(Options.instance(context), it) }
++    }
++
++    private val javac = object : JavaCompiler(context) {
++        override fun parseFiles(files: Iterable<JavaFileObject>?) = compilationUnits
++    }
++    private val fileManager = context[JavaFileManager::class.java] as JavacFileManager
++
++    init {
++        fileManager.setLocation(StandardLocation.CLASS_PATH, classPathRoots)
++        outDir?.let {
++            it.mkdirs()
++            fileManager.setLocation(StandardLocation.CLASS_OUTPUT, listOf(it))
++        }
++    }
++
++    private val symbols = Symtab.instance(context)
++    private val trees = JavacTrees.instance(context)
++    private val elements = JavacElements.instance(context)
++    private val fileObjects = fileManager.getJavaFileObjectsFromFiles(javaFiles).toJavacList()
++    private val compilationUnits: JavacList<JCTree.JCCompilationUnit> = fileObjects.map(javac::parse).toJavacList()
++
++    private val javaClasses = compilationUnits
++            .flatMap { unit -> unit.typeDecls
++                    .flatMap { JCClass(it as JCTree.JCClassDecl, trees.getPath(unit, it), this).withInnerClasses() }
++            }
++            .map { it.fqName to it }
++            .toMap()",There is `keysToMap` in Kotlin project itself & also `associateBy` in stdlib. I'm not sure it's quite important but they may be faster (one internal container instead of two) and definitely shorter.,2017-04-05 13:08:29
+707,"@@ -0,0 +1,227 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.JavacClass
++import org.jetbrains.kotlin.wrappers.symbols.JavacPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.wrappers.trees.JCClass
++import org.jetbrains.kotlin.wrappers.trees.JCPackage
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.TypeElement
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class Javac(javaFiles: Collection<File>,
++            classPathRoots: List<File>,
++            outDir: File?,
++            private val messageCollector: MessageCollector?,
++            arguments: Array<String>?) : Closeable {
++
++    companion object {
++        fun getInstance(project: Project): Javac = ServiceManager.getService(project, Javac::class.java)
++    }
++
++    val JAVA_LANG_OBJECT by lazy { findClassInSymbols(CommonClassNames.JAVA_LANG_OBJECT) }
++
++    private val context = Context()
++
++    init {
++        messageCollector?.let { JavacLogger.preRegister(context, it) }
++        arguments?.toList()?.let { JavacOptionsMapper.map(Options.instance(context), it) }
++    }
++
++    private val javac = object : JavaCompiler(context) {
++        override fun parseFiles(files: Iterable<JavaFileObject>?) = compilationUnits
++    }
++    private val fileManager = context[JavaFileManager::class.java] as JavacFileManager
++
++    init {
++        fileManager.setLocation(StandardLocation.CLASS_PATH, classPathRoots)
++        outDir?.let {
++            it.mkdirs()
++            fileManager.setLocation(StandardLocation.CLASS_OUTPUT, listOf(it))
++        }
++    }
++
++    private val symbols = Symtab.instance(context)
++    private val trees = JavacTrees.instance(context)
++    private val elements = JavacElements.instance(context)
++    private val fileObjects = fileManager.getJavaFileObjectsFromFiles(javaFiles).toJavacList()
++    private val compilationUnits: JavacList<JCTree.JCCompilationUnit> = fileObjects.map(javac::parse).toJavacList()
++
++    private val javaClasses = compilationUnits
++            .flatMap { unit -> unit.typeDecls
++                    .flatMap { JCClass(it as JCTree.JCClassDecl, trees.getPath(unit, it), this).withInnerClasses() }
++            }
++            .map { it.fqName to it }
++            .toMap()
++
++    private val javaPackages = compilationUnits
++            .map { FqName(it.packageName.toString()) to JCPackage(it.packageName.toString(), this) }
++            .toMap()",See above,2017-04-05 13:08:45
+709,"@@ -0,0 +1,227 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.JavacClass
++import org.jetbrains.kotlin.wrappers.symbols.JavacPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.wrappers.trees.JCClass
++import org.jetbrains.kotlin.wrappers.trees.JCPackage
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.TypeElement
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class Javac(javaFiles: Collection<File>,
++            classPathRoots: List<File>,
++            outDir: File?,
++            private val messageCollector: MessageCollector?,
++            arguments: Array<String>?) : Closeable {
++
++    companion object {
++        fun getInstance(project: Project): Javac = ServiceManager.getService(project, Javac::class.java)
++    }
++
++    val JAVA_LANG_OBJECT by lazy { findClassInSymbols(CommonClassNames.JAVA_LANG_OBJECT) }
++
++    private val context = Context()
++
++    init {
++        messageCollector?.let { JavacLogger.preRegister(context, it) }
++        arguments?.toList()?.let { JavacOptionsMapper.map(Options.instance(context), it) }
++    }
++
++    private val javac = object : JavaCompiler(context) {
++        override fun parseFiles(files: Iterable<JavaFileObject>?) = compilationUnits
++    }
++    private val fileManager = context[JavaFileManager::class.java] as JavacFileManager
++
++    init {
++        fileManager.setLocation(StandardLocation.CLASS_PATH, classPathRoots)
++        outDir?.let {
++            it.mkdirs()
++            fileManager.setLocation(StandardLocation.CLASS_OUTPUT, listOf(it))
++        }
++    }
++
++    private val symbols = Symtab.instance(context)
++    private val trees = JavacTrees.instance(context)
++    private val elements = JavacElements.instance(context)
++    private val fileObjects = fileManager.getJavaFileObjectsFromFiles(javaFiles).toJavacList()
++    private val compilationUnits: JavacList<JCTree.JCCompilationUnit> = fileObjects.map(javac::parse).toJavacList()
++
++    private val javaClasses = compilationUnits
++            .flatMap { unit -> unit.typeDecls
++                    .flatMap { JCClass(it as JCTree.JCClassDecl, trees.getPath(unit, it), this).withInnerClasses() }
++            }
++            .map { it.fqName to it }
++            .toMap()
++
++    private val javaPackages = compilationUnits
++            .map { FqName(it.packageName.toString()) to JCPackage(it.packageName.toString(), this) }
++            .toMap()
++
++    fun compile() = with(javac) {
++        if (errorCount() > 0) return false
++
++        fileManager.setClassPathForCompilation()
++        messageCollector?.report(CompilerMessageSeverity.INFO,
++                                 ""Compiling Java sources"",
++                                 CompilerMessageLocation.NO_LOCATION)
++        compile(fileObjects)
++        errorCount() == 0
++    }
++
++    override fun close() {
++        fileManager.close()
++        javac.close()
++    }
++
++    fun findClass(fqName: FqName, scope: GlobalSearchScope = EverythingGlobalScope()) = when {
++        scope is EverythingGlobalScope -> javaClasses[fqName] ?: findClassInSymbols(fqName.asString())
++        scope.contains(AnyJavaSourceVirtualFile) -> javaClasses[fqName]","I don't quite understand the idea with this object. As I can see, it's used in `contains` only. Who does put it into the scope?",2017-04-05 13:18:50
+708,"@@ -0,0 +1,227 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.JavacClass
++import org.jetbrains.kotlin.wrappers.symbols.JavacPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.wrappers.trees.JCClass
++import org.jetbrains.kotlin.wrappers.trees.JCPackage
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.TypeElement
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class Javac(javaFiles: Collection<File>,
++            classPathRoots: List<File>,
++            outDir: File?,
++            private val messageCollector: MessageCollector?,
++            arguments: Array<String>?) : Closeable {
++
++    companion object {
++        fun getInstance(project: Project): Javac = ServiceManager.getService(project, Javac::class.java)
++    }
++
++    val JAVA_LANG_OBJECT by lazy { findClassInSymbols(CommonClassNames.JAVA_LANG_OBJECT) }
++
++    private val context = Context()
++
++    init {
++        messageCollector?.let { JavacLogger.preRegister(context, it) }
++        arguments?.toList()?.let { JavacOptionsMapper.map(Options.instance(context), it) }
++    }
++
++    private val javac = object : JavaCompiler(context) {
++        override fun parseFiles(files: Iterable<JavaFileObject>?) = compilationUnits
++    }
++    private val fileManager = context[JavaFileManager::class.java] as JavacFileManager
++
++    init {
++        fileManager.setLocation(StandardLocation.CLASS_PATH, classPathRoots)
++        outDir?.let {
++            it.mkdirs()
++            fileManager.setLocation(StandardLocation.CLASS_OUTPUT, listOf(it))
++        }
++    }
++
++    private val symbols = Symtab.instance(context)
++    private val trees = JavacTrees.instance(context)
++    private val elements = JavacElements.instance(context)
++    private val fileObjects = fileManager.getJavaFileObjectsFromFiles(javaFiles).toJavacList()
++    private val compilationUnits: JavacList<JCTree.JCCompilationUnit> = fileObjects.map(javac::parse).toJavacList()
++
++    private val javaClasses = compilationUnits
++            .flatMap { unit -> unit.typeDecls
++                    .flatMap { JCClass(it as JCTree.JCClassDecl, trees.getPath(unit, it), this).withInnerClasses() }
++            }
++            .map { it.fqName to it }
++            .toMap()
++
++    private val javaPackages = compilationUnits
++            .map { FqName(it.packageName.toString()) to JCPackage(it.packageName.toString(), this) }
++            .toMap()
++
++    fun compile() = with(javac) {
++        if (errorCount() > 0) return false
++
++        fileManager.setClassPathForCompilation()
++        messageCollector?.report(CompilerMessageSeverity.INFO,
++                                 ""Compiling Java sources"",
++                                 CompilerMessageLocation.NO_LOCATION)
++        compile(fileObjects)
++        errorCount() == 0
++    }
++
++    override fun close() {
++        fileManager.close()
++        javac.close()
++    }
++
++    fun findClass(fqName: FqName, scope: GlobalSearchScope = EverythingGlobalScope()) = when {
++        scope is EverythingGlobalScope -> javaClasses[fqName] ?: findClassInSymbols(fqName.asString())
++        scope.contains(AnyJavaSourceVirtualFile) -> javaClasses[fqName]
++        else -> findClassInSymbols(fqName.asString()) ?: javaClasses[fqName]
++    }
++
++    fun findPackage(fqName: FqName, scope: GlobalSearchScope) = when {
++        scope is EverythingGlobalScope -> javaPackages[fqName] ?: findPackageInSymbols(fqName.asString())
++        scope.contains(AnyJavaSourceVirtualFile) -> javaPackages[fqName]
++        else -> findPackageInSymbols(fqName.asString()) ?: javaPackages[fqName]
++    }
++
++    fun findSubPackages(fqName: FqName) = symbols.packages
++                                                  .filter { (k, _) -> k.toString().startsWith(""$fqName."") }
++                                                  .map { JavacPackage(it.value, this) } +
++                                          javaPackages
++                                                  .filter { it.key.isSubpackageOf(fqName) && it.key != fqName }
++                                                  .map { it.value }",There is `filterValues`.,2017-04-05 13:10:49
+710,"@@ -0,0 +1,227 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.JavacClass
++import org.jetbrains.kotlin.wrappers.symbols.JavacPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.wrappers.trees.JCClass
++import org.jetbrains.kotlin.wrappers.trees.JCPackage
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.TypeElement
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class Javac(javaFiles: Collection<File>,
++            classPathRoots: List<File>,
++            outDir: File?,
++            private val messageCollector: MessageCollector?,
++            arguments: Array<String>?) : Closeable {
++
++    companion object {
++        fun getInstance(project: Project): Javac = ServiceManager.getService(project, Javac::class.java)
++    }
++
++    val JAVA_LANG_OBJECT by lazy { findClassInSymbols(CommonClassNames.JAVA_LANG_OBJECT) }
++
++    private val context = Context()
++
++    init {
++        messageCollector?.let { JavacLogger.preRegister(context, it) }
++        arguments?.toList()?.let { JavacOptionsMapper.map(Options.instance(context), it) }
++    }
++
++    private val javac = object : JavaCompiler(context) {
++        override fun parseFiles(files: Iterable<JavaFileObject>?) = compilationUnits
++    }
++    private val fileManager = context[JavaFileManager::class.java] as JavacFileManager
++
++    init {
++        fileManager.setLocation(StandardLocation.CLASS_PATH, classPathRoots)
++        outDir?.let {
++            it.mkdirs()
++            fileManager.setLocation(StandardLocation.CLASS_OUTPUT, listOf(it))
++        }
++    }
++
++    private val symbols = Symtab.instance(context)
++    private val trees = JavacTrees.instance(context)
++    private val elements = JavacElements.instance(context)
++    private val fileObjects = fileManager.getJavaFileObjectsFromFiles(javaFiles).toJavacList()
++    private val compilationUnits: JavacList<JCTree.JCCompilationUnit> = fileObjects.map(javac::parse).toJavacList()
++
++    private val javaClasses = compilationUnits
++            .flatMap { unit -> unit.typeDecls
++                    .flatMap { JCClass(it as JCTree.JCClassDecl, trees.getPath(unit, it), this).withInnerClasses() }
++            }
++            .map { it.fqName to it }
++            .toMap()
++
++    private val javaPackages = compilationUnits
++            .map { FqName(it.packageName.toString()) to JCPackage(it.packageName.toString(), this) }
++            .toMap()
++
++    fun compile() = with(javac) {
++        if (errorCount() > 0) return false
++
++        fileManager.setClassPathForCompilation()
++        messageCollector?.report(CompilerMessageSeverity.INFO,
++                                 ""Compiling Java sources"",
++                                 CompilerMessageLocation.NO_LOCATION)
++        compile(fileObjects)
++        errorCount() == 0
++    }
++
++    override fun close() {
++        fileManager.close()
++        javac.close()
++    }
++
++    fun findClass(fqName: FqName, scope: GlobalSearchScope = EverythingGlobalScope()) = when {
++        scope is EverythingGlobalScope -> javaClasses[fqName] ?: findClassInSymbols(fqName.asString())
++        scope.contains(AnyJavaSourceVirtualFile) -> javaClasses[fqName]
++        else -> findClassInSymbols(fqName.asString()) ?: javaClasses[fqName]
++    }
++
++    fun findPackage(fqName: FqName, scope: GlobalSearchScope) = when {
++        scope is EverythingGlobalScope -> javaPackages[fqName] ?: findPackageInSymbols(fqName.asString())
++        scope.contains(AnyJavaSourceVirtualFile) -> javaPackages[fqName]
++        else -> findPackageInSymbols(fqName.asString()) ?: javaPackages[fqName]
++    }
++
++    fun findSubPackages(fqName: FqName) = symbols.packages
++                                                  .filter { (k, _) -> k.toString().startsWith(""$fqName."") }
++                                                  .map { JavacPackage(it.value, this) } +
++                                          javaPackages
++                                                  .filter { it.key.isSubpackageOf(fqName) && it.key != fqName }
++                                                  .map { it.value }
++
++    fun findClassesFromPackage(fqName: FqName) = javaClasses.filter { it.key?.parentOrNull() == fqName }
++                                                         .flatMap { it.value.withInnerClasses() } +
++                                                 elements.getPackageElement(fqName.asString())
++                                                         ?.members()
++                                                         ?.elements
++                                                         ?.filterIsInstance(TypeElement::class.java)
++                                                         ?.map { JavacClass(it, this) }
++                                                         .orEmpty()
++
++    fun getTreePath(tree: JCTree, compilationUnit: CompilationUnitTree): TreePath = trees.getPath(compilationUnit, tree)
++
++    private inline fun <reified T> Iterable<T>.toJavacList() = JavacList.from(this)
++
++    private fun findClassInSymbols(fqName: String) = elements.getTypeElement(fqName)?.let { JavacClass(it, this) }
++
++    private fun findPackageInSymbols(fqName: String) = elements.getPackageElement(fqName)?.let { JavacPackage(it, this) }
++
++    private fun JavacFileManager.setClassPathForCompilation() = apply {
++        setLocation(StandardLocation.CLASS_PATH,
++                    getLocation(StandardLocation.CLASS_PATH) + getLocation(StandardLocation.CLASS_OUTPUT))
++
++        val reader = ClassReader.instance(context)
++        val names = Names.instance(context)
++        val outDirName = getLocation(StandardLocation.CLASS_OUTPUT).firstOrNull()?.path ?: """"
++
++        list(StandardLocation.CLASS_OUTPUT, """", setOf(JavaFileObject.Kind.CLASS), true)
++                .forEach {
++                    val fqName = it.name
++                            .substringAfter(outDirName)
++                            .substringBefore("".class"")
++                            .replace(""/"", ""."")
++                            .let { if (it.startsWith(""."")) it.substring(1) else it }
++                            .let(names::fromString)
++
++                    symbols.classes[fqName]?.let { symbols.classes[fqName] = null }
++                    val symbol = reader.enterClass(fqName, it)
++
++                    (elements.getPackageOf(symbol) as? Symbol.PackageSymbol)?.let {
++                        it.members_field.enter(symbol)
++                        it.flags_field = it.flags_field or Flags.EXISTS.toLong()
++                    }
++                }
++
++    }
++
++    private fun JavaClass.withInnerClasses(): List<JavaClass> = listOf(this) + innerClasses.flatMap { it.withInnerClasses() }
++
++}
++
++private object AnyJavaSourceVirtualFile : VirtualFile() {
++    override fun refresh(asynchronous: Boolean, recursive: Boolean, postRunnable: Runnable?) {}
++
++    override fun getLength() = 0L
++
++    override fun getFileSystem() = throw UnsupportedOperationException()","May be (if you need this object at all) it's better to provide some message like `""Should never be called""`. ",2017-04-05 13:20:04
+977,"@@ -0,0 +1,24 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.factories
++
++import org.jetbrains.kotlin.effectsystem.structure.ESBooleanExpression
++import org.jetbrains.kotlin.effectsystem.structure.ESClause
++import org.jetbrains.kotlin.effectsystem.structure.ESEffect
++
++fun createClause(premise: ESBooleanExpression, conclusion: ESEffect) = ESClause(premise, conclusion)
++fun createUnconditionalClause(effect: ESEffect): ESClause = ESClause(true.lift(), effect)","Why do we need this `unconditionalClause`? As far as I understand it's interpreted as ""if effect takes place then true is true"", and this statement is always true.",2017-08-15 16:24:21
+538,"@@ -0,0 +1,240 @@
++@file:kotlin.jvm.JvmMultifileClass
++@file:kotlin.jvm.JvmName(""StringsKt"")
++@file:Suppress(""PLATFORM_CLASS_MAPPED_TO_KOTLIN"")
++
++package kotlin.text
++
++
++/**
++ * Returns `true` if the contents of this string is equal to the word ""true"", ignoring case, and `false` otherwise.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toBoolean(): Boolean = java.lang.Boolean.parseBoolean(this)
++
++/**
++ * Parses the string as a signed [Byte] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toByte(radix: Int = 10): Byte = java.lang.Byte.parseByte(this, radix)
++
++/**
++ * Parses the string as a [Short] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toShort(radix: Int = 10): Short = java.lang.Short.parseShort(this, radix)
++
++/**
++ * Parses the string as an [Int] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toInt(radix: Int = 10): Int = java.lang.Integer.parseInt(this, radix)
++
++/**
++ * Parses the string as a [Long] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toLong(radix: Int = 10): Long = java.lang.Long.parseLong(this, radix)
++
++/**
++ * Parses the string as a [Float] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toFloat(radix: Int = 10): Float = java.lang.Float.parseFloat(this)","Radix parameter seems to be unused
+",2016-04-21 07:07:12
+539,"@@ -0,0 +1,240 @@
++@file:kotlin.jvm.JvmMultifileClass
++@file:kotlin.jvm.JvmName(""StringsKt"")
++@file:Suppress(""PLATFORM_CLASS_MAPPED_TO_KOTLIN"")
++
++package kotlin.text
++
++
++/**
++ * Returns `true` if the contents of this string is equal to the word ""true"", ignoring case, and `false` otherwise.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toBoolean(): Boolean = java.lang.Boolean.parseBoolean(this)
++
++/**
++ * Parses the string as a signed [Byte] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toByte(radix: Int = 10): Byte = java.lang.Byte.parseByte(this, radix)
++
++/**
++ * Parses the string as a [Short] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toShort(radix: Int = 10): Short = java.lang.Short.parseShort(this, radix)
++
++/**
++ * Parses the string as an [Int] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toInt(radix: Int = 10): Int = java.lang.Integer.parseInt(this, radix)
++
++/**
++ * Parses the string as a [Long] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toLong(radix: Int = 10): Long = java.lang.Long.parseLong(this, radix)
++
++/**
++ * Parses the string as a [Float] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toFloat(radix: Int = 10): Float = java.lang.Float.parseFloat(this)
++
++/**
++ * Parses the string as a [Double] number and returns the result.
++ * @throws NumberFormatException if the string is not a valid representation of a number.
++ */
++@kotlin.internal.InlineOnly
++public inline fun String.toDouble(radix: Int = 10): Double = java.lang.Double.parseDouble(this)","Radix parameter seems to be unused
+",2016-04-21 07:07:21
+791,"@@ -0,0 +1,243 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope","I think it would be nice to move parts of this class that use `com.intellij.openapi` to other compiler modules, to get rid of dependency of module `javac-wrapper` on `openapi`. This can be done in the future, I suppose.",2017-04-25 10:28:28
+776,"@@ -0,0 +1,243 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.model.JavacTypes
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.config.CompilerConfiguration
++import org.jetbrains.kotlin.config.JVMConfigurationKeys
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.wrappers.trees.TreeBasedClass
++import org.jetbrains.kotlin.wrappers.trees.TreeBasedPackage
++import org.jetbrains.kotlin.wrappers.trees.TreePathResolverCache
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.Element
++import javax.lang.model.element.TypeElement
++import javax.lang.model.type.TypeMirror
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class JavacWrapper(javaFiles: Collection<File>,","Since you're passing `CompilerConfiguration` here, there's no need to pass `classPathRoots` and `messageCollector` separately because in production code, they can be trivially obtained from the configuration (and tests can be adapted to mimic that)",2017-04-25 07:50:20
+813,"@@ -0,0 +1,243 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.intellij.ide.highlighter.JavaFileType
++import com.intellij.openapi.components.ServiceManager
++import com.intellij.openapi.fileTypes.FileType
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.CommonClassNames
++import com.intellij.psi.search.EverythingGlobalScope
++import com.intellij.psi.search.GlobalSearchScope
++import com.sun.source.tree.CompilationUnitTree
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.api.JavacTrees
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.code.Symbol
++import com.sun.tools.javac.code.Symtab
++import com.sun.tools.javac.file.JavacFileManager
++import com.sun.tools.javac.jvm.ClassReader
++import com.sun.tools.javac.main.JavaCompiler
++import com.sun.tools.javac.model.JavacElements
++import com.sun.tools.javac.model.JavacTypes
++import com.sun.tools.javac.tree.JCTree
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Names
++import com.sun.tools.javac.util.Options
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.config.CompilerConfiguration
++import org.jetbrains.kotlin.config.JVMConfigurationKeys
++import com.sun.tools.javac.util.List as JavacList
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedClass
++import org.jetbrains.kotlin.wrappers.symbols.SymbolBasedPackage
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.isSubpackageOf
++import org.jetbrains.kotlin.name.parentOrNull
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.wrappers.trees.TreeBasedClass
++import org.jetbrains.kotlin.wrappers.trees.TreeBasedPackage
++import org.jetbrains.kotlin.wrappers.trees.TreePathResolverCache
++import java.io.Closeable
++import java.io.File
++import javax.lang.model.element.Element
++import javax.lang.model.element.TypeElement
++import javax.lang.model.type.TypeMirror
++import javax.tools.JavaFileManager
++import javax.tools.JavaFileObject
++import javax.tools.StandardLocation
++
++class JavacWrapper(javaFiles: Collection<File>,
++                   kotlinFiles: Collection<KtFile>,
++                   classPathRoots: List<File>,
++                   private val configuration: CompilerConfiguration,
++                   private val messageCollector: MessageCollector?,
++                   arguments: Array<String>?) : Closeable {
++
++    companion object {
++        fun getInstance(project: Project): JavacWrapper = ServiceManager.getService(project, JavacWrapper::class.java)
++    }
++
++    val JAVA_LANG_OBJECT by lazy { findClassInSymbols(CommonClassNames.JAVA_LANG_OBJECT) }
++
++    private val context = Context()
++
++    init {
++        messageCollector?.let { JavacLogger.preRegister(context, it) }
++        arguments?.toList()?.let { JavacOptionsMapper.map(Options.instance(context), it) }
++    }
++
++    private val javac = object : JavaCompiler(context) {
++        override fun parseFiles(files: Iterable<JavaFileObject>?) = compilationUnits
++    }
++    private val fileManager = context[JavaFileManager::class.java] as JavacFileManager
++
++    init {
++        fileManager.setLocation(StandardLocation.CLASS_PATH, classPathRoots)
++    }
++
++    private val symbols = Symtab.instance(context)
++    private val trees = JavacTrees.instance(context)
++    private val elements = JavacElements.instance(context)
++    private val types = JavacTypes.instance(context)
++    private val fileObjects = fileManager.getJavaFileObjectsFromFiles(javaFiles).toJavacList()
++    private val compilationUnits: JavacList<JCTree.JCCompilationUnit> = fileObjects.map(javac::parse).toJavacList()
++
++    private val javaClasses = compilationUnits
++            .flatMap { unit -> unit.typeDecls
++                    .flatMap { TreeBasedClass(it as JCTree.JCClassDecl, trees.getPath(unit, it), this).withInnerClasses() }
++            }
++            .associateBy(JavaClass::fqName)
++
++    private val javaPackages = compilationUnits
++            .map { TreeBasedPackage(it.packageName.toString(), this) }
++            .associateBy(TreeBasedPackage::fqName)
++
++    private val kotlinClassifiersCache = KotlinClassifiersCache(kotlinFiles, this)
++    private val treePathResolverCache = TreePathResolverCache(this)
++
++    fun compile(outDir: File? = null) = with(javac) {
++        if (errorCount() > 0) return false
++
++        fileManager.setClassPathForCompilation(outDir)
++        messageCollector?.report(CompilerMessageSeverity.INFO,
++                                 ""Compiling Java sources"")
++        compile(fileObjects)
++        errorCount() == 0
++    }
++
++    override fun close() {
++        fileManager.close()
++        javac.close()
++    }
++
++    fun findClass(fqName: FqName, scope: GlobalSearchScope = EverythingGlobalScope()) = when {
++        scope is EverythingGlobalScope -> javaClasses[fqName] ?: findClassInSymbols(fqName.asString())","Using `instanceof` on `GlobalSearchScope` is very risky and should be avoided at all costs. For example, if I wrap the everything-scope twice into the not-scope:
+```
+GlobalSearchScope.notScope(GlobalSearchScope.notScope(
+    GlobalSearchScope.allScope(project)
+))
+```
+The resulting scope will be effectively the same, but your code won't work anymore because it would be another instance.
+
+Also, relying on specific scopes being passed here (like a scope with all .java files) is risky as well, because we might reconfigure the compiler in such a way that the compiled module is split into a different set of scopes in the near future.",2017-04-25 12:40:53
+136,"@@ -0,0 +1,25 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++public enum class ExpressionKind(val output: String) {
++    IF : ExpressionKind(""if"")
++    ELSE : ExpressionKind(""else"")
++    WHILE : ExpressionKind(""while"")
++    DOWHILE : ExpressionKind(""do...while"")
++    FOR : ExpressionKind(""for"")
++}","Storing string representation in enum is a good idea.  
+I think this enum shouldn't be public and is better to put it near corresponding methods in Utils.kt
+",2014-03-05 16:42:00
+489,"@@ -0,0 +1,25 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.psi;
++
++import com.intellij.psi.PsiElement;
++import org.jetbrains.annotations.Nullable;
++
++public interface KtValVarKeywordProvider extends PsiElement {","""Provider"" is not a great name for it, I think
+",2015-11-03 11:53:33
+480,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(","Not related to changes, but why is it uppercase?
+",2015-09-23 14:50:43
+479,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))","Please use Kotlin's `split`
+",2015-09-23 14:48:19
+478,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))
++
++            val argsArray = ArrayUtil.toStringArray(argumentsList)","`toTypedArray()`
+",2015-09-23 14:48:04
+477,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))
++
++            val argsArray = ArrayUtil.toStringArray(argumentsList)
++
++            if (!tryCompileWithDaemon(messageCollector, collector, environment, argsArray)) {
++                // otherwise fallback to in-process
++
++                val stream = ByteArrayOutputStream()
++                val out = PrintStream(stream)
++
++                val rc = CompilerRunnerUtil.invokeExecMethod(compilerClassName, argsArray, environment, messageCollector, out)
++
++                // exec() returns an ExitCode object, class of which is loaded with a different class loader,
++                // so we take it's contents through reflection
++                ProcessCompilerOutput(messageCollector, collector, stream, getReturnCodeFromObject(rc))
++            }
++        }
++        catch (e: Throwable) {
++            MessageCollectorUtil.reportException(messageCollector, e)
++            reportInternalCompilerError(messageCollector)
++        }
++
++    }
++
++    private fun tryCompileWithDaemon(messageCollector: MessageCollector,
++                                     collector: OutputItemsCollector,
++                                     environment: CompilerEnvironment,
++                                     argsArray: Array<String>): Boolean {
++        if (isDaemonEnabled()) {","Early return would be helpful
+",2015-09-23 14:47:49
+476,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))
++
++            val argsArray = ArrayUtil.toStringArray(argumentsList)
++
++            if (!tryCompileWithDaemon(messageCollector, collector, environment, argsArray)) {
++                // otherwise fallback to in-process
++
++                val stream = ByteArrayOutputStream()
++                val out = PrintStream(stream)
++
++                val rc = CompilerRunnerUtil.invokeExecMethod(compilerClassName, argsArray, environment, messageCollector, out)
++
++                // exec() returns an ExitCode object, class of which is loaded with a different class loader,
++                // so we take it's contents through reflection
++                ProcessCompilerOutput(messageCollector, collector, stream, getReturnCodeFromObject(rc))
++            }
++        }
++        catch (e: Throwable) {
++            MessageCollectorUtil.reportException(messageCollector, e)
++            reportInternalCompilerError(messageCollector)
++        }
++
++    }
++
++    private fun tryCompileWithDaemon(messageCollector: MessageCollector,
++                                     collector: OutputItemsCollector,
++                                     environment: CompilerEnvironment,
++                                     argsArray: Array<String>): Boolean {
++        if (isDaemonEnabled()) {
++            val libPath = CompilerRunnerUtil.getLibPath(environment.kotlinPaths, messageCollector)
++            // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
++            //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
++            val compilerId = CompilerId.makeCompilerId(File(libPath, ""kotlin-compiler.jar""))
++            val daemonOptions = configureDaemonOptions()
++            val daemonJVMOptions = configureDaemonJVMOptions(true)
++
++            val daemonReportMessages = ArrayList<DaemonReportMessage>()
++
++            val daemon = KotlinCompilerClient.connectToCompileService(compilerId, daemonJVMOptions, daemonOptions, DaemonReportingTargets(null, daemonReportMessages), true, true)
++
++            for (msg in daemonReportMessages) {
++                if (msg.category === DaemonReportCategory.EXCEPTION && daemon == null) {
++                    messageCollector.report(CompilerMessageSeverity.INFO,
++                                            ""Falling  back to compilation without daemon due to error: "" + msg.message,
++                                            CompilerMessageLocation.NO_LOCATION)
++                }
++                else {
++                    messageCollector.report(CompilerMessageSeverity.INFO, msg.message, CompilerMessageLocation.NO_LOCATION)
++                }
++            }
++
++            if (daemon != null) {
++                val compilerOut = ByteArrayOutputStream()
++                val daemonOut = ByteArrayOutputStream()
++
++                val services = CompilationServices(
++                        incrementalCompilationComponents = environment.services.get(IncrementalCompilationComponents::class.java),
++                        compilationCanceledStatus = environment.services.get(CompilationCanceledStatus::class.java))
++
++                val res = KotlinCompilerClient.incrementalCompile(daemon, argsArray, services, compilerOut, daemonOut)
++
++                ProcessCompilerOutput(messageCollector, collector, compilerOut, res.toString())
++                BufferedReader(StringReader(daemonOut.toString())).forEachLine {
++                    messageCollector.report(CompilerMessageSeverity.INFO, it, CompilerMessageLocation.NO_LOCATION)
++                }
++                return true
++            }
++        }
++        return false
++    }
++
++    private fun getReturnCodeFromObject(rc: Any?): String {
++        if (rc == null) {","`when`
+",2015-09-23 14:46:49
+475,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))
++
++            val argsArray = ArrayUtil.toStringArray(argumentsList)
++
++            if (!tryCompileWithDaemon(messageCollector, collector, environment, argsArray)) {
++                // otherwise fallback to in-process
++
++                val stream = ByteArrayOutputStream()
++                val out = PrintStream(stream)
++
++                val rc = CompilerRunnerUtil.invokeExecMethod(compilerClassName, argsArray, environment, messageCollector, out)
++
++                // exec() returns an ExitCode object, class of which is loaded with a different class loader,
++                // so we take it's contents through reflection
++                ProcessCompilerOutput(messageCollector, collector, stream, getReturnCodeFromObject(rc))
++            }
++        }
++        catch (e: Throwable) {
++            MessageCollectorUtil.reportException(messageCollector, e)
++            reportInternalCompilerError(messageCollector)
++        }
++
++    }
++
++    private fun tryCompileWithDaemon(messageCollector: MessageCollector,
++                                     collector: OutputItemsCollector,
++                                     environment: CompilerEnvironment,
++                                     argsArray: Array<String>): Boolean {
++        if (isDaemonEnabled()) {
++            val libPath = CompilerRunnerUtil.getLibPath(environment.kotlinPaths, messageCollector)
++            // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
++            //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
++            val compilerId = CompilerId.makeCompilerId(File(libPath, ""kotlin-compiler.jar""))
++            val daemonOptions = configureDaemonOptions()
++            val daemonJVMOptions = configureDaemonJVMOptions(true)
++
++            val daemonReportMessages = ArrayList<DaemonReportMessage>()
++
++            val daemon = KotlinCompilerClient.connectToCompileService(compilerId, daemonJVMOptions, daemonOptions, DaemonReportingTargets(null, daemonReportMessages), true, true)
++
++            for (msg in daemonReportMessages) {
++                if (msg.category === DaemonReportCategory.EXCEPTION && daemon == null) {
++                    messageCollector.report(CompilerMessageSeverity.INFO,
++                                            ""Falling  back to compilation without daemon due to error: "" + msg.message,
++                                            CompilerMessageLocation.NO_LOCATION)
++                }
++                else {
++                    messageCollector.report(CompilerMessageSeverity.INFO, msg.message, CompilerMessageLocation.NO_LOCATION)
++                }
++            }
++
++            if (daemon != null) {
++                val compilerOut = ByteArrayOutputStream()
++                val daemonOut = ByteArrayOutputStream()
++
++                val services = CompilationServices(
++                        incrementalCompilationComponents = environment.services.get(IncrementalCompilationComponents::class.java),
++                        compilationCanceledStatus = environment.services.get(CompilationCanceledStatus::class.java))
++
++                val res = KotlinCompilerClient.incrementalCompile(daemon, argsArray, services, compilerOut, daemonOut)
++
++                ProcessCompilerOutput(messageCollector, collector, compilerOut, res.toString())
++                BufferedReader(StringReader(daemonOut.toString())).forEachLine {
++                    messageCollector.report(CompilerMessageSeverity.INFO, it, CompilerMessageLocation.NO_LOCATION)
++                }
++                return true
++            }
++        }
++        return false
++    }
++
++    private fun getReturnCodeFromObject(rc: Any?): String {
++        if (rc == null) {
++            return INTERNAL_ERROR
++        }
++        else if (ExitCode::class.java.name == rc.javaClass.name) {
++            return rc.toString()
++        }
++        else {
++            throw IllegalStateException(""Unexpected return: "" + rc)
++        }
++    }
++
++    private fun <T : CommonCompilerArguments> mergeBeans(from: CommonCompilerArguments, to: T): T {
++        // TODO: rewrite when updated version of com.intellij.util.xmlb is available on TeamCity
++        try {
++            val copy = XmlSerializerUtil.createCopy(to)
++
++            val fromFields = collectFieldsToCopy(from.javaClass)
++            for (fromField in fromFields) {
++                val toField = copy.javaClass.getField(fromField.name)
++                toField.set(copy, fromField.get(from))
++            }
++
++            return copy
++        }
++        catch (e: NoSuchFieldException) {
++            throw rethrow(e)
++        }
++        catch (e: IllegalAccessException) {
++            throw rethrow(e)","This `try`/`catch` and `rethrow`s are not needed in Kotlin
+",2015-09-23 14:46:18
+473,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))
++
++            val argsArray = ArrayUtil.toStringArray(argumentsList)
++
++            if (!tryCompileWithDaemon(messageCollector, collector, environment, argsArray)) {
++                // otherwise fallback to in-process
++
++                val stream = ByteArrayOutputStream()
++                val out = PrintStream(stream)
++
++                val rc = CompilerRunnerUtil.invokeExecMethod(compilerClassName, argsArray, environment, messageCollector, out)
++
++                // exec() returns an ExitCode object, class of which is loaded with a different class loader,
++                // so we take it's contents through reflection
++                ProcessCompilerOutput(messageCollector, collector, stream, getReturnCodeFromObject(rc))
++            }
++        }
++        catch (e: Throwable) {
++            MessageCollectorUtil.reportException(messageCollector, e)
++            reportInternalCompilerError(messageCollector)
++        }
++
++    }
++
++    private fun tryCompileWithDaemon(messageCollector: MessageCollector,
++                                     collector: OutputItemsCollector,
++                                     environment: CompilerEnvironment,
++                                     argsArray: Array<String>): Boolean {
++        if (isDaemonEnabled()) {
++            val libPath = CompilerRunnerUtil.getLibPath(environment.kotlinPaths, messageCollector)
++            // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
++            //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
++            val compilerId = CompilerId.makeCompilerId(File(libPath, ""kotlin-compiler.jar""))
++            val daemonOptions = configureDaemonOptions()
++            val daemonJVMOptions = configureDaemonJVMOptions(true)
++
++            val daemonReportMessages = ArrayList<DaemonReportMessage>()
++
++            val daemon = KotlinCompilerClient.connectToCompileService(compilerId, daemonJVMOptions, daemonOptions, DaemonReportingTargets(null, daemonReportMessages), true, true)
++
++            for (msg in daemonReportMessages) {
++                if (msg.category === DaemonReportCategory.EXCEPTION && daemon == null) {
++                    messageCollector.report(CompilerMessageSeverity.INFO,
++                                            ""Falling  back to compilation without daemon due to error: "" + msg.message,
++                                            CompilerMessageLocation.NO_LOCATION)
++                }
++                else {
++                    messageCollector.report(CompilerMessageSeverity.INFO, msg.message, CompilerMessageLocation.NO_LOCATION)
++                }
++            }
++
++            if (daemon != null) {
++                val compilerOut = ByteArrayOutputStream()
++                val daemonOut = ByteArrayOutputStream()
++
++                val services = CompilationServices(
++                        incrementalCompilationComponents = environment.services.get(IncrementalCompilationComponents::class.java),
++                        compilationCanceledStatus = environment.services.get(CompilationCanceledStatus::class.java))
++
++                val res = KotlinCompilerClient.incrementalCompile(daemon, argsArray, services, compilerOut, daemonOut)
++
++                ProcessCompilerOutput(messageCollector, collector, compilerOut, res.toString())
++                BufferedReader(StringReader(daemonOut.toString())).forEachLine {
++                    messageCollector.report(CompilerMessageSeverity.INFO, it, CompilerMessageLocation.NO_LOCATION)
++                }
++                return true
++            }
++        }
++        return false
++    }
++
++    private fun getReturnCodeFromObject(rc: Any?): String {
++        if (rc == null) {
++            return INTERNAL_ERROR
++        }
++        else if (ExitCode::class.java.name == rc.javaClass.name) {
++            return rc.toString()
++        }
++        else {
++            throw IllegalStateException(""Unexpected return: "" + rc)
++        }
++    }
++
++    private fun <T : CommonCompilerArguments> mergeBeans(from: CommonCompilerArguments, to: T): T {
++        // TODO: rewrite when updated version of com.intellij.util.xmlb is available on TeamCity
++        try {
++            val copy = XmlSerializerUtil.createCopy(to)
++
++            val fromFields = collectFieldsToCopy(from.javaClass)
++            for (fromField in fromFields) {
++                val toField = copy.javaClass.getField(fromField.name)
++                toField.set(copy, fromField.get(from))
++            }
++
++            return copy
++        }
++        catch (e: NoSuchFieldException) {
++            throw rethrow(e)
++        }
++        catch (e: IllegalAccessException) {
++            throw rethrow(e)
++        }
++
++    }
++
++    private fun collectFieldsToCopy(clazz: Class<*>): List<Field> {
++        val fromFields = ArrayList<Field>()
++
++        var currentClass: Class<*>? = clazz
++        while (currentClass != null) {
++            for (field in currentClass.declaredFields) {
++                val modifiers = field.modifiers
++                if (!Modifier.isStatic(modifiers) && Modifier.isPublic(modifiers)) {
++                    fromFields.add(field)
++                }
++            }
++            currentClass = currentClass.superclass
++        }
++
++        return fromFields
++    }
++
++    private fun setupK2JvmArguments(moduleFile: File, settings: K2JVMCompilerArguments) {
++        settings.module = moduleFile.absolutePath
++        settings.noStdlib = true
++        settings.noJdkAnnotations = true
++        settings.noJdk = true
++    }
++
++    private fun setupK2JsArguments(
++            outputFile: File,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            settings: K2JSCompilerArguments) {
++        settings.noStdlib = true
++        settings.freeArgs = ContainerUtil.map(sourceFiles, object : Function<File, String> {","Please use Kotlin's `map { ... }`
+",2015-09-23 14:45:19
+474,"@@ -0,0 +1,255 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.compilerRunner
++
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.util.ArrayUtil
++import com.intellij.util.Function
++import com.intellij.util.containers.ContainerUtil
++import com.intellij.util.xmlb.XmlSerializerUtil
++import org.jetbrains.kotlin.cli.common.ExitCode
++import org.jetbrains.kotlin.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.kotlin.cli.common.arguments.K2JVMCompilerArguments
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageLocation
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.ERROR
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity.INFO
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollectorUtil
++import org.jetbrains.kotlin.config.CompilerSettings
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCompilationComponents
++import org.jetbrains.kotlin.progress.CompilationCanceledStatus
++import org.jetbrains.kotlin.rmi.CompilerId
++import org.jetbrains.kotlin.rmi.configureDaemonJVMOptions
++import org.jetbrains.kotlin.rmi.configureDaemonOptions
++import org.jetbrains.kotlin.rmi.isDaemonEnabled
++import org.jetbrains.kotlin.rmi.kotlinr.*
++import org.jetbrains.kotlin.utils.rethrow
++import java.io.*
++import java.lang.reflect.Field
++import java.lang.reflect.Modifier
++import java.util.*
++
++public object KotlinCompilerRunner {
++    private val K2JVM_COMPILER = ""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""
++    private val K2JS_COMPILER = ""org.jetbrains.kotlin.cli.js.K2JSCompiler""
++    private val INTERNAL_ERROR = ExitCode.INTERNAL_ERROR.toString()
++
++    public fun runK2JvmCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jvmArguments: K2JVMCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            moduleFile: File,
++            collector: OutputItemsCollector) {
++        val arguments = mergeBeans(commonArguments, k2jvmArguments)
++        setupK2JvmArguments(moduleFile, arguments)
++
++        runCompiler(K2JVM_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    public fun runK2JsCompiler(
++            commonArguments: CommonCompilerArguments,
++            k2jsArguments: K2JSCompilerArguments,
++            compilerSettings: CompilerSettings,
++            messageCollector: MessageCollector,
++            environment: CompilerEnvironment,
++            collector: OutputItemsCollector,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            outputFile: File) {
++        val arguments = mergeBeans(commonArguments, k2jsArguments)
++        setupK2JsArguments(outputFile, sourceFiles, libraryFiles, arguments)
++
++        runCompiler(K2JS_COMPILER, arguments, compilerSettings.additionalArguments, messageCollector, collector, environment)
++    }
++
++    private fun ProcessCompilerOutput(
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            stream: ByteArrayOutputStream,
++            exitCode: String) {
++        val reader = BufferedReader(StringReader(stream.toString()))
++        CompilerOutputParser.parseCompilerMessagesFromReader(messageCollector, reader, collector)
++
++        if (INTERNAL_ERROR == exitCode) {
++            reportInternalCompilerError(messageCollector)
++        }
++    }
++
++    private fun reportInternalCompilerError(messageCollector: MessageCollector) {
++        messageCollector.report(ERROR, ""Compiler terminated with internal error"", CompilerMessageLocation.NO_LOCATION)
++    }
++
++    private fun runCompiler(
++            compilerClassName: String,
++            arguments: CommonCompilerArguments,
++            additionalArguments: String,
++            messageCollector: MessageCollector,
++            collector: OutputItemsCollector,
++            environment: CompilerEnvironment) {
++        try {
++            messageCollector.report(INFO, ""Using kotlin-home = "" + environment.kotlinPaths.homePath, CompilerMessageLocation.NO_LOCATION)
++
++            val argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments)
++            argumentsList.addAll(StringUtil.split(additionalArguments, "" ""))
++
++            val argsArray = ArrayUtil.toStringArray(argumentsList)
++
++            if (!tryCompileWithDaemon(messageCollector, collector, environment, argsArray)) {
++                // otherwise fallback to in-process
++
++                val stream = ByteArrayOutputStream()
++                val out = PrintStream(stream)
++
++                val rc = CompilerRunnerUtil.invokeExecMethod(compilerClassName, argsArray, environment, messageCollector, out)
++
++                // exec() returns an ExitCode object, class of which is loaded with a different class loader,
++                // so we take it's contents through reflection
++                ProcessCompilerOutput(messageCollector, collector, stream, getReturnCodeFromObject(rc))
++            }
++        }
++        catch (e: Throwable) {
++            MessageCollectorUtil.reportException(messageCollector, e)
++            reportInternalCompilerError(messageCollector)
++        }
++
++    }
++
++    private fun tryCompileWithDaemon(messageCollector: MessageCollector,
++                                     collector: OutputItemsCollector,
++                                     environment: CompilerEnvironment,
++                                     argsArray: Array<String>): Boolean {
++        if (isDaemonEnabled()) {
++            val libPath = CompilerRunnerUtil.getLibPath(environment.kotlinPaths, messageCollector)
++            // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
++            //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
++            val compilerId = CompilerId.makeCompilerId(File(libPath, ""kotlin-compiler.jar""))
++            val daemonOptions = configureDaemonOptions()
++            val daemonJVMOptions = configureDaemonJVMOptions(true)
++
++            val daemonReportMessages = ArrayList<DaemonReportMessage>()
++
++            val daemon = KotlinCompilerClient.connectToCompileService(compilerId, daemonJVMOptions, daemonOptions, DaemonReportingTargets(null, daemonReportMessages), true, true)
++
++            for (msg in daemonReportMessages) {
++                if (msg.category === DaemonReportCategory.EXCEPTION && daemon == null) {
++                    messageCollector.report(CompilerMessageSeverity.INFO,
++                                            ""Falling  back to compilation without daemon due to error: "" + msg.message,
++                                            CompilerMessageLocation.NO_LOCATION)
++                }
++                else {
++                    messageCollector.report(CompilerMessageSeverity.INFO, msg.message, CompilerMessageLocation.NO_LOCATION)
++                }
++            }
++
++            if (daemon != null) {
++                val compilerOut = ByteArrayOutputStream()
++                val daemonOut = ByteArrayOutputStream()
++
++                val services = CompilationServices(
++                        incrementalCompilationComponents = environment.services.get(IncrementalCompilationComponents::class.java),
++                        compilationCanceledStatus = environment.services.get(CompilationCanceledStatus::class.java))
++
++                val res = KotlinCompilerClient.incrementalCompile(daemon, argsArray, services, compilerOut, daemonOut)
++
++                ProcessCompilerOutput(messageCollector, collector, compilerOut, res.toString())
++                BufferedReader(StringReader(daemonOut.toString())).forEachLine {
++                    messageCollector.report(CompilerMessageSeverity.INFO, it, CompilerMessageLocation.NO_LOCATION)
++                }
++                return true
++            }
++        }
++        return false
++    }
++
++    private fun getReturnCodeFromObject(rc: Any?): String {
++        if (rc == null) {
++            return INTERNAL_ERROR
++        }
++        else if (ExitCode::class.java.name == rc.javaClass.name) {
++            return rc.toString()
++        }
++        else {
++            throw IllegalStateException(""Unexpected return: "" + rc)
++        }
++    }
++
++    private fun <T : CommonCompilerArguments> mergeBeans(from: CommonCompilerArguments, to: T): T {
++        // TODO: rewrite when updated version of com.intellij.util.xmlb is available on TeamCity
++        try {
++            val copy = XmlSerializerUtil.createCopy(to)
++
++            val fromFields = collectFieldsToCopy(from.javaClass)
++            for (fromField in fromFields) {
++                val toField = copy.javaClass.getField(fromField.name)
++                toField.set(copy, fromField.get(from))
++            }
++
++            return copy
++        }
++        catch (e: NoSuchFieldException) {
++            throw rethrow(e)
++        }
++        catch (e: IllegalAccessException) {
++            throw rethrow(e)
++        }
++
++    }
++
++    private fun collectFieldsToCopy(clazz: Class<*>): List<Field> {
++        val fromFields = ArrayList<Field>()
++
++        var currentClass: Class<*>? = clazz
++        while (currentClass != null) {
++            for (field in currentClass.declaredFields) {
++                val modifiers = field.modifiers
++                if (!Modifier.isStatic(modifiers) && Modifier.isPublic(modifiers)) {
++                    fromFields.add(field)
++                }
++            }
++            currentClass = currentClass.superclass
++        }
++
++        return fromFields
++    }
++
++    private fun setupK2JvmArguments(moduleFile: File, settings: K2JVMCompilerArguments) {
++        settings.module = moduleFile.absolutePath
++        settings.noStdlib = true
++        settings.noJdkAnnotations = true
++        settings.noJdk = true
++    }
++
++    private fun setupK2JsArguments(
++            outputFile: File,
++            sourceFiles: Collection<File>,
++            libraryFiles: List<String>,
++            settings: K2JSCompilerArguments) {
++        settings.noStdlib = true
++        settings.freeArgs = ContainerUtil.map(sourceFiles, object : Function<File, String> {
++            override fun `fun`(file: File): String {
++                return file.path
++            }
++        })
++        settings.outputFile = outputFile.path
++        settings.metaInfo = true
++        settings.libraryFiles = ArrayUtil.toStringArray(libraryFiles)","`toTypedArray()`
+",2015-09-23 14:45:36
+357,"@@ -0,0 +1,26 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package kotlin.jvm
++
++import java.lang.annotation.Retention
++import java.lang.annotation.RetentionPolicy
++
++/**
++ * Instructs the Kotlin compiler to generate overloads for this function that substitute default parameter values.","Maybe it will be useful to document exactly what overloads are generated here? One might think that `2^n` overloads will be generated, if `n` is the number of default parameters
+",2015-04-01 14:27:42
+701,"@@ -0,0 +1,26 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.descriptors.SourceFile
++import org.jetbrains.kotlin.load.java.sources.JavaSourceElement
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++
++class JavacSourceElement(override val javaElement: JavaElement) : JavaSourceElement {",`JavacBasedSourceElement`?,2017-04-05 12:56:28
+702,"@@ -0,0 +1,26 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.load.java.sources.JavaSourceElementFactory
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++
++class JavacSourceElementFactory : JavaSourceElementFactory {",`JavacBasedSourceElementFactory`?,2017-04-05 12:58:21
+247,"@@ -0,0 +1,26 @@
++import kotlin.test.assertEquals
++
++fun test1() {
++    val u = when (true) {
++        true -> 42
++        else -> 1.0
++    }
++
++    assertEquals(42, u)
++}
++
++fun test2() {
++    val u = 1L.let {
++        when (it) {
++            is Long -> if (it.toLong() == 2L) it.toLong() else it * 2 // CompilationException
++            else -> it.toDouble()
++        }
++    }
++
++    assertEquals(1L, u)
++}
++
++fun box(): String {
++    return ""OK""","what about test1, test2 call?
+",2014-09-24 13:18:33
+405,"@@ -0,0 +1,262 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =","~~Why do we need our own isAlive implementation?~~
+My bad. `Process.isAlive` was introduced in Java 8
+",2015-08-19 22:01:03
+412,"@@ -0,0 +1,262 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)","Will we see black console window on Windows if we start `java.exe`? Shouldn't we run `javaw.exe` instead?
+",2015-08-19 22:42:40
+406,"@@ -0,0 +1,262 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho))
++                                      lock.write { isEchoRead = true; return@forEachLine }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    var waitMillis: Long = DAEMON_STARTUP_TIMEOUT_MS / DAEMON_STARTUP_CHECK_INTERVAL_MS
++                    while (waitMillis-- > 0) {
++                        Thread.sleep(DAEMON_STARTUP_CHECK_INTERVAL_MS)
++                        if (!daemon.isAlive() || lock.read { isEchoRead } == true) break;
++                    }
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (lock.read { isEchoRead } == false)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdouThread.isAlive)","But if it is not then the child process could hang if there are bytes were not consumed: generally it may happen if the child process is trying to write to the pipe but nobody reads it anymore and the pipe internal buffer is full
+",2015-08-19 22:17:44
+407,"@@ -0,0 +1,262 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho))
++                                      lock.write { isEchoRead = true; return@forEachLine }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    var waitMillis: Long = DAEMON_STARTUP_TIMEOUT_MS / DAEMON_STARTUP_CHECK_INTERVAL_MS
++                    while (waitMillis-- > 0) {
++                        Thread.sleep(DAEMON_STARTUP_CHECK_INTERVAL_MS)
++                        if (!daemon.isAlive() || lock.read { isEchoRead } == true) break;
++                    }
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (lock.read { isEchoRead } == false)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdouThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    lock.write { stdouThread.stop() }
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++        }
++
++        public fun connectToCompileService(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
++            val service = connectToService(compilerId, daemonOptions, errStream)
++            if (service != null) {
++                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
++                    errStream.println(""[daemon client] found the suitable daemon"")
++                    return service
++                }
++                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.asParams.joinToString("" ""))
++                if (!autostart) return null;
++                errStream.println(""[daemon client] shutdown the daemon"")
++                service.shutdown()
++                // TODO: find more reliable way","pidfile, some kind of ping, shutdown port?
+",2015-08-19 22:24:10
+408,"@@ -0,0 +1,262 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho))
++                                      lock.write { isEchoRead = true; return@forEachLine }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    var waitMillis: Long = DAEMON_STARTUP_TIMEOUT_MS / DAEMON_STARTUP_CHECK_INTERVAL_MS
++                    while (waitMillis-- > 0) {
++                        Thread.sleep(DAEMON_STARTUP_CHECK_INTERVAL_MS)
++                        if (!daemon.isAlive() || lock.read { isEchoRead } == true) break;
++                    }
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (lock.read { isEchoRead } == false)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdouThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    lock.write { stdouThread.stop() }
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++        }
++
++        public fun connectToCompileService(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
++            val service = connectToService(compilerId, daemonOptions, errStream)
++            if (service != null) {
++                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
++                    errStream.println(""[daemon client] found the suitable daemon"")
++                    return service
++                }
++                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.asParams.joinToString("" ""))
++                if (!autostart) return null;
++                errStream.println(""[daemon client] shutdown the daemon"")
++                service.shutdown()
++                // TODO: find more reliable way
++                Thread.sleep(1000)
++                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++            }
++            else {
++                if (!autostart) return null;
++                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            }
++
++            startDaemon(compilerId, daemonLaunchingOptions, daemonOptions, errStream)
++            errStream.println(""[daemon client] daemon started, trying to connect"")
++            return connectToService(compilerId, daemonOptions, errStream)
++        }
++
++        public fun shutdownCompileService(): Unit {
++            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonLaunchingOptions(), DaemonOptions(), System.out, autostart = false, checkId = false)
++                    ?.shutdown()
++        }
++
++        public fun incrementalCompile(compiler: CompileService, args: Array<String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++            try {
++                caches.forEach { cacheServers.put( it.getKey(), RemoteIncrementalCacheServer( it.getValue())) }
++                val res = compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++                return res
++            }
++            finally {
++                cacheServers.forEach { it.getValue().disconnect() }
++                outStrm.disconnect()
++            }
++        }
++
++        public fun isDaemonEnabled(): Boolean = System.getProperty(COMPILE_DAEMON_ENABLED_PROPERTY) != null
++
++        public fun configureDaemonLaunchingOptions(opts: DaemonLaunchingOptions) {
++            System.getProperty(COMPILE_DAEMON_JVM_OPTIONS_PROPERTY)?.let {
++                // TODO: find better way to pass and parse jvm options for daemon
++                opts.jvmParams = it.split(""##"")
++            }
++        }
++
++        data class ClientOptions(
++                public var stop: Boolean = false
++        ) :CmdlineParams {
++            override val asParams: Iterable<String>
++                get() =
++                    if (stop) listOf(""stop"") else listOf()","listOf() -> emptyList()
+",2015-08-19 22:25:55
+409,"@@ -0,0 +1,262 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho))
++                                      lock.write { isEchoRead = true; return@forEachLine }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    var waitMillis: Long = DAEMON_STARTUP_TIMEOUT_MS / DAEMON_STARTUP_CHECK_INTERVAL_MS
++                    while (waitMillis-- > 0) {
++                        Thread.sleep(DAEMON_STARTUP_CHECK_INTERVAL_MS)
++                        if (!daemon.isAlive() || lock.read { isEchoRead } == true) break;
++                    }
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (lock.read { isEchoRead } == false)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdouThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    lock.write { stdouThread.stop() }
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++        }
++
++        public fun connectToCompileService(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
++            val service = connectToService(compilerId, daemonOptions, errStream)
++            if (service != null) {
++                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
++                    errStream.println(""[daemon client] found the suitable daemon"")
++                    return service
++                }
++                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.asParams.joinToString("" ""))
++                if (!autostart) return null;
++                errStream.println(""[daemon client] shutdown the daemon"")
++                service.shutdown()
++                // TODO: find more reliable way
++                Thread.sleep(1000)
++                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++            }
++            else {
++                if (!autostart) return null;
++                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            }
++
++            startDaemon(compilerId, daemonLaunchingOptions, daemonOptions, errStream)
++            errStream.println(""[daemon client] daemon started, trying to connect"")
++            return connectToService(compilerId, daemonOptions, errStream)
++        }
++
++        public fun shutdownCompileService(): Unit {
++            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonLaunchingOptions(), DaemonOptions(), System.out, autostart = false, checkId = false)
++                    ?.shutdown()
++        }
++
++        public fun incrementalCompile(compiler: CompileService, args: Array<String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++            try {
++                caches.forEach { cacheServers.put( it.getKey(), RemoteIncrementalCacheServer( it.getValue())) }
++                val res = compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++                return res
++            }
++            finally {
++                cacheServers.forEach { it.getValue().disconnect() }
++                outStrm.disconnect()
++            }
++        }
++
++        public fun isDaemonEnabled(): Boolean = System.getProperty(COMPILE_DAEMON_ENABLED_PROPERTY) != null
++
++        public fun configureDaemonLaunchingOptions(opts: DaemonLaunchingOptions) {
++            System.getProperty(COMPILE_DAEMON_JVM_OPTIONS_PROPERTY)?.let {
++                // TODO: find better way to pass and parse jvm options for daemon
++                opts.jvmParams = it.split(""##"")
++            }
++        }
++
++        data class ClientOptions(
++                public var stop: Boolean = false
++        ) :CmdlineParams {
++            override val asParams: Iterable<String>
++                get() =
++                    if (stop) listOf(""stop"") else listOf()
++
++            override val parsers: List<PropParser<*,*,*>>
++                get() = listOf( BoolPropParser(this, ::stop))
++        }
++
++        platformStatic public fun main(vararg args: String) {
++            val compilerId = CompilerId()
++            val daemonOptions = DaemonOptions()
++            val daemonLaunchingOptions = DaemonLaunchingOptions()
++            val clientOptions = ClientOptions()
++            val filteredArgs = args.asIterable().propParseFilter(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions)
++
++            if (!clientOptions.stop) {
++                if (compilerId.compilerClasspath.none()) {
++                    // attempt to find compiler to use
++                    println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
++                    System.getProperty(""java.class.path"")
++                            ?.split(File.pathSeparator)
++                            ?.map { File(it).parent }
++                            ?.distinct()
++                            ?.map {
++                                it?.walk()
++                                        ?.firstOrNull { it.getName().equals(COMPILER_JAR_NAME, ignoreCase = true) }
++                            }
++                            ?.filterNotNull()
++                            ?.firstOrNull()
++                            ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
++                }
++                if (compilerId.compilerClasspath.none())
++                    throw IllegalArgumentException(""Cannot find compiler jar"")
++                else
++                    println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
++
++                compilerId.updateDigest()
++            }
++
++            connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, System.out, autostart = !clientOptions.stop, checkId = !clientOptions.stop)?.let {
++                when {
++                    clientOptions.stop -> {
++                        println(""Shutdown the daemon"")
++                        it.shutdown()
++                        println(""Daemon shut down successfully"")
++                    }
++                    else -> {
++                        println(""Executing daemon compilation with args: "" + filteredArgs.joinToString("" ""))
++                        val outStrm = RemoteOutputStreamServer(System.out)
++                        try {
++                            val memBefore = it.getUsedMemory() / 1024
++                            val startTime = System.nanoTime()
++                            val res = it.remoteCompile(filteredArgs.toArrayList().toTypedArray(), outStrm, CompileService.OutputFormat.PLAIN)
++                            val endTime = System.nanoTime()","We can use kotlin's `measureTimeMillis` or `measureTimeNano`: http://kotlinlang.org/api/latest/jvm/stdlib/kotlin.util/index.html
+",2015-08-19 22:28:46
+465,"@@ -0,0 +1,263 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import kotlin.concurrent.thread
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++                val javaw = File(it, ""javaw.exe"")
++                if (javaw.exists()) javaw
++                else File(it, ""java"")
++            }
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable.absolutePath,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                       compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            var isEchoRead = Semaphore(1)
++            isEchoRead.acquire()
++
++            val stdoutThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
++                                      isEchoRead.release()
++                                      return@forEachLine
++                                  }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (!succeeded)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdoutThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    stdoutThread.stop()
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++        }
++
++        public fun connectToCompileService(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
++            val service = connectToService(compilerId, daemonOptions, errStream)
++            if (service != null) {
++                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
++                    errStream.println(""[daemon client] found the suitable daemon"")
++                    return service
++                }
++                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
++                if (!autostart) return null;
++                errStream.println(""[daemon client] shutdown the daemon"")
++                service.shutdown()
++                // TODO: find more reliable way
++                Thread.sleep(1000)
++                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++            }
++            else {
++                if (!autostart) return null;
++                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            }
++
++            startDaemon(compilerId, daemonJVMOptions, daemonOptions, errStream)
++            errStream.println(""[daemon client] daemon started, trying to connect"")
++            return connectToService(compilerId, daemonOptions, errStream)
++        }
++
++        public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
++            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, System.out, autostart = false, checkId = false)
++                    ?.shutdown()
++        }
++
++        public fun shutdownCompileService(): Unit {
++            shutdownCompileService(DaemonOptions())
++        }
++
++        public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            try {
++                return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN)
++            }
++            finally {
++                outStrm.disconnect()
++            }
++        }
++
++        public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++            try {
++                caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer( it.getValue()) })
++                return compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++            }
++            finally {
++                cacheServers.forEach { it.getValue().disconnect() }
++                outStrm.disconnect()
++            }
++        }
++
++        data class ClientOptions(
++                public var stop: Boolean = false
++        ) : OptionsGroup {
++            override val mappers: List<PropMapper<*, *, *>>
++                get() = listOf( BoolPropMapper(this, ::stop))
++        }
++
++        jvmStatic public fun main(vararg args: String) {
++            val compilerId = CompilerId()
++            val daemonOptions = DaemonOptions()
++            val daemonLaunchingOptions = DaemonJVMOptions()
++            val clientOptions = ClientOptions()
++            val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
++
++            if (!clientOptions.stop) {
++                if (compilerId.compilerClasspath.none()) {
++                    // attempt to find compiler to use
++                    println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")","Why are you printing this & other information to stdout, not stderr?
+",2015-09-01 07:29:59
+964,"@@ -0,0 +1,27 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.structure
++
++interface ESEffect {
++    /**
++     * Returns:
++     *  - true, when presence of `this`-effect necessary implies presence of `other`-effect
++     *  - false, when presence of `this`-effect necessary implies absence of `other`-effect
++     *  - null, when presence of `this`-effect doesn't implies neither presence nor absence of `other`-effect
++     */
++    fun isImplies(other: ESEffect): Boolean?",It's matter of taste but I'd use here some enum with three elements,2017-08-15 15:35:58
+430,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1","Try to run optimize imports and reformat
+",2015-08-24 12:14:46
+428,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {","Looks like it should be object
+",2015-08-24 12:02:18
+432,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L","private?
+",2015-08-24 12:22:32
+431,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {","we prefer to first declare a public API
+",2015-08-24 12:22:20
+433,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running","minor: I'd inline `connectToDaemon`
+",2015-08-24 12:23:10
+429,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:","Why ClassCastException is not enough here?
+",2015-08-24 12:08:31
+434,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)","We prefer to use braces in `if` except one-line ifs: `if (cond) return/break/continue`
+",2015-08-24 12:50:33
+435,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++                val javaw = File(it, ""javaw.exe"")
++                if (javaw.exists()) javaw
++                else File(it, ""java"")
++            }
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable.absolutePath,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.extractors.flatMap { it.extract(""-"") } +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.extractors.flatMap { it.extract(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                       compilerId.extractors.flatMap { it.extract(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            var isEchoRead = Semaphore(1)
++            isEchoRead.acquire()
++
++            val stdoutThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
++                                      isEchoRead.release()
++                                      return@forEachLine
++                                  }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (!succeeded)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else","braces
+",2015-08-24 12:53:32
+457,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++                val javaw = File(it, ""javaw.exe"")
++                if (javaw.exists()) javaw
++                else File(it, ""java"")
++            }
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable.absolutePath,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.extractors.flatMap { it.extract(""-"") } +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.extractors.flatMap { it.extract(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                       compilerId.extractors.flatMap { it.extract(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            var isEchoRead = Semaphore(1)
++            isEchoRead.acquire()
++
++            val stdoutThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
++                                      isEchoRead.release()
++                                      return@forEachLine
++                                  }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (!succeeded)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdoutThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    stdoutThread.stop()
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&","why we skip empty parameters?
+",2015-08-26 20:31:57
+458,"@@ -0,0 +1,271 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.Semaphore
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++import kotlin.reflect.KProperty1
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++                val javaw = File(it, ""javaw.exe"")
++                if (javaw.exists()) javaw
++                else File(it, ""java"")
++            }
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable.absolutePath,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.extractors.flatMap { it.extract(""-"") } +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.extractors.flatMap { it.extract(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                       compilerId.extractors.flatMap { it.extract(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            var isEchoRead = Semaphore(1)
++            isEchoRead.acquire()
++
++            val stdoutThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
++                                      isEchoRead.release()
++                                      return@forEachLine
++                                  }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (!succeeded)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdoutThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    stdoutThread.stop()
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&","`containsAll`
+",2015-08-26 20:32:41
+436,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)","i'd just add default value for `name` to primary constructor
+",2015-08-25 12:24:13
+439,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()","we can get list with string which ends with ""null"" and `filterNotNull` is unnecessary here
+",2015-08-25 13:34:27
+446,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {","I think we need better name for this function
+",2015-08-25 18:00:38
+444,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->","I think it'll be simpler if rewrite with `while`
+",2015-08-25 17:06:36
+443,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }","replace `;` with `\n`
+",2015-08-25 16:31:24
+445,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true","please don't mix blocks with and without braces
+",2015-08-25 17:07:21
+448,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {","minor: I don't like `Cmdline`
+",2015-08-25 18:15:36
+455,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>","I think these properties should not be part of public api
+",2015-08-26 17:24:49
+447,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =","what is cs?
+",2015-08-25 18:03:11
+456,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",","I don't like public vars and public constructor in inheritors of CmdlineParams
+",2015-08-26 18:59:17
+441,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),","I'd extract `{ it.isEmpty() }` to constant
+",2015-08-25 15:21:39
+442,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),","i'd extract `{ it }` or use `identity()` from `core/util.runtime/src/org/jetbrains/kotlin/utils/functions.kt`
+",2015-08-25 15:23:25
+440,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),","Should `allowMergedArg` be false here?
+",2015-08-25 15:20:54
+449,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),
++                        PropParser(this, ::reservedCodeCacheSize, listOf(""XX:ReservedCodeCacheSize""), { it }, allowMergedArg = true))
++                        // otherJvmParams is missing here deliberately, it is used explicitly as a restParser param to filterSetProps
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,","I'd toggle case of `s` or drop `auto` prefix
+",2015-08-25 19:22:38
+450,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),
++                        PropParser(this, ::reservedCodeCacheSize, listOf(""XX:ReservedCodeCacheSize""), { it }, allowMergedArg = true))
++                        // otherJvmParams is missing here deliberately, it is used explicitly as a restParser param to filterSetProps
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::port),
++                        PropExtractor(this, ::autoshutdownMemoryThreshold, skipIf = { it == 0L }),
++                        PropExtractor(this, ::autoshutdownIdleSeconds, skipIf = { it == 0 }),
++                        PropExtractor(this, ::startEcho))
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""","private?
+",2015-08-25 19:27:21
+451,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),
++                        PropParser(this, ::reservedCodeCacheSize, listOf(""XX:ReservedCodeCacheSize""), { it }, allowMergedArg = true))
++                        // otherJvmParams is missing here deliberately, it is used explicitly as a restParser param to filterSetProps
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::port),
++                        PropExtractor(this, ::autoshutdownMemoryThreshold, skipIf = { it == 0L }),
++                        PropExtractor(this, ::autoshutdownIdleSeconds, skipIf = { it == 0 }),
++                        PropExtractor(this, ::startEcho))
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++
++fun updateSingleFileDigest(file: File, md: MessageDigest) {","private?
+",2015-08-26 13:42:48
+452,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),
++                        PropParser(this, ::reservedCodeCacheSize, listOf(""XX:ReservedCodeCacheSize""), { it }, allowMergedArg = true))
++                        // otherJvmParams is missing here deliberately, it is used explicitly as a restParser param to filterSetProps
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::port),
++                        PropExtractor(this, ::autoshutdownMemoryThreshold, skipIf = { it == 0L }),
++                        PropExtractor(this, ::autoshutdownIdleSeconds, skipIf = { it == 0 }),
++                        PropExtractor(this, ::startEcho))
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++
++fun updateSingleFileDigest(file: File, md: MessageDigest) {
++    DigestInputStream(file.inputStream(), md).use {
++        val buf = ByteArray(1024)
++        while (it.read(buf) != -1) { }
++        it.close()
++    }
++}
++
++fun updateForAllClasses(dir: File, md: MessageDigest) {
++    dir.walk().forEach { updateEntryDigest(it, md) }
++}
++
++fun updateEntryDigest(entry: File, md: MessageDigest) {
++    when {
++        entry.isDirectory
++            -> updateForAllClasses(entry, md)
++        entry.isFile &&
++                (entry.getName().endsWith("".class"", ignoreCase = true) ||","`getName()` can be replaces with `name`
+",2015-08-26 14:42:30
+453,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),
++                        PropParser(this, ::reservedCodeCacheSize, listOf(""XX:ReservedCodeCacheSize""), { it }, allowMergedArg = true))
++                        // otherJvmParams is missing here deliberately, it is used explicitly as a restParser param to filterSetProps
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::port),
++                        PropExtractor(this, ::autoshutdownMemoryThreshold, skipIf = { it == 0L }),
++                        PropExtractor(this, ::autoshutdownIdleSeconds, skipIf = { it == 0 }),
++                        PropExtractor(this, ::startEcho))
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++
++fun updateSingleFileDigest(file: File, md: MessageDigest) {
++    DigestInputStream(file.inputStream(), md).use {
++        val buf = ByteArray(1024)
++        while (it.read(buf) != -1) { }
++        it.close()
++    }
++}
++
++fun updateForAllClasses(dir: File, md: MessageDigest) {
++    dir.walk().forEach { updateEntryDigest(it, md) }
++}
++
++fun updateEntryDigest(entry: File, md: MessageDigest) {
++    when {
++        entry.isDirectory
++            -> updateForAllClasses(entry, md)
++        entry.isFile &&
++                (entry.getName().endsWith("".class"", ignoreCase = true) ||
++                entry.getName().endsWith("".jar"", ignoreCase = true))
++            -> updateSingleFileDigest(entry, md)
++        // else skip
++    }
++}
++
++fun Iterable<File>.getFilesClasspathDigest(): String {
++    val md = MessageDigest.getInstance(COMPILER_ID_DIGEST)
++    this.forEach { updateEntryDigest(it, md) }
++    return md.digest().joinToString("""", transform = { ""%02x"".format(it) })
++}
++
++fun Iterable<String>.getClasspathDigest(): String = map { File(it) }.getFilesClasspathDigest()
++
++
++public data class CompilerId(
++        public var compilerClasspath: List<String> = listOf(),
++        public var compilerDigest: String = """",
++        public var compilerVersion: String = """"
++        // TODO: checksum
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::compilerClasspath, convert = { it.joinToString(File.pathSeparator) }),
++                        PropExtractor(this, ::compilerDigest),
++                        PropExtractor(this, ::compilerVersion, skipIf = { it.isEmpty() }))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() =
++            listOf( PropParser(this, ::compilerClasspath, { it.trim('""').split(File.pathSeparator)}),
++                    PropParser(this, ::compilerDigest, { it.trim('""') }),
++                    PropParser(this, ::compilerVersion, { it.trim('""') }))
++
++    public fun updateDigest() {
++        compilerDigest = compilerClasspath.getClasspathDigest()
++    }
++
++    companion object {
++        public platformStatic fun makeCompilerId(vararg paths: File): CompilerId = makeCompilerId(paths.asIterable())","`platformStatic` deprecated now
+",2015-08-26 16:33:29
+454,"@@ -0,0 +1,272 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.platform.platformStatic
++import kotlin.reflect.KMutableProperty1
++import kotlin.reflect.KProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++
++
++open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++                                                    val prop: P,
++                                                    val name: String,
++                                                    val convert: ((v: V) -> String?) = { it.toString() },
++                                                    val skipIf: ((v: V) -> Boolean) = { false },
++                                                    val mergeWithDelimiter: String? = null)
++{
++    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++            }
++}
++
++class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++}
++
++
++open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P, alternativeNames: List<String>,
++                                                        val parse: (s: String) -> V,
++                                                        val allowMergedArg: Boolean = false) {
++    val names = listOf(prop.name) + alternativeNames
++    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++    fun apply(s: String) = prop.set(dest, parse(s))
++}
++
++class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++
++class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++
++fun Iterable<String>.filterSetProps(parsers: List<PropParser<*,*,*>>, prefix: String, restParser: RestPropParser<*,*>? = null) : Iterable<String>  {
++    var currentParser: PropParser<*,*,*>? = null
++    var matchingOption = """"
++    val res = filter { param ->
++        if (currentParser == null) {
++            val parser = parsers.find { it.names.any { name ->
++                if (param.startsWith(prefix + name)) { matchingOption = prefix + name; true }
++                else false } }
++            if (parser != null) {
++                val optionLength = matchingOption.length()
++                when {
++                    parser is BoolPropParser<*,*> ->
++                        if (param.length() > optionLength) throw IllegalArgumentException(""Invalid switch option '$param', expecting $matchingOption without arguments"")
++                        else parser.apply("""")
++                    param.length() > optionLength ->
++                        if (param[optionLength] != '=') {
++                            if (parser.allowMergedArg) parser.apply(param.substring(optionLength))
++                            else throw IllegalArgumentException(""Invalid option syntax '$param', expecting $matchingOption[= ]<arg>"")
++                        }
++                        else parser.apply(param.substring(optionLength + 1))
++                    else -> currentParser = parser
++                }
++                false
++            }
++            else if (restParser != null && param.startsWith(prefix)) {
++                restParser.add(param.removePrefix(prefix))
++                false
++            }
++            else true
++        }
++        else {
++            currentParser!!.apply(param)
++            currentParser = null
++            false
++        }
++    }
++    if (currentParser != null) throw IllegalArgumentException(""Expecting argument for the option $matchingOption"")
++    return res
++}
++
++// TODO: find out how to create more generic variant using first constructor
++//fun<C> C.propsToParams() {
++//    val kc = C::class
++//    kc.constructors.first().
++//}
++
++
++
++public interface CmdlineParams : Serializable {
++    public val extractors: List<PropExtractor<*,*,*>>
++    public val parsers: List<PropParser<*,*,*>>
++}
++
++public fun Iterable<String>.filterSetProps(vararg cs: CmdlineParams, prefix: String) : Iterable<String> =
++    filterSetProps(cs.flatMap { it.parsers }, prefix)
++
++
++public data class DaemonLaunchingOptions(
++        public var maxMemory: String = """",
++        public var maxPermSize: String = """",
++        public var reservedCodeCacheSize: String = """",
++        public var otherJvmParams: MutableCollection<String> = arrayListOf()
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*,*,*>>
++        get() = listOf( PropExtractor(this, ::maxMemory, ""Xmx"", skipIf = { it.isEmpty() }, mergeWithDelimiter = """"),
++                        PropExtractor(this, ::maxPermSize, ""XX:MaxPermSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        PropExtractor(this, ::reservedCodeCacheSize, ""XX:ReservedCodeCacheSize"", skipIf = { it.isEmpty() }, mergeWithDelimiter = ""=""),
++                        RestPropExtractor(this, ::otherJvmParams))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() = listOf( PropParser(this, ::maxMemory, listOf(""Xmx""), { it }, allowMergedArg = true),
++                        PropParser(this, ::maxPermSize, listOf(""XX:MaxPermSize""), { it }, allowMergedArg = true),
++                        PropParser(this, ::reservedCodeCacheSize, listOf(""XX:ReservedCodeCacheSize""), { it }, allowMergedArg = true))
++                        // otherJvmParams is missing here deliberately, it is used explicitly as a restParser param to filterSetProps
++}
++
++public data class DaemonOptions(
++        public var port: Int = COMPILE_DAEMON_DEFAULT_PORT,
++        public var autoshutdownMemoryThreshold: Long = 0 /* 0 means unchecked */,
++        public var autoshutdownIdleSeconds: Int = 0 /* 0 means unchecked */,
++        public var startEcho: String = COMPILER_SERVICE_RMI_NAME
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::port),
++                        PropExtractor(this, ::autoshutdownMemoryThreshold, skipIf = { it == 0L }),
++                        PropExtractor(this, ::autoshutdownIdleSeconds, skipIf = { it == 0 }),
++                        PropExtractor(this, ::startEcho))
++
++    override val parsers: List<PropParser<*,*,*>>
++            get() = listOf( PropParser(this, ::port, { it.toInt()}),
++                            PropParser(this, ::autoshutdownMemoryThreshold, { it.toLong()}),
++                            PropParser(this, ::autoshutdownIdleSeconds, { it.toInt()}),
++                            PropParser(this, ::startEcho, { it.trim('""') }))
++}
++
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++
++fun updateSingleFileDigest(file: File, md: MessageDigest) {
++    DigestInputStream(file.inputStream(), md).use {
++        val buf = ByteArray(1024)
++        while (it.read(buf) != -1) { }
++        it.close()
++    }
++}
++
++fun updateForAllClasses(dir: File, md: MessageDigest) {
++    dir.walk().forEach { updateEntryDigest(it, md) }
++}
++
++fun updateEntryDigest(entry: File, md: MessageDigest) {
++    when {
++        entry.isDirectory
++            -> updateForAllClasses(entry, md)
++        entry.isFile &&
++                (entry.getName().endsWith("".class"", ignoreCase = true) ||
++                entry.getName().endsWith("".jar"", ignoreCase = true))
++            -> updateSingleFileDigest(entry, md)
++        // else skip
++    }
++}
++
++fun Iterable<File>.getFilesClasspathDigest(): String {
++    val md = MessageDigest.getInstance(COMPILER_ID_DIGEST)
++    this.forEach { updateEntryDigest(it, md) }
++    return md.digest().joinToString("""", transform = { ""%02x"".format(it) })
++}
++
++fun Iterable<String>.getClasspathDigest(): String = map { File(it) }.getFilesClasspathDigest()
++
++
++public data class CompilerId(
++        public var compilerClasspath: List<String> = listOf(),
++        public var compilerDigest: String = """",
++        public var compilerVersion: String = """"
++        // TODO: checksum
++) : CmdlineParams {
++
++    override val extractors: List<PropExtractor<*, *, *>>
++        get() = listOf( PropExtractor(this, ::compilerClasspath, convert = { it.joinToString(File.pathSeparator) }),
++                        PropExtractor(this, ::compilerDigest),
++                        PropExtractor(this, ::compilerVersion, skipIf = { it.isEmpty() }))
++
++    override val parsers: List<PropParser<*,*,*>>
++        get() =
++            listOf( PropParser(this, ::compilerClasspath, { it.trim('""').split(File.pathSeparator)}),
++                    PropParser(this, ::compilerDigest, { it.trim('""') }),
++                    PropParser(this, ::compilerVersion, { it.trim('""') }))
++
++    public fun updateDigest() {
++        compilerDigest = compilerClasspath.getClasspathDigest()
++    }
++
++    companion object {
++        public platformStatic fun makeCompilerId(vararg paths: File): CompilerId = makeCompilerId(paths.asIterable())
++
++        public platformStatic fun makeCompilerId(paths: Iterable<File>): CompilerId =","it has only one usage
+",2015-08-26 16:37:19
+414,"@@ -0,0 +1,276 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false","Would be simpler to use an AtomicBoolean here. Or better yet, a semaphore, in which case you won't need a wait loop.
+",2015-08-20 13:16:24
+413,"@@ -0,0 +1,276 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =","typo: stdoutThread
+",2015-08-20 13:14:33
+415,"@@ -0,0 +1,276 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho))
++                                      lock.write { isEchoRead = true; return@forEachLine }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    var waitMillis: Long = DAEMON_STARTUP_TIMEOUT_MS / DAEMON_STARTUP_CHECK_INTERVAL_MS
++                    while (waitMillis-- > 0) {
++                        Thread.sleep(DAEMON_STARTUP_CHECK_INTERVAL_MS)
++                        if (!daemon.isAlive() || lock.read { isEchoRead } == true) break;
++                    }
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (lock.read { isEchoRead } == false)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdouThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    lock.write { stdouThread.stop() }
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++        }
++
++        public fun connectToCompileService(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
++            val service = connectToService(compilerId, daemonOptions, errStream)
++            if (service != null) {
++                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
++                    errStream.println(""[daemon client] found the suitable daemon"")
++                    return service
++                }
++                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.asParams.joinToString("" ""))
++                if (!autostart) return null;
++                errStream.println(""[daemon client] shutdown the daemon"")
++                service.shutdown()
++                // TODO: find more reliable way
++                Thread.sleep(1000)
++                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++            }
++            else {
++                if (!autostart) return null;
++                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            }
++
++            startDaemon(compilerId, daemonLaunchingOptions, daemonOptions, errStream)
++            errStream.println(""[daemon client] daemon started, trying to connect"")
++            return connectToService(compilerId, daemonOptions, errStream)
++        }
++
++        public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
++            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonLaunchingOptions(), daemonOptions, System.out, autostart = false, checkId = false)
++                    ?.shutdown()
++        }
++
++        public fun shutdownCompileService(): Unit {
++            shutdownCompileService(DaemonOptions())
++        }
++
++        public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            try {
++                return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN)
++            }
++            finally {
++                outStrm.disconnect()
++            }
++        }
++
++        public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++            try {
++                caches.forEach { cacheServers.put( it.getKey(), RemoteIncrementalCacheServer( it.getValue())) }","`mapValues()`
+",2015-08-20 13:31:40
+416,"@@ -0,0 +1,276 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
++import org.jetbrains.kotlin.rmi.*
++import java.io.File
++import java.io.OutputStream
++import java.io.PrintStream
++import java.rmi.ConnectException
++import java.rmi.Remote
++import java.rmi.registry.LocateRegistry
++import java.util.concurrent.TimeUnit
++import java.util.concurrent.locks.ReentrantReadWriteLock
++import kotlin.concurrent.read
++import kotlin.concurrent.thread
++import kotlin.concurrent.write
++import kotlin.platform.platformStatic
++
++fun Process.isAlive() =
++        try {
++            this.exitValue()
++            false
++        }
++        catch (e: IllegalThreadStateException) {
++            true
++        }
++
++public class KotlinCompilerClient {
++
++    companion object {
++
++        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
++        val DAEMON_STARTUP_CHECK_INTERVAL_MS = 100L
++
++        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++
++            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
++            return compilerObj as? CompileService ?:
++                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++        }
++
++        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
++            try {
++                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
++                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
++                if (daemon != null)
++                    return daemon
++                errStream.println(""[daemon client] daemon not found"")
++            }
++            catch (e: ConnectException) {
++                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++                // ignoring it - processing below
++            }
++            return null
++        }
++
++
++        private fun startDaemon(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
++            val javaExecutable = listOf(System.getProperty(""java.home""), ""bin"", ""java"").joinToString(File.separator)
++            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
++            val args = listOf(javaExecutable,
++                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                       daemonLaunchingOptions.jvmParams +
++                       COMPILER_DAEMON_CLASS_FQN +
++                       daemonOptions.asParams +
++                       compilerId.asParams
++            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
++            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++            val daemon = processBuilder.start()
++
++            val lock = ReentrantReadWriteLock()
++            var isEchoRead = false
++
++            val stdouThread =
++                    thread {
++                        daemon.getInputStream()
++                              .reader()
++                              .forEachLine {
++                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho))
++                                      lock.write { isEchoRead = true; return@forEachLine }
++                                  errStream.println(""[daemon] "" + it)
++                              }
++                    }
++            try {
++                // trying to wait for process
++                if (daemonOptions.startEcho.isNotEmpty()) {
++                    errStream.println(""[daemon client] waiting for daemon to respond"")
++                    var waitMillis: Long = DAEMON_STARTUP_TIMEOUT_MS / DAEMON_STARTUP_CHECK_INTERVAL_MS
++                    while (waitMillis-- > 0) {
++                        Thread.sleep(DAEMON_STARTUP_CHECK_INTERVAL_MS)
++                        if (!daemon.isAlive() || lock.read { isEchoRead } == true) break;
++                    }
++                    if (!daemon.isAlive())
++                        throw Exception(""Daemon terminated unexpectedly"")
++                    if (lock.read { isEchoRead } == false)
++                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
++                }
++                else
++                // without startEcho defined waiting for max timeout
++                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
++            }
++            finally {
++                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++                if (stdouThread.isAlive)
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                    lock.write { stdouThread.stop() }
++            }
++        }
++
++        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
++            val remoteId = compiler.getCompilerId()
++            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
++            errStream.println(""[daemon client] localId = "" + localId.toString())
++            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++        }
++
++        public fun connectToCompileService(compilerId: CompilerId, daemonLaunchingOptions: DaemonLaunchingOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
++            val service = connectToService(compilerId, daemonOptions, errStream)
++            if (service != null) {
++                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
++                    errStream.println(""[daemon client] found the suitable daemon"")
++                    return service
++                }
++                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.asParams.joinToString("" ""))
++                if (!autostart) return null;
++                errStream.println(""[daemon client] shutdown the daemon"")
++                service.shutdown()
++                // TODO: find more reliable way
++                Thread.sleep(1000)
++                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++            }
++            else {
++                if (!autostart) return null;
++                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            }
++
++            startDaemon(compilerId, daemonLaunchingOptions, daemonOptions, errStream)
++            errStream.println(""[daemon client] daemon started, trying to connect"")
++            return connectToService(compilerId, daemonOptions, errStream)
++        }
++
++        public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
++            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonLaunchingOptions(), daemonOptions, System.out, autostart = false, checkId = false)
++                    ?.shutdown()
++        }
++
++        public fun shutdownCompileService(): Unit {
++            shutdownCompileService(DaemonOptions())
++        }
++
++        public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            try {
++                return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN)
++            }
++            finally {
++                outStrm.disconnect()
++            }
++        }
++
++        public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++
++            val outStrm = RemoteOutputStreamServer(out)
++            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++            try {
++                caches.forEach { cacheServers.put( it.getKey(), RemoteIncrementalCacheServer( it.getValue())) }
++                return compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++            }
++            finally {
++                cacheServers.forEach { it.getValue().disconnect() }
++                outStrm.disconnect()
++            }
++        }
++
++        public fun isDaemonEnabled(): Boolean = System.getProperty(COMPILE_DAEMON_ENABLED_PROPERTY) != null
++
++        public fun configureDaemonLaunchingOptions(opts: DaemonLaunchingOptions) {
++            System.getProperty(COMPILE_DAEMON_JVM_OPTIONS_PROPERTY)?.let {
++                // TODO: find better way to pass and parse jvm options for daemon
++                opts.jvmParams = it.split(""##"")
++            }
++        }
++
++        data class ClientOptions(
++                public var stop: Boolean = false
++        ) :CmdlineParams {
++            override val asParams: Iterable<String>
++                get() =
++                    if (stop) listOf(""stop"") else listOf()
++
++            override val parsers: List<PropParser<*,*,*>>
++                get() = listOf( BoolPropParser(this, ::stop))
++        }
++
++        platformStatic public fun main(vararg args: String) {
++            val compilerId = CompilerId()
++            val daemonOptions = DaemonOptions()
++            val daemonLaunchingOptions = DaemonLaunchingOptions()
++            val clientOptions = ClientOptions()
++            val filteredArgs = args.asIterable().propParseFilter(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions)
++
++            if (!clientOptions.stop) {
++                if (compilerId.compilerClasspath.none()) {
++                    // attempt to find compiler to use
++                    println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
++                    System.getProperty(""java.class.path"")
++                            ?.split(File.pathSeparator)
++                            ?.map { File(it).parent }
++                            ?.distinct()
++                            ?.map {
++                                it?.walk()
++                                        ?.firstOrNull { it.getName().equals(COMPILER_JAR_NAME, ignoreCase = true) }
++                            }
++                            ?.filterNotNull()
++                            ?.firstOrNull()
++                            ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
++                }
++                if (compilerId.compilerClasspath.none())
++                    throw IllegalArgumentException(""Cannot find compiler jar"")
++                else
++                    println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
++
++                compilerId.updateDigest()
++            }
++
++            connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, System.out, autostart = !clientOptions.stop, checkId = !clientOptions.stop)?.let {
++                when {
++                    clientOptions.stop -> {
++                        println(""Shutdown the daemon"")
++                        it.shutdown()
++                        println(""Daemon shut down successfully"")
++                    }
++                    else -> {
++                        println(""Executing daemon compilation with args: "" + filteredArgs.joinToString("" ""))
++                        val outStrm = RemoteOutputStreamServer(System.out)
++                        try {
++                            val memBefore = it.getUsedMemory() / 1024
++                            val startTime = System.nanoTime()
++                            val res = it.remoteCompile(filteredArgs.toArrayList().toTypedArray(), outStrm, CompileService.OutputFormat.PLAIN)
++                            val endTime = System.nanoTime()
++                            println(""Compilation result code: $res"")
++                            val memAfter = it.getUsedMemory() / 1024
++                            println(""Compilation time: "" + TimeUnit.NANOSECONDS.toMillis(endTime - startTime) + "" ms"")
++                            println(""Used memory $memAfter (${""%+d"".format(memAfter - memBefore)} kb)"")
++                        }
++                        finally {
++                            outStrm.disconnect()
++                        }
++                    }
++                }
++            }
++            ?: if (clientOptions.stop) println(""No daemon found to shut down"")","I think that such dangling `?:` are fairly hard to understand.
+",2015-08-20 13:32:55
+610,"@@ -0,0 +1,278 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.caches
++
++import com.intellij.openapi.projectRoots.Sdk
++import com.intellij.psi.PsiField
++import com.intellij.psi.PsiMethod
++import com.intellij.psi.PsiModifier
++import com.intellij.psi.search.GlobalSearchScope
++import com.intellij.psi.search.PsiShortNamesCache
++import com.sun.tools.javac.util.Convert.shortName
++import junit.framework.TestCase
++import org.jetbrains.kotlin.asJava.elements.KtLightField
++import org.jetbrains.kotlin.asJava.elements.KtLightMethod
++import org.jetbrains.kotlin.idea.refactoring.fqName.getKotlinFqName
++import org.jetbrains.kotlin.idea.test.ConfigLibraryUtil
++import org.jetbrains.kotlin.idea.test.KotlinCodeInsightTestCase
++import org.jetbrains.kotlin.idea.test.PluginTestCaseBase
++import org.jetbrains.kotlin.load.java.JvmAbi
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.KtProperty
++import org.jetbrains.kotlin.test.KotlinTestUtils
++
++
++/**","Please remove this comment
+",2016-09-19 15:25:37
+671,"@@ -0,0 +1,278 @@
++package kotlin.collections
++
++/**
++ * Represents a source of elements with a [keyOf] function, which can be applied to each element to get its key.
++ *
++ * A [Grouping] structure serves as an intermediate step in group-and-fold operations:
++ * they group elements by their keys and then fold each group with some aggregating operation.
++ *
++ * It is created by attaching `keySelector: (T) -> K` function to a source of elements.
++ * To get an instance of [Grouping] use one of `groupingBy` extension functions:
++ * - [Iterable.groupingBy]
++ * - [Sequence.groupingBy]
++ * - [Array.groupingBy]
++ * - [CharSequence.groupingBy]
++ *
++ * For the list of group-and-fold operations available, see the [extension functions](#extension-functions) for `Grouping`.
++ */
++@SinceKotlin(""1.1"")
++public interface Grouping<T, out K> {
++    /** Returns an [Iterator] which iterates through the elements of the source. */
++    fun elementIterator(): Iterator<T>","@{18f15b45-4413-42a3-82e7-d057983d1e65,Ilya Gorbunov} `sourceIterator()` or just `source()` ? Need to be documented: whether it creates iterator every time or keep the same instance. If the behaviour is undefined we have to notice it here.",2016-12-29 12:11:45
+672,"@@ -0,0 +1,278 @@
++package kotlin.collections
++
++/**
++ * Represents a source of elements with a [keyOf] function, which can be applied to each element to get its key.
++ *
++ * A [Grouping] structure serves as an intermediate step in group-and-fold operations:
++ * they group elements by their keys and then fold each group with some aggregating operation.
++ *
++ * It is created by attaching `keySelector: (T) -> K` function to a source of elements.
++ * To get an instance of [Grouping] use one of `groupingBy` extension functions:
++ * - [Iterable.groupingBy]
++ * - [Sequence.groupingBy]
++ * - [Array.groupingBy]
++ * - [CharSequence.groupingBy]
++ *
++ * For the list of group-and-fold operations available, see the [extension functions](#extension-functions) for `Grouping`.
++ */
++@SinceKotlin(""1.1"")
++public interface Grouping<T, out K> {
++    /** Returns an [Iterator] which iterates through the elements of the source. */
++    fun elementIterator(): Iterator<T>
++    /** Extracts the key of an [element]. */
++    fun keyOf(element: T): K
++}
++
++/**
++ * Groups elements from the [Grouping] source by key and aggregates elements of each group with the specified [operation].
++ *
++ * The key for each element is provided by the [Grouping.keyOf] function.
++ *
++ * @param operation function is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `value`: the current value of the accumulator of a group, can be `null` if it's first `element` encountered in the group;
++ *  - `element`: the element from the source being aggregated;
++ *  - `first`: indicates whether it's first `element` encountered in the group.
++ *
++ * @return a [Map] associating the key of each group with the result of aggregation of the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R> Grouping<T, K>.aggregate(
++        operation: (key: K, value: R?, element: T, first: Boolean) -> R
++): Map<K, R> {
++    val result = mutableMapOf<K, R>()",Why don't we use `aggregateTo` instead?,2016-12-29 12:15:55
+673,"@@ -0,0 +1,278 @@
++package kotlin.collections
++
++/**
++ * Represents a source of elements with a [keyOf] function, which can be applied to each element to get its key.
++ *
++ * A [Grouping] structure serves as an intermediate step in group-and-fold operations:
++ * they group elements by their keys and then fold each group with some aggregating operation.
++ *
++ * It is created by attaching `keySelector: (T) -> K` function to a source of elements.
++ * To get an instance of [Grouping] use one of `groupingBy` extension functions:
++ * - [Iterable.groupingBy]
++ * - [Sequence.groupingBy]
++ * - [Array.groupingBy]
++ * - [CharSequence.groupingBy]
++ *
++ * For the list of group-and-fold operations available, see the [extension functions](#extension-functions) for `Grouping`.
++ */
++@SinceKotlin(""1.1"")
++public interface Grouping<T, out K> {
++    /** Returns an [Iterator] which iterates through the elements of the source. */
++    fun elementIterator(): Iterator<T>
++    /** Extracts the key of an [element]. */
++    fun keyOf(element: T): K
++}
++
++/**
++ * Groups elements from the [Grouping] source by key and aggregates elements of each group with the specified [operation].
++ *
++ * The key for each element is provided by the [Grouping.keyOf] function.
++ *
++ * @param operation function is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `value`: the current value of the accumulator of a group, can be `null` if it's first `element` encountered in the group;
++ *  - `element`: the element from the source being aggregated;
++ *  - `first`: indicates whether it's first `element` encountered in the group.
++ *
++ * @return a [Map] associating the key of each group with the result of aggregation of the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R> Grouping<T, K>.aggregate(
++        operation: (key: K, value: R?, element: T, first: Boolean) -> R
++): Map<K, R> {
++    val result = mutableMapOf<K, R>()
++    for (e in this.elementIterator()) {
++        val key = keyOf(e)
++        val value = result[key]
++        result[key] = operation(key, value, e, value == null && !result.containsKey(key))
++    }
++    return result
++}
++
++/**
++ * Groups elements from the [Grouping] source by key and aggregates elements of each group with the specified [operation]
++ * to the given [destination] map.
++ *
++ * The key for each element is provided by the [Grouping.keyOf] function.
++ *
++ * @param operation a function that is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `accumulator`: the current value of the accumulator of the group, can be `null` if it's first `element` encountered in the group;
++ *  - `element`: the element from the source being aggregated;
++ *  - `first`: indicates whether it's first `element` encountered in the group.
++ *
++ * If the [destination] map already has a value corresponding to some key,
++ * then the elements being aggregated for that key are never considered as `first`.
++ *
++ * @return the [destination] map associating the key of each group with the result of aggregation of the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R, M : MutableMap<in K, R>> Grouping<T, K>.aggregateTo(
++        destination: M,
++        operation: (key: K, accumulator: R?, element: T, first: Boolean) -> R","`value` vs `accumulator`, `v` vs `acc`",2016-12-29 12:16:41
+674,"@@ -0,0 +1,278 @@
++package kotlin.collections
++
++/**
++ * Represents a source of elements with a [keyOf] function, which can be applied to each element to get its key.
++ *
++ * A [Grouping] structure serves as an intermediate step in group-and-fold operations:
++ * they group elements by their keys and then fold each group with some aggregating operation.
++ *
++ * It is created by attaching `keySelector: (T) -> K` function to a source of elements.
++ * To get an instance of [Grouping] use one of `groupingBy` extension functions:
++ * - [Iterable.groupingBy]
++ * - [Sequence.groupingBy]
++ * - [Array.groupingBy]
++ * - [CharSequence.groupingBy]
++ *
++ * For the list of group-and-fold operations available, see the [extension functions](#extension-functions) for `Grouping`.
++ */
++@SinceKotlin(""1.1"")
++public interface Grouping<T, out K> {
++    /** Returns an [Iterator] which iterates through the elements of the source. */
++    fun elementIterator(): Iterator<T>
++    /** Extracts the key of an [element]. */
++    fun keyOf(element: T): K
++}
++
++/**
++ * Groups elements from the [Grouping] source by key and aggregates elements of each group with the specified [operation].
++ *
++ * The key for each element is provided by the [Grouping.keyOf] function.
++ *
++ * @param operation function is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `value`: the current value of the accumulator of a group, can be `null` if it's first `element` encountered in the group;
++ *  - `element`: the element from the source being aggregated;
++ *  - `first`: indicates whether it's first `element` encountered in the group.
++ *
++ * @return a [Map] associating the key of each group with the result of aggregation of the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R> Grouping<T, K>.aggregate(
++        operation: (key: K, value: R?, element: T, first: Boolean) -> R
++): Map<K, R> {
++    val result = mutableMapOf<K, R>()
++    for (e in this.elementIterator()) {
++        val key = keyOf(e)
++        val value = result[key]
++        result[key] = operation(key, value, e, value == null && !result.containsKey(key))
++    }
++    return result
++}
++
++/**
++ * Groups elements from the [Grouping] source by key and aggregates elements of each group with the specified [operation]
++ * to the given [destination] map.
++ *
++ * The key for each element is provided by the [Grouping.keyOf] function.
++ *
++ * @param operation a function that is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `accumulator`: the current value of the accumulator of the group, can be `null` if it's first `element` encountered in the group;
++ *  - `element`: the element from the source being aggregated;
++ *  - `first`: indicates whether it's first `element` encountered in the group.
++ *
++ * If the [destination] map already has a value corresponding to some key,
++ * then the elements being aggregated for that key are never considered as `first`.
++ *
++ * @return the [destination] map associating the key of each group with the result of aggregation of the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R, M : MutableMap<in K, R>> Grouping<T, K>.aggregateTo(
++        destination: M,
++        operation: (key: K, accumulator: R?, element: T, first: Boolean) -> R
++): M {
++    for (e in this.elementIterator()) {
++        val key = keyOf(e)
++        val acc = destination[key]
++        destination[key] = operation(key, acc, e, acc == null && !destination.containsKey(key))
++    }
++    return destination
++}
++
++/**
++ * Groups elements from the [Grouping] source by key and accumulates elements of each group with the specified [operation]
++ * starting with an initial value of accumulator provided by the [initialValueSelector] function.
++ *
++ * @param initialValueSelector a function that provides an initial value of accumulator for an each group.
++ *  It's invoked with parameters:
++ *  - `key`: the key of a group;
++ *  - `element`: the first element being encountered in that group.
++ *
++ * @param operation a function that is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `accumulator`: the current value of the accumulator of the group;
++ *  - `element`: the element from the source being accumulated.
++ *
++ * @return a [Map] associating the key of each group with the result of accumulating the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R> Grouping<T, K>.fold(
++        initialValueSelector: (key: K, element: T) -> R,
++        operation: (key: K, accumulator: R, element: T) -> R
++): Map<K, R> =
++        aggregate { key, value, e, first -> operation(key, if (first) initialValueSelector(key, e) else value as R, e) }
++
++/**
++ * Groups elements from the [Grouping] source by key and accumulates elements of each group with the specified [operation]
++ * starting with an initial value of accumulator provided by the [initialValueSelector] function
++ * to the given [destination] map.
++ *
++ * @param initialValueSelector a function that provides an initial value of accumulator for an each group.
++ *  It's invoked with parameters:
++ *  - `key`: the key of a group;
++ *  - `element`: the first element being encountered in that group.
++ *
++ * If the [destination] map already has a value corresponding to some key, that value is used as an initial value of
++ * the accumulator for that group and the [initialValueSelector] function is not called for that group.
++ *
++ * @param operation a function that is invoked on each element with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `accumulator`: the current value of the accumulator of the group;
++ *  - `element`: the element from the source being accumulated.
++ *
++ * @return the [destination] map associating the key of each group with the result of accumulating the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R, M : MutableMap<in K, R>> Grouping<T, K>.foldTo(
++        destination: M,
++        initialValueSelector: (key: K, element: T) -> R,
++        operation: (key: K, accumulator: R, element: T) -> R
++): M =
++        aggregateTo(destination) { key, value, e, first -> operation(key, if (first) initialValueSelector(key, e) else value as R, e) }
++
++
++/**
++ * Groups elements from the [Grouping] source by key and accumulates elements of each group with the specified [operation]
++ * starting with the [initialValue].
++ *
++ * @param operation a function that is invoked on each element with the following parameters:
++ *  - `accumulator`: the current value of the accumulator of the group;
++ *  - `element`: the element from the source being accumulated.
++ *
++ * @return a [Map] associating the key of each group with the result of accumulating the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R> Grouping<T, K>.fold(
++        initialValue: R,
++        operation: (accumulator: R, element: T) -> R
++): Map<K, R> =
++        aggregate { k, v, e, first -> operation(if (first) initialValue else v as R, e) }
++
++/**
++ * Groups elements from the [Grouping] source by key and accumulates elements of each group with the specified [operation]
++ * starting with the [initialValue] to the given [destination] map.
++ *
++ * If the [destination] map already has a value corresponding to the key of some group,
++ * that value is used as an initial value of the accumulator for that group.
++ *
++ * @param operation a function that is invoked on each element with the following parameters:
++ *  - `accumulator`: the current value of the accumulator of the group;
++ *  - `element`: the element from the source being accumulated.
++ *
++ * @return the [destination] map associating the key of each group with the result of accumulating the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <T, K, R, M : MutableMap<in K, R>> Grouping<T, K>.foldTo(
++        destination: M,
++        initialValue: R,
++        operation: (accumulator: R, element: T) -> R
++): M =
++        aggregateTo(destination) { k, v, e, first -> operation(if (first) initialValue else v as R, e) }
++
++
++/**
++ * Groups elements from the [Grouping] source by key and accumulates elements of each group with the specified [operation]
++ * starting the first element in that group.
++ *
++ * @param operation a function that is invoked on each subsequent element of the group with the following parameters:
++ *  - `key`: the key of a group this element belongs to;
++ *  - `accumulator`: the current value of the accumulator of the group;
++ *  - `element`: the element from the source being accumulated.
++ *
++ * @return a [Map] associating the key of each group with the result of accumulating the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <S, T : S, K> Grouping<T, K>.reduce(
++        operation: (key: K, accumulator: S, element: T) -> S
++): Map<K, S> =
++        aggregate { key, value, e, first ->
++            if (first) e else operation(key, value as S, e)
++        }
++
++/**
++ * Groups elements from the [Grouping] source by key and accumulates elements of each group with the specified [operation]
++ * starting the first element in that group to the given [destination] map.
++ *
++ * If the [destination] map already has a value corresponding to the key of some group,
++ * that value is used as an initial value of the accumulator for that group and the first element of that group is also
++ * subjected to the [operation].
++
++ * @param operation a function that is invoked on each subsequent element of the group with the following parameters:
++ *  - `accumulator`: the current value of the accumulator of the group;
++ *  - `element`: the element from the source being folded;
++ *
++ * @return the [destination] map associating the key of each group with the result of accumulating the group elements.
++ */
++@SinceKotlin(""1.1"")
++public inline fun <S, T : S, K, M : MutableMap<in K, S>> Grouping<T, K>.reduceTo(
++        destination: M,
++        operation: (key: K, accumulator: S, element: T) -> S
++): M =
++        aggregateTo(destination) { key, value, e, first ->
++            if (first) e else operation(key, value as S, e)
++        }
++
++
++/**
++ * Groups elements from the [Grouping] source by key and counts elements in each group.
++ *
++ * @return a [Map] associating the key of each group with the count of element in the group.
++ */
++@SinceKotlin(""1.1"")
++@JvmVersion
++public fun <T, K> Grouping<T, K>.eachCount(): Map<K, Int> =
++        // fold(0) { acc, e -> acc + 1 } optimized for boxing
++        fold(
++                initialValueSelector = { k, e -> kotlin.jvm.internal.Ref.IntRef() },
++                operation = { k, acc, e -> acc.apply { element += 1 } })
++        .mapValues { it.value.element }
++
++/**
++ * Groups elements from the [Grouping] source by key and counts elements in each group to the given [destination] map.
++ *
++ * @return the [destination] map associating the key of each group with the count of element in the group.
++ */
++@SinceKotlin(""1.1"")
++public fun <T, K, M : MutableMap<in K, Int>> Grouping<T, K>.eachCountTo(destination: M): M =
++        foldTo(destination, 0) { acc, e -> acc + 1 }
++
++/**
++ * Groups elements from the [Grouping] source by key and sums values provided by the [valueSelector] function for elements in each group.
++ *
++ * @return a [Map] associating the key of each group with the count of element in the group.
++ */
++@SinceKotlin(""1.1"")
++@JvmVersion
++public inline fun <T, K> Grouping<T, K>.eachSumOf(valueSelector: (T) -> Int): Map<K, Int> =
++        // fold(0) { acc, e -> acc + valueSelector(e)} optimized for boxing
++        fold(
++                initialValueSelector = { k, e -> kotlin.jvm.internal.Ref.IntRef() },
++                operation = { k, acc, e -> acc.apply { element += valueSelector(e) } })
++        .mapValues { it.value.element }",as we already use internal API hack we could do even more: we can create replace `IntRef` to `Int` inplace and then do unchecked cast.,2016-12-29 12:23:10
+698,"@@ -0,0 +1,28 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.descriptors.PropertyDescriptor
++import org.jetbrains.kotlin.load.java.components.JavaPropertyInitializerEvaluator
++import org.jetbrains.kotlin.load.java.structure.JavaField
++
++class JavacJavaPropertyInitializerEvaluator : JavaPropertyInitializerEvaluator {",There is already `JavaPropertyInitializerEvaluator.DO_NOTHING` with the same functionality,2017-04-05 12:49:39
+677,"@@ -0,0 +1,282 @@
++package kotlin.collections
++
++/**
++ * Represents a source of elements with a [keyOf] function, which can be applied to each element to get its key.
++ *
++ * A [Grouping] structure serves as an intermediate step in group-and-fold operations:
++ * they group elements by their keys and then fold each group with some aggregating operation.
++ *
++ * It is created by attaching `keySelector: (T) -> K` function to a source of elements.
++ * To get an instance of [Grouping] use one of `groupingBy` extension functions:","|`line 32`|
+|---|
+""a group"" -> ""the group"" here and below",2017-01-02 17:11:16
+678,"@@ -0,0 +1,282 @@
++package kotlin.collections
++
++/**
++ * Represents a source of elements with a [keyOf] function, which can be applied to each element to get its key.
++ *
++ * A [Grouping] structure serves as an intermediate step in group-and-fold operations:
++ * they group elements by their keys and then fold each group with some aggregating operation.
++ *
++ * It is created by attaching `keySelector: (T) -> K` function to a source of elements.
++ * To get an instance of [Grouping] use one of `groupingBy` extension functions:
++ * - [Iterable.groupingBy]
++ * - [Sequence.groupingBy]","|`line 61`|
+|---|
+Any chance for some `@sample`'s?",2017-01-02 17:15:42
+842,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {",Why not simply `at.getNonStrictParentOfType<KtStringTemplateExpression>`()?,2017-05-08 12:25:55
+843,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)","I think that it's better to create a single `StringBuilder` to hold the entire preprocessed contents, and to use the overload of `escapeStringCharacters` that takes a `StringBuilder` as a parameter.",2017-05-08 12:39:49
+844,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)
++                    is EntryChunk -> it.text
++                    is NewLineChunk -> ""\\n\""+\n \""""
++
++                }
++            }.joinToString(separator = """")
++        }
++        else {
++            val tripleQuoteRe = Regex(""[\""]{3,}"")
++            TemplateTokenizer(text).map { chunk ->
++                when (chunk) {
++                    is LiteralChunk -> chunk.text.replace(""\$"", ""\${'$'}"").let { escapedDollar ->
++                        tripleQuoteRe.replace(escapedDollar) { ""\""\"""" + ""\${'\""'}"".repeat(it.value.count() - 2) }
++                    }
++
++                    is EntryChunk -> chunk.text
++                    is NewLineChunk -> ""\n""
++
++                }
++            }.joinToString(separator = """")
++        }
++",Please reformat the files to remove unnecessary blank lines.,2017-05-08 12:41:33
+845,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)
++                    is EntryChunk -> it.text
++                    is NewLineChunk -> ""\\n\""+\n \""""
++
++                }
++            }.joinToString(separator = """")
++        }
++        else {
++            val tripleQuoteRe = Regex(""[\""]{3,}"")
++            TemplateTokenizer(text).map { chunk ->
++                when (chunk) {
++                    is LiteralChunk -> chunk.text.replace(""\$"", ""\${'$'}"").let { escapedDollar ->
++                        tripleQuoteRe.replace(escapedDollar) { ""\""\"""" + ""\${'\""'}"".repeat(it.value.count() - 2) }
++                    }
++
++                    is EntryChunk -> chunk.text
++                    is NewLineChunk -> ""\n""
++
++                }
++            }.joinToString(separator = """")
++        }
++
++    }
++
++
++}
++
++private sealed class TemplateChunk
++private data class LiteralChunk(val text: String) : TemplateChunk()
++private data class EntryChunk(val text: String) : TemplateChunk()
++private class NewLineChunk : TemplateChunk()",Can be `object NewLineChunk`,2017-05-08 12:41:50
+846,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)
++                    is EntryChunk -> it.text
++                    is NewLineChunk -> ""\\n\""+\n \""""
++
++                }
++            }.joinToString(separator = """")
++        }
++        else {
++            val tripleQuoteRe = Regex(""[\""]{3,}"")
++            TemplateTokenizer(text).map { chunk ->
++                when (chunk) {
++                    is LiteralChunk -> chunk.text.replace(""\$"", ""\${'$'}"").let { escapedDollar ->
++                        tripleQuoteRe.replace(escapedDollar) { ""\""\"""" + ""\${'\""'}"".repeat(it.value.count() - 2) }
++                    }
++
++                    is EntryChunk -> chunk.text
++                    is NewLineChunk -> ""\n""
++
++                }
++            }.joinToString(separator = """")
++        }
++
++    }
++
++
++}
++
++private sealed class TemplateChunk
++private data class LiteralChunk(val text: String) : TemplateChunk()
++private data class EntryChunk(val text: String) : TemplateChunk()
++private class NewLineChunk : TemplateChunk()
++
++private class TemplateTokenizer(private val inputString: String) : Sequence<TemplateChunk> {","I think this naming is kind of confusing; a tokenizer is something that returns a sequence, not something that is a sequence. I'd call it `TemplateTokenSequence`",2017-05-08 12:43:02
+847,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)
++                    is EntryChunk -> it.text
++                    is NewLineChunk -> ""\\n\""+\n \""""
++
++                }
++            }.joinToString(separator = """")
++        }
++        else {
++            val tripleQuoteRe = Regex(""[\""]{3,}"")
++            TemplateTokenizer(text).map { chunk ->
++                when (chunk) {
++                    is LiteralChunk -> chunk.text.replace(""\$"", ""\${'$'}"").let { escapedDollar ->
++                        tripleQuoteRe.replace(escapedDollar) { ""\""\"""" + ""\${'\""'}"".repeat(it.value.count() - 2) }
++                    }
++
++                    is EntryChunk -> chunk.text
++                    is NewLineChunk -> ""\n""
++
++                }
++            }.joinToString(separator = """")
++        }
++
++    }
++
++
++}
++
++private sealed class TemplateChunk
++private data class LiteralChunk(val text: String) : TemplateChunk()
++private data class EntryChunk(val text: String) : TemplateChunk()
++private class NewLineChunk : TemplateChunk()
++
++private class TemplateTokenizer(private val inputString: String) : Sequence<TemplateChunk> {
++
++    private fun String.guessIsTemplateEntryStart(): Boolean =
++            if (this.startsWith(""\${"")) {
++                true
++            }
++            else if (this.length > 1 && this[0] == '$'){
++                KotlinLexer().apply { start(this@guessIsTemplateEntryStart.substring(1)) }.tokenType == KtTokens.IDENTIFIER",Better to declare the result of `substring` as a variable outside of the `apply` block.,2017-05-08 12:44:14
+849,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)
++                    is EntryChunk -> it.text
++                    is NewLineChunk -> ""\\n\""+\n \""""
++
++                }
++            }.joinToString(separator = """")
++        }
++        else {
++            val tripleQuoteRe = Regex(""[\""]{3,}"")
++            TemplateTokenizer(text).map { chunk ->
++                when (chunk) {
++                    is LiteralChunk -> chunk.text.replace(""\$"", ""\${'$'}"").let { escapedDollar ->
++                        tripleQuoteRe.replace(escapedDollar) { ""\""\"""" + ""\${'\""'}"".repeat(it.value.count() - 2) }
++                    }
++
++                    is EntryChunk -> chunk.text
++                    is NewLineChunk -> ""\n""
++
++                }
++            }.joinToString(separator = """")
++        }
++
++    }
++
++
++}
++
++private sealed class TemplateChunk
++private data class LiteralChunk(val text: String) : TemplateChunk()
++private data class EntryChunk(val text: String) : TemplateChunk()
++private class NewLineChunk : TemplateChunk()
++
++private class TemplateTokenizer(private val inputString: String) : Sequence<TemplateChunk> {
++
++    private fun String.guessIsTemplateEntryStart(): Boolean =
++            if (this.startsWith(""\${"")) {
++                true
++            }
++            else if (this.length > 1 && this[0] == '$'){
++                KotlinLexer().apply { start(this@guessIsTemplateEntryStart.substring(1)) }.tokenType == KtTokens.IDENTIFIER
++            }
++            else {
++                false
++            }
++
++    private fun findTemplateEntryEnd(input: String, from: Int): Int{
++        val wrapped = '""' + input.substring(from) + '""'
++        val lexer = KotlinLexer().apply { start(wrapped) }.apply { advance() }
++
++        if (lexer.tokenType == KtTokens.SHORT_TEMPLATE_ENTRY_START){
++            lexer.advance()
++            return if (lexer.tokenType == KtTokens.IDENTIFIER){
++                from + lexer.tokenEnd -1
++            } else{
++                -1
++            }
++        }
++        else if(lexer.tokenType == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++            var depth = 0
++            while (lexer.tokenType != null) {
++                if (lexer.tokenType == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    depth++
++                }
++                else if (lexer.tokenType == KtTokens.LONG_TEMPLATE_ENTRY_END) {
++                    depth--
++                    if (depth == 0) {
++                        return from + lexer.currentPosition.offset - 1
++                    }
++                }
++                lexer.advance()
++            }
++            return -1
++        }
++        else {
++            return -1
++        }
++    }
++
++    private suspend fun SequenceBuilder<TemplateChunk>.yieldLiteral(chunk: String) {
++
++            val splitLines = LineTokenizer.tokenize(chunk, false, true)
++            for (i in 0..splitLines.size - 1) {
++                if (i != 0) {
++                    yield(NewLineChunk())
++                }
++                splitLines[i].takeIf { !it.isEmpty() }?.let { yield(LiteralChunk(it)) }
++            }
++
++    }
++
++    private fun iterTemplateChunks(): Iterator<TemplateChunk> {
++        if (inputString.isEmpty()) {
++            return emptySequence<TemplateChunk>().iterator()
++        }
++        return buildIterator {
++            var from = 0
++            var to = 0
++            while (to < inputString.length) {
++                val c = inputString[to]
++                if (c == '\\') {
++                    to += 1
++                    if (to < inputString.length)
++                        to += 1",I think this assumes that all escapes are single-character? That's not true; there are also `\uxxxx` escape sequences.,2017-05-08 12:48:33
+848,"@@ -0,0 +1,285 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor
++
++import com.intellij.codeInsight.editorActions.CopyPastePreProcessor
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.editor.RawText
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.openapi.util.text.LineTokenizer
++import com.intellij.openapi.util.text.StringUtil
++import com.intellij.psi.PsiDocumentManager
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.editor.fixers.range
++import org.jetbrains.kotlin.lexer.KotlinLexer
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtEscapeStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtStringTemplateEntry
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.isSingleQuoted
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import kotlin.coroutines.experimental.SequenceBuilder
++import kotlin.coroutines.experimental.buildIterator
++
++private fun PsiElement.findContainingTemplate(): PsiElement {
++    val parent = this.parent
++    @Suppress(""IfThenToElvis"")
++    return if (parent is KtStringTemplateEntry) parent.parent else parent
++}
++
++private fun PsiFile.getTemplateIfAtLiteral(offset: Int): KtStringTemplateExpression? {
++    val at = this.findElementAt(offset) ?: return null
++    return when (at.node?.elementType) {
++        KtTokens.REGULAR_STRING_PART, KtTokens.ESCAPE_SEQUENCE, KtTokens.LONG_TEMPLATE_ENTRY_START, KtTokens.SHORT_TEMPLATE_ENTRY_START -> at.parent.parent as? KtStringTemplateExpression
++        KtTokens.CLOSING_QUOTE -> if (offset == at.startOffset) at.parent as? KtStringTemplateExpression else null
++        else -> null
++
++    }
++}
++
++
++//Copied from StringLiteralCopyPasteProcessor to avoid erroneous inheritance
++private fun deduceBlockSelectionWidth(startOffsets: IntArray, endOffsets: IntArray, text: String): Int {
++    val fragmentCount = startOffsets.size
++    assert(fragmentCount > 0)
++    var totalLength = fragmentCount - 1 // number of line breaks inserted between fragments
++    for (i in 0..fragmentCount - 1) {
++        totalLength += endOffsets[i] - startOffsets[i]
++    }
++    if (totalLength < text.length && (text.length + 1) % fragmentCount == 0) {
++        return (text.length + 1) / fragmentCount - 1
++    }
++    else {
++        return -1
++    }
++}
++
++class KotlinLiteralCopyPasteProcessor : CopyPastePreProcessor {
++    override fun preprocessOnCopy(file: PsiFile, startOffsets: IntArray, endOffsets: IntArray, text: String): String? {
++        if (file !is KtFile){
++            return null
++        }
++        val buffer = StringBuilder()
++        var changed = false
++        val fileText = file.text
++        val deducedBlockSelectionWidth = deduceBlockSelectionWidth(startOffsets, endOffsets, text)
++
++        for (i in startOffsets.indices) {
++            if (i > 0) {
++                buffer.append('\n') // LF is added for block selection
++            }
++
++            val fileRange = TextRange(startOffsets[i], endOffsets[i])
++
++            var givenTextOffset = fileRange.startOffset
++            while (givenTextOffset < fileRange.endOffset) {
++                val element: PsiElement? = file.findElementAt(givenTextOffset)
++                if (element == null) {
++                    buffer.append(fileText.substring(givenTextOffset, fileRange.endOffset))
++                    break
++                }
++                val elTp = element.node.elementType
++                if (elTp == KtTokens.ESCAPE_SEQUENCE && fileRange.contains(element.range) && !fileRange.contains(element.findContainingTemplate().range)) {
++                    val tpEntry = element.parent as KtEscapeStringTemplateEntry
++                    changed = true
++                    buffer.append(tpEntry.unescapedValue)
++                    givenTextOffset = element.endOffset
++                }
++                else if (elTp == KtTokens.SHORT_TEMPLATE_ENTRY_START || elTp == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    //Process inner templates without escaping
++                    val tpEntry = element.parent
++                    val inter = fileRange.intersection(tpEntry.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++                else {
++                    val inter = fileRange.intersection(element.range)!!
++                    buffer.append(fileText.substring(inter.startOffset, inter.endOffset))
++                    givenTextOffset = inter.endOffset
++                }
++
++            }
++            val blockSelectionPadding = deducedBlockSelectionWidth - fileRange.length
++            for (j in 0..blockSelectionPadding - 1) {
++                buffer.append(' ')
++            }
++
++        }
++
++        return if (changed) buffer.toString() else null
++    }
++
++    override fun preprocessOnPaste(project: Project, file: PsiFile, editor: Editor, text: String, rawText: RawText?): String {
++        if (file !is KtFile){
++            return text
++        }
++        PsiDocumentManager.getInstance(project).commitDocument(editor.document)
++        val selectionModel = editor.selectionModel
++        val beginTp = file.getTemplateIfAtLiteral(selectionModel.selectionStart) ?: return text
++        val endTp = file.getTemplateIfAtLiteral(selectionModel.selectionEnd) ?: return text
++        if (beginTp.isSingleQuoted() != endTp.isSingleQuoted()) {
++            return text
++        }
++
++
++        return if (beginTp.isSingleQuoted()) {
++            TemplateTokenizer(text).map {
++                when (it) {
++                    is LiteralChunk -> StringUtil.escaper(true, ""\$\"""").`fun`(it.text)
++                    is EntryChunk -> it.text
++                    is NewLineChunk -> ""\\n\""+\n \""""
++
++                }
++            }.joinToString(separator = """")
++        }
++        else {
++            val tripleQuoteRe = Regex(""[\""]{3,}"")
++            TemplateTokenizer(text).map { chunk ->
++                when (chunk) {
++                    is LiteralChunk -> chunk.text.replace(""\$"", ""\${'$'}"").let { escapedDollar ->
++                        tripleQuoteRe.replace(escapedDollar) { ""\""\"""" + ""\${'\""'}"".repeat(it.value.count() - 2) }
++                    }
++
++                    is EntryChunk -> chunk.text
++                    is NewLineChunk -> ""\n""
++
++                }
++            }.joinToString(separator = """")
++        }
++
++    }
++
++
++}
++
++private sealed class TemplateChunk
++private data class LiteralChunk(val text: String) : TemplateChunk()
++private data class EntryChunk(val text: String) : TemplateChunk()
++private class NewLineChunk : TemplateChunk()
++
++private class TemplateTokenizer(private val inputString: String) : Sequence<TemplateChunk> {
++
++    private fun String.guessIsTemplateEntryStart(): Boolean =
++            if (this.startsWith(""\${"")) {
++                true
++            }
++            else if (this.length > 1 && this[0] == '$'){
++                KotlinLexer().apply { start(this@guessIsTemplateEntryStart.substring(1)) }.tokenType == KtTokens.IDENTIFIER
++            }
++            else {
++                false
++            }
++
++    private fun findTemplateEntryEnd(input: String, from: Int): Int{
++        val wrapped = '""' + input.substring(from) + '""'
++        val lexer = KotlinLexer().apply { start(wrapped) }.apply { advance() }
++
++        if (lexer.tokenType == KtTokens.SHORT_TEMPLATE_ENTRY_START){
++            lexer.advance()
++            return if (lexer.tokenType == KtTokens.IDENTIFIER){
++                from + lexer.tokenEnd -1
++            } else{
++                -1
++            }
++        }
++        else if(lexer.tokenType == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++            var depth = 0
++            while (lexer.tokenType != null) {
++                if (lexer.tokenType == KtTokens.LONG_TEMPLATE_ENTRY_START) {
++                    depth++
++                }
++                else if (lexer.tokenType == KtTokens.LONG_TEMPLATE_ENTRY_END) {
++                    depth--
++                    if (depth == 0) {
++                        return from + lexer.currentPosition.offset - 1
++                    }
++                }
++                lexer.advance()
++            }
++            return -1
++        }
++        else {
++            return -1
++        }
++    }
++
++    private suspend fun SequenceBuilder<TemplateChunk>.yieldLiteral(chunk: String) {
++
++            val splitLines = LineTokenizer.tokenize(chunk, false, true)
++            for (i in 0..splitLines.size - 1) {
++                if (i != 0) {
++                    yield(NewLineChunk())
++                }
++                splitLines[i].takeIf { !it.isEmpty() }?.let { yield(LiteralChunk(it)) }
++            }
++
++    }
++
++    private fun iterTemplateChunks(): Iterator<TemplateChunk> {
++        if (inputString.isEmpty()) {
++            return emptySequence<TemplateChunk>().iterator()
++        }
++        return buildIterator {
++            var from = 0
++            var to = 0
++            while (to < inputString.length) {
++                val c = inputString[to]
++                if (c == '\\') {
++                    to += 1
++                    if (to < inputString.length)
++                        to += 1
++                    continue
++
++                }
++                when (c) {",No reason to use `when` here; `if` would be cleaner.,2017-05-08 12:45:31
+901,"@@ -0,0 +1,3 @@
++// INTENTION_TEXT: ""Convert to sealed class""","Since you aren't changing the intention text dynamically, there's no need to include INTENTION_TEXT in testdata files.",2017-07-17 11:17:40
+902,"@@ -0,0 +1,3 @@
++<spot>@JvmStatic</spot>","The template shows a top-level method, not a method inside an `object`. Please update it to show what the intention action actually does.",2017-07-17 11:20:35
+100,"@@ -0,0 +1,3 @@
++[3]
++
++[3, 5]","Please update this file to be exactly the result of your intention on `before.kt.template`. Also you can use `<spot>` tag to highlight the place where the user should put his attention
+",2014-02-06 14:38:50
+223,"@@ -0,0 +1,3 @@
++for ((i,x) in foo.withIndices()) {","Please add a whitespace after the comma
+",2014-04-30 19:19:20
+211,"@@ -0,0 +1,3 @@
++fun foo(a: String?, b: String?) {
++    a?.equals(b) ?: b.identityEquals(null)
++}","Please, add test for the case of non-nullable receiver
+",2014-04-23 14:22:32
+84,"@@ -0,0 +1,3 @@
++fun foo(x: Boolean) : Boolean {
++    return x || x || x","This behavior is objectionable: order of predicates evaluation can change program behavior, when evaluated expressions have side effects. I'll disable intention in this case.
+",2013-07-08 15:18:18
+805,"@@ -0,0 +1,30 @@
++/*","Consider merging small and relevant declarations together into one file, e.g. `JavaType` implementations into `symbolBasedTypes.kt`, `JavaAnnotationArgument` implementations into `symbolBasedAnnotationArguments.kt` and so on. I think it'd be more readable in the end",2017-04-25 12:19:05
+720,"@@ -0,0 +1,30 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaEnumValueAnnotationArgument
++import org.jetbrains.kotlin.name.FqName
++import javax.lang.model.element.VariableElement
++
++class JavacReferenceAnnotationArgument(val element: VariableElement,
++                                       javac: Javac) : JavacAnnotationArgument(FqName(element.simpleName.toString()), javac),
++        JavaEnumValueAnnotationArgument {
++
++    override fun resolve() = JavacField(element, javac)","In NB plugin you're using containing class at this point, but here you aren't. Are you sure it's not a mistake?",2017-04-05 15:10:31
+803,"@@ -0,0 +1,30 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationAsAnnotationArgument
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.AnnotationMirror
++
++class SymbolBasedAnnotationAsAnnotationArgument(val mirror: AnnotationMirror,","I'd assume that all `SymbolBased*AnnotationArgument`s are subclasses of `SymbolBasedAnnotationArgument`, but only one of them is (`SymbolBasedReferenceAnnotationArgument`). I suggest either inheriting all of them from `SymbolBasedAnnotationArgument`, or getting rid of the latter altogether",2017-04-25 12:08:18
+809,"@@ -0,0 +1,30 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaArrayType
++import javax.lang.model.type.ArrayType
++import javax.lang.model.type.TypeMirror
++
++class SymbolBasedArrayType<out T : TypeMirror>(typeMirror: T,","Instead of generic type parameter, inherit from `SymbolBasedType<ArrayType>`, cast `typeMirror` to `ArrayType` once at creation site",2017-04-25 12:26:46
+394,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.","""in the runtime"" -> ""at runtime""?
+Имеется в виду ""во время выполнения программы""?
+",2015-07-27 18:37:05
+395,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter), so that it's possible to do `listOfStrings.map(String::length)`","""coercible"" usually assumes some transformation of the value representation to fit to a new type. If it's exactly the same object, just viewed as an instance of a new type, then maybe it would be better to say ""implicitly convertible"" or ""assignable""?
+",2015-07-27 18:40:57
+396,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter), so that it's possible to do `listOfStrings.map(String::length)`
++* Allow functions with more than 23 parameters, theoretically any number of parameters (in practice 255 on JVM).
++* At the same time, allow to implement Kotlin functions easily from Java: `new Function2() { ... }` and overriding `invoke` only would be the best.","I do not get the meaning of ""overriding `invoke` only would be the best"".
+",2015-07-27 18:42:14
+397,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter), so that it's possible to do `listOfStrings.map(String::length)`
++* Allow functions with more than 23 parameters, theoretically any number of parameters (in practice 255 on JVM).
++* At the same time, allow to implement Kotlin functions easily from Java: `new Function2() { ... }` and overriding `invoke` only would be the best.
++Enabling SAM conversions on Java 8 would also be terrific.
++
++## Brief solution overview
++
++* Treat extension functions almost like non-extension functions with one extra parameter, allowing to use them almost interchangeably.
++* Introduce a physical class `Function` and unlimited number of *fictitious* (synthetic) classes `Function0`, `Function1`, ... in the compiler front-end
++* On JVM, introduce `Function0`..`Function22`, which are optimized in a certain way,
++and `FunctionN` for functions with 23+ parameters.
++When passing a lambda to Kotlin from Java, one will need to implement one of these interfaces.
++* Also on JVM (under the hood) add abstract `FunctionImpl` which implements all of `Fun0`..`Fun22` and `FunN`","What is `Fun0`?
+",2015-07-27 18:44:14
+398,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter), so that it's possible to do `listOfStrings.map(String::length)`
++* Allow functions with more than 23 parameters, theoretically any number of parameters (in practice 255 on JVM).
++* At the same time, allow to implement Kotlin functions easily from Java: `new Function2() { ... }` and overriding `invoke` only would be the best.
++Enabling SAM conversions on Java 8 would also be terrific.
++
++## Brief solution overview
++
++* Treat extension functions almost like non-extension functions with one extra parameter, allowing to use them almost interchangeably.
++* Introduce a physical class `Function` and unlimited number of *fictitious* (synthetic) classes `Function0`, `Function1`, ... in the compiler front-end
++* On JVM, introduce `Function0`..`Function22`, which are optimized in a certain way,
++and `FunctionN` for functions with 23+ parameters.
++When passing a lambda to Kotlin from Java, one will need to implement one of these interfaces.
++* Also on JVM (under the hood) add abstract `FunctionImpl` which implements all of `Fun0`..`Fun22` and `FunN`
++(throwing exceptions), and which knows its arity.
++Kotlin lambdas are translated to subclasses of this abstract class, passing the correct arity to the super constructor.
++* Provide a way to get arity of an arbitrary `Function` object (pretty straightforward).
++* Hack `is/as Function5` on any numbered function in codegen (and probably `KClass.cast()` in reflection) to check against `Function` and its arity.","So, is it `Function` or `FunctionImpl` who knows the function arity? For which type are we going to check in `is` operator?
+",2015-07-27 18:47:04
+399,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter), so that it's possible to do `listOfStrings.map(String::length)`
++* Allow functions with more than 23 parameters, theoretically any number of parameters (in practice 255 on JVM).
++* At the same time, allow to implement Kotlin functions easily from Java: `new Function2() { ... }` and overriding `invoke` only would be the best.
++Enabling SAM conversions on Java 8 would also be terrific.
++
++## Brief solution overview
++
++* Treat extension functions almost like non-extension functions with one extra parameter, allowing to use them almost interchangeably.
++* Introduce a physical class `Function` and unlimited number of *fictitious* (synthetic) classes `Function0`, `Function1`, ... in the compiler front-end
++* On JVM, introduce `Function0`..`Function22`, which are optimized in a certain way,
++and `FunctionN` for functions with 23+ parameters.
++When passing a lambda to Kotlin from Java, one will need to implement one of these interfaces.
++* Also on JVM (under the hood) add abstract `FunctionImpl` which implements all of `Fun0`..`Fun22` and `FunN`
++(throwing exceptions), and which knows its arity.
++Kotlin lambdas are translated to subclasses of this abstract class, passing the correct arity to the super constructor.
++* Provide a way to get arity of an arbitrary `Function` object (pretty straightforward).
++* Hack `is/as Function5` on any numbered function in codegen (and probably `KClass.cast()` in reflection) to check against `Function` and its arity.
++
++## Extension functions
++
++Extension function type `T.(P) -> R` is now just a shorthand for `@kotlin.extension Function2<T, P, R>`.
++`kotlin.extension` is a **type annotation** defined in built-ins.
++So effectively functions and extension functions now have the same type,
++which means that everything which takes a function will work with an extension function and vice versa.
++
++To prevent unpleasant ambiguities, we introduce additional restrictions:
++* A value of an extension function type cannot be **called** as a function, and a value of a non-extension
++function type cannot be called as an extension. This requires an additional diagnostic which is only fired
++when a call is resolved to the `invoke` with the wrong extension-ness.
++* If an extension function **literal** argument has some shape (its parameters are written out explicitly
++in the code and it's evident that there is or there isn't a receiver parameter), this shape must exactly match","What could make it evident that there is or there isn't a receiver parameter?
+",2015-07-27 18:50:04
+400,"@@ -0,0 +1,304 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. One of the problems with them is that they should be effectively duplicated in reflection which means a lot of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter), so that it's possible to do `listOfStrings.map(String::length)`
++* Allow functions with more than 23 parameters, theoretically any number of parameters (in practice 255 on JVM).
++* At the same time, allow to implement Kotlin functions easily from Java: `new Function2() { ... }` and overriding `invoke` only would be the best.
++Enabling SAM conversions on Java 8 would also be terrific.
++
++## Brief solution overview
++
++* Treat extension functions almost like non-extension functions with one extra parameter, allowing to use them almost interchangeably.
++* Introduce a physical class `Function` and unlimited number of *fictitious* (synthetic) classes `Function0`, `Function1`, ... in the compiler front-end
++* On JVM, introduce `Function0`..`Function22`, which are optimized in a certain way,
++and `FunctionN` for functions with 23+ parameters.
++When passing a lambda to Kotlin from Java, one will need to implement one of these interfaces.
++* Also on JVM (under the hood) add abstract `FunctionImpl` which implements all of `Fun0`..`Fun22` and `FunN`
++(throwing exceptions), and which knows its arity.
++Kotlin lambdas are translated to subclasses of this abstract class, passing the correct arity to the super constructor.
++* Provide a way to get arity of an arbitrary `Function` object (pretty straightforward).
++* Hack `is/as Function5` on any numbered function in codegen (and probably `KClass.cast()` in reflection) to check against `Function` and its arity.
++
++## Extension functions
++
++Extension function type `T.(P) -> R` is now just a shorthand for `@kotlin.extension Function2<T, P, R>`.
++`kotlin.extension` is a **type annotation** defined in built-ins.
++So effectively functions and extension functions now have the same type,
++which means that everything which takes a function will work with an extension function and vice versa.
++
++To prevent unpleasant ambiguities, we introduce additional restrictions:
++* A value of an extension function type cannot be **called** as a function, and a value of a non-extension
++function type cannot be called as an extension. This requires an additional diagnostic which is only fired
++when a call is resolved to the `invoke` with the wrong extension-ness.
++* If an extension function **literal** argument has some shape (its parameters are written out explicitly
++in the code and it's evident that there is or there isn't a receiver parameter), this shape must exactly match
++the extension-ness of the corresponding parameter. You can't pass an extension function **literal**
++where a function is expected and vice versa. The same holds for function expressions.
++If you really want to do that, change the shape or use the `as` operator.
++
++So basically you can now safely coerce values between function and extension function types,
++but still should invoke them in the format which you specified in their type (with or without `@extension`).
++
++With this we'll get rid of classes `ExtensionFunction0`, `ExtensionFunction1`, ...
++and the rest of this article will deal only with usual functions.
++
++## Function0, Function1, ... types
++
++The arity of the functional interface that the type checker can create in theory **is not limited** to any number,
++but in practice should be limited to 255 on JVM.
++
++These interfaces are named `kotlin.Function0<R>`, `kotlin.Function1<P0, R>`, ..., `kotlin.Function42<P0, P1, ..., P41, R>`, ...
++They are *fictitious*, which means they have no sources and no runtime representation.
++Type checker creates the corresponding descriptors on demand, IDE creates corresponding source files on demand as well.
++Each of them inherits from `kotlin.Function` (described below) and contains only two functions,
++both of which should be synthetically produced by the compiler:
++* (declaration) `invoke` with no receiver, with the corresponding number of parameters and return type.
++* (synthesized) `invoke` with first type parameter as the extension receiver type, and the rest as parameters and return type.","""first type parameter""? Are you talking about `<T, ...>`?
+",2015-07-27 18:54:14
+719,"@@ -0,0 +1,31 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.builtins.PrimitiveType
++import org.jetbrains.kotlin.load.java.structure.JavaPrimitiveType
++import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType
++import javax.lang.model.type.TypeMirror
++
++class JavacPrimitiveType<out T : TypeMirror>(typeMirror: T,
++                                             javac: Javac) : JavacType<T>(typeMirror, javac), JavaPrimitiveType {
++
++    override val type: PrimitiveType?
++        get() = if (""void"" == typeMirror.toString()) null else JvmPrimitiveType.get(typeMirror.toString()).primitiveType",You can extract `typeMirror.toString()`,2017-04-05 15:09:04
+830,"@@ -0,0 +1,31 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationArgument
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++import org.jetbrains.kotlin.name.FqName
++
++open class TreeBasedAnnotationArgument(val tree: JCTree.JCExpression,
++                                       fqName: FqName,",`Name` should be enough here as well,2017-04-25 16:28:33
+462,"@@ -0,0 +1,313 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.reflect.KMutableProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++public val COMPILE_DAEMON_TIMEOUT_INFINITE_S: Int = 0
++public val COMPILE_DAEMON_MEMORY_THRESHOLD_INFINITE: Long = 0L
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++//open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++//                                                    val prop: P,
++//                                                    val name: String,
++//                                                    val convert: ((v: V) -> String?) = { it.toString() },
++//                                                    val skipIf: ((v: V) -> Boolean) = { false },
++//                                                    val mergeWithDelimiter: String? = null)
++//{
++//    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++//    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++//            when {
++//                skipIf(prop.get(dest)) -> listOf<String>()
++//                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++//                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++//            }
++//}
++//
++//class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++//    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++//
++//class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++//    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++//}
++//
++//
++//open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++//                                                        val prop: P, alternativeNames: List<String>,
++//                                                        val parse: (s: String) -> V,
++//                                                        val allowMergedArg: Boolean = false) {
++//    val names = listOf(prop.name) + alternativeNames
++//    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++//    fun apply(s: String) = prop.set(dest, parse(s))
++//}
++//
++//class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++//
++//class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++//    fun add(s: String) { prop.get(dest).add(s) }
++//}","let's drop it
+",2015-08-31 12:29:46
+460,"@@ -0,0 +1,313 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.reflect.KMutableProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++public val COMPILE_DAEMON_TIMEOUT_INFINITE_S: Int = 0
++public val COMPILE_DAEMON_MEMORY_THRESHOLD_INFINITE: Long = 0L
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++//open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++//                                                    val prop: P,
++//                                                    val name: String,
++//                                                    val convert: ((v: V) -> String?) = { it.toString() },
++//                                                    val skipIf: ((v: V) -> Boolean) = { false },
++//                                                    val mergeWithDelimiter: String? = null)
++//{
++//    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++//    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++//            when {
++//                skipIf(prop.get(dest)) -> listOf<String>()
++//                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++//                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++//            }
++//}
++//
++//class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++//    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++//
++//class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++//    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++//}
++//
++//
++//open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++//                                                        val prop: P, alternativeNames: List<String>,
++//                                                        val parse: (s: String) -> V,
++//                                                        val allowMergedArg: Boolean = false) {
++//    val names = listOf(prop.name) + alternativeNames
++//    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++//    fun apply(s: String) = prop.set(dest, parse(s))
++//}
++//
++//class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++//
++//class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++//    fun add(s: String) { prop.get(dest).add(s) }
++//}
++
++// --------------------------------------------------------
++
++open class PropMapper<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P,
++                                                        val names: List<String> = listOf(prop.name),
++                                                        val fromString: (s: String) -> V,
++                                                        val toString: ((v: V) -> String?) = { it.toString() },
++                                                        val skipIf: ((v: V) -> Boolean) = { false },
++                                                        val mergeDelimiter: String? = null)
++{
++    open fun toArgs(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeDelimiter != null -> listOf(prefix + names.first() + mergeDelimiter + toString(prop.get(dest))).filterNotNull()","nothing to filter out by `filterNotNull` 
+",2015-08-31 11:42:08
+461,"@@ -0,0 +1,313 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.File
++import java.io.Serializable
++import java.lang.management.ManagementFactory
++import java.security.DigestInputStream
++import java.security.MessageDigest
++import kotlin.reflect.KMutableProperty1
++
++
++public val COMPILER_JAR_NAME: String = ""kotlin-compiler.jar""
++public val COMPILER_SERVICE_RMI_NAME: String = ""KotlinJvmCompilerService""
++public val COMPILER_DAEMON_CLASS_FQN: String = ""org.jetbrains.kotlin.rmi.service.CompileDaemon""
++public val COMPILE_DAEMON_DEFAULT_PORT: Int = 17031
++public val COMPILE_DAEMON_ENABLED_PROPERTY: String =""kotlin.daemon.enabled""
++public val COMPILE_DAEMON_JVM_OPTIONS_PROPERTY: String =""kotlin.daemon.jvm.options""
++public val COMPILE_DAEMON_OPTIONS_PROPERTY: String =""kotlin.daemon.options""
++public val COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX: String =""--daemon-""
++public val COMPILE_DAEMON_TIMEOUT_INFINITE_S: Int = 0
++public val COMPILE_DAEMON_MEMORY_THRESHOLD_INFINITE: Long = 0L
++
++val COMPILER_ID_DIGEST = ""MD5""
++
++//open class PropExtractor<C, V, P: KProperty1<C, V>>(val dest: C,
++//                                                    val prop: P,
++//                                                    val name: String,
++//                                                    val convert: ((v: V) -> String?) = { it.toString() },
++//                                                    val skipIf: ((v: V) -> Boolean) = { false },
++//                                                    val mergeWithDelimiter: String? = null)
++//{
++//    constructor(dest: C, prop: P, convert: ((v: V) -> String?) = { it.toString() }, skipIf: ((v: V) -> Boolean) = { false }) : this(dest, prop, prop.name, convert, skipIf)
++//    open fun extract(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++//            when {
++//                skipIf(prop.get(dest)) -> listOf<String>()
++//                mergeWithDelimiter != null -> listOf(prefix + name + mergeWithDelimiter + convert(prop.get(dest))).filterNotNull()
++//                else -> listOf(prefix + name, convert(prop.get(dest))).filterNotNull()
++//            }
++//}
++//
++//class BoolPropExtractor<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, name: String? = null)
++//    : PropExtractor<C, Boolean, P>(dest, prop, name ?: prop.name, convert = { null }, skipIf = { !prop.get(dest) })
++//
++//class RestPropExtractor<C, P: KMutableProperty1<C, out MutableCollection<String>>>(dest: C, prop: P) : PropExtractor<C, MutableCollection<String>, P>(dest, prop, convert = { null }) {
++//    override fun extract(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++//}
++//
++//
++//open class PropParser<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++//                                                        val prop: P, alternativeNames: List<String>,
++//                                                        val parse: (s: String) -> V,
++//                                                        val allowMergedArg: Boolean = false) {
++//    val names = listOf(prop.name) + alternativeNames
++//    constructor(dest: C, prop: P, parse: (s: String) -> V, allowMergedArg: Boolean = false) : this(dest, prop, listOf(), parse, allowMergedArg)
++//    fun apply(s: String) = prop.set(dest, parse(s))
++//}
++//
++//class BoolPropParser<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P): PropParser<C, Boolean, P>(dest, prop, { true })
++//
++//class RestPropParser<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P): PropParser<C, MutableCollection<String>, P>(dest, prop, { arrayListOf() }) {
++//    fun add(s: String) { prop.get(dest).add(s) }
++//}
++
++// --------------------------------------------------------
++
++open class PropMapper<C, V, P: KMutableProperty1<C, V>>(val dest: C,
++                                                        val prop: P,
++                                                        val names: List<String> = listOf(prop.name),
++                                                        val fromString: (s: String) -> V,
++                                                        val toString: ((v: V) -> String?) = { it.toString() },
++                                                        val skipIf: ((v: V) -> Boolean) = { false },
++                                                        val mergeDelimiter: String? = null)
++{
++    open fun toArgs(prefix: String = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX): List<String> =
++            when {
++                skipIf(prop.get(dest)) -> listOf<String>()
++                mergeDelimiter != null -> listOf(prefix + names.first() + mergeDelimiter + toString(prop.get(dest))).filterNotNull()
++                else -> listOf(prefix + names.first(), toString(prop.get(dest))).filterNotNull()
++            }
++    fun apply(s: String) = prop.set(dest, fromString(s))
++}
++
++class StringPropMapper<C, P: KMutableProperty1<C, String>>(dest: C,
++                                                           prop: P,
++                                                           names: List<String> = listOf(),
++                                                           fromString: ((String) -> String) = { it },
++                                                           toString: ((String) -> String?) = { it.toString() },
++                                                           skipIf: ((String) -> Boolean) = { it.isEmpty() },
++                                                           mergeDelimiter: String? = null)
++: PropMapper<C, String, P>(dest = dest, prop = prop, names = if (names.any()) names else listOf(prop.name),
++                            fromString = fromString,  toString = toString, skipIf = skipIf, mergeDelimiter = mergeDelimiter)
++
++class BoolPropMapper<C, P: KMutableProperty1<C, Boolean>>(dest: C, prop: P, names: List<String> = listOf())
++    : PropMapper<C, Boolean, P>(dest = dest, prop = prop, names = if (names.any()) names else listOf(prop.name), 
++                                fromString = { true },  toString = { null }, skipIf = { !prop.get(dest) })
++
++class RestPropMapper<C, P: KMutableProperty1<C, MutableCollection<String>>>(dest: C, prop: P) 
++    : PropMapper<C, MutableCollection<String>, P>(dest = dest, prop = prop, toString = { null }, fromString = { arrayListOf() }) 
++{
++    override fun toArgs(prefix: String): List<String> = prop.get(dest).map { prefix + it }
++    fun add(s: String) { prop.get(dest).add(s) }
++}
++
++// ------------------------------------------
++
++fun Iterable<String>.filterExtractProps(propMappers: List<PropMapper<*,*,*>>, prefix: String, restParser: RestPropMapper<*,*>? = null) : Iterable<String>  {","During the previous review I slightly rewrite this and something else, I hope this will be useful.
+https://github.com/JetBrains/kotlin/commit/ef2ea84a85c3415fc9fa1c933e44c880df979d80#diff-4ff40116c0033e709c32c7abef5b2b0eR84
+",2015-08-31 12:24:57
+810,"@@ -0,0 +1,32 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaPrimitiveType
++import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType
++import javax.lang.model.type.TypeMirror
++
++class SymbolBasedPrimitiveType<out T : TypeMirror>(typeMirror: T,",Drop generic type parameter here and inherit from `SymbolBasedType<*>`,2017-04-25 12:27:41
+806,"@@ -0,0 +1,32 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaPrimitiveType
++import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType
++import javax.lang.model.type.TypeMirror
++
++class SymbolBasedPrimitiveType<out T : TypeMirror>(typeMirror: T,
++                                                   javac: JavacWrapper) : SymbolBasedType<T>(typeMirror, javac), JavaPrimitiveType {
++
++    override val type
++        get() = with(typeMirror.toString()) {
++            if (""void"" == this) null else JvmPrimitiveType.get(this).primitiveType",Please inspect `TypeMirror.getKind` instead of `toString`,2017-04-25 12:20:25
+831,"@@ -0,0 +1,32 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaPrimitiveType
++import org.jetbrains.kotlin.resolve.jvm.JvmPrimitiveType
++
++class TreeBasedPrimitiveType<out T : JCTree.JCPrimitiveTypeTree>(tree: T,
++                                                                 treePath: TreePath,
++                                                                 javac: JavacWrapper) : TreeBasedType<T>(tree, treePath, javac), JavaPrimitiveType {
++
++    override val type
++        get() = if (""void"" == tree.toString()) null else JvmPrimitiveType.get(tree.toString()).primitiveType","Again, please inspect `tree.getKind()` instead of the string returned by `toString`",2017-04-25 16:34:26
+78,"@@ -0,0 +1,334 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManagerUtil;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class SpecifySuperExplicitlyFix extends JetIntentionAction<JetSuperExpression> {","About functionality:
+1. It's not good to give a user a partial functionality.
+He would be surprised to find that the case 'super.foo()' is working, but 'super.foo().bar()' isn't.
+2. I'd expect some choice which receiver I'd like to invoke here.
+",2013-05-29 11:07:40
+79,"@@ -0,0 +1,334 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManagerUtil;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class SpecifySuperExplicitlyFix extends JetIntentionAction<JetSuperExpression> {
++    private PsiElement elementToReplace;
++    private final LinkedHashSet<String> options;","It's better to use less concrete types like Set<String> or Collection<String> here. (The following code should be independent of concrete implementation of collection to make it easy to change it later if necessary).
+",2013-05-29 11:09:34
+82,"@@ -0,0 +1,334 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManagerUtil;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class SpecifySuperExplicitlyFix extends JetIntentionAction<JetSuperExpression> {
++    private PsiElement elementToReplace;
++    private final LinkedHashSet<String> options;
++
++
++    public SpecifySuperExplicitlyFix(@NotNull JetSuperExpression element, @NotNull LinkedHashSet<String> options) {
++        super(element);
++        elementToReplace = element;
++        this.options = options;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""specify.super.explicitly"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""specify.super.explicitly.family"");
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        return !options.isEmpty();
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) {","Don't override 'Deprecated' method.
+",2013-05-29 11:15:42
+80,"@@ -0,0 +1,334 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManagerUtil;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class SpecifySuperExplicitlyFix extends JetIntentionAction<JetSuperExpression> {
++    private PsiElement elementToReplace;
++    private final LinkedHashSet<String> options;
++
++
++    public SpecifySuperExplicitlyFix(@NotNull JetSuperExpression element, @NotNull LinkedHashSet<String> options) {
++        super(element);
++        elementToReplace = element;
++        this.options = options;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""specify.super.explicitly"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""specify.super.explicitly.family"");
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        return !options.isEmpty();
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) {
++        elementToReplace = elementToReplace.replace(JetPsiFactory.createExpression(project, options.iterator().next()));
++        buildAndShowTemplate(project, editor, file, elementToReplace, options);
++    }
++
++    public static JetIntentionActionFactory createFactory() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {","I'd rather divide this method into several smaller ones with meaningful names.
+",2013-05-29 11:10:46
+81,"@@ -0,0 +1,334 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManagerUtil;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class SpecifySuperExplicitlyFix extends JetIntentionAction<JetSuperExpression> {
++    private PsiElement elementToReplace;
++    private final LinkedHashSet<String> options;
++
++
++    public SpecifySuperExplicitlyFix(@NotNull JetSuperExpression element, @NotNull LinkedHashSet<String> options) {
++        super(element);
++        elementToReplace = element;
++        this.options = options;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""specify.super.explicitly"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""specify.super.explicitly.family"");
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        return !options.isEmpty();
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) {
++        elementToReplace = elementToReplace.replace(JetPsiFactory.createExpression(project, options.iterator().next()));
++        buildAndShowTemplate(project, editor, file, elementToReplace, options);
++    }
++
++    public static JetIntentionActionFactory createFactory() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetSuperExpression superExp = QuickFixUtil.getParentElementOfType(diagnostic, JetSuperExpression.class);
++                if (superExp == null) {
++                    return null;
++                }
++
++                JetClass klass = QuickFixUtil.getParentElementOfType(diagnostic, JetClass.class);
++                if (klass == null) {
++                    return null;
++                }
++
++                JetDelegationSpecifierList superClasses = PsiTreeUtil.getChildOfType(klass, JetDelegationSpecifierList.class);
++                if (superClasses == null) {
++                    return null;
++                }
++
++                //Used for checking visibility
++                BindingContext contextClasses = KotlinCacheManagerUtil.getDeclarationsFromProject(superExp).getBindingContext();
++                ClassDescriptor fromClass = contextClasses.get(BindingContext.CLASS, klass);
++                if (fromClass == null) {
++                    return null;
++                }
++
++                //Fetch class descriptors for all super classes
++                LinkedHashSet<ClassDescriptor> superClassDescs = new LinkedHashSet<ClassDescriptor>();
++                for (JetDelegationSpecifier delSpec : superClasses.getDelegationSpecifiers()) {
++                    JetSimpleNameExpression jetRef = PsiTreeUtil.findChildOfType(delSpec.getTypeReference(), JetSimpleNameExpression.class);
++                    if (jetRef == null) {
++                        continue;
++                    }
++                    ClassDescriptor classDesc = resolveToClass(jetRef, contextClasses);
++                    if (classDesc != null) {
++                        superClassDescs.add(classDesc);
++                    }
++                }
++                if (superClassDescs.isEmpty()) {
++                    return null;
++                }
++
++                //Get the name of the member in question and other access information. The super expression
++                //MUST be a part of a dot qualified expression.
++                JetDotQualifiedExpression dotExp = QuickFixUtil.getParentElementOfType(diagnostic, JetDotQualifiedExpression.class);
++                if (dotExp == null) {
++                    return null;
++                }
++                JetExpression nextExp = dotExp;
++                JetExpression currentExp = null;
++
++                ArrayList<String> memberNames = new ArrayList<String>();
++                //contains a null in the index where the memberName at that same index is of a property.
++                ArrayList<JetValueArgumentList> argsForFunction = new ArrayList<JetValueArgumentList>();
++                while (nextExp != null && (nextExp instanceof JetDotQualifiedExpression || nextExp instanceof JetArrayAccessExpression)) {
++                    currentExp = nextExp;
++                    String memberName;
++                    JetValueArgumentList valArgs;
++
++                    if (currentExp instanceof JetDotQualifiedExpression) {
++                        JetCallExpression call = PsiTreeUtil.getChildOfType(currentExp, JetCallExpression.class);
++                        if (call != null) {
++                            JetSimpleNameExpression name = PsiTreeUtil.getChildOfType(call, JetSimpleNameExpression.class);
++                            if (name == null) {
++                                return null;
++                            }
++                            memberName = name.getText();
++                            valArgs = call.getValueArgumentList();
++                        }
++                        else {
++                            JetSimpleNameExpression name = PsiTreeUtil.getChildOfType(currentExp, JetSimpleNameExpression.class);
++                            if (name == null) {
++                                return null;
++                            }
++                            memberName = name.getText();
++                            valArgs = null;
++                        }
++                    }
++                    else {
++                        //array indexing not supported for now.
++                        return null;
++                        /**
++                        memberName = ""get""; //array indexing is the same as get function call
++
++                        JetContainerNode indexNode =  ((JetArrayAccessExpression) currentExp).getIndicesNode();
++                        JetConstantExpression constant = PsiTreeUtil.getChildOfType(indexNode, JetConstantExpression.class);
++                        JetReferenceExpression refIndex = PsiTreeUtil.getChildOfType(indexNode, JetReferenceExpression.class);
++                        if (constant == null && refIndex == null) {
++                            return null;
++                        }
++                        if (constant != null) {
++                            valArgs = JetPsiFactory.createCallArguments(diagnostic.getPsiFile()
++                            .getProject(), ""("" + constant.getText() + "")"");
++                        }
++                        else {
++                            valArgs = JetPsiFactory.createCallArguments(diagnostic.getPsiFile()
++                            .getProject(), ""("" + refIndex.getText() + "")"");
++                        }**/
++                    }
++                    memberNames.add(memberName);
++                    argsForFunction.add(valArgs);
++                    nextExp = PsiTreeUtil.getParentOfType(currentExp, JetExpression.class);
++                }
++                if (memberNames.isEmpty()) {
++                    return null;
++                }
++
++                //Right now, code has unexpected behavior with chained calls e.g. super.foo().bar.baz() so we just return null.
++                if (memberNames.size() > 1) {
++                    return null;
++                }
++
++
++                //Get the expected type of the expression if applicable (e.g. var a : Int = super.foo)
++                BindingContext contextExpressions = AnalyzerFacadeWithCache.analyzeFileWithCache((JetFile) diagnostic.getPsiFile())
++                        .getBindingContext();
++                JetProperty assignment = PsiTreeUtil.getParentOfType(currentExp, JetProperty.class);
++                JetType expectedJetType = null;
++                if (assignment != null) {
++                    expectedJetType = contextExpressions.get(BindingContext.TYPE, assignment.getTypeRef());
++                }
++                //TODO with Expected Type, if it is part of a return statement, look at return type of the function.
++
++                LinkedHashSet<String> options = new LinkedHashSet<String>();
++                for (ClassDescriptor classDesc : superClassDescs) {
++                    //ClassDescriptor currentClassDesc = classDesc;
++
++                    boolean failed = false;
++                    JetType returnType;
++                    //for (int i = 0; i < memberNames.size(); i++) {
++                                                            //should be currentClassDesc and .get(i)'s
++                        returnType = memberNameAndArgsFound(classDesc, fromClass, memberNames.get(0),
++                                                                    argsForFunction.get(0), contextExpressions);
++                        /*
++                        if (returnType == null) {
++                            failed = true;
++                            break;
++                        }
++                        //Update the class from which we see the next member.
++                        fromClass = currentClassDesc;
++                        TODO deal with generic types (especially in arrays) as the return type.
++                        currentClassDesc = DescriptorUtils.getClassDescriptorForType(returnType);
++                    }*/
++                    if (!failed && returnType != null &&
++                        (expectedJetType == null || JetTypeChecker.INSTANCE.isSubtypeOf(returnType, expectedJetType))) {
++                        options.add(""super<"" + classDesc.getName().getIdentifier() + "">"");
++                    }
++                }
++                return new SpecifySuperExplicitlyFix(superExp, options);
++            }
++        };
++    }
++
++    /*returns null if false or error occured*/
++    private static JetType memberNameAndArgsFound(@NotNull ClassDescriptor classDesc, @NotNull ClassDescriptor fromClass,","Please annotate return type as Nullable if a method may return null.
+The method name should explain what this method does (better using some verbs like 'do something') and what it returns ('memberNameAndArgsFound' returning JetType is unclear).
+",2013-05-29 11:13:58
+83,"@@ -0,0 +1,334 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.codeInsight.template.*;
++import com.intellij.openapi.editor.CaretModel;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.util.PsiTreeUtil;
++import com.intellij.refactoring.rename.inplace.MyLookupExpression;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.descriptors.*;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.lang.resolve.BindingContext;
++import org.jetbrains.jet.lang.resolve.name.Name;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.lang.types.checker.JetTypeChecker;
++import org.jetbrains.jet.plugin.JetBundle;
++import org.jetbrains.jet.plugin.caches.resolve.KotlinCacheManagerUtil;
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache;
++
++import java.util.ArrayList;
++import java.util.Collection;
++import java.util.LinkedHashSet;
++import java.util.List;
++
++public class SpecifySuperExplicitlyFix extends JetIntentionAction<JetSuperExpression> {
++    private PsiElement elementToReplace;
++    private final LinkedHashSet<String> options;
++
++
++    public SpecifySuperExplicitlyFix(@NotNull JetSuperExpression element, @NotNull LinkedHashSet<String> options) {
++        super(element);
++        elementToReplace = element;
++        this.options = options;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""specify.super.explicitly"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""specify.super.explicitly.family"");
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        return !options.isEmpty();
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) {
++        elementToReplace = elementToReplace.replace(JetPsiFactory.createExpression(project, options.iterator().next()));
++        buildAndShowTemplate(project, editor, file, elementToReplace, options);
++    }
++
++    public static JetIntentionActionFactory createFactory() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetSuperExpression superExp = QuickFixUtil.getParentElementOfType(diagnostic, JetSuperExpression.class);
++                if (superExp == null) {
++                    return null;
++                }
++
++                JetClass klass = QuickFixUtil.getParentElementOfType(diagnostic, JetClass.class);
++                if (klass == null) {
++                    return null;
++                }
++
++                JetDelegationSpecifierList superClasses = PsiTreeUtil.getChildOfType(klass, JetDelegationSpecifierList.class);
++                if (superClasses == null) {
++                    return null;
++                }
++
++                //Used for checking visibility
++                BindingContext contextClasses = KotlinCacheManagerUtil.getDeclarationsFromProject(superExp).getBindingContext();
++                ClassDescriptor fromClass = contextClasses.get(BindingContext.CLASS, klass);
++                if (fromClass == null) {
++                    return null;
++                }
++
++                //Fetch class descriptors for all super classes
++                LinkedHashSet<ClassDescriptor> superClassDescs = new LinkedHashSet<ClassDescriptor>();
++                for (JetDelegationSpecifier delSpec : superClasses.getDelegationSpecifiers()) {
++                    JetSimpleNameExpression jetRef = PsiTreeUtil.findChildOfType(delSpec.getTypeReference(), JetSimpleNameExpression.class);
++                    if (jetRef == null) {
++                        continue;
++                    }
++                    ClassDescriptor classDesc = resolveToClass(jetRef, contextClasses);
++                    if (classDesc != null) {
++                        superClassDescs.add(classDesc);
++                    }
++                }
++                if (superClassDescs.isEmpty()) {
++                    return null;
++                }
++
++                //Get the name of the member in question and other access information. The super expression
++                //MUST be a part of a dot qualified expression.
++                JetDotQualifiedExpression dotExp = QuickFixUtil.getParentElementOfType(diagnostic, JetDotQualifiedExpression.class);
++                if (dotExp == null) {
++                    return null;
++                }
++                JetExpression nextExp = dotExp;
++                JetExpression currentExp = null;
++
++                ArrayList<String> memberNames = new ArrayList<String>();
++                //contains a null in the index where the memberName at that same index is of a property.
++                ArrayList<JetValueArgumentList> argsForFunction = new ArrayList<JetValueArgumentList>();
++                while (nextExp != null && (nextExp instanceof JetDotQualifiedExpression || nextExp instanceof JetArrayAccessExpression)) {
++                    currentExp = nextExp;
++                    String memberName;
++                    JetValueArgumentList valArgs;
++
++                    if (currentExp instanceof JetDotQualifiedExpression) {
++                        JetCallExpression call = PsiTreeUtil.getChildOfType(currentExp, JetCallExpression.class);
++                        if (call != null) {
++                            JetSimpleNameExpression name = PsiTreeUtil.getChildOfType(call, JetSimpleNameExpression.class);
++                            if (name == null) {
++                                return null;
++                            }
++                            memberName = name.getText();
++                            valArgs = call.getValueArgumentList();
++                        }
++                        else {
++                            JetSimpleNameExpression name = PsiTreeUtil.getChildOfType(currentExp, JetSimpleNameExpression.class);
++                            if (name == null) {
++                                return null;
++                            }
++                            memberName = name.getText();
++                            valArgs = null;
++                        }
++                    }
++                    else {
++                        //array indexing not supported for now.
++                        return null;
++                        /**
++                        memberName = ""get""; //array indexing is the same as get function call
++
++                        JetContainerNode indexNode =  ((JetArrayAccessExpression) currentExp).getIndicesNode();
++                        JetConstantExpression constant = PsiTreeUtil.getChildOfType(indexNode, JetConstantExpression.class);
++                        JetReferenceExpression refIndex = PsiTreeUtil.getChildOfType(indexNode, JetReferenceExpression.class);
++                        if (constant == null && refIndex == null) {
++                            return null;
++                        }
++                        if (constant != null) {
++                            valArgs = JetPsiFactory.createCallArguments(diagnostic.getPsiFile()
++                            .getProject(), ""("" + constant.getText() + "")"");
++                        }
++                        else {
++                            valArgs = JetPsiFactory.createCallArguments(diagnostic.getPsiFile()
++                            .getProject(), ""("" + refIndex.getText() + "")"");
++                        }**/
++                    }
++                    memberNames.add(memberName);
++                    argsForFunction.add(valArgs);
++                    nextExp = PsiTreeUtil.getParentOfType(currentExp, JetExpression.class);
++                }
++                if (memberNames.isEmpty()) {
++                    return null;
++                }
++
++                //Right now, code has unexpected behavior with chained calls e.g. super.foo().bar.baz() so we just return null.
++                if (memberNames.size() > 1) {
++                    return null;
++                }
++
++
++                //Get the expected type of the expression if applicable (e.g. var a : Int = super.foo)
++                BindingContext contextExpressions = AnalyzerFacadeWithCache.analyzeFileWithCache((JetFile) diagnostic.getPsiFile())
++                        .getBindingContext();
++                JetProperty assignment = PsiTreeUtil.getParentOfType(currentExp, JetProperty.class);
++                JetType expectedJetType = null;
++                if (assignment != null) {
++                    expectedJetType = contextExpressions.get(BindingContext.TYPE, assignment.getTypeRef());
++                }
++                //TODO with Expected Type, if it is part of a return statement, look at return type of the function.
++
++                LinkedHashSet<String> options = new LinkedHashSet<String>();
++                for (ClassDescriptor classDesc : superClassDescs) {
++                    //ClassDescriptor currentClassDesc = classDesc;
++
++                    boolean failed = false;
++                    JetType returnType;
++                    //for (int i = 0; i < memberNames.size(); i++) {
++                                                            //should be currentClassDesc and .get(i)'s
++                        returnType = memberNameAndArgsFound(classDesc, fromClass, memberNames.get(0),
++                                                                    argsForFunction.get(0), contextExpressions);
++                        /*
++                        if (returnType == null) {
++                            failed = true;
++                            break;
++                        }
++                        //Update the class from which we see the next member.
++                        fromClass = currentClassDesc;
++                        TODO deal with generic types (especially in arrays) as the return type.
++                        currentClassDesc = DescriptorUtils.getClassDescriptorForType(returnType);
++                    }*/
++                    if (!failed && returnType != null &&
++                        (expectedJetType == null || JetTypeChecker.INSTANCE.isSubtypeOf(returnType, expectedJetType))) {
++                        options.add(""super<"" + classDesc.getName().getIdentifier() + "">"");
++                    }
++                }
++                return new SpecifySuperExplicitlyFix(superExp, options);
++            }
++        };
++    }
++
++    /*returns null if false or error occured*/
++    private static JetType memberNameAndArgsFound(@NotNull ClassDescriptor classDesc, @NotNull ClassDescriptor fromClass,
++            @NotNull String memberName,
++            @Nullable JetValueArgumentList valArgs, @NotNull BindingContext contextExpressions) {
++        if (valArgs == null) {
++            Collection<VariableDescriptor> varDescs = classDesc.getMemberScope(classDesc.getDefaultType().getArguments())
++                    .getProperties(Name.identifier(memberName));
++            return memberNamePropFound(classDesc, fromClass, varDescs);
++        }
++        else {
++            Collection<FunctionDescriptor> funDescs = classDesc.getMemberScope(classDesc.getDefaultType().getArguments())
++                    .getFunctions(Name.identifier(memberName));
++            return memberNameFuncFound(fromClass, funDescs, valArgs, contextExpressions);
++
++        }
++    }
++
++    private static JetType memberNameFuncFound(@NotNull ClassDescriptor fromClass,
++            @NotNull Collection<FunctionDescriptor> funDescs,
++            @NotNull JetValueArgumentList valArgs, @NotNull BindingContext contextExpressions) {
++        for (FunctionDescriptor fun : funDescs) {
++            if (fun.getModality() == Modality.ABSTRACT || !fun.getKind().isReal() ||
++                    !Visibilities.isVisible(fun, fromClass)) {
++                continue;
++            }
++            List<ValueParameterDescriptor> valParams = fun.getValueParameters();
++            List<JetValueArgument> jValArgs = valArgs.getArguments();
++            if (jValArgs.size() != valParams.size()) {
++                continue;
++            }
++            boolean argTypesMatch = true;
++            for (int j = 0; j < valParams.size(); j++) {
++                JetExpression expr = jValArgs.get(j).getArgumentExpression();
++                JetType subtype = contextExpressions.get(BindingContext.EXPRESSION_TYPE, expr);
++                if (subtype == null || !JetTypeChecker.INSTANCE.isSubtypeOf(subtype, valParams.get(j).getType())) {
++                    argTypesMatch = false;
++                    break;
++                }
++            }
++            if (!argTypesMatch) {
++                continue;
++            }
++            return fun.getReturnType();
++        }
++        return null;
++    }
++
++    private static JetType memberNamePropFound(@NotNull ClassDescriptor classDesc, @NotNull ClassDescriptor fromClass,
++            @NotNull Collection<VariableDescriptor> varDescs) {
++        for (VariableDescriptor var : varDescs) {
++            if (classDesc.getKind() != ClassKind.TRAIT && Visibilities.isVisible(var, fromClass)) {
++                return var.getType();
++            }
++        }
++        return null;
++    }
++
++    /*Taken and modified from MapPlatformClassToKotlinFix*/","You shouldn't copy code. You may change this method in its class or/and move it to util instead.
+",2013-05-29 11:17:36
+366,"@@ -0,0 +1,34 @@
++# Class Literals as Annotation Arguments
++
++Prior to M12 Kotlin annotation allowed parameters of type `java.lang.Class<...>` whose values could be of the form `javaClass<...>()`. 
++Since M12 both these options are deprecated, and subject to deletion in further milestones.
++
++## Annotation Parameters
++
++Annotation parameters of type `java.lang.Class<T>` are deprecated.
++
++Annotation parameters of type `kotlin.reflect.KClass<T>` are supported.
++
++A quick-fix transforming one into the other is provided.
++
++## Annotation Arguments
++
++Arguments of the form `javaClass<T>()` are deprecated.
++
++Arguments of teh form `ClassName::class` are supported.","teh -> the
+",2015-04-04 23:01:08
+367,"@@ -0,0 +1,34 @@
++# Class Literals as Annotation Arguments
++
++Prior to M12 Kotlin annotation allowed parameters of type `java.lang.Class<...>` whose values could be of the form `javaClass<...>()`. 
++Since M12 both these options are deprecated, and subject to deletion in further milestones.
++
++## Annotation Parameters
++
++Annotation parameters of type `java.lang.Class<T>` are deprecated.
++
++Annotation parameters of type `kotlin.reflect.KClass<T>` are supported.
++
++A quick-fix transforming one into the other is provided.
++
++## Annotation Arguments
++
++Arguments of the form `javaClass<T>()` are deprecated.
++
++Arguments of teh form `ClassName::class` are supported.
++
++A quick-fix transforming one into the other is provided.
++
++## Loading Annotation Classes from Java
++
++Java annotation `@interfaces` may declare methods of type `java.lang.Class<T>`. And on the JVM this is the only representation we can compile our annotations to. These should be processed specially and mapped to `kotlin.reflect.KClass<T>`. At the call sites for annotations delcared in Kotlin as well as in Java, when a property of type `KClass<T>` is accessed, we have to map its value from `java.lang.Class` to `kotlin.reflect.KClass`. Same needs to happen when we access those properties through reflection.","delcared -> declared
+",2015-04-04 23:03:41
+368,"@@ -0,0 +1,34 @@
++# Class Literals as Annotation Arguments
++
++Prior to M12 Kotlin annotation allowed parameters of type `java.lang.Class<...>` whose values could be of the form `javaClass<...>()`. 
++Since M12 both these options are deprecated, and subject to deletion in further milestones.
++
++## Annotation Parameters
++
++Annotation parameters of type `java.lang.Class<T>` are deprecated.
++
++Annotation parameters of type `kotlin.reflect.KClass<T>` are supported.
++
++A quick-fix transforming one into the other is provided.
++
++## Annotation Arguments
++
++Arguments of the form `javaClass<T>()` are deprecated.
++
++Arguments of teh form `ClassName::class` are supported.
++
++A quick-fix transforming one into the other is provided.
++
++## Loading Annotation Classes from Java
++
++Java annotation `@interfaces` may declare methods of type `java.lang.Class<T>`. And on the JVM this is the only representation we can compile our annotations to. These should be processed specially and mapped to `kotlin.reflect.KClass<T>`. At the call sites for annotations delcared in Kotlin as well as in Java, when a property of type `KClass<T>` is accessed, we have to map its value from `java.lang.Class` to `kotlin.reflect.KClass`. Same needs to happen when we access those properties through reflection.
++
++> This is unprecedented in Kotlin: never before we mapped a Java class to another *real* class, all mappings we had before were fictitious, e.g. existed at compile time only.
++
++Since it is likely to be rather common that the value of an annotation property will only be used to retrieve an instance of `java.lang.Class`, e.g. `annInstance.implClass.java`, to avoid runtime overhead, we should optimize such cases in the JVM back-end by skipping the steps of converting a `java.lamg.Class` to `KClass` and then back.
++","lamg -> lang
+",2015-04-04 23:05:23
+634,"@@ -0,0 +1,34 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInspection.CleanupLocalInspectionTool
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.psi.KtClassBody
++
++class RemoveEmptyClassBodyInspection : IntentionBasedInspection<KtClassBody>(RemoveEmptyClassBodyIntention::class), CleanupLocalInspectionTool {","If you want your inspection to run as part of code cleanup, you need to specify cleanupTool=""true"" in its XML registration.
+",2016-10-10 11:06:19
+990,"@@ -0,0 +1,34 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.adapters
++
++import org.jetbrains.kotlin.effectsystem.structure.ConstantID
++import org.jetbrains.kotlin.effectsystem.structure.ESValueID
++import org.jetbrains.kotlin.resolve.calls.smartcasts.DataFlowValue
++
++class DataFlowValueID(val dfv: DataFlowValue) : ESValueID {",Not quite sure this wrapper is needed. Can `DataFlowValue` itself serve you here?,2017-08-15 17:06:51
+800,"@@ -0,0 +1,34 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaTypeParameter
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.TypeParameterElement
++import javax.lang.model.type.TypeVariable
++
++class SymbolBasedTypeParameter<out T : TypeParameterElement>(element: T,
++                                                             javac: JavacWrapper) : SymbolBasedClassifier<T>(element, javac), JavaTypeParameter {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())",`Name.identifier`,2017-04-25 11:56:09
+801,"@@ -0,0 +1,34 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaTypeParameter
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.TypeParameterElement
++import javax.lang.model.type.TypeVariable
++
++class SymbolBasedTypeParameter<out T : TypeParameterElement>(element: T,
++                                                             javac: JavacWrapper) : SymbolBasedClassifier<T>(element, javac), JavaTypeParameter {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())
++
++    override val upperBounds
++        get() = listOf(SymbolBasedClassifierType((element.asType() as TypeVariable).upperBound, javac))",I think you should handle the case of `IntersectionType` here by expanding it into multiple bounds. `TypeVariable.getUpperBound`'s javadoc implies that this is possible here.,2017-04-25 12:04:14
+373,"@@ -0,0 +1,342 @@
++# Function Types in Kotlin on JVM
++
++## Goals
++
++* Get rid of 23 hardwired physical function classes. The problem with them is,
++reflection introduces a few kinds of functions but each of them should be invokable as a normal function as well, and so
++we get `{top-level, member, extension, member-extension, local, ...} * 23` = **a lot** of physical classes in the runtime.
++* Make extension functions coercible to normal functions (with an extra parameter).
++At the moment it's not possible to do `listOfStrings.map(String::length)`
++* Allow functions with more than 23 parameters, theoretically any number of parameters (in practice 255 on JVM).
++* At the same time, allow to implement Kotlin functions easily from Java: `new Function2() { ... }` and overriding `invoke` only would be the best.
++Enabling SAM conversions on Java 8 would also be terrific.
++
++## Brief solution overview
++
++* Treat extension functions almost like non-extension functions with one extra parameter, allowing to use them almost interchangeably.
++* Introduce a physical class `Function` and unlimited number of *fictitious* (synthetic) classes `Function0`, `Function1`, ... in the compiler front-end
++* On JVM, introduce `Function0`..`Function22`, which are optimized in a certain way,
++and `FunctionN` for functions with 23+ parameters.
++When passing a lambda to Kotlin from Java, one will need to implement one of these interfaces.
++* Also on JVM (under the hood) add abstract `FunctionImpl` which implements all of `Fun0`..`Fun22` and `FunN`
++(throwing exceptions), and which knows its arity.
++Kotlin lambdas are translated to subclasses of this abstract class, passing the correct arity to the super constructor.
++* Provide a way to get arity of an arbitrary `Function` object (pretty straightforward).
++* Hack `is/as Function5` on any numbered function in codegen (and probably `KClass.cast()` in reflection) to check against `Function` and its arity.
++
++## Extension functions
++
++Extension function type `T.(P) -> R` is now just a shorthand for `[kotlin.extension] Function2<T, P, R>`.
++`kotlin.extension` is a **type annotation** defined in built-ins.
++So effectively functions and extension functions now have the same type,
++how can we make extension function expressions support extension function call syntax?
++
++We introduce the following convention: expression `foo` of type `Foo` can be used as an extension function
++(i.e. `object.foo(arguments)`) if and only if there is a function `invokeExtension`
++with the corresponding parameters available on the type `Foo`.
++This function may be declared in class `Foo` or somewhere as an extension to `Foo`.
++
++> Note that at the moment a less convenient convention is used: there must be a **member extension**
++> function `invoke` in the class which you want to be used as an extension function.
++> This means you can't add ""extension-function-ness"" to a foreign class,
++> since you'd need to declare a function with two receivers.
++> The new approach will solve this problem.
++
++We declare `invokeExtension` to be available on all extension functions:
++
++``` kotlin
++package kotlin
++
++...
++fun <T, R> (T.() -> R).invokeExtension(): R = this()
++fun <T, P1, R> (T.(P1) -> R).invokeExtension(p1: P1): R = this(p1)
++...
++```
++
++So now an expression type-checked to an ""extension function type"" can be used with the desired syntax.
++But, since a function type and a corresponding extension function type effectively have the same classifier (e.g. `Function7`),
++they are coercible to each other and therefore our `invokeExtension` will be applicable to the usual
++functions as well, which is something we don't want to happen! Example:
++
++``` kotlin
++val lengthHacked: (String) -> Int = { it.length }
++
++fun test() = """".lengthHacked()  // <-- bad! The declared function accepts a single non-receiver argument
++                                // and is not designed to be invoked as an extension
++```
++
++And here we introduce the following **restriction**: given a call `object.foo(arguments)`,
++if `foo` is resolved **exactly** to the built-in extension function `invokeExtension`,
++then the call *will not compile* unless the receiver type is annotated with `[extension]`.
++So `invokeExtension` will yield an error when used on a normal (not extension) function.
++
++To make your class invokable as an extension you only need to declare `invokeExtension`.
++Declaring `invoke` (and maybe overriding it from the needed function class) will only make your class invokable *as a usual function*.
++Inheriting from a function type thus makes sense if you want your class to behave like a simple function.
++Inheriting from an extension function type however makes no sense and should be prohibited / frowned upon.
++In a broad sense, providing type annotations on supertypes (which is what inheriting from an extension function is)
++maybe should be diagnosed in the compiler (maybe not, more knowledge needed).
++
++With this we'll get rid of classes `ExtensionFunction0`, `ExtensionFunction1`, ...
++and the rest of this article will deal only with usual functions.
++
++## Function0, Function1, ... types
++
++The arity of the functional trait that the type checker can create in theory **is not limited** to any number,
++but in practice should be limited to 255 on JVM.
++
++These traits are named `kotlin.Function0<R>`, `kotlin.Function1<P0, R>`, ..., `kotlin.Function42<P0, P1, ..., P41, R>`, ...
++They are *fictitious*, which means they have no sources and no runtime representation.
++Type checker creates the corresponding descriptors on demand, IDE creates corresponding source files on demand as well.
++Each of them inherits from `kotlin.Function` (described below) and contains a single
++`fun invoke()` with the corresponding number of parameters and return type.
++
++> TODO: investigate exactly what changes in IDE should be done and if they are possible at all.
++
++On JVM function types are erased to the physical classes defined in package `kotlin.jvm.internal`:
++`Function0`, `Function1`, ..., `Function22` and `FunctionN` for 23+ parameters.
++
++## Function trait
++
++There's also an empty trait `kotlin.Function<R>` for cases when e.g. you're storing functions with different/unknown arity
++in a collection to invoke them reflectively somewhere else.
++
++``` kotlin
++package kotlin
++
++trait Function<out R>
++```
++
++It's a physical trait, declared in platform-agnostic built-ins, and present in `kotlin-runtime.jar` for example.
++However its declaration is **empty** and should be empty because every physical JVM function class `Function0`, `Function1`, ...
++inherits from it (and adds `invoke()`), and we don't want to override anything besides `invoke()` when doing it from Java code.
++
++## Functions with 0..22 parameters at runtime
++
++There are 23 function traits in `kotlin.platform.jvm`: `Function0`, `Function1`, ..., `Function22`.
++Here's `Function1` declaration, for example:
++
++``` kotlin
++package kotlin.platform.jvm
++
++trait Function1<in P1, out R> : kotlin.Function<R> {
++    fun invoke(p1: P1): R
++}
++```
++
++These traits are supposed to be inherited from by Java classes when passing lambdas to Kotlin.
++
++Package `kotlin.platform.jvm` is supposed to contain interfaces which help use Kotlin from Java.
++(And not from Kotlin, because normally you would use a function type there,
++most of the time even without mentioning built-in function classes: `(P1, P2, P3) -> R`.)
++
++## Translation of Kotlin lambdas
++
++There's also `FunctionImpl` abstract class at runtime which helps in implementing `arity` and vararg-invocation.
++It inherits from all the physical function classes, unfortunately (more on that later).
++
++``` kotlin
++package kotlin.jvm.internal
++
++abstract class FunctionImpl(override val arity: Int) :
++    Function<Any?>,
++    Function0<Any?>, Function1<Any?, Any?>, ..., ..., Function22<...>,
++    FunctionN   // See the next section on FunctionN
++{
++    override fun invoke(): Any? {
++        // Default implementations of all ""invoke""s invoke ""invokeVararg""
++        // This is needed for KFunctionImpl (see below)
++        assert(arity == 0)
++        return invokeVararg()
++    }
++    
++    override fun invoke(p1: Any?): Any? {
++        assert(arity == 1)
++        return invokeVararg(p1)
++    }
++    
++    ...
++    override fun invoke(p1: Any?, ..., p22: Any?) { ... }
++    
++    override fun invokeVararg(vararg p: Any?): Any? = throw UnsupportedOperationException()
++    
++    override fun toString() = ... // Some calculation involving generic runtime signatures
++}
++```
++
++> TODO: sadly, this class needs to be implemented in Java because supertypes need to be **raw** classes
++> for reflection to pick up correct generic signatures for inheritors
++
++Each lambda is compiled to an anonymous class which inherits from `FunctionImpl` and implements the corresponding `invoke`:
++
++``` kotlin
++{ (s: String): Int -> s.length }
++
++// is translated to
++
++object : FunctionImpl(2), Function2<String, Int> {","Doesn't `Function2` have 3 type parameters (2 for parameter types and 1 for return type)?
+",2015-04-08 16:13:34
+723,"@@ -0,0 +1,35 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClassifierType
++import org.jetbrains.kotlin.load.java.structure.JavaTypeParameter
++import org.jetbrains.kotlin.name.SpecialNames
++import javax.lang.model.element.TypeParameterElement
++import javax.lang.model.type.TypeVariable
++
++class JavacTypeParameter<out T : TypeParameterElement>(element: T,
++                                                       javac: Javac) : JavacClassifier<T>(element, javac), JavaTypeParameter {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(element.simpleName.toString())
++
++    override val upperBounds: Collection<JavaClassifierType>
++        get() = listOf(JavacClassifierType((element.asType() as TypeVariable).upperBound, javac))
++","In NB plugin, `equals` & `hashCode` are also implemented for this class. Should we have them here?",2017-04-05 15:17:27
+978,"@@ -0,0 +1,36 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.structure
++
++/**
++ * An abstraction of effect-generating nature of some operation.
++ *
++ * [ESFunctor] roughly corresponds to some call, but it cares only
++ * about effects of this call, so instead of value arguments, its [apply]
++ * method takes just description of effects of each argument
++ * (represented by [EffectSchema]), and produces effects of the whole call
++ * (instead of some value, compared to usual calls).
++ *
++ * Implementors should never produce non-conservative effects.
++ * However, they are not obliged to produce most precise description
++ * of effects, though they are encouraged to do so.
++ */
++
++interface ESFunctor {",May be it's better to move this into `functors` package,2017-08-15 16:27:05
+724,"@@ -0,0 +1,36 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaWildcardType
++import javax.lang.model.type.TypeMirror
++import javax.lang.model.type.WildcardType
++
++class JavacWildcardType<out T : TypeMirror>(typeMirror: T,
++                                            javac: Javac) : JavacType<T>(typeMirror, javac), JavaWildcardType {
++
++    override val bound
++        get() = typeMirror.let {
++            val boundMirror = (it as WildcardType).extendsBound ?: it.superBound
++
++            if (boundMirror != null) create(boundMirror, javac) else null","`boundMirror.let { create(it, javac) }`",2017-04-05 15:18:45
+808,"@@ -0,0 +1,36 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaWildcardType
++import javax.lang.model.type.TypeMirror
++import javax.lang.model.type.WildcardType
++
++class SymbolBasedWildcardType<out T : TypeMirror>(typeMirror: T,",Looks like generic type parameter `T` is not needed here as well. This class should just inherit from `SymbolBasedType<WildcardType>` and `typeMirror` should have the type `WildcardType`,2017-04-25 12:25:51
+797,"@@ -0,0 +1,38 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.AnnotationMirror
++import javax.lang.model.element.TypeElement
++
++open class SymbolBasedAnnotation(val annotationMirror: AnnotationMirror,
++                                 val javac: JavacWrapper) : JavaElement, JavaAnnotation {
++
++    override val arguments
++        get() = annotationMirror.elementValues
++                .map { SymbolBasedAnnotationArgument.create(it.value.value, Name.identifier(it.key.simpleName.toString()), javac) }","`.map { (key, value) -> ... }`",2017-04-25 11:47:36
+815,"@@ -0,0 +1,39 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.sun.tools.javac.util.Options
++import java.util.regex.Pattern
++
++object JavacOptionsMapper {
++
++    fun map(options: Options, arguments: List<String>) = arguments.forEach { options.putOption(it) }","Please don't use expression body syntax for `Unit`-returning functions, it's slightly confusing (I was figuring out what does this function return)",2017-04-25 12:57:47
+814,"@@ -0,0 +1,39 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.sun.tools.javac.util.Options
++import java.util.regex.Pattern
++
++object JavacOptionsMapper {
++
++    fun map(options: Options, arguments: List<String>) = arguments.forEach { options.putOption(it) }
++
++    private val optionPattern by lazy { Pattern.compile(""\\s+"") }",There's no need to make it lazy (it will be accessed anyway any time `JavacOptionsMapper.map` is called),2017-04-25 12:55:59
+816,"@@ -0,0 +1,39 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.sun.tools.javac.util.Options
++import java.util.regex.Pattern
++
++object JavacOptionsMapper {
++
++    fun map(options: Options, arguments: List<String>) = arguments.forEach { options.putOption(it) }
++
++    private val optionPattern by lazy { Pattern.compile(""\\s+"") }
++
++    private fun Options.putOption(option: String) = option
++            .split(optionPattern)
++            .filter { it.isNotEmpty() }
++            .let { arg ->
++                when(arg.size) {
++                    1 -> put(arg[0], arg[0])
++                    2 -> put(arg[0], arg[1])
++                    else -> null","`else -> null` is not needed here, I think",2017-04-25 12:58:02
+796,"@@ -0,0 +1,39 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationOwner
++import org.jetbrains.kotlin.load.java.structure.JavaClassifier
++import org.jetbrains.kotlin.name.FqName
++import javax.lang.model.element.Element
++
++abstract class SymbolBasedClassifier<out T : Element>(element: T,
++                                                      javac: JavacWrapper) : SymbolBasedElement<T>(element, javac), JavaClassifier, JavaAnnotationOwner {
++
++    override val annotations
++        get() = element.annotationMirrors
++                .map { SymbolBasedAnnotation(it, javac) }
++
++    override fun findAnnotation(fqName: FqName) = element.annotationMirrors
++            .find { it.toString() == ""@${fqName.asString()}"" }","Please avoid using `toString` in this way in production code. I don't see anything in `TypeMirror.toString`'s javadoc that would suggest that the returned string is equal to `@` + annotation type's FQ name, which means that it can change between releases. I think inspecting the type directly via `AnnotationMirror.getAnnotationType` would be more robust",2017-04-25 11:44:56
+751,"@@ -0,0 +1,39 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMember
++import org.jetbrains.kotlin.name.FqName
++
++abstract class JCMember<out T : JCTree>(tree: T,
++                                        treePath: TreePath,
++                                        override val containingClass: JavaClass,
++                                        javac: Javac) : JCElement<T>(tree, treePath, javac), JavaMember {
++
++    override val isDeprecatedInJavaDoc = false
++
++    override val annotations
++        get() = emptyList<JavaAnnotation>()
++
++    override fun findAnnotation(fqName: FqName) = annotations.firstOrNull { it.classId?.asSingleFqName() == fqName }","Again, what do you want to find in the empty list?",2017-04-05 16:20:33
+145,"@@ -0,0 +1,4 @@
++// ERROR: Too many arguments for public final fun get(index: kotlin.Int): kotlin.Int defined in kotlin.Array","I can't seem to fix the source of this error, so I declared it.
+",2014-04-07 07:49:58
+146,"@@ -0,0 +1,4 @@
++// ERROR: Too many arguments for public final fun get(index: kotlin.Int): kotlin.Int defined in kotlin.Array
++fun foo(a: Array<Int>, i: Int) {
++    a<caret>[i, { }]","This wouldn't work unless the second argument was a function. Is it still possible to give multiple indices to this construct (i.e, `a[i, 2]`)?
+",2014-04-07 07:50:36
+148,"@@ -0,0 +1,4 @@
++// ERROR: Unresolved reference: !in","I don't understand this error.
+",2014-04-07 07:51:14
+108,"@@ -0,0 +1,4 @@
++// IS_APPLICABLE: false
++fun foo(x: Foo?) {
++    x!!.<caret>get(1)
++}","Why not applicable here? `x!![1]` looks pretty okay
+",2014-02-07 18:42:01
+48,"@@ -0,0 +1,40 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.jet.lang.psi.JetClass;
++import org.jetbrains.jet.lang.psi.JetFile;
++import org.jetbrains.jet.lang.psi.JetPsiFactory;
++import org.jetbrains.jet.plugin.JetBundle;","A lot of not optimized imports.
+When committing, check that you your code is green (no warnings). If you edit some code, assure that you don't introduce new warnings.
+",2013-04-26 11:09:38
+481,"@@ -0,0 +1,40 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.incremental.components.LookupTracker
++import org.jetbrains.kotlin.incremental.components.ScopeKind
++import org.jetbrains.kotlin.rmi.CompileService
++import org.jetbrains.kotlin.rmi.LoopbackNetworkInterface
++import org.jetbrains.kotlin.rmi.SOCKET_ANY_FREE_PORT
++import java.rmi.server.UnicastRemoteObject
++
++
++public class RemoteLookupTrackerServer(val base: LookupTracker, port: Int = SOCKET_ANY_FREE_PORT) : CompileService.RemoteLookupTracker {
++
++    init {
++        UnicastRemoteObject.exportObject(this, port, LoopbackNetworkInterface.clientLoopbackSocketFactory, LoopbackNetworkInterface.serverLoopbackSocketFactory)
++    }
++
++    override fun record(lookupContainingFile: String, lookupLine: Int?, lookupColumn: Int?, scopeFqName: String, scopeKind: ScopeKind, name: String) {
++        base.record(lookupContainingFile, lookupLine, lookupColumn, scopeFqName, scopeKind, name)
++    }
++
++    private val _isDoNothing: Boolean = base == LookupTracker.DO_NOTHING","I think underscore is not needed here
+",2015-09-23 14:51:55
+772,"@@ -0,0 +1,40 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.descriptors.ConstructorDescriptor
++import org.jetbrains.kotlin.descriptors.PropertyDescriptor
++import org.jetbrains.kotlin.descriptors.SimpleFunctionDescriptor
++import org.jetbrains.kotlin.load.java.components.AbstractJavaResolverCache
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.resolve.lazy.ResolveSession
++
++class JavacBasedJavaResolverCache(resolveSession: ResolveSession) : AbstractJavaResolverCache(resolveSession) {",May be we should name it like `StubJavaResolverCache`. The thing here is obviously not javac based.,2017-04-20 10:18:00
+713,"@@ -0,0 +1,40 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationOwner
++import org.jetbrains.kotlin.load.java.structure.JavaClassifier
++import org.jetbrains.kotlin.name.FqName
++import javax.lang.model.element.Element
++
++abstract class JavacClassifier<out T : Element>(element: T,
++                                                javac: Javac) : JavacElement<T>(element, javac), JavaClassifier, JavaAnnotationOwner {
++
++    override val annotations: Collection<JavaAnnotation>
++            get() = element.annotationMirrors
++                    .map { JavacAnnotation(it, javac) }
++
++    override fun findAnnotation(fqName: FqName): JavaAnnotation? = element.annotationMirrors
++            .filter { it.toString() == fqName.asString() }
++            .firstOrNull()
++            ?.let { JavacAnnotation(it, javac) }
++
++    override val isDeprecatedInJavaDoc = false",Why always false?,2017-04-05 14:55:04
+616,"@@ -0,0 +1,40 @@
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++
++class TooLongCharLiteralToStringFix(
++        element: KtConstantExpression
++) : KotlinQuickFixAction<KtConstantExpression>(element) {
++    override fun getText(): String = ""Convert too long character literal to string""
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val text = element.text
++        if (!(text.startsWith(""'"") && text.endsWith(""'"") && text.length >= 2)) {
++            return
++        }
++
++        val newStringContent = text
++                .slice(1..text.length - 2)
++                .replace(""\\"", ""\\\\"")","For me it's suspicious. We can have a literal like `'Bye\n'` and expect to get `""Bye\n""` as result, so I'd not touch these back slashes. Please add a test for such case.
+",2016-09-22 10:49:05
+617,"@@ -0,0 +1,40 @@
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++
++class TooLongCharLiteralToStringFix(
++        element: KtConstantExpression
++) : KotlinQuickFixAction<KtConstantExpression>(element) {
++    override fun getText(): String = ""Convert too long character literal to string""
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val text = element.text
++        if (!(text.startsWith(""'"") && text.endsWith(""'"") && text.length >= 2)) {
++            return
++        }
++
++        val newStringContent = text
++                .slice(1..text.length - 2)
++                .replace(""\\"", ""\\\\"")
++                .replace(""\"""", ""\\\"""")","Changing double quote to escaped double quote is logical, I think it should be left as is.
+",2016-09-22 10:49:57
+615,"@@ -0,0 +1,40 @@
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++
++class TooLongCharLiteralToStringFix(
++        element: KtConstantExpression
++) : KotlinQuickFixAction<KtConstantExpression>(element) {
++    override fun getText(): String = ""Convert too long character literal to string""
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val text = element.text
++        if (!(text.startsWith(""'"") && text.endsWith(""'"") && text.length >= 2)) {
++            return
++        }
++
++        val newStringContent = text
++                .slice(1..text.length - 2)
++                .replace(""\\"", ""\\\\"")
++                .replace(""\"""", ""\\\"""")
++        val newElement = KtPsiFactory(element).createStringTemplate(newStringContent)","What happens if we have character literal like `'$x'` ? Should we get `""$x""` or `""\$x""`? I'd say the first case (without dollar escaping) is more logical, but I'd add a test for it.
+",2016-09-22 10:48:02
+613,"@@ -0,0 +1,40 @@
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++
++class TooLongCharLiteralToStringFix(
++        element: KtConstantExpression
++) : KotlinQuickFixAction<KtConstantExpression>(element) {
++    override fun getText(): String = ""Convert too long character literal to string""
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val text = element.text
++        if (!(text.startsWith(""'"") && text.endsWith(""'"") && text.length >= 2)) {
++            return
++        }
++
++        val newStringContent = text
++                .slice(1..text.length - 2)
++                .replace(""\\"", ""\\\\"")
++                .replace(""\"""", ""\\\"""")
++        val newElement = KtPsiFactory(element).createStringTemplate(newStringContent)
++
++        element.replace(newElement)
++    }
++
++    override fun getFamilyName(): String = ""Strings""","Usually `= text` is in use here.
+",2016-09-22 10:44:22
+749,"@@ -0,0 +1,41 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaPackage
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++
++class JCPackage(val name: String, val javac: Javac) : JavaPackage {
++
++    override val fqName: FqName
++        get() = FqName(name)",Consider making it an initializer and remove getter,2017-04-05 16:15:12
+834,"@@ -0,0 +1,41 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaPackage
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++
++class TreeBasedPackage(val name: String, val javac: JavacWrapper) : JavaPackage {","Similarly to `SymbolBasedPackage`, I think it can inherit from `SymbolBasedElement` and avoid overriding `equals`/`hashCode`/`toString`",2017-04-25 16:41:11
+833,"@@ -0,0 +1,41 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaPackage
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++
++class TreeBasedPackage(val name: String, val javac: JavacWrapper) : JavaPackage {
++
++    override val fqName
++        get() = FqName(name)
++
++    override val subPackages
++        get() = javac.findSubPackages(fqName)
++
++    override fun getClasses(nameFilter: (Name) -> Boolean) = javac.findClassesFromPackage(fqName)","Shouldn't `TreeBasedPackage` contain only `TreeBasedClass`es, and `SymbolBasedPackage` -- only `SymbolBasedClass`es?",2017-04-25 16:40:20
+704,"@@ -0,0 +1,42 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.kotlin.KotlinBinaryClassCache
++import org.jetbrains.kotlin.load.kotlin.KotlinJvmBinaryClass
++import org.jetbrains.kotlin.load.kotlin.VirtualFileFinder
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.wrappers.trees.computeClassId
++
++
++abstract class JavacVirtualFileFinder : VirtualFileFinder() {
++
++    override fun findKotlinClass(javaClass: JavaClass): KotlinJvmBinaryClass? {
++        var file = javaClass.computeClassId()?.let(this::findVirtualFileWithHeader) ?: return null
++
++        if (javaClass.outerClass != null) {
++            // For nested classes we get a file of the containing class, to get the actual class file for A.B.C,
++            // we take the file for A, take its parent directory, then in this directory we look for A$B$C.class
++            file = file.parent!!.findChild(classFileName(javaClass) + "".class"").sure { ""Virtual file not found for $javaClass"" }","Again, it's better not to repeat the same code. Extract some protected function from `VirtualFileFinder`",2017-04-05 13:02:31
+703,"@@ -0,0 +1,42 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.kotlin.KotlinBinaryClassCache
++import org.jetbrains.kotlin.load.kotlin.KotlinJvmBinaryClass
++import org.jetbrains.kotlin.load.kotlin.VirtualFileFinder
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.wrappers.trees.computeClassId
++
++
++abstract class JavacVirtualFileFinder : VirtualFileFinder() {
++
++    override fun findKotlinClass(javaClass: JavaClass): KotlinJvmBinaryClass? {
++        var file = javaClass.computeClassId()?.let(this::findVirtualFileWithHeader) ?: return null
++
++        if (javaClass.outerClass != null) {
++            // For nested classes we get a file of the containing class, to get the actual class file for A.B.C,
++            // we take the file for A, take its parent directory, then in this directory we look for A$B$C.class
++            file = file.parent!!.findChild(classFileName(javaClass) + "".class"").sure { ""Virtual file not found for $javaClass"" }
++        }
++
++        return KotlinBinaryClassCache.getKotlinBinaryClass(file)
++    }
++
++    inline fun <T : Any> T?.sure(message: () -> String): T = this ?: throw AssertionError(message())",This function already exists (anyway you will not need it after processing the previous comment),2017-04-05 13:00:31
+765,"@@ -0,0 +1,42 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.LowPriorityAction
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.KtDeclaration
++import org.jetbrains.kotlin.psi.KtFunction
++import org.jetbrains.kotlin.psi.KtProperty
++import org.jetbrains.kotlin.psi.psiUtil.getNonStrictParentOfType
++
++class AddOpenModifierIntention : SelfTargetingIntention<KtDeclaration>(KtDeclaration::class.java, ""Make open""), LowPriorityAction {
++    override fun isApplicableTo(element: KtDeclaration, caretOffset: Int): Boolean {
++        if (element.hasModifier(KtTokens.OPEN_KEYWORD) || element.hasModifier(KtTokens.PRIVATE_KEYWORD)) return false
++        when (element) {
++            is KtProperty -> if (element.isLocal) return false
++            is KtFunction -> if (element.isLocal) return false
++        }
++        val ktClass = element.getNonStrictParentOfType<KtClass>() ?: return false
++        return ktClass.hasModifier(KtTokens.OPEN_KEYWORD)","Things are not so easy here. First of all, there is `KtDeclaration.implicitModality()`, please use it. For example, interface functions with body are implicitly open and do not require explicit open modifier. Also, you need `containingClassOrObject` and not `getNonStrictParentOfType<KtClass>`, you are risking to miss e.g. companion object in the middle this way. Remember also that object / interface members should never have `open` added, as well as top-level guys. And at last, class can have `open` members if it's `open`, `abstract` or `sealed` itself, I'd not limit it to just open classes as described in an issue. ",2017-04-18 06:59:02
+812,"@@ -0,0 +1,42 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaPackage
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.PackageElement
++
++class SymbolBasedPackage(val element: PackageElement, val javac: JavacWrapper) : JavaPackage {",Why doesn't it inherit from `SymbolBasedElement` to get `equals`/`hashCode`/`toString` for free?,2017-04-25 12:33:45
+555,"@@ -0,0 +1,43 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.psi.KtPsiFactory
++
++class AddRunToLambdaFix(element: KtLambdaExpression) : KotlinQuickFixAction<KtLambdaExpression>(element) {
++    override fun getText() = ""Add 'run' before the lambda expression""
++    override fun getFamilyName() = ""Add 'run' before the lambda expression""","`= getText()`
+",2016-05-06 15:32:20
+804,"@@ -0,0 +1,43 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import javax.lang.model.element.ElementKind
++import javax.lang.model.element.VariableElement
++
++class SymbolBasedField<out T : VariableElement>(element: T,
++                                                javac: JavacWrapper) : SymbolBasedMember<T>(element, javac), JavaField {
++
++    override val isEnumEntry
++        get() = element.kind == ElementKind.ENUM_CONSTANT
++
++    override val type
++        get() = SymbolBasedType.create(element.asType(), javac)
++
++    override val initializerValue: Any?
++        get() = element.constantValue
++
++    override val hasConstantNotNullInitializer
++        get() = element.constantValue?.let {
++            val typeMirror = type.typeMirror
++
++            (typeMirror.kind.isPrimitive || typeMirror.toString() == ""java.lang.String"")","Please inspect the underlying element instead of `toString`.
+",2017-04-25 12:16:15
+788,"@@ -0,0 +1,43 @@
++package test
++
++public/*package*/ open class ExtendsAbstractListT {
++    public/*package*/ constructor ExtendsAbstractListT()
++}
++
++public abstract class Mine</*0*/ T> : java.util.AbstractList<T> {
++    public constructor Mine</*0*/ T>()
++    protected/*protected and package*/ final /*fake_override*/ var modCount: kotlin.Int
++    public abstract /*fake_override*/ val size: kotlin.Int
++    public open /*fake_override*/ fun add(/*0*/ T!): kotlin.Boolean
++    public open /*fake_override*/ fun add(/*0*/ kotlin.Int, /*1*/ T!): kotlin.Unit
++    public open /*fake_override*/ fun addAll(/*0*/ kotlin.Int, /*1*/ kotlin.collections.Collection<T!>): kotlin.Boolean
++    public open /*fake_override*/ fun addAll(/*0*/ kotlin.collections.Collection<T!>): kotlin.Boolean
++    public open /*fake_override*/ fun clear(): kotlin.Unit
++    public open /*fake_override*/ fun contains(/*0*/ T!): kotlin.Boolean
++    public open /*fake_override*/ fun containsAll(/*0*/ kotlin.collections.Collection<T!>): kotlin.Boolean
++    public open /*fake_override*/ fun forEach(/*0*/ java.util.function.Consumer<in T!>!): kotlin.Unit","Do I understand correctly that `xxx2.txt` differs from `xxx.txt` only in members that come from Java 8 and this is caused by the fact that the original test was run against JDK 6, but the test with javac is run against JDK 8?
+
+I suggest just using JDK 8 then in both tests, to avoid complicating things too much.",2017-04-25 10:04:28
+717,"@@ -0,0 +1,44 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaPackage
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.PackageElement
++
++class JavacPackage(val element: PackageElement, val javac: Javac) : JavaPackage {
++
++    override val fqName
++        get() = element.qualifiedName.let { FqName(it.toString()) }",I'd consider removing `let` from this and next getter. I suppose code without it will be easier to read,2017-04-05 15:07:21
+718,"@@ -0,0 +1,44 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaPackage
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.PackageElement
++
++class JavacPackage(val element: PackageElement, val javac: Javac) : JavaPackage {
++
++    override val fqName
++        get() = element.qualifiedName.let { FqName(it.toString()) }
++
++    override val subPackages
++        get() = javac.findSubPackages(element.qualifiedName.toString().let(::FqName))
++
++    override fun getClasses(nameFilter: (Name) -> Boolean) = javac.findClassesFromPackage(fqName)
++            .filter { Name.isValidIdentifier(it.name.toString())
++                      && nameFilter(Name.identifier(it.name.toString()))
++            }
++
++    override fun hashCode() = element.hashCode()
++
++    override fun equals(other: Any?) = (other as? JavacPackage)?.element == element",Why do you need to override `equals` from `JavacElement` here?,2017-04-05 15:07:52
+426,"@@ -0,0 +1,45 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr","It seems this file should be placed in the appropriate subdirectory in order to get rid of warning about file location?
+",2015-08-20 14:48:32
+417,"@@ -0,0 +1,45 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.rmi.RemoteOutputStream
++import java.io.OutputStream
++import java.rmi.server.UnicastRemoteObject
++
++
++class RemoteOutputStreamServer(val out: OutputStream) : RemoteOutputStream {","`: RemoteOutputStream by out`
+",2015-08-20 13:33:53
+425,"@@ -0,0 +1,45 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.kotlinr
++
++import org.jetbrains.kotlin.rmi.RemoteOutputStream
++import java.io.OutputStream
++import java.rmi.server.UnicastRemoteObject
++
++
++class RemoteOutputStreamServer(val out: OutputStream) : RemoteOutputStream {
++
++    init {
++        UnicastRemoteObject.exportObject(this, 0)
++    }
++
++    public fun disconnect() {
++        UnicastRemoteObject.unexportObject(this, true)
++    }
++
++    override fun close() {
++        out.close()
++    }
++
++    override fun write(data: ByteArray, start: Int, length: Int) {","`start` -> `offset` (as in the supertype) in order to get rid of corresponding warning.
+",2015-08-20 14:45:47
+109,"@@ -0,0 +1,46 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import org.jetbrains.jet.lang.psi.JetQualifiedExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetValueArgument
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++
++
++public class BracketToGetIntention : JetSelfTargetingIntention<JetArrayAccessExpression>(""bracket.to.get"", javaClass()) {
++    override fun isApplicableTo(element: JetArrayAccessExpression): Boolean {
++        return element is JetArrayAccessExpression
++    }
++
++    override fun applyTo(element: JetArrayAccessExpression, editor: Editor) {
++        val array = element.getArrayExpression()!!
++        val indices = element.getIndexExpressions()
++
++        val arrayText = array.getText()
++        val indicesText = indices.map { it.getText() }.makeString("", "")","This line feels like a hack. It also doesn't preserve comments. Is there any way to get the contents of the indices without losing comments?
+",2014-02-08 22:34:13
+583,"@@ -0,0 +1,46 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor.wordSelection
++
++import com.intellij.codeInsight.editorActions.ExtendWordSelectionHandlerBase
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElement
++import org.jetbrains.kotlin.psi.KtTypeReference
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class KotlinFunctionReturnTypeSelectioner : ExtendWordSelectionHandlerBase() {
++
++    override fun canSelect(e: PsiElement?): Boolean {
++        return e is KtTypeReference
++    }
++
++    override fun select(e: PsiElement?, editorText: CharSequence?, cursorOffset: Int, editor: Editor): List<TextRange>? {
++        e ?: return null
++        editorText ?: return null
++        val position = getColonPosition(e, editorText)
++        if (position < 0) return null
++        return listOf(TextRange(position, e.endOffset))
++    }
++
++    private fun getColonPosition(e: PsiElement, editorText: CharSequence): Int {
++        val colonIndex = editorText.filterIndexed { i, c -> i < e.startOffset }.indexOfLast { it == ':' }","Please do not use the text or regular expressions to perform the action. All the necessary information is available in the PSI; please do use it.
+",2016-07-18 20:59:44
+655,"@@ -0,0 +1,46 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtForExpression
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.createExpressionByPattern
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++
++class ConvertRangeCheckToTwoComparisonsIntention : SelfTargetingOffsetIndependentIntention<KtBinaryExpression>(KtBinaryExpression::class.java, ""Convert to comparisons"") {
++    override fun applyTo(element: KtBinaryExpression, editor: Editor?) {
++        if (element.operationToken != KtTokens.IN_KEYWORD) return
++        val rangeExpression = element.right as? KtBinaryExpression ?: return
++        val min = rangeExpression.left?.text ?: return
++        val arg = element.left?.text ?: return
++        val max: Any = rangeExpression.right?.text ?: return",Why do you need `Any` here?,2016-12-13 10:24:27
+654,"@@ -0,0 +1,46 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtForExpression
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.createExpressionByPattern
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++
++class ConvertRangeCheckToTwoComparisonsIntention : SelfTargetingOffsetIndependentIntention<KtBinaryExpression>(KtBinaryExpression::class.java, ""Convert to comparisons"") {
++    override fun applyTo(element: KtBinaryExpression, editor: Editor?) {
++        if (element.operationToken != KtTokens.IN_KEYWORD) return
++        val rangeExpression = element.right as? KtBinaryExpression ?: return
++        val min = rangeExpression.left?.text ?: return
++        val arg = element.left?.text ?: return
++        val max: Any = rangeExpression.right?.text ?: return
++        val comparisonsExpression = KtPsiFactory(element).createExpressionByPattern(""$0 <= $1 && $1 <= $2"", min, arg, max)
++        element.replace(comparisonsExpression)
++    }
++
++    override fun isApplicableTo(element: KtBinaryExpression): Boolean {
++        if (element.operationToken != KtTokens.IN_KEYWORD) return false
++        // ignore for-loop. for(x in 1..2) should not be convert to for(1<=x && x<=2)
++        if (element.getStrictParentOfType<KtForExpression>() != null) return false","I'd say this condition is too strict. E.g. your intention will not work for code like
+
+```
+for (element in list) {
+    if (element in 1..4) { ... }
+}
+```",2016-12-13 10:23:40
+542,"@@ -0,0 +1,47 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.codegen.intrinsics
++
++import org.jetbrains.kotlin.codegen.ExpressionCodegen
++import org.jetbrains.kotlin.codegen.StackValue
++import org.jetbrains.kotlin.descriptors.ConstructorDescriptor
++import org.jetbrains.kotlin.psi.KtCallableReferenceExpression
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
++import org.jetbrains.kotlin.resolve.jvm.AsmTypes
++import org.jetbrains.kotlin.resolve.scopes.receivers.ExpressionReceiver
++import org.jetbrains.org.objectweb.asm.Type
++
++class KCallableNameProperty : IntrinsicPropertyGetter() {
++    override fun generate(resolvedCall: ResolvedCall<*>?, codegen: ExpressionCodegen, returnType: Type, receiver: StackValue): StackValue? {
++        val expressionReceiver = resolvedCall!!.dispatchReceiver as? ExpressionReceiver ?: return null
++        val expression = expressionReceiver.expression as? KtCallableReferenceExpression ?: return null
++        val callableReference = expression.callableReference
++        val descriptor = callableReference.getResolvedCall(codegen.bindingContext)?.resultingDescriptor ?: return null
++
++        val name = if (descriptor is ConstructorDescriptor) {","`descriptor.name.asString()`
+",2016-04-22 19:46:23
+782,"@@ -0,0 +1,47 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.load.java
++
++import org.jetbrains.kotlin.load.java.structure.impl.JavaPackageImpl
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.CodeAnalyzerInitializer
++import org.jetbrains.kotlin.resolve.jvm.KotlinJavaPsiFacade
++import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
++
++import javax.annotation.PostConstruct
++
++class JavaClassFinderImpl : AbstractJavaClassFinder() {
++
++    private lateinit var javaFacade: KotlinJavaPsiFacade
++
++    @PostConstruct
++    fun initialize(trace: BindingTrace, codeAnalyzer: KotlinCodeAnalyzer) {
++        javaSearchScope = FilterOutKotlinSourceFilesScope(baseScope)",Please extract the first and the third line of this method into `AbstractJavaClassFinder.initialize` and call it here and in `JavacBasedClassFinder.initialize`,2017-04-25 08:08:33
+783,"@@ -0,0 +1,47 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.load.java
++
++import org.jetbrains.kotlin.load.java.structure.impl.JavaPackageImpl
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.CodeAnalyzerInitializer
++import org.jetbrains.kotlin.resolve.jvm.KotlinJavaPsiFacade
++import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
++
++import javax.annotation.PostConstruct
++
++class JavaClassFinderImpl : AbstractJavaClassFinder() {
++
++    private lateinit var javaFacade: KotlinJavaPsiFacade
++
++    @PostConstruct
++    fun initialize(trace: BindingTrace, codeAnalyzer: KotlinCodeAnalyzer) {
++        javaSearchScope = FilterOutKotlinSourceFilesScope(baseScope)
++        javaFacade = KotlinJavaPsiFacade.getInstance(proj)
++        CodeAnalyzerInitializer.getInstance(proj).initialize(trace, codeAnalyzer.moduleDescriptor, codeAnalyzer)
++    }
++
++
++    override fun findClass(classId: ClassId) = javaFacade.findClass(classId, javaSearchScope)",Please do not omit return types at least where inspections are reported (there's an inspection about platform type here).,2017-04-25 08:10:49
+903,"@@ -0,0 +1,47 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.LowPriorityAction
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.inspections.UnusedSymbolInspection
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.idea.util.findAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.KtNamedFunction
++import org.jetbrains.kotlin.psi.KtObjectDeclaration
++
++class AddJvmStaticIntention : SelfTargetingIntention<KtNamedFunction>(
++    KtNamedFunction::class.java,
++    ""Add '@JvmStatic' annotation""
++), LowPriorityAction {
++
++    private val annotationFqName = FqName(""kotlin.jvm.JvmStatic"")
++
++    override fun isApplicableTo(element: KtNamedFunction, caretOffset: Int): Boolean {
++        if (element.findAnnotation(annotationFqName) != null) return false
++        if (!UnusedSymbolInspection.isEntryPoint(element)) return false",See `KotlinRunLineMarkerContributor` for the correct way to check that a function is `main`.,2017-07-17 11:21:50
+904,"@@ -0,0 +1,47 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.LowPriorityAction
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.inspections.UnusedSymbolInspection
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.idea.util.findAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.KtNamedFunction
++import org.jetbrains.kotlin.psi.KtObjectDeclaration
++
++class AddJvmStaticIntention : SelfTargetingIntention<KtNamedFunction>(
++    KtNamedFunction::class.java,
++    ""Add '@JvmStatic' annotation""
++), LowPriorityAction {
++
++    private val annotationFqName = FqName(""kotlin.jvm.JvmStatic"")
++
++    override fun isApplicableTo(element: KtNamedFunction, caretOffset: Int): Boolean {
++        if (element.findAnnotation(annotationFqName) != null) return false
++        if (!UnusedSymbolInspection.isEntryPoint(element)) return false
++        element.parent.parent.run {",Please use `KtDeclaration.containingClassOrObject`.,2017-07-17 11:23:10
+469,"@@ -0,0 +1,48 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.io.IOException
++import java.io.Serializable
++import java.net.InetAddress
++import java.net.ServerSocket
++import java.net.Socket
++import java.rmi.server.RMIClientSocketFactory
++import java.rmi.server.RMIServerSocketFactory
++
++
++// TODO switch to InetAddress.getLoopbackAddress on java 7+
++val loopbackAddrName by lazy { if (java.net.InetAddress.getLocalHost() is java.net.Inet6Address) ""::1"" else ""127.0.0.1"" }","`java.net.InetAddress.getLocalHost()` may crash with IOException (actually, UnknownHostException) on some machines due to strange network configuration. Notice that it is not a wrong machine configuration but Java's limitation. In some cases it couldn't be fixed on some corporate machines. I faced it few times in different companies. It is possible at least on Linux and Solaris machines
+",2015-09-08 18:13:12
+750,"@@ -0,0 +1,48 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.load.java.structure.JavaValueParameter
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++
++class JCValueParameter<out T : JCTree.JCVariableDecl>(tree: T,
++                                                      treePath: TreePath,
++                                                      javac: Javac) : JCElement<T>(tree, treePath, javac), JavaValueParameter {
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = emptyList()",Value parameter in Java can have annotations,2017-04-05 16:17:43
+584,"@@ -0,0 +1,49 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor.wordSelection
++
++import com.intellij.codeInsight.editorActions.ExtendWordSelectionHandlerBase
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElement
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.KtSuperTypeList
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class KotlinSuperTypeSelectioner : ExtendWordSelectionHandlerBase() {
++    override fun canSelect(e: PsiElement?): Boolean {
++        return e is KtSuperTypeList
++    }
++
++    override fun select(e: PsiElement?, editorText: CharSequence?, cursorOffset: Int, editor: Editor): List<TextRange>? {
++        e ?: return null","Those parameters are actually non-null. You don't need the null checks here and in the other selectioner.
+",2016-07-22 18:17:04
+585,"@@ -0,0 +1,49 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.editor.wordSelection
++
++import com.intellij.codeInsight.editorActions.ExtendWordSelectionHandlerBase
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElement
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.KtSuperTypeList
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class KotlinSuperTypeSelectioner : ExtendWordSelectionHandlerBase() {
++    override fun canSelect(e: PsiElement?): Boolean {
++        return e is KtSuperTypeList
++    }
++
++    override fun select(e: PsiElement?, editorText: CharSequence?, cursorOffset: Int, editor: Editor): List<TextRange>? {
++        e ?: return null
++        editorText ?: return null
++        val colonPosition = getColonPosition(e)
++        if (colonPosition < 0) return null
++        return listOf(TextRange(colonPosition, e.endOffset))
++    }
++
++    private fun getColonPosition(e: PsiElement): Int {
++        var parent = e.parent","You can use the `PsiElement.getParentOfType()` extension function to do this with less code.
+",2016-07-22 18:17:50
+818,"@@ -0,0 +1,49 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaTypeParameter
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedTypeParameter<out T : JCTree.JCTypeParameter>(tree: T,
++                                                             treePath: TreePath,
++                                                             javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaTypeParameter {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.name.toString())",`Name.identifier`,2017-04-25 13:09:56
+819,"@@ -0,0 +1,49 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaTypeParameter
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.SpecialNames
++
++class TreeBasedTypeParameter<out T : JCTree.JCTypeParameter>(tree: T,
++                                                             treePath: TreePath,
++                                                             javac: JavacWrapper) : TreeBasedElement<T>(tree, treePath, javac), JavaTypeParameter {
++
++    override val name
++        get() = SpecialNames.safeIdentifier(tree.name.toString())
++
++    override val annotations by lazy { tree.annotations().map { TreeBasedAnnotation(it, treePath, javac) } }
++
++    override fun findAnnotation(fqName: FqName) = annotations.firstOrNull { it.classId?.asSingleFqName() == fqName }
++
++    override val isDeprecatedInJavaDoc
++        get() = findAnnotation(FqName(""java.lang.Deprecated"")) != null",You should return `false` here and in other implementations of `isDeprecatedInJavaDoc`. The call site looks for the annotation itself if needed,2017-04-25 13:23:18
+147,"@@ -0,0 +1,5 @@
++// ERROR: Unresolved reference: array","I don't understand this error.
+",2014-04-07 07:51:03
+623,"@@ -0,0 +1,5 @@
++<html>
++<body>
++    This intention detects 'Math.max' calls that can be safely replaced with 'coerceAtLeast'","This intention replaces 'Math.max' calls with safe 'coerceAtLeast' ... or something like. Inspection detects, but inspection does some change.
+",2016-09-26 10:58:15
+560,"@@ -0,0 +1,5 @@
++<html>
++<body>
++Reports unnecessary java usage.","This is not clear. A better description would be ""Use of Java API that has a Kotlin equivalent"" or something like that.
+",2016-05-18 13:22:55
+631,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This inspection remove an empty class body","reports and offers to remove
+",2016-10-10 11:02:44
+659,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This inspection reports unused equals expression.",expression**s**,2016-12-23 09:31:28
+621,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This intention detects 'Math.max' calls that can be safely replaced with 'coerceAtLeast'","inspection
+",2016-09-26 10:56:49
+622,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This intention detects 'Math.min' calls that can be safely replaced with 'coerceAtMost'","inspection
+",2016-09-26 10:56:58
+632,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This intention detects an empty class body.","removes
+",2016-10-10 11:04:11
+186,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This intention makes types explicit in a lambda expression.","A little elaboration won't hurt: `types of parameters, receiver and return type`
+",2014-04-16 23:44:55
+187,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This intention makes types implicit in a lambda expression","Ditto
+",2014-04-16 23:45:02
+101,"@@ -0,0 +1,5 @@
++<html>
++<body>
++This intention take a qualified call to any function ""get"" which has some arguments and converts it to square brackets.","""takes""
+",2014-02-06 14:39:06
+511,"@@ -0,0 +1,5 @@
++fun box(): String {
++    val sub = Box<Long>(-1)
++    println(sub.value == 1L)","replace 'println' with if check
+",2016-02-09 08:34:22
+224,"@@ -0,0 +1,5 @@
++if (<spot>foo()</spot>) {
++    bar()
++} else {
++    baz()
++}","The branches aren't swapped in the after-template
+",2014-05-03 10:49:59
+955,"@@ -0,0 +1,5 @@
++package org.junit
++
++@Deprecated(""Use 'Ignore' from kotlin.test package"", replaceWith = ReplaceWith(""Ignore"", imports = ""kotlin.test.Ignore""))
++@Suppress(""HEADER_WITHOUT_IMPLEMENTATION"")
++header annotation class Ignore",I'm working on not needing this...,2017-08-11 20:44:29
+786,"@@ -0,0 +1,50 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.AbstractJavaClassFinder
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.CodeAnalyzerInitializer
++import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
++import javax.annotation.PostConstruct
++
++class JavacBasedClassFinder : AbstractJavaClassFinder() {
++
++    private lateinit var javac: JavacWrapper
++
++    @PostConstruct
++    fun initialize(trace: BindingTrace, codeAnalyzer: KotlinCodeAnalyzer) {
++        javaSearchScope = FilterOutKotlinSourceFilesScope(baseScope)
++        javac = JavacWrapper.getInstance(proj)
++        CodeAnalyzerInitializer.getInstance(proj).initialize(trace, codeAnalyzer.moduleDescriptor, codeAnalyzer)
++    }
++
++    override fun findClass(classId: ClassId) = javac.findClass(classId.asSingleFqName(), javaSearchScope)","Note that `ClassId.asSingleFqName` is an operation that loses some information, namely where package name in the `FqName` ends and where the class name starts. For example, `FqName` ""a.b.c"" might mean class c nested in class b in package a, or it might mean class c in package a.b.
+
+Please consider either using `ClassId` when possible, or at least destructuring it into package FQ name and relative class name and using them, to avoid problems related to resolution of nested classes.",2017-04-25 08:25:38
+785,"@@ -0,0 +1,50 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.AbstractJavaClassFinder
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.CodeAnalyzerInitializer
++import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
++import javax.annotation.PostConstruct
++
++class JavacBasedClassFinder : AbstractJavaClassFinder() {
++
++    private lateinit var javac: JavacWrapper
++
++    @PostConstruct
++    fun initialize(trace: BindingTrace, codeAnalyzer: KotlinCodeAnalyzer) {
++        javaSearchScope = FilterOutKotlinSourceFilesScope(baseScope)
++        javac = JavacWrapper.getInstance(proj)
++        CodeAnalyzerInitializer.getInstance(proj).initialize(trace, codeAnalyzer.moduleDescriptor, codeAnalyzer)
++    }
++
++    override fun findClass(classId: ClassId) = javac.findClass(classId.asSingleFqName(), javaSearchScope)
++
++    override fun findPackage(fqName: FqName) = javac.findPackage(fqName, javaSearchScope)
++
++    override fun knownClassNamesInPackage(packageFqName: FqName): Set<String> = javac.findClassesFromPackage(packageFqName)
++            .mapNotNullTo(hashSetOf()) {
++                it.fqName?.let {
++                    if (it.isRoot) it.asString() else it.shortName().asString()","Multiple `it`s in nested lambdas are dangerous and confusing, please rename at least one of them",2017-04-25 08:18:38
+887,"@@ -0,0 +1,50 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.psi.*
++
++class RemoveRedundantBackticksInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitCallExpression(expression: KtCallExpression) {","Why is this limited to call expressions? Backticks can be used around any occurrence of identifier in Kotlin code, and the inspection should detect those in any context.",2017-07-10 09:03:51
+888,"@@ -0,0 +1,50 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.psi.*
++
++class RemoveRedundantBackticksInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitCallExpression(expression: KtCallExpression) {
++                super.visitCallExpression(expression)
++                val calleeExpression = expression.calleeExpression ?: return
++                if (calleeExpression.text.contains(""^`.+`$"".toRegex())) {","This detects any backticks, not just redundant backticks. Backticks are redundant only if they enclose a valid identifier (not a keyword and not containing any invalid characters).",2017-07-10 09:04:46
+755,"@@ -0,0 +1,51 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.AbstractJavaClassFinder
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.CodeAnalyzerInitializer
++import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
++import javax.annotation.PostConstruct
++
++class JavacBasedClassFinder : AbstractJavaClassFinder() {
++
++    private lateinit var javac: JavacWrapper
++
++    @PostConstruct
++    fun initialize(trace: BindingTrace, codeAnalyzer: KotlinCodeAnalyzer) {
++        javaSearchScope = FilterOutKotlinSourceFilesScope(baseScope)
++        javac = JavacWrapper.getInstance(proj)
++        CodeAnalyzerInitializer.getInstance(proj).initialize(trace, codeAnalyzer.moduleDescriptor, codeAnalyzer)
++    }
++
++    override fun findClass(classId: ClassId) = javac.findClass(classId.asSingleFqName(), javaSearchScope)
++
++    override fun findPackage(fqName: FqName) = javac.findPackage(fqName, javaSearchScope)
++
++    override fun knownClassNamesInPackage(packageFqName: FqName) = javac.findClassesFromPackage(packageFqName)
++            .mapNotNull {","Here you can use `mapNotNullTo` without `toSet` at the end, it may be a bit faster",2017-04-11 10:03:58
+933,"@@ -0,0 +1,51 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.util.PsiTreeUtil
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.getNonStrictParentOfType
++
++class RemoveUselessIsCheckFixForWhen(element: KtWhenConditionIsPattern) : KotlinQuickFixAction<KtWhenConditionIsPattern>(element) {
++    override fun getFamilyName() = ""Remove useless is check""
++
++    override fun getText(): String = familyName
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val condition = element ?: return
++        val whenEntry = condition.parent as KtWhenEntry
++        val whenExpression = whenEntry.parent as KtWhenExpression
++
++        if (condition.isNegated) {
++            condition.parent.delete()
++        } else {
++            whenExpression.entries.forEach { it.delete() }","You should not delete all entries here, but only subsequent ones. E.g.
+
+```
+val something: Base = ...
+when (something) {
+    is Derived -> forDerived()
+    is Base /* always true */ -> forBase()
+    is Any /* unreachable */ -> forAny()
+    is SomethingWrong /* also unreachable */ forWrong()
+    else -> forElse()
+}
+```
+
+Here `is Base` branch must be left intact.",2017-07-26 14:59:07
+404,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package kotlin.collections","Why not `package kotlin`?
+",2015-07-29 17:28:08
+639,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.refactoring.rename.RenameProcessor
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.visibilityModifier
++
++class ValToObjectIntention : SelfTargetingIntention<KtProperty>(KtProperty::class.java, ""Convert to object declaration"") {
++
++    override fun isApplicableTo(element: KtProperty, caretOffset: Int): Boolean {
++        if (element.isVar) return false
++        if (!element.isTopLevel) return false
++        if (element.initializer !is KtObjectLiteralExpression) return false
++        if (element.getter != null) return false
++
++        return true
++    }
++
++    override fun applyTo(element: KtProperty, editor: Editor?) {
++        val modifier = element.visibilityModifier()","You're losing all annotations on the original property. (I think that it would be best not to offer the intention if the property has any, because the semantics of annotations on a `val` and an `object` is significantly different.)
+",2016-10-14 10:53:34
+640,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.refactoring.rename.RenameProcessor
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.visibilityModifier
++
++class ValToObjectIntention : SelfTargetingIntention<KtProperty>(KtProperty::class.java, ""Convert to object declaration"") {
++
++    override fun isApplicableTo(element: KtProperty, caretOffset: Int): Boolean {
++        if (element.isVar) return false
++        if (!element.isTopLevel) return false
++        if (element.initializer !is KtObjectLiteralExpression) return false
++        if (element.getter != null) return false
++
++        return true
++    }
++
++    override fun applyTo(element: KtProperty, editor: Editor?) {
++        val modifier = element.visibilityModifier()
++        val name = element.name ?: return
++        val o = element.initializer as? KtObjectLiteralExpression ?: return
++        val od = o.objectDeclaration
++        val superTypeList = od.getSuperTypeList() ?: return","I think you should check the supertype list in `isApplicableTo` as well, so that you don't end up with an intention which is enabled and does nothing.
+",2016-10-14 10:54:38
+638,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.refactoring.rename.RenameProcessor
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.visibilityModifier
++
++class ValToObjectIntention : SelfTargetingIntention<KtProperty>(KtProperty::class.java, ""Convert to object declaration"") {
++
++    override fun isApplicableTo(element: KtProperty, caretOffset: Int): Boolean {
++        if (element.isVar) return false
++        if (!element.isTopLevel) return false
++        if (element.initializer !is KtObjectLiteralExpression) return false
++        if (element.getter != null) return false
++
++        return true
++    }
++
++    override fun applyTo(element: KtProperty, editor: Editor?) {
++        val modifier = element.visibilityModifier()
++        val name = element.name ?: return
++        val o = element.initializer as? KtObjectLiteralExpression ?: return
++        val od = o.objectDeclaration
++        val superTypeList = od.getSuperTypeList() ?: return
++        val body = od.getBody() ?: return
++
++        val prefix = modifier?.text?.plus("" "") ?: """"
++        val replacementText = ""${prefix}object $name: ${superTypeList.text} ${body.text}""
++        val replaced = element.replaced(KtPsiFactory(element).createDeclarationByPattern<KtObjectDeclaration>(replacementText))
++
++        RenameProcessor(element.project, replaced, name.capitalize(), false, false).doRun()","I think that automatically changing the name without user input is not a very good idea. It's better to trigger a rename refactoring where the user inputs the name, initialized with the capitalized version of the old name.
+",2016-10-14 10:51:49
+625,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.psi.KtCallExpression
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++
++class ReplaceMathMaxWithCoerceAtLeastInspection : IntentionBasedInspection<KtCallExpression>(ReplaceMathMaxWithCoerceAtLeastIntention::class)
++
++class ReplaceMathMaxWithCoerceAtLeastIntention() : SelfTargetingOffsetIndependentIntention<KtCallExpression>(","I think abstract class should be extracted from this intention and the next one. Too many similar code inside
+",2016-09-26 11:04:32
+624,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.psi.KtCallExpression
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameUnsafe
++
++class ReplaceMathMaxWithCoerceAtLeastInspection : IntentionBasedInspection<KtCallExpression>(ReplaceMathMaxWithCoerceAtLeastIntention::class)
++
++class ReplaceMathMaxWithCoerceAtLeastIntention() : SelfTargetingOffsetIndependentIntention<KtCallExpression>(
++        KtCallExpression::class.java, ""Replace Math.max with coerceAtLeast"") {
++
++    override fun applyTo(element: KtCallExpression, editor: Editor?) {
++        val target = element.getStrictParentOfType<KtDotQualifiedExpression>() ?: element
++        val valueArguments = element.valueArguments
++        val newExpression = KtPsiFactory(element).createExpression(""${valueArguments[0].text}.coerceAtLeast(${valueArguments[1].text})"")
++        target.replaced(newExpression)
++    }
++
++    override fun isApplicableTo(element: KtCallExpression) = isMaxMethod(element)
++
++    private fun isMaxMethod(element: KtCallExpression) =
++            element.calleeExpression?.text == ""max"" && element.valueArguments.size == 2 && element.isMethodCall(""java.lang.Math.max"")
++
++    private fun KtCallExpression.isMethodCall(fqMethodName: String): Boolean {","You have the same method in `ReplaceMathMinWithCoerceAtMostIntention`. It would make more sense to pull it out in a Utils class.
+",2016-09-26 11:01:50
+802,"@@ -0,0 +1,52 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationArgument
++import org.jetbrains.kotlin.load.java.structure.JavaArrayAnnotationArgument
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.AnnotationMirror
++import javax.lang.model.element.AnnotationValue
++import javax.lang.model.element.VariableElement
++import javax.lang.model.type.TypeMirror
++
++open class SymbolBasedAnnotationArgument(private val fqName: FqName,","Annotation argument has no FQ name, a `Name` should be enough",2017-04-25 12:06:23
+721,"@@ -0,0 +1,53 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationOwner
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.FqName
++import javax.lang.model.type.TypeKind
++import javax.lang.model.type.TypeMirror
++
++open class JavacType<out T : TypeMirror>(val typeMirror: T,
++                                         val javac: Javac) : JavaType, JavaAnnotationOwner {
++
++    companion object {
++        fun <TM : TypeMirror> create(t: TM, javac: Javac) = when {
++            t.kind.isPrimitive || t.toString() == ""void"" -> JavacPrimitiveType(t, javac)",Why the second part is needed? Looks like `TypeMirror` for `void` also should be primitive? You can also consider extracting this condition as `if` and continue with `when (t.kind)`.,2017-04-05 15:13:45
+722,"@@ -0,0 +1,53 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationOwner
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.FqName
++import javax.lang.model.type.TypeKind
++import javax.lang.model.type.TypeMirror
++
++open class JavacType<out T : TypeMirror>(val typeMirror: T,
++                                         val javac: Javac) : JavaType, JavaAnnotationOwner {
++
++    companion object {
++        fun <TM : TypeMirror> create(t: TM, javac: Javac) = when {
++            t.kind.isPrimitive || t.toString() == ""void"" -> JavacPrimitiveType(t, javac)
++            t.kind == TypeKind.DECLARED || t.kind == TypeKind.TYPEVAR -> JavacClassifierType(t, javac)
++            t.kind == TypeKind.WILDCARD -> JavacWildcardType(t, javac)
++            t.kind == TypeKind.ARRAY -> JavacArrayType(t, javac)
++            else -> throw UnsupportedOperationException(""Unsupported type: $t"")
++        }
++    }
++
++    override val annotations: Collection<JavaAnnotation> = emptyList()
++
++    override val isDeprecatedInJavaDoc
++            get() = false
++
++    override fun findAnnotation(fqName: FqName) = null",`annotations` and `findAnnotation` are implemented in a different way in NB plugin,2017-04-05 15:15:17
+744,"@@ -0,0 +1,53 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaConstructor
++import org.jetbrains.kotlin.name.Name
++
++class JCConstructor<out T : JCTree.JCMethodDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 containingClass: JavaClass,
++                                                 javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaConstructor {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract",Constructor never can be abstract,2017-04-05 16:06:44
+742,"@@ -0,0 +1,53 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaConstructor
++import org.jetbrains.kotlin.name.Name
++
++class JCConstructor<out T : JCTree.JCMethodDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 containingClass: JavaClass,
++                                                 javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaConstructor {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic",Constructor never can be static,2017-04-05 16:05:51
+743,"@@ -0,0 +1,53 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaConstructor
++import org.jetbrains.kotlin.name.Name
++
++class JCConstructor<out T : JCTree.JCMethodDecl>(tree: T,
++                                                 treePath: TreePath,
++                                                 containingClass: JavaClass,
++                                                 javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaConstructor {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal",Also it never can be overridable. Not sure should it be considered as `final` or not.,2017-04-05 16:06:27
+739,"@@ -0,0 +1,54 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.Name
++
++class JCField<out T : JCTree.JCVariableDecl>(tree: T,
++                                             treePath: TreePath,
++                                             containingClass: JavaClass,
++                                             javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaField {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = if (containingClass.isInterface) true else tree.modifiers.isStatic",`containingClass.isInterface || tree.modifiers.isStatic`,2017-04-05 16:00:34
+790,"@@ -0,0 +1,54 @@
++package test
++
++public final annotation class AByte : kotlin.Annotation {
++    public constructor AByte(/*0*/ kotlin.Byte)
++    public final val value: kotlin.Byte
++}
++
++public final annotation class AChar : kotlin.Annotation {
++    public constructor AChar(/*0*/ kotlin.Char)
++    public final val value: kotlin.Char
++}
++
++public final annotation class ADouble : kotlin.Annotation {
++    public constructor ADouble(/*0*/ kotlin.Double)
++    public final val value: kotlin.Double
++}
++
++public final annotation class AFloat : kotlin.Annotation {
++    public constructor AFloat(/*0*/ kotlin.Float)
++    public final val value: kotlin.Float
++}
++
++public final annotation class AInt : kotlin.Annotation {
++    public constructor AInt(/*0*/ kotlin.Int)
++    public final val value: kotlin.Int
++}
++
++public final annotation class ALong : kotlin.Annotation {
++    public constructor ALong(/*0*/ kotlin.Long)
++    public final val value: kotlin.Long
++}
++
++public final annotation class AString : kotlin.Annotation {
++    public constructor AString(/*0*/ kotlin.String)
++    public final val value: kotlin.String
++}
++
++@test.AString(value = ""Test"") @test.AChar(value = \u0063 ('c')) @test.AInt(value = 10) @test.AByte(value = 11.toByte()) @test.ALong(value = 12.toLong()) @test.ADouble(value = 1.2.toDouble()) @test.AFloat(value = 1.3.toFloat()) public open class AnnotationTrait {",Ditto (`@test.AByte(value = 11.toByte())` vs `@test.AByte(value = 11)`),2017-04-25 10:10:53
+552,"@@ -0,0 +1,55 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.idea.refactoring.changeSignature.KotlinValVar
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtNameReferenceExpression
++import org.jetbrains.kotlin.psi.KtParameter
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.psiUtil.getAssignmentByLHS
++import org.jetbrains.kotlin.psi.psiUtil.getPrimaryConstructorParameterWithSameName
++
++class MakeConstructorParameterPropertyFix(element: KtParameter, private val kotlinValVar: KotlinValVar) : KotlinQuickFixAction<KtParameter>(element) {
++    override fun getFamilyName() = ""Make primary constructor parameter a property""
++    override fun getText() = ""Make primary constructor parameter '${element.name}' a property""","In the case when we're updating an outer class, it'd be better to show the name of that class in the inspection text.
+",2016-04-28 09:08:47
+781,"@@ -0,0 +1,55 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.load.java
++
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.search.DelegatingGlobalSearchScope
++import com.intellij.psi.search.GlobalSearchScope
++import org.jetbrains.kotlin.idea.KotlinFileType
++import javax.inject.Inject
++
++abstract class AbstractJavaClassFinder : JavaClassFinder {
++
++    protected lateinit var proj: Project",Please rename to `project`,2017-04-25 08:06:05
+811,"@@ -0,0 +1,55 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationOwner
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.FqName
++import javax.lang.model.type.TypeKind
++import javax.lang.model.type.TypeMirror
++
++open class SymbolBasedType<out T : TypeMirror>(val typeMirror: T,
++                                               val javac: JavacWrapper) : JavaType, JavaAnnotationOwner {
++
++    companion object {
++        fun <TM : TypeMirror> create(t: TM, javac: JavacWrapper) = when {
++            t.kind.isPrimitive || t.toString() == ""void"" -> SymbolBasedPrimitiveType(t, javac)",`t.kind.isPrimitive || t.kind == TypeKind.VOID -> ...`,2017-04-25 12:30:40
+770,"@@ -0,0 +1,55 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotationOwner
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.FqName
++
++abstract class JCType<out T : JCTree>(val tree: T,
++                                      val treePath: TreePath,
++                                      val javac: JavacWrapper) : JavaType, JavaAnnotationOwner {
++
++    companion object {
++        fun <Type : JCTree> create(tree: Type, treePath: TreePath, javac: JavacWrapper) = when (tree) {
++            is JCTree.JCPrimitiveTypeTree -> JCPrimitiveType(tree, TreePath(treePath, tree), javac)
++            is JCTree.JCArrayTypeTree -> JCArrayType(tree, TreePath(treePath, tree), javac)
++            is JCTree.JCWildcard -> JCWildcardType(tree, TreePath(treePath, tree), javac)
++            is JCTree.JCTypeApply -> JCClassifierTypeWithTypeArgument(tree, TreePath(treePath, tree), javac)
++            is JCTree.JCExpression -> JCClassifierType(tree, TreePath(treePath, tree), javac)
++            else -> throw UnsupportedOperationException(""Unsupported type: $tree"")
++        }
++    }
++
++    override val annotations
++        get() = emptyList<JCAnnotation>()",Are you sure this list should be empty? In `JavaTypeImpl` it's not so,2017-04-20 10:03:55
+789,"@@ -0,0 +1,55 @@
++package test
++
++public final annotation class AByte : kotlin.Annotation {
++    public constructor AByte(/*0*/ kotlin.Byte)
++    public final val value: kotlin.Byte
++}
++
++public final annotation class AChar : kotlin.Annotation {
++    public constructor AChar(/*0*/ kotlin.Char)
++    public final val value: kotlin.Char
++}
++
++public final annotation class ADouble : kotlin.Annotation {
++    public constructor ADouble(/*0*/ kotlin.Double)
++    public final val value: kotlin.Double
++}
++
++public final annotation class AFloat : kotlin.Annotation {
++    public constructor AFloat(/*0*/ kotlin.Float)
++    public final val value: kotlin.Float
++}
++
++public final annotation class AInt : kotlin.Annotation {
++    public constructor AInt(/*0*/ kotlin.Int)
++    public final val value: kotlin.Int
++}
++
++public final annotation class ALong : kotlin.Annotation {
++    public constructor ALong(/*0*/ kotlin.Long)
++    public final val value: kotlin.Long
++}
++
++public final annotation class AString : kotlin.Annotation {
++    public constructor AString(/*0*/ kotlin.String)
++    public final val value: kotlin.String
++}
++
++@test.AString(value = ""Test"") @test.AChar(value = \u0063 ('c')) @test.AInt(value = 10) @test.AByte(value = 11.toByte()) @test.ALong(value = 12.toLong()) @test.ADouble(value = 1.2.toDouble()) @test.AFloat(value = 1.3.toFloat()) public open class AnnotationClass {","Why is there `@test.AByte(value = 11.toByte())`, but only `@test.AByte(value = 11)` in the main test data, is worth investigating, I think. Loading annotation arguments with different types than what is done now might break some invariants in the compiler",2017-04-25 10:10:17
+112,"@@ -0,0 +1,56 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }
++        val jetBlockElement = element.findBlockInExpression(element)","Obviously, won't work for `else`
+",2014-02-21 16:37:14
+113,"@@ -0,0 +1,56 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }
++        val jetBlockElement = element.findBlockInExpression(element)
++        if (jetBlockElement != null) return false
++
++        setText(""Add braces to '$conditionText' statement"")
++        return true
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val bodyElement = when (element) {","""bodyNode"" would be a better name
+",2014-02-21 16:37:24
+114,"@@ -0,0 +1,56 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }
++        val jetBlockElement = element.findBlockInExpression(element)
++        if (jetBlockElement != null) return false
++
++        setText(""Add braces to '$conditionText' statement"")
++        return true
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val bodyElement = when (element) {
++            is JetIfExpression -> element.getNode().findChildByType(JetNodeTypes.THEN)
++            else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++        }
++        val bodyText = bodyElement?.getText()
++        val newElement = bodyElement?.getPsi()?.getPrevSibling()?.replace(JetPsiFactory.createExpression(element.getProject(), ""{\n $bodyText \n}""))","You are replace element before expression with block, and then add whitespace. Why not replace expression with block directly? Also, this works incorrectly for `if (true)println()`
+",2014-02-21 16:37:56
+115,"@@ -0,0 +1,56 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }
++        val jetBlockElement = element.findBlockInExpression(element)
++        if (jetBlockElement != null) return false
++
++        setText(""Add braces to '$conditionText' statement"")
++        return true
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val bodyElement = when (element) {
++            is JetIfExpression -> element.getNode().findChildByType(JetNodeTypes.THEN)
++            else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++        }
++        val bodyText = bodyElement?.getText()
++        val newElement = bodyElement?.getPsi()?.getPrevSibling()?.replace(JetPsiFactory.createExpression(element.getProject(), ""{\n $bodyText \n}""))
++        newElement?.getParent()?.addBefore(JetPsiFactory.createWhiteSpace(element.getProject()), newElement)
++        bodyElement?.getPsi()?.delete()","Am I right that this sequence of safe calls is only because bodyElement can be null? Shouldn't it be checked in `isApplicable`? Otherwise there can be case when intention is available i UI, but will have no effect, which is confusing.
+Side note: if some condition is to hard to check in isApplicable, it's a good idea to show error message.
+",2014-02-21 16:38:23
+116,"@@ -0,0 +1,57 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++
++
++public class RemoveBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""remove.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }","Duplicate code.
+",2014-02-21 16:39:03
+117,"@@ -0,0 +1,57 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++
++
++public class RemoveBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""remove.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }
++        val jetBlockElement = element.findBlockInExpression(element)
++        if (jetBlockElement == null) return false
++
++        if (jetBlockElement.getStatements().size == 1) {
++            setText(""Remove braces from '$conditionText' statement"")
++            return true
++        }
++        return false
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val jetBlockElement = element.findBlockInExpression(element)
++        val newElement = jetBlockElement?.replace(JetPsiFactory.createExpression(element.getProject(), jetBlockElement?.getStatements()?.first?.getText()))","Safe call is redundant: we already checked for null in `isApplicable`.
+",2014-02-21 16:39:17
+118,"@@ -0,0 +1,57 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++
++
++public class RemoveBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""remove.braces"", javaClass()) {
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        val conditionText = when (element) {
++            is JetIfExpression -> ""if""
++            is JetWhileExpression -> ""while""
++            is JetDoWhileExpression -> ""do...while""
++            is JetForExpression -> ""for""
++            else -> return false
++        }
++        val jetBlockElement = element.findBlockInExpression(element)
++        if (jetBlockElement == null) return false
++
++        if (jetBlockElement.getStatements().size == 1) {
++            setText(""Remove braces from '$conditionText' statement"")
++            return true
++        }
++        return false
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val jetBlockElement = element.findBlockInExpression(element)
++        val newElement = jetBlockElement?.replace(JetPsiFactory.createExpression(element.getProject(), jetBlockElement?.getStatements()?.first?.getText()))
++        if (element is JetDoWhileExpression) {
++            newElement?.getParent()?.addAfter(JetPsiFactory.createNewLine(element.getProject()), newElement)
++        }","Redundant safe calls again
+",2014-02-21 16:39:25
+418,"@@ -0,0 +1,58 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi
++
++import java.rmi.Remote
++import java.rmi.RemoteException
++
++public interface CompileService : Remote {
++
++    public enum class OutputFormat : java.io.Serializable {
++        PLAIN,
++        XML
++    }
++
++    public interface RemoteIncrementalCache : Remote {
++        throws(RemoteException::class)","Do we really need all those `throws` annotations?
+",2015-08-20 13:36:25
+938,"@@ -0,0 +1,58 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiNameIdentifierOwner
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.idea.core.deleteElementAndCleanParent
++import org.jetbrains.kotlin.psi.KtDeclaration
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtProperty
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.psiUtil.getNonStrictParentOfType
++
++/**",Please don't add `@author` tags to the code,2017-08-03 09:55:21
+939,"@@ -0,0 +1,58 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiNameIdentifierOwner
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.idea.core.deleteElementAndCleanParent
++import org.jetbrains.kotlin.psi.KtDeclaration
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtProperty
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.psiUtil.getNonStrictParentOfType
++
++/**
++ * @author Andrius Semionovas
++ * @since 2017-07-31
++ */
++class ReplaceInitializerWithGetterFix(element: KtProperty): KotlinQuickFixAction<KtProperty>(element) {",We already have `ConvertPropertyInitializerToGetterIntention` which is offered as an intention action in this context; you should be able to reuse it directly.,2017-08-03 10:00:57
+807,"@@ -0,0 +1,58 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaMember
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.Element
++import javax.lang.model.element.TypeElement
++
++abstract class SymbolBasedMember<out T : Element>(element: T,
++                                                  javac: JavacWrapper) : SymbolBasedElement<T>(element, javac), JavaMember {
++
++    override val containingClass
++        get() = SymbolBasedClass((element.enclosingElement as TypeElement), javac)
++
++    override val annotations
++        get() = element.annotationMirrors
++                .map { SymbolBasedAnnotation(it, javac) }
++
++    override fun findAnnotation(fqName: FqName) = element.annotationMirrors
++            .find { it.toString() == ""@${fqName.asString()}"" }","Please deduplicate this with `SymbolBasedClassifier.findAnnotation`, `SymbolBasedValueParameter.findAnnotation`, `SymbolBasedType.findAnnotation`",2017-04-25 12:24:08
+865,"@@ -0,0 +1,59 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.psi.KtAnnotationEntry
++import org.jetbrains.kotlin.psi.KtCallableDeclaration
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++
++class MoveReceiverAnnotationFix(element: KtAnnotationEntry) : KotlinQuickFixAction<KtAnnotationEntry>(element) {
++
++    override fun getFamilyName() = ""Move annotation to receiver type""
++    override fun getText() = familyName
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val element = element ?: return
++
++        val declaration = element.getParentOfType<KtCallableDeclaration>(true) ?: return
++        val receiverTypeRef = declaration.receiverTypeReference ?: return
++
++        receiverTypeRef.addAnnotationEntry(element)
++        element.delete()
++    }
++
++    companion object Factory : KotlinSingleIntentionActionFactory() {
++        override fun createAction(diagnostic: Diagnostic): IntentionAction? {
++            val diag = Errors.INAPPLICABLE_RECEIVER_TARGET.cast(diagnostic)
++            val entry = diag.psiElement as? KtAnnotationEntry ?: return null
++
++            val declaration = entry.getParentOfType<KtCallableDeclaration>(true) ?: return null
++            if (declaration.receiverTypeReference == null) return null
++
++            return MoveReceiverAnnotationFix(entry)
++        }
++    }
++}
++
++fun String.foo() {",Looks like not-deleted trash. I'll remove it.,2017-05-30 12:43:08
+759,"@@ -0,0 +1,59 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.name.Name
++
++class JCMethod<out T : JCTree.JCMethodDecl>(tree: T,
++                                            treePath: TreePath,
++                                            containingClass: JavaClass,
++                                            javac: JavacWrapper) : JCMember<T>(tree, treePath, containingClass, javac), JavaMethod {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract",What about interface members? (not sure it's important),2017-04-11 10:25:49
+554,"@@ -0,0 +1,6 @@
++// ""Add 'run' before the lambda expression"" ""true""
++// ERROR: Unresolved reference: run","You can add WITH_RUNTIME directive so that the `run` function will be resolved correctly.
+",2016-05-06 15:32:01
+908,"@@ -0,0 +1,6 @@
++// ""Remove useless is check"" ""false""
++fun foo(a: String) {
++    when (1) {
++        <caret>is Int -> { }","Well, it's an exceptional case but here we can also do something :). If a condition in when branch is definitely true, we can replace the condition with `else` and delete all subsequent branches because they are unreachable anyway. If the condition is definitely false (add test for this case), we can delete this when branch.",2017-07-18 11:04:58
+648,"@@ -0,0 +1,6 @@
++// WITH_RUNTIME
++// IS_APPLICABLE: true
++
++fun Int.foo() {
++    +1","This transformation does not look correct for me. I would expect `this + 1` as a result here,
+",2016-11-07 09:19:00
+214,"@@ -0,0 +1,6 @@
++//ERROR: Unresolved reference: SortedMap
++fun a(b: SortedMap<Int, String>) {
++    for ((index, c) in b.withIndices()) {","I'm not sure what's happening here because `SortedMap` is not an iterable/stream/array, so it doesn't have `withIndices` extension and the intention should not be applicable on it as well as on `Map`
+",2014-04-30 18:41:11
+614,"@@ -0,0 +1,6 @@
++public class Foo {
++    private native final void nativeMethod()","Please avoid irrelevant syntax errors in testdata. Java does require semicolons :)
+",2016-09-22 10:46:28
+746,"@@ -0,0 +1,60 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.Name
++
++class JCMethod<out T : JCTree.JCMethodDecl>(tree: T,
++                                            treePath: TreePath,
++                                            containingClass: JavaClass,
++                                            javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaMethod {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())",This can be extracted into `JCMember`,2017-04-05 16:09:38
+747,"@@ -0,0 +1,60 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.Name
++
++class JCMethod<out T : JCTree.JCMethodDecl>(tree: T,
++                                            treePath: TreePath,
++                                            containingClass: JavaClass,
++                                            javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaMethod {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract","Non-static methods in interface are `abstract` by default. However in Java 1.8+ they are not abstract if `default` modifier exists. Here we have complex logic, so be accurate, please.",2017-04-05 16:10:50
+748,"@@ -0,0 +1,60 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.Name
++
++class JCMethod<out T : JCTree.JCMethodDecl>(tree: T,
++                                            treePath: TreePath,
++                                            containingClass: JavaClass,
++                                            javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaMethod {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal",I think interface methods are never `final`,2017-04-05 16:13:37
+745,"@@ -0,0 +1,60 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.load.java.structure.JavaType
++import org.jetbrains.kotlin.name.Name
++
++class JCMethod<out T : JCTree.JCMethodDecl>(tree: T,
++                                            treePath: TreePath,
++                                            containingClass: JavaClass,
++                                            javac: Javac) : JCMember<T>(tree, treePath, containingClass, javac), JavaMethod {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = tree.modifiers.isStatic
++
++    override val isFinal
++        get() = tree.modifiers.isFinal
++
++    override val visibility",This can be extracted into `JCMember`,2017-04-05 16:08:46
+548,"@@ -0,0 +1,61 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.LowPriorityAction
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.project.ProjectStructureUtil
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.idea.util.findAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++
++private val annotationFqName = FqName(""kotlin.jvm.JvmOverloads"")
++
++class AddJvmOverloadsIntention : SelfTargetingIntention<KtParameterList>(
++        KtParameterList::class.java, ""Add '@JvmOverloads' annotation""","I think that all intentions that modify the declaration of a function need to be available on the function name. Showing this only on the parameter list is confusing
+",2016-04-28 08:47:01
+549,"@@ -0,0 +1,61 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.LowPriorityAction
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.project.ProjectStructureUtil
++import org.jetbrains.kotlin.idea.util.addAnnotation
++import org.jetbrains.kotlin.idea.util.findAnnotation
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.*
++
++private val annotationFqName = FqName(""kotlin.jvm.JvmOverloads"")
++
++class AddJvmOverloadsIntention : SelfTargetingIntention<KtParameterList>(
++        KtParameterList::class.java, ""Add '@JvmOverloads' annotation""
++), LowPriorityAction {
++
++    override fun isApplicableTo(element: KtParameterList, caretOffset: Int): Boolean {
++        val parent = element.parent as? KtModifierListOwner ?: return false
++        val target = when (parent) {
++            is KtNamedFunction -> ""function '${parent.name}'""
++            is KtPrimaryConstructor -> ""primary constructor""
++            is KtSecondaryConstructor -> ""secondary constructor""
++            else -> return false
++        }
++        text = ""Add '@JvmOverloads' annotation to $target""
++
++        return !ProjectStructureUtil.isJsKotlinModule(element.getContainingKtFile())","If a constructor has one parameter with a default value, adding @JvmOverloads won't modify the resulting bytecode in any way, so the intention shouldn't be displayed.
+",2016-04-28 08:47:42
+910,"@@ -0,0 +1,61 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.KtWhenExpression
++import org.jetbrains.kotlin.resolve.bindingContextUtil.isUsedAsExpression
++
++class WhenWithOnlyElseInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitWhenExpression(expression: KtWhenExpression) {
++                super.visitWhenExpression(expression)",You don't actually need the `super` call here.,2017-07-24 12:39:59
+911,"@@ -0,0 +1,61 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.KtWhenExpression
++import org.jetbrains.kotlin.resolve.bindingContextUtil.isUsedAsExpression
++
++class WhenWithOnlyElseInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitWhenExpression(expression: KtWhenExpression) {
++                super.visitWhenExpression(expression)
++
++                val singleEntry = expression.entries.singleOrNull()
++                if (singleEntry?.isElse != true) return
++
++                val usedAsExpression = expression.isUsedAsExpression(expression.analyze())
++
++                holder.registerProblem(expression,
++                                       ""'when' has only 'else' branch and can be simplified"",
++                                       SimplifyFix(usedAsExpression)
++                )
++            }
++        }
++    }
++
++    private class SimplifyFix(
++            private val isUsedAsExpression: Boolean
++    ) : LocalQuickFix {
++        override fun getFamilyName() = name
++
++        override fun getName() = ""Simplify expression""
++
++        override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
++            val whenExpression = descriptor.psiElement as? KtWhenExpression ?: return",Please don't forget `FileModificationService.getInstance().preparePsiElementForWrite()`,2017-07-24 12:42:50
+799,"@@ -0,0 +1,61 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.JavaVisibilities
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.*
++
++val Element.isAbstract",Please mark such declarations as `internal` (those that are only used from this module). Also in the other `utils.kt`,2017-04-25 11:51:32
+798,"@@ -0,0 +1,61 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.JavaVisibilities
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.*
++
++val Element.isAbstract
++    get() = modifiers.contains(Modifier.ABSTRACT)
++
++val Element.isStatic
++    get() = modifiers.contains(Modifier.STATIC)
++
++val Element.isFinal
++    get() = modifiers.contains(Modifier.FINAL)
++
++fun Element.getVisibility() = when {
++    Modifier.PUBLIC in modifiers -> Visibilities.PUBLIC
++    Modifier.PRIVATE in modifiers -> Visibilities.PRIVATE
++    Modifier.PROTECTED in modifiers -> {
++        if (Modifier.STATIC in modifiers) {
++            JavaVisibilities.PROTECTED_STATIC_VISIBILITY
++        }
++        else {
++            JavaVisibilities.PROTECTED_AND_PACKAGE
++        }
++    }
++    else -> JavaVisibilities.PACKAGE_VISIBILITY
++}
++
++fun TypeElement.computeClassId(): ClassId? {
++    if (enclosingElement.kind != ElementKind.PACKAGE) {
++        val parentClassId = (enclosingElement as TypeElement).computeClassId() ?: return null
++        return parentClassId.createNestedClassId(Name.identifier(simpleName.toString()))
++    }
++
++    return ClassId.topLevel(FqName(qualifiedName.toString()))
++}
++
++fun ExecutableElement.valueParameters(javac: JavacWrapper) = parameters.mapIndexed { index, it ->
++    SymbolBasedValueParameter(it, it.simpleName.toString(), (index == parameters.size - 1) && isVarArgs, javac)",`index == parameters.lastIndex`,2017-04-25 11:49:57
+619,"@@ -0,0 +1,63 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions.copyConcatenatedStringToClipboard
++
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.collectDescendantsOfType
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++
++class ConcatenatedStringGenerator {
++    fun create(element: KtBinaryExpression): String {
++        val binaryExpression = getBinaryParentExpression(element)
++        val stringBuilder = StringBuilder()
++        create(binaryExpression, stringBuilder)
++        return stringBuilder.toString()
++    }
++
++    private fun getBinaryParentExpression(element: KtBinaryExpression): KtBinaryExpression {
++        var binaryExpression = element.getStrictParentOfType<KtBinaryExpression>() ?: return element","There is `getTopmostParentOfTypes`, I think it should work here
+",2016-09-22 10:56:09
+620,"@@ -0,0 +1,63 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions.copyConcatenatedStringToClipboard
++
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.collectDescendantsOfType
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++
++class ConcatenatedStringGenerator {
++    fun create(element: KtBinaryExpression): String {
++        val binaryExpression = getBinaryParentExpression(element)
++        val stringBuilder = StringBuilder()
++        create(binaryExpression, stringBuilder)
++        return stringBuilder.toString()
++    }
++
++    private fun getBinaryParentExpression(element: KtBinaryExpression): KtBinaryExpression {
++        var binaryExpression = element.getStrictParentOfType<KtBinaryExpression>() ?: return element
++        while (binaryExpression != null) {
++            binaryExpression = binaryExpression.getStrictParentOfType<KtBinaryExpression>() ?: return element
++        }
++        return element
++    }
++
++    private fun create(element: KtBinaryExpression, sb: StringBuilder) {","I'd declare it as something like `private fun KtBinaryExpression.appendTo(sb: StringBuilder)`. And the same for the next function.
+",2016-09-22 10:57:32
+839,"@@ -0,0 +1,63 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.IntentionWrapper
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.AddNamesToCallArgumentsIntention
++import org.jetbrains.kotlin.psi.KtCallExpression
++import org.jetbrains.kotlin.psi.KtNameReferenceExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.referenceExpression
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.DataClassDescriptorResolver
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++
++class CopyWithoutNamedArgumentsInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitCallExpression(expression: KtCallExpression) {
++                super.visitCallExpression(expression)
++
++                val reference = expression.referenceExpression() as? KtNameReferenceExpression ?: return
++                if (reference.getReferencedNameAsName() != DataClassDescriptorResolver.COPY_METHOD_NAME) return
++                if (expression.valueArguments.none { !it.isNamed() }) return",`.all { it.isNamed() }` is easier to read.,2017-05-03 09:47:04
+360,"@@ -0,0 +1,64 @@
++# Enums
++
++Goals:
++* Better syntax for passing constructor parameters when defining enum constants
++* Resolve issues with annotation syntax for enum constants
++
++## Example
++
++Simple enum:
++``` kotlin
++enum class Foo {
++    A
++    B
++    C {
++        override fun foo() { ... }
++    }
++  
++    open fun foo() {}
++}
++```
++
++Enum with constructor:
++``` kotlin
++enum class Foo(val s: String) {
++    A(""a"")
++    B(""b"")
++    C(""c"") {
++        override fun foo() { ... }
++    }
++  
++    open fun foo() {}
++}
++```
++
++Issues
++* Enum literals syntax clash with annotation syntax
++    * Option 1.1: Forbid short annotation syntax in enums. **downside**: cannot annotate functions/properties/classes in this enum
++    * Option 1.2: Add a separator between enum constants and members, and forbid short annotation syntax only on enum entriesc themselves. **downside**: separator is not intuitive, hard to think of when doign this for the first time (the error message will be rather clear and instructive, though)","Spelling: doign -> doing
+",2015-04-04 17:52:45
+372,"@@ -0,0 +1,64 @@
++# Enums
++
++Goals:
++* Better syntax for passing constructor parameters when defining enum constants
++* Resolve issues with annotation syntax for enum constants
++
++## Example
++
++Simple enum:
++``` kotlin
++enum class Foo {
++    A
++    B
++    C {
++        override fun foo() { ... }
++    }
++  
++    open fun foo() {}
++}
++```
++
++Enum with constructor:
++``` kotlin
++enum class Foo(val s: String) {
++    A(""a"")
++    B(""b"")
++    C(""c"") {
++        override fun foo() { ... }
++    }
++  
++    open fun foo() {}
++}
++```
++
++Issues
++* Enum literals syntax clash with annotation syntax
++    * Option 1.1: Forbid short annotation syntax in enums. **downside**: cannot annotate functions/properties/classes in this enum
++    * Option 1.2: Add a separator between enum constants and members, and forbid short annotation syntax only on enum entriesc themselves. **downside**: separator is not intuitive, hard to think of when doing this for the first time (the error message will be rather clear and instructive, though)
++    * Option 1.3: prefix each entry with a soft-keyword, e.g. `entry`. **downside**: verbosity
++* How do we specify other supertypes for a constant (if any)
++    * Option 2.1: Leave unsupported, use cases are very few, and Java does not support it
++    * Option 2.2: `A(""s""): OtherType`
++
++Example for option 1.2:
++
++``` kotlin
++enum class Foo(val s: String) {
++    A(""a"") // semicolon CAN NOT be used here!
++    B(""b"")
++    C(""c"") {
++        override fun foo() { ... }
++    }; // semicolon is MANDATORY here, if a member follows
++  
++    // if no semicolon was provided, `open` is another enum entry
++    open fun foo() {}
++}
++```
++
++Notes:
++* No overhead in the most common case of no members at all: `enum class E {A B C}","Missing backtick?
+",2015-04-06 17:37:57
+25,"@@ -0,0 +1,64 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.openapi.vfs.LocalFileSystem;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.testFramework.PsiTestUtil;
++import org.jetbrains.jet.JetTestCaseBuilder;
++
++import java.util.Arrays;
++import java.util.List;
++
++public class FinalJavaSupertypeTest extends JetQuickFixMultiFileTest {
++    @Override
++    protected void setUp() throws Exception {
++        super.setUp();
++
++        String path = getTestDataPath();
++        VirtualFile virtualFile = LocalFileSystem.getInstance().refreshAndFindFileByPath(path);
++        if (virtualFile != null) {
++            virtualFile.getChildren();
++            virtualFile.refresh(false, true);
++        }","This piece of code occurs at least three times in the code base, it probably means that we should create a utility method for it.
+",2013-01-29 14:05:29
+26,"@@ -0,0 +1,64 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.openapi.vfs.LocalFileSystem;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiDocumentManager;
++import com.intellij.testFramework.PsiTestUtil;
++import org.jetbrains.jet.JetTestCaseBuilder;
++
++import java.util.Arrays;
++import java.util.List;
++
++public class FinalJavaSupertypeTest extends JetQuickFixMultiFileTest {
++    @Override
++    protected void setUp() throws Exception {
++        super.setUp();
++
++        String path = getTestDataPath();
++        VirtualFile virtualFile = LocalFileSystem.getInstance().refreshAndFindFileByPath(path);
++        if (virtualFile != null) {
++            virtualFile.getChildren();
++            virtualFile.refresh(false, true);
++        }
++    }
++
++    public void testFinalJavaSupertype() throws Exception {
++        String path = getTestDataPath() + ""/../javaCode/"";
++        final VirtualFile rootDir = PsiTestUtil.createTestProjectStructure(myProject, myModule, path, myFilesToDelete, false);
++        addSourceContentToRoots(myModule, rootDir);
++        PsiDocumentManager.getInstance(myProject).commitAllDocuments();
++        doTest();
++    }
++
++    @Override
++    protected String getCheckFileName() {
++        assert false;","It's a lot better to explicitly throw an exception here + provide a comprehensible message that tells me why this behavior is not legitimate
+",2013-01-29 14:09:34
+562,"@@ -0,0 +1,64 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.psi.*
++
++class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    val patterns = mapOf(
++            ""System.out.println($0)"" to ""println($0)"",
++            ""System.out.print($0)"" to ""print($0)"",
++            ""Collections.sort($0)"" to ""$0.sort()""
++    )
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitQualifiedExpression(expression: KtQualifiedExpression) {
++                super.visitQualifiedExpression(expression)
++
++                val selectorExpression = expression.selectorExpression ?: return
++                if (selectorExpression !is KtCallExpression) return
++                if (selectorExpression.valueArguments.size != 1) return
++                val value = selectorExpression.valueArguments[0].text
++                val pattern = expression.text.replace(value, ""$0"")","This is not good enough. You need to resolve the call to make sure that it points to the correct method, and not to a method of a different class that also happens to be called `Collections`.
+",2016-05-18 13:25:07
+563,"@@ -0,0 +1,64 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.psi.*
++
++class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    val patterns = mapOf(
++            ""System.out.println($0)"" to ""println($0)"",
++            ""System.out.print($0)"" to ""print($0)"",
++            ""Collections.sort($0)"" to ""$0.sort()""
++    )
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitQualifiedExpression(expression: KtQualifiedExpression) {
++                super.visitQualifiedExpression(expression)
++
++                val selectorExpression = expression.selectorExpression ?: return
++                if (selectorExpression !is KtCallExpression) return
++                if (selectorExpression.valueArguments.size != 1) return
++                val value = selectorExpression.valueArguments[0].text
++                val pattern = expression.text.replace(value, ""$0"")
++                if (!patterns.containsKey(pattern)) return
++
++                holder.registerProblem(expression,
++                                       ""Unnecessary java usage"",
++                                       ProblemHighlightType.LIKE_UNUSED_SYMBOL,","LIKE_UNUSED_SYMBOL highlighting is applied to code fragments that can be removed entirely. In this case, the quick fix is not removing the code, but is replacing it with different code.
+",2016-05-18 13:25:59
+953,"@@ -0,0 +1,64 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.codeInsight.intention.LowPriorityAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.core.moveCaret
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.createExpressionByPattern
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameOrNull
++
++class SwapStringEqualsIgnoreCaseIntention : SelfTargetingRangeIntention<KtDotQualifiedExpression>(KtDotQualifiedExpression::class.java, ""Flip 'equals'""), LowPriorityAction {
++
++    override fun applicabilityRange(element: KtDotQualifiedExpression): TextRange? {
++        val descriptor = element.getCallableDescriptor() ?: return null
++
++        val fqName: FqName = descriptor.fqNameOrNull() ?: return null
++        if (fqName.asString() != ""kotlin.text.equals"") return null
++
++        val valueParameters = descriptor.valueParameters.takeIf { it.size == 2 } ?: return null
++        if (!KotlinBuiltIns.isStringOrNullableString(valueParameters[0].type)) return null
++        if (!KotlinBuiltIns.isBoolean(valueParameters[1].type)) return null
++
++        return element.callExpression?.calleeExpression?.textRange
++    }
++
++    override fun applyTo(element: KtDotQualifiedExpression, editor: Editor?) {
++        val callExpression = element.callExpression ?: return
++        val offset = (editor?.caretModel?.offset ?: 0) - (callExpression.calleeExpression?.startOffset ?: 0)
++        val receiverExpression = element.receiverExpression
++        val valueArguments = callExpression.valueArguments.takeIf { it.size == 2 } ?: return
++        val newElement = KtPsiFactory(element).createExpressionByPattern(
++                ""$0.equals($1, $2)"",
++                valueArguments[0].text,",It's better to use here expressions and not their text,2017-08-07 11:06:09
+896,"@@ -0,0 +1,65 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.kotlin.lexer.KtTokens.*
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class ConvertClassToSealedClassIntention : SelfTargetingRangeIntention<KtClass>(KtClass::class.java, ""Convert to sealed class"") {
++
++    override fun applicabilityRange(element: KtClass): TextRange? {
++        if (element.modifierList == null) return null
++        if (!element.hasModifier(OPEN_KEYWORD) && !element.hasModifier(ABSTRACT_KEYWORD)) return null
++
++        val constructors = listOfNotNull(element.primaryConstructor) + element.secondaryConstructors
++        if (constructors.isEmpty()) return null
++        if (constructors.any { !it.hasModifier(PRIVATE_KEYWORD) }) return null",Please use `none` instead of `any` with a negative condition.,2017-07-17 11:14:05
+898,"@@ -0,0 +1,65 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.kotlin.lexer.KtTokens.*
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class ConvertClassToSealedClassIntention : SelfTargetingRangeIntention<KtClass>(KtClass::class.java, ""Convert to sealed class"") {
++
++    override fun applicabilityRange(element: KtClass): TextRange? {
++        if (element.modifierList == null) return null
++        if (!element.hasModifier(OPEN_KEYWORD) && !element.hasModifier(ABSTRACT_KEYWORD)) return null
++
++        val constructors = listOfNotNull(element.primaryConstructor) + element.secondaryConstructors
++        if (constructors.isEmpty()) return null
++        if (constructors.any { !it.hasModifier(PRIVATE_KEYWORD) }) return null
++
++        val nameIdentifier = element.nameIdentifier ?: return null
++        return TextRange(element.startOffset, nameIdentifier.endOffset)
++    }
++
++    override fun applyTo(element: KtClass, editor: Editor?) {
++        val newElement = element.copy() as KtClass",It doesn't seem necessary to create a copy; you should be able to apply all the changes to the original `KtClass` directly.,2017-07-17 11:15:07
+897,"@@ -0,0 +1,65 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.kotlin.lexer.KtTokens.*
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class ConvertClassToSealedClassIntention : SelfTargetingRangeIntention<KtClass>(KtClass::class.java, ""Convert to sealed class"") {
++
++    override fun applicabilityRange(element: KtClass): TextRange? {
++        if (element.modifierList == null) return null
++        if (!element.hasModifier(OPEN_KEYWORD) && !element.hasModifier(ABSTRACT_KEYWORD)) return null
++
++        val constructors = listOfNotNull(element.primaryConstructor) + element.secondaryConstructors
++        if (constructors.isEmpty()) return null
++        if (constructors.any { !it.hasModifier(PRIVATE_KEYWORD) }) return null
++
++        val nameIdentifier = element.nameIdentifier ?: return null
++        return TextRange(element.startOffset, nameIdentifier.endOffset)
++    }
++
++    override fun applyTo(element: KtClass, editor: Editor?) {
++        val newElement = element.copy() as KtClass
++
++        newElement.modifierList?.run {
++            getModifier(OPEN_KEYWORD)?.delete()
++            getModifier(ABSTRACT_KEYWORD)?.delete()
++            newElement.addModifier(SEALED_KEYWORD)",It's better to move this line out of the `run` block.,2017-07-17 11:14:40
+899,"@@ -0,0 +1,65 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.kotlin.lexer.KtTokens.*
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class ConvertClassToSealedClassIntention : SelfTargetingRangeIntention<KtClass>(KtClass::class.java, ""Convert to sealed class"") {
++
++    override fun applicabilityRange(element: KtClass): TextRange? {
++        if (element.modifierList == null) return null
++        if (!element.hasModifier(OPEN_KEYWORD) && !element.hasModifier(ABSTRACT_KEYWORD)) return null
++
++        val constructors = listOfNotNull(element.primaryConstructor) + element.secondaryConstructors
++        if (constructors.isEmpty()) return null
++        if (constructors.any { !it.hasModifier(PRIVATE_KEYWORD) }) return null
++
++        val nameIdentifier = element.nameIdentifier ?: return null
++        return TextRange(element.startOffset, nameIdentifier.endOffset)
++    }
++
++    override fun applyTo(element: KtClass, editor: Editor?) {
++        val newElement = element.copy() as KtClass
++
++        newElement.modifierList?.run {
++            getModifier(OPEN_KEYWORD)?.delete()
++            getModifier(ABSTRACT_KEYWORD)?.delete()
++            newElement.addModifier(SEALED_KEYWORD)
++        }
++
++        newElement.primaryConstructor?.run {
++            modifierList?.getModifier(PRIVATE_KEYWORD)?.delete()
++            getConstructorKeyword()?.delete()",The `constructor` keyword can only be deleted if there are no annotations or other modifiers on the constructor. Please add a test for the case with annotations.,2017-07-17 11:15:50
+900,"@@ -0,0 +1,65 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiWhiteSpace
++import org.jetbrains.kotlin.lexer.KtTokens.*
++import org.jetbrains.kotlin.psi.KtClass
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++
++class ConvertClassToSealedClassIntention : SelfTargetingRangeIntention<KtClass>(KtClass::class.java, ""Convert to sealed class"") {
++
++    override fun applicabilityRange(element: KtClass): TextRange? {
++        if (element.modifierList == null) return null
++        if (!element.hasModifier(OPEN_KEYWORD) && !element.hasModifier(ABSTRACT_KEYWORD)) return null
++
++        val constructors = listOfNotNull(element.primaryConstructor) + element.secondaryConstructors
++        if (constructors.isEmpty()) return null
++        if (constructors.any { !it.hasModifier(PRIVATE_KEYWORD) }) return null
++
++        val nameIdentifier = element.nameIdentifier ?: return null
++        return TextRange(element.startOffset, nameIdentifier.endOffset)
++    }
++
++    override fun applyTo(element: KtClass, editor: Editor?) {
++        val newElement = element.copy() as KtClass
++
++        newElement.modifierList?.run {
++            getModifier(OPEN_KEYWORD)?.delete()
++            getModifier(ABSTRACT_KEYWORD)?.delete()
++            newElement.addModifier(SEALED_KEYWORD)
++        }
++
++        newElement.primaryConstructor?.run {
++            modifierList?.getModifier(PRIVATE_KEYWORD)?.delete()
++            getConstructorKeyword()?.delete()
++            if (newElement.secondaryConstructors.isEmpty() && valueParameters.isEmpty()) valueParameterList?.delete()
++            (newElement.nameIdentifier?.prevSibling as? PsiWhiteSpace)?.delete()",It should never be necessary to do that manually; the formatter should take care of whitespaces.,2017-07-17 11:16:15
+817,"@@ -0,0 +1,65 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.javac
++
++import com.sun.tools.javac.util.Context
++import com.sun.tools.javac.util.Log
++import org.jetbrains.kotlin.cli.common.messages.CompilerMessageSeverity
++import org.jetbrains.kotlin.cli.common.messages.GroupingMessageCollector
++import org.jetbrains.kotlin.cli.common.messages.MessageCollector
++import java.io.PrintWriter
++import java.io.Writer
++
++class JavacLogger(context: Context,
++               errorWriter: PrintWriter,
++               warningWriter: PrintWriter,
++               infoWriter: PrintWriter) : Log(context, errorWriter, warningWriter, infoWriter) {
++    init {
++        context.put(Log.outKey, infoWriter)
++    }
++
++    override fun printLines(kind: WriterKind, message: String, vararg args: Any?) {}
++
++    companion object {
++        fun preRegister(context: Context, messageCollector: MessageCollector) {
++            context.put(Log.logKey, Context.Factory<Log> {
++                JavacLogger(it,
++                            PrintWriter(MessageCollectorAdapter(messageCollector, CompilerMessageSeverity.ERROR)),
++                            PrintWriter(MessageCollectorAdapter(messageCollector, CompilerMessageSeverity.WARNING)),
++                            PrintWriter(MessageCollectorAdapter(messageCollector, CompilerMessageSeverity.INFO)))
++            })
++        }
++    }
++
++}
++
++private class MessageCollectorAdapter(private val messageCollector: MessageCollector,
++                                      private val severity: CompilerMessageSeverity) : Writer() {
++
++    override fun write(buffer: CharArray, offset: Int, length: Int) {
++        if (length > 1) {",Why? A comment would be helpful here,2017-04-25 13:06:30
+756,"@@ -0,0 +1,66 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.PropertyDescriptor
++import org.jetbrains.kotlin.load.java.components.JavaPropertyInitializerEvaluator
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import org.jetbrains.kotlin.resolve.constants.ConstantValueFactory
++import org.jetbrains.kotlin.resolve.descriptorUtil.builtIns
++import org.jetbrains.kotlin.wrappers.symbols.JavacField
++import org.jetbrains.kotlin.wrappers.trees.JCClassifierType
++import org.jetbrains.kotlin.wrappers.trees.JCField
++import org.jetbrains.kotlin.wrappers.trees.JCPrimitiveType
++
++class JavacBasedPropertyInitializerEvaluator : JavaPropertyInitializerEvaluator {
++
++    override fun getInitializerConstant(field: JavaField, descriptor: PropertyDescriptor) = when (field) {
++        is JavacField<*> -> field.constant(descriptor)
++        is JCField<*> -> field.constant(descriptor)
++        else -> null
++    }
++
++    override fun isNotNullCompileTimeConstant(field: JavaField) = when(field) {
++        is JavacField<*> -> field.isCompileTimeConstant()
++        is JCField<*> -> field.isCompileTimeConstant()
++        else -> false
++    }
++
++    private fun JavacField<*>.constant(descriptor: PropertyDescriptor) = value?.let {
++        ConstantValueFactory(descriptor.builtIns).createConstantValue(it)
++    }
++
++    private fun JCField<*>.constant(descriptor: PropertyDescriptor) = value?.let {
++        if (isCompileTimeConstant() && it is JCTree.JCLiteral) {
++            ConstantValueFactory(descriptor.builtIns).createConstantValue(it.value)
++        } else null
++    }
++
++    private fun JavacField<*>.isCompileTimeConstant() = value?.let {
++        val typeMirror = type.typeMirror
++
++        (typeMirror.kind.isPrimitive || typeMirror.toString() == ""java.lang.String"")","It would be better to avoid `toString()` call here, if possible. Does this `typeMirror` have something like `name` or `fqName`?",2017-04-11 10:16:24
+35,"@@ -0,0 +1,68 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.impl.source.tree.LeafPsiElement;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class RemoveSpreadFix extends JetIntentionAction<LeafPsiElement>{
++    private final LeafPsiElement spreadSign;
++
++    public RemoveSpreadFix(@NotNull LeafPsiElement element) {
++        super(element);
++        spreadSign = element;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""remove.spread.sign"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""remove.spread.sign"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        spreadSign.delete();
++    }
++
++    public static JetIntentionActionFactory createFactory() {
++        return new JetIntentionActionFactory() {
++            @Override
++            public JetIntentionAction<LeafPsiElement> createAction(Diagnostic diagnostic) {
++                PsiElement element = diagnostic.getPsiElement();
++                if (!(element instanceof LeafPsiElement)) return null;","Almost right, but here's the way to do it without constant:
+
+```
+if (leaf instanceof LeafPsiElement && ((LeafPsiElement)leaf).getElementType() == JetTokens.MUL) {
+}
+```
+",2013-02-22 15:53:06
+988,"@@ -0,0 +1,68 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.functors
++
++import org.jetbrains.kotlin.effectsystem.impls.or
++import org.jetbrains.kotlin.effectsystem.factories.lift
++import org.jetbrains.kotlin.effectsystem.structure.*
++
++/**
++ * Applies [operation] to [first] and [second] if both not-null, otherwise returns null
++ */
++internal fun <F, S, R> applyIfBothNotNull(first: F?, second: S?, operation: (F, S) -> R): R? =
++        if (first == null || second == null) null else operation(first, second)
++
++/**
++ * If both [first] and [second] are null, then return null
++ * If only one of [first] and [second] is null, then return other one
++ * Otherwise, return result of [operation]
++ */
++internal fun <F : R, S : R, R> applyWithDefault(first: F?, second: S?, operation: (F, S) -> R): R? = when {
++    first == null && second == null -> null
++    first == null -> second
++    second == null -> first
++    else -> operation(first, second)
++}
++
++internal fun foldConditionsWithOr(list: List<ESClause>): ESBooleanExpression? =
++        if (list.isEmpty())
++            null
++        else
++            list.map { it.condition }.reduce { acc, condition -> acc.or(condition) }
++
++/**
++ * Places all clauses that equal to `firstModel` into first list, and all clauses that equal to `secondModel` into second list
++ */
++internal fun List<ESClause>.strictPartition(firstModel: ESEffect, secondModel: ESEffect): Pair<List<ESClause>, List<ESClause>> {","May be it's better to return here just lists of conditions, not lists of clauses. Then you can accept list of conditions in `foldConditionsWithOr`.",2017-08-15 17:01:07
+936,"@@ -0,0 +1,68 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtParenthesizedExpression
++import org.jetbrains.kotlin.psi.KtPrefixExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++import org.jetbrains.kotlin.types.typeUtil.isBoolean
++
++class DoubleNegationInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitPrefixExpression(expression: KtPrefixExpression) {
++                    if (expression.operationToken != KtTokens.EXCL || expression.baseExpression?.getType(expression.analyze())?.isBoolean() != true) {
++                        return
++                    }
++                    var parent = expression.parent
++                    while (parent is KtParenthesizedExpression) {
++                        parent = parent.parent
++                    }
++                    if (parent is KtPrefixExpression && parent.operationToken == KtTokens.EXCL) {
++                        holder.registerProblem(expression,
++                                               ""Redundant double negation"",
++                                               ProblemHighlightType.WEAK_WARNING,","For future: use here `GENERIC_ERROR_OR_WARNING` if you want to get highlight type depending on inspection severity level (by default, from plugin.xml, or configured by user). Explicitly given `WEAK_WARNING` enforces this severiry level making it unconfigurable by user (will fix myself).",2017-07-27 08:13:44
+961,"@@ -0,0 +1,68 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.CleanupLocalInspectionTool
++import com.intellij.codeInspection.LocalInspectionToolSession
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import java.util.*
++
++class SuspiciousEqualsCombination : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                    if (expression.parent is KtBinaryExpression) return
++                    val (first, second) = expression.parseBinary()
++                    val eqeq = first.map { it.text }
++                    val eqeqeq = second.map { it.text }
++                    if (eqeq.fold(false) { acc, it -> acc || eqeqeq.contains(it) }) {
++                        holder.registerProblem(expression, ""Suspicious combination of == and ==="",
++                                               ProblemHighlightType.GENERIC_ERROR_OR_WARNING)
++                    }
++                }
++            }
++
++    private fun KtBinaryExpression.parseBinary(pair: Pair<MutableList<KtExpression>, MutableList<KtExpression>>","I think the intent of this code will be much clearer if you used an explicit class instead of a Pair:
+
+```
+data class ComparisonOperands(val eqEqOperands: MutableList<KtExpression>, val eqEqEqOperands: MutableList<KtExpression>)",2017-08-15 09:49:55
+962,"@@ -0,0 +1,68 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.CleanupLocalInspectionTool
++import com.intellij.codeInspection.LocalInspectionToolSession
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import java.util.*
++
++class SuspiciousEqualsCombination : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                    if (expression.parent is KtBinaryExpression) return
++                    val (first, second) = expression.parseBinary()
++                    val eqeq = first.map { it.text }
++                    val eqeqeq = second.map { it.text }
++                    if (eqeq.fold(false) { acc, it -> acc || eqeqeq.contains(it) }) {
++                        holder.registerProblem(expression, ""Suspicious combination of == and ==="",
++                                               ProblemHighlightType.GENERIC_ERROR_OR_WARNING)
++                    }
++                }
++            }
++
++    private fun KtBinaryExpression.parseBinary(pair: Pair<MutableList<KtExpression>, MutableList<KtExpression>>
++                                               = Pair(LinkedList(), LinkedList())): Pair<MutableList<KtExpression>, MutableList<KtExpression>> {",Please don't use `LinkedList` for anything ever. :),2017-08-15 09:50:25
+963,"@@ -0,0 +1,68 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.CleanupLocalInspectionTool
++import com.intellij.codeInspection.LocalInspectionToolSession
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import java.util.*
++
++class SuspiciousEqualsCombination : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                    if (expression.parent is KtBinaryExpression) return
++                    val (first, second) = expression.parseBinary()
++                    val eqeq = first.map { it.text }
++                    val eqeqeq = second.map { it.text }
++                    if (eqeq.fold(false) { acc, it -> acc || eqeqeq.contains(it) }) {
++                        holder.registerProblem(expression, ""Suspicious combination of == and ==="",
++                                               ProblemHighlightType.GENERIC_ERROR_OR_WARNING)
++                    }
++                }
++            }
++
++    private fun KtBinaryExpression.parseBinary(pair: Pair<MutableList<KtExpression>, MutableList<KtExpression>>
++                                               = Pair(LinkedList(), LinkedList())): Pair<MutableList<KtExpression>, MutableList<KtExpression>> {
++        when (operationToken) {
++            KtTokens.EQEQ, KtTokens.EXCLEQ -> {
++                left?.let(pair.first::add)","I'd check that the operands are `KtNameReferenceExpression`'s, to make the behavior more predictable.",2017-08-15 09:50:58
+627,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.js.descriptorUtils.getJetTypeFqName
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++import java.util.*
++
++class RemoveRedundantCallsOfConversionMethodsInspection : IntentionBasedInspection<KtDotQualifiedExpression>(RemoveRedundantCallsOfConversionMethodsIntention::class)","I think these redundant calls should be highlighted as unused symbols.
+",2016-10-07 09:51:22
+628,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.js.descriptorUtils.getJetTypeFqName
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++import java.util.*
++
++class RemoveRedundantCallsOfConversionMethodsInspection : IntentionBasedInspection<KtDotQualifiedExpression>(RemoveRedundantCallsOfConversionMethodsIntention::class)
++
++class RemoveRedundantCallsOfConversionMethodsIntention : SelfTargetingOffsetIndependentIntention<KtDotQualifiedExpression>(KtDotQualifiedExpression::class.java, ""Remove redundant calls of the conversion method"") {
++
++    private val targetClassMap = mapOf(""toList()"" to List::class.qualifiedName,
++                                       ""toSet()"" to Set::class.qualifiedName,
++                                       ""toMap()"" to Map::class.qualifiedName,
++                                       ""toMutableList()"" to ""kotlin.collections.MutableList"",
++                                       ""toMutableSet()"" to ""kotlin.collections.MutableSet"",
++                                       ""toMutableMap()"" to ""kotlin.collections.MutableMap"",
++                                       ""toSortedSet()"" to SortedSet::class.qualifiedName,
++                                       ""toSortedMap()"" to SortedMap::class.qualifiedName,
++                                       ""toString()"" to String::class.qualifiedName,
++                                       ""toDouble()"" to Double::class.qualifiedName,
++                                       ""toFloat()"" to Float::class.qualifiedName,
++                                       ""toLong()"" to Long::class.qualifiedName,
++                                       ""toInt()"" to Int::class.qualifiedName,
++                                       ""toChar()"" to Char::class.qualifiedName,
++                                       ""toShort()"" to Short::class.qualifiedName,
++                                       ""toByte()"" to Byte::class.qualifiedName)
++
++
++    override fun applyTo(element: KtDotQualifiedExpression, editor: Editor?) {
++        element.replaced(element.receiverExpression)
++
++        mutableMapOf(1 to 1).toMutableMap()","What is it? Looks like it's not needed here :)
+",2016-10-07 09:52:16
+629,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.js.descriptorUtils.getJetTypeFqName
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++import java.util.*
++
++class RemoveRedundantCallsOfConversionMethodsInspection : IntentionBasedInspection<KtDotQualifiedExpression>(RemoveRedundantCallsOfConversionMethodsIntention::class)
++
++class RemoveRedundantCallsOfConversionMethodsIntention : SelfTargetingOffsetIndependentIntention<KtDotQualifiedExpression>(KtDotQualifiedExpression::class.java, ""Remove redundant calls of the conversion method"") {
++
++    private val targetClassMap = mapOf(""toList()"" to List::class.qualifiedName,
++                                       ""toSet()"" to Set::class.qualifiedName,
++                                       ""toMap()"" to Map::class.qualifiedName,
++                                       ""toMutableList()"" to ""kotlin.collections.MutableList"",
++                                       ""toMutableSet()"" to ""kotlin.collections.MutableSet"",
++                                       ""toMutableMap()"" to ""kotlin.collections.MutableMap"",
++                                       ""toSortedSet()"" to SortedSet::class.qualifiedName,
++                                       ""toSortedMap()"" to SortedMap::class.qualifiedName,
++                                       ""toString()"" to String::class.qualifiedName,
++                                       ""toDouble()"" to Double::class.qualifiedName,
++                                       ""toFloat()"" to Float::class.qualifiedName,
++                                       ""toLong()"" to Long::class.qualifiedName,
++                                       ""toInt()"" to Int::class.qualifiedName,
++                                       ""toChar()"" to Char::class.qualifiedName,
++                                       ""toShort()"" to Short::class.qualifiedName,
++                                       ""toByte()"" to Byte::class.qualifiedName)
++
++
++    override fun applyTo(element: KtDotQualifiedExpression, editor: Editor?) {
++        element.replaced(element.receiverExpression)
++
++        mutableMapOf(1 to 1).toMutableMap()
++    }
++
++    override fun isApplicableTo(element: KtDotQualifiedExpression): Boolean {","Looks like we can apply this intention for all qualified expressions, not only unsafe ones.
+",2016-10-07 09:53:28
+630,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.inspections.IntentionBasedInspection
++import org.jetbrains.kotlin.js.descriptorUtils.getJetTypeFqName
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtStringTemplateExpression
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++import java.util.*
++
++class RemoveRedundantCallsOfConversionMethodsInspection : IntentionBasedInspection<KtDotQualifiedExpression>(RemoveRedundantCallsOfConversionMethodsIntention::class)
++
++class RemoveRedundantCallsOfConversionMethodsIntention : SelfTargetingOffsetIndependentIntention<KtDotQualifiedExpression>(KtDotQualifiedExpression::class.java, ""Remove redundant calls of the conversion method"") {
++
++    private val targetClassMap = mapOf(""toList()"" to List::class.qualifiedName,
++                                       ""toSet()"" to Set::class.qualifiedName,
++                                       ""toMap()"" to Map::class.qualifiedName,
++                                       ""toMutableList()"" to ""kotlin.collections.MutableList"",
++                                       ""toMutableSet()"" to ""kotlin.collections.MutableSet"",
++                                       ""toMutableMap()"" to ""kotlin.collections.MutableMap"",
++                                       ""toSortedSet()"" to SortedSet::class.qualifiedName,
++                                       ""toSortedMap()"" to SortedMap::class.qualifiedName,
++                                       ""toString()"" to String::class.qualifiedName,
++                                       ""toDouble()"" to Double::class.qualifiedName,
++                                       ""toFloat()"" to Float::class.qualifiedName,
++                                       ""toLong()"" to Long::class.qualifiedName,
++                                       ""toInt()"" to Int::class.qualifiedName,
++                                       ""toChar()"" to Char::class.qualifiedName,
++                                       ""toShort()"" to Short::class.qualifiedName,
++                                       ""toByte()"" to Byte::class.qualifiedName)
++
++
++    override fun applyTo(element: KtDotQualifiedExpression, editor: Editor?) {
++        element.replaced(element.receiverExpression)
++
++        mutableMapOf(1 to 1).toMutableMap()
++    }
++
++    override fun isApplicableTo(element: KtDotQualifiedExpression): Boolean {
++        val selectorExpressionText = element.selectorExpression?.text
++        val qualifiedName = targetClassMap[selectorExpressionText] ?: return false
++        val receiverExpression = element.receiverExpression
++        return when (receiverExpression) {
++            is KtStringTemplateExpression -> String::class.qualifiedName
++            is KtConstantExpression -> receiverExpression.getType(receiverExpression.analyze())?.getJetTypeFqName(false)
++            else -> receiverExpression.getResolvedCall(receiverExpression.analyze())?.candidateDescriptor?.returnType?.getJetTypeFqName(false)
++        } == qualifiedName","I'm not sure here what will be happened if somebody defines custom `toType()` function. Probably it's not too important, because it's expected that `toType()` has result of `Type` anyway.
+",2016-10-07 09:59:19
+546,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.builtins.getReturnTypeFromFunctionType
++import org.jetbrains.kotlin.builtins.isExtensionFunctionType
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.util.IdeDescriptorRenderers
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.KtTypeReference
++import org.jetbrains.kotlin.renderer.DescriptorRenderer
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++import org.jetbrains.kotlin.types.KotlinType
++
++class ConvertExtensionToFunctionTypeFix(element: KtTypeReference, type: KotlinType) : KotlinQuickFixAction<KtTypeReference>(element) {
++
++    private val targetTypeStringShort = type.renderType(IdeDescriptorRenderers.SOURCE_CODE_SHORT_NAMES_IN_TYPES)
++    private val targetTypeStringLong = type.renderType(IdeDescriptorRenderers.SOURCE_CODE)
++
++    override fun getText() = ""Convert supertype to '$targetTypeStringShort'""
++    override fun getFamilyName() = ""Convert extension function type to regular function type.""","No period here please
+",2016-04-28 08:41:35
+547,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.builtins.getReturnTypeFromFunctionType
++import org.jetbrains.kotlin.builtins.isExtensionFunctionType
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.util.IdeDescriptorRenderers
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.KtTypeReference
++import org.jetbrains.kotlin.renderer.DescriptorRenderer
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++import org.jetbrains.kotlin.types.KotlinType
++
++class ConvertExtensionToFunctionTypeFix(element: KtTypeReference, type: KotlinType) : KotlinQuickFixAction<KtTypeReference>(element) {
++
++    private val targetTypeStringShort = type.renderType(IdeDescriptorRenderers.SOURCE_CODE_SHORT_NAMES_IN_TYPES)
++    private val targetTypeStringLong = type.renderType(IdeDescriptorRenderers.SOURCE_CODE)
++
++    override fun getText() = ""Convert supertype to '$targetTypeStringShort'""
++    override fun getFamilyName() = ""Convert extension function type to regular function type.""
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val replaced = element.replaced(KtPsiFactory(project).createType(targetTypeStringLong))
++        ShortenReferences.DEFAULT.process(replaced)
++    }
++
++    private fun KotlinType.renderType(renderer: DescriptorRenderer) = buildString {
++        append('(')
++        arguments.dropLast(1).map { renderer.renderType(it.type) }.joinTo(this@buildString, "", "")","I'd add a test for more than one argument, and/or for type with type parameters
+",2016-04-28 08:42:07
+997,"@@ -0,0 +1,69 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.CleanupLocalInspectionTool
++import com.intellij.codeInspection.LocalInspectionToolSession
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++
++class SuspiciousEqualsCombination : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                    if (expression.parent is KtBinaryExpression) return
++                    val operands = expression.parseBinary()
++                    val eqeq = operands.eqEqOperands.map { it.text }
++                    val eqeqeq = operands.eqEqEqOperands.map { it.text }
++                    if (eqeq.fold(false) { acc, it -> acc || eqeqeq.contains(it) }) {",This can actually be expressed as `eqeq.intersect(eqeqeq).isNotEmpty()`,2017-08-16 16:41:17
+940,"@@ -0,0 +1,7 @@
++// ""Replace initializer with getter"" ""true""
++
++fun String.foo() = ""bar""
++
++interface A {
++    val name = <caret>""The quick brown fox jumps over the lazy dog"".foo()",Neither the existing intention action nor your suggested quickfix handle `var` properties correctly. They should create a stub for the setter with no implementation.,2017-08-03 10:02:22
+213,"@@ -0,0 +1,7 @@
++// ERROR: Unresolved reference: listOf
++fun a() {
++    val b = listOf(1,2,3,4,5)","You should use `// WITH_RUNTIME` directive in this and all other tests where you use standard library functions to avoid errors
+",2014-04-30 18:18:06
+135,"@@ -0,0 +1,7 @@
++// IS_APPLICABLE: false
++fun foo() {
++    if (true) {
++        println(""test"")
++        println(""test2"")
++        <caret>}
++}","Typo in file name.
+",2014-03-04 16:08:30
+347,"@@ -0,0 +1,7 @@
++class KotlinClass(): JavaClass({}) {","Please make function literal here non-trivial.
+",2015-03-26 15:35:16
+163,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++        if (hasDeclaredParamsType || hasDeclaredReturnType || hasDeclaredReceiverType) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val paramList = element.getFunctionLiteral().getValueParameterList()","Ditto (`element.getFunctionLiteral()` deserves to be extracted into a variable)
+",2014-04-09 15:42:14
+162,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++        if (hasDeclaredParamsType || hasDeclaredReturnType || hasDeclaredReceiverType) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val paramList = element.getFunctionLiteral().getValueParameterList()
++        val params = paramList?.getParameters()
++
++        if (element.hasDeclaredReturnType()) {
++            val childAfterParamList = paramList?.getNextSibling()
++            val arrow = element.getFunctionLiteral().getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            element.getFunctionLiteral().deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            element.getFunctionLiteral().addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++        if (hasDeclaredReceiverType) {
++            val childAfterBrace = element.getFunctionLiteral().getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = paramList?.getPrevSibling()
++            element.getFunctionLiteral().deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        if (params != null && params!!.size() == 1 && params[0].getNameIdentifier() != null) {","There's a warning about a useless `!!` here
+",2014-04-09 15:41:34
+164,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.types.ErrorUtils
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++        if (hasDeclaredParamsType || hasDeclaredReturnType || hasDeclaredReceiverType) return true
++
++        return false
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val paramList = element.getFunctionLiteral().getValueParameterList()
++        val params = paramList?.getParameters()
++
++        if (element.hasDeclaredReturnType()) {
++            val childAfterParamList = paramList?.getNextSibling()
++            val arrow = element.getFunctionLiteral().getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            element.getFunctionLiteral().deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            element.getFunctionLiteral().addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++        if (hasDeclaredReceiverType) {
++            val childAfterBrace = element.getFunctionLiteral().getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = paramList?.getPrevSibling()
++            element.getFunctionLiteral().deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        if (params != null && params!!.size() == 1 && params[0].getNameIdentifier() != null) {
++            paramList!!.replace(params[0].getNameIdentifier()!!)
++        }
++        else {
++            params?.forEach{","Missing a space before `{`
+",2014-04-09 15:43:44
+228,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        }
++        else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        val multiParameter = element.getMultiParameter() ?: return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() as? JetCallExpression ?: return false
++
++        if (!selector.textMatches(""withIndices()"")) return false","This is a nice optimization, but I'd check if `selector` is a call expression with a callee named `withIndices`. People can have different weird code style settings, for example ones requiring spaces before parentheses; it would be a pity if this intention wouldn't work in that case (`withIndices ()`)
+",2014-05-12 12:27:19
+227,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        }
++        else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        val multiParameter = element.getMultiParameter() ?: return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() as? JetCallExpression ?: return false
++
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val bindingContext = AnalyzerFacadeWithCache.getContextForElement(element)
++        val callResolution = bindingContext[BindingContext.RESOLVED_CALL, selector.getCalleeExpression()!!] ?: return false
++        val fqName = DescriptorUtils.getFqNameSafe(callResolution.getCandidateDescriptor())","Ditto (`getFqNameSafe`)
+",2014-05-12 12:21:26
+235,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        }
++        else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        val multiParameter = element.getMultiParameter() ?: return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() as? JetCallExpression ?: return false
++
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val bindingContext = AnalyzerFacadeWithCache.getContextForElement(element)
++        val callResolution = bindingContext[BindingContext.RESOLVED_CALL, selector.getCalleeExpression()!!] ?: return false
++        val fqName = DescriptorUtils.getFqNameSafe(callResolution.getCandidateDescriptor())
++        if (fqName.toString() != ""kotlin.withIndices"") return false
++
++        val indexVar = multiParameter.getEntries()[0]","You should check if there are any entries. Otherwise your intention fails with the exception on the following test case:
+
+``` kotlin
+        for (() in listOf(1).withIndices()) {
+        }
+```
+",2014-05-12 13:22:11
+234,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        }
++        else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        val multiParameter = element.getMultiParameter() ?: return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() as? JetCallExpression ?: return false
++
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val bindingContext = AnalyzerFacadeWithCache.getContextForElement(element)
++        val callResolution = bindingContext[BindingContext.RESOLVED_CALL, selector.getCalleeExpression()!!] ?: return false
++        val fqName = DescriptorUtils.getFqNameSafe(callResolution.getCandidateDescriptor())
++        if (fqName.toString() != ""kotlin.withIndices"") return false
++
++        val indexVar = multiParameter.getEntries()[0]
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar, false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        var usageCount = 0","As I mentioned earlier, this should be a boolean flag, rather than an integer variable
+",2014-05-12 13:14:21
+714,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMember
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.Element
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++
++abstract class JavacMember<out T : Element>(element: T,
++                                            javac: Javac) : JavacElement<T>(element, javac), JavaMember {
++    override val containingClass: JavaClass
++        get() = JavacClass((element.enclosingElement as TypeElement), javac)
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = element.annotationMirrors
++                .map { JavacAnnotation(it, javac) }
++
++    override fun findAnnotation(fqName: FqName): JavaAnnotation? = element.annotationMirrors
++            .filter { it.toString() == fqName.asString() }
++            .firstOrNull()
++            ?.let { JavacAnnotation(it, javac) }
++
++    override val visibility
++        get() = element.getVisibility()
++
++    override val name
++        get() = Name.identifier(element.simpleName.toString())
++
++    override val isDeprecatedInJavaDoc = false","Again, why false?",2017-04-05 15:02:01
+716,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMember
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.Element
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++
++abstract class JavacMember<out T : Element>(element: T,
++                                            javac: Javac) : JavacElement<T>(element, javac), JavaMember {
++    override val containingClass: JavaClass
++        get() = JavacClass((element.enclosingElement as TypeElement), javac)
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = element.annotationMirrors
++                .map { JavacAnnotation(it, javac) }
++
++    override fun findAnnotation(fqName: FqName): JavaAnnotation? = element.annotationMirrors
++            .filter { it.toString() == fqName.asString() }
++            .firstOrNull()
++            ?.let { JavacAnnotation(it, javac) }
++
++    override val visibility
++        get() = element.getVisibility()
++
++    override val name
++        get() = Name.identifier(element.simpleName.toString())
++
++    override val isDeprecatedInJavaDoc = false
++
++    override val isAbstract
++        get() = element.isAbstract
++
++    override val isStatic
++        get() = element.isStatic
++
++    override val isFinal
++        get() = element.isFinal
++
++}
++
++fun ExecutableElement.valueParameters(javac: Javac) = let {",May be create separate file like `JavacElementUtils.kt` for such things.,2017-04-05 15:04:24
+715,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.symbols
++
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.load.java.structure.JavaAnnotation
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaMember
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.Name
++import javax.lang.model.element.Element
++import javax.lang.model.element.ExecutableElement
++import javax.lang.model.element.TypeElement
++
++abstract class JavacMember<out T : Element>(element: T,
++                                            javac: Javac) : JavacElement<T>(element, javac), JavaMember {
++    override val containingClass: JavaClass
++        get() = JavacClass((element.enclosingElement as TypeElement), javac)
++
++    override val annotations: Collection<JavaAnnotation>
++        get() = element.annotationMirrors
++                .map { JavacAnnotation(it, javac) }
++
++    override fun findAnnotation(fqName: FqName): JavaAnnotation? = element.annotationMirrors
++            .filter { it.toString() == fqName.asString() }
++            .firstOrNull()
++            ?.let { JavacAnnotation(it, javac) }
++
++    override val visibility
++        get() = element.getVisibility()
++
++    override val name
++        get() = Name.identifier(element.simpleName.toString())
++
++    override val isDeprecatedInJavaDoc = false
++
++    override val isAbstract
++        get() = element.isAbstract
++
++    override val isStatic
++        get() = element.isStatic
++
++    override val isFinal
++        get() = element.isFinal
++
++}
++
++fun ExecutableElement.valueParameters(javac: Javac) = let {
++    val parameterTypesCount = parameters.size
++
++    parameters.mapIndexed { index, it ->
++        val isLastParameter = index == parameterTypesCount - 1
++        val parameterName = it.simpleName.toString()
++        JavacValueParameter(it, parameterName, if (isLastParameter) isVarArgs else false, javac)",`isLastParameter && isVarArgs`,2017-04-05 15:03:47
+832,"@@ -0,0 +1,70 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.code.Flags
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.descriptors.Visibilities
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import org.jetbrains.kotlin.name.Name
++
++class TreeBasedField<out T : JCTree.JCVariableDecl>(tree: T,
++                                                    treePath: TreePath,
++                                                    containingClass: JavaClass,
++                                                    javac: JavacWrapper) : TreeBasedMember<T>(tree, treePath, containingClass, javac), JavaField {
++
++    override val name
++        get() = Name.identifier(tree.name.toString())
++
++    override val isAbstract
++        get() = tree.modifiers.isAbstract
++
++    override val isStatic
++        get() = containingClass.isInterface || tree.modifiers.isStatic",Please ensure there's a test on static fields in annotations,2017-04-25 16:37:02
+569,"@@ -0,0 +1,71 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.references.mainReference
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++
++class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    val patterns = mapOf(
++            ""java.io.PrintStream.println"" to ""println($0)"",
++            ""java.io.PrintStream.print"" to ""print($0)"",
++            ""java.util.Collections.sort"" to ""$0.sort()""
++    )
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitQualifiedExpression(expression: KtQualifiedExpression) {
++                super.visitQualifiedExpression(expression)
++
++                val selectorExpression = expression.selectorExpression ?: return
++                if (selectorExpression !is KtCallExpression) return
++                val value = selectorExpression.valueArguments.singleOrNull() ?: return
++
++                val calleeExpression = selectorExpression.calleeExpression as KtSimpleNameExpression
++                val bindingContext = calleeExpression.analyze(BodyResolveMode.PARTIAL)
++                val target = calleeExpression.mainReference.resolveToDescriptors(bindingContext).singleOrNull() ?: return
++                val pattern = target.fqNameSafe.asString()","I tryed use `importableFqName` but it's was giving null for me. I am a bit confused with this. 
+",2016-05-20 02:37:19
+660,"@@ -0,0 +1,71 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.evaluatesTo
++import org.jetbrains.kotlin.idea.refactoring.getLineNumber
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtBlockExpression
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.lastBlockStatementOrThis
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++
++class UnusedEqualsInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                super.visitBinaryExpression(expression)
++                if (expression.operationToken != KtTokens.EQEQ) return
++                val parent = expression.parent as? KtBlockExpression ?: return
++                val lastBlockStatement = parent.lastBlockStatementOrThis()
++                when {
++                    expression.evaluatesTo(lastBlockStatement) && expression.getLineNumber() == lastBlockStatement.getLineNumber() ->
++                        expression.getStrictParentOfType<KtLambdaExpression>()?.visitLambdaExpression(holder, expression) ?: holder.registerUnusedEqualsProblem(expression)",All of this looks too nasty and unsafe. Please use `KtExpression.isUsedAsExpression` from `BindingContextUtils.kt` to determine whether your `equals` result is used or not.,2016-12-23 10:08:19
+662,"@@ -0,0 +1,71 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.evaluatesTo
++import org.jetbrains.kotlin.idea.refactoring.getLineNumber
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtBlockExpression
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.lastBlockStatementOrThis
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++
++class UnusedEqualsInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                super.visitBinaryExpression(expression)
++                if (expression.operationToken != KtTokens.EQEQ) return
++                val parent = expression.parent as? KtBlockExpression ?: return
++                val lastBlockStatement = parent.lastBlockStatementOrThis()
++                when {
++                    expression.evaluatesTo(lastBlockStatement) && expression.getLineNumber() == lastBlockStatement.getLineNumber() ->
++                        expression.getStrictParentOfType<KtLambdaExpression>()?.visitLambdaExpression(holder, expression) ?: holder.registerUnusedEqualsProblem(expression)
++                    else -> holder.registerUnusedEqualsProblem(expression)
++                }
++            }
++
++            private fun KtLambdaExpression.visitLambdaExpression(holder: ProblemsHolder, expression: KtBinaryExpression) {
++                val lambdaTypeArguments = getType(analyze())?.arguments ?: return
++                if (lambdaTypeArguments.size != 1) return
++                when {
++                    KotlinBuiltIns.isBoolean(lambdaTypeArguments[0].type) -> {
++                        val lastBlockStatementOrThis = bodyExpression?.lastBlockStatementOrThis() ?: return
++                        if (!expression.evaluatesTo(lastBlockStatementOrThis)) holder.registerUnusedEqualsProblem(expression)
++                    }
++                    else -> holder.registerUnusedEqualsProblem(expression)
++                }
++            }
++
++            private fun ProblemsHolder.registerUnusedEqualsProblem(expression: KtBinaryExpression) {
++                registerProblem(expression,",I'd say it's better to provide also text range here and highlight `==` only as unused.,2016-12-23 10:13:12
+661,"@@ -0,0 +1,71 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.intentions.branchedTransformations.evaluatesTo
++import org.jetbrains.kotlin.idea.refactoring.getLineNumber
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtBlockExpression
++import org.jetbrains.kotlin.psi.KtLambdaExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.lastBlockStatementOrThis
++import org.jetbrains.kotlin.resolve.calls.callUtil.getType
++
++class UnusedEqualsInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                super.visitBinaryExpression(expression)
++                if (expression.operationToken != KtTokens.EQEQ) return
++                val parent = expression.parent as? KtBlockExpression ?: return
++                val lastBlockStatement = parent.lastBlockStatementOrThis()
++                when {
++                    expression.evaluatesTo(lastBlockStatement) && expression.getLineNumber() == lastBlockStatement.getLineNumber() ->
++                        expression.getStrictParentOfType<KtLambdaExpression>()?.visitLambdaExpression(holder, expression) ?: holder.registerUnusedEqualsProblem(expression)
++                    else -> holder.registerUnusedEqualsProblem(expression)
++                }
++            }
++
++            private fun KtLambdaExpression.visitLambdaExpression(holder: ProblemsHolder, expression: KtBinaryExpression) {
++                val lambdaTypeArguments = getType(analyze())?.arguments ?: return
++                if (lambdaTypeArguments.size != 1) return
++                when {
++                    KotlinBuiltIns.isBoolean(lambdaTypeArguments[0].type) -> {
++                        val lastBlockStatementOrThis = bodyExpression?.lastBlockStatementOrThis() ?: return
++                        if (!expression.evaluatesTo(lastBlockStatementOrThis)) holder.registerUnusedEqualsProblem(expression)
++                    }
++                    else -> holder.registerUnusedEqualsProblem(expression)
++                }
++            }
++
++            private fun ProblemsHolder.registerUnusedEqualsProblem(expression: KtBinaryExpression) {
++                registerProblem(expression,
++                                ""Unused equals expression"",
++                                ProblemHighlightType.LIKE_UNUSED_SYMBOL)","Should we provide some quick fix? I'd say that in simple cases with local variables or constants binary expression could be completely deleted, but in cases like `foo() == bar()` we should get
+
+```
+foo()
+bar()
+```
+
+instead",2016-12-23 10:11:29
+40,"@@ -0,0 +1,72 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.lang.ASTNode;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.impl.PsiImplUtil;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.JetDelegationSpecifier;
++import org.jetbrains.jet.lexer.JetTokens;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class RemoveSupertypeFix extends JetIntentionAction<JetDelegationSpecifier> {
++    private final JetDelegationSpecifier superClass;
++
++    public RemoveSupertypeFix(@NotNull JetDelegationSpecifier superClass) {
++        super(superClass);
++        this.superClass = superClass;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""remove.supertype"", superClass.getText());
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""remove.supertype.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        // Find the preceding comma and delete it as well.
++        // We must ignore whitespaces and comments when looking for the comma.
++        ASTNode prev = PsiImplUtil.skipWhitespaceAndCommentsBack(superClass.getPrevSibling().getNode());","Possible NullPointerException if superClass has no previous sibling??? But will it ever have no previous sibling?
+",2013-03-29 16:53:57
+10,"@@ -0,0 +1,73 @@
++/*
++ * Copyright 2010-2012 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.impl.source.tree.LeafPsiElement;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.jet.lang.psi.JetFile;
++import org.jetbrains.jet.lexer.JetTokens;
++import org.jetbrains.jet.plugin.JetBundle;
++
++/**
++ * @author slukjanov aka Frostman
++ */
++public class UnnecessaryNotNullAssertionFix implements IntentionAction {","I understand why you decided to create another class for that task but still think that there should be another logic in UnnecessaryNotNullAssertionFix and ReplaceCallFix. I propose ReplaceCallFix could also be used for replacing !!. call to something else as it can be used for introducing such calls now. And this class can could be responsible only for introducing and removing a!! postfix operation.
+What do you think?
+",2012-06-19 15:01:46
+12,"@@ -0,0 +1,73 @@
++/*
++ * Copyright 2010-2012 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.impl.source.tree.LeafPsiElement;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.jet.lang.psi.JetFile;
++import org.jetbrains.jet.lexer.JetTokens;
++import org.jetbrains.jet.plugin.JetBundle;
++
++/**
++ * @author slukjanov aka Frostman
++ */
++public class UnnecessaryNotNullAssertionFix implements IntentionAction {
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""remove.unnecessary.non.null.assertion"");
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return getText();
++    }
++
++    @Override
++    public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
++        return file instanceof JetFile && getExclExclElement(editor, file) != null;
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        final PsiElement exclExcl = getExclExclElement(editor, file);
++        assert exclExcl != null;
++
++        exclExcl.delete();","There's a problem with removing PSI element this way. It looks like IDEA can't handle the region for update correctly. I'm going to debug and fix it. It can be reproduced with this chunk of code. After applying the fix idea shows errors in internal mode (with -Didea.is.internal=true in javac string).
+fun test(value : String) : String {
+  return value!!
+}
+",2012-06-26 20:27:50
+771,"@@ -0,0 +1,74 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.javac.MockKotlinClassifier
++import org.jetbrains.kotlin.load.java.structure.*
++
++sealed class ClassifierType<out T : JCTree>(tree: T,
++                                              treePath: TreePath,
++                                              javac: JavacWrapper) : JCType<T>(tree, treePath, javac), JavaClassifierType {
++
++    override val classifier by lazy { treePath.resolve(javac) }
++
++    override val canonicalText
++        get() = (classifier as? JavaClass)?.fqName?.asString() ?: treePath.leaf.toString()
++
++    override val presentableText
++        get() = canonicalText
++
++    private val typeParameter
++        get() = treePath.filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }
++                .flatMap {
++                    when (it) {
++                        is JCTree.JCClassDecl -> it.typarams
++                        is JCTree.JCMethodDecl -> it.typarams
++                        else -> throw UnsupportedOperationException(""${it.kind} cannot have a type parameter"")
++                    }
++                }
++                .find { it.toString().substringBefore("" "") == treePath.leaf.toString() }
++
++}
++
++class JCClassifierType<out T : JCTree.JCExpression>(tree: T,
++                                                    treePath: TreePath,
++                                                    javac: JavacWrapper) : ClassifierType<T>(tree, treePath, javac) {
++
++    override val typeArguments: List<JavaType>
++        get() = emptyList()
++
++    override val isRaw
++        get() = (classifier as? MockKotlinClassifier)?.hasTypeParameters
++                ?: (classifier as? JavaClass)?.typeParameters?.isNotEmpty()
++                ?: false
++
++}
++
++class JCClassifierTypeWithTypeArgument<out T : JCTree.JCTypeApply>(tree: T,","May be it's not the best name. For me it's more or less obvious, that `JCClassifierTypeWithTypeArgument` is an inheritor of `JCClassifierType`, but in fact it's not so. I'd change one of these two names.",2017-04-20 10:09:15
+829,"@@ -0,0 +1,75 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.javac.MockKotlinClassifier
++import org.jetbrains.kotlin.load.java.structure.*
++
++sealed class TreeBasedClassifierType<out T : JCTree>(tree: T,
++                                                     treePath: TreePath,
++                                                     javac: JavacWrapper) : TreeBasedType<T>(tree, treePath, javac), JavaClassifierType {
++
++    override val classifier
++        get() = javac.resolve(treePath)
++
++    override val classifierQualifiedName
++        get() = (classifier as? JavaClass)?.fqName?.asString() ?: treePath.leaf.toString()
++
++    override val presentableText
++        get() = classifierQualifiedName
++
++    private val typeParameter
++        get() = treePath.filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }
++                .flatMap {
++                    when (it) {
++                        is JCTree.JCClassDecl -> it.typarams
++                        is JCTree.JCMethodDecl -> it.typarams
++                        else -> throw UnsupportedOperationException(""${it.kind} cannot have a type parameter"")","You can remove `.filter { ... }` above, and use `else -> emptyList()` here",2017-04-25 16:25:29
+828,"@@ -0,0 +1,75 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.wrappers.trees
++
++import com.sun.source.util.TreePath
++import com.sun.tools.javac.tree.JCTree
++import org.jetbrains.kotlin.javac.JavacWrapper
++import org.jetbrains.kotlin.javac.MockKotlinClassifier
++import org.jetbrains.kotlin.load.java.structure.*
++
++sealed class TreeBasedClassifierType<out T : JCTree>(tree: T,
++                                                     treePath: TreePath,
++                                                     javac: JavacWrapper) : TreeBasedType<T>(tree, treePath, javac), JavaClassifierType {
++
++    override val classifier
++        get() = javac.resolve(treePath)
++
++    override val classifierQualifiedName
++        get() = (classifier as? JavaClass)?.fqName?.asString() ?: treePath.leaf.toString()
++
++    override val presentableText
++        get() = classifierQualifiedName
++
++    private val typeParameter
++        get() = treePath.filter { it is JCTree.JCClassDecl || it is JCTree.JCMethodDecl }
++                .flatMap {
++                    when (it) {
++                        is JCTree.JCClassDecl -> it.typarams
++                        is JCTree.JCMethodDecl -> it.typarams
++                        else -> throw UnsupportedOperationException(""${it.kind} cannot have a type parameter"")
++                    }
++                }
++                .find { it.toString().substringBefore("" "") == treePath.leaf.toString() }
++
++}
++
++class TreeBasedClassifierTypeWithoutTypeArgument<out T : JCTree.JCExpression>(tree: T,",Consider renaming to `TreeBasedNonGenericClassifierType` and `TreeBasedGenericClassifierType`,2017-04-25 13:58:07
+98,"@@ -0,0 +1,77 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.plugin.JetBundle
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFile
++import com.intellij.psi.PsiFile
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import com.intellij.psi.PsiElement
++import com.intellij.refactoring.changeSignature.PsiCallReference
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import com.intellij.psi.PsiArrayAccessExpression
++import com.intellij.psi.impl.source.tree.java.PsiArrayAccessExpressionImpl
++import org.jetbrains.jet.lang.psi.JetVisitorVoid
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.plugin.quickfix.JetIntentionAction
++
++public class GetCallReplacementIntention : JetSelfTargetingIntention<JetDotQualifiedExpression>(""get.call.replacement"", javaClass()) {
++    var project : Project? = null
++
++    override fun invoke(project: Project, editor: Editor, file: PsiFile) {
++        this.project = project
++        super<JetSelfTargetingIntention>.invoke(project, editor, file)
++    }
++
++    override fun isApplicableTo(element: JetDotQualifiedExpression): Boolean {
++        val selector : JetCallExpression? = element.getSelectorExpression() as? JetCallExpression","Code formatting is inconsistent.
+",2014-01-27 21:29:48
+99,"@@ -0,0 +1,77 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.plugin.JetBundle
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFile
++import com.intellij.psi.PsiFile
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import com.intellij.psi.PsiElement
++import com.intellij.refactoring.changeSignature.PsiCallReference
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import com.intellij.psi.PsiArrayAccessExpression
++import com.intellij.psi.impl.source.tree.java.PsiArrayAccessExpressionImpl
++import org.jetbrains.jet.lang.psi.JetVisitorVoid
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.plugin.quickfix.JetIntentionAction
++
++public class GetCallReplacementIntention : JetSelfTargetingIntention<JetDotQualifiedExpression>(""get.call.replacement"", javaClass()) {
++    var project : Project? = null
++
++    override fun invoke(project: Project, editor: Editor, file: PsiFile) {
++        this.project = project
++        super<JetSelfTargetingIntention>.invoke(project, editor, file)
++    }
++
++    override fun isApplicableTo(element: JetDotQualifiedExpression): Boolean {
++        val selector : JetCallExpression? = element.getSelectorExpression() as? JetCallExpression
++        val callee : JetExpression? = selector?.getCalleeExpression()
++
++        return callee != null && callee.textMatches(""get"")
++    }
++
++    override fun applyTo(element: JetDotQualifiedExpression, editor: Editor) {
++        val selector : JetCallExpression? = element.getSelectorExpression() as? JetCallExpression
++        val callee : JetExpression? = selector?.getCalleeExpression()
++        val arguments = selector?.getValueArgumentList()
++        assert(arguments != null)
++        val argumentsText = arguments!!.getText()
++        assert(argumentsText != null)
++        val receiver : JetExpression = element.getReceiverExpression()
++        var arrayArgumentsText = """"
++
++        for (i in 0..argumentsText!!.length() - 1) {
++            when (i) {
++                0 -> arrayArgumentsText += ""[""
++                argumentsText.length() - 1 -> arrayArgumentsText += ""]""
++                else -> arrayArgumentsText += argumentsText[i]
++            }
++        }
++
++        if (project == null) {","No need to save project to local property: it can be obtained from `element`
+",2014-01-27 21:30:34
+171,"@@ -0,0 +1,78 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++import org.jetbrains.jet.lang.psi.JetCallableReferenceExpression
++
++public class ConvertAssertToIfWithThrowIntention : JetSelfTargetingIntention<JetCallExpression>(
++        ""convert.assert.to.if.with.throw"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        if (element.getCalleeExpression()?.getText() != ""assert"") return false
++        val arguments = element.getValueArguments().size
++        val lambdas = element.getFunctionLiteralArguments().size
++        if (!(arguments == 1 && (lambdas == 1 || lambdas == 0)) && arguments != 2) return false
++        val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        val resolvedCall = context[BindingContext.RESOLVED_CALL, element.getCalleeExpression()]
++        return resolvedCall?.getResultingDescriptor()?.getContainingDeclaration()?.getName().toString() == ""kotlin""
++    }
++
++    override fun applyTo(element: JetCallExpression, editor: Editor) {
++        val args = element.getValueArguments()
++        val condition = args[0]?.getArgumentExpression()
++        val lambdas = element.getFunctionLiteralArguments()
++
++        val messageExpr = if (args.size == 2) {
++            args[1]?.getArgumentExpression()
++        } else if (!lambdas.isEmpty()) {
++            element.getFunctionLiteralArguments()[0]
++        } else {
++            JetPsiFactory.createExpression(element.getProject(), ""\""Assertion failed\"""")","not sure on this line, basically i just want that string, but later i use messageExpr as an expression, so i was debating whether to create an expression with the string and then have easier handling at line 62, or i thought maybe setting messageExpr to be Any and then just assigning the string and adding a special check for String in line 62, probably more efficient but less readable.
+Ended up going for readability
+",2014-04-10 17:21:23
+120,"@@ -0,0 +1,78 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class ReplaceWithOperatorAssignIntention : JetSelfTargetingIntention<JetBinaryExpression>(""replace.with.operator.assign.intention"", javaClass()) {
++    override fun isApplicableTo(element: JetBinaryExpression): Boolean {
++        fun checkForNullSafety(element : JetBinaryExpression): Boolean {
++            val rightExpression = element.getRight()
++
++            return element.getLeft() != null &&
++                    element.getRight() != null &&
++                    element.getLeft() is JetSimpleNameExpression &&
++                    element.getOperationToken() == JetTokens.EQ &&
++                    rightExpression is JetBinaryExpression &&
++                    rightExpression.getLeft() != null &&
++                    rightExpression.getRight() != null","1) Extract `element.getLeft()` just like you did for `element.getRight()` (let's call it leftExpression)
+2) There is no point in using `element.getRight()`/`element.getLeft()` in comparisons since they are/will be extracted to variables
+3) `leftExpression !=null` is redundant (it's implied by `leftExpression is JetSimpleNameExpression`)
+The same goes for `element.getRight() != null`
+4) Also I'd change the function name since it doesn't just check for null safety. Something like `isWellFormedAssignment`, for example.
+",2014-02-25 14:58:08
+121,"@@ -0,0 +1,78 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class ReplaceWithOperatorAssignIntention : JetSelfTargetingIntention<JetBinaryExpression>(""replace.with.operator.assign.intention"", javaClass()) {
++    override fun isApplicableTo(element: JetBinaryExpression): Boolean {
++        fun checkForNullSafety(element : JetBinaryExpression): Boolean {
++            val rightExpression = element.getRight()
++
++            return element.getLeft() != null &&
++                    element.getRight() != null &&
++                    element.getLeft() is JetSimpleNameExpression &&
++                    element.getOperationToken() == JetTokens.EQ &&
++                    rightExpression is JetBinaryExpression &&
++                    rightExpression.getLeft() != null &&
++                    rightExpression.getRight() != null
++        }
++
++        fun checkExpressionRepeat(variableExpression: JetSimpleNameExpression, expression: JetBinaryExpression): Boolean {
++            if (variableExpression.getText().equals(expression.getLeft()!!.getText()))
++                return expression.getOperationToken() == JetTokens.PLUS ||
++                        expression.getOperationToken() == JetTokens.MINUS ||
++                        expression.getOperationToken() == JetTokens.MUL ||
++                        expression.getOperationToken() == JetTokens.DIV ||
++                        expression.getOperationToken() == JetTokens.PERC
++            else if (variableExpression.getText().equals(expression.getRight()!!.getText()))
++                return expression.getOperationToken() == JetTokens.PLUS ||
++                        expression.getOperationToken() == JetTokens.MUL
++            else if (expression.getLeft() is JetBinaryExpression)
++                return checkExpressionRepeat(variableExpression, expression.getLeft() as JetBinaryExpression)
++            else
++                return false
++        }
++","1) JetPsiMatcher class provides more reliable and generic way to compare PSI elements. Please, use it instead of comparing element text directly. For example, `JetPsiMatcher.checkElementMatch(variableExpression, expression.getLeft())`
+2) I suggest to use when expression instead of nested ""ifs"". Like this:
+
+```
+return when {
+    JetPsiMatcher.checkElementMatch(variableExpression, expression.getLeft()) -> ...
+    ...
+}
+```
+
+3) This function is tail-recursive, so it's worth annotating it with `tailRecursive`. Then compiler can apply tail-call optimization to it.
+",2014-02-25 15:21:24
+122,"@@ -0,0 +1,78 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lexer.JetTokens
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class ReplaceWithOperatorAssignIntention : JetSelfTargetingIntention<JetBinaryExpression>(""replace.with.operator.assign.intention"", javaClass()) {
++    override fun isApplicableTo(element: JetBinaryExpression): Boolean {
++        fun checkForNullSafety(element : JetBinaryExpression): Boolean {
++            val rightExpression = element.getRight()
++
++            return element.getLeft() != null &&
++                    element.getRight() != null &&
++                    element.getLeft() is JetSimpleNameExpression &&
++                    element.getOperationToken() == JetTokens.EQ &&
++                    rightExpression is JetBinaryExpression &&
++                    rightExpression.getLeft() != null &&
++                    rightExpression.getRight() != null
++        }
++
++        fun checkExpressionRepeat(variableExpression: JetSimpleNameExpression, expression: JetBinaryExpression): Boolean {
++            if (variableExpression.getText().equals(expression.getLeft()!!.getText()))
++                return expression.getOperationToken() == JetTokens.PLUS ||
++                        expression.getOperationToken() == JetTokens.MINUS ||
++                        expression.getOperationToken() == JetTokens.MUL ||
++                        expression.getOperationToken() == JetTokens.DIV ||
++                        expression.getOperationToken() == JetTokens.PERC
++            else if (variableExpression.getText().equals(expression.getRight()!!.getText()))
++                return expression.getOperationToken() == JetTokens.PLUS ||
++                        expression.getOperationToken() == JetTokens.MUL
++            else if (expression.getLeft() is JetBinaryExpression)
++                return checkExpressionRepeat(variableExpression, expression.getLeft() as JetBinaryExpression)
++            else
++                return false
++        }
++
++        if (checkForNullSafety(element)) {
++            return checkExpressionRepeat(element.getLeft() as JetSimpleNameExpression, element.getRight() as JetBinaryExpression)
++        } else {
++            return false
++        }
++    }
++
++    override fun applyTo(element: JetBinaryExpression, editor: Editor) {
++        fun buildReplacement(variableExpression: JetSimpleNameExpression, expression: JetBinaryExpression, replacementBuilder: StringBuilder): String {","This function is also tail-recursive, so please add [tailRecursive] annotation.
+",2014-02-25 16:12:47
+700,"@@ -0,0 +1,79 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.descriptors.ConstructorDescriptor
++import org.jetbrains.kotlin.descriptors.PropertyDescriptor
++import org.jetbrains.kotlin.descriptors.SimpleFunctionDescriptor
++import org.jetbrains.kotlin.load.java.components.JavaResolverCache
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.tail
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.lazy.ResolveSession
++import org.jetbrains.kotlin.resolve.lazy.ResolveSessionUtils
++import javax.inject.Inject
++
++class JavacJavaResolverCache : JavaResolverCache {",Here we also could extract `AbstractJavaResolverCache`,2017-04-05 12:56:06
+699,"@@ -0,0 +1,79 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.descriptors.ConstructorDescriptor
++import org.jetbrains.kotlin.descriptors.PropertyDescriptor
++import org.jetbrains.kotlin.descriptors.SimpleFunctionDescriptor
++import org.jetbrains.kotlin.load.java.components.JavaResolverCache
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.JavaElement
++import org.jetbrains.kotlin.load.java.structure.JavaField
++import org.jetbrains.kotlin.load.java.structure.JavaMethod
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.name.tail
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.lazy.ResolveSession
++import org.jetbrains.kotlin.resolve.lazy.ResolveSessionUtils
++import javax.inject.Inject
++
++class JavacJavaResolverCache : JavaResolverCache {
++
++    private lateinit var trace: BindingTrace
++    private lateinit var resolveSession: ResolveSession","In `LazyJavaResolverCache` both of them are `val`, why we do not want the same behaviour here?",2017-04-05 12:54:49
+52,"@@ -0,0 +1,8 @@
++// ""Create method 'get' from usage"" ""true""
++import java.util.ArrayList
++
++class Foo<T> {","Isn't it better to remove type parameter of class to avoid confusing when reading test? Or is it intentional?
+",2013-04-26 11:17:17
+34,"@@ -0,0 +1,8 @@
++enum class E {
++FOO
++fun foo() : Unit {
++FOO.toString()
++}
++public fun name() : String { return """" }
++public fun order() : Int { return 0 }
++}
+\ No newline at end of file","The same: code formatting is wrong
+",2013-02-21 14:58:31
+346,"@@ -0,0 +1,8 @@
++var status: String = ""fail""","I beleive it would be good to add comment explaining why ""status"" here is top-level property instead of local variable.
+",2015-03-26 15:33:16
+172,"@@ -0,0 +1,80 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++import org.jetbrains.jet.lang.psi.JetCallableReferenceExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++
++public class ConvertAssertToIfWithThrowIntention : JetSelfTargetingIntention<JetCallExpression>(
++        ""convert.assert.to.if.with.throw"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        if (element.getCalleeExpression()?.getText() != ""assert"") return false
++        val arguments = element.getValueArguments().size
++        val lambdas = element.getFunctionLiteralArguments().size
++        if (!(arguments == 1 && (lambdas == 1 || lambdas == 0)) && arguments != 2) return false
++        val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        val resolvedCall = context[BindingContext.RESOLVED_CALL, element.getCalleeExpression()]
++        if (resolvedCall == null) return false
++        return DescriptorUtils.getFqName(resolvedCall.getResultingDescriptor()).toString() == ""kotlin.assert""","fixed to use DescriptorUtils.getFqName
+",2014-04-14 22:32:03
+173,"@@ -0,0 +1,80 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.plugin.codeInsight.ShortenReferences
++import org.jetbrains.jet.lang.psi.JetCallableReferenceExpression
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++
++public class ConvertAssertToIfWithThrowIntention : JetSelfTargetingIntention<JetCallExpression>(
++        ""convert.assert.to.if.with.throw"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        if (element.getCalleeExpression()?.getText() != ""assert"") return false
++        val arguments = element.getValueArguments().size
++        val lambdas = element.getFunctionLiteralArguments().size
++        if (!(arguments == 1 && (lambdas == 1 || lambdas == 0)) && arguments != 2) return false
++        val context = AnalyzerFacadeWithCache.getContextForElement(element)
++        val resolvedCall = context[BindingContext.RESOLVED_CALL, element.getCalleeExpression()]
++        if (resolvedCall == null) return false
++        return DescriptorUtils.getFqName(resolvedCall.getResultingDescriptor()).toString() == ""kotlin.assert""
++    }
++
++    override fun applyTo(element: JetCallExpression, editor: Editor) {
++        val args = element.getValueArguments()
++        val condition = args[0]?.getArgumentExpression()
++        val lambdas = element.getFunctionLiteralArguments()
++
++        val messageExpr = if (args.size == 2) {
++            args[1]?.getArgumentExpression()
++        } else if (lambdas.isNotEmpty()) {","!lambdas.isEmpty changed to lambdas.isNotEmpty()
+",2014-04-14 22:32:53
+183,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {","Ditto (`paramsTextRange != null && caretLocation in paramsTextRange` or `paramsTextRange?.contains(caretLocation) ?: false`)
+",2014-04-16 18:26:38
+182,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false","Ditto
+",2014-04-16 18:25:53
+184,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val paramsTextRange = element.getFunctionLiteral().getValueParameterList()?.getTextRange()
++        val caretIsInParams = if (paramsTextRange != null) {
++            caretLocation in paramsTextRange
++        }
++        else false
++        if (!(caretLocation == openBraceOffset + 1 || caretLocation == closeBraceOffset || caretIsInParams)) return false
++
++        val params = element.getValueParameters()
++        val hasDeclaredParamsType = params.any { it.getTypeReference() != null }
++        val hasDeclaredReturnType = element.hasDeclaredReturnType()
++        val hasDeclaredReceiverType = element.getFunctionLiteral().getReceiverTypeRef() != null
++        if (hasDeclaredParamsType || hasDeclaredReturnType || hasDeclaredReceiverType) return true","I think I noticed the first time: such code creates a false sense that the applicability of the intention here depends on all three of these variables. Your code should look more like this:
+1. if has declared params type, return true
+2. if has declared return type, return true
+3. if has declared receiver type, return true
+4. return false
+
+Once you refactor your code to look like this, you'll notice that these variables are no longer needed since they can be inlined. This will make the code shorter. Please do this.
+",2014-04-16 18:29:37
+566,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.KtNodeTypes
++import org.jetbrains.kotlin.psi.*
++
++class RedundantIfInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitIfExpression(expression: KtIfExpression) {
++                super.visitIfExpression(expression)
++
++                if (expression.condition != null && isRedundant(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Redundant 'if' statement"",
++                                           ProblemHighlightType.LIKE_UNUSED_SYMBOL,
++                                           RemoveRedundantIf)
++                }
++            }
++        }
++    }
++
++    private fun isRedundant(expression: KtIfExpression): Boolean {
++        val thenReturn = getReturnedExpression(expression.then) ?: return false
++        val elseReturn = getReturnedExpression(expression.`else`) ?: return false
++
++        if (KtPsiUtil.isTrueConstant(thenReturn) && !KtPsiUtil.isTrueConstant(elseReturn)) {","I find it somewhat confusing that the KtNodeTypes.BOOLEAN_CONSTANT check is separate from the value check. It would be clearer to add the corresponding `isFalseConstant()` method to `KtPsiUtil` and to remove the node type check from `getReturnedExpression()`.
+",2016-05-18 13:37:45
+564,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.KtNodeTypes
++import org.jetbrains.kotlin.psi.*
++
++class RedundantIfInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitIfExpression(expression: KtIfExpression) {
++                super.visitIfExpression(expression)
++
++                if (expression.condition != null && isRedundant(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Redundant 'if' statement"",
++                                           ProblemHighlightType.LIKE_UNUSED_SYMBOL,
++                                           RemoveRedundantIf)
++                }
++            }
++        }
++    }
++
++    private fun isRedundant(expression: KtIfExpression): Boolean {
++        val thenReturn = getReturnedExpression(expression.then) ?: return false
++        val elseReturn = getReturnedExpression(expression.`else`) ?: return false
++
++        if (KtPsiUtil.isTrueConstant(thenReturn) && !KtPsiUtil.isTrueConstant(elseReturn)) {
++            return true
++        }
++
++        if (!KtPsiUtil.isTrueConstant(thenReturn) && KtPsiUtil.isTrueConstant(elseReturn)) {
++            return true
++        }
++
++        return false
++    }
++
++    private fun getReturnedExpression(expression: KtExpression?) : KtExpression? {
++        if (expression == null) return null
++        if (expression !is KtBlockExpression) return null","This check isn't necessary: a statement where `return` is not enclosed in braces is no less trivial.
+",2016-05-18 13:31:51
+565,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.KtNodeTypes
++import org.jetbrains.kotlin.psi.*
++
++class RedundantIfInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitIfExpression(expression: KtIfExpression) {
++                super.visitIfExpression(expression)
++
++                if (expression.condition != null && isRedundant(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Redundant 'if' statement"",
++                                           ProblemHighlightType.LIKE_UNUSED_SYMBOL,
++                                           RemoveRedundantIf)
++                }
++            }
++        }
++    }
++
++    private fun isRedundant(expression: KtIfExpression): Boolean {
++        val thenReturn = getReturnedExpression(expression.then) ?: return false
++        val elseReturn = getReturnedExpression(expression.`else`) ?: return false
++
++        if (KtPsiUtil.isTrueConstant(thenReturn) && !KtPsiUtil.isTrueConstant(elseReturn)) {
++            return true
++        }
++
++        if (!KtPsiUtil.isTrueConstant(thenReturn) && KtPsiUtil.isTrueConstant(elseReturn)) {
++            return true
++        }
++
++        return false
++    }
++
++    private fun getReturnedExpression(expression: KtExpression?) : KtExpression? {
++        if (expression == null) return null
++        if (expression !is KtBlockExpression) return null
++        if (expression.statements.size != 1) return null
++
++        val statement = expression.statements[0]","`expression.statements.singleOrNull() as? KtReturnExpression ?: return null`
+",2016-05-18 13:32:40
+536,"@@ -0,0 +1,81 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.util.IdeDescriptorRenderers
++import org.jetbrains.kotlin.idea.util.ShortenReferences
++import org.jetbrains.kotlin.psi.KtClassOrObject
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.resolve.DescriptorToSourceUtils
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.isInterface
++import org.jetbrains.kotlin.types.typeUtil.supertypes
++
++private fun KotlinType.renderShort() = IdeDescriptorRenderers.SOURCE_CODE_SHORT_NAMES_IN_TYPES.renderType(this)
++
++private fun KotlinType.getSuperTypesRecursive() = constructor.supertypes.let { it + it.flatMap { it.supertypes() } }","BTW, this is exponential; please use `TypeUtils#getAllSupertypes` instead
+",2016-04-01 14:19:36
+574,"@@ -0,0 +1,82 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.references.mainReference
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++
++class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    private val patterns = mapOf(
++            ""java.io.PrintStream.println"" to Pair(""println($0)"", ConversionType.METHOD),","What about other usages of  `PrintStream.println` outside of `System.out`, e.g. `System.err`? This will produce a lot of false positives.
+",2016-05-24 14:21:19
+595,"@@ -0,0 +1,82 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.references.mainReference
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++
++class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    private val patterns = mapOf(
++            ""java.io.PrintStream.println"" to Pair(""println($0)"", ConversionType.METHOD),
++            ""java.io.PrintStream.print"" to Pair(""print($0)"", ConversionType.METHOD),
++            ""java.util.Collections.sort"" to Pair(""$0.sort()"", ConversionType.METHOD),
++            ""java.util.HashMap.put"" to Pair(""$0[$1] = $2"", ConversionType.ASSIGNMENT)","Why limit to `HashMap`?
+",2016-08-25 12:50:11
+596,"@@ -0,0 +1,82 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.references.mainReference
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++
++class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++
++    private val patterns = mapOf(
++            ""java.io.PrintStream.println"" to Pair(""println($0)"", ConversionType.METHOD),
++            ""java.io.PrintStream.print"" to Pair(""print($0)"", ConversionType.METHOD),
++            ""java.util.Collections.sort"" to Pair(""$0.sort()"", ConversionType.METHOD),
++            ""java.util.HashMap.put"" to Pair(""$0[$1] = $2"", ConversionType.ASSIGNMENT)
++    )
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitQualifiedExpression(expression: KtQualifiedExpression) {
++                super.visitQualifiedExpression(expression)
++
++                val selectorExpression = expression.selectorExpression
++                if(selectorExpression !is KtCallExpression) return
++                val args = selectorExpression.valueArguments
++                if(args.isEmpty()) return
++
++                val calleeExpression = selectorExpression.calleeExpression as? KtSimpleNameExpression ?: return
++                val bindingContext = calleeExpression.analyze(BodyResolveMode.PARTIAL)
++                val target = calleeExpression.mainReference.resolveToDescriptors(bindingContext).singleOrNull() ?: return","You can use `findOriginalTopMostOverriddenDescriptors` e.g. to to get `MutableMap.put` instead of `HashMap.put`
+",2016-08-25 12:51:28
+531,"@@ -0,0 +1,82 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf
++
++private val JAVA_LANG_CLASS_FQ_NAME = FqName(""java.lang.Class"")
++
++private fun KotlinType.isJClass(): Boolean {
++    val expressionTypeFqName = constructor.declarationDescriptor?.fqNameSafe ?: return false
++    return expressionTypeFqName == JAVA_LANG_CLASS_FQ_NAME
++}
++
++class ConvertClassToKClassFix(element: KtDotQualifiedExpression, private val type: KotlinType) : KotlinQuickFixAction<KtDotQualifiedExpression>(element) {
++    override fun getText() = ""Remove '.${element.children.lastOrNull()?.text}'""
++    override fun getFamilyName() = ""Remove conversion from 'KClass' to 'Class'""
++
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (!super.isAvailable(project, editor, file)) return false
++
++        val expressionType = element.analyze(BodyResolveMode.PARTIAL).getType(element) ?: return false
++        if (!expressionType.isJClass()) return false
++
++        val children = element.children
++        if (children.size != 2) return false
++
++        val firstChild = children.first() as? KtExpression ?: return false
++        val firstChildType = firstChild.analyze(BodyResolveMode.PARTIAL).getType(firstChild) ?: return false","You should reuse the BindingContext from the first analyze() call.
+",2016-03-23 14:12:43
+532,"@@ -0,0 +1,82 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.codeInsight.intention.IntentionAction
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.descriptors.ClassDescriptor
++import org.jetbrains.kotlin.diagnostics.Diagnostic
++import org.jetbrains.kotlin.diagnostics.Errors
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.descriptorUtil.fqNameSafe
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++import org.jetbrains.kotlin.types.KotlinType
++import org.jetbrains.kotlin.types.typeUtil.isSubtypeOf
++
++private val JAVA_LANG_CLASS_FQ_NAME = FqName(""java.lang.Class"")
++
++private fun KotlinType.isJClass(): Boolean {
++    val expressionTypeFqName = constructor.declarationDescriptor?.fqNameSafe ?: return false
++    return expressionTypeFqName == JAVA_LANG_CLASS_FQ_NAME
++}
++
++class ConvertClassToKClassFix(element: KtDotQualifiedExpression, private val type: KotlinType) : KotlinQuickFixAction<KtDotQualifiedExpression>(element) {
++    override fun getText() = ""Remove '.${element.children.lastOrNull()?.text}'""
++    override fun getFamilyName() = ""Remove conversion from 'KClass' to 'Class'""
++
++
++    override fun isAvailable(project: Project, editor: Editor?, file: PsiFile): Boolean {
++        if (!super.isAvailable(project, editor, file)) return false
++
++        val expressionType = element.analyze(BodyResolveMode.PARTIAL).getType(element) ?: return false
++        if (!expressionType.isJClass()) return false
++
++        val children = element.children
++        if (children.size != 2) return false
++
++        val firstChild = children.first() as? KtExpression ?: return false
++        val firstChildType = firstChild.analyze(BodyResolveMode.PARTIAL).getType(firstChild) ?: return false
++
++        return firstChildType.isSubtypeOf(type)
++    }
++
++    override fun invoke(project: Project, editor: Editor?, file: KtFile) {
++        val lastChild = element.children.lastOrNull() ?: return
++        editor?.document?.replaceString(lastChild.startOffset - 1, lastChild.endOffset, """")","The quickfix will do nothing if there is no editor. It's possible to perform the change through the PSI, and it's better to do it that way.
+",2016-03-23 14:13:21
+697,"@@ -0,0 +1,82 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.components
++
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.vfs.VirtualFile
++import com.intellij.psi.search.DelegatingGlobalSearchScope
++import com.intellij.psi.search.GlobalSearchScope
++import org.jetbrains.kotlin.javac.Javac
++import org.jetbrains.kotlin.idea.KotlinFileType
++import org.jetbrains.kotlin.load.java.JavaClassFinder
++import org.jetbrains.kotlin.name.ClassId
++import org.jetbrains.kotlin.name.FqName
++import org.jetbrains.kotlin.resolve.BindingTrace
++import org.jetbrains.kotlin.resolve.CodeAnalyzerInitializer
++import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
++import javax.annotation.PostConstruct
++import javax.inject.Inject
++
++class JavacClassFinder : JavaClassFinder {",JavacBasedClassFinder?,2017-04-05 12:27:33
+229,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import com.intellij.psi.util.PsiTreeUtil
++import com.intellij.psi.PsiDocumentManager
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import com.intellij.codeInsight.template.TemplateBuilderImpl
++import com.intellij.codeInsight.template.impl.TemplateManagerImpl
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++import org.jetbrains.jet.analyzer.analyzeInContext
++import org.jetbrains.jet.lang.psi.JetCallExpression
++
++public class AddForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""add.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val loopRange = element.getLoopRange()!!
++        val newRangeText = ""${loopRange.getText()}.withIndices()""
++        val newRange = JetPsiFactory.createExpression(editor.getProject(), newRangeText)
++
++        //Roundabout way to create new multiparameter element so as not to incorrectly trigger syntax error highlighting
++        val loopParameter = element.getLoopParameter()!!
++        val parenthesizedParam = JetPsiFactory.createExpression(editor.getProject(), ""(index)"") as JetParenthesizedExpression
++        val indexElement = parenthesizedParam.getExpression()!!
++        val comma = JetPsiFactory.createComma(editor.getProject())
++        val newParamElement = JetPsiFactory.createExpression(editor.getProject(), "" ${loopParameter.getText()}"")
++        parenthesizedParam.addAfter(newParamElement, indexElement)
++        parenthesizedParam.addAfter(comma, indexElement)
++
++        loopParameter.replace(parenthesizedParam)
++        loopRange.replace(newRange)
++
++        val multiParameter = PsiTreeUtil.findChildOfType(element, indexElement.javaClass)!!
++
++        editor.getCaretModel().moveToOffset(multiParameter.getTextOffset())
++        val templateBuilder = TemplateBuilderImpl(multiParameter)
++        templateBuilder.replaceElement(multiParameter, ""index"")
++        val manager = TemplateManagerImpl(editor.getProject())
++        PsiDocumentManager.getInstance(editor.getProject()!!).doPostponedOperationsAndUnblockDocument(editor.getDocument())
++        manager.startTemplate(editor, templateBuilder.buildInlineTemplate()!!)
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getLoopParameter() == null) return false
++        val range = element.getLoopRange() ?: return false
++        if (range is JetDotQualifiedExpression) {
++            val selector = range.getSelectorExpression() ?: return true
++            if (selector.getText() == ""withIndices()"") return false","The same here, I wouldn't want **add withIndices** intention to be applicable where I've typed `withIndices ()`
+",2014-05-12 12:28:28
+226,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import com.intellij.psi.util.PsiTreeUtil
++import com.intellij.psi.PsiDocumentManager
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import com.intellij.codeInsight.template.TemplateBuilderImpl
++import com.intellij.codeInsight.template.impl.TemplateManagerImpl
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++import org.jetbrains.jet.analyzer.analyzeInContext
++import org.jetbrains.jet.lang.psi.JetCallExpression
++
++public class AddForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""add.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val loopRange = element.getLoopRange()!!
++        val newRangeText = ""${loopRange.getText()}.withIndices()""
++        val newRange = JetPsiFactory.createExpression(editor.getProject(), newRangeText)
++
++        //Roundabout way to create new multiparameter element so as not to incorrectly trigger syntax error highlighting
++        val loopParameter = element.getLoopParameter()!!
++        val parenthesizedParam = JetPsiFactory.createExpression(editor.getProject(), ""(index)"") as JetParenthesizedExpression
++        val indexElement = parenthesizedParam.getExpression()!!
++        val comma = JetPsiFactory.createComma(editor.getProject())
++        val newParamElement = JetPsiFactory.createExpression(editor.getProject(), "" ${loopParameter.getText()}"")
++        parenthesizedParam.addAfter(newParamElement, indexElement)
++        parenthesizedParam.addAfter(comma, indexElement)
++
++        loopParameter.replace(parenthesizedParam)
++        loopRange.replace(newRange)
++
++        val multiParameter = PsiTreeUtil.findChildOfType(element, indexElement.javaClass)!!
++
++        editor.getCaretModel().moveToOffset(multiParameter.getTextOffset())
++        val templateBuilder = TemplateBuilderImpl(multiParameter)
++        templateBuilder.replaceElement(multiParameter, ""index"")
++        val manager = TemplateManagerImpl(editor.getProject())
++        PsiDocumentManager.getInstance(editor.getProject()!!).doPostponedOperationsAndUnblockDocument(editor.getDocument())
++        manager.startTemplate(editor, templateBuilder.buildInlineTemplate()!!)
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getLoopParameter() == null) return false
++        val range = element.getLoopRange() ?: return false
++        if (range is JetDotQualifiedExpression) {
++            val selector = range.getSelectorExpression() ?: return true
++            if (selector.getText() == ""withIndices()"") return false
++        }
++
++        val potentialExpression = JetPsiFactory.createExpression(element.getProject(),
++                                                                 ""${range.getText()}.withIndices()"") as JetDotQualifiedExpression
++
++        val bindingContext = AnalyzerFacadeWithCache.getContextForElement(element)
++        val scope = bindingContext[BindingContext.RESOLUTION_SCOPE, element] ?: return false
++        val functionSelector = potentialExpression.getSelectorExpression() as JetCallExpression
++        val updatedContext = potentialExpression.analyzeInContext(scope)
++        val callScope = updatedContext[BindingContext.RESOLVED_CALL, functionSelector.getCalleeExpression()!!] ?: return false
++        val callFqName = DescriptorUtils.getFqNameSafe(callScope.getCandidateDescriptor())","You shouldn't call `getFqNameSafe`, because FQ name can be unsafe here (consider functions in class objects)
+",2014-05-12 12:21:10
+217,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.lang.cfg.PseudocodeVariablesData.VariableUseState
++import org.jetbrains.jet.lang.cfg.pseudocode.PseudocodeUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.cfg.JetFlowInformationProvider
++import org.jetbrains.jet.lang.cfg.JetControlFlowProcessor
++import com.intellij.debugger.jdi.LocalVariablesUtil
++import com.siyeh.ig.psiutils.VariableAccessUtils
++import com.google.dart.compiler.util.AstUtil
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        } else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getMultiParameter() == null) return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() ?: return false
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val indexVar = element.getMultiParameter()!!.getEntries()[0]
++
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar,false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        val usageCount = array(0)","Once again experience the power of Kotlin and just use a `var` here
+",2014-04-30 18:58:37
+219,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.lang.cfg.PseudocodeVariablesData.VariableUseState
++import org.jetbrains.jet.lang.cfg.pseudocode.PseudocodeUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.cfg.JetFlowInformationProvider
++import org.jetbrains.jet.lang.cfg.JetControlFlowProcessor
++import com.intellij.debugger.jdi.LocalVariablesUtil
++import com.siyeh.ig.psiutils.VariableAccessUtils
++import com.google.dart.compiler.util.AstUtil
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        } else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getMultiParameter() == null) return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() ?: return false
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val indexVar = element.getMultiParameter()!!.getEntries()[0]
++
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar,false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        val usageCount = array(0)
++        val usageFinderRunnable = object : Runnable {
++            override fun run() {
++                val processor = object : Processor<UsageInfo> {
++                    override fun process(t: UsageInfo?): Boolean {
++                        usageCount[0] = usageCount[0] + 1","How about `++`?
+",2014-04-30 19:13:00
+220,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.lang.cfg.PseudocodeVariablesData.VariableUseState
++import org.jetbrains.jet.lang.cfg.pseudocode.PseudocodeUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.cfg.JetFlowInformationProvider
++import org.jetbrains.jet.lang.cfg.JetControlFlowProcessor
++import com.intellij.debugger.jdi.LocalVariablesUtil
++import com.siyeh.ig.psiutils.VariableAccessUtils
++import com.google.dart.compiler.util.AstUtil
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        } else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getMultiParameter() == null) return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() ?: return false
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val indexVar = element.getMultiParameter()!!.getEntries()[0]
++
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar,false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        val usageCount = array(0)
++        val usageFinderRunnable = object : Runnable {
++            override fun run() {
++                val processor = object : Processor<UsageInfo> {
++                    override fun process(t: UsageInfo?): Boolean {
++                        usageCount[0] = usageCount[0] + 1
++                        return true","Do you really need to continue processing all usages if you've already found one? This also means that you should just have a boolean flag instead of an integer value
+",2014-04-30 19:13:56
+221,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.lang.cfg.PseudocodeVariablesData.VariableUseState
++import org.jetbrains.jet.lang.cfg.pseudocode.PseudocodeUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.cfg.JetFlowInformationProvider
++import org.jetbrains.jet.lang.cfg.JetControlFlowProcessor
++import com.intellij.debugger.jdi.LocalVariablesUtil
++import com.siyeh.ig.psiutils.VariableAccessUtils
++import com.google.dart.compiler.util.AstUtil
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        } else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getMultiParameter() == null) return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() ?: return false
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val indexVar = element.getMultiParameter()!!.getEntries()[0]
++
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar,false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        val usageCount = array(0)
++        val usageFinderRunnable = object : Runnable {
++            override fun run() {
++                val processor = object : Processor<UsageInfo> {
++                    override fun process(t: UsageInfo?): Boolean {
++                        usageCount[0] = usageCount[0] + 1
++                        return true
++                    }
++                }
++                findHandler.processElementUsages(indexVar,processor,options)","`Processor` is a Java interface with a single method (SAM interface), so you should be able to just pass a lambda instead of an object expression, thanks to SAM conversion in Kotlin
+",2014-04-30 19:16:23
+222,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.lang.cfg.PseudocodeVariablesData.VariableUseState
++import org.jetbrains.jet.lang.cfg.pseudocode.PseudocodeUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.cfg.JetFlowInformationProvider
++import org.jetbrains.jet.lang.cfg.JetControlFlowProcessor
++import com.intellij.debugger.jdi.LocalVariablesUtil
++import com.siyeh.ig.psiutils.VariableAccessUtils
++import com.google.dart.compiler.util.AstUtil
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        } else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getMultiParameter() == null) return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() ?: return false
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val indexVar = element.getMultiParameter()!!.getEntries()[0]
++
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar,false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        val usageCount = array(0)
++        val usageFinderRunnable = object : Runnable {
++            override fun run() {
++                val processor = object : Processor<UsageInfo> {
++                    override fun process(t: UsageInfo?): Boolean {
++                        usageCount[0] = usageCount[0] + 1
++                        return true
++                    }
++                }
++                findHandler.processElementUsages(indexVar,processor,options)
++            }
++        }
++        usageFinderRunnable.run()","I'm not sure what's the point in creating a `Runnable` and immediately running it?
+",2014-04-30 19:17:19
+218,"@@ -0,0 +1,83 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import org.jetbrains.jet.lang.cfg.PseudocodeVariablesData.VariableUseState
++import org.jetbrains.jet.lang.cfg.pseudocode.PseudocodeUtil
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.lang.psi.JetFile
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.cfg.JetFlowInformationProvider
++import org.jetbrains.jet.lang.cfg.JetControlFlowProcessor
++import com.intellij.debugger.jdi.LocalVariablesUtil
++import com.siyeh.ig.psiutils.VariableAccessUtils
++import com.google.dart.compiler.util.AstUtil
++import com.intellij.find.FindManager
++import com.intellij.find.impl.FindManagerImpl
++import com.intellij.usageView.UsageInfo
++import com.intellij.util.Processor
++import org.jetbrains.jet.plugin.findUsages.KotlinPropertyFindUsagesOptions
++
++public class RemoveForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""remove.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val parameter = element.getMultiParameter()!!
++        val range = element.getLoopRange() as JetDotQualifiedExpression
++        val parameters = parameter.getEntries()
++        if (parameters.size() == 2) {
++            parameter.replace(parameters[1])
++        } else {
++            JetPsiUtil.deleteElementWithDelimiters(parameters[0])
++        }
++
++        range.replace(range.getReceiverExpression())
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getMultiParameter() == null) return false
++        val range = element.getLoopRange() as? JetDotQualifiedExpression ?: return false
++        val selector = range.getSelectorExpression() ?: return false
++        if (!selector.textMatches(""withIndices()"")) return false
++
++        val indexVar = element.getMultiParameter()!!.getEntries()[0]
++
++        val findManager = FindManager.getInstance(element.getProject()) as FindManagerImpl
++        val findHandler = findManager.getFindUsagesManager().getFindUsagesHandler(indexVar,false) ?: return false
++        val options = KotlinPropertyFindUsagesOptions(element.getProject())
++        val usageCount = array(0)
++        val usageFinderRunnable = object : Runnable {
++            override fun run() {
++                val processor = object : Processor<UsageInfo> {
++                    override fun process(t: UsageInfo?): Boolean {
++                        usageCount[0] = usageCount[0] + 1
++                        return true
++                    }
++                }
++                findHandler.processElementUsages(indexVar,processor,options)
++            }
++        }
++        usageFinderRunnable.run()
++        return usageCount[0] == 0","Similarly to the first intention, I think we should check here if `withIndices` is actually resolved to `kotlin.withIndices` (don't forget about a test)
+",2014-04-30 19:08:27
+47,"@@ -0,0 +1,84 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.fileEditor.FileEditorManager;
++import com.intellij.openapi.project.Project;
++import com.intellij.openapi.vfs.VirtualFile;
++import com.intellij.psi.PsiElement;
++import com.intellij.psi.PsiFile;
++import com.intellij.psi.PsiReference;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.psi.*;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class CreateClassObjectFromUsageFix extends CreateFromUsageFixBase {
++    private final JetClass klass;
++
++    public CreateClassObjectFromUsageFix(@NotNull PsiElement element, @NotNull JetClass klass) {
++        super(element);
++        this.klass = klass;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""create.class.object.from.usage"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        PsiFile containingFile = klass.getContainingFile();
++        VirtualFile virtualFile = containingFile.getVirtualFile();
++        assert virtualFile != null;
++        FileEditorManager fileEditorManager = FileEditorManager.getInstance(project);
++        fileEditorManager.openFile(virtualFile, true);","This piece of code can be replaced with `NavigationUtil.activateFileWithPsiElement(klass)`
+",2013-04-26 11:07:40
+102,"@@ -0,0 +1,84 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.jet.plugin.intentions
++
++
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import com.intellij.psi.PsiElement
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.ValueArgument
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class GetToSquareBracketsIntention : JetSelfTargetingIntention<JetCallExpression>(""get.to.square.brackets"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        val expression = element.getCalleeExpression() as? JetSimpleNameExpression
++
++        if (expression?.getReferencedName() != ""get"")
++            return false
++
++        if (element.getValueArguments().isEmpty())
++            return false
++
++        val arguments = element.getValueArguments()","You declare this variable here, but for some reason only use it once: in other places, you still call `element.getValueArguments()`
+",2014-02-06 14:41:09
+104,"@@ -0,0 +1,84 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.jet.plugin.intentions
++
++
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import com.intellij.psi.PsiElement
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.ValueArgument
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class GetToSquareBracketsIntention : JetSelfTargetingIntention<JetCallExpression>(""get.to.square.brackets"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        val expression = element.getCalleeExpression() as? JetSimpleNameExpression
++
++        if (expression?.getReferencedName() != ""get"")
++            return false
++
++        if (element.getValueArguments().isEmpty())
++            return false
++
++        val arguments = element.getValueArguments()
++
++        for (argument in arguments) {
++            if (argument?.getArgumentExpression().equals(null))","Note that in Kotlin `==` is equivalent to `equals`. The former looks a lot more readable, so we usually prefer it over `equals`
+",2014-02-06 14:45:44
+103,"@@ -0,0 +1,84 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.jet.plugin.intentions
++
++
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import com.intellij.psi.PsiElement
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.ValueArgument
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class GetToSquareBracketsIntention : JetSelfTargetingIntention<JetCallExpression>(""get.to.square.brackets"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        val expression = element.getCalleeExpression() as? JetSimpleNameExpression
++
++        if (expression?.getReferencedName() != ""get"")
++            return false
++
++        if (element.getValueArguments().isEmpty())
++            return false
++
++        val arguments = element.getValueArguments()
++
++        for (argument in arguments) {
++            if (argument?.getArgumentExpression().equals(null))
++                return false
++        }
++
++        if (element.getValueArguments().any() { it!!.isNamed() })","Please don't just copy-paste code without adapting it :) Here you use `any`, but a few lines earlier you use a hand-written for-loop. You should attempt to use similar constructs for similar intents: either `any` everywhere, or for-loops everywhere. You can also combine these two and save a few lines
+",2014-02-06 14:44:19
+105,"@@ -0,0 +1,84 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.jet.plugin.intentions
++
++
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import com.intellij.psi.PsiElement
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.ValueArgument
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class GetToSquareBracketsIntention : JetSelfTargetingIntention<JetCallExpression>(""get.to.square.brackets"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        val expression = element.getCalleeExpression() as? JetSimpleNameExpression
++
++        if (expression?.getReferencedName() != ""get"")
++            return false
++
++        if (element.getValueArguments().isEmpty())
++            return false
++
++        val arguments = element.getValueArguments()
++
++        for (argument in arguments) {
++            if (argument?.getArgumentExpression().equals(null))
++                return false
++        }
++
++        if (element.getValueArguments().any() { it!!.isNamed() })
++            return false
++
++        return element.getTypeArguments().isEmpty() && element.getFunctionLiteralArguments().isEmpty()
++
++    }
++
++    override fun applyTo(element: JetCallExpression, editor: Editor) {
++        val parentElement = element.getParent()
++        val parentExpression: String?
++
++        if (parentElement is JetDotQualifiedExpression) {
++            parentExpression = parentElement.getReceiverExpression().getText()
++        } else {
++            return","`return` in `applyTo` should give you a hint that's something's not right: your `isApplicableTo` should've already filtered out inapplicable usages and `applyTo` should only _apply_ the intention on a good code. Here it appears that your intention says that it **is applicable** to expressions other than `JetDotQualifiedExpression` (in `isApplicable`), but `applyTo` doesn't do anything on them. As a result, your intention is available on `get(0)` (without any receiver expression), but does nothing, which is not right for an intention
+",2014-02-06 14:52:24
+106,"@@ -0,0 +1,84 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.jet.plugin.intentions
++
++
++import org.jetbrains.jet.plugin.intentions.JetSelfTargetingIntention
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++import com.intellij.psi.PsiElement
++import org.jetbrains.jet.lang.psi.JetArrayAccessExpression
++import org.jetbrains.jet.lang.psi.ValueArgument
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetSimpleNameExpression
++
++public class GetToSquareBracketsIntention : JetSelfTargetingIntention<JetCallExpression>(""get.to.square.brackets"", javaClass()) {
++
++    override fun isApplicableTo(element: JetCallExpression): Boolean {
++        val expression = element.getCalleeExpression() as? JetSimpleNameExpression
++
++        if (expression?.getReferencedName() != ""get"")
++            return false
++
++        if (element.getValueArguments().isEmpty())
++            return false
++
++        val arguments = element.getValueArguments()
++
++        for (argument in arguments) {
++            if (argument?.getArgumentExpression().equals(null))
++                return false
++        }
++
++        if (element.getValueArguments().any() { it!!.isNamed() })
++            return false
++
++        return element.getTypeArguments().isEmpty() && element.getFunctionLiteralArguments().isEmpty()
++
++    }
++
++    override fun applyTo(element: JetCallExpression, editor: Editor) {
++        val parentElement = element.getParent()
++        val parentExpression: String?
++
++        if (parentElement is JetDotQualifiedExpression) {
++            parentExpression = parentElement.getReceiverExpression().getText()
++        } else {
++            return
++        }
++        var expressionString = StringBuilder()
++        expressionString.append(parentExpression)
++        expressionString.append(""["")
++        val arguments = element.getValueArguments()
++        val numberOfArguments = arguments.size()","This variable is no longer used. Please watch out for compilation warnings in your code (yellow spots on the scroll bar in IDEA)
+",2014-02-06 14:53:32
+139,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lexer.JetTokens
++import com.intellij.psi.impl.source.tree.PsiErrorElementImpl
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++
++
++public class ConvertNegatedBooleanSequenceIntention : JetSelfTargetingIntention<JetBinaryExpression>(
++        ""convert.negated.boolean.sequence"", javaClass()) {
++
++    override fun isApplicableTo(element: JetBinaryExpression): Boolean {
++        if (element.getParent() is JetBinaryExpression) return false // operate only on the longest sequence
++        var binaryExpression = element : JetBinaryExpression?","Maybe 'var binaryExpression : JetBinaryExpression? = element' would be best
+",2014-03-17 16:21:22
+140,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lexer.JetTokens
++import com.intellij.psi.impl.source.tree.PsiErrorElementImpl
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++
++
++public class ConvertNegatedBooleanSequenceIntention : JetSelfTargetingIntention<JetBinaryExpression>(
++        ""convert.negated.boolean.sequence"", javaClass()) {
++
++    override fun isApplicableTo(element: JetBinaryExpression): Boolean {
++        if (element.getParent() is JetBinaryExpression) return false // operate only on the longest sequence
++        var binaryExpression = element : JetBinaryExpression?
++        val originalOperator = element.getOperationToken()
++","What about Demorgan transformation here?
+",2014-03-17 16:23:19
+141,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetPrefixExpression
++import org.jetbrains.jet.lexer.JetTokens
++import com.intellij.psi.impl.source.tree.PsiErrorElementImpl
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import org.jetbrains.jet.lang.psi.JetPsiUtil
++
++
++public class ConvertNegatedBooleanSequenceIntention : JetSelfTargetingIntention<JetBinaryExpression>(
++        ""convert.negated.boolean.sequence"", javaClass()) {
++
++    override fun isApplicableTo(element: JetBinaryExpression): Boolean {
++        if (element.getParent() is JetBinaryExpression) return false // operate only on the longest sequence
++        var binaryExpression = element : JetBinaryExpression?
++        val originalOperator = element.getOperationToken()
++
++        if (!(originalOperator == (JetTokens.ANDAND)) && !(originalOperator == (JetTokens.OROR))) {
++            return false
++        }
++
++        do {
++            val leftChild = binaryExpression?.getFirstChild()
++            val rightChild = binaryExpression?.getLastChild()
++            val operator = binaryExpression?.getOperationToken()
++            when {
++                rightChild !is JetPrefixExpression,
++                rightChild is PsiErrorElementImpl,","Why you need 'rightChild is PsiErrorElementImpl' check?
+",2014-03-17 16:36:45
+943,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RemoveRedundantBackticksInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {","This still handles only a random subset of PSI elements. The correct way to handle this is to override `visitKtElement` and to look for all children with element type `KtTokens.IDENTIFIER`, similar to how it's done [here](https://github.com/JetBrains/intellij-community/blob/b6dcce52194f52c921c414b7ccc01dbb3363cc7d/platform/core-impl/src/com/intellij/extapi/psi/ASTDelegatePsiElement.java#L230)",2017-08-03 10:58:38
+947,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RemoveRedundantBackticksInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                val nameIdentifier = property.nameIdentifier ?: return
++                if (isRedundantBackticks(nameIdentifier)) {
++                    registerProblem(holder, nameIdentifier)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                function.valueParameters.map {
++                    val nameIdentifier = it.nameIdentifier ?: return@map
++                    if (isRedundantBackticks(nameIdentifier)) {
++                        registerProblem(holder, nameIdentifier)
++                    }
++                }
++            }
++
++            override fun visitReferenceExpression(expression: KtReferenceExpression) {
++                super.visitReferenceExpression(expression)
++                val bindingContext = expression.analyze()
++                expression.getResolvedCall(bindingContext) ?: return
++                if (isRedundantBackticks(expression)) {
++                    registerProblem(holder, expression)
++                }
++            }
++        }
++    }
++
++    private fun isKeyword(text: String): Boolean {",Backticks can also be used to enclose identifiers containing spaces and other characters not allowed in Java identifiers. In this case they must not be highlighted as redundant.,2017-08-03 11:04:43
+944,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RemoveRedundantBackticksInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                val nameIdentifier = property.nameIdentifier ?: return
++                if (isRedundantBackticks(nameIdentifier)) {
++                    registerProblem(holder, nameIdentifier)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                function.valueParameters.map {
++                    val nameIdentifier = it.nameIdentifier ?: return@map
++                    if (isRedundantBackticks(nameIdentifier)) {
++                        registerProblem(holder, nameIdentifier)
++                    }
++                }
++            }
++
++            override fun visitReferenceExpression(expression: KtReferenceExpression) {
++                super.visitReferenceExpression(expression)
++                val bindingContext = expression.analyze()
++                expression.getResolvedCall(bindingContext) ?: return
++                if (isRedundantBackticks(expression)) {
++                    registerProblem(holder, expression)
++                }
++            }
++        }
++    }
++
++    private fun isKeyword(text: String): Boolean {
++        return (KtTokens.KEYWORDS.types + KtTokens.SOFT_KEYWORDS.types).any { it.toString() == text }
++    }
++
++    private fun isRedundantBackticks(element: PsiElement): Boolean {
++        return (element.text.contains(""^`.+`$"".toRegex()) &&",Please don't use regular expressions here. Use `startsWith` and `endsWith`.,2017-08-03 10:59:26
+945,"@@ -0,0 +1,85 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElement
++import com.intellij.psi.PsiElementVisitor
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RemoveRedundantBackticksInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                val nameIdentifier = property.nameIdentifier ?: return
++                if (isRedundantBackticks(nameIdentifier)) {
++                    registerProblem(holder, nameIdentifier)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                function.valueParameters.map {
++                    val nameIdentifier = it.nameIdentifier ?: return@map
++                    if (isRedundantBackticks(nameIdentifier)) {
++                        registerProblem(holder, nameIdentifier)
++                    }
++                }
++            }
++
++            override fun visitReferenceExpression(expression: KtReferenceExpression) {
++                super.visitReferenceExpression(expression)
++                val bindingContext = expression.analyze()
++                expression.getResolvedCall(bindingContext) ?: return
++                if (isRedundantBackticks(expression)) {
++                    registerProblem(holder, expression)
++                }
++            }
++        }
++    }
++
++    private fun isKeyword(text: String): Boolean {
++        return (KtTokens.KEYWORDS.types + KtTokens.SOFT_KEYWORDS.types).any { it.toString() == text }
++    }
++
++    private fun isRedundantBackticks(element: PsiElement): Boolean {
++        return (element.text.contains(""^`.+`$"".toRegex()) &&
++                !isKeyword(element.text.removePrefix(""`"").removeSuffix(""`"")))
++    }
++
++    private fun registerProblem(holder: ProblemsHolder, element: PsiElement) {
++        holder.registerProblem(element,
++                               ""Remove redundant backticks"",
++                               ProblemHighlightType.GENERIC_ERROR_OR_WARNING,
++                               RemoveRedundantBackticksQuickFix())
++    }
++}
++
++class RemoveRedundantBackticksQuickFix : LocalQuickFix {
++    override fun getName() = ""Remove redundant backticks""
++    override fun getFamilyName() = name
++
++    override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
++        val element = descriptor.psiElement
++        val factory = KtPsiFactory(project)
++        element.replace(factory.createExpression(element.text.removePrefix(""`"").removeSuffix(""`"")))","If you replace an arbitrary element in a PSI tree (such as the name identifier of a property) with an expression, this will create an invalid PSI structure and will break other code insight features until the file contents is reparsed. You need to always replace an element with another element of the same type (in this case, an identifier with an identifier). Use `KtPsiFactory.createIdentifier()`.",2017-08-03 11:02:32
+41,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.psi.JetParameter;
++import org.jetbrains.jet.lang.psi.JetPsiFactory;
++import org.jetbrains.jet.lang.psi.JetTypeReference;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class ChangeTypeFix extends JetIntentionAction<JetTypeReference> {
++    private JetType type;","Field may be 'final'
+",2013-04-17 09:37:49
+44,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.psi.JetParameter;
++import org.jetbrains.jet.lang.psi.JetPsiFactory;
++import org.jetbrains.jet.lang.psi.JetTypeReference;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class ChangeTypeFix extends JetIntentionAction<JetTypeReference> {
++    private JetType type;
++
++    public ChangeTypeFix(@NotNull JetTypeReference element, JetType type) {
++        super(element);
++        this.type = type;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""change.type"", element.getText(), type);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""change.type.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        element.replace(JetPsiFactory.createType(project, type.toString()));
++    }
++
++    @NotNull
++    public static JetIntentionActionFactory createFactoryForExpectedParameterTypeMismatch() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetParameter property = QuickFixUtil.getParentElementOfType(diagnostic, JetParameter.class);","Add please checking for diagnostic factory. Look like line 91 in `idea/src/org/jetbrains/jet/plugin/quickfix/AddStarProjectionsFix.java`
+",2013-04-17 10:12:08
+42,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.psi.JetParameter;
++import org.jetbrains.jet.lang.psi.JetPsiFactory;
++import org.jetbrains.jet.lang.psi.JetTypeReference;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class ChangeTypeFix extends JetIntentionAction<JetTypeReference> {
++    private JetType type;
++
++    public ChangeTypeFix(@NotNull JetTypeReference element, JetType type) {
++        super(element);
++        this.type = type;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""change.type"", element.getText(), type);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""change.type.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        element.replace(JetPsiFactory.createType(project, type.toString()));
++    }
++
++    @NotNull
++    public static JetIntentionActionFactory createFactoryForExpectedParameterTypeMismatch() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetParameter property = QuickFixUtil.getParentElementOfType(diagnostic, JetParameter.class);
++                assert property != null : ""EXPECTED_PARAMETER_TYPE_MISMATCH reported on element that is not within any property"";
++                JetTypeReference typeReference = property.getTypeReference();
++                JetType type = ((DiagnosticWithParameters1<JetParameter, JetType>) diagnostic).getA();","Use SuppressWarnings, please, like line 92-95 in `idea/src/org/jetbrains/jet/plugin/quickfix/AddStarProjectionsFix.java`
+",2013-04-17 09:41:37
+45,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.psi.JetParameter;
++import org.jetbrains.jet.lang.psi.JetPsiFactory;
++import org.jetbrains.jet.lang.psi.JetTypeReference;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class ChangeTypeFix extends JetIntentionAction<JetTypeReference> {
++    private JetType type;
++
++    public ChangeTypeFix(@NotNull JetTypeReference element, JetType type) {
++        super(element);
++        this.type = type;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""change.type"", element.getText(), type);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""change.type.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        element.replace(JetPsiFactory.createType(project, type.toString()));
++    }
++
++    @NotNull
++    public static JetIntentionActionFactory createFactoryForExpectedParameterTypeMismatch() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetParameter property = QuickFixUtil.getParentElementOfType(diagnostic, JetParameter.class);
++                assert property != null : ""EXPECTED_PARAMETER_TYPE_MISMATCH reported on element that is not within any property"";
++                JetTypeReference typeReference = property.getTypeReference();
++                JetType type = ((DiagnosticWithParameters1<JetParameter, JetType>) diagnostic).getA();
++                return typeReference == null ? null : new ChangeTypeFix(typeReference, type);","Maybe `typeReference == null` should be just `assert`
+",2013-04-17 11:05:31
+43,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2013 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.quickfix;
++
++import com.intellij.codeInsight.intention.IntentionAction;
++import com.intellij.openapi.editor.Editor;
++import com.intellij.openapi.project.Project;
++import com.intellij.psi.PsiFile;
++import com.intellij.util.IncorrectOperationException;
++import org.jetbrains.annotations.NotNull;
++import org.jetbrains.annotations.Nullable;
++import org.jetbrains.jet.lang.diagnostics.Diagnostic;
++import org.jetbrains.jet.lang.diagnostics.DiagnosticWithParameters1;
++import org.jetbrains.jet.lang.psi.JetParameter;
++import org.jetbrains.jet.lang.psi.JetPsiFactory;
++import org.jetbrains.jet.lang.psi.JetTypeReference;
++import org.jetbrains.jet.lang.types.JetType;
++import org.jetbrains.jet.plugin.JetBundle;
++
++public class ChangeTypeFix extends JetIntentionAction<JetTypeReference> {
++    private JetType type;
++
++    public ChangeTypeFix(@NotNull JetTypeReference element, JetType type) {
++        super(element);
++        this.type = type;
++    }
++
++    @NotNull
++    @Override
++    public String getText() {
++        return JetBundle.message(""change.type"", element.getText(), type);
++    }
++
++    @NotNull
++    @Override
++    public String getFamilyName() {
++        return JetBundle.message(""change.type.family"");
++    }
++
++    @Override
++    public void invoke(@NotNull Project project, Editor editor, PsiFile file) throws IncorrectOperationException {
++        element.replace(JetPsiFactory.createType(project, type.toString()));
++    }
++
++    @NotNull
++    public static JetIntentionActionFactory createFactoryForExpectedParameterTypeMismatch() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetParameter property = QuickFixUtil.getParentElementOfType(diagnostic, JetParameter.class);
++                assert property != null : ""EXPECTED_PARAMETER_TYPE_MISMATCH reported on element that is not within any property"";
++                JetTypeReference typeReference = property.getTypeReference();
++                JetType type = ((DiagnosticWithParameters1<JetParameter, JetType>) diagnostic).getA();
++                return typeReference == null ? null : new ChangeTypeFix(typeReference, type);
++            }
++        };
++    }
++
++    @NotNull
++    public static JetIntentionActionFactory createFactoryForExpectedReturnTypeMismatch() {
++        return new JetIntentionActionFactory() {
++            @Nullable
++            @Override
++            public IntentionAction createAction(Diagnostic diagnostic) {
++                JetTypeReference typeReference = QuickFixUtil.getParentElementOfType(diagnostic, JetTypeReference.class);
++                assert typeReference != null : ""EXPECTED_RETURN_TYPE_MISMATCH reported on element that is not a type reference"";
++                JetType type = ((DiagnosticWithParameters1<JetTypeReference, JetType>) diagnostic).getA();","Use SuppressWarnings, please.
+",2013-04-17 09:41:54
+215,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import com.intellij.psi.util.PsiTreeUtil
++import com.intellij.psi.PsiDocumentManager
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.di.InjectorForMacros
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.types.TypeUtils
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.resolve.calls.autocasts.DataFlowInfo
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import com.intellij.codeInsight.template.TemplateBuilderImpl
++import com.intellij.codeInsight.template.impl.TemplateManagerImpl
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++import org.jetbrains.jet.lang.descriptors.ModuleDescriptor
++
++
++public class AddForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""add.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val loopRange = element.getLoopRange()!!
++        val newRangeText = ""${loopRange.getText()}.withIndices()""
++        val newRange = JetPsiFactory.createExpression(editor.getProject(), newRangeText)
++
++        //Roundabout way to create new multiparameter element so as not to incorrectly trigger syntax error highlighting
++        val loopParameter = element.getLoopParameter()!!
++        val parenthesizedParam = JetPsiFactory.createExpression(editor.getProject(), ""(index)"") as JetParenthesizedExpression
++        val indexElement = parenthesizedParam.getExpression()!!
++        val comma = JetPsiFactory.createComma(editor.getProject())
++        val newParamElement = JetPsiFactory.createExpression(editor.getProject(), "" ${loopParameter.getText()}"")
++        parenthesizedParam.addAfter(newParamElement, indexElement)
++        parenthesizedParam.addAfter(comma, indexElement)
++
++        loopParameter.replace(parenthesizedParam)
++        loopRange.replace(newRange)
++
++        val multiParameter = PsiTreeUtil.findChildOfType(element, indexElement.javaClass)!!
++
++        editor.getCaretModel().moveToOffset(multiParameter.getTextOffset())
++        val templateBuilder = TemplateBuilderImpl(multiParameter)
++        templateBuilder.replaceElement(multiParameter, ""index"")
++        val manager = TemplateManagerImpl(editor.getProject())
++        PsiDocumentManager.getInstance(editor.getProject()!!).doPostponedOperationsAndUnblockDocument(editor.getDocument())
++        manager.startTemplate(editor, templateBuilder.buildInlineTemplate()!!)
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getLoopParameter() == null) return false
++        val range = element.getLoopRange() ?: return false
++        if (range is JetDotQualifiedExpression) {
++            val selector = (range as JetDotQualifiedExpression).getSelectorExpression() ?: return true","You don't need this cast (experience the power of Kotlin)
+",2014-04-30 18:55:57
+216,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import com.intellij.psi.util.PsiTreeUtil
++import com.intellij.psi.PsiDocumentManager
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.di.InjectorForMacros
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.types.TypeUtils
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.resolve.calls.autocasts.DataFlowInfo
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import com.intellij.codeInsight.template.TemplateBuilderImpl
++import com.intellij.codeInsight.template.impl.TemplateManagerImpl
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++import org.jetbrains.jet.lang.descriptors.ModuleDescriptor
++
++
++public class AddForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""add.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val loopRange = element.getLoopRange()!!
++        val newRangeText = ""${loopRange.getText()}.withIndices()""
++        val newRange = JetPsiFactory.createExpression(editor.getProject(), newRangeText)
++
++        //Roundabout way to create new multiparameter element so as not to incorrectly trigger syntax error highlighting
++        val loopParameter = element.getLoopParameter()!!
++        val parenthesizedParam = JetPsiFactory.createExpression(editor.getProject(), ""(index)"") as JetParenthesizedExpression
++        val indexElement = parenthesizedParam.getExpression()!!
++        val comma = JetPsiFactory.createComma(editor.getProject())
++        val newParamElement = JetPsiFactory.createExpression(editor.getProject(), "" ${loopParameter.getText()}"")
++        parenthesizedParam.addAfter(newParamElement, indexElement)
++        parenthesizedParam.addAfter(comma, indexElement)
++
++        loopParameter.replace(parenthesizedParam)
++        loopRange.replace(newRange)
++
++        val multiParameter = PsiTreeUtil.findChildOfType(element, indexElement.javaClass)!!
++
++        editor.getCaretModel().moveToOffset(multiParameter.getTextOffset())
++        val templateBuilder = TemplateBuilderImpl(multiParameter)
++        templateBuilder.replaceElement(multiParameter, ""index"")
++        val manager = TemplateManagerImpl(editor.getProject())
++        PsiDocumentManager.getInstance(editor.getProject()!!).doPostponedOperationsAndUnblockDocument(editor.getDocument())
++        manager.startTemplate(editor, templateBuilder.buildInlineTemplate()!!)
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getLoopParameter() == null) return false
++        val range = element.getLoopRange() ?: return false
++        if (range is JetDotQualifiedExpression) {
++            val selector = (range as JetDotQualifiedExpression).getSelectorExpression() ?: return true
++            if (selector.getText().equals(""withIndices()"")) return false","Please use `==` instead of `equals` in Kotlin code
+",2014-04-30 18:56:26
+212,"@@ -0,0 +1,87 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import com.intellij.psi.util.PsiTreeUtil
++import com.intellij.psi.PsiDocumentManager
++import org.jetbrains.jet.plugin.project.AnalyzerFacadeWithCache
++import org.jetbrains.jet.di.InjectorForMacros
++import org.jetbrains.jet.lang.resolve.BindingContext
++import org.jetbrains.jet.lang.types.TypeUtils
++import org.jetbrains.jet.lang.resolve.ObservableBindingTrace
++import org.jetbrains.jet.lang.resolve.BindingTraceContext
++import org.jetbrains.jet.lang.resolve.calls.autocasts.DataFlowInfo
++import org.jetbrains.jet.lang.psi.JetParenthesizedExpression
++import com.intellij.codeInsight.template.TemplateBuilderImpl
++import com.intellij.codeInsight.template.impl.TemplateManagerImpl
++import org.jetbrains.jet.lang.resolve.DescriptorUtils
++import org.jetbrains.jet.lang.descriptors.ModuleDescriptor
++
++
++public class AddForLoopIndicesIntention : JetSelfTargetingIntention<JetForExpression>(
++        ""add.for.loop.indices"", javaClass()) {
++    override fun applyTo(element: JetForExpression, editor: Editor) {
++        val loopRange = element.getLoopRange()!!
++        val newRangeText = ""${loopRange.getText()}.withIndices()""
++        val newRange = JetPsiFactory.createExpression(editor.getProject(), newRangeText)
++
++        //Roundabout way to create new multiparameter element so as not to incorrectly trigger syntax error highlighting
++        val loopParameter = element.getLoopParameter()!!
++        val parenthesizedParam = JetPsiFactory.createExpression(editor.getProject(), ""(index)"") as JetParenthesizedExpression
++        val indexElement = parenthesizedParam.getExpression()!!
++        val comma = JetPsiFactory.createComma(editor.getProject())
++        val newParamElement = JetPsiFactory.createExpression(editor.getProject(), "" ${loopParameter.getText()}"")
++        parenthesizedParam.addAfter(newParamElement, indexElement)
++        parenthesizedParam.addAfter(comma, indexElement)
++
++        loopParameter.replace(parenthesizedParam)
++        loopRange.replace(newRange)
++
++        val multiParameter = PsiTreeUtil.findChildOfType(element, indexElement.javaClass)!!
++
++        editor.getCaretModel().moveToOffset(multiParameter.getTextOffset())
++        val templateBuilder = TemplateBuilderImpl(multiParameter)
++        templateBuilder.replaceElement(multiParameter, ""index"")
++        val manager = TemplateManagerImpl(editor.getProject())
++        PsiDocumentManager.getInstance(editor.getProject()!!).doPostponedOperationsAndUnblockDocument(editor.getDocument())
++        manager.startTemplate(editor, templateBuilder.buildInlineTemplate()!!)
++    }
++
++    override fun isApplicableTo(element: JetForExpression): Boolean {
++        if (element.getLoopParameter() == null) return false
++        val range = element.getLoopRange() ?: return false
++        if (range is JetDotQualifiedExpression) {
++            val selector = (range as JetDotQualifiedExpression).getSelectorExpression() ?: return true
++            if (selector.getText().equals(""withIndices()"")) return false
++        }
++
++        val potentialExpression = JetPsiFactory.createExpression(element.getProject(), ""${range.getText()}.withIndices()"")
++        val bindingContext = AnalyzerFacadeWithCache.getContextForElement(element)
++        val scope = bindingContext[BindingContext.RESOLUTION_SCOPE, element] ?: return false
++        val module = DescriptorUtils.getParentOfType(scope.getContainingDeclaration(), javaClass<ModuleDescriptor>())!!
++        val components = InjectorForMacros(element.getProject(), module)
++        val dataFlowInfo = bindingContext[BindingContext.NON_DEFAULT_EXPRESSION_DATA_FLOW, element] ?: DataFlowInfo.EMPTY
++        val bindingTrace = ObservableBindingTrace(BindingTraceContext())
++        val expressionType = components.getExpressionTypingServices()!!.getTypeInfo(scope, potentialExpression, TypeUtils.NO_EXPECTED_TYPE, dataFlowInfo, bindingTrace)
++        return expressionType.getType() != null","Do you allow to use the intention only if the resulting code will be green? In that case, I'm not sure what's wrong, but it's still applicable whenever there are errors in the initial code, e.g.
+
+```
+fun foo() {
+    for (a in b) { // <-- still applicable here, although 'b' is unresolved
+    }
+}
+```
+",2014-04-30 18:12:56
+883,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.impl.source.tree.LeafPsiElement
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.imports.importableFqName
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RedundantProgressionStepInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                if (isStepOneCall(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Iteration step is redundant. Recommended to remove it."",","No need to say ""Recommended..."" in the problem description; ""redundant"" implies that already.",2017-07-07 11:46:31
+886,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.impl.source.tree.LeafPsiElement
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.imports.importableFqName
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RedundantProgressionStepInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                if (isStepOneCall(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Iteration step is redundant. Recommended to remove it."",
++                                           ProblemHighlightType.WEAK_WARNING,
++                                           TextRange(expression.operationReference.startOffsetInParent, expression.endOffset - expression.startOffset),
++                                           EliminateStepOneFix())
++                }
++            }
++        }
++    }
++
++
++    class EliminateStepOneFix : LocalQuickFix {
++        override fun getName() = ""Eliminate redundant iteration step size""
++
++        override fun getFamilyName() = name
++
++        override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
++            if (!FileModificationService.getInstance().preparePsiElementForWrite(descriptor.psiElement)) return
++            val expression = descriptor.psiElement as? KtBinaryExpression ?: return","This only handles ""step"" called as an infix function; would be better to handle regular ""step"" calls too.",2017-07-07 11:54:53
+885,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.impl.source.tree.LeafPsiElement
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.imports.importableFqName
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RedundantProgressionStepInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                if (isStepOneCall(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Iteration step is redundant. Recommended to remove it."",
++                                           ProblemHighlightType.WEAK_WARNING,
++                                           TextRange(expression.operationReference.startOffsetInParent, expression.endOffset - expression.startOffset),
++                                           EliminateStepOneFix())
++                }
++            }
++        }
++    }
++
++
++    class EliminateStepOneFix : LocalQuickFix {
++        override fun getName() = ""Eliminate redundant iteration step size""
++
++        override fun getFamilyName() = name
++
++        override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
++            if (!FileModificationService.getInstance().preparePsiElementForWrite(descriptor.psiElement)) return
++            val expression = descriptor.psiElement as? KtBinaryExpression ?: return
++            if (!isStepOneCall(expression)) return
++            expression.replaced(expression.left!!)
++        }
++    }
++
++    companion object {
++        private val STEP_FUNCTION_FQ_NAME = ""kotlin.ranges.step""
++
++        fun isStepOneCall(expression: KtBinaryExpression): Boolean {
++            val left = expression.left as? KtBinaryExpression ?: return false",You should use KtPsiUtil.deparenthesize() to handle the case when the range expression is in parentheses.,2017-07-07 11:53:29
+884,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import com.intellij.openapi.util.TextRange
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.impl.source.tree.LeafPsiElement
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.idea.imports.importableFqName
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.KtBinaryExpression
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtVisitorVoid
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
++import org.jetbrains.kotlin.resolve.BindingContext
++import org.jetbrains.kotlin.resolve.calls.callUtil.getResolvedCall
++
++class RedundantProgressionStepInspection : AbstractKotlinInspection() {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitBinaryExpression(expression: KtBinaryExpression) {
++                if (isStepOneCall(expression)) {
++                    holder.registerProblem(expression,
++                                           ""Iteration step is redundant. Recommended to remove it."",
++                                           ProblemHighlightType.WEAK_WARNING,
++                                           TextRange(expression.operationReference.startOffsetInParent, expression.endOffset - expression.startOffset),
++                                           EliminateStepOneFix())
++                }
++            }
++        }
++    }
++
++
++    class EliminateStepOneFix : LocalQuickFix {
++        override fun getName() = ""Eliminate redundant iteration step size""
++
++        override fun getFamilyName() = name
++
++        override fun applyFix(project: Project, descriptor: ProblemDescriptor) {
++            if (!FileModificationService.getInstance().preparePsiElementForWrite(descriptor.psiElement)) return
++            val expression = descriptor.psiElement as? KtBinaryExpression ?: return
++            if (!isStepOneCall(expression)) return
++            expression.replaced(expression.left!!)
++        }
++    }
++
++    companion object {
++        private val STEP_FUNCTION_FQ_NAME = ""kotlin.ranges.step""
++
++        fun isStepOneCall(expression: KtBinaryExpression): Boolean {
++            val left = expression.left as? KtBinaryExpression ?: return false
++            if (left.operationToken != KtTokens.RANGE) return false
++            if (expression.operationReference.text != ""step"") return false
++            val right = expression.right as? KtConstantExpression ?: return false
++            val rightConst = right.firstChild as? LeafPsiElement ?: return false
++            if (rightConst.elementType != KtTokens.INTEGER_LITERAL) return false
++
++            if (rightConst.text !in setOf(""1"", ""1L"")) return false",Please use ConstantExpressionEvaluator.getConstant() instead.,2017-07-07 11:51:57
+854,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.addRemoveModifier.addModifier
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {","This should check val/var parameters defined in the primary constructor, too (KtParameter)",2017-05-16 15:24:22
+855,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.addRemoveModifier.addModifier
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (canBePrivate(property)) {
++                    registerProblem(holder, property)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                if (canBePrivate(function)) {
++                    registerProblem(holder, function)
++                }
++            }
++        }
++    }
++
++
++    private fun canBePrivate(declaration: KtDeclaration): Boolean {
++        val modifiers = declaration.modifierList
++        if (modifiers != null && (modifiers.hasModifier(KtTokens.PRIVATE_KEYWORD) || modifiers.hasModifier(KtTokens.OVERRIDE_KEYWORD))) return false",You can use `declaration.hasModifier()` directly,2017-05-16 15:24:55
+856,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.addRemoveModifier.addModifier
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (canBePrivate(property)) {
++                    registerProblem(holder, property)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                if (canBePrivate(function)) {
++                    registerProblem(holder, function)
++                }
++            }
++        }
++    }
++
++
++    private fun canBePrivate(declaration: KtDeclaration): Boolean {
++        val modifiers = declaration.modifierList
++        if (modifiers != null && (modifiers.hasModifier(KtTokens.PRIVATE_KEYWORD) || modifiers.hasModifier(KtTokens.OVERRIDE_KEYWORD))) return false
++        val klass = (declaration.parent as? KtClassBody)?.parent as? KtClass ?: return false
++        if (!klass.isInheritable() && modifiers?.hasModifier(KtTokens.PROTECTED_KEYWORD) ?: false) return false //reported by ProtectedInFinalInspection
++        if (declaration.isOverridable()) return false
++        val allUsages = ReferencesSearch.search(declaration, declaration.useScope).count()","This is very inefficient: usages search is an expensive operation and most of the cost is wasted. You should iterate over all usages and stop as soon as you find one outside the local search scope.
+
+See also the [corresponding Java inspection](https://github.com/JetBrains/intellij-community/blob/master/java/java-analysis-impl/src/com/intellij/codeInspection/visibility/AccessCanBeTightenedInspection.java#L143) for inspiration.",2017-05-16 15:28:33
+857,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInsight.FileModificationService
++import com.intellij.codeInspection.LocalQuickFix
++import com.intellij.codeInspection.ProblemDescriptor
++import com.intellij.codeInspection.ProblemHighlightType
++import com.intellij.codeInspection.ProblemsHolder
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.addRemoveModifier.addModifier
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (canBePrivate(property)) {
++                    registerProblem(holder, property)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                if (canBePrivate(function)) {
++                    registerProblem(holder, function)
++                }
++            }
++        }
++    }
++
++
++    private fun canBePrivate(declaration: KtDeclaration): Boolean {
++        val modifiers = declaration.modifierList
++        if (modifiers != null && (modifiers.hasModifier(KtTokens.PRIVATE_KEYWORD) || modifiers.hasModifier(KtTokens.OVERRIDE_KEYWORD))) return false
++        val klass = (declaration.parent as? KtClassBody)?.parent as? KtClass ?: return false
++        if (!klass.isInheritable() && modifiers?.hasModifier(KtTokens.PROTECTED_KEYWORD) ?: false) return false //reported by ProtectedInFinalInspection
++        if (declaration.isOverridable()) return false
++        val allUsages = ReferencesSearch.search(declaration, declaration.useScope).count()
++        if (allUsages == 0) return false
++        val classUsages = ReferencesSearch.search(declaration, LocalSearchScope(klass)).count()
++        if (allUsages != classUsages)
++            return false
++        return true
++    }
++
++    private fun registerProblem(holder: ProblemsHolder, declaration: KtDeclaration) {
++        holder.registerProblem(declaration,
++                               ""Can have 'private' visibility"",
++                               ProblemHighlightType.WEAK_WARNING,
++                               MakePrivateFix())
++    }
++
++    class MakePrivateFix : LocalQuickFix {",You can reuse `AddModifierFix`,2017-05-16 15:29:31
+858,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.PsiReference
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import com.intellij.util.Processor
++import org.jetbrains.kotlin.idea.quickfix.AddModifierFix
++import org.jetbrains.kotlin.idea.refactoring.isConstructorDeclaredProperty
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (canBePrivate(property)) {",This is now reported on local variables (which are also KtProperty instances).,2017-05-19 18:28:28
+859,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.PsiReference
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import com.intellij.util.Processor
++import org.jetbrains.kotlin.idea.quickfix.AddModifierFix
++import org.jetbrains.kotlin.idea.refactoring.isConstructorDeclaredProperty
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (canBePrivate(property)) {
++                    registerProblem(holder, property)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                if (canBePrivate(function)) {
++                    registerProblem(holder, function)
++                }
++            }
++
++            override fun visitParameter(parameter: KtParameter) {
++                super.visitParameter(parameter)
++                if (parameter.isConstructorDeclaredProperty() && canBePrivate(parameter)) {
++                    registerProblem(holder, parameter)
++                }
++            }
++        }
++    }
++
++
++    private fun canBePrivate(declaration: KtDeclaration): Boolean {
++        if (declaration.hasModifier(KtTokens.PRIVATE_KEYWORD) || declaration.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return false
++        val klass = declaration.containingClass() ?: return false",Wouldn't hurt to handle members of `object` declarations too.,2017-05-19 18:28:48
+860,"@@ -0,0 +1,89 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.PsiReference
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import com.intellij.util.Processor
++import org.jetbrains.kotlin.idea.quickfix.AddModifierFix
++import org.jetbrains.kotlin.idea.refactoring.isConstructorDeclaredProperty
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.containingClass
++import org.jetbrains.kotlin.psi.psiUtil.getParentOfType
++import org.jetbrains.kotlin.psi.psiUtil.isInheritable
++import org.jetbrains.kotlin.psi.psiUtil.isOverridable
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (canBePrivate(property)) {
++                    registerProblem(holder, property)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                if (canBePrivate(function)) {
++                    registerProblem(holder, function)
++                }
++            }
++
++            override fun visitParameter(parameter: KtParameter) {
++                super.visitParameter(parameter)
++                if (parameter.isConstructorDeclaredProperty() && canBePrivate(parameter)) {
++                    registerProblem(holder, parameter)
++                }
++            }
++        }
++    }
++
++
++    private fun canBePrivate(declaration: KtDeclaration): Boolean {
++        if (declaration.hasModifier(KtTokens.PRIVATE_KEYWORD) || declaration.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return false
++        val klass = declaration.containingClass() ?: return false
++        if (!klass.isInheritable() && declaration.hasModifier(KtTokens.PROTECTED_KEYWORD)) return false //reported by ProtectedInFinalInspection
++        if (declaration.isOverridable()) return false
++        var otherUsageFound = false
++        var inClassUsageFound = false
++        ReferencesSearch.search(declaration, declaration.useScope).forEach(Processor<PsiReference> {
++            val usage = it.element
++            if (klass != usage.getParentOfType<KtClass>(false)) {
++                otherUsageFound = true
++                false
++            } else {
++                inClassUsageFound = true
++                true
++            }
++        })
++        return inClassUsageFound && !otherUsageFound
++    }
++
++    private fun registerProblem(holder: ProblemsHolder, declaration: KtDeclaration) {
++        val modifierListOwner = declaration.getParentOfType<KtModifierListOwner>(false) ?: return
++        holder.registerProblem(declaration,
++                               ""Can have 'private' visibility"",","Better to include name of declaration in the message, otherwise it's hard to understand results of a batch inspection.",2017-05-19 18:29:34
+852,"@@ -0,0 +1,9 @@
++// IS_APPLICABLE: false
++// WITH_RUNTIME
++class A(val _value: Int) {
++    operator fun compareTo(other: Int) = _value.compareTo(other)
++}
++
++fun test(a: A): Boolean {
++    return a >= 0 && a <= 100<caret>","My suggested change to KotlinType.isComparable() will break this test, but I think it's OK because this test should be red, and we make no guarantees regarding the behavior of intentions on red code.",2017-05-08 13:11:43
+230,"@@ -0,0 +1,9 @@
++// WITH_RUNTIME
++// IS_APPLICABLE: FALSE
++fun String.withIndices(): Int = 42
++
++fun foo(s: String) {
++    for (<caret>a in s) {
++
++    }
++}","The test is fine, the naming is not: _overridden_ function is a function declaration in a subclass with the same signature as in the superclass. There are no overridden functions here, `withIndices` is just an extension function
+",2014-05-12 12:39:33
+853,"@@ -0,0 +1,9 @@
++interface B {
++    fun c()
++}
++
++
++<spot>object A : B</spot> {",This should be `object a`,2017-05-08 13:29:17
+424,"@@ -0,0 +1,91 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.service
++
++import java.io.FilePermission
++import java.net.SocketPermission
++import java.security.CodeSource
++import java.security.Permission
++import java.security.PermissionCollection
++import java.security.Policy
++import java.util.ArrayList
++import java.util.Collections
++import java.util.Enumeration
++import java.util.PropertyPermission
++
++
++public class DaemonPolicy(val port: Int) : Policy() {
++
++    private fun createPermissions(): PermissionCollection {
++        val perms = DaemonPermissionCollection()
++
++        val socketPermission = SocketPermission(""localhost:$port-"", ""connect, accept, resolve"")
++        val propertyPermission = PropertyPermission(""localhost:$port"", ""read"")
++        //val filePermission = FilePermission(""<<ALL FILES>>"", ""read"")
++
++        perms.add(socketPermission)
++        perms.add(propertyPermission)
++        //perms.add(filePermission)
++
++        return perms
++    }
++
++    private val perms: PermissionCollection by lazy { createPermissions() }
++
++    override fun getPermissions(codesource: CodeSource?): PermissionCollection {
++        return perms
++    }
++}
++
++
++class DaemonPermissionCollection : PermissionCollection() {
++    var perms = ArrayList<Permission>()","why `var`?
+",2015-08-20 14:45:43
+423,"@@ -0,0 +1,91 @@
++/*
++ * Copyright 2010-2015 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.rmi.service
++
++import java.io.FilePermission
++import java.net.SocketPermission
++import java.security.CodeSource
++import java.security.Permission
++import java.security.PermissionCollection
++import java.security.Policy
++import java.util.ArrayList
++import java.util.Collections
++import java.util.Enumeration
++import java.util.PropertyPermission
++
++
++public class DaemonPolicy(val port: Int) : Policy() {
++
++    private fun createPermissions(): PermissionCollection {
++        val perms = DaemonPermissionCollection()
++
++        val socketPermission = SocketPermission(""localhost:$port-"", ""connect, accept, resolve"")
++        val propertyPermission = PropertyPermission(""localhost:$port"", ""read"")
++        //val filePermission = FilePermission(""<<ALL FILES>>"", ""read"")
++
++        perms.add(socketPermission)
++        perms.add(propertyPermission)
++        //perms.add(filePermission)
++
++        return perms
++    }
++
++    private val perms: PermissionCollection by lazy { createPermissions() }
++
++    override fun getPermissions(codesource: CodeSource?): PermissionCollection {
++        return perms
++    }
++}
++
++
++class DaemonPermissionCollection : PermissionCollection() {
++    var perms = ArrayList<Permission>()
++
++    override fun add(p: Permission) {
++        perms.add(p)
++    }
++
++    override fun implies(p: Permission): Boolean {
++        val i = perms.iterator()","perms.any { it.implies(p) }
+",2015-08-20 14:45:27
+864,"@@ -0,0 +1,91 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.psi.PsiElementVisitor
++import com.intellij.psi.PsiReference
++import com.intellij.psi.search.LocalSearchScope
++import com.intellij.psi.search.searches.ReferencesSearch
++import com.intellij.util.Processor
++import org.jetbrains.kotlin.idea.quickfix.AddModifierFix
++import org.jetbrains.kotlin.idea.refactoring.isConstructorDeclaredProperty
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.*
++
++class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
++
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean): PsiElementVisitor {
++        return object : KtVisitorVoid() {
++            override fun visitProperty(property: KtProperty) {
++                super.visitProperty(property)
++                if (!property.isLocal && canBePrivate(property)) {
++                    registerProblem(holder, property)
++                }
++            }
++
++            override fun visitNamedFunction(function: KtNamedFunction) {
++                super.visitNamedFunction(function)
++                if (canBePrivate(function)) {
++                    registerProblem(holder, function)
++                }
++            }
++
++            override fun visitParameter(parameter: KtParameter) {
++                super.visitParameter(parameter)
++                if (parameter.isConstructorDeclaredProperty() && canBePrivate(parameter)) {
++                    registerProblem(holder, parameter)
++                }
++            }
++        }
++    }
++
++
++    private fun canBePrivate(declaration: KtDeclaration): Boolean {
++        if (declaration.hasModifier(KtTokens.PRIVATE_KEYWORD) || declaration.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return false
++        val classOrObject = declaration.containingClassOrObject ?: return false
++        val inheritable = classOrObject is KtClass && classOrObject.isInheritable()
++        if (!inheritable && declaration.hasModifier(KtTokens.PROTECTED_KEYWORD)) return false //reported by ProtectedInFinalInspection
++        if (declaration.isOverridable()) return false
++        var otherUsageFound = false
++        var inClassUsageFound = false
++        ReferencesSearch.search(declaration, declaration.useScope).forEach(Processor<PsiReference> {
++            val usage = it.element
++            if (classOrObject != usage.getParentOfType<KtClassOrObject>(false)) {
++                otherUsageFound = true
++                false
++            } else {
++                inClassUsageFound = true
++                true
++            }
++        })
++        return inClassUsageFound && !otherUsageFound
++    }
++
++    private fun registerProblem(holder: ProblemsHolder, declaration: KtDeclaration) {
++        val modifierListOwner = declaration.getParentOfType<KtModifierListOwner>(false) ?: return
++        val member = when (declaration) {
++            is KtNamedFunction -> ""Function""
++            else -> ""Property""
++        }
++        holder.registerProblem(declaration,","This highlights the entire declaration with a wavy underline, which is very intrusive. Should highlight only the name identifier.",2017-05-23 17:08:14
+985,"@@ -0,0 +1,92 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.effectsystem.impls
++
++import org.jetbrains.kotlin.effectsystem.structure.ESClause
++import org.jetbrains.kotlin.effectsystem.structure.EffectSchema
++import org.jetbrains.kotlin.effectsystem.structure.ESExpressionVisitor
++
++class Printer : ESExpressionVisitor<Unit> {
++    private val builder = StringBuilder()
++
++    private fun print(string: String) {
++        builder.append(string)
++    }
++
++    private inline fun line(block: () -> Unit) {
++        block()
++    }
++
++    fun print(schema: EffectSchema) {
++        schema.clauses.forEach { visitClause(it) }
++    }
++
++    fun visitClause(clause: ESClause) {
++        line {
++            clause.condition.accept(this)
++            print("" -> "")",Looks like this arrow has the wrong direction,2017-08-15 16:54:12
+196,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++        return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()!!.getText()!!","Your intention would be helpful to make types implicit here :) I think they don't really add anything to readability
+",2014-04-22 22:25:02
+195,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++        return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()!!.getText()!!
++                                              }).makeString("", "", ""("", "")"")
++            val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++            oldParameterList.replace(newParameterList)
++        }
++
++        if (!hasExplicitParamType(element)) {
++            val currentParamList = element.getFunctionLiteral().getValueParameterList()
++            val firstChild = currentParamList?.getFirstChild()
++            if (firstChild?.getNode()?.getElementType() == JetTokens.LPAR) firstChild!!.delete()
++            val lastChild = currentParamList?.getLastChild()
++            if (lastChild?.getNode()?.getElementType() == JetTokens.RPAR) lastChild!!.delete()
++        }
++    }
++
++    fun hasExplicitReturnType(element: JetFunctionLiteralExpression): Boolean {
++        return element.hasDeclaredReturnType()
++    }
++
++    fun hasExplicitReceiverType(element: JetFunctionLiteralExpression): Boolean {
++        return element.getFunctionLiteral().getReceiverTypeRef() != null
++    }
++
++    fun hasExplicitParamType(element: JetFunctionLiteralExpression): Boolean {
++        if (element.getValueParameters().any { it.getTypeReference() != null }) {
++            val parameters = element.getFunctionLiteral().getValueParameterList()?.getParameters()
++            return !(parameters?.any { it.getNameIdentifier()?.getText() == null } ?: false)","This code looks a little awkward to me.
+
+First, consider using other standard library functions such as `none` or `all` instead of `any` to prevent at least some negations.
+
+Second, why can't you iterate the parameter list with one simple `for` and check two conditions for each parameter in the loop body?
+",2014-04-22 22:12:08
+198,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++        return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        val oldParameters = oldParameterList?.getParameters()
++        if (oldParameterList != null && oldParameters != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameters.map({(parameter: JetParameter): String -> parameter.getNameIdentifier()!!.getText()!!
++                                              }).makeString("", "", ""("", "")"")
++            val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++            oldParameterList.replace(newParameterList)
++        }
++
++        if (!hasExplicitParamType(element)) {
++            val currentParamList = element.getFunctionLiteral().getValueParameterList()
++            val firstChild = currentParamList?.getFirstChild()
++            if (firstChild?.getNode()?.getElementType() == JetTokens.LPAR) firstChild!!.delete()
++            val lastChild = currentParamList?.getLastChild()
++            if (lastChild?.getNode()?.getElementType() == JetTokens.RPAR) lastChild!!.delete()
++        }
++    }
++
++    fun hasExplicitReturnType(element: JetFunctionLiteralExpression): Boolean {
++        return element.hasDeclaredReturnType()
++    }
++
++    fun hasExplicitReceiverType(element: JetFunctionLiteralExpression): Boolean {
++        return element.getFunctionLiteral().getReceiverTypeRef() != null
++    }
++
++    fun hasExplicitParamType(element: JetFunctionLiteralExpression): Boolean {
++        if (element.getValueParameters().any { it.getTypeReference() != null }) {
++            val parameters = element.getFunctionLiteral().getValueParameterList()?.getParameters()
++            return !(parameters?.any { it.getNameIdentifier()?.getText() == null } ?: false)
++        }
++        return false;
++    }","Ditto (`private`)
+",2014-04-22 22:25:56
+127,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import com.intellij.lang.ASTNode
++import com.intellij.psi.PsiElement
++import com.siyeh.ig.PsiReplacementUtil
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5","Stricter way is to find ""else"" keyword directly by `element.getNode().findChildByType(JetTokens.ELSE_KEYWORD)`. And this ""minus 5"" looks very esoteric anyway :)
+",2014-03-04 16:04:00
+128,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import com.intellij.lang.ASTNode
++import com.intellij.psi.PsiElement
++import com.siyeh.ig.PsiReplacementUtil
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }","This code for distinguishing ""if"" from ""else"" has two problems:
+- It is duplicated (here and symmetric intention)
+- It is spread among two places: first `getExpressionType` returns `else` (which actually means ""if or else, I don't know yet), and then it is recalculated for if-else case.
+  Alternative it to pass caret position to `getExpressionType`, so all these calculations will be there.
+",2014-03-04 16:05:53
+129,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import com.intellij.lang.ASTNode
++import com.intellij.psi.PsiElement
++import com.siyeh.ig.PsiReplacementUtil
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        if (jetBlockElement != null) return false
++
++        setText(""Add braces to '$expressionType' statement"")
++        return true
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val bodyNode = when (expressionType) {
++            ""else"" -> element.getNode().findChildByType(JetNodeTypes.ELSE)
++            ""if"" -> element.getNode().findChildByType(JetNodeTypes.THEN)
++            else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++        }
++        generateCleanOutput(element, bodyNode)
++    }
++
++    fun generateCleanOutput(element: JetExpressionImpl, bodyNode: ASTNode?) {
++        val newElement: PsiElement?
++
++        if (element.getNextSibling()?.getText() == "";"") {
++            element.getNextSibling()!!.delete()
++        }
++        newElement = bodyNode!!.getPsi()!!.replace(JetPsiFactory.createFunctionBody(element.getProject(), bodyNode.getText()))
++
++        //handles the case of the block statement being on a new line
++        if (newElement?.getPrevSibling()?.getText() != "")"") {","Checking for `is PsiWhiteSpace` is more robust.
+",2014-03-04 16:06:11
+130,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import com.intellij.lang.ASTNode
++import com.intellij.psi.PsiElement
++import com.siyeh.ig.PsiReplacementUtil
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        if (jetBlockElement != null) return false
++
++        setText(""Add braces to '$expressionType' statement"")
++        return true
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val bodyNode = when (expressionType) {
++            ""else"" -> element.getNode().findChildByType(JetNodeTypes.ELSE)
++            ""if"" -> element.getNode().findChildByType(JetNodeTypes.THEN)
++            else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++        }
++        generateCleanOutput(element, bodyNode)
++    }
++
++    fun generateCleanOutput(element: JetExpressionImpl, bodyNode: ASTNode?) {
++        val newElement: PsiElement?
++
++        if (element.getNextSibling()?.getText() == "";"") {
++            element.getNextSibling()!!.delete()
++        }
++        newElement = bodyNode!!.getPsi()!!.replace(JetPsiFactory.createFunctionBody(element.getProject(), bodyNode.getText()))
++
++        //handles the case of the block statement being on a new line
++        if (newElement?.getPrevSibling()?.getText() != "")"") {
++            newElement!!.getPrevSibling()!!.replace(JetPsiFactory.createWhiteSpace(element.getProject()))
++        }
++        //handles the case of no space between condition and statement
++        if (newElement?.getPrevSibling()?.getText() == "")"") {","Shouldn't it be just an `else` for previous `if`?
+",2014-03-04 16:06:22
+131,"@@ -0,0 +1,93 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import com.intellij.lang.ASTNode
++import com.intellij.psi.PsiElement
++import com.siyeh.ig.PsiReplacementUtil
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""add.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        if (jetBlockElement != null) return false
++
++        setText(""Add braces to '$expressionType' statement"")
++        return true
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val bodyNode = when (expressionType) {
++            ""else"" -> element.getNode().findChildByType(JetNodeTypes.ELSE)
++            ""if"" -> element.getNode().findChildByType(JetNodeTypes.THEN)
++            else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++        }
++        generateCleanOutput(element, bodyNode)
++    }
++
++    fun generateCleanOutput(element: JetExpressionImpl, bodyNode: ASTNode?) {
++        val newElement: PsiElement?
++
++        if (element.getNextSibling()?.getText() == "";"") {
++            element.getNextSibling()!!.delete()
++        }
++        newElement = bodyNode!!.getPsi()!!.replace(JetPsiFactory.createFunctionBody(element.getProject(), bodyNode.getText()))
++
++        //handles the case of the block statement being on a new line
++        if (newElement?.getPrevSibling()?.getText() != "")"") {
++            newElement!!.getPrevSibling()!!.replace(JetPsiFactory.createWhiteSpace(element.getProject()))
++        }
++        //handles the case of no space between condition and statement
++        if (newElement?.getPrevSibling()?.getText() == "")"") {
++            newElement!!.addBefore(JetPsiFactory.createWhiteSpace(element.getProject()), newElement.getFirstChild())
++        }
++        if (expressionType == ""do...while"") {
++            newElement?.getNextSibling()?.delete()
++        }
++        bodyNode.getPsi()!!.delete()","What is this for? Couldn't understand without comment.
+",2014-03-04 16:06:31
+137,"@@ -0,0 +1,94 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++//import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.JetNodeTypes
++import com.intellij.psi.PsiComment
++import com.intellij.psi.PsiElement
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++//import org.jetbrains.jet.lang.psi.psiUtil.getExpressionKind","Commented imports? Are you sure? :)
+",2014-03-05 16:43:00
+205,"@@ -0,0 +1,95 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false","Yes, our formatter fails here at the moment, but you still should indent this line manually with 4 spaces
+",2014-04-22 23:48:59
+202,"@@ -0,0 +1,95 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++        return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        if (oldParameterList?.getParameters() != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameterList!!.getParameters().map({parameter -> parameter.getNameIdentifier()!!.getText()!!
++                                              }).makeString("", "", ""("", "")"")","Formatting got screwed up while you were modifying this code. It should be:
+
+```
+val ....map({
+    parameter -> ...
+}).makeString(...)
+```
+",2014-04-22 23:43:55
+204,"@@ -0,0 +1,95 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++        return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        if (oldParameterList?.getParameters() != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameterList!!.getParameters().map({parameter -> parameter.getNameIdentifier()!!.getText()!!
++                                              }).makeString("", "", ""("", "")"")
++            val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++            oldParameterList.replace(newParameterList)
++        }
++
++        if (!hasExplicitParamType(element)) {
++            val currentParamList = element.getFunctionLiteral().getValueParameterList()
++            val firstChild = currentParamList?.getFirstChild()
++            if (firstChild?.getNode()?.getElementType() == JetTokens.LPAR) firstChild!!.delete()
++            val lastChild = currentParamList?.getLastChild()
++            if (lastChild?.getNode()?.getElementType() == JetTokens.RPAR) lastChild!!.delete()
++        }
++    }
++
++    private fun hasExplicitReturnType(element: JetFunctionLiteralExpression): Boolean {
++        return element.hasDeclaredReturnType()
++    }
++
++    private fun hasExplicitReceiverType(element: JetFunctionLiteralExpression): Boolean {
++        return element.getFunctionLiteral().getReceiverTypeRef() != null
++    }
++
++    private fun hasExplicitParamType(element: JetFunctionLiteralExpression): Boolean {
++        val parameters = element.getFunctionLiteral().getValueParameterList()?.getParameters()
++        if (parameters == null) return false
++        var numExplicitParams = 0","Better, but shouldn't it be a boolean `hasExplicitParamType`? :)
+",2014-04-22 23:45:57
+203,"@@ -0,0 +1,95 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetFunctionLiteralExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetParameter
++import org.jetbrains.jet.lexer.JetTokens
++
++public class MakeTypeImplicitInLambdaIntention : JetSelfTargetingIntention<JetFunctionLiteralExpression>(
++        ""make.type.implicit.in.lambda"", javaClass()) {
++    override fun isApplicableTo(element: JetFunctionLiteralExpression): Boolean {
++        throw IllegalStateException(""isApplicableTo(JetExpressionImpl, Editor) should be called instead"")
++    }
++
++    override fun isApplicableTo(element: JetFunctionLiteralExpression, editor: Editor): Boolean {
++        val openBraceOffset = element.getLeftCurlyBrace().getStartOffset()
++        val closeBraceOffset = element.getRightCurlyBrace()?.getStartOffset()
++        val caretLocation = editor.getCaretModel().getOffset()
++        val arrow = element.getFunctionLiteral().getArrowNode()
++        if (arrow != null && !(openBraceOffset < caretLocation && caretLocation < arrow.getStartOffset() + 2) &&
++        caretLocation != closeBraceOffset) return false
++        else if (arrow == null && caretLocation != openBraceOffset + 1 && caretLocation != closeBraceOffset) return false
++        return hasExplicitReturnType(element) || hasExplicitReceiverType(element) || hasExplicitParamType(element)
++    }
++
++    override fun applyTo(element: JetFunctionLiteralExpression, editor: Editor) {
++        val functionLiteral = element.getFunctionLiteral()
++        val oldParameterList = functionLiteral.getValueParameterList()
++
++        if (hasExplicitReturnType(element)) {
++            val childAfterParamList = oldParameterList?.getNextSibling()
++            val arrow = functionLiteral.getArrowNode()?.getPsi()
++            val childBeforeArrow = arrow?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterParamList, childBeforeArrow)
++            val whiteSpaceBeforeArrow = JetPsiFactory.createWhiteSpace(element.getProject())
++            functionLiteral.addBefore(whiteSpaceBeforeArrow, arrow)
++        }
++
++        if (hasExplicitReceiverType(element)) {
++            val childAfterBrace = functionLiteral.getOpenBraceNode().getPsi()?.getNextSibling()
++            val childBeforeParamList = oldParameterList?.getPrevSibling()
++            functionLiteral.deleteChildRange(childAfterBrace, childBeforeParamList)
++        }
++
++        if (oldParameterList?.getParameters() != null && hasExplicitParamType(element)) {
++            val parameterString = oldParameterList!!.getParameters().map({parameter -> parameter.getNameIdentifier()!!.getText()!!
++                                              }).makeString("", "", ""("", "")"")
++            val newParameterList = JetPsiFactory.createParameterList(element.getProject(), parameterString)
++            oldParameterList.replace(newParameterList)
++        }
++
++        if (!hasExplicitParamType(element)) {
++            val currentParamList = element.getFunctionLiteral().getValueParameterList()
++            val firstChild = currentParamList?.getFirstChild()
++            if (firstChild?.getNode()?.getElementType() == JetTokens.LPAR) firstChild!!.delete()
++            val lastChild = currentParamList?.getLastChild()
++            if (lastChild?.getNode()?.getElementType() == JetTokens.RPAR) lastChild!!.delete()
++        }
++    }
++
++    private fun hasExplicitReturnType(element: JetFunctionLiteralExpression): Boolean {
++        return element.hasDeclaredReturnType()
++    }
++
++    private fun hasExplicitReceiverType(element: JetFunctionLiteralExpression): Boolean {
++        return element.getFunctionLiteral().getReceiverTypeRef() != null
++    }
++
++    private fun hasExplicitParamType(element: JetFunctionLiteralExpression): Boolean {
++        val parameters = element.getFunctionLiteral().getValueParameterList()?.getParameters()
++        if (parameters == null) return false
++        var numExplicitParams = 0
++        for (param in parameters!!) {","`!!` shouldn't be needed here
+",2014-04-22 23:44:54
+579,"@@ -0,0 +1,96 @@
++/*
++ * Copyright 2010-2016 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.quickfix
++
++import com.intellij.openapi.editor.Editor
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++import org.jetbrains.kotlin.builtins.KotlinBuiltIns
++import org.jetbrains.kotlin.codegen.ExpressionCodegen
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
++import org.jetbrains.kotlin.idea.core.replaced
++import org.jetbrains.kotlin.psi.KtConstantExpression
++import org.jetbrains.kotlin.psi.KtExpression
++import org.jetbrains.kotlin.psi.KtFile
++import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.resolve.DescriptorUtils
++import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
++import org.jetbrains.kotlin.types.KotlinType
++
++private val valueRanges = mapOf(
++        KotlinBuiltIns.FQ_NAMES._byte to Byte.MIN_VALUE.toLong()..Byte.MAX_VALUE.toLong(),
++        KotlinBuiltIns.FQ_NAMES._short to Short.MIN_VALUE.toLong()..Short.MAX_VALUE.toLong(),
++        KotlinBuiltIns.FQ_NAMES._int to Int.MIN_VALUE.toLong()..Int.MAX_VALUE.toLong(),
++        KotlinBuiltIns.FQ_NAMES._long to Long.MIN_VALUE..Long.MAX_VALUE
++)
++
++class WrongPrimitiveLiteralFix(element: KtConstantExpression, type: KotlinType) : KotlinQuickFixAction<KtExpression>(element) {
++
++    private val typeName = DescriptorUtils.getFqName(type.constructor.declarationDescriptor!!)
++    private val expectedTypeIsFloat = KotlinBuiltIns.isFloat(type)
++    private val expectedTypeIsDouble = KotlinBuiltIns.isDouble(type)
++    private val constValue
++            = ExpressionCodegen.getPrimitiveOrStringCompileTimeConstant(element, element.analyze(BodyResolveMode.PARTIAL))?.value as? Number
++
++    private val fixedExpression = buildString {
++        if (expectedTypeIsFloat || expectedTypeIsDouble) {
++            append(constValue)
++            if (expectedTypeIsFloat) {
++                append('F')
++            }
++            else if ('.' !in this) {
++                append("".0"")
++            }
++        }
++        else {
++            if (constValue is Float || constValue is Double) {
++                append(constValue.toLong())
++            }
++            else {
++                append(element.text.takeWhile { it != 'l' && it != 'L' })","I'd rather use `element.text.trimEnd('l', 'L')`
+",2016-07-05 11:03:44
+246,"@@ -0,0 +1,96 @@
++fun Int.foo(a: Int = 1,","The correct spelling is `extension` :)
+",2014-08-20 07:36:15
+132,"@@ -0,0 +1,98 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import com.intellij.psi.PsiComment
++import com.intellij.psi.PsiElement
++import java.util.ArrayList
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++
++public class RemoveBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""remove.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }
++
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        if (jetBlockElement == null) return false
++
++        if (jetBlockElement!!.getStatements().size == 1) {
++            setText(""Remove braces from '$expressionType' statement"")
++            return true
++        }
++        return false
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        val firstStatement = jetBlockElement!!.getStatements().first()
++
++        val comments = handleComment(jetBlockElement)
++        if (comments != null) {
++            //TODO - output comments on the line above the control statement
++        }
++        val newElement = jetBlockElement.replace(JetPsiFactory.createExpression(element.getProject(), firstStatement.getText()))
++
++        if (expressionType == ""do...while"") {
++            newElement.getParent()!!.addAfter(JetPsiFactory.createNewLine(element.getProject()), newElement)
++        }
++    }
++
++    fun handleComment(element: JetBlockExpression): ArrayList<PsiComment>? {","With this function name, it's hard to guess what it does and what does it return. What about ""extractComments""?
+It return `ArrayList`, while just `List` would be enough.
+",2014-03-04 16:07:09
+133,"@@ -0,0 +1,98 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import com.intellij.psi.PsiComment
++import com.intellij.psi.PsiElement
++import java.util.ArrayList
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++
++public class RemoveBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""remove.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }
++
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        if (jetBlockElement == null) return false
++
++        if (jetBlockElement!!.getStatements().size == 1) {
++            setText(""Remove braces from '$expressionType' statement"")
++            return true
++        }
++        return false
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        val firstStatement = jetBlockElement!!.getStatements().first()
++
++        val comments = handleComment(jetBlockElement)
++        if (comments != null) {
++            //TODO - output comments on the line above the control statement
++        }
++        val newElement = jetBlockElement.replace(JetPsiFactory.createExpression(element.getProject(), firstStatement.getText()))
++
++        if (expressionType == ""do...while"") {
++            newElement.getParent()!!.addAfter(JetPsiFactory.createNewLine(element.getProject()), newElement)
++        }
++    }
++
++    fun handleComment(element: JetBlockExpression): ArrayList<PsiComment>? {
++        val comments = ArrayList<PsiComment>()
++        var sibling = element.getFirstChild()
++        if (sibling == null) return null
++            sibling = sibling?.getNextSibling()","This indent blows minds. I thought that this assignment relates to if.
+Why safe call here? `sibling` is not null before assignment here.
+",2014-03-04 16:07:44
+134,"@@ -0,0 +1,98 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetBlockExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.psiUtil.findBlockInExpression
++import org.jetbrains.jet.JetNodeTypes
++import org.jetbrains.jet.lang.psi.psiUtil.getExpressionType
++import com.intellij.psi.PsiComment
++import com.intellij.psi.PsiElement
++import java.util.ArrayList
++import com.intellij.openapi.fileEditor.FileEditorManager
++import com.intellij.openapi.project.Project
++import com.intellij.psi.PsiFile
++
++
++public class RemoveBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""remove.braces"", javaClass()) {
++    private var expressionType: String? = """"
++    private var caretLocation: Int = 1
++
++    override fun isAvailable(project: Project, editor: Editor, file: PsiFile): Boolean {
++        caretLocation = editor.getCaretModel().getOffset()
++        return getTarget(editor, file) != null
++    }
++
++    override fun isApplicableTo(element: JetExpressionImpl): Boolean {
++        expressionType = element.getExpressionType(element)
++        if (expressionType == null) return false
++
++        if (expressionType == ""else"") {
++            val elseLocation = (element as JetIfExpression).getElse()!!.getParent()!!.getTextOffset() - 5
++            if (caretLocation < elseLocation) {
++                expressionType = ""if""
++            }
++        }
++
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        if (jetBlockElement == null) return false
++
++        if (jetBlockElement!!.getStatements().size == 1) {
++            setText(""Remove braces from '$expressionType' statement"")
++            return true
++        }
++        return false
++    }
++
++    override fun applyTo(element: JetExpressionImpl, editor: Editor) {
++        val jetBlockElement = element.findBlockInExpression(element, expressionType)
++        val firstStatement = jetBlockElement!!.getStatements().first()
++
++        val comments = handleComment(jetBlockElement)
++        if (comments != null) {
++            //TODO - output comments on the line above the control statement
++        }
++        val newElement = jetBlockElement.replace(JetPsiFactory.createExpression(element.getProject(), firstStatement.getText()))
++
++        if (expressionType == ""do...while"") {
++            newElement.getParent()!!.addAfter(JetPsiFactory.createNewLine(element.getProject()), newElement)
++        }
++    }
++
++    fun handleComment(element: JetBlockExpression): ArrayList<PsiComment>? {
++        val comments = ArrayList<PsiComment>()
++        var sibling = element.getFirstChild()
++        if (sibling == null) return null
++            sibling = sibling?.getNextSibling()
++
++        while (sibling != null) {
++            if (sibling is PsiComment) {
++                comments.add(sibling as PsiComment)
++            }
++            sibling = sibling?.getNextSibling()","Another redundant safe call.
+",2014-03-04 16:08:03
+243,"@@ -0,0 +1,98 @@
++class A(val a: Int = 1,
++        val b: Int = 2,
++        val c: Int = 3,
++        val d: Int = 4,
++        val e: Int = 5,
++        val f: Int = 6,
++        val g: Int = 7,
++        val h: Int = 8,
++        val i: Int = 9,
++        val j: Int = 10,
++        val k: Int = 11,
++        val l: Int = 12,
++        val m: Int = 13,
++        val n: Int = 14,
++        val o: Int = 15,
++        val p: Int = 16,
++        val q: Int = 17,
++        val r: Int = 18,
++        val s: Int = 19,
++        val t: Int = 20,
++        val u: Int = 21,
++        val v: Int = 22,
++        val w: Int = 23,
++        val x: Int = 24,
++        val y: Int = 25,
++        val z: Int = 26,
++        val aa: Int = 27,
++        val bb: Int = 28,
++        val cc: Int = 29,
++        val dd: Int = 30,
++        val ee: Int = 31,
++        val ff: Int = 32,
++        val gg: Int = 33,
++        val hh: Int = 34,
++        val ii: Int = 35,
++        val jj: Int = 36,
++        val kk: Int = 37,
++        val ll: Int = 38,
++        val mm: Int = 39,
++        val nn: Int = 40,
++        val oo: Int = 41,
++        val pp: Int = 42,
++        val qq: Int = 43,
++        val rr: Int = 44,
++        val ss: Int = 45,
++        val tt: Int = 46,
++        val uu: Int = 47,
++        val vv: Int = 48,
++        val ww: Int = 49,
++        val xx: Int = 50,
++        val yy: Int = 51,
++        val zz: Int = 52,
++        val aaa: Int = 53,
++        val bbb: Int = 54,
++        val ccc: Int = 55,
++        val ddd: Int = 56,
++        val eee: Int = 57,
++        val fff: Int = 58,
++        val ggg: Int = 59,
++        val hhh: Int = 60,
++        val iii: Int = 61,
++        val jjj: Int = 62,
++        val kkk: Int = 63,
++        val lll: Int = 64,
++        val mmm: Int = 65,
++        val nnn: Int = 66,
++        val ooo: Int = 67,
++        val ppp: Int = 68,
++        val qqq: Int = 69,
++        val rrr: Int = 70) {
++    override fun toString(): String {
++        return ""$a $b $c $d $e $f $g $h $i $j $k $l $m $n $o $p $q $r $s $t $u $v $w $x $y $z $aa $bb $cc $dd $ee $ff $gg $hh $ii $jj $kk "" +
++                ""$ll $mm $nn $oo $pp $qq $rr $ss $tt $uu $vv $ww $xx $yy $zz $aaa $bbb $ccc $ddd $eee $fff $ggg $hhh $iii $jjj $kkk $lll "" +
++                ""$mmm $nnn $ooo $ppp $qqq $rrr""
++    }
++}
++
++fun box(): String {
++    val test1 = A(5, f = 3, w = 1, aa = 71, nn = 2, qq = 15, ww = 97, aaa = 261258, iii = 3, nnn = 8, rrr = 7).toString()
++    val test2 = A().toString()
++    val test3 = A(70, 69, 68, 67, 66, 65, 64, 63, 62, 61, 60, 59, 58, 57, 56, 55, 54, 53, 52, 51, 50, 49, 48, 47, 46, 45, 44, 43, 42, 41,
++                    40, 39, 38, 37, 36, jj = 35, kk = 34, ll = 33, mm = 32, nn = 31, oo = 30, pp = 29, qq = 28, rr = 27, ss = 26, tt = 25,
++                    uu = 24, vv = 23, ww = 22, xx = 21, yy = 20, zz = 19, aaa = 18, bbb = 17, ccc = 16, ddd = 15, eee = 14, fff = 13,
++                    ggg = 12, hhh = 11, iii = 10, jjj = 9, kkk = 8, lll = 7, mmm = 6, nnn = 5, ooo = 4, ppp = 3, qqq = 2, rrr = 1).toString()
++    if (test1 != ""5 2 3 4 5 3 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 1 24 25 26 71 28 29 30 31 32 33 34 35 36 37 38 39 2 41 42 15 "" +
++            ""44 45 46 47 48 97 50 51 52 261258 54 55 56 57 58 59 60 3 62 63 64 65 8 67 68 69 7"") {
++        return test1
++    }
++    if (test2 != ""1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 "" +
++            ""43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70"") {
++        return test2
++    }
++    if (test3 != ""70 69 68 67 66 65 64 63 62 61 60 59 58 57 56 55 54 53 52 51 50 49 48 47 46 45 44 43 42 41 40 39 38 37 36 35 34 33 32 "" +
++            ""31 30 29 28 27 26 25 24 23 22 21 20 19 18 17 16 15 14 13 12 11 10 9 8 7 6 5 4 3 2 1"") {
++        return test3
++    }
++    return ""OK""","Unfortunately no test checks the introduced behavior in `FunctionCodegen#generateConstructorWithoutParametersIfNeeded()`.
+
+This test looks almost as if it does, but `A()` here is only a syntactic sugar for invoking the `$default` method :)
+
+To test precisely the synthetic no-args constructor we generate for a class whose constructor's arguments are all default, you could either invoke it from Java or call it reflectively via `newInstance` (I recommend the latter).
+",2014-08-20 07:27:47
+107,"@@ -0,0 +1,99 @@
++/*
++ * Copyright 2010-2014 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.jet.plugin.intentions
++
++import com.intellij.openapi.editor.Editor
++import org.jetbrains.jet.lang.psi.JetDotQualifiedExpression
++import org.jetbrains.jet.lang.psi.JetCallExpression
++import org.jetbrains.jet.lang.psi.JetExpression
++import org.jetbrains.jet.lang.psi.JetPsiFactory
++import org.jetbrains.jet.lang.psi.JetValueArgument
++import org.jetbrains.jet.lang.psi.JetValueArgumentList
++import org.jetbrains.jet.lang.psi.JetNamedArgumentImpl
++import org.jetbrains.jet.lang.psi.JetValueArgumentName
++import org.jetbrains.jet.plugin.references.JetSimpleNameReference
++import org.jetbrains.jet.lang.psi.JetBinaryExpression
++import org.jetbrains.jet.lang.psi.JetPostfixExpression
++import org.jetbrains.jet.lang.psi.JetTypeArgumentList
++
++public class ReplaceGetCallWithArrayAccessIntention : JetSelfTargetingIntention<JetExpression>(""replace.get.call.with.array.access"", javaClass()) {
++    override fun isApplicableTo(element: JetExpression): Boolean {
++        fun methodCallCheck(expression: JetDotQualifiedExpression): Boolean {
++            val selector = expression.getSelectorExpression()
++            val receiver = expression.getReceiverExpression()
++
++            if (selector is JetCallExpression && !(receiver is JetPostfixExpression)) {
++                val callee = selector.getCalleeExpression()
++                val arguments = selector.getValueArgumentList()
++                val typeArguments = selector.getTypeArgumentList()
++
++                return arguments != null
++                    && typeArguments == null
++                    && !arguments.getArguments().any { (arg): Boolean -> arg.getArgumentName() != null }","Specifying return type in function literal is redundant here. Explicit parameter can be also omitted (""it"" name will be auto-generated for it).
+",2014-02-07 18:33:54
+956,"@@ -0,0 +1,99 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.getCallNameExpression
++
++class KotlinRedundantOverrideInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitNamedFunction(function: KtNamedFunction) {
++                    super.visitNamedFunction(function)
++                    if (!function.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return
++
++                    val bodyExpression = function.bodyExpression
++                    bodyExpression ?: return
++
++                    val body = if (bodyExpression is KtDotQualifiedExpression) {
++                        bodyExpression
++                    }
++                    else {
++                        if (bodyExpression.children.size != 1) {
++                            return
++                        }
++                        bodyExpression.children[0]",You could use `singleOrNull() ?: return` here.,2017-08-14 09:14:30
+957,"@@ -0,0 +1,99 @@
++/*
++ * Copyright 2010-2017 JetBrains s.r.o.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.jetbrains.kotlin.idea.inspections
++
++import com.intellij.codeInspection.*
++import com.intellij.openapi.project.Project
++import org.jetbrains.kotlin.lexer.KtTokens
++import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.getCallNameExpression
++
++class KotlinRedundantOverrideInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
++    override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession) =
++            object : KtVisitorVoid() {
++                override fun visitNamedFunction(function: KtNamedFunction) {
++                    super.visitNamedFunction(function)
++                    if (!function.hasModifier(KtTokens.OVERRIDE_KEYWORD)) return
++
++                    val bodyExpression = function.bodyExpression
++                    bodyExpression ?: return
++
++                    val body = if (bodyExpression is KtDotQualifiedExpression) {
++                        bodyExpression
++                    }
++                    else {
++                        if (bodyExpression.children.size != 1) {
++                            return
++                        }
++                        bodyExpression.children[0]
++                    }
++
++                    val qualifiedExpression = if (body is KtReturnExpression) {
++                        val returnedExpression = body.returnedExpression
++                        returnedExpression ?: return
++                        returnedExpression as? KtDotQualifiedExpression ?: return
++                    }
++                    else {
++                        body as? KtDotQualifiedExpression ?: return
++                    }
++
++                    if (qualifiedExpression.receiverExpression !is KtSuperExpression) return
++
++                    val superSelectorExpression = qualifiedExpression.selectorExpression
++                    val superCallElement = superSelectorExpression as? KtCallElement ?: return
++
++                    if (!isSameFunctionName(superSelectorExpression, function)) return",I can use `superCallElement` for the argument. I will fix it.,2017-08-14 10:21:40
+95,"@@ -1,11 +1,11 @@
+ <component name=""libraryTable"">
+   <library name=""kotlin-runtime"">
+     <CLASSES>
+-      <root url=""jar://$KOTLIN_BUNDLED$/lib/kotlin-runtime.jar!/"" />
++      <root url=""jar://$PROJECT_DIR$/out/artifacts/Kotlin/kotlinc/lib/kotlin-runtime.jar!/"" />","Changes like this in meta-information should be carefully reviewed before committing, because they can easily break compilation or workflow for other developers.
+",2014-01-27 21:23:50
+312,"@@ -1,15 +1,15 @@
+ package kotlin
+ 
+ /**
+- * Creates a tuple of type [[Pair<A,B>]] from this and *that* which can be useful for creating [[Map]] literals
+- * with less noise, for example
+-
+- * @includeFunctionBody ../../test/collections/MapTest.kt createUsingTo
++ * Creates a tuple of type [Pair] from this and [that].
++ *
++ * This can be useful for creating [Map] literals with less noise, for example:
++ * @sample test.collections.MapTest.createUsingTo
+  */
+ public fun <A, B> A.to(that: B): Pair<A, B> = Pair(this, that)
+ 
+ /**
+-Run function f
++ * Runs the specified function.","Runs -> Calls?
+",2015-02-09 16:24:56
+543,"@@ -1,3 +1,19 @@
++/*","It's added by IDEA's pre-commit action. Really shouldn't for generated files.
+",2016-04-25 23:33:19
+767,"@@ -1,3 +1,3 @@
+ package test
+ 
+-fun lll(a: Int) = a
++fun lll(a: kotlin.Int) = a",Here we have `kotlin.` added too,2017-04-19 15:42:08
+768,"@@ -1,4 +1,4 @@
+ package test
+ 
+ // extra parameter is to make sure generic signature is not erased
+-fun doNothing(array: IntArray, ignore: java.util.List<String>) = array
++fun doNothing(array: kotlin.IntArray, ignore: java.util.List<String>) = array",And here we have `kotlin.` too,2017-04-19 15:42:26
+726,"@@ -1,4 +1,4 @@
+ package test
+ 
+ // extra parameter is to preserve generic signature
+-fun anyany(a: Any, ignore: java.util.List<String>) = a
++fun anyany(a: kotlin.Any, ignore: java.util.List<String>) = a",Unclear. Why should you have `kotlin.` here and how it works without it?,2017-04-05 15:28:43
+984,"@@ -1,4 +1,5 @@
+ package org.junit
+ 
++@Deprecated(""Use 'Test' from kotlin.test package"", replaceWith = ReplaceWith(""Test"", imports = ""kotlin.test.Test""))",👍 ,2017-08-15 16:51:33
+207,"@@ -1,6 +1,10 @@
+ // ""Change 'foo' function return type to '([ERROR : NoSuchType]) -> Int'"" ""false""
++// ACTION: Disable 'Make Types Implicit In Lambda'
++// ACTION: Edit intention settings
++// ACTION: Make types implicit in lambda","Note that this test is now failing again due to obvious reasons :)
+",2014-04-23 12:29:36
+646,"@@ -1,7 +1,6 @@
+ fun foo() {
+-    val a: kotlin.test.Asserter?
+-    if (<caret>) {
+-        a = null
++    val a = if (<caret>) {","It's not OK that you're losing the variable type here.
+",2016-10-18 18:59:07
+381,"@@ -1,72 +0,0 @@
+-/*
+- * Copyright 2010-2015 JetBrains s.r.o.
+- *
+- * Licensed under the Apache License, Version 2.0 (the ""License"");
+- * you may not use this file except in compliance with the License.
+- * You may obtain a copy of the License at
+- *
+- * http://www.apache.org/licenses/LICENSE-2.0
+- *
+- * Unless required by applicable law or agreed to in writing, software
+- * distributed under the License is distributed on an ""AS IS"" BASIS,
+- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+- * See the License for the specific language governing permissions and
+- * limitations under the License.
+- */
+-
+-package org.jetbrains.kotlin.idea.quickfix
+-
+-import org.jetbrains.kotlin.psi.*
+-import kotlin.platform.*
+-import org.jetbrains.kotlin.diagnostics.*
+-import com.intellij.codeInsight.intention.*
+-import org.jetbrains.kotlin.idea.*
+-import com.intellij.openapi.project.*
+-import com.intellij.openapi.editor.*
+-import com.intellij.psi.*
+-import org.jetbrains.kotlin.idea.project.PluginJetFilesProvider
+-import org.jetbrains.kotlin.idea.quickfix.quickfixUtil.createIntentionFactory
+-import org.jetbrains.kotlin.idea.quickfix.quickfixUtil.createIntentionForFirstParentOfType
+-import org.jetbrains.kotlin.lexer.JetTokens
+-import org.jetbrains.kotlin.psi.psiUtil.*
+-import java.util.ArrayList
+-
+-
+-public class AddInitKeywordFix(element: JetClassInitializer) : JetIntentionAction<JetClassInitializer>(element) {
+-    override fun getText() = JetBundle.message(""add.init.keyword"")
+-
+-    override fun getFamilyName() = JetBundle.message(""add.init.keyword.family"")
+-
+-    override fun invoke(project: Project, editor: Editor?, file: JetFile) {
+-        addInitKeyword(element)
+-    }
+-
+-    companion object Factory : JetSingleIntentionActionFactory() {
+-        override fun createAction(diagnostic: Diagnostic) = diagnostic.createIntentionForFirstParentOfType(::AddInitKeywordFix)
+-
+-        public fun createWholeProjectFixFactory(): JetSingleIntentionActionFactory = createIntentionFactory {
+-            JetWholeProjectForEachElementOfTypeFix.createByPredicate<JetClassInitializer>(
+-                predicate = { !it.hasInitKeyword() },
+-                taskProcessor = { addInitKeyword(it) },
+-                modalTitle = JetBundle.message(""add.init.keyword.in.whole.project.modal.title""),
+-                name = JetBundle.message(""add.init.keyword.in.whole.project""),
+-                familyName = JetBundle.message(""add.init.keyword.in.whole.project.family"")
+-            )
+-        }
+-
+-        private fun addInitKeyword(element: JetClassInitializer) {
+-            if (element.hasInitKeyword()) return
+-
+-            val psiFactory = JetPsiFactory(element)
+-            val initKeyword = psiFactory.createInitKeyword()","JetPsiFactory.createInitKeyword became unused
+",2015-04-29 11:30:03
+635,"@@ -1,8 +1,9 @@
+ object A {
+     @JvmStatic fun main(args: Array<String>) {
+-        println(Void.TYPE)
+-        println(Integer.TYPE)
+-        println(java.lang.Double.TYPE)
++        println(Unit::class.javaPrimitiveType)","This doesn't actually work: `Unit` has no `javaPrimitiveType`. For `void.class`, the previous variant of the code should be used.
+",2016-10-10 17:23:18
+311,"@@ -10,21 +10,34 @@ import kotlin.jvm.internal.Intrinsic
+  *
+  * Example:
+  *
+- *      throws(javaClass<IOException>())
+- *      fun readFile(name: String): String {...}
++ * ```
++ * throws(javaClass<IOException>())
++ * fun readFile(name: String): String {...}
++ * ```
+  *
+  * will be translated to
+  *
+- *      String readFile(String name) throws IOException {...}
++ * ```
++ * String readFile(String name) throws IOException {...}
++ * ```
+  */
+ Retention(RetentionPolicy.SOURCE)
+ public annotation class throws(public vararg val exceptionClasses: Class<out Throwable>)
+ 
++/**
++ * Returns the runtime Java class of this object.
++ */
+ [Intrinsic(""kotlin.javaClass.property"")] public val <T: Any> T.javaClass : Class<T>
+     get() = (this as java.lang.Object).getClass() as Class<T>
+ 
++/**
++ * Returns the Java class for the specified type.
++ */
+ [Intrinsic(""kotlin.javaClass.function"")] public fun <reified T: Any> javaClass(): Class<T> = null as Class<T>
+ 
++/**
++ * Executes the given function [block] while holding the monitor of the given object [lock].","Somewhere I saw you called it ""semaphore"", and here calling ""monitor""
+",2015-02-09 16:23:16
+954,"@@ -10,6 +10,12 @@ class BasicAssertionsTest {
+     }
+ 
+     @Test
++    fun testAssertSame() {","`test` prefix reminds me old days of `JUnit`, where it was obligatory to run any test :-)
+
+Could you tell me why there is doubled `kotlin` and `test` packages in path: `kotlin/libraries/kotlin.test/common/src/test/kotlin/kotlin/test/tests/`? Just wondering.",2017-08-08 06:08:19
+589,"@@ -10,6 +10,12 @@ package kotlin.text
+ public inline fun buildString(builderAction: StringBuilder.() -> Unit): String = StringBuilder().apply(builderAction).toString()
+ 
+ /**
++ * Builds new string by populating newly created [StringBuilder] initialized with the given capacity using provided [builderAction] and then converting it to [String].
++ */","Will fix formatting upon rebase.
+",2016-08-08 22:59:18
+557,"@@ -10,6 +10,12 @@ package kotlin.text
+ public inline fun buildString(builderAction: StringBuilder.() -> Unit): String = StringBuilder().apply(builderAction).toString()
+ 
+ /**
++ * Builds new string by populating newly created [StringBuilder] initialized with the given capacity using provided [builderAction] and then converting it to [String].
++ */
++@kotlin.internal.InlineOnly
++inline fun buildString(length : Int, builderAction: StringBuilder.() -> Unit): String = StringBuilder(length).apply(builderAction).toString()","Constructor parameter is called `capacity` so it should have the same name here.
+Also there should be no space before `:` in parameter definition.
+",2016-05-17 17:43:41
+293,"@@ -10,9 +10,9 @@ import java.util.*
+ import java.util.Collections // TODO: it's temporary while we have java.util.Collections in js
+ 
+ /**
+- * Appends the string from all the elements separated using the *separator* and using the given *prefix* and *postfix* if supplied
+- * If a collection could be huge you can specify a non-negative value of *limit* which will only show a subset of the collection then it will
+- * a special *truncated* separator (which defaults to ""..."")
++ * Appends the string from all the elements separated using [separator] and using the given [prefix] and *postfix* if supplied.","Linkify `postfix`
+",2015-02-09 15:54:25
+294,"@@ -10,9 +10,9 @@ import java.util.*
+ import java.util.Collections // TODO: it's temporary while we have java.util.Collections in js
+ 
+ /**
+- * Appends the string from all the elements separated using the *separator* and using the given *prefix* and *postfix* if supplied
+- * If a collection could be huge you can specify a non-negative value of *limit* which will only show a subset of the collection then it will
+- * a special *truncated* separator (which defaults to ""..."")
++ * Appends the string from all the elements separated using [separator] and using the given [prefix] and *postfix* if supplied.
++ * If the collection could be huge, you can specify a non-negative value of [limit], in which case only the first [limit]
++ * elements will be appended, followed by the [truncated] string (which defaults to ""..."").","Ideally `trucated` should default to ""…"", not ""...""
+",2015-02-09 15:55:06
+332,"@@ -100,65 +181,143 @@ public class Byte private () : Number, Comparable<Byte> {
+  * On the JVM, non-nullable values of this type are represented as values of the primitive type `char`.
+  */
+ public class Char private () : Comparable<Char> {
+-    class object {}
++    default object {}
+ 
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Byte): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public override fun compareTo(other: Char): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Short): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Int): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Long): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Float): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Double): Int
+ 
++    /** Adds the two values. */
+     public fun plus(other: Byte): Int
++    /** Adds the two values. */
+     public fun plus(other: Short): Int
++    /** Adds the two values. */
+     public fun plus(other: Int): Int
++    /** Adds the two values. */
+     public fun plus(other: Long): Long
++    /** Adds the two values. */
+     public fun plus(other: Float): Float
++    /** Adds the two values. */
+     public fun plus(other: Double): Double
+ 
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Byte): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Char): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Short): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Int): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Long): Long
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Float): Float
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Double): Double
+ 
++    /** Multiplies the two values. */
+     public fun times(other: Byte): Int
++    /** Multiplies the two values. */
+     public fun times(other: Short): Int
++    /** Multiplies the two values. */
+     public fun times(other: Int): Int
++    /** Multiplies the two values. */
+     public fun times(other: Long): Long
++    /** Multiplies the two values. */
+     public fun times(other: Float): Float
++    /** Multiplies the two values. */
+     public fun times(other: Double): Double
+ 
++    /** Divides this value by the other value. */
+     public fun div(other: Byte): Int
++    /** Divides this value by the other value. */
+     public fun div(other: Short): Int
++    /** Divides this value by the other value. */
+     public fun div(other: Int): Int
++    /** Divides this value by the other value. */
+     public fun div(other: Long): Long
++    /** Divides this value by the other value. */
+     public fun div(other: Float): Float
++    /** Divides this value by the other value. */
+     public fun div(other: Double): Double
+ 
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Byte): Int
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Short): Int
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Int): Int
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Long): Long
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Float): Float
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Double): Double
+ 
++    /** Increments this value. */
+     public fun inc(): Char
++    /** Decrements this value. */
+     public fun dec(): Char
++    /** Returns this value. */
+     public fun plus(): Int
++    /** Returns the negative of this value. */
+     public fun minus(): Int
+ 
++     /** Creates a range from this value to the specified [other] value. */
+     public fun rangeTo(other: Char): CharRange","We don't have other overloads for rangeTo, like in other types?
+",2015-03-12 14:45:44
+333,"@@ -100,65 +181,143 @@ public class Byte private () : Number, Comparable<Byte> {
+  * On the JVM, non-nullable values of this type are represented as values of the primitive type `char`.
+  */
+ public class Char private () : Comparable<Char> {
+-    class object {}
++    default object {}
+ 
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Byte): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public override fun compareTo(other: Char): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Short): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Int): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Long): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Float): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Double): Int
+ 
++    /** Adds the two values. */
+     public fun plus(other: Byte): Int
++    /** Adds the two values. */
+     public fun plus(other: Short): Int
++    /** Adds the two values. */
+     public fun plus(other: Int): Int
++    /** Adds the two values. */
+     public fun plus(other: Long): Long
++    /** Adds the two values. */
+     public fun plus(other: Float): Float
++    /** Adds the two values. */
+     public fun plus(other: Double): Double
+ 
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Byte): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Char): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Short): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Int): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Long): Long
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Float): Float
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Double): Double
+ 
++    /** Multiplies the two values. */
+     public fun times(other: Byte): Int
++    /** Multiplies the two values. */
+     public fun times(other: Short): Int
++    /** Multiplies the two values. */
+     public fun times(other: Int): Int
++    /** Multiplies the two values. */
+     public fun times(other: Long): Long
++    /** Multiplies the two values. */
+     public fun times(other: Float): Float
++    /** Multiplies the two values. */
+     public fun times(other: Double): Double
+ 
++    /** Divides this value by the other value. */
+     public fun div(other: Byte): Int
++    /** Divides this value by the other value. */
+     public fun div(other: Short): Int
++    /** Divides this value by the other value. */
+     public fun div(other: Int): Int
++    /** Divides this value by the other value. */
+     public fun div(other: Long): Long
++    /** Divides this value by the other value. */
+     public fun div(other: Float): Float
++    /** Divides this value by the other value. */
+     public fun div(other: Double): Double
+ 
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Byte): Int
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Short): Int
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Int): Int
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Long): Long
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Float): Float
++    /** Calculates the remainder of dividing this value by the other value. */
+     public fun mod(other: Double): Double
+ 
++    /** Increments this value. */
+     public fun inc(): Char
++    /** Decrements this value. */
+     public fun dec(): Char
++    /** Returns this value. */
+     public fun plus(): Int
++    /** Returns the negative of this value. */
+     public fun minus(): Int
+ 
++     /** Creates a range from this value to the specified [other] value. */
+     public fun rangeTo(other: Char): CharRange
+ 
++    /** Returns the value of this character as a `name`. */","As a name?
+",2015-03-12 14:46:03
+975,"@@ -105,8 +105,19 @@ public KotlinTypeInfo visitIfExpression(KtIfExpression ifExpression, ExpressionT
+ 
+         LexicalWritableScope thenScope = newWritableScopeImpl(context, LexicalScopeKind.THEN, components.overloadChecker);
+         LexicalWritableScope elseScope = newWritableScopeImpl(context, LexicalScopeKind.ELSE, components.overloadChecker);
+-        DataFlowInfo thenInfo = components.dataFlowAnalyzer.extractDataFlowInfoFromCondition(condition, true, context).and(conditionDataFlowInfo);
+-        DataFlowInfo elseInfo = components.dataFlowAnalyzer.extractDataFlowInfoFromCondition(condition, false, context).and(conditionDataFlowInfo);
++        DataFlowInfo basicThenInfo = components.dataFlowAnalyzer.extractDataFlowInfoFromCondition(condition, true, context).and(conditionDataFlowInfo);
++        DataFlowInfo thenInfoFromES = components.effectSystem.getConditionalInfoForThenBranch(",I'd expect here some language feature check.,2017-08-15 16:13:17
+385,"@@ -107,29 +106,38 @@ protected ExitCode doExecute(
+         Project project = environmentForJS.getProject();
+         List<JetFile> sourcesFiles = environmentForJS.getSourceFiles();
+ 
+-        if (arguments.verbose) {
+-            reportCompiledSourcesList(messageCollector, sourcesFiles);
++        if (arguments.outputFile == null) {
++            messageSeverityCollector.report(CompilerMessageSeverity.ERROR, ""Specify output file via -output"", CompilerMessageLocation.NO_LOCATION);
++            return ExitCode.INTERNAL_ERROR;
+         }
+ 
+-        if (arguments.outputFile == null) {
+-            messageCollector.report(CompilerMessageSeverity.ERROR, ""Specify output file via -output"", CompilerMessageLocation.NO_LOCATION);
++        if (messageSeverityCollector.anyReported(CompilerMessageSeverity.ERROR)) {
+             return ExitCode.INTERNAL_ERROR;
+         }
+ 
++        if (sourcesFiles.isEmpty()) {
++            messageSeverityCollector.report(CompilerMessageSeverity.ERROR, ""No source files"", CompilerMessageLocation.NO_LOCATION);
++            return COMPILATION_ERROR;","Maybe we should have another exit code for such cases? e.g. `ILLEGAL_ARGUMENTS_ERROR`.
+
+//cc @udalov 
+",2015-06-11 10:41:44
+694,"@@ -110,7 +149,10 @@ fun createContainerForLazyResolveWithJava(
+         useImpl<LazyResolveToken>()
+     }
+ }.apply {
+-    get<JavaClassFinderImpl>().initialize(bindingTrace, get<KotlinCodeAnalyzer>())
++    if (useJavac)
++        get<JavacClassFinder>().initialize(bindingTrace, get<KotlinCodeAnalyzer>())",I'd write here `JavacBasedClassFinder`. The current name is too close to just `JavaClassFinder`.,2017-04-05 12:17:44
+872,"@@ -111,7 +114,9 @@ interface ReplEvalAction {
+ 
+ sealed class ReplEvalResult : Serializable {
+     class ValueResult(val value: Any?) : ReplEvalResult() {
+-        override fun toString(): String = ""Result: $value""
++        val type = LastInferredTypeHolder.inferredType.get()",I think you can obtain this type from `compileResult` at `GenericReplEvaluator.eval` and pass to `ValueResult`'s constructor here,2017-06-13 14:36:40
+889,"@@ -112,9 +112,18 @@ class MemberVisibilityCanPrivateInspection : AbstractKotlinInspection() {
+             else -> ""Property""
+         }
+         val nameElement = (declaration as? PsiNameIdentifierOwner)?.nameIdentifier ?: return
+-        holder.registerProblem(declaration.visibilityModifier() ?: nameElement,
++        val visibilityModifier = declaration.visibilityModifier()
++        val fix = object : AddModifierFix(modifierListOwner, KtTokens.PRIVATE_KEYWORD) {","I would do this as a general fix to AddModifierFix (which already has special logic for handling modality modifiers), not as a single-case override here.",2017-07-10 09:10:34
+496,"@@ -112,9 +112,20 @@ void parseFile() {
+             parseTopLevelDeclaration();
+         }
+ 
++        checkUnclosedBlockComment();
+         fileMarker.done(KT_FILE);
+     }
+ 
++    private void checkUnclosedBlockComment() {
++        if (TokenSet.create(BLOCK_COMMENT, DOC_COMMENT).contains(myBuilder.rawLookup(-1))) {
++            int startOffset = myBuilder.rawTokenTypeStart(-1);
++            int endOffset = myBuilder.rawTokenTypeStart(0);
++            if (!myBuilder.getOriginalText().subSequence(startOffset, endOffset).toString().endsWith(""*/"")) {","This may materialize a huge file as a single string (in case of this file being commented entirely)
+
+We could probably use other means, such as:
+- changing the lexer to emit a special token type on unfinished comments
+- using the CharSequence API to only materialize the last two characters as String, and not the entire text
+",2015-12-17 16:52:41
+497,"@@ -112,9 +112,20 @@ void parseFile() {
+             parseTopLevelDeclaration();
+         }
+ 
++        checkUnclosedBlockComment();
+         fileMarker.done(KT_FILE);
+     }
+ 
++    private void checkUnclosedBlockComment() {
++        if (TokenSet.create(BLOCK_COMMENT, DOC_COMMENT).contains(myBuilder.rawLookup(-1))) {
++            int startOffset = myBuilder.rawTokenTypeStart(-1);
++            int endOffset = myBuilder.rawTokenTypeStart(0);
++            if (!myBuilder.getOriginalText().subSequence(startOffset, endOffset).toString().endsWith(""*/"")) {
++                error(""Unclosed comment"");","This error is placed before the comment, in Java it is at the end of the file
+",2015-12-17 16:53:02
+580,"@@ -114,15 +116,28 @@ class KotlinQuickDocumentationProvider : AbstractDocumentationProvider() {
+             return null
+         }
+ 
+-        private fun renderKotlinDeclaration(declaration: KtDeclaration, quickNavigation: Boolean): String {
++        private fun renderKotlinDeclaration(declaration: KtExpression, quickNavigation: Boolean): String {
+             val context = declaration.analyze(BodyResolveMode.PARTIAL)
+-            var declarationDescriptor = context[BindingContext.DECLARATION_TO_DESCRIPTOR, declaration]
++            val declarationDescriptor = context[BindingContext.DECLARATION_TO_DESCRIPTOR, declaration]
+ 
+             if (declarationDescriptor == null) {
+                 LOG.info(""Failed to find descriptor for declaration "" + declaration.getElementTextWithContext())
+                 return ""No documentation available""
+             }
+ 
++            return renderKotlin(context, declarationDescriptor, quickNavigation)
++        }
++
++        private fun renderKotlinImplicitLambdaParameter(element: KtReferenceExpression, quickNavigation: Boolean): String? {
++            val context = element.analyze(BodyResolveMode.PARTIAL)
++            val target = element.mainReference.resolveToDescriptors(context).singleOrNull() as? ValueParameterDescriptor? ?: return null
++            context.get(BindingContext.AUTO_CREATED_IT, target)","This line doesn't do anything
+",2016-07-05 11:32:13
+581,"@@ -114,15 +116,28 @@ class KotlinQuickDocumentationProvider : AbstractDocumentationProvider() {
+             return null
+         }
+ 
+-        private fun renderKotlinDeclaration(declaration: KtDeclaration, quickNavigation: Boolean): String {
++        private fun renderKotlinDeclaration(declaration: KtExpression, quickNavigation: Boolean): String {
+             val context = declaration.analyze(BodyResolveMode.PARTIAL)
+-            var declarationDescriptor = context[BindingContext.DECLARATION_TO_DESCRIPTOR, declaration]
++            val declarationDescriptor = context[BindingContext.DECLARATION_TO_DESCRIPTOR, declaration]
+ 
+             if (declarationDescriptor == null) {
+                 LOG.info(""Failed to find descriptor for declaration "" + declaration.getElementTextWithContext())
+                 return ""No documentation available""
+             }
+ 
++            return renderKotlin(context, declarationDescriptor, quickNavigation)
++        }
++
++        private fun renderKotlinImplicitLambdaParameter(element: KtReferenceExpression, quickNavigation: Boolean): String? {
++            val context = element.analyze(BodyResolveMode.PARTIAL)
++            val target = element.mainReference.resolveToDescriptors(context).singleOrNull() as? ValueParameterDescriptor? ?: return null
++            context.get(BindingContext.AUTO_CREATED_IT, target)
++            return renderKotlin(context, target, quickNavigation)
++        }
++
++        private fun renderKotlin(context: BindingContext, declarationDescriptor: DeclarationDescriptor, quickNavigation: Boolean): String {
++            @Suppress(""NAME_SHADOWING"")
++            var declarationDescriptor = declarationDescriptor","This doesn't seem to be needed, either
+",2016-07-05 11:32:43
+587,"@@ -115,9 +116,73 @@ class KotlinCodeFragmentFactory: CodeFragmentFactory() {
+             }
+         })
+ 
++        if (contextElement != null && contextElement !is KtElement) {","Now such variables are skipped during text rendering, so it doesn't matter if they are present in resulting map (this map is used only to get values for kotlin variables that are present in resulting text)
+",2016-08-03 14:11:50
+588,"@@ -115,9 +116,73 @@ class KotlinCodeFragmentFactory: CodeFragmentFactory() {
+             }
+         })
+ 
++        if (contextElement != null && contextElement !is KtElement) {
++            codeFragment.putCopyableUserData(KtCodeFragment.FAKE_CONTEXT_FOR_JAVA_FILE, {
++                val emptyFile = createFakeFileWithJavaContextElement("""", contextElement)
++
++                val debuggerContext = DebuggerManagerEx.getInstanceEx(project).context
++                val debuggerSession = debuggerContext.debuggerSession
++                if ((debuggerSession == null || debuggerContext.suspendContext == null) && !ApplicationManager.getApplication().isUnitTestMode) {
++                    LOG.warn(""Couldn't create fake context element for java file, debugger isn't paused on breakpoint"")
++                    return@putCopyableUserData emptyFile
++                }
++
++                // TODO: 'this' is unavailable
++                val visibleVariables = getVisibleLocalVariables(contextElement, debuggerContext)
++                if (visibleVariables == null) {
++                    LOG.warn(""Couldn't get a list of local variables for ${debuggerContext.sourcePosition.file.name}:${debuggerContext.sourcePosition.line}"")
++                    return@putCopyableUserData emptyFile
++                }
++
++                val fakeFunctionText = ""fun _java_locals_debug_fun_() {\n"" +
++                                       visibleVariables.entries.associate { it.key.name() to it.value }.kotlinVariablesAsText(project) +
++                                       ""}""
++
++                val fakeFile = createFakeFileWithJavaContextElement(fakeFunctionText, contextElement)
++                val fakeFunction = fakeFile.declarations.firstOrNull() as? KtFunction
++                val fakeContext = (fakeFunction?.bodyExpression as? KtBlockExpression)?.statements?.lastOrNull()
++
++                return@putCopyableUserData wrapContextIfNeeded(project, contextElement, fakeContext) ?: emptyFile
++            })
++        }
++
+         return codeFragment
+     }
+ 
++    private fun getVisibleLocalVariables(contextElement: PsiElement?, debuggerContext: DebuggerContextImpl): Map<LocalVariable, Value>? {
++        val semaphore = Semaphore()
++        semaphore.down()
++
++        var visibleVariables: Map<LocalVariable, Value>? = null
++
++        val worker = object : DebuggerCommandImpl() {
++            override fun action() {","I've replaced it with codeFragment.getContentElement().statements.lastOrNull() to make this line clearer
+",2016-08-03 14:13:56
+421,"@@ -116,13 +128,35 @@ private static String execCompiler(
+             List<String> argumentsList = ArgumentUtils.convertArgumentsToStringList(arguments);
+             argumentsList.addAll(StringUtil.split(additionalArguments, "" ""));
+ 
++            String[] argsArray = ArrayUtil.toStringArray(argumentsList);
++
++            // trying the daemon first
++            if (incrementalCaches != null && KotlinCompilerClient.Companion.isDaemonEnabled()) {
++                File libPath = CompilerRunnerUtil.getLibPath(environment.getKotlinPaths(), messageCollector);
++                // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
++                //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
++                CompilerId compilerId = CompilerId.makeCompilerId(new File(libPath, ""kotlin-compiler.jar""));
++                DaemonOptions daemonOptions = new DaemonOptions();
++                DaemonLaunchingOptions daemonLaunchingOptions = new DaemonLaunchingOptions();
++                KotlinCompilerClient.Companion.configureDaemonLaunchingOptions(daemonLaunchingOptions);
++                // TODO: find proper stream to report daemon connection progress
++                CompileService daemon = KotlinCompilerClient.Companion.connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, System.out, true, true);
++                if (daemon != null) {
++                    Integer res = KotlinCompilerClient.Companion.incrementalCompile(daemon, argsArray, incrementalCaches, out);
++                    return res.toString();
++                }
++            }
++
++            // otherwise fallback to in-process
++
+             Object rc = CompilerRunnerUtil.invokeExecMethod(
+-                    compilerClassName, ArrayUtil.toStringArray(argumentsList), environment, messageCollector, out
++                    compilerClassName, argsArray, environment, messageCollector, out
+             );
+ 
+             // exec() returns an ExitCode object, class of which is loaded with a different class loader,
+             // so we take it's contents through reflection
+             return getReturnCodeFromObject(rc);
++","Extra empty line.
+",2015-08-20 14:15:28
+514,"@@ -1162,3 +1162,77 @@ public fun CharSequence.lineSequence(): Sequence<String> = splitToSequence(""\r\n
+  * * Splits this char sequence to a list of lines delimited by any of the following character sequences: CRLF, LF or CR.
+  */
+ public fun CharSequence.lines(): List<String> = lineSequence().toList()
++
++/**
++ * For each i in [0, length), this function computes
++ * the length of the longest suffix of a substring of pattern from 0 to i
++ * that is also a prefix of the pattern itself.
++ */
++private fun computePrefixFunction(pattern: CharSequence): IntArray {
++    val resultTable = IntArray(pattern.length)
++
++    var matches = 0
++    for (i in 1..pattern.length - 1) {
++        while (matches > 0 && pattern[matches] != pattern[i]) {
++            matches = resultTable[matches]
++        }
++
++        if (pattern[matches] == pattern[i]) {
++            matches++
++        }
++        resultTable[i] = matches
++    }
++
++    return resultTable
++}
++
++/**
++ * Returns a list of indices where the pattern occurs in this String. This method
++ * searches character by character and thus does not support regular expressions
++ * as input for the pattern.
++ *
++ * @param [pattern] The pattern to look for in this String. Regular expressions
++ *                 are not supported
++ * @param [ignoreCase] If true, characters are matched even if one is upper and the other is
++ *                 lower case
++ *
++ * @return A list of indices where the supplied [pattern] starts in the text.
++ */
++public fun CharSequence.occurrencesOf(pattern: CharSequence, ignoreCase: Boolean = false): Sequence<Int> {
++
++    if (isEmpty() || pattern.isEmpty()) {","`if (pattern.isEmpty() || pattern.length > this.length)`  ?
+",2016-02-16 19:00:19
+515,"@@ -1162,3 +1162,77 @@ public fun CharSequence.lineSequence(): Sequence<String> = splitToSequence(""\r\n
+  * * Splits this char sequence to a list of lines delimited by any of the following character sequences: CRLF, LF or CR.
+  */
+ public fun CharSequence.lines(): List<String> = lineSequence().toList()
++
++/**
++ * For each i in [0, length), this function computes
++ * the length of the longest suffix of a substring of pattern from 0 to i
++ * that is also a prefix of the pattern itself.
++ */
++private fun computePrefixFunction(pattern: CharSequence): IntArray {
++    val resultTable = IntArray(pattern.length)
++
++    var matches = 0
++    for (i in 1..pattern.length - 1) {
++        while (matches > 0 && pattern[matches] != pattern[i]) {
++            matches = resultTable[matches]
++        }
++
++        if (pattern[matches] == pattern[i]) {
++            matches++
++        }
++        resultTable[i] = matches
++    }
++
++    return resultTable
++}
++
++/**
++ * Returns a list of indices where the pattern occurs in this String. This method
++ * searches character by character and thus does not support regular expressions
++ * as input for the pattern.
++ *
++ * @param [pattern] The pattern to look for in this String. Regular expressions
++ *                 are not supported
++ * @param [ignoreCase] If true, characters are matched even if one is upper and the other is
++ *                 lower case
++ *
++ * @return A list of indices where the supplied [pattern] starts in the text.
++ */
++public fun CharSequence.occurrencesOf(pattern: CharSequence, ignoreCase: Boolean = false): Sequence<Int> {
++
++    if (pattern.isEmpty() || pattern.length > this.length) {
++        return emptySequence()","I believe this should be consistent with the result of `Regex("""").findAll(input = ""...."")`, i.e. a match in every position.
+",2016-02-17 02:35:56
+528,"@@ -1162,3 +1162,84 @@ public fun CharSequence.lineSequence(): Sequence<String> = splitToSequence(""\r\n
+  * * Splits this char sequence to a list of lines delimited by any of the following character sequences: CRLF, LF or CR.
+  */
+ public fun CharSequence.lines(): List<String> = lineSequence().toList()
++
++/**
++ * For each i in [0, length), this function computes
++ * the length of the longest suffix of a substring of pattern from 0 to i
++ * that is also a prefix of the pattern itself.
++ */
++private fun computePrefixFunction(pattern: CharSequence): IntArray {
++    val resultTable = IntArray(pattern.length)
++
++    var matches = 0
++    for (i in 1..pattern.length - 1) {
++        while (matches > 0 && pattern[matches] != pattern[i]) {
++            matches = resultTable[matches]
++        }
++
++        if (pattern[matches] == pattern[i]) {
++            matches++
++        }
++        resultTable[i] = matches
++    }
++
++    return resultTable
++}
++
++/**
++ * Returns a list of indices where the pattern occurs in this String. This method
++ * searches character by character and thus does not support regular expressions
++ * as input for the pattern.
++ * For a pattern longer than the text, an empty sequence is returned. If the pattern
++ * is empty, all indices are matched.
++ *
++ * @param [pattern] The pattern to look for in this String. Regular expressions
++ *                 are not supported
++ * @param [ignoreCase] If true, characters are matched even if one is upper and the other is
++ *                 lower case
++ * @param [matchOverlapping] If true, also match overlapping occurences.
++ *
++ * @return A list of indices where the supplied [pattern] starts in the text.
++ */
++public fun CharSequence.occurrencesOf(pattern: CharSequence, ignoreCase: Boolean = false, matchOverlapping: Boolean = false): Sequence<Int> {
++
++    if (pattern.length > this.length) {
++        return emptySequence()
++    }
++
++    if (pattern.isEmpty()) {
++        return indices.asSequence()","It should be `(0..length).asSequence()`, because you need to count an empty match before the first character and empty one after the last characater.
+",2016-03-02 18:56:47
+529,"@@ -1162,3 +1162,84 @@ public fun CharSequence.lineSequence(): Sequence<String> = splitToSequence(""\r\n
+  * * Splits this char sequence to a list of lines delimited by any of the following character sequences: CRLF, LF or CR.
+  */
+ public fun CharSequence.lines(): List<String> = lineSequence().toList()
++
++/**
++ * For each i in [0, length), this function computes
++ * the length of the longest suffix of a substring of pattern from 0 to i
++ * that is also a prefix of the pattern itself.
++ */
++private fun computePrefixFunction(pattern: CharSequence): IntArray {
++    val resultTable = IntArray(pattern.length)
++
++    var matches = 0
++    for (i in 1..pattern.length - 1) {
++        while (matches > 0 && pattern[matches] != pattern[i]) {
++            matches = resultTable[matches]
++        }
++
++        if (pattern[matches] == pattern[i]) {
++            matches++
++        }
++        resultTable[i] = matches
++    }
++
++    return resultTable
++}
++
++/**
++ * Returns a list of indices where the pattern occurs in this String. This method
++ * searches character by character and thus does not support regular expressions
++ * as input for the pattern.
++ * For a pattern longer than the text, an empty sequence is returned. If the pattern
++ * is empty, all indices are matched.
++ *
++ * @param [pattern] The pattern to look for in this String. Regular expressions
++ *                 are not supported
++ * @param [ignoreCase] If true, characters are matched even if one is upper and the other is
++ *                 lower case
++ * @param [matchOverlapping] If true, also match overlapping occurences.
++ *
++ * @return A list of indices where the supplied [pattern] starts in the text.
++ */
++public fun CharSequence.occurrencesOf(pattern: CharSequence, ignoreCase: Boolean = false, matchOverlapping: Boolean = false): Sequence<Int> {
++
++    if (pattern.length > this.length) {
++        return emptySequence()
++    }
++
++    if (pattern.isEmpty()) {
++        return indices.asSequence()
++    }
++
++    if (pattern.length == 1) {
++        return indices.asSequence().filter { this[it].equals(pattern[0], ignoreCase) }","We could extract `CharSequence.occurrencesOf(char: Char, ignoreCase)` function from here.
+",2016-03-02 18:58:18
+558,"@@ -1162,3 +1162,97 @@ public fun CharSequence.lineSequence(): Sequence<String> = splitToSequence(""\r\n
+  * * Splits this char sequence to a list of lines delimited by any of the following character sequences: CRLF, LF or CR.
+  */
+ public fun CharSequence.lines(): List<String> = lineSequence().toList()
++
++/**
++ * For each i in [0, length), this function computes
++ * the length of the longest suffix of a substring of pattern from 0 to i
++ * that is also a prefix of the pattern itself.
++ */
++private fun computePrefixFunction(pattern: CharSequence): IntArray {","I'm not sure the prefix function is computed correctly. For the following example ""ABCDABD"" it returns [0,0,0,0,1,2,0], while according to the [reference](https://en.wikipedia.org/wiki/Knuth%E2%80%93Morris%E2%80%93Pratt_algorithm#Worked_example_of_the_table-building_algorithm) it should be [-1,0,0,0,0,1,2].
+
+Also it loops infinitely on the input ""AAABAAB"".
+",2016-05-17 19:15:22
+567,"@@ -1162,3 +1162,97 @@ public fun CharSequence.lineSequence(): Sequence<String> = splitToSequence(""\r\n
+  * * Splits this char sequence to a list of lines delimited by any of the following character sequences: CRLF, LF or CR.
+  */
+ public fun CharSequence.lines(): List<String> = lineSequence().toList()
++
++/**
++ * For each i in [0, length), this function computes
++ * the length of the longest suffix of a substring of pattern from 0 to i
++ * that is also a prefix of the pattern itself.
++ */
++private fun computePrefixFunction(pattern: CharSequence): IntArray {
++    val resultTable = IntArray(pattern.length)
++
++    var matches = 0
++    for (i in 1..pattern.length - 1) {
++        while (matches > 0 && pattern[matches] != pattern[i]) {
++            matches = resultTable[matches - 1]
++        }
++
++        if (pattern[matches] == pattern[i]) {
++            matches++
++        }
++        resultTable[i] = matches
++    }
++
++    return resultTable
++}
++
++/**
++ * Returns a sequence of indices where the char occurs in this CharSequence.
++ *
++ * @param [char] The character to look for in the string
++ * @param [ignoreCase] If true, characters are matched even if one is upper and the other is
++ *                 lower case
++ *
++ * @return A list of indices where the supplied [char] occurs in the text.
++ */
++public fun CharSequence.occurrencesOf(char: Char, ignoreCase: Boolean = false): Sequence<Int> {
++    return indices.asSequence().filter { this[it].equals(char, ignoreCase) }
++}
++
++/**
++ * Returns a sequence of indices where the pattern occurs in this CharSequence. This method
++ * searches character by character and thus does not support regular expressions
++ * as input for the pattern.
++ * For a pattern longer than the text, an empty sequence is returned. If the pattern
++ * is empty, all indices plus an empty occurrence at the end are matched.
++ *
++ * @param [pattern] The pattern to look for in this String. Regular expressions
++ *                 are not supported
++ * @param [ignoreCase] If true, characters are matched even if one is upper and the other is
++ *                 lower case
++ * @param [matchOverlapping] If true, also match overlapping occurrences.
++ *
++ * @return A list of indices where the supplied [pattern] starts in the text.
++ */
++public fun CharSequence.occurrencesOf(pattern: CharSequence, ignoreCase: Boolean = false, matchOverlapping: Boolean = false): Sequence<Int> {
++
++    if (pattern.length > this.length) {
++        return emptySequence()
++    }
++
++    if (pattern.isEmpty()) {
++        return (0..length).asSequence()
++    }
++
++    if (pattern.length == 1) {
++        return occurrencesOf(pattern[0], ignoreCase)
++    }
++
++    // Non-trivial pattern matching, perform computation
++    // using Knuth-Morris-Pratt
++
++    val prefixFunction = computePrefixFunction(pattern)
++
++    var i = 0
++    var matches = 0
++    return generateSequence {
++        while (i < length) {
++            while (matches > 0 && !pattern[matches].equals(this[i], ignoreCase)) {
++                matches = prefixFunction[matches - 1]
++            }
++
++            if (pattern[matches].equals(this[i], ignoreCase)) {
++                matches++
++            }","This approach requires two character comparisons per position when `matches > 0`. Is it possible to restructure the loop body? Also applies to `computePrefixFunction`.
+",2016-05-18 20:09:24
+578,"@@ -117,7 +117,7 @@ and find classes or functions which are not documented very well and submit a pa
+ In particular it'd be great if all functions included a nice example of how to use it such as for the
+ <a href=""http://kotlinlang.org/api/latest/jvm/stdlib/kotlin/hash-map-of.html"">hashMapOf()</a> function.
+ This is implemented using the <a href=https://github.com/JetBrains/kotlin/blob/master/libraries/stdlib/src/kotlin/collections/Maps.kt#L53"">@sample</a>
+-macro to include code from a test function. This serves as a double win; the API gets better documented with nice examples to help new users and the code gets more test coverage.
++macro to include code from a test function. The benefits of this approach are twofold; First, the API's documentations is improved via beneficial examples that help new users and second, the code coverage is increased.","> documentations is
+
+Not sure if it's consistent: either ""documentations are"" or ""documentation is""
+",2016-06-07 15:57:33
+495,"@@ -117,9 +118,8 @@ public object KotlinCompilerRunner {
+                 val stream = ByteArrayOutputStream()
+                 val out = PrintStream(stream)
+ 
+-// Uncomment after resolving problems with parallel compilation and tests
+-//                if (System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY) == null)
+-//                    System.setProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY, """")
++                if (java.lang.Boolean.parseBoolean(System.getProperty(GlobalOptions.COMPILE_PARALLEL_OPTION, ""false"")))","use `String#toBoolean()`
+",2015-12-01 14:14:38
+5,"@@ -118,17 +119,33 @@ private static Integer doExec(@NotNull CompileContext context, @NotNull Compiler
+             context.addMessage(CompilerMessageCategory.ERROR, ""K2JSCompiler does not support multiple module source roots."", null, -1, -1);
+             return -1;
+         }
+-        String[] commandLineArgs = constructArguments(context.getProject(), context.getModuleOutputDirectory(module), roots[0]);
++
++        VirtualFile outDir = context.getModuleOutputDirectory(module);
++        String outFile = outDir == null ? null : K2JSRunnerUtils.constructPathToGeneratedFile(context.getProject(), outDir.getPath());
++
++        String[] commandLineArgs = constructArguments(context.getProject(), outFile, roots[0]);
+         Object rc = invokeExecMethod(environment, out, context, commandLineArgs, ""org.jetbrains.jet.cli.js.K2JSCompiler"");
++
++        if (outDir != null) {
++            outDir.refresh(false, true);","Can you please tell me what this is about?
+",2012-05-15 18:35:31
+292,"@@ -1191,14 +1191,14 @@ public inline fun <T> Iterable<T>.takeWhile(predicate: (T) -> Boolean): List<T>
+ }
+ 
+ /**
+- * Returns a stream containing first elements satisfying the given *predicate*
++ * Returns a stream containing first elements satisfying the given [predicate]
+  */
+ public fun <T> Stream<T>.takeWhile(predicate: (T) -> Boolean): Stream<T> {
+     return TakeWhileStream(this, predicate)
+ }
+ 
+ /**
+- * Returns a list containing first elements satisfying the given *predicate*
++ * Returns a string containing the first characters that satisfy the given [predicate]","""the first characters"", do not need ""the""
+",2015-02-09 15:53:46
+297,"@@ -12,7 +12,7 @@ public fun <T> Enumeration<T>.iterator(): Iterator<T> = object : Iterator<T> {
+ }
+ 
+ /**
+- * Returns the given iterator itself. This allows to use an instance of iterator in a ranged for-loop
++ * Returns the given iterator itself. This allows to use an instance of iterator in a ranged for-loop.","""ranged for-loop"" -> ""`for` loop""
+",2015-02-09 16:00:05
+124,"@@ -120,6 +129,39 @@ fun JetElement.wrapInBlock(): JetBlockExpression {
+     block.appendElement(this)
+     return block
+ }
++
++fun JetExpressionImpl.findBlockInExpression(element: JetExpressionImpl,  expressionType: String?): JetBlockExpression? {","Why are this and the following functions extensions, but you don't use `this` in them and require call sites to pass same value twice?
+",2014-03-04 16:01:55
+125,"@@ -120,6 +129,39 @@ fun JetElement.wrapInBlock(): JetBlockExpression {
+     block.appendElement(this)
+     return block
+ }
++
++fun JetExpressionImpl.findBlockInExpression(element: JetExpressionImpl,  expressionType: String?): JetBlockExpression? {
++    val bodyNode = when (expressionType) {
++        ""if"" -> element.getNode().findChildByType(JetNodeTypes.THEN)
++        ""else"" -> element.getNode().findChildByType(JetNodeTypes.ELSE)
++        else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++    }
++    if (bodyNode?.getPsi()?.getFirstChild() is JetBlockExpression) {
++        return bodyNode!!.getPsi()!!.getFirstChild() as JetBlockExpression
++    }
++    return null","Use the power of Kotlin :) Four lines can be replaced with `return bodyNode?.getPsi()?.getFirstChild() as? JetBlockExpression`
+",2014-03-04 16:02:09
+126,"@@ -120,6 +129,39 @@ fun JetElement.wrapInBlock(): JetBlockExpression {
+     block.appendElement(this)
+     return block
+ }
++
++fun JetExpressionImpl.findBlockInExpression(element: JetExpressionImpl,  expressionType: String?): JetBlockExpression? {
++    val bodyNode = when (expressionType) {
++        ""if"" -> element.getNode().findChildByType(JetNodeTypes.THEN)
++        ""else"" -> element.getNode().findChildByType(JetNodeTypes.ELSE)
++        else -> element.getNode().findChildByType(JetNodeTypes.BODY)
++    }
++    if (bodyNode?.getPsi()?.getFirstChild() is JetBlockExpression) {
++        return bodyNode!!.getPsi()!!.getFirstChild() as JetBlockExpression
++    }
++    return null
++}
++
++fun JetExpressionImpl.getExpressionType(element: JetExpressionImpl): String? {","""Expression type"" phrase usually means different thing, so this usage of it is misleading. Better to replace ""type"" word with ""kind"". Don't forget that you have this phrase in several other places.
+Also, it's better to use enumeration instead of strings, because it's more type-safe. Enumeration can be named `ExpressionBlockKind` or something like this.
+",2014-03-04 16:03:02
+255,"@@ -121,17 +164,16 @@ public open class KotlinCompile(): AbstractCompile() {
+         args.noOptimize = kotlinOptions.noOptimize
+         args.noCallAssertions = kotlinOptions.noCallAssertions
+         args.noParamAssertions = kotlinOptions.noParamAssertions
++    }
+ 
+-        val messageCollector = GradleMessageCollector(getLogger())
+-        getLogger().debug(""Calling compiler"")
+-        val exitCode = compiler.exec(messageCollector, Services.EMPTY, args)
+-
+-        when (exitCode) {
+-            ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
+-            ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
+-            else -> {}
+-        }
++    private fun getJavaSourceRoots(): HashSet<File> = getSource()","May be `List`?
+",2014-11-11 18:08:20
+254,"@@ -121,17 +164,16 @@ public open class KotlinCompile(): AbstractCompile() {
+         args.noOptimize = kotlinOptions.noOptimize
+         args.noCallAssertions = kotlinOptions.noCallAssertions
+         args.noParamAssertions = kotlinOptions.noParamAssertions
++    }
+ 
+-        val messageCollector = GradleMessageCollector(getLogger())
+-        getLogger().debug(""Calling compiler"")
+-        val exitCode = compiler.exec(messageCollector, Services.EMPTY, args)
+-
+-        when (exitCode) {
+-            ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
+-            ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
+-            else -> {}
+-        }
++    private fun getJavaSourceRoots(): HashSet<File> = getSource()
++            .filter { isJava(it) }
++            .map { findSrcDirRoot(it) }
++            .filter { it != null }","May be replaced with `filterNotNull`
+",2014-11-11 18:07:54
+890,"@@ -122,3 +124,47 @@ class KotlinEnterHandler: EnterHandlerDelegateAdapter() {
+         return false
+     }
+ }
++
++class KotlinConvertToBodyEnterHandler : EnterHandlerDelegateAdapter() {
++    override fun preprocessEnter(file: PsiFile, editor: Editor,
++                                 caretOffset: Ref<Int>, caretAdvance: Ref<Int>, dataContext: DataContext,
++                                 originalHandler: EditorActionHandler?): EnterHandlerDelegate.Result {
++        if (file !is KtFile) return EnterHandlerDelegate.Result.Continue
++        if (!KotlinEditorOptions.getInstance().isEnableSmartConvertToBody) return EnterHandlerDelegate.Result.Continue
++        if (!EnterAfterUnmatchedBraceHandler.isAfterUnmatchedLBrace(editor, caretOffset.get(),
++                                                                    file.fileType)) return EnterHandlerDelegate.Result.Continue
++
++        val document = editor.document
++
++        //Let's check if it's special convert to body case.",This comments doesn't explain anything and can be dropped safely.,2017-07-12 10:02:55
+891,"@@ -122,3 +124,47 @@ class KotlinEnterHandler: EnterHandlerDelegateAdapter() {
+         return false
+     }
+ }
++
++class KotlinConvertToBodyEnterHandler : EnterHandlerDelegateAdapter() {
++    override fun preprocessEnter(file: PsiFile, editor: Editor,
++                                 caretOffset: Ref<Int>, caretAdvance: Ref<Int>, dataContext: DataContext,
++                                 originalHandler: EditorActionHandler?): EnterHandlerDelegate.Result {
++        if (file !is KtFile) return EnterHandlerDelegate.Result.Continue
++        if (!KotlinEditorOptions.getInstance().isEnableSmartConvertToBody) return EnterHandlerDelegate.Result.Continue
++        if (!EnterAfterUnmatchedBraceHandler.isAfterUnmatchedLBrace(editor, caretOffset.get(),
++                                                                    file.fileType)) return EnterHandlerDelegate.Result.Continue
++
++        val document = editor.document
++
++        //Let's check if it's special convert to body case.
++        val prevOffset = caretOffset.get() - 1
++        if (document.isTextAt(prevOffset, ""{"")) {",Please consider inverting `if`.,2017-07-12 10:04:52
+893,"@@ -122,3 +124,47 @@ class KotlinEnterHandler: EnterHandlerDelegateAdapter() {
+         return false
+     }
+ }
++
++class KotlinConvertToBodyEnterHandler : EnterHandlerDelegateAdapter() {
++    override fun preprocessEnter(file: PsiFile, editor: Editor,
++                                 caretOffset: Ref<Int>, caretAdvance: Ref<Int>, dataContext: DataContext,
++                                 originalHandler: EditorActionHandler?): EnterHandlerDelegate.Result {
++        if (file !is KtFile) return EnterHandlerDelegate.Result.Continue
++        if (!KotlinEditorOptions.getInstance().isEnableSmartConvertToBody) return EnterHandlerDelegate.Result.Continue
++        if (!EnterAfterUnmatchedBraceHandler.isAfterUnmatchedLBrace(editor, caretOffset.get(),
++                                                                    file.fileType)) return EnterHandlerDelegate.Result.Continue
++
++        val document = editor.document
++
++        //Let's check if it's special convert to body case.
++        val prevOffset = caretOffset.get() - 1
++        if (document.isTextAt(prevOffset, ""{"")) {
++            document.commit(file.project)
++            val element = file.findElementAt(prevOffset)
++            if (element != null && element.matchParents(
++                    KtFunctionLiteral::class.java,
++                    KtLambdaExpression::class.java,
++                    KtDeclarationWithBody::class.java
++            )) {
++                val declaration = element.parent.parent.parent as KtDeclarationWithBody
++                if (!declaration.hasDeclaredReturnType()) return EnterHandlerDelegate.Result.Continue",I think this restriction leaves the majority of use-cases out of scope. Can we overcome it? I'm not sure it all worth it without the solution.,2017-07-12 10:43:03
+894,"@@ -122,3 +124,47 @@ class KotlinEnterHandler: EnterHandlerDelegateAdapter() {
+         return false
+     }
+ }
++
++class KotlinConvertToBodyEnterHandler : EnterHandlerDelegateAdapter() {
++    override fun preprocessEnter(file: PsiFile, editor: Editor,
++                                 caretOffset: Ref<Int>, caretAdvance: Ref<Int>, dataContext: DataContext,
++                                 originalHandler: EditorActionHandler?): EnterHandlerDelegate.Result {
++        if (file !is KtFile) return EnterHandlerDelegate.Result.Continue
++        if (!KotlinEditorOptions.getInstance().isEnableSmartConvertToBody) return EnterHandlerDelegate.Result.Continue
++        if (!EnterAfterUnmatchedBraceHandler.isAfterUnmatchedLBrace(editor, caretOffset.get(),
++                                                                    file.fileType)) return EnterHandlerDelegate.Result.Continue
++
++        val document = editor.document
++
++        //Let's check if it's special convert to body case.
++        val prevOffset = caretOffset.get() - 1
++        if (document.isTextAt(prevOffset, ""{"")) {
++            document.commit(file.project)
++            val element = file.findElementAt(prevOffset)
++            if (element != null && element.matchParents(
++                    KtFunctionLiteral::class.java,
++                    KtLambdaExpression::class.java,
++                    KtDeclarationWithBody::class.java
++            )) {
++                val declaration = element.parent.parent.parent as KtDeclarationWithBody
++                if (!declaration.hasDeclaredReturnType()) return EnterHandlerDelegate.Result.Continue
++                val equals = declaration.equalsToken
++                if (equals != null) {
++                    val startOffset =",Will it work with comments? Maybe it would be better to check for '=' and extend it with spaces from left and right.,2017-07-12 10:44:30
+850,"@@ -124,21 +128,71 @@ class ConvertTwoComparisonsToRangeCheckIntention : SelfTargetingOffsetIndependen
+         // To avoid possible side effects
+         if (!min.isSimple() || !max.isSimple()) return null
+ 
++        val valContext = value.analyze()",You don't need to call `analyze()` multiple times; calling it once will return a `BindingContext` with information about all the expressions.,2017-05-08 13:06:34
+851,"@@ -124,21 +128,71 @@ class ConvertTwoComparisonsToRangeCheckIntention : SelfTargetingOffsetIndependen
+         // To avoid possible side effects
+         if (!min.isSimple() || !max.isSimple()) return null
+ 
++        val valContext = value.analyze()
++        val minContext = min.analyze()
++        val maxContext = max.analyze()
++        val valType = value.getType(valContext)
++        val minType = min.getType(minContext)
++        val maxType = max.getType(maxContext)
++
++        if (valType == null || minType == null || maxType == null) return null
++
++        if (!valType.isComparable()) return null
++
++        var minVal = min
++        var maxVal = max
++
++        if (minType != valType || maxType != valType) {
++            //numbers can be compared to numbers of different types
++            if (valType.isPrimitiveNumberType() && minType.isPrimitiveNumberType() && maxType.isPrimitiveNumberType()) {
++                //char is comparable to chars only
++                if (KotlinBuiltIns.isChar(valType) || KotlinBuiltIns.isChar(minType) || KotlinBuiltIns.isChar(maxType)) return null
++
++                if (valType.isFloatingPoint()) {
++                    if (minType.isInteger())
++                        minVal = KtPsiFactory(minVal).createExpression(getDoubleConstant(min, minType, minContext) ?: return null)
++                    if (maxType.isInteger())
++                        maxVal = KtPsiFactory(maxVal).createExpression(getDoubleConstant(max, maxType, maxContext) ?: return null)
++                }
++            } else {
++                return null
++            }
++        }
++
+         if (incrementMinByOne || decrementMaxByOne) {
+-            if (!value.getType(value.analyze()).isValidTypeForIncrementDecrementByOne()) return null
++            if (!valType.isValidTypeForIncrementDecrementByOne()) return null
+         }
+ 
+-        val minText = if (incrementMinByOne) min.getChangeBy(1) else min.text
+-        val maxText = if (decrementMaxByOne) max.getChangeBy(-1) else max.text
++        val minText = if (incrementMinByOne) minVal.getChangeBy(1) else minVal.text
++        val maxText = if (decrementMaxByOne) maxVal.getChangeBy(-1) else maxVal.text
+         return RangeExpressionData(value, minText ?: return null, maxText ?: return null)
+     }
+ 
+-    private fun KotlinType?.isValidTypeForIncrementDecrementByOne(): Boolean {
+-        this ?: return false
++    private fun getDoubleConstant(intExpr: KtExpression, type: KotlinType, context: BindingContext): String? {
++        val intConst = ConstantExpressionEvaluator.getConstant(intExpr, context)?.getValue(type) ?: return null
++        return (intConst as? Number)?.toDouble()?.toString()
++    }
++
++    private fun KotlinType.isComparable(): Boolean {","`DescriptorUtils.isSubtypeOfClass(this, expression.builtIns.getComparable())`",2017-05-08 13:09:47
+325,"@@ -126,32 +254,100 @@ public trait MutableSet<E> : Set<E>, MutableCollection<E> {
+     override fun clear(): Unit
+ }
+ 
++/**
++ * A collection that holds pairs of objects (keys and values) and supports efficiently retrieving
++ * the value corresponding to each key. Map keys are unique; the map holds only one value for each key.
++ * Methods in this trait support only read-only access to the map; read-write access is supported through
++ * the [MutableMap] trait.
++ */
+ public trait Map<K, out V> {
+     // Query Operations
++    /**
++     * Returns the size of the map.
++     */","size is a little bit unclear, may be ""number of key-value"" pairs? 
+",2015-03-02 17:30:23
+326,"@@ -126,32 +254,100 @@ public trait MutableSet<E> : Set<E>, MutableCollection<E> {
+     override fun clear(): Unit
+ }
+ 
++/**
++ * A collection that holds pairs of objects (keys and values) and supports efficiently retrieving
++ * the value corresponding to each key. Map keys are unique; the map holds only one value for each key.
++ * Methods in this trait support only read-only access to the map; read-write access is supported through
++ * the [MutableMap] trait.
++ */
+ public trait Map<K, out V> {
+     // Query Operations
++    /**
++     * Returns the size of the map.
++     */
+     public fun size(): Int
++
++    /**
++     * Returns `true` if the map is empty (contains no elements), `false` otherwise.
++     */
+     public fun isEmpty(): Boolean
++
++    /**
++     * Returns `true` if the map contains the specified [key].
++     */
+     public fun containsKey(key: Any?): Boolean
++
++    /**
++     * Returns `true` if the map maps one or more keys to the specified [value].
++     */
+     public fun containsValue(value: Any?): Boolean
++
++    /**
++     * Returns the value corresponding to the given [key], or `null` if such a key is not present in the map.
++     */
+     public fun get(key: Any?): V?
+ 
+     // Views
++    /**
++     * Returns a [Set] of all keys in this map.
++     */
+     public fun keySet(): Set<K>
++
++    /**
++     * Returns a [Collection] of all values in this map.
++     */
+     public fun values(): Collection<V>","May contain duplicate values
+",2015-03-02 17:31:59
+470,"@@ -128,36 +128,71 @@ private static String execCompiler(
+ 
+             String[] argsArray = ArrayUtil.toStringArray(argumentsList);
+ 
+-            // trying the daemon first
+-            if (incrementalCaches != null && RmiPackage.isDaemonEnabled()) {
+-                File libPath = CompilerRunnerUtil.getLibPath(environment.getKotlinPaths(), messageCollector);
+-                // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
+-                //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
+-                CompilerId compilerId = CompilerId.makeCompilerId(new File(libPath, ""kotlin-compiler.jar""));
+-                DaemonOptions daemonOptions = RmiPackage.configureDaemonOptions();
+-                DaemonJVMOptions daemonJVMOptions = RmiPackage.configureDaemonLaunchingOptions(true);
+-                // TODO: find proper stream to report daemon connection progress
+-                CompileService daemon = KotlinCompilerClient.Companion.connectToCompileService(compilerId, daemonJVMOptions, daemonOptions, System.out, true, true);
+-                if (daemon != null) {
+-                    Integer res = KotlinCompilerClient.Companion.incrementalCompile(daemon, argsArray, incrementalCaches, out);
+-                    return res.toString();
+-                }
+-            }
++            if (!tryCompileWithDaemon(messageCollector, collector, environment, incrementalCaches, argsArray)) {
++                // otherwise fallback to in-process
+ 
+-            // otherwise fallback to in-process
++                ByteArrayOutputStream stream = new ByteArrayOutputStream();
++                PrintStream out = new PrintStream(stream);
+ 
+-            Object rc = CompilerRunnerUtil.invokeExecMethod(
+-                    compilerClassName, argsArray, environment, messageCollector, out
+-            );
++                Object rc = CompilerRunnerUtil.invokeExecMethod( compilerClassName, argsArray, environment, messageCollector, out);
+ 
+-            // exec() returns an ExitCode object, class of which is loaded with a different class loader,
+-            // so we take it's contents through reflection
+-            return getReturnCodeFromObject(rc);
++                // exec() returns an ExitCode object, class of which is loaded with a different class loader,
++                // so we take it's contents through reflection
++                ProcessCompilerOutput(messageCollector, collector, stream, getReturnCodeFromObject(rc));
++            }
+         }
+         catch (Throwable e) {
+             MessageCollectorUtil.reportException(messageCollector, e);
+-            return INTERNAL_ERROR;
++            reportInternalCompilerError(messageCollector);
++        }
++    }
++
++    private static boolean tryCompileWithDaemon(
++            MessageCollector messageCollector,
++            OutputItemsCollector collector,
++            CompilerEnvironment environment,
++            Map<String, IncrementalCache> incrementalCaches,
++            String[] argsArray
++    ) throws IOException {
++        if (incrementalCaches != null && RmiPackage.isDaemonEnabled()) {
++            File libPath = CompilerRunnerUtil.getLibPath(environment.getKotlinPaths(), messageCollector);
++            // TODO: it may be a good idea to cache the compilerId, since making it means calculating digest over jar(s) and if \\
++            //    the lifetime of JPS process is small anyway, we can neglect the probability of changed compiler
++            CompilerId compilerId = CompilerId.makeCompilerId(new File(libPath, ""kotlin-compiler.jar""));
++            DaemonOptions daemonOptions = RmiPackage.configureDaemonOptions();
++            DaemonJVMOptions daemonJVMOptions = RmiPackage.configureDaemonJVMOptions(true);
++
++            ArrayList<DaemonReportMessage> daemonReportMessages = new ArrayList<DaemonReportMessage>();
++
++            CompileService daemon = KotlinCompilerClient.connectToCompileService(compilerId, daemonJVMOptions, daemonOptions, new DaemonReportingTargets(null, daemonReportMessages), true, true);
++
++            for (DaemonReportMessage msg: daemonReportMessages) {
++                if (msg.getCategory() == DaemonReportCategory.EXCEPTION && daemon == null) {
++                    messageCollector.report(CompilerMessageSeverity.INFO,
++                                            ""Falling  back to compilation without daemon due to error: "" + msg.getMessage(),
++                                            CompilerMessageLocation.NO_LOCATION);
++                }
++                else {
++                    messageCollector.report(CompilerMessageSeverity.INFO, msg.getMessage(), CompilerMessageLocation.NO_LOCATION);
++                }
++            }
++
++            if (daemon != null) {
++                ByteArrayOutputStream compilerOut = new ByteArrayOutputStream();
++                ByteArrayOutputStream daemonOut = new ByteArrayOutputStream();
++
++                Integer res = KotlinCompilerClient.incrementalCompile(daemon, argsArray, incrementalCaches, compilerOut, daemonOut);
++
++                ProcessCompilerOutput(messageCollector, collector, compilerOut, res.toString());
++                BufferedReader reader = new BufferedReader(new StringReader(daemonOut.toString()));","will we see non-latin characters? it could be significant for error messages with path to files, for example
+",2015-09-08 18:24:39
+318,"@@ -13,39 +13,45 @@ public fun InputStream.iterator(): ByteIterator =
+             public override fun nextByte(): Byte = read().toByte()
+         }
+ 
+-/** Creates a buffered input stream */
++/**
++ * Creates a buffered input stream wrapping this stream.
++ * @param bufferSize the buffer size to use.
++ */
+ public fun InputStream.buffered(bufferSize: Int = defaultBufferSize): InputStream
+         = if (this is BufferedInputStream)
+     this
+ else
+     BufferedInputStream(this, bufferSize)
+ 
+-/** Creates a reader on an input stream using UTF-8 or specified charset. */
++/** Creates a reader on this input stream using UTF-8 or the specified [charset]. */","Need to put it in conventions, wording around documenting parameter with default value.
+",2015-02-11 08:38:03
+534,"@@ -13,79 +13,96 @@ class ParsePrimitivesJVMTest {
+     }
+ 
+     @test fun toByte() {
+-        assertEqualsOrFailsNullable(77.toByte(), ""+77"", String::toByte, String::toByteOrNull)
+-        assertEqualsOrFailsNullable(Byte.MIN_VALUE, ""-128"", String::toByte, String::toByteOrNull)
+-        assertEqualsOrFailsNullable(null, ""128"", String::toByte, String::toByteOrNull)
++        CompareBehaviourContext(String::toByte, String::toByteOrNull).apply {
++
++            assertProduce(77.toByte(), ""+77"")
++            assertProduce(Byte.MIN_VALUE, ""-128"")
++            assertProduce(null, ""128"")
++        }
+     }
+ 
+     @test fun toShort() {
+-        assertEqualsOrFailsNullable(77.toShort(), ""77"", String::toShort, String::toShortOrNull)
+-        assertEqualsOrFailsNullable(Short.MIN_VALUE, ""-32768"", String::toShort, String::toShortOrNull)
+-        assertEqualsOrFailsNullable(null, ""+32768"", String::toShort, String::toShortOrNull)
++        CompareBehaviourContext(String::toShort, String::toShortOrNull).apply {
++
++            assertProduce(77.toShort(), ""77"")
++            assertProduce(Short.MIN_VALUE, ""-32768"")
++            assertProduce(null, ""+32768"")
++        }
+     }
+ 
+     @test fun toInt() {
+-        assertEqualsOrFailsNullable(77, ""77"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(Int.MAX_VALUE, ""+2147483647"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(Int.MIN_VALUE, ""-2147483648"", String::toInt, String::toIntOrNull)
++        CompareBehaviourContext(String::toInt, String::toIntOrNull).apply {
++
++            assertProduce(77, ""77"")
++            assertProduce(Int.MAX_VALUE, ""+2147483647"")
++            assertProduce(Int.MIN_VALUE, ""-2147483648"")
+ 
+-        assertEqualsOrFailsNullable(null, ""2147483648"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(null, ""-2147483649"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(null, ""239239kotlin"", String::toInt, String::toIntOrNull)
++            assertProduce(null, ""2147483648"")
++            assertProduce(null, ""-2147483649"")
++            assertProduce(null, ""239239kotlin"")
++        }
+     }
+ 
+     @test fun toLong() {
+-        assertEqualsOrFailsNullable(77.toLong(), ""77"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(Long.MAX_VALUE, ""+9223372036854775807"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(Long.MIN_VALUE, ""-9223372036854775808"", String::toLong, String::toLongOrNull)
+-
+-        assertEqualsOrFailsNullable(null, ""9223372036854775808"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""-9223372036854775809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""922337 75809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""92233,75809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""92233`75809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""-922337KOTLIN775809"", String::toLong, String::toLongOrNull)
++        CompareBehaviourContext(String::toLong, String::toLongOrNull).apply {
++
++            assertProduce(77.toLong(), ""77"")
++            assertProduce(Long.MAX_VALUE, ""+9223372036854775807"")
++            assertProduce(Long.MIN_VALUE, ""-9223372036854775808"")
++
++            assertProduce(null, ""9223372036854775808"")
++            assertProduce(null, ""-9223372036854775809"")
++            assertProduce(null, ""922337 75809"")
++            assertProduce(null, ""92233,75809"")
++            assertProduce(null, ""92233`75809"")
++            assertProduce(null, ""-922337KOTLIN775809"")
++        }
+     }
+ 
+     @test fun toFloat() {
+-        assertEqualsOrFailsNullable(77.0f, ""77.0"", String::toFloat, String::toFloatOrNull)
+-        assertEqualsOrFailsNullable(Float.NEGATIVE_INFINITY, ""-1e39"", String::toFloat, String::toFloatOrNull)
+-        assertEqualsOrFailsNullable(Float.POSITIVE_INFINITY, ""1000000000000000000000000000000000000000"",
+-                String::toFloat, String::toFloatOrNull)
++        CompareBehaviourContext(String::toFloat, String::toFloatOrNull).apply {
+ 
+-        assertEqualsOrFailsNullable(null, ""dark side"", String::toFloat, String::toFloatOrNull)
++            assertProduce(77.0f, ""77.0"")
++            assertProduce(Float.NEGATIVE_INFINITY, ""-1e39"")
++            assertProduce(Float.POSITIVE_INFINITY, ""1000000000000000000000000000000000000000"")
++            assertProduce(null, ""dark side"")
++        }
+     }
+ 
+     @test fun toDouble() {
+-        assertEqualsOrFailsNullable(-77.0, ""-77"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""77."", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""77.0"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(-1.77, ""-1.77"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(0.77, ""+.77"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(-77.0, ""\t-77 \n"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""7.7e1"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""+770e-1"", String::toDouble, String::toDoubleOrNull)
+-
+-        assertEqualsOrFailsNullable(-Double.NaN, ""-NaN"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(Double.POSITIVE_INFINITY, ""+Infinity"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable((0x77 shl 1).toDouble(), ""0x77p1"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(0x77.toDouble(), ""0x.77P8"", String::toDouble, String::toDoubleOrNull)
+-
+-        assertEqualsOrFailsNullable(null, ""7..7"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(null, ""0x77e1"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(null, ""007 not a number"", String::toDouble, String::toDoubleOrNull)
++        CompareBehaviourContext(String::toDouble, String::toDoubleOrNull).apply {
++
++            assertProduce(-77.0, ""-77"")
++            assertProduce(77.0, ""77."")
++            assertProduce(77.0, ""77.0"")
++            assertProduce(-1.77, ""-1.77"")
++            assertProduce(0.77, ""+.77"")
++            assertProduce(-77.0, ""\t-77 \n"")
++            assertProduce(77.0, ""7.7e1"")
++            assertProduce(77.0, ""+770e-1"")
++
++            assertProduce(-Double.NaN, ""-NaN"")
++            assertProduce(Double.POSITIVE_INFINITY, ""+Infinity"")
++            assertProduce((0x77 shl 1).toDouble(), ""0x77p1"")
++            assertProduce(0x77.toDouble(), ""0x.77P8"")
++
++            assertProduce(null, ""7..7"")
++            assertProduce(null, ""0x77e1"")
++            assertProduce(null, ""007 not a number"")
++        }
+     }
+ }
+ 
+-private inline fun <T: Any> assertEqualsOrFailsNullable(output: T?,
+-                                                        input: String,
+-                                                        crossinline converOrFail: (String) -> T,
+-                                                        crossinline convertOrNull: (String) -> T?) {
+-    if(output == null) {
+-        assertFails { converOrFail(input) }
+-        assertNull (convertOrNull(input) )
+-    } else {
+-        assertEquals(output, converOrFail(input))
+-        assertEquals(output, convertOrNull(input))
++
++private class CompareBehaviourContext<T: Any>(val convertOrFail: (String) -> T,","`Behaviour` we prefer American English in identifiers :)
+",2016-03-30 18:24:39
+533,"@@ -13,79 +13,96 @@ class ParsePrimitivesJVMTest {
+     }
+ 
+     @test fun toByte() {
+-        assertEqualsOrFailsNullable(77.toByte(), ""+77"", String::toByte, String::toByteOrNull)
+-        assertEqualsOrFailsNullable(Byte.MIN_VALUE, ""-128"", String::toByte, String::toByteOrNull)
+-        assertEqualsOrFailsNullable(null, ""128"", String::toByte, String::toByteOrNull)
++        CompareBehaviourContext(String::toByte, String::toByteOrNull).apply {
++
++            assertProduce(77.toByte(), ""+77"")
++            assertProduce(Byte.MIN_VALUE, ""-128"")
++            assertProduce(null, ""128"")
++        }
+     }
+ 
+     @test fun toShort() {
+-        assertEqualsOrFailsNullable(77.toShort(), ""77"", String::toShort, String::toShortOrNull)
+-        assertEqualsOrFailsNullable(Short.MIN_VALUE, ""-32768"", String::toShort, String::toShortOrNull)
+-        assertEqualsOrFailsNullable(null, ""+32768"", String::toShort, String::toShortOrNull)
++        CompareBehaviourContext(String::toShort, String::toShortOrNull).apply {
++
++            assertProduce(77.toShort(), ""77"")
++            assertProduce(Short.MIN_VALUE, ""-32768"")
++            assertProduce(null, ""+32768"")
++        }
+     }
+ 
+     @test fun toInt() {
+-        assertEqualsOrFailsNullable(77, ""77"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(Int.MAX_VALUE, ""+2147483647"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(Int.MIN_VALUE, ""-2147483648"", String::toInt, String::toIntOrNull)
++        CompareBehaviourContext(String::toInt, String::toIntOrNull).apply {
++
++            assertProduce(77, ""77"")
++            assertProduce(Int.MAX_VALUE, ""+2147483647"")
++            assertProduce(Int.MIN_VALUE, ""-2147483648"")
+ 
+-        assertEqualsOrFailsNullable(null, ""2147483648"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(null, ""-2147483649"", String::toInt, String::toIntOrNull)
+-        assertEqualsOrFailsNullable(null, ""239239kotlin"", String::toInt, String::toIntOrNull)
++            assertProduce(null, ""2147483648"")
++            assertProduce(null, ""-2147483649"")
++            assertProduce(null, ""239239kotlin"")
++        }
+     }
+ 
+     @test fun toLong() {
+-        assertEqualsOrFailsNullable(77.toLong(), ""77"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(Long.MAX_VALUE, ""+9223372036854775807"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(Long.MIN_VALUE, ""-9223372036854775808"", String::toLong, String::toLongOrNull)
+-
+-        assertEqualsOrFailsNullable(null, ""9223372036854775808"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""-9223372036854775809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""922337 75809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""92233,75809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""92233`75809"", String::toLong, String::toLongOrNull)
+-        assertEqualsOrFailsNullable(null, ""-922337KOTLIN775809"", String::toLong, String::toLongOrNull)
++        CompareBehaviourContext(String::toLong, String::toLongOrNull).apply {
++
++            assertProduce(77.toLong(), ""77"")
++            assertProduce(Long.MAX_VALUE, ""+9223372036854775807"")
++            assertProduce(Long.MIN_VALUE, ""-9223372036854775808"")
++
++            assertProduce(null, ""9223372036854775808"")
++            assertProduce(null, ""-9223372036854775809"")
++            assertProduce(null, ""922337 75809"")
++            assertProduce(null, ""92233,75809"")
++            assertProduce(null, ""92233`75809"")
++            assertProduce(null, ""-922337KOTLIN775809"")
++        }
+     }
+ 
+     @test fun toFloat() {
+-        assertEqualsOrFailsNullable(77.0f, ""77.0"", String::toFloat, String::toFloatOrNull)
+-        assertEqualsOrFailsNullable(Float.NEGATIVE_INFINITY, ""-1e39"", String::toFloat, String::toFloatOrNull)
+-        assertEqualsOrFailsNullable(Float.POSITIVE_INFINITY, ""1000000000000000000000000000000000000000"",
+-                String::toFloat, String::toFloatOrNull)
++        CompareBehaviourContext(String::toFloat, String::toFloatOrNull).apply {
+ 
+-        assertEqualsOrFailsNullable(null, ""dark side"", String::toFloat, String::toFloatOrNull)
++            assertProduce(77.0f, ""77.0"")
++            assertProduce(Float.NEGATIVE_INFINITY, ""-1e39"")
++            assertProduce(Float.POSITIVE_INFINITY, ""1000000000000000000000000000000000000000"")
++            assertProduce(null, ""dark side"")
++        }
+     }
+ 
+     @test fun toDouble() {
+-        assertEqualsOrFailsNullable(-77.0, ""-77"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""77."", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""77.0"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(-1.77, ""-1.77"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(0.77, ""+.77"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(-77.0, ""\t-77 \n"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""7.7e1"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(77.0, ""+770e-1"", String::toDouble, String::toDoubleOrNull)
+-
+-        assertEqualsOrFailsNullable(-Double.NaN, ""-NaN"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(Double.POSITIVE_INFINITY, ""+Infinity"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable((0x77 shl 1).toDouble(), ""0x77p1"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(0x77.toDouble(), ""0x.77P8"", String::toDouble, String::toDoubleOrNull)
+-
+-        assertEqualsOrFailsNullable(null, ""7..7"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(null, ""0x77e1"", String::toDouble, String::toDoubleOrNull)
+-        assertEqualsOrFailsNullable(null, ""007 not a number"", String::toDouble, String::toDoubleOrNull)
++        CompareBehaviourContext(String::toDouble, String::toDoubleOrNull).apply {
++
++            assertProduce(-77.0, ""-77"")
++            assertProduce(77.0, ""77."")
++            assertProduce(77.0, ""77.0"")
++            assertProduce(-1.77, ""-1.77"")
++            assertProduce(0.77, ""+.77"")
++            assertProduce(-77.0, ""\t-77 \n"")
++            assertProduce(77.0, ""7.7e1"")
++            assertProduce(77.0, ""+770e-1"")
++
++            assertProduce(-Double.NaN, ""-NaN"")
++            assertProduce(Double.POSITIVE_INFINITY, ""+Infinity"")
++            assertProduce((0x77 shl 1).toDouble(), ""0x77p1"")
++            assertProduce(0x77.toDouble(), ""0x.77P8"")
++
++            assertProduce(null, ""7..7"")
++            assertProduce(null, ""0x77e1"")
++            assertProduce(null, ""007 not a number"")
++        }
+     }
+ }
+ 
+-private inline fun <T: Any> assertEqualsOrFailsNullable(output: T?,
+-                                                        input: String,
+-                                                        crossinline converOrFail: (String) -> T,
+-                                                        crossinline convertOrNull: (String) -> T?) {
+-    if(output == null) {
+-        assertFails { converOrFail(input) }
+-        assertNull (convertOrNull(input) )
+-    } else {
+-        assertEquals(output, converOrFail(input))
+-        assertEquals(output, convertOrNull(input))
++
++private class CompareBehaviourContext<T: Any>(val convertOrFail: (String) -> T,
++                                              val convertOrNull: (String) -> T?) {
++    fun assertProduce(output: T?, input: String) {
++        if(output == null) {
++            assertFails { convertOrFail(input) }","Please specify input string in the detail message, i.e. something like ""Expected to fail (or return null) on $input""
+",2016-03-30 18:17:46
+295,"@@ -13,8 +13,8 @@ private enum class State {
+ }
+ 
+ /**
+- * A base class to simplify implementing iterators so that implementations only have to implement [[computeNext()]]
+- * to implement the iterator, calling [[done()]] when the iteration is complete.
++ * A base class to simplify implementing iterators so that implementations only have to implement [computeNext]","Warning, using this class has performance penalty compared to plain raw implementation per case, measured with JMH when operation per element is relatively cheap.
+",2015-02-09 15:56:52
+676,"@@ -132,50 +132,34 @@ public inline fun println() {
+     System.out.println()
+ }
+ 
+-// Since System.in can change its value on the course of program running,
+-// we should always delegate to current value and cannot just pass it to InputStreamReader constructor.
+-// We could use ""by"" implementation, but we can only use ""by"" with interfaces and InputStream is abstract class.
+-private val stdin: BufferedReader by lazy { BufferedReader(InputStreamReader(object : InputStream() {
+-    public override fun read(): Int {
+-        return System.`in`.read()
+-    }
+-
+-    public override fun reset() {
+-        System.`in`.reset()
+-    }
+-
+-    public override fun read(b: ByteArray): Int {
+-        return System.`in`.read(b)
+-    }
+-
+-    public override fun close() {
+-        System.`in`.close()
+-    }
+-
+-    public override fun mark(readlimit: Int) {
+-        System.`in`.mark(readlimit)
+-    }
+-
+-    public override fun skip(n: Long): Long {
+-        return System.`in`.skip(n)
+-    }
+-
+-    public override fun available(): Int {
+-        return System.`in`.available()
+-    }
+-
+-    public override fun markSupported(): Boolean {
+-        return System.`in`.markSupported()
+-    }
+-
+-    public override fun read(b: ByteArray, off: Int, len: Int): Int {
+-        return System.`in`.read(b, off, len)
+-    }
+-}))}
+-
+ /**
+  * Reads a line of input from the standard input stream.
+  *
+  * @return the line read or `null` if the input stream is redirected to a file and the end of file has been reached.
+  */
+-public fun readLine(): String? = stdin.readLine()
++
++public fun readLine(): String? {
++    val buffer = StringBuilder()
++    var c = System.`in`.read()
++    if(c < 0) return null
++    buffer.append(c.toChar())
++    do {
++        c = System.`in`.read()
++        if(c < 0) return buffer.toString()
++        val ch = c.toChar()","Unfortunately, this will work only for US-ASCII encoding. ",2016-12-29 23:07:06
+50,"@@ -132,7 +132,10 @@ map.platform.class.to.kotlin=Change all usages of ''{0}'' in this file to ''{1}'
+ map.platform.class.to.kotlin.multiple=Change all usages of ''{0}'' in this file to a Kotlin class
+ map.platform.class.to.kotlin.advertisement=Choose an appropriate Kotlin class
+ map.platform.class.to.kotlin.family=Change to Kotlin class
+-
++create.from.usage.family=Create from usage
++create.method.from.usage=Create method ''{0}'' from usage","In Kotlin, we call them functions, not methods. Please, rename it here and in other code.
+",2013-04-26 11:10:47
+513,"@@ -132,8 +132,13 @@ class AndroidGradleWrapper {
+               && variantData.scope.getRenderscriptCompileTask() != null) {
+         result.add(variantData.scope.getRenderscriptSourceOutputDir());
+       }
++    }
+ 
+-      return result
++    def getExtraSourcesMethod = variantData.getMetaClass().getMetaMethod(""getExtraGeneratedSourceFolders"")
++    if (getExtraSourcesMethod.returnType.metaClass == List.metaClass) {
++      result.addAll(variantData.getExtraGeneratedSourceFolders())","variantData.getExtraGeneratedSourceFolders() is Nullable, so you should check for null, before calling addAll
+",2016-02-12 08:47:33
+591,"@@ -133,15 +138,32 @@ public void execute() throws MojoExecutionException, MojoFailureException {
+         configureCompilerArguments(arguments, compiler);
+         printCompilerArgumentsIfDebugEnabled(arguments, compiler);
+ 
+-        MessageCollector messageCollector = new MavenPluginLogMessageCollector(getLog());
++        MavenPluginLogMessageCollector messageCollector = new MavenPluginLogMessageCollector(getLog(), true);
+ 
+         ExitCode exitCode = compiler.exec(messageCollector, Services.EMPTY, arguments);
+ 
+         switch (exitCode) {
+             case COMPILATION_ERROR:
+-                throw new MojoExecutionException(""Compilation error. See log for more details"");
+             case INTERNAL_ERROR:
+-                throw new MojoExecutionException(""Internal compiler error. See log for more details"");
++                throw new KotlinCompilationFailureException(
++                        CollectionsKt.map(messageCollector.getCollectedErrors(), new Function1<Pair<CompilerMessageLocation, String>, CompilerMessage>() {","Isn't compiler exception logged as error?
+",2016-08-10 11:22:25
+590,"@@ -133,15 +138,32 @@ public void execute() throws MojoExecutionException, MojoFailureException {
+         configureCompilerArguments(arguments, compiler);
+         printCompilerArgumentsIfDebugEnabled(arguments, compiler);
+ 
+-        MessageCollector messageCollector = new MavenPluginLogMessageCollector(getLog());
++        MavenPluginLogMessageCollector messageCollector = new MavenPluginLogMessageCollector(getLog(), true);
+ 
+         ExitCode exitCode = compiler.exec(messageCollector, Services.EMPTY, arguments);
+ 
+         switch (exitCode) {
+             case COMPILATION_ERROR:
+-                throw new MojoExecutionException(""Compilation error. See log for more details"");
+             case INTERNAL_ERROR:
+-                throw new MojoExecutionException(""Internal compiler error. See log for more details"");
++                throw new KotlinCompilationFailureException(
++                        CollectionsKt.map(messageCollector.getCollectedErrors(), new Function1<Pair<CompilerMessageLocation, String>, CompilerMessage>() {
++                            @Override
++                            public CompilerMessage invoke(Pair<CompilerMessageLocation, String> pair) {
++                                String lineContent = pair.getFirst().getLineContent();
++                                int lineContentLength = lineContent == null ? 0 : lineContent.length();
++
++                                return new CompilerMessage(
++                                        pair.getFirst().getPath(),
++                                        CompilerMessage.Kind.ERROR,
++                                        pair.getFirst().getLine(),","Are they zero-based in `CompilerMessageLocation` ?
+",2016-08-10 11:18:37
+592,"@@ -133,16 +137,32 @@ public void execute() throws MojoExecutionException, MojoFailureException {
+         configureCompilerArguments(arguments, compiler);
+         printCompilerArgumentsIfDebugEnabled(arguments, compiler);
+ 
+-        MessageCollector messageCollector = new MavenPluginLogMessageCollector(getLog());
++        MavenPluginLogMessageCollector messageCollector = new MavenPluginLogMessageCollector(getLog());
+ 
+         ExitCode exitCode = compiler.exec(messageCollector, Services.EMPTY, arguments);
+ 
+-        switch (exitCode) {
+-            case COMPILATION_ERROR:
+-                throw new MojoExecutionException(""Compilation error. See log for more details"");
+-            case INTERNAL_ERROR:
+-                throw new MojoExecutionException(""Internal compiler error. See log for more details"");
+-            default:
++        if (exitCode != ExitCode.OK) {
++            throw new KotlinCompilationFailureException(
++                    CollectionsKt.map(messageCollector.getCollectedErrors(), new Function1<Pair<CompilerMessageLocation, String>, CompilerMessage>() {
++                        @Override
++                        public CompilerMessage invoke(Pair<CompilerMessageLocation, String> pair) {
++                            CompilerMessageLocation location = pair.getFirst();
++                            String message = pair.getSecond();
++                            String lineContent = location.getLineContent();
++                            int lineContentLength = lineContent == null ? 0 : lineContent.length();
++
++                            return new CompilerMessage(
++                                    location.getPath(),
++                                    CompilerMessage.Kind.ERROR,","yes, but in this case it looks not so clear that there is -1 and 0 with special meaning
+",2016-08-10 14:35:44
+9,"@@ -133,8 +133,12 @@ private QuickFixes() {}
+         actions.put(VAL_WITH_SETTER, changeVariableMutabilityFix);
+         actions.put(VAL_REASSIGNMENT, changeVariableMutabilityFix);
+ 
+-        actions.put(UNNECESSARY_SAFE_CALL, new ReplaceCallFix(false));
+-        actions.put(UNSAFE_CALL, new ReplaceCallFix(true));
++        actions.put(UNNECESSARY_SAFE_CALL, new ReplaceCallFix(true, false));
++        actions.put(UNSAFE_CALL, new ReplaceCallFix(true, true));
++        actions.put(UNSAFE_CALL, new ReplaceCallFix(false, true));","Two booleans in parameters almost always look bad because it's difficult to read such code. It's better to provide static constructors like ReplaceCallFix.toDotCall(), ReplaceCallFix.toQuestionMarkCall(), ReplaceCallFix.toExclamationCall(). Another alternative is to create and pass as parameter some enumeration.
+",2012-06-19 14:50:21
+11,"@@ -133,8 +133,14 @@ private QuickFixes() {}
+         actions.put(VAL_WITH_SETTER, changeVariableMutabilityFix);
+         actions.put(VAL_REASSIGNMENT, changeVariableMutabilityFix);
+ 
+-        actions.put(UNNECESSARY_SAFE_CALL, new ReplaceCallFix(false));
+-        actions.put(UNSAFE_CALL, new ReplaceCallFix(true));
++        actions.put(UNNECESSARY_SAFE_CALL, ReplaceCallFix.toDotCallFromSafeCall());
++        actions.put(UNSAFE_CALL, ReplaceCallFix.toSafeCall());
++
++        actions.put(UNSAFE_CALL, ReplaceCallFix.toNonNullAssertedCall());
++        actions.put(UNNECESSARY_NOT_NULL_ASSERTION, ReplaceCallFix.toDotCallFromNonNullAssertedCall());
++
++        actions.put(UNNECESSARY_NOT_NULL_ASSERTION, new UnnecessaryNotNullAssertionFix());","Both quick fixes are available for this code snippet:
+fun test(value : String) : String {
+  return value!!.toString()
+}
+
+I suggest to forbid one from UnnecessaryNotNullAssertionFix if warning is in the middle of DOT_QUALIFIED_EXPRESSION.
+
+By the way, Sergey, what tools do you use for monitoring PSI tree. I don't remember did I tell you about Tools->View PSI structure of current file?
+",2012-06-26 20:19:10
+912,"@@ -135,4 +136,23 @@ public static KotlinSingleIntentionActionFactory createFactory() {
+             }
+         };
+     }
++
++    public static KotlinSingleIntentionActionFactory createLateInitFactory() {","Please convert this file to Kotlin if you're adding substantial new code to it. (Rename to .kt, commit, then rename back to .java, run J2K, make any changes needed for the project to compile, commit again, then make your changes.)",2017-07-24 12:48:44
+913,"@@ -135,4 +136,23 @@ public static KotlinSingleIntentionActionFactory createFactory() {
+             }
+         };
+     }
++
++    public static KotlinSingleIntentionActionFactory createLateInitFactory() {
++        return new KotlinSingleIntentionActionFactory() {
++            @Override
++            public KotlinQuickFixAction<KtProperty> createAction(@NotNull Diagnostic diagnostic) {
++                PsiElement element = Errors.INAPPLICABLE_LATEINIT_MODIFIER.cast(diagnostic).getPsiElement();
++                KtProperty property = PsiTreeUtil.getParentOfType(element, KtProperty.class);
++                if (property == null) return null;
++
++                boolean hasInitializer = property.hasInitializer();
++                boolean hasGetter = property.getGetter() != null && property.getGetter().getBodyExpression() != null;","The getter and setter checks are not needed. This quickfix should apply to any lateinit property; _late_init means that it's initialized somewhere in the class, and this applies to regular properties with default getters and setters too.",2017-07-24 12:52:05
+666,"@@ -135,7 +135,7 @@ public inline fun println() {
+ // Since System.in can change its value on the course of program running,
+ // we should always delegate to current value and cannot just pass it to InputStreamReader constructor.
+ // We could use ""by"" implementation, but we can only use ""by"" with interfaces and InputStream is abstract class.
+-private val stdin: BufferedReader by lazy { BufferedReader(InputStreamReader(object : InputStream() {
++private val stdin: InputStreamReader by lazy { InputStreamReader(object : InputStream() {","If we're not going to buffer contents, `stdin` wrapper isn't required anymore.",2016-12-28 17:02:10
+780,"@@ -137,6 +137,16 @@
+     )
+     public String[] scriptResolverEnvironment;
+ 
++    // Javac options
++    @Argument(value = ""-Xuse-javac"", description = ""Use Javac analysis"")","Consider something like `""Use javac for analysis of Java source and class files""`",2017-04-25 08:01:54
+320,"@@ -139,29 +140,34 @@ public fun File.readLines(charset: Charset = Charsets.UTF_8): List<String> {
+     return result
+ }
+ 
+-/** Creates a buffered reader, or returns self if Reader is already buffered */
++/** Creates a buffered reader wrapping this Reader, or returns self if Reader is already buffered */","self -> this Reader
+",2015-02-11 08:40:01
+319,"@@ -139,29 +140,34 @@ public fun File.readLines(charset: Charset = Charsets.UTF_8): List<String> {
+     return result
+ }
+ 
+-/** Creates a buffered reader, or returns self if Reader is already buffered */
++/** Creates a buffered reader wrapping this Reader, or returns self if Reader is already buffered */
+ public fun Reader.buffered(bufferSize: Int = defaultBufferSize): BufferedReader
+         = if (this is BufferedReader) this else BufferedReader(this, bufferSize)
+ 
+-/** Creates a buffered writer, or returns self if Writer is already buffered */
++/** Creates a buffered writer wrapping this Writer, or returns self if Writer is already buffered */","self -> this Writer
+",2015-02-11 08:39:52
+355,"@@ -139,4 +139,214 @@ The compiler issues warnings specific to `@Nullable`/`@NotNull` in the following
+  - a `@Nullable` value is assigned to a not-null location (including passing parameters and receivers to functions/properties);
+  - a nullable value is assigned to a `@NotNull` location;
+  - a `@NotNull` value is dereferenced with a safe call (`?.`), used in `!!` or on the left-hand side of an elvis operator `?:`;
+- - a `@NotNull` value is compared with `null` through `==`, `!=`, `===` or `!==`
+\ No newline at end of file
++ - a `@NotNull` value is compared with `null` through `==`, `!=`, `===` or `!==`
++
++## More precise type information from annotations
++
++Goals:
++ - Catch more errors related to nullability in case of Java interop
++ - Keep all class hierarchies consistent at all times (no hierarchy errors related to incorrect annotations)
++ - (!) If the code compiled with annotations, it should always compile without annotations (because external annotations may disappear)
++
++ This process never results in errors. On any mismatch, a bare platform signature is used (and a warning issued).
++
++### Annotations recognized by the compiler
++
++- `org.jetbrains.annotations.Nullable` - value may be null/accepts nulls","Why only the JetBrains versions and not also javax.annotations versions? My own code won't benefit if this is the complete list.
+",2015-03-31 16:20:28
+356,"@@ -139,4 +139,214 @@ The compiler issues warnings specific to `@Nullable`/`@NotNull` in the following
+  - a `@Nullable` value is assigned to a not-null location (including passing parameters and receivers to functions/properties);
+  - a nullable value is assigned to a `@NotNull` location;
+  - a `@NotNull` value is dereferenced with a safe call (`?.`), used in `!!` or on the left-hand side of an elvis operator `?:`;
+- - a `@NotNull` value is compared with `null` through `==`, `!=`, `===` or `!==`
+\ No newline at end of file
++ - a `@NotNull` value is compared with `null` through `==`, `!=`, `===` or `!==`
++
++## More precise type information from annotations
++
++Goals:
++ - Catch more errors related to nullability in case of Java interop
++ - Keep all class hierarchies consistent at all times (no hierarchy errors related to incorrect annotations)
++ - (!) If the code compiled with annotations, it should always compile without annotations (because external annotations may disappear)
++
++ This process never results in errors. On any mismatch, a bare platform signature is used (and a warning issued).
++
++### Annotations recognized by the compiler
++
++- `org.jetbrains.annotations.Nullable` - value may be null/accepts nulls
++- `org.jetbrains.annotations.NotNull` - value can not be null/passing null leads to an exception
++- `org.jetbrains.annotations.ReadOnly` - only non-mutating methods can be used on this collection/iterable/iterator
++- `org.jetbrains.annotations.Mutable` - only non-mutating methods can be used on this collection/iterable/iterator","This description seems duplicated?
+",2015-03-31 16:20:43
+77,"@@ -139,8 +140,8 @@ public boolean isVar() {
+ 
+     @NotNull
+     @Override
+-    public ValueParameterDescriptor copy(@NotNull DeclarationDescriptor newOwner) {
+-        return new ValueParameterDescriptorImpl(newOwner, index, Lists.newArrayList(getAnnotations()), getName(), getType(), hasDefaultValue, varargElementType);
++    public ValueParameterDescriptor copy(@NotNull DeclarationDescriptor newOwner, @NotNull Name newName) {
++        return new ValueParameterDescriptorImpl(newOwner, index, Lists.newArrayList(getAnnotations()), newName, getType(), declaresDefaultValue(), varargElementType);","I have changed `hasDefaultValue` to `declaresDefaultValue()` - I think that is correct (the constructor parameter is named `declaresDefaultValue`). Besides, `hasDefaultValue` is computed lazily in `hasDefaultValue()` and can be `null` resulting in `NullPointerException` (which, in fact, it does).
+",2013-05-27 08:40:03
+322,"@@ -14,48 +14,47 @@ public fun Appendable.appendln(value: CharSequence?): Appendable = append(value)
+ /** Appends value to the given Appendable and line separator after it. */
+ public fun Appendable.appendln(value: Char): Appendable = append(value).append(LINE_SEPARATOR)
+ 
+-/** Appends line separator to StringBuilder. */
+-
++/** Appends a line separator to this StringBuilder. */
+ public fun StringBuilder.appendln(): StringBuilder = append(LINE_SEPARATOR)
+ 
+-/** Appends value to the given StringBuilder and line separator after it. */
++/** Appends value to this StringBuilder and line separator after it. */","backtickify value, linkify StringBuilder
+",2015-02-11 08:44:11
+265,"@@ -14,6 +14,44 @@ public fun File.recurse(block: (File) -> Unit): Unit {
+ }
+ 
+ /**
++ * Create an empty directory in the specified directory, using the given prefix and suffix to generate its name.
++ * Prefix shouldn't be shorter than 3 symbols or IllegalArgumentException will be thrown.
++ *
++ * If prefix is not specified then some unspecified name will be used.
++ * If suffix is not specified then "".tmp"" will be used.
++ * If directory is not specified then the default temporary-file directory will be used.
++ *
++ * Returns a file object corresponding to a newly-created directory.
++ *
++ * If some error occurs then IOException is thrown.
++ */
++public fun createTempDir(prefix: String = ""tmp"", suffix: String? = null, directory: File? = null): File {","I don't really like global functions in stdlib, until absolutely necessary. They pollute global namespace, since they are in the `kotlin` package. Consider creating object to group them into. 
+",2014-11-26 15:00:40
+879,"@@ -14,7 +14,7 @@ fun elements(): List<GenericFunction> {
+         doc { f -> ""Returns `true` if [element] is found in the ${f.collection}."" }
+         typeParam(""@kotlin.internal.OnlyInputTypes T"")
+         returns(""Boolean"")
+-        body(Iterables) { f ->
++        body(Iterables) {","Please extract unrelated changes, such as formatting improvement in a separate PR.",2017-07-03 18:20:49
+380,"@@ -14,88 +14,77 @@ import java.util.Collections // TODO: it's temporary while we have java.util.Col
+  * Returns an ArrayList of all elements
+  */
+ public fun <T> Array<out T>.toArrayList(): ArrayList<T> {
+-    val list = ArrayList<T>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun BooleanArray.toArrayList(): ArrayList<Boolean> {
+-    val list = ArrayList<Boolean>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun ByteArray.toArrayList(): ArrayList<Byte> {
+-    val list = ArrayList<Byte>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun CharArray.toArrayList(): ArrayList<Char> {
+-    val list = ArrayList<Char>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun DoubleArray.toArrayList(): ArrayList<Double> {
+-    val list = ArrayList<Double>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun FloatArray.toArrayList(): ArrayList<Float> {
+-    val list = ArrayList<Float>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun IntArray.toArrayList(): ArrayList<Int> {
+-    val list = ArrayList<Int>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun LongArray.toArrayList(): ArrayList<Long> {
+-    val list = ArrayList<Long>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun ShortArray.toArrayList(): ArrayList<Short> {
+-    val list = ArrayList<Short>(size())
+-    for (item in this) list.add(item)
+-    return list
++    return this.asList().toArrayList()
++}
++
++/**
++ * Returns an ArrayList of all elements
++ */
++public fun <T> Collection<T>.toArrayList(): ArrayList<T> {
++    return ArrayList(this)
+ }
+ 
+ /**
+  * Returns an ArrayList of all elements
+  */
+ public fun <T> Iterable<T>.toArrayList(): ArrayList<T> {
+-    return toCollection(ArrayList<T>(collectionSizeOrDefault(10)))
++    return toCollection(ArrayList<T>())","Still it makes sense to check an actual type of this `Iterable` and switch to `Collection.toArrayList` in case if this is a collection.
+",2015-04-27 12:36:49
+909,"@@ -141,13 +141,28 @@ public static void checkAnnotationType(
+         }
+     }
+ 
++    @Nullable
++    private static <T extends PsiElement> T findAncestorOfType(@NotNull PsiElement element, Class<T> ancestorType) {","There is already `getParentOfType`, please use it here",2017-07-18 11:47:13
+256,"@@ -141,6 +183,64 @@ public open class KotlinCompile(): AbstractCompile() {
+     }
+ }
+ 
++public open class Kotlin2JsCompile(): AbstractKotlinCompile<K2JSCompilerArguments>() {
++    override val compiler = K2JSCompiler()
++
++    override fun createBlankArgs(): K2JSCompilerArguments = K2JSCompilerArguments()
++
++    public fun addLibraryFiles(vararg fs: String) {
++        kotlinOptions.libraryFiles = (kotlinOptions.libraryFiles + fs).copyToArray()
++    }
++
++    public fun addLibraryFiles(vararg fs: File) {
++        val strs = fs.map{it.getPath()}.copyToArray()
++        addLibraryFiles(*strs)
++    }
++
++    fun outputFile(): String {
++        return if (StringUtils.isEmpty(kotlinOptions.outputFile)) {
++            ""${kotlinDestinationDir}/app.js""","I think outputFile can not be omitted and if it omitted compilation should be failed.
+",2014-11-11 18:19:53
+257,"@@ -141,6 +183,64 @@ public open class KotlinCompile(): AbstractCompile() {
+     }
+ }
+ 
++public open class Kotlin2JsCompile(): AbstractKotlinCompile<K2JSCompilerArguments>() {
++    override val compiler = K2JSCompiler()
++
++    override fun createBlankArgs(): K2JSCompilerArguments = K2JSCompilerArguments()
++
++    public fun addLibraryFiles(vararg fs: String) {
++        kotlinOptions.libraryFiles = (kotlinOptions.libraryFiles + fs).copyToArray()
++    }
++
++    public fun addLibraryFiles(vararg fs: File) {
++        val strs = fs.map{it.getPath()}.copyToArray()
++        addLibraryFiles(*strs)
++    }
++
++    fun outputFile(): String {
++        return if (StringUtils.isEmpty(kotlinOptions.outputFile)) {
++            ""${kotlinDestinationDir}/app.js""
++        } else {
++            kotlinOptions.outputFile
++        }
++    }
++
++    public fun sourceMapDestinationDir(): File = File(outputFile()).directory
++
++    {
++        getOutputs().file(MethodClosure(this, ""outputFile""))
++    }
++
++    override fun populateTargetSpecificArgs(args: K2JSCompilerArguments, sources: ArrayList<File>) {
++        args.outputFile = outputFile()
++        args.outputPrefix = kotlinOptions.outputPrefix
++        args.outputPostfix = kotlinOptions.outputPostfix
++        args.libraryFiles = kotlinOptions.libraryFiles
++        args.target = kotlinOptions.target
++        args.sourceMap = kotlinOptions.sourceMap
++
++        val outputDir = File(args.outputFile).directory
++        if (!outputDir.exists()) {
++            if (!outputDir.mkdirs()) {
++               throw GradleException(""Failed to create output directory ${outputDir} or one of its ancestors"")
++            }
++        }
++    }
++}
++
++public open class RewritePathsInSourceMap(): DefaultTask() {
++    var sourceMapPath: () -> String = {""""}
++    var sourceRootDir: () -> String = {""""}
++
++    [TaskAction] fun rewrite() {
++        val file = File(sourceMapPath())
++        val text = file.readText(""UTF-8"")","charset parameter may be omitted -- UTF-8 will by use by default
+",2014-11-11 18:26:21
+260,"@@ -141,7 +185,63 @@ public open class KotlinCompile(): AbstractCompile() {
+     }
+ }
+ 
+-public open class KDoc(): SourceTask() {
++public open class Kotlin2JsCompile() : AbstractKotlinCompile<K2JSCompilerArguments>() {
++    override val compiler = K2JSCompiler()
++
++    override fun createBlankArgs(): K2JSCompilerArguments = K2JSCompilerArguments()
++
++    public fun addLibraryFiles(vararg fs: String) {","I think we should extract all libraries from dependencies instead.
+",2014-11-12 13:22:09
+259,"@@ -141,7 +185,63 @@ public open class KotlinCompile(): AbstractCompile() {
+     }
+ }
+ 
+-public open class KDoc(): SourceTask() {
++public open class Kotlin2JsCompile() : AbstractKotlinCompile<K2JSCompilerArguments>() {
++    override val compiler = K2JSCompiler()
++
++    override fun createBlankArgs(): K2JSCompilerArguments = K2JSCompilerArguments()
++
++    public fun addLibraryFiles(vararg fs: String) {
++        kotlinOptions.libraryFiles = (kotlinOptions.libraryFiles + fs).copyToArray()
++    }
++
++    public fun addLibraryFiles(vararg fs: File) {
++        val strs = fs.map { it.getPath() }.copyToArray()
++        addLibraryFiles(*strs)
++    }
++
++    fun outputFile(): String? = kotlinOptions.outputFile
++
++    public fun sourceMapDestinationDir(): File = File(outputFile()).directory
++
++    {
++        getOutputs().file(MethodClosure(this, ""outputFile""))
++    }
++
++    override fun populateTargetSpecificArgs(args: K2JSCompilerArguments) {
++        args.outputFile = outputFile()
++        args.outputPrefix = kotlinOptions.outputPrefix
++        args.outputPostfix = kotlinOptions.outputPostfix
++        args.libraryFiles = kotlinOptions.libraryFiles
++        args.target = kotlinOptions.target
++        args.sourceMap = kotlinOptions.sourceMap
++
++        if (args.outputFile == null) {
++            throw GradleException(""${getName()}.kotlinOptions.outputFile must be set to a string."")
++        }
++
++        val outputDir = File(args.outputFile).directory
++        if (!outputDir.exists()) {
++            if (!outputDir.mkdirs()) {
++                throw GradleException(""Failed to create output directory ${outputDir} or one of its ancestors"")
++            }
++        }
++    }
++}
++
++public open class RewritePathsInSourceMap() : DefaultTask() {","Ideally it should be fixed in compiler as part of [KT-4078](https://youtrack.jetbrains.com/issue/KT-4078). You can just add TODO comment that this hack should be dropped after KT-4078 will be fixed or fix it :)
+",2014-11-12 13:18:02
+303,"@@ -142,7 +176,7 @@ public inline fun <K, V, R, C : MutableMap<R, V>> Map<K, V>.mapKeysTo(destinatio
+ }
+ 
+ /**
+- * Puts all the entries into this [[MutableMap]] with the first value in the pair being the key and the second the value
++ * Puts all the entries into this [MutableMap] with the first value in the pair being the key and the second the value","""Puts given values"", and again value vs component for Pair.
+",2015-02-09 16:06:41
+760,"@@ -144,8 +146,14 @@ fun createKeywordConstructLookupElement(
+                     val beforeCaret = tailBeforeCaret.indentLinesAfterFirst(newIndent)
+                     val afterCaret = tailAfterCaret.indentLinesAfterFirst(newIndent)
+ 
+-                    insertionContext.document.insertString(offset, beforeCaret + afterCaret)
+-                    insertionContext.editor.moveCaret(offset + beforeCaret.length)
++                    val element = insertionContext.file.findElementAt(offset)?.getNextSiblingIgnoringWhitespaceAndComments(true)","Why getNextSiblingIgnoringWhitespaceAndComments() is needed? I expect that it is for 'for' keyword completion, but at least one test needed for it.
+I also think that there shouldn't be comments skipping.",2017-04-11 16:21:06
+761,"@@ -144,8 +146,14 @@ fun createKeywordConstructLookupElement(
+                     val beforeCaret = tailBeforeCaret.indentLinesAfterFirst(newIndent)
+                     val afterCaret = tailAfterCaret.indentLinesAfterFirst(newIndent)
+ 
+-                    insertionContext.document.insertString(offset, beforeCaret + afterCaret)
+-                    insertionContext.editor.moveCaret(offset + beforeCaret.length)
++                    val element = insertionContext.file.findElementAt(offset)?.getNextSiblingIgnoringWhitespaceAndComments(true)
++
++                    if (element != null && beforeCaret.trimStart().startsWith(insertionContext.document.getText(TextRange.from(element.startOffset, 1)))) {",I think it will be more safe to use == instead of startsWith(),2017-04-11 16:23:32
+0,"@@ -145,10 +145,22 @@ private static JetElement overrideFunction(Project project, JetFile file, Simple
+         StringBuilder bodyBuilder = new StringBuilder(""override fun "");
+         bodyBuilder.append(descriptor.getName());
+         bodyBuilder.append(""("");
++        boolean isAbstractFun = descriptor.getModality() == Modality.ABSTRACT;
++        StringBuilder delegationBuilder = new StringBuilder();","It's not very critical now, but I think that your decision to barter flat and simple structure of this method to one more iteration over parameters collection was a bad deal. Now it's really difficult to understand the logic of filling StringBuilder variables.
+",2012-04-03 12:21:38
+725,"@@ -15,6 +15,7 @@ public abstract class Mine</*0*/ T> : java.util.AbstractList<T> {
+     public open /*fake_override*/ fun clear(): kotlin.Unit
+     public open /*fake_override*/ fun contains(/*0*/ T!): kotlin.Boolean
+     public open /*fake_override*/ fun containsAll(/*0*/ kotlin.collections.Collection<T!>): kotlin.Boolean
++    public open /*fake_override*/ fun forEach(/*0*/ java.util.function.Consumer<in T!>!): kotlin.Unit","You'd better not to change existing tests, but to create a new test group with the same test data and your flag enabled.",2017-04-05 15:27:24
+304,"@@ -151,7 +185,7 @@ public fun <K, V> MutableMap<K, V>.putAll(vararg values: Pair<K, V>): Unit {
+ }
+ 
+ /**
+- * Puts all the entries into this [[MutableMap]] with the first value in the pair being the key and the second the value
++ * Puts all the entries into this [MutableMap] with the first value in the pair being the key and the second the value","""Puts elements of the given collection""
+",2015-02-09 16:07:10
+618,"@@ -152,13 +152,14 @@ class ClassBodyConverter(private val psiClass: PsiClass,
+     ): Member? {
+         when (member) {
+             is PsiMethod -> {
+-                memberToPropertyInfo[member]?.let { propertyInfo ->
+-                    if (propertyInfo.field != null) return null // just drop the method, property will be generated when converting the field
+-                    return if (member == propertyInfo.getMethod || propertyInfo.getMethod == null)
+-                        converter.convertProperty(propertyInfo, classKind)
+-                    else
+-                        null // drop the method, property will be generated when converting the field or the getter
+-                }
++                if (!member.hasModifierProperty(PsiModifier.NATIVE))","This doesn't seem to be a correct check. This is valid Kotlin:
+
+``` kotlin
+val foo: Int = 0
+    external get
+```
+",2016-09-22 10:50:26
+568,"@@ -1520,6 +1520,15 @@
+                      language=""kotlin""
+     />
+ 
++    <localInspection implementationClass=""org.jetbrains.kotlin.idea.inspections.UnnecessaryJavaUsageInspection""
++                     displayName=""Unnecessary java usage""","This is no more clear than the same text in the inspection description, and also needs to be changed.
+",2016-05-19 14:49:43
+561,"@@ -1520,6 +1520,15 @@
+                      language=""kotlin""
+     />
+ 
++    <localInspection implementationClass=""org.jetbrains.kotlin.idea.inspections.UnnecessaryJavaUsageInspection""
++                     displayName=""Unnecessary java usage""
++                     groupName=""Kotlin""
++                     enabledByDefault=""true""
++                     cleanupTool=""true""
++                     level=""WARNING""","This should be a WEAK_WARNING at most. There's nothing wrong with the original code - it's simply not as concise as it could be.
+",2016-05-18 13:23:26
+85,"@@ -1564,4 +1568,36 @@ public static void checkParameterHasNoValOrVar(
+             trace.report(diagnosticFactory.on(valOrVarNode.getPsi(), ((JetKeywordToken) valOrVarNode.getElementType())));
+         }
+     }
++
++    private static void checkConstructorParameterHasNoModifier(
++            @NotNull BindingTrace trace,
++            @NotNull JetParameter parameter,
++            @NotNull DiagnosticFactory1<PsiElement, JetKeywordToken> diagnosticFactory
++    ) {
++        // If is not a property, then it must have no modifier
++        if (parameter.getValOrVarNode() == null) {
++            checkParameterHasNoModifier(trace, parameter, diagnosticFactory);
++        }
++    }
++
++    public static void checkParameterHasNoModifier(
++            @NotNull BindingTrace trace,
++            @NotNull JetParameter parameter,
++            @NotNull DiagnosticFactory1<PsiElement, JetKeywordToken> diagnosticFactory
++    ) {
++        JetModifierList modifiers = parameter.getModifierList();
++        if (modifiers != null) {
++            ASTNode node = modifiers.getNode().getFirstChildNode();
++
++            while (node != null) {
++                IElementType elementType = node.getElementType();
++
++                if (elementType != JetTokens.VARARG_KEYWORD && elementType instanceof JetKeywordToken) {
++                    trace.report(diagnosticFactory.on(node.getPsi(), (JetKeywordToken) elementType));
++                    break;","fun foo(public abstract x: Int) //abstract should also highlighted as error 
+",2013-08-29 10:12:30
+348,"@@ -158,6 +157,7 @@ protected void blackBox() {
+             Method method = aClass.getMethod(""box"");
+             String r = (String) method.invoke(null);
+             assertEquals(""OK"", r);
++            System.out.println(generateToText());","I beleive this was commited erroneously.
+",2015-03-26 15:35:44
+284,"@@ -16,10 +16,25 @@
+ 
+ package kotlin
+ 
++/**
++ * Represents a sequence of numbers or characters with a given start value, end value and step.
++ * This class is intended to be used in 'for' loops, and the JVM backend suggests efficient
++ * bytecode generation for it. Progressions with a step of -1 can be created through the
++ * `downTo` method on classes representing primitive types.","Link to `downTo` method.
+",2015-02-09 15:42:22
+285,"@@ -16,10 +16,25 @@
+ 
+ package kotlin
+ 
++/**
++ * Represents a sequence of numbers or characters with a given start value, end value and step.
++ * This class is intended to be used in 'for' loops, and the JVM backend suggests efficient
++ * bytecode generation for it. Progressions with a step of -1 can be created through the
++ * `downTo` method on classes representing primitive types.
++ */
+ public trait Progression<out N : Any> : Iterable<N> {
++    /**
++     * The start value of a progression.
++     */
+     public val start: N
+ 
++    /**
++     * The end value of the progression (inclusive).","start ""a progression"", end ""the progression""
+",2015-02-09 15:42:45
+269,"@@ -16,10 +16,25 @@
+ 
+ package kotlin
+ 
++/**
++ * The root of the Kotlin class hierarchy. Every Kotlin class has [Any] as a superclass.
++ */
+ public open class Any {
++    /**
++     * Indicates whether some other object is ""equal to"" this one. Implementations must follow
++     * the same contract as the [Java equals() method](http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#equals%28java.lang.Object%29).","Referencing Java in such a way doesn't make it look like a standard library for a _language_, which is targeting different platforms. E.g. for JS it may be different contract.
+",2015-02-09 15:23:56
+270,"@@ -16,10 +16,25 @@
+ 
+ package kotlin
+ 
++/**
++ * The root of the Kotlin class hierarchy. Every Kotlin class has [Any] as a superclass.
++ */
+ public open class Any {
++    /**
++     * Indicates whether some other object is ""equal to"" this one. Implementations must follow
++     * the same contract as the [Java equals() method](http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#equals%28java.lang.Object%29).
++     * Note that the `==` operator in Kotlin code is translated into a null-safe call to [equals].","Expand ""null-safe call"". I would read it as ""a?.equals(b)"" which is wrong, because expression type for `==` is `Boolean`, not `Boolean?`
+",2015-02-09 15:24:55
+271,"@@ -16,10 +16,25 @@
+ 
+ package kotlin
+ 
++/**
++ * The root of the Kotlin class hierarchy. Every Kotlin class has [Any] as a superclass.
++ */
+ public open class Any {
++    /**
++     * Indicates whether some other object is ""equal to"" this one. Implementations must follow
++     * the same contract as the [Java equals() method](http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#equals%28java.lang.Object%29).
++     * Note that the `==` operator in Kotlin code is translated into a null-safe call to [equals].
++     */
+     public open fun equals(other: Any?): Boolean
+ 
++    /**
++     * Returns a hash code value for the object. Implementations must follow the same contract
++     * as the [Java hashCode() method](http://docs.oracle.com/javase/7/docs/api/java/lang/Object.html#hashCode%28%29).","Same note about Java-ism.
+",2015-02-09 15:25:14
+281,"@@ -16,10 +16,30 @@
+ 
+ package kotlin
+ 
++/**
++ * Marks the annotated class as a data class. Data classes have automatically generated","""When processing data class, compiler will generate""...
+",2015-02-09 15:39:18
+169,"@@ -16,11 +16,17 @@
+ 
+ package org.jetbrains.jet.plugin.refactoring.rename;
+ 
+-import org.jetbrains.jet.JetTestUtils;
+-import org.jetbrains.jet.test.TestMetadata;
++import junit.framework.Assert;
++import junit.framework.Test;
++import junit.framework.TestSuite;
+ 
+ import java.io.File;
+ import java.util.regex.Pattern;
++import org.jetbrains.jet.JetTestUtils;
++import org.jetbrains.jet.test.InnerTestClasses;
++import org.jetbrains.jet.test.TestMetadata;
++
++import org.jetbrains.jet.plugin.refactoring.rename.AbstractRenameTest;","Changes in this file shouldn't have been included in your pull request
+",2014-04-09 16:13:35
+279,"@@ -16,13 +16,31 @@
+ 
+ package kotlin
+ 
++/**
++ * Returns true if the receiver and the [other] object are the same object instance, or if they
++ * are both null.
++ */
+ public fun Any?.identityEquals(other: Any?): Boolean // = this === other
+ 
++/**
++ * Returns true if the receiver and the [other] object are ""equal"" to each other, or if they are","Link to Any.equals() on ""equal"" would be good, to refer to explanation of equality.
+",2015-02-09 15:37:06
+272,"@@ -16,13 +16,44 @@
+ 
+ package kotlin
+ 
++/**
++ * Represents an array (specifically, a Java array when targeting the JVM platform).
++ * Array instances can be created using the [array] and [arrayOfNulls] standard
++ * library functions.
++ * See [Kotlin language documentation](http://kotlinlang.org/docs/reference/basic-types.html#arrays)
++ * for more information on arrays.
++ */
+ public class Array<reified T> private (): Cloneable {
++    /**
++     * Returns the array element at the specified [index]. This method can be called using the
++     * brackets notation:","We usually call it ""index operator"", I think, not ""brackets notation"".
+",2015-02-09 15:26:26
+273,"@@ -16,13 +16,44 @@
+ 
+ package kotlin
+ 
++/**
++ * Represents an array (specifically, a Java array when targeting the JVM platform).
++ * Array instances can be created using the [array] and [arrayOfNulls] standard
++ * library functions.
++ * See [Kotlin language documentation](http://kotlinlang.org/docs/reference/basic-types.html#arrays)
++ * for more information on arrays.
++ */
+ public class Array<reified T> private (): Cloneable {
++    /**
++     * Returns the array element at the specified [index]. This method can be called using the
++     * brackets notation:
++     * ```
++     * val = arr[index]","bad example, ""val"" is keyword. 
+",2015-02-09 15:27:02
+274,"@@ -16,13 +16,44 @@
+ 
+ package kotlin
+ 
++/**
++ * Represents an array (specifically, a Java array when targeting the JVM platform).
++ * Array instances can be created using the [array] and [arrayOfNulls] standard
++ * library functions.
++ * See [Kotlin language documentation](http://kotlinlang.org/docs/reference/basic-types.html#arrays)
++ * for more information on arrays.
++ */
+ public class Array<reified T> private (): Cloneable {
++    /**
++     * Returns the array element at the specified [index]. This method can be called using the
++     * brackets notation:
++     * ```
++     * val = arr[index]
++     * ```
++     */
+     public fun get(index: Int): T
++
++    /**
++     * Sets the array element at the specified [index] to the specified [value]. This method can
++     * be called using the brackets notation:
++     * ```
++     * arr[index] = val","Same here for ""brackets"" and ""val""
+",2015-02-09 15:27:25
+275,"@@ -16,13 +16,44 @@
+ 
+ package kotlin
+ 
++/**
++ * Represents an array (specifically, a Java array when targeting the JVM platform).
++ * Array instances can be created using the [array] and [arrayOfNulls] standard
++ * library functions.
++ * See [Kotlin language documentation](http://kotlinlang.org/docs/reference/basic-types.html#arrays)
++ * for more information on arrays.
++ */
+ public class Array<reified T> private (): Cloneable {
++    /**
++     * Returns the array element at the specified [index]. This method can be called using the
++     * brackets notation:
++     * ```
++     * val = arr[index]
++     * ```
++     */
+     public fun get(index: Int): T
++
++    /**
++     * Sets the array element at the specified [index] to the specified [value]. This method can
++     * be called using the brackets notation:
++     * ```
++     * arr[index] = val
++     * ```
++     */
+     public fun set(index: Int, value: T): Unit
+ 
++    /**
++     * Returns the length of the array.","""Returns number of elements in the array"". Method called ""size"" shouldn't be described with word ""length""
+",2015-02-09 15:27:58
+484,"@@ -16,14 +16,9 @@
+ 
+ package org.jetbrains.kotlin.resolve.descriptorUtil
+ 
+-import org.jetbrains.kotlin.descriptors.DeclarationDescriptor
+ import org.jetbrains.kotlin.descriptors.annotations.Annotated
+ import org.jetbrains.kotlin.name.FqName
+ 
+-private val HIDDEN_ANNOTATION_FQ_NAME = FqName(""kotlin.HiddenDeclaration"")
+-
+-public fun DeclarationDescriptor.isAnnotatedAsHidden(): Boolean = annotations.findAnnotation(HIDDEN_ANNOTATION_FQ_NAME) != null
+-
+ private val NO_INFER_ANNOTATION_FQ_NAME = FqName(""kotlin.NoInfer"")","I think this whole file should be moved to `frontend`...
+",2015-10-10 20:45:40
+918,"@@ -16,18 +16,25 @@
+ 
+ package kotlin.script.templates.standard
+ 
++// discuss
++//
++// These are some 'basic' script templates
++// Should we keep them here?","I think we should do the following with these:
+* `SimpleScriptTemplate` -> remove (script with args can be always used instead of it)
+* `kotlin.script.templates.standard.ScriptTemplateWithArgs` -> rename and move to `kotlin.script.templates.StandardScriptTemplate`
+* `kotlin.script.templates.standard.ScriptTemplateWithBindings` -> move to `kotlin.script.templates.ScriptTemplateWithBindings`",2017-07-25 10:25:34
+276,"@@ -16,26 +16,66 @@
+ 
+ package kotlin
+ 
++/**
++ * An iterator over a collection. Allows to sequentially access the elements in a collection.","Not necessary ""in a collection"". 
+",2015-02-09 15:28:42
+277,"@@ -16,26 +16,66 @@
+ 
+ package kotlin
+ 
++/**
++ * An iterator over a collection. Allows to sequentially access the elements in a collection.
++ */
+ public trait Iterator<out T> {
++    /**
++     * Returns the next element in the iteration.
++     */
+     public fun next(): T
++
++    /**
++     * Returns `true` if the iteration has more elements.
++     */
+     public fun hasNext(): Boolean
+ }
+ 
++/**
++ * An iterator over a mutable collection. Provides the ability to remove elements while iterating.
++ * @see MutableCollection.iterator
++ */
+ public trait MutableIterator<out T> : Iterator<T> {
++    /**
++     * Removes from the underlying collection the last element returned by this iterator.
++     */
+     public fun remove(): Unit
+ }
+ 
++/**
++ * An iterator over a collection that supports indexed access.
++ * @see List.listIterator
++ */
+ public trait ListIterator<out T> : Iterator<T> {
+     // Query Operations
+     override fun next(): T","Do we need overrides here?
+",2015-02-09 15:34:07
+642,"@@ -16,29 +16,26 @@
+ 
+ package org.jetbrains.kotlin.idea.codeInsight.surroundWith
+ 
+-import com.intellij.openapi.project.Project
+ import com.intellij.psi.PsiElement
+ import com.intellij.psi.PsiReference
+ import com.intellij.psi.search.LocalSearchScope
+ import com.intellij.psi.search.SearchScope
+ import com.intellij.psi.search.searches.ReferencesSearch
+ import com.intellij.psi.util.PsiUtilCore
+-import org.jetbrains.kotlin.descriptors.VariableDescriptor
+-import org.jetbrains.kotlin.idea.caches.resolve.*
++import org.jetbrains.kotlin.idea.caches.resolve.analyze
+ import org.jetbrains.kotlin.idea.codeInsight.CodeInsightUtils
+-import org.jetbrains.kotlin.idea.util.IdeDescriptorRenderers
+ import org.jetbrains.kotlin.idea.core.ShortenReferences
++import org.jetbrains.kotlin.idea.util.IdeDescriptorRenderers
+ import org.jetbrains.kotlin.psi.*
+ import org.jetbrains.kotlin.resolve.BindingContext
+ import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
+ import org.jetbrains.kotlin.types.KotlinType
+-
+-import java.util.ArrayList
++import java.util.*
+ 
+ object MoveDeclarationsOutHelper {","This `object` serves no purpose; the contents of the file should simply be top-level functions
+",2016-10-18 18:44:48
+324,"@@ -16,40 +16,112 @@
+ 
+ package kotlin
+ 
++/**
++ * Classes that inherit from this trait can be represented as a sequence of elements that can
++ * be iterated over.
++ */
+ public trait Iterable<out T> {","doc for `T`?
+",2015-03-02 17:23:35
+920,"@@ -16,6 +16,11 @@
+ 
+ package kotlin.script.extensions
+ 
++// discuss
++
++// Is this an appropriate place to put this class?","This doesn't look like an appropriate place. If I understand correctly, it has nothing to do with scripts, so putting it into package `kotlin.script.extensions` is risky. As soon as we decide to publish it as a supported compiler plugin, we'll have to move it to another package and artifact, causing incompatibilities, so maybe it'd be better to do this earlier.",2017-07-25 11:06:18
+282,"@@ -16,8 +16,18 @@
+ 
+ package kotlin
+ 
++/**
++ * Annotates the parameter of a function annotates as [inline] and forbids inlining of","Typo: ""annotates as [inline]"" -> ""annotated as [inline]""
+",2015-02-09 15:40:41
+283,"@@ -16,8 +16,18 @@
+ 
+ package kotlin
+ 
++/**
++ * Annotates the parameter of a function annotates as [inline] and forbids inlining of
++ * function literals passed as arguments for this parameter.
++ */
+ public annotation class noinline
+ 
++/**","Add cross-reference to other annotations, like `noinline`
+",2015-02-09 15:41:44
+778,"@@ -161,6 +162,13 @@ object KotlinToJVMBytecodeCompiler {
+                 ProgressIndicatorAndCompilationCanceledStatus.checkCanceled()
+                 writeOutput(state.configuration, state.factory, null)
+             }
++
++            if (chunk.size == 1 && projectConfiguration.getBoolean(JVMConfigurationKeys.USE_JAVAC)) {","If the chunk contains multiple modules and `-Xuse-javac` has been specified, maybe we should report a warning saying that we won't in fact use javac for compilation",2017-04-25 07:54:52
+762,"@@ -161,6 +162,14 @@ object KotlinToJVMBytecodeCompiler {
+                 ProgressIndicatorAndCompilationCanceledStatus.checkCanceled()
+                 writeOutput(state.configuration, state.factory, null)
+             }
++
++            if (chunk.size == 1) {
++                val javacWrapper = JavacWrapper.getInstance(environment.project)
++                if (projectConfiguration[JVMConfigurationKeys.USE_JAVAC]!!) {",@baratynskiy Please use `getBoolean(...)` instead of `get(...)!!`,2017-04-12 15:41:33
+76,"@@ -162,4 +162,8 @@ change.function.signature.family=Change function signature
+ change.function.signature.chooser.title=Choose signature
+ change.function.signature.action=Change function signature
+ remove.unnecessary.parentheses=Remove unnecessary parentheses
+-remove.unnecessary.parentheses.family=Remove Unnecessary Parentheses
+\ No newline at end of file
++remove.unnecessary.parentheses.family=Remove Unnecessary Parentheses
++add.function.to.supertype.family=Add Function to Supertype","While I know it's technically not 100% correct and maybe ""Add Function to _Superclassifier_"" would be a more accurate name for this quickfix I still want to stick with the name ""Add Function to Supertype"". In my opinion the user would be confused by using word ""superclassifier"". I can change the name though if you disagree. 
+",2013-05-16 07:45:39
+288,"@@ -1629,70 +1629,70 @@ public fun <T> Stream<T>.lastIndexOf(element: T): Int {
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun <T> Array<out T>.lastOrNull(): T? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun BooleanArray.lastOrNull(): Boolean? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun ByteArray.lastOrNull(): Byte? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun CharArray.lastOrNull(): Char? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun DoubleArray.lastOrNull(): Double? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun FloatArray.lastOrNull(): Float? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun IntArray.lastOrNull(): Int? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty
+  */
+ public fun LongArray.lastOrNull(): Long? {
+     return if (isEmpty()) null else this[size() - 1]
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last element, or null if the collection is empty","Back-tick quote ""null""?
+",2015-02-09 15:48:24
+503,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {","It seems more like just ""createIncrementalCache""
+",2016-02-02 15:30:24
+502,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =","1. Formatting is unusual to our codebase (surrounding ""->"" with spaces).
+2. logAction is the same for both call-sites
+3. filesFiler is almost the same for call-sites. Could be replaced with excludedFiles: Set<File>
+",2016-02-02 15:25:33
+504,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =
++            flatMap { lookup ->
++                val files = lookupStorage.get(lookup).map(::File).filter(filesFilter)
++                if (files.any()) {
++                    logAction(lookup, files)
++                }
++                files
++            }
++
++        fun dirtyLookupSymbolsFromRemovedKotlinFiles(): List<LookupSymbol> {","I don't think these lookups can useful: 
+- for JPS a processing of removed classes is done in `clearCacheForRemovedClasses`; that method uses proto from caches for dirty fqnames;
+- current implementation can only return lookups of classes.
+
+So I suggest to remove this function.
+",2016-02-02 17:58:19
+505,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =
++            flatMap { lookup ->
++                val files = lookupStorage.get(lookup).map(::File).filter(filesFilter)
++                if (files.any()) {
++                    logAction(lookup, files)
++                }
++                files
++            }
++
++        fun dirtyLookupSymbolsFromRemovedKotlinFiles(): List<LookupSymbol> {
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            return if (removedKotlinFiles.isNotEmpty())
++                targets.flatMap { getIncrementalCache(it).classesBySources(removedKotlinFiles).map { LookupSymbol(it.fqNameForClassNameWithoutDollars.shortName().toString(), it.packageFqName.toString()) } }
++            else listOf()
++        }
++
++        fun dirtyLookupSymbolsFromModifiedJavaFiles(): List<LookupSymbol> {
++            val modifiedJavaFiles = modified.filter { it.isJavaFile() }
++            return (if (modifiedJavaFiles.any()) {
++                val rootDisposable = Disposer.newDisposable()
++                val configuration = CompilerConfiguration()
++                val environment = KotlinCoreEnvironment.createForProduction(rootDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
++                val project = environment.project
++                val psiFileFactory = PsiFileFactory.getInstance(project) as PsiFileFactoryImpl
++                modifiedJavaFiles.flatMap {
++                    val javaFile = psiFileFactory.createFileFromText(it.nameWithoutExtension, Language.findLanguageByID(""JAVA"")!!, it.readText())
++                    if (javaFile is PsiJavaFile)
++                        javaFile.classes.flatMap { it.findLookupSymbols() }
++                    else listOf()
++                }
++            } else listOf())
++        }
++
++        fun dirtyKotlinSourcesFromGradle(): List<File> {
++            // TODO: handle classpath changes similarly - compare with cashed version (likely a big change, may be costly, some heuristics could be considered)
++            val modifiedKotlinFiles = modified.filter { it.isKotlinFile() }
++            val lookupSymbols =
++                    dirtyLookupSymbolsFromModifiedJavaFiles() +
++                    dirtyLookupSymbolsFromRemovedKotlinFiles()
++                    // TODO: add dirty lookups from modified kotlin files to reduce number of steps needed
++
++            if (lookupSymbols.any()) {
++                val kotlinModifiedFilesSet = modifiedKotlinFiles.toHashSet()
++                return modifiedKotlinFiles +
++                        lookupSymbols.files(
++                                filesFilter = { it !in kotlinModifiedFilesSet },
++                                logAction = { lookup, files ->
++                                    logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                                })
++            }
++            return modifiedKotlinFiles
++        }
++
++        fun isClassPathChanged(): Boolean {
++            // TODO: that doesn't look to wise - join it first and then split here, consider storing it somewhere in between
++            val classpath = args.classpath.split(File.pathSeparator).map { File(it) }.toHashSet()
++            val changedClasspath = modified.filter { classpath.contains(it) }
++            return changedClasspath.any()
++        }
++
++        fun allCachesVersions() = allCachesVersions(cachesBaseDir, listOf(cachesBaseDir))
++
++        fun calculateSourcesToCompile(): Pair<List<File>, Boolean> {
++
++            if (!experimentalIncremental ||
++                    !isIncrementalRequested ||
++                    // TODO: more precise will be not to rebuild unconditionally on classpath changes, but retrieve lookup info and try to find out which sources are affected by cp changes
++                    isClassPathChanged() ||
++                    // so far considering it not incremental TODO: store java files in the cache and extract removed symbols from it here
++                    removed.any { it.isJavaFile() }
++            ) {
++                logger.kotlinInfo(if (!isIncrementalRequested) ""clean caches on rebuild"" else ""classpath changed, rebuilding all kotlin files"")
++                targets.forEach { getIncrementalCache(it).clean() }
++                lookupStorage.clean()
++                return Pair(sources, false)
++            }
++            val actions = if (isIncrementalRequested) allCachesVersions().map { it.checkVersion() }
++                          else listOf(CacheVersion.Action.REBUILD_ALL_KOTLIN)
++            // TODO: find out whether these flags should be emulated too
++//            val hasKotlin = HasKotlinMarker(dataManager)
++//            val rebuildAfterCacheVersionChanged = RebuildAfterCacheVersionChangeMarker(dataManager)
++
++            for (status in actions.distinct().sorted()) {
++                when (status) {
++                    CacheVersion.Action.REBUILD_ALL_KOTLIN -> {
++                        logger.kotlinInfo(""Kotlin global lookup map format changed, rebuilding all kotlin files"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                        lookupStorage.clean()
++                        return Pair(sources, false)
++                    }
++                    CacheVersion.Action.REBUILD_CHUNK -> {
++                        logger.kotlinInfo(""Clearing caches for "" + targets.joinToString { it.name })
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_NORMAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_EXPERIMENTAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing experimental caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).cleanExperimental() }
++                    }
++                    CacheVersion.Action.CLEAN_DATA_CONTAINER -> {
++                        logger.kotlinInfo(""Clearing lookup cache"")
++                        lookupStorage.clean()
++                        dataContainerCacheVersion(cachesBaseDir).clean()
++                    }
++                    else -> {
++                        assert(status == CacheVersion.Action.DO_NOTHING) { ""Unknown version status $status"" }
++                    }
++                }
++            }
++            val dirtyFiles = dirtyKotlinSourcesFromGradle().distinct()
++            // first dirty files should be found and only then caches cleared
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            targets.forEach { getIncrementalCache(it).let {
++                it.markOutputClassesDirty(removedKotlinFiles)
++                it.removeClassfilesBySources(removedKotlinFiles)
++            }}
++            return Pair(dirtyFiles, true)
++        }
++
++        fun cleanupOnError() {
++            val outputDirFile = File(args.destination!!)
++
++            assert(outputDirFile.exists())
++            val generatedRelPaths = allGeneratedFiles.map { it.outputFile.toRelativeString(outputDirFile) }
++            logger.kotlinInfo(""deleting output on error: ${generatedRelPaths.joinToString()}"")
++
++            allGeneratedFiles.forEach { it.outputFile.delete() }
++            generatedRelPaths.forEach { File(destinationDir, it).delete() }
++        }
++
++        fun processCompilerExitCode(exitCode: ExitCode) {
++            if (exitCode != ExitCode.OK) {
++                cleanupOnError()
++            }
++            when (exitCode) {
++                ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
++                ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
++                ExitCode.SCRIPT_EXECUTION_ERROR -> throw GradleException(""Script execution error. See log for more details"")
++                ExitCode.OK -> logger.kotlinInfo(""Compilation succeeded"")
++            }
++        }
++
++        fun outputRelativePath(f: File) = f.toRelativeString(outputDir)
++
++
++        if (!experimentalIncremental) {
++            anyClassesCompiled = true
++            processCompilerExitCode(compileNotIncremental(sources, outputDir, args))
++            return
++        }
++        logger.warn(""Using experimental kotlin incremental compilation"")
++
++        anyClassesCompiled = false
++
++        // TODO: decide what to do if no files are considered dirty - rebuild or skip the module
++        var (sourcesToCompile, isIncrementalDecided) = calculateSourcesToCompile()
++
++        if (isIncrementalDecided) {
++            // TODO: process as list here, merge into string later
++            args.classpath = args.classpath + File.pathSeparator + outputDir.absolutePath
++        }
++
++        while (sourcesToCompile.any()) {
++            logger.kotlinInfo(""compile iteration: ${sourcesToCompile.joinToString{ projectRelativePath(it) }}"")
++
++            val (exitCode, generatedFiles) = compileChanged(","What's the point in using named arguments here?
+",2016-02-02 18:10:10
+506,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =
++            flatMap { lookup ->
++                val files = lookupStorage.get(lookup).map(::File).filter(filesFilter)
++                if (files.any()) {
++                    logAction(lookup, files)
++                }
++                files
++            }
++
++        fun dirtyLookupSymbolsFromRemovedKotlinFiles(): List<LookupSymbol> {
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            return if (removedKotlinFiles.isNotEmpty())
++                targets.flatMap { getIncrementalCache(it).classesBySources(removedKotlinFiles).map { LookupSymbol(it.fqNameForClassNameWithoutDollars.shortName().toString(), it.packageFqName.toString()) } }
++            else listOf()
++        }
++
++        fun dirtyLookupSymbolsFromModifiedJavaFiles(): List<LookupSymbol> {
++            val modifiedJavaFiles = modified.filter { it.isJavaFile() }
++            return (if (modifiedJavaFiles.any()) {
++                val rootDisposable = Disposer.newDisposable()
++                val configuration = CompilerConfiguration()
++                val environment = KotlinCoreEnvironment.createForProduction(rootDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
++                val project = environment.project
++                val psiFileFactory = PsiFileFactory.getInstance(project) as PsiFileFactoryImpl
++                modifiedJavaFiles.flatMap {
++                    val javaFile = psiFileFactory.createFileFromText(it.nameWithoutExtension, Language.findLanguageByID(""JAVA"")!!, it.readText())
++                    if (javaFile is PsiJavaFile)
++                        javaFile.classes.flatMap { it.findLookupSymbols() }
++                    else listOf()
++                }
++            } else listOf())
++        }
++
++        fun dirtyKotlinSourcesFromGradle(): List<File> {
++            // TODO: handle classpath changes similarly - compare with cashed version (likely a big change, may be costly, some heuristics could be considered)
++            val modifiedKotlinFiles = modified.filter { it.isKotlinFile() }
++            val lookupSymbols =
++                    dirtyLookupSymbolsFromModifiedJavaFiles() +
++                    dirtyLookupSymbolsFromRemovedKotlinFiles()
++                    // TODO: add dirty lookups from modified kotlin files to reduce number of steps needed
++
++            if (lookupSymbols.any()) {
++                val kotlinModifiedFilesSet = modifiedKotlinFiles.toHashSet()
++                return modifiedKotlinFiles +
++                        lookupSymbols.files(
++                                filesFilter = { it !in kotlinModifiedFilesSet },
++                                logAction = { lookup, files ->
++                                    logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                                })
++            }
++            return modifiedKotlinFiles
++        }
++
++        fun isClassPathChanged(): Boolean {
++            // TODO: that doesn't look to wise - join it first and then split here, consider storing it somewhere in between
++            val classpath = args.classpath.split(File.pathSeparator).map { File(it) }.toHashSet()
++            val changedClasspath = modified.filter { classpath.contains(it) }
++            return changedClasspath.any()
++        }
++
++        fun allCachesVersions() = allCachesVersions(cachesBaseDir, listOf(cachesBaseDir))
++
++        fun calculateSourcesToCompile(): Pair<List<File>, Boolean> {
++
++            if (!experimentalIncremental ||
++                    !isIncrementalRequested ||
++                    // TODO: more precise will be not to rebuild unconditionally on classpath changes, but retrieve lookup info and try to find out which sources are affected by cp changes
++                    isClassPathChanged() ||
++                    // so far considering it not incremental TODO: store java files in the cache and extract removed symbols from it here
++                    removed.any { it.isJavaFile() }
++            ) {
++                logger.kotlinInfo(if (!isIncrementalRequested) ""clean caches on rebuild"" else ""classpath changed, rebuilding all kotlin files"")
++                targets.forEach { getIncrementalCache(it).clean() }
++                lookupStorage.clean()
++                return Pair(sources, false)
++            }
++            val actions = if (isIncrementalRequested) allCachesVersions().map { it.checkVersion() }
++                          else listOf(CacheVersion.Action.REBUILD_ALL_KOTLIN)
++            // TODO: find out whether these flags should be emulated too
++//            val hasKotlin = HasKotlinMarker(dataManager)
++//            val rebuildAfterCacheVersionChanged = RebuildAfterCacheVersionChangeMarker(dataManager)
++
++            for (status in actions.distinct().sorted()) {
++                when (status) {
++                    CacheVersion.Action.REBUILD_ALL_KOTLIN -> {
++                        logger.kotlinInfo(""Kotlin global lookup map format changed, rebuilding all kotlin files"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                        lookupStorage.clean()
++                        return Pair(sources, false)
++                    }
++                    CacheVersion.Action.REBUILD_CHUNK -> {
++                        logger.kotlinInfo(""Clearing caches for "" + targets.joinToString { it.name })
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_NORMAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_EXPERIMENTAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing experimental caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).cleanExperimental() }
++                    }
++                    CacheVersion.Action.CLEAN_DATA_CONTAINER -> {
++                        logger.kotlinInfo(""Clearing lookup cache"")
++                        lookupStorage.clean()
++                        dataContainerCacheVersion(cachesBaseDir).clean()
++                    }
++                    else -> {
++                        assert(status == CacheVersion.Action.DO_NOTHING) { ""Unknown version status $status"" }
++                    }
++                }
++            }
++            val dirtyFiles = dirtyKotlinSourcesFromGradle().distinct()
++            // first dirty files should be found and only then caches cleared
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            targets.forEach { getIncrementalCache(it).let {
++                it.markOutputClassesDirty(removedKotlinFiles)
++                it.removeClassfilesBySources(removedKotlinFiles)
++            }}
++            return Pair(dirtyFiles, true)
++        }
++
++        fun cleanupOnError() {
++            val outputDirFile = File(args.destination!!)
++
++            assert(outputDirFile.exists())
++            val generatedRelPaths = allGeneratedFiles.map { it.outputFile.toRelativeString(outputDirFile) }
++            logger.kotlinInfo(""deleting output on error: ${generatedRelPaths.joinToString()}"")
++
++            allGeneratedFiles.forEach { it.outputFile.delete() }
++            generatedRelPaths.forEach { File(destinationDir, it).delete() }
++        }
++
++        fun processCompilerExitCode(exitCode: ExitCode) {
++            if (exitCode != ExitCode.OK) {
++                cleanupOnError()
++            }
++            when (exitCode) {
++                ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
++                ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
++                ExitCode.SCRIPT_EXECUTION_ERROR -> throw GradleException(""Script execution error. See log for more details"")
++                ExitCode.OK -> logger.kotlinInfo(""Compilation succeeded"")
++            }
++        }
++
++        fun outputRelativePath(f: File) = f.toRelativeString(outputDir)
++
++
++        if (!experimentalIncremental) {
++            anyClassesCompiled = true
++            processCompilerExitCode(compileNotIncremental(sources, outputDir, args))
++            return
++        }
++        logger.warn(""Using experimental kotlin incremental compilation"")
++
++        anyClassesCompiled = false
++
++        // TODO: decide what to do if no files are considered dirty - rebuild or skip the module
++        var (sourcesToCompile, isIncrementalDecided) = calculateSourcesToCompile()
++
++        if (isIncrementalDecided) {
++            // TODO: process as list here, merge into string later
++            args.classpath = args.classpath + File.pathSeparator + outputDir.absolutePath
++        }
++
++        while (sourcesToCompile.any()) {
++            logger.kotlinInfo(""compile iteration: ${sourcesToCompile.joinToString{ projectRelativePath(it) }}"")
++
++            val (exitCode, generatedFiles) = compileChanged(
++                    targets = targets,
++                    sourcesToCompile = sourcesToCompile,
++                    outputDir = outputDir,
++                    args = args,
++                    getIncrementalCache = ::getIncrementalCache,
++                    lookupTracker = lookupTracker)
++
++            allGeneratedFiles.addAll(generatedFiles)
++            // save versions?
++
++            val changes = updateIncrementalCaches(
++                    targets = targets,
++                    generatedFiles = generatedFiles,
++                    compiledWithErrors = exitCode != ExitCode.OK,
++                    getIncrementalCache = { caches[it]!! })
++
++//            lookupTracker.lookups.entrySet().forEach {
++//                logger.kotlinDebug(""lookups to ${it.key.name}:${it.key.scope} from ${it.value.joinToString { projectRelativePath(it) }}"")
++//            }
++
++            lookupStorage.update(lookupTracker, sourcesToCompile, currentRemoved)
++
++            allCachesVersions().forEach { it.saveIfNeeded() }","I believe saving versions should be after the loop.
+",2016-02-02 18:14:51
+507,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =
++            flatMap { lookup ->
++                val files = lookupStorage.get(lookup).map(::File).filter(filesFilter)
++                if (files.any()) {
++                    logAction(lookup, files)
++                }
++                files
++            }
++
++        fun dirtyLookupSymbolsFromRemovedKotlinFiles(): List<LookupSymbol> {
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            return if (removedKotlinFiles.isNotEmpty())
++                targets.flatMap { getIncrementalCache(it).classesBySources(removedKotlinFiles).map { LookupSymbol(it.fqNameForClassNameWithoutDollars.shortName().toString(), it.packageFqName.toString()) } }
++            else listOf()
++        }
++
++        fun dirtyLookupSymbolsFromModifiedJavaFiles(): List<LookupSymbol> {
++            val modifiedJavaFiles = modified.filter { it.isJavaFile() }
++            return (if (modifiedJavaFiles.any()) {
++                val rootDisposable = Disposer.newDisposable()
++                val configuration = CompilerConfiguration()
++                val environment = KotlinCoreEnvironment.createForProduction(rootDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
++                val project = environment.project
++                val psiFileFactory = PsiFileFactory.getInstance(project) as PsiFileFactoryImpl
++                modifiedJavaFiles.flatMap {
++                    val javaFile = psiFileFactory.createFileFromText(it.nameWithoutExtension, Language.findLanguageByID(""JAVA"")!!, it.readText())
++                    if (javaFile is PsiJavaFile)
++                        javaFile.classes.flatMap { it.findLookupSymbols() }
++                    else listOf()
++                }
++            } else listOf())
++        }
++
++        fun dirtyKotlinSourcesFromGradle(): List<File> {
++            // TODO: handle classpath changes similarly - compare with cashed version (likely a big change, may be costly, some heuristics could be considered)
++            val modifiedKotlinFiles = modified.filter { it.isKotlinFile() }
++            val lookupSymbols =
++                    dirtyLookupSymbolsFromModifiedJavaFiles() +
++                    dirtyLookupSymbolsFromRemovedKotlinFiles()
++                    // TODO: add dirty lookups from modified kotlin files to reduce number of steps needed
++
++            if (lookupSymbols.any()) {
++                val kotlinModifiedFilesSet = modifiedKotlinFiles.toHashSet()
++                return modifiedKotlinFiles +
++                        lookupSymbols.files(
++                                filesFilter = { it !in kotlinModifiedFilesSet },
++                                logAction = { lookup, files ->
++                                    logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                                })
++            }
++            return modifiedKotlinFiles
++        }
++
++        fun isClassPathChanged(): Boolean {
++            // TODO: that doesn't look to wise - join it first and then split here, consider storing it somewhere in between
++            val classpath = args.classpath.split(File.pathSeparator).map { File(it) }.toHashSet()
++            val changedClasspath = modified.filter { classpath.contains(it) }
++            return changedClasspath.any()
++        }
++
++        fun allCachesVersions() = allCachesVersions(cachesBaseDir, listOf(cachesBaseDir))
++
++        fun calculateSourcesToCompile(): Pair<List<File>, Boolean> {
++
++            if (!experimentalIncremental ||
++                    !isIncrementalRequested ||
++                    // TODO: more precise will be not to rebuild unconditionally on classpath changes, but retrieve lookup info and try to find out which sources are affected by cp changes
++                    isClassPathChanged() ||
++                    // so far considering it not incremental TODO: store java files in the cache and extract removed symbols from it here
++                    removed.any { it.isJavaFile() }
++            ) {
++                logger.kotlinInfo(if (!isIncrementalRequested) ""clean caches on rebuild"" else ""classpath changed, rebuilding all kotlin files"")
++                targets.forEach { getIncrementalCache(it).clean() }
++                lookupStorage.clean()
++                return Pair(sources, false)
++            }
++            val actions = if (isIncrementalRequested) allCachesVersions().map { it.checkVersion() }
++                          else listOf(CacheVersion.Action.REBUILD_ALL_KOTLIN)
++            // TODO: find out whether these flags should be emulated too
++//            val hasKotlin = HasKotlinMarker(dataManager)
++//            val rebuildAfterCacheVersionChanged = RebuildAfterCacheVersionChangeMarker(dataManager)
++
++            for (status in actions.distinct().sorted()) {
++                when (status) {
++                    CacheVersion.Action.REBUILD_ALL_KOTLIN -> {
++                        logger.kotlinInfo(""Kotlin global lookup map format changed, rebuilding all kotlin files"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                        lookupStorage.clean()
++                        return Pair(sources, false)
++                    }
++                    CacheVersion.Action.REBUILD_CHUNK -> {
++                        logger.kotlinInfo(""Clearing caches for "" + targets.joinToString { it.name })
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_NORMAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_EXPERIMENTAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing experimental caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).cleanExperimental() }
++                    }
++                    CacheVersion.Action.CLEAN_DATA_CONTAINER -> {
++                        logger.kotlinInfo(""Clearing lookup cache"")
++                        lookupStorage.clean()
++                        dataContainerCacheVersion(cachesBaseDir).clean()
++                    }
++                    else -> {
++                        assert(status == CacheVersion.Action.DO_NOTHING) { ""Unknown version status $status"" }
++                    }
++                }
++            }
++            val dirtyFiles = dirtyKotlinSourcesFromGradle().distinct()
++            // first dirty files should be found and only then caches cleared
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            targets.forEach { getIncrementalCache(it).let {
++                it.markOutputClassesDirty(removedKotlinFiles)
++                it.removeClassfilesBySources(removedKotlinFiles)
++            }}
++            return Pair(dirtyFiles, true)
++        }
++
++        fun cleanupOnError() {
++            val outputDirFile = File(args.destination!!)
++
++            assert(outputDirFile.exists())
++            val generatedRelPaths = allGeneratedFiles.map { it.outputFile.toRelativeString(outputDirFile) }
++            logger.kotlinInfo(""deleting output on error: ${generatedRelPaths.joinToString()}"")
++
++            allGeneratedFiles.forEach { it.outputFile.delete() }
++            generatedRelPaths.forEach { File(destinationDir, it).delete() }
++        }
++
++        fun processCompilerExitCode(exitCode: ExitCode) {
++            if (exitCode != ExitCode.OK) {
++                cleanupOnError()
++            }
++            when (exitCode) {
++                ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
++                ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
++                ExitCode.SCRIPT_EXECUTION_ERROR -> throw GradleException(""Script execution error. See log for more details"")
++                ExitCode.OK -> logger.kotlinInfo(""Compilation succeeded"")
++            }
++        }
++
++        fun outputRelativePath(f: File) = f.toRelativeString(outputDir)
++
++
++        if (!experimentalIncremental) {
++            anyClassesCompiled = true
++            processCompilerExitCode(compileNotIncremental(sources, outputDir, args))
++            return
++        }
++        logger.warn(""Using experimental kotlin incremental compilation"")
++
++        anyClassesCompiled = false
++
++        // TODO: decide what to do if no files are considered dirty - rebuild or skip the module
++        var (sourcesToCompile, isIncrementalDecided) = calculateSourcesToCompile()
++
++        if (isIncrementalDecided) {
++            // TODO: process as list here, merge into string later
++            args.classpath = args.classpath + File.pathSeparator + outputDir.absolutePath
++        }
++
++        while (sourcesToCompile.any()) {
++            logger.kotlinInfo(""compile iteration: ${sourcesToCompile.joinToString{ projectRelativePath(it) }}"")
++
++            val (exitCode, generatedFiles) = compileChanged(
++                    targets = targets,
++                    sourcesToCompile = sourcesToCompile,
++                    outputDir = outputDir,
++                    args = args,
++                    getIncrementalCache = ::getIncrementalCache,
++                    lookupTracker = lookupTracker)
++
++            allGeneratedFiles.addAll(generatedFiles)
++            // save versions?
++
++            val changes = updateIncrementalCaches(
++                    targets = targets,
++                    generatedFiles = generatedFiles,
++                    compiledWithErrors = exitCode != ExitCode.OK,
++                    getIncrementalCache = { caches[it]!! })
++
++//            lookupTracker.lookups.entrySet().forEach {
++//                logger.kotlinDebug(""lookups to ${it.key.name}:${it.key.scope} from ${it.value.joinToString { projectRelativePath(it) }}"")
++//            }
++
++            lookupStorage.update(lookupTracker, sourcesToCompile, currentRemoved)
++
++            allCachesVersions().forEach { it.saveIfNeeded() }
++
++            processCompilerExitCode(exitCode)
++
++            if (!isIncrementalDecided) break;
++
++//            logger.kotlinDebug(""generated ${generatedFiles.joinToString { outputRelativePath(it.outputFile) }}"")
++//            logger.kotlinDebug(""changes: ${changes.changes.joinToString { ""${it.fqName}: ${it.javaClass.simpleName}"" }}"")
++//
++//            logger.kotlinLazyDebug({
++//                ""known lookups:\n${lookupStorage.dump(changes.changes.flatMap {
++//                    change ->
++//                        if (change is ChangeInfo.MembersChanged)
++//                            change.names.asSequence().map { LookupSymbol(it, change.fqName.asString()) }
++//                        else
++//                            sequenceOf<LookupSymbol>()
++//                }.toSet(), project.projectDir)}"" })
++
++            compiledSourcesSet.addAll(sourcesToCompile)
++
++            val dirtyLookups = changes.dirtyLookups<TargetId>(caches.values.asSequence())
++
++//            logger.kotlinDebug(""dirty lookups: ${dirtyLookups.joinToString { ""${it.name}:${it.scope}"" }}"")
++
++            val dirty = dirtyLookups.files(
++                    filesFilter = { it !in compiledSourcesSet },
++                    logAction = { lookup, files ->
++                        logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                    })
++            sourcesToCompile = dirty.filter { it in sources }.toList()","Minor: `filter` returns list
+",2016-02-02 18:17:41
+508,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =
++            flatMap { lookup ->
++                val files = lookupStorage.get(lookup).map(::File).filter(filesFilter)
++                if (files.any()) {
++                    logAction(lookup, files)
++                }
++                files
++            }
++
++        fun dirtyLookupSymbolsFromRemovedKotlinFiles(): List<LookupSymbol> {
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            return if (removedKotlinFiles.isNotEmpty())
++                targets.flatMap { getIncrementalCache(it).classesBySources(removedKotlinFiles).map { LookupSymbol(it.fqNameForClassNameWithoutDollars.shortName().toString(), it.packageFqName.toString()) } }
++            else listOf()
++        }
++
++        fun dirtyLookupSymbolsFromModifiedJavaFiles(): List<LookupSymbol> {
++            val modifiedJavaFiles = modified.filter { it.isJavaFile() }
++            return (if (modifiedJavaFiles.any()) {
++                val rootDisposable = Disposer.newDisposable()
++                val configuration = CompilerConfiguration()
++                val environment = KotlinCoreEnvironment.createForProduction(rootDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
++                val project = environment.project
++                val psiFileFactory = PsiFileFactory.getInstance(project) as PsiFileFactoryImpl
++                modifiedJavaFiles.flatMap {
++                    val javaFile = psiFileFactory.createFileFromText(it.nameWithoutExtension, Language.findLanguageByID(""JAVA"")!!, it.readText())
++                    if (javaFile is PsiJavaFile)
++                        javaFile.classes.flatMap { it.findLookupSymbols() }
++                    else listOf()
++                }
++            } else listOf())
++        }
++
++        fun dirtyKotlinSourcesFromGradle(): List<File> {
++            // TODO: handle classpath changes similarly - compare with cashed version (likely a big change, may be costly, some heuristics could be considered)
++            val modifiedKotlinFiles = modified.filter { it.isKotlinFile() }
++            val lookupSymbols =
++                    dirtyLookupSymbolsFromModifiedJavaFiles() +
++                    dirtyLookupSymbolsFromRemovedKotlinFiles()
++                    // TODO: add dirty lookups from modified kotlin files to reduce number of steps needed
++
++            if (lookupSymbols.any()) {
++                val kotlinModifiedFilesSet = modifiedKotlinFiles.toHashSet()
++                return modifiedKotlinFiles +
++                        lookupSymbols.files(
++                                filesFilter = { it !in kotlinModifiedFilesSet },
++                                logAction = { lookup, files ->
++                                    logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                                })
++            }
++            return modifiedKotlinFiles
++        }
++
++        fun isClassPathChanged(): Boolean {
++            // TODO: that doesn't look to wise - join it first and then split here, consider storing it somewhere in between
++            val classpath = args.classpath.split(File.pathSeparator).map { File(it) }.toHashSet()
++            val changedClasspath = modified.filter { classpath.contains(it) }
++            return changedClasspath.any()
++        }
++
++        fun allCachesVersions() = allCachesVersions(cachesBaseDir, listOf(cachesBaseDir))
++
++        fun calculateSourcesToCompile(): Pair<List<File>, Boolean> {
++
++            if (!experimentalIncremental ||
++                    !isIncrementalRequested ||
++                    // TODO: more precise will be not to rebuild unconditionally on classpath changes, but retrieve lookup info and try to find out which sources are affected by cp changes
++                    isClassPathChanged() ||
++                    // so far considering it not incremental TODO: store java files in the cache and extract removed symbols from it here
++                    removed.any { it.isJavaFile() }
++            ) {
++                logger.kotlinInfo(if (!isIncrementalRequested) ""clean caches on rebuild"" else ""classpath changed, rebuilding all kotlin files"")
++                targets.forEach { getIncrementalCache(it).clean() }
++                lookupStorage.clean()
++                return Pair(sources, false)
++            }
++            val actions = if (isIncrementalRequested) allCachesVersions().map { it.checkVersion() }
++                          else listOf(CacheVersion.Action.REBUILD_ALL_KOTLIN)
++            // TODO: find out whether these flags should be emulated too
++//            val hasKotlin = HasKotlinMarker(dataManager)
++//            val rebuildAfterCacheVersionChanged = RebuildAfterCacheVersionChangeMarker(dataManager)
++
++            for (status in actions.distinct().sorted()) {
++                when (status) {
++                    CacheVersion.Action.REBUILD_ALL_KOTLIN -> {
++                        logger.kotlinInfo(""Kotlin global lookup map format changed, rebuilding all kotlin files"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                        lookupStorage.clean()
++                        return Pair(sources, false)
++                    }
++                    CacheVersion.Action.REBUILD_CHUNK -> {
++                        logger.kotlinInfo(""Clearing caches for "" + targets.joinToString { it.name })
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_NORMAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_EXPERIMENTAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing experimental caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).cleanExperimental() }
++                    }
++                    CacheVersion.Action.CLEAN_DATA_CONTAINER -> {
++                        logger.kotlinInfo(""Clearing lookup cache"")
++                        lookupStorage.clean()
++                        dataContainerCacheVersion(cachesBaseDir).clean()
++                    }
++                    else -> {
++                        assert(status == CacheVersion.Action.DO_NOTHING) { ""Unknown version status $status"" }
++                    }
++                }
++            }
++            val dirtyFiles = dirtyKotlinSourcesFromGradle().distinct()
++            // first dirty files should be found and only then caches cleared
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            targets.forEach { getIncrementalCache(it).let {
++                it.markOutputClassesDirty(removedKotlinFiles)
++                it.removeClassfilesBySources(removedKotlinFiles)
++            }}
++            return Pair(dirtyFiles, true)
++        }
++
++        fun cleanupOnError() {
++            val outputDirFile = File(args.destination!!)
++
++            assert(outputDirFile.exists())
++            val generatedRelPaths = allGeneratedFiles.map { it.outputFile.toRelativeString(outputDirFile) }
++            logger.kotlinInfo(""deleting output on error: ${generatedRelPaths.joinToString()}"")
++
++            allGeneratedFiles.forEach { it.outputFile.delete() }
++            generatedRelPaths.forEach { File(destinationDir, it).delete() }
++        }
++
++        fun processCompilerExitCode(exitCode: ExitCode) {
++            if (exitCode != ExitCode.OK) {
++                cleanupOnError()
++            }
++            when (exitCode) {
++                ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
++                ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
++                ExitCode.SCRIPT_EXECUTION_ERROR -> throw GradleException(""Script execution error. See log for more details"")
++                ExitCode.OK -> logger.kotlinInfo(""Compilation succeeded"")
++            }
++        }
++
++        fun outputRelativePath(f: File) = f.toRelativeString(outputDir)
++
++
++        if (!experimentalIncremental) {
++            anyClassesCompiled = true
++            processCompilerExitCode(compileNotIncremental(sources, outputDir, args))
++            return
++        }
++        logger.warn(""Using experimental kotlin incremental compilation"")
++
++        anyClassesCompiled = false
++
++        // TODO: decide what to do if no files are considered dirty - rebuild or skip the module
++        var (sourcesToCompile, isIncrementalDecided) = calculateSourcesToCompile()
++
++        if (isIncrementalDecided) {
++            // TODO: process as list here, merge into string later
++            args.classpath = args.classpath + File.pathSeparator + outputDir.absolutePath
++        }
++
++        while (sourcesToCompile.any()) {
++            logger.kotlinInfo(""compile iteration: ${sourcesToCompile.joinToString{ projectRelativePath(it) }}"")
++
++            val (exitCode, generatedFiles) = compileChanged(
++                    targets = targets,
++                    sourcesToCompile = sourcesToCompile,
++                    outputDir = outputDir,
++                    args = args,
++                    getIncrementalCache = ::getIncrementalCache,
++                    lookupTracker = lookupTracker)
++
++            allGeneratedFiles.addAll(generatedFiles)
++            // save versions?
++
++            val changes = updateIncrementalCaches(
++                    targets = targets,
++                    generatedFiles = generatedFiles,
++                    compiledWithErrors = exitCode != ExitCode.OK,
++                    getIncrementalCache = { caches[it]!! })
++
++//            lookupTracker.lookups.entrySet().forEach {
++//                logger.kotlinDebug(""lookups to ${it.key.name}:${it.key.scope} from ${it.value.joinToString { projectRelativePath(it) }}"")
++//            }
++
++            lookupStorage.update(lookupTracker, sourcesToCompile, currentRemoved)
++
++            allCachesVersions().forEach { it.saveIfNeeded() }
++
++            processCompilerExitCode(exitCode)
++
++            if (!isIncrementalDecided) break;
++
++//            logger.kotlinDebug(""generated ${generatedFiles.joinToString { outputRelativePath(it.outputFile) }}"")
++//            logger.kotlinDebug(""changes: ${changes.changes.joinToString { ""${it.fqName}: ${it.javaClass.simpleName}"" }}"")
++//
++//            logger.kotlinLazyDebug({
++//                ""known lookups:\n${lookupStorage.dump(changes.changes.flatMap {
++//                    change ->
++//                        if (change is ChangeInfo.MembersChanged)
++//                            change.names.asSequence().map { LookupSymbol(it, change.fqName.asString()) }
++//                        else
++//                            sequenceOf<LookupSymbol>()
++//                }.toSet(), project.projectDir)}"" })
++
++            compiledSourcesSet.addAll(sourcesToCompile)
++
++            val dirtyLookups = changes.dirtyLookups<TargetId>(caches.values.asSequence())
++
++//            logger.kotlinDebug(""dirty lookups: ${dirtyLookups.joinToString { ""${it.name}:${it.scope}"" }}"")
++
++            val dirty = dirtyLookups.files(
++                    filesFilter = { it !in compiledSourcesSet },
++                    logAction = { lookup, files ->
++                        logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                    })
++            sourcesToCompile = dirty.filter { it in sources }.toList()
++            if (currentRemoved.any()) {
++                currentRemoved = listOf()
++            }
++//            logger.kotlinDebug(""dirty: ${dirty.joinToString { projectRelativePath(it) }}"")
++//            logger.kotlinDebug(""to compile: ${sourcesToCompile.joinToString { projectRelativePath(it) }}"")
++        }
++        lookupStorage.flush(false)
++        lookupStorage.close()
++        caches.values.forEach { it.flush(false); it.close() }
++        if (allGeneratedFiles.isNotEmpty()) {
++            anyClassesCompiled = true
++        }
++    }
++
++    private data class CompileChangedResults(val exitCode: ExitCode, val generatedFiles: List<GeneratedFile<TargetId>>)
++
++    private fun compileChanged(targets: List<TargetId>,
++                               sourcesToCompile: List<File>,
++                               outputDir: File,
++                               args: K2JVMCompilerArguments,
++                               getIncrementalCache: (TargetId) -> GradleIncrementalCacheImpl,
++                               lookupTracker: LookupTracker)
++            : CompileChangedResults","Minor: formatting
+",2016-02-02 18:20:30
+509,"@@ -163,16 +217,341 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+         logger.kotlinDebug(""args.moduleName = ${args.moduleName}"")
+     }
+ 
++    override fun callCompiler(args: K2JVMCompilerArguments, sources: List<File>, isIncrementalRequested: Boolean, modified: List<File>, removed: List<File>, cachesBaseDir: File) {
++
++        if (experimentalIncremental) {
++            // TODO: consider other ways to pass incremental flag to compiler/builder
++            System.setProperty(""kotlin.incremental.compilation"", ""true"")
++            // TODO: experimental should be removed as soon as it becomes standard
++            System.setProperty(""kotlin.incremental.compilation.experimental"", ""true"")
++        }
++
++        val targetType = ""java-production""
++        val moduleName = args.moduleName
++        val targets = listOf(TargetId(moduleName, targetType))
++        val outputDir = File(args.destination)
++        val caches = hashMapOf<TargetId, GradleIncrementalCacheImpl>()
++        val lookupStorage = LookupStorage(File(cachesBaseDir, ""lookups""))
++        val lookupTracker = LookupTrackerImpl(LookupTracker.DO_NOTHING)
++        var currentRemoved = removed
++        val allGeneratedFiles = hashSetOf<GeneratedFile<TargetId>>()
++        val compiledSourcesSet = hashSetOf<File>()
++
++        fun getOrCreateIncrementalCache(target: TargetId): GradleIncrementalCacheImpl {
++            val cacheDir = File(cachesBaseDir, ""increCache.${target.name}"")
++            cacheDir.mkdirs()
++            return GradleIncrementalCacheImpl(targetDataRoot = cacheDir, targetOutputDir = outputDir, target = target)
++        }
++
++        fun getIncrementalCache(it: TargetId) = caches.getOrPut(it, { getOrCreateIncrementalCache(it) })
++
++        fun PsiClass.findLookupSymbols(): Iterable<LookupSymbol> {
++            val fqn = qualifiedName.orEmpty()
++            return listOf(LookupSymbol(name.orEmpty(), if (fqn == name) """" else fqn.removeSuffix(""."" + name!!))) +
++                    methods.map { LookupSymbol(it.name, fqn) } +
++                    fields.map { LookupSymbol(it.name.orEmpty(), fqn) } +
++                    innerClasses.flatMap { it.findLookupSymbols() }
++        }
++
++        fun Iterable<LookupSymbol>.files(filesFilter: (File) -> Boolean = { true }, logAction: (LookupSymbol, Iterable<File>) -> Unit = { l,fs -> }): Iterable<File> =
++            flatMap { lookup ->
++                val files = lookupStorage.get(lookup).map(::File).filter(filesFilter)
++                if (files.any()) {
++                    logAction(lookup, files)
++                }
++                files
++            }
++
++        fun dirtyLookupSymbolsFromRemovedKotlinFiles(): List<LookupSymbol> {
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            return if (removedKotlinFiles.isNotEmpty())
++                targets.flatMap { getIncrementalCache(it).classesBySources(removedKotlinFiles).map { LookupSymbol(it.fqNameForClassNameWithoutDollars.shortName().toString(), it.packageFqName.toString()) } }
++            else listOf()
++        }
++
++        fun dirtyLookupSymbolsFromModifiedJavaFiles(): List<LookupSymbol> {
++            val modifiedJavaFiles = modified.filter { it.isJavaFile() }
++            return (if (modifiedJavaFiles.any()) {
++                val rootDisposable = Disposer.newDisposable()
++                val configuration = CompilerConfiguration()
++                val environment = KotlinCoreEnvironment.createForProduction(rootDisposable, configuration, EnvironmentConfigFiles.JVM_CONFIG_FILES)
++                val project = environment.project
++                val psiFileFactory = PsiFileFactory.getInstance(project) as PsiFileFactoryImpl
++                modifiedJavaFiles.flatMap {
++                    val javaFile = psiFileFactory.createFileFromText(it.nameWithoutExtension, Language.findLanguageByID(""JAVA"")!!, it.readText())
++                    if (javaFile is PsiJavaFile)
++                        javaFile.classes.flatMap { it.findLookupSymbols() }
++                    else listOf()
++                }
++            } else listOf())
++        }
++
++        fun dirtyKotlinSourcesFromGradle(): List<File> {
++            // TODO: handle classpath changes similarly - compare with cashed version (likely a big change, may be costly, some heuristics could be considered)
++            val modifiedKotlinFiles = modified.filter { it.isKotlinFile() }
++            val lookupSymbols =
++                    dirtyLookupSymbolsFromModifiedJavaFiles() +
++                    dirtyLookupSymbolsFromRemovedKotlinFiles()
++                    // TODO: add dirty lookups from modified kotlin files to reduce number of steps needed
++
++            if (lookupSymbols.any()) {
++                val kotlinModifiedFilesSet = modifiedKotlinFiles.toHashSet()
++                return modifiedKotlinFiles +
++                        lookupSymbols.files(
++                                filesFilter = { it !in kotlinModifiedFilesSet },
++                                logAction = { lookup, files ->
++                                    logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                                })
++            }
++            return modifiedKotlinFiles
++        }
++
++        fun isClassPathChanged(): Boolean {
++            // TODO: that doesn't look to wise - join it first and then split here, consider storing it somewhere in between
++            val classpath = args.classpath.split(File.pathSeparator).map { File(it) }.toHashSet()
++            val changedClasspath = modified.filter { classpath.contains(it) }
++            return changedClasspath.any()
++        }
++
++        fun allCachesVersions() = allCachesVersions(cachesBaseDir, listOf(cachesBaseDir))
++
++        fun calculateSourcesToCompile(): Pair<List<File>, Boolean> {
++
++            if (!experimentalIncremental ||
++                    !isIncrementalRequested ||
++                    // TODO: more precise will be not to rebuild unconditionally on classpath changes, but retrieve lookup info and try to find out which sources are affected by cp changes
++                    isClassPathChanged() ||
++                    // so far considering it not incremental TODO: store java files in the cache and extract removed symbols from it here
++                    removed.any { it.isJavaFile() }
++            ) {
++                logger.kotlinInfo(if (!isIncrementalRequested) ""clean caches on rebuild"" else ""classpath changed, rebuilding all kotlin files"")
++                targets.forEach { getIncrementalCache(it).clean() }
++                lookupStorage.clean()
++                return Pair(sources, false)
++            }
++            val actions = if (isIncrementalRequested) allCachesVersions().map { it.checkVersion() }
++                          else listOf(CacheVersion.Action.REBUILD_ALL_KOTLIN)
++            // TODO: find out whether these flags should be emulated too
++//            val hasKotlin = HasKotlinMarker(dataManager)
++//            val rebuildAfterCacheVersionChanged = RebuildAfterCacheVersionChangeMarker(dataManager)
++
++            for (status in actions.distinct().sorted()) {
++                when (status) {
++                    CacheVersion.Action.REBUILD_ALL_KOTLIN -> {
++                        logger.kotlinInfo(""Kotlin global lookup map format changed, rebuilding all kotlin files"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                        lookupStorage.clean()
++                        return Pair(sources, false)
++                    }
++                    CacheVersion.Action.REBUILD_CHUNK -> {
++                        logger.kotlinInfo(""Clearing caches for "" + targets.joinToString { it.name })
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_NORMAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).clean() }
++                    }
++                    CacheVersion.Action.CLEAN_EXPERIMENTAL_CACHES -> {
++                        logger.kotlinInfo(""Clearing experimental caches for all targets"")
++                        targets.forEach { getIncrementalCache(it).cleanExperimental() }
++                    }
++                    CacheVersion.Action.CLEAN_DATA_CONTAINER -> {
++                        logger.kotlinInfo(""Clearing lookup cache"")
++                        lookupStorage.clean()
++                        dataContainerCacheVersion(cachesBaseDir).clean()
++                    }
++                    else -> {
++                        assert(status == CacheVersion.Action.DO_NOTHING) { ""Unknown version status $status"" }
++                    }
++                }
++            }
++            val dirtyFiles = dirtyKotlinSourcesFromGradle().distinct()
++            // first dirty files should be found and only then caches cleared
++            val removedKotlinFiles = removed.filter { it.isKotlinFile() }
++            targets.forEach { getIncrementalCache(it).let {
++                it.markOutputClassesDirty(removedKotlinFiles)
++                it.removeClassfilesBySources(removedKotlinFiles)
++            }}
++            return Pair(dirtyFiles, true)
++        }
++
++        fun cleanupOnError() {
++            val outputDirFile = File(args.destination!!)
++
++            assert(outputDirFile.exists())
++            val generatedRelPaths = allGeneratedFiles.map { it.outputFile.toRelativeString(outputDirFile) }
++            logger.kotlinInfo(""deleting output on error: ${generatedRelPaths.joinToString()}"")
++
++            allGeneratedFiles.forEach { it.outputFile.delete() }
++            generatedRelPaths.forEach { File(destinationDir, it).delete() }
++        }
++
++        fun processCompilerExitCode(exitCode: ExitCode) {
++            if (exitCode != ExitCode.OK) {
++                cleanupOnError()
++            }
++            when (exitCode) {
++                ExitCode.COMPILATION_ERROR -> throw GradleException(""Compilation error. See log for more details"")
++                ExitCode.INTERNAL_ERROR -> throw GradleException(""Internal compiler error. See log for more details"")
++                ExitCode.SCRIPT_EXECUTION_ERROR -> throw GradleException(""Script execution error. See log for more details"")
++                ExitCode.OK -> logger.kotlinInfo(""Compilation succeeded"")
++            }
++        }
++
++        fun outputRelativePath(f: File) = f.toRelativeString(outputDir)
++
++
++        if (!experimentalIncremental) {
++            anyClassesCompiled = true
++            processCompilerExitCode(compileNotIncremental(sources, outputDir, args))
++            return
++        }
++        logger.warn(""Using experimental kotlin incremental compilation"")
++
++        anyClassesCompiled = false
++
++        // TODO: decide what to do if no files are considered dirty - rebuild or skip the module
++        var (sourcesToCompile, isIncrementalDecided) = calculateSourcesToCompile()
++
++        if (isIncrementalDecided) {
++            // TODO: process as list here, merge into string later
++            args.classpath = args.classpath + File.pathSeparator + outputDir.absolutePath
++        }
++
++        while (sourcesToCompile.any()) {
++            logger.kotlinInfo(""compile iteration: ${sourcesToCompile.joinToString{ projectRelativePath(it) }}"")
++
++            val (exitCode, generatedFiles) = compileChanged(
++                    targets = targets,
++                    sourcesToCompile = sourcesToCompile,
++                    outputDir = outputDir,
++                    args = args,
++                    getIncrementalCache = ::getIncrementalCache,
++                    lookupTracker = lookupTracker)
++
++            allGeneratedFiles.addAll(generatedFiles)
++            // save versions?
++
++            val changes = updateIncrementalCaches(
++                    targets = targets,
++                    generatedFiles = generatedFiles,
++                    compiledWithErrors = exitCode != ExitCode.OK,
++                    getIncrementalCache = { caches[it]!! })
++
++//            lookupTracker.lookups.entrySet().forEach {
++//                logger.kotlinDebug(""lookups to ${it.key.name}:${it.key.scope} from ${it.value.joinToString { projectRelativePath(it) }}"")
++//            }
++
++            lookupStorage.update(lookupTracker, sourcesToCompile, currentRemoved)
++
++            allCachesVersions().forEach { it.saveIfNeeded() }
++
++            processCompilerExitCode(exitCode)
++
++            if (!isIncrementalDecided) break;
++
++//            logger.kotlinDebug(""generated ${generatedFiles.joinToString { outputRelativePath(it.outputFile) }}"")
++//            logger.kotlinDebug(""changes: ${changes.changes.joinToString { ""${it.fqName}: ${it.javaClass.simpleName}"" }}"")
++//
++//            logger.kotlinLazyDebug({
++//                ""known lookups:\n${lookupStorage.dump(changes.changes.flatMap {
++//                    change ->
++//                        if (change is ChangeInfo.MembersChanged)
++//                            change.names.asSequence().map { LookupSymbol(it, change.fqName.asString()) }
++//                        else
++//                            sequenceOf<LookupSymbol>()
++//                }.toSet(), project.projectDir)}"" })
++
++            compiledSourcesSet.addAll(sourcesToCompile)
++
++            val dirtyLookups = changes.dirtyLookups<TargetId>(caches.values.asSequence())
++
++//            logger.kotlinDebug(""dirty lookups: ${dirtyLookups.joinToString { ""${it.name}:${it.scope}"" }}"")
++
++            val dirty = dirtyLookups.files(
++                    filesFilter = { it !in compiledSourcesSet },
++                    logAction = { lookup, files ->
++                        logger.kotlinInfo(""changes in ${lookup.name} (${lookup.scope}) causes recompilation of ${files.joinToString { projectRelativePath(it) }}"")
++                    })
++            sourcesToCompile = dirty.filter { it in sources }.toList()
++            if (currentRemoved.any()) {
++                currentRemoved = listOf()
++            }
++//            logger.kotlinDebug(""dirty: ${dirty.joinToString { projectRelativePath(it) }}"")
++//            logger.kotlinDebug(""to compile: ${sourcesToCompile.joinToString { projectRelativePath(it) }}"")
++        }
++        lookupStorage.flush(false)
++        lookupStorage.close()
++        caches.values.forEach { it.flush(false); it.close() }
++        if (allGeneratedFiles.isNotEmpty()) {
++            anyClassesCompiled = true
++        }
++    }
++
++    private data class CompileChangedResults(val exitCode: ExitCode, val generatedFiles: List<GeneratedFile<TargetId>>)
++
++    private fun compileChanged(targets: List<TargetId>,
++                               sourcesToCompile: List<File>,
++                               outputDir: File,
++                               args: K2JVMCompilerArguments,
++                               getIncrementalCache: (TargetId) -> GradleIncrementalCacheImpl,
++                               lookupTracker: LookupTracker)
++            : CompileChangedResults
++    {
++        // show kotlin compiler where to look for java source files
++        args.freeArgs = (sourcesToCompile.map { it.absolutePath } + getJavaSourceRoots().map { it.absolutePath }).distinct()
++        args.destination = outputDir.absolutePath
++
++        logger.kotlinDebug(""compiling with args ${ArgumentUtils.convertArgumentsToStringList(args)}"")
++
++        val outputItemCollector = OutputItemsCollectorImpl()
++
++        val messageCollector = GradleMessageCollector(logger, outputItemCollector)
++
++        val incrementalCaches = makeIncrementalCachesMap(targets, { listOf<TargetId>() }, getIncrementalCache, { this })
++
++        val compilationCanceledStatus = object : CompilationCanceledStatus {
++            override fun checkCanceled() {}
++        }
++
++        logger.kotlinDebug(""compiling with args ${ArgumentUtils.convertArgumentsToStringList(args)}"")
++
++        val exitCode = compiler.exec(messageCollector, makeCompileServices(incrementalCaches, lookupTracker, compilationCanceledStatus), args)
++
++        return CompileChangedResults(
++                exitCode,
++                outputItemCollector.generatedFiles(
++                        targets = targets,
++                        representativeTarget = targets.first(),
++                        getSources = { sourcesToCompile },
++                        getOutputDir = { outputDir }))
++    }
++
++    private fun compileNotIncremental(sourcesToCompile: List<File>,
++                                      outputDir: File,
++                                      args: K2JVMCompilerArguments)
++            : ExitCode","Minor: formatting
+",2016-02-02 18:20:35
+905,"@@ -168,6 +168,20 @@ class CommonIntentionActionsTest : LightPlatformCodeInsightFixtureTestCase() {
+         """""".trim().trimMargin(), true)
+     }
+ 
++    fun testRemoveConstructorParameters() {
++        myFixture.configureByText(""foo.kt"", """"""
++        |class <caret>Foo(i: Int) {
++        |}
++        """""".trim().trimMargin())
++
++        myFixture.launchAction(codeModifications.createAddCallableMemberActions(MethodInsertionInfo.constructorInfo(
++                atCaret<UClass>(myFixture), makeParams())).findWithText(""Remove 1st parameter from method 'Foo'""))","It's better to change the intention text so that it says ""constructor"" and not ""method"".",2017-07-17 11:29:15
+472,"@@ -17,12 +17,22 @@
+ package org.jetbrains.kotlin.idea.compiler.configuration
+ 
+ import com.intellij.compiler.server.BuildProcessParametersProvider
++import org.jetbrains.kotlin.idea.PluginStartupComponent
+ 
+-public class KotlinBuildProcessParametersProvider(private val compilerWorkspaceSettings: KotlinCompilerWorkspaceSettings): BuildProcessParametersProvider() {
++public class KotlinBuildProcessParametersProvider(private val compilerWorkspaceSettings: KotlinCompilerWorkspaceSettings,
++                                                  private val kotlinPluginStartupComponent: PluginStartupComponent
++): BuildProcessParametersProvider() {
+     override fun getVMArguments(): MutableList<String> {
+-        return if (compilerWorkspaceSettings.incrementalCompilationEnabled)
+-            arrayListOf()
+-        else
+-            arrayListOf(""-Dkotlin.incremental.compilation=false"")
++        val res = arrayListOf<String>()
++        if (compilerWorkspaceSettings.incrementalCompilationEnabled) {","Is it ok that behavior changed?
+",2015-09-10 11:41:42
+490,"@@ -17,3 +17,11 @@
+ package org.jetbrains.kotlin.cli.common
+ 
+ public val KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY = ""kotlin.environment.keepalive""
++
++
++fun String?.toBooleanLenient(): Boolean? = when (this?.toLowerCase()) {","It seems it is possible to simplify conditional expressions by using the following function instead of `toBooleanLenient`
+
+```
+fun String.systemPropertyAsBooleanOrTrueOtherwise(negate: Boolean): Boolean {
+    val propValue = System.getProperty(this) ?: return true
+
+    return when (propValue.toLowerCase()) {
+        in listOf("""", ""yes"", ""true"", ""on"", ""y"") -> !negate
+        in listOf(""no"", ""false"", ""off"", ""n"") -> negate
+        else -> true
+    }
+}
+```
+
+See comments below.
+",2015-11-27 18:20:45
+280,"@@ -17,6 +17,7 @@
+ package kotlin
+ 
+ /**
+- * Nothing has no instances
++ * Nothing has no instances. You can use Nothing as the return type of a function to indicate
++ * that it never returns (always throws an exception).","There are more use-cases for Nothing, e.g. Iterable<Nothing> is ok to exist, but it will never enter ""for"" loop, etc. Needs link to lang docs.
+",2015-02-09 15:38:44
+668,"@@ -171,11 +171,21 @@ private val stdin: BufferedReader by lazy { BufferedReader(InputStreamReader(obj
+     public override fun read(b: ByteArray, off: Int, len: Int): Int {
+         return System.`in`.read(b, off, len)
+     }
+-}))}
++})}
+ 
+ /**
+  * Reads a line of input from the standard input stream.
+  *
+  * @return the line read or `null` if the input stream is redirected to a file and the end of file has been reached.
+  */
+-public fun readLine(): String? = stdin.readLine()
++public fun readLine(): String? {
++    tailrec fun readChars(oldBuffer: StringBuffer? = null): StringBuffer? {",Why do you choose `StringBuffer` instead of `StringBuilder`?,2016-12-28 17:03:12
+667,"@@ -171,11 +171,21 @@ private val stdin: BufferedReader by lazy { BufferedReader(InputStreamReader(obj
+     public override fun read(b: ByteArray, off: Int, len: Int): Int {
+         return System.`in`.read(b, off, len)
+     }
+-}))}
++})}
+ 
+ /**
+  * Reads a line of input from the standard input stream.
+  *
+  * @return the line read or `null` if the input stream is redirected to a file and the end of file has been reached.
+  */
+-public fun readLine(): String? = stdin.readLine()
++public fun readLine(): String? {
++    tailrec fun readChars(oldBuffer: StringBuffer? = null): StringBuffer? {
++        val c = mystdin.read()",What is `mystdin` here?,2016-12-28 17:02:31
+669,"@@ -171,11 +171,21 @@ private val stdin: BufferedReader by lazy { BufferedReader(InputStreamReader(obj
+     public override fun read(b: ByteArray, off: Int, len: Int): Int {
+         return System.`in`.read(b, off, len)
+     }
+-}))}
++})}
+ 
+ /**
+  * Reads a line of input from the standard input stream.
+  *
+  * @return the line read or `null` if the input stream is redirected to a file and the end of file has been reached.
+  */
+-public fun readLine(): String? = stdin.readLine()
++public fun readLine(): String? {
++    tailrec fun readChars(oldBuffer: StringBuffer? = null): StringBuffer? {
++        val c = mystdin.read()
++        if(c < 0) return oldBuffer
++        val buffer = oldBuffer ?: StringBuffer()
++        val ch = c.toChar()
++        if(ch == '\r' || ch == '\n') return buffer","We should support ""\n"" and ""\r\n"" line delimiters, and ""\r"" alone can be treated like a plain character.",2016-12-28 17:04:59
+670,"@@ -171,11 +171,21 @@ private val stdin: BufferedReader by lazy { BufferedReader(InputStreamReader(obj
+     public override fun read(b: ByteArray, off: Int, len: Int): Int {
+         return System.`in`.read(b, off, len)
+     }
+-}))}
++})}
+ 
+ /**
+  * Reads a line of input from the standard input stream.
+  *
+  * @return the line read or `null` if the input stream is redirected to a file and the end of file has been reached.
+  */
+-public fun readLine(): String? = stdin.readLine()
++public fun readLine(): String? {
++    tailrec fun readChars(oldBuffer: StringBuffer? = null): StringBuffer? {
++        val c = mystdin.read()
++        if(c < 0) return oldBuffer
++        val buffer = oldBuffer ?: StringBuffer()
++        val ch = c.toChar()
++        if(ch == '\r' || ch == '\n') return buffer
++        return readChars(buffer.append(ch))
++    }
++    return readChars()?.toString()
++}","Overall, `buildString` + imperative loop might be more clear than tail recursion approach.",2016-12-28 17:06:43
+266,"@@ -171,6 +138,36 @@ public open class KotlinCompile() : AbstractKotlinCompile<K2JVMCompilerArguments
+             FileUtils.copyDirectory(outputDirFile, getDestinationDir())
+         }
+     }
++
++    // override setSource to track source directory sets
++    override fun setSource(source: Any?) {
++        srcDirsSources.clear()
++        if (source is SourceDirectorySet) {
++            srcDirsSources.add(source)
++        }
++        super.setSource(source)
++    }
++
++    // override source to track source directory sets
++    override fun source(vararg sources: Any?): SourceTask? {
++        for (source in sources) {
++            if (source is SourceDirectorySet) {
++                srcDirsSources.add(source)
++            }
++        }
++        return super.source(sources)
++    }
++","SourceTask has ""protected final List<Object> source"" field from version 1.10 (or 1.11)
+",2014-12-26 14:23:23
+289,"@@ -1730,14 +1730,14 @@ public fun <T> Stream<T>.lastOrNull(): T? {
+ }
+ 
+ /**
+- * Returns last element, or null if collection is empty
++ * Returns the last character, or null if the string is empty
+  */
+ public fun String.lastOrNull(): Char? {
+     return if (isEmpty()) null else this[length() - 1]
+ }
+ 
+ /**
+- * Returns last element matching the given *predicate*, or null if element was not found
++ * Returns the last element matching the given [predicate], or *null* if no such element was found.","_null_ -> `null`
+",2015-02-09 15:48:49
+881,"@@ -175,6 +175,23 @@ class KotlinQuickDocumentationProvider : AbstractDocumentationProvider() {
+                 // element is not an KtReferenceExpression, but KtClass of enum
+                 return renderEnum(element, originalElement, quickNavigation)
+             }
++            else if (element is KtEnumEntry && !quickNavigation) {
++                val desc = element.resolveToDescriptorIfAny()
++                val ordinal =",It's better to calculate ordinal with `val ordinal = element.containingClassOrObject?.run { getChildrenOfType<KtEnumEntry>().indexOf(element) }`,2017-07-06 12:32:45
+934,"@@ -18,13 +18,15 @@ package org.jetbrains.kotlin.idea.quickfix
+ 
+ import com.intellij.openapi.editor.Editor
+ import com.intellij.openapi.project.Project
++import com.intellij.psi.util.PsiTreeUtil
+ import org.jetbrains.kotlin.diagnostics.Diagnostic
+ import org.jetbrains.kotlin.psi.KtFile
+ import org.jetbrains.kotlin.psi.KtIsExpression
+ import org.jetbrains.kotlin.psi.KtPsiFactory
++import org.jetbrains.kotlin.psi.KtWhenEntry
+ import org.jetbrains.kotlin.psi.psiUtil.getNonStrictParentOfType
+ 
+-class RemoveUselessIsCheckFix(element: KtIsExpression) : KotlinQuickFixAction<KtIsExpression>(element) {
++class RemoveUselessIsCheckFixForIf(element: KtIsExpression) : KotlinQuickFixAction<KtIsExpression>(element) {","Not a good name, may be it's better to leave it as before. This action is applicable also for when without subject, or just for code like `val a = b is Any`.",2017-07-26 15:01:15
+935,"@@ -18,18 +18,17 @@ package org.jetbrains.kotlin.idea.intentions
+ 
+ import com.intellij.openapi.editor.Editor
+ import org.jetbrains.kotlin.idea.core.replaced
+-import org.jetbrains.kotlin.psi.KtCallExpression
+-import org.jetbrains.kotlin.psi.KtDotQualifiedExpression
+-import org.jetbrains.kotlin.psi.KtPsiFactory
+-import org.jetbrains.kotlin.psi.createExpressionByPattern
++import org.jetbrains.kotlin.psi.*
+ import org.jetbrains.kotlin.psi.psiUtil.getStrictParentOfType
+ 
+ abstract class ReplaceMathMethodsWithKotlinNativeMethodsIntention(
+-        text: String, val replacedMethodName: String, val mathMethodName: String
++        text: String, private val replacedMethodName: String, private val mathMethodName: String
+ ) : SelfTargetingOffsetIndependentIntention<KtCallExpression>(KtCallExpression::class.java, text) {
+ 
+     override fun applyTo(element: KtCallExpression, editor: Editor?) {
+-        val target = element.getStrictParentOfType<KtDotQualifiedExpression>() ?: element
++        val target = element.getStrictParentOfType<KtDotQualifiedExpression>()?.takeIf {
++            (it.receiverExpression as? KtNameReferenceExpression)?.getReferencedName() == ""Math""
++        } ?: element","It's also not the best way, you can meet something like
+
+```
+Math.max(max(1, 3), max(2, 4))
+```
+
+and will have the same problem. Will fix it myself.",2017-07-26 16:51:40
+466,"@@ -18,246 +18,376 @@ package org.jetbrains.kotlin.rmi.kotlinr
+ 
+ import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
+ import org.jetbrains.kotlin.rmi.*
+-import java.io.File
+-import java.io.OutputStream
+-import java.io.PrintStream
++import java.io.*
+ import java.rmi.ConnectException
+-import java.rmi.Remote
+ import java.rmi.registry.LocateRegistry
+ import java.util.concurrent.Semaphore
+ import java.util.concurrent.TimeUnit
+ import kotlin.concurrent.thread
+ 
+-fun Process.isAlive() =
++
++public object KotlinCompilerClient {
++
++    val DAEMON_DEFAULT_STARTUP_TIMEOUT_MS = 10000L
++    val DAEMON_CONNECT_CYCLE_ATTEMPTS = 3
++
++
++    // TODO: remove jvmStatic after all use sites will switch to kotlin
++    jvmStatic
++    public fun connectToCompileService(compilerId: CompilerId,
++                                       daemonJVMOptions: DaemonJVMOptions,
++                                       daemonOptions: DaemonOptions,
++                                       reportingTargets: DaemonReportingTargets,
++                                       autostart: Boolean = true,
++                                       checkId: Boolean = true
++    ): CompileService? {
++
++        var attempts = 0
++        var fileLock: FileBasedLock? = null
+         try {
+-            this.exitValue()
+-            false
++            while (attempts++ < DAEMON_CONNECT_CYCLE_ATTEMPTS) {
++                val service = tryFindDaemon(File(daemonOptions.runFilesPath), compilerId, reportingTargets)
++                if (service != null) {
++                    if (!checkId || checkCompilerId(service, compilerId)) {
++                        reportingTargets.report(DaemonReportCategory.DEBUG, ""connected to the daemon"")
++                        return service
++                    }
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
++                    if (!autostart) return null
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""shutdown the daemon"")
++                    service.shutdown()
++                    // TODO: find more reliable way
++                    Thread.sleep(1000)
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""daemon shut down correctly, restarting search"")
++                }
++                else {
++                    if (!autostart) return null
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""no suitable daemon found, starting a new one"")
++                }
++
++                if (fileLock == null || !fileLock.isLocked()) {
++                    File(daemonOptions.runFilesPath).mkdirs()
++                    fileLock = FileBasedLock(compilerId, daemonOptions)
++                    // need to check the daemons again here, because of possible racing conditions
++                    // note: the algorithm could be simpler if we'll acquire lock right from the beginning, but it may be costly
++                    attempts--
++                }
++                else {
++                    startDaemon(compilerId, daemonJVMOptions, daemonOptions, reportingTargets)
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""daemon started, trying to resolve"")
++                }
++            }
+         }
+-        catch (e: IllegalThreadStateException) {
+-            true
++        catch (e: Exception) {
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, e.toString())
++        }
++        finally {
++            fileLock?.release()
+         }
++        return null
++    }
+ 
+-public class KotlinCompilerClient {
+ 
+-    companion object {
++    public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
++        KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, DaemonReportingTargets(out = System.out), autostart = false, checkId = false)
++                ?.shutdown()
++    }
+ 
+-        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
+ 
+-        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++    public fun shutdownCompileService(): Unit {
++        shutdownCompileService(DaemonOptions())
++    }
+ 
+-            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
+-            return compilerObj as? CompileService ?:
+-                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++
++    public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
++
++        val outStrm = RemoteOutputStreamServer(out)
++        try {
++            return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN, outStrm)
+         }
++        finally {
++            outStrm.disconnect()
++        }
++    }
+ 
+-        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
+-            try {
+-                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
+-                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
+-                if (daemon != null)
+-                    return daemon
+-                errStream.println(""[daemon client] daemon not found"")
+-            }
+-            catch (e: ConnectException) {
+-                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
+-                // ignoring it - processing below
+-            }
+-            return null
++
++    // TODO: remove jvmStatic after all use sites will switch to kotlin
++    jvmStatic
++    public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, compilerOut: OutputStream, daemonOut: OutputStream): Int {
++
++        val compilerOutStreamServer = RemoteOutputStreamServer(compilerOut)
++        val daemonOutStreamServer = RemoteOutputStreamServer(daemonOut)
++        val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++        try {
++            caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer(it.getValue()) })
++            return compiler.remoteIncrementalCompile(args, cacheServers, compilerOutStreamServer, CompileService.OutputFormat.XML, daemonOutStreamServer)
++        }
++        finally {
++            cacheServers.forEach { it.getValue().disconnect() }
++            compilerOutStreamServer.disconnect()
++            daemonOutStreamServer.disconnect()
+         }
++    }
+ 
+ 
+-        private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
+-            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
+-                val javaw = File(it, ""javaw.exe"")
+-                if (javaw.exists()) javaw
+-                else File(it, ""java"")
+-            }
+-            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
+-            val args = listOf(javaExecutable.absolutePath,
+-                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
+-                       daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
+-                       COMPILER_DAEMON_CLASS_FQN +
+-                       daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
+-                       compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
+-            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
+-            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
+-            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
+-            val daemon = processBuilder.start()
+-
+-            var isEchoRead = Semaphore(1)
+-            isEchoRead.acquire()
+-
+-            val stdoutThread =
+-                    thread {
+-                        daemon.getInputStream()
+-                              .reader()
+-                              .forEachLine {
+-                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
+-                                      isEchoRead.release()
+-                                      return@forEachLine
+-                                  }
+-                                  errStream.println(""[daemon] "" + it)
+-                              }
+-                    }
+-            try {
+-                // trying to wait for process
+-                if (daemonOptions.startEcho.isNotEmpty()) {
+-                    errStream.println(""[daemon client] waiting for daemon to respond"")
+-                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
+-                    if (!daemon.isAlive())
+-                        throw Exception(""Daemon terminated unexpectedly"")
+-                    if (!succeeded)
+-                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
+-                }
+-                else
+-                // without startEcho defined waiting for max timeout
+-                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
+-            }
+-            finally {
+-                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
+-                if (stdoutThread.isAlive)
+-                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
+-                    stdoutThread.stop()
++    data class ClientOptions(
++            public var stop: Boolean = false
++    ) : OptionsGroup {
++        override val mappers: List<PropMapper<*, *, *>>
++            get() = listOf(BoolPropMapper(this, ::stop))
++    }
++
++
++    jvmStatic public fun main(vararg args: String) {
++        val compilerId = CompilerId()
++        val daemonOptions = DaemonOptions()
++        val daemonLaunchingOptions = DaemonJVMOptions()
++        val clientOptions = ClientOptions()
++        val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
++
++        if (!clientOptions.stop) {
++            if (compilerId.compilerClasspath.none()) {
++                // attempt to find compiler to use
++                System.err.println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
++                System.getProperty(""java.class.path"")
++                        ?.split(File.pathSeparator)
++                        ?.map { File(it).parentFile }
++                        ?.distinct()
++                        ?.map {
++                            it?.walk()
++                                    ?.firstOrNull { it.name.equals(COMPILER_JAR_NAME, ignoreCase = true) }
++                        }
++                        ?.filterNotNull()
++                        ?.firstOrNull()
++                        ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
+             }
+-        }
++            if (compilerId.compilerClasspath.none())
++                throw IllegalArgumentException(""Cannot find compiler jar"")
++            else
++                println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
+ 
+-        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
+-            val remoteId = compiler.getCompilerId()
+-            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
+-            errStream.println(""[daemon client] localId = "" + localId.toString())
+-            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
+-                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
+-                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++            compilerId.updateDigest()
+         }
+ 
+-        public fun connectToCompileService(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
+-            val service = connectToService(compilerId, daemonOptions, errStream)
+-            if (service != null) {
+-                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
+-                    errStream.println(""[daemon client] found the suitable daemon"")
+-                    return service
+-                }
+-                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
+-                if (!autostart) return null;
+-                errStream.println(""[daemon client] shutdown the daemon"")
+-                service.shutdown()
+-                // TODO: find more reliable way
+-                Thread.sleep(1000)
+-                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++        val daemon = connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, DaemonReportingTargets(out = System.out), autostart = !clientOptions.stop, checkId = !clientOptions.stop)
++
++        if (daemon == null) {
++            if (clientOptions.stop) {
++                System.err.println(""No daemon found to shut down"")
+             }
+-            else {
+-                if (!autostart) return null;
+-                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            else throw Exception(""Unable to connect to daemon"")
++        }
++        else when {
++            clientOptions.stop -> {
++                println(""Shutdown the daemon"")
++                daemon.shutdown()
++                println(""Daemon shut down successfully"")
+             }
++            else -> {
++                println(""Executing daemon compilation with args: "" + filteredArgs.joinToString("" ""))
++                val outStrm = RemoteOutputStreamServer(System.out)
++                try {
++                    val memBefore = daemon.getUsedMemory() / 1024
++                    val startTime = System.nanoTime()
++
++                    val res = daemon.remoteCompile(filteredArgs.toArrayList().toTypedArray(), outStrm, CompileService.OutputFormat.PLAIN, outStrm)
+ 
+-            startDaemon(compilerId, daemonJVMOptions, daemonOptions, errStream)
+-            errStream.println(""[daemon client] daemon started, trying to connect"")
+-            return connectToService(compilerId, daemonOptions, errStream)
++                    val endTime = System.nanoTime()
++                    println(""Compilation result code: $res"")
++                    val memAfter = daemon.getUsedMemory() / 1024
++                    println(""Compilation time: "" + TimeUnit.NANOSECONDS.toMillis(endTime - startTime) + "" ms"")
++                    println(""Used memory $memAfter (${""%+d"".format(memAfter - memBefore)} kb)"")
++                }
++                finally {
++                    outStrm.disconnect()
++                }
++            }
+         }
++    }
+ 
+-        public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
+-            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, System.out, autostart = false, checkId = false)
+-                    ?.shutdown()
++    // --- Implementation ---------------------------------------
++
++    val verboseReporting = System.getProperty(COMPILE_DAEMON_VERBOSE_REPORT_PROPERTY) != null
++
++    fun DaemonReportingTargets.report(category: DaemonReportCategory, message: String, source: String = ""daemon client"") {
++        if (category == DaemonReportCategory.DEBUG && !verboseReporting) return
++        out?.println(""[$source] ${category.name()}: $message"")
++        messages?.add(DaemonReportMessage(category, ""[$source] $message""))
++    }
++
++    private fun tryFindDaemon(registryDir: File, compilerId: CompilerId, reportingTargets: DaemonReportingTargets): CompileService? {
++        val classPathDigest = compilerId.compilerClasspath.map { File(it).absolutePath }.distinctStringsDigest()
++        val daemons = registryDir.walk()
++                .map { Pair(it, makeRunFilenameRegex(digest = classPathDigest, port = ""(\\d+)"").match(it.name)?.groups?.get(1)?.value?.toInt() ?: 0) }
++                .filter { it.second != 0 }
++                .map {
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""found suitable daemon on port ${it.second}, trying to connect"")
++                    val daemon = tryConnectToDaemon(it.second, reportingTargets)
++                    // cleaning orphaned file; note: daemon should shut itself down if it detects that the run file is deleted
++                    if (daemon == null && !it.first.delete()) {
++                        reportingTargets.report(DaemonReportCategory.INFO, ""WARNING: unable to delete seemingly orphaned file '${it.first.absolutePath}', cleanup recommended"")
++                    }
++                    daemon
++                }
++                .filterNotNull()
++                .toList()
++        return when (daemons.size()) {
++            0 -> null
++            1 -> daemons.first()
++            else -> throw IllegalStateException(""Multiple daemons serving the same compiler, reset with the cleanup required"")
++        // TODO: consider implementing automatic recovery instead, e.g. getting the youngest or least used daemon and shut down others
+         }
++    }
+ 
+-        public fun shutdownCompileService(): Unit {
+-            shutdownCompileService(DaemonOptions())
++    private fun tryConnectToDaemon(port: Int, reportingTargets: DaemonReportingTargets): CompileService? {
++        try {
++            val daemon = LocateRegistry.getRegistry(loopbackAddrName, port)
++                    ?.lookup(COMPILER_SERVICE_RMI_NAME)
++            if (daemon != null)
++                return daemon as? CompileService ?:
++                       throw ClassCastException(""Unable to cast compiler service, actual class received: ${daemon.javaClass}"")
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, ""daemon not found"")
++        }
++        catch (e: ConnectException) {
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, ""cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++            // ignoring it - processing below
+         }
++        return null
++    }
+ 
+-        public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
+ 
+-            val outStrm = RemoteOutputStreamServer(out)
+-            try {
+-                return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN)
+-            }
+-            finally {
+-                outStrm.disconnect()
+-            }
++    private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, reportingTargets: DaemonReportingTargets) {
++        val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++            val javaw = File(it, ""javaw.exe"")
++            // TODO: doesn't seem reliable enough, consider more checks if OS is of windows flavor, etc.
++            if (javaw.exists() && javaw.isFile && javaw.canExecute()) javaw else File(it, ""java"")
+         }
++        val args = listOf(javaExecutable.absolutePath,
++                          ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                   daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
++                   COMPILER_DAEMON_CLASS_FQN +
++                   daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                   compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++        reportingTargets.report(DaemonReportCategory.DEBUG, ""starting the daemon as: "" + args.joinToString("" ""))
++        val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++        // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++        val daemon = processBuilder.start()
+ 
+-        public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++        var isEchoRead = Semaphore(1)
++        isEchoRead.acquire()
+ 
+-            val outStrm = RemoteOutputStreamServer(out)
+-            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
+-            try {
+-                caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer( it.getValue()) })
+-                return compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++        val stdoutThread =
++                thread {
++                    daemon.inputStream
++                            .reader()
++                            .forEachLine {
++                                if (daemonOptions.runFilesPath.isNotEmpty() && it.contains(daemonOptions.runFilesPath)) {
++                                    isEchoRead.release()
++                                    return@forEachLine
++                                }
++                                reportingTargets.report(DaemonReportCategory.DEBUG, it, ""daemon"")
++                            }
++                }
++        try {
++            // trying to wait for process
++            val daemonStartupTimeout = System.getProperty(COMPILE_DAEMON_STARTUP_TIMEOUT_PROPERTY)?.let {
++                try {
++                    it.toLong()
++                }
++                catch (e: Exception) {
++                    reportingTargets.report(DaemonReportCategory.INFO, ""unable to interpret $COMPILE_DAEMON_STARTUP_TIMEOUT_PROPERTY property ('$it'); using default timeout $DAEMON_DEFAULT_STARTUP_TIMEOUT_MS ms"")
++                    null
++                }
++            } ?: DAEMON_DEFAULT_STARTUP_TIMEOUT_MS
++            if (daemonOptions.runFilesPath.isNotEmpty()) {
++                val succeeded = isEchoRead.tryAcquire(daemonStartupTimeout, TimeUnit.MILLISECONDS)
++                if (!daemon.isAlive())
++                    throw Exception(""Daemon terminated unexpectedly"")
++                if (!succeeded)
++                    throw Exception(""Unable to get response from daemon in $daemonStartupTimeout ms"")
+             }
+-            finally {
+-                cacheServers.forEach { it.getValue().disconnect() }
+-                outStrm.disconnect()
++            else
++            // without startEcho defined waiting for max timeout
++                Thread.sleep(daemonStartupTimeout)
++        }
++        finally {
++            // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++            if (stdoutThread.isAlive) {
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                stdoutThread.stop()
+             }
+         }
++    }
+ 
+-        data class ClientOptions(
+-                public var stop: Boolean = false
+-        ) : OptionsGroup {
+-            override val mappers: List<PropMapper<*, *, *>>
+-                get() = listOf( BoolPropMapper(this, ::stop))
+-        }
+ 
+-        jvmStatic public fun main(vararg args: String) {
+-            val compilerId = CompilerId()
+-            val daemonOptions = DaemonOptions()
+-            val daemonLaunchingOptions = DaemonJVMOptions()
+-            val clientOptions = ClientOptions()
+-            val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
+-
+-            if (!clientOptions.stop) {
+-                if (compilerId.compilerClasspath.none()) {
+-                    // attempt to find compiler to use
+-                    println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
+-                    System.getProperty(""java.class.path"")
+-                            ?.split(File.pathSeparator)
+-                            ?.map { File(it).parent }
+-                            ?.distinct()
+-                            ?.map {
+-                                it?.walk()
+-                                        ?.firstOrNull { it.getName().equals(COMPILER_JAR_NAME, ignoreCase = true) }
+-                            }
+-                            ?.filterNotNull()
+-                            ?.firstOrNull()
+-                            ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
+-                }
+-                if (compilerId.compilerClasspath.none())
+-                    throw IllegalArgumentException(""Cannot find compiler jar"")
+-                else
+-                    println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
++    private fun checkCompilerId(compiler: CompileService, localId: CompilerId): Boolean {
++        val remoteId = compiler.getCompilerId()
++        return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++               (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++               (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++    }
+ 
+-                compilerId.updateDigest()
++
++    class FileBasedLock(compilerId: CompilerId, daemonOptions: DaemonOptions) {
++        private val lockFile: File =
++                File(daemonOptions.runFilesPath,","do we need to keep them in home dir? can we use tempdir instead to eliminate possible issues caused by NFS-backed homedir, etc ?
+",2015-09-08 17:58:11
+467,"@@ -18,246 +18,376 @@ package org.jetbrains.kotlin.rmi.kotlinr
+ 
+ import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
+ import org.jetbrains.kotlin.rmi.*
+-import java.io.File
+-import java.io.OutputStream
+-import java.io.PrintStream
++import java.io.*
+ import java.rmi.ConnectException
+-import java.rmi.Remote
+ import java.rmi.registry.LocateRegistry
+ import java.util.concurrent.Semaphore
+ import java.util.concurrent.TimeUnit
+ import kotlin.concurrent.thread
+ 
+-fun Process.isAlive() =
++
++public object KotlinCompilerClient {
++
++    val DAEMON_DEFAULT_STARTUP_TIMEOUT_MS = 10000L
++    val DAEMON_CONNECT_CYCLE_ATTEMPTS = 3
++
++
++    // TODO: remove jvmStatic after all use sites will switch to kotlin
++    jvmStatic
++    public fun connectToCompileService(compilerId: CompilerId,
++                                       daemonJVMOptions: DaemonJVMOptions,
++                                       daemonOptions: DaemonOptions,
++                                       reportingTargets: DaemonReportingTargets,
++                                       autostart: Boolean = true,
++                                       checkId: Boolean = true
++    ): CompileService? {
++
++        var attempts = 0
++        var fileLock: FileBasedLock? = null
+         try {
+-            this.exitValue()
+-            false
++            while (attempts++ < DAEMON_CONNECT_CYCLE_ATTEMPTS) {
++                val service = tryFindDaemon(File(daemonOptions.runFilesPath), compilerId, reportingTargets)
++                if (service != null) {
++                    if (!checkId || checkCompilerId(service, compilerId)) {
++                        reportingTargets.report(DaemonReportCategory.DEBUG, ""connected to the daemon"")
++                        return service
++                    }
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
++                    if (!autostart) return null
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""shutdown the daemon"")
++                    service.shutdown()
++                    // TODO: find more reliable way
++                    Thread.sleep(1000)
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""daemon shut down correctly, restarting search"")
++                }
++                else {
++                    if (!autostart) return null
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""no suitable daemon found, starting a new one"")
++                }
++
++                if (fileLock == null || !fileLock.isLocked()) {
++                    File(daemonOptions.runFilesPath).mkdirs()
++                    fileLock = FileBasedLock(compilerId, daemonOptions)
++                    // need to check the daemons again here, because of possible racing conditions
++                    // note: the algorithm could be simpler if we'll acquire lock right from the beginning, but it may be costly
++                    attempts--
++                }
++                else {
++                    startDaemon(compilerId, daemonJVMOptions, daemonOptions, reportingTargets)
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""daemon started, trying to resolve"")
++                }
++            }
+         }
+-        catch (e: IllegalThreadStateException) {
+-            true
++        catch (e: Exception) {
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, e.toString())
++        }
++        finally {
++            fileLock?.release()
+         }
++        return null
++    }
+ 
+-public class KotlinCompilerClient {
+ 
+-    companion object {
++    public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
++        KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, DaemonReportingTargets(out = System.out), autostart = false, checkId = false)
++                ?.shutdown()
++    }
+ 
+-        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
+ 
+-        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++    public fun shutdownCompileService(): Unit {
++        shutdownCompileService(DaemonOptions())
++    }
+ 
+-            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
+-            return compilerObj as? CompileService ?:
+-                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++
++    public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
++
++        val outStrm = RemoteOutputStreamServer(out)
++        try {
++            return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN, outStrm)
+         }
++        finally {
++            outStrm.disconnect()
++        }
++    }
+ 
+-        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
+-            try {
+-                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
+-                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
+-                if (daemon != null)
+-                    return daemon
+-                errStream.println(""[daemon client] daemon not found"")
+-            }
+-            catch (e: ConnectException) {
+-                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
+-                // ignoring it - processing below
+-            }
+-            return null
++
++    // TODO: remove jvmStatic after all use sites will switch to kotlin
++    jvmStatic
++    public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, compilerOut: OutputStream, daemonOut: OutputStream): Int {
++
++        val compilerOutStreamServer = RemoteOutputStreamServer(compilerOut)
++        val daemonOutStreamServer = RemoteOutputStreamServer(daemonOut)
++        val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++        try {
++            caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer(it.getValue()) })
++            return compiler.remoteIncrementalCompile(args, cacheServers, compilerOutStreamServer, CompileService.OutputFormat.XML, daemonOutStreamServer)
++        }
++        finally {
++            cacheServers.forEach { it.getValue().disconnect() }
++            compilerOutStreamServer.disconnect()
++            daemonOutStreamServer.disconnect()
+         }
++    }
+ 
+ 
+-        private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
+-            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
+-                val javaw = File(it, ""javaw.exe"")
+-                if (javaw.exists()) javaw
+-                else File(it, ""java"")
+-            }
+-            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
+-            val args = listOf(javaExecutable.absolutePath,
+-                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
+-                       daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
+-                       COMPILER_DAEMON_CLASS_FQN +
+-                       daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
+-                       compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
+-            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
+-            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
+-            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
+-            val daemon = processBuilder.start()
+-
+-            var isEchoRead = Semaphore(1)
+-            isEchoRead.acquire()
+-
+-            val stdoutThread =
+-                    thread {
+-                        daemon.getInputStream()
+-                              .reader()
+-                              .forEachLine {
+-                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
+-                                      isEchoRead.release()
+-                                      return@forEachLine
+-                                  }
+-                                  errStream.println(""[daemon] "" + it)
+-                              }
+-                    }
+-            try {
+-                // trying to wait for process
+-                if (daemonOptions.startEcho.isNotEmpty()) {
+-                    errStream.println(""[daemon client] waiting for daemon to respond"")
+-                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
+-                    if (!daemon.isAlive())
+-                        throw Exception(""Daemon terminated unexpectedly"")
+-                    if (!succeeded)
+-                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
+-                }
+-                else
+-                // without startEcho defined waiting for max timeout
+-                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
+-            }
+-            finally {
+-                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
+-                if (stdoutThread.isAlive)
+-                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
+-                    stdoutThread.stop()
++    data class ClientOptions(
++            public var stop: Boolean = false
++    ) : OptionsGroup {
++        override val mappers: List<PropMapper<*, *, *>>
++            get() = listOf(BoolPropMapper(this, ::stop))
++    }
++
++
++    jvmStatic public fun main(vararg args: String) {
++        val compilerId = CompilerId()
++        val daemonOptions = DaemonOptions()
++        val daemonLaunchingOptions = DaemonJVMOptions()
++        val clientOptions = ClientOptions()
++        val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
++
++        if (!clientOptions.stop) {
++            if (compilerId.compilerClasspath.none()) {
++                // attempt to find compiler to use
++                System.err.println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
++                System.getProperty(""java.class.path"")
++                        ?.split(File.pathSeparator)
++                        ?.map { File(it).parentFile }
++                        ?.distinct()
++                        ?.map {
++                            it?.walk()
++                                    ?.firstOrNull { it.name.equals(COMPILER_JAR_NAME, ignoreCase = true) }
++                        }
++                        ?.filterNotNull()
++                        ?.firstOrNull()
++                        ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
+             }
+-        }
++            if (compilerId.compilerClasspath.none())
++                throw IllegalArgumentException(""Cannot find compiler jar"")
++            else
++                println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
+ 
+-        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
+-            val remoteId = compiler.getCompilerId()
+-            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
+-            errStream.println(""[daemon client] localId = "" + localId.toString())
+-            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
+-                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
+-                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++            compilerId.updateDigest()
+         }
+ 
+-        public fun connectToCompileService(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
+-            val service = connectToService(compilerId, daemonOptions, errStream)
+-            if (service != null) {
+-                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
+-                    errStream.println(""[daemon client] found the suitable daemon"")
+-                    return service
+-                }
+-                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
+-                if (!autostart) return null;
+-                errStream.println(""[daemon client] shutdown the daemon"")
+-                service.shutdown()
+-                // TODO: find more reliable way
+-                Thread.sleep(1000)
+-                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++        val daemon = connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, DaemonReportingTargets(out = System.out), autostart = !clientOptions.stop, checkId = !clientOptions.stop)
++
++        if (daemon == null) {
++            if (clientOptions.stop) {
++                System.err.println(""No daemon found to shut down"")
+             }
+-            else {
+-                if (!autostart) return null;
+-                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            else throw Exception(""Unable to connect to daemon"")
++        }
++        else when {
++            clientOptions.stop -> {
++                println(""Shutdown the daemon"")
++                daemon.shutdown()
++                println(""Daemon shut down successfully"")
+             }
++            else -> {
++                println(""Executing daemon compilation with args: "" + filteredArgs.joinToString("" ""))
++                val outStrm = RemoteOutputStreamServer(System.out)
++                try {
++                    val memBefore = daemon.getUsedMemory() / 1024
++                    val startTime = System.nanoTime()
++
++                    val res = daemon.remoteCompile(filteredArgs.toArrayList().toTypedArray(), outStrm, CompileService.OutputFormat.PLAIN, outStrm)
+ 
+-            startDaemon(compilerId, daemonJVMOptions, daemonOptions, errStream)
+-            errStream.println(""[daemon client] daemon started, trying to connect"")
+-            return connectToService(compilerId, daemonOptions, errStream)
++                    val endTime = System.nanoTime()
++                    println(""Compilation result code: $res"")
++                    val memAfter = daemon.getUsedMemory() / 1024
++                    println(""Compilation time: "" + TimeUnit.NANOSECONDS.toMillis(endTime - startTime) + "" ms"")
++                    println(""Used memory $memAfter (${""%+d"".format(memAfter - memBefore)} kb)"")
++                }
++                finally {
++                    outStrm.disconnect()
++                }
++            }
+         }
++    }
+ 
+-        public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
+-            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, System.out, autostart = false, checkId = false)
+-                    ?.shutdown()
++    // --- Implementation ---------------------------------------
++
++    val verboseReporting = System.getProperty(COMPILE_DAEMON_VERBOSE_REPORT_PROPERTY) != null
++
++    fun DaemonReportingTargets.report(category: DaemonReportCategory, message: String, source: String = ""daemon client"") {
++        if (category == DaemonReportCategory.DEBUG && !verboseReporting) return
++        out?.println(""[$source] ${category.name()}: $message"")
++        messages?.add(DaemonReportMessage(category, ""[$source] $message""))
++    }
++
++    private fun tryFindDaemon(registryDir: File, compilerId: CompilerId, reportingTargets: DaemonReportingTargets): CompileService? {
++        val classPathDigest = compilerId.compilerClasspath.map { File(it).absolutePath }.distinctStringsDigest()
++        val daemons = registryDir.walk()
++                .map { Pair(it, makeRunFilenameRegex(digest = classPathDigest, port = ""(\\d+)"").match(it.name)?.groups?.get(1)?.value?.toInt() ?: 0) }
++                .filter { it.second != 0 }
++                .map {
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""found suitable daemon on port ${it.second}, trying to connect"")
++                    val daemon = tryConnectToDaemon(it.second, reportingTargets)
++                    // cleaning orphaned file; note: daemon should shut itself down if it detects that the run file is deleted
++                    if (daemon == null && !it.first.delete()) {
++                        reportingTargets.report(DaemonReportCategory.INFO, ""WARNING: unable to delete seemingly orphaned file '${it.first.absolutePath}', cleanup recommended"")
++                    }
++                    daemon
++                }
++                .filterNotNull()
++                .toList()
++        return when (daemons.size()) {
++            0 -> null
++            1 -> daemons.first()
++            else -> throw IllegalStateException(""Multiple daemons serving the same compiler, reset with the cleanup required"")
++        // TODO: consider implementing automatic recovery instead, e.g. getting the youngest or least used daemon and shut down others
+         }
++    }
+ 
+-        public fun shutdownCompileService(): Unit {
+-            shutdownCompileService(DaemonOptions())
++    private fun tryConnectToDaemon(port: Int, reportingTargets: DaemonReportingTargets): CompileService? {
++        try {
++            val daemon = LocateRegistry.getRegistry(loopbackAddrName, port)
++                    ?.lookup(COMPILER_SERVICE_RMI_NAME)
++            if (daemon != null)
++                return daemon as? CompileService ?:
++                       throw ClassCastException(""Unable to cast compiler service, actual class received: ${daemon.javaClass}"")
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, ""daemon not found"")
++        }
++        catch (e: ConnectException) {
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, ""cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++            // ignoring it - processing below
+         }
++        return null
++    }
+ 
+-        public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
+ 
+-            val outStrm = RemoteOutputStreamServer(out)
+-            try {
+-                return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN)
+-            }
+-            finally {
+-                outStrm.disconnect()
+-            }
++    private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, reportingTargets: DaemonReportingTargets) {
++        val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++            val javaw = File(it, ""javaw.exe"")
++            // TODO: doesn't seem reliable enough, consider more checks if OS is of windows flavor, etc.
++            if (javaw.exists() && javaw.isFile && javaw.canExecute()) javaw else File(it, ""java"")
+         }
++        val args = listOf(javaExecutable.absolutePath,
++                          ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                   daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
++                   COMPILER_DAEMON_CLASS_FQN +
++                   daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                   compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++        reportingTargets.report(DaemonReportCategory.DEBUG, ""starting the daemon as: "" + args.joinToString("" ""))
++        val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++        // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++        val daemon = processBuilder.start()
+ 
+-        public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++        var isEchoRead = Semaphore(1)
++        isEchoRead.acquire()
+ 
+-            val outStrm = RemoteOutputStreamServer(out)
+-            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
+-            try {
+-                caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer( it.getValue()) })
+-                return compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++        val stdoutThread =
++                thread {
++                    daemon.inputStream
++                            .reader()
++                            .forEachLine {
++                                if (daemonOptions.runFilesPath.isNotEmpty() && it.contains(daemonOptions.runFilesPath)) {
++                                    isEchoRead.release()
++                                    return@forEachLine
++                                }
++                                reportingTargets.report(DaemonReportCategory.DEBUG, it, ""daemon"")
++                            }
++                }
++        try {
++            // trying to wait for process
++            val daemonStartupTimeout = System.getProperty(COMPILE_DAEMON_STARTUP_TIMEOUT_PROPERTY)?.let {
++                try {
++                    it.toLong()
++                }
++                catch (e: Exception) {
++                    reportingTargets.report(DaemonReportCategory.INFO, ""unable to interpret $COMPILE_DAEMON_STARTUP_TIMEOUT_PROPERTY property ('$it'); using default timeout $DAEMON_DEFAULT_STARTUP_TIMEOUT_MS ms"")
++                    null
++                }
++            } ?: DAEMON_DEFAULT_STARTUP_TIMEOUT_MS
++            if (daemonOptions.runFilesPath.isNotEmpty()) {
++                val succeeded = isEchoRead.tryAcquire(daemonStartupTimeout, TimeUnit.MILLISECONDS)
++                if (!daemon.isAlive())
++                    throw Exception(""Daemon terminated unexpectedly"")
++                if (!succeeded)
++                    throw Exception(""Unable to get response from daemon in $daemonStartupTimeout ms"")
+             }
+-            finally {
+-                cacheServers.forEach { it.getValue().disconnect() }
+-                outStrm.disconnect()
++            else
++            // without startEcho defined waiting for max timeout
++                Thread.sleep(daemonStartupTimeout)
++        }
++        finally {
++            // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++            if (stdoutThread.isAlive) {
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                stdoutThread.stop()
+             }
+         }
++    }
+ 
+-        data class ClientOptions(
+-                public var stop: Boolean = false
+-        ) : OptionsGroup {
+-            override val mappers: List<PropMapper<*, *, *>>
+-                get() = listOf( BoolPropMapper(this, ::stop))
+-        }
+ 
+-        jvmStatic public fun main(vararg args: String) {
+-            val compilerId = CompilerId()
+-            val daemonOptions = DaemonOptions()
+-            val daemonLaunchingOptions = DaemonJVMOptions()
+-            val clientOptions = ClientOptions()
+-            val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
+-
+-            if (!clientOptions.stop) {
+-                if (compilerId.compilerClasspath.none()) {
+-                    // attempt to find compiler to use
+-                    println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
+-                    System.getProperty(""java.class.path"")
+-                            ?.split(File.pathSeparator)
+-                            ?.map { File(it).parent }
+-                            ?.distinct()
+-                            ?.map {
+-                                it?.walk()
+-                                        ?.firstOrNull { it.getName().equals(COMPILER_JAR_NAME, ignoreCase = true) }
+-                            }
+-                            ?.filterNotNull()
+-                            ?.firstOrNull()
+-                            ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
+-                }
+-                if (compilerId.compilerClasspath.none())
+-                    throw IllegalArgumentException(""Cannot find compiler jar"")
+-                else
+-                    println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
++    private fun checkCompilerId(compiler: CompileService, localId: CompilerId): Boolean {
++        val remoteId = compiler.getCompilerId()
++        return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++               (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++               (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++    }
+ 
+-                compilerId.updateDigest()
++
++    class FileBasedLock(compilerId: CompilerId, daemonOptions: DaemonOptions) {
++        private val lockFile: File =
++                File(daemonOptions.runFilesPath,
++                     makeRunFilenameString(ts = ""lock"",
++                                           digest = compilerId.compilerClasspath.map { File(it).absolutePath }.distinctStringsDigest(),
++                                           port = ""0""))
++
++        private var locked: Boolean = acquireLockFile(lockFile)
++
++        public fun isLocked(): Boolean = locked
++
++        synchronized public fun release(): Unit {
++            if (locked) {
++                lock?.release()
++                channel?.close()
++                lockFile.delete()
++                locked = false
+             }
++        }
+ 
+-            val daemon = connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, System.out, autostart = !clientOptions.stop, checkId = !clientOptions.stop)
++        private val channel = if (locked) RandomAccessFile(lockFile, ""rw"").channel else null
++        private val lock = channel?.lock()
+ 
+-            if (daemon == null) {
+-                if (clientOptions.stop) println(""No daemon found to shut down"")
+-                else throw Exception(""Unable to connect to daemon"")
++        synchronized private fun acquireLockFile(lockFile: File): Boolean {","~~Why do we have `:Boolean` function that always returns `true` ?~~
+I see, sorry
+",2015-09-08 18:01:00
+468,"@@ -18,246 +18,376 @@ package org.jetbrains.kotlin.rmi.kotlinr
+ 
+ import org.jetbrains.kotlin.load.kotlin.incremental.components.IncrementalCache
+ import org.jetbrains.kotlin.rmi.*
+-import java.io.File
+-import java.io.OutputStream
+-import java.io.PrintStream
++import java.io.*
+ import java.rmi.ConnectException
+-import java.rmi.Remote
+ import java.rmi.registry.LocateRegistry
+ import java.util.concurrent.Semaphore
+ import java.util.concurrent.TimeUnit
+ import kotlin.concurrent.thread
+ 
+-fun Process.isAlive() =
++
++public object KotlinCompilerClient {
++
++    val DAEMON_DEFAULT_STARTUP_TIMEOUT_MS = 10000L
++    val DAEMON_CONNECT_CYCLE_ATTEMPTS = 3
++
++
++    // TODO: remove jvmStatic after all use sites will switch to kotlin
++    jvmStatic
++    public fun connectToCompileService(compilerId: CompilerId,
++                                       daemonJVMOptions: DaemonJVMOptions,
++                                       daemonOptions: DaemonOptions,
++                                       reportingTargets: DaemonReportingTargets,
++                                       autostart: Boolean = true,
++                                       checkId: Boolean = true
++    ): CompileService? {
++
++        var attempts = 0
++        var fileLock: FileBasedLock? = null
+         try {
+-            this.exitValue()
+-            false
++            while (attempts++ < DAEMON_CONNECT_CYCLE_ATTEMPTS) {
++                val service = tryFindDaemon(File(daemonOptions.runFilesPath), compilerId, reportingTargets)
++                if (service != null) {
++                    if (!checkId || checkCompilerId(service, compilerId)) {
++                        reportingTargets.report(DaemonReportCategory.DEBUG, ""connected to the daemon"")
++                        return service
++                    }
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
++                    if (!autostart) return null
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""shutdown the daemon"")
++                    service.shutdown()
++                    // TODO: find more reliable way
++                    Thread.sleep(1000)
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""daemon shut down correctly, restarting search"")
++                }
++                else {
++                    if (!autostart) return null
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""no suitable daemon found, starting a new one"")
++                }
++
++                if (fileLock == null || !fileLock.isLocked()) {
++                    File(daemonOptions.runFilesPath).mkdirs()
++                    fileLock = FileBasedLock(compilerId, daemonOptions)
++                    // need to check the daemons again here, because of possible racing conditions
++                    // note: the algorithm could be simpler if we'll acquire lock right from the beginning, but it may be costly
++                    attempts--
++                }
++                else {
++                    startDaemon(compilerId, daemonJVMOptions, daemonOptions, reportingTargets)
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""daemon started, trying to resolve"")
++                }
++            }
+         }
+-        catch (e: IllegalThreadStateException) {
+-            true
++        catch (e: Exception) {
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, e.toString())
++        }
++        finally {
++            fileLock?.release()
+         }
++        return null
++    }
+ 
+-public class KotlinCompilerClient {
+ 
+-    companion object {
++    public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
++        KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, DaemonReportingTargets(out = System.out), autostart = false, checkId = false)
++                ?.shutdown()
++    }
+ 
+-        val DAEMON_STARTUP_TIMEOUT_MS = 10000L
+ 
+-        private fun connectToService(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): CompileService? {
++    public fun shutdownCompileService(): Unit {
++        shutdownCompileService(DaemonOptions())
++    }
+ 
+-            val compilerObj = connectToDaemon(compilerId, daemonOptions, errStream) ?: return null // no registry - no daemon running
+-            return compilerObj as? CompileService ?:
+-                throw ClassCastException(""Unable to cast compiler service, actual class received: ${compilerObj.javaClass}"")
++
++    public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
++
++        val outStrm = RemoteOutputStreamServer(out)
++        try {
++            return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN, outStrm)
+         }
++        finally {
++            outStrm.disconnect()
++        }
++    }
+ 
+-        private fun connectToDaemon(compilerId: CompilerId, daemonOptions: DaemonOptions, errStream: PrintStream): Remote? {
+-            try {
+-                val daemon = LocateRegistry.getRegistry(""localhost"", daemonOptions.port)
+-                        ?.lookup(COMPILER_SERVICE_RMI_NAME)
+-                if (daemon != null)
+-                    return daemon
+-                errStream.println(""[daemon client] daemon not found"")
+-            }
+-            catch (e: ConnectException) {
+-                errStream.println(""[daemon client] cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
+-                // ignoring it - processing below
+-            }
+-            return null
++
++    // TODO: remove jvmStatic after all use sites will switch to kotlin
++    jvmStatic
++    public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, compilerOut: OutputStream, daemonOut: OutputStream): Int {
++
++        val compilerOutStreamServer = RemoteOutputStreamServer(compilerOut)
++        val daemonOutStreamServer = RemoteOutputStreamServer(daemonOut)
++        val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
++        try {
++            caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer(it.getValue()) })
++            return compiler.remoteIncrementalCompile(args, cacheServers, compilerOutStreamServer, CompileService.OutputFormat.XML, daemonOutStreamServer)
++        }
++        finally {
++            cacheServers.forEach { it.getValue().disconnect() }
++            compilerOutStreamServer.disconnect()
++            daemonOutStreamServer.disconnect()
+         }
++    }
+ 
+ 
+-        private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream) {
+-            val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
+-                val javaw = File(it, ""javaw.exe"")
+-                if (javaw.exists()) javaw
+-                else File(it, ""java"")
+-            }
+-            // TODO: add some specific environment variables to the cp and may be command line, to allow some specific startup configs
+-            val args = listOf(javaExecutable.absolutePath,
+-                              ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
+-                       daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
+-                       COMPILER_DAEMON_CLASS_FQN +
+-                       daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
+-                       compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
+-            errStream.println(""[daemon client] starting the daemon as: "" + args.joinToString("" ""))
+-            val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
+-            // assuming daemon process is deaf and (mostly) silent, so do not handle streams
+-            val daemon = processBuilder.start()
+-
+-            var isEchoRead = Semaphore(1)
+-            isEchoRead.acquire()
+-
+-            val stdoutThread =
+-                    thread {
+-                        daemon.getInputStream()
+-                              .reader()
+-                              .forEachLine {
+-                                  if (daemonOptions.startEcho.isNotEmpty() && it.contains(daemonOptions.startEcho)) {
+-                                      isEchoRead.release()
+-                                      return@forEachLine
+-                                  }
+-                                  errStream.println(""[daemon] "" + it)
+-                              }
+-                    }
+-            try {
+-                // trying to wait for process
+-                if (daemonOptions.startEcho.isNotEmpty()) {
+-                    errStream.println(""[daemon client] waiting for daemon to respond"")
+-                    val succeeded = isEchoRead.tryAcquire(DAEMON_STARTUP_TIMEOUT_MS, TimeUnit.MILLISECONDS)
+-                    if (!daemon.isAlive())
+-                        throw Exception(""Daemon terminated unexpectedly"")
+-                    if (!succeeded)
+-                        throw Exception(""Unable to get response from daemon in $DAEMON_STARTUP_TIMEOUT_MS ms"")
+-                }
+-                else
+-                // without startEcho defined waiting for max timeout
+-                    Thread.sleep(DAEMON_STARTUP_TIMEOUT_MS)
+-            }
+-            finally {
+-                // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
+-                if (stdoutThread.isAlive)
+-                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
+-                    stdoutThread.stop()
++    data class ClientOptions(
++            public var stop: Boolean = false
++    ) : OptionsGroup {
++        override val mappers: List<PropMapper<*, *, *>>
++            get() = listOf(BoolPropMapper(this, ::stop))
++    }
++
++
++    jvmStatic public fun main(vararg args: String) {
++        val compilerId = CompilerId()
++        val daemonOptions = DaemonOptions()
++        val daemonLaunchingOptions = DaemonJVMOptions()
++        val clientOptions = ClientOptions()
++        val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
++
++        if (!clientOptions.stop) {
++            if (compilerId.compilerClasspath.none()) {
++                // attempt to find compiler to use
++                System.err.println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
++                System.getProperty(""java.class.path"")
++                        ?.split(File.pathSeparator)
++                        ?.map { File(it).parentFile }
++                        ?.distinct()
++                        ?.map {
++                            it?.walk()
++                                    ?.firstOrNull { it.name.equals(COMPILER_JAR_NAME, ignoreCase = true) }
++                        }
++                        ?.filterNotNull()
++                        ?.firstOrNull()
++                        ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
+             }
+-        }
++            if (compilerId.compilerClasspath.none())
++                throw IllegalArgumentException(""Cannot find compiler jar"")
++            else
++                println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
+ 
+-        public fun checkCompilerId(compiler: CompileService, localId: CompilerId, errStream: PrintStream): Boolean {
+-            val remoteId = compiler.getCompilerId()
+-            errStream.println(""[daemon client] remoteId = "" + remoteId.toString())
+-            errStream.println(""[daemon client] localId = "" + localId.toString())
+-            return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
+-                   (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
+-                   (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++            compilerId.updateDigest()
+         }
+ 
+-        public fun connectToCompileService(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, errStream: PrintStream, autostart: Boolean = true, checkId: Boolean = true): CompileService? {
+-            val service = connectToService(compilerId, daemonOptions, errStream)
+-            if (service != null) {
+-                if (!checkId || checkCompilerId(service, compilerId, errStream)) {
+-                    errStream.println(""[daemon client] found the suitable daemon"")
+-                    return service
+-                }
+-                errStream.println(""[daemon client] compiler identity don't match: "" + compilerId.mappers.flatMap { it.toArgs("""") }.joinToString("" ""))
+-                if (!autostart) return null;
+-                errStream.println(""[daemon client] shutdown the daemon"")
+-                service.shutdown()
+-                // TODO: find more reliable way
+-                Thread.sleep(1000)
+-                errStream.println(""[daemon client] daemon shut down correctly, restarting"")
++        val daemon = connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, DaemonReportingTargets(out = System.out), autostart = !clientOptions.stop, checkId = !clientOptions.stop)
++
++        if (daemon == null) {
++            if (clientOptions.stop) {
++                System.err.println(""No daemon found to shut down"")
+             }
+-            else {
+-                if (!autostart) return null;
+-                else errStream.println(""[daemon client] cannot connect to Compile Daemon, trying to start"")
++            else throw Exception(""Unable to connect to daemon"")
++        }
++        else when {
++            clientOptions.stop -> {
++                println(""Shutdown the daemon"")
++                daemon.shutdown()
++                println(""Daemon shut down successfully"")
+             }
++            else -> {
++                println(""Executing daemon compilation with args: "" + filteredArgs.joinToString("" ""))
++                val outStrm = RemoteOutputStreamServer(System.out)
++                try {
++                    val memBefore = daemon.getUsedMemory() / 1024
++                    val startTime = System.nanoTime()
++
++                    val res = daemon.remoteCompile(filteredArgs.toArrayList().toTypedArray(), outStrm, CompileService.OutputFormat.PLAIN, outStrm)
+ 
+-            startDaemon(compilerId, daemonJVMOptions, daemonOptions, errStream)
+-            errStream.println(""[daemon client] daemon started, trying to connect"")
+-            return connectToService(compilerId, daemonOptions, errStream)
++                    val endTime = System.nanoTime()
++                    println(""Compilation result code: $res"")
++                    val memAfter = daemon.getUsedMemory() / 1024
++                    println(""Compilation time: "" + TimeUnit.NANOSECONDS.toMillis(endTime - startTime) + "" ms"")
++                    println(""Used memory $memAfter (${""%+d"".format(memAfter - memBefore)} kb)"")
++                }
++                finally {
++                    outStrm.disconnect()
++                }
++            }
+         }
++    }
+ 
+-        public fun shutdownCompileService(daemonOptions: DaemonOptions): Unit {
+-            KotlinCompilerClient.connectToCompileService(CompilerId(), DaemonJVMOptions(), daemonOptions, System.out, autostart = false, checkId = false)
+-                    ?.shutdown()
++    // --- Implementation ---------------------------------------
++
++    val verboseReporting = System.getProperty(COMPILE_DAEMON_VERBOSE_REPORT_PROPERTY) != null
++
++    fun DaemonReportingTargets.report(category: DaemonReportCategory, message: String, source: String = ""daemon client"") {
++        if (category == DaemonReportCategory.DEBUG && !verboseReporting) return
++        out?.println(""[$source] ${category.name()}: $message"")
++        messages?.add(DaemonReportMessage(category, ""[$source] $message""))
++    }
++
++    private fun tryFindDaemon(registryDir: File, compilerId: CompilerId, reportingTargets: DaemonReportingTargets): CompileService? {
++        val classPathDigest = compilerId.compilerClasspath.map { File(it).absolutePath }.distinctStringsDigest()
++        val daemons = registryDir.walk()
++                .map { Pair(it, makeRunFilenameRegex(digest = classPathDigest, port = ""(\\d+)"").match(it.name)?.groups?.get(1)?.value?.toInt() ?: 0) }
++                .filter { it.second != 0 }
++                .map {
++                    reportingTargets.report(DaemonReportCategory.DEBUG, ""found suitable daemon on port ${it.second}, trying to connect"")
++                    val daemon = tryConnectToDaemon(it.second, reportingTargets)
++                    // cleaning orphaned file; note: daemon should shut itself down if it detects that the run file is deleted
++                    if (daemon == null && !it.first.delete()) {
++                        reportingTargets.report(DaemonReportCategory.INFO, ""WARNING: unable to delete seemingly orphaned file '${it.first.absolutePath}', cleanup recommended"")
++                    }
++                    daemon
++                }
++                .filterNotNull()
++                .toList()
++        return when (daemons.size()) {
++            0 -> null
++            1 -> daemons.first()
++            else -> throw IllegalStateException(""Multiple daemons serving the same compiler, reset with the cleanup required"")
++        // TODO: consider implementing automatic recovery instead, e.g. getting the youngest or least used daemon and shut down others
+         }
++    }
+ 
+-        public fun shutdownCompileService(): Unit {
+-            shutdownCompileService(DaemonOptions())
++    private fun tryConnectToDaemon(port: Int, reportingTargets: DaemonReportingTargets): CompileService? {
++        try {
++            val daemon = LocateRegistry.getRegistry(loopbackAddrName, port)
++                    ?.lookup(COMPILER_SERVICE_RMI_NAME)
++            if (daemon != null)
++                return daemon as? CompileService ?:
++                       throw ClassCastException(""Unable to cast compiler service, actual class received: ${daemon.javaClass}"")
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, ""daemon not found"")
++        }
++        catch (e: ConnectException) {
++            reportingTargets.report(DaemonReportCategory.EXCEPTION, ""cannot connect to registry: "" + (e.getCause()?.getMessage() ?: e.getMessage() ?: ""unknown exception""))
++            // ignoring it - processing below
+         }
++        return null
++    }
+ 
+-        public fun compile(compiler: CompileService, args: Array<out String>, out: OutputStream): Int {
+ 
+-            val outStrm = RemoteOutputStreamServer(out)
+-            try {
+-                return compiler.remoteCompile(args, outStrm, CompileService.OutputFormat.PLAIN)
+-            }
+-            finally {
+-                outStrm.disconnect()
+-            }
++    private fun startDaemon(compilerId: CompilerId, daemonJVMOptions: DaemonJVMOptions, daemonOptions: DaemonOptions, reportingTargets: DaemonReportingTargets) {
++        val javaExecutable = File(System.getProperty(""java.home""), ""bin"").let {
++            val javaw = File(it, ""javaw.exe"")
++            // TODO: doesn't seem reliable enough, consider more checks if OS is of windows flavor, etc.
++            if (javaw.exists() && javaw.isFile && javaw.canExecute()) javaw else File(it, ""java"")
+         }
++        val args = listOf(javaExecutable.absolutePath,
++                          ""-cp"", compilerId.compilerClasspath.joinToString(File.pathSeparator)) +
++                   daemonJVMOptions.mappers.flatMap { it.toArgs(""-"") } +
++                   COMPILER_DAEMON_CLASS_FQN +
++                   daemonOptions.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) } +
++                   compilerId.mappers.flatMap { it.toArgs(COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX) }
++        reportingTargets.report(DaemonReportCategory.DEBUG, ""starting the daemon as: "" + args.joinToString("" ""))
++        val processBuilder = ProcessBuilder(args).redirectErrorStream(true)
++        // assuming daemon process is deaf and (mostly) silent, so do not handle streams
++        val daemon = processBuilder.start()
+ 
+-        public fun incrementalCompile(compiler: CompileService, args: Array<out String>, caches: Map<String, IncrementalCache>, out: OutputStream): Int {
++        var isEchoRead = Semaphore(1)
++        isEchoRead.acquire()
+ 
+-            val outStrm = RemoteOutputStreamServer(out)
+-            val cacheServers = hashMapOf<String, RemoteIncrementalCacheServer>()
+-            try {
+-                caches.mapValuesTo(cacheServers, { RemoteIncrementalCacheServer( it.getValue()) })
+-                return compiler.remoteIncrementalCompile(args, cacheServers, outStrm, CompileService.OutputFormat.XML)
++        val stdoutThread =
++                thread {
++                    daemon.inputStream
++                            .reader()
++                            .forEachLine {
++                                if (daemonOptions.runFilesPath.isNotEmpty() && it.contains(daemonOptions.runFilesPath)) {
++                                    isEchoRead.release()
++                                    return@forEachLine
++                                }
++                                reportingTargets.report(DaemonReportCategory.DEBUG, it, ""daemon"")
++                            }
++                }
++        try {
++            // trying to wait for process
++            val daemonStartupTimeout = System.getProperty(COMPILE_DAEMON_STARTUP_TIMEOUT_PROPERTY)?.let {
++                try {
++                    it.toLong()
++                }
++                catch (e: Exception) {
++                    reportingTargets.report(DaemonReportCategory.INFO, ""unable to interpret $COMPILE_DAEMON_STARTUP_TIMEOUT_PROPERTY property ('$it'); using default timeout $DAEMON_DEFAULT_STARTUP_TIMEOUT_MS ms"")
++                    null
++                }
++            } ?: DAEMON_DEFAULT_STARTUP_TIMEOUT_MS
++            if (daemonOptions.runFilesPath.isNotEmpty()) {
++                val succeeded = isEchoRead.tryAcquire(daemonStartupTimeout, TimeUnit.MILLISECONDS)
++                if (!daemon.isAlive())
++                    throw Exception(""Daemon terminated unexpectedly"")
++                if (!succeeded)
++                    throw Exception(""Unable to get response from daemon in $daemonStartupTimeout ms"")
+             }
+-            finally {
+-                cacheServers.forEach { it.getValue().disconnect() }
+-                outStrm.disconnect()
++            else
++            // without startEcho defined waiting for max timeout
++                Thread.sleep(daemonStartupTimeout)
++        }
++        finally {
++            // assuming that all important output is already done, the rest should be routed to the log by the daemon itself
++            if (stdoutThread.isAlive) {
++                // TODO: find better method to stop the thread, but seems it will require asynchronous consuming of the stream
++                stdoutThread.stop()
+             }
+         }
++    }
+ 
+-        data class ClientOptions(
+-                public var stop: Boolean = false
+-        ) : OptionsGroup {
+-            override val mappers: List<PropMapper<*, *, *>>
+-                get() = listOf( BoolPropMapper(this, ::stop))
+-        }
+ 
+-        jvmStatic public fun main(vararg args: String) {
+-            val compilerId = CompilerId()
+-            val daemonOptions = DaemonOptions()
+-            val daemonLaunchingOptions = DaemonJVMOptions()
+-            val clientOptions = ClientOptions()
+-            val filteredArgs = args.asIterable().filterExtractProps(compilerId, daemonOptions, daemonLaunchingOptions, clientOptions, prefix = COMPILE_DAEMON_CMDLINE_OPTIONS_PREFIX)
+-
+-            if (!clientOptions.stop) {
+-                if (compilerId.compilerClasspath.none()) {
+-                    // attempt to find compiler to use
+-                    println(""compiler wasn't explicitly specified, attempt to find appropriate jar"")
+-                    System.getProperty(""java.class.path"")
+-                            ?.split(File.pathSeparator)
+-                            ?.map { File(it).parent }
+-                            ?.distinct()
+-                            ?.map {
+-                                it?.walk()
+-                                        ?.firstOrNull { it.getName().equals(COMPILER_JAR_NAME, ignoreCase = true) }
+-                            }
+-                            ?.filterNotNull()
+-                            ?.firstOrNull()
+-                            ?.let { compilerId.compilerClasspath = listOf(it.absolutePath) }
+-                }
+-                if (compilerId.compilerClasspath.none())
+-                    throw IllegalArgumentException(""Cannot find compiler jar"")
+-                else
+-                    println(""desired compiler classpath: "" + compilerId.compilerClasspath.joinToString(File.pathSeparator))
++    private fun checkCompilerId(compiler: CompileService, localId: CompilerId): Boolean {
++        val remoteId = compiler.getCompilerId()
++        return (localId.compilerVersion.isEmpty() || localId.compilerVersion == remoteId.compilerVersion) &&
++               (localId.compilerClasspath.all { remoteId.compilerClasspath.contains(it) }) &&
++               (localId.compilerDigest.isEmpty() || remoteId.compilerDigest.isEmpty() || localId.compilerDigest == remoteId.compilerDigest)
++    }
+ 
+-                compilerId.updateDigest()
++
++    class FileBasedLock(compilerId: CompilerId, daemonOptions: DaemonOptions) {
++        private val lockFile: File =
++                File(daemonOptions.runFilesPath,
++                     makeRunFilenameString(ts = ""lock"",
++                                           digest = compilerId.compilerClasspath.map { File(it).absolutePath }.distinctStringsDigest(),
++                                           port = ""0""))
++
++        private var locked: Boolean = acquireLockFile(lockFile)
++
++        public fun isLocked(): Boolean = locked
++
++        synchronized public fun release(): Unit {
++            if (locked) {
++                lock?.release()
++                channel?.close()
++                lockFile.delete()
++                locked = false
+             }
++        }
+ 
+-            val daemon = connectToCompileService(compilerId, daemonLaunchingOptions, daemonOptions, System.out, autostart = !clientOptions.stop, checkId = !clientOptions.stop)
++        private val channel = if (locked) RandomAccessFile(lockFile, ""rw"").channel else null
++        private val lock = channel?.lock()
+ 
+-            if (daemon == null) {
+-                if (clientOptions.stop) println(""No daemon found to shut down"")
+-                else throw Exception(""Unable to connect to daemon"")
++        synchronized private fun acquireLockFile(lockFile: File): Boolean {
++            if (lockFile.createNewFile()) return true
++            try {
++                // attempt to delete if file is orphaned
++                if (lockFile.delete() && lockFile.createNewFile())
++                    return true // if orphaned file deleted assuming that the probability of
+             }
+-            else when {
+-                clientOptions.stop -> {
+-                    println(""Shutdown the daemon"")
+-                    daemon.shutdown()
+-                    println(""Daemon shut down successfully"")
+-                }
+-                else -> {
+-                    println(""Executing daemon compilation with args: "" + filteredArgs.joinToString("" ""))
+-                    val outStrm = RemoteOutputStreamServer(System.out)
+-                    try {
+-                        val memBefore = daemon.getUsedMemory() / 1024
+-                        val startTime = System.nanoTime()
+-                        val res = daemon.remoteCompile(filteredArgs.toArrayList().toTypedArray(), outStrm, CompileService.OutputFormat.PLAIN)
+-                        val endTime = System.nanoTime()
+-                        println(""Compilation result code: $res"")
+-                        val memAfter = daemon.getUsedMemory() / 1024
+-                        println(""Compilation time: "" + TimeUnit.NANOSECONDS.toMillis(endTime - startTime) + "" ms"")
+-                        println(""Used memory $memAfter (${""%+d"".format(memAfter - memBefore)} kb)"")
+-                    }
+-                    finally {
+-                        outStrm.disconnect()
+-                    }
+-                }
++            catch (e: IOException) {
++                // Ignoring it - assuming it is another client process owning it
+             }
++            var attempts = 0L
++            while (lockFile.exists() && attempts++ * COMPILE_DAEMON_STARTUP_LOCK_TIMEOUT_CHECK_MS < COMPILE_DAEMON_STARTUP_LOCK_TIMEOUT_MS) {
++                Thread.sleep(COMPILE_DAEMON_STARTUP_LOCK_TIMEOUT_CHECK_MS)
++            }
++            if (lockFile.exists())
++                throw IOException(""Timeout waiting the release of the lock file '${lockFile.absolutePath}"")
++
++            return lockFile.createNewFile()","Can't we replace it with something like that:
+
+``` kotlin
+do {
+    if (lockFile.createNewFile()) return true
+    Thread.sleep(...)
+} while (!timeout)
+
+throw timeout exception
+```
+
+It is better because the function has only two cases: return or exception. Now we have true/false/exception
+",2015-09-08 18:05:15
+403,"@@ -18,64 +18,89 @@ package org.jetbrains.kotlin.gradle.plugin
+ 
+ import org.gradle.BuildAdapter
+ import org.gradle.BuildResult
++import org.gradle.api.invocation.Gradle
+ import org.gradle.api.logging.Logging
+ import java.lang.ref.Reference
+ import java.util.concurrent.ScheduledExecutorService
++import kotlin.text.MatchGroup
+ 
+-class FinishBuildListener(var pluginClassLoader: ParentLastURLClassLoader?) : BuildAdapter() {
++internal fun getUsedMemoryKb(): Long {
++    System.gc()
++    val rt = Runtime.getRuntime()
++    return (rt.totalMemory() - rt.freeMemory()) / 1024
++}
++
++
++private fun comparableVersionStr(version: String) =
++        ""(\\d+)\\.(\\d+).*""
++                .toRegex()
++                .match(version)
++                ?.groups
++                ?.drop(1)?.take(2)
++                // checking if two subexpression groups are found and length of each is >0 and <4
++                ?.let { if (it.all { (it?.value?.length() ?: 0).let { it > 0 && it < 4 }}) it else null }
++                ?.map { ""%3s"".format(it?.value ?: 0).replace(' ', '0') }
++                ?.joinToString(""."")","We can omit some of safe calls using `filterNotNull` and `padStart` trick:
+
+``` kotlin
+private fun comparableVersionStr(version: String) =
+        ""(\\d+)\\.(\\d+).*""
+                .toRegex()
+                .match(version)
+                ?.groups
+                ?.drop(1)?.take(2)
+                ?.filterNotNull()
+                // checking if two subexpression groups are found and length of each is >0 and <4
+                ?.let { if (it.size() == 2 && it.all { it.value.length() in 1..3 }) it else null }
+                ?.map { it.value.padStart(3, '0') }
+                ?.joinToString(""."")
+```
+",2015-07-29 13:33:34
+336,"@@ -18,72 +18,118 @@
+ 
+ package kotlin
+ 
++/** A function that takes 0 arguments. */
+ public trait Function0<out R> {
++    /** Invokes the function with the specified arguments. */","no arguments
+",2015-03-12 14:49:28
+337,"@@ -18,72 +18,118 @@
+ 
+ package kotlin
+ 
++/** A function that takes 0 arguments. */
+ public trait Function0<out R> {
++    /** Invokes the function with the specified arguments. */
+     public fun invoke(): R
+ }
++/** A function that takes 1 arguments. */","plural use for 1
+",2015-03-12 14:49:50
+335,"@@ -18,72 +18,118 @@
+ 
+ package kotlin
+ 
++/** An extension function that takes 0 arguments. */
+ public trait ExtensionFunction0<in T, out R> {
++    /** Invokes the function with the specified arguments. */","There are no arguments, so just ""Invokes the function""
+",2015-03-12 14:48:48
+334,"@@ -18,72 +18,118 @@
+ 
+ package kotlin
+ 
++/** An extension function that takes 0 arguments. */
+ public trait ExtensionFunction0<in T, out R> {
++    /** Invokes the function with the specified arguments. */
+     public fun T.invoke(): R
+ }
++/** An extension function that takes 1 arguments. */","""argument"", no ""s""
+",2015-03-12 14:48:29
+696,"@@ -181,7 +183,7 @@ object TopDownAnalyzerFacadeForJVM {
+         // TODO: get rid of duplicate invocation of CodeAnalyzerInitializer#initialize, or refactor CliLightClassGenerationSupport
+         val container = createContainerForTopDownAnalyzerForJvm(
+                 moduleContext, trace, declarationProviderFactory(storageManager, files), sourceScope, lookupTracker,
+-                partProvider, moduleClassResolver, jvmTarget, languageVersionSettings
++                partProvider, moduleClassResolver, jvmTarget, languageVersionSettings, useJavac",Not to this PR but just to note: this TODO above should be handled somehow,2017-04-05 12:26:58
+633,"@@ -1839,6 +1844,14 @@
+                      language=""kotlin""
+     />
+ 
++    <localInspection implementationClass=""org.jetbrains.kotlin.idea.intentions.RemoveEmptyClassBodyInspection""
++                     displayName=""Replace empty class body""
++                     groupName=""Kotlin""
++                     enabledByDefault=""true""
++                     level=""WARNING""","There is nothing bad about an empty class body, so this should be severity INFO, not WARNING
+",2016-10-10 11:04:46
+92,"@@ -184,6 +184,22 @@ public inline fun <K> BooleanArray.groupByTo(result: MutableMap<K, MutableList<B
+ }
+ 
+ /**
++ * Returns first index of item, or -1 if the array does not contain item
++ */
++public fun BooleanArray.indexOf(item : Boolean) : Int {
++    if (item == null) {","Value of 'Boolean' type cannot be 'null' in Kotlin.
+",2013-12-26 20:32:09
+599,"@@ -185,6 +169,15 @@ object LightClassUtil {
+         return null
+     }
+ 
++    private fun getWrappingClasses(declaration: KtDeclaration): List<PsiClass> {","You can simplify this code by changing the return type to `Sequence<PsiClass>` and using `generateSequence()`
+",2016-09-05 17:29:17
+692,"@@ -186,6 +187,14 @@ class K2JVMCompiler : CLICompiler<K2JVMCompilerArguments>() {
+                 val environment = createEnvironmentWithScriptingSupport(rootDisposable, configuration, arguments, messageCollector)
+                                   ?: return COMPILATION_ERROR
+ 
++                if (arguments.useJavac) {",Looks like this if / else is better to be moved above (just before environment definition). It's more consistent with previous code.,2017-04-05 11:27:20
+691,"@@ -186,6 +187,14 @@ class K2JVMCompiler : CLICompiler<K2JVMCompilerArguments>() {
+                 val environment = createEnvironmentWithScriptingSupport(rootDisposable, configuration, arguments, messageCollector)
+                                   ?: return COMPILATION_ERROR
+ 
++                if (arguments.useJavac) {
++                    environment.configuration.put(JVMConfigurationKeys.USE_JAVAC, true)
++                    environment.registerJavac(outDir = File(destination),
++                                              messageCollector = messageCollector,
++                                              arguments = arguments.javacArguments)
++                }
++                else environment.configuration.put(JVMConfigurationKeys.USE_JAVAC, false)",Use {} here,2017-04-05 11:23:54
+878,"@@ -187,5 +185,26 @@ fun arrays(): List<GenericFunction> {
+         }
+     }
+ 
++    templates add f(""nullIfEmpty()"") {
++        only(ArraysOfObjects, ArraysOfPrimitives, Collections)
++        doc { f ->
++            """"""
++            Returns `this` value if it is not empty or `null`, if it is.
++
++            ${if (f == ArraysOfObjects || f == ArraysOfPrimitives)
++                ""@sample samples.collections.Arrays.nullIfEmpty""
++            else if (f == Collections)
++                ""@sample samples.collections.Collections.nullIfEmpty""
++            else
++                """"
++            }
++            """"""
++        }
++        returns(""SELF?"")
++        body {
++            ""return if (this == null || this.isEmpty()) null else this""","`this == null` 
+^ expression is always false",2017-07-03 18:19:57
+290,"@@ -1893,7 +1893,7 @@ public inline fun String.lastOrNull(predicate: (Char) -> Boolean): Char? {
+ }
+ 
+ /**
+- * Returns single element, or throws exception if there is no or more than one element
++ * Returns the single element, or throws an exception if if the collection is empty or has more than one element.","if if
+",2015-02-09 15:49:12
+321,"@@ -19,18 +19,39 @@ package kotlin.jvm
+ import java.lang.annotation.Retention
+ import java.lang.annotation.RetentionPolicy
+ 
++/**
++ * Marks the JVM backing field of the annotated property as `volatile`, meaning that it can
++ * be modified asynchronously by concurrently running threads.","""can be modified async"" is strange wording. Even if field is not volatile, you still can modify it async by concurrent threads, but effect may be different. Need better description.
+",2015-02-11 08:41:43
+510,"@@ -19,6 +19,7 @@ package org.jetbrains.kotlin.codegen
+ import org.jetbrains.kotlin.descriptors.ValueParameterDescriptor
+ import org.jetbrains.kotlin.psi.KtExpression
+ import org.jetbrains.kotlin.resolve.calls.model.ResolvedCall
++import org.jetbrains.kotlin.codegen.binding.CodegenBinding.*","Unused import
+",2016-02-09 08:33:51
+992,"@@ -195,6 +195,7 @@ enum class TraversalOrder {
+     BACKWARD
+ }
+ 
++",Remove me,2017-08-16 09:42:12
+753,"@@ -195,6 +205,11 @@ class K2JVMCompiler : CLICompiler<K2JVMCompilerArguments>() {
+                 }
+ 
+                 KotlinToJVMBytecodeCompiler.compileBunchOfSources(environment)
++
++                if (arguments.useJavac) {
++                    val success = JavacWrapper.getInstance(environment.project).use(JavacWrapper::compile)
++                    if (!success) return COMPILATION_ERROR
++                }",And this code should also be performed for previous branches,2017-04-11 09:57:39
+464,"@@ -198,6 +202,8 @@
+             <fileset dir=""compiler/builtins-serializer/src""/>
+             <fileset dir=""compiler/cli/src""/>
+             <fileset dir=""compiler/cli/cli-common/src""/>
++            <include name=""compiler/rmi/rmi-server/src""/>
++            <include name=""compiler/rmi/rmi-interface/src""/>","Other lines here use `<fileset dir=...>`
+",2015-09-01 07:28:05
+89,"@@ -199,6 +199,22 @@ public inline fun <T, K> Array<out T>.groupByTo(result: MutableMap<K, MutableLis
+ }
+ 
+ /**
++ * Returns first index of item, or -1 if the array does not contain item
++ */
++public fun <T> Array<out T>.indexOf(item : T) : Int {","We usually don't add space before colon in parameters list
+",2013-12-26 20:29:36
+90,"@@ -199,6 +199,22 @@ public inline fun <T, K> Array<out T>.groupByTo(result: MutableMap<K, MutableLis
+ }
+ 
+ /**
++ * Returns first index of item, or -1 if the array does not contain item
++ */
++public fun <T> Array<out T>.indexOf(item : T) : Int {
++    if (item == null) {","Why do you need to handle 'item==null' case separately? '==' operator works properly with nulls.
+",2013-12-26 20:30:31
+91,"@@ -199,6 +199,22 @@ public inline fun <T, K> Array<out T>.groupByTo(result: MutableMap<K, MutableLis
+ }
+ 
+ /**
++ * Returns first index of item, or -1 if the array does not contain item
++ */
++public fun <T> Array<out T>.indexOf(item : T) : Int {
++    if (item == null) {
++        for (i in 0..size - 1) if (this[i] == null) {","size-1 can be replaced by lastIndex.
+",2013-12-26 20:31:11
+340,"@@ -2,36 +2,65 @@ package kotlin.concurrent
+ 
+ import java.util.concurrent.*
+ 
++/**
++ * Return the current thread.","Returns
+",2015-03-12 14:56:56
+917,"@@ -20,6 +20,15 @@ package kotlin.script.dependencies
+ 
+ import java.io.File
+ 
++// discuss
++
++// Currently File is used to disambiguate between plain strings and paths
++// One of the ideas is to use java.nio.Path but this requires JDK 7
++// that means that script templates would require higher JDK (but since script are run by calling koltinc it seems ok to me after consideration)",I think requiring JDK 8 in scripts is fine,2017-07-25 10:15:27
+915,"@@ -20,6 +20,15 @@ package kotlin.script.dependencies
+ 
+ import java.io.File
+ 
++// discuss
++
++// Currently File is used to disambiguate between plain strings and paths
++// One of the ideas is to use java.nio.Path but this requires JDK 7
++// that means that script templates would require higher JDK (but since script are run by calling koltinc it seems ok to me after consideration)
++// Andrey expressed the idea that File (or Path) does not support other protocols, should we use URL/URI? (is it viable to support non-file protocols in compiler and IDE?)","> File (or Path) does not support other protocols
+
+Path _does_ support other protocols AFAIK. You can create a custom `java.nio.file.FileSystem` and resolve paths within that file system.",2017-07-25 10:08:01
+931,"@@ -20,6 +20,15 @@ package kotlin.script.dependencies
+ 
+ import java.io.File
+ 
++// discuss
++
++// Currently File is used to disambiguate between plain strings and paths
++// One of the ideas is to use java.nio.Path but this requires JDK 7
++// that means that script templates would require higher JDK (but since script are run by calling koltinc it seems ok to me after consideration)
++// Andrey expressed the idea that File (or Path) does not support other protocols, should we use URL/URI? (is it viable to support non-file protocols in compiler and IDE?)
++//
++// Explicitly references javaHome, what if it's not a jvm targeted script?
++// Currently it's convenient for IDE code and for the user because including jdk classes in classpath is a mess
+ data class ScriptDependencies(",What's the difference between `sources` and `scripts`?,2017-07-25 12:57:27
+929,"@@ -20,6 +20,15 @@ package kotlin.script.dependencies
+ 
+ import java.io.File
+ 
++// discuss
++
++// Currently File is used to disambiguate between plain strings and paths
++// One of the ideas is to use java.nio.Path but this requires JDK 7
++// that means that script templates would require higher JDK (but since script are run by calling koltinc it seems ok to me after consideration)
++// Andrey expressed the idea that File (or Path) does not support other protocols, should we use URL/URI? (is it viable to support non-file protocols in compiler and IDE?)
++//
++// Explicitly references javaHome, what if it's not a jvm targeted script?
++// Currently it's convenient for IDE code and for the user because including jdk classes in classpath is a mess
+ data class ScriptDependencies(
+         val javaHome: File? = null,","What is `javaHome`: is it required to be a path to the JDK, or a path to the JRE is enough?",2017-07-25 11:50:16
+930,"@@ -20,6 +20,15 @@ package kotlin.script.dependencies
+ 
+ import java.io.File
+ 
++// discuss
++
++// Currently File is used to disambiguate between plain strings and paths
++// One of the ideas is to use java.nio.Path but this requires JDK 7
++// that means that script templates would require higher JDK (but since script are run by calling koltinc it seems ok to me after consideration)
++// Andrey expressed the idea that File (or Path) does not support other protocols, should we use URL/URI? (is it viable to support non-file protocols in compiler and IDE?)
++//
++// Explicitly references javaHome, what if it's not a jvm targeted script?
++// Currently it's convenient for IDE code and for the user because including jdk classes in classpath is a mess
+ data class ScriptDependencies(
+         val javaHome: File? = null,
+         val classpath: List<File> = emptyList(),","Can we use here directories/jars/individual files? 
+Maybe it's worth to document it somewhere",2017-07-25 12:48:24
+22,"@@ -200,4 +201,13 @@ public static PsiElement createPrimaryConstructor(Project project) {
+         JetClass aClass = createClass(project, ""class A()"");
+         return aClass.findElementAt(7).getParent();
+     }
++
++    public static JetSimpleNameExpression createClassLabel(Project project, @NotNull String labelName) {
++        JetThisExpression expression = (JetThisExpression) createExpression(project, ""this@"" + labelName);
++        return expression.getTargetLabel();
++    }
++
++    public static JetExpression createFieldIdentifier(Project project, @NotNull String fieldName) {
++        return createExpression(project, ""$"" + fieldName);
++    }","Maybe this one will be final :)
+",2013-01-11 16:42:26
+21,"@@ -200,4 +202,14 @@ public static PsiElement createPrimaryConstructor(Project project) {
+         JetClass aClass = createClass(project, ""class A()"");
+         return aClass.findElementAt(7).getParent();
+     }
++
++    public static PsiElement createClassLabel(Project project, @NotNull String labelName) {
++        JetExpression expression = createExpression(project, ""this@"" + labelName);
++        return expression.getLastChild();","However I have one question: in current variant org.jetbrains.jet.JetNodeTypes#LABEL_QUALIFIER returned - this is normal that org.jetbrains.jet.lexer.JetTokens#FIELD_IDENTIFIER replaced by org.jetbrains.jet.JetNodeTypes#LABEL_QUALIFIER?
+",2013-01-11 16:27:42
+20,"@@ -200,4 +202,14 @@ public static PsiElement createPrimaryConstructor(Project project) {
+         JetClass aClass = createClass(project, ""class A()"");
+         return aClass.findElementAt(7).getParent();
+     }
++
++    public static PsiElement createClassLabel(Project project, @NotNull String labelName) {
++        JetExpression expression = createExpression(project, ""this@"" + labelName);
++        return expression.getLastChild();
++    }
++
++    public static PsiElement createFieldIdentifier(Project project, @NotNull String fieldName) {
++        JetExpression expression = createExpression(project, ""$"" + fieldName);
++        return expression.getFirstChild();","Much nice
+",2013-01-11 16:21:10
+18,"@@ -200,4 +202,19 @@ public static PsiElement createPrimaryConstructor(Project project) {
+         JetClass aClass = createClass(project, ""class A()"");
+         return aClass.findElementAt(7).getParent();
+     }
++
++    public static PsiElement createClassLabel(Project project, @NotNull String labelName) {
++        final String labelTemplate = ""class {0}()'{' fun aFun()'{' this@{0}'}'}"";
++        JetClass aClass = createClass(project, MessageFormat.format(labelTemplate, labelName));
++        final int offset = 18;    // @labelName
++        return aClass.getBody().findElementAt(offset);
++    }
++
++    public static PsiElement createFieldIdentifier(Project project, @NotNull String fieldName){
++        final String labelTemplate = ""class aClass()'{'var {0}:Int=0;set(value)'{'${0}'} '}"";
++        JetClass aClass = createClass(project, MessageFormat.format(labelTemplate, fieldName));
++        final JetDeclaration declaration = aClass.getBody().getDeclarations().get(0);
++        final int offset = 11;   // $fieldName
++        return declaration.getLastChild().findElementAt(offset);","Ok, now it looks better
+",2013-01-11 15:01:40
+305,"@@ -205,7 +241,9 @@ public inline fun <K, V> Map<K, V>.filterValues(predicate: (V) -> Boolean): Map<
+ 
+ 
+ /**
+- * Appends all elements matching the given *predicate* into the given *destination*
++ * Appends all entries matching the given [predicate] into the given [destination] mutable map.","""[destination] mutable map."", looks confusing a bit.
+",2015-02-09 16:08:37
+487,"@@ -209,7 +209,7 @@ public void generateMethod(
+             generateMethodBody(mv, functionDescriptor, methodContext, jvmSignature, strategy, memberCodegen);
+         }
+         else if (staticInCompanionObject) {
+-            // native platformStatic foo() in companion object should delegate to the static native function moved to the outer class
++            // native @JvmStatic foo() in companion object should delegate to the static native function moved to the outer class
+             mv.visitCode();
+             FunctionDescriptor staticFunctionDescriptor = PlatformStaticGenerator.createStaticFunctionDescriptor(functionDescriptor);","rename `PlatformStaticGenerator` -> `JvmStaticGenerator`?
+",2015-10-30 15:12:17
+299,"@@ -21,15 +21,18 @@ private object EmptyMap : Map<Any, Any> {
+ /** Returns an empty read-only map of specified type */
+ public fun emptyMap<K, V>(): Map<K, V> = EmptyMap as Map<K, V>
+ 
+-/** Returns a new read-only map of given pairs, where the first value is the key, and the second is value */
++/**
++ * Returns a new read-only map with the specified contents, given as a list of pairs
++ * where the first value is the key and the second is the value.
++ */","specify, that it behaves as sequential `put` calls, so that if conflicting keys exist in source sequence, last one wins.
+",2015-02-09 16:01:42
+754,"@@ -21,17 +21,30 @@ import com.intellij.psi.search.GlobalSearchScope
+ import org.jetbrains.kotlin.builtins.BuiltInSerializerProtocol
+ import org.jetbrains.kotlin.cli.jvm.index.JavaRoot
+ import org.jetbrains.kotlin.cli.jvm.index.JvmDependenciesIndex
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.impl.JavaClassImpl
++import org.jetbrains.kotlin.load.kotlin.KotlinJvmBinaryClass
+ import org.jetbrains.kotlin.load.kotlin.VirtualFileFinder
+ import org.jetbrains.kotlin.name.ClassId
+ import org.jetbrains.kotlin.name.FqName
+ import org.jetbrains.kotlin.name.Name
+ import org.jetbrains.kotlin.serialization.deserialization.MetadataPackageFragment
++import org.jetbrains.kotlin.wrappers.trees.computeClassId
+ import java.io.InputStream
+ 
+ class CliVirtualFileFinder(
+         private val index: JvmDependenciesIndex,
+         private val scope: GlobalSearchScope
+ ) : VirtualFileFinder() {
++
++    override fun findKotlinClass(javaClass: JavaClass): KotlinJvmBinaryClass? {
++        if (javaClass !is JavaClassImpl) {
++            return javaClass.computeClassId()?.let(this::findKotlinClass) ?: return null",This `return null` is unnecessary,2017-04-11 09:58:37
+773,"@@ -21,17 +21,31 @@ import com.intellij.psi.search.GlobalSearchScope
+ import org.jetbrains.kotlin.builtins.BuiltInSerializerProtocol
+ import org.jetbrains.kotlin.cli.jvm.index.JavaRoot
+ import org.jetbrains.kotlin.cli.jvm.index.JvmDependenciesIndex
++import org.jetbrains.kotlin.load.java.structure.JavaClass
++import org.jetbrains.kotlin.load.java.structure.impl.JavaClassImpl
++import org.jetbrains.kotlin.load.java.structure.impl.classFiles.BinaryJavaClass
++import org.jetbrains.kotlin.load.kotlin.KotlinJvmBinaryClass
+ import org.jetbrains.kotlin.load.kotlin.VirtualFileFinder
+ import org.jetbrains.kotlin.name.ClassId
+ import org.jetbrains.kotlin.name.FqName
+ import org.jetbrains.kotlin.name.Name
+ import org.jetbrains.kotlin.serialization.deserialization.MetadataPackageFragment
++import org.jetbrains.kotlin.wrappers.trees.computeClassId
+ import java.io.InputStream
+ 
+ class CliVirtualFileFinder(
+         private val index: JvmDependenciesIndex,
+         private val scope: GlobalSearchScope
+ ) : VirtualFileFinder() {
++
++    override fun findKotlinClass(javaClass: JavaClass): KotlinJvmBinaryClass? {
++        if (javaClass !is JavaClassImpl && javaClass !is BinaryJavaClass) {
++            return javaClass.computeClassId()?.let(this::findKotlinClass)",I think you should create a custom KotlinJvmBinaryClass implementation here: there's no need to look up the class that is already found and passed in the argument,2017-04-25 07:34:22
+684,"@@ -21,5 +21,6 @@
+     <orderEntry type=""module"" module-name=""tests-common"" scope=""TEST"" />
+     <orderEntry type=""module"" module-name=""idea-core"" />
+     <orderEntry type=""module"" module-name=""lint-idea"" scope=""TEST"" />
++    <orderEntry type=""module"" module-name=""light-classes"" />","Try to avoid light classes, some explanation below",2017-01-25 12:51:11
+916,"@@ -21,6 +21,24 @@ package kotlin.script.dependencies
+ import java.io.File
+ import kotlin.script.dependencies.DependenciesResolver.ResolveResult
+ 
++//discuss
++
++// Provides api to discover dependencies of scripts
++// Dependencies can be content-dependent
++//
++// Some concerns on naming:
++// Environment -> ScriptEnvironment (top level class with too common a name)
++// ResolveResult -> ResolutionResult",+1 for ResolutionResult,2017-07-25 10:13:47
+932,"@@ -21,6 +21,24 @@ package kotlin.script.dependencies
+ import java.io.File
+ import kotlin.script.dependencies.DependenciesResolver.ResolveResult
+ 
++//discuss
++
++// Provides api to discover dependencies of scripts
++// Dependencies can be content-dependent
++//
++// Some concerns on naming:
++// Environment -> ScriptEnvironment (top level class with too common a name)
++// ResolveResult -> ResolutionResult
++//
++// Admittedly DependenciesResolver is too generic a name, but ScriptDependenciesResolver is already taken by deprecated interface
++// My guess is script.runtime.jar is not gonna be used as application wide dependency in users project (like stdlib)
++// but rather as a dependency for a module that contains DependenciesResolver implementation so maybe this is a non-problem
++//
++// ResolveResult contains resulting dependencies and reports (diagnostics?)
++// reports may contain errors (regardless of result being Success or Failure) which is gonna lead to compiler error and script not run/error highlighting in IDE.
++// Is this semantic reasonable? Are Success and Failure misleading names?
++// Main idea behind Failure is to be able to distinguish between scenarios where resolver could or could not return meaningful ScriptDependencies object.
++// For example, IDE can avoid repainting all external references as errors when Resolver threw an exception or is in inconsistent state.
+ typealias Environment = Map<String, Any?>
+ 
+ interface DependenciesResolver : @Suppress(""DEPRECATION"") ScriptDependenciesResolver {",`DependencyResolver` instead of `DependenciesResolver`,2017-07-26 01:48:17
+779,"@@ -211,6 +220,25 @@ class K2JVMCompiler : CLICompiler<K2JVMCompilerArguments>() {
+         }
+     }
+ 
++    private fun registerJavacIfNeeded(environment: KotlinCoreEnvironment,
++                                      arguments: K2JVMCompilerArguments,
++                                      messageCollector: MessageCollector) {
++        if (arguments.useJavac) {
++            environment.configuration.put(JVMConfigurationKeys.USE_JAVAC, true)
++            environment.registerJavac(messageCollector = messageCollector,
++                                      arguments = arguments.javacArguments)
++        } else {
++            environment.configuration.put(JVMConfigurationKeys.USE_JAVAC, false)",There's no need to put `false` as the configuration value if you're using `getBoolean` at call sites,2017-04-25 07:58:25
+867,"@@ -212,11 +212,12 @@ fun createSpacingBuilder(settings: CodeStyleSettings, builderUtil: KotlinSpacing
+             afterInside(LT, TYPE_ARGUMENT_LIST).spaces(0)
+             beforeInside(GT, TYPE_ARGUMENT_LIST).spaces(0)
+ 
+-            betweenInside(FOR_KEYWORD, LPAR, FOR).spacing(1, 1, 0, false, 0)
+-            betweenInside(IF_KEYWORD, LPAR, IF).spacing(1, 1, 0, false, 0)
+-            betweenInside(WHILE_KEYWORD, LPAR, WHILE).spacing(1, 1, 0, false, 0)
+-            betweenInside(WHILE_KEYWORD, LPAR, DO_WHILE).spacing(1, 1, 0, false, 0)
+-            betweenInside(WHEN_KEYWORD, LPAR, WHEN).spacing(1, 1, 0, false, 0)
++            betweenInside(FOR_KEYWORD, LPAR, FOR).lineBreakOrForceSpace(false, kotlinCommonSettings.SPACE_BEFORE_FOR_PARENTHESES)","There is never a line break in these locations, so you should better use `spaceIf`.",2017-06-02 15:50:02
+29,"@@ -214,21 +214,32 @@ public static void addTypeAnnotation(Project project, JetParameter parameter, @N
+         ReferenceToClassesShortening.compactReferenceToClasses(Collections.singletonList(parameter));
+     }
+ 
+-    private static void removeTypeAnnotation(@NotNull JetNamedDeclaration property, @Nullable JetTypeReference typeReference) {
++    private static void removeTypeAnnotation(@NotNull PsiElement removeAfter, @Nullable JetTypeReference typeReference) {","I don't love name 'removeAfter' but I didn't come up with anything better.
+",2013-02-09 17:40:01
+880,"@@ -2165,6 +2183,9 @@ public fun Iterable<Int>.sum(): Int {
+  */
+ @kotlin.jvm.JvmName(""sumOfLong"")
+ public fun Iterable<Long>.sum(): Long {
++    if (this is LongProgression) {
++        return (this.first + this.last) * this.count() / 2",Is this as overflow safe as the old approach? `(this.first + this.last) * this.count()` might overflow when `(this.first + this.last) * (this.count() / 2)` wouldn't.,2017-07-05 09:28:29
+307,"@@ -217,14 +255,16 @@ public inline fun <K, V, C : MutableMap<K, V>> Map<K, V>.filterTo(destination: C
+ }
+ 
+ /**
+- * Returns a map containing all key-value pairs matching the given *predicate*
++ * Returns a map containing all key-value pairs matching the given [predicate].","Returns a _new_ map
+",2015-02-09 16:09:53
+774,"@@ -217,6 +216,34 @@ class KotlinCoreEnvironment private constructor(
+         project.registerService(VirtualFileFinderFactory::class.java, finderFactory)
+     }
+ 
++    // Maybe there is another way to obtain all java files
++    private val VirtualFile.javaFiles: List<VirtualFile>","This is rather inefficient because it creates a lot of lists. Try something like this:
+```
+    private val VirtualFile.javaFiles: List<VirtualFile>
+        get() = mutableListOf<VirtualFile>().apply {
+            VfsUtilCore.processFilesRecursively(this@javaFiles) { file ->
+                if (file.fileType == JavaFileType.INSTANCE) {
+                    add(file)
+                }
+                true
+            }
+        }
+```
+",2017-04-25 07:44:49
+777,"@@ -217,6 +216,34 @@ class KotlinCoreEnvironment private constructor(
+         project.registerService(VirtualFileFinderFactory::class.java, finderFactory)
+     }
+ 
++    // Maybe there is another way to obtain all java files
++    private val VirtualFile.javaFiles: List<VirtualFile>
++        get() = children.filter { it.extension == ""java"" }
++                .toMutableList()
++                .apply {
++                    children
++                            .filter(VirtualFile::isDirectory)
++                            .forEach { dir -> addAll(dir.javaFiles) }
++                }
++
++    private val javaFiles",`allJavaFiles` maybe?,2017-04-25 07:51:16
+775,"@@ -217,6 +216,34 @@ class KotlinCoreEnvironment private constructor(
+         project.registerService(VirtualFileFinderFactory::class.java, finderFactory)
+     }
+ 
++    // Maybe there is another way to obtain all java files
++    private val VirtualFile.javaFiles: List<VirtualFile>
++        get() = children.filter { it.extension == ""java"" }
++                .toMutableList()
++                .apply {
++                    children
++                            .filter(VirtualFile::isDirectory)
++                            .forEach { dir -> addAll(dir.javaFiles) }
++                }
++
++    private val javaFiles
++        get() = configuration.kotlinSourceRoots
++                .mapNotNull(this::findLocalDirectory)
++                .flatMap { it.javaFiles }
++                .map { File(it.canonicalPath) }
++
++    fun registerJavac(files: List<File> = javaFiles,
++                      kotlinFiles: List<KtFile> = sourceFiles,
++                      messageCollector: MessageCollector? = null,
++                      arguments: Array<String>? = null) {
++        projectEnvironment.project.registerService(JavacWrapper::class.java, JavacWrapper(files,",Please fix formatting here,2017-04-25 07:46:06
+863,"@@ -2180,6 +2180,14 @@
+                      language=""kotlin""
+     />
+ 
++    <localInspection implementationClass=""org.jetbrains.kotlin.idea.inspections.MemberVisibilityCanPrivateInspection""
++                     displayName=""Can have 'private' visibility""","Better to show a more full name here: ""Class member can have 'private' visibility""",2017-05-23 17:07:14
+488,"@@ -22,13 +22,11 @@ import org.jetbrains.kotlin.descriptors.PropertyAccessorDescriptor
+ import org.jetbrains.kotlin.descriptors.annotations.AnnotationDescriptor
+ import org.jetbrains.kotlin.descriptors.annotations.AnnotationUseSiteTarget
+ import org.jetbrains.kotlin.descriptors.annotations.Annotations
+-import org.jetbrains.kotlin.lexer.KtTokens
+ import org.jetbrains.kotlin.name.FqName
+ import org.jetbrains.kotlin.resolve.DescriptorUtils
+ 
+ public fun DeclarationDescriptor.hasPlatformStaticAnnotation(): Boolean {","`hasJvmStaticAnnotation`?
+",2015-10-30 15:12:35
+927,"@@ -22,13 +22,28 @@ import kotlin.reflect.KClass
+ import kotlin.script.dependencies.DependenciesResolver.NoDependencies
+ import kotlin.script.dependencies.ScriptDependenciesResolver
+ 
++// discuss",Maybe move this file to package `kotlin.script.annotations`? To leave `kotlin.script.templates` for actual templates only,2017-07-25 11:38:05
+926,"@@ -22,13 +22,28 @@ import kotlin.reflect.KClass
+ import kotlin.script.dependencies.DependenciesResolver.NoDependencies
+ import kotlin.script.dependencies.ScriptDependenciesResolver
+ 
++// discuss
++
++// One of the requests is to allow to share compiler args via script templates: https://youtrack.jetbrains.com/issue/KT-19120
++// Making it a property of ScriptTemplateDefinition is a viable options but it doesn't allow to changes compiler arguments based on script content.
++// For example, it could be possible to allow file level annotation and use it like:
++// @file: ExtraCompilerArgs(""-enableWhatever"")","I think it's fine if we don't support extra compiler arguments based on script content now. If this becomes really needed, we can support it in the future, e.g. with an annotation like you mentioned here.",2017-07-25 11:36:50
+919,"@@ -22,13 +22,28 @@ import kotlin.reflect.KClass
+ import kotlin.script.dependencies.DependenciesResolver.NoDependencies
+ import kotlin.script.dependencies.ScriptDependenciesResolver
+ 
++// discuss
++
++// One of the requests is to allow to share compiler args via script templates: https://youtrack.jetbrains.com/issue/KT-19120
++// Making it a property of ScriptTemplateDefinition is a viable options but it doesn't allow to changes compiler arguments based on script content.
++// For example, it could be possible to allow file level annotation and use it like:
++// @file: ExtraCompilerArgs(""-enableWhatever"")
++
+ const val DEFAULT_SCRIPT_FILE_PATTERN = "".*\\.kts""
+ 
++// classes annotated with ScriptTemplateDefinition become script templates.
++// examples: https://github.com/JetBrains/kotlin/blob/5faad493b4cf7bf33bf82475e966a99a8e835720/compiler/tests/org/jetbrains/kotlin/scripts/ScriptTemplateTest.kt#L564-L601
+ @Target(AnnotationTarget.CLASS)
+ @Retention(AnnotationRetention.RUNTIME)
+ annotation class ScriptTemplateDefinition(val resolver: KClass<out ScriptDependenciesResolver> = NoDependencies::class,
+                                           val scriptFilePattern: String = DEFAULT_SCRIPT_FILE_PATTERN)","Do we need `scriptFilePattern` in this restricted form at all? 
+- IDE uses `ScriptTemplatesProvider.filePattern` that allows to determine scripts without loading script definition annotation.
+- There might be scripts of different kind that differentiate by full path or maybe content.",2017-07-25 10:33:46
+928,"@@ -22,13 +22,28 @@ import kotlin.reflect.KClass
+ import kotlin.script.dependencies.DependenciesResolver.NoDependencies
+ import kotlin.script.dependencies.ScriptDependenciesResolver
+ 
++// discuss
++
++// One of the requests is to allow to share compiler args via script templates: https://youtrack.jetbrains.com/issue/KT-19120
++// Making it a property of ScriptTemplateDefinition is a viable options but it doesn't allow to changes compiler arguments based on script content.
++// For example, it could be possible to allow file level annotation and use it like:
++// @file: ExtraCompilerArgs(""-enableWhatever"")
++
+ const val DEFAULT_SCRIPT_FILE_PATTERN = "".*\\.kts""
+ 
++// classes annotated with ScriptTemplateDefinition become script templates.
++// examples: https://github.com/JetBrains/kotlin/blob/5faad493b4cf7bf33bf82475e966a99a8e835720/compiler/tests/org/jetbrains/kotlin/scripts/ScriptTemplateTest.kt#L564-L601
+ @Target(AnnotationTarget.CLASS)
+ @Retention(AnnotationRetention.RUNTIME)
+ annotation class ScriptTemplateDefinition(val resolver: KClass<out ScriptDependenciesResolver> = NoDependencies::class,
+                                           val scriptFilePattern: String = DEFAULT_SCRIPT_FILE_PATTERN)
+ 
++// usage example: https://github.com/JetBrains/kotlin/blob/88652154c96402475d42ae0496ab0b423cc0a2b2/libraries/tools/kotlin-script-util/src/main/kotlin/org/jetbrains/kotlin/script/util/resolve.kt#L42-L42","I'm confused, why is this needed? Can't the DependenciesResolver implementation just filter out the unneeded annotations from ScriptContents.annotations?",2017-07-25 11:43:48
+86,"@@ -22,3 +22,22 @@ class FinalClass() {
+ 
+ <!INCOMPATIBLE_MODIFIERS!>private<!> <!INCOMPATIBLE_MODIFIERS!>public<!> class C
+ <!INCOMPATIBLE_MODIFIERS!>private<!> <!INCOMPATIBLE_MODIFIERS!>public<!> object D
++
++class LegalModifiersInConstructorParameters(val a: Int, private var b: String, vararg v: Int)
++
++class IllegalModifiersInConstructorParameters(<!ILLEGAL_MODIFIER!>private<!> a: Int)
++
++class SecondIllegalModifiersInConstructorParameters(<!ILLEGAL_MODIFIER!>public<!> b: String)
++
++class ThirdIllegalModifiersInConstructorParameters(<!ILLEGAL_MODIFIER!>protected<!> vararg v: Int)
++
++abstract class IllegalModifiersInFunctionParameters() {
++
++  abstract fun illegalModifiersInFunctionParameters(<!ILLEGAL_MODIFIER!>public<!> a: Int, vararg v: String)
++
++  private fun illegalModifiersInCatchBlock() {
++    try {
++
++    } catch (<!ILLEGAL_MODIFIER!>public<!> e: Exception) {}
++  }
++}","You should add a test with annotation and modifier like
+fun foo(deprecated(""ss"") public a: Int) 
+because annotations are parsed in modifier list.
+
+Also a test for more than one modifier on parameter is missed
+",2013-08-29 10:28:29
+4,"@@ -22,5 +22,5 @@
+ public class CompilerVersion {
+     // The value of this constant is generated by the build script
+     // DON'T MODIFY IT
+-    public static final String VERSION = ""@snapshot@"";
++    public static final String VERSION = ""snapshot"";","This will crash the build miserably.
+",2012-05-15 18:34:55
+784,"@@ -22,6 +22,9 @@
+     <property name=""javax.inject.jar"" value=""${basedir}/lib/javax.inject.jar""/>
+     <property name=""gradle.logging.level"" value=""""/>
+ 
++    <property environment=""env""/>
++    <property name=""tools.jar"" value=""${env.JDK_18}/lib/tools.jar""/>",Do you know if it's possible to download sources of this artifact from somewhere? This would be very useful,2017-04-25 08:16:39
+97,"@@ -220,6 +220,7 @@ add.name.to.argument.single=Add name to argument\: ''{0}''
+ add.name.to.argument.multiple=Add name to argument...
+ add.name.to.argument.action=Add name to argument...
+ add.name.to.parameter.name.chooser.title=Choose parameter name
++get.call.replacement=Get Call Replace","That's not a good name for an intention. The name should be ""Do something"", with correct capitalization.
+
+In such cases, always refer to existing UI elements, so the new features will be consistent with common style.
+",2014-01-27 21:28:35
+6,"@@ -225,38 +225,7 @@","ignore this file
+",2012-05-24 14:20:57
+111,"@@ -226,6 +226,10 @@ replace.with.dot.qualified.method.call.intention=Replace with simple method call
+ replace.with.dot.qualified.method.call.intention.family=Replace with simple method call
+ replace.with.infix.function.call.intention=Replace with infix function call
+ replace.with.infix.function.call.intention.family=Replace with infix function call
++remove.braces=Remove Braces
++remove.braces.family=Remove Braces
++add.braces=Add Braces
++add.braces.family=Add Braces","Capitalization of family name is correct, but of intention text is not. See other intentions as a reference.
+",2014-02-21 16:36:51
+119,"@@ -226,6 +226,8 @@ replace.with.dot.qualified.method.call.intention=Replace with simple method call
+ replace.with.dot.qualified.method.call.intention.family=Replace with simple method call
+ replace.with.infix.function.call.intention=Replace with infix function call
+ replace.with.infix.function.call.intention.family=Replace with infix function call
++replace.with.operator.assign.intention=Replace with an operator-assign expression
++replace.with.operator.assign.intention.family=Replace with an operator-assign expression","By convention every significant word in the intention family name should be capitalized. Compare `unfold.assignment.to.when` and `unfold.assignment.to.when.family`, for example
+",2014-02-25 14:48:13
+378,"@@ -227,7 +228,7 @@ private void checkForCastImpossibilityOrRedundancy(
+                 expression.getLeft(), context.dataFlowInfo, actualType, context);
+         for (JetType possibleType : possibleTypes) {
+             if (typeChecker.isSubtypeOf(possibleType, targetType)) {
+-                context.trace.report(USELESS_CAST_STATIC_ASSERT_IS_FINE.on(expression));
++                context.trace.report(USELESS_CAST.on(expression));","Probably this shouldn't be reported at all here?
+
+Consider this example:
+
+```
+trait A
+trait B
+trait C : A, B
+
+fun foo(a: A) {}
+fun foo(b: B) {}
+
+fun bar(c: C) = foo(c as A)   // <-- incorrect warning here, the cast is not useless
+```
+",2015-04-24 13:25:55
+882,"@@ -2278,6 +2278,14 @@
+                      language=""kotlin""
+     />
+ 
++    <localInspection implementationClass=""org.jetbrains.kotlin.idea.inspections.RedundantProgressionStepInspection""
++                     displayName=""Redundant progression step""
++                     groupName=""Kotlin""",Please provide a group path and group name for the inspection according to https://github.com/JetBrains/kotlin/commit/a09b31b5680952c56bb3ea5bbcb7939084e9f027,2017-07-07 11:45:43
+575,"@@ -228,6 +228,8 @@ fun createSpacingBuilder(settings: CodeStyleSettings, builderUtil: KotlinSpacing
+             betweenInside(REFERENCE_EXPRESSION, LAMBDA_ARGUMENT, CALL_EXPRESSION).spaces(1)
+             betweenInside(TYPE_ARGUMENT_LIST, LAMBDA_ARGUMENT, CALL_EXPRESSION).spaces(1)
+ 
++            around(IS_KEYWORD).spaces(1)","This is really minor, but still: to make the code easier to follow, I'd move this line next to the rule for the AS keyword.
+",2016-05-30 17:32:26
+382,"@@ -23,14 +23,14 @@
+ import org.jetbrains.kotlin.resolve.DescriptorUtils;
+ 
+ public abstract class AbstractClassTypeConstructor implements TypeConstructor {
+-    private boolean hashCodeComputed;
++    private volatile boolean hashCodeComputed;
+     private int hashCode;
+ 
+     @Override
+     public final int hashCode() {","@yole, Maybe there would be best to use String.hashCode() approach? It doesn't require additional volatile field. 
+What about caching fqnames for descriptors? Will it waste memory?
+",2015-06-03 08:46:12
+553,"@@ -23,38 +23,57 @@ import org.jetbrains.kotlin.idea.util.addAnnotation
+ import org.jetbrains.kotlin.idea.util.findAnnotation
+ import org.jetbrains.kotlin.name.FqName
+ import org.jetbrains.kotlin.psi.*
++import org.jetbrains.kotlin.psi.psiUtil.endOffset
++import org.jetbrains.kotlin.psi.psiUtil.startOffset
+ 
+ private val annotationFqName = FqName(""kotlin.jvm.JvmOverloads"")
+ 
+-class AddJvmOverloadsIntention : SelfTargetingIntention<KtParameterList>(
+-        KtParameterList::class.java, ""Add '@JvmOverloads' annotation""
++class AddJvmOverloadsIntention : SelfTargetingIntention<KtModifierListOwner>(
++        KtModifierListOwner::class.java, ""Add '@JvmOverloads' annotation""
+ ), LowPriorityAction {
+ 
+-    override fun isApplicableTo(element: KtParameterList, caretOffset: Int): Boolean {
+-        val parent = element.parent as? KtModifierListOwner ?: return false
+-        val target = when (parent) {
+-            is KtNamedFunction -> ""function '${parent.name}'""
+-            is KtPrimaryConstructor -> ""primary constructor""
+-            is KtSecondaryConstructor -> ""secondary constructor""
++    override fun isApplicableTo(element: KtModifierListOwner, caretOffset: Int): Boolean {
++        val (targetName, parameterList) = when (element) {
++            is KtNamedFunction -> {
++                val funKeyword = element.funKeyword ?: return false
++                val valueParameterList = element.valueParameterList ?: return false
++                if (caretOffset !in funKeyword.startOffset..valueParameterList.endOffset) {
++                    return false
++                }
++
++                ""function '${element.name}'"" to valueParameterList
++            }
++            is KtSecondaryConstructor -> {
++                val constructorKeyword = element.getConstructorKeyword()
++                val valueParameterList = element.valueParameterList ?: return false
++                if (caretOffset !in constructorKeyword.startOffset..valueParameterList.endOffset) {
++                    return false
++                }
++
++                ""secondary constructor"" to valueParameterList
++            }
++            is KtPrimaryConstructor -> ""primary constructor"" to element.valueParameterList
+             else -> return false
+         }
+-        text = ""Add '@JvmOverloads' annotation to $target""
++        val parameters = parameterList?.parameters ?: return false
++
++        text = ""Add '@JvmOverloads' annotation to $targetName""
+ 
+         return !ProjectStructureUtil.isJsKotlinModule(element.getContainingKtFile())
+-               && element.parameters.any { it.hasDefaultValue() }
+-               && parent.findAnnotation(annotationFqName) == null
++               && parameters.size > 1","This is not exactly the check that I meant. Specifically for the primary constructor, Kotlin will generate a no-argument overload when all arguments have default values, even if the @JvmOverloads annotation is not present. This doesn't happen for regular functions.
+",2016-04-29 09:57:23
+517,"@@ -235,6 +235,22 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if(indexesRange.first < 0 || indexesRange.last > lastIndex)","What is the value of `last` of empty range and of `lastIndex` of the empty list? Don't they throw an exception? You have to add corresponding tests 
+",2016-02-27 13:50:01
+519,"@@ -235,6 +235,22 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if(indexesRange.first < 0 || indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException()","It should be more debug information: exact range bounds and the list size
+",2016-02-27 13:52:37
+520,"@@ -235,6 +235,22 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if(indexesRange.first < 0 || indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException()
++        else if(indexesRange.first<=indexesRange.last)","Formatting
+",2016-02-27 13:52:52
+518,"@@ -235,6 +235,22 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if(indexesRange.first < 0 || indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException()
++        else if(indexesRange.first<=indexesRange.last)
++            subList(indexesRange.first, indexesRange.last+1)
++        else
++            listOf<T>()
++
++/**
++ * Returns the list multiplication.
++ */
++operator fun <T> List<T>.times(factor: Int): List<T> = (1..factor).flatMap { this }","Negative `factor` should throw an exception 
+",2016-02-27 13:51:33
+525,"@@ -235,6 +235,28 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if (indexesRange.first < 0)
++            throw IndexOutOfBoundsException(""Range beginning (${indexesRange.first}) is less than zero."")
++        else if (indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException(""Range end (${indexesRange.last}) is bigger then the end of table ($lastIndex)"")
++        else if (indexesRange.first <= indexesRange.last)
++            subList(indexesRange.first, indexesRange.last + 1)","It should be `toList()` after because we need a copy but `subList` just refers to the original list. 
+",2016-02-27 17:26:31
+524,"@@ -235,6 +235,28 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if (indexesRange.first < 0)
++            throw IndexOutOfBoundsException(""Range beginning (${indexesRange.first}) is less than zero."")
++        else if (indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException(""Range end (${indexesRange.last}) is bigger then the end of table ($lastIndex)"")
++        else if (indexesRange.first <= indexesRange.last)
++            subList(indexesRange.first, indexesRange.last + 1)
++        else
++            listOf<T>()
++
++/**
++ * Returns the list multiplication.
++ */
++operator fun <T> List<T>.times(factor: Int): List<T> =
++        if (factor < 0)
++            throw ArithmeticException(""List factor must be bigger then 0"")","You may just do `require(factor >= 0) {""error message… ""}`. Also notice that in Java wrong arguments should cause `IllegalArgumentException` (so it is done inside of the `require` function) 
+",2016-02-27 17:24:54
+526,"@@ -235,6 +235,30 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++public operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if (indexesRange.isEmpty())
++            listOf<T>()
++        else if (indexesRange.first < 0)
++            throw IndexOutOfBoundsException(""Range beginning (${indexesRange.first}) is less than zero."")
++        else if (indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException(""Range end (${indexesRange.last}) is bigger then the end of table ($lastIndex)"")","typo: than
+",2016-02-28 12:52:55
+527,"@@ -235,6 +235,30 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ }
+ 
+ /**
++ * Returns the elements from the list from indexes specified in range.
++ */
++public operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if (indexesRange.isEmpty())
++            listOf<T>()
++        else if (indexesRange.first < 0)
++            throw IndexOutOfBoundsException(""Range beginning (${indexesRange.first}) is less than zero."")
++        else if (indexesRange.last > lastIndex)
++            throw IndexOutOfBoundsException(""Range end (${indexesRange.last}) is bigger then the end of table ($lastIndex)"")
++        else if (indexesRange.first <= indexesRange.last)
++            subList(indexesRange.first, indexesRange.last + 1).toList()
++        else
++            throw Exception(""Unknown exception in getting range of indexes from list"")
++
++/**
++ * Returns the list multiplication.
++ */
++public operator fun <T> List<T>.times(factor: Int): List<T> {
++    require(factor >= 0) { ""List factor must be bigger then 0"" }","Type: than
+Also lets include actual value in the message 
+",2016-02-28 12:53:53
+306,"@@ -236,7 +276,7 @@ public inline fun <K, V, C : MutableMap<K, V>> Map<K, V>.filterNotTo(destination
+ }
+ 
+ /**
+- * Returns a map containing all key-value pairs matching the given *predicate*
++ * Returns a map containing all key-value pairs not matching the given [predicate].","Returns a _new_ map
+",2015-02-09 16:09:41
+540,"@@ -237,24 +237,26 @@ public fun <T> List<T>.binarySearch(fromIndex: Int = 0, toIndex: Int = size, com
+ /**
+  * Returns the elements from the list from indexes specified in range.
+  */
+-operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
+-        if (indexesRange.first < 0)
++public operator fun <T> List<T>.get(indexesRange: IntRange): List<T> =
++        if (indexesRange.isEmpty())
++            listOf<T>()
++        else if (indexesRange.first < 0)
+             throw IndexOutOfBoundsException(""Range beginning (${indexesRange.first}) is less than zero."")
+         else if (indexesRange.last > lastIndex)
+             throw IndexOutOfBoundsException(""Range end (${indexesRange.last}) is bigger then the end of table ($lastIndex)"")
+         else if (indexesRange.first <= indexesRange.last)
+-            subList(indexesRange.first, indexesRange.last + 1)
++            subList(indexesRange.first, indexesRange.last + 1).toList()
+         else
+-            listOf<T>()
++            throw Exception(""Unknown exception in getting range of indexes from list"")
+ 
+ /**
+  * Returns the list multiplication.
+  */
+-operator fun <T> List<T>.times(factor: Int): List<T> =
+-        if (factor < 0)
+-            throw ArithmeticException(""List factor must be bigger then 0"")
+-        else
+-            (1..factor).flatMap { this }
++public operator fun <T> List<T>.times(factor: Int): List<T> {
++    require(factor >= 0) { ""List factor must be bigger then 0"" }","""than"", also is 0 itself valid or not?
+",2016-04-21 07:24:05
+577,"@@ -24,11 +24,11 @@ internal fun <K, V> Map<K, V>.getOrImplicitDefault(key: K): V {
+ /**
+  * Returns a wrapper of this read-only map, having the implicit default value provided with the specified function [defaultValue].
+  * This implicit default value is used when properties are delegated to the returned map,
+- * and that map doesn't contain value for the key specified.
++ * and that map doesn't contain a value for the key specified.
+  *
+- * When this map already have an implicit default value provided with a former call to [withDefault], it is being replaced by this call.
++ * When this map already has an implicit default value provided with a former call to [withDefault], it is being replaced by this call.
+  */
+-public fun <K, V> Map<K, V>.withDefault(defaultValue: (key: K) -> V): Map<K, V> =
++fun <K, V> Map<K, V>.withDefault(defaultValue: (key: K) -> V): Map<K, V> =","Missing `public` modifier.
+",2016-06-07 14:34:38
+249,"@@ -24,19 +24,38 @@ import org.apache.commons.io.FileUtils
+ import org.jetbrains.kotlin.gradle.plugin.*
+ import org.gradle.api.Project
+ import org.jetbrains.jet.config.Services
+-
+-public open class KotlinCompile(): AbstractCompile() {
+-
++import org.jetbrains.jet.cli.js.K2JSCompiler
++import org.jetbrains.jet.cli.common.arguments.K2JSCompilerArguments
++import org.jetbrains.k2js.config.MetaInfServices
++import org.jetbrains.k2js.config.ClassPathLibraryDefintionsConfig
++import org.jetbrains.jet.cli.common.CLIConfigurationKeys
++import org.jetbrains.jet.config.CompilerConfiguration
++import org.jetbrains.jet.cli.jvm.compiler.CompileEnvironmentUtil
++import org.jetbrains.jet.cli.jvm.compiler.JetCoreEnvironment
++import com.intellij.openapi.Disposable
++import com.intellij.openapi.util.Disposer
++import org.jetbrains.k2js.config.EcmaVersion
++import org.gradle.api.tasks.Copy
++import org.gradle.api.Action
++import org.gradle.api.internal.project.ProjectInternal
++import groovy.lang.Closure
++import org.codehaus.groovy.runtime.MethodClosure
++import org.gradle.api.DefaultTask
++import org.jetbrains.jet.cli.common.arguments.CommonCompilerArguments
++import org.jetbrains.jet.cli.common.CLICompiler
++
++
++abstract class AbstractKotlinCompile<T : CommonCompilerArguments>(): AbstractCompile() {
+     val srcDirsSources = HashSet<SourceDirectorySet>()
+-    val compiler = K2JVMCompiler()
++    abstract protected val compiler: CLICompiler<T>
++    abstract protected fun createBlankArgs(): T
++    public var kotlinOptions: T = createBlankArgs()
++
++    public var kotlinDestinationDir : File? = getDestinationDir()","Unnecessary space before colon(`:`)
+",2014-11-11 17:05:49
+393,"@@ -24,7 +24,7 @@ fileAnnotations
+   ;
+ 
+ fileAnnotation
+-  : ""@"" ""file"" "":"" (""["" annotationEntry+ ""]"" | annotationEntry)
++  : ""@"" ""file"" "":"" (""["" annotation+ ""]"" | annotation)","I think it should be `unescapedAnnotation` instead of `annotation`.
+Probably we should also remove `("":"" ""file"")?` part from `annotationPrefix`.
+",2015-07-15 11:50:08
+995,"@@ -241,7 +241,8 @@ class DefaultExpressionConverter : JavaElementVisitor(), ExpressionConverter {
+         }
+         val name = if (primitiveType != null) {
+             ""javaPrimitiveType""
+-        } else {
++        }
++        else {",It is wrong according to Java Code Conventions,2017-08-16 15:39:44
+110,"@@ -244,7 +244,10 @@
+     <inspection_tool class=""MethodOverloadsParentMethod"" enabled=""true"" level=""WARNING"" enabled_by_default=""true"" />
+     <inspection_tool class=""MethodOverridesPrivateMethod"" enabled=""true"" level=""WARNING"" enabled_by_default=""true"" />
+     <inspection_tool class=""MethodOverridesStaticMethod"" enabled=""true"" level=""WARNING"" enabled_by_default=""true"" />
+-    <inspection_tool class=""MissingOverrideAnnotation"" enabled=""true"" level=""WARNING"" enabled_by_default=""true"" />
++    <inspection_tool class=""MissingOverrideAnnotation"" enabled=""true"" level=""WARNING"" enabled_by_default=""true"">
++      <option name=""ignoreObjectMethods"" value=""true"" />
++      <option name=""ignoreAnonymousClassMethods"" value=""false"" />
++    </inspection_tool>","This should be reverted
+",2014-02-21 16:35:27
+582,"@@ -245,10 +245,12 @@ class KotlinCodeFragmentFactory: CodeFragmentFactory() {
+         fun createCodeFragmentForLabeledObjects(project: Project, markupMap: Map<*, ValueMarkup>): Pair<String, Map<String, Value>> {
+             val sb = StringBuilder()
+             val labeledObjects = HashMap<String, Value>()
++            val psiNameHelper = PsiNameHelper.getInstance(project)
++
+             val entrySet: Set<Map.Entry<*, ValueMarkup>> = markupMap.entries
+             for ((value, markup) in entrySet) {
+                 val labelName = markup.text
+-                if (!Name.isValidIdentifier(labelName)) continue
++                if (!Name.isValidIdentifier(labelName) || !psiNameHelper.isIdentifier(labelName)) continue","Do we need Name.isValidIdentifier() here at all?
+",2016-07-15 13:48:52
+530,"@@ -246,4 +246,32 @@ private fun rangeCheck(size: Int, fromIndex: Int, toIndex: Int) {
+     }
+ }
+ 
++/**
++ * List ""and"" operation that returns elements that are in both lists in number of lower list
++ * Note that listOf(1, 1) and listOf(1, 1, 1) == listOf(1, 1)
++ */
++infix fun <T> List<T>.and(secList: List<T>): List<T> {
++    var tempSecList = secList
++    return filter {
++        if ( it in tempSecList ) {
++            tempSecList -= it
++            true
++        } else {
++            false
++        }
++    }
++}
+ 
++/**
++ * List ""or"" operation that returns elements that are in both lists in number of lower list
++ * Note that listOf(1, 1) and listOf(1, 1, 1) == listOf(1, 1, 1)","listOf(1, 1) OR listOf(1, 1, 1) == listOf(1, 1, 1) !?
+",2016-03-17 21:49:05
+485,"@@ -248,6 +250,18 @@ abstract class AbstractKotlinPlugin @Inject constructor(val scriptHandler: Scrip
+             }
+         })
+     }
++
++    private fun configureResolutionStrategy(project: Project) {
++        val projectVersion = loadKotlinVersionFromResource(project.logger)
++        project.configurations.all(Action<Configuration> { configuration ->
++            configuration.resolutionStrategy.eachDependency { details ->
++                val requested = details.requested
++                if (requested.group.equals(""org.jetbrains.kotlin"") && requested.version.isEmpty()) {
++                    details.useTarget(""${requested.group}:${requested.name}:$projectVersion"")","Why do you put `project.version` here? shouldn't you somehow lookup Kotlin plugin version here?
+",2015-10-28 13:06:10
+329,"@@ -25,65 +25,146 @@ package kotlin
+ public class Byte private () : Number, Comparable<Byte> {
+     default object {}
+ 
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public override fun compareTo(other: Byte): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Char): Int","Comparing byte with char for ordering probably requires more description about what it really means.
+",2015-03-12 14:42:57
+330,"@@ -25,65 +25,146 @@ package kotlin
+ public class Byte private () : Number, Comparable<Byte> {
+     default object {}
+ 
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public override fun compareTo(other: Byte): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Char): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Short): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Int): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Long): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Float): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Double): Int
+ 
++    /** Adds the two values. */
+     public fun plus(other: Byte): Int
++    /** Adds the two values. */
+     public fun plus(other: Char): Int
++    /** Adds the two values. */
+     public fun plus(other: Short): Int
++    /** Adds the two values. */
+     public fun plus(other: Int): Int
++    /** Adds the two values. */
+     public fun plus(other: Long): Long
++    /** Adds the two values. */
+     public fun plus(other: Float): Float
++    /** Adds the two values. */","""Adds the other value to this value.""
+like in `minus`
+",2015-03-12 14:43:35
+331,"@@ -25,65 +25,146 @@ package kotlin
+ public class Byte private () : Number, Comparable<Byte> {
+     default object {}
+ 
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public override fun compareTo(other: Byte): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Char): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Short): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Int): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Long): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Float): Int
++/**
++ * Compares this value with the specified value for order.
++ * Returns zero if this value is equal to the specified other value, a negative number if its less than other, 
++ * or a positive number if its greater than other.
++ */
+     public fun compareTo(other: Double): Int
+ 
++    /** Adds the two values. */
+     public fun plus(other: Byte): Int
++    /** Adds the two values. */
+     public fun plus(other: Char): Int
++    /** Adds the two values. */
+     public fun plus(other: Short): Int
++    /** Adds the two values. */
+     public fun plus(other: Int): Int
++    /** Adds the two values. */
+     public fun plus(other: Long): Long
++    /** Adds the two values. */
+     public fun plus(other: Float): Float
++    /** Adds the two values. */
+     public fun plus(other: Double): Double
+ 
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Byte): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Char): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Short): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Int): Int
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Long): Long
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Float): Float
++    /** Subtracts the other value from this value. */
+     public fun minus(other: Double): Double
+ 
++    /** Multiplies the two values. */","Multiplies this value by the other value.
+",2015-03-12 14:43:56
+971,"@@ -256,6 +255,16 @@ public KotlinType getBodyExpressionType(
+         DataFlowInfo beforeJumpInfo = newContext.dataFlowInfo;
+         boolean jumpOutPossible = false;
+         for (Iterator<? extends KtElement> iterator = block.iterator(); iterator.hasNext(); ) {
++            // Use filtering trace to keep effect system cache only for one statement","For me this place is not very clear, check it with @erokhins ",2017-08-15 16:02:59
+491,"@@ -257,7 +258,7 @@ public class KotlinCoreEnvironment private constructor(
+             val appEnv = getOrCreateApplicationEnvironmentForProduction(configuration, configFilePaths)
+             // Disposing of the environment is unsafe in production then parallel builds are enabled, but turning it off universally
+             // breaks a lot of tests, therefore it is disabled for production and enabled for tests
+-            if (System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY) == null) {
++            if (!(System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY).toBooleanLenient() ?: false)) {","This could be written as
+
+```
+if (KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY.systemPropertyAsBooleanOrTrueOtherwise(negate = true)) {
+```
+",2015-11-27 18:21:30
+267,"@@ -264,3 +264,35 @@ public fun <K, V> Iterable<Pair<K, V>>.toMap(): Map<K, V> {
+  * Converts this [Map] to a [LinkedHashMap] so future insertion orders are maintained
+  */
+ public fun <K, V> Map<K, V>.toLinkedMap(): MutableMap<K, V> = LinkedHashMap(this)
++
++/**
++ * Create a new read-only map from a map and a single new key-value pair
++ */
++public fun <K, V> Map<K, V>.plus(pair: Pair<K, V>): Map<K, V> {
++    val newMap = this.toLinkedMap()
++    newMap.put(pair.first, pair.second)
++    return newMap
++}
++
++/**
++ * Create a new read-only map from a map and a list new key-value pairs
++ */
++public fun <K, V> Map<K, V>.plus(pairs: Collection<Pair<K, V>>): Map<K, V> {
++    val newMap = this.toLinkedMap()
++    newMap.putAll(pairs)
++    return newMap
++}
++
++/**
++ * Create a new read-only map by removing a key
++ */
++public fun <K, V> Map<K, V>.minus(key: K): Map<K, V> {
++    return this.filterKeys { key != it }
++}
++
++/**
++ * Create a new read-only map by removing a list of keys","> list of
+
+oops
+",2015-01-15 07:02:10
+572,"@@ -28,41 +28,47 @@ import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
+ class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
+ 
+     val patterns = mapOf(
+-            ""java.io.PrintStream.println"" to ""println($0)"",
+-            ""java.io.PrintStream.print"" to ""print($0)"",
+-            ""java.util.Collections.sort"" to ""$0.sort()""
++            ""java.io.PrintStream.println"" to Pair(""println($0)"", false),","This boolean value is quite unclear. Much better to use an enum instead.
+",2016-05-23 17:59:43
+571,"@@ -28,41 +28,47 @@ import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
+ class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
+ 
+     val patterns = mapOf(
+-            ""java.io.PrintStream.println"" to ""println($0)"",
+-            ""java.io.PrintStream.print"" to ""print($0)"",
+-            ""java.util.Collections.sort"" to ""$0.sort()""
++            ""java.io.PrintStream.println"" to Pair(""println($0)"", false),
++            ""java.io.PrintStream.print"" to Pair(""print($0)"", false),
++            ""java.util.Collections.sort"" to Pair(""$0.sort()"", false),
++            ""java.util.HashMap.put"" to Pair(""$0[$1] = $2"", true)
+     )
+ 
+     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
+         return object : KtVisitorVoid() {
+             override fun visitQualifiedExpression(expression: KtQualifiedExpression) {
+                 super.visitQualifiedExpression(expression)
+ 
+-                val selectorExpression = expression.selectorExpression ?: return
+-                if (selectorExpression !is KtCallExpression) return
+-                val value = selectorExpression.valueArguments.singleOrNull() ?: return
++                val selectorExpression = expression.selectorExpression
++                if(selectorExpression !is KtCallExpression) return
++                val arguments = selectorExpression.valueArguments
++                if(arguments.isEmpty()) return
+ 
+                 val calleeExpression = selectorExpression.calleeExpression as KtSimpleNameExpression
+                 val bindingContext = calleeExpression.analyze(BodyResolveMode.PARTIAL)
+                 val target = calleeExpression.mainReference.resolveToDescriptors(bindingContext).singleOrNull() ?: return
+-                val pattern = target.fqNameSafe.asString()
+-                if (!patterns.containsKey(pattern)) return
+-
+-                holder.registerProblem(expression,
+-                                       ""Unnecessary java usage"",
+-                                       ProblemHighlightType.WEAK_WARNING,
+-                                       UnnecessaryJavaUsageFix(patterns[pattern]!!, value.text))
++                val pattern = patterns[target.fqNameSafe.asString()] ?: return
++                val javaUsageFix = UnnecessaryJavaUsageFix(pattern, expression.receiverExpression, arguments.map{it.text})
++                holder.registerProblem(expression, ""Unnecessary java usage"", ProblemHighlightType.WEAK_WARNING, javaUsageFix)","Once again ""unnecessary java usage"".
+",2016-05-23 17:58:23
+573,"@@ -28,41 +28,47 @@ import org.jetbrains.kotlin.resolve.lazy.BodyResolveMode
+ class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalInspectionTool {
+ 
+     val patterns = mapOf(
+-            ""java.io.PrintStream.println"" to ""println($0)"",
+-            ""java.io.PrintStream.print"" to ""print($0)"",
+-            ""java.util.Collections.sort"" to ""$0.sort()""
++            ""java.io.PrintStream.println"" to Pair(""println($0)"", false),
++            ""java.io.PrintStream.print"" to Pair(""print($0)"", false),
++            ""java.util.Collections.sort"" to Pair(""$0.sort()"", false),
++            ""java.util.HashMap.put"" to Pair(""$0[$1] = $2"", true)
+     )
+ 
+     override fun buildVisitor(holder: ProblemsHolder, isOnTheFly: Boolean, session: LocalInspectionToolSession): PsiElementVisitor {
+         return object : KtVisitorVoid() {
+             override fun visitQualifiedExpression(expression: KtQualifiedExpression) {
+                 super.visitQualifiedExpression(expression)
+ 
+-                val selectorExpression = expression.selectorExpression ?: return
+-                if (selectorExpression !is KtCallExpression) return
+-                val value = selectorExpression.valueArguments.singleOrNull() ?: return
++                val selectorExpression = expression.selectorExpression
++                if(selectorExpression !is KtCallExpression) return
++                val arguments = selectorExpression.valueArguments
++                if(arguments.isEmpty()) return
+ 
+                 val calleeExpression = selectorExpression.calleeExpression as KtSimpleNameExpression
+                 val bindingContext = calleeExpression.analyze(BodyResolveMode.PARTIAL)
+                 val target = calleeExpression.mainReference.resolveToDescriptors(bindingContext).singleOrNull() ?: return
+-                val pattern = target.fqNameSafe.asString()
+-                if (!patterns.containsKey(pattern)) return
+-
+-                holder.registerProblem(expression,
+-                                       ""Unnecessary java usage"",
+-                                       ProblemHighlightType.WEAK_WARNING,
+-                                       UnnecessaryJavaUsageFix(patterns[pattern]!!, value.text))
++                val pattern = patterns[target.fqNameSafe.asString()] ?: return
++                val javaUsageFix = UnnecessaryJavaUsageFix(pattern, expression.receiverExpression, arguments.map{it.text})
++                holder.registerProblem(expression, ""Unnecessary java usage"", ProblemHighlightType.WEAK_WARNING, javaUsageFix)
+             }
+         }
+     }
+ 
+-    private class UnnecessaryJavaUsageFix(val pattern: String, val value: String) : LocalQuickFix {
++    private class UnnecessaryJavaUsageFix(val pattern: Pair<String, Boolean>,","Better to unpack the pair and to use separate arguments for the text and conversion mode.
+",2016-05-23 18:01:13
+969,"@@ -28,60 +28,60 @@ public inline fun TODO(reason: String): Nothing = throw NotImplementedError(""An
+  * Calls the specified function [block] and returns its result.
+  */
+ @kotlin.internal.InlineOnly
+-public inline fun <R> run(block: () -> R): R = block()
++public inline fun <R> run(@kotlin.internal.CalledInPlace(kotlin.internal.InvocationCount.EXACTLY_ONCE) block: () -> R): R = block()",Can we annotate also both `TODO` functions?,2017-08-15 15:56:21
+388,"@@ -287,16 +314,24 @@ static void replaceFile(File updatedFile, VirtualFile replacedJarFile) {
+     @NotNull
+     private static Collection<VirtualFile> getLibraryRootsWithAbiIncompatibleVersion(
+             @NotNull Project project,
+-            @NotNull ScalarIndexExtension<Integer> index
++            @NotNull ScalarIndexExtension<Integer> index,
++            @NotNull Predicate<Module> checkModule,
++            @NotNull Predicate<Integer> checkAbiVersion
+     ) {
+         ID<Integer, Void> id = index.getName();
+-        Collection<Integer> abiVersions = FileBasedIndex.getInstance().getAllKeys(id, project);
+-        Set<Integer> badAbiVersions = Sets.newHashSet(Collections2.filter(abiVersions, new Predicate<Integer>() {
+-            @Override
+-            public boolean apply(Integer abiVersion) {
+-                return !AbiVersionUtil.isAbiVersionCompatible(abiVersion);
++
++        Module[] modules = ModuleManager.getInstance(project).getModules();
++
++        List<Module> modulesToCheck = new ArrayList<Module>();
++        for(Module module : modules) {","If you're using `Predicate`, you might as well go ahead and call `Collections2.filter` here. Also I would recommend to use `kotlin.Function1` and `KotlinPackage.filter` instead, but that's up to you
+",2015-06-11 22:05:41
+387,"@@ -287,16 +314,24 @@ static void replaceFile(File updatedFile, VirtualFile replacedJarFile) {
+     @NotNull
+     private static Collection<VirtualFile> getLibraryRootsWithAbiIncompatibleVersion(
+             @NotNull Project project,
+-            @NotNull ScalarIndexExtension<Integer> index
++            @NotNull ScalarIndexExtension<Integer> index,
++            @NotNull Predicate<Module> checkModule,
++            @NotNull Predicate<Integer> checkAbiVersion
+     ) {
+         ID<Integer, Void> id = index.getName();
+-        Collection<Integer> abiVersions = FileBasedIndex.getInstance().getAllKeys(id, project);
+-        Set<Integer> badAbiVersions = Sets.newHashSet(Collections2.filter(abiVersions, new Predicate<Integer>() {
+-            @Override
+-            public boolean apply(Integer abiVersion) {
+-                return !AbiVersionUtil.isAbiVersionCompatible(abiVersion);
++
++        Module[] modules = ModuleManager.getInstance(project).getModules();
++
++        List<Module> modulesToCheck = new ArrayList<Module>();
++        for(Module module : modules) {
++            if (checkModule.apply(module)) {
++                modulesToCheck.add(module);
+             }
+-        }));
++        }
++        if (modulesToCheck.isEmpty()) return new ArrayList<VirtualFile>();","`Collections.emptyList()`?
+",2015-06-11 22:01:48
+167,"@@ -287,6 +287,10 @@ convert.negated.expression.with.demorgans.law=Convert negated expression to DeMo
+ convert.negated.expression.with.demorgans.law.family=Convert negated expression to DeMorgan's equivalent
+ split.if=Split into 2 if's
+ split.if.family=Split If
++make.type.explicit.in.lambda=Make types explicit
++make.type.explicit.in.lambda.family=Make Types Explicit
++make.type.implicit.in.lambda=Make types implicit
++make.type.implicit.in.lambda.family=Make Types Implicit","Why not `... in lambda` ?
+",2014-04-09 15:57:50
+482,"@@ -288,8 +288,8 @@ public String render(@NotNull BadNamedArgumentsTarget target) {
+ 
+         MAP.put(MANY_COMPANION_OBJECTS, ""Only one companion object is allowed per class"");
+ 
+-        MAP.put(DEPRECATED_SYMBOL, ""''{0}'' is deprecated."", DEPRECATION_RENDERER);
+-        MAP.put(DEPRECATED_SYMBOL_WITH_MESSAGE, ""''{0}'' is deprecated. {1}"", DEPRECATION_RENDERER, STRING);
++        MAP.put(DEPRECATION, ""''{0}'' is deprecated. {1}"", DEPRECATION_RENDERER, STRING);
++        MAP.put(DEPRECATION_ERROR, ""Calling ''{0}'' is an error. {1}"", DEPRECATION_RENDERER, STRING);","I think this error message looks weird on classes in type positions...
+",2015-10-10 12:09:49
+237,"@@ -288,9 +295,21 @@ public static Type getTraitImplThisParameterType(@NotNull ClassDescriptor traitD
+ 
+     private static Type stringValueOfOrStringBuilderAppendType(Type type) {
+         int sort = type.getSort();
+-        return sort == Type.OBJECT || sort == Type.ARRAY
+-                   ? AsmTypeConstants.OBJECT_TYPE
+-                   : sort == Type.BYTE || sort == Type.SHORT ? Type.INT_TYPE : type;
++        switch (sort) {
++            case Type.OBJECT:
++                if(STRINGBULDER_OBJECT_APPEND_ARG_TYPES.contains(type.getClassName())) {","Please add a space after `if`
+",2014-05-12 20:45:52
+87,"@@ -29,27 +29,27 @@ fun main(args: Array<String>) {
+     generateDomEventsAPI(File(jsCoreDir, ""domEvents.kt""))
+ 
+     iterators().writeTo(File(outDir, ""_Iterators.kt"")) {
+-        buildFor(Iterators, """")
++        buildFor(Iterators, null)
+     }
+ 
+     val iterables = iterables()
+-    iterables.writeTo(File(outDir, ""_Arrays.kt"")) {
+-        buildFor(Arrays, """")
++    val sumFunctions = PrimitiveType.values().map(::sumFunction).filterNotNull()
++    (iterables+sumFunctions).writeTo(File(outDir, ""_Arrays.kt"")) {
++        buildFor(Arrays, null)
+     }
+ 
+-    val otherArrayNames = arrayListOf(""Boolean"", ""Byte"", ""Char"", ""Short"", ""Int"", ""Long"", ""Float"", ""Double"")
+-    for (a in otherArrayNames) {
+-        iterables.writeTo(File(outDir, ""_${a}Arrays.kt"")) {
+-            buildFor(PrimitiveArrays, a)
++    for (primitive in PrimitiveType.values()) {
++        (iterables+sumFunction(primitive)).filterNotNull().writeTo(File(outDir, ""_${primitive.name}Arrays.kt"")) {","Let's stick to conventions: ""+"" should be surrounded by spaces
+",2013-11-27 07:33:34
+231,"@@ -292,6 +292,10 @@ convert.negated.boolean.sequence=Replace negated sequence with DeMorgan equivale
+ convert.negated.boolean.sequence.family=Replace negated sequence with DeMorgan equivalent
+ convert.negated.expression.with.demorgans.law=Convert negated expression to DeMorgan's equivalent
+ convert.negated.expression.with.demorgans.law.family=Convert negated expression to DeMorgan's equivalent
++add.for.loop.indices=Add indices to for loop
++add.for.loop.indices.family=Add indices to for loop","Should be `Add Indices to For Loop`, take a look at https://github.com/JetBrains/kotlin/commit/5a0055cbeb90b0c6d80c223d4d68cc451d0ccfc1
+",2014-05-12 12:49:03
+232,"@@ -292,6 +292,10 @@ convert.negated.boolean.sequence=Replace negated sequence with DeMorgan equivale
+ convert.negated.boolean.sequence.family=Replace negated sequence with DeMorgan equivalent
+ convert.negated.expression.with.demorgans.law=Convert negated expression to DeMorgan's equivalent
+ convert.negated.expression.with.demorgans.law.family=Convert negated expression to DeMorgan's equivalent
++add.for.loop.indices=Add indices to for loop
++add.for.loop.indices.family=Add indices to for loop
++remove.for.loop.indices=Remove indices from for loop
++remove.for.loop.indices.family=Remove indices from for loop","`Remove Indices from For Loop`
+",2014-05-12 12:49:12
+328,"@@ -2945,6 +2946,12 @@ public Unit invoke(InstructionAdapter v) {
+         });
+     }
+ 
++    private static boolean isInRangeValueType(Type type) {","There's `AsmUtil#isIntPrimitive`
+",2015-03-04 20:31:13
+174,"@@ -295,7 +295,10 @@ simplify.boolean.with.constants=Simplify boolean expression
+ simplify.boolean.with.constants.family=Simplify boolean expression
+ insert.explicit.type.arguments=Add explicit type arguments
+ insert.explicit.type.arguments.family=Add explicit type arguments
+->>>>>>> Intention for adding explicit type arguments at function calls
++make.type.explicit.in.lambda=Make types explicit
++make.type.explicit.in.lambda.family=Make Types Explicit
++make.type.implicit.in.lambda=Make types implicit
++make.type.implicit.in.lambda.family=Make Types Implicit","Why not ""Make types explicit/implicit **in lambda**""? I believe I asked you this the first time
+",2014-04-16 16:44:54
+193,"@@ -295,7 +295,10 @@ simplify.boolean.with.constants=Simplify boolean expression
+ simplify.boolean.with.constants.family=Simplify boolean expression
+ insert.explicit.type.arguments=Add explicit type arguments
+ insert.explicit.type.arguments.family=Add explicit type arguments
+->>>>>>> Intention for adding explicit type arguments at function calls
++make.type.explicit.in.lambda=Make types explicit in lambda
++make.type.explicit.in.lambda.family=Make Types Explicit In Lambda
++make.type.implicit.in.lambda=Make types implicit in lambda(may break code)","Please add a space before `(` :)
+",2014-04-22 21:59:49
+194,"@@ -295,7 +295,10 @@ simplify.boolean.with.constants=Simplify boolean expression
+ simplify.boolean.with.constants.family=Simplify boolean expression
+ insert.explicit.type.arguments=Add explicit type arguments
+ insert.explicit.type.arguments.family=Add explicit type arguments
+->>>>>>> Intention for adding explicit type arguments at function calls
++make.type.explicit.in.lambda=Make types explicit in lambda
++make.type.explicit.in.lambda.family=Make Types Explicit In Lambda
++make.type.implicit.in.lambda=Make types implicit in lambda(may break code)
++make.type.implicit.in.lambda.family=Make Types Implicit In Lambda(May Break Code)","Ditto
+",2014-04-22 22:00:15
+298,"@@ -3,12 +3,12 @@ package kotlin
+ import java.util.*
+ 
+ /**
+- * Returns a new [[SortedSet]] with the initial elements
++ * Returns a new [SortedSet] with the given elements.
+  */
+ public fun sortedSetOf<T>(vararg values: T): TreeSet<T> = values.toCollection(TreeSet<T>())
+ 
+ /**
+- * Returns a new [[SortedSet]] with the given *comparator* and the initial elements
++ * Returns a new [SortedSet] with the given [comparator] and initial elements.","initial -> given as in the function above
+",2015-02-09 16:00:52
+950,"@@ -3,13 +3,13 @@ import kotlinApi.*
+ //TODO: Formatter works incorrectly
+ internal class A {
+     fun foo(c: KotlinClass): Int {
+-        return c.nullableProperty!!.length
+-        +c.property.length
+-        +KotlinClass.nullableStaticVar!!
+-        +KotlinClass.staticVar
+-        +KotlinClass.nullableStaticFun(1)!!
+-        +KotlinClass.staticFun(1)
+-        +nullableGlobalFunction("""")!!.length
+-        +globalFunction("""").length
++        return (c.nullableProperty!!.length",After changes TODO comment above your code should be removed. You've already fixed it.,2017-08-04 08:43:46
+689,"@@ -3,7 +3,7 @@
+     <property file=""resources/kotlinManifest.properties""/>
+ 
+     <!-- Set to false to disable proguard run on kotlin-compiler.jar. Speeds up the build -->
+-    <property name=""shrink"" value=""true""/>
++    <property name=""shrink"" value=""false""/>",Why? :(,2017-04-05 11:15:01
+296,"@@ -3,7 +3,7 @@ package kotlin
+ import java.util.Enumeration
+ 
+ /**
+- * Helper to make java.util.Enumeration usable in for
++ * Helper to make [Enumeration] usable in `for` loops.","""Creates `Iterator<T>` for an `Enumeration<T>`""
+",2015-02-09 15:59:24
+641,"@@ -3,9 +3,9 @@ fun foo() {
+         fun test() {}
+     }
+ 
+-    val d: A
++    val d =
+     if (<caret>) {
+-        d = A()
++        A()","I expected to generate following code
+
+``` kotlin
+    class A {
+        fun test() {}
+    }
+    val d = if () {
+        A()
+    }
+```
+
+I don't think this new line is the problem with this pull request.
+
+If I have following case
+
+``` kotlin
+fun foo() {
+    <selection>class A {
+        fun test() {}
+    }
+
+
+
+    val d: A = A()</selection>
+
+    d.test()
+    A()
+}
+```
+
+For current kotlin plugin converts them into 
+
+``` kotlin
+    class A {
+        fun test() {
+        }
+    }
+
+    val d: A
+
+
+    if () {
+        d = A()
+    }
+```
+",2016-10-16 07:46:40
+637,"@@ -30,5 +32,10 @@ class RemoveEmptyClassBodyInspection : IntentionBasedInspection<KtClassBody>(Rem
+ class RemoveEmptyClassBodyIntention : SelfTargetingOffsetIndependentIntention<KtClassBody>(KtClassBody::class.java, ""Remove empty class body"") {
+     override fun applyTo(element: KtClassBody, editor: Editor?) = element.delete()
+ 
+-    override fun isApplicableTo(element: KtClassBody) = element.text.replace(""{"", """").replace(""}"", """").isBlank()
++    override fun isApplicableTo(element: KtClassBody): Boolean {
++        element.getStrictParentOfType<KtObjectDeclaration>()?.let {","Won't
+
+```
+object Foo {
+    class Bar {}
+}
+```
+
+cause a false negative here?
+",2016-10-13 15:07:19
+649,"@@ -31,18 +31,49 @@ class ReplaceSingleLineLetIntention : SelfTargetingOffsetIndependentIntention<Kt
+         ""Remove redundant '.let' call""
+ ) {
+     override fun applyTo(element: KtCallExpression, editor: Editor?) {
+-        val lambdaExpression = element.lambdaArguments.firstOrNull()?.getLambdaExpression() ?: return
+-        val bodyExpression = lambdaExpression.bodyExpression?.children?.singleOrNull() ?: return
+-        val dotQualifiedExpression = bodyExpression as? KtDotQualifiedExpression ?: return
++        element.lambdaArguments.firstOrNull()?.getLambdaExpression()?.bodyExpression?.children?.singleOrNull()?.let {
++            when (it) {
++                is KtDotQualifiedExpression -> it.applyTo(element)
++                is KtBinaryExpression -> it.applyTo(element)
++            }
++        }
++    }
++
++    private fun KtBinaryExpression.applyTo(element: KtCallExpression) {
++        val left = left ?: return
++        val factory = KtPsiFactory(element.project)
++        val parent = element.parent
++        when (parent) {
++            is KtQualifiedExpression -> {
++                val receiver = parent.receiverExpression
++                val newLeft = when (left) {
++                    is KtDotQualifiedExpression -> left.replaceFirstReceiver(factory, receiver, parent.operationSign == KtTokens.SAFE_ACCESS)
++                    else -> receiver
++                }
++                val newExpression = factory.createExpression(""${newLeft.text}${operationReference.text}${right?.text ?: """"}"")","I think `createExpressionByPattern` should be better here and below. I'm trying to avoid using `text`, when possible.
+",2016-11-07 09:24:47
+693,"@@ -31,7 +31,7 @@ import java.io.InputStream
+ class CliVirtualFileFinder(
+         private val index: JvmDependenciesIndex,
+         private val scope: GlobalSearchScope
+-) : VirtualFileFinder() {
++) : JavacVirtualFileFinder() {",Check attentively that nothing is changed without `use-javac` option,2017-04-05 11:29:09
+268,"@@ -313,14 +315,21 @@ private boolean shouldInitializeProperty(@NotNull JetProperty property) {
+         PropertyDescriptor propertyDescriptor = (PropertyDescriptor) bindingContext.get(VARIABLE, property);
+         assert propertyDescriptor != null;
+ 
+-        CompileTimeConstant<?> compileTimeValue = propertyDescriptor.getCompileTimeInitializer();
++        JetExpression initializer = property.getInitializer();
++
++        CompileTimeConstant<?> initializerValue =
++                property.isVar() && initializer != null
++                ? ConstantExpressionEvaluator.OBJECT$.evaluate(initializer, state.getBindingTrace(), null)","I suggest to use a temporary trace here (and discard it) instead of `state.getBindingTrace()` so that `ConstantExpressionEvaluator` won't unexpectedly write to the global trace and alter the subsequent code generation.
+",2015-01-30 13:22:36
+323,"@@ -32,15 +32,49 @@ public annotation class noinline
+  */
+ public annotation class inline(public val strategy: InlineStrategy = InlineStrategy.AS_FUNCTION)
+ 
++/**
++ * Specifies the strategy for JVM bytecode generation for an inline function.","It's not JVM specific.
+",2015-03-02 12:11:37
+925,"@@ -32,6 +50,7 @@ interface DependenciesResolver : @Suppress(""DEPRECATION"") ScriptDependenciesReso
+ 
+     sealed class ResolveResult {","I'd simplify this by assuming that the result is ""success"" iff there are no errors:
+```
+data class ResolutionResult(
+    val dependencies: ScriptDependencies, // ScriptDependencies.Empty in case of failure
+    val diagnostics: List<ScriptDiagnostic>
+) {
+    val isSuccess: Boolean get() = diagnostics.none { it.severity == ERROR } // maybe an extension
+}
+```
+",2017-07-25 11:29:13
+924,"@@ -32,6 +50,7 @@ interface DependenciesResolver : @Suppress(""DEPRECATION"") ScriptDependenciesReso
+ 
+     sealed class ResolveResult {
+         abstract val dependencies: ScriptDependencies?
++        // reports -> diagnostics",+1 for `val diagnostics: List<ScriptDiagnostic>`,2017-07-25 11:25:01
+376,"@@ -327,12 +327,12 @@ else if (containingDescriptor instanceof FunctionDescriptor || containingDescrip
+         return defaultVisibility;
+     }
+ 
+-    public static Modality getDefaultModality(DeclarationDescriptor containingDescriptor, boolean isBodyPresent) {
++    public static Modality getDefaultModality(DeclarationDescriptor containingDescriptor, Visibility visibility, boolean isBodyPresent) {
+         Modality defaultModality;
+         if (containingDescriptor instanceof ClassDescriptor) {
+             boolean isTrait = ((ClassDescriptor) containingDescriptor).getKind() == ClassKind.TRAIT;
+             boolean isDefinitelyAbstract = isTrait && !isBodyPresent;
+-            Modality basicModality = isTrait ? Modality.OPEN : Modality.FINAL;
++            Modality basicModality = isTrait && visibility != Visibilities.PRIVATE ? Modality.OPEN : Modality.FINAL;","Please use `Visibilities.isPrivate` instead & add a test on a private-to-this fun/val in a trait
+",2015-04-20 14:38:27
+763,"@@ -33,10 +33,18 @@ public class StringBuilder(content: String = """") : Appendable, CharSequence {
+     override val length: Int
+         get() = string.asDynamic().length
+ 
++    fun setLength(newLength : Int) {
++        string = string.substring(0, newLength)",This implementation doesn't conform to the `setLength` method contract.,2017-04-17 19:05:52
+766,"@@ -33,6 +33,7 @@
+ public class KotlinEditorOptions implements PersistentStateComponent<KotlinEditorOptions> {
+     private boolean donTShowConversionDialog = false;
+     private boolean enableJavaToKotlinConversion = true;
++    private boolean enableSmartEditing = true;","I don't like the idea of adding a preference for this behavior. First of all, the name of the preference says nothing at all to the user. Second, if anyone becomes annoyed by the behavior, it's quite hard for them to discover how to change it.",2017-04-19 10:20:22
+576,"@@ -33,7 +33,7 @@
+         <dependency>
+             <groupId>com.android.tools.build</groupId>
+             <artifactId>gradle</artifactId>
+-            <version>1.1.0</version>
++            <version>1.3.0</version>","I suppose this isn't strictly needed since the plugin is looked up by name.
+",2016-06-06 03:48:55
+315,"@@ -34,33 +34,38 @@ private object EmptySet : Set<Any> {
+     override fun toString(): String = set.toString()
+ }
+ 
++/** Returns an empty read-only list. */
+ public fun emptyList<T>(): List<T> = EmptyList as List<T>
++/** Returns an empty read-only set. */
+ public fun emptySet<T>(): Set<T> = EmptySet as Set<T>
+ 
+ /** Returns a new read-only list of given elements */
+ public fun listOf<T>(vararg values: T): List<T> = if (values.size() == 0) emptyList() else arrayListOf(*values)
+ 
+-/** Returns an empty read-only list */
++/** Returns an empty read-only list. */
+ public fun listOf<T>(): List<T> = emptyList()
+ 
+-/** Returns a new read-only ordered set of given elements */
++/** Returns a new read-only ordered set with the given elements. */
+ public fun setOf<T>(vararg values: T): Set<T> = if (values.size() == 0) emptySet() else values.toCollection(LinkedHashSet<T>())
+ 
+-/** Returns an empty read-only set */
++/** Returns an empty read-only set. */
+ public fun setOf<T>(): Set<T> = emptySet()
+ 
+-/** Returns a new LinkedList with a variable number of initial elements */
++/** Returns a new LinkedList with the given elements. */","Linkify LinkedList
+",2015-02-11 08:32:02
+316,"@@ -34,33 +34,38 @@ private object EmptySet : Set<Any> {
+     override fun toString(): String = set.toString()
+ }
+ 
++/** Returns an empty read-only list. */
+ public fun emptyList<T>(): List<T> = EmptyList as List<T>
++/** Returns an empty read-only set. */
+ public fun emptySet<T>(): Set<T> = EmptySet as Set<T>
+ 
+ /** Returns a new read-only list of given elements */
+ public fun listOf<T>(vararg values: T): List<T> = if (values.size() == 0) emptyList() else arrayListOf(*values)
+ 
+-/** Returns an empty read-only list */
++/** Returns an empty read-only list. */
+ public fun listOf<T>(): List<T> = emptyList()
+ 
+-/** Returns a new read-only ordered set of given elements */
++/** Returns a new read-only ordered set with the given elements. */
+ public fun setOf<T>(vararg values: T): Set<T> = if (values.size() == 0) emptySet() else values.toCollection(LinkedHashSet<T>())
+ 
+-/** Returns an empty read-only set */
++/** Returns an empty read-only set. */
+ public fun setOf<T>(): Set<T> = emptySet()
+ 
+-/** Returns a new LinkedList with a variable number of initial elements */
++/** Returns a new LinkedList with the given elements. */
+ public fun linkedListOf<T>(vararg values: T): LinkedList<T> = values.toCollection(LinkedList<T>())
+ 
+-/** Returns a new ArrayList with a variable number of initial elements */
++/** Returns a new ArrayList with the given elements. */
+ public fun arrayListOf<T>(vararg values: T): ArrayList<T> = values.toCollection(ArrayList(values.size()))
+ 
+-/** Returns a new HashSet with a variable number of initial elements */
++/** Returns a new HashSet with the given elements. */
+ public fun hashSetOf<T>(vararg values: T): HashSet<T> = values.toCollection(HashSet(values.size()))
+ 
+-/** Returns a new LinkedHashSet with a variable number of initial elements */
++/** Returns a new LinkedHashSet with the given elements. */
+ public fun linkedSetOf<T>(vararg values: T): LinkedHashSet<T> = values.toCollection(LinkedHashSet(values.size()))
+ 
++/**
++ * Returns the valid indices for this collection.","Returns an IntRange specifying the valid... 
+",2015-02-11 08:32:43
+537,"@@ -35,15 +34,45 @@ class ConvertToForEachFunctionCallIntention : SelfTargetingIntention<KtForExpres
+     override fun applyTo(element: KtForExpression, editor: Editor?) {
+         val commentSaver = CommentSaver(element)
+ 
++        val labelName = element.getLabelName()
++
+         val body = element.body!!
+         val loopParameter = element.loopParameter!!
+ 
+         val functionBodyArgument: Any = if (body is KtBlockExpression) body.contentRange() else body
+ 
+-        val foreachExpression = KtPsiFactory(element).createExpressionByPattern(
++        val psiFactory = KtPsiFactory(element)
++        val foreachExpression = psiFactory.createExpressionByPattern(
+                 ""$0.forEach{$1->$2}"", element.loopRange!!, loopParameter, functionBodyArgument)
+-        val result = element.replace(foreachExpression)
++        val result = element.replace(foreachExpression) as KtElement
++
++        result.getContinuesWithLabel(labelName).forEach {
++            it.replace(psiFactory.createExpression(""return@forEach""))
++        }
+ 
+         commentSaver.restore(result)
+     }
++
++    private fun KtElement.getContinuesWithLabel(labelName: String?): List<KtContinueExpression> {
++        val continueElements = ArrayList<KtContinueExpression>()
++
++        forEachDescendantOfType<KtContinueExpression>({ it !is KtLoopExpression }) {","I think the code will be cleaner if you merge the two loops into one.
+",2016-04-05 12:30:16
+23,"@@ -35,33 +34,35 @@
+ 
+ import javax.swing.*;
+ 
+-public class DescriptorClassMember implements ClassMemberWithElement {
++public class DescriptorClassMember extends MemberChooserObjectBase implements ClassMemberWithElement {","Copying replaced with delegation, please, pay attention - I rebased on master and squash fix into existing commit.
+",2013-01-15 19:29:16
+437,"@@ -35,6 +35,16 @@ target(AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY, AnnotationTarget.FI
+ public annotation(retention = AnnotationRetention.RUNTIME, mustBeDocumented = true) class jvmStatic
+ 
+ /**
++ * Specifies the name for the target platform element (Java method, JavaScript function)","Documentation should probably not mention JavaScript anymore
+",2015-08-25 12:48:50
+948,"@@ -354,11 +360,11 @@ fun KtTypeParameterListOwner.addTypeParameter(typeParameter: KtTypeParameter): K
+     val list = KtPsiFactory(this).createTypeParameterList(""<X>"")
+     list.parameters[0].replace(typeParameter)
+     val leftAnchor = when (this) {
+-        is KtClass -> nameIdentifier ?: getClassOrInterfaceKeyword()
+-        is KtNamedFunction -> funKeyword
+-        is KtProperty -> valOrVarKeyword
+-        else -> null
+-    } ?: return null
++                         is KtClass -> nameIdentifier ?: getClassOrInterfaceKeyword()","There is a lot of unnecessary code formatting, which make harder to find what exactly author of PR changed. @Dimach, did was intentional and done by you or automatically changed by IntelliJ?",2017-08-03 12:50:40
+570,"@@ -36,15 +40,18 @@ class UnnecessaryJavaUsageInspection : AbstractKotlinInspection(), CleanupLocalI
+ 
+                 val selectorExpression = expression.selectorExpression ?: return
+                 if (selectorExpression !is KtCallExpression) return
+-                if (selectorExpression.valueArguments.size != 1) return
+-                val value = selectorExpression.valueArguments[0].text
+-                val pattern = expression.text.replace(value, ""$0"")
++                val value = selectorExpression.valueArguments.singleOrNull() ?: return
++
++                val calleeExpression = selectorExpression.calleeExpression as KtSimpleNameExpression","The calleeExpression is not always a KtSimpleNameExpression, so you should use a safe cast here.
+",2016-05-23 17:57:41
+991,"@@ -367,7 +368,8 @@ class ControlFlowInformationProvider private constructor(
+         // Do not consider top-level properties
+         if (containingDeclarationDescriptor is PackageFragmentDescriptor) return false
+         var parentDeclaration = getElementParentDeclaration(writeValueInstruction.element)
+-        while (true) {
++
++        loop@ while (true) {",I recommend some self-describing name for this label,2017-08-16 09:39:02
+516,"@@ -37,18 +37,19 @@ class AnnotatedClassDescriptor(classFqName: String) : AnnotatedElementDescriptor
+ }
+ 
+ class AnnotatedMethodDescriptor(classFqName: String, public val methodName: String) : AnnotatedElementDescriptor(classFqName) {
+-    override fun equals(other: Any?) = other is AnnotatedMethodDescriptor && methodName == other.methodName
++    override fun equals(other: Any?) = other is AnnotatedMethodDescriptor && methodName == other.methodName && classFqName == other.classFqName
+ 
+-    override fun hashCode() = methodName.hashCode()
++    override fun hashCode() =  methodName.hashCode() + classFqName.hashCode()","Is it the best way to combine hashcodes?
+",2016-02-18 01:36:46
+545,"@@ -371,6 +371,8 @@ class QuickFixRegistrar : QuickFixContributor {
+ 
+         DATA_CLASS_NOT_PROPERTY_PARAMETER.registerFactory(AddValVarToConstructorParameterAction.QuickFixFactory)
+ 
+-        NON_LOCAL_RETURN_NOT_ALLOWED.registerFactory(AddCrossInlineFix)
++        NON_LOCAL_RETURN_NOT_ALLOWED.registerFactory(ConvertExtensionToFunctionTypeFix)","This seems to be an accidental change, please revert
+",2016-04-28 08:30:42
+149,"@@ -3731,6 +3738,160 @@ else if (condition instanceof JetWhenConditionWithExpression) {
+         }
+     }
+ 
++    private StackValue generateSwitch(JetWhenExpression expression, Type subjectType, Type resultType, boolean isStatement) {
++        JetType subjectJetType = bindingContext.get(BindingContext.EXPRESSION_TYPE, expression.getSubjectExpression());
++        assert subjectJetType != null;
++
++        Map<Integer, Label> transitions = Maps.newTreeMap();
++
++        Label[] entryLabels = new Label[expression.getEntries().size()];
++        int entryLabelsCounter = 0;
++
++        Label elseLabel = new Label();
++        Label endLabel = new Label();
++        boolean hasElse = expression.getElseExpression() != null;
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            Label entryLabel = new Label();
++
++            for (JetWhenCondition condition : entry.getConditions()) {
++                assert condition instanceof JetWhenConditionWithExpression;
++
++                JetExpression conditionExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++                assert conditionExpression != null;
++
++                CompileTimeConstant constant = getCompileTimeConstant(conditionExpression, bindingContext);
++                assert doesConstantFitForSwitch(constant);
++
++                int value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).intValue() : ((Character)constant.getValue()).charValue();
++
++                if (!transitions.containsKey(value)) {
++                    transitions.put(value, entryLabel);
++                }
++            }
++
++            if (entry.isElse()) {
++                elseLabel = entryLabel;
++            }
++
++            entryLabels[entryLabelsCounter++] = entryLabel;
++        }
++
++        gen(expression.getSubjectExpression(), subjectType);
++        generateSwitchCall(
++                transitions,
++                //if there is no else-entry and it's statement then default --- endLabel
++                (hasElse || !isStatement) ? elseLabel : endLabel
++        );
++
++        //resolving entries' labels
++        int i = 0;
++        for (JetWhenEntry entry : expression.getEntries()) {
++            v.visitLabel(entryLabels[i++]);
++
++            FrameMap.Mark mark = myFrameMap.mark();
++            gen(entry.getExpression(), resultType);
++            mark.dropTo();
++
++            if (!entry.isElse()) {
++                v.goTo(endLabel);
++            }
++        }
++
++        //there is no else-entry but this is not statement, so we should return Unit
++        if (!hasElse && !isStatement) {
++            v.visitLabel(elseLabel);
++            // a result is expected
++            if (Boolean.TRUE.equals(bindingContext.get(BindingContext.EXHAUSTIVE_WHEN, expression))) {
++                // when() is supposed to be exhaustive
++                throwNewException(""kotlin/NoWhenBranchMatchedException"");
++            }
++            else {
++                // non-exhaustive when() with no else -> Unit must be expected
++                StackValue.putUnitInstance(v);
++            }
++        }","Please, get rid of code duplication.
+",2014-04-08 16:03:12
+150,"@@ -3731,6 +3738,160 @@ else if (condition instanceof JetWhenConditionWithExpression) {
+         }
+     }
+ 
++    private StackValue generateSwitch(JetWhenExpression expression, Type subjectType, Type resultType, boolean isStatement) {
++        JetType subjectJetType = bindingContext.get(BindingContext.EXPRESSION_TYPE, expression.getSubjectExpression());
++        assert subjectJetType != null;
++
++        Map<Integer, Label> transitions = Maps.newTreeMap();
++
++        Label[] entryLabels = new Label[expression.getEntries().size()];
++        int entryLabelsCounter = 0;
++
++        Label elseLabel = new Label();
++        Label endLabel = new Label();
++        boolean hasElse = expression.getElseExpression() != null;
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            Label entryLabel = new Label();
++
++            for (JetWhenCondition condition : entry.getConditions()) {
++                assert condition instanceof JetWhenConditionWithExpression;
++
++                JetExpression conditionExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++                assert conditionExpression != null;
++
++                CompileTimeConstant constant = getCompileTimeConstant(conditionExpression, bindingContext);
++                assert doesConstantFitForSwitch(constant);
++
++                int value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).intValue() : ((Character)constant.getValue()).charValue();
++
++                if (!transitions.containsKey(value)) {
++                    transitions.put(value, entryLabel);
++                }
++            }
++
++            if (entry.isElse()) {
++                elseLabel = entryLabel;
++            }
++
++            entryLabels[entryLabelsCounter++] = entryLabel;
++        }
++
++        gen(expression.getSubjectExpression(), subjectType);
++        generateSwitchCall(
++                transitions,
++                //if there is no else-entry and it's statement then default --- endLabel
++                (hasElse || !isStatement) ? elseLabel : endLabel
++        );
++
++        //resolving entries' labels
++        int i = 0;
++        for (JetWhenEntry entry : expression.getEntries()) {
++            v.visitLabel(entryLabels[i++]);
++
++            FrameMap.Mark mark = myFrameMap.mark();
++            gen(entry.getExpression(), resultType);
++            mark.dropTo();
++
++            if (!entry.isElse()) {
++                v.goTo(endLabel);
++            }
++        }
++
++        //there is no else-entry but this is not statement, so we should return Unit
++        if (!hasElse && !isStatement) {
++            v.visitLabel(elseLabel);
++            // a result is expected
++            if (Boolean.TRUE.equals(bindingContext.get(BindingContext.EXHAUSTIVE_WHEN, expression))) {
++                // when() is supposed to be exhaustive
++                throwNewException(""kotlin/NoWhenBranchMatchedException"");
++            }
++            else {
++                // non-exhaustive when() with no else -> Unit must be expected
++                StackValue.putUnitInstance(v);
++            }
++        }
++
++        markLineNumber(expression);
++        v.mark(endLabel);
++
++        return StackValue.onStack(resultType);
++    }
++
++    private void generateSwitchCall(Map<Integer, Label> transitions, Label defaultLabel) {","What does ""call"" mean here?
+",2014-04-08 16:04:14
+151,"@@ -3731,6 +3738,160 @@ else if (condition instanceof JetWhenConditionWithExpression) {
+         }
+     }
+ 
++    private StackValue generateSwitch(JetWhenExpression expression, Type subjectType, Type resultType, boolean isStatement) {
++        JetType subjectJetType = bindingContext.get(BindingContext.EXPRESSION_TYPE, expression.getSubjectExpression());
++        assert subjectJetType != null;
++
++        Map<Integer, Label> transitions = Maps.newTreeMap();
++
++        Label[] entryLabels = new Label[expression.getEntries().size()];
++        int entryLabelsCounter = 0;
++
++        Label elseLabel = new Label();
++        Label endLabel = new Label();
++        boolean hasElse = expression.getElseExpression() != null;
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            Label entryLabel = new Label();
++
++            for (JetWhenCondition condition : entry.getConditions()) {
++                assert condition instanceof JetWhenConditionWithExpression;
++
++                JetExpression conditionExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++                assert conditionExpression != null;
++
++                CompileTimeConstant constant = getCompileTimeConstant(conditionExpression, bindingContext);
++                assert doesConstantFitForSwitch(constant);
++
++                int value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).intValue() : ((Character)constant.getValue()).charValue();
++
++                if (!transitions.containsKey(value)) {
++                    transitions.put(value, entryLabel);
++                }
++            }
++
++            if (entry.isElse()) {
++                elseLabel = entryLabel;
++            }
++
++            entryLabels[entryLabelsCounter++] = entryLabel;
++        }
++
++        gen(expression.getSubjectExpression(), subjectType);
++        generateSwitchCall(
++                transitions,
++                //if there is no else-entry and it's statement then default --- endLabel
++                (hasElse || !isStatement) ? elseLabel : endLabel
++        );
++
++        //resolving entries' labels
++        int i = 0;
++        for (JetWhenEntry entry : expression.getEntries()) {
++            v.visitLabel(entryLabels[i++]);
++
++            FrameMap.Mark mark = myFrameMap.mark();
++            gen(entry.getExpression(), resultType);
++            mark.dropTo();
++
++            if (!entry.isElse()) {
++                v.goTo(endLabel);
++            }
++        }
++
++        //there is no else-entry but this is not statement, so we should return Unit
++        if (!hasElse && !isStatement) {
++            v.visitLabel(elseLabel);
++            // a result is expected
++            if (Boolean.TRUE.equals(bindingContext.get(BindingContext.EXHAUSTIVE_WHEN, expression))) {
++                // when() is supposed to be exhaustive
++                throwNewException(""kotlin/NoWhenBranchMatchedException"");
++            }
++            else {
++                // non-exhaustive when() with no else -> Unit must be expected
++                StackValue.putUnitInstance(v);
++            }
++        }
++
++        markLineNumber(expression);
++        v.mark(endLabel);
++
++        return StackValue.onStack(resultType);
++    }
++
++    private void generateSwitchCall(Map<Integer, Label> transitions, Label defaultLabel) {
++        int[] keys = new int[transitions.size()];
++        Label[] labels = new Label[transitions.size()];
++        int i = 0;
++
++        for (Map.Entry<Integer,Label> transition : transitions.entrySet()) {
++            keys[i] = transition.getKey();
++            labels[i] = transition.getValue();
++
++            i++;
++        }
++
++        int hi = keys[keys.length-1];
++        int lo = keys[0];
++        long emptyCells = ((long)hi - (long)lo + 1) - keys.length;
++
++        boolean useTableSwitch = keys.length > 0 &&
++                                 10L * emptyCells <= (long) keys.length; // less then 10% of empty cells
++
++        if (!useTableSwitch) {
++            v.lookupswitch(defaultLabel, keys, labels);
++            return;
++        }
++
++        Label[] sparseLabels = new Label[hi-lo + 1];
++        Arrays.fill(sparseLabels, defaultLabel);
++
++        for (i = 0; i < keys.length; i++) {
++            sparseLabels[keys[i] - lo] = labels[i];
++        }
++
++        v.tableswitch(lo, hi, defaultLabel, sparseLabels);
++    }
++
++    private boolean doesConstantFitForSwitch(CompileTimeConstant constant) {","IDEA says this method can be static. And I believe it ;)
+",2014-04-08 16:04:30
+152,"@@ -3731,6 +3738,160 @@ else if (condition instanceof JetWhenConditionWithExpression) {
+         }
+     }
+ 
++    private StackValue generateSwitch(JetWhenExpression expression, Type subjectType, Type resultType, boolean isStatement) {
++        JetType subjectJetType = bindingContext.get(BindingContext.EXPRESSION_TYPE, expression.getSubjectExpression());
++        assert subjectJetType != null;
++
++        Map<Integer, Label> transitions = Maps.newTreeMap();
++
++        Label[] entryLabels = new Label[expression.getEntries().size()];
++        int entryLabelsCounter = 0;
++
++        Label elseLabel = new Label();
++        Label endLabel = new Label();
++        boolean hasElse = expression.getElseExpression() != null;
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            Label entryLabel = new Label();
++
++            for (JetWhenCondition condition : entry.getConditions()) {
++                assert condition instanceof JetWhenConditionWithExpression;
++
++                JetExpression conditionExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++                assert conditionExpression != null;
++
++                CompileTimeConstant constant = getCompileTimeConstant(conditionExpression, bindingContext);
++                assert doesConstantFitForSwitch(constant);
++
++                int value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).intValue() : ((Character)constant.getValue()).charValue();
++
++                if (!transitions.containsKey(value)) {
++                    transitions.put(value, entryLabel);
++                }
++            }
++
++            if (entry.isElse()) {
++                elseLabel = entryLabel;
++            }
++
++            entryLabels[entryLabelsCounter++] = entryLabel;
++        }
++
++        gen(expression.getSubjectExpression(), subjectType);
++        generateSwitchCall(
++                transitions,
++                //if there is no else-entry and it's statement then default --- endLabel
++                (hasElse || !isStatement) ? elseLabel : endLabel
++        );
++
++        //resolving entries' labels
++        int i = 0;
++        for (JetWhenEntry entry : expression.getEntries()) {
++            v.visitLabel(entryLabels[i++]);
++
++            FrameMap.Mark mark = myFrameMap.mark();
++            gen(entry.getExpression(), resultType);
++            mark.dropTo();
++
++            if (!entry.isElse()) {
++                v.goTo(endLabel);
++            }
++        }
++
++        //there is no else-entry but this is not statement, so we should return Unit
++        if (!hasElse && !isStatement) {
++            v.visitLabel(elseLabel);
++            // a result is expected
++            if (Boolean.TRUE.equals(bindingContext.get(BindingContext.EXHAUSTIVE_WHEN, expression))) {
++                // when() is supposed to be exhaustive
++                throwNewException(""kotlin/NoWhenBranchMatchedException"");
++            }
++            else {
++                // non-exhaustive when() with no else -> Unit must be expected
++                StackValue.putUnitInstance(v);
++            }
++        }
++
++        markLineNumber(expression);
++        v.mark(endLabel);
++
++        return StackValue.onStack(resultType);
++    }
++
++    private void generateSwitchCall(Map<Integer, Label> transitions, Label defaultLabel) {
++        int[] keys = new int[transitions.size()];
++        Label[] labels = new Label[transitions.size()];
++        int i = 0;
++
++        for (Map.Entry<Integer,Label> transition : transitions.entrySet()) {
++            keys[i] = transition.getKey();
++            labels[i] = transition.getValue();
++
++            i++;
++        }
++
++        int hi = keys[keys.length-1];
++        int lo = keys[0];
++        long emptyCells = ((long)hi - (long)lo + 1) - keys.length;
++
++        boolean useTableSwitch = keys.length > 0 &&
++                                 10L * emptyCells <= (long) keys.length; // less then 10% of empty cells
++
++        if (!useTableSwitch) {
++            v.lookupswitch(defaultLabel, keys, labels);
++            return;
++        }
++
++        Label[] sparseLabels = new Label[hi-lo + 1];
++        Arrays.fill(sparseLabels, defaultLabel);
++
++        for (i = 0; i < keys.length; i++) {
++            sparseLabels[keys[i] - lo] = labels[i];
++        }
++
++        v.tableswitch(lo, hi, defaultLabel, sparseLabels);
++    }
++
++    private boolean doesConstantFitForSwitch(CompileTimeConstant constant) {
++        if (constant == null || !(constant instanceof IntegerValueConstant)) {","`constant == null` can be removed, because ""instanceof"" is false for null anyway
+",2014-04-08 16:04:38
+153,"@@ -3731,6 +3738,160 @@ else if (condition instanceof JetWhenConditionWithExpression) {
+         }
+     }
+ 
++    private StackValue generateSwitch(JetWhenExpression expression, Type subjectType, Type resultType, boolean isStatement) {
++        JetType subjectJetType = bindingContext.get(BindingContext.EXPRESSION_TYPE, expression.getSubjectExpression());
++        assert subjectJetType != null;
++
++        Map<Integer, Label> transitions = Maps.newTreeMap();
++
++        Label[] entryLabels = new Label[expression.getEntries().size()];
++        int entryLabelsCounter = 0;
++
++        Label elseLabel = new Label();
++        Label endLabel = new Label();
++        boolean hasElse = expression.getElseExpression() != null;
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            Label entryLabel = new Label();
++
++            for (JetWhenCondition condition : entry.getConditions()) {
++                assert condition instanceof JetWhenConditionWithExpression;
++
++                JetExpression conditionExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++                assert conditionExpression != null;
++
++                CompileTimeConstant constant = getCompileTimeConstant(conditionExpression, bindingContext);
++                assert doesConstantFitForSwitch(constant);
++
++                int value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).intValue() : ((Character)constant.getValue()).charValue();
++
++                if (!transitions.containsKey(value)) {
++                    transitions.put(value, entryLabel);
++                }
++            }
++
++            if (entry.isElse()) {
++                elseLabel = entryLabel;
++            }
++
++            entryLabels[entryLabelsCounter++] = entryLabel;
++        }
++
++        gen(expression.getSubjectExpression(), subjectType);
++        generateSwitchCall(
++                transitions,
++                //if there is no else-entry and it's statement then default --- endLabel
++                (hasElse || !isStatement) ? elseLabel : endLabel
++        );
++
++        //resolving entries' labels
++        int i = 0;
++        for (JetWhenEntry entry : expression.getEntries()) {
++            v.visitLabel(entryLabels[i++]);
++
++            FrameMap.Mark mark = myFrameMap.mark();
++            gen(entry.getExpression(), resultType);
++            mark.dropTo();
++
++            if (!entry.isElse()) {
++                v.goTo(endLabel);
++            }
++        }
++
++        //there is no else-entry but this is not statement, so we should return Unit
++        if (!hasElse && !isStatement) {
++            v.visitLabel(elseLabel);
++            // a result is expected
++            if (Boolean.TRUE.equals(bindingContext.get(BindingContext.EXHAUSTIVE_WHEN, expression))) {
++                // when() is supposed to be exhaustive
++                throwNewException(""kotlin/NoWhenBranchMatchedException"");
++            }
++            else {
++                // non-exhaustive when() with no else -> Unit must be expected
++                StackValue.putUnitInstance(v);
++            }
++        }
++
++        markLineNumber(expression);
++        v.mark(endLabel);
++
++        return StackValue.onStack(resultType);
++    }
++
++    private void generateSwitchCall(Map<Integer, Label> transitions, Label defaultLabel) {
++        int[] keys = new int[transitions.size()];
++        Label[] labels = new Label[transitions.size()];
++        int i = 0;
++
++        for (Map.Entry<Integer,Label> transition : transitions.entrySet()) {
++            keys[i] = transition.getKey();
++            labels[i] = transition.getValue();
++
++            i++;
++        }
++
++        int hi = keys[keys.length-1];
++        int lo = keys[0];
++        long emptyCells = ((long)hi - (long)lo + 1) - keys.length;
++
++        boolean useTableSwitch = keys.length > 0 &&
++                                 10L * emptyCells <= (long) keys.length; // less then 10% of empty cells
++
++        if (!useTableSwitch) {
++            v.lookupswitch(defaultLabel, keys, labels);
++            return;
++        }
++
++        Label[] sparseLabels = new Label[hi-lo + 1];
++        Arrays.fill(sparseLabels, defaultLabel);
++
++        for (i = 0; i < keys.length; i++) {
++            sparseLabels[keys[i] - lo] = labels[i];
++        }
++
++        v.tableswitch(lo, hi, defaultLabel, sparseLabels);
++    }
++
++    private boolean doesConstantFitForSwitch(CompileTimeConstant constant) {
++        if (constant == null || !(constant instanceof IntegerValueConstant)) {
++            return false;
++        }
++
++        long value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).longValue() : ((Character)constant.getValue()).charValue();
++        return value >= Integer.MIN_VALUE &&
++               value <= Integer.MAX_VALUE;","This check seems redundant, because we already checked that constant is not `long`
+",2014-04-08 16:04:46
+154,"@@ -3731,6 +3738,160 @@ else if (condition instanceof JetWhenConditionWithExpression) {
+         }
+     }
+ 
++    private StackValue generateSwitch(JetWhenExpression expression, Type subjectType, Type resultType, boolean isStatement) {
++        JetType subjectJetType = bindingContext.get(BindingContext.EXPRESSION_TYPE, expression.getSubjectExpression());
++        assert subjectJetType != null;
++
++        Map<Integer, Label> transitions = Maps.newTreeMap();
++
++        Label[] entryLabels = new Label[expression.getEntries().size()];
++        int entryLabelsCounter = 0;
++
++        Label elseLabel = new Label();
++        Label endLabel = new Label();
++        boolean hasElse = expression.getElseExpression() != null;
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            Label entryLabel = new Label();
++
++            for (JetWhenCondition condition : entry.getConditions()) {
++                assert condition instanceof JetWhenConditionWithExpression;
++
++                JetExpression conditionExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++                assert conditionExpression != null;
++
++                CompileTimeConstant constant = getCompileTimeConstant(conditionExpression, bindingContext);
++                assert doesConstantFitForSwitch(constant);
++
++                int value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).intValue() : ((Character)constant.getValue()).charValue();
++
++                if (!transitions.containsKey(value)) {
++                    transitions.put(value, entryLabel);
++                }
++            }
++
++            if (entry.isElse()) {
++                elseLabel = entryLabel;
++            }
++
++            entryLabels[entryLabelsCounter++] = entryLabel;
++        }
++
++        gen(expression.getSubjectExpression(), subjectType);
++        generateSwitchCall(
++                transitions,
++                //if there is no else-entry and it's statement then default --- endLabel
++                (hasElse || !isStatement) ? elseLabel : endLabel
++        );
++
++        //resolving entries' labels
++        int i = 0;
++        for (JetWhenEntry entry : expression.getEntries()) {
++            v.visitLabel(entryLabels[i++]);
++
++            FrameMap.Mark mark = myFrameMap.mark();
++            gen(entry.getExpression(), resultType);
++            mark.dropTo();
++
++            if (!entry.isElse()) {
++                v.goTo(endLabel);
++            }
++        }
++
++        //there is no else-entry but this is not statement, so we should return Unit
++        if (!hasElse && !isStatement) {
++            v.visitLabel(elseLabel);
++            // a result is expected
++            if (Boolean.TRUE.equals(bindingContext.get(BindingContext.EXHAUSTIVE_WHEN, expression))) {
++                // when() is supposed to be exhaustive
++                throwNewException(""kotlin/NoWhenBranchMatchedException"");
++            }
++            else {
++                // non-exhaustive when() with no else -> Unit must be expected
++                StackValue.putUnitInstance(v);
++            }
++        }
++
++        markLineNumber(expression);
++        v.mark(endLabel);
++
++        return StackValue.onStack(resultType);
++    }
++
++    private void generateSwitchCall(Map<Integer, Label> transitions, Label defaultLabel) {
++        int[] keys = new int[transitions.size()];
++        Label[] labels = new Label[transitions.size()];
++        int i = 0;
++
++        for (Map.Entry<Integer,Label> transition : transitions.entrySet()) {
++            keys[i] = transition.getKey();
++            labels[i] = transition.getValue();
++
++            i++;
++        }
++
++        int hi = keys[keys.length-1];
++        int lo = keys[0];
++        long emptyCells = ((long)hi - (long)lo + 1) - keys.length;
++
++        boolean useTableSwitch = keys.length > 0 &&
++                                 10L * emptyCells <= (long) keys.length; // less then 10% of empty cells
++
++        if (!useTableSwitch) {
++            v.lookupswitch(defaultLabel, keys, labels);
++            return;
++        }
++
++        Label[] sparseLabels = new Label[hi-lo + 1];
++        Arrays.fill(sparseLabels, defaultLabel);
++
++        for (i = 0; i < keys.length; i++) {
++            sparseLabels[keys[i] - lo] = labels[i];
++        }
++
++        v.tableswitch(lo, hi, defaultLabel, sparseLabels);
++    }
++
++    private boolean doesConstantFitForSwitch(CompileTimeConstant constant) {
++        if (constant == null || !(constant instanceof IntegerValueConstant)) {
++            return false;
++        }
++
++        long value = (constant.getValue() instanceof Number) ? ((Number)constant.getValue()).longValue() : ((Character)constant.getValue()).charValue();
++        return value >= Integer.MIN_VALUE &&
++               value <= Integer.MAX_VALUE;
++    }
++
++    private boolean canSwitchBeUsedIn(JetWhenExpression expression, Type subjectType) {
++        int typeSort = subjectType.getSort();
++
++        if (typeSort != Type.INT && typeSort != Type.CHAR && typeSort != Type.SHORT && typeSort != Type.BYTE) {
++            return false;
++        }
++
++        for (JetWhenEntry entry : expression.getEntries()) {
++            for (JetWhenCondition condition : entry.getConditions()) {
++                if (!(condition instanceof JetWhenConditionWithExpression)) {
++                    return false;
++                }
++
++                //ensure that expression is constant
++                JetExpression patternExpression = ((JetWhenConditionWithExpression) condition).getExpression();
++
++                if (patternExpression == null) {","Should be replaced with assert, because it can be null only for code with syntax errors.
+
+Common rule: if some method of PSI (`JetExpression`, `JetWhenCondition`, `JetWhatever`...) is annotated as `@Nullable @IfNotParsed`, it returns null only if code has syntax errors. Front-end should be tolerant to nulls here, while back-end can be assert it.
+",2014-04-08 16:07:20
+841,"@@ -375,6 +382,7 @@
+                 <zipfileset src=""${dependencies}/jline.jar""/>
+                 <zipfileset src=""${dependencies}/javaslang-2.0.6.jar""/>
+                 <zipfileset src=""${protobuf.jar}""/>
++                <zipfileset src=""${tools.jar}""/>",This string must be removed due to licensing problems,2017-05-03 13:13:59
+907,"@@ -38,17 +37,27 @@ class SwitchConverter(private val codeConverter: CodeConverter) {
+ 
+         val result = ArrayList<WhenEntry>()
+         var pendingSelectors = ArrayList<WhenEntrySelector>()
++        var defaultSelector: WhenEntrySelector? = null
++        var defaultEntry: WhenEntry? = null
+         for ((i, case) in cases.withIndex()) {
+             if (case.label == null) { // invalid switch - no case labels
+                 result.add(WhenEntry(listOf(ValueWhenEntrySelector(Expression.Empty).assignNoPrototype()), convertCaseStatementsToBody(cases, i)).assignNoPrototype())
+                 continue
+             }
+-            pendingSelectors.add(codeConverter.convertStatement(case.label) as WhenEntrySelector)
++            (codeConverter.convertStatement(case.label) as WhenEntrySelector).run {","I'd extracted selector to a variable, then smart-cast on line 54 will calculate properly.",2017-07-17 19:23:05
+327,"@@ -3833,6 +3833,9 @@ public Unit invoke(InstructionAdapter v) {
+                                 v.mark(nonnull);
+                             }
+                         }
++                        else if (value.type == Type.VOID_TYPE) {
++                            v.aconst(null);
++                        }
+                         else {
+                             v.dup();
+                             generateInstanceOfInstruction(rightType);","Similar code is present in `generateInstanceOf` which probably means `Unit is Int?` is also affected?
+",2015-03-04 20:27:42
+349,"@@ -386,6 +386,10 @@ else if (containingDeclaration instanceof PackageFragmentDescriptor) {
+     @Override
+     public void visitCallExpression(@NotNull JetCallExpression expression) {
+         super.visitCallExpression(expression);
++        checkSamCall(expression);
++    }
++
++    public void checkSamCall(@NotNull JetCallElement expression) {","public?
+",2015-03-26 17:11:14
+471,"@@ -39,54 +39,111 @@ import kotlin.concurrent.read
+ import kotlin.concurrent.write
+ 
+ 
++fun nowSeconds() = System.nanoTime() / 1000000000L
++
+ class CompileServiceImpl<Compiler: CLICompiler<*>>(
+         val registry: Registry,","How long this thing work? Does it shutdown itself?
+",2015-09-08 18:34:25
+606,"@@ -39,7 +39,10 @@ class SwitchConverter(private val codeConverter: CodeConverter) {
+                 continue
+             }
+             pendingSelectors.add(codeConverter.convertStatement(case.label) as WhenEntrySelector)
+-            if (case.statements.isNotEmpty()) {
++            if (!case.label.isDefaultCase && case.statements.isEmpty() && cases[i + 1]?.label!!.isDefaultCase){","You are accessing `cases[i+1]` without checking that `i+1` is a valid index in the `cases` collection.
+",2016-09-12 18:39:58
+895,"@@ -39,7 +39,9 @@ class ClassBody (
+         builder append "" "" append lBrace append ""\n""
+ 
+         if (!classKind.isEnum()) {
+-            builder.append(membersFiltered, ""\n"")
++            builder.append(membersFiltered.sortedWith(Comparator { o1, o2 ->",Please extract variable to deduplicate this code,2017-07-14 00:12:32
+314,"@@ -39,7 +41,7 @@ class GenericFunction(val signature: String) : Comparable<GenericFunction> {
+     var receiverAsterisk = false
+     val inlineFamilies = HashMap<Family, Boolean>()
+ 
+-    val buildFamilies = HashSet(defaultFamilies.toList())
++    val buildFamilies = HashSet(defaultFamilies.filter { it != RangesOfPrimitives && it != ProgressionsOfPrimitives }.toList())","Why is this filtering here? It seem to have no effect, anyway.
+",2015-02-10 20:05:32
+837,"@@ -394,6 +394,8 @@ public static DiagnosticRenderer getRendererForDiagnostic(@NotNull Diagnostic di
+         MAP.put(IS_ENUM_ENTRY, ""'is' over enum entry is not allowed, use comparison instead"");
+         MAP.put(ENUM_ENTRY_AS_TYPE, ""Use of enum entry names as types is not allowed, use enum type instead"");
+         MAP.put(USELESS_NULLABLE_CHECK, ""Non-null type is checked for instance of nullable type"");
++        MAP.put(USELESS_IS_CHECK, ""'is' check is always true"");
++        MAP.put(USELESS_IS_NOT_CHECK, ""'!is' check is always false"");","Then here:
+```
+MAP.put(USELESS_IS_CHECK, ""Check for instance is always ''{0}''"", TO_STRING);
+```",2017-05-02 18:34:47
+512,"@@ -3975,4 +3981,19 @@ private NonLocalReturnInfo(Type type, String name) {
+             labelName = name;
+         }
+     }
++
++    private StackValue getCompileTimeConstant(@NotNull KtExpression expression) {","Combine this method with original one by adding checkPure flag, and create overload with original signature to keep old invocations
+",2016-02-10 09:48:42
+967,"@@ -398,4 +401,13 @@ class CallCompleter(
+         val expressionType = trace.getType(expression.receiverExpression)
+         return expressionType != null && TypeUtils.isNullableType(expressionType)
+     }
++
++    private fun MutableResolvedCall<*>.updateResultDataFlowInfoUsingEffects(bindingTrace: BindingTrace) {
++        val moduleDescriptor = DescriptorUtils.getContainingModule(this.resultingDescriptor?.containingDeclaration ?: return)
++
++        val resultDFIfromES = effectSystem.getResultDataFlowInfo(this, bindingTrace, moduleDescriptor)
++        this.dataFlowInfoForArguments.updateResultInfo(resultDFIfromES)
++
++        effectSystem.recordDefiniteInvocations(this, bindingTrace, moduleDescriptor)","This line appears in the last but one commit, when the language features were added. It's quite unclear for me, why it appears in this commit.",2017-08-15 15:49:08
+914,"@@ -4,5 +4,110 @@ package kotlin.js
+  * Exposes the [Date API](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Date) to Kotlin.
+  */
+ public external class Date() {
+-    public fun getTime(): Double
++
++    constructor(timestamp: Long)
++    constructor(dateString: String)
++    constructor(year: Int,
++                month: Int = definedExternally,
++                date: Int = definedExternally,
++                hours: Int = definedExternally,
++                minutes: Int = definedExternally,
++                seconds: Int = definedExternally,
++                millis: Int = definedExternally)
++
++    public fun getDate(): Int = definedExternally
++    public fun getDay(): Int = definedExternally
++    public fun getFullYear(): Int = definedExternally
++    public fun getHours(): Int = definedExternally
++    public fun getMilliseconds(): Int = definedExternally
++    public fun getMinutes(): Int = definedExternally
++    public fun getMonth(): Int = definedExternally
++    public fun getSeconds(): Int = definedExternally
++    public fun getTime(): Long = definedExternally
++
++    public fun getTimezoneOffset(): Int = definedExternally
++    public fun getUTCDate(): Int = definedExternally
++    public fun getUTCDay(): Int = definedExternally
++    public fun getUTCFullYear(): Int = definedExternally
++    public fun getUTCHours(): Int = definedExternally
++    public fun getUTCMilliseconds(): Int = definedExternally
++    public fun getUTCMinutes(): Int = definedExternally
++    public fun getUTCMonth(): Int = definedExternally
++    public fun getUTCSeconds(): Int = definedExternally
++
++    @Deprecated(""Returns the year (usually 2-3 digits) in the specified date according to local time."",
++                ReplaceWith(""getFullYear""))
++    public fun getYear(): Int = definedExternally
++
++
++
++    public fun setDate(date: Int): Long = definedExternally
++    public fun setFullYear(year: Int,
++                           month: Int = definedExternally,
++                           day: Int = definedExternally): Long = definedExternally
++    public fun setHours(hours: Int,
++                        minutes: Int = definedExternally,
++                        seconds: Int = definedExternally,
++                        millis: Int = definedExternally): Long = definedExternally
++    public fun setMilliseconds(millis: Int): Long = definedExternally
++    public fun setMinutes(minutes: Int,
++                          seconds: Int = definedExternally,
++                          millis: Int = definedExternally): Long = definedExternally
++    public fun setMonth(month: Int,
++                        day: Int = definedExternally)
++    public fun setSeconds(seconds: Int,
++                          millis: Int = definedExternally): Long = definedExternally
++    public fun setTime(timeMillis: Long): Long = definedExternally
++    public fun setUTCDate(day: Int): Long = definedExternally
++    public fun setUTCFullYear(year: Int,
++                              month: Int,
++                              day: Int): Long = definedExternally
++    public fun setUTCHours(hours: Int,
++                           minutes: Int = definedExternally,
++                           seconds: Int = definedExternally,
++                           millis: Int): Long = definedExternally
++    public fun setUTCMilliseconds(millis: Int): Long = definedExternally
++    public fun setUTCMinutes(minutes: Int,
++                             seconds: Int = definedExternally,
++                             millis: Int = definedExternally): Long = definedExternally
++    public fun setUTCMonth(month: Int,
++                           day: Int = definedExternally): Long = definedExternally
++    public fun setUTCSeconds(seconds: Int,
++                             millis: Int = definedExternally): Long = definedExternally
++
++    @Deprecated(""Be aware that this feature may cease to work at any time."", ReplaceWith(""setFullYear""))
++    public fun setYear(year: Int): Long = definedExternally
++
++
++
++    public fun toDateString(): String = definedExternally
++    @Deprecated(""Be aware that this feature may cease to work at any time."", ReplaceWith(""toUTCString""))
++    public fun toGMTString(): String = definedExternally
++    public fun toISOString(): String = definedExternally
++    public fun toJSON(): String = definedExternally
++    public fun toLocaleDateString(locales: dynamic = definedExternally, /* String | Array<String> */
++                                  options: dynamic = definedExternally): String = definedExternally
++    public fun toLocaleString(locales: dynamic = definedExternally, /* String | Array<String> */
++                              options: dynamic = definedExternally): String = definedExternally
++    public fun toLocaleTimeString(locales: dynamic = definedExternally, /* String | Array<String> */
++                                  options: dynamic = definedExternally): String = definedExternally
++    public override fun toString(): String = definedExternally
++    public fun toTimeString(): String = definedExternally
++    public fun toUTCString(): String = definedExternally
++    public fun valueOf(): Long = definedExternally
++
++    companion object {
++        fun now(): Long = definedExternally",I think return type should not be `Long` here since it's not native JS type and it's emulated in Kotlin. Probably it should be `Number` or `Double`.,2017-07-24 19:20:45
+343,"@@ -4,66 +4,121 @@ import java.util.Timer
+ import java.util.TimerTask
+ import java.util.Date
+ 
++/**
++ * Schedules an [action] to be executed after the specified [delay] (expressed in milliseconds).
++ */
+ public fun Timer.schedule(delay: Long, action: TimerTask.() -> Unit): TimerTask {
+     val task = timerTask(action)
+     schedule(task, delay)
+     return task
+ }
+ 
++/**
++ * Schedules an [action] to be executed at the specified [time].
++ */
+ public fun Timer.schedule(time: Date, action: TimerTask.() -> Unit): TimerTask {
+     val task = timerTask(action)
+     schedule(task, time)
+     return task
+ }
+ 
++/**
++ * Schedules an [action] to be executed periodically, starting after the specified [delay] (expressed
++ * in milliseconds) and with the interval of [period] milliseconds between the end of the previous task
++ * and the start of the next one.
++ */
+ public fun Timer.schedule(delay: Long, period: Long, action: TimerTask.() -> Unit): TimerTask {
+     val task = timerTask(action)
+     schedule(task, delay, period)
+     return task
+ }
+ 
++/**
++ * Schedules an [action] to be executed periodically, starting at the specified [time] and with the
++ * interval of [period] milliseconds between the end of the previous task and the start of the next one.
++ */
+ public fun Timer.schedule(time: Date, period: Long, action: TimerTask.() -> Unit): TimerTask {
+     val task = timerTask(action)
+     schedule(task, time, period)
+     return task
+ }
+ 
++/**
++ * Schedules an [action] to be executed periodically, starting after the specified [delay] (expressed
++ * in milliseconds) and with the interval of [period] milliseconds between the start of the previous task
++ * and the start of the next one.
++ */
+ public fun Timer.scheduleAtFixedRate(delay: Long, period: Long, action: TimerTask.() -> Unit): TimerTask {
+     val task = timerTask(action)
+     scheduleAtFixedRate(task, delay, period)
+     return task
+ }
+ 
++/**
++ * Schedules an [action] to be executed periodically, starting at the specified [time] and with the
++ * interval of [period] milliseconds between the start of the previous task and the start of the next one.
++ */
+ public fun Timer.scheduleAtFixedRate(time: Date, period: Long, action: TimerTask.() -> Unit): TimerTask {
+     val task = timerTask(action)
+     scheduleAtFixedRate(task, time, period)
+     return task
+ }
+ 
++/**
++ * Creates a timer that executes the specified [action] periodically, starting after the specified [initialDelay]
++ * (expressed in milliseconds) and with the interval of [period] milliseconds between the end of the previous task
++ * and the start of the next one.
++ *
++ * @param name the name to use for the thread which is running the timer.
++ * @param daemon if true, the thread is started as a daemon thread (the VM will exit when only daemon threads are running)
++ */
+ public fun timer(name: String? = null, daemon: Boolean = false, initialDelay: Long = 0.toLong(), period: Long, action: TimerTask.() -> Unit): Timer {
+     val timer = if (name == null) Timer(daemon) else Timer(name, daemon)
+     timer.schedule(initialDelay, period, action)
+     return timer
+ }
+ 
++/**
++ * Creates a timer that executes the specified [action] periodically, starting at the specified [startAt] date
++ * and with the interval of [period] milliseconds between the end of the previous task and the start of the next one.
++ *
++ * @param name the name to use for the thread which is running the timer.
++ * @param daemon if true, the thread is started as a daemon thread (the VM will exit when only daemon threads are running)
++ */
+ public fun timer(name: String? = null, daemon: Boolean = false, startAt: Date, period: Long, action: TimerTask.() -> Unit): Timer {
+     val timer = if (name == null) Timer(daemon) else Timer(name, daemon)
+     timer.schedule(startAt, period, action)
+     return timer
+ }
+ 
++/**
++ * Creates a timer that executes the specified [action] periodically, starting after the specified [initialDelay]
++ * (expressed in milliseconds) and with the interval of [period] milliseconds between the start of the previous task
++ * and the start of the next one.
++ *
++ * @param name the name to use for the thread which is running the timer.
++ * @param daemon if true, the thread is started as a daemon thread (the VM will exit when only daemon threads are running)
++ */
+ public fun fixedRateTimer(name: String? = null, daemon: Boolean = false, initialDelay: Long = 0.toLong(), period: Long, action: TimerTask.() -> Unit): Timer {
+     val timer = if (name == null) Timer(daemon) else Timer(name, daemon)
+     timer.scheduleAtFixedRate(initialDelay, period, action)
+     return timer
+ }
+ 
++/**
++ * Creates a timer that executes the specified [action] periodically, starting at the specified [startAt] date
++ * and with the interval of [period] milliseconds between the start of the previous task and the start of the next one.
++ *
++ * @param name the name to use for the thread which is running the timer.
++ * @param daemon if true, the thread is started as a daemon thread (the VM will exit when only daemon threads are running)
++ */
+ public fun fixedRateTimer(name: String? = null, daemon: Boolean = false, startAt: Date, period: Long, action: TimerTask.() -> Unit): Timer {
+     val timer = if (name == null) Timer(daemon) else Timer(name, daemon)
+     timer.scheduleAtFixedRate(startAt, period, action)
+     return timer
+ }
+ 
++deprecated(""Use the built-in SAM conversion instead"")","Shouldn't we update usages in this file to invoke TimerTask constructor directly?
+",2015-03-12 15:00:37
+949,"@@ -4,7 +4,7 @@ object A {
+             ""text3""
+ 
+ 
+-    val TEXT2 = ""text1\n""
+-    + ""text2\n""
+-    + ""text3""
++    val TEXT2 = (""text1\n""","If I were you, I would reduce space from 2 to 1 line. I think one is enough to make this object readable.",2017-08-04 08:42:49
+942,"@@ -4,8 +4,8 @@ internal class C {
+     fun foo(): Int {
+         KotlinObject.property1 = 1
+         KotlinObject.property2 = 2
+-        return KotlinObject.foo() +
++        return (KotlinObject.foo() +",The parentheses are only required if the line break is before the operator. In this case they should not be added.,2017-08-03 10:41:40
+258,"@@ -40,10 +40,224 @@ import org.gradle.api.UnknownDomainObjectException
+ import org.gradle.api.initialization.dsl.ScriptHandler
+ import org.jetbrains.kotlin.gradle.plugin.android.AndroidGradleWrapper
+ import javax.inject.Inject
++import org.jetbrains.kotlin.gradle.tasks.Kotlin2JsCompile
++import org.gradle.api.tasks.Copy
++import org.gradle.api.file.SourceDirectorySet
++import kotlin.properties.Delegates
++import org.gradle.api.tasks.Delete
++import org.codehaus.groovy.runtime.MethodClosure
++import org.jetbrains.kotlin.gradle.tasks.RewritePathsInSourceMap
++import groovy.lang.Closure
+ 
+ val DEFAULT_ANNOTATIONS = ""org.jebrains.kotlin.gradle.defaultAnnotations""
+ 
+-open class KotlinPlugin [Inject] (val scriptHandler: ScriptHandler): Plugin<Project> {
++
++abstract class KotlinSourceSetProcessor<T : AbstractCompile>(val project: ProjectInternal,
++                                                             val javaBasePlugin: JavaBasePlugin,
++                                                             val sourceSet: SourceSet,
++                                                             val pluginName: String,
++                                                             val compileTaskNameSuffix: String,
++                                                             val taskDescription: String,
++                                                             val compilerClass: Class<T>) {
++    abstract protected fun doTargetSpecificProcessing()
++    val logger = Logging.getLogger(this.javaClass)
++
++    protected val sourceSetName: String = sourceSet.getName()
++    protected val sourceRootDir: String = ""src/${sourceSetName}/kotlin""
++    protected val absoluteSourceRootDir: String = project.getProjectDir().getPath() + ""/"" + sourceRootDir
++    protected val kotlinSourceSet: KotlinSourceSet? by Delegates.lazy { createKotlinSourceSet() }
++    protected val kotlinDirSet: SourceDirectorySet? by Delegates.lazy { createKotlinDirSet() }
++    protected val kotlinTask: T by Delegates.lazy { createKotlinCompileTask() }
++    protected val kotlinTaskName: String by Delegates.lazy { kotlinTask.getName() }
++
++    public fun run() {
++        if (kotlinSourceSet == null || kotlinDirSet == null) {
++            return
++        }
++        addSourcesToKotlinDirSet()
++        commonTaskConfiguration()
++        doTargetSpecificProcessing()
++    }
++
++    open protected fun createKotlinSourceSet(): KotlinSourceSet? =
++            if (sourceSet is HasConvention) {
++                logger.debug(""Creating KotlinSourceSet for source set ${sourceSet}"")
++                val kotlinSourceSet = KotlinSourceSetImpl(sourceSet.getName(), project.getFileResolver())
++                sourceSet.getConvention().getPlugins().put(pluginName, kotlinSourceSet)
++                kotlinSourceSet
++            } else {
++                null
++            }
++
++    open protected fun createKotlinDirSet(): SourceDirectorySet? {
++        val srcDir = project.file(sourceRootDir)
++        logger.debug(""Creating Kotlin SourceDirectorySet for source set ${kotlinSourceSet} with src dir ${srcDir}"")
++        val kotlinDirSet = kotlinSourceSet?.getKotlin()
++        kotlinDirSet?.srcDir(srcDir)
++        return kotlinDirSet
++    }
++
++    open protected fun addSourcesToKotlinDirSet() {
++        logger.debug(""Adding Kotlin SourceDirectorySet ${kotlinDirSet} to source set ${sourceSet}"")
++        sourceSet.getAllJava()?.source(kotlinDirSet)
++        sourceSet.getAllSource()?.source(kotlinDirSet)
++        sourceSet.getResources()?.getFilter()?.exclude(KSpec({ elem ->
++            kotlinDirSet!!.contains(elem.getFile())
++        }))
++    }
++
++    open protected fun createKotlinCompileTask(): T {
++        val name = sourceSet.getCompileTaskName(compileTaskNameSuffix)
++        logger.debug(""Creating kotlin compile task $name with class $compilerClass"")
++        return project.getTasks().create(name, compilerClass)
++    }
++
++    open protected fun commonTaskConfiguration() {
++        javaBasePlugin.configureForSourceSet(sourceSet, kotlinTask)
++        kotlinTask.setDescription(taskDescription)
++        kotlinTask.source(kotlinDirSet)
++    }
++}
++
++class Kotlin2JvmSourceSetProcessor(
++        project: ProjectInternal,
++        javaBasePlugin: JavaBasePlugin,
++        sourceSet: SourceSet,
++        val scriptHandler: ScriptHandler)
++: KotlinSourceSetProcessor<KotlinCompile>(
++        project, javaBasePlugin, sourceSet,
++        pluginName = ""kotlin"",
++        compileTaskNameSuffix = ""kotlin"",
++        taskDescription = ""Compiles the $sourceSet.kotlin."",
++        compilerClass = javaClass()) {
++
++    override fun doTargetSpecificProcessing() {
++        // store kotlin classes in separate directory. They will serve as class-path to java compiler
++        val kotlinOutputDir = File(project.getBuildDir(), ""kotlin-classes/${sourceSetName}"")
++        kotlinTask.kotlinDestinationDir = kotlinOutputDir
++
++        val javaTask = project.getTasks().findByName(sourceSet.getCompileJavaTaskName()) as AbstractCompile?
++
++        if (javaTask != null) {
++            javaTask.dependsOn(kotlinTaskName)
++            val javacClassPath = javaTask.getClasspath() + project.files(kotlinTask.kotlinDestinationDir);
++            javaTask.setClasspath(javacClassPath)
++        }
++    }
++}
++
++
++class Kotlin2JsSourceSetProcessor(
++        project: ProjectInternal,
++        javaBasePlugin: JavaBasePlugin,
++        sourceSet: SourceSet,
++        val scriptHandler: ScriptHandler
++) : KotlinSourceSetProcessor<Kotlin2JsCompile>(
++        project, javaBasePlugin, sourceSet,
++        pluginName = ""kotlin2js"",
++        taskDescription = ""Compiles the kotlin sources in $sourceSet to JavaScript."",
++        compileTaskNameSuffix = ""kotlin2Js"",
++        compilerClass = javaClass<Kotlin2JsCompile>()) {
++    val copyKotlinJsTaskName = sourceSet.getTaskName(""copy"", ""kotlinJs"")
++    val clean = project.getTasks().findByName(""clean"")
++    val compileJava = project.getTasks().findByName(sourceSet.getCompileJavaTaskName()) as AbstractCompile?","Why we need javaTask?
+",2014-11-12 11:52:19
+261,"@@ -40,10 +40,224 @@ import org.gradle.api.UnknownDomainObjectException
+ import org.gradle.api.initialization.dsl.ScriptHandler
+ import org.jetbrains.kotlin.gradle.plugin.android.AndroidGradleWrapper
+ import javax.inject.Inject
++import org.jetbrains.kotlin.gradle.tasks.Kotlin2JsCompile
++import org.gradle.api.tasks.Copy
++import org.gradle.api.file.SourceDirectorySet
++import kotlin.properties.Delegates
++import org.gradle.api.tasks.Delete
++import org.codehaus.groovy.runtime.MethodClosure
++import org.jetbrains.kotlin.gradle.tasks.RewritePathsInSourceMap
++import groovy.lang.Closure
+ 
+ val DEFAULT_ANNOTATIONS = ""org.jebrains.kotlin.gradle.defaultAnnotations""
+ 
+-open class KotlinPlugin [Inject] (val scriptHandler: ScriptHandler): Plugin<Project> {
++
++abstract class KotlinSourceSetProcessor<T : AbstractCompile>(val project: ProjectInternal,
++                                                             val javaBasePlugin: JavaBasePlugin,
++                                                             val sourceSet: SourceSet,
++                                                             val pluginName: String,
++                                                             val compileTaskNameSuffix: String,
++                                                             val taskDescription: String,
++                                                             val compilerClass: Class<T>) {
++    abstract protected fun doTargetSpecificProcessing()
++    val logger = Logging.getLogger(this.javaClass)
++
++    protected val sourceSetName: String = sourceSet.getName()
++    protected val sourceRootDir: String = ""src/${sourceSetName}/kotlin""
++    protected val absoluteSourceRootDir: String = project.getProjectDir().getPath() + ""/"" + sourceRootDir
++    protected val kotlinSourceSet: KotlinSourceSet? by Delegates.lazy { createKotlinSourceSet() }
++    protected val kotlinDirSet: SourceDirectorySet? by Delegates.lazy { createKotlinDirSet() }
++    protected val kotlinTask: T by Delegates.lazy { createKotlinCompileTask() }
++    protected val kotlinTaskName: String by Delegates.lazy { kotlinTask.getName() }
++
++    public fun run() {
++        if (kotlinSourceSet == null || kotlinDirSet == null) {
++            return
++        }
++        addSourcesToKotlinDirSet()
++        commonTaskConfiguration()
++        doTargetSpecificProcessing()
++    }
++
++    open protected fun createKotlinSourceSet(): KotlinSourceSet? =
++            if (sourceSet is HasConvention) {
++                logger.debug(""Creating KotlinSourceSet for source set ${sourceSet}"")
++                val kotlinSourceSet = KotlinSourceSetImpl(sourceSet.getName(), project.getFileResolver())
++                sourceSet.getConvention().getPlugins().put(pluginName, kotlinSourceSet)
++                kotlinSourceSet
++            } else {
++                null
++            }
++
++    open protected fun createKotlinDirSet(): SourceDirectorySet? {
++        val srcDir = project.file(sourceRootDir)
++        logger.debug(""Creating Kotlin SourceDirectorySet for source set ${kotlinSourceSet} with src dir ${srcDir}"")
++        val kotlinDirSet = kotlinSourceSet?.getKotlin()
++        kotlinDirSet?.srcDir(srcDir)
++        return kotlinDirSet
++    }
++
++    open protected fun addSourcesToKotlinDirSet() {
++        logger.debug(""Adding Kotlin SourceDirectorySet ${kotlinDirSet} to source set ${sourceSet}"")
++        sourceSet.getAllJava()?.source(kotlinDirSet)
++        sourceSet.getAllSource()?.source(kotlinDirSet)
++        sourceSet.getResources()?.getFilter()?.exclude(KSpec({ elem ->
++            kotlinDirSet!!.contains(elem.getFile())
++        }))
++    }
++
++    open protected fun createKotlinCompileTask(): T {
++        val name = sourceSet.getCompileTaskName(compileTaskNameSuffix)
++        logger.debug(""Creating kotlin compile task $name with class $compilerClass"")
++        return project.getTasks().create(name, compilerClass)
++    }
++
++    open protected fun commonTaskConfiguration() {
++        javaBasePlugin.configureForSourceSet(sourceSet, kotlinTask)
++        kotlinTask.setDescription(taskDescription)
++        kotlinTask.source(kotlinDirSet)
++    }
++}
++
++class Kotlin2JvmSourceSetProcessor(
++        project: ProjectInternal,
++        javaBasePlugin: JavaBasePlugin,
++        sourceSet: SourceSet,
++        val scriptHandler: ScriptHandler)
++: KotlinSourceSetProcessor<KotlinCompile>(
++        project, javaBasePlugin, sourceSet,
++        pluginName = ""kotlin"",
++        compileTaskNameSuffix = ""kotlin"",
++        taskDescription = ""Compiles the $sourceSet.kotlin."",
++        compilerClass = javaClass()) {
++
++    override fun doTargetSpecificProcessing() {
++        // store kotlin classes in separate directory. They will serve as class-path to java compiler
++        val kotlinOutputDir = File(project.getBuildDir(), ""kotlin-classes/${sourceSetName}"")
++        kotlinTask.kotlinDestinationDir = kotlinOutputDir
++
++        val javaTask = project.getTasks().findByName(sourceSet.getCompileJavaTaskName()) as AbstractCompile?
++
++        if (javaTask != null) {
++            javaTask.dependsOn(kotlinTaskName)
++            val javacClassPath = javaTask.getClasspath() + project.files(kotlinTask.kotlinDestinationDir);
++            javaTask.setClasspath(javacClassPath)
++        }
++    }
++}
++
++
++class Kotlin2JsSourceSetProcessor(
++        project: ProjectInternal,
++        javaBasePlugin: JavaBasePlugin,
++        sourceSet: SourceSet,
++        val scriptHandler: ScriptHandler
++) : KotlinSourceSetProcessor<Kotlin2JsCompile>(
++        project, javaBasePlugin, sourceSet,
++        pluginName = ""kotlin2js"",
++        taskDescription = ""Compiles the kotlin sources in $sourceSet to JavaScript."",
++        compileTaskNameSuffix = ""kotlin2Js"",
++        compilerClass = javaClass<Kotlin2JsCompile>()) {
++    val copyKotlinJsTaskName = sourceSet.getTaskName(""copy"", ""kotlinJs"")
++    val clean = project.getTasks().findByName(""clean"")
++    val compileJava = project.getTasks().findByName(sourceSet.getCompileJavaTaskName()) as AbstractCompile?
++
++    val defaultKotlinDestinationDir = File(project.getBuildDir(), ""kotlin2js/${sourceSetName}"")
++    private fun kotlinTaskDestinationDir(): File? = kotlinTask.kotlinDestinationDir
++    private fun kotlinJsDestinationDir(): File? = if (kotlinTask.outputFile() == null) {
++        null
++    } else {
++        File(kotlinTask.outputFile()).directory
++    }
++
++    private fun copyKotlinJsTaskOutput(): String? = if (kotlinJsDestinationDir() == null) {
++        null
++    } else {
++        val copyTask = project.getTasks().getByName(copyKotlinJsTaskName) as Copy
++        ""${copyTask.getDestinationDir()}/kotlin.js""
++    }
++
++    private fun kotlinSourcePathsForSourceMap() = sourceSet.getAllSource()
++            .map { it.path }
++            .filter { it.endsWith("".kt"") }
++            .map { it.replace(absoluteSourceRootDir, kotlinTask.sourceMapDestinationDir().getPath()) }
++
++    private fun shouldGenerateSourceMap() = kotlinTask.kotlinOptions.sourceMap
++
++    override fun doTargetSpecificProcessing() {
++        val version = project.getProperties()[""kotlin.gradle.plugin.version""] as String
++        val jsLibraryJar = GradleUtils(scriptHandler).resolveDependencies(""org.jetbrains.kotlin:kotlin-js-library:$version"").map { it.getAbsolutePath() }[0]
++
++        kotlinTask.kotlinOptions.libraryFiles = array(jsLibraryJar)
++        kotlinTask.kotlinDestinationDir = defaultKotlinDestinationDir
++
++        compileJava?.dependsOn(kotlinTaskName)
++        clean?.dependsOn(""clean"" + kotlinTaskName.capitalize())
++
++        createCopyKotlinJsTask(jsLibraryJar)
++        createCopyKotlinSourcesForSourceMapTask()","I think we should not be able to copy source files.
+",2014-11-13 17:05:10
+729,"@@ -40,9 +41,12 @@ class KotlinClassFinderTest : KotlinTestWithEnvironmentManagement() {
+         val environment = createEnvironment(tmpdir)
+         val project = environment.project
+ 
++        val classFinder = createClassFinder(project)","Here you also should create your own separate test, and leave the old one as is. ",2017-04-05 15:37:43
+494,"@@ -41,12 +41,21 @@
+ import org.jetbrains.kotlin.utils.KotlinPaths;
+ import org.jetbrains.kotlin.utils.PathUtil;
+ import org.junit.Assert;
++import org.junit.Before;
+ import org.junit.Test;
+ 
+ import java.util.Collections;
+ import java.util.List;
+ 
+ public class ScriptTest {
++
++    //@Before
++    //public void setUp() throws Exception {
++    //    // set to false if not present or set to true or unknown (empty considered true)
++    //    if (System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY)?.let { it.toBooleanLenient() ?: true } ?: true )
++    //    System.setProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY, ""false"")
++    //}
++","Why is this needed here?
+",2015-11-28 17:25:08
+7,"@@ -410,6 +410,9 @@","ignore this file
+",2012-05-24 14:21:07
+225,"@@ -4118,6 +4118,59 @@ public void testTypesAlreadyImplicit() throws Exception {
+         
+     }
+     
++    @TestMetadata(""idea/testData/intentions/invertIfCondition"")
++    public static class InvertIfCondition extends AbstractCodeTransformationTest {
++        public void testAllFilesPresentInInvertIfCondition() throws Exception {
++            JetTestUtils.assertAllTestsPresentByMetadata(this.getClass(), ""org.jetbrains.jet.generators.tests.TestsPackage"", new File(""idea/testData/intentions/invertIfCondition""), Pattern.compile(""^(.+)\\.kt$""), true);
++        }
++        
++        @TestMetadata(""binaryExpression.kt"")
++        public void testBinaryExpression() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/binaryExpression.kt"");
++        }
++        
++        @TestMetadata(""booleanLiteral.kt"")
++        public void testBooleanLiteral() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/booleanLiteral.kt"");
++        }
++        
++        @TestMetadata(""forLoopWithMultipleExpressions.kt"")
++        public void testForLoopWithMultipleExpressions() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/forLoopWithMultipleExpressions.kt"");
++        }
++        
++        @TestMetadata(""functionWithReturnExpression.kt"")
++        public void testFunctionWithReturnExpression() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/functionWithReturnExpression.kt"");
++        }
++        
++        @TestMetadata(""ifExpressionInsideForLoop.kt"")
++        public void testIfExpressionInsideForLoop() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/ifExpressionInsideForLoop.kt"");
++        }
++        
++        @TestMetadata(""ifExpressionWithReturn.kt"")
++        public void testIfExpressionWithReturn() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/ifExpressionWithReturn.kt"");
++        }
++        
++        @TestMetadata(""invertableOperator.kt"")
++        public void testInvertableOperator() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/invertableOperator.kt"");
++        }
++        
++        @TestMetadata(""negatedExpression.kt"")
++        public void testNegatedExpression() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/negatedExpression.kt"");
++        }
++        
++        @TestMetadata(""simple.kt"")
++        public void testSimple() throws Exception {
++            doTestInvertIfCondition(""idea/testData/intentions/invertIfCondition/simple.kt"");
++        }
++        
++    }
++    ","Please add some tests for the cases where ""if"" is used as an expression, like 
+`val t = if (a > 0) a else -a`
+Combinations of valued ifs with returns and other ""jumps"" is of particular interest, e.g. `return if ...` or `val t = if (a > 0) a else return 0`, etc.
+",2014-05-03 10:55:02
+88,"@@ -414,6 +414,14 @@ class CollectionTest {
+         expect(arrayList(2, 3, 1)) { list }
+     }
+ 
++    test fun sum() {
++        expect(0) {ArrayList<Int>().sum()}
++        expect(14) {arrayListOf(2,3,9).sum()}
++        expect(3.0) {arrayListOf(1.0,2.0).sum()}
++        expect(3000000000000) {arrayListOf<Long>(1000000000000,2000000000000).sum()}","Formatting: space after comma
+",2013-11-27 07:35:41
+675,"@@ -423,6 +423,13 @@ public header inline fun <K, M : MutableMap<in K, MutableList<Char>>> CharSequen
+ public header inline fun <K, V, M : MutableMap<in K, MutableList<V>>> CharSequence.groupByTo(destination: M, keySelector: (Char) -> K, valueTransform: (Char) -> V): M
+ 
+ /**
++ * Creates a [Grouping] source from a char sequence to be used later with one of group-and-fold operations
++ * using the specified [keySelector] function to extract a key from each character.
++ */
++@SinceKotlin(""1.1"")
++public header inline fun <K> CharSequence.groupingBy(crossinline keySelector: (Char) -> K): Grouping<Char, K>",why there is specialization here? the implementations look the same,2016-12-29 12:55:04
+603,"@@ -424,6 +425,24 @@ class Converter private constructor(
+         }
+     }
+ 
++
++    private fun specialAnnotationPropertyCases(field: PsiField): Annotations {
++        val javaSerializableInterface = PsiType.getTypeByName(""java.io.Serializable"", project, GlobalSearchScope.allScope(project)).resolve()","It's a minor issue, but the correct way is to use `field.getResolveScope()` instead of `allScope` here. Otherwise you may get incorrect results if the project uses multiple JDKs in different modules.
+",2016-09-12 08:56:16
+688,"@@ -428,4 +428,37 @@ class KotlinGradleIT: BaseGradleIT() {
+             assertSuccessful()
+         }
+     }
++
++    @Test
++    fun testGradleJavaIcWorking() {
++        val project = Project(""kotlinJavaProject"", ""2.14.1"")","What about newer Gradle versions?
+Btw, it would be interesting to test if Java compile avoidance works in this case with the Gradle 3.4 (in other words that Java is not compiled if Kotlin public API is not changed). ",2017-03-14 10:01:02
+278,"@@ -43,6 +83,15 @@ public trait MutableListIterator<T> : ListIterator<T>, MutableIterator<T> {
+ 
+     // Modification Operations
+     override fun remove(): Unit
++
++    /**
++     * Replaces the last element returned by [next] or [previous] with the specified element [e].
++     */
+     public fun set(e: T): Unit
++
++    /**
++     * Adds the specified element [e] into the underlying collection immediately before the element that would be
++     * returned by [next].","Will it affect what is returned next? Unclear from the text. What if previous was called?
+",2015-02-09 15:36:05
+838,"@@ -439,6 +443,13 @@ class PatternMatchingTypingVisitor internal constructor(facade: ExpressionTyping
+             context.trace.report(Errors.USELESS_NULLABLE_CHECK.on(element as KtNullableType))
+         }
+         checkTypeCompatibility(context, targetType, subjectType, typeReferenceAfterIs)
++        if (!subjectType.containsError() && !targetType.containsError() && subjectType.isSubtypeOf(targetType)) {","Note that this isn't correct for platform types (see https://kotlinlang.org/docs/reference/java-interop.html#null-safety-and-platform-types)
+
+Currently there will be warning for case like this:
+```
+// Java
+class A {
+  static A create() { return null; }
+}
+--
+// Kotlin
+fun test() {
+  A.create() is A // false warning 
+}
+```",2017-05-02 18:40:04
+959,"@@ -44,7 +44,7 @@ object MakeVisibleFactory  : KotlinIntentionActionsFactory() {
+ 
+         val module = DescriptorUtils.getContainingModule(descriptor)
+         val targetVisibilities = when (descriptor.visibility) {
+-            PRIVATE, INVISIBLE_FAKE -> if (module != usageModule) listOf(PUBLIC) else listOf(PUBLIC, INTERNAL)
++            PRIVATE, INVISIBLE_FAKE -> if (module != usageModule) listOf(PUBLIC) else listOf(PUBLIC, INTERNAL, PROTECTED)","It's not so easy, because `protected` should not be offered if member is referenced not from a subclass. Please add necessary checks here and such a test.",2017-08-14 10:29:34
+647,"@@ -45,15 +46,7 @@ class JoinBlockIntoSingleStatementHandler : JoinRawLinesHandlerDelegate {
+             // if outer if has else-branch and inner does not have it, do not remove braces otherwise else-branch will belong to different if!","I can't unify the check because while the intention is simply not available, the join handler still has to go into this branch.
+",2016-10-21 17:36:22
+492,"@@ -45,6 +47,13 @@ public abstract class AbstractReplInterpreterTest : UsefulTestCase() {
+ 
+     private data class OneLine(val code: String, val expected: String)
+ 
++    override fun setUp() {
++        super.setUp()
++        // set to false if not present or set to true or unknown (empty considered true)
++        if (System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY)?.let { it.toBooleanLenient() ?: true } ?: true )","This could be written as
+
+```
+if (KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY.systemPropertyAsBooleanOrTrueOtherwise(negate = false)) {
+```
+",2015-11-27 18:22:30
+695,"@@ -45,6 +49,37 @@ import org.jetbrains.kotlin.resolve.lazy.KotlinCodeAnalyzer
+ import org.jetbrains.kotlin.resolve.lazy.ResolveSession
+ import org.jetbrains.kotlin.resolve.lazy.declarations.DeclarationProviderFactory
+ 
++private fun StorageComponentContainer.configureJavaTopDownAnalysisWithJavac(
++        moduleContentScope: GlobalSearchScope,
++        project: Project,
++        lookupTracker: LookupTracker",I think it's better to remove this function and add boolean flag `useJavac` to the next one instead. The code is mostly the same,2017-04-05 12:23:40
+550,"@@ -454,3 +454,17 @@ fun checkReservedPrefixWord(sink: DiagnosticSink, element: PsiElement, word: Str
+     }
+ }
+ 
++fun KtNameReferenceExpression.getPrimaryConstructorParameterWithSameName(): KtParameter? {","I think this is far too specific to live in a general PSI utlilities class; I'd move it into the quickfix file.
+",2016-04-28 08:57:16
+551,"@@ -454,3 +454,17 @@ fun checkReservedPrefixWord(sink: DiagnosticSink, element: PsiElement, word: Str
+     }
+ }
+ 
++fun KtNameReferenceExpression.getPrimaryConstructorParameterWithSameName(): KtParameter? {
++    return getPrimaryConstructorParameterWithName(getReferencedName())
++}
++
++private fun KtElement.getPrimaryConstructorParameterWithName(name: String): KtParameter? {","The name of this function doesn't describe what it does. A more descriptive name would be ""findContainingClassConstructorParameterWithName"" (which is long enough to hint that it may be better to split the logic: a function to generate a sequence of outer classes for a class and a single-line call to find the parameter of the class by name).
+",2016-04-28 09:00:23
+263,"@@ -46,15 +84,91 @@ public val File.extension: String
+     }
+ 
+ /**
++ * Replaces all separators in the string used to separate directories with system ones and returns the resulting string.
++ */
++public fun String.separatorsToSystem(): String {
++    val otherSep = if (File.separator == ""/"") ""\\"" else ""/""
++    return replace(otherSep, File.separator)
++}
++
++/**
++ * Replaces all path separators in the string with system ones and returns the resulting string.
++ */
++public fun String.pathSeparatorsToSystem(): String {
++    val otherSep = if (File.pathSeparator == "":"") "";"" else "":""
++    return replace(otherSep, File.pathSeparator)
++}
++
++/**
++ * Replaces path and directories separators with corresponding system ones and returns the resulting string.
++ */
++public fun String.allSeparatorsToSystem(): String {
++    return separatorsToSystem().pathSeparatorsToSystem()
++}
++
++/**
++ * Returns a pathname of this file with all path separators replaced with File.pathSeparator
++ */
++public fun File.separatorsToSystem(): String {
++    return toString().separatorsToSystem()
++}
++
++/**
++ * Returns file's name without an extension.
++ */
++public val File.nameWithoutExtension: String
++    get() = name.substringBeforeLast(""."")
++
++/**
+  * Returns true if the given file is in the same directory or a descendant directory
+  */
+ public fun File.isDescendant(file: File): Boolean {
+     return file.directory.canonicalPath.startsWith(directory.canonicalPath)
+ }
+-
+ /**
+- * Returns the relative path of the given descendant of this file if it is a descendant
++ * Returns path of this file relatively to the given directory.
++ * Note that the base file is treated as a directory.
++ * If this file matches the base directory, then ""."" will be returned.
+  */
++public fun File.relativeTo(base: File): String {","Shouldn't it return File instead?
+",2014-11-26 14:52:46
+262,"@@ -46,15 +84,91 @@ public val File.extension: String
+     }
+ 
+ /**
++ * Replaces all separators in the string used to separate directories with system ones and returns the resulting string.
++ */
++public fun String.separatorsToSystem(): String {
++    val otherSep = if (File.separator == ""/"") ""\\"" else ""/""
++    return replace(otherSep, File.separator)
++}
++
++/**
++ * Replaces all path separators in the string with system ones and returns the resulting string.
++ */
++public fun String.pathSeparatorsToSystem(): String {
++    val otherSep = if (File.pathSeparator == "":"") "";"" else "":""
++    return replace(otherSep, File.pathSeparator)
++}
++
++/**
++ * Replaces path and directories separators with corresponding system ones and returns the resulting string.
++ */
++public fun String.allSeparatorsToSystem(): String {
++    return separatorsToSystem().pathSeparatorsToSystem()
++}
++
++/**
++ * Returns a pathname of this file with all path separators replaced with File.pathSeparator
++ */
++public fun File.separatorsToSystem(): String {
++    return toString().separatorsToSystem()
++}
++
++/**
++ * Returns file's name without an extension.
++ */
++public val File.nameWithoutExtension: String
++    get() = name.substringBeforeLast(""."")
++
++/**
+  * Returns true if the given file is in the same directory or a descendant directory
+  */
+ public fun File.isDescendant(file: File): Boolean {
+     return file.directory.canonicalPath.startsWith(directory.canonicalPath)
+ }
+-
+ /**
+- * Returns the relative path of the given descendant of this file if it is a descendant
++ * Returns path of this file relatively to the given directory.
++ * Note that the base file is treated as a directory.
++ * If this file matches the base directory, then ""."" will be returned.
+  */
++public fun File.relativeTo(base: File): String {
++    val thisCanonical = canonicalPath
++    val baseCanonical = base.canonicalPath
++    if (thisCanonical.equals(baseCanonical)) {
++        return "".""
++    }
++
++    fun String.longestCommonPrefixLen(o: String): Int {
++        var i = 0
++        val len = length
++        val oLen = o.length
++        while (i < len && i < oLen && this[i] == o[i]) {
++            i++
++        }
++        return i
++    }
++
++    val commonPrefLen = thisCanonical.longestCommonPrefixLen(baseCanonical)
++    val thisSuffix = thisCanonical.substring(commonPrefLen + if (commonPrefLen == baseCanonical.length) 1 else 0)
++    val baseSuffix = baseCanonical.substring(commonPrefLen + if (commonPrefLen == thisCanonical.length) 1 else 0)
++    val separator = File.separator.charAt(0)
++    val ups = if (baseSuffix.isEmpty()) 0 else baseSuffix.count { it == separator } + 1
++    val result = StringBuilder()
++    for (i in 1 .. ups) {
++        if (i != 1) {
++            result.append(separator)
++        }
++        result.append("".."")
++    }
++    if (commonPrefLen != thisCanonical.length) {
++        if (result.length() != 0) {
++            result.append(separator)
++        }
++        result.append(thisSuffix)
++    }
++    return result.toString()
++}
++
++deprecated(""Use relativeTo() functin instead"")","typo: functin 
+",2014-11-26 14:52:24
+653,"@@ -46,7 +45,7 @@ internal fun MethodNode.getParametersInfo(containingClass: ClassNode): List<Para
+     for (index in startParameterIndex..parameterTypes.lastIndex) {
+         val type = parameterTypes[index]
+         var name = parameters.getOrNull(index - startParameterIndex)?.name
+-                   ?: localVariables.getOrNull(index + (if (isStatic) 0 else 1))?.name
++                   ?: localVariables.getOrNull(index)?.name
+                    ?: ""p${index - startParameterIndex}""","@yanex Removing this offset fixes https://youtrack.jetbrains.com/issue/KT-15024, but I'm not sure exactly what the offset was for in the first place. Could you let me know what it's for and I can update this PR if needed. I have included a static method in the test and it still works fine. ",2016-11-29 09:50:18
+13,"@@ -46,7 +47,17 @@ public String getFamilyName() {
+ 
+     @Override
+     public boolean isAvailable(@NotNull Project project, Editor editor, PsiFile file) {
+-        return file instanceof JetFile && getExclExclElement(editor, file) != null;
++        if (file instanceof JetFile) {
++            PsiElement exclExcl = getExclExclElement(editor, file);
++            if (exclExcl != null) {
++                PsiElement element = PsiTreeUtil.nextLeaf(exclExcl);
++                if (element instanceof LeafPsiElement && ((LeafPsiElement) element).getElementType() != JetTokens.DOT) {","Unfortunately I didn't understand how to easily verify that we are inside the JetDotQualified element, so, I think that the check for the next leaf is not bad too.
+",2012-06-27 12:31:48
+14,"@@ -46,7 +48,18 @@ public static void addDelegatedMembers(@NotNull BindingTrace trace, @NotNull Jet
+                             type.getMemberScope().getAllDescriptors(),
+                             Predicates.instanceOf(CallableMemberDescriptor.class));
+                     Collection<CallableMemberDescriptor> descriptors = generateDelegatedMembers(classDescriptor, callableDescriptors);
++                    outer:
+                     for (CallableMemberDescriptor descriptor : descriptors) {
++                        for (CallableMemberDescriptor existingDescriptor : classDescriptor.getAllCallableMembers()) {","Seems like you haven't updated from our trunk for a while. There is a conflict on this change. I'll resolve it manually, but in the future it would be a good idea to update frequently.
+",2012-09-06 15:17:16
+922,"@@ -47,18 +66,23 @@ interface DependenciesResolver : @Suppress(""DEPRECATION"") ScriptDependenciesReso
+     }
+ }
+ 
++// is File a could type to use here?
++// No way to get script name if file is not present, should add another property (val fileName: String)
+ interface ScriptContents {
+     val file: File?
+     val annotations: Iterable<Annotation>",Maybe use `Collection` here?,2017-07-25 11:17:04
+923,"@@ -47,18 +66,23 @@ interface DependenciesResolver : @Suppress(""DEPRECATION"") ScriptDependenciesReso
+     }
+ }
+ 
++// is File a could type to use here?
++// No way to get script name if file is not present, should add another property (val fileName: String)
+ interface ScriptContents {
+     val file: File?
+     val annotations: Iterable<Annotation>
+     val text: CharSequence?",Why not `String?`?,2017-07-25 11:22:57
+921,"@@ -47,18 +66,23 @@ interface DependenciesResolver : @Suppress(""DEPRECATION"") ScriptDependenciesReso
+     }
+ }
+ 
++// is File a could type to use here?
++// No way to get script name if file is not present, should add another property (val fileName: String)
+ interface ScriptContents {
+     val file: File?
+     val annotations: Iterable<Annotation>
+     val text: CharSequence?
+ 
++    // nothing to discuss, for compatibility with previous version
+     @Deprecated(""Use DependenciesResolver interface"")
+     data class Position(val line: Int, val col: Int)
+ }
+ 
++// ScriptReport -> ScriptDiagnostic
+ data class ScriptReport(val message: String, val severity: Severity = ScriptReport.Severity.ERROR, val position: Position? = null) {
+     data class Position(val startLine: Int, val startColumn: Int, val endLine: Int? = null, val endColumn: Int? = null)
+     enum class Severity { ERROR, WARNING, INFO, DEBUG }
+ }
+ 
+-fun ScriptDependencies.asSuccess(): ResolveResult.Success = ResolveResult.Success(this)
+\ No newline at end of file
++// should we expose this helper?
++fun ScriptDependencies.asSuccess(): ResolutionResult.Success = ResolutionResult.Success(this)","I think, we should not",2017-07-25 11:14:51
+974,"@@ -47,6 +48,9 @@ public void updateInfo(@NotNull ValueArgument valueArgument, @NotNull DataFlowIn
+             throw new IllegalStateException();
+         }
+ 
++        @Override
++        public void updateResultInfo(@NotNull DataFlowInfo dataFlowInfo) { }",Should we throw here `IllegalStateException`?,2017-08-15 16:10:01
+138,"@@ -47,7 +47,7 @@ public class AddBracesIntention : JetSelfTargetingIntention<JetExpressionImpl>(""
+         val jetBlockElement = element.findBlockInExpression(expressionKind)","[this is a dummy comment, please ignore it]
+",2014-03-15 18:44:12
+769,"@@ -48,7 +48,7 @@ class JCClass<out T : JCTree.JCClassDecl>(tree: T,
+         get() = tree.modifiers.isAbstract
+ 
+     override val isStatic
+-        get() = outerClass?.isInterface ?: tree.modifiers.isStatic
++        get() = if (outerClass?.isInterface ?: false) true else tree.modifiers.isStatic","It's better to write here
+
+```
+(outerClass?.isInterface ?: false) || tree.modifiers.isStatic
+```",2017-04-19 16:00:50
+626,"@@ -48,7 +48,8 @@ class ReplaceContainsIntention : SelfTargetingRangeIntention<KtDotQualifiedExpre
+         if (!element.isReceiverExpressionWithValue()) return null
+ 
+         val functionDescriptor = getFunctionDescriptor(element) ?: return null
+-        if (!functionDescriptor.isOperator || !OperatorChecks.check(functionDescriptor).isSuccess) return null
++
++        if (!functionDescriptor.isOperator) return null","This will break the use of the intention with Java methods, which don't use an explicit `operator` modifier but still can be used as operators. The correct fix is to replace || with && in the original check.
+",2016-09-30 13:48:52
+241,"@@ -48,8 +56,11 @@ else if (argument instanceof VarargValueArgument) {
+                 generateOther(i, argument);
+             }
+         }
+-
+-        return mask;
++        masks.add(mask);
++        if (!maskIsNeeded) {
++            masks = null;","Not sure why you're encoding no masks with `null` when an empty list would work just fine. Might also be a good idea to annotate the return type of the method with `@NotNull`
+",2014-08-20 07:20:13
+652,"@@ -49,7 +49,18 @@ public inline fun File.printWriter(charset: Charset = Charsets.UTF_8): PrintWrit
+  *
+  * @return the entire content of this file as a byte array.
+  */
+-public fun File.readBytes(): ByteArray = FileInputStream(this).use { it.readBytes(length().toInt()) }
++public fun File.readBytes(): ByteArray = FileInputStream(this).use { input ->",Changed exception type to OutOfMemoryError,2016-11-22 20:38:41
+248,"@@ -5,20 +5,141 @@ import java.nio.charset.*
+ import java.util.*
+ 
+ /**
+- * Recursively process this file and all children with the given block
++ * Recursively process this file and all children with the given block.
++ * Note that if this file doesn't exist, then the block will be executed on it anyway.
+  */
+ public fun File.recurse(block: (File) -> Unit): Unit {
+     block(this)
+-    val children = listFiles()
+-    if (children != null) {
+-        for (child in children) {
+-            child.recurse(block)
++    listFiles()?.forEach { it.recurse(block) }
++}
++
++/**
++ * Stream allowing you to get all files that have the specified file as an ancestor in the depth-first order,
++ * including this file itself.
++ *
++ * If you specify a nonexistent file as a constructor parameter, IllegalArgumentException will be thrown.
++ */
++public class TraverseStream(private val file: File) : Stream<File> {
++    {
++        if (!file.exists()) {
++            throw IllegalArgumentException(""This file doesn't exist: $file"")
++        }
++    }
++
++    override fun iterator(): Iterator<File> = object : Iterator<File> {
++        inner class Cursor(val files: Array<File>, var pos: Int) {
++            val curFile: File
++                get() = files[pos]
++        }
++
++        val cursors = arrayListOf(Cursor(array(file), 0))
++        var childrenVisited = false
++
++        fun prepareCursor() {
++            if (cursors.isEmpty()) {
++                return
++            }
++            var cursor = cursors.last!!","Do not use first/last properties, they will be removed. Use first()/last() methods.
+",2014-11-06 11:47:00
+752,"@@ -5,6 +5,12 @@
+     <!-- Set to false to disable proguard run on kotlin-compiler.jar. Speeds up the build -->
+     <property name=""shrink"" value=""true""/>
+ 
++    <!-- Set to false to disable compiler's javadoc generation. Speeds up the build -->
++    <property name=""generate.javadoc"" value=""false""/>
++
++    <!-- Set to false to prevent jarjar and metadata stripping on kotlin-reflect.jar and reflection sources. Use to debug reflection -->
++    <property name=""obfuscate.reflect"" value=""true""/>
++",I think this should be dropped,2017-04-11 09:55:56
+556,"@@ -5,6 +5,12 @@ import org.junit.Test as test
+ 
+ class StringBuilderTest {
+ 
++    @test fun stringBuildWithInitialCapacity() {
++        val s = buildString(123) {
++            assertEquals(123, capacity())","This test won't compile in JS because there is no `StringBuilder.capacity` there.
+To make this test JVM-only, move it to `StringBuilderJVMTest.kt`
+",2016-05-17 17:42:06
+317,"@@ -5,8 +5,8 @@ import java.util.concurrent.locks.ReentrantReadWriteLock
+ import java.util.concurrent.CountDownLatch
+ 
+ /**
+- * Executes given calculation under lock
+- * Returns result of the calculation
++ * Executes the given calculation under this lock.","calculation -> action
+",2015-02-11 08:34:56
+438,"@@ -50,6 +52,8 @@ public String render(@NotNull ConflictingJvmDeclarationsData data) {
+         MAP.put(ErrorsJvm.OVERLOADS_WITHOUT_DEFAULT_ARGUMENTS, ""''jvmOverloads'' annotation has no effect for methods without default arguments"");
+         MAP.put(ErrorsJvm.OVERLOADS_ABSTRACT, ""''jvmOverloads'' annotation cannot be used on abstract methods"");
+         MAP.put(ErrorsJvm.OVERLOADS_PRIVATE, ""''jvmOverloads'' annotation has no effect on private and local declarations"");
++        MAP.put(ErrorsJvm.INAPPLICABLE_JVM_NAME, ""''jvmName ''annotation is not applicable to this declaration"");","Mistyped whitespace
+",2015-08-25 12:51:43
+96,"@@ -51,7 +51,7 @@
+   <component name=""ProjectResources"">
+     <default-html-doctype>http://www.w3.org/1999/xhtml</default-html-doctype>
+   </component>
+-  <component name=""ProjectRootManager"" version=""2"" languageLevel=""JDK_1_6"" assert-keyword=""true"" jdk-15=""true"" project-jdk-name=""1.6"" project-jdk-type=""JavaSDK"">
++  <component name=""ProjectRootManager"" version=""2"" languageLevel=""JDK_1_6"" assert-keyword=""true"" jdk-15=""true"" project-jdk-name=""1.7"" project-jdk-type=""JavaSDK"">","This change is harmful, as well.
+",2014-01-27 21:24:06
+941,"@@ -513,6 +513,16 @@ public static boolean areParenthesesNecessary(
+             return false;
+         }
+ 
++        if (innerExpression instanceof KtBinaryExpression) {
++            PsiElement expr = innerExpression.getFirstChild();
++            while (expr != null) {
++                if (expr instanceof PsiWhiteSpace && (expr.textContains('\n') || expr.textContains('\r'))) {","IntelliJ always normalizes text of files to use \n line breaks, the \r will never be there. Please remove it from the check.",2017-08-03 10:34:35
+645,"@@ -52,16 +52,16 @@ object MoveDeclarationsOutHelper {
+             val scope = LocalSearchScope(container)
+             val lastStatementOffset = statements[statements.size - 1].textRange.endOffset
+ 
+-            for (statement in statements) {
++            statements.forEachIndexed { i, statement ->
+                 if (needToDeclareOut(statement, lastStatementOffset, scope)) {
+                     if (statement is KtProperty && statement.initializer != null) {
+-                        var declaration = createVariableDeclaration(statement, generateDefaultInitializers)
++                        val isLastStatement = i == statements.size - 1
++                        var declaration = createVariableAssignment(statement, generateDefaultInitializers, isLastStatement)","I don't think this code is structured well enough. You have three functions that do three sets of entirely different things based on a value of a boolean parameter. I think it's clearer to pull the check out to the top level and to avoid introducing the functions altogether.
+",2016-10-18 18:58:03
+300,"@@ -52,37 +55,65 @@ public fun <K, V> linkedMapOf(vararg values: Pair<K, V>): LinkedHashMap<K, V> {
+     return answer
+ }
+ 
+-/** Returns the [[Map]] if its not null otherwise it returns the empty [[Map]] */
++/**
++ * Returns the [Map] if its not null, or the empty [Map] otherwise.
++ */
+ public fun <K,V> Map<K,V>?.orEmpty() : Map<K,V>
+        = if (this != null) this else emptyMap()
+ 
++/**
++ * Checks if the map contains the given key. This method allows to use the `x in map` syntax for checking
++ * whether an object is contained in the map.
++ */
+ public fun <K,V> Map<K,V>.contains(key : K) : Boolean = containsKey(key)
+ 
+-/** Returns the key of the entry */
++/**
++ * Allows to access the key of a map entry as a property. Equivalent to `getKey()`.
++ */
+ public val <K, V> Map.Entry<K, V>.key: K
+     get() = getKey()
+ 
+-/** Returns the value of the entry */
++/**
++ * Allows to access the value of a map entry as a property. Equivalent to `getValue()`.
++ */
+ public val <K, V> Map.Entry<K, V>.value: V
+     get() = getValue()
+ 
+-/** Returns the key of the entry */
++/**
++ * Returns the key of the map entry. This method allows to use multi-declarations when working with maps,","""Returns the key component of the map entry""
+",2015-02-09 16:03:34
+301,"@@ -52,37 +55,65 @@ public fun <K, V> linkedMapOf(vararg values: Pair<K, V>): LinkedHashMap<K, V> {
+     return answer
+ }
+ 
+-/** Returns the [[Map]] if its not null otherwise it returns the empty [[Map]] */
++/**
++ * Returns the [Map] if its not null, or the empty [Map] otherwise.
++ */
+ public fun <K,V> Map<K,V>?.orEmpty() : Map<K,V>
+        = if (this != null) this else emptyMap()
+ 
++/**
++ * Checks if the map contains the given key. This method allows to use the `x in map` syntax for checking
++ * whether an object is contained in the map.
++ */
+ public fun <K,V> Map<K,V>.contains(key : K) : Boolean = containsKey(key)
+ 
+-/** Returns the key of the entry */
++/**
++ * Allows to access the key of a map entry as a property. Equivalent to `getKey()`.
++ */
+ public val <K, V> Map.Entry<K, V>.key: K
+     get() = getKey()
+ 
+-/** Returns the value of the entry */
++/**
++ * Allows to access the value of a map entry as a property. Equivalent to `getValue()`.
++ */
+ public val <K, V> Map.Entry<K, V>.value: V
+     get() = getValue()
+ 
+-/** Returns the key of the entry */
++/**
++ * Returns the key of the map entry. This method allows to use multi-declarations when working with maps,
++ * for example:
++ * ```
++ * for ((key, value) in map) {
++ *     // do something with the key and the value
++ * }
++ * ```
++ */
+ public fun <K, V> Map.Entry<K, V>.component1(): K {
+     return getKey()
+ }
+ 
+-/** Returns the value of the entry */
++/**
++ * Returns the value of the map entry. This method allows to use multi-declarations when working with maps,","""Returns the value component of the map entry""
+",2015-02-09 16:03:48
+302,"@@ -52,37 +55,65 @@ public fun <K, V> linkedMapOf(vararg values: Pair<K, V>): LinkedHashMap<K, V> {
+     return answer
+ }
+ 
+-/** Returns the [[Map]] if its not null otherwise it returns the empty [[Map]] */
++/**
++ * Returns the [Map] if its not null, or the empty [Map] otherwise.
++ */
+ public fun <K,V> Map<K,V>?.orEmpty() : Map<K,V>
+        = if (this != null) this else emptyMap()
+ 
++/**
++ * Checks if the map contains the given key. This method allows to use the `x in map` syntax for checking
++ * whether an object is contained in the map.
++ */
+ public fun <K,V> Map<K,V>.contains(key : K) : Boolean = containsKey(key)
+ 
+-/** Returns the key of the entry */
++/**
++ * Allows to access the key of a map entry as a property. Equivalent to `getKey()`.
++ */
+ public val <K, V> Map.Entry<K, V>.key: K
+     get() = getKey()
+ 
+-/** Returns the value of the entry */
++/**
++ * Allows to access the value of a map entry as a property. Equivalent to `getValue()`.
++ */
+ public val <K, V> Map.Entry<K, V>.value: V
+     get() = getValue()
+ 
+-/** Returns the key of the entry */
++/**
++ * Returns the key of the map entry. This method allows to use multi-declarations when working with maps,
++ * for example:
++ * ```
++ * for ((key, value) in map) {
++ *     // do something with the key and the value
++ * }
++ * ```
++ */
+ public fun <K, V> Map.Entry<K, V>.component1(): K {
+     return getKey()
+ }
+ 
+-/** Returns the value of the entry */
++/**
++ * Returns the value of the map entry. This method allows to use multi-declarations when working with maps,
++ * for example:
++ * ```
++ * for ((key, value) in map) {
++ *     // do something with the key and the value
++ * }
++ * ```
++ */
+ public fun <K, V> Map.Entry<K, V>.component2(): V {
+     return getValue()
+ }
+ 
+-/** Converts entry to Pair with key being first component and value being second */
++/**
++ * Converts entry to [Pair] with key being first component and value being second","This doc uses first/second _component_, while doc for mapOf/hashMapOf/… uses first/second _value_. Should use the same word.
+",2015-02-09 16:05:14
+245,"@@ -527,10 +527,15 @@ static void generateConstructorWithoutParametersIfNeeded(
+         for (ValueParameterDescriptor parameterDescriptor : constructorDescriptor.getValueParameters()) {
+             Type paramType = state.getTypeMapper().mapType(parameterDescriptor.getType());
+             pushDefaultValueOnStack(paramType, v);
+-            mask |= (1 << parameterDescriptor.getIndex());
++            int i = parameterDescriptor.getIndex();
++            if (i != 0 && i % Integer.SIZE == 0) {
++                v.iconst(mask);
++                mask = 0;
++            }
++            mask |= (1 << (parameterDescriptor.getIndex() % Integer.SIZE));","Use `i` here, introduced a few lines earlier
+",2014-08-20 07:34:20
+244,"@@ -527,10 +527,15 @@ static void generateConstructorWithoutParametersIfNeeded(
+         for (ValueParameterDescriptor parameterDescriptor : constructorDescriptor.getValueParameters()) {
+             Type paramType = state.getTypeMapper().mapType(parameterDescriptor.getType());
+             pushDefaultValueOnStack(paramType, v);
+-            mask |= (1 << parameterDescriptor.getIndex());
++            int i = parameterDescriptor.getIndex();
++            if (i != 0 && i % Integer.SIZE == 0) {
++                v.iconst(mask);
++                mask = 0;
++            }
++            mask |= (1 << (parameterDescriptor.getIndex() % Integer.SIZE));
+         }
+         v.iconst(mask);","Should this `iconst` still be done if there's exactly `32*n` parameters?
+",2014-08-20 07:33:41
+870,"@@ -53,14 +54,20 @@ class MovePropertyToConstructorIntention :
+         applyTo(property, null)
+     }
+ 
+-    override fun isApplicableTo(element: KtProperty, caretOffset: Int): Boolean =
+-            !element.isLocal
+-            && !element.hasDelegate()
+-            && element.getter == null
+-            && element.setter == null
+-            && !element.hasModifier(LATEINIT_KEYWORD)
+-            && element.getStrictParentOfType<KtClassOrObject>() is KtClass
+-            && (element.initializer?.isValidInConstructor() ?: true)
++    override fun isApplicableTo(element: KtProperty, caretOffset: Int): Boolean {
++        fun KtProperty.isDeclaredInClass() : Boolean {
++            val parent = element.getStrictParentOfType<KtClassOrObject>()
++            return parent != null && !parent.isInterfaceClass()",Here it's also necessary to check that the `KtClassOrObject` is not an object declaration. I'll add this check.,2017-06-13 10:57:27
+341,"@@ -53,15 +82,15 @@ public fun thread(start: Boolean = true, daemon: Boolean = false, contextClassLo
+ 
+ /**
+  * Allows you to use the executor as a function to","""Allows you"" - not good for docs.
+",2015-03-12 14:58:09
+342,"@@ -53,15 +82,15 @@ public fun thread(start: Boolean = true, daemon: Boolean = false, contextClassLo
+ 
+ /**
+  * Allows you to use the executor as a function to
+- * execute the given block on the [[Executor]].
++ * execute the given block on the [Executor].
+  */
+ public fun Executor.invoke(action: () -> Unit) {
+     execute(action)
+ }
+ 
+ /**
+- * Allows you to use the executor as a function to
+- * execute the given block on the [[Executor]].
++ * Allows you to use the executor service as a function to","Allows you.
+",2015-03-12 14:58:17
+612,"@@ -538,6 +538,13 @@ class DefaultExpressionConverter : JavaElementVisitor(), ExpressionConverter {
+         val qualifier = expression.qualifierExpression
+ 
+         var identifier = Identifier.withNoPrototype(referenceName, isNullable)
++
++
++        if (expression.getContainingClass()?.getParentOfType<PsiField>(false).let { it != null && it == expression.qualifierExpression?.reference?.resolve() }) {","Why are you checking for `PsiField` specifically? Won't the same problem happen if the anonymous class is used as a local variable initializer?
+",2016-09-22 10:04:48
+402,"@@ -538,6 +538,16 @@
+                 <attribute name=""Main-Class"" value=""org.jetbrains.kotlin.cli.jvm.K2JVMCompiler""/>
+             </manifest>
+         </jar>
++
++        <delete file=""${output}/kotlin-compiler-embeddable.jar"" failonerror=""false""/>
++        <taskdef name=""jarjar"" classname=""com.tonicsystems.jarjar.JarJarTask"" classpath=""dependencies/jarjar.jar""/>
++        <jarjar jarfile=""${output}/kotlin-compiler-embeddable.jar"" filesonly=""true"" filesetmanifest=""merge"">
++            <zipfileset src=""${kotlin-home}/lib/kotlin-compiler.jar"" includes=""**""/>
++            <zipfileset src=""${bootstrap.runtime}"" includes=""**"" excludes=""META-INF/**""/>
++            <zipfileset src=""${bootstrap.reflect}"" includes=""**"" excludes=""META-INF/**""/>
++            <rule pattern=""com.google.**"" result=""kotlin.compiler.jvm.internal.impl.com.google.protobuf.@1""/>
++            <rule pattern=""javax.inject.**"" result=""kotlin.compiler.jvm.internal.impl.javax.inject.@1""/>","Please do not put it under package `kotlin` as this is what's used by our stdlib, reflection and other public API. I propose `org.jetbrains.kotlin.com.google.protobuf` and `org.jetbrains.kotlin.javax.inject`
+",2015-07-29 12:56:27
+419,"@@ -54,13 +62,14 @@ public static void runK2JvmCompiler(
+             CompilerSettings compilerSettings,
+             MessageCollector messageCollector,
+             CompilerEnvironment environment,
+-            File moduleFile,
++            Map<String, IncrementalCache> incrementalCaches, File moduleFile,","It seems it is better to have one parameter per line.
+",2015-08-20 14:10:55
+966,"@@ -54,6 +54,8 @@ enum class LanguageFeature(
+     InlineDefaultFunctionalParameters(KOTLIN_1_2),
+     SoundSmartCastsAfterTry(KOTLIN_1_2),
+     DeprecatedFieldForInvisibleCompanionObject(KOTLIN_1_2),
++    ContractEffects(KOTLIN_1_1),
++    CalledInPlaceEffect(KOTLIN_1_1),","Also, I suspect we require also the third feature, something like ""value analysis in conditions"". I have in mind checks like `if (1 == 2)`.",2017-08-15 15:46:32
+286,"@@ -548,7 +548,7 @@ public fun String.elementAt(index: Int): Char {
+ }
+ 
+ /**
+- * Returns first element
++ * Returns first element. Throws [NoSuchElementException] if the collection is empty.","Should it be `@throws` tag instead?
+",2015-02-09 15:45:56
+123,"@@ -55,6 +55,15 @@ import com.intellij.psi.PsiPackage
+ import com.intellij.psi.PsiClass
+ import com.intellij.psi.PsiMember
+ import org.jetbrains.jet.lang.psi.JetNamedDeclaration
++import org.jetbrains.jet.lang.psi.JetExpressionImpl
++import org.jetbrains.jet.lang.psi.JetContainerNode
++import org.jetbrains.jet.lang.psi.JetWhileExpression
++import org.jetbrains.jet.lang.psi.JetDoWhileExpression
++import org.jetbrains.jet.lang.psi.JetForExpression
++import org.jetbrains.jet.lang.psi.JetIfExpression
++import org.jetbrains.jet.JetNodeTypes
++import com.intellij.lang.ASTNode","Some imports are unused here :)
+",2014-03-04 16:01:37
+338,"@@ -55,6 +58,8 @@ public enum class InlineStrategy {
+  * receiving function are allowed to use non-local control flow statements. Lambdas which are called from
+  * a different execution context (for example, from an object contained in the receiving function)
+  * are restricted to local control flow statements.
++ *
++ * @property value the inlining options selected for this lambda.","""this lambda"" is unclear, may be ""options for annotated functional parameter""?
+",2015-03-12 14:50:46
+392,"@@ -55,8 +55,8 @@ protected void postProcess(PsiFile createdElement, String templateName, Map<Stri
+     @Override
+     protected void buildDialog(Project project, PsiDirectory directory, CreateFileFromTemplateDialog.Builder builder) {
+         builder
+-                .setTitle(JetBundle.message(""new.kotlin.file.action""))
+-                .addKind(""Kotlin file"", JetFileType.INSTANCE.getIcon(), ""Kotlin File"")
++                .setTitle(""New Kotlin File/Class"")","Other stuff under the `New...` menu doesn't start with ""New"", this probably shouldn't start as well
+",2015-07-14 13:19:40
+687,"@@ -551,8 +552,22 @@ internal open class KotlinAndroidPlugin(
+ }
+ 
+ private fun configureJavaTask(kotlinTask: KotlinCompile, javaTask: AbstractCompile, logger: Logger) {
++    // Gradle Java IC in older Gradle versions (before 2.14) cannot check .class directories updates.
++    // To make it work, reset the up-to-date status of compileJava with this flag.
++    kotlinTask.anyClassesCompiled = false
++    javaTask.outputs.upToDateWhen { task ->
++        val gradleSupportsJavaIcWithClassesDirs = ParsedGradleVersion.parse(javaTask.project.gradle.gradleVersion)",I think that version checking should be performed before `upToDateWhen` callback is added,2017-03-14 09:55:46
+686,"@@ -551,8 +552,22 @@ internal open class KotlinAndroidPlugin(
+ }
+ 
+ private fun configureJavaTask(kotlinTask: KotlinCompile, javaTask: AbstractCompile, logger: Logger) {
++    // Gradle Java IC in older Gradle versions (before 2.14) cannot check .class directories updates.
++    // To make it work, reset the up-to-date status of compileJava with this flag.
++    kotlinTask.anyClassesCompiled = false
++    javaTask.outputs.upToDateWhen { task ->
++        val gradleSupportsJavaIcWithClassesDirs = ParsedGradleVersion.parse(javaTask.project.gradle.gradleVersion)
++                                                          ?.let { it >= ParsedGradleVersion(2, 14) } ?: false
++        val kotlinClassesCompiled = kotlinTask.anyClassesCompiled
++        if (!gradleSupportsJavaIcWithClassesDirs && kotlinClassesCompiled) {
++            logger.info(""Marking $task out of date, because kotlin classes are changed"")
++            return@upToDateWhen false
++        }
++        true
++    }
++
+     // Make Gradle check if the javaTask up-to-date based on the Kotlin classes
+-    javaTask.inputs.dir(kotlinTask.destinationDir!!)
++    javaTask.inputs.dir(kotlinTask.destinationDir)","I think you should also include kapt1 annotations file:
+https://github.com/JetBrains/kotlin/blob/master/libraries/tools/kotlin-gradle-plugin/src/main/kotlin/org/jetbrains/kotlin/gradle/internal/AnnotationProcessingManager.kt#L139
+
+In kapt1 AP is performed by java task, so if this file is not included, AP may be skipped when only source annotations are modified.
+Kapt3 should probably work as intended.
+I think the test should be added for this case (Java IC + Kapt 1/3 + change only Kotlin source annotations).",2017-03-14 09:54:19
+500,"@@ -56,11 +60,37 @@ fun generateIsCheck(
+         }
+     }
+     else {
+-        generateInstanceOfInstruction(v)
++        TypeIntrinsics.instanceOf(v, kotlinType, asmType)
++    }
++}
++
++fun generateAsCheck(","`is` is a ""check"", but `as` is not :) `generateCast`?
+",2015-12-28 15:07:05
+952,"@@ -56,6 +57,13 @@ open class AddModifierFix(
+ 
+     override fun invoke(project: Project, editor: Editor?, file: KtFile) {
+         element?.addModifier(modifier)
++
++        if (modifier == KtTokens.ABSTRACT_KEYWORD && (element is KtProperty || element is KtNamedFunction)) {
++            element?.containingClass()?.run {
++                if (!hasModifier(KtTokens.ABSTRACT_KEYWORD) && !hasModifier(KtTokens.SEALED_KEYWORD)) addModifier(KtTokens.ABSTRACT_KEYWORD)
++                if (hasModifier(KtTokens.OPEN_KEYWORD)) removeModifier(KtTokens.OPEN_KEYWORD)","Should work without this line, at least in theory. Will check it myself.",2017-08-04 18:26:05
+535,"@@ -57,11 +58,10 @@ class KotlinMavenArchetypesProvider : MavenArchetypesProvider {
+             .asJsonArray
+             .map { it.asJsonObject }
+             .map { MavenArchetype(it.get(""g"").asString, it.get(""a"").asString, it.get(""v"").asString, null, null) }
+-            .filter { it.version.matches(versionRegexp) }
+-            .groupBy { it.artifactId + ""-"" + it.version.substringBeforeLast('.') }
+-            .mapValues { it.value.maxBy { a -> a.version.substringAfterLast('.').toInt() }!! }
+-            .values
+-            .toList()
++            .filter { it.version?.startsWith(versionPrefix) ?: false }
++            .maxBy { MavenVersionComparable(it.version) }
++            ?.let { listOf(it) }","It might be cleaner to use `listOfNotNull` instead of `?.let { listOf } ?: emptyList()`
+",2016-03-31 15:16:06
+873,"@@ -57,6 +58,16 @@ class RedundantSemicolonInspection : AbstractKotlinInspection(), CleanupLocalIns
+ 
+         if (semicolon.parent is KtEnumEntry) return false
+ 
++        (semicolon.parent.parent as? KtClass)?.let {
++            if (it.isEnum() && it.getChildrenOfType<KtEnumEntry>().isEmpty()) {
++                if (semicolon.prevLeaf { it !is PsiWhiteSpace && it !is PsiComment && !it.isLineBreak() }?.node?.elementType == KtTokens.LBRACE &&
++                    semicolon.nextLeaf { it !is PsiWhiteSpace && it !is PsiComment && !it.isLineBreak() }?.node?.elementType != KtTokens.RBRACE) {","I thinks it's more precise just to check here that `getDeclarations()` isn't empty, instead of doing these operations with `nextLeaf`.",2017-06-26 09:32:09
+309,"@@ -58,12 +68,22 @@ public fun CharSequence.iterator(): CharIterator = object : CharIterator() {
+     public override fun hasNext(): Boolean = index < length
+ }
+ 
+-/** Returns the string if it is not null or the empty string if its null */
++/** Returns the string if it is not null, or the empty string otherwise. */
+ public fun String?.orEmpty(): String = this ?: """"
+ 
++/**
++ * Returns the range of valid character indices for this string.
++ */
+ public val String.indices: IntRange
+     get() = 0..length() - 1
+ 
++/**
++ * Returns a character at the given index in a [CharSequence]. Allows to use the
++ * brackets notation for working with character sequences:","""brackets notation"" -> ""index operator""
+",2015-02-09 16:18:51
+650,"@@ -59,17 +90,49 @@ class ReplaceSingleLineLetIntention : SelfTargetingOffsetIndependentIntention<Kt
+     override fun isApplicableTo(element: KtCallExpression): Boolean {
+         if (!isLetMethod(element)) return false
+         val lambdaExpression = element.lambdaArguments.firstOrNull()?.getLambdaExpression() ?: return false
+-        val bodyExpression = lambdaExpression.bodyExpression?.children?.singleOrNull() ?: return false
+-        val dotQualifiedExpression = bodyExpression as? KtDotQualifiedExpression ?: return false
+         val parameterName = lambdaExpression.getParameterName() ?: return false
+-        val receiverExpression = dotQualifiedExpression.getLeftMostReceiverExpression()
+-        if (receiverExpression.text != parameterName) return false
+-        dotQualifiedExpression.selectorExpression?.let {
+-            if (it.anyDescendantOfType<KtLambdaExpression>()) return false
++        val bodyExpression = lambdaExpression.bodyExpression?.children?.singleOrNull() ?: return false
++
++        return when (bodyExpression) {
++            is KtBinaryExpression -> bodyExpression.isApplication(parameterName)
++            is KtDotQualifiedExpression -> bodyExpression.isApplicable(parameterName)","Why is the first `isApplication`, but the second `isApplicable`?
+",2016-11-07 09:26:04
+651,"@@ -59,17 +90,49 @@ class ReplaceSingleLineLetIntention : SelfTargetingOffsetIndependentIntention<Kt
+     override fun isApplicableTo(element: KtCallExpression): Boolean {
+         if (!isLetMethod(element)) return false
+         val lambdaExpression = element.lambdaArguments.firstOrNull()?.getLambdaExpression() ?: return false
+-        val bodyExpression = lambdaExpression.bodyExpression?.children?.singleOrNull() ?: return false
+-        val dotQualifiedExpression = bodyExpression as? KtDotQualifiedExpression ?: return false
+         val parameterName = lambdaExpression.getParameterName() ?: return false
+-        val receiverExpression = dotQualifiedExpression.getLeftMostReceiverExpression()
+-        if (receiverExpression.text != parameterName) return false
+-        dotQualifiedExpression.selectorExpression?.let {
+-            if (it.anyDescendantOfType<KtLambdaExpression>()) return false
++        val bodyExpression = lambdaExpression.bodyExpression?.children?.singleOrNull() ?: return false
++
++        return when (bodyExpression) {
++            is KtBinaryExpression -> bodyExpression.isApplication(parameterName)
++            is KtDotQualifiedExpression -> bodyExpression.isApplicable(parameterName)
++            else -> false
+         }
+-        return !dotQualifiedExpression.receiverUsedAsArgument(parameterName)
+     }
+ 
++    private fun KtBinaryExpression.isApplication(parameterName: String): Boolean {
++        val left = left ?: return false
++
++        if (when (left) {
++            is KtNameReferenceExpression -> left.text != parameterName
++            is KtDotQualifiedExpression -> !left.isApplicable(parameterName)
++            else -> return false
++        }) return false","This construction is hard to read. I'd rewrite it like
+
+```
+when (...) {
+    is ... -> if (...) return false
+}
+```
+",2016-11-07 09:27:24
+866,"@@ -596,6 +596,12 @@ public void testSpaceBeforeFunctionLiteral() throws Exception {
+             doTest(fileName);
+         }
+ 
++        @TestMetadata(""SpaceBeforeIndices.after.kt"")
++        public void testSpaceBeforeIndices() throws Exception {
++            String fileName = KotlinTestUtils.navigationMetadata(""idea/testData/formatter/SpaceBeforeIndices.after.kt"");
++            doTest(fileName);
++        }
++
+         @TestMetadata(""SpacedInsideParans.after.kt"")",Lenor ,2017-05-31 19:47:02
+308,"@@ -6,7 +6,10 @@ public fun String.trim(text: String): String = trimLeading(text).trimTrailing(te
+ /** Returns the string with the prefix and postfix text trimmed */
+ public fun String.trim(prefix: String, postfix: String): String = trimLeading(prefix).trimTrailing(postfix)
+ 
+-/** Returns the string with the leading prefix of this string removed */
++/**
++ * If this string starts with the given [prefix], returns a copy of this string","Documentation is backwards. Normally it reads ""Returns a … if …, otherwise …""
+",2015-02-09 16:16:54
+1,"@@ -60,6 +60,8 @@ public inline fun String.format(format : String, vararg args : Any?) : String =
+ 
+ public inline fun String.split(regex : String) : Array<String> = (this as java.lang.String).split(regex) as Array<String>
+ 
++public inline fun String.split(ch : Char) : Array<String> = (this as java.lang.String).split(java.util.regex.Pattern.quote(ch.toString())) as Array<String>","Why here you are casting ""this"" to String? 
+",2012-04-23 06:52:06
+389,"@@ -61,6 +64,8 @@ protected void applyEditorTo(JetRunConfiguration configuration) throws Configura
+         myModuleSelector.applyTo(configuration);
+         myCommonProgramParameters.applyTo(configuration);
+         configuration.setRunClass(myMainClassField.getText());
++        configuration.setAlternativeJrePath(alternativeJREPanel.getPath());
++        configuration.setAlternativeJrePathEnabled(alternativeJREPanel.isPathEnabled());","Has it real effect during run? Is it enough to just set it to a configuration?
+",2015-06-23 13:19:02
+611,"@@ -61,6 +66,13 @@ class KotlinIndicesHelper(
+ 
+     private val moduleDescriptor = resolutionFacade.moduleDescriptor
+     private val project = resolutionFacade.project
++    private val scopeWithoutKotlin = ScopeWithoutKotlin(scope)","You can use `SearchUtil.excludeKotlinSources`
+",2016-09-21 16:20:25
+242,"@@ -614,10 +614,22 @@ public JvmMethodSignature mapSignature(@NotNull FunctionDescriptor f, @NotNull O
+     }
+ 
+     @NotNull
++    public static String getDefaultDescriptor(@NotNull String descriptor) {","Take a look on the usages, this method should take a `Method` as a parameter rather than a `String`
+",2014-08-20 07:22:45
+240,"@@ -614,10 +614,22 @@ public JvmMethodSignature mapSignature(@NotNull FunctionDescriptor f, @NotNull O
+     }
+ 
+     @NotNull
++    public static String getDefaultDescriptor(@NotNull String descriptor) {
++        // read Type.getArgumentsAndReturnSizes documentation for explanations","This comment is useless :) If I don't understand `>> 2`, I'll go and read what the method returns by myself, and if I do, I need not this comment at all
+",2014-08-20 07:14:50
+239,"@@ -614,10 +614,22 @@ public JvmMethodSignature mapSignature(@NotNull FunctionDescriptor f, @NotNull O
+     }
+ 
+     @NotNull
++    public static String getDefaultDescriptor(@NotNull String descriptor) {
++        // read Type.getArgumentsAndReturnSizes documentation for explanations
++        int argumentsSize = (Type.getArgumentsAndReturnSizes(descriptor) >> 2) - 1;
++        int maskArgumentsCont = argumentsSize / Integer.SIZE + (argumentsSize % Integer.SIZE == 0 ? 0 : 1);","Typo? _count_, not cont
+",2014-08-20 07:10:01
+238,"@@ -614,10 +614,22 @@ public JvmMethodSignature mapSignature(@NotNull FunctionDescriptor f, @NotNull O
+     }
+ 
+     @NotNull
++    public static String getDefaultDescriptor(@NotNull String descriptor) {
++        // read Type.getArgumentsAndReturnSizes documentation for explanations
++        int argumentsSize = (Type.getArgumentsAndReturnSizes(descriptor) >> 2) - 1;
++        int maskArgumentsCont = argumentsSize / Integer.SIZE + (argumentsSize % Integer.SIZE == 0 ? 0 : 1);
++        String maskArguments = ""I"";
++        for (int i = 1; i < maskArgumentsCont; i++) {
++            maskArguments += 'I';
++        }","`StringUtil.repeat(INT_TYPE.getDescriptor(), maskArgumentsCount)`
+",2014-08-20 07:09:14
+386,"@@ -63,12 +66,36 @@ private KotlinRuntimeLibraryUtil() {}
+ 
+     @NotNull
+     public static Collection<VirtualFile> getLibraryRootsWithAbiIncompatibleKotlinClasses(@NotNull Project project) {
+-        return getLibraryRootsWithAbiIncompatibleVersion(project, KotlinAbiVersionIndex.INSTANCE$);
++        return getLibraryRootsWithAbiIncompatibleVersion(project, KotlinAbiVersionIndex.INSTANCE$,
++                            new Predicate<Module>() {
++                             @Override
++                             public boolean apply(@Nullable Module module) {
++                                 return module != null && ProjectStructureUtil.isJavaKotlinModule(module);
++                             }
++                            },
++                            new Predicate<Integer>() {
++                             @Override
++                             public boolean apply(Integer abiVersion) {
++                                 return !AbiVersionUtil.isAbiVersionCompatible(abiVersion);
++                             }
++                            });","Something wrong with formatting in this file I suppose?
+",2015-06-11 21:59:37
+17,"@@ -63,3 +63,16 @@ public inline fun String.count(predicate: (Char) -> Boolean): Int {
+     }
+     return answer
+ }
++
++/**
++ * Repeats a given string n times. With n <= 0, the empty string is returned.","I think it's better to throw IllegalArgumentException if n < 0, because it doesn't make much sense to hide user's error and return empty string in this case.
+",2012-11-15 09:52:35
+16,"@@ -63,3 +63,16 @@ public inline fun String.count(predicate: (Char) -> Boolean): Int {
+     }
+     return answer
+ }
++
++/**
++ * Repeats a given string n times. With n <= 0, the empty string is returned.
++ * @includeFunctionBody ../../test/StringTest.kt times
++ */
++public inline fun String.times(var n: Int) : String {
++    var answer = """";","semicolons are noise which is unnecessary in Kotlin :)
+",2012-11-15 09:48:58
+15,"@@ -63,3 +63,16 @@ public inline fun String.count(predicate: (Char) -> Boolean): Int {
+     }
+     return answer
+ }
++
++/**
++ * Repeats a given string n times. With n <= 0, the empty string is returned.
++ * @includeFunctionBody ../../test/StringTest.kt times
++ */
++public inline fun String.times(var n: Int) : String {
++    var answer = """";
++    while (n > 0) {
++        answer = answer.concat(this)","I think that it'll be good to use StringBuilder#append instead of strings concatenations.
+",2012-11-15 09:45:38
+892,"@@ -63,6 +63,13 @@ val PsiElement.parentsWithSelf: Sequence<PsiElement>
+ val PsiElement.parents: Sequence<PsiElement>
+     get() = parentsWithSelf.drop(1)
+ 
++fun PsiElement.matchParents(vararg parentClasses: Class<out PsiElement>): Boolean {
++    return this.parents.zip(sequenceOf(*parentClasses)).all {
++        val (elem, clazz) = it
++        clazz.isAssignableFrom(elem.javaClass)","With lambda argument destructuring and `isInstance` method you could write this method as
+
+```
+    return this.parents.zip(sequenceOf(*parentClasses)).all { (elem, clazz) ->
+        clazz.isInstance(elem)
+    }
+```",2017-07-12 10:26:50
+690,"@@ -63,6 +63,7 @@
+       <module fileurl=""file://$PROJECT_DIR$/compiler/ir/ir.tree/ir.tree.iml"" filepath=""$PROJECT_DIR$/compiler/ir/ir.tree/ir.tree.iml"" group=""compiler/ir"" />
+       <module fileurl=""file://$PROJECT_DIR$/j2k/j2k.iml"" filepath=""$PROJECT_DIR$/j2k/j2k.iml"" group=""j2k"" />
+       <module fileurl=""file://$PROJECT_DIR$/plugins/java-model-wrappers/java-model-wrappers.iml"" filepath=""$PROJECT_DIR$/plugins/java-model-wrappers/java-model-wrappers.iml"" group=""plugins"" />
++      <module fileurl=""file://$PROJECT_DIR$/compiler/javac/javac.iml"" filepath=""$PROJECT_DIR$/compiler/javac/javac.iml"" group=""compiler"" />",I'm not sure `javac` is the best possible name here. May be something like `javac-wrapper`?,2017-04-05 11:20:29
+493,"@@ -63,6 +65,10 @@ public abstract class KotlinLightCodeInsightFixtureTestCase : LightCodeInsightFi
+                 super.processError(message, t, details, logger)
+             }
+         })
++
++        // set to false if not present or set to true or unknown (empty considered true)
++        if (System.getProperty(KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY)?.let { it.toBooleanLenient() ?: true } ?: true )","This could be written as
+
+```
+if (KOTLIN_COMPILER_ENVIRONMENT_KEEPALIVE_PROPERTY.systemPropertyAsBooleanOrTrueOtherwise(negate = false)) {
+```
+",2015-11-27 18:22:54
+976,"@@ -64,4 +66,92 @@ internal annotation class InlineOnly
+  */
+ @Target(AnnotationTarget.FUNCTION, AnnotationTarget.PROPERTY)
+ @Retention(AnnotationRetention.BINARY)
+-internal annotation class DynamicExtension
+\ No newline at end of file
++internal annotation class DynamicExtension
++
++/**
++ * Specifies effect: annotated function returns specific value when condition provided
++ * by other annotations is true.*
++ */
++@Target(AnnotationTarget.FUNCTION)
++@Retention(AnnotationRetention.BINARY)
++internal annotation class Returns(val value: ConstantValue = ConstantValue.UNKNOWN)
++
++/**
++ * Specifies effect: annotated function throws 'exception' when condition is true
++ */
++@Target(AnnotationTarget.FUNCTION)
++@Retention(AnnotationRetention.BINARY)
++internal annotation class Throws",I didn't notice any use of this annotation (may be I missed something),2017-08-15 16:17:28
+236,"@@ -64,6 +64,13 @@
+             KotlinBuiltIns.getInstance().getChar()
+     );
+ 
++    private static final Set<String> STRINGBULDER_OBJECT_APPEND_ARG_TYPES = Sets.newHashSet(","I think declaring a `Set<Type>` would be more straightforward. You can use `Type.getType(Class<?>)` to create corresponding `Type` objects
+",2014-05-12 20:45:35
+665,"@@ -650,7 +650,7 @@ class DefaultExpressionConverter : JavaElementVisitor(), ExpressionConverter {
+             result = MethodCallExpression.buildNonNull(operandConverted, typeConversion)
+         }
+         else {
+-            val nullability = if (operandConverted.isNullable && !expression.isQualifier())
++            val nullability = if ((operandConverted.isNullable && !expression.isQualifier()) || operandType == PsiType.NULL)","Better not to hack this check, but fix problem with `operandConverted.isNullable == false` for `null` literal  ",2016-12-27 11:47:32
+586,"@@ -67,7 +73,15 @@ abstract class KtCodeFragment(
+ 
+     override fun isValid() = true
+ 
+-    override fun getContext() = context
++    override fun getContext(): PsiElement? {
++        if (fakeContextForJavaFile != null) return fakeContextForJavaFile
++        if (context !is KtElement) {
++            LOG.warn(""CodeFragment with non-kotlin context should have fakeContextForJavaFile set: \noriginalContext = ${context?.getElementTextWithContext()}"")","We shouldn't create kotlin codeFragments for scala files. See KotlinCodeFragmentFactory.isContextAccepted
+",2016-08-03 14:06:55
+2,"@@ -68,10 +70,14 @@ public inline fun String.startsWith(prefix: String) : Boolean = (this as java.la
+ 
+ public inline fun String.startsWith(prefix: String, toffset: Int) : Boolean = (this as java.lang.String).startsWith(prefix, toffset)
+ 
++public inline fun String.startsWith(ch: Char) : Boolean = (this as java.lang.String).startsWith(ch.toString())","The same
+",2012-04-23 06:52:41
+906,"@@ -68,3 +64,9 @@ class ClassBody(
+         builder.append(companionObjectMembers, ""\n"", ""companion object {\n"", ""\n}"")
+     }
+ }
++
++private object PropertyComparator : Comparator<Member> {
++    override fun compare(o1: Member?, o2: Member?): Int {
++        return if (o1 is Property) if (o2 is Property) 0 else -1 else if (o2 is Property) 1 else 0",I'd use when for readability ,2017-07-17 18:14:59
+960,"@@ -69,6 +68,15 @@ class KotlinRedundantOverrideInspection : AbstractKotlinInspection(), CleanupLoc
+                 }
+             }
+ 
++    private fun KtNamedFunction.containsOtherModifier(): Boolean {
++        MODIFIER_EXCLUDE_OVERRIDE.forEach {",You can simplify this to `return MODIFIER_EXCLUDE_OVERRIDE.any { hasModifier(it) }`,2017-08-15 09:48:07
+19,"@@ -69,7 +72,18 @@ public TextRange getRangeInElement() {
+ 
+     @Override
+     public PsiElement handleElementRename(String newElementName) throws IncorrectOperationException {
+-        PsiElement element = JetPsiFactory.createNameIdentifier(myExpression.getProject(), newElementName);
++        IElementType type = myExpression.getReferencedNameElementType();
++        final PsiElement element;","We do not mark variables final unless this is required by the compiler.
+",2013-01-11 15:18:39
+420,"@@ -69,7 +78,7 @@ public static void runK2JsCompiler(
+             @NotNull CompilerSettings compilerSettings,
+             @NotNull MessageCollector messageCollector,
+             @NotNull CompilerEnvironment environment,
+-            @NotNull OutputItemsCollector collector,
++            Map<String, IncrementalCache> incrementalCaches, @NotNull OutputItemsCollector collector,","Same here --- one parameter per line.
+",2015-08-20 14:11:23
+344,"@@ -7,127 +7,358 @@ import java.util.regex.MatchResult
+ import java.util.regex.Pattern
+ import java.nio.charset.Charset
+ 
++/**
++ * Returns the index within this string of the last occurrence of the specified substring.
++ */
+ public fun String.lastIndexOf(str: String): Int = (this as java.lang.String).lastIndexOf(str)
+ 
++/**
++ * Returns the index within this string of the last occurrence of the specified character.
++ */
+ public fun String.lastIndexOf(ch: Char): Int = (this as java.lang.String).lastIndexOf(ch.toString())
+ 
++/**
++ * Compares this string to another string, ignoring case considerations.
++ */
+ public fun String.equalsIgnoreCase(anotherString: String): Boolean = (this as java.lang.String).equalsIgnoreCase(anotherString)
+ 
++/**
++ * Returns the hash code of this string.
++ */
+ public fun String.hashCode(): Int = (this as java.lang.String).hashCode()
+ 
++/**
++ * Returns the index within this string of the first occurrence of the specified substring.
++ */
+ public fun String.indexOf(str: String): Int = (this as java.lang.String).indexOf(str)
+ 
++/**
++ * Returns the index within this string of the first occurrence of the specified substring, starting from the specified offset.
++ */
+ public fun String.indexOf(str: String, fromIndex: Int): Int = (this as java.lang.String).indexOf(str, fromIndex)
+ 
++/**
++ * Returns a copy of this string with all occurrences of [oldChar] replaced with [newChar].
++ */
+ public fun String.replace(oldChar: Char, newChar: Char): String = (this as java.lang.String).replace(oldChar, newChar)
+ 
++/**
++ * Returns a new string obtained by replacing each substring of this string that matches the given regular expression
++ * with the given [replacement].
++ */
+ public fun String.replaceAll(regex: String, replacement: String): String = (this as java.lang.String).replaceAll(regex, replacement)
+ 
++/**
++ * Returns a copy of this string with leading and trailing whitespace trimmed.
++ */
+ public fun String.trim(): String = (this as java.lang.String).trim()
+ 
++/**
++ * Returns a copy of this string converted to upper case using the rules of the default locale.
++ */
+ public fun String.toUpperCase(): String = (this as java.lang.String).toUpperCase()
+ 
++/**
++ * Returns a copy of this string converted to lower case using the rules of the default locale.
++ */
+ public fun String.toLowerCase(): String = (this as java.lang.String).toLowerCase()
+ 
++/**
++ * Returns a new character array containing the characters from this string.
++ */
+ public fun String.toCharArray(): CharArray = (this as java.lang.String).toCharArray()
+ 
++/**
++ * Uses this string as a format string and returns a string obtained by substituting the specified arguments,
++ * using the default locale.
++ */
+ public fun String.format(vararg args: Any?): String = java.lang.String.format(this, *args)
+ 
++/**
++ * Uses this string as a format string and returns a string obtained by substituting the specified arguments, using
++ * the specified locale.
++ */
+ public fun String.format(locale: Locale, vararg args : Any?) : String = java.lang.String.format(locale, this, *args)
+ 
++/**
++ * Splits this string around matches of the given regular expression.
++ */
+ public fun String.split(regex: String): Array<String> = (this as java.lang.String).split(regex)
+ 
++/**
++ * Splits this string around occurrences of the specified character.
++ */
+ public fun String.split(ch: Char): Array<String> = (this as java.lang.String).split(java.util.regex.Pattern.quote(ch.toString()))
+ 
++/**
++ * Returns a substring of this string starting with the specified index.
++ */
+ public fun String.substring(beginIndex: Int): String = (this as java.lang.String).substring(beginIndex)
+ 
++/**
++ * Returns the substring of this string starting and ending at the specified indices.
++ */
+ public fun String.substring(beginIndex: Int, endIndex: Int): String = (this as java.lang.String).substring(beginIndex, endIndex)
+ 
++/**
++ * Returns `true` if this string starts with the specified prefix.
++ */
+ public fun String.startsWith(prefix: String): Boolean = (this as java.lang.String).startsWith(prefix)
+ 
++/**
++ * Returns `true` if a subsring of this string starting at the specified offset starts with the specified prefix.
++ */
+ public fun String.startsWith(prefix: String, toffset: Int): Boolean = (this as java.lang.String).startsWith(prefix, toffset)
+ 
++/**
++ * Returns `true` if this string starts with the specified character.
++ */
+ public fun String.startsWith(ch: Char): Boolean = (this as java.lang.String).startsWith(ch.toString())
+ 
++/**
++ * Returns `true` if this string contains the specified sequence of characters as a substring.
++ */
+ public fun String.contains(seq: CharSequence): Boolean = (this as java.lang.String).contains(seq)
+ 
++/**
++ * Returns `true` if this string ends with the specified suffix.
++ */
+ public fun String.endsWith(suffix: String): Boolean = (this as java.lang.String).endsWith(suffix)
+ 
++/**
++ * Returns `true` if this string ends with the specified character.
++ */
+ public fun String.endsWith(ch: Char): Boolean = (this as java.lang.String).endsWith(ch.toString())
+ 
+ // ""constructors"" for String
+ 
++/**
++ * Converts the data from a portion of the specified array of bytes to characters using the specified character set
++ * and returns the conversion result as a string.
++ *
++ * @param offset the offset in the array of the data to be converted.
++ * @param length the number of bytes to be converted.","charsetName parameter missing
+",2015-03-12 15:05:31
+345,"@@ -7,127 +7,358 @@ import java.util.regex.MatchResult
+ import java.util.regex.Pattern
+ import java.nio.charset.Charset
+ 
++/**
++ * Returns the index within this string of the last occurrence of the specified substring.
++ */
+ public fun String.lastIndexOf(str: String): Int = (this as java.lang.String).lastIndexOf(str)
+ 
++/**
++ * Returns the index within this string of the last occurrence of the specified character.
++ */
+ public fun String.lastIndexOf(ch: Char): Int = (this as java.lang.String).lastIndexOf(ch.toString())
+ 
++/**
++ * Compares this string to another string, ignoring case considerations.
++ */
+ public fun String.equalsIgnoreCase(anotherString: String): Boolean = (this as java.lang.String).equalsIgnoreCase(anotherString)
+ 
++/**
++ * Returns the hash code of this string.
++ */
+ public fun String.hashCode(): Int = (this as java.lang.String).hashCode()
+ 
++/**
++ * Returns the index within this string of the first occurrence of the specified substring.
++ */
+ public fun String.indexOf(str: String): Int = (this as java.lang.String).indexOf(str)
+ 
++/**
++ * Returns the index within this string of the first occurrence of the specified substring, starting from the specified offset.
++ */
+ public fun String.indexOf(str: String, fromIndex: Int): Int = (this as java.lang.String).indexOf(str, fromIndex)
+ 
++/**
++ * Returns a copy of this string with all occurrences of [oldChar] replaced with [newChar].
++ */
+ public fun String.replace(oldChar: Char, newChar: Char): String = (this as java.lang.String).replace(oldChar, newChar)
+ 
++/**
++ * Returns a new string obtained by replacing each substring of this string that matches the given regular expression
++ * with the given [replacement].
++ */
+ public fun String.replaceAll(regex: String, replacement: String): String = (this as java.lang.String).replaceAll(regex, replacement)
+ 
++/**
++ * Returns a copy of this string with leading and trailing whitespace trimmed.
++ */
+ public fun String.trim(): String = (this as java.lang.String).trim()
+ 
++/**
++ * Returns a copy of this string converted to upper case using the rules of the default locale.
++ */
+ public fun String.toUpperCase(): String = (this as java.lang.String).toUpperCase()
+ 
++/**
++ * Returns a copy of this string converted to lower case using the rules of the default locale.
++ */
+ public fun String.toLowerCase(): String = (this as java.lang.String).toLowerCase()
+ 
++/**
++ * Returns a new character array containing the characters from this string.
++ */
+ public fun String.toCharArray(): CharArray = (this as java.lang.String).toCharArray()
+ 
++/**
++ * Uses this string as a format string and returns a string obtained by substituting the specified arguments,
++ * using the default locale.
++ */
+ public fun String.format(vararg args: Any?): String = java.lang.String.format(this, *args)
+ 
++/**
++ * Uses this string as a format string and returns a string obtained by substituting the specified arguments, using
++ * the specified locale.
++ */
+ public fun String.format(locale: Locale, vararg args : Any?) : String = java.lang.String.format(locale, this, *args)
+ 
++/**
++ * Splits this string around matches of the given regular expression.
++ */
+ public fun String.split(regex: String): Array<String> = (this as java.lang.String).split(regex)
+ 
++/**
++ * Splits this string around occurrences of the specified character.
++ */
+ public fun String.split(ch: Char): Array<String> = (this as java.lang.String).split(java.util.regex.Pattern.quote(ch.toString()))
+ 
++/**
++ * Returns a substring of this string starting with the specified index.
++ */
+ public fun String.substring(beginIndex: Int): String = (this as java.lang.String).substring(beginIndex)
+ 
++/**
++ * Returns the substring of this string starting and ending at the specified indices.
++ */
+ public fun String.substring(beginIndex: Int, endIndex: Int): String = (this as java.lang.String).substring(beginIndex, endIndex)
+ 
++/**
++ * Returns `true` if this string starts with the specified prefix.
++ */
+ public fun String.startsWith(prefix: String): Boolean = (this as java.lang.String).startsWith(prefix)
+ 
++/**
++ * Returns `true` if a subsring of this string starting at the specified offset starts with the specified prefix.
++ */
+ public fun String.startsWith(prefix: String, toffset: Int): Boolean = (this as java.lang.String).startsWith(prefix, toffset)
+ 
++/**
++ * Returns `true` if this string starts with the specified character.
++ */
+ public fun String.startsWith(ch: Char): Boolean = (this as java.lang.String).startsWith(ch.toString())
+ 
++/**
++ * Returns `true` if this string contains the specified sequence of characters as a substring.
++ */
+ public fun String.contains(seq: CharSequence): Boolean = (this as java.lang.String).contains(seq)
+ 
++/**
++ * Returns `true` if this string ends with the specified suffix.
++ */
+ public fun String.endsWith(suffix: String): Boolean = (this as java.lang.String).endsWith(suffix)
+ 
++/**
++ * Returns `true` if this string ends with the specified character.
++ */
+ public fun String.endsWith(ch: Char): Boolean = (this as java.lang.String).endsWith(ch.toString())
+ 
+ // ""constructors"" for String
+ 
++/**
++ * Converts the data from a portion of the specified array of bytes to characters using the specified character set
++ * and returns the conversion result as a string.
++ *
++ * @param offset the offset in the array of the data to be converted.
++ * @param length the number of bytes to be converted.
++ */
+ public fun String(bytes: ByteArray, offset: Int, length: Int, charsetName: String): String = java.lang.String(bytes, offset, length, charsetName) as String
+ 
++/**
++ * Converts the data from a portion of the specified array of bytes to characters using the specified character set
++ * and returns the conversion result as a string.
++ *
++ * @param offset the offset in the array of the data to be converted.
++ * @param length the number of bytes to be converted.
++ */","charset parameter missing
+",2015-03-12 15:05:45
+937,"@@ -70,7 +72,11 @@ fun KtLambdaArgument.moveInsideParenthesesAndReplaceWith(
+     val newCallExpression = oldCallExpression.copy() as KtCallExpression
+ 
+     val psiFactory = KtPsiFactory(project)
+-    val argument = if (newCallExpression.getValueArgumentsInParentheses().any { it.isNamed() }) {
++
++    val argument = if (newCallExpression.getValueArgumentsInParentheses().run {",I think this nested `run` expression is far too complex. Better to extract this logic into a method.,2017-08-03 09:53:52
+250,"@@ -71,48 +90,72 @@ public open class KotlinCompile(): AbstractCompile() {
+ 
+     [TaskAction]
+     override fun compile() {
+-
+-        getLogger().debug(""Starting Kotlin compilation task"")
+-
+-        val args = K2JVMCompilerArguments()
+-
+-        val javaSrcRoots = HashSet<File>()
+-        val sources = ArrayList<File>()
+-
+-        // collect source directory roots for all java files to allow cross compilation
+-        for (file in getSource()) {
+-            if (FilenameUtils.getExtension(file.getName()).equalsIgnoreCase(""java"")) {
+-                val javaRoot = findSrcDirRoot(file)
+-                if (javaRoot != null) {
+-                    javaSrcRoots.add(javaRoot)
+-                }
+-            } else {
+-                sources.add(file)
+-            }
+-        }
+-
++        getLogger().debug(""Starting ${javaClass} task"")
++        val args = createBlankArgs()
++        val sources = getKotlinSources()
+         if (sources.empty) {
+             getLogger().warn(""No Kotlin files found, skipping Kotlin compiler task"")
+             return
+         }
+ 
++        populateTargetSpecificArgs(args, sources)
++        populateCommonArgs(args, sources)
++        callCompiler(args)
++        afterCompileHook(args)
++    }
++
++    protected fun isJava(it: File): Boolean = FilenameUtils.getExtension(it.getName()).equalsIgnoreCase(""java"")
++
++    private fun getKotlinSources(): ArrayList<File> = getSource()","The call chain may be written in one line
+",2014-11-11 17:14:33
+253,"@@ -71,48 +90,72 @@ public open class KotlinCompile(): AbstractCompile() {
+ 
+     [TaskAction]
+     override fun compile() {
+-
+-        getLogger().debug(""Starting Kotlin compilation task"")
+-
+-        val args = K2JVMCompilerArguments()
+-
+-        val javaSrcRoots = HashSet<File>()
+-        val sources = ArrayList<File>()
+-
+-        // collect source directory roots for all java files to allow cross compilation
+-        for (file in getSource()) {
+-            if (FilenameUtils.getExtension(file.getName()).equalsIgnoreCase(""java"")) {
+-                val javaRoot = findSrcDirRoot(file)
+-                if (javaRoot != null) {
+-                    javaSrcRoots.add(javaRoot)
+-                }
+-            } else {
+-                sources.add(file)
+-            }
+-        }
+-
++        getLogger().debug(""Starting ${javaClass} task"")
++        val args = createBlankArgs()
++        val sources = getKotlinSources()
+         if (sources.empty) {
+             getLogger().warn(""No Kotlin files found, skipping Kotlin compiler task"")
+             return
+         }
+ 
++        populateTargetSpecificArgs(args, sources)
++        populateCommonArgs(args, sources)
++        callCompiler(args)
++        afterCompileHook(args)
++    }
++
++    protected fun isJava(it: File): Boolean = FilenameUtils.getExtension(it.getName()).equalsIgnoreCase(""java"")
++
++    private fun getKotlinSources(): ArrayList<File> = getSource()
++            .filterNot { isJava(it) }","I think more properly to check that it's kotlin file.
+
+P.S. I see that it's legacy code
+",2014-11-11 17:59:07
+252,"@@ -71,48 +90,72 @@ public open class KotlinCompile(): AbstractCompile() {
+ 
+     [TaskAction]
+     override fun compile() {
+-
+-        getLogger().debug(""Starting Kotlin compilation task"")
+-
+-        val args = K2JVMCompilerArguments()
+-
+-        val javaSrcRoots = HashSet<File>()
+-        val sources = ArrayList<File>()
+-
+-        // collect source directory roots for all java files to allow cross compilation
+-        for (file in getSource()) {
+-            if (FilenameUtils.getExtension(file.getName()).equalsIgnoreCase(""java"")) {
+-                val javaRoot = findSrcDirRoot(file)
+-                if (javaRoot != null) {
+-                    javaSrcRoots.add(javaRoot)
+-                }
+-            } else {
+-                sources.add(file)
+-            }
+-        }
+-
++        getLogger().debug(""Starting ${javaClass} task"")
++        val args = createBlankArgs()
++        val sources = getKotlinSources()
+         if (sources.empty) {
+             getLogger().warn(""No Kotlin files found, skipping Kotlin compiler task"")
+             return
+         }
+ 
++        populateTargetSpecificArgs(args, sources)
++        populateCommonArgs(args, sources)
++        callCompiler(args)
++        afterCompileHook(args)
++    }
++
++    protected fun isJava(it: File): Boolean = FilenameUtils.getExtension(it.getName()).equalsIgnoreCase(""java"")
++
++    private fun getKotlinSources(): ArrayList<File> = getSource()
++            .filterNot { isJava(it) }
++            .toArrayList()
++
++    protected fun populateCommonArgs(args: T, sources: ArrayList<File>) {","should be it private?
+",2014-11-11 17:48:45
+251,"@@ -71,48 +90,72 @@ public open class KotlinCompile(): AbstractCompile() {
+ 
+     [TaskAction]
+     override fun compile() {
+-
+-        getLogger().debug(""Starting Kotlin compilation task"")
+-
+-        val args = K2JVMCompilerArguments()
+-
+-        val javaSrcRoots = HashSet<File>()
+-        val sources = ArrayList<File>()
+-
+-        // collect source directory roots for all java files to allow cross compilation
+-        for (file in getSource()) {
+-            if (FilenameUtils.getExtension(file.getName()).equalsIgnoreCase(""java"")) {
+-                val javaRoot = findSrcDirRoot(file)
+-                if (javaRoot != null) {
+-                    javaSrcRoots.add(javaRoot)
+-                }
+-            } else {
+-                sources.add(file)
+-            }
+-        }
+-
++        getLogger().debug(""Starting ${javaClass} task"")
++        val args = createBlankArgs()
++        val sources = getKotlinSources()
+         if (sources.empty) {
+             getLogger().warn(""No Kotlin files found, skipping Kotlin compiler task"")
+             return
+         }
+ 
++        populateTargetSpecificArgs(args, sources)
++        populateCommonArgs(args, sources)
++        callCompiler(args)
++        afterCompileHook(args)
++    }
++
++    protected fun isJava(it: File): Boolean = FilenameUtils.getExtension(it.getName()).equalsIgnoreCase(""java"")
++
++    private fun getKotlinSources(): ArrayList<File> = getSource()
++            .filterNot { isJava(it) }
++            .toArrayList()
++
++    protected fun populateCommonArgs(args: T, sources: ArrayList<File>) {
++        args.freeArgs = sources.map { it.getAbsolutePath() }
+         args.suppressWarnings = kotlinOptions.suppressWarnings
++        args.verbose = kotlinOptions.verbose
+         args.version = kotlinOptions.version
+-        args.verbose = logger.isDebugEnabled()
++        args.noInline = kotlinOptions.noInline
++    }
+ 
+-        args.freeArgs = sources.map { it.getAbsolutePath() }
++    abstract protected fun populateTargetSpecificArgs(args: T, sources: ArrayList<File>)","looks like we don't need `sources` in `populateTargetSpecificArgs`
+",2014-11-11 17:41:41
+559,"@@ -714,6 +714,43 @@ class StringTest {
+         }
+     }
+ 
++    @test fun occurencesOf() {
++        // Multiple overlapping occurances
++        assertEquals(""abaabaaababac"".occurrencesOf(""abaa"", matchOverlapping = true).toList(), listOf(0, 3))","`expected` value comes first, `actual` value second.
+",2016-05-17 19:17:46
+994,"@@ -73,10 +73,10 @@ object SwitchDemo {
+         val status = """"
+         when (status) {
+             ""init"", ""dial"", ""transmit"" -> return 0x111111
+-            ""ok"" -> return 0xFF006600.toInt()
+-            ""cancel"" -> return 0xFF666666.toInt()
+-            ""fail"", ""busy"", ""error"" -> return 0xFF660000.toInt()
+-            else -> return 0xFF660000.toInt()
++            ""ok"" -> return -16751104","Please, write out these numbers in hex, if input in hex. ",2017-08-16 12:34:22
+32,"@@ -73,6 +73,14 @@ public static ASTNode createColonNode(Project project) {
+         return property.getNode().findChildByType(JetTokens.COLON);
+     }
+ 
++    @NotNull
++    public static PsiElement createSemicolon(Project project) {
++        JetProperty property = createProperty(project, ""val x: Int;"");
++        PsiElement colon = property.findElementAt(10);","Colon variable should be renamed to senilicon
+",2013-02-21 14:22:36
+339,"@@ -75,6 +75,9 @@ public fun ByteArray.toString(charset: String): String = String(this, charset)
+  */
+ public fun ByteArray.toString(charset: Charset): String = String(this, charset)
+ 
++/**
++ * Returnsn an array containing the elements of this collection.","typo ""returnsn""
+",2015-03-12 14:54:06
+993,"@@ -77,13 +78,18 @@ class ControlFlowInstructionsGenerator : ControlFlowBuilderAdapter() {
+         delegateBuilder.enterSubroutine(subroutine)
+     }
+ 
+-    override fun exitSubroutine(subroutine: KtElement): Pseudocode {
+-        super.exitSubroutine(subroutine)
++    override fun exitSubroutine(subroutine: KtElement, invocationKind: InvocationKind?): Pseudocode {
++        super.exitSubroutine(subroutine, invocationKind)
+         delegateBuilder.exitBlockScope(subroutine)
+         val worker = popBuilder()
+         if (!builders.empty()) {
+             val builder = builders.peek()
+-            builder.declareFunction(subroutine, worker.pseudocode)
++
++            if (invocationKind == null) {
++                builder.declareFunction(subroutine, worker.pseudocode)
++            } else {",Formatting,2017-08-16 09:43:12
+49,"@@ -77,6 +77,18 @@ private static void addName(ArrayList<String> result, String name, JetNameValida
+         if (result.isEmpty()) addName(result, ""value"", validator);
+         return ArrayUtil.toStringArray(result);
+     }
++
++    public static String[] suggestNamesForType(JetType jetType, JetNameValidator validator) {
++        ArrayList<String> result = new ArrayList<String>();
++        addNamesForType(result, jetType, validator);
++        return ArrayUtil.toStringArray(result);
++    }
++
++    public static String[] suggestNamesForExpression(JetExpression expression, JetNameValidator validator) {
++        ArrayList<String> result = new ArrayList<String>();
++        addNamesForExpression(result, expression, validator);
++        return ArrayUtil.toStringArray(result);","Why converting this to array? Why not return list?
+",2013-04-26 11:10:15
+291,"@@ -773,7 +773,7 @@ public fun <T> Array<out T>.slice(indices: Iterable<Int>): List<T> {
+ }
+ 
+ /**
+- * Returns a list containing elements at specified positions
++ * Returns a string containing characters at specified positions","copypasta: Array is not a string
+",2015-02-09 15:52:41
+877,"@@ -78,7 +81,7 @@ private fun collectNullCheckExpressions(expression: KtBinaryExpression): Triple<
+ 
+ private fun isNullChecksToSafeCallFixAvailable(expression: KtBinaryExpression): Boolean {
+     val (lte, rte) = collectNullCheckExpressions(expression) ?: return false
+-    return getDuplicates(lte, rte)?.parent as? KtDotQualifiedExpression != null
++    return lte.isChainStable() && getDuplicates(lte, rte)?.parent as? KtDotQualifiedExpression != null",At least one or two tests required here,2017-07-03 12:02:22
+379,"@@ -8,6 +8,7 @@ false
+ for
+ if
+ in
++interface","Why?
+",2015-04-27 10:32:01
+463,"@@ -81,16 +81,11 @@ public abstract class AnnotationProcessorWrapper(
+             return
+         }
+ 
+-        val annotationsFile = processingEnv.getOptions().get(KAPT_ANNOTATION_OPTION)
+-        if (annotationsFile != null) {
+-            try {
+-                kotlinAnnotationsProvider = FileKotlinAnnotationProvider(File(annotationsFile))
+-            }
+-            catch (e: IOException) {
+-                kotlinAnnotationsProvider = EmptyKotlinAnnotationsProvider()
+-            }
+-        }
+-        else kotlinAnnotationsProvider = EmptyKotlinAnnotationsProvider()
++        val annotationsFilePath = processingEnv.getOptions().get(KAPT_ANNOTATION_OPTION)
++        val annotationsFile = if (annotationsFilePath != null) File(annotationsFilePath) else null
++        kotlinAnnotationsProvider = if (annotationsFile != null && annotationsFile.exists()) {
++            FileKotlinAnnotationProvider(annotationsFile)
++        } else EmptyKotlinAnnotationsProvider()","Could you please put `else` on the new line and add `{}` for it? So it would be agreed with our coding conventions.
+",2015-08-31 12:51:52
+973,"@@ -82,7 +89,8 @@ public inline fun <T:Any> checkNotNull(value: T?): T = checkNotNull(value) { ""Re
+  * @sample samples.misc.Preconditions.failCheckWithLazyMessage
+  */
+ @kotlin.internal.InlineOnly
+-public inline fun <T:Any> checkNotNull(value: T?, lazyMessage: () -> Any): T {
++@kotlin.internal.Returns
++public inline fun <T:Any> checkNotNull(@kotlin.internal.Equals(kotlin.internal.ConstantValue.NOT_NULL) value: T?, lazyMessage: () -> Any): T {",Can we annotate also `error` below?,2017-08-15 16:08:34
+836,"@@ -824,6 +824,8 @@
+     DiagnosticFactory0<KtExpression> ALWAYS_NULL = DiagnosticFactory0.create(WARNING);
+ 
+     DiagnosticFactory0<KtNullableType> USELESS_NULLABLE_CHECK = DiagnosticFactory0.create(WARNING, NULLABLE_TYPE);
++    DiagnosticFactory0<KtElement> USELESS_IS_CHECK = DiagnosticFactory0.create(WARNING);
++    DiagnosticFactory0<KtElement> USELESS_IS_NOT_CHECK = DiagnosticFactory0.create(WARNING);","I'd propose to use one diagnostiс: 
+```
+DiagnosticFactory1<KtElement, Boolean> USELESS_IS_CHECK = DiagnosticFactory1.create(WARNING);
+```",2017-05-02 18:34:14
+643,"@@ -83,6 +83,35 @@ object MoveDeclarationsOutHelper {
+         return PsiUtilCore.toPsiElementArray(resultStatements)
+     }
+ 
++    private fun addSymbolAfterDeclaration(container: PsiElement, declaration: KtProperty, isLastStatemnt: Boolean) {","typo: statemnt -> statement
+",2016-10-18 18:48:22
+644,"@@ -83,6 +83,35 @@ object MoveDeclarationsOutHelper {
+         return PsiUtilCore.toPsiElementArray(resultStatements)
+     }
+ 
++    private fun addSymbolAfterDeclaration(container: PsiElement, declaration: KtProperty, isLastStatemnt: Boolean) {
++        if (isLastStatemnt) {
++            container.addAfter(KtPsiFactory(declaration).createEQ(), declaration)
++        }
++        else {
++            container.addAfter(KtPsiFactory(declaration).createNewLine(), declaration)","It should never be necessary to create newlines from text. All newlines should be inserted by the formatter.
+",2016-10-18 18:53:52
+871,"@@ -83,7 +84,9 @@ sealed class ReplCompileResult : Serializable {
+                           val mainClassName: String,
+                           val classes: List<CompiledClassData>,
+                           val hasResult: Boolean,
+-                          val classpathAddendum: List<File>) : ReplCompileResult()
++                          val classpathAddendum: List<File>) : ReplCompileResult() {
++        val type = LastInferredTypeHolder.inferredType.get()","It would be easier to pass the expression type explicitly to `ReplCompileResult.CompiledClasses`'s constructor where it's created at `GenericReplCompiler.compile` with:
+```
+val expression = psiFile.getChildOfType<KtExpression>()
+compilerState.analyzerEngine.trace.bindingContext.getType(expression)
+```
+(+ handle the case when there's no expression in a REPL line)",2017-06-13 14:33:56
+310,"@@ -84,109 +104,113 @@ public fun CharSequence.slice(indices: Iterable<Int>): CharSequence {
+ }
+ 
+ /**
+- * Returns a substring specified by given range
++ * Returns a substring specified by the given [range].
+  */
+ public fun String.substring(range: IntRange): String = substring(range.start, range.end + 1)
+ 
+ /**
+- * Creates a string from all the elements separated using the *separator* and using the given *prefix* and *postfix* if supplied.
+- * If a collection could be huge you can specify a non-negative value of *limit* which will only show a subset of the collection then it will
+- * a special *truncated* separator (which defaults to ""..."")
++ * Creates a string from all the elements separated using [separator] and using the given [prefix] and [postfix] if supplied.
++ * If the collection could be huge, you can specify a non-negative value of [limit], in which case only the first [limit]
++ * elements will be appended, followed by the [truncated] string (which defaults to ""..."").
+  */
+ public fun Iterable<String>.join(separator: String = "", "", prefix: String = """", postfix: String = """", limit: Int = -1, truncated: String = ""...""): String {
+     return joinToString(separator, prefix, postfix, limit, truncated)
+ }
+ 
+ /**
+- * Creates a string from all the elements separated using the *separator* and using the given *prefix* and *postfix* if supplied.
+- * If an array could be huge you can specify a non-negative value of *limit* which will only show a subset of the array then it will
+- * a special *truncated* separator (which defaults to ""..."")
++ * Creates a string from all the elements separated using [separator] and using the given [prefix] and [postfix] if supplied.
++ * If the array could be huge, you can specify a non-negative value of [limit], in which case only the first [limit]
++ * elements will be appended, followed by the [truncated] string (which defaults to ""..."").
+  */
+ public fun Array<String>.join(separator: String = "", "", prefix: String = """", postfix: String = """", limit: Int = -1, truncated: String = ""...""): String {
+     return joinToString(separator, prefix, postfix, limit, truncated)
+ }
+ 
+ /**
+- * Creates a string from all the elements separated using the *separator* and using the given *prefix* and *postfix* if supplied.
+- * If a stream could be huge you can specify a non-negative value of *limit* which will only show a subset of the stream then it will
+- * a special *truncated* separator (which defaults to ""..."")
++ * Creates a string from all the elements separated using [separator] and using the given [prefix] and [postfix] if supplied.
++ * If the stream could be huge, you can specify a non-negative value of [limit], in which case only the first [limit]
++ * elements will be appended, followed by the [truncated] string (which defaults to ""..."").
+  */
+ public fun Stream<String>.join(separator: String = "", "", prefix: String = """", postfix: String = """", limit: Int = -1, truncated: String = ""...""): String {
+     return joinToString(separator, prefix, postfix, limit, truncated)
+ }
++
+ /**
+- * Returns a substring before first occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring before the first occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringBefore(delimiter: Char, missingSeparatorValue : String = this): String {
++public fun String.substringBefore(delimiter: Char, missingDelimiterValue: String = this): String {
+     val index = indexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(0, index)
++    return if (index == -1) missingDelimiterValue else substring(0, index)
+ }
+ 
+ /**
+- * Returns a substring before first occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring before the first occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringBefore(delimiter: String, missingSeparatorValue : String = this): String {
++public fun String.substringBefore(delimiter: String, missingDelimiterValue: String = this): String {
+     val index = indexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(0, index)
++    return if (index == -1) missingDelimiterValue else substring(0, index)
+ }
++
+ /**
+- * Returns a substring after first occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring after the first occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringAfter(delimiter: Char, missingSeparatorValue : String = this): String {
++public fun String.substringAfter(delimiter: Char, missingDelimiterValue: String = this): String {
+     val index = indexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(index + 1, length)
++    return if (index == -1) missingDelimiterValue else substring(index + 1, length)
+ }
+ 
+ /**
+- * Returns a substring after first occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring after the first occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringAfter(delimiter: String, missingSeparatorValue : String = this): String {
++public fun String.substringAfter(delimiter: String, missingDelimiterValue: String = this): String {
+     val index = indexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(index + delimiter.length, length)
++    return if (index == -1) missingDelimiterValue else substring(index + delimiter.length, length)
+ }
+ 
+ /**
+- * Returns a substring before last occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring before the last occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringBeforeLast(delimiter: Char, missingSeparatorValue : String = this): String {
++public fun String.substringBeforeLast(delimiter: Char, missingDelimiterValue: String = this): String {
+     val index = lastIndexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(0, index)
++    return if (index == -1) missingDelimiterValue else substring(0, index)
+ }
+ 
+ /**
+- * Returns a substring before last occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring before the last occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringBeforeLast(delimiter: String, missingSeparatorValue : String = this): String {
++public fun String.substringBeforeLast(delimiter: String, missingDelimiterValue: String = this): String {
+     val index = lastIndexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(0, index)
++    return if (index == -1) missingDelimiterValue else substring(0, index)
+ }
+ 
+ /**
+- * Returns a substring after last occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring after the last occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringAfterLast(delimiter: Char, missingSeparatorValue : String = this): String {
++public fun String.substringAfterLast(delimiter: Char, missingDelimiterValue: String = this): String {
+     val index = lastIndexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(index + 1, length)
++    return if (index == -1) missingDelimiterValue else substring(index + 1, length)
+ }
+ 
+ /**
+- * Returns a substring after last occurrence of delimiter.
+- * In case of no delimiter, returns the value of missingSeparatorValue which defaults to original string.
++ * Returns a substring after the last occurrence of [delimiter].
++ * If the string does not contain the delimiter, returns [missingDelimiterValue] which defaults to the original string.
+  */
+-public fun String.substringAfterLast(delimiter: String, missingSeparatorValue : String = this): String {
++public fun String.substringAfterLast(delimiter: String, missingDelimiterValue: String = this): String {
+     val index = lastIndexOf(delimiter)
+-    return if (index == -1) missingSeparatorValue else substring(index + delimiter.length, length)
++    return if (index == -1) missingDelimiterValue else substring(index + delimiter.length, length)
+ }
+ 
+ /**
+- * Replace part of string at given range with replacement string
++ * Replace the part of string at given the range with the [replacement] string.","""Replaces"", ""of the string""
+",2015-02-09 16:20:50
+608,"@@ -85,30 +87,73 @@ class KotlinShortNamesCache(private val project: Project) : PsiShortNamesCache()
+         dest.addAll(allClassNames)
+     }
+ 
+-    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod>
+-            = emptyArray()
++    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod> {
++        return getMethodSequenceByName(name, scope).toList().toTypedArray()
++    }
++
++    fun getMethodSequenceByName(name: String, scope: GlobalSearchScope): Sequence<PsiMethod> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
++
++        val kotlinFunctionsPsi = functionIndex.get(name, project, scope).asSequence()
++                .flatMap { LightClassUtil.getLightClassMethods(it).asSequence() }
++                .filter { it.name == name }
++
++        val propertyAccessorsPsi = getPropertyNamesCandidatesByAccessorName(Name.identifier(name)).asSequence()
++                .flatMap { propertiesIndex.get(it.asString(), project, scope).asSequence() }
++                .flatMap { LightClassUtil.getLightClassPropertyMethods(it).allDeclarations.asSequence() }
++                .filter { it.name == name }
++                .map { it as? PsiMethod }
+ 
+-    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod>
+-            = emptyArray()
++        return (propertyAccessorsPsi + kotlinFunctionsPsi).filterNotNull()","This accesses the property index even if it's not actually necessary (if the sequence enumeration stops before we reach the property names). Would be nice to use something like `sequenceOfLazyValues().flatMap` to avoid this.
+",2016-09-19 15:22:32
+609,"@@ -85,30 +87,73 @@ class KotlinShortNamesCache(private val project: Project) : PsiShortNamesCache()
+         dest.addAll(allClassNames)
+     }
+ 
+-    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod>
+-            = emptyArray()
++    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod> {
++        return getMethodSequenceByName(name, scope).toList().toTypedArray()
++    }
++
++    fun getMethodSequenceByName(name: String, scope: GlobalSearchScope): Sequence<PsiMethod> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
++
++        val kotlinFunctionsPsi = functionIndex.get(name, project, scope).asSequence()
++                .flatMap { LightClassUtil.getLightClassMethods(it).asSequence() }
++                .filter { it.name == name }
++
++        val propertyAccessorsPsi = getPropertyNamesCandidatesByAccessorName(Name.identifier(name)).asSequence()
++                .flatMap { propertiesIndex.get(it.asString(), project, scope).asSequence() }
++                .flatMap { LightClassUtil.getLightClassPropertyMethods(it).allDeclarations.asSequence() }
++                .filter { it.name == name }
++                .map { it as? PsiMethod }
+ 
+-    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod>
+-            = emptyArray()
++        return (propertyAccessorsPsi + kotlinFunctionsPsi).filterNotNull()
++    }
++
++    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod> {
++        val psiMethods = getMethodSequenceByName(name, scope)
++        val limitedByMaxCount = psiMethods.take(maxCount)
++        psiMethods.drop(maxCount).firstOrNull()?.let { return PsiMethod.EMPTY_ARRAY }","You can avoid repeated iteration of the sequence if you use `take(maxCount+1)` and check if you actually got N+1 elements.
+",2016-09-19 15:24:10
+600,"@@ -85,30 +87,78 @@ class KotlinShortNamesCache(private val project: Project) : PsiShortNamesCache()
+         dest.addAll(allClassNames)
+     }
+ 
+-    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod>
+-            = emptyArray()
++    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
+ 
+-    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod>
+-            = emptyArray()
++        val kotlinFunctionsPsi = functionIndex.get(name, project, scope)
++                .flatMap { LightClassUtil.getLightClassMethods(it) }
+ 
+-    override fun getFieldsByNameIfNotMoreThan(s: String, scope: GlobalSearchScope, i: Int): Array<PsiField>
+-            = emptyArray()
++        val propertyAccessorsPsi = getPropertyNamesCandidatesByAccessorName(Name.identifier(name))
++                .flatMap { propertiesIndex.get(it.asString(), project, scope) }
++                .flatMap { LightClassUtil.getLightClassPropertyMethods(it).allDeclarations }
++                .filter { it.name == name }
++                .map { it as? PsiMethod }
++
++        return (propertyAccessorsPsi + kotlinFunctionsPsi).filterNotNull().toList().toTypedArray()
++    }
++
++    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod> {
++        val methods = getMethodsByName(name, scope)
++        if (methods.size > maxCount)","This implementation defeats the purpose of this method. You should calculate the candidates lazily and stop evaluating if you've found more than `maxCount` candidates.
+",2016-09-05 17:33:47
+601,"@@ -85,30 +87,78 @@ class KotlinShortNamesCache(private val project: Project) : PsiShortNamesCache()
+         dest.addAll(allClassNames)
+     }
+ 
+-    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod>
+-            = emptyArray()
++    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
+ 
+-    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod>
+-            = emptyArray()
++        val kotlinFunctionsPsi = functionIndex.get(name, project, scope)
++                .flatMap { LightClassUtil.getLightClassMethods(it) }
+ 
+-    override fun getFieldsByNameIfNotMoreThan(s: String, scope: GlobalSearchScope, i: Int): Array<PsiField>
+-            = emptyArray()
++        val propertyAccessorsPsi = getPropertyNamesCandidatesByAccessorName(Name.identifier(name))
++                .flatMap { propertiesIndex.get(it.asString(), project, scope) }
++                .flatMap { LightClassUtil.getLightClassPropertyMethods(it).allDeclarations }
++                .filter { it.name == name }
++                .map { it as? PsiMethod }
++
++        return (propertyAccessorsPsi + kotlinFunctionsPsi).filterNotNull().toList().toTypedArray()
++    }
++
++    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod> {
++        val methods = getMethodsByName(name, scope)
++        if (methods.size > maxCount)
++            return PsiMethod.EMPTY_ARRAY
++        return methods
++    }
++
++    override fun getFieldsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiField> {
++        val fields = getFieldsByName(name, scope)
++        if (fields.size > maxCount)
++            return PsiField.EMPTY_ARRAY
++        return fields
++    }
+ 
+     override fun processMethodsWithName(name: String, scope: GlobalSearchScope, processor: Processor<PsiMethod>): Boolean
+             = ContainerUtil.process(getMethodsByName(name, scope), processor)
+ 
+-    override fun getAllMethodNames(): Array<String>
+-            = emptyArray()
++    override fun getAllMethodNames(): Array<String> {
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
++        val functionNames = functionIndex.getAllKeys(project)
++
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val globalScope = GlobalSearchScope.allScope(project)
++        val propertyAccessorNames = propertiesIndex.getAllKeys(project)
++                .flatMap { propertiesIndex.get(it, project, globalScope) }","This will be extremely slow. It's OK to return names for which `getMethodsByName()` will then not find any methods, but it's not OK to look up every single method in the index. You should only use `getAllKeys()` and then calculate possible accessor names from those, without any lookups to the property index.
+",2016-09-05 17:35:10
+602,"@@ -85,30 +87,78 @@ class KotlinShortNamesCache(private val project: Project) : PsiShortNamesCache()
+         dest.addAll(allClassNames)
+     }
+ 
+-    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod>
+-            = emptyArray()
++    override fun getMethodsByName(name: String, scope: GlobalSearchScope): Array<PsiMethod> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
+ 
+-    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod>
+-            = emptyArray()
++        val kotlinFunctionsPsi = functionIndex.get(name, project, scope)
++                .flatMap { LightClassUtil.getLightClassMethods(it) }
+ 
+-    override fun getFieldsByNameIfNotMoreThan(s: String, scope: GlobalSearchScope, i: Int): Array<PsiField>
+-            = emptyArray()
++        val propertyAccessorsPsi = getPropertyNamesCandidatesByAccessorName(Name.identifier(name))
++                .flatMap { propertiesIndex.get(it.asString(), project, scope) }
++                .flatMap { LightClassUtil.getLightClassPropertyMethods(it).allDeclarations }
++                .filter { it.name == name }
++                .map { it as? PsiMethod }
++
++        return (propertyAccessorsPsi + kotlinFunctionsPsi).filterNotNull().toList().toTypedArray()
++    }
++
++    override fun getMethodsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiMethod> {
++        val methods = getMethodsByName(name, scope)
++        if (methods.size > maxCount)
++            return PsiMethod.EMPTY_ARRAY
++        return methods
++    }
++
++    override fun getFieldsByNameIfNotMoreThan(name: String, scope: GlobalSearchScope, maxCount: Int): Array<PsiField> {
++        val fields = getFieldsByName(name, scope)
++        if (fields.size > maxCount)
++            return PsiField.EMPTY_ARRAY
++        return fields
++    }
+ 
+     override fun processMethodsWithName(name: String, scope: GlobalSearchScope, processor: Processor<PsiMethod>): Boolean
+             = ContainerUtil.process(getMethodsByName(name, scope), processor)
+ 
+-    override fun getAllMethodNames(): Array<String>
+-            = emptyArray()
++    override fun getAllMethodNames(): Array<String> {
++        val functionIndex = KotlinFunctionShortNameIndex.getInstance()
++        val functionNames = functionIndex.getAllKeys(project)
++
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val globalScope = GlobalSearchScope.allScope(project)
++        val propertyAccessorNames = propertiesIndex.getAllKeys(project)
++                .flatMap { propertiesIndex.get(it, project, globalScope) }
++                .flatMap { it.getAccessorNames() }
++
++        return (functionNames + propertyAccessorNames).toTypedArray()
++    }
+ 
+     override fun getAllMethodNames(set: HashSet<String>) {
++        set.addAll(allMethodNames)
++    }
++
++    override fun getFieldsByName(name: String, scope: GlobalSearchScope): Array<PsiField> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++
++        return propertiesIndex.get(name, project, scope)
++                .map { LightClassUtil.getLightClassBackingField(it) }
++                .filterNotNull()
++                .toTypedArray()
+     }
+ 
+-    override fun getFieldsByName(name: String, scope: GlobalSearchScope): Array<PsiField>
+-            = emptyArray()
++    override fun getAllFieldNames(): Array<String> {
++        val propertiesIndex = KotlinPropertyShortNameIndex.getInstance()
++        val globalScope = GlobalSearchScope.allScope(project)
+ 
+-    override fun getAllFieldNames(): Array<String>
+-            = emptyArray()
++        return propertiesIndex.getAllKeys(project)
++                .flatMap { propertiesIndex.get(it, project, globalScope) }","Same here. No property index lookups please.
+",2016-09-05 17:36:15
+521,"@@ -854,4 +854,38 @@ class CollectionTest {
+         // we need toString() inside pattern because of KT-8666
+         assertEquals(""[1, a, null, ${Long.MAX_VALUE.toString()}]"", listOf(1, ""a"", null, Long.MAX_VALUE).toString())
+     }
++
++    @test fun testGetRange() {
++        val listStr = listOf(""a"", ""b"", ""c"", ""d"", ""e"")
++
++        assertTrue(throwsError{listStr[-1..2]})
++        assertTrue(throwsError{listStr[1..10]})
++
++        assertTrue(listStr[1..3] == listOf(""b"", ""c"", ""d""))
++        assertTrue(listStr[1..3] is List<String>)
++        assertTrue(listStr[1..3][0..1] == listOf(""b"", ""c""))
++        assertTrue(listStr[1..3][0..1] is List<String>)
++        assertTrue(listStr[1..3][0..1][0] is String)
++        assertTrue(listStr[1..3][0..1][0] == ""b"")
++
++        assertTrue(listStr[1..1] == listOf(listStr[1]))
++        assertTrue(listStr[3..1] == listOf<String>())
++    }
++
++    fun throwsError(f :()->Unit): Boolean {
++        try{
++            f()
++        } catch(e: Exception){
++            return true
++        }
++        return false
++    }
++
++    @test fun testListTimes(){
++        val shortlistStr = listOf(""a"", ""b"")
++        assertTrue(shortlistStr*0 == listOf<String>())","`assertEquals(expected, actual)` is preferred as it dumps diff on failure
+",2016-02-27 13:54:32
+523,"@@ -854,4 +854,41 @@ class CollectionTest {
+         // we need toString() inside pattern because of KT-8666
+         assertEquals(""[1, a, null, ${Long.MAX_VALUE.toString()}]"", listOf(1, ""a"", null, Long.MAX_VALUE).toString())
+     }
++
++    @test fun testGetRange() {
++        val listStr = listOf(""a"", ""b"", ""c"", ""d"", ""e"")","I believe we also need tests on an empty list: should fail at any range but empty range on empty list should produce empty list 
+",2016-02-27 17:22:10
+522,"@@ -854,4 +854,41 @@ class CollectionTest {
+         // we need toString() inside pattern because of KT-8666
+         assertEquals(""[1, a, null, ${Long.MAX_VALUE.toString()}]"", listOf(1, ""a"", null, Long.MAX_VALUE).toString())
+     }
++
++    @test fun testGetRange() {
++        val listStr = listOf(""a"", ""b"", ""c"", ""d"", ""e"")
++
++        assertTrue(throwsError{listStr[-1..2]})
++        assertTrue(throwsError{listStr[1..10]})
++
++        assertEquals(listStr[IntRange.EMPTY], listOf<String>())","I should be expected value at the first place, the second argument is actual, swap these arguments please
+",2016-02-27 17:20:29
+427,"@@ -86,6 +86,8 @@
+         <include name=""compiler/builtins-serializer/src""/>
+         <include name=""compiler/cli/src""/>
+         <include name=""compiler/cli/cli-common/src""/>
++        <include name=""compiler/rmi/rmi-server/src""/>
++        <include name=""compiler/rmi/rmi-interface/src""/>","There's another fileset which is used in the `compiler-quick` target and declared just below, please also add these modules there.
+
+Also please add them to `compiler-sources`.
+",2015-08-22 02:20:42
+401,"@@ -86,7 +86,8 @@ protected void configureSpecificCompilerArguments(@NotNull K2JSCompilerArguments
+             collector.add(new File(outputFile).getParent());
+         }
+         if (metaInfo) {
+-            String metaFile = KotlinPackage.substringBeforeLast(outputFile, JavaScript.DOT_EXTENSION, outputFile) + KotlinJavascriptMetadataUtils.META_JS_SUFFIX;
++            String output = com.google.common.base.Objects.firstNonNull(outputFile, """"); // fqname here because of J8 compatibility issues","Is it not possible with Kotlin stdlib?
+",2015-07-27 19:30:49
+996,"@@ -867,7 +912,8 @@ class DefaultExpressionConverter : JavaElementVisitor(), ExpressionConverter {
+                 if (parameters.size == 1 && !isKotlinFunctionType) {
+                     // for lambdas all parameters with types should be present
+                     emptyList()
+-                } else {
++                }
++                else {",Please restore previous code formatting - actual `if-else` statements and spaces are against accepted conceptions.,2017-08-16 16:24:17
+384,"@@ -87,15 +87,24 @@ public boolean execute() throws BuildException {
+ 
+         kotlinc.getAdditionalArguments().addAll(additionalArguments);
+ 
+-        kotlinc.execute();
+-        if (!Integer.valueOf(0).equals(kotlinc.getExitCode())) {
+-            // Don't run javac if failOnError = false and there were errors on Kotlin sources
+-            return false;
++        // Javac13#execute passes everything in compileList to javac, which doesn't recognize .kt files
++        File[] compileListForJavac = filterOutKotlinSources(compileList);
++
++        boolean hasKotlinFilesInSources = compileListForJavac.length < compileList.length;
++
++        if (hasKotlinFilesInSources) {
++            kotlinc.execute();
++            if (!Integer.valueOf(0).equals(kotlinc.getExitCode())) {
++                // Don't run javac if failOnError = false and there were errors on Kotlin sources
++                return false;
++            }
++        }
++        else {
++            kotlinc.fillArguments();","what for this?
+",2015-06-11 10:28:18
+383,"@@ -87,15 +87,24 @@ public boolean execute() throws BuildException {
+ 
+         kotlinc.getAdditionalArguments().addAll(additionalArguments);
+ 
+-        kotlinc.execute();
+-        if (!Integer.valueOf(0).equals(kotlinc.getExitCode())) {
+-            // Don't run javac if failOnError = false and there were errors on Kotlin sources
+-            return false;
++        // Javac13#execute passes everything in compileList to javac, which doesn't recognize .kt files
++        File[] compileListForJavac = filterOutKotlinSources(compileList);
++
++        boolean hasKotlinFilesInSources = compileListForJavac.length < compileList.length;
++
++        if (hasKotlinFilesInSources) {
++            kotlinc.execute();
++            if (!Integer.valueOf(0).equals(kotlinc.getExitCode())) {
++                // Don't run javac if failOnError = false and there were errors on Kotlin sources
++                return false;
++            }
++        }
++        else {
++            kotlinc.fillArguments();
+         }
+ 
+         javac.log(""Running javac..."");
+ 
+-        // Javac13#execute passes everything in compileList to javac, which doesn't recognize .kt files
+         compileList = filterOutKotlinSources(compileList);","why do you filter it twice?
+",2015-06-11 10:26:09
+679,"@@ -88,8 +85,10 @@ class ConvertFunctionToPropertyIntention : SelfTargetingIntention<KtNamedFunctio
+             function.setName(newName)
+ 
+             val property = originalFunction.replace(psiFactory.createProperty(function.text)) as KtProperty
+-            if (needsExplicitType) {
+-                elementsToShorten.add(property.typeReference!!)
++
++            if (!hasExplicitType) {
++                val linebreak = property.getter?.node?.treePrev","Ouch. This should be handled by a formatter rule, not by AST manipulations.",2017-01-09 11:16:04
+313,"@@ -9,11 +9,11 @@ import java.io.Serializable
+  * Pair exhibits value semantics, i.e. two pairs are equal if both components are equal.
+  *
+  * An example of decomposing it into values:
+- * ${code test.tuples.PairTest.pairMultiAssignment}
++ * @sample test.tuples.PairTest.pairMultiAssignment
+  *
+- * $constructor: Creates new instance of [Pair]
+- * $first: First value
+- * $second: Second value
++ * @param first First value","Missing @param for type parameters.
+",2015-02-09 16:25:50
+377,"@@ -9,7 +9,7 @@ internal trait One {
+ }
+ 
+ internal trait OneImpl : One {
+-    invisible_fake open override /*1*/ /*fake_override*/ fun boo(): kotlin.Int
++    invisible_fake final override /*1*/ /*fake_override*/ fun boo(): kotlin.Int","I suspect that this may lead to some unexpected errors in subclasses
+",2015-04-20 15:45:51
+142,"@@ -9,8 +9,9 @@ import kotlin.test.assertTrue
+ import kotlin.test.assertEquals
+ import kotlin.test.fail
+ 
+-open class BaseGradleIT {
++open class BaseGradleIT(val resourcesRoot: String = ""src/test/resources"") {","There is no need to make resourcesRoot a property: you can remove val keyword to make it a constructor parameter
+",2014-03-24 09:59:47
+143,"@@ -9,8 +9,9 @@ import kotlin.test.assertTrue
+ import kotlin.test.assertEquals
+ import kotlin.test.fail
+ 
+-open class BaseGradleIT {
++open class BaseGradleIT(val resourcesRoot: String = ""src/test/resources"") {
+ 
++    val resourcesRootFile: File = File(resourcesRoot)","You can avoid specifying type for this property: it can be inferred automatically from the initializer. Also it is better to add a private modifier for properties that are used only in this class
+",2014-03-24 10:04:00
+264,"@@ -91,3 +205,18 @@ public fun File.listFiles(filter: (file: File) -> Boolean): Array<File>? = listF
+             override fun accept(file: File) = filter(file)
+         }
+                                                                                     )
++
++/**
++ * Returns true if the file is a directory and contains a child file with a given name. Otherwise false is returned.
++ */
++public fun File.contains(name: String): Boolean {","Name of the function is not very good. First, it can be perceived if ""path"" contains ""name"", not contents of the folder. Second, it will fit ""in"" by convention, and while `if (""build.gradle"" in folder)` looks nice, for the overload with predicate it is a little bit strange. Consider using a different name.
+",2014-11-26 14:56:02
+951,"@@ -92,6 +95,14 @@ fun KtLambdaArgument.moveInsideParenthesesAndReplaceWith(
+     return oldCallExpression.replace(newCallExpression) as KtCallExpression
+ }
+ 
++private fun shouldLambdaParameterNamed(args: List<ValueArgument>, callExpr: KtCallExpression): Boolean {
++    return args.any { it.isNamed() } ||","Now that it's a separate function, there's no need to cramp it all into a single expression.
+
+```
+if (args.any { it.isNamed () }) return true
+val callee = ...resolve as? KtFunction ?: return true
+return callee.valueParameters.any { ... }
+```
+
+Also the grammatically correct name would be `shouldLambdaParameterBeNamed`.",2017-08-04 13:44:39
+544,"@@ -95,6 +95,48 @@ class CollectionTest {
+         }
+     }
+ 
++    @test fun filterIsInstanceList() {
++        val values: List<Any> = listOf(1, 2, 3.0, ""abc"", ""cde"")
++
++        val numberValues: List<Number> = values.filterIsInstance<Number>()
++        assertEquals(listOf(1, 2, 3.0), numberValues)
++
++        // doesn't distinguish double from int in JS
++//        val doubleValues: List<Double> = values.filterIsInstance<Double>()
++//        assertEquals(listOf(3.0), doubleValues)
++
++        val stringValues: List<String> = values.filterIsInstance<String>()
++        assertEquals(listOf(""abc"", ""cde""), stringValues)
++
++        // is Any doesn't work in JS
++//        val anyValues: List<Any> = values.filterIsInstance<Any>()","ok, could be mentioned
+",2016-04-25 23:33:53
+868,"@@ -96,6 +97,9 @@ class RecursivePropertyAccessorInspection : AbstractKotlinInspection() {
+             val bindingContext = element.analyze()
+             val target = bindingContext[REFERENCE_TARGET, element]",y :-*,2017-06-04 11:54:12
+869,"@@ -96,6 +97,9 @@ class RecursivePropertyAccessorInspection : AbstractKotlinInspection() {
+             val bindingContext = element.analyze()
+             val target = bindingContext[REFERENCE_TARGET, element]
+             if (target != bindingContext[BindingContext.DECLARATION_TO_DESCRIPTOR, propertyAccessor.property]) return false
++            (element.parent as? KtDotQualifiedExpression)?.let {
++                if (it.receiverExpression.text != KtTokens.THIS_KEYWORD.value && !it.isCompanionObjectReceiver(bindingContext)) return false
++            }
+             return isSameAccessor(element, propertyAccessor.isGetter)",sufjfubi,2017-06-04 11:54:22
+24,"@@ -96,7 +96,10 @@ public boolean accept(File pathname) {
+             List<File> subdirs = Arrays.asList(files);
+             Collections.sort(subdirs);
+             for (File subdir : subdirs) {
+-                suite.addTest(suiteForDirectory(baseDataDir, dataPath + ""/"" + subdir.getName(), recursive, filter, factory));","This change must sit in a separate commit, as it has no relation to the problem being solved by this one
+",2013-01-29 14:00:10
+593,"@@ -97,12 +97,28 @@ class KotlinFoldingBuilder : CustomFoldingBuilder(), DumbAware {
+     }
+ 
+     override fun getLanguagePlaceholderText(node: ASTNode, range: TextRange): String = when {
+-        node.elementType == KtTokens.BLOCK_COMMENT -> ""/.../""
+-        node.elementType == KDocTokens.KDOC -> ""/**...*/""
++        node.elementType == KtTokens.BLOCK_COMMENT -> ""/${getFirstLineOfComment(node)}.../""
++        node.elementType == KDocTokens.KDOC -> ""/**${getFirstLineOfComment(node)}...*/""
+         node.psi is KtImportList -> ""...""
+         else ->  ""{...}""
+     }
+ 
++    private fun getFirstLineOfComment(node: ASTNode): String {
++        val targetCommentLine = node.text.split(""\n"").firstOrNull {
++            getCommentContents(it).isNotEmpty()
++        } ?: return """"
++        return getCommentContents(targetCommentLine)
++    }
++
++    private fun getCommentContents(line: String): String {
++        val comment = KotlinCommenter()","There is no need to create a new object here; it's OK to hard-code the token texts.
+",2016-08-19 16:20:42
+594,"@@ -97,12 +97,28 @@ class KotlinFoldingBuilder : CustomFoldingBuilder(), DumbAware {
+     }
+ 
+     override fun getLanguagePlaceholderText(node: ASTNode, range: TextRange): String = when {
+-        node.elementType == KtTokens.BLOCK_COMMENT -> ""/.../""
+-        node.elementType == KDocTokens.KDOC -> ""/**...*/""
++        node.elementType == KtTokens.BLOCK_COMMENT -> ""/${getFirstLineOfComment(node)}.../""
++        node.elementType == KDocTokens.KDOC -> ""/**${getFirstLineOfComment(node)}...*/""
+         node.psi is KtImportList -> ""...""
+         else ->  ""{...}""
+     }
+ 
++    private fun getFirstLineOfComment(node: ASTNode): String {
++        val targetCommentLine = node.text.split(""\n"").firstOrNull {
++            getCommentContents(it).isNotEmpty()
++        } ?: return """"
++        return getCommentContents(targetCommentLine)
++    }
++
++    private fun getCommentContents(line: String): String {
++        val comment = KotlinCommenter()
++        return line.trim()
++                .replace(comment.documentationCommentPrefix!!, """")
++                .replace(comment.blockCommentPrefix!!, """")
++                .replace(comment.blockCommentSuffix!!, """")
++                .replace(comment.documentationCommentLinePrefix!!, """")","Please make sure that the line has at most one leading and at most one trailing space after you've remove the prefix and suffix
+",2016-08-19 16:21:18
+499,"@@ -97,3 +96,24 @@ inline fun AbstractInsnNode.findPreviousOrNull(predicate: (AbstractInsnNode) ->
+ 
+ fun AbstractInsnNode.hasOpcode(): Boolean =
+         getOpcode() >= 0
++
++//   See InstructionAdapter
++//
++//   public void iconst(final int cst) {
++//       if (cst >= -1 && cst <= 5) {
++//           mv.visitInsn(Opcodes.ICONST_0 + cst);
++//       } else if (cst >= Byte.MIN_VALUE && cst <= Byte.MAX_VALUE) {
++//           mv.visitIntInsn(Opcodes.BIPUSH, cst);
++//       } else if (cst >= Short.MIN_VALUE && cst <= Short.MAX_VALUE) {
++//           mv.visitIntInsn(Opcodes.SIPUSH, cst);
++//       } else {
++//           mv.visitLdcInsn(new Integer(cst));
++//       }
++//   }
++val AbstractInsnNode.intConstant: Int? get() =
++    when (opcode) {
++        in ICONST_0..ICONST_5 -> opcode - ICONST_0","What about `ICONST_M1`?
+",2015-12-28 14:54:59
+498,"@@ -97,3 +96,24 @@ inline fun AbstractInsnNode.findPreviousOrNull(predicate: (AbstractInsnNode) ->
+ 
+ fun AbstractInsnNode.hasOpcode(): Boolean =
+         getOpcode() >= 0
++
++//   See InstructionAdapter
++//
++//   public void iconst(final int cst) {
++//       if (cst >= -1 && cst <= 5) {
++//           mv.visitInsn(Opcodes.ICONST_0 + cst);
++//       } else if (cst >= Byte.MIN_VALUE && cst <= Byte.MAX_VALUE) {
++//           mv.visitIntInsn(Opcodes.BIPUSH, cst);
++//       } else if (cst >= Short.MIN_VALUE && cst <= Short.MAX_VALUE) {
++//           mv.visitIntInsn(Opcodes.SIPUSH, cst);
++//       } else {
++//           mv.visitLdcInsn(new Integer(cst));
++//       }
++//   }
++val AbstractInsnNode.intConstant: Int? get() =
++    when (opcode) {
++        in ICONST_0..ICONST_5 -> opcode - ICONST_0
++        BIPUSH, SIPUSH -> (this as IntInsnNode).operand
++        LDC -> (this as LdcInsnNode).cst as? Int?","`as? Int` should work I think
+",2015-12-28 14:54:41
+874,"@@ -97,7 +98,15 @@ fun KotlinType.isResolvableInScope(scope: LexicalScope?, checkTypeParameters: Bo
+ 
+     val descriptor = constructor.declarationDescriptor
+     if (descriptor == null || descriptor.name.isSpecial) return false
+-    if (!checkTypeParameters && descriptor is TypeParameterDescriptor) return true
++
++    if (descriptor is TypeParameterDescriptor) {
++        if (checkTypeParameters) {
++            val owner = descriptor.containingDeclaration
++            if (owner is FunctionDescriptor && owner.typeParameters.any { it == descriptor }) return true",any { it == descriptor } is equivalent to just contains(descriptor),2017-06-26 14:20:03
+875,"@@ -97,7 +98,15 @@ fun KotlinType.isResolvableInScope(scope: LexicalScope?, checkTypeParameters: Bo
+ 
+     val descriptor = constructor.declarationDescriptor
+     if (descriptor == null || descriptor.name.isSpecial) return false
+-    if (!checkTypeParameters && descriptor is TypeParameterDescriptor) return true
++
++    if (descriptor is TypeParameterDescriptor) {
++        if (checkTypeParameters) {
++            val owner = descriptor.containingDeclaration
++            if (owner is FunctionDescriptor && owner.typeParameters.any { it == descriptor }) return true
++        } else {","FYI: in Kotlin project if...else is formatted in a different way:
+```
+if () {
+}
+else {
+}
+```",2017-06-26 14:20:37
+287,"@@ -988,7 +988,7 @@ public inline fun <T> Stream<T>.firstOrNull(predicate: (T) -> Boolean): T? {
+ }
+ 
+ /**
+- * Returns first element matching the given *predicate*, or *null* if element was not found
++ * Returns first character matching the given [predicate], or *null* if character was not found","May be replace _null_ with `null`?
+",2015-02-09 15:47:09
+597,"@@ -99,10 +100,18 @@ class KotlinFoldingBuilder : CustomFoldingBuilder(), DumbAware {
+     override fun getLanguagePlaceholderText(node: ASTNode, range: TextRange): String = when {
+         node.elementType == KtTokens.BLOCK_COMMENT -> ""/${getFirstLineOfComment(node)}.../""
+         node.elementType == KDocTokens.KDOC -> ""/**${getFirstLineOfComment(node)}...*/""
++        node.elementType == KtNodeTypes.STRING_TEMPLATE -> ""\""\""\""${getFirstLineOfString(node)}...\""\""\""""
+         node.psi is KtImportList -> ""...""
+         else ->  ""{...}""
+     }
+ 
++    private fun getFirstLineOfString(node: ASTNode): String {
++        val targetStringLine = node.text.split(""\n"").firstOrNull {","You can avoid multiple `replace` calls if you use `asSequence().map { it.replace(...) }.firstOrNull { it.isNotBlank }`
+",2016-08-29 11:06:06
+598,"@@ -99,10 +100,18 @@ class KotlinFoldingBuilder : CustomFoldingBuilder(), DumbAware {
+     override fun getLanguagePlaceholderText(node: ASTNode, range: TextRange): String = when {
+         node.elementType == KtTokens.BLOCK_COMMENT -> ""/${getFirstLineOfComment(node)}.../""
+         node.elementType == KDocTokens.KDOC -> ""/**${getFirstLineOfComment(node)}...*/""
++        node.elementType == KtNodeTypes.STRING_TEMPLATE -> ""\""\""\""${getFirstLineOfString(node)}...\""\""\""""
+         node.psi is KtImportList -> ""...""
+         else ->  ""{...}""
+     }
+ 
++    private fun getFirstLineOfString(node: ASTNode): String {
++        val targetStringLine = node.text.split(""\n"").firstOrNull {
++            it.replace(""\""\""\"""", """").isNotBlank()
++        } ?: return """"
++        return "" ${targetStringLine.replace(""\""\""\"""", """").trim()} ""","It's better to add surrounding spaces in `getLanguagePlaceholderText()`, not in this function. (This applies also to `getFirstLineOfComment()`.)
+",2016-08-29 11:06:55
diff --git a/data/microsoft_vscode_1000.csv b/data/microsoft_vscode_1000.csv
new file mode 100644
index 0000000..de5e1b6
--- /dev/null
+++ b/data/microsoft_vscode_1000.csv
@@ -0,0 +1,24091 @@
+,diff_hunk,human_review,created_at
+422,"@@ -0,0 +1 @@
++<svg xmlns=""http://www.w3.org/2000/svg"" width=""16"" height=""16""><path d=""M13.451 5.609l-.579-.939-1.068.812-.076.094c-.335.415-.927 1.341-1.124 2.876l-.021.165.033.163.071.345c0 1.654-1.346 3-3 3-.795 0-1.545-.311-2.107-.868-.563-.567-.873-1.317-.873-2.111 0-1.431 1.007-2.632 2.351-2.929v2.926s2.528-2.087 2.984-2.461h.012l3.061-2.582-4.919-4.1h-1.137v2.404c-3.429.318-6.121 3.211-6.121 6.721 0 1.809.707 3.508 1.986 4.782 1.277 1.282 2.976 1.988 4.784 1.988 3.722 0 6.75-3.028 6.75-6.75 0-1.245-.349-2.468-1.007-3.536z"" fill=""#2D2D30""/><path d=""M12.6 6.134l-.094.071c-.269.333-.746 1.096-.91 2.375.057.277.092.495.092.545 0 2.206-1.794 4-4 4-1.098 0-2.093-.445-2.817-1.164-.718-.724-1.163-1.718-1.163-2.815 0-2.206 1.794-4 4-4l.351.025v1.85s1.626-1.342 1.631-1.339l1.869-1.577-3.5-2.917v2.218l-.371-.03c-3.176 0-5.75 2.574-5.75 5.75 0 1.593.648 3.034 1.695 4.076 1.042 1.046 2.482 1.694 4.076 1.694 3.176 0 5.75-2.574 5.75-5.75-.001-1.106-.318-2.135-.859-3.012z"" fill=""#C5C5C5""/></svg>","Are you reusing an icon here?
+",2016-10-24 15:59:57
+421,"@@ -0,0 +1 @@
++<svg xmlns=""http://www.w3.org/2000/svg"" width=""16"" height=""16""><path d=""M13.451 5.609l-.579-.939-1.068.812-.076.094c-.335.415-.927 1.341-1.124 2.876l-.021.165.033.163.071.345c0 1.654-1.346 3-3 3-.795 0-1.545-.311-2.107-.868-.563-.567-.873-1.317-.873-2.111 0-1.431 1.007-2.632 2.351-2.929v2.926s2.528-2.087 2.984-2.461h.012l3.061-2.582-4.919-4.1h-1.137v2.404c-3.429.318-6.121 3.211-6.121 6.721 0 1.809.707 3.508 1.986 4.782 1.277 1.282 2.976 1.988 4.784 1.988 3.722 0 6.75-3.028 6.75-6.75 0-1.245-.349-2.468-1.007-3.536z"" fill=""#F6F6F6""/><path d=""M12.6 6.134l-.094.071c-.269.333-.746 1.096-.91 2.375.057.277.092.495.092.545 0 2.206-1.794 4-4 4-1.098 0-2.093-.445-2.817-1.164-.718-.724-1.163-1.718-1.163-2.815 0-2.206 1.794-4 4-4l.351.025v1.85s1.626-1.342 1.631-1.339l1.869-1.577-3.5-2.917v2.218l-.371-.03c-3.176 0-5.75 2.574-5.75 5.75 0 1.593.648 3.034 1.695 4.076 1.042 1.046 2.482 1.694 4.076 1.694 3.176 0 5.75-2.574 5.75-5.75-.001-1.106-.318-2.135-.859-3.012z"" fill=""#424242""/></svg>","Are you reusing an icon here?
+",2016-10-24 15:59:51
+208,"@@ -0,0 +1,101 @@
++/*---------------------------------------------------------------------------------------------","Awesome work :+1:
+",2016-07-08 13:57:42
+403,"@@ -0,0 +1,101 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TreeExplorerNodeProvider } from 'vscode';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Disposable } from 'vs/workbench/api/node/extHostTypes';
++import { IThreadService } from 'vs/workbench/services/thread/common/threadService';
++import { MainContext, ExtHostTreeExplorersShape, MainThreadTreeExplorersShape } from './extHost.protocol';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ExtHostCommands } from 'vs/workbench/api/node/extHostCommands';
++import { asWinJsPromise } from 'vs/base/common/async';
++import { Severity } from 'vs/platform/message/common/message';
++
++export class ExtHostTreeExplorers extends ExtHostTreeExplorersShape {
++	private _proxy: MainThreadTreeExplorersShape;
++
++	private _treeExplorerNodeProviders: { [providerId: string]: TreeExplorerNodeProvider<any> };
++	private _externalNodeMaps: { [providerId: string]: { [id: number]: any } };
++
++	constructor(
++		threadService: IThreadService,
++		private commands: ExtHostCommands
++	) {
++		super();
++
++		this._proxy = threadService.get(MainContext.MainThreadExplorers);
++
++		this._treeExplorerNodeProviders = Object.create(null);
++		this._externalNodeMaps = Object.create(null);
++	}
++
++	registerTreeExplorerNodeProvider(providerId: string, provider: TreeExplorerNodeProvider<any>): Disposable {","Shouldn't this return `vscode.Disposable` from `import * as vscode from 'vscode';`?
+",2016-10-24 15:36:37
+404,"@@ -0,0 +1,101 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TreeExplorerNodeProvider } from 'vscode';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Disposable } from 'vs/workbench/api/node/extHostTypes';
++import { IThreadService } from 'vs/workbench/services/thread/common/threadService';
++import { MainContext, ExtHostTreeExplorersShape, MainThreadTreeExplorersShape } from './extHost.protocol';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ExtHostCommands } from 'vs/workbench/api/node/extHostCommands';
++import { asWinJsPromise } from 'vs/base/common/async';
++import { Severity } from 'vs/platform/message/common/message';
++
++export class ExtHostTreeExplorers extends ExtHostTreeExplorersShape {
++	private _proxy: MainThreadTreeExplorersShape;
++
++	private _treeExplorerNodeProviders: { [providerId: string]: TreeExplorerNodeProvider<any> };
++	private _externalNodeMaps: { [providerId: string]: { [id: number]: any } };
++
++	constructor(
++		threadService: IThreadService,
++		private commands: ExtHostCommands
++	) {
++		super();
++
++		this._proxy = threadService.get(MainContext.MainThreadExplorers);
++
++		this._treeExplorerNodeProviders = Object.create(null);
++		this._externalNodeMaps = Object.create(null);
++	}
++
++	registerTreeExplorerNodeProvider(providerId: string, provider: TreeExplorerNodeProvider<any>): Disposable {
++		this._proxy.$registerTreeExplorerNodeProvider(providerId);
++		this._treeExplorerNodeProviders[providerId] = provider;
++
++		return new Disposable(() => {
++			delete this._treeExplorerNodeProviders[providerId];","Don't you need to clean up `_externalNodeMaps` too?
+",2016-10-24 15:37:16
+400,"@@ -0,0 +1,101 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TreeExplorerNodeProvider } from 'vscode';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Disposable } from 'vs/workbench/api/node/extHostTypes';
++import { IThreadService } from 'vs/workbench/services/thread/common/threadService';
++import { MainContext, ExtHostTreeExplorersShape, MainThreadTreeExplorersShape } from './extHost.protocol';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ExtHostCommands } from 'vs/workbench/api/node/extHostCommands';
++import { asWinJsPromise } from 'vs/base/common/async';
++import { Severity } from 'vs/platform/message/common/message';
++
++export class ExtHostTreeExplorers extends ExtHostTreeExplorersShape {
++	private _proxy: MainThreadTreeExplorersShape;
++
++	private _treeExplorerNodeProviders: { [providerId: string]: TreeExplorerNodeProvider<any> };
++	private _externalNodeMaps: { [providerId: string]: { [id: number]: any } };
++
++	constructor(
++		threadService: IThreadService,
++		private commands: ExtHostCommands
++	) {
++		super();
++
++		this._proxy = threadService.get(MainContext.MainThreadExplorers);
++
++		this._treeExplorerNodeProviders = Object.create(null);
++		this._externalNodeMaps = Object.create(null);
++	}
++
++	registerTreeExplorerNodeProvider(providerId: string, provider: TreeExplorerNodeProvider<any>): Disposable {
++		this._proxy.$registerTreeExplorerNodeProvider(providerId);
++		this._treeExplorerNodeProviders[providerId] = provider;
++
++		return new Disposable(() => {
++			delete this._treeExplorerNodeProviders[providerId];
++		});
++	}
++
++	$provideRootNode(providerId: string): TPromise<InternalTreeExplorerNode> {
++		const provider = this.getProvider(providerId);
++
++		return asWinJsPromise(() => provider.provideRootNode()).then(externalRootNode => {
++			const treeNodeMap = Object.create(null);
++			this._externalNodeMaps[providerId] = treeNodeMap;
++
++			const internalRootNode = new InternalTreeExplorerNode(externalRootNode, provider);
++			this._externalNodeMaps[providerId][internalRootNode.id] = externalRootNode;
++			return internalRootNode;
++		}, err => {
++			this.showErrorMessage(`TreeExplorerNodeProvider '${providerId}' failed to provide root node.`);
++		});
++	}
++
++	$resolveChildren(providerId: string, mainThreadNode: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]> {
++		const provider = this.getProvider(providerId);
++
++		const externalNodeMap = this._externalNodeMaps[providerId];
++		const externalNode = externalNodeMap[mainThreadNode.id];
++
++		return asWinJsPromise(() => provider.resolveChildren(externalNode)).then(children => {
++			return children.map(externalChild => {
++				const internalChild = new InternalTreeExplorerNode(externalChild, provider);
++				externalNodeMap[internalChild.id] = externalChild;
++				return internalChild;
++			});
++		}, err => {
++			this.showErrorMessage(`TreeExplorerNodeProvider '${providerId}' failed to resolve children.`);
++		});
++	}
++
++	$executeCommand(providerId: string, mainThreadNode: InternalTreeExplorerNode): TPromise<void> {
++		if (mainThreadNode.clickCommand) {
++			const externalNode = this._externalNodeMaps[providerId][mainThreadNode.id];
++			return asWinJsPromise(() => this.commands.executeCommand(mainThreadNode.clickCommand, externalNode)).then(() => {
++				return null;
++			}, err => {
++				this.showErrorMessage(`Failed to execute command '${mainThreadNode.clickCommand}' provided by TreeExplorerNodeProvider '${providerId}'.`);
++			});
++		}
++
++		return TPromise.as(null);
++	}
++
++	getProvider(providerId: string): TreeExplorerNodeProvider<any> {
++		const provider = this._treeExplorerNodeProviders[providerId];
++		if (!provider) {
++			this.showErrorMessage(`No TreeExplorerNodeProvider with id '${providerId}' registered.`);
++		}
++
++		return provider;
++	}
++
++	private showErrorMessage(message: string): void {
++		this._proxy.$showMessage(Severity.Error, message);","You could probably make ExtHostMessageService a dependency and call into that from here?
+",2016-10-24 15:30:49
+803,"@@ -0,0 +1,102 @@
++/*---------------------------------------------------------------------------------------------","Seems like a lot of overlap with https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-browser/bootstrap/index.js#L48, maybe better to have a common base that both can reuse?",2017-03-07 06:36:13
+427,"@@ -0,0 +1,102 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TreeExplorerNodeProvider } from 'vscode';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Disposable } from 'vs/workbench/api/node/extHostTypes';
++import { IThreadService } from 'vs/workbench/services/thread/common/threadService';
++import { MainContext, ExtHostTreeExplorersShape, MainThreadTreeExplorersShape } from './extHost.protocol';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ExtHostCommands } from 'vs/workbench/api/node/extHostCommands';
++import { asWinJsPromise } from 'vs/base/common/async';
++import { Severity } from 'vs/platform/message/common/message';
++
++export class ExtHostTreeExplorers extends ExtHostTreeExplorersShape {
++	private _proxy: MainThreadTreeExplorersShape;
++
++	private _treeExplorerNodeProviders: { [providerId: string]: TreeExplorerNodeProvider<any> };
++	private _externalNodeMaps: { [providerId: string]: { [id: number]: any } };
++
++	constructor(
++		threadService: IThreadService,
++		private commands: ExtHostCommands
++	) {
++		super();
++
++		this._proxy = threadService.get(MainContext.MainThreadExplorers);
++
++		this._treeExplorerNodeProviders = Object.create(null);
++		this._externalNodeMaps = Object.create(null);
++	}
++
++	registerTreeExplorerNodeProvider(providerId: string, provider: TreeExplorerNodeProvider<any>): Disposable {
++		this._proxy.$registerTreeExplorerNodeProvider(providerId);
++		this._treeExplorerNodeProviders[providerId] = provider;
++
++		return new Disposable(() => {
++			delete this._treeExplorerNodeProviders[providerId];
++			delete this._treeExplorerNodeProviders[providerId];
++		});
++	}
++
++	$provideRootNode(providerId: string): TPromise<InternalTreeExplorerNode> {
++		const provider = this.getProvider(providerId);
++
++		return asWinJsPromise(() => provider.provideRootNode()).then(externalRootNode => {
++			const treeNodeMap = Object.create(null);
++			this._externalNodeMaps[providerId] = treeNodeMap;
++
++			const internalRootNode = new InternalTreeExplorerNode(externalRootNode, provider);
++			this._externalNodeMaps[providerId][internalRootNode.id] = externalRootNode;
++			return internalRootNode;
++		}, err => {
++			this.showErrorMessage(`TreeExplorerNodeProvider '${providerId}' failed to provide root node.`);","[needs change] Replace with `return TPromise.wrapError('TreeEx...')`
+",2016-11-01 09:49:31
+428,"@@ -0,0 +1,102 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TreeExplorerNodeProvider } from 'vscode';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Disposable } from 'vs/workbench/api/node/extHostTypes';
++import { IThreadService } from 'vs/workbench/services/thread/common/threadService';
++import { MainContext, ExtHostTreeExplorersShape, MainThreadTreeExplorersShape } from './extHost.protocol';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ExtHostCommands } from 'vs/workbench/api/node/extHostCommands';
++import { asWinJsPromise } from 'vs/base/common/async';
++import { Severity } from 'vs/platform/message/common/message';
++
++export class ExtHostTreeExplorers extends ExtHostTreeExplorersShape {
++	private _proxy: MainThreadTreeExplorersShape;
++
++	private _treeExplorerNodeProviders: { [providerId: string]: TreeExplorerNodeProvider<any> };
++	private _externalNodeMaps: { [providerId: string]: { [id: number]: any } };
++
++	constructor(
++		threadService: IThreadService,
++		private commands: ExtHostCommands
++	) {
++		super();
++
++		this._proxy = threadService.get(MainContext.MainThreadExplorers);
++
++		this._treeExplorerNodeProviders = Object.create(null);
++		this._externalNodeMaps = Object.create(null);
++	}
++
++	registerTreeExplorerNodeProvider(providerId: string, provider: TreeExplorerNodeProvider<any>): Disposable {
++		this._proxy.$registerTreeExplorerNodeProvider(providerId);
++		this._treeExplorerNodeProviders[providerId] = provider;
++
++		return new Disposable(() => {
++			delete this._treeExplorerNodeProviders[providerId];
++			delete this._treeExplorerNodeProviders[providerId];
++		});
++	}
++
++	$provideRootNode(providerId: string): TPromise<InternalTreeExplorerNode> {
++		const provider = this.getProvider(providerId);
++
++		return asWinJsPromise(() => provider.provideRootNode()).then(externalRootNode => {
++			const treeNodeMap = Object.create(null);
++			this._externalNodeMaps[providerId] = treeNodeMap;
++
++			const internalRootNode = new InternalTreeExplorerNode(externalRootNode, provider);
++			this._externalNodeMaps[providerId][internalRootNode.id] = externalRootNode;
++			return internalRootNode;
++		}, err => {
++			this.showErrorMessage(`TreeExplorerNodeProvider '${providerId}' failed to provide root node.`);
++		});
++	}
++
++	$resolveChildren(providerId: string, mainThreadNode: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]> {
++		const provider = this.getProvider(providerId);
++
++		const externalNodeMap = this._externalNodeMaps[providerId];
++		const externalNode = externalNodeMap[mainThreadNode.id];
++
++		return asWinJsPromise(() => provider.resolveChildren(externalNode)).then(children => {
++			return children.map(externalChild => {
++				const internalChild = new InternalTreeExplorerNode(externalChild, provider);
++				externalNodeMap[internalChild.id] = externalChild;
++				return internalChild;
++			});
++		}, err => {
++			this.showErrorMessage(`TreeExplorerNodeProvider '${providerId}' failed to resolve children.`);","[needs change] Like above `return Promise.wrapError(...)`
+",2016-11-01 09:50:08
+52,"@@ -0,0 +1,107 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import nls = require('vs/nls');
++import {Promise} from 'vs/base/common/winjs.base';
++import {Action} from 'vs/base/common/actions';
++import {KeyMod, KeyCode} from 'vs/base/common/keyCodes';
++import {Registry} from 'vs/platform/platform';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {IPanel} from 'vs/workbench/common/panel';
++import {IWorkbenchActionRegistry, Extensions as WorkbenchExtensions} from 'vs/workbench/common/actionRegistry';
++import {Composite, CompositeDescriptor, CompositeRegistry} from 'vs/workbench/browser/composite';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IWorkspaceContextService} from 'vs/workbench/services/workspace/common/contextService';
++
++export abstract class Panel extends Composite implements IPanel { }
++
++/**
++ * A panel descriptor is a leightweight descriptor of a panel in the monaco workbench.
++ */
++export class PanelDescriptor extends CompositeDescriptor<Panel> { }
++
++export class PanelRegistry extends CompositeRegistry<Panel> {
++	private defaultPanelId: string;
++
++	/**
++	 * Registers a panel to the platform.
++	 */
++	public registerPanel(descriptor: PanelDescriptor): void {
++		super.registerComposite(descriptor);
++	}
++
++	/**
++	 * Returns the panel descriptor for the given id or null if none.
++	 */
++	public getPanel(id: string): PanelDescriptor {
++		return this.getComposite(id);
++	}
++
++	/**
++	 * Returns an array of registered panels known to the platform.
++	 */
++	public getPanels(): PanelDescriptor[] {
++		return this.getComposits();
++	}
++
++	/**
++	 * Sets the id of the panel that should open on startup by default.
++	 */
++	public setDefaultPanelId(id: string): void {
++		this.defaultPanelId = id;
++	}
++
++	/**
++	 * Gets the id of the panel that should open on startup by default.
++	 */
++	public getDefaultPanelId(): string {
++		return this.defaultPanelId;
++	}
++}
++
++export const Extensions = {
++	Panels: 'workbench.contributions.panels'
++};
++
++export class ClosePanelAction extends Action {","@isidorn Suggest to move these actions into panelPart. You can see that sidebarPart is also contributing an action!
+",2016-01-19 11:10:10
+50,"@@ -0,0 +1,107 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import nls = require('vs/nls');
++import {Promise} from 'vs/base/common/winjs.base';
++import {Action} from 'vs/base/common/actions';
++import {KeyMod, KeyCode} from 'vs/base/common/keyCodes';
++import {Registry} from 'vs/platform/platform';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {IPanel} from 'vs/workbench/common/panel';
++import {IWorkbenchActionRegistry, Extensions as WorkbenchExtensions} from 'vs/workbench/common/actionRegistry';
++import {Composite, CompositeDescriptor, CompositeRegistry} from 'vs/workbench/browser/composite';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IWorkspaceContextService} from 'vs/workbench/services/workspace/common/contextService';
++
++export abstract class Panel extends Composite implements IPanel { }
++
++/**
++ * A panel descriptor is a leightweight descriptor of a panel in the monaco workbench.
++ */
++export class PanelDescriptor extends CompositeDescriptor<Panel> { }
++
++export class PanelRegistry extends CompositeRegistry<Panel> {
++	private defaultPanelId: string;
++
++	/**
++	 * Registers a panel to the platform.
++	 */
++	public registerPanel(descriptor: PanelDescriptor): void {
++		super.registerComposite(descriptor);
++	}
++
++	/**
++	 * Returns the panel descriptor for the given id or null if none.
++	 */
++	public getPanel(id: string): PanelDescriptor {
++		return this.getComposite(id);
++	}
++
++	/**
++	 * Returns an array of registered panels known to the platform.
++	 */
++	public getPanels(): PanelDescriptor[] {
++		return this.getComposits();
++	}
++
++	/**
++	 * Sets the id of the panel that should open on startup by default.
++	 */
++	public setDefaultPanelId(id: string): void {
++		this.defaultPanelId = id;
++	}
++
++	/**
++	 * Gets the id of the panel that should open on startup by default.
++	 */
++	public getDefaultPanelId(): string {
++		return this.defaultPanelId;
++	}
++}
++
++export const Extensions = {
++	Panels: 'workbench.contributions.panels'
++};
++
++export class ClosePanelAction extends Action {
++	static ID = 'workbench.action.closePanelAction';
++	static LABEL = nls.localize('closePanel', ""Close"");
++
++	constructor(
++		id: string,
++		name: string,
++		@IPartService private partService: IPartService
++	) {
++		super(id, name, 'close-editor-action');
++	}
++
++	public run(): Promise {
++		this.partService.setPanelHidden(false);","I guess this should be ""true"" for closing?
+",2016-01-19 11:03:48
+907,"@@ -0,0 +1,107 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import strings = require('vs/base/common/strings');
++import uri from 'vs/base/common/uri';
++import { isMacintosh } from 'vs/base/common/platform';
++import * as errors from 'vs/base/common/errors';
++import { IMouseEvent, StandardMouseEvent } from 'vs/base/browser/mouseEvent';
++import * as nls from 'vs/nls';
++import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++
++export class LinkDetector {
++	private static FILE_LOCATION_PATTERNS: RegExp[] = [
++		// group 0: the full thing :)
++		// group 1: absolute path
++		// group 2: drive letter on windows with trailing backslash or leading slash on mac/linux
++		// group 3: line number
++		// group 4: column number
++		// eg: at Context.<anonymous> (c:\Users\someone\Desktop\mocha-runner\test\test.js:26:11)
++		/(?![\(])(?:file:\/\/)?((?:([a-zA-Z]+:)|[^\(\)<>\'\""\[\]:\s]+)(?:[\\/][^\(\)<>\'\""\[\]:]*)?\.[a-zA-Z]+[0-9]*):(\d+)(?::(\d+))?/g","I notice that the comments are the same but the regex is now more complicated.
+Could you please add some comments in code to clarify this regex beast",2017-05-05 09:38:51
+909,"@@ -0,0 +1,107 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import strings = require('vs/base/common/strings');
++import uri from 'vs/base/common/uri';
++import { isMacintosh } from 'vs/base/common/platform';
++import * as errors from 'vs/base/common/errors';
++import { IMouseEvent, StandardMouseEvent } from 'vs/base/browser/mouseEvent';
++import * as nls from 'vs/nls';
++import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++
++export class LinkDetector {
++	private static FILE_LOCATION_PATTERNS: RegExp[] = [
++		// group 0: the full thing :)
++		// group 1: absolute path
++		// group 2: drive letter on windows with trailing backslash or leading slash on mac/linux
++		// group 3: line number
++		// group 4: column number
++		// eg: at Context.<anonymous> (c:\Users\someone\Desktop\mocha-runner\test\test.js:26:11)
++		/(?![\(])(?:file:\/\/)?((?:([a-zA-Z]+:)|[^\(\)<>\'\""\[\]:\s]+)(?:[\\/][^\(\)<>\'\""\[\]:]*)?\.[a-zA-Z]+[0-9]*):(\d+)(?::(\d+))?/g
++	];
++
++	constructor(
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IWorkspaceContextService private contextService: IWorkspaceContextService
++	) {
++		// noop
++	}
++","Since this `handleLinks` is now a public method we could try to make the API a bit nicer, a personally find it ugly that it returns an `HTMLElement` or a `string`. It is hard to figure out what to expect as a return result for someobdy who just wants to use the link detector.
+At least provide some comments to clarify each case, or try to always return an object with the corresponding fields.
+
+For ideas you can also check what does the terminal / editor link detector do and how does their API look like",2017-05-05 09:41:48
+908,"@@ -0,0 +1,107 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import strings = require('vs/base/common/strings');
++import uri from 'vs/base/common/uri';
++import { isMacintosh } from 'vs/base/common/platform';
++import * as errors from 'vs/base/common/errors';
++import { IMouseEvent, StandardMouseEvent } from 'vs/base/browser/mouseEvent';
++import * as nls from 'vs/nls';
++import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++
++export class LinkDetector {
++	private static FILE_LOCATION_PATTERNS: RegExp[] = [
++		// group 0: the full thing :)
++		// group 1: absolute path
++		// group 2: drive letter on windows with trailing backslash or leading slash on mac/linux
++		// group 3: line number
++		// group 4: column number
++		// eg: at Context.<anonymous> (c:\Users\someone\Desktop\mocha-runner\test\test.js:26:11)
++		/(?![\(])(?:file:\/\/)?((?:([a-zA-Z]+:)|[^\(\)<>\'\""\[\]:\s]+)(?:[\\/][^\(\)<>\'\""\[\]:]*)?\.[a-zA-Z]+[0-9]*):(\d+)(?::(\d+))?/g
++	];
++
++	constructor(
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IWorkspaceContextService private contextService: IWorkspaceContextService
++	) {
++		// noop
++	}
++
++	public handleLinks(text: string): HTMLElement | string {","As far as I understand there have been no changes till the end of this file, it has just been moved over.
+If that is the case it looks good to me",2017-05-05 09:40:14
+952,"@@ -0,0 +1,110 @@
++/*---------------------------------------------------------------------------------------------","I like the idea of inferring the tsconfig.json to use from the open active TS file. However if no file is open I think we should still provide a reasonable command and not just look into the workspace root. We should search for all tsconfig.json and return all of them. If a build is trigger the task runner will run all of them
+
+Regarding activation: I have a similar problem in ESLint where I need to active the plugin to simply being able to listen to config changes. This is all I do in activate. In addition I listen to open event and if a JS files opens I start the ESLint server by hand. So basically I have an activate and a realActivate. We could do the same for TS and start the tsserver when we get a open event for a TS file in the listener registered in activate. ",2017-05-23 19:21:21
+486,"@@ -0,0 +1,111 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import * as crypto from 'crypto';
++import * as fs from 'fs';
++import * as path from 'path';
++import Uri from 'vs/base/common/uri';
++import { readdirSync } from 'vs/base/node/extfs';
++import { IBackupWorkspacesFormat, IBackupMainService } from 'vs/platform/backup/common/backup';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++
++export class BackupMainService implements IBackupMainService {
++
++	public _serviceBrand: any;
++
++	protected backupHome: string;
++	protected workspacesJsonPath: string;
++
++	private workspacesJsonContent: IBackupWorkspacesFormat;
++
++	constructor(
++		@IEnvironmentService environmentService: IEnvironmentService
++	) {
++		this.backupHome = environmentService.backupHome;
++		this.workspacesJsonPath = environmentService.backupWorkspacesPath;
++		this.loadSync();
++	}
++
++	public getWorkspaceBackupPaths(): string[] {
++		return this.workspacesJsonContent.folderWorkspaces;
++	}
++
++	public pushWorkspaceBackupPathsSync(workspaces: Uri[]): void {
++		workspaces.forEach(workspace => {
++			// Hot exit is disabled for empty workspaces
++			if (!workspace) {
++				return;
++			}
++
++			if (this.workspacesJsonContent.folderWorkspaces.indexOf(workspace.fsPath) === -1) {
++				this.workspacesJsonContent.folderWorkspaces.push(workspace.fsPath);
++			}
++		});
++		this.saveSync();
++	}
++
++	public removeWorkspaceBackupPathSync(workspace: Uri): void {
++		if (!this.workspacesJsonContent.folderWorkspaces) {
++			return;
++		}
++		const index = this.workspacesJsonContent.folderWorkspaces.indexOf(workspace.fsPath);
++		if (index === -1) {
++			return;
++		}
++		this.workspacesJsonContent.folderWorkspaces.splice(index, 1);
++		this.saveSync();
++	}
++
++	public getWorkspaceUntitledFileBackupsSync(workspace: Uri): string[] {
++		const untitledDir = path.join(this.getWorkspaceBackupDirectory(workspace), 'untitled');
++
++		// Allow sync here as it's only used in workbench initialization's critical path
++		try {
++			return readdirSync(untitledDir).map(file => path.join(untitledDir, file));
++		} catch (ex) {
++			return [];
++		}
++	}
++
++	public hasWorkspaceBackup(workspace: Uri): boolean {
++		return fs.existsSync(this.getWorkspaceBackupDirectory(workspace));
++	}
++
++	private getWorkspaceBackupDirectory(workspace: Uri): string {
++		const workspaceHash = crypto.createHash('md5').update(workspace.fsPath).digest('hex');
++		return path.join(this.backupHome, workspaceHash);
++	}
++
++	protected loadSync(): void {
++		try {
++			this.workspacesJsonContent = JSON.parse(fs.readFileSync(this.workspacesJsonPath, 'utf8').toString()); // invalid JSON or permission issue can happen here
++		} catch (error) {
++			this.workspacesJsonContent = Object.create(null);
++		}
++
++		// Ensure folderWorkspaces is a string[]
++		if (this.workspacesJsonContent.folderWorkspaces) {
++			const fws = this.workspacesJsonContent.folderWorkspaces;
++			if (!Array.isArray(fws) || fws.some(f => typeof f !== 'string')) {
++				this.workspacesJsonContent = Object.create(null);
++			}
++		}
++
++		if (!this.workspacesJsonContent.folderWorkspaces) {
++			this.workspacesJsonContent.folderWorkspaces = [];
++		}
++	}
++
++	private saveSync(): void {
++		try {
++			// The user data directory must exist so only the Backup directory needs to be checked.
++			if (!fs.existsSync(this.backupHome)) {
++				fs.mkdirSync(this.backupHome);
++			}
++			fs.writeFileSync(this.workspacesJsonPath, JSON.stringify(this.workspacesJsonContent));
++		} catch (ex) {","@Tyriar maybe add at least some logging here to be able to find out about issues more easily.
+",2016-11-11 07:04:09
+415,"@@ -0,0 +1,115 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import nls = require('vs/nls');
++import { TPromise } from 'vs/base/common/winjs.base';
++import * as DOM from 'vs/base/browser/dom';
++import { Builder, $ } from 'vs/base/browser/builder';
++import { IWorkspace } from 'vs/platform/workspace/common/workspace';
++import { CollapsibleViewletView } from 'vs/workbench/browser/viewlet';
++import { IAction, IActionRunner } from 'vs/base/common/actions';
++import { IMessageService } from 'vs/platform/message/common/message';
++import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
++import { IContextMenuService } from 'vs/platform/contextview/browser/contextView';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
++import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
++import { IEditorGroupService } from 'vs/workbench/services/group/common/groupService';
++import { ITreeExplorerViewletService } from 'vs/workbench/parts/explorers/browser/treeExplorerViewletService';
++import { ITree } from 'vs/base/parts/tree/browser/tree';
++import { Tree } from 'vs/base/parts/tree/browser/treeImpl';
++import { TreeExplorerViewletState, TreeDataSource, TreeRenderer, TreeController } from 'vs/workbench/parts/explorers/browser/views/treeExplorerViewer';
++import { RefreshViewExplorerAction } from 'vs/workbench/parts/explorers/browser/treeExplorerActions';
++
++export class TreeExplorerView extends CollapsibleViewletView {
++	private workspace: IWorkspace;
++
++	constructor(
++		private viewletState: TreeExplorerViewletState,
++		private treeNodeProviderId: string,
++		actionRunner: IActionRunner,
++		headerSize: number,
++		@IMessageService messageService: IMessageService,
++		@IKeybindingService keybindingService: IKeybindingService,
++		@IContextMenuService contextMenuService: IContextMenuService,
++		@IWorkspaceContextService private contextService: IWorkspaceContextService,
++		@IInstantiationService private instantiationService: IInstantiationService,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IEditorGroupService private editorGroupService: IEditorGroupService,
++		@ITreeExplorerViewletService private treeExplorerViewletService: ITreeExplorerViewletService
++	) {
++		super(actionRunner, false, nls.localize('treeExplorerViewletTree', ""Tree Explorer Section""), messageService, keybindingService, contextMenuService, headerSize);
++
++		this.workspace = contextService.getWorkspace();
++
++		this.create();
++	}
++
++	renderBody(container: HTMLElement): void {
++		this.treeContainer = super.renderViewTree(container);
++		DOM.addClass(this.treeContainer, 'tree-explorer-viewlet-tree-view');
++
++		this.tree = this.createViewer($(this.treeContainer));
++	}
++
++	createViewer(container: Builder): ITree {
++		const dataSource = this.instantiationService.createInstance(TreeDataSource, this.treeNodeProviderId);
++		const renderer = this.instantiationService.createInstance(TreeRenderer, this.viewletState, this.actionRunner, container.getHTMLElement());
++		const controller = this.instantiationService.createInstance(TreeController, this.treeNodeProviderId);
++		const sorter = null;
++		const filter = null;
++		const dnd = null;
++		const accessibilityProvider = null;
++
++		return new Tree(container.getHTMLElement(), {
++			dataSource,
++			renderer,
++			controller,
++			sorter,
++			filter,
++			dnd,
++			accessibilityProvider
++		});
++	}
++
++	getActions(): IAction[] {
++		const refresh = this.instantiationService.createInstance(RefreshViewExplorerAction, this);
++		return [refresh];
++	}
++
++	create(): TPromise<void> {
++		return this.updateInput();
++	}
++
++	setVisible(visible: boolean): TPromise<void> {
++		return super.setVisible(visible);
++	}
++
++	updateInput(): TPromise<void> {
++		if (this.treeExplorerViewletService.hasProvider(this.treeNodeProviderId)) {
++			return this.treeExplorerViewletService.provideRootNode(this.treeNodeProviderId).then(tree => {
++				this.tree.setInput(tree);
++			});
++		} else {","else/indent is redundant
+",2016-10-24 15:55:25
+652,"@@ -0,0 +1,118 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { CodeLensProvider, CodeLens, CancellationToken, TextDocument, Range, Uri, Location, Position } from 'vscode';
++import * as Proto from '../protocol';
++import * as PConst from '../protocol.const';
++
++import { ITypescriptServiceClient } from '../typescriptService';
++
++import * as nls from 'vscode-nls';
++let localize = nls.loadMessageBundle();
++
++
++class ReferencesCodeLens extends CodeLens {
++	public document: Uri;
++	public file: string;
++
++	constructor(document: Uri, file: string, range: Range) {
++		super(range);
++		this.document = document;
++		this.file = file;
++	}
++}
++
++export default class TypeScriptReferencesCodeLensProvider implements CodeLensProvider {
++	private client: ITypescriptServiceClient;
++
++	constructor(client: ITypescriptServiceClient) {
++		this.client = client;
++	}
++
++	provideCodeLenses(document: TextDocument, token: CancellationToken): Promise<CodeLens[]> {
++		const filepath = this.client.asAbsolutePath(document.uri);
++		if (!filepath) {
++			return Promise.resolve([]);
++		}
++		return this.client.execute('navtree', { file: filepath }, token).then(response => {
++			const tree = response.body;
++			const referenceableSpans: Range[] = [];
++			if (tree && tree.childItems) {
++				tree.childItems.forEach(item => this.extractReferenceableSymbols(item, referenceableSpans));
++			}
++			return Promise.resolve(referenceableSpans.map(span => new ReferencesCodeLens(document.uri, filepath, span)));
++		});
++	}
++
++	resolveCodeLens(inputCodeLens: CodeLens, token: CancellationToken): Promise<CodeLens> {
++		const codeLens = inputCodeLens as ReferencesCodeLens;
++		if (!codeLens.document) {
++			return Promise.reject<CodeLens>(codeLens);
++		}
++		const args: Proto.FileLocationRequestArgs = {
++			file: codeLens.file,
++			line: codeLens.range.start.line + 1,
++			offset: codeLens.range.start.character + 1
++		};
++		return this.client.execute('references', args, token).then(response => {
++			if (response && response.body) {
++				const referenceCount = Math.max(0, response.body.refs.length - 1);
++				const locations = response.body.refs.map(reference =>
++					new Location(codeLens.document,
++						new Range(
++							new Position(reference.start.line - 1, reference.start.offset - 1),
++							new Position(reference.end.line - 1, reference.end.offset - 1))));
++
++				codeLens.command = {
++					title: referenceCount + ' ' + (referenceCount === 1 ? localize('oneReferenceLabel', 'reference') : localize('manyReferenceLabel', 'references')),
++					command: 'editor.action.showReferences',
++					arguments: [codeLens.document, locations[0].range.start, locations.slice(1)]
++				};
++				return Promise.resolve(codeLens);
++			}
++			return Promise.reject(codeLens);
++		}).catch(() => {
++			codeLens.command = {
++				title: localize('referenceErrorLabel', 'Could not determine references'),
++				command: ''
++			};
++			return Promise.resolve(codeLens);","@jrieken What is the proper way to reject code lenses if resolving them fails? I tried using `Promise.reject`, but that leaves a bunch of ugly blank lines in the document:
+
+![screen shot 2017-01-05 at 7 17 23 pm](https://cloud.githubusercontent.com/assets/12821956/21706402/c4a051da-d37b-11e6-9f71-9016f251c61d.png)
+",2017-01-06 03:19:16
+316,"@@ -0,0 +1,119 @@
++/*---------------------------------------------------------------------------------------------","If this is a service it should move into vs/workbench/services !
+",2016-10-13 15:05:00
+317,"@@ -0,0 +1,119 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import * as fs from 'original-fs';
++import * as arrays from 'vs/base/common/arrays';
++import Uri from 'vs/base/common/uri';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { IBackupService } from 'vs/platform/backup/common/backup';
++
++interface IBackupFormat {
++	folderWorkspaces?: {
++		[workspacePath: string]: string[]
++	};
++}
++
++export class BackupService implements IBackupService {
++
++	public _serviceBrand: any;
++
++	private workspaceResource: Uri;
++	private workspacesJsonFilePath: string;
++	private fileContent: IBackupFormat;
++
++	constructor(
++		@IEnvironmentService private environmentService: IEnvironmentService,
++		@IWorkspaceContextService contextService: IWorkspaceContextService
++	) {
++		this.workspacesJsonFilePath = path.join(environmentService.userDataPath, 'Backups', 'workspaces.json');","Again this should be defined inside IEnvironmentService and not constructed
+",2016-10-13 15:05:20
+318,"@@ -0,0 +1,119 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import * as fs from 'original-fs';
++import * as arrays from 'vs/base/common/arrays';
++import Uri from 'vs/base/common/uri';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { IBackupService } from 'vs/platform/backup/common/backup';
++
++interface IBackupFormat {
++	folderWorkspaces?: {
++		[workspacePath: string]: string[]
++	};
++}
++
++export class BackupService implements IBackupService {
++
++	public _serviceBrand: any;
++
++	private workspaceResource: Uri;
++	private workspacesJsonFilePath: string;
++	private fileContent: IBackupFormat;
++
++	constructor(
++		@IEnvironmentService private environmentService: IEnvironmentService,
++		@IWorkspaceContextService contextService: IWorkspaceContextService
++	) {
++		this.workspacesJsonFilePath = path.join(environmentService.userDataPath, 'Backups', 'workspaces.json');
++		this.workspaceResource = contextService.getWorkspace().resource;
++	}
++
++	public getBackupWorkspaces(): string[] {
++		this.load();
++		return Object.keys(this.fileContent.folderWorkspaces || {});
++	}
++
++	public clearBackupWorkspaces(): void {","Again confused why this guy seems to be doing the same work as the backup service on the main side, plus some additional things.
+",2016-10-13 15:06:03
+319,"@@ -0,0 +1,119 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import * as fs from 'original-fs';
++import * as arrays from 'vs/base/common/arrays';
++import Uri from 'vs/base/common/uri';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { IBackupService } from 'vs/platform/backup/common/backup';
++
++interface IBackupFormat {
++	folderWorkspaces?: {
++		[workspacePath: string]: string[]
++	};
++}
++
++export class BackupService implements IBackupService {
++
++	public _serviceBrand: any;
++
++	private workspaceResource: Uri;
++	private workspacesJsonFilePath: string;
++	private fileContent: IBackupFormat;
++
++	constructor(
++		@IEnvironmentService private environmentService: IEnvironmentService,
++		@IWorkspaceContextService contextService: IWorkspaceContextService
++	) {
++		this.workspacesJsonFilePath = path.join(environmentService.userDataPath, 'Backups', 'workspaces.json');
++		this.workspaceResource = contextService.getWorkspace().resource;
++	}
++
++	public getBackupWorkspaces(): string[] {
++		this.load();
++		return Object.keys(this.fileContent.folderWorkspaces || {});
++	}
++
++	public clearBackupWorkspaces(): void {
++		this.fileContent = {
++			folderWorkspaces: {}
++		};
++		this.save();
++	}
++
++	public removeWorkspace(workspace: string): void {
++		this.load();
++		if (!this.fileContent.folderWorkspaces) {
++			return;
++		}
++		delete this.fileContent.folderWorkspaces[workspace];
++		this.save();
++	}
++
++	public getBackupFiles(workspace: string): string[] {
++		this.load();
++		return this.fileContent.folderWorkspaces[workspace] || [];
++	}
++
++	public getBackupUntitledFiles(workspace: string): string[] {
++		const workspaceHash = crypto.createHash('md5').update(this.workspaceResource.fsPath).digest('hex');","What happens when the same file is edited in 2 windows?
+",2016-10-13 15:06:33
+320,"@@ -0,0 +1,119 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import * as fs from 'original-fs';
++import * as arrays from 'vs/base/common/arrays';
++import Uri from 'vs/base/common/uri';
++import { IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { IBackupService } from 'vs/platform/backup/common/backup';
++
++interface IBackupFormat {
++	folderWorkspaces?: {
++		[workspacePath: string]: string[]
++	};
++}
++
++export class BackupService implements IBackupService {
++
++	public _serviceBrand: any;
++
++	private workspaceResource: Uri;
++	private workspacesJsonFilePath: string;
++	private fileContent: IBackupFormat;
++
++	constructor(
++		@IEnvironmentService private environmentService: IEnvironmentService,
++		@IWorkspaceContextService contextService: IWorkspaceContextService
++	) {
++		this.workspacesJsonFilePath = path.join(environmentService.userDataPath, 'Backups', 'workspaces.json');
++		this.workspaceResource = contextService.getWorkspace().resource;
++	}
++
++	public getBackupWorkspaces(): string[] {
++		this.load();
++		return Object.keys(this.fileContent.folderWorkspaces || {});
++	}
++
++	public clearBackupWorkspaces(): void {
++		this.fileContent = {
++			folderWorkspaces: {}
++		};
++		this.save();
++	}
++
++	public removeWorkspace(workspace: string): void {
++		this.load();
++		if (!this.fileContent.folderWorkspaces) {
++			return;
++		}
++		delete this.fileContent.folderWorkspaces[workspace];
++		this.save();
++	}
++
++	public getBackupFiles(workspace: string): string[] {
++		this.load();
++		return this.fileContent.folderWorkspaces[workspace] || [];
++	}
++
++	public getBackupUntitledFiles(workspace: string): string[] {
++		const workspaceHash = crypto.createHash('md5').update(this.workspaceResource.fsPath).digest('hex');
++		const untitledDir = path.join(this.environmentService.userDataPath, 'Backups', workspaceHash, 'untitled');
++		try {
++			const untitledFiles = fs.readdirSync(untitledDir).map(file => path.join(untitledDir, file));","Red flag for sync fs API, we should avoid it by all means and use Promises instead if needed.
+",2016-10-13 15:07:02
+14,"@@ -0,0 +1,12 @@
++# EditorConfig is awesome: http://EditorConfig.org
++
++# top-most EditorConfig file
++root = true
++
++# Tab indentation (no size specified)
++[*]
++indent_style = tab
++
++[{.travis.yml,npm-shrinkwrap.json}]
++indent_style = space
++indent_size = 2","indent must be 4
+",2015-11-24 09:12:49
+949,"@@ -0,0 +1,128 @@
++{
++  ""name"": ""merge-conflict"",
++  ""publisher"": ""vscode"",
++  ""displayName"": ""merge-conflict"",
++  ""description"": ""Merge Conflict"",
++  ""version"": ""0.7.0"",
++  ""aiKey"": ""AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217"",
++  ""enableProposedApi"": true,","Not needed, I believe. Remove the property to clarify.",2017-05-23 18:19:29
+947,"@@ -0,0 +1,128 @@
++{
++  ""name"": ""merge-conflict"",
++  ""publisher"": ""vscode"",
++  ""displayName"": ""merge-conflict"",
++  ""description"": ""Merge Conflict"",
++  ""version"": ""0.7.0"",
++  ""aiKey"": ""AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217"",
++  ""enableProposedApi"": true,
++  ""engines"": {
++    ""vscode"": ""^1.5.0""
++  },
++  ""categories"": [
++    ""Other""
++  ],
++  ""activationEvents"": [
++    ""*""
++  ],
++  ""main"": ""./out/extension"",
++  ""scripts"": {
++    ""compile"": ""gulp compile-extension:merge-conflict"",
++    ""watch"": ""gulp watch-extension:merge-conflict""
++  },
++  ""contributes"": {
++    ""commands"": [
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.accept.all-incoming%"",
++        ""command"": ""merge-conflict.accept.all-incoming""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.accept.all-both%"",
++        ""command"": ""merge-conflict.accept.all-both""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.accept.current%"",
++        ""command"": ""merge-conflict.accept.current""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.accept.incoming%"",
++        ""command"": ""merge-conflict.accept.incoming""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""Accept selection"",
++        ""command"": ""merge-conflict.accept.selection""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.accept.both%"",
++        ""command"": ""merge-conflict.accept.both""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.next%"",
++        ""command"": ""merge-conflict.next""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.previous%"",
++        ""command"": ""merge-conflict.previous""
++      },
++      {
++        ""category"": ""%command.category%"",
++        ""title"": ""%command.compare%"",
++        ""command"": ""merge-conflict.compare""
++      }
++    ],
++    ""keybindings"": [
++      {
++        ""command"": ""merge-conflict.next"",
++        ""when"": ""editorTextFocus"",
++        ""key"": ""alt+m down""
++      },
++      {
++        ""command"": ""merge-conflict.previous"",
++        ""when"": ""editorTextFocus"",
++        ""key"": ""alt+m up""
++      },
++      {
++        ""command"": ""merge-conflict.accept.selection"",
++        ""when"": ""editorTextFocus"",
++        ""key"": ""alt+m enter""
++      },
++      {
++        ""command"": ""merge-conflict.accept.current"",
++        ""when"": ""editorTextFocus"",
++        ""key"": ""alt+m 1""
++      },
++      {
++        ""command"": ""merge-conflict.accept.incoming"",
++        ""when"": ""editorTextFocus"",
++        ""key"": ""alt+m 2""
++      },
++      {
++        ""command"": ""merge-conflict.accept.both"",
++        ""when"": ""editorTextFocus"",
++        ""key"": ""alt+m 3""
++      }
++    ],
++    ""configuration"": {
++      ""title"": ""Merge Conflict"",",Extract to nls file for completeness.,2017-05-23 18:17:10
+116,"@@ -0,0 +1,129 @@
++/*---------------------------------------------------------------------------------------------","This should also live in `electron-browser/`.
+",2016-04-18 19:11:53
+51,"@@ -0,0 +1,13 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++.monaco-workbench > .panel > .content > .panel {
++	height: 100%;
++}
++
++.monaco-workbench > .part.panel > .title {
++	display: block;
++	border-top: 1px solid #007ACC","@isidorn is this value not dynamic depending on debug, no workspace or workspace? I would check what the statusbar does to set this color.
+",2016-01-19 11:07:45
+416,"@@ -0,0 +1,130 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { $, Builder } from 'vs/base/browser/builder';
++import { ITree, IDataSource, IRenderer, IElementCallback } from 'vs/base/parts/tree/browser/tree';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ClickBehavior, DefaultController } from 'vs/base/parts/tree/browser/treeDefaults';
++import { IMouseEvent } from 'vs/base/browser/mouseEvent';
++import { IActionRunner } from 'vs/base/common/actions';
++import { IActionProvider, ActionsRenderer } from 'vs/base/parts/tree/browser/actionsRenderer';
++import { ContributableActionProvider } from 'vs/workbench/browser/actionBarRegistry';
++import { IContextViewService } from 'vs/platform/contextview/browser/contextView';
++import { IExtensionService } from 'vs/platform/extensions/common/extensions';
++import { IModeService } from 'vs/editor/common/services/modeService';
++import { ITreeExplorerViewletService } from 'vs/workbench/parts/explorers/browser/treeExplorerViewletService';
++import { IProgressService } from 'vs/platform/progress/common/progress';
++
++export class TreeDataSource implements IDataSource {","Fill in access modifiers
+",2016-10-24 15:56:22
+417,"@@ -0,0 +1,130 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { $, Builder } from 'vs/base/browser/builder';
++import { ITree, IDataSource, IRenderer, IElementCallback } from 'vs/base/parts/tree/browser/tree';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ClickBehavior, DefaultController } from 'vs/base/parts/tree/browser/treeDefaults';
++import { IMouseEvent } from 'vs/base/browser/mouseEvent';
++import { IActionRunner } from 'vs/base/common/actions';
++import { IActionProvider, ActionsRenderer } from 'vs/base/parts/tree/browser/actionsRenderer';
++import { ContributableActionProvider } from 'vs/workbench/browser/actionBarRegistry';
++import { IContextViewService } from 'vs/platform/contextview/browser/contextView';
++import { IExtensionService } from 'vs/platform/extensions/common/extensions';
++import { IModeService } from 'vs/editor/common/services/modeService';
++import { ITreeExplorerViewletService } from 'vs/workbench/parts/explorers/browser/treeExplorerViewletService';
++import { IProgressService } from 'vs/platform/progress/common/progress';
++
++export class TreeDataSource implements IDataSource {
++
++	constructor(
++		private treeNodeProviderId: string,
++		@ITreeExplorerViewletService private treeExplorerViewletService: ITreeExplorerViewletService,
++		@IProgressService private progressService: IProgressService
++	) {
++
++	}
++
++	getId(tree: ITree, node: InternalTreeExplorerNode): string {
++		return node.id.toString();
++	}
++
++	hasChildren(tree: ITree, node: InternalTreeExplorerNode): boolean {
++		return node.hasChildren;
++	}
++
++	getChildren(tree: ITree, node: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]> {
++		const promise = this.treeExplorerViewletService.resolveChildren(this.treeNodeProviderId, node);
++
++		this.progressService.showWhile(promise, 800);","Why 800?
+",2016-10-24 15:57:30
+418,"@@ -0,0 +1,130 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { $, Builder } from 'vs/base/browser/builder';
++import { ITree, IDataSource, IRenderer, IElementCallback } from 'vs/base/parts/tree/browser/tree';
++import { InternalTreeExplorerNode } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { ClickBehavior, DefaultController } from 'vs/base/parts/tree/browser/treeDefaults';
++import { IMouseEvent } from 'vs/base/browser/mouseEvent';
++import { IActionRunner } from 'vs/base/common/actions';
++import { IActionProvider, ActionsRenderer } from 'vs/base/parts/tree/browser/actionsRenderer';
++import { ContributableActionProvider } from 'vs/workbench/browser/actionBarRegistry';
++import { IContextViewService } from 'vs/platform/contextview/browser/contextView';
++import { IExtensionService } from 'vs/platform/extensions/common/extensions';
++import { IModeService } from 'vs/editor/common/services/modeService';
++import { ITreeExplorerViewletService } from 'vs/workbench/parts/explorers/browser/treeExplorerViewletService';
++import { IProgressService } from 'vs/platform/progress/common/progress';
++
++export class TreeDataSource implements IDataSource {
++
++	constructor(
++		private treeNodeProviderId: string,
++		@ITreeExplorerViewletService private treeExplorerViewletService: ITreeExplorerViewletService,
++		@IProgressService private progressService: IProgressService
++	) {
++
++	}
++
++	getId(tree: ITree, node: InternalTreeExplorerNode): string {
++		return node.id.toString();
++	}
++
++	hasChildren(tree: ITree, node: InternalTreeExplorerNode): boolean {
++		return node.hasChildren;
++	}
++
++	getChildren(tree: ITree, node: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]> {
++		const promise = this.treeExplorerViewletService.resolveChildren(this.treeNodeProviderId, node);
++
++		this.progressService.showWhile(promise, 800);
++
++		return promise;
++	}
++
++	getParent(tree: ITree, node: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode> {
++		return TPromise.as(null);
++	}
++}
++
++export class TreeRenderer extends ActionsRenderer implements IRenderer {
++
++	constructor(
++		state: TreeExplorerViewletState,
++		actionRunner: IActionRunner,
++		private container: HTMLElement,
++		@IContextViewService private contextViewService: IContextViewService,
++		@IExtensionService private extensionService: IExtensionService,
++		@IModeService private modeService: IModeService
++	) {
++		super({
++			actionProvider: state.actionProvider,
++			actionRunner: actionRunner
++		});
++	}
++
++	getContentHeight(tree: ITree, element: any): number {
++		return 22;","Why 22?
+",2016-10-24 15:57:48
+748,"@@ -0,0 +1,135 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as editorBrowser from 'vs/editor/browser/editorBrowser';
++import { FastDomNode, createFastDomNode } from 'vs/base/browser/styleMutator';
++import { Widget } from 'vs/base/browser/ui/widget';
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
++import { Configuration } from 'vs/editor/browser/config/configuration';
++import { Position } from 'vs/editor/common/core/position';
++import { IPosition, TextEditorCursorStyle, IConfigurationChangedEvent } from 'vs/editor/common/editorCommon';
++
++export class DragTargetHintWidget extends Widget implements editorBrowser.IContentWidget {
++
++	static ID = 'editor.contrib.dragTargetHintWidget';
++	protected _editor: editorBrowser.ICodeEditor;
++	protected _showAtPosition: Position;
++	private disposables: IDisposable[] = [];
++	private _cursorStyle: TextEditorCursorStyle;
++	private _lineHeight: number;
++	private _typicalHalfwidthCharacterWidth: number;
++	private readonly _domNode: FastDomNode;","Sorry for the compile error, use `FastDomNode<HTMLElement>`",2017-02-20 11:32:05
+749,"@@ -0,0 +1,135 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as editorBrowser from 'vs/editor/browser/editorBrowser';
++import { FastDomNode, createFastDomNode } from 'vs/base/browser/styleMutator';
++import { Widget } from 'vs/base/browser/ui/widget';
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
++import { Configuration } from 'vs/editor/browser/config/configuration';
++import { Position } from 'vs/editor/common/core/position';
++import { IPosition, TextEditorCursorStyle, IConfigurationChangedEvent } from 'vs/editor/common/editorCommon';
++
++export class DragTargetHintWidget extends Widget implements editorBrowser.IContentWidget {
++
++	static ID = 'editor.contrib.dragTargetHintWidget';
++	protected _editor: editorBrowser.ICodeEditor;
++	protected _showAtPosition: Position;
++	private disposables: IDisposable[] = [];
++	private _cursorStyle: TextEditorCursorStyle;
++	private _lineHeight: number;
++	private _typicalHalfwidthCharacterWidth: number;
++	private readonly _domNode: FastDomNode;
++	private _isVisible: boolean = false;
++
++	protected get isVisible(): boolean {
++		return this._isVisible;
++	}
++
++	protected set isVisible(value: boolean) {
++		this._isVisible = value;
++	}
++
++	constructor(editor: editorBrowser.ICodeEditor) {
++		super();
++		this._editor = editor;
++
++
++		// Create the dom node
++		this._domNode = createFastDomNode(document.createElement('div'));
++		this._domNode.setClassName('cursor secondary');
++		this._domNode.setTop(0);
++		this._domNode.setLeft(0);
++		this._domNode.setAttribute('role', 'presentation');
++		this._domNode.setAttribute('aria-hidden', 'true');
++		this._domNode.setVisibility('hidden');
++		this._editor.addContentWidget(this);
++
++		this._cursorStyle = this._editor.getConfiguration().viewInfo.cursorStyle;","I don't like that we reuse here the cursor style and the cursor CSS. It makes it difficult to make changes in the CSS and e.g. it makes no sense to use a block cursor to paint the insertion point.
+
+IMHO the insertion point should always be rendered as a line, regardless of user settings. It is not a cursor, it is an insertion point.
+
+On top, I would render the insertion point in a distinct way than the cursor. I got very confused when I tried it out, it looks too much like a cursor, it should be orange or dashed or something special to let me know that it represents the drop point and is not some editor bug where a cursor is painted.
+
+It should also go away if the mouse is not sitting directly on text (mouseEvent.target !== CONTENT). If the drag is on top of a view zone, the margin, etc. there should be no drop. IMHO, only on top of content.",2017-02-20 11:35:12
+750,"@@ -0,0 +1,135 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as editorBrowser from 'vs/editor/browser/editorBrowser';
++import { FastDomNode, createFastDomNode } from 'vs/base/browser/styleMutator';
++import { Widget } from 'vs/base/browser/ui/widget';
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
++import { Configuration } from 'vs/editor/browser/config/configuration';
++import { Position } from 'vs/editor/common/core/position';
++import { IPosition, TextEditorCursorStyle, IConfigurationChangedEvent } from 'vs/editor/common/editorCommon';
++
++export class DragTargetHintWidget extends Widget implements editorBrowser.IContentWidget {
++
++	static ID = 'editor.contrib.dragTargetHintWidget';
++	protected _editor: editorBrowser.ICodeEditor;
++	protected _showAtPosition: Position;
++	private disposables: IDisposable[] = [];
++	private _cursorStyle: TextEditorCursorStyle;
++	private _lineHeight: number;
++	private _typicalHalfwidthCharacterWidth: number;
++	private readonly _domNode: FastDomNode;
++	private _isVisible: boolean = false;
++
++	protected get isVisible(): boolean {
++		return this._isVisible;
++	}
++
++	protected set isVisible(value: boolean) {
++		this._isVisible = value;
++	}
++
++	constructor(editor: editorBrowser.ICodeEditor) {
++		super();
++		this._editor = editor;
++
++
++		// Create the dom node
++		this._domNode = createFastDomNode(document.createElement('div'));
++		this._domNode.setClassName('cursor secondary');
++		this._domNode.setTop(0);
++		this._domNode.setLeft(0);
++		this._domNode.setAttribute('role', 'presentation');
++		this._domNode.setAttribute('aria-hidden', 'true');
++		this._domNode.setVisibility('hidden');
++		this._editor.addContentWidget(this);
++
++		this._cursorStyle = this._editor.getConfiguration().viewInfo.cursorStyle;
++		this._lineHeight = this._editor.getConfiguration().lineHeight;
++		this._typicalHalfwidthCharacterWidth = this._editor.getConfiguration().fontInfo.typicalHalfwidthCharacterWidth;
++
++		this._register(this._editor.onDidChangeConfiguration((e: IConfigurationChangedEvent) => {
++			if (e.fontInfo || e.viewInfo || e.lineHeight) {
++				this._typicalHalfwidthCharacterWidth = this._editor.getConfiguration().fontInfo.typicalHalfwidthCharacterWidth;
++				this._lineHeight = this._editor.getConfiguration().lineHeight;
++				this._cursorStyle = this._editor.getConfiguration().viewInfo.cursorStyle;
++			}
++		}));
++
++		// render cursor after preparing the dom node and fetching data from config.
++		this.renderCursor();
++	}
++
++	public getId(): string {
++		return DragTargetHintWidget.ID;
++	}
++
++	public getDomNode(): HTMLElement {
++		return this._domNode.domNode;
++	}
++
++	public showAt(position: IPosition): void {
++		// Position has changed
++		this._showAtPosition = new Position(position.lineNumber, position.column);
++		this.show();
++		this._editor.layoutContentWidget(this);
++		this._editor.render();
++	}
++
++	public show(): void {
++		if (!this._isVisible) {
++			this._domNode.setVisibility('inherit');
++			this._isVisible = true;
++		}
++		this.renderCursor();
++	}
++
++	public hide(): void {
++		if (this._isVisible) {
++			this._domNode.setVisibility('hidden');
++			this._isVisible = false;
++			this._editor.layoutContentWidget(this);
++		}
++	}
++
++	public getPosition(): editorBrowser.IContentWidgetPosition {
++		if (this._isVisible) {
++			return {
++				position: this._showAtPosition,
++				preference: [
++					editorBrowser.ContentWidgetPositionPreference.EXACT
++				]
++			};
++		}
++		return null;
++	}
++
++	public dispose(): void {
++		this._editor.removeContentWidget(this);
++		this.disposables = dispose(this.disposables);
++		super.dispose();
++	}
++
++	private renderCursor() {
++		if (!this.isVisible) {
++			return;
++		}
++
++		Configuration.applyFontInfo(this._domNode, this._editor.getConfiguration().fontInfo);
++		this._domNode.setHeight(this._lineHeight);
++		if (this._cursorStyle === TextEditorCursorStyle.Line) {
++			this._domNode.setWidth(1);
++		} else {
++			this._domNode.setWidth(this._typicalHalfwidthCharacterWidth);
++		}
++
++		if (this._cursorStyle === TextEditorCursorStyle.Underline) {","I would use its own styles, doing this is nasty and to be honest, confused me a lot. I couldn't tell apart the cursor from the drop hint.",2017-02-20 11:35:48
+666,"@@ -0,0 +1,14 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as os from 'os';
++import platform = require('vs/base/common/platform');
++import processes = require('vs/base/node/processes');
++
++const powershellPath = `${ process.env.SystemRoot }/system32/WindowsPowerShell/v1.0/powershell.exe`;",I think `sysnative/` should be used on 64 bit machines? Please confirm @daviwil ,2017-01-13 06:53:21
+668,"@@ -0,0 +1,14 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as os from 'os';
++import platform = require('vs/base/common/platform');
++import processes = require('vs/base/node/processes');
++
++const powershellPath = `${ process.env.SystemRoot }/system32/WindowsPowerShell/v1.0/powershell.exe`;
++const isAtLeastWindows10 = platform.isWindows && parseFloat(os.release()) >= 10;","I think you'd be better off getting the major version here as `os.release()` may return `x.y.z`?
+
+Something like this should be safe (if Node does indeed give that format):
+
+```js
+parseInt(os.release().split('.')[0], 10) >= 10
+```",2017-01-13 06:57:17
+148,"@@ -0,0 +1,143 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import 'vs/css!./media/terminal.contribution';
++import nls = require('vs/nls');
++import product from 'vs/platform/product';
++//import {KeyMod, KeyCode} from 'vs/base/common/keyCodes';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {registerSingleton} from 'vs/platform/instantiation/common/extensions';
++import {IWorkbenchActionRegistry, Extensions as ActionExtensions} from 'vs/workbench/common/actionRegistry';
++import {TerminalService} from 'vs/workbench/parts/terminal/electron-browser/terminalService';
++import {ToggleTerminalAction} from 'vs/workbench/parts/terminal/electron-browser/terminalActions';
++import {ITerminalService, TERMINAL_PANEL_ID, TERMINAL_DEFAULT_SHELL_UNIX_LIKE, TERMINAL_DEFAULT_SHELL_WINDOWS} from 'vs/workbench/parts/terminal/common/terminal';
++import * as panel from 'vs/workbench/browser/panel';
++import {Registry} from 'vs/platform/platform';
++import {Extensions, IConfigurationRegistry} from 'vs/platform/configuration/common/configurationRegistry';
++
++// Only enable in the alpha channel until more stable
++if (product.quality === 'alpha') {
++	let configurationRegistry = <IConfigurationRegistry>Registry.as(Extensions.Configuration);
++	configurationRegistry.registerConfiguration({
++		'id': 'terminal',
++		'order': 100,
++		'title': nls.localize('integratedTerminalConfigurationTitle', ""(Experimental) Integrated terminal configuration""),
++		'type': 'object',
++		'properties': {
++			'integratedTerminal.shell.unixLike': {
++				'description': nls.localize('integratedTerminal.shell.unixLike', ""The path of the shell that the terminal uses on Linux and OS X.""),
++				'type': 'string',
++				'default': TERMINAL_DEFAULT_SHELL_UNIX_LIKE
++			},
++			'integratedTerminal.shell.windows': {
++				'description': nls.localize('integratedTerminal.shell.windows', ""The path of the shell that the terminal uses on Windows.""),
++				'type': 'string',
++				'default': TERMINAL_DEFAULT_SHELL_WINDOWS
++			},
++			'integratedTerminal.fontFamily': {
++				'description': nls.localize('integratedTerminal.fontFamily', ""The font family used by the terminal (CSS font-family format).""),
++				'type': 'string',
++				'default': 'Menlo, Monaco, Consolas, ""Droid Sans Mono"", ""Courier New"", monospace, ""Droid Sans Fallback""'
++			},
++			'integratedTerminal.ansiColors.black': {
++				'description': nls.localize('integratedTerminal.ansiColors.black', ""Black color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#000000'
++			},
++			'integratedTerminal.ansiColors.red': {
++				'description': nls.localize('integratedTerminal.ansiColors.red', ""Red color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#cd3131'
++			},
++			'integratedTerminal.ansiColors.green': {
++				'description': nls.localize('integratedTerminal.ansiColors.green', ""Green color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#09885a'
++			},
++			'integratedTerminal.ansiColors.yellow': {
++				'description': nls.localize('integratedTerminal.ansiColors.yellow', ""Yellow color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#e5e510'
++			},
++			'integratedTerminal.ansiColors.blue': {
++				'description': nls.localize('integratedTerminal.ansiColors.blue', ""Blue color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#0451a5'
++			},
++			'integratedTerminal.ansiColors.magenta': {
++				'description': nls.localize('integratedTerminal.ansiColors.magenta', ""Magenta color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#bc05bc'
++			},
++			'integratedTerminal.ansiColors.cyan': {
++				'description': nls.localize('integratedTerminal.ansiColors.cyan', ""Cyan color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#0598bc'
++			},
++			'integratedTerminal.ansiColors.white': {
++				'description': nls.localize('integratedTerminal.ansiColors.white', ""White color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#e5e5e5'
++			},
++			'integratedTerminal.ansiColors.brightBlack': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightBlack', ""Bright black color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#000000'
++			},
++			'integratedTerminal.ansiColors.brightRed': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightRed', ""Bright red color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#cd3131'
++			},
++			'integratedTerminal.ansiColors.brightGreen': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightGreen', ""Bright green color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#09885a'
++			},
++			'integratedTerminal.ansiColors.brightYellow': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightYellow', ""Bright yellow color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#e5e510'
++			},
++			'integratedTerminal.ansiColors.brightBlue': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightBlue', ""Bright blue color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#0451a5'
++			},
++			'integratedTerminal.ansiColors.brightMagenta': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightMagenta', ""Bright magenta color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#bc05bc'
++			},
++			'integratedTerminal.ansiColors.brightCyan': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightCyan', ""Bright cyan color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#0598bc'
++			},
++			'integratedTerminal.ansiColors.brightWhite': {
++				'description': nls.localize('integratedTerminal.ansiColors.brightWhite', ""Bright white color for terminals that support ANSI escape sequences (format: #rrggbb)""),
++				'type': 'string',
++				'default': '#e5e5e5'
++			}
++		}
++	});
++
++	// Register Service
++	registerSingleton(ITerminalService, TerminalService);
++
++	// Register Output Panel
++	(<panel.PanelRegistry>Registry.as(panel.Extensions.Panels)).registerPanel(new panel.PanelDescriptor(
++		'vs/workbench/parts/terminal/electron-browser/terminalPanel',","@Tyriar if you have an AMD entry point like this, it needs to be declared in our buildfile.js (see https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/buildfile.js#L34)
+",2016-05-17 05:05:31
+140,"@@ -0,0 +1,145 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import termJs = require('term.js');
++import fs = require('fs');
++import {fork, Terminal} from 'pty.js';
++import platform = require('vs/base/common/platform');
++import {TPromise} from 'vs/base/common/winjs.base';
++import {Builder, Dimension} from 'vs/base/browser/builder';
++import {IConfigurationService} from 'vs/platform/configuration/common/configuration';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IWorkspaceContextService} from 'vs/platform/workspace/common/workspace';
++import {ITerminalConfiguration, TERMINAL_PANEL_ID} from 'vs/workbench/parts/terminal/common/terminal';
++import {Panel} from 'vs/workbench/browser/panel';
++import {ScrollableElement} from 'vs/base/browser/ui/scrollbar/scrollableElementImpl';
++import {DomNodeScrollable} from 'vs/base/browser/ui/scrollbar/domNodeScrollable';
++
++const TERMINAL_CHAR_WIDTH = 8;
++const TERMINAL_CHAR_HEIGHT = 18;
++
++export class TerminalPanel extends Panel {
++
++	private ptyProcess: Terminal;
++	private parentDomElement: HTMLElement;
++	private terminal;
++	private terminalDomElement: HTMLDivElement;
++
++	constructor(
++		@IConfigurationService private configurationService: IConfigurationService,
++		@ITelemetryService telemetryService: ITelemetryService,
++		@IWorkspaceContextService private contextService: IWorkspaceContextService
++	) {
++		super(TERMINAL_PANEL_ID, telemetryService);
++	}
++
++	public layout(dimension: Dimension): void {
++		let cols = Math.floor(this.parentDomElement.offsetWidth / TERMINAL_CHAR_WIDTH);
++		let rows = Math.floor(this.parentDomElement.offsetHeight / TERMINAL_CHAR_HEIGHT);
++		this.terminal.resize(cols, rows);
++		this.ptyProcess.resize(cols, rows);
++	}
++
++	public create(parent: Builder): TPromise<void> {
++		super.create(parent);
++
++		this.parentDomElement = parent.getHTMLElement();
++		this.createTerminal();
++
++		return TPromise.as(null);
++	}
++
++	private createTerminal(): void {
++		this.parentDomElement.innerHTML = '';
++		this.ptyProcess = fork(this.getShell(), [], {
++			name: fs.existsSync('/usr/share/terminfo/x/xterm-256color') ? 'xterm-256color' : 'xterm',","⚡ evil sync io inside the main thread. use callbacks/promises esp given your outer caller (`create`) allows you to do that
+",2016-04-29 15:14:50
+141,"@@ -0,0 +1,145 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import termJs = require('term.js');
++import fs = require('fs');
++import {fork, Terminal} from 'pty.js';
++import platform = require('vs/base/common/platform');
++import {TPromise} from 'vs/base/common/winjs.base';
++import {Builder, Dimension} from 'vs/base/browser/builder';
++import {IConfigurationService} from 'vs/platform/configuration/common/configuration';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IWorkspaceContextService} from 'vs/platform/workspace/common/workspace';
++import {ITerminalConfiguration, TERMINAL_PANEL_ID} from 'vs/workbench/parts/terminal/common/terminal';
++import {Panel} from 'vs/workbench/browser/panel';
++import {ScrollableElement} from 'vs/base/browser/ui/scrollbar/scrollableElementImpl';
++import {DomNodeScrollable} from 'vs/base/browser/ui/scrollbar/domNodeScrollable';
++
++const TERMINAL_CHAR_WIDTH = 8;
++const TERMINAL_CHAR_HEIGHT = 18;
++
++export class TerminalPanel extends Panel {
++
++	private ptyProcess: Terminal;
++	private parentDomElement: HTMLElement;
++	private terminal;
++	private terminalDomElement: HTMLDivElement;
++
++	constructor(
++		@IConfigurationService private configurationService: IConfigurationService,
++		@ITelemetryService telemetryService: ITelemetryService,
++		@IWorkspaceContextService private contextService: IWorkspaceContextService
++	) {
++		super(TERMINAL_PANEL_ID, telemetryService);
++	}
++
++	public layout(dimension: Dimension): void {
++		let cols = Math.floor(this.parentDomElement.offsetWidth / TERMINAL_CHAR_WIDTH);
++		let rows = Math.floor(this.parentDomElement.offsetHeight / TERMINAL_CHAR_HEIGHT);
++		this.terminal.resize(cols, rows);
++		this.ptyProcess.resize(cols, rows);
++	}
++
++	public create(parent: Builder): TPromise<void> {
++		super.create(parent);
++
++		this.parentDomElement = parent.getHTMLElement();
++		this.createTerminal();
++
++		return TPromise.as(null);
++	}
++
++	private createTerminal(): void {
++		this.parentDomElement.innerHTML = '';
++		this.ptyProcess = fork(this.getShell(), [], {
++			name: fs.existsSync('/usr/share/terminfo/x/xterm-256color') ? 'xterm-256color' : 'xterm',
++			cols: 80,
++			rows: 6,
++			cwd: this.contextService.getWorkspace() ? this.contextService.getWorkspace().resource.path : process.env.HOME
++		});
++		this.terminalDomElement = document.createElement('div');
++		this.parentDomElement.classList.add('integrated-terminal');
++		let terminalScrollable = new DomNodeScrollable(this.terminalDomElement);
++		let terminalContainer = new ScrollableElement(this.terminalDomElement, terminalScrollable, { horizontal: 'hidden', vertical: 'auto' });
++		this.terminal = termJs({
++			cursorBlink: false // term.js' blinking cursor breaks selection
++		});
++
++		this.ptyProcess.on('data', (data) => {
++			this.terminal.write(data);
++		});
++		this.terminal.on('data', (data) => {
++			this.ptyProcess.write(data);
++			return false;
++		});
++		this.ptyProcess.on('exit', (data) => {
++			this.terminal.destroy();
++			// TODO: When multiple terminals are supported this should do something smarter. There is
++			// also a weird bug here at leasy on Ubuntu 15.10 where the new terminal text does not
++			// repaint correctly.
++			this.createTerminal();
++		});
++		this.parentDomElement.addEventListener('mousedown', (event) => {
++			// Drop selection and focus terminal on Linux to enable middle button paste when click
++			// occurs on the selection itself.
++			if (event.which === 2 && platform.isLinux) {
++				this.focusTerminal(true);
++			}
++		});
++		this.parentDomElement.addEventListener('mouseup', (event) => {
++			if (event.which !== 3) {
++				this.focusTerminal();
++			}
++		});",":zap: leakage! Use the `DOM.addDisposableListener` and other unbind/unlisten APIs, keep them, and implement `dispose` in the class
+",2016-04-29 15:15:56
+142,"@@ -0,0 +1,145 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import termJs = require('term.js');
++import fs = require('fs');
++import {fork, Terminal} from 'pty.js';
++import platform = require('vs/base/common/platform');
++import {TPromise} from 'vs/base/common/winjs.base';
++import {Builder, Dimension} from 'vs/base/browser/builder';
++import {IConfigurationService} from 'vs/platform/configuration/common/configuration';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IWorkspaceContextService} from 'vs/platform/workspace/common/workspace';
++import {ITerminalConfiguration, TERMINAL_PANEL_ID} from 'vs/workbench/parts/terminal/common/terminal';
++import {Panel} from 'vs/workbench/browser/panel';
++import {ScrollableElement} from 'vs/base/browser/ui/scrollbar/scrollableElementImpl';
++import {DomNodeScrollable} from 'vs/base/browser/ui/scrollbar/domNodeScrollable';
++
++const TERMINAL_CHAR_WIDTH = 8;
++const TERMINAL_CHAR_HEIGHT = 18;
++
++export class TerminalPanel extends Panel {
++
++	private ptyProcess: Terminal;
++	private parentDomElement: HTMLElement;
++	private terminal;
++	private terminalDomElement: HTMLDivElement;
++
++	constructor(
++		@IConfigurationService private configurationService: IConfigurationService,
++		@ITelemetryService telemetryService: ITelemetryService,
++		@IWorkspaceContextService private contextService: IWorkspaceContextService
++	) {
++		super(TERMINAL_PANEL_ID, telemetryService);
++	}
++
++	public layout(dimension: Dimension): void {
++		let cols = Math.floor(this.parentDomElement.offsetWidth / TERMINAL_CHAR_WIDTH);
++		let rows = Math.floor(this.parentDomElement.offsetHeight / TERMINAL_CHAR_HEIGHT);
++		this.terminal.resize(cols, rows);
++		this.ptyProcess.resize(cols, rows);
++	}
++
++	public create(parent: Builder): TPromise<void> {
++		super.create(parent);
++
++		this.parentDomElement = parent.getHTMLElement();
++		this.createTerminal();
++
++		return TPromise.as(null);
++	}
++
++	private createTerminal(): void {
++		this.parentDomElement.innerHTML = '';
++		this.ptyProcess = fork(this.getShell(), [], {
++			name: fs.existsSync('/usr/share/terminfo/x/xterm-256color') ? 'xterm-256color' : 'xterm',
++			cols: 80,
++			rows: 6,
++			cwd: this.contextService.getWorkspace() ? this.contextService.getWorkspace().resource.path : process.env.HOME
++		});
++		this.terminalDomElement = document.createElement('div');
++		this.parentDomElement.classList.add('integrated-terminal');
++		let terminalScrollable = new DomNodeScrollable(this.terminalDomElement);
++		let terminalContainer = new ScrollableElement(this.terminalDomElement, terminalScrollable, { horizontal: 'hidden', vertical: 'auto' });
++		this.terminal = termJs({
++			cursorBlink: false // term.js' blinking cursor breaks selection
++		});
++
++		this.ptyProcess.on('data', (data) => {
++			this.terminal.write(data);
++		});
++		this.terminal.on('data', (data) => {
++			this.ptyProcess.write(data);
++			return false;
++		});
++		this.ptyProcess.on('exit', (data) => {
++			this.terminal.destroy();
++			// TODO: When multiple terminals are supported this should do something smarter. There is
++			// also a weird bug here at leasy on Ubuntu 15.10 where the new terminal text does not
++			// repaint correctly.
++			this.createTerminal();
++		});
++		this.parentDomElement.addEventListener('mousedown', (event) => {
++			// Drop selection and focus terminal on Linux to enable middle button paste when click
++			// occurs on the selection itself.
++			if (event.which === 2 && platform.isLinux) {
++				this.focusTerminal(true);
++			}
++		});
++		this.parentDomElement.addEventListener('mouseup', (event) => {
++			if (event.which !== 3) {
++				this.focusTerminal();
++			}
++		});
++
++		this.terminal.open(this.terminalDomElement);
++		this.parentDomElement.appendChild(terminalContainer.getDomNode());
++
++		let config = this.configurationService.getConfiguration<ITerminalConfiguration>();
++		this.terminalDomElement.style.fontFamily = config.integratedTerminal.fontFamily;
++		this.terminal.colors = this.getTerminalColors();","unsure where/how that is configured but the terminal shows dark tho I use a light theme...
+",2016-04-29 15:32:27
+461,"@@ -0,0 +1,147 @@
++/*---------------------------------------------------------------------------------------------","@Tyriar I see warnings in this file. you gotta get your ghooks setup to prevent pushing files with warnings 👎 
+",2016-11-09 07:05:49
+143,"@@ -0,0 +1,147 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++interface Entry<T> {
++	next?: Entry<T>;
++	prev?: Entry<T>;
++	key: string;
++	value: T;
++}
++
++/**
++ * A simple Map<T> that optionally allows to set a limit of entries to store. Once the limit is hit,
++ * the cache will remove the entry that was last recently added.
++ */
++export class LinkedMap<T> {
++	protected map: { [key: string]: Entry<T> };
++	private head: Entry<T>;
++	private tail: Entry<T>;
++	private _size: number;
++
++	constructor(private limit = Number.MAX_VALUE) {
++		this.map = Object.create(null);
++		this._size = 0;
++	}
++
++	public get size(): number {
++		return this._size;
++	}
++
++	public set(key: string, value: T): boolean {
++		if (this.map[key]) {
++			return false; // already present!
++		}
++
++		const entry: Entry<T> = { key, value };
++		this.push(entry);
++
++		if (this._size > this.limit) {","Soon you will end up removing a single item for each new item which is extra cost. Since the limit isn't so hard I would use a load factor, like if 3/4 of limit are reached remove so many items that you at 2/3 usage. That will make you remove less often.
+",2016-05-02 10:11:59
+983,"@@ -0,0 +1,149 @@
++# Auto-detect text files
++* text=auto",":memo: If the repository requires the use of a specific line ending by all users, it can be added to this line, and we can remove everything below except the *exceptions* to this case. However, the preferable case is to not require a specific line ending and instead allow it to be controlled by the user (or automated system) which checks out the code. For example, a build machine which validates line endings (I believe this is ""hygiene"" or something), could use the following configuration without being a noisy neighbor to all other contributors:
+
+```
+git config core.eol lf
+```",2017-06-17 20:30:20
+981,"@@ -0,0 +1,149 @@
++# Auto-detect text files
++* text=auto
++
++# Some source files are edited with LF endings by everyone
++.editorconfig eol=lf
++.eslintrc eol=lf
++.gitignore eol=lf
++.mention-bot eol=lf
++COMMIT_EDITMSG eol=lf
++Dockerfile eol=lf
++git-rebase-todo eol=lf
++LICENSE eol=lf
++makefile eol=lf
++*.c eol=lf
++*.cc eol=lf
++*.clj eol=lf
++*.coffee eol=lf
++*.cpp eol=lf
++*.cs eol=lf
++*.cshtml eol=lf
++*.css eol=lf
++*.desktop eol=lf
++*.diff eol=lf
++*.fs eol=lf
++*.go eol=lf
++*.groovy eol=lf
++*.handlebars eol=lf
++*.hbs eol=lf
++*.hlsl eol=lf
++*.html eol=lf
++*.ini eol=lf
++*.java eol=lf
++*.js eol=lf
++*.json eol=lf
++*.jsx eol=lf
++*.less eol=lf
++*.lua eol=lf
++*.m eol=lf
++*.md eol=lf
++*.opts eol=lf
++*.php eol=lf
++*.pl eol=lf
++*.plist eol=lf
++*.pug eol=lf
++*.py eol=lf
++*.r eol=lf
++*.rb eol=lf
++*.recipe eol=lf
++*.rs eol=lf
++*.scss eol=lf
++*.shader eol=lf
++*.sql eol=lf
++*.svg eol=lf
++*.swift eol=lf
++*.template eol=lf
++*.tmLanguage eol=lf
++*.tmLanguage.base eol=lf
++*.tmTheme eol=lf
++*.ts eol=lf
++*.ts.disabled eol=lf
++*.tsx eol=lf
++*.txt eol=lf
++*.vb eol=lf
++*.vscodeignore eol=lf
++*.xml eol=lf
++*.xpm eol=lf
++*.yaml eol=lf
++*.yml eol=lf
++
++# Some source files are edited with CRLF endings by everyone
++LICENSE.txt eol=crlf
++ThirdPartyNotices.txt eol=crlf
++*.isl eol=crlf
++*.iss eol=crlf
++*.jxs eol=crlf
++
++# Some scripts require specific endings, others use specific in vscode
++*.bat eol=lf",":memo: Normally this would use `eol=crlf`, but the repository is not currently following this convention.",2017-06-17 20:20:18
+982,"@@ -0,0 +1,149 @@
++# Auto-detect text files
++* text=auto
++
++# Some source files are edited with LF endings by everyone
++.editorconfig eol=lf
++.eslintrc eol=lf
++.gitignore eol=lf
++.mention-bot eol=lf
++COMMIT_EDITMSG eol=lf
++Dockerfile eol=lf
++git-rebase-todo eol=lf
++LICENSE eol=lf
++makefile eol=lf
++*.c eol=lf
++*.cc eol=lf
++*.clj eol=lf
++*.coffee eol=lf
++*.cpp eol=lf
++*.cs eol=lf
++*.cshtml eol=lf
++*.css eol=lf
++*.desktop eol=lf
++*.diff eol=lf
++*.fs eol=lf
++*.go eol=lf
++*.groovy eol=lf
++*.handlebars eol=lf
++*.hbs eol=lf
++*.hlsl eol=lf
++*.html eol=lf
++*.ini eol=lf
++*.java eol=lf
++*.js eol=lf
++*.json eol=lf
++*.jsx eol=lf
++*.less eol=lf
++*.lua eol=lf
++*.m eol=lf
++*.md eol=lf
++*.opts eol=lf
++*.php eol=lf
++*.pl eol=lf
++*.plist eol=lf
++*.pug eol=lf
++*.py eol=lf
++*.r eol=lf
++*.rb eol=lf
++*.recipe eol=lf
++*.rs eol=lf
++*.scss eol=lf
++*.shader eol=lf
++*.sql eol=lf
++*.svg eol=lf
++*.swift eol=lf
++*.template eol=lf
++*.tmLanguage eol=lf
++*.tmLanguage.base eol=lf
++*.tmTheme eol=lf
++*.ts eol=lf
++*.ts.disabled eol=lf
++*.tsx eol=lf
++*.txt eol=lf
++*.vb eol=lf
++*.vscodeignore eol=lf
++*.xml eol=lf
++*.xpm eol=lf
++*.yaml eol=lf
++*.yml eol=lf
++
++# Some source files are edited with CRLF endings by everyone
++LICENSE.txt eol=crlf
++ThirdPartyNotices.txt eol=crlf
++*.isl eol=crlf
++*.iss eol=crlf
++*.jxs eol=crlf
++
++# Some scripts require specific endings, others use specific in vscode
++*.bat eol=lf
++*.cmd eol=crlf
++*.ps1 eol=lf",":memo: Normally this would use `eol=crlf`, but the repository is not currently following this convention.",2017-06-17 20:20:29
+693,"@@ -0,0 +1,156 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as strings from 'vs/base/common/strings';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { EditorInput, EditorModel, ITextEditorModel } from 'vs/workbench/common/editor';
++import URI from 'vs/base/common/uri';
++import { IReference } from 'vs/base/common/lifecycle';
++import { telemetryURIDescriptor } from 'vs/platform/telemetry/common/telemetry';
++import { ITextModelResolverService } from 'vs/editor/common/services/resolverService';
++import { IFileService } from 'vs/platform/files/common/files';
++import { marked } from 'vs/base/common/marked/marked';
++import { WALK_THROUGH_SNIPPET_SCHEME } from 'vs/workbench/parts/walkThrough/node/walkThroughContentProvider';
++
++export class WalkThroughModel extends EditorModel {
++
++	constructor(
++		private mainRef: IReference<ITextEditorModel>,
++		private snippetRefs: IReference<ITextEditorModel>[]
++	) {
++		super();
++	}
++
++	get main() {
++		return this.mainRef.object;
++	}
++
++	get snippets() {
++		return this.snippetRefs.map(snippet => snippet.object);
++	}
++
++	dispose() {
++		this.snippetRefs.forEach(ref => ref.dispose());
++		this.mainRef.dispose();
++		super.dispose();
++	}
++}
++
++export class WalkThroughInput extends EditorInput {
++
++	static ID: string = 'workbench.editors.walkThroughInput';
++
++	private promise: TPromise<WalkThroughModel>;
++	private resource: URI;
++
++	private name: string;
++	private description: string;
++
++	constructor(
++		name: string,
++		description: string,
++		resource: URI,
++		public readonly onReady: (container: HTMLElement) => void,
++		@IFileService private fileService: IFileService,",Unused,2017-01-19 06:02:00
+37,"@@ -0,0 +1,159 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import timer = require('vs/base/common/timer');
++import uuid = require('vs/base/common/uuid');
++import strings = require('vs/base/common/strings');
++import {Registry} from 'vs/platform/platform';
++import {IPanel} from 'vs/workbench/common/panel';
++import {EventType as WorkbenchEventType, CompositeEvent} from 'vs/workbench/common/events';
++import {CompositePart} from 'vs/workbench/browser/parts/compositePart';
++import {Panel, PanelRegistry, Extensions as PanelExtensions} from 'vs/workbench/browser/panel';
++import {IPanelService} from 'vs/workbench/services/panel/common/panelService';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
++import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
++import {IEventService} from 'vs/platform/event/common/event';
++import {IMessageService, Severity} from 'vs/platform/message/common/message';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
++
++export class PanelPart extends CompositePart<Panel> implements IPanelService {
++
++	public static activePanelSettingsKey = 'workbench.panelpart.activepanelid';
++
++	public serviceId = IPanelService;
++
++	private blockOpeningPanel: boolean;
++	private currentPanelOpenToken: string;
++
++	constructor(
++		messageService: IMessageService,
++		storageService: IStorageService,
++		eventService: IEventService,
++		telemetryService: ITelemetryService,
++		contextMenuService: IContextMenuService,
++		partService: IPartService,
++		keybindingService: IKeybindingService,
++		id: string
++	) {
++		super(messageService, storageService, eventService, telemetryService, contextMenuService, partService, keybindingService,
++			(<PanelRegistry>Registry.as(PanelExtensions.Panels)), PanelPart.activePanelSettingsKey, id);
++	}
++
++	public openPanel(id: string, focus?: boolean): TPromise<Panel> {
++		if (this.blockOpeningPanel) {","@isidorn I would try to push this down to the compositePart because this seems like lots of duplicated code also in the panelPart. You would then also have just one onCompositeOpen event instead of onViewletOpen and onPanelOpen.
+",2016-01-15 15:11:33
+38,"@@ -0,0 +1,159 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import timer = require('vs/base/common/timer');
++import uuid = require('vs/base/common/uuid');
++import strings = require('vs/base/common/strings');
++import {Registry} from 'vs/platform/platform';
++import {IPanel} from 'vs/workbench/common/panel';
++import {EventType as WorkbenchEventType, CompositeEvent} from 'vs/workbench/common/events';
++import {CompositePart} from 'vs/workbench/browser/parts/compositePart';
++import {Panel, PanelRegistry, Extensions as PanelExtensions} from 'vs/workbench/browser/panel';
++import {IPanelService} from 'vs/workbench/services/panel/common/panelService';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
++import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
++import {IEventService} from 'vs/platform/event/common/event';
++import {IMessageService, Severity} from 'vs/platform/message/common/message';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
++
++export class PanelPart extends CompositePart<Panel> implements IPanelService {
++
++	public static activePanelSettingsKey = 'workbench.panelpart.activepanelid';
++
++	public serviceId = IPanelService;
++
++	private blockOpeningPanel: boolean;
++	private currentPanelOpenToken: string;
++
++	constructor(
++		messageService: IMessageService,
++		storageService: IStorageService,
++		eventService: IEventService,
++		telemetryService: ITelemetryService,
++		contextMenuService: IContextMenuService,
++		partService: IPartService,
++		keybindingService: IKeybindingService,
++		id: string
++	) {
++		super(messageService, storageService, eventService, telemetryService, contextMenuService, partService, keybindingService,
++			(<PanelRegistry>Registry.as(PanelExtensions.Panels)), PanelPart.activePanelSettingsKey, id);
++	}
++
++	public openPanel(id: string, focus?: boolean): TPromise<Panel> {
++		if (this.blockOpeningPanel) {
++			return TPromise.as(null); // Workaround against a potential race condition
++		}
++
++		// First check if panel part is hidden and show if so
++		if (this.partService.isPanelPartHidden()) {
++			try {
++				this.blockOpeningPanel = true;
++				this.partService.setPanelPartHidden(false);
++			} finally {
++				this.blockOpeningPanel = false;
++			}
++		}
++
++		// Check if panel already visible and just focus in that case
++		if (this.activePanel && this.activePanel.getId() === id) {
++			if (focus) {
++				this.activePanel.focus();
++			}
++
++			// Fullfill promise with panel that is being opened
++			return TPromise.as(this.activePanel);
++		}
++
++		// Open
++		return this.doOpenPanel(id, focus);
++	}
++
++	private doOpenPanel(id: string, focus?: boolean): TPromise<Panel> {
++		let timerEvent = timer.start(timer.Topic.WORKBENCH, strings.format('Open Panel {0}', id.substr(id.lastIndexOf('.') + 1)));
++
++		// Use a generated token to avoid race conditions from long running promises
++		let currentPanelOpenToken = uuid.generateUuid();
++		this.currentPanelOpenToken = currentPanelOpenToken;
++
++		// Emit Panel Opening Event
++		this.emit(WorkbenchEventType.PANEL_OPENING, new CompositeEvent(id));
++
++		// Hide current
++		let hidePromise: TPromise<void>;
++		if (this.activePanel) {
++			hidePromise = this.hideActivePanel();
++		} else {
++			hidePromise = TPromise.as(null);
++		}
++
++		return hidePromise.then(() => {
++
++			// Update Title
++			this.updateTitle(id);
++
++			// Create panel
++			return this.createPanel(id, true).then((panel: Panel) => {
++
++				// Check if another panel opened meanwhile and return in that case
++				if ((this.currentPanelOpenToken !== currentPanelOpenToken) || (this.activePanel && this.activePanel.getId() !== panel.getId())) {
++					timerEvent.stop();
++
++					return TPromise.as(null);
++				}
++
++				// Check if panel already visible and just focus in that case
++				if (this.activePanel && this.activePanel.getId() === panel.getId()) {
++					if (focus) {
++						panel.focus();
++					}
++
++					timerEvent.stop();
++
++					// Fullfill promise with panel that is being opened
++					return TPromise.as(panel);
++				}
++
++				// Show Panel and Focus
++				return this.showPanel(panel).then(() => {
++					if (focus) {
++						panel.focus();
++					}
++
++					timerEvent.stop();
++
++					// Fullfill promise with panel that is being opened
++					return panel;
++				});
++			});
++		});
++	}
++
++	private get activePanel(): IPanel {","All of this is super nice and shared.
+",2016-01-15 15:11:53
+459,"@@ -0,0 +1,160 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import fs = require('fs');
++import Uri from 'vs/base/common/uri';
++import { readdirSync } from 'vs/base/node/extfs';
++import { IBackupWorkspacesFormat } from 'vs/platform/backup/common/backup';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {","@Tyriar I suggest to move any service interfaces to `vs/platform`. If you need to distinguish between main and renderer you can call it `IBackupMainService`.
+",2016-11-09 07:02:37
+460,"@@ -0,0 +1,160 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import fs = require('fs');
++import Uri from 'vs/base/common/uri';
++import { readdirSync } from 'vs/base/node/extfs';
++import { IBackupWorkspacesFormat } from 'vs/platform/backup/common/backup';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {
++	_serviceBrand: any;
++
++	/**
++	 * Gets the set of active workspace backup paths being tracked for restoration.
++	 *
++	 * @return The set of active workspace backup paths being tracked for restoration.
++	 */
++	getWorkspaceBackupPathsSync(): string[];
++
++	/**
++	 * Pushes workspace backup paths to be tracked for restoration.
++	 *
++	 * @param workspaces The workspaces to add.
++	 */
++	pushWorkspaceBackupPathsSync(workspaces: Uri[]): void;
++
++	/**
++	 * Removes a workspace backup path being tracked for restoration.
++	 *
++	 * @param workspace The workspace to remove.
++	 */
++	removeWorkspaceBackupPathSync(workspace: Uri): void;
++
++	/**
++	 * Gets the set of untitled file backups for a particular workspace.
++	 *
++	 * @param workspace The workspace to get the backups for.
++	 * @return The absolute paths for all the untitled file _backups_.
++	 */
++	getWorkspaceUntitledFileBackupsSync(workspace: Uri): string[];
++
++	/**
++	 * Gets whether the workspace has backups associated with it (ie. if the workspace backup
++	 * directory exists).
++	 *
++	 * @param workspace The workspace to evaluate.
++	 * @return Whether the workspace has backups.
++	 */
++	doesWorkspaceHaveBackups(workspace: Uri): boolean;","@Tyriar maybe better `hasWorkspaceBackup` or just `hasBackup`
+",2016-11-09 07:04:46
+458,"@@ -0,0 +1,160 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as path from 'path';
++import * as crypto from 'crypto';
++import fs = require('fs');
++import Uri from 'vs/base/common/uri';
++import { readdirSync } from 'vs/base/node/extfs';
++import { IBackupWorkspacesFormat } from 'vs/platform/backup/common/backup';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {
++	_serviceBrand: any;
++
++	/**
++	 * Gets the set of active workspace backup paths being tracked for restoration.
++	 *
++	 * @return The set of active workspace backup paths being tracked for restoration.
++	 */
++	getWorkspaceBackupPathsSync(): string[];
++
++	/**
++	 * Pushes workspace backup paths to be tracked for restoration.
++	 *
++	 * @param workspaces The workspaces to add.
++	 */
++	pushWorkspaceBackupPathsSync(workspaces: Uri[]): void;
++
++	/**
++	 * Removes a workspace backup path being tracked for restoration.
++	 *
++	 * @param workspace The workspace to remove.
++	 */
++	removeWorkspaceBackupPathSync(workspace: Uri): void;
++
++	/**
++	 * Gets the set of untitled file backups for a particular workspace.
++	 *
++	 * @param workspace The workspace to get the backups for.
++	 * @return The absolute paths for all the untitled file _backups_.
++	 */
++	getWorkspaceUntitledFileBackupsSync(workspace: Uri): string[];
++
++	/**
++	 * Gets whether the workspace has backups associated with it (ie. if the workspace backup
++	 * directory exists).
++	 *
++	 * @param workspace The workspace to evaluate.
++	 * @return Whether the workspace has backups.
++	 */
++	doesWorkspaceHaveBackups(workspace: Uri): boolean;
++}
++
++export class BackupService implements IBackupService {
++
++	public _serviceBrand: any;
++
++	protected backupHome: string;
++	protected workspacesJsonPath: string;
++
++	private workspacesJsonContent: IBackupWorkspacesFormat;
++
++	constructor(
++		@IEnvironmentService environmentService: IEnvironmentService
++	) {
++		this.backupHome = environmentService.backupHome;
++		this.workspacesJsonPath = environmentService.backupWorkspacesPath;
++	}
++
++	public getWorkspaceBackupPathsSync(): string[] {
++		this.loadSync();","@Tyriar why the `loadSync` on every method? The main process is a singleton so this should not be needed unless some other process writes to this file (which I would not expect). It should be sufficient to load once, keep in memory and save to disk on each write like we do in `storage.ts`. 
+",2016-11-09 07:01:26
+469,"@@ -0,0 +1,164 @@
++/*---------------------------------------------------------------------------------------------","@Tyriar seeing again lots of warnings in this file
+",2016-11-09 07:32:44
+580,"@@ -0,0 +1,167 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import { IExpression } from 'vs/workbench/parts/debug/common/debug';
++import { IDecorationOptions, IRange, IModel } from 'vs/editor/common/editorCommon';
++import { createStringDictionary, IStringDictionary } from 'vs/base/common/collections';
++import { StandardTokenType } from 'vs/editor/common/core/lineTokens';
++
++export const MAX_INLINE_VALUE_LENGTH = 50; // Max string length of each inline 'x = y' string. If exceeded ... is added
++export const MAX_INLINE_DECORATOR_LENGTH = 150; // Max string length of each inline decorator when debugging. If exceeded ... is added
++export const MAX_NUM_INLINE_VALUES = 100; // JS Global scope can have 700+ entries. We want to limit ourselves for perf reasons
++export const MAX_TOKENIZATION_LINE_LEN = 500; // If line is too long, then inline values for the line are skipped
++export const ELLIPSES = '…';
++// LanguageConfigurationRegistry.getWordDefinition() return regexes that allow spaces and punctuation characters for languages like python
++// Using that approach is not viable so we are using a simple regex to look for word tokens.
++export const WORD_REGEXP = /[\$\_A-Za-z][\$\_A-Za-z0-9]*/g;",For simplicity can we just use the regex \b word boundary character?,2016-12-05 15:12:54
+581,"@@ -0,0 +1,167 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import { IExpression } from 'vs/workbench/parts/debug/common/debug';
++import { IDecorationOptions, IRange, IModel } from 'vs/editor/common/editorCommon';
++import { createStringDictionary, IStringDictionary } from 'vs/base/common/collections';
++import { StandardTokenType } from 'vs/editor/common/core/lineTokens';
++
++export const MAX_INLINE_VALUE_LENGTH = 50; // Max string length of each inline 'x = y' string. If exceeded ... is added
++export const MAX_INLINE_DECORATOR_LENGTH = 150; // Max string length of each inline decorator when debugging. If exceeded ... is added
++export const MAX_NUM_INLINE_VALUES = 100; // JS Global scope can have 700+ entries. We want to limit ourselves for perf reasons
++export const MAX_TOKENIZATION_LINE_LEN = 500; // If line is too long, then inline values for the line are skipped
++export const ELLIPSES = '…';
++// LanguageConfigurationRegistry.getWordDefinition() return regexes that allow spaces and punctuation characters for languages like python
++// Using that approach is not viable so we are using a simple regex to look for word tokens.
++export const WORD_REGEXP = /[\$\_A-Za-z][\$\_A-Za-z0-9]*/g;
++
++export function getNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): IStringDictionary<string> {",This as a 2 dimensional array makes things overly complicated. Please make this one dimensional. Caller of this method could just merge mutliple expression arrays into one,2016-12-05 15:13:48
+579,"@@ -0,0 +1,167 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import { IExpression } from 'vs/workbench/parts/debug/common/debug';
++import { IDecorationOptions, IRange, IModel } from 'vs/editor/common/editorCommon';
++import { createStringDictionary, IStringDictionary } from 'vs/base/common/collections';
++import { StandardTokenType } from 'vs/editor/common/core/lineTokens';
++
++export const MAX_INLINE_VALUE_LENGTH = 50; // Max string length of each inline 'x = y' string. If exceeded ... is added
++export const MAX_INLINE_DECORATOR_LENGTH = 150; // Max string length of each inline decorator when debugging. If exceeded ... is added
++export const MAX_NUM_INLINE_VALUES = 100; // JS Global scope can have 700+ entries. We want to limit ourselves for perf reasons
++export const MAX_TOKENIZATION_LINE_LEN = 500; // If line is too long, then inline values for the line are skipped
++export const ELLIPSES = '…';
++// LanguageConfigurationRegistry.getWordDefinition() return regexes that allow spaces and punctuation characters for languages like python
++// Using that approach is not viable so we are using a simple regex to look for word tokens.
++export const WORD_REGEXP = /[\$\_A-Za-z][\$\_A-Za-z0-9]*/g;
++
++export function getNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): IStringDictionary<string> {
++	const nameValueMap = createStringDictionary<string>();
++	let valueCount = 0;
++
++	for (let expressions of scopeExpressions) {
++		for (let expr of expressions) {
++			// Put ellipses in value if its too long. Preserve last char e.g ""longstr…"" or {a:true, b:true, …}
++			let value = expr.value;
++			if (value && value.length > MAX_INLINE_VALUE_LENGTH) {
++				value = value.substr(0, MAX_INLINE_VALUE_LENGTH - ELLIPSES.length) + ELLIPSES + value[value.length - 1];
++			}
++
++			nameValueMap[expr.name] = value;
++
++			// Limit the size of map. Too large can have a perf impact
++			if (++valueCount >= MAX_NUM_INLINE_VALUES) {
++				return nameValueMap;
++			}
++		}
++	}
++
++	return nameValueMap;
++}
++
++export function getDecorators(nameValueMap: IStringDictionary<string>, wordRangeMap: IStringDictionary<IRange[]>, linesContent: string[]): IDecorationOptions[] {
++	const linesNames = createStringDictionary<IStringDictionary<boolean>>();
++	const names = Object.keys(nameValueMap);
++	const decorators: IDecorationOptions[] = [];
++
++	// Compute unique set of names on each line
++	for (let name of names) {
++		const ranges = wordRangeMap[name];
++		if (ranges) {
++			for (let range of ranges) {
++				const lineNum = range.startLineNumber;
++				if (!linesNames[lineNum]) {
++					linesNames[lineNum] = createStringDictionary<boolean>();
++				}
++				linesNames[lineNum][name] = true;
++			}
++		}
++	}
++
++	// Compute decorators for each line
++	const lineNums = Object.keys(linesNames);
++	for (let lineNum of lineNums) {
++		const uniqueNames = Object.keys(linesNames[lineNum]);
++		const decorator = getDecoratorFromNames(parseInt(lineNum), uniqueNames, nameValueMap, linesContent);
++		decorators.push(decorator);
++	}
++
++	return decorators;
++}
++
++export function getDecoratorFromNames(lineNumber: number, names: string[], nameValueMap: IStringDictionary<string>, linesContent: string[]): IDecorationOptions {
++	const margin = '10px';
++	const backgroundColor = 'rgba(255,200,0,0.2)';",Adding css here is ugly. Is it possible to just add a css class and then style the decorations in debug.contribution.css?,2016-12-05 15:11:04
+577,"@@ -0,0 +1,167 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import { IExpression } from 'vs/workbench/parts/debug/common/debug';
++import { IDecorationOptions, IRange, IModel } from 'vs/editor/common/editorCommon';
++import { createStringDictionary, IStringDictionary } from 'vs/base/common/collections';
++import { StandardTokenType } from 'vs/editor/common/core/lineTokens';
++
++export const MAX_INLINE_VALUE_LENGTH = 50; // Max string length of each inline 'x = y' string. If exceeded ... is added
++export const MAX_INLINE_DECORATOR_LENGTH = 150; // Max string length of each inline decorator when debugging. If exceeded ... is added
++export const MAX_NUM_INLINE_VALUES = 100; // JS Global scope can have 700+ entries. We want to limit ourselves for perf reasons
++export const MAX_TOKENIZATION_LINE_LEN = 500; // If line is too long, then inline values for the line are skipped
++export const ELLIPSES = '…';
++// LanguageConfigurationRegistry.getWordDefinition() return regexes that allow spaces and punctuation characters for languages like python
++// Using that approach is not viable so we are using a simple regex to look for word tokens.
++export const WORD_REGEXP = /[\$\_A-Za-z][\$\_A-Za-z0-9]*/g;
++
++export function getNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): IStringDictionary<string> {
++	const nameValueMap = createStringDictionary<string>();
++	let valueCount = 0;
++
++	for (let expressions of scopeExpressions) {
++		for (let expr of expressions) {
++			// Put ellipses in value if its too long. Preserve last char e.g ""longstr…"" or {a:true, b:true, …}
++			let value = expr.value;
++			if (value && value.length > MAX_INLINE_VALUE_LENGTH) {
++				value = value.substr(0, MAX_INLINE_VALUE_LENGTH - ELLIPSES.length) + ELLIPSES + value[value.length - 1];
++			}
++
++			nameValueMap[expr.name] = value;
++
++			// Limit the size of map. Too large can have a perf impact
++			if (++valueCount >= MAX_NUM_INLINE_VALUES) {
++				return nameValueMap;
++			}
++		}
++	}
++
++	return nameValueMap;
++}
++
++export function getDecorators(nameValueMap: IStringDictionary<string>, wordRangeMap: IStringDictionary<IRange[]>, linesContent: string[]): IDecorationOptions[] {
++	const linesNames = createStringDictionary<IStringDictionary<boolean>>();
++	const names = Object.keys(nameValueMap);
++	const decorators: IDecorationOptions[] = [];
++
++	// Compute unique set of names on each line
++	for (let name of names) {
++		const ranges = wordRangeMap[name];
++		if (ranges) {
++			for (let range of ranges) {
++				const lineNum = range.startLineNumber;
++				if (!linesNames[lineNum]) {
++					linesNames[lineNum] = createStringDictionary<boolean>();
++				}
++				linesNames[lineNum][name] = true;
++			}
++		}
++	}
++
++	// Compute decorators for each line
++	const lineNums = Object.keys(linesNames);
++	for (let lineNum of lineNums) {
++		const uniqueNames = Object.keys(linesNames[lineNum]);
++		const decorator = getDecoratorFromNames(parseInt(lineNum), uniqueNames, nameValueMap, linesContent);
++		decorators.push(decorator);
++	}
++
++	return decorators;
++}
++
++export function getDecoratorFromNames(lineNumber: number, names: string[], nameValueMap: IStringDictionary<string>, linesContent: string[]): IDecorationOptions {
++	const margin = '10px';
++	const backgroundColor = 'rgba(255,200,0,0.2)';
++	const lightForegroundColor = 'rgba(0,0,0,0.5)';
++	const darkForegroundColor = 'rgba(255,255,255,0.5)';
++	const lineLength = linesContent[lineNumber - 1].length;
++
++	// Wrap with 1em unicode space for readability
++	let contentText = '\u2003' + names.map(n => `${n} = ${nameValueMap[n]}`).join(', ') + '\u2003';
++
++	// If decoratorText is too long, trim and add ellipses. This could happen for minified files with everything on a single line
++	if (contentText.length > MAX_INLINE_DECORATOR_LENGTH) {
++		contentText = contentText.substr(0, MAX_INLINE_DECORATOR_LENGTH - ELLIPSES.length) + ELLIPSES;
++	}
++
++	const decorator: IDecorationOptions = {
++		range: {
++			startLineNumber: lineNumber,
++			endLineNumber: lineNumber,
++			startColumn: lineLength,
++			endColumn: lineLength + 1
++		},
++		renderOptions: {
++			dark: {
++				after: {
++					contentText,
++					backgroundColor,
++					color: darkForegroundColor,
++					margin
++				}
++			},
++			light: {
++				after: {
++					contentText,
++					backgroundColor,
++					color: lightForegroundColor,
++					margin
++				}
++			}
++		}
++	};
++
++	return decorator;
++}
++
++export function getEditorWordRangeMap(editorModel: IModel): IStringDictionary<IRange[]> {
++	const wordRangeMap = createStringDictionary<IRange[]>();
++	const linesContent = editorModel.getLinesContent();
++
++	// For every word in every line, map its ranges for fast lookup
++	for (let i = 0, len = linesContent.length; i < len; ++i) {
++		const lineContent = linesContent[i];
++
++		// If line is too long then skip the line
++		if (lineContent.length > MAX_TOKENIZATION_LINE_LEN) {
++			continue;
++		}
++
++		const lineTokens = editorModel.getLineTokens(i + 1); // lineNumbers are 1 based
++
++		for (let j = 0, len = lineTokens.getTokenCount(); j < len; ++j) {
++			let startOffset = lineTokens.getTokenStartOffset(j);
++			let endOffset = lineTokens.getTokenEndOffset(j);
++			const tokenStr = lineContent.substring(startOffset, endOffset);
++
++			// Token is a word and not a comment
++			if (lineTokens.getStandardTokenType(j) !== StandardTokenType.Comment) {",Great that you are using getStandardTokenType() since that is the new recommanded way of handling tokens,2016-12-05 15:04:38
+184,"@@ -0,0 +1,170 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as vscode from 'vscode';
++import * as path from 'path';
++import { ExtensionContext, TextDocumentContentProvider, EventEmitter, Event, Uri, ViewColumn } from ""vscode"";
++
++const hljs = require('highlight.js');
++const mdnh = require('markdown-it-named-headers');
++const md = require('markdown-it')({
++	html: true,
++	highlight: function (str, lang) {
++		if (lang && hljs.getLanguage(lang)) {
++			try {
++				return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
++			} catch (error) { }
++		}
++		return `<pre class=""hljs""><code><div>${md.utils.escapeHtml(str)}</div></code></pre>`;
++	}
++}).use(mdnh, {});","If you don't mind me asking.  As it is coded here, anytime a member wants to add a plugin to markdown-it, it seems they will have to:
+1. `Npm install markdown-it-plugin --savedev` in extensions folder
+2.  Require package here and add package to `.use(...)`
+
+This seems fine to me, but I believe that also means I would have to do this _every_ time that extension is updated.  I don't know of a good solution, but one solution I thought of is to allow for developers to create a ""skeleton"" package that simply exposes and api to the markdown extension that says use this.  So people will be able to install a package, say: `vscode-markdown-it-katex` for math support which has a dependency on this package and it should just work.  Not an ideal solution, but maybe there is a better one?  I could open this as a feature request if you would like to defer this until another cycle.  Or possibly a pull request later on.
+",2016-06-14 18:32:11
+185,"@@ -0,0 +1,170 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as vscode from 'vscode';
++import * as path from 'path';
++import { ExtensionContext, TextDocumentContentProvider, EventEmitter, Event, Uri, ViewColumn } from ""vscode"";
++
++const hljs = require('highlight.js');
++const mdnh = require('markdown-it-named-headers');
++const md = require('markdown-it')({
++	html: true,
++	highlight: function (str, lang) {
++		if (lang && hljs.getLanguage(lang)) {
++			try {
++				return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
++			} catch (error) { }
++		}
++		return `<pre class=""hljs""><code><div>${md.utils.escapeHtml(str)}</div></code></pre>`;
++	}
++}).use(mdnh, {});
++
++export function activate(context: ExtensionContext) {
++	let provider = new MDDocumentContentProvider(context);
++	let registration = vscode.workspace.registerTextDocumentContentProvider('markdown', provider);
++
++	let d1 = vscode.commands.registerCommand('extension.previewMarkdown', () => openPreview());
++	let d2 = vscode.commands.registerCommand('extension.previewMarkdownSide', () => openPreview(true));
++
++	context.subscriptions.push(d1, d2, registration);
++
++	vscode.workspace.onDidSaveTextDocument(document => {
++		if (isMarkdownFile(document)) {
++			const uri = getMarkdownUri(document);
++			provider.update(uri);
++		}
++	});
++
++	vscode.workspace.onDidChangeTextDocument(event => {
++		if (isMarkdownFile(event.document)) {
++			const uri = getMarkdownUri(event.document);
++			provider.update(uri);
++
++		}
++	});
++
++	vscode.workspace.onDidChangeConfiguration(() => {
++		vscode.workspace.textDocuments.forEach((document) => {
++			if (isMarkdownFile) {
++				provider.update(document.uri);
++			}
++		});
++	});
++}
++
++function isMarkdownFile(document: vscode.TextDocument) {
++	return document.languageId === 'markdown'
++		&& document.uri.scheme !== 'markdown'; // prevent processing of own documents
++}
++
++function getMarkdownUri(document: vscode.TextDocument) {
++	return document.uri.with({ scheme: 'markdown', query: document.uri.toString() });
++}
++
++function openPreview(sideBySide?: boolean): void {
++	const activeEditor = vscode.window.activeTextEditor;
++	if (!activeEditor) {
++		vscode.commands.executeCommand('workbench.action.navigateBack');
++		return;
++	}
++
++	let markdownPreviewUri = getMarkdownUri(activeEditor.document);
++	vscode.commands.executeCommand('vscode.previewHtml',
++		markdownPreviewUri,
++		getViewColumn(sideBySide),
++		`Preview '${path.basename(activeEditor.document.fileName)}'`);
++}
++
++function getViewColumn(sideBySide): ViewColumn {
++	const active = vscode.window.activeTextEditor;
++	if (!active) {
++		return ViewColumn.One;
++	}
++
++	if (!sideBySide) {
++		return active.viewColumn;
++	}
++
++	switch (active.viewColumn) {
++		case ViewColumn.One:
++			return ViewColumn.Two;
++		case ViewColumn.Two:
++			return ViewColumn.Three;
++	}
++
++	return active.viewColumn;
++}
++
++
++class MDDocumentContentProvider implements TextDocumentContentProvider {
++	private _context: ExtensionContext;
++	private _onDidChange = new EventEmitter<Uri>();
++
++	constructor(context: ExtensionContext) {
++		this._context = context;
++	}
++
++	private getMediaPath(mediaFile) {
++		return this._context.asAbsolutePath(path.join('media', mediaFile));
++	}
++
++	private fixHref(resource: Uri, href: string) {
++		if (href) {
++			// Return early if href is already a URL
++			if (Uri.parse(href).scheme) {
++				return href;
++			}
++			// Otherwise convert to a file URI by joining the href with the resource location
++			return Uri.file(path.join(path.dirname(resource.fsPath), href)).toString();
++		}
++		return href;
++	}
++
++	private computeCustomStyleSheetIncludes(uri: Uri): string[] {
++		const styles = vscode.workspace.getConfiguration('markdown')['styles'];
++		if (styles && Array.isArray(styles)) {
++			return styles.map((style) => {
++				return `<link rel=""stylesheet"" href=""${this.fixHref(uri, style)}"" type=""text/css"" media=""screen"">`;
++			});
++		}
++		return [];
++	}
++
++	public provideTextDocumentContent(uri: Uri): Thenable<string> {
++
++		return vscode.workspace.openTextDocument(Uri.parse(uri.query)).then(document => {
++			const head = [].concat(
++				'<!DOCTYPE html>',
++				'<html>',
++				'<head>',
++				'<meta http-equiv=""Content-type"" content=""text/html;charset=UTF-8"">',
++				`<link rel=""stylesheet"" type=""text/css"" href=""${this.getMediaPath('markdown.css')}"" >`,
++				`<link rel=""stylesheet"" type=""text/css"" href=""${this.getMediaPath('tomorrow.css')}"" >`,
++				this.computeCustomStyleSheetIncludes(uri),
++				'</head>',
++				'<body>'
++			).join('\n');
++
++			const body = md.render(document.getText());
++
++			const tail = [
++				'</body>',
++				'</html>'
++			].join('\n');
++
++			return head + body + tail;
++		});
++	}
++
++	get onDidChange(): Event<Uri> {
++		return this._onDidChange.event;
++	}
++
++	public update(uri: Uri) {
++		this._onDidChange.fire(uri);","Have you considered a timout here?  Spamming markdown-it may not always be a good idea.  This is more true when you add more plugins like `highlight` and when I was testing for math support `katex`.  I simply did something like:
+
+```
+            if (!this._waiting) {
+                this._waiting = true;
+                setTimeout(() => {
+                    this._waiting = false;
+                    this._onDidChange.fire(uri);
+                }, 300);
+            }
+```
+
+The timeout should probably be modifiable by the user, maybe even default to 0 with a note that for those who may experience problems.
+",2016-06-14 18:42:38
+113,"@@ -0,0 +1,18 @@
++/*---------------------------------------------------------------------------------------------","This file should live in `src/vs/workbench/parts/execution/common/electron-browser/terminal.ts` as it's not usable in a browser. Check out [this wiki page](https://github.com/Microsoft/vscode/blob/master/wiki/contributing/code-organization.md#target-environments) for more information on code organization, basically things in common/ and browser/ need to work both in vscode (under node) and in monaco (on a browser).
+",2016-04-18 16:40:27
+671,"@@ -0,0 +1,18 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as os from 'os';
++import platform = require('vs/base/common/platform');
++import processes = require('vs/base/node/processes');
++
++const powerShellExePath =
++		!process.env.hasOwnProperty('PROCESSOR_ARCHITEW6432')",@daviwil so this is an env variable only available on 64 bit Windows? Would it be better to check `process.arch` instead?,2017-01-14 02:18:24
+111,"@@ -0,0 +1,18 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++import fs = require('fs');
++import env = require('vs/base/common/platform');","`env` -> `platform`, I think the instances where this is `env` are older ones that weren't cleaned up
+",2016-04-18 16:37:36
+112,"@@ -0,0 +1,18 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++import fs = require('fs');
++import env = require('vs/base/common/platform');
++
++export let defaultLinuxTerm = 'x-terminal-emulator';
++
++// if we're not on debian and using gnome then
++// set default to gnome-terminal
++if (env.isLinux
++	&& fs.existsSync('/etc/debian_version') === false
++	&& process.env.DESKTOP_SESSION === 'gnome') {
++	defaultLinuxTerm = 'gnome-terminal';
++}
++
++export const defaultWindowsTerm = 'cmd';","Rename this and `defaultLinuxTerm` as `ALL_CAPS_NAMING`.
+",2016-04-18 16:37:37
+773,"@@ -0,0 +1,184 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { Position, Selection, Range, CompletionItemProvider, CompletionItemKind, TextDocument, CancellationToken, CompletionItem, window, commands, Uri, ProviderResult, TextEditor } from 'vscode';
++
++import { ITypescriptServiceClient } from '../typescriptService';
++import { FileLocationRequestArgs, DocCommandTemplateResponse } from '../protocol';
++
++import * as nls from 'vscode-nls';
++const localize = nls.loadMessageBundle();
++
++const tryCompleteJsDocCommand = '_typeScript.tryCompleteJsDoc';
++
++
++class JsDocCompletionItem extends CompletionItem {
++	constructor(file: Uri, position: Position) {
++		super('/** @param */', CompletionItemKind.Snippet);
++		this.detail = localize('typescript.jsDocCompletionItem.detail', 'Complete JSDoc comment');
++		this.insertText = '';
++		this.command = {
++			title: 'Try Complete Js Doc',
++			command: tryCompleteJsDocCommand,
++			arguments: [file, position]
++		};","You are on very thin ice with this... It is really not recommended to modify the document using  [`CompletionItem#command`](https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2510). Cursor state and undo stack might be get confused by this. 
+
+@mjbvz Any reason why you don't use [`CompletionItem#insertText`](https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2466) and [`CompletionItem#range`](https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2477). You could create a range that encloses the current, partial doc comment, and replace that with the new text",2017-02-22 15:07:44
+774,"@@ -0,0 +1,184 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { Position, Selection, Range, CompletionItemProvider, CompletionItemKind, TextDocument, CancellationToken, CompletionItem, window, commands, Uri, ProviderResult, TextEditor } from 'vscode';
++
++import { ITypescriptServiceClient } from '../typescriptService';
++import { FileLocationRequestArgs, DocCommandTemplateResponse } from '../protocol';
++
++import * as nls from 'vscode-nls';
++const localize = nls.loadMessageBundle();
++
++const tryCompleteJsDocCommand = '_typeScript.tryCompleteJsDoc';
++
++
++class JsDocCompletionItem extends CompletionItem {
++	constructor(file: Uri, position: Position) {
++		super('/** @param */', CompletionItemKind.Snippet);
++		this.detail = localize('typescript.jsDocCompletionItem.detail', 'Complete JSDoc comment');
++		this.insertText = '';
++		this.command = {
++			title: 'Try Complete Js Doc',
++			command: tryCompleteJsDocCommand,
++			arguments: [file, position]
++		};
++	}
++}
++
++export default class JsDocCompletionHelper implements CompletionItemProvider {
++
++	constructor(
++		private client: ITypescriptServiceClient,
++	) {
++		window.onDidChangeTextEditorSelection(e => {
++			if (e.textEditor.document.languageId !== 'typescript'
++				&& e.textEditor.document.languageId !== 'typescriptreact'
++				&& e.textEditor.document.languageId !== 'javascript'
++				&& e.textEditor.document.languageId !== 'javascriptreact'
++			) {
++				return;
++			}
++
++			const selection = e.selections[0];
++			if (!selection.start.isEqual(selection.end)) {
++				return;
++			}
++			if (this.shouldAutoShowJsDocSuggestion(e.textEditor.document, selection.start)) {
++				return commands.executeCommand('editor.action.triggerSuggest');","We have all sorts of commands and settings to trigger suggestions, for instance 24x7 or provider-specific trigger characters. This is somewhat backwards and I wonder why that is needed? This provider could for instance use `*` as trigger character to complete `/**` sequences. It's also being continuously asked for suggestion because the default config is `editor.quickSuggestion: true`. The idea is not trigger yourself but to know when to return something ",2017-02-22 15:10:58
+775,"@@ -0,0 +1,184 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { Position, Selection, Range, CompletionItemProvider, CompletionItemKind, TextDocument, CancellationToken, CompletionItem, window, commands, Uri, ProviderResult, TextEditor } from 'vscode';
++
++import { ITypescriptServiceClient } from '../typescriptService';
++import { FileLocationRequestArgs, DocCommandTemplateResponse } from '../protocol';
++
++import * as nls from 'vscode-nls';
++const localize = nls.loadMessageBundle();
++
++const tryCompleteJsDocCommand = '_typeScript.tryCompleteJsDoc';
++
++
++class JsDocCompletionItem extends CompletionItem {
++	constructor(file: Uri, position: Position) {
++		super('/** @param */', CompletionItemKind.Snippet);
++		this.detail = localize('typescript.jsDocCompletionItem.detail', 'Complete JSDoc comment');
++		this.insertText = '';
++		this.command = {
++			title: 'Try Complete Js Doc',
++			command: tryCompleteJsDocCommand,
++			arguments: [file, position]
++		};
++	}
++}
++
++export default class JsDocCompletionHelper implements CompletionItemProvider {
++
++	constructor(
++		private client: ITypescriptServiceClient,
++	) {
++		window.onDidChangeTextEditorSelection(e => {
++			if (e.textEditor.document.languageId !== 'typescript'
++				&& e.textEditor.document.languageId !== 'typescriptreact'
++				&& e.textEditor.document.languageId !== 'javascript'
++				&& e.textEditor.document.languageId !== 'javascriptreact'
++			) {
++				return;
++			}
++
++			const selection = e.selections[0];
++			if (!selection.start.isEqual(selection.end)) {
++				return;
++			}
++			if (this.shouldAutoShowJsDocSuggestion(e.textEditor.document, selection.start)) {
++				return commands.executeCommand('editor.action.triggerSuggest');
++			}
++			return;
++		});
++
++		commands.registerCommand(
++			tryCompleteJsDocCommand,
++			(file: Uri, position: Position) => this.tryCompleteJsDoc(file, position));
++	}
++
++	public provideCompletionItems(document: TextDocument, position: Position, _token: CancellationToken): ProviderResult<CompletionItem[]> {
++		const file = this.client.normalizePath(document.uri);
++		if (file) {
++			return [new JsDocCompletionItem(document.uri, position)];","Unconditionally returning a completion is causing https://github.com/Microsoft/vscode/issues/21147. Expect this method to be called 'randomly' (see above). Because you cannot control when that happens, the function must check the document/postion for a valid jsdoc-insertion locations and return something falsy else",2017-02-22 15:11:46
+776,"@@ -0,0 +1,184 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { Position, Selection, Range, CompletionItemProvider, CompletionItemKind, TextDocument, CancellationToken, CompletionItem, window, commands, Uri, ProviderResult, TextEditor } from 'vscode';
++
++import { ITypescriptServiceClient } from '../typescriptService';
++import { FileLocationRequestArgs, DocCommandTemplateResponse } from '../protocol';
++
++import * as nls from 'vscode-nls';
++const localize = nls.loadMessageBundle();
++
++const tryCompleteJsDocCommand = '_typeScript.tryCompleteJsDoc';
++
++
++class JsDocCompletionItem extends CompletionItem {
++	constructor(file: Uri, position: Position) {
++		super('/** @param */', CompletionItemKind.Snippet);
++		this.detail = localize('typescript.jsDocCompletionItem.detail', 'Complete JSDoc comment');
++		this.insertText = '';
++		this.command = {
++			title: 'Try Complete Js Doc',
++			command: tryCompleteJsDocCommand,
++			arguments: [file, position]
++		};
++	}
++}
++
++export default class JsDocCompletionHelper implements CompletionItemProvider {
++
++	constructor(
++		private client: ITypescriptServiceClient,
++	) {
++		window.onDidChangeTextEditorSelection(e => {
++			if (e.textEditor.document.languageId !== 'typescript'
++				&& e.textEditor.document.languageId !== 'typescriptreact'
++				&& e.textEditor.document.languageId !== 'javascript'
++				&& e.textEditor.document.languageId !== 'javascriptreact'
++			) {
++				return;
++			}
++
++			const selection = e.selections[0];
++			if (!selection.start.isEqual(selection.end)) {
++				return;
++			}
++			if (this.shouldAutoShowJsDocSuggestion(e.textEditor.document, selection.start)) {
++				return commands.executeCommand('editor.action.triggerSuggest');
++			}
++			return;
++		});
++
++		commands.registerCommand(
++			tryCompleteJsDocCommand,
++			(file: Uri, position: Position) => this.tryCompleteJsDoc(file, position));
++	}
++
++	public provideCompletionItems(document: TextDocument, position: Position, _token: CancellationToken): ProviderResult<CompletionItem[]> {
++		const file = this.client.normalizePath(document.uri);
++		if (file) {
++			return [new JsDocCompletionItem(document.uri, position)];
++		}
++		return [];
++	}
++
++	public resolveCompletionItem(item: CompletionItem, _token: CancellationToken) {
++		return item;
++	}
++
++	private shouldAutoShowJsDocSuggestion(document: TextDocument, position: Position): boolean {
++		const line = document.lineAt(position.line).text;
++
++		// Ensure line starts with '/**' then cursor
++		const prefix = line.slice(0, position.character).match(/^\s*(\/\*\*+)\s*$/);
++		if (prefix === null) {
++			return false;
++		}
++
++		// Ensure there is no content after the cursor besides possibly the end of the comment
++		const suffix = line.slice(position.character).match(/^\s*\**\/?$/);
++		return suffix !== null;
++	}
++
++	/**
++	 * Try to insert a jsdoc comment, using a template provide by typescript
++	 * if possible, otherwise falling back to a default comment format.
++	 */
++	private tryCompleteJsDoc(resource: Uri, position: Position): Thenable<boolean> {
++		const file = this.client.normalizePath(resource);
++		if (!file) {
++			return Promise.resolve(false);
++		}
++
++		const editor = window.activeTextEditor;
++		if (!editor || editor.document.uri.fsPath !== resource.fsPath) {
++			return Promise.resolve(false);
++		}
++
++		return this.prepForDocCompletion(editor, position)
++			.then((start: Position) => {
++				return this.tryInsertJsDocFromTemplate(editor, file, start);
++			})
++			.then((didInsertFromTemplate: boolean) => {
++				if (didInsertFromTemplate) {
++					return true;
++				}
++				return this.tryInsertDefaultDoc(editor, position);
++			});
++	}
++
++	/**
++	 * Prepare the area around the position for insertion of the jsdoc.
++	 *
++	 * Removes any the prefix and suffix of a possible jsdoc
++	 */
++	private prepForDocCompletion(editor: TextEditor, position: Position): Thenable<Position> {
++		const line = editor.document.lineAt(position.line).text;
++		const prefix = line.slice(0, position.character).match(/\/\**\s*$/);
++		const suffix = line.slice(position.character).match(/^\s*\**\//);
++		if (!prefix && !suffix) {
++			// Nothing to remove
++			return Promise.resolve(position);
++		}
++
++		const start = position.translate(0, prefix ? -prefix[0].length : 0);
++		return editor.edit(
++			edits => {
++				edits.delete(new Range(start, position.translate(0, suffix ? suffix[0].length : 0)));
++			}, {
++				undoStopBefore: true,
++				undoStopAfter: false
++			}).then(() => start);
++	}
++
++	private tryInsertJsDocFromTemplate(editor: TextEditor, file: string, position: Position): Promise<boolean> {
++		const args: FileLocationRequestArgs = {
++			file: file,
++			line: position.line + 1,
++			offset: position.character + 1
++		};
++		return this.client.execute('docCommentTemplate', args)
++			.then((res: DocCommandTemplateResponse) => {
++				if (!res || !res.body) {
++					return false;
++				}
++				const commentText = res.body.newText;
++				return editor.edit(
++					edits => edits.insert(position, commentText),
++					{ undoStopBefore: false, undoStopAfter: true });
++			}, () => false)
++			.then((didInsertComment: boolean) => {
++				if (didInsertComment) {
++					const newCursorPosition = new Position(position.line + 1, editor.document.lineAt(position.line + 1).text.length);
++					editor.selection = new Selection(newCursorPosition, newCursorPosition);
++				}
++				return didInsertComment;
++			});
++	}
++
++	/**
++	 * Insert the default JSDoc
++	 */
++	private tryInsertDefaultDoc(editor: TextEditor, position: Position): Thenable<boolean> {
++		const line = editor.document.lineAt(position.line).text;
++		const spaceBefore = line.slice(0, position.character).match(/^\s*$/);",When you use [`SnippetString`](https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L2122) you get indentation for free and you can also define placeholders for params and define the final cursor position.,2017-02-22 15:15:16
+381,"@@ -0,0 +1,2 @@
++Line 1","Line 1: **Awesome**
+",2016-10-23 10:14:11
+382,"@@ -0,0 +1,2 @@
++Line 1
++Line 2","Line 2: **Better Even**
+",2016-10-23 10:14:31
+576,"@@ -0,0 +1,212 @@
++/*---------------------------------------------------------------------------------------------",Awesome that we have tests for this!,2016-12-05 14:55:38
+578,"@@ -0,0 +1,212 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import * as assert from 'assert';
++import { Model as EditorModel } from 'vs/editor/common/model/model';
++import { IExpression } from 'vs/workbench/parts/debug/common/debug';
++import { IRange, IModel } from 'vs/editor/common/editorCommon';
++import { createStringDictionary, IStringDictionary } from 'vs/base/common/collections';
++import { LineTokens, StandardTokenType } from 'vs/editor/common/core/lineTokens';
++import * as inlineDecorators from 'vs/workbench/parts/debug/electron-browser/debugInlineDecorators';
++
++// Test data
++const testLine = 'function doit(everything, is, awesome, awesome, when, youre, part, of, a, team){}';
++
++const testNameValueMap = {
++	everything: '{emmet: true, batman: true, legoUniverse: true}',
++	is: '15',
++	awesome: '""aweeeeeeeeeeeeeeeeeeeeeeeeeeeeeeesome…""',
++	when: 'true',
++	youre: '""Yes I mean you""',
++	part: '""𝄞 ♪ ♫""'
++};
++
++suite('Debug - Inline Value Decorators', () => {
++	test('getNameValueMapFromScopeChildren trims long values', () => {
++		const expressions = [
++			createExpression('hello', 'world'),
++			createExpression('blah', createLongString())
++		];
++
++		const nameValueMap = inlineDecorators.getNameValueMapFromScopeChildren([expressions]);
++
++		// Ensure blah is capped and ellipses added
++		assert.deepEqual(nameValueMap, {
++			hello: 'world',
++			blah: '""blah blah blah blah blah blah blah blah blah bla…""'
++		});
++	});
++
++	test('getNameValueMapFromScopeChildren caps scopes to a MAX_NUM_INLINE_VALUES limit', () => {
++		const scopeChildren: IExpression[][] = new Array(5);
++		const expectedNameValueMap: IStringDictionary<string> = createStringDictionary<string>();
++
++		// 10 Stack Frames with a 100 scope expressions each
++		// JS Global Scope has 700+ expressions so this is close to a real world scenario
++		for (let i = 0; i < scopeChildren.length; i++) {
++			const expressions = new Array(50);
++
++			for (let j = 0; j < expressions.length; ++j) {
++				const name = `name${i}.${j}`;
++				const val = `val${i}.${j}`;
++				expressions[j] = createExpression(name, val);
++
++				if ((i * expressions.length + j) < inlineDecorators.MAX_NUM_INLINE_VALUES) {
++					expectedNameValueMap[name] = val;
++				}
++			}
++
++			scopeChildren[i] = expressions;
++		}
++
++		const nameValueMap = inlineDecorators.getNameValueMapFromScopeChildren(scopeChildren);
++
++		assert.deepEqual(nameValueMap, expectedNameValueMap);
++	});
++
++	test('getDecoratorFromNames caps long decorator afterText', () => {
++		const names = Object.keys(testNameValueMap);
++		const lineNumber = 1;
++		const decorator = inlineDecorators.getDecoratorFromNames(lineNumber, names, testNameValueMap, [testLine]);
++
++		const expectedDecoratorText = ' everything = {emmet: true, batman: true, legoUniverse: true}, is = 15, awesome = ""aweeeeeeeeeeeeeeeeeeeeeeeeeeeeeeesome…"", when = true, youre = ""Yes…';
++		assert.equal(decorator.renderOptions.dark.after.contentText, decorator.renderOptions.light.after.contentText);
++		assert.equal(decorator.renderOptions.dark.after.contentText, expectedDecoratorText);
++		assert.deepEqual(decorator.range, {
++			startLineNumber: lineNumber,
++			endLineNumber: lineNumber,
++			startColumn: testLine.length,
++			endColumn: testLine.length + 1
++		});
++	});
++
++	test('getDecorators returns correct decorator afterText', () => {
++		const lineContent = 'console.log(everything, part, part);'; // part shouldn't be duplicated
++		const lineNumber = 1;
++		const wordRangeMap = updateWordRangeMap(createStringDictionary<IRange[]>(), lineNumber, lineContent);
++		const decorators = inlineDecorators.getDecorators(testNameValueMap, wordRangeMap, [lineContent]);
++		const expectedDecoratorText = ' everything = {emmet: true, batman: true, legoUniverse: true}, part = ""𝄞 ♪ ♫"" ';
++		assert.equal(decorators[0].renderOptions.dark.after.contentText, expectedDecoratorText);
++	});
++
++	test('getEditorWordRangeMap ignores comments and long lines', () => {
++		const expectedWords = 'function, doit, everything, is, awesome, when, youre, part, of, a, team'.split(', ');
++		const editorModel = EditorModel.createFromString(`/** Copyright comment */\n  \n${testLine}\n// Test comment\n${createLongString()}\n`);
++		mockEditorModelLineTokens(editorModel);
++
++		const wordRangeMap = inlineDecorators.getEditorWordRangeMap(editorModel);
++		const words = Object.keys(wordRangeMap);
++		assert.deepEqual(words, expectedWords);
++	});
++});
++
++// Test helpers
++
++function createExpression(name: string, value: string): IExpression {
++	return {
++		name,
++		value,
++		getId: () => name,
++		hasChildren: false,
++		getChildren: null
++	};
++}
++
++function createLongString(): string {
++	let longStr = '';
++	for (let i = 0; i < 100; ++i) {
++		longStr += 'blah blah blah ';
++	}
++	return `""${longStr}""`;
++}
++
++// Simple word range creator that maches wordRegex throughout string
++function updateWordRangeMap(wordRangeMap: IStringDictionary<IRange[]>, lineNumber: number, lineContent: string): IStringDictionary<IRange[]> {
++	const wordRegexp = inlineDecorators.WORD_REGEXP;
++	wordRegexp.lastIndex = 0; // Reset matching
++
++	while (true) {
++		const wordMatch = wordRegexp.exec(lineContent);
++		if (!wordMatch) {
++			break;
++		}
++
++		const word = wordMatch[0];
++		const startOffset = wordMatch.index;
++		const endOffset = startOffset + word.length;
++
++		const range: IRange = {
++			startColumn: startOffset + 1,
++			endColumn: endOffset + 1,
++			startLineNumber: lineNumber,
++			endLineNumber: lineNumber
++		};
++
++		if (!wordRangeMap[word]) {
++			wordRangeMap[word] = [];
++		}
++
++		wordRangeMap[word].push(range);
++	}
++
++	return wordRangeMap;
++}
++
++interface MockToken {
++	tokenType: StandardTokenType;
++	startOffset: number;
++	endOffset: number;
++}
++
++// Simple tokenizer that separates comments from words
++function mockLineTokens(lineContent: string): LineTokens {","I do not think this method is needed. You could instead reuses model.createFromeString and then on that model get line tokens.
+Here's an example [usage](https://github.com/Microsoft/vscode/blob/master/src/vs/editor/test/common/model/textModelWithTokens.test.ts#L283)",2016-12-05 15:08:21
+314,"@@ -0,0 +1,25 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++import Uri from 'vs/base/common/uri';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {
++	_serviceBrand: any;
++
++	getBackupWorkspaces(): string[];","Now I am confused why this guy reaches into the territory of vs/electron-main/backup
+",2016-10-13 15:03:02
+48,"@@ -0,0 +1,257 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {Promise, TPromise} from 'vs/base/common/winjs.base';
++import {IEventEmitter} from 'vs/base/common/eventEmitter';
++import {Dimension, Builder, $} from 'vs/base/browser/builder';
++import {IAction, IActionRunner, Action, ActionRunner} from 'vs/base/common/actions';
++import {IActionItem, ActionsOrientation} from 'vs/base/browser/ui/actionbar/actionbar';
++import {WorkbenchComponent} from 'vs/workbench/common/component';
++import {CompositeEvent} from 'vs/workbench/common/events';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {AsyncDescriptor} from 'vs/platform/instantiation/common/descriptors';
++import {IComposite} from 'vs/workbench/common/composite';
++import {ISelection, Selection} from 'vs/platform/selection/common/selection';
++
++/**
++ * Internal composite events to communicate with composite container.
++ */
++export const EventType = {
++	INTERNAL_COMPOSITE_TITLE_AREA_UPDATE: 'internalCompositeTitleAreaUpdate'
++};
++
++/**
++ * Composites are layed out in the sidebar part of the workbench. Only one composite can be open","@isidorn would rephrase, it is not just sidebar
+",2016-01-19 10:43:33
+194,"@@ -0,0 +1,26 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as Types from 'vs/base/common/types';
++import { AbstractSystemVariables } from 'vs/base/common/parsers';
++import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
++
++export class SettingsVariables extends AbstractSystemVariables {
++	private configuration: any;
++	constructor(private configurationService: IConfigurationService) {
++		super();
++		this.configuration = this.configurationService.getConfiguration();
++	}
++
++	protected resolveString(value: string): string {
++		let regexp = /\$\{settings\.(.*?)\}/g;","I would prefer if you just read the configuration every time you need to resolve the string. 
+Not sure if doing it the current way you can end up with a stale configuration.
+",2016-07-06 08:02:09
+195,"@@ -0,0 +1,26 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as Types from 'vs/base/common/types';
++import { AbstractSystemVariables } from 'vs/base/common/parsers';
++import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
++
++export class SettingsVariables extends AbstractSystemVariables {
++	private configuration: any;
++	constructor(private configurationService: IConfigurationService) {
++		super();
++		this.configuration = this.configurationService.getConfiguration();
++	}
++
++	protected resolveString(value: string): string {
++		let regexp = /\$\{settings\.(.*?)\}/g;
++		return value.replace(regexp, (match: string, name: string) => {
++			let config = this.configuration;
++			let newValue = new Function('_', 'try {return _.' + name + ';} catch (ex) { return """";}')(config);
++			return Types.isString(newValue) ? newValue : '';","We try to avoid using the 'new Function' pattern, is it possible to re-write this using a lambda function - it would read much nicer?
+",2016-07-06 08:03:47
+946,"@@ -0,0 +1,280 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++import * as vscode from 'vscode';
++import * as interfaces from './interfaces';
++import ContentProvider from './contentProvider';
++import * as path from 'path';
++import { loadMessageBundle } from 'vscode-nls';
++const localize = loadMessageBundle();
++
++const messages = {
++	cursorNotInConflict: 'Editor cursor is not within a merge conflict',
++	cursorOnSplitterRange: 'Editor cursor is within the merge conflict splitter, please move it to either the ""current"" or ""incoming"" block',
++	noConflicts: 'No merge conflicts found in this file',
++	noOtherConflictsInThisFile: 'No other merge conflicts within this file'
++};
++
++interface IDocumentMergeConflictNavigationResults {
++	canNavigate: boolean;
++	conflict?: interfaces.IDocumentMergeConflict;
++}
++
++enum NavigationDirection {
++	Forwards,
++	Backwards
++}
++
++export default class CommandHandler implements vscode.Disposable {
++
++	private disposables: vscode.Disposable[] = [];
++
++	constructor(private context: vscode.ExtensionContext, private tracker: interfaces.IDocumentMergeConflictTracker) {
++	}
++
++	begin() {
++		this.disposables.push(
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.current', this.acceptCurrent, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.incoming', this.acceptIncoming, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.selection', this.acceptSelection, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.both', this.acceptBoth, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.all-current', this.acceptAllCurrent, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.all-incoming', this.acceptAllIncoming, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.accept.all-both', this.acceptAllBoth, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.next', this.navigateNext, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.previous', this.navigatePrevious, this),
++			vscode.commands.registerTextEditorCommand('merge-conflict.compare', this.compare, this)
++		);
++	}
++
++	acceptCurrent(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, ...args): Promise<void> {
++		return this.accept(interfaces.CommitType.Current, editor, ...args);
++	}
++
++	acceptIncoming(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, ...args): Promise<void> {
++		return this.accept(interfaces.CommitType.Incoming, editor, ...args);
++	}
++
++	acceptBoth(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, ...args): Promise<void> {
++		return this.accept(interfaces.CommitType.Both, editor, ...args);
++	}
++
++	acceptAllCurrent(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, ...args): Promise<void> {
++		return this.acceptAll(interfaces.CommitType.Current, editor);
++	}
++
++	acceptAllIncoming(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, ...args): Promise<void> {
++		return this.acceptAll(interfaces.CommitType.Incoming, editor);
++	}
++
++	acceptAllBoth(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, ...args): Promise<void> {
++		return this.acceptAll(interfaces.CommitType.Both, editor);
++	}
++
++	async compare(editor: vscode.TextEditor, edit: vscode.TextEditorEdit, conflict: interfaces.IDocumentMergeConflict | null, ...args) {
++		const fileName = path.basename(editor.document.uri.fsPath);
++
++		// No conflict, command executed from command palette
++		if (!conflict) {
++			conflict = await this.findConflictContainingSelection(editor);
++
++			// Still failed to find conflict, warn the user and exit
++			if (!conflict) {
++				vscode.window.showWarningMessage(localize('cursorNotInConflict', messages.cursorNotInConflict));
++				return;
++			}
++		}
++
++		let range = conflict.current.content;
++		const leftUri = editor.document.uri.with({
++			scheme: ContentProvider.scheme,
++			query: JSON.stringify(range)
++		});
++
++		const leftTitle = `Current changes`; // (Ln ${range.start.line}${!range.isSingleLine ? `-${range.end.line}` : ''})`;
++
++		range = conflict.incoming.content;
++		const rightUri = leftUri.with({ query: JSON.stringify(range) });
++
++		const rightTitle = `Incoming changes`; // (Ln${range.start.line}${!range.isSingleLine ? `-${range.end.line}` : ''})`;
++
++		const title = `${fileName}: ${leftTitle} \u2194 ${rightTitle}`;",Maybe inline the two titles and use a placeholder `{0}` to localize like: https://github.com/Microsoft/vscode/blame/master/extensions/git/src/commands.ts#L754,2017-05-23 18:16:30
+207,"@@ -0,0 +1,29 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as Types from 'vs/base/common/types';
++import { SystemVariables } from './systemVariables';
++import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
++import { IWorkbenchEditorService } from 'vs/workbench/services/editor/common/editorService';
++import { IWorkspaceContextService } from 'vs/workbench/services/workspace/common/contextService';
++import URI from 'vs/base/common/uri';
++
++export class ConfigVariables extends SystemVariables {
++	constructor(private configurationService: IConfigurationService, editorService: IWorkbenchEditorService, contextService: IWorkspaceContextService, workspaceRoot: URI = null, envVariables: { [key: string]: string } = process.env) {
++		super(editorService, contextService, workspaceRoot, envVariables);
++	}
++
++	protected resolveString(value: string): string {
++		value = super.resolveString(value);
++","The regexp should have 'config' not 'settings' to allign with other places where we have replacments.
+",2016-07-08 13:56:00
+18,"@@ -0,0 +1,295 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++","Is this actually our copyright and was this copied from some public source?
+",2015-11-27 08:45:20
+19,"@@ -0,0 +1,295 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++export class HTMLTagSpecification {
++	constructor(public label: string, public attributes: string[] = []) {}
++}
++
++// HTML tag information sourced from http://www.w3.org/TR/2015/WD-html51-20151008/
++export const HTML_TAGS : { [tag:string]: HTMLTagSpecification } = {","@Tyriar I meat this. @chrisdias will know how to attribute properly...
+",2015-11-27 11:59:40
+187,"@@ -0,0 +1,30 @@
++## Using Markdown-it Plugins
++
++To use a `markdown-it` plugin, goto the directory containing the `markdown-it` extension.  This will
++be found in the `extensions` folder in your vscode installation.  Install the `markdown-it` plugin
++as a node module.  For example, to install the `KaTeX` markdown-it extension you would simply type:
++
++``` sh
++npm install markdown-it-katex
++```
++
++Next, add the plugin into your [settings configuration](https://code.visualstudio.com/docs/customization/userandworkspace)
++under the `""markdown.plugs""` namespace.  This setting should contain a list for each `markdown-it` extension you wish
++to install.  The list should contain an object describing the name of the module, a list of styles that your extentsion
++may require, and options that you wish to pass to your extension.  For example, while installing the `markdown-it-katex`
++extension we would include this in your settings configuration:
++
++``` json
++    ""markdown.plugins"": [
++        {
++            ""name"": ""markdown-it-katex"",
++            ""styles"": [","Just curious, is it necessary to have separate styling for plugins?
+",2016-06-20 09:59:36
+619,"@@ -0,0 +1,30 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>",Let's leave this as MIT for now as I don't think we use a special license for metadata.,2016-12-16 18:57:04
+618,"@@ -0,0 +1,30 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>
++	<project_license>MIT</project_license>",This can be sourced from `product.licenseName` now.,2016-12-16 18:56:21
+802,"@@ -0,0 +1,32 @@
++<!-- Copyright (C) Microsoft Corporation. All rights reserved. -->
++<!DOCTYPE html>
++<html>
++
++<head>
++	<meta charset=""utf-8"" />
++</head>
++
++<body class=""monaco-shell vs-dark"" aria-label="""">
++	<script>
++		(function () {
++			try {
++				window.location.search.substring(1).split('&').forEach(p => {",Theming here?,2017-03-07 06:34:21
+0,"@@ -0,0 +1,34 @@
++#!/bin/bash
++# This is the install script for installing vs code onto a linux machine
++# Usage: sudo bash linux_install.sh 
++userid=`id -u`
++if [[ $userid -ne 0 ]]
++then
++   echo ""Sorry, you aren't a root user""
++fi
++
++cmd=`mkdir ""/usr/local/vscode/""`
++
++if [[ $cmd -eq 0 ]]; then
++	echo ""folder creation successful""
++else
++	echo ""something went wrong creating folder""
++fi
++
++cmd=`cp vscode.desktop /usr/share/applications`
++
++if [[ $cmd -eq 0 ]]; then
++	echo ""successfully installed app shortcut""
++else
++	echo ""something went wrong with installing app shortcut""
++fi
++
++cmd=`cp -r * /usr/local/vscode/`
++
++if [[ $cmd -eq 0 ]]; then
++	echo ""successfully installed app""
++else
++	echo ""something went wrong with installing app""
++fi
++
++echo 'export PATH=$PATH:/usr/local/vscode' >> ~/.bashrc","NO. You install things into /usr/local, without tracking.
+YOU WRITE THINGS INTO BASHRC!!! And apparently root's bashrc. What about people who don't use bash?
+What's wrong with you?
+
+This code isn't safe, it doesn't have `undo` command and it's tailored for one user only.
+",2015-11-19 20:16:07
+703,"@@ -0,0 +1,35 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { DefaultController, WorkbenchOpenMode, IControllerOptions } from 'vs/base/parts/tree/browser/treeDefaults';
++import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
++
++interface IConfiguration {
++	workbench: {
++		openMode: string;
++	};
++}
++
++export class TreeControllerBase extends DefaultController {
++	constructor(
++		options: IControllerOptions,",Suggest to make options optional so that not everyone has to repeat the `ClickBehaviour` setting and rather benefit from the default which is `onMouseUp`.,2017-01-20 11:58:57
+139,"@@ -0,0 +1,37 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import {Action} from 'vs/base/common/actions';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IPanelService} from 'vs/workbench/services/panel/common/panelService';
++import {TERMINAL_PANEL_ID, ITerminalService} from 'vs/workbench/parts/terminal/common/terminal';
++
++export class ToggleTerminalAction extends Action {
++
++	public static ID = 'workbench.action.terminal.toggleTerminal';
++	public static LABEL = nls.localize('toggleTerminal', ""(Experimental) Toggle Terminal"");
++
++	constructor(
++		id: string, label: string,
++		@IPartService private partService: IPartService,
++		@IPanelService private panelService: IPanelService,
++		@ITerminalService private terminalService: ITerminalService
++	) {
++		super(id, label);
++	}
++
++	public run(event?: any): TPromise<any> {
++		const panel = this.panelService.getActivePanel();
++		if (panel && panel.getId() === TERMINAL_PANEL_ID) {
++			this.partService.setPanelHidden(true);
++
++			return TPromise.as(null);
++		}
++
++		return this.terminalService.show();","that's my point about the terminal service. it doesn't make you not have a dependency on the panel service to which it is just a slim wrapper nor does it make you keep the panel id private
+",2016-04-29 15:13:40
+401,"@@ -0,0 +1,44 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { TreeExplorerNodeProvider } from 'vscode';
++
++export class InternalTreeExplorerNode implements TreeExplorerNodeContent {","Why not just TreeExplorerNode?
+",2016-10-24 15:32:14
+420,"@@ -0,0 +1,44 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { TreeExplorerNodeProvider } from 'vscode';
++
++export class InternalTreeExplorerNode implements TreeExplorerNodeContent {
++	static idCounter = 1;","Should not be public
+",2016-10-24 15:59:17
+419,"@@ -0,0 +1,44 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { TreeExplorerNodeProvider } from 'vscode';
++
++export class InternalTreeExplorerNode implements TreeExplorerNodeContent {
++	static idCounter = 1;
++
++	id: number;
++
++	label: string = 'label';","Why does this default to `'label'`?
+",2016-10-24 15:58:58
+402,"@@ -0,0 +1,44 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { TreeExplorerNodeProvider } from 'vscode';
++
++export class InternalTreeExplorerNode implements TreeExplorerNodeContent {
++	static idCounter = 1;
++
++	id: number;
++
++	label: string = 'label';
++	hasChildren: boolean = true;
++	clickCommand: string = null;
++
++	constructor(node: any, provider: TreeExplorerNodeProvider<any>) {
++		this.id = InternalTreeExplorerNode.idCounter++;
++
++		if (provider.getLabel) {
++			this.label = provider.getLabel(node);
++		}
++		if (provider.getHasChildren) {
++			this.hasChildren = provider.getHasChildren(node);
++		}
++		if (provider.getClickCommand) {
++			this.clickCommand = provider.getClickCommand(node);
++		}
++	}
++}
++
++export interface InternalTreeExplorerNodeProvider {","Why not just TreeExplorerNodeProvider?
+",2016-10-24 15:32:22
+33,"@@ -0,0 +1,441 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import {Registry} from 'vs/platform/platform';
++import {IDisposable} from 'vs/base/common/lifecycle';
++import {Dimension, Builder, $} from 'vs/base/browser/builder';
++import events = require('vs/base/common/events');
++import strings = require('vs/base/common/strings');
++import types = require('vs/base/common/types');
++import errors = require('vs/base/common/errors');
++import {CONTEXT as ToolBarContext, ToolBar} from 'vs/base/browser/ui/toolbar/toolbar';
++import {IActionItem, ActionsOrientation} from 'vs/base/browser/ui/actionbar/actionbar';
++import {ProgressBar} from 'vs/base/browser/ui/progressbar/progressbar';
++import {Scope, IActionBarRegistry, Extensions, prepareActions} from 'vs/workbench/browser/actionBarRegistry';
++import {Action, IAction} from 'vs/base/common/actions';
++import {Part} from 'vs/workbench/browser/part';
++import {Composite, CompositeDescriptor, CompositeRegistry} from 'vs/workbench/browser/composite';
++import {IComposite} from 'vs/workbench/common/composite';
++import {EventType as WorkbenchEventType, CompositeEvent} from 'vs/workbench/common/events';
++import {EventType as CompositeEventType} from 'vs/workbench/browser/composite';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {WorkbenchProgressService} from 'vs/workbench/services/progress/browser/progressService';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
++import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
++import {IEventService} from 'vs/platform/event/common/event';
++import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
++import {IMessageService, Severity} from 'vs/platform/message/common/message';
++import {IProgressService} from 'vs/platform/progress/common/progress';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
++
++export abstract class CompositePart<T extends Composite> extends Part {
++
++	private instantiationService: IInstantiationService;
++	private activeCompositeListeners: { (): void; }[];
++	private instantiatedCompositeListeners: { (): void; }[];
++	private mapCompositeToCompositeContainer: { [compositeId: string]: Builder; };
++	private mapActionsBindingToComposite: { [compositeId: string]: () => void; };
++	private mapProgressServiceToComposite: { [compositeId: string]: IProgressService; };
++	private activeComposite: Composite;
++	private lastActiveCompositeId: string;
++	private instantiatedComposits: Composite[];
++	private titleLabel: Builder;
++	private toolBar: ToolBar;
++	private compositeLoaderPromises: { [compositeId: string]: TPromise<Composite>; };
++	private progressBar: ProgressBar;
++	private contentAreaSize: Dimension;
++	private telemetryActionsListener: IDisposable;
++
++	constructor(
++		private messageService: IMessageService,
++		private storageService: IStorageService,
++		private eventService: IEventService,
++		private telemetryService: ITelemetryService,
++		private contextMenuService: IContextMenuService,
++		protected partService: IPartService,
++		private keybindingService: IKeybindingService,
++		private registry: CompositeRegistry<T>,
++		private activeCompositeSettingsKey: string,
++		id: string
++	) {
++		super(id);
++
++		this.activeCompositeListeners = [];
++		this.instantiatedCompositeListeners = [];
++		this.mapCompositeToCompositeContainer = {};
++		this.mapActionsBindingToComposite = {};
++		this.mapProgressServiceToComposite = {};
++		this.activeComposite = null;
++		this.instantiatedComposits = [];
++		this.compositeLoaderPromises = {};
++	}
++
++	public setInstantiationService(service: IInstantiationService): void {
++		this.instantiationService = service;
++	}
++
++	protected createComposite(id: string, isActive?: boolean): TPromise<Composite> {
++
++		// Check if composite is already created
++		for (let i = 0; i < this.instantiatedComposits.length; i++) {
++			if (this.instantiatedComposits[i].getId() === id) {
++				return TPromise.as(this.instantiatedComposits[i]);
++			}
++		}
++
++		// Instantiate composite from registry otherwise
++		let compositeDescriptor = this.registry.getComposite(id);
++		if (compositeDescriptor) {
++			let loaderPromise = this.compositeLoaderPromises[id];
++			if (!loaderPromise) {
++				let progressService = new WorkbenchProgressService(this.eventService, this.progressBar, compositeDescriptor.id, isActive);
++				let services = {
++					progressService: progressService
++				};
++				let compositeInstantiationService = this.instantiationService.createChild(services);
++
++				loaderPromise = compositeInstantiationService.createInstance(compositeDescriptor).then((composite: Composite) => {
++					this.mapProgressServiceToComposite[composite.getId()] = progressService;
++
++					// Remember as Instantiated
++					this.instantiatedComposits.push(composite);
++
++					// Register to title area update events from the composite
++					this.instantiatedCompositeListeners.push(composite.addListener(CompositeEventType.INTERNAL_COMPOSITE_TITLE_AREA_UPDATE, (e) => { this.onTitleAreaUpdate(e); }));
++
++					// Remove from Promises Cache since Loaded
++					delete this.compositeLoaderPromises[id];
++
++					return composite;
++				});
++
++				// Report progress for slow loading composits
++				progressService.showWhile(loaderPromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++
++				// Add to Promise Cache until Loaded
++				this.compositeLoaderPromises[id] = loaderPromise;
++			}
++
++			return loaderPromise;
++		}
++
++		throw new Error(strings.format('Unable to find composite with id {0}', id));
++	}
++
++	protected showComposite(composite: Composite): TPromise<void> {
++
++		// Remember Composite
++		this.activeComposite = composite;
++
++		// Store in preferences
++		this.storageService.store(this.activeCompositeSettingsKey, this.activeComposite.getId(), StorageScope.WORKSPACE);
++
++		// Remember
++		this.lastActiveCompositeId = this.activeComposite.getId();
++
++		// Register as Emitter to Workbench Bus
++		this.activeCompositeListeners.push(this.eventService.addEmitter(this.activeComposite, this.activeComposite.getId()));
++
++		let createCompositePromise: TPromise<void>;
++
++		// Composits created for the first time
++		let compositeContainer = this.mapCompositeToCompositeContainer[composite.getId()];
++		if (!compositeContainer) {
++
++			// Build Container off-DOM
++			compositeContainer = $().div({
++				'class': 'viewlet',","@isidorn this should probably be passed in from the outside so that we can tweak the CSS for viewlets and panels separately.
+",2016-01-15 15:05:40
+34,"@@ -0,0 +1,441 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import {Registry} from 'vs/platform/platform';
++import {IDisposable} from 'vs/base/common/lifecycle';
++import {Dimension, Builder, $} from 'vs/base/browser/builder';
++import events = require('vs/base/common/events');
++import strings = require('vs/base/common/strings');
++import types = require('vs/base/common/types');
++import errors = require('vs/base/common/errors');
++import {CONTEXT as ToolBarContext, ToolBar} from 'vs/base/browser/ui/toolbar/toolbar';
++import {IActionItem, ActionsOrientation} from 'vs/base/browser/ui/actionbar/actionbar';
++import {ProgressBar} from 'vs/base/browser/ui/progressbar/progressbar';
++import {Scope, IActionBarRegistry, Extensions, prepareActions} from 'vs/workbench/browser/actionBarRegistry';
++import {Action, IAction} from 'vs/base/common/actions';
++import {Part} from 'vs/workbench/browser/part';
++import {Composite, CompositeDescriptor, CompositeRegistry} from 'vs/workbench/browser/composite';
++import {IComposite} from 'vs/workbench/common/composite';
++import {EventType as WorkbenchEventType, CompositeEvent} from 'vs/workbench/common/events';
++import {EventType as CompositeEventType} from 'vs/workbench/browser/composite';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {WorkbenchProgressService} from 'vs/workbench/services/progress/browser/progressService';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
++import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
++import {IEventService} from 'vs/platform/event/common/event';
++import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
++import {IMessageService, Severity} from 'vs/platform/message/common/message';
++import {IProgressService} from 'vs/platform/progress/common/progress';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
++
++export abstract class CompositePart<T extends Composite> extends Part {
++
++	private instantiationService: IInstantiationService;
++	private activeCompositeListeners: { (): void; }[];
++	private instantiatedCompositeListeners: { (): void; }[];
++	private mapCompositeToCompositeContainer: { [compositeId: string]: Builder; };
++	private mapActionsBindingToComposite: { [compositeId: string]: () => void; };
++	private mapProgressServiceToComposite: { [compositeId: string]: IProgressService; };
++	private activeComposite: Composite;
++	private lastActiveCompositeId: string;
++	private instantiatedComposits: Composite[];
++	private titleLabel: Builder;
++	private toolBar: ToolBar;
++	private compositeLoaderPromises: { [compositeId: string]: TPromise<Composite>; };
++	private progressBar: ProgressBar;
++	private contentAreaSize: Dimension;
++	private telemetryActionsListener: IDisposable;
++
++	constructor(
++		private messageService: IMessageService,
++		private storageService: IStorageService,
++		private eventService: IEventService,
++		private telemetryService: ITelemetryService,
++		private contextMenuService: IContextMenuService,
++		protected partService: IPartService,
++		private keybindingService: IKeybindingService,
++		private registry: CompositeRegistry<T>,
++		private activeCompositeSettingsKey: string,
++		id: string
++	) {
++		super(id);
++
++		this.activeCompositeListeners = [];
++		this.instantiatedCompositeListeners = [];
++		this.mapCompositeToCompositeContainer = {};
++		this.mapActionsBindingToComposite = {};
++		this.mapProgressServiceToComposite = {};
++		this.activeComposite = null;
++		this.instantiatedComposits = [];
++		this.compositeLoaderPromises = {};
++	}
++
++	public setInstantiationService(service: IInstantiationService): void {
++		this.instantiationService = service;
++	}
++
++	protected createComposite(id: string, isActive?: boolean): TPromise<Composite> {
++
++		// Check if composite is already created
++		for (let i = 0; i < this.instantiatedComposits.length; i++) {
++			if (this.instantiatedComposits[i].getId() === id) {
++				return TPromise.as(this.instantiatedComposits[i]);
++			}
++		}
++
++		// Instantiate composite from registry otherwise
++		let compositeDescriptor = this.registry.getComposite(id);
++		if (compositeDescriptor) {
++			let loaderPromise = this.compositeLoaderPromises[id];
++			if (!loaderPromise) {
++				let progressService = new WorkbenchProgressService(this.eventService, this.progressBar, compositeDescriptor.id, isActive);
++				let services = {
++					progressService: progressService
++				};
++				let compositeInstantiationService = this.instantiationService.createChild(services);
++
++				loaderPromise = compositeInstantiationService.createInstance(compositeDescriptor).then((composite: Composite) => {
++					this.mapProgressServiceToComposite[composite.getId()] = progressService;
++
++					// Remember as Instantiated
++					this.instantiatedComposits.push(composite);
++
++					// Register to title area update events from the composite
++					this.instantiatedCompositeListeners.push(composite.addListener(CompositeEventType.INTERNAL_COMPOSITE_TITLE_AREA_UPDATE, (e) => { this.onTitleAreaUpdate(e); }));
++
++					// Remove from Promises Cache since Loaded
++					delete this.compositeLoaderPromises[id];
++
++					return composite;
++				});
++
++				// Report progress for slow loading composits
++				progressService.showWhile(loaderPromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++
++				// Add to Promise Cache until Loaded
++				this.compositeLoaderPromises[id] = loaderPromise;
++			}
++
++			return loaderPromise;
++		}
++
++		throw new Error(strings.format('Unable to find composite with id {0}', id));
++	}
++
++	protected showComposite(composite: Composite): TPromise<void> {
++
++		// Remember Composite
++		this.activeComposite = composite;
++
++		// Store in preferences
++		this.storageService.store(this.activeCompositeSettingsKey, this.activeComposite.getId(), StorageScope.WORKSPACE);
++
++		// Remember
++		this.lastActiveCompositeId = this.activeComposite.getId();
++
++		// Register as Emitter to Workbench Bus
++		this.activeCompositeListeners.push(this.eventService.addEmitter(this.activeComposite, this.activeComposite.getId()));
++
++		let createCompositePromise: TPromise<void>;
++
++		// Composits created for the first time
++		let compositeContainer = this.mapCompositeToCompositeContainer[composite.getId()];
++		if (!compositeContainer) {
++
++			// Build Container off-DOM
++			compositeContainer = $().div({
++				'class': 'viewlet',
++				id: composite.getId()
++			}, (div: Builder) => {
++				createCompositePromise = composite.create(div);
++			});
++
++			// Remember composite container
++			this.mapCompositeToCompositeContainer[composite.getId()] = compositeContainer;
++		}
++
++		// Composite already exists but is hidden
++		else {
++			createCompositePromise = TPromise.as(null);
++		}
++
++		// Report progress for slow loading composits (but only if we did not create the composits before already)
++		let progressService = this.mapProgressServiceToComposite[composite.getId()];
++		if (progressService && !compositeContainer) {
++			this.mapProgressServiceToComposite[composite.getId()].showWhile(createCompositePromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++		}
++
++		// Fill Content and Actions
++		return createCompositePromise.then(() => {
++
++			// Make sure that the user meanwhile did not open another composite or closed the sidebar","@isidorn sidebar reference in comment
+",2016-01-15 15:06:09
+35,"@@ -0,0 +1,441 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import {Registry} from 'vs/platform/platform';
++import {IDisposable} from 'vs/base/common/lifecycle';
++import {Dimension, Builder, $} from 'vs/base/browser/builder';
++import events = require('vs/base/common/events');
++import strings = require('vs/base/common/strings');
++import types = require('vs/base/common/types');
++import errors = require('vs/base/common/errors');
++import {CONTEXT as ToolBarContext, ToolBar} from 'vs/base/browser/ui/toolbar/toolbar';
++import {IActionItem, ActionsOrientation} from 'vs/base/browser/ui/actionbar/actionbar';
++import {ProgressBar} from 'vs/base/browser/ui/progressbar/progressbar';
++import {Scope, IActionBarRegistry, Extensions, prepareActions} from 'vs/workbench/browser/actionBarRegistry';
++import {Action, IAction} from 'vs/base/common/actions';
++import {Part} from 'vs/workbench/browser/part';
++import {Composite, CompositeDescriptor, CompositeRegistry} from 'vs/workbench/browser/composite';
++import {IComposite} from 'vs/workbench/common/composite';
++import {EventType as WorkbenchEventType, CompositeEvent} from 'vs/workbench/common/events';
++import {EventType as CompositeEventType} from 'vs/workbench/browser/composite';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {WorkbenchProgressService} from 'vs/workbench/services/progress/browser/progressService';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
++import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
++import {IEventService} from 'vs/platform/event/common/event';
++import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
++import {IMessageService, Severity} from 'vs/platform/message/common/message';
++import {IProgressService} from 'vs/platform/progress/common/progress';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
++
++export abstract class CompositePart<T extends Composite> extends Part {
++
++	private instantiationService: IInstantiationService;
++	private activeCompositeListeners: { (): void; }[];
++	private instantiatedCompositeListeners: { (): void; }[];
++	private mapCompositeToCompositeContainer: { [compositeId: string]: Builder; };
++	private mapActionsBindingToComposite: { [compositeId: string]: () => void; };
++	private mapProgressServiceToComposite: { [compositeId: string]: IProgressService; };
++	private activeComposite: Composite;
++	private lastActiveCompositeId: string;
++	private instantiatedComposits: Composite[];
++	private titleLabel: Builder;
++	private toolBar: ToolBar;
++	private compositeLoaderPromises: { [compositeId: string]: TPromise<Composite>; };
++	private progressBar: ProgressBar;
++	private contentAreaSize: Dimension;
++	private telemetryActionsListener: IDisposable;
++
++	constructor(
++		private messageService: IMessageService,
++		private storageService: IStorageService,
++		private eventService: IEventService,
++		private telemetryService: ITelemetryService,
++		private contextMenuService: IContextMenuService,
++		protected partService: IPartService,
++		private keybindingService: IKeybindingService,
++		private registry: CompositeRegistry<T>,
++		private activeCompositeSettingsKey: string,
++		id: string
++	) {
++		super(id);
++
++		this.activeCompositeListeners = [];
++		this.instantiatedCompositeListeners = [];
++		this.mapCompositeToCompositeContainer = {};
++		this.mapActionsBindingToComposite = {};
++		this.mapProgressServiceToComposite = {};
++		this.activeComposite = null;
++		this.instantiatedComposits = [];
++		this.compositeLoaderPromises = {};
++	}
++
++	public setInstantiationService(service: IInstantiationService): void {
++		this.instantiationService = service;
++	}
++
++	protected createComposite(id: string, isActive?: boolean): TPromise<Composite> {
++
++		// Check if composite is already created
++		for (let i = 0; i < this.instantiatedComposits.length; i++) {
++			if (this.instantiatedComposits[i].getId() === id) {
++				return TPromise.as(this.instantiatedComposits[i]);
++			}
++		}
++
++		// Instantiate composite from registry otherwise
++		let compositeDescriptor = this.registry.getComposite(id);
++		if (compositeDescriptor) {
++			let loaderPromise = this.compositeLoaderPromises[id];
++			if (!loaderPromise) {
++				let progressService = new WorkbenchProgressService(this.eventService, this.progressBar, compositeDescriptor.id, isActive);
++				let services = {
++					progressService: progressService
++				};
++				let compositeInstantiationService = this.instantiationService.createChild(services);
++
++				loaderPromise = compositeInstantiationService.createInstance(compositeDescriptor).then((composite: Composite) => {
++					this.mapProgressServiceToComposite[composite.getId()] = progressService;
++
++					// Remember as Instantiated
++					this.instantiatedComposits.push(composite);
++
++					// Register to title area update events from the composite
++					this.instantiatedCompositeListeners.push(composite.addListener(CompositeEventType.INTERNAL_COMPOSITE_TITLE_AREA_UPDATE, (e) => { this.onTitleAreaUpdate(e); }));
++
++					// Remove from Promises Cache since Loaded
++					delete this.compositeLoaderPromises[id];
++
++					return composite;
++				});
++
++				// Report progress for slow loading composits
++				progressService.showWhile(loaderPromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++
++				// Add to Promise Cache until Loaded
++				this.compositeLoaderPromises[id] = loaderPromise;
++			}
++
++			return loaderPromise;
++		}
++
++		throw new Error(strings.format('Unable to find composite with id {0}', id));
++	}
++
++	protected showComposite(composite: Composite): TPromise<void> {
++
++		// Remember Composite
++		this.activeComposite = composite;
++
++		// Store in preferences
++		this.storageService.store(this.activeCompositeSettingsKey, this.activeComposite.getId(), StorageScope.WORKSPACE);
++
++		// Remember
++		this.lastActiveCompositeId = this.activeComposite.getId();
++
++		// Register as Emitter to Workbench Bus
++		this.activeCompositeListeners.push(this.eventService.addEmitter(this.activeComposite, this.activeComposite.getId()));
++
++		let createCompositePromise: TPromise<void>;
++
++		// Composits created for the first time
++		let compositeContainer = this.mapCompositeToCompositeContainer[composite.getId()];
++		if (!compositeContainer) {
++
++			// Build Container off-DOM
++			compositeContainer = $().div({
++				'class': 'viewlet',
++				id: composite.getId()
++			}, (div: Builder) => {
++				createCompositePromise = composite.create(div);
++			});
++
++			// Remember composite container
++			this.mapCompositeToCompositeContainer[composite.getId()] = compositeContainer;
++		}
++
++		// Composite already exists but is hidden
++		else {
++			createCompositePromise = TPromise.as(null);
++		}
++
++		// Report progress for slow loading composits (but only if we did not create the composits before already)
++		let progressService = this.mapProgressServiceToComposite[composite.getId()];
++		if (progressService && !compositeContainer) {
++			this.mapProgressServiceToComposite[composite.getId()].showWhile(createCompositePromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++		}
++
++		// Fill Content and Actions
++		return createCompositePromise.then(() => {
++
++			// Make sure that the user meanwhile did not open another composite or closed the sidebar
++			if (!this.activeComposite || composite.getId() !== this.activeComposite.getId()) {
++				return;
++			}
++
++			// Take Composite on-DOM and show
++			compositeContainer.build(this.getContentArea());
++			compositeContainer.show();
++
++			// Setup action runner
++			this.toolBar.actionRunner = composite.getActionRunner();
++
++			// Update title with composite title if it differs from descriptor
++			let descriptor = this.registry.getComposite(composite.getId());
++			if (descriptor && descriptor.name !== composite.getTitle()) {
++				this.updateTitle(composite.getId(), composite.getTitle());
++			}
++
++			// Handle Composite Actions
++			let actionsBinding = this.mapActionsBindingToComposite[composite.getId()];
++			if (!actionsBinding) {
++				actionsBinding = this.collectCompositeActions(composite);
++				this.mapActionsBindingToComposite[composite.getId()] = actionsBinding;
++			}
++			actionsBinding();
++
++			if (this.telemetryActionsListener) {
++				this.telemetryActionsListener.dispose();
++				this.telemetryActionsListener = null;
++			}
++
++			// Action Run Handling
++			this.telemetryActionsListener = this.toolBar.actionRunner.addListener2(events.EventType.RUN, (e: any) => {
++
++				// Check for Error
++				if (e.error && !errors.isPromiseCanceledError(e.error)) {
++					this.messageService.show(Severity.Error, e.error);
++				}
++
++				// Log in telemetry
++				if (this.telemetryService) {
++					this.telemetryService.publicLog('workbenchActionExecuted', { id: e.action.id, from: 'sideBar' });","@isidorn the ""from: sideBar"" value should be passed in from the subclass of the part
+",2016-01-15 15:06:48
+36,"@@ -0,0 +1,441 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import {Registry} from 'vs/platform/platform';
++import {IDisposable} from 'vs/base/common/lifecycle';
++import {Dimension, Builder, $} from 'vs/base/browser/builder';
++import events = require('vs/base/common/events');
++import strings = require('vs/base/common/strings');
++import types = require('vs/base/common/types');
++import errors = require('vs/base/common/errors');
++import {CONTEXT as ToolBarContext, ToolBar} from 'vs/base/browser/ui/toolbar/toolbar';
++import {IActionItem, ActionsOrientation} from 'vs/base/browser/ui/actionbar/actionbar';
++import {ProgressBar} from 'vs/base/browser/ui/progressbar/progressbar';
++import {Scope, IActionBarRegistry, Extensions, prepareActions} from 'vs/workbench/browser/actionBarRegistry';
++import {Action, IAction} from 'vs/base/common/actions';
++import {Part} from 'vs/workbench/browser/part';
++import {Composite, CompositeDescriptor, CompositeRegistry} from 'vs/workbench/browser/composite';
++import {IComposite} from 'vs/workbench/common/composite';
++import {EventType as WorkbenchEventType, CompositeEvent} from 'vs/workbench/common/events';
++import {EventType as CompositeEventType} from 'vs/workbench/browser/composite';
++import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
++import {WorkbenchProgressService} from 'vs/workbench/services/progress/browser/progressService';
++import {IPartService} from 'vs/workbench/services/part/common/partService';
++import {IStorageService, StorageScope} from 'vs/platform/storage/common/storage';
++import {IContextMenuService} from 'vs/platform/contextview/browser/contextView';
++import {IEventService} from 'vs/platform/event/common/event';
++import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
++import {IMessageService, Severity} from 'vs/platform/message/common/message';
++import {IProgressService} from 'vs/platform/progress/common/progress';
++import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
++import {IKeybindingService} from 'vs/platform/keybinding/common/keybindingService';
++
++export abstract class CompositePart<T extends Composite> extends Part {
++
++	private instantiationService: IInstantiationService;
++	private activeCompositeListeners: { (): void; }[];
++	private instantiatedCompositeListeners: { (): void; }[];
++	private mapCompositeToCompositeContainer: { [compositeId: string]: Builder; };
++	private mapActionsBindingToComposite: { [compositeId: string]: () => void; };
++	private mapProgressServiceToComposite: { [compositeId: string]: IProgressService; };
++	private activeComposite: Composite;
++	private lastActiveCompositeId: string;
++	private instantiatedComposits: Composite[];
++	private titleLabel: Builder;
++	private toolBar: ToolBar;
++	private compositeLoaderPromises: { [compositeId: string]: TPromise<Composite>; };
++	private progressBar: ProgressBar;
++	private contentAreaSize: Dimension;
++	private telemetryActionsListener: IDisposable;
++
++	constructor(
++		private messageService: IMessageService,
++		private storageService: IStorageService,
++		private eventService: IEventService,
++		private telemetryService: ITelemetryService,
++		private contextMenuService: IContextMenuService,
++		protected partService: IPartService,
++		private keybindingService: IKeybindingService,
++		private registry: CompositeRegistry<T>,
++		private activeCompositeSettingsKey: string,
++		id: string
++	) {
++		super(id);
++
++		this.activeCompositeListeners = [];
++		this.instantiatedCompositeListeners = [];
++		this.mapCompositeToCompositeContainer = {};
++		this.mapActionsBindingToComposite = {};
++		this.mapProgressServiceToComposite = {};
++		this.activeComposite = null;
++		this.instantiatedComposits = [];
++		this.compositeLoaderPromises = {};
++	}
++
++	public setInstantiationService(service: IInstantiationService): void {
++		this.instantiationService = service;
++	}
++
++	protected createComposite(id: string, isActive?: boolean): TPromise<Composite> {
++
++		// Check if composite is already created
++		for (let i = 0; i < this.instantiatedComposits.length; i++) {
++			if (this.instantiatedComposits[i].getId() === id) {
++				return TPromise.as(this.instantiatedComposits[i]);
++			}
++		}
++
++		// Instantiate composite from registry otherwise
++		let compositeDescriptor = this.registry.getComposite(id);
++		if (compositeDescriptor) {
++			let loaderPromise = this.compositeLoaderPromises[id];
++			if (!loaderPromise) {
++				let progressService = new WorkbenchProgressService(this.eventService, this.progressBar, compositeDescriptor.id, isActive);
++				let services = {
++					progressService: progressService
++				};
++				let compositeInstantiationService = this.instantiationService.createChild(services);
++
++				loaderPromise = compositeInstantiationService.createInstance(compositeDescriptor).then((composite: Composite) => {
++					this.mapProgressServiceToComposite[composite.getId()] = progressService;
++
++					// Remember as Instantiated
++					this.instantiatedComposits.push(composite);
++
++					// Register to title area update events from the composite
++					this.instantiatedCompositeListeners.push(composite.addListener(CompositeEventType.INTERNAL_COMPOSITE_TITLE_AREA_UPDATE, (e) => { this.onTitleAreaUpdate(e); }));
++
++					// Remove from Promises Cache since Loaded
++					delete this.compositeLoaderPromises[id];
++
++					return composite;
++				});
++
++				// Report progress for slow loading composits
++				progressService.showWhile(loaderPromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++
++				// Add to Promise Cache until Loaded
++				this.compositeLoaderPromises[id] = loaderPromise;
++			}
++
++			return loaderPromise;
++		}
++
++		throw new Error(strings.format('Unable to find composite with id {0}', id));
++	}
++
++	protected showComposite(composite: Composite): TPromise<void> {
++
++		// Remember Composite
++		this.activeComposite = composite;
++
++		// Store in preferences
++		this.storageService.store(this.activeCompositeSettingsKey, this.activeComposite.getId(), StorageScope.WORKSPACE);
++
++		// Remember
++		this.lastActiveCompositeId = this.activeComposite.getId();
++
++		// Register as Emitter to Workbench Bus
++		this.activeCompositeListeners.push(this.eventService.addEmitter(this.activeComposite, this.activeComposite.getId()));
++
++		let createCompositePromise: TPromise<void>;
++
++		// Composits created for the first time
++		let compositeContainer = this.mapCompositeToCompositeContainer[composite.getId()];
++		if (!compositeContainer) {
++
++			// Build Container off-DOM
++			compositeContainer = $().div({
++				'class': 'viewlet',
++				id: composite.getId()
++			}, (div: Builder) => {
++				createCompositePromise = composite.create(div);
++			});
++
++			// Remember composite container
++			this.mapCompositeToCompositeContainer[composite.getId()] = compositeContainer;
++		}
++
++		// Composite already exists but is hidden
++		else {
++			createCompositePromise = TPromise.as(null);
++		}
++
++		// Report progress for slow loading composits (but only if we did not create the composits before already)
++		let progressService = this.mapProgressServiceToComposite[composite.getId()];
++		if (progressService && !compositeContainer) {
++			this.mapProgressServiceToComposite[composite.getId()].showWhile(createCompositePromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
++		}
++
++		// Fill Content and Actions
++		return createCompositePromise.then(() => {
++
++			// Make sure that the user meanwhile did not open another composite or closed the sidebar
++			if (!this.activeComposite || composite.getId() !== this.activeComposite.getId()) {
++				return;
++			}
++
++			// Take Composite on-DOM and show
++			compositeContainer.build(this.getContentArea());
++			compositeContainer.show();
++
++			// Setup action runner
++			this.toolBar.actionRunner = composite.getActionRunner();
++
++			// Update title with composite title if it differs from descriptor
++			let descriptor = this.registry.getComposite(composite.getId());
++			if (descriptor && descriptor.name !== composite.getTitle()) {
++				this.updateTitle(composite.getId(), composite.getTitle());
++			}
++
++			// Handle Composite Actions
++			let actionsBinding = this.mapActionsBindingToComposite[composite.getId()];
++			if (!actionsBinding) {
++				actionsBinding = this.collectCompositeActions(composite);
++				this.mapActionsBindingToComposite[composite.getId()] = actionsBinding;
++			}
++			actionsBinding();
++
++			if (this.telemetryActionsListener) {
++				this.telemetryActionsListener.dispose();
++				this.telemetryActionsListener = null;
++			}
++
++			// Action Run Handling
++			this.telemetryActionsListener = this.toolBar.actionRunner.addListener2(events.EventType.RUN, (e: any) => {
++
++				// Check for Error
++				if (e.error && !errors.isPromiseCanceledError(e.error)) {
++					this.messageService.show(Severity.Error, e.error);
++				}
++
++				// Log in telemetry
++				if (this.telemetryService) {
++					this.telemetryService.publicLog('workbenchActionExecuted', { id: e.action.id, from: 'sideBar' });
++				}
++			});
++
++			// Indicate to composite that it is now visible
++			return composite.setVisible(true).then(() => {
++
++				// Make sure that the user meanwhile did not open another composite or closed the sidebar","@isidorn ""sidebar"" being mentioned in comment
+",2016-01-15 15:07:07
+138,"@@ -0,0 +1,46 @@
++/*---------------------------------------------------------------------------------------------","all of this should sit in `electron-browser` and not in the `node` namespace cos we have a dependency to the browser world, like DOM etc, and nodejs libs
+",2016-04-29 15:11:52
+611,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>","Could you check that this validates against:
+
+```
+appstream-util validate code.appdata.xml
+```",2016-12-13 20:04:50
+605,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">",If you wanted to split the .appdata.xml change out into a separate PR we can merge this a lot faster.,2016-12-13 19:38:53
+608,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>",@chrisdias do we have a preferred license for metadata files like these?,2016-12-13 19:40:49
+610,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>
++	<project_license>MIT</project_license>",This will need to change to be based on product.json but I just realized we don't do it for the rpm package so this is work I'll need to follow up :smile: #17133,2016-12-13 19:45:38
+609,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>
++	<project_license>MIT</project_license>
++	<name>@@NAME_LONG@@</name>
++	<url type=""homepage"">https://code.visualstudio.com</url>
++	<summary>Code editor for developers supporting integration with existing tools</summary>","As in https://github.com/Microsoft/vscode/issues/17130, let's make this ""Code editing. Redefined."" for now",2016-12-13 19:43:48
+607,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>
++	<project_license>MIT</project_license>
++	<name>@@NAME_LONG@@</name>
++	<url type=""homepage"">https://code.visualstudio.com</url>
++	<summary>Code editor for developers supporting integration with existing tools</summary>
++	<description>
++		<p>
++			Visual Studio Code is a lightweight but powerful source code editor which","Let's go with the standard description now as defined in https://github.com/Microsoft/vscode/issues/17130, also could you put it all one line? `<p>Visual Studio...`",2016-12-13 19:40:20
+606,"@@ -0,0 +1,46 @@
++<?xml version=""1.0"" encoding=""UTF-8""?>
++<component type=""desktop"">
++	<id>@@NAME@@.desktop</id>
++	<metadata_license>CC-BY-SA-3.0</metadata_license>
++	<project_license>MIT</project_license>
++	<name>@@NAME_LONG@@</name>
++	<url type=""homepage"">https://code.visualstudio.com</url>
++	<summary>Code editor for developers supporting integration with existing tools</summary>
++	<description>
++		<p>
++			Visual Studio Code is a lightweight but powerful source code editor which
++			runs on your desktop and is available for Windows, Mac and Linux. It comes
++			with built-in support for JavaScript, TypeScript and Node.js and has a rich
++			ecosystem of extensions for other languages (such as C++, C#, Python, PHP)
++			and runtimes. 
++		</p>
++		<p>
++			The editor includes built-in support for the Git distributed version control
++			system, intelligent code completion, support for highlighting and completing
++			many programming languages, and and integrated debugging interface. Additional
++			functionality is provided by optional extensions.
++		</p>
++	</description>
++	<screenshots>
++		<screenshot type=""default"">
++			<image>https://code.visualstudio.com/home/home-screenshot-linux-lg.png</image>
++			<caption>Editing a TypeScript file and searching for extensions.</caption>
++		</screenshot>
++		<screenshot>","Let's just keep the default screenshot for now, I've created https://github.com/Microsoft/vscode/issues/17131 to follow this up.",2016-12-13 19:39:29
+253,"@@ -0,0 +1,51 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import {ITerminalService} from 'vs/workbench/parts/terminal/electron-browser/terminal';
++import {MainThreadTerminalServiceShape} from './extHost.protocol';
++
++export class MainThreadTerminalService extends MainThreadTerminalServiceShape {
++
++	private _terminalService: ITerminalService;
++
++	constructor(
++		@ITerminalService terminalService: ITerminalService
++	) {
++		super();
++		this._terminalService = terminalService;
++	}
++
++	public $createTerminal(name?: string): TPromise<number> {
++		return this._terminalService.createNew(name);
++	}
++
++	public $show(terminalId: number, preserveFocus: boolean): void {
++		this._terminalService.show(!preserveFocus).then((terminalPanel) => {
++			terminalPanel.setActiveTerminalById(terminalId);
++		});
++	}
++
++	public $hide(terminalId: number): void {
++		this._terminalService.hide();
++	}
++
++	public $dispose(terminalId: number): void {
++		// TODO: This could be improved by not first showing the terminal to be disposed
++		var self = this;","`self`, really? it's a fat-arrow function
+",2016-08-18 19:32:18
+137,"@@ -0,0 +1,53 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import {createDecorator, ServiceIdentifier} from 'vs/platform/instantiation/common/instantiation';
++import path = require('path');
++import platform = require('vs/base/common/platform');
++
++export const TERMINAL_PANEL_ID = 'workbench.panel.terminal';
++
++export const TERMINAL_SERVICE_ID = 'terminalService';
++
++export const TERMINAL_DEFAULT_SHELL_UNIX_LIKE = process.env.SHELL || 'sh';
++export const TERMINAL_DEFAULT_SHELL_WINDOWS = platform.isWindows ? path.resolve(process.env.SystemRoot, 'System32', 'WindowsPowerShell', 'v1.0', 'powershell.exe') : '';
++
++export var ITerminalService = createDecorator<ITerminalService>(TERMINAL_SERVICE_ID);
++
++export interface ITerminalConfiguration {
++	integratedTerminal: {
++		shell: {
++			unixLike: string,
++			windows: string
++		},
++		fontFamily: string,
++		ansiColors: {
++			black: string,
++			red: string,
++			green: string,
++			yellow: string,
++			blue: string,
++			magenta: string,
++			cyan: string,
++			white: string,
++			brightBlack: string,
++			brightRed: string,
++			brightGreen: string,
++			brightYellow: string,
++			brightBlue: string,
++			brightMagenta: string,
++			brightCyan: string,
++			brightWhite: string,
++		}
++	};
++}
++
++export interface ITerminalService {","it doesn't seem like this service isn't buying us anything
+",2016-04-29 15:11:06
+196,"@@ -0,0 +1,56 @@
++/*---------------------------------------------------------------------------------------------","Great for having tests 👍 
+",2016-07-06 08:04:20
+252,"@@ -0,0 +1,56 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import {TPromise} from 'vs/base/common/winjs.base';
++import {IThreadService} from 'vs/workbench/services/thread/common/threadService';
++import vscode = require('vscode');
++import {MainContext, MainThreadTerminalServiceShape} from './extHost.protocol';
++
++export class ExtHostTerminal implements vscode.Terminal {
++
++	private _id: number;
++	private _proxy: MainThreadTerminalServiceShape;
++	private _disposed: boolean;
++
++	constructor(proxy: MainThreadTerminalServiceShape, id: number) {
++		this._id = id;
++		this._proxy = proxy;
++	}
++
++	public sendText(text: string, addNewLine: boolean = true) {
++		this._proxy.$sendText(this._id, text, addNewLine);","throw if disposed?
+",2016-08-18 19:30:15
+440,"@@ -0,0 +1,57 @@
++/*---------------------------------------------------------------------------------------------","@octref not sure if you care about it but this file could move into the `common` layer since it does not seem to depend on anything browser related.
+",2016-11-03 08:03:51
+445,"@@ -0,0 +1,57 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as nls from 'vs/nls';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Registry } from 'vs/platform/platform';
++import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actionRegistry';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { Action } from 'vs/base/common/actions';
++import { IQuickOpenService, IPickOpenEntry } from 'vs/workbench/services/quickopen/common/quickOpenService';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++
++const registry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions);
++
++export class ToggleExternalViewletAction extends Action {
++	public static ID = 'workbench.action.customTreeExplorer.toggle';
++	public static LABEL = nls.localize('toggleCustomExplorer', 'Toggle Custom Explorer');
++
++	constructor(
++		id: string,
++		label: string,
++		@IQuickOpenService private quickOpenService: IQuickOpenService,
++		@IActivityService private activityService: IActivityService
++	) {
++		super(id, name);
++	}
++
++	run(): TPromise<any> {
++		const infoForExternalViewlets = this.activityService.getInfoForExternalViewlets();
++
++		const picks: IPickOpenEntry[] = [];
++		for (let viewletId in infoForExternalViewlets) {
++			const { isEnabled, treeLabel } = infoForExternalViewlets[viewletId];
++			picks.push({
++				id: viewletId,
++				label: (isEnabled ? 'Disable ' : 'Enable ') + treeLabel","@octref you are messing with nls here!
+",2016-11-03 08:28:32
+446,"@@ -0,0 +1,57 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as nls from 'vs/nls';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Registry } from 'vs/platform/platform';
++import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actionRegistry';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { Action } from 'vs/base/common/actions';
++import { IQuickOpenService, IPickOpenEntry } from 'vs/workbench/services/quickopen/common/quickOpenService';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++
++const registry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions);
++
++export class ToggleExternalViewletAction extends Action {
++	public static ID = 'workbench.action.customTreeExplorer.toggle';
++	public static LABEL = nls.localize('toggleCustomExplorer', 'Toggle Custom Explorer');
++
++	constructor(
++		id: string,
++		label: string,
++		@IQuickOpenService private quickOpenService: IQuickOpenService,
++		@IActivityService private activityService: IActivityService
++	) {
++		super(id, name);
++	}
++
++	run(): TPromise<any> {
++		const infoForExternalViewlets = this.activityService.getInfoForExternalViewlets();
++
++		const picks: IPickOpenEntry[] = [];
++		for (let viewletId in infoForExternalViewlets) {
++			const { isEnabled, treeLabel } = infoForExternalViewlets[viewletId];
++			picks.push({
++				id: viewletId,
++				label: (isEnabled ? 'Disable ' : 'Enable ') + treeLabel
++			});
++		}
++
++		return TPromise.timeout(50 /* quick open is sensitive to being opened so soon after another */).then(() => {
++			this.quickOpenService.pick(picks, { placeHolder: 'Select Viewlet to toggle', autoFocus: 2 }).then(pick => {","@octref multiple things:
+- nls!
+- I suggest to not call it Viewlet but rather similar to the action that it was opened from (""Custom Explorer"")
+- please use the enum and not the number it represents for `autoFocus`
+",2016-11-03 08:28:49
+411,"@@ -0,0 +1,60 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as nls from 'vs/nls';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Registry } from 'vs/platform/platform';
++import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actionRegistry';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { Action } from 'vs/base/common/actions';
++import { IQuickOpenService, IPickOpenEntry } from 'vs/workbench/services/quickopen/common/quickOpenService';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++
++const registry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions);
++
++export class ToggleExternalViewletAction extends Action {
++	public static ID = 'workbench.action.customTreeExplorer.toggle';
++	public static LABEL = nls.localize('toggleCustomExplorer', 'Toggle Custom Explorer');
++
++	constructor(
++		id: string,
++		label: string,
++		@IQuickOpenService private quickOpenService: IQuickOpenService,
++		@IActivityService private activityService: IActivityService
++	) {
++		super(id, name);
++	}
++
++	run(): TPromise<any> {
++		const viewletsToggleStataus = this.activityService.getIsEnabledForRegisteredViewlets();","Typo: Stataus
+",2016-10-24 15:50:22
+410,"@@ -0,0 +1,60 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import * as nls from 'vs/nls';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Registry } from 'vs/platform/platform';
++import { IWorkbenchActionRegistry, Extensions as ActionExtensions } from 'vs/workbench/common/actionRegistry';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { Action } from 'vs/base/common/actions';
++import { IQuickOpenService, IPickOpenEntry } from 'vs/workbench/services/quickopen/common/quickOpenService';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++
++const registry = Registry.as<IWorkbenchActionRegistry>(ActionExtensions.WorkbenchActions);
++
++export class ToggleExternalViewletAction extends Action {
++	public static ID = 'workbench.action.customTreeExplorer.toggle';
++	public static LABEL = nls.localize('toggleCustomExplorer', 'Toggle Custom Explorer');
++
++	constructor(
++		id: string,
++		label: string,
++		@IQuickOpenService private quickOpenService: IQuickOpenService,
++		@IActivityService private activityService: IActivityService
++	) {
++		super(id, name);
++	}
++
++	run(): TPromise<any> {
++		const viewletsToggleStataus = this.activityService.getIsEnabledForRegisteredViewlets();
++
++		const picks: IPickOpenEntry[] = [];
++		for (let viewletId in viewletsToggleStataus) {
++			picks.push({
++				id: viewletId,
++				label: (viewletsToggleStataus[viewletId] ? 'Disable ' : 'Enable ') + this.getShortViewletId(viewletId)","Is this `viewletId` the `treeExplorerNodeProviderId` in the contribution? If so why aren't you using treeLabel as the label in the quick open?
+",2016-10-24 15:50:04
+438,"@@ -0,0 +1,60 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { localize } from 'vs/nls';
++import { join } from 'vs/base/common/paths';
++import { createCSSRule } from 'vs/base/browser/dom';
++import { IJSONSchema } from 'vs/base/common/jsonSchema';
++import { ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
++import { Registry } from 'vs/platform/platform';
++import { ViewletRegistry, Extensions as ViewletExtensions, ViewletDescriptor } from 'vs/workbench/browser/viewlet';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';","@octref you are reaching into the contribution space of the workbench here which is not good (see https://github.com/Microsoft/vscode/wiki/Code-Organization#workbench-parts). Can we not just move this entire file into `vs/workbench/parts/explorers`? I see no reason why this file has to live top level in `workbench` core.
+",2016-11-03 07:49:07
+441,"@@ -0,0 +1,60 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { localize } from 'vs/nls';
++import { join } from 'vs/base/common/paths';
++import { createCSSRule } from 'vs/base/browser/dom';
++import { IJSONSchema } from 'vs/base/common/jsonSchema';
++import { ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
++import { Registry } from 'vs/platform/platform';
++import { ViewletRegistry, Extensions as ViewletExtensions, ViewletDescriptor } from 'vs/workbench/browser/viewlet';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++import { ITreeExplorer } from 'vs/platform/extensionManagement/common/extensionManagement';
++
++namespace schema {
++
++	export const explorerContribtion: IJSONSchema = {
++		description: localize('vscode.extension.contributes.explorer', ""Contributes custom tree explorer viewlet to the sidebar""),
++		type: 'object',
++		properties: {
++			treeExplorerNodeProviderId: {
++				description: localize('vscode.extension.contributes.explorer.treeExplorerNodeProviderId', 'Unique id used to identify provider registered through vscode.workspace.registerTreeExplorerNodeProvider'),
++				type: 'string'
++			},
++			treeLabel: {
++				description: localize('vscode.extension.contributes.explorer.treeLabel', 'Human readable string used to render the custom tree viewlet'),
++				type: 'string'
++			},
++			icon: {
++				description: localize('vscode.extension.contributes.explorer.icon', 'Path to the viewlet icon on the activity bar'),
++				type: 'string'
++			}
++		}
++	};
++}
++
++ExtensionsRegistry.registerExtensionPoint<ITreeExplorer>('explorer', [], schema.explorerContribtion).setHandler(extensions => {
++	for (let extension of extensions) {
++		const { treeExplorerNodeProviderId, treeLabel, icon } = extension.value;
++
++		const getIconRule = (iconPath) => { return `background-image: url('${iconPath}')`; };
++		if (icon) {
++			const iconClass = `.monaco-workbench > .activitybar .monaco-action-bar .action-label.${treeExplorerNodeProviderId}`;","@octref shouldn't the icon rule be created on `VIEWLET_ID_ROOT + treeExplorerNodeProviderId`? How do we otherwise prevent someone from overwriting the icon for the explorer?
+
+Also you have to be carful when taking a user defined string as CSS class. Maybe ping @aeschli on his use of CSS escaping (see https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/themes/electron-browser/themeService.ts#L603)
+",2016-11-03 08:21:00
+443,"@@ -0,0 +1,60 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { localize } from 'vs/nls';
++import { join } from 'vs/base/common/paths';
++import { createCSSRule } from 'vs/base/browser/dom';
++import { IJSONSchema } from 'vs/base/common/jsonSchema';
++import { ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
++import { Registry } from 'vs/platform/platform';
++import { ViewletRegistry, Extensions as ViewletExtensions, ViewletDescriptor } from 'vs/workbench/browser/viewlet';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++import { ITreeExplorer } from 'vs/platform/extensionManagement/common/extensionManagement';
++
++namespace schema {
++
++	export const explorerContribtion: IJSONSchema = {
++		description: localize('vscode.extension.contributes.explorer', ""Contributes custom tree explorer viewlet to the sidebar""),
++		type: 'object',
++		properties: {
++			treeExplorerNodeProviderId: {
++				description: localize('vscode.extension.contributes.explorer.treeExplorerNodeProviderId', 'Unique id used to identify provider registered through vscode.workspace.registerTreeExplorerNodeProvider'),
++				type: 'string'
++			},
++			treeLabel: {
++				description: localize('vscode.extension.contributes.explorer.treeLabel', 'Human readable string used to render the custom tree viewlet'),
++				type: 'string'
++			},
++			icon: {
++				description: localize('vscode.extension.contributes.explorer.icon', 'Path to the viewlet icon on the activity bar'),
++				type: 'string'
++			}
++		}
++	};
++}
++
++ExtensionsRegistry.registerExtensionPoint<ITreeExplorer>('explorer', [], schema.explorerContribtion).setHandler(extensions => {
++	for (let extension of extensions) {
++		const { treeExplorerNodeProviderId, treeLabel, icon } = extension.value;
++
++		const getIconRule = (iconPath) => { return `background-image: url('${iconPath}')`; };
++		if (icon) {
++			const iconClass = `.monaco-workbench > .activitybar .monaco-action-bar .action-label.${treeExplorerNodeProviderId}`;
++			const iconPath = join(extension.description.extensionFolderPath, icon);
++			createCSSRule(iconClass, getIconRule(iconPath));
++		}
++
++		Registry.as<ViewletRegistry>(ViewletExtensions.Viewlets).registerViewlet(new ViewletDescriptor(
++			'vs/workbench/parts/explorers/browser/treeExplorerViewlet',
++			'TreeExplorerViewlet',
++			VIEWLET_ID_ROOT + treeExplorerNodeProviderId,
++			treeLabel,
++			treeExplorerNodeProviderId,
++			-1, // External viewlets are ordered by enabling sequence, so order here doesn't matter.","@octref `Extension viewlets...`
+",2016-11-03 08:24:14
+444,"@@ -0,0 +1,7 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++export const VIEWLET_ID_ROOT = 'workbench.view.customTreeExplorer.';","@octref since you seem to use this always as a prefix, might be more elegant to just expose a function `toViewletId()` that does the concatenation?
+",2016-11-03 08:26:12
+548,"@@ -0,0 +1,71 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import { PPromise, TPromise } from 'vs/base/common/winjs.base';
++import { IChannel } from 'vs/base/parts/ipc/common/ipc';
++import { ISerializedFileMatch } from '../search';
++import { IProgress, ILineMatch, IPatternInfo, ISearchStats } from 'vs/platform/search/common/search';
++import { SearchWorker } from './searchWorker';
++
++export interface ISearchWorkerConfig {
++	pattern: IPatternInfo;
++	fileEncoding: string;
++	id: number;
++}
++
++export interface ISearchWorkerSearchArgs {
++	absolutePaths: string[];
++	maxResults: number;
++}
++
++export interface ISearchWorkerSearchResult {
++	matches: ISerializedFileMatch[];
++	numMatches: number;
++	limitReached: boolean;
++}
++
++export interface ISearchWorker {
++	initialize(config: ISearchWorkerConfig): TPromise<void>;
++	search(args: ISearchWorkerSearchArgs): TPromise<ISearchWorkerSearchResult>;
++	cancel(): TPromise<void>;
++}
++
++export interface ISearchWorkerChannel extends IChannel {
++	call(command: 'initialize', config: ISearchWorkerConfig): TPromise<void>;
++	call(command: 'search', args: ISearchWorkerSearchArgs): TPromise<ISearchWorkerSearchResult>;
++	call(command: 'cancel'): TPromise<void>;
++	call(command: string, arg?: any): TPromise<any>;
++}
++
++export class SearchWorkerChannel implements ISearchWorkerChannel {
++	constructor(private worker: SearchWorker) {
++	}
++
++	call(command: string, arg?: any): TPromise<any> {
++		switch(command) {
++			case 'initialize': return TPromise.wrap(this.worker.initialize(arg));",`TPromise.wrap` is already used in initialize().,2016-11-30 20:02:40
+392,"@@ -0,0 +1,71 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { localize } from 'vs/nls';
++import { join } from 'vs/base/common/paths';
++import { createCSSRule } from 'vs/base/browser/dom';
++import { IJSONSchema } from 'vs/base/common/jsonSchema';
++import { ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
++import { Registry } from 'vs/platform/platform';
++import { ViewletRegistry, Extensions as ViewletExtensions, ViewletDescriptor } from 'vs/workbench/browser/viewlet';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++
++namespace schema {
++
++	export interface IExplorer {","Should you reuse the one in extensionManagement.ts instead of duplicating?
+",2016-10-24 14:52:56
+391,"@@ -0,0 +1,71 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { localize } from 'vs/nls';
++import { join } from 'vs/base/common/paths';
++import { createCSSRule } from 'vs/base/browser/dom';
++import { IJSONSchema } from 'vs/base/common/jsonSchema';
++import { ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
++import { Registry } from 'vs/platform/platform';
++import { ViewletRegistry, Extensions as ViewletExtensions, ViewletDescriptor } from 'vs/workbench/browser/viewlet';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++
++namespace schema {
++
++	export interface IExplorer {
++		treeExplorerNodeProviderId: string;
++		treeLabel: string;
++		icon: string;
++	}
++
++	export const explorerContribtion: IJSONSchema = {
++		description: localize('vscode.extension.contributes.explorer', ""Contributes custom tree explorer viewlet to the sidebar""),
++		type: 'object',
++		properties: {
++			treeExplorerNodeProviderId: {
++				description: localize('vscode.extension.contributes.explorer.treeExplorerNodeProviderId', 'Unique id used to identify provider registered through vscode.workspace.registerTreeExplorerNodeProvider'),
++				type: 'string'
++			},
++			treeLabel: {
++				description: localize('vscode.extension.contributes.explorer.treeLabel', 'Human readable string used to render the custom tree viewlet'),
++				type: 'string'
++			},
++			icon: {
++				description: localize('vscode.extension.contributes.explorer.icon', 'Path to the viewlet icon on the activity bar'),
++				type: 'string'
++			}
++		}
++	};
++}
++
++ExtensionsRegistry.registerExtensionPoint<schema.IExplorer>('explorer', schema.explorerContribtion).setHandler(extensions => {
++	let baseOrder = 200; // Stock viewlet order goes up to 100
++	let descriptors = [];
++
++	for (let extension of extensions) {
++		const { treeExplorerNodeProviderId, treeLabel, icon } = extension.value;
++
++		const getIconRule = (iconPath) => { return `background-image: url('${iconPath}')`; };
++		if (icon) {
++			const iconClass = `.monaco-workbench > .activitybar .monaco-action-bar .action-label.${treeExplorerNodeProviderId}`;","You need styles for `.vs-dark` and `.hc-black` base themes as well
+",2016-10-24 14:51:54
+390,"@@ -0,0 +1,71 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { localize } from 'vs/nls';
++import { join } from 'vs/base/common/paths';
++import { createCSSRule } from 'vs/base/browser/dom';
++import { IJSONSchema } from 'vs/base/common/jsonSchema';
++import { ExtensionsRegistry } from 'vs/platform/extensions/common/extensionsRegistry';
++import { Registry } from 'vs/platform/platform';
++import { ViewletRegistry, Extensions as ViewletExtensions, ViewletDescriptor } from 'vs/workbench/browser/viewlet';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++
++namespace schema {
++
++	export interface IExplorer {
++		treeExplorerNodeProviderId: string;
++		treeLabel: string;
++		icon: string;
++	}
++
++	export const explorerContribtion: IJSONSchema = {
++		description: localize('vscode.extension.contributes.explorer', ""Contributes custom tree explorer viewlet to the sidebar""),
++		type: 'object',
++		properties: {
++			treeExplorerNodeProviderId: {
++				description: localize('vscode.extension.contributes.explorer.treeExplorerNodeProviderId', 'Unique id used to identify provider registered through vscode.workspace.registerTreeExplorerNodeProvider'),
++				type: 'string'
++			},
++			treeLabel: {
++				description: localize('vscode.extension.contributes.explorer.treeLabel', 'Human readable string used to render the custom tree viewlet'),
++				type: 'string'
++			},
++			icon: {
++				description: localize('vscode.extension.contributes.explorer.icon', 'Path to the viewlet icon on the activity bar'),
++				type: 'string'
++			}
++		}
++	};
++}
++
++ExtensionsRegistry.registerExtensionPoint<schema.IExplorer>('explorer', schema.explorerContribtion).setHandler(extensions => {
++	let baseOrder = 200; // Stock viewlet order goes up to 100
++	let descriptors = [];
++
++	for (let extension of extensions) {
++		const { treeExplorerNodeProviderId, treeLabel, icon } = extension.value;
++
++		const getIconRule = (iconPath) => { return `background-image: url('${iconPath}')`; };
++		if (icon) {
++			const iconClass = `.monaco-workbench > .activitybar .monaco-action-bar .action-label.${treeExplorerNodeProviderId}`;
++			const iconPath = join(extension.description.extensionFolderPath, icon);
++			createCSSRule(iconClass, getIconRule(iconPath));
++			// Coerce the icon into a style similar to stock icons
++			createCSSRule(iconClass, '-webkit-filter: grayscale(1) invert(1)');","This one could be pulled into CSS as a general rule
+",2016-10-24 14:51:43
+478,"@@ -0,0 +1,72 @@
++/*---------------------------------------------------------------------------------------------","@Tyriar for performance reasons I think we need to add some buffer logic when processing the events. doing a backup on every keystroke is crazy. you should really measure how many model change events you get while typing to get a feeling on it.
+",2016-11-09 07:50:19
+498,"@@ -0,0 +1,73 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import URI from 'vs/base/common/uri';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { IUntitledEditorService } from 'vs/workbench/services/untitled/common/untitledEditorService';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++import { IWorkbenchContribution } from 'vs/workbench/common/contributions';
++import { IPartService } from 'vs/workbench/services/part/common/partService';
++import errors = require('vs/base/common/errors');
++import { IBackupService, IBackupFileService } from 'vs/workbench/services/backup/common/backup';
++import { IEditorGroupService } from 'vs/workbench/services/group/common/groupService';
++import { FileEditorInput } from 'vs/workbench/parts/files/common/files';
++
++// TODO@ben TODO@tyriar this should restore any backup that exists on disk and not rely
++// on the editors to be restored already in the stacks model. For that a method is needed
++// to get all backups that exist on disk.
++export class BackupRestorer implements IWorkbenchContribution {
++
++	public _serviceBrand: any;","Not needed
+",2016-11-18 16:20:26
+448,"@@ -0,0 +1,76 @@
++/*---------------------------------------------------------------------------------------------","@octref I find the naming of this service weird and hard to understand what it does. can we maybe rename it to something that better tells us what the purpose is? I see the name is `ITreeExplorerViewletService` but it gets contributed as `customViewletService` which seems weird. Mayb `IExtensionTreeService`? Afaik it seems only tree related but not viewlet related.
+",2016-11-03 08:42:01
+413,"@@ -0,0 +1,76 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { IInstantiationService, createDecorator } from 'vs/platform/instantiation/common/instantiation';
++import { InternalTreeExplorerNode, InternalTreeExplorerNodeProvider } from 'vs/workbench/parts/explorers/common/treeExplorerViewModel';
++import { IMessageService, Severity } from 'vs/platform/message/common/message';
++import Event, { Emitter } from 'vs/base/common/event';
++
++export const ITreeExplorerViewletService = createDecorator<ITreeExplorerViewletService>('customViewletService');
++
++export interface ITreeExplorerViewletService {
++	_serviceBrand: any;
++
++	onTreeExplorerNodeProviderRegistered: Event<String>;
++
++	registerTreeExplorerNodeProvider(providerId: string, provider: InternalTreeExplorerNodeProvider): void;
++	hasProvider(providerId: string): boolean;
++
++	provideRootNode(providerId: string): TPromise<InternalTreeExplorerNode>;
++	resolveChildren(providerId: string, node: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]>;
++	executeCommand(providerId: string, node: InternalTreeExplorerNode): TPromise<void>;
++}
++
++export class TreeExplorerViewletService implements ITreeExplorerViewletService {","Fill in access modifiers
+",2016-10-24 15:53:38
+948,"@@ -0,0 +1,82 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++import * as vscode from 'vscode';
++import { MergeConflictParser } from './mergeConflictParser';
++import * as interfaces from './interfaces';
++import { Delayer } from './delayer';
++
++export default class DocumentMergeConflictTracker implements vscode.Disposable, interfaces.IDocumentMergeConflictTracker {
++
++	private cache: Map<string, Delayer<interfaces.IDocumentMergeConflict[]>> = new Map();
++	private delayExpireTime: number = 150;
++
++	getConflicts(document: vscode.TextDocument): PromiseLike<interfaces.IDocumentMergeConflict[]> {
++		// Attempt from cache
++
++		let key = this.getCacheKey(document);
++
++		if (!key) {
++			// Document doesnt have a uri, can't cache it, so return
++			return Promise.resolve(this.getConflictsOrEmpty(document));
++		}
++
++		let cacheItem = this.cache.get(key);
++		if (!cacheItem) {
++			cacheItem = new Delayer<interfaces.IDocumentMergeConflict[]>(this.delayExpireTime);
++			this.cache.set(key, cacheItem);
++		}
++
++		return cacheItem.trigger(() => {
++			let conflicts = this.getConflictsOrEmpty(document);
++
++			if (this.cache) {
++				this.cache.delete(key!);
++			}
++
++			return conflicts;
++		});
++	}
++
++	forget(document: vscode.TextDocument) {
++		let key = this.getCacheKey(document);
++
++		if (key) {
++			this.cache.delete(key);
++		}
++	}
++
++	dispose() {
++		this.cache.clear();
++	}
++
++	private getConflictsOrEmpty(document: vscode.TextDocument): interfaces.IDocumentMergeConflict[] {
++		let stepStart = process.hrtime();",Skip or remove console output.,2017-05-23 18:17:54
+313,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------","So this guy is the one that manages all backups across all workspaces and the vs/platform/backup is the one per workspace for individual files?
+",2016-10-13 15:02:20
+310,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as fs from 'original-fs';
++import * as path from 'path';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {
++	getBackupWorkspaces(): string[];
++	clearBackupWorkspaces(): void;
++	pushBackupWorkspaces(workspaces: string[]): void;","Not quite clear here what `workspaces` is about? Is this an identifier or absolute path?
+",2016-10-13 14:55:53
+308,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as fs from 'original-fs';
++import * as path from 'path';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {
++	getBackupWorkspaces(): string[];
++	clearBackupWorkspaces(): void;
++	pushBackupWorkspaces(workspaces: string[]): void;
++	getBackupFiles(workspace: string): string[];
++}
++
++interface IBackupFormat {
++	folderWorkspaces?: {
++		[workspacePath: string]: string[]
++	};
++}
++
++export class BackupService implements IBackupService {
++
++	private filePath: string;
++	private fileContent: IBackupFormat;
++
++	constructor(
++		@IEnvironmentService private environmentService: IEnvironmentService
++	) {
++		this.filePath = path.join(environmentService.userDataPath, 'Backups', 'workspaces.json');","This should be a key inside environment service and not being constructed, or?
+",2016-10-13 14:54:01
+309,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import * as fs from 'original-fs';
++import * as path from 'path';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++
++export interface IBackupService {
++	getBackupWorkspaces(): string[];
++	clearBackupWorkspaces(): void;
++	pushBackupWorkspaces(workspaces: string[]): void;
++	getBackupFiles(workspace: string): string[];
++}
++
++interface IBackupFormat {
++	folderWorkspaces?: {
++		[workspacePath: string]: string[]
++	};
++}
++
++export class BackupService implements IBackupService {
++
++	private filePath: string;
++	private fileContent: IBackupFormat;
++
++	constructor(
++		@IEnvironmentService private environmentService: IEnvironmentService
++	) {
++		this.filePath = path.join(environmentService.userDataPath, 'Backups', 'workspaces.json');
++	}
++
++	public getBackupWorkspaces(): string[] {
++		if (!this.fileContent) {
++			this.load();
++		}
++		return Object.keys(this.fileContent.folderWorkspaces || {});
++	}
++
++	public clearBackupWorkspaces(): void {
++		this.fileContent = {
++			folderWorkspaces: {}","Just a personal preference to use `Object.create(null)` over `{}`
+",2016-10-13 14:54:58
+468,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import Uri from 'vs/base/common/uri';
++import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { ITextFileEditorModelManager } from 'vs/workbench/services/textfile/common/textfiles';
++
++export const IBackupService = createDecorator<IBackupService>('backupService');
++export const IBackupFileService = createDecorator<IBackupFileService>('backupFileService');
++export const IBackupModelService = createDecorator<IBackupModelService>('backupModelService');
++
++/**
++ * A service that handles the lifecycle of backups, eg. listening for file changes and acting
++ * appropriately on shutdown.
++ */
++export interface IBackupService {
++	_serviceBrand: any;
++
++	isHotExitEnabled: boolean;
++	backupBeforeShutdown(dirtyToBackup: Uri[], textFileEditorModelManager: ITextFileEditorModelManager, quitRequested: boolean, confirmCallback: () => boolean | TPromise<boolean>): boolean | TPromise<boolean>;
++	cleanupBackupsBeforeShutdown(): boolean | TPromise<boolean>;
++
++	doBackup(resource: Uri, content: string, immediate?: boolean): TPromise<void>;
++}
++
++/**
++ * A service that handles any I/O and state associated with the backup system.
++ */
++export interface IBackupFileService {
++	_serviceBrand: any;
++
++	/**
++	 * Gets the set of active workspace backup paths being tracked for restoration.
++	 *
++	 * @return The set of active workspace backup paths being tracked for restoration.
++	 */
++	getWorkspaceBackupPaths(): TPromise<string[]>;
++
++	/**
++	 * Gets whether a text file has a backup to restore.
++	 *
++	 * @param resource The resource to check.
++	 * @returns Whether the file has a backup.
++	 */
++	doesTextFileHaveBackup(resource: Uri): TPromise<boolean>;","@Tyriar maybe `hasTextFileBackup`?
+",2016-11-09 07:31:59
+414,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Builder, Dimension } from 'vs/base/browser/builder';
++import { Orientation } from 'vs/base/browser/ui/splitview/splitview';
++import { IAction } from 'vs/base/common/actions';
++import { IViewletView, Viewlet } from 'vs/workbench/browser/viewlet';
++import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
++import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
++import { TreeExplorerView } from 'vs/workbench/parts/explorers/browser/views/treeExplorerView';
++import { TreeExplorerViewletState } from 'vs/workbench/parts/explorers/browser/views/treeExplorerViewer';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++
++export class TreeExplorerViewlet extends Viewlet {","Fill in access modifiers
+",2016-10-24 15:54:01
+449,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Builder, Dimension } from 'vs/base/browser/builder';
++import { Orientation } from 'vs/base/browser/ui/splitview/splitview';
++import { IAction } from 'vs/base/common/actions';
++import { IViewletView, Viewlet } from 'vs/workbench/browser/viewlet';
++import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
++import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
++import { TreeExplorerView } from 'vs/workbench/parts/explorers/browser/views/treeExplorerView';
++import { TreeExplorerViewletState } from 'vs/workbench/parts/explorers/browser/views/treeExplorerViewer';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++
++export class TreeExplorerViewlet extends Viewlet {
++	private static _idCounter = 1;
++
++	private viewletContainer: Builder;
++	private view: IViewletView;
++
++	private viewletState: TreeExplorerViewletState;
++
++	private externalViewletId: string;
++	private treeNodeProviderId: string;
++
++	constructor(
++		@ITelemetryService telemetryService: ITelemetryService,
++		@IInstantiationService private instantiationService: IInstantiationService,
++		@IActivityService private activityService: IActivityService
++	) {
++		super(VIEWLET_ID_ROOT + TreeExplorerViewlet._idCounter, telemetryService);","@octref this is very confusing and fragile. the viewlet ID is now suddenly something dynamic and not static? and then you get an external ID from somewhere and return it from `getId()`? All of this has to change :-/
+",2016-11-03 08:44:11
+412,"@@ -0,0 +1,88 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { Builder, Dimension } from 'vs/base/browser/builder';
++import { Orientation } from 'vs/base/browser/ui/splitview/splitview';
++import { IAction } from 'vs/base/common/actions';
++import { IViewletView, Viewlet } from 'vs/workbench/browser/viewlet';
++import { ITelemetryService } from 'vs/platform/telemetry/common/telemetry';
++import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
++import { TreeExplorerView } from 'vs/workbench/parts/explorers/browser/views/treeExplorerView';
++import { TreeExplorerViewletState } from 'vs/workbench/parts/explorers/browser/views/treeExplorerViewer';
++import { IActivityService } from 'vs/workbench/services/activity/common/activityService';
++import { VIEWLET_ID_ROOT } from 'vs/workbench/parts/explorers/common/treeExplorer';
++
++export class TreeExplorerViewlet extends Viewlet {
++	private static _idCounter = 1;
++
++	private viewletContainer: Builder;
++	private view: IViewletView;
++
++	private viewletState: TreeExplorerViewletState;
++
++	private externalViewletId: string;
++	private treeNodeProviderId: string;
++
++	constructor(
++		@ITelemetryService telemetryService: ITelemetryService,
++		@IInstantiationService private instantiationService: IInstantiationService,
++		@IActivityService private activityService: IActivityService
++	) {
++		super(VIEWLET_ID_ROOT + TreeExplorerViewlet._idCounter, telemetryService);
++
++		this.viewletState = new TreeExplorerViewletState();
++
++		this.externalViewletId = this.activityService.getExternalViewletIdToOpen();
++		this.treeNodeProviderId = this.getTreeProviderName(this.externalViewletId);
++
++		TreeExplorerViewlet._idCounter++;
++	}
++
++	getId(): string {
++		return this.externalViewletId;
++	}
++
++	create(parent: Builder): TPromise<void> {
++		super.create(parent);
++
++		this.viewletContainer = parent.div().addClass('custom-tree-explorer-viewlet');","I don't think this class is used.
+",2016-10-24 15:52:14
+768,"@@ -0,0 +1,89 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';","We no longer 'use strict', this is simply ignored",2017-02-21 10:53:26
+769,"@@ -0,0 +1,89 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import nls = require('vs/nls');
++import Filters = require('vs/base/common/filters');
++import { TPromise } from 'vs/base/common/winjs.base';
++import Quickopen = require('vs/workbench/browser/quickopen');
++import QuickOpen = require('vs/base/parts/quickopen/common/quickOpen');
++import Model = require('vs/base/parts/quickopen/browser/quickOpenModel');
++import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen';
++import { IDebugService } from 'vs/workbench/parts/debug/common/debug';
++import * as errors from 'vs/base/common/errors';
++
++class DebugEntry extends Model.QuickOpenEntry {
++	private debugService: IDebugService;",Get rid of this privates,2017-02-21 10:54:01
+770,"@@ -0,0 +1,89 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import nls = require('vs/nls');
++import Filters = require('vs/base/common/filters');
++import { TPromise } from 'vs/base/common/winjs.base';
++import Quickopen = require('vs/workbench/browser/quickopen');
++import QuickOpen = require('vs/base/parts/quickopen/common/quickOpen');
++import Model = require('vs/base/parts/quickopen/browser/quickOpenModel');
++import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen';
++import { IDebugService } from 'vs/workbench/parts/debug/common/debug';
++import * as errors from 'vs/base/common/errors';
++
++class DebugEntry extends Model.QuickOpenEntry {
++	private debugService: IDebugService;
++	private configurationName: string;
++
++	constructor(debugService: IDebugService, config: string, highlights: Model.IHighlight[] = []) {
++		super(highlights);
++		this.debugService = debugService;
++		this.configurationName = config;
++	}
++
++	public getLabel(): string {
++		return this.configurationName;
++	}
++
++	public getAriaLabel(): string {
++		return nls.localize('entryAriaLabel', ""{0}, debug"", this.getLabel());
++	}
++
++	public run(mode: QuickOpen.Mode, context: Model.IContext): boolean {
++		if (mode === QuickOpen.Mode.PREVIEW) {
++			return false;
++		}
++		// Run selected debug configuration
++		this.debugService.createProcess(this.configurationName).done(undefined, errors.onUnexpectedError);",Do it the other way around,2017-02-21 10:54:26
+771,"@@ -0,0 +1,89 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import nls = require('vs/nls');
++import Filters = require('vs/base/common/filters');
++import { TPromise } from 'vs/base/common/winjs.base';
++import Quickopen = require('vs/workbench/browser/quickopen');
++import QuickOpen = require('vs/base/parts/quickopen/common/quickOpen');
++import Model = require('vs/base/parts/quickopen/browser/quickOpenModel');
++import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen';
++import { IDebugService } from 'vs/workbench/parts/debug/common/debug';
++import * as errors from 'vs/base/common/errors';
++
++class DebugEntry extends Model.QuickOpenEntry {
++	private debugService: IDebugService;
++	private configurationName: string;
++
++	constructor(debugService: IDebugService, config: string, highlights: Model.IHighlight[] = []) {
++		super(highlights);
++		this.debugService = debugService;
++		this.configurationName = config;
++	}
++
++	public getLabel(): string {
++		return this.configurationName;
++	}
++
++	public getAriaLabel(): string {
++		return nls.localize('entryAriaLabel', ""{0}, debug"", this.getLabel());
++	}
++
++	public run(mode: QuickOpen.Mode, context: Model.IContext): boolean {
++		if (mode === QuickOpen.Mode.PREVIEW) {
++			return false;
++		}
++		// Run selected debug configuration
++		this.debugService.createProcess(this.configurationName).done(undefined, errors.onUnexpectedError);
++		this.debugService.getViewModel().setSelectedConfigurationName(this.configurationName);
++
++		return true;
++	}
++}
++
++export class QuickOpenHandler extends Quickopen.QuickOpenHandler {
++
++	private debugService: IDebugService;
++	private quickOpenService: IQuickOpenService;
++
++	constructor(
++		@IQuickOpenService quickOpenService: IQuickOpenService,
++		@IDebugService debugService: IDebugService
++	) {
++		super();
++
++		this.quickOpenService = quickOpenService;
++		this.debugService = debugService;
++	}
++
++	public getAriaLabel(): string {
++		return nls.localize('debugAriaLabel', ""Type a name of a launch configuration to run."");
++	}
++
++	public getResults(input: string): TPromise<Model.QuickOpenModel> {
++		const configurationNames = this.debugService.getConfigurationManager().getConfigurationNames()
++			.sort((a, b) => a.localeCompare(b))",Do not sort,2017-02-21 10:55:25
+764,"@@ -0,0 +1,89 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import nls = require('vs/nls');
++import Filters = require('vs/base/common/filters');
++import { TPromise } from 'vs/base/common/winjs.base';
++import Quickopen = require('vs/workbench/browser/quickopen');
++import QuickOpen = require('vs/base/parts/quickopen/common/quickOpen');
++import Model = require('vs/base/parts/quickopen/browser/quickOpenModel');
++import { IQuickOpenService } from 'vs/platform/quickOpen/common/quickOpen';
++import { IDebugService } from 'vs/workbench/parts/debug/common/debug';
++import * as errors from 'vs/base/common/errors';
++
++class DebugEntry extends Model.QuickOpenEntry {
++	private debugService: IDebugService;
++	private configurationName: string;
++
++	constructor(debugService: IDebugService, config: string, highlights: Model.IHighlight[] = []) {
++		super(highlights);
++		this.debugService = debugService;
++		this.configurationName = config;
++	}
++
++	public getLabel(): string {
++		return this.configurationName;
++	}
++
++	public getAriaLabel(): string {
++		return nls.localize('entryAriaLabel', ""{0}, debug"", this.getLabel());
++	}
++
++	public run(mode: QuickOpen.Mode, context: Model.IContext): boolean {
++		if (mode === QuickOpen.Mode.PREVIEW) {
++			return false;
++		}
++		// Run selected debug configuration
++		this.debugService.createProcess(this.configurationName).done(undefined, errors.onUnexpectedError);
++		this.debugService.getViewModel().setSelectedConfigurationName(this.configurationName);
++
++		return true;
++	}
++}
++
++export class QuickOpenHandler extends Quickopen.QuickOpenHandler {
++
++	private debugService: IDebugService;
++	private quickOpenService: IQuickOpenService;
++
++	constructor(
++		@IQuickOpenService quickOpenService: IQuickOpenService,
++		@IDebugService debugService: IDebugService
++	) {
++		super();
++
++		this.quickOpenService = quickOpenService;
++		this.debugService = debugService;
++	}
++
++	public getAriaLabel(): string {
++		return nls.localize('debugAriaLabel', ""Type a name of a launch configuration to run."");
++	}
++
++	public getResults(input: string): TPromise<Model.QuickOpenModel> {
++		const configurationNames = this.debugService.getConfigurationManager().getConfigurationNames()
++			.sort((a, b) => a.localeCompare(b))
++			.map(config => ({ config: config, highlights: Filters.matchesContiguousSubString(input, config) }))
++			.filter(({ highlights }) => !!highlights)
++			.map(({ config, highlights }) => new DebugEntry(this.debugService, config, highlights));
++
++		return TPromise.as(new Model.QuickOpenModel(configurationNames));
++	}
++
++	public getAutoFocus(input: string): QuickOpen.IAutoFocus {
++		return {
++			autoFocusFirstEntry: !!input
++		};
++	}
++
++	public getEmptyLabel(searchString: string): string {
++		if (searchString.length > 0) {
++			return nls.localize('noConfigurationsMatching', ""No debug configurations matching"");
++		}
++
++		return nls.localize('noConfigurationsFound', ""No debug configurations found"");",Update label to also contain '. Please create a 'launch.json' file.',2017-02-21 10:47:53
+950,"@@ -0,0 +1,9 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++/// <reference path='../../../../src/vs/vscode.d.ts'/>
++/// <reference path='../../../../src/vs/vscode.proposed.d.ts'/>","Not needed, I believe. Remove to clarify.",2017-05-23 18:19:44
+22,"@@ -0,0 +1,9 @@
++[Desktop Entry]
++Type=Application
++Encoding=UTF-8
++Name=Visual Studio Code
++Comment=Code Editing. Redefined. Build and debug modern web and cloud applications.
++Exec=code","The `Exec` property depends on the symlink made by the installation script. I have hardcoded the script (`install.py`) in a way that the symlink will always be called `code`.
+",2015-12-08 19:26:42
+845,"@@ -0,0 +1,95 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import { Registry } from 'vs/platform/platform';
++import { Action } from 'vs/base/common/actions';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { IWorkbenchActionRegistry, Extensions } from 'vs/workbench/common/actionRegistry';
++import { IPartService, Parts } from 'vs/workbench/services/part/common/partService';
++import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
++
++const RESIZE_INCREMENT = 50;
++
++export class ExpandViewAction extends Action {
++
++	public static ID = 'workbench.action.expandView';
++	public static LABEL = nls.localize('expandView', ""Expand Current View"");","I suggest to name this differently, e.g. ""Increase Current View Size"" and `workbench.action.increaseViewSize`",2017-03-22 13:25:37
+846,"@@ -0,0 +1,95 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import { Registry } from 'vs/platform/platform';
++import { Action } from 'vs/base/common/actions';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { IWorkbenchActionRegistry, Extensions } from 'vs/workbench/common/actionRegistry';
++import { IPartService, Parts } from 'vs/workbench/services/part/common/partService';
++import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
++
++const RESIZE_INCREMENT = 50;
++
++export class ExpandViewAction extends Action {
++
++	public static ID = 'workbench.action.expandView';
++	public static LABEL = nls.localize('expandView', ""Expand Current View"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++
++	) {
++		super(id, label);
++
++		this.enabled = !!this.partService;
++	}
++
++	public run(): TPromise<any> {
++
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);",This logic should be extracted into a base class and shared across both actions.,2017-03-22 13:26:11
+832,"@@ -0,0 +1,95 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import { Registry } from 'vs/platform/platform';
++import { Action } from 'vs/base/common/actions';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { IWorkbenchActionRegistry, Extensions } from 'vs/workbench/common/actionRegistry';
++import { IPartService, Parts } from 'vs/workbench/services/part/common/partService';
++import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
++
++const RESIZE_INCREMENT = 50;
++
++export class ExpandViewAction extends Action {
++
++	public static ID = 'workbench.action.expandView';
++	public static LABEL = nls.localize('expandView', ""Expand Current View"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++
++	) {
++		super(id, label);
++
++		this.enabled = !!this.partService;
++	}
++
++	public run(): TPromise<any> {
++
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++
++		if (isSidebarFocus) {
++			return this.partService.resizePart(Parts.SIDEBAR_PART, RESIZE_INCREMENT);
++		}
++		else if (isPanelFocus) {
++			return this.partService.resizePart(Parts.PANEL_PART, RESIZE_INCREMENT);
++		}
++		else if (isEditorFocus) {
++			// console.log('editor f1ocus');
++			return this.partService.resizePart(Parts.EDITOR_PART, RESIZE_INCREMENT);
++		}
++		return TPromise.as(false);
++	}
++}
++
++export class ContractViewAction extends Action {",It seems to me that a lot of the code in ```ContractViewAction``` looks the same with ```ExpandViewAction``` except for the increment value which could be abstracted to a ```BaseResizeViewAction``` and an argument ```INCREMENT_DIRECTION``` (probably 1 or -1) could be passed down.,2017-03-20 00:05:45
+847,"@@ -0,0 +1,95 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import nls = require('vs/nls');
++import { Registry } from 'vs/platform/platform';
++import { Action } from 'vs/base/common/actions';
++import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { IWorkbenchActionRegistry, Extensions } from 'vs/workbench/common/actionRegistry';
++import { IPartService, Parts } from 'vs/workbench/services/part/common/partService';
++import { KeyMod, KeyCode } from 'vs/base/common/keyCodes';
++
++const RESIZE_INCREMENT = 50;
++
++export class ExpandViewAction extends Action {
++
++	public static ID = 'workbench.action.expandView';
++	public static LABEL = nls.localize('expandView', ""Expand Current View"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++
++	) {
++		super(id, label);
++
++		this.enabled = !!this.partService;
++	}
++
++	public run(): TPromise<any> {
++
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++
++		if (isSidebarFocus) {
++			return this.partService.resizePart(Parts.SIDEBAR_PART, RESIZE_INCREMENT);
++		}
++		else if (isPanelFocus) {
++			return this.partService.resizePart(Parts.PANEL_PART, RESIZE_INCREMENT);
++		}
++		else if (isEditorFocus) {
++			// console.log('editor f1ocus');
++			return this.partService.resizePart(Parts.EDITOR_PART, RESIZE_INCREMENT);
++		}
++		return TPromise.as(false);
++	}
++}
++
++export class ContractViewAction extends Action {
++
++	public static ID = 'workbench.action.contractView';
++	public static LABEL = nls.localize('contractView', ""Contract Current View"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++
++	) {
++		super(id, label);
++
++		this.enabled = !!this.partService;
++	}
++
++	public run(): TPromise<any> {
++
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++
++		// we ask but layout may not deliver, if limits silently ignore
++
++		if (isSidebarFocus) {
++			return this.partService.resizePart(Parts.SIDEBAR_PART, -RESIZE_INCREMENT);
++		}
++		else if (isPanelFocus) {
++			return this.partService.resizePart(Parts.PANEL_PART, -RESIZE_INCREMENT);
++		}
++		else if (isEditorFocus) {
++			return this.partService.resizePart(Parts.EDITOR_PART, -RESIZE_INCREMENT);
++		}
++		return TPromise.as(false);
++	}
++}
++
++// probably won't have default key bindings, set up for easy test...
++
++const registry = Registry.as<IWorkbenchActionRegistry>(Extensions.WorkbenchActions);
++registry.registerWorkbenchAction(new SyncActionDescriptor(ExpandViewAction, ExpandViewAction.ID, ExpandViewAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KEY_B }), 'View: Expand View', nls.localize('view', ""View""));",Are these keybindings just for testing?,2017-03-22 13:26:42
+612,"@@ -0,0 +1,95 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++'use strict';
++
++import { TPromise } from 'vs/base/common/winjs.base';
++import { IRequestOptions, IRequestContext, IRequestFunction } from 'vs/base/node/request';
++import { Readable } from 'stream';
++import { RequestService as NodeRequestService } from 'vs/platform/request/node/requestService';
++
++/**
++ * This service exposes the `request` API, while using the global
++ * or configured proxy settings.
++ */
++export class RequestService extends NodeRequestService {
++	request(options: IRequestOptions): TPromise<IRequestContext> {
++		return super.request(options, xhrRequest);
++	}
++}
++
++class ArryBufferStream extends Readable {",nit: Don't you mean ArrAyBufferStream?,2016-12-14 22:38:17
+745,"@@ -0,0 +1,97 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import 'vs/css!./dnd';
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
++import { ICodeEditor, IEditorMouseEvent } from 'vs/editor/browser/editorBrowser';
++import { editorContribution } from 'vs/editor/browser/editorBrowserExtensions';
++import * as editorCommon from 'vs/editor/common/editorCommon';
++import { Position } from 'vs/editor/common/core/position';
++import { Selection } from 'vs/editor/common/core/selection';
++import { DragTargetHintWidget } from './dndHintWidget';
++import { DragAndDropCommand } from '../common/dragAndDropCommand';
++
++@editorContribution
++export class DragAndDropController implements editorCommon.IEditorContribution {
++
++	private static ID = 'editor.contrib.dragAndDrop';
++
++	private _editor: ICodeEditor;
++	private _toUnhook: IDisposable[];
++	private _targetWidget: DragTargetHintWidget;
++	private _active: boolean;
++	private _dragSelection: Selection;
++
++	static get(editor: editorCommon.ICommonCodeEditor): DragAndDropController {
++		return editor.getContribution<DragAndDropController>(DragAndDropController.ID);
++	}
++
++	constructor(editor: ICodeEditor) {
++		this._editor = editor;
++		this._toUnhook = [];
++		this._toUnhook.push(this._editor.onMouseDrag((e: IEditorMouseEvent) => this._onEditorMouseDrag(e)));
++		this._toUnhook.push(this._editor.onMouseDrop((e: IEditorMouseEvent) => this._onEditorMouseDrop(e)));
++		this._targetWidget = new DragTargetHintWidget(editor);
++		this._active = false;
++	}
++
++	private _onEditorMouseDrag(mouseEvent: IEditorMouseEvent): void {
++		let target = mouseEvent.target;
++
++		if (this._active) {
++			this._targetWidget.showAt(target.position);
++		} else {
++			let possibleSelections = this._editor.getSelections().filter(selection => selection.containsPosition(target.position));
++
++			if (possibleSelections.length === 1) {
++				this._active = true;
++				this._dragSelection = possibleSelections[0];
++				this._targetWidget.showAt(target.position);
++			}
++		}
++	}
++
++	private _onEditorMouseDrop(mouseEvent: IEditorMouseEvent): void {
++		let targetPosition = mouseEvent.target.position;","perhaps first thing to do is to check if the mouse went outside the editor. For now, we can consider that a cancel and not do anything...",2017-02-20 11:29:17
+746,"@@ -0,0 +1,97 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import 'vs/css!./dnd';
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
++import { ICodeEditor, IEditorMouseEvent } from 'vs/editor/browser/editorBrowser';
++import { editorContribution } from 'vs/editor/browser/editorBrowserExtensions';
++import * as editorCommon from 'vs/editor/common/editorCommon';
++import { Position } from 'vs/editor/common/core/position';
++import { Selection } from 'vs/editor/common/core/selection';
++import { DragTargetHintWidget } from './dndHintWidget';
++import { DragAndDropCommand } from '../common/dragAndDropCommand';
++
++@editorContribution
++export class DragAndDropController implements editorCommon.IEditorContribution {
++
++	private static ID = 'editor.contrib.dragAndDrop';
++
++	private _editor: ICodeEditor;
++	private _toUnhook: IDisposable[];
++	private _targetWidget: DragTargetHintWidget;
++	private _active: boolean;
++	private _dragSelection: Selection;
++
++	static get(editor: editorCommon.ICommonCodeEditor): DragAndDropController {
++		return editor.getContribution<DragAndDropController>(DragAndDropController.ID);
++	}
++
++	constructor(editor: ICodeEditor) {
++		this._editor = editor;
++		this._toUnhook = [];
++		this._toUnhook.push(this._editor.onMouseDrag((e: IEditorMouseEvent) => this._onEditorMouseDrag(e)));
++		this._toUnhook.push(this._editor.onMouseDrop((e: IEditorMouseEvent) => this._onEditorMouseDrop(e)));
++		this._targetWidget = new DragTargetHintWidget(editor);
++		this._active = false;
++	}
++
++	private _onEditorMouseDrag(mouseEvent: IEditorMouseEvent): void {
++		let target = mouseEvent.target;
++
++		if (this._active) {
++			this._targetWidget.showAt(target.position);
++		} else {
++			let possibleSelections = this._editor.getSelections().filter(selection => selection.containsPosition(target.position));
++
++			if (possibleSelections.length === 1) {
++				this._active = true;
++				this._dragSelection = possibleSelections[0];
++				this._targetWidget.showAt(target.position);
++			}
++		}
++	}
++
++	private _onEditorMouseDrop(mouseEvent: IEditorMouseEvent): void {
++		let targetPosition = mouseEvent.target.position;
++
++		if (targetPosition) {
++			let newCursorPosition = new Position(targetPosition.lineNumber, targetPosition.column);
++
++			if (this._dragSelection.containsPosition(newCursorPosition)) {
++				let newSelections = this._editor.getSelections().map(selection => {",this code can be simplified once we guard in the mouseHandler to only begin dnd if the editor has precisely one selection,2017-02-20 11:31:14
+747,"@@ -0,0 +1,97 @@
++/*---------------------------------------------------------------------------------------------
++ *  Copyright (c) Microsoft Corporation. All rights reserved.
++ *  Licensed under the MIT License. See License.txt in the project root for license information.
++ *--------------------------------------------------------------------------------------------*/
++
++'use strict';
++
++import 'vs/css!./dnd';
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
++import { ICodeEditor, IEditorMouseEvent } from 'vs/editor/browser/editorBrowser';
++import { editorContribution } from 'vs/editor/browser/editorBrowserExtensions';
++import * as editorCommon from 'vs/editor/common/editorCommon';
++import { Position } from 'vs/editor/common/core/position';
++import { Selection } from 'vs/editor/common/core/selection';
++import { DragTargetHintWidget } from './dndHintWidget';
++import { DragAndDropCommand } from '../common/dragAndDropCommand';
++
++@editorContribution
++export class DragAndDropController implements editorCommon.IEditorContribution {
++
++	private static ID = 'editor.contrib.dragAndDrop';
++
++	private _editor: ICodeEditor;
++	private _toUnhook: IDisposable[];
++	private _targetWidget: DragTargetHintWidget;
++	private _active: boolean;
++	private _dragSelection: Selection;
++
++	static get(editor: editorCommon.ICommonCodeEditor): DragAndDropController {
++		return editor.getContribution<DragAndDropController>(DragAndDropController.ID);
++	}
++
++	constructor(editor: ICodeEditor) {
++		this._editor = editor;
++		this._toUnhook = [];
++		this._toUnhook.push(this._editor.onMouseDrag((e: IEditorMouseEvent) => this._onEditorMouseDrag(e)));
++		this._toUnhook.push(this._editor.onMouseDrop((e: IEditorMouseEvent) => this._onEditorMouseDrop(e)));
++		this._targetWidget = new DragTargetHintWidget(editor);
++		this._active = false;
++	}
++
++	private _onEditorMouseDrag(mouseEvent: IEditorMouseEvent): void {
++		let target = mouseEvent.target;
++
++		if (this._active) {
++			this._targetWidget.showAt(target.position);
++		} else {
++			let possibleSelections = this._editor.getSelections().filter(selection => selection.containsPosition(target.position));
++
++			if (possibleSelections.length === 1) {
++				this._active = true;
++				this._dragSelection = possibleSelections[0];
++				this._targetWidget.showAt(target.position);
++			}
++		}
++	}
++
++	private _onEditorMouseDrop(mouseEvent: IEditorMouseEvent): void {
++		let targetPosition = mouseEvent.target.position;
++
++		if (targetPosition) {
++			let newCursorPosition = new Position(targetPosition.lineNumber, targetPosition.column);
++
++			if (this._dragSelection.containsPosition(newCursorPosition)) {
++				let newSelections = this._editor.getSelections().map(selection => {
++					if (selection.equalsSelection(this._dragSelection)) {
++						return new Selection(newCursorPosition.lineNumber, newCursorPosition.column, newCursorPosition.lineNumber, newCursorPosition.column);
++					} else {
++						return selection;
++					}
++				});
++				this._editor.setSelections(newSelections);
++			} else {
++				this._editor.executeCommand(DragAndDropController.ID, new DragAndDropCommand(this._dragSelection, newCursorPosition));
++			}
++		}
++
++		this._hideWidgets();",a single widget => `_hideWidget`,2017-02-20 11:31:40
+4,"@@ -1,101 +1,104 @@
+ {
+-	""name"": ""csharp-o"",","why is this just whitespace changes?
+",2015-11-20 11:59:20
+782,"@@ -1,2 +1,2 @@
+-import * as Proto from '../node_modules/typescript/lib/protocol';
++import * as Proto from '../../node_modules/typescript/lib/protocol';",Use `import * as Proto from 'typescript/lib/protocol';` instead to avoid the path dependency,2017-03-01 08:26:04
+972,"@@ -1,20 +1,23 @@
+-# Visual Studio Code - Open Source
++# Code - Open Source
+ 
+ [![Build Status](https://travis-ci.org/Microsoft/vscode.svg?branch=master)](https://travis-ci.org/Microsoft/vscode)
+ [![Build Status](https://ci.appveyor.com/api/projects/status/vuhlhg80tj3e2a0l/branch/master?svg=true)](https://ci.appveyor.com/project/VSCode/vscode)
+ [![Coverage Status](https://img.shields.io/coveralls/Microsoft/vscode/master.svg)](https://coveralls.io/github/Microsoft/vscode?branch=master)
+ [![Gitter](https://img.shields.io/badge/chat-on%20gitter-blue.svg)](https://gitter.im/Microsoft/vscode)
+ 
+-[VS Code](https://code.visualstudio.com) is a new type of tool that combines the simplicity of
++Code is a new type of tool that combines the simplicity of
+ a code editor with what developers need for their core edit-build-debug cycle. Code
+ provides comprehensive editing and debugging support, an extensibility model, and lightweight integration with existing tools.
+ 
+-VS Code is updated monthly with new features and bug fixes. You can download it for Windows, Mac and Linux on [VS Code's website](https://code.visualstudio.com/Download). To get the latest releases everyday, you can install the [Insiders version of VS Code](https://code.visualstudio.com/insiders). This builds from the master branch and is updated at least daily.
+-
+ <p align=""center"">
+   <img alt=""VS Code in action"" src=""https://cloud.githubusercontent.com/assets/11839736/16642200/6624dde0-43bd-11e6-8595-c81885ba0dc2.png"">
+ </p>
+ 
++Code is updated monthly with new features and bug fixes.
++You can download sources of released versions from [GitHub Releases](https://github.com/Microsoft/vscode/releases).
++Building binaries for Windows, OS X and Linux [instructions](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source)",Using Mac instead of OS X?,2017-06-14 17:58:17
+257,"@@ -1,5 +1,5 @@
+ {
+-	""name"": ""MagicRegExp"",
++	""name"": ""Python"",","This one should say something else -- that's a syntax for Python regexps. The name isn't that important, it can be ""Regular Expressions (Python)""
+",2016-08-23 01:18:20
+151,"@@ -1,6 +1,6 @@
+ {
+ 	""account"": ""monacobuild"",
+ 	""container"": ""debuggers"",
+-	""zip"": ""624d700/node-debug.zip"",
++	""zip"": ""3c7ed19/node-debug.zip"",","Is this change related to 3077?
+",2016-05-20 08:18:55
+704,"@@ -1,6 +1,7 @@
+ {
+-	""configuration.validate.enable"": ""Whether php validation is enabled or not."",
+-	""configuration.validate.executablePath"": ""Points to the php executable."",
++	""configuration.builtInCompletions.enable"": ""Enable/disable built-in PHP completions."",
++	""configuration.validate.enable"": ""Enable/disable built-in PHP validation."",
++	""configuration.validate.executablePath"": ""Points to the PHP executable."",","Do we have a strategy for aliasing settings names? e.g. php.validate.enable is somewhat ambiguous, but it's also already in use.",2017-01-23 06:37:26
+787,"@@ -10,6 +10,7 @@
+ 	""insertSpaceAfterFunctionKeywordForAnonymousFunctions"": true,
+ 	""insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis"": false,
+ 	""insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets"": false,
++	""insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces"": true,",I'm inclined to leave this file alone for now since it is used for the VSCode codebase itself. Any specific reasons for adding this setting here?,2017-03-02 05:24:46
+327,"@@ -100,14 +100,17 @@ export class GitStatusbarItem implements IStatusbarItem {
+ 
+ 	private onGitServiceChange(): void {
+ 		const model = this.gitService.getModel();
++		const ps1 = model.getPS1();
++		const tags = model.getRefs().filter(iref => iref.commit.substr(0,8) === ps1);","You should use `model.getHEAD().commit` to compare with `iref.commit`.
+",2016-10-14 13:23:34
+328,"@@ -100,14 +100,17 @@ export class GitStatusbarItem implements IStatusbarItem {
+ 
+ 	private onGitServiceChange(): void {
+ 		const model = this.gitService.getModel();
++		const ps1 = model.getPS1();
++		const tags = model.getRefs().filter(iref => iref.commit.substr(0,8) === ps1);
++		const name = tags.length > 0 ? tags[0].name : model.getPS1();","This breaks the `+*!` symbols in front of branches, since whenever a branch is checked out, `model.getPS1` is never called.
+",2016-10-14 13:24:05
+889,"@@ -100,18 +133,35 @@ export class TerminalLinkHandler {
+ 
+ 	protected get _localLinkRegex(): RegExp {
+ 		if (this._platform === platform.Platform.Windows) {
+-			return WINDOWS_LOCAL_LINK_REGEX;
++			return this._winLocalLinkPattern;
+ 		}
+-		return UNIX_LIKE_LOCAL_LINK_REGEX;
++		return this._unixLocalLinkPattern;
+ 	}
+ 
+ 	private _handleLocalLink(link: string): TPromise<void> {
+ 		return this._resolvePath(link).then(resolvedLink => {
+ 			if (!resolvedLink) {
+ 				return void 0;
+ 			}
+-			const resource = Uri.file(path.normalize(path.resolve(resolvedLink)));
+-			return this._editorService.openEditor({ resource }).then(() => void 0);
++
++			let normalizedPath = path.normalize(path.resolve(resolvedLink));","Can this be pulled into a `formatLocalLinkPath` or similar named function that returns a URI in form `<path>#line,col`?",2017-04-17 17:47:23
+885,"@@ -100,18 +133,35 @@ export class TerminalLinkHandler {
+ 
+ 	protected get _localLinkRegex(): RegExp {
+ 		if (this._platform === platform.Platform.Windows) {
+-			return WINDOWS_LOCAL_LINK_REGEX;
++			return this._winLocalLinkPattern;
+ 		}
+-		return UNIX_LIKE_LOCAL_LINK_REGEX;
++		return this._unixLocalLinkPattern;
+ 	}
+ 
+ 	private _handleLocalLink(link: string): TPromise<void> {
+ 		return this._resolvePath(link).then(resolvedLink => {
+ 			if (!resolvedLink) {
+ 				return void 0;
+ 			}
+-			const resource = Uri.file(path.normalize(path.resolve(resolvedLink)));
+-			return this._editorService.openEditor({ resource }).then(() => void 0);
++
++			let normalizedPath = path.normalize(path.resolve(resolvedLink));
++			const normalizedUrl = this.extractLinkUrl(normalizedPath);
++
++			const lineColumnInfo: LineColumnInfo = this.extractLineColumnInfo(normalizedPath);
++			if (lineColumnInfo.lineNumber) {
++				normalizedPath += `#${lineColumnInfo.lineNumber}`;
++
++				if (lineColumnInfo.columnNumber) {
++					normalizedPath += `,${lineColumnInfo.columnNumber}`;
++				}
++			}
++
++			let resource = Uri.file(normalizedUrl);
++			resource = resource.with({
++				fragment: Uri.parse(normalizedPath).fragment
++			});
++
++			return this._openerService.open(resource);",Does `this._editorService.openEditor` ignore the line/col?,2017-04-17 17:39:38
+710,"@@ -100,19 +100,15 @@ class CodeLensAdapter {
+ }
+ 
+ class DefinitionAdapter {
+-
+-	private _documents: ExtHostDocuments;
+-	private _provider: vscode.DefinitionProvider;
+-
+-	constructor(documents: ExtHostDocuments, provider: vscode.DefinitionProvider) {
+-		this._documents = documents;
+-		this._provider = provider;
+-	}
++	constructor(
++		private documents: ExtHostDocuments,
++		private provider: vscode.DefinitionProvider)
++	{ }",restore previous coding style,2017-02-02 07:59:12
+662,"@@ -100,3 +100,16 @@ CommandsRegistry.registerCommand('_workbench.previewHtml', function (accessor: S
+ 		.openEditor(input, { pinned: true }, position)
+ 		.then(editor => true);
+ });
++
++CommandsRegistry.registerCommand('_workbench.htmlPreview.postMessage', (accessor: ServicesAccessor, resource: URI | string, message: any) => {
++	const uri = resource instanceof URI ? resource : URI.parse(resource);
++	const activePreview = accessor.get(IWorkbenchEditorService).getVisibleEditors()
++		.filter(c => c instanceof HtmlPreviewPart)
++		.map(e => e as HtmlPreviewPart)
++		.filter(e => e.model.uri.scheme == uri.scheme && e.model.uri.path === uri.path);
++	if (activePreview.length) {",You may want to highlight in the description or doc that only the first visible matched htmlPreview document can get the message.,2017-01-12 05:01:32
+804,"@@ -100,6 +100,15 @@ suite('workspace-namespace', () => {
+ 		});
+ 	});
+ 
++	test('openTextDocument, untitled without path but language ID and contents', function () {
++		return workspace.openTextDocument({ language: 'html', contents: '<h1>Hello world!</h1>' }).then(doc => {","singular, `content`?",2017-03-07 08:20:17
+160,"@@ -101,11 +98,19 @@ export class TerminalPanel extends Panel {
+ 	) {
+ 		super(TERMINAL_PANEL_ID, telemetryService);
+ 		this.toDispose = [];
++		configurationService.onDidUpdateConfiguration(()=>{
++			this.applyFont();","If #6456 gets done, this should reuse the the `onDidUpdateConfiguration` that's being merged into master soon https://github.com/Microsoft/vscode/pull/6985/commits/3fde03980baf7d33d14c36dce623ad1c89470d93
+",2016-05-28 20:56:50
+83,"@@ -101,7 +102,8 @@ class ExtHostApiCommands {
+ 			description: 'Execute completion item provider.',
+ 			args: [
+ 				{ name: 'uri', description: 'Uri of a text document', constraint: URI },
+-				{ name: 'position', description: 'Position in a text document', constraint: types.Position }
++				{ name: 'position', description: 'Position in a text document', constraint: types.Position },
++				{ name: 'triggerCharacter', description: 'Trigger completion when the user types the character, like `,` or `(`', constraint: String }
+ 			],","as above
+",2016-03-22 10:58:58
+879,"@@ -102,11 +104,16 @@ export class MainThreadEditors extends MainThreadEditorsShape {
+ 
+ 	// --- from extension host process
+ 
+-	$tryShowTextDocument(resource: URI, position: EditorPosition, preserveFocus: boolean): TPromise<string> {
++	$tryShowTextDocument(resource: URI, options: vscode.ShowTextDocumentOptions): TPromise<string> {
++		const position: EditorPosition = TypeConverters.fromViewColumn(options.column);","@jrieken I moved some of the data massaging into here, so that it could take the same `ShowTextDocumentOptions` (since I think you can technically call the proxy methods from inside an extension).",2017-04-13 18:55:05
+155,"@@ -102,6 +102,7 @@ export class Symbol {
+ export class ScopeBuilder implements nodes.IVisitor {","Thinking about this again, I think we should put all css variables always in the global scope (along with the local scope). That way intellisense will show all variables.
+That simplifies the code a bit and we get rid of the _isRootSelectorNode, which is not confusing and not correct when sass and less variables are found.
+",2016-05-20 10:20:17
+932,"@@ -1020,6 +1063,30 @@ export class ShowWorkspaceRecommendedExtensionsAction extends Action {
+ 	}
+ }
+ 
++export class InstallWorkspaceRecommendedExtensionsAction extends Action {
++
++	static ID = 'workbench.extensions.action.installWorkspaceRecommendedExtensions';
++	static LABEL = localize('installWorkspaceRecommendedExtensions', ""Install Workspace Recommended Extensions"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkspaceContextService contextService: IWorkspaceContextService,
++		@IViewletService private viewletService: IViewletService,
++		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService",Remove unused services,2017-05-12 09:15:41
+928,"@@ -1020,6 +1063,30 @@ export class ShowWorkspaceRecommendedExtensionsAction extends Action {
+ 	}
+ }
+ 
++export class InstallWorkspaceRecommendedExtensionsAction extends Action {
++
++	static ID = 'workbench.extensions.action.installWorkspaceRecommendedExtensions';
++	static LABEL = localize('installWorkspaceRecommendedExtensions', ""Install Workspace Recommended Extensions"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkspaceContextService contextService: IWorkspaceContextService,
++		@IViewletService private viewletService: IViewletService,
++		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService
++	) {
++		super(id, label, null, contextService.hasWorkspace());
++	}
++
++	run(): TPromise<void> {
++		return this.extensionsWorkbenchService.installAllWorkspaceRecommendations();
++	}
++
++	protected isEnabled(): boolean {
++		return true;",It should not be enabled if there are no recommendations or all recommended extensions are already installed and also if there is a workspace or not,2017-05-12 09:05:15
+722,"@@ -1023,6 +1026,21 @@ export class WindowsManager implements IWindowsMainService {
+ 		return res && res[0];
+ 	}
+ 
++	private findBestWindow(context: OpenContext, filePaths: IPath[]): VSCodeWindow {
++		const findContainer = context === OpenContext.DESKTOP || context === OpenContext.CLI;
++		return findContainer && this.findContainingWindow(filePaths) || this.getLastActiveWindow();","I find it hard to understand the precedence logic here without paranthesis, suggest to rewrite to:
+
+`return (findContainer && this.findContainingWindow(filePaths)) || this.getLastActiveWindow();`",2017-02-07 06:26:45
+283,"@@ -103,22 +118,31 @@ export class LineNumbersOverlay extends DynamicViewOverlay {
+ 		let visibleStartLineNumber = ctx.visibleRange.startLineNumber;
+ 		let visibleEndLineNumber = ctx.visibleRange.endLineNumber;
+ 		let common = '<div class=""' + ClassNames.LINE_NUMBERS + lineHeightClassName + '"" style=""left:' + this._lineNumbersLeft.toString() + 'px;width:' + this._lineNumbersWidth.toString() + 'px;height:' + lineHeight + 'px;"">';
++		let commonLeft = '<div class=""' + ClassNames.LINE_NUMBERS + lineHeightClassName + '"" style=""text-align:left;left:' + this._lineNumbersLeft.toString() + 'px;width:' + this._lineNumbersWidth.toString() + 'px;height:' + lineHeight + 'px;"">';
+ 
+ 		let output: string[] = [];
+ 		for (let lineNumber = visibleStartLineNumber; lineNumber <= visibleEndLineNumber; lineNumber++) {
+ 			let lineIndex = lineNumber - visibleStartLineNumber;
++			let position = this._context.model.convertViewPositionToModelPosition(lineNumber, 1);
++			let relativeLineNumber = position.lineNumber;
++
++			if (position.column === 1) {
++				if (this._relativeLineNumbers) {","The test `if (this._relativeLineNumbers)` should be the first thing done here before doing any position conversions. All the new rendering code should go in this `if`. All the old rendering code should be maintained in an `else` branch. As it looks right now, regular line number rendering appears to be broken.
+",2016-09-21 06:15:57
+222,"@@ -103,7 +115,15 @@ export class OpenAnythingHandler extends QuickOpenHandler {
+ 		// Check Cache first
+ 		let cachedResults = this.getResultsFromCache(searchValue, searchWithRange ? searchWithRange.range : null);
+ 		if (cachedResults) {
+-			return TPromise.as(new QuickOpenModel(cachedResults));
++			timerEvent.data = <ITimerEventData>{","I find quite some similarities to the ITimerEventData further below in the file, can we extract a method and use it in both places to construct the ITimerEventData?
+",2016-07-14 17:37:34
+258,"@@ -104,6 +104,49 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 		return this.domNode;
+ 	}
+ 
++	private getHoveredExpression(lineContent: string, range: Range) : Range {","Please rename this to better represent what is specific about this method
+",2016-08-24 14:10:19
+245,"@@ -104,6 +104,49 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 		return this.domNode;
+ 	}
+ 
++	private getHoveredExpression(lineContent: string, range: Range) : Range {
++		let matchingExpression = undefined;
++		let startOffset = 0;
++
++		// Some example supported expressions: myVar.prop, a.b.c.d, myVar?.prop, myVar->prop, MyClass::StaticProp, *myVar
++		// Match any character except a set of characters which often break interesting sub-expressions
++		let expression: RegExp = /([^()\[\]{}<>\s+\-/%~#^;=|,`!]|\->)+/g;","doesn't this filter out template/generic types? For instance, in C++, an expression like this should be valid:
+CSeafood<Squid>::Swim  where CSeafood is a template instance with template parameter Squid. 
+",2016-08-02 00:31:44
+243,"@@ -104,6 +104,49 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 		return this.domNode;
+ 	}
+ 
++	private getHoveredExpression(lineContent: string, range: Range) : Range {
++		let matchingExpression = undefined;
++		let startOffset = 0;
++
++		// Some example supported expressions: myVar.prop, a.b.c.d, myVar?.prop, myVar->prop, MyClass::StaticProp, *myVar
++		// Match any character except a set of characters which often break interesting sub-expressions
++		let expression: RegExp = /([^()\[\]{}<>\s+\-/%~#^;=|,`!]|\->)+/g;
++		let result = undefined;
++
++		// First find the full expression under the cursor
++		while (result = expression.exec(lineContent)) {
++			let start = result.index + 1;
++			let end = start + result[0].length;
++
++			if (start <= range.startColumn && end >= range.endColumn) {","does this ignore expressions that are split across lines? Do we care?
+",2016-08-02 00:16:09
+244,"@@ -104,6 +104,49 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 		return this.domNode;
+ 	}
+ 
++	private getHoveredExpression(lineContent: string, range: Range) : Range {
++		let matchingExpression = undefined;
++		let startOffset = 0;
++
++		// Some example supported expressions: myVar.prop, a.b.c.d, myVar?.prop, myVar->prop, MyClass::StaticProp, *myVar
++		// Match any character except a set of characters which often break interesting sub-expressions
++		let expression: RegExp = /([^()\[\]{}<>\s+\-/%~#^;=|,`!]|\->)+/g;
++		let result = undefined;
++
++		// First find the full expression under the cursor
++		while (result = expression.exec(lineContent)) {
++			let start = result.index + 1;
++			let end = start + result[0].length;
++
++			if (start <= range.startColumn && end >= range.endColumn) {
++				matchingExpression = result[0];
++				startOffset = start;
++				break;
++			}
++		}
++
++		// If there are non-word characters after the cursor, we want to truncate the expression then.
++		// For example in expression 'a.b.c.d', if the focus was under 'b', 'a.b' would be evaluated.
++		if (matchingExpression) {
++			let subExpression: RegExp = /\w+/g;","This is a good example of why the proper solution long-term is to let the extension handle tokenization. The identifier `x'` is normally invalid in languages, but is a [valid identifier in Haskell](https://www.haskell.org/onlinereport/lexemes.html#sect2.4).
+",2016-08-02 00:18:03
+818,"@@ -105,6 +105,11 @@ configurationRegistry.registerConfiguration({
+ 			'type': 'number',
+ 			'default': 1.2
+ 		},
++		'terminal.integrated.fontWeight': {
++			'type': 'string',
++			'description': nls.localize('terminal.integrated.fontWeight', ""Customizes font weight in terminal.""),","This needs to be something like `enableBold` like how gnome-terminal does it, otherwise this setting will override the terminal's regular bold/normal formatting with what's in this setting.
+
+The logic should then be added as an event listener on the `IConfigurationService` so it's picked up when the setting is changed, something like this:
+
+```
+set class name 'disable-bold' if `enableBold` setting is not set
+```
+
+I use `disable-bold` as the class name here because enableBold will be the standard.",2017-03-12 01:54:49
+315,"@@ -105,6 +105,27 @@ export interface IFileService {
+ 	del(resource: URI, useTrash?: boolean): TPromise<void>;
+ 
+ 	/**
++	 * Backs up the provided file to a temporary directory to be used by the hot
++	 * exit feature and crash recovery.
++	 */
++	backupFile(resource: URI, content: string): TPromise<IFileStat>;","I think all of this should move into textfile.ts (ITextFileService) because in here we talk about all files but for hot exit we only care about text files.
+",2016-10-13 15:04:10
+102,"@@ -105,6 +105,8 @@ export interface IWorkingFilesModel {
+ 	removeEntry(entry: IWorkingFileEntry): IWorkingFileEntry;
+ 	removeEntry(arg1: IWorkingFileEntry | URI): IWorkingFileEntry;
+ 
++	restoreRecentlyRemovedEntry(): IWorkingFileEntry;","Rather something like ""getLastClosedEntry()""
+",2016-04-09 14:42:22
+817,"@@ -106,6 +106,67 @@ export class SplitEditorAction extends Action {
+ 	}
+ }
+ 
++export class JoinTwoGroupsAction extends Action {
++
++	public static ID = 'workbench.action.joinTwoGroups';
++	public static LABEL = nls.localize('joinTwoGroups', ""Join Editors of Two Groups"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IEditorGroupService private editorGroupService: IEditorGroupService
++	) {
++		super(id, label);
++	}
++
++	public run(context?: IEditorContext): TPromise<any> {
++
++		const editorStacksModel = this.editorGroupService.getStacksModel();
++
++		// Return if has no other group to join to
++		if (editorStacksModel.groups.length <= 1) {
++			return TPromise.as(true);
++		}
++
++		let fromPosition: number;
++		let toPosition: number;
++
++		// Joining group is from context, or the active group
++		if (context) {
++			fromPosition = editorStacksModel.positionOfGroup(context.group);
++		} else {
++			fromPosition = editorStacksModel.positionOfGroup(editorStacksModel.activeGroup);
++		}
++
++		// Target group is next group if joining from position one, otherwise it is the previous group
++		if (fromPosition === Position.ONE) {
++			toPosition = fromPosition + 1;
++		} else {
++			toPosition = fromPosition - 1;
++		}
++
++		const fromGroup = editorStacksModel.groupAt(fromPosition);
++		const toGroup = editorStacksModel.groupAt(toPosition);
++
++		const activeEditor = fromGroup.activeEditor;
++		const fromGroupEditors = fromGroup.getEditors();
++		const fromGroupTotalCount = fromGroupEditors.length;
++
++		// If an editor exists in both groups, only the editor in the joining group is kept
++		if (toPosition < fromPosition) {","We still need to improve this: Now we start to move editors from the group to another group starting with the first editor of that group, going to the last. This is bad when the first editor of the group is also the active editor because after each editor is moved, the group will show the next editor as active.
+
+As such, please first move all the inactive editors of the group and only at last the active editor. This will again prevent many unwanted editor change events being fired. ",2017-03-11 13:56:12
+812,"@@ -106,6 +106,71 @@ export class SplitEditorAction extends Action {
+ 	}
+ }
+ 
++export class JoinEditorsAction extends Action {
++
++	public static ID = 'workbench.action.joinEditors';
++	public static LABEL = nls.localize('joinEditors', ""Join Editors"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IEditorGroupService private editorGroupService: IEditorGroupService
++	) {
++		super(id, label, 'join-editors-action');","You do not need the CSS class here unless it would show up as icon, so I suggest to remove it.",2017-03-10 14:23:57
+813,"@@ -106,6 +106,71 @@ export class SplitEditorAction extends Action {
+ 	}
+ }
+ 
++export class JoinEditorsAction extends Action {
++
++	public static ID = 'workbench.action.joinEditors';
++	public static LABEL = nls.localize('joinEditors', ""Join Editors"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IEditorGroupService private editorGroupService: IEditorGroupService
++	) {
++		super(id, label, 'join-editors-action');
++	}
++
++	public run(context?: IEditorContext): TPromise<any> {
++		let editorToJoin: IEditor;","It looks like you only need `position` and `input` from the `IEditor`. If so, I suggest to completley bypass the `editorService` API and do all of this from the `stacks model` that provides all you need (`inputs`, `groups`, a way to convert from a `group` to a `position`) from `editor group service` (there is a bit of overlap for historic reasons).
+
+The `stacks model` is really the truth of what is going up in the 1-3 `editor groups` and you should be able to do everything with it. The more heavy `IEditor` is the actual instance of control that hosts inputs.",2017-03-10 14:26:16
+814,"@@ -106,6 +106,71 @@ export class SplitEditorAction extends Action {
+ 	}
+ }
+ 
++export class JoinEditorsAction extends Action {
++
++	public static ID = 'workbench.action.joinEditors';
++	public static LABEL = nls.localize('joinEditors', ""Join Editors"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IEditorGroupService private editorGroupService: IEditorGroupService
++	) {
++		super(id, label, 'join-editors-action');
++	}
++
++	public run(context?: IEditorContext): TPromise<any> {
++		let editorToJoin: IEditor;
++		if (context) {
++			editorToJoin = this.editorService.getVisibleEditors()[this.editorGroupService.getStacksModel().positionOfGroup(context.group)];
++		} else {
++			editorToJoin = this.editorService.getActiveEditor();
++		}
++
++		// Return if no editor to join
++		if (!editorToJoin) {
++			return TPromise.as(true);
++		}
++
++		const visibleEditors = this.editorService.getVisibleEditors();
++
++		// Return if has no other group to join to
++		if (visibleEditors.length <= 1) {
++			return TPromise.as(true);
++		}
++
++		const toJoinPosition = editorToJoin.position;
++		let targetPosition: number;
++
++		// Join to next group if is position one, otherwise join to previous group
++		if (toJoinPosition === Position.ONE) {
++			targetPosition = toJoinPosition + 1;
++		} else {
++			targetPosition = toJoinPosition - 1;
++		}
++
++		const toJoinEditorInput = editorToJoin.input;
++		const toJoinGroup = this.editorGroupService.getStacksModel().groupAt(toJoinPosition);
++		const targetGroup = this.editorGroupService.getStacksModel().groupAt(targetPosition);
++
++		const toJoinEditors = toJoinGroup.getEditors();
++		const toJoinEditorsTotalCount = toJoinEditors.length;
++
++		// If an editor exists in joining group and target group, only the editor in the joining group is kept.
++		if (targetPosition < toJoinPosition) {
++			toJoinEditors.forEach(e => this.editorGroupService.moveEditor(e, toJoinPosition, targetPosition, targetGroup.count));",This is a bit crazy to do because for each editor that gets moved it will be opened in the target group causing an editor switch. It would be much smoother if the move would happen with the editors opening `inactive` on the target group and only the last one would actually be `active`. There is an option that can be set when opening an editor called `inactive` that I think we should wire into the moveEditor call so that we can optimize for this (for the `openEditor` call [here](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editorPart.ts#L866)).,2017-03-10 14:35:04
+816,"@@ -106,9 +106,10 @@ export interface IEditorGroupService {
+ 
+ 	/**
+ 	 * Moves an editor from one group to another. The index in the group is optional.
++	 * The inactive option is applied when moving across groups.
+ 	 */
+-	moveEditor(input: IEditorInput, from: IEditorGroup, to: IEditorGroup, index?: number): void;
+-	moveEditor(input: IEditorInput, from: Position, to: Position, index?: number): void;
++	moveEditor(input: IEditorInput, from: IEditorGroup, to: IEditorGroup, index?: number, inactive?: boolean): void;",`IMoveOptions`,2017-03-11 07:14:32
+132,"@@ -107,11 +128,19 @@ try {
+ 	console.error(err);
+ }
+ 
+-// Set path according to being built or not
++// If root user, use a root-owned directory for user data
++var configDir = path.join(process.env.HOME, product.dataFolderName);","Are you really sure this is a solid cross platform way of finding out the users home directory? What if it is not defined? Please see https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-main/env.ts#L98 how we get it.
+",2016-04-21 08:54:56
+123,"@@ -107,11 +128,19 @@ try {
+ 	console.error(err);
+ }
+ 
+-// Set path according to being built or not
++// If root user, use a root-owned directory for user data
++var configDir = path.join(process.env.HOME, product.dataFolderName);
+ if (process.env.VSCODE_DEV) {
+-	var appData = app.getPath('appData');
+-	app.setPath('userData', path.join(appData, 'Code-Development'));
++	configDir += '-dev';","Do we need this actually? We already have this: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/electron-main/env.ts#L79
+",2016-04-21 08:43:02
+124,"@@ -107,11 +128,19 @@ try {
+ 	console.error(err);
+ }
+ 
+-// Set path according to being built or not
++// If root user, use a root-owned directory for user data
++var configDir = path.join(process.env.HOME, product.dataFolderName);
+ if (process.env.VSCODE_DEV) {
+-	var appData = app.getPath('appData');
+-	app.setPath('userData', path.join(appData, 'Code-Development'));
++	configDir += '-dev';
+ }
++var userDataDir = path.join(configDir, 'user-data');","Suggest to make this use really no special characters and reflect what it stores. maybe just ""userdata""? it contains all kind of Chromium stuff...
+",2016-04-21 08:43:55
+131,"@@ -107,11 +128,19 @@ try {
+ 	console.error(err);
+ }
+ 
+-// Set path according to being built or not
++// If root user, use a root-owned directory for user data
++var configDir = path.join(process.env.HOME, product.dataFolderName);
+ if (process.env.VSCODE_DEV) {
+-	var appData = app.getPath('appData');
+-	app.setPath('userData', path.join(appData, 'Code-Development'));
++	configDir += '-dev';
+ }
++var userDataDir = path.join(configDir, 'user-data');
++
++// Attempt migrations if userDataDir does not exist
++if (!fs.existsSync(userDataDir)) {","What if the userdata dir exists but is a file and not a folder?
+",2016-04-21 08:51:39
+125,"@@ -107,11 +128,19 @@ try {
+ 	console.error(err);
+ }
+ 
+-// Set path according to being built or not
++// If root user, use a root-owned directory for user data
++var configDir = path.join(process.env.HOME, product.dataFolderName);
+ if (process.env.VSCODE_DEV) {
+-	var appData = app.getPath('appData');
+-	app.setPath('userData', path.join(appData, 'Code-Development'));
++	configDir += '-dev';
+ }
++var userDataDir = path.join(configDir, 'user-data');
++
++// Attempt migrations if userDataDir does not exist
++if (!fs.existsSync(userDataDir)) {
++	migrateUserDataDir(userDataDir);","Would this not mean we could potentially migrate the user folder from normal user to root? I would think we should not migrate for root...
+",2016-04-21 08:44:39
+169,"@@ -107,4 +166,18 @@ export class TerminalConfigHelper {
+ 		}
+ 		return config.terminal.integrated.shell.linux;
+ 	}
++
++	private toInteger(source:any, minimum?:number, maximum?:number): number {","Spaces after `:` for consistency
+",2016-06-02 06:59:53
+793,"@@ -107,6 +107,11 @@ configurationRegistry.registerConfiguration({
+ 			'default': 'right',
+ 			'description': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'editorOpenPositioning' }, ""Controls where editors open. Select 'left' or 'right' to open editors to the left or right of the current active one. Select 'first' or 'last' to open editors independently from the currently active one."")
+ 		},
++		'workbench.editor.reuseIfOpen': {","The name and description reads a bit weird, maybe this should be called `revealIfOpen`? Because the editor is not reused if opened, it is being revealed. That also aligns with the `revealIfVisible` option.
+
+Description idea: 
+
+> Controls if an editor is revealed in any of the visible groups if opened. If disabled, an editor will prefer to open in the currently active editor group. If enabled, an already opened editor will be revealed instead of opened again in the currently active editor group. Note that there are some cases where this setting is ignored, e.g. when forcing an editor to open in a specific group or to the side of the currently active group. ",2017-03-03 10:52:26
+480,"@@ -108,27 +110,29 @@ export abstract class TextFileService implements ITextFileService {
+ 		this.toUnbind.push(this.editorGroupService.onEditorsChanged(() => this.onEditorFocusChanged()));
+ 	}
+ 
+-	private beforeShutdown(): boolean | TPromise<boolean> {
++	private beforeShutdown(quitRequested: boolean): boolean | TPromise<boolean> {","@Tyriar can you explain again why the backup service cannot participate in the shutdown and do its work there?
+",2016-11-09 07:57:58
+681,"@@ -108,6 +108,17 @@ declare module 'vscode' {
+ 		getClickCommand?(node: T): string;
+ 	}
+ 
++	export interface TextEditor {
++		/**
++		 * Enters snippet mode in the editor with the specified snippet.
++		 *
++		 * @param snippet The snippet to insert in this edit.
++		 * @param options The undo/redo behaviour around this edit. By default, undo stops will be created before and after this edit.
++		 */
++		edit(snippet: SnippetString, options?: { undoStopBefore: boolean; undoStopAfter: boolean; }): void;
++
++	}",It is enough to have it `vscode.d.ts` only. Duplication not needed,2017-01-18 10:33:55
+288,"@@ -108,7 +108,7 @@ class Extension implements IExtension {
+ 			return this.local.changelogUrl;
+ 		}
+ 
+-		return ''; // Hopefully we will change this once the gallery will support that.
++		return this.gallery && this.gallery.assets.changelog;","This was the wrong place. You should do it in the `hasChangelog` and `getChangelog`. While you're at it, just delete the `readmeUrl` and `changelogUrl`; the former was an old implementation which I forgot to delete.
+",2016-09-22 15:31:50
+233,"@@ -1092,7 +1093,8 @@ export class Cursor extends EventEmitter {
+ 				postOperationRunnable: null,
+ 				shouldPushStackElementBefore: false,
+ 				shouldPushStackElementAfter: false,
+-				requestScrollDeltaLines: 0
++				requestScrollDeltaLines: 0,
++				eventData: ctx.eventData","Why? Please decode the arguments before invoking for each cursor. If there are 1000 cursors it makes no sense to pass the data to each cursor to have it parsed and decoded 1000 times.
+",2016-07-15 11:23:12
+333,"@@ -11,6 +11,10 @@
+ 	display: flex;
+ }
+ 
++.monaco-workbench.mac.use-inline-toolbar > .part > .composite.title {","This is bad, it is causing me to drag the window when I drag the title of the output panel for example.
+",2016-10-15 06:20:38
+263,"@@ -11,6 +11,8 @@ if (env.isLinux) {
+ 		defaultTerminalLinux = 'x-terminal-emulator';
+ 	} else if (process.env.DESKTOP_SESSION === 'gnome' || process.env.DESKTOP_SESSION === 'gnome-classic') {
+ 		defaultTerminalLinux = 'gnome-terminal';
++	} else if (process.env.DESKTOP_SESSION === 'kde-plasma') {","Is plasma a version or something? If so can this be made more generic?
+",2016-09-02 19:45:58
+264,"@@ -11,6 +11,8 @@ if (env.isLinux) {
+ 		defaultTerminalLinux = 'x-terminal-emulator';
+ 	} else if (process.env.DESKTOP_SESSION === 'gnome' || process.env.DESKTOP_SESSION === 'gnome-classic') {
+ 		defaultTerminalLinux = 'gnome-terminal';
++	} else if (process.env.DESKTOP_SESSION === 'kde-plasma') {
++		defaultTerminalLinux = 'konsole';","Is there some environment variable that houses this? `konsole` is the default terminal for this distribution, correct?
+",2016-09-02 19:46:19
+147,"@@ -11,7 +11,7 @@ import ConfigurationRegistry = require('vs/platform/configuration/common/configu
+ 
+ ModesRegistry.registerCompatMode({
+ 	id: 'html',
+-	extensions: ['.html', '.htm', '.shtml', '.mdoc', '.jsp', '.asp', '.aspx', '.jshtm'],","Is it a problem that .xhtml isn't here?
+",2016-05-12 16:06:35
+912,"@@ -11,9 +11,11 @@ import { ICodeEditor } from 'vs/editor/browser/editorBrowser';
+ import { IContextViewService } from 'vs/platform/contextview/browser/contextView';",looks good,2017-05-05 09:46:55
+346,"@@ -1103,20 +1111,7 @@ export class EditorHistoryEntry extends EditorQuickOpenEntry {
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
+-			const sideBySide = !context.quickNavigateConfiguration && context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-			const pinned = !this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>().workbench.editor.enablePreviewFromQuickOpen;
+-
+-			if (this.input instanceof EditorInput) {
+-				this.editorService.openEditor(this.input, { pinned }, sideBySide).done(null, errors.onUnexpectedError);
+-			} else {
+-				this.editorService.openEditor({ resource: (this.input as IResourceInput).resource, options: { pinned: true } }, sideBySide);","can you tell me why `pinned` was forced to `true` for a `IResourceInput` here?
+",2016-10-19 22:19:47
+345,"@@ -1103,20 +1111,7 @@ export class EditorHistoryEntry extends EditorQuickOpenEntry {
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
+-			const sideBySide = !context.quickNavigateConfiguration && context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-			const pinned = !this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>().workbench.editor.enablePreviewFromQuickOpen;
+-
+-			if (this.input instanceof EditorInput) {
+-				this.editorService.openEditor(this.input, { pinned }, sideBySide).done(null, errors.onUnexpectedError);
+-			} else {
+-				this.editorService.openEditor({ resource: (this.input as IResourceInput).resource, options: { pinned: true } }, sideBySide);
+-			}
+-
+-			return true;
+-		}
+-
+-		return false;
++		return super.run(mode, context);","I moved all this out per https://github.com/Microsoft/vscode/pull/13909/commits/06187520ed3a0f3afc41cc04e5b66133b1954773 
+",2016-10-19 22:19:10
+875,"@@ -1109,7 +1110,10 @@ export class Workbench implements IPartService {
+ 			this.setPanelHidden(true, true).done(undefined, errors.onUnexpectedError);
+ 			this.setSideBarHidden(true, true).done(undefined, errors.onUnexpectedError);
+ 
+-			this.setActivityBarHidden(true, true);
++			this.setActivityBarHidden(false, false);","This line is not needed. `this.setActivityBarHidden(false, false);`
+If the setting is not `true` we simply should not do anything
+",2017-04-11 13:45:20
+694,"@@ -111,6 +111,11 @@ export interface IOutputChannel {
+ 	output: string;
+ 
+ 	/**
++	 * Returns the value indicating whether the channel has scroll locked.
++	 */
++	hasScrollLock: boolean;","I would rename this to `scrollLock`, as `outputChannel.hasScrollLock = false` sounds strange to me",2017-01-19 10:00:52
+855,"@@ -1114,6 +1115,26 @@ export class ReopenClosedEditorAction extends Action {
+ 	}
+ }
+ 
++export class ClearRecentItemsAction extends Action {
++
++	public static ID = 'workbench.action.clearRecentItems';
++	public static LABEL = nls.localize('clearRecentItems', ""Clear Recent"");",`Clear Recent Files` maybe?,2017-03-23 14:06:14
+351,"@@ -1115,6 +1115,9 @@ export class EditorHistoryEntry extends EditorQuickOpenEntry {
+ 
+ 			return true;
+ 		}
++		else if (mode === Mode.OPEN_IN_BACKGROUND) {","I think we could always just `return super.run(mode, context)` here because the parent class does not handle `PREVIEW` anyway. 
+",2016-10-20 14:13:33
+89,"@@ -112,17 +117,8 @@ export class Sash extends EventEmitter {
+ 		this.$e.addClass('active');
+ 		this.emit('start', startEvent);
+ 
+-		let overlayDiv = $('div').style({
+-			position: 'absolute',
+-			top: 0,
+-			left: 0,
+-			width: '100%',
+-			height: '100%',
+-			zIndex: 1000000,
+-			cursor: this.orientation === Orientation.VERTICAL ? 'ew-resize' : 'ns-resize'
+-		});
+-
+ 		let $window = $(window);","Can you explain why the changes in sash are needed?
+",2016-03-30 05:24:20
+240,"@@ -112,26 +112,67 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 			return;
+ 		}
+ 
+-		// string magic to get the parents of the variable (a and b for a.b.foo)
+ 		const lineContent = model.getLineContent(pos.lineNumber);
+-		const namesToFind = lineContent.substring(0, lineContent.indexOf('.' + hoveringOver))
+-			.split('.').map(word => word.trim()).filter(word => !!word);
+-		namesToFind.push(hoveringOver);
+-		namesToFind[0] = namesToFind[0].substring(namesToFind[0].lastIndexOf(' ') + 1);
++		const session = this.debugService.getActiveSession();
++		let evaluatedExpression : TPromise<Expression> = undefined;
++		let matchingExpression: string = undefined;
++		let startOffset: number = 0;
++		if (session.configuration.capabilities.supportsEvaluateForHovers) {
++			let expression: RegExp = /([^()\[\]{}<>\s+\-/%~#^;=|,`!]|\->)+/g;","I would suggest adding some comments indicating what this code is doing. Something like:
+
+Line 121:
+// If the debug adapter supports evaluation-based-hover, we need to try and guess what the expression under the mouse cursor is. Someday it might be nice if the language service could somehow provide this. But this code attempts to approximate the answer for a variety of languages. Some example supported expressions: myVar.prop, a.b.c.d, myVar?.prop, myVar->prop, MyClass::StaticProp, *myVar
+
+Reg ex explanation
+// Match any character _except_ a set of characters which often break interesting sub-expressions
+
+Line 124 comment:
+// First find the full expression under the cursor
+
+Line 135 comment:
+// If there are non-word characters after the cursor, we want to truncate the expression then.
+",2016-07-26 23:45:44
+241,"@@ -112,26 +112,67 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 			return;
+ 		}
+ 
+-		// string magic to get the parents of the variable (a and b for a.b.foo)
+ 		const lineContent = model.getLineContent(pos.lineNumber);
+-		const namesToFind = lineContent.substring(0, lineContent.indexOf('.' + hoveringOver))
+-			.split('.').map(word => word.trim()).filter(word => !!word);
+-		namesToFind.push(hoveringOver);
+-		namesToFind[0] = namesToFind[0].substring(namesToFind[0].lastIndexOf(' ') + 1);
++		const session = this.debugService.getActiveSession();
++		let evaluatedExpression : TPromise<Expression> = undefined;
++		let matchingExpression: string = undefined;
++		let startOffset: number = 0;
++		if (session.configuration.capabilities.supportsEvaluateForHovers) {
++			let expression: RegExp = /([^()\[\]{}<>\s+\-/%~#^;=|,`!]|\->)+/g;
++			let result: RegExpExecArray = undefined;
++
++			while (result = expression.exec(lineContent)) {
++				let start = result.index + 1;
++				let end = start + result[0].length;
++
++				if (start <= range.startColumn && end >= range.endColumn) {
++					matchingExpression = result[0];
++					startOffset = start;
++					break;
++				}
++			}
+ 
+-		return this.getExpression(namesToFind).then(expression => {
++			if (matchingExpression) {
++				let subExpression: RegExp = /\w+/g;
++				let subExpressionResult: RegExpExecArray = undefined;
++				while (subExpressionResult = subExpression.exec(matchingExpression)) {
++					let subStart = subExpressionResult.index + 1 + startOffset;
++					let subEnd = subStart + subExpressionResult[0].length;
++					if (subStart <= range.startColumn && subEnd >= range.endColumn) {","Does the `subStart <= range.startColumn` part of the expression make sense since we are only going to trim the end?
+",2016-07-26 23:52:39
+242,"@@ -112,27 +112,75 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 			return;
+ 		}
+ 
+-		// string magic to get the parents of the variable (a and b for a.b.foo)
++		const session = this.debugService.getActiveSession();
++		const canEvaluateForHovers: boolean = session.configuration.capabilities.supportsEvaluateForHovers;
++
+ 		const lineContent = model.getLineContent(pos.lineNumber);
+-		const namesToFind = lineContent.substring(0, lineContent.indexOf('.' + hoveringOver))
+-			.split('.').map(word => word.trim()).filter(word => !!word);
+-		namesToFind.push(hoveringOver);
+-		namesToFind[0] = namesToFind[0].substring(namesToFind[0].lastIndexOf(' ') + 1);
++		let evaluatedExpression : TPromise<Expression> = undefined;
++		let matchingExpression: string = undefined;
++		let startOffset: number = 0;
++		if (canEvaluateForHovers) {
++			// If the debug adapter supports evaluation-based-hover, we need to try and guess what the expression under the mouse cursor is.
++			// Someday it might be nice if the language service could somehow provide this.
++			// But this code attempts to approximate the answer for a variety of languages.
++			// Some example supported expressions: myVar.prop, a.b.c.d, myVar?.prop, myVar->prop, MyClass::StaticProp, *myVar
++
++			// Match any character except a set of characters which often break interesting sub-expressions
++			let expression: RegExp = /([^()\[\]{}<>\s+\-/%~#^;=|,`!]|\->)+/g;","does it make sense to use a tokenizer? There should be language specific techniques
+",2016-07-27 15:19:05
+259,"@@ -112,27 +155,41 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 			return;
+ 		}
+ 
+-		// string magic to get the parents of the variable (a and b for a.b.foo)
++		const session = this.debugService.getActiveSession();
++		const canEvaluateForHovers: boolean = session.configuration.capabilities.supportsEvaluateForHovers;","Remove type
+",2016-08-24 14:11:20
+260,"@@ -112,27 +155,41 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 			return;
+ 		}
+ 
+-		// string magic to get the parents of the variable (a and b for a.b.foo)
++		const session = this.debugService.getActiveSession();
++		const canEvaluateForHovers: boolean = session.configuration.capabilities.supportsEvaluateForHovers;
++
+ 		const lineContent = model.getLineContent(pos.lineNumber);
+-		const namesToFind = lineContent.substring(0, lineContent.indexOf('.' + hoveringOver))
+-			.split('.').map(word => word.trim()).filter(word => !!word);
+-		namesToFind.push(hoveringOver);
+-		namesToFind[0] = namesToFind[0].substring(namesToFind[0].lastIndexOf(' ') + 1);
++		let evaluatedExpression = undefined;
++		let matchingExpression = undefined;
++		let startOffset = 0;
++
++		if (canEvaluateForHovers) {
++			let expressionRange = this.getHoveredExpression(lineContent, range);
++			startOffset = expressionRange.startColumn;
++			let matchingExpression = lineContent.substring(expressionRange.startColumn - 1, expressionRange.endColumn);
++			evaluatedExpression = this.getExpressionSupportingEvaluate(session, matchingExpression);
++		}
++		else {","move to previous line, this is not our else formating style
+",2016-08-24 14:11:38
+262,"@@ -112,27 +155,41 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 			return;
+ 		}
+ 
+-		// string magic to get the parents of the variable (a and b for a.b.foo)
++		const session = this.debugService.getActiveSession();
++		const canEvaluateForHovers: boolean = session.configuration.capabilities.supportsEvaluateForHovers;
++
+ 		const lineContent = model.getLineContent(pos.lineNumber);
+-		const namesToFind = lineContent.substring(0, lineContent.indexOf('.' + hoveringOver))
+-			.split('.').map(word => word.trim()).filter(word => !!word);
+-		namesToFind.push(hoveringOver);
+-		namesToFind[0] = namesToFind[0].substring(namesToFind[0].lastIndexOf(' ') + 1);
++		let evaluatedExpression = undefined;
++		let matchingExpression = undefined;
++		let startOffset = 0;
++
++		if (canEvaluateForHovers) {
++			let expressionRange = this.getHoveredExpression(lineContent, range);
++			startOffset = expressionRange.startColumn;
++			let matchingExpression = lineContent.substring(expressionRange.startColumn - 1, expressionRange.endColumn);
++			evaluatedExpression = this.getExpressionSupportingEvaluate(session, matchingExpression);
++		}
++		else {
++			// string magic to get the parents of the variable (a and b for a.b.foo)
++			const namesToFind = lineContent.substring(0, lineContent.indexOf('.' + hoveringOver))
++				.split('.').map(word => word.trim()).filter(word => !!word);
++			namesToFind.push(hoveringOver);
++			namesToFind[0] = namesToFind[0].substring(namesToFind[0].lastIndexOf(' ') + 1);
++			evaluatedExpression = this.getExpression(namesToFind);
++		}
+ 
+-		return this.getExpression(namesToFind).then(expression => {
++		return evaluatedExpression.then(expression => {
+ 			if (!expression || !expression.available) {
+ 				this.hide();
+ 				return;
+ 			}
+ 
+-			// show it","No need for the type here
+",2016-08-24 14:12:33
+43,"@@ -112,6 +117,7 @@ export class Workbench implements IPartService {
+ 	private creationPromiseComplete: ValueCallback;
+ 	private sideBarHidden: boolean;
+ 	private sideBarPosition: Position;
++	private panelPartHidden: boolean;","@isidorn => panelHidden
+",2016-01-15 15:17:43
+613,"@@ -1123,15 +1123,16 @@ declare module 'vscode' {
+ 		/**
+ 		 * Derive a new Uri from this Uri.
+ 		 *
++		 * ```ts",I moved this out of a @sample tag as it looked really bad on the website https://code.visualstudio.com/docs/extensionAPI/vscode-api#Uri.with,2016-12-15 23:50:10
+223,"@@ -1126,6 +1128,10 @@ export class Cursor extends EventEmitter {
+ 		return this._invokeForAll(ctx, (cursorIndex: number, oneCursor: OneCursor, oneCtx: IOneCursorOperationContext) => OneCursorOp.moveTo(oneCursor, inSelectionMode, ctx.eventData.position, ctx.eventData.viewPosition, ctx.eventSource, oneCtx));
+ 	}
+ 
++	private _move(inSelectionMode:boolean, ctx: IMultipleCursorOperationContext): boolean {","`inSelectionMode` should be added as a boolean argument accepted by the command. Not sure what name would be best.
+",2016-07-15 11:11:17
+234,"@@ -1126,6 +1128,10 @@ export class Cursor extends EventEmitter {
+ 		return this._invokeForAll(ctx, (cursorIndex: number, oneCursor: OneCursor, oneCtx: IOneCursorOperationContext) => OneCursorOp.moveTo(oneCursor, inSelectionMode, ctx.eventData.position, ctx.eventData.viewPosition, ctx.eventSource, oneCtx));
+ 	}
+ 
++	private _move(inSelectionMode:boolean, ctx: IMultipleCursorOperationContext): boolean {
++		return this._invokeForAll(ctx, (cursorIndex: number, oneCursor: OneCursor, oneCtx: IOneCursorOperationContext) => OneCursorOp.move(oneCursor, inSelectionMode, ctx.eventData.to, ctx.eventSource, oneCtx));","Why? Please decode the arguments before invoking for each cursor. If there are 1000 cursors it makes no sense to pass the data to each cursor to have it parsed and decoded 1000 times.
+",2016-07-15 11:23:18
+97,"@@ -1127,4 +1134,12 @@ registry.add('eslint-stylish', {
+ 	applyTo: ApplyToKind.allDocuments,
+ 	fileLocation: FileLocationKind.Absolute,
+ 	pattern: defaultPattern('eslint-stylish')
+-});
+\ No newline at end of file
++});
++
++registry.add('go', {
++	owner: 'typescript',
++	applyTo: ApplyToKind.allDocuments,
++	fileLocation: FileLocationKind.Relative,
++	filePrefix: '${cwd}',","I chose `cwd` here over `workspaceRoot` so that the task can override the working directory if desired (with the default being the workspace root). Make sense?
+",2016-04-09 04:41:49
+117,"@@ -113,8 +113,20 @@
+ 			process.env['VSCODE_SHARED_IPC_HOOK'] = configuration.sharedIPCHandle;
+ 
+ 			// Get the nls configuration into the process.env as early as possible.
++			var nlsConfig = { availableLanguages: {} };
+ 			if (configuration.userEnv && configuration.userEnv['VSCODE_NLS_CONFIG']) {
+-				process.env['VSCODE_NLS_CONFIG'] = configuration.userEnv['VSCODE_NLS_CONFIG'];
++				var config = configuration.userEnv['VSCODE_NLS_CONFIG'];
++				process.env['VSCODE_NLS_CONFIG'] = config;
++				try {
++					if (config) {
++						nlsConfig = JSON.parse(config);
++					}
++				} catch (e) {
++				}
++			}
++			var uiLanguage = nlsConfig.availableLanguages['*'];
++			if (uiLanguage) {
++				window.document.getElementsByTagName('html')[0].setAttribute('lang', uiLanguage)","I am not sure if our language codes map directly to the expected language codes for the HTML attribute. The list of expected codes seem to be listed here: http://www.w3schools.com/tags/ref_language_codes.asp
+",2016-04-18 20:46:29
+510,"@@ -1136,15 +1160,15 @@ class DiffEditorWidgetStyle {
+ 		};
+ 	}
+ 
+-	_getViewZones(lineChanges: editorCommon.ILineChange[], originalForeignVZ: editorCommon.IEditorWhitespace[], modifiedForeignVZ: editorCommon.IEditorWhitespace[], originalEditor: editorBrowser.ICodeEditor, modifiedEditor: editorBrowser.ICodeEditor): IEditorsZones {
++	_getViewZones(lineChanges: editorCommon.ILineChange[], originalForeignVZ: editorCommon.IEditorWhitespace[], modifiedForeignVZ: editorCommon.IEditorWhitespace[], originalEditor: editorBrowser.ICodeEditor, modifiedEditor: editorBrowser.ICodeEditor, renderIndicators?: boolean): IEditorsZones {",@rebornix why is renderIndicators optional here?,2016-11-23 19:01:07
+566,"@@ -114,6 +114,9 @@ export class EnvironmentService implements IEnvironmentService {
+ 	@memoize
+ 	get sharedIPCHandle(): string { return `${getIPCHandlePrefix()}-${pkg.version}-shared${getIPCHandleSuffix()}`; }
+ 
++	@memoize
++	get nodeCachedDataDir(): string { return path.join(this.userDataPath, 'CachedData', pkg.version); }","@jrieken should we not use the commit ID of the built as a way to identify the backup? if we use the version, wouldn't we use old cached data each time we update insiders build?",2016-12-05 08:51:33
+540,"@@ -114,7 +118,7 @@ suite('TextSearch performance', () => {
+ 		const finishedEvents = [];
+ 		return runSearch() // Warm-up first
+ 			.then(() => {
+-				if (testWorkspaceArg) { // Don't measure by default
++				if (testWorkspacePath) { // Don't measure by default",This is always set. I'd revert this change so unit tests run without additional output.,2016-11-30 19:05:52
+861,"@@ -1142,6 +1142,24 @@ export class Workbench implements IPartService {
+ 		}
+ 	}
+ 
++	// Resize requested part along the main axis
++	// layout will do all the math for us and adjusts the other Parts
++	public resizePart(part: Parts, sizeChange: number): void {
++
++		switch (part) {
++			case Parts.SIDEBAR_PART:
++			case Parts.PANEL_PART:
++			case Parts.EDITOR_PART:
++				this.workbenchLayout.setPartSizeChange(part, sizeChange);",`setPartSizeChange` => `resizePart` ?,2017-03-24 20:26:50
+851,"@@ -1142,6 +1142,24 @@ export class Workbench implements IPartService {
+ 		}
+ 	}
+ 
++	// Resize requested part along the main axis
++	// layout will do all the math for us and adjusts the other Parts
++	public resizePart(part: Parts, sizeChangePx: number, skipLayout?: boolean): TPromise<void> {",This method does not need to return a promise and also does not seem to be using `skipLayout`. I would suggest to do the `layout()` call from within `layout.ts` and not outside.,2017-03-22 13:29:36
+628,"@@ -1144,13 +1144,20 @@ export class WindowsManager implements IWindowsMainService {
+ 		// Update in settings
+ 		const menuBarHidden = this.storageService.getItem(VSCodeWindow.menuBarHiddenKey, false);
+ 		const newMenuBarHidden = !menuBarHidden;
++
++		const windowConfig = this.configurationService.getConfiguration<IWindowSettings>('window');","It is true that on the main side we do not have access to the default values because they get defined on the browser side. Maybe we should turn this setting around and make it so that the default of a false value is OK for us. That avoids having to fill in a default on our end (instead of having `true` as default, change the setting so that `false` as default is good).",2016-12-20 06:21:36
+893,"@@ -115,6 +116,12 @@ export class EditorAccessor implements emmet.Editor {
+ 		}
+ 
+ 		let range = new Range(startPosition.lineNumber, startPosition.column, endPosition.lineNumber, endPosition.column);
++		let textToReplace = this._editor.getModel().getValueInRange(range);
++		if (this._emmetActionName === 'expand_abbreviation' && (value === textToReplace || value === textToReplace + '${0}')) {","Maybe divide into two variables?
+
+```ts
+const isExpandAbbreviation = this._emmetActionName === 'expand_abbreviation';
+const isWrongExpansion = value === textToReplace || value === textToReplace + '${0}';
+```
+
+",2017-04-18 07:11:35
+920,"@@ -1155,6 +1161,7 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 		unbind.push(group.onEditorStateChanged(editor => this._onModelChanged.fire({ group, editor })));
+ 		unbind.push(group.onEditorOpened(editor => this._onEditorOpened.fire({ editor, group })));
+ 		unbind.push(group.onEditorClosed(event => {
++			this._onWillCloseEditor.fire({ editor: event.editor, group });
+ 			this.handleOnEditorClosed(event);",I checked and you are emiting and handling the `onWillCloseEditor` similar to `onEditorClosed` -> looks good.,2017-05-10 08:20:43
+216,"@@ -116,11 +116,7 @@ export class LinesDecorationsOverlay extends DedupOverlay {
+ 			if (classNames.length === 0) {
+ 				output[lineIndex] = '';
+ 			} else {
+-				output[lineIndex] = (
+-					'<div class=""cldr'
+-					+ classNames
+-					+ common
+-				);
++				output[lineIndex] = classNames.map(className => '<div class=""cldr ' + className + common).join('');","please spell out for loops
+",2016-07-14 09:38:53
+376,"@@ -117,29 +114,8 @@ export abstract class TextFileService implements ITextFileService {
+ 	}
+ 
+ 	private beforeShutdown(): boolean | TPromise<boolean> {
+-		// If hot exit is enabled then save the dirty files in the workspace and then exit
+-		// Hot exit is currently disabled for both empty workspaces (#13733) and on Mac (#13305)
+-		if (this.configuredHotExit && this.contextService.getWorkspace() && !platform.isMacintosh) {
+-			// If there are no dirty files, clean up and exit
+-			if (this.getDirty().length === 0) {
+-				return this.cleanupBackupsBeforeShutdown();
+-			}
+-
+-			return this.backupService.getWorkspaceBackupPaths().then(workspaceBackupPaths => {
+-				// Only remove the workspace from the backup service if it's not the last one or it's not dirty
+-				if (workspaceBackupPaths.length > 1) {
+-					return this.confirmBeforeShutdown();
+-				}
+-
+-				// Backup and hot exit
+-				return this.backupAll().then(result => {
+-					if (result.results.some(r => !r.success)) {
+-						return true; // veto if some backups failed
+-					}
+-
+-					return false; // the backup went smoothly, no veto
+-				});
+-			});
++		if (this.backupService.isHotExitEnabled) {","Let the backup service listen to the lifecycle method and do it in there. Here I would only check if hot exit is enabled to see if confirmation is needed.
+",2016-10-21 14:04:44
+644,"@@ -118,25 +118,26 @@ export class OpenFileHandler extends QuickOpenHandler {
+ 		return promise.then(result => [new QuickOpenModel(result[0]), result[1]]);
+ 	}
+ 
+-	private doFindResults(searchValue: string): TPromise<[QuickOpenEntry[], ISearchStats]> {
++	private doFindResults(searchValue: string): PPromise<[QuickOpenEntry[], ISearchStats], QuickOpenEntry> {
+ 		const query: IQueryOptions = {
+ 			folderResources: this.contextService.getWorkspace() ? [this.contextService.getWorkspace().resource] : [],
+ 			extraFileResources: getOutOfWorkspaceEditorResources(this.editorGroupService, this.contextService),
+ 			filePattern: searchValue
+ 		};
+ 
++		let results: QuickOpenEntry[] = [];
+ 		return this.searchService.search(this.queryBuilder.file(query)).then((complete) => {
+-			let results: QuickOpenEntry[] = [];","According to coding standards, `.then(complete => [results, complete.stats], null, progress => { ...});` would be better",2016-12-23 06:59:39
+677,"@@ -118,6 +118,12 @@ configurationRegistry.registerConfiguration({
+ 			'description': nls.localize('showEditorTabCloseButton', ""Controls if editor tabs should have a visible close button or not.""),
+ 			'default': true
+ 		},
++		'workbench.editor.tabCloseButton': {
++			'type': 'string',
++			'enum': ['left', 'right', 'off'],
++			'default': 'right',
++			'description': nls.localize('editorTabCloseButton', ""Controls the position of the editor's tabs close buttons."")","This should mention what ""off"" does.",2017-01-16 08:00:10
+943,"@@ -118,6 +118,12 @@ export const STATUS_BAR_FOREGROUND = registerColor('statusBar.foreground', {
+ 	hc: '#FFFFFF'
+ }, nls.localize('statusBarForeground', ""Status bar foreground color. The status bar is shown in the bottom of the window.""));
+ 
++export const STATUS_BAR_NO_FOLDER_FOREGROUND = registerColor('statusBar.noFolderForeground', {
++	dark: '#FFFFFF',",I suggest to use `STATUS_BAR_FOREGROUND` here as default color for all themes instead of specifying the color again as `FFFFFF`. This makes sure that all existing themes are not broken that specify `STATUS_BAR_FOREGROUND` any different from `FFFFFF`.,2017-05-22 04:47:10
+96,"@@ -119,6 +119,7 @@
+ .monaco-editor .view-lines {
+ 	cursor: text;
+ 	white-space: nowrap;
++	z-index: 1;","This makes text rendered over cursor.
+",2016-04-05 02:01:21
+358,"@@ -119,7 +119,6 @@ export abstract class BaseHistoryService {
+ 		const activeEditor = this.editorService.getActiveEditor();
+ 		const activeInput = activeEditor ? activeEditor.input : void 0;
+ 
+-		// Propagate to history","@wprater you removed the comment here?
+",2016-10-21 09:52:13
+275,"@@ -12,16 +12,17 @@ export class ExtHostTerminal implements vscode.Terminal {
+ 
+ 	public _name: string;
+ 	public _shellPath: string;","`_shellPath` and `_shellArgs` can safely be removed as they're not exposed like name
+",2016-09-13 21:17:23
+276,"@@ -12,16 +12,17 @@ export class ExtHostTerminal implements vscode.Terminal {
+ 
+ 	public _name: string;
+ 	public _shellPath: string;
++	public _shellArgs: string[];
+ 
+ 	private _id: number;
+ 	private _proxy: MainThreadTerminalServiceShape;
+ 	private _disposed: boolean;
+ 
+-	constructor(proxy: MainThreadTerminalServiceShape, id: number, name?: string, shellPath?: string) {
++	constructor(proxy: MainThreadTerminalServiceShape, id: number, name?: string, shellPath?: string, shellArgs?: string[]) {
+ 		this._name = name;
+ 		this._shellPath = shellPath;"," You can remove this line
+",2016-09-13 21:17:35
+641,"@@ -12,16 +12,4 @@ MimeType=text/plain;inode/directory;
+ Actions=new-window;
+ Keywords=vscode;
+ 
+-[Desktop Action new-window]
+-Name=New Window
+-Name[de]=Neues Fenster
+-Name[es]=Nueva ventana
+-Name[fr]=Nouvelle fenêtre
+-Name[it]=Nuova finestra
+-Name[ja]=新規ウインドウ
+-Name[ko]=새 창
+-Name[ru]=Новое окно
+-Name[zh_CN]=新建窗口
+-Name[zh_TW]=開新視窗
+-Exec=/usr/share/@@NAME@@/@@NAME@@ --new-window %U
+ Icon=@@NAME@@",You can remove this one too then good to go :smile: ,2016-12-21 23:05:33
+751,"@@ -12,16 +13,28 @@
+ 	white-space: nowrap;
+ }
+ 
++.monaco-editor .zone-widget .zone-widget-container.marker-error-widget {
++	border-top-color: #ff5a5a;
++	border-bottom-color: #ff5a5a;
++}
++
++.monaco-editor .zone-widget .zone-widget-container.marker-warning-widget {
++	border-top-color: #5aac5a;
++	border-bottom-color: #5aac5a;
++}
++
+ .monaco-editor.vs-dark .marker-widget {
+ 	background-color: #2D2D30;
+ }
+ 
++
+ /* High Contrast Theming */
++
+ .monaco-editor.hc-black .marker-widget {
+ 	background-color: #0C141F;
+ }
+ 
+-.monaco-editor .marker-widget > .stale {",Do not change unnecessary lines,2017-02-20 14:00:02
+649,"@@ -12,7 +12,8 @@ import Event from 'vs/base/common/event';
+ 
+ export enum GroupArrangement {
+ 	MINIMIZE_OTHERS,
+-	EVEN
++	EVEN,
++	KEEP_RATIO",Suggest to not expose.,2017-01-04 10:26:43
+984,"@@ -120,10 +127,14 @@ export class FileService implements IFileService {
+ 		}
+ 
+ 		if (this.basePath && !this.options.disableWatcher) {
+-			if (isWindows) {
+-				this.setupWin32WorkspaceWatching();
++			if (this.options.useNsfwFileWatcher) {",@bpasero merging this now as the tests are passing and the new code should all be blocked off by this setting. Please send comments my way though :smiley: ,2017-06-18 00:57:36
+836,"@@ -120,6 +120,15 @@ export class MockSession implements debug.ISession {
+ 		});",Looks good,2017-03-21 17:01:31
+462,"@@ -121,6 +124,7 @@ export class LifecycleService implements ILifecycleService {
+ 		vscodeWindow.win.on('close', (e) => {
+ 			const windowId = vscodeWindow.id;
+ 			this.logService.log('Lifecycle#window-before-close', windowId);
++			this.logService.log('this.quitRequested: ' + this.quitRequested);","@Tyriar leftover debug statement?
+",2016-11-09 07:07:31
+90,"@@ -1212,6 +1214,14 @@ export class SideBySideEditorControl extends EventEmitter implements IVerticalSa
+ 		this.editorActionsToolbar[position].setActions([], [])();
+ 	}
+ 
++	private centerStash(a: Position, b: Position): void {","Please rename all stash => sash
+",2016-03-30 05:24:41
+711,"@@ -123,19 +119,15 @@ class DefinitionAdapter {
+ }
+ 
+ class ImplementationAdapter {
+-
+-	private _documents: ExtHostDocuments;
+-	private _provider: vscode.ImplementationProvider;
+-
+-	constructor(documents: ExtHostDocuments, provider: vscode.ImplementationProvider) {
+-		this._documents = documents;
+-		this._provider = provider;
+-	}
++	constructor(",same,2017-02-02 07:59:27
+778,"@@ -1234,11 +1234,17 @@ export class Cursor extends EventEmitter {
+ 	}
+ 
+ 	private _moveToBeginningOfLine(inSelectionMode: boolean, ctx: IMultipleCursorOperationContext): boolean {
+-		return this._invokeForAll(ctx, (cursorIndex: number, oneCursor: OneCursor, oneCtx: IOneCursorOperationContext) => OneCursorOp.moveToBeginningOfLine(oneCursor, inSelectionMode, oneCtx));","`_invokeForAll` is for multi cursor, you may want to keep it.",2017-02-27 16:10:32
+767,"@@ -127,6 +128,17 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(EnableAllBreakpointsAc
+ registry.registerWorkbenchAction(new SyncActionDescriptor(DisableAllBreakpointsAction, DisableAllBreakpointsAction.ID, DisableAllBreakpointsAction.LABEL), 'Debug: Disable All Breakpoints', debugCategory);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(ClearReplAction, ClearReplAction.ID, ClearReplAction.LABEL), 'Debug: Clear Debug Console', debugCategory);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(FocusReplAction, FocusReplAction.ID, FocusReplAction.LABEL), 'Debug: Focus Debug Console', debugCategory);
++registry.registerWorkbenchAction(new SyncActionDescriptor(LaunchAction, LaunchAction.ID, LaunchAction.LABEL, null, CONTEXT_NOT_IN_DEBUG_MODE), 'Debug: Launch Configuration', debugCategory);",Remove null and context for now,2017-02-21 10:51:02
+514,"@@ -127,6 +128,7 @@ export class TerminalService implements ITerminalService {
+ 			terminalInstance.setVisible(i === terminalIndex);
+ 		});
+ 		this._onActiveInstanceChanged.fire();
++		this.getActiveInstance().focus(true);","I believe the reason focus is not run in `setActiveInstanceByIndex` is because on launch we do not want the terminal to be focused when the workbench is restored, instead the editor needs to be focused.
+
+Could we isolate this particular case? When a terminal exits AND it is not the last terminal AND the terminal was focused previously. The last case prevents the terminal hijacking focus from the editor if the shell process dies for example.",2016-11-24 21:50:49
+792,"@@ -1272,6 +1272,21 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 			return Position.ONE; // can only be ONE
+ 		}
+ 
++		const config = this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>();
++		const reuseIfOpen = config.workbench.editor.reuseIfOpen;
++		// Respect option to reveal an editor if it is open (not necessarily already visible)
++		const skipReuse = (options && options.index) || arg1;",There are imho more cases where you need to `skipReuse`: when `revealIfVisible` is true and there is a visible editor matching the input you should prefer it,2017-03-03 10:47:00
+791,"@@ -1272,6 +1272,21 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 			return Position.ONE; // can only be ONE
+ 		}
+ 
++		const config = this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>();
++		const reuseIfOpen = config.workbench.editor.reuseIfOpen;
++		// Respect option to reveal an editor if it is open (not necessarily already visible)
++		const skipReuse = (options && options.index) || arg1;
++		if(!skipReuse && reuseIfOpen) {
++			const groups = this.stacks.groups;",I suggest to extract this into a method `findGroup(editor)` in the `EditorStacksModel` and add tests for it. I would add an option to this method to only respect the active editor and then also use it for the `revealIfVisible` option further below 👍 ,2017-03-03 10:44:49
+800,"@@ -1274,14 +1274,20 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 
+ 		// Respect option to reveal an editor if it is already visible
+ 		if (options && options.revealIfVisible) {
+-			const editorsToCheck: BaseEditor[] = [];
+-			if (activeEditor) { editorsToCheck.push(activeEditor); }
+-			visibleEditors.forEach(e => { if (e !== activeEditor) { editorsToCheck.push(e); } });
+-			for (let i = 0; i < editorsToCheck.length; i++) {
+-				const editorToCheck = editorsToCheck[i];
+-				if (input.matches(editorToCheck.input)) {
+-					return editorToCheck.position;
+-				}
++			const group = this.stacks.findGroup(input, true);
++			if (null !== group) {",=> `if (group)`,2017-03-07 06:22:13
+801,"@@ -1274,14 +1274,20 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 
+ 		// Respect option to reveal an editor if it is already visible
+ 		if (options && options.revealIfVisible) {
+-			const editorsToCheck: BaseEditor[] = [];
+-			if (activeEditor) { editorsToCheck.push(activeEditor); }
+-			visibleEditors.forEach(e => { if (e !== activeEditor) { editorsToCheck.push(e); } });
+-			for (let i = 0; i < editorsToCheck.length; i++) {
+-				const editorToCheck = editorsToCheck[i];
+-				if (input.matches(editorToCheck.input)) {
+-					return editorToCheck.position;
+-				}
++			const group = this.stacks.findGroup(input, true);
++			if (null !== group) {
++				return this.stacks.positionOfGroup(group);
++			}
++		}
++
++		const config = this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>();",Instead of getting the config each time we open an editor I suggest to store the value in a field of `EditorPart`. You can see in the [constructor](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editorPart.ts#L145) that we resolve configuration and we also react to [updates](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/parts/editor/editorPart.ts#L173).,2017-03-07 06:23:52
+799,"@@ -1274,14 +1274,20 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 
+ 		// Respect option to reveal an editor if it is already visible
+ 		if (options && options.revealIfVisible) {
+-			const editorsToCheck: BaseEditor[] = [];
+-			if (activeEditor) { editorsToCheck.push(activeEditor); }
+-			visibleEditors.forEach(e => { if (e !== activeEditor) { editorsToCheck.push(e); } });
+-			for (let i = 0; i < editorsToCheck.length; i++) {
+-				const editorToCheck = editorsToCheck[i];
+-				if (input.matches(editorToCheck.input)) {
+-					return editorToCheck.position;
+-				}
++			const group = this.stacks.findGroup(input, true);
++			if (null !== group) {
++				return this.stacks.positionOfGroup(group);
++			}
++		}
++
++		const config = this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>();
++		const revealIfOpen = config.workbench.editor.revealIfOpen;
++		// Respect option to reveal an editor if it is open (not necessarily visible)
++		const skipReuse = (options && options.index) || arg1;
++		if (!skipReuse && revealIfOpen) {
++			const group = this.stacks.findGroup(input, false);
++			if (null !== group) {",=> `if (group)`,2017-03-07 06:21:45
+507,"@@ -128,6 +129,17 @@ export class ViewCursor {
+ 			this._positionTop = visibleRange.top;
+ 			this._positionLeft = visibleRange.left;
+ 			this._isInViewport = true;
++
++			let visibleRangeForCharacter = ctx.linesVisibleRangesForRange({",@rebornix This extra call should be done only if the cursor style is a block cursor,2016-11-23 18:56:38
+828,"@@ -129,33 +128,42 @@ export class TerminalLinkHandler {
+ 		});
+ 	}
+ 
+-	private _resolvePath(link: string): TPromise<string> {
++	protected _preprocessPath(link: string): string {
+ 		if (this._platform === platform.Platform.Windows) {
+ 			// Resolve ~ -> %HOMEDRIVE%\%HOMEPATH%
+ 			if (link.charAt(0) === '~') {
+ 				if (!process.env.HOMEDRIVE || !process.env.HOMEPATH) {
+-					return TPromise.as(void 0);
++					return null;
+ 				}
+ 				link = `${process.env.HOMEDRIVE}\\${process.env.HOMEPATH + link.substring(1)}`;
+ 			}
+-		} else {
+-			// Resolve workspace path . / .. -> <path>/. / <path/..
+-			if (link.charAt(0) === '.') {
++
++			//resolve relative paths
++			if (!link.match('^' + winDrivePrefix)) {
+ 				if (!this._contextService.hasWorkspace) {
+ 					// Abort if no workspace is open
+-					return TPromise.as(void 0);
++					return null;
+ 				}
+ 				link = path.join(this._contextService.getWorkspace().resource.fsPath, link);
+ 			}
+ 		}
+-		// Resolve workspace path . / .. -> <path>/. / <path/..
+-		if (link.charAt(0) === '.') {
++		// Resolve workspace path . | .. | <relative_path> -> <path>/. | <path>/.. | <path>/<relative_path>
++		else if (link.charAt(0) !== '/' && link.charAt(0) !== '~') {
+ 			if (!this._contextService.hasWorkspace) {
+ 				// Abort if no workspace is open
+-				return TPromise.as(void 0);
++				return null;
+ 			}
+ 			link = path.join(this._contextService.getWorkspace().resource.fsPath, link);
+ 		}
++		return link;
++	}
++
++	private _resolvePath(link: string): TPromise<string> {
++		link = this._preprocessPath(link);",Was this factoring out purely for code cleanliness?,2017-03-14 18:42:25
+830,"@@ -129,33 +128,42 @@ export class TerminalLinkHandler {
+ 		});
+ 	}
+ 
+-	private _resolvePath(link: string): TPromise<string> {
++	protected _preprocessPath(link: string): string {
+ 		if (this._platform === platform.Platform.Windows) {
+ 			// Resolve ~ -> %HOMEDRIVE%\%HOMEPATH%
+ 			if (link.charAt(0) === '~') {
+ 				if (!process.env.HOMEDRIVE || !process.env.HOMEPATH) {
+-					return TPromise.as(void 0);
++					return null;
+ 				}
+ 				link = `${process.env.HOMEDRIVE}\\${process.env.HOMEPATH + link.substring(1)}`;
+ 			}
+-		} else {
+-			// Resolve workspace path . / .. -> <path>/. / <path/..
+-			if (link.charAt(0) === '.') {
+-				if (!this._contextService.hasWorkspace) {",Good catch :+1: ,2017-03-17 02:31:07
+877,"@@ -129,7 +129,10 @@ export abstract class MainThreadDocumentsShape {
+ }
+ 
+ export abstract class MainThreadEditorsShape {
+-	$tryShowTextDocument(resource: URI, position: EditorPosition, preserveFocus: boolean): TPromise<string> { throw ni(); }
++	$tryShowTextDocument(resource: URI, position: EditorPosition, preserveFocus: boolean): TPromise<string>;
++	$tryShowTextDocument(resource: URI, position: EditorPosition, options: { preserveFocus: boolean, pinned: boolean }): TPromise<string>;
++	$tryShowTextDocument(resource: URI, position: EditorPosition, preserveFocusOrOptions: boolean | { preserveFocus: boolean, pinned: boolean }): TPromise<string>;
++	$tryShowTextDocument(resource: URI, position: EditorPosition, preserveFocusOrOptions: boolean | { preserveFocus: boolean, pinned: boolean }): TPromise<string> { throw ni(); }",In the protocol/shape there should only be one signature and the calling side should do the argument construction,2017-04-13 15:14:32
+331,"@@ -13,10 +13,22 @@
+ 	padding-left: 20px;
+ }
+ 
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content .title {
++	-webkit-app-region: drag;
++}
++
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content > .one-editor-silo > .container > .title .title-label {","Why are we adding 1px (from 35px) here?
+",2016-10-15 06:19:59
+332,"@@ -13,10 +13,22 @@
+ 	padding-left: 20px;
+ }
+ 
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content .title {
++	-webkit-app-region: drag;
++}
++
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content > .one-editor-silo > .container > .title .title-label {
++	line-height: 36px;
++}
++
+ .monaco-workbench > .part.editor > .content > .one-editor-silo > .container > .title .monaco-icon-label::before {
+ 	height: 35px; /* tweak the icon size of the editor labels when icons are enabled */
+ }
+ 
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content > .one-editor-silo > .container > .title .monaco-icon-label::before {","Why are we adding 1px (from 35px) here?
+",2016-10-15 06:20:06
+389,"@@ -13,10 +13,25 @@
+ 	padding-left: 20px;
+ }
+ 
++/* Allow the unused gutter to be dragabble */
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content .title {
++	-webkit-app-region: drag;
++}
++
++/* Align the title text with the traffic lights */
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content > .one-editor-silo > .container > .title .title-label {
++	line-height: 36px;
++}
++","Still needed?
+",2016-10-24 14:24:02
+388,"@@ -13,10 +13,25 @@
+ 	padding-left: 20px;
+ }
+ 
++/* Allow the unused gutter to be dragabble */
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content .title {
++	-webkit-app-region: drag;
++}
++
++/* Align the title text with the traffic lights */
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content > .one-editor-silo > .container > .title .title-label {
++	line-height: 36px;
++}
++
+ .monaco-workbench > .part.editor > .content > .one-editor-silo > .container > .title .monaco-icon-label::before {
+ 	height: 35px; /* tweak the icon size of the editor labels when icons are enabled */
+ }
+ 
++/* Align the icon with the traffic lights */
++.monaco-workbench.mac.use-inline-toolbar > .part.editor > .content > .one-editor-silo > .container > .title .monaco-icon-label::before {
++	height: 36px;
++}
++","Still needed?
+",2016-10-24 14:23:57
+2,"@@ -13,15 +13,15 @@ The [`vscode`](https://github.com/microsoft/vscode) repository is where we do de
+ ## Contributing
+ If you are interested in fixing issues and contributing directly to the code base, please see the document [How to Contribute](https://github.com/Microsoft/vscode/wiki/How-to-Contribute), which covers the following:
+ 
+-* How to build and run from source
+-* The development workflow, including debugging and running tests
+-* [Coding guidelines](https://github.com/Microsoft/vscode/wiki/Coding-Guidelines)
+-* Submitting pull requests
++* [How to build and run from source](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run-from-source)
++* [The development workflow, including debugging and running tests](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#development-workflow)
++* [Coding Guidelines](https://github.com/Microsoft/vscode/wiki/Coding-Guidelines)","""Guidelines"" is capitalized differently to the rest of the list, lower case fits better.
+",2015-11-19 22:05:53
+79,"@@ -13,6 +13,7 @@ import severity from 'vs/base/common/severity';
+ import types = require('vs/base/common/types');","Looks good overall - some comments below.
+",2016-03-16 10:45:25
+482,"@@ -130,7 +154,7 @@ export class UntitledEditorService implements IUntitledEditorService {
+ 			.map((i) => i.getResource());
+ 	}
+ 
+-	public createOrGet(resource?: URI, modeId?: string): UntitledEditorInput {
++	public createOrGet(resource?: URI, modeId?: string, restoreResource?: URI): UntitledEditorInput {","@Tyriar can you explain again why we cannot do something similar as with files (`this.backupFileService.doesTextFileHaveBackup`)
+",2016-11-09 08:00:54
+95,"@@ -132,6 +132,8 @@ export interface IInstantiationService {
+ 	createInstance<A1, A2, A3, A4, A5, A6, A7, T>(descriptor: descriptors.SyncDescriptor7<A1, A2, A3, A4, A5, A6, A7, T>, a1: A1, a2: A2, a3: A3, a4: A4, a5: A5, a6: A6, a7: A7): T;
+ 	createInstance<A1, A2, A3, A4, A5, A6, A7, A8, T>(descriptor: descriptors.SyncDescriptor8<A1, A2, A3, A4, A5, A6, A7, A8, T>, a1: A1, a2: A2, a3: A3, a4: A4, a5: A5, a6: A6, a7: A7, a8: A8): T;
+ 
++	createInstance<T>(descriptor: descriptors.SyncDescriptor0<T>, ...args: any[]): T;",":-1: I think the evil lies in the fact that the actual logic is hidden in actions and not in a command-function. I would not restructure towards more actions but towards one command that does more or less this
+
+```
+// Handle in browser process
+        if (this.ipcArg) {
+            ipc.send(this.ipcMsg, this.ipcArg);
+        } else {
+            ipc.send(this.ipcMsg);
+        }
+```
+
+and make the action use that command as well as the API using it. The relations should be `command_id -> function` and `action -> command_id` and `api_command -> command_id`. We have done with language features similar things (see suggest for instance)
+
+Maybe we should talk about this ;-)
+",2016-04-04 14:47:03
+565,"@@ -132,9 +134,26 @@ export class BackupMainService implements IBackupMainService {
+ 
+ 		backups.folderWorkspaces.forEach(workspacePath => {
+ 			const backupPath = path.join(this.backupHome, this.getWorkspaceHash(workspacePath));
+-			if (!this.hasBackupsSync(backupPath)) {
++			const hasBackups = this.hasBackupsSync(backupPath);
++			const missingWorkspace = hasBackups && !fs.existsSync(workspacePath);
++
++			// If the folder has no backups, make sure to delete it
++			// If the folder has backups, but the target workspace is missing, convert backups to empty ones
++			if (!hasBackups || missingWorkspace) {
+ 				const backupWorkspace = this.sanitizePath(workspacePath);
+ 				staleBackupWorkspaces.push({ workspaceIdentifier: Uri.file(backupWorkspace).fsPath, backupPath, isEmptyWorkspace: false });
++
++				if (missingWorkspace) {",Can we add test coverage for this?,2016-12-03 18:43:51
+564,"@@ -132,9 +134,26 @@ export class BackupMainService implements IBackupMainService {
+ 
+ 		backups.folderWorkspaces.forEach(workspacePath => {
+ 			const backupPath = path.join(this.backupHome, this.getWorkspaceHash(workspacePath));
+-			if (!this.hasBackupsSync(backupPath)) {
++			const hasBackups = this.hasBackupsSync(backupPath);
++			const missingWorkspace = hasBackups && !fs.existsSync(workspacePath);
++
++			// If the folder has no backups, make sure to delete it
++			// If the folder has backups, but the target workspace is missing, convert backups to empty ones
++			if (!hasBackups || missingWorkspace) {
+ 				const backupWorkspace = this.sanitizePath(workspacePath);
+ 				staleBackupWorkspaces.push({ workspaceIdentifier: Uri.file(backupWorkspace).fsPath, backupPath, isEmptyWorkspace: false });
++
++				if (missingWorkspace) {
++					const identifier = this.pushBackupPathsSync((Date.now() + Math.round(Math.random() * 1000)).toString(), true /* is empty workspace */);",Should we add this random part to the regular folder generation in `registerWindowForBackups` if you're concerned about conflicts?,2016-12-03 18:39:34
+334,"@@ -134,12 +134,14 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				this.partService.layout();","This should only be called if the setting for inline title is enabled, no?
+",2016-10-15 06:21:14
+335,"@@ -134,12 +134,14 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				this.partService.layout();
+ 			});
+ 		});
+ 
+ 		ipc.on('vscode:leaveFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.removeClass('fullscreen');
++				this.partService.layout();","This should only be called if the setting for inline title is enabled, no?
+",2016-10-15 06:21:18
+296,"@@ -134,12 +134,24 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				// We need to re-layout the sidebar as the activitybar's width can change between
++				// fullscreen and window'd modes on macOS.
++				this.partService.setSideBarHidden(this.partService.isSideBarHidden());","this is ugly, we should rather call `this.partService.layout()` and make it work there if it does not
+",2016-10-05 06:45:35
+297,"@@ -134,12 +134,24 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				// We need to re-layout the sidebar as the activitybar's width can change between
++				// fullscreen and window'd modes on macOS.
++				this.partService.setSideBarHidden(this.partService.isSideBarHidden());
++
+ 			});
+ 		});
+ 
+ 		ipc.on('vscode:leaveFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.removeClass('fullscreen');
++				this.partService.setSideBarHidden(this.partService.isSideBarHidden());","this is ugly, we should rather call `this.partService.layout()` and make it work there if it does not
+",2016-10-05 06:45:40
+295,"@@ -134,12 +134,24 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				// We need to re-layout the sidebar as the activitybar's width can change between
++				// fullscreen and window'd modes on macOS.
++				this.partService.setSideBarHidden(this.partService.isSideBarHidden());
++
+ 			});
+ 		});
+ 
+ 		ipc.on('vscode:leaveFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.removeClass('fullscreen');
++				this.partService.setSideBarHidden(this.partService.isSideBarHidden());
++			});
++		});
++
++		ipc.on('vscode:macOSUseInlineToolbar', (event) => {","this looks like dead code to me
+",2016-10-05 06:44:38
+69,"@@ -134,18 +134,18 @@ export class DebugEditorModelManager implements IWorkbenchContribution {
+ 		const result: editorcommon.IModelDeltaDecoration[] = [];","I like that there are not a lot of changes in this file now. Due to this we will not have to intensively test the UI changes in the editor (e.g. breakpoints).
+",2016-03-16 10:20:32
+957,"@@ -134,7 +134,7 @@ export function shorten(paths: string[]): string[] {
+ 		let path = paths[pathIndex];
+ 
+ 		if (path === '') {
+-			shortenedPaths[pathIndex] = '.';
++			shortenedPaths[pathIndex] = '.' + nativeSep;","@hun1ahpu 💄 
+
+`.${nativeSep}`",2017-06-03 11:46:37
+806,"@@ -134,7 +134,9 @@ export function shorten(paths: string[]): string[] {
+ 					// suffix subpath treated specially as we consider no match 'x' and 'x/...'
+ 					if (otherPathIndex !== pathIndex && paths[otherPathIndex] && paths[otherPathIndex].indexOf(subpath) > -1) {
+ 						const isSubpathEnding: boolean = (start + subpathLength === segments.length);
+-						const isOtherPathEnding: boolean = endsWith(paths[otherPathIndex], subpath);
++
++						const subpathWithSep: string = (start > 0 && paths[otherPathIndex].indexOf(nativeSep) > -1) ? nativeSep + subpath : subpath;",A comment here that explains why this is needed would be good,2017-03-09 16:15:11
+942,"@@ -1349,6 +1349,13 @@ export class SearchViewlet extends Viewlet {
+ 		];
+ 	}
+ 
++	public shutdown(): void {
++		this.viewletSettings['query.contentPattern'] = this.searchWidget.searchInput.getValue();
++		this.saveMemento();","I think saveMemento is done by super.shutdown, right?",2017-05-18 21:03:39
+393,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.","Drop ""by extension"" as it's implied being in this file. How about this:
+
+> A node provider for a tree explorer contribution.
+",2016-10-24 14:56:31
+353,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.
++	 *
++	 * Providers are registered through (#workspace.registerTreeExplorerNodeProvider) with a
++	 * `providerId` that corresponds to the `treeExplorerNodeProviderId` in the extension's
++	 * `contributes.explorer` section.
++	 *
++	 * The contributed tree explorer will ask the corresponding provider to provide the root
++	 * node and resolve children for each node. In addition, the provider could **optionally**
++	 * provide the following information for each node:
++	 * - label: A human-readable label used for rendering the node.
++	 * - hasChildren: Whether the node has children and is expandable.
++	 * - clickCommand: A command to execute when the node is clicked.
++	 */
++	export interface TreeExplorerNodeProvider<T> {","Some high level feedback on the API
+- Not a big friend of the lonely `<T>` since that provides little guidance what to actually provide. I'd recommend to look at quick pick for inspiration and have a `TreeItem` being like `interface TreeItem { label: string; command: Command; }`
+- The node provider should have a way to signal to the main side that a node/substree has changes (similar to `TextDocumentContentProvider#onDidChange`) so that UI updates
+- Tree elements should support icons - in one or the other way... maybe even reuse our existing icon story?
+- We should consider adding something like paging to the `resolveChildren`-call. I see this API being used for large sets or sets that are slow to resolve. 
+- The API lacks a way to reveal, select, focus a node in a tree. Unsure if the `TreeItem` should be able to do that or if another API is needed (think of something like`window.activeTreeWidget`)
+",2016-10-20 16:18:40
+394,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.
++	 *
++	 * Providers are registered through (#workspace.registerTreeExplorerNodeProvider) with a
++	 * `providerId` that corresponds to the `treeExplorerNodeProviderId` in the extension's
++	 * `contributes.explorer` section.
++	 *
++	 * The contributed tree explorer will ask the corresponding provider to provide the root
++	 * node and resolve children for each node. In addition, the provider could **optionally**
++	 * provide the following information for each node:
++	 * - label: A human-readable label used for rendering the node.
++	 * - hasChildren: Whether the node has children and is expandable.
++	 * - clickCommand: A command to execute when the node is clicked.
++	 */
++	export interface TreeExplorerNodeProvider<T> {
++
++		/**
++		 * Provide the root node. This function will be called when the tree explorer is activated
++		 * for the first time.
++		 * The root node is hidden and its direct children will be displayed on the first level of","Attach this to the previous line.
+",2016-10-24 14:57:38
+395,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.
++	 *
++	 * Providers are registered through (#workspace.registerTreeExplorerNodeProvider) with a
++	 * `providerId` that corresponds to the `treeExplorerNodeProviderId` in the extension's
++	 * `contributes.explorer` section.
++	 *
++	 * The contributed tree explorer will ask the corresponding provider to provide the root
++	 * node and resolve children for each node. In addition, the provider could **optionally**
++	 * provide the following information for each node:
++	 * - label: A human-readable label used for rendering the node.
++	 * - hasChildren: Whether the node has children and is expandable.
++	 * - clickCommand: A command to execute when the node is clicked.
++	 */
++	export interface TreeExplorerNodeProvider<T> {
++
++		/**
++		 * Provide the root node. This function will be called when the tree explorer is activated
++		 * for the first time.
++		 * The root node is hidden and its direct children will be displayed on the first level of
++		 * the tree explorer.
++		 *
++		 * @return The root node.
++		 */
++		provideRootNode(): T | Thenable<T>;","@jrieken currently this returns the _invisible_ root node, what do you think about that versus a `provideRootNodes(): T[] | Thenable<T[]>` (or `provideTopLevelNodes`) to hide the invisible root node?
+",2016-10-24 14:59:20
+398,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.
++	 *
++	 * Providers are registered through (#workspace.registerTreeExplorerNodeProvider) with a
++	 * `providerId` that corresponds to the `treeExplorerNodeProviderId` in the extension's
++	 * `contributes.explorer` section.
++	 *
++	 * The contributed tree explorer will ask the corresponding provider to provide the root
++	 * node and resolve children for each node. In addition, the provider could **optionally**
++	 * provide the following information for each node:
++	 * - label: A human-readable label used for rendering the node.
++	 * - hasChildren: Whether the node has children and is expandable.
++	 * - clickCommand: A command to execute when the node is clicked.
++	 */
++	export interface TreeExplorerNodeProvider<T> {
++
++		/**
++		 * Provide the root node. This function will be called when the tree explorer is activated
++		 * for the first time.
++		 * The root node is hidden and its direct children will be displayed on the first level of
++		 * the tree explorer.
++		 *
++		 * @return The root node.
++		 */
++		provideRootNode(): T | Thenable<T>;
++
++		/**
++		 * Resolve the children of `node`.
++		 *
++		 * @param node The node from which the provider resolves children.
++		 * @return Children of `node`.
++		 */
++		resolveChildren(node: T): T[] | Thenable<T[]>;
++
++		/**
++		 * Provide a human-readable string that will be used for rendering the node.
++		 *
++		 * Default to use `node.toString()` if not provided.","> Defaults to `node.toString()`.
+
+I'd attach this sentence to the first line.
+",2016-10-24 15:22:05
+397,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.
++	 *
++	 * Providers are registered through (#workspace.registerTreeExplorerNodeProvider) with a
++	 * `providerId` that corresponds to the `treeExplorerNodeProviderId` in the extension's
++	 * `contributes.explorer` section.
++	 *
++	 * The contributed tree explorer will ask the corresponding provider to provide the root
++	 * node and resolve children for each node. In addition, the provider could **optionally**
++	 * provide the following information for each node:
++	 * - label: A human-readable label used for rendering the node.
++	 * - hasChildren: Whether the node has children and is expandable.
++	 * - clickCommand: A command to execute when the node is clicked.
++	 */
++	export interface TreeExplorerNodeProvider<T> {
++
++		/**
++		 * Provide the root node. This function will be called when the tree explorer is activated
++		 * for the first time.
++		 * The root node is hidden and its direct children will be displayed on the first level of
++		 * the tree explorer.
++		 *
++		 * @return The root node.
++		 */
++		provideRootNode(): T | Thenable<T>;
++
++		/**
++		 * Resolve the children of `node`.
++		 *
++		 * @param node The node from which the provider resolves children.
++		 * @return Children of `node`.
++		 */
++		resolveChildren(node: T): T[] | Thenable<T[]>;
++
++		/**
++		 * Provide a human-readable string that will be used for rendering the node.
++		 *
++		 * Default to use `node.toString()` if not provided.
++		 *
++		 * @param node The node from which the provider computes label.
++		 * @return A human-readable label.
++		 */
++		getLabel?(node: T): string;
++
++		/**
++		 * Determine if `node` has children and is expandable.
++		 *
++		 * Default to return `true` if not provided.","> Defaults to `true`.
+
+I'd attach this sentence to the first line.
+",2016-10-24 15:21:56
+396,"@@ -1349,6 +1349,72 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * A node provider for the tree explorer contributed by extension.
++	 *
++	 * Providers are registered through (#workspace.registerTreeExplorerNodeProvider) with a
++	 * `providerId` that corresponds to the `treeExplorerNodeProviderId` in the extension's
++	 * `contributes.explorer` section.
++	 *
++	 * The contributed tree explorer will ask the corresponding provider to provide the root
++	 * node and resolve children for each node. In addition, the provider could **optionally**
++	 * provide the following information for each node:
++	 * - label: A human-readable label used for rendering the node.
++	 * - hasChildren: Whether the node has children and is expandable.
++	 * - clickCommand: A command to execute when the node is clicked.
++	 */
++	export interface TreeExplorerNodeProvider<T> {
++
++		/**
++		 * Provide the root node. This function will be called when the tree explorer is activated
++		 * for the first time.
++		 * The root node is hidden and its direct children will be displayed on the first level of
++		 * the tree explorer.
++		 *
++		 * @return The root node.
++		 */
++		provideRootNode(): T | Thenable<T>;
++
++		/**
++		 * Resolve the children of `node`.
++		 *
++		 * @param node The node from which the provider resolves children.
++		 * @return Children of `node`.
++		 */
++		resolveChildren(node: T): T[] | Thenable<T[]>;
++
++		/**
++		 * Provide a human-readable string that will be used for rendering the node.
++		 *
++		 * Default to use `node.toString()` if not provided.
++		 *
++		 * @param node The node from which the provider computes label.
++		 * @return A human-readable label.
++		 */
++		getLabel?(node: T): string;
++
++		/**
++		 * Determine if `node` has children and is expandable.
++		 *
++		 * Default to return `true` if not provided.
++		 *
++		 * @param node The node to determine if it has children and is expandable.
++		 * @return A boolean that determines if `node` has children and is expandable.
++		 */
++		getHasChildren?(node: T): boolean;
++
++		/**
++		 * Get the command to execute when `node` is clicked.
++		 *
++		 * Commands can be registered through (#commands.registerCommand). `node` will be provided","`[registerCommand](#commands.registerCommand)`
+",2016-10-24 15:20:34
+384,"@@ -136,17 +136,26 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				const windowConfig = this.configurationService.getConfiguration<IWindowConfiguration>();
++				if (windowConfig && windowConfig.window.macOSUseInlineToolbar) {
++					this.partService.layout();","This deserves a comment why we call layout under this condition.
+",2016-10-24 14:17:06
+385,"@@ -136,17 +136,26 @@ export class ElectronIntegration {
+ 		ipc.on('vscode:enterFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.addClass('fullscreen');
++				const windowConfig = this.configurationService.getConfiguration<IWindowConfiguration>();
++				if (windowConfig && windowConfig.window.macOSUseInlineToolbar) {
++					this.partService.layout();
++				}
+ 			});
+ 		});
+ 
+ 		ipc.on('vscode:leaveFullScreen', (event) => {
+ 			this.partService.joinCreation().then(() => {
+ 				this.partService.removeClass('fullscreen');
++				const windowConfig = this.configurationService.getConfiguration<IWindowConfiguration>();
++				if (windowConfig && windowConfig.window.macOSUseInlineToolbar) {
++					this.partService.layout();","This deserves a comment why we call layout under this condition.
+",2016-10-24 14:17:10
+733,"@@ -136,3 +144,36 @@ class ExecCommandPasteAction extends ExecCommandAction {
+ 		});
+ 	}
+ }
++
++@conditionalCopyWithSyntaxHighlighting()
++class ExecCommandCopyWithSyntaxHighlightingAction extends ExecCommandAction {
++
++	constructor() {
++		super('copy', {
++			id: 'editor.action.clipboardCopyWithSyntaxHighlightingAction',
++			label: nls.localize('actions.clipboard.copyWithSyntaxHighlightingLabel', ""Copy With Syntax Highlighting""),
++			alias: 'Copy With Syntax Highlighting',
++			precondition: null,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: null
++			},
++			menuOpts: {
++				group: CLIPBOARD_CONTEXT_MENU_GROUP,
++				order: 2
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: editorCommon.ICommonCodeEditor): void {
++		var enableEmptySelectionClipboard = editor.getConfiguration().contribInfo.emptySelectionClipboard && browser.enableEmptySelectionClipboard;
++
++		if (!enableEmptySelectionClipboard && editor.getSelection().isEmpty()) {
++			return;
++		}
++
++		window.localStorage.setItem('forceCopyWithSyntaxHighlighting', 'true');","very very nasty, especially for standalone editor embedders (other HTML pages outside vscode).
+
+In such cases you can use a static, you can put it somewhere in editor/config or something...",2017-02-16 15:57:16
+274,"@@ -136,6 +136,25 @@ export class NavigateBetweenGroupsAction extends Action {
+ 	}
+ }
+ 
++export class FocusActiveGroupAction extends Action {
++
++	public static ID = 'workbench.action.focusActiveEditorGroup';
++	public static LABEL = nls.localize('focusActiveEditorGroup', ""Focus Active Editor Group"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		this.editorService.getActiveEditor().focus();","@Tyriar You will get a NPE when no editor is opened!
+",2016-09-13 04:46:23
+84,"@@ -136,9 +136,9 @@ export class HTMLWorker {
+ 			return callback(false, model);
+ 		}
+ 
+-		let modeAtPosition = modelAtPosition.getMode();
++		let modeAtPositionMode = modelAtPosition.getMode();
+ 
+-		return callback(modeAtPosition.getId() !== this._modeId, modelAtPosition);
++		return callback(modeAtPositionMode.getId() !== this._modeId, modelAtPosition);
+ 	}","This is just a variable rename. Is there more to come?
+",2016-03-22 11:12:31
+424,"@@ -139,6 +141,11 @@ export abstract class MainThreadEditorsShape {
+ 	$tryApplyEdits(id: string, modelVersionId: number, edits: editorCommon.ISingleEditOperation[], opts: IApplyEditsOptions): TPromise<boolean> { throw ni(); }
+ }
+ 
++export abstract class MainThreadTreeExplorersShape {
++	$registerTreeExplorerNodeProvider(providerId: string): void { throw ni(); }
++	$showMessage(severity: Severity, message: string): void { throw ni(); }","[needs change] Why is this here? It duplicates functionality we already have in other places (ExtHostMessageService). Also, failure to resolve a tree item shouldn't automatically result in an error message. I propose to let the error bubble (as rejected promise) and handle the error in the tree, like showing an error node. 
+",2016-11-01 09:44:02
+852,"@@ -14,6 +14,7 @@ import { Builder, $ } from 'vs/base/browser/builder';
+ import DOM = require('vs/base/browser/dom');
+ import { DomScrollableElement } from 'vs/base/browser/ui/scrollbar/scrollableElement';
+ import { BoundedLinkedMap } from 'vs/base/common/map';
++import { IWindowsService } from 'vs/platform/windows/common/windows';",@mjbvz we try to have base not depending on platform if possible (see https://github.com/Microsoft/vscode/wiki/Code-Organization#layers),2017-03-23 14:00:15
+503,"@@ -14,84 +14,173 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
+ import { IFileService } from 'vs/platform/files/common/files';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ 
++export interface IBackupsFileModel {
++	resolve(backupRoot: string): TPromise<IBackupsFileModel>;
++
++	add(resource: Uri, versionId?: number): void;
++	has(resource: Uri, versionId?: number): boolean;
++	remove(resource: Uri): void;
++	clear(): void;
++}
++
++// TODO@daniel this should resolve the backups with their file names once we have the metadata in place
++export class BackupsFileModel implements IBackupsFileModel {",Maybe `BackupFilesModel` would be clearer to indicate this deals with multiple files?,2016-11-22 19:12:52
+502,"@@ -14,84 +14,173 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
+ import { IFileService } from 'vs/platform/files/common/files';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ 
++export interface IBackupsFileModel {
++	resolve(backupRoot: string): TPromise<IBackupsFileModel>;
++
++	add(resource: Uri, versionId?: number): void;
++	has(resource: Uri, versionId?: number): boolean;
++	remove(resource: Uri): void;
++	clear(): void;
++}
++
++// TODO@daniel this should resolve the backups with their file names once we have the metadata in place
++export class BackupsFileModel implements IBackupsFileModel {
++	private cache: { [resource: string]: number /* version ID */ } = Object.create(null);
++
++	resolve(backupRoot: string): TPromise<IBackupsFileModel> {",Explicit access modifiers?,2016-11-22 19:12:06
+501,"@@ -14,84 +14,173 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
+ import { IFileService } from 'vs/platform/files/common/files';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ 
++export interface IBackupsFileModel {
++	resolve(backupRoot: string): TPromise<IBackupsFileModel>;
++
++	add(resource: Uri, versionId?: number): void;
++	has(resource: Uri, versionId?: number): boolean;
++	remove(resource: Uri): void;
++	clear(): void;
++}
++
++// TODO@daniel this should resolve the backups with their file names once we have the metadata in place
++export class BackupsFileModel implements IBackupsFileModel {
++	private cache: { [resource: string]: number /* version ID */ } = Object.create(null);
++
++	resolve(backupRoot: string): TPromise<IBackupsFileModel> {
++		return pfs.readDirsInDir(backupRoot).then(backupSchemas => {
++
++			// For all supported schemas
++			return TPromise.join(backupSchemas.map(backupSchema => {
++
++				// Read backup directory for backups
++				const backupSchemaPath = path.join(backupRoot, backupSchema);
++				return pfs.readdir(backupSchemaPath).then(backupHashes => {
++
++					// Remember known backups in our caches
++					backupHashes.forEach(backupHash => {
++						const backupResource = Uri.file(path.join(backupSchemaPath, backupHash));
++						this.add(backupResource);
++					});
++				});
++			}));
++		}).then(() => this, error => this);
++	}
++
++	add(resource: Uri, versionId = 0): void {",Type `versionId`?,2016-11-22 19:11:57
+504,"@@ -14,84 +14,173 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
+ import { IFileService } from 'vs/platform/files/common/files';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ 
++export interface IBackupsFileModel {
++	resolve(backupRoot: string): TPromise<IBackupsFileModel>;
++
++	add(resource: Uri, versionId?: number): void;
++	has(resource: Uri, versionId?: number): boolean;
++	remove(resource: Uri): void;
++	clear(): void;
++}
++
++// TODO@daniel this should resolve the backups with their file names once we have the metadata in place
++export class BackupsFileModel implements IBackupsFileModel {
++	private cache: { [resource: string]: number /* version ID */ } = Object.create(null);
++
++	resolve(backupRoot: string): TPromise<IBackupsFileModel> {
++		return pfs.readDirsInDir(backupRoot).then(backupSchemas => {
++
++			// For all supported schemas
++			return TPromise.join(backupSchemas.map(backupSchema => {
++
++				// Read backup directory for backups
++				const backupSchemaPath = path.join(backupRoot, backupSchema);
++				return pfs.readdir(backupSchemaPath).then(backupHashes => {
++
++					// Remember known backups in our caches
++					backupHashes.forEach(backupHash => {
++						const backupResource = Uri.file(path.join(backupSchemaPath, backupHash));
++						this.add(backupResource);
++					});
++				});
++			}));
++		}).then(() => this, error => this);
++	}
++
++	add(resource: Uri, versionId = 0): void {
++		this.cache[resource.toString()] = versionId;
++	}
++
++	has(resource: Uri, versionId?: number): boolean {
++		const cachedVersionId = this.cache[resource.toString()];
++		if (typeof cachedVersionId !== 'number') {
++			return false; // unknown resource
++		}
++
++		if (typeof versionId === 'number') {
++			return versionId === cachedVersionId; // if we are asked with a specific version ID, make sure to test for it
++		}
++
++		return true;
++	}
++
++	remove(resource: Uri): void {
++		delete this.cache[resource.toString()];
++	}
++
++	clear(): void {
++		this.cache = Object.create(null);
++	}
++}
++
+ export class BackupFileService implements IBackupFileService {
+ 
+ 	public _serviceBrand: any;
+ 
+ 	protected backupHome: string;
+ 	protected workspacesJsonPath: string;
+ 
++	private backupWorkspacePath: string;
++	private ready: TPromise<IBackupsFileModel>;
++
+ 	constructor(
+ 		private currentWorkspace: Uri,
+ 		@IEnvironmentService private environmentService: IEnvironmentService,
+ 		@IFileService private fileService: IFileService
+ 	) {
+ 		this.backupHome = environmentService.backupHome;
+ 		this.workspacesJsonPath = environmentService.backupWorkspacesPath;
++
++		if (this.currentWorkspace) {
++			const workspaceHash = crypto.createHash('md5').update(this.currentWorkspace.fsPath).digest('hex');
++			this.backupWorkspacePath = path.join(this.backupHome, workspaceHash);
++		}
++
++		this.ready = this.init();
+ 	}
+ 
+ 	private get backupEnabled(): boolean {
+ 		return this.currentWorkspace && !this.environmentService.isExtensionDevelopment; // Hot exit is disabled for empty workspaces and when doing extension development
+ 	}
+ 
+-	public hasBackup(resource: Uri): TPromise<boolean> {
+-		const backupResource = this.getBackupResource(resource);
+-		if (!backupResource) {
+-			return TPromise.as(false);
+-		}
+-
+-		return pfs.exists(backupResource.fsPath);
+-	}
++	private init(): TPromise<IBackupsFileModel> {
++		const model = new BackupsFileModel();
+ 
+-	private getBackupHash(resource: Uri): string {
+ 		if (!this.backupEnabled) {
+-			return null;
++			return TPromise.as(model);
+ 		}
+ 
+-		// Only hash the file path if the file is not untitled
+-		return resource.scheme === 'untitled' ? resource.fsPath : crypto.createHash('md5').update(resource.fsPath).digest('hex');
++		return model.resolve(this.backupWorkspacePath);
+ 	}
+ 
+-	public getBackupResource(resource: Uri): Uri {
+-		const backupHash = this.getBackupHash(resource);
+-		if (!backupHash) {
+-			return null;
+-		}
+-
+-		const backupPath = path.join(this.getWorkspaceBackupDirectory(), resource.scheme, backupHash);
+-
+-		return Uri.file(backupPath);
++	public hasBackup(resource: Uri): TPromise<boolean> {
++		return this.ready.then(model => {
++			const backupResource = this.getBackupResource(resource);
++			if (!backupResource) {
++				return TPromise.as(false);
++			}
++
++			return model.has(backupResource);
++		});
+ 	}
+ 
+-	private getWorkspaceBackupDirectory(): string {
+-		const workspaceHash = crypto.createHash('md5').update(this.currentWorkspace.fsPath).digest('hex');
++	public loadBackupResource(resource: Uri): TPromise<Uri> {
++		return this.ready.then(() => {
++			return this.hasBackup(resource).then(hasBackup => {
++				if (hasBackup) {
++					return this.getBackupResource(resource);
++				}
+ 
+-		return path.join(this.backupHome, workspaceHash);
++				return void 0;
++			});
++		});
+ 	}
+ 
+-	public backupResource(resource: Uri, content: string): TPromise<void> {
+-		const backupResource = this.getBackupResource(resource);
+-		if (!backupResource) {
+-			return TPromise.as(void 0);
+-		}
++	public backupResource(resource: Uri, content: string, versionId?: number): TPromise<void> {
++		return this.ready.then(model => {
++			const backupResource = this.getBackupResource(resource);
++			if (!backupResource) {
++				return TPromise.as(void 0);",Make these `return void 0;` now since it's inside a promise?,2016-11-22 19:15:59
+505,"@@ -14,84 +14,173 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
+ import { IFileService } from 'vs/platform/files/common/files';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ 
++export interface IBackupsFileModel {
++	resolve(backupRoot: string): TPromise<IBackupsFileModel>;
++
++	add(resource: Uri, versionId?: number): void;
++	has(resource: Uri, versionId?: number): boolean;
++	remove(resource: Uri): void;
++	clear(): void;
++}
++
++// TODO@daniel this should resolve the backups with their file names once we have the metadata in place
++export class BackupsFileModel implements IBackupsFileModel {
++	private cache: { [resource: string]: number /* version ID */ } = Object.create(null);
++
++	resolve(backupRoot: string): TPromise<IBackupsFileModel> {
++		return pfs.readDirsInDir(backupRoot).then(backupSchemas => {
++
++			// For all supported schemas
++			return TPromise.join(backupSchemas.map(backupSchema => {
++
++				// Read backup directory for backups
++				const backupSchemaPath = path.join(backupRoot, backupSchema);
++				return pfs.readdir(backupSchemaPath).then(backupHashes => {
++
++					// Remember known backups in our caches
++					backupHashes.forEach(backupHash => {
++						const backupResource = Uri.file(path.join(backupSchemaPath, backupHash));
++						this.add(backupResource);
++					});
++				});
++			}));
++		}).then(() => this, error => this);
++	}
++
++	add(resource: Uri, versionId = 0): void {
++		this.cache[resource.toString()] = versionId;
++	}
++
++	has(resource: Uri, versionId?: number): boolean {
++		const cachedVersionId = this.cache[resource.toString()];
++		if (typeof cachedVersionId !== 'number') {
++			return false; // unknown resource
++		}
++
++		if (typeof versionId === 'number') {
++			return versionId === cachedVersionId; // if we are asked with a specific version ID, make sure to test for it
++		}
++
++		return true;
++	}
++
++	remove(resource: Uri): void {
++		delete this.cache[resource.toString()];
++	}
++
++	clear(): void {
++		this.cache = Object.create(null);
++	}
++}
++
+ export class BackupFileService implements IBackupFileService {
+ 
+ 	public _serviceBrand: any;
+ 
+ 	protected backupHome: string;
+ 	protected workspacesJsonPath: string;
+ 
++	private backupWorkspacePath: string;
++	private ready: TPromise<IBackupsFileModel>;
++
+ 	constructor(
+ 		private currentWorkspace: Uri,
+ 		@IEnvironmentService private environmentService: IEnvironmentService,
+ 		@IFileService private fileService: IFileService
+ 	) {
+ 		this.backupHome = environmentService.backupHome;
+ 		this.workspacesJsonPath = environmentService.backupWorkspacesPath;
++
++		if (this.currentWorkspace) {
++			const workspaceHash = crypto.createHash('md5').update(this.currentWorkspace.fsPath).digest('hex');
++			this.backupWorkspacePath = path.join(this.backupHome, workspaceHash);
++		}
++
++		this.ready = this.init();
+ 	}
+ 
+ 	private get backupEnabled(): boolean {
+ 		return this.currentWorkspace && !this.environmentService.isExtensionDevelopment; // Hot exit is disabled for empty workspaces and when doing extension development
+ 	}
+ 
+-	public hasBackup(resource: Uri): TPromise<boolean> {
+-		const backupResource = this.getBackupResource(resource);
+-		if (!backupResource) {
+-			return TPromise.as(false);
+-		}
+-
+-		return pfs.exists(backupResource.fsPath);
+-	}
++	private init(): TPromise<IBackupsFileModel> {
++		const model = new BackupsFileModel();
+ 
+-	private getBackupHash(resource: Uri): string {
+ 		if (!this.backupEnabled) {
+-			return null;
++			return TPromise.as(model);
+ 		}
+ 
+-		// Only hash the file path if the file is not untitled
+-		return resource.scheme === 'untitled' ? resource.fsPath : crypto.createHash('md5').update(resource.fsPath).digest('hex');
++		return model.resolve(this.backupWorkspacePath);
+ 	}
+ 
+-	public getBackupResource(resource: Uri): Uri {
+-		const backupHash = this.getBackupHash(resource);
+-		if (!backupHash) {
+-			return null;
+-		}
+-
+-		const backupPath = path.join(this.getWorkspaceBackupDirectory(), resource.scheme, backupHash);
+-
+-		return Uri.file(backupPath);
++	public hasBackup(resource: Uri): TPromise<boolean> {
++		return this.ready.then(model => {
++			const backupResource = this.getBackupResource(resource);
++			if (!backupResource) {
++				return TPromise.as(false);
++			}
++
++			return model.has(backupResource);
++		});
+ 	}
+ 
+-	private getWorkspaceBackupDirectory(): string {
+-		const workspaceHash = crypto.createHash('md5').update(this.currentWorkspace.fsPath).digest('hex');
++	public loadBackupResource(resource: Uri): TPromise<Uri> {
++		return this.ready.then(() => {
++			return this.hasBackup(resource).then(hasBackup => {
++				if (hasBackup) {
++					return this.getBackupResource(resource);
++				}
+ 
+-		return path.join(this.backupHome, workspaceHash);
++				return void 0;
++			});
++		});
+ 	}
+ 
+-	public backupResource(resource: Uri, content: string): TPromise<void> {
+-		const backupResource = this.getBackupResource(resource);
+-		if (!backupResource) {
+-			return TPromise.as(void 0);
+-		}
++	public backupResource(resource: Uri, content: string, versionId?: number): TPromise<void> {
++		return this.ready.then(model => {
++			const backupResource = this.getBackupResource(resource);
++			if (!backupResource) {
++				return TPromise.as(void 0);
++			}
++
++			if (model.has(backupResource, versionId)) {
++				return TPromise.as(void 0); // return early if backup version id matches requested one
++			}
+ 
+-		return this.fileService.updateContent(backupResource, content, BACKUP_FILE_UPDATE_OPTIONS).then(() => void 0);
++			return this.fileService.updateContent(backupResource, content, BACKUP_FILE_UPDATE_OPTIONS).then(() => model.add(backupResource, versionId));
++		});
+ 	}
+ 
+ 	public discardResourceBackup(resource: Uri): TPromise<void> {
+-		const backupResource = this.getBackupResource(resource);
+-		if (!backupResource) {
+-			return TPromise.as(void 0);
+-		}
+-
+-		return this.fileService.del(backupResource);
++		return this.ready.then(model => {
++			const backupResource = this.getBackupResource(resource);
++			if (!backupResource) {
++				return TPromise.as(void 0);
++			}
++
++			return this.fileService.del(backupResource).then(() => model.remove(backupResource));
++		});
+ 	}
+ 
+ 	public discardAllWorkspaceBackups(): TPromise<void> {
++		return this.ready.then(model => {
++			if (!this.backupEnabled) {
++				return TPromise.as(void 0);
++			}
++
++			return this.fileService.del(Uri.file(this.backupWorkspacePath)).then(() => model.clear());
++		});
++	}
++
++	public getBackupResource(resource: Uri): Uri {",Should this be `private`/`protected` now?,2016-11-22 19:16:58
+772,"@@ -141,6 +141,34 @@ export class FocusNextTerminalAction extends Action {
+ 	}
+ }
+ 
++export class FocusTerminalByNumberAction extends Action {
++	private static ID_PREFIX = 'workbench.action.terminal.focus';
++
++	constructor(
++		id: string, label: string,
++		@ITerminalService private terminalService: ITerminalService
++	) {
++		super(id, label);
++	}
++
++	public run(event?: any): TPromise<any> {
++		this.terminalService.setActiveInstanceByIndex(this.getTerminalNumber() - 1);
++		return this.terminalService.showPanel(true);
++	}
++
++	public static getId(n: number): string {
++		return FocusTerminalByNumberAction.ID_PREFIX + n;
++	}
++
++	public static getLabel(n: number): string {
++		return nls.localize(`workbench.action.terminal.focusByNumber${n}`, `Focus Terminal ${n}`, n);","Almost there 😃 I think this should be:
+
+```ts
+return nls.localize('workbench.action.terminal.focusByNumber', 'Focus Terminal {0}', n);
+```
+
+That way our localization system will understand it.",2017-02-21 16:17:15
+719,"@@ -1412,6 +1412,21 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * Options to configure the behavior of the message.
++	 *
++	 * @see [showInformationMessage](#window.showInformationMessage)
++	 * @see [showWarningMessage](#window.showWarningMessage)
++	 * @see [showErrorMessage](#window.showErrorMessage)
++	 */
++	export interface MessageOptions {
++
++		/**
++		 * Indicates that this message should be modal.
++		 */
++		modal?: boolean;
++	}",Can we already imagine having other options here? If not we should think about a naked boolean instead,2017-02-02 16:47:44
+261,"@@ -142,12 +199,13 @@ export class DebugHoverWidget implements editorbrowser.IContentWidget {
+ 		});
+ 	}
+ 
++	private getExpressionSupportingEvaluate(session: debug.IRawDebugSession, expression: string) : TPromise<Expression> {","No need for this method, just brings conffusion among method names. I recommend to just move these two lines out to the one place where you call this method from
+",2016-08-24 14:12:15
+601,"@@ -142,6 +175,76 @@ function buildRpmPackage(arch) {
+ 	]);
+ }
+ 
++function getFlatpakArch(arch) {
++	return { x64: 'x86_64', ia32: 'i386', arm: 'arm' }[arch];
++}
++
++function prepareFlatpak(arch) {
++	// This is not imported in the global scope to avoid requiring ImageMagick
++	// (or GraphicsMagick) when building not building Flatpak bundles.
++	const imgResize = require('gulp-image-resize');
++
++	const binaryDir = '../VSCode-linux-' + arch;
++	const flatpakArch = getFlatpakArch(arch);
++	const destination = '.build/linux/flatpak/' + flatpakArch;
++
++	return function () {
++		const all = [16, 24, 32, 48, 64, 128, 192, 256, 512].map(function (size) {",Are all these sizes necessary? The smaller ones in particular would probably look pretty crappy being scaled like this?,2016-12-13 19:31:01
+602,"@@ -142,6 +175,76 @@ function buildRpmPackage(arch) {
+ 	]);
+ }
+ 
++function getFlatpakArch(arch) {
++	return { x64: 'x86_64', ia32: 'i386', arm: 'arm' }[arch];
++}
++
++function prepareFlatpak(arch) {
++	// This is not imported in the global scope to avoid requiring ImageMagick
++	// (or GraphicsMagick) when building not building Flatpak bundles.
++	const imgResize = require('gulp-image-resize');
++
++	const binaryDir = '../VSCode-linux-' + arch;
++	const flatpakArch = getFlatpakArch(arch);
++	const destination = '.build/linux/flatpak/' + flatpakArch;
++
++	return function () {
++		const all = [16, 24, 32, 48, 64, 128, 192, 256, 512].map(function (size) {
++			return gulp.src('resources/linux/code.png', { base: '.' })
++				.pipe(imgResize({ width: size, height: size, format: ""png"", noProfile: true }))
++				.pipe(rename('share/icons/hicolor/' + size + 'x' + size + '/apps/' + flatpakManifest.appId + '.png'));
++		});
++
++		all.push(gulp.src('resources/linux/code.desktop', { base: '.' })
++			.pipe(replace('Exec=/usr/share/@@NAME@@/@@NAME@@', 'Exec=code-oss'))
++			.pipe(replace('@@NAME_LONG@@', product.nameLong))
++			.pipe(replace('@@NAME_SHORT@@', product.nameShort))
++			.pipe(replace('@@NAME@@', product.applicationName))
++			.pipe(rename('share/applications/' + flatpakManifest.appId + '.desktop')));
++
++		all.push(gulp.src('resources/linux/code.appdata.xml', { base: '.' })
++			.pipe(replace('@@NAME_LONG@@', product.nameLong))
++			.pipe(replace('@@NAME@@', flatpakManifest.appId))
++			.pipe(rename('share/appdata/' + flatpakManifest.appId + '.appdata.xml')));
++
++		all.push(gulp.src(binaryDir + '/**/*', { base:binaryDir })",What's this part doing?,2016-12-13 19:33:43
+603,"@@ -142,6 +175,76 @@ function buildRpmPackage(arch) {
+ 	]);
+ }
+ 
++function getFlatpakArch(arch) {
++	return { x64: 'x86_64', ia32: 'i386', arm: 'arm' }[arch];
++}
++
++function prepareFlatpak(arch) {
++	// This is not imported in the global scope to avoid requiring ImageMagick
++	// (or GraphicsMagick) when building not building Flatpak bundles.
++	const imgResize = require('gulp-image-resize');
++
++	const binaryDir = '../VSCode-linux-' + arch;
++	const flatpakArch = getFlatpakArch(arch);
++	const destination = '.build/linux/flatpak/' + flatpakArch;
++
++	return function () {
++		const all = [16, 24, 32, 48, 64, 128, 192, 256, 512].map(function (size) {
++			return gulp.src('resources/linux/code.png', { base: '.' })
++				.pipe(imgResize({ width: size, height: size, format: ""png"", noProfile: true }))
++				.pipe(rename('share/icons/hicolor/' + size + 'x' + size + '/apps/' + flatpakManifest.appId + '.png'));
++		});
++
++		all.push(gulp.src('resources/linux/code.desktop', { base: '.' })
++			.pipe(replace('Exec=/usr/share/@@NAME@@/@@NAME@@', 'Exec=code-oss'))
++			.pipe(replace('@@NAME_LONG@@', product.nameLong))
++			.pipe(replace('@@NAME_SHORT@@', product.nameShort))
++			.pipe(replace('@@NAME@@', product.applicationName))
++			.pipe(rename('share/applications/' + flatpakManifest.appId + '.desktop')));
++
++		all.push(gulp.src('resources/linux/code.appdata.xml', { base: '.' })
++			.pipe(replace('@@NAME_LONG@@', product.nameLong))
++			.pipe(replace('@@NAME@@', flatpakManifest.appId))
++			.pipe(rename('share/appdata/' + flatpakManifest.appId + '.appdata.xml')));
++
++		all.push(gulp.src(binaryDir + '/**/*', { base:binaryDir })
++			.pipe(rename(function (p) {
++				p.dirname = 'share/' + product.applicationName + '/' + p.dirname;
++			})));
++
++		return es.merge(all).pipe(vfs.dest(destination));
++	}
++}
++
++function buildFlatpak(arch) {
++	const flatpakArch = getFlatpakArch(arch);
++	const manifest = {};
++	for (var k in flatpakManifest) manifest[k] = flatpakManifest[k];",Use braces and put `manifest[k]..` on new line as this would fail ts style rules,2016-12-13 19:34:40
+604,"@@ -142,6 +175,76 @@ function buildRpmPackage(arch) {
+ 	]);
+ }
+ 
++function getFlatpakArch(arch) {
++	return { x64: 'x86_64', ia32: 'i386', arm: 'arm' }[arch];
++}
++
++function prepareFlatpak(arch) {
++	// This is not imported in the global scope to avoid requiring ImageMagick
++	// (or GraphicsMagick) when building not building Flatpak bundles.
++	const imgResize = require('gulp-image-resize');
++
++	const binaryDir = '../VSCode-linux-' + arch;
++	const flatpakArch = getFlatpakArch(arch);
++	const destination = '.build/linux/flatpak/' + flatpakArch;
++
++	return function () {
++		const all = [16, 24, 32, 48, 64, 128, 192, 256, 512].map(function (size) {
++			return gulp.src('resources/linux/code.png', { base: '.' })
++				.pipe(imgResize({ width: size, height: size, format: ""png"", noProfile: true }))
++				.pipe(rename('share/icons/hicolor/' + size + 'x' + size + '/apps/' + flatpakManifest.appId + '.png'));
++		});
++
++		all.push(gulp.src('resources/linux/code.desktop', { base: '.' })
++			.pipe(replace('Exec=/usr/share/@@NAME@@/@@NAME@@', 'Exec=code-oss'))
++			.pipe(replace('@@NAME_LONG@@', product.nameLong))
++			.pipe(replace('@@NAME_SHORT@@', product.nameShort))
++			.pipe(replace('@@NAME@@', product.applicationName))
++			.pipe(rename('share/applications/' + flatpakManifest.appId + '.desktop')));
++
++		all.push(gulp.src('resources/linux/code.appdata.xml', { base: '.' })
++			.pipe(replace('@@NAME_LONG@@', product.nameLong))
++			.pipe(replace('@@NAME@@', flatpakManifest.appId))
++			.pipe(rename('share/appdata/' + flatpakManifest.appId + '.appdata.xml')));
++
++		all.push(gulp.src(binaryDir + '/**/*', { base:binaryDir })
++			.pipe(rename(function (p) {
++				p.dirname = 'share/' + product.applicationName + '/' + p.dirname;
++			})));
++
++		return es.merge(all).pipe(vfs.dest(destination));
++	}
++}
++
++function buildFlatpak(arch) {
++	const flatpakArch = getFlatpakArch(arch);
++	const manifest = {};
++	for (var k in flatpakManifest) manifest[k] = flatpakManifest[k];
++	manifest.files = [
++		['.build/linux/flatpak/' + flatpakArch, '/'],
++	];
++	const buildOptions = {
++		arch: flatpakArch,
++		subject: product.nameLong + ' ' + packageJson.version + '.' + linuxPackageRevision,
++	};
++	// If requested, use the configured path for the OSTree repository.
++	if (process.env.FLATPAK_REPO) {
++		buildOptions.repoDir = process.env.FLATPAK_REPO;
++	} else {
++		buildOptions.bundlePath = manifest.appId + '-' + flatpakArch + '.flatpak';
++	}
++	// Setup PGP signing if requested.
++	if (process.env.GPG_KEY_ID !== undefined) {","I'd prefer to keep this and the `FLATPAK_REPO` if out until we decided to use them. Was this going to be for personal use, or?",2016-12-13 19:38:30
+409,"@@ -144,8 +234,12 @@ class ViewletActivityAction extends ActivityAction {
+ 	private static preventDoubleClickDelay = 300;
+ 	private lastRun: number = 0;
+ 
++	private _onOpenExternalViewlet = new Emitter<string>();
++	get onOpenExternalViewlet(): Event<string> { return this._onOpenExternalViewlet.event; };","Access modifier
+",2016-10-24 15:44:10
+182,"@@ -145,29 +153,55 @@ export default class Webview {
+ 		::-webkit-scrollbar {
+ 			width: 14px;
+ 			height: 10px;
+-		}
+-		::-webkit-scrollbar-thumb:hover {
+-			background-color: rgba(100, 100, 100, 0.7);
+ 		}`;
+ 
++		let bodyClasses = {
++			remove: ['monaco-editor', 'vs', 'vs-dark', 'hc-black']","do we need `monaco-editor`? 
+and for the sake of being aligned and explicit should we call the theme classes: `vscode-light`, `vscode-dark`, and `vscode-high-contrast`?
+",2016-06-14 13:36:50
+712,"@@ -145,6 +137,26 @@ class ImplementationAdapter {
+ 	}
+ }
+ 
++class TypeDefinitionAdapter {
++	constructor(",same,2017-02-02 07:59:39
+674,"@@ -145,7 +145,8 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 				previewEditors: editorConfig.enablePreview,
+ 				showIcons: editorConfig.showIcons,
+ 				showTabs: editorConfig.showTabs,
+-				showTabCloseButton: editorConfig.showTabCloseButton
++				showTabCloseButton: editorConfig.showTabCloseButton,",Just delete support for `showTabCloseButton` option since it is now supported via your `tabCloseButton` setting.,2017-01-16 07:57:57
+940,"@@ -147,6 +150,11 @@ export default class PHPValidationProvider {
+ 			let shellSettings = section.get<any>('validate.runInShell');
+ 			if (typeof(shellSettings) === 'boolean') {
+ 				this.runInShell = shellSettings;
++				if (this.platform.toLowerCase() === 'win32') {
++					this.shellExecutable = 'C:\\Windows\\sysnative\\bash.exe';","I think we can't assume that a user wants the bash if runInShell is set to true. I would expect that the user wants to use what is defined in ComSpec under Windows.
+
+And then we need to set the shellArgs accordingly as well since -c will not work with cmd.exe nor with powershell.exe. For cmd.exe this is /C and for PowerShell it is /Command
+",2017-05-18 08:25:03
+379,"@@ -147,6 +152,10 @@ export class TextFileEditorModelManager implements ITextFileEditorModelManager {
+ 		return true;
+ 	}
+ 
++	public get onModelContentChanged(): Event<TextFileModelChangeEvent> {","I see the need for an event when untitled or text files are changing so that the backup service can do its business, however I fear that this comes at the cost of spam: you will see many model content change events while the user is typing, so basically each key press will trigger this event. Performance should always be something to be concerned of, especially when it is typing performance we are talking about. 
+
+Some ideas:
+- buffer the model content change event and only start to emit the change after a certain delay
+- do not always create an event object to send around
+
+I think buffering would be a good idea anyway because backups should also not be created without some delay.
+",2016-10-21 14:09:35
+533,"@@ -147,6 +158,10 @@ export class BackupFileService implements IBackupFileService {
+ 				return void 0; // return early if backup version id matches requested one
+ 			}
+ 
++			if (resource.scheme === 'file') {","@Tyriar so you say that you do this only for files because untitled do not have this issue? not sure about that, what about someone that starts ""`code <file name>`"" where the file path does not exist and we show an untitled file with associated file path? I think we will have to store the path for untitled too in that case. Maybe untitled files should be stored differently on disk compared to today: instead of using their name (`Untitled-1`, `Untitled-2`), hash the associated file path and if there is none, hash the name. This would also be the fix for https://github.com/Microsoft/vscode/issues/15941",2016-11-29 05:22:11
+532,"@@ -147,6 +158,10 @@ export class BackupFileService implements IBackupFileService {
+ 				return void 0; // return early if backup version id matches requested one
+ 			}
+ 
++			if (resource.scheme === 'file') {
++				content = `${resource.fsPath}\n${content}`;",@Tyriar I suggest to use `Uri.toString()` here and `Uri.parse()` on the other side to reconstruct.,2016-11-29 05:20:03
+736,"@@ -147,7 +147,7 @@ configurationRegistry.registerConfiguration({
+ 				CreateNewTerminalAction.ID,
+ 				CopyTerminalSelectionAction.ID,
+ 				KillTerminalAction.ID,
+-				FocusTerminalAction.ID,
++				FocusActiveTerminalAction.ID,",I wonder if all the new commands should be added here as well?,2017-02-18 19:01:46
+720,"@@ -148,31 +148,32 @@ export class TerminalPanel extends Panel {
+ 				// Drop selection and focus terminal on Linux to enable middle button paste when click
+ 				// occurs on the selection itself.
+ 				this._terminalService.getActiveInstance().focus();
+-			} else if (event.which === 3) {
+-				if (this._terminalService.configHelper.getRightClickCopyPaste()) {
+-					let terminal = this._terminalService.getActiveInstance();
+-					if (terminal.hasSelection()) {
+-						terminal.copySelection();
+-						terminal.clearSelection();
+-					} else {
+-						terminal.paste();
+-					}
++			}
++		}));
++		this._register(DOM.addDisposableListener(this._parentDomElement, 'contextmenu', (event: MouseEvent) => {
++			if (this._terminalService.configHelper.getRightClickCopyPaste()) {",Should the right click copy/paste stuff still be in the mousedown handler and cancel the event if it goes off? I think cmd copies/pastes on mousedown rather than mouseup.,2017-02-03 20:01:34
+280,"@@ -148,7 +148,10 @@ export class ExtensionManagementService implements IExtensionManagementService {
+ 					const readme = children.filter(child => /^readme(\.txt|\.md|)$/i.test(child))[0];
+ 					const readmeUrl = readme ? URI.file(path.join(extensionPath, readme)).toString() : null;
+ 
+-					const local: ILocalExtension = { id, manifest, metadata, path: extensionPath, readmeUrl };
++					const changelog = children.filter(child => /^changelog(\.txt|\.md|)$/i.test(child))[0];
++					const changelogUrl = changelog ? URI.file(path.join(extensionPath, changelog)).toString() : null;","This code is a simple copy paste from the `readme` counterpart.
+Do you think would it be worth to rewrite in a more coincise way like `['changelog', 'readme'].reduce(() => {...}`?
+",2016-09-14 17:07:40
+636,"@@ -149,25 +149,30 @@ export class TerminalPanel extends Panel {
+ 				// occurs on the selection itself.
+ 				this._terminalService.getActiveInstance().focus();
+ 			} else if (event.which === 3) {
+-				// Trigger the context menu on right click
+-				let anchor: HTMLElement | { x: number, y: number } = this._parentDomElement;
+-				if (event instanceof MouseEvent) {","I just realized that this is actually my code haha, as long as the context menu appears in the correct spot after this change (when `rightClickCopyPaste` is false) then this was fine to remove :+1: ",2016-12-21 03:02:52
+621,"@@ -149,25 +149,35 @@ export class TerminalPanel extends Panel {
+ 				// occurs on the selection itself.
+ 				this._terminalService.getActiveInstance().focus();
+ 			} else if (event.which === 3) {
+-				// Trigger the context menu on right click
+-				let anchor: HTMLElement | { x: number, y: number } = this._parentDomElement;
+-				if (event instanceof MouseEvent) {
+-					const standardEvent = new StandardMouseEvent(event);
+-					anchor = { x: standardEvent.posx, y: standardEvent.posy };
+-				}
++				let rightClickAction: string = this._terminalService.configHelper.getRightClickAction();
++				if (rightClickAction === 'copyPaste') {",I was thinking of adding enum for rightClickAction but not sure it's worth it.,2016-12-18 22:51:17
+625,"@@ -149,25 +149,35 @@ export class TerminalPanel extends Panel {
+ 				// occurs on the selection itself.
+ 				this._terminalService.getActiveInstance().focus();
+ 			} else if (event.which === 3) {
+-				// Trigger the context menu on right click
+-				let anchor: HTMLElement | { x: number, y: number } = this._parentDomElement;
+-				if (event instanceof MouseEvent) {
+-					const standardEvent = new StandardMouseEvent(event);
+-					anchor = { x: standardEvent.posx, y: standardEvent.posy };
+-				}
++				let rightClickAction: string = this._terminalService.configHelper.getRightClickAction();
++				if (rightClickAction === 'copyPaste') {
++					let terminal = this._terminalService.getActiveInstance();
++					if (terminal.hasSelection()) {
++						terminal.copySelection();
++						terminal.clearSelection();
++					} else {
++						terminal.paste();
++					}
++				} else if (rightClickAction === 'contextMenu') {
++					let anchor: HTMLElement | { x: number, y: number } = this._parentDomElement;",Would prefer if these were 2 different variables (if you need to store `this._parentDomElement` at all),2016-12-19 05:38:26
+624,"@@ -149,25 +149,35 @@ export class TerminalPanel extends Panel {
+ 				// occurs on the selection itself.
+ 				this._terminalService.getActiveInstance().focus();
+ 			} else if (event.which === 3) {
+-				// Trigger the context menu on right click
+-				let anchor: HTMLElement | { x: number, y: number } = this._parentDomElement;
+-				if (event instanceof MouseEvent) {
+-					const standardEvent = new StandardMouseEvent(event);
+-					anchor = { x: standardEvent.posx, y: standardEvent.posy };
+-				}
++				let rightClickAction: string = this._terminalService.configHelper.getRightClickAction();
++				if (rightClickAction === 'copyPaste') {
++					let terminal = this._terminalService.getActiveInstance();
++					if (terminal.hasSelection()) {
++						terminal.copySelection();
++						terminal.clearSelection();
++					} else {
++						terminal.paste();
++					}
++				} else if (rightClickAction === 'contextMenu') {
++					let anchor: HTMLElement | { x: number, y: number } = this._parentDomElement;
++					if (event instanceof MouseEvent) {",Isn't `event` guaranteed to be a `MouseEvent`?,2016-12-19 05:37:47
+906,"@@ -149,6 +149,16 @@ export async function mkdirp(path: string, mode?: number): Promise<boolean> {
+ 	return true;
+ }
+ 
++export async function createOrAppendFile(path: string, data: string, options?: any): Promise<boolean> {","I'd rather we go through the `applyEdit` vscode API, instead of raw node file editing.",2017-05-05 08:38:15
+965,"@@ -149,6 +149,31 @@ export class ShowAllCommandsAction extends Action {
+ 	}
+ }
+ 
++export class ShowTasksAction extends Action {
++
++	public static ID = 'workbench.action.showTasks';
++	public static LABEL = nls.localize('showTasks', ""Show Task Menu"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IQuickOpenService private quickOpenService: IQuickOpenService,
++		@IConfigurationService private configurationService: IConfigurationService
++	) {
++		super(id, label);
++	}
++
++	public run(context?: any): TPromise<any> {
++		let value = ALL_COMMANDS_PREFIX;
++		let taskStr = 'tasks';","Style nitpick, use `const` when possible. ",2017-06-12 21:24:07
+528,"@@ -15,12 +15,31 @@ const util = require('./lib/util');
+ const packageJson = require('../package.json');
+ const product = require('../product.json');
+ 
++const linuxPackageRevision = Math.floor(new Date().getTime() / 1000);
++
++const flatpakManifest = {
++	appId: 'com.microsoft.CodeOSS',
++	sdk: 'org.freedesktop.Sdk',
++	runtime: 'org.freedesktop.Sdk',
++	runtimeVersion: '1.4',
++	base: 'io.atom.electron.BaseApp',
++	baseFlatpakref: 'https://s3-us-west-2.amazonaws.com/electron-flatpak.endlessm.com/electron-base-app-master.flatpakref',
++	command: ""code-oss"",
++	symlinks: [
++		['/share/code-oss/code-oss', '/bin/code-oss'],
++	],
++	finishArgs: [
++		'--share=ipc', '--socket=x11',  // Allow showing X11 windows.
++		'--filesystem=home',            // Allow access to home directory.","I think for a text editor, exposing as much of the filesystem as possible would be a good idea. So use `--filesystem=host` instead. That's what gnome-builder does, for example.",2016-11-28 20:17:01
+529,"@@ -15,12 +15,31 @@ const util = require('./lib/util');
+ const packageJson = require('../package.json');
+ const product = require('../product.json');
+ 
++const linuxPackageRevision = Math.floor(new Date().getTime() / 1000);
++
++const flatpakManifest = {
++	appId: 'com.microsoft.CodeOSS',
++	sdk: 'org.freedesktop.Sdk',
++	runtime: 'org.freedesktop.Sdk',
++	runtimeVersion: '1.4',
++	base: 'io.atom.electron.BaseApp',
++	baseFlatpakref: 'https://s3-us-west-2.amazonaws.com/electron-flatpak.endlessm.com/electron-base-app-master.flatpakref',
++	command: ""code-oss"",
++	symlinks: [
++		['/share/code-oss/code-oss', '/bin/code-oss'],
++	],
++	finishArgs: [
++		'--share=ipc', '--socket=x11',  // Allow showing X11 windows.
++		'--filesystem=home',            // Allow access to home directory.
++		'--device=dri',                 // Allow OpenGL rendering.","Other finish args to consider
+ - `--socket=pulseaudio` if the app or any app extensions need audio output
+ - `--share=network` to install extensions using the network connection
+ - `--talk-name=org.freedesktop.Notifications` if this even uses libnotify for desktop notifications
+
+Lastly a bit weird, but adding `--filesystem=/tmp` will make sure you get the system tmp directory, which chromium/electron is using for its single check. https://github.com/electron/electron/blob/master/chromium_src/chrome/browser/process_singleton_posix.cc#L12",2016-11-28 20:22:37
+597,"@@ -15,12 +15,35 @@ const util = require('./lib/util');
+ const packageJson = require('../package.json');
+ const product = require('../product.json');
+ 
++const linuxPackageRevision = Math.floor(new Date().getTime() / 1000);
++
++const flatpakManifest = {
++	appId: 'com.microsoft.CodeOSS',","Our application id in the other packages is `code[-insiders].desktop`, should this be the same or is this a new ID we would be introducing? This should be sourced from https://github.com/Microsoft/vscode/blob/master/product.json",2016-12-13 19:26:20
+598,"@@ -15,12 +15,35 @@ const util = require('./lib/util');
+ const packageJson = require('../package.json');
+ const product = require('../product.json');
+ 
++const linuxPackageRevision = Math.floor(new Date().getTime() / 1000);
++
++const flatpakManifest = {
++	appId: 'com.microsoft.CodeOSS',
++	sdk: 'org.freedesktop.Sdk',
++	runtime: 'org.freedesktop.Sdk',
++	runtimeVersion: '1.4',",What version is this for?,2016-12-13 19:27:47
+599,"@@ -15,12 +15,35 @@ const util = require('./lib/util');
+ const packageJson = require('../package.json');
+ const product = require('../product.json');
+ 
++const linuxPackageRevision = Math.floor(new Date().getTime() / 1000);
++
++const flatpakManifest = {
++	appId: 'com.microsoft.CodeOSS',
++	sdk: 'org.freedesktop.Sdk',
++	runtime: 'org.freedesktop.Sdk',
++	runtimeVersion: '1.4',
++	base: 'io.atom.electron.BaseApp',
++	baseFlatpakref: 'https://s3-us-west-2.amazonaws.com/electron-flatpak.endlessm.com/electron-base-app-master.flatpakref',
++	command: ""code-oss"",","```
+command: product.applicationName
+```",2016-12-13 19:28:22
+600,"@@ -15,12 +15,35 @@ const util = require('./lib/util');
+ const packageJson = require('../package.json');
+ const product = require('../product.json');
+ 
++const linuxPackageRevision = Math.floor(new Date().getTime() / 1000);
++
++const flatpakManifest = {
++	appId: 'com.microsoft.CodeOSS',
++	sdk: 'org.freedesktop.Sdk',
++	runtime: 'org.freedesktop.Sdk',
++	runtimeVersion: '1.4',
++	base: 'io.atom.electron.BaseApp',
++	baseFlatpakref: 'https://s3-us-west-2.amazonaws.com/electron-flatpak.endlessm.com/electron-base-app-master.flatpakref',
++	command: ""code-oss"",
++	symlinks: [
++		['/share/code-oss/bin/code-oss', '/bin/code-oss'],",This should use `product.applicationName` instead of `code-oss`,2016-12-13 19:28:39
+512,"@@ -15,6 +15,14 @@
+ 			""aliases"": [ ""PHP"", ""php"" ],
+ 			""mimetypes"": [""application/x-php""],
+ 			""configuration"": ""./language-configuration.json""
++		},
++		{
++			// For reference by services requiring PHP syntax highlighting for partial
++			// code missing script start/end tags.
++			""id"": ""phplanguage"",
++			""aliases"": [ null ], // unsupported: prevents language from appearing in Language Mode list","Couldn't this just be `""aliases"": null` instead of the one-element array?",2016-11-24 11:40:19
+387,"@@ -15,6 +15,8 @@
+ .monaco-workbench > .part.editor > .content > .one-editor-silo > .container > .title .tabs-container > .tab .tab-label a {
+ 	text-decoration: none;
+ 	font-size: 13px;
++	height:35px;
++	line-height: 35px;","Are these two still needed?
+",2016-10-24 14:22:04
+698,"@@ -150,6 +151,87 @@ class FormatOnType implements editorCommon.IEditorContribution {
+ 	}
+ }
+ 
++@commonEditorContribution
++class FormatOnPaste implements editorCommon.IEditorContribution {
++
++	private static ID = 'editor.contrib.formatOnPaste';
++
++	private editor: editorCommon.ICommonCodeEditor;
++	private workerService: IEditorWorkerService;
++	private callOnDispose: IDisposable[];
++	private callOnModel: IDisposable[];
++
++	constructor(editor: editorCommon.ICommonCodeEditor, @IEditorWorkerService workerService: IEditorWorkerService) {
++		this.editor = editor;
++		this.workerService = workerService;
++		this.callOnDispose = [];
++		this.callOnModel = [];
++
++		this.callOnDispose.push(editor.onDidChangeConfiguration(() => this.update()));
++		this.callOnDispose.push(editor.onDidChangeModel(() => this.update()));
++		this.callOnDispose.push(editor.onDidChangeModelLanguage(() => this.update()));
++		this.callOnDispose.push(DocumentRangeFormattingEditProviderRegistry.onDidChange(this.update, this));
++	}
++
++	private update(): void {
++
++		// clean up
++		this.callOnModel = dispose(this.callOnModel);
++
++		// we are disabled
++		if (!this.editor.getConfiguration().contribInfo.formatOnPaste) {
++			return;
++		}
++
++		// no model
++		if (!this.editor.getModel()) {
++			return;
++		}
++
++		var model = this.editor.getModel();",nitpick: prefer let over var (same two lines below),2017-01-19 15:40:14
+699,"@@ -150,6 +151,87 @@ class FormatOnType implements editorCommon.IEditorContribution {
+ 	}
+ }
+ 
++@commonEditorContribution
++class FormatOnPaste implements editorCommon.IEditorContribution {
++
++	private static ID = 'editor.contrib.formatOnPaste';
++
++	private editor: editorCommon.ICommonCodeEditor;
++	private workerService: IEditorWorkerService;
++	private callOnDispose: IDisposable[];
++	private callOnModel: IDisposable[];
++
++	constructor(editor: editorCommon.ICommonCodeEditor, @IEditorWorkerService workerService: IEditorWorkerService) {
++		this.editor = editor;
++		this.workerService = workerService;
++		this.callOnDispose = [];
++		this.callOnModel = [];
++
++		this.callOnDispose.push(editor.onDidChangeConfiguration(() => this.update()));
++		this.callOnDispose.push(editor.onDidChangeModel(() => this.update()));
++		this.callOnDispose.push(editor.onDidChangeModelLanguage(() => this.update()));
++		this.callOnDispose.push(DocumentRangeFormattingEditProviderRegistry.onDidChange(this.update, this));
++	}
++
++	private update(): void {
++
++		// clean up
++		this.callOnModel = dispose(this.callOnModel);
++
++		// we are disabled
++		if (!this.editor.getConfiguration().contribInfo.formatOnPaste) {
++			return;
++		}
++
++		// no model
++		if (!this.editor.getModel()) {
++			return;
++		}
++
++		var model = this.editor.getModel();
++
++		// no support
++		var [support] = OnTypeFormattingEditProviderRegistry.ordered(model);
++		if (!support || !support.autoFormatTriggerCharacters) {",No need for the support to have autoFormatTriggerCharacters. Perhaps a copy-paste error?,2017-01-19 15:40:44
+700,"@@ -150,6 +151,87 @@ class FormatOnType implements editorCommon.IEditorContribution {
+ 	}
+ }
+ 
++@commonEditorContribution
++class FormatOnPaste implements editorCommon.IEditorContribution {
++
++	private static ID = 'editor.contrib.formatOnPaste';
++
++	private editor: editorCommon.ICommonCodeEditor;
++	private workerService: IEditorWorkerService;
++	private callOnDispose: IDisposable[];
++	private callOnModel: IDisposable[];
++
++	constructor(editor: editorCommon.ICommonCodeEditor, @IEditorWorkerService workerService: IEditorWorkerService) {
++		this.editor = editor;
++		this.workerService = workerService;
++		this.callOnDispose = [];
++		this.callOnModel = [];
++
++		this.callOnDispose.push(editor.onDidChangeConfiguration(() => this.update()));
++		this.callOnDispose.push(editor.onDidChangeModel(() => this.update()));
++		this.callOnDispose.push(editor.onDidChangeModelLanguage(() => this.update()));
++		this.callOnDispose.push(DocumentRangeFormattingEditProviderRegistry.onDidChange(this.update, this));
++	}
++
++	private update(): void {
++
++		// clean up
++		this.callOnModel = dispose(this.callOnModel);
++
++		// we are disabled
++		if (!this.editor.getConfiguration().contribInfo.formatOnPaste) {
++			return;
++		}
++
++		// no model
++		if (!this.editor.getModel()) {
++			return;
++		}
++
++		var model = this.editor.getModel();
++
++		// no support
++		var [support] = OnTypeFormattingEditProviderRegistry.ordered(model);
++		if (!support || !support.autoFormatTriggerCharacters) {
++			return;
++		}
++
++		this.callOnModel.push(this.editor.onDidPaste((range: Range) => {
++			this.trigger(range);
++		}));
++	}
++
++	private trigger(range: Range): void {
++		if (this.editor.getSelections().length > 1) {
++			return;
++		}
++
++		const model = this.editor.getModel();
++		const { tabSize, insertSpaces } = model.getOptions();
++		const state = this.editor.captureState(editorCommon.CodeEditorStateFlag.Value, editorCommon.CodeEditorStateFlag.Position);
++
++		getDocumentRangeFormattingEdits(model, range, { tabSize, insertSpaces }).then(edits => {
++			return this.workerService.computeMoreMinimalEdits(model.uri, edits, []);
++		}).then(edits => {
++			if (!state.validate(this.editor) || isFalsyOrEmpty(edits)) {
++				return;
++			}
++			const command = new EditOperationsCommand(edits, this.editor.getSelection());
++			this.editor.executeCommand(this.getId(), command);
++			this.editor.focus();","No need to focus here, since we are not moving the focus anywhere. ",2017-01-19 15:41:59
+377,"@@ -151,15 +127,15 @@ export abstract class TextFileService implements ITextFileService {
+ 						return this.confirmBeforeShutdown(); // we still have dirty files around, so confirm normally
+ 					}
+ 
+-					return this.cleanupBackupsBeforeShutdown();
++					return this.backupService.cleanupBackupsBeforeShutdown(); // all good, no veto","All of the cleanupBackupsBeforeShutdown should move out into the backup service that itself should listen to lifecycle events.
+",2016-10-21 14:05:22
+197,"@@ -152,7 +153,7 @@ const jsonRegistry = <jsonContributionRegistry.IJSONContributionRegistry>platfor
+ jsonRegistry.registerSchema(schemaId, schema);
+ 
+ export class ConfigurationManager implements debug.IConfigurationManager {
+-
++	private settingsVariables: SettingsVariables;","Just move it one line down, so we have nice seperation between public / private members
+",2016-07-06 08:05:04
+442,"@@ -153,7 +153,7 @@ export abstract class ViewerViewlet extends Viewlet {
+  */
+ export class ViewletDescriptor extends CompositeDescriptor<Viewlet> {
+ 
+-	constructor(moduleId: string, ctorName: string, id: string, name: string, cssClass?: string, order?: number) {
++	constructor(moduleId: string, ctorName: string, id: string, name: string, cssClass?: string, order?: number, public isExternal: boolean = false) {","@octref `isExternal` is a bit confusing, can we maybe call this `isExtension`?
+",2016-11-03 08:23:28
+61,"@@ -155,44 +145,36 @@ export class OutputService implements IOutputService {
+ 		return Object.keys(this.receivedOutput);
+ 	}
+ 
+-	public clearOutput(channel = DEFAULT_OUTPUT_CHANNEL): void {
+-		this.receivedOutput[channel] = '';
++	public getActiveChannel(): string {
++		if (!this.outputPanel || !this.outputPanel.getInput()) {
++			return null;
++		}
+ 
+-		this._onOutput.fire({ channel: channel, output: null /* indicator to clear output */ });
++		return (<OutputEditorInput>this.outputPanel.getInput()).getChannel();
+ 	}
+ 
+-	public showOutput(channel: string = DEFAULT_OUTPUT_CHANNEL, sideBySide?: boolean | Position, preserveFocus?: boolean): TPromise<IEditor> {
+-
+-		// If already opened, focus it unless we want to preserve focus
+-		let existingOutputEditor = this.findOutputEditor(channel);
+-		if (existingOutputEditor) {
+-			if (!preserveFocus) {
+-				return this.editorService.focusEditor(existingOutputEditor);
+-			}
+-
+-			// Still reveal last line
+-			(<OutputEditorInput>existingOutputEditor.input).revealLastLine();
++	public clearOutput(channel: string): void {
++		this.receivedOutput[channel] = '';
+ 
+-			return Promise.as(existingOutputEditor);
+-		}
++		this._onOutput.fire({ channel: channel, output: null /* indicator to clear output */ });
++	}
+ 
+-		// Otherwise open new
+-		return this.editorService.openEditor(OutputEditorInput.getInstance(this.instantiationService, channel), preserveFocus ? EditorOptions.create({ preserveFocus: true }) : null, <any>sideBySide);
++	public showOutput(channel: string, preserveFocus?: boolean): TPromise<IEditor> {
++		return this.panelService.openPanel(OUTPUT_PANEL_ID, !preserveFocus).then((panel: OutputPanel) => {
++			this.outputPanel = panel;","@isidorn this seems weird to me, imagine I bring up the panel by just toggling it and output happens to be the last panel I had in there. all your assumptions about having the outputPanel inside the service would fail because the output panel was not revealed through this service. idealy I would try to reduce the use of outputPanel inside the service to a minimum. do we need it in all cases? could the active channel also be a property on the service? could ""revealLastLine"" move out and someone that wants to reveal just has to open the output panel and call reveal on it? think towards that and maybe we can get rid of the ""this.outputPanel"" in the service completly!
+",2016-01-21 16:13:17
+60,"@@ -155,44 +145,36 @@ export class OutputService implements IOutputService {
+ 		return Object.keys(this.receivedOutput);
+ 	}
+ 
+-	public clearOutput(channel = DEFAULT_OUTPUT_CHANNEL): void {
+-		this.receivedOutput[channel] = '';
++	public getActiveChannel(): string {
++		if (!this.outputPanel || !this.outputPanel.getInput()) {
++			return null;
++		}
+ 
+-		this._onOutput.fire({ channel: channel, output: null /* indicator to clear output */ });
++		return (<OutputEditorInput>this.outputPanel.getInput()).getChannel();
+ 	}
+ 
+-	public showOutput(channel: string = DEFAULT_OUTPUT_CHANNEL, sideBySide?: boolean | Position, preserveFocus?: boolean): TPromise<IEditor> {
+-
+-		// If already opened, focus it unless we want to preserve focus
+-		let existingOutputEditor = this.findOutputEditor(channel);
+-		if (existingOutputEditor) {
+-			if (!preserveFocus) {
+-				return this.editorService.focusEditor(existingOutputEditor);
+-			}
+-
+-			// Still reveal last line
+-			(<OutputEditorInput>existingOutputEditor.input).revealLastLine();
++	public clearOutput(channel: string): void {
++		this.receivedOutput[channel] = '';
+ 
+-			return Promise.as(existingOutputEditor);
+-		}
++		this._onOutput.fire({ channel: channel, output: null /* indicator to clear output */ });
++	}
+ 
+-		// Otherwise open new
+-		return this.editorService.openEditor(OutputEditorInput.getInstance(this.instantiationService, channel), preserveFocus ? EditorOptions.create({ preserveFocus: true }) : null, <any>sideBySide);
++	public showOutput(channel: string, preserveFocus?: boolean): TPromise<IEditor> {
++		return this.panelService.openPanel(OUTPUT_PANEL_ID, !preserveFocus).then((panel: OutputPanel) => {
++			this.outputPanel = panel;
++			return this.outputPanel.setInput(OutputEditorInput.getInstance(this.instantiationService, channel), EditorOptions.create({ preserveFocus: true })).
++				then(() => this.outputPanel);
++		});
+ 	}
+ 
+-	private findOutputEditor(channel: string): IEditor {
+-		let editors = this.editorService.getVisibleEditors();
+-		for (let i = 0; i < editors.length; i++) {
+-			let editor = editors[i];
+-			if (editor.input instanceof OutputEditorInput && (<OutputEditorInput>editor.input).getChannel() === channel && (<OutputEditorInput>editor.input).getMime() === OUTPUT_MIME) {
+-				return editor;
+-			}
++	public revealLastLine(): void {
++		if (this.outputPanel) {
++			this.outputPanel.revealLastLine();
+ 		}
+-
+-		return null;
+ 	}
+ 
+ 	public dispose(): void {
++		this.outputPanel.dispose();","@isidorn suggest to not dispose outputPanel here, it will be handled when the compositePart is disposed
+",2016-01-21 16:11:13
+59,"@@ -156,18 +149,12 @@ export class StringEditor extends BaseTextEditor {
+ 		let options = super.getCodeEditorOptions();
+ 
+ 		let input = this.getInput();
+-		let isLog = input instanceof LogEditorInput;
+ 		let isUntitled = input instanceof UntitledEditorInput;
+ 
+ 		options.readOnly = !isUntitled; 				// all string editors are readonly except for the untitled one
+ 
+-		if (isLog) {
+-			options.wrappingColumn = 0;					// all log editors wrap
+-			options.lineNumbers = false;				// all log editors hide line numbers
+-		} else {
+-			options.wrappingColumn = this.defaultWrappingColumn; 	// otherwise make sure to restore the defaults
+-			options.lineNumbers = this.defaultLineNumbers; 			// otherwise make sure to restore the defaults
+-		}
++		options.wrappingColumn = this.defaultWrappingColumn; 	// otherwise make sure to restore the defaults","@isidorn suggest to remove the concept of defaultWrappingColumn and defaultLineNumbers because it was only needed for the outputEditorInput and this now moved nicely into the outputPanel
+",2016-01-21 16:00:49
+508,"@@ -156,6 +168,15 @@ export class ViewCursor {
+ 			this._domNode.setLineHeight(this._lineHeight);
+ 			this._domNode.setHeight(this._lineHeight);
+ 
++			let desiredWidth = '1ch';",@rebornix Computing the desiredWidth and setting it needs to happen only if the cursor style is set to block.,2016-11-23 18:57:12
+171,"@@ -157,13 +155,14 @@ export class TerminalPanel extends Panel {
+ 				this.setTerminalTheme();
+ 			}));
+ 			this.toDispose.push(this.configurationService.onDidUpdateConfiguration((e) => {
+-				this.setTerminalFont();
++				this.updateFont(true);
++				this.layout(new Dimension(this.parentDomElement.offsetWidth, this.parentDomElement.offsetHeight));
+ 			}));
+ 
+ 			this.terminal.open(this.terminalDomElement);
+ 			this.parentDomElement.appendChild(terminalScrollbar.getDomNode());
+ 
+-			this.setTerminalFont();
++			this.updateFont();","Why not measure the characters at this point?
+",2016-06-02 07:01:21
+853,"@@ -157,9 +158,21 @@ export class ResourceViewer {
+ 		else {
+ 			$(container)
+ 				.empty()
+-				.span({
++				.append($('p', {
+ 					text: nls.localize('nativeBinaryError', ""The file will not be displayed in the editor because it is either binary, very large or uses an unsupported text encoding."")
+-				});
++				}))
++				.append($('a', {
++					role: 'button',
++					class: 'open-external',
++					text: nls.localize('resourceOpenExternal', ""Try opening file in external program?"")
++				}).on(DOM.EventType.CLICK, (e) => {
++					windowsService.openExternal(descriptor.resource.toString()).then(didOpen => {","Do we have an understanding what this native call does when the file is an executable? Also, how does this behave when you are seeing a binary file which is associated with VS Code, you click it only to see the same issue again because it opens in VS Code?",2017-03-23 14:01:21
+256,"@@ -16,14 +16,15 @@
+ 		""grammars"": [{
+ 			""language"": ""python"",
+ 			""scopeName"": ""source.python"",
+-			""path"": ""./syntaxes/Python.tmLanguage""
++			""path"": ""./syntaxes/Python.tmLanguage.json""
+ 		},{
+ 			""scopeName"": ""source.regexp.python"",
+-			""path"": ""./syntaxes/Regular Expressions (Python).tmLanguage""
++			""path"": ""./syntaxes/Regular Expressions (Python).tmLanguage.json""
+ 		}]
+ 	},
+ 	""scripts"": {
+ 		""compile"": ""gulp compile-extension:python"",
+-		""watch"": ""gulp watch-extension:python""
++		""watch"": ""gulp watch-extension:python"",
++		""update-grammar"": ""node ../../build/npm/update-grammar.js MagicStack/MagicPython grammars/MagicPython.tmLanguage ./syntaxes/Python.tmLanguage.json && node ../../build/npm/update-grammar.js MagicStack/MagicPython grammars/MagicRegExp.tmLanguage './syntaxes/Regular Expressions (Python).tmLanguage.json'""","I'd suggest to name the second output file MagicRegExp.tmLanguage.json as to not confuse where it came from.
+Also if both grammars are from the same repo, you can use a single call to update-grammar (with 5 parameters: repo, grammarRepoPath1, extPath1, grammarRepoPath2, extPath2)
+",2016-08-19 06:41:54
+753,"@@ -16,15 +16,15 @@
+ }",Looks good,2017-02-20 14:02:54
+41,"@@ -16,6 +16,7 @@ export const Identifiers = {
+ 	WORKBENCH_CONTAINER: 'workbench.main.container',
+ 	ACTIVITYBAR_PART: 'workbench.parts.activitybar',
+ 	SIDEBAR_PART: 'workbench.parts.sidebar',
++	PANEL_PART: 'workbench.parts.panelpart',","@isidorn suggest to call it just ""workbench.parts.panel""
+",2016-01-15 15:16:42
+991,"@@ -16,7 +13,7 @@
+ 		""grammars"": [{
+ 			""language"": ""r"",
+ 			""scopeName"": ""source.r"",
+-			""path"": ""./syntaxes/r.tmLanguage.json""",Please keep using the .tmLanguage.json file extension. It makes it easier for us to distinguish the various JSON files.,2017-06-19 13:56:56
+842,"@@ -160,6 +160,41 @@ suite('workspace-namespace', () => {
+ 		});
+ 	});
+ 
++	test('eol, read', () => {",Is there any reason to call-out the scenario in which there is an equal number of LF vs. CRLF line endings?,2017-03-21 17:50:27
+843,"@@ -160,6 +160,41 @@ suite('workspace-namespace', () => {
+ 		});
+ 	});
+ 
++	test('eol, read', () => {
++		const a = createRandomFile('foo\nbar\nbar').then(file => {
++			return workspace.openTextDocument(file).then(doc => {
++				assert.equal(doc.eol, EndOfLine.LF);
++			});
++		});
++		const b = createRandomFile('foo\nbar\nbar\r\nbaz').then(file => {
++			return workspace.openTextDocument(file).then(doc => {
++				assert.equal(doc.eol, EndOfLine.LF);
++			});
++		});
++		const c = createRandomFile('foo\r\nbar\r\nbar').then(file => {
++			return workspace.openTextDocument(file).then(doc => {
++				assert.equal(doc.eol, EndOfLine.CRLF);
++			});
++		});
++		return Promise.all([a, b, c]);
++	});
++
++	test('eol, change via editor', () => {
++		return createRandomFile('foo\nbar\nbar').then(file => {
++			return workspace.openTextDocument(file).then(doc => {
++				assert.equal(doc.eol, EndOfLine.LF);
++				return window.showTextDocument(doc).then(editor => {
++					return editor.edit(builder => builder.setEndOfLine(EndOfLine.CRLF));","I'm assuming this is now ""the way"" to do it for extension authors as well, correct?",2017-03-21 17:51:33
+463,"@@ -160,6 +164,14 @@ export class LifecycleService implements ILifecycleService {
+ 			const oneTimeCancelEvent = 'vscode:cancel' + oneTimeEventToken;
+ 
+ 			ipc.once(oneTimeOkEvent, () => {
++				// Clear out any workspace backups from workspaces.json that don't have any backups
++				if (vscodeWindow.openedWorkspacePath) {","@Tyriar this is ugly, instead I suggest to introduce an event that the lifecycle service (on the main side) emits with the veto result of the unload call. The backup main service should listen to this event and do its business when it happens.
+",2016-11-09 07:12:16
+873,"@@ -1617,7 +1617,7 @@ declare module 'vscode' {
+ 		/**
+ 		 * The command this code lens represents.
+ 		 */
+-		command?: Command;
++		command?: Command | string;",@jrieken I'm not a huge fan of this API design. Let me know if you have any suggestions on a better way to express this  ,2017-04-10 22:02:49
+63,"@@ -163,7 +163,7 @@ export abstract class TextAreaState {
+ 		if (currentSelectionStart === currentSelectionEnd) {
+ 			// composition accept case
+ 			// [blahblah] => blahblah|
+-			if (previousValue === currentValue && previousSelectionStart === 0 && previousSelectionEnd === previousValue.length && currentSelectionStart === currentValue.length) {
++			if (previousValue === currentValue && previousSelectionStart === 0 && previousSelectionEnd === previousValue.length && currentSelectionStart === currentValue.length && currentValue !== '\n') {","@alexandrudima 
+
+When replacing the end-of-line with a newline, this check results in no typing being recognized (well, on the first typing, on the second it is recorded).  I added this specific check for enter but I'm not convinced it's correct.
+",2016-01-31 19:17:53
+661,"@@ -1633,6 +1633,24 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * The implementation provider interface defines the contract between extensions and
++	 * the go to implementation feature.
++	 */
++	export interface ImplementationProvider {",Maybe `TypeDefinitionProvider` would be a better name?,2017-01-10 08:38:30
+634,"@@ -165,6 +165,9 @@ suite('Workbench - TerminalConfigHelper', () => {
+ 					},
+ 					shellArgs: {
+ 						linux: []
++					},
++					rightClickAction: {",These can be removed now that the setting changed.,2016-12-21 03:00:00
+713,"@@ -1668,6 +1668,24 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * The type definition provider defines the contract between extensions and
++	 * the go to type definition feature.",Like the other language features this needs a section the doc (editing evolved) such that people has a clear understanding of what this is,2017-02-02 08:00:55
+199,"@@ -167,7 +168,14 @@ export class TerminalPanel extends Panel {
+ 		if (!themeId) {
+ 			themeId = this.themeService.getTheme();
+ 		}
+-		let theme = this.configurationHelper.getTheme(themeId);
++
++		let terminalThemeId = this.configurationHelper.getTerminalThemeId(themeId);","Can you pull `getBaseThemeId` into this file and check it here instead of calling into `configurationHelper` twice?
+",2016-07-06 22:59:10
+511,"@@ -1671,12 +1695,12 @@ class DiffEdtorWidgetInline extends DiffEditorWidgetStyle implements IDiffEditor
+ 		// Nothing to do..
+ 	}
+ 
+-	_getViewZones(lineChanges: editorCommon.ILineChange[], originalForeignVZ: editorCommon.IEditorWhitespace[], modifiedForeignVZ: editorCommon.IEditorWhitespace[], originalEditor: editorBrowser.ICodeEditor, modifiedEditor: editorBrowser.ICodeEditor): IEditorsZones {
+-		let computer = new InlineViewZonesComputer(lineChanges, originalForeignVZ, modifiedForeignVZ, originalEditor, modifiedEditor);
++	_getViewZones(lineChanges: editorCommon.ILineChange[], originalForeignVZ: editorCommon.IEditorWhitespace[], modifiedForeignVZ: editorCommon.IEditorWhitespace[], originalEditor: editorBrowser.ICodeEditor, modifiedEditor: editorBrowser.ICodeEditor, renderIndicators?: boolean): IEditorsZones {",same question,2016-11-23 19:01:27
+204,"@@ -168,10 +168,27 @@ export class ToggleRenderWhitespaceAction extends EditorAction {
+ 	}
+ }
+ 
++export class ToggleRenderControlCharacterAction extends EditorAction {
++	static ID = 'editor.action.toggleRenderControlCharacter';","Here is `static ID = 'editor.action.toggleRenderControlCharacters';`
+
+Fixes https://github.com/Microsoft/vscode/issues/8823
+",2016-07-07 09:26:15
+294,"@@ -168,13 +170,17 @@ export class VSCodeWindow {
+ 			title: this.envService.product.nameLong,
+ 			webPreferences: {
+ 				'backgroundThrottling': false // by default if Code is in the background, intervals and timeouts get throttled
+-			}
++			},","extra comma
+",2016-10-05 06:41:24
+98,"@@ -169,6 +169,7 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(RevertFileAction, Reve
+ registry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewFolderAction, GlobalNewFolderAction.ID, GlobalNewFolderAction.LABEL), category);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(GlobalCompareResourcesAction, GlobalCompareResourcesAction.ID, GlobalCompareResourcesAction.LABEL), category);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(CloseFileAction, CloseFileAction.ID, CloseFileAction.LABEL, { primary: KeyMod.chord(KeyMod.CtrlCmd | KeyCode.KEY_K, KeyCode.KEY_W) }), category);
++registry.registerWorkbenchAction(new SyncActionDescriptor(OpenRecentlyClosedResourcesAction, OpenRecentlyClosedResourcesAction.ID, OpenRecentlyClosedResourcesAction.LABEL), category);","Some thoughts:
+- [x] name this ""Reopen Closed File"" (as ST)
+- [x] add it as first entry under the File > Open Recent menu
+- [x] steal the proper keybinding for this from the run test task thingy
+",2016-04-09 14:39:34
+206,"@@ -169,8 +168,8 @@ export class ConfigurationManager implements debug.IConfigurationManager {
+ 		@IQuickOpenService private quickOpenService: IQuickOpenService,
+ 		@IKeybindingService private keybindingService: IKeybindingService
+ 	) {","This will probably throw an exception if you open the no-folder workspace.
+That is the reason why I originally check for this.contextService.getWorkspace(), I think you need to re-introduce that check.
+",2016-07-08 13:54:53
+913,"@@ -17,15 +17,21 @@ import * as nls from 'vscode-nls';
+ 
+ const localize = nls.loadMessageBundle();
+ 
+-class CheckoutItem implements QuickPickItem {
++class CheckoutBasicItem implements QuickPickItem {",Why not instead of this simply create a new `class MergeItem implements QuickPick`?,2017-05-05 10:15:18
+595,"@@ -17,31 +17,66 @@ interface IPackageInfo {
+ 
+ var telemetryReporter: TelemetryReporter | null;
+ 
++interface IToken {
++	type: string;
++	map: [number, number];
++}
++
++interface MarkdownIt {
++	render(text: string): string;
++	parse(text: string): IToken[];
++}
++
++function createMarkdownIt(): MarkdownIt {
++	const hljs = require('highlight.js');
++	const mdnh = require('markdown-it-named-headers');
++	const md = require('markdown-it')({
++		html: true,
++		highlight: (str: string, lang: string) => {
++			if (lang && hljs.getLanguage(lang)) {
++				try {
++					return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
++				} catch (error) { }
++			}
++			return `<pre class=""hljs""><code><div>${md.utils.escapeHtml(str)}</div></code></pre>`;
++		}
++	}).use(mdnh, {});
++
++	return md;
++}
++
++const FrontMatterRegex = /^---\s*(.|\s)*?---\s*/;
++
+ export function activate(context: vscode.ExtensionContext) {
+ 
+ 	let packageInfo = getPackageInfo(context);
+ 	telemetryReporter = packageInfo && new TelemetryReporter(packageInfo.name, packageInfo.version, packageInfo.aiKey);
+ 
+-	let provider = new MDDocumentContentProvider(context);
+-	let registration = vscode.workspace.registerTextDocumentContentProvider('markdown', provider);
++	const markdownIt = createMarkdownIt();","Previously the creation of the  markdown it object was deferred until it was actually needed. Now it will be created on extension activation.
+
+How about giving the consumers of markdown it a `MarkdownItProvider` object that can create the markdown-it instance when first invoked and cache it for subsequent calls?",2016-12-09 20:08:35
+93,"@@ -17,6 +17,10 @@
+ 	overflow: hidden;
+ }
+ 
++.explorer-viewlet .explorer-item-label a, .explorer-viewlet .working-files-item-label {
++	margin-right: 12px;
++}
++","Why?
+",2016-03-30 05:25:43
+475,"@@ -17,6 +17,11 @@ export interface IUntitledEditorService {
+ 	_serviceBrand: any;
+ 
+ 	/**
++	 * Events for when untitled editors content changes (e.g. any keystroke).
++	 */
++	onDidChangeContent: Event<URI>;","@Tyriar can we have test coverage for `onDidChangeContent` and `onDidDisposeModel`
+",2016-11-09 07:44:34
+788,"@@ -17,6 +17,7 @@
+ 	""format.insertSpaceBeforeAndAfterBinaryOperators"": ""Defines space handling after a binary operator."",
+ 	""format.insertSpaceAfterKeywordsInControlFlowStatements"": ""Defines space handling after keywords in a control flow statement."",
+ 	""format.insertSpaceAfterFunctionKeywordForAnonymousFunctions"": ""Defines space handling after function keyword for anonymous functions."",
++	""format.insertSpaceBeforeFunctionParenthesis"": ""Defines space handling before function argument parentheses."",",Please add a ` Requires TypeScript >= 2.1.5.` blurb at the end ,2017-03-02 08:17:36
+667,"@@ -17,7 +17,7 @@ export const TERMINAL_SERVICE_ID = 'terminalService';
+ 
+ export const TERMINAL_DEFAULT_SHELL_LINUX = !platform.isWindows ? (process.env.SHELL || 'sh') : 'sh';
+ export const TERMINAL_DEFAULT_SHELL_OSX = !platform.isWindows ? (process.env.SHELL || 'sh') : 'sh';
+-export const TERMINAL_DEFAULT_SHELL_WINDOWS = processes.getWindowsShell();
++/**    const TERMINAL_DEFAULT_SHELL_WINDOWS moved to ../electron-browser/terminal.ts */",You can remove this line :+1: ,2017-01-13 06:55:25
+352,"@@ -170,6 +170,7 @@ export class ExtensionsViewlet extends Viewlet implements IExtensionsViewlet {
+ 				new Separator(),
+ 				this.instantiationService.createInstance(ChangeSortAction, 'extensions.sort.install', localize('sort by installs', ""Sort By: Install Count""), this.onSearchChange, 'installs', undefined),
+ 				this.instantiationService.createInstance(ChangeSortAction, 'extensions.sort.rating', localize('sort by rating', ""Sort By: Rating""), this.onSearchChange, 'rating', undefined),
++				this.instantiationService.createInstance(ChangeSortAction, 'extensions.sort.name', localize('sort by name', ""Sort By: Name""), this.onSearchChange, 'name', undefined),","Are you sure this alone fixes it? Did you give it a try?
+",2016-10-20 14:29:21
+30,"@@ -171,7 +171,7 @@ export function distinct<T>(array: T[], keyFn?: (t: T) => string): T[] {
+ }
+ 
+ export function first<T>(array: T[], fn: (item: T) => boolean, notFoundValue: T = null): T {
+-	for (let i = 0; i < array.length; i++) {
++	for (let i = 0, I = array.length; i < I; i++) {
+ 		const element = array[i];","we don't do upper-case locals
+",2015-12-23 12:39:54
+31,"@@ -171,7 +171,7 @@ export function distinct<T>(array: T[], keyFn?: (t: T) => string): T[] {
+ }
+ 
+ export function first<T>(array: T[], fn: (item: T) => boolean, notFoundValue: T = null): T {
+-	for (let i = 0; i < array.length; i++) {
++	for (let i = 0, iMax = array.length; i < iMax; i++) {","sorry, actually we should use a ES6 for-of loop and let the compiler/engine decide
+",2015-12-23 13:12:20
+535,"@@ -172,6 +187,29 @@ export class BackupFileService implements IBackupFileService {
+ 		});
+ 	}
+ 
++	public getWorkspaceTextFileBackups(): TPromise<string[]> {","@Tyriar at first I thought this should move into the cache but then we would stop each and every file open waiting for this to be done. Since backups can be restored later, I think it is OK to leave this outside of the cache even though the result could probably be cached.",2016-11-29 05:27:02
+429,"@@ -173,6 +177,16 @@ export class ViewletRegistry extends CompositeRegistry<Viewlet> {
+ 	}
+ 
+ 	/**
++	 * Registers multiple external viewlets.
++	 */
++	public registerExternalViewlets(descriptors: ViewletDescriptor[]): void {","This feels wrong - since we always register `ViewletDescriptor`-instances we shouldn't use two separate functions. Why not treat viewlet and external viewlet equal, have only one function, one event which we send for each viewlet registration, let listeners filter on `ViewletDescriptor#isExternal`
+",2016-11-01 09:55:33
+794,"@@ -174,6 +175,12 @@ function main(accessor: ServicesAccessor, mainIpcServer: Server, userEnv: platfo
+ 		// TODO@Joao: unfold this
+ 		windowsMainService = accessor.get(IWindowsMainService);
+ 
++		windowsMainService.onWindowClose(() => {
++			if (windowsMainService.getWindowCount() === 0) {","@joaomoreno as I said before, this should have a check for Windows/Linux, because only there we close the app when closing the last window!",2017-03-03 18:03:54
+936,"@@ -175,6 +175,7 @@ export class SearchViewlet extends Viewlet {
+ 		const exclusionsUsePattern = this.viewletSettings['query.exclusionsUsePattern'];
+ 		const includesUsePattern = this.viewletSettings['query.includesUsePattern'];
+ 		const patternIncludes = this.viewletSettings['query.folderIncludes'] || '';
++		const userExtended = this.viewletSettings['query.userExtended'] || '';","Looks great, only comment is that the name `userExtended` isn't totally obvious at first. Maybe `queryDetailsExpanded` or something like that?",2017-05-16 00:34:06
+170,"@@ -177,14 +176,14 @@ export class TerminalPanel extends Panel {
+ 		this.terminal.refresh(0, this.terminal.rows);
+ 	}
+ 
+-	/**
+-	 * Set the terminal font to `terminal.integrated.fontFamily` if it is set, otherwise fallback to
+-	 * `editor.fontFamily`.
+-	 */
+-	private setTerminalFont(): void {
+-		this.terminalDomElement.style.fontFamily = this.configurationHelper.getFontFamily();
++	private updateFont(updateCharSize?: boolean): void {
++		this.font = this.configurationHelper.getFont(this.parentDomElement, updateCharSize);
++		this.terminalDomElement.style.fontFamily = this.font.fontFamily;
++		this.terminalDomElement.style.lineHeight = this.font.lineHeight + 'px';
++		this.terminalDomElement.style.fontSize = this.font.fontSize + 'px';","This triggers `this.layout`, right?
+",2016-06-02 07:00:52
+174,"@@ -177,14 +177,15 @@ export class TerminalPanel extends Panel {
+ 		this.terminal.refresh(0, this.terminal.rows);
+ 	}
+ 
+-	/**
+-	 * Set the terminal font to `terminal.integrated.fontFamily` if it is set, otherwise fallback to
+-	 * `editor.fontFamily`.
+-	 */
+-	private setTerminalFont(): void {
+-		this.terminalDomElement.style.fontFamily = this.configurationHelper.getFontFamily();
++	private updateFont(): void {
++		this.font = this.configurationHelper.getFont();","Fix indentation
+",2016-06-02 20:21:55
+215,"@@ -177,6 +177,33 @@ suite('Event',function(){
+ 			Errors.setUnexpectedErrorHandler(origErrorHandler);
+ 		}
+ 	});
++
++	test('Debounce Event', function () {","since this test is async (setTimeout) you must add the `done` parameter and call it. Alternatively make this test return a promise.
+",2016-07-13 10:43:57
+201,"@@ -177,7 +178,7 @@ suite('Workbench - TerminalConfigHelper', () => {
+ 		let configHelper: TerminalConfigHelper;
+ 
+ 		configHelper = new TerminalConfigHelper(Platform.Linux, configurationService, fixture);
+-		assert.deepEqual(configHelper.getTheme('hc-black foo'), [","Just pass in the base theme IDs for the tests and this is good to go.
+
+``` js
+assert.deepEqual(configHelper.getTheme('hc-black'), [
+```
+",2016-07-07 00:21:25
+100,"@@ -1783,6 +1783,43 @@ export class OpenResourcesAction extends Action {
+ 	}
+ }
+ 
++export class OpenRecentlyClosedResourcesAction extends Action {
++
++	public static ID = 'workbench.files.action.openRecentlyClosedFile';
++	public static LABEL = nls.localize('openRecentlyClosedFile', ""Open Recently Closed File"");","Same naming concerns, also for ID
+",2016-04-09 14:41:10
+99,"@@ -1783,6 +1783,43 @@ export class OpenResourcesAction extends Action {
+ 	}
+ }
+ 
++export class OpenRecentlyClosedResourcesAction extends Action {
++
++	public static ID = 'workbench.files.action.openRecentlyClosedFile';
++	public static LABEL = nls.localize('openRecentlyClosedFile', ""Open Recently Closed File"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IViewletService private viewletService: IViewletService,
++		@ITextFileService private textFileService: ITextFileService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		return this.partService.joinCreation().then(() => {","You do not need this in most cases, safe to remove the joining.
+",2016-04-09 14:40:51
+101,"@@ -1783,6 +1783,43 @@ export class OpenResourcesAction extends Action {
+ 	}
+ }
+ 
++export class OpenRecentlyClosedResourcesAction extends Action {
++
++	public static ID = 'workbench.files.action.openRecentlyClosedFile';
++	public static LABEL = nls.localize('openRecentlyClosedFile', ""Open Recently Closed File"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IViewletService private viewletService: IViewletService,
++		@ITextFileService private textFileService: ITextFileService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		return this.partService.joinCreation().then(() => {
++			let viewletPromise = TPromise.as(null);
++			if (!this.partService.isSideBarHidden()) {
++				viewletPromise = this.viewletService.openViewlet(Files.VIEWLET_ID, false);
++			}
++
++			return viewletPromise.then(() => {
++				let resource = this.textFileService.getWorkingFilesModel().restoreRecentlyRemovedEntry();
++","I suggest to change this method to something like ""give me the last closed working file"" and then handle everything in this action (add the file back to working files and open it).
+",2016-04-09 14:42:02
+106,"@@ -1783,6 +1783,79 @@ export class OpenResourcesAction extends Action {
+ 	}
+ }
+ 
++export class ReopenClosedFileAction extends Action {
++
++	public static ID = 'workbench.files.action.reopenClosedFile';
++	public static LABEL = nls.localize('reopenClosedFile', ""Reopen Closed File"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IViewletService private viewletService: IViewletService,
++		@ITextFileService private textFileService: ITextFileService,
++		@IFileService private fileService: IFileService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		let viewletPromise = TPromise.as(null);
++		if (!this.partService.isSideBarHidden()) {
++			viewletPromise = this.viewletService.openViewlet(Files.VIEWLET_ID, false);
++		}
++
++		return viewletPromise.then(() => {
++			let workingFilesModel: Files.IWorkingFilesModel = this.textFileService.getWorkingFilesModel();
++			let resources: Files.IWorkingFileEntry[] = workingFilesModel.popLastClosedEntry();","@Tyriar why would this return an array? I would not expect this action to open any more than one file?
+",2016-04-15 06:16:20
+107,"@@ -1783,6 +1783,79 @@ export class OpenResourcesAction extends Action {
+ 	}
+ }
+ 
++export class ReopenClosedFileAction extends Action {
++
++	public static ID = 'workbench.files.action.reopenClosedFile';
++	public static LABEL = nls.localize('reopenClosedFile', ""Reopen Closed File"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IPartService private partService: IPartService,
++		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
++		@IViewletService private viewletService: IViewletService,
++		@ITextFileService private textFileService: ITextFileService,
++		@IFileService private fileService: IFileService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		let viewletPromise = TPromise.as(null);
++		if (!this.partService.isSideBarHidden()) {
++			viewletPromise = this.viewletService.openViewlet(Files.VIEWLET_ID, false);
++		}
++
++		return viewletPromise.then(() => {
++			let workingFilesModel: Files.IWorkingFilesModel = this.textFileService.getWorkingFilesModel();
++			let resources: Files.IWorkingFileEntry[] = workingFilesModel.popLastClosedEntry();
++
++			if (resources === null) {
++				return TPromise.as(true);
++			}
++
++			let resolveFilePromises: TPromise<any>[] = resources.map((r) => { return this.fileService.resolveFile(r.resource); });
++
++			return TPromise.join(resolveFilePromises).then(() => {
++				return this.openEntries(resources, workingFilesModel);
++			}, (e: any[]) => {
++
++				// Don't attempt to reopen files that fail because they no longer exist
++				let exceptions = [];
++				e.forEach(err => {
++					if (err.code === 'ENOENT') {","@Tyriar suggest to use our error constants instead for file operations: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/actions/openSettings.ts#L48
+",2016-04-15 06:17:45
+509,"@@ -1787,12 +1811,14 @@ class InlineViewZonesComputer extends ViewZonesComputer {
+ 	private originalModel: editorCommon.IModel;
+ 	private modifiedEditorConfiguration: editorCommon.InternalEditorOptions;
+ 	private modifiedEditorTabSize: number;
++	private renderIndicator: boolean;
+ 
+-	constructor(lineChanges: editorCommon.ILineChange[], originalForeignVZ: editorCommon.IEditorWhitespace[], modifiedForeignVZ: editorCommon.IEditorWhitespace[], originalEditor: editorBrowser.ICodeEditor, modifiedEditor: editorBrowser.ICodeEditor) {
++	constructor(lineChanges: editorCommon.ILineChange[], originalForeignVZ: editorCommon.IEditorWhitespace[], modifiedForeignVZ: editorCommon.IEditorWhitespace[], originalEditor: editorBrowser.ICodeEditor, modifiedEditor: editorBrowser.ICodeEditor, renderIndicator?: boolean) {",same question,2016-11-23 19:00:15
+880,"@@ -179,296 +211,296 @@ interface IParsedLine {
+ 	placeHolders: IParsedLinePlaceHolderInfo[];
+ }
+ 
+-const InternalFormatSnippetParser = new class implements ISnippetParser {
+-
+-	private _lastGeneratedId: number;
+-	private _snippet: CodeSnippet;
+-
+-	parse(template: string): CodeSnippet {
+-		this._lastGeneratedId = 0;
+-		this._snippet = new CodeSnippet();
+-		this.parseTemplate(template);
+-		return this._snippet;
+-	}
+-
+-	private parseTemplate(template: string): void {
+-
+-		var placeHoldersMap: collections.IStringDictionary<IPlaceHolder> = Object.create(null);
+-		var i: number, len: number, j: number, lenJ: number, templateLines = template.split('\n');
+-
+-		for (i = 0, len = templateLines.length; i < len; i++) {
+-			var parsedLine = this.parseLine(templateLines[i], (id: string) => {
+-				if (placeHoldersMap[id]) {
+-					return placeHoldersMap[id].value;
+-				}
+-				return '';
+-			});
+-			for (j = 0, lenJ = parsedLine.placeHolders.length; j < lenJ; j++) {
+-				var linePlaceHolder = parsedLine.placeHolders[j];
+-				var occurence = new Range(i + 1, linePlaceHolder.startColumn, i + 1, linePlaceHolder.endColumn);
+-				var placeHolder: IPlaceHolder;
+-
+-				if (placeHoldersMap[linePlaceHolder.id]) {
+-					placeHolder = placeHoldersMap[linePlaceHolder.id];
+-				} else {
+-					placeHolder = {
+-						id: linePlaceHolder.id,
+-						value: linePlaceHolder.value,
+-						occurences: []
+-					};
+-					this._snippet.placeHolders.push(placeHolder);
+-					placeHoldersMap[linePlaceHolder.id] = placeHolder;
+-				}
+-
+-				placeHolder.occurences.push(occurence);
+-			}
+-
+-			this._snippet.lines.push(parsedLine.line);
+-		}
+-
+-		// Named variables (e.g. {greeting} and {greeting:Hello}) are sorted first, followed by
+-		// tab-stops and numeric variables (e.g. $1, $2, ${3:foo}) which are sorted in ascending order
+-		this._snippet.placeHolders.sort((a, b) => {
+-			let nonIntegerId = (v: IPlaceHolder) => !(/^\d+$/).test(v.id);
+-			let isFinishPlaceHolder = (v: IPlaceHolder) => v.id === '' && v.value === '';
+-
+-			// Sort finish placeholder last
+-			if (isFinishPlaceHolder(a)) {
+-				return 1;
+-			} else if (isFinishPlaceHolder(b)) {
+-				return -1;
+-			}
+-
+-			// Sort named placeholders first
+-			if (nonIntegerId(a) && nonIntegerId(b)) {
+-				return 0;
+-			} else if (nonIntegerId(a)) {
+-				return -1;
+-			} else if (nonIntegerId(b)) {
+-				return 1;
+-			}
+-
+-			if (a.id === b.id) {
+-				return 0;
+-			}
+-
+-			return Number(a.id) < Number(b.id) ? -1 : 1;
+-		});
+-
+-		if (this._snippet.placeHolders.length > 0 && this._snippet.placeHolders[this._snippet.placeHolders.length - 1].value === '') {
+-			this._snippet.finishPlaceHolderIndex = this._snippet.placeHolders.length - 1;
+-		}
+-	}
+-
+-	private parseLine(line: string, findDefaultValueForIdFromPrevLines: (id: string) => string): IParsedLine {
+-
+-		// Placeholder 0 is the entire line
+-		var placeHolderStack: { placeHolderId: string; placeHolderText: string; }[] = [{ placeHolderId: '', placeHolderText: '' }];
+-		var placeHolders: IParsedLinePlaceHolderInfo[] = [];
+-
+-		const findDefaultValueForId = (id) => {
+-			const result = findDefaultValueForIdFromPrevLines(id);
+-			if (result) {
+-				return result;
+-			}
+-			for (const placeHolder of placeHolders) {
+-				if (placeHolder.id === id && placeHolder.value) {
+-					return placeHolder.value;
+-				}
+-			}
+-			return '';
+-		};
+-
+-		var i = 0;
+-		var len = line.length;
+-		var resultIndex = 0;
+-		while (i < len) {
+-
+-			var restOfLine = line.substr(i);
+-
+-			// Look for the start of a placeholder {{
+-			if (/^{{/.test(restOfLine)) {
+-				i += 2;
+-				placeHolderStack.push({ placeHolderId: '', placeHolderText: '' });
+-
+-				// Look for id
+-				var matches = restOfLine.match(/^{{(\w+):/);
+-				if (Array.isArray(matches) && matches.length === 2) {
+-					placeHolderStack[placeHolderStack.length - 1].placeHolderId = matches[1];
+-					i += matches[1].length + 1; // +1 to account for the : at the end of the id
+-				}
+-
+-				continue;
+-			}
+-
+-			// Look for the end of a placeholder. placeHolderStack[0] is the top-level line.
+-			if (placeHolderStack.length > 1 && /^}}/.test(restOfLine)) {
+-				i += 2;
+-
+-				if (placeHolderStack[placeHolderStack.length - 1].placeHolderId.length === 0) {
+-					// This placeholder did not have an explicit id
+-					placeHolderStack[placeHolderStack.length - 1].placeHolderId = placeHolderStack[placeHolderStack.length - 1].placeHolderText;
+-
+-					if (placeHolderStack[placeHolderStack.length - 1].placeHolderId === '_') {
+-						// This is just an empty tab stop
+-						placeHolderStack[placeHolderStack.length - 1].placeHolderId = 'TAB_STOP_' + String(++this._lastGeneratedId);
+-						placeHolderStack[placeHolderStack.length - 1].placeHolderText = '';
+-						--resultIndex; // Roll back one iteration of the result index as we made the text empty
+-					}
+-				}
+-
+-				if (placeHolderStack[placeHolderStack.length - 1].placeHolderText.length === 0) {
+-					// This placeholder is empty or was a mirror
+-					var defaultValue = findDefaultValueForId(placeHolderStack[placeHolderStack.length - 1].placeHolderId);
+-					placeHolderStack[placeHolderStack.length - 1].placeHolderText = defaultValue;
+-					resultIndex += defaultValue.length;
+-				}
+-
+-				placeHolders.push({
+-					id: placeHolderStack[placeHolderStack.length - 1].placeHolderId,
+-					value: placeHolderStack[placeHolderStack.length - 1].placeHolderText,
+-					startColumn: resultIndex + 1 - placeHolderStack[placeHolderStack.length - 1].placeHolderText.length,
+-					endColumn: resultIndex + 1
+-				});
+-
+-				// Insert our text into the previous placeholder
+-				placeHolderStack[placeHolderStack.length - 2].placeHolderText += placeHolderStack[placeHolderStack.length - 1].placeHolderText;
+-				placeHolderStack.pop();
+-				continue;
+-			}
+-
+-			// Look for escapes
+-			if (/^\\./.test(restOfLine)) {
+-				if (restOfLine.charAt(1) === '{' || restOfLine.charAt(1) === '}' || restOfLine.charAt(1) === '\\') {
+-					++i; // Skip the escape slash and take the character literally
+-				} else {
+-					// invalid escapes
+-					placeHolderStack[placeHolderStack.length - 1].placeHolderText += line.charAt(i);
+-					++resultIndex;
+-					++i;
+-				}
+-			}
+-
+-			//This is an escape sequence or not a special character, just insert it
+-			placeHolderStack[placeHolderStack.length - 1].placeHolderText += line.charAt(i);
+-			++resultIndex;
+-			++i;
+-		}
+-
+-		// Sort the placeholder in order of apperance:
+-		placeHolders.sort((a, b) => {
+-			if (a.startColumn < b.startColumn) {
+-				return -1;
+-			}
+-			if (a.startColumn > b.startColumn) {
+-				return 1;
+-			}
+-			if (a.endColumn < b.endColumn) {
+-				return -1;
+-			}
+-			if (a.endColumn > b.endColumn) {
+-				return 1;
+-			}
+-			return 0;
+-		});
+-
+-		return {
+-			line: placeHolderStack[0].placeHolderText,
+-			placeHolders: placeHolders
+-		};
+-	}
+-};
+-
+-const EmmetSnippetParser = new class implements ISnippetParser {
+-
+-	parse(template: string): CodeSnippet {
+-		template = _convertExternalSnippet(template, ExternalSnippetType.EmmetSnippet);
+-		return InternalFormatSnippetParser.parse(template);
+-	}
+-};
+-
+-export enum ExternalSnippetType {
+-	TextMateSnippet,
+-	EmmetSnippet
+-}
+-
+-// This is used for both TextMate and Emmet
+-function _convertExternalSnippet(snippet: string, snippetType: ExternalSnippetType): string {
+-	var openBraces = 0;
+-	var convertedSnippet = '';
+-	var i = 0;
+-	var len = snippet.length;
+-
+-	while (i < len) {
+-		var restOfLine = snippet.substr(i);
+-
+-		// Cursor tab stop
+-		if (/^\$0/.test(restOfLine)) {
+-			i += 2;
+-			convertedSnippet += snippetType === ExternalSnippetType.EmmetSnippet ? '{{_}}' : '{{}}';
+-			continue;
+-		}
+-		if (/^\$\{0\}/.test(restOfLine)) {
+-			i += 4;
+-			convertedSnippet += snippetType === ExternalSnippetType.EmmetSnippet ? '{{_}}' : '{{}}';
+-			continue;
+-		}
+-
+-		// Tab stops
+-		var matches = restOfLine.match(/^\$(\d+)/);
+-		if (Array.isArray(matches) && matches.length === 2) {
+-			i += 1 + matches[1].length;
+-			convertedSnippet += '{{' + matches[1] + ':}}';
+-			continue;
+-		}
+-		matches = restOfLine.match(/^\$\{(\d+)\}/);
+-		if (Array.isArray(matches) && matches.length === 2) {
+-			i += 3 + matches[1].length;
+-			convertedSnippet += '{{' + matches[1] + ':}}';
+-			continue;
+-		}
+-
+-		// Open brace patterns placeholder
+-		if (/^\${/.test(restOfLine)) {
+-			i += 2;
+-			++openBraces;
+-			convertedSnippet += '{{';
+-			continue;
+-		}
+-
+-		// Close brace patterns placeholder
+-		if (openBraces > 0 && /^}/.test(restOfLine)) {
+-			i += 1;
+-			--openBraces;
+-			convertedSnippet += '}}';
+-			continue;
+-		}
+-
+-		// Escapes
+-		if (/^\\./.test(restOfLine)) {
+-			i += 2;
+-			if (/^\\\$/.test(restOfLine)) {
+-				convertedSnippet += '$';
+-			} else {
+-				convertedSnippet += restOfLine.substr(0, 2);
+-			}
+-			continue;
+-		}
+-
+-		// Escape braces that don't belong to a placeholder
+-		matches = restOfLine.match(/^({|})/);
+-		if (Array.isArray(matches) && matches.length === 2) {
+-			i += 1;
+-			convertedSnippet += '\\' + matches[1];
+-			continue;
+-		}
+-
+-		i += 1;
+-		convertedSnippet += restOfLine.charAt(0);
+-	}
+-
+-	return convertedSnippet;
+-};
++// const InternalFormatSnippetParser = new class implements ISnippetParser {","we use source control, no reason to push commented code ;-)",2017-04-14 07:36:36
+593,"@@ -18,15 +18,25 @@ class MyCompletionItem extends CompletionItem {
+ 	document: TextDocument;
+ 	position: Position;
+ 
+-	constructor(entry: CompletionEntry) {
++	constructor(position: Position, document: TextDocument, entry: CompletionEntry) {
+ 		super(entry.name);
+ 		this.sortText = entry.sortText;
+ 		this.kind = MyCompletionItem.convertKind(entry.kind);
++		this.position = position;
++		this.document = document;
+ 		if (entry.replacementSpan) {
+ 			let span: protocol.TextSpan = entry.replacementSpan;
+ 			// The indexing for the range returned by the server uses 1-based indexing.
+ 			// We convert to 0-based indexing.
+ 			this.textEdit = TextEdit.replace(new Range(span.start.line - 1, span.start.offset - 1, span.end.line - 1, span.end.offset - 1), entry.name);
++		} else {
++			const text = document.getText(new Range(position.line, Math.max(0, position.character - entry.name.length), position.line, position.character));","This assume that the replacement text will always start with the replaced text. @dbaeumer is this a safe assumption to make. It worked in all cases in my testing, but we may want to scope the fix by only applying it to certain kinds of completion entries",2016-12-09 01:10:03
+49,"@@ -18,7 +18,10 @@ import {IContextViewService} from 'vs/platform/contextview/browser/contextView';
+ import {IEventService} from 'vs/platform/event/common/event';
+ 
+ const DEFAULT_MIN_PART_WIDTH = 170;
++const DEFAULT_MIN_PANEL_PART_HEIGHT = 170;
+ const HIDE_SIDEBAR_WIDTH_THRESHOLD = 50;
++const HIDE_PANEL_HEIGHT_THRESHOLD = 50;","@isidorn is this (HIDE_PANEL_HEIGHT_THRESHOLD) used at all? I think we can let it hide when you make it small and treat the fact that you cannot size it back as a bug for the future :)
+",2016-01-19 10:46:09
+754,"@@ -18,7 +18,6 @@ import { ICodeEditor, IOverlayWidget, IOverlayWidgetPosition, IViewZone, IViewZo
+ export interface IOptions {
+ 	showFrame?: boolean;","Make sure that references widget, peek view widget, error list widget and breakpoint widget are rendered the same as before.",2017-02-20 14:08:36
+92,"@@ -180,6 +180,10 @@ export class ExplorerViewlet extends Viewlet {
+ 		return this.actionRunner;
+ 	}
+ 
++	public getOptimalWidth(): number {
++		return this.getExplorerView().getOptimalWidth();
++	}
++","You need to take the working files view into account too. Note that explorer view can be different when you open no workspace (no folder).
+",2016-03-30 05:25:37
+356,"@@ -180,6 +180,13 @@ export interface IEditorOptions {
+ 	pinned?: boolean;
+ 
+ 	/**
++	 * Editor that is being shown with an `forcePreview` will override the `enablePreview` setting
++	 * of the workspace configuration to allow the editor to be shown as a preview editor while
++	 * selecting in the quick open widgets.
++	 */
++	forcePreview?: boolean;","@wprater this is good but the comment should not mention quick open scenario, I think its a valid override in any case, there may be more.
+",2016-10-21 09:46:22
+39,"@@ -182,363 +139,28 @@ export class SidebarPart extends Part implements IViewletService {
+ 		});
+ 	}
+ 
+-	private createViewlet(id: string, isActive?: boolean): TPromise<Viewlet> {
+-
+-		// Check if viewlet is already created
+-		for (let i = 0; i < this.instantiatedViewlets.length; i++) {
+-			if (this.instantiatedViewlets[i].getId() === id) {
+-				return TPromise.as(this.instantiatedViewlets[i]);
+-			}
+-		}
+-
+-		// Instantiate viewlet from registry otherwise
+-		let viewletDescriptor = this.registry.getViewlet(id);
+-		if (viewletDescriptor) {
+-			let loaderPromise = this.viewletLoaderPromises[id];
+-			if (!loaderPromise) {
+-				let progressService = new WorkbenchProgressService(this.eventService, this.progressBar, viewletDescriptor.id, isActive);
+-				let services = {
+-					progressService: progressService
+-				};
+-				let viewletInstantiationService = this.instantiationService.createChild(services);
+-
+-				loaderPromise = viewletInstantiationService.createInstance(viewletDescriptor).then((viewlet: Viewlet) => {
+-					this.mapProgressServiceToViewlet[viewlet.getId()] = progressService;
+-
+-					// Remember as Instantiated
+-					this.instantiatedViewlets.push(viewlet);
+-
+-					// Register to title area update events from the viewlet
+-					this.instantiatedViewletListeners.push(viewlet.addListener(ViewletEventType.INTERNAL_VIEWLET_TITLE_AREA_UPDATE, (e) => { this.onTitleAreaUpdate(e); }));
+-
+-					// Remove from Promises Cache since Loaded
+-					delete this.viewletLoaderPromises[id];
+-
+-					return viewlet;
+-				});
+-
+-				// Report progress for slow loading viewlets
+-				progressService.showWhile(loaderPromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
+-
+-				// Add to Promise Cache until Loaded
+-				this.viewletLoaderPromises[id] = loaderPromise;
+-			}
+-
+-			return loaderPromise;
+-		}
+-
+-		throw new Error(strings.format('Unable to find viewlet with id {0}', id));
+-	}
+-
+-	private showViewlet(viewlet: Viewlet): TPromise<void> {
+-
+-		// Remember Viewlet
+-		this.activeViewlet = viewlet;
+-
+-		// Store in preferences
+-		this.storageService.store(SidebarPart.activeViewletSettingsKey, this.activeViewlet.getId(), StorageScope.WORKSPACE);
+-
+-		// Remember
+-		this.lastActiveViewletId = this.activeViewlet.getId();
+-
+-		// Register as Emitter to Workbench Bus
+-		this.activeViewletListeners.push(this.eventService.addEmitter(this.activeViewlet, this.activeViewlet.getId()));
+-
+-		let createViewletPromise: TPromise<void>;
+-
+-		// Viewlet created for the first time
+-		let viewletContainer = this.mapViewletToViewletContainer[viewlet.getId()];
+-		if (!viewletContainer) {
+-
+-			// Build Container off-DOM
+-			viewletContainer = $().div({
+-				'class': 'viewlet',
+-				id: viewlet.getId()
+-			}, (div: Builder) => {
+-				createViewletPromise = viewlet.create(div);
+-			});
+-
+-			// Remember viewlet container
+-			this.mapViewletToViewletContainer[viewlet.getId()] = viewletContainer;
+-		}
+-
+-		// Viewlet already exists but is hidden
+-		else {
+-			createViewletPromise = TPromise.as(null);
+-		}
+-
+-		// Report progress for slow loading viewlets (but only if we did not create the viewlet before already)
+-		let progressService = this.mapProgressServiceToViewlet[viewlet.getId()];
+-		if (progressService && !viewletContainer) {
+-			this.mapProgressServiceToViewlet[viewlet.getId()].showWhile(createViewletPromise, this.partService.isCreated() ? 800 : 3200 /* less ugly initial startup */);
+-		}
+-
+-		// Fill Content and Actions
+-		return createViewletPromise.then(() => {
+-
+-			// Make sure that the user meanwhile did not open another viewlet or closed the sidebar
+-			if (!this.activeViewlet || viewlet.getId() !== this.activeViewlet.getId()) {
+-				return;
+-			}
+-
+-			// Take Viewlet on-DOM and show
+-			viewletContainer.build(this.getContentArea());
+-			viewletContainer.show();
+-
+-			// Setup action runner
+-			this.toolBar.actionRunner = viewlet.getActionRunner();
+-
+-			// Update title with viewlet title if it differs from descriptor
+-			let descriptor = this.registry.getViewlet(viewlet.getId());
+-			if (descriptor && descriptor.name !== viewlet.getTitle()) {
+-				this.updateTitle(viewlet.getId(), viewlet.getTitle());
+-			}
+-
+-			// Handle Viewlet Actions
+-			let actionsBinding = this.mapActionsBindingToViewlet[viewlet.getId()];
+-			if (!actionsBinding) {
+-				actionsBinding = this.collectViewletActions(viewlet);
+-				this.mapActionsBindingToViewlet[viewlet.getId()] = actionsBinding;
+-			}
+-			actionsBinding();
+-
+-			if (this.telemetryActionsListener) {
+-				this.telemetryActionsListener.dispose();
+-				this.telemetryActionsListener = null;
+-			}
+-
+-			// Action Run Handling
+-			this.telemetryActionsListener = this.toolBar.actionRunner.addListener2(events.EventType.RUN, (e: any) => {
+-
+-				// Check for Error
+-				if (e.error && !errors.isPromiseCanceledError(e.error)) {
+-					this.messageService.show(Severity.Error, e.error);
+-				}
+-
+-				// Log in telemetry
+-				if (this.telemetryService) {
+-					this.telemetryService.publicLog('workbenchActionExecuted', { id: e.action.id, from: 'sideBar' });
+-				}
+-			});
+-
+-			// Indicate to viewlet that it is now visible
+-			return viewlet.setVisible(true).then(() => {
+-
+-				// Make sure that the user meanwhile did not open another viewlet or closed the sidebar
+-				if (!this.activeViewlet || viewlet.getId() !== this.activeViewlet.getId()) {
+-					return;
+-				}
+-
+-				// Make sure the viewlet is layed out
+-				if (this.contentAreaSize) {
+-					viewlet.layout(this.contentAreaSize);
+-				}
+-
+-				// Emit Viewlet Opened Event
+-				this.emit(WorkbenchEventType.VIEWLET_OPENED, new ViewletEvent(this.activeViewlet.getId()));
+-			});
+-		}, (error: any) => this.onError(error));
++	private get activeViewlet(): IViewlet {
++		return this.getActiveViewlet();
+ 	}
+ 
+-	private onTitleAreaUpdate(e: ViewletEvent): void {
+-
+-		// Active Viewlet
+-		if (this.activeViewlet && this.activeViewlet.getId() === e.viewletId) {
+-
+-			// Title
+-			this.updateTitle(this.activeViewlet.getId(), this.activeViewlet.getTitle());
+-
+-			// Actions
+-			let actionsBinding = this.collectViewletActions(this.activeViewlet);
+-			this.mapActionsBindingToViewlet[this.activeViewlet.getId()] = actionsBinding;
+-			actionsBinding();
+-		}
+-
+-		// Otherwise invalidate actions binding for next time when the viewlet becomes visible
+-		else {
+-			delete this.mapActionsBindingToViewlet[e.viewletId];
+-		}
+-	}
+-
+-	private updateTitle(viewletId: string, viewletTitle?: string): void {
+-		let viewletDescriptor = this.registry.getViewlet(viewletId);
+-		if (!viewletDescriptor) {
+-			return;
+-		}
+-
+-		if (!viewletTitle) {
+-			viewletTitle = viewletDescriptor.name;
+-		}
+-
+-		let keybinding: string = null;
+-		let keys = this.keybindingService.lookupKeybindings(viewletId).map(k => this.keybindingService.getLabelFor(k));
+-		if (keys && keys.length) {
+-			keybinding = keys[0];
+-		}
+-
+-		this.titleLabel.safeInnerHtml(viewletTitle);
+-		this.titleLabel.title(keybinding ? nls.localize('viewletTitleTooltip', ""{0} ({1})"", viewletTitle, keybinding) : viewletTitle);
++	private createViewlet(id: string, isActive?: boolean): TPromise<Viewlet> {","Similar to panelPart, I think more can be pushed down to compositePart.
+",2016-01-15 15:12:50
+538,"@@ -182,7 +183,7 @@ export abstract class KeybindingService implements IKeybindingService {
+ 				e.preventDefault();
+ 			}
+ 			let commandId = resolveResult.commandId.replace(/^\^/, '');
+-			this._commandService.executeCommand(commandId, resolveResult.commandArgs || {}).done(undefined, err => {
++			this._commandService.executeCommand(commandId, objects.assign({ from: 'keybinding' }, resolveResult.commandArgs || {})).done(undefined, err => {",Not sure if copying the arguments object is save here. What are the cases that come into play?,2016-11-30 05:47:39
+518,"@@ -183,19 +193,104 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 	}
+ 
+ 	private onFocusStackFrame(stackFrame: IStackFrame): void {
+-		if (!stackFrame || stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
++		// TODO: onFocusStackFrame isn't called for the first time when editor url changes due to source mapping
++		//console.log(""onFocusStackFrame"", this.editor.getModel().uri.toString(), this.editor.getModel().uri.toString(), stackFrame);
++
++		if (!stackFrame || stackFrame && stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {",If the stackFrame is false the other part of this expression will not be evaluted so the other stackFrame truthfulness check is not needed,2016-11-28 10:28:48
+519,"@@ -183,19 +193,104 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 	}
+ 
+ 	private onFocusStackFrame(stackFrame: IStackFrame): void {
+-		if (!stackFrame || stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
++		// TODO: onFocusStackFrame isn't called for the first time when editor url changes due to source mapping
++		//console.log(""onFocusStackFrame"", this.editor.getModel().uri.toString(), this.editor.getModel().uri.toString(), stackFrame);
++
++		if (!stackFrame || stackFrame && stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
+ 			// clear all inline value decorations in this editor
++			this.editor.removeDecorations(INLINE_DECORATOR_KEY);
+ 			return;
+ 		}
+ 
+-		// Compute all inline value decorations for this editor
+-		// 1. Find all the words in this document (in the future improve to only look inside ranges for top scope). Editor has nice api for this
+-		// 2. All words found should be compared against a children of all non expenisve scopes (good pointer for this is debugHover.ts)
+-		// 2b. If there seems to be a lot of duplication between here and debugHover we should consider to move this variable searching method inside a stack frame
+-		// 3. Words found in the variables map should be added as decorations on correct locations
+-		// 4. Nicely style decorations
++		stackFrame.getScopes()
++			// Get all top level children in the scope chain
++			.then(scopes => TPromise.join(scopes.map(scope => scope.getChildren())))
++			.then(children => {
++				// Compute name-value map for all variables in scope chain
++				const nameValueMap = this.computeNameValueMapFromScopeChildren(children);
++				// Compute inline contentText for decorators from nameValueMap
++				const linesContent = this.editor.getModel().getLinesContent();
++				const linesDecoratorText = this.computeLinesDecoratorTextFromNameValueMap(nameValueMap, linesContent);
++				// Apply decorators for each line
++				this.setInlineDecoratorsFromLinesDecoratorText(linesDecoratorText, linesContent);
++			});
++	}
++",Two dimensional expression array is ugly - maybe we first merge children across scopes so we get an 1 dimensional array,2016-11-28 10:29:37
+520,"@@ -183,19 +193,104 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 	}
+ 
+ 	private onFocusStackFrame(stackFrame: IStackFrame): void {
+-		if (!stackFrame || stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
++		// TODO: onFocusStackFrame isn't called for the first time when editor url changes due to source mapping
++		//console.log(""onFocusStackFrame"", this.editor.getModel().uri.toString(), this.editor.getModel().uri.toString(), stackFrame);
++
++		if (!stackFrame || stackFrame && stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
+ 			// clear all inline value decorations in this editor
++			this.editor.removeDecorations(INLINE_DECORATOR_KEY);
+ 			return;
+ 		}
+ 
+-		// Compute all inline value decorations for this editor
+-		// 1. Find all the words in this document (in the future improve to only look inside ranges for top scope). Editor has nice api for this
+-		// 2. All words found should be compared against a children of all non expenisve scopes (good pointer for this is debugHover.ts)
+-		// 2b. If there seems to be a lot of duplication between here and debugHover we should consider to move this variable searching method inside a stack frame
+-		// 3. Words found in the variables map should be added as decorations on correct locations
+-		// 4. Nicely style decorations
++		stackFrame.getScopes()
++			// Get all top level children in the scope chain
++			.then(scopes => TPromise.join(scopes.map(scope => scope.getChildren())))
++			.then(children => {
++				// Compute name-value map for all variables in scope chain
++				const nameValueMap = this.computeNameValueMapFromScopeChildren(children);
++				// Compute inline contentText for decorators from nameValueMap
++				const linesContent = this.editor.getModel().getLinesContent();
++				const linesDecoratorText = this.computeLinesDecoratorTextFromNameValueMap(nameValueMap, linesContent);
++				// Apply decorators for each line
++				this.setInlineDecoratorsFromLinesDecoratorText(linesDecoratorText, linesContent);
++			});
++	}
++
++	private computeNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): { [name: string]: string } {
++		const nameValueMap: { [name: string]: string } = {};
++		let valueCount = 0;
++
++		for (let expressions of scopeExpressions) {
++			for (let expr of expressions) {
++				// Put ellipses in value if its too long. Preserve last char e.g ""longstr…"" or {a:true, b:true, …}
++				let value = expr.value;
++				if (value && value.length > MAX_INLINE_VALUE_LENGTH) {
++					value = value.substr(0, MAX_INLINE_VALUE_LENGTH - ELLIPSES.length) + ELLIPSES + value[value.length - 1];","I woudl just inline the ELLIPSES it is only used here.
+Also consider using the unicode elipses character, might look nicer",2016-11-28 10:31:10
+521,"@@ -183,19 +193,104 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 	}
+ 
+ 	private onFocusStackFrame(stackFrame: IStackFrame): void {
+-		if (!stackFrame || stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
++		// TODO: onFocusStackFrame isn't called for the first time when editor url changes due to source mapping
++		//console.log(""onFocusStackFrame"", this.editor.getModel().uri.toString(), this.editor.getModel().uri.toString(), stackFrame);
++
++		if (!stackFrame || stackFrame && stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
+ 			// clear all inline value decorations in this editor
++			this.editor.removeDecorations(INLINE_DECORATOR_KEY);
+ 			return;
+ 		}
+ 
+-		// Compute all inline value decorations for this editor
+-		// 1. Find all the words in this document (in the future improve to only look inside ranges for top scope). Editor has nice api for this
+-		// 2. All words found should be compared against a children of all non expenisve scopes (good pointer for this is debugHover.ts)
+-		// 2b. If there seems to be a lot of duplication between here and debugHover we should consider to move this variable searching method inside a stack frame
+-		// 3. Words found in the variables map should be added as decorations on correct locations
+-		// 4. Nicely style decorations
++		stackFrame.getScopes()
++			// Get all top level children in the scope chain
++			.then(scopes => TPromise.join(scopes.map(scope => scope.getChildren())))
++			.then(children => {
++				// Compute name-value map for all variables in scope chain
++				const nameValueMap = this.computeNameValueMapFromScopeChildren(children);
++				// Compute inline contentText for decorators from nameValueMap
++				const linesContent = this.editor.getModel().getLinesContent();
++				const linesDecoratorText = this.computeLinesDecoratorTextFromNameValueMap(nameValueMap, linesContent);
++				// Apply decorators for each line
++				this.setInlineDecoratorsFromLinesDecoratorText(linesDecoratorText, linesContent);
++			});
++	}
++
++	private computeNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): { [name: string]: string } {
++		const nameValueMap: { [name: string]: string } = {};
++		let valueCount = 0;
++
++		for (let expressions of scopeExpressions) {
++			for (let expr of expressions) {
++				// Put ellipses in value if its too long. Preserve last char e.g ""longstr…"" or {a:true, b:true, …}
++				let value = expr.value;
++				if (value && value.length > MAX_INLINE_VALUE_LENGTH) {
++					value = value.substr(0, MAX_INLINE_VALUE_LENGTH - ELLIPSES.length) + ELLIPSES + value[value.length - 1];
++				}
++
++				nameValueMap[expr.name] = value;
++
++				// Limit the size of map. Too large can have a perf impact",I would not bother with limiting the size of the map for now. We can easily add perf limits later,2016-11-28 10:36:04
+516,"@@ -183,19 +193,104 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 	}
+ 
+ 	private onFocusStackFrame(stackFrame: IStackFrame): void {
+-		if (!stackFrame || stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
++		// TODO: onFocusStackFrame isn't called for the first time when editor url changes due to source mapping
++		//console.log(""onFocusStackFrame"", this.editor.getModel().uri.toString(), this.editor.getModel().uri.toString(), stackFrame);
++
++		if (!stackFrame || stackFrame && stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
+ 			// clear all inline value decorations in this editor
++			this.editor.removeDecorations(INLINE_DECORATOR_KEY);
+ 			return;
+ 		}
+ 
+-		// Compute all inline value decorations for this editor
+-		// 1. Find all the words in this document (in the future improve to only look inside ranges for top scope). Editor has nice api for this
+-		// 2. All words found should be compared against a children of all non expenisve scopes (good pointer for this is debugHover.ts)
+-		// 2b. If there seems to be a lot of duplication between here and debugHover we should consider to move this variable searching method inside a stack frame
+-		// 3. Words found in the variables map should be added as decorations on correct locations
+-		// 4. Nicely style decorations
++		stackFrame.getScopes()
++			// Get all top level children in the scope chain
++			.then(scopes => TPromise.join(scopes.map(scope => scope.getChildren())))
++			.then(children => {
++				// Compute name-value map for all variables in scope chain
++				const nameValueMap = this.computeNameValueMapFromScopeChildren(children);
++				// Compute inline contentText for decorators from nameValueMap
++				const linesContent = this.editor.getModel().getLinesContent();
++				const linesDecoratorText = this.computeLinesDecoratorTextFromNameValueMap(nameValueMap, linesContent);
++				// Apply decorators for each line
++				this.setInlineDecoratorsFromLinesDecoratorText(linesDecoratorText, linesContent);
++			});
++	}
++
++	private computeNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): { [name: string]: string } {
++		const nameValueMap: { [name: string]: string } = {};
++		let valueCount = 0;
++
++		for (let expressions of scopeExpressions) {
++			for (let expr of expressions) {
++				// Put ellipses in value if its too long. Preserve last char e.g ""longstr…"" or {a:true, b:true, …}
++				let value = expr.value;
++				if (value && value.length > MAX_INLINE_VALUE_LENGTH) {
++					value = value.substr(0, MAX_INLINE_VALUE_LENGTH - ELLIPSES.length) + ELLIPSES + value[value.length - 1];
++				}
++
++				nameValueMap[expr.name] = value;
++
++				// Limit the size of map. Too large can have a perf impact
++				if (valueCount++ >= MAX_NUM_INLINE_VALUES) {
++					break;
++				}
++			}
++		}
++
++		return nameValueMap;
++	}
++
++	private computeLinesDecoratorTextFromNameValueMap(nameValueMap: { [name: string]: string }, linesContent: string[]): string[] {
++		// Compose a single regex that matches any of the names as a whole word
++		// Single regex is much faster than multiple string matches
++		// TODO: This step could be optimized if we already have a pre-computed variableName to ranges map for editor",Agree that this could be optimized as we do not need to compute all the words on each step. We just need to recompute them on editor model changed event.,2016-11-28 10:25:34
+522,"@@ -183,19 +193,104 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 	}
+ 
+ 	private onFocusStackFrame(stackFrame: IStackFrame): void {
+-		if (!stackFrame || stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
++		// TODO: onFocusStackFrame isn't called for the first time when editor url changes due to source mapping
++		//console.log(""onFocusStackFrame"", this.editor.getModel().uri.toString(), this.editor.getModel().uri.toString(), stackFrame);
++
++		if (!stackFrame || stackFrame && stackFrame.source.uri.toString() !== this.editor.getModel().uri.toString()) {
+ 			// clear all inline value decorations in this editor
++			this.editor.removeDecorations(INLINE_DECORATOR_KEY);
+ 			return;
+ 		}
+ 
+-		// Compute all inline value decorations for this editor
+-		// 1. Find all the words in this document (in the future improve to only look inside ranges for top scope). Editor has nice api for this
+-		// 2. All words found should be compared against a children of all non expenisve scopes (good pointer for this is debugHover.ts)
+-		// 2b. If there seems to be a lot of duplication between here and debugHover we should consider to move this variable searching method inside a stack frame
+-		// 3. Words found in the variables map should be added as decorations on correct locations
+-		// 4. Nicely style decorations
++		stackFrame.getScopes()
++			// Get all top level children in the scope chain
++			.then(scopes => TPromise.join(scopes.map(scope => scope.getChildren())))
++			.then(children => {
++				// Compute name-value map for all variables in scope chain
++				const nameValueMap = this.computeNameValueMapFromScopeChildren(children);
++				// Compute inline contentText for decorators from nameValueMap
++				const linesContent = this.editor.getModel().getLinesContent();
++				const linesDecoratorText = this.computeLinesDecoratorTextFromNameValueMap(nameValueMap, linesContent);
++				// Apply decorators for each line
++				this.setInlineDecoratorsFromLinesDecoratorText(linesDecoratorText, linesContent);
++			});
++	}
++
++	private computeNameValueMapFromScopeChildren(scopeExpressions: IExpression[][]): { [name: string]: string } {
++		const nameValueMap: { [name: string]: string } = {};
++		let valueCount = 0;
++
++		for (let expressions of scopeExpressions) {
++			for (let expr of expressions) {
++				// Put ellipses in value if its too long. Preserve last char e.g ""longstr…"" or {a:true, b:true, …}
++				let value = expr.value;
++				if (value && value.length > MAX_INLINE_VALUE_LENGTH) {
++					value = value.substr(0, MAX_INLINE_VALUE_LENGTH - ELLIPSES.length) + ELLIPSES + value[value.length - 1];
++				}
++
++				nameValueMap[expr.name] = value;
++
++				// Limit the size of map. Too large can have a perf impact
++				if (valueCount++ >= MAX_NUM_INLINE_VALUES) {
++					break;
++				}
++			}
++		}
++
++		return nameValueMap;
++	}
++
++	private computeLinesDecoratorTextFromNameValueMap(nameValueMap: { [name: string]: string }, linesContent: string[]): string[] {
++		// Compose a single regex that matches any of the names as a whole word
++		// Single regex is much faster than multiple string matches
++		// TODO: This step could be optimized if we already have a pre-computed variableName to ranges map for editor
++		const namesRegex = new RegExp(`\\b(${Object.keys(nameValueMap).join('|')})\\b`, 'g');
++
++		// For every line, get list of names that exist in that line.
++		const linesNames = linesContent.map(content => content.match(namesRegex));
++
++		// Compute text that will be shown after each line as decorators
++		return linesNames.map((names) => {",First filter then map so we do not have falsy elements in the array. Thus you would not need the falsy check on line 272 in setInlineDecoratorfFromLinesDecoratorText,2016-11-28 10:38:34
+457,"@@ -184,7 +192,11 @@ export class GotoLineHandler extends QuickOpenHandler {
+ 			this.lastKnownEditorViewState = (<IEditor>editor.getControl()).saveViewState();
+ 		}
+ 
+-		return TPromise.as(new QuickOpenModel([new GotoLineEntry(searchValue, this.editorService, this)]));
++		const entry = this.instantiationService.createInstance(","@wprater you do not need to pass in the services, just do: `this.instantiationService.createInstance(GotoLineEntry, searchValue)`
+
+All services will be passed in automatically.
+",2016-11-05 07:41:05
+959,"@@ -184,8 +185,35 @@ export class ReferencesController implements editorCommon.IEditorContribution {
+ 				return undefined;
+ 			});
+ 
++		};
++
++		let firstUpdate = true;
++		const aggregatedLocations: Location[] = [];
++		const promise = modelPromise.then(result => {
++			if (result instanceof ReferencesModel) {
++				return handleModel(result);
++			}
++			// All results should have been received via progress.
++			alert(this._model.getAriaMessage());",do this in a `.then` instead,2017-06-05 22:48:24
+374,"@@ -187,33 +190,14 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
+ 			this.configurationChangeListener = null;
+ 		}
+ 
++		this._onDidChangeContent.dispose();
+ 		this._onDidChangeDirty.dispose();
+ 		this._onDidChangeEncoding.dispose();
+ 
+ 		this.cancelBackupPromises();
+-		this.fileService.discardBackup(this.resource);
+-	}
+-
+-	public backup(): TPromise<void> {
+-		return this.doBackup(true);
+-	}
+-
+-	private doBackup(immediate?: boolean): TPromise<void> {
+-		// Cancel any currently running backups to make this the one that succeeds
+-		this.cancelBackupPromises();
+-
+-		if (immediate) {
+-			return this.fileService.backupFile(this.resource, this.getValue()).then(f => void 0);
+-		}
+-
+-		// Create new backup promise and keep it
+-		const promise = TPromise.timeout(1000).then(() => {
+-			this.fileService.backupFile(this.resource, this.getValue()); // Very important here to not return the promise because if the timeout promise is canceled it will bubble up the error otherwise - do not change
+-		});
+-
+-		this.backupPromises.push(promise);
+ 
+-		return promise;
++		// TODO: Introduce an event on IUntitledEditorService so this can be moved to BackupModelService?","Yes, please!
+",2016-10-21 14:03:04
+886,"@@ -188,12 +238,65 @@ export class TerminalLinkHandler {
+ 			return TPromise.as(void 0);
+ 		}
+ 
++		const linkUrl = this.extractLinkUrl(link);
+ 		// Open an editor if the path exists
+-		return pfs.fileExists(link).then(isFile => {
++		return pfs.fileExists(linkUrl).then(isFile => {
+ 			if (!isFile) {
+ 				return null;
+ 			}
+ 			return link;
+ 		});
+ 	}
++
++	/**
++	 * Returns line and column number of URl if that is present.
++	 *
++	 * @param link Url link which may contain line and column number.
++	 */
++	public extractLineColumnInfo(link: string): LineColumnInfo {
++		const matches: string[] = this._localLinkRegex.exec(link);
++
++		let lineColumnClauseLength = this._lineAndColumnClauses.length;
++		let lineColumnInfo: LineColumnInfo = {};
++
++		let lineAndColumnMatchIndex = this._winLineAndColumnMatchIndex;
++
++		if (platform.Platform.Windows !== this._platform) {",Can you swap the if? Normally we put the constant expression on the right: `this._platform !== platform.Platform.Windows`,2017-04-17 17:41:45
+887,"@@ -188,12 +238,65 @@ export class TerminalLinkHandler {
+ 			return TPromise.as(void 0);
+ 		}
+ 
++		const linkUrl = this.extractLinkUrl(link);
+ 		// Open an editor if the path exists
+-		return pfs.fileExists(link).then(isFile => {
++		return pfs.fileExists(linkUrl).then(isFile => {
+ 			if (!isFile) {
+ 				return null;
+ 			}
+ 			return link;
+ 		});
+ 	}
++
++	/**
++	 * Returns line and column number of URl if that is present.
++	 *
++	 * @param link Url link which may contain line and column number.
++	 */
++	public extractLineColumnInfo(link: string): LineColumnInfo {
++		const matches: string[] = this._localLinkRegex.exec(link);
++
++		let lineColumnClauseLength = this._lineAndColumnClauses.length;
++		let lineColumnInfo: LineColumnInfo = {};
++
++		let lineAndColumnMatchIndex = this._winLineAndColumnMatchIndex;
++
++		if (platform.Platform.Windows !== this._platform) {
++			lineAndColumnMatchIndex = this._unixLineAndColumnMatchIndex;
++		}
++
++		for (let i = 0; i < lineColumnClauseLength; i++) {
++			let lineMatchIndex = lineAndColumnMatchIndex + 6 * i;",What's 6?,2017-04-17 17:41:53
+70,"@@ -189,6 +189,10 @@ export class BaseDebugController extends treedefaults.DefaultController {
+ ","Looks good.
+",2016-03-16 10:21:00
+114,"@@ -19,6 +19,40 @@ import {ITerminalService} from 'vs/workbench/parts/execution/common/execution';
+ import {SyncActionDescriptor} from 'vs/platform/actions/common/actions';
+ import {IInstantiationService} from 'vs/platform/instantiation/common/instantiation';
+ import {KeyMod, KeyCode} from 'vs/base/common/keyCodes';
++import {Extensions, IConfigurationRegistry} from 'vs/platform/configuration/common/configurationRegistry';
++import {defaultWindowsTerm, defaultLinuxTerm} from 'vs/workbench/parts/execution/common/terminal';
++
++let configurationRegistry = <IConfigurationRegistry>Registry.as(Extensions.Configuration);
++configurationRegistry.registerConfiguration({
++	'id': 'terminal',
++	'order': 100,
++	'title': nls.localize('terminalConfigurationTitle', ""Terminal configuration""),
++	'type': 'object',
++	'properties': {
++		'terminal.windows': {
++			'description': nls.localize('terminal.windows', ""Windows specific settings.""),
++			'type': 'object',
++			'properties': {
++				'exec': {
++					'type': 'string',
++					'description': nls.localize('terminal.windows.exec', ""Customizes which terminal to run.""),
++					'default': defaultWindowsTerm
++				}
++			}
++		},
++		'terminal.linux': {
++			'description': nls.localize('terminal.linux', ""Linux specific settings.""),
++			'type': 'object',
++			'properties': {
++				'exec': {","Have you thought about how the settings should be named given that the eventual integrated terminal https://github.com/Microsoft/vscode/issues/143 will likely have a set of settings as well? Maybe something like `terminal.external...` and `terminal.integrated...` or something?
+",2016-04-18 17:17:41
+786,"@@ -19,6 +19,7 @@
+ 	""format.insertSpaceAfterFunctionKeywordForAnonymousFunctions"": ""Defines space handling after function keyword for anonymous functions."",
+ 	""format.insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis"": ""Defines space handling after opening and before closing non empty parenthesis."",
+ 	""format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets"": ""Defines space handling after opening and before closing non empty brackets."",
++	""format.insertSpaceAfterOpeningAndBeforeClosingNonemptyBraces"": ""Defines space handling after opening and before closing non empty braces."",",Please add a blurb at the end about requiring TS 2.3 or higher,2017-03-02 05:23:28
+431,"@@ -19,6 +19,9 @@ import 'vs/editor/browser/editor.all';
+ // Menus/Actions
+ import 'vs/platform/actions/browser/menusExtensionPoint';
+ 
++// External Explorers
++import ""vs/platform/explorers/browser/explorerExtensionPoint"";","[needs change] Please move this file into the `workbench` folder, only shared services (between editor/workbench) and things around it should be in `platform`
+",2016-11-01 10:06:06
+439,"@@ -19,6 +19,9 @@ import 'vs/editor/browser/editor.all';
+ // Menus/Actions
+ import 'vs/platform/actions/browser/menusExtensionPoint';
+ 
++// External Explorers
++import ""vs/workbench/browser/explorerExtensionPoint"";","@octref as mentioned, suggest to move this into `vs/workbench/parts/explorers` and move this down to the other contributions or actually just add the code to one of the contribution files you already have.
+",2016-11-03 07:50:15
+326,"@@ -190,7 +190,10 @@ class CheckoutCommand implements ICommand {
+ 		if (currentHeadMatches.length > 0) {
+ 			entries.unshift(new CurrentHeadEntry(this.gitService, this.messageService, currentHeadMatches[0].head, currentHeadMatches[0].highlights));
+ 
+-		} else if (exactMatches.length === 0 && isValidBranchName(input)) {
++		} else if (exactMatches.length === 0) {
++			if (!isValidBranchName(input)) {
++			input = correctBranchName(input);","Could we do the same for the `git branch` command?
+",2016-10-14 12:51:39
+119,"@@ -190,9 +191,10 @@ export class OpenWorkspaceSettingsAction extends BaseOpenSettingsAction {
+ class DefaultSettingsInput extends StringEditorInput {
+ 	private static INSTANCE: DefaultSettingsInput;
+ 
+-	public static getInstance(instantiationService: IInstantiationService): DefaultSettingsInput {
++	public static getInstance(instantiationService: IInstantiationService, configurationService: IConfigurationService): DefaultSettingsInput {
+ 		if (!DefaultSettingsInput.INSTANCE) {
+-			let defaults = getDefaultValuesContent();
++			let editorConfig = configurationService.getConfiguration<any>();
++			let defaults = getDefaultValuesContent(editorConfig.insertSpaces ? strings.repeat(' ', editorConfig.tabSize) : '\t');","editorConfig.insertSpaces => editorConfig.editor.insertSpaces
+",2016-04-21 07:16:10
+270,"@@ -190,9 +191,12 @@ export class TerminalService implements ITerminalService {
+ 
+ 		if (processCount === 0 && !name) {
+ 			name = this.nextTerminalName;
++			shellPath = this.nextTerminalShellPath;","Create the config here so that the config isn't tracked in 2 vars:
+
+``` ts
+private _nextTerminalConfiguration: ITerminalProcessConfiguration;
+
+...
+
+if (processCount === 0 && !name) {
+  this._nextTerminalConfiguration = {
+    name: ...
+    shellPath: ...
+  };
+} else {
+  ...
+}
+```
+",2016-09-08 19:04:36
+866,"@@ -192,6 +197,18 @@ export class SettingsDocument {
+ 		return Promise.resolve([]);
+ 	}
+ 
++	private provideDefaultLanguageCompletionItems(location: Location, range: vscode.Range): vscode.ProviderResult<vscode.CompletionItem[]> {","Can we make this method reused between the two clients calling `vscode.languages.getLanguages` here, it seems there is quite a bit of overlap",2017-03-26 19:20:44
+574,"@@ -192,6 +200,42 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 		});
+ 	}
+ 
++	private onFocusStackFrame(stackFrame: IStackFrame): void {
++		// Since step over, step out is a fast continue + break. Continue clears stack.
++		// This means we'll get a null stackFrame followed quickly by a valid stackFrame.
++		// Removing all decorators and adding them again causes a noticeable UI flash due to relayout and paint.
++		// We want to only remove inline decorations if a null stackFrame isn't followed by a valid stackFrame in a short interval.
++		clearTimeout(this.removeDecorationsTimeoutId);",Same as I already commented couple of days ago. Instead of using a timeout I would prefer that we have the decorations on our end and than only update the delta using deltaDecorations. Only if this approach does not work I would consider using timeouts which feels ugly to me.,2016-12-05 14:51:36
+647,"@@ -194,40 +219,53 @@ export class TypeOperations {
+ 		}
+ 	}
+ 
++
+ 	private static _enter(config: CursorConfiguration, model: ITokenizedModel, keepPosition: boolean, range: Range): EditOperationResult {
++		let enterAction = LanguageConfigurationRegistry.getEnterActionAtPosition(model, range.startLineNumber, range.startColumn);
++		let lineText = model.getLineContent(range.startLineNumber);
++		let indentation = strings.getLeadingWhitespace(lineText);
++		if (indentation.length > range.startColumn - 1) {
++			indentation = indentation.substring(0, range.startColumn - 1);
++		}
+ 
+-		let r = LanguageConfigurationRegistry.getEnterActionAtPosition(model, range.startLineNumber, range.startColumn);
+-		let enterAction = r.enterAction;
+-		let indentation = r.indentation;
++		// adjust indentation of current line.
++		let beforeText = '';
++		if (enterAction.outdentCurrentLine) {","When running scripts\test.bat --coverage this block is not covered, can you please write some tests that cover this new functionality?",2016-12-27 09:59:14
+629,"@@ -196,6 +200,15 @@ export class VSCodeMenu {
+ 			updateMenu = true;
+ 		}
+ 
++		let newAutoHideMenuBar = config && config.window && config.window.autoHideMenuBar;",I think this should move out of `menu.ts` into `window.ts` because it rather belongs there. You can have the same listener installed in `window.ts` and do the updating. Also note that I think it should only update if the menu is actually hidden.,2016-12-20 06:24:17
+23,"@@ -1962,6 +1962,63 @@ declare namespace vscode {
+ 	}
+ 
+ 	/**
++	 * Reasons for which completion can be triggered.
++	 */
++	export enum CompletionTriggerReason {
++
++		/**
++		 * Invoked by the user, e.g. by hitting `Ctrl+Space`
++		 */
++		OnManualInvocation = 1,
++
++		/**
++		 * When a trigger character was types or when the configuration","`s/types/typed/`
+",2015-12-10 16:17:52
+24,"@@ -1962,6 +1962,63 @@ declare namespace vscode {
+ 	}
+ 
+ 	/**
++	 * Reasons for which completion can be triggered.
++	 */
++	export enum CompletionTriggerReason {
++
++		/**
++		 * Invoked by the user, e.g. by hitting `Ctrl+Space`
++		 */
++		OnManualInvocation = 1,
++
++		/**
++		 * When a trigger character was types or when the configuration
++		 * is set to trigger on any character.
++		 */
++		OnType = 2
++	}
++
++	/**
++	 * Value-object that contains additional information when
++	 * requesting completions.
++	 */
++	export interface CompletionContext {
++		triggerReason: CompletionTriggerReason;
++		triggerCharacter: string;
++	}
++
++	/**
++	 * Represents a list of completions.
++	 */
++	export class CompletionList extends Array<CompletionItem> {
++
++		/**
++		 * The context from which this completion list was computed.
++		 */
++		context: CompletionContext;","Why does the completion implementer need to return back the context?
+",2015-12-10 16:19:22
+896,"@@ -197,17 +198,25 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 		this._checkGlobalTSCVersion = true;
+ 		this.trace = this.readTrace();
+ 		this.tsServerLogLevel = this.readTsServerLogLevel();
++		this.checkJs = this.readCheckJs();
++
+ 		disposables.push(workspace.onDidChangeConfiguration(() => {
+ 			let oldLoggingLevel = this.tsServerLogLevel;",Managing config like this is becoming pretty old. I'll look into refactoring this logic to be clearer in another change,2017-04-21 03:06:10
+523,"@@ -197,4 +206,24 @@ export class TerminalService implements ITerminalService {
+ 		}
+ 		return terminalIndex;
+ 	}
++
++	public updateConfig(): void {
++		this.terminalInstances.forEach((instance) => {
++			this._updateCursorBlink(instance);
++			this._updateCommandsToSkipShell(instance);
++			this._updateScrollback(instance);
++		});
++	}
++
++	private _updateCursorBlink(terminalInstance): void {
++		terminalInstance.setCursorBlink(this.configHelper.getCursorBlink());",I think it would make sense to just roll these 3 single line functions into `updateConfig` now.,2016-11-28 18:57:22
+726,"@@ -1973,10 +1973,15 @@ declare module 'vscode' {
+ 		 * @param position The position at which the command was invoked.
+ 		 * @param context
+ 		 * @param token A cancellation token.
++		 * @param progress A callback that the implementation MAY call to send intermediate results.
++		 * This allows the UI to start showing these results to the user.
++		 * Calls to `progress` should only include results that have not been passed to previous calls to `progress`.
++		 * Calls to `progress` after the call to `provideReferences` has resolved will be ignored.
++		 * The order of data sent via `progress` does not matter. The results will be sorted before being displayed to the user.
+ 		 * @return An array of locations or a thenable that resolves to such. The lack of a result can be
+ 		 * signaled by returning `undefined`, `null`, or an empty array.
+ 		 */
+-		provideReferences(document: TextDocument, position: Position, context: ReferenceContext, token: CancellationToken): ProviderResult<Location[]>;
++		provideReferences(document: TextDocument, position: Position, context: ReferenceContext, token: CancellationToken, progress: (locations: Location[]) => void): ProviderResult<Location[]>;","Two comments here:
+
+1. AFAIK this change is backwards compatible because we are adding the callback as a last parameter. VS Code controls all callers (so we can require it to be passed), but implementors of this function can ignore the progress parameter if they want.
+2. Unsure if `progress` is the right name for this parameter. It is for intermediate results, not for reporting a percent completion. Wasn't sure if I should use the proposed `Progress<T>` type for this. Thoughts?",2017-02-09 19:39:01
+755,"@@ -2,6 +2,7 @@
+  *  Copyright (c) Microsoft Corporation. All rights reserved.",Looks good,2017-02-20 14:09:47
+3,"@@ -2,7 +2,9 @@
+ 
+ [VS Code](http://code.visualstudio.com) is a new type of tool that combines the simplicity of a code editor with what developers need for their core edit-build-debug cycle. Code provides comprehensive editing and debugging support, an extensibility model, and lightweight integration with existing tools.
+ 
+-<img width=""550"" alt=""vscodereadme"" align=""middle""  src=""https://cloud.githubusercontent.com/assets/1487073/11243985/98562110-8e0b-11e5-9922-29a0b4884eab.png"">","`alt` text should probably be `""""` as the image doesn't really convey information. @chrisdias any reason for adding it initially?
+",2015-11-19 22:11:07
+944,"@@ -20,6 +20,12 @@ export const STATUS_BAR_DEBUGGING_BACKGROUND = registerColor('statusBar.debuggin
+ 	hc: '#CC6633'
+ }, localize('statusBarDebuggingBackground', ""Status bar background color when a program is being debugged. The status bar is shown in the bottom of the window""));
+ 
++export const STATUS_BAR_DEBUGGING_FOREGROUND = registerColor('statusBar.debuggingForeground', {
++	dark: '#FFFFFF',","Same here, use `STATUS_BAR_FOREGROUND` as default",2017-05-22 04:47:46
+917,"@@ -20,6 +20,7 @@ export const HIGH_CONTRAST = 'hc';
+ export type ThemeType = 'light' | 'dark' | 'hc';
+ 
+ export interface ITheme {
++	readonly name: string;","The reason for adding a new field here is give us a human readable identifier to workwith in css rules. The `selector` is something like `vs.vscode-theme-solarized-light-themes-solarized-light-color-theme-json` for example. 
+
+I wasn't exactly sure what this new field should be called though. `name` seemed like the best fit but `label` and `id`are also used in the codebase",2017-05-05 22:22:17
+536,"@@ -20,7 +20,22 @@ export const ILifecycleService = createDecorator<ILifecycleService>('lifecycleSe
+  */
+ export interface ShutdownEvent {
+ 	veto(value: boolean | TPromise<boolean>): void;
+-	quitRequested: boolean;
++	reason: ShutdownReason;
++}
++
++export enum ShutdownReason {
++
++	/** Window is closed */
++	CLOSE,
++
++	/** Application is quit */
++	QUIT,
++
++	/** Window is reloaded */
++	RELOAD,
++
++	/** Other configuration loaded into window */",I'm a little unsure what LOAD is.,2016-11-29 07:52:55
+570,"@@ -20,9 +25,33 @@ export interface RenderOptions {
+ 	codeBlockRenderer?: (modeId: string, value: string) => string | TPromise<string>;
+ }
+ 
+-export function renderMarkedString(markedString: MarkedString, options: RenderOptions = {}): Node {
++export function renderMarkedString(modeService: IModeService, openerService: IOpenerService, markedString: MarkedString): Node {
+ 	const htmlContentElement = typeof markedString === 'string' ? { markdown: markedString } : { code: markedString };
+-	return renderHtml(htmlContentElement, options);
++
++	return renderHtml(htmlContentElement, {
++		actionCallback: (content) => {
++			openerService.open(URI.parse(content)).then(void 0, onUnexpectedError);
++		},
++		codeBlockRenderer: (languageAlias, value): string | TPromise<string> => {
++			// According to the language server spec (https://github.com/Microsoft/language-server-protocol)
++			// A MarkedString is rendered as:
++			// - CASE 1: markdown if it is represented as a string
++			// - CASE 2: markdown code block of the given langauge if it is represented as a pair of a language and a value
++			//
++			// Because this function is only responsible for rendering code blocks, we only need to worry about handling
++			// CASE 2 here. We follow the spec exactly because in some cases (e.g. PHP), we want the content to be
++			// rendered using less strict rules than the official grammar (as we sometimes do in markdown.)
++			//
++			// Also note that we render the codeblock using TextMate grammar rather than using highlight.js as we do in the
++			// markdown preview. This is because we want renderings to be as consistent with the editor as possible.
++			value = '```' + languageAlias + '\n' + value + '\n ```';
++			const modeId = 'markdown';",That's the wrong `modeId` - it should be `languageAlias`,2016-12-05 13:59:12
+627,"@@ -200,6 +200,11 @@ let properties: { [path: string]: IJSONSchema; } = {
+ 		'type': 'boolean',
+ 		'default': false,
+ 		'description': nls.localize('showFullPath', ""If enabled, will show the full path of opened files in the window title."")
++	},","Two things:
+* this setting should be wrapped around a isLinux/isWindows check so that it does not show up on macOS where it is not supported
+* I find the setting name a bit confusing because `autoHideMenuBar` is not really clear other than that it matches the Electron method we are using it for. I would try to change it to the intent it actually does (if this option is set to true, you can press Alt key to show the menu even if the menu is hidden)",2016-12-20 06:19:29
+735,"@@ -200,9 +200,12 @@ actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(CreateNewTermina
+ 	primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_BACKTICK,
+ 	mac: { primary: KeyMod.WinCtrl | KeyMod.Shift | KeyCode.US_BACKTICK }
+ }), 'Terminal: Create New Integrated Terminal', category);
+-actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(FocusTerminalAction, FocusTerminalAction.ID, FocusTerminalAction.LABEL), 'Terminal: Focus Terminal', category);
++actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(FocusActiveTerminalAction, FocusActiveTerminalAction.ID, FocusActiveTerminalAction.LABEL), 'Terminal: Focus Active Terminal', category);
+ actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(FocusNextTerminalAction, FocusNextTerminalAction.ID, FocusNextTerminalAction.LABEL), 'Terminal: Focus Next Terminal', category);
+ actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(FocusPreviousTerminalAction, FocusPreviousTerminalAction.ID, FocusPreviousTerminalAction.LABEL), 'Terminal: Focus Previous Terminal', category);
++for (let i = 0; i < 10; i++) {","This should be 1 to 9, not 0 to 9",2017-02-18 17:49:56
+615,"@@ -203,6 +203,14 @@ let properties: { [path: string]: IJSONSchema; } = {
+ 	}
+ };
+ 
++if (platform.isWindows) {
++	properties['window.autoDetectHighContrast'] = {
++		'type': 'boolean',
++		'default': true,
++		'description': nls.localize('autoDetectHighContrast', ""If enabled, will automatically change to high contrast theme if Windows is using a high contrast theme."")
++	}",Missing trailing comma.,2016-12-16 14:13:31
+897,"@@ -204,6 +204,28 @@ export class TerminalPanel extends Panel {
+ 				event.stopPropagation();
+ 			}
+ 		}));
++		this._register(DOM.addDisposableListener(this._parentDomElement, DOM.EventType.DROP, (e: DragEvent) => {
++			if (e.target === this._parentDomElement || DOM.isAncestor(e.target as HTMLElement, this._parentDomElement)) {
++				if (!e.dataTransfer) {
++					return;
++				}
++				const url = e.dataTransfer.getData('URL');
++				const filePath = this._getPathFromUrl(url);","Instead of doing this you should use `Uri.file(path)`, you should then be able to extract the path in the correct format from that class. https://github.com/Microsoft/vscode/blob/d02567a2e43203f20d4a1daf1ca7c489be033a4b/src/vs/base/common/uri.ts#L215",2017-04-21 18:44:13
+53,"@@ -208,6 +214,11 @@ export class Workbench implements IPartService {
+ 				viewletAndEditorPromises.push(this.sidebarPart.openViewlet(viewletId, false).then(() => viewletTimerEvent.stop()));
+ 			}
+ 
++			if (!this.panelHidden) {
++				const panelId = this.storageService.get(PanelPart.activePanelSettingsKey, StorageScope.WORKSPACE);
++				viewletAndEditorPromises.push(this.panelPart.openPanel(panelId, false));","@isidorn viewletAndEditorPromises => createCompositesPromises or so :)
+",2016-01-19 11:12:08
+487,"@@ -21,13 +23,29 @@ export class BackupMainService implements IBackupMainService {
+ 	private workspacesJsonContent: IBackupWorkspacesFormat;
+ 
+ 	constructor(
+-		@IEnvironmentService environmentService: IEnvironmentService
++		@IEnvironmentService environmentService: IEnvironmentService,
++		@ILifecycleService lifecycleService: ILifecycleService
+ 	) {
+ 		this.backupHome = environmentService.backupHome;
+ 		this.workspacesJsonPath = environmentService.backupWorkspacesPath;
++
++		if (lifecycleService) {","@Tyriar I am not a big fan of this pattern where we check for services to be present. if you have a test, make sure it includes a sufficient test lifecycle service.
+",2016-11-15 05:36:33
+765,"@@ -210,6 +211,28 @@ export class RunAction extends StartAction {
+ 	}
+ }
+ 
++export class LaunchAction extends RunAction {",Extend from abstractdebugAction,2017-02-21 10:48:22
+763,"@@ -210,6 +211,28 @@ export class RunAction extends StartAction {
+ 	}
+ }
+ 
++export class LaunchAction extends RunAction {
++	private quickOpenService: IQuickOpenService;
++	static ID = 'workbench.action.debug.launch';
++	static LABEL = nls.localize('launchDebugConfiguration', ""Select and Start Debugging"");
++
++	constructor(id: string, label: string,
++		@IDebugService debugService: IDebugService,
++		@IKeybindingService keybindingService: IKeybindingService,
++		@ICommandService commandService: ICommandService,
++		@IWorkspaceContextService contextService: IWorkspaceContextService,
++		@IFileService fileService: IFileService,
++		@IQuickOpenService quickOpenService: IQuickOpenService",Put private for quickOpenService,2017-02-21 10:41:31
+766,"@@ -210,6 +211,28 @@ export class RunAction extends StartAction {
+ 	}
+ }
+ 
++export class LaunchAction extends RunAction {
++	private quickOpenService: IQuickOpenService;
++	static ID = 'workbench.action.debug.launch';
++	static LABEL = nls.localize('launchDebugConfiguration', ""Select and Start Debugging"");
++
++	constructor(id: string, label: string,
++		@IDebugService debugService: IDebugService,
++		@IKeybindingService keybindingService: IKeybindingService,
++		@ICommandService commandService: ICommandService,
++		@IWorkspaceContextService contextService: IWorkspaceContextService,
++		@IFileService fileService: IFileService,
++		@IQuickOpenService quickOpenService: IQuickOpenService
++	) {
++		super(id, label, debugService, keybindingService, commandService, contextService, fileService);
++		this.quickOpenService = quickOpenService;
++	}
++
++	public run(): TPromise<any> {
++		return TPromise.as(this.quickOpenService.show('debug '));",Do not wrap as promise,2017-02-21 10:49:06
+672,"@@ -211,7 +211,8 @@ export class EditorGroupsControl implements IEditorGroupsControl, IVerticalSashL
+ 	}
+ 
+ 	private updateTabOptions(tabOptions: ITabOptions, refresh?: boolean): void {
+-		const showTabCloseButton = this.tabOptions ? this.tabOptions.showTabCloseButton : false;
++		const tabCloseButton = this.tabOptions ? this.tabOptions.tabCloseButton : 'right';
++		const showTabCloseButton =  this.tabOptions ? this.tabOptions.showTabCloseButton : false;",Just delete support for `showTabCloseButton` option since it is now supported via your `tabCloseButton` setting.,2017-01-16 07:57:33
+974,"@@ -212,7 +212,8 @@ function packageTask(platform, arch, opts) {
+ 			'vs/workbench/electron-browser/workbench.main.js',
+ 			'vs/workbench/electron-browser/workbench.main.css',
+ 			'vs/workbench/electron-browser/bootstrap/index.html',
+-			'vs/workbench/electron-browser/bootstrap/index.js'
++			'vs/workbench/electron-browser/bootstrap/index.js',
++			'vs/workbench/electron-browser/bootstrap/preload.js'",@mjbvz make sure to run a test build and verify that this file is included in the produced drop,2017-06-15 05:13:41
+725,"@@ -212,8 +212,19 @@ class DataSource implements tree.IDataSource {
+ 	}
+ }
+ 
++/**
++ * RevealedReference wraps an optional OneReference.
++ * This allows RevealedReference to be passed around (i.e. to Controller)
++ * and updates to the reference can be seen.
++ */
++type RevealedReference = { ref: OneReference | undefined };","I am unsure if the Controller should own the state of what is expanded & revealed or if the ReferenceWidget should own the state. Currently the ReferenceWidget does not retain a reference to the Controller and I am unfamiliar with the lifecycle, so this implementation has the ReferenceWidget owning this state and passing it through to the controller.",2017-02-09 19:35:03
+663,"@@ -2146,64 +2156,6 @@ suite('Editor Controller - Regression tests', () => {
+ 		});
+ 	});
+ 
+-	test('issue Microsoft/monaco-editor#108 part 1/2: Auto indentation on Enter with selection is half broken', () => {",Move it to indentation related test suite and uses indent rules instead of mocking `enterAction`.,2017-01-12 05:52:09
+179,"@@ -216,6 +216,21 @@ export class Controller extends treedefaults.DefaultController {
+ 		super({ clickBehavior: treedefaults.ClickBehavior.ON_MOUSE_DOWN });
+ 	}
+ 
++	public onClick(tree: ITree, element: any, event: IMouseEvent): boolean {
++
++		// Close opened editor on middle mouse click
++		if (element instanceof OpenEditor && event.browserEvent && event.browserEvent.button === 1 /* Middle Button */) {
++			const closeAction = this.instantiationService.createInstance(CloseEditorAction, CloseEditorAction.ID, CloseEditorAction.LABEL);
++			closeAction.run({ event, group: (<OpenEditor>element).editorGroup, editor: (<OpenEditor>element).editorInput }).done(() => {
++				closeAction.dispose();
++			}, errors.onUnexpectedError);
++
++			return true;
++		}
++
++		return super.onClick(tree, element, event);
++	}
++
+ 	protected onLeftClick(tree: ITree, element: any, event: IMouseEvent, origin: string = 'mouse'): boolean {","Looks good - tried it out and it works!
+Though why do you instantiate the action when you can simply go to the editorService and say closeEditor - you have the position and the input.
+",2016-06-03 15:02:30
+660,"@@ -217,6 +222,35 @@ export class PeekDefinitionAction extends DefinitionAction {
+ 	}
+ }
+ 
++
++@editorAction
++export class GoToImplementationAction extends DefinitionAction {
++
++	public static ID = 'editor.action.goToImplementation';
++
++	constructor() {
++		super(new DefinitionActionConfig(), {
++			id: GoToImplementationAction.ID,
++			label: nls.localize('actions.goToImplementation.label', ""Go to Implementation""),
++			alias: 'Go to Implementation',
++			precondition: ModeContextKeys.hasImplementationProvider,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.CtrlCmd | KeyCode.F12",conflicts with Find References,2017-01-10 08:37:17
+485,"@@ -217,6 +233,12 @@ export class TextFileEditorModelManager implements ITextFileEditorModelManager {
+ 						break;
+ 				}
+ 			});
++
++			// Install model content change listener
++			this.mapResourceToModelContentChangeListener[resource.toString()] = model.onDidContentChange(() => {
++				const newEvent = new TextFileModelChangeEvent(model, StateChange.CONTENT_CHANGE);","@Tyriar I do not see a reason to create an object here each time a character is typed. the untitled event just sends around its resource URI and I would do the same thing here for files.
+
+Cannot say it often enough, this model content change event WILL FIRE like CRAZY. And perf is a hot topic after hot exit :)
+",2016-11-09 08:05:40
+552,"@@ -22,10 +23,16 @@ export interface IBackupMainService {
+ 	 */
+ 	getWorkspaceBackupPaths(): string[];
+ 
++	// TODO: Doc
++	getEmptyWorkspaceBackupWindowIds(): string[];
++
+ 	/**
+ 	 * Pushes workspace backup paths to be tracked for restoration.
+ 	 *
+ 	 * @param workspaces The workspaces to add.
+ 	 */
+ 	pushWorkspaceBackupPathsSync(workspaces: Uri[]): void;
++
++	// TODO: Doc
++	pushEmptyWorkspaceBackupWindowIdSync(vscodeWindowId: string): void;",@Tyriar maybe merge both methods into one and the return type can either be a path to a workspace or a window id? might make the naming easier.,2016-12-01 16:28:11
+988,"@@ -22,15 +22,15 @@ export class GlobalQuickOpenAction extends Action {
+ 	public static ID = 'workbench.action.quickOpen';
+ 	public static LABEL = nls.localize('quickOpen', ""Go to File..."");
+ 
+-	constructor(id: string, label: string, @IQuickOpenService private quickOpenService: IQuickOpenService) {
++	constructor(id: string, label: string, @IQuickOpenService private quickOpenService: IQuickOpenService, @ICommandService private commandService: ICommandService) {
+ 		super(id, label);
+ 
+ 		this.order = 100; // Allow other actions to position before or after
+ 		this.class = 'quickopen';
+ 	}
+ 
+-	public run(): TPromise<any> {
+-		this.quickOpenService.show(null);
++	public run(prefix?: string, showOptions?: IShowOptions): TPromise<any> {",I think we can remove `prefix` and `showOptions` from this action right? We are not using these arguments anywhere. The extension is using the command.,2017-06-19 10:40:02
+656,"@@ -22,15 +22,22 @@ File a single issue per problem and feature request.
+ * Do not enumerate multiple bugs or feature requests in the same issue.
+ * Do not add your issue as a comment to an existing issue unless it's for the identical input. Many issues look similar, but have different causes.
+ 
+-The more information you can provide, the more likely someone will be successful reproducing the issue and finding a fix. Therefore:
++The more information you can provide, the more likely someone will be successful reproducing the issue and finding a fix. 
++
++Please include the following with each issue. 
+ 
+-* Provide reproducible steps, what the result of the steps was, and what you would have expected.
+-* A description of what you expect to happen
+-* Animated GIFs
+-* Code that demonstrates the issue, when providing a code snippet also include it in source and not only as an image
+ * Version of VS Code
++* List of extensions that you have installed. ",Suggest to add: You can easily include the list of extensions by creating the issue using the `Help>Report Issues` menu item.,2017-01-09 09:59:06
+657,"@@ -22,15 +22,22 @@ File a single issue per problem and feature request.
+ * Do not enumerate multiple bugs or feature requests in the same issue.
+ * Do not add your issue as a comment to an existing issue unless it's for the identical input. Many issues look similar, but have different causes.
+ 
+-The more information you can provide, the more likely someone will be successful reproducing the issue and finding a fix. Therefore:
++The more information you can provide, the more likely someone will be successful reproducing the issue and finding a fix. 
++
++Please include the following with each issue. 
+ 
+-* Provide reproducible steps, what the result of the steps was, and what you would have expected.
+-* A description of what you expect to happen
+-* Animated GIFs
+-* Code that demonstrates the issue, when providing a code snippet also include it in source and not only as an image
+ * Version of VS Code
++* List of extensions that you have installed. 
++* Reproducible steps (1... 2... 3...) and what you expected versus what you actually saw. 
++* Images, animations, or a link to a video. 
++* A code snippet that demonstrates the issue or a link to a code repository we can easily pull down onto our machine to recreate the issue. ","Suggest to emphasize, `including a code snippet as a GIF only, is not sufficient, since this requires us to type in the snippet to reproduce the problem.",2017-01-09 10:00:42
+435,"@@ -22,25 +23,48 @@ import { IActivityService, IBadge } from 'vs/workbench/services/activity/common/
+ import { IPartService } from 'vs/workbench/services/part/common/partService';
+ import { IInstantiationService } from 'vs/platform/instantiation/common/instantiation';
+ import { IKeybindingService } from 'vs/platform/keybinding/common/keybinding';
++import { IStorageService } from 'vs/platform/storage/common/storage';
++import { IExtensionService } from 'vs/platform/extensions/common/extensions';
+ 
+ export class ActivitybarPart extends Part implements IActivityService {
+ 	public _serviceBrand: any;
++
+ 	private viewletSwitcherBar: ActionBar;
+ 	private activityActionItems: { [actionId: string]: IActionItem; };
+ 	private compositeIdToActions: { [compositeId: string]: ActivityAction; };
+ 
++	private enabledExternalViewlets: string[];
++	private externalViewlets: { [viewletId: string]: ViewletDescriptor; };
++
++	// Serves two purposes:
++	// 1. Expose the viewletId that will be assigned to an external Viewlet,
++	//    which wouldn't know its viewletId until construction time.
++	// 2. When workbench restores sidebar, if the last-opened Viewlet is external,
++	//    it'll set this value and defer restoration until all extensions are loaded.
++	private _externalViewletIdToOpen: string;","This feels a bit unclean, but I can't find a better way to do it.
+
+I don't think 1) can be worked around, but as for 2), I could have put `IExtensionService` as a dep for `Workbench` and register a callback for `extensionService.onReady`. What's your opinion @bpasero ?
+",2016-11-02 05:41:38
+678,"@@ -22,6 +22,7 @@ export const IEditorGroupService = createDecorator<IEditorGroupService>('editorG
+ export interface ITabOptions {
+ 	showTabs?: boolean;
+ 	showTabCloseButton?: boolean;
++	tabCloseButton?: string;",Use string enum here (`'left' | 'right' | 'off'`),2017-01-16 08:00:32
+180,"@@ -220,6 +220,15 @@ export class CommonFindController extends Disposable implements editorCommon.IEd
+ 		}
+ 		return false;
+ 	}
++
++	public selectAllMatches(): boolean {
++		if (this._model) {
++			this._model.selectAllMatches();
++			this.closeFindWidget();","``` ts
+this.closeFindWidget();
+```
+
+Why is it removed in the latest code(in master branch)?
+",2016-06-11 08:43:59
+11,"@@ -221,7 +221,14 @@ export class FileService implements files.IFileService {
+ 			if (exists) {
+ 				createParentsPromise = Promise.as(null);
+ 			} else {
+-				createParentsPromise = pfs.mkdirp(paths.dirname(absolutePath));
++				//Do not try to make parent directory if saving to drive root
++				var dirName = paths.dirname(absolutePath);
++				if(dirName.slice(-2) != ':\\') {","So the problem is that a recursive `mkdir` is always attempted if the file does not yet exist, which breaks when it's in a drive root? How about doing a `pfs.stat` on `paths.dirname(absolutePath)` and see if it exists? Root directories should return true to that and it should be fine cross-platform too.
+",2015-11-22 07:20:13
+212,"@@ -222,14 +222,7 @@ export class TerminalService implements ITerminalService {
+ 	}
+ 
+ 	private createTerminalProcess(): ITerminalProcess {
+-		let env = this.cloneEnv();
+-		let shell = this.configHelper.getShell();
+-		env['PTYPID'] = process.pid.toString();
+-		env['PTYSHELL'] = shell.executable;
+-		shell.args.forEach((arg, i) => {
+-			env[`PTYSHELLARG${i}`] = arg;
+-		});
+-		env['PTYCWD'] = this.contextService.getWorkspace() ? this.contextService.getWorkspace().resource.fsPath : os.homedir();
++		let env = this.createTerminalEnv();","May as well do the call inside `cp.fork` now. Other than that good to go though I'd like to see some tests for it since it see,s fairly testable.
+",2016-07-09 02:23:17
+450,"@@ -228,9 +228,14 @@ export class Workbench implements IPartService {
+ 				viewletId = this.storageService.get(SidebarPart.activeViewletSettingsKey, StorageScope.WORKSPACE, viewletId); // help developers and restore last view
+ 			}
+ 
+-			if (!this.sideBarHidden && !!viewletId) {
+-				const viewletTimerEvent = timer.start(timer.Topic.STARTUP, strings.format('Opening Viewlet: {0}', viewletId));
+-				compositeAndEditorPromises.push(this.sidebarPart.openViewlet(viewletId, false).then(() => viewletTimerEvent.stop()));
++			// If external viewlet is the last active viewlet, defer its construction until all extensions are loaded
++			if (!viewletRegistry.getViewlet(viewletId)) {","@octref this is ugly and should be removed. instead the viewlet service should be fit enough to handle both extension viewlets and normal viewlets. if you clean that up you will not need this if-else condition at all 👍 
+",2016-11-03 08:46:28
+40,"@@ -229,15 +234,15 @@ export class CommandEvent extends Event {
+ }
+ 
+ /**
+- * Viewlet events are emitted when a viewlet opens or closes in the sidebar.
++ * Composite events are emitted when a composite opens or closes in the sidebar or panel.
+  */
+-export class ViewletEvent extends Event {
+-	public viewletId: string;
++export class CompositeEvent extends Event {
++	public compositeId: string;
+ 
+-	constructor(viewletId: string, originalEvent?: any) {
++	constructor(compositeId: string, originalEvent?: any) {","@isidorn I think here we should also send around the actual instance of Composite that was opened or closed because then one can simply do an instance of check to find out if the composite was a viewlet or panel.
+",2016-01-15 15:13:58
+88,"@@ -23,4 +23,12 @@
+ 
+ .monaco-sash.disabled {
+ 	cursor: default;
++}
++
++.vertical-cursor-container * {
++	cursor: ew-resize !important;
++}
++
++.horizontal-cursor-container * {
++	cursor: ns-resize !important;","Why is this needed?
+",2016-03-30 05:23:56
+904,"@@ -23,7 +23,13 @@
+ 
+ .monaco-editor .suggest-widget > .tree {
+ 	height: 100%;
+-	width: 100%;
++	width: 40%;
++	float: left;","Careful with floats. If all you have is two divs, you should use the usual `inline-block` display to lay them out side by side.",2017-05-04 12:37:58
+210,"@@ -230,6 +230,9 @@ export class TerminalService implements ITerminalService {
+ 			env[`PTYSHELLARG${i}`] = arg;
+ 		});
+ 		env['PTYCWD'] = this.contextService.getWorkspace() ? this.contextService.getWorkspace().resource.fsPath : os.homedir();
++		if (!env['LANG'] && platform.locale) {","This function's a bit busy at this point, can you factor out the `env` stuff into a `createTerminalEnv` function?
+",2016-07-08 23:00:58
+209,"@@ -230,6 +230,9 @@ export class TerminalService implements ITerminalService {
+ 			env[`PTYSHELLARG${i}`] = arg;
+ 		});
+ 		env['PTYCWD'] = this.contextService.getWorkspace() ? this.contextService.getWorkspace().resource.fsPath : os.homedir();
++		if (!env['LANG'] && platform.locale) {
++			env['LANG'] = this.getLang(platform.locale);","Do the `LC_` variables get fixed with this? Do you need to set `LC_ALL` too?
+",2016-07-08 22:59:30
+963,"@@ -230,6 +232,19 @@ export class Repl extends Panel implements IPrivateReplService {
+ 		this.layout(this.dimension);
+ 	}
+ ","I do not like code duplication, can you please look into removing the `CopyAllAction` from `electronDebugActions.ts`. I believe that we can now always use this action instead, can you please try that?",2017-06-08 09:59:44
+669,"@@ -235,6 +236,33 @@ export class FormatSelectionAction extends AbstractFormatAction {
+ 	}
+ }
+ 
++@editorAction
++export class FormatOnPasteAction extends AbstractFormatAction {
++	constructor() {
++		super({
++			id: 'editor.action.formatOnPaste',
++			label: nls.localize('formatOnPaste.label', ""Format on paste""),
++			alias: 'Format on paste',",Maybe 'Paste and Format'?,2017-01-13 11:26:03
+670,"@@ -235,6 +236,33 @@ export class FormatSelectionAction extends AbstractFormatAction {
+ 	}
+ }
+ 
++@editorAction
++export class FormatOnPasteAction extends AbstractFormatAction {
++	constructor() {
++		super({
++			id: 'editor.action.formatOnPaste',
++			label: nls.localize('formatOnPaste.label', ""Format on paste""),
++			alias: 'Format on paste',
++			precondition: EditorContextKeys.Writable",We have context key which knows if for the current document there is someone that can format selections: `ModeContextKeys.hasDocumentSelectionFormattingProvider` (see [`FormatSelection`](https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/format/common/formatActions.ts#L219) as a sample). With that the menus will automatically update.,2017-01-13 11:28:03
+136,"@@ -2362,7 +2362,7 @@ export function keybindingForAction(id: string): Keybinding {
+ 			return new Keybinding(KeyMod.CtrlCmd | KeyCode.KEY_S);
+ 		case DeleteFileAction.ID:
+ 		case MoveFileToTrashAction.ID:
+-			return new Keybinding(KeyCode.Delete);
++			return new Keybinding(isMacintosh ? KeyMod.CtrlCmd | KeyCode.Backspace : KeyMod.Shift | KeyCode.Delete);","@SamVerschueren it should actually be just KeyCode.Delete on Windows and Linux. The shift+delete was added to have a way to bypass the trash when doing the delete.
+",2016-04-21 21:39:39
+135,"@@ -239,6 +240,10 @@ class ConfigureTaskRunnerAction extends Action {
+ 					contentPromise = TPromise.as(selection.content);
+ 				}
+ 				return contentPromise.then(content => {
++					let editorConfig = this.configurationService.getConfiguration<any>();
++					if (editorConfig.editor.insertSpaces) {
++						content = content.replace(/(\n)(\t+)/g, (_, s1, s2) => s1 + strings.repeat(' ', s2.length * editorConfig.editor.tabSize));","I am a bit confused by the ""\n"" in the regex because later you are replacing it without having a ""\n"". Is that even needed?
+",2016-04-21 14:28:20
+121,"@@ -239,6 +240,10 @@ class ConfigureTaskRunnerAction extends Action {
+ 					contentPromise = TPromise.as(selection.content);
+ 				}
+ 				return contentPromise.then(content => {
++					let editorConfig = this.configurationService.getConfiguration<any>();
++					if (editorConfig.insertSpaces) {","same here
+",2016-04-21 07:16:50
+122,"@@ -239,6 +240,10 @@ class ConfigureTaskRunnerAction extends Action {
+ 					contentPromise = TPromise.as(selection.content);
+ 				}
+ 				return contentPromise.then(content => {
++					let editorConfig = this.configurationService.getConfiguration<any>();
++					if (editorConfig.insertSpaces) {
++						content = content.replace(/(\n)(\t+)/g, (_, s1, s2) => s1 + strings.repeat(' ', s2.length * editorConfig.tabSize));","why does the regex include a newline?
+",2016-04-21 07:17:07
+987,"@@ -239,6 +240,16 @@ export class ExtHostApiCommands {
+ 					{ name: 'column', description: '(optional) Column in which to open', constraint: v => v === void 0 || typeof v === 'number' }
+ 				]
+ 			});
++
++		this._register('vscode.quickOpen', (prefix: string, showOptions: IShowOptions) => {","I am not sure about exposing `IShowOptions` to extensions, I would not do this until we hear otherwise. ",2017-06-19 10:39:19
+455,"@@ -239,7 +239,7 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 		// while the UI is not yet ready. Clients have to deal with this fact and we have to make sure that the
+ 		// stacks model gets updated if any of the UI updating fails with an error.
+ 		const group = this.ensureGroup(position, !options || !options.preserveFocus);
+-		const pinned = !this.previewEditors || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();
++		const pinned = (!this.previewEditors && !(options && options.forcePreview)) || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();","This is actually interesting: conceptually we cannot have a dirty file open as preview. So if you have many dirty files and you navigate over them in quick open they will open as pinned editors :-/
+",2016-11-05 07:36:05
+484,"@@ -24,6 +24,8 @@ export class TextFileEditorModelManager implements ITextFileEditorModelManager {
+ 
+ 	private toUnbind: IDisposable[];
+ 
++	private _onModelDisposed: Emitter<URI>;","@Tyriar can we have test coverage for `onModelDisposed` and `onModelContentChanged`
+",2016-11-09 08:03:29
+76,"@@ -240,11 +240,16 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
+ 			const threadId = event.body.threadId;
+ 
+ 			this.getThreadData(threadId).then(() => {
+-				this.session.stackTrace({ threadId: threadId, levels: 20 }).done((result) => {
++				let thread = this.model.getThreads()[threadId];
+ 
+-					this.model.rawUpdate({ threadId: threadId, callStack: result.body.stackFrames, stoppedDetails: event.body });
++				this.model.rawUpdate({
++					threadId: threadId,
++					stoppedDetails: event.body,
++					allThreadsStopped: event.body.allThreadsStopped
++				});
++","Looks good - I like that the changes here are minimal now.
+
+Though I think you can handle this promises a bit better - you can nicely have only one place where you handle errors. I propose:
+- Line 242: needs a `done`
+- Line 251: needs a `return` and a `then`
+- Line 256: needs a `return` and no `done` - this will be boobled up
+- Move error handling from line 260 to 261
+
+This way I believe the error handling and `promise` flow is nicer.
+",2016-03-16 10:37:24
+246,"@@ -240,12 +240,12 @@ export class ScrollableElement extends Widget {
+ 			let deltaX = e.deltaX * this._options.mouseWheelScrollSensitivity;
+ 
+ 			if (this._options.flipAxes) {
+-				deltaY = e.deltaX;
+-				deltaX = e.deltaY;
++				deltaY = deltaX;","Sorry if I'm missing something, but how does this work?
+
+```
+deltaY = deltaX;
+deltaX = deltaY;
+```
+
+will not actually swap the two variables, it will just assign them both to have the value of deltaX. Is that the desired behavior?
+
+My guess is you'd want to use `[deltaY, deltaX] = [deltaX, deltaY]`
+",2016-08-09 00:10:43
+357,"@@ -240,7 +240,16 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 		// while the UI is not yet ready. Clients have to deal with this fact and we have to make sure that the
+ 		// stacks model gets updated if any of the UI updating fails with an error.
+ 		const group = this.ensureGroup(position, !options || !options.preserveFocus);
+-		const pinned = !this.previewEditors || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();
++		let pinned = !this.previewEditors || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();","@wprater I do not really like that we change other options (`revealIfVisible` and `preserveFocus`), here is how i would code it up:
+
+`const pinned = (!this.previewEditors && !(options && options.forcePreview)) || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();`
+
+The other options should be untouched and set from the outside as before.
+",2016-10-21 09:49:56
+347,"@@ -240,7 +241,18 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 		// while the UI is not yet ready. Clients have to deal with this fact and we have to make sure that the
+ 		// stacks model gets updated if any of the UI updating fails with an error.
+ 		const group = this.ensureGroup(position, !options || !options.preserveFocus);
+-		const pinned = !this.previewEditors || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();
++		let pinned = !this.previewEditors || (options && (options.pinned || typeof options.index === 'number')) || input.isDirty();
++		if (this.previewEditors) {
++			pinned = !this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>().workbench.editor.enablePreviewFromQuickOpen;","using the config service here vs. `EditorHistoryEntry`.  I may have preferred to put the config service call in the `getOptions` of `EditorQuickOpenEntry`, but there is no configurationService directly available there.
+",2016-10-19 22:23:02
+691,"@@ -2404,6 +2431,38 @@
+ 						</dict>
+ 					</array>
+ 				</dict>
++				<key>fenced_code_block_rust</key>",Please update these to use the fenced code block logic that the other languages now use. It's rather horrific but it fixes a few important edge cases,2017-01-19 01:54:56
+903,"@@ -241,6 +239,8 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 			this.trace = this.readTrace();
+ 			this.tsServerLogLevel = this.readTsServerLogLevel();
+ 			this.servicePromise = this.startService();
++			this.lastError = null;",I don't think this bit is needed,2017-05-03 05:11:31
+626,"@@ -242,6 +255,10 @@ export class VSCodeMenu {
+ 
+ 	private install(): void {
+ 
++		// Auto hide menu bar
++		const windows = this.windowsService.getWindows();
++		windows.forEach(w => w.win.setAutoHideMenuBar(this.currentAutoHideMenuBar));","Is this the right place to put this? 
+
+Feels a bit wasteful to create the whole menu from scratch when I just want to update a property of the window?",2016-12-19 15:35:28
+27,"@@ -244,6 +245,14 @@ registerWordCommand(H.CursorWordRight, false, KeyCode.RightArrow);
+ registerWordCommand(H.CursorWordRightSelect, true, KeyCode.RightArrow);
+ registerWordCommand(H.DeleteWordLeft, false, KeyCode.Backspace);
+ registerWordCommand(H.DeleteWordRight, false, KeyCode.Delete);
++registerWordCommand(H.DeleteSubWordLeft,false, KeyCode.F7);
++registerWordCommand(H.DeleteSubWordRight,false, KeyCode.F6);","space between `,` and `false`
+",2015-12-11 13:10:41
+220,"@@ -244,7 +274,7 @@ export class OpenAnythingHandler extends QuickOpenHandler {
+ 		return null;
+ 	}
+ 
+-	public getResultsFromCache(searchValue: string, range: IRange = null): QuickOpenEntry[] {
++	public getResultsFromCache(searchValue: string, range: IRange = null) {","One of our coding principles is to always type the return value of a function, even if TS can infer it. So please add an interface for this method too.
+
+Also it looks like we can make this method private.
+",2016-07-14 17:35:20
+679,"@@ -244,9 +244,10 @@ configurationRegistry.registerConfiguration({
+ 			'description': nls.localize('watcherExclude', ""Configure glob patterns of file paths to exclude from file watching. Changing this setting requires a restart. When you experience Code consuming lots of cpu time on startup, you can exclude large folders to reduce the initial load."")
+ 		},
+ 		'files.hotExit': {
+-			'type': 'boolean',
+-			'default': true,
+-			'description': nls.localize('hotExit', ""Controls whether unsaved files are restored after relaunching. If this is enabled there will be no prompt to save when exiting the editor."")
++			'type': 'string',
++			'enum': [HotExitConfiguration.OFF, HotExitConfiguration.ON_EXIT, HotExitConfiguration.ON_EXIT_AND_WINDOW_CLOSE],
++			'default': HotExitConfiguration.ON_EXIT,
++			'description': nls.localize('hotExit', ""Whether hot exit is enabled which allows changes to unsaved files to be remembered between sessions, hiding the prompt t save when exiting the editor. Selecting \""{0}\"" means that hot exit will only be triggered when the application is closed (workbench.action.quit command via command pallete, keybinding of menu) and ALL windows with backups will be restored upon next launch. Selecting \""{1}\"" will trigger hot exit when any FOLDER window is closed, only NON-FOLDER windows will be restored when the application is restarted (not FOLDER workspaces)."", HotExitConfiguration.ON_EXIT, HotExitConfiguration.ON_EXIT_AND_WINDOW_CLOSE)","Typo?
+
+`hiding the prompt t save`",2017-01-17 05:41:33
+571,"@@ -245,24 +242,7 @@ export class ModesContentHoverWidget extends ContentHoverWidget {
+ 			msg.contents
+ 				.filter(contents => !!contents)
+ 				.forEach(contents => {
+-					const renderedContents = renderMarkedString(contents, {
+-						actionCallback: (content) => {
+-							this._openerService.open(URI.parse(content)).then(void 0, onUnexpectedError);
+-						},
+-						codeBlockRenderer: (languageAlias, value): string | TPromise<string> => {
+-							// In markdown,
+-							// it is possible that we stumble upon language aliases (e.g.js instead of javascript)
+-							// it is possible no alias is given in which case we fall back to the current editor lang
+-							const modeId = languageAlias
+-								? this._modeService.getModeIdForLanguageName(languageAlias)
+-								: this._editor.getModel().getModeId();
+-
+-							return this._modeService.getOrCreateMode(modeId).then(_ => {
+-								return `<div class=""code"">${tokenizeToString(value, modeId)}</div>`;
+-							});
+-						}
+-					});
+-
++					const renderedContents = renderMarkedString(this._modeService, this._openerService, contents);",We have a feature that we use the documents language when a code block doesn't specify one (just triple tick pairs). We are loosing that feature here,2016-12-05 14:01:52
+239,"@@ -2459,6 +2459,12 @@ declare namespace vscode {
+ 			 * @deprecated
+ 			 */
+ 			brackets?: any;
++			/**
++			 * This property is deprecated and not fully supported anymore by
++			 * the editor (scope and lineStart are ignored).
++			 * Use the the autoClosingPairs property in the language configuration file instead.
++			 * @deprecated","Do we have a doc page on the homepage we can refer them to?
+",2016-07-22 07:39:49
+17,"@@ -246,7 +246,7 @@ export class ChangesView extends EventEmitter.EventEmitter implements GitView.IV
+ 	public getSecondaryActions(): Actions.IAction[] {
+ 		if (!this.secondaryActions) {
+ 			this.secondaryActions = [
+-				this.instantiationService.createInstance(GitActions.SyncAction),
++				this.instantiationService.createInstance(GitActions.SyncAction, GitActions.SyncAction.ID, GitActions.SyncAction.LABEL),","... here
+",2015-11-25 15:13:05
+303,"@@ -247,20 +247,26 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
+-			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-
+-			let input = this.getInput();
+-			if (input instanceof EditorInput) {
+-				this.editorService.openEditor(input, this.getOptions(), sideBySide).done(null, errors.onUnexpectedError);
+-			} else {
+-				this.editorService.openEditor(<IResourceInput>input, sideBySide).done(null, errors.onUnexpectedError);
+-			}
++		let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
++
++		let input = this.getInput();
++		let options = this.getOptions();
+ 
+-			return true;
++		const isPreview = mode === Mode.PREVIEW;
++
++		if (input instanceof EditorInput) {
++			if (isPreview) {
++				options.preserveFocus = false;","flip this
+",2016-10-05 08:24:33
+341,"@@ -247,20 +248,30 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
++		const hideWidget = mode === Mode.OPEN;
++
++		let opts = this.getOptions();
++		if (mode === Mode.OPEN_BEHIND) {
++			opts = objects.assign(opts || {}, {
++				pinned: true,
++				revealIfVisible: true,","@wprater I think this option is a bit dangerous here because what it basically means is that the file will not be opened if it is visible in any other group. but I think the intent when sending files to open to the background is to open them in that group independent from other groups. I suggest to not set this flag.
+",2016-10-18 09:43:18
+342,"@@ -247,20 +248,30 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
++		const hideWidget = mode === Mode.OPEN;
++
++		let opts = this.getOptions();
++		if (mode === Mode.OPEN_BEHIND) {
++			opts = objects.assign(opts || {}, {
++				pinned: true,
++				revealIfVisible: true,
++				preserveFocus: true
++			});
++		}
++
++		if (mode === Mode.OPEN || mode === Mode.OPEN_BEHIND) {
+ 			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+ 
+ 			let input = this.getInput();
+ 			if (input instanceof EditorInput) {
+-				this.editorService.openEditor(input, this.getOptions(), sideBySide).done(null, errors.onUnexpectedError);
++				this.editorService.openEditor(input, opts, sideBySide).done(null, errors.onUnexpectedError);
+ 			} else {
++				objects.assign((<IResourceInput>input).options, opts);","@wprater carefull, options could be null within the resource input and I think this would break `assign` method.
+",2016-10-18 09:44:40
+349,"@@ -247,20 +248,38 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
++		const hideWidget = mode === Mode.OPEN;
++
++		let backgroundOpts;","I suggest to move this into the other if check where we actually care about backgroundOpts. It is not being used in the scope otherwise.
+",2016-10-20 14:08:02
+348,"@@ -247,20 +248,38 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
++		const hideWidget = mode === Mode.OPEN;
++
++		let backgroundOpts;
++		if (mode === Mode.OPEN_IN_BACKGROUND) {
++			backgroundOpts = objects.assign({}, {","Why not just `{ pinned: true, preserveFocus: true }` ??
+",2016-10-20 14:06:40
+350,"@@ -247,20 +248,38 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	}
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+-		if (mode === Mode.OPEN) {
++		const hideWidget = mode === Mode.OPEN;
++
++		let backgroundOpts;
++		if (mode === Mode.OPEN_IN_BACKGROUND) {
++			backgroundOpts = objects.assign({}, {
++				pinned: true,
++				preserveFocus: true
++			});
++		}
++
++		if (mode === Mode.OPEN || mode === Mode.OPEN_IN_BACKGROUND) {
+ 			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
++			let opts = this.getOptions();
++			if (backgroundOpts) {
++				opts = objects.assign(opts || {}, backgroundOpts);","You cannot use `objects.assign` with the `opts` here because opts can be a real instance of `EditorOptions`, it might not just be an options bag. Maybe the better fix is to see if `this.getOptions()` could always return `IEditorOptions`.
+",2016-10-20 14:10:24
+673,"@@ -249,7 +250,7 @@ export class EditorGroupsControl implements IEditorGroupsControl, IVerticalSashL
+ 				}
+ 
+ 				// Refresh title when icons change
+-				else if (showingIcons !== this.tabOptions.showIcons || showTabCloseButton !== this.tabOptions.showTabCloseButton) {
++				else if (showingIcons !== this.tabOptions.showIcons || showTabCloseButton !== this.tabOptions.showTabCloseButton || tabCloseButton !== this.tabOptions.tabCloseButton) {",...same here,2017-01-16 07:57:46
+265,"@@ -25,14 +25,16 @@ export class ConfigVariables extends SystemVariables {
+ 	}
+ 
+ 	protected resolveString(value: string): string {
++		const originalValue = value;
+ 		value = super.resolveString(value);
+ 
+ 		let regexp = /\$\{config\.(.*?)\}/g;
+ 		return value.replace(regexp, (match: string, name: string) => {
+ 			let config = this.configurationService.getConfiguration();
+ 			let newValue = new Function('_', 'try {return _.' + name + ';} catch (ex) { return """";}')(config);","Can we simplify this line such that it is more readable? Also new Function syntax is not our style - it is not used anywhere else in our code base so I would suggest to change this
+",2016-09-05 16:30:12
+266,"@@ -25,14 +25,16 @@ export class ConfigVariables extends SystemVariables {
+ 	}
+ 
+ 	protected resolveString(value: string): string {
++		const originalValue = value;
+ 		value = super.resolveString(value);
+ 
+ 		let regexp = /\$\{config\.(.*?)\}/g;
+ 		return value.replace(regexp, (match: string, name: string) => {
+ 			let config = this.configurationService.getConfiguration();
+ 			let newValue = new Function('_', 'try {return _.' + name + ';} catch (ex) { return """";}')(config);
+ 			if (Types.isString(newValue)) {
+-				return newValue;
++				// Prevent infinite recursion and also support nested references (or tokens)
++				return newValue === originalValue ? '' : this.resolveString(newValue);
+ 			}","Else formating is not our style, please keep the else on the same line
+",2016-09-05 16:30:25
+75,"@@ -25,6 +25,7 @@ export interface IRawModelUpdate {
+ 	thread?: DebugProtocol.Thread;","Looks good.
+",2016-03-16 10:29:50
+850,"@@ -25,6 +25,7 @@ import 'vs/workbench/browser/actions/toggleSidebarVisibility';
+ import 'vs/workbench/browser/actions/toggleSidebarPosition';
+ import 'vs/workbench/browser/actions/toggleEditorLayout';
+ import 'vs/workbench/browser/actions/toggleZenMode';
++import 'vs/workbench/browser/actions/reSizePart';",Lowercase 's' to be `resizePart` ?,2017-03-22 13:28:53
+362,"@@ -250,33 +250,38 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+ 		const hideWidget = (mode === Mode.OPEN);
+ 
++		let sideBySide;
+ 		if (mode === Mode.OPEN || mode === Mode.OPEN_IN_BACKGROUND) {
+-			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-
+-			let openInBackgroundOptions: IEditorOptions;
+-			if (mode === Mode.OPEN_IN_BACKGROUND) {
+-				openInBackgroundOptions = { pinned: true, preserveFocus: true };
+-			}
++			sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
++		}
+ 
+-			let input = this.getInput();
+-			if (input instanceof EditorInput) {
+-				let opts = this.getOptions();
+-				if (opts) {
+-					opts.mixin(openInBackgroundOptions);
+-				} else if (openInBackgroundOptions) {
+-					opts = EditorOptions.create(openInBackgroundOptions);
+-				}
++		let modeOverrideOptions: IEditorOptions;
++		if (mode === Mode.PREVIEW) {
++			modeOverrideOptions = { forcePreview: true };
++		}","@wprater style `} else {`
+",2016-10-21 09:56:35
+363,"@@ -250,33 +250,38 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+ 		const hideWidget = (mode === Mode.OPEN);
+ 
++		let sideBySide;
+ 		if (mode === Mode.OPEN || mode === Mode.OPEN_IN_BACKGROUND) {
+-			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-
+-			let openInBackgroundOptions: IEditorOptions;
+-			if (mode === Mode.OPEN_IN_BACKGROUND) {
+-				openInBackgroundOptions = { pinned: true, preserveFocus: true };
+-			}
++			sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
++		}
+ 
+-			let input = this.getInput();
+-			if (input instanceof EditorInput) {
+-				let opts = this.getOptions();
+-				if (opts) {
+-					opts.mixin(openInBackgroundOptions);
+-				} else if (openInBackgroundOptions) {
+-					opts = EditorOptions.create(openInBackgroundOptions);
+-				}
++		let modeOverrideOptions: IEditorOptions;
++		if (mode === Mode.PREVIEW) {
++			modeOverrideOptions = { forcePreview: true };
++		}
++		else if (mode === Mode.OPEN_IN_BACKGROUND) {
++			modeOverrideOptions = { forcePreview: false, pinned: true, preserveFocus: true };","@wprater you do not need `forcePreview: false` here imho
+",2016-10-21 09:57:18
+364,"@@ -250,33 +250,38 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+ 		const hideWidget = (mode === Mode.OPEN);
+ 
++		let sideBySide;
+ 		if (mode === Mode.OPEN || mode === Mode.OPEN_IN_BACKGROUND) {
+-			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-
+-			let openInBackgroundOptions: IEditorOptions;
+-			if (mode === Mode.OPEN_IN_BACKGROUND) {
+-				openInBackgroundOptions = { pinned: true, preserveFocus: true };
+-			}
++			sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
++		}
+ 
+-			let input = this.getInput();
+-			if (input instanceof EditorInput) {
+-				let opts = this.getOptions();
+-				if (opts) {
+-					opts.mixin(openInBackgroundOptions);
+-				} else if (openInBackgroundOptions) {
+-					opts = EditorOptions.create(openInBackgroundOptions);
+-				}
++		let modeOverrideOptions: IEditorOptions;
++		if (mode === Mode.PREVIEW) {
++			modeOverrideOptions = { forcePreview: true };
++		}
++		else if (mode === Mode.OPEN_IN_BACKGROUND) {
++			modeOverrideOptions = { forcePreview: false, pinned: true, preserveFocus: true };
++		}
+ 
+-				this.editorService.openEditor(input, opts, sideBySide).done(null, errors.onUnexpectedError);
+-			} else {
+-				const resourceInput = <IResourceInput>input;
++		let input = this.getInput();
++		if (input instanceof EditorInput) {
++			let opts = this.getOptions();
++			if (opts) {
++				opts.mixin(modeOverrideOptions);
++			} else if (modeOverrideOptions) {
++				opts = EditorOptions.create(modeOverrideOptions);
++			}
+ 
+-				if (openInBackgroundOptions) {
+-					resourceInput.options = objects.assign(resourceInput.options || Object.create(null), openInBackgroundOptions);
+-				}
++			this.editorService.openEditor(input, opts, sideBySide).done(null, errors.onUnexpectedError);
++		}","@wprater style `} else {`
+",2016-10-21 09:57:57
+453,"@@ -250,35 +256,53 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+ 		const hideWidget = (mode === Mode.OPEN);
+ 
++		let sideBySide;
+ 		if (mode === Mode.OPEN || mode === Mode.OPEN_IN_BACKGROUND) {
+-			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-
+-			let openInBackgroundOptions: IEditorOptions;
+-			if (mode === Mode.OPEN_IN_BACKGROUND) {
+-				openInBackgroundOptions = { pinned: true, preserveFocus: true };
+-			}
++			sideBySide = !context.quickNavigateConfiguration && context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;","@wprater any particular reason you added the extra `!context.quickNavigateConfiguration` check here?
+",2016-11-05 07:33:24
+454,"@@ -250,35 +256,53 @@ export class EditorQuickOpenEntry extends QuickOpenEntry implements IEditorQuick
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+ 		const hideWidget = (mode === Mode.OPEN);
+ 
++		let sideBySide;
+ 		if (mode === Mode.OPEN || mode === Mode.OPEN_IN_BACKGROUND) {
+-			let sideBySide = context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
+-
+-			let openInBackgroundOptions: IEditorOptions;
+-			if (mode === Mode.OPEN_IN_BACKGROUND) {
+-				openInBackgroundOptions = { pinned: true, preserveFocus: true };
+-			}
++			sideBySide = !context.quickNavigateConfiguration && context.keymods.indexOf(KeyMod.CtrlCmd) >= 0;
++		}
+ 
+-			let input = this.getInput();
+-			if (input instanceof EditorInput) {
+-				let opts = this.getOptions();
+-				if (opts) {
+-					opts = objects.mixin(opts, openInBackgroundOptions, true);
+-				} else if (openInBackgroundOptions) {
+-					opts = EditorOptions.create(openInBackgroundOptions);
+-				}
++		let pinned;","@wprater why do we need pinned here? first of all it does not seem to be used when the mode is `Mode.OPEN`. And then I think the editor part itself is already dealing with the setting `workbench.editor.enablePreviewFromQuickOpen`?
+",2016-11-05 07:34:37
+281,"@@ -250,6 +254,7 @@ export class ExtensionEditor extends BaseEditor {
+ 		this.navbar.onChange(this.onNavbarChange.bind(this, extension), this, this.transientDisposables);
+ 		this.navbar.push(NavbarSection.Readme, localize('details', ""Details""));
+ 		this.navbar.push(NavbarSection.Contributions, localize('contributions', ""Contributions""));
++		this.navbar.push(NavbarSection.Changelog, localize('changelog', ""Changelog""));","I'd like to show the Changelog section only if there is actually a Changelog to show.
+
+You can add a `hasChangelog(): boolean` method to `IExtension` that will let you know this synchronously.
+",2016-09-15 07:08:02
+94,"@@ -253,7 +255,11 @@ function setupIPC(): TPromise<Server> {
+ // and assign them to the process environment (e.g. when doubleclick app on Mac)
+ getUserEnvironment()
+ 	.then(userEnv => {
+-		assign(process.env, userEnv);
++		if (!tty.isatty(1)) {
++			// Only assign global environment variables when
++			// STDOUT is not attached to terminal.
++			assign(process.env, userEnv);","Instead of testing if vscode is run from terminal, different `assign` method could be used. Maybe:
+
+``` js
+assign(userEnv, process.env); // session's envvar trumps login shell's envvar
+process.env = userEnv;
+```
+",2016-03-30 12:46:12
+716,"@@ -255,6 +255,18 @@ export function createApiFactory(initData: IInitData, threadService: IThreadServ
+ 			}
+ 		};
+ 
++		const emptyMessageOptions: vscode.MessageOptions = Object.create(null);
++
++		function parseMessageArguments(args: any[]): { options: vscode.MessageOptions; items: any[]; } {
++			const [first, ...rest] = args;
++
++			if (first && (typeof first === 'string' || first.title)) {",What if `first === ''`? The first check would fail even though it is a `string`,2017-02-02 15:57:04
+718,"@@ -255,6 +255,18 @@ export function createApiFactory(initData: IInitData, threadService: IThreadServ
+ 			}
+ 		};
+ 
++		const emptyMessageOptions: vscode.MessageOptions = Object.create(null);
++
++		function parseMessageArguments(args: any[]): { options: vscode.MessageOptions; items: any[]; } {
++			const [first, ...rest] = args;
++
++			if (typeof first === 'string' || (first && first.title)) {
++				return { options: emptyMessageOptions, items: args };
++			} else {
++				return { options: first || emptyMessageOptions, items: rest };
++			}
++		}","I like the code but I don't like that it is placed here. Instead I'd propose to move it into the `extHostMessageService` and make its `showMessage`-function like: `showMessage(sev, message, optionOrFirstItem, ...restItem)`. That would encapsulate things better IMO",2017-02-02 16:45:53
+483,"@@ -257,20 +266,33 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 			else {
+ 				diag('load() - created text editor model', this.resource, new Date());
+ 
+-				this.createTextEditorModelPromise = this.createTextEditorModel(content.value, content.resource).then(() => {
+-					this.createTextEditorModelPromise = null;
++				return this.backupFileService.doesTextFileHaveBackup(this.resource).then(backupExists => {
++					let getContentPromise: TPromise<IRawText>;
++					if (backupExists) {
++						const restoreResource = this.backupFileService.getBackupResource(this.resource);
++						const restoreOptions = { acceptTextOnly: true, encoding: 'utf-8' };
++						getContentPromise = this.textFileService.resolveTextContent(restoreResource, restoreOptions).then(content => content.value);","@Tyriar if something goes wrong loading that backup, a user will never be able again to open the file. I think a safe guard should be added to fall back to the content from disk. 
+",2016-11-09 08:02:23
+211,"@@ -257,4 +260,13 @@ export class TerminalService implements ITerminalService {
+ 		});
+ 		return newEnv;
+ 	}
++
++	private getLang(locale: string) {","Can you rename to `getLangEnvVariable` for clarity as to its purpose?
+",2016-07-08 23:01:59
+354,"@@ -257,6 +264,12 @@ export abstract class ExtHostEditorsShape {
+ 	$acceptTextEditorRemove(id: string): void { throw ni(); }
+ }
+ 
++export abstract class ExtHostTreeExplorersShape {","Since `InternalTreeExplorerNode` is a class I won't send it over the wire. JSON serialisation will drop the prototype, functions etc
+",2016-10-21 07:43:31
+616,"@@ -258,15 +258,21 @@ export class ElectronWindow {
+ 
+ 		// High Contrast Events
+ 		ipc.on('vscode:enterHighContrast', (event) => {
+-			this.partService.joinCreation().then(() => {
+-				this.themeService.setColorTheme(VS_HC_THEME, false);
+-			});
++			const windowConfig = this.configurationService.getConfiguration<IWindowSettings>('window');
++			if (windowConfig.autoDetectHighContrast) {",`windowConfig` can be null,2016-12-16 14:14:29
+617,"@@ -258,15 +258,21 @@ export class ElectronWindow {
+ 
+ 		// High Contrast Events
+ 		ipc.on('vscode:enterHighContrast', (event) => {
+-			this.partService.joinCreation().then(() => {
+-				this.themeService.setColorTheme(VS_HC_THEME, false);
+-			});
++			const windowConfig = this.configurationService.getConfiguration<IWindowSettings>('window');
++			if (windowConfig.autoDetectHighContrast) {
++				this.partService.joinCreation().then(() => {
++					this.themeService.setColorTheme(VS_HC_THEME, false);
++				});
++			}
+ 		});
+ 
+ 		ipc.on('vscode:leaveHighContrast', (event) => {
+-			this.partService.joinCreation().then(() => {
+-				this.themeService.setColorTheme(VS_DARK_THEME, false);
+-			});
++			const windowConfig = this.configurationService.getConfiguration<IWindowSettings>('window');","I think we can ignore the setting in this case because leaving HC on Windows you want to switch back to dark theme. Or otherwise the setting should be clearer that it prevents switching in both ways, not just from normal to HC theme.",2016-12-16 14:15:05
+575,"@@ -26,12 +26,16 @@ import { IContextKeyService, IContextKey } from 'vs/platform/contextkey/common/c
+ import { IContextMenuService } from 'vs/platform/contextview/browser/contextView';
+ import { DebugHoverWidget } from 'vs/workbench/parts/debug/electron-browser/debugHover';
+ import { RemoveBreakpointAction, EditConditionalBreakpointAction, ToggleEnablementAction, AddConditionalBreakpointAction } from 'vs/workbench/parts/debug/browser/debugActions';
+-import { IDebugEditorContribution, IDebugService, State, IBreakpoint, EDITOR_CONTRIBUTION_ID, CONTEXT_BREAKPOINT_WIDGET_VISIBLE } from 'vs/workbench/parts/debug/common/debug';
++import { IDebugEditorContribution, IDebugService, State, IBreakpoint, EDITOR_CONTRIBUTION_ID, CONTEXT_BREAKPOINT_WIDGET_VISIBLE, IStackFrame } from 'vs/workbench/parts/debug/common/debug';
+ import { BreakpointWidget } from 'vs/workbench/parts/debug/browser/breakpointWidget';
+ import { FloatingClickWidget } from 'vs/workbench/parts/preferences/browser/preferencesWidgets';
++import { getNameValueMapFromScopeChildren, getDecorators, getEditorWordRangeMap } from 'vs/workbench/parts/debug/electron-browser/debugInlineDecorators';
++import { IStringDictionary } from 'vs/base/common/collections';","We try to sort imports by first base, editor and at the end workbench.",2016-12-05 14:52:18
+324,"@@ -26,6 +26,7 @@ import { IEnvironmentService } from 'vs/platform/environment/common/environment'
+ import { IEditorGroupService } from 'vs/workbench/services/group/common/groupService';","Can these methods live in ITextFileService and implementation?
+",2016-10-13 15:16:24
+277,"@@ -260,11 +265,12 @@ export class ExtensionEditor extends BaseEditor {
+ 		switch (id) {
+ 			case NavbarSection.Readme: return this.openReadme(extension);
+ 			case NavbarSection.Contributions: return this.openContributions(extension);
++			case NavbarSection.Changelog: return this.openChangelog(extension);
+ 		}
+ 	}
+ 
+-	private openReadme(extension: IExtension) {
+-		return this.loadContents(() => this.extensionReadme.get()
++	private openMarkdown(extension: IExtension, content: TPromise<string>, noContentCopy: string) {","Given that readme and changelog are basically the same file, I've generalised the function so it can be used from both sides.
+",2016-09-14 17:04:22
+894,"@@ -261,17 +273,15 @@ export abstract class EmmetEditorAction extends EditorAction {
+ 
+ export class BasicEmmetEditorAction extends EmmetEditorAction {
+ 
+-	private emmetActionName: string;
+-
+ 	constructor(id: string, label: string, alias: string, actionName: string, kbOpts?: ICommandKeybindingsOptions) {
+ 		super({
+ 			id: id,
+ 			label: label,
+ 			alias: alias,
+ 			precondition: EditorContextKeys.Writable,
+-			kbOpts: kbOpts
++			kbOpts: kbOpts,
++			actionName: actionName","We can use here ES2015 object destructuring for `id`, `label`, `alias`, `kbOpts`, `actionName`? ",2017-04-18 07:13:36
+118,"@@ -264,6 +268,16 @@ export function match(arg1: string | IExpression, path: string, siblings?: strin
+ 
+ 	// Glob with String
+ 	if (typeof arg1 === 'string') {
++
++		if (trivia1.test(arg1)) {
++			// common pattern: **/*.txt just need endsWith check
++			return strings.endsWith(path, arg1.substr(4)); // '**/*'.length === 4","you are assuming that most of these patterns have 3 letters in file type, but we know that it is not always the case, like `.js`, `.ts`. Better will be to actually get the match
+
+```
+const trivia1 = /^\*\*\/\*(\.\w+)$/;
+
+if ((let t1match = trivia1.match(arg1)) != null) {
+    return strings.endsWith(path, t2match[1]);
+}
+```
+",2016-04-20 13:31:35
+306,"@@ -265,4 +266,33 @@ class MDDocumentContentProvider implements TextDocumentContentProvider {
+ 			}, 300);
+ 		}
+ 	}
++}
++
++class DocumentHeadingsProvider implements vscode.DocumentSymbolProvider {
++
++	// http://daringfireball.net/projects/markdown/syntax#header
++	private static _atxPattern = /^(#){1,6}\s+.+(\s+\1)?/;","On the regex:
+- Strip out any number of trailing `#`s at the end of the line. This does not have to match the number at the start: http://spec.commonmark.org/0.26/#example-42
+- Match end of line too, to handle weird cases like `# a # a #`
+- Strip out whitespace around the header text itself for the displayed symbol.
+
+Something like: `^(#{1,6})\s+(.+?)\s*#*\s*$` and use these two captures to build up the symbol
+",2016-10-05 18:05:17
+307,"@@ -265,4 +266,33 @@ class MDDocumentContentProvider implements TextDocumentContentProvider {
+ 			}, 300);
+ 		}
+ 	}
++}
++
++class DocumentHeadingsProvider implements vscode.DocumentSymbolProvider {
++
++	// http://daringfireball.net/projects/markdown/syntax#header
++	private static _atxPattern = /^(#){1,6}\s+.+(\s+\1)?/;
++	private static _settext = /^\s*[-=]+\s*$/;","Make sure to also test that this does not pick up separators
+",2016-10-05 18:07:34
+344,"@@ -267,4 +267,4 @@ export class AllEditorsPicker extends BaseEditorPicker {
+ 
+ 		return super.getAutoFocus(searchValue);
+ 	}
+-}","@bpasero sorry about the newlines.  I can rebase them out. should we add `""files.insertFinalNewline"": false` to workspace settings or `.editorconfig` ?
+",2016-10-19 01:26:27
+365,"@@ -267,7 +271,7 @@ export class QuickOpenController extends WorkbenchComponent implements IQuickOpe
+ 				withElementById(this.partService.getWorkbenchElementId()).getHTMLElement(),
+ 				{
+ 					onOk: () => { /* ignore, handle later */ },
+-					onCancel: () => { /* ignore, handle later */ },
++					onCancel: () => this.handleOnCancel(true),","@wprater careful, this is being overridden later in a `setCallbacks()` call, so you have to do it there for the picker.
+",2016-10-21 09:59:51
+556,"@@ -268,6 +268,28 @@ export class SearchService implements IRawSearchService {
+ 		});
+ 	}
+ 
++	private doSearchWithBatchTimeout(engine: ISearchEngine<ISerializedFileMatch>, batchSize: number): PPromise<ISerializedSearchComplete, IRawProgressItem<ISerializedFileMatch>> {
++		return new PPromise<ISerializedSearchComplete, IRawProgressItem<ISerializedFileMatch>>((c, e, p) => {
++			// Use BatchedCollector to get new results to the frontend every 2s at least, until 50 results have been returned
++			const collector = new BatchedCollector(batchSize, /*timeout=*/2000, /*batchOnlyAfter=*/50, p);",I think 2s is a long time. What about using 500ms initially and after 5s start using a timeout of 2s? That would ensure that the first results are show quickly and that progress is visible even for very long running searches.,2016-12-01 18:55:54
+752,"@@ -269,11 +269,11 @@ class MarkerNavigationWidget extends ZoneWidget {
+ 			// update frame color (only applied on 'show')
+ 			switch (marker.severity) {
+ 				case Severity.Error:
+-					this.options.frameColor = '#ff5a5a';
++					this._container.parentElement.classList.add('marker-error-widget');","Make sure to remove the warning class in this case, same as when you add a warning class remove the error class",2017-02-20 14:01:17
+910,"@@ -27,6 +27,11 @@
+ 	margin-top: 0.5em;
+ }
+ ",Makes sense,2017-05-05 09:44:13
+145,"@@ -27,8 +27,10 @@
+     ""iconv-lite"": ""0.4.13"",
+     ""minimist"": ""^1.2.0"",
+     ""native-keymap"": ""0.1.2"",
++    ""pty.js"": ""git+https://github.com/jeremyramin/pty.js.git#28f2667"",
+     ""sax"": ""1.1.2"",","@bpasero You raised concerns about NAN versions but those packages are prebuilt so it shouldn't be a problem, right?
+",2016-05-02 11:01:50
+659,"@@ -274,31 +269,20 @@ export class TabsTitleControl extends TitleControl {
+ 			labels.push(item);
+ 
+ 			mapLabelToDuplicates.getOrSet(item.name, []).push(item);
+-			if (item.description) {
+-				mapLabelAndDescriptionToDuplicates.getOrSet(item.name + item.description, []).push(item);
+-			}
+ 		});
+ 
+-		// Mark label duplicates
++		// Mark duplicates and shorten their descriptions
+ 		const labelDuplicates = mapLabelToDuplicates.values();
+ 		labelDuplicates.forEach(duplicates => {
+ 			if (duplicates.length > 1) {
+-				duplicates.forEach(duplicate => {
++				var shortenedDescriptions = paths.shorten(duplicates.map(duplicate => duplicate.editor.getDescription()));",`var` => `const`,2017-01-10 05:45:04
+470,"@@ -275,7 +282,14 @@ export class Workbench implements IPartService {
+ 
+ 					editorOpenPromise = this.editorPart.openEditors(editors);
+ 				} else {
+-					editorOpenPromise = this.editorPart.restoreEditors();
++					if (this.workbenchParams.options.untitledToRestore && this.workbenchParams.options.untitledToRestore.length) {","@Tyriar something is very broken here in this case:
+- have a window with a folder open that has a dirty untitled file
+- close that window without saving
+- from the command line start `code <path to that folder> <file in that folder>`
+  => you are not seeing the file being opened 
+  => instead the dirty untitled file is opened
+
+This is related to the comment I made in that one issue where I said that your restore logic will not work if someone opens Code like that.
+",2016-11-09 07:37:47
+941,"@@ -277,10 +285,12 @@ export default class PHPValidationProvider {
+ 				// Shell args
+ 				let executableArgs = args.slice(0);
+ 
+-				// Transform Windows file path to Linux file path
+-				let windowsPath = executableArgs.pop();
+-				let linuxPath = windowsPath.trim().replace(/^([a-zA-Z]):\\/, '/mnt/$1/').replace(/\\/g, '/');
+-				executableArgs.push(linuxPath);
++				// If win32 and bash.exe, transform Windows file path to Linux file path
++				if (this.platform === 'win32' && executable.indexOf('bash.exe') !== -1) {",We can't simply test bash.exe here since git under Window installs a bash.exe as well. We either need to test for the full path or better see how bash from git mount the drive and do the path magic as well.,2017-05-18 08:29:09
+473,"@@ -28,10 +28,14 @@ import pfs = require('vs/base/node/pfs');
+ import encoding = require('vs/base/node/encoding');
+ import mime = require('vs/base/node/mime');
+ import flow = require('vs/base/node/flow');
++import { IDisposable, dispose } from 'vs/base/common/lifecycle';
+ import { FileWatcher as UnixWatcherService } from 'vs/workbench/services/files/node/watcher/unix/watcherService';
+ import { FileWatcher as WindowsWatcherService } from 'vs/workbench/services/files/node/watcher/win32/watcherService';
+ import { toFileChangesEvent, normalize, IRawFileChange } from 'vs/workbench/services/files/node/watcher/common';
+ import { IEventService } from 'vs/platform/event/common/event';
++import { IEnvironmentService } from 'vs/platform/environment/common/environment';","@Tyriar this file contains changes that do NOT seem to be needed after all
+",2016-11-09 07:41:07
+323,"@@ -28,10 +28,16 @@ import pfs = require('vs/base/node/pfs');
+ import encoding = require('vs/base/node/encoding');","Can these methods live in ITextFileService and implementation?
+",2016-10-13 15:16:12
+685,"@@ -28,34 +29,74 @@ export class Adapter {
+ 		}
+ 	}
+ 
+-	public get runtime(): string {
++	public getAdapterExecutable(verifyAgainstFS = true): TPromise<IAdapterExecutable> {
++
++		if (this.rawAdapter.adapterExecutableCommand) {
++			return this.commandService.executeCommand<IAdapterExecutable>(this.rawAdapter.adapterExecutableCommand).then(ad => {
++				return this.verifyAdapterDetails(ad, verifyAgainstFS);
++			});
++		}
++
++		const ad = <IAdapterExecutable>{","ad is a wrong acronym here, I suspect this was previously IAdapterDetails",2017-01-18 14:06:50
+688,"@@ -28,34 +29,74 @@ export class Adapter {
+ 		}
+ 	}
+ 
+-	public get runtime(): string {
++	public getAdapterExecutable(verifyAgainstFS = true): TPromise<IAdapterExecutable> {
++
++		if (this.rawAdapter.adapterExecutableCommand) {
++			return this.commandService.executeCommand<IAdapterExecutable>(this.rawAdapter.adapterExecutableCommand).then(ad => {
++				return this.verifyAdapterDetails(ad, verifyAgainstFS);
++			});
++		}
++
++		const ad = <IAdapterExecutable>{
++			command: this.getProgram(),
++			args: this.getAttributeBasedOnPlatform('args')
++		};
++		const runtime = this.getRuntime();
++		if (runtime) {
++			const runtimeArgs = this.getAttributeBasedOnPlatform('runtimeArgs');
++			ad.args = (runtimeArgs || []).concat([ad.command]).concat(ad.args || []);
++			ad.command = runtime;
++		}
++		return this.verifyAdapterDetails(ad, verifyAgainstFS);
++	}
++","It feels to me like `verifyAgainstFS` should not be passed to this method, but if that is `false` this method should simply not be called.",2017-01-18 14:13:53
+425,"@@ -280,6 +287,12 @@ export abstract class ExtHostEditorsShape {
+ 	$acceptTextEditorRemove(id: string): void { throw ni(); }
+ }
+ 
++export abstract class ExtHostTreeExplorersShape {
++	$provideRootNode(providerId: string): TPromise<InternalTreeExplorerNode> { throw ni(); };
++	$resolveChildren(providerId: string, node: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]> { throw ni(); }","As mentioned above, instead of `MainThreadTreeExplorersShape.$showMessage` return a rejected promise from this call and handle the promise (rejected/resolved) in the main side. 
+",2016-11-01 09:45:26
+426,"@@ -280,6 +287,12 @@ export abstract class ExtHostEditorsShape {
+ 	$acceptTextEditorRemove(id: string): void { throw ni(); }
+ }
+ 
++export abstract class ExtHostTreeExplorersShape {
++	$provideRootNode(providerId: string): TPromise<InternalTreeExplorerNode> { throw ni(); };
++	$resolveChildren(providerId: string, node: InternalTreeExplorerNode): TPromise<InternalTreeExplorerNode[]> { throw ni(); }
++	$executeCommand(providerId: string, node: InternalTreeExplorerNode): TPromise<void> { throw ni(); }","[needs change] Related to `MainThreadTreeExplorersShape.$showMessage` - Remove this, because it duplicates functionality and also supports extension host side commands only. The on main side, implement this by calling [`ICommandService#executeCommand`]('https://github.com/Microsoft/vscode/blob/master/src/vs/platform/commands/common/commands.ts#L16').
+
+To preserve the semantics wrt to the node bing the command argument, make sure to use `modes.ICommand`, the [`CommandConverter`](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/extHostCommands.ts#L45), and the node as argument
+",2016-11-01 09:47:43
+594,"@@ -281,13 +298,36 @@ class MDDocumentContentProvider implements vscode.TextDocumentContentProvider {
+ 			}, 300);
+ 		}
+ 	}
++}
++
++class MDDocumentSymbolProvider implements vscode.DocumentSymbolProvider {
++
++	constructor(private markdownIt: MarkdownIt) { }
+ 
+-	private getDocumentContentForPreview(document: vscode.TextDocument): string {
+-		const content = document.getText();
+-		const previewFrontMatter = vscode.workspace.getConfiguration('markdown')['previewFrontMatter'];
+-		if (previewFrontMatter === 'hide') {
+-			return content.replace(/^-{3}[ \t]*(\r\n|\n)(.|\r\n|\n)*?(\r\n|\n)-{3}[ \t]*(\r\n|\n)/, '');
++	provideDocumentSymbols(document: vscode.TextDocument): vscode.ProviderResult<vscode.SymbolInformation[]> {
++		let offset = 0;
++		let text = document.getText();
++		const frontMatterMatch = FrontMatterRegex.exec(text);
++
++		if (frontMatterMatch) {
++			const frontMatter = frontMatterMatch[0];
++
++			offset = frontMatter.split(/\r\n|\n|\r/g).length - 1;
++			text = text.substr(frontMatter.length);
+ 		}
+-		return content;
++
++		const tokens = this.markdownIt.parse(text);
++		const headings = tokens.filter(token => token.type === 'heading_open');
++
++		const symbols = headings.map(heading => {
++			const lineNumber = heading.map[0];
++			const line = document.lineAt(lineNumber + offset);
++			const location = new vscode.Location(document.uri, line.range);
++			const text = line.text.replace(/^\s*#+\s*/, '');","In order to handle headings such as `# a #`, perform the same replacement backwards on the end of the string too (the number of leading `#` does not have to match the number of trailing `#`)",2016-12-09 20:03:50
+278,"@@ -282,10 +288,18 @@ export class ExtensionEditor extends BaseEditor {
+ 			})
+ 			.then(null, () => {
+ 				const p = append(this.content, $('p'));
+-				p.textContent = localize('noReadme', ""No README available."");
++				p.textContent = noContentCopy;
+ 			}));
+ 	}
+ 
++	private openReadme(extension: IExtension) {
++		return this.openMarkdown(extension, this.extensionReadme.get(), localize('noReadme', ""No README available.""));","I do not know how expansive is to call `localize`
+If it's a lot, we could probably use `localize.bind(this, 'noReadme', ""No README available."")` and use the new returned function only if it's necessary. What's your opinion?
+",2016-09-14 17:05:18
+279,"@@ -282,10 +288,18 @@ export class ExtensionEditor extends BaseEditor {
+ 			})
+ 			.then(null, () => {
+ 				const p = append(this.content, $('p'));
+-				p.textContent = localize('noReadme', ""No README available."");
++				p.textContent = noContentCopy;
+ 			}));
+ 	}
+ 
++	private openReadme(extension: IExtension) {
++		return this.openMarkdown(extension, this.extensionReadme.get(), localize('noReadme', ""No README available.""));
++	}
++
++	private openChangelog(extension : IExtension) {
++		return this.openMarkdown(extension, this.extensionChangelog.get(), localize('noChangelog', ""No CHANGELOG available.""));","Where should I go to provide localisation for this new introduced string?
+",2016-09-14 17:05:32
+64,"@@ -282,7 +284,15 @@ export class DebugService extends ee.EventEmitter implements debug.IDebugService
+ 
+ 		this.toDispose.push(this.session.addListener2(debug.SessionEvents.OUTPUT, (event: DebugProtocol.OutputEvent) => {
+ 			if (event.body && event.body.category === 'telemetry') {
+-				this.telemetryService.publicLog(event.body.output, event.body.data);
++				const key = this.configurationManager.getAdapter().aiKey;
++				// only log telemetry events from debug adapter if the adapter provided the telemetry key
++				if (key) {
++					if (!this.telemetryAdapter) {
++						this.telemetryAdapter = new AIAdapter(key, this.session.getType());","we need here to append common vscode properties such as machineId and sessionId, I will go ahead and merge this and then push a fix for that
+",2016-02-16 20:30:33
+714,"@@ -284,10 +284,69 @@ export class PeekImplementationAction extends DefinitionAction {
+ 	}
+ 
+ 	protected getDeclarationsAtPosition(model: editorCommon.IModel, position: corePosition.Position): TPromise<Location[]> {
+-		return getImplementationAtPosition(model, position);
++		return getImplementationsAtPosition(model, position);
+ 	}
+ }
+ 
++@editorAction
++export class GoToTypeDefintionAction extends DefinitionAction {
++
++	public static ID = 'editor.action.goToTypeDefinition';
++
++	constructor() {
++		super(new DefinitionActionConfig(), {
++			id: GoToTypeDefintionAction.ID,
++			label: nls.localize('actions.goToTypeDefinition.label', ""Go to Type Definition""),
++			alias: 'Go to Type Definition',
++			precondition: ContextKeyExpr.and(
++				ModeContextKeys.hasTypeDefinitionProvider,
++				ModeContextKeys.isInEmbeddedEditor.toNegated()),
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: 0
++			},
++			menuOpts: {
++				group: 'navigation',
++				order: 1.3
++			}
++		});
++	}
++
++	protected getDeclarationsAtPosition(model: editorCommon.IModel, position: corePosition.Position): TPromise<Location[]> {
++		return getTypeDefinitionsAtPosition(model, position);
++	}
++}
++
++@editorAction
++export class PeekTypeDefinitionAction extends DefinitionAction {
++
++	public static ID = 'editor.action.peekTypeDefinition';
++
++	constructor() {
++		super(new DefinitionActionConfig(false, true, false), {
++			id: PeekTypeDefinitionAction.ID,
++			label: nls.localize('actions.peekTypeDefinition.label', ""Peek Type Definition""),
++			alias: 'Peek Type Definition',
++			precondition: ContextKeyExpr.and(
++				ModeContextKeys.hasTypeDefinitionProvider,
++				ModeContextKeys.isInEmbeddedEditor.toNegated()),
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: 0
++			},
++			menuOpts: {
++				group: 'navigation',
++				order: 1.3",The `order` collides with the one above with means lex sort is applied which means order changes from language to language,2017-02-02 08:01:57
+715,"@@ -284,10 +284,69 @@ export class PeekImplementationAction extends DefinitionAction {
+ 	}
+ 
+ 	protected getDeclarationsAtPosition(model: editorCommon.IModel, position: corePosition.Position): TPromise<Location[]> {
+-		return getImplementationAtPosition(model, position);
++		return getImplementationsAtPosition(model, position);
+ 	}
+ }
+ 
++@editorAction
++export class GoToTypeDefintionAction extends DefinitionAction {
++
++	public static ID = 'editor.action.goToTypeDefinition';
++
++	constructor() {
++		super(new DefinitionActionConfig(), {
++			id: GoToTypeDefintionAction.ID,
++			label: nls.localize('actions.goToTypeDefinition.label', ""Go to Type Definition""),
++			alias: 'Go to Type Definition',
++			precondition: ContextKeyExpr.and(
++				ModeContextKeys.hasTypeDefinitionProvider,
++				ModeContextKeys.isInEmbeddedEditor.toNegated()),
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: 0
++			},
++			menuOpts: {
++				group: 'navigation',
++				order: 1.3
++			}
++		});
++	}
++
++	protected getDeclarationsAtPosition(model: editorCommon.IModel, position: corePosition.Position): TPromise<Location[]> {
++		return getTypeDefinitionsAtPosition(model, position);
++	}
++}
++
++@editorAction
++export class PeekTypeDefinitionAction extends DefinitionAction {
++
++	public static ID = 'editor.action.peekTypeDefinition';
++
++	constructor() {
++		super(new DefinitionActionConfig(false, true, false), {
++			id: PeekTypeDefinitionAction.ID,
++			label: nls.localize('actions.peekTypeDefinition.label', ""Peek Type Definition""),
++			alias: 'Peek Type Definition',
++			precondition: ContextKeyExpr.and(
++				ModeContextKeys.hasTypeDefinitionProvider,
++				ModeContextKeys.isInEmbeddedEditor.toNegated()),
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: 0
++			},
++			menuOpts: {
++				group: 'navigation',
++				order: 1.3
++			}","In general we need to revisit the context menu because now it becomes more and more loaded. We will now have
+
+* Find References
+* Go to Definition
+* Peek Definition
+* Go to Implementation
+* Peek Implementation
+* Go to Type Definition
+* Peek Type Definition
+
+which I think is a little messy already",2017-02-02 08:03:49
+120,"@@ -287,12 +287,16 @@ export class ConfigurationManager implements debug.IConfigurationManager {
+ 				return null;
+ 			}
+ 
+-			return this.massageInitialConfigurations(adapter).then(() =>
+-				JSON.stringify({
+-					version: '0.2.0',
+-					configurations: adapter.initialConfigurations ? adapter.initialConfigurations : []
+-				}, null, '\t')
+-			);
++			return this.massageInitialConfigurations(adapter).then(() => {
++				let editorConfig = this.configurationService.getConfiguration<any>();
++				return JSON.stringify(
++					{
++						version: '0.2.0',
++						configurations: adapter.initialConfigurations ? adapter.initialConfigurations : []
++					},
++					null,
++					editorConfig.insertSpaces ? strings.repeat(' ', editorConfig.tabSize) : '\t');","editorConfig.insertSpaces => editorConfig.editor.insertSpaces
+
+Note: you can also do this.configurationService.getConfiguration<any>('editor') instead.
+",2016-04-21 07:16:41
+154,"@@ -288,6 +299,27 @@ export class Scanner {
+ 		if (tokenType !== null) {
+ 			return this.finishToken(offset, tokenType);
+ 		}
++
++		// css variable name --identifier followed by ':' or ')'
++		if (this.stream.advanceIfChars([_MIN, _MIN])) {
++			let content: string[] = ['-', '-'] ;
++			if (this.ident(content)) {
++				let nextChar= this.stream.peekNextChar([_WSP, _TAB, _NWL, _CAR]);
++				if (nextChar === _COL || nextChar === _RPA) {
++					return this.finishToken(offset, TokenType.CssVariableName, content.join(''));
++				}
++			}
++			this.stream.goBackTo(offset);
++		}
++
++		// var
++		if (this.stream.advanceIfChars([_v, _a, _r])) {","As mentioned, let's avoid a separate token for var.
+",2016-05-20 10:03:44
+383,"@@ -29,6 +29,7 @@ export interface IWindowCreationOptions {
+ 	state: IWindowState;
+ 	extensionDevelopmentPath?: string;
+ 	allowFullscreen?: boolean;
++	macOSUseInlineToolbar: boolean;","I am starting to think that we should make this more open ended because I also would like to have the option to have a custom dark title bar as a choice. This should be an enumeration with open ended values (e.g. default, inline, dark) so that we can continue with experiments.
+",2016-10-24 14:15:45
+734,"@@ -29,9 +29,12 @@ class ClipboardEventWrapper implements IClipboardEvent {
+ 		return false;
+ 	}
+ 
+-	public setTextData(text: string): void {
++	public setTextData(text: string, richText?: string): void {","I would use null for richText as a signal that it should not be set (instead of undefined + optional).
+
+IMHO null is a lot more clear and prevents bugs where we forget by accident to add a second argument....",2017-02-16 15:59:08
+531,"@@ -290,11 +290,14 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 				diag('load() - created text editor model', this.resource, new Date());
+ 
+ 				return this.backupFileService.loadBackupResource(this.resource).then(backupResource => {
+-					let resolveBackupPromise: TPromise<IRawText>;
++					let resolveBackupPromise: TPromise<string | IRawText>;
+ 
+ 					// Try get restore content, if there is an issue fallback silently to the original file's content
+ 					if (backupResource) {
+-						resolveBackupPromise = this.textFileService.resolveTextContent(backupResource, BACKUP_FILE_RESOLVE_OPTIONS).then(backup => backup.value, error => content.value);
++						resolveBackupPromise = this.textFileService.resolveTextContent(backupResource, BACKUP_FILE_RESOLVE_OPTIONS).then(backup => {","@Tyriar this is bad, what if we resolve the text content in another place? everyone has to remove the first line? why not move the entire thing into the backup service and thus have the logic in one place where it should be. We can even get rid of `loadBackupResource` and just have 1 method to call to resolve the backup content (which can be null if there is no backup).",2016-11-29 05:18:00
+939,"@@ -290,6 +290,25 @@ export function registerCommands(): void {
+ 	});
+ 
+ 	KeybindingsRegistry.registerCommandAndKeybindingRule({
++		id: 'list.selectAll',
++		weight: KeybindingsRegistry.WEIGHT.workbenchContrib(),
++		when: ListFocusContext,
++		primary: KeyMod.CtrlCmd | KeyCode.KEY_A,
++		handler: (accessor) => {
++			const listService = accessor.get(IListService);
++			const focused = listService.getFocused();
++
++			if (focused instanceof List) {
++				const list = focused;
++				if (list.length !== 0) {
++					list.setSelection(Array.apply(null, { length: list.length }).map(Function.call, Number));","We have a helper for creating arrays over a range of numbers, see `range` in src/vs/base/common/arrays.ts. ",2017-05-18 03:21:06
+938,"@@ -290,6 +290,25 @@ export function registerCommands(): void {
+ 	});
+ 
+ 	KeybindingsRegistry.registerCommandAndKeybindingRule({
++		id: 'list.selectAll',
++		weight: KeybindingsRegistry.WEIGHT.workbenchContrib(),
++		when: ListFocusContext,
++		primary: KeyMod.CtrlCmd | KeyCode.KEY_A,
++		handler: (accessor) => {
++			const listService = accessor.get(IListService);
++			const focused = listService.getFocused();
++
++			if (focused instanceof List) {
++				const list = focused;
++				if (list.length !== 0) {
++					list.setSelection(Array.apply(null, { length: list.length }).map(Function.call, Number));
++					list.focusFirst();",Can we keep the same element focused?,2017-05-18 03:10:51
+214,"@@ -2908,6 +2942,10 @@ export enum MouseTargetType {
+ 	 */
+ 	GUTTER_LINE_NUMBERS,
+ 	/**
++	 * Mouse is on top of the git blame annotation
++	 */
++	GUTTER_GIT_BLAME,","Layer breaker.
+",2016-07-11 09:02:20
+213,"@@ -294,7 +297,12 @@ export class MouseTargetFactory {
+ 
+ 		if (REGEX.IS_CHILD_OF_VIEW_OVERLAYS.test(path)) {
+ 			var offset = Math.abs(e.posx - editorContent.left);
++			if (offset <= layoutInfo.gitBlameWidth) {
++				// On the git blame annotation
++				return this.createMouseTargetFromGitBlame(t, mouseVerticalOffset, mouseColumn);","Layer breaker.
+",2016-07-11 09:01:42
+218,"@@ -294,8 +298,13 @@ export class MouseHandler extends ViewEventHandler implements IDisposable {
+ 		} else if (targetIsViewZone) {
+ 			let viewZoneData = <editorBrowser.IViewZoneData>t.detail;
+ 			if (this.viewHelper.shouldSuppressMouseDownOnViewZone(viewZoneData.viewZoneId)) {
++				focus();
++				this._mouseDownOperation.start(t.type, e);
+ 				e.preventDefault();
+ 			}
++		} else if (targetIsWidget && (<string>t.detail).indexOf('codeLensWidget') === 0) {","This is a layer breaker -- the editor core should not know about specific widgets. We perhaps need something similar to `shouldSuppressMouseDownOnViewZone` but with content widgets
+",2016-07-14 16:16:20
+758,"@@ -296,6 +305,47 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 		}
+ 	}
+ 
++	// exception widget",Why is this public?,2017-02-20 14:19:33
+761,"@@ -296,6 +305,47 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 		}
+ 	}
+ 
++	// exception widget
++	public toggleExceptionWidget(): void {
++		// Toggles exception widget based on the state of the current editor model and debug stack frame
++		const model = this.editor.getModel();
++		const focusedSf = this.debugService.getViewModel().focusedStackFrame;
++		const callStack = focusedSf ? focusedSf.thread.getCallStack() : null;
++		if (!model || !focusedSf || !callStack) {
++			this.closeExceptionWidget();
++			return;
++		}
++
++		// First call stack frame is the frame where exception has been thrown",Callstack can be an empty array in some corner cases,2017-02-20 14:29:12
+759,"@@ -296,6 +305,47 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 		}
+ 	}
+ 
++	// exception widget
++	public toggleExceptionWidget(): void {
++		// Toggles exception widget based on the state of the current editor model and debug stack frame
++		const model = this.editor.getModel();
++		const focusedSf = this.debugService.getViewModel().focusedStackFrame;
++		const callStack = focusedSf ? focusedSf.thread.getCallStack() : null;
++		if (!model || !focusedSf || !callStack) {
++			this.closeExceptionWidget();
++			return;
++		}
++
++		// First call stack frame is the frame where exception has been thrown
++		const exceptionSf = callStack[0];
++		const sameUri = exceptionSf.source.uri.toString() === model.uri.toString();
++		if (this.exceptionWidget && !sameUri) {
++			this.hideExceptionWidget();
++		} else if (focusedSf && focusedSf.thread.stoppedDetails.reason === 'exception' && sameUri) {
++			this.showExceptionWidget(exceptionSf.lineNumber);
++		}
++	}
++
++	private showExceptionWidget(lineNumber: number): void {
++		if (this.exceptionWidget) {
++			this.exceptionWidget.dispose();
++		}
++
++		this.exceptionWidget = this.instantiationService.createInstance(ExceptionWidget, this.editor, lineNumber);
++		this.exceptionWidget.show({ lineNumber, column: 1 }, 3);
++	}
++
++	private hideExceptionWidget() {",Get rid fo this method,2017-02-20 14:21:06
+760,"@@ -296,6 +305,47 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 		}
+ 	}
+ 
++	// exception widget
++	public toggleExceptionWidget(): void {
++		// Toggles exception widget based on the state of the current editor model and debug stack frame
++		const model = this.editor.getModel();
++		const focusedSf = this.debugService.getViewModel().focusedStackFrame;
++		const callStack = focusedSf ? focusedSf.thread.getCallStack() : null;
++		if (!model || !focusedSf || !callStack) {
++			this.closeExceptionWidget();
++			return;
++		}
++
++		// First call stack frame is the frame where exception has been thrown
++		const exceptionSf = callStack[0];
++		const sameUri = exceptionSf.source.uri.toString() === model.uri.toString();
++		if (this.exceptionWidget && !sameUri) {
++			this.hideExceptionWidget();
++		} else if (focusedSf && focusedSf.thread.stoppedDetails.reason === 'exception' && sameUri) {
++			this.showExceptionWidget(exceptionSf.lineNumber);
++		}
++	}
++
++	private showExceptionWidget(lineNumber: number): void {
++		if (this.exceptionWidget) {
++			this.exceptionWidget.dispose();
++		}
++
++		this.exceptionWidget = this.instantiationService.createInstance(ExceptionWidget, this.editor, lineNumber);
++		this.exceptionWidget.show({ lineNumber, column: 1 }, 3);
++	}
++
++	private hideExceptionWidget() {
++		this.exceptionWidget.hide();
++	}
++
++	private closeExceptionWidget(): void {",No need to make difference between hide and close. Always destroy and recreate the widget as needed,2017-02-20 14:22:59
+250,"@@ -2972,6 +2972,37 @@ declare namespace vscode {
+ 	}
+ 
+ 	/**
++	 * An individual terminal instance within the integrated terminal.
++	 */
++	export interface Terminal {
++","add `name` as readonly so people can access that data they have passed in the create call
+",2016-08-18 19:27:00
+249,"@@ -2972,6 +2972,37 @@ declare namespace vscode {
+ 	}
+ 
+ 	/**
++	 * An individual terminal instance within the integrated terminal.
++	 */
++	export interface Terminal {
++
++		/**
++		 * Send text to the terminal.
++		 *
++		 * @param addNewLine Whether to add a new line to the text being sent, this is normally
++		 * required to run a command in the terminal. This defaults to `true`.
++		 */
++		sendText(text: string, addNewLine?: boolean);","Is this always the same sequence for new line or should `addNewLine` be something like `\n|\r\n|\r`?
+",2016-08-18 19:25:34
+874,"@@ -298,6 +298,11 @@ configurationRegistry.registerConfiguration({
+ 			'default': true,
+ 			'description': nls.localize('zenMode.hideStatusBar', ""Controls if turning on Zen Mode also hides the status bar at the bottom of the workbench."")
+ 		},
++		'zenMode.hideActivityBar': {
++			'type': 'boolean',
++			'default': true,
++			'description': nls.localize('zenMode.hideActivityBar', ""Controls if turning on Zen Mode also hides the activitybar bar at the left of the workbench."")",Please use 'activity bar' not 'activitybar' in the description,2017-04-11 13:43:56
+495,"@@ -298,7 +298,7 @@ export class Workbench implements IPartService {
+ 				} else {
+ 					if (this.workbenchParams.options.untitledToRestore && this.workbenchParams.options.untitledToRestore.length) {
+ 						const untitledToRestoreInputs = this.workbenchParams.options.untitledToRestore.map(resourceInput => {
+-							return this.untitledEditorService.createOrGet(null, null, resourceInput.resource);
++							return this.untitledEditorService.createOrGet(resourceInput.resource, null, true);","@Tyriar Same here, parameter is not being used later?
+",2016-11-16 14:33:28
+191,"@@ -3,16 +3,49 @@
+  *  Licensed under the MIT License. See License.txt in the project root for license information.
+  *--------------------------------------------------------------------------------------------*/
+ 
++.monaco-editor.vs .scroll-decoration {
++	box-shadow: #fff 0 6px 6px -6px inset; /* TODO: use a CSS custom property of the theme's `.monaco-editor-background` color here to blend better */
++}
++
++.monaco-editor.vs-dark .scroll-decoration {
++	box-shadow: #1E1E1E 0 6px 6px -6px inset; /* TODO: use a CSS custom property of the theme's `.monaco-editor-background` color here to blend better */
++}","@bpasero are these the scroll styles I changed that you mentioned in the PR? I changed these so that they would match the editor background color so that it creates a fake gradual mask over text when you've scrolled.  That way the active tab, which has the same background color of the editor, will not appear to abruptly chop off text in the editor while also not creating a shadow (as it used to) which would make the tab appear on a different plane than the text.
+
+Unfortunately, I had to hard-code these values, so in other themes than the just the default Dark and Light, it looks weird.  We could just hide these `display: none`, until we can get CSS custom property to give us the theme's editor base color.  I'll leave that up to you.
+",2016-06-30 05:22:01
+971,"@@ -3,43 +3,10 @@
+ <html>
+ 	<head>
+ 		<meta charset=""utf-8"" />
++		<meta http-equiv=""Content-Security-Policy"" content=""default-src 'none'; img-src 'self' http: https: data:; media-src 'self' http: https: data:; child-src 'self'; object-src 'self'; script-src 'self'; style-src 'self' 'unsafe-inline'; connect-src 'self' https:; font-src 'self' https:;"">
+ 	</head>
+ 	<body class=""monaco-shell vs-dark"" aria-label="""">
+-		<script>
+-			(function() {
+-				function getConfig() {
+-					let queryParams = window.location.search.substring(1).split('&');
+-					for (let i = 0; i < queryParams.length; i++) {
+-						var kv = queryParams[i].split('=');
+-						if (kv[0] === 'config' && kv[1]) {
+-							return JSON.parse(decodeURIComponent(kv[1]));
+-						}
+-					}
+-					return {};
+-				}
+-				try {
+-					let config = getConfig();
+-					let document = window.document;
+-
+-					// sets the base theme class ('vs', 'vs-dark', 'hc-black')
+-					let baseTheme = config.baseTheme || 'vs';
+-					document.body.className = 'monaco-shell ' + baseTheme;
+-
+-					// adds a stylesheet with the backgrdound color
+-					let backgroundColor = config.backgroundColor;
+-					if (!backgroundColor) {
+-						backgroundColor = baseTheme === 'hc-black' ? '#000000' : (baseTheme === 'vs' ? '#FFFFFF' : '#1E1E1E');
+-					}
+-					let foregroundColor = baseTheme === 'hc-black' ? '#FFFFFF' : (baseTheme === 'vs' ? '#6C6C6C' : '#CCCCCC');
+-					let style = document.createElement('style');
+-					style.innerHTML = '.monaco-shell { background-color:' + backgroundColor + '; color:' + foregroundColor + '; }';
+-					document.head.appendChild(style);
+-
+-				} catch (error) {
+-					console.error(error);
+-				}
+-			})();
+-		</script>
++		<script src=""preload.js""></script>","@mjbvz is there a specific need to introduce preload.js here? I would rather want to keep this JS close to the file because it is about updating the background color. Slower loading can result in ugly flicker otherwise.
+
+Is it because of the `unsafe-inline` CSP?",2017-06-14 05:44:41
+284,"@@ -3,6 +3,7 @@ npm-debug.log
+ Thumbs.db
+ node_modules/
+ .build/
++.vscode/.browse.VC*
","Please remove this one, you can use `.git/info/exclude` for it
+",2016-09-21 06:17:16
+990,"@@ -3,9 +3,6 @@
+ 	""version"": ""0.1.0"",
+ 	""publisher"": ""vscode"",
+ 	""engines"": { ""vscode"": ""*"" },
+-	""scripts"": {",Please keep the script and point it to the repo that has the improved grammar.,2017-06-19 13:55:51
+456,"@@ -30,11 +30,12 @@ import { IResourceInput, IEditorInput } from 'vs/platform/editor/common/editor';
+ import { IModeService } from 'vs/editor/common/services/modeService';
+ import { getIconClasses } from 'vs/workbench/browser/labels';
+ import { IModelService } from 'vs/editor/common/services/modelService';
+-import { EditorInput, getUntitledOrFileResource, IWorkbenchEditorConfiguration } from 'vs/workbench/common/editor';
++// import { EditorInput, getUntitledOrFileResource, IWorkbenchEditorConfiguration } from 'vs/workbench/common/editor';","@wprater why commented out?
+",2016-11-05 07:39:37
+200,"@@ -30,6 +30,7 @@ export class TerminalPanel extends Panel {
+ 	private actions: IAction[];
+ 	private parentDomElement: HTMLElement;
+ 	private terminalContainer: HTMLElement;
++	private currentThemeId: string;","Make this `currentBaseThemeId`
+",2016-07-06 22:59:29
+292,"@@ -30,6 +30,7 @@ namespace schema {
+ 			case 'editor/title': return MenuId.EditorTitle;
+ 			case 'editor/context': return MenuId.EditorContext;
+ 			case 'explorer/context': return MenuId.ExplorerContext;
++			case 'editor/tab': return MenuId.EditorTab;","maybe better editor/tab/context or editor/context/tab?
+",2016-10-04 10:49:29
+103,"@@ -300,6 +303,25 @@ export class WorkingFilesModel implements IWorkingFilesModel {
+ 		return null;
+ 	}
+ 
++	public restoreRecentlyRemovedEntry(): WorkingFileEntry {","I think I would change the data structure of recently closed entries so that it alway is an array (of up to N entries) so that you can perform the reopening multiple times as needed. 
+
+You have to be aware of the fact that you can have untitled files in the list, I suggest to ignore any entry in the working files list of closed entries that is not file thereby.
+
+Another interesting aspect is that we remove a working file automatically if a file gets deleted. So a remove of an entry might not necessarily be via user interaction. This might change in the future though, because it also has its own set of issues. But it would be weird to reopen a deleted file.
+",2016-04-09 14:44:12
+12,"@@ -3012,6 +3012,11 @@ declare namespace vscode {
+ 		export const onDidChangeTextDocument: Event<TextDocumentChangeEvent>;
+ 
+ 		/**
++		 * An event that is emitted when a [text document](#TextDocument) is saving to disk (save may fail).
++		 */
++		export const onSavingTextDocument: Event<TextDocument>;","wrong name. must be `onWillSaveTextDocument`
+",2015-11-24 09:10:38
+305,"@@ -306,7 +305,12 @@ function setupIPC(accessor: ServicesAccessor): TPromise<Server> {
+ 						promise = service.getMainProcessId()
+ 							.then(processId => {
+ 								logService.log('Sending some foreground love to the running instance:', processId);
+-								allowSetForegroundWindow(processId);
++								try {
++									const { allowSetForegroundWindow } = <any>require.__$__nodeRequire('windows-foreground-love');","@the-ress this is rather ugly, can we do what windows-mutex does? This native module is also only build for Windows and it still has a nice import 👍 
+",2016-10-05 17:36:06
+870,"@@ -308,4 +542,556 @@ export function processNlsFiles(opts:{fileHeader:string;}): ThroughStream {
+ 		}
+ 		this.emit('data', file);
+ 	});
++}
++
++export function prepareXlfFiles(projectName?: string, extensionName?: string): ThroughStream {
++	return through(
++		function (file: File) {
++			if (!file.isBuffer()) {
++				log('Error', `Failed to read component file: ${file.relative}`);
++			}
++
++			const extension = path.extname(file.path);
++			if (extension === '.json') {
++				const json = JSON.parse((<Buffer>file.contents).toString('utf8'));
++
++				if (BundledFormat.is(json)) {
++					importBundleJson(file, json, this);
++				} else if (PackageJsonFormat.is(json) || ModuleJsonFormat.is(json)) {
++					importModuleOrPackageJson(file, json, projectName, this, extensionName);
++				} else {
++					log('Error', 'JSON format cannot be deduced.');
++				}
++			} else if (extension === '.isl') {
++				importIsl(file, this);
++			}
++		}
++	);
++}
++
++export function getResource(sourceFile: string): Resource {
++	const editorProject: string = 'vscode-editor',
++		workbenchProject: string = 'vscode-workbench';
++	let resource: string;
++
++	if (sourceFile.startsWith('vs/platform')) {
++		return { name: 'vs/platform', project: editorProject };
++	} else if (sourceFile.startsWith('vs/editor/contrib')) {
++		return { name: 'vs/editor/contrib', project: editorProject };
++	} else if (sourceFile.startsWith('vs/editor')) {
++		return { name: 'vs/editor', project: editorProject };
++	} else if (sourceFile.startsWith('vs/base')) {
++		return { name: 'vs/base', project: editorProject };
++ 	} else if (sourceFile.startsWith('vs/code')) {
++		return { name: 'vs/code', project: workbenchProject };
++	} else if (sourceFile.startsWith('vs/workbench/parts')) {
++		resource = sourceFile.split('/', 4).join('/');
++		return { name: resource, project: workbenchProject };
++	} else if (sourceFile.startsWith('vs/workbench/services')) {
++		resource = sourceFile.split('/', 4).join('/');
++		return { name: resource, project: workbenchProject };
++	} else if (sourceFile.startsWith('vs/workbench')) {
++		return { name: 'vs/workbench', project: workbenchProject };
++	}
++
++	throw new Error (`Could not identify the XLF bundle for ${sourceFile}`);
++}
++
++
++function importBundleJson(file: File, json: BundledFormat, stream: ThroughStream): void {
++	let bundleXlfs: Map<XLF> = Object.create(null);
++
++	for (let source in json.keys) {
++		const projectResource = getResource(source);
++		const resource = projectResource.name;
++		const project = projectResource.project;
++
++		const keys = json.keys[source];
++		const messages = json.messages[source];
++		if (keys.length !== messages.length) {
++			log('Error:', `There is a mismatch between keys and messages in ${file.relative}`);
++		}
++
++		let xlf = bundleXlfs[resource] ? bundleXlfs[resource] : bundleXlfs[resource] = new XLF(project);
++		xlf.addFile('src/' + source, keys, messages);
++	}
++
++	for (let resource in bundleXlfs) {
++		const newFilePath = `${bundleXlfs[resource].project}/${resource.replace(/\//g, '_')}.xlf`;
++		const xlfFile = new File({ path: newFilePath, contents: new Buffer(bundleXlfs[resource].toString(), 'utf-8')});
++		stream.emit('data', xlfFile);
++	}
++}
++
++// Keeps existing XLF instances and a state of how many files were already processed for faster file emission
++var extensions: Map<{ xlf: XLF, processed: number }> = Object.create(null);
++function importModuleOrPackageJson(file: File, json: ModuleJsonFormat | PackageJsonFormat, projectName: string, stream: ThroughStream, extensionName?: string): void {
++	if (ModuleJsonFormat.is(json) && json['keys'].length !== json['messages'].length) {
++		log('Error:', `There is a mismatch between keys and messages in ${file.relative}`);
++	}
++
++	// Prepare the source path for <original/> attribute in XLF & extract messages from JSON
++	const formattedSourcePath = file.relative.replace(/\\/g, '/');
++	const messages = Object.keys(json).map((key) => json[key].toString());
++
++	// Stores the amount of localization files to be transformed to XLF before the emission
++	let localizationFilesCount,
++		originalFilePath;
++	// If preparing XLF for external extension, then use different glob pattern and source path
++	if (extensionName) {
++		localizationFilesCount = glob.sync('**/*.nls.json').length;
++		originalFilePath = `${formattedSourcePath.substr(0, formattedSourcePath.length - '.nls.json'.length)}`;
++	} else {
++		// Used for vscode/extensions folder
++		extensionName = formattedSourcePath.split('/')[0];
++		localizationFilesCount = glob.sync(`./extensions/${extensionName}/**/*.nls.json`).length;
++		originalFilePath = `extensions/${formattedSourcePath.substr(0, formattedSourcePath.length - '.nls.json'.length)}`;
++	}
++
++	let extension = extensions[extensionName] ?
++		extensions[extensionName] : extensions[extensionName] = { xlf: new XLF(projectName), processed: 0 };
++
++	if (ModuleJsonFormat.is(json)) {
++		extension.xlf.addFile(originalFilePath, json['keys'], json['messages']);
++	} else {
++		extension.xlf.addFile(originalFilePath, Object.keys(json), messages);
++	}
++
++	// Check if XLF is populated with file nodes to emit it
++	if (++extensions[extensionName].processed === localizationFilesCount) {
++		const newFilePath = path.join(projectName, extensionName + '.xlf');
++		const xlfFile = new File({ path: newFilePath, contents: new Buffer(extension.xlf.toString(), 'utf-8')});
++		stream.emit('data', xlfFile);
++	}
++}
++
++var islXlf: XLF,
++	islProcessed: number = 0;
++
++function importIsl(file: File, stream: ThroughStream) {
++	const islFiles = ['Default.isl', 'messages.en.isl'];
++	const projectName = 'vscode-workbench';
++
++	let xlf = islXlf ? islXlf : islXlf = new XLF(projectName),
++		keys: string[] = [],
++		messages: string[] = [];
++
++	let model = new TextModel(file.contents.toString());
++	let inMessageSection = false;
++	model.lines.forEach(line => {
++		if (line.length === 0) {
++			return;
++		}
++		let firstChar = line.charAt(0);
++		switch (firstChar) {
++			case ';':
++				// Comment line;
++				return;
++			case '[':
++				inMessageSection = '[Messages]' === line || '[CustomMessages]' === line;
++				return;
++		}
++		if (!inMessageSection) {
++			return;
++		}
++		let sections: string[] = line.split('=');
++		if (sections.length !== 2) {
++			log('Error:', `Badly formatted message found: ${line}`);
++		} else {
++			let key = sections[0];
++			let value = sections[1];
++			if (key.length > 0 && value.length > 0) {
++				keys.push(key);
++				messages.push(value);
++			}
++		}
++	});
++
++	const originalPath = file.path.substring(file.cwd.length+1, file.path.split('.')[0].length).replace(/\\/g, '/');
++	xlf.addFile(originalPath, keys, messages);
++
++	// Emit only upon all ISL files combined into single XLF instance
++	if (++islProcessed === islFiles.length) {
++		const newFilePath = path.join(projectName, 'setup.xlf');
++		const xlfFile = new File({ path: newFilePath, contents: new Buffer(xlf.toString(), 'utf-8')});
++		stream.emit('data', xlfFile);
++	}
++}
++
++export function pushXlfFiles(apiHostname: string, username: string, password: string): ThroughStream {
++	let tryGetPromises = [];
++	let updateCreatePromises = [];
++
++	return through(function(file: File) {
++		const project = path.dirname(file.relative);
++		const fileName = path.basename(file.path);
++		const slug = fileName.substr(0, fileName.length - '.xlf'.length);
++		const credentials = `${username}:${password}`;
++
++		// Check if resource already exists, if not, then create it.
++		let promise = tryGetResource(project, slug, apiHostname, credentials);
++		tryGetPromises.push(promise);
++		promise.then(exists => {
++			if (exists) {
++				promise = updateResource(project, slug, file, apiHostname, credentials);
++			} else {
++				promise = createResource(project, slug, file, apiHostname, credentials);
++			}
++			updateCreatePromises.push(promise);
++		}).catch((reason) => {",I am not a gulp expert either but I think this simply logs something to the console but the gulp stream says in tact and the build will look like it passed. We have to ensure that in the cause of exceptions talking to Transifex this can be observed as a failing build from the outside.,2017-04-04 13:06:52
+871,"@@ -308,4 +542,556 @@ export function processNlsFiles(opts:{fileHeader:string;}): ThroughStream {
+ 		}
+ 		this.emit('data', file);
+ 	});
++}
++
++export function prepareXlfFiles(projectName?: string, extensionName?: string): ThroughStream {
++	return through(
++		function (file: File) {
++			if (!file.isBuffer()) {
++				log('Error', `Failed to read component file: ${file.relative}`);
++			}
++
++			const extension = path.extname(file.path);
++			if (extension === '.json') {
++				const json = JSON.parse((<Buffer>file.contents).toString('utf8'));
++
++				if (BundledFormat.is(json)) {
++					importBundleJson(file, json, this);
++				} else if (PackageJsonFormat.is(json) || ModuleJsonFormat.is(json)) {
++					importModuleOrPackageJson(file, json, projectName, this, extensionName);
++				} else {
++					log('Error', 'JSON format cannot be deduced.');
++				}
++			} else if (extension === '.isl') {
++				importIsl(file, this);
++			}
++		}
++	);
++}
++
++export function getResource(sourceFile: string): Resource {
++	const editorProject: string = 'vscode-editor',
++		workbenchProject: string = 'vscode-workbench';
++	let resource: string;
++
++	if (sourceFile.startsWith('vs/platform')) {
++		return { name: 'vs/platform', project: editorProject };
++	} else if (sourceFile.startsWith('vs/editor/contrib')) {
++		return { name: 'vs/editor/contrib', project: editorProject };
++	} else if (sourceFile.startsWith('vs/editor')) {
++		return { name: 'vs/editor', project: editorProject };
++	} else if (sourceFile.startsWith('vs/base')) {
++		return { name: 'vs/base', project: editorProject };
++ 	} else if (sourceFile.startsWith('vs/code')) {
++		return { name: 'vs/code', project: workbenchProject };
++	} else if (sourceFile.startsWith('vs/workbench/parts')) {
++		resource = sourceFile.split('/', 4).join('/');
++		return { name: resource, project: workbenchProject };
++	} else if (sourceFile.startsWith('vs/workbench/services')) {
++		resource = sourceFile.split('/', 4).join('/');
++		return { name: resource, project: workbenchProject };
++	} else if (sourceFile.startsWith('vs/workbench')) {
++		return { name: 'vs/workbench', project: workbenchProject };
++	}
++
++	throw new Error (`Could not identify the XLF bundle for ${sourceFile}`);
++}
++
++
++function importBundleJson(file: File, json: BundledFormat, stream: ThroughStream): void {
++	let bundleXlfs: Map<XLF> = Object.create(null);
++
++	for (let source in json.keys) {
++		const projectResource = getResource(source);
++		const resource = projectResource.name;
++		const project = projectResource.project;
++
++		const keys = json.keys[source];
++		const messages = json.messages[source];
++		if (keys.length !== messages.length) {
++			log('Error:', `There is a mismatch between keys and messages in ${file.relative}`);
++		}
++
++		let xlf = bundleXlfs[resource] ? bundleXlfs[resource] : bundleXlfs[resource] = new XLF(project);
++		xlf.addFile('src/' + source, keys, messages);
++	}
++
++	for (let resource in bundleXlfs) {
++		const newFilePath = `${bundleXlfs[resource].project}/${resource.replace(/\//g, '_')}.xlf`;
++		const xlfFile = new File({ path: newFilePath, contents: new Buffer(bundleXlfs[resource].toString(), 'utf-8')});
++		stream.emit('data', xlfFile);
++	}
++}
++
++// Keeps existing XLF instances and a state of how many files were already processed for faster file emission
++var extensions: Map<{ xlf: XLF, processed: number }> = Object.create(null);
++function importModuleOrPackageJson(file: File, json: ModuleJsonFormat | PackageJsonFormat, projectName: string, stream: ThroughStream, extensionName?: string): void {
++	if (ModuleJsonFormat.is(json) && json['keys'].length !== json['messages'].length) {
++		log('Error:', `There is a mismatch between keys and messages in ${file.relative}`);
++	}
++
++	// Prepare the source path for <original/> attribute in XLF & extract messages from JSON
++	const formattedSourcePath = file.relative.replace(/\\/g, '/');
++	const messages = Object.keys(json).map((key) => json[key].toString());
++
++	// Stores the amount of localization files to be transformed to XLF before the emission
++	let localizationFilesCount,
++		originalFilePath;
++	// If preparing XLF for external extension, then use different glob pattern and source path
++	if (extensionName) {
++		localizationFilesCount = glob.sync('**/*.nls.json').length;
++		originalFilePath = `${formattedSourcePath.substr(0, formattedSourcePath.length - '.nls.json'.length)}`;
++	} else {
++		// Used for vscode/extensions folder
++		extensionName = formattedSourcePath.split('/')[0];
++		localizationFilesCount = glob.sync(`./extensions/${extensionName}/**/*.nls.json`).length;
++		originalFilePath = `extensions/${formattedSourcePath.substr(0, formattedSourcePath.length - '.nls.json'.length)}`;
++	}
++
++	let extension = extensions[extensionName] ?
++		extensions[extensionName] : extensions[extensionName] = { xlf: new XLF(projectName), processed: 0 };
++
++	if (ModuleJsonFormat.is(json)) {
++		extension.xlf.addFile(originalFilePath, json['keys'], json['messages']);
++	} else {
++		extension.xlf.addFile(originalFilePath, Object.keys(json), messages);
++	}
++
++	// Check if XLF is populated with file nodes to emit it
++	if (++extensions[extensionName].processed === localizationFilesCount) {
++		const newFilePath = path.join(projectName, extensionName + '.xlf');
++		const xlfFile = new File({ path: newFilePath, contents: new Buffer(extension.xlf.toString(), 'utf-8')});
++		stream.emit('data', xlfFile);
++	}
++}
++
++var islXlf: XLF,
++	islProcessed: number = 0;
++
++function importIsl(file: File, stream: ThroughStream) {
++	const islFiles = ['Default.isl', 'messages.en.isl'];
++	const projectName = 'vscode-workbench';
++
++	let xlf = islXlf ? islXlf : islXlf = new XLF(projectName),
++		keys: string[] = [],
++		messages: string[] = [];
++
++	let model = new TextModel(file.contents.toString());
++	let inMessageSection = false;
++	model.lines.forEach(line => {
++		if (line.length === 0) {
++			return;
++		}
++		let firstChar = line.charAt(0);
++		switch (firstChar) {
++			case ';':
++				// Comment line;
++				return;
++			case '[':
++				inMessageSection = '[Messages]' === line || '[CustomMessages]' === line;
++				return;
++		}
++		if (!inMessageSection) {
++			return;
++		}
++		let sections: string[] = line.split('=');
++		if (sections.length !== 2) {
++			log('Error:', `Badly formatted message found: ${line}`);
++		} else {
++			let key = sections[0];
++			let value = sections[1];
++			if (key.length > 0 && value.length > 0) {
++				keys.push(key);
++				messages.push(value);
++			}
++		}
++	});
++
++	const originalPath = file.path.substring(file.cwd.length+1, file.path.split('.')[0].length).replace(/\\/g, '/');
++	xlf.addFile(originalPath, keys, messages);
++
++	// Emit only upon all ISL files combined into single XLF instance
++	if (++islProcessed === islFiles.length) {
++		const newFilePath = path.join(projectName, 'setup.xlf');
++		const xlfFile = new File({ path: newFilePath, contents: new Buffer(xlf.toString(), 'utf-8')});
++		stream.emit('data', xlfFile);
++	}
++}
++
++export function pushXlfFiles(apiHostname: string, username: string, password: string): ThroughStream {
++	let tryGetPromises = [];
++	let updateCreatePromises = [];
++
++	return through(function(file: File) {
++		const project = path.dirname(file.relative);
++		const fileName = path.basename(file.path);
++		const slug = fileName.substr(0, fileName.length - '.xlf'.length);
++		const credentials = `${username}:${password}`;
++
++		// Check if resource already exists, if not, then create it.
++		let promise = tryGetResource(project, slug, apiHostname, credentials);
++		tryGetPromises.push(promise);
++		promise.then(exists => {
++			if (exists) {
++				promise = updateResource(project, slug, file, apiHostname, credentials);
++			} else {
++				promise = createResource(project, slug, file, apiHostname, credentials);
++			}
++			updateCreatePromises.push(promise);
++		}).catch((reason) => {
++			log('Error:', reason);
++		});
++
++	}, function() {
++		// End the pipe only after all the communication with Transifex API happened
++		Promise.all(tryGetPromises).then(() => {
++			Promise.all(updateCreatePromises).then(() => {
++				this.emit('end');
++			}).catch((reason) => log('Error:', reason));
++		}).catch((reason) => log('Error:', reason));
++	});
++}
++
++function tryGetResource(project: string, slug: string, apiHostname: string, credentials: string): Promise<boolean> {
++	return new Promise((resolve, reject) => {
++		const options = {
++			hostname: apiHostname,
++			path: `/api/2/project/${project}/resource/${slug}/?details`,
++			auth: credentials,
++			method: 'GET'
++		};
++
++		const request = http.request(options, (response) => {
++			if (response.statusCode === 404) {
++				resolve(false);
++			} else if (response.statusCode === 200) {
++				resolve(true);
++			} else {
++				reject(`Failed to query resource ${project}/${slug}. Response: ${response.statusCode} ${response.statusMessage}`);
++			}
++		}).on('error', (err) => {
++			reject(`Failed to get ${project}/${slug} on Transifex: ${err}`);
++		});
++
++		request.end();
++	});
++}
++
++function createResource(project: string, slug: string, xlfFile: File, apiHostname: string, credentials: any): Promise<any> {
++	return new Promise((resolve, reject) => {
++		const data = JSON.stringify({
++			'content': xlfFile.contents.toString(),
++			'name': slug,
++			'slug': slug,
++			'i18n_type': 'XLIFF'
++		});
++		const options = {
++			hostname: apiHostname,
++			path: `/api/2/project/${project}/resources`,
++			headers: {
++				'Content-Type': 'application/json',
++				'Content-Length': Buffer.byteLength(data)
++			},
++			auth: credentials,
++			method: 'POST'
++		};
++
++		let request = http.request(options, (res) => {
++			if (res.statusCode === 201) {
++				log(`Resource ${project}/${slug} successfully created on Transifex.`);
++			} else {
++				reject(`Something went wrong in the request creating ${slug} in ${project}. ${res.statusCode}`);
++			}
++		}).on('error', (err) => {
++			reject(`Failed to create ${project}/${slug} on Transifex: ${err}`);
++		});
++
++		request.write(data);
++		request.end();
++	});
++}
++
++/**
++ * The following link provides information about how Transifex handles updates of a resource file:
++ * https://dev.befoolish.co/tx-docs/public/projects/updating-content#what-happens-when-you-update-files
++ */
++function updateResource(project: string, slug: string, xlfFile: File, apiHostname: string, credentials: string) : Promise<any> {
++	return new Promise((resolve, reject) => {
++		const data = JSON.stringify({ content: xlfFile.contents.toString() });
++		const options = {
++			hostname: apiHostname,
++			path: `/api/2/project/${project}/resource/${slug}/content`,
++			headers: {
++				'Content-Type': 'application/json',
++				'Content-Length': Buffer.byteLength(data)
++			},
++			auth: credentials,
++			method: 'PUT'
++		};
++
++		let request = http.request(options, (res) => {
++			if (res.statusCode === 200) {
++				res.setEncoding('utf8');
++
++				let responseBuffer: string = '';
++				res.on('data', function (chunk) {
++					responseBuffer += chunk;
++				});
++				res.on('end', () => {
++					const response = JSON.parse(responseBuffer);
++					log(`Resource ${project}/${slug} successfully updated on Transifex. Strings added: ${response.strings_added}, updated: ${response.strings_added}, deleted: ${response.strings_added}`);
++					resolve();
++				});
++			} else {
++				reject(`Something went wrong in the request updating ${slug} in ${project}. ${res.statusCode}`);
++			}
++		}).on('error', (err) => {
++			reject(`Failed to update ${project}/${slug} on Transifex: ${err}`);
++		});
++
++		request.write(data);
++		request.end();
++	});
++}
++
++function getMetadataResources(pathToMetadata: string) : Resource[] {
++	const metadata = fs.readFileSync(pathToMetadata).toString('utf8');
++	const json = JSON.parse(metadata);
++	let slugs = [];
++
++	for (let source in json['keys']) {
++		let projectResource = getResource(source);
++		if (!slugs.find(slug => slug.name === projectResource.name && slug.project === projectResource.project)) {
++			slugs.push(projectResource);
++		}
++	}
++
++	return slugs;
++}
++
++function obtainProjectResources(projectName: string): Resource[] {
++	let resources: Resource[];
++
++	if (projectName === 'vscode-editor-workbench') {
++		resources = getMetadataResources('./out-vscode/nls.metadata.json');
++		resources.push({ name: 'setup', project: 'vscode-workbench' });
++	} else if (projectName === 'vscode-extensions') {
++		let extensionsToLocalize: string[] = glob.sync('./extensions/**/*.nls.json').map(extension => extension.split('/')[2]);
++		let resourcesToPull: string[] = [];
++		resources = [];
++
++		extensionsToLocalize.forEach(extension => {
++			if (resourcesToPull.indexOf(extension) === -1) { // remove duplicate elements returned by glob
++				resourcesToPull.push(extension);
++				resources.push({ name: extension, project: projectName });
++			}
++		});
++	}
++
++	return resources;
++}
++
++export function pullXlfFiles(projectName: string, apiHostname: string, username: string, password: string, resources?: Resource[]): NodeJS.ReadableStream {
++	if (!resources) {
++		resources = obtainProjectResources(projectName);
++	}
++	if (!resources) {
++		throw new Error('Transifex projects and resources must be defined to be able to pull translations from Transifex.');
++	}
++
++	const credentials = `${username}:${password}`;
++	let expectedTranslationsCount = vscodeLanguages.length * resources.length;
++	let translationsRetrieved = 0, called = false;
++
++	return readable(function(count, callback) {
++		// Mark end of stream when all resources were retrieved
++		if (translationsRetrieved === expectedTranslationsCount) {
++			return this.emit('end');
++		}
++
++		if (!called) {
++			called = true;
++			const stream = this;
++
++			vscodeLanguages.map(function(language) {
++				resources.map(function (resource) {
++					const slug = resource.name.replace(/\//g, '_');
++					const project = resource.project;
++					const iso639 = iso639_3_to_2[language];
++					const options = {
++						hostname: apiHostname,
++						path: `/api/2/project/${project}/resource/${slug}/translation/${iso639}?file&mode=onlyreviewed`,
++						auth: credentials,
++						method: 'GET'
++					};
++
++					let request = http.request(options, (res) => {
++							let xlfBuffer: string = '';
++							res.on('data', (data) => xlfBuffer += data);
++							res.on('end', () => {
++								if (res.statusCode === 200) {
++									stream.emit('data', new File({ contents: new Buffer(xlfBuffer) }));
++								} else {
++									log('Error:', `${slug} in ${project} returned no data. Response code: ${res.statusCode}.`);
++								}
++								translationsRetrieved++;
++							});
++					}).on('error', (err) => {
++						log('Error:', `Failed to query resource ${slug} with the following error: ${err}`);
++					});
++					request.end();
++				});
++			});
++		}
++
++		callback();
++	});
++}
++
++export function prepareJsonFiles(): ThroughStream {
++	return through(function(xlf: File) {
++		let stream = this;
++
++		XLF.parse(xlf.contents.toString()).then(
++			function(resolvedFiles) {
++				resolvedFiles.forEach(file => {
++					let messages = file.messages, translatedFile;
++
++					// ISL file path always starts with 'build/'
++					if (file.originalFilePath.startsWith('build/')) {
++						const defaultLanguages = { 'zh-cn': true, 'zh-tw': true, 'ko': true };
++						if (path.basename(file.originalFilePath) === 'Default' && !defaultLanguages[file.language]) {
++							return;
++						}
++
++						translatedFile = createIslFile('..', file.originalFilePath, messages, iso639_2_to_3[file.language]);
++					} else {
++						translatedFile = createI18nFile(iso639_2_to_3[file.language], file.originalFilePath, messages);
++					}
++
++					stream.emit('data', translatedFile);
++				});
++			},
++			function(rejectReason) {
++				log('Error:', rejectReason);
++			}
++		);
++	});
++}
++
++export function createI18nFile(base: string, originalFilePath: string, messages: Map<string>): File {
++	let content = [
++		'/*---------------------------------------------------------------------------------------------',
++		' *  Copyright (c) Microsoft Corporation. All rights reserved.',
++		' *  Licensed under the MIT License. See License.txt in the project root for license information.',
++		' *--------------------------------------------------------------------------------------------*/',
++		'// Do not edit this file. It is machine generated.'
++	].join('\n') + '\n' + JSON.stringify(messages, null, '\t').replace(/\r\n/g, '\n');
++
++	return new File({
++		path: path.join(base, originalFilePath + '.i18n.json'),
++		contents: new Buffer(content, 'utf8')
++	});
++}
++
++
++const languageNames: Map<string> = {
++	'chs': 'Simplified Chinese',
++	'cht': 'Traditional Chinese',
++	'kor': 'Korean'
++};
++
++const languageIds: Map<string> = {
++	'chs': '$0804',
++	'cht': '$0404',
++	'kor': '$0412'
++};
++
++const encodings: Map<string> = {
++	'chs': 'CP936',
++	'cht': 'CP950',
++	'jpn': 'CP932',
++	'kor': 'CP949',
++	'deu': 'CP1252',
++	'fra': 'CP1252',
++	'esn': 'CP1252',
++	'rus': 'CP1251',
++	'ita': 'CP1252'
++};
++
++export function createIslFile(base: string, originalFilePath: string, messages: Map<string>, language: string): File {",Did you consider that for the ISL we only need to push ch* and kor. For all other languages we have translations. Or is this not possible since languages are defined by a Transifex project. If so we might want to consider not pushing the Default.isl to Transifex,2017-04-04 13:10:34
+221,"@@ -308,7 +340,12 @@ export class OpenAnythingHandler extends QuickOpenHandler {
+ 			entry.setHighlights(labelHighlights, descriptionHighlights);
+ 		});
+ 
+-		return viewResults;
++		return {","Can we make this nicer? E.g. an interface which has one entry for results and another for all performance/telemetry relevant data? Maybe just a Tupel<2>?
+",2016-07-14 17:36:35
+477,"@@ -31,26 +33,37 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
+ 
+ 	private hasAssociatedFilePath: boolean;
+ 
++	private backupPromises: TPromise<void>[];","@Tyriar this is not being used? and related code around canceling it?
+",2016-11-09 07:46:47
+476,"@@ -31,26 +33,37 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
+ 
+ 	private hasAssociatedFilePath: boolean;
+ 
++	private backupPromises: TPromise<void>[];
++
+ 	constructor(
+ 		value: string,
+ 		modeId: string,
+ 		resource: URI,
+ 		hasAssociatedFilePath: boolean,
+ 		@IModeService modeService: IModeService,
+ 		@IModelService modelService: IModelService,
+-		@IConfigurationService private configurationService: IConfigurationService
++		@IFileService private fileService: IFileService,","@Tyriar unused `fileService` and `backupFileService`
+",2016-11-09 07:46:05
+899,"@@ -31,7 +31,8 @@ class ExpandAbbreviationAction extends BasicEmmetEditorAction {
+ 					EditorContextKeys.hasOnlyEmptySelection,
+ 					EditorContextKeys.hasSingleSelection,
+ 					EditorContextKeys.tabDoesNotMoveFocus,
+-					ContextKeyExpr.has('config.emmet.triggerExpansionOnTab')
++					ContextKeyExpr.has('config.emmet.triggerExpansionOnTab'),
++					ContextKeyExpr.not('config.emmet.autocomplete')",Shouldn't we have a schema definition for this? Like for other values: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/emmet/node/emmet.contribution.ts#L38,2017-04-25 07:18:32
+975,"@@ -310,6 +310,10 @@ export class ViewletActionItem extends ActivityActionItem {
+ 	public render(container: HTMLElement): void {
+ 		super.render(container);
+ 
++		if (this._keybinding) {","@RohithKumbharkar I have a different suggestion where to put this code that makes it much easier. If you look below in that class there is a `public set keybinding(keybinding: string)`. I suggest to set the title in there because it gets computed there:
+
+```typescript
+this.$label.title(title);
+this.$badge.title(title);
+this.$container.title(title); // <-- add it here
+```",2017-06-15 15:50:28
+572,"@@ -310,7 +310,7 @@ class DecorationRenderHelper {
+ 				cssTextArr.push(strings.format(this._CSS_MAP.contentIconPath, opts.contentIconPath.toString(true).replace(/'/g, '%27')));","What is the reason for this change?
+How can we be sure that we did not break any of the many use cases editor decorations have. 
+
+This PR should not touch anything in the editor land. A change in the editor land is only acceptable if there is no alternative.",2016-12-05 14:48:24
+898,"@@ -310,7 +310,7 @@ export class ExtHostSCM {
+ 		return sourceControl;
+ 	}
+ 
+-	$provideOriginalResource(sourceControlHandle: number, uri: URI): TPromise<URI> {","I also wasn't entirely sure of `URI` vs `vscode.Uri`. I think the change itself is correct, but I was not confident to know if any existing code is relying on the old signature or if this change could cause any trouble",2017-04-24 23:50:46
+515,"@@ -312,7 +312,10 @@ export class DebugService implements debug.IDebugService {
+ 		}));
+ 
+ 		this.toDisposeOnSessionEnd[session.getId()].push(session.onDidContinued(event => {
+-			this.transitionToRunningState(session, event.body.allThreadsContinued ? undefined : event.body.threadId);
++			// TODO: This calls onStackFrame with null stack frame on every step causing all decorators to be re-drawn.
++			// onDidContinued also gets called for step-over causing flash in decorators due to removeDecorators and setDecorators call
++			// One idea is to use throttled onStackFrame, other is to only call onDidContinued only for continue
++			// this.transitionToRunningState(session, event.body.allThreadsContinued ? undefined : event.body.threadId);
+ 		}));","Let's first try with the idea I mentioned in my comment - to use editor.deltaDecorations and keep track of our decorations.
+Calling onDidContinued only for continue will not work because some step calls can take arbitrary long, so in essence they can be just like a continue.
+
+If the decoraionts idea does not work then we will update decorations with a delay, similar to how the debug views in the debug viewlet have a delay to prevetn tree collapsing and flashing",2016-11-28 10:22:48
+977,"@@ -316,6 +321,29 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 			etag = this.lastResolvedDiskStat.etag; // otherwise respect etag to support caching
+ 		}
+ 
++		const storageKey = 'workbench.tasks.ranTaskBefore';",Can you put this in its own method?,2017-06-16 20:13:11
+271,"@@ -317,10 +322,10 @@ export class TerminalService implements ITerminalService {
+ 		return terminalProcess;
+ 	}
+ 
+-	public static createTerminalEnv(parentEnv: IStringDictionary<string>, shell: IShell, workspace: IWorkspace, locale?: string): IStringDictionary<string> {
++	public static createTerminalEnv(parentEnv: IStringDictionary<string>, shell: IShell, workspace: IWorkspace, shellPath?: string, locale?: string): IStringDictionary<string> {","Thinking about this again, I think we should probably support args for the shellPath too (what `IShell` does). Meaning shellPath and shellArgs should pass through the API layers.
+",2016-09-08 19:07:24
+104,"@@ -319,6 +341,9 @@ export class WorkingFilesModel implements IWorkingFilesModel {
+ 	}
+ 
+ 	public clear(): void {
++		this.recentlyClosedEntries.push(this.entries.map((entry) => {
++			return entry.resource;
++		}));","This should just shift all entries into the array of recently closed entries.
+",2016-04-09 14:44:34
+996,"@@ -319,7 +324,57 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 		// Resolve Content
+ 		return this.textFileService
+ 			.resolveTextContent(this.resource, { acceptTextOnly: true, etag, encoding: this.preferredEncoding })
+-			.then(content => this.handleLoadSuccess(content), error => this.handleLoadError(error));
++			.then(content => this.handleLoadSuccess(content), error => this.handleLoadError(error))
++			.then((result) => {
++				this.showTaskNotification();
++				return result;
++			});
++	}
++
++	private showTaskNotification(): void {
++		const storageKey = 'workbench.tasks.ranTaskBefore';
++		if (this.storageService.get(storageKey)) {
++			const fileName = path.relative(this.contextService.getWorkspace().resource.toString(), this.resource.toString());
++			if (fileName.match(/^gruntfile\.js$/i) || fileName.match(/^gulpfile\.js$/i) || fileName.match(/^tsconfig\.json$/i)) {
++				const message = localize('taskFileOpened', `Run your ${fileName.split('.')[0]} in vscode. Get started here.`);
++				let action: any;
++				let messageTest: string;
++				const showDocumentation = isShowTaskDocumentation(this.storageService);",You can use `telemetryService.getExperiments().showTaskDocumentation` instead.,2017-06-19 22:00:12
+66,"@@ -319,71 +319,71 @@ export const HTML_TAGS: ITagSet = {
+ };
+ 
+ export const IONIC_TAGS: ITagSet = {
+-	'ion-checkbox': new HTMLTagSpecification('',
++	'ion-checkbox': new HTMLTagSpecification(nls.localize('tags.ion.checkbox', 'The checkbox is no different than the HTML checkbox input, except it\'s styled differently. The checkbox behaves like any AngularJS checkbox.'),","I've used nls.localize, with a string ID for each label; is there anything else to do for localization?
+",2016-03-04 21:54:55
+895,"@@ -32,5 +32,6 @@
+ 	""typescript.implementationsCodeLens.enabled"": ""Enable/disable implementations CodeLens. Requires TypeScript >= 2.2.0."",
+ 	""typescript.openTsServerLog.title"": ""Open TS Server log file"",
+ 	""typescript.selectTypeScriptVersion.title"": ""Select TypeScript Version"",
+-	""jsDocCompletion.enabled"": ""Enable/disable auto JSDoc comments""
++	""jsDocCompletion.enabled"": ""Enable/disable auto JSDoc comments"",
++	""javascript.implicitProjectConfig.checkJs"": ""Enable/disable type checking in loose JavaScript files that are not included in any jsconfig or tsconfig projects. Requires TypeScript >= 2.3.1.""","I'm still not sure how to clearly express when this setting applies and when it does not
+
+The setting applies only when a javascript file is not included in a JavaScript project as defined in a `jsconfig` or `tsconfig`. If the file is part of a project, the user must instead enable `checkJs` in the config file itself
+
+@kieferrm Let me know if you have any suggestions here",2017-04-21 03:04:44
+549,"@@ -32,6 +32,7 @@ export interface IWindowCreationOptions {
+ 	extensionDevelopmentPath?: string;
+ 	allowFullscreen?: boolean;
+ 	titleBarStyle?: 'native' | 'custom';
++	vscodeWindowId?: string;",@Tyriar I would suggest to call this `id` and instead fix all users of the current `id` property to use `vscodeWindows.win.id` because that makes it very clear what ID is being asked.,2016-12-01 16:20:32
+905,"@@ -32,7 +32,7 @@ class JsDocCompletionItem extends CompletionItem {
+ 	) {
+ 		super('/** */', CompletionItemKind.Snippet);
+ 		this.detail = localize('typescript.jsDocCompletionItem.documentation', 'JSDoc comment');
+-		this.insertText = '';
++		this.insertText = ' ';","This is the minimal change that fixes the issue. I also considered updating the suggestion provider to not apply the new enter logic for empty insert text or for completions with commands, however this carried more risk.
+
+I'm also going to try to get TypeScript to improve the api we use to get doctemplates so that the `JsDocCompletionItem` doesn't require using a command",2017-05-05 05:10:15
+150,"@@ -32,7 +32,7 @@ var baseModules = [
+ 	'applicationinsights', 'assert', 'child_process', 'chokidar', 'crypto', 'emmet',
+ 	'events', 'fs', 'getmac', 'glob', 'graceful-fs', 'http', 'http-proxy-agent',
+ 	'https', 'https-proxy-agent', 'iconv-lite', 'electron', 'net',
+-	'os', 'path', 'readline', 'sax', 'semver', 'stream', 'string_decoder', 'url',
++	'os', 'path', 'pty.js', 'readline', 'sax', 'semver', 'stream', 'string_decoder', 'url', 'term.js',","Is this change related to 3077?
+",2016-05-20 08:18:13
+979,"@@ -321,12 +321,21 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 			etag = this.lastResolvedDiskStat.etag; // otherwise respect etag to support caching
+ 		}
+ 
++		this.taskNotification();","Maybe this should only happen after opening the file succeeds? Partly to avoid slowing down the file open with extra work, but also, a file can fail to open, in which case you don't want to show the notification. ",2017-06-16 23:28:40
+980,"@@ -321,12 +321,21 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 			etag = this.lastResolvedDiskStat.etag; // otherwise respect etag to support caching
+ 		}
+ 
++		this.taskNotification();
++
++		// Resolve Content
++		return this.textFileService
++			.resolveTextContent(this.resource, { acceptTextOnly: true, etag, encoding: this.preferredEncoding })
++			.then(content => this.handleLoadSuccess(content), error => this.handleLoadError(error));
++	}
++
++	private taskNotification(): void {",More verb-y name like `showTaskNotification` or something,2017-06-16 23:29:07
+978,"@@ -321,12 +321,21 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 			etag = this.lastResolvedDiskStat.etag; // otherwise respect etag to support caching
+ 		}
+ 
++		this.taskNotification();
++
++		// Resolve Content
++		return this.textFileService
++			.resolveTextContent(this.resource, { acceptTextOnly: true, etag, encoding: this.preferredEncoding })
++			.then(content => this.handleLoadSuccess(content), error => this.handleLoadError(error));
++	}
++
++	private taskNotification(): void {
+ 		const storageKey = 'workbench.tasks.ranTaskBefore';
+-		const fileName = path.relative(this.storageService['workspaceKey'], this.resource['_formatted']);
++		const fileName = path.relative(this.contextService.getWorkspace().resource.toString(), this.resource.toString());","Can you only do this check if the storageService check succeeds, to avoid extra work, since most of the time, it won't be needed?",2017-06-16 23:25:56
+835,"@@ -323,6 +323,10 @@ export class RawDebugSession extends v8.V8Protocol implements debug.ISession {
+ 		return this.send('stackTrace', args);",Looks good,2017-03-21 17:01:11
+856,"@@ -323,6 +323,7 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(ShowEditorsInGroupThre
+ registry.registerWorkbenchAction(new SyncActionDescriptor(OpenNextEditor, OpenNextEditor.ID, OpenNextEditor.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.PageDown, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.RightArrow, secondary: [KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_CLOSE_SQUARE_BRACKET] } }), 'View: Open Next Editor', category);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(OpenPreviousEditor, OpenPreviousEditor.ID, OpenPreviousEditor.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.PageUp, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.LeftArrow, secondary: [KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.US_OPEN_SQUARE_BRACKET] } }), 'View: Open Previous Editor', category);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(ReopenClosedEditorAction, ReopenClosedEditorAction.ID, ReopenClosedEditorAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_T }), 'View: Reopen Closed Editor', category);
++registry.registerWorkbenchAction(new SyncActionDescriptor(ClearRecentItemsAction, ClearRecentItemsAction.ID, ClearRecentItemsAction.LABEL), 'View: Clear Items', category);",`Clear Recent Files` maybe?,2017-03-23 14:06:25
+15,"@@ -325,7 +325,7 @@ export class DebugEditorModelManager implements wbext.IWorkbenchContribution {
+ 
+ 	private static FOCUSED_STACK_FRAME_DECORATION: editorcommon.IModelDecorationOptions = {
+ 		isWholeLine: true,
+-		className: 'debug-focussed-stack-frame-line',
++		className: 'debug-focused-stack-frame-line',","Make sure you adopt the same change on `src/vs/workbench/parts/debug/browser/media/debug.contribution.css` where this class name is used.
+",2015-11-25 08:35:38
+784,"@@ -327,20 +327,14 @@ export class Repository {
+ 			return TPromise.wrapError(localize('errorBuffer', ""Can't open file from git""));
+ 		}
+ 
+-		return new Promise((c, e) => {
+-			detectMimesFromStream(child.stdout, null, (err, result) => {
+-				if (err) {
+-					e(err);
+-				} else if (isBinaryMime(result.mimes)) {
+-					e(<IFileOperationResult>{
+-						message: localize('fileBinaryError', ""File seems to be binary and cannot be opened as text""),
+-						fileOperationResult: FileOperationResult.FILE_IS_BINARY
+-					});
+-				} else {
+-					c(this.doBuffer(object));
+-				}
+-			});
+-		});
++		return detectMimesFromStream(child.stdout, null).then(result =>
++			isBinaryMime(result.mimes) ?
++				TPromise.wrapError<string>(<IFileOperationResult>{",@katainaka0503 return missing here?,2017-03-01 09:18:16
+783,"@@ -328,7 +328,7 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 	}
+ 
+ 	private get bundledTypeScriptPath(): string {
+-		return path.join(__dirname, '..', 'node_modules', 'typescript', 'lib', 'tsserver.js');
++		return path.join(__dirname, '..', '..', 'node_modules', 'typescript', 'lib', 'tsserver.js');",Use `require.resolve('typescript/lib/tsserver.js')` instead to avoid the path dependency,2017-03-01 08:26:39
+960,"@@ -329,16 +329,20 @@ export function createApiFactory(
+ 				return extHostTerminalService.onDidCloseTerminal(listener, thisArg, disposables);
+ 			},
+ 			showInformationMessage(message, first, ...rest) {
+-				return extHostMessageService.showMessage(Severity.Info, message, first, rest);",These changes are the main ones I'm uncertain about. Let me know if you think a different fix would be better,2017-06-06 19:00:04
+837,"@@ -33,15 +33,40 @@ export class ExceptionWidget extends ZoneWidget {
+ 		const fontInfo = this.editor.getConfiguration().fontInfo;
+ 		this.container.style.fontSize = `${fontInfo.fontSize}px`;
+ 		this.container.style.lineHeight = `${fontInfo.lineHeight}px`;
+-
+-		let title = $('.title');
+-		title.textContent = nls.localize('exceptionThrown', 'Exception occurred');
+-		dom.append(container, title);
+-
+ 		const thread = this.debugService.getViewModel().focusedThread;
++
+ 		if (thread && thread.stoppedDetails) {
++			let title = $('.title');
+ 			let msg = $('.message');
+-			msg.textContent = thread.stoppedDetails.text;
++
++			if (this.exceptionInfo) {
++				let conditionMessage;
++				switch (this.exceptionInfo.body.breakMode) {
++					case 'never':
++						conditionMessage = nls.localize('neverException', 'User-handled exception has occurred.');
++						break;
++					case 'always':
++						conditionMessage = nls.localize('alwaysException', 'Always-breaking exception has occurred.');
++						break;
++					case 'unhandled':
++						conditionMessage = nls.localize('unhandledException', 'Unhandled exception has occurred.');
++						break;
++					case 'userUnhandled':
++						conditionMessage = nls.localize('userUnhandledException', 'User-unhandled exception has occurred.');
++						break;
++					default:
++						conditionMessage = '';",I would prefer if the default case had the same `Exception occurred` message as the case when there is no exceptionInfo,2017-03-21 17:04:00
+838,"@@ -33,15 +33,40 @@ export class ExceptionWidget extends ZoneWidget {
+ 		const fontInfo = this.editor.getConfiguration().fontInfo;
+ 		this.container.style.fontSize = `${fontInfo.fontSize}px`;
+ 		this.container.style.lineHeight = `${fontInfo.lineHeight}px`;
+-
+-		let title = $('.title');
+-		title.textContent = nls.localize('exceptionThrown', 'Exception occurred');
+-		dom.append(container, title);
+-
+ 		const thread = this.debugService.getViewModel().focusedThread;
++
+ 		if (thread && thread.stoppedDetails) {
++			let title = $('.title');
+ 			let msg = $('.message');
+-			msg.textContent = thread.stoppedDetails.text;
++
++			if (this.exceptionInfo) {
++				let conditionMessage;
++				switch (this.exceptionInfo.body.breakMode) {
++					case 'never':
++						conditionMessage = nls.localize('neverException', 'User-handled exception has occurred.');
++						break;
++					case 'always':
++						conditionMessage = nls.localize('alwaysException', 'Always-breaking exception has occurred.');
++						break;
++					case 'unhandled':
++						conditionMessage = nls.localize('unhandledException', 'Unhandled exception has occurred.');
++						break;
++					case 'userUnhandled':
++						conditionMessage = nls.localize('userUnhandledException', 'User-unhandled exception has occurred.');
++						break;
++					default:
++						conditionMessage = '';
++						break;
++				}
++
++				title.textContent = `${conditionMessage} ${this.exceptionInfo.body.description}`;",You are missing a colon here between the condition message and the description,2017-03-21 17:04:17
+506,"@@ -33,4 +36,42 @@ const extensions = [
+ 	'html'
+ ];
+ 
+-extensions.forEach(extension => npmInstall(`extensions/${extension}`));
+\ No newline at end of file
++extensions.forEach(extension => npmInstallSync(`extensions/${extension}`));
++
++function rmDuplicateModulesSync() {
++
++	function fetchModuleIds(basepath) {
++		const result = new Map();
++		for (const candidate of fs.readdirSync(path.join(basepath, 'node_modules'))) {
++			try {
++				let raw = fs.readFileSync(path.join(basepath, 'node_modules', candidate, 'package.json'));
++				let data = JSON.parse(raw);
++				result.set(data._id, path.join(basepath, 'node_modules', candidate));
++			} catch (e) {
++				if (e.code !== 'ENOENT') {
++					throw e;
++				}
++			}
++		}
++		return result;
++	}
++
++	const duplicates = new Set();
++	const baseModules = fetchModuleIds('');
++
++	for (const extension of extensions) {
++		const extensionModules = fetchModuleIds(`extensions/${extension}`);
++		for (let [key, value] of extensionModules) {
++			if (baseModules.has(key)) {
++				duplicates.add(value);
++			}
++		}
++	}
++
++	for (let duplicate of duplicates) {
++		console.log(`REMOVING duplicate module '${duplicate}'`);
++		rimraf.sync(path.join(process.cwd(), duplicate));",Is `process.cwd()` a good idea here?,2016-11-23 18:16:59
+811,"@@ -331,6 +331,7 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(CloseEditorsInGroupAct
+ registry.registerWorkbenchAction(new SyncActionDescriptor(CloseOtherEditorsInGroupAction, CloseOtherEditorsInGroupAction.ID, CloseOtherEditorsInGroupAction.LABEL, { primary: null, mac: { primary: KeyMod.CtrlCmd | KeyMod.Alt | KeyCode.KEY_T } }), 'View: Close Other Editors', category);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(CloseEditorsInOtherGroupsAction, CloseEditorsInOtherGroupsAction.ID, CloseEditorsInOtherGroupsAction.LABEL), 'View: Close Editors in Other Groups', category);
+ registry.registerWorkbenchAction(new SyncActionDescriptor(SplitEditorAction, SplitEditorAction.ID, SplitEditorAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.US_BACKSLASH }), 'View: Split Editor', category);
++registry.registerWorkbenchAction(new SyncActionDescriptor(JoinEditorsAction, JoinEditorsAction.ID, JoinEditorsAction.LABEL), 'View: Join Editors', category);",Should this maybe be more descriptive to what it actually does? `Join Editors of two Groups`?,2017-03-10 14:23:11
+998,"@@ -333,23 +333,44 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 
+ 	private showTaskNotification(): void {
+ 		const storageKey = 'workbench.tasks.ranTaskBefore';
+-		if (!this.storageService.get(storageKey)) {
++		if (this.storageService.get(storageKey)) {
+ 			const fileName = path.relative(this.contextService.getWorkspace().resource.toString(), this.resource.toString());
+ 			if (fileName.match(/^gruntfile\.js$/i) || fileName.match(/^gulpfile\.js$/i) || fileName.match(/^tsconfig\.json$/i)) {
+-				const message = localize('taskFileOpened', ""Visual Studio Code has extra functionality for this type of file"");
+-				const action = this.instantiationService.createInstance(ShowTasksAction, ShowTasksAction.ID, localize('showTasks', ""Show Tasks""));
+-
++				const message = localize('taskFileOpened', `Run your ${fileName.split('.')[0]} in vscode. Get started here.`);","This is going to fail the main build, or not work - localized strings have to be constant string literals. But you can add a placeholder like this:
+
+`localize('id', 'foo {0} bar {1}', 'string inserted at {0}', 'inserted at {1}' ...)`",2017-06-19 22:09:18
+999,"@@ -333,23 +333,44 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 
+ 	private showTaskNotification(): void {
+ 		const storageKey = 'workbench.tasks.ranTaskBefore';
+-		if (!this.storageService.get(storageKey)) {
++		if (this.storageService.get(storageKey)) {
+ 			const fileName = path.relative(this.contextService.getWorkspace().resource.toString(), this.resource.toString());
+ 			if (fileName.match(/^gruntfile\.js$/i) || fileName.match(/^gulpfile\.js$/i) || fileName.match(/^tsconfig\.json$/i)) {
+-				const message = localize('taskFileOpened', ""Visual Studio Code has extra functionality for this type of file"");
+-				const action = this.instantiationService.createInstance(ShowTasksAction, ShowTasksAction.ID, localize('showTasks', ""Show Tasks""));
+-
++				const message = localize('taskFileOpened', `Run your ${fileName.split('.')[0]} in vscode. Get started here.`);
++				let action: any;",Type as `Action` instead of `any`,2017-06-19 22:13:18
+108,"@@ -333,6 +346,27 @@ export class WorkingFilesModel implements IWorkingFilesModel {
+ 		return this.mapEntryToResource[resource.toString()];
+ 	}
+ 
++	private recordRecentlyClosedEntries(resources: WorkingFileEntry[]): void {
++		if (resources.length === 0) {
++			return;
++		}
++
++		// Make the active entry the first entry","@Tyriar can you explain what these lines are for?
+",2016-04-15 06:23:01
+890,"@@ -334,6 +335,22 @@ export class VSCodeWindow {
+ 		return this._readyState;
+ 	}
+ 
++	private registerNavigationListenerOn(command: string, back: string, forward: string) {
++		this._win.on(command, (e, cmd) => {
++			if (this.readyState !== ReadyState.READY) {
++				return; // window must be ready
++			}
++
++			if (cmd === back) {
++				this.send('vscode:runAction', 'workbench.action.navigateBack');
++			} else if (cmd === forward) {
++				this.send('vscode:runAction', 'workbench.action.navigateForward');
++			} else {
++				console.warn('[electron command]: did not handle: ', command);","Should not happen, please remove.",2017-04-18 05:51:48
+481,"@@ -334,6 +356,9 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 				diag('makeDirty() - prevented save because we are in conflict resolution mode', this.resource, new Date());
+ 			}
+ 		}
++
++		// Trigger listeners only if no auto save occurred and model changes were not blocked
++		this._onDidContentChange.fire();","@Tyriar hm careful here. there are some return statements above e.g. when the user undos his changes up to the saved version, don't we want to also update (or actually discard) the backup in that case?
+
+Also I am not sure the comment `if no auto save occurred` makes sense.
+",2016-11-09 07:59:48
+359,"@@ -339,6 +339,17 @@ export class HistoryService extends BaseHistoryService implements IHistoryServic
+ 		this.recentlyClosedFiles = [];
+ 	}
+ 
++	public block(block: boolean) {
++		if (block) {
++			this.blockStackChanges = true;
++			this.blockEditorHistoryChanges = true;
++		}","@wprater style, prefer `} else {`
+",2016-10-21 09:52:52
+380,"@@ -339,6 +346,15 @@ export class WorkbenchLayout implements IVerticalSashLayoutProvider, IHorizontal
+ 
+ 		// Activity Bar
+ 		let activityBarMinWidth = this.computedStyles.activitybar.minWidth;
++
++		// For inline titles, we want to ignore the minWidth on the activity bar
++		// and generate a zoom-dependent width, to ensure all other parts lay out correctly
++		const windowConfig = this.configurationService.getConfiguration<IWindowConfiguration>();
++		if (windowConfig && windowConfig.window.macOSUseInlineToolbar) {
++			const zoom = webFrame.getZoomFactor();
++			activityBarMinWidth = 76/zoom;","@orta the 76px should be read from the CSS file if possible and not hardcoded (compare with https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/layout.ts#L307)
+",2016-10-23 06:53:05
+325,"@@ -339,7 +339,11 @@ export interface IAskpassService {
+ }
+ 
+ // Utils
++const invalidBranchPatternName = /(^\.)|(\/\.)|(\.\.)|(~)|(\^)|(:)|(\/$)|(\.lock$)|(\.lock\/)|(\\)|(\*)|(\s)|(^\s*$)|(\.$)/g;","Why wrapping everything in groups? The regex is now broken since the `^` and `$` were making sure the whole string is matched.
+",2016-10-14 12:51:15
+596,"@@ -34,7 +34,18 @@ export default class TypeScriptDocumentHighlightProvider implements DocumentHigh
+ 		}
+ 		return this.client.execute('occurrences', args, token).then((response): DocumentHighlight[] => {
+ 			let data = response.body;
+-			if (data) {
++			if (data && data.length) {","We may also want to scope to using the TypeScript version just to be safe. That way if something does go terribly wrong, users could point to their own ts install as a workaround.",2016-12-12 18:13:18
+158,"@@ -340,4 +341,11 @@ suite('Sass - Sass Parser', () => {
+ 		assertNode('%hover', parser, parser._parseSimpleSelector.bind(parser));
+ 		assertNode('a%float', parser, parser._parseSimpleSelector.bind(parser));
+ 	});
++
++	test('Sass Parser - Css Variable Declaration', function() {","Just one tiny suggestion, we may want to use `CSS` or `css` rather than `Css`
+",2016-05-20 17:25:00
+423,"@@ -340,6 +342,9 @@ export function createApiFactory(initDataConfiguration: IInitConfiguration, init
+ 			onWillSaveTextDocument: (listener, thisArgs?, disposables?) => {
+ 				return extHostDocumentSaveParticipant.onWillSaveTextDocumentEvent(listener, thisArgs, disposables);
+ 			},
++			registerTreeExplorerNodeProvider(providerId: string, provider: vscode.TreeExplorerNodeProvider<any>) {","[needs change] This function must be marked as proposed - look at the [`sampleFunction`](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/api/node/extHost.api.impl.ts#L279)
+",2016-11-01 09:40:02
+25,"@@ -342,7 +341,15 @@ export const Suggest = {
+ 		result.documentation = suggestion.documentationLabel;
+ 		result.sortText = suggestion.sortText;
+ 		result.filterText = suggestion.filterText;
+-		result.textEdit = suggestion.textEdit && <any> TextEdit.to(suggestion.textEdit);
++
++		var overwriteBefore = (typeof suggestion.overwriteBefore !== 'undefined') ? suggestion.overwriteBefore : container.currentWord.length;","boh, `var`
+",2015-12-11 10:24:44
+614,"@@ -3422,17 +3423,18 @@ declare module 'vscode' {
+ 	 * register a command handler with the identfier `extension.sayHello`.
+ 	 * ```javascript
+ 	 * commands.registerCommand('extension.sayHello', () => {
+-	 * 		window.showInformationMessage('Hello World!');
++	 * 	window.showInformationMessage('Hello World!');
+ 	 * });
+ 	 * ```
+ 	 * Second, bind the command identfier to a title under which it will show in the palette (`package.json`).
+ 	 * ```json
+ 	 * {
+-	 * ""contributes"": {
+-	 * 	""commands"": [{
+-	 * 		""command"": ""extension.sayHello"",
+-	 * 		""title"": ""Hello World""
+-	 * 	}]
++	 * 	""contributes"": {
++	 * 		""commands"": [{
++	 * 			""command"": ""extension.sayHello"",
++	 * 			""title"": ""Hello World""
++	 * 		}]
++	 * 	}",This one seemed to be missing a closing curly brace,2016-12-15 23:50:29
+251,"@@ -3429,6 +3460,15 @@ declare namespace vscode {
+ 		 * @return A new status bar item.
+ 		 */
+ 		export function createStatusBarItem(alignment?: StatusBarAlignment, priority?: number): StatusBarItem;
++
++		/**
++		 * Creates a [Terminal](#Terminal).
++		 *
++		 * @param name The optional name of a terminal, this will override the label used in the
++		 * terminal dropdown.
++		 * @return A new Terminal.
++		 */
++		export function createTerminal(name?: string): Thenable<vscode.Terminal>;","We do not return promises from there functions but already working objects (see `createStatusBarItem`). It should be `createTerminal(name?: string): Terminal`. We don't expose in the API  that stuff is being created/executed in a different process.
+",2016-08-18 19:28:17
+554,"@@ -344,3 +366,49 @@ interface CacheStats {
+ 	cacheFilterStartTime: number;
+ 	cacheFilterResultCount: number;
+ }
++
++/**
++ * Collects a batch of items that each have a size. When the cumulative size of the batch reaches 'maxBatchSize', it calls the callback.
++ * If the batch isn't filled within 'timeout' ms, the callback is also called.
++ * And after 'batchOnlyAfter' items, the timeout is ignored, and the callback is called only when the batch is full.","`batchOnlyAfter` seems misleading, we batch before too.",2016-12-01 18:50:42
+555,"@@ -344,3 +366,49 @@ interface CacheStats {
+ 	cacheFilterStartTime: number;
+ 	cacheFilterResultCount: number;
+ }
++
++/**
++ * Collects a batch of items that each have a size. When the cumulative size of the batch reaches 'maxBatchSize', it calls the callback.
++ * If the batch isn't filled within 'timeout' ms, the callback is also called.
++ * And after 'batchOnlyAfter' items, the timeout is ignored, and the callback is called only when the batch is full.
++ */
++class BatchedCollector<T> {
++	private totalNumberCompleted = 0;
++	private batch: T[] = [];
++	private batchSize = 0;
++	private timeoutHandle: number;
++
++	constructor(private maxBatchSize: number, private timeout: number, private batchOnlyAfter: number, private cb: (items: T | T[]) => void) {
++	}
++
++	addItem(item: T, size: number): void {
++		if (!item) {
++			return;
++		}
++
++		if (this.maxBatchSize > 0) {
++			this.batch.push(item);
++			this.batchSize += size;
++			if (this.batchSize >= this.maxBatchSize) {
++				this.flush();
++			} else {
++				if (!this.timeoutHandle && this.totalNumberCompleted < this.batchOnlyAfter) {
++					this.timeoutHandle = setTimeout(() => {
++						this.flush();
++					}, this.timeout);
++				}
++			}
++		} else {
++			this.cb(item);
++		}
++	}
++
++	flush(): void {
++		this.totalNumberCompleted += this.batchSize;",Check if `this.batchSize > 0`?,2016-12-01 18:52:02
+737,"@@ -346,8 +346,10 @@ class MouseDownOperation extends Disposable {
+ 
+ 	private _mouseMoveMonitor: GlobalEditorMouseMoveMonitor;
+ 	private _mouseDownThenMoveEventHandler: EventGateKeeper<EditorMouseEvent>;
++	private _mouseDragThenMoveEventHandler: EventGateKeeper<EditorMouseEvent>;","No need for a separate handler, I suggest to use `mouseState.lastMouseDownEvent` (which should be renamed to something better, see other comment) to differentiate the two cases inside `onMouseDownThenMove`",2017-02-20 11:07:43
+273,"@@ -347,4 +352,19 @@ export class TerminalService implements ITerminalService {
+ 		}
+ 		return parts.join('_') + '.UTF-8';
+ 	}
++}
++
++interface ITerminalProcessConfiguration {
++	_name: string;","Underscore not necessary since it's public
+",2016-09-08 19:11:24
+272,"@@ -347,4 +352,19 @@ export class TerminalService implements ITerminalService {
+ 		}
+ 		return parts.join('_') + '.UTF-8';
+ 	}
++}
++
++interface ITerminalProcessConfiguration {
++	_name: string;
++	_shellPath: string;
++}
++
++class TerminalProcessConfiguration implements ITerminalProcessConfiguration {","We don't really need to implement the interface, an interface is all we need to enforce the types. TypeScript allows regular objects `{}` to use interfaces and keeps the type safe.
+",2016-09-08 19:08:23
+675,"@@ -349,6 +349,18 @@ export class TabsTitleControl extends TitleControl {
+ 		tabContainer.setAttribute('role', 'presentation'); // cannot use role ""tab"" here due to https://github.com/Microsoft/vscode/issues/8659
+ 		DOM.addClass(tabContainer, 'tab monaco-editor-background');
+ 
++		if (!this.tabOptions.showTabCloseButton || this.tabOptions.tabCloseButton === 'off') {",Please move this into the `doUpdate` method above where you will notice that there already is an update for `no-close-button` class from the other option (that should be deleted). We need to have it there because otherwise tabs will not update live from a config change.,2017-01-16 07:59:36
+268,"@@ -3497,9 +3497,10 @@ declare namespace vscode {
+ 		 * [Terminal.show](#Terminal.show) in order to show the terminal panel.
+ 		 *
+ 		 * @param name Optional human-readable string which will be used to represent the terminal in the UI.
++		 * @param shellPath Path to the user-requested shell executable that will be used in the terminal","Change this to:
+
+> @param shellPath Optional path to a custom shell executable to be used in the terminal.
+",2016-09-08 18:53:00
+329,"@@ -35,6 +35,10 @@
+ 
+ /** Custom Mac Cursor */
+ 
++.monaco-workbench.mac.use-inline-toolbar > .monaco-sash.mac {","We should not add workbench dependencies here, instead if we want to override something for widgets it should go into workbench.css
+",2016-10-15 06:14:13
+931,"@@ -358,6 +358,7 @@ export class ManageExtensionAction extends Action {
+ 				instantiationService.createInstance(EnableGloballyAction, localize('enableAlwaysAction.label', ""Enable (Always)""))
+ 			],
+ 			[
++				instantiationService.createInstance(AddToWorkspaceRecommendationsAction, localize('addToWorkspaceRecommendationsAction.label', ""Add to Workspace Recommendations"")),","How about having a short label - `Recommend (Workspace)`  and `Unrecommend (Workspace)`. Not sure `Workspace` word is necessary since a user can recommend only to Workspace, but having it makes it complete.",2017-05-12 09:14:36
+876,"@@ -3646,6 +3646,18 @@ declare module 'vscode' {
+ 		export function showTextDocument(document: TextDocument, column?: ViewColumn, preserveFocus?: boolean): Thenable<TextEditor>;
+ 
+ 		/**
++		 * Show the given document in a text editor. A [column](#ViewColumn) can be provided
++		 * to control where the editor is being shown. Might change the [active editor](#window.activeTextEditor).
++		 *
++		 * @param document A text document to be shown.
++		 * @param column A view column in which the editor should be shown. The default is the [one](#ViewColumn.One), other values
++		 * are adjusted to be __Min(column, columnCount + 1)__.
++		 * @param options Editor options for showing the text editor.
++		 * @return A promise that resolves to an [editor](#TextEditor).
++		 */
++		export function showTextDocument(document: TextDocument, column?: ViewColumn, options?: { preserveFocus?: boolean, pinned?: boolean }): Thenable<TextEditor>;","Sooo, if we add this new overload it should include `column` and also make it a type which we can document nicer",2017-04-13 15:13:46
+467,"@@ -369,6 +373,30 @@ export class WindowsManager implements IWindowsMainService, IWindowEventService
+ 			iPathsToOpen = this.cliToPaths(openConfig.cli, ignoreFileNotFound);
+ 		}
+ 
++		let configuration: IWindowConfiguration;","@Tyriar suggest to move this code block down before the line
+
+`// Handle files to open/diff or to create when we dont open a folder` 
+
+Because there we actually start the job of opening something.
+",2016-11-09 07:21:08
+466,"@@ -369,6 +373,30 @@ export class WindowsManager implements IWindowsMainService, IWindowEventService
+ 			iPathsToOpen = this.cliToPaths(openConfig.cli, ignoreFileNotFound);
+ 		}
+ 
++		let configuration: IWindowConfiguration;
++		let openInNewWindow = openConfig.preferNewWindow || openConfig.forceNewWindow;
++
++		// Restore any existing backup workspaces
++		if (openConfig.restoreBackups) {
++			const workspacesWithBackups = this.backupService.getWorkspaceBackupPathsSync();","@Tyriar again not sure about all the sync fs calls are needed here
+",2016-11-09 07:20:33
+322,"@@ -37,6 +38,7 @@ export class DirtyFilesTracker implements IWorkbenchContribution {
+ 
+ 	constructor(
+ 		@ITextFileService private textFileService: ITextFileService,
++		@IFileService private fileService: IFileService,","Unused service?
+",2016-10-13 15:13:31
+479,"@@ -370,9 +374,9 @@ export abstract class TextFileService implements ITextFileService {
+ 		return this._models.getAll(<URI>arg1);
+ 	}
+ 
+-	private getDirtyFileModels(resources?: URI[]): ITextFileEditorModel[];
+-	private getDirtyFileModels(resource?: URI): ITextFileEditorModel[];
+-	private getDirtyFileModels(arg1?: any): ITextFileEditorModel[] {
++	public getDirtyFileModels(resources?: URI[]): ITextFileEditorModel[];","@Tyriar why public here? not used outside it seems
+",2016-11-09 07:57:00
+901,"@@ -373,15 +376,31 @@ export function registerCommands(): void {
+ 		win: { primary: void 0 }
+ 	});
+ 
+-	CommandsRegistry.registerCommand('_workbench.diff', function (accessor: ServicesAccessor, args: [URI, URI, string, string]) {
++	CommandsRegistry.registerCommand('_workbench.diff', function (accessor: ServicesAccessor, args: [URI, URI, string, string, vscode.TextDocumentShowOptions]) {",it's dangerous to use the vscode-module here (actually everywhere outside the extension host) because these type actually don't exist. for interfaces it's OK because they disappear but using `IEditorOption` would have been better,2017-04-25 13:58:11
+867,"@@ -373,6 +373,19 @@ export class VSCodeWindow {
+ 			}
+ 		});
+ 
++		// Swipe command support (macOS)
++		this._win.on('swipe', (e, cmd) => {",@seivan can we reuse this code with the `on('app-command')` handler? Seems duplicate.,2017-03-30 23:08:19
+961,"@@ -375,3 +390,26 @@ CommonEditorRegistry.registerEditorCommand(new SuggestCommand({
+ 		primary: KeyCode.RightArrow
+ 	}
+ }));
++
++@editorAction
++class ReplCopyAllAction extends EditorAction {
++
++	constructor() {
++		super({
++			id: 'repl.action.copyall',
++			label: nls.localize('actions.repl.copyall', ""Debug Copy All""),","I would prefer the title to be ""Debug: Console Copy All"", that way it nicely aligns with the other debug actions and has a more clear name",2017-06-08 09:56:50
+962,"@@ -375,3 +390,26 @@ CommonEditorRegistry.registerEditorCommand(new SuggestCommand({
+ 		primary: KeyCode.RightArrow
+ 	}
+ }));
++
++@editorAction
++class ReplCopyAllAction extends EditorAction {
++
++	constructor() {
++		super({
++			id: 'repl.action.copyall',
++			label: nls.localize('actions.repl.copyall', ""Debug Copy All""),
++			alias: 'Debug Copy All',
++			precondition: debug.CONTEXT_IN_DEBUG_REPL,
++			kbOpts: {","I think you can just leave out the `kbOpts` and it should nicely compile, please try that",2017-06-08 09:58:02
+489,"@@ -376,6 +380,28 @@ export class WindowsManager implements IWindowsMainService {
+ 		}
+ 
+ 		let configuration: IWindowConfiguration;
++		let openInNewWindow = openConfig.preferNewWindow || openConfig.forceNewWindow;
++
++		// Restore any existing backup workspaces
++		if (openConfig.restoreBackups) {
++			const workspacesWithBackups = this.backupService.getWorkspaceBackupPaths();
++
++			workspacesWithBackups.forEach(workspacePath => {
++				if (!fs.existsSync(workspacePath)) {","@Tyriar would it be possible that we have a backup workspace without backups to restore? maybe we should add more checks here that a backup workspace path should only cause a window to open if it has backups, otherwise it gets deleted. I am thinking of situations where we the backup workspace gets out of sync with the backups within (for whatever reason - e.g. crash). This would prevent bugs where multiple windows just open even though there are no backups.
+",2016-11-15 05:56:16
+491,"@@ -376,6 +380,28 @@ export class WindowsManager implements IWindowsMainService {
+ 		}
+ 
+ 		let configuration: IWindowConfiguration;
++		let openInNewWindow = openConfig.preferNewWindow || openConfig.forceNewWindow;
++
++		// Restore any existing backup workspaces
++		if (openConfig.restoreBackups) {
++			const workspacesWithBackups = this.backupService.getWorkspaceBackupPaths();
++
++			workspacesWithBackups.forEach(workspacePath => {
++				if (!fs.existsSync(workspacePath)) {
++					this.backupService.removeWorkspaceBackupPathSync(Uri.file(workspacePath));
++					return;
++				}
++
++				const untitledToRestore = this.backupService.getWorkspaceUntitledFileBackupsSync(Uri.file(workspacePath)).map(filePath => {","@Tyriar same comment here about how to restore untitled files. This would not be needed if untitled had input factory.
+",2016-11-15 05:59:45
+78,"@@ -378,6 +424,14 @@ export class Model extends ee.EventEmitter implements debug.IModel {
+ 		this.emit(debug.ModelEvents.CALLSTACK_UPDATED);
+ 	}
+ ","Should `continueThreads()` also `clearCallstack()` for each `thread`?
+",2016-03-16 10:44:40
+697,"@@ -3801,6 +3810,13 @@ export interface ICommonCodeEditor extends IEditor {
+ 	onDidType(listener: (text: string) => void): IDisposable;
+ 
+ 	/**
++	 * An event emitted when users paste text in the editor.
++	 * @event
++	 * @internal
++	 */
++	onDidPaste(listener: (range: Range) => void): IDisposable;","Here we say we give out a `Range`, but the implementation gives out an `IRange`. Please adjust the implementation.",2017-01-19 15:38:39
+399,"@@ -3804,6 +3870,15 @@ declare module 'vscode' {
+ 		export function registerTextDocumentContentProvider(scheme: string, provider: TextDocumentContentProvider): Disposable;
+ 
+ 		/**
++		 * Register a [tree explorer node provider](#TreeExplorerNodeProvider).","tree explorer node provider -> TreeExplorerNodeProvider
+",2016-10-24 15:23:09
+738,"@@ -384,6 +386,12 @@ class MouseDownOperation extends Disposable {
+ 				() => !this._viewHelper.isDirty()
+ 			)
+ 		);
++		this._mouseDragThenMoveEventHandler = this._register(","No need for a separate handler, I suggest to code the dnd case inside `onMouseDownThenMove`",2017-02-20 11:08:19
+26,"@@ -388,20 +388,21 @@ export interface ISuggestion {
+ 	label: string;
+ 	codeSnippet: string;
+ 	type: string;
+-	textEdit?: EditorCommon.ISingleEditOperation;
+ 	typeLabel?: string;
+ 	documentationLabel?: string;
+ 	filterText?: string;
+ 	sortText?: string;
+ 	noAutoAccept?: boolean;
++	overwriteBefore?: number;
++	overwriteAfter?: number;
++
++	textEdit?: EditorCommon.ISingleEditOperation;","this isn't needed anymore, right?
+",2015-12-11 10:25:03
+702,"@@ -389,6 +395,16 @@ export class DefaultController implements _.IController {
+ 
+ 		return false;
+ 	}
++
++	protected setOpenMode(openMode: WorkbenchOpenMode) {
++		if (this.options.openMode !== openMode) {
++			this.options.openMode = openMode;
++		}
++	}
++
++	protected isInSingleClickOpenMode() {",Maybe better `openOnSingleClick`,2017-01-20 11:54:38
+883,"@@ -39,12 +42,42 @@ export class TerminalLinkHandler {
+ 	private _tooltipDisposables: IDisposable[] = [];
+ 	private _widgetManager: TerminalWidgetManager;
+ 
++	// Changing any regex may effect this value, hence changes this as well if required.
++	private _winLineAndColumnMatchIndex = 12;
++	private _unixLineAndColumnMatchIndex = 15;
++
++	private _lineAndColumnClauses = [",Any reason this isn't a constant up the top so it's shared between multiple instances of `TerminalLinkHandler`?,2017-04-17 17:37:21
+54,"@@ -391,11 +418,17 @@ export class Workbench implements IPartService {
+ 			this.sideBarHidden = true; // we hide sidebar in single-file-mode
+ 		}
+ 
+-		let registry = (<IViewletRegistry>Registry.as(ViewletExtensions.Viewlets));
++		let registry = (<ViewletRegistry>Registry.as(ViewletExtensions.Viewlets));
+ 		if (!registry.getDefaultViewletId()) {
+ 			this.sideBarHidden = true; // can only hide sidebar if we dont have a default viewlet id","@isidorn for the sake of completness, the panel should also be hidden if there is no default panel
+",2016-01-19 11:14:04
+826,"@@ -391,7 +391,7 @@ export class TerminalTaskSystem extends EventEmitter implements ITaskSystem {
+ 			} else {
+ 				(this.terminalService.configHelper as TerminalConfigHelper).mergeDefaultShellPathAndArgs(shellLaunchConfig);
+ 			}
+-			let shellArgs = shellLaunchConfig.args.slice(0);
++			let shellArgs = <string[]>shellLaunchConfig.args.slice(0);",@weinand FYI IShellLaunchConfig can now have args as a string to support @dbaeumer's use case of needed to use a pre-escaped set of arguments. I needed to make this change which I believe shouldn't cause any issues.,2017-03-14 18:22:28
+653,"@@ -392,3 +393,58 @@ export const isAbsoluteRegex = /^((\/|[a-zA-Z]:\\)[^\(\)<>\\'\""\[\]]+)/;
+ export function isAbsolute(path: string): boolean {
+ 	return isAbsoluteRegex.test(path);
+ }
++
++/**
++ * Shortens the paths but keeps them easy to distinguish.
++ * Replaces not important parts with ellipsis.
++ * Every shorten path matches only one original path and vice versa.
++ */
++export function shorten(paths: string[]): string[] {
++	var separator = isWindows ? '\\' : '/';",Suggest to use `paths.nativeSep` here (https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/paths.ts#L20),2017-01-09 09:10:00
+655,"@@ -392,3 +393,58 @@ export const isAbsoluteRegex = /^((\/|[a-zA-Z]:\\)[^\(\)<>\\'\""\[\]]+)/;
+ export function isAbsolute(path: string): boolean {
+ 	return isAbsoluteRegex.test(path);
+ }
++
++/**
++ * Shortens the paths but keeps them easy to distinguish.
++ * Replaces not important parts with ellipsis.
++ * Every shorten path matches only one original path and vice versa.
++ */
++export function shorten(paths: string[]): string[] {
++	var separator = isWindows ? '\\' : '/';
++	var ellipsis = '...';",How about using the actual unicode ellipsis character? I think that will save us some pixels (e.g. http://www.fileformat.info/info/unicode/char/2026/index.htm),2017-01-09 09:11:02
+105,"@@ -392,6 +392,9 @@ export class VSCodeMenu {
+ 	}
+ 
+ 	private setOpenRecentMenu(openRecentMenu: Electron.Menu): void {
++		openRecentMenu.append(this.createMenuItem(nls.localize({ key: 'miReopenClosedFile', comment: ['&& denotes a mnemonic'] }, ""&&Reopen Closed File""), 'workbench.files.action.reopenClosedFile'));
++		openRecentMenu.append(__separator__());","@Tyriar careful, the menu might not have any entries (if there are not recent files) so you would have one separator too much in the end
+",2016-04-15 06:13:35
+689,"@@ -392,9 +388,13 @@ export class MainThreadTextEditor {
+ 		return false;
+ 	}
+ 
+-	insertSnippet(template: string, opts: IInsertSnippetOptions) {
++	insertSnippet(template: string, opts: IUndoStopOptions) {",@jrieken Should `console.warn('applyEdits on invisible editor');` be added to `insertSnippet`?,2017-01-18 18:22:48
+930,"@@ -394,6 +395,48 @@ export class ManageExtensionAction extends Action {
+ 	}
+ }
+ 
++export class AddToWorkspaceRecommendationsAction extends Action implements IExtensionAction {","Since there is an action to add an extension to recommended list, there should also be a counter action to remove it from recommended list",2017-05-12 09:10:19
+927,"@@ -394,6 +395,48 @@ export class ManageExtensionAction extends Action {
+ 	}
+ }
+ 
++export class AddToWorkspaceRecommendationsAction extends Action implements IExtensionAction {
++
++	static ID = 'extensions.addToWorkspaceRecommendationsAction';
++	static LABEL = localize('addToWorkspaceRecommendationsAction', ""Workspace"");
++
++	private disposables: IDisposable[] = [];
++
++	private _extension: IExtension;
++	get extension(): IExtension { return this._extension; }
++	set extension(extension: IExtension) { this._extension = extension; this.update(); }
++
++	constructor(label: string,
++		@IWorkspaceContextService private workspaceContextService: IWorkspaceContextService,
++		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
++		@IExtensionEnablementService private extensionEnablementService: IExtensionEnablementService,
++		@IInstantiationService private instantiationService: IInstantiationService",Please remove those services which are not used,2017-05-12 09:04:13
+929,"@@ -394,6 +395,48 @@ export class ManageExtensionAction extends Action {
+ 	}
+ }
+ 
++export class AddToWorkspaceRecommendationsAction extends Action implements IExtensionAction {
++
++	static ID = 'extensions.addToWorkspaceRecommendationsAction';
++	static LABEL = localize('addToWorkspaceRecommendationsAction', ""Workspace"");
++
++	private disposables: IDisposable[] = [];
++
++	private _extension: IExtension;
++	get extension(): IExtension { return this._extension; }
++	set extension(extension: IExtension) { this._extension = extension; this.update(); }
++
++	constructor(label: string,
++		@IWorkspaceContextService private workspaceContextService: IWorkspaceContextService,
++		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
++		@IExtensionEnablementService private extensionEnablementService: IExtensionEnablementService,
++		@IInstantiationService private instantiationService: IInstantiationService
++	) {
++		super(AddToWorkspaceRecommendationsAction.ID, label);
++
++		this.disposables.push(this.extensionsWorkbenchService.onChange(() => this.update()));
++		this.update();
++	}
++
++	private update(): void {
++		this.enabled = !!this.extension;",Enablement should also depends on if it is already recommended or not and also if there is a workspace or not,2017-05-12 09:09:40
+922,"@@ -394,6 +395,48 @@ export class ManageExtensionAction extends Action {
+ 	}
+ }
+ 
++export class AddToWorkspaceRecommendationsAction extends Action implements IExtensionAction {
++
++	static ID = 'extensions.addToWorkspaceRecommendationsAction';
++	static LABEL = localize('addToWorkspaceRecommendationsAction', ""Workspace"");
++
++	private disposables: IDisposable[] = [];
++
++	private _extension: IExtension;
++	get extension(): IExtension { return this._extension; }
++	set extension(extension: IExtension) { this._extension = extension; this.update(); }
++
++	constructor(label: string,
++		@IWorkspaceContextService private workspaceContextService: IWorkspaceContextService,
++		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
++		@IExtensionEnablementService private extensionEnablementService: IExtensionEnablementService,
++		@IInstantiationService private instantiationService: IInstantiationService
++	) {
++		super(AddToWorkspaceRecommendationsAction.ID, label);
++
++		this.disposables.push(this.extensionsWorkbenchService.onChange(() => this.update()));
++		this.update();
++	}
++
++	private update(): void {
++		this.enabled = !!this.extension;
++	}
++
++	run(): TPromise<any> {
++		const action = <Action>this.instantiationService.createInstance(
++			ConfigureWorkspaceRecommendedExtensionsAction,
++			ConfigureWorkspaceRecommendedExtensionsAction.ID,
++			ConfigureWorkspaceRecommendedExtensionsAction.LABEL","- Check for the case when there is no workspace.
+- Also why do we need to show the extensions file if we can just add the recommendation silently in the background.",2017-05-12 08:45:09
+923,"@@ -394,6 +395,48 @@ export class ManageExtensionAction extends Action {
+ 	}
+ }
+ 
++export class AddToWorkspaceRecommendationsAction extends Action implements IExtensionAction {
++
++	static ID = 'extensions.addToWorkspaceRecommendationsAction';
++	static LABEL = localize('addToWorkspaceRecommendationsAction', ""Workspace"");
++
++	private disposables: IDisposable[] = [];
++
++	private _extension: IExtension;
++	get extension(): IExtension { return this._extension; }
++	set extension(extension: IExtension) { this._extension = extension; this.update(); }
++
++	constructor(label: string,
++		@IWorkspaceContextService private workspaceContextService: IWorkspaceContextService,
++		@IExtensionsWorkbenchService private extensionsWorkbenchService: IExtensionsWorkbenchService,
++		@IExtensionEnablementService private extensionEnablementService: IExtensionEnablementService,
++		@IInstantiationService private instantiationService: IInstantiationService
++	) {
++		super(AddToWorkspaceRecommendationsAction.ID, label);
++
++		this.disposables.push(this.extensionsWorkbenchService.onChange(() => this.update()));
++		this.update();
++	}
++
++	private update(): void {
++		this.enabled = !!this.extension;
++	}
++
++	run(): TPromise<any> {
++		const action = <Action>this.instantiationService.createInstance(
++			ConfigureWorkspaceRecommendedExtensionsAction,
++			ConfigureWorkspaceRecommendedExtensionsAction.ID,
++			ConfigureWorkspaceRecommendedExtensionsAction.LABEL
++		);
++		return action.run()
++			.then(() => this.extensionsWorkbenchService.addToWorkspaceRecommendations(this.extension));",Why not call the ExtensionTip service directly to add a recommendation?,2017-05-12 08:46:46
+790,"@@ -394,7 +394,10 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 				if (!fs.existsSync(modulePath)) {
+ 					window.showWarningMessage(localize('noServerFound', 'The path {0} doesn\'t point to a valid tsserver install. Falling back to bundled TypeScript version.', path.dirname(modulePath)));
+ 					modulePath = this.bundledTypeScriptPath;
+-					// TODO check again?
++					if (!fs.existsSync(modulePath)) {
++						window.showErrorMessage(localize('noBundledServerFound', 'Could not find VSCode\'s tsserver install. Please try reinstalling VSCode'));","This error message is only visible in the rare case that the installation was corrupted by a third party program. I think we should be explicit in calling it out: ""VSCode's tsserver was deleted by a another application such as a misbehaving virus detection tool. Please reinstall VS Code."" Otherwise, if I'd see the message you propose right now, I'd think VS Code did something wrong.",2017-03-02 16:25:06
+857,"@@ -4,7 +4,7 @@
+  *--------------------------------------------------------------------------------------------*/
+ 'use strict';
+ 
+-import { Emitter } from 'vs/base/common/event';
++import { Emitter, createEmptyEvent } from 'vs/base/common/event';",Event.none?,2017-03-24 09:49:21
+235,"@@ -4,8 +4,9 @@
+  *--------------------------------------------------------------------------------------------*/
+ 'use strict';
+ 
+-import {onUnexpectedError} from 'vs/base/common/errors';
++import {onUnexpectedError, illegalArgument} from 'vs/base/common/errors';
+ import * as strings from 'vs/base/common/strings';
++import types = require('vs/base/common/types');","no more old school require pls
+",2016-07-15 11:23:31
+231,"@@ -4,9 +4,11 @@
+  *--------------------------------------------------------------------------------------------*/
+ 'use strict';
+ 
++import nls = require('vs/nls');","no more old school require please
+",2016-07-15 11:19:06
+230,"@@ -4,9 +4,11 @@
+  *--------------------------------------------------------------------------------------------*/
+ 'use strict';
+ 
++import nls = require('vs/nls');
+ import {IAction} from 'vs/base/common/actions';
+ import {IEventEmitter, BulkListenerCallback} from 'vs/base/common/eventEmitter';
+ import {MarkedString} from 'vs/base/common/htmlContent';
++import types = require('vs/base/common/types');","no more old school require please
+",2016-07-15 11:18:59
+149,"@@ -40,10 +40,10 @@ exports.loaderConfig = function (emptyPaths) {
+ 			paths: {
+ 				'vs/extensions': 'extensions'
+ 			}
+-		}
++		},
++		nodeModules: emptyPaths||[]","Is this change related to 3077?
+",2016-05-20 08:17:59
+966,"@@ -40,6 +40,10 @@ registry.registerWorkbenchAction(new SyncActionDescriptor(QuickOpenViewPickerAct
+ 	primary: KeyMod.CtrlCmd | KeyCode.KEY_Q, mac: { primary: KeyMod.WinCtrl | KeyCode.KEY_Q }, linux: { primary: null }
+ }), 'Quick Open View');
+ 
++registry.registerWorkbenchAction(new SyncActionDescriptor(ShowTasksAction, ShowTasksAction.ID, ShowTasksAction.LABEL, {",`cmd+shift+t` is taken by 'Reopen closed editor',2017-06-12 21:25:25
+73,"@@ -40,8 +40,8 @@ export class Source {
+ 			// first try to find the raw source amongst the stack frames - since that represenation has more data (source reference),","Looks good.
+",2016-03-16 10:25:09
+583,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||","trimmedLinesContent.length could be 0 here, leading to a call of `trimmedLinesContent.charAt(-1)`. 
+
+You could use if (insertSpace && ....)",2016-12-05 17:09:59
+584,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {","Why are we looking for `)` in the line text here ? i.e. this looks weird to me, why not for `]`. I suggest to remove this unless it is part of some weird join lines spec.",2016-12-05 17:13:08
+585,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {
++					insertSpace = false;
++				}
++
++				trimmedLinesContent += (insertSpace ? ' ' : '') + lineTextWithoutIndent;
++
++				if (insertSpace) {
++					columnDeltaOffset = lineTextWithoutIndent.length + 1;
++				} else {
++					columnDeltaOffset = lineTextWithoutIndent.length;
++				}
++			} else {
++				columnDeltaOffset = 0;
++			}
++		}
++
++		let deleteSelection = new Range(
++			startLineNumber,
++			startColumn,
++			endLineNumber,
++			endColumn
++		);
++
++		if (!deleteSelection.isEmpty()) {
++			if (selection.isEmpty()) {
++				editor.executeCommand(this.id,
++					new ReplaceCommandWithOffsetCursorState(deleteSelection, trimmedLinesContent, 0, -columnDeltaOffset)
++				);
++			} else {
++				if (selection.startLineNumber === selection.endLineNumber) {
++					editor.executeCommand(this.id,
++						new ReplaceCommandThatPreservesSelection(deleteSelection, trimmedLinesContent, selection)
++					);
++				} else {
++					editor.executeCommand(this.id, new ReplaceCommand(deleteSelection, trimmedLinesContent));
++					editor.setSelection(new Selection(selection.startLineNumber, selection.startColumn,
++						selection.startLineNumber, trimmedLinesContent.length - selectionEndPositionOffset));
++				}
++			}
++		}
++	}
++}
++
++@editorAction
++export class TransposeAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transpose',
++			label: nls.localize('editor.transpose', ""Transpose characters around the cursor""),
++			alias: 'Transpose characters around the cursor',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				if (cursor.column > model.getLineContent(cursor.lineNumber).length) {
++					return;
++				}
++
++				let deleteSelection = new Range(cursor.lineNumber, Math.max(1, cursor.column - 1), cursor.lineNumber, cursor.column + 1);
++				let chars = model.getValueInRange(deleteSelection).split('').reverse().join('');
++				commands.push(new ReplaceCommandThatPreservesSelection(deleteSelection, chars,
++					new Selection(cursor.lineNumber, cursor.column + 1, cursor.lineNumber, cursor.column + 1)));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++class PasteAndFormatAction extends EditorAction {",":-1: IMHO on this action.
+
+I would prefer to have an `editor.formatOnPaste` which in my opinion would align more with our current approach to automatic formatting (same as `formatOnType` and `formatOnSave`). @jrieken what do you think?
+
+This one also assumes it knows how paste is implemented in the cursor, but in case of multicursor paste touches multiple ranges, not just one. i.e. `pastedContentRange` is incorrect in case of multicursor paste.
+
+I suggest to wait with this action and consider implementing it in the format contribution, we are shipping since a long time without it, and there's no reason to rush it in.",2016-12-05 17:23:15
+586,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {
++					insertSpace = false;
++				}
++
++				trimmedLinesContent += (insertSpace ? ' ' : '') + lineTextWithoutIndent;
++
++				if (insertSpace) {
++					columnDeltaOffset = lineTextWithoutIndent.length + 1;
++				} else {
++					columnDeltaOffset = lineTextWithoutIndent.length;
++				}
++			} else {
++				columnDeltaOffset = 0;
++			}
++		}
++
++		let deleteSelection = new Range(
++			startLineNumber,
++			startColumn,
++			endLineNumber,
++			endColumn
++		);
++
++		if (!deleteSelection.isEmpty()) {
++			if (selection.isEmpty()) {
++				editor.executeCommand(this.id,
++					new ReplaceCommandWithOffsetCursorState(deleteSelection, trimmedLinesContent, 0, -columnDeltaOffset)
++				);
++			} else {
++				if (selection.startLineNumber === selection.endLineNumber) {
++					editor.executeCommand(this.id,
++						new ReplaceCommandThatPreservesSelection(deleteSelection, trimmedLinesContent, selection)
++					);
++				} else {
++					editor.executeCommand(this.id, new ReplaceCommand(deleteSelection, trimmedLinesContent));
++					editor.setSelection(new Selection(selection.startLineNumber, selection.startColumn,
++						selection.startLineNumber, trimmedLinesContent.length - selectionEndPositionOffset));
++				}
++			}
++		}
++	}
++}
++
++@editorAction
++export class TransposeAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transpose',
++			label: nls.localize('editor.transpose', ""Transpose characters around the cursor""),
++			alias: 'Transpose characters around the cursor',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				if (cursor.column > model.getLineContent(cursor.lineNumber).length) {
++					return;
++				}
++
++				let deleteSelection = new Range(cursor.lineNumber, Math.max(1, cursor.column - 1), cursor.lineNumber, cursor.column + 1);
++				let chars = model.getValueInRange(deleteSelection).split('').reverse().join('');
++				commands.push(new ReplaceCommandThatPreservesSelection(deleteSelection, chars,
++					new Selection(cursor.lineNumber, cursor.column + 1, cursor.lineNumber, cursor.column + 1)));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++class PasteAndFormatAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.pasteAndFormat',
++			label: nls.localize('editor.pasteAndFormat', ""Paste and format""),
++			alias: 'Paste and format',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): TPromise<void> {
++		const originalCursorPosition = editor.getSelection().getStartPosition();
++
++		// 1. paste
++		editor.focus();
++		document.execCommand('paste');
++
++		const currentCursorPosition = editor.getSelection().getStartPosition();
++		const pastedContentRange = new Selection(currentCursorPosition.lineNumber, currentCursorPosition.column, originalCursorPosition.lineNumber, originalCursorPosition.column);
++
++		// 2. format
++		const model = editor.getModel();
++		const { tabSize, insertSpaces } = model.getOptions();
++		const workerService = accessor.get(IEditorWorkerService);
++		const formattingPromise = getDocumentRangeFormattingEdits(model, pastedContentRange, { tabSize, insertSpaces });
++
++		if (!formattingPromise) {
++			return TPromise.as(void 0);
++		}
++
++		const state = editor.captureState(CodeEditorStateFlag.Value, CodeEditorStateFlag.Position);
++
++		return formattingPromise.then(edits => workerService.computeMoreMinimalEdits(editor.getModel().uri, edits, editor.getSelections())).then(edits => {
++			if (!state.validate(editor) || isFalsyOrEmpty(edits)) {
++				return;
++			}
++
++			const command = new EditOperationsCommand(edits, editor.getSelection());
++			editor.executeCommand(this.id, command);
++			editor.focus();
++
++			// 3. update cursor positions
++			let selection = editor.getSelection();
++			selection = new Selection(selection.endLineNumber, selection.endColumn, selection.endLineNumber, selection.endColumn);
++			editor.setSelection(selection);
++		});
++	}
++}
++
++@editorAction
++export class UpperCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToUppercase',
++			label: nls.localize('editor.transformToUppercase', ""Transform to Uppercase""),
++			alias: 'Transform to Uppercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);",`word` can be null here,2016-12-05 17:24:34
+587,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {
++					insertSpace = false;
++				}
++
++				trimmedLinesContent += (insertSpace ? ' ' : '') + lineTextWithoutIndent;
++
++				if (insertSpace) {
++					columnDeltaOffset = lineTextWithoutIndent.length + 1;
++				} else {
++					columnDeltaOffset = lineTextWithoutIndent.length;
++				}
++			} else {
++				columnDeltaOffset = 0;
++			}
++		}
++
++		let deleteSelection = new Range(
++			startLineNumber,
++			startColumn,
++			endLineNumber,
++			endColumn
++		);
++
++		if (!deleteSelection.isEmpty()) {
++			if (selection.isEmpty()) {
++				editor.executeCommand(this.id,
++					new ReplaceCommandWithOffsetCursorState(deleteSelection, trimmedLinesContent, 0, -columnDeltaOffset)
++				);
++			} else {
++				if (selection.startLineNumber === selection.endLineNumber) {
++					editor.executeCommand(this.id,
++						new ReplaceCommandThatPreservesSelection(deleteSelection, trimmedLinesContent, selection)
++					);
++				} else {
++					editor.executeCommand(this.id, new ReplaceCommand(deleteSelection, trimmedLinesContent));
++					editor.setSelection(new Selection(selection.startLineNumber, selection.startColumn,
++						selection.startLineNumber, trimmedLinesContent.length - selectionEndPositionOffset));
++				}
++			}
++		}
++	}
++}
++
++@editorAction
++export class TransposeAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transpose',
++			label: nls.localize('editor.transpose', ""Transpose characters around the cursor""),
++			alias: 'Transpose characters around the cursor',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				if (cursor.column > model.getLineContent(cursor.lineNumber).length) {
++					return;
++				}
++
++				let deleteSelection = new Range(cursor.lineNumber, Math.max(1, cursor.column - 1), cursor.lineNumber, cursor.column + 1);
++				let chars = model.getValueInRange(deleteSelection).split('').reverse().join('');
++				commands.push(new ReplaceCommandThatPreservesSelection(deleteSelection, chars,
++					new Selection(cursor.lineNumber, cursor.column + 1, cursor.lineNumber, cursor.column + 1)));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++class PasteAndFormatAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.pasteAndFormat',
++			label: nls.localize('editor.pasteAndFormat', ""Paste and format""),
++			alias: 'Paste and format',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): TPromise<void> {
++		const originalCursorPosition = editor.getSelection().getStartPosition();
++
++		// 1. paste
++		editor.focus();
++		document.execCommand('paste');
++
++		const currentCursorPosition = editor.getSelection().getStartPosition();
++		const pastedContentRange = new Selection(currentCursorPosition.lineNumber, currentCursorPosition.column, originalCursorPosition.lineNumber, originalCursorPosition.column);
++
++		// 2. format
++		const model = editor.getModel();
++		const { tabSize, insertSpaces } = model.getOptions();
++		const workerService = accessor.get(IEditorWorkerService);
++		const formattingPromise = getDocumentRangeFormattingEdits(model, pastedContentRange, { tabSize, insertSpaces });
++
++		if (!formattingPromise) {
++			return TPromise.as(void 0);
++		}
++
++		const state = editor.captureState(CodeEditorStateFlag.Value, CodeEditorStateFlag.Position);
++
++		return formattingPromise.then(edits => workerService.computeMoreMinimalEdits(editor.getModel().uri, edits, editor.getSelections())).then(edits => {
++			if (!state.validate(editor) || isFalsyOrEmpty(edits)) {
++				return;
++			}
++
++			const command = new EditOperationsCommand(edits, editor.getSelection());
++			editor.executeCommand(this.id, command);
++			editor.focus();
++
++			// 3. update cursor positions
++			let selection = editor.getSelection();
++			selection = new Selection(selection.endLineNumber, selection.endColumn, selection.endLineNumber, selection.endColumn);
++			editor.setSelection(selection);
++		});
++	}
++}
++
++@editorAction
++export class UpperCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToUppercase',
++			label: nls.localize('editor.transformToUppercase', ""Transform to Uppercase""),
++			alias: 'Transform to Uppercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);
++				let wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
++
++				if (wordRange !== undefined) {",???,2016-12-05 17:24:42
+590,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {
++					insertSpace = false;
++				}
++
++				trimmedLinesContent += (insertSpace ? ' ' : '') + lineTextWithoutIndent;
++
++				if (insertSpace) {
++					columnDeltaOffset = lineTextWithoutIndent.length + 1;
++				} else {
++					columnDeltaOffset = lineTextWithoutIndent.length;
++				}
++			} else {
++				columnDeltaOffset = 0;
++			}
++		}
++
++		let deleteSelection = new Range(
++			startLineNumber,
++			startColumn,
++			endLineNumber,
++			endColumn
++		);
++
++		if (!deleteSelection.isEmpty()) {
++			if (selection.isEmpty()) {
++				editor.executeCommand(this.id,
++					new ReplaceCommandWithOffsetCursorState(deleteSelection, trimmedLinesContent, 0, -columnDeltaOffset)
++				);
++			} else {
++				if (selection.startLineNumber === selection.endLineNumber) {
++					editor.executeCommand(this.id,
++						new ReplaceCommandThatPreservesSelection(deleteSelection, trimmedLinesContent, selection)
++					);
++				} else {
++					editor.executeCommand(this.id, new ReplaceCommand(deleteSelection, trimmedLinesContent));
++					editor.setSelection(new Selection(selection.startLineNumber, selection.startColumn,
++						selection.startLineNumber, trimmedLinesContent.length - selectionEndPositionOffset));
++				}
++			}
++		}
++	}
++}
++
++@editorAction
++export class TransposeAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transpose',
++			label: nls.localize('editor.transpose', ""Transpose characters around the cursor""),
++			alias: 'Transpose characters around the cursor',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				if (cursor.column > model.getLineContent(cursor.lineNumber).length) {
++					return;
++				}
++
++				let deleteSelection = new Range(cursor.lineNumber, Math.max(1, cursor.column - 1), cursor.lineNumber, cursor.column + 1);
++				let chars = model.getValueInRange(deleteSelection).split('').reverse().join('');
++				commands.push(new ReplaceCommandThatPreservesSelection(deleteSelection, chars,
++					new Selection(cursor.lineNumber, cursor.column + 1, cursor.lineNumber, cursor.column + 1)));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++class PasteAndFormatAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.pasteAndFormat',
++			label: nls.localize('editor.pasteAndFormat', ""Paste and format""),
++			alias: 'Paste and format',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): TPromise<void> {
++		const originalCursorPosition = editor.getSelection().getStartPosition();
++
++		// 1. paste
++		editor.focus();
++		document.execCommand('paste');
++
++		const currentCursorPosition = editor.getSelection().getStartPosition();
++		const pastedContentRange = new Selection(currentCursorPosition.lineNumber, currentCursorPosition.column, originalCursorPosition.lineNumber, originalCursorPosition.column);
++
++		// 2. format
++		const model = editor.getModel();
++		const { tabSize, insertSpaces } = model.getOptions();
++		const workerService = accessor.get(IEditorWorkerService);
++		const formattingPromise = getDocumentRangeFormattingEdits(model, pastedContentRange, { tabSize, insertSpaces });
++
++		if (!formattingPromise) {
++			return TPromise.as(void 0);
++		}
++
++		const state = editor.captureState(CodeEditorStateFlag.Value, CodeEditorStateFlag.Position);
++
++		return formattingPromise.then(edits => workerService.computeMoreMinimalEdits(editor.getModel().uri, edits, editor.getSelections())).then(edits => {
++			if (!state.validate(editor) || isFalsyOrEmpty(edits)) {
++				return;
++			}
++
++			const command = new EditOperationsCommand(edits, editor.getSelection());
++			editor.executeCommand(this.id, command);
++			editor.focus();
++
++			// 3. update cursor positions
++			let selection = editor.getSelection();
++			selection = new Selection(selection.endLineNumber, selection.endColumn, selection.endLineNumber, selection.endColumn);
++			editor.setSelection(selection);
++		});
++	}
++}
++
++@editorAction
++export class UpperCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToUppercase',
++			label: nls.localize('editor.transformToUppercase', ""Transform to Uppercase""),
++			alias: 'Transform to Uppercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);
++				let wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
++
++				if (wordRange !== undefined) {
++					let text = model.getValueInRange(wordRange);
++					commands.push(new ReplaceCommandThatPreservesSelection(wordRange, text.toLocaleUpperCase(),
++						new Selection(cursor.lineNumber, cursor.column, cursor.lineNumber, cursor.column)));
++				}
++			} else {
++				let text = model.getValueInRange(selection);
++				commands.push(new ReplaceCommandThatPreservesSelection(selection, text.toLocaleUpperCase(), selection));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++export class LowerCaseAction extends EditorAction {",I suggest to create an abstract `CaseAction` that has an abstract method `_modifyText` or whatever that can be overwritten to use `toLocaleUpperCase` and `toLocalLowerCase` to avoid code duplication.,2016-12-05 17:31:57
+588,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {
++					insertSpace = false;
++				}
++
++				trimmedLinesContent += (insertSpace ? ' ' : '') + lineTextWithoutIndent;
++
++				if (insertSpace) {
++					columnDeltaOffset = lineTextWithoutIndent.length + 1;
++				} else {
++					columnDeltaOffset = lineTextWithoutIndent.length;
++				}
++			} else {
++				columnDeltaOffset = 0;
++			}
++		}
++
++		let deleteSelection = new Range(
++			startLineNumber,
++			startColumn,
++			endLineNumber,
++			endColumn
++		);
++
++		if (!deleteSelection.isEmpty()) {
++			if (selection.isEmpty()) {
++				editor.executeCommand(this.id,
++					new ReplaceCommandWithOffsetCursorState(deleteSelection, trimmedLinesContent, 0, -columnDeltaOffset)
++				);
++			} else {
++				if (selection.startLineNumber === selection.endLineNumber) {
++					editor.executeCommand(this.id,
++						new ReplaceCommandThatPreservesSelection(deleteSelection, trimmedLinesContent, selection)
++					);
++				} else {
++					editor.executeCommand(this.id, new ReplaceCommand(deleteSelection, trimmedLinesContent));
++					editor.setSelection(new Selection(selection.startLineNumber, selection.startColumn,
++						selection.startLineNumber, trimmedLinesContent.length - selectionEndPositionOffset));
++				}
++			}
++		}
++	}
++}
++
++@editorAction
++export class TransposeAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transpose',
++			label: nls.localize('editor.transpose', ""Transpose characters around the cursor""),
++			alias: 'Transpose characters around the cursor',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				if (cursor.column > model.getLineContent(cursor.lineNumber).length) {
++					return;
++				}
++
++				let deleteSelection = new Range(cursor.lineNumber, Math.max(1, cursor.column - 1), cursor.lineNumber, cursor.column + 1);
++				let chars = model.getValueInRange(deleteSelection).split('').reverse().join('');
++				commands.push(new ReplaceCommandThatPreservesSelection(deleteSelection, chars,
++					new Selection(cursor.lineNumber, cursor.column + 1, cursor.lineNumber, cursor.column + 1)));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++class PasteAndFormatAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.pasteAndFormat',
++			label: nls.localize('editor.pasteAndFormat', ""Paste and format""),
++			alias: 'Paste and format',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): TPromise<void> {
++		const originalCursorPosition = editor.getSelection().getStartPosition();
++
++		// 1. paste
++		editor.focus();
++		document.execCommand('paste');
++
++		const currentCursorPosition = editor.getSelection().getStartPosition();
++		const pastedContentRange = new Selection(currentCursorPosition.lineNumber, currentCursorPosition.column, originalCursorPosition.lineNumber, originalCursorPosition.column);
++
++		// 2. format
++		const model = editor.getModel();
++		const { tabSize, insertSpaces } = model.getOptions();
++		const workerService = accessor.get(IEditorWorkerService);
++		const formattingPromise = getDocumentRangeFormattingEdits(model, pastedContentRange, { tabSize, insertSpaces });
++
++		if (!formattingPromise) {
++			return TPromise.as(void 0);
++		}
++
++		const state = editor.captureState(CodeEditorStateFlag.Value, CodeEditorStateFlag.Position);
++
++		return formattingPromise.then(edits => workerService.computeMoreMinimalEdits(editor.getModel().uri, edits, editor.getSelections())).then(edits => {
++			if (!state.validate(editor) || isFalsyOrEmpty(edits)) {
++				return;
++			}
++
++			const command = new EditOperationsCommand(edits, editor.getSelection());
++			editor.executeCommand(this.id, command);
++			editor.focus();
++
++			// 3. update cursor positions
++			let selection = editor.getSelection();
++			selection = new Selection(selection.endLineNumber, selection.endColumn, selection.endLineNumber, selection.endColumn);
++			editor.setSelection(selection);
++		});
++	}
++}
++
++@editorAction
++export class UpperCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToUppercase',
++			label: nls.localize('editor.transformToUppercase', ""Transform to Uppercase""),
++			alias: 'Transform to Uppercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);
++				let wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
++
++				if (wordRange !== undefined) {
++					let text = model.getValueInRange(wordRange);
++					commands.push(new ReplaceCommandThatPreservesSelection(wordRange, text.toLocaleUpperCase(),
++						new Selection(cursor.lineNumber, cursor.column, cursor.lineNumber, cursor.column)));
++				}
++			} else {
++				let text = model.getValueInRange(selection);
++				commands.push(new ReplaceCommandThatPreservesSelection(selection, text.toLocaleUpperCase(), selection));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++export class LowerCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToLowercase',
++			label: nls.localize('editor.transformToLowercase', ""Transform to Lowercase""),
++			alias: 'Transform to Lowercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);",`word` can be null here. think of empty lines.,2016-12-05 17:25:00
+589,"@@ -401,3 +407,267 @@ export class DeleteAllLeftAction extends EditorAction {
+ 		editor.executeEdits(this.id, edits);
+ 	}
+ }
++
++@editorAction
++export class JoinLinesAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.joinLines',
++			label: nls.localize('lines.joinLines', ""Join Lines""),
++			alias: 'Join Lines',
++			precondition: EditorContextKeys.Writable,
++			kbOpts: {
++				kbExpr: EditorContextKeys.TextFocus,
++				primary: KeyMod.WinCtrl | KeyCode.KEY_J
++			}
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selection = editor.getSelection();
++		let model = editor.getModel();
++		let startLineNumber = selection.startLineNumber;
++		let startColumn = 1;
++		let endLineNumber: number,
++			endColumn: number,
++			columnDeltaOffset: number;
++
++		let selectionEndPositionOffset = model.getLineContent(selection.endLineNumber).length - selection.endColumn;
++
++		if (selection.isEmpty() || selection.startLineNumber === selection.endLineNumber) {
++			let position = selection.getStartPosition();
++			if (position.lineNumber < model.getLineCount()) {
++				endLineNumber = startLineNumber + 1;
++				endColumn = model.getLineMaxColumn(endLineNumber);
++			} else {
++				endLineNumber = position.lineNumber;
++				endColumn = model.getLineMaxColumn(position.lineNumber);
++			}
++		} else {
++			endLineNumber = selection.endLineNumber;
++			endColumn = model.getLineMaxColumn(endLineNumber);
++		}
++
++		let trimmedLinesContent = model.getLineContent(startLineNumber);
++
++		for (let i = startLineNumber + 1; i <= endLineNumber; i++) {
++			let lineText = model.getLineContent(i);
++			let firstNonWhitespaceIdx = model.getLineFirstNonWhitespaceColumn(i);
++
++			if (firstNonWhitespaceIdx >= 1) {
++				let insertSpace = true;
++				if (trimmedLinesContent === '') {
++					insertSpace = false;
++				}
++
++				if (trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === ' ' ||
++					trimmedLinesContent.charAt(trimmedLinesContent.length - 1) === '\t') {
++					insertSpace = false;
++					trimmedLinesContent = trimmedLinesContent.replace(/[\s\uFEFF\xA0]+$/g, ' ');
++				}
++
++				let lineTextWithoutIndent = lineText.substr(firstNonWhitespaceIdx - 1);
++
++				if (lineTextWithoutIndent.charAt(0) === ')') {
++					insertSpace = false;
++				}
++
++				trimmedLinesContent += (insertSpace ? ' ' : '') + lineTextWithoutIndent;
++
++				if (insertSpace) {
++					columnDeltaOffset = lineTextWithoutIndent.length + 1;
++				} else {
++					columnDeltaOffset = lineTextWithoutIndent.length;
++				}
++			} else {
++				columnDeltaOffset = 0;
++			}
++		}
++
++		let deleteSelection = new Range(
++			startLineNumber,
++			startColumn,
++			endLineNumber,
++			endColumn
++		);
++
++		if (!deleteSelection.isEmpty()) {
++			if (selection.isEmpty()) {
++				editor.executeCommand(this.id,
++					new ReplaceCommandWithOffsetCursorState(deleteSelection, trimmedLinesContent, 0, -columnDeltaOffset)
++				);
++			} else {
++				if (selection.startLineNumber === selection.endLineNumber) {
++					editor.executeCommand(this.id,
++						new ReplaceCommandThatPreservesSelection(deleteSelection, trimmedLinesContent, selection)
++					);
++				} else {
++					editor.executeCommand(this.id, new ReplaceCommand(deleteSelection, trimmedLinesContent));
++					editor.setSelection(new Selection(selection.startLineNumber, selection.startColumn,
++						selection.startLineNumber, trimmedLinesContent.length - selectionEndPositionOffset));
++				}
++			}
++		}
++	}
++}
++
++@editorAction
++export class TransposeAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transpose',
++			label: nls.localize('editor.transpose', ""Transpose characters around the cursor""),
++			alias: 'Transpose characters around the cursor',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				if (cursor.column > model.getLineContent(cursor.lineNumber).length) {
++					return;
++				}
++
++				let deleteSelection = new Range(cursor.lineNumber, Math.max(1, cursor.column - 1), cursor.lineNumber, cursor.column + 1);
++				let chars = model.getValueInRange(deleteSelection).split('').reverse().join('');
++				commands.push(new ReplaceCommandThatPreservesSelection(deleteSelection, chars,
++					new Selection(cursor.lineNumber, cursor.column + 1, cursor.lineNumber, cursor.column + 1)));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++class PasteAndFormatAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.pasteAndFormat',
++			label: nls.localize('editor.pasteAndFormat', ""Paste and format""),
++			alias: 'Paste and format',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): TPromise<void> {
++		const originalCursorPosition = editor.getSelection().getStartPosition();
++
++		// 1. paste
++		editor.focus();
++		document.execCommand('paste');
++
++		const currentCursorPosition = editor.getSelection().getStartPosition();
++		const pastedContentRange = new Selection(currentCursorPosition.lineNumber, currentCursorPosition.column, originalCursorPosition.lineNumber, originalCursorPosition.column);
++
++		// 2. format
++		const model = editor.getModel();
++		const { tabSize, insertSpaces } = model.getOptions();
++		const workerService = accessor.get(IEditorWorkerService);
++		const formattingPromise = getDocumentRangeFormattingEdits(model, pastedContentRange, { tabSize, insertSpaces });
++
++		if (!formattingPromise) {
++			return TPromise.as(void 0);
++		}
++
++		const state = editor.captureState(CodeEditorStateFlag.Value, CodeEditorStateFlag.Position);
++
++		return formattingPromise.then(edits => workerService.computeMoreMinimalEdits(editor.getModel().uri, edits, editor.getSelections())).then(edits => {
++			if (!state.validate(editor) || isFalsyOrEmpty(edits)) {
++				return;
++			}
++
++			const command = new EditOperationsCommand(edits, editor.getSelection());
++			editor.executeCommand(this.id, command);
++			editor.focus();
++
++			// 3. update cursor positions
++			let selection = editor.getSelection();
++			selection = new Selection(selection.endLineNumber, selection.endColumn, selection.endLineNumber, selection.endColumn);
++			editor.setSelection(selection);
++		});
++	}
++}
++
++@editorAction
++export class UpperCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToUppercase',
++			label: nls.localize('editor.transformToUppercase', ""Transform to Uppercase""),
++			alias: 'Transform to Uppercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);
++				let wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
++
++				if (wordRange !== undefined) {
++					let text = model.getValueInRange(wordRange);
++					commands.push(new ReplaceCommandThatPreservesSelection(wordRange, text.toLocaleUpperCase(),
++						new Selection(cursor.lineNumber, cursor.column, cursor.lineNumber, cursor.column)));
++				}
++			} else {
++				let text = model.getValueInRange(selection);
++				commands.push(new ReplaceCommandThatPreservesSelection(selection, text.toLocaleUpperCase(), selection));
++			}
++		}
++
++		editor.executeCommands(this.id, commands);
++	}
++}
++
++@editorAction
++export class LowerCaseAction extends EditorAction {
++	constructor() {
++		super({
++			id: 'editor.action.transformToLowercase',
++			label: nls.localize('editor.transformToLowercase', ""Transform to Lowercase""),
++			alias: 'Transform to Lowercase',
++			precondition: EditorContextKeys.Writable
++		});
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let selections = editor.getSelections();
++		let model = editor.getModel();
++		let commands: ICommand[] = [];
++
++		for (let i = 0, len = selections.length; i < len; i++) {
++			let selection = selections[i];
++			if (selection.isEmpty()) {
++				let cursor = selection.getStartPosition();
++				let word = model.getWordAtPosition(cursor);
++				let wordRange = new Range(cursor.lineNumber, word.startColumn, cursor.lineNumber, word.endColumn);
++
++				if (wordRange !== undefined) {",same ??,2016-12-05 17:25:10
+302,"@@ -404,7 +404,7 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 			}
+ 
+ 			// Focus (unless prevented)
+-			const focus = !options || !options.preserveFocus;
++			const focus = !options || options.preserveFocus;","This cannot be changed...
+",2016-10-05 08:11:45
+721,"@@ -406,15 +409,15 @@ export class WindowsManager implements IWindowsMainService {
+ 			}
+ 
+ 			// Open Files in last instance if any and flag tells us so",The comment should probably be updated,2017-02-07 06:25:31
+739,"@@ -407,12 +415,30 @@ class MouseDownOperation extends Disposable {
+ 		this._dispatchMouse(position, true);
+ 	}
+ 
++	private _onMouseDragThenMove(e: EditorMouseEvent): void {","Merge into `_onMouseDownThenMove` and use `mouseState.lastMouseDownEvent` (which should be renamed to something better, see other comment) to differentiate the two cases",2017-02-20 11:09:03
+740,"@@ -407,12 +415,30 @@ class MouseDownOperation extends Disposable {
+ 		this._dispatchMouse(position, true);
+ 	}
+ 
++	private _onMouseDragThenMove(e: EditorMouseEvent): void {
++		this._lastMouseEvent = e;
++		this._mouseState.setModifiers(e);
++		this._mouseState.setMouseDownEvent('drag');",`this._mouseState.setMouseDownEvent('drag');` should move to the `start` method when the operation starts. The `lastMouseDownEvent` should be set only once when the operation starts inside `start`.,2017-02-20 11:10:21
+805,"@@ -4085,7 +4085,7 @@ declare module 'vscode' {
+ 		 * @param options Options to control how the document will be created.
+ 		 * @return A promise that resolves to a [document](#TextDocument).
+ 		 */
+-		export function openTextDocument(options?: { language: string; }): Thenable<TextDocument>;
++		export function openTextDocument(options?: { language?: string; contents?: string; }): Thenable<TextDocument>;","missing jsdoc-comment, also use `content` to align with `TextDocumentContentProvider`",2017-03-07 08:20:45
+859,"@@ -409,6 +409,10 @@ export function createApiFactory(initData: IInitData, threadService: IThreadServ
+ 			onWillSaveTextDocument: (listener, thisArgs?, disposables?) => {
+ 				return extHostDocumentSaveParticipant.onWillSaveTextDocumentEvent(listener, thisArgs, disposables);
+ 			},
++			onDidChangeDiffInformation: (listener, thisArgs?, disposables?) => {
++				// TODO@joao
++				return createEmptyEvent()(listener, thisArgs, disposables);",We could the be smart about this and *only* send these event from the main side when we have listeners on the ext host side,2017-03-24 09:50:58
+918,"@@ -41,13 +41,12 @@
+ 		}
+ 	},
+ 	""scripts"": {
+-		""compile"": ""node ./node_modules/vscode/bin/compile -watch -p ./"",
+-		""vscode:prepublish"": ""node ../../node_modules/gulp/bin/gulp.js --gulpfile ../../build/gulpfile.extensions.js compile-extension:vscode-api-tests ./tsconfig.json""
++		""compile"": ""gulp compile-extension:vscode-api-tests"",
++		""watch"": ""gulp watch-extension:vscode-api-tests""",The extension shouldn't have an implicit dependency on the *parent* project/package.json. Now it misses the dependency to `gulp` and `typescript`. I'd reckon to simply update the `typescript` dependency here,2017-05-09 07:34:17
+375,"@@ -41,13 +43,16 @@ export class UntitledEditorModel extends StringEditorModel implements IEncodingS
+ 		@IModeService modeService: IModeService,
+ 		@IModelService modelService: IModelService,
+ 		@IFileService private fileService: IFileService,
+-		@IConfigurationService private configurationService: IConfigurationService
++		@IConfigurationService private configurationService: IConfigurationService,
++		@IBackupService private backupService: IBackupService,","Unused service?
+",2016-10-21 14:03:37
+373,"@@ -41,19 +42,26 @@ export class UntitledEditorInput extends AbstractUntitledEditorInput {
+ 		resource: URI,
+ 		hasAssociatedFilePath: boolean,
+ 		modeId: string,
++		restoreResource: URI,
+ 		@IInstantiationService private instantiationService: IInstantiationService,
+ 		@IWorkspaceContextService private contextService: IWorkspaceContextService,
+ 		@IModeService private modeService: IModeService,
+ 		@ITextFileService private textFileService: ITextFileService
+ 	) {
+ 		super();
+ 		this.resource = resource;
++		this.restoreResource = restoreResource;","As mentioned before I think we can get rid of the restoreResource also for untitled. The untitled model should go to the backup service and ask for available backups with the resource URI, similar to how text files now ask.
+",2016-10-21 14:01:46
+175,"@@ -41,6 +41,14 @@ configurationRegistry.registerConfiguration({
+ 		'terminal.integrated.fontFamily': {
+ 			'description': nls.localize('terminal.integrated.fontFamily', ""The font family used by the terminal (CSS font-family format), this defaults to editor.fontFamily's value.""),
+ 			'type': 'string'
++		},
++		'terminal.integrated.fontSize': {","Font size should have a default here, otherwise auto-complete does this.
+
+![image](https://cloud.githubusercontent.com/assets/2193314/15760084/816ab9b0-28c6-11e6-8262-e26f7e994a58.png)
+",2016-06-02 20:33:05
+178,"@@ -41,6 +41,14 @@ configurationRegistry.registerConfiguration({
+ 		'terminal.integrated.fontFamily': {
+ 			'description': nls.localize('terminal.integrated.fontFamily', ""The font family used by the terminal (CSS font-family format), this defaults to editor.fontFamily's value.""),
+ 			'type': 'string'
++		},
++		'terminal.integrated.fontSize': {
++			'description': nls.localize('terminal.integrated.fontSize', ""The font size used by the terminal (in pixels), this defaults to editor.fontSize's value.""),","Sorry but let's go for consistency with the editor settings for this in commonEditorConfig.ts:
+
+```
+""Controls the font family of the terminal.""
+""Controls the font size of the terminal.""
+""Controls the line height of the terminal.""
+```
+",2016-06-02 20:37:43
+176,"@@ -41,6 +41,14 @@ configurationRegistry.registerConfiguration({
+ 		'terminal.integrated.fontFamily': {
+ 			'description': nls.localize('terminal.integrated.fontFamily', ""The font family used by the terminal (CSS font-family format), this defaults to editor.fontFamily's value.""),
+ 			'type': 'string'
++		},
++		'terminal.integrated.fontSize': {
++			'description': nls.localize('terminal.integrated.fontSize', ""The font size used by the terminal (in pixels), this defaults to editor.fontSize's value.""),
++			'type': 'number'
++		},
++		'terminal.integrated.lineHeight': {","Same here, it needs the default set.
+",2016-06-02 20:33:24
+161,"@@ -41,6 +41,14 @@ configurationRegistry.registerConfiguration({
+ 		'terminal.integrated.fontFamily': {
+ 			'description': nls.localize('terminal.integrated.fontFamily', ""The font family used by the terminal (CSS font-family format), this defaults to editor.fontFamily's value.""),
+ 			'type': 'string'
++		},
++		'terminal.integrated.fontSize': {
++			'description': nls.localize('terminal.integrated.fontSize', ""The font size used by the terminal.""),","Add: "" (in pixels)""
+",2016-06-02 06:45:23
+162,"@@ -41,6 +41,14 @@ configurationRegistry.registerConfiguration({
+ 		'terminal.integrated.fontFamily': {
+ 			'description': nls.localize('terminal.integrated.fontFamily', ""The font family used by the terminal (CSS font-family format), this defaults to editor.fontFamily's value.""),
+ 			'type': 'string'
++		},
++		'terminal.integrated.fontSize': {
++			'description': nls.localize('terminal.integrated.fontSize', ""The font size used by the terminal.""),
++			'type': 'number'
++		},
++		'terminal.integrated.lineHeight': {
++			'description': nls.localize('terminal.integrated.lineHeight', ""The line height used by the terminal.""),","Add: "" (in pixels)""
+",2016-06-02 06:45:26
+976,"@@ -41,6 +44,20 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
+ * File a bug in [GitHub Issues](https://github.com/Microsoft/vscode/issues).
+ * [Tweet](https://twitter.com/code) us with other feedback.
+ 
++## Related Products
++Microsoft is distributing its own build as Microsoft Visual Studio Code. 
++You can download packages for Windows, Mac and Linux on [VS Code's website](https://code.visualstudio.com/Download). 
++
++It's based on Code Open Source with some changes:
++* Microsoft branding
++* licensed under Microsoft [closed source custom product license](https://code.visualstudio.com/License) (EULA)
++* Extension Marketplace supported
++* crash reporting and telemetry enabled",maybe add that both can be disabled?,2017-06-16 15:49:42
+973,"@@ -41,6 +44,20 @@ This project has adopted the [Microsoft Open Source Code of Conduct](https://ope
+ * File a bug in [GitHub Issues](https://github.com/Microsoft/vscode/issues).
+ * [Tweet](https://twitter.com/code) us with other feedback.
+ 
++## Related Products
++Microsoft is distributing its own build as Microsoft Visual Studio Code. 
++You can download packages for Windows, Mac and Linux on [VS Code's website](https://code.visualstudio.com/Download). 
++
++It's based on Code Open Source with some changes:
++* Microsoft branding
++* licensed under Microsoft [closed source custom product license](https://code.visualstudio.com/License) (EULA)
++* Extension Marketplace supported
++* crash reporting and telemetry enabled
++* user configuration and extensions stored in different directory then Code - Open Source",Typo: s/then/than/,2017-06-15 03:29:21
+827,"@@ -41,6 +65,7 @@ suite('Workbench - TerminalLinkHandler', () => {
+ 			testLink('c:/a/long/path');
+ 			testLink('c:\\a\\long\\path');
+ 			testLink('c:\\mixed/slash\\path');
++			testLink('a/relative/path');","Will this also linkify just plain words for example `""foo""`? That way after validation the output of `ls` should all be linked. If so a test for that would be great.",2017-03-14 18:40:53
+343,"@@ -410,14 +410,19 @@ export class QuickOpenWidget implements IModelProvider {
+ 
+ 		// Trigger open of element on selection
+ 		if (this.isVisible()) {
+-			const context: IEntryRunContext = { event, keymods: this.extractKeyMods(event), quickNavigateConfiguration: this.quickNavigateConfiguration };
++			let eventForContext = event;
+ 			let mode = Mode.OPEN;
+ 
+-			if (context.event instanceof StandardKeyboardEvent) {
+-				if (context.event.keyCode === KeyCode.RightArrow) {
++			if (event instanceof StandardKeyboardEvent) {
++				eventForContext = event.browserEvent;","@bpasero preserving the browser's event as the context here.  will this work better?  allows us to leave `Mode` logic in `elementSelected`.
+",2016-10-18 17:03:27
+840,"@@ -411,6 +411,10 @@ export class EndOfLineEdit {
+ 	static readonly CRLF: EndOfLineEdit = Object.freeze({ newEol: EndOfLine.CRLF });
+ 
+ 	newEol: EndOfLine;
++
++	constructor(newEol: EndOfLine) {","Any reason you didn't do:
+```ts
+constructor(public newEol: EndOfLine) {
+}
+```
+Is it because there would be an empty function body?",2017-03-21 17:40:03
+340,"@@ -411,7 +411,15 @@ export class QuickOpenWidget implements IModelProvider {
+ 		// Trigger open of element on selection
+ 		if (this.isVisible()) {
+ 			const context: IEntryRunContext = { event, keymods: this.extractKeyMods(event), quickNavigateConfiguration: this.quickNavigateConfiguration };
+-			hide = this.model.runner.run(value, Mode.OPEN, context);
++			let mode = Mode.OPEN;
++
++			if (context.event instanceof KeyboardEvent) {","@wprater can we just send over a flag to indicate this mode from where we call this method with the arrow key right pressed? I think we already create the standard keyboard event there and do not need to create it again here.
+",2016-10-18 09:38:22
+68,"@@ -414,6 +424,14 @@ export class Model extends ee.EventEmitter implements debug.IModel {
+ 		this.emit(debug.ModelEvents.CALLSTACK_UPDATED);
+ 	}
+ 
++	public continueThreads(): void {","I could add the functionality of `continueThreads` to `clearThreads` behind yet another boolean arguments.
+
+I think having an explicit method is better (`clearThreads` is already confusing enough). Let me know what you think.
+",2016-03-16 02:49:32
+707,"@@ -416,65 +496,94 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 		}
+ 
+ 		const shippedVersion = this.getTypeScriptVersion(this.globalTypescriptPath);
+-		const localModulePath = path.join(workspace.rootPath, 'node_modules', 'typescript', 'lib', 'tsserver.js');
++		const localModulePath = this.localTypeScriptPath;
+ 
+-		let messageShown: Thenable<MyMessageItem | undefined>;
+-		if (fs.existsSync(localModulePath) && this.getTypeScriptVersion(localModulePath)) {
++		let messageShown: Thenable<MyQuickPickItem | undefined>;
++		if (localModulePath) {
+ 			const localVersion = this.getTypeScriptVersion(localModulePath);
+ 			const usingWorkspaceVersion = this.workspaceState.get<boolean>(TypeScriptServiceClient.useWorkspaceTsdkStorageKey, false);
+-			messageShown = window.showInformationMessage<MyMessageItem>(
+-				usingWorkspaceVersion
+-					? localize(
+-						'usingWorkspaceTsVersion',
+-						'Using TypeScript version {0} from workspace for IntelliSense.',
+-						localVersion)
+-					: localize(
+-						'usingVSCodeTsVersion',
+-						'Using VSCode\'s TypeScript version {0} for IntelliSense.',
+-						shippedVersion
+-					),
++			messageShown = window.showQuickPick<MyQuickPickItem>([
+ 				{
+-					title: localize('use', 'Use workspace version ({0})', localVersion),
++					label: localize('useWorkspaceVersionOption', 'Use Workspace Version'),
++					description: localVersion || '',
++					detail: modulePath === localModulePath ? localize('activeVersion', 'active') : '',",I'd omit the `active` indication. It's not adding additional information as all information is already in the place holder text.,2017-01-27 02:26:35
+708,"@@ -416,65 +496,94 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 		}
+ 
+ 		const shippedVersion = this.getTypeScriptVersion(this.globalTypescriptPath);
+-		const localModulePath = path.join(workspace.rootPath, 'node_modules', 'typescript', 'lib', 'tsserver.js');
++		const localModulePath = this.localTypeScriptPath;
+ 
+-		let messageShown: Thenable<MyMessageItem | undefined>;
+-		if (fs.existsSync(localModulePath) && this.getTypeScriptVersion(localModulePath)) {
++		let messageShown: Thenable<MyQuickPickItem | undefined>;
++		if (localModulePath) {
+ 			const localVersion = this.getTypeScriptVersion(localModulePath);
+ 			const usingWorkspaceVersion = this.workspaceState.get<boolean>(TypeScriptServiceClient.useWorkspaceTsdkStorageKey, false);
+-			messageShown = window.showInformationMessage<MyMessageItem>(
+-				usingWorkspaceVersion
+-					? localize(
+-						'usingWorkspaceTsVersion',
+-						'Using TypeScript version {0} from workspace for IntelliSense.',
+-						localVersion)
+-					: localize(
+-						'usingVSCodeTsVersion',
+-						'Using VSCode\'s TypeScript version {0} for IntelliSense.',
+-						shippedVersion
+-					),
++			messageShown = window.showQuickPick<MyQuickPickItem>([
+ 				{
+-					title: localize('use', 'Use workspace version ({0})', localVersion),
++					label: localize('useWorkspaceVersionOption', 'Use Workspace Version'),
++					description: localVersion || '',
++					detail: modulePath === localModulePath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useLocal
+ 				}, {
+-					title: localize(
+-						'useVSCodeVersionOption',
+-						'Use VSCode\'s version ({0})',
+-						shippedVersion),
++					label: localize('useVSCodeVersionOption', 'Use VSCode\'s Version'),
++					description: shippedVersion || '',
++					detail: modulePath === this.globalTypescriptPath ? localize('activeVersion', 'active') : '',",I'd omit the `active` indication. It's not adding additional information as all information is already in the place holder text.,2017-01-27 02:26:47
+705,"@@ -416,65 +496,94 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 		}
+ 
+ 		const shippedVersion = this.getTypeScriptVersion(this.globalTypescriptPath);
+-		const localModulePath = path.join(workspace.rootPath, 'node_modules', 'typescript', 'lib', 'tsserver.js');
++		const localModulePath = this.localTypeScriptPath;
+ 
+-		let messageShown: Thenable<MyMessageItem | undefined>;
+-		if (fs.existsSync(localModulePath) && this.getTypeScriptVersion(localModulePath)) {
++		let messageShown: Thenable<MyQuickPickItem | undefined>;
++		if (localModulePath) {
+ 			const localVersion = this.getTypeScriptVersion(localModulePath);
+ 			const usingWorkspaceVersion = this.workspaceState.get<boolean>(TypeScriptServiceClient.useWorkspaceTsdkStorageKey, false);
+-			messageShown = window.showInformationMessage<MyMessageItem>(
+-				usingWorkspaceVersion
+-					? localize(
+-						'usingWorkspaceTsVersion',
+-						'Using TypeScript version {0} from workspace for IntelliSense.',
+-						localVersion)
+-					: localize(
+-						'usingVSCodeTsVersion',
+-						'Using VSCode\'s TypeScript version {0} for IntelliSense.',
+-						shippedVersion
+-					),
++			messageShown = window.showQuickPick<MyQuickPickItem>([
+ 				{
+-					title: localize('use', 'Use workspace version ({0})', localVersion),
++					label: localize('useWorkspaceVersionOption', 'Use Workspace Version'),
++					description: localVersion || '',
++					detail: modulePath === localModulePath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useLocal
+ 				}, {
+-					title: localize(
+-						'useVSCodeVersionOption',
+-						'Use VSCode\'s version ({0})',
+-						shippedVersion),
++					label: localize('useVSCodeVersionOption', 'Use VSCode\'s Version'),
++					description: shippedVersion || '',
++					detail: modulePath === this.globalTypescriptPath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useBundled,
+ 				}, {
+-					title: localize('learnMore', 'Learn More'),
+-					id: MessageAction.learnMore,
+-					isCloseAffordance: true
++					label: localize('learnMore', 'Learn More'),
++					description: '',
++					id: MessageAction.learnMore
++				}], {
++					placeHolder: usingWorkspaceVersion
++						? localize(
++							'usingWorkspaceTsVersion',
++							'Using TypeScript version {0} from workspace for Typescript language features.',",Please use `TypeScript` rather than `Typescript`.,2017-01-27 02:24:57
+706,"@@ -416,65 +496,94 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 		}
+ 
+ 		const shippedVersion = this.getTypeScriptVersion(this.globalTypescriptPath);
+-		const localModulePath = path.join(workspace.rootPath, 'node_modules', 'typescript', 'lib', 'tsserver.js');
++		const localModulePath = this.localTypeScriptPath;
+ 
+-		let messageShown: Thenable<MyMessageItem | undefined>;
+-		if (fs.existsSync(localModulePath) && this.getTypeScriptVersion(localModulePath)) {
++		let messageShown: Thenable<MyQuickPickItem | undefined>;
++		if (localModulePath) {
+ 			const localVersion = this.getTypeScriptVersion(localModulePath);
+ 			const usingWorkspaceVersion = this.workspaceState.get<boolean>(TypeScriptServiceClient.useWorkspaceTsdkStorageKey, false);
+-			messageShown = window.showInformationMessage<MyMessageItem>(
+-				usingWorkspaceVersion
+-					? localize(
+-						'usingWorkspaceTsVersion',
+-						'Using TypeScript version {0} from workspace for IntelliSense.',
+-						localVersion)
+-					: localize(
+-						'usingVSCodeTsVersion',
+-						'Using VSCode\'s TypeScript version {0} for IntelliSense.',
+-						shippedVersion
+-					),
++			messageShown = window.showQuickPick<MyQuickPickItem>([
+ 				{
+-					title: localize('use', 'Use workspace version ({0})', localVersion),
++					label: localize('useWorkspaceVersionOption', 'Use Workspace Version'),
++					description: localVersion || '',
++					detail: modulePath === localModulePath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useLocal
+ 				}, {
+-					title: localize(
+-						'useVSCodeVersionOption',
+-						'Use VSCode\'s version ({0})',
+-						shippedVersion),
++					label: localize('useVSCodeVersionOption', 'Use VSCode\'s Version'),
++					description: shippedVersion || '',
++					detail: modulePath === this.globalTypescriptPath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useBundled,
+ 				}, {
+-					title: localize('learnMore', 'Learn More'),
+-					id: MessageAction.learnMore,
+-					isCloseAffordance: true
++					label: localize('learnMore', 'Learn More'),
++					description: '',
++					id: MessageAction.learnMore
++				}], {
++					placeHolder: usingWorkspaceVersion
++						? localize(
++							'usingWorkspaceTsVersion',
++							'Using TypeScript version {0} from workspace for Typescript language features.',
++							localVersion)
++						: localize(
++							'usingVSCodeTsVersion',
++							'Using VSCode\'s TypeScript version {0} for Typescript language features.',",Should use `TypeScript` rather than `Typescript`,2017-01-27 02:25:09
+709,"@@ -416,65 +496,94 @@ export default class TypeScriptServiceClient implements ITypescriptServiceClient
+ 		}
+ 
+ 		const shippedVersion = this.getTypeScriptVersion(this.globalTypescriptPath);
+-		const localModulePath = path.join(workspace.rootPath, 'node_modules', 'typescript', 'lib', 'tsserver.js');
++		const localModulePath = this.localTypeScriptPath;
+ 
+-		let messageShown: Thenable<MyMessageItem | undefined>;
+-		if (fs.existsSync(localModulePath) && this.getTypeScriptVersion(localModulePath)) {
++		let messageShown: Thenable<MyQuickPickItem | undefined>;
++		if (localModulePath) {
+ 			const localVersion = this.getTypeScriptVersion(localModulePath);
+ 			const usingWorkspaceVersion = this.workspaceState.get<boolean>(TypeScriptServiceClient.useWorkspaceTsdkStorageKey, false);
+-			messageShown = window.showInformationMessage<MyMessageItem>(
+-				usingWorkspaceVersion
+-					? localize(
+-						'usingWorkspaceTsVersion',
+-						'Using TypeScript version {0} from workspace for IntelliSense.',
+-						localVersion)
+-					: localize(
+-						'usingVSCodeTsVersion',
+-						'Using VSCode\'s TypeScript version {0} for IntelliSense.',
+-						shippedVersion
+-					),
++			messageShown = window.showQuickPick<MyQuickPickItem>([
+ 				{
+-					title: localize('use', 'Use workspace version ({0})', localVersion),
++					label: localize('useWorkspaceVersionOption', 'Use Workspace Version'),
++					description: localVersion || '',
++					detail: modulePath === localModulePath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useLocal
+ 				}, {
+-					title: localize(
+-						'useVSCodeVersionOption',
+-						'Use VSCode\'s version ({0})',
+-						shippedVersion),
++					label: localize('useVSCodeVersionOption', 'Use VSCode\'s Version'),
++					description: shippedVersion || '',
++					detail: modulePath === this.globalTypescriptPath ? localize('activeVersion', 'active') : '',
+ 					id: MessageAction.useBundled,
+ 				}, {
+-					title: localize('learnMore', 'Learn More'),
+-					id: MessageAction.learnMore,
+-					isCloseAffordance: true
++					label: localize('learnMore', 'Learn More'),
++					description: '',
++					id: MessageAction.learnMore
++				}], {
++					placeHolder: usingWorkspaceVersion
++						? localize(
++							'usingWorkspaceTsVersion',
++							'Using TypeScript version {0} from workspace for Typescript language features.',
++							localVersion)
++						: localize(
++							'usingVSCodeTsVersion',
++							'Using VSCode\'s TypeScript version {0} for Typescript language features.',
++							shippedVersion),
+ 				});
+ 		} else {
+-			messageShown = window.showInformationMessage<MyMessageItem>(
+-				localize(
+-					'versionCheckUsingBundledTS',
+-					'Using VSCode\'s TypeScript version {0} for IntelliSense.',
+-					shippedVersion),
++			messageShown = window.showQuickPick<MyQuickPickItem>([
+ 				{
+-					title: localize('learnMore', 'Learn More'),
+-					id: MessageAction.learnMore,
+-					isCloseAffordance: true,
++					label: localize('learnMore', 'Learn More'),
++					description: '',
++
++					id: MessageAction.learnMore
+ 				}, {
+-					title: localize('close', 'Close'),
+-					id: MessageAction.close,
+-					isCloseAffordance: true,
++					label: localize('close', 'Close'),
++					description: '',
++					id: MessageAction.close
++				}],
++				{
++					placeHolder: localize(
++						'versionCheckUsingBundledTS',
++						'Using VSCode\'s TypeScript version {0} for Typescript language features.',
++						shippedVersion),
+ 				});
+ 		}
+ 
++		const tryShowRestart = (newModulePath: string) => {
++			if (newModulePath === this.modulePath) {
++				return;
++			}
++
++			window.showInformationMessage<MessageItem>(
++				localize('restartBlurb', 'Restart VSCode to apply change'),",We don't use `restart` anywhere else. I think we should use `Reload window to apply changes`.,2017-01-27 02:30:14
+229,"@@ -4164,6 +4167,33 @@ export var EventType = {
+ };
+ 
+ /**
++ * Positions on the view
++ */
++export const ViewPosition = {","I suggest renaming `ViewPosition` to `MoveCommandViewPosition` or something more specific -- for someone looking at `monaco.d.ts` the current name might be very confusing, as it is simply typing an argument to a specific command and is not a new concept of `Position` <-> `ViewPosition`.
+",2016-07-15 11:18:43
+227,"@@ -4164,6 +4167,33 @@ export var EventType = {
+ };
+ 
+ /**
++ * Positions on the view
++ */
++export const ViewPosition = {
++	LineStart: 'lineStart',
++	LineFirstNonWhitespaceCharacter: 'lineFirstNonWhitespaceCharacter',","Sometimes referred to as ""soft start"". @jrieken @sandy081 -- would `lineSoftStart` be easier to program against?
+",2016-07-15 11:16:46
+228,"@@ -4164,6 +4167,33 @@ export var EventType = {
+ };
+ 
+ /**
++ * Positions on the view
++ */
++export const ViewPosition = {
++	LineStart: 'lineStart',
++	LineFirstNonWhitespaceCharacter: 'lineFirstNonWhitespaceCharacter',
++	LineCenter: 'lineCenter',
++	LineEnd: 'lineEnd',
++	LineLastNonWhitespaceCharacter: 'lineLastNonWhitespaceCharacter'","Same as above, `lineSoftEnd` -- would that be confusing?
+",2016-07-15 11:17:09
+225,"@@ -4164,6 +4167,33 @@ export var EventType = {
+ };
+ 
+ /**
++ * Positions on the view
++ */
++export const ViewPosition = {
++	LineStart: 'lineStart',
++	LineFirstNonWhitespaceCharacter: 'lineFirstNonWhitespaceCharacter',
++	LineCenter: 'lineCenter',
++	LineEnd: 'lineEnd',
++	LineLastNonWhitespaceCharacter: 'lineLastNonWhitespaceCharacter'
++};
++
++/**
++ * @internal
++ */
++export var CommandDescription= {","space before =
+",2016-07-15 11:13:54
+226,"@@ -4164,6 +4167,33 @@ export var EventType = {
+ };
+ 
+ /**
++ * Positions on the view
++ */
++export const ViewPosition = {
++	LineStart: 'lineStart',
++	LineFirstNonWhitespaceCharacter: 'lineFirstNonWhitespaceCharacter',
++	LineCenter: 'lineCenter',
++	LineEnd: 'lineEnd',
++	LineLastNonWhitespaceCharacter: 'lineLastNonWhitespaceCharacter'
++};
++
++/**
++ * @internal
++ */
++export var CommandDescription= {
++	CursorMove: <ICommandHandlerDescription>{
++		description: nls.localize('editorCommand.cursorMove.description', ""Move cursor to a logical position in the view""),
++		args: [
++			{","@jrieken Is this correct? I think the name and description should apply to `firstArgument.to` not to `firstArgument`.
+",2016-07-15 11:15:35
+159,"@@ -42,6 +42,26 @@ configurationRegistry.registerConfiguration({
+ 			'description': nls.localize('terminal.integrated.fontFamily', ""The font family used by the terminal (CSS font-family format).""),
+ 			'type': 'string',
+ 			'default': 'Menlo, Monaco, Consolas, ""Droid Sans Mono"", ""Courier New"", monospace, ""Droid Sans Fallback""'
++		},
++		'terminal.integrated.fontSize': {
++			'description': nls.localize('terminal.integrated.fontSize', ""The font size used by the terminal (CSS font-size format).""),
++			'type': 'string',
++			'default': ''
++		},
++		'terminal.integrated.lineHeight': {
++			'description': nls.localize('terminal.integrated.lineHeight', ""The line height used by the terminal (CSS line height format).""),
++			'type': 'string',
++			'default': ''
++		},
++		'terminal.integrated.charWidth': {","I think https://github.com/Microsoft/vscode/issues/6456 should be figured out before the font size and line height is added to prevent addition the `charWidth`/`charHeight` settings.
+",2016-05-28 20:51:32
+553,"@@ -42,6 +42,7 @@ export interface IEnvironmentService {
+ 
+ 	execPath: string;
+ 	appRoot: string;
++	vscodeWindowId: string;","@Tyriar we cannot really add this here because environment service is agnostic to windows, we have one in the shared process as well as the CLI. I suggest to put this into the `IWindowService` on the renderer side.",2016-12-01 16:29:03
+989,"@@ -422,4 +423,13 @@ export function registerCommands(): void {
+ 			return void 0;
+ 		});
+ 	});
++
++	CommandsRegistry.registerCommand('_workbench.quickOpen', function (accessor: ServicesAccessor, args: [string, IShowOptions]) {
++		const quickOpenService = accessor.get(IQuickOpenService);",Remove `IShowOptions`,2017-06-19 10:40:16
+360,"@@ -424,6 +435,10 @@ export class HistoryService extends BaseHistoryService implements IHistoryServic
+ 		}
+ 	}
+ 
++	private isEditorEagerlyPreviewing(editor: IBaseEditor): boolean {","@wprater why is this method needed? We already have the `block()` method for this purpose and should only rely on that.
+",2016-10-21 09:53:51
+744,"@@ -424,6 +450,36 @@ class MouseDownOperation extends Disposable {
+ 		// Overwrite the detail of the MouseEvent, as it will be sent out in an event and contributions might rely on it.
+ 		e.detail = this._mouseState.count;
+ 
++		if (!this._mouseState.altKey // we don't support multiple mouse",We should also include a test for an editor option here. `editor.dragAndDrop` or something... `this._context.configuration.editor` is available in this class.,2017-02-20 11:28:17
+741,"@@ -424,6 +450,36 @@ class MouseDownOperation extends Disposable {
+ 		// Overwrite the detail of the MouseEvent, as it will be sent out in an event and contributions might rely on it.
+ 		e.detail = this._mouseState.count;
+ 
++		if (!this._mouseState.altKey // we don't support multiple mouse
++			&& e.detail < 2 // only single click on a selection can work
++			&& !this._isActive // the mouse is not down yet
++			&& !this._currentSelection.isEmpty() // we don't drag single cursor
++			&& this._currentSelection.containsPosition(position.position) // single click on a selection
++		) {
++			this._isActive = true;
++			this._dropTarget = this._createMouseTarget(e, true);",This is where `this._mouseState.setMouseDownEvent('drag');` should be set,2017-02-20 11:10:51
+742,"@@ -424,6 +450,36 @@ class MouseDownOperation extends Disposable {
+ 		// Overwrite the detail of the MouseEvent, as it will be sent out in an event and contributions might rely on it.
+ 		e.detail = this._mouseState.count;
+ 
++		if (!this._mouseState.altKey // we don't support multiple mouse
++			&& e.detail < 2 // only single click on a selection can work
++			&& !this._isActive // the mouse is not down yet
++			&& !this._currentSelection.isEmpty() // we don't drag single cursor
++			&& this._currentSelection.containsPosition(position.position) // single click on a selection
++		) {
++			this._isActive = true;
++			this._dropTarget = this._createMouseTarget(e, true);
++
++			this._mouseMoveMonitor.startMonitoring(
++				createMouseMoveEventMerger(null),
++				this._mouseDragThenMoveEventHandler.handler,
++				() => {
++					if (this._mouseState.lastMouseDownEvent !== 'drag') {","when can this happen?
+
+IMHO the mouseState is set to `drag` or `mouseDown` and it should not change while the mouse is pressed (i.e. while the global mouse monitoring is active). ",2017-02-20 11:11:55
+891,"@@ -425,11 +431,20 @@ export class VSCodeWindow {
+ 	}
+ 
+ 	private onConfigurationUpdated(config: IConfiguration): void {
+-		const newMenuBarVisibility = this.getMenuBarVisibility(config);
++		const newMenuBarVisibility = this.getMenuBarVisibility();
+ 		if (newMenuBarVisibility !== this.currentMenuBarVisibility) {
+ 			this.currentMenuBarVisibility = newMenuBarVisibility;
+ 			this.setMenuBarVisibility(newMenuBarVisibility);
+ 		}
++
++		// Swipe command support (macOS)
++		const workbenchConfig = this.configurationService.getConfiguration<IWorkbenchEditorConfiguration>();
++		if (workbenchConfig && workbenchConfig.workbench && workbenchConfig.workbench.editor.swipeBetweenOpenFiles) {","Careful here, `workbenchConfig.workbench.editor` can be `null` so we need another `null` check.",2017-04-18 05:52:20
+490,"@@ -426,6 +430,11 @@ export class VSCodeWindow {
+ 		delete configuration.filesToCreate;
+ 		delete configuration.filesToDiff;
+ 
++		// Update untitled files to restore so they come through in the reloaded window","@Tyriar I am thinking more and more that untitled editors with backups should not be loaded from the main side but rather from the window itself. Files for example restore because we store their state into local storage (via `IEditorInputFactory` -  see https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/common/editor/editorStacksModel.ts#L621).
+
+If we add a factory for untitled editors, we would just rely on that to bring the untitled back on reopen. It would also fix the issue that untitled would reopen at the right location where they where before. 
+",2016-11-15 05:58:48
+464,"@@ -426,6 +430,11 @@ export class VSCodeWindow {
+ 		delete configuration.filesToCreate;
+ 		delete configuration.filesToDiff;
+ 
++		// Update untitled files to restore so they come through in the reloaded window
++		configuration.untitledToRestore = this.backupService.getWorkspaceUntitledFileBackupsSync(Uri.file(configuration.workspacePath)).map(filePath => {","@Tyriar not a big fan of all the sync fs calls. Why can the state of backups not be in memory in the backup service? there should be no other process writing to the file or?
+",2016-11-09 07:15:07
+465,"@@ -426,6 +430,11 @@ export class VSCodeWindow {
+ 		delete configuration.filesToCreate;
+ 		delete configuration.filesToDiff;
+ 
++		// Update untitled files to restore so they come through in the reloaded window
++		configuration.untitledToRestore = this.backupService.getWorkspaceUntitledFileBackupsSync(Uri.file(configuration.workspacePath)).map(filePath => {
++			return { filePath: filePath };","@Tyriar TS allows you a nicer short hand syntax here:
+
+`return { filePath };`
+",2016-11-09 07:15:32
+153,"@@ -43,12 +43,13 @@ export enum TokenType {
+ 	Resolution,
+ 	Comma,
+ 	Charset,
+-
+ 	EscapedJavaScript,
+ 	BadEscapedJavaScript,
+ 	Comment,
+ 	SingleLineComment,
+ 	EOF,
++	Var,","we shouldn't have a special token for `var`. `var` should stay an identifier as there might be selectors of that name, or many other places where `var` is a valid identifier.
+",2016-05-20 10:02:48
+339,"@@ -43,7 +43,8 @@ export interface IAutoFocus {
+ 
+ export enum Mode {
+ 	PREVIEW,
+-	OPEN
++	OPEN,
++	OPEN_BEHIND","@wprater maybe better ""OPEN_IN_BACKGROUND""?
+",2016-10-18 09:36:24
+687,"@@ -431,11 +430,7 @@ export class RawDebugSession extends v8.V8Protocol implements debug.ISession {
+ 	}
+ 
+ 	private startServer(): TPromise<any> {
+-		if (!this.adapter.program) {
+-			return TPromise.wrapError(new Error(nls.localize('noDebugAdapterExtensionInstalled', ""No extension installed for '{0}' debugging."", this.adapter.type)));
+-		}
+-
+-		return this.getLaunchDetails().then(d => this.launchServer(d).then(() => {
++		return this.adapter.getAdapterExecutable().then(d => this.launchServer(d).then(() => {",`d` is the wrong acronym here,2017-01-18 14:11:21
+436,"@@ -438,8 +438,7 @@ export class VSCodeMenu {
+ 	private createOpenRecentMenuItem(path: string): Electron.MenuItem {
+ 		return new MenuItem({
+ 			label: unMnemonicLabel(path), click: (menuItem, win, event) => {
+-				const openInNewWindow = event && ((!platform.isMacintosh && event.ctrlKey) || (platform.isMacintosh && event.metaKey));
+-				const success = !!this.windowsService.open({ cli: this.environmentService.args, pathsToOpen: [path], forceNewWindow: openInNewWindow });
++				const success = !!this.windowsService.open({ cli: this.environmentService.args, pathsToOpen: [path] });","@elemongw can we keep the semantic of forcing a new window when the user presses the Ctrl/Meta key? I see no reason to remove it.
+",2016-11-03 07:30:40
+192,"@@ -44,20 +44,20 @@
+ },
+ {
+ 	""name"": ""libchromiumcontent"",
+-	""version"": ""49.0.2623.75"",
++	""version"": ""51.0.2704.103"",
+ 	""license"": ""MIT"",
+ 	""repositoryURL"": ""https://github.com/electron/libchromiumcontent"",
+ 	""isProd"": true
+ },
+ {
+ 	""name"": ""nodejs"",
+-	""version"": ""5.10.0"",
++	""version"": ""6.10.0"",","@bpasero, that's a bit wrong, isn't it? :cat:
+
+Current version Node.js: v6.2.2
+Current version Node.js in Electron: 6.1.0
+",2016-07-02 13:31:12
+173,"@@ -44,22 +42,23 @@ export class TerminalPanel extends Panel {
+ 		@IThemeService private themeService: IThemeService
+ 	) {
+ 		super(TERMINAL_PANEL_ID, telemetryService);
+-		this.configurationHelper = new TerminalConfigHelper(platform.platform, this.configurationService, this.themeService);
+ 		this.toDispose = [];
+ 	}
+ 
+ 	public layout(dimension: Dimension): void {
+-		let cols = Math.floor(this.parentDomElement.offsetWidth / TERMINAL_CHAR_WIDTH);
+-		let rows = Math.floor(this.parentDomElement.offsetHeight / TERMINAL_CHAR_HEIGHT);
+-		if (this.terminal) {
+-			this.terminal.resize(cols, rows);
+-		}
+-		if (this.ptyProcess.connected) {
+-			this.ptyProcess.send({
+-				event: 'resize',
+-				cols: cols,
+-				rows: rows
+-			});
++		if (this.font.charWidth && this.font.charHeight) {","Prefer early exits to keep indentation low:
+
+```
+if (!this.font.charWidth || !this.font.charHeight) {
+    return;
+}
+```
+
+Also should this attempt to measure at this point or would that just be rework?
+",2016-06-02 20:21:21
+777,"@@ -44,26 +41,22 @@ export default class MarkdownDocumentLinkProvider implements vscode.DocumentLink
+ 		return results;
+ 	}
+ 
+-	private normalizeLink(link: string, base: string, toc: TableOfContentProvider): vscode.Uri {
+-		let uri = vscode.Uri.parse(link);
+-		if (!uri.scheme) {
+-			if (uri.fragment && !uri.path) {
+-				// local link
+-				const line = toc.lookup(uri.fragment);
+-				if (!isNaN(line)) {
+-					return vscode.Uri.parse(`command:revealLine?${encodeURIComponent(JSON.stringify({ lineNumber: line, at: 'top' }))}`);
+-				}
+-			}
++	private normalizeLink(document: vscode.TextDocument, link: string, base: string): vscode.Uri {
++		const uri = vscode.Uri.parse(link);
++		if (uri.scheme) {
++			return uri;
++		}
+ 
+-			// assume it must be a file
+-			let file;
+-			if (uri.path[0] === '/') {
+-				file = path.join(vscode.workspace.rootPath, uri.path);
+-			} else {
+-				file = path.join(base, uri.path);
+-			}
+-			uri = vscode.Uri.file(file);
++		// assume it must be a file
++		let resourcePath;
++		if (!uri.path) {
++			resourcePath = document.uri.path;
++		} else if (uri.path[0] === '/') {
++			resourcePath = path.join(vscode.workspace.rootPath, uri.path);
++		} else {
++			resourcePath = path.join(base, uri.path);
+ 		}
+-		return uri;
++
++		return vscode.Uri.parse(`command:_markdown.openDocumentLink?${encodeURIComponent(JSON.stringify({ fragment: uri.fragment, path: resourcePath }))}`);","This is a lot of code for using an URI that goes like this: `file:///files/thisFile.md#L22`. Unless there are bugs which I would happily fix, the `OpenerService` should handle such links correctly.",2017-02-24 11:39:50
+452,"@@ -440,6 +440,7 @@ export class EditorOptions implements IEditorOptions {
+ 		options.forceOpen = settings.forceOpen;
+ 		options.revealIfVisible = settings.revealIfVisible;
+ 		options.pinned = settings.pinned;
++		options.forcePreview = settings.forcePreview;","@wprater can you quickly check where else in this file options are handled, I think you missed to add this new flag e.g. to `TextDiffEditorOptions`
+",2016-11-05 07:32:13
+285,"@@ -441,66 +441,81 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 		// A save participant can still change the model now and since we are so close to saving
+ 		// we do not want to trigger another auto save or similar, so we block this
+ 		// In addition we update our version right after in case it changed because of a model change
++		let saveParticipantPromise = TPromise.as(versionId);
++
+ 		if (TextFileEditorModel.saveParticipant) {
+-			this.blockModelContentChange = true;
+-			try {
+-				TextFileEditorModel.saveParticipant.participate(this, { isAutoSaved });
+-			} finally {
++			saveParticipantPromise = TPromise.as(undefined).then(() => {
++				this.blockModelContentChange = true;
++				return TextFileEditorModel.saveParticipant.participate(this, { isAutoSaved });
++			}).then(() => {
+ 				this.blockModelContentChange = false;
+-			}
+-			versionId = this.versionId;
++				return this.versionId;
++			}, err => {
++				this.blockModelContentChange = false;
++				return TPromise.wrapError(err);","@jrieken this is a semantical change from how it worked before where a save participant error would never make the save operation fail. maybe we should ignore the possible errors from save participants (especially since they can now come from extensions) and always allow the save to take place.
+",2016-09-21 06:23:59
+286,"@@ -441,66 +441,81 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 		// A save participant can still change the model now and since we are so close to saving
+ 		// we do not want to trigger another auto save or similar, so we block this
+ 		// In addition we update our version right after in case it changed because of a model change
++		let saveParticipantPromise = TPromise.as(versionId);
++
+ 		if (TextFileEditorModel.saveParticipant) {
+-			this.blockModelContentChange = true;
+-			try {
+-				TextFileEditorModel.saveParticipant.participate(this, { isAutoSaved });
+-			} finally {
++			saveParticipantPromise = TPromise.as(undefined).then(() => {
++				this.blockModelContentChange = true;
++				return TextFileEditorModel.saveParticipant.participate(this, { isAutoSaved });
++			}).then(() => {
+ 				this.blockModelContentChange = false;
+-			}
+-			versionId = this.versionId;
++				return this.versionId;
++			}, err => {
++				this.blockModelContentChange = false;
++				return TPromise.wrapError(err);
++			});
+ 		}
+ 
+-		// Clear error flag since we are trying to save again
+-		this.inErrorMode = false;
++		this.mapPendingSaveToVersionId[versionId] = saveParticipantPromise.then(newVersionId => {","@jrieken is there a reason why you chose to store the save participant into `mapPendingSaveToVersionId`, then delete it and later store it in `mapPendingSaveToVersionId` again for the `updateContent` call?
+
+Easier to read and understand, I suggest to store the save participant promise into `mapPendingSaveToVersionId` as you do now, but do not delete it right after. Rather let the promise from `this.fileService.updateContent` also contribute to the overall pending save. 
+
+In other words, a pending save is the sum of running save participants and saving to disk.
+",2016-09-21 06:27:04
+287,"@@ -441,66 +441,81 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 		// A save participant can still change the model now and since we are so close to saving
+ 		// we do not want to trigger another auto save or similar, so we block this
+ 		// In addition we update our version right after in case it changed because of a model change
++		let saveParticipantPromise = TPromise.as(versionId);
++
+ 		if (TextFileEditorModel.saveParticipant) {
+-			this.blockModelContentChange = true;
+-			try {
+-				TextFileEditorModel.saveParticipant.participate(this, { isAutoSaved });
+-			} finally {
++			saveParticipantPromise = TPromise.as(undefined).then(() => {
++				this.blockModelContentChange = true;
++				return TextFileEditorModel.saveParticipant.participate(this, { isAutoSaved });
++			}).then(() => {
+ 				this.blockModelContentChange = false;
+-			}
+-			versionId = this.versionId;
++				return this.versionId;
++			}, err => {
++				this.blockModelContentChange = false;
++				return TPromise.wrapError(err);
++			});
+ 		}
+ 
+-		// Clear error flag since we are trying to save again
+-		this.inErrorMode = false;
++		this.mapPendingSaveToVersionId[versionId] = saveParticipantPromise.then(newVersionId => {
+ 
+-		// Remember when this model was saved last
+-		this.lastSaveAttemptTime = Date.now();
+-
+-		// Save to Disk
+-		diag(`doSave(${versionId}) - before updateContent()`, this.resource, new Date());
+-		this.mapPendingSaveToVersionId[versionId] = this.fileService.updateContent(this.versionOnDiskStat.resource, this.getValue(), {
+-			overwriteReadonly: overwriteReadonly,
+-			overwriteEncoding: overwriteEncoding,
+-			mtime: this.versionOnDiskStat.mtime,
+-			encoding: this.getEncoding(),
+-			etag: this.versionOnDiskStat.etag
+-		}).then((stat: IFileStat) => {
+-			diag(`doSave(${versionId}) - after updateContent()`, this.resource, new Date());
+-
+-			// Remove from pending saves
++			// remove save participant promise and update versionId with
++			// its new value (if pre-save changes happened)
+ 			delete this.mapPendingSaveToVersionId[versionId];
++			versionId = newVersionId;
+ 
+-			// Telemetry
+-			this.telemetryService.publicLog('filePUT', { mimeType: stat.mime, ext: paths.extname(this.versionOnDiskStat.resource.fsPath) });
++			// Clear error flag since we are trying to save again
++			this.inErrorMode = false;
+ 
+-			// Update dirty state unless model has changed meanwhile
+-			if (versionId === this.versionId) {
+-				diag(`doSave(${versionId}) - setting dirty to false because versionId did not change`, this.resource, new Date());
+-				this.setDirty(false);
+-			} else {
+-				diag(`doSave(${versionId}) - not setting dirty to false because versionId did change meanwhile`, this.resource, new Date());
+-			}
++			// Remember when this model was saved last
++			this.lastSaveAttemptTime = Date.now();
++
++			// Save to Disk
++			diag(`doSave(${versionId}) - before updateContent()`, this.resource, new Date());
++			this.mapPendingSaveToVersionId[versionId] = this.fileService.updateContent(this.versionOnDiskStat.resource, this.getValue(), {","@jrieken as per my comment above I would here just return the promise and not add it to the map, since it is already added from the save participant.
+",2016-09-21 06:27:33
+561,"@@ -441,7 +441,17 @@ export class WindowsManager implements IWindowsMainService {
+ 		}
+ 
+ 		// Handle empty
+-		if (emptyToOpen.length > 0) {
++		if (emptyToRestore.length > 0) {
++			emptyToRestore.forEach(backupFolder => {
++				const configuration = this.toConfiguration(openConfig, null, null, null, null, backupFolder);","@Tyriar something is weird about `backupFolder`. As someone that tries to understand the code I would assume every window has an associated `backupFolder`. but that is not true, only the empty windows to restore have it. I would make this more obvious. Maybe remove the property from `IWindowConfiguration` and just pass it into `openInBrowserWindow` method? Also needs a clearer name to make its meaning more obvious.",2016-12-02 06:53:45
+558,"@@ -441,7 +441,17 @@ export class WindowsManager implements IWindowsMainService {
+ 		}
+ 
+ 		// Handle empty
+-		if (emptyToOpen.length > 0) {
++		if (emptyToRestore.length > 0) {
++			emptyToRestore.forEach(backupFolder => {
++				const configuration = this.toConfiguration(openConfig, null, null, null, null, backupFolder);
++				const browserWindow = this.openInBrowserWindow(configuration, openInNewWindow, openInNewWindow ? void 0 : openConfig.windowToUse);","@Tyriar we always want each of these windows to open inside a new window so I suggest to just call 
+
+`const browserWindow = this.openInBrowserWindow(configuration, true /* new window */);`
+
+In the same way as we do for restoring folders.",2016-12-02 06:43:30
+550,"@@ -441,7 +442,20 @@ export class WindowsManager implements IWindowsMainService {
+ 		}
+ 
+ 		// Handle empty
+-		if (emptyToOpen.length > 0) {
++		if (emptyToRestore.length > 0) {
++			// TODO: There's an extra empty workspace opening when restoring an empty workspace (sometimes)
++			emptyToRestore.forEach(vscodeWindowId => {
++				const configuration = this.toConfiguration(openConfig);
++				configuration.vscodeWindowId = vscodeWindowId;",@Tyriar why is this done here and not inside the `toConfiguration` method?,2016-12-01 16:24:01
+562,"@@ -444,7 +444,7 @@ export class WindowsManager implements IWindowsMainService {
+ 		if (emptyToRestore.length > 0) {
+ 			emptyToRestore.forEach(emptyWorkspaceBackupFolder => {
+ 				const configuration = this.toConfiguration(openConfig, null, null, null, null);
+-				const browserWindow = this.openInBrowserWindow(configuration, openInNewWindow, openInNewWindow ? void 0 : openConfig.windowToUse, emptyWorkspaceBackupFolder);
++				const browserWindow = this.openInBrowserWindow(configuration, true /* new window */, openInNewWindow ? void 0 : openConfig.windowToUse, emptyWorkspaceBackupFolder);",@Tyriar I would not assume we have a `windowToUse` in this case ever?,2016-12-02 08:27:20
+57,"@@ -45,3 +29,25 @@ registerMode({
+ 	moduleId: 'vs/workbench/parts/output/common/outputMode',
+ 	ctorName: 'OutputMode'
+ });
++
++// Register Output Panel
++(<panel.PanelRegistry>platform.Registry.as(panel.Extensions.Panels)).registerPanel(new panel.PanelDescriptor(","@isidorn do not forget to add the panel to the same buildfile.js where we added REPL so that the loader can load it
+",2016-01-21 15:54:22
+58,"@@ -45,3 +29,25 @@ registerMode({
+ 	moduleId: 'vs/workbench/parts/output/common/outputMode',
+ 	ctorName: 'OutputMode'
+ });
++
++// Register Output Panel
++(<panel.PanelRegistry>platform.Registry.as(panel.Extensions.Panels)).registerPanel(new panel.PanelDescriptor(
++	'vs/workbench/parts/output/browser/outputPanel',
++	'OutputPanel',
++	OUTPUT_PANEL_ID,
++	nls.localize('output', ""Output""),
++	'output',
++	40","@isidorn I dont think we need the ""order"" property for panels, it is used for showing the actions in the activity bar only
+",2016-01-21 15:55:43
+198,"@@ -45,6 +47,19 @@ KeybindingsRegistry.registerCommandDesc({
+ 
+ type ApiThemeClassName = 'vscode-light' | 'vscode-dark' | 'vscode-high-contrast';
+ 
++function isDefaultKeyboardEvent(e: KeyboardEvent): boolean {
++	let keyEvent = new StandardKeyboardEvent(e);
++	let keybinding = keyEvent.asKeybinding();
++	switch (keybinding) {
++		case KeyMod.CtrlCmd | KeyCode.KEY_C:
++		case KeyMod.CtrlCmd | KeyCode.KEY_V:
++		case KeyMod.CtrlCmd | KeyCode.KEY_X:
++		case KeyMod.CtrlCmd | KeyCode.KEY_A:","this is bad
+",2016-07-06 13:51:08
+500,"@@ -45,7 +42,7 @@ script:
+   - gulp electron
+   - gulp compile
+   - gulp optimize-vscode
+-  - if [[ ""$TRAVIS_OS_NAME"" == ""linux"" ]]; then ./scripts/test.sh --coverage; else ./scripts/test.sh; fi
++  - if [[ ""$TRAVIS_OS_NAME"" == ""linux"" ]]; then ./scripts/test.sh --no-colors --reporter dot --coverage; else ./scripts/test.sh --no-colors --reporter dot; fi",Awesome. Why take out the colors though? Red is what I usually look for when looking at travis.,2016-11-21 15:06:04
+205,"@@ -45,7 +49,7 @@ export class TerminalInstance {
+ 		this.xterm.on('data', (data) => {
+ 			this.terminalProcess.process.send({
+ 				event: 'input',
+-				data: data
++				data: data && data.replace(TerminalInstance.eolRegex, os.EOL)","This should be split out above for clarity, it looks like it's passing in a boolean right now.
+",2016-07-08 00:37:09
+557,"@@ -458,10 +458,10 @@ export class Workbench implements IPartService {
+ 
+ 		// Backup File Service
+ 		const workspace = this.contextService.getWorkspace();
+-		serviceCollection.set(IBackupFileService, this.instantiationService.createInstance(BackupFileService, workspace ? workspace.resource : null));
++		serviceCollection.set(IBackupFileService, this.instantiationService.createInstance(BackupFileService, this.windowService.getCurrentWindowId()));",@Tyriar why not let backup file service depend on windows service to get the ID?,2016-12-02 06:40:03
+829,"@@ -46,18 +47,9 @@ export class ContextValuesContainer {
+ 		}
+ 		return ret;
+ 	}
+-
+-	public fillInContext(bucket: any): void {
+-		if (this._parent) {
+-			this._parent.fillInContext(bucket);
+-		}
+-		for (let key in this._value) {
+-			bucket[key] = this._value[key];
+-		}
+-	}","@joaomoreno I might be missing something but I don't find the place in which now child-context overwrites the values of it's parent. Like, a peek view editor which has `findWidgetVisible: false` and its parent editor/context having `findWidgetVisible: true`",2017-03-16 14:30:55
+371,"@@ -46,7 +45,7 @@ export class FileEditorInput extends CommonFileEditorInput {
+ 		@IHistoryService private historyService: IHistoryService,
+ 		@IEventService private eventService: IEventService,
+ 		@ITextFileService private textFileService: ITextFileService,
+-		@IBackupService private backupService: IBackupService
++		@IBackupFileService private backupFileService: IBackupFileService","Unused member
+",2016-10-21 13:51:08
+293,"@@ -462,6 +471,10 @@ export abstract class TitleControl implements ITitleAreaControl {
+ 			actions.push(new Separator(), this.pinEditorAction);
+ 		}
+ 
++		const titleBarMenu = this.menuService.createMenu(MenuId.EditorTab, this.contextKeyService);","Since you update the context key you don't need to create/dispose the menu as it will update when the context keys change. 
+",2016-10-04 10:50:56
+970,"@@ -462,7 +462,9 @@ export class ActivitybarPart extends Part implements IActivityBarService {
+ 			const index = this.pinnedViewlets.indexOf(viewletId);
+ 			this.pinnedViewlets.splice(index, 1);
+ 
+-			this.updateViewletSwitcher();
++			if (this.viewletSwitcherBar) {",@nicksnyder should we not just move this check into the `updateViewletSwitcher` method? There are many more places where we call it.,2017-06-13 04:33:27
+640,"@@ -466,11 +466,20 @@ export class SnippetController {
+ 		return SnippetController.ID;
+ 	}
+ 
++	public get inSnippetMode() {
++		return this._inSnippetMode.get();
++	}
++
+ 	public insertSnippet(template: string, overwriteBefore: number, overwriteAfter: number): void {
+ 		const snippet = CodeSnippet.fromTextmate(template, this._variableResolver);
+ 		this.run(snippet, overwriteBefore, overwriteAfter);
+ 	}
+ 
++	public insertSnippetWithReplaceRange(template: string, replaceRange: Range): void {",We should try to get away with just using `insertSnippet`. The controller is already complex ,2016-12-21 08:23:13
+884,"@@ -47,47 +47,267 @@ class TestWorkspace implements IWorkspace {
+ suite('Workbench - TerminalLinkHandler', () => {
+ 	suite('localLinkRegex', () => {
+ 		test('Windows', () => {
+-			const regex = new TestTerminalLinkHandler(new TestXterm(), Platform.Windows, null, null).localLinkRegex;
+-			function testLink(link: string) {
+-				assert.equal(` ${link} `.match(regex)[1], link);
+-				assert.equal(`:${link}:`.match(regex)[1], link);
+-				assert.equal(`;${link};`.match(regex)[1], link);
+-				assert.equal(`(${link})`.match(regex)[1], link);
++			const terminalLinkHandler = new TestTerminalLinkHandler(new TestXterm(), Platform.Windows, null, null, null);
++			function testLink(link: string, linkUrl: string, lineNo?: string, columnNo?: string) {
++				assert.equal(terminalLinkHandler.extractLinkUrl(link), linkUrl);
++				assert.equal(terminalLinkHandler.extractLinkUrl(`:${link}:`), linkUrl);
++				assert.equal(terminalLinkHandler.extractLinkUrl(`;${link};`), linkUrl);
++				assert.equal(terminalLinkHandler.extractLinkUrl(`(${link})`), linkUrl);
++
++				if (lineNo) {
++					const lineColumnInfo: LineColumnInfo = terminalLinkHandler.extractLineColumnInfo(link);
++					assert.equal(lineColumnInfo.lineNumber, lineNo);
++
++					if (columnNo) {
++						assert.equal(lineColumnInfo.columnNumber, columnNo);
++					}
++				}
+ 			}
+-			testLink('c:\\foo');
+-			testLink('c:/foo');
+-			testLink('.\\foo');
+-			testLink('./foo');
+-			testLink('..\\foo');
+-			testLink('../foo');
+-			testLink('~\\foo');
+-			testLink('~/foo');
+-			testLink('c:/a/long/path');
+-			testLink('c:\\a\\long\\path');
+-			testLink('c:\\mixed/slash\\path');
+-			testLink('a/relative/path');
++
++			testLink('c:\\foo', 'c:\\foo');
++			testLink('c:/foo', 'c:/foo');
++			testLink('.\\foo', '.\\foo');
++			testLink('./foo', './foo');
++			testLink('..\\foo', '..\\foo');
++			testLink('../foo', '../foo');
++			testLink('~\\foo', '~\\foo');
++			testLink('~/foo', '~/foo');
++			testLink('c:/a/long/path', 'c:/a/long/path');
++			testLink('c:\\a\\long\\path', 'c:\\a\\long\\path');
++			testLink('c:\\mixed/slash\\path', 'c:\\mixed/slash\\path');
++			testLink('a/relative/path', 'a/relative/path');
++
++			// With line and column number.
++			testLink('c:\\foo:5', 'c:\\foo', '5');
++			testLink('c:\\foo:5:3', 'c:\\foo', '5', '3');
++			testLink('c:\\foo:line 5', 'c:\\foo', '5');
++			testLink('c:\\foo:line 5, column 3', 'c:\\foo', '5', '3');
++			testLink('c:\\foo(5)', 'c:\\foo', '5');
++			testLink('c:\\foo(5,3)', 'c:\\foo', '5', '3');
++			testLink('c:\\foo (5)', 'c:\\foo', '5');
++			testLink('c:\\foo (5,3)', 'c:\\foo', '5', '3');
++			testLink('c:\\foo on line 5', 'c:\\foo', '5');
++			testLink('c:\\foo on line 5, column 3', 'c:\\foo', '5', '3');
++
++			testLink('c:/foo:5', 'c:/foo', '5');
++			testLink('c:/foo:5:3', 'c:/foo', '5', '3');
++			testLink('c:/foo:line 5', 'c:/foo', '5');
++			testLink('c:/foo:line 5, column 3', 'c:/foo', '5', '3');
++			testLink('c:/foo(5)', 'c:/foo', '5');",It would be good to have example programs that output each format (and only add them if we have an example).,2017-04-17 17:38:06
+958,"@@ -47,7 +47,7 @@ class ResourceModelCollection extends ReferenceCollection<TPromise<ITextEditorMo
+ 			} else {
+ 				model.dispose();
+ 			}
+-		});
++		}, () => void 0);",Not sure if we should log here or add some other handler. We do add catch callbacks  at higher levels that do error handling when the file does not exist. These still should be invoked after this change,2017-06-05 22:23:56
+386,"@@ -470,7 +492,11 @@ export class WorkbenchLayout implements IVerticalSashLayoutProvider, IHorizontal
+ 		}
+ 
+ 		// Activity Bar Part
+-		this.activitybar.getContainer().size(null, activityBarSize.height);
++		if (windowConfig && windowConfig.window.macOSUseInlineToolbar) {","Instead of duplicating the same code, the `activityBarSize` should be used in both cases. I know it was not used before but I do not think it would cause any harm.
+",2016-10-24 14:18:58
+146,"@@ -477,9 +477,7 @@ export class SuggestWidget implements IContentWidget, IDisposable {
+ 	}
+ 
+ 	private onModelModeChanged(): void {
+-		const model = this.editor.getModel();
+-		const supports = SuggestRegistry.all(model);
+-		this.shouldShowEmptySuggestionList = supports.some(s => true);
++		this.shouldShowEmptySuggestionList = true;","all of this should be nuked. since the value of `shouldShowEmptySuggestionList` is now always true it should disappear, also we don't need to listen of mode change events anymore
+",2016-05-03 09:12:27
+368,"@@ -479,6 +483,21 @@ export class QuickOpenController extends WorkbenchComponent implements IQuickOpe
+ 
+ 		this.previousValue = prefix;
+ 
++		// Track active editor before navigation","@wprater what about the picker? I think you need to extract this into a reusable method so that you can also use it when the picker opens.
+",2016-10-21 10:02:45
+367,"@@ -479,6 +483,21 @@ export class QuickOpenController extends WorkbenchComponent implements IQuickOpe
+ 
+ 		this.previousValue = prefix;
+ 
++		// Track active editor before navigation
++		this.previousActiveEditorInput = this.editorService.getActiveEditorInput();","@wprater suggest to just use `activeGroup.activeEditor` here
+",2016-10-21 10:01:58
+366,"@@ -479,6 +483,21 @@ export class QuickOpenController extends WorkbenchComponent implements IQuickOpe
+ 
+ 		this.previousValue = prefix;
+ 
++		// Track active editor before navigation
++		this.previousActiveEditorInput = this.editorService.getActiveEditorInput();
++
++		// Determine if there was a preview editor already open
++		this.previousPreviewEditorInput = null;
++		const activeGroup = this.editorGroupService.getStacksModel().activeGroup;
++		if (activeGroup) {
++			const visiblePreviewEditors = activeGroup.getEditors().filter((input: EditorInput) => {","@wprater why not just `activeGroup.previewEditor` ?
+",2016-10-21 10:01:24
+144,"@@ -479,7 +479,7 @@ export class SuggestWidget implements IContentWidget, IDisposable {
+ 	private onModelModeChanged(): void {
+ 		const model = this.editor.getModel();
+ 		const supports = SuggestRegistry.all(model);
+-		this.shouldShowEmptySuggestionList = supports.some(s => s.shouldShowEmptySuggestionList());
++		this.shouldShowEmptySuggestionList = supports.some(s => true);","just set it to `true`, not need for `some`
+",2016-05-02 10:13:38
+46,"@@ -48,33 +52,43 @@ interface ComputedStyles {
+ /**
+  * The workbench layout is responsible to lay out all parts that make the Monaco Workbench.
+  */
+-export class WorkbenchLayout implements IVerticalSashLayoutProvider {
++export class WorkbenchLayout implements IVerticalSashLayoutProvider, IHorizontalSashLayoutProvider {
+ 
+-	private static sashWidthSettingsKey = 'workbench.sidebar.width';
++	private static sashXWidthSettingsKey = 'workbench.sidebar.width';
++	private static sashYHeightSettingsKey = 'workbench.panelpart.height';","=> workbench.panel.height
+",2016-01-15 15:21:46
+47,"@@ -48,33 +52,43 @@ interface ComputedStyles {
+ /**
+  * The workbench layout is responsible to lay out all parts that make the Monaco Workbench.
+  */
+-export class WorkbenchLayout implements IVerticalSashLayoutProvider {
++export class WorkbenchLayout implements IVerticalSashLayoutProvider, IHorizontalSashLayoutProvider {
+ 
+-	private static sashWidthSettingsKey = 'workbench.sidebar.width';
++	private static sashXWidthSettingsKey = 'workbench.sidebar.width';
++	private static sashYHeightSettingsKey = 'workbench.panelpart.height';
+ 
+ 	private parent: Builder;
+ 	private workbenchContainer: Builder;
+ 	private activitybar: Part;
+ 	private editor: Part;
+ 	private sidebar: Part;
++	private panelPart: Part;
+ 	private statusbar: Part;
+ 	private quickopen: QuickOpenController;
+ 	private options: LayoutOptions;
+ 	private toUnbind: { (): void; }[];
+ 	private computedStyles: ComputedStyles;
+-	private editorHeight: number;
+ 	private workbenchSize: Dimension;
+-	private sash: Sash;
++	private sashX: Sash;
++	private sashY: Sash;
+ 	private startSidebarWidth: number;
+ 	private sidebarWidth: number;
++	private sidebarHeight: number;
++	private startPanelPartHeight: number;","@isidorn again easier to read the thing as ""panel"" unless you actually talk about the panelPart class. applies to multiple things in this file, not just here.
+",2016-01-15 15:24:59
+643,"@@ -48,6 +48,28 @@ export class TypeOperations {
+ 		);
+ 	}
+ 
++	public static shiftIndent(config: CursorConfiguration, indentation: string, count?: number): string {
++		count = count || 1;
++		let desiredIndentCount = ShiftCommand.shiftIndentCount(indentation, indentation.length + count, config.tabSize);
++		let newIndentation = '';",What about `let newIndentation = '\t'.repeat(desiredIntentCount);`?,2016-12-23 04:18:53
+831,"@@ -48,6 +48,7 @@ ptyProcess.on('data', function (data) {
+ });
+ 
+ ptyProcess.on('exit', function (exitCode) {
++	ptyProcess.kill();","Thanks @chirag64!
+
+Does everything seem to work fine? It's worth testing on Windows if you haven't. I was thinking we might need a timeout here before we kill `terminalProcess` or it could mess with the pty processes' shutdown.",2017-03-19 07:10:51
+8,"@@ -48,6 +48,7 @@ var globals = <IGlobalScope><any> (typeof self === 'object' ? self : global);
+ // IE: ""Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/5.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; MS-RTC LM 8; InfoPath.3; Zune 4.7)""
+ // Opera:	""Opera/9.80 (Windows NT 6.1; U; en) Presto/2.9.168 Version/11.52""
+ // FF: ""Mozilla/5.0 (Windows NT 6.1; WOW64; rv:8.0) Gecko/20100101 Firefox/8.0""
++// Edge: ""Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.246""
+ ","I don't think we need that comment at the moment
+",2015-11-21 19:09:25
+695,"@@ -48,6 +49,33 @@ export class ClearOutputAction extends Action {
+ 	}
+ }
+ 
++export class ToggleOutputScrollLockAction extends Action {
++
++	public static ID = 'workbench.output.action.toggleOutputScrollLock';
++	public static LABEL = nls.localize('toggleOutputScrollLock', ""Toggle Output Scroll Lock"");
++
++	private toDispose: IDisposable[] = [];
++
++	constructor(id: string, label: string,
++		@IOutputService private outputService: IOutputService) {
++		super(id, label, 'output-action toggle-output-scroll-lock');
++		this.toDispose.push(this.outputService.onActiveOutputChannel(channel => this._setChecked(this.outputService.getActiveChannel().hasScrollLock)));
++	}
++
++	public run(): TPromise<any> {
++		const activeChannel = this.outputService.getActiveChannel();","What if there is no active output channel (output hidden) and this command is triggered from the command pallete?
+You either need a null check here or even better do not register this action as a global workbench action as I do not see people assigning shortcuts to this action or triggering it via command pallete.",2017-01-19 10:05:00
+492,"@@ -485,6 +510,9 @@ export class WindowsManager implements IWindowsMainService {
+ 			}
+ 		}
+ 
++		// Register new paths for backup
++		this.backupService.pushWorkspaceBackupPathsSync(iPathsToOpen.filter(p => p.workspacePath).map(p => Uri.file(p.workspacePath)));","@Tyriar should this only happen if hot exit is enabled in settings?
+",2016-11-15 06:00:44
+868,"@@ -488,6 +488,7 @@ export class TreeView extends HeightMap {
+ 		this.viewListeners.push(DOM.addDisposableListener(this.domNode, 'mousedown', (e) => this.onMouseDown(e)));
+ 		this.viewListeners.push(DOM.addDisposableListener(this.domNode, 'mouseup', (e) => this.onMouseUp(e)));
+ 		this.viewListeners.push(DOM.addDisposableListener(this.wrapper, 'click', (e) => this.onClick(e)));
++		this.viewListeners.push(DOM.addDisposableListener(this.wrapper, 'auxclick', (e) => this.onClick(e))); // >= Chrome 56","If AUXCLICK is getting disabled, why add an event listener for the event type?",2017-04-02 22:17:47
+87,"@@ -49,14 +72,41 @@ export class MacTerminalService implements ITerminalService {
+ 			child.on('exit', (code: number) => {
+ 				c(code === 0 ? 'iterm.scpt' : 'terminal.scpt');
+ 			});
+-		}).then(name => uri.parse(require.toUrl(`vs/workbench/parts/execution/electron-browser/${ name }`)).fsPath);
++		}).then(name => uri.parse(require.toUrl(`vs/workbench/parts/execution/electron-browser/${name}`)).fsPath);
+ 	}
+ }
+ 
+ export class LinuxTerminalService implements ITerminalService {
+ 	public serviceId = ITerminalService;
+ 
++	constructor(
++		@IConfigurationService private _configurationService: IConfigurationService
++	) { }
++
++
+ 	public openTerminal(path: string): void {
+-		cp.spawn('x-terminal-emulator', [], { cwd: path });
++		this._configurationService.loadConfiguration().done(configuration => {
++			return new Promise((success, failed) => {
++				this.spawnTerminal(
++					cp,
++					configuration,
++					path,
++					success,
++					err => {
++						errors.onUnexpectedError(err);
++						failed(err);
++					}
++				);
++			});
++		}, errors.onUnexpectedError);
+ 	}
++
++	private spawnTerminal(spawner, configuration, path: string, onExit, onError) {
++		let terminalConfig = configuration.terminal;
++		let exec = terminalConfig.linux.exec || defaultLinuxTerm;
++		const child = spawner.spawn(exec, [], { cwd: path });","Does just setting the `cwd` work with `gnome-terminal`? You may need to pass in `--working-directory=path` for that?
+",2016-03-24 01:40:03
+956,"@@ -49,7 +51,11 @@ export class MergeConflictParser {
+ 				}
+ 
+ 				// Create a new conflict starting at this line
+-				currentConflict = { startHeader: line };
++				currentConflict = { startHeader: line, commonAncestors: null };
++			}
++			// Are we within a conflict block and is this a common ancestors marker? |||||||
++			else if (currentConflict && line.text.startsWith(commonAncestorsMarker)) {
++				currentConflict.commonAncestors = line;","If, for some reason, we ended up with:
+
+```
+<<<<<<< HEAD
+Foo
+||||||| common
+foo
+||||||| common
+fooo
+=======
+blah
+>>>>>>> incoming
+```
+
+We will end up extending the ""current"" content over the first merge ancestor block. If we encounter two blocks of `|||||||` I think there are two thing we could do: 
+
+ - Favorable: Don't overwrite `currentConflict.commonAncestors`, just leave it with the first occurrence, this way the current content block will span the correct range. (e.g. `else if (currentConflict && !currentConflict.commonAncestors && line.text.startsWith(commonAncestorsMarker))`
+ - Break out of scanning (like we do if we encounter a start marker before an end marker), so we don't provide any decoration if we are unsure what to do. 
+
+FWIW I think this is also true of existing `=======` scanning...",2017-05-30 16:09:15
+839,"@@ -490,6 +490,18 @@ export class Thread implements IThread {
+ 		});
+ 	}
+ 
++	/**
++	 * Returns exception info promise if the exception was thrown and the debug adapter supports 'exceptionInfo' request, otherwise null
++	 */
++	public get exceptionInfo(): TPromise<DebugProtocol.ExceptionInfoResponse> {
++		const session = this.process.session;","I would love if the exception widget always calls this method.
+And all the logic is in this method, meaning that if we are not stopped we return null, if the session does not supportExceptionInfoRequest we also return something",2017-03-21 17:07:29
+844,"@@ -490,6 +490,18 @@ export class Thread implements IThread {
+ 		});
+ 	}
+ 
++	/**
++	 * Returns exception info promise if the exception was thrown and the debug adapter supports 'exceptionInfo' request, otherwise null
++	 */
++	public get exceptionInfo(): TPromise<DebugProtocol.ExceptionInfoResponse> {
++		const session = this.process.session;
++		if (session.capabilities.supportsExceptionInfoRequest && this.stoppedDetails && this.stoppedDetails.reason === 'exception') {","I do not like this check for this.stoppedDetails and this.stoppedDetails.reason === 'exception' since now we do it two times. Once before calling this method and once in the method.
+
+We should do it in only one of those places - whichever feels better to you.
+You just have to figure out what is the contract of this method and when should it be calle",2017-03-22 10:55:40
+833,"@@ -490,6 +490,18 @@ export class Thread implements IThread {
+ 		});
+ 	}
+ 
++	/**
++	 * Returns exception info promise if the exception was thrown and the debug adapter supports 'exceptionInfo' request, otherwise null
++	 */
++	public get exceptionInfo(): TPromise<DebugProtocol.ExceptionInfoResponse> {
++		const session = this.process.session;
++		if (session.capabilities.supportsExceptionInfoRequest && this.stoppedDetails && this.stoppedDetails.reason === 'exception') {
++			return session.exceptionInfo({ threadId: this.threadId });
++		}
++
++		return null;","You can not just return `null` when a promise is expected, you should
+`return TPromise.as(null)`",2017-03-21 17:00:23
+44,"@@ -499,6 +533,42 @@ export class Workbench implements IPartService {
+ 		this.storageService.store(Workbench.sidebarHiddenSettingKey, hidden ? 'true' : 'false', StorageScope.WORKSPACE);
+ 	}
+ 
++	public isPanelPartHidden(): boolean {","@isidorn => isPanelHidden
+",2016-01-15 15:19:03
+45,"@@ -499,6 +533,42 @@ export class Workbench implements IPartService {
+ 		this.storageService.store(Workbench.sidebarHiddenSettingKey, hidden ? 'true' : 'false', StorageScope.WORKSPACE);
+ 	}
+ 
++	public isPanelPartHidden(): boolean {
++		return this.panelPartHidden;
++	}
++
++	public setPanelPartHidden(hidden: boolean, skipLayout?:boolean): void {","@isidorn => setPanelHidden
+",2016-01-15 15:19:17
+115,"@@ -5,14 +5,14 @@
+ import fs = require('fs');
+ import env = require('vs/base/common/platform');
+ 
+-export let defaultLinuxTerm = 'x-terminal-emulator';
++export let DEFAULT_LINUX_TERM = 'x-terminal-emulator';
+ 
+ // if we're not on debian and using gnome then
+ // set default to gnome-terminal
+ if (env.isLinux
+ 	&& fs.existsSync('/etc/debian_version') === false
+ 	&& process.env.DESKTOP_SESSION === 'gnome') {
+-	defaultLinuxTerm = 'gnome-terminal';
++	DEFAULT_LINUX_TERM = 'gnome-terminal';
+ }
+ 
+-export const defaultWindowsTerm = 'cmd';
+\ No newline at end of file
++export const DEFAILT_WINDOWS_TERM = 'cmd';","Typo DEFAULT
+",2016-04-18 18:50:35
+692,"@@ -5,15 +5,17 @@
+ 'use strict';
+ 
+ import { localize } from 'vs/nls';
+-import { WalkThroughInput } from 'vs/workbench/parts/walkThrough/common/walkThroughInput';
++import { WalkThroughInput } from 'vs/workbench/parts/walkThrough/node/walkThroughInput';
+ import { WalkThroughPart } from 'vs/workbench/parts/walkThrough/electron-browser/walkThroughPart';
++import { WalkThroughContentProvider, WalkThroughSnippetContentProvider } from 'vs/workbench/parts/walkThrough/node/walkThroughContentProvider';
+ import { EditorWalkThroughAction } from 'vs/workbench/parts/walkThrough/electron-browser/editor/editorWalkThrough';
+ import { Registry } from 'vs/platform/platform';
+ import { EditorDescriptor } from 'vs/workbench/browser/parts/editor/baseEditor';
+ import { IEditorRegistry, Extensions as EditorExtensions } from 'vs/workbench/common/editor';
+ import { SyncDescriptor } from 'vs/platform/instantiation/common/descriptors';
+ import { IWorkbenchActionRegistry, Extensions } from 'vs/workbench/common/actionRegistry';
+ import { SyncActionDescriptor } from 'vs/platform/actions/common/actions';
++import { IWorkbenchContributionsRegistry, Extensions as WorkbenchExtensions } from 'vs/workbench/common/contributions';
+ 
+ (<IEditorRegistry>Registry.as(EditorExtensions.Editors)).registerEditor(new EditorDescriptor(WalkThroughPart.ID,",`Registry.as<IEditorRegistry>(EditorExtensions.Editors)`,2017-01-19 06:01:05
+690,"@@ -5,16 +5,114 @@
+ 
+ 'use strict';
+ 
+-let pageHeight = 0;
+-
+-window.onload = () => {
+-	pageHeight = document.body.getBoundingClientRect().height;
+-};
+-
+-window.addEventListener('resize', () => {
+-	const currentOffset = window.scrollY;
+-	const newPageHeight = document.body.getBoundingClientRect().height;
+-	const dHeight = newPageHeight / pageHeight;
+-	window.scrollTo(0, currentOffset * dHeight);
+-	pageHeight = newPageHeight;
+-}, true);
++(function () {
++	var pageHeight = 0;
++
++	/**
++	 * Find the elements around line.
++	 *
++	 * If an exact match, returns a single element. If the line is between elements,
++	 * returns the element before and the element after the given line.
++	 */
++	function getElementsAroundSourceLine(targetLine) {
++		const lines = document.getElementsByClassName('code-line');
++		let before = null;
++		for (const element of lines) {
++			const lineNumber = +element.getAttribute('data-line');
++			if (isNaN(lineNumber)) {
++				continue;
++			}
++			const entry = { line: lineNumber, element: element };
++			if (lineNumber === targetLine) {
++				return { before: entry, after: null };
++			} else if (lineNumber > targetLine) {
++				return { before, after: entry };
++			}
++			before = entry;
++		}
++		return { before };
++	}
++
++	function getSourceRevealAddedOffset() {
++		return -(window.innerHeight * 1 / 5);
++	}
++
++	/**
++	 * Attempt to reveal the element for a source line in the editor.
++	 */
++	function scrollToRevealSourceLine(line) {
++		const {before, after} = getElementsAroundSourceLine(line);
++		if (before) {
++			let scrollTo = 0;
++			if (after) {
++				// Between two elements. Go to percentage offset between them.
++				const betweenProgress = (line - before.line) / (after.line - before.line);
++				const elementOffset = after.element.getBoundingClientRect().top - before.element.getBoundingClientRect().top;
++				scrollTo = before.element.getBoundingClientRect().top + betweenProgress * elementOffset;
++			} else {
++				scrollTo = before.element.getBoundingClientRect().top;
++			}
++			window.scroll(0, window.scrollY + scrollTo + getSourceRevealAddedOffset());
++		}
++	}
++
++	function didUpdateScrollPosition(offset) {
++		const lines = document.getElementsByClassName('code-line');
++		let nearest = lines[0];
++		for (let i = lines.length - 1; i >= 0; --i) {
++			const lineElement = lines[i];
++			if (offset <= window.scrollY + lineElement.getBoundingClientRect().top + lineElement.getBoundingClientRect().height) {
++				nearest = lineElement;
++			} else {
++				break;
++			}
++		}
++
++		if (nearest) {
++			const line = +nearest.getAttribute('data-line');
++			const args = [window.initialData.source, line];
++			window.parent.postMessage({
++				command: ""did-click-link"",","This functionality is something we would probably want to standardize, similar to the `postMessage` command. Emulating clicks is pretty iffy.",2017-01-19 00:49:02
+488,"@@ -5,19 +5,18 @@
+ 
+ 'use strict';
+ 
+-import Uri from 'vs/base/common/uri';
+ import { EventEmitter } from 'events';
+ import { ipcMain as ipc, app } from 'electron';
+ import { TPromise, TValueCallback } from 'vs/base/common/winjs.base';
+ import { ReadyState, VSCodeWindow } from 'vs/code/electron-main/window';
+ import { IEnvironmentService } from 'vs/platform/environment/common/environment';
+ import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
+-import { IBackupMainService } from 'vs/platform/backup/common/backup';
+ import { ILogService } from 'vs/code/electron-main/log';
+ import { IStorageService } from 'vs/code/electron-main/storage';
+ 
+ const EventTypes = {
+-	BEFORE_QUIT: 'before-quit'
++	BEFORE_QUIT: 'before-quit',
++	AFTER_UNLOAD: 'after-unload'","@Tyriar should this maybe be `BEFORE_CLOSE`? because the next thing that is going to happen after this event is the window closing.
+",2016-11-15 05:40:10
+544,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());",Add error handler to returned promises?,2016-11-30 19:50:40
+541,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());
++	}
+ 
+-		let progress = () => {
+-			this.progressed++;
+-			if (this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
+-				onProgress({ total: this.total, worked: this.worked }); // buffer progress in chunks to reduce pressure
++	search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
++		this.startWorkers();
++		const progress = () => {
++			if (++this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
++				onProgress({ total: this.totalBytes, worked: this.processedBytes }); // buffer progress in chunks to reduce pressure
+ 			}
+ 		};
+ 
+-		let unwind = (processed: number) => {
+-			this.worked += processed;
++		const unwind = (processed: number) => {
++			this.processedBytes += processed;
+ 
+ 			// Emit progress() unless we got canceled or hit the limit
+ 			if (processed && !this.isDone && !this.isCanceled && !this.limitReached) {
+ 				progress();
+ 			}
+ 
+ 			// Emit done()
+-			if (this.worked === this.total && this.walkerIsDone && !this.isDone) {
++			if (!this.isDone && this.processedBytes === this.totalBytes && this.walkerIsDone) {","I wonder if `this.processedBytes === this.totalBytes` is a good condition to rely on. If a file changes its size between the file traversal and the text search it would never hold, would it?",2016-11-30 19:31:30
+545,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());
++	}
+ 
+-		let progress = () => {
+-			this.progressed++;
+-			if (this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
+-				onProgress({ total: this.total, worked: this.worked }); // buffer progress in chunks to reduce pressure
++	search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
++		this.startWorkers();
++		const progress = () => {
++			if (++this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
++				onProgress({ total: this.totalBytes, worked: this.processedBytes }); // buffer progress in chunks to reduce pressure
+ 			}
+ 		};
+ 
+-		let unwind = (processed: number) => {
+-			this.worked += processed;
++		const unwind = (processed: number) => {
++			this.processedBytes += processed;
+ 
+ 			// Emit progress() unless we got canceled or hit the limit
+ 			if (processed && !this.isDone && !this.isCanceled && !this.limitReached) {
+ 				progress();
+ 			}
+ 
+ 			// Emit done()
+-			if (this.worked === this.total && this.walkerIsDone && !this.isDone) {
++			if (!this.isDone && this.processedBytes === this.totalBytes && this.walkerIsDone) {
+ 				this.isDone = true;
++				this.disposeWorkers();",Why is this different from cancel() above? Should the walker also be canceled/disposed?,2016-11-30 19:52:08
+546,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());
++	}
+ 
+-		let progress = () => {
+-			this.progressed++;
+-			if (this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
+-				onProgress({ total: this.total, worked: this.worked }); // buffer progress in chunks to reduce pressure
++	search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
++		this.startWorkers();
++		const progress = () => {
++			if (++this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
++				onProgress({ total: this.totalBytes, worked: this.processedBytes }); // buffer progress in chunks to reduce pressure
+ 			}
+ 		};
+ 
+-		let unwind = (processed: number) => {
+-			this.worked += processed;
++		const unwind = (processed: number) => {
++			this.processedBytes += processed;
+ 
+ 			// Emit progress() unless we got canceled or hit the limit
+ 			if (processed && !this.isDone && !this.isCanceled && !this.limitReached) {
+ 				progress();
+ 			}
+ 
+ 			// Emit done()
+-			if (this.worked === this.total && this.walkerIsDone && !this.isDone) {
++			if (!this.isDone && this.processedBytes === this.totalBytes && this.walkerIsDone) {
+ 				this.isDone = true;
++				this.disposeWorkers();
+ 				done(this.walkerError, {
+ 					limitHit: this.limitReached,
+ 					stats: this.walker.getStats()
+ 				});
+ 			}
+ 		};
+ 
+-		// Walk over the file system
+-		this.walker.walk(this.rootFolders, this.extraFiles, result => {
+-			const size = result.size || 1;
+-			this.total += size;
+-
+-			// If the result is empty or we have reached the limit or we are canceled, ignore it
+-			if (this.limitReached || this.isCanceled) {
+-				return unwind(size);
+-			}
++		const run = (batch: string[], batchBytes: number): void => {
++			const worker = this.workers[this.nextWorker];
++			this.nextWorker = (this.nextWorker + 1) % this.workers.length;
+ 
+-			// Indicate progress to the outside
+-			progress();
+-
+-			let fileMatch: FileMatch = null;
+-
+-			let doneCallback = (error?: Error) => {
+-				if (!error && !this.isCanceled && fileMatch && !fileMatch.isEmpty()) {
+-					onResult(fileMatch.serialize());
+-				}
+-
+-				return unwind(size);
+-			};
+-
+-			const absolutePath = result.base ? [result.base, result.relativePath].join(path.sep) : result.relativePath;
+-			let perLineCallback = (line: string, lineNumber: number) => {
+-				if (this.limitReached || this.isCanceled) {
+-					return; // return early if canceled or limit reached
++			const maxResults = this.config.maxResults - this.numResults;
++			worker.search({ absolutePaths: batch, maxResults }).then(result => {",Add error handler to arguments of .then()?,2016-11-30 19:54:09
+542,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());
++	}
+ 
+-		let progress = () => {
+-			this.progressed++;
+-			if (this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
+-				onProgress({ total: this.total, worked: this.worked }); // buffer progress in chunks to reduce pressure
++	search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
++		this.startWorkers();
++		const progress = () => {
++			if (++this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
++				onProgress({ total: this.totalBytes, worked: this.processedBytes }); // buffer progress in chunks to reduce pressure
+ 			}
+ 		};
+ 
+-		let unwind = (processed: number) => {
+-			this.worked += processed;
++		const unwind = (processed: number) => {
++			this.processedBytes += processed;
+ 
+ 			// Emit progress() unless we got canceled or hit the limit
+ 			if (processed && !this.isDone && !this.isCanceled && !this.limitReached) {
+ 				progress();
+ 			}
+ 
+ 			// Emit done()
+-			if (this.worked === this.total && this.walkerIsDone && !this.isDone) {
++			if (!this.isDone && this.processedBytes === this.totalBytes && this.walkerIsDone) {
+ 				this.isDone = true;
++				this.disposeWorkers();
+ 				done(this.walkerError, {
+ 					limitHit: this.limitReached,
+ 					stats: this.walker.getStats()
+ 				});
+ 			}
+ 		};
+ 
+-		// Walk over the file system
+-		this.walker.walk(this.rootFolders, this.extraFiles, result => {
+-			const size = result.size || 1;
+-			this.total += size;
+-
+-			// If the result is empty or we have reached the limit or we are canceled, ignore it
+-			if (this.limitReached || this.isCanceled) {
+-				return unwind(size);
+-			}
++		const run = (batch: string[], batchBytes: number): void => {
++			const worker = this.workers[this.nextWorker];
++			this.nextWorker = (this.nextWorker + 1) % this.workers.length;
+ 
+-			// Indicate progress to the outside
+-			progress();
+-
+-			let fileMatch: FileMatch = null;
+-
+-			let doneCallback = (error?: Error) => {
+-				if (!error && !this.isCanceled && fileMatch && !fileMatch.isEmpty()) {
+-					onResult(fileMatch.serialize());
+-				}
+-
+-				return unwind(size);
+-			};
+-
+-			const absolutePath = result.base ? [result.base, result.relativePath].join(path.sep) : result.relativePath;
+-			let perLineCallback = (line: string, lineNumber: number) => {
+-				if (this.limitReached || this.isCanceled) {
+-					return; // return early if canceled or limit reached
++			const maxResults = this.config.maxResults - this.numResults;
++			worker.search({ absolutePaths: batch, maxResults }).then(result => {
++				if (!result || this.limitReached || this.isCanceled) {
++					return unwind(batchBytes);
+ 				}
+ 
+-				let lineMatch: LineMatch = null;
+-				let match = this.contentPattern.exec(line);
+-
+-				// Record all matches into file result
+-				while (match !== null && match[0].length > 0 && !this.limitReached && !this.isCanceled) {
+-					resultCounter++;
+-					if (this.maxResults && resultCounter >= this.maxResults) {
+-						this.limitReached = true;
+-					}
+-
+-					if (fileMatch === null) {
+-						fileMatch = new FileMatch(absolutePath);
+-					}
+-
+-					if (lineMatch === null) {
+-						lineMatch = new LineMatch(line, lineNumber);
+-						fileMatch.addMatch(lineMatch);
+-					}
+-
+-					lineMatch.addMatch(match.index, match[0].length);
++				const matches = result.matches;
++				this.numResults += result.numMatches;
++				matches.forEach(m => {
++					onResult(m);
++				});
+ 
+-					match = this.contentPattern.exec(line);
++				if (this.numResults >= this.config.maxResults) {
++					// It's possible to go over maxResults like this, but it's much simpler than trying to extract the exact number
++					// of file matches, line matches, and matches within a line to == maxResults.
++					this.limitReached = true;
+ 				}
+-			};
+ 
+-			// Read lines buffered to support large files
+-			this.readlinesAsync(absolutePath, perLineCallback, { bufferLength: 8096, encoding: this.fileEncoding }, doneCallback);
+-		}, (error, isLimitHit) => {
+-			this.walkerIsDone = true;
+-			this.walkerError = error;
+-			unwind(0 /* walker is done, indicate this back to our handler to be able to unwind */);
+-		});
+-	}
++				unwind(batchBytes);
++			});
++		};
+ 
+-	private readlinesAsync(filename: string, perLineCallback: (line: string, lineNumber: number) => void, options: ReadLinesOptions, callback: (error: Error) => void): void {
+-		fs.open(filename, 'r', null, (error: Error, fd: number) => {
+-			if (error) {
+-				return callback(error);
++		// Walk over the file system
++		let nextBatch = [];
++		let nextBatchBytes = 0;
++		const batchFlushBytes = 2 ** 20; // 1MB
++		this.walker.walk(this.config.rootFolders, this.config.extraFiles, result => {
++			let bytes = result.size || 1;",Any idea why we || 1? Would an empty file make the condition `this.processedBytes === this.totalBytes` further up never hold?,2016-11-30 19:34:35
+543,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());
++	}
+ 
+-		let progress = () => {
+-			this.progressed++;
+-			if (this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
+-				onProgress({ total: this.total, worked: this.worked }); // buffer progress in chunks to reduce pressure
++	search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
++		this.startWorkers();
++		const progress = () => {
++			if (++this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
++				onProgress({ total: this.totalBytes, worked: this.processedBytes }); // buffer progress in chunks to reduce pressure
+ 			}
+ 		};
+ 
+-		let unwind = (processed: number) => {
+-			this.worked += processed;
++		const unwind = (processed: number) => {
++			this.processedBytes += processed;
+ 
+ 			// Emit progress() unless we got canceled or hit the limit
+ 			if (processed && !this.isDone && !this.isCanceled && !this.limitReached) {
+ 				progress();
+ 			}
+ 
+ 			// Emit done()
+-			if (this.worked === this.total && this.walkerIsDone && !this.isDone) {
++			if (!this.isDone && this.processedBytes === this.totalBytes && this.walkerIsDone) {
+ 				this.isDone = true;
++				this.disposeWorkers();
+ 				done(this.walkerError, {
+ 					limitHit: this.limitReached,
+ 					stats: this.walker.getStats()
+ 				});
+ 			}
+ 		};
+ 
+-		// Walk over the file system
+-		this.walker.walk(this.rootFolders, this.extraFiles, result => {
+-			const size = result.size || 1;
+-			this.total += size;
+-
+-			// If the result is empty or we have reached the limit or we are canceled, ignore it
+-			if (this.limitReached || this.isCanceled) {
+-				return unwind(size);
+-			}
++		const run = (batch: string[], batchBytes: number): void => {
++			const worker = this.workers[this.nextWorker];
++			this.nextWorker = (this.nextWorker + 1) % this.workers.length;
+ 
+-			// Indicate progress to the outside
+-			progress();
+-
+-			let fileMatch: FileMatch = null;
+-
+-			let doneCallback = (error?: Error) => {
+-				if (!error && !this.isCanceled && fileMatch && !fileMatch.isEmpty()) {
+-					onResult(fileMatch.serialize());
+-				}
+-
+-				return unwind(size);
+-			};
+-
+-			const absolutePath = result.base ? [result.base, result.relativePath].join(path.sep) : result.relativePath;
+-			let perLineCallback = (line: string, lineNumber: number) => {
+-				if (this.limitReached || this.isCanceled) {
+-					return; // return early if canceled or limit reached
++			const maxResults = this.config.maxResults - this.numResults;
++			worker.search({ absolutePaths: batch, maxResults }).then(result => {
++				if (!result || this.limitReached || this.isCanceled) {
++					return unwind(batchBytes);
+ 				}
+ 
+-				let lineMatch: LineMatch = null;
+-				let match = this.contentPattern.exec(line);
+-
+-				// Record all matches into file result
+-				while (match !== null && match[0].length > 0 && !this.limitReached && !this.isCanceled) {
+-					resultCounter++;
+-					if (this.maxResults && resultCounter >= this.maxResults) {
+-						this.limitReached = true;
+-					}
+-
+-					if (fileMatch === null) {
+-						fileMatch = new FileMatch(absolutePath);
+-					}
+-
+-					if (lineMatch === null) {
+-						lineMatch = new LineMatch(line, lineNumber);
+-						fileMatch.addMatch(lineMatch);
+-					}
+-
+-					lineMatch.addMatch(match.index, match[0].length);
++				const matches = result.matches;
++				this.numResults += result.numMatches;
++				matches.forEach(m => {
++					onResult(m);
++				});
+ 
+-					match = this.contentPattern.exec(line);
++				if (this.numResults >= this.config.maxResults) {
++					// It's possible to go over maxResults like this, but it's much simpler than trying to extract the exact number
++					// of file matches, line matches, and matches within a line to == maxResults.
++					this.limitReached = true;
+ 				}
+-			};
+ 
+-			// Read lines buffered to support large files
+-			this.readlinesAsync(absolutePath, perLineCallback, { bufferLength: 8096, encoding: this.fileEncoding }, doneCallback);
+-		}, (error, isLimitHit) => {
+-			this.walkerIsDone = true;
+-			this.walkerError = error;
+-			unwind(0 /* walker is done, indicate this back to our handler to be able to unwind */);
+-		});
+-	}
++				unwind(batchBytes);
++			});
++		};
+ 
+-	private readlinesAsync(filename: string, perLineCallback: (line: string, lineNumber: number) => void, options: ReadLinesOptions, callback: (error: Error) => void): void {
+-		fs.open(filename, 'r', null, (error: Error, fd: number) => {
+-			if (error) {
+-				return callback(error);
++		// Walk over the file system
++		let nextBatch = [];
++		let nextBatchBytes = 0;
++		const batchFlushBytes = 2 ** 20; // 1MB
++		this.walker.walk(this.config.rootFolders, this.config.extraFiles, result => {
++			let bytes = result.size || 1;
++			this.totalBytes += bytes;
++
++			// If we have reached the limit or we are canceled, ignore it
++			if (this.limitReached || this.isCanceled) {
++				return unwind(bytes);
+ 			}
+ 
+-			let buffer = new Buffer(options.bufferLength);
+-			let pos: number;
+-			let i: number;
+-			let line = '';
+-			let lineNumber = 0;
+-			let lastBufferHadTraillingCR = false;
+-
+-			const outer = this;
+-
+-			function decodeBuffer(buffer: NodeBuffer, start: number, end: number): string {
+-				if (options.encoding === UTF8 || options.encoding === UTF8_with_bom) {
+-					return buffer.toString(undefined, start, end); // much faster to use built in toString() when encoding is default
+-				}
++			// Indicate progress to the outside
++			progress();
+ 
+-				return decode(buffer.slice(start, end), options.encoding);
+-			}
++			const absolutePath = result.base ? [result.base, result.relativePath].join(path.sep) : result.relativePath;
++			nextBatch.push(absolutePath);
++			nextBatchBytes += bytes;
+ 
+-			function lineFinished(offset: number): void {
+-				line += decodeBuffer(buffer, pos, i + offset);
+-				perLineCallback(line, lineNumber);
+-				line = '';
+-				lineNumber++;
+-				pos = i + offset;
++			if (nextBatchBytes >= batchFlushBytes) {
++				run(nextBatch, nextBatchBytes);
++				nextBatch = [];
++				nextBatchBytes = 0;
+ 			}
+-
+-			function readFile(isFirstRead: boolean, clb: (error: Error) => void): void {
+-				if (outer.limitReached || outer.isCanceled) {
+-					return clb(null); // return early if canceled or limit reached
++		}, (error, isLimitHit) => {
++			// Send any remaining paths to a worker, or unwind if we're stopping
++			if (nextBatch.length) {
++				if (this.limitReached || this.isCanceled) {
++					unwind(nextBatchBytes);
++				} else {
++					run(nextBatch, nextBatchBytes);
+ 				}
+-
+-				fs.read(fd, buffer, 0, buffer.length, null, (error: Error, bytesRead: number, buffer: NodeBuffer) => {
+-					if (error || bytesRead === 0 || outer.limitReached || outer.isCanceled) {
+-						return clb(error); // return early if canceled or limit reached or no more bytes to read
+-					}
+-
+-					pos = 0;
+-					i = 0;
+-
+-					// Detect encoding and mime when this is the beginning of the file
+-					if (isFirstRead) {
+-						let mimeAndEncoding = detectMimeAndEncodingFromBuffer(buffer, bytesRead);
+-						if (mimeAndEncoding.mimes[mimeAndEncoding.mimes.length - 1] !== baseMime.MIME_TEXT) {
+-							return clb(null); // skip files that seem binary
+-						}
+-
+-						// Check for BOM offset
+-						switch (mimeAndEncoding.encoding) {
+-							case UTF8:
+-								pos = i = 3;
+-								options.encoding = UTF8;
+-								break;
+-							case UTF16be:
+-								pos = i = 2;
+-								options.encoding = UTF16be;
+-								break;
+-							case UTF16le:
+-								pos = i = 2;
+-								options.encoding = UTF16le;
+-								break;
+-						}
+-					}
+-
+-					if (lastBufferHadTraillingCR) {
+-						if (buffer[i] === 0x0a) { // LF (Line Feed)
+-							lineFinished(1);
+-							i++;
+-						} else {
+-							lineFinished(0);
+-						}
+-
+-						lastBufferHadTraillingCR = false;
+-					}
+-
+-					for (; i < bytesRead; ++i) {
+-						if (buffer[i] === 0x0a) { // LF (Line Feed)
+-							lineFinished(1);
+-						} else if (buffer[i] === 0x0d) { // CR (Carriage Return)
+-							if (i + 1 === bytesRead) {
+-								lastBufferHadTraillingCR = true;
+-							} else if (buffer[i + 1] === 0x0a) { // LF (Line Feed)
+-								lineFinished(2);
+-								i++;
+-							} else {
+-								lineFinished(1);
+-							}
+-						}
+-					}
+-
+-					line += decodeBuffer(buffer, pos, bytesRead);
+-
+-					readFile(false /* isFirstRead */, clb); // Continue reading
+-				});
+ 			}
+ 
+-			readFile(true /* isFirstRead */, (error: Error) => {
+-				if (error) {
+-					return callback(error);
+-				}
+-
+-				if (line.length) {
+-					perLineCallback(line, lineNumber); // handle last line
+-				}
+-
+-				fs.close(fd, (error: Error) => {
+-					callback(error);
+-				});
+-			});
++			this.walkerIsDone = true;
++			this.walkerError = error;
+ 		});
+ 	}
+-}
+-
+-class FileMatch implements ISerializedFileMatch {
+-	public path: string;
+-	public lineMatches: LineMatch[];
+-
+-	constructor(path: string) {
+-		this.path = path;
+-		this.lineMatches = [];
+-	}
+ 
+-	public addMatch(lineMatch: LineMatch): void {
+-		this.lineMatches.push(lineMatch);
+-	}
+-
+-	public isEmpty(): boolean {
+-		return this.lineMatches.length === 0;
+-	}
+-
+-	public serialize(): ISerializedFileMatch {
+-		let lineMatches: ILineMatch[] = [];
+-
+-		for (let i = 0; i < this.lineMatches.length; i++) {
+-			lineMatches.push(this.lineMatches[i].serialize());
++	private startWorkers(): void {
++		// If the CPU has hyperthreading enabled, this will report (# of physical cores)*2.
++		const numWorkers = os.cpus().length;
++		for (let i = 0; i < numWorkers; i++) {
++			this.createWorker(i);
+ 		}
+-
+-		return {
+-			path: this.path,
+-			lineMatches: lineMatches
+-		};
+-	}
+-}
+-
+-class LineMatch implements ILineMatch {
+-	public preview: string;
+-	public lineNumber: number;
+-	public offsetAndLengths: number[][];
+-
+-	constructor(preview: string, lineNumber: number) {
+-		this.preview = preview.replace(/(\r|\n)*$/, '');
+-		this.lineNumber = lineNumber;
+-		this.offsetAndLengths = [];
+ 	}
+ 
+-	public getText(): string {
+-		return this.preview;
+-	}
++	private createWorker(id: number): void {
++		let client = new Client(
++			uri.parse(require.toUrl('bootstrap')).fsPath,
++			{
++				serverName: 'Search Worker ' + id,
++				args: ['--type=searchWorker'],
++				env: {
++					AMD_ENTRYPOINT: 'vs/workbench/services/search/node/worker/searchWorkerApp',
++					PIPE_LOGGING: 'true',
++					VERBOSE_LOGGING: 'true'","Others seem to be using `environmentService.verbose` or `!environmentService.isBuilt || environmentService.verbose`. Not sure if it matters in this case, but we should avoid being noisy.",2016-11-30 19:47:23
+547,"@@ -5,330 +5,178 @@
+ 
+ 'use strict';
+ 
+-import * as strings from 'vs/base/common/strings';
++import uri from 'vs/base/common/uri';
+ 
+-import * as fs from 'fs';
++import * as os from 'os';
+ import * as path from 'path';
+ 
+-import * as baseMime from 'vs/base/common/mime';
+-import { ILineMatch, IProgress } from 'vs/platform/search/common/search';
+-import { detectMimeAndEncodingFromBuffer } from 'vs/base/node/mime';
++import * as ipc from 'vs/base/parts/ipc/common/ipc';
++
++import { IProgress } from 'vs/platform/search/common/search';
+ import { FileWalker } from 'vs/workbench/services/search/node/fileSearch';
+-import { UTF16le, UTF16be, UTF8, UTF8_with_bom, encodingExists, decode } from 'vs/base/node/encoding';
+ import { ISerializedFileMatch, ISerializedSearchComplete, IRawSearch, ISearchEngine } from './search';
++import { ISearchWorkerConfig, ISearchWorker, ISearchWorkerChannel, SearchWorkerChannelClient } from './worker/searchWorkerIpc';
+ 
+-interface ReadLinesOptions {
+-	bufferLength: number;
+-	encoding: string;
+-}
++import { Client } from 'vs/base/parts/ipc/node/ipc.cp';
+ 
+ export class Engine implements ISearchEngine<ISerializedFileMatch> {
+ 
+ 	private static PROGRESS_FLUSH_CHUNK_SIZE = 50; // optimization: number of files to process before emitting progress event
+ 
+-	private rootFolders: string[];
+-	private extraFiles: string[];
+-	private maxResults: number;
++	private config: IRawSearch;
+ 	private walker: FileWalker;
+-	private contentPattern: RegExp;
+-	private isCanceled: boolean;
+-	private isDone: boolean;
+-	private total: number;
+-	private worked: number;
+-	private progressed: number;
+ 	private walkerError: Error;
+-	private walkerIsDone: boolean;
+-	private fileEncoding: string;
+-	private limitReached: boolean;
++
++	private isCanceled = false;
++	private isDone = false;
++	private totalBytes = 0;
++	private processedBytes = 0;
++	private progressed = 0;
++	private walkerIsDone = false;
++	private limitReached = false;
++	private numResults = 0;
++
++	private nextWorker = 0;
++	private workers: ISearchWorker[] = [];
++	private workerClients: Client[] = [];
+ 
+ 	constructor(config: IRawSearch, walker: FileWalker) {
+-		this.rootFolders = config.rootFolders;
+-		this.extraFiles = config.extraFiles;
++		this.config = config;
+ 		this.walker = walker;
+-		this.contentPattern = strings.createRegExp(config.contentPattern.pattern, config.contentPattern.isRegExp, { matchCase: config.contentPattern.isCaseSensitive, wholeWord: config.contentPattern.isWordMatch, multiline: false, global: true });
+-		this.isCanceled = false;
+-		this.limitReached = false;
+-		this.maxResults = config.maxResults;
+-		this.worked = 0;
+-		this.progressed = 0;
+-		this.total = 0;
+-		this.fileEncoding = encodingExists(config.fileEncoding) ? config.fileEncoding : UTF8;
+ 	}
+ 
+-	public cancel(): void {
++	cancel(): void {
+ 		this.isCanceled = true;
+ 		this.walker.cancel();
+-	}
+ 
+-	public search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
+-		let resultCounter = 0;
++		this.workers.forEach(w => w.cancel());
++	}
+ 
+-		let progress = () => {
+-			this.progressed++;
+-			if (this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
+-				onProgress({ total: this.total, worked: this.worked }); // buffer progress in chunks to reduce pressure
++	search(onResult: (match: ISerializedFileMatch) => void, onProgress: (progress: IProgress) => void, done: (error: Error, complete: ISerializedSearchComplete) => void): void {
++		this.startWorkers();
++		const progress = () => {
++			if (++this.progressed % Engine.PROGRESS_FLUSH_CHUNK_SIZE === 0) {
++				onProgress({ total: this.totalBytes, worked: this.processedBytes }); // buffer progress in chunks to reduce pressure
+ 			}
+ 		};
+ 
+-		let unwind = (processed: number) => {
+-			this.worked += processed;
++		const unwind = (processed: number) => {
++			this.processedBytes += processed;
+ 
+ 			// Emit progress() unless we got canceled or hit the limit
+ 			if (processed && !this.isDone && !this.isCanceled && !this.limitReached) {
+ 				progress();
+ 			}
+ 
+ 			// Emit done()
+-			if (this.worked === this.total && this.walkerIsDone && !this.isDone) {
++			if (!this.isDone && this.processedBytes === this.totalBytes && this.walkerIsDone) {
+ 				this.isDone = true;
++				this.disposeWorkers();
+ 				done(this.walkerError, {
+ 					limitHit: this.limitReached,
+ 					stats: this.walker.getStats()
+ 				});
+ 			}
+ 		};
+ 
+-		// Walk over the file system
+-		this.walker.walk(this.rootFolders, this.extraFiles, result => {
+-			const size = result.size || 1;
+-			this.total += size;
+-
+-			// If the result is empty or we have reached the limit or we are canceled, ignore it
+-			if (this.limitReached || this.isCanceled) {
+-				return unwind(size);
+-			}
++		const run = (batch: string[], batchBytes: number): void => {
++			const worker = this.workers[this.nextWorker];
++			this.nextWorker = (this.nextWorker + 1) % this.workers.length;
+ 
+-			// Indicate progress to the outside
+-			progress();
+-
+-			let fileMatch: FileMatch = null;
+-
+-			let doneCallback = (error?: Error) => {
+-				if (!error && !this.isCanceled && fileMatch && !fileMatch.isEmpty()) {
+-					onResult(fileMatch.serialize());
+-				}
+-
+-				return unwind(size);
+-			};
+-
+-			const absolutePath = result.base ? [result.base, result.relativePath].join(path.sep) : result.relativePath;
+-			let perLineCallback = (line: string, lineNumber: number) => {
+-				if (this.limitReached || this.isCanceled) {
+-					return; // return early if canceled or limit reached
++			const maxResults = this.config.maxResults - this.numResults;
++			worker.search({ absolutePaths: batch, maxResults }).then(result => {
++				if (!result || this.limitReached || this.isCanceled) {
++					return unwind(batchBytes);
+ 				}
+ 
+-				let lineMatch: LineMatch = null;
+-				let match = this.contentPattern.exec(line);
+-
+-				// Record all matches into file result
+-				while (match !== null && match[0].length > 0 && !this.limitReached && !this.isCanceled) {
+-					resultCounter++;
+-					if (this.maxResults && resultCounter >= this.maxResults) {
+-						this.limitReached = true;
+-					}
+-
+-					if (fileMatch === null) {
+-						fileMatch = new FileMatch(absolutePath);
+-					}
+-
+-					if (lineMatch === null) {
+-						lineMatch = new LineMatch(line, lineNumber);
+-						fileMatch.addMatch(lineMatch);
+-					}
+-
+-					lineMatch.addMatch(match.index, match[0].length);
++				const matches = result.matches;
++				this.numResults += result.numMatches;
++				matches.forEach(m => {
++					onResult(m);
++				});
+ 
+-					match = this.contentPattern.exec(line);
++				if (this.numResults >= this.config.maxResults) {
++					// It's possible to go over maxResults like this, but it's much simpler than trying to extract the exact number
++					// of file matches, line matches, and matches within a line to == maxResults.
++					this.limitReached = true;
+ 				}
+-			};
+ 
+-			// Read lines buffered to support large files
+-			this.readlinesAsync(absolutePath, perLineCallback, { bufferLength: 8096, encoding: this.fileEncoding }, doneCallback);
+-		}, (error, isLimitHit) => {
+-			this.walkerIsDone = true;
+-			this.walkerError = error;
+-			unwind(0 /* walker is done, indicate this back to our handler to be able to unwind */);
+-		});
+-	}
++				unwind(batchBytes);
++			});
++		};
+ 
+-	private readlinesAsync(filename: string, perLineCallback: (line: string, lineNumber: number) => void, options: ReadLinesOptions, callback: (error: Error) => void): void {
+-		fs.open(filename, 'r', null, (error: Error, fd: number) => {
+-			if (error) {
+-				return callback(error);
++		// Walk over the file system
++		let nextBatch = [];
++		let nextBatchBytes = 0;
++		const batchFlushBytes = 2 ** 20; // 1MB
++		this.walker.walk(this.config.rootFolders, this.config.extraFiles, result => {
++			let bytes = result.size || 1;
++			this.totalBytes += bytes;
++
++			// If we have reached the limit or we are canceled, ignore it
++			if (this.limitReached || this.isCanceled) {
++				return unwind(bytes);
+ 			}
+ 
+-			let buffer = new Buffer(options.bufferLength);
+-			let pos: number;
+-			let i: number;
+-			let line = '';
+-			let lineNumber = 0;
+-			let lastBufferHadTraillingCR = false;
+-
+-			const outer = this;
+-
+-			function decodeBuffer(buffer: NodeBuffer, start: number, end: number): string {
+-				if (options.encoding === UTF8 || options.encoding === UTF8_with_bom) {
+-					return buffer.toString(undefined, start, end); // much faster to use built in toString() when encoding is default
+-				}
++			// Indicate progress to the outside
++			progress();
+ 
+-				return decode(buffer.slice(start, end), options.encoding);
+-			}
++			const absolutePath = result.base ? [result.base, result.relativePath].join(path.sep) : result.relativePath;
++			nextBatch.push(absolutePath);
++			nextBatchBytes += bytes;
+ 
+-			function lineFinished(offset: number): void {
+-				line += decodeBuffer(buffer, pos, i + offset);
+-				perLineCallback(line, lineNumber);
+-				line = '';
+-				lineNumber++;
+-				pos = i + offset;
++			if (nextBatchBytes >= batchFlushBytes) {
++				run(nextBatch, nextBatchBytes);
++				nextBatch = [];
++				nextBatchBytes = 0;
+ 			}
+-
+-			function readFile(isFirstRead: boolean, clb: (error: Error) => void): void {
+-				if (outer.limitReached || outer.isCanceled) {
+-					return clb(null); // return early if canceled or limit reached
++		}, (error, isLimitHit) => {
++			// Send any remaining paths to a worker, or unwind if we're stopping
++			if (nextBatch.length) {
++				if (this.limitReached || this.isCanceled) {
++					unwind(nextBatchBytes);
++				} else {
++					run(nextBatch, nextBatchBytes);
+ 				}
+-
+-				fs.read(fd, buffer, 0, buffer.length, null, (error: Error, bytesRead: number, buffer: NodeBuffer) => {
+-					if (error || bytesRead === 0 || outer.limitReached || outer.isCanceled) {
+-						return clb(error); // return early if canceled or limit reached or no more bytes to read
+-					}
+-
+-					pos = 0;
+-					i = 0;
+-
+-					// Detect encoding and mime when this is the beginning of the file
+-					if (isFirstRead) {
+-						let mimeAndEncoding = detectMimeAndEncodingFromBuffer(buffer, bytesRead);
+-						if (mimeAndEncoding.mimes[mimeAndEncoding.mimes.length - 1] !== baseMime.MIME_TEXT) {
+-							return clb(null); // skip files that seem binary
+-						}
+-
+-						// Check for BOM offset
+-						switch (mimeAndEncoding.encoding) {
+-							case UTF8:
+-								pos = i = 3;
+-								options.encoding = UTF8;
+-								break;
+-							case UTF16be:
+-								pos = i = 2;
+-								options.encoding = UTF16be;
+-								break;
+-							case UTF16le:
+-								pos = i = 2;
+-								options.encoding = UTF16le;
+-								break;
+-						}
+-					}
+-
+-					if (lastBufferHadTraillingCR) {
+-						if (buffer[i] === 0x0a) { // LF (Line Feed)
+-							lineFinished(1);
+-							i++;
+-						} else {
+-							lineFinished(0);
+-						}
+-
+-						lastBufferHadTraillingCR = false;
+-					}
+-
+-					for (; i < bytesRead; ++i) {
+-						if (buffer[i] === 0x0a) { // LF (Line Feed)
+-							lineFinished(1);
+-						} else if (buffer[i] === 0x0d) { // CR (Carriage Return)
+-							if (i + 1 === bytesRead) {
+-								lastBufferHadTraillingCR = true;
+-							} else if (buffer[i + 1] === 0x0a) { // LF (Line Feed)
+-								lineFinished(2);
+-								i++;
+-							} else {
+-								lineFinished(1);
+-							}
+-						}
+-					}
+-
+-					line += decodeBuffer(buffer, pos, bytesRead);
+-
+-					readFile(false /* isFirstRead */, clb); // Continue reading
+-				});
+ 			}
+ 
+-			readFile(true /* isFirstRead */, (error: Error) => {
+-				if (error) {
+-					return callback(error);
+-				}
+-
+-				if (line.length) {
+-					perLineCallback(line, lineNumber); // handle last line
+-				}
+-
+-				fs.close(fd, (error: Error) => {
+-					callback(error);
+-				});
+-			});
++			this.walkerIsDone = true;
++			this.walkerError = error;
+ 		});
+ 	}
+-}
+-
+-class FileMatch implements ISerializedFileMatch {
+-	public path: string;
+-	public lineMatches: LineMatch[];
+-
+-	constructor(path: string) {
+-		this.path = path;
+-		this.lineMatches = [];
+-	}
+ 
+-	public addMatch(lineMatch: LineMatch): void {
+-		this.lineMatches.push(lineMatch);
+-	}
+-
+-	public isEmpty(): boolean {
+-		return this.lineMatches.length === 0;
+-	}
+-
+-	public serialize(): ISerializedFileMatch {
+-		let lineMatches: ILineMatch[] = [];
+-
+-		for (let i = 0; i < this.lineMatches.length; i++) {
+-			lineMatches.push(this.lineMatches[i].serialize());
++	private startWorkers(): void {
++		// If the CPU has hyperthreading enabled, this will report (# of physical cores)*2.
++		const numWorkers = os.cpus().length;
++		for (let i = 0; i < numWorkers; i++) {
++			this.createWorker(i);
+ 		}
+-
+-		return {
+-			path: this.path,
+-			lineMatches: lineMatches
+-		};
+-	}
+-}
+-
+-class LineMatch implements ILineMatch {
+-	public preview: string;
+-	public lineNumber: number;
+-	public offsetAndLengths: number[][];
+-
+-	constructor(preview: string, lineNumber: number) {
+-		this.preview = preview.replace(/(\r|\n)*$/, '');
+-		this.lineNumber = lineNumber;
+-		this.offsetAndLengths = [];
+ 	}
+ 
+-	public getText(): string {
+-		return this.preview;
+-	}
++	private createWorker(id: number): void {
++		let client = new Client(
++			uri.parse(require.toUrl('bootstrap')).fsPath,
++			{
++				serverName: 'Search Worker ' + id,
++				args: ['--type=searchWorker'],
++				env: {
++					AMD_ENTRYPOINT: 'vs/workbench/services/search/node/worker/searchWorkerApp',
++					PIPE_LOGGING: 'true',
++					VERBOSE_LOGGING: 'true'
++				}
++			});
+ 
+-	public getLineNumber(): number {
+-		return this.lineNumber;
+-	}
++		// Make async?
++		const channel = ipc.getNextTickChannel(client.getChannel<ISearchWorkerChannel>('searchWorker'));
++		const channelClient = new SearchWorkerChannelClient(channel);
++		const config: ISearchWorkerConfig = { pattern: this.config.contentPattern, id, fileEncoding: this.config.fileEncoding };
++		channelClient.initialize(config);",Add error handler.,2016-11-30 19:56:21
+91,"@@ -5,4 +5,9 @@
+ 
+ import {IComposite} from 'vs/workbench/common/composite';
+ 
+-export interface IViewlet extends IComposite { }
++export interface IViewlet extends IComposite {
++	/**
++	 * Returns the minimal width needed to avoid any content horizontal truncation
++	 */
++	getOptimalWidth?(): number;","Suggest to make this a non optional method and implement it by default in the base viewlet class.
+",2016-03-30 05:25:08
+290,"@@ -50,8 +50,8 @@ export function create(container: Builder, keybindingService: IKeybindingService
+ 					entry.ids
+ 						.map(id => keybindingService.lookupKeybindings(id)
+ 							.map(k => keybindingService.getLabelFor(k))
+-							.join(', ') || UNBOUND)
+-						.join(' / ')
++							.join(' or ') || UNBOUND)
++						.join(' or ')","We'll need to translate these.
+",2016-09-27 04:34:16
+563,"@@ -51,11 +51,6 @@ export class BackupMainService implements IBackupMainService {
+ 	}
+ 
+ 	public registerWindowForBackups(windowId: number, isEmptyWorkspace: boolean, backupFolder?: string, workspacePath?: string): void {","@Tyriar I didnt know you had this check in here, I am also fine leaving it there to keep this knowledge inside the service!",2016-12-02 08:28:50
+497,"@@ -51,6 +51,7 @@ export interface IEnvironmentService {
+ 	appSettingsPath: string;
+ 	appKeybindingsPath: string;
+ 
++	isBackupEnabled: boolean;","@Tyriar not so sure about introducing such a specific option to the environment service. keep in mind that it is being used in a lot of environments, including the CLI when managing extensions. I think a better approach is to introduce an `isExtensionDevelopment` flag that we can use to replace all our checks for `extensionDevelopmentPath` throughout the code. 
+",2016-11-17 05:58:36
+10,"@@ -51,7 +51,7 @@ export var language = <ILanguage> {
+ 		'internal', 'private', 'abstract', 'sealed', 'static', 'struct', 'readonly',
+ 		'volatile', 'virtual', 'override', 'params', 'get', 'set', 'add', 'remove',
+ 		'operator', 'true', 'false', 'implicit', 'explicit', 'interface', 'enum',
+-		'null', 'async', 'await'
++		'null', 'async', 'await','fixed','sizeof','stackalloc','unsafe'
+ 		],","This change is good, but note that this file is not in use in VS Code. For CSharp colorization in VS Code we use `/extensions/csharp/syntaxes/csharp.json`. 
+This file is used for the standalone editor build.
+",2015-11-21 19:13:06
+683,"@@ -510,30 +505,6 @@ export class RawDebugSession extends v8.V8Protocol implements debug.ISession {
+ 		return ret;
+ 	}
+ ",Great that this is no longer in RawDebugSession!,2017-01-18 14:03:24
+854,"@@ -511,7 +511,8 @@ export class VSCodeMenu {
+ 
+ 		if (folders.length || files.length) {
+ 			openRecentMenu.append(__separator__());
+-			openRecentMenu.append(new MenuItem(this.likeAction('clearRecentlyOpened', { label: mnemonicLabel(nls.localize({ key: 'miClearItems', comment: ['&& denotes a mnemonic'] }, ""&&Clear Items"")), click: () => this.windowsService.clearRecentPathsList() }, false)));
++			//workbench.action.clearRecentItems",Extra comment?,2017-03-23 14:05:35
+110,"@@ -52,24 +54,40 @@ export interface IWorkbenchActionRegistry {
+ 	 * Returns the category for the given action or null iff none.
+ 	 */
+ 	getCategory(actionId: string): string;
++
++	/**
++	 * Returns the keywords associated with the given action or null iff none.
++	 */
++	getKeywords(actionId: string): string[];
+ }
+ 
+ class WorkbenchActionRegistry implements IWorkbenchActionRegistry {
+ 	private workbenchActions: collections.IStringDictionary<SyncActionDescriptor>;
+ 	private mapActionIdToCategory: { [id: string]: string; };
++	private mapActionIdToKeywords: { [id: string]: string[]; };
+ 
+ 	constructor() {
+ 		this.workbenchActions = Object.create(null);
+ 		this.mapActionIdToCategory = Object.create(null);
++		this.mapActionIdToKeywords = Object.create(null);","will it be better to actually have a map to everything? Have map where values will be some structure, so you will not need to maintain two of them?
+",2016-04-18 13:35:24
+109,"@@ -52,24 +54,40 @@ export interface IWorkbenchActionRegistry {
+ 	 * Returns the category for the given action or null iff none.
+ 	 */
+ 	getCategory(actionId: string): string;
++
++	/**
++	 * Returns the keywords associated with the given action or null iff none.
++	 */
++	getKeywords(actionId: string): string[];
+ }
+ 
+ class WorkbenchActionRegistry implements IWorkbenchActionRegistry {
+ 	private workbenchActions: collections.IStringDictionary<SyncActionDescriptor>;
+ 	private mapActionIdToCategory: { [id: string]: string; };
++	private mapActionIdToKeywords: { [id: string]: string[]; };
+ 
+ 	constructor() {
+ 		this.workbenchActions = Object.create(null);
+ 		this.mapActionIdToCategory = Object.create(null);
++		this.mapActionIdToKeywords = Object.create(null);
+ 	}
+ 
+-	public registerWorkbenchAction(descriptor: SyncActionDescriptor, category?: string): void {
++	public registerWorkbenchAction(descriptor: SyncActionDescriptor, category?: string): void;
++	public registerWorkbenchAction(descriptor: SyncActionDescriptor, keywords?: string[]): void;
++	public registerWorkbenchAction(descriptor: SyncActionDescriptor, category?: string, keywords?: string[]): void;
++	public registerWorkbenchAction(descriptor: SyncActionDescriptor, categoryOrKeywords?: string|string[], keywords?: string[]): void {
+ 		if (!this.workbenchActions[descriptor.id]) {
+ 			this.workbenchActions[descriptor.id] = descriptor;
+ 			registerWorkbenchCommandFromAction(descriptor);
+ 
+-			if (category) {
+-				this.mapActionIdToCategory[descriptor.id] = category;
++			if (typeof categoryOrKeywords === 'string') {","`Types.isString`?
+",2016-04-18 13:34:07
+193,"@@ -52,7 +55,7 @@ export class TerminalInstance {
+ 				this.isExiting = true;
+ 				this.dispose();
+ 				if (exitCode) {
+-					console.error('Integrated terminal exited with code ' + exitCode);
++					this.messageService.show(Severity.Error, nls.localize('terminal.integrated.exitedWithCode', 'Terminal: The terminal process terminated with exit code: {0}', exitCode));","I don't think `Terminal:` is necessary here, doesn't seem to be used elsewhere (from a cursory search of `Severity.Error`).
+",2016-07-05 20:53:09
+156,"@@ -53,6 +53,11 @@ export class SassParser extends cssParser.Parser {
+ 
+ 	// Sass variables: $font-size: 12px;
+ 	public _parseVariableDeclaration(panic:scanner.TokenType[]=[]): nodes.VariableDeclaration {
++		var cssVariableDeclaration= super._parseCssVariableDeclaration(panic);","That looks wrong. Not all places where you can declare a sass variable are also suited to declare a css variable.
+",2016-05-20 10:23:37
+304,"@@ -532,7 +532,7 @@ export class TextEditorOptions extends EditorOptions {
+ 	public static from(input: IResourceInput): TextEditorOptions {
+ 		let options: TextEditorOptions = null;
+ 		if (input && input.options) {
+-			if (input.options.selection || input.options.forceOpen || input.options.revealIfVisible || input.options.preserveFocus || input.options.pinned || input.options.inactive || typeof input.options.index === 'number') {
++			if (input.options.selection || input.options.forceOpen || input.options.revealIfVisible || !input.options.preserveFocus || input.options.pinned || input.options.inactive || typeof input.options.index === 'number') {","all of this cannot be changed...
+",2016-10-05 08:24:48
+631,"@@ -536,25 +540,37 @@
+ 					<!-- seperator    [ ]{0,3}([-*_][ ]{0,2}\2){2,}[ \t]*$\n? -->
+ 					<!-- list         [ ]{0,3}[*+-]([ ]{1,3}|\t) -->
+ 					<!-- both are folded together in the expression below -->
+-					<string>(^|\G)(?!\s*$|#|[ ]{0,3}((([*_][ ]{0,2}\2){2,}[ \t]*$\n?)|([*+-]([ ]{1,3}|\t)))|\s*\[.+?\]:|&gt;)</string>
+-				</dict>
+-				<key>raw_block</key>
+-				<dict>
+-					<key>begin</key>
+-					<string>(^|\G)([ ]{4}|\t)</string>
+-					<key>name</key>
+-					<string>markup.raw.block.markdown</string>
+-					<key>while</key>
+-					<string>(^|\G)([ ]{4}|\t)</string>
++					<string>(^|\G)(?!\s*$|#|[`~]{0,3}|[ ]{0,3}((([*_][ ]{0,2}\2){2,}[ \t]*$\n?)|([*+-]([ ]{1,3}|\t)))|\s*\[.+?\]:|&gt;)</string>
+ 				</dict>
+ 				<key>fenced_code_block_css</key>
+ 				<dict>
+ 					<key>begin</key>
+-					<string>(^|\G)\s*(([`~]){3,})\s*(css|css.erb)(\s+.*)?$</string>
++					<string>(^|\G)\s*([`~]{3,})\s*(css|css.erb)\n</string>
+ 					<key>name</key>
+ 					<string>markup.fenced_code.block.markdown</string>
+-					<key>while</key>
+-					<string>(^|\G)(?!\s*\2\3*\s*$)</string>
++					<key>end</key>
++					<string>(^|\G)\s*([`~]{3,})\n</string>",We have to use a while clause here. This prevents broken language grammars from leaking outside of the fenced block. Switching to while from end fixed a large number of syntax highlighting issues.,2016-12-20 23:29:21
+848,"@@ -539,6 +539,48 @@ export class WorkbenchLayout implements IVerticalSashLayoutProvider, IHorizontal
+ 		return this.panelMaximized;
+ 	}
+ 
++	// Add reset for keyboard support
++	public resetSideBarWidth(): number {",Not being used?,2017-03-22 13:26:51
+849,"@@ -539,6 +539,48 @@ export class WorkbenchLayout implements IVerticalSashLayoutProvider, IHorizontal
+ 		return this.panelMaximized;
+ 	}
+ 
++	// Add reset for keyboard support
++	public resetSideBarWidth(): number {
++		this.sidebarWidth = MIN_SIDEBAR_PART_WIDTH;
++		return this.sidebarWidth;
++	}
++
++	// change part size along the main axis
++	public setPartSizeChange(part: Parts, sizeChange: number): boolean {",This method should do the same validation about minimal and maximal sizes for a specific part as we already do when the user resizes a view using the sashes (e.g. [here](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/browser/layout.ts#L192)),2017-03-22 13:28:25
+369,"@@ -549,6 +568,33 @@ export class QuickOpenController extends WorkbenchComponent implements IQuickOpe
+ 		return promiseCompletedOnHide;
+ 	}
+ 
++	private handleOnCancel(isPicker: boolean): void {
++		// restore the editor part state after cancelling
++		this.historyService.block(true);","@wprater shouldn't this be `block(false)`? also I am missing the all to `block(true)`.
+",2016-10-21 10:03:37
+370,"@@ -549,6 +568,33 @@ export class QuickOpenController extends WorkbenchComponent implements IQuickOpe
+ 		return promiseCompletedOnHide;
+ 	}
+ 
++	private handleOnCancel(isPicker: boolean): void {
++		// restore the editor part state after cancelling
++		this.historyService.block(true);
++
++		// restore the previous preview editor
++		if (this.previousPreviewEditorInput) {","@wprater unfortunately I think this is more complicated for the restore part. I can see the following states:
+- 1.) no active editor
+- 2.) no preview editor
+- 3.) active editor is preview editor
+- 4.) active editor is not preview editor
+
+1.) easy, just close the preview editor that was opened
+2.) also easy, just close the preview editor
+3.) restore the previous active editor by opening it
+4.) restore the previous editor in the preview slot but open it in the background because it was not the active one. also open the previous active editor
+
+Also you have to be careful that you do this from the `onCancel()` callback. Because as far as I remember this method is not called when you actually pick an entry from quick open. I would expect some additional logic when an element is picked.
+",2016-10-21 10:06:44
+67,"@@ -55,23 +55,30 @@ export interface IThread extends ITreeElement {
+ 	threadId: number;
+ 	name: string;
+ 	stoppedDetails: IRawStoppedDetails;
++
++	/**
++	 * Queries the debug adapter for the callstack and returns a promise with
++	 * the stack frames of the callstack.
++	 * If the thread is not stopped, it returns a promise to an empty array.
++	 */
+ 	getCallStack(debugService: IDebugService): TPromise<IStackFrame[]>;
+-	clearCallStack(): void;
+ 
+ 	/**
+-	 * Indicates whether the call stack for this thread can be obtained from
+-	 * the debug adapter.
++	 * Gets the callstack if it has already been received from the debug
++	 * adapter, otherwise it returns undefined.
+ 	 */
+-	callStackObtainable: boolean;
++	getCachedCallStack(): IStackFrame[];
+ 
+ 	/**
+-	 * Indicates whether the call stack for this thread is available because it
+-	 * has already been obtained from the debug adapter.
+-	 * This property is used to determine whether the call stack is available
+-	 * without triggering a call to the debug adapter.
++	 * Invalidates the callstack cache
+ 	 */
+-	callStackAvailable: boolean;
++	clearCallStack(): void;
+ 
++	/**
++	 * Indicates whether this thread is stopped. The callstack for stopped
++	 * threads can be retrieved from the debug adapter.
++	 */
++	stopped: boolean;","`stopped` doesn't necessarily need to be exposed. We could have two methods `setRunning` and `setStopped` that would set `stopped` to false and `true`, respectively.
+
+I left it exposed so that the tests can check it. I'm fine removing `stopped` from the interface and only have setters. Let me know what you think.
+",2016-03-16 02:48:04
+881,"@@ -55,7 +55,39 @@ export class CodeSnippet implements ICodeSnippet {
+ 	}
+ 
+ 	static fromEmmet(template: string): CodeSnippet {
+-		return EmmetSnippetParser.parse(template);
++		//return EmmetSnippetParser.parse(template);
++
++		let matchFinalStops = template.match(/\$\{0\}/g);
++		if (!matchFinalStops || matchFinalStops.length === 1) {
++			return CodeSnippet.fromTextmate(template);
++		}
++
++		// Emmet sometimes returns snippets with multiple ${0}
++		// In such cases, replace ${0} with incremental tab stops
++","There is also the shorthand notion which omits the curlies, like so `foo$1ba$0r`. Isn't emmet using that?",2017-04-14 07:41:24
+882,"@@ -55,7 +55,39 @@ export class CodeSnippet implements ICodeSnippet {
+ 	}
+ 
+ 	static fromEmmet(template: string): CodeSnippet {
+-		return EmmetSnippetParser.parse(template);
++		//return EmmetSnippetParser.parse(template);
++
++		let matchFinalStops = template.match(/\$\{0\}/g);
++		if (!matchFinalStops || matchFinalStops.length === 1) {
++			return CodeSnippet.fromTextmate(template);
++		}
++
++		// Emmet sometimes returns snippets with multiple ${0}
++		// In such cases, replace ${0} with incremental tab stops
++
++		let maxTabStop = -1;
++		let matches = [];
++		let regex = /\$\{(\d+)\}/g;
++		while (matches = regex.exec(template)) {
++			let tabStop = Number(matches[1]);
++			if (tabStop > maxTabStop) {
++				maxTabStop = tabStop;
++			}
++		}
++		regex = /\$\{(\d+):[^\}]+\}/g;
++		matches = [];
++		while (matches = regex.exec(template)) {
++			let tabStop = Number(matches[1]);
++			if (tabStop > maxTabStop) {
++				maxTabStop = tabStop;
++			}
++		}","If this is becoming too complex, e.g `$1`, with escaped `}`, or nested placeholder (stretch, like `foo ${1:\}}` or `foo${2:b${1:ar}$0`), we should consider using the (new) snippet parser (`SnippetParser`) which allows you read all placeholders. Tho I'd say that depends on the Emmet-TextMate-subset",2017-04-14 07:44:44
+291,"@@ -55,7 +55,8 @@
+ 	width: 49%;
+ 	margin: 0 1% 0 0;
+ 	text-align: right;
+-	font-weight: bold;
++	font-weight: normal;","You can just take out `font-weight` altogether
+",2016-09-29 00:14:11
+902,"@@ -55,8 +55,26 @@ export class ExtHostEditors extends ExtHostEditorsShape {
+ 		return this._extHostDocumentsAndEditors.allEditors();
+ 	}
+ 
+-	showTextDocument(document: vscode.TextDocument, column: vscode.ViewColumn, preserveFocus: boolean): TPromise<vscode.TextEditor> {
+-		return this._proxy.$tryShowTextDocument(<URI>document.uri, TypeConverters.fromViewColumn(column), preserveFocus).then(id => {
++	showTextDocument(document: vscode.TextDocument, column: vscode.ViewColumn, preserveFocus: boolean): TPromise<vscode.TextEditor>;
++	showTextDocument(document: vscode.TextDocument, options: { column: vscode.ViewColumn, preserveFocus: boolean, pinned: boolean }): TPromise<vscode.TextEditor>;
++	showTextDocument(document: vscode.TextDocument, columnOrOptions: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): TPromise<vscode.TextEditor>;
++	showTextDocument(document: vscode.TextDocument, columnOrOptions: vscode.ViewColumn | vscode.TextDocumentShowOptions, preserveFocus?: boolean): TPromise<vscode.TextEditor> {
++		let options: ITextDocumentShowOptions;
++		if (typeof columnOrOptions === 'number') {
++			options = {
++				position: TypeConverters.fromViewColumn(columnOrOptions),
++				preserveFocus: preserveFocus,
++				pinned: true
++			};
++		} else {
++			options = {",The `else` cannot be unconditional because it will be hit when no second parameter is given. Add a check like `typeof columnOrOptions === 'object'`,2017-04-25 14:05:50
+224,"@@ -553,6 +552,18 @@ export class OneCursor {
+ 	public getViewLineMaxColumn(lineNumber:number): number {
+ 		return this.viewModelHelper.viewModel.getLineMaxColumn(lineNumber);
+ 	}
++	public getViewLineMinColumn(lineNumber:number): number {
++		return this.viewModelHelper.viewModel.getLineMinColumn(lineNumber);
++	}
++	public getViewLineCenterColumn(lineNumber:number): number {","You have to be careful about this one. This does not work for lines containing bi-di or variable width character sizes.
+",2016-07-15 11:12:25
+13,"@@ -553,6 +564,9 @@ export class MainThreadDocuments {
+ 		modelService.onModelRemoved.add(this._onModelRemoved, this, this._toDispose);
+ 		modelService.onModelModeChanged.add(this._onModelModeChanged, this, this._toDispose);
+ 
++		this._toDispose.push(eventService.addListener2(FileEventType.FILE_SAVING, (e: LocalFileChangeEvent) => {
++			this._proxy._acceptModelSaving(e.getAfter().resource);
++		}));","What guarantees do we make when a document is being saved? Can people still modify etc?
+",2015-11-24 09:12:06
+864,"@@ -555,13 +556,15 @@ export class GlobalNewUntitledFileAction extends Action {
+ 		id: string,
+ 		label: string,
+ 		@IWorkbenchEditorService private editorService: IWorkbenchEditorService,
+-		@IUntitledEditorService private untitledEditorService: IUntitledEditorService
++		@IUntitledEditorService private untitledEditorService: IUntitledEditorService,
++		@IConfigurationService private configurationService: IConfigurationService
+ 	) {
+ 		super(id, label);
+ 	}
+ 
+ 	public run(): TPromise<any> {
+-		const input = this.untitledEditorService.createOrGet();
++		const configuration = this.configurationService.getConfiguration<IFilesConfiguration>();","I suggest to not add this to the action but actually to the place where untitled editors are being created. There can be other ways how untitled buffers open (e.g. from extensions) and I think a configured default language would also apply there.
+
+I am thinking somewhere inside https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/services/untitled/common/untitledEditorService.ts#L177 to use the configuration if the `modeId` parameter is undefined.",2017-03-25 23:52:49
+743,"@@ -557,6 +617,7 @@ class MouseDownState {
+ 	private _lastMouseDownPositionEqualCount: number;
+ 	private _lastMouseDownCount: number;
+ 	private _lastSetMouseDownCountTime: number;
++	private _lastMouseDownEvent: 'mouseDown' | 'drag';",pick a better name for this. Perhaps just a boolean `isDragAndDrop` would do. This boolean should be set only in the `start` method above,2017-02-20 11:13:52
+732,"@@ -558,4 +560,97 @@ export class ViewModel extends EventEmitter implements IViewModel {
+ 	public validateModelPosition(position: editorCommon.IPosition): Position {
+ 		return this.model.validatePosition(position);
+ 	}
++
++	public getPlainTextToCopy(ranges: Range[], enableEmptySelectionClipboard: boolean): string {
++		let newLineCharacter = this.getEOL();
++
++		if (ranges.length === 1) {
++			let range: Range = ranges[0];
++			if (range.isEmpty()) {
++				if (enableEmptySelectionClipboard) {
++					let modelLineNumber = this.coordinatesConverter.convertViewPositionToModelPosition(new Position(range.startLineNumber, 1)).lineNumber;
++					return this.getModelLineContent(modelLineNumber) + newLineCharacter;
++				} else {
++					return '';
++				}
++			}
++
++			return this.getValueInRange(range, editorCommon.EndOfLinePreference.TextDefined);
++		} else {
++			ranges = ranges.slice(0).sort(Range.compareRangesUsingStarts);
++			let result: string[] = [];
++			for (let i = 0; i < ranges.length; i++) {
++				result.push(this.getValueInRange(ranges[i], editorCommon.EndOfLinePreference.TextDefined));
++			}
++
++			return result.join(newLineCharacter);
++		}
++	}
++
++	public getHTMLToCopy(ranges: Range[], enableEmptySelectionClipboard: boolean): string {
++		let rules: { [key: string]: string } = {};",please leave a TODO here so we clean this up once the minimap branch gets merged in (same as above),2017-02-16 15:55:11
+517,"@@ -56,6 +60,12 @@ export class DebugEditorContribution implements IDebugEditorContribution {
+ 		this.hideHoverScheduler = new RunOnceScheduler(() => this.hoverWidget.hide(), HOVER_DELAY);
+ 		this.registerListeners();
+ 		this.breakpointWidgetVisible = CONTEXT_BREAKPOINT_WIDGET_VISIBLE.bindTo(contextKeyService);
++
++		// TODO: How do I register a new decoration type using exposed api ?","You do not need to do any of this. Just by calling editor.deltaDecorations editor should register you decoration nicely.
+When removing decorations you will also use ids of each of the added decorations by calling deltaDecoraitons.",2016-11-28 10:27:42
+620,"@@ -56,8 +56,7 @@ export class KillTerminalAction extends Action {
+ }
+ 
+ /**
+- * Copies the terminal selection. Note that since the command palette takes focus from the terminal,",This comment seems obsolete to me. Let me know if i'm missing something.,2016-12-18 22:50:04
+622,"@@ -56,8 +56,7 @@ export class KillTerminalAction extends Action {
+ }
+ 
+ /**
+- * Copies the terminal selection. Note that since the command palette takes focus from the terminal,
+- * this can only be triggered via a keybinding.
++ * Copies the terminal selection.","The comment is still relevant as you can't trigger it through the command palette. This is what it should probably say though:
+
+```js
+/**
+ * Copies the terminal selection. Note that since the command palette takes focus from the terminal,
+ * this cannot be triggered through the command palette.
+ */
+```",2016-12-19 05:31:33
+134,"@@ -560,7 +560,7 @@ export abstract class BaseGlobalNewAction extends Action {
+ }
+ 
+ /* Create new file from anywhere: Open untitled */
+-export class GlobalNewFileAction extends Action {
++export class GlobalNewUntitledFileAction extends Action {
+ 	public static ID = 'workbench.action.files.newUntitledFile';
+ 	public static LABEL = nls.localize('newFile', ""New File"");","Should this maybe read ""New Untitled File"" to make the difference clear?
+",2016-04-21 11:12:56
+632,"@@ -566,11 +582,32 @@
+ 				<key>fenced_code_block_basic</key>
+ 				<dict>
+ 					<key>begin</key>
+-						<string>(^|\G)\s*(([`~]){3,})\s*(html|htm|shtml|xhtml|inc|tmpl|tpl)(\s+.*)?$</string>
++					<string>(^|\G)\s*([`~]{3,})\s*(html|htm|shtml|xhtml|inc|tmpl|tpl)\n</string>",Keep the `(\s+.*)?$`bit. We allow arbitrary text on the rest of the line after the language identifier to support passing other attributes (like line numbers specifiers) that some markdown engines support.,2016-12-20 23:31:27
+633,"@@ -566,11 +582,32 @@
+ 				<key>fenced_code_block_basic</key>
+ 				<dict>
+ 					<key>begin</key>
+-						<string>(^|\G)\s*(([`~]){3,})\s*(html|htm|shtml|xhtml|inc|tmpl|tpl)(\s+.*)?$</string>
++					<string>(^|\G)\s*([`~]{3,})\s*(html|htm|shtml|xhtml|inc|tmpl|tpl)\n</string>
+ 					<key>name</key>
+ 					<string>markup.fenced_code.block.markdown</string>
+-					<key>while</key>
+-					<string>(^|\G)(?!\s*\2\3*\s*$)</string>
++					<key>end</key>
++					<string>(^|\G)\s*([`~]{3,})\n</string>",This should also reverted to how it was before so that we consume any number of spaces after the fence end and the end of line.,2016-12-20 23:32:17
+762,"@@ -569,6 +569,9 @@ export class TerminalInstance implements ITerminalInstance {
+ 			env['PTYCOLS'] = cols.toString();
+ 			env['PTYROWS'] = rows.toString();
+ 		}
++		if (!env['LANG']) {","I think it's a good idea to have a fallback, but this would probably be better in `_getLangEnvVariable` instead, replacing the `n === 0` case :+1: ",2017-02-20 20:34:02
+133,"@@ -57,7 +57,7 @@ const category = nls.localize('filesCategory', ""Files"");
+ 
+ let workbenchActionsRegistry = <IWorkbenchActionRegistry>Registry.as(ActionExtensions.WorkbenchActions);
+ workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(SaveFileAsAction, SaveFileAsAction.ID, SaveFileAsAction.LABEL, { primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KEY_S }), category, ['save', 'as']);
+-workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewFileAction, GlobalNewFileAction.ID, GlobalNewFileAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_N }), category, ['new', 'file']);
++workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(GlobalNewUntitledFileAction, GlobalNewUntitledFileAction.ID, GlobalNewUntitledFileAction.LABEL, { primary: KeyMod.CtrlCmd | KeyCode.KEY_N }), category, ['new', 'file']);","Maybe add the ""untitled"" to the keywords?
+",2016-04-21 11:12:17
+282,"@@ -57,7 +61,15 @@ export class LineNumbersOverlay extends DynamicViewOverlay {
+ 		return true;
+ 	}
+ 	public onCursorPositionChanged(e:editorCommon.IViewCursorPositionChangedEvent): boolean {
+-		return false;
++		let modelPosition = this._context.model.convertViewPositionToModelPosition(e.position.lineNumber, e.position.column);
++
++		if (!this._relativeLineNumbers || this._currentLineNumber === modelPosition.lineNumber) {
++			return false;
++		}
++
++		this._currentLineNumber = modelPosition.lineNumber;","In the case where `this._relativeLineNumbers` is `false`, `this._currentLineNumber` should still be assigned such that `this._currentLineNumber` always has a good value.
+
+It is possible that the `relativeLineNumbers` option changes at runtime and in that case we'd want `this._currentLineNumber` to be up-to-date.
+",2016-09-21 06:06:24
+865,"@@ -575,6 +575,7 @@ export interface IFilesConfiguration {
+ 		exclude: glob.IExpression;
+ 		watcherExclude: { [filepattern: string]: boolean };
+ 		encoding: string;
++		defaultLanguage: string;",We do have an extension running that provides intellisense inside settings. For this setting I would like to see the list of language Ids when the user wants to quickly select a known language. The place to add this is here: https://github.com/Microsoft/vscode/blob/master/extensions/configuration-editing/src/settingsDocumentHelper.ts#L26,2017-03-25 23:55:11
+680,"@@ -58,12 +59,19 @@ export enum TextEditorRevealType {
+ 	InCenterIfOutsideViewport = 2
+ }
+ 
+-export interface IApplyEditsOptions {
++export interface IUndoStopOptions {
+ 	undoStopBefore: boolean;
+ 	undoStopAfter: boolean;
++}
++
++export interface IApplyEditsOptions extends IUndoStopOptions {
+ 	setEndOfLine: EndOfLine;
+ }
+ 
++export interface IInsertSnippetOptions extends IUndoStopOptions {
++",![](https://cdn.meme.am/Instance/Preview?imageID=10051184&generatorTypeID=&panels=&text0=Machete&text1=don't%20do%20empty%20interface&text2=&text3=),2017-01-18 10:32:49
+717,"@@ -58,4 +67,27 @@ export class MainThreadMessageService extends MainThreadMessageServiceShape {
+ 			});
+ 		});
+ 	}
++
++	private showModalMessage(severity: Severity, message: string, commands: { title: string; isCloseAffordance: boolean; handle: number; }[]): Thenable<number> {
++		let closeAffordanceIndex = -1;",Just keep a `boolean`? I do not see `closeAffordanceIndex` being used for anything but that. Or is that an oversight?,2017-02-02 16:00:54
+474,"@@ -58,7 +68,7 @@ export interface IUntitledEditorService {
+ 	 * It is valid to pass in a file resource. In that case the path will be used as identifier.
+ 	 * The use case is to be able to create a new file with a specific path with VSCode.
+ 	 */
+-	createOrGet(resource?: URI, modeId?: string): UntitledEditorInput;
++	createOrGet(resource?: URI, modeId?: string, restoreResource?: URI): UntitledEditorInput;","@Tyriar maybe `restoreFromBackupResource` to make it clear this is about backups?
+",2016-11-09 07:44:16
+28,"@@ -583,6 +586,63 @@ export class OneCursorOp {
+ 		return true;
+ 	}
+ 
++	public static moveSubWordLeft(cursor:OneCursor, inSelectionMode: boolean, ctx: IOneCursorOperationContext): boolean {
++		let position = cursor.getPosition();
++		var lineNumber = position.lineNumber;","Use `const` as much as possible. If the value changes, like `positionFound` at L608, use `let`. Try to avoid `var`.
+
+Tough I noticed Microsoft isn't doing this everytime as well. But it's best practice :).
+",2015-12-11 13:11:48
+964,"@@ -586,6 +586,7 @@ export class CodeMenu {
+ 		const output = this.createMenuItem(nls.localize({ key: 'miToggleOutput', comment: ['&& denotes a mnemonic'] }, ""&&Output""), 'workbench.action.output.toggleOutput');
+ 		const debugConsole = this.createMenuItem(nls.localize({ key: 'miToggleDebugConsole', comment: ['&& denotes a mnemonic'] }, ""De&&bug Console""), 'workbench.debug.action.toggleRepl');
+ 		const integratedTerminal = this.createMenuItem(nls.localize({ key: 'miToggleIntegratedTerminal', comment: ['&& denotes a mnemonic'] }, ""&&Integrated Terminal""), 'workbench.action.terminal.toggleTerminal');
++		const taskMenu = this.createMenuItem(nls.localize({ key: 'miShowTask', comment: ['&& denotes a mnemonic'] }, ""&&Show Tasks...""), 'workbench.action.showTasks');","The && mnemonic is the letter that gets underlined on windows, then you can open the menu with alt+that letter. Looks like S is taken by Search, maybe use T",2017-06-12 21:22:52
+696,"@@ -588,6 +589,25 @@ export abstract class CommonCodeEditor extends EventEmitter implements editorCom
+ 			return;
+ 		}
+ 
++		if (handlerId === editorCommon.Handler.Paste) {
++			if (!this.cursor || typeof payload.text !== 'string' || payload.text.length === 0) {
++				// nothing to do
++				return;
++			}
++			const startPosition = this.cursor.getSelection().getStartPosition();
++			this.cursor.trigger(source, handlerId, payload);
++			const endPosition = this.cursor.getSelection().getStartPosition();
++			if (source === 'keyboard') {
++				this.emit(editorCommon.EventType.DidPaste, {",I would prefer for the editor to always give out rich objects (i.e. `Range` and not `IRange`). It does so for all non-serializable events.,2017-01-19 15:37:45
+780,"@@ -59,6 +59,31 @@ export class CloseEditorAction extends Action {
+ 	}
+ }
+ 
++export class ForceCloseEditorAction extends Action {",Suggest to move this into `editorActions.ts`,2017-03-01 05:15:11
+779,"@@ -59,6 +59,31 @@ export class CloseEditorAction extends Action {
+ 	}
+ }
+ 
++export class ForceCloseEditorAction extends Action {
++
++	public static ID = 'workbench.action.forceCloseActiveEditor';",Maybe better `workbench.action.revertAndCloseActiveEditor` ?,2017-03-01 05:14:33
+781,"@@ -59,6 +59,31 @@ export class CloseEditorAction extends Action {
+ 	}
+ }
+ 
++export class ForceCloseEditorAction extends Action {
++
++	public static ID = 'workbench.action.forceCloseActiveEditor';
++	public static LABEL = nls.localize('forceCloseActiveEditor', ""Force Close Editor"");",`Revert and Close Editor`,2017-03-01 05:15:28
+20,"@@ -59,7 +59,8 @@
+ 				"".xml"",
+ 				"".xpdl"",
+ 				"".xsd"",
+-				"".xul""","H
+H
+",2015-12-01 12:17:19
+238,"@@ -596,6 +596,14 @@ export class View extends ViewEventHandler implements editorBrowser.IView, IDisp
+ 		return viewModel.convertViewRangeToModelRange(currentCenteredViewRange);
+ 	}
+ 
++	public getVisibleRangeInViewport(): Range {
++		if (this._isDisposed) {
++			throw new Error('ViewImpl.getVisibleRangeInViewport: View is disposed');
++		}
++		let visibleRange= this.layoutProvider.getLinesViewportData().visibleRange;","spacing around `=`
+",2016-07-20 13:25:04
+181,"@@ -6,10 +6,12 @@
+ {
+ 	""label.closeButton"": ""关闭"",
+ 	""label.find"": ""查找"",
+-	""label.matchesLocation"": ""第 {0} 个(共 {1} 个)"",
++	""label.matchesLocation"": ""{0} / {1}"",
+ 	""label.nextMatchButton"": ""下一个匹配"",
+ 	""label.noResults"": ""无结果"",
+ 	""label.previousMatchButton"": ""上一个匹配"",
++	""label"".allMatchButton"": ""选中所有匹配"",","I think we don't modify locaization files ourselves, only touch the English version.
+",2016-06-12 04:12:09
+582,"@@ -6,10 +6,16 @@
+ 
+ import * as nls from 'vs/nls';
+ import { KeyCode, KeyMod, KeyChord } from 'vs/base/common/keyCodes';
++import { TPromise } from 'vs/base/common/winjs.base';
++import { isFalsyOrEmpty } from 'vs/base/common/arrays';
+ import { SortLinesCommand } from 'vs/editor/contrib/linesOperations/common/sortLinesCommand';
++import { getDocumentRangeFormattingEdits } from 'vs/editor/contrib/format/common/format';
++import { EditOperationsCommand } from 'vs/editor/contrib/format/common//formatCommand';",two slashes here -> vs/editor/contrib/format/common//formatCommand,2016-12-05 17:04:48
+567,"@@ -6,12 +6,17 @@
+ 'use strict';
+ 
+ import DOM = require('vs/base/browser/dom');
++import { onUnexpectedError } from 'vs/base/common/errors';
+ import { defaultGenerator } from 'vs/base/common/idGenerator';
+ import { escape } from 'vs/base/common/strings';
++import URI from 'vs/base/common/uri';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ import { IHTMLContentElement, MarkedString } from 'vs/base/common/htmlContent';
+ import { marked } from 'vs/base/common/marked/marked';
+ import { IMouseEvent } from 'vs/base/browser/mouseEvent';
++import { tokenizeToString } from 'vs/editor/common/modes/textToHtmlTokenizer';",layer breaker,2016-12-05 13:56:12
+568,"@@ -6,12 +6,17 @@
+ 'use strict';
+ 
+ import DOM = require('vs/base/browser/dom');
++import { onUnexpectedError } from 'vs/base/common/errors';
+ import { defaultGenerator } from 'vs/base/common/idGenerator';
+ import { escape } from 'vs/base/common/strings';
++import URI from 'vs/base/common/uri';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ import { IHTMLContentElement, MarkedString } from 'vs/base/common/htmlContent';
+ import { marked } from 'vs/base/common/marked/marked';
+ import { IMouseEvent } from 'vs/base/browser/mouseEvent';
++import { tokenizeToString } from 'vs/editor/common/modes/textToHtmlTokenizer';
++import { IModeService } from 'vs/editor/common/services/modeService';",same,2016-12-05 13:56:23
+569,"@@ -6,12 +6,17 @@
+ 'use strict';
+ 
+ import DOM = require('vs/base/browser/dom');
++import { onUnexpectedError } from 'vs/base/common/errors';
+ import { defaultGenerator } from 'vs/base/common/idGenerator';
+ import { escape } from 'vs/base/common/strings';
++import URI from 'vs/base/common/uri';
+ import { TPromise } from 'vs/base/common/winjs.base';
+ import { IHTMLContentElement, MarkedString } from 'vs/base/common/htmlContent';
+ import { marked } from 'vs/base/common/marked/marked';
+ import { IMouseEvent } from 'vs/base/browser/mouseEvent';
++import { tokenizeToString } from 'vs/editor/common/modes/textToHtmlTokenizer';
++import { IModeService } from 'vs/editor/common/services/modeService';
++import { IOpenerService } from 'vs/platform/opener/common/opener';",same,2016-12-05 13:56:32
+217,"@@ -6,40 +6,31 @@
+ .monaco-editor .margin-view-overlays .folding {
+ 	margin-left: 5px;
+ 	cursor: pointer;
+-}
+-
+-.monaco-editor .margin-view-overlays .folding::after {
+ 	background-repeat: no-repeat;","why are these changes part of this PR? Is the change in the editor core forcing these changes?
+",2016-07-14 09:39:57
+756,"@@ -6,6 +6,8 @@
+ .monaco-editor .zone-widget .zone-widget-container.breakpoint-widget {
+ 	height: 30px !important;
+ 	display: flex;",Try to put it in one rule together,2017-02-20 14:16:34
+65,"@@ -6,7 +6,7 @@
+ 	""contributes"": {
+ 		""languages"": [{
+ 			""id"": ""html"",
+-			""extensions"": [ "".html"", "".htm"", "".shtml"", "".mdoc"", "".jsp"", "".asp"", "".aspx"", "".jshtm"" ],
++			""extensions"": [ "".html"", "".htm"", "".shtml"", "".xhtml"", "".mdoc"", "".jsp"", "".asp"", "".aspx"", "".jshtm"" ],
+ 			""aliases"": [ ""HTML"", ""htm"", ""html"", ""xhtml"" ],
+ 			""mimetypes"": [""text/html"", ""text/x-jshtm"", ""text/template"", ""text/ng-template""]","Oh you should also probably add `application/xhtml+xml` to this list.
+",2016-02-29 22:56:59
+1,"@@ -6,7 +6,7 @@
+ 	""contributes"": {
+ 		""languages"": [{
+ 			""id"": ""powershell"",
+-			""extensions"": [ "".ps1"", "".psm1"", "".psd1"" ],
++			""extensions"": [  "".ps1"", "".psm1"", "".psd1"", "".pssc"", "".psrc"" ],","Remove the space before `"".ps1""`
+",2015-11-19 22:03:13
+916,"@@ -60,6 +60,26 @@ class CheckoutRemoteHeadItem extends CheckoutItem {
+ 	}
+ }
+ 
++class BranchDeleteItem implements QuickPickItem {
++
++	protected get shortCommit(): string { return (this.ref.commit || '').substr(0, 8); }
++	protected get treeish(): string | undefined { return this.ref.name; }
++	get label(): string { return this.ref.name || this.shortCommit; }
++	get description(): string { return this.shortCommit; }
++
++	constructor(protected ref: Ref) { }
++
++	async run(model: Model): Promise<void> {
++		const ref = this.treeish;
++
++		if (!ref) {
++			return;
++		}
++
++		await model.deleteBranch(ref);","A common error from this operation happens when the branch isn't yet merged:
+
+![image](https://cloud.githubusercontent.com/assets/22350/25742311/24ce0144-318f-11e7-96ea-81dfbf6f3d5d.png)
+
+It would be great if the underlying git library would catch this situation, wrap it neatly in a `GitError` with a new `GitErrorCode` and we `try catch` it here, prompting the user `Hey, the branch isn't yet merge. Do you still want to delete it?`.",2017-05-05 10:35:08
+311,"@@ -602,6 +605,18 @@ export class WindowsManager implements IWindowsService {
+ 			iPathsToOpen = this.cliToPaths(openConfig.cli, ignoreFileNotFound);
+ 		}
+ 
++		// Add any existing backup workspaces
++		if (openConfig.restoreBackups) {
++			// TODO: Ensure the workspaces being added actually have backups
++			this.backupService.getBackupWorkspaces().forEach(ws => {","What if a window is already opened with a workspace that has backup files, I think you need to avoid opening those again (since we prevent opening the same workspace twice we would just focus that window).
+",2016-10-13 15:00:12
+934,"@@ -61,11 +64,25 @@ function registerSettingsCompletions(): vscode.Disposable {
+ 	});
+ }
+ 
+-function newSimpleCompletionItem(text: string, range: vscode.Range, description?: string): vscode.CompletionItem {
++function registerExtensionsCompletions(): vscode.Disposable {
++	return vscode.languages.registerCompletionItemProvider({ pattern: '**/extensions.json' }, {
++		provideCompletionItems(document, position, token) {
++			const location = getLocation(document.getText(), document.offsetAt(position));
++			const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
++			if (location.path[0] === 'recommendations') {
++				return vscode.extensions.all",What do you suggest if there are no installed extensions?,2017-05-12 09:21:44
+935,"@@ -61,11 +64,25 @@ function registerSettingsCompletions(): vscode.Disposable {
+ 	});
+ }
+ 
+-function newSimpleCompletionItem(text: string, range: vscode.Range, description?: string): vscode.CompletionItem {
++function registerExtensionsCompletions(): vscode.Disposable {
++	return vscode.languages.registerCompletionItemProvider({ pattern: '**/extensions.json' }, {
++		provideCompletionItems(document, position, token) {
++			const location = getLocation(document.getText(), document.offsetAt(position));
++			const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
++			if (location.path[0] === 'recommendations') {
++				return vscode.extensions.all
++					.filter(e => !e.id.startsWith('vscode.'))","- You also need to exclude following extension which is packaged along with VS Code - `Microsoft.vscode-markdown`. This was getting shown in the intelli-sense.
+
+- Intelli-sense should not show already entered extensions. ",2017-05-15 14:46:39
+933,"@@ -61,11 +64,25 @@ function registerSettingsCompletions(): vscode.Disposable {
+ 	});
+ }
+ 
+-function newSimpleCompletionItem(text: string, range: vscode.Range, description?: string): vscode.CompletionItem {
++function registerExtensionsCompletions(): vscode.Disposable {
++	return vscode.languages.registerCompletionItemProvider({ pattern: '**/extensions.json' }, {
++		provideCompletionItems(document, position, token) {
++			const location = getLocation(document.getText(), document.offsetAt(position));
++			const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
++			if (location.path[0] === 'recommendations') {
++				return vscode.extensions.all
++					.filter(e => e.id.indexOf('vscode') === -1)",is this should ne `e.id.startsWith('vscode.')`?,2017-05-12 09:21:02
+937,"@@ -61,11 +64,32 @@ function registerSettingsCompletions(): vscode.Disposable {
+ 	});
+ }
+ 
+-function newSimpleCompletionItem(text: string, range: vscode.Range, description?: string): vscode.CompletionItem {
++function registerExtensionsCompletions(): vscode.Disposable {
++	return vscode.languages.registerCompletionItemProvider({ pattern: '**/extensions.json' }, {
++		provideCompletionItems(document, position, token) {
++			const location = getLocation(document.getText(), document.offsetAt(position));
++			const range = document.getWordRangeAtPosition(position) || new vscode.Range(position, position);
++			if (location.path[0] === 'recommendations') {
++				const config = vscode.workspace && vscode.workspace.getConfiguration('extensions.json');","I do not think`vscode.workspace.getConfiguration('extensions.json')` will get the extension recommendations. 
+You might have to read the document and parse it. You already have document with text, so you can just use parse from `jsonc-parser` to get the existing recommendations.",2017-05-16 16:29:05
+32,"@@ -61,28 +61,28 @@ export class ActivitybarPart extends Part implements IActivityService {
+ 	private registerListeners(): void {
+ 
+ 		// Activate viewlet action on opening of a viewlet
+-		this.toUnbind.push(this.eventService.addListener(EventType.VIEWLET_OPENING, (e: ViewletEvent) => this.onViewletOpening(e)));
++		this.toUnbind.push(this.eventService.addListener(EventType.VIEWLET_OPENING, (e: CompositeEvent) => this.onViewletOpening(e)));","@isidorn I think we can generalize this event to be COMPOSITE_OPENING and onCompositeOpening() because the listener seems to use the ID of the composite to do something and it also seems to be the only client through out the workbench.
+",2016-01-15 15:02:19
+968,"@@ -610,6 +610,9 @@ class TaskService extends EventEmitter implements ITaskService {
+ 
+ 	private registerCommands(): void {
+ 		CommandsRegistry.registerCommand('workbench.action.tasks.runTask', (accessor, arg) => {",If I run the build task with cmd+shift+b does this get called?,2017-06-12 21:48:02
+945,"@@ -62,10 +68,24 @@ export class StatusBarColorProvider extends Themable implements IWorkbenchContri
+ 			return STATUS_BAR_NO_FOLDER_BACKGROUND;
+ 		}
+ 
+-		// debugging
++		// Debugging
+ 		return STATUS_BAR_DEBUGGING_BACKGROUND;
+ 	}
+ 
++	private getForegroundColorKey(): string {","This looks almost identical to `getBackgroundColorKey`. Can we just have one method where all color keys are passed in? Something like `getColorKey(noFolderColor, debuggingColor, normalColor)`?",2017-05-22 04:50:06
+635,"@@ -62,6 +65,7 @@ export interface ITerminalConfigHelper {
+ 	getFont(): ITerminalFont;
+ 	getFontLigaturesEnabled(): boolean;
+ 	getCursorBlink(): boolean;
++	isRightClickCopyPaste(): boolean;",Change this to `get...` like `getCursorBlink`,2016-12-21 03:01:49
+236,"@@ -622,15 +632,55 @@ export class OneCursorOp {
+ 			validatedViewPosition = cursor.convertModelPositionToViewPosition(validatedPosition.lineNumber, validatedPosition.column);
+ 		}
+ 
++		return this.move(cursor, inSelectionMode, validatedViewPosition, eventSource, ctx);
++	}
++
++	public static move(cursor:OneCursor, inSelectionMode: boolean, to:editorCommon.IPosition | string, eventSource: string, ctx: IOneCursorOperationContext): boolean {","please move argument decoding to `cursor.ts` to do it only once even if there are 1000 cursors.
+
+Please also make it clear which one is cursorMove and which one is the old one. They are all called move now.
+",2016-07-15 11:26:08
+237,"@@ -622,15 +632,55 @@ export class OneCursorOp {
+ 			validatedViewPosition = cursor.convertModelPositionToViewPosition(validatedPosition.lineNumber, validatedPosition.column);
+ 		}
+ 
++		return this.move(cursor, inSelectionMode, validatedViewPosition, eventSource, ctx);
++	}
++
++	public static move(cursor:OneCursor, inSelectionMode: boolean, to:editorCommon.IPosition | string, eventSource: string, ctx: IOneCursorOperationContext): boolean {
++		if (!to) {
++			illegalArgument('to');
++		}
++
++		if (types.isString(to)) {
++			return this._move(cursor, inSelectionMode, to, ctx);
++		}
++
++		let viewPosition: editorCommon.IPosition= <editorCommon.IPosition>to;","space before equal pls
+",2016-07-15 11:26:18
+573,"@@ -622,6 +622,10 @@ export abstract class CommonCodeEditor extends EventEmitter implements editorCom
+ 		return this.model.deltaDecorations(oldDecorations, newDecorations, this.id);
+ 	}
+ ","Same as my previous comment. This PR should not touch anything in the editor land.
+
+As I commented earlier have you tried using editor.deltaDecoraitions which should automatically register a decoration. A nice use case of this api can be found [here](https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/debug/browser/debugEditorModelManager.ts#L97)",2016-12-05 14:49:47
+80,"@@ -624,11 +676,13 @@ export class Model extends ee.EventEmitter implements debug.IModel {
+ 
+ 	public sourceIsUnavailable(source: Source): void {
+ 		Object.keys(this.threads).forEach(key => {
+-			this.threads[key].callStack.forEach(stackFrame => {","For some reason I had missed updating this reference to `callStack`.
+
+Just pointing out what we have changed today that wasn't in yesterday's commit and you hadn't commented on.
+",2016-03-17 00:57:12
+255,"@@ -63,6 +66,8 @@ export class TerminalInstance {
+ 				event: 'input',
+ 				data: this.sanitizeInput(data)
+ 			});
++
++			console.log('this.terminalProcess.process.pid=' + this.terminalProcess.process.pid);","💥 
+",2016-08-18 19:36:22
+527,"@@ -63,9 +63,10 @@ export class TerminalPanel extends Panel {
+ 		this._terminalService.setContainers(this.getContainer().getHTMLElement(), this._terminalContainer);
+ 
+ 		this._register(this._themeService.onDidColorThemeChange(this._updateTheme.bind(this)));
+-		this._register(this._configurationService.onDidUpdateConfiguration(this._updateConfig.bind(this)));
++		this._register(this._configurationService.onDidUpdateConfiguration(this._updateFont.bind(this)));
++		this._updateFont();
+ 		this._updateTheme();
+-		this._updateConfig();
++		this._terminalService.updateConfig();",I think this can safely be removed.,2016-11-28 19:11:06
+372,"@@ -639,18 +639,26 @@ export class WindowsManager implements IWindowsService {
+ 			iPathsToOpen = this.cliToPaths(openConfig.cli, ignoreFileNotFound);
+ 		}
+ 
+-		// Add any existing backup workspaces
++		let configuration: IWindowConfiguration;
++		let openInNewWindow = openConfig.preferNewWindow || openConfig.forceNewWindow;
++
++		// Restore any existing backup workspaces
+ 		if (openConfig.restoreBackups) {
+-			this.backupService.getWorkspaceBackupPathsSync().forEach(ws => {
+-				iPathsToOpen.push(this.toIPath(ws));
+-			});
+-			// Get rid of duplicates
+-			iPathsToOpen = arrays.distinct(iPathsToOpen, path => {
+-				if (!('workspacePath' in path)) {
+-					return path.workspacePath;
+-				}
+-				return platform.isLinux ? path.workspacePath : path.workspacePath.toLowerCase();
++			const workspacesWithBackups = this.backupService.getWorkspaceBackupPathsSync();","As reported in a different issue that code should really move out of the `open()` method and only be used from the first startup code. Otherwise it makes it very hard to understand what this method is actually doing (it is already quite complex).
+",2016-10-21 13:57:17
+534,"@@ -64,6 +67,14 @@ export class BackupFilesModel implements IBackupFilesModel {
+ 		return true;
+ 	}
+ 
++	public getTextFiles(): string[] {","@Tyriar this is some crazy string magic that is not very robust, instead I suggest to use the `URI` apis we already have: use `URI.parse()` to convert the resource string into a `URI` and then you have access to `fsPath` and scheme to find out what you want.",2016-11-29 05:26:25
+645,"@@ -645,19 +645,40 @@ export class VSCodeWindow implements IVSCodeWindow {
+ 
+ 		this.win.setFullScreen(willBeFullScreen);
+ 
+-		// Windows & Linux: Hide the menu bar but still allow to bring it up by pressing the Alt key
+-		if (platform.isWindows || platform.isLinux) {
+-			if (willBeFullScreen) {
+-				this.setMenuBarVisibility(false);
+-			} else {
+-				this.setMenuBarVisibility(!this.storageService.getItem<boolean>(VSCodeWindow.menuBarHiddenKey, false)); // restore as configured
+-			}
+-		}
++		// respect configured menu bar visibility",@bpasero I changed the existing behavior here. Does this make sense for you?,2016-12-23 15:18:38
+254,"@@ -65,15 +65,15 @@ export interface ITerminalService {
+ 
+ 	close(): TPromise<any>;
+ 	copySelection(): TPromise<any>;
+-	createNew(): TPromise<any>;
+-	focus(): TPromise<any>;
++	createNew(name?: string): TPromise<number>;","As a recommendation I'd return the `ITerminalPanel` here and move `setActive`, `show`, `dispose` etc in it - the services seems to become quite large. 
+",2016-08-18 19:35:52
+405,"@@ -65,6 +97,30 @@ export class ActivitybarPart extends Part implements IActivityService {
+ 		}
+ 	}
+ 
++	getIsEnabledForRegisteredViewlets(): { [viewletId: string]: boolean } {","Add access modifier
+",2016-10-24 15:41:53
+406,"@@ -65,6 +97,30 @@ export class ActivitybarPart extends Part implements IActivityService {
+ 		}
+ 	}
+ 
++	getIsEnabledForRegisteredViewlets(): { [viewletId: string]: boolean } {
++		const result = {};
++		for (let viewletId in this.registeredViewlets) {
++			result[viewletId] = (this.enabledExternalViewlets.indexOf(viewletId) !== -1);
++		}
++		return result;
++	}
++
++	toggleViewlet(viewletId: string): void {","Add access modifier
+",2016-10-24 15:41:57
+915,"@@ -650,6 +650,11 @@ export class Repository {
+ 		await this.run(args);
+ 	}
+ 
++	async deleteBranch(name: string): Promise<void> {
++		const args = ['branch', '-d', name];",Maybe we should be explicit with the branch name and use its full form `refs/heads/${name}` instead of simply `name`.,2017-05-05 10:33:26
+994,"@@ -651,12 +651,16 @@ export class List<T> implements ISpliceable<T>, IDisposable {
+ 		if (options.ariaLabel) {
+ 			this.view.domNode.setAttribute('aria-label', options.ariaLabel);
+ 		}
++		this.view.domNode.setAttribute('aria-setsize', this.length.toString());","Just make this `0`, to be explicit.",2017-06-19 14:39:42
+995,"@@ -651,12 +651,16 @@ export class List<T> implements ISpliceable<T>, IDisposable {
+ 		if (options.ariaLabel) {
+ 			this.view.domNode.setAttribute('aria-label', options.ariaLabel);
+ 		}
++		this.view.domNode.setAttribute('aria-setsize', this.length.toString());
+ 
+ 		this.style(options);
+ 	}
+ 
+ 	splice(start: number, deleteCount: number, elements: T[] = []): void {
+-		this.eventBufferer.bufferEvents(() => this.spliceable.splice(start, deleteCount, elements));
++		this.eventBufferer.bufferEvents(() => {",Return this to the old syntax.,2017-06-19 14:39:57
+651,"@@ -652,19 +652,40 @@ export class VSCodeWindow implements IVSCodeWindow {
+ 
+ 		this.win.setFullScreen(willBeFullScreen);
+ 
+-		// Windows & Linux: Hide the menu bar but still allow to bring it up by pressing the Alt key
+-		if (platform.isWindows || platform.isLinux) {
+-			if (willBeFullScreen) {
+-				this.setMenuBarVisibility(false);
+-			} else {
+-				this.setMenuBarVisibility(!this.storageService.getItem<boolean>(VSCodeWindow.menuBarHiddenKey, false)); // restore as configured
+-			}
+-		}
++		// respect configured menu bar visibility
++		const windowConfig = this.configurationService.getConfiguration<IWindowSettings>('window');
++		this.setMenuBarVisibility(windowConfig && windowConfig.menuBarVisibility, false);
+ 	}
+ 
+-	public setMenuBarVisibility(visible: boolean): void {
+-		this.win.setMenuBarVisibility(visible);
+-		this.win.setAutoHideMenuBar(!visible);
++	public setMenuBarVisibility(visibility: '' | 'visible' | 'toggle' | 'hidden', notify: boolean = true): void {
++
++		switch (visibility) {
++			case ('visible'): {
++				this.win.setMenuBarVisibility(true);
++				this.win.setAutoHideMenuBar(false);
++				break;
++			}
++			case ('toggle'): {
++				this.win.setMenuBarVisibility(false);
++				this.win.setAutoHideMenuBar(true);
++
++				if (notify) {
++					this.send('vscode:showInfoMessage', nls.localize('hiddenMenuBar', ""You can still access the menu bar by pressing the **Alt** key.""));
++				};
++				break;
++			}
++			case ('hidden'): {
++				this.win.setMenuBarVisibility(false);
++				this.win.setAutoHideMenuBar(false);
++				break;
++			}
++			default: {",@xwvvvvwx can we merge this with the 'visible' case? that avoids code duplication here.,2017-01-04 10:54:12
+992,"@@ -656,7 +656,10 @@ export class List<T> implements ISpliceable<T>, IDisposable {
+ 	}
+ 
+ 	splice(start: number, deleteCount: number, elements: T[] = []): void {
+-		this.eventBufferer.bufferEvents(() => this.spliceable.splice(start, deleteCount, elements));
++		this.eventBufferer.bufferEvents(() => {
++			this.spliceable.splice(start, deleteCount, elements);
++			this.view.domNode.setAttribute('aria-setsize', this.length.toString());","You should do this outside the event buffering.
+
+Shouldn't there be an initial value for this, before any `splice` is called?",2017-06-19 14:28:57
+186,"@@ -658,6 +662,22 @@
+ 						</dict>
+ 					</array>
+ 				</dict>
++				<key>fenced_code_block_php</key>
++				<dict>
++					<key>begin</key>
++					<string>(^|\G)\s*([`~]{3,})\s*(php|php3|php4|php5|phpt|phtml|aw|ctp)\s*$</string>
++					<key>name</key>
++					<string>markup.fenced_code.block.markdown</string>
++					<key>end</key>
++					<string>(^|\G)(\2)\n</string>
++					<key>patterns</key>
++					<array>
++						<dict>
++							<key>include</key>
++							<string>text.html.php</string>","It's the same as the scopeName inside php syntax file, but currently the inline highlighting doesn't work. Will look into it later on.
+",2016-06-20 09:36:02
+823,"@@ -66,6 +66,10 @@ workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(Toggle
+ if (isWindows || isLinux) {
+ 	workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(ToggleMenuBarAction, ToggleMenuBarAction.ID, ToggleMenuBarAction.LABEL), 'View: Toggle Menu Bar', viewCategory);
+ }
++workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(NavigateUpAction, NavigateUpAction.ID, NavigateUpAction.LABEL, null), 'View: Move to the View Part above', viewCategory);","@misoguy please use capital casing here, e.g. `View: Move to the View Part Above`",2017-03-14 05:40:24
+808,"@@ -66,6 +66,10 @@ workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(Toggle
+ if (isWindows || isLinux) {
+ 	workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(ToggleMenuBarAction, ToggleMenuBarAction.ID, ToggleMenuBarAction.LABEL), 'View: Toggle Menu Bar', viewCategory);
+ }
++workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(NavigateUpAction, NavigateUpAction.ID, NavigateUpAction.LABEL, null), 'View: Navigate Up', viewCategory);","I wonder if the command name is verbose enough to understand the intent. Can we see how others (VIM?) name this command? Maybe ""Navigate to next View to the Left"" etc?",2017-03-10 05:45:35
+321,"@@ -66,6 +68,7 @@ export class DirtyFilesTracker implements IWorkbenchContribution {
+ 	}
+ 
+ 	private onUntitledDidChangeDirty(resource: URI): void {
++","I prefer to not add empty lines in the beginning of a method, please stick to the coding format used elsewhere in the files.
+",2016-10-13 15:13:17
+163,"@@ -67,11 +72,23 @@ const DEFAULT_ANSI_COLORS = {
+ 	]
+ };
+ 
++export interface ITerminalFont {
++	fontFamily: string;
++	fontSize: number;
++	lineHeight: number;
++	charWidth: number;
++	charHeight: number;
++}
++
+ /**
+  * Encapsulates terminal configuration logic, the primary purpose of this file is so that platform
+  * specific test cases can be written.
+  */
+ export class TerminalConfigHelper {
++	private characterMeasureElement: HTMLElement;","Name `charMeasureElement` for consistency
+",2016-06-02 06:46:40
+172,"@@ -67,34 +69,73 @@ const DEFAULT_ANSI_COLORS = {
+ 	]
+ };
+ 
++export interface ITerminalFont {
++	fontFamily: string;
++	fontSize: number;
++	lineHeight: number;
++	charWidth: number;
++	charHeight: number;
++}
++
+ /**
+  * Encapsulates terminal configuration logic, the primary purpose of this file is so that platform
+  * specific test cases can be written.
+  */
+ export class TerminalConfigHelper {
++	private charMeasureElement: HTMLElement;
++
+ 	public constructor(
+ 		private platform: Platform,
+ 		private configurationService: IConfigurationService,
+-		private themeService: IThemeService) {
++		private themeService: IThemeService,
++		private parentDomElement: HTMLElement) {
+ 	}
+ 
+ 	public getTheme(): string[] {
+ 		let baseThemeId = getBaseThemeId(this.themeService.getTheme());
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private neasureFont(fontFamily: string, fontSize: number, lineHeight: number): ITerminalFont {
++		if (!this.charMeasureElement) {
++			this.charMeasureElement = new Builder(this.parentDomElement, true).div().build().getHTMLElement();
++		}
++		let style = this.charMeasureElement.style;
++		style.display = 'inline';","Will this flicker the element on the screen? Should it be positioned absolutely off screen?
+",2016-06-02 20:19:31
+177,"@@ -67,34 +69,73 @@ const DEFAULT_ANSI_COLORS = {
+ 	]
+ };
+ 
++export interface ITerminalFont {
++	fontFamily: string;
++	fontSize: number;
++	lineHeight: number;
++	charWidth: number;
++	charHeight: number;
++}
++
+ /**
+  * Encapsulates terminal configuration logic, the primary purpose of this file is so that platform
+  * specific test cases can be written.
+  */
+ export class TerminalConfigHelper {
++	private charMeasureElement: HTMLElement;
++
+ 	public constructor(
+ 		private platform: Platform,
+ 		private configurationService: IConfigurationService,
+-		private themeService: IThemeService) {
++		private themeService: IThemeService,
++		private parentDomElement: HTMLElement) {
+ 	}
+ 
+ 	public getTheme(): string[] {
+ 		let baseThemeId = getBaseThemeId(this.themeService.getTheme());
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private neasureFont(fontFamily: string, fontSize: number, lineHeight: number): ITerminalFont {
++		if (!this.charMeasureElement) {
++			this.charMeasureElement = new Builder(this.parentDomElement, true).div().build().getHTMLElement();
++		}
++		let style = this.charMeasureElement.style;
++		style.display = 'inline';
++		style.fontFamily = fontFamily;
++		style.fontSize = fontSize + 'px';
++		style.lineHeight = lineHeight + 'px';
++		this.charMeasureElement.innerText = 'X';
++		let rect = this.charMeasureElement.getBoundingClientRect();
++		style.display = 'none';
++		let charWidth = Math.ceil(rect.width);
++		let charHeight = Math.ceil(rect.height);
++		return {
++			fontFamily,
++			fontSize,
++			lineHeight,
++			charWidth,
++			charHeight
++		};
++	}
++
+ 	/**
+-	 * Set the terminal font to `terminal.integrated.fontFamily` if it is set, otherwise fallback to
+-	 * `editor.fontFamily`.
++	 * Gets the font information based on the terminal.integrated.fontFamily,
++	 * terminal.integrated.fontSize, terminal.integrated.lineHeight configuration properties
+ 	 */
+-	public getFontFamily(): string {
+-		let terminalConfig = this.configurationService.getConfiguration<ITerminalConfiguration>();
+-		let fontFamily = terminalConfig.terminal.integrated.fontFamily;
+-		if (!fontFamily) {
+-			let editorConfig = this.configurationService.getConfiguration<IConfiguration>();
+-			fontFamily = editorConfig.editor.fontFamily;
++	public getFont(): ITerminalFont {
++		let terminalConfig = this.configurationService.getConfiguration<ITerminalConfiguration>().terminal.integrated;
++		let editorConfig = this.configurationService.getConfiguration<IConfiguration>();
++
++		let fontFamily = terminalConfig.fontFamily || editorConfig.editor.fontFamily;
++		let fontSize = this.toInteger(terminalConfig.fontSize, 0) || editorConfig.editor.fontSize;
++		let lineHeight = this.toInteger(terminalConfig.lineHeight, 0) || editorConfig.editor.lineHeight;
++
++		if (lineHeight === 0) {
++			lineHeight = Math.round(GOLDEN_LINE_HEIGHT_RATIO * fontSize);","We basically want consistency with how editor.lineHeight works here, is this how that falls back?
+",2016-06-02 20:36:11
+592,"@@ -67,4 +67,118 @@ suite('Editor Contrib - Line Operations', () => {
+ 				assert.equal(model.getLineContent(5), 'horlworld', '005');
+ 			});
+ 	});
++
++	test('Join lines', function () {
++		withMockCodeEditor(
++			[
++				'hello',
++				'world',
++				'hello ',
++				'world',
++				'hello		',
++				'	world',
++				'hello   ',
++				'	world',
++				'',
++				'',
++				'hello world'
++			], {}, (editor, cursor) => {
++				let model = editor.getModel();
++				let joinLinesAction = new JoinLinesAction();
++
++				editor.setSelection(new Selection(1, 2, 1, 2));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(1), 'hello world', '001');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(1, 6, 1, 6).toString(), '002');
++
++				editor.setSelection(new Selection(2, 2, 2, 2));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(2), 'hello world', '003');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(2, 7, 2, 7).toString(), '004');
++
++				editor.setSelection(new Selection(3, 2, 3, 2));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(3), 'hello world', '005');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(3, 7, 3, 7).toString(), '006');
++
++				editor.setSelection(new Selection(4, 2, 5, 3));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(4), 'hello world', '007');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(4, 2, 4, 8).toString(), '008');
++
++				editor.setSelection(new Selection(5, 1, 7, 3));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(5), 'hello world', '009');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(5, 1, 5, 3).toString(), '010');
++			});
++	});
++
++	test('transpose', function () {","does it work for empty lines, or on empty files?
+
+You can use scripts\test.bat --coverage and my awesome LCOV plugin to see your code coverage ;)",2016-12-05 17:33:49
+591,"@@ -67,4 +67,118 @@ suite('Editor Contrib - Line Operations', () => {
+ 				assert.equal(model.getLineContent(5), 'horlworld', '005');
+ 			});
+ 	});
++
++	test('Join lines', function () {
++		withMockCodeEditor(
++			[
++				'hello',
++				'world',
++				'hello ',
++				'world',
++				'hello		',
++				'	world',
++				'hello   ',
++				'	world',
++				'',
++				'',
++				'hello world'
++			], {}, (editor, cursor) => {
++				let model = editor.getModel();
++				let joinLinesAction = new JoinLinesAction();
++
++				editor.setSelection(new Selection(1, 2, 1, 2));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(1), 'hello world', '001');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(1, 6, 1, 6).toString(), '002');
++
++				editor.setSelection(new Selection(2, 2, 2, 2));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(2), 'hello world', '003');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(2, 7, 2, 7).toString(), '004');
++
++				editor.setSelection(new Selection(3, 2, 3, 2));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(3), 'hello world', '005');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(3, 7, 3, 7).toString(), '006');
++
++				editor.setSelection(new Selection(4, 2, 5, 3));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(4), 'hello world', '007');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(4, 2, 4, 8).toString(), '008');
++
++				editor.setSelection(new Selection(5, 1, 7, 3));
++				joinLinesAction.run(null, editor);
++				assert.equal(model.getLineContent(5), 'hello world', '009');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(5, 1, 5, 3).toString(), '010');
++			});
++	});
++
++	test('transpose', function () {
++		withMockCodeEditor(
++			[
++				'hello world'
++			], {}, (editor, cursor) => {
++				let model = editor.getModel();
++				let transposeAction = new TransposeAction();
++
++				editor.setSelection(new Selection(1, 1, 1, 1));
++				transposeAction.run(null, editor);
++				assert.equal(model.getLineContent(1), 'hello world', '001');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(1, 2, 1, 2).toString(), '002');
++
++				editor.setSelection(new Selection(1, 6, 1, 6));
++				transposeAction.run(null, editor);
++				assert.equal(model.getLineContent(1), 'hell oworld', '003');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(1, 7, 1, 7).toString(), '004');
++
++				editor.setSelection(new Selection(1, 12, 1, 12));
++				transposeAction.run(null, editor);
++				assert.equal(model.getLineContent(1), 'hell oworld', '005');
++				assert.deepEqual(editor.getSelection().toString(), new Selection(1, 12, 1, 12).toString(), '006');
++			}
++		);
++	});
++
++	test('toggle case', function () {","add more tests, e.g. for empty lines or for the cursor in the middle of whitespace.",2016-12-05 17:32:39
+921,"@@ -67,6 +70,12 @@ export class TextFileEditor extends BaseTextEditor {
+ 		}
+ 	}
+ 
++	private onWillCloseEditor(e: IEditorIdentifier): void {
++		if (e.editor === this.input && this.position === this.editorGroupService.getStacksModel().positionOfGroup(e.group)) {","It is fine to do the equality check here between editors here? They are actually the same reference?
+I understand you do not have an `id` for the editors here.
+
+You also treat the input as FileEditorInput later on so I guess you could check their resource uri as comparison?",2017-05-10 08:23:13
+630,"@@ -67,7 +67,7 @@ export class PackageJSONContribution implements IJSONContribution {
+ 										let name = keys[0];
+ 										let insertText = new SnippetString().appendText(JSON.stringify(name));
+ 										if (addValue) {
+-											insertText.appendText(': ').appendPlaceholder('*');
++											insertText.appendText(': ""').appendPlaceholder('').appendText('""');
+ 											if (!isLast) {","should be `""*""`, not just `""""`",2016-12-20 08:32:22
+872,"@@ -670,7 +669,7 @@ export class ActionBar extends EventEmitter implements IActionRunner {
+ 
+ 	public dispose(): void {
+ 		if (this.items !== null) {
+-			lifecycle.dispose(this.items);
++			this.clear();","Can we not do this for stable, but only on insiders? Seems like an additional change on top that is not needed to fix the actual issue.",2017-04-04 15:23:32
+914,"@@ -671,6 +677,29 @@ export class CommandCenter {
+ 		await this.model.branch(name);
+ 	}
+ 
++	@command('git.merge')
++	async merge(): Promise<void> {
++		const config = workspace.getConfiguration('git');
++		const checkoutType = config.get<string>('checkoutType') || 'all';
++		const includeRemotes = checkoutType === 'all' || checkoutType === 'remote';
++
++		const heads = this.model.refs.filter(ref => ref.type === RefType.Head)
++			.map(ref => new CheckoutItem(ref));
++
++		const remoteHeads = (includeRemotes ? this.model.refs.filter(ref => ref.type === RefType.RemoteHead) : [])
++			.map(ref => new CheckoutRemoteHeadItem(ref));
++
++		const picks = [...heads, ...remoteHeads];
++		const placeHolder = 'Select a ref to checkout';","Where's the `localize` call? Remember, Code needs to be localized for other languages. Also, the sentence is wrong. It should be something like `Select a branch to merge from`",2017-05-05 10:15:42
+494,"@@ -68,7 +68,7 @@ export interface IUntitledEditorService {
+ 	 * It is valid to pass in a file resource. In that case the path will be used as identifier.
+ 	 * The use case is to be able to create a new file with a specific path with VSCode.
+ 	 */
+-	createOrGet(resource?: URI, modeId?: string, restoreResource?: URI): UntitledEditorInput;
++	createOrGet(resource?: URI, modeId?: string, hasBackupToRestore?: boolean): UntitledEditorInput;","@Tyriar `hasBackupToRestore` is not being used after all?
+",2016-11-16 14:30:34
+878,"@@ -699,6 +699,26 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * Represents options to configure the behavior of showing a [document](#TextDocument) in an [editor](#TextEditor).
++	 */
++	export interface ShowTextDocumentOptions {","@jrieken I don't love this name, let me know what you think",2017-04-13 18:53:00
+900,"@@ -699,6 +699,26 @@ declare module 'vscode' {
+ 	}
+ 
+ 	/**
++	 * Represents options to configure the behavior of showing a [document](#TextDocument) in an [editor](#TextEditor).
++	 */
++	export interface TextDocumentShowOptions {
++		/**
++		 * An optional view column in which the [editor](#TextEditor) should be shown. The default is the [one](#ViewColumn.One), other values are adjusted to be __Min(column, columnCount + 1)__.
++		 */
++		column ?: ViewColumn,",Wow - your commit should have been blocked because that's a formatting issue...,2017-04-25 13:56:23
+954,"@@ -7,11 +7,13 @@ import * as interfaces from './interfaces';
+ import { DocumentMergeConflict } from './documentMergeConflict';
+ 
+ const startHeaderMarker = '<<<<<<< ';
++const commonAncestorsMarker = '||||||| ';
+ const splitterMarker = '=======';
+ const endFooterMarker = '>>>>>>> ';
+ 
+ interface IScanMergedConflict {
+ 	startHeader: vscode.TextLine;
++	commonAncestors: vscode.TextLine | null;",Nit; might as well mark `commonAncestors` as optional e.g. `commonAncestors?`,2017-05-30 15:42:22
+911,"@@ -7,13 +7,10 @@ import * as nls from 'vs/nls';
+ import { TPromise } from 'vs/base/common/winjs.base';","Looks good overall and I like we removed code from this class.
+
+I only have the issue that you are creating a `linkDetector` at every iteration in a loop. Would it not make sense just to create one global one for the replViewer and always to reuse it?",2017-05-05 09:46:06
+330,"@@ -7,13 +7,19 @@
+ 	transform: rotate(180deg);
+ }
+ 
+-.monaco-workbench > .part.activitybar {
++.monaco-workbench > .part.activitybar, .monaco-workbench.mac.fullscreen.use-inline-toolbar > .part.activitybar {","I do not understand why this rule is duplicated here?
+",2016-10-15 06:17:22
+785,"@@ -7,28 +7,20 @@
+ 
+ const fs = require('fs');
+ const path = require('path');
++const toDelete = new Set(['tsc.js', 'tsserverlibrary.js', 'typescript.js', 'typescriptServices.js']);
+ 
+-function removeFile(filePath) {
+-	try {
+-		fs.unlinkSync(filePath);
+-		console.log(`removed '${filePath}'`);
+-	} catch (e) {
+-		console.warn(e);
++const root = path.join(__dirname, 'node_modules', 'typescript', 'lib');
++for (let name of fs.readdirSync(root)) {
++	if (name === 'lib.d.ts' || name.match(/^lib\..*\.d\.ts$/) || name === 'protocol.d.ts') {
++		continue;
+ 	}",Should we just use glob patterns to avoid the mix of `toDelete` and or-conditions?,2017-03-01 09:23:27
+74,"@@ -7,6 +7,11 @@ import assert = require('assert');
+ import uri from 'vs/base/common/uri';","Really happy for the tests.
+",2016-03-16 10:25:45
+7,"@@ -7,6 +7,7 @@
+ 		<string>ps1</string>
+ 		<string>psm1</string>
+ 		<string>psd1</string>
++		<string>ps1xml</string>","Same here, `/extensions/powershell/package.json` contains the file extensions
+",2015-11-21 19:07:45
+951,"@@ -7,6 +7,7 @@
+   ""license"": ""MIT"",
+   ""publisher"": ""vscode"",
+   ""aiKey"": ""AIF-d9b70cd4-b9f9-4d70-929b-a071c400b217"",
++  ""enableProposedApi"": true,",No need to use proposed API here anymore. I moved the API to vscode.d.ts ,2017-05-23 19:14:38
+654,"@@ -7,6 +7,7 @@
+ import { isLinux, isWindows } from 'vs/base/common/platform';
+ import { fill } from 'vs/base/common/arrays';
+ import { CharCode } from 'vs/base/common/charCode';
++import { endsWith } from 'vs/base/common/strings';","Overall, can you please use `const` and `let` instead of `var` for variables?",2017-01-09 09:10:27
+6,"@@ -7,6 +7,9 @@
+ 		<string>clj</string>
+ 		<string>cljs</string>
+ 		<string>clojure</string>
++		<string>cljc</string>
++		<string>cljx</string>
++		<string>edn</string>","If you want to add file extensions for clojure, you have to do that `/extensions/clojure/package.json`. From `/extensions/clojure/syntaxes/Clojure.tmLanguage` we only take the colorizer information.
+",2015-11-21 19:07:06
+430,"@@ -70,4 +70,24 @@ export interface IActivityService {
+ 	 * Clears activity shown in the activitybar for the given viewlet or panel.
+ 	 */
+ 	clearActivity(compositeId: string): void;
+-}
+\ No newline at end of file
++
++	/**
++	 * Get registered external viewlets' info for populating 'Toggle Custom Explorer' command picks.
++	 */
++	getInfoForRegisteredViewlets(): {
++		[viewletId: string]: {
++			isEnabled: boolean;
++			treeLabel: string;
++		}
++	};
++
++	/**
++	 * Enable/disable an external viewlet.
++	 */
++	toggleViewlet(viewletId: string): void;
++
++	/**
++	 * Get the external viewlet id that is about to open.
++	 */
++	getExternalViewletIdToOpen(): string;
++}","[needs thinking] @bpasero will know better, but I have a strong feeling that the `IActivityService` isn't the right place for viewlet specifics. Isn't there an `IViewletService` and wouldn't that be the better place for this?
+",2016-11-01 10:05:06
+447,"@@ -70,4 +71,19 @@ export interface IActivityService {
+ 	 * Clears activity shown in the activitybar for the given viewlet or panel.
+ 	 */
+ 	clearActivity(compositeId: string): void;
+-}
+\ No newline at end of file
++","@octref this Viewlet related code should move into `IViewletService` or if that is impossible for some reason maybe into a new `IExtensionViewletService`
+",2016-11-03 08:38:55
+919,"@@ -703,6 +703,7 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 	private _onEditorDirty: Emitter<EditorIdentifier>;
+ 	private _onEditorLabelChange: Emitter<EditorIdentifier>;
+ 	private _onEditorOpened: Emitter<EditorIdentifier>;
++	private _onWillCloseEditor: Emitter<EditorIdentifier>;
+ 	private _onEditorClosed: Emitter<GroupEvent>;
+ 	private _onModelChanged: Emitter<IStacksModelChangeEvent>;","Why does `onWillCloseEditor` emit a different event than `onEditorClosed`?
+Intuitivly they should emit the same and it makes sense to me that is the `EditorIdentififer`",2017-05-10 08:19:47
+301,"@@ -709,6 +718,17 @@ export class Workbench implements IPartService {
+ 		// Create Workbench DIV Off-DOM
+ 		this.workbenchContainer = $('.monaco-workbench-container');
+ 		this.workbench = $().div({ 'class': 'monaco-workbench ' + (isWindows ? 'windows' : isLinux ? 'linux' : 'mac'), id: Identifiers.WORKBENCH_CONTAINER }).appendTo(this.workbenchContainer);
++
++		// Only needed while the option `windowConfig.macOSUseInlineToolbar` exists
++		if (isMacintosh) {","Please move all of this code into `renderWorkbench` where we already adjust some CSS classes based on things like sidebar visible or not. It is also much easier to get hold of the IConfigurationService by adding the following to the constructor of the workbench:
+
+`@IConfigurationService private configurationService: IConfigurationService`
+
+All the other code is not needed then. 
+
+To find out if the setting is set, I suggest this code:
+
+`this.configurationService.lookup('window.macOSUseInlineToolbar').value`
+",2016-10-05 06:53:48
+437,"@@ -709,7 +709,18 @@ export class WindowsManager implements IWindowsService {
+ 		}
+ 
+ 		// Handle folders to open
+-		let openInNewWindow = openConfig.preferNewWindow || openConfig.forceNewWindow;
++		let openInNewWindow: boolean;","@elemongw sorry, but this does not work for me when I try it. The folder opens in the same window no matter how I configure the setting. I believe you need to turn the logic around: set `openInNewWindow` to true when the setting is enabled!
+",2016-11-03 07:31:33
+993,"@@ -712,6 +715,7 @@ export class List<T> implements ISpliceable<T>, IDisposable {
+ 	setFocus(indexes: number[]): void {
+ 		indexes = indexes.sort(numericSort);
+ 		this.focus.set(indexes);
++		this.view.domNode.setAttribute('aria-posinset', indexes.length ? (indexes[0] + 1).toString() : undefined);","The [w3 docs](https://www.w3.org/TR/wai-aria/states_and_properties#aria-posinset) state:
+
+> Authors MUST set the value for aria-posinset to an integer greater than or equal to 1, and less than or equal to the size of the set.
+
+Setting it to `undefined` doesn't sound like it's the right thing to do here.",2017-06-19 14:30:41
+637,"@@ -72,6 +72,11 @@ configurationRegistry.registerConfiguration({
+ 			},
+ 			'default': []
+ 		},
++		'terminal.integrated.rightClickCopyPaste': {
++			'description': nls.localize('terminal.integrated.rightClickCopyPaste', ""Controls whether copy/paste happens on mouse right click in integrated terminal.""),","I think the description needs to be more detailed, how about this?
+
+> When set, this will prevent the context menu from appearing on right clicking in the terminal, instead it will copy when there is a selection and paste when there is no selection.",2016-12-21 03:07:43
+623,"@@ -72,6 +84,12 @@ configurationRegistry.registerConfiguration({
+ 			},
+ 			'default': []
+ 		},
++		'terminal.integrated.rightClickAction.windows': {","I'm thinking instead of having 3 settings for each platform and using strings, instead having a single setting for all platforms that just turns on rightClickCopy/Paste. Maybe `terminal.integrated.rightClickCopyPaste`? Then the default could be true when `platform.isWindows` (put the default in terminal.ts and import it into this file).",2016-12-19 05:33:46
+539,"@@ -72,8 +72,8 @@ export default class LinkedMap<T> {
+ 		return item.value;
+ 	}
+ 
+-	public shift(): T {
+-		if (!this.head && !this.tail) {
++	public shift(): T | undefined {",The idea why I used && here is that only having one being undefined / null basically points to a programming error somewhere else and the code should fail later on. Now that error might be covered up. I think if we go with a || here then we should add additional asserts.,2016-11-30 09:15:49
+551,"@@ -729,9 +744,16 @@ export class WindowsManager implements IWindowsMainService {
+ 				state: this.getNewWindowState(configuration),
+ 				extensionDevelopmentPath: configuration.extensionDevelopmentPath,
+ 				allowFullscreen: this.lifecycleService.wasUpdated || (windowConfig && windowConfig.restoreFullscreen),
+-				titleBarStyle: windowConfig ? windowConfig.titleBarStyle : void 0
++				titleBarStyle: windowConfig ? windowConfig.titleBarStyle : void 0,
++				vscodeWindowId: configuration.vscodeWindowId
+ 			});
+ 
++			configuration.vscodeWindowId = vscodeWindow.vscodeWindowId;
++			if (!configuration.extensionDevelopmentPath) {
++				// TODO: Cover closing a folder/existing window case
++				this.backupService.pushEmptyWorkspaceBackupWindowIdSync(configuration.vscodeWindowId);",@Tyriar I suggest to move this up to the place where we already call `pushWorkspaceBackupPathsSync` so that we have it in one place. doing this from `toConfiguration` is very weird. As a caller of this method I would expect to get a configuration object but as a side effect I am writing to the backup folder??,2016-12-01 16:25:57
+289,"@@ -73,7 +73,7 @@
+ 		""menus"": {
+ 			""editor/title"": [
+ 				{
+-					""when"": ""resourceLangId == markdown"",
++					""when"": ""editorLangId == markdown"",","I could also change this to be `resourceLangId == markdown || editorLangId == markdown`, but only showing the preview menu item for files that are viewed as markdown makes more sense  to me
+",2016-09-22 18:14:49
+312,"@@ -730,6 +745,12 @@ export class WindowsManager implements IWindowsService {
+ 		// Emit events
+ 		iPathsToOpen.forEach(iPath => this.eventEmitter.emit(EventTypes.OPEN, iPath));
+ 
++		// Add to backups","Why are we adding these workspaces again to backup service?
+",2016-10-13 15:01:36
+336,"@@ -736,6 +736,16 @@ export class Workbench implements IPartService {
+ 		// Create Workbench DIV Off-DOM
+ 		this.workbenchContainer = $('.monaco-workbench-container');
+ 		this.workbench = $().div({ 'class': 'monaco-workbench ' + (isWindows ? 'windows' : isLinux ? 'linux' : 'mac'), id: Identifiers.WORKBENCH_CONTAINER }).appendTo(this.workbenchContainer);
++
++
++		// Mac specific UI changes
++		if (isMacintosh) {
++			const {serviceCollection} = this.workbenchParams;","Unused serviceCollection?
+",2016-10-15 06:21:59
+337,"@@ -736,6 +736,16 @@ export class Workbench implements IPartService {
+ 		// Create Workbench DIV Off-DOM
+ 		this.workbenchContainer = $('.monaco-workbench-container');
+ 		this.workbench = $().div({ 'class': 'monaco-workbench ' + (isWindows ? 'windows' : isLinux ? 'linux' : 'mac'), id: Identifiers.WORKBENCH_CONTAINER }).appendTo(this.workbenchContainer);
++
++
++		// Mac specific UI changes
++		if (isMacintosh) {
++			const {serviceCollection} = this.workbenchParams;
++			const windowConfig = this.configurationService.getConfiguration<any>('window');","Instead of any, you should add the setting to https://github.com/Microsoft/vscode/blob/mac-titlebar-inline/src/vs/workbench/electron-browser/common.ts#L24 and use `IWindowConfiguration` properly.
+",2016-10-15 06:22:42
+338,"@@ -736,6 +736,16 @@ export class Workbench implements IPartService {
+ 		// Create Workbench DIV Off-DOM
+ 		this.workbenchContainer = $('.monaco-workbench-container');
+ 		this.workbench = $().div({ 'class': 'monaco-workbench ' + (isWindows ? 'windows' : isLinux ? 'linux' : 'mac'), id: Identifiers.WORKBENCH_CONTAINER }).appendTo(this.workbenchContainer);
++
++
++		// Mac specific UI changes
++		if (isMacintosh) {
++			const {serviceCollection} = this.workbenchParams;
++			const windowConfig = this.configurationService.getConfiguration<any>('window');
++			if (windowConfig.macOSUseInlineToolbar) {","`windowConfig` can be null if the user has a weird config
+",2016-10-15 06:23:06
+299,"@@ -74,6 +74,11 @@ import {IEnvironmentService} from 'vs/platform/environment/common/environment';
+ import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
+ import * as watermark from 'vs/workbench/parts/watermark/watermark';
+ 
++// These three are used for the macOS inline toolbars option, and can be removed once default
++import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
++import { ConfigurationService } from 'vs/platform/configuration/node/configurationService';","Can you make sure the formatting of imports matches the other imports? also I suggest to remove the comment for now, we will likely not make this default soon nor get rid of the setting if people don't like it. We still have to figure out how to run this experiment, maybe settings is not the best in the end.
+",2016-10-05 06:51:28
+298,"@@ -74,6 +74,11 @@ import {IEnvironmentService} from 'vs/platform/environment/common/environment';
+ import {ITelemetryService} from 'vs/platform/telemetry/common/telemetry';
+ import * as watermark from 'vs/workbench/parts/watermark/watermark';
+ 
++// These three are used for the macOS inline toolbars option, and can be removed once default
++import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
++import { ConfigurationService } from 'vs/platform/configuration/node/configurationService';
++import { IWindowSettings } from 'vs/code/electron-main/window';","this is a layer break: we cannot depend from a VSCode window into the main process, please see https://github.com/Microsoft/vscode/wiki/Code-Organization
+",2016-10-05 06:50:44
+682,"@@ -75,6 +75,10 @@ export const debuggersExtPoint = extensionsRegistry.ExtensionsRegistry.registerE
+ 				description: nls.localize('vscode.extension.contributes.debuggers.languages', ""List of languages for which the debug extension could be considered the \""default debugger\"".""),
+ 				type: 'array'
+ 			},
++			adapterExecutableCommand: {",argumnts is missing an E argumEnts,2017-01-18 14:02:37
+219,"@@ -76,6 +86,8 @@ export class OpenAnythingHandler extends QuickOpenHandler {
+ 	}
+ 
+ 	public getResults(searchValue: string): TPromise<QuickOpenModel> {
++		const timerEvent = this.telemetryService.timedPublicLog('openAnything');
++		const startTime = timerEvent.startTime ? timerEvent.startTime.getTime() : Date.now();","I find the check weird here, why would startTime be undefined if you got timerEvent from the timedPublicLog method?
+",2016-07-14 17:33:48
+888,"@@ -76,8 +109,8 @@ export class TerminalLinkHandler {
+ 			this._handleLocalLink(url);
+ 			return;
+ 		});
++
+ 		return this._xterm.registerLinkMatcher(this._localLinkRegex, wrappedHandler, {
+-			matchIndex: 1,",Don't we need this?,2017-04-17 17:44:34
+892,"@@ -76,83 +76,96 @@ workbenchActionsRegistry.registerWorkbenchAction(new SyncActionDescriptor(Decrea
+ 
+ // Configuration: Workbench
+ const configurationRegistry = Registry.as<IConfigurationRegistry>(ConfigurationExtensions.Configuration);
++
++let workbenchProperties: { [path: string]: IJSONSchema; } = {
++	'workbench.editor.showTabs': {
++		'type': 'boolean',
++		'description': nls.localize('showEditorTabs', ""Controls if opened editors should show in tabs or not.""),
++		'default': true
++	},
++	'workbench.editor.tabCloseButton': {
++		'type': 'string',
++		'enum': ['left', 'right', 'off'],
++		'default': 'right',
++		'description': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'editorTabCloseButton' }, ""Controls the position of the editor's tabs close buttons or disables them when set to 'off'."")
++	},
++	'workbench.editor.showIcons': {
++		'type': 'boolean',
++		'description': nls.localize('showIcons', ""Controls if opened editors should show with an icon or not. This requires an icon theme to be enabled as well.""),
++		'default': true
++	},
++	'workbench.editor.enablePreview': {
++		'type': 'boolean',
++		'description': nls.localize('enablePreview', ""Controls if opened editors show as preview. Preview editors are reused until they are kept (e.g. via double click or editing).""),
++		'default': true
++	},
++	'workbench.editor.enablePreviewFromQuickOpen': {
++		'type': 'boolean',
++		'description': nls.localize('enablePreviewFromQuickOpen', ""Controls if opened editors from Quick Open show as preview. Preview editors are reused until they are kept (e.g. via double click or editing).""),
++		'default': true
++	},
++	'workbench.editor.openPositioning': {
++		'type': 'string',
++		'enum': ['left', 'right', 'first', 'last'],
++		'default': 'right',
++		'description': nls.localize({ comment: ['This is the description for a setting. Values surrounded by single quotes are not to be translated.'], key: 'editorOpenPositioning' }, ""Controls where editors open. Select 'left' or 'right' to open editors to the left or right of the current active one. Select 'first' or 'last' to open editors independently from the currently active one."")
++	},
++	'workbench.editor.revealIfOpen': {
++		'type': 'boolean',
++		'description': nls.localize('revealIfOpen', ""Controls if an editor is revealed in any of the visible groups if opened. If disabled, an editor will prefer to open in the currently active editor group. If enabled, an already opened editor will be revealed instead of opened again in the currently active editor group. Note that there are some cases where this setting is ignored, e.g. when forcing an editor to open in a specific group or to the side of the currently active group.""),
++		'default': false
++	},
++	'workbench.quickOpen.closeOnFocusLost': {
++		'type': 'boolean',
++		'description': nls.localize('closeOnFocusLost', ""Controls if Quick Open should close automatically once it loses focus.""),
++		'default': true
++	},
++	'workbench.settings.openDefaultSettings': {
++		'type': 'boolean',
++		'description': nls.localize('openDefaultSettings', ""Controls if opening settings also opens an editor showing all default settings.""),
++		'default': true
++	},
++	'workbench.sideBar.location': {
++		'type': 'string',
++		'enum': ['left', 'right'],
++		'default': 'left',
++		'description': nls.localize('sideBarLocation', ""Controls the location of the sidebar. It can either show on the left or right of the workbench."")
++	},
++	'workbench.statusBar.visible': {
++		'type': 'boolean',
++		'default': true,
++		'description': nls.localize('statusBarVisibility', ""Controls the visibility of the status bar at the bottom of the workbench."")
++	},
++	'workbench.activityBar.visible': {
++		'type': 'boolean',
++		'default': true,
++		'description': nls.localize('activityBarVisibility', ""Controls the visibility of the activity bar in the workbench."")
++	},
++	'workbench.editor.closeOnFileDelete': {
++		'type': 'boolean',
++		'description': nls.localize('closeOnFileDelete', ""Controls if editors showing a file should close automatically when the file is deleted or renamed by some other process. Disabling this will keep the editor open as dirty on such an event. Note that deleting from within the application will always close the editor and that dirty files will never close to preserve your data.""),
++		'default': true
++	}
++};
++
++if (isMacintosh) {
++	workbenchProperties['workbench.editor.swipeBetweenOpenFiles'] = {","I am not a big fan of the naming `swipeBetweenOpenFiles`, because in reality you can swipe left and right between any editor that is opened, not just files. How about naming this `workbench.editor.swipeToNavigate`?",2017-04-18 05:53:33
+648,"@@ -760,7 +760,7 @@ export class EditorGroupsControl implements IEditorGroupsControl, IVerticalSashL
+ 			this.sashTwo.setOrientation(this.layoutVertically ? Orientation.VERTICAL : Orientation.HORIZONTAL);
+ 
+ 			// Trigger layout
+-			this.arrangeGroups(GroupArrangement.EVEN);
++			this.arrangeGroups(GroupArrangement.KEEP_RATIO);","Suggest to not introduce a `GroupArrangement.KEEP_RATIO` but rather allow to call `arrangeGroups` without any parameter and then use that as an indication to ""keep the ratio"". I would not expose this as API but just set the arrangement optional here in this file.",2017-01-04 10:26:25
+559,"@@ -761,6 +768,8 @@ export class WindowsManager implements IWindowsMainService {
+ 			}
+ 		}
+ 
++		this.backupService.registerWindowForBackups(vscodeWindow.id, !configuration.workspacePath, configuration.backupFolder, configuration.workspacePath);",@Tyriar are you missing the check for `openConfig.cli.extensionDevelopmentPath` on purpose here?,2016-12-02 06:47:15
+361,"@@ -77,16 +78,22 @@ export class EditorPickerEntry extends QuickOpenEntryGroup {
+ 
+ 	public run(mode: Mode, context: IEntryRunContext): boolean {
+ 		if (mode === Mode.OPEN) {
+-			return this.runOpen(context);
++			this.runOpen(context);
++
++			return true;
++		}","@wprater style: `} else {`
+",2016-10-21 09:54:52
+834,"@@ -77,6 +77,7 @@ export interface IExpression extends ITreeElement, IExpressionContainer {
+ ",Looks good,2017-03-21 17:00:36
+267,"@@ -77,7 +77,7 @@ function prepareDebPackage(arch) {
+ function buildDebPackage(arch) {
+ 	const debArch = getDebPackageArch(arch);
+ 	return shell.task([
+-		'chmod 755 ' + product.applicationName + '-' + debArch + '/DEBIAN/postinst ' + product.applicationName + '-' + debArch + '/DEBIAN/prerm',
++		'chmod 755 ' + product.applicationName + '-' + debArch + '/DEBIAN/postinst ' + product.applicationName + '-' + debArch + '/DEBIAN/prerm ' + product.applicationName + '-' + debArch + '/DEBIAN/postrm',","Thanks for fixing this!
+",2016-09-06 16:04:08
+378,"@@ -778,9 +746,9 @@ export class TextFileEditorModel extends BaseTextEditorModel implements ITextFil
+ 		this.createTextEditorModelPromise = null;
+ 
+ 		this.cancelAutoSavePromises();
+-		this.cancelBackupPromises();
+ 
+-		this.fileService.discardBackup(this.resource);
++		// TODO: Can this be moved to BackupModelService?
++		this.backupFileService.discardAndDeregisterResource(this.resource);","Yes, I suggest another event on the service maybe when this model gets disposed.
+",2016-10-21 14:06:28
+646,"@@ -78,20 +78,32 @@ export class OnEnterSupport {
+ 
+ 		// (3): Indentation Support
+ 		if (this._indentationRules) {
++			let enterAction: EnterAction = null;
+ 			if (this._indentationRules.increaseIndentPattern && this._indentationRules.increaseIndentPattern.test(beforeEnterText)) {
+-				return OnEnterSupport._INDENT;
++				enterAction = OnEnterSupport._INDENT;
+ 			}
+ 			if (this._indentationRules.indentNextLinePattern && this._indentationRules.indentNextLinePattern.test(beforeEnterText)) {
+-				return OnEnterSupport._INDENT;
++				enterAction = OnEnterSupport._INDENT;
+ 			}
+ 			if (/^\s/.test(beforeEnterText)) {
+ 				// No reason to run regular expressions if there is nothing to outdent from
+ 				if (this._indentationRules.decreaseIndentPattern && this._indentationRules.decreaseIndentPattern.test(afterEnterText)) {
+-					return OnEnterSupport._OUTDENT;
++					enterAction = OnEnterSupport._OUTDENT;
+ 				}
+ 				if (this._indentationRules.indentNextLinePattern && this._indentationRules.indentNextLinePattern.test(oneLineAboveText)) {
+-					return OnEnterSupport._OUTDENT;
++					enterAction = OnEnterSupport._OUTDENT;
+ 				}
++				if (this._indentationRules.decreaseIndentPattern && this._indentationRules.decreaseIndentPattern.test(beforeEnterText)) {
++					if (enterAction === null) {
++						enterAction = { indentAction: IndentAction.None, outdentCurrentLine: true };
++					} else {
++						enterAction.outdentCurrentLine = true;","Given this line modifies enterAction, please remove the instances OnEnterSupport._INDENT, OnEnterSupport._OUTDENT and create new object instances everywhere, otherwise the second call to this function might contain a stale outdentCurrentLine set to true.",2016-12-27 09:20:58
+860,"@@ -78,7 +78,11 @@ export interface IEditorGroupsControl {
+ 	setGroupOrientation(orientation: GroupOrientation): void;
+ 	getGroupOrientation(): GroupOrientation;
+ 
++	requestActiveGroupSizeChange(groupSizeChange: number): boolean;","Can we maybe call this similar to the other one `resizePart` in `partService`, e.g. `resizeGroup` and you pass in the position of the group to resize?",2017-03-24 20:25:46
+986,"@@ -785,6 +786,19 @@ export class ImportFileAction extends BaseFileAction {
+ 		return this.tree;
+ 	}
+ 
++	private bringWindowToForeground(): void {
++		if (isWindows) {
++			try {
++				const { allowSetForegroundWindow } = <any>require.__$__nodeRequire('windows-foreground-love');
++				allowSetForegroundWindow(process.pid);","Testing this, I do not see any fix for the issue where sometimes the task bar is just flashing and focus is not put. I suggest to remove this code for now, I see no added value.",2017-06-18 15:46:23
+985,"@@ -785,6 +786,19 @@ export class ImportFileAction extends BaseFileAction {
+ 		return this.tree;
+ 	}
+ 
++	private bringWindowToForeground(): void {
++		if (isWindows) {
++			try {
++				const { allowSetForegroundWindow } = <any>require.__$__nodeRequire('windows-foreground-love');
++				allowSetForegroundWindow(process.pid);
++			} catch (e) {
++				// noop
++			}
++		}
++
++		this.windowService.focusWindow();",I suggest to move this closer to the place of the drop operation because that is really where we want to focus the window: https://github.com/Microsoft/vscode/blob/ben/work/src/vs/workbench/parts/files/browser/views/explorerViewer.ts#L735,2017-06-18 15:45:52
+924,"@@ -79,6 +79,27 @@ export class ExtensionTipsService implements IExtensionTipsService {
+ 		}, err => []);
+ 	}
+ 
++	addToWorkspaceRecommendations(extensionId: string): TPromise<void> {","- Check if extensionId is valid or not
+- I would rather use workbench model service and json edit utility to update. This will retain the existing formatting options of the file. Refer [ConfigurationEditingService](https://github.com/microsoft/vscode/blob/thr0w-13456/src/vs/workbench/services/configuration/node/configurationEditingService.ts#L64) that edits configuration files programatically.",2017-05-12 08:56:08
+42,"@@ -79,6 +82,7 @@ export class Workbench implements IPartService {
+ 
+ 	private static sidebarPositionSettingKey = 'workbench.sidebar.position';
+ 	private static sidebarHiddenSettingKey = 'workbench.sidebar.hidden';
++	private static panelPartHiddenSettingKey = 'workbench.panelPart.hidden';","@isidorn suggest to call it just ""workbench.panel.hidden""
+",2016-01-15 15:17:23
+925,"@@ -799,6 +799,32 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
+ 			});
+ 	}
+ 
++	addToWorkspaceRecommendations(extension: IExtension): TPromise<void> {
++		return this.tipsService.addToWorkspaceRecommendations(extension.id);
++	}
++
++	installAllWorkspaceRecommendations(): TPromise<void> {
++		return this.tipsService.getWorkspaceRecommendations()
++			.then(extensions => {
++				this.queryGallery({ names: extensions })
++					.done(result => {
++						if (result.total < 1) {
++							return;
++						}
++
++						const extension = result.firstPage[0];
++						const promises = [this.open(extension)];",Sorry.. I did not get why do we need to open extension,2017-05-12 08:59:10
+926,"@@ -799,6 +799,32 @@ export class ExtensionsWorkbenchService implements IExtensionsWorkbenchService {
+ 			});
+ 	}
+ 
++	addToWorkspaceRecommendations(extension: IExtension): TPromise<void> {
++		return this.tipsService.addToWorkspaceRecommendations(extension.id);
++	}
++
++	installAllWorkspaceRecommendations(): TPromise<void> {
++		return this.tipsService.getWorkspaceRecommendations()
++			.then(extensions => {
++				this.queryGallery({ names: extensions })
++					.done(result => {
++						if (result.total < 1) {
++							return;
++						}
++
++						const extension = result.firstPage[0];
++						const promises = [this.open(extension)];
++
++						if (this.local.every(local => local.id !== extension.id)) {
++							promises.push(this.install(extension));
++						}
++",Not sure if I misunderstood.. I see it is installing only one recommended extensions in the list not all.. I do not see complete result is being read to install?,2017-05-12 09:02:45
+727,"@@ -8,11 +8,115 @@ import * as strings from 'vs/base/common/strings';
+ import { IState, ITokenizationSupport, TokenizationRegistry, LanguageId } from 'vs/editor/common/modes';
+ import { NULL_STATE, nullTokenize2 } from 'vs/editor/common/modes/nullMode';
+ import { LineTokens } from 'vs/editor/common/core/lineTokens';
++import { CharacterMapping } from 'vs/editor/common/viewLayout/viewLineRenderer';
++import { CharCode } from 'vs/base/common/charCode';
++import { ViewLineToken } from 'vs/editor/common/core/viewLineToken';
+ 
+ export function tokenizeToString(text: string, languageId: string): string {
+ 	return _tokenizeToString(text, _getSafeTokenizationSupport(languageId));
+ }
+ 
++export function tokenizeLineToHTML(text: string, viewLineTokens: ViewLineToken[], rules: { [key: string]: string }, options: { startOffset: number, endOffset: number, tabSize: number, containsRTL: boolean }): string {
++	let tabSize = options.tabSize;
++	let containsRTL = options.containsRTL;
++
++	let result = `<div>`;
++	const characterMapping = new CharacterMapping(text.length + 1, viewLineTokens.length);",No need to build up character mapping here,2017-02-16 15:48:36
+729,"@@ -8,11 +8,115 @@ import * as strings from 'vs/base/common/strings';
+ import { IState, ITokenizationSupport, TokenizationRegistry, LanguageId } from 'vs/editor/common/modes';
+ import { NULL_STATE, nullTokenize2 } from 'vs/editor/common/modes/nullMode';
+ import { LineTokens } from 'vs/editor/common/core/lineTokens';
++import { CharacterMapping } from 'vs/editor/common/viewLayout/viewLineRenderer';
++import { CharCode } from 'vs/base/common/charCode';
++import { ViewLineToken } from 'vs/editor/common/core/viewLineToken';
+ 
+ export function tokenizeToString(text: string, languageId: string): string {
+ 	return _tokenizeToString(text, _getSafeTokenizationSupport(languageId));
+ }
+ 
++export function tokenizeLineToHTML(text: string, viewLineTokens: ViewLineToken[], rules: { [key: string]: string }, options: { startOffset: number, endOffset: number, tabSize: number, containsRTL: boolean }): string {
++	let tabSize = options.tabSize;
++	let containsRTL = options.containsRTL;
++
++	let result = `<div>`;
++	const characterMapping = new CharacterMapping(text.length + 1, viewLineTokens.length);
++
++	let charIndex = options.startOffset;
++	let tabsCharDelta = 0;
++	let charOffsetInPart = 0;","since there's no need to build up character mapping, there's also no need to keep track of charOffsetInPart",2017-02-16 15:50:33
+728,"@@ -8,11 +8,115 @@ import * as strings from 'vs/base/common/strings';
+ import { IState, ITokenizationSupport, TokenizationRegistry, LanguageId } from 'vs/editor/common/modes';
+ import { NULL_STATE, nullTokenize2 } from 'vs/editor/common/modes/nullMode';
+ import { LineTokens } from 'vs/editor/common/core/lineTokens';
++import { CharacterMapping } from 'vs/editor/common/viewLayout/viewLineRenderer';
++import { CharCode } from 'vs/base/common/charCode';
++import { ViewLineToken } from 'vs/editor/common/core/viewLineToken';
+ 
+ export function tokenizeToString(text: string, languageId: string): string {
+ 	return _tokenizeToString(text, _getSafeTokenizationSupport(languageId));
+ }
+ 
++export function tokenizeLineToHTML(text: string, viewLineTokens: ViewLineToken[], rules: { [key: string]: string }, options: { startOffset: number, endOffset: number, tabSize: number, containsRTL: boolean }): string {
++	let tabSize = options.tabSize;
++	let containsRTL = options.containsRTL;
++
++	let result = `<div>`;
++	const characterMapping = new CharacterMapping(text.length + 1, viewLineTokens.length);
++
++	let charIndex = options.startOffset;
++	let tabsCharDelta = 0;
++	let charOffsetInPart = 0;
++
++	for (let tokenIndex = 0, lenJ = viewLineTokens.length; tokenIndex < lenJ; tokenIndex++) {
++		const token = viewLineTokens[tokenIndex];
++		const tokenEndIndex = token.endIndex;
++
++		if (token.endIndex < options.startOffset) {
++			continue;
++		}
++
++		const tokenType = token.type;
++		let partContentCnt = 0;","since there's no need to build up character mapping, there's also no need to keep track of partContentCnt",2017-02-16 15:49:59
+730,"@@ -8,11 +8,115 @@ import * as strings from 'vs/base/common/strings';
+ import { IState, ITokenizationSupport, TokenizationRegistry, LanguageId } from 'vs/editor/common/modes';
+ import { NULL_STATE, nullTokenize2 } from 'vs/editor/common/modes/nullMode';
+ import { LineTokens } from 'vs/editor/common/core/lineTokens';
++import { CharacterMapping } from 'vs/editor/common/viewLayout/viewLineRenderer';
++import { CharCode } from 'vs/base/common/charCode';
++import { ViewLineToken } from 'vs/editor/common/core/viewLineToken';
+ 
+ export function tokenizeToString(text: string, languageId: string): string {
+ 	return _tokenizeToString(text, _getSafeTokenizationSupport(languageId));
+ }
+ 
++export function tokenizeLineToHTML(text: string, viewLineTokens: ViewLineToken[], rules: { [key: string]: string }, options: { startOffset: number, endOffset: number, tabSize: number, containsRTL: boolean }): string {
++	let tabSize = options.tabSize;
++	let containsRTL = options.containsRTL;
++
++	let result = `<div>`;
++	const characterMapping = new CharacterMapping(text.length + 1, viewLineTokens.length);
++
++	let charIndex = options.startOffset;
++	let tabsCharDelta = 0;
++	let charOffsetInPart = 0;
++
++	for (let tokenIndex = 0, lenJ = viewLineTokens.length; tokenIndex < lenJ; tokenIndex++) {
++		const token = viewLineTokens[tokenIndex];
++		const tokenEndIndex = token.endIndex;
++
++		if (token.endIndex < options.startOffset) {
++			continue;
++		}
++
++		const tokenType = token.type;
++		let partContentCnt = 0;
++		let partContent = '';
++
++		for (; charIndex < tokenEndIndex && charIndex < options.endOffset; charIndex++) {
++			characterMapping.setPartData(charIndex, tokenIndex, charOffsetInPart);
++			const charCode = text.charCodeAt(charIndex);
++
++			switch (charCode) {
++				case CharCode.Tab:
++					let insertSpacesCount = tabSize - (charIndex + tabsCharDelta) % tabSize;
++					tabsCharDelta += insertSpacesCount - 1;
++					charOffsetInPart += insertSpacesCount - 1;
++					while (insertSpacesCount > 0) {
++						partContent += '&nbsp;';
++						partContentCnt++;
++						insertSpacesCount--;
++					}
++					break;
++
++				case CharCode.Space:
++					partContent += '&nbsp;';
++					partContentCnt++;
++					break;
++
++				case CharCode.LessThan:
++					partContent += '&lt;';
++					partContentCnt++;
++					break;
++
++				case CharCode.GreaterThan:
++					partContent += '&gt;';
++					partContentCnt++;
++					break;
++
++				case CharCode.Ampersand:
++					partContent += '&amp;';
++					partContentCnt++;
++					break;
++
++				case CharCode.Null:
++					partContent += '&#00;';
++					partContentCnt++;
++					break;
++
++				case CharCode.UTF8_BOM:
++				case CharCode.LINE_SEPARATOR_2028:
++					partContent += '\ufffd';
++					partContentCnt++;
++					break;
++
++				case CharCode.CarriageReturn:
++					// zero width space, because carriage return would introduce a line break
++					partContent += '&#8203';
++					partContentCnt++;
++					break;
++
++				default:
++					partContent += String.fromCharCode(charCode);
++					partContentCnt++;
++			}
++
++			charOffsetInPart++;
++		}
++
++		characterMapping.setPartLength(tokenIndex, partContentCnt);
++		let style = tokenType.split(' ').map(type => rules[type]).join('');","please leave a todo here, we should clean this up once I merge the minimap branch where a view line token holds on to the metadata, it should be straight-forward with those changes to read here the font style and the foreground color directly",2017-02-16 15:52:49
+731,"@@ -8,11 +8,115 @@ import * as strings from 'vs/base/common/strings';
+ import { IState, ITokenizationSupport, TokenizationRegistry, LanguageId } from 'vs/editor/common/modes';
+ import { NULL_STATE, nullTokenize2 } from 'vs/editor/common/modes/nullMode';
+ import { LineTokens } from 'vs/editor/common/core/lineTokens';
++import { CharacterMapping } from 'vs/editor/common/viewLayout/viewLineRenderer';
++import { CharCode } from 'vs/base/common/charCode';
++import { ViewLineToken } from 'vs/editor/common/core/viewLineToken';
+ 
+ export function tokenizeToString(text: string, languageId: string): string {
+ 	return _tokenizeToString(text, _getSafeTokenizationSupport(languageId));
+ }
+ 
++export function tokenizeLineToHTML(text: string, viewLineTokens: ViewLineToken[], rules: { [key: string]: string }, options: { startOffset: number, endOffset: number, tabSize: number, containsRTL: boolean }): string {
++	let tabSize = options.tabSize;
++	let containsRTL = options.containsRTL;
++
++	let result = `<div>`;
++	const characterMapping = new CharacterMapping(text.length + 1, viewLineTokens.length);
++
++	let charIndex = options.startOffset;
++	let tabsCharDelta = 0;
++	let charOffsetInPart = 0;
++
++	for (let tokenIndex = 0, lenJ = viewLineTokens.length; tokenIndex < lenJ; tokenIndex++) {
++		const token = viewLineTokens[tokenIndex];
++		const tokenEndIndex = token.endIndex;
++
++		if (token.endIndex < options.startOffset) {
++			continue;
++		}
++
++		const tokenType = token.type;
++		let partContentCnt = 0;
++		let partContent = '';
++
++		for (; charIndex < tokenEndIndex && charIndex < options.endOffset; charIndex++) {
++			characterMapping.setPartData(charIndex, tokenIndex, charOffsetInPart);
++			const charCode = text.charCodeAt(charIndex);
++
++			switch (charCode) {
++				case CharCode.Tab:
++					let insertSpacesCount = tabSize - (charIndex + tabsCharDelta) % tabSize;
++					tabsCharDelta += insertSpacesCount - 1;
++					charOffsetInPart += insertSpacesCount - 1;
++					while (insertSpacesCount > 0) {
++						partContent += '&nbsp;';
++						partContentCnt++;
++						insertSpacesCount--;
++					}
++					break;
++
++				case CharCode.Space:
++					partContent += '&nbsp;';
++					partContentCnt++;
++					break;
++
++				case CharCode.LessThan:
++					partContent += '&lt;';
++					partContentCnt++;
++					break;
++
++				case CharCode.GreaterThan:
++					partContent += '&gt;';
++					partContentCnt++;
++					break;
++
++				case CharCode.Ampersand:
++					partContent += '&amp;';
++					partContentCnt++;
++					break;
++
++				case CharCode.Null:
++					partContent += '&#00;';
++					partContentCnt++;
++					break;
++
++				case CharCode.UTF8_BOM:
++				case CharCode.LINE_SEPARATOR_2028:
++					partContent += '\ufffd';
++					partContentCnt++;
++					break;
++
++				case CharCode.CarriageReturn:
++					// zero width space, because carriage return would introduce a line break
++					partContent += '&#8203';
++					partContentCnt++;
++					break;
++
++				default:
++					partContent += String.fromCharCode(charCode);
++					partContentCnt++;
++			}
++
++			charOffsetInPart++;
++		}
++
++		characterMapping.setPartLength(tokenIndex, partContentCnt);
++		let style = tokenType.split(' ').map(type => rules[type]).join('');
++		if (containsRTL) {
++			result += `<span dir=""ltr"" style=""${style}"">${partContent}</span>`;","perhaps this is overkill. I have a feeling the software where we paste should figure out by itself what to do with RTL characters, so I suggest to ignore RTL here for now.",2017-02-16 15:53:59
+81,"@@ -8,11 +8,16 @@
+ 		<string>bash</string>
+ 		<string>zsh</string>
+ 		<string>bashrc</string>
++        <string>zshrc</string>","I think you can safely remove these since they're added to the package.json which is the source of truth. Good to go after this is done :+1: 
+",2016-03-22 08:10:18
+9,"@@ -8,13 +8,13 @@ define([
+ 	""vs/languages/html/common/html.contribution"",
+ 	""vs/languages/javascript/common/javascript.contribution"",
+ 	""vs/languages/json/common/json.contribution"",
++	""vs/languages/less/common/less.contribution"",
+ 	""vs/languages/markdown/common/markdown.contribution"",
+ 	""vs/languages/php/common/php.contribution"",
+ 	""vs/languages/plaintext/common/plaintext.contribution"",
+ 	""vs/languages/razor/common/razor.contribution"",
+-	""vs/languages/typescript/common/typescript.contribution"",
+-	""vs/languages/less/common/less.contribution"",
+-	""vs/languages/sass/common/sass.contribution""
++	""vs/languages/sass/common/sass.contribution"",
++	""vs/languages/typescript/common/typescript.contribution""","This change is not really necessary
+",2015-11-21 19:12:58
+757,"@@ -8,14 +8,12 @@
+ 	background-image: url('debug.svg');
+ }
+ 
+-.monaco-editor .debug-top-stack-frame-line {
++.monaco-editor .debug-top-stack-frame-line,
++.monaco-editor .debug-top-stack-frame-exception-line
++{",Put the bracket on the previous line,2017-02-20 14:17:29
+499,"@@ -8,23 +8,22 @@ import { TPromise } from 'vs/base/common/winjs.base';
+ import URI from 'vs/base/common/uri';
+ import { createDecorator } from 'vs/platform/instantiation/common/instantiation';
+ import { IModel } from 'vs/editor/common/editorCommon';
+-import { ITextEditorModel as IBaseTextEditorModel } from 'vs/platform/editor/common/editor';
+-import { IDisposable } from 'vs/base/common/lifecycle';
++import { IEditorModel } from 'vs/platform/editor/common/editor';
++import { IDisposable, IReference } from 'vs/base/common/lifecycle';
+ 
+ export const ITextModelResolverService = createDecorator<ITextModelResolverService>('textModelResolverService');
+ 
+ export interface ITextModelResolverService {
+ 	_serviceBrand: any;
+ 
+ 	/**
+-	 * Given a resource, tries to resolve a ITextEditorModel out of it. Will support many schemes like file://, untitled://,
+-	 * inMemory:// and for anything else fall back to the model content provider registry.
++	 * Provided a resource URI, it will return a model reference
++	 * which should be disposed once not needed anymore.
+ 	 */
+-	resolve(resource: URI): TPromise<ITextEditorModel>;
++	getModelReference(resource: URI): IReference<TPromise<ITextEditorModel>>;","@joaomoreno good stuff. the only thing I am uncertain about is the flow of getting the reference and disposing it. Typically we say you need to `dispose` if you called a `create` method. Here we do a `getReference` and then ask clients to `dispose`. 
+
+I think I would also call it `aquire` and `release` in the resolver service so that it becomes clear that you need to dispose. I am also fine with `createReference` and `dispose`. ",2016-11-21 12:55:56
+451,"@@ -8,6 +8,7 @@
+ import 'vs/css!./media/activitybarpart';
+ import nls = require('vs/nls');
+ import { TPromise } from 'vs/base/common/winjs.base';
++import Event, { Emitter } from 'vs/base/common/event';","@octref I expect some code from here to move out to `IViewletService` or `IExtensionViewletService`. it feels lots of things that should not be activity bar related are now inside this part. To me, the part should not really distinguish between normal viewlets and extension viewlets, but just do its business of rendering a set of viewlets and their activity.
+",2016-11-03 08:49:44
+686,"@@ -8,6 +8,7 @@ import * as paths from 'vs/base/common/paths';
+ import * as platform from 'vs/base/common/platform';
+ import { Adapter } from 'vs/workbench/parts/debug/node/debugAdapter';
+ import { TestConfigurationService } from 'vs/platform/configuration/test/common/testConfigurationService';
++import debug = require('vs/workbench/parts/debug/common/debug');
+ ","This is the old style of importing we no longer use, instead we should switch to
+`import * as debug from 'vs/workbench/parts/debug/common/debug'`
+which should be preferable in new TS versions",2017-01-18 14:08:56
+658,"@@ -8,6 +8,7 @@ import { isLinux, isWindows } from 'vs/base/common/platform';
+ import { fill } from 'vs/base/common/arrays';
+ import { rtrim } from 'vs/base/common/strings';
+ import { CharCode } from 'vs/base/common/charCode';
++import { endsWith } from 'vs/base/common/strings';",@hun1ahpu unused import?,2017-01-10 05:44:32
+513,"@@ -80,6 +80,7 @@ export class TerminalService implements ITerminalService {
+ 			this.setActiveInstanceByIndex(0);
+ 		}
+ 		this._onInstancesChanged.fire();
++		terminalInstance.setCommandsToSkipShell(this.configHelper.getCommandsToSkipShell());","You've actually stumbled upon a bug bigger than this in that no settings values are updated correctly, including scrollback and cursorBlinking as well. Having a brief look at the code, I think the best way to fix this might be to move `TerminalPanel._updateConfig` to `TerminalService.updateConfig` and then call into that after creating the new instance.",2016-11-24 21:09:19
+997,"@@ -80,6 +83,11 @@ export function isWelcomePageEnabled(storageService: IStorageService) {
+ 	return 'enableWelcomePage' in overrides ? overrides.enableWelcomePage : splitExperimentsRandomness(storageService).enableWelcomePage;
+ }
+ 
++export function isShowTaskDocumentation(storageService: IStorageService) {",This is not needed then (see below). The welcome page one (you probably looked at) was a special case I'm about to remove.,2017-06-19 22:01:32
+525,"@@ -80,6 +83,9 @@ export class TerminalService implements ITerminalService {
+ 			this.setActiveInstanceByIndex(0);
+ 		}
+ 		this._onInstancesChanged.fire();
++		this._updateCursorBlink(terminalInstance);","These calls would be more at home inside `TerminalInstance.constructor`. Thinking about this further we may be able to get rid of both calls in `TerminalPanel.setVisible` as well by updating the config at the end of `TerminalInstance.attachToElement`. I believe that covers the cases we need to worry about for updating the config:
+
+- When the terminal is created and the panel exists (`attachToElement` will trigger immediately)
+- When the terminal is created via the API and the panel does not exist (`attachToElement` call will be deferred)
+- When the config is updated (`TerminalService` now listens to `IConfigurationservice.onDidUpdateConfiguration`)",2016-11-28 19:09:11
+815,"@@ -808,9 +808,9 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 		this._onEditorsMoved.fire();
+ 	}
+ 
+-	public moveEditor(input: EditorInput, from: EditorGroup, to: EditorGroup, index?: number): void;
+-	public moveEditor(input: EditorInput, from: Position, to: Position, index?: number): void;
+-	public moveEditor(input: EditorInput, arg2: any, arg3: any, index?: number): void {
++	public moveEditor(input: EditorInput, from: EditorGroup, to: EditorGroup, index?: number, inactive?: boolean): void;",I suggest to put `index` and `inactive` into a new optional options bag (`IMoveOptions`).,2017-03-11 07:14:11
+29,"@@ -81,22 +83,37 @@ export class PluginScanner {
+ 	/**
+ 	 * Scan a list of extensions defined in `absoluteFolderPath`
+ 	 */
+-	public static scanPlugins(version: string, collector: IPluginsMessageCollector, absoluteFolderPath:string, isBuiltin:boolean): TPromise<IPluginDescription[]> {
+-		return pfs.readDirsInDir(absoluteFolderPath).then((folders) => {
+-			return TPromise.join(
+-				folders.map((folder) => this.scanPlugin(version, collector, paths.join(absoluteFolderPath, folder), isBuiltin))
+-			);
+-		}, (err) => {
+-			collector.error(absoluteFolderPath, err);
+-			return [];
+-		}).then((results) => results.filter(item => (item !== null)));
++	public static scanPlugins(
++		version: string,
++		collector: IPluginsMessageCollector,
++		absoluteFolderPath:string,
++		isBuiltin:boolean
++	) : TPromise<IPluginDescription[]>
++	{
++		return pfs.readDirsInDir(absoluteFolderPath)
++			.then(folders => TPromise.join(folders.map(f => this.scanPlugin(version, collector, paths.join(absoluteFolderPath, f), isBuiltin))))
++			.then(plugins => plugins.filter(item => item !== null))
++			.then(plugins => {
++				const pluginsById = values(groupBy(plugins, p => p.id));
++				return pluginsById.map(p => p.sort((a, b) => semver.rcompare(a.version, b.version))[0]);","@joaomoreno 
+
+`semver.rcompare(a.version, b.version)` throws if `a.version` or `b.version` are undefined.
+
+Effectively, this change makes `version` a required field in `package.json`. If this is the intent, then the validation of `package.json` must reflect this. If the version field is required, then `pluginsRegistry.ts` > `isValidPluginDescription` must be updated to check the field exists and **is parsable by semver**.
+
+The following `package.json` breaks all user extension loading:
+
+```
+{
+    ""name"": ""test"",
+    ""publisher"": ""alex"",
+    ""engines"": {
+        ""vscode"": ""0.10.x""
+    }
+}
+```
+
+Just place it twice in the extensions folder with two different folder names to repro. It should fail twice but not prevent other extensions in the same folder from being discovered.
+
+You can do the following:
+- in `pluginsRegistry.ts` > `isValidPluginDescription` check that a version field is present and is a string
+- in `vs\platform\plugins\node\pluginVersionValidator.ts` > `isValidPluginDescription` use semver and check that semver can parse the version
+
+Of course all of this if you know for a fact that no extension made it into the gallery without a valid semver version field, otherwise this new check might break already installed extensions
+",2015-12-16 14:12:08
+472,"@@ -81,7 +81,7 @@ export class FileService implements IFileService {
+ 
+ 		// create service
+ 		const workspace = this.contextService.getWorkspace();
+-		this.raw = new NodeFileService(workspace ? workspace.resource.fsPath : void 0, fileServiceConfig, this.eventService);
++		this.raw = new NodeFileService(workspace ? workspace.resource.fsPath : void 0, fileServiceConfig, this.eventService, this.environmentService, this.configurationService);","@Tyriar these changes are all NOT needed
+",2016-11-09 07:40:51
+841,"@@ -82,23 +94,31 @@ class EditTask implements IDisposable {
+ 	}
+ 
+ 	public addEdit(edit: IResourceEdit): void {
+-		let range: IRange;
+-		if (!edit.range) {
+-			range = this._model.getFullModelRange();
++		if (isIEndOfLineSequenceEdit(edit)) {
++			// store new EOL-sequence, last wins
++			this._newEol = edit.eol;
++
+ 		} else {
+-			range = edit.range;
++			// create edit operation
++			let range: IRange;","Consider a `const` here:
+```ts
+const range = edit.range || this._model.getFullModelRange();
+```",2017-03-21 17:44:01
+164,"@@ -83,18 +100,60 @@ export class TerminalConfigHelper {
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private initializeCharacterSize(font: ITerminalFont, parentDomElement: HTMLElement) {
++		if (!this.characterMeasureElement) {
++			this.characterMeasureElement = new Builder(parentDomElement, true).div().build().getHTMLElement();
++		}
++
++		this.characterMeasureElement.style.display = 'inline';
++		this.characterMeasureElement.style.fontFamily = font.fontFamily;
++		this.characterMeasureElement.style.fontSize = font.fontSize + 'px';
++		this.characterMeasureElement.style.lineHeight = font.lineHeight + 'px';
++		this.characterMeasureElement.innerText = 'X';
++		let bcr = this.characterMeasureElement.getBoundingClientRect();","Probably better named `rect`
+",2016-06-02 06:48:36
+165,"@@ -83,18 +100,60 @@ export class TerminalConfigHelper {
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private initializeCharacterSize(font: ITerminalFont, parentDomElement: HTMLElement) {
++		if (!this.characterMeasureElement) {
++			this.characterMeasureElement = new Builder(parentDomElement, true).div().build().getHTMLElement();
++		}
++
++		this.characterMeasureElement.style.display = 'inline';
++		this.characterMeasureElement.style.fontFamily = font.fontFamily;
++		this.characterMeasureElement.style.fontSize = font.fontSize + 'px';
++		this.characterMeasureElement.style.lineHeight = font.lineHeight + 'px';
++		this.characterMeasureElement.innerText = 'X';
++		let bcr = this.characterMeasureElement.getBoundingClientRect();
++		this.characterMeasureElement.style.display = 'none';
++		this.charWidth = Math.ceil(bcr.width || TERMINAL_CHAR_WIDTH_FALLBACK);","Do you know when `bcr.width` will be falsey or was this just defensive?
+",2016-06-02 06:51:25
+166,"@@ -83,18 +100,60 @@ export class TerminalConfigHelper {
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private initializeCharacterSize(font: ITerminalFont, parentDomElement: HTMLElement) {
++		if (!this.characterMeasureElement) {
++			this.characterMeasureElement = new Builder(parentDomElement, true).div().build().getHTMLElement();
++		}
++
++		this.characterMeasureElement.style.display = 'inline';
++		this.characterMeasureElement.style.fontFamily = font.fontFamily;
++		this.characterMeasureElement.style.fontSize = font.fontSize + 'px';
++		this.characterMeasureElement.style.lineHeight = font.lineHeight + 'px';
++		this.characterMeasureElement.innerText = 'X';
++		let bcr = this.characterMeasureElement.getBoundingClientRect();
++		this.characterMeasureElement.style.display = 'none';
++		this.charWidth = Math.ceil(bcr.width || TERMINAL_CHAR_WIDTH_FALLBACK);
++		this.charHeight = Math.ceil(bcr.height || TERMINAL_CHAR_HEIGHT_FALLBACK);
++	}
++
+ 	/**
+-	 * Set the terminal font to `terminal.integrated.fontFamily` if it is set, otherwise fallback to
+-	 * `editor.fontFamily`.
++	 * Gets the font information based on the terminal.integrated.fontFamily,
++	 * terminal.integrated.fontSize, terminal.integrated.lineHeight configuration properties
++	 *
++	 * @param parentDomElement Host for the character measurement element
++	 * @param updateCharSize A flag which indicates whether the character size should be measured
+ 	 */
+-	public getFontFamily(): string {
++	public getFont(parentDomElement: HTMLElement, updateCharSize?: boolean): ITerminalFont {","Pass `parentDomElement` into the constructor and have `TerminalConfigHelper` keep a pointer to it.
+",2016-06-02 06:52:58
+168,"@@ -83,18 +100,60 @@ export class TerminalConfigHelper {
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private initializeCharacterSize(font: ITerminalFont, parentDomElement: HTMLElement) {
++		if (!this.characterMeasureElement) {
++			this.characterMeasureElement = new Builder(parentDomElement, true).div().build().getHTMLElement();
++		}
++
++		this.characterMeasureElement.style.display = 'inline';
++		this.characterMeasureElement.style.fontFamily = font.fontFamily;
++		this.characterMeasureElement.style.fontSize = font.fontSize + 'px';
++		this.characterMeasureElement.style.lineHeight = font.lineHeight + 'px';
++		this.characterMeasureElement.innerText = 'X';
++		let bcr = this.characterMeasureElement.getBoundingClientRect();
++		this.characterMeasureElement.style.display = 'none';
++		this.charWidth = Math.ceil(bcr.width || TERMINAL_CHAR_WIDTH_FALLBACK);
++		this.charHeight = Math.ceil(bcr.height || TERMINAL_CHAR_HEIGHT_FALLBACK);
++	}
++
+ 	/**
+-	 * Set the terminal font to `terminal.integrated.fontFamily` if it is set, otherwise fallback to
+-	 * `editor.fontFamily`.
++	 * Gets the font information based on the terminal.integrated.fontFamily,
++	 * terminal.integrated.fontSize, terminal.integrated.lineHeight configuration properties
++	 *
++	 * @param parentDomElement Host for the character measurement element
++	 * @param updateCharSize A flag which indicates whether the character size should be measured
+ 	 */
+-	public getFontFamily(): string {
++	public getFont(parentDomElement: HTMLElement, updateCharSize?: boolean): ITerminalFont {
+ 		let terminalConfig = this.configurationService.getConfiguration<ITerminalConfiguration>();
++		let editorConfig = this.configurationService.getConfiguration<IConfiguration>();
++
+ 		let fontFamily = terminalConfig.terminal.integrated.fontFamily;
++		let fontSize = this.toInteger(terminalConfig.terminal.integrated.fontSize, 0, 100) || this.toInteger(editorConfig.editor.fontSize, 0, 100);","Is the max necessary?
+
+Also you can simplify:
+
+``` ts
+this.toInteger(terminalConfig.terminal.integrated.fontSize || editorConfig.editor.fontSize, 0, 100)
+```
+",2016-06-02 06:57:51
+167,"@@ -83,18 +100,60 @@ export class TerminalConfigHelper {
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
++	private initializeCharacterSize(font: ITerminalFont, parentDomElement: HTMLElement) {
++		if (!this.characterMeasureElement) {
++			this.characterMeasureElement = new Builder(parentDomElement, true).div().build().getHTMLElement();
++		}
++
++		this.characterMeasureElement.style.display = 'inline';
++		this.characterMeasureElement.style.fontFamily = font.fontFamily;
++		this.characterMeasureElement.style.fontSize = font.fontSize + 'px';
++		this.characterMeasureElement.style.lineHeight = font.lineHeight + 'px';
++		this.characterMeasureElement.innerText = 'X';
++		let bcr = this.characterMeasureElement.getBoundingClientRect();
++		this.characterMeasureElement.style.display = 'none';
++		this.charWidth = Math.ceil(bcr.width || TERMINAL_CHAR_WIDTH_FALLBACK);
++		this.charHeight = Math.ceil(bcr.height || TERMINAL_CHAR_HEIGHT_FALLBACK);
++	}
++
+ 	/**
+-	 * Set the terminal font to `terminal.integrated.fontFamily` if it is set, otherwise fallback to
+-	 * `editor.fontFamily`.
++	 * Gets the font information based on the terminal.integrated.fontFamily,
++	 * terminal.integrated.fontSize, terminal.integrated.lineHeight configuration properties
++	 *
++	 * @param parentDomElement Host for the character measurement element
++	 * @param updateCharSize A flag which indicates whether the character size should be measured
+ 	 */
+-	public getFontFamily(): string {
++	public getFont(parentDomElement: HTMLElement, updateCharSize?: boolean): ITerminalFont {
+ 		let terminalConfig = this.configurationService.getConfiguration<ITerminalConfiguration>();
++		let editorConfig = this.configurationService.getConfiguration<IConfiguration>();
++
+ 		let fontFamily = terminalConfig.terminal.integrated.fontFamily;
++		let fontSize = this.toInteger(terminalConfig.terminal.integrated.fontSize, 0, 100) || this.toInteger(editorConfig.editor.fontSize, 0, 100);
++		let lineHeight = this.toInteger(terminalConfig.terminal.integrated.lineHeight, 0, 150) || this.toInteger(editorConfig.editor.lineHeight, 0, 150);
++
+ 		if (!fontFamily) {
+-			let editorConfig = this.configurationService.getConfiguration<IConfiguration>();
+ 			fontFamily = editorConfig.editor.fontFamily;
+ 		}
+-		return fontFamily;
++
++		if (lineHeight === 0) {
++			lineHeight = Math.round(GOLDEN_LINE_HEIGHT_RATIO * fontSize);
++		}
++
++		var font: ITerminalFont = {","Prefer `let`
+",2016-06-02 06:55:32
+524,"@@ -84,12 +85,14 @@ export class TerminalPanel extends Panel {
+ 	public setVisible(visible: boolean): TPromise<void> {
+ 		if (visible) {
+ 			if (this._terminalService.terminalInstances.length > 0) {
+-				this._updateConfig();
++				this._terminalService.updateConfig();
++				this._updateFont();
+ 				this._updateTheme();
+ 			} else {
+ 				return super.setVisible(visible).then(() => {
+ 					this._terminalService.createInstance();
+-					this._updateConfig();
++					this._terminalService.updateConfig();",This shouldn't be needed anymore as it's called within `ITerminalService.createInstance`,2016-11-28 19:02:15
+407,"@@ -84,43 +140,77 @@ export class ActivitybarPart extends Part implements IActivityService {
+ 		const $result = $('.content').appendTo($el);
+ 
+ 		// Top Actionbar with action items for each viewlet action
+-		this.createViewletSwitcher($result.clone());
++		this.createViewletSwitcher($result.clone().addClass('position-top'));","What does this do?
+",2016-10-24 15:42:28
+408,"@@ -84,43 +140,77 @@ export class ActivitybarPart extends Part implements IActivityService {
+ 		const $result = $('.content').appendTo($el);
+ 
+ 		// Top Actionbar with action items for each viewlet action
+-		this.createViewletSwitcher($result.clone());
++		this.createViewletSwitcher($result.clone().addClass('position-top'));
+ 
+ 		return $result;
+ 	}
+ 
+ 	private createViewletSwitcher(div: Builder): void {
+-
+-		// Composite switcher is on top","Why remove?
+",2016-10-24 15:43:08
+560,"@@ -84,6 +84,7 @@ export interface IWindowConfiguration extends ParsedArgs {
+ 	perfWindowLoadTime?: number;
+ 
+ 	workspacePath?: string;
++	backupFolder?: string;",@Tyriar suggest `backupPath` to keep naming consistent,2016-12-02 06:48:36
+955,"@@ -84,6 +90,12 @@ export class MergeConflictParser {
+ 			return null;
+ 		}
+ 
++		let tokenAfterCurrentBlock: vscode.TextLine = scanned.splitter;
++
++		if (scanned.commonAncestors !== null) {
++			tokenAfterCurrentBlock = scanned.commonAncestors;
++		}
++","Nit; Could be condensed to
+
+```javascript
+const tokenAfterCurrentBlock = scanned.commonAncestors || scanned.splitter; 
+```",2017-05-30 15:43:48
+638,"@@ -85,4 +85,16 @@ declare module 'vscode' {
+ 		 */
+ 		getClickCommand?(node: T): string;
+ 	}
++	export interface TextEditor {
++		/**
++		 * Inserts the given snippet template and enters snippet mode.
++		 *
++		 * If the editor is already in snippet mode, insertion fails and the returned promise resolves to false.
++		 *
++		 * @param template The snippet template to insert
++		 * @param posOrRange The position or replacement range representing the location of the insertion.
++		 * @return A promise that resolves with a value indicating if the snippet could be inserted.
++		 */
++		insertSnippet(template: string, posOrRange: Position | Range): Thenable<boolean>;
++	}",this isn't needed as we make the change directly in `vscode.d.ts`,2016-12-21 08:17:27
+869,"@@ -85,6 +299,26 @@ const iso639_3_to_2: Map<string> = {
+ 	'trk': 'tr'
+ };
+ 
++const iso639_2_to_3: Map<string> = {",We might want to consider using 2 letter id in the future. The reason why we have this mapping is that MS internally uses 3. If all is public we could switch over to 2.,2017-04-04 13:02:52
+664,"@@ -85,6 +85,39 @@ class MyCompletionItem extends CompletionItem {
+ 
+ 		return CompletionItemKind.Property;
+ 	}
++
++	private static getCommitCharacters(document: TextDocument, kind: string): string[] | undefined {
++		switch (kind) {
++			case PConst.Kind.externalModuleName:
++				return ['""', '\''];
++
++			case PConst.Kind.file:
++			case PConst.Kind.directory:
++				return ['/', '""', '\''];",backslash?,2017-01-12 08:36:26
+665,"@@ -85,6 +85,39 @@ class MyCompletionItem extends CompletionItem {
+ 
+ 		return CompletionItemKind.Property;
+ 	}
++
++	private static getCommitCharacters(document: TextDocument, kind: string): string[] | undefined {
++		switch (kind) {
++			case PConst.Kind.externalModuleName:
++				return ['""', '\''];
++
++			case PConst.Kind.file:
++			case PConst.Kind.directory:
++				return ['/', '""', '\''];
++
++			case PConst.Kind.alias:
++			case PConst.Kind.variable:
++			case PConst.Kind.localVariable:
++			case PConst.Kind.memberVariable:
++			case PConst.Kind.memberGetAccessor:
++			case PConst.Kind.memberSetAccessor:
++			case PConst.Kind.constructSignature:
++			case PConst.Kind.callSignature:
++			case PConst.Kind.indexSignature:
++			case PConst.Kind.enum:
++			case PConst.Kind.module:
++			case PConst.Kind.class:
++			case PConst.Kind.interface:
++			case PConst.Kind.function:",`(` for functions?,2017-01-12 08:36:49
+953,"@@ -85,6 +90,11 @@ export default class MergeDectorator implements vscode.Disposable {
+ 				}
+ 			});
+ 
++			this.decorations['commonAncestors.header'] = vscode.window.createTextEditorDecorationType({
++				color: new vscode.ThemeColor('editor.foreground'),","@kieferrm, @chrmarti: We should probably add a new theme color from common ancestor blocks. I'd be in favor of coloring them at some point. ",2017-05-30 15:41:11
+355,"@@ -85,6 +91,7 @@ export interface IExtensionContributions {
+ 	menus?: { [context: string]: IMenu[] };
+ 	snippets?: ISnippet[];
+ 	themes?: ITheme[];
++	explorer?: ITreeExplorer;","Only one tree per extension?
+",2016-10-21 07:44:44
+269,"@@ -85,8 +87,8 @@ export class ExtHostTerminalService {
+ 		this._proxy = threadService.get(MainContext.MainThreadTerminalService);
+ 	}
+ 
+-	public createTerminal(name?: string): vscode.Terminal {
+-		return new ExtHostTerminal(this._proxy, -1, name);
++	public createTerminal(name?: string, path?: string): vscode.Terminal {","path -> shellPath
+",2016-09-08 19:02:55
+862,"@@ -853,6 +857,83 @@ export class EditorGroupsControl extends Themable implements IEditorGroupsContro
+ 		return ratio;
+ 	}
+ 
++	// Request size change on the active editor/group - changes main axis
++	public requestActiveGroupSizeChange(groupSizeChange: number): boolean {
++
++		enum VISIBLE_EDITORS {
++			ONE = 1,
++			TWO = 2,
++			THREE = 3
++		}
++
++		const visibleEditors = this.getVisibleEditorCount();
++
++		if (visibleEditors <= VISIBLE_EDITORS.ONE) {
++			return false;
++		}
++
++		let availableSize = this.totalSize;
++		const activeGroupPosition = this.getActivePosition();
++
++		switch (visibleEditors) {
++			case VISIBLE_EDITORS.TWO:
++				switch (activeGroupPosition) {
++					case Position.ONE:
++						this.silosSize[Position.ONE] = this.boundSiloSize(Position.ONE, groupSizeChange);
++						this.silosSize[Position.TWO] = availableSize - this.silosSize[Position.ONE];
++						break;
++					case Position.TWO:
++						this.silosSize[Position.TWO] = this.boundSiloSize(Position.TWO, groupSizeChange);
++						this.silosSize[Position.ONE] = availableSize - this.silosSize[Position.TWO];
++					default:
++						break;
++				}
++				break;
++			case VISIBLE_EDITORS.THREE:
++				switch (activeGroupPosition) {
++					case Position.ONE:
++						this.silosSize[Position.ONE] = this.boundSiloSize(Position.ONE, groupSizeChange);
++						this.distributeRemainingSilosSize(Position.TWO, Position.THREE, availableSize - this.silosSize[Position.ONE]);
++						break;
++					case Position.TWO:
++						this.silosSize[Position.TWO] = this.boundSiloSize(Position.TWO, groupSizeChange);
++						this.distributeRemainingSilosSize(Position.ONE, Position.THREE, availableSize - this.silosSize[Position.TWO]);
++						break;
++					case Position.THREE:
++						this.silosSize[Position.THREE] = this.boundSiloSize(Position.THREE, groupSizeChange);
++						this.distributeRemainingSilosSize(Position.ONE, Position.TWO, availableSize - this.silosSize[Position.THREE]);
++						break;
++					default:
++						break;
++				}
++			default:
++				break;
++		}
++		this.layout(this.dimension);
++
++		return true;
++	}
++
++	protected boundSiloSize(siloPosition: Position, sizeChangePx: number): number {",`protected` =>  `private`?,2017-03-24 20:37:46
+863,"@@ -853,6 +857,83 @@ export class EditorGroupsControl extends Themable implements IEditorGroupsContro
+ 		return ratio;
+ 	}
+ 
++	// Request size change on the active editor/group - changes main axis
++	public requestActiveGroupSizeChange(groupSizeChange: number): boolean {
++
++		enum VISIBLE_EDITORS {
++			ONE = 1,
++			TWO = 2,
++			THREE = 3
++		}
++
++		const visibleEditors = this.getVisibleEditorCount();
++
++		if (visibleEditors <= VISIBLE_EDITORS.ONE) {
++			return false;
++		}
++
++		let availableSize = this.totalSize;
++		const activeGroupPosition = this.getActivePosition();
++
++		switch (visibleEditors) {
++			case VISIBLE_EDITORS.TWO:
++				switch (activeGroupPosition) {
++					case Position.ONE:
++						this.silosSize[Position.ONE] = this.boundSiloSize(Position.ONE, groupSizeChange);
++						this.silosSize[Position.TWO] = availableSize - this.silosSize[Position.ONE];
++						break;
++					case Position.TWO:
++						this.silosSize[Position.TWO] = this.boundSiloSize(Position.TWO, groupSizeChange);
++						this.silosSize[Position.ONE] = availableSize - this.silosSize[Position.TWO];
++					default:
++						break;
++				}
++				break;
++			case VISIBLE_EDITORS.THREE:
++				switch (activeGroupPosition) {
++					case Position.ONE:
++						this.silosSize[Position.ONE] = this.boundSiloSize(Position.ONE, groupSizeChange);
++						this.distributeRemainingSilosSize(Position.TWO, Position.THREE, availableSize - this.silosSize[Position.ONE]);
++						break;
++					case Position.TWO:
++						this.silosSize[Position.TWO] = this.boundSiloSize(Position.TWO, groupSizeChange);
++						this.distributeRemainingSilosSize(Position.ONE, Position.THREE, availableSize - this.silosSize[Position.TWO]);
++						break;
++					case Position.THREE:
++						this.silosSize[Position.THREE] = this.boundSiloSize(Position.THREE, groupSizeChange);
++						this.distributeRemainingSilosSize(Position.ONE, Position.TWO, availableSize - this.silosSize[Position.THREE]);
++						break;
++					default:
++						break;
++				}
++			default:
++				break;
++		}
++		this.layout(this.dimension);
++
++		return true;
++	}
++
++	protected boundSiloSize(siloPosition: Position, sizeChangePx: number): number {
++		const visibleEditors = this.getVisibleEditorCount();
++		let newSiloSize: number = 0;
++
++		newSiloSize = Math.max(this.minSize, this.silosSize[siloPosition] + sizeChangePx);
++		newSiloSize = Math.min(newSiloSize, (this.totalSize - this.minSize * (visibleEditors - 1)));
++
++		return newSiloSize;
++	}
++
++	protected distributeRemainingSilosSize(remPosition1: Position, remPosition2: Position, availableSize: number): void {",`protected` =>  `private`?,2017-03-24 20:37:51
+82,"@@ -86,7 +86,8 @@ class ExtHostApiCommands {
+ 			description: 'Execute signature help provider.',
+ 			args: [
+ 				{ name: 'uri', description: 'Uri of a text document', constraint: URI },
+-				{ name: 'position', description: 'Position in a text document', constraint: types.Position }
++				{ name: 'position', description: 'Position in a text document', constraint: types.Position },
++				{ name: 'triggerCharacter', description: 'Trigger signature help when the user types the character, like `,` or `(`', constraint: String }
+ 			],","this is an array and called triggerCharacters, also it's optional which I don't know if we express yet
+",2016-03-22 10:58:51
+496,"@@ -87,8 +86,13 @@ export class UntitledEditorInput extends AbstractUntitledEditorInput {
+ 			return this.cachedModel.isDirty();
+ 		}
+ 
+-		// untitled files with an associated path or restore resource are always dirty
+-		return this.hasAssociatedFilePath || !!this.restoreResource;
++		// A disposed input is never dirty, even if it was restored from backup
++		if (this.isDisposed()) {
++			return false;
++		}
++
++		// untitled files with an associated path or associated resource
++		return this.hasAssociatedFilePath || !!this.resource;","@Tyriar isn't that wrong? every untitled editor input will have a resource but will not be dirty when opened (e.g. open a new untitled file without content, it should not show dirty).
+",2016-11-16 14:57:41
+723,"@@ -88,42 +88,82 @@ export function shorten(paths: string[]): string[] {
+ 	// for every path
+ 	let match = false;
+ 	for (let pathIndex = 0; pathIndex < paths.length; pathIndex++) {
+-		const path = paths[pathIndex];
++		let path = paths[pathIndex];
++
++		if (path === '') {
++			shortenedPaths[pathIndex] = '.';
++			continue;
++		}
++
++		if (!path) {
++			shortenedPaths[pathIndex] = path;
++			continue;
++		}
++
+ 		match = true;
+ 
++		let prefix = '';
++		// trim for now and concatenate network path (e.g. \\network) or root path (/etc) later
++		if (path.indexOf(`${nativeSep + nativeSep}`) === 0) {",I suggest to extract a new `const unc = ${nativeSep + nativeSep}`,2017-02-09 06:30:07
+724,"@@ -88,42 +88,82 @@ export function shorten(paths: string[]): string[] {
+ 	// for every path
+ 	let match = false;
+ 	for (let pathIndex = 0; pathIndex < paths.length; pathIndex++) {
+-		const path = paths[pathIndex];
++		let path = paths[pathIndex];
++
++		if (path === '') {
++			shortenedPaths[pathIndex] = '.';
++			continue;
++		}
++
++		if (!path) {
++			shortenedPaths[pathIndex] = path;
++			continue;
++		}
++
+ 		match = true;
+ 
++		let prefix = '';
++		// trim for now and concatenate network path (e.g. \\network) or root path (/etc) later
++		if (path.indexOf(`${nativeSep + nativeSep}`) === 0) {
++			prefix = path.substr(0, path.indexOf(`${nativeSep + nativeSep}`) + 2);
++			path = path.substr(path.indexOf(`${nativeSep + nativeSep}`) + 2);
++		} else if (path.indexOf(`${nativeSep}`) === 0) {
++			prefix = path.substr(0, path.indexOf(`${nativeSep}`) + 1);","Makes it unnecessarily hard to read to put a variable around ticks, just use `nativeSep` here?",2017-02-09 06:30:44
+820,"@@ -88,6 +88,30 @@ export function tildify(path: string, userHome: string): string {
+  * Shortens the paths but keeps them easy to distinguish.
+  * Replaces not important parts with ellipsis.
+  * Every shorten path matches only one original path and vice versa.
++ *
++ * Algorithm for shortening paths is as follows:
++ * 1. For every path in list, find unique substring of that path.
++ * 2. Unique substring along with ellipsis is shortened path of that path.
++ * 3. To find unique substring of path, consider every segment of length from 1 to path.length of path from end of string
++ *    and if present segment is not substring to any other paths then present segment is unique path,
++ *    else check if it is not present as suffix of any other path and present segment is suffix of path itself,
++ *    if it is true take present segment as unique path.
++ * 4. Apply ellipsis to unique segment according to whether segment is present at start/in-between/end of path.
++ *
++ * Example 1
++ * 1. consider 2 paths i.e. ['a\\b\\c\\d', 'a\\f\\b\\c\\d']
++ * 2. find unique path of first path,
++ * 	a. 'd' is present in path2 and is suffix of path2, hence not unique of present path.
++ * 	b. 'c' is present in path2 and 'c' is not suffix of present path, similarly for 'b' and 'a' also.
++ * 	c. 'd\\c' is suffix of path2.
++ *  d. 'b\\c' is not suffix of present path.
++ *  e. 'a\\b' is not present in path2, hence unique path is 'a\\b...'.
++ * 3. for path2, 'f' is not present in path1 hence unique is '...\\f\\...'.
++ *
++ * Example 2
++ * 1. consider 2 paths i.e. ['a\\b', 'a\\b\\c'].
++ * 	a. Even if 'b' is present in path2, as 'b' is suffix of path1 and is not suffix of path2, unique path will be '...\\b'.
++ * 2. for path2, 'c' is not present in path1 hence unique path is '..\\c'.","@bpasero @hun1ahpu @Tyriar Adding detailed algorithm. Please review.
+
+I think algorithm can be improved with the help of better data-structure, will create new PR with improved algorithm.
+
+Thanks :)",2017-03-13 12:12:36
+152,"@@ -889,7 +909,8 @@ export class Parser {
+ 			node.setExpression(this._parseStringLiteral()) ||
+ 			node.setExpression(this._parseNumeric()) ||
+ 			node.setExpression(this._parseHexColor()) ||
+-			node.setExpression(this._parseOperation())
++			node.setExpression(this._parseOperation()) ||
++			node.setExpression(this._parseVariableExpression())","This needs to be before parseIndent (there could be an ident 'var'). Actually i'd rather do not have a _parseVariableExpression but let variable declarations be handled by _parseFunction.
+",2016-05-20 09:59:25
+676,"@@ -898,6 +898,7 @@ export interface IWorkbenchEditorConfiguration {
+ 		editor: {
+ 			showTabs: boolean;
+ 			showTabCloseButton: boolean;
++			tabCloseButton: 'left' | 'right' | 'off';",remove `showTabCloseButton`,2017-01-16 07:59:57
+967,"@@ -899,6 +905,24 @@ export class CodeMenu {
+ 		}
+ 	}
+ 
++	private setTaskMenu(taskMenu: Electron.Menu): void {
++		const runTask = this.createMenuItem(nls.localize({ key: 'miRunTask', comment: ['&& denotes a mnemonic'] }, ""&&Run Task...""), 'workbench.action.tasks.runTask');
++		const restartTask = this.createMenuItem(nls.localize({ key: 'miRestartTask', comment: ['&& denotes a mnemonic'] }, ""&&Restart Task""), 'workbench.action.tasks.restartTask');
++		const terminateTask = this.createMenuItem(nls.localize({ key: 'miTerminateTask', comment: ['&& denotes a mnemonic'] }, ""&&Terminate Task""), 'workbench.action.tasks.terminate');
++		const buildTask = this.createMenuItem(nls.localize({ key: 'miBuildTask', comment: ['&& denotes a mnemonic'] }, ""&&Build Task""), 'workbench.action.tasks.build');
++		const testTask = this.createMenuItem(nls.localize({ key: 'miTestTask', comment: ['&& denotes a mnemonic'] }, ""&&Test Task""), 'workbench.action.tasks.test');
++		const showTaskLog = this.createMenuItem(nls.localize({ key: 'miShowTaskLog', comment: ['&& denotes a mnemonic'] }, ""&&Show Task Log""), 'workbench.action.tasks.showLog');","De-dupe the mnemonics here- R, T",2017-06-12 21:34:30
+55,"@@ -9,10 +9,28 @@
+ 
+ declare namespace vscode {
+ 
+-	/**
+-	 * The version of the editor.
+-	 */
+-	export var version: string;","that is API breakage which we cannot do
+",2016-01-21 11:29:53
+56,"@@ -9,10 +9,28 @@
+ 
+ declare namespace vscode {
+ 
+-	/**
+-	 * The version of the editor.
+-	 */
+-	export var version: string;
++	export const env: {
++		/**
++		 * The version of the editor.
++		 */
++		version: string;
++
++		/**
++		 * locale, like de-ch, en-us
++		 */
++		locale: string;","@dbaeumer We are looking into adding some vscode environment information. What do thing is needed for localisation support. Is a `locale` string enough?
+",2016-01-21 11:30:53
+471,"@@ -9,11 +9,13 @@ import fs = require('fs');
+ import path = require('path');
+ import os = require('os');
+ import assert = require('assert');
++import crypto = require('crypto');","@Tyriar warnings in this file
+",2016-11-09 07:39:16
+190,"@@ -9,21 +9,46 @@ import * as vscode from 'vscode';
+ import * as path from 'path';
+ import { ExtensionContext, TextDocumentContentProvider, EventEmitter, Event, Uri, ViewColumn } from ""vscode"";
+ 
+-const hljs = require('highlight.js');
+-const mdnh = require('markdown-it-named-headers');
+-const md = require('markdown-it')({
+-	html: true,
+-	highlight: function (str, lang) {
+-		if (lang && hljs.getLanguage(lang)) {
+-			try {
+-				return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
+-			} catch (error) { }
++let md;
++let userStyles = [];
++
++export function activate(context: ExtensionContext) {
++	// Upon activation, load markdown module with default
++	// plugins, and then load any user-defined plugins.
++	// Note: user-defined plugins may override default plugins.
++	const hljs = require('highlight.js');","Would suggest a better naming for the hljs. const HIGHLIGHT? Same for the const below MARKDOWN_HEADERS? And out of curiosity why are the const namings not ALL_CAPS? I cannot find this back in the https://github.com/Microsoft/vscode/wiki/Coding-Guidelines
+",2016-06-21 11:29:28
+188,"@@ -9,21 +9,46 @@ import * as vscode from 'vscode';
+ import * as path from 'path';
+ import { ExtensionContext, TextDocumentContentProvider, EventEmitter, Event, Uri, ViewColumn } from ""vscode"";
+ 
+-const hljs = require('highlight.js');
+-const mdnh = require('markdown-it-named-headers');
+-const md = require('markdown-it')({
+-	html: true,
+-	highlight: function (str, lang) {
+-		if (lang && hljs.getLanguage(lang)) {
+-			try {
+-				return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
+-			} catch (error) { }
++let md;
++let userStyles = [];
++
++export function activate(context: ExtensionContext) {
++	// Upon activation, load markdown module with default
++	// plugins, and then load any user-defined plugins.
++	// Note: user-defined plugins may override default plugins.
++	const hljs = require('highlight.js');
++	const mdnh = require('markdown-it-named-headers');","Put it into a special list, maybe called `builtInPlugins` and merge it with `userPlugins` at runtime?
+",2016-06-20 10:02:31
+189,"@@ -9,21 +9,46 @@ import * as vscode from 'vscode';
+ import * as path from 'path';
+ import { ExtensionContext, TextDocumentContentProvider, EventEmitter, Event, Uri, ViewColumn } from ""vscode"";
+ 
+-const hljs = require('highlight.js');
+-const mdnh = require('markdown-it-named-headers');
+-const md = require('markdown-it')({
+-	html: true,
+-	highlight: function (str, lang) {
+-		if (lang && hljs.getLanguage(lang)) {
+-			try {
+-				return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
+-			} catch (error) { }
++let md;
++let userStyles = [];
++
++export function activate(context: ExtensionContext) {
++	// Upon activation, load markdown module with default
++	// plugins, and then load any user-defined plugins.
++	// Note: user-defined plugins may override default plugins.
++	const hljs = require('highlight.js');
++	const mdnh = require('markdown-it-named-headers');
++	md = require('markdown-it')({
++		html: true,
++		highlight: function (str, lang) {
++			if (lang && hljs.getLanguage(lang)) {
++				try {
++					return `<pre class=""hljs""><code><div>${hljs.highlight(lang, str, true).value}</div></code></pre>`;
++				} catch (error) { }
++			}
++			return `<pre class=""hljs""><code><div>${md.utils.escapeHtml(str)}</div></code></pre>`;
+ 		}
+-		return `<pre class=""hljs""><code><div>${md.utils.escapeHtml(str)}</div></code></pre>`;
++	}).use(mdnh, {});
++
++	// Load user-defined packages
++	const userPlugins = <Array<Object>>vscode.workspace.getConfiguration('markdown')['plugins'];
++	if (userPlugins && Array.isArray(userPlugins)) {","This can be a single `instanceof Array`
+",2016-06-20 10:04:30
+183,"@@ -9,26 +9,41 @@
+ 	<script>
+ 		'use strict';
+ 
++		var initData = {};
++
++		function styleBody(body) {
++			if (body) {
++				let currentClasses = body.className.split(' ');
++				let strippedClasses = currentClasses.filter((cl) => {
++					return !initData.bodyClasses.remove.includes(cl);
++				});
++				body.className= `${strippedClasses.join(' ')} ${initData.bodyClasses.add}`;
++			}","Could we just use: `body.classList.remove(""vs"", ""vs-dark"", ""hc-dark""); body.classList.add(""theActualTheme"")`?
+",2016-06-14 13:39:47
+86,"@@ -9,42 +9,132 @@
+ 	""properties"": {
+ 		""compilerOptions"": {
+ 			""type"": ""object"",
+-			""description"": ""Instructs the JavaScript language service how to validate .js files"",
++			""description"": ""Instructs the JavaScript language service how to validate and down level compile .js files"",
+ 			""properties"": {
+ 				""charset"": {
+ 					""description"": ""The character set of the input files"",
+ 					""type"": ""string""
+ 				},
+ 				""diagnostics"": {
+-					""description"": ""Show diagnostic information."",
++					""description"": ""When down-level compiling, show diagnostic information."",
+ 					""type"": ""boolean""
+ 				},
+-				""locale"": {
+-					""description"": ""The locale to use to show error messages, e.g. en-us."",
++				""emitBOM"": {
++					""description"": ""When down-level compiling, emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files."",
++					""type"": ""boolean""
++				},
++				""inlineSourceMap"": {
++					""description"": ""When down-level compiling, emit a single file with source maps instead of having a separate file."",
++					""type"": ""boolean""
++				},
++				""inlineSources"": {
++					""description"": ""When down-level compiling, emit the source alongside the sourcemaps within a single file; requires --inlineSourceMap to be set."",
++					""type"": ""boolean""
++				},
++				""jsx"": {
++					""description"": ""When down-level compiling, specify JSX code generation: 'preserve' or 'react'."",
++					""enum"": [
++						""preserve"",
++						""react""
++					]
++				},
++				""reactNamespace"": {
++					""description"": ""When down-level compiling, specifies the object invoked for createElement and __spread when targeting 'react' JSX emit."",
+ 					""type"": ""string""
+ 				},
++				""listFiles"": {
++					""description"": ""When down-level compiling, print names of files part of the compilation."",
++					""type"": ""boolean""
++				},
+ 				""mapRoot"": {
+-					""description"": ""Specifies the location where debugger should locate map files instead of generated locations"",
++					""description"": ""When down-level compiling, specifies the location where debugger should locate map files instead of generated locations"",
+ 					""type"": ""string"",
+ 					""format"": ""uri""
+ 				},
+ 				""module"": {
+-					""description"": ""Specify used module type: 'commonjs', 'system', 'umd', 'es6', or 'es2015'. Note: 'amd' is currently not supported."",
++					""description"": ""When down-level compiling, specify module code generation: 'commonjs', 'system', 'umd', 'amd', 'es6', or 'es2015'."",
+ 					""enum"": [
+ 						""commonjs"",
+ 						""umd"",
++						""amd"",
+ 						""system"",
+ 						""es6"",
+ 						""es2015""
+ 					]
+ 				},
+-
++				""newLine"": {
++					""description"": ""When down-level compiling, specifies the end of line sequence to be used when emitting files: 'CRLF' (dos) or 'LF' (unix)."",
++					""enum"": [
++						""CRLF"",
++						""LF""
++					]
++				},
++				""noEmit"": {
++					""description"": ""When down-level compiling, do not emit output."",
++					""type"": ""boolean""
++				},
++				""noEmitHelpers"": {
++					""description"": ""When down-level compiling, do not generate custom helper functions like __extends in compiled output."",
++					""type"": ""boolean""
++				},
++				""noEmitOnError"": {
++					""description"": ""When down-level compiling, do not emit outputs if any type checking errors were reported."",
++					""type"": ""boolean""
++				},
+ 				""noLib"": {
+ 					""description"": ""Do not include the default library file (lib.d.ts)."",
+ 					""type"": ""boolean""
+ 				},
++				""noResolve"": {
++					""description"": ""When down-level compiling, do not add triple-slash references or module import targets to the input files."",","I changed it from
+Do not add triple-slash references or module import targets to the _list of compiled_ files.
+",2016-03-22 12:04:49
+85,"@@ -9,42 +9,132 @@
+ 	""properties"": {
+ 		""compilerOptions"": {
+ 			""type"": ""object"",
+-			""description"": ""Instructs the JavaScript language service how to validate .js files"",
++			""description"": ""Instructs the JavaScript language service how to validate and down level compile .js files"",
+ 			""properties"": {
+ 				""charset"": {
+ 					""description"": ""The character set of the input files"",
+ 					""type"": ""string""
+ 				},
+ 				""diagnostics"": {
+-					""description"": ""Show diagnostic information."",
++					""description"": ""When down-level compiling, show diagnostic information."",
+ 					""type"": ""boolean""
+ 				},
+-				""locale"": {
+-					""description"": ""The locale to use to show error messages, e.g. en-us."",
++				""emitBOM"": {
++					""description"": ""When down-level compiling, emit a UTF-8 Byte Order Mark (BOM) in the beginning of output files."",
++					""type"": ""boolean""
++				},
++				""inlineSourceMap"": {
++					""description"": ""When down-level compiling, emit a single file with source maps instead of having a separate file."",
++					""type"": ""boolean""
++				},
++				""inlineSources"": {
++					""description"": ""When down-level compiling, emit the source alongside the sourcemaps within a single file; requires --inlineSourceMap to be set."",
++					""type"": ""boolean""
++				},
++				""jsx"": {
++					""description"": ""When down-level compiling, specify JSX code generation: 'preserve' or 'react'."",
++					""enum"": [
++						""preserve"",
++						""react""
++					]
++				},
++				""reactNamespace"": {
++					""description"": ""When down-level compiling, specifies the object invoked for createElement and __spread when targeting 'react' JSX emit."",
+ 					""type"": ""string""
+ 				},
++				""listFiles"": {
++					""description"": ""When down-level compiling, print names of files part of the compilation."",
++					""type"": ""boolean""
++				},
+ 				""mapRoot"": {
+-					""description"": ""Specifies the location where debugger should locate map files instead of generated locations"",
++					""description"": ""When down-level compiling, specifies the location where debugger should locate map files instead of generated locations"",
+ 					""type"": ""string"",
+ 					""format"": ""uri""
+ 				},
+ 				""module"": {
+-					""description"": ""Specify used module type: 'commonjs', 'system', 'umd', 'es6', or 'es2015'. Note: 'amd' is currently not supported."",
++					""description"": ""When down-level compiling, specify module code generation: 'commonjs', 'system', 'umd', 'amd', 'es6', or 'es2015'."",
+ 					""enum"": [
+ 						""commonjs"",
+ 						""umd"",
++						""amd"",
+ 						""system"",
+ 						""es6"",
+ 						""es2015""
+ 					]
+ 				},
+-
++				""newLine"": {
++					""description"": ""When down-level compiling, specifies the end of line sequence to be used when emitting files: 'CRLF' (dos) or 'LF' (unix)."",
++					""enum"": [
++						""CRLF"",
++						""LF""
++					]
++				},
++				""noEmit"": {
++					""description"": ""When down-level compiling, do not emit output."",
++					""type"": ""boolean""
++				},
++				""noEmitHelpers"": {
++					""description"": ""When down-level compiling, do not generate custom helper functions like __extends in compiled output."",
++					""type"": ""boolean""
++				},
++				""noEmitOnError"": {
++					""description"": ""When down-level compiling, do not emit outputs if any type checking errors were reported."",
++					""type"": ""boolean""
++				},
+ 				""noLib"": {
+ 					""description"": ""Do not include the default library file (lib.d.ts)."",
+ 					""type"": ""boolean""
+ 				},
++				""noResolve"": {
++					""description"": ""When down-level compiling, do not add triple-slash references or module import targets to the input files."",
++					""type"": ""boolean""
++				},
++				""skipDefaultLibCheck"": {
++					""description"": ""When down-level compiling, do not check for the default library (lib.d.ts)."",","I made up this description (description missing in the tsconfig schema)
+",2016-03-22 12:03:16
+537,"@@ -9,6 +9,7 @@ License:  MIT
+ URL:      https://code.visualstudio.com/
+ Icon:     @@NAME@@.xpm
+ Requires: glibc >= 2.15
++Requires: GConf2",Thanks for the PR! Will this work for both 32 and 64 bit across most distributions? We had some issues with `libXss.so.1` where installation failed because the package was not found in the local package manager..,2016-11-29 22:47:05
+130,"@@ -9,6 +9,7 @@ global.vscodeStart = Date.now();
+ var app = require('electron').app;
+ var fs = require('fs');
+ var path = require('path');
++var product = require('../product.json');","Isn't product.json one level more up?
+",2016-04-21 08:50:30
+684,"@@ -9,8 +9,9 @@ import * as strings from 'vs/base/common/strings';
+ import * as objects from 'vs/base/common/objects';
+ import * as paths from 'vs/base/common/paths';
+ import * as platform from 'vs/base/common/platform';
++import fs = require('fs');","I would put this at the top of the imports as we usually first put node imports than base, editor, platform, workbench",2017-01-18 14:04:47
+72,"@@ -90,16 +91,61 @@ export function getFullExpressionName(expression: debug.IExpression, sessionType
+ }
+ 
+ export class Thread implements debug.IThread {
+-
++	private promisedCallStack: TPromise<debug.IStackFrame[]>;
++	private cachedCallStack: debug.IStackFrame[];
++	private callStackQueried: boolean;
+ 	public stoppedDetails: debug.IRawStoppedDetails;
++	public stopped: boolean;
+ 
+-	constructor(public name: string, public threadId, public callStack: debug.IStackFrame[]) {
++	constructor(public name: string, public threadId) {","Not important - but I personally am not a big fun of using `undefined`. I always try to use `null`, because having one `null` is already bad enough. You do not have to change anything here, but just for the future so you know that is my style.
+",2016-03-16 10:23:35
+77,"@@ -90,16 +91,61 @@ export function getFullExpressionName(expression: debug.IExpression, sessionType
+ }
+ 
+ export class Thread implements debug.IThread {
+-
++	private promisedCallStack: TPromise<debug.IStackFrame[]>;
++	private cachedCallStack: debug.IStackFrame[];
++	private callStackQueried: boolean;
+ 	public stoppedDetails: debug.IRawStoppedDetails;
++	public stopped: boolean;
+ 
+-	constructor(public name: string, public threadId, public callStack: debug.IStackFrame[]) {
++	constructor(public name: string, public threadId) {
++		this.promisedCallStack = undefined;
+ 		this.stoppedDetails = undefined;
++		this.callStackQueried = false;
++		this.cachedCallStack = undefined;
++		this.stopped = false;
+ 	}
+ 
+ 	public getId(): string {
+ 		return `thread:${ this.name }:${ this.threadId }`;
+ 	}
++
++	public clearCallStack(): void {
++		this.promisedCallStack = undefined;
++		this.cachedCallStack = undefined;
++		this.callStackQueried = false;
++	}
++
++	public getCachedCallStack(): debug.IStackFrame[] {
++		return this.cachedCallStack;
++	}
++
++	public getCallStack(debugService: debug.IDebugService): TPromise<debug.IStackFrame[]> {
++		if (!this.stopped) {
++			return TPromise.as([]);
++		}
++		if (!this.callStackQueried) {","I believe the `callStackQueried` flag is superflous and we can remove it. What I propose is to just change line 126 to `if (!this.promisedCallStack)`. This way if we already queried a call to the adapter the original call will be returned and no additional calls will be made. Same as the `ExpressionsContainer` does with `getChildren`
+",2016-03-16 10:41:46
+650,"@@ -90,6 +90,12 @@ interface INativeOpenDialogOptions {
+ 	window?: VSCodeWindow;
+ }
+ 
++interface IConfiguration {",@xwvvvvwx I suggest to move this into `window.ts` including the configuration change listener. I think it is OK to let each window handle this change from within instead of from outside.,2017-01-04 10:53:03
+433,"@@ -90,6 +90,29 @@ function _renderHtml(content: IHTMLContentElement, options: RenderOptions = {}):
+ 		const withInnerHTML = new TPromise(c => signalInnerHTML = c);
+ 
+ 		const renderer = new marked.Renderer();
++		renderer.image = (href: string, title: string, text: string) => {
++			let attributes = '';
++			if (title) {
++				const splitted = title.split('|');
++				title = splitted[0];","Looks like the actual title is getting lost now. Add it back into the attributes
+",2016-11-01 22:18:11
+432,"@@ -90,6 +90,29 @@ function _renderHtml(content: IHTMLContentElement, options: RenderOptions = {}):
+ 		const withInnerHTML = new TPromise(c => signalInnerHTML = c);
+ 
+ 		const renderer = new marked.Renderer();
++		renderer.image = (href: string, title: string, text: string) => {
++			let attributes = '';
++			if (title) {
++				const splitted = title.split('|');
++				title = splitted[0];
++				const parameters = splitted[1];
++				if (parameters) {
++					const heightFromParams = new RegExp(/height=(\d+)/).exec(parameters);","[nit] Just use regexp literal, not `new RegExp`
+",2016-11-01 22:13:50
+434,"@@ -90,6 +90,29 @@ function _renderHtml(content: IHTMLContentElement, options: RenderOptions = {}):
+ 		const withInnerHTML = new TPromise(c => signalInnerHTML = c);
+ 
+ 		const renderer = new marked.Renderer();
++		renderer.image = (href: string, title: string, text: string) => {
++			let attributes = '';
++			if (title) {
++				const splitted = title.split('|');
++				title = splitted[0];
++				const parameters = splitted[1];
++				if (parameters) {
++					const heightFromParams = new RegExp(/height=(\d+)/).exec(parameters);
++					const widthFromParams = new RegExp(/width=(\d+)/).exec(parameters);
++					const height = (heightFromParams && heightFromParams[1]);
++					const width = (widthFromParams && widthFromParams[1]);
++					const dimensions = [];
++					if (width) {","Change this check to `isFinite` to correctly handle zero width/heights
+",2016-11-01 22:20:58
+247,"@@ -90,8 +90,35 @@ export class UserSettings {
+ 	}
+ 
+ 	private registerWatchers(): void {
+-		this.watcher = fs.watch(path.dirname(this.appSettingsPath));
+-		this.watcher.on('change', (eventType: string, fileName: string) => this.onSettingsFileChange(eventType, fileName));
++		let self = this;
++		function attachSettingsChangeWatcher(watchPath: string): void {
++			self.watcher = fs.watch(watchPath);
++			self.watcher.on('change', (eventType: string, fileName: string) => self.onSettingsFileChange(eventType, fileName));","I think onSettingsFileChange ignores eventType and fileName so maybe just remove it from there and invocations.
+",2016-08-09 19:47:26
+248,"@@ -90,8 +90,35 @@ export class UserSettings {
+ 	}
+ 
+ 	private registerWatchers(): void {
+-		this.watcher = fs.watch(path.dirname(this.appSettingsPath));
+-		this.watcher.on('change', (eventType: string, fileName: string) => this.onSettingsFileChange(eventType, fileName));
++		let self = this;
++		function attachSettingsChangeWatcher(watchPath: string): void {
++			self.watcher = fs.watch(watchPath);
++			self.watcher.on('change', (eventType: string, fileName: string) => self.onSettingsFileChange(eventType, fileName));
++		}
++
++		// Attach a watcher to the settings directory
++		attachSettingsChangeWatcher(path.dirname(this.appSettingsPath));
++
++		// Follow symlinks for settings and keybindings and attach watchers if they resolve
++		let followSymlinkPaths = [
++			this.appSettingsPath,
++			this.appKeybindingsPath
++		];
++		followSymlinkPaths.forEach((path) => {
++			fs.lstat(path, function(err, stats) {
++				if (err) {
++					return;
++				}
++				if (stats.isSymbolicLink()) {
++					fs.readlink(path, function(err, realPath) {","What if the symlink is actually a folder? Can you check that the stat is a file?
+",2016-08-09 19:48:07
+701,"@@ -91,8 +91,11 @@ export enum ClickBehavior {
+ 	ON_MOUSE_UP
+ }
+ 
++export type WorkbenchOpenMode = 'singleClick' | 'doubleClick';",I would not call this `WorkbenchXY` but just `OpenMode` since the tree itself is not only used in the workbench scope.,2017-01-20 11:52:36
+825,"@@ -918,4 +922,261 @@ export class ToggleSharedProcessAction extends Action {
+ 	run(): TPromise<void> {
+ 		return this.windowsService.toggleSharedProcess();
+ 	}
+-}
+\ No newline at end of file
++}
++
++export abstract class BaseNavigationAction extends Action {
++
++	protected NEXT = 'next';","@misoguy a bit weird, why not use an enum outside of the action?
+
+```
+enum Direction {
+   Next,
+   Previous
+}
+```",2017-03-14 05:42:36
+824,"@@ -918,4 +922,261 @@ export class ToggleSharedProcessAction extends Action {
+ 	run(): TPromise<void> {
+ 		return this.windowsService.toggleSharedProcess();
+ 	}
+-}
+\ No newline at end of file
++}
++
++export abstract class BaseNavigationAction extends Action {
++
++	protected NEXT = 'next';
++	protected PREVIOUS = 'previous';
++
++	constructor(
++		id: string,
++		label: string,
++		@IEditorGroupService protected groupService: IEditorGroupService,
++		@IPanelService protected panelService: IPanelService,
++		@IPartService protected partService: IPartService,
++		@IViewletService protected viewletService: IViewletService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++
++		const isEditorGroupVertical = this.groupService.getGroupOrientation() === 'vertical';
++		const isSidebarPositionLeft = this.partService.getSideBarPosition() === SidebarPosition.LEFT;
++
++		if (isEditorFocus) {
++			return this.navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isPanelFocus) {
++			return this.navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isSidebarFocus) {
++			return this.navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		return TPromise.as(false);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateToPanel(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.PANEL_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activePanelId = this.panelService.getActivePanel().getId();
++		return this.panelService.openPanel(activePanelId, true);
++	}
++
++	protected navigateToSidebar(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.SIDEBAR_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activeViewletId = this.viewletService.getActiveViewlet().getId();
++		return this.viewletService.openViewlet(activeViewletId, true);
++	}
++
++	protected navigateAcrossEditorGroup(direction: string): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const currentPosition = model.positionOfGroup(model.activeGroup);
++		const nextPosition = direction === this.NEXT ? currentPosition + 1 : currentPosition - 1;
++
++		if (nextPosition < 0 || nextPosition > model.groups.length - 1) {
++			return TPromise.as(false);
++		}
++
++		this.groupService.focusGroup(nextPosition);
++		return TPromise.as(true);
++	}
++
++	protected navigateToLastActiveGroup(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const lastActiveGroup = model.activeGroup;
++		this.groupService.focusGroup(lastActiveGroup);
++		return TPromise.as(true);
++	}
++
++	protected navigateToFirstEditorGroup(): TPromise<any> {
++		this.groupService.focusGroup(0);
++		return TPromise.as(true);
++	}
++
++	protected navigateToLastEditorGroup(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const lastEditorGroupPosition = model.groups.length - 1;
++		this.groupService.focusGroup(lastEditorGroupPosition);
++		return TPromise.as(true);
++	}
++}
++
++export class NavigateLeftAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateLeft';
++	public static LABEL = nls.localize('navigateLeft', ""Navigate Left"");",@misoguy please make sure that these labels are in sync with where you register them (e.g. this one should be `View: Move to the View Part on the Left`).,2017-03-14 05:41:31
+821,"@@ -918,4 +922,261 @@ export class ToggleSharedProcessAction extends Action {
+ 	run(): TPromise<void> {
+ 		return this.windowsService.toggleSharedProcess();
+ 	}
+-}
+\ No newline at end of file
++}
++
++export abstract class BaseNavigationAction extends Action {
++
++	protected NEXT = 'next';
++	protected PREVIOUS = 'previous';
++
++	constructor(
++		id: string,
++		label: string,
++		@IEditorGroupService protected groupService: IEditorGroupService,
++		@IPanelService protected panelService: IPanelService,
++		@IPartService protected partService: IPartService,
++		@IViewletService protected viewletService: IViewletService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++
++		const isEditorGroupVertical = this.groupService.getGroupOrientation() === 'vertical';
++		const isSidebarPositionLeft = this.partService.getSideBarPosition() === SidebarPosition.LEFT;
++
++		if (isEditorFocus) {
++			return this.navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isPanelFocus) {
++			return this.navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isSidebarFocus) {
++			return this.navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		return TPromise.as(false);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateToPanel(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.PANEL_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activePanelId = this.panelService.getActivePanel().getId();
++		return this.panelService.openPanel(activePanelId, true);
++	}
++
++	protected navigateToSidebar(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.SIDEBAR_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activeViewletId = this.viewletService.getActiveViewlet().getId();
++		return this.viewletService.openViewlet(activeViewletId, true);
++	}
++
++	protected navigateAcrossEditorGroup(direction: string): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const currentPosition = model.positionOfGroup(model.activeGroup);
++		const nextPosition = direction === this.NEXT ? currentPosition + 1 : currentPosition - 1;
++
++		if (nextPosition < 0 || nextPosition > model.groups.length - 1) {
++			return TPromise.as(false);
++		}
++
++		this.groupService.focusGroup(nextPosition);
++		return TPromise.as(true);
++	}
++
++	protected navigateToLastActiveGroup(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const lastActiveGroup = model.activeGroup;
++		this.groupService.focusGroup(lastActiveGroup);
++		return TPromise.as(true);
++	}
++
++	protected navigateToFirstEditorGroup(): TPromise<any> {
++		this.groupService.focusGroup(0);
++		return TPromise.as(true);
++	}
++
++	protected navigateToLastEditorGroup(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const lastEditorGroupPosition = model.groups.length - 1;
++		this.groupService.focusGroup(lastEditorGroupPosition);
++		return TPromise.as(true);
++	}
++}
++
++export class NavigateLeftAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateLeft';
++	public static LABEL = nls.localize('navigateLeft', ""Navigate Left"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {","If `isEditorGroupVertical` is `false`, navigate left will navigate to the sidebar, whether the sidebar is on the left or right. However, if `isEditorGroupVertical` is `true` and `isSidebarPositionLeft ` is `false`, it won't navigate to the sidebar on the right. The behavior is not consistent.",2017-03-14 03:43:41
+822,"@@ -918,4 +922,261 @@ export class ToggleSharedProcessAction extends Action {
+ 	run(): TPromise<void> {
+ 		return this.windowsService.toggleSharedProcess();
+ 	}
+-}
+\ No newline at end of file
++}
++
++export abstract class BaseNavigationAction extends Action {
++
++	protected NEXT = 'next';
++	protected PREVIOUS = 'previous';
++
++	constructor(
++		id: string,
++		label: string,
++		@IEditorGroupService protected groupService: IEditorGroupService,
++		@IPanelService protected panelService: IPanelService,
++		@IPartService protected partService: IPartService,
++		@IViewletService protected viewletService: IViewletService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++
++		const isEditorGroupVertical = this.groupService.getGroupOrientation() === 'vertical';
++		const isSidebarPositionLeft = this.partService.getSideBarPosition() === SidebarPosition.LEFT;
++
++		if (isEditorFocus) {
++			return this.navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isPanelFocus) {
++			return this.navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isSidebarFocus) {
++			return this.navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		return TPromise.as(false);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateToPanel(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.PANEL_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activePanelId = this.panelService.getActivePanel().getId();
++		return this.panelService.openPanel(activePanelId, true);
++	}
++
++	protected navigateToSidebar(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.SIDEBAR_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activeViewletId = this.viewletService.getActiveViewlet().getId();
++		return this.viewletService.openViewlet(activeViewletId, true);
++	}
++
++	protected navigateAcrossEditorGroup(direction: string): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const currentPosition = model.positionOfGroup(model.activeGroup);
++		const nextPosition = direction === this.NEXT ? currentPosition + 1 : currentPosition - 1;
++
++		if (nextPosition < 0 || nextPosition > model.groups.length - 1) {
++			return TPromise.as(false);
++		}
++
++		this.groupService.focusGroup(nextPosition);
++		return TPromise.as(true);
++	}
++
++	protected navigateToLastActiveGroup(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const lastActiveGroup = model.activeGroup;
++		this.groupService.focusGroup(lastActiveGroup);
++		return TPromise.as(true);
++	}
++
++	protected navigateToFirstEditorGroup(): TPromise<any> {
++		this.groupService.focusGroup(0);
++		return TPromise.as(true);
++	}
++
++	protected navigateToLastEditorGroup(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		const lastEditorGroupPosition = model.groups.length - 1;
++		this.groupService.focusGroup(lastEditorGroupPosition);
++		return TPromise.as(true);
++	}
++}
++
++export class NavigateLeftAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateLeft';
++	public static LABEL = nls.localize('navigateLeft', ""Navigate Left"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (!isEditorGroupVertical) {
++			return this.navigateToSidebar();
++		}
++		return this.navigateAcrossEditorGroup(this.PREVIOUS)
++			.then(didNavigate => {
++				if (!didNavigate && isSidebarPositionLeft) {
++					return this.navigateToSidebar();
++				}
++				return TPromise.as(true);
++			});
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isSidebarPositionLeft) {
++			return this.navigateToSidebar();
++		}
++		return TPromise.as(false);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isSidebarPositionLeft) {
++			return TPromise.as(false);
++		}
++		if (isEditorGroupVertical) {
++			return this.navigateToLastEditorGroup();
++		}
++		return this.navigateToLastActiveGroup();
++	}
++}
++
++export class NavigateRightAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateRight';
++	public static LABEL = nls.localize('navigateRight', ""Navigate Right"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (!isEditorGroupVertical) {",Same here.,2017-03-14 03:45:58
+809,"@@ -918,4 +922,289 @@ export class ToggleSharedProcessAction extends Action {
+ 	run(): TPromise<void> {
+ 		return this.windowsService.toggleSharedProcess();
+ 	}
+-}
+\ No newline at end of file
++}
++
++export abstract class BaseNavigationAction extends Action {
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService protected editorService: IWorkbenchEditorService,
++		@IEditorGroupService protected groupService: IEditorGroupService,
++		@IPanelService protected panelService: IPanelService,
++		@IPartService protected partService: IPartService,
++		@IViewletService protected viewletService: IViewletService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++
++		const isEditorGroupVertical = this.groupService.getGroupOrientation() === 'vertical';
++		const isSidebarPositionLeft = this.partService.getSideBarPosition() === SidebarPosition.LEFT;
++
++		if (isEditorFocus) {
++			return this.navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isPanelFocus) {
++			return this.navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isSidebarFocus) {
++			return this.navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		return TPromise.as(false);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateToPanel(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.PANEL_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activePanelId = this.panelService.getActivePanel().getId();
++		return this.panelService.openPanel(activePanelId, true);
++	}
++
++	protected navigateToSidebar(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.SIDEBAR_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activeViewletId = this.viewletService.getActiveViewlet().getId();
++		return this.viewletService.openViewlet(activeViewletId, true);
++	}
++
++	protected navigateToLastActiveEditor(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		if (model.groups.length < 1) {
++			return null;
++		}
++
++		const lastGroup = model.activeGroup;
++		const activeEditor = lastGroup.activeEditor;
++		return this.editorService.openEditor(activeEditor, null, model.positionOfGroup(lastGroup));
++	}
++
++	protected navigateToStartOfEditor(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		if (model.groups.length < 1) {
++			return null;
++		}
++
++		const firstGroup = model.getGroup(0);
++		const firstEditor = firstGroup.getEditor(0);
++		return this.editorService.openEditor(firstEditor, null, model.positionOfGroup(firstGroup));
++	}
++
++	protected navigateToEndOfEditor(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		if (model.groups.length < 1) {
++			return null;
++		}
++
++		const lastGroup = model.getGroup(model.groups[model.groups.length - 1].id);
++		const lastEditor = lastGroup.getEditor(lastGroup.count - 1);
++		return this.editorService.openEditor(lastEditor, null, model.positionOfGroup(lastGroup));
++	}
++}
++
++export class NavigateLeftAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateLeft';
++	public static LABEL = nls.localize('navigateLeft', ""Navigate Left"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, editorService, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isEditorGroupVertical) {
++			return this.navigateLeftFromEditor(true, isSidebarPositionLeft);
++		}
++		return this.navigateLeftFromEditor(false, isSidebarPositionLeft);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isSidebarPositionLeft) {
++			return this.navigateToSidebar();
++		}
++		return TPromise.as(false);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isSidebarPositionLeft) {
++			return TPromise.as(false);
++		}
++		if (isEditorGroupVertical) {
++			return this.navigateToEndOfEditor();
++		}
++		return this.navigateToLastActiveEditor();
++	}
++
++	private navigateLeftFromEditor(jumpGroups: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {",Why would we ever not jump groups? I am in a state where I have 2 editors open in one group and navigating left and right jumps between those tabs. My understanding is that this is entirely not about navigating between tabs?,2017-03-10 05:51:42
+810,"@@ -918,4 +922,289 @@ export class ToggleSharedProcessAction extends Action {
+ 	run(): TPromise<void> {
+ 		return this.windowsService.toggleSharedProcess();
+ 	}
+-}
+\ No newline at end of file
++}
++
++export abstract class BaseNavigationAction extends Action {
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService protected editorService: IWorkbenchEditorService,
++		@IEditorGroupService protected groupService: IEditorGroupService,
++		@IPanelService protected panelService: IPanelService,
++		@IPartService protected partService: IPartService,
++		@IViewletService protected viewletService: IViewletService
++	) {
++		super(id, label);
++	}
++
++	public run(): TPromise<any> {
++		const isEditorFocus = this.partService.hasFocus(Parts.EDITOR_PART);
++		const isPanelFocus = this.partService.hasFocus(Parts.PANEL_PART);
++		const isSidebarFocus = this.partService.hasFocus(Parts.SIDEBAR_PART);
++
++		const isEditorGroupVertical = this.groupService.getGroupOrientation() === 'vertical';
++		const isSidebarPositionLeft = this.partService.getSideBarPosition() === SidebarPosition.LEFT;
++
++		if (isEditorFocus) {
++			return this.navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isPanelFocus) {
++			return this.navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		if (isSidebarFocus) {
++			return this.navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft);
++		}
++
++		return TPromise.as(false);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		return TPromise.as(true);
++	}
++
++	protected navigateToPanel(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.PANEL_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activePanelId = this.panelService.getActivePanel().getId();
++		return this.panelService.openPanel(activePanelId, true);
++	}
++
++	protected navigateToSidebar(): TPromise<any> {
++		if (!this.partService.isVisible(Parts.SIDEBAR_PART)) {
++			return TPromise.as(false);
++		}
++
++		const activeViewletId = this.viewletService.getActiveViewlet().getId();
++		return this.viewletService.openViewlet(activeViewletId, true);
++	}
++
++	protected navigateToLastActiveEditor(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		if (model.groups.length < 1) {
++			return null;
++		}
++
++		const lastGroup = model.activeGroup;
++		const activeEditor = lastGroup.activeEditor;
++		return this.editorService.openEditor(activeEditor, null, model.positionOfGroup(lastGroup));
++	}
++
++	protected navigateToStartOfEditor(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		if (model.groups.length < 1) {
++			return null;
++		}
++
++		const firstGroup = model.getGroup(0);
++		const firstEditor = firstGroup.getEditor(0);
++		return this.editorService.openEditor(firstEditor, null, model.positionOfGroup(firstGroup));
++	}
++
++	protected navigateToEndOfEditor(): TPromise<any> {
++		const model = this.groupService.getStacksModel();
++		if (model.groups.length < 1) {
++			return null;
++		}
++
++		const lastGroup = model.getGroup(model.groups[model.groups.length - 1].id);
++		const lastEditor = lastGroup.getEditor(lastGroup.count - 1);
++		return this.editorService.openEditor(lastEditor, null, model.positionOfGroup(lastGroup));
++	}
++}
++
++export class NavigateLeftAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateLeft';
++	public static LABEL = nls.localize('navigateLeft', ""Navigate Left"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, editorService, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isEditorGroupVertical) {
++			return this.navigateLeftFromEditor(true, isSidebarPositionLeft);
++		}
++		return this.navigateLeftFromEditor(false, isSidebarPositionLeft);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isSidebarPositionLeft) {
++			return this.navigateToSidebar();
++		}
++		return TPromise.as(false);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isSidebarPositionLeft) {
++			return TPromise.as(false);
++		}
++		if (isEditorGroupVertical) {
++			return this.navigateToEndOfEditor();
++		}
++		return this.navigateToLastActiveEditor();
++	}
++
++	private navigateLeftFromEditor(jumpGroups: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		const model = this.groupService.getStacksModel();
++		let result = model.previous(jumpGroups, false);
++		if (result) {
++			return this.editorService.openEditor(result.editor, null, model.positionOfGroup(result.group))
++				.then(ok => true);
++		}
++		if (isSidebarPositionLeft) {
++			return this.navigateToSidebar();
++		}
++		return TPromise.as(false);
++	}
++}
++
++export class NavigateRightAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateRight';
++	public static LABEL = nls.localize('navigateRight', ""Navigate Right"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, editorService, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isEditorGroupVertical) {
++			return this.navigateRightFromEditor(true, isSidebarPositionLeft);
++		}
++		return this.navigateRightFromEditor(false, isSidebarPositionLeft);
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (!isSidebarPositionLeft) {
++			return this.navigateToSidebar();
++		}
++		return TPromise.as(false);
++	}
++
++	protected navigateOnSidebarFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (!isSidebarPositionLeft) {
++			return TPromise.as(false);
++		}
++		if (isEditorGroupVertical) {
++			return this.navigateToStartOfEditor();
++		}
++		return this.navigateToLastActiveEditor();
++	}
++
++	private navigateRightFromEditor(jumpGroups: boolean, isSidebarPositionLeft: boolean): TPromise<boolean> {
++		const model = this.groupService.getStacksModel();
++		let result = model.next(jumpGroups, false);
++		if (result) {
++			return this.editorService.openEditor(result.editor, null, model.positionOfGroup(result.group))
++				.then(ok => true);
++		}
++		if (!isSidebarPositionLeft) {
++			return this.navigateToSidebar();
++		}
++		return TPromise.as(false);
++	}
++}
++
++export class NavigateUpAction extends BaseNavigationAction {
++
++	public static ID = 'workbench.action.navigateUp';
++	public static LABEL = nls.localize('navigateUp', ""Navigate Up"");
++
++	constructor(
++		id: string,
++		label: string,
++		@IWorkbenchEditorService editorService: IWorkbenchEditorService,
++		@IEditorGroupService groupService: IEditorGroupService,
++		@IPanelService panelService: IPanelService,
++		@IPartService partService: IPartService,
++		@IViewletService viewletService: IViewletService
++	) {
++		super(id, label, editorService, groupService, panelService, partService, viewletService);
++	}
++
++	protected navigateOnEditorFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isEditorGroupVertical) {
++			return TPromise.as(false);
++		}
++		return this.navigateUpFromEditor();
++	}
++
++	protected navigateOnPanelFocus(isEditorGroupVertical, isSidebarPositionLeft): TPromise<boolean> {
++		if (isEditorGroupVertical) {
++			return this.navigateToLastActiveEditor();
++		}
++		return this.navigateToEndOfEditor();
++	}
++
++	private navigateUpFromEditor(): TPromise<boolean> {
++		const model = this.groupService.getStacksModel();
++		const position = model.positionOfGroup(model.activeGroup);
++		this.groupService.focusGroup(position - 1);
++		return TPromise.as(true);
++	}
++}
++
++export class NavigateDownAction extends BaseNavigationAction {",Should we navigate down to the panel when focus is in the sidebar? Currently that is not happening.,2017-03-10 05:53:24
+62,"@@ -92,13 +95,23 @@ export class ExtHostAPIImplementation {
+ 	constructor(
+ 		@IThreadService threadService: IThreadService,
+ 		@IPluginService pluginService: IPluginService,
+-		@IWorkspaceContextService contextService: IWorkspaceContextService
++		@IWorkspaceContextService contextService: IWorkspaceContextService,
++		@ITelemetryService telemetryService: ITelemetryService
+ 	) {
+ 		this._pluginService = pluginService;
+ 		this._threadService = threadService;
++		this._telemetryService = telemetryService;
+ 		this._proxy = threadService.getRemotable(MainProcessVSCodeAPIHelper);
+ 
+ 		this.version = contextService.getConfiguration().env.version;
++		this._telemetryService.getTelemetryInfo().then((info) => {
++			this.env = {
++				machineId: info.machineId,
++				sessionId: info.sessionId,
++				locale: null","this is not good. either fill in or don't have it yet - i'll tackle
+",2016-01-22 08:32:11
+789,"@@ -92,4 +93,24 @@ export function detectEncodingByBOMFromBuffer(buffer: NodeBuffer, bytesRead: num
+  */
+ export function detectEncodingByBOM(file: string): TPromise<string> {
+ 	return stream.readExactlyByFile(file, 3).then(({buffer, bytesRead}) => detectEncodingByBOMFromBuffer(buffer, bytesRead));
++}
++
++const IGNORE_ENCODINGS = ['ascii', 'utf-8', 'utf-16', 'urf-32'];","This meant to be ""utf-32"" instead of ""urf-32"", right?",2017-03-02 12:23:01
+969,"@@ -920,6 +920,9 @@ class TaskService extends EventEmitter implements ITaskService {
+ 	}
+ 
+ 	private executeTask(task: Task, resolver: ITaskResolver): TPromise<ITaskSummary> {
++		if (!this.storageService.get('userRanTask', StorageScope.GLOBAL)) {","Add some variable for this, see RecentlyUsedTasks_Key ",2017-06-12 23:39:55
+493,"@@ -928,6 +928,17 @@ export class EditorPart extends Part implements IEditorPart, IEditorGroupService
+ 			};
+ 		});
+ 
++		// Add any untitled files to be restored from backup","@Tyriar again this would not be needed if we had untitled editor factory.
+",2016-11-15 06:01:40
+202,"@@ -93,6 +93,12 @@ export default class Webview {
+ 					this._webview.style.opacity = '';
+ 					return;
+ 				}
++			}),
++			addDisposableListener(this._webview, EventType.DRAG_OVER, (event: DragEvent) => {
++				event.stopImmediatePropagation();
++			}),","this leaks a listener
+",2016-07-07 06:28:29
+203,"@@ -93,6 +93,12 @@ export default class Webview {
+ 					this._webview.style.opacity = '';
+ 					return;
+ 				}
++			}),
++			addDisposableListener(this._webview, EventType.DRAG_OVER, (event: DragEvent) => {
++				event.stopImmediatePropagation();
++			}),
++			addDisposableListener(this._webview, EventType.DROP, (event: DragEvent) => {
++				event.stopImmediatePropagation();","same
+
+@bpasero I this a change you agree with? I haven't been involved in any dnd thing
+",2016-07-07 06:28:47
+71,"@@ -93,7 +93,7 @@ class VariablesView extends viewlet.CollapsibleViewletView {
+ 		this.toDispose.push(this.debugService.addListener2(debug.ServiceEvents.STATE_CHANGED, () => {","Looks good.
+",2016-03-16 10:21:36
+16,"@@ -941,9 +941,10 @@ export abstract class BaseSyncAction extends GitAction {
+ export class SyncAction extends BaseSyncAction {
+ 
+ 	static ID = 'workbench.action.sync';
++	static LABEL = nls.localize('sync', ""Sync"");
+ 
+-	constructor(@IGitService gitService: IGitService) {
+-		super(SyncAction.ID, nls.localize('sync', ""Sync""), 'git-action sync', gitService);
++	constructor(id: string, label: string, @IGitService gitService: IGitService) {","Make `id` and `label` optional with predefined values of `GitActions.SyncAction.ID` and `GitActions.SyncAction.LABEL` instead of polluting that...
+",2015-11-25 15:13:01
+795,"@@ -944,6 +944,16 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 		return this._groups.indexOf(group);
+ 	}
+ 
++	public findGroup(editorInput: EditorInput, activeOnly: Boolean): EditorGroup {",`Boolean` => `boolean`,2017-03-07 06:15:27
+796,"@@ -944,6 +944,16 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 		return this._groups.indexOf(group);
+ 	}
+ 
++	public findGroup(editorInput: EditorInput, activeOnly: Boolean): EditorGroup {
++		const found = this.groups.filter(group =>","I suggest to change this logic a) for perf reasons and b) for logical reasons
+
+a) Perf: I suggest to simply use 2 for loops here to avoid iterating over all groups and all editors even if a match has found. With the current logic, if the editor is found in group 1 you will still iterate over all other groups and editors even though we only return one result.
+
+b) Logic: there is always an active group and that group might not be group 1. Wouldn't it make more sense to start with the currently active group to look for the editor and then check the others? This means we prefer to reveal an editor in the currently active group if we find it. Another solution would be to prefer an editor if it is already visible in one of the groups. You have to decide after all how this option should behave:
+* does it prefer active editors over inactive
+* does it prefer active groups over inactive
+* does it prefer strict spatial order of the groups (left to right)",2017-03-07 06:18:39
+798,"@@ -944,6 +944,16 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 		return this._groups.indexOf(group);
+ 	}
+ 
++	public findGroup(editorInput: EditorInput, activeOnly: Boolean): EditorGroup {
++		const found = this.groups.filter(group =>
++			group.getEditors().some(editor => {
++				const isActive = group.isActive(editor);
++				return editor.matches(editorInput)",You should first check for the `isActive` condition and then do the `editor.matches` call to avoid it unless needed.,2017-03-07 06:21:05
+797,"@@ -944,6 +944,16 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 		return this._groups.indexOf(group);
+ 	}
+ 
++	public findGroup(editorInput: EditorInput, activeOnly: Boolean): EditorGroup {
++		const found = this.groups.filter(group =>
++			group.getEditors().some(editor => {
++				const isActive = group.isActive(editor);
++				return editor.matches(editorInput)
++					&& (!activeOnly || isActive);
++			}));
++		return found[0] || null;","It is fine to return `undefined` instead of `null`, you do not need to do an explicit `|| null`.",2017-03-07 06:19:31
+232,"@@ -944,6 +944,7 @@ export class Cursor extends EventEmitter {
+ 
+ 		this._handlers[H.JumpToBracket] =				(ctx) => this._jumpToBracket(ctx);
+ 
++		this._handlers[H.CursorMove] = 					(ctx) => this._move(false, ctx);","Please rename the method `_move` to `_cursorMove` to easily find it and not get confused with the previous moveTo
+",2016-07-15 11:22:11
+858,"@@ -945,6 +945,12 @@ declare module 'vscode' {
+ 		viewColumn?: ViewColumn;
+ 
+ 		/**
++		 * The diff information for this text editor. Will be `udnefined` in case",udnefined,2017-03-24 09:49:40
+642,"@@ -95,6 +95,19 @@ class InsertCursorAtEndOfEachLineSelected extends EditorAction {
+ 				});
+ 			}
+ 		}
+-		editor.setSelections(newSelections);
++		return newSelections;
++	}
++
++	public run(accessor: ServicesAccessor, editor: ICommonCodeEditor): void {
++		let newSelections = new Array<ISelection>();
++		let selections = editor.getSelections();
++
++		for (var i = 0; i < selections.length; ++i) {","This can be simplified to `let newSelections = selections.map(selection => this.getCursorsForSelection(selection, editor));`",2016-12-23 04:06:31
+126,"@@ -95,6 +96,26 @@ function getNLSConfiguration() {
+ 	return { locale: initialLocale, availableLanguages: {} };
+ }
+ 
++function migrateUserDataDir(newDir) {
++	var oldDir = path.join(process.env.HOME, '.config', product.nameShort);","Why do you need to compute the old dir? Is it not much safer to use app.getPath('userData')
+",2016-04-21 08:45:31
+127,"@@ -95,6 +96,26 @@ function getNLSConfiguration() {
+ 	return { locale: initialLocale, availableLanguages: {} };
+ }
+ 
++function migrateUserDataDir(newDir) {
++	var oldDir = path.join(process.env.HOME, '.config', product.nameShort);
++	if (!fs.existsSync(oldDir)) {
++		return;","I am not sure this test holds, please verify. My understanding is that Chrome might create this folder very early, so please test it.
+",2016-04-21 08:46:10
+128,"@@ -95,6 +96,26 @@ function getNLSConfiguration() {
+ 	return { locale: initialLocale, availableLanguages: {} };
+ }
+ 
++function migrateUserDataDir(newDir) {
++	var oldDir = path.join(process.env.HOME, '.config', product.nameShort);
++	if (!fs.existsSync(oldDir)) {
++		return;
++	}
++	mkdirp(path.dirname(newDir));
++	fs.renameSync(oldDir, newDir);","Please note that rename does not work if source and target are on different drives. I think we need to add a lot more error handling to your code so that in case of an issue we can show something useful to the user.
+",2016-04-21 08:46:54
+129,"@@ -95,6 +96,26 @@ function getNLSConfiguration() {
+ 	return { locale: initialLocale, availableLanguages: {} };
+ }
+ 
++function migrateUserDataDir(newDir) {
++	var oldDir = path.join(process.env.HOME, '.config', product.nameShort);
++	if (!fs.existsSync(oldDir)) {
++		return;
++	}
++	mkdirp(path.dirname(newDir));
++	fs.renameSync(oldDir, newDir);
++}
++
++function mkdirp(newDir) {
++	var stack = [];
++	while (!fs.existsSync(newDir)) {
++		stack.push(newDir);
++		newDir = path.dirname(newDir);
++	}
++	while (stack.length > 0) {
++		fs.mkdirSync(stack.pop());
++	}
++}
++","Please review this with https://github.com/Microsoft/vscode/blob/master/src/vs/base/node/extfs.ts#L51 there are some interesting issues with mkdirp
+",2016-04-21 08:49:03
+157,"@@ -955,6 +976,34 @@ export class Parser {
+ 		return null;
+ 	}
+ 
++	public _parseCssVariable(): nodes.Variable {
++		var node = <nodes.Variable> this.create(nodes.Variable);
++		if (!this.accept(scanner.TokenType.CssVariableName)) {
++			return null;
++		}
++		return <nodes.Variable> node;
++	}
++
++	public _parseVariableExpression(): nodes.Node {
++		if (!this.accept(scanner.TokenType.Var)) {
++			return null;
++		}
++
++		var node= this.createNode(nodes.NodeType.VariableExpression);
++		if (!this.accept(scanner.TokenType.ParenthesisL)) {
++			return this.finish(node, errors.ParseError.LeftParenthesisExpected);
++		}
++
++		if (!node.addChild(this._parseCssVariable())) {
++			return this.finish(node, errors.ParseError.VariableValueExpected);
++		}
++
++		if (!this.accept(scanner.TokenType.ParenthesisR)) {","The var syntax also allows extra parameters (default values).
+see https://drafts.csswg.org/css-variables/#using-variables, example 10.
+
+As mentioned I'd just use the regular _parseFunction for that.
+",2016-05-20 10:27:09
+530,"@@ -96,4 +96,70 @@ export function readExactlyByFile(file: string, totalBytes: number, callback: (e
+ 
+ 		loop();
+ 	});
++}
++
++/**
++ * Reads a file until a matching string is found.
++ *
++ * @param file The file to read.
++ * @param matchingString The string to search for.
++ * @param chunkBytes The number of bytes to read each iteration.
++ * @param maximumBytesToRead The maximum number of bytes to read before giving up.
++ * @param callback The finished callback.
++ */
++export function readToMatchingString(file: string, matchingString: string, chunkBytes: number, maximumBytesToRead: number, callback: (error: Error, result: string) => void): void {
++	fs.open(file, 'r', null, (err, fd) => {
++		if (err) {
++			return callback(err, null);
++		}
++
++		function end(err: Error, result: string): void {
++			fs.close(fd, (closeError: Error) => {
++				if (closeError) {
++					return callback(closeError, null);
++				}
++
++				if (err && (<any>err).code === 'EISDIR') {
++					return callback(err, null); // we want to bubble this error up (file is actually a folder)
++				}
++
++				return callback(null, result);
++			});
++		}
++
++		let buffer = new Buffer(maximumBytesToRead);
++		let bytesRead = 0;
++		let zeroAttempts = 0;
++		function loop(): void {
++			fs.read(fd, buffer, bytesRead, chunkBytes, null, (err, moreBytesRead) => {
++				if (err) {
++					return end(err, null);
++				}
++
++				// Retry up to N times in case 0 bytes where read
++				if (moreBytesRead === 0) {
++					if (++zeroAttempts === 10) {
++						return end(null, null);
++					}
++
++					return loop();
++				}
++
++				bytesRead += moreBytesRead;
++
++				const newLineIndex = buffer.indexOf(matchingString);
++				if (buffer.indexOf('\n') >= 0) {",@Tyriar is this an oversight? why suddenly you look for `\n` and call it `newLineIndex` if `matchingString` can be anything?,2016-11-29 05:14:26
+526,"@@ -96,6 +102,9 @@ export class TerminalService implements ITerminalService {
+ 		if (wasActiveInstance && this.terminalInstances.length > 0) {
+ 			let newIndex = index < this.terminalInstances.length ? index : this.terminalInstances.length - 1;
+ 			this.setActiveInstanceByIndex(newIndex);
++			if (terminalInstance.hadFocusOnExit) {",Love it! :+1: ,2016-11-28 19:09:43
+819,"@@ -96,7 +96,7 @@ export class TerminalConfigHelper implements ITerminalConfigHelper {
+ 		return DEFAULT_ANSI_COLORS[baseThemeId];
+ 	}
+ 
+-	private _measureFont(fontFamily: string, fontSize: number, lineHeight: number): ITerminalFont {
++	private _measureFont(fontFamily: string, fontSize: number, lineHeight: number, fontWeight: string): ITerminalFont {",It's fine to leave out font weight from font measurement as the terminal assumes we're working with a monospace font where bold size is the same as non-bold size.,2017-03-12 01:55:51
+639,"@@ -968,6 +968,17 @@ declare module 'vscode' {
+ 		edit(callback: (editBuilder: TextEditorEdit) => void, options?: { undoStopBefore: boolean; undoStopAfter: boolean; }): Thenable<boolean>;
+ 
+ 		/**
++		 * Inserts the given snippet template and enters snippet mode.
++		 *
++		 * If the editor is already in snippet mode, insertion fails and the returned promise resolves to false.
++		 *
++		 * @param template The snippet template to insert
++		 * @param posOrRange The position or replacement range representing the location of the insertion.
++		 * @return A promise that resolves with a value indicating if the snippet could be inserted.
++		 */
++		insertSnippet(template: string, posOrRange: Position | Range): Thenable<boolean>;","* template should be of type `SnippetString`
+* Unsure about `posOrRange` - we should consider using the current editor selection/selections. That would allow to insert snippets in multiple locations at the same time. Also inserting snippets is highly interactive, so it's fair to use the current selection for that (or change the selection first).
+* We should consider making this an overload of the `edit` method",2016-12-21 08:21:30
+807,"@@ -975,7 +975,7 @@ export class EditorStacksModel implements IEditorStacksModel {
+ 		return this._groups[position];
+ 	}
+ 
+-	public next(jumpGroups: boolean): IEditorIdentifier {
++	public next(jumpGroups: boolean, cycleAtEnd = true): IEditorIdentifier {",Please add a test for this in `editorStacksModel.test.ts`,2017-03-10 05:44:57
+5,"@@ -979,10 +979,17 @@ export class TextModel extends OrderGuaranteeEventEmitter implements EditorCommo
+ 
+ 	private _findMatchesInLine(searchRegex:RegExp, text:string, lineNumber:number, deltaOffset:number, counter:number, result:EditorCommon.IEditorRange[], limitResultCount:number): number {
+ 		var m:RegExpExecArray;
++		// Reset regex to search from the beginning
++		searchRegex.lastIndex = 0;
+ 		do {
+ 			m = searchRegex.exec(text);
+ 			if (m) {
+-				result.push(new Range(lineNumber, m.index + 1 + deltaOffset, lineNumber, m.index + 1 + m[0].length + deltaOffset));
++				var range = new Range(lineNumber, m.index + 1 + deltaOffset, lineNumber, m.index + 1 + m[0].length + deltaOffset);","Why use `var` in TS when `let` and `const` are available?
+",2015-11-20 23:27:43
+300,"@@ -98,6 +103,10 @@ const Identifiers = {
+ 	STATUSBAR_PART: 'workbench.parts.statusbar'
+ };
+ 
++const ExposedWindowOptions = {","Just inline this one and avoid the const
+",2016-10-05 06:51:43
+21,"@@ -99,7 +105,23 @@ export class ShiftCommand implements EditorCommon.ICommand {
+ 				indents[j] = indents[j-1] + oneIndent;
+ 			}
+ 
+-			builder.addEditOperation(new Range(lineNumber, 1, lineNumber, indentationEndIndex + 1), indents[desiredIndentCount]);
++			var desiredIndent = indents[desiredIndentCount];
++			if (isMultilineComment) {
++				// Add space to align the multiline comment
++				desiredIndent += "" "";
++			}
++
++			// Check whether we're in a multiline comment or not
++			if (lineText.length >= 2 + indentationEndIndex) {
++				if (lineText.indexOf(""/*"") === indentationEndIndex) {
++					isMultilineComment = true;
++				}
++				if (lineText.indexOf(""*/"") !== -1) {","[minor] You can pass the start index in the call to indexOf. Will reduce atleast 2 comparisons. 
+",2015-12-04 05:30:10
diff --git a/data/msg-test.csv b/data/msg-test.csv
new file mode 100644
index 0000000..bf8cbec
--- /dev/null
+++ b/data/msg-test.csv
@@ -0,0 +1,122419 @@
+,diff_hunk,human_review
+0,"@@ -53,7 +53,7 @@ public class ProtocGapicPluginGeneratorTest {
+                 model.getFiles().stream().map(ProtoFile::getProto).collect(Collectors.toList()))
+             // Only the file to generate a client for (don't generate dependencies)
+             .addFileToGenerate(""multiple_services.proto"")
+-            .setParameter(""language=java"")
++            .setParameter(""language=java,transport=grpc"")
+             .build();
+
+     CodeGeneratorResponse response = ProtocGeneratorMain.generate(codeGeneratorRequest);",can we also test for `transport=rest`?
+1,"@@ -182,7 +182,9 @@ abstract class AbstractSolrBackendFactory implements FactoryInterface
+      */
+     protected function createBackend(Connector $connector)
+     {
++        $config = $this->config->get($this->mainConfig);
+         $backend = new $this->backendClass($connector);
++        $backend->setPageSize($config->Index->record_batch_size);
+         $backend->setQueryBuilder($this->createQueryBuilder());
+         $backend->setSimilarBuilder($this->createSimilarBuilder());
+         if ($this->logger) {","If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`)."
+2,"@@ -1,6 +1,6 @@
+ <script type=""text/javascript"">
+   window.analytics||(window.analytics=[]),window.analytics.methods=[""identify"",""track"",""trackLink"",""trackForm"",""trackClick"",""trackSubmit"",""page"",""pageview"",""ab"",""alias"",""ready"",""group"",""on"",""once"",""off""],window.analytics.factory=function(t){return function(){var a=Array.prototype.slice.call(arguments);return a.unshift(t),window.analytics.push(a),window.analytics}};for(var i=0;i<window.analytics.methods.length;i++){var method=window.analytics.methods[i];window.analytics[method]=window.analytics.factory(method)}window.analytics.load=function(t){var a=document.createElement(""script"");a.type=""text/javascript"",a.async=!0,a.src=(""https:""===document.location.protocol?""https://"":""http://"")+""d2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/""+t+""/analytics.min.js"";var n=document.getElementsByTagName(""script"")[0];n.parentNode.insertBefore(a,n)},window.analytics.SNIPPET_VERSION=""2.0.8"",
+-  window.analytics.load(""2nexpdgku3"");
++  window.analytics.load(<%= ENV['SEGMENT_KEY']%>);
+   window.analytics.page();
+ </script>
+ ","I didn't realize we were hardcoding this, thanks for moving it to an env value."
+3,"@@ -99,7 +99,7 @@ module.exports = function fileItem (props) {
+         }
+       </h4>
+       <div class=""UppyDashboardItem-status"">
+-        ${file.data.size && html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
++        ${isNaN(file.data.size) ? '' : html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
+         ${file.source && html`<div class=""UppyDashboardItem-sourceIcon"">
+             ${acquirers.map(acquirer => {
+               if (acquirer.id === file.source) return html`<span title=""${props.i18n('fileSource')}: ${acquirer.name}"">${acquirer.icon()}</span>`","We are trying to support IE 10-11, so we'll need a polyfill for this one, I think."
+4,"@@ -38,6 +38,9 @@ const { useSelect, useDispatch } = Data;
+ function ResetButton( { children } ) {
+ 	const postResetURL = useSelect( ( select ) => select( CORE_SITE ).getAdminURL( 'googlesitekit-splash', { notification: 'reset_success' } ) );
+
++	const isNavigating = useSelect( ( select ) => select( CORE_LOCATION ).isNavigating() );
++	const navigatingURL = useSelect( ( select ) => select( CORE_LOCATION ).getNavigateURL() );
++
+ 	const [ dialogActive, setDialogActive ] = useState( false );
+
+ 	useEffect( () => {",It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with.
+5,"@@ -29,8 +29,8 @@
+
+ namespace lbann {
+
+-void im2col(const Mat& im,
+-            Mat& col,
++void im2col(const AbsMat& im,
++            AbsMat& col,
+             const int num_channels,
+             const int im_num_dims,
+             const int * im_dims,",I think im2col should only accommodate CPUMat.
+6,"@@ -24,6 +24,8 @@ from google.cloud.forseti.notifier.notifiers import cscc_notifier
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+ from google.cloud.forseti.services.inventory.storage import DataAccess
+ from google.cloud.forseti.services.scanner import dao as scanner_dao
++from google.cloud.forseti.common.util.email.email_factory import EmailFactory
++from google.cloud.forseti.notifier.notifiers import email_violations
+ # pylint: enable=line-too-long
+
+ ",alpha sort the imports
+7,"@@ -1067,7 +1067,7 @@ fpga_result mmio_error(struct RASCommandLine *rasCmdLine)
+ 	if ( rasCmdLine->function >0 )
+ 		function = rasCmdLine->bus;
+
+-	snprintf(sysfs_path, sizeof(sysfs_path),
++	snprintf_s_iiii(sysfs_path, sizeof(sysfs_path),
+ 			DEVICEID_PATH,0,bus,device,function);
+
+ 	result = sysfs_read_u64(sysfs_path, &value);",Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?
+8,"@@ -219,7 +219,19 @@ def internal_keyDownEvent(vkCode,scanCode,extended,injected):
+ 			for k in range(256):
+ 				keyStates[k]=ctypes.windll.user32.GetKeyState(k)
+ 			charBuf=ctypes.create_unicode_buffer(5)
++			# First try getting the keyboard layout from the thread with the focus (input thread)
+ 			hkl=ctypes.windll.user32.GetKeyboardLayout(focus.windowThreadID)
++			if not hkl:
++				log.debug(""Failed to fetch keyboard layout from focus, trying layout from last detected change"")
++				# Some threads, such as for Windows consoles
++				# Do not allow getKeyboardLayout to work.
++				# Therefore, use the cached keyboard layout from the last inputLangChange detected by NVDA
++				# on the foreground object.
++				hkl = getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)
++				if not hkl:
++					log.debug(""No layout cached, falling back to layout of NVDA main thread"")
++					# As a last resort, use the keyboard layout of NVDA's main thread.
++					hkl = ctypes.windll.user32.GetKeyboardLayout(core.mainThreadId)
+ 			# In previous Windows builds, calling ToUnicodeEx would destroy keyboard buffer state and therefore cause the app to not produce the right WM_CHAR message.
+ 			# However, ToUnicodeEx now can take a new flag of 0x4, which stops it from destroying keyboard state, thus allowing us to safely call it here.
+ 			res=ctypes.windll.user32.ToUnicodeEx(vkCode,scanCode,keyStates,charBuf,len(charBuf),0x4,hkl)",How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?
+9,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)
+10,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below
+11,"@@ -39,6 +39,7 @@ func (p *Provisioner) ProvisionHostPath(opts pvController.VolumeOptions, volumeC
+ 	name := opts.PVName
+ 	stgType := volumeConfig.GetStorageType()
+ 	saName := getOpenEBSServiceAccountName()
++	shared := volumeConfig.GetSharedMountValue()
+
+ 	path, err := volumeConfig.GetPath()
+ 	if err != nil {","n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code."
+12,"@@ -85,7 +85,10 @@ export class ManualColumnFreeze extends BasePlugin {
+   }
+
+   /**
+-   * Freezes the given column (add it to fixed columns).
++   * Freezes the specified column (i.e. adds it to fixed columns).
++   *
++   * `freezeColumn()` doesn't re-render the table,
++   * so you need to call the `render()` method afterward.
+    *
+    * @param {number} column Visual column index.
+    */",I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax
+13,"@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace
+         private void RunGetRequestedDataOtherSampler(Activity activity)
+         {
+             ActivityContext parentContext;
+-            if (string.IsNullOrEmpty(activity.ParentId))
++            if (string.IsNullOrEmpty(activity.ParentId) || activity.ParentSpanId.ToHexString().Equals(""0000000000000000""))
+             {
+                 parentContext = default;
+             }","this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed."
+14,"@@ -114,11 +114,16 @@ func (w *watcher) run(ctx context.Context, provider imageprovider.Provider, inte
+ 				updates = append(updates, u...)
+ 			}
+ 			if len(updates) == 0 {
+-				w.logger.Info(""no image to be updated"")
++				w.logger.Info(""no image to be updated"",
++					zap.String(""image-provider"", provider.Name()),
++				)
+ 				continue
+ 			}
+ 			if err := update(updates); err != nil {
+-				w.logger.Error(""failed to update image"", zap.Error(err))
++				w.logger.Error(""failed to update image"", zap.String(""image-provider"",
++					provider.Name()),
++					zap.Error(err),
++				)
+ 				continue
+ 			}
+ 		}","`zap.String(""image-provider"", provider.Name())` should be in a same line."
+15,"@@ -1,8 +1,6 @@
+ /*exported DqElement */
+
+ function truncate(str, maxLength) {
+-	'use strict';
+-
+ 	maxLength = maxLength || 300;
+
+ 	if (str.length > maxLength) {",Why this deletion?
+16,"@@ -419,7 +419,10 @@ class S3KeyTest(unittest.TestCase):
+         remote_metadata = check._get_remote_metadata()
+
+         # TODO: investigate whether encoding ' ' as '%20' makes sense
+-        self.assertEqual(check.cache_control, 'public,%20max-age=500')
++        self.assertIn(
++            check.cache_control,
++            ('public,%20max-age=500', 'public, max-age=500')
++        )
+         self.assertEqual(remote_metadata['cache-control'], 'public,%20max-age=500')
+         self.assertEqual(check.get_metadata('test-plus'), 'A plus (+)')
+         self.assertEqual(check.content_disposition, 'filename=Sch%C3%B6ne%20Zeit.txt')",This change looks unrelated to the CL description?
+17,"@@ -18,7 +18,7 @@ class DedupTest : public QueryTestBase {
+   void SetUp() override { QueryTestBase::SetUp(); }
+ };
+
+-#define DEDUP_RESUTL_CHECK(inputName, outputName, sentence, expected)                   \
++#define DEDUP_RESULT_CHECK(inputName, outputName, sentence, expected)                   \
+   do {                                                                                  \
+     qctx_->symTable()->newVariable(outputName);                                         \
+     auto yieldSentence = getYieldSentence(sentence, qctx_.get());                       \",I'm not certain that `res`+`utl` isn't a thing.
+18,"@@ -182,6 +182,7 @@ public class FetchActiveFlowDao {
+             + "" LEFT JOIN ""
+             + "" executors et ON ex.executor_id = et.id""
+             + "" WHERE ex.status NOT IN (""
++            + Status.EXECUTION_STOPPED.getNumVal() + "", ""
+             + Status.SUCCEEDED.getNumVal() + "", ""
+             + Status.KILLED.getNumVal() + "", ""
+             + Status.FAILED.getNumVal() + "")"";","This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List<Integer> list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, "",""); You can use it at multiple places shown in this diff."
+19,"@@ -23,7 +23,10 @@ void wlr_input_device_init(struct wlr_input_device *dev,
+ }
+
+ void wlr_input_device_destroy(struct wlr_input_device *dev) {
+-	if (!dev) return;
++	if (!dev) {
++		return;
++	}
++
+ 	if (dev->_device) {
+ 		switch (dev->type) {
+ 		case WLR_INPUT_DEVICE_KEYBOARD:",Merge with next condition
+20,"@@ -348,6 +348,7 @@ type appResourcesGetter interface {
+
+ type taskDeployer interface {
+ 	DeployTask(input *deploy.CreateTaskResourcesInput, opts ...cloudformation.StackOption) error
++	DeleteTask(task deploy.TaskStackInfo) error
+ }
+
+ type taskRunner interface {",Maybe add it when it is used.
+21,"@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
+     {'name': 'cloudsql_acl', 'enabled': False},
+     {'name': 'iam_policy', 'enabled': True}
+ ]}
++
++NONEXIST_ENABLED = {'scanners': [
++    {'name': 'bigquery', 'enabled': False},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': False},
++    {'name': 'non_exist_scanner', 'enabled': True}
++]}
++
++ALL_EXIST = {'scanners': [
++    {'name': 'bigquery', 'enabled': True},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': True},
++    {'name': 'iam_policy', 'enabled': True}
++]}",More clear naming: NONEXISTENT_ENABLED
+22,"@@ -282,10 +282,10 @@ public class TypeUtil {
+
+     switch (from.typeId()) {
+       case INTEGER:
+-        return to == Types.LongType.get();
++        return to.equals(Types.LongType.get());
+
+       case FLOAT:
+-        return to == Types.DoubleType.get();
++        return to.equals(Types.DoubleType.get());
+
+       case DECIMAL:
+         Types.DecimalType fromDecimal = (Types.DecimalType) from;",why is this change necessary?
+23,"@@ -178,9 +178,8 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter {
+
+   @Override
+   public String getFullNameFor(TypeModel type) {
+-    // TODO(andrealin): Remove this hack when null response types are implemented.
+-    if (type == null) {
+-      return ""nullFullName"";
++    if (type.isEmptyType()) {
++      return ""java.lang.Void"";
+     }
+     if (type instanceof DiscoveryRequestType) {
+       Method method = ((DiscoveryRequestType) type).parentMethod().getDiscoMethod();",make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here.
+24,"@@ -26,7 +26,10 @@ class TinyMCELanguage extends AbstractSmartyPlugin
+
+     public function __construct(Request $request)
+     {
+-        $this->locale = $request->getSession()->getLang()->getLocale();
++        if($request->getSession() != null)
++            $this->locale = $request->getSession()->getLang()->getLocale();
++        else
++            $this->locale = Lang::getDefaultLanguage()->getLocale();
+     }
+
+     public function guessTinyMCELanguage($params, \Smarty_Internal_Template $template)",Use braces on your conditional structures please
+25,"@@ -16,6 +16,7 @@
+
+ DECLARE_string(u);
+ DECLARE_string(p);
++DEFINE_bool(enable_history, false, ""Whether to force saving the command history"");
+
+ namespace nebula {
+ namespace graph {","Great God, I have a question. This "".nebula_history"" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx."
+26,"@@ -1004,8 +1004,9 @@ static void parseRecord (tokenInfo *const token)
+ 	 */
+ 	if (!isType (token, TOKEN_OPEN_PAREN))
+ 		readToken (token);
++	if (!isType (token, TOKEN_OPEN_PAREN))
++		return;
+
+-	Assert (isType (token, TOKEN_OPEN_PAREN));
+ 	do
+ 	{
+ 		if (isType (token, TOKEN_COMMA) ||",Isn't this the same check as two lines above?
+27,"@@ -18,8 +18,11 @@ from mitmproxy import io
+ from mitmproxy import log
+ from mitmproxy import version
+ from mitmproxy import optmanager
++from mitmproxy import options
+ import mitmproxy.tools.web.master # noqa
+
++CONFIG_PATH = os.path.join(options.CA_DIR, 'config.yaml')
++
+
+ def flow_to_json(flow: mitmproxy.flow.Flow) -> dict:
+     """"""","Don't redefine, just import the existing one in `cmdline.py`. :)"
+28,"@@ -92,7 +92,8 @@ module Mongoid
+       #
+       # @since 2.0.0.rc.7
+       def process_attribute(name, value)
+-        if store_as = aliased_fields.invert[name.to_s]
++        responds = respond_to?(""#{name}="")
++        if !responds && store_as = aliased_fields.invert[name.to_s]
+           name = store_as
+         end
+         responds = respond_to?(""#{name}="")","why not call `respond_to?(""#{name}="")` from the `if` line?"
+29,"@@ -215,7 +215,8 @@ public final class BlazeCidrLauncher extends CidrLauncher {
+         workingDir = workspaceRootDirectory;
+       }
+
+-      GeneralCommandLine commandLine = new GeneralCommandLine(runner.executableToDebug.getPath());
++      GeneralCommandLine commandLine = new GeneralCommandLine(runner.executableToDebug.getPath())
++          .withWorkDirectory(workingDir);
+
+       commandLine.addParameters(handlerState.getExeFlagsState().getFlagsForExternalProcesses());
+       commandLine.addParameters(handlerState.getTestArgs());",This was properly set above as `<target>.runfiles/<workspace_name>` (with a fallback to workspace root dir) but never used past this line.
+30,"@@ -0,0 +1,13 @@
++using System;
++using System.Collections.Generic;
++using System.Linq;
++using System.Text;
++using System.Threading.Tasks;
++using MvvmCross.Core.Views;
++
++namespace MvvmCross.Uwp.Attributes
++{
++    public class MvxPagePresentationAttribute : MvxBasePresentationAttribute
++    {
++    }
++}",Are all these namespaces required for this attribute?
+31,"@@ -53,9 +53,12 @@ module Beaker
+           result.stdout << std_out
+           result.stderr << std_err
+           result.exit_code = status.exitstatus
++          @logger.info(result.stdout)
++          @logger.info(result.stderr)
+         end
+       rescue => e
+         result.stderr << e.inspect
++        @logger.info(result.stderr)
+         result.exit_code = 1
+       end
+ ","Given this may be used and printed in other ways, isn't `debug` more appropriate?"
+32,"@@ -540,3 +540,7 @@ func (s *blockDiskStore) remove(id kbfsblock.ID) error {
+ 	}
+ 	return err
+ }
++
++func (s blockDiskStore) clear() error {
++	return ioutil.RemoveAll(s.dir)
++}",Looks like this is unused? Did you mean to call it when clearing the block journal?
+33,"@@ -117,8 +117,10 @@ public class ExecutorManager extends EventHandler implements
+
+   public ExecutorManager(Props props, ExecutorLoader loader,
+       Map<String, Alerter> alters) throws ExecutorManagerException {
++    alerters = alters;
+     azkProps = props;
+     this.executorLoader = loader;
++
+     this.setupExecutors();
+     this.loadRunningFlows();
+ ",why named alters? how about this.alerts = alerts?
+34,"@@ -1549,7 +1549,7 @@ func (js *jetStream) processStreamLeaderChange(mset *stream, isLeader bool) {
+ 		resp.Error = jsError(err)
+ 		s.sendAPIErrResponse(client, acc, subject, reply, _EMPTY_, s.jsonResponse(&resp))
+ 	} else {
+-		resp.StreamInfo = &StreamInfo{Created: mset.createdTime(), State: mset.state(), Config: mset.config(), Cluster: js.clusterInfo(mset.raftGroup())}
++		resp.StreamInfo = &StreamInfo{Created: mset.createdTime(), State: mset.state(), Config: mset.config(), Cluster: js.clusterInfo(mset.raftGroup()), Sources: mset.sourcesInfo(), Mirror: mset.mirrorInfo()}
+ 		s.sendAPIResponse(client, acc, subject, reply, _EMPTY_, s.jsonResponse(&resp))
+ 		if node := mset.raftNode(); node != nil {
+ 			mset.sendCreateAdvisory()",not sure if this has to be here or not tbh
+35,"@@ -72,7 +72,12 @@ func newHarnessUsingAutodelete(ctx context.Context, t *testing.T) (drivertest.Ha
+ }
+
+ func (h *harness) CreateTopic(ctx context.Context, testName string) (dt driver.Topic, cleanup func(), err error) {
++	// Keep the topic entity name under 50 characters as per Azure limits.
++	// See https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-quotas
+ 	topicName := fmt.Sprintf(""%s-topic-%d"", sanitize(testName), atomic.AddUint32(&h.numTopics, 1))
++	if len(topicName) > 50 {
++		topicName = topicName[:50]
++	}
+
+ 	createTopic(ctx, topicName, h.ns, nil)
+ ","There's a better fix for this in #1741, which should replace this."
+36,"@@ -63,7 +63,7 @@ func (s *StreamMock) Close() error {
+ func TestHandshake(t *testing.T) {
+ 	logger := logging.New(ioutil.Discard, 0)
+ 	info := Info{
+-		Address:   ""node1"",
++		Address:   []byte(""node1""),
+ 		NetworkID: 0,
+ 		Light:     false,
+ 	}","Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string."
+37,"@@ -80,8 +80,9 @@ func TestFSRepoInit(t *testing.T) {
+
+ 	dir, err := ioutil.TempDir("""", """")
+ 	assert.NoError(t, err)
+-
+-	defer os.RemoveAll(dir)
++	defer func() {
++		require.NoError(t, os.RemoveAll(dir))
++	}()
+
+ 	t.Log(""init FSRepo"")
+ 	assert.NoError(t, InitFSRepo(dir, config.NewDefaultConfig()))","It would be worth factoring this out to a function, but you don't have to do that here."
+38,"@@ -0,0 +1,15 @@
++package com.fsck.k9.message.html;
++
++/**
++ * General framework to handle uris when parsing. Allows different handling depending on the scheme identifier.
++ */
++public interface UriParser {
++    /**
++     * Parse and linkify scheme specific uri beginning from given position. The result will be written to given buffer.
++     * @param text String to parse uri from.
++     * @param startPos Position where uri starts (first letter of scheme).
++     * @param outputBuffer Buffer where linkified variant of uri is written to.
++     * @return Index where parsed uri ends (first non-uri letter). Should be startPos or smaller if no valid uri was found.
++     */
++    int linkifyUri(String text, int startPos, StringBuffer outputBuffer);
++}",There's no need for `final` in interfaces.
+39,"@@ -101,6 +101,9 @@ namespace Datadog.Trace.OpenTracing
+                 case DatadogTags.ServiceName:
+                     Span.ServiceName = value;
+                     return this;
++                case DatadogTags.ServiceVersion:
++                    Span.SetTag(Tags.Version, value);
++                    return this;
+             }
+
+             if (key == global::OpenTracing.Tag.Tags.Error.Key)",Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties.
+40,"@@ -681,7 +681,6 @@ class Quitter:
+     @cmdutils.argument('session', completion=miscmodels.session)
+     def quit(self, save=False, session=None):
+         """"""Quit qutebrowser.
+-
+         Args:
+             save: When given, save the open windows even if auto_save.session
+                   is turned off.",This shouldn't be changed.
+41,"@@ -1,5 +1,5 @@
+ ## This file is part of Invenio.
+-## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 CERN.
++## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`"
+42,"@@ -32,6 +32,8 @@ import java.util.Map;
+ import java.util.Optional;
+ import java.util.Set;
+ import java.util.concurrent.TimeoutException;
++import java.util.function.BiConsumer;
++import java.util.function.Consumer;
+
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;","Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail."
+43,"@@ -0,0 +1,10 @@
++class TraceDestroyerJob < ApplicationJob
++  queue_as :default
++
++  def perform(trace)
++    trace.destroy
++  rescue StandardError => ex
++    logger.info ex.to_s
++    ex.backtrace.each { |l| logger.info l }
++  end
++end",Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued...
+44,"@@ -90,14 +90,11 @@ class CartController extends FrontBaseController
+      */
+     public function indexAction(Request $request)
+     {
+-        $cart = $this->cartFacade->getCartOfCurrentCustomer();
+-
+-        if ($cart->isEmpty()) {
+-            $this->cartFacade->cleanAdditionalData();
+-        }
++        $cart = $this->cartFacade->findCartOfCurrentCustomer();
++        $cartItems = $cart === null ? [] : $cart->getItems();
+
+         $cartFormData = ['quantities' => []];
+-        foreach ($cart->getItems() as $cartItem) {
++        foreach ($cartItems as $cartItem) {
+             $cartFormData['quantities'][$cartItem->getId()] = $cartItem->getQuantity();
+         }
+ ","If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)"
+45,"@@ -34,7 +34,8 @@ public enum BesuMetricCategory implements MetricCategory {
+   PRUNER(""pruner""),
+   RPC(""rpc""),
+   SYNCHRONIZER(""synchronizer""),
+-  TRANSACTION_POOL(""transaction_pool"");
++  TRANSACTION_POOL(""transaction_pool""),
++  VALIDATORS(""validators"");
+
+   private static final Optional<String> BESU_PREFIX = Optional.of(""besu_"");
+   public static final Set<MetricCategory> DEFAULT_METRIC_CATEGORIES;",Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2.
+46,"@@ -14,9 +14,7 @@
+  */
+ package org.hyperledger.besu.tests.acceptance.dsl.account;
+
+-import org.hyperledger.besu.crypto.SECP256K1.KeyPair;
+-import org.hyperledger.besu.crypto.SECP256K1.PrivateKey;
+-import org.hyperledger.besu.crypto.SECP256K1.PublicKey;
++import org.hyperledger.besu.crypto.*;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.Hash;
+ import org.hyperledger.besu.tests.acceptance.dsl.blockchain.Amount;",Spotless is configured to reject star imports. Please replace with explicit imports.
+47,"@@ -115,6 +115,8 @@ void SYCLInternal::initialize(const sycl::device& d) {
+
+     m_maxThreadsPerSM =
+         d.template get_info<sycl::info::device::max_work_group_size>();
++    m_maxShmemPerBlock =
++        d.template get_info<sycl::info::device::local_mem_size>();
+     m_indirectKernelMem.reset(*m_queue);
+     m_indirectReducerMem.reset(*m_queue);
+   } else {",Remind me why you are using CUDA vocabulary when naming these variables.
+48,"@@ -898,6 +898,16 @@ public final class DBReader {
+         }
+         final LongIntMap feedCounters = adapter.getFeedCounters(feedIds);
+
++        int feedFilter = UserPreferences.getFeedFilter();
++        if (feedFilter == UserPreferences.FEED_FILTER_COUNTER_ZERO) {
++            for (int i = 0; i < feeds.size(); i++) {
++                if (feedCounters.get(feeds.get(i).getId()) <= 0) {
++                    feedCounters.delete(feeds.get(i).getId());
++                    feeds.remove(i);
++                }
++            }
++        }
++
+         Comparator<Feed> comparator;
+         int feedOrder = UserPreferences.getFeedOrder();
+         if (feedOrder == UserPreferences.FEED_ORDER_COUNTER) {",Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed.
+49,"@@ -620,7 +620,7 @@ def execute_reentrant_pipeline(pipeline, typed_environment, throw_on_error, reen
+ def get_subset_pipeline(pipeline, solid_subset):
+     check.inst_param(pipeline, 'pipeline', PipelineDefinition)
+     check.opt_list_param(solid_subset, 'solid_subset', of_type=str)
+-    return pipeline if solid_subset is None else build_sub_pipeline(pipeline, solid_subset)
++    return pipeline if not solid_subset else build_sub_pipeline(pipeline, solid_subset)
+
+
+ def create_typed_environment(pipeline, environment=None):",this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline
+50,"@@ -318,8 +318,7 @@ Licensed under the MIT License. See License.txt in the project root for license
+             {
+                 foreach (var unmatchedSetting in CustomSettings.Keys)
+                 {
+-                    Logger.LogError(new ArgumentException(unmatchedSetting),
+-                        Resources.ParameterIsNotValid, unmatchedSetting);
++                    Logger.LogWarning(Resources.ParameterIsNotValid, unmatchedSetting);
+                 }
+             }
+             ErrorManager.ThrowErrors();","this is a breaking change, any specific reason you want to do this?"
+51,"@@ -91,6 +91,8 @@ type nodeChainReader interface {
+ 	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ 	HeadEvents() *ps.PubSub
+ 	Load(context.Context) error
++	PutTipSetAndState(context.Context, *chain.TipSetAndState) error
++	SetHead(context.Context, types.TipSet) error
+ 	Stop()
+ }
+ ","Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks."
+52,"@@ -22,7 +22,8 @@ const (
+ 	minimalPrefetchWorkerQueueSize       int = 1
+ 	testBlockRetrievalWorkerQueueSize    int = 5
+ 	testPrefetchWorkerQueueSize          int = 1
+-	defaultOnDemandRequestPriority       int = 100
++	defaultOnDemandRequestPriority       int = 1<<30 - 1
++	lowestTriggerPrefetchPriority        int = 1
+ 	// Channel buffer size can be big because we use the empty struct.
+ 	workerQueueSize int = 1<<31 - 1
+ )",The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?
+53,"@@ -609,6 +609,14 @@ bool Game::removeCreature(Creature* creature, bool isLogout/* = true*/)
+ 	return true;
+ }
+
++void Game::executeDeath(uint32_t creatureId)
++{
++	Creature* creature = getCreatureByID(creatureId);
++	if (creature && !creature->isRemoved() && creature->getHealth() < 1) {
++		creature->onDeath();
++	}
++}
++
+ void Game::playerMoveThing(uint32_t playerId, const Position& fromPos,
+                            uint16_t spriteId, uint8_t fromStackPos, const Position& toPos, uint8_t count)
+ {",checking health again? I think it is not necessary.
+54,"@@ -442,7 +442,18 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			log.WithError(err).Error(""Failed to connect to Typha. Retrying..."")
++			startTime := time.Now()
++			for err != nil && time.Since(startTime) < 30*time.Second {
++				// Set Ready to false and Live to true when unable to connect to typha
++				healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Debug(""Retrying to start Typha"")
++				time.Sleep(1 * time.Second)
++			}
++			if err != nil {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()",Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.
+55,"@@ -0,0 +1,18 @@
++'use strict';
++
++const assert = require('assert');
++
++class ProvidedPromise {
++  set Promise(lib) {
++    assert.ok(typeof lib === 'function', `mongodb.Promise must be a function, got ${lib}`);
++    this._promise = lib;
++  }
++  get Promise() {
++    return this._promise;
++  }
++}
++
++const provided = new ProvidedPromise();
++provided.Promise = global.Promise;
++
++module.exports = provided;","to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate."
+56,"@@ -738,6 +738,12 @@ func addDep(s *scope, args []pyObject) pyObject {
+ 	dep := core.ParseBuildLabelContext(string(args[1].(pyString)), s.pkg)
+ 	exported := args[2].IsTruthy()
+ 	target.AddMaybeExportedDependency(dep, exported, false, false)
++	// Queue this dependency if it'll be needed.
++	if target.State() > core.Inactive {
++		err := s.state.QueueTarget(dep, target.Label, true, false)
++		s.Assert(err == nil, ""%s"", err)
++	}
++	// TODO(peterebden): Do we even need the following any more?
+ 	s.pkg.MarkTargetModified(target)
+ 	return None
+ }","I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better."
+57,"@@ -123,7 +123,7 @@ def sndrcv(pks, pkt, timeout = None, inter = 0, verbose=None, chainCC=0, retry=0
+                                 if remaintime <= 0:
+                                     break
+                             r = None
+-                            if arch.FREEBSD or arch.DARWIN:
++                            if not (pks.__class__.__name__ == 'StreamSocket') and (arch.FREEBSD or arch.DARWIN):
+                                 inp, out, err = select(inmask,[],[], 0.05)
+                                 if len(inp) == 0 or pks in inp:
+                                     r = pks.nonblock_recv()",You should use `isinstance()` instead of comparing the class name to a string.
+58,"@@ -15,6 +15,11 @@ axe.utils.isHidden = function isHidden(el, recursed) {
+ 		return false;
+ 	}
+
++	// do not exclude `video` or `audio` el's
++	if ([`VIDEO`, `AUDIO`].includes(el.nodeName.toUpperCase())) {
++		return false;
++	}
++
+ 	// 11 === Node.DOCUMENT_FRAGMENT_NODE
+ 	if (el.nodeType === 11) {
+ 		el = el.host; // grab the host Node",Why should audio and video elements always return `false` for `isHidden`?
+59,"@@ -27,7 +27,7 @@ namespace Playground.Core
+
+             Mvx.IoCProvider.RegisterSingleton<IMvxTextProvider>(new TextProviderBuilder().TextProvider);
+
+-            RegisterAppStart<RootViewModel>();
++            // RegisterAppStart<RootViewModel>();
+         }
+
+         /// <summary>",This obviously won't work for all the other platforms.
+60,"@@ -15,7 +15,7 @@ public class ManipulationTest extends BasicJBehaveTest {
+
+     @Override
+     public InjectableStepsFactory stepsFactory() {
+-        Map<String, Object> state = new HashMap<String, Object>();
++        Map<String, Object> state = new HashMap<>();
+
+         return new InstanceStepsFactory(configuration(),
+                 new SharedSteps(state),",Isn't he diamond operator Java7+?
+61,"@@ -159,6 +159,17 @@ public final class Require {
+     return number;
+   }
+
++  public static double positive(String argName, double number, String message) {
++    if (number <= 0) {
++      if (message == null) {
++        throw new IllegalArgumentException(argName + "" must be greater than 0"");
++      } else {
++        throw new IllegalArgumentException(message);
++      }
++    }
++    return number;
++  }
++
+   public static int positive(String argName, Integer number) {
+     return positive(argName, number, null);
+   }","Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly."
+62,"@@ -474,7 +474,7 @@ func (rule removeCount) Name() string {
+ func (rule removeCount) Pattern() plan.Pattern {
+ 	return plan.Pat(universe.CountKind, plan.Any())
+ }
+-func (rule removeCount) Rewrite(ctx context.Context, node plan.Node) (plan.Node, bool, error) {
++func (rule removeCount) Rewrite(ctx context.Context, node plan.Node, nextNodeId *int) (plan.Node, bool, error) {
+ 	return node.Predecessors()[0], true, nil
+ }
+ ","This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it."
+63,"@@ -164,10 +164,13 @@ func WriteWordpressConfig(wordpressConfig *WordpressConfig, filePath string) err
+ 		return err
+ 	}
+
+-	// Ensure target directory is writable.
++	// Ensure target directory exists and is writeable
+ 	dir := filepath.Dir(filePath)
+-	err = os.Chmod(dir, 0755)
+-	if err != nil {
++	if err = os.Chmod(dir, 0755); os.IsNotExist(err) {
++		if err = os.MkdirAll(dir, 0755); err != nil {
++			return err
++		}
++	} else if err != nil {
+ 		return err
+ 	}
+ ",This seems like an improved pattern :)
+64,"@@ -127,16 +127,16 @@ class UserController < ApplicationController
+         # valid OpenID and one the user has control over before saving
+         # it as a password equivalent for the user.
+         session[:new_user_settings] = params
+-        openid_verify(params[:user][:openid_url], @user)
++        federated_verify(params[:user][:openid_url], @user)
+       else
+         update_user(@user, params)
+       end
+-    elsif using_open_id?
++    elsif using_federated_login?
+       # The redirect from the OpenID provider reenters here
+       # again and we need to pass the parameters through to
+       # the open_id_authentication function
+       settings = session.delete(:new_user_settings)
+-      openid_verify(nil, @user) do |user|
++      federated_verify(nil, @user) do |user|
+         update_user(user, settings)
+       end
+     end","`open_id_authentication` is no longer the name of the function, and it's not OpenID specific"
+65,"@@ -243,10 +243,10 @@ void rai_qt::accounts::refresh_wallet_balance ()
+ 		balance = balance + (this->wallet.node.ledger.account_balance (transaction, key));
+ 		pending = pending + (this->wallet.node.ledger.account_pending (transaction, key));
+ 	}
+-	auto final_text (std::string (""Wallet balance (XRB): "") + wallet.format_balance (balance));
++	auto final_text (std::string (""Balance: "") + wallet.format_balance (balance));
+ 	if (!pending.is_zero ())
+ 	{
+-		final_text += ""\nWallet pending: "" + wallet.format_balance (pending);
++		final_text += ""\nPending: "" + wallet.format_balance (pending);
+ 	}
+ 	wallet_balance_label->setText (QString (final_text.c_str ()));
+ 	this->wallet.node.alarm.add (std::chrono::system_clock::now () + std::chrono::seconds (60), [this]() {",This didn't require corresponding changes to the test case(s)?
+66,"@@ -509,6 +509,7 @@ type TaskConfig struct {
+ 	Count          Count                `yaml:""count""`
+ 	ExecuteCommand ExecuteCommand       `yaml:""exec""`
+ 	Variables      map[string]string    `yaml:""variables""`
++	EnvFile        string               `yaml:""env_file""`
+ 	Secrets        map[string]string    `yaml:""secrets""`
+ 	Storage        Storage              `yaml:""storage""`
+ }","A question! I think `string` totally works, but what do you think of `*string` for consistency?"
+67,"@@ -25,6 +25,12 @@ import (
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+
++const (
++	AnnotationClusterInfrastructureReady = ""aws.cluster.sigs.k8s.io/infrastructure-ready""
++	AnnotationControlPlaneReady          = ""aws.cluster.sigs.k8s.io/control-plane-ready""
++	ValueReady                           = ""true""
++)
++
+ // AWSResourceReference is a reference to a specific AWS resource by ID, ARN, or filters.
+ // Only one of ID, ARN or Filters may be specified. Specifying more than one will result in
+ // a validation error.",Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?
+68,"@@ -142,7 +142,7 @@ void PairLubricate::compute(int eflag, int vflag)
+     Ef[2][2] = h_rate[2]/domain->zprd;
+     Ef[0][1] = Ef[1][0] = 0.5 * h_rate[5]/domain->yprd;
+     Ef[0][2] = Ef[2][0] = 0.5 * h_rate[4]/domain->zprd;
+-    Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->zprd;
++    Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->xprd;
+
+     // copy updated velocity/omega/angmom to the ghost particles
+     // no need to do this if not shearing since comm->ghost_velocity is set",Not clear on why this change is correct.
+69,"@@ -193,5 +193,10 @@ public final class ByteBuffersIndexInput extends IndexInput implements RandomAcc
+     if (in == null) {
+       throw new AlreadyClosedException(""Already closed."");
+     }
+-  }
++  }
++
++  @Override
++  public boolean isMMapped() {
++    return true;
++  }
+ }","Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap)."
+70,"@@ -54,6 +54,7 @@ storiesOf( 'PageSpeed Insights Module/Settings', module )
+ 		decorators: [
+ 			withRegistry,
+ 		],
++		padding: 0,
+ 	} )
+ 	.add( 'View, open with all settings', ( args, { registry } ) => {
+ 		return <Settings isOpen={ true } registry={ registry } />;",All stories in this file also need to have the default padding.
+71,"@@ -804,8 +804,10 @@ static void subsurface_handle_place_above(struct wl_client *client,
+ 		return;
+ 	}
+
++	assert(sibling->parent == subsurface->parent);
++
+ 	wl_list_remove(&subsurface->parent_pending_link);
+-	wl_list_insert(&sibling->parent_pending_link,
++	wl_list_insert(sibling->parent_pending_link.prev,
+ 		&subsurface->parent_pending_link);
+
+ 	subsurface->reordered = true;","I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?"
+72,"@@ -0,0 +1,15 @@
++class Episode < ActiveRecord::Base
++  attr_accessible :title, :duration, :file, :description, :published_on, :notes,
++    :old_url, :file_size
++
++  validates_presence_of :title, :duration, :file, :file_size, :description,
++    :published_on
++
++  def self.published
++    where(""published_on <= ?"", Date.today).order('published_on desc')
++  end
++
++  def full_title
++    ""Episode #{id}: #{title}""
++  end
++end",Should this be `number` instead of `id`?
+73,"@@ -1569,12 +1569,11 @@ NATable *BindWA::getNATable(CorrName& corrName,
+       ((QualifiedName&)(table->getTableName())).setIsVolatile(TRUE);
+     }
+
+-  // For now, do not allow access through the Trafodion external name created for
+-  // the HIVE object unless the inDDL flag is set.  inDDL is set for drop
+-  // table and SHOWDDL statements.
+-  // TDB - may want to merge the Trafodion version with the HIVE version.
+-  // TDB - similar operation may be needed for external HBase tables
+-  if ((table) && (table->isExternalTable() && (! bindWA->inDDL())))
++  // For now, don't allow access through the Trafodion external name created for
++  // native HIVE or HBASE objects unless the allowExternalTables flag is set.
++  // allowExternalTables is set for drop table and SHOWDDL statements.
++  // TDB - may want to merge the Trafodion version with the native version.
++  if ((table) && (table->isExternalTable() && (! bindWA->allowExternalTables())))
+     {
+       *CmpCommon::diags() << DgSqlCode(-4258)
+                           << DgTableName(table->getTableName().getQualifiedNameAsAnsiString());","I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name."
+74,"@@ -40,6 +40,18 @@
+
+ struct ase_cfg_t *cfg;
+
++int app2sim_alloc_rx;		// app2sim mesaage queue in RX mode
++int sim2app_alloc_tx;		// sim2app mesaage queue in TX mode
++int app2sim_mmioreq_rx;		// MMIO Request path
++int sim2app_mmiorsp_tx;		// MMIO Response path
++int app2sim_umsg_rx;		// UMSG    message queue in RX mode
++int app2sim_portctrl_req_rx;	// Port Control messages in Rx mode
++int app2sim_dealloc_rx;
++int sim2app_dealloc_tx;
++int sim2app_portctrl_rsp_tx;
++int sim2app_intr_request_tx;
++int intr_event_fds[MAX_USR_INTRS];
++
+ int glbl_test_cmplt_cnt;   // Keeps the number of session_deinits received
+
+ volatile int sockserver_kill;",Should most of these non-globals be static?
+75,"@@ -14,6 +14,14 @@ class TestFakerName < Test::Unit::TestCase
+     assert @tester.name_with_middle.match(/(\w+\.? ?){3,4}/)
+   end
+
++  def test_first_name
++    assert @tester.first_name.match(/(\w+\.? ?){3,4}/)
++  end
++
++  def test_last_name
++    assert @tester.last_name.match(/(\w+\.? ?){3,4}/)
++  end
++
+   def test_prefix
+     assert @tester.prefix.match(/[A-Z][a-z]+\.?/)
+   end",Please do not approve PRs without tests!!!!
+76,"@@ -48,7 +48,7 @@ class WebEngineView(QWebEngineView):
+         else:
+             profile = webenginesettings.default_profile
+         page = WebEnginePage(theme_color=theme_color, profile=profile,
+-                             parent=self)
++                             parent=self, win_id=win_id)
+         self.setPage(page)
+
+     def shutdown(self):",Now that you handle this in `webenginetab.py` you can undo all the changes in this file.
+77,"@@ -30,7 +30,11 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext
+ public class JavaFXApplication extends Application {
+
+     public static void main(String[] args) {
+-        Application.launch(JavaFXApplication.class);
++        try {
++            Application.launch(JavaFXApplication.class);
++        } catch (Exception e) {
++            e.printStackTrace();
++        }
+     }
+
+     @Override",I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console.
+78,"@@ -57,7 +57,7 @@ func (r *Helper) Apply(obj []byte) (ApplyResult, error) {
+ 	if err != nil {
+ 		r.logger.WithError(err).
+ 			WithField(""stdout"", ioStreams.Out.(*bytes.Buffer).String()).
+-			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Error(""running the apply command failed"")
++			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Warn(""running the apply command failed"")
+ 		return """", err
+ 	}
+ 	return changeTracker.GetResult(), nil","These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors."
+79,"@@ -167,7 +167,7 @@ class ExportCategoryTableMap extends TableMap
+      */
+     public function buildRelations()
+     {
+-        $this->addRelation('Export', '\\Thelia\\Model\\Export', RelationMap::ONE_TO_MANY, array('id' => 'export_category_id', ), 'CASCADE', 'RESTRICT', 'Exports');
++        $this->addRelation('Export', '\\Thelia\\Model\\Export', RelationMap::ONE_TO_MANY, array('id' => 'export_category_id', ), null, null, 'Exports');
+         $this->addRelation('ExportCategoryI18n', '\\Thelia\\Model\\ExportCategoryI18n', RelationMap::ONE_TO_MANY, array('id' => 'id', ), 'CASCADE', null, 'ExportCategoryI18ns');
+     } // buildRelations()
+ ",do you really want to change the behavior on foreign key ?
+80,"@@ -183,7 +183,8 @@ void event_batch_destroy (struct event_batch *batch)
+         if (batch->f)
+             (void)flux_future_wait_for (batch->f, -1);
+         if (batch->state_trans) {
+-            event_publish_state (batch->event, batch->state_trans);
++            if (json_array_size (batch->state_trans) > 0)
++                event_publish_state (batch->event, batch->state_trans);
+             json_decref (batch->state_trans);
+         }
+         if (batch->responses) {",Looks like my bad. Thanks for fixing!
+81,"@@ -82,6 +82,7 @@ class Command:
+         no_cmd_split: If true, ';;' to split sub-commands is ignored.
+         backend: Which backend the command works with (or None if it works with
+                  both)
++        no_replace_variables: Whether or not to replace variables like {url}
+         _qute_args: The saved data from @cmdutils.argument
+         _needs_js: Whether the command needs javascript enabled
+         _modes: The modes the command can be executed in.","I think ""Don't replace variables ..."" would be cleaner."
+82,"@@ -82,8 +82,7 @@ class MPLPlot(DimensionedPlot):
+     sublabel_size = param.Number(default=18, doc=""""""
+          Size of optional subfigure label."""""")
+
+-    projection = param.ObjectSelector(default=None,
+-                                      objects=['3d', 'polar', None], doc=""""""
++    projection = param.Parameter(default=None, doc=""""""
+         The projection of the plot axis, default of None is equivalent to
+         2D plot, '3d' and 'polar' are also supported."""""")
+ ",Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate...
+83,"@@ -40,13 +40,11 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
+ 	for i, dataDiskInfo := range dataDiskInfos {
+ 		dataDiskIndex := i + 1
+ 		dataDiskFilePath := dataDiskInfo.FilePath
+-		diskNames = append(
+-			diskNames,
+-			fmt.Sprintf(""%v-data-disk-%v"", w.Vars[""instance_name""].Value, dataDiskIndex))
++		diskNames = append(diskNames, generateDataDiskName(w.Vars[""instance_name""].Value, dataDiskIndex))
+
+ 		setupDataDiskStepName := fmt.Sprintf(""setup-data-disk-%v"", dataDiskIndex)
+-		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v"", dataDiskIndex)
+-		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%v-%v"", dataDiskIndex, w.Vars[""instance_name""].Value)
++		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v-%v"", dataDiskIndex, w.ID())
++		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%v-%v"", dataDiskIndex, w.ID())
+
+ 		setupDataDiskStep := daisy.NewStepDefaultTimeout(setupDataDiskStepName, w)
+ 		setupDataDiskStep.CreateDisks = &daisy.CreateDisks{",I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID().
+84,"@@ -29,6 +29,11 @@ import java.util.Map;
+  * @param <F> the concrete Java class of a ContentFile instance.
+  */
+ public interface ContentFile<F> {
++  /**
++   * Returns the ordinal position of the file in a manifest, or null if it was not read from a manifest.
++   */
++  Long pos();
++
+   /**
+    * Returns id of the partition spec used for partition metadata.
+    */",qq: do we want to include anything in the name to indicate that it is a position in the manifest?
+85,"@@ -969,8 +969,11 @@ public class VRBrowserActivity extends PlatformActivity implements WidgetManager
+         GleanMetricsService.stopImmersive();
+         Handler handler = new Handler(Looper.getMainLooper());
+         handler.postDelayed(() -> {
+-            mWindows.resumeCompositor();
+-            Log.d(LOGTAG, ""Compositor Resumed"");
++            if (!mWindows.isPaused()) {
++                Log.d(LOGTAG, ""Compositor resume begin"");
++                mWindows.resumeCompositor();
++                Log.d(LOGTAG, ""Compositor resume end"");
++            }
+         }, 20);
+     }
+ ",These logs should probably use the `LOGTAG`
+86,"@@ -28,10 +28,10 @@ import (
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/services/wireguard""
+ 	""github.com/mysteriumnetwork/node/services/wireguard/key""
+-	""github.com/mysteriumnetwork/wireguard-go/device""
+-	""github.com/mysteriumnetwork/wireguard-go/tun""
+ 	""github.com/pkg/errors""
+ 	""github.com/rs/zerolog/log""
++	""golang.zx2c4.com/wireguard/device""
++	""golang.zx2c4.com/wireguard/tun""
+ )
+
+ const (","From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing."
+87,"@@ -43,7 +43,7 @@ namespace Nethermind.JsonRpc
+
+         public static ResultWrapper<T> Fail(Exception e)
+         {
+-            return new() { Result = Result.Fail(e.ToString()), ErrorCode = ErrorCodes.InternalError};
++            return new() { Result = Result.Fail(e.Message), ErrorCode = ErrorCodes.InternalError};
+         }
+
+         public static ResultWrapper<T> Fail(string error, int errorCode, T outputData)",Any particular reason for this? This potentially will make harder to investigate users issues
+88,"@@ -999,7 +999,8 @@ Blockly.BlockSvg.prototype.updatePreviews = function(closestConnection,
+   // grayed-out blocks instead of highlighting the connection; for compatibility
+   // with Web Blockly the name ""highlightedConnection"" will still be used.
+   if (Blockly.highlightedConnection_ &&
+-      Blockly.highlightedConnection_ != closestConnection) {
++      (Blockly.highlightedConnection_ != closestConnection ||
++       Blockly.localConnection_ != localConnection)) {
+     if (Blockly.insertionMarker_ && Blockly.insertionMarkerConnection_) {
+       Blockly.BlockSvg.disconnectInsertionMarker();
+     }",Do you also need to check if Blockly.localConnection_ is non-null?
+89,"@@ -1,5 +1,6 @@
+ module RSpec
+   module Core
++    # Internal container for global non-configuration data
+     class World
+
+       include RSpec::Core::Hooks","Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?"
+90,"@@ -3,6 +3,8 @@ const { basename } = require('./path-utils');
+ const shim = require('./shim').default;
+ const JoplinError = require('./JoplinError').default;
+ const { Buffer } = require('buffer');
++const { Readable } = require('stream').Readable;
++const { GetObjectCommand, ListObjectsV2Command, HeadObjectCommand, PutObjectCommand, DeleteObjectCommand, DeleteObjectsCommand } = require(""@aws-sdk/client-s3"");
+
+ const S3_MAX_DELETES = 1000;
+ ","The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], ""stream"").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(""data"", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?"
+91,"@@ -93,7 +93,9 @@ func (m *MockStorer) Put(ctx context.Context, mode storage.ModePut, chs ...swarm
+ 			po := swarm.Proximity(ch.Address().Bytes(), m.baseAddress)
+ 			m.bins[po]++
+ 		}
+-		m.store[ch.Address().String()] = ch.Data()
++		b := make([]byte, len(ch.Data()))
++		copy(b, ch.Data())
++		m.store[ch.Address().String()] = b
+ 		m.modePut[ch.Address().String()] = mode
+
+ 		// pin chunks if needed","this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store"
+92,"@@ -42,6 +42,10 @@ import (
+ 	""go.uber.org/yarpc/yarpcerrors""
+ )
+
++func init() {
++	opentracing.SetGlobalTracer(nil)
++}
++
+ func TestHandlerSuccess(t *testing.T) {
+ 	mockCtrl := gomock.NewController(t)
+ 	defer mockCtrl.Finish()",wut. We can do this at the beginning of tests if we want right? Why are we depending on init?
+93,"@@ -1403,9 +1403,12 @@ func (c *client) processConnect(arg []byte) error {
+ 				c.mu.Lock()
+ 				acc := c.acc
+ 				c.mu.Unlock()
++				srv.mu.Lock()
+ 				if acc != nil && acc != srv.gacc {
++					srv.mu.Unlock()
+ 					return ErrTooManyAccountConnections
+ 				}
++				srv.mu.Unlock()
+ 			}
+ 			c.authViolation()
+ 			return ErrAuthentication",Same trick here IMO.
+94,"@@ -108,10 +108,11 @@ module Selenium
+
+         def initialize(source, duration, x, y, element: nil, origin: nil)
+           super(source)
++
+           @duration = duration * 1000
+           @x_offset = x
+           @y_offset = y
+-          @origin = element || origin
++          @origin = origin || POINTER
+         end
+
+         def type",Should be `@origin = element || origin || POINTER`
+95,"@@ -50,11 +50,14 @@ func NewUpgradeCStorSPCJob() *cobra.Command {
+ 		Long:    cstorSPCUpgradeCmdHelpText,
+ 		Example: `upgrade cstor-spc --spc-name <spc-name>`,
+ 		Run: func(cmd *cobra.Command, args []string) {
++			util.CheckErr(options.RunCStorSPCUpgradeChecks(cmd, args), util.Fatal)
+ 			options.resourceKind = ""storagePoolClaim""
+-			util.CheckErr(options.RunPreFlightChecks(cmd), util.Fatal)
+-			util.CheckErr(options.RunCStorSPCUpgradeChecks(cmd), util.Fatal)
+-			util.CheckErr(options.InitializeDefaults(cmd), util.Fatal)
+-			util.CheckErr(options.RunCStorSPCUpgrade(cmd), util.Fatal)
++			if options.cstorSPC.spcName != """" {
++				singleCstorSPCUpgrade(cmd)
++			}
++			if len(args) != 0 {
++				bulkCstorSPCUpgrade(cmd, args)
++			}
+ 		},
+ 	}
+ ",this example needs a fix?
+96,"@@ -248,9 +248,9 @@ static void close(struct roots_view *view) {
+ 	struct wlr_xdg_surface *surface = view->xdg_surface;
+ 	struct wlr_xdg_popup *popup = NULL;
+ 	wl_list_for_each(popup, &surface->popups, link) {
+-		wlr_xdg_surface_send_close(popup->base);
++		wlr_xdg_popup_destroy(popup->base);
+ 	}
+-	wlr_xdg_surface_send_close(surface);
++	wlr_xdg_toplevel_send_close(surface);
+ }
+
+ static void destroy(struct roots_view *view) {",Is it safe to assume this surface is a toplevel?
+97,"@@ -225,6 +225,16 @@ projCtx pj_ctx_alloc()
+     return new (std::nothrow) projCtx_t(*pj_get_default_ctx());
+ }
+
++/************************************************************************/
++/*                            pj_ctx_clone()                            */
++/************************************************************************/
++
++projCtx pj_ctx_clone( projCtx ctx )
++
++{
++    return new (std::nothrow) projCtx_t(*ctx);
++}
++
+ /************************************************************************/
+ /*                            pj_ctx_free()                             */
+ /************************************************************************/",we don't need that function
+98,"@@ -72,6 +72,13 @@ public enum Platform {
+     }
+   },
+
++  WIN10(""windows 10"", ""win10"") {
++    @Override
++    public Platform family() {
++      return WINDOWS;
++    }
++  },
++
+   MAC(""mac"", ""darwin"", ""os x"") {},
+
+   SNOW_LEOPARD(""snow leopard"", ""os x 10.6"") {","we'll also have to think about adding ""Windows Server 2014"" or whatever they come up with later."
+99,"@@ -35,6 +35,9 @@ public interface ExecutorLoader {
+   Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchActiveFlows()
+       throws ExecutorManagerException;
+
++  Pair<ExecutionReference, ExecutableFlow> fetchActiveFlowByExecId(int execId)
++      throws ExecutorManagerException;
++
+   List<ExecutableFlow> fetchFlowHistory(int skip, int num)
+       throws ExecutorManagerException;
+ ",curious do we have an API to fetch an inactive flow?
+100,"@@ -116,10 +116,6 @@ function upgradeToVNodes(arr, offset) {
+ 		if (Array.isArray(obj)) {
+ 			upgradeToVNodes(obj);
+ 		}
+-		else if (obj && typeof obj==='object' && !isValidElement(obj) && ((obj.props && obj.type) || obj.text!=null)) {
+-			if (obj.text) continue;
+-			arr[i] = createElement(obj.type, obj.props, obj.props.children);
+-		}
+ 	}
+ }
+ ",This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now .
+101,"@@ -0,0 +1,16 @@
++const { getComposedParent } = axe.commons.dom;
++
++function shouldMatchElement(el) {
++	if (!el) {
++		return true;
++	}
++	const ariaHiddenValue = el.getAttribute('aria-hidden')
++		? el.getAttribute('aria-hidden')
++		: null;
++	if (ariaHiddenValue === null) {
++		return shouldMatchElement(getComposedParent(el));
++	}
++	return false;
++}
++
++return shouldMatchElement(getComposedParent(node));",Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability.
+102,"@@ -37,13 +37,14 @@ import pytest
+ import py.path  # pylint: disable=no-name-in-module
+
+ import helpers.stubs as stubsmod
++from helpers.utils import CallbackChecker
+ from qutebrowser.config import config, configdata, configtypes, configexc
+ from qutebrowser.utils import objreg, standarddir
+ from qutebrowser.browser.webkit import cookies
+ from qutebrowser.misc import savemanager, sql
+ from qutebrowser.keyinput import modeman
+
+-from PyQt5.QtCore import pyqtSignal, QEvent, QSize, Qt, QObject
++from PyQt5.QtCore import QEvent, QSize, Qt
+ from PyQt5.QtGui import QKeyEvent
+ from PyQt5.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout
+ from PyQt5.QtNetwork import QNetworkCookieJar",Please import modules and not classes (except for Qt stuff).
+103,"@@ -20,6 +20,11 @@ public class DummyJavaNode extends AbstractJavaNode {
+         super(id);
+     }
+
++    @Override
++    public void setImage(String image) {
++        super.setImage(image);
++    }
++
+     @Override
+     public Object jjtAccept(JavaParserVisitor visitor, Object data) {
+         return data;","Hm... why do we have a ""DummyJavaNode"" in src/main? Looks like, this should have gone into src/test...."
+104,"@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
+ limitations under the License.
+ */
+
++// Package v1alpha1
+ package v1alpha1
+
+ // CasKey is used for all cas specific annotation keys",This seems meaningless. If we cannot add any info let us remove this.
+105,"@@ -493,6 +493,14 @@ func (c *Container) GetLabels() map[string]string {
+ 	return c.labels
+ }
+
++// GetPorts gets the ports for a container
++func (c *Container) GetPorts() []PortBinding {
++	c.lock.RLock()
++	defer c.lock.RUnlock()
++
++	return c.Ports
++}
++
+ // HealthStatusShouldBeReported returns true if the health check is defined in
+ // the task definition
+ func (c *Container) HealthStatusShouldBeReported() bool {",Can you rename `Ports` to `PortsUnsafe`?
+106,"@@ -0,0 +1,10 @@
++module ReturnToHelper
++  def make_return_to(name, path)
++    sig = OpenSSL::HMAC.digest(
++      OpenSSL::Digest::SHA256.new,
++      Rails.application.secrets.secret_key_base,
++      name + ""$"" + path
++    )
++    {name: name, path: path, sig: Base64.urlsafe_encode64(sig)}
++  end
++end",This feels like it could be moved out to your first gem!
+107,"@@ -44,7 +44,7 @@ public abstract class NewSessionQueue implements HasReadyState {
+
+   public abstract boolean offerFirst(HttpRequest request, RequestId requestId);
+
+-  public abstract Optional<HttpRequest> poll();
++  public abstract Optional<HttpRequest> poll(RequestId requestId);
+
+   public abstract int clear();
+ ","The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here."
+108,"@@ -7,4 +7,17 @@
+ axe.utils.toArray = function (thing) {
+ 	'use strict';
+ 	return Array.prototype.slice.call(thing);
+-};
++};
++
++
++/**
++ * Creates an array without duplicate values from 2 array inputs
++ * @param  {Array} arr1 First array
++ * @param  {Array} arr2 Second array
++ * @return {Array}
++ */
++axe.utils.uniqueArray = (arr1, arr2) => {
++  return arr1.concat(arr2).filter((elem, pos, arr) => {
++    return arr.indexOf(elem) === pos;
++  });
++};","This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs."
+109,"@@ -1676,9 +1676,10 @@ _tmain(int argc, TCHAR *targv[])
+     }
+ # ifdef UNIX
+     /* i#1676: detect whether under gdb */
+-    _snprintf(buf, BUFFER_SIZE_ELEMENTS(buf), ""/proc/%d/exe"", getppid());
+-    NULL_TERMINATE_BUFFER(buf);
+-    i = readlink(buf, buf, BUFFER_SIZE_ELEMENTS(buf));
++    char path_buf[MAXIMUM_PATH];
++    _snprintf(path_buf, BUFFER_SIZE_ELEMENTS(path_buf), ""/proc/%d/exe"", getppid());
++    NULL_TERMINATE_BUFFER(path_buf);
++    i = readlink(path_buf, buf, BUFFER_SIZE_ELEMENTS(buf));
+     if (i > 0) {
+         if (i < BUFFER_SIZE_ELEMENTS(buf))
+             buf[i] = '\0';","What is the problem here? The commit message has strange wording ""readlink is defined with restrict pointers"": do you mean ""restricted""? Is that a well-defined language term? I'm not sure what it means."
+110,"@@ -17,6 +17,7 @@ package com.google.api.codegen.util.ruby;
+ import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.util.NameFormatter;
+ import com.google.api.codegen.util.NamePath;
++import com.google.common.collect.ImmutableSet;
+
+ /**
+  * The NameFormatter for Ruby.",Why are we not wrapping here?
+111,"@@ -2,12 +2,10 @@
+
+ namespace Shopsys\FrameworkBundle\Model\Product\Filter;
+
+-use Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter;
+-
+ class ParameterFilterData
+ {
+     /**
+-     * @var \Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter
++     * @var \Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter|null
+      */
+     public $parameter;
+ ","I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?"
+112,"@@ -22,16 +22,16 @@ var sourceHashes = map[string]string{
+ 	""libflux/flux-core/src/ast/flatbuffers/mod.rs"":                                                ""00c75dc1da14487953a4a017616fb8a237fe3da437c876f1328532dd7906f015"",
+ 	""libflux/flux-core/src/ast/flatbuffers/monotype.rs"":                                           ""4e82aae8e7edb8e230302241fe702ece9ae84fc708003c24709c2ea944cfaae8"",
+ 	""libflux/flux-core/src/ast/flatbuffers/tests.rs"":                                              ""ea85b78049f0c3d79daedcf9e171ccb00d0a596d1a643aa218590c99e6b160bc"",
+-	""libflux/flux-core/src/ast/mod.rs"":                                                            ""676e22d24cd7a97525688ed391a980d08b4bee40c5b5067d187f3ae6d66210ca"",
++	""libflux/flux-core/src/ast/mod.rs"":                                                            ""29b25b75a01cf1e1ac2b52d99b91986cec32011dc55af1ffd7f145838fce858d"",
+ 	""libflux/flux-core/src/ast/tests.rs"":                                                          ""bc7f77d569d8bbd4b9d00653f48bacd47eed46f53024dce836d3c8bbb6a80555"",
+ 	""libflux/flux-core/src/ast/walk/mod.rs"":                                                       ""e8a03023d7426bcf6dfdb1a61ac3263f5cf9194a595a1584dff7c899d06562f1"",
+ 	""libflux/flux-core/src/ast/walk/tests.rs"":                                                     ""f7b2d7dd5643bb795a86c04b6979b136b0de46b52b213caff094aed6d204a05d"",
+ 	""libflux/flux-core/src/formatter/mod.rs"":                                                      ""945736a4ad87adb6a3f359b6f2da6e5492b3cb0efd282e277303e2acae137763"",
+ 	""libflux/flux-core/src/formatter/tests.rs"":                                                    ""b0a10998a65fc4b54a8f68b3a0ed186d8548ba3d7638f911eb188d2ce485206f"",
+ 	""libflux/flux-core/src/lib.rs"":                                                                ""d19b7054e07f234c107d457030a0031374c123fe14a84a5b8e35537d138bac7a"",
+-	""libflux/flux-core/src/parser/mod.rs"":                                                         ""e3f11fe29f47271b5c04accc2d7efa35e1dc62c6de036bf0cc0cccda5e4742e8"",
++	""libflux/flux-core/src/parser/mod.rs"":                                                         ""daf24b2c439f4c7a6f138e2b25064a205aee73bb6cffc898df22dd0c962ca5df"",
+ 	""libflux/flux-core/src/parser/strconv.rs"":                                                     ""748c82f6efc2eafaafb872db5b4185ce29aafa8f03ba02c4b84f4a9614e832d2"",
+-	""libflux/flux-core/src/parser/tests.rs"":                                                       ""e3a7c9222f90323a7ea9b319bd84f96f66c6f115af6d199a0da332c894713ae4"",
++	""libflux/flux-core/src/parser/tests.rs"":                                                       ""43a1e5d3de85d76da2107544e417f583a1f66c20910286285b9645a309c42425"",
+ 	""libflux/flux-core/src/scanner/mod.rs"":                                                        ""2e15c9e0a73d0936d2eaeec030b636786db6dbe7aab673045de3a3e815c49f8a"",
+ 	""libflux/flux-core/src/scanner/scanner.rl"":                                                    ""530c062363b66daded3c521af44111b99ffee0eeb2a12ccffa8b8f349002d852"",
+ 	""libflux/flux-core/src/scanner/scanner_generated.rs"":                                          ""d65dcc216ccbb88d8f2e261a994ba2789075e434cb7a0f5e39e390bee2821e5b"",",Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily.
+113,"@@ -440,18 +440,6 @@ func parseConfig(loc location.Location, opts options.Options) (interface{}, erro
+ 			cfg.ProjectID = os.Getenv(""GOOGLE_PROJECT_ID"")
+ 		}
+
+-		if cfg.JSONKeyPath == """" {
+-			if path := os.Getenv(""GOOGLE_APPLICATION_CREDENTIALS""); path != """" {
+-				// Check read access
+-				if _, err := ioutil.ReadFile(path); err != nil {
+-					return nil, errors.Fatalf(""Failed to read google credential from file %v: %v"", path, err)
+-				}
+-				cfg.JSONKeyPath = path
+-			} else {
+-				return nil, errors.Fatal(""No credential file path is set"")
+-			}
+-		}
+-
+ 		if err := opts.Apply(loc.Scheme, &cfg); err != nil {
+ 			return nil, err
+ 		}","We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!"
+114,"@@ -1,11 +1,12 @@
+ package plugin
+
+ type Config struct {
+-	SocketPath string        `yaml:""path""`
+-	Volumes    VolumesConfig `yaml:""volume""`
++	SocketDir string                       `yaml:""socket_dir"" default:""/run/docker/plugins""`
++	Volumes   VolumesConfig                `yaml:""volume""`
++	GPUs      map[string]map[string]string `yaml:""GPUs""`
+ }
+
+ type VolumesConfig struct {
+-	Root    string
++	Root    string `yaml:""root"" default:""/var/lib/docker-volumes""`
+ 	Volumes map[string]map[string]string
+ }",No need to speficy attribute here. Moreover in yaml it is default to use lowercase names.
+115,"@@ -8,10 +8,12 @@ using System;
+ using System.Collections.Generic;
+ using System.Globalization;
+ using System.IO;
++using System.Linq;
+ using System.Net;
+ using System.Net.Http;
+ using System.Text;
+ using System.Threading;
++using System.Threading.Tasks;
+ using Task = System.Threading.Tasks.Task;
+
+ namespace Microsoft.DotNet.Build.CloudTestTasks",In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?
+116,"@@ -151,7 +151,9 @@ class BlacklistRuleBook(bre.BaseRuleBook):
+             lists: first one is IP addresses,
+             second one is network blocks
+         """"""
+-        data = urllib2.urlopen(url).read()
++        req = urllib2.build_opener()
++        req.addheaders = [('User-Agent', 'Forseti blacklist rules engine agent')]
++        data = req.open(url).read()
+         ip_addresses = re.findall(r'^[0-9]+(?:\.[0-9]+){3}$', data, re.M)
+         netblocks = re.findall(r'^[0-9]+(?:\.[0-9]+){0,3}/[0-9]{1,2}$',
+                                data, re.M)","Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?"
+117,"@@ -1405,6 +1405,8 @@ def getFormatFieldSpeech(attrs,attrsCache=None,formatConfig=None,unit=None,extra
+ 		linePrefix=attrs.get(""line-prefix"")
+ 		if linePrefix:
+ 			textList.append(linePrefix)
++	breakpoint=attrs.get(""breakpoint"")
++	if breakpoint: textList.append(breakpoint)
+ 	if attrsCache is not None:
+ 		attrsCache.clear()
+ 		attrsCache.update(attrs)","@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?"
+118,"@@ -539,7 +539,10 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            return self.size, self.location
+
+     @property
+     def screenshot_as_base64(self):",This would return a tuple of two dictionaries. You need to combine them and return a dictionary
+119,"@@ -7,10 +7,14 @@ import (
+ 	""errors""
+ 	""fmt""
+
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/manifest""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/secretsmanager""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/ssm""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/color""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/log""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/prompt""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/workspace""
+
+ 	""github.com/spf13/cobra""
+ )","What do you think of moving the example to the help text of the prompt? and the prompt itself can be ""What is your application's GitHub repository URL?"""
+120,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.
+121,"@@ -266,7 +266,7 @@ bool parse_it(Iterator &first, Iterator last, RDKit::RWMol &mol) {
+       } else {
+         if (!parse_atom_labels(first, last, mol)) return false;
+       }
+-    } else if ((first + 9) < last &&
++    } else if (std::distance(first, last) > 9 &&
+                std::string(first, first + 9) == ""atomProp:"") {
+       first += 9;
+       if (!parse_atom_props(first, last, mol)) return false;",Nice use of std::distance. I'm a bit worried about first += 9 though.
+122,"@@ -578,8 +578,9 @@ func (c *Operator) syncNodeEndpoints(ctx context.Context) error {
+ 		ObjectMeta: metav1.ObjectMeta{
+ 			Name: c.kubeletObjectName,
+ 			Labels: c.config.Labels.Merge(map[string]string{
+-				""k8s-app"":                ""kubelet"",
+-				""app.kubernetes.io/name"": ""kubelet"",
++				""k8s-app"":                   ""kubelet"",
++				""app.kubernetes.io/name"":    ""kubelet"",
++				""app.kubernetes.io/part-of"": ""prometheus-operator"",
+ 			}),
+ 		},
+ 		Subsets: []v1.EndpointSubset{","Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?"
+123,"@@ -41,8 +41,9 @@ namespace Datadog.Trace.ClrProfiler
+
+                 if (parent != null &&
+                     parent.Type == SpanTypes.Http &&
+-                    parent.GetTag(Tags.HttpMethod).Equals(httpMethod, StringComparison.OrdinalIgnoreCase) &&
+-                    parent.GetTag(Tags.HttpUrl).Equals(UriHelpers.CleanUri(requestUri, removeScheme: false, tryRemoveIds: false), StringComparison.OrdinalIgnoreCase))
++                    parent.GetTag(Tags.InstrumentationName) != null &&
++                    httpMethod.Equals(parent.GetTag(Tags.HttpMethod), StringComparison.OrdinalIgnoreCase) &&
++                    UriHelpers.CleanUri(requestUri, removeScheme: false, tryRemoveIds: false).Equals(parent.GetTag(Tags.HttpUrl), StringComparison.OrdinalIgnoreCase))
+                 {
+                     // we are already instrumenting this,
+                     // don't instrument nested methods that belong to the same stacktrace","As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?"
+124,"@@ -19,6 +19,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/node""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/update""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/version""
++	xrc20 ""github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20""
+ )
+
+ // RootCmd represents the base command when called without any subcommands",No need to have `xrc20` alias
+125,"@@ -172,6 +172,19 @@ def define_environment_cls(pipeline_def):
+     )
+
+
++def context_cls_inst(pipeline_def):
++    check.inst_param(pipeline_def, 'pipeline_def', PipelineDefinition)
++    pipeline_name = camelcase(pipeline_def.name)
++    return SystemNamedDict(
++        name='{pipeline_name}.Context'.format(pipeline_name=pipeline_name),
++        fields={
++            'context': define_maybe_optional_selector_field(
++                define_context_context_cls(pipeline_name, pipeline_def.context_definitions)
++            )
++        },
++    ).inst()
++
++
+ def define_expectations_config_cls(name):
+     check.str_param(name, 'name')
+ ",the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn
+126,"@@ -54,6 +54,7 @@ public class BlockMiner<C, M extends AbstractBlockCreator<C>> implements Runnabl
+   private final ProtocolSchedule<C> protocolSchedule;
+   private final Subscribers<MinedBlockObserver> observers;
+   private final AbstractBlockScheduler scheduler;
++  private Boolean gpuMining = false;
+
+   public BlockMiner(
+       final Function<BlockHeader, M> blockCreatorFactory,","Don't call it GPU mining, call it `externalMining`, here and throughout."
+127,"@@ -252,6 +252,15 @@ return [
+     | folder - a folder prefix for storing all generated files inside.
+     | path   - the public path relative to the application base URL,
+     |          or you can specify a full URL path.
++    |
++    | For the 'media' resource you can also specify:
++    |
++    | imageMaxWidth     - Resize all media manager image uploads to be
++    |                     within this with (in pixels, 0 = ignore)
++    | imageMaxHeight    - Resize all media manager image uploads to be
++    |                     within this height (in pixels, 0 = ignore)
++    | imageQuality      - Set this quality to all media manager image uploads
++    |                     (1-100)
+     */
+
+     'storage' => [","`within this with` typo, should be `within this width`"
+128,"@@ -22,10 +22,12 @@ import (
+ )
+
+ // Prometheus defines a Prometheus deployment.
++// +k8s:openapi-gen=true
+ type Prometheus struct {
+ 	metav1.TypeMeta `json:"",inline""`
+ 	// Standard object’s metadata. More info:
+ 	// https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#metadata
++	// +k8s:openapi-gen=false
+ 	metav1.ObjectMeta `json:""metadata,omitempty""`
+ 	// Specification of the desired behavior of the Prometheus cluster. More info:
+ 	// https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#spec-and-status",how come this is false?
+129,"@@ -24,6 +24,19 @@ function node_require(module) {
+     return require(module);
+ }
+
++function typeOf(obj) {
++    return ({}).toString.call(obj).match(/\s(\w+)/)[1].toLowerCase();
++}
++
++function checkTypes(args, types) {
++    args = [].slice.call(args);
++    for (var i = 0; i < types.length; ++i) {
++        if (typeOf(args[i]) !== types[i]) {
++            throw new TypeError('param ' + i + ' must be of type ' + types[i]);
++        }
++    }
++}
++
+ const performFetch = typeof fetch === 'undefined' ? node_require('node-fetch') : fetch;
+
+ const url_parse = require('url-parse');",How about `Object.prototype.toString`? Or using the `typeof` operator?
+130,"@@ -83,6 +83,7 @@ type ReporterKBPKI struct {
+ 	notifySyncBuffer chan *keybase1.FSPathSyncStatus
+ 	suppressCh       chan time.Duration
+ 	canceler         func()
++	ctx              context.Context
+ }
+
+ // NewReporterKBPKI creates a new ReporterKBPKI.","I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly."
+131,"@@ -12,12 +12,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Networking
+         {
+             IsWindows = PlatformApis.IsWindows;
+
+-            var isDarwinMono =
+-#if DNX451
+-                IsWindows ? false : PlatformApis.IsDarwin;
+-#else
+-                false;
+-#endif
++            var isDarwinMono = !IsWindows && PlatformApis.IsDarwin;
+
+             if (isDarwinMono)
+             {",This check isn't right though.
+132,"@@ -96,6 +96,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+     return missingDefaultServiceAddress() || missingDefaultServiceScopes();
+   }
+
++  public abstract String codeGenVersion();
++
+   @Override
+   public String resourceRoot() {
+     return SnippetSetRunner.SNIPPET_RESOURCE_ROOT;","maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself."
+133,"@@ -230,15 +230,13 @@ module.exports = class XHRUpload extends Plugin {
+           const body = opts.getResponseData(xhr.responseText, xhr)
+           const uploadURL = body[opts.responseUrlFieldName]
+
+-          const response = {
++          const uploadResp = {
+             status: ev.target.status,
+             body,
+             uploadURL
+           }
+
+-          this.uppy.setFileState(file.id, { response })
+-
+-          this.uppy.emit('upload-success', file, body, uploadURL)
++          this.uppy.emit('upload-success', file, uploadResp)
+
+           if (uploadURL) {
+             this.uppy.log(`Download ${file.name} from ${file.uploadURL}`)","the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now "
+134,"@@ -134,7 +134,7 @@ func (s *stream) Read(p []byte) (int, error) {
+ 			} else {
+ 				select {
+ 				case <-s.readChan:
+-				case <-time.After(deadline.Sub(time.Now())):
++				case <-time.After(time.Until(deadline)):
+ 				}
+ 			}
+ 			s.mutex.Lock()",This isn't really easy to read.
+135,"@@ -123,7 +123,7 @@ func (c *CStorVolumeReplicaController) cVREventHandler(operation common.QueueOpe
+
+ 		err := volumereplica.DeleteVolume(fullVolName)
+ 		if err != nil {
+-			glog.Errorf(""Error in deleting volume %q: %s"", cVR.ObjectMeta.Name,err)
++			glog.Errorf(""Error in deleting volume %q: %s"", cVR.ObjectMeta.Name, err)
+ 			c.recorder.Event(cVR, corev1.EventTypeWarning, string(common.FailureDestroy), string(common.MessageResourceFailDestroy))
+ 			return string(apis.CVRStatusDeletionFailed), err
+ 		}",This line changed due to go formatting. Format was not there earlier.
+136,"@@ -28,13 +28,13 @@ type staticUpstream struct {
+ 		Path     string
+ 		Interval time.Duration
+ 	}
++	Without string
+ }
+
+ // NewStaticUpstreams parses the configuration input and sets up
+ // static upstreams for the proxy middleware.
+ func NewStaticUpstreams(c parse.Dispenser) ([]Upstream, error) {
+ 	var upstreams []Upstream
+-
+ 	for c.Next() {
+ 		upstream := &staticUpstream{
+ 			from:        """",","The name ""Without"" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)"
+137,"@@ -254,6 +254,12 @@ public class MoveIT {
+         linkDataset.then().assertThat()
+                 .statusCode(OK.getStatusCode());
+
++        // A dataset cannot be linked to the same dataverse again.
++        Response tryToLinkAgain = UtilIT.linkDataset(datasetPid, dataverse2Alias, superuserApiToken);
++        tryToLinkAgain.prettyPrint();
++        tryToLinkAgain.then().assertThat()
++                .statusCode(FORBIDDEN.getStatusCode());
++
+         Response getLinksBefore = UtilIT.getDatasetLinks(datasetPid, superuserApiToken);
+         getLinksBefore.prettyPrint();
+         getLinksBefore.then().assertThat()","is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here."
+138,"@@ -368,5 +368,8 @@ type Instance struct {
+ 	EBSOptimized *bool `json:""ebsOptimized""`
+
+ 	// The tags associated with the instance.
+-	Tags map[string]string `json:""tag""`
++	Tags map[string]string `json:""tags""`
++
++	// The security groups associated with the instance.
++	SecurityGroups map[string]string `json:""securityGroups""`
+ }","I'm not sure if this wanted to be `json:""tags""` (which I'd set in my PR) or `json:""tag""` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`."
+139,"@@ -47,6 +47,11 @@ module Ncr
+       message: ""must be three letters or numbers""
+     }, allow_blank: true
+
++    scope :for_fiscal_year, lambda { |year|
++      range = self.class.range_for_fiscal_year(year)
++      where(created_at: range[:start_time]...range[:end_time])
++    }
++
+     def self.all_system_approver_emails
+       [
+         self.ba61_tier1_budget_mailbox,","since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?"
+140,"@@ -42,6 +42,11 @@ class InfluxWriterSubscriber(object):
+         self.time = 0
+
+
++    def on_connection_closed(self, connection, reply_code, reply_text):
++        self.log.info('RabbitMQ connection got closed!')
++        self.connection.add_timeout(5, self.connect_to_rabbitmq)
++
++
+     @staticmethod
+     def static_callback(ch, method, properties, body, obj):
+         return obj.callback(ch, method, properties, body)",there is no static method as a go between -- how does this work?
+141,"@@ -0,0 +1,8 @@
++# frozen_string_literal: true
++# encoding: utf-8
++
++class StringifiedSymbol
++  include Mongoid::Document
++  store_in collection: ""stringified_symbols"", client: :other
++  field :stringified_symbol, type: StringifiedSymbol
++end",Can you please change the name of this class to be something else?
+142,"@@ -403,7 +403,7 @@ size_t h2o_strstr(const char *haysack, size_t haysack_len, const char *needle, s
+ }
+
+ /* note: returns a zero-width match as well */
+-const char *h2o_next_token(h2o_iovec_t *iter, int separator, size_t *element_len, h2o_iovec_t *value)
++const char *h2o_next_token(h2o_iovec_t *iter, int separator, size_t *element_len, h2o_iovec_t *value, int coma_separator)
+ {
+     const char *cur = iter->base, *end = iter->base + iter->len, *token_start, *token_end;
+ ","I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`."
+143,"@@ -43,8 +43,8 @@ namespace Nethermind.Blockchain
+     {
+         private const long LowestInsertedBodyNumberDbEntryAddress = 0;
+         private const int CacheSize = 64;
+-        private readonly ICache<Keccak, Block> _blockCache = new LruCacheWithRecycling<Keccak, Block>(CacheSize, CacheSize, ""blocks"");
+-        private readonly ICache<Keccak, BlockHeader> _headerCache = new LruCacheWithRecycling<Keccak, BlockHeader>(CacheSize, CacheSize, ""headers"");
++        private readonly ICache<Keccak, Block> _blockCache = new LruCache<Keccak, Block>(CacheSize, CacheSize, ""blocks"");
++        private readonly ICache<Keccak, BlockHeader> _headerCache = new LruCache<Keccak, BlockHeader>(CacheSize, CacheSize, ""headers"");
+
+         private const int BestKnownSearchLimit = 256_000_000;
+ ",why not recycling? I Lru cache now recycling?
+144,"@@ -69,7 +69,7 @@ func (consumer *createConsumer) Consume(requestPtr interface{}) (response interf
+ 	issuerID := consumer.peerID
+ 	if request.ConsumerInfo != nil {
+ 		issuerID = request.ConsumerInfo.IssuerID
+-		if request.ConsumerInfo.PaymentVersion == PaymentVersionV2 {
++		if request.ConsumerInfo.PaymentVersion == PaymentVersionV3 {
+ 			indicateNewVersion = true
+ 		}
+ 	} else {",Why it is now called `PaymentVersionV3`?
+145,"@@ -165,7 +165,7 @@ func (dc *DownstreamController) syncSecret() {
+ 			}
+
+ 			nodes := dc.lc.SecretNodes(secret.Namespace, secret.Name)
+-			klog.Infof(""there are %d nodes need to sync secret, operation: %s"", len(nodes), e.Type)
++			klog.V(4).Infof(""there are %d nodes need to sync secret, operation: %s"", len(nodes), e.Type)
+ 			for _, n := range nodes {
+ 				msg := model.NewMessage("""")
+ 				msg.SetResourceVersion(secret.ResourceVersion)",changed for debug purpose?
+146,"@@ -46,6 +46,13 @@ namespace OpenTelemetry
+         /// <inheritdoc />
+         public abstract override void OnEnd(T data);
+
++        internal override void SetParentProvider(BaseProvider parentProvider)
++        {
++            base.SetParentProvider(parentProvider);
++
++            this.exporter.ParentProvider = parentProvider;
++        }
++
+         /// <inheritdoc />
+         protected override bool OnShutdown(int timeoutMilliseconds)
+         {",@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though.
+147,"@@ -31,9 +31,13 @@ inline extractor::RoadClassification roadClass(const ConnectedRoad &road,
+     return graph.GetEdgeData(road.eid).flags.road_classification;
+ }
+
+-inline bool isRampClass(EdgeID eid, const util::NodeBasedDynamicGraph &node_based_graph)
++inline bool isRampClass(EdgeID eid,
++                        const util::NodeBasedDynamicGraph &node_based_graph,
++                        bool from_motorway = true)
+ {
+-    return node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass();
++    return node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass() ||
++           (from_motorway &&
++            node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass());
+ }
+
+ } // namespace",Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario.
+148,"@@ -13,7 +13,7 @@ module Beaker
+           :q_verify_packages => ENV['q_verify_packages'] || 'y',
+           :q_puppet_symlinks_install => 'y',
+           :q_puppetagent_certname => host,
+-          :q_puppetagent_server => master,
++          :q_puppetagent_server => master_certname,
+
+           # Disable database, console, and master by default
+           # This will be overridden by other blocks being merged in.",where does `master_certname` come from?
+149,"@@ -1,5 +1,7 @@
+ from .resnet import ResNet, make_res_layer
+ from .resnext import ResNeXt
+ from .ssd_vgg import SSDVGG
++from .hrnet import HRNet
+
+-__all__ = ['ResNet', 'make_res_layer', 'ResNeXt', 'SSDVGG']
++__all__ = ['ResNet', 'make_res_layer', 'ResNeXt', 'SSDVGG',
++           'HRNet']",The line breaking is unnecessary.
+150,"@@ -28,7 +28,7 @@ void DatasetLoader::SetHeader(const char* filename) {
+     // get column names
+     if (io_config_.has_header) {
+       std::string first_line = text_reader.first_line();
+-      feature_names_ = Common::Split(first_line.c_str(), ""\t ,"");
++      feature_names_ = Common::Split(first_line.c_str(), ""\t,"");
+     }
+
+     // load label idx first",why not enable split by space here ?
+151,"@@ -1076,7 +1076,8 @@ fpga_result mmio_error(struct RASCommandLine *rasCmdLine)
+ 		return result;
+ 	}
+
+-	if(value != FPGA_INTEGRATED_DEVICEID) {
++	if( (value != FPGA_INTEGRATED_DEVICEID) ||
++		(value != FPGA_DISCRETE_DEVICEID) ) {
+ 		FPGA_ERR(""Failed  to read Device id"");
+ 		return FPGA_NOT_SUPPORTED;
+ 	}",Shouldn't the operator be && ?
+152,"@@ -161,6 +161,17 @@ module Beaker
+       FileUtils.rm_rf(@vagrant_path)
+     end
+
++    #snapshotting depends on https://github.com/scalefactory/vagrant-multiprovider-snap
++    def take_snapshot(host,snapshot_name)
++      @logger.debug ""Creating snapshot of #{host}""
++      vagrant_cmd(""snap take #{host} --name=#{snapshot_name}"")
++    end
++
++    def restore_snapshot(host,snapshot_name)
++      @logger.debug ""Restoring snapshot of #{host}""
++      vagrant_cmd(""snap rollback #{host} --name=#{snapshot_name}"")
++    end
++
+     def vagrant_cmd(args)
+       Dir.chdir(@vagrant_path) do
+         exit_status = 1",My best guess is that you want to use host.name in these parts to get the name of the host ?
+153,"@@ -270,13 +270,6 @@ func (n *Node) UnmarshalBinary(data []byte) error {
+
+ 		n.entry = append([]byte{}, data[nodeHeaderSize:nodeHeaderSize+refBytesSize]...)
+ 		offset := nodeHeaderSize + refBytesSize // skip entry
+-		// Currently we don't persist the root nodeType when we marshal the manifest, as a result
+-		// the root nodeType information is lost on Unmarshal. This causes issues when we want to
+-		// perform a path 'Walk' on the root. If there is more than 1 fork, the root node type
+-		// is an edge, so we will deduce this information from index byte array
+-		if !bytes.Equal(data[offset:offset+32], make([]byte, 32)) {
+-			n.nodeType = nodeTypeEdge
+-		}
+ 		n.forks = make(map[byte]*fork)
+ 		bb := &bitsForBytes{}
+ 		bb.fromBytes(data[offset:])","IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`"
+154,"@@ -205,9 +205,10 @@ public class DownloadService extends Service {
+         Log.d(TAG, ""Service shutting down"");
+         isRunning = false;
+
++        boolean showAutoDownloadReport = UserPreferences.showAutoDownloadReport();
+         if (ClientConfig.downloadServiceCallbacks.shouldCreateReport()
+-                && UserPreferences.showDownloadReport()) {
+-            notificationManager.updateReport(reportQueue);
++                && (UserPreferences.showDownloadReport() || showAutoDownloadReport)) {
++            notificationManager.updateReport(reportQueue, showAutoDownloadReport);
+             reportQueue.clear();
+         }
+ ","Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though."
+155,"@@ -140,3 +140,11 @@ func (c *Call) RoutingDelegate() string {
+ 	}
+ 	return c.ic.req.RoutingDelegate
+ }
++
++// Features returns the RequestFeatures for this request.
++func (c *Call) Features() transport.RequestFeatures {
++	if c == nil {
++		return transport.RequestFeatures{}
++	}
++	return c.ic.req.Features
++}",Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?
+156,"@@ -1202,3 +1202,15 @@ L:
+ 	}
+ 	return filtered
+ }
++
++func (a *WebAPI) GenerateAPIKey(ctx context.Context, req *webservice.GenerateAPIKeyRequest) (*webservice.GenerateAPIKeyResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *WebAPI) DisableAPIKey(ctx context.Context, req *webservice.DisableAPIKeyRequest) (*webservice.DisableAPIKeyResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *WebAPI) ListAPIKeys(ctx context.Context, req *webservice.ListAPIKeysRequest) (*webservice.ListAPIKeysResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}",`ctx` is unused in GenerateAPIKey
+157,"@@ -75,6 +75,7 @@ type (
+ func NewBlockDAO(indexers []BlockIndexer, cfg config.DB) BlockDAO {
+ 	blkStore, err := filedao.NewFileDAO(cfg)
+ 	if err != nil {
++		log.L().Fatal(err.Error(), zap.Any(""cfg"", cfg))
+ 		return nil
+ 	}
+ 	return createBlockDAO(blkStore, indexers, cfg)",Can you judge the type of error?
+158,"@@ -204,7 +204,7 @@ class GridInterface(DictInterface):
+         if edges and not isedges:
+             data = cls._infer_interval_breaks(data)
+         elif not edges and isedges:
+-            data = np.convolve(data, [0.5, 0.5], 'valid')
++            data = data[:-1] + np.diff(data)/2.
+         return data
+
+ ",Much simpler than a weird and confusing ``convolve`` call!
+159,"@@ -739,8 +739,8 @@ describe('suspense', () => {
+ 				expect(scratch.innerHTML).to.eql(
+ 					`<div>Hello first 2</div><div>Hello second 2</div>`
+ 				);
+-				expect(Suspender1.prototype.render).to.have.been.calledThrice;
+-				expect(Suspender2.prototype.render).to.have.been.calledThrice;
++				expect(Suspender1.prototype.render).to.have.been.calledTwice;
++				expect(Suspender2.prototype.render).to.have.been.calledTwice;
+ 			});
+ 		});
+ 	});","Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `<div>Hello second 2</div>` output... Imma take a peak at these tests to understand what's going on"
+160,"@@ -80,6 +80,10 @@ class ApplicationController < ActionController::Base
+   def failed_destroy_error(obj, obj_name)
+     ""#{_('Could not delete the %{o}.') % {o: obj_name}} #{errors_to_s(obj)}""
+   end
++
++  def success_message(obj_name, action)
++    ""#{_('Successfully %{action} your %{object}.') % {object: obj_name, action: action}}""
++  end
+
+   private
+     # Override rails default render action to look for a branded version of a","Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper."
+161,"@@ -92,7 +92,7 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme
+
+ # Template used to display messages. This is a python new-style format string
+ # used to format the message information. See doc for all details
+-#msg-template=
++msg-template=[{msg_id}] {path}:{line:3d}:{column}: {msg}
+
+
+ [SPELLING]","Will this mess up parsing the messages by other editors? (vscode, vim ...)"
+162,"@@ -1,4 +1,3 @@
+-# Set up gems listed in the Gemfile.
+-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
++ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+
+-require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
++require 'bundler/setup' # Set up gems listed in the Gemfile.",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+163,"@@ -28,8 +28,13 @@ namespace Microsoft.AspNet.Server.Kestrel.Filter
+             _filteredStream = filteredStream;
+             _socketInputStream = new SocketInputStream(SocketInput);
+
+-            _filteredStream.CopyToAsync(_socketInputStream).ContinueWith((task, state) =>
++            var block = memory.Lease();
++            // Use pooled block for copy
++            _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) =>
+             {
++                var returnedBlock = task.Result;
++                returnedBlock.Pool?.Return(returnedBlock);
++
+                 ((FilteredStreamAdapter)state).OnStreamClose(task);
+             }, this);
+         }",Why can the pool be null?
+164,"@@ -74,6 +74,15 @@ class ToggleButton(ia2Web.Ia2Web):
+ 		return states
+
+
++class PresentationalList(ia2Web.Ia2Web):
++	"""""" Ensures that lists like UL, DL and OL always have the readonly state.""""""
++
++	def _get_states(self):
++		states = super().states
++		states.add(controlTypes.STATE_READONLY)
++		return states
++
++
+ def findExtraOverlayClasses(obj, clsList):
+ 	""""""Determine the most appropriate class(es) for Chromium objects.
+ 	This works similarly to L{NVDAObjects.NVDAObject.findOverlayClasses} except that it never calls any other findOverlayClasses method.","It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable."
+165,"@@ -66,16 +66,16 @@ import java.util.Set;
+  * the current node) may be queried.
+  *
+  */
+-class DigraphNode implements Cloneable, Serializable {
++class DigraphNode<E> implements Cloneable, Serializable {
+
+     /** The data associated with this node. */
+-    protected Object data;
++    protected E data;
+
+     /**
+      * A <code>Set</code> of neighboring nodes pointed to by this
+      * node.
+      */
+-    protected Set outNodes = new HashSet();
++    protected Set<DigraphNode<E>> outNodes = new HashSet<>();
+
+     /** The in-degree of the node. */
+     protected int inDegree = 0;",This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?
+166,"@@ -282,8 +282,12 @@ void nano::bootstrap_attempt_legacy::request_push (nano::unique_lock<std::mutex>
+ void nano::bootstrap_attempt_legacy::add_frontier (nano::pull_info const & pull_a)
+ {
+ 	nano::pull_info pull (pull_a);
+-	nano::lock_guard<std::mutex> lock (mutex);
+-	frontier_pulls.push_back (pull);
++	// Prevent incorrent or malicious pulls with frontier 0 insertion
++	if (!pull.head.is_zero ())
++	{
++		nano::lock_guard<std::mutex> lock (mutex);
++		frontier_pulls.push_back (pull);
++	}
+ }
+
+ void nano::bootstrap_attempt_legacy::add_bulk_push_target (nano::block_hash const & head, nano::block_hash const & end)",There doesn't seem to be a reason to copy this here.
+167,"@@ -1774,6 +1774,7 @@ std::string h2o_raw_tracer::bpf_text() {
+
+ #include <linux/sched.h>
+ #include <linux/limits.h>
++#include ""include/h2o/ebpf.h""
+
+ #define STR_LEN 64
+ ","We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs."
+168,"@@ -170,6 +170,10 @@ type ThanosRulerSpec struct {
+ 	// Note: Currently only the CAFile, CertFile, and KeyFile fields are supported.
+ 	// Maps to the '--grpc-server-tls-*' CLI args.
+ 	GRPCServerTLSConfig *TLSConfig `json:""grpcServerTlsConfig,omitempty""`
++	// The external Query URL the Thanos Ruler will set in the 'Source' field
++	// of all alerts.
++	// Maps to the '--alert.query-url' CLI arg.
++	AlertQueryURL string `json:""alertQueryUrl,omitempty""`
+ }
+
+ // ThanosRulerStatus is the most recent observed status of the ThanosRuler. Read-only. Not",I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses.
+169,"@@ -224,9 +224,7 @@ func (m *ipipManager) CompleteDeferredWork() error {
+ 		for _, ip := range m.activeHostnameToIP {
+ 			members = append(members, ip)
+ 		}
+-		for _, ip := range m.externalNodeCIDRs {
+-			members = append(members, ip)
+-		}
++		members = append(members, m.externalNodeCIDRs...)
+ 		m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, members)
+ 		m.ipSetInSync = true
+ 	}",Same change just above?
+170,"@@ -511,4 +511,14 @@ describe('services_SearchEngine', function() {
+ 		expect((await engine.search('""- [ ]""', { searchType: SearchEngine.SEARCH_TYPE_BASIC })).length).toBe(1);
+ 		expect((await engine.search('""[ ]""', { searchType: SearchEngine.SEARCH_TYPE_BASIC })).length).toBe(2);
+ 	}));
++
++	it('should not mistake cyrillic ""l"" for latin ""n""', asyncTest(async () => {
++		const n1 = await Note.save({ title: 'latin n', body: 'n' });
++		const n2 = await Note.save({ title: 'cyrillic l', body: 'л' });
++
++		await engine.syncTables();
++
++		expect((await engine.search('n')).length).toBe(1);
++		expect((await engine.search('л')).length).toBe(1);
++	}));
+ });","Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning ""latin n"" for both queries, we won't know about it."
+171,"@@ -47,9 +47,10 @@ const (
+
+ 	otherDomainID = ""spiffe://otherdomain.test""
+
+-	serverID   = ""spiffe://example.org/spire/server""
+-	agentID    = ""spiffe://example.org/spire/agent/test/id""
+-	workloadID = ""spiffe://example.org/workload""
++	serverID    = ""spiffe://example.org/spire/server""
++	agentID     = ""spiffe://example.org/spire/agent/test/id""
++	agentlessID = ""spiffe://example.org/test/id""
++	workloadID  = ""spiffe://example.org/workload""
+
+ 	// used to cancel stream operations on test failure instead of blocking the
+ 	// full go test timeout period (i.e. 10 minutes)",nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways
+172,"@@ -1,4 +1,4 @@
+-require 'spec_helper'
++require 'rails_helper'
+
+ feature 'Admin manages mentors' do
+   scenario 'creating a new mentor' do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+173,"@@ -204,11 +204,7 @@ public class ClassTypeResolver extends JavaParserVisitorAdapter {
+             if (className != null) {
+                 populateClassName(node, className);
+             }
+-        } catch (ClassNotFoundException e) {
+-            if (LOG.isLoggable(Level.FINE)) {
+-                LOG.log(Level.FINE, ""Could not find class "" + className + "", due to: "" + e);
+-            }
+-        } catch (NoClassDefFoundError e) {
++        } catch (ClassNotFoundException | NoClassDefFoundError e) {
+             if (LOG.isLoggable(Level.FINE)) {
+                 LOG.log(Level.FINE, ""Could not find class "" + className + "", due to: "" + e);
+             }",We should have a rule to detect identical catch branches
+174,"@@ -28,10 +28,6 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+
+         public bool PublishFlatContainer { get; set; }
+
+-        public int RetryAttempts { get; set; } = 5;
+-
+-        public int RetryDelayInSeconds { get; set; } = 30;
+-
+         public int MaxClients { get; set; } = 8;
+
+         public bool SkipCreateContainer { get; set; } = false;",remove these from the targets file.
+175,"@@ -11,14 +11,13 @@ import (
+ 	""time""
+
+ 	""github.com/ethersphere/bee/pkg/addressbook""
++	""github.com/ethersphere/bee/pkg/bzz""
+ 	""github.com/ethersphere/bee/pkg/hive/pb""
+ 	""github.com/ethersphere/bee/pkg/logging""
+ 	""github.com/ethersphere/bee/pkg/p2p""
+ 	""github.com/ethersphere/bee/pkg/p2p/protobuf""
+ 	""github.com/ethersphere/bee/pkg/storage""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+-
+-	ma ""github.com/multiformats/go-multiaddr""
+ )
+
+ const (","now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe"
+176,"@@ -35,11 +35,12 @@ NAMESPACE_PACKAGES = [
+ REQUIRED_PACKAGES = [
+     # Installation related.
+     'anytree==2.4.3',
+-    'google-api-python-client==1.7.7',
+-    'google-auth==1.6.2',
++    'google-api-python-client==1.7.10',
++    'google-auth==1.6.3',
+     'google-auth-httplib2==0.0.3',
+     'Jinja2==2.10.1',
+     'jmespath==0.9.3',
++    'mailjet-rest==1.3.3',
+     'netaddr==0.7.19',
+     'pyyaml==4.2b4',
+     'python-graph-core==1.8.2',","I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?"
+177,"@@ -8,10 +8,7 @@ package javaslang.control;
+ import javaslang.Serializables;
+ import org.junit.Test;
+
+-import java.util.Iterator;
+-import java.util.NoSuchElementException;
+-import java.util.Objects;
+-import java.util.Optional;
++import java.util.*;
+
+ import static org.assertj.core.api.Assertions.assertThat;
+ ",I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard.
+178,"@@ -29,7 +29,9 @@ module Beaker
+         v_file << ""    v.vm.box = '#{host['box']}'\n""
+         v_file << ""    v.vm.box_url = '#{host['box_url']}'\n"" unless host['box_url'].nil?
+         v_file << ""    v.vm.base_mac = '#{randmac}'\n""
+-        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
++        host['ips'].each do |ip|
++          v_file << ""    v.vm.network :private_network, ip: \""#{ip.to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
++        end
+
+         if host['disk_path']
+           v_file << ""    v.vm.provider :virtualbox do |vb|\n""",Where is host['ips'] coming from?
+179,"@@ -3,14 +3,7 @@
+
+ package userns
+
+-import (
+-	""strings""
+-
+-	""github.com/opencontainers/runc/libcontainer/user""
+-)
+-
+-func FuzzUIDMap(data []byte) int {
+-	uidmap, _ := user.ParseIDMap(strings.NewReader(string(data)))
+-	_ = uidMapInUserNS(uidmap)
++func FuzzUIDMap(uidmap []byte) int {
++	_ = uidMapInUserNS(string(uidmap))
+ 	return 1
+ }",oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable
+180,"@@ -1,6 +1,8 @@
+ describe ""Display status text"" do
+   let(:proposal) { FactoryGirl.create(:proposal, :with_parallel_approvers) }
+   before do
++    proposal.approvers.first.update(first_name: ""Uniquely"", last_name: ""Named"")
++    proposal.approvers.second.update(first_name: ""Onlyof"", last_name: ""Itskind"")
+     login_as(proposal.requester)
+   end
+ ",Is this necessary?
+181,"@@ -1,8 +1,16 @@
+-import React from 'react';
++import React, {Component} from 'react';
+ import 'element-theme-default';
+ import {i18n} from 'element-react';
+ import locale from 'element-react/src/locale/lang/en';
+
++import storage from './utils/storage';
++import logo from './utils/logo';
++import {makeLogin, isTokenExpire} from './utils/login';
++
++import Header from './components/Header';
++import Footer from './components/Footer';
++import LoginModal from './components/Login';
++
+ i18n.use(locale);
+
+ import Route from './router';",I'd create a different method for each render section.
+182,"@@ -23,6 +23,8 @@ public class EstimateGasOperationTracer implements OperationTracer {
+
+   private Gas sStoreStipendNeeded = Gas.ZERO;
+
++  private boolean isReverted = false;
++
+   @Override
+   public void traceExecution(
+       final MessageFrame frame, final OperationTracer.ExecuteOperation executeOperation) {",Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?
+183,"@@ -71,7 +71,7 @@ public class TestSparkOrcReader extends AvroDataTest {
+
+     try (CloseableIterable<InternalRow> reader = ORC.read(Files.localInput(testFile))
+         .project(schema)
+-        .createReaderFunc(SparkOrcReader::new)
++        .createReaderFunc(readOrcSchema -> new SparkOrcReader(schema, readOrcSchema))
+         .build()) {
+       final Iterator<InternalRow> actualRows = reader.iterator();
+       final Iterator<InternalRow> expectedRows = expected.iterator();",I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized.
+184,"@@ -100,6 +100,10 @@ abstract class BaseFile<F>
+           found = true;
+           fromProjectionPos[i] = j;
+         }
++        if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId()) {
++          found = true;
++          fromProjectionPos[i] = 14;
++        }
+       }
+
+       if (!found) {",These modifications allow BaseFile to translate into a SparkRow with the specID as a column
+185,"@@ -519,7 +519,7 @@ function resolveReadPreference(parent, options) {
+     throw new Error('No readPreference was provided or inherited.');
+   }
+
+-  return readPreference;
++  return typeof readPreference === 'string' ? new ReadPreference(readPreference) : readPreference;
+ }
+
+ /**",is this something we've been missing this whole time?
+186,"@@ -25,6 +25,7 @@ import (
+ const (
+ 	defaultWaitApprovalTimeout  = Duration(6 * time.Hour)
+ 	defaultAnalysisQueryTimeout = Duration(30 * time.Second)
++	allEvents                   = ""*""
+ )
+
+ type GenericDeploymentSpec struct {",nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`.
+187,"@@ -111,6 +111,15 @@ def generate_thrift_files(thrift_files_dir, env, silent=True):
+         LOG.error('Failed to generate viewer server files')
+         return ret
+
++    auth_thrift = os.path.join(thrift_files_dir, 'authentication.thrift')
++    auth_thrift = 'authentication.thrift'
++    auth_cmd = ['thrift', '-r', '-I', '.',
++                '--gen', 'py', auth_thrift]
++    ret = run_cmd(auth_cmd, thrift_files_dir, env, silent=silent)
++    if ret:
++        LOG.error('Failed to generate authentication interface files')
++        return ret
++
+
+ # -------------------------------------------------------------------
+ def generate_documentation(doc_root, env, silent=True):",There seems to be some repetition. Does a local function make this code shorter overall?
+188,"@@ -298,6 +298,7 @@ function diffElementNodes(
+ 	}
+
+ 	if (dom == null) {
++		isHydrating = false;
+ 		if (newVNode.type === null) {
+ 			return document.createTextNode(newProps);
+ 		}",Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?
+189,"@@ -22,7 +22,6 @@ import java.util.List;
+
+ @AutoValue
+ public abstract class TestCaseView {
+-
+   public abstract String clientMethodName();
+
+   public abstract InitCodeView initCode();",Revert this blank line
+190,"@@ -50,8 +50,8 @@ public class MoveReplicaHDFSTest extends MoveReplicaTest {
+       HdfsTestUtil.teardownClass(dfsCluster);
+     } finally {
+       dfsCluster = null;
+-      System.setProperty(""solr.hdfs.blockcache.blocksperbank"", ""512"");
+-      System.setProperty(""tests.hdfs.numdatanodes"", ""1"");
++      System.clearProperty(""solr.hdfs.blockcache.blocksperbank"");
++      System.clearProperty(""tests.hdfs.numdatanodes"");
+     }
+   }
+ ",This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures.
+191,"@@ -2,6 +2,7 @@ class ProposalsController < ApplicationController
+   include TokenAuth
+
+   skip_before_action :authenticate_user!, only: [:approve]
++  before_action :check_disabled_client
+   # TODO use Policy for all actions
+   before_action ->{authorize proposal}, only: [:show, :cancel, :cancel_form, :history]
+   before_action :needs_token_on_get, only: :approve",I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client
+192,"@@ -56,9 +56,10 @@ class DefaultBucketViewTest(BaseWebTest, unittest.TestCase):
+         self.app.get(self.collection_url, headers=self.headers)
+
+     def test_querystring_parameters_are_taken_into_account(self):
+-        self.app.get(self.collection_url + '/records?_since=invalid',
+-                     headers=self.headers,
+-                     status=400)
++        resp = self.app.get(self.collection_url + '/records?_since=invalid',
++                            headers=self.headers,
++                            status=400)
++        self.assertIn('Content-Length', resp.headers)
+
+     def test_option_is_possible_without_authentication_for_default(self):
+         headers = 'authorization,content-type'",I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?
+193,"@@ -42,7 +42,7 @@ module Bolt
+         path = File.join(libexec, 'custom_facts.rb')
+         file = { 'name' => 'custom_facts.rb', 'path' => path }
+         metadata = { 'supports_noop' => true, 'input_method' => 'stdin' }
+-        Bolt::Task.new(name: 'custom_facts', files: [file], metadata: metadata)
++        Bolt::Task.new(name: 'apply_helpers::custom_facts', files: [file], metadata: metadata)
+       end
+     end
+ ","We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers."
+194,"@@ -0,0 +1,11 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Shopsys\ShopBundle\Model\Order\Item;
++
++use Shopsys\FrameworkBundle\Model\Order\Item\OrderItemFactory as BaseOrderItemFactory;
++
++class OrderItemFactory extends BaseOrderItemFactory
++{
++}",Why do you think that it is necessary to create this class?
+195,"@@ -18,8 +18,8 @@ type Hash struct {
+ //
+ // See http://docs.aws.amazon.com/amazonglacier/latest/dev/checksum-calculations.html for more information.
+ func ComputeHashes(r io.ReadSeeker) Hash {
+-	r.Seek(0, 0)       // Read the whole stream
+-	defer r.Seek(0, 0) // Rewind stream at end
++	start, _ := r.Seek(0, 1)  // Read the whole stream
++	defer r.Seek(start, 0) // Rewind stream at end
+
+ 	buf := make([]byte, bufsize)
+ 	hashes := [][]byte{}",replacing the `1` with `io.SeekCurrent` may be good here
+196,"@@ -0,0 +1,15 @@
++package main
++
++import (
++	""time""
++
++	""gopkg.in/square/go-jose.v2""
++)
++
++type JWKSSource interface {
++	// FetchJWKS returns the key set and modified time.
++	FetchKeySet() (*jose.JSONWebKeySet, time.Time, bool)
++
++	// Close closes the source.
++	Close() error
++}",nit: perhaps this file would be better named `jwks_source.go` ?
+197,"@@ -153,6 +153,9 @@ public class Constants {
+   // Overridable plugin load properties
+   public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = ""azkaban.plugin.load.override.props"";
+
++  // File containing param override configs
++  public static final String PARAM_OVERRIDE_FILE = ""param_override.properties"";
++
+   // Azkaban event reporter constants
+   public static class EventReporterConstants {
+ ",It will be helpful to specify the intended priority as well for the properties within this file.
+198,"@@ -23,6 +23,8 @@ import (
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/osinfo""
+ )
+
++type RunFunc func(*exec.Cmd) ([]byte, error)
++
+ var (
+ 	// AptExists indicates whether apt is installed.
+ 	AptExists bool","Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided."
+199,"@@ -1956,7 +1956,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		""OFF""),
+   DDkwd__(HIVE_DEFAULT_CHARSET,            (char *)SQLCHARSETSTRING_UTF8),
+   DD_____(HIVE_DEFAULT_SCHEMA,                  ""HIVE""),
+   DD_____(HIVE_FILE_CHARSET,                    """"),
+-  DD_____(HIVE_FILE_NAME,     ""/hive/tpcds/customer/customer.dat"" ),
++  DD_____(HIVE_FILE_NAME,     ""/user/trafodion/hive/tpcds/customer/customer.dat"" ),
+   DD_____(HIVE_HDFS_STATS_LOG_FILE,             """"),
+   DDui___(HIVE_INSERT_ERROR_MODE,               ""1""),
+   DDint__(HIVE_LIB_HDFS_PORT_OVERRIDE,          ""-1""),",Do you now why is it a specific table name is used as a default?
+200,"@@ -414,8 +414,8 @@ namespace Microsoft.DotNet.Build.Tasks
+                     return Environment.GetEnvironmentVariable(""TMPDIR"");
+                 else if (DirExists(Environment.GetEnvironmentVariable(""TMP"")))
+                     return Environment.GetEnvironmentVariable(""TMP"");
+-                else if (DirExists(""/home/DDITAdministrator/myagent/_work/_temp""))
+-                    return ""/home/DDITAdministrator/myagent/_work/_temp"";
++                else if (DirExists(Path.Combine(Environment.GetEnvironmentVariable(""HOME""), ""myagent/_work/_temp"")))
++                    return Path.Combine(Environment.GetEnvironmentVariable(""HOME""), ""myagent/_work/_temp"");
+                 else
+                 {
+                     Log.LogMessage(""No TEMP dir found."");","If all you're doing is checking for the existence of a directory as your ""temp"" directory, why does it matter what OS you're on?"
+201,"@@ -60,10 +60,11 @@
+ package server
+
+ import (
+-	""fmt""
++	v2 ""github.com/algorand/go-algorand/daemon/algod/api/server/v2""
++	""github.com/algorand/go-algorand/daemon/algod/api/server/v2/generated""
+ 	""net/http""
+
+-	""github.com/gorilla/mux""
++	""github.com/labstack/echo/v4""
+
+ 	""github.com/algorand/go-algorand/daemon/algod/api/server/common""
+ 	""github.com/algorand/go-algorand/daemon/algod/api/server/lib""",nit- would be cleaner to import it once
+202,"@@ -159,6 +159,14 @@ class GenericProxyHandler(BaseHTTPRequestHandler):
+             # allow pre-flight CORS headers by default
+             if 'Access-Control-Allow-Origin' not in response.headers:
+                 self.send_header('Access-Control-Allow-Origin', '*')
++            if 'Access-Control-Allow-Headers' not in response.headers:
++                self.send_header('Access-Control-Allow-Headers', ','.join([
++                    'authorization',
++                    'x-amz-content-sha256',
++                    'x-amz-date',
++                    'x-amz-security-token',
++                    'x-amz-user-agent'
++                ])
+
+             self.end_headers()
+             if len(response.content):",Looks like there is a closing parenthesis `)` missing here.
+203,"@@ -1684,8 +1684,8 @@ void PairTlsph::coeff(int narg, char **arg) {
+                 } // end energy release rate failure criterion
+
+                 else {
+-                        sprintf(str, ""unknown *KEYWORD: %s"", arg[ioffset]);
+-                        error->all(FLERR, str);
++                  snprintf(str,128,""unknown *KEYWORD: %s"", arg[ioffset]);
++                  error->all(FLERR, str);
+                 }
+
+         }",this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed.
+204,"@@ -706,6 +706,7 @@ func TestKBFSOpsGetBaseDirChildrenCacheSuccess(t *testing.T) {
+ 	ops := getOps(config, id)
+ 	n := nodeFromPath(t, ops, p)
+
++	config.mockMdserv.EXPECT().FastForwardBackoff().AnyTimes()
+ 	children, err := config.KBFSOps().GetDirChildren(ctx, n)
+ 	if err != nil {
+ 		t.Errorf(""Got error on getdir: %+v"", err)","You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test."
+205,"@@ -528,8 +528,10 @@ drx_insert_counter_update(void *drcontext, instrlist_t *ilist, instr_t *where,
+         }
+     }
+ #elif defined(AARCHXX)
++#    ifdef ARM_32
+     /* FIXME i#1551: implement 64-bit counter support */
+-    ASSERT(!is_64, ""DRX_COUNTER_64BIT is not implemented"");
++    ASSERT(!is_64, ""DRX_COUNTER_64BIT is not implemented for ARM_32"");
++#    endif /* ARM_32 */
+
+     if (use_drreg) {
+         if (drreg_reserve_register(drcontext, ilist, where, NULL, &reg1) !=","`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32."
+206,"@@ -38,8 +38,11 @@ import javax.annotation.Nullable;
+ /** A field declaration wrapper around a Discovery Schema. */
+ public class DiscoveryField implements FieldModel, TypeModel {
+   private final List<DiscoveryField> properties;
++  // Dereferenced schema for use rendering type names and determining properties, type, and format.
+   private final Schema schema;
+-  private final Schema originalSchema; // Not dereferenced schema.
++
++  // Not dereferenced schema; used in rendering this FieldModel's parameter name.
++  private final Schema originalSchema;
+   private final DiscoApiModel apiModel;
+
+   /* Create a FieldModel object from a non-null Schema object, and internally dereference the input schema. */",s/for use/to use for/
+207,"@@ -60,7 +60,7 @@ class UserCreatedEventProjector
+                 'language' => $event->getLanguage()->getCode(),
+                 'password' => $event->getPassword()->getValue(),
+                 'is_active' => $event->isActive(),
+-                'avatar_id' => $event->getAvatarId() ? $event->getAvatarId()->getValue() : null,
++                'avatar_filename' => $event->getAvatarFilename() ? $event->getAvatarFilename()->getValue() : null,
+             ],
+             [
+                 'is_active' => \PDO::PARAM_BOOL,",` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `
+208,"@@ -34,7 +34,7 @@ import (
+
+ var (
+ 	// ErrPersistenceLimitExceeded is the error indicating QPS limit reached.
+-	ErrPersistenceLimitExceeded = serviceerror.NewResourceExhausted(""Persistence Max QPS Reached."")
++	ErrPersistenceLimitExceeded = serviceerror.NewUnavailable(""Persistence Max QPS Reached."")
+ )
+
+ type (",why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?
+209,"@@ -27,13 +27,10 @@ namespace OpenTelemetry.Instrumentation.AspNet
+     public class AspNetInstrumentationOptions
+     {
+         /// <summary>
+-        /// Gets or sets <see cref=""TextMapPropagator""/> for context propagation. Default value: <see cref=""CompositeTextMapPropagator""/> with <see cref=""TraceContextPropagator""/> &amp; <see cref=""BaggagePropagator""/>.
++        /// Gets or sets <see cref=""TextMapPropagator""/> for context propagation.
++        /// By default, <see cref=""Propagators.DefaultTextMapPropagator"" /> will be used.
+         /// </summary>
+-        public TextMapPropagator Propagator { get; set; } = new CompositeTextMapPropagator(new TextMapPropagator[]
+-        {
+-            new TraceContextPropagator(),
+-            new BaggagePropagator(),
+-        });
++        public TextMapPropagator Propagator { get; set; } = Propagators.DefaultTextMapPropagator;
+
+         /// <summary>
+         /// Gets or sets a Filter function to filter instrumentation for requests on a per request basis.","Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable."
+210,"@@ -158,7 +158,6 @@ public class TransactionSimulator {
+         callParams.getFrom() != null ? callParams.getFrom() : DEFAULT_FROM;
+
+     BlockHeader blockHeaderToProcess = header;
+-
+     if (transactionValidationParams.isAllowExceedingBalance()) {
+       updater.getOrCreate(senderAddress).getMutable().setBalance(Wei.of(UInt256.MAX_VALUE));
+       if (header.getBaseFee().isPresent()) {",Unrelated file. Please remove from PR.
+211,"@@ -2663,6 +2663,7 @@ static work_queue_msg_code_t process_http_request( struct work_queue *q, struct
+ 	} else {
+ 	        // Other requests get raw JSON data.
+ 		send_worker_msg(q,w,""Content-type: text/plain\n\n"");
++		send_worker_msg(q,w,""Access-Control-Allow-Origin: *\n\n"");
+ 		process_queue_status(q, w, &path[1], stoptime );
+ 	}
+ ",Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.)
+212,"@@ -9,6 +9,9 @@ def request(flow):
+     flow.request.headers.pop('If-Modified-Since', None)
+     flow.request.headers.pop('Cache-Control', None)
+
++    # do not force https redirection
++    flow.request.headers.pop('Upgrade-Insecure-Requests', None)
++
+     # proxy connections to SSL-enabled hosts
+     if flow.request.pretty_host in secure_hosts:
+         flow.request.scheme = 'https'","This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b""pattern""`)?"
+213,"@@ -85,7 +85,7 @@ const ariaRoles = {
+ 	},
+ 	combobox: {
+ 		type: 'composite',
+-		requiredOwned: ['textbox', 'listbox', 'tree', 'grid', 'dialog'],
++		requiredOwned: ['listbox', 'tree', 'grid', 'dialog', 'textbox'],
+ 		requiredAttrs: ['aria-expanded'],
+ 		// Note: because aria-controls is not well supported we will not
+ 		// make it a required attribute even though it is required in the","This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for ""equal but order doesn't matter"" in chai."
+214,"@@ -16546,6 +16546,18 @@ RelInternalSP::costMethod() const
+ } // RelInternalSP::costMethod()
+ //<pb>
+
++CostMethod *
++HbaseDelete::costMethod() const
++{
++  if (CmpCommon::getDefault(HBASE_DELETE_COSTING) == DF_OFF)
++    return RelExpr::costMethod();  // returns cost 1 cost object
++
++  static THREAD_P CostMethodHbaseDelete *m = NULL;
++  if (m == NULL)
++    m = new (GetCliGlobals()->exCollHeap()) CostMethodHbaseDelete();
++  return m;
++} // HbaseDelete::costMethod()
++
+ PhysicalProperty*
+ HbaseDelete::synthPhysicalProperty(const Context* myContext,
+                                    const Lng32     planNumber,","maybe say ""returns the default cost method that returns an object of cost 1""."
+215,"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+
++	rules = append(rules, Rule{
++		Match: Match().ProtocolNum(ProtoUDP).
++			DestPorts(uint16(r.Config.VXLANPort)).
++			VXLANVNI(uint32(r.Config.VXLANVNI)),
++		Action:  DropAction{},
++		Comment: ""Drop VXLAN encapped packets originating in pods"",
++	})
++	rules = append(rules, Rule{
++		Match:   Match().ProtocolNum(ProtoIPIP),
++		Action:  DropAction{},
++		Comment: ""Drop IPinIP encapped packets originating in pods"",
++	})
++
+ 	if len(policyNames) > 0 {
+ 		// Clear the ""pass"" mark.  If a policy sets that mark, we'll skip the rest of the policies and
+ 		// continue processing the profiles, if there are any.","I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?"
+216,"@@ -125,7 +125,9 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
+                     try {
+                         // Not a 2xx status
+                         if (!response.isSuccess()) {
+-                            callbackContext.error(response.asString());
++                            JSONObject errorObj = new JSONObject();
++                            errorObj.putOpt(""response"", response.fullResponseAsJSONObject());
++                            callbackContext.error(errorObj.toString());
+                         }
+                         // Binary response
+                         else if (returnBinary) {","Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine."
+217,"@@ -113,7 +113,7 @@ describe('PasswordEditor', () => {
+     const editorHolder = $('.handsontableInputHolder');
+     const editor = editorHolder.find('.handsontableInput');
+
+-    expect(parseInt(editorHolder.css('z-index'), 10)).toBeGreaterThan(0);
++    expect(editorHolder.is(':visible')).toBe(true);
+
+     editor.val('Edgar');
+ ",Are you sure? We've changed it during an introduction of the IME support.
+218,"@@ -46,7 +46,7 @@ class QueryBuilder
+             $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
+         }
+
+-        if (!empty($dqlFilter)) {
++        if (null !== $dqlFilter) {
+             $queryBuilder->andWhere($dqlFilter);
+         }
+ ","I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?"
+219,"@@ -170,14 +170,12 @@ func (p *Agent) Start(ctx context.Context) error {
+ 			p2pMsgLatency.WithLabelValues(""broadcast"", strconv.Itoa(int(broadcast.MsgType)), status).Observe(float64(latency))
+ 		}()
+ 		if err = proto.Unmarshal(data, &broadcast); err != nil {
+-			err = errors.Wrap(err, ""error when marshaling broadcast message"")
+-			return
++			return errors.Wrap(err, ""error when marshaling broadcast message"")
+ 		}
+ 		// Skip the broadcast message if it's from the node itself
+ 		rawmsg, ok := p2p.GetBroadcastMsg(ctx)
+ 		if !ok {
+-			err = errors.New(""error when asserting broadcast msg context"")
+-			return
++			return errors.New(""error when asserting broadcast msg context"")
+ 		}
+ 		peerID = rawmsg.GetFrom().Pretty()
+ 		if p.host.HostIdentity() == peerID {","this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem"
+220,"@@ -202,7 +202,7 @@ ostree_gpg_verify_result_get_all (OstreeGpgVerifyResult *result,
+  * ostree_gpg_verify_result_describe:
+  * @result: an #OstreeGpgVerifyResult
+  * @signature_index: which signature to describe
+- * @output_buffer: a #GString to hold the description
++ * @output_buffer: (out): a #GString to hold the description
+  * @line_prefix: (allow-none): optional line prefix string
+  * @flags: flags to adjust the description format
+  *","I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for."
+221,"@@ -7,9 +7,9 @@ from ..registry import LOSSES
+
+ def _expand_binary_labels(labels, label_weights, label_channels):
+     bin_labels = labels.new_full((labels.size(0), label_channels), 0)
+-    inds = torch.nonzero(labels >= 1).squeeze()
++    inds = torch.nonzero((labels >= 0) & (labels < label_channels)).squeeze()
+     if inds.numel() > 0:
+-        bin_labels[inds, labels[inds] - 1] = 1
++        bin_labels[inds, labels[inds]] = 1
+     bin_label_weights = label_weights.view(-1, 1).expand(
+         label_weights.size(0), label_channels)
+     return bin_labels, bin_label_weights","If the label is not binary, should we rename this function?"
+222,"@@ -421,10 +421,12 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister):
+         :param file_list:
+         :return: etree
+         """"""
++        cur_path = r""${__BeanShell(import org.apache.jmeter.services.FileServer; FileServer.getFileServer()"" \
++                   r"".getBaseDir();)}${__BeanShell(File.separator,)}""
+         for file_path in file_list:
+             file_path_elements = jmx.xpath('//stringProp[text()=""%s""]' % file_path)
+             for file_path_element in file_path_elements:
+-                file_path_element.text = os.path.basename(file_path)
++                file_path_element.text = cur_path + os.path.basename(file_path)
+
+     def __get_resource_files_from_jmx(self, jmx):
+         """"""",This is very-very bad idea because of its performance impact
+223,"@@ -6,6 +6,7 @@ import (
+ 	""database/sql""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/sonm-io/core/proto""
+ 	""math/big""
+ 	""net""
+ 	""sync""",WHY U NOT SORT IMPORTS?
+224,"@@ -0,0 +1,11 @@
++module SignInRequestHelpers
++  def sign_in_as(user)
++    post(
++      ""/session"",
++      session: {
++        email: user.email,
++        password: user.password,
++      },
++    )
++  end
++end",Put a comma after the last item of a multiline hash.
+225,"@@ -12,7 +12,7 @@ __version__ = param.Version(release=(1,7,0), fpath=__file__,
+                             commit=""$Format:%h$"", reponame='holoviews')
+
+ from .core import archive                                # noqa (API import)
+-from .core.dimension import OrderedDict, Dimension       # noqa (API import)
++from .core.dimension import OrderedDict, Dimension, Dimensioned       # noqa (API import)
+ from .core.boundingregion import BoundingBox             # noqa (API import)
+ from .core.options import (Options, Store, Cycle,        # noqa (API import)
+                            Palette, StoreOptions)",How come we need ``Dimensioned`` in the top-level namespace?
+226,"@@ -75,9 +75,9 @@ import net.runelite.client.util.Text;
+ import net.runelite.client.util.WildcardMatcher;
+
+ @PluginDescriptor(
+-	name = ""NPC Indicators"",
+-	description = ""Highlight NPCs on-screen and/or on the minimap"",
+-	tags = {""highlight"", ""minimap"", ""npcs"", ""overlay"", ""respawn"", ""tags""}
++		name = ""NPC Indicators"",
++		description = ""Highlight NPCs on-screen and/or on the minimap"",
++		tags = {""highlight"", ""minimap"", ""npcs"", ""overlay"", ""respawn"", ""tags""}
+ )
+ @Slf4j
+ @Singleton",excess whitespace through plugin.
+227,"@@ -138,7 +138,7 @@ void EdgeBasedGraphFactory::InsertEdgeBasedNode(const NodeID node_u, const NodeI
+     NodeID current_edge_source_coordinate_id = node_u;
+
+     // traverse arrays from start and end respectively
+-    for (const auto i : util::irange(0UL, geometry_size))
++    for (const auto i : util::irange(std::size_t{ 0 }, geometry_size))
+     {
+         BOOST_ASSERT(current_edge_source_coordinate_id ==
+                      m_compressed_edge_container.GetBucketReference(",What is the problem here? I feel we used this in a lot of places.
+228,"@@ -109,8 +109,7 @@ class RPN(BaseDetector):
+             for proposals, meta in zip(proposal_list, img_metas):
+                 proposals[:, :4] /= proposals.new_tensor(meta['scale_factor'])
+
+-        # TODO: remove this restriction
+-        return proposal_list[0].cpu().numpy()
++        return [proposal.cpu().numpy() for proposal in proposal_list]
+
+     def aug_test(self, imgs, img_metas, rescale=False):
+         """"""Test function with test time augmentation.",Update the docstring.
+229,"@@ -7,10 +7,11 @@
+ package api
+
+ import (
+-	""errors""
+ 	""testing""
+ 	""time""
+
++	""github.com/pkg/errors""
++
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/stretchr/testify/require""
+ ","delete the empty line ""github.com/pkg/errors"" should be grouped with other third party packages same for the rest"
+230,"@@ -155,7 +155,7 @@ public class RemoteWebDriver implements WebDriver, JavascriptExecutor,
+   }
+
+   private void init(Capabilities capabilities) {
+-    capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;
++    this.capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;
+
+     logger.addHandler(LoggingHandler.getInstance());
+ ",Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field).
+231,"@@ -110,8 +110,6 @@ module RSpec::Core
+       end
+     end
+
+-    alias_method :abort, :finish
+-
+     def stop
+       @duration = (RSpec::Core::Time.now - @start).to_f if @start
+       notify :stop","Is this a breaking change, or is the API private?"
+232,"@@ -0,0 +1,4 @@
++import pandas as pd
++
++test_data = pd.read_json(""./dumps/courseData.json"");
++test_data = {k: val.groupby('pk')['fields'].apply(list).apply(lambda x: x[0]).to_dict() for k, val in test_data.groupby(""model"")};",I don't think we need this dependency in this project right now
+233,"@@ -30,8 +30,9 @@ const (
+ 	// FanoutName is the name used for the fanout container.
+ 	FanoutName = ""fanout""
+ 	// RetryName is the name used for the retry container.
+-	RetryName          = ""retry""
+-	BrokerCellLabelKey = ""brokerCell""
++	RetryName             = ""retry""
++	BrokerCellLabelKey    = ""brokerCell""
++	BrokerSystemNamespace = ""cloud-run-events""
+ )
+
+ var (",I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant.
+234,"@@ -155,14 +155,15 @@ module Bolt
+                          ""`task.py`) and the extension is case sensitive. When a target's name is `localhost`, ""\
+                          ""Ruby tasks run with the Bolt Ruby interpreter by default."",
+             additionalProperties: {
+-              type: String,
++              type: [String, Array],
+               _plugin: false
+             },
+             propertyNames: {
+               pattern: ""^.?[a-zA-Z0-9]+$""
+             },
+             _plugin: true,
+-            _example: { ""rb"" => ""/usr/bin/ruby"" }
++            _example: { ""rb"" => [""/usr/bin/ruby"", ""-r"", ""puppet""],
++                        "".py"" => ""/usr/bin/python3"" }
+           },
+           ""job-poll-interval"" => {
+             type: Integer,",The `_example` field should be updated to include an interpreter with an array value.
+235,"@@ -532,12 +532,14 @@ var supportedKeyTypes = map[string]acme.KeyType{
+
+ // Map of supported protocols.
+ // HTTP/2 only supports TLS 1.2 and higher.
+-var supportedProtocols = map[string]uint16{
++var SupportedProtocols = map[string]uint16{
+ 	""tls1.0"": tls.VersionTLS10,
+ 	""tls1.1"": tls.VersionTLS11,
+ 	""tls1.2"": tls.VersionTLS12,
+ }
+
++// NOTE: if updating the above map, also update sslProtocolToStringMap in caddyhttp/fastcgi/fastcgi.go
++
+ // Map of supported ciphers, used only for parsing config.
+ //
+ // Note that, at time of writing, HTTP/2 blacklists 276 cipher suites,",Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?
+236,"@@ -59,13 +59,12 @@ func (container *CronContainer) StopStatsCron() {
+ }
+
+ // newCronContainer creates a CronContainer object.
+-func newCronContainer(dockerID *string, name *string, dockerGraphPath string) *CronContainer {
++func newCronContainer(dockerID *string, dockerGraphPath string) *CronContainer {
+ 	statePath := filepath.Join(dockerGraphPath, DockerExecDriverPath, *dockerID)
+
+ 	container := &CronContainer{
+ 		containerMetadata: &ContainerMetadata{
+ 			DockerID: dockerID,
+-			Name:     name,
+ 		},
+ 		statePath: statePath,
+ 	}","I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer."
+237,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+238,"@@ -19,7 +19,10 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
++import org.openqa.selenium.SessionNotCreatedException;
+ import org.openqa.selenium.grid.distributor.Distributor;
++import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.internal.Require;
+
+ import java.net.URI;",You can safely revert changes to this file.
+239,"@@ -127,7 +127,6 @@ class AnchorHead(nn.Module):
+
+     def loss_single(self, cls_score, bbox_pred, labels, label_weights,
+                     bbox_targets, bbox_weights, num_total_samples, cfg):
+-        # classification loss
+         labels = labels.reshape(-1)
+         label_weights = label_weights.reshape(-1)
+         cls_score = cls_score.permute(0, 2, 3, 1).reshape(",This deletion is unnecessary.
+240,"@@ -302,7 +302,10 @@ class Notification extends Component {
+ 								mdc-layout-grid__cell
+ 								mdc-layout-grid__cell--span-1
+ 							"">
+-								<img className=""googlesitekit-publisher-win__small-image"" alt="""" src={ smallImage } />
++								{
++									typeof smallImage === 'string'
++										? <img className=""googlesitekit-publisher-win__small-image"" alt="""" src={ smallImage } /> : smallImage
++								}
+ 							</div>
+ 						}
+ ","I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear."
+241,"@@ -21,10 +21,7 @@ import java.io.InputStream;
+ import java.io.StringWriter;
+ import java.lang.invoke.MethodHandles;
+ import java.nio.charset.StandardCharsets;
+-import java.util.Collections;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
+ import java.util.concurrent.TimeUnit;
+
+ import org.apache.solr.cloud.ZkController;","I've had this happen recently with IntelliJ, was this intentional?"
+242,"@@ -22,9 +22,10 @@
+ #include <string.h>
+ #include <string>
+ #include <vector>
+-#include <map>
++#include <unordered_map>
+ #include ""vulkan/vulkan.h""
+ #include ""vk_format_utils.h""
++#include ""hash_util.h""
+
+ struct VULKAN_FORMAT_INFO {
+     size_t size;",Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements.
+243,"@@ -33,6 +33,7 @@ import (
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/ip""
+ 	""github.com/mysteriumnetwork/node/core/location""
++	location_factory ""github.com/mysteriumnetwork/node/core/location/factory""
+ 	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/mysteriumnetwork/node/core/port""
+ 	""github.com/mysteriumnetwork/node/core/service""",I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?
+244,"@@ -47,6 +47,14 @@ void Engine::SetCallBack(std::function<void(const void *, std::string,
+ {
+ }
+
++static void engineThrowUp(const std::string &engineType,
++                          const std::string &func)
++{
++    throw std::invalid_argument(
++        ""ERROR: Engine bass class "" + func + ""() called. "" + engineType +
++        "" child class is not implementing this function\n"");
++}
++
+ // should these functions throw an exception?
+ void Engine::Write(Variable<char> & /*variable*/, const char * /*values*/) {}
+ void Engine::Write(Variable<unsigned char> & /*variable*/,",Use `UpperCamelCase` for function names
+245,"@@ -232,9 +232,12 @@ SchemaDate.prototype.cast = function(value) {
+
+   if (value instanceof Number || typeof value === 'number') {
+     date = new Date(value);
++  } else if (typeof value === 'string' && !isNaN(Number(value)) && (Number(value) >= 275761 || Number(value) < 0)) {
++    // string representation of milliseconds take this path
++    date = new Date(Number(value));
+   } else if (typeof value.valueOf === 'function') {
+-    // support for moment.js. This is also the path strings will take because strings
+-    // have a `valueOf()`
++    // support for moment.js. This is also the path string representation of years
++    // will take because strings have a `valueOf()`
+     date = new Date(value.valueOf());
+   } else {
+     // fallback","I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior."
+246,"@@ -138,8 +138,7 @@ public abstract class BaseHttpClusterStateProvider implements ClusterStateProvid
+     Set<String> liveNodes = new HashSet((List<String>)(cluster.get(""live_nodes"")));
+     this.liveNodes = liveNodes;
+     liveNodesTimestamp = System.nanoTime();
+-    //TODO SOLR-11877 we don't know the znode path; CLUSTER_STATE is probably wrong leading to bad stateFormat
+-    ClusterState cs = ClusterState.load(znodeVersion, collectionsMap, liveNodes, ZkStateReader.CLUSTER_STATE);
++    ClusterState cs = ClusterState.createFromData(znodeVersion, collectionsMap, liveNodes);
+     if (clusterProperties != null) {
+       Map<String, Object> properties = (Map<String, Object>) cluster.get(""properties"");
+       if (properties != null) {",Remember to close SOLR-11877 after this
+247,"@@ -1124,7 +1124,7 @@ void Identifier::_exportToJSON(JSONFormatter *formatter) const {
+ //! @cond Doxygen_Suppress
+ static bool isIgnoredChar(char ch) {
+     return ch == ' ' || ch == '_' || ch == '-' || ch == '/' || ch == '(' ||
+-           ch == ')' || ch == '.' || ch == '&' || ch == ',';
++           ch == ')' || ch == '.' || ch == '&';
+ }
+ //! @endcond
+ ",this change should be reverted
+248,"@@ -186,9 +186,15 @@ type mockedIdentityRegistry struct {
+ 	anyIdentityRegistered bool
+ }
+
++// IsRegistered mock
+ func (mir *mockedIdentityRegistry) IsRegistered(address common.Address) (bool, error) {
+ 	return mir.anyIdentityRegistered, nil
+ }
+
++// WaitForRegistrationEvent mock
++func (mir *mockedIdentityRegistry) WaitForRegistrationEvent(providerAddress common.Address, registeredEvent chan int, stopLoop chan int) {
++
++}
++
+ //check that we implemented mocked registry correctly
+ var _ registry.IdentityRegistry = &mockedIdentityRegistry{}","This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented"
+249,"@@ -45,7 +45,7 @@ const options = {
+         query: ['src/**/*.png', 'src/**/*.jpg', 'src/**/*.gif', 'src/**/*.svg']
+     },
+     copy: {
+-        query: ['src/**/*.json', 'src/**/*.ico']
++        query: ['src/**/*.json', 'src/**/*.ico', 'src/**/*.wav']
+     },
+     injectBundle: {
+         query: 'src/index.html'","`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`..."
+250,"@@ -1602,6 +1602,17 @@ luaA_client_swap(lua_State *L)
+         *ref_swap = c;
+
+         luaA_class_emit_signal(L, &client_class, ""list"", 0);
++
++        luaA_object_push(L, swap);
++        lua_pushboolean(L, true);
++        luaA_object_emit_signal(L, -4, ""swapped"", 2);
++        lua_pop(L, 2);
++
++        luaA_object_push(L, swap);
++        luaA_object_push(L, c);
++        lua_pushboolean(L, false);
++        luaA_object_emit_signal(L, -3, ""swapped"", 2);
++        lua_pop(L, 3);
+     }
+
+     return 0;",Wouldn't a single signal call be enough? (without the boolean even)
+251,"@@ -17,6 +17,11 @@
+       <br/>
+       <%= note_event(@note.status, @note.closed_at, @note_comments.last.author) %>
+     <% end %>
++    <% if current_user && current_user != @note.author %>
++      <%= link_to new_report_url(reportable_id: @note.id, reportable_type: @note.class.name), :title => t('browse.note.report') do %>
++          &nbsp;&#9872;
++      <% end %>
++    <% end %>
+   </div>
+
+   <% if @note_comments.find { |comment| comment.author.nil? } -%>","I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?"
+252,"@@ -218,6 +218,9 @@ class Document < AbstractBlock
+   # Public: Get the Reader associated with this document
+   attr_reader :reader
+
++  # Public: Get/Set the PathResolver instance used to resolve paths in this Document.
++  attr_reader :path_resolver
++
+   # Public: Get the Converter associated with this document
+   attr_reader :converter
+ ",Should we expose this attribute in the Asciidoctor.js API ?
+253,"@@ -147,7 +147,7 @@ public interface Multimap<K, V> extends Traversable<Tuple2<K, V>>, Function1<K,
+
+     @Override
+     default boolean contains(Tuple2<K, V> element) {
+-        return get(element._1).map(v -> Objects.equals(v, element._2)).getOrElse(false);
++        return get(element._1).map(v -> v.contains(element._2)).getOrElse(false);
+     }
+
+     /**",I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right
+254,"@@ -57,6 +57,7 @@ public class TiConfiguration implements Serializable {
+   private static final int DEF_KV_CLIENT_CONCURRENCY = 10;
+   private static final List<TiStoreType> DEF_ISOLATION_READ_ENGINES =
+       ImmutableList.of(TiStoreType.TiKV, TiStoreType.TiFlash);
++  private static final int DEF_PREWRITE_CONCURRENCY = 20;
+
+   private int timeout = DEF_TIMEOUT;
+   private TimeUnit timeoutUnit = DEF_TIMEOUT_UNIT;",delete this line
+255,"@@ -43,6 +43,7 @@ module Test
+
+   def self.setup_models
+     conn = ClientRequest.connection
++    return if conn.table_exists? ""test_client_requests""
+     conn.create_table(:test_client_requests, force: true) do |t|
+       t.decimal  :amount
+       t.string   :project_title",Presumably we no longer need `force: true` here.
+256,"@@ -339,6 +339,12 @@ hipError_t hipHostAlloc(void** ptr, size_t sizeBytes, unsigned int flags) {
+ // width in bytes
+ hipError_t ihipMallocPitch(void** ptr, size_t* pitch, size_t width, size_t height, size_t depth) {
+     hipError_t hip_status = hipSuccess;
++	if(ptr==NULL || ptr==0)
++	{
++	hip_status=hipErrorInvalidValue;
++	return hip_status;
++	}
++
+     // hardcoded 128 bytes
+     *pitch = ((((int)width - 1) / 128) + 1) * 128;
+     const size_t sizeBytes = (*pitch) * height;",HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient.
+257,"@@ -0,0 +1,10 @@
++<%= t(""mailer.welcome_mailer.welcome_notification.header"") %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para1"") %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para2"", help_url: help_url('') ) %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para3"", feedback_url: feedback_url ) %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.signature"") %>
++",these urls are still in `a` tags so we should probably include these links separately for a non-HTML version
+258,"@@ -507,8 +507,18 @@ func (s *Server) configureAccounts() error {
+ 	if opts.SystemAccount != _EMPTY_ {
+ 		// Lock may be acquired in lookupAccount, so release to call lookupAccount.
+ 		s.mu.Unlock()
+-		_, err := s.lookupAccount(opts.SystemAccount)
++		acc, err := s.lookupAccount(opts.SystemAccount)
+ 		s.mu.Lock()
++		if err == nil && s.sys != nil && acc != s.sys.account {
++			// sys.account.clients (including internal client)/respmap/etc... are transferred separately
++			s.sys.account = acc
++			s.mu.Unlock()
++			// acquires server lock separately
++			s.addSystemAccountExports(acc)
++			// can't hold the lock as go routine reading it may be waiting for lock as well
++			s.sys.resetCh <- struct{}{}
++			s.mu.Lock()
++		}
+ 		if err != nil {
+ 			return fmt.Errorf(""error resolving system account: %v"", err)
+ 		}","That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval."
+259,"@@ -47,6 +47,7 @@ public interface CapabilityType {
+   String ELEMENT_SCROLL_BEHAVIOR = ""elementScrollBehavior"";
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
++  String ENABLE_DOWNLOADING = ""chromium:enableDownloading"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ",The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?
+260,"@@ -28,10 +28,9 @@ public interface ValidatorManager {
+   Map<String, ValidationReport> validate(Project project, File projectDir);
+
+   /**
+-   * The ValidatorManager should have a default validator which checks for the most essential
+-   * components of a project. The ValidatorManager should always load the default validator. This
+-   * method returns the default validator of this ValidatorManager.
++   * ValidatorManager will not have any default validator.
+    */
++  @Deprecated
+   ProjectValidator getDefaultValidator();
+
+   /**",Found one internal team is using this method. Will coordinate with them about the migration solution.
+261,"@@ -230,6 +230,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+
++        /// <summary>
++        /// Configuration key for the application's server http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpServerErrorCodes""/>
++        public const string HttpServerErrorCodes = ""DD_HTTP_SERVER_ERROR_STATUSES"";
++
++        /// <summary>
++        /// Configuration key for the application's client http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpClientErrorCodes""/>
++        public const string HttpClientErrorCodes = ""DD_HTTP_CLIENT_ERROR_STATUSES"";
++
+         /// <summary>
+         /// String format patterns used to match integration-specific configuration keys.
+         /// </summary>",The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`
+262,"@@ -35,6 +35,12 @@ MAXIMUM_LOOP_COUNT = 600
+ DEFAULT_BUCKET_FMT_V1 = 'gs://{}-data-{}'
+ DEFAULT_BUCKET_FMT_V2 = 'gs://{}-{}-data-{}'
+
++FORSETI_V1_RULE_FILES = [
++    'bigquery_rules.yaml', 'blacklist_rules.yaml', 'bucket_rules.yaml',
++    'cloudsql_rules.yaml', 'firewall_rules.yaml', 'forwarding_rules.yaml',
++    'group_rules.yaml', 'iam_rules.yaml', 'iap_rules.yaml', 'ke_rules.yaml',
++    'instance_network_interface_rules.yaml']
++
+ GCLOUD_MIN_VERSION = (180, 0, 0)
+ GCLOUD_VERSION_REGEX = r'Google Cloud SDK (.*)'
+ GCLOUD_ALPHA_REGEX = r'alpha.*'","Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove."
+263,"@@ -170,10 +170,14 @@ public class ConfigSetsHandler extends RequestHandlerBase implements PermissionN
+
+     boolean overwritesExisting = zkClient.exists(configPathInZk, true);
+
+-    if (overwritesExisting && !req.getParams().getBool(ConfigSetParams.OVERWRITE, false)) {
+-      throw new SolrException(ErrorCode.BAD_REQUEST,
+-          ""The configuration "" + configSetName + "" already exists in zookeeper"");
+-    }
++    // Get upload parameters
++    String singleFilePath = req.getParams().get(ConfigSetParams.FILE_PATH, """");
++    boolean allowOverwrite = req.getParams().getBool(ConfigSetParams.OVERWRITE, false);
++    // Cleanup is not allowed while using singleFilePath upload
++    boolean cleanup = singleFilePath.isEmpty() && req.getParams().getBool(ConfigSetParams.CLEANUP, false);
++
++    // Create a node for the configuration in zookeeper
++    createBaseZnode(zkClient, overwritesExisting, isTrusted(req, coreContainer.getAuthenticationPlugin()), cleanup, configPathInZk);
+
+     Iterator<ContentStream> contentStreamsIterator = req.getContentStreams().iterator();
+ ","should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`"
+264,"@@ -191,7 +191,7 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
+ 	if len(archive.File) == 0 {
+ 		return nil, errors.New(""archive is empty"")
+ 	} else if fi := archive.File[0].FileInfo(); !fi.IsDir() {
+-		return nil, errors.New(""archive root is not a directory"")
++		return nil, fmt.Errorf(""archive root directory missing: expected a 'root' directory but got %v"", archive.File[0].Name)
+ 	}
+ 	root := archive.File[0].Name
+ 	pref, err := unitPrefix(root, archive.File)","There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip."
+265,"@@ -1,6 +1,9 @@
+ <% unless ENV['DISABLE_SANDBOX_WARNING'] == 'true' %>
+   <%= render partial: 'shared/sandbox_warning' %>
+ <% end %>
++<% if !current_page?(me_path) && current_user && current_user.requires_profile_attention? %>
++  <%= render partial: ""shared/user_profile_warning"" %>
++<% end %>
+ <header>
+   <div class='container'>
+     <div id='header-identity'>",perhaps we should encapsulate this logic in a helper method w a test?
+266,"@@ -0,0 +1,7 @@
++[ 'options_hash', 'defaults', 'command_line_parser', 'pe_version_scraper', 'parser' ].each do |file|
++  begin
++    require ""beaker/options/#{file}""
++  rescue LoadError
++    require File.expand_path(File.join(File.dirname(__FILE__), 'options', file))
++  end
++end",Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below.
+267,"@@ -53,7 +53,8 @@ enum Timestamps implements Transform<Long, Integer> {
+     OffsetDateTime timestamp = Instant
+         .ofEpochSecond(timestampMicros / 1_000_000)
+         .atOffset(ZoneOffset.UTC);
+-    return (int) granularity.between(EPOCH, timestamp);
++    Integer year = Long.valueOf(granularity.between(EPOCH, timestamp)).intValue();
++    return year;
+   }
+
+   @Override","This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?"
+268,"@@ -351,8 +351,6 @@ func (mtask *managedTask) waitEvent(stopWaiting <-chan struct{}) bool {
+ 		mtask.handleDesiredStatusChange(acsTransition.desiredStatus, acsTransition.seqnum)
+ 		return false
+ 	case dockerChange := <-mtask.dockerMessages:
+-		seelog.Infof(""Managed task [%s]: got container [%s (Runtime ID: %s)] event: [%s]"",
+-			mtask.Arn, dockerChange.container.Name, dockerChange.container.GetRuntimeID(), dockerChange.event.Status.String())
+ 		mtask.handleContainerChange(dockerChange)
+ 		return false
+ 	case resChange := <-mtask.resourceStateChangeEvent:",this is redundant because it gets logged immediately on entering the handleContainerChange function
+269,"@@ -126,7 +126,7 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ 	var approvers []string
+
+ 	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+-		if v.Event == ""DEPLOYMENT_WAIT_APPROVAL"" {
++		if e := ""EVENT_"" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {
+ 			approvers = v.Slack
+ 		}
+ 	}",`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable.
+270,"@@ -42,4 +42,8 @@ public class CliqueMiningTracker {
+   public boolean blockCreatedLocally(final BlockHeader header) {
+     return CliqueHelpers.getProposerOfBlock(header).equals(localAddress);
+   }
++
++  public ProtocolContext getProtocolContext() {
++    return protocolContext;
++  }
+ }",this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine.
+271,"@@ -265,13 +265,11 @@ public class FirefoxDriver extends RemoteWebDriver
+
+   @Override
+   public String installExtension(Path path) {
+-    Require.nonNull(""Path"", path);
+     return extensions.installExtension(path);
+   }
+
+   @Override
+   public void uninstallExtension(String extensionId) {
+-    Require.nonNull(""Extension ID"", extensionId);
+     extensions.uninstallExtension(extensionId);
+   }
+ ","It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user."
+272,"@@ -60,8 +60,9 @@ RSpec.configure do |config|
+   # Add modules for helpers
+   config.include ControllerSpecHelper, type: :controller
+   config.include RequestSpecHelper, type: :request
+-  [:feature, :request].each do |type|
++  [:feature, :request, :model].each do |type|
+     config.include IntegrationSpecHelper, type: type
++    config.include EnvironmentSpecHelper, type: type
+   end
+   config.include FeatureSpecHelper, type: :feature
+ ","We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?"
+273,"@@ -25,6 +25,9 @@ func TestWriteDrupalConfig(t *testing.T) {
+ 	err = WriteDrupalConfig(drupalConfig, file.Name())
+ 	assert.NoError(t, err)
+
++	os.Chmod(dir, 0755)
++	os.Chmod(file.Name(), 0666)
++
+ 	err = os.RemoveAll(dir)
+ 	assert.NoError(t, err)
+ }",Please check the return on these.
+274,"@@ -279,10 +279,14 @@ class Storage {
+       if (uplink == null) {
+         uplink = new Proxy({
+           url: file.url,
++          cache: true,
+           _autogenerated: true,
+         }, self.config);
+       }
+-      let savestream = self.local.add_tarball(name, filename);
++      let savestream = null;
++      if (uplink.config.cache) {
++        savestream = self.local.add_tarball(name, filename);
++      }
+       let on_open = function() {
+         // prevent it from being called twice
+         on_open = function() {};",Do we need `==` for true?
+275,"@@ -17,7 +17,7 @@ class BaseEMAHook(Hook):
+         momentum (float): The momentum used for updating ema parameter.
+             Ema's parameter are updated with the formula:
+            `ema_param = (1-momentum) * ema_param + momentum * cur_param`.
+-            Defaults to 0.0002.
++            Defaults to 0.0001.
+         skip_buffers (bool): Whether to skip the model buffers, such as
+             batchnorm running stats (running_mean, running_var), it does not
+             perform the ema operation. Default to False.",Changing the default value may cause BC-breaking. Suggest changing this value in config.
+276,"@@ -325,7 +325,7 @@ class SimpleConfig(Logger):
+         slider_pos = max(slider_pos, 0)
+         slider_pos = min(slider_pos, len(FEE_ETA_TARGETS))
+         if slider_pos < len(FEE_ETA_TARGETS):
+-            num_blocks = FEE_ETA_TARGETS[slider_pos]
++            num_blocks = FEE_ETA_TARGETS[int(slider_pos)]
+             fee = self.eta_target_to_fee(num_blocks)
+         else:
+             fee = self.eta_target_to_fee(1)",how does that happen?
+277,"@@ -31,9 +31,9 @@
+ #
+ from __future__ import print_function
+
+-import unittest
++import unittest, doctest
+ import os,sys
+-
++from rdkit.six import exec_
+ from rdkit.six.moves import cPickle
+
+ from rdkit import rdBase",This is gross/clever. :-)
+278,"@@ -1,6 +1,6 @@
+ require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb')
+
+-class TestZhCnLocale < Test::Unit::TestCase
++class TestZhLocale < Test::Unit::TestCase
+   def setup
+     Faker::Config.locale = 'zh-CN'
+   end",Take a look at the name of this file. Definitely copy and
+279,"@@ -163,12 +163,15 @@ func NewVolumeInfo(URL string, volname string, namespace string) (volInfo *Volum
+ 		if resp.StatusCode == 500 {
+ 			fmt.Printf(""Volume: %s not found at namespace: %q\n"", volname, namespace)
+ 			err = util.InternalServerError
++			return
+ 		} else if resp.StatusCode == 503 {
+ 			fmt.Printf(""maya apiservice not reachable at %q\n"", mapiserver.GetURL())
+ 			err = util.ServerUnavailable
++			return
+ 		} else if resp.StatusCode == 404 {
+ 			fmt.Printf(""Volume: %s not found at namespace: %q error: %s\n"", volname, namespace, http.StatusText(resp.StatusCode))
+ 			err = util.PageNotFound
++			return
+ 		}
+ 		fmt.Printf(""Received an error from maya apiservice: statuscode: %d"", resp.StatusCode)
+ 		err = fmt.Errorf(""Received an error from maya apiservice: statuscode: %d"", resp.StatusCode)",Can you check with @mahebbar how to work this error. Should be different from 404.
+280,"@@ -46,7 +46,7 @@ setup(
+         'spark': ['pyspark>=2.4.0'],
+         'mlflow': ['mlflow>=1.0'],
+     },
+-    python_requires='>=3.5,<3.8',
++    python_requires='>=3.5',
+     install_requires=[
+         'pandas>=0.23.2',
+         'pyarrow>=0.10',",Do we still need the upper bound `<3.9`?
+281,"@@ -229,7 +229,10 @@ function getPathsToCheck($f_paths): ?array
+             /** @var string */
+             $input_path = $input_paths[$i];
+
+-            if (realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm')
++            if (
++                realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')
++                || realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalter')
++                || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm')
+                 || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalter')
+                 || realpath($input_path) === realpath(Phar::running(false))
+             ) {",Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?
+282,"@@ -1,4 +1,4 @@
+-package aws_test
++package aws
+
+ import (
+ 	""fmt""","@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user."
+283,"@@ -54,8 +54,6 @@ func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter
+ 	instruments := map[string]data{
+ 		""test-int64-counter"":         {sdkapi.CounterInstrumentKind, number.Int64Kind, 1},
+ 		""test-float64-counter"":       {sdkapi.CounterInstrumentKind, number.Float64Kind, 1},
+-		""test-int64-histogram"":       {sdkapi.HistogramInstrumentKind, number.Int64Kind, 2},
+-		""test-float64-histogram"":     {sdkapi.HistogramInstrumentKind, number.Float64Kind, 2},
+ 		""test-int64-gaugeobserver"":   {sdkapi.GaugeObserverInstrumentKind, number.Int64Kind, 3},
+ 		""test-float64-gaugeobserver"": {sdkapi.GaugeObserverInstrumentKind, number.Float64Kind, 3},
+ 	}","The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?"
+284,"@@ -274,6 +274,13 @@ func (eval *BlockEvaluator) Round() basics.Round {
+ 	return eval.block.Round()
+ }
+
++// ResetTxnBytes resets the number of bytes tracked by the BlockEvaluator to
++// zero.  This is a specialized operation used by the transaction pool to
++// simulate the effect of putting pending transactions in multiple blocks.
++func (eval *BlockEvaluator) ResetTxnBytes(validateTxnBytes bool) {
++	eval.totalTxBytes = 0
++}
++
+ // Transaction tentatively adds a new transaction as part of this block evaluation.
+ // If the transaction cannot be added to the block without violating some constraints,
+ // an error is returned and the block evaluator state is unchanged.",should this increment eval.Round somehow?
+285,"@@ -91,7 +91,7 @@ class Blacklight::Solr::Response < ActiveSupport::HashWithIndifferentAccess
+         value.each { |v| force_to_utf8(v) }
+       when String
+         if value.encoding != Encoding::UTF_8
+-          Rails.logger.warn ""Found a non utf-8 value in Blacklight::Solr::Response. \""#{value}\"" Encoding is #{value.encoding}""
++          Blacklight.logger.warn ""Found a non utf-8 value in Blacklight::Solr::Response. \""#{value}\"" Encoding is #{value.encoding}""
+           value.dup.force_encoding('UTF-8')
+         else
+           value",Although this change looks good. Maybe there are other inconsistent cases too?
+286,"@@ -21,7 +21,7 @@ module ApplicationHelper
+     '/auth/github'
+   end
+
+-  def format_resources(resources)
++  def format_markdown(resources)
+     BlueCloth.new(resources).to_html.html_safe
+   end
+ ",This is a way better method name.
+287,"@@ -1,7 +1,5 @@
+ class NewLanguageConfirmationsController < ApplicationController
+   def index
+-    redirect_to welcome_to_upcase_path(
+-      confirmation: true, language_selected: params[:language],
+-    ), notice: ""Thanks for signing up. We will be in touch!""
++    redirect_to root_path, notice: t(""marketing.show.language_flash"")
+   end
+ end",Prefer single-quoted strings when you don't need string interpolation or special symbols.
+288,"@@ -1,3 +1,5 @@
++options = Array.isArray(options) ? options : [];
++
+ var invalid = [];
+
+ var attr, attrName, allowed,","I was wondering if this should allow per role specification, instead of (or in addition to) a generic ""allowed everywhere"". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the ""generic"" case you've got now: `{ '*': ['always-allowed'] }`."
+289,"@@ -942,7 +942,8 @@ SQLVarChar::SQLVarChar(Lng32 maxLen,
+ 	       FALSE, allowSQLnull, isUpShifted, isCaseInsensitive,
+ 	       TRUE, cs, co, ce,
+ 	       encoding, vcIndLen),
+-      clientDataType_(collHeap())  // Get heap from NABasicObject. Can't allocate on stack.
++      clientDataType_(collHeap()),  // Get heap from NABasicObject. Can't allocate on stack.
++      wasHiveString_(FALSE)
+ {}
+ #pragma warn(1506)  // warning elimination
+ ",I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...)
+290,"@@ -31,12 +31,7 @@ import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.grid.sessionmap.local.LocalSessionMap;
+ import org.openqa.selenium.netty.server.NettyServer;
+ import org.openqa.selenium.remote.SessionId;
+-import org.openqa.selenium.remote.http.HttpClient;
+-import org.openqa.selenium.remote.http.HttpHandler;
+-import org.openqa.selenium.remote.http.HttpRequest;
+-import org.openqa.selenium.remote.http.HttpResponse;
+-import org.openqa.selenium.remote.http.TextMessage;
+-import org.openqa.selenium.remote.http.WebSocket;
++import org.openqa.selenium.remote.http.*;
+ import org.openqa.selenium.remote.tracing.DefaultTestTracer;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ ",Could you please leave the explicit imports?
+291,"@@ -23,7 +23,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/hash""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+-	""github.com/iotexproject/iotex-core/proto""
++	iproto ""github.com/iotexproject/iotex-core/proto""
+ 	""github.com/iotexproject/iotex-core/state/factory""
+ )
+ ",Why need alias?
+292,"@@ -148,6 +148,10 @@ func (c testTLFJournalConfig) teamMembershipChecker() kbfsmd.TeamMembershipCheck
+ 	return nil
+ }
+
++func (c testTLFJournalConfig) tlfIDGetter() tlfIDGetter {
++	return nil
++}
++
+ func (c testTLFJournalConfig) diskLimitTimeout() time.Duration {
+ 	return c.dlTimeout
+ }","Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?"
+293,"@@ -156,6 +156,9 @@ const (
+ 	tealsignTooManyArg    = ""--set-lsig-arg-idx too large, maximum of %d arguments""
+ 	tealsignInfoWroteSig  = ""Wrote signature for %s to LSig.Args[%d]""
+
++	tealLogicSigSize = ""%s: logicsig program size too large: %d > %d""
++	tealAppSize      = ""%s: app program size too large: %d > %d""
++
+ 	// Wallet
+ 	infoRecoveryPrompt           = ""Please type your recovery mnemonic below, and hit return when you are done: ""
+ 	infoChoosePasswordPrompt     = ""Please choose a password for wallet '%s': """,I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings.
+294,"@@ -118,9 +118,6 @@ Status FetchVerticesExecutor::prepareTags() {
+             if (!tagIdStatus.ok()) {
+                 return tagIdStatus.status();
+             }
+-            auto tagId = tagIdStatus.value();
+-            tagNames_.push_back(tagName);
+-            tagIds_.push_back(tagId);
+             auto result = tagNameSet_.emplace(tagName);
+             if (!result.second) {
+                 return Status::Error(folly::sformat(""tag({}) was dup"", tagName));",Seems we don't need it anymore.
+295,"@@ -54,7 +54,7 @@ class Guidance < ActiveRecord::Base
+   validates :published, inclusion: { message: INCLUSION_MESSAGE,
+                                      in: BOOLEAN_VALUES}
+
+-  validates :themes, presence: { message: PRESENCE_MESSAGE }
++  validates :themes, presence: { message: PRESENCE_MESSAGE }, if: :published?
+
+   # Retrieves every guidance associated to an org
+   scope :by_org, -> (org) {",This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough.
+296,"@@ -75,7 +75,7 @@ func NewRawExporter(config Config) (*Exporter, error) {
+ // 	defer pipeline.Stop()
+ // 	... Done
+ func InstallNewPipeline(config Config) (*push.Controller, error) {
+-	controller, err := NewExportPipeline(config)
++	controller, err := NewExportPipeline(config, time.Hour)
+ 	if err != nil {
+ 		return controller, err
+ 	}","this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below..."
+297,"@@ -92,6 +92,15 @@ func (ACMEIssuer) CaddyModule() caddy.ModuleInfo {
+ func (iss *ACMEIssuer) Provision(ctx caddy.Context) error {
+ 	iss.logger = ctx.Logger(iss)
+
++	// expand email address, if non-empty
++	if iss.Email != """" {
++		email, err := caddy.NewReplacer().ReplaceOrErr(iss.Email, true, true)
++		if err != nil {
++			return fmt.Errorf(""expanding email address '%s': %v"", iss.Email, err)
++		}
++		iss.Email = email
++	}
++
+ 	// DNS providers
+ 	if iss.Challenges != nil && iss.Challenges.DNS != nil && iss.Challenges.DNS.ProviderRaw != nil {
+ 		val, err := ctx.LoadModule(iss.Challenges.DNS, ""ProviderRaw"")","I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here"
+298,"@@ -29,7 +29,9 @@ TestEnv::~TestEnv() {
+ void TestEnv::SetUp() {
+     FLAGS_load_data_interval_secs = 1;
+     // Create metaServer
+-    metaServer_ = nebula::meta::TestUtils::mockMetaServer(0, metaRootPath_.path());
++    metaServer_ = nebula::meta::TestUtils::mockMetaServer(
++                                                    network::NetworkUtils::getAvailablePort(),
++                                                    metaRootPath_.path());
+     FLAGS_meta_server_addrs = folly::stringPrintf(""127.0.0.1:%d"", metaServerPort());
+
+     // Create storageServer",Why change the port from 0 to getAvailablePort()?
+299,"@@ -691,9 +691,9 @@ class TestSeleniumScriptGeneration(SeleniumTestCase):
+             content = fds.read()
+
+         target_lines = [
+-            ""var_loc_keys=self.loc_mng.get_locator([{'name':'btn1',}])self.driver.find_element""
++            ""var_loc_keys=self.loc_mng.get_locator([{'name':'btn1',}],30.0)self.driver.find_element""
+             ""(var_loc_keys[0],var_loc_keys[1]).click()"",
+-            ""var_loc_keys=self.loc_mng.get_locator([{'id':'Id_123',}])self.driver.find_element""
++            ""var_loc_keys=self.loc_mng.get_locator([{'id':'Id_123',}],30.0)self.driver.find_element""
+             ""(var_loc_keys[0],var_loc_keys[1]).clear()"",
+             ""self.driver.find_element(var_loc_keys[0],var_loc_keys[1]).send_keys('London')""
+         ]","For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`"
+300,"@@ -30,8 +30,9 @@ func NewGlobalOpts() *GlobalOpts {
+ 	bindProjectName()
+
+ 	return &GlobalOpts{
+-		projectName: viper.GetString(projectFlag),
+-		prompt:      prompt.New(),
++		// Leave the projectName as empty in case it's overwritten by a global flag.
++		// See https://github.com/aws/amazon-ecs-cli-v2/issues/570#issuecomment-569133741
++		prompt: prompt.New(),
+ 	}
+ }
+ ","I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired."
+301,"@@ -531,7 +531,7 @@ namespace Nethermind.Core.Extensions
+         [DebuggerStepThrough]
+         public static string ByteArrayToHexViaLookup32Safe(byte[] bytes, bool withZeroX)
+         {
+-            if (bytes.Length == 0)
++            if (bytes?.Length == 0 || bytes == null)
+             {
+                 return withZeroX ? ""0x"" : """";
+             }",why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place
+302,"@@ -142,15 +142,12 @@ axe.utils.getNodeFromTree = function(vNode, node) {
+ 		return vNode;
+ 	}
+ 	vNode.children.forEach(candidate => {
+-		var retVal;
+-
+-		if (candidate.actualNode === node) {
++		if (found) {
++			return;
++		} else if (candidate.actualNode === node) {
+ 			found = candidate;
+ 		} else {
+-			retVal = axe.utils.getNodeFromTree(candidate, node);
+-			if (retVal) {
+-				found = retVal;
+-			}
++			found = axe.utils.getNodeFromTree(candidate, node);
+ 		}
+ 	});
+ 	return found;",nit: can remove this `else` since we return from the condition above.
+303,"@@ -39,11 +39,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             _flushCompleted = OnFlushCompleted;
+         }
+
+-        public void Write(ArraySegment<byte> buffer, bool chunk = false)
+-        {
+-            WriteAsync(buffer, default(CancellationToken), chunk).GetAwaiter().GetResult();
+-        }
+-
+         public Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken))
+         {
+             if (cancellationToken.IsCancellationRequested)",You missed `Write<T>(...)`! I'm kidding ofc.
+304,"@@ -5,7 +5,7 @@ class SubscriptionUpcomingInvoiceUpdater
+
+   def process
+     @subscriptions.each do |subscription|
+-      if subscription.stripe_customer_id
++      if subscription.stripe_customer_id.present?
+         upcoming_invoice = upcoming_invoice_for(subscription.stripe_customer_id)
+         update_next_payment_information(subscription, upcoming_invoice)
+       end",Was there a customer who had this set to an empty string?
+305,"@@ -13,6 +13,14 @@ module Ncr
+       approver_email_address(final_approver)
+     end
+
++    def status_aware_approver_email_address
++      if proposal.approved?
++        final_approver_email_address
++      else
++        current_approver_email_address
++      end
++    end
++
+     private
+
+     def approver_email_address(approver)","I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test."
+306,"@@ -34,4 +34,6 @@ public interface RestClientRequest {
+   void addForm(String name, Object value);
+
+   Buffer getBodyBuffer() throws Exception;
++
++  void attach(String name, String filename);
+ }","it's better to be : void attach(String name, Part part);"
+307,"@@ -77,7 +77,8 @@ public abstract class BasePageIterator {
+   protected abstract void initDefinitionLevelsReader(DataPageV1 dataPageV1, ColumnDescriptor descriptor,
+                                                      ByteBufferInputStream in, int count) throws IOException;
+
+-  protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2, ColumnDescriptor descriptor);
++  protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2, ColumnDescriptor descriptor)
++          throws IOException;
+
+   public int currentPageCount() {
+     return triplesCount;","I didn't see where the IOException can get thrown, is this just to match the V1 reader?"
+308,"@@ -418,7 +418,7 @@ unsigned int compute2DCoordsMimicDistMat(
+     RDKit::ROMol &mol, const DOUBLE_SMART_PTR *dmat, bool canonOrient,
+     bool clearConfs, double weightDistMat, unsigned int nFlipsPerSample,
+     unsigned int nSamples, int sampleSeed, bool permuteDeg4Nodes,
+-    bool forceRDKit) {
++    bool /* forceRDKit */) {
+   // storage for pieces of a molecule/s that are embedded in 2D
+   std::list<EmbeddedFrag> efrags;
+   computeInitialCoords(mol, nullptr, efrags);",We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`
+309,"@@ -473,12 +473,11 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
+ 		return nullptr;
+ 	}
+
+-	for (const auto& it : players) {
+-		if (guid == it.second->getGUID()) {
+-			return it.second;
+-		}
++	auto it = mappedPlayerGuids.find(guid);
++	if (it == mappedPlayerGuids.end()) {
++		return nullptr;
+ 	}
+-	return nullptr;
++	return it->second;
+ }
+
+ ReturnValue Game::getPlayerByNameWildcard(const std::string& s, Player*& player)","What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?"
+310,"@@ -129,7 +129,7 @@ public class ApplicationsSidebar extends Sidebar {
+         this.testingCheck = new SidebarCheckBox(tr(""Testing""));
+         this.testingCheck.selectedProperty().bindBidirectional(filter.containTestingApplicationsProperty());
+
+-        this.requiresPatchCheck = new SidebarCheckBox(tr(""Requires patch""));
++        this.requiresPatchCheck = new SidebarCheckBox(tr(""Patch Required""));
+         this.requiresPatchCheck.selectedProperty().bindBidirectional(filter.containRequiresPatchApplicationsProperty());
+
+         this.commercialCheck = new SidebarCheckBox(tr(""Commercial""));","Why upper case ""R""?"
+311,"@@ -107,3 +107,19 @@ func relativeDockerfilePath(ws copilotDirGetter, dockerfilePath string) (string,
+ 	}
+ 	return relDfPath, nil
+ }
++
++// dfBuildRequired returns if the container image should be built from local Dockerfile.
++func dfBuildRequired(svc interface{}) (bool, error) {
++	type manifest interface {
++		BuildRequired() (bool, error)
++	}
++	mf, ok := svc.(manifest)
++	if !ok {
++		return false, fmt.Errorf(""service does not have required methods BuildRequired()"")
++	}
++	required, err := mf.BuildRequired()
++	if err != nil {
++		return false, fmt.Errorf(""check if service requires building from local Dockerfile: %w"", err)
++	}
++	return required, nil
++}","Does this need to return an error or could it return `false, nil`?"
+312,"@@ -94,7 +94,7 @@ public abstract class Analyzer implements Closeable {
+    * Create a new Analyzer, reusing the same set of components per-thread
+    * across calls to {@link #tokenStream(String, Reader)}.
+    */
+-  public Analyzer() {
++  protected Analyzer() {
+     this(GLOBAL_REUSE_STRATEGY);
+   }
+ ",Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change.
+313,"@@ -85,7 +85,7 @@ class TranslationsController extends BaseAdminController
+                 'item_to_translate'             => $item_to_translate,
+                 'item_name'                     => $item_name,
+                 'module_part'                   => $module_part,
+-                'view_missing_traductions_only' => $this->getRequest()->get('view_missing_traductions_only', 1),
++                'view_missing_traductions_only' => $this->getRequest()->get('view_missing_traductions_only'),
+                 'max_input_vars_warning'        => false,
+         );
+ ","this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks"
+314,"@@ -29,8 +29,8 @@ export default function(config: Config, auth: IAuth, storage: IStorageHandler) {
+   // this might be too harsh, so ask if it causes trouble
+   // $FlowFixMe
+   app.param('package', validatePackage);
++  app.param('filename', validatePackage);
+   // $FlowFixMe
+-  app.param('filename', validateName);
+   app.param('tag', validateName);
+   app.param('version', validateName);
+   app.param('revision', validateName);",Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403.
+315,"@@ -639,7 +639,11 @@ class LabelledData(param.Parameterized):
+             for k, v in self.items():
+                 new_val = v.map(map_fn, specs, clone)
+                 if new_val is not None:
+-                    deep_mapped[k] = new_val
++                    # Ensure key validation doesn't cause errors
++                    try:
++                        deep_mapped[k] = new_val
++                    except KeyError:
++                        pass
+             if applies: deep_mapped = map_fn(deep_mapped)
+             return deep_mapped
+         else:",I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?
+316,"@@ -427,6 +427,15 @@ func (te *transactorEndpoint) Withdraw(c *gin.Context) {
+ 	}
+
+ 	chainID := config.GetInt64(config.FlagChainID)
++	if req.ChainID != 0 {
++		if _, ok := registry.Chains()[req.ChainID]; !ok {
++			utils.SendError(resp, errors.New(""Unsupported chain""), http.StatusBadRequest)
++			return
++		}
++
++		chainID = req.ChainID
++	}
++
+ 	err = te.promiseSettler.Withdraw(chainID, identity.FromAddress(req.ProviderID), common.HexToAddress(req.HermesID), common.HexToAddress(req.Beneficiary))
+ 	if err != nil {
+ 		utils.SendError(resp, err, http.StatusInternalServerError)","this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from."
+317,"@@ -57,7 +57,11 @@ func (TraceContext) Inject(ctx context.Context, supplier propagation.HTTPSupplie
+ }
+
+ func (tc TraceContext) Extract(ctx context.Context, supplier propagation.HTTPSupplier) context.Context {
+-	return ContextWithRemoteSpanContext(ctx, tc.extract(supplier))
++	sc := tc.extract(supplier)
++	if !sc.IsValid() {
++		return ctx
++	}
++	return ContextWithRemoteSpanContext(ctx, sc)
+ }
+
+ func (TraceContext) extract(supplier propagation.HTTPSupplier) core.SpanContext {","If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?"
+318,"@@ -22,8 +22,8 @@
+ #include ""depotchest.h""
+ #include ""tools.h""
+
+-DepotChest::DepotChest(uint16_t type) :
+-	Container(type), maxDepotItems(2000) {}
++DepotChest::DepotChest(uint16_t type, bool paginated /*= true*/) :
++	Container(type, items[type].maxItems, true, paginated), maxDepotItems(2000) {}
+
+ ReturnValue DepotChest::queryAdd(int32_t index, const Thing& thing, uint32_t count,
+ 		uint32_t flags, Creature* actor/* = nullptr*/) const",here shouldn't we use `depotFreeLimit`?
+319,"@@ -0,0 +1,3 @@
++# A secret token used to encrypt user_id's in the Bookmarks#export callback URL
++# functionality, for example in Refworks export of Bookmarks.
++Rails.application.config.blacklight_export_secret_token = '<%= SecureRandom.hex(64) %>'",Could we use the Rails application's secret token instead? Do we actually need our own here?
+320,"@@ -80,6 +80,10 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
+
+         self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.b, as_index=False))
+
++        self.assertRaises(ValueError, lambda: kdf.groupby('a', axis=1))
++        self.assertRaises(ValueError, lambda: kdf.groupby('a', 'b'))
++        self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.a, kdf.b))
++
+         # we can't use column name/names as a parameter `by` for `SeriesGroupBy`.
+         self.assertRaises(KeyError, lambda: kdf.a.groupby(by='a'))
+         self.assertRaises(KeyError, lambda: kdf.a.groupby(by=['a', 'b']))",so should be fixed here also
+321,"@@ -6478,8 +6478,13 @@ dr_get_mcontext_priv(dcontext_t *dcontext, dr_mcontext_t *dmc, priv_mcontext_t *
+          * when most old clients have been converted, remove this (we'll
+          * still return false)
+          */
+-        CLIENT_ASSERT(dmc->size == sizeof(dr_mcontext_t),
+-                      ""dr_mcontext_t.size field not set properly"");
++        CLIENT_ASSERT(
++            dmc->size == sizeof(dr_mcontext_t) ||
++                /* Opmask storage has been added for AVX-512 (xref i#1312).
++                 * An older client's mcontext may be filled in w/o the new structure.
++                 */
++                dmc->size == sizeof(dr_mcontext_t) - sizeof(dr_opmask_t),
++            ""dr_mcontext_t.size field not set properly"");
+         CLIENT_ASSERT(dmc->flags != 0 && (dmc->flags & ~(DR_MC_ALL)) == 0,
+                       ""dr_mcontext_t.flags field not set properly"");
+     } else",I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below.
+322,"@@ -28,6 +28,7 @@ func DefaultConfig() Config {
+ 		ReservedPorts:               []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort},
+ 		ReservedPortsUDP:            []uint16{},
+ 		DataDir:                     ""/data/"",
++		HostDataDir:                 ""/var/lib/ecs/"",
+ 		DisableMetrics:              false,
+ 		ReservedMemory:              0,
+ 		AvailableLoggingDrivers:     []dockerclient.LoggingDriver{dockerclient.JSONFileDriver},",`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary.
+323,"@@ -37,6 +37,9 @@ const (
+ 	defaultMTUGRE             = 1462
+ 	defaultMTUSTT             = 1500
+ 	defaultMTU                = 1500
++	// IPsec ESP can add a maximum of 38 bytes to the packet including the ESP
++	// header and trailer.
++	ipsecESPOverhead = 38
+ )
+
+ type Options struct {",I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec.
+324,"@@ -14,11 +14,15 @@
+ // limitations under the License.
+ // </copyright>
+
+-#nullable enable
++using System;
++using System.Collections.Generic;
++using System.Diagnostics.Metrics;
+
+ namespace OpenTelemetry.Metrics
+ {
+     public abstract class MeasurementProcessor : BaseProcessor<MeasurementItem>
+     {
++        public abstract void OnEnd<T>(MeasurementItem measurementItem, ref DateTimeOffset dt, ref T value, ref ReadOnlySpan<KeyValuePair<string, object>> tags)
++            where T : struct;
+     }
+ }","Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor<MeasurementItem> (not blocking. just noting some observations in the PR :) )"
+325,"@@ -3,6 +3,13 @@ package cmd
+ import (
+ 	""bufio""
+ 	""fmt""
++	""io/ioutil""
++	""os""
++	""path""
++	""path/filepath""
++	""runtime""
++	""strings""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.
+326,"@@ -51,7 +51,8 @@ type Options struct {
+ 	DefaultSamplingPolicy trace.Sampler
+ }
+
+-// New creates a new server. New(nil) is the same as new(Server).
++// New creates a new server. New(nil) is the same as new(Server). Note: A
++// configured Requestlogger will not log HealthChecks.
+ func New(opts *Options) *Server {
+ 	srv := new(Server)
+ 	if opts != nil {",This seems like a more appropriate message under `ListenAndServe`. WDYT?
+327,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?
+328,"@@ -360,7 +360,16 @@ class AdminController extends Controller
+         }
+
+         $searchableFields = $this->entity['search']['fields'];
+-        $paginator = $this->findBy($this->entity['class'], $this->request->query->get('query'), $searchableFields, $this->request->query->get('page', 1), $this->config['list']['max_results'], $this->request->query->get('sortField'), $this->request->query->get('sortDirection'), $this->entity['search']['dql_filter']);
++        $paginator = $this->findBy(
++            $this->entity['class'],
++            $this->request->query->get('query'),
++            $searchableFields,
++            $this->request->query->get('page', 1),
++            $this->config['list']['max_results'],
++            isset($this->entity['search']['sort']['field']) ? $this->entity['search']['sort']['field'] : $this->request->query->get('sortField'),
++            isset($this->entity['search']['sort']['direction']) ? $this->entity['search']['sort']['direction'] : $this->request->query->get('sortDirection'),
++            $this->entity['search']['dql_filter']
++        );
+         $fields = $this->entity['list']['fields'];
+
+         $this->dispatch(EasyAdminEvents::POST_SEARCH, array(",We should start thinking of an object that encapsulates this information :) we might need more arguments in the future.
+329,"@@ -4652,10 +4652,12 @@ TEST_F(VkLayerTest, RenderPassBarrierConflicts) {
+     img_barrier.subresourceRange.levelCount = 1;
+     // Mis-match src stage mask
+     m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-srcStageMask-01173"");
++    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-dstStageMask-01174"");
+     vkCmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_HOST_BIT, VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
+                          VK_DEPENDENCY_BY_REGION_BIT, 0, nullptr, 0, nullptr, 1, &img_barrier);
+     m_errorMonitor->VerifyFound();
+     // Now mis-match dst stage mask
++    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-srcStageMask-01173"");
+     m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-dstStageMask-01174"");
+     vkCmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_PIPELINE_STAGE_HOST_BIT,
+                          VK_DEPENDENCY_BY_REGION_BIT, 0, nullptr, 0, nullptr, 1, &img_barrier);","Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct."
+330,"@@ -52,11 +52,11 @@ public class EthMiningTest {
+   public void shouldReturnTrueWhenMiningCoordinatorExistsAndRunning() {
+     final JsonRpcRequest request = requestWithParams();
+     final JsonRpcResponse expectedResponse = new JsonRpcSuccessResponse(request.getId(), true);
+-    when(miningCoordinator.isRunning()).thenReturn(true);
++    when(miningCoordinator.isMining()).thenReturn(true);
+
+     final JsonRpcResponse actualResponse = method.response(request);
+     assertThat(actualResponse).isEqualToComparingFieldByField(expectedResponse);
+-    verify(miningCoordinator).isRunning();
++    verify(miningCoordinator).isMining();
+     verifyNoMoreInteractions(miningCoordinator);
+   }
+ ",rename? MiningCoordinator always exists
+331,"@@ -8,7 +8,8 @@
+ var ip = {},
+     net = require('net'),
+     extIP = require('external-ip'),
+-    plugins = require('../../../plugins/pluginManager.js');
++    plugins = require('../../../plugins/pluginManager.js'),
++    offlineMode = plugins.getConfig(""api"").offline_mode;
+
+ /**
+  * Function to get the hostname/ip address/url to access dashboard","Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file."
+332,"@@ -486,6 +486,8 @@ func (d *Dir) Cleanup(ctx context.Context, fi *dokan.FileInfo) {
+ 	defer func() { d.folder.reportErr(ctx, libkbfs.WriteMode, err) }()
+
+ 	if fi != nil && fi.IsDeleteOnClose() && d.parent != nil {
++		d.folder.fs.renameAndDeletionLock.Lock()
++		defer d.folder.fs.renameAndDeletionLock.Unlock()
+ 		d.folder.fs.log.CDebugf(ctx, ""Removing (Delete) dir in cleanup %s"", d.name)
+
+ 		err = d.folder.fs.config.KBFSOps().RemoveDir(ctx, d.parent, d.name)","Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me."
+333,"@@ -56,7 +56,7 @@ func Test_Mine(t *testing.T) {
+ 	baseBlock := &block.Block{Height: 2, StateRoot: stateRoot, Tickets: []block.Ticket{{VRFProof: []byte{0}}}}
+ 	tipSet := th.RequireNewTipSet(t, baseBlock)
+
+-	st, pool, addrs, cst, bs := sharedSetup(t, mockSignerVal)
++	st, pool, addrs, _, bs := sharedSetup(t, mockSignerVal)
+ 	getStateTree := func(c context.Context, ts block.TipSet) (state.Tree, error) {
+ 		return st, nil
+ 	}",Does anyone still use the cst out of this method? If not consider deleting
+334,"@@ -9,6 +9,7 @@ get(
+     ""/getting-started-with-ios-development?utm_source=podcast""
+   )
+ )
++get ""/videos/vim-for-rails-developers"" => redirect(""https://www.youtube.com/watch?v=9J2OjH8Ao_A"")
+ get ""/humans-present/oss"" => redirect( ""https://www.youtube.com/watch?v=VMBhumlUP-A"")
+ get ""/ios-on-rails"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+ get ""/ios-on-rails-beta"" => redirect(""https://gumroad.com/l/ios-on-rails"")",Line is too long. [97/80]
+335,"@@ -1,12 +1,14 @@
+ """""" Testing for data_transfer.py """"""
+
+ ### Python imports
++from io import BytesIO
+ import pathlib
+
+ from unittest import mock
+
+ ### Third-party imports
+ from botocore.stub import ANY
++from botocore.exceptions import ReadTimeoutError
+ import pandas as pd
+ import pytest
+ ",This seems unused.
+336,"@@ -184,8 +184,8 @@ func GetOSInterface() types.OSTypeInstaller {
+ 	case CentOSType:
+ 		return &CentOS{}
+ 	default:
++		panic(""unsupport os-release"")
+ 	}
+-	return nil
+ }
+
+ //IsKubeEdgeController identifies if the node is having edge controller and k8s api-server already running.","@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like ""This OS version is currently un-supported by keadm"""
+337,"@@ -53,6 +53,10 @@ from rdkit.Chem.Draw import rdMolDraw2D
+ from rdkit.Chem import rdDepictor
+ from rdkit.Chem import rdMolDescriptors as rdMD
+
++def _CleanFpInfoAttr_(mol):
++  if hasattr(mol, '_fpInfo'):
++    delattr(mol, '_fpInfo')
++
+
+ def GetAtomicWeightsForFingerprint(refMol, probeMol, fpFunction, metric=DataStructs.DiceSimilarity):
+   """"""",should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`.
+338,"@@ -7101,6 +7101,13 @@ bool CoreChecks::PreCallValidateCmdBindDescriptorSets(VkCommandBuffer commandBuf
+                          ""(%zu) when pipeline layout was created"",
+                          firstSet, setCount, pipeline_layout->set_layouts.size());
+     }
++
++    static const std::map<VkPipelineBindPoint, std::string> bindpoint_errors = {
++        std::make_pair(VK_PIPELINE_BIND_POINT_GRAPHICS, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361""),
++        std::make_pair(VK_PIPELINE_BIND_POINT_COMPUTE, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361""),
++        std::make_pair(VK_PIPELINE_BIND_POINT_RAY_TRACING_NV, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361"")};
++    skip |= ValidatePipelineBindPoint(cb_state, pipelineBindPoint, ""vkCmdBindPipeline()"", bindpoint_errors);
++
+     return skip;
+ }
+ ","nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)"
+339,"@@ -23,6 +23,6 @@ class Api::V1::ExercisesController < ApiController
+   end
+
+   def exercise_parameters
+-    params.require(:exercise).permit(:edit_url, :summary, :title, :url)
++    params.require(:exercise).permit(:edit_url, :summary, :name, :url)
+   end
+ end",This will need to be updated in the upcase-exercises repo as well.
+340,"@@ -21,7 +21,7 @@ class Trail < ActiveRecord::Base
+   def steps_remaining_for(user)
+     ExerciseWithProgressQuery.
+       new(user: user, exercises: exercises).
+-      count { |exercise| exercise.state != Status::REVIEWED }
++      count { |exercise| exercise.state != Status::COMPLETE }
+   end
+
+   def self.most_recent_published",Think it's worth extracting this to `Exercise#complete?`?
+341,"@@ -87,14 +87,6 @@ class Currency
+         return $this->exchangeRate;
+     }
+
+-    /**
+-     * @return string
+-     */
+-    public function getReversedExchangeRate()
+-    {
+-        return 1 / $this->exchangeRate;
+-    }
+-
+     /**
+      * @param string $exchangeRate
+      */",This is still a potentially useful public method - should we remove such methods?
+342,"@@ -40,15 +40,9 @@ public abstract class ApiDefaultsConfig {
+   /** The name of the license of the client library. */
+   public abstract String licenseName();
+
+-  protected abstract Map<TargetLanguage, ReleaseLevel> releaseLevel();
+-
+   /** The development status of the client library. Configured per language. */
+-  public ReleaseLevel releaseLevel(TargetLanguage language) {
+-    ReleaseLevel level = releaseLevel().get(language);
+-    if (level == null) {
+-      level = ReleaseLevel.UNSET_RELEASE_LEVEL;
+-    }
+-    return level;
++  public ReleaseLevel releaseLevel() {
++    return ReleaseLevel.ALPHA;
+   }
+
+   protected abstract Map<TargetLanguage, VersionBound> generatedNonGAPackageVersionBound();","I don't understand this change, what is happening here?"
+343,"@@ -944,7 +944,8 @@ class ExcelCellTextInfo(NVDAObjectTextInfo):
+
+ 	def _getFormatFieldAndOffsets(self,offset,formatConfig,calculateOffsets=True):
+ 		formatField=textInfos.FormatField()
+-		if (self.obj.excelCellObject.Application.Version > ""12.0""):
++		version=int(self.obj.excelCellObject.Application.Version.split('.')[0])
++		if version>12:
+ 			cellObj=self.obj.excelCellObject.DisplayFormat
+ 		else:
+ 			cellObj=self.obj.excelCellObject",I think its worth stating this is `versionMajor`
+344,"@@ -375,3 +375,14 @@ func (nc NodeController) readGenesisJSON(genesisFile string) (genesisLedger book
+ 	err = protocol.DecodeJSON(genesisText, &genesisLedger)
+ 	return
+ }
++
++// SetConsensus applies a new consensus settings which would get deployed before
++// any of the nodes starts
++func (nc NodeController) SetConsensus(consensus config.ConsensusProtocols) error {
++	return config.SaveConfigurableConsensus(nc.algodDataDir, consensus)
++}
++
++// GetConsensus rebuild the consensus version from the data directroy
++func (nc NodeController) GetConsensus() (config.ConsensusProtocols, error) {
++	return config.PreloadConfigurableConsensusProtocols(nc.algodDataDir)
++}",rebuild: say loads and merges
+345,"@@ -20,7 +20,6 @@
+  * External dependencies
+  */
+ import { getDefaultOptions } from 'expect-puppeteer';
+-import { Page, ElementHandle } from 'puppeteer';
+
+ /**
+  * Jest matcher for asserting the given instance has tracking loaded or not.",Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?
+346,"@@ -32,13 +32,12 @@ from databricks.koalas.series import Series
+
+
+ class PySparkTestCase(unittest.TestCase):
+-
+     def setUp(self):
+         self._old_sys_path = list(sys.path)
+         if SparkContext._active_spark_context is not None:
+             SparkContext._active_spark_context.stop()
+         class_name = self.__class__.__name__
+-        self.sc = SparkContext('local[4]', class_name)
++        self.sc = SparkContext(""local[4]"", class_name)
+
+     def tearDown(self):
+         self.sc.stop()",I'd prefer to have a blank line between the class declaration and its first member. Is it possible?
+347,"@@ -299,7 +299,7 @@ describe('Mongos SRV Polling', function () {
+         return records.map(r => `${r.name}:${r.port}`);
+       }
+
+-      const MONGOS_DEFAULT_ISMASTER = Object.assign({}, mock.DEFAULT_ISMASTER_36, {
++      const MONGOS_LEGACY_HELLO = Object.assign({}, mock.HELLO, {
+         msg: 'isdbgrid'
+       });
+ ",Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?
+348,"@@ -1922,10 +1922,10 @@ detach_on_permanent_stack(bool internal, bool do_cleanup)
+     DEBUG_DECLARE(bool ok;)
+     DEBUG_DECLARE(int exit_res;)
+     /* synch-all flags: if we fail to suspend a thread (e.g., privilege
+-     * problems) ignore it.  XXX Should we retry instead?
++     * problems) retry it.
+      */
+     /* i#297: we only synch client threads after process exit event. */
+-    uint flags = THREAD_SYNCH_SUSPEND_FAILURE_IGNORE | THREAD_SYNCH_SKIP_CLIENT_THREAD;
++    uint flags = THREAD_SYNCH_SUSPEND_FAILURE_RETRY | THREAD_SYNCH_SKIP_CLIENT_THREAD;
+
+     ENTERING_DR();
+ ","I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new ""synchall failure is fatal and should kill the process"" approach it turns what used to work for us on Windows into process death."
+349,"@@ -45,6 +45,7 @@ program
+   .option('-C <build_dir>', 'build config (out/Debug, out/Release')
+   .option('--target_arch <target_arch>', 'target architecture', 'x64')
+   .option('--mac_signing_identifier <id>', 'The identifier to use for signing')
++  .option('--mac_installer_signing_identifier <id>', 'The identifier to use for signing the installer')
+   .option('--mac_signing_keychain <keychain>', 'The identifier to use for signing', 'login')
+   .option('--debug_build <debug_build>', 'keep debugging symbols')
+   .option('--official_build <official_build>', 'force official build settings')",think it should only be in create_dist
+350,"@@ -429,9 +429,14 @@ func (c *NPLController) handleAddUpdatePod(key string, obj interface{}) error {
+ 			podPorts[port] = struct{}{}
+ 			portData := c.portTable.GetEntryByPodIPPort(podIP, int(cport.ContainerPort))
+ 			if portData == nil { // rule does not exist
+-				nodePort, err = c.portTable.AddRule(podIP, port)
+-				if err != nil {
+-					return fmt.Errorf(""failed to add rule for Pod %s: %v"", key, err)
++				if int(cport.HostPort) > 0 {
++					klog.V(4).Infof(""Host Port is defined for Container %s in Pod %s, thus extra NPL port is not allocated"", container.Name, key)
++					nodePort = int(cport.HostPort)
++				} else {
++					nodePort, err = c.portTable.AddRule(podIP, port)
++					if err != nil {
++						return fmt.Errorf(""failed to add rule for Pod %s: %v"", key, err)
++					}
+ 				}
+ 			} else {
+ 				nodePort = portData.NodePort",Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?
+351,"@@ -157,13 +157,14 @@ func (tlf *TLF) GetFileInformation(ctx context.Context, fi *dokan.FileInfo) (st
+ }
+
+ // open tries to open a file.
+-func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (dokan.File, bool, error) {
++func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (
++	dokan.File, dokan.CreateStatus, error) {
+ 	if len(path) == 0 {
+ 		if err := oc.ReturningDirAllowed(); err != nil {
+-			return nil, true, err
++			return nil, 0, err
+ 		}
+ 		tlf.refcount.Increase()
+-		return tlf, true, nil
++		return tlf, dokan.ExistingDir, nil
+ 	}
+
+ 	mode := libkbfs.ReadMode","Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?"
+352,"@@ -27,7 +27,11 @@ void deleteRegion(const storage::SharedRegionRegister::ShmKey key)
+
+ void listRegions()
+ {
+-
++    if (!storage::SharedMonitor<storage::SharedRegionRegister>::exists())
++    {
++        osrm::util::Log() << ""No shared memory regions found. Try running osrm-datastore"";
++        return;
++    }
+     storage::SharedMonitor<storage::SharedRegionRegister> monitor;
+     std::vector<std::string> names;
+     const auto &shared_register = monitor.data();",What about just printing an empty list in this case? That would make the output more predictable.
+353,"@@ -24,7 +24,6 @@ export default Component.extend({
+
+     init() {
+         this._super(...arguments);
+-        this.container = document.querySelector('.gh-editor-container')[0];
+
+         let mobiledoc = this.get('value') || BLANK_DOC;
+         let userCards = this.get('cards') || [];","I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?"
+354,"@@ -256,11 +256,11 @@ function roots_request_filter($query_vars) {
+ add_filter('request', 'roots_request_filter');
+
+ /**
+- * Tell WordPress to use searchform.php from the templates/ directory
++ * Tell WordPress to use searchform.php from the templates/ directory. Requires WordPress 3.6+
+  */
+-function roots_get_search_form($argument) {
+-  if ($argument === '') {
+-    locate_template('/templates/searchform.php', true, false);
+-  }
++function roots_get_search_form($form) {
++  $form = '';
++  locate_template('/templates/searchform.php', true, false);
++  return $form;
+ }
+ add_filter('get_search_form', 'roots_get_search_form');",I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!
+355,"@@ -19,6 +19,7 @@ use Thelia\Condition\ConditionEvaluator;
+ use Thelia\Condition\Implementation\MatchForTotalAmount;
+ use Thelia\Condition\Operators;
+ use Thelia\Coupon\FacadeInterface;
++use Thelia\Coupon\Type\FreeProduct;
+ use Thelia\Model\CartItem;
+ use Thelia\Model\CountryQuery;
+ use Thelia\Model\CurrencyQuery;",Fixes test failed in some cases
+356,"@@ -23,9 +23,7 @@ module.exports = [
+   'https://balance-staging.mercury.basicattentiontoken.org/',
+   'https://publishers.basicattentiontoken.org/',
+   'https://publishers-staging.basicattentiontoken.org/',
+-  'https://updates.bravesoftware.com/', // remove this once updates are moved to the prod environment
+-  'https://ads-serve.bravesoftware.com/', // remove this once ads catalog moves to using prod
+-  'https://pdfjs.robwu.nl/logpdfjs', // allowed because it gets canceled in tracking protection
++  'https://updates.bravesoftware.com/',
+   'https://publishers-distro.basicattentiontoken.org/',
+   'https://publishers-staging-distro.basicattentiontoken.org/',
+   'https://p3a.brave.com/',",what's the prod url for this? just curious. @amirsaber
+357,"@@ -153,6 +153,12 @@ public class Constants {
+   // Overridable plugin load properties
+   public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = ""azkaban.plugin.load.override.props"";
+
++  // Append JVM args to job commands
++  public static final String AZ_JOB_COMMAND_ARGS = ""azkaban.jvm.cmd.args"";
++
++  // Ignore the above JVM args for jobtypes which have this true.
++  public static final String AZ_JOB_IGNORE_JVM_ARGS = ""ignore.jvm.args"";
++
+   /**
+    * File containing param override configs
+    * For a directory structure, property files in Proj_Dir used to have lower precedence than A.",Can you please change this to azkaban.jobs.java.opts?
+358,"@@ -66,11 +66,10 @@ function AcquisitionPieChart( { data, args, source } ) {
+
+ 	let sourceMessage = '';
+ 	if ( source ) {
+-		sourceMessage = sprintf(
+-			/* translators: %1$s: URL to Analytics Module page in Site Kit Admin, %2$s: Analytics (Service Name) */
+-			__( 'Source: <a class=""googlesitekit-cta-link googlesitekit-cta-link--external googlesitekit-cta-link--inherit"" href=""%1$s"">%2$s</a>', 'google-site-kit' ),
++		sourceMessage = __( 'Source:', 'google-site-kit' ) + sprintf(
++			' <a class=""googlesitekit-cta-link googlesitekit-cta-link--external googlesitekit-cta-link--inherit"" href=""%1$s"">%2$s</a>',
+ 			getSiteKitAdminURL( 'googlesitekit-module-analytics' ),
+-			_x( 'Analytics', 'Service name', 'google-site-kit' ),
++			_x( 'Analytics', 'Service name', 'google-site-kit' )
+ 		);
+ 	}
+ ","Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component."
+359,"@@ -26,12 +26,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Infrastructure
+ #endif
+         }
+
+-        public static Task<int> GetCancelledZeroTask()
++        public static Task<int> GetCancelledZeroTask(CancellationToken cancellationToken = default(CancellationToken))
+         {
+-            // Task<int>.FromCanceled doesn't return Task<int>
++#if NETSTANDARD1_3
++            return Task.FromCanceled<int>(cancellationToken);
++#else
+             var tcs = new TaskCompletionSource<int>();
+             tcs.TrySetCanceled();
+             return tcs.Task;
++#endif
+         }
+     }
+ }",I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`.
+360,"@@ -295,9 +295,13 @@ void BestPractices::PreCallRecordDestroyImage(VkDevice device, VkImage image, co
+ }
+
+ void BestPractices::PreCallRecordDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks* pAllocator) {
+-    SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
+-    for (auto& image : chain->images) {
+-        ReleaseImageUsageState(image.image_state->image());
++    if (VK_NULL_HANDLE != swapchain) {
++        SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
++        for (auto& image : chain->images) {
++            if (image.image_state) {
++                ReleaseImageUsageState(image.image_state->image());
++            }
++        }
+     }
+     ValidationStateTracker::PreCallRecordDestroySwapchainKHR(device, swapchain, pAllocator);
+ }","Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious."
+361,"@@ -1131,9 +1131,10 @@ bool nano::wallet::change_sync (nano::account const & source_a, nano::account co
+
+ void nano::wallet::change_async (nano::account const & source_a, nano::account const & representative_a, std::function<void(std::shared_ptr<nano::block>)> const & action_a, uint64_t work_a, bool generate_work_a)
+ {
+-	wallets.node.wallets.queue_wallet_action (nano::wallets::high_priority, shared_from_this (), [source_a, representative_a, action_a, work_a, generate_work_a](nano::wallet & wallet_a) {
++	wallets.node.wallets.queue_wallet_action (nano::wallets::high_priority, shared_from_this (), [this, source_a, representative_a, action_a, work_a, generate_work_a](nano::wallet & wallet_a) {
+ 		auto block (wallet_a.change_action (source_a, representative_a, work_a, generate_work_a));
+ 		action_a (block);
++		this->wallets.queue_work_regeneration (std::chrono::steady_clock::now (), block);
+ 	});
+ }
+ ","Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`"
+362,"@@ -55,7 +55,8 @@ module.exports = iterateJsdoc(
+ 		) {
+ 			context.report( {
+ 				data: { name: jsdocNode.name },
+-				message: `The first word in a function's description should be a third-person verb (eg ""runs"" not ""run"").`,
++				message:
++					'The first word in a function\'s description should be a third-person verb (eg ""runs"" not ""run"").',
+ 				node: jsdocNode,
+ 			} );
+ 		}","And here. Please, use `'` for apostrophes in changed strings in this file."
+363,"@@ -100,7 +100,7 @@ func (gs *GasStation) EstimateGasForAction(actPb *iotextypes.Action) (uint64, er
+ 		if err != nil {
+ 			return 0, err
+ 		}
+-		_, receipt, err := gs.bc.ExecuteContractRead(callerAddr, sc)
++		_, receipt, err := gs.bc.SimulateExecution(callerAddr, sc)
+ 		if err != nil {
+ 			return 0, err
+ 		}",assignments should only be cuddled with other assignments (from `wsl`)
+364,"@@ -504,7 +504,15 @@ func (c *ConfigLocal) MetadataVersion() MetadataVer {
+
+ // DataVersion implements the Config interface for ConfigLocal.
+ func (c *ConfigLocal) DataVersion() DataVer {
+-	return 1
++	return FilesWithHolesDataVer
++}
++
++// DefaultNewBlockDataVersion returns the default data version for new blocks.
++func DefaultNewBlockDataVersion(c Config, holes bool) DataVer {
++	if holes {
++		return FilesWithHolesDataVer
++	}
++	return FirstValidDataVer
+ }
+
+ // DoBackgroundFlushes implements the Config interface for ConfigLocal.",Please move this to `block_types.go`.
+365,"@@ -40,9 +40,6 @@ namespace NLog.Layouts
+     /// JSON attribute.
+     /// </summary>
+     [NLogConfigurationItem]
+-    [ThreadAgnostic]
+-    [ThreadSafe]
+-    [AppDomainFixedOutput]
+     public class JsonAttribute
+     {
+         /// <summary>",So this is not needed anymore for all attributes?
+366,"@@ -46,13 +46,13 @@ namespace OpenTelemetry.Extensions.Hosting.Implementation
+             }
+         }
+
+-        [Event(1, Message = ""Failed to initialize: '{0}'. OpenTelemetry will not work."", Level = EventLevel.Error)]
++        [Event(1, Message = ""An exception occured while adding OpenTelemetry Tracing to ServiceCollection. OpenTelemetry tracing will not work. Exception: '{0}'."", Level = EventLevel.Error)]
+         public void FailedInitialize(string exception)
+         {
+             this.WriteEvent(1, exception);
+         }
+
+-        [Event(2, Message = ""Failed to get OpenTelemetrySDK: '{0}'. OpenTelemetry will not work."", Level = EventLevel.Error)]
++        [Event(2, Message = ""An exception occured while retrieving OpenTelemetry Tracer from Service Provider. OpenTelemetry tracing will not work. Exception: '{0}'."", Level = EventLevel.Error)]
+         public void FailedOpenTelemetrySDK(string exception)
+         {
+             this.WriteEvent(2, exception);",Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work.
+367,"@@ -108,6 +108,11 @@ def start_acm(port=None, asynchronous=False):
+     return start_moto_server('acm', port, name='ACM', asynchronous=asynchronous)
+
+
++def start_ses(port=None, asynchronous=False, update_listener=None):
++    port = port or config.PORT_SES
++    return start_moto_server('ses', port, name='SES', asynchronous=asynchronous, update_listener=update_listener)
++
++
+ # TODO move to es_starter.py?
+ def start_elasticsearch_service(port=None, asynchronous=False):
+     port = port or config.PORT_ES","I think we can remove this function, right? (duplicate with `ses_starter.py`)"
+368,"@@ -195,6 +195,10 @@ class PandasLikeSeries(_Frame):
+                     ""Field {} not found, possible values are {}"".format(name, "", "".join(fnames)))
+             return anchor_wrap(self, self._spark_getField(name))
+
++    # TODO: automate the process here
++    def alias(self, name):
++        return self.rename(name)
++
+     @property
+     def schema(self):
+         if not hasattr(self, '_pandas_schema') or self._pandas_schema is None:","With this fix, I am not even sure we need to overwrite this function."
+369,"@@ -311,6 +311,8 @@ class PackageEntry(object):
+ class Package(object):
+     """""" In-memory representation of a package """"""
+
++    use_tqdm = os.getenv('QUILT_USE_TQDM').lower() == 'true'
++
+     def __init__(self):
+         self._children = {}
+         self._meta = {'version': 'v0'}",Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR.
+370,"@@ -99,7 +99,7 @@ module Beaker
+       it ""can correctly combine arguments from different sources"" do
+         FakeFS.deactivate!
+         args = [""-h"", hosts_path, ""--debug"", ""--type"", ""git"", ""--install"", ""PUPPET/1.0,HIERA/hello""]
+-        expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>""git"", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>""/opt/enterprise/dists"", :pe_version_file=>""LATEST"", :pe_version_file_win=>""LATEST-win"", :dot_fog=>""#{home}/.fog"", :ec2_yaml=>""config/image_templates/ec2.yaml"", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[""publickey""], :port=>22, :forward_agent=>true, :keys=>[""#{home}/.ssh/id_rsa""], :user_known_hosts_file=>""#{home}/.ssh/known_hosts""}, :install=>[""git://github.com/puppetlabs/puppet.git#1.0"", ""git://github.com/puppetlabs/hiera.git#hello""], :HOSTS=>{:""pe-ubuntu-lucid""=>{:roles=>[""agent"", ""dashboard"", ""database"", ""master""], :vmname=>""pe-ubuntu-lucid"", :platform=>""ubuntu-10.04-i386"", :snapshot=>""clean-w-keys"", :hypervisor=>""fusion""}, :""pe-centos6""=>{:roles=>[""agent""], :vmname=>""pe-centos6"", :platform=>""el-6-i386"", :hypervisor=>""fusion"", :snapshot=>""clean-w-keys""}}, :nfs_server=>""none"", :puppet_ver=>nil, :facter_ver=>nil, :hiera_ver=>nil, :hiera_puppet_ver=>nil, :helper=>[], :load_path=>[], :tests=>[], :pre_suite=>[], :post_suite=>[], :modules=>[]}
++        expect(parser.parse_args(args)).to be === {:hosts_file=>""/Users/anode/beaker/spec/beaker/options/data/hosts.cfg"", :options_file=>nil, :type=>""git"", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>""/opt/enterprise/dists"", :pe_version_file=>""LATEST"", :pe_version_file_win=>""LATEST-win"", :dot_fog=>""/Users/anode/.fog"", :ec2_yaml=>""config/image_templates/ec2.yaml"", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[""publickey""], :port=>22, :forward_agent=>true, :keys=>[""/Users/anode/.ssh/id_rsa""], :user_known_hosts_file=>""/Users/anode/.ssh/known_hosts""}, :install=>[""git://github.com/puppetlabs/puppet.git#1.0"", ""git://github.com/puppetlabs/hiera.git#hello""], :HOSTS=>{:""pe-ubuntu-lucid""=>{:roles=>[""agent"", ""dashboard"", ""database"", ""master""], :vmname=>""pe-ubuntu-lucid"", :platform=>""ubuntu-10.04-i386"", :snapshot=>""clean-w-keys"", :hypervisor=>""fusion""}, :""pe-centos6""=>{:roles=>[""agent""], :vmname=>""pe-centos6"", :platform=>""el-6-i386"", :hypervisor=>""fusion"", :snapshot=>""clean-w-keys""}}, :nfs_server=>""none"", :helper=>[], :load_path=>[], :tests=>[], :pre_suite=>[], :post_suite=>[], :modules=>[]}
+       end
+
+       it ""ensures that file-mode is one of fast/stop"" do",You've got an absolute path here referencing your home dir :-).
+371,"@@ -526,10 +526,10 @@ public final class JavaParserMetaModel {
+         unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.expressionPropertyMetaModel);
+         unaryExprMetaModel.operatorPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""operator"", com.github.javaparser.ast.expr.UnaryExpr.Operator.class, Optional.empty(), false, false, false, false, false);
+         unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.operatorPropertyMetaModel);
+-        unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""prefix"", boolean.class, Optional.empty(), false, true, false, false, false);
+-        unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.prefixPropertyMetaModel);
+         unaryExprMetaModel.postfixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""postfix"", boolean.class, Optional.empty(), false, true, false, false, false);
+         unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.postfixPropertyMetaModel);
++        unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""prefix"", boolean.class, Optional.empty(), false, true, false, false, false);
++        unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.prefixPropertyMetaModel);
+         variableDeclarationExprMetaModel.annotationsPropertyMetaModel = new PropertyMetaModel(variableDeclarationExprMetaModel, ""annotations"", com.github.javaparser.ast.expr.AnnotationExpr.class, Optional.of(annotationExprMetaModel), false, false, true, false, false);
+         variableDeclarationExprMetaModel.getDeclaredPropertyMetaModels().add(variableDeclarationExprMetaModel.annotationsPropertyMetaModel);
+         variableDeclarationExprMetaModel.modifiersPropertyMetaModel = new PropertyMetaModel(variableDeclarationExprMetaModel, ""modifiers"", com.github.javaparser.ast.Modifier.class, Optional.empty(), false, false, false, true, false);",Maybe I should do some sorting so that these properties don't keep moving around...
+372,"@@ -32,14 +32,6 @@ func TestCheckMountDestFalsePositive(t *testing.T) {
+ 	}
+ }
+
+-func TestCheckMountRoot(t *testing.T) {
+-	dest := ""/rootfs""
+-	err := checkMountDestination(""/rootfs"", dest)
+-	if err == nil {
+-		t.Fatal(err)
+-	}
+-}
+-
+ func TestNeedsSetupDev(t *testing.T) {
+ 	config := &configs.Config{
+ 		Mounts: []*configs.Mount{","Can we keep this test anyway, as it's part of the spec?"
+373,"@@ -0,0 +1,19 @@
++<?php
++
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See license.txt for license details.
++ */
++
++declare(strict_types = 1);
++
++namespace Ergonode\Mailer;
++
++use Ergonode\Mailer\Application\DependencyInjection\CompilerPass\MailerStrategyInterfaceCompilerPass;
++use Ergonode\SharedKernel\Application\AbstractModule;
++
++/**
++ */
++class ErgonodeMailerBundle extends AbstractModule
++{
++}",Can be removed
+374,"@@ -1,5 +1,7 @@
+ <?php namespace System\Controllers;
+
++use Config;
++use Request;
+ use Lang;
+ use Flash;
+ use Backend;","It's a minor quibble I know, but I like having the imports ordered by lengt"
+375,"@@ -216,7 +216,7 @@ public abstract class AbstractRestInvocation {
+       }
+     }
+     responseEx.setStatus(response.getStatusCode(), response.getReasonPhrase());
+-    responseEx.setContentType(produceProcessor.getName());
++    responseEx.setContentType(produceProcessor.getName()+""; charset=utf-8"");
+
+     Object body = response.getResult();
+     if (response.isFailed()) {",It's better to get the charset from context or other setting to let the user override it.
+376,"@@ -70,7 +70,7 @@ func NewCStorPoolController(
+ 	cStorInformerFactory informers.SharedInformerFactory) *CStorPoolController {
+
+ 	// obtain references to shared index informers for the cStorPool resources
+-	cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().NewTestCStorPools()
++	cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().CStorPoolInstances()
+
+ 	zpool.KubeClient = kubeclientset
+ 	zpool.OpenEBSClient = clientset",this filename as well needs change
+377,"@@ -179,10 +179,11 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
+ // ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
+ // configuration for AWS
+ type ACMEIssuerDNS01ProviderRoute53 struct {
+-	AccessKeyID     string            `json:""accessKeyID""`
+-	SecretAccessKey SecretKeySelector `json:""secretAccessKeySecretRef""`
+-	HostedZoneID    string            `json:""hostedZoneID""`
+-	Region          string            `json:""region""`
++	AccessKeyID        string            `json:""accessKeyID,omitempty""`
++	AccessKeyIDRef     SecretKeySelector `json:""accessKeyIDSecretRef,omitempty""`
++	SecretAccessKeyRef SecretKeySelector `json:""secretAccessKeySecretRef""`
++	HostedZoneID       string            `json:""hostedZoneID""`
++	Region             string            `json:""region""`
+ }
+
+ // ACMEIssuerDNS01ProviderAzureDNS is a structure containing the",I think we want to remove `omitempty` here
+378,"@@ -129,6 +129,8 @@ func startContainer(context *cli.Context, spec *specs.LinuxSpec) (int, error) {
+ 	if err != nil {
+ 		return -1, err
+ 	}
++	handler := newSignalHandler(tty)
++	defer handler.Close()
+ 	if err := container.Start(process); err != nil {
+ 		return -1, err
+ 	}",You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start
+379,"@@ -376,8 +376,7 @@ lookupTables.role = {
+ 			one: ['rowgroup', 'row']
+ 		},
+ 		nameFrom: ['author'],
+-		context: null,
+-		implicit: ['table']
++		context: null
+ 	},
+ 	'gridcell': {
+ 		type: 'widget',",I updated only the implicit roles who needed a update for this new rule to validate.
+380,"@@ -7,11 +7,12 @@
+ package pb
+
+ import (
++	reflect ""reflect""
++	sync ""sync""
++
+ 	proto ""github.com/golang/protobuf/proto""
+ 	protoreflect ""google.golang.org/protobuf/reflect/protoreflect""
+ 	protoimpl ""google.golang.org/protobuf/runtime/protoimpl""
+-	reflect ""reflect""
+-	sync ""sync""
+ )
+
+ const (",> // Code generated by protoc-gen-go. DO NOT EDIT.
+381,"@@ -46,6 +46,9 @@ var (
+ 		utils.GcloudProdWrapperLatest:   ""gcloud"",
+ 		utils.GcloudLatestWrapperLatest: ""gcloud"",
+ 	}
++	// Apply this as instance metadata if the OS config agent is not
++	// supported for the platform or version being imported.
++	skipOSConfig = map[string]string{""osconfig_not_supported"": ""true""}
+ )
+
+ type ovfInstanceImportTestProperties struct {","minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean"
+382,"@@ -56,7 +56,9 @@ public class NSRSS20 extends Namespace {
+ 			boolean validType = false;
+ 			boolean validUrl = !TextUtils.isEmpty(url);
+
+-			if (type == null) {
++			if(SyndTypeUtils.enclosureTypeValid(type)) {
++				validType = true;
++			} else {
+ 				type = SyndTypeUtils.getMimeTypeFromUrl(url);
+ 			}
+ ","~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for ""fixing"" this!"
+383,"@@ -239,3 +239,16 @@ func (client *Client) Stop() error {
+
+ 	return nil
+ }
++
++// GetSessions returns all sessions from history
++func (client *Client) GetSessions() (endpoints.SessionsDTO, error) {
++	response, err := client.http.Get(""sessions"", url.Values{})
++	if err != nil {
++		return endpoints.SessionsDTO{}, err
++	}
++	defer response.Body.Close()
++
++	var sessions endpoints.SessionsDTO
++	err = parseResponseJSON(response, &sessions)
++	return sessions, err
++}",`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler.
+384,"@@ -5242,8 +5242,11 @@ master_signal_handler_C(byte *xsp)
+
+     /* Ensure we didn't get the app's sigstack into our frame.  On Mac, the kernel
+      * doesn't use the frame's uc_stack, so we limit this to Linux.
++     * The pointers may be different if a thread is on its way to exit, and the app's
++     * sigstack was already restored (i#3369).
+      */
+-    IF_LINUX(ASSERT(dcontext == NULL || dcontext == GLOBAL_DCONTEXT ||
++    IF_LINUX(ASSERT(dcontext == NULL || dcontext->is_exiting ||
++                    dcontext == GLOBAL_DCONTEXT ||
+                     frame->uc.uc_stack.ss_sp ==
+                         ((thread_sig_info_t *)dcontext->signal_field)->sigstack.ss_sp));
+ ",These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1)
+385,"@@ -24,7 +24,8 @@ namespace Http2SampleApp
+                     factory.SetMinimumLevel(LogLevel.Trace);
+                     factory.AddConsole();
+                 })
+-                .UseKestrel((context, options) =>
++                .UseKestrel()
++                .ConfigureKestrel((context, options) =>
+                 {
+                     var basePort = context.Configuration.GetValue<int?>(""BASE_PORT"") ?? 5000;
+ ",Why not change the other samples?
+386,"@@ -10,8 +10,9 @@ table.isHeader = function (cell) {
+ 		return true;
+ 	}
+
+-	if (cell.id) {
+-		return !!document.querySelector('[headers~=""' + axe.utils.escapeSelector(cell.id) + '""]');
++	if (cell.getAttribute('id')) {
++    const id = axe.utils.escapeSelector(cell.getAttribute('id'));
++		return !!document.querySelector(`[headers~=""${id}""]`);
+ 	}
+
+ 	return false;","Indentation is mixed up here due to spaces/tabs, I'm guessing."
+387,"@@ -738,9 +738,15 @@ static fpga_result poll_interrupt(fpga_dma_handle dma_h) {
+ 		res = FPGA_EXCEPTION;
+ 	} else {
+ 		uint64_t count = 0;
+-		read(pfd.fd, &count, sizeof(count));
+-		debug_print(""Poll success. Return = %d, count = %d\n"",poll_res, (int)count);
+-		res = FPGA_OK;
++		ssize_t bytes_read = read(pfd.fd, &count, sizeof(count));
++		if(bytes_read <= 0) {
++			fprintf( stderr, ""Error: %s\n"",
++				bytes_read < 0 ? strerror(errno) : ""zero bytes read"");
++			res = FPGA_EXCEPTION;
++		} else {
++			debug_print(""Poll success. Return = %d, count = %d\n"",poll_res, (int)count);
++			res = FPGA_OK;
++		}
+ 	}
+
+ out:",Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?
+388,"@@ -138,7 +138,10 @@ class PluginBase extends ServiceProviderBase
+      */
+     public function registerSettings()
+     {
+-        return [];
++		$configuration = $this->getConfigurationFromYaml();
++		if (array_key_exists('settings', $configuration)) {
++			return $configuration['settings'];
++		}
+     }
+
+     /**","Project standard is spaces, not tabs. Please fix and then we can merge this."
+389,"@@ -1,12 +1,14 @@
+ #include ""dynamic_zone.h""
+-#include ""expedition.h""
+-#include ""expedition_state.h""
++#include ""cliententry.h""
++#include ""clientlist.h""
++#include ""dynamic_zone_manager.h""
+ #include ""worlddb.h""
+ #include ""zonelist.h""
+ #include ""zoneserver.h""
+ #include ""../common/eqemu_logsys.h""
+ #include ""../common/repositories/instance_list_repository.h""
+
++extern ClientList client_list;
+ extern ZSList zoneserver_list;
+
+ Database& DynamicZone::GetDatabase()",@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here
+390,"@@ -226,11 +226,11 @@ public class ManifestReader extends CloseableGroup implements Filterable<Filtere
+
+   @Override
+   public Iterator<DataFile> iterator() {
+-    return iterator(alwaysTrue(), fileSchema);
++    return iterator(fileSchema);
+   }
+
+   // visible for use by PartialManifest
+-  Iterator<DataFile> iterator(Expression partFilter, Schema fileProjection) {
++  Iterator<DataFile> iterator(Schema fileProjection) {
+     return Iterables.transform(Iterables.filter(
+         entries(fileProjection),
+         entry -> entry.status() != ManifestEntry.Status.DELETED),",The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there.
+391,"@@ -24,7 +24,15 @@ module Mongoid
+             # @since 1.0.0
+             def evolve(object)
+               __evolve__(object) do |obj|
+-                obj ? obj.to_s : obj
++                if obj
++                  if obj.is_a?(::BigDecimal) && Mongoid.map_big_decimal_to_decimal128
++                    BSON::Decimal128.new(obj)
++                  elsif obj.is_a?(BSON::Decimal128) && Mongoid.map_big_decimal_to_decimal128
++                    obj
++                  else
++                    obj.to_s
++                  end
++                end
+               end
+             end
+           end",I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option.
+392,"@@ -1,6 +1,7 @@
+ # frozen_string_literal: true
+
+ require 'bolt/application'
++require 'bolt/plan_creator'
+
+ require 'bolt_spec/files'
+ ",We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded.
+393,"@@ -34,7 +34,10 @@ namespace Benchmarks
+
+         private static IConfig GetConfig(Options options)
+         {
+-            var baseJob = Job.ShortRun; // let's use the Short Run for better first user experience ;)
++            var baseJob = Job.Default
++                .WithWarmupCount(1) // 1 warmup is enough for our purpose
++                .WithMaxTargetIterationCount(20);  // we don't want to run more that 20 iterations
++
+             var jobs = GetJobs(options, baseJob).ToArray();
+
+             var config = DefaultConfig.Instance",">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default."
+394,"@@ -47,7 +47,7 @@ class Service(object):
+         self.start_error_message = start_error_message
+         self.log_file = log_file
+         self.env = env or os.environ
+-
++
+     @property
+     def service_url(self):
+         """"""",can just remove it ?
+395,"@@ -654,7 +654,17 @@ func MigrateRepository(u *User, opts MigrateRepoOptions) (*Repository, error) {
+ 		return repo, UpdateRepository(repo, false)
+ 	}
+
+-	if err = createUpdateHook(repoPath); err != nil {
++	repo, err = FinishMigrateRepository(repo, repoPath)
++	if err != nil {
++		return repo, err
++	}
++
++	return repo, UpdateRepository(repo, false)
++}
++
++// Finish migrating repository with things that don't need to be done for mirrors.
++func FinishMigrateRepository(repo *Repository, repoPath string) (*Repository, error) {
++	if err := createUpdateHook(repoPath); err != nil {
+ 		return repo, fmt.Errorf(""createUpdateHook: %v"", err)
+ 	}
+ ",Better call it `CleanUpMirrorInfo`?
+396,"@@ -405,6 +405,19 @@ func (node *Node) SetupMining(ctx context.Context) error {
+ 		}
+ 	}
+
++	if err := node.StorageMining.Start(ctx); err != nil {
++		fmt.Printf(""error starting storage miner: %s\n"", err)
++	}
++
++	if err := node.StorageProtocol.StorageProvider.Start(ctx); err != nil {
++		fmt.Printf(""error starting storage provider: %s\n"", err)
++	}
++
++	// TODO: Retrieval Market Integration
++	//if err := node.RetrievalProtocol.RetrievalProvider.Start(); err != nil {
++	//	fmt.Printf(""error starting retrieval provider: %s\n"", err)
++	//}
++
+ 	return nil
+ }
+ ",@shannonwells is there still something missing here?
+397,"@@ -149,6 +149,9 @@ MESSAGE
+       # don't accidentally leave the seed encoded.
+       define_reader :seed
+
++      # Time limit for stress testing, if any (default: nil).
++      add_setting :stress_test
++
+       # When a block passed to pending fails (as expected), display the failure
+       # without reporting it as a failure (default: false).
+       add_setting :show_failures_in_pending_blocks",This could be more indicative of what it is... e.g... `stresstest_time_limit`
+398,"@@ -279,7 +279,6 @@ bool PDPSimple::createPDPEndpoints()
+         delete mp_listener;
+         mp_listener = nullptr;
+         reader_payload_pool_->release_history(reader_pool_cfg, true);
+-        TopicPayloadPoolRegistry::release(reader_payload_pool_);
+         return false;
+     }
+ ",Shouldn't we do a `reader_payload_pool_.reset()` here?
+399,"@@ -33,9 +33,9 @@ type Block struct {
+ 	// ElectionProof is the vrf proof giving this block's miner authoring rights
+ 	ElectionProof *crypto.ElectionProof
+
+-	// DrandEntries contain the verifiable oracle randomness used to elect
++	// BeaconEntries contain the verifiable oracle randomness used to elect
+ 	// this block's author leader
+-	DrandEntries []*drand.Entry
++	BeaconEntries []*drand.Entry
+
+ 	// PoStProofs are the winning post proofs
+ 	PoStProofs []PoStProof `json:""PoStProofs""`",I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change.
+400,"@@ -853,6 +853,11 @@ class DynamicMap(HoloMap):
+                 unbounded_dims.append(str(kdim))
+         return unbounded_dims
+
++    @property
++    def current_key(self):
++        """"""Returns the current key value.""""""
++        return getattr(self, '_current_key', None)
++
+     def _stream_parameters(self):
+         return util.stream_parameters(
+             self.streams, no_duplicates=not self.positional_stream_args",I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here.
+401,"@@ -22,8 +22,14 @@ const FromCSVKind = ""fromCSV""
+ type FromCSVOpSpec struct {
+ 	CSV  string `json:""csv""`
+ 	File string `json:""file""`
++	Mode string `json:""mode""`
+ }
+
++const (
++	annotationMode = ""annotations""
++	rawMode        = ""raw""
++)
++
+ func init() {
+ 	fromCSVSignature := runtime.MustLookupBuiltinType(""csv"", ""from"")
+ 	runtime.RegisterPackageValue(""csv"", ""from"", flux.MustValue(flux.FunctionValue(FromCSVKind, createFromCSVOpSpec, fromCSVSignature)))",I guess I like the name `mode` okay. I can't think of anything better.
+402,"@@ -69,8 +69,12 @@ type Step struct {
+ 	testType stepImpl
+ }
+
+-// NewStep creates a Step with given name and timeout  with the specified workflow
++// NewStep creates a Step with given name and timeout  with the specified workflow.
++// If timeout is less or equal to zero, defaultTimeout from the workflow will be used
+ func NewStep(name string, w *Workflow, timeout time.Duration) *Step {
++	if timeout <= 0 {
++		return &Step{name: name, w: w, Timeout: w.DefaultTimeout}
++	}
+ 	return &Step{name: name, w: w, timeout: timeout}
+ }
+ ",I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic
+403,"@@ -71,6 +71,7 @@ func Register(r *gin.RouterGroup, s *Service) {
+ // @Param experimentNamespace query string false ""The namespace of the experiment""
+ // @Param uid query string false ""The UID of the experiment""
+ // @Param kind query string false ""kind"" Enums(PodChaos, IoChaos, NetworkChaos, TimeChaos, KernelChaos, StressChaos)
++// @Param limit query string false ""The max length of events list""
+ // @Success 200 {array} core.Event
+ // @Router /api/events [get]
+ // @Failure 500 {object} utils.APIError",Are these limit changes related?
+404,"@@ -18,12 +18,12 @@ Routing and network interface handling for IPv6.
+
+ from __future__ import absolute_import
+ import socket
++import scapy.consts
+ from scapy.config import conf
+ from scapy.utils6 import *
+ from scapy.arch import *
+ from scapy.pton_ntop import *
+ from scapy.error import warning, log_loading
+-from scapy.consts import LOOPBACK_INTERFACE
+ import scapy.modules.six as six
+
+ ",Don't you mean `import scapy.consts`?
+405,"@@ -62,3 +62,7 @@ func (e *Executor) ensurePrimaryUpdate(ctx context.Context) model.StageStatus {
+ 	e.LogPersister.AppendSuccess(fmt.Sprintf(""Successfully applied %d primary resources"", len(manifests)))
+ 	return model.StageStatus_STAGE_SUCCESS
+ }
++
++func (e *Executor) rollbackPrimary(ctx context.Context) model.StageStatus {
++	return model.StageStatus_STAGE_SUCCESS
++}",`ctx` is unused in rollbackPrimary
+406,"@@ -40,7 +40,7 @@ const (
+ 	// BufferedEventID is the id of the buffered event
+ 	BufferedEventID int64 = -123
+ 	// EmptyEventTaskID is uninitialized id of the task id within event
+-	EmptyEventTaskID int64 = -1234
++	EmptyEventTaskID int64 = 0
+ 	// TransientEventID is the id of the transient event
+ 	TransientEventID int64 = -124
+ 	// FirstBlobPageToken is the page token identifying the first blob for each history archival",This is not what title says.
+407,"@@ -0,0 +1,19 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.autofix;
++
++import net.sourceforge.pmd.lang.ast.Node;
++
++/**
++ * Classes of this interface must be used when it is desired to make one or more operations to the AST.
++ */
++public interface RuleViolationFix {
++
++    /**
++     * Apply one or more operations to a node.
++     * @param node the node in the AST on which to apply operations
++     */
++    void applyFixesToNode(Node node);
++}",a fix applies several fixes? maybe this should simply be `applyToNode`
+408,"@@ -25,11 +25,12 @@ import (
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+
++// fakeGetClientset gets the cvr clientset
+ func fakeGetClientset() (clientset *clientset.Clientset, err error) {
+ 	return &client.Clientset{}, nil
+ }
+
+-func fakeListfn(cli *clientset.Clientset, namespace string, opts metav1.ListOptions) (*apis.CStorVolumeReplicaList, error) {
++func fakeListOk(cli *clientset.Clientset, namespace string, opts metav1.ListOptions) (*apis.CStorVolumeReplicaList, error) {
+ 	return &apis.CStorVolumeReplicaList{}, nil
+ }
+ ",U1000: func `fakeGetOk` is unused (from `unused`)
+409,"@@ -18,6 +18,8 @@ import (
+ 	""errors""
+ 	""fmt""
+
++	""k8s.io/client-go/util/retry""
++
+ 	""github.com/hashicorp/go-multierror""
+ 	""golang.org/x/sync/errgroup""
+ 	v1 ""k8s.io/api/core/v1""","Because there is a ""k8s.io/client-go/tools/cache"" below, we can sort out all the ""imports"" here."
+410,"@@ -3,7 +3,9 @@
+ package api
+
+ import (
++	""github.com/aws/aws-sdk-go/aws""
+ 	""fmt""
++	""encoding/json""
+ 	""reflect""
+ 	""sort""
+ 	""strings""","Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports."
+411,"@@ -118,8 +118,10 @@ func (o *deletePipelineOpts) Ask() error {
+
+ // Execute deletes the secret and pipeline stack.
+ func (o *deletePipelineOpts) Execute() error {
+-	if err := o.deleteSecret(); err != nil {
+-		return err
++	if o.PipelineSecret != """" {
++		if err := o.deleteSecret(); err != nil {
++			return err
++		}
+ 	}
+
+ 	if err := o.deleteStack(); err != nil {",Do we not have tests for pipeline delete
+412,"@@ -146,6 +146,12 @@ class HdfsClient(hdfs_abstract_client.HdfsFileSystem):
+     def put(self, local_path, destination):
+         self.call_check(load_hadoop_cmd() + ['fs', '-put', local_path, destination])
+
++    def append(self, local_path, destination):
++        """"""
++        Requires Hadoop >= 2.3.0
++        """"""
++        call_check(load_hadoop_cmd() + ['fs', '-appendToFile', local_path, destination])
++
+     def get(self, path, local_destination):
+         self.call_check(load_hadoop_cmd() + ['fs', '-get', path, local_destination])
+ ",Good that you mention this constraint in the docstring :)
+413,"@@ -15,8 +15,13 @@ package workflow
+
+ import (
+ 	""encoding/json""
++	""fmt""
+ 	""net/http""
+
++	ctrl ""sigs.k8s.io/controller-runtime""
++
++	apierrors ""k8s.io/apimachinery/pkg/api/errors""
++
+ 	""github.com/gin-gonic/gin""
+
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""",remove this blank?
+414,"@@ -9515,7 +9515,8 @@ FileScan::FileScan(const CorrName& tableName,
+      estRowsAccessed_ (0),
+      mdamFlag_(UNDECIDED),
+      skipRowsToPreventHalloween_(FALSE),
+-     doUseSearchKey_(TRUE)
++     doUseSearchKey_(TRUE),
++     computedNumOfActivePartiions_(-1)
+ {
+   // Set the filescan properties:
+ ","Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those."
+415,"@@ -22,9 +22,11 @@
+ import shlex
+
+ from PyQt5.QtCore import (pyqtSlot, pyqtSignal, QObject, QProcess,
+-                          QProcessEnvironment)
++                          QProcessEnvironment, QUrl)
+
+-from qutebrowser.utils import message, log
++from qutebrowser.utils import message, log, objreg
++
++from qutebrowser.browser import qutescheme
+
+ # A mapping of QProcess::ErrorCode's to human-readable strings.
+ ",Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports.
+416,"@@ -45,6 +45,8 @@ var ActionCmd = &cobra.Command{
+ 	Args:  cobra.MinimumNArgs(1),
+ }
+
++var insecure bool
++
+ func init() {
+ 	ActionCmd.AddCommand(actionHashCmd)
+ 	ActionCmd.AddCommand(actionTransferCmd)",`insecure` is a global variable (from `gochecknoglobals`)
+417,"@@ -479,6 +479,11 @@ func HTTPBackend(ctx *context.Context, cfg *serviceConfig) http.HandlerFunc {
+ 		for _, route := range routes {
+ 			r.URL.Path = strings.ToLower(r.URL.Path) // blue: In case some repo name has upper case name
+ 			if m := route.reg.FindStringSubmatch(r.URL.Path); m != nil {
++				if setting.Repository.DisableHttpGit {
++					w.WriteHeader(http.StatusForbidden)
++					w.Write([]byte(""Interacting with repositories by HTTP protocol is not allowed""))
++					return
++				}
+ 				if route.method != r.Method {
+ 					if r.Proto == ""HTTP/1.1"" {
+ 						w.WriteHeader(http.StatusMethodNotAllowed)",Same as above (HTTP in upper-case)
+418,"@@ -206,4 +206,11 @@ class YouTubeProviderTest extends AbstractProviderTest
+         $this->assertSame(100, $properties['player_parameters']['height']);
+         $this->assertSame(100, $properties['player_parameters']['width']);
+     }
++
++    public function testGetReferenceUrl()
++    {
++        $media = new Media();
++        $media->setProviderReference('123456');
++        $this->assertEquals('http://www.youtube.com/watch?v=123456', $this->getProvider()->getReferenceUrl($media));
++    }
+ }",This is getting repetitive  maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?
+419,"@@ -0,0 +1,5 @@
++package reflect
++
++func MakeFunc(typ Type, fn func(args []Value) (results []Value)) Value {
++	return Value{}
++}","I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead."
+420,"@@ -73,7 +73,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
+ 	else if (name[0]==='o' && name[1]==='n') {
+ 		let useCapture = name !== (name=name.replace(/Capture$/, ''));
+ 		let nameLower = name.toLowerCase();
+-		name = (nameLower in dom ? nameLower : name).substring(2);
++		name = (nameLower in window ? nameLower : name).substring(2);
+
+ 		if (value) {
+ 			if (!oldValue) dom.addEventListener(name, eventProxy, useCapture);",Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit
+421,"@@ -224,9 +224,7 @@ func (m *ipipManager) CompleteDeferredWork() error {
+ 		for _, ip := range m.activeHostnameToIP {
+ 			members = append(members, ip)
+ 		}
+-		for _, ip := range m.externalNodeCIDRs {
+-			members = append(members, ip)
+-		}
++		members = append(members, m.externalNodeCIDRs...)
+ 		m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, members)
+ 		m.ipSetInSync = true
+ 	}",Same change just above?
+422,"@@ -35,7 +35,8 @@
+         // Promise() being missing on some legacy browser, and a funky one
+         // is Promise() present but buggy on WebOS 2
+         window.Promise = undefined;
+-        window.Promise = undefined;
++        /* eslint-disable-next-line no-restricted-globals -- Explicit check on self needed */
++        self.Promise = undefined;
+     }
+
+     if (!window.Promise) {",I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here.
+423,"@@ -7,13 +7,7 @@ test_name ""bolt plan run should apply manifest block on remote hosts via ssh"" do
+   extend Acceptance::BoltCommandHelper
+
+   ssh_nodes = select_hosts(roles: ['ssh'])
+-  skip_targets = select_hosts(platform: [/debian-8/])
+   targets = ""ssh_nodes""
+-  if skip_targets.any?
+-    ssh_nodes -= skip_targets
+-    targets = ssh_nodes.each_with_object([]) { |node, acc| acc.push(node[:vmhostname]) }.join("","")
+-  end
+-
+   skip_test('no applicable nodes to test on') if ssh_nodes.empty?
+
+   dir = bolt.tmpdir('apply_ssh')",Since this var is no longer defined we should remove the `if skip_targets.any?` bit below.
+424,"@@ -170,6 +170,12 @@ def func_arn(function_name):
+     return aws_stack.lambda_function_arn(function_name)
+
+
++def func_qualifier(function_name, qualifier=None):
++    arn = aws_stack.lambda_function_arn(function_name)
++    if ARN_TO_LAMBDA.get(arn).qualifier_exists(qualifier):
++        return '{}:{}'.format(arn, qualifier)
++
++
+ def check_batch_size_range(source_arn, batch_size=None):
+     batch_size_entry = BATCH_SIZE_RANGES.get(source_arn.split(':')[2].lower())
+     if not batch_size_entry:",I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`).
+425,"@@ -41,6 +41,11 @@ type NATProxy struct {
+
+ func (np *NATProxy) consumerHandOff(consumerPort int, remoteConn *net.UDPConn) chan struct{} {
+ 	stop := make(chan struct{})
++	if np.socketProtect == nil {
++		// shutdown pinger session since openvpn client will connect directly (without NATProxy)
++		remoteConn.Close()
++		return stop
++	}
+ 	go np.consumerProxy(consumerPort, remoteConn, stop)
+ 	return stop
+ }","Why session is started at all, if you need to shut it down e.g. DI should launch noopSession"
+426,"@@ -184,7 +184,7 @@ type describer interface {
+ }
+
+ type workspaceDeleter interface {
+-	DeleteAll() error
++	DeleteWorkspaceFile() error
+ }
+
+ type svcManifestReader interface {",nit: can we rename the interface to `wsFileDeleter`
+427,"@@ -91,10 +91,10 @@ func hashRule(r *rule) string {
+ // It's the struct used by reconciler.
+ type CompletedRule struct {
+ 	*rule
+-	// Source Pods of this rule, can't coexist with ToAddresses.
+-	FromAddresses v1beta1.GroupMemberPodSet
+-	// Destination Pods of this rule, can't coexist with FromAddresses.
+-	ToAddresses v1beta1.GroupMemberPodSet
++	// Source GroupMembers of this rule, can't coexist with ToAddresses.
++	FromAddresses v1beta1.GroupMemberSet
++	// Destination GroupMembers of this rule, can't coexist with FromAddresses.
++	ToAddresses v1beta1.GroupMemberSet
+ 	// Target Pods of this rule.
+ 	Pods v1beta1.GroupMemberPodSet
+ }",Why target cannot be external endpoints?
+428,"@@ -127,4 +127,8 @@ public interface CollectionAdminParams {
+
+   /** Option to follow aliases when deciding the target of a collection admin command. */
+   String FOLLOW_ALIASES = ""followAliases"";
++
++  /** Prefix for automatically created config elements. */
++  String AUTO_PREFIX = "".auto_"";
++
+ }","We use a suffix "".AUTOCREATED"" for configsets, maybe we can use the same here?"
+429,"@@ -27,7 +27,7 @@ namespace Samples
+         {
+             // Enable OpenTelemetry for the source ""MyCompany.MyProduct.MyWebServer""
+             // and use Console exporter
+-            OpenTelemetrySdk.Default.EnableOpenTelemetry(
++            OpenTelemetrySdk.EnableOpenTelemetry(
+                 (builder) => builder.AddActivitySource(""MyCompany.MyProduct.MyWebServer"")
+                 .UseConsoleActivityExporter(opt => opt.DisplayAsJson = options.DisplayAsJson));
+ ",This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?
+430,"@@ -37,7 +37,7 @@ from logHandler import log
+ import UIAUtils
+ from comInterfaces import UIAutomationClient as UIA
+ # F403: unable to detect undefined names
+-from comInterfaces .UIAutomationClient import *  # noqa:  F403
++from comInterfaces.UIAutomationClient import *  # noqa:  F403
+ import textInfos
+ from typing import Dict
+ from queue import Queue",Why this is in the diff?
+431,"@@ -136,6 +136,8 @@ type QuiesceDriver interface {
+ type CloudBackupDriver interface {
+ 	// CloudBackupCreate uploads snapshot of a volume to the cloud
+ 	CloudBackupCreate(input *api.CloudBackupCreateRequest) error
++	// CloudBackupGroupCreate creates and then uploads volumegroup snapshots
++	CloudBackupGroupCreate(input *api.CloudBackupGroupCreateRequest) error
+ 	// CloudBackupRestore downloads a cloud backup and restores it to a volume
+ 	CloudBackupRestore(input *api.CloudBackupRestoreRequest) (*api.CloudBackupRestoreResponse, error)
+ 	// CloudBackupEnumerate enumerates the backups for a given cluster/credential/volumeID",How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?
+432,"@@ -232,6 +232,15 @@ export function diff(
+
+ 		if ((tmp = options.diffed)) tmp(newVNode);
+ 	} catch (e) {
++		// When we are hydrating and have excessDomChildren we don't know the _children this VNode
++		// should receive so it's safer to unmount them. Else on the subsequent error-boundary diff,
++		// we won't know the oldDom and insert an additional node instead of replace the prerendered one. (#2539)
++		if (isHydrating && excessDomChildren != null) {
++			for (tmp = excessDomChildren.length; tmp--; ) {
++				if (excessDomChildren[tmp] != null) removeNode(excessDomChildren[tmp]);
++			}
++		}
++
+ 		newVNode._original = null;
+ 		options._catchError(e, newVNode, oldVNode);
+ 	}",We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better.
+433,"@@ -464,7 +464,7 @@ class CombineAssets
+      */
+     protected function setHashOnCombinerFilters($hash)
+     {
+-        $allFilters = call_user_func_array('array_merge', $this->getFilters());
++        $allFilters = array_merge(...array_values($this->getFilters()));
+
+         foreach ($allFilters as $filter) {
+             if (method_exists($filter, 'setHash')) {",In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc.
+434,"@@ -82,6 +82,9 @@ func (b3 B3) Extract(ctx context.Context, supplier propagation.HTTPSupplier) con
+ 	} else {
+ 		sc = b3.extract(supplier)
+ 	}
++	if !sc.IsValid() {
++		return ctx
++	}
+ 	return ContextWithRemoteSpanContext(ctx, sc)
+ }
+ ","If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?"
+435,"@@ -56,7 +56,7 @@ return [
+         'choose_file' => 'Datei auswählen',
+         'close' => 'Schließen',
+         'create' => 'Erstellen',
+-        'create_and_add_another' => 'Erstellen und weiter hinzufügen',
++        'create_and_add_another' => 'Erstellen und weitere hinzufügen',
+         'create_and_continue' => 'Erstellen und weiter bearbeiten',
+         'save' => 'Speichern',
+         'save_and_continue' => 'Speichern und weiter bearbeiten',",I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though
+436,"@@ -227,3 +227,12 @@ class RecordsViewTest(BaseWebTest, unittest.TestCase):
+                      MINIMALIST_RECORD,
+                      headers=headers,
+                      status=200)
++
++    def test_records_can_be_created_after_deletion(self):
++        self.app.delete(self.record_url,
++                        headers=self.headers,
++                        status=200)
++        headers = self.headers.copy()
++        headers['If-None-Match'] = '*'
++        self.app.put_json(self.record_url, MINIMALIST_RECORD,
++                          headers=headers, status=201)",nit: 200 is superfluous
+437,"@@ -246,7 +246,7 @@ TEST_F(SchemaTest, metaCommunication) {
+     // Test unreserved keyword
+     {
+         cpp2::ExecutionResponse resp;
+-        std::string query = ""CREATE TAG upper(name string, EMAIL string, ""
++        std::string query = ""CREATE TAG upper(name string, email string, ""
+                             ""age int, gender string, row_timestamp timestamp)"";
+         auto code = client->execute(query, resp);
+         ASSERT_EQ(cpp2::ErrorCode::SUCCEEDED, code);",This is testing `unreserved keyword`
+438,"@@ -829,6 +829,10 @@ static const MethodMapping projectionMethodMappings[] = {
+
+     {PROJ_WKT2_NAME_METHOD_QUADRILATERALIZED_SPHERICAL_CUBE, 0,
+      ""Quadrilateralized_Spherical_Cube"", ""qsc"", nullptr, paramsNatOrigin},
++
++    {PROJ_WKT2_NAME_METHOD_S2, 0,
++     ""S2"", ""s2"", nullptr, paramsNatOrigin},
++
+
+     {PROJ_WKT2_NAME_METHOD_SPHERICAL_CROSS_TRACK_HEIGHT, 0,
+      ""Spherical_Cross_Track_Height"", ""sch"", nullptr, paramsSch},",paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now
+439,"@@ -71,9 +71,15 @@ func makeKMD() KeyMetadata {
+ 	return emptyKeyMetadata{tlf.FakeID(0, tlf.Private), 1}
+ }
+
++func initBlockRetrievalQueueTest(t *testing.T) *blockRetrievalQueue {
++	q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))
++	<-q.TogglePrefetcher(false, nil)
++	return q
++}
++
+ func TestBlockRetrievalQueueBasic(t *testing.T) {
+ 	t.Log(""Add a block retrieval request to the queue and retrieve it."")
+-	q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))
++	q := initBlockRetrievalQueueTest(t)
+ 	require.NotNil(t, q)
+ 	defer q.Shutdown()
+ ","It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me."
+440,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[ListAccessKeys.java demonstrates how to list access keys associated with an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[ListAccessKeys.java demonstrates how to list access keys associated with an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+441,"@@ -34,6 +34,7 @@ class LoadProjectsCloudsqlPipeline(base_pipeline.BasePipeline):
+     """"""Pipeline to load project CloudSql data into Inventory.""""""
+
+     PROJECTS_RESOURCE_NAME = 'project_iam_policies'
++    RESOURCE_NAME = 'cloudsql'
+     RESOURCE_NAME_INSTANCES = 'cloudsql_instances'
+     RESOURCE_NAME_IPADDRESSES = 'cloudsql_ipaddresses'
+     RESOURCE_NAME_AUTHORIZEDNETWORKS = (  # pylint: disable=invalid-name","As a long term thing, would it make sense to move the resource names as keys under the requirements map?"
+442,"@@ -57,7 +57,7 @@ function traverseForHeaders(headerType, position, tableGrid) {
+  * @return {Array<HTMLTableCellElement>} Array of headers associated to the table cell
+  */
+ table.getHeaders = function(cell, tableGrid) {
+-	if (cell.hasAttribute('headers')) {
++	if (cell.getAttribute('headers')) {
+ 		return commons.dom.idrefs(cell, 'headers');
+ 	}
+ 	if (!tableGrid) {","That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers."
+443,"@@ -38,7 +38,9 @@ public class NoUnusedPinCheckTask extends DefaultTask {
+
+     @Input
+     public final Set<String> getResolvedArtifacts() {
+-        return BaselineVersions.getResolvedArtifacts(getProject());
++        return getProject().getAllprojects().stream()
++                .flatMap(project -> BaselineVersions.getResolvedArtifacts(project).stream())
++                .collect(Collectors.toSet());
+     }
+
+     @InputFile",I am pretty sure that this is infinite recursion as getAllProjects returns the project itself.
+444,"@@ -268,6 +268,7 @@ Blockly.Categories = {
+   ""sound"": ""sounds"",
+   ""pen"": ""pen"",
+   ""data"": ""data"",
++  ""dataLists"": ""data-lists"",
+   ""event"": ""events"",
+   ""control"": ""control"",
+   ""sensing"": ""sensing"",","Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should ""data-lists"" be ""data_lists""? @paulkaplan"
+445,"@@ -248,3 +248,7 @@ L2socket: use the provided L2socket
+
+ import scapy.sendrecv
+ scapy.sendrecv.sniff = sniff
++
++# If wpcap.dll is not available
++if (not conf.use_winpcapy) and (not conf.use_pcap) and (not conf.use_dnet):
++    from scapy.arch.windows.disable_sendrecv import *",Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`
+446,"@@ -23,6 +23,8 @@ class _Repository:
+         self.description = check.opt_str_param(description, ""description"")
+
+     def __call__(self, fn: Callable[[], Any]) -> RepositoryDefinition:
++        from dagster.core.asset_defs import ForeignAsset
++
+         check.callable_param(fn, ""fn"")
+
+         if not self.name:",we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them.
+447,"@@ -14,8 +14,7 @@ TempDir::TempDir(const char* pathTemplate, bool deleteOnDestroy)
+         : deleteOnDestroy_(deleteOnDestroy) {
+     auto len = strlen(pathTemplate);
+     std::unique_ptr<char[]> name(new char[len + 1]);
+-    strncpy(name.get(), pathTemplate, len);
+-    name.get()[len] = '\0';
++    strcpy(name.get(), pathTemplate);
+
+     VLOG(2) << ""Trying to create the temp directory with pattern \""""
+             << name.get() << ""\"""";","`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though."
+448,"@@ -36,7 +36,7 @@ const (
+
+ // ErrSharedConfigSourceCollision will be returned if a section contains both
+ // source_profile and credential_source
+-var ErrSharedConfigSourceCollision = awserr.New(ErrCodeSharedConfig, ""only source profile or credential source can be specified, not both"", nil)
++var ErrSharedConfigSourceCollision = awserr.New(ErrCodeSharedConfig, ""only one credential type may be specified per profile: source profile, credential source, credential process, web identity token, or sso"", nil)
+
+ // ErrSharedConfigECSContainerEnvVarEmpty will be returned if the environment
+ // variables are empty and Environment was set as the credential source","Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed."
+449,"@@ -3,6 +3,7 @@
+ var f = require('util').format;
+ var test = require('./shared').assert;
+ var setupDatabase = require('./shared').setupDatabase;
++const { ReadPreference } = require('../..');
+ const Db = require('../../lib/db');
+ const expect = require('chai').expect;
+ ",The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles
+450,"@@ -10,8 +10,9 @@ from ..registry import PIPELINES
+ @PIPELINES.register_module
+ class LoadImageFromFile(object):
+
+-    def __init__(self, to_float32=False):
++    def __init__(self, to_float32=False, color_type='color'):
+         self.to_float32 = to_float32
++        self.color_type = color_type
+
+     def __call__(self, results):
+         if results['img_prefix'] is not None:",I suggest expanding dims here to simplify the formatting.
+451,"@@ -9,7 +9,7 @@ from pyramid.paster import bootstrap
+
+ from kinto.config import init
+
+-CONFIG_FILE = 'config/kinto.ini'
++CONFIG_FILE = 'kinto/config/kinto.ini'
+
+
+ def main(args=None):",Why do you need to specify the kinto prefix here?
+452,"@@ -45,7 +45,7 @@ class FPN(nn.Module):
+         >>> self = FPN(in_channels, 11, len(in_channels)).eval()
+         >>> outputs = self.forward(inputs)
+         >>> for i in range(len(outputs)):
+-        ...     print('outputs[{}].shape = {!r}'.format(i, outputs[i].shape))
++        ...     print(f'outputs[{i}].shape = {outputs[i].shape!r}')
+         outputs[0].shape = torch.Size([1, 11, 340, 340])
+         outputs[1].shape = torch.Size([1, 11, 170, 170])
+         outputs[2].shape = torch.Size([1, 11, 84, 84])",The `!r` is unnecessary.
+453,"@@ -161,7 +161,7 @@ func (o *lazyCredsOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.
+
+ 		isMSIEnvironment := adal.MSIAvailable(ctx, adal.CreateSender())
+
+-		if accountKey != """" {
++		if accountKey != """" || sasToken != """" {
+ 			o.opener, o.err = openerFromEnv(accountName, accountKey, sasToken, storageDomain, protocol)
+ 		} else if isMSIEnvironment {
+ 			o.opener, o.err = openerFromMSI(accountName, storageDomain, protocol)",I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls.
+454,"@@ -21,6 +21,8 @@ namespace AutoRest.Go.TemplateModels
+         // (null or empty if the model is not paged).
+         public string NextLink;
+
++        public bool PreparerNeeded;
++
+         public ModelTemplateModel(CompositeType source)
+         {
+             this.LoadFrom(source);",Should we default to `true` ?
+455,"@@ -15,6 +15,7 @@ import (
+ 	uconfig ""go.uber.org/config""
+
+ 	""github.com/iotexproject/iotex-core/address""
++	""github.com/iotexproject/iotex-core/consensus/fsm""
+ 	""github.com/iotexproject/iotex-core/crypto""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ )",File is not `goimports`-ed (from `goimports`)
+456,"@@ -54,11 +54,14 @@ const rules = [
+ 		use: [
+ 			{
+ 				loader: 'babel-loader',
+-				query: {
+-					presets: [ [ '@babel/env', {
+-						useBuiltIns: 'entry',
+-						corejs: 2,
+-					} ], '@babel/preset-react' ],
++				options: {
++					babelrc: false,
++					configFile: false,
++					cacheDirectory: true,
++					presets: [
++						'@wordpress/default',
++						'@babel/preset-react',
++					],
+ 				},
+ 			},
+ 			{","Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise."
+457,"@@ -1609,7 +1609,7 @@ func (wn *WebsocketNetwork) removePeer(peer *wsPeer, reason disconnectReason) {
+ 	// first logging, then take the lock and do the actual accounting.
+ 	// definitely don't change this to do the logging while holding the lock.
+ 	localAddr, _ := wn.Address()
+-	wn.log.With(""event"", ""Disconnected"").With(""remote"", peer.rootURL).With(""local"", localAddr).Infof(""Peer %v disconnected"", peer.rootURL)
++	wn.log.With(""event"", ""Disconnected"").With(""remote"", peer.rootURL).With(""local"", localAddr).Infof(""Peer %v disconnected: %v"", peer.rootURL, reason)
+ 	peerAddr := peer.OriginAddress()
+ 	// we might be able to get addr out of conn, or it might be closed
+ 	if peerAddr == """" && peer.conn != nil {",Nit: We can use `%s` since `disconnectReason` is a string.
+458,"@@ -17,7 +17,8 @@ X_test = df_test.drop(0, axis=1).values
+
+ print('Start training...')
+ # train
+-gbm = lgb.LGBMRegressor(objective='regression',
++gbm = lgb.LGBMRegressor(boosting_type='rgf',
++                        objective='regression',
+                         num_leaves=31,
+                         learning_rate=0.05,
+                         n_estimators=20)",I think it's better to create a new example
+459,"@@ -392,7 +392,7 @@ void ResolveOperation(Action &action, const RENDER_PASS_STATE &rp_state, const V
+
+         if (aspect_mask) {
+             action(aspect_string, ""resolve read"", src_at, dst_at, attachment_views[src_at],
+-                   SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_READ, kDepthStencilAttachmentRasterOrder, offset, extent,
++                   SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_READ, kAttachmentRasterOrder, offset, extent,
+                    aspect_mask);
+             action(aspect_string, ""resolve write"", src_at, dst_at, attachment_views[dst_at],
+                    SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_WRITE, kAttachmentRasterOrder, offset, extent, aspect_mask);","The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers."
+460,"@@ -64,7 +64,7 @@ class AcidBasePair(object):
+ #: Administration Substance Registration System Standard Operating Procedure guide.
+ ACID_BASE_PAIRS = (
+     AcidBasePair('-OSO3H', 'OS(=O)(=O)[OH]', 'OS(=O)(=O)[O-]'),
+-    AcidBasePair('–SO3H', '[!O]S(=O)(=O)[OH]', '[!O]S(=O)(=O)[O-]'),
++    AcidBasePair('--SO3H', '[!O]S(=O)(=O)[OH]', '[!O]S(=O)(=O)[O-]'),
+     AcidBasePair('-OSO2H', 'O[SD3](=O)[OH]', 'O[SD3](=O)[O-]'),
+     AcidBasePair('-SO2H', '[!O][SD3](=O)[OH]', '[!O][SD3](=O)[O-]'),
+     AcidBasePair('-OPO3H2', 'OP(=O)([OH])[OH]', 'OP(=O)([OH])[O-]'),","To be consistent, I think it should actually just be a single `-`"
+461,"@@ -6,6 +6,7 @@ import yaml
+
+ from datetime import datetime
+ from listenbrainz.utils import escape, convert_to_unix_timestamp
++from flask import current_app
+
+ def flatten_dict(d, seperator='', parent_key=''):
+     """"""",this seems extraneous.
+462,"@@ -795,7 +795,7 @@ func (s *Suite) Define() {
+ 			By(""Sanity-check the issued Certificate"")
+ 			err = f.Helper().ValidateCertificate(f.Namespace.Name, ""testcert"", validations...)
+ 			Expect(err).NotTo(HaveOccurred())
+-		}, featureset.OnlySAN)
++		}, featureset.OnlySAN, featureset.LongDomainFeatureSet)
+
+ 		s.it(f, ""should allow updating an existing certificate with a new DNS Name"", func(issuerRef cmmeta.ObjectReference) {
+ 			testCertificate := &cmapi.Certificate{","Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this?   if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible"
+463,"@@ -112,12 +112,13 @@ module Travis
+                   'cdbs qpdf texinfo libssh2-1-dev devscripts '\
+                   ""#{optional_apt_pkgs}"", retry: true
+
+-                r_filename = ""R-#{r_version}-$(lsb_release -cs).xz""
+-                r_url = ""https://travis-ci.rstudio.org/#{r_filename}""
++                r_filename = ""r-#{r_version}_1_amd64.deb""
++                os_version = ""$(lsb_release -rs | tr -d '.')""
++                r_url = ""https://cdn.rstudio.com/r/ubuntu-#{os_version}/pkgs/#{r_filename}""
+                 sh.cmd ""curl -fLo /tmp/#{r_filename} #{r_url}"", retry: true
+-                sh.cmd ""tar xJf /tmp/#{r_filename} -C ~""
+-                sh.export 'PATH', ""${TRAVIS_HOME}/R-bin/bin:$PATH"", echo: false
+-                sh.export 'LD_LIBRARY_PATH', ""${TRAVIS_HOME}/R-bin/lib:$LD_LIBRARY_PATH"", echo: false
++                sh.cmd ""sudo apt-get install gdebi-core""
++                sh.cmd ""sudo gdebi r-#{r_version}_1_amd64.deb""
++                sh.export 'PATH', ""/opt/R/#{r_version}/bin:$PATH"", echo: false
+                 sh.rm ""/tmp/#{r_filename}""
+
+                 sh.cmd ""sudo mkdir -p /usr/local/lib/R/site-library $R_LIBS_USER""",I think you need `-y` here to prevent a user confirmation prompt
+464,"@@ -100,6 +100,7 @@ bool dynamo_heap_initialized = false;
+ bool dynamo_started = false;
+ bool automatic_startup = false;
+ bool control_all_threads = false;
++bool dynamo_avx512_code_in_use = false;
+ #ifdef WINDOWS
+ bool dr_early_injected = false;
+ int dr_early_injected_location = INJECT_LOCATION_Invalid;","Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above."
+465,"@@ -55,8 +55,11 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister):
+     """"""
+     MIRRORS_SOURCE = ""https://archive.apache.org/dist/jmeter/binaries/""
+     JMETER_DOWNLOAD_LINK = ""https://archive.apache.org/dist/jmeter/binaries/apache-jmeter-{version}.zip""
++    PLUGINS_MANAGER = 'https://repo1.maven.org/maven2/kg/apc/jmeter-plugins-manager/0.8/jmeter-plugins-manager-0.8.jar'
++    CMDRUNNER = 'http://search.maven.org/remotecontent?filepath=kg/apc/cmdrunner/2.0/cmdrunner-2.0.jar'
++    PLUGINS = [""jpgc-casutg"", ""jpgc-dummy"", ""jpgc-ffw"", ""jpgc-fifo"", ""jpgc-functions"",
++               ""jpgc-json"", ""jpgc-perfmon"", ""jpgc-prmctl"", ""jpgc-tst""]
+     JMETER_VER = ""3.0""
+-    PLUGINS_DOWNLOAD_TPL = ""http://jmeter-plugins.org/files/JMeterPlugins-{plugin}-1.4.0.zip""
+     UDP_PORT_NUMBER = None
+
+     def __init__(self):","right URL is like in cmdrunner, using search.maven .org"
+466,"@@ -32,9 +32,9 @@ namespace OpenTelemetry.Exporter
+ #if NETSTANDARD2_1
+         /// <summary>
+         /// Gets or sets the target to which the exporter is going to send traces or metrics.
+-        /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md.
++        /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md. The endpoint value should start with http or https.
+         /// </summary>
+-        public Uri Endpoint { get; set; } = new Uri(""http://localhost:4317"");
++        public string Endpoint { get; set; } = ""http://localhost:4317"";
+ #else
+         /// <summary>
+         /// Gets or sets the target to which the exporter is going to send traces or metrics.","The link to valid syntax is not really applicable for NET2_1, right?"
+467,"@@ -16,6 +16,13 @@
+ // PubSub. Use OpenTopic to construct a *pubsub.Topic, and/or OpenSubscription
+ // to construct a *pubsub.Subscription.
+ //
++// Escaping
++//
++// Go CDK supports all UTF-8 strings; some strings are escaped (during writes)
++// and unescaped (during reads) to ensure compatibility with the provider:
++//  - Metadata keys: No escaping required.
++//  - Metadata values: No escaping required.
++//
+ // As
+ //
+ // gcspubsub exposes the following types for As:","Shouldn't it be more specific, like ""gcppubsub supports all UTF-8 strings""?"
+468,"@@ -59,14 +59,14 @@ public class CdcrReplicationHandlerTest extends BaseCdcrDistributedZkTest {
+   }
+
+   /**
+-   * Test the scenario where the slave is killed from the start. The replication
++   * Test the scenario where the secondary is killed from the start. The replication
+    * strategy should fetch all the missing tlog files from the leader.
+    */
+   @Test
+   @ShardsFixed(num = 2)
+   public void testFullReplication() throws Exception {
+-    List<CloudJettyRunner> slaves = this.getShardToSlaveJetty(SOURCE_COLLECTION, SHARD1);
+-    slaves.get(0).jetty.stop();
++    List<CloudJettyRunner> secondaries = this.getShardToSecondaryJetty(SOURCE_COLLECTION, SHARD1);
++    secondaries.get(0).jetty.stop();
+
+     for (int i = 0; i < 10; i++) {
+       List<SolrInputDocument> docs = new ArrayList<>();","Everything in this class is SolrCloud-related, not legacy replication"
+469,"@@ -1122,15 +1122,8 @@ drbbdup_prepare_redirect(dr_mcontext_t *mcontext, drbbdup_manager_t *manager,
+ {
+     /* Restore flags and scratch reg to their original app values. */
+     if (!manager->are_flags_dead) {
+-        reg_t val;
+-        uint sahf;
+-        reg_t newval = mcontext->xflags;
+-        val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT);
+-        sahf = (val & 0xff00) >> 8;
+-        newval &= ~(EFLAGS_ARITH);
+-        newval |= sahf;
+-        if (TEST(1, val)) /* seto */
+-            newval |= EFLAGS_OF;
++        reg_t val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT);
++        reg_t newval = dr_merge_arith_flags(mcontext->xflags, val);
+         mcontext->xflags = newval;
+     }
+     if (!manager->is_scratch_reg_dead) {",Could just assign directly and eliminate the `newval` var.
+470,"@@ -27,11 +27,13 @@ import (
+ const (
+ 	inProgressLabel            = ""in progress""
+ 	issueTitleComment          = ""Please edit the title of this issue with the name of the affected package, followed by a colon, followed by a short summary of the issue. Example: `blob/gcsblob: not blobby enough`.""
++	pullRequestTitleComment    = ""Please edit the title of this pull request with the name of the affected package, followed by a colon, followed by a short summary of the change. Example: `blob/gcsblob: improve comments`.""
+ 	branchesInForkCloseComment = ""Please create pull requests from your own fork instead of from branches in the main repository. Also, please delete this branch.""
+ )
+
+ var (
+-	issueTitleRegexp = regexp.MustCompile(""^[a-z0-9/]+: .*$"")
++	issueTitleRegexp       = regexp.MustCompile(""^[a-z0-9/]+: .*$"")
++	pullRequestTitleRegexp = issueTitleRegexp
+ )
+
+ // issueData is information about an issue event.","... with the name of the affected package, or ""all"", followed by a colon,..."
+471,"@@ -48,6 +48,10 @@ namespace PrepareRelease
+                 ""src/Datadog.Trace.ClrProfiler.Managed/Datadog.Trace.ClrProfiler.Managed.csproj"",
+                 NugetVersionReplace);
+
++            SynchronizeVersion(
++                ""src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj"",
++                NugetVersionReplace);
++
+             SynchronizeVersion(
+                 ""src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt"",
+                 text => FullVersionReplace(text, "".""));",We'll want to remove this one if we make the assembly version constant.
+472,"@@ -51,6 +51,7 @@ class Frontend extends Generator {
+ 		$this->setup_blog_colors();
+ 		$this->setup_form_fields_style();
+ 		$this->setup_single_post_style();
++		$this->setup_single_page_style();
+ 	}
+
+ 	/**",Can we have a single function here that uses the same subscribers and just changes meta based on context?
+473,"@@ -513,8 +513,9 @@ hsa_executable_t load_executable(const string& file, hsa_executable_t executable
+     return executable;
+ }
+
+-// To force HIP to load the kernels and to setup the function
+-// symbol map on program startup
++// HIP startup kernel loader logic
++// When enabled HIP_STARTUP_LOADER, HIP will load the kernels and setup
++// the function symbol map on program startup
+ class startup_kernel_loader {
+    private:
+     startup_kernel_loader() { functions(); }",where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?
+474,"@@ -0,0 +1,14 @@
++const webkitGetAsEntryApi = require('./utils/webkitGetAsEntryApi')
++const getFilesAndDirectoriesApi = require('./utils/getFilesAndDirectoriesApi')
++const fallbackApi = require('./utils/fallbackApi')
++
++module.exports = function getDroppedFiles (dataTransfer, callback) {
++  if (dataTransfer.items[0] && 'webkitGetAsEntry' in dataTransfer.items[0]) {
++    webkitGetAsEntryApi(dataTransfer, callback)
++  } else if ('getFilesAndDirectories' in dataTransfer) {
++    // Doesn't actually work in firefox, maybe in previous versions. webkitGetAsEntryApi() works.
++    getFilesAndDirectoriesApi(dataTransfer, callback)
++  } else {
++    fallbackApi(dataTransfer, callback)
++  }
++}","I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module."
+475,"@@ -732,12 +732,6 @@ func (m *Volume) Contains(mid string) bool {
+ // Copy makes a deep copy of VolumeSpec
+ func (s *VolumeSpec) Copy() *VolumeSpec {
+ 	spec := *s
+-	if s.VolumeLabels != nil {
+-		spec.VolumeLabels = make(map[string]string)
+-		for k, v := range s.VolumeLabels {
+-			spec.VolumeLabels[k] = v
+-		}
+-	}
+ 	if s.ReplicaSet != nil {
+ 		spec.ReplicaSet = &ReplicaSet{Nodes: make([]string, len(s.ReplicaSet.Nodes))}
+ 		copy(spec.ReplicaSet.Nodes, s.ReplicaSet.Nodes)",Migrate the spec.Labels to locator.Labels ?
+476,"@@ -250,7 +250,7 @@ func TestS3_EmptyBucket(t *testing.T) {
+
+ 			gotErr := service.EmptyBucket(tc.inBucket)
+
+-			if gotErr != nil {
++			if tc.wantErr != nil {
+ 				require.EqualError(t, gotErr, tc.wantErr.Error())
+ 			}
+ 		})",The test case already existed but it never tested properly because of the conditional in the test.
+477,"@@ -68,11 +68,9 @@ public class PartitionField implements Serializable {
+     }
+
+     PartitionField that = (PartitionField) other;
+-    return (
+-        sourceId == that.sourceId &&
++    return sourceId == that.sourceId &&
+         name.equals(that.name) &&
+-        transform.equals(that.transform)
+-    );
++        transform.equals(that.transform);
+   }
+
+   @Override","I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them."
+478,"@@ -138,7 +138,7 @@ public class IndexSchema {
+
+   protected List<SchemaField> fieldsWithDefaultValue = new ArrayList<>();
+   protected Collection<SchemaField> requiredFields = new HashSet<>();
+-  protected volatile DynamicField[] dynamicFields;
++  protected DynamicField[] dynamicFields = new DynamicField[] {};
+   public DynamicField[] getDynamicFields() { return dynamicFields; }
+
+   protected Map<String, SchemaField> dynamicFieldCache = new ConcurrentHashMap<>();",@sarowe why was this volatile? It's fishy to see this as the only volatile field.
+479,"@@ -0,0 +1,13 @@
++package org.apache.servicecomb.serviceregistry.task.event;
++
++/**
++ * 一句话功能简述
++ * 功能详细描述
++ * @author m00416667
++ * @version [版本号, ]
++ * @see  [相关类/方法]
++ * @since [产品/模块版本]
++ * Package Name:org.apache.servicecomb.serviceregistry.task.event
++ */
++public class InstanceRegistryFailedEvent {
++}",template is not correct?
+480,"@@ -0,0 +1,4 @@
++from mmdet.utils import Registry
++
++ASSIGNERS = Registry('assigner')
++SAMPLERS = Registry('sampler')",Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler.
+481,"@@ -89,9 +89,7 @@ module Beaker
+     describe ""provisioning and cleanup"" do
+
+       before :each do
+-        vagrant.should_receive( :make_vfile ).with( @hosts ).once
+-
+-        vagrant.should_receive( :vagrant_cmd ).with( ""destroy --force"" ).once
++        FakeFS.activate!
+         vagrant.should_receive( :vagrant_cmd ).with( ""up"" ).once
+         @hosts.each do |host|
+           host_prev_name = host['user']","This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters."
+482,"@@ -188,6 +188,11 @@ module BoltServer
+       [200, GC.stat.to_json]
+     end
+
++    get '/admin/status' do
++      stats = Puma.stats
++      [200, stats.is_a?(Hash) ? stats.to_json : stats]
++    end
++
+     get '/500_error' do
+       raise 'Unexpected error'
+     end",This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this.
+483,"@@ -5902,6 +5902,7 @@ os_forge_exception(app_pc target_pc, dr_exception_type_t type)
+     switch (type) {
+     case ILLEGAL_INSTRUCTION_EXCEPTION: sig = SIGILL; break;
+     case UNREADABLE_MEMORY_EXECUTION_EXCEPTION: sig = SIGSEGV; break;
++    case SINGLE_STEP_EXCEPTION: ASSERT_NOT_IMPLEMENTED(false); /* cf i#2144 */
+     case IN_PAGE_ERROR_EXCEPTION: /* fall-through: Windows only */
+     default: ASSERT_NOT_REACHED(); sig = SIGSEGV; break;
+     }","Convention is ""FIXME: i#2144"" or ""XXX: i#2144"""
+484,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface IHasHttpMethod
++    {
++        string GetHttpMethod();
++    }
++}",This should probably be a property instead of a method.
+485,"@@ -159,10 +159,12 @@ spec:
+     status:
+       phase: Init
+     versionDetails:
+-      current: {{ .CAST.version }}
++      status:
++        current: {{ .CAST.version }}
++        dependentsUpgraded: true
++        state: RECONCILED
+       desired: {{ .CAST.version }}
+       autoUpgrade: false
+-      dependentsUpgraded: true
+ ---
+ apiVersion: openebs.io/v1alpha1
+ kind: RunTask","do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions."
+486,"@@ -3,7 +3,11 @@ module Blacklight::Solr
+     extend ActiveSupport::Concern
+
+     included do
+-      self.default_processor_chain = [:default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr, :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr, :add_sorting_to_solr, :add_group_config_to_solr ]
++      self.default_processor_chain = [
++        :default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr,
++        :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr,
++        :add_sorting_to_solr, :add_group_config_to_solr, :add_facet_paging_to_solr
++      ]
+     end
+
+     ####",Line is too long. [82/80]
+487,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel
+ {
+     using System;",Add blank line below license header.
+488,"@@ -110,9 +110,17 @@ public abstract class BaseMetastoreCatalog implements Catalog {
+       throw new NoSuchTableException(""No such table: "" + identifier);
+     }
+
+-    String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
+     Map<String, String> tableProperties = properties != null ? properties : Maps.newHashMap();
+-    TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
++
++    TableMetadata metadata;
++    if (ops.current() != null) {
++      String baseLocation = location != null ? location : ops.current().location();
++      metadata = ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);
++    } else {
++      String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
++      metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
++    }
++
+     if (orCreate) {
+       return Transactions.createOrReplaceTableTransaction(identifier.toString(), ops, metadata);
+     } else {","I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider."
+489,"@@ -37,8 +37,10 @@ import (
+ 	executionpb ""go.temporal.io/temporal-proto/execution""
+ 	tasklistpb ""go.temporal.io/temporal-proto/tasklist""
+
++	executionproto ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	""github.com/temporalio/temporal/.gen/proto/persistenceblobs""
+ 	replicationgenpb ""github.com/temporalio/temporal/.gen/proto/replication""
++
+ 	""github.com/temporalio/temporal/common""
+ 	""github.com/temporalio/temporal/common/checksum""
+ 	""github.com/temporalio/temporal/common/persistence/serialization""",Just run a global replacement for all `executionproto`.
+490,"@@ -111,7 +111,7 @@ class WebDriver(object):
+
+     def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
+                  desired_capabilities=None, browser_profile=None, proxy=None,
+-                 keep_alive=False, file_detector=None):
++                 keep_alive=False, file_detector=None, options=None):
+         """"""
+         Create a new driver that will issue commands using the wire protocol.
+ ",@AutomatedTester @davehunt thoughts on a new keyword argument?
+491,"@@ -49,6 +49,9 @@ fpga_result opae_ioctl(int fd, int request, ...)
+ 		case EINVAL:
+ 			res = FPGA_INVALID_PARAM;
+ 			break;
++		case ENOTSUP:
++			res = FPGA_NOT_SUPPORTED;
++			break;
+ 		default:
+ 			// other errors could be
+ 			// EBADF - fd is bad file descriptor",Should line 47 be OPAE_ERR?
+492,"@@ -104,6 +104,8 @@ import (
+ 	""gocloud.dev/pubsub/driver""
+ )
+
++var zeroTime time.Time
++
+ // Message contains data to be published.
+ type Message struct {
+ 	// Body contains the content of the message.","Not necessary, just write `time.Time{}`"
+493,"@@ -499,6 +499,11 @@ def data(readonly=False):
+              SettingValue(typ.Bool(), 'true'),
+              ""Whether to show favicons in the tab bar.""),
+
++            ('tabbar-size',
++             SettingValue(typ.Int(minval=8), '12'),
++             ""The height of the tabbar in pixels.""
++             ""This also controls the size of the favicons.""),
++
+             ('width',
+              SettingValue(typ.PercOrInt(minperc=0, maxperc=100, minint=1),
+                           '20%'),","As these two strings simply get concatenated for the docs, there's a space missing after the dot here."
+494,"@@ -29,6 +29,7 @@ namespace Datadog.Trace.ClrProfiler.CallTarget
+         {
+             if (IntegrationOptions<TIntegration, TTarget>.IsIntegrationEnabled)
+             {
++                IntegrationOptions<TIntegration, TTarget>.RecordTelemetry();
+                 return BeginMethodHandler<TIntegration, TTarget>.Invoke(instance);
+             }
+ ",What about integrations where we don't plug ourselved on OnMethodBegin?
+495,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?
+496,"@@ -18,12 +18,15 @@ import com.google.api.codegen.SnippetSetRunner;
+ import com.google.api.codegen.viewmodel.FileHeaderView;
+ import com.google.api.codegen.viewmodel.ViewModel;
+ import com.google.api.codegen.viewmodel.testing.MockServiceImplView.Builder;
++import com.google.api.tools.framework.model.Interface;
+ import com.google.auto.value.AutoValue;
+ import java.util.List;
+
+ @AutoValue
+ public abstract class GapicSurfaceTestClassView implements ViewModel {
+
++  public abstract Interface service();
++
+   public abstract FileHeaderView fileHeader();
+
+   public abstract String name();",ViewModel classes should not expose any classes from framework.model.
+497,"@@ -135,9 +135,6 @@ def test_single_required_string_field_config_type():
+     assert _validate(_single_required_string_config_dict(), {'string_field': 'value'}) == {
+         'string_field': 'value'
+     }
+-    assert _validate(_single_required_string_config_dict(), {'string_field': None}) == {
+-        'string_field': None
+-    }
+
+     with pytest.raises(DagsterEvaluateConfigValueError):
+         _validate(_single_required_string_config_dict(), {})",how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?
+498,"@@ -21,10 +21,11 @@ test_name ""bolt plan run should apply manifest block on remote hosts via winrm""
+     scp_to(bolt, File.join(fixtures, 'example_apply'), ""#{dir}/modules/example_apply"")
+   end
+
+-  bolt_command = ""bolt plan run example_apply filepath=#{filepath} nodes=winrm_nodes""
++  bolt_command = ""bolt plan run example_apply filepath=#{filepath}""
+   flags = {
+     '--modulepath' => modulepath(File.join(dir, 'modules')),
+-    '--format' => 'json'
++    '--format' => 'json',
++    '-t' => ""winrm_nodes""
+   }
+
+   teardown do","Why do we use the `winrm_nodes` variable here and not the string `""winrm_nodes""` as we were using before?"
+499,"@@ -1,4 +1,4 @@
+-/* Copyright (c) 2018 vesoft inc. All rights reserved.
++/* Copyright (c) 2019 vesoft inc. All rights reserved.
+  *
+  * This source code is licensed under Apache 2.0 License,
+  * attached with Common Clause Condition 1.0, found in the LICENSES directory.",why update Copyright ?
+500,"@@ -7469,7 +7469,14 @@ RelExpr *Scan::bindNode(BindWA *bindWA)
+      bindWA->setErrStatus();
+      return NULL;
+   }
+-
++  if (naTable->hasLobColumn() && isSampleScan())
++    {
++      *CmpCommon::diags() << DgSqlCode(-4322)
++       << DgTableName(
++           naTable->getTableName().getQualifiedNameAsAnsiString());
++     bindWA->setErrStatus();
++     return NULL;
++    }
+   // restricted partitions for HBase table
+   if (naTable->isHbaseTable() &&
+       (naTable->isPartitionNameSpecified() ||",Does this mean we cannot update statistics with sampling on a table with LOB columns?
+501,"@@ -47,7 +47,18 @@ namespace NLog.LayoutRenderers.Wrappers
+     [ThreadAgnostic]
+     public sealed class CachedLayoutRendererWrapper : WrapperLayoutRendererBase
+     {
+-        private string cachedValue;
++        /// <summary>
++        /// A value indicating when the cache is cleared.
++        /// </summary>
++        public enum ClearCacheOption
++        {
++            /// <summary>Never clear the cache.</summary>
++            Never = 0,
++            /// <summary>Clear the cache whenever the <see cref=""CachedLayoutRendererWrapper""/> is initialized.</summary>
++            OnInitialize = 1
++        }
++
++        private string cachedValue = null;
+
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""CachedLayoutRendererWrapper""/> class.","Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?"
+502,"@@ -1577,6 +1577,16 @@
+       require: '^uiGrid',
+       link: function($scope, $elm, $attrs, uiGridCtrl) {
+         var self = uiGridCtrl.grid;
++        $scope.treeButtonClass = function(row) {
++          if ( ( self.options.showTreeExpandNoChildren && row.treeLevel > -1 ) || ( row.treeNode.children && row.treeNode.children.length > 0 ) ) {
++            if (row.treeNode.state === 'expanded' ) {
++              return 'ui-grid-icon-minus-squared';
++            }
++            if (row.treeNode.state === 'collapsed' ) {
++              return 'ui-grid-icon-plus-squared';
++            }
++          }
++        };
+         $scope.treeButtonClick = function(row, evt) {
+           evt.stopPropagation();
+           uiGridTreeBaseService.toggleRowTreeState(self, row, evt);","Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `"
+503,"@@ -32,10 +32,6 @@ import org.apache.solr.common.SolrException;
+  * Solr endpoints for SolrCloud collections, and then use the
+  * {@link LBHttp2SolrClient} to issue requests.
+  *
+- * This class assumes the id field for your documents is called
+- * 'id' - if this is not the case, you must set the right name
+- * with {@link #setIdField(String)}.
+- *
+  * @lucene.experimental
+  * @since solr 8.0
+  */","the latter part can go but isn't the first part of this still sound -- that we assume ""id""?"
+504,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return '\'' + value + '\'';
+ 	} else {
+-		return '""""';
++		return '\'\'';
+ 	}
+ }
+ ",Why is the escaping of @ and $ removed?
+505,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface IHasHttpUrl
++    {
++        string GetRawUrl();
++    }
++}",Nit: `Http` is redundant in this interface's name.
+506,"@@ -82,6 +82,19 @@ func NewCluster(ctx context.Context, cfg *ClusterConfig, creds credentials.Trans
+ 	if err != nil {
+ 		return nil, nil, err
+ 	}
++
++	exists, err := store.Exists(cfg.SynchronizableEntitiesPrefix)
++	if err != nil {
++		return nil, nil, fmt.Errorf(""failed to check if SynchronizableEntitiesPrefix exists: %s"", err)
++	}
++
++	if !exists {
++		err = store.Put(cfg.SynchronizableEntitiesPrefix, []byte{}, nil)
++		if err != nil {
++			return nil, nil, err
++		}
++	}
++
+ 	endpoints, err := parseEndpoints(cfg)
+ 	if err != nil {
+ 		return nil, nil, err","what if I set SynchronizableEntitiesPrefix to ""a/b/c/d"" in config?"
+507,"@@ -83,9 +83,13 @@ func (opts *InitAppOpts) Validate() error {
+ 		}
+ 	}
+ 	if opts.DockerfilePath != """" {
+-		if _, err := listDockerfiles(opts.fs, opts.DockerfilePath); err != nil {
++		isDir, err := afero.IsDir(opts.fs, opts.DockerfilePath)
++		if err != nil {
+ 			return err
+ 		}
++		if isDir {
++			return fmt.Errorf(""dockerfile path expected, got %s"", opts.DockerfilePath)
++		}
+ 	}
+ 	if opts.ProjectName() == """" {
+ 		return errNoProjectInWorkspace","nit: This error message doesn't mention that the path is a directory, maybe ""Dockerfile path is a directory:%s, please provide path to file."""
+508,"@@ -26,6 +26,7 @@
+ # Copyright (c) 2020 Anthony <tanant@users.noreply.github.com>
+ # Copyright (c) 2021 Marc Mueller <30130371+cdce8p@users.noreply.github.com>
+ # Copyright (c) 2021 Peter Kolbus <peter.kolbus@garmin.com>
++# Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com>
+
+
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html","This is done automatically, you can skip it next time ;)"
+509,"@@ -128,6 +128,14 @@ class WebKitElement(webelem.AbstractWebElement):
+             value = javascript.string_escape(value)
+             self._elem.evaluateJavaScript(""this.value='{}'"".format(value))
+
++    def dispatch_event(self, event):
++        self._check_vanished()
++        if self._tab.is_deleted():
++            raise webelem.OrphanedError(""Tab containing element vanished"")
++        log.webelem.debug(""Firing event on {!r} via javascript."".format(self))
++        self._elem.evaluateJavaScript(""this.dispatchEvent(new Event('{}'))""
++                                      .format(event))
++
+     def caret_position(self):
+         """"""Get the text caret position for the current element.""""""
+         self._check_vanished()","This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?"
+510,"@@ -53,6 +53,10 @@ type agentConfig struct {
+
+ 	ConfigPath string
+ 	Umask      string `hcl:""umask""`
++
++	ProfilingEnabled string `hcl:""profiling_enabled""`
++	ProfilingPort    string `hcl:""profiling_port""`
++	ProfilingFreq    string `hcl:""profiling_freq""`
+ }
+
+ type RunCLI struct {","Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?"
+511,"@@ -22,6 +22,7 @@ module Beaker
+       #HACK HACK HACK - add checks here to ensure that we have box + box_url
+       #generate the VagrantFile
+       v_file = ""Vagrant.configure(\""2\"") do |c|\n""
++      v_file << ""  c.ssh.forward_agent = true\n"" unless options['forward_ssh_agent'].nil?
+       hosts.each do |host|
+         host['ip'] ||= randip #use the existing ip, otherwise default to a random ip
+         v_file << ""  c.vm.define '#{host.name}' do |v|\n""",This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set.
+512,"@@ -521,7 +521,7 @@ func TestVoteTrackerFiltersDuplicateVoteOnce(t *testing.T) {
+ 			inputVotes[i] = helper.MakeValidVoteAcceptedVal(t, i, next, Val1)
+ 			expectedOutputs[i] = thresholdEvent{T: none}
+ 		case i == Num:
+-			inputVotes[i] = voteFilterRequestEvent{RawVote: inputVotes[Num-1].(voteAcceptedEvent).Vote.R}
++			inputVotes[i] = voteFilterRequestEvent{RawVote: inputVotes[Num-1].(voteAcceptedEvent).Vote.R, Proto: protocol.ConsensusCurrentVersion}
+ 			expectedOutputs[i] = filteredStepEvent{T: voteFilteredStep}
+ 		}
+ 	}",We could avoid passing proto since threshold isn't needed.
+513,"@@ -1040,7 +1040,10 @@ func (di *Dependencies) AllowURLAccess(servers ...string) error {
+ 		return err
+ 	}
+
+-	if config.GetBool(config.FlagKeepConnectedOnFail) {
++	// Doesn't work as expected because some services share IP address with
++	// each other and with location oracle which is supposed to be routed
++	// through VPN tunnel.
++	if false && config.GetBool(config.FlagKeepConnectedOnFail) {
+ 		if err := router.AllowURLAccess(servers...); err != nil {
+ 			return err
+ 		}","This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded."
+514,"@@ -124,8 +124,8 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+   }
+   CHECK(status.ok()) << status.ToString();
+   db_.reset(db);
+-  partsNum_ = allParts().size();
+   extractorLen_ = sizeof(PartitionID) + vIdLen;
++  partsNum_ = allParts().size();
+   LOG(INFO) << ""open rocksdb on "" << path;
+
+   backup();",why can this modification avoid crash?
+515,"@@ -1,8 +1,7 @@
+ module RedirectIfDisabled
+   def redirect_if_disabled
+-    account = current_user
+-    return unless account && account.access.disabled?
+-    request.env[:clearance].sign_out
+-    redirect_to disabled_account_url(account)
++    return unless @account && @account.access.disabled?
++    request.env[:clearance].sign_out if @account.id == current_user.id
++    redirect_to disabled_account_url(@account)
+   end
+ end",This looks good -- signing out the user if the current user is disabled
+516,"@@ -47,13 +47,13 @@ class Selection {
+      */
+     this.selectedByCorner = false;
+     /**
+-     * The collection of the selection layer levels where the whole row was selected using the row header.
++     * The collection of the selection layer levels where the whole row was selected using the row header or the corner header.
+      *
+      * @type {Set.<number>}
+      */
+     this.selectedByRowHeader = new Set();
+     /**
+-     * The collection of the selection layer levels where the whole column was selected using the column header.
++     * The collection of the selection layer levels where the whole column was selected using the column header or the corner header.
+      *
+      * @type {Set.<number>}
+      */",The line exceeds 120 characters.
+517,"@@ -62,6 +62,11 @@ func renderAppDescribe(desc map[string]interface{}) (string, error) {
+ 	ddevapp.RenderAppRow(appTable, desc)
+ 	output = fmt.Sprint(appTable)
+
++	output = output + ""\n\nSite Information\n-----------------\n""
++	siteInfo := uitable.New()
++	siteInfo.AddRow(""PHP version:"", desc[""php_version""])
++	output = output + fmt.Sprint(siteInfo)
++
+ 	// Only show extended status for running sites.
+ 	if desc[""status""] == ddevapp.SiteRunning {
+ 		output = output + ""\n\nMySQL Credentials\n-----------------\n""","Let's go ahead and change ""Site"" to ""Project"", since that's the path we've chosen. One less thing to alter in the other issue."
+518,"@@ -89,7 +89,6 @@ Prints out information about filecoin process and its environment.
+ 			sw.Printf(""\nEnvironment\n"")
+ 			sw.Printf(""FilAPI: \t%s\n"", info.Environment.FilAPI)
+ 			sw.Printf(""FilPath:\t%s\n"", info.Environment.FilPath)
+-			sw.Printf(""GoPath: \t%s\n"", info.Environment.GoPath)
+
+ 			// Print Config Info
+ 			sw.Printf(""\nConfig\n"")","I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?"
+519,"@@ -296,11 +296,16 @@ public class ImageRampupManagerImpl implements ImageRampupManager {
+       if (null == flow) {
+         log.info(""Flow object is null, so continue"");
+         final ImageRampup firstImageRampup = imageRampupList.get(0);
++
++        // Find the imageVersion in the Rampup list with maximum rampup percentage.
++        final ImageRampup maxImageRampup = imageRampupList.stream()
++            .max(Comparator.comparing(ImageRampup::getRampupPercentage))
++            .orElseGet(() -> firstImageRampup);
+         imageTypeRampupVersionMap.put(imageTypeName,
+-            this.fetchImageVersion(imageTypeName, firstImageRampup.getImageVersion())
++            this.fetchImageVersion(imageTypeName, maxImageRampup.getImageVersion())
+                 .orElseThrow(() -> new ImageMgmtException(
+                     String.format(""Unable to fetch version %s from image "" + ""versions table."",
+-                        firstImageRampup.getImageVersion()))));
++                        maxImageRampup.getImageVersion()))));
+         continue;
+       }
+       int prevRampupPercentage = 0;",I thought we decided on using the latest active version and not the one which is max ramped up.
+520,"@@ -461,10 +461,13 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
+ 		if err != nil {
+ 			if err == selector.ErrSubnetsNotFound {
+ 				log.Errorf(`No existing public subnets were found in VPC %s. You can either:
+-- Create new public subnets and then import them.
+-- Use the default Copilot environment configuration.`, o.importVPC.ID)
++- %s to interrupt, create new public subnets, then rerun %s and import them.
++- %s to interrupt, then rerun %s and use the default Copilot environment configuration.
++- Proceed without public subnets, knowing that deploying a load-balanced web service in this environment will fail because Load Balancers require at least two public subnets in different Availability Zones.
++`, o.importVPC.ID, color.HighlightUserInput(""ctrl-c""), color.HighlightCode(""copilot env init""), color.HighlightUserInput(""ctrl-c""), color.HighlightCode(""copilot env init""))
++			} else {
++				return fmt.Errorf(""select public subnets: %w"", err)
+ 			}
+-			return fmt.Errorf(""select public subnets: %w"", err)
+ 		}
+ 		o.importVPC.PublicSubnetIDs = publicSubnets
+ 	}",can we update this to a `log.Warningf`?
+521,"@@ -105,7 +105,11 @@ def connect_container_to_network(container, network):
+
+
+ def disconnect_container_from_network(container, network):
+-    subprocess.check_call([""docker"", ""network"", ""disconnect"", network, container])
++    # subprocess.run instead of subprocess.check_call so we don't fail when
++    # trying to disconnect a container from a network that it's not connected to
++    subprocess.run(  # pylint: disable=subprocess-run-check
++        [""docker"", ""network"", ""disconnect"", network, container]
++    )
+
+
+ def hostnames(network):",can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?
+522,"@@ -20,9 +20,10 @@ namespace storage {
+ TEST(DeleteVertexTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/DeleteVertexTest.XXXXXX"");
+     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
++    auto schemaMan = TestUtils::mockSchemaMan();
+     // Add vertices
+     {
+-        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr);
++        auto* processor = AddVerticesProcessor::instance(kv.get(), schemaMan.get(), nullptr);
+         cpp2::AddVerticesRequest req;
+         req.space_id = 0;
+         req.overwritable = false;",Do we need `schema manager` at here ?
+523,"@@ -0,0 +1,19 @@
++package parser
++
++//go:generate cargo build --release
++
++// #cgo LDFLAGS: -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic
++// #include <stdlib.h>
++// void flux_parse_json(const char*);
++import ""C""
++
++import (
++	""unsafe""
++)
++
++func Parse(input string) {
++	cstr := C.CString(input)
++	defer C.free(unsafe.Pointer(cstr))
++
++	C.flux_parse_json(cstr)
++}","This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module."
+524,"@@ -153,6 +153,8 @@ func (r *REPL) executeLine(t string) (values.Value, error) {
+ 		return nil, err
+ 	}
+
++	r.scope.SetReturn(nil)
++
+ 	if _, err := r.interpreter.Eval(semPkg, r.scope, flux.StdLib()); err != nil {
+ 		return nil, err
+ 	}","Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements."
+525,"@@ -162,12 +162,14 @@ func makeStatefulSetService(p *monitoringv1.Alertmanager, config Config) *v1.Ser
+ 		p.Spec.PortName = defaultPortName
+ 	}
+
++	labels := config.Labels.Merge(p.Spec.ServiceMetadata.Labels)
++	labels[""operated-alertmanager""] = ""true""
++
+ 	svc := &v1.Service{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: governingServiceName,
+-			Labels: config.Labels.Merge(map[string]string{
+-				""operated-alertmanager"": ""true"",
+-			}),
++			Name:        governingServiceName,
++			Labels:      labels,
++			Annotations: p.Spec.ServiceMetadata.Annotations,
+ 			OwnerReferences: []metav1.OwnerReference{
+ 				metav1.OwnerReference{
+ 					Name:       p.GetName(),","This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?"
+526,"@@ -32,6 +32,7 @@ type AttestedNode struct {
+ 	ExpiresAt       time.Time `gorm:""index""`
+ 	NewSerialNumber string
+ 	NewExpiresAt    *time.Time
++	CanReattest     bool `gorm:""default:false""`
+
+ 	Selectors []*NodeSelector
+ }","Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns)."
+527,"@@ -39,6 +39,18 @@ module ExportsHelper
+     ""<strong>#{prefix}</strong> #{attribution.join(', ')}""
+   end
+
++  def download_plan_page_title(plan, phase, hash)
++    # If there is more than one phase show the plan title and phase title
++    return hash[:phases].many? ? ""#{plan.title} - #{phase[:title]}"" : plan.title
++  end
++
++  def display_section?(customization, section, show_custom_sections)
++    display = !customization
++    display ||= customization && !section[:modifiable]
++    display ||= customization && section[:modifiable] && show_custom_sections
++    return display
++  end
++
+   private
+
+   def get_margin_value_for_side(side)",thanks for moving these over. makes more sense for them to be in the exports_helper
+528,"@@ -29,8 +29,9 @@ from qutebrowser.utils import message
+ from qutebrowser.config import config
+ from qutebrowser.keyinput import keyparser
+ from qutebrowser.utils import usertypes, log, objreg, utils
++from qutebrowser.config.parsers import keyconf
+
+-
++
+ STARTCHARS = "":/?""
+ LastPress = usertypes.enum('LastPress', ['none', 'filtertext', 'keystring'])
+ ",That import now isn't needed anymore
+529,"@@ -237,6 +237,8 @@ class WebDriver(RemoteWebDriver):
+         Returns identifier of installed addon. This identifier can later
+         be used to uninstall addon.
+
++        :param path: Full path to the addon that will be installed.
++
+         :Usage:
+             driver.install_addon('firebug.xpi')
+         """"""",Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`
+530,"@@ -2,17 +2,13 @@
+ // The .NET Foundation licenses this file to you under the MS-PL license.
+ // See the LICENSE file in the project root for more information.
+
+-
+-using MvvmCross.Plugins;
+-
+ namespace MvvmCross.Plugin.Accelerometer.Platform.Uap
+ {
+-    public class Plugin
+-        : IMvxPlugin
++    public class Plugin : IMvxPlugin
+     {
+         public void Load()
+         {
+-            Mvx.RegisterSingleton<IMvxAccelerometer>(new MvxWindowsCommonAccelerometer());
++            Mvx.RegisterSingleton<IMvxAccelerometer>(new MvxWindowsAccelerometer());
+         }
+     }
+ }",This class is missing the `MvxPlugin` attribute
+531,"@@ -596,6 +596,8 @@ def initialize():
+ 	if mainFrame:
+ 		raise RuntimeError(""GUI already initialized"")
+ 	mainFrame = MainFrame()
++	wxLang = core.getWxLang(languageHandler.getLanguage())
++	mainFrame.SetLayoutDirection(wxLang.LayoutDirection)
+ 	wx.GetApp().SetTopWindow(mainFrame)
+ 	# In wxPython >= 4.1,
+ 	# wx.CallAfter no longer executes callbacks while NVDA's main thread is within apopup menu or message box.",What if `wxLang` is returned `None` from `getWxLang`
+532,"@@ -546,9 +546,9 @@ ResultCode NebulaStore::ingest(GraphSpaceID spaceId) {
+             auto files = nebula::fs::FileUtils::listAllFilesInDir(path.c_str(), true, ""*.sst"");
+             for (auto file : files) {
+                 LOG(INFO) << ""Ingesting extra file: "" << file;
+-                auto code = engine->ingest(std::vector<std::string>({file}));
+-                if (code != ResultCode::SUCCEEDED) {
+-                    return code;
++                auto ret_code = engine->ingest(std::vector<std::string>({file}));
++                if (ResultCode::SUCCEEDED != ret_code) {
++                    return ret_code;
+                 }
+             }
+         }",Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions.
+533,"@@ -35,13 +35,13 @@ public class BaseSuite {
+   public static ExternalResource testEnvironment = new ExternalResource() {
+     @Override
+     protected void before() {
+-      log.info(""Preparing test environment"");
++      log.finest(""Preparing test environment"");
+       GlobalTestEnvironment.get(SeleniumTestEnvironment.class);
+       System.setProperty(""webdriver.remote.shorten_log_messages"", ""true"");
+     }
+     @Override
+     protected void after() {
+-      log.info(""Cleaning test environment"");
++      log.finest(""Cleaning test environment"");
+       TestEnvironment environment = GlobalTestEnvironment.get();
+       if (environment != null) {
+         environment.stop();",This is in test code: understanding what we're doing is important in this context.
+534,"@@ -76,8 +76,8 @@ public class CommandLineUtils {
+    * @param isMainOptionCondition the conditions to test dependent options against. If all
+    *     conditions are true, dependent options will be checked.
+    * @param dependentOptionsNames a list of option names that can't be used if condition is met.
+-   *     Example: if --min-gas-price is in the list and condition is that either --miner-enabled or
+-   *     --goquorum-compatibility-enabled should not be false, we log a warning.
++   *     Example: if --min-gas-price is in the list and condition is that --miner-enabled should not
++   *     be false, we log a warning.
+    */
+   public static void checkMultiOptionDependencies(
+       final Logger logger,",prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?
+535,"@@ -246,9 +246,9 @@ class PlansController < ApplicationController
+     file_name = @plan.title.gsub(/ /, ""_"")
+
+     respond_to do |format|
+-      format.html
+-      format.csv  { send_data @exported_plan.as_csv(@sections, @unanswered_question, @question_headings),  filename: ""#{file_name}.csv"" }
+-      format.text { send_data @exported_plan.as_txt(@sections, @unanswered_question, @question_headings, @show_details),  filename: ""#{file_name}.txt"" }
++      format.html { render layout: false }
++      format.csv  { send_data @plan.as_csv(@show_sections_questions),  filename: ""#{file_name}.csv"" }
++      format.text { send_data render_to_string(partial: 'shared/export/plan_txt'), filename: ""#{file_name}.txt"" }
+       format.docx { render docx: 'export', filename: ""#{file_name}.docx"" }
+       format.pdf do
+         render pdf: file_name,","I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html..."
+536,"@@ -21,7 +21,7 @@ var LocalDevStopCmd = &cobra.Command{
+ 		err = app.Stop()
+ 		if err != nil {
+ 			log.Println(err)
+-			util.Failed(""Failed to stop containers for %s. Run `ddev list` to ensure your site exists."", app.ContainerName())
++			util.Failed(""Failed to stop containers for %s. Run `ddev list` to ensure your site exists. error="", app.ContainerName(), err)
+ 		}
+
+ 		util.Success(""Application has been stopped."")","stylistic nitpick: I _feel_ like we've largely shown errors like this as ""error: "" vs. ""error="". IMO colon/space reads better."
+537,"@@ -18,11 +18,16 @@
+  */
+
+ #include <fastdds/rtps/writer/RTPSWriter.h>
++
++#include <fastdds/dds/log/Log.hpp>
++
+ #include <fastdds/rtps/history/WriterHistory.h>
+ #include <fastdds/rtps/messages/RTPSMessageCreator.h>
+-#include <fastdds/dds/log/Log.hpp>
+-#include <rtps/participant/RTPSParticipantImpl.h>
++
++#include <rtps/history/BasicPayloadPool.hpp>
++#include <rtps/history/CacheChangePool.h>
+ #include <rtps/flowcontrol/FlowController.h>
++#include <rtps/participant/RTPSParticipantImpl.h>
+
+ #include <mutex>
+ ",We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function.
+538,"@@ -25,6 +25,7 @@
+ package persistencetests
+
+ import (
++	""fmt""
+ 	""time""
+
+ 	""github.com/pborman/uuid""",should this file ends with _test.go?
+539,"@@ -382,7 +382,7 @@ class IPv6(_IPv6GuessPayload, Packet, IPTools):
+
+         if conf.checkIPsrc and conf.checkIPaddr and not in6_ismaddr(sd):
+             sd = inet_pton(socket.AF_INET6, sd)
+-            ss = inet_pton(socket.AF_INET6, self.src)
++            ss = inet_pton(socket.AF_INET6, ss)
+             return strxor(sd, ss) + struct.pack(""B"", nh) + self.payload.hashret()  # noqa: E501
+         else:
+             return struct.pack(""B"", nh) + self.payload.hashret()",It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does
+540,"@@ -483,6 +483,7 @@ class DataManager {
+    */
+   addChildAtIndex(parent, index, element) {
+     let childElement = element;
++    let flattenIndex;
+
+     if (!childElement) {
+       childElement = this.mockNode();","""Flatten"" is a verb, so I'd probably go with `flattenedIndex` as a variable name here."
+541,"@@ -1,5 +1,19 @@
+ const chalk = require('chalk')
+
++const valuesToMask = []
++/**
++ * Adds a list of strings that should be masked by the logger.
++ * This function can only be called once through out the life of the server.
++ * @param {Array} maskables a list of strings to be masked
++ */
++exports.addMaskables = (maskables) => {
++  maskables.forEach((i) => {
++    valuesToMask.push(i)
++  })
++
++  Object.freeze(valuesToMask)
++}
++
+ /**
+  * INFO level log
+  * @param {string} msg the message to log","If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times"
+542,"@@ -38,7 +38,7 @@ func downloadAndExtractConfigPackage(channel string, targetDir string) (err erro
+ }
+
+ func downloadConfigPackage(channelName string, targetDir string) (packageFile string, err error) {
+-	s3, err := s3.MakeS3SessionForDownload()
++	s3, err := s3.MakePublicS3SessionForDownload()
+ 	if err != nil {
+ 		return
+ 	}",Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket.
+543,"@@ -0,0 +1,17 @@
++# MicrosoftEdge.py
++#A part of NonVisual Desktop Access (NVDA)
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++#Copyright (C) 2018 NV Access Limited, Joseph Lee
++
++""""""appModule for Microsoft Edge main process""""""
++
++import appModuleHandler
++import ui
++
++class AppModule(appModuleHandler.AppModule):
++
++	def event_UIA_notification(self, obj, nextHandler, displayString=None, **kwargs):
++		# #8423: even though content process is focused, notifications are fired by main Edge process.
++		# The base object will simply ignore this, so notifications must be announced here and no more.
++		ui.message(displayString)",Could you please end the file with an empty line?
+544,"@@ -76,7 +76,7 @@ public class ProtocolHandshake {
+
+         if (result.isPresent()) {
+           Result toReturn = result.get();
+-          LOG.info(String.format(""Detected dialect: %s"", toReturn.dialect));
++          LOG.finest(String.format(""Detected dialect: %s"", toReturn.dialect));
+           return toReturn;
+         }
+       }",This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users.
+545,"@@ -89,7 +89,9 @@ func (v *Var) UnmarshalJSON(b []byte) error {
+ // Workflow is a single Daisy workflow workflow.
+ type Workflow struct {
+ 	// Populated on New() construction.
+-	Cancel chan struct{} `json:""-""`
++	Cancel       chan struct{} `json:""-""`
++	isCanceled   bool
++	isCanceledMx sync.Mutex
+
+ 	// Workflow template fields.
+ 	// Workflow name.",Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work.
+546,"@@ -145,7 +145,11 @@ func (w *watcher) ErrorAs(err error, i interface{}) bool {
+ 	return w.bucket.ErrorAs(err, i)
+ }
+
+-// IsNotExist implements driver.IsNotExist.
+-func (*watcher) IsNotExist(err error) bool {
+-	return gcerrors.Code(err) == gcerrors.NotFound
++// ErrorCode implements driver.ErrorCode.
++func (*watcher) ErrorCode(err error) gcerrors.ErrorCode {
++	// err might have come from blob, in which case use its code.
++	if c := gcerrors.Code(err); c != gcerrors.Unknown {
++		return c
++	}
++	return gcerrors.Unknown
+ }","Nit: this is just `return gcerrors.Code(err)`, isn't it?"
+547,"@@ -189,12 +189,7 @@ func (smc *Client) ProposeDeal(ctx context.Context, miner address.Address, data
+ 	// create payment information
+ 	totalCost := price.MulBigInt(big.NewInt(int64(pieceSize * duration)))
+ 	if totalCost.GreaterThan(types.ZeroAttoFIL) {
+-		// The payment setup requires that the payment is mined into a block, currently we
+-		// will wait for at most 5 blocks to be mined before giving up
+-		ctxPaymentSetup, cancel := context.WithTimeout(ctx, 5*smc.api.BlockTime())
+-		defer cancel()
+-
+-		cpResp, err := smc.api.CreatePayments(ctxPaymentSetup, porcelain.CreatePaymentsParams{
++		cpResp, err := smc.api.CreatePayments(ctx, porcelain.CreatePaymentsParams{
+ 			From:            fromAddress,
+ 			To:              minerOwner,
+ 			Value:           totalCost,","I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests."
+548,"@@ -47,7 +47,8 @@ def loadState():
+ 	global state
+ 	statePath=os.path.join(globalVars.appArgs.configPath,stateFilename)
+ 	try:
+-		state = cPickle.load(file(statePath, ""r""))
++		with open(statePath, ""r"") as f:
++			state = cPickle.load(f)
+ 		if ""disabledAddons"" not in state:
+ 			state[""disabledAddons""] = set()
+ 		if ""pendingDisableSet"" not in state:","In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb."
+549,"@@ -2068,7 +2068,7 @@ const processRequest = (params) => {
+                     }
+                     else {
+                         if (params.qstring.event && params.qstring.event.startsWith('[CLY]_group_')) {
+-                            validateRead(params, 'core', countlyApi.data.fetch.fetchMergedEventGroups, params.qstring.method);
++                            validateRead(params, 'core', countlyApi.data.fetch.fetchMergedEventGroups);
+                         }
+                         else {
+                             params.truncateEventValuesList = true;",did you remove **params.qstring.method** intentionally? if so why?
+550,"@@ -90,6 +90,12 @@ public class TableProperties {
+   public static final String ORC_VECTORIZATION_ENABLED = ""read.orc.vectorization.enabled"";
+   public static final boolean ORC_VECTORIZATION_ENABLED_DEFAULT = false;
+
++  public static final String LOCALITY_ENABLED = ""read.locality.enabled"";
++  public static final String LOCALITY_ENABLED_DEFAULT = null;
++
++  public static final String LOCALITY_TASK_INITIALIZE_THREADS = ""read.locality.task.initialize.threads"";
++  public static final int LOCALITY_TASK_INITIALIZE_THREADS_DEFAULT = 1;
++
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ ",What is the current default? Is that inconsistent across uses and that's why this is null?
+551,"@@ -477,6 +477,7 @@ func (cf CloudFormation) getLastDeployedAppConfig(appConfig *stack.AppStackConfi
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""parse previous deployed stackset %w"", err)
+ 	}
++	previouslyDeployedConfig.App = appConfig.Name
+ 	return previouslyDeployedConfig, nil
+ }
+ ",Why did we make this change? How come it wasn't an issue before
+552,"@@ -4342,14 +4342,11 @@ TEST_F(VkLayerTest, InvalidDescriptorSet) {
+     // ObjectTracker should catch this.
+     // Create a valid cmd buffer
+     // call vk::CmdBindDescriptorSets w/ false Descriptor Set
++    ASSERT_NO_FATAL_FAILURE(Init());
+
+     uint64_t fake_set_handle = 0xbaad6001;
+     VkDescriptorSet bad_set = reinterpret_cast<VkDescriptorSet &>(fake_set_handle);
+
+-    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdBindDescriptorSets-pDescriptorSets-parameter"");
+-
+-    ASSERT_NO_FATAL_FAILURE(Init());
+-
+     VkDescriptorSetLayoutBinding layout_binding = {};
+     layout_binding.binding = 0;
+     layout_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;",Can you tighten scope by moving to of these variables? i.e. Move to ~4372?
+553,"@@ -90,7 +90,7 @@ public class RDATAFileReader extends TabularDataFileReader {
+   // RServe static variables
+   private static String RSERVE_HOST = System.getProperty(""dataverse.rserve.host"");
+   private static String RSERVE_USER = System.getProperty(""dataverse.rserve.user"");
+-  private static String RSERVE_PASSWORD = System.getProperty(""dataverse.rserve.pwrd"");
++  private static String RSERVE_PASSWORD = System.getProperty(""dataverse.rserve.password"");
+   private static int RSERVE_PORT;
+
+   // TODO: ",Nice to see this `dataverse.rserve.password` fix rolled in.
+554,"@@ -273,7 +273,7 @@ int parse_args(int argc, char *argv[])
+ 				break;
+ 			endptr = NULL;
+ 			config.target.bus = (int) strtoul(tmp_optarg, &endptr, 0);
+-			if (endptr != tmp_optarg + strlen(tmp_optarg)) {
++			if (endptr != tmp_optarg + strnlen_s(tmp_optarg, sizeof(tmp_optarg))) {
+ 				fprintf(stderr, ""invalid bus: %s\n"", tmp_optarg);
+ 				return -1;
+ 			}","How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\0' || *endptr != '\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\0') or invalid (`endptr` points to something other that a '\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though."
+555,"@@ -7,6 +7,7 @@ class FeedbackMailer < ApplicationMailer
+       to: self.class.support_email,
+       subject: 'Feedback submission',
+       from: from,
++      cc: from,
+       body: message
+     )
+   end","I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different."
+556,"@@ -32,13 +32,12 @@ describe('useEffect', () => {
+ 			return null;
+ 		}
+
+-		render(<Comp />, scratch);
+-		render(<Comp />, scratch);
+-
+-		expect(cleanupFunction).to.be.not.called;
+-		expect(callback).to.be.calledOnce;
++		act(() => {
++			render(<Comp />, scratch);
++			render(<Comp />, scratch);
++		});
+
+-		render(<Comp />, scratch);
++		act(() => render(<Comp />, scratch));
+
+ 		expect(cleanupFunction).to.be.calledOnce;
+ 		expect(callback).to.be.calledTwice;",I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(
+557,"@@ -632,8 +632,13 @@ void nano::active_transactions::update_difficulty (std::shared_ptr<nano::block>
+ 			{
+ 				node.logger.try_log (boost::str (boost::format (""Block %1% was updated from difficulty %2% to %3%"") % block_a->hash ().to_string () % nano::to_string_hex (existing_election->difficulty) % nano::to_string_hex (difficulty)));
+ 			}
+-			roots.get<tag_root> ().modify (existing_election, [difficulty](nano::conflict_info & info_a) {
++			roots.get<tag_root> ().modify (existing_election, [election = existing_election->election, &block_a, difficulty](nano::conflict_info & info_a) {
+ 				info_a.difficulty = difficulty;
++				election->blocks[block_a->hash ()] = block_a;
++				if (election->status.winner->hash () == block_a->hash ())
++				{
++					election->status.winner = block_a;
++				}
+ 			});
+ 			adjust_difficulty (block_a->hash ());
+ 		}","Could use election from `info_a.election`, or is this deliberate?"
+558,"@@ -95,6 +95,15 @@ class EasyAdminExtension extends AbstractTypeExtension
+     {
+         return LegacyFormHelper::getType('form');
+     }
++
++    /**
++     * {@inheritdoc}
++     */
++    public static function getExtendedTypes()
++    {
++        // needed to avoid a deprecation when using Symfony 4.2
++        return [LegacyFormHelper::getType('form')];
++    }
+ }
+
+ class_alias('EasyCorp\Bundle\EasyAdminBundle\Form\Extension\EasyAdminExtension', 'JavierEguiluz\Bundle\EasyAdminBundle\Form\Extension\EasyAdminExtension', false);",looks like this should be `return array(LegacyFormHelper::getType('form'));`
+559,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?
+560,"@@ -223,10 +223,9 @@ Blockly.ScratchBlocks.VerticalExtensions.SCRATCH_EXTENSION = function() {
+ Blockly.ScratchBlocks.VerticalExtensions.registerAll = function() {
+   var categoryNames =
+       ['control', 'data', 'data_lists', 'sounds', 'motion', 'looks', 'event',
+-      'sensing', 'pen', 'operators', 'more'];
++        'sensing', 'pen', 'operators', 'more'];
+   // Register functions for all category colours.
+-  for (var i = 0; i < categoryNames.length; i++) {
+-    name = categoryNames[i];
++  for (var i = 0, name; name = categoryNames[i]; i++) {
+     Blockly.Extensions.register('colours_' + name,
+         Blockly.ScratchBlocks.VerticalExtensions.colourHelper(name));
+   }",Where was `name` being declared before?
+561,"@@ -74,6 +74,18 @@ func (t testHelper) UnavailableDeployment() *appsv1.Deployment {
+ 	return d
+ }
+
++func (t testHelper) UnknownDeployment() *appsv1.Deployment {
++	d := &appsv1.Deployment{}
++	d.Name = ""unknown""
++	d.Status.Conditions = []appsv1.DeploymentCondition{
++		{
++			Type:   appsv1.DeploymentAvailable,
++			Status: ""Unknown"",
++		},
++	}
++	return d
++}
++
+ func (t testHelper) ReadyBrokerCellStatus() *BrokerCellStatus {
+ 	bs := &BrokerCellStatus{}
+ 	bs.PropagateIngressAvailability(t.AvailableEndpoints())",nit: use `corev1.ConditionUnknown`
+562,"@@ -997,7 +997,10 @@ Mongoose.prototype.isValidObjectId = function(v) {
+     v = v.toString();
+   }
+
+-  if (typeof v === 'string' && (v.length === 12 || v.length === 24)) {
++  if (typeof v === 'string' && v.length === 12) {
++    return true;
++  }
++  if (typeof v === 'string' && v.length === 24 && /^[a-f0-9]*$/.test(v)) {
+     return true;
+   }
+ ","You also need to add a similar check on line 992, there's another place where we check `length === 24`"
+563,"@@ -105,9 +105,14 @@ public class BftBlockCreatorFactory {
+   public Bytes createExtraData(final int round, final BlockHeader parentHeader) {
+     final BftContext bftContext = protocolContext.getConsensusState(BftContext.class);
+     final ValidatorProvider validatorProvider = bftContext.getValidatorProvider();
+-    checkState(validatorProvider.getVoteProvider().isPresent(), ""Bft requires a vote provider"");
++    checkState(
++        validatorProvider.getVoteProviderAfterBlock(parentHeader).isPresent(),
++        ""Bft requires a vote provider"");
+     final Optional<ValidatorVote> proposal =
+-        validatorProvider.getVoteProvider().get().getVoteAfterBlock(parentHeader, localAddress);
++        validatorProvider
++            .getVoteProviderAfterBlock(parentHeader)
++            .get()
++            .getVoteAfterBlock(parentHeader, localAddress);
+
+     final List<Address> validators =
+         new ArrayList<>(validatorProvider.getValidatorsAfterBlock(parentHeader));",nit: can extract the voteProvider as a local variable
+564,"@@ -1190,14 +1190,8 @@ public class QueryEqualityTest extends SolrTestCaseJ4 {
+     assertFuncEquals(""gte(foo_i,2)"", ""gte(foo_i,2)"");
+     assertFuncEquals(""eq(foo_i,2)"", ""eq(foo_i,2)"");
+
+-    boolean equals = false;
+-    try {
+-      assertFuncEquals(""eq(foo_i,2)"", ""lt(foo_i,2)"");
+-      equals = true;
+-    } catch (AssertionError e) {
+-      //expected
+-    }
+-    assertFalse(equals);
++    expectThrows(AssertionError.class, ""expected error, functions are not equal"",
++        () -> assertFuncEquals(""eq(foo_i,2)"", ""lt(foo_i,2)""));
+   }
+
+   public void testChildField() throws Exception {","[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`"
+565,"@@ -61,3 +61,19 @@ func (bc *Blockchain) GetAccountantFee(accountantAddress common.Address) (uint16
+
+ 	return res.Value, err
+ }
++
++// IsRegistered checks wether the given identity is registered or not
++func (bc *Blockchain) IsRegistered(registryAddress, addressToCheck common.Address) (bool, error) {
++	caller, err := bindings.NewRegistryCaller(registryAddress, bc.client)
++	if err != nil {
++		return false, errors.Wrap(err, ""could not create registry caller"")
++	}
++
++	ctx, cancel := context.WithTimeout(context.Background(), bc.bcTimeout)
++	defer cancel()
++
++	res, err := caller.IsRegistered(&bind.CallOpts{
++		Context: ctx,
++	}, addressToCheck)
++	return res, errors.Wrap(err, ""could not check registration status"")
++}",why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?
+566,"@@ -2,7 +2,7 @@ import { pathOr, curry, merge } from 'ramda';
+
+ /**
+  * Flattens a property path so that its fields are spread out into the provided object.
+- *
++ * It's like {@link RA.spreadPath|spreadPath}, but preserves object under property path
+  *
+  * @func flattenPath
+  * @memberOf RA",`.` at the end of the sentence
+567,"@@ -284,12 +284,16 @@ func (s *Service) checkAndAddPeers(ctx context.Context, peers pb.Peers) {
+ 			ctx, cancel := context.WithTimeout(ctx, pingTimeout)
+ 			defer cancel()
+
++			start := time.Now()
++
+ 			// check if the underlay is usable by doing a raw ping using libp2p
+ 			if _, err = s.streamer.Ping(ctx, multiUnderlay); err != nil {
++				s.metrics.PingTime.Observe(float64(time.Since(start).Milliseconds()))
+ 				s.metrics.UnreachablePeers.Inc()
+ 				s.logger.Debugf(""hive: peer %s: underlay %s not reachable"", hex.EncodeToString(newPeer.Overlay), multiUnderlay)
+ 				return
+ 			}
++			s.metrics.PingTime.Observe(float64(time.Since(start).Milliseconds()))
+
+ 			bzzAddress := bzz.Address{
+ 				Overlay:     swarm.NewAddress(newPeer.Overlay),",wouldn't it be useful to split this into an error metric for the timing?
+568,"@@ -47,4 +47,8 @@ class TestFakerName < Test::Unit::TestCase
+     assert @tester.initials.match(/[A-Z]{3}/)
+     assert @tester.initials(2).match(/[A-Z]{2}/)
+   end
++
++  def test_fictional_character_name
++  assert @tester.fictional_character_name.match(/\w+/)
++  end
+ end","Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator..."
+569,"@@ -1293,6 +1293,8 @@ func newTestCFSM(
+ 				MintNewSecretBlock(gomock.Any(), gomock.Any(), gomock.Any()).Return(secretBlkToMint, nil).AnyTimes()
+ 			blockchain.EXPECT().
+ 				Nonce(gomock.Any()).Return(uint64(0), nil).AnyTimes()
++			blockchain.EXPECT().
++				MintNewBlockWithActionIterator(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(blkToMint, nil).AnyTimes()
+ 			if mockChain == nil {
+ 				candidates := make([]*state.Candidate, 0)
+ 				for _, delegate := range delegates {",line is 138 characters
+570,"@@ -75,8 +75,9 @@ type Params struct {
+ 	TraceOpts []ocsql.TraceOption
+ }
+
+-// Open opens a Cloud SQL database.
+-func Open(ctx context.Context, certSource proxy.CertSource, params *Params) (*sql.DB, error) {
++// Open opens a Cloud SQL database. The second return value is a Wire cleanup
++// function that calls Close on the returned database.
++func Open(ctx context.Context, certSource proxy.CertSource, params *Params) (*sql.DB, func(), error) {
+ 	// TODO(light): Avoid global registry once https://github.com/go-sql-driver/mysql/issues/771 is fixed.
+ 	dialerCounter.mu.Lock()
+ 	dialerNum := dialerCounter.n",Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it.
+571,"@@ -14,10 +14,14 @@
+  */
+ package com.google.api.codegen.transformer.ruby;
+
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",Nit: each field can be on a separate line to make it visually easier to read.
+572,"@@ -336,6 +336,7 @@ def get_analysis_statistics(inputs, limits):
+                     statistics_files.append(compilation_db)
+             elif inp_f in ['compiler_includes.json',
+                            'compiler_target.json',
++                           'compiler_info.json',
+                            'metadata.json']:
+                 analyzer_file = os.path.join(input_path, inp_f)
+                 statistics_files.append(analyzer_file)",Do we still have these files? Shouldn't we remove these?
+573,"@@ -22,6 +22,11 @@ import (
+ 	""github.com/jetstack/cert-manager/pkg/apis/certmanager/v1alpha1""
+ )
+
++ const (
++ 	// Error reason generated when duration or renewBefore is invalid
++	ErrorDurationInvalid = ""ErrDurationInvalid""
++)
++
+ type Interface interface {
+ 	// Setup initialises the issuer. This may include registering accounts with
+ 	// a service, creating a CA and storing it somewhere, or verifying","A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?"
+574,"@@ -171,7 +171,9 @@ var (
+ 			RepeatDecayStep:       1,
+ 		},
+ 		Dispatcher: Dispatcher{
+-			EventChanSize: 10000,
++			ActionChanSize:    1000,
++			BlockChanSize:     1000,
++			BlockSyncChanSize: 10,
+ 		},
+ 		API: API{
+ 			UseRDS:    false,","is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node"
+575,"@@ -297,7 +297,7 @@ module Bolt
+         errors.each do |error|
+           @logger.warn(error.details['original_error'])
+         end
+-        plans
++        plans.reject { |plan| get_plan_info(plan.first)['private'] }
+       end
+     end
+ ",A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective.
+576,"@@ -19,3 +19,9 @@ const (
+ 	BUTTON3 = 15
+ 	BUTTON4 = 16
+ )
++
++// UART pins for NRF52840-DK
++const (
++	UART_TX_PIN = 6
++	UART_RX_PIN = 8
++)","These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?"
+577,"@@ -1089,6 +1089,13 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+           ""Specifies the static node file containing the static nodes for this node to connect to"")
+   private final Path staticNodesFile = null;
+
++  @SuppressWarnings({""FieldCanBeFinal"", ""FieldMayBeFinal""}) // PicoCLI requires non-final Strings.
++  @CommandLine.Option(
++          names = { ""--dns-discovery-url"" },
++          description = ""Specifies the URL to use for DNS discovery""
++  )
++  private String dnsDiscoveryUrl = null;
++
+   private EthNetworkConfig ethNetworkConfig;
+   private JsonRpcConfiguration jsonRpcConfiguration;
+   private GraphQLConfiguration graphQLConfiguration;",Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?
+578,"@@ -1,3 +1,4 @@
++//go:build !ignore_autogenerated
+ // +build !ignore_autogenerated
+
+ /*",why is this needed?
+579,"@@ -23,7 +23,7 @@ DEFAULT_TYPE_ATTRIBUTES = ConfigTypeAttributes()
+
+
+ class ConfigType(object):
+-    def __init__(self, name=None, type_attributes=DEFAULT_TYPE_ATTRIBUTES, description=None):
++    def __init__(self, key, name, type_attributes=DEFAULT_TYPE_ATTRIBUTES, description=None):
+
+         type_obj = type(self)
+         if type_obj in ConfigType.__cache:","I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1."
+580,"@@ -110,6 +110,7 @@ public final class ThriftCodec implements Codec {
+     final Field IPV4 = new Field(TYPE_I32, 1);
+     final Field PORT = new Field(TYPE_I16, 2);
+     final Field SERVICE_NAME = new Field(TYPE_STRING, 3);
++    final Field IPV6 = new Field(TYPE_STRING, 4);
+
+     @Override
+     public Endpoint read(ByteBuffer bytes) {",@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?
+581,"@@ -506,7 +506,7 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
+ ReturnValue Game::getPlayerByNameWildcard(const std::string& s, Player*& player)
+ {
+ 	size_t strlen = s.length();
+-	if (strlen == 0 || strlen > 20) {
++	if (strlen == 0 || strlen > PLAYER_NAME_LENGHT) {
+ 		return RETURNVALUE_PLAYERWITHTHISNAMEISNOTONLINE;
+ 	}
+ ","spelling (variable name, all three changes)"
+582,"@@ -411,8 +411,16 @@ type KeybaseService interface {
+ 		[]keybase1.PublicKey, error)
+
+ 	// LoadTeamPlusKeys returns a TeamInfo struct for a team with the
+-	// specified TeamID.
+-	LoadTeamPlusKeys(ctx context.Context, tid keybase1.TeamID) (TeamInfo, error)
++	// specified TeamID.  The caller can specify `desiredKeyGen` to
++	// force a server check if that particular key gen isn't yet
++	// known; it may be set to UnspecifiedKeyGen if no server check is
++	// required.  The caller can specify `desiredUID` to force a
++	// server check if that particular UID isn't a member of the team
++	// yet according to local caches; it may be set to """" if no server
++	// check is required.
++	LoadTeamPlusKeys(ctx context.Context, tid keybase1.TeamID,
++		desiredKeyGen KeyGen, desiredUser keybase1.UserVersion,
++		desiredRole keybase1.TeamRole) (TeamInfo, error)
+
+ 	// CurrentSession returns a SessionInfo struct with all the
+ 	// information for the current session, or an error otherwise.","I believe you meant ""specify `desiredUID` and `desiredRole`""?"
+583,"@@ -16,10 +16,9 @@ package openflow
+
+ import (
+ 	""fmt""
++	""github.com/vmware-tanzu/antrea/pkg/apis/networking/v1beta1""
+ 	""net""
+
+-	coreV1 ""k8s.io/api/core/v1""
+-	v1 ""k8s.io/api/networking/v1""
+ 	""k8s.io/klog""
+
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/types""","Please follow the import style, move it to its similar group"
+584,"@@ -63,3 +63,18 @@ func IsUnrecognizedProcedureError(err error) bool {
+ 	_, ok := err.(errors.UnrecognizedProcedureError)
+ 	return ok
+ }
++
++// UnrecognizedEncodingError returns an error for the given request, such that
++// IsUnrecognizedEncodingError can distinguish it from other errors coming out
++// of router.Choose.
++func UnrecognizedEncodingError(req *Request, want []string) error {
++	return errors.RouterUnrecognizedEncodingError(want, string(req.Encoding))
++}
++
++// IsUnrecognizedEncodingError returns true for errors returned by
++// Router.Choose if the router cannot find a handler for the request's
++// encoding.
++func IsUnrecognizedEncodingError(err error) bool {
++	_, ok := err.(errors.UnrecognizedEncodingError)
++	return ok
++}",Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal
+585,"@@ -146,11 +146,9 @@ public class PasswordValidatorServiceBean implements java.io.Serializable {
+      * @return A List with error messages. Empty when the password is valid.
+      */
+     public List<String> validate(String password, Date passwordModificationTime, boolean isHumanReadable) {
+-//    public List<String> validate(String password, boolean isHumanReadable) {
+
+         init();
+-        final PasswordData passwordData = PasswordData.newInstance(password, String.valueOf(passwordModificationTime.getTime()), null);
+-//        final PasswordData passwordData = PasswordData.newInstance(password, ""username"", null);
++        final PasswordData passwordData = new PasswordData(password);
+         final RuleResult result = new RuleResult();
+
+         for (PasswordValidator currentUser : validators.values()) {",passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?
+586,"@@ -40,7 +40,7 @@ namespace ScenarioMeasurement
+
+                 source.Kernel.ProcessStart += evt =>
+                 {
+-                    if (processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine == commandLine)
++                    if (processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine.Trim() == commandLine.Trim())
+                     {
+                         if (pid.HasValue)
+                         {","Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?"
+587,"@@ -115,7 +115,7 @@ var _ = Describe(""with running container"", func() {
+ 		It(""iptables should succeed in getting the lock after 3s"", func() {
+ 			iptCmd := cmdInContainer(""iptables"", ""-w"", ""3"", ""-A"", ""FORWARD"")
+ 			out, err := iptCmd.CombinedOutput()
+-			Expect(string(out)).To(ContainSubstring(""Another app is currently holding the xtables lock""))
++			log.Printf(""iptables output='%s'"", out)
+ 			Expect(err).NotTo(HaveOccurred())
+ 		})
+ ","Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)"
+588,"@@ -155,13 +155,14 @@ Blockly.FlyoutButton.prototype.createDom = function() {
+       this.svgGroup_);
+   svgText.textContent = this.text_;
+
+-  this.width = svgText.getComputedTextLength() +
+-      2 * Blockly.FlyoutButton.MARGIN;
++  this.width = svgText.getComputedTextLength();
+
+   if (!this.isLabel_) {
++    this.width += 2 * Blockly.FlyoutButton.MARGIN;
+     shadow.setAttribute('width', this.width);
+     shadow.setAttribute('height', this.height);
+   }
++
+   rect.setAttribute('width', this.width);
+   rect.setAttribute('height', this.height);
+ ","Hm, this looks like a change that should go upstream as well."
+589,"@@ -1533,16 +1533,6 @@ func (core *coreService) ChainID() uint32 {
+ 	return core.bc.ChainID()
+ }
+
+-// GetActionByActionHash returns action by action hash
+-func (core *coreService) ActionByActionHash(h hash.Hash256) (action.SealedEnvelope, error) {
+-	if !core.hasActionIndex || core.indexer == nil {
+-		return action.SealedEnvelope{}, status.Error(codes.NotFound, blockindex.ErrActionIndexNA.Error())
+-	}
+-
+-	selp, _, _, _, err := core.getActionByActionHash(h)
+-	return selp, err
+-}
+-
+ // ReadContractStorage reads contract's storage
+ func (core *coreService) ReadContractStorage(ctx context.Context, addr address.Address, key []byte) ([]byte, error) {
+ 	ctx, err := core.bc.Context(ctx)",let's keep ActionByActionHash and delete getActionByActionHash
+590,"@@ -64,4 +64,12 @@ class ProductVisibility
+     {
+         return $this->visible;
+     }
++
++    /**
++     * @return \Shopsys\FrameworkBundle\Model\Pricing\Group\PricingGroup
++     */
++    public function getPricingGroup(): PricingGroup
++    {
++        return $this->pricingGroup;
++    }
+ }",please use return type
+591,"@@ -76,7 +76,7 @@ public class TestEdgeDriver extends RemoteWebDriver implements WebStorage, Locat
+                 .findFirst().orElseThrow(WebDriverException::new);
+
+         service = (EdgeDriverService) builder.withVerbose(true).withLogFile(logFile.toFile()).build();
+-        LOG.info(""edgedriver will log to "" + logFile);
++        LOG.fine(""edgedriver will log to "" + logFile);
+         service.start();
+         Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));
+       }",This is deliberately at this level.
+592,"@@ -237,7 +237,7 @@ class UploadWorkerThread(TransferThread):
+             except self._retry_exceptions as e:
+                 log.error(""Exception caught uploading part number %s for ""
+                           ""vault %s, attempt: (%s / %s), filename: %s, ""
+-                          ""exception: %s, msg: %s"",
++                          ""exception: %s as msg: %s"",
+                           work[0], self._vault_name, i + 1, self._num_retries + 1,
+                           self._filename, e.__class__, e)
+                 time.sleep(self._time_between_retries)","I'm going to go ahead and undo this change, I don't think it was intentional."
+593,"@@ -163,7 +163,7 @@ namespace Datadog.AutoInstrumentation.ManagedLoader
+         /// As a result, the target framework moniker and the binary compatibility flags are initialized correctly.
+         /// </summary>
+         /// <remarks>
+-        /// The above logic is further specialised, depending on the kind of the currnent AppDomain and where the app is hosted:
++        /// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted:
+         /// <br />
+         /// * On non-default AD:
+         ///   we do not wait.",> specialised This isn't a typo in my neck of the woods
+594,"@@ -29,6 +29,7 @@ import (
+
+ var packages = []string{
+ 	""github.com/google/knative-gcp/test/cmd/target"",
++	""github.com/google/knative-gcp/test/cmd/storageTarget"",
+ }
+
+ var packageToImageConfig = map[string]string{}",will change to `storage_target`
+595,"@@ -38,7 +38,7 @@ class SecurityCenterTest(unittest_utils.ForsetiTestCase):
+         """"""Set up.""""""
+         fake_global_configs = {
+             'securitycenter': {'max_calls': 1, 'period': 1.1}}
+-        cls.securitycenter_beta_api_client = securitycenter.SecurityCenterClient(version='v1beta1')
++        cls.securitycenter = securitycenter.SecurityCenterClient(version='v1')
+         cls.project_id = 111111
+         cls.source_id = 'organizations/111/sources/222'
+ ","This would be better as `cls.securitycenter_client`, to match what is being instantiated."
+596,"@@ -34,6 +34,15 @@ import appModules
+ import watchdog
+ import extensionPoints
+ from fileUtils import getFileVersionInfo
++import shlobj
++from functools import wraps
++
++# Path to the native system32 directory.
++nativeSys32: str = shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEM)
++# Path to the syswow64 directory if it exists on the current system.
++Syswow64Sys32: str = shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEMX86)
++# Do we have separate system32 directories for 32 and 64-bit processes?
++hasSeparateSyswow64: bool = nativeSys32 != Syswow64Sys32
+
+ #Dictionary of processID:appModule paires used to hold the currently running modules
+ runningTable={}",Could we have this initialization as part of the initialize method?
+597,"@@ -15,7 +15,7 @@ export default AbstractEditController.extend({
+   showUpdateButton: true,
+
+   database: inject.service(),
+-  editController: inject.controller('patients/edit'),
++  editController: null,
+   filesystem: inject.service(),
+
+   photoFileNotSet: computed('model.photoFile', function() {",This line should be removed as editController is not used from this context anymore.
+598,"@@ -9,11 +9,17 @@ import (
+ 	""github.com/influxdata/flux/plan""
+ )
+
++// Transformation represents functions that control of how the execution
++// engine will take in a flux Table, perform the necessary data processing
++// and return an output flux Table
+ type Transformation interface {
+ 	RetractTable(id DatasetID, key flux.GroupKey) error
++	// Process takes in a flux Table, performs data processing on it
++	// and produces an output flux Table
+ 	Process(id DatasetID, tbl flux.Table) error
+ 	UpdateWatermark(id DatasetID, t Time) error
+ 	UpdateProcessingTime(id DatasetID, t Time) error
++	// Finish indicates that the Transformation is complete
+ 	Finish(id DatasetID, err error)
+ }
+ ","This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?"
+599,"@@ -238,9 +238,14 @@ class DetectoRS_ResNet(ResNet):
+                  pretrained=None,
+                  init_cfg=None,
+                  **kwargs):
+-        assert init_cfg is None, 'To prevent abnormal initialization ' \
+-                                 'behavior, init_cfg is not allowed to be set'
+-        self.pretrained = pretrained
++        self.init_cfg = init_cfg
++        if init_cfg is not None:  # init_cfg priority > pretrained
++            self.pretrained = init_cfg['checkpoint']
++        else:
++            if pretrained is not None:
++                self.pretrained = pretrained
++            else:
++                self.pretrained = None
+         self.sac = sac
+         self.stage_with_sac = stage_with_sac
+         self.rfp_inplanes = rfp_inplanes","For insurance, it's best not to take it directly"
+600,"@@ -67,11 +67,11 @@ public abstract class AbstractWebDriverEventListener implements WebDriverEventLi
+     // Do nothing.
+   }
+
+-  public void beforeChangeValueOf(WebElement element, WebDriver driver) {
++  public void beforeChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) {
+     // Do nothing.
+   }
+
+-  public void afterChangeValueOf(WebElement element, WebDriver driver) {
++  public void afterChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) {
+     // Do nothing.
+   }
+ ","change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it."
+601,"@@ -1244,6 +1244,8 @@ func (engine *DockerTaskEngine) provisionContainerResources(task *apitask.Task,
+ 	taskIP := result.IPs[0].Address.IP.String()
+ 	seelog.Infof(""Task engine [%s]: associated with ip address '%s'"", task.Arn, taskIP)
+ 	engine.state.AddTaskIPAddress(taskIP, task.Arn)
++	task.SetLocalIPAddress(taskIP)
++	engine.saveTaskData(task)
+ 	return dockerapi.DockerContainerMetadata{
+ 		DockerID: cniConfig.ContainerID,
+ 	}",is the plan to fully migrate to boltdb and then remove the state save here?
+602,"@@ -153,6 +153,8 @@ function themeStyle(theme) {
+
+ 		output.colorUrl = '#7B81FF';
+
++		output.strongTextColor = 'rgb(220,220,220)';
++
+ 		themeCache_[theme] = output;
+ 		return addExtraStyles(themeCache_[theme]);
+ 	}",This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable.
+603,"@@ -6,6 +6,11 @@
+
+ import os
+
++version_year=2016
++version_major=3
++version_minor=0
++version_build=0
++
+ def _updateVersionFromVCS():
+ 	""""""Update the version from version control system metadata if possible.
+ 	""""""","nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place."
+604,"@@ -99,7 +99,7 @@ const LanguageParameters& GetLangParams(IDLOptions::Language lang) {
+       """",
+       """",
+       """",
+-      ""import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\n""
++      ""import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\nimport javax.annotation.*;\n""
+         ""import com.google.flatbuffers.*;\n\n@SuppressWarnings(\""unused\"")\n"",
+       {
+         ""/**"",",Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?
+605,"@@ -50,8 +50,8 @@ class Phase < ActiveRecord::Base
+   has_many :suffix_sections, -> (phase) {
+     modifiable.where(<<~SQL, phase_id: phase.id, modifiable: false)
+       sections.number > (SELECT MAX(number) FROM sections
+-                           WHERE sections.modifiable = :modifiable)
+-                           AND sections.phase_id = :phase_id
++                           WHERE sections.modifiable = :modifiable
++                           AND sections.phase_id = :phase_id)
+     SQL
+   }, class_name: ""Section""
+ ",@briri Thanks! I just caught this too updating my feature branch
+606,"@@ -214,8 +214,17 @@ var errorConfigFileNotFound = errors.New(""config file not found"")
+ // automatically decrypt it.
+ func loadConfigFile() (*goconfig.ConfigFile, error) {
+ 	b, err := ioutil.ReadFile(ConfigPath)
++	envpw := os.Getenv(""RCLONE_CONFIG_PASS"")
+ 	if err != nil {
+ 		if os.IsNotExist(err) {
++			if len(configKey) == 0 && envpw != """" {
++				err := setConfigPassword(envpw)
++				if err != nil {
++					fmt.Println(""Using RCLONE_CONFIG_PASS returned:"", err)
++				} else {
++					fs.Debugf(nil, ""Using RCLONE_CONFIG_PASS password."")
++				}
++			}
+ 			return nil, errorConfigFileNotFound
+ 		}
+ 		return nil, err","I think you should move this block (and the `envpw := os.Getenv(""RCLONE_CONFIG_PASS"")`) right to the start of the function, then we can remove the duplicate code below"
+607,"@@ -424,6 +424,17 @@ public class NodeTest {
+     return baseDir;
+   }
+
++  //Test that the draining command sets Host status to DRAINING
++  @Test
++  public void drainingNodeStatusDraining() {
++
++  }
++
++  //Test that a draining node doesn't accept new sessions by any means
++  //Test that a draining node continues to run its sessions and accept new WebDriver commands
++  //Test that a node will shut down once all sessions are finished
++  //Test that RemoteNode will post the correct command oto the LocalNode
++
+   private CreateSessionRequest createSessionRequest(Capabilities caps) {
+     return new CreateSessionRequest(
+             ImmutableSet.copyOf(Dialect.values()),",Is this only to set the node to draining?   I think we can do that inside `Before` or something?
+608,"@@ -647,6 +647,11 @@ namespace Datadog.Trace
+             {
+                 try
+                 {
++                    if (AzureAppServices.Metadata.IsRelevant)
++                    {
++                        return AzureAppServices.Metadata.SiteName;
++                    }
++
+                     if (TryLoadAspNetSiteName(out var siteName))
+                     {
+                         return siteName;",This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this.
+609,"@@ -43,12 +43,13 @@ module Bolt
+       Bolt::ResultSet.include_iterable
+     end
+
+-    # Create a top-level alias for TargetSpec so that users don't have to
++    # Create a top-level alias for TargetSpec and PlanResult so that users don't have to
+     # namespace it with Boltlib, which is just an implementation detail. This
+-    # allows TargetSpec to feel like a built-in type in bolt, rather than
++    # allows them to feel like a built-in type in bolt, rather than
+     # something has been, no pun intended, ""bolted on"".
+-    def add_target_spec(compiler)
++    def alias_types(compiler)
+       compiler.evaluate_string('type TargetSpec = Boltlib::TargetSpec')
++      compiler.evaluate_string('type PlanResult = Boltlib::PlanResult')
+     end
+
+     def full_modulepath(modulepath)",Do we expect people to use PlanResult directly?
+610,"@@ -48,7 +48,8 @@ func NewBackoff() wait.Backoff {
+
+ // WaitForWithRetryable repeats a condition check with exponential backoff.
+ func WaitForWithRetryable(backoff wait.Backoff, condition wait.ConditionFunc, retryableErrors ...string) error { //nolint
+-	return wait.ExponentialBackoff(backoff, func() (bool, error) {
++	var actualErr error
++	waitErr := wait.ExponentialBackoff(backoff, func() (bool, error) {
+ 		ok, err := condition()
+ 		if ok {
+ 			// All done!",Maybe we should call this something like `errToReturn`?
+611,"@@ -215,7 +215,8 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch {
++	fairBankEpochNum := rp.GetEpochNum(hu.FairbankBlockHeight()) // extend foundation bonus from fairbank to fairbank + 1 year
++	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= fairBankEpochNum && epochNum <= fairBankEpochNum+a.foundationBonusLastEpoch) {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that"
+612,"@@ -350,14 +350,17 @@ const htmlElms = {
+       },
+       usemap: {
+         matches: '[usemap]',
+-        contentTypes: ['interactive', 'embedded', 'phrasing', 'flow']
++        contentTypes: ['interactive', 'embedded', 'flow']
+       },
+       default: {
+         // Note: allow role presentation and none on image with no
+         // alt as a way to prevent axe from flagging the image as
+         // needing an alt
+         allowedRoles: ['presentation', 'none'],
+-        contentTypes: ['embedded', 'phrasing', 'flow']
++        // Note: spec change (do not count as phrasing), because browsers
++        // insert a space between an img's accessible name and other
++        // elements' accessible names
++        contentTypes: ['embedded', 'flow']
+       }
+     },
+     // 5.10 img Element",I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used.
+613,"@@ -20,11 +20,13 @@
+ """"""
+ Geneve: Generic Network Virtualization Encapsulation
+
+-draft-ietf-nvo3-geneve-06
++draft-ietf-nvo3-geneve-16
+ """"""
+
++import struct
++
+ from scapy.fields import BitField, XByteField, XShortEnumField, X3BytesField, \
+-    XStrField
++    XStrField, XShortField, StrField, XByteField, FieldLenField, PacketListField
+ from scapy.packet import Packet, bind_layers
+ from scapy.layers.inet import IP, UDP
+ from scapy.layers.inet6 import IPv6","Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used"
+614,"@@ -630,6 +630,18 @@ class FilenamePrompt(_BasePrompt):
+
+         self._to_complete = ''
+
++    def _directories_hide_show_model(self, path):
++        """"""Get rid of non-matching directories.""""""
++        try:
++            num_rows = self._file_model.rowCount(self._root_index)
++            for row in range(num_rows):
++                index = self._file_model.index(row, 0, self._file_model.index(path))
++                hidden = self._to_complete not in index.data()
++                self._file_view.setRowHidden(index.row(), index.parent(), hidden)
++        except FileNotFoundError:
++            log.prompt.debug(""Directory doesn't exist, can't \
++                                hide and unhide file prompt folders"")
++
+     @pyqtSlot(str)
+     def _set_fileview_root(self, path, *, tabbed=False):
+         """"""Set the root path for the file display.""""""","I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?"
+615,"@@ -75,6 +75,8 @@ public class DirectSpellChecker {
+   private float thresholdFrequency = 0f;
+   /** minimum length of a query word to return suggestions */
+   private int minQueryLength = 4;
++  /** maximum length of a query word to return suggestions */
++  private int maxQueryLength = 0;
+   /** value in [0..1] (or absolute number &gt;= 1) representing the maximum
+    *  number of documents (of the total) a query term can appear in to
+    *  be corrected. */",Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?
+616,"@@ -81,7 +81,7 @@ namespace NLog.LayoutRenderers
+         {
+             if (TopFrames == 1)
+             {
+-                // Allows fast rendering of ${when:when='${ndc:topframes=1}' == '':inner=:else=${ndc}|}
++                // Allows fast rendering of ${ndc:topframes=1}
+                 var topFrame = NestedDiagnosticsContext.PeekObject();
+                 if (topFrame != null)
+                     AppendAsString(topFrame, GetFormatProvider(logEvent), builder);",:+1: that's a easier example :)
+617,"@@ -117,4 +117,9 @@ interface ProductQueryInterface
+      * @return AttributeId[]
+      */
+     public function findAttributeIdsByProductId(ProductId $productId): array;
++
++    /**
++     * @return array
++     */
++    public function findProductIdsWithBoundAttributeByAttributeId(AggregateId $id): array;
+ }","If an external module decorates this interface, such a change will cause it to generate an error"
+618,"@@ -254,7 +254,7 @@ static int jobtap_remove (struct jobtap *jobtap,
+     while (p) {
+         const char *name = jobtap_plugin_name (p);
+         if (all
+-            || (isglob && fnmatch (arg, name, 0) == 0)
++            || (isglob && fnmatch (arg, name, FNM_PERIOD) == 0)
+             || strcmp (arg, name) == 0) {
+             zlistx_detach_cur (jobtap->plugins);
+             flux_plugin_destroy (p);","Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention."
+619,"@@ -7,11 +7,12 @@
+ package action
+
+ import (
++	""encoding/hex""
+ 	""fmt""
+-	""math/big""
+-
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""
++	""math/big""
++	""strings""
+
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/account""","wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group."
+620,"@@ -78,8 +78,10 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) {
+ // Validate returns an error if the values provided by flags are invalid.
+ func (o *jobLogsOpts) Validate() error {
+ 	if o.appName != """" {
+-		_, err := o.configStore.GetApplication(o.appName)
+-		if err != nil {
++		if _, err := o.configStore.GetApplication(o.appName); err != nil {
++			return err
++		}
++		if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {
+ 			return err
+ 		}
+ 	}",Is `o.name` always set here?
+621,"@@ -73,7 +73,8 @@ func dependenciesCanBeResolved(target *api.Container, by []*api.Container) bool
+ 	}
+
+ 	return verifyStatusResolvable(target, nameMap, neededVolumeContainers, volumeCanResolve) &&
+-		verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve)
++		verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve) &&
++		verifyStatusResolvable(target, nameMap, target.SteadyStateDependencies, onSteadyStateCanResolve)
+ }
+
+ // DependenciesAreResolved validates that the `target` container can be","Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?"
+622,"@@ -73,7 +73,7 @@ class User < ActiveRecord::Base
+   end
+
+   def eligible_for_annual_upgrade?
+-    plan.present? && plan.has_annual_plan?
++    has_active_subscription? && plan.present? && plan.has_annual_plan?
+   end
+
+   def annualized_payment","`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`."
+623,"@@ -100,6 +100,7 @@ class Command:
+         if scope != 'global' and instance is None:
+             raise ValueError(""Setting scope without setting instance makes ""
+                              ""no sense!"")
++        # pylint: enable=too-many-locals
+
+         self.name = name
+         self.maxsplit = maxsplit","No need for this, as pylint already only turns things off for this function and it's needed for the entire function."
+624,"@@ -188,7 +188,7 @@ func (c *Operator) bootstrap(ctx context.Context) error {
+ 	}
+ 	c.secrInfs, err = informers.NewInformersForResource(
+ 		informers.NewKubeInformerFactories(
+-			c.config.Namespaces.AllowList,
++			c.config.Namespaces.AlertmanagerConfigAllowList,
+ 			c.config.Namespaces.DenyList,
+ 			c.kclient,
+ 			resyncPeriod,",L171 needs to be modified too?
+625,"@@ -19,6 +19,16 @@ See the file COPYING for details.
+ #include <stdlib.h>
+ #include <unistd.h>
+
++int dag_node_comp(void *item, const void *arg)
++{
++	struct dag_node *d = ((struct dag_node *) item);
++	struct dag_node *e = ((struct dag_node *) arg);
++
++	if(d->nodeid == e->nodeid)
++		return 1;
++	return 0;
++}
++
+ struct dag_node *dag_node_create(struct dag *d, int linenum)
+ {
+ 	struct dag_node *n;","Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong."
+626,"@@ -0,0 +1,18 @@
++_base_ = [
++    '../_base_/models/retinanet_r50_fpn.py',
++    '../_base_/datasets/coco_detection.py',
++    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
++]
++model = dict(
++    type='RetinaNet',
++    backbone=dict(
++        _delete_=True,
++        type='PyramidVisionTransformer',
++        num_layers=[2, 2, 2, 2],
++        init_cfg=dict(
++            type='Pretrained',
++            checkpoint='https://github.com/whai362/PVT/'
++            'releases/download/v2/pvt_tiny.pth')),
++    neck=dict(in_channels=[64, 128, 320, 512]))
++# optimizer
++optimizer = dict(_delete_=True, type='AdamW', lr=0.0001, weight_decay=0.0001)",configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py
+627,"@@ -20,7 +20,7 @@ type MetadataResponse struct {
+
+ type TaskResponse struct {
+ 	Arn           string
+-	DesiredStatus string
++	DesiredStatus string `json:""DesiredStatus,omitempty""`
+ 	KnownStatus   string
+ 	Family        string
+ 	Version       string","Nit, this could be json:"",omitempty"""
+628,"@@ -113,7 +113,12 @@ func tplDirName(s string) string {
+ 	return filepath.Dir(s)
+ }
+
+-//BuildArgs returns a docker.BuildArguments object given a ws root directory.
++// BuildRequired returns if the service requires building from the local Dockerfile.
++func (s *LoadBalancedWebService) BuildRequired() (bool, error) {
++	return buildRequired(s.Image.Image)
++}
++
++// BuildArgs returns a docker.BuildArguments object given a ws root directory.
+ func (s *LoadBalancedWebService) BuildArgs(wsRoot string) *DockerBuildArgs {
+ 	return s.Image.BuildConfig(wsRoot)
+ }",It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?
+629,"@@ -1,4 +1,4 @@
+-// +build integration
++// +build integration,deploy
+
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ // SPDX-License-Identifier: Apache-2.0",nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario
+630,"@@ -4701,8 +4701,8 @@ XS(XS_Mob_HasNPCSpecialAtk) {
+ XS(XS_Mob_SendAppearanceEffect); /* prototype to pass -Wmissing-prototypes */
+ XS(XS_Mob_SendAppearanceEffect) {
+ 	dXSARGS;
+-	if (items < 2 || items > 7)
+-		Perl_croak(aTHX_ ""Usage: Mob::SendAppearanceEffect(THIS, int32 param_1, [int32 param_2 = 0], [int32 param_3 = 0], [int32 param_4 = 0], [int32 param_5 = 0], [Client* single_client_to_send_to = null])""); // @categories Script Utility
++	if (items < 2 || items > 17)
++		Perl_croak(aTHX_ ""Usage: Mob::SendAppearanceEffect(THIS, int32 effect1, [int32 effect2 = 0], [int32 effect3 = 0], [int32 effect4 = 0], [int32 effect5 = 0], [Client* single_client_to_send_to = null]), [uint32 slot1 = 1], [uint32 ground1 = 1], [uint32 slot2 = 1], [uint32 ground2 = 1], [uint32 slot3 = 1], [uint32 ground2 = 1], [uint32 slot4 = 1], [uint32 ground4 = 1], [uint32 slot5 = 1], [uint32 ground5 = 1]""); // @categories Script Utility
+ 	{
+ 		Mob *THIS;
+ 		int32 parm1 = (int32) SvIV(ST(1));",Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others.
+631,"@@ -16,11 +16,12 @@
+
+ using System.Collections.Generic;
+ using Nethermind.Core;
++using Nethermind.Core.Crypto;
+
+ namespace Nethermind.Consensus
+ {
+     public interface IPendingTxSelector
+     {
+-        IEnumerable<Transaction> SelectTransactions(long gasLimit);
++        IEnumerable<Transaction> SelectTransactions(Keccak stateRoot, long gasLimit);
+     }
+ }",stateRoot or maybe ParentHeader would make more sense from API point of view?
+632,"@@ -151,7 +151,6 @@ public class PlaybackServiceFlavorHelper {
+                 // hardware volume buttons control the local device volume
+                 mediaRouter.setMediaSessionCompat(null);
+                 unregisterWifiBroadcastReceiver();
+-                callback.setupNotification(false, info);
+             }
+         };
+     }",Are you sure that this is no longer needed?
+633,"@@ -57,7 +57,11 @@ class BaseTableScan implements TableScan {
+   private static final Logger LOG = LoggerFactory.getLogger(TableScan.class);
+
+   private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat(""yyyy-MM-dd HH:mm:ss.SSS"");
+-  private static final List<String> SNAPSHOT_COLUMNS = ImmutableList.of(
++  private static final List<String> SCAN_COLUMNS = ImmutableList.of(
++      ""snapshot_id"", ""file_path"", ""file_ordinal"", ""file_format"", ""block_size_in_bytes"",
++      ""file_size_in_bytes"", ""record_count"", ""partition""
++  );
++  private static final List<String> SCAN_WITH_STATS_COLUMNS = ImmutableList.of(
+       ""snapshot_id"", ""file_path"", ""file_ordinal"", ""file_format"", ""block_size_in_bytes"",
+       ""file_size_in_bytes"", ""record_count"", ""partition"", ""value_counts"", ""null_value_counts"",
+       ""lower_bounds"", ""upper_bounds""","Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.<String>builder().addAll(SCAN_COLUMNS).add(""value_counts"",....).build()` ?"
+634,"@@ -85,11 +85,19 @@ func (a *PipedAPI) Register(server *grpc.Server) {
+
+ // Ping is periodically sent to report its realtime status/stats to control-plane.
+ // The received stats will be pushed to the metrics collector.
++// Note: This service is deprecated, use ReportStat instead.
+ func (a *PipedAPI) Ping(ctx context.Context, req *pipedservice.PingRequest) (*pipedservice.PingResponse, error) {
+ 	return &pipedservice.PingResponse{}, nil
+ 	// return nil, status.Error(codes.Unimplemented, """")
+ }
+
++// ReportStat is periodically sent to report its realtime status/stats to control-plane.
++// The received stats will be pushed to the metrics collector.
++func (a *PipedAPI) ReportStat(ctx context.Context, req *pipedservice.ReportStatRequest) (*pipedservice.ReportStatResponse, error) {
++	return &pipedservice.ReportStatResponse{}, nil
++	// return nil, status.Error(codes.Unimplemented, """")
++}
++
+ // ReportPipedMeta is sent by piped while starting up to report its metadata
+ // such as configured cloud providers.
+ func (a *PipedAPI) ReportPipedMeta(ctx context.Context, req *pipedservice.ReportPipedMetaRequest) (*pipedservice.ReportPipedMetaResponse, error) {",`ctx` is unused in ReportStat
+635,"@@ -21,12 +21,15 @@
+ #include <fstream>
+ #include <iostream>
+ #include <vector>
++#include <list>
++#include <map>
+
+ #include <stdlib.h>
+ #include <sys/stat.h>
+ #include <sys/types.h>
+ #include <sstream>
+ #include <algorithm>
++
+ #include ""t_generator.h""
+ #include ""platform.h""
+ #include ""version.h""",We don't want to add boost as a dependency when building the Thrift compiler. Sorry.
+636,"@@ -323,7 +323,8 @@ bool Monsters::deserializeSpell(const pugi::xml_node& node, spellBlock_t& sb, co
+ 			combat->setParam(COMBAT_PARAM_TYPE, COMBAT_HEALING);
+ 			combat->setParam(COMBAT_PARAM_AGGRESSIVE, 0);
+ 		} else if (tmpName == ""speed"") {
+-			int32_t speedChange = 0;
++			int32_t minSpeedChange = 0;
++			int32_t maxSpeedChange = 0;
+ 			int32_t duration = 10000;
+
+ 			if ((attr = node.attribute(""duration""))) {",It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000.
+637,"@@ -332,3 +332,15 @@ func (c *clusterClient) SchedPolicyDelete(name string) error {
+
+ 	return nil
+ }
++
++// SchedPolicyGet returns schedule policy matching given name.
++func (c *clusterClient) SchedPolicyGet(name string) (*sched.SchedPolicy, error) {
++	policy := new(sched.SchedPolicy)
++	req := c.c.Get().Resource(clusterPath + SchedPath + ""/"" + name)
++
++	if err := req.Do().Unmarshal(policy); err != nil {
++		return nil, err
++	}
++
++	return policy, nil
++}",if name is empty will this become enumerate ? (and cause the unmarshal to fail ?)
+638,"@@ -15,7 +15,7 @@ module ProductsHelper
+     if current_user_has_access_to?(:exercises)
+       link_to url, options, &block
+     else
+-      content_tag ""a"", &block
++      link_to edit_subscription_path, options, &block
+     end
+   end
+ end",How about including a flash message that explains the exercises are only available to subscribers of X plan?
+639,"@@ -232,6 +232,11 @@ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
+         Enter/Shift+Enter/etc. will cause QLineEdit to think it's finished
+         without command_accept to be called.
+         """"""
++        text = self.text()
++        if text in modeparsers.STARTCHARS and e.key() == Qt.Key_Backspace:
++            modeman.leave(self._win_id, usertypes.KeyMode.command,
++                          'prefix deleted')
++
+         if e.key() == Qt.Key_Return:
+             e.ignore()
+             return",You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways).
+640,"@@ -0,0 +1,14 @@
++MAIL_SETTINGS = {
++  address: ""smtp.sendgrid.net"",
++  port: ""587"",
++  authentication: :plain,
++  user_name: ENV[""SENDGRID_USERNAME""],
++  password: ENV[""SENDGRID_PASSWORD""],
++  domain: ""heroku.com""
++}
++
++if ENV[""EMAIL_RECIPIENTS""]
++  Mail.register_interceptor(
++    RecipientInterceptor.new(ENV.fetch(""EMAIL_RECIPIENTS"")),
++  )
++end",Freeze mutable objects assigned to constants.
+641,"@@ -34,8 +34,11 @@ import {
+
+ async function toggleOptIn() {
+ 	await page.waitForSelector( '#googlesitekit-opt-in' );
+-	await expect( page ).toClick( '#googlesitekit-opt-in' );
+-	await page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) );
++	await pageWait();
++	await Promise.all( [
++		page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) ),
++		expect( page ).toClick( '#googlesitekit-opt-in' ),
++	] );
+ }
+
+ describe( 'management of tracking opt-in/out via settings page', () => {","Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?"
+642,"@@ -144,6 +144,12 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation
+                 {
+                     activity.SetTag(SemanticConventions.AttributeHttpUserAgent, userAgent);
+                 }
++
++                var xForwardedFor = request.Headers[""X-Forwarded-For""].FirstOrDefault();
++                if (!string.IsNullOrEmpty(xForwardedFor))
++                {
++                    activity.SetTag(SemanticConventions.AttributeHttpClientIP, xForwardedFor.Split(',').First().Trim());
++                }
+             }
+         }
+ ","Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags."
+643,"@@ -91,7 +91,7 @@ int main(int argc, char *argv[]) {
+     }
+
+     LOG(INFO) << ""Starting Graph HTTP Service"";
+-    nebula::WebService::registerHandler(""/graph"", [] {
++    nebula::WebService::registerHandler(""/status"", [] {
+         return new nebula::graph::GraphHttpHandler();
+     });
+     status = nebula::WebService::start();","`status` is just one of the features, named as status is not suitable."
+644,"@@ -296,9 +296,17 @@ public class NavListAdapter extends BaseAdapter
+                 .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
+
+         convertView = inflater.inflate(R.layout.nav_section_item, parent, false);
++        TextView feedsFilteredMsg = convertView.findViewById(R.id.nav_feeds_filtered_message);
+
+-        convertView.setEnabled(false);
+-        convertView.setOnClickListener(null);
++        if (UserPreferences.getFeedFilter() != UserPreferences.FEED_FILTER_NONE) {
++            convertView.setEnabled(true);
++            feedsFilteredMsg.setText(""{md-info-outline} "" + context.getString(R.string.feed_is_filtered));
++            Iconify.addIcons(feedsFilteredMsg);
++            feedsFilteredMsg.setVisibility(View.VISIBLE);
++        } else {
++            convertView.setEnabled(false);
++            feedsFilteredMsg.setVisibility(View.GONE);
++        }
+
+         return convertView;
+     }","There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed."
+645,"@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""query/useCircuitBreakers"", false);
++    memoryCircuitBreakerThreshold = getInt(""query/memoryCircuitBreakerThreshold"", 100);
++
++    validateMemoryBreakerThreshold();
+
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ","I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate."
+646,"@@ -57,8 +57,6 @@ extern Events* g_events;
+ extern Chat* g_chat;
+ extern LuaEnvironment g_luaEnvironment;
+
+-using ErrorCode = boost::system::error_code;
+-
+ Signals::Signals(boost::asio::io_service& service) :
+ 	set(service)
+ {",move the constructor to down the `namespace`
+647,"@@ -123,6 +123,10 @@ type ClusterDeploymentStatus struct {
+ 	// Federated is true if the cluster deployment has been federated with the host cluster.
+ 	Federated bool `json:""federated,omitempty""`
+
++	// FederatedClusterRef is the reference to the federated cluster resource associated with
++	// this ClusterDeployment
++	FederatedClusterRef *corev1.ObjectReference `json:""federatedClusterRef,omitempty""`
++
+ 	// AdminKubeconfigSecret references the secret containing the admin kubeconfig for this cluster.
+ 	AdminKubeconfigSecret corev1.LocalObjectReference `json:""adminKubeconfigSecret,omitempty""`
+ ",Nit: ending with a '.' looks consistent with the fields around it.
+648,"@@ -138,7 +138,7 @@ func (s *Service) MintX509SVID(ctx context.Context, req *svidv1.MintX509SVIDRequ
+ }
+
+ func (s *Service) MintJWTSVID(ctx context.Context, req *svidv1.MintJWTSVIDRequest) (*svidv1.MintJWTSVIDResponse, error) {
+-	rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(req.Id, req.Audience, req.Ttl))
++	rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(ctx, req.Id, req.Audience, req.Ttl))
+ 	jwtsvid, err := s.mintJWTSVID(ctx, req.Id, req.Audience, req.Ttl)
+ 	if err != nil {
+ 		return nil, err","Audit log will not have a warning about they are using a deprecated path, is it something we must care about?"
+649,"@@ -23,7 +23,7 @@ namespace Microsoft.Cci.Differs.Rules
+             // If implementation is protected then contract must be protected as well.
+             if (impl.Visibility == TypeMemberVisibility.Family)
+             {
+-                if (contract.Visibility != TypeMemberVisibility.Family)
++                if (contract.Visibility != TypeMemberVisibility.Family && contract.Visibility != TypeMemberVisibility.FamilyOrAssembly)
+                 {
+                     differences.AddIncompatibleDifference(this,
+                         ""Visibility of member '{0}' is '{1}' in the implementation but '{2}' in the contract."",",I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`.
+650,"@@ -18,7 +18,10 @@ import (
+ )
+
+ var (
+-	depositToRewardingFundBaseGas = uint64(10000)
++	// DepositToRewardingFundBaseGas represents the base intrinsic gas for depositToRewardingFund
++	DepositToRewardingFundBaseGas = uint64(10000)
++	// DepositToRewardingFundGasPerByte represents the depositToRewardingFund payload gas per uint
++	DepositToRewardingFundGasPerByte = uint64(100)
+ )
+
+ // DepositToRewardingFund is the action to deposit to the rewarding fund",`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)
+651,"@@ -3,12 +3,14 @@
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ // SPDX-License-Identifier: Apache-2.0
+
+-// Package groups contains the names of command groups
++// Package groups contains the names of command groups.
+ package group
+
++// Categories for each top level command in the CLI.
+ const (
+-	GettingStarted = ""Getting Started ✨""
+-	Develop        = ""Develop 🔧""
++	GettingStarted = ""Getting Started 🌱""
++	Develop        = ""Develop ✨""
+ 	Settings       = ""Settings ⚙️""
++	Operational    = ""Operational 🧐""
+ 	Release        = ""Release 🚀""
+ )","What do you think of ""operations""?? Also what do these emojis look like on Linux??"
+652,"@@ -0,0 +1,16 @@
++<% content_for :subject_block do %>
++  <h1><%= t('shared.subscription.name') %> for Teams</h1>
++  <h2 class=""tagline"">
++    Sign your team up for <%= t('shared.subscription.name') %> today, and give them the finest Ruby on Rails content and the best expert teachers.
++  </h2>
++<% end %>
++
++<p>Your team gets all of the great benefits of <%= link_to t('shared.subscription.name'), prime_path %>, with convenient monthly group billing, as well as a nice discount. <%= t('shared.subscription.name') %> Teams have a minimum of 5 members, and a 10% discount off the normal price. New members can be added at any time.</p>
++
++<section class=""plans"">
++  <%= render @plans %>
++</section>
++
++<span class=""prime-aside-links"">
++  <%= link_to ""View all the features of #{t('shared.subscription.name')}"", prime_path %>
++</span>","I like the word ""give"" here. Feels like I'm giving a gift to my team."
+653,"@@ -11,12 +11,16 @@ import numpy as np
+ from sklearn import __version__ as sk_version
+ from sklearn.base import clone
+ from sklearn.datasets import (load_boston, load_breast_cancer, load_digits,
+-                              load_iris, load_svmlight_file)
++                              load_iris, load_linnerud, load_svmlight_file,
++                              make_multilabel_classification)
+ from sklearn.exceptions import SkipTestWarning
+ from sklearn.metrics import log_loss, mean_squared_error
+-from sklearn.model_selection import GridSearchCV, train_test_split
++from sklearn.model_selection import GridSearchCV, RandomizedSearchCV, train_test_split
++from sklearn.multioutput import (MultiOutputClassifier, ClassifierChain, MultiOutputRegressor,
++                                 RegressorChain)
+ from sklearn.utils.estimator_checks import (_yield_all_checks, SkipTest,
+                                             check_parameters_default_constructible)
++from scipy.stats import randint, uniform
+
+
+ decreasing_generator = itertools.count(0, -1)",Is it possible to use `np.random` module instead?
+654,"@@ -49,7 +49,7 @@ legend_dimensions = ['label_standoff', 'label_width', 'label_height', 'glyph_wid
+
+ class ElementPlot(BokehPlot, GenericElementPlot):
+
+-    bgcolor = param.Parameter(default='white', doc=""""""
++    bgcolor = param.Parameter(default=None, allow_None=True, doc=""""""
+         Background color of the plot."""""")
+
+     border = param.Number(default=10, doc=""""""","``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed."
+655,"@@ -551,8 +551,8 @@ func genClientCerts(config *config.Control, runtime *config.ControlRuntime) erro
+ 	if _, err = factory(""system:kube-proxy"", nil, runtime.ClientKubeProxyCert, runtime.ClientKubeProxyKey); err != nil {
+ 		return err
+ 	}
+-	// this must be hardcoded to k3s-controller because it's hard coded in the rolebindings.yaml
+-	if _, err = factory(""system:k3s-controller"", nil, runtime.ClientK3sControllerCert, runtime.ClientK3sControllerKey); err != nil {
++	// This user (system:k3s-controller by default) must be bound to a role in rolebindings.yaml or the downstream equivalent
++	if _, err = factory(""system:""+version.Program+""-controller"", nil, runtime.ClientK3sControllerCert, runtime.ClientK3sControllerKey); err != nil {
+ 		return err
+ 	}
+ ",Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand.
+656,"@@ -21,7 +21,7 @@ import (
+ 	""strings""
+ 	""time""
+
+-	acd ""github.com/ncw/go-acd""
++	""github.com/ncw/go-acd""
+ 	""github.com/ncw/rclone/fs""
+ 	""github.com/ncw/rclone/fs/config""
+ 	""github.com/ncw/rclone/fs/config/configmap""",File is not `goimports`-ed (from `goimports`)
+657,"@@ -0,0 +1,15 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++namespace Reporting
++{
++    public class Os
++    {
++        public string Locale { get; set; }
++
++        public string Architecture { get; set; }
++
++        public string Name { get; set; }
++    }
++}","nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?"
+658,"@@ -16,7 +16,7 @@
+ #include <GraphMol/SmilesParse/SmilesParse.h>
+ #include <GraphMol/FileParsers/FileParsers.h>
+ #include <Geometry/point.h>
+-#include ""MolTransforms.h""
++#include <GraphMol/MolTransforms/MolTransforms.h>
+
+ using namespace RDKit;
+ using namespace MolTransforms;",Why is this needed here?
+659,"@@ -192,7 +192,7 @@ public interface Context {
+                 methodUsage = ((TypeVariableResolutionCapability) methodDeclaration)
+                                       .resolveTypeVariables(this, argumentsTypes);
+             } else {
+-                throw new UnsupportedOperationException();
++                return Optional.empty();
+             }
+
+             return Optional.of(methodUsage);","mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?"
+660,"@@ -32,8 +32,8 @@ public class EeaSendRawTransaction extends PrivacySendTransaction {
+
+   public EeaSendRawTransaction(
+       final PrivacyParameters privacyParameters,
+-      final PrivateTransactionHandler privateTransactionHandler,
+-      final TransactionPool transactionPool) {
++      final TransactionPool transactionPool,
++      final PrivateTransactionHandler privateTransactionHandler) {
+     super(privacyParameters, privateTransactionHandler, transactionPool);
+   }
+ ",nit: any reason you swapped the ordering?
+661,"@@ -4,7 +4,7 @@ define([""jQuery"", ""loading"", ""globalize"", ""dom""], function($, loading, globalize
+     function loadPage(page, config, systemInfo) {
+         Array.prototype.forEach.call(page.querySelectorAll("".chkDecodeCodec""), function(c) {
+             c.checked = -1 !== (config.HardwareDecodingCodecs || []).indexOf(c.getAttribute(""data-codec""))
+-        }), page.querySelector(""#chkHardwareEncoding"").checked = config.EnableHardwareEncoding, $(""#selectVideoDecoder"", page).val(config.HardwareAccelerationType), $(""#selectThreadCount"", page).val(config.EncodingThreadCount), $(""#txtDownMixAudioBoost"", page).val(config.DownMixAudioBoost), page.querySelector("".txtEncoderPath"").value = config.EncoderAppPath || """", $(""#txtTranscodingTempPath"", page).val(config.TranscodingTempPath || """"), $(""#txtVaapiDevice"", page).val(config.VaapiDevice || """"), page.querySelector(""#selectH264Preset"").value = config.H264Preset || """", page.querySelector(""#txtH264Crf"").value = config.H264Crf || """", page.querySelector(""#chkEnableSubtitleExtraction"").checked = config.EnableSubtitleExtraction || !1, page.querySelector(""#selectVideoDecoder"").dispatchEvent(new CustomEvent(""change"", {
++        }), page.querySelector(""#chkHardwareEncoding"").checked = config.EnableHardwareEncoding, $(""#selectVideoDecoder"", page).val(config.HardwareAccelerationType), $(""#selectThreadCount"", page).val(config.EncodingThreadCount), $(""#txtDownMixAudioBoost"", page).val(config.DownMixAudioBoost), page.querySelector("".txtEncoderPath"").value = config.EncoderAppPathDisplay || """", $(""#txtTranscodingTempPath"", page).val(config.TranscodingTempPath || """"), $(""#txtVaapiDevice"", page).val(config.VaapiDevice || """"), page.querySelector(""#selectH264Preset"").value = config.H264Preset || """", page.querySelector(""#txtH264Crf"").value = config.H264Crf || """", page.querySelector(""#chkEnableSubtitleExtraction"").checked = config.EnableSubtitleExtraction || !1, page.querySelector(""#selectVideoDecoder"").dispatchEvent(new CustomEvent(""change"", {
+             bubbles: !0
+         })), loading.hide()
+     }",can you de-uglify at least this line?.. hard to tell what changed...
+662,"@@ -354,13 +354,10 @@ type BPFDataplane interface {
+ 	RemoveXDP(ifName string, mode XDPMode) error
+ 	UpdateCIDRMap(ifName string, family IPFamily, ip net.IP, mask int, refCount uint32) error
+ 	UpdateFailsafeMap(proto uint8, port uint16) error
+-	loadXDPRaw(objPath, ifName string, mode XDPMode, mapArgs []string) error
+ 	GetBPFCalicoDir() string
+ 	AttachToSockmap() error
+ 	DetachFromSockmap(mode FindObjectMode) error
+ 	RemoveSockmap(mode FindObjectMode) error
+-	loadBPF(objPath, progPath, progType string, mapArgs []string) error
+-	LoadSockops(objPath string) error
+ 	LoadSockopsWithBytes(objBytes []byte) error
+ 	LoadSockopsAuto() error
+ 	RemoveSockops() error",Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code.
+663,"@@ -66,3 +66,14 @@ class MyCls:
+     @classmethod
+     def get_class_var(cls):
+         return cls.__class_var
++
++
++class Bla:
++    """"""Regression test for issue 4638""""""
++
++    def __init__(self):
++        type(self).__a()
++
++    @classmethod
++    def __a(cls):
++        pass",Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`)
+664,"@@ -462,7 +462,7 @@ def search(collection, p, of, ot, so, rm):
+
+     ctx = dict(
+         facets=facets.get_facets_config(collection, qid),
+-        records=len(get_current_user_records_that_can_be_displayed(qid)),
++        records=len(recids),
+         qid=qid, rg=rg,
+         create_nearest_terms_box=lambda: _create_neareset_term_box(argd_orig),
+         easy_search_form=EasySearchForm(csrf_enabled=False),","the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)"
+665,"@@ -669,7 +669,15 @@ func (b *Bucket) newRangeReader(ctx context.Context, key string, offset, length
+
+ // WriteAll is a shortcut for creating a Writer via NewWriter and writing p.
+ func (b *Bucket) WriteAll(ctx context.Context, key string, p []byte, opts *WriterOptions) (err error) {
+-	w, err := b.NewWriter(ctx, key, opts)
++	realOpts := new(WriterOptions)
++	if opts != nil {
++		*realOpts = *opts
++	}
++	if len(realOpts.ContentMD5) == 0 {
++		sum := md5.Sum(p)
++		realOpts.ContentMD5 = sum[:]
++	}
++	w, err := b.NewWriter(ctx, key, realOpts)
+ 	if err != nil {
+ 		return err
+ 	}","Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?"
+666,"@@ -143,6 +143,9 @@ def executeEvent(eventName,obj,**kwargs):
+ 	@param kwargs: Additional event parameters as keyword arguments.
+ 	""""""
+ 	try:
++		# Allow NVDAObjects to redirect focus events to another object of their choosing.
++		if eventName==""gainFocus"" and obj.focusRedirect:
++			obj=obj.focusRedirect
+ 		sleepMode=obj.sleepMode
+ 		if eventName==""gainFocus"" and not doPreGainFocus(obj,sleepMode=sleepMode):
+ 			return","focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!"
+667,"@@ -21,6 +21,8 @@ import (
+ 	""encoding/base64""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/config""
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/gcp_clients""
+ 	""io""
+ 	""log""
+ 	""path""",You imports are out of order
+668,"@@ -45,7 +45,7 @@ import org.slf4j.LoggerFactory;
+ public class QuartzScheduler {
+
+   //Unless specified, all Quartz jobs's identities comes with the default job name.
+-  private static final String DEFAULT_JOB_NAME = ""job1"";
++  public static final String DEFAULT_JOB_NAME = ""job1"";
+   private static final Logger logger = LoggerFactory.getLogger(QuartzScheduler.class);
+   private Scheduler scheduler = null;
+ ","This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, ""flowtrigger"""
+669,"@@ -0,0 +1,19 @@
++// Copyright (c) 2018 IoTeX
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package sqlite3
++
++import (
++	""github.com/iotexproject/iotex-core/config""
++	""github.com/iotexproject/iotex-core/db""
++	// this is required for sqlite3 usage
++	_ ""github.com/mattn/go-sqlite3""
++)
++
++// NewSQLite3 instantiates an sqlite3
++func NewSQLite3(cfg *config.SQLITE3) db.Store {
++	return db.NewSQLBase(""sqlite3"", cfg.SQLite3File)
++}",File is not `goimports`-ed (from `goimports`)
+670,"@@ -30,6 +30,10 @@ public partial class Program
+
+     public static void Stress(int concurrency = 0)
+     {
++#if DEBUG
++        Console.WriteLine(""***WARNING*** The current build is DEBUG which may affect timing!\n"");
++#endif
++
+         if (concurrency < 0)
+         {
+             throw new ArgumentOutOfRangeException(nameof(concurrency), ""concurrency level should be a non-negative number."");",Why do we need `\n` if we already use `WriteLine`? (and `\n` is not cross platform)
+671,"@@ -30,12 +30,15 @@ import com.google.common.base.MoreObjects;
+ public class MetricsConfiguration {
+   private static final String DEFAULT_METRICS_HOST = ""127.0.0.1"";
+   public static final int DEFAULT_METRICS_PORT = 9545;
+-
++  private static final String DEFAULT_INSTRUMENTATION_NAME = ""besu"";
++  private static final String DEFAULT_METRICS_PROTOCOL = ""prometheus"";
+   private static final String DEFAULT_METRICS_PUSH_HOST = ""127.0.0.1"";
+   public static final int DEFAULT_METRICS_PUSH_PORT = 9001;
+   public static final Boolean DEFAULT_TIMERS_ENABLED = true;
+
+   private final boolean enabled;
++  private final String instrumentationName;
++  private final String protocol;
+   private final int port;
+   private int actualPort;
+   private final String host;","What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder."
+672,"@@ -21,8 +21,10 @@ namespace Nethermind.TxPool.Collections
+ {
+     public partial class SortedPool<TKey, TValue, TGroupKey>
+     {
++#pragma warning disable 67
+         public event EventHandler<SortedPoolEventArgs>? Inserted;
+         public event EventHandler<SortedPoolRemovedEventArgs>? Removed;
++#pragma warning restore 67
+
+         public class SortedPoolEventArgs
+         {",@kristofgazso could you review these warnings?
+673,"@@ -0,0 +1,3 @@
++require(""child_process"");
++
++console.log(""hi"");",will delete this.
+674,"@@ -104,9 +104,9 @@ module PurchasesHelper
+
+   def new_plan_link(plan)
+     link_to(
+-       I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe,
+-       new_individual_plan_purchase_path(plan),
+-       class: 'button'
++      I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe,
++      new_individual_plan_purchase_path(plan),
++      class: 'button'
+     )
+   end
+ end",~~Indent 2 lines above~~ Disregard. My fault
+675,"@@ -366,7 +366,7 @@ public class InitCodeTransformer {
+         default:
+           throw new UnsupportedOperationException(""unexpected entity name type"");
+       }
+-    } else if (initValueConfig.hasFormattingConfig()) {
++    } else if (initValueConfig.hasFormattingConfig() && !item.getType().isRepeated()) {
+       if (context.getFeatureConfig().enableStringFormatFunctions()) {
+         FormattedInitValueView.Builder initValue = FormattedInitValueView.newBuilder();
+ ",What was the bug that this is fixing?
+676,"@@ -471,6 +471,9 @@ class RemoteConnection(object):
+             request.add_header('Accept', 'application/json')
+             request.add_header('Content-Type', 'application/json;charset=UTF-8')
+
++            base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))
++            request.add_header(""Authorization"", ""Basic %s"" % base64string)
++
+             if password_manager:
+                 opener = url_request.build_opener(url_request.HTTPRedirectHandler(),
+                                                   HttpErrorHandler(),","This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'"
+677,"@@ -50,7 +50,12 @@ uint32_t lcg_rand() {
+ }
+ void lcg_reset() { lcg_seed = 48271; }
+
+-std::string test_data_path = ""tests/"";
++std::string test_data_path =
++#ifdef BAZEL_TEST_DATA_PATH
++    ""../com_github_google_flatbuffers/tests/"";
++#else
++    ""tests/"";
++#endif
+
+ // example of how to build up a serialized buffer algorithmically:
+ flatbuffers::DetachedBuffer CreateFlatBufferTest(std::string &buffer) {",Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?
+678,"@@ -169,7 +169,9 @@ class ElasticsearchTarget(luigi.Target):
+
+         The document id would be sufficient but,
+         for documentation,
+-        we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well.
++        we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well.  `date_utc` added
++        so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the
++        client machine.
+         """"""
+         self.create_marker_index()
+         self.es.index(index=self.marker_index, doc_type=self.marker_doc_type,","Not an expert of ES, so not sure of the impact here."
+679,"@@ -1665,10 +1665,10 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs(
+   if (ComUser::isRootUserID())
+     return FALSE;
+
+-  // any user granted the DB__ROOTROLE sees everything
+   Int32 numRoles;
+   Int32 *roleList;
+-  if (currContext->getRoleList(numRoles, roleList) == SUCCESS)
++  Int32 *granteeList;
++  if (currContext->getRoleList(numRoles, roleList, granteeList) == SUCCESS)
+   {
+     char authIDAsChar[sizeof(Int32)+10];
+     NAString auths;",Who deletes the memory for the granteeList? (or the roleList for that matter)
+680,"@@ -13,6 +13,11 @@ ws_listener (listener_a), ws (std::move (socket_a)), write_strand (ws.get_execut
+
+ nano::websocket::session::~session ()
+ {
++	for (auto & subscription : subscriptions)
++	{
++		ws_listener.decrease_subscription_count (subscription);
++	}
++
+ 	ws_listener.get_node ().logger.try_log (""websocket session ended"");
+ }
+ ",This loop is missing a lock on subscriptions_mutex.
+681,"@@ -62,7 +62,9 @@ Workshops::Application.routes.draw do
+   match '/backbone-js-on-rails' => redirect(""/products/1-backbone-js-on-rails"")
+
+   match '/rubyist-booster-shot' => ""high_voltage/pages#show"", as: :rubyist_booster_shot, id: ""rubyist-booster-shot""
+-  match 'sign_in'  => 'sessions#new', as: 'sign_in'
++  match '/sign_up' => 'users#new', as: 'sign_up'
++  match '/sign_in' => 'sessions#new', as: 'sign_in'
++  match '/sign_out' => 'sessions#destroy', as: 'sign_out', via: :delete
+
+   mount Split::Dashboard, at: 'split'
+ ",shouldn't clearance be setting these up for us?
+682,"@@ -46,6 +46,10 @@ type (
+ 	}
+
+ 	defaultServiceNameDetector struct{}
++
++	// noOp is a Detector that only provides an empty resource.  Used
++	// to disable automatic detection.
++	noOp struct{}
+ )
+
+ var (",Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions.
+683,"@@ -55,12 +55,6 @@ public final class ASTRecordDeclaration extends AbstractAnyTypeDeclaration {
+         return isNested() || isLocal();
+     }
+
+-    @Override
+-    public boolean isFinal() {
+-        // A record is implicitly final
+-        return true;
+-    }
+-
+     @Override
+     public boolean isLocal() {
+         return getParent() instanceof ASTBlockStatement;",I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected
+684,"@@ -2444,6 +2444,11 @@ angular.module('ui.grid')
+           //   to get the full position we need
+           scrollPixels = self.renderContainers.body.prevScrollTop - (topBound - pixelsToSeeRow);
+
++          //Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop.
++          if (gridCol.colDef.enableCellEditOnFocus === true) {
++            scrollPixels = scrollPixels - self.footerHeight - self.scrollbarWidth;
++          }
++
+           scrollEvent.y = getScrollY(scrollPixels, scrollLength, self.renderContainers.body.prevScrolltopPercentage);
+         }
+         // Otherwise if the scroll position we need to see the row is MORE than the bottom boundary, i.e. obscured below the bottom of the self...",Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?
+685,"@@ -23,6 +23,7 @@ import com.playonlinux.common.dtos.*;
+ import com.playonlinux.domain.PlayOnLinuxError;
+ import com.playonlinux.injection.Scan;
+ import com.playonlinux.injection.Inject;
++import com.playonlinux.ui.api.InstallerFilter;
+ import com.playonlinux.webservice.RemoteAvailableInstallers;
+
+ import java.net.MalformedURLException;",You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?
+686,"@@ -42,7 +42,7 @@ const (
+ 	templateCreateWorkflowExecutionClosed = `INSERT INTO executions_visibility (` +
+ 		`namespace_id, workflow_id, run_id, start_time, execution_time, workflow_type_name, close_time, status, history_length, memo, encoding) ` +
+ 		`VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ` +
+-		`ON DUPLICATE KEY UPDATE start_time = VALUES(start_time), execution_time = VALUES(execution_time), workflow_type_name = VALUES(workflow_type_name), ` +
++		`ON DUPLICATE KEY UPDATE workflow_id = VALUES(workflow_id), start_time = VALUES(start_time), execution_time = VALUES(execution_time), workflow_type_name = VALUES(workflow_type_name), ` +
+ 		`close_time = VALUES(close_time), status = VALUES(status), history_length = VALUES(history_length), memo = VALUES(memo), encoding = VALUES(encoding)`
+
+ 	// RunID condition is needed for correct pagination","This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key."
+687,"@@ -4520,7 +4520,9 @@ RelExpr * GenericUpdate::preCodeGen(Generator * generator,
+     {
+       oltOptInfo().setOltOpt(FALSE);
+       generator->oltOptInfo()->setOltOpt(FALSE);
+-      generator->setAqrEnabled(FALSE);
++      //enabling AQR to take care of the lock conflict error 8558 that
++      // should be retried.
++      //      generator->setAqrEnabled(FALSE);
+       generator->setUpdAbortOnError(TRUE);
+       generator->setUpdSavepointOnError(FALSE);
+     }",How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?
+688,"@@ -6,9 +6,11 @@ import (
+ 	""net""
+ 	""os""
+
+-	sds_v2 ""github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2""
++	discovery_v2 ""github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2""
++	secret_v3 ""github.com/envoyproxy/go-control-plane/envoy/service/secret/v3""
+ 	attestor ""github.com/spiffe/spire/pkg/agent/attestor/workload""
+-	""github.com/spiffe/spire/pkg/agent/endpoints/sds""
++	""github.com/spiffe/spire/pkg/agent/endpoints/sds/sdsv2""
++	""github.com/spiffe/spire/pkg/agent/endpoints/sds/sdsv3""
+ 	""github.com/spiffe/spire/pkg/agent/endpoints/workload""
+ 	""github.com/spiffe/spire/pkg/common/peertracker""
+ 	""github.com/spiffe/spire/pkg/common/telemetry""","Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter"
+689,"@@ -927,7 +927,7 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
+     if (isFunction(beforeChangeResult)) {
+       warn('Your beforeChange callback returns a function. It\'s not supported since Handsontable 0.12.1 (and the returned function will not be executed).');
+
+-    } else if (beforeChangeResult === false) {
++    } else if (beforeChangeResult === false || beforeChangeResult.length === 0 || beforeChangeResult[0] === null) {
+       const activeEditor = instance.getActiveEditor();
+
+       if (activeEditor) {",Please check also whether `null` occurs in the rest of `beforeChangeResult` array.
+690,"@@ -22,9 +22,10 @@ package transport
+
+ import ""context""
+
+-// Filter defines transport-level middleware for Outbounds.
++// UnaryFilter defines transport-level middleware for `UnaryOutbound`s.
++// Note: this is client side.
+ //
+-// Filters MAY
++// UnaryFilter MAY
+ //
+ // - change the context
+ // - change the request","Outdated docs. There is no response, there's an ack."
+691,"@@ -27,7 +27,7 @@ your host.`,
+ 		}
+ 		switch status {
+ 		case libcontainer.Created:
+-			return container.Signal(libcontainer.InitContinueSignal)
++			return container.Exec()
+ 		case libcontainer.Stopped:
+ 			return fmt.Errorf(""cannot start a container that has run and stopped"")
+ 		case libcontainer.Running:","I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the ""FIFO does not exist"" error and translate it to a prettier ""someone must have already started the container""."
+692,"@@ -284,7 +284,7 @@ func (svr *Web3Server) getTransactionFromActionInfo(actInfo *iotexapi.ActionInfo
+
+ func (svr *Web3Server) getTransactionCreateFromActionInfo(actInfo *iotexapi.ActionInfo) (transactionObject, error) {
+ 	tx, err := svr.getTransactionFromActionInfo(actInfo)
+-	if err != nil {
++	if err != nil || tx == nil {
+ 		return transactionObject{}, err
+ 	}
+ ",can you check if there's other similar cases to add nil-check like this?
+693,"@@ -106,7 +106,10 @@ def dummy_cert(privkey, cacert, commonname, sans, organization):
+     cert.gmtime_adj_notBefore(-3600 * 48)
+     cert.gmtime_adj_notAfter(DEFAULT_EXP_DUMMY_CERT)
+     cert.set_issuer(cacert.get_subject())
+-    if commonname is not None and len(commonname) < 64:
++    is_valid_commonname = (
++        commonname is not None and len(commonname) < 64
++    )
++    if is_valid_commonname:
+         cert.get_subject().CN = commonname
+     if organization is not None:
+         cert.get_subject().O = organization","`<= 64`? I just picked up what you said in #3981 (""the CN field is limited to 64 characters"") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:"
+694,"@@ -20,4 +20,10 @@ class License < ActiveRecord::Base
+   def short_name
+     abbreviation.blank? ? nice_name : abbreviation
+   end
++
++  class << self
++    def autocomplete(term)
++      License.select([:nice_name, :id]).where(['lower(nice_name) LIKE ?', ""#{term.downcase}%""]).limit(10)
++    end
++  end
+ end",I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?
+695,"@@ -480,6 +480,10 @@ public class BlockchainQueries {
+         txs.get(txIndex), header.getNumber(), blockHeaderHash, txIndex);
+   }
+
++  public Optional<TransactionLocation> transactionLocationByHash(final Hash transactionHash) {
++    return blockchain.getTransactionLocation(transactionHash);
++  }
++
+   /**
+    * Returns the transaction receipt associated with the given transaction hash.
+    *",I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ...
+696,"@@ -180,6 +180,19 @@ public class StringUtil {
+         }
+     }
+
++    public static String sanitizeFileDirectory(String value){
++
++        while (value.startsWith(""\\"") || value.startsWith(""/"") || value.startsWith(""-"") || value.startsWith(""."")){
++            value = value.substring(1);
++        }
++        while (value.endsWith(""\\"") || value.endsWith(""/"") || value.endsWith(""-"") || value.endsWith(""."")){
++            value = value.substring(0, value.length() - 1);
++        }
++
++        return value;
++    }
++
++
+     private static SecretKeySpec generateKeyFromString(final String secKey) throws UnsupportedEncodingException, NoSuchAlgorithmException {
+         byte[] key = (secKey).getBytes(""UTF-8"");
+         MessageDigest sha = MessageDigest.getInstance(""SHA-1"");","@sekmiller This method correctly strips the leading and trailing slashes (and also ""."" and ""-""); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter ""folder1///folder2"", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as ""folder1/folder2""."
+697,"@@ -45,7 +45,7 @@
+
+ int main()
+ {
+-    int pid;
++    int64_t pid;
+     fprintf(stderr, ""starting\n"");
+ #if defined(AARCH64)
+     asm(""movz x8, "" STRINGIFY(SYS_getpid) "";""",Looks like the X86 inline assembly is not happy with this type. I will update that
+698,"@@ -6,6 +6,12 @@
+
+     <h2><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></h2>
+
++    <% if @user and diary_entry.user.id != @user.id %>
++           <%= link_to new_issue_url(reportable_id: diary_entry.id, reportable_type: diary_entry.class.name, reported_user_id: diary_entry.user.id,referer: request.fullpath), :title => t('diary_entry.diary_entry.report') do %>
++            &nbsp;&#9872;
++          <% end %>
++    <% end %>
++
+     <small class='deemphasize'>
+       <%= raw(t 'diary_entry.diary_entry.posted_by', :link_user => (link_to h(diary_entry.user.display_name), :controller => 'user', :action => 'view', :display_name => diary_entry.user.display_name), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to h(diary_entry.language.name), :controller => 'diary_entry', :action => 'list', :display_name => nil, :language => diary_entry.language_code)) %>
+     </small>","Tabs and a space, again."
+699,"@@ -2441,6 +2441,16 @@ bool QuestManager::istaskappropriate(int task) {
+ 	return false;
+ }
+
++std::string QuestManager::gettaskname(uint32 task_id) {
++	QuestManagerCurrentQuestVars();
++
++	if (RuleB(TaskSystem, EnableTaskSystem)) {
++		return taskmanager->GetTaskName(task_id);
++	}
++
++	return std::string();
++}
++
+ void QuestManager::clearspawntimers() {
+ 	if(!zone)
+         return;",Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them
+700,"@@ -185,11 +185,7 @@
+ <% if policy(@proposal).can_approve_or_reject? %>
+   <div class=""centered"">
+     <p>
+-      <%= link_to ""Approve"",
+-          approval_response_path(approver_action: 'approve',
+-                                 # @todo: get rid of cart
+-                                 cart_id: @proposal.cart.id, version: @proposal.version
+-                                 ), class: 'form-button' %>
++      <%= link_to ""Approve"", approve_proposal_url(@proposal, version: @proposal.version), class: 'form-button' %>
+     </p>
+   </div>
+ <% end %>","`version` isn't need anymore because it's built into `approve_proposal_url`, yes?"
+701,"@@ -11,9 +11,10 @@ import struct
+
+ from scapy.compat import orb, chb
+ from scapy.config import conf
+-from scapy.data import MTU, DLT_BLUETOOTH_LE_LL
++from scapy.data import MTU, DLT_BLUETOOTH_LE_LL, DLT_BLUETOOTH_LE_LL_WITH_PHDR
+ from scapy.packet import *
+ from scapy.fields import *
++from scapy.layers.dot11 import _dbmField
+ from scapy.layers.ppi import PPI, addPPIType, PPIGenericFldHdr
+
+ from scapy.contrib.ppi_geotag import XLEIntField, XLEShortField",Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after
+702,"@@ -48,6 +48,7 @@ module Blacklight::SolrHelper
+   extend ActiveSupport::Concern
+   include Blacklight::SearchFields
+   include Blacklight::Facet
++  require 'json'
+
+   included do
+     if self.respond_to?(:helper_method)","This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)"
+703,"@@ -56,8 +56,13 @@ type byteReadCloser struct{ io.ReadCloser }
+ // ReadByte implements the io.ByteReader interface.
+ func (b byteReadCloser) ReadByte() (byte, error) {
+ 	var buf [1]byte
+-	_, err := b.Read(buf[:])
+-	return buf[0], err
++	for {
++		n, err := b.Read(buf[:])
++		if n == 0 && err == nil {
++			continue
++		}
++		return buf[0], err
++	}
+ }
+
+ // A compressor builds a Riegeli compressed block.","This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just ""trying again"" and failing if it fails the second time."
+704,"@@ -20,11 +20,18 @@
+ package org.apache.iceberg;
+
+ import java.util.List;
++import java.util.Optional;
+ import org.apache.iceberg.exceptions.ValidationException;
+ import org.apache.iceberg.expressions.Expressions;
++import org.apache.iceberg.util.PartitionSet;
+
+ public class BaseReplacePartitions
+     extends MergingSnapshotProducer<ReplacePartitions> implements ReplacePartitions {
++
++  private final PartitionSet deletedPartitions = PartitionSet.create(super.getSpecsById());
++  private Long startingSnapshotId = null;
++  private boolean validateNoConflictingAppends = false;
++
+   BaseReplacePartitions(String tableName, TableOperations ops) {
+     super(tableName, ops);
+     set(SnapshotSummary.REPLACE_PARTITIONS_PROP, ""true"");","If there is a reference to other fields or methods, please do the initialization in the constructor."
+705,"@@ -0,0 +1,13 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/base.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/icons.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/avatars.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/bare.jsx'),
++];
++
++module.exports = siteStories;",These should be importing from `pill-container`
+706,"@@ -2593,12 +2593,12 @@ void Game::playerRequestTrade(uint32_t playerId, const Position& pos, uint8_t st
+
+ 	Player* tradePartner = getPlayerByID(tradePlayerId);
+ 	if (!tradePartner || tradePartner == player) {
+-		player->sendTextMessage(MESSAGE_INFO_DESCR, ""Sorry, not possible."");
++		player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
+ 		return;
+ 	}
+
+ 	if (!Position::areInRange<2, 2, 0>(tradePartner->getPosition(), player->getPosition())) {
+-		player->sendTextMessage(MESSAGE_INFO_DESCR, fmt::format(""{:s} tells you to move closer."", tradePartner->getName()));
++		player->sendCancelMessage(RETURNVALUE_DESTINATIONOUTOFREACH);
+ 		return;
+ 	}
+ ","Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?"
+707,"@@ -46,7 +46,7 @@ module Blacklight
+
+       fields = Array.wrap(view_config.title_field) + [configuration.document_model.unique_key]
+       f = fields.lazy.map { |field| field_config(field) }.detect { |field_config| field_presenter(field_config).any? }
+-      field_value(f, except_operations: [Rendering::HelperMethod])
++      f ? field_value(f, except_operations: [Rendering::HelperMethod]) : """"
+     end
+
+     def display_type(base_name = nil, default: nil)",Does this need to allocate a string or would a nil value (indicating no header) be a better?
+708,"@@ -13,6 +13,7 @@ import { Fragment } from './create-element';
+ export function Component(props, context) {
+ 	this.props = props;
+ 	this.context = context;
++	// this.constructor // When component is functional component, this is reseted to functional component
+ 	// if (this.state==null) this.state = {};
+ 	// this.state = {};
+ 	// this._dirty = true;",Nit: Past tense of `reset` is also `reset`.
+709,"@@ -672,6 +672,12 @@ class Commands:
+         """""" return wallet synchronization status """"""
+         return self.wallet.is_up_to_date()
+
++    @command('')
++    def getfee(self):
++        """"""Return current optimal fee per kilobyte, according to
++        config settings (static/dynamic)""""""
++        return self.config.fee_per_kb()
++
+     @command('')
+     def help(self):
+         # for the python console",Shouldn't this use `'n'` instead?
+710,"@@ -451,10 +451,10 @@ func (t *timerQueueProcessorBase) getTimerTaskType(
+ 	switch taskType {
+ 	case enumsspb.TASK_TYPE_USER_TIMER:
+ 		return ""UserTimer""
+-	case enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT:
+-		return ""ActivityTimeout""
+-	case enumsspb.TASK_TYPE_DECISION_TIMEOUT:
+-		return ""DecisionTimeout""
++	case enumsspb.TASK_TYPE_ACTIVITY_TASK_TIMEOUT:
++		return ""ActivityTaskTimeout""
++	case enumsspb.TASK_TYPE_WORKFLOW_TASK_TIMEOUT:
++		return ""WorkflowTaskTimeout""
+ 	case enumsspb.TASK_TYPE_WORKFLOW_RUN_TIMEOUT:
+ 		return ""WorkflowRunTimeout""
+ 	case enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT:",revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT'
+711,"@@ -105,6 +105,9 @@ Engine::Engine(core::Engine *engine) : m_Engine(engine) {}
+     template void Engine::Get<T>(const std::string &, std::vector<T> &,        \
+                                  const Mode);                                  \
+                                                                                \
++    template void Engine::GetBlock<T>(Variable<T>, T **, const Mode);          \
++    template void Engine::GetBlock<T>(const std::string &, T **, const Mode);  \
++                                                                               \
+     template std::map<size_t, std::vector<typename Variable<T>::Info>>         \
+     Engine::AllStepsBlocksInfo(const Variable<T> variable) const;              \
+                                                                                \","Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?"
+712,"@@ -146,9 +146,15 @@ func (n *NetworkPolicyController) processClusterNetworkPolicy(cnp *secv1alpha1.C
+ 			appliedToGroupNamesForRule = append(appliedToGroupNamesForRule, atGroup)
+ 			appliedToGroupNamesSet.Insert(atGroup)
+ 		}
++		cgExists := len(ingressRule.SourceGroups) > 0
++		iFromPeers := n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists, cgExists)
++		// If ClusterGroups are set in Rule, then create AddressGroups corresponding to the CG and append to From Peers.
++		ag, ipb := n.processRefCGs(ingressRule.SourceGroups)
++		iFromPeers.IPBlocks = append(iFromPeers.IPBlocks, ipb...)
++		iFromPeers.AddressGroups = append(iFromPeers.AddressGroups, ag...)
+ 		rules = append(rules, controlplane.NetworkPolicyRule{
+ 			Direction:       controlplane.DirectionIn,
+-			From:            *n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists),
++			From:            iFromPeers,
+ 			Services:        services,
+ 			Action:          ingressRule.Action,
+ 			Priority:        int32(idx),",nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though.
+713,"@@ -98,6 +98,7 @@ func updateSPCVersion(name string) error {
+ 		return err
+ 	}
+ 	spcObj.VersionDetails.Desired = upgradeVersion
++	spcObj.VersionDetails.Status.State = apis.ReconcilePending
+ 	_, err = client.Update(spcObj)
+ 	if err != nil {
+ 		return err","Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?"
+714,"@@ -61,11 +61,13 @@ class VimeoProvider extends BaseVideoProvider
+         $box = $this->getBoxHelperProperties($media, $format, $options);
+
+         $params = array(
+-            'src'         => http_build_query($player_parameters),
+-            'id'          => $player_parameters['js_swf_id'],
+-            'frameborder' => isset($options['frameborder']) ? $options['frameborder'] : 0,
+-            'width'       => $box->getWidth(),
+-            'height'      => $box->getHeight(),
++            'src'               => http_build_query($player_parameters),
++            'id'                => $player_parameters['js_swf_id'],
++            'frameborder'       => isset($options['frameborder']) ? $options['frameborder'] : 0,
++            'width'             => $box->getWidth(),
++            'height'            => $box->getHeight(),
++            'class'             => isset($options['class']) ? $options['class'] : '',
++            'allow_fullscreen'  => isset($options['allowfullscreen']) ? true : false,
+         );
+
+         return $params;",would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?
+715,"@@ -169,6 +169,8 @@ public class PhpSampleMethodToViewTransformer implements SampleMethodToViewTrans
+     builder.isResourceMap(fieldInfo.type().isMap());
+     builder.pageVarName(
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name()))));
++    builder.pageTokenName(methodInfo.requestPageTokenName());
++    builder.nextPageTokenName(Name.lowerCamel(methodInfo.responsePageTokenName()).toUpperCamel());
+     return builder.build();
+   }
+ }",How come we need case manipulation for the nextPageToken and not for pageToken?
+716,"@@ -2,7 +2,8 @@ C2::Application.routes.draw do
+   ActiveAdmin.routes(self)
+   root :to => 'home#index'
+   get '/error' => 'home#error'
+-  get '/me'    => 'home#me'
++  get '/me'    => 'profile#show'
++  post '/me'   => 'profile#update'
+   get '/feedback' => 'feedback#index'
+   get '/feedback/thanks' => 'feedback#thanks'
+   post '/feedback' => 'feedback#create'",why use these rather than regular named paths?
+717,"@@ -61,6 +61,9 @@ module Bolt
+           { flags: OPTIONS[:global],
+             banner: GROUP_HELP }
+         end
++      when 'guide'
++        { flags: OPTIONS[:global] + %w[format],
++          banner: GUIDE_HELP }
+       when 'plan'
+         case action
+         when 'convert'","Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out."
+718,"@@ -1,3 +1,18 @@
++# This script is responsible to create candidate sets for all users. The generated candidate sets
++# will be given as input to the recommender to assign ratings to the recordings in candidate sets.
++# The general flow is as follows:
++#
++# Last 7 days listens are filtered from mapped_listens_df and is called the mapped_listens_subset_df.
++# Top X artists are fetched for each user from the mapped_listens_subset_df. The top_artist_df is joined
++# with recordings_df to get the dataframe of recordings belonging to the top artists. From this dataframe,
++# recordings listened to by the users in the last 7 days are filtered so that the recommendations don't contain
++# recordings that the user has listened to in the last week. The resultant dataframe is called the top_artists_candidate_set_df.
++#
++# Artists similar to top artists are fetched from the artist_relations_df and the similar_artist_candidate_set_df is generated
++# in a manner similar to the generation of the top artist candidate set.
++#
++# The top artist and similar artist candidate set dataframes are saved to HDFS.
++
+ import os
+ import sys
+ import uuid","We should make this a docstring, so that editors are able to pick it up."
+719,"@@ -14,5 +14,13 @@ feature ""User without a subscription views sample video"" do
+     expect(current_path).to eq(video_path(video))
+     expect(page).to have_css(""h1"", text: video.name)
+     expect(page).not_to have_css("".locked-message"")
++    expect_authed_to_access_event_fired_for(video)
++  end
++
++  def expect_authed_to_access_event_fired_for(video)
++    expect(analytics).to have_tracked(""Authed to Access"").with_properties(
++      video_name: video.name,
++      watchable_name: video.watchable_name,
++    )
+   end
+ end",Put a comma after the last parameter of a multiline method call.
+720,"@@ -150,10 +150,8 @@ public class SalesforceDroidGapActivity extends CordovaActivity {
+     		webSettings.setDomStorageEnabled(true);
+     		String cachePath = getApplicationContext().getCacheDir().getAbsolutePath();
+     		webSettings.setAppCachePath(cachePath);
+-            webSettings.setAppCacheMaxSize(1024 * 1024 * 8);
+     		webSettings.setAppCacheEnabled(true);
+     		webSettings.setAllowFileAccess(true);
+-            webSettings.setSavePassword(false);
+     		webSettings.setCacheMode(WebSettings.LOAD_DEFAULT);
+     		EventsObservable.get().notifyEvent(EventType.GapWebViewCreateComplete, appView);
+       	}",App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework.
+721,"@@ -1,4 +1,6 @@
+-var nn = node.nodeName.toLowerCase();
+-return (
+-	node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area')
+-);
++const { nodeName } = virtualNode.props;
++if (['img', 'input', 'area'].includes(nodeName) === false) {
++	return false;
++}
++
++return typeof virtualNode.attr('alt') === 'string';","VirtualNode has a `hasAttr` function, any reason why you're not using it?"
+722,"@@ -69,7 +69,6 @@ public class HttpAccess {
+      * Initializes HttpAccess. Should be called from the application.
+      */
+     public static void init(Context app) {
+-        assert DEFAULT == null : ""HttpAccess.init should be called once per process"";
+         DEFAULT = new HttpAccess(app, null /* user agent will be calculated at request time */);
+     }
+ ",This now throws when running tests (maybe the move to java 11??). Do we want to keep it?
+723,"@@ -45,8 +45,8 @@ func EncodeSha1(str string) string {
+ }
+
+ func ShortSha(sha1 string) string {
+-	if len(sha1) == 40 {
+-		return sha1[:10]
++	if len(sha1) > 7 {
++		return sha1[:7]
+ 	}
+ 	return sha1
+ }","We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut."
+724,"@@ -66,8 +66,10 @@ en_US.strings = {
+   loading: 'Loading...',
+   logOut: 'Log out',
+   myDevice: 'My Device',
++  noDuplicates: 'Cannot add the duplicate file %{fileName}, it already exists',
+   noFilesFound: 'You have no files or folders here',
+   noInternetConnection: 'No Internet connection',
++  noNewAlreadyUploading: 'Cannot add new files: already uploading',
+   openFolderNamed: 'Open folder %{name}',
+   pause: 'Pause',
+   pauseUpload: 'Pause upload',",this one should also have quotes i guess :)
+725,"@@ -106,12 +106,14 @@ func TestBuilderForYAML(t *testing.T) {
+ 		""Test 2"": {fakeInvalidK8sResource, """", true},
+ 	}
+ 	for name, mock := range tests {
++		name := name // pin it
++		mock := mock // pin it
+ 		t.Run(name, func(t *testing.T) {
+ 			b := BuilderForYaml(mock.resourceYAML)
+ 			if mock.expectError && len(b.errs) == 0 {
+ 				t.Fatalf(""Test %s failed, expected err but got 0"", name)
+-			} else if b.unstruct.object.GetName() != mock.expectedName {
+-				t.Fatalf(""Test %s failed, expected %v but got %v"", name, mock.expectedName, b.unstruct.object.GetName())
++			} else if b.unstruct.Object.GetName() != mock.expectedName {
++				t.Fatalf(""Test %s failed, expected %v but got %v"", name, mock.expectedName, b.unstruct.Object.GetName())
+ 			}
+ 		})
+ 	}",Using the variable on range scope `mock` in function literal (from `scopelint`)
+726,"@@ -1020,7 +1020,7 @@ public class Datasets extends AbstractApiBean {
+             PublishDatasetResult res = execCommand(new PublishDatasetCommand(ds,
+                         createDataverseRequest(user),
+                     isMinor));
+-            return res.isCompleted() ? ok(json(res.getDataset())) : accepted(json(res.getDataset()));
++            return res.isWorkflow() ? accepted(json(res.getDataset())) : ok(json(res.getDataset()));
+             }
+         } catch (WrappedResponse ex) {
+             return ex.getResponse();",does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?
+727,"@@ -65,6 +65,7 @@ public class SmartStorePlugin extends ForcePlugin {
+ 	public static final String LIKE_KEY = ""likeKey"";
+ 	public static final String MATCH_KEY = ""matchKey"";
+ 	public static final String SMART_SQL = ""smartSql"";
++	public static final String ORDER_PATH = ""orderPath"";
+ 	public static final String ORDER = ""order"";
+ 	public static final String PAGE_SIZE = ""pageSize"";
+ 	public static final String QUERY_TYPE = ""queryType"";","Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided."
+728,"@@ -38,7 +38,7 @@ export function flushMounts() {
+  * Apply differences in a given vnode (and it's deep children) to a real DOM Node.
+  * @param {import('../dom').PreactElement} dom A DOM node to mutate into the shape of a `vnode`
+  * @param {import('../vnode').VNode} vnode A VNode (with descendants forming a tree) representing
+- *  the desired DOM structure
++ *	the desired DOM structure
+  * @param {object} context The current context
+  * @param {boolean} mountAll Whether or not to immediately mount all components
+  * @param {Element} parent ?",VIM didn't like your whitespace.
+729,"@@ -3,14 +3,7 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
+-using System;
+-using System.Collections.Generic;
+-using System.IO;
+-using System.Linq;
+-using System.Reflection;
+-using System.Threading;
+-using System.Threading.Tasks;
+-using Datadog.Trace.TestHelpers;
++using Datadog.Trace.ClrProfiler;
+ using Xunit;
+ using Xunit.Abstractions;
+ using Xunit.Sdk;",Are you sure the namespace should change?
+730,"@@ -12,7 +12,7 @@ namespace MvvmCross.ViewModels
+
+         void Initialize();
+
+-        void Startup(object hint);
++        object Startup(object hint);
+
+         void Reset();
+     }",@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication<THint> with THint set to object
+731,"@@ -31,6 +31,7 @@ import com.pingcap.tikv.meta.TiColumnInfo.InternalTypeHolder;
+ // https://dev.mysql.com/doc/refman/8.0/en/time.html
+
+ public class TimeType extends DataType {
++  public static final TimeType TIME = new TimeType(MySQLType.TypeDuration);
+   public static final MySQLType[] subTypes = new MySQLType[] {MySQLType.TypeDuration};
+   protected static final long NANOSECOND = 1;
+   protected static final long MICROSECOND = 1000 * NANOSECOND;",why do we create a time type here?
+732,"@@ -1,4 +1,4 @@
+-define([""jQuery"", ""datetime"", ""loading"", ""libraryMenu"", ""listViewStyle"", ""paper-icon-button-light""], function ($, datetime, loading, libraryMenu) {
++define([""jQuery"", ""datetime"", ""loading"", ""libraryMenu"", ""css!components/listview/listview"", ""paper-icon-button-light""], function ($, datetime, loading, libraryMenu) {
+     ""use strict"";
+
+     function populateRatings(allParentalRatings, page) {",Does this style actually need to get loaded in all of these components?
+733,"@@ -30,6 +30,9 @@ import io.servicecomb.foundation.ssl.SSLCustom;
+ import io.servicecomb.foundation.ssl.SSLOption;
+ import io.servicecomb.foundation.ssl.SSLOptionFactory;
+ import io.servicecomb.foundation.vertx.VertxTLSBuilder;
++import io.servicecomb.transport.rest.vertx.accesslog.AccessLogConfiguration;
++import io.servicecomb.transport.rest.vertx.accesslog.impl.AccessLogHandlerImpl;
++import io.servicecomb.transport.rest.vertx.accesslog.parser.impl.DefaultAccessLogPatternParser;
+ import io.vertx.core.AbstractVerticle;
+ import io.vertx.core.Context;
+ import io.vertx.core.Future;",import but not used so you did not resolve compile warnings?
+734,"@@ -865,15 +865,10 @@ BlockType_t Creature::blockHit(Creature* attacker, CombatType_t combatType, int3
+ 		}
+
+ 		if (checkArmor) {
+-			int32_t armorValue = getArmor();
+-			if (armorValue > 1) {
+-				double armorFormula = armorValue * 0.475;
+-				int32_t armorReduction = static_cast<int32_t>(std::ceil(armorFormula));
+-				damage -= uniform_random(
+-					armorReduction,
+-					armorReduction + static_cast<int32_t>(std::floor(armorFormula))
+-				);
+-			} else if (armorValue == 1) {
++			int32_t armor = getArmor();
++			if (armor > 3) {
++				damage -= uniform_random(armor / 2, armor - (armor % 2 + 1));
++			} else if (armor > 0) {
+ 				--damage;
+ 			}
+ ",This is so much more concise and beautiful than the previous formula
+735,"@@ -41,9 +41,19 @@ import org.hyperledger.besu.tests.acceptance.dsl.transaction.perm.PermissioningT
+ import org.hyperledger.besu.tests.acceptance.dsl.transaction.privacy.PrivacyTransactions;
+ import org.hyperledger.besu.tests.acceptance.dsl.transaction.web3.Web3Transactions;
+
++import java.io.File;
++
++import org.apache.logging.log4j.LogManager;
++import org.apache.logging.log4j.Logger;
++import org.apache.logging.log4j.ThreadContext;
+ import org.junit.After;
++import org.junit.Rule;
++import org.junit.rules.TestName;
++import org.junit.rules.TestWatcher;
++import org.junit.runner.Description;
+
+ public class AcceptanceTestBase {
++  protected final Logger LOG = LogManager.getLogger();
+
+   protected final Accounts accounts;
+   protected final AccountTransactions accountTransactions;",Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_
+736,"@@ -27,11 +27,18 @@ import (
+ // DialogCreator creates new dialog between consumer and provider, using given contact information
+ type DialogCreator func(consumerID, providerID identity.Identity, contact market.Contact) (communication.Dialog, error)
+
++// SessionCreationConfig are the parameters that get sent to the provider
++type SessionCreationConfig interface{}
++
++// ConsumerConfig are the parameters used for the initiation of connection
++type ConsumerConfig interface{}
++
+ // Connection represents a connection
+ type Connection interface {
+-	Start() error
++	Start(ConnectOptions) error
+ 	Wait() error
+ 	Stop()
++	GetSessionConfig() (SessionCreationConfig, error)
+ }
+
+ // StateChannel is the channel we receive state change events on",It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself
+737,"@@ -97,7 +97,7 @@ type ConfigLocal struct {
+ 	kbpki            KBPKI
+ 	renamer          ConflictRenamer
+ 	registry         metrics.Registry
+-	loggerFn         func(prefix string) logger.Logger
++	loggerFn         func(prefix string, overrideEnableDebug bool) logger.Logger
+ 	noBGFlush        bool // logic opposite so the default value is the common setting
+ 	rwpWaitTime      time.Duration
+ 	diskLimiter      DiskLimiter","Why is there an ""enable"" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else."
+738,"@@ -1,4 +1,8 @@
+ class VideosController < ApplicationController
++  def index
++    @videos = Video.published.recently_published_first
++  end
++
+   def show
+     @video = Video.find(params[:id])
+     @offering = Offering.new(@video.watchable, current_user)",`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?
+739,"@@ -20,7 +20,11 @@ var createIntegrationPreprocessor = function(logger) {
+       // and add the test data to it
+       var htmlpath = file.originalPath.replace(extRegex, '.html');
+       var html = fs.readFileSync(htmlpath, 'utf-8');
+-      var test = JSON.parse(content);
++      try {
++        var test = JSON.parse(content);
++      } catch (e) {
++        throw new Error('Unable to parse content of ' + file.originalPath)
++      }
+       test.content = html;
+
+       var result = template.replace('{}; /*tests*/', JSON.stringify(test));",Encountered this because I had a stray comma. Figured I'd tweak it a bit.
+740,"@@ -306,6 +306,13 @@ var _ = infrastructure.DatastoreDescribe(""service loop prevention; with 2 nodes""
+ 			cfg.Spec.ServiceLoopPrevention = ""Disabled""
+ 		})
+
++		// Expect to see empty cali-cidr-block chains.  (Allowing time for a Felix
++		// restart.)  This ensures that the cali-cidr-block chain has been cleared
++		// before we try a test ping.
++		for _, felix := range felixes {
++			Eventually(getCIDRBlockRules(felix, ""iptables-save""), ""8s"", ""0.5s"").Should(BeEmpty())
++		}
++
+ 		By(""test that we DO get a routing loop"")
+ 		// (In order to test that the tryRoutingLoop setup is genuine.)
+ 		tryRoutingLoop(true)",qq: Should this include the iptables6-save sim. to the inverse checks above?
+741,"@@ -195,8 +195,16 @@ func (cfg *Config) Merge(rhs Config) *Config {
+
+ 	for i := 0; i < left.NumField(); i++ {
+ 		leftField := left.Field(i)
+-		if utils.ZeroOrNil(leftField.Interface()) {
+-			leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++		switch leftField.Interface().(type) {
++		case BooleanDefaultFalse, BooleanDefaultTrue:
++			str, _ := json.Marshal(reflect.ValueOf(leftField.Interface()).Interface())
++			if string(str) == ""null"" {
++				leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++			}
++		default:
++			if utils.ZeroOrNil(leftField.Interface()) {
++				leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++			}
+ 		}
+ 	}
+ ",im open to explicitly checking NotSet value here but json logic already handles it so kept it this way.
+742,"@@ -27,6 +27,7 @@ extern ""C"" {
+ #include ""ScriptingEnvironment.h""
+ #include ""../typedefs.h""
+ #include ""../Util/OpenMPWrapper.h""
++#include ""../Util/Lua.h""
+
+ ScriptingEnvironment::ScriptingEnvironment() {}
+ ScriptingEnvironment::ScriptingEnvironment(const char * fileName) {",The naming of the include file appears to be unlucky.
+743,"@@ -1018,7 +1018,8 @@ class BarPlot(BarsMixin, ColorbarPlot, LegendPlot):
+         if self.show_legend and any(len(l) for l in labels) and (sdim or not self.multi_level):
+             leg_spec = self.legend_specs[self.legend_position]
+             if self.legend_cols: leg_spec['ncol'] = self.legend_cols
+-            axis.legend(title=title, **leg_spec)
++            self.legend_opts.update(**leg_spec)
++            axis.legend(title=title, **self.legend_opts)
+
+         return bars, xticks, ax_dims
+ ",Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable.
+744,"@@ -455,6 +455,11 @@ func (r *AWSMachinePoolReconciler) reconcileLaunchTemplate(machinePoolScope *sco
+ 	// userdata, OR we've discovered a new AMI ID.
+ 	if needsUpdate || tagsChanged || *imageID != *launchTemplate.AMI.ID || launchTemplateUserDataHash != bootstrapDataHash {
+ 		machinePoolScope.Info(""creating new version for launch template"", ""existing"", launchTemplate, ""incoming"", machinePoolScope.AWSMachinePool.Spec.AWSLaunchTemplate)
++		// There is a limit to the number of Launch Template Versions.
++		// We ensure that the number of versions does not grow without bound by following a simple rule: For each version we create, we delete one old version.
++		if err := ec2svc.PruneLaunchTemplateVersions(machinePoolScope.AWSMachinePool.Status.LaunchTemplateID); err != nil {
++			return err
++		}
+ 		if err := ec2svc.CreateLaunchTemplateVersion(machinePoolScope, imageID, bootstrapData); err != nil {
+ 			return err
+ 		}","Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing."
+745,"@@ -27,13 +27,13 @@ class ContainerInformationTab extends Tab {
+
+     private final WinePrefixContainerDTO container;
+
+-    private Consumer<ContainerDTO> onDeletePrefix;
++    private Consumer<ContainerDTO> onDeleteContainer;
+     private Consumer<ContainerDTO> onOpenFileBrowser;
+
+-    ContainerInformationTab(WinePrefixContainerDTO container) {
++    ContainerInformationTab(ContainerDTO container) {
+         super(tr(""Information""));
+
+-        this.container = container;
++        this.container = (WinePrefixContainerDTO) container; // TODO: use generic container
+
+         this.setClosable(false);
+ ",Do we require the specific implementation information here?
+746,"@@ -0,0 +1,13 @@
++class DomainBlacklist < ActiveRecord::Base
++  validates :domain, uniqueness: { case_sensitive: false }
++
++  class << self
++    def email_banned?(email_address)
++      contains?(email_address.split('@').last)
++    end
++
++    def contains?(domain)
++      exists?(['lower(domain) LIKE ?', ""%#{domain.downcase}%""])
++    end
++  end
++end","How about `exists?(['domain ~* ?', domain.downcase])` ?"
+747,"@@ -729,6 +729,15 @@ func newContextForLongPoll(c *cli.Context) (context.Context, context.CancelFunc)
+ 	return newContextWithTimeout(c, defaultContextTimeoutForLongPoll)
+ }
+
++func newContextForBackground(c *cli.Context) (context.Context, context.CancelFunc) {
++	if c.GlobalIsSet(FlagContextTimeout) {
++		timeout := time.Duration(c.GlobalInt(FlagContextTimeout)) * time.Second
++		return rpc.NewContextWithTimeoutAndCLIHeaders(timeout)
++	}
++
++	return rpc.NewContextWithCLIHeaders()
++}
++
+ func newContextWithTimeout(c *cli.Context, timeout time.Duration) (context.Context, context.CancelFunc) {
+ 	if c.GlobalIsSet(FlagContextTimeout) {
+ 		timeout = time.Duration(c.GlobalInt(FlagContextTimeout)) * time.Second",Is this getting used in other places? Can we switch all the places to use the new API you added?
+748,"@@ -483,17 +483,6 @@ int HTTP_OP::libcurl_exec(
+     curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, 1L);
+     //curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, FALSE);
+
+-    // if the above is nonzero, you need the following:
+-    //
+-#ifndef _WIN32
+-    if (boinc_file_exists(CA_BUNDLE_FILENAME)) {
+-        // call this only if a local copy of ca-bundle.crt exists;
+-        // otherwise, let's hope that it exists in the default place
+-        //
+-        curl_easy_setopt(curlEasy, CURLOPT_CAINFO, CA_BUNDLE_FILENAME);
+-    }
+-#endif
+-
+     // set the user agent as this boinc client & version
+     //
+     curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);","This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file."
+749,"@@ -1,12 +1,12 @@
+-define(['browser', 'dom', 'layoutManager', 'css!components/viewManager/viewContainer'], function (browser, dom, layoutManager) {
+-    'use strict';
++import 'css!components/viewManager/viewContainer';
++/* eslint-disable indent */
+
+     function setControllerClass(view, options) {
+         if (options.controllerFactory) {
+             return Promise.resolve();
+         }
+
+-        var controllerUrl = view.getAttribute('data-controller');
++        let controllerUrl = view.getAttribute('data-controller');
+
+         if (controllerUrl) {
+             if (controllerUrl.indexOf('__plugin/') === 0) {",Shouldn't we import `default`? I can't get here to test.
+750,"@@ -99,7 +99,7 @@ class UNIXServerClient(object):
+         self.unix_socket = os.path.join(self.temp_dir, 'luigid.sock')
+
+     def run_server(self):
+-        luigi.server.run(unix_socket=unix_socket)
++        luigi.server.run(unix_socket=self.unix_socket)
+
+     def scheduler(self):
+         url = ParseResult(","!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???"
+751,"@@ -484,11 +484,11 @@ namespace Microsoft.DotNet.Execute
+         public string FormatSetting(string option, string value, string type, string toolName)
+         {
+             string commandOption = null;
+-            if (type.Equals(""passThrough""))
++            if (type != null && type.Equals(""passThrough""))
+             {
+                 commandOption = string.Format("" {0}"", toolName.Equals(""console"") ? """" : value);
+             }
+-            else if (type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }
++            else if (type != null && type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }
+             else
+             {
+                 Tool toolFormat;","I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way."
+752,"@@ -1,4 +1,11 @@
+ var parent = axe.commons.dom.getComposedParent(node);
+-return (['UL', 'OL'].includes(parent.nodeName.toUpperCase()) ||
+-    (parent.getAttribute('role') || '').toLowerCase() === 'list');
+-
++
++var parentRole = (parent.getAttribute('role') || '').toLowerCase();
++
++var isListRole = parentRole === 'list';
++
++return (
++	(['UL', 'OL'].includes(parent.nodeName.toUpperCase()) &&
++		(!parentRole || isListRole)) ||
++	isListRole
++);",This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?
+753,"@@ -4,10 +4,10 @@
+ package stack
+
+ import (
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/template""
+ 	""github.com/aws/aws-sdk-go/service/cloudformation""
++	""github.com/aws/copilot-cli/internal/pkg/template""
+
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy""
++	""github.com/aws/copilot-cli/internal/pkg/deploy""
+ )
+
+ const pipelineCfnTemplatePath = ""cicd/pipeline_cfn.yml""","The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?"
+754,"@@ -60,7 +60,7 @@ public class Program
+             // turn off the above default. i.e any
+             // instrument which does not match any views
+             // gets dropped.
+-            // .AddView(instrumentName: ""*"", new DropAggregationConfig())
++            // .AddView(instrumentName: ""*"", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })
+             .AddConsoleExporter()
+             .Build();
+ ",Consider making a constant (e.g. `MetricStreamConfiguration.Drop`).
+755,"@@ -18,6 +18,7 @@ try:
+ except ImportError:
+   from rdkit.piddle import piddle
+ import ClusterUtils
++from rdkit.six.moves import xrange
+
+ import numpy
+ ",same question: why not just switch this to range too?
+756,"@@ -111,10 +111,10 @@ Variable IO::InquireVariable(const std::string &name)
+     helper::CheckForNullptr(m_IO, ""for variable "" + name +
+                                       "", in call to IO::InquireVariable"");
+
+-    const std::string type(m_IO->InquireVariableType(name));
++    const Type type(m_IO->InquireVariableType(name));
+     core::VariableBase *variable = nullptr;
+
+-    if (type == ""unknown"")
++    if (type == Type::None)
+     {
+     }
+ #define declare_template_instantiation(T)                                      \","@chuckatkins most places used an empty string for ""no type"", but a few used `""unknown""`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?"
+757,"@@ -408,7 +408,7 @@ void CUDATreeLearner::copyDenseFeature() {
+     // looking for dword_features_ non-sparse feature-groups
+     if (!train_data_->IsMultiGroup(i)) {
+       dense_feature_group_map_.push_back(i);
+-      auto sizes_in_byte = train_data_->FeatureGroupSizesInByte(i);
++      auto sizes_in_byte = std::min(train_data_->FeatureGroupSizesInByte(i), static_cast<size_t>(num_data_));
+       void* tmp_data = train_data_->FeatureGroupData(i);
+       Log::Debug(""Started copying dense features from CPU to GPU - 2"");
+       CUDASUCCESS_OR_FATAL(cudaMemcpyAsync(&device_features[copied_feature * num_data_], tmp_data, sizes_in_byte, cudaMemcpyHostToDevice, stream_[device_id]));",should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type.
+758,"@@ -51,10 +51,10 @@ class TestCube(ComparisonTestCase):
+     def test_dimension_values_vdim(self):
+         cube = Dataset(self.cube, kdims=['longitude', 'latitude'])
+         self.assertEqual(cube.dimension_values('unknown', flat=False),
+-                         np.flipud(np.array([[ 0,  4,  8],
+-                                             [ 1,  5,  9],
+-                                             [ 2,  6, 10],
+-                                             [ 3,  7, 11]], dtype=np.int32).T))
++                         np.array([[ 0,  4,  8],
++                                   [ 1,  5,  9],
++                                   [ 2,  6, 10],
++                                   [ 3,  7, 11]], dtype=np.int32).T)
+
+     def test_range_kdim(self):
+         cube = Dataset(self.cube, kdims=['longitude', 'latitude'])",As long as you are sure this is definitely correct now... :-)
+759,"@@ -166,7 +166,7 @@ public class ActionsFragment extends SubscriberFragment implements View.OnClickL
+                             tempBasal.setVisibility(View.GONE);
+                             tempBasalCancel.setVisibility(View.VISIBLE);
+                             final TemporaryBasal activeTemp = MainApp.getConfigBuilder().getTempBasalFromHistory(System.currentTimeMillis());
+-                            tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + ""\n"" + activeTemp.toStringShort());
++                            tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + "" "" + activeTemp.toStringShort());
+                         } else {
+                             tempBasal.setVisibility(View.VISIBLE);
+                             tempBasalCancel.setVisibility(View.GONE);",... so that all action buttons have the same height :-)
+760,"@@ -21,6 +21,12 @@
+ #include <fastdds/dds/log/Log.hpp>
+ #include <fastdds/dds/log/Colors.hpp>
+ #include <fastrtps/xmlparser/XMLProfileManager.h>
++#include <fastdds/dds/domain/DomainParticipantFactory.hpp>
++#include <fastdds/dds/domain/DomainParticipant.hpp>
++#include <fastdds/dds/publisher/DataWriterListener.hpp>
++#include <fastdds/dds/subscriber/qos/DataReaderQos.hpp>
++#include <fastdds/dds/subscriber/DataReader.hpp>
++#include <fastdds/dds/publisher/DataWriter.hpp>
+
+ #include <numeric>
+ #include <cmath>","Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `""LatencyTestPublisher.hpp""`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers"
+761,"@@ -58,6 +58,10 @@ type OutboundOption func(*Outbound)
+
+ func (OutboundOption) httpOption() {}
+
++// RequestFactory allows clients to configure their outgoing http requests. If not set,
++// a default implemenation will use the HostPort to make a POST request with the request body.
++type RequestFactory func(*transport.Request) (*http.Request, error)
++
+ // URLTemplate specifies the URL this outbound makes requests to. For
+ // peer.Chooser-based outbounds, the peer (host:port) spection of the URL may
+ // vary from call to call but the rest will remain unchanged. For single-peer","I hate this name, open to suggestions."
+762,"@@ -199,7 +199,13 @@ func (c *Client) locallyCacheResults(target *core.BuildTarget, digest *pb.Digest
+ 	}
+ 	data, _ := proto.Marshal(ar)
+ 	metadata.RemoteAction = data
+-	c.state.Cache.Store(target, c.localCacheKey(digest), nil)
++	// TODO(jpoole): Similar to retrieveTargetMetadataFromCache, it would be cleaner if we could store
++	//               into the cache from an arbitrary reader.
++	if err := build.StoreTargetMetadata(target, metadata); err != nil {
++		log.Warning(""%s"", err)
++		return
++	}
++	c.state.Cache.Store(target, c.localCacheKey(digest), []string{target.TargetBuildMetadataFileName()})
+ }
+
+ // retrieveLocalResults retrieves locally cached results for a target if possible.",Does this log line work? We need Warningf or just warning without the format string.
+763,"@@ -62,6 +62,7 @@ func New(checkpointer export.Checkpointer, exporter export.Exporter, opts ...Opt
+ 	impl := sdk.NewAccumulator(
+ 		checkpointer,
+ 		sdk.WithResource(c.Resource),
++		sdk.WithMetricsProcessors(c.MetricsProcessors...),
+ 	)
+ 	return &Controller{
+ 		provider:     registry.NewMeterProvider(impl),",The pull controller would need similar updates.
+764,"@@ -1,5 +1,5 @@
+ /**
+- * Copyright 2015-2017 The OpenZipkin Authors
++ * Copyright 2015-2018 The OpenZipkin Authors
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except
+  * in compliance with the License. You may obtain a copy of the License at",ignore this.. just didn't want to litter with a commit update to satisfy license plugin
+765,"@@ -807,8 +807,8 @@ module Beaker
+         end
+
+         if host['is_cygwin'].nil? or host['is_cygwin'] == true
+-          dest = ""/cygdrive/c/Windows/Temp/#{host['dist']}.msi""
+-          on host, ""curl -O #{dest} #{link}""
++          dest = ""#{host['dist']}.msi""
++          on host, ""curl -O #{link}""
+
+           #Because the msi installer doesn't add Puppet to the environment path
+           #Add both potential paths for simplicity",Is this definition needed since it doesn't look like it's being used anywhere?
+766,"@@ -35,6 +35,11 @@ module Mongoid
+           class << self
+             delegate :discriminator_key, to: ::Mongoid
+           end
++        end
++
++        unless fields.has_key?(self.discriminator_key) || descendants.length == 0
++          default_proc = lambda { self.class.name }
++          field(self.discriminator_key, default: default_proc, type: String)
+         end
+       end
+     end",Can this condition be reworded using `if` please?
+767,"@@ -135,13 +135,15 @@ Status FetchEdgesExecutor::setupEdgeKeysFromRef() {
+     const InterimResult *inputs;
+     if (sentence_->ref()->isInputExpr()) {
+         inputs = inputs_.get();
+-        if (inputs == nullptr) {
++        if (inputs == nullptr
++                || (inputs != nullptr && !inputs->hasData())) {
+             // we have empty imputs from pipe.
+             return Status::OK();
+         }
+     } else {
+         inputs = ectx()->variableHolder()->get(varname_);
+-        if (inputs == nullptr) {
++        if (inputs == nullptr
++                || (inputs != nullptr && !inputs->hasData())) {
+             return Status::Error(""Variable `%s' not defined"", varname_.c_str());
+         }
+     }","after ||, no need inputs != nullptr"
+768,"@@ -159,7 +159,14 @@ func (s *Source) Owner() (string, error) {
+ // is deloying to and the containerized applications that will be deployed.
+ type PipelineStage struct {
+ 	*AssociatedEnvironment
+-	LocalApplications []string
++	LocalApplications []AppInStage
++}
++
++// AppInStage represents configurations for an app in a pipeline stage
++type AppInStage struct {
++	Name string
++	// the path to the integration test buildspec for this action
++	IntegTestBuildspecPath string
+ }
+
+ // AppTemplatePath returns the full path to the application CFN template",Is it just preference or on purpose that using slice of structs instead of slice of pointers?
+769,"@@ -90,7 +90,7 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi
+ 					c.state = c._nextState;
+ 					c._dirty = false;
+ 					c._vnode = newVNode;
+-					newVNode._dom = oldDom!=null ? oldDom!==oldVNode._dom ? oldDom : oldVNode._dom : null;
++					newVNode._dom = oldVNode._dom;
+ 					newVNode._children = oldVNode._children;
+ 					for (tmp = 0; tmp < newVNode._children.length; tmp++) {
+ 						if (newVNode._children[tmp]) newVNode._children[tmp]._parent = newVNode;",This line always confused me   anyway. Good catch!
+770,"@@ -130,6 +130,6 @@ func (j journalBlockServer) IsUnflushed(ctx context.Context, tlfID tlf.ID,
+ }
+
+ func (j journalBlockServer) Shutdown() {
+-	j.jServer.shutdown()
++	j.jServer.shutdown(context.Background())
+ 	j.BlockServer.Shutdown()
+ }","Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much."
+771,"@@ -42,7 +42,7 @@ bool DeadlineQosPolicy::addToCDRMessage(CDRMessage_t* msg)
+     bool valid = CDRMessage::addUInt16(msg, this->Pid);
+     valid &= CDRMessage::addUInt16(msg, this->length);//this->length);
+     valid &= CDRMessage::addInt32(msg,period.seconds);
+-    valid &= CDRMessage::addUInt32(msg,period.fraction);
++    valid &= CDRMessage::addUInt32(msg,period.nanosec);
+     return valid;
+ }
+ ",Duration_t at RTPS level must be serialized using fractions.
+772,"@@ -28,6 +28,14 @@ import (
+ 	""go.uber.org/yarpc/yarpcerrors""
+ )
+
++var msgInboundDispatcherNotRunning = ""peer for service %q is not running""
++
++// NotRunningInboundError builds a YARPC error with code
++// yarpcerrors.CodeUnavailable when the dispatcher is not running.
++func NotRunningInboundError(service string) error {
++	return yarpcerrors.UnavailableErrorf(msgInboundDispatcherNotRunning, service)
++}
++
+ // RequestBodyDecodeError builds a YARPC error with code
+ // yarpcerrors.CodeInvalidArgument that represents a failure to decode
+ // the request body.","""peer"" has its own meaning within YARPC with its own class of objects. This should probably be ""dispatcher"" too?"
+773,"@@ -172,9 +172,18 @@ class ClangSA(analyzer_base.SourceAnalyzer):
+                                          '-Xclang', checker_name])
+
+             if config.ctu_dir and not self.__disable_ctu:
++                # ctu-clang5 compatibility
+                 analyzer_cmd.extend(['-Xclang', '-analyzer-config',
+                                      '-Xclang',
+-                                     'xtu-dir=' + self.get_xtu_dir()])
++                                     'xtu-dir=' + self.get_ctu_dir()])
++                # ctu-clang6 compatibility (5.0 and 6.0 options work together)
++                analyzer_cmd.extend(['-Xclang', '-analyzer-config',
++                                     '-Xclang',
++                                     'experimental-enable-naive-ctu-analysis'
++                                     '=true',
++                                     '-Xclang', '-analyzer-config',
++                                     '-Xclang',
++                                     'ctu-dir=' + self.get_ctu_dir()])
+                 if config.ctu_has_analyzer_display_ctu_progress:
+                     analyzer_cmd.extend(['-Xclang',
+                                          '-analyzer-display-ctu-progress'])",I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together.
+774,"@@ -34,18 +34,10 @@ import (
+ // the default value in Default var.
+
+ func init() {
+-	flag.StringVar(&_overwritePath, ""config-path"", """", ""Config path"")
+-	flag.StringVar(&_secretPath, ""secret-path"", """", ""Secret path"")
+-	flag.StringVar(&_subChainPath, ""sub-config-path"", """", ""Sub chain Config path"")
+ 	flag.Var(&_plugins, ""plugin"", ""Plugin of the node"")
+ }
+
+ var (
+-	// overwritePath is the path to the config file which overwrite default values
+-	_overwritePath string
+-	// secretPath is the path to the  config file store secret values
+-	_secretPath   string
+-	_subChainPath string
+ 	_plugins      strs
+ 	_evmNetworkID uint32
+ 	loadChainID   sync.Once",_plugins should be removed too
+775,"@@ -0,0 +1,5 @@
++let nn = node.nodeName.toLowerCase();
++let validSetup =
++	node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area');
++let validAttrValue = /^\s+$/.test(node.getAttribute('alt'));
++return validSetup && validAttrValue;","The rule selector will not include `<input>` and `<area>` elements. Why not make this a new, separate rule altogether?"
+776,"@@ -1122,7 +1122,7 @@ class CommandDispatcher:
+         try:
+             userscripts.run_async(tab, cmd, *args, win_id=self._win_id,
+                                   env=env, verbose=verbose)
+-        except userscripts.UnsupportedError as e:
++        except (userscripts.UnsupportedError, userscripts.NotFoundError) as e:
+             raise cmdexc.CommandError(e)
+
+     @cmdutils.register(instance='command-dispatcher', scope='window')",@The-Compiler Is this style okay or would you prefer a common userscript exception base?
+777,"@@ -98,7 +98,8 @@ SchemaBuffer.prototype.cast = function (value, doc, init) {
+
+     return value;
+   } else if (value instanceof Binary) {
+-    return new MongooseBuffer(value.value(true), [this.path, doc]);
++    var sub_type = value.sub_type || 0x00;
++    return (new MongooseBuffer(value.value(true), [this.path, doc])).toObject(sub_type);
+   }
+
+   if (null === value) return value;",we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead.
+778,"@@ -1158,7 +1158,6 @@ function updateDocuments(coll, selector, document, options, callback) {
+   if ('function' === typeof options) (callback = options), (options = null);
+   if (options == null) options = {};
+   if (!('function' === typeof callback)) callback = null;
+-
+   // If we are not providing a selector or document throw
+   if (selector == null || typeof selector !== 'object')
+     return callback(toError('selector must be a valid JavaScript object'));",Let's remove this change.
+779,"@@ -727,7 +727,7 @@ def processNegativeStates(role, states, reason, negativeStates=None):
+ 	# but only if it is either focused or this is something other than a change event.
+ 	# The condition stops ""not selected"" from being spoken in some broken controls
+ 	# when the state change for the previous focus is issued before the focus change.
+-	if role in (ROLE_LISTITEM, ROLE_TREEVIEWITEM, ROLE_TABLEROW) and STATE_SELECTABLE in states and (reason != REASON_CHANGE or STATE_FOCUSED in states):
++	if role in (ROLE_LISTITEM, ROLE_TREEVIEWITEM, ROLE_TABLEROW,ROLE_TABLECELL,ROLE_TABLECOLUMNHEADER,ROLE_TABLEROWHEADER) and STATE_SELECTABLE in states and (reason != REASON_CHANGE or STATE_FOCUSED in states):
+ 		speakNegatives.add(STATE_SELECTED)
+ 	# Restrict ""not checked"" in a similar way to ""not selected"".
+ 	if (role in (ROLE_CHECKBOX, ROLE_RADIOBUTTON, ROLE_CHECKMENUITEM) or STATE_CHECKABLE in states)  and (STATE_HALFCHECKED not in states) and (reason != REASON_CHANGE or STATE_FOCUSED in states):",Could you split this into multiple lines?
+780,"@@ -25,12 +25,17 @@ import { __ } from '@wordpress/i18n';
+ /**
+  * Internal dependencies
+  */
+-import Layout from '../../../components/layout/layout';
++import Data from 'googlesitekit-data';
+ import DashboardModuleHeader from '../../../components/dashboard/dashboard-module-header';
+ import DashboardPageSpeed from '../components/DashboardPageSpeed';
++import { STORE_NAME } from '../../../googlesitekit/datastore/site/constants';
++const { useSelect } = Data;
+
+ function DashboardSpeed() {
+-	const description = global.googlesitekit.permaLink ? __( 'How fast this page is.', 'google-site-kit' ) : __( 'How fast your home page is.', 'google-site-kit' );
++	const currentEntityURL = useSelect( ( select ) => select( STORE_NAME ).getCurrentEntityURL() );
++	const description = currentEntityURL
++		? __( 'How fast your page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' )
++		: __( 'How fast your home page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' );
+
+ 	return (
+ 		<Fragment>","This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that."
+781,"@@ -69,9 +69,9 @@ func (c *WSClient) Connect() (conn.Connection, error) {
+ 	if resp != nil {
+ 		body, errRead := ioutil.ReadAll(resp.Body)
+ 		if errRead == nil {
+-			respMsg = fmt.Sprintf(""response code: %d, response body: %s"", resp.StatusCode, string(body))
++			respMsg = fmt.Sprintf(""Response code: %d, response body: %s"", resp.StatusCode, string(body))
+ 		} else {
+-			respMsg = fmt.Sprintf(""response code: %d"", resp.StatusCode)
++			respMsg = fmt.Sprintf(""Response code: %d"", resp.StatusCode)
+ 		}
+ 		resp.Body.Close()
+ 	}",It does not recommend capitalization
+782,"@@ -113,6 +113,17 @@ feature 'User creates a subscription' do
+     expect(page).to have_content(I18n.t('subscriptions.flashes.update.success'))
+   end
+
++  scenario 'updates Stripe subscription with declining credit card', :js => true do
++    FakeStripe.failure = true
++    sign_in_as_subscriber
++    visit my_account_path
++    submit_declining_credit_card_info
++
++    expect(current_path).to eq my_account_path
++    expect(page).to_not have_content(I18n.t('subscriptions.flashes.update.success'))
++    expect(page).to have_content 'Your credit card was declined'
++  end
++
+   scenario 'does not see option to update billing if not subscribing' do
+     visit my_account_path
+ ","Minor thing, but can you use 1.9 hash syntax for this?"
+783,"@@ -361,6 +361,7 @@ class LambdaExecutorReuseContainers(LambdaExecutorContainers):
+
+                 mount_volume = not config.LAMBDA_REMOTE_DOCKER
+                 lambda_cwd_on_host = Util.get_host_path_for_path_in_docker(lambda_cwd)
++                lambda_cwd_on_host = Util.format_windows_path(lambda_cwd)
+                 mount_volume_str = '-v ""%s"":/var/task' % lambda_cwd_on_host if mount_volume else ''
+
+                 # Create and start the container",I tried to follow the code structure already present.
+784,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?
+785,"@@ -118,7 +118,7 @@ class ExperimentTestBaseClass(HelperTestCaseBase):
+     global g_myEnv
+     if not g_myEnv:
+       # Setup environment
+-      params = type('obj', (object,), {'installDir' : os.environ['NUPIC']})
++      params = type('obj', (object,), {'installDir' : resource_filename(""nupic"","""")})
+       g_myEnv = MyTestEnvironment(params)
+
+ ",Please leave 1 space char between commas here and other places in this PR.
+786,"@@ -100,8 +100,8 @@ bool ThreadsExec::spawn() {
+
+   pthread_attr_t attr;
+
+-  if (0 == pthread_attr_init(&attr) ||
+-      0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) ||
++  if (0 == pthread_attr_init(&attr) &&
++      0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) &&
+       0 == pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED)) {
+     pthread_t pt;
+ ",hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?
+787,"@@ -149,7 +149,8 @@ public class PackageTool extends SolrCLI.ToolBase {
+                 String version = parsedVersion.second();
+                 boolean noprompt = cli.hasOption('y');
+                 boolean isUpdate = cli.hasOption(""update"") || cli.hasOption('u');
+-                packageManager.deploy(packageName, version, PackageUtils.validateCollections(cli.getOptionValue(""collections"").split("","")), cli.getOptionValues(""param""), isUpdate, noprompt);
++                String collections[] = cli.hasOption(""collections"")? PackageUtils.validateCollections(cli.getOptionValue(""collections"").split("","")): new String[] {};
++                packageManager.deploy(packageName, version, collections, cli.hasOption(""cluster""), cli.getOptionValues(""param""), isUpdate, noprompt);
+                 break;
+               }
+               case ""undeploy"":",Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this
+788,"@@ -259,6 +259,12 @@ bool pmix_value_cmp(pmix_value_t *p, pmix_value_t *p1)
+         case PMIX_STRING:
+             rc = strcmp(p->data.string, p1->data.string);
+             break;
++        case PMIX_COMPRESSED_STRING:
++            if (p->data.bo.size != p1->data.bo.size) {
++                return false;
++            } else {
++                return true;
++            }
+         case PMIX_STATUS:
+             rc = (p->data.status == p1->data.status);
+             break;",@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same.
+789,"@@ -1601,6 +1601,7 @@ void nano::json_handler::bootstrap ()
+ {
+ 	std::string address_text = request.get<std::string> (""address"");
+ 	std::string port_text = request.get<std::string> (""port"");
++	const bool confirmed_frontiers = request.get<bool> (""confirmed_frontiers"", false);
+ 	boost::system::error_code address_ec;
+ 	auto address (boost::asio::ip::address_v6::from_string (address_text, address_ec));
+ 	if (!address_ec)",I think `bypass_frontier_confirmation` conveys the intention better (default false as well)
+790,"@@ -5,12 +5,9 @@ import (
+ 	""fmt""
+ 	""testing""
+
+-	""github.com/ipfs/go-cid""
+-	""github.com/ipfs/go-hamt-ipld""
+-	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/assert""
+-	""github.com/stretchr/testify/require""
+
++	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/chain""
+ 	""github.com/filecoin-project/go-filecoin/config""
+ 	""github.com/filecoin-project/go-filecoin/core""","This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too."
+791,"@@ -666,9 +666,10 @@ class AbstractAudio(QObject):
+     muted_changed = pyqtSignal(bool)
+     recently_audible_changed = pyqtSignal(bool)
+
+-    def __init__(self, parent=None):
++    def __init__(self, tab, parent=None):
+         super().__init__(parent)
+         self._widget = None
++        self._tab = tab
+
+     def set_muted(self, muted: bool):
+         """"""Set this tab as muted or not.""""""",You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`.
+792,"@@ -1,19 +1,3 @@
+-/*
+-Copyright 2019 The Kubernetes Authors.
+-
+-Licensed under the Apache License, Version 2.0 (the ""License"");
+-you may not use this file except in compliance with the License.
+-You may obtain a copy of the License at
+-
+-    http://www.apache.org/licenses/LICENSE-2.0
+-
+-Unless required by applicable law or agreed to in writing, software
+-distributed under the License is distributed on an ""AS IS"" BASIS,
+-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-See the License for the specific language governing permissions and
+-limitations under the License.
+-*/
+-
+ package helpers
+
+ import (",@csrwng what should we do here? This one is from origin.
+793,"@@ -17,6 +17,7 @@
+ #include <LightGBM/utils/openmp_wrapper.h>
+ #include <LightGBM/utils/random.h>
+ #include <LightGBM/utils/threading.h>
++#include <LightGBM/utils/LocaleContext.h>
+
+ #include <string>
+ #include <cstdio>",Follow alphabetical order.
+794,"@@ -0,0 +1,16 @@
++// <copyright file=""IAutomaticTracer.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.ClrProfiler
++{
++    internal interface IAutomaticTracer : ICommonTracer
++    {
++        object GetDistributedTrace();
++
++        void SetDistributedTrace(object trace);
++
++        void Register(object manualTracer);
++    }
++}","As far as I can tell, these always get and set the context as an `IReadOnlyDictionary<string, string>`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary<string, string>`?"
+795,"@@ -206,7 +206,7 @@ class CompletionItemDelegate(QStyledItemDelegate):
+             else:
+                 self._doc.setPlainText(self._opt.text)
+         else:
+-            self._doc.setHtml('<b>{}</b>'.format(html.escape(self._opt.text)))
++            self._doc.setHtml('{}'.format(html.escape(self._opt.text)))
+
+     def _draw_focus_rect(self):
+         """"""Draw the focus rectangle of an ItemViewItem.""""""","As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`"
+796,"@@ -161,6 +161,8 @@ public class Constants {
+
+     // enable Quartz Scheduler if true.
+     public static final String ENABLE_QUARTZ= ""azkaban.server.schedule.enable_quartz"";
++
++    public static final String CUSTOM_CREDENTIAL_NAME = ""azkaban.security.credential"";
+   }
+
+   public static class FlowProperties {",Where would this be configured? In azkaban.properties?
+797,"@@ -2101,6 +2101,12 @@ Collection.prototype.findOneAndUpdate = function(filter, update, options, callba
+   if (typeof options === 'function') (callback = options), (options = {});
+   options = options || {};
+
++  var err = checkForAtomicOperators(update);
++  if (err) {
++    if (typeof callback === 'function') return callback(err);
++    return this.s.promiseLibrary.reject(err);
++  }
++
+   // Basic validation
+   if (filter == null || typeof filter !== 'object')
+     throw toError('filter parameter must be an object');",1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`.
+798,"@@ -29,6 +29,13 @@ struct st_h2o_multithread_queue_t {
+ #if H2O_USE_LIBUV
+     uv_async_t async;
+ #else
++#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
++/**
++ * The kernel overhead of an eventfd file descriptor is
++ * much lower than that of a pipe, and only one file descriptor is required
++ */
++#define H2O_ASYNC_NOTIFY_USING_EVENTFD
++#endif
+     struct {
+         int write;
+         h2o_socket_t *read;","Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users."
+799,"@@ -61,6 +61,7 @@ public class DatabaseTransferConsumer implements IDataTransferConsumer<DatabaseC
+         IDataTransferNodePrimary, DBPReferentialIntegrityController {
+     private static final Log log = Log.getLog(DatabaseTransferConsumer.class);
+
++    private DBCStatistics statistics = new DBCStatistics();
+     private DatabaseConsumerSettings settings;
+     private DatabaseMappingContainer containerMapping;
+     private ColumnMapping[] columnMappings;",This field could be `final`.
+800,"@@ -62,8 +62,14 @@ module Beaker
+     def close
+       begin
+         @ssh.close if @ssh
+-      rescue
+-        @ssh.shutdown!
++      rescue => e
++        @logger.warn ""Attemped ssh.close.  Caught an error: #{e.message}  Attempting ssh.shutdown!...""
++        begin
++          @ssh.shutdown!
++        rescue => e
++          @logger.warn ""Attemped ssh.shutdown!.  Caught an error: #{e.message}. Giving up and destorying ssh.""
++          @ssh = nil
++        end
+       end
+       @ssh = nil
+     end",would be good to have a test for the case when `shutdown!` raises
+801,"@@ -2747,6 +2747,10 @@ short HbaseInsert::codeGen(Generator *generator)
+
+   generator->initTdbFields(hbasescan_tdb);
+
++  if (CmpCommon::getDefault(HBASE_ASYNC_OPERATIONS) == DF_ON
++           && t == ComTdbHbaseAccess::INSERT_)
++     hbasescan_tdb->setAsyncOperations(TRUE);
++
+   if (getTableDesc()->getNATable()->isSeabaseTable())
+     {
+       hbasescan_tdb->setSQHbaseTable(TRUE);",Does upsert pass this check also?
+802,"@@ -43,6 +43,9 @@ func (r *helper) Patch(name types.NamespacedName, kind, apiVersion string, patch
+ 			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Warn(""running the patch command failed"")
+ 		return err
+ 	}
++	r.logger.
++		WithField(""stdout"", ioStreams.Out.(*bytes.Buffer).String()).
++		WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Info(""patch command successful"")
+ 	return nil
+ }
+ ","Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all."
+803,"@@ -23,6 +23,7 @@ import (
+ const (
+ 	kbfsRepoDir         = "".kbfs_git""
+ 	kbfsConfigName      = ""kbfs_config""
++	kbfsConfigNameTemp  = ""._kbfs_config""
+ 	gitSuffixToIgnore   = "".git""
+ 	kbfsDeletedReposDir = "".kbfs_deleted_repos""
+ )",I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems.
+804,"@@ -1,4 +1,4 @@
+-class AddIndexOnSectionIdAndTeacherIdToSectionTeachers < ActiveRecord::Migration
++class AddIndexOnSectionIdAndTeacherIdToSectionTeachers < ActiveRecord::Migration[4.2]
+   def up
+     change_table :section_teachers do |t|
+       t.remove_index :section_id",Metrics/LineLength: Line is too long. [85/80]
+805,"@@ -19,12 +19,13 @@
+
+ package org.apache.iceberg.flink;
+
+-
+ import java.util.List;
+ import org.apache.flink.table.api.SqlParserException;
+ import org.apache.iceberg.AssertHelpers;
+ import org.apache.iceberg.FileFormat;
+ import org.apache.iceberg.catalog.Namespace;
++import org.apache.iceberg.events.Listeners;
++import org.apache.iceberg.events.ScanEvent;
+ import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+ import org.junit.After;
+ import org.junit.Assert;",Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes.
+806,"@@ -112,7 +112,10 @@ static int http_post(struct flb_out_http *ctx,
+                         payload_buf, payload_size,
+                         ctx->host, ctx->port,
+                         ctx->proxy, 0);
+-
++    if (!c) {
++        flb_plg_error(ctx->ins, ""[http_client] failed to create HTTP client"");
++        return FLB_RETRY;
++    }
+
+     if (c->proxy.host) {
+         flb_plg_debug(ctx->ins, ""[http_client] proxy host: %s port: %i"",","thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too."
+807,"@@ -492,10 +492,13 @@ class MainWindow(QWidget):
+     @pyqtSlot(bool)
+     def _on_fullscreen_requested(self, on):
+         if on:
+-            self.state_before_fullscreen = self.windowState()
+-            self.showFullScreen()
++            self.window_state_before_fullscreen = self.windowState()
++            self.config_state_before_fullscreen = config.val.content.desktop_fullscreen
++            if config.val.content.desktop_fullscreen:
++                self.showFullScreen()
+         elif self.isFullScreen():
+-            self.setWindowState(self.state_before_fullscreen)
++            if config.val.content.desktop_fullscreen or self.config_state_before_fullscreen:
++                self.setWindowState(self.window_state_before_fullscreen)
+         log.misc.debug('on: {}, state before fullscreen: {}'.format(
+             on, debug.qflags_key(Qt, self.state_before_fullscreen)))
+ ","If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`)."
+808,"@@ -53,6 +53,7 @@ public class MapLayerMetadata implements Serializable {
+     // ForeignKey to DataFile
+     //x@ManyToOne
+     // For now, make this unique:  Each DataFile may only have one map
++    //@OneToOne(cascade = {CascadeType.REMOVE, CascadeType.MERGE, CascadeType.PERSIST}) // TODO: Figure out why this doesn't work.
+     @JoinColumn(nullable=false, unique=true)
+     private DataFile dataFile;
+ ","As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this."
+809,"@@ -84,5 +84,8 @@ func (a *action) Matches(act coretesting.Action) error {
+ 		return nil
+ 	}
+
++	fmt.Printf(""EXP:%+v\n"", objExp.GetObject())
++	fmt.Printf(""ACT:%+v\n"", objExp.GetObject())
++
+ 	return fmt.Errorf(""unexpected difference between actions: %s"", pretty.Diff(objExp.GetObject(), objAct.GetObject()))
+ }","Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes  "
+810,"@@ -63,6 +63,9 @@ const (
+
+ 	// SecretTypeEnv is to show secret type being ENVIRONMENT_VARIABLE
+ 	SecretTypeEnv = ""ENVIRONMENT_VARIABLE""
++
++	// TargetLogDriver is to show secret target being ""LOG_DRIVER"", the default will be ""CONTAINER""
++	SecretTargetLogDriver = ""LOG_DRIVER""
+ )
+
+ // DockerConfig represents additional metadata about a container to run. It's",where is the default being set?
+811,"@@ -154,7 +154,7 @@ static void found_package_cb (const char *line,
+ 		vString *name = vStringNew ();
+ 		tagEntryInfo tag;
+
+-		vStringNCopyS (name, line + matches[1].start, matches[1].length);
++		vStringNCopyS (name, line + matches[2].start, matches[2].length);
+ 		initTagEntry (&tag, vStringValue (name), RpmSpecKinds + K_PACKAGE);
+ 		tag.extensionFields.scopeIndex = *(int *)userData;
+ 		makeTagEntry (&tag);",these changes should likely be in the next commit instead
+812,"@@ -26,9 +26,12 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ )
+
++type Foobar struct {
++	Foo string
++}
++
+ // TestFormat ensures the formatter and AddonTransform works as expected.
+ func TestFormat(t *testing.T) {
+-	// TODO: Add table formatter tests after implementing table formatter
+ 	for _, tc := range []struct {
+ 		name            string
+ 		singleton       bool","Since you have defined this struct, I would suggest to replace all exist literal structs by this."
+813,"@@ -168,6 +168,7 @@ public class K9 extends Application {
+     private static boolean mAnimations = true;
+
+     private static boolean mConfirmDelete = false;
++    private static boolean mConfirmMenuDiscard = true;
+     private static boolean mConfirmDeleteStarred = false;
+     private static boolean mConfirmSpam = false;
+     private static boolean mConfirmDeleteFromNotification = true;",The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice.
+814,"@@ -192,6 +192,15 @@ class FileProvider extends BaseProvider
+             return;
+         }
+
++        // is_file will cause a fatal error if binary content is not a string
++        if (!is_string($media->getBinaryContent())) {
++            throw new \RuntimeException(sprintf(
++                'Invalid data provided for binary content, choose among: string, %s, %s',
++                'Symfony\Component\HttpFoundation\File\File',
++                'Symfony\Component\HttpFoundation\Request'
++            ));
++        }
++
+         // if the binary content is a filename => convert to a valid File
+         if (!is_file($media->getBinaryContent())) {
+             throw new \RuntimeException('The file does not exist : '.$media->getBinaryContent());",what if `$media->getBinaryContent() == Symfony\Component\HttpFoundation\File\File` does `is_string()` return `true`? ping @greg0ire
+815,"@@ -1065,11 +1065,9 @@ void GenStruct(StructDef &struct_def, std::string *code_ptr) {
+       }
+     }
+   // generate object accessors if is nested_flatbuffer
++  if (field.nested_flatbuffer) {
+   auto nested = field.attributes.Lookup(""nested_flatbuffer"");
+-  if (nested) {
+-    auto nested_qualified_name =
+-      parser_.namespaces_.back()->GetFullyQualifiedName(nested->constant);
+-    auto nested_type = parser_.structs_.Lookup(nested_qualified_name);
++	auto nested_type = nested->type.struct_def;
+     auto nested_type_name = WrapInNameSpace(*nested_type);
+     auto nestedMethodName = MakeCamel(field.name, lang_.first_camel_upper)
+       + ""As"" + nested_type_name;",maybe rather than `bool` make this field a `StructDef *` ?
+816,"@@ -209,6 +209,13 @@ func (fbm *folderBlockManager) enqueueBlocksToDelete(toDelete blocksToDelete) {
+ 	fbm.blocksToDeleteChan <- toDelete
+ }
+
++func (fbm *folderBlockManager) enqueueBlocksToDeleteAfterShortDelay(
++	toDelete blocksToDelete) {
++	fbm.blocksToDeleteWaitGroup.Add(1)
++	time.AfterFunc(10*time.Millisecond,
++		func() { fbm.blocksToDeleteChan <- toDelete })
++}
++
+ // enqueueBlocksToDeleteNoWait enqueues blocks to be deleted just like
+ // enqueueBlocksToDelete, except that when fbm.blocksToDeleteChan is full, it
+ // doesn't block, but instead spawns a goroutine to handle the sending.",Shall we maybe put this in a `const` like `backgroundTaskTimeout`?
+817,"@@ -272,6 +272,11 @@ namespace Datadog.Trace.TestHelpers
+                     ctx.Response.OutputStream.Write(buffer, 0, buffer.Length);
+                     ctx.Response.Close();
+                 }
++                catch (InvalidOperationException)
++                {
++                    // this can occur when setting Response.ContentLength64, with the framework claiming that the response has already been submitted
++                    // for now ignore, and we'll see if this introduces downstream issues
++                }
+                 catch (HttpListenerException)
+                 {
+                     // listener was stopped,",CI is complaining about this.
+818,"@@ -31,6 +31,14 @@ import java.util.Date;
+  */
+ public class DefaultHistoryRemovalTimeProvider implements HistoryRemovalTimeProvider {
+
++  public static Date determineRemovalTime(Date initTime, Integer timeToLive) {
++    Calendar removalTime = Calendar.getInstance();
++    removalTime.setTime(initTime);
++    removalTime.add(Calendar.DATE, timeToLive);
++
++    return removalTime.getTime();
++  }
++
+   public Date calculateRemovalTime(HistoricProcessInstanceEventEntity historicRootProcessInstance, ProcessDefinition processDefinition) {
+
+     Integer historyTimeToLive = processDefinition.getHistoryTimeToLive();",Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced.
+819,"@@ -210,6 +210,14 @@ class ImageExtension extends Twig_Extension
+         $htmlAttributes = $attributes;
+         unset($htmlAttributes['type'], $htmlAttributes['size']);
+
++        $useLazyLoading = array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;
++        $isAttributeClassExistsAndNotEmpty = array_key_exists('class', $attributes) && $attributes['class'] !== '';
++        $htmlAttributes['class'] = sprintf(
++            '%s%s',
++            $useLazyLoading ? 'lazy' : '',
++            $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : ''
++        );
++
+         return $this->templating->render('@ShopsysFramework/Common/image.html.twig', [
+             'attr' => $htmlAttributes,
+             'additionalImagesData' => $additionalImagesData,","I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`"
+820,"@@ -22,9 +22,13 @@ AdminJobExecutor::AdminJobExecutor(Sentence *sentence,
+
+ void AdminJobExecutor::execute() {
+     LOG(INFO) << __func__ << "" enter"";
+-    auto opEnum = toAdminJobOp(sentence_->getType());
++    auto optOpEnum = toAdminJobOp(sentence_->getType());
++    if (!optOpEnum) {
++        LOG(ERROR) << ""unknown setence type["" << sentence_->getType() <<""]"";
++    }
+     auto paras = sentence_->getParas();
+
++    auto opEnum = *optOpEnum;
+     if (opNeedsSpace(opEnum)) {
+         auto status = checkIfGraphSpaceChosen();
+         if (!status.ok()) {",when Op is illegal should return here?
+821,"@@ -447,8 +447,6 @@ public class FlowRunnerManager implements EventListener,
+             } catch (IOException e) {
+               logger.error(e);
+             }
+-
+-            installedVersions.remove(versionKey);
+           }
+         }
+       }",don't we need to remove the project version from installedVersions?
+822,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.
+823,"@@ -51,7 +51,10 @@ func (s *DaemonServer) FlushIPSets(ctx context.Context, req *pb.IPSetsRequest) (
+ 		ipset := ipset
+ 		s.IPSetLocker.Lock(ipset.Name)
+ 		err := flushIPSet(ctx, req.EnterNS, pid, ipset)
+-		s.IPSetLocker.Unlock(ipset.Name)
++		if err != nil {
++			return nil, err
++		}
++		err = s.IPSetLocker.Unlock(ipset.Name)
+ 		if err != nil {
+ 			return nil, err
+ 		}",This is intended. Pls revert this.
+824,"@@ -68,7 +68,7 @@ interface RedBlackTree<T> extends Iterable<T> {
+
+     static <T extends Comparable<? super T>> RedBlackTree<T> ofAll(Iterable<? extends T> values) {
+         Objects.requireNonNull(values, ""values is null"");
+-        return ofAll((Comparator<? super T> & Serializable) T::compareTo, values);
++        return ofAll(Comparators.naturalComparator(), values);
+     }
+
+     @SuppressWarnings(""unchecked"")","Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated"
+825,"@@ -217,15 +217,10 @@ export default class App extends Component {
+
+   // eslint-disable-next-line no-unused-vars
+   handleClickSearch = (_, { suggestionValue, method }) => {
+-    const { packages } = this.state;
+     switch(method) {
+       case 'click':
+-        window.location.href = getDetailPageURL(suggestionValue);
+-      break;
+       case 'enter':
+-        this.setState({
+-          filteredPackages: packages.filter(pkg => pkg.label.match(suggestionValue))
+-        });
++        window.location.href = getDetailPageURL(suggestionValue);
+       break;
+     }
+   }","I think we need this. Not sure, I'll test."
+826,"@@ -83,7 +83,6 @@ module Beaker
+         host['user'] = 'google_compute'
+
+         disable_se_linux(host, @options)
+-        disable_iptables(host, @options)
+         copy_ssh_to_root(host, @options)
+         enable_root_login(host, @options)
+         host['user'] = default_user","I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact."
+827,"@@ -2,6 +2,7 @@
+ // sources:
+ // build/static/charts/traefik-10.3.001.tgz
+ // build/static/charts/traefik-crd-10.3.001.tgz
++//go:build !no_stage
+ // +build !no_stage
+
+ package static",Did go change their tags with the new version?
+828,"@@ -330,11 +330,15 @@ func (s *Server) newEndpointsServer(ctx context.Context, catalog catalog.Catalog
+ }
+
+ func (s *Server) newBundleManager(cat catalog.Catalog, metrics telemetry.Metrics) *bundle_client.Manager {
++	log := s.config.Log.WithField(telemetry.SubsystemName, ""bundle_client"")
+ 	return bundle_client.NewManager(bundle_client.ManagerConfig{
+-		Log:       s.config.Log.WithField(telemetry.SubsystemName, ""bundle_client""),
++		Log:       log,
+ 		Metrics:   metrics,
+ 		DataStore: cat.GetDataStore(),
+-		Source:    bundle_client.TrustDomainConfigMap(s.config.Federation.FederatesWith),
++		Source: bundle_client.MergeTrustDomainConfigSources(
++			bundle_client.TrustDomainConfigMap(s.config.Federation.FederatesWith),
++			bundle_client.DataStoreTrustDomainConfigSource(log, cat.GetDataStore()),
++		),
+ 	})
+ }
+ ","I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results."
+829,"@@ -192,7 +192,7 @@ func replaceSequenceLabel(state *core.BuildState, target *core.BuildTarget, labe
+ }
+
+ func checkAndReplaceSequence(state *core.BuildState, target, dep *core.BuildTarget, in string, runnable, multiple, dir, outPrefix, hash, test, allOutputs, tool bool) string {
+-	if allOutputs && !multiple && len(dep.Outputs()) != 1 {
++	if allOutputs && !multiple && len(dep.Outputs()) > 1 {
+ 		// Label must have only one output.
+ 		panic(fmt.Sprintf(""Rule %s can't use %s; %s has multiple outputs."", target.Label, in, dep.Label))
+ 	} else if runnable && !dep.IsBinary {",I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit.
+830,"@@ -110,12 +110,14 @@ public class SolrMetricManager {
+
+   public static final int DEFAULT_CLOUD_REPORTER_PERIOD = 60;
+
+-  private MetricRegistry.MetricSupplier<Counter> counterSupplier;
+-  private MetricRegistry.MetricSupplier<Meter> meterSupplier;
+-  private MetricRegistry.MetricSupplier<Timer> timerSupplier;
+-  private MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
++  private final MetricsConfig metricsConfig;
++  private final MetricRegistry.MetricSupplier<Counter> counterSupplier;
++  private final MetricRegistry.MetricSupplier<Meter> meterSupplier;
++  private final MetricRegistry.MetricSupplier<Timer> timerSupplier;
++  private final MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
+
+   public SolrMetricManager() {
++    metricsConfig = new MetricsConfig.MetricsConfigBuilder().build();
+     counterSupplier = MetricSuppliers.counterSupplier(null, null);
+     meterSupplier = MetricSuppliers.meterSupplier(null, null);
+     timerSupplier = MetricSuppliers.timerSupplier(null, null);",*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122.
+831,"@@ -60,12 +60,7 @@ function _command(server, ns, cmd, options, callback) {
+     finalCmd.$clusterTime = clusterTime;
+   }
+
+-  if (
+-    isSharded(server) &&
+-    !shouldUseOpMsg &&
+-    readPreference &&
+-    readPreference.preference !== 'primary'
+-  ) {
++  if (isSharded(server) && !shouldUseOpMsg && readPreference && readPreference.mode !== 'primary') {
+     finalCmd = {
+       $query: finalCmd,
+       $readPreference: readPreference.toJSON()",switch over to .mode
+832,"@@ -125,7 +125,7 @@ describe('HiddenColumns', () => {
+       });
+
+       it('should return correct visual indexes when columns sequence is non-contiguous ' +
+-         '(force desync between physical and visual indexes)', () => {
++        '(force desync between physical and visual indexes)', () => {
+         const hot = handsontable({
+           data: Handsontable.helper.createSpreadsheetData(1, 10),
+           colHeaders: true,",I guess your IDE did some auto-fixing here
+833,"@@ -32,6 +32,7 @@ import org.apache.lucene.search.BooleanClause;
+ import org.apache.lucene.search.BooleanQuery;
+ import org.apache.lucene.search.DisjunctionMaxQuery;
+ import org.apache.lucene.search.FuzzyQuery;
++import org.apache.lucene.search.PhraseQuery;
+ import org.apache.lucene.search.TermQuery;
+
+ public class TestRamUsageEstimator extends LuceneTestCase {",This is an unused import failing recommit still.
+834,"@@ -133,8 +133,12 @@ module Beaker
+               #move to the host
+               logger.debug ""Using scp to transfer #{source_path} to #{target_path}""
+               scp_to host, source_path, target_module_dir, {:ignore => ignore_list}
++
+               #rename to the selected module name, if not correct
+               cur_path = File.join(target_module_dir, source_name)
++              if host.is_powershell? #make sure our slashes are correct
++                cur_path = cur_path.gsub(/\//,'\\')
++              end
+               host.mv cur_path, target_path unless cur_path == target_path
+             when 'rsync'
+               logger.debug ""Using rsync to transfer #{source_path} to #{target_path}""","I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`."
+835,"@@ -52,6 +52,6 @@
+ <%= tinymce :content_css => asset_path('application.css') %>
+
+ <!-- alert for the default template-->
+-<div id=""edit_guidance_alert_dialog"" class=""modal"" style=""display:none"">
++<div id=""edit_guidance_alert_dialog"" class=""modal"" role=""dialog"" aria-label=""<%=_(""Missing Fields Alert"")%>"" style=""display:none"">
+   <ul id=""missing_fields_edit_guidance""></ul>
+ </div>",I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens.
+836,"@@ -44,9 +44,9 @@ const COLUMN_SIZE_MAP_NAME = 'autoColumnSize';
+  * autoColumnSize: {syncLimit: '40%'},
+  * ```
+  *
+- * The plugin uses {@link GhostTable} and {@link SamplesGenerator} for calculations.
+- * First, {@link SamplesGenerator} prepares samples of data with its coordinates.
+- * Next {@link GhostTable} uses coordinates to get cells' renderers and append all to the DOM through DocumentFragment.
++ * The plugin uses GhostTable and SamplesGenerator for calculations.
++ * First, SamplesGenerator prepares samples of data with its coordinates.
++ * Next GhostTable uses coordinates to get cells' renderers and append all to the DOM through DocumentFragment.
+  *
+  * Sampling accepts additional options:
+  * - *samplingRatio* - Defines how many samples for the same length will be used to calculate. Default is `3`.",Should these link be removed?
+837,"@@ -217,11 +217,12 @@ class TabbedBrowser(tabwidget.TabWidget):
+         for tab in self.widgets():
+             self._remove_tab(tab)
+
+-    def close_tab(self, tab):
++    def close_tab(self, tab, add_undo=True):
+         """"""Close a tab.
+
+         Args:
+             tab: The QWebView to be closed.
++            add_undo: Whether the tab close can be undone.
+         """"""
+         last_close = config.get('tabs', 'last-close')
+         count = self.count()",Please make this a keyword-only argument by adding a `*` argument before `add_undo`.
+838,"@@ -201,6 +201,13 @@ var eventStreamWriterTestTmpl = template.Must(
+ 			{{- end }}
+ 		}
+
++		var marshalers request.HandlerList
++		marshalers.PushBackNamed({{ $.API.ProtocolPackage }}.BuildHandler)
++		payloadMarshaler := protocol.HandlerPayloadMarshal{
++			Marshalers: marshalers,
++		}
++		_ = payloadMarshaler
++
+ 		eventMsgs := []eventstream.Message{
+ 			{{- range $idx, $event := $.InputStream.Events }}
+ 				{{- template ""set event message"" Map ""idx"" $idx ""parentShape"" $event.Shape ""eventName"" $event.Name }}",didn't quite follow what this code block is doing.
+839,"@@ -1071,6 +1071,12 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+         }
+
+         function onWindowKeyDown(e) {
++            // FIXME: Conflicts with keyboard navigation
++            // FIXME: Then the keyboard is completely ignored. Need another solution.
++            if (layoutManager.tv) {
++                return void showOsd();
++            }
++
+             if (!currentVisibleMenu && 32 === e.keyCode) {
+                 playbackManager.playPause(currentPlayer);
+                 return void showOsd();","this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then"
+840,"@@ -205,4 +205,17 @@ function patchDOMElement(dom, newVNode, internal, globalContext, commitQueue) {
+ 			dom.firstChild
+ 		);
+ 	}
++
++	if ('value' in newProps && dom._isControlled) {
++		dom._prevValue = newProps.value;
++
++		if (newProps.value !== dom.value) {
++			setProperty(dom, 'value', i, oldProps.value, 0);
++		}
++	} else if ('checked' in newProps && dom._isControlled) {
++		dom._prevValue = newProps.checked;
++		if (newProps.checked !== dom.checked) {
++			setProperty(dom, 'checked', i, oldProps.checked, 0);
++		}
++	}
+ }","After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component"
+841,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package node provides the glue-code needed in order
++// to start a Bee node.
+ package node
+
+ import (","It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node."
+842,"@@ -330,6 +330,8 @@ class ConfigManager(QObject):
+     CHANGED_OPTIONS = {
+         ('content', 'cookies-accept'):
+             _get_value_transformer('default', 'no-3rdparty'),
++        ('storage', 'download-directory'):
++            _get_value_transformer('', '%'),
+     }
+
+     changed = pyqtSignal(str, str)","I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore."
+843,"@@ -88,6 +88,13 @@ public interface Table {
+    */
+   Map<Integer, SortOrder> sortOrders();
+
++  /**
++   * Return the {@link RowKey row key} for this table.
++   *
++   * @return this table's row key.
++   */
++  RowKey rowKey();
++
+   /**
+    * Return a map of string properties for this table.
+    *",Nit: this table's row key map -> this table's row keys map
+844,"@@ -87,7 +87,7 @@ void proj_assign_context( PJ* pj, PJ_CONTEXT *ctx )
+ pj_ctx pj_ctx::createDefault()
+ {
+     pj_ctx ctx;
+-    ctx.debug_level = PJ_LOG_ERROR;
++    ctx.debug_level = PJ_LOG_NONE;
+     ctx.logger = pj_stderr_logger;
+     NS_PROJ::FileManager::fillDefaultNetworkInterface(&ctx);
+ ",this change should be reverted
+845,"@@ -26,8 +26,10 @@ __copyright__ = ""Copyright 2014-2018 Florian Bruhin (The Compiler)""
+ __license__ = ""GPL""
+ __maintainer__ = __author__
+ __email__ = ""mail@qutebrowser.org""
+-__version_info__ = (1, 5, 0)
+-__version__ = '.'.join(str(e) for e in __version_info__)
++__version__ = ""1.5.0""
++__version_info__ = [int(part) for part in __version__.split('.')]
+ __description__ = ""A keyboard-driven, vim-like browser based on PyQt5.""
+
+ basedir = os.path.dirname(os.path.realpath(__file__))
++appdata_path = os.path.join(os.path.dirname(basedir), ""misc"",
++                            ""qutebrowser.appdata.xml"")","I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself."
+846,"@@ -750,8 +750,8 @@ func TestConfigCheck(t *testing.T) {
+                 http_port = 8222
+ 				`,
+ 			err:       errors.New(`Duplicate user ""foo"" detected`),
+-			errorLine: 6,
+-			errorPos:  21,
++			errorLine: 5,
++			errorPos:  19,
+ 		},
+ 		{
+ 			name: ""when accounts block imports are not a list"",",Revert this change and see below why...
+847,"@@ -1,6 +1,6 @@
+ _base_ = [
+     '../_base_/models/cascade_mask_rcnn_r50_fpn.py',
+-    '../_base_/datasets/coco_instance.py',
++    '../_base_/datasets/lvis_v1_instance.py',
+     '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py'
+ ]
+ ",Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.
+848,"@@ -70,7 +70,7 @@ public class NodeOptions {
+       Capabilities caps = info.getCanonicalCapabilities();
+       builders.stream()
+           .filter(builder -> builder.score(caps) > 0)
+-          .peek(builder -> LOG.info(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
++          .peek(builder -> LOG.finest(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
+           .forEach(builder -> {
+             DriverService.Builder freePortBuilder = builder.usingAnyFreePort();
+ ",This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave.
+849,"@@ -52,6 +52,9 @@ type Alert interface {
+ 	// GetKvdbInstance.
+ 	GetKvdbInstance() kvdb.Kvdb
+
++	// RaiseSingleton raises a singleton alert.
++	RaiseSingleton(alert *api.Alert) error
++
+ 	// Raise raises an Alert.
+ 	Raise(alert *api.Alert) error
+ ",This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure.
+850,"@@ -45,6 +45,7 @@ public class JavaProcessJobTest {
+   private JavaProcessJob job = null;
+   private Props props = null;
+   private Logger log = Logger.getLogger(JavaProcessJob.class);
++  private AllJobExecutorTests jobExecutorTests = null;
+
+   private static String classPaths;
+ ","What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method."
+851,"@@ -12,6 +12,7 @@ const mdUsageStr = `Usage:
+
+ The possible subcommands are:
+   dump		Dump metadata objects
++  check		Check metadata objects and their associated blocks for errors
+
+ `
+ ","This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?"
+852,"@@ -136,6 +136,17 @@ void image_data_reader::load() {
+   select_subset_of_data();
+ }
+
++void image_data_reader::setup() {
++  generic_data_reader::setup();
++
++  using InputBuf_T = lbann::cv_image_type<uint8_t>;
++  auto cvMat = cv::Mat(1, get_linearized_data_size(), InputBuf_T::T(1));
++  m_thread_cv_buffer.resize(omp_get_max_threads());
++  for(int tid = 0; tid < omp_get_max_threads(); ++tid) {
++    m_thread_cv_buffer[tid] = cvMat.clone();
++  }
++}
++
+ std::vector<image_data_reader::sample_t> image_data_reader::get_image_list_of_current_mb() const {
+   std::vector<sample_t> ret;
+   ret.reserve(m_mini_batch_size);","Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should."
+853,"@@ -48,6 +48,8 @@ const (
+ 	KindLambdaApp Kind = ""LambdaApp""
+ 	// KindCloudRunApp represents deployment configuration for a CloudRun application.
+ 	KindCloudRunApp Kind = ""CloudRunApp""
++	// KindEcsApp represents deployment configuration for an AWS ECS.
++	KindEcsApp Kind = ""EcsApp""
+ 	// KindSealedSecret represents a sealed secret.
+ 	KindSealedSecret Kind = ""SealedSecret""
+ )",should be `ECSApp`
+854,"@@ -539,7 +539,13 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            rect = self.size.copy()
++            rect.update(self.location)
++            return rect
++
+
+     @property
+     def screenshot_as_base64(self):",flake8 is going to fail on this having 2 lines
+855,"@@ -15,7 +15,6 @@ package podfailure
+
+ import (
+ 	""context""
+-	""errors""
+ 	""fmt""
+ 	""time""
+ ",should we make a dir named controllers/scheduler/podchaos
+856,"@@ -50,9 +50,9 @@ import (
+ )
+
+ const (
+-	//KeyNode represents the key values used for specifying the Node Affinity
++	//KeyNodeHostname represents the key values used for specifying the Node Affinity
+ 	// based on the hostname
+-	KeyNode = ""kubernetes.io/hostname""
++	KeyNodeHostname = ""kubernetes.io/hostname""
+ )
+
+ // NewProvisioner will create a new Provisioner object and initialize",there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?
+857,"@@ -22,12 +22,12 @@ import (
+ 	""fmt""
+ 	""time""
+
++	""github.com/mysteriumnetwork/node/cmd/commands""
++
+ 	""github.com/mysteriumnetwork/node/cmd/commands/cli/clio""
+ 	""github.com/mysteriumnetwork/node/config""
+-	""github.com/mysteriumnetwork/node/config/urfavecli/clicontext""
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/connection/connectionstate""
+-	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/mysteriumnetwork/node/datasize""
+ 	""github.com/mysteriumnetwork/node/identity/registry""
+ 	""github.com/mysteriumnetwork/node/metadata""",Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?
+858,"@@ -122,6 +122,7 @@ public class EmojiPlugin extends Plugin
+ 			case FRIENDSCHAT:
+ 			case PRIVATECHAT:
+ 			case PRIVATECHATOUT:
++			case MODPRIVATECHAT:
+ 				break;
+ 			default:
+ 				return;",Don't think this belongs in this pr
+859,"@@ -206,6 +206,16 @@ func (d *Dispatcher) Inbounds() Inbounds {
+ 	return inbounds
+ }
+
++// Outbounds returns a copy of the map of outbounds for this RPC object.
++// The outbounds are already wrapped with middleware
++func (d *Dispatcher) Outbounds() Outbounds {
++	outbounds := make(Outbounds, len(d.outbounds))
++	for k, v := range d.outbounds {
++		outbounds[k] = v
++	}
++	return outbounds
++}
++
+ // ClientConfig provides the configuration needed to talk to the given
+ // service through an outboundKey. This configuration may be directly
+ // passed into encoding-specific RPC clients.","We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?"
+860,"@@ -37,14 +37,13 @@ namespace MvvmCross.Core.ViewModels
+
+     public interface IMvxViewModel<TParameter> : IMvxViewModel where TParameter : class
+     {
+-        Task Initialize(TParameter parameter);
++        void Declare(TParameter parameter);
+     }
+
+     //TODO: Can we keep the IMvxViewModel syntax here? Compiler complains
+     public interface IMvxViewModelResult<TResult> : IMvxViewModel where TResult : class
+     {
+-        void SetClose(TaskCompletionSource<TResult> tcs, CancellationToken cancellationToken);
+-        Task<bool> Close(TResult result);
++        TaskCompletionSource<object> CloseCompletionSource { get; set; }
+     }
+
+     public interface IMvxViewModel<TParameter, TResult> : IMvxViewModel<TParameter>, IMvxViewModelResult<TResult> where TParameter : class where TResult : class",@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs
+861,"@@ -89,6 +89,13 @@ class SingleStageDetector(BaseDetector):
+         Returns:
+             dict[str, Tensor]: A dictionary of loss components.
+         """"""
++        # NOTE the batched image size information may be useful, e.g.
++        # in DETR, this is needed for the construction of masks, which is
++        # then used for the transformer_head.
++        input_img_shape = tuple(img.size()[-2:])
++        for img_meta in img_metas:
++            img_meta['input_img_shape'] = input_img_shape
++
+         x = self.extract_feat(img)
+         losses = self.bbox_head.forward_train(x, img_metas, gt_bboxes,
+                                               gt_labels, gt_bboxes_ignore)",Are these modification duplicate? Or should we move it into base detector.
+862,"@@ -35,7 +35,7 @@ public class DirectAcyclicGraphSeed {
+             }
+           });
+
+-  public static byte[] dagSeed(final long block) {
++  private static byte[] dagSeed(final long block) {
+     final byte[] seed = new byte[32];
+     if (Long.compareUnsigned(block, EPOCH_LENGTH) >= 0) {
+       final MessageDigest keccak256 = KECCAK_256.get();",Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method.
+863,"@@ -160,11 +160,10 @@ abstract class Tx_Solr_PluginBase_PluginBase extends tslib_pibase {
+ 	 * @param array $configuration configuration array as provided by the TYPO3 core
+ 	 */
+ 	protected function initialize($configuration) {
+-		$this->conf = $configuration;
+-
+-		$this->conf = t3lib_div::array_merge_recursive_overrule(
+-			$GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'],
+-			$this->conf
++		$this->conf = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'];
++		\TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule(
++			$this->conf,
++			$configuration
+ 		);
+
+ 		$this->pi_setPiVarDefaults();",why the order change? Also for the next chunk. (I understand the result will be the same though)
+864,"@@ -42,7 +42,9 @@ type FuncDef struct {
+ 	// Not part of the grammar. Used to indicate internal targets that can only
+ 	// be called using keyword arguments.
+ 	KeywordsOnly bool
+-	IsPrivate    bool
++	// allowed return types of the FuncDef
++	Returns   []string
++	IsPrivate bool
+ }
+
+ // A ForStatement implements the 'for' statement.",I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier.
+865,"@@ -125,7 +125,7 @@ abstract class BaseDataReader<T> implements Closeable {
+
+   protected InputFile getInputFile(FileScanTask task) {
+     Preconditions.checkArgument(!task.isDataTask(), ""Invalid task type"");
+-    return inputFiles.get(task.file().path().toString());
++    return getInputFile(task.file().path().toString());
+   }
+
+   protected InputFile getInputFile(String location) {",I don't think this needs to change. Can you go back to the previous implementation?
+866,"@@ -32,7 +32,7 @@ from jinja2 import PackageLoader
+
+ import molecule.utilities as utilities
+ import molecule.validators as validators
+-from provisioners import Ansible
++from molecule.core import Molecule
+
+
+ class Commands(object):","Bump it 2 lines higher, 'c' > 'u'."
+867,"@@ -0,0 +1,11 @@
++/**
++ * Copyright @ 2018-present. All rights reserved by Vesoft Inc.
++ * Author: Fenglin Hou <dutor@vesoft-inc.com>
++ */
++#include ""parser/AstTypes.h""
++
++namespace vesoft {
++
++
++
++}",Please do not add author here
+868,"@@ -4,6 +4,7 @@ import (
+ 	""database/sql""
+ 	""encoding/hex""
+
++	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/db/rds""","Similarly, we should be able to persist action uniformly"
+869,"@@ -1,3 +1,8 @@
++#This prevents caching via the browser
++#in testing mode
++module ActionController::ConditionalGet
++    def expires_in(*args) ; end
++end
+ Workshops::Application.configure do
+   # Settings specified here will take precedence over those in config/application.rb
+ ","I think i'd prefer this override to be in the test helper instead, if that's possible?"
+870,"@@ -134,6 +134,13 @@ func Untar(source string, dest string, extractionDir string) error {
+ 		case tar.TypeReg:
+ 			fallthrough
+ 		case tar.TypeRegA:
++			// Always ensure the directory is created before trying to move the file.
++			fullPathDir := filepath.Dir(fullPath)
++			err = os.MkdirAll(fullPathDir, 0755)
++			if err != nil {
++				return err
++			}
++
+ 			// For a regular file, create and copy the file.
+ 			exFile, err := os.Create(fullPath)
+ 			if err != nil {",This would be better with context added via wrapping or fmt.errorf()
+871,"@@ -0,0 +1,19 @@
++//  Copyright 2020 Google Inc. All Rights Reserved.
++//
++//  Licensed under the Apache License, Version 2.0 (the ""License"");
++//  you may not use this file except in compliance with the License.
++//  You may obtain a copy of the License at
++//
++//      http://www.apache.org/licenses/LICENSE-2.0
++//
++//  Unless required by applicable law or agreed to in writing, software
++//  distributed under the License is distributed on an ""AS IS"" BASIS,
++//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++//  See the License for the specific language governing permissions and
++//  limitations under the License.
++
++// Package assert provides convenience functions that help a method or constructor check whether
++// it was invoked correctly (whether its preconditions have been met).
++//
++// When the assertion fails, a panic occurs, allowing bugs to be found in a fail-fast manner.
++package assert",What's the purpose of this file?
+872,"@@ -616,12 +616,14 @@ public class PasscodeManager  {
+      */
+     public void setPasscodeLength(Context ctx, int passcodeLength) {
+     	if (passcodeLength > this.passcodeLength) {
+-            if (hasStoredPasscode(ctx)) {
++            if (hasStoredPasscode(ctx) && passcodeLengthKnown) {
+                 this.passcodeChangeRequired = true;
+             }
++
++            this.passcodeLength = passcodeLength;
+     	}
+-        this.passcodeLength = passcodeLength;
+-    	this.passcodeLengthKnown = true;
++
++        this.passcodeLengthKnown = true;
+         storeMobilePolicy(ctx);
+     }
+ ",@bhariharan Why was passcode length requirement allowed to be lowered?
+873,"@@ -6,14 +6,6 @@ import (
+ 	""flag""
+ 	""io/ioutil""
+ 	""log""
+-
+-	""github.com/aws/aws-sdk-go/aws""
+-	""github.com/aws/aws-sdk-go/aws/credentials""
+-	""github.com/aws/aws-sdk-go/aws/session""
+-	""github.com/google/go-cloud/blob""
+-	""github.com/google/go-cloud/blob/gcsblob""
+-	""github.com/google/go-cloud/blob/s3blob""
+-	""github.com/google/go-cloud/gcp""
+ )
+
+ const bucketName = ""my-cool-bucket""","This file needs a license header, too. Sorry I didn't catch that earlier."
+874,"@@ -289,7 +289,7 @@ func main() {
+ 		}
+ 	}
+
+-	err = s.Initialize(cfg, phonebookAddresses)
++	err = s.Initialize(cfg, phonebookAddresses, string(genesisText[:]))
+ 	if err != nil {
+ 		fmt.Fprintln(os.Stderr, err)
+ 		log.Error(err)",probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?
+875,"@@ -86,8 +86,13 @@ public:
+                              const table& y_data,
+                              const table& result_values) {
+         auto reference = compute_reference(scale, shift, x_data, y_data);
++        const table reference_table = dal::detail::homogen_table_builder{}
++                                          .reset(reference.get_array(),
++                                                 reference.get_row_count(),
++                                                 reference.get_column_count())
++                                          .build();
+         const double tol = te::get_tolerance<Float>(3e-4, 1e-9);
+-        const double diff = la::l_inf_norm(reference, la::matrix<double>::wrap(result_values));
++        const double diff = te::abs_error(reference_table, result_values);
+         CHECK(diff < tol);
+     }
+ ",Why reference is converted to table?
+876,"@@ -347,6 +347,19 @@ func (s *DataStore) ListRegistrationEntries(ctx context.Context,
+ 	s.mu.Lock()
+ 	defer s.mu.Unlock()
+
++	// no pagination allow for this fake, for now it return only one page
++	if req.Pagination != nil {
++		if req.Pagination.Token == 0 {
++			req.Pagination.Token = 1
++		} else {
++			// for now only 1 page is returned
++			return &datastore.ListRegistrationEntriesResponse{
++				Entries:    []*common.RegistrationEntry{},
++				Pagination: req.Pagination,
++			}, nil
++		}
++	}
++
+ 	// add the registration entries to the map
+ 	entriesSet := make(map[string]*common.RegistrationEntry)
+ 	for _, entry := range s.registrationEntries {",should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?
+877,"@@ -15,6 +15,12 @@ func Compile(scope Scope, f *semantic.FunctionExpression, in semantic.MonoType)
+ 		return nil, errors.Newf(codes.Invalid, ""function input must be an object @ %v"", f.Location())
+ 	}
+
++	// If the function is vectorizable, `f.Vectorized` will be populated, and
++	// we should use the FunctionExpression it points to instead of `f`
++	if f.Vectorized != nil {
++		f = f.Vectorized
++	}
++
+ 	// Retrieve the function argument types and create an object type from them.
+ 	fnType := f.TypeOf()
+ 	argN, err := fnType.NumArguments()",What mechanism will be exposed so the caller knows they're using the vectorized version?
+878,"@@ -20,9 +20,9 @@ class TopicsController < ApplicationController
+     @topic = build_new_topic
+     respond_to do |format|
+       if verify_recaptcha(model: @topic) && @topic.save
+-        format.html { redirect_to forum_path(@forum), flash: { success: t('.success') } }
++        format.html { redirect_to forum_path(@forum), notice: t('.success') }
+       else
+-        format.html { redirect_to forum_path(@forum), flash: { error: t('.error') } }
++        format.html { render :new }
+       end
+     end
+   end",Can we remove respond_to block its not required here
+879,"@@ -23,12 +23,13 @@
+ #include ""oneapi/dal/algo/jaccard.hpp""
+ #include ""oneapi/dal/graph/service_functions.hpp""
+ #include ""oneapi/dal/graph/undirected_adjacency_vector_graph.hpp""
+-#include ""oneapi/dal/io/graph_csv_data_source.hpp""
+-#include ""oneapi/dal/io/load_graph.hpp""
++#include ""oneapi/dal/io/csv.hpp""
+ #include ""oneapi/dal/table/homogen.hpp""
+
+ namespace dal = oneapi::dal;
+
++using namespace dal;
++
+ /// Computes Jaccard similarity coefficients for the graph. The upper triangular
+ /// matrix is processed only as it is symmetic for undirected graph.
+ ///","Do not do that even in example, we demonstrate bad practice"
+880,"@@ -202,7 +202,13 @@ module Beaker
+     #Examine the host system to determine the architecture
+     #@return [Boolean] true if x86_64, false otherwise
+     def determine_if_x86_64
+-      result = exec(Beaker::Command.new(""arch | grep x86_64""), :acceptable_exit_codes => (0...127))
++      if self['is_cygwin'].nil? or self['is_cygwin'] == true
++        command = Beaker::Command.new(""arch | grep x86_64"")
++      else
++        command = Beaker::Command.new(""echo '' | wmic os get osarchitecture | FindStr 64-bit"")
++      end
++
++      result = exec(command, :acceptable_exit_codes => (0...127))
+       result.exit_code == 0
+     end
+ ","Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location."
+881,"@@ -84,11 +84,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [InlineData(null, new byte[0])]
+         public void EncodesAsAscii(string input, byte[] expected)
+         {
+-            var writerBuffer = _pipe.Writer;
+-            var writer = new BufferWriter<PipeWriter>(writerBuffer);
++            var pipeWriter = _pipe.Writer;
++            var writer = new BufferWriter<PipeWriter>(pipeWriter);
+             writer.WriteAsciiNoValidation(input);
+             writer.Commit();
+-            writerBuffer.FlushAsync().GetAwaiter().GetResult();
++            pipeWriter.FlushAsync().GetAwaiter().GetResult();
++            pipeWriter.Complete();
++
+             var reader = _pipe.Reader.ReadAsync().GetAwaiter().GetResult();
+
+             if (expected.Length > 0)",We have to `.Complete` now because of empty/null string test cases.
+882,"@@ -166,7 +166,7 @@ module Beaker
+     def scp_to source, target, options = {}, dry_run = false
+       return if dry_run
+
+-      options[:recursive]  = File.directory?(source) if options[:recursive].nil?
++      options[:recursive]  = File.directory?(source)
+       options[:chunk_size] = options[:chunk_size] || 16384
+
+       result = Result.new(@hostname, [source, target])",Is there still a way to specify no recursion?
+883,"@@ -438,6 +438,15 @@ Loop:
+ 	return w, nil
+ }
+
++// Tool is used to communicate the tool's name ot the user.
++type Tool struct {
++
++	// HumanReadableName is used for error messages, for example: ""image import"".
++	HumanReadableName string
++	// URISafeName is used programmatically, eg: ""image-import""
++	URISafeName string
++}
++
+ // EnvironmentSettings controls the resources that are used during tool execution.
+ type EnvironmentSettings struct {
+ 	// Location of workflows",How is this name being URI safe and being used programmatically related?
+884,"@@ -358,14 +358,14 @@ module.exports = class ProviderView {
+       state = this.plugin.getPluginState()
+       state.selectedFolders[folderId] = { loading: false, files: files }
+       this.plugin.setPluginState({ selectedFolders: folders })
+-      const dashboard = this.plugin.uppy.getPlugin('Dashboard')
++
+       let message
+       if (files.length) {
+-        message = dashboard.i18n('folderAdded', {
++        message = this.plugin.uppy.i18n('folderAdded', {
+           smart_count: files.length, folder: folder.name
+         })
+       } else {
+-        message = dashboard.i18n('emptyFolderAdded')
++        message = this.plugin.uppy.i18n('emptyFolderAdded')
+       }
+       this.plugin.uppy.info(message)
+     }).catch((e) => {","I think we have to keep this as a fallback for now, else it's a small breaking change :("
+885,"@@ -80,7 +80,7 @@ func TestOpImmediateNote(t *testing.T) {
+ func TestOpDocExtra(t *testing.T) {
+ 	xd := OpDocExtra(""bnz"")
+ 	require.NotEmpty(t, xd)
+-	xd = OpDocExtra(""+"")
++	xd = OpDocExtra(""-"")
+ 	require.Empty(t, xd)
+ }
+ ",nit: shouldn't be part of this PR.
+886,"@@ -83,7 +83,7 @@ describe('Cursor Async Iterator Tests', function() {
+           expect(doc).to.exist;
+           cursor.close();
+         }
+-        throw new Error('expected closing the cursor to break iteration');
++        throw new MongoError('expected closing the cursor to break iteration');
+       } catch (e) {
+         expect(e).to.be.an.instanceOf(MongoError);
+       }","this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it."
+887,"@@ -164,6 +164,13 @@ namespace NLog.Internal
+
+             if (reusableBuilder != null)
+             {
++                if (!_layout.IsThreadAgnostic)
++                {
++                    string cachedResult;
++                    if (logEvent.TryGetCachedLayoutValue(_layout, out cachedResult))
++                        return cachedResult;
++                }
++
+                 _layout.RenderAppendBuilder(logEvent, reusableBuilder);
+
+                 if (_cachedPrevRawFileName != null && _cachedPrevRawFileName.Length == reusableBuilder.Length)","I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread."
+888,"@@ -7,14 +7,19 @@ import javafx.scene.control.ToggleGroup;
+ import javafx.scene.layout.HBox;
+ import org.phoenicis.javafx.views.common.widgets.lists.CombinedListWidget;
+ import org.phoenicis.javafx.views.common.widgets.lists.ListWidgetType;
++import org.slf4j.LoggerFactory;
+
+ import java.util.Arrays;
+ import java.util.List;
++import java.util.Optional;
++import java.util.function.Consumer;
+
+ /**
+  * Created by marc on 15.05.17.
+  */
+ public class LeftListWidgetChooser<E> extends HBox {
++    private final org.slf4j.Logger LOGGER = LoggerFactory.getLogger(LeftListWidgetChooser.class);
++
+     private List<CombinedListWidget<E>> listWidgets;
+
+     private ToggleGroup toggleGroup;",Please use only `Logger` instead of `org.slf4j.Logger`
+889,"@@ -326,6 +326,10 @@ void nano::block_processor::process_live (nano::transaction const & transaction_
+ 	{
+ 		node.network.flood_block_initial (block_a);
+ 	}
++	else if (!node.flags.disable_block_processor_republishing)
++	{
++		node.network.flood_block (block_a, nano::buffer_drop_policy::no_limiter_drop);
++	}
+
+ 	if (node.websocket_server && node.websocket_server->any_subscriber (nano::websocket::topic::new_unconfirmed_block))
+ 	{","Should this be ""no limiter drop"", since this isn't an absolutely essential activity for the stability of the network?"
+890,"@@ -22,8 +22,8 @@ var iam = new AWS.IAM({apiVersion: '2010-05-08'});
+
+ iam.deleteAccountAlias({AccountAlias: process.argv[2]}, function(err, data) {
+   if (err) {
+-    console.log(""Error"", err);
++    throw err;
+   } else {
+-    console.log(""Success"", data);
++    console.log('Account alias ' + process.argv[2] + ' deleted.');
+   }
+ });","I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully."
+891,"@@ -45,6 +45,8 @@ def _test_pyx():
+                                       stdout=devnull, stderr=subprocess.STDOUT)
+     except (subprocess.CalledProcessError, OSError):
+         return False
++    except FileNotFoundError as fnfe:
++        return False
+     else:
+         return r == 0
+ ",Could you simply add it to the previous clause ?
+892,"@@ -108,13 +108,10 @@ Blockly.Procedures.sortProcedureMutations_ = function(mutations) {
+     var procCodeA = a.getAttribute('proccode');
+     var procCodeB = b.getAttribute('proccode');
+
+-    if (procCodeA < procCodeB) {
+-      return -1;
+-    } else if (procCodeA > procCodeB) {
+-      return 1;
+-    } else {
+-      return 0;
+-    }
++    return procCodeA.localeCompare(procCodeB, undefined, {
++      sensitivity: 'base',
++      numeric: true
++    });
+   });
+
+   return newMutations;","@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options."
+893,"@@ -239,6 +239,10 @@ public class ExecuteFlowAction implements TriggerAction {
+     }
+     exflow.setExecutionOptions(executionOptions);
+
++    if (slaOptions != null && slaOptions.size() > 0) {
++      exflow.setSlaOptions(slaOptions);
++    }
++
+     try {
+       logger.info(""Invoking flow "" + project.getName() + ""."" + flowName);
+       executorManager.submitExecutableFlow(exflow, submitUser);",@chengren311 : where does this logic move to?
+894,"@@ -204,6 +204,14 @@ func (s *NodegroupService) reconcileNodegroupIAMRole() error {
+ 	}
+
+ 	policies := NodegroupRolePolicies()
++	if len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0 {
++		if !s.scope.AllowAdditionalRoles() {
++			return ErrCannotUseAdditionalRoles
++		}
++
++		policies = append(policies, s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies...)
++	}
++
+ 	_, err = s.EnsurePoliciesAttached(role, aws.StringSlice(policies))
+ 	if err != nil {
+ 		return errors.Wrapf(err, ""error ensuring policies are attached: %v"", policies)",Can we have a `nil` exception check at `s.scope.ManagedMachinePool`
+895,"@@ -40,16 +40,6 @@ class Options extends \VuFind\Search\Base\Options
+ {
+     use \VuFind\Search\Options\ViewOptionsTrait;
+
+-    /**
+-     * Available sort options for facets
+-     *
+-     * @var array
+-     */
+-    protected $facetSortOptions = [
+-        'count' => 'sort_count',
+-        'index' => 'sort_alphabetic'
+-    ];
+-
+     /**
+      * Hierarchical facets
+      *","Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?"
+896,"@@ -31,11 +31,14 @@ class ManagerConfiguration {
+       '#collapsible' => FALSE,
+     ];
+     foreach ($this->datastoreManager->getConfigurableProperties() as $property => $default_value) {
++      $propety_label = str_replace(""_"", "" "", $property);
++      $propety_label = ucfirst($propety_label);
++
+       if ($property == ""delimiter"") {
+         $form['import_options'][""datastore_manager_config_{$property}""] = array(
+           '#type' => 'select',
+           // @codingStandardsIgnoreStart
+-          '#title' => ucfirst(t(""{$property}"")),
++          '#title' => t($propety_label),
+           // @codingStandardsIgnoreEnd
+           '#options' => array(
+             "","" => "","",","wrap, single line"
+897,"@@ -202,6 +202,12 @@ public class JavaContextCommon {
+
+     public abstract String getReturnType();
+
++    public String getGenericAwareReturnType() {
++      String returnType = getReturnType();
++      if (returnType == null || returnType.isEmpty()) return ""Void"";
++      else return returnType;
++    }
++
+     public abstract ImmutableList<Variable> getParams();
+
+     public abstract ImmutableList<Variable> getRequiredParams();",always use brackets for if statements
+898,"@@ -34,14 +34,13 @@ namespace Datadog.Trace.ClrProfiler.Integrations.Testing
+         private const string NUnitTestExecutionContextType = ""NUnit.Framework.Internal.TestExecutionContext"";
+
+         private static readonly Vendors.Serilog.ILogger Log = DatadogLogging.GetLogger(typeof(NUnitIntegration));
+-        private static readonly FrameworkDescription _runtimeDescription;
++        private static readonly FrameworkDescription RuntimeDescription;
+
+         static NUnitIntegration()
+         {
+             // Preload environment variables.
+             CIEnvironmentValues.DecorateSpan(null);
+-
+-            _runtimeDescription = FrameworkDescription.Create();
++            RuntimeDescription = FrameworkDescription.Instance;
+         }
+
+         /// <summary>",`NUnitIntegration` doesn't need to cache this anymore.
+899,"@@ -210,8 +210,9 @@ EXTS_ACCESS_COUNTS = textwrap.dedent(""""""\
+             eventname,
+             bucket,
+             lower(CASE
+-                WHEN cardinality(parts) > 2 THEN concat(element_at(parts, -2), '.', element_at(parts, -1))
+-                WHEN cardinality(parts) = 2 THEN element_at(parts, -1)
++                WHEN cardinality(parts) > 2 AND lower(element_at(parts, -1)) = 'gz'
++                    THEN concat(element_at(parts, -2), '.', element_at(parts, -1))
++                WHEN cardinality(parts) >= 2 THEN element_at(parts, -1)
+                 ELSE ''
+                 END
+             ) AS ext,",Why did you change it to `>=` here?
+900,"@@ -30,8 +30,11 @@ abstract class BaseAction<R> implements Action<R> {
+     String tableName = table().toString();
+     if (tableName.contains(""/"")) {
+       return tableName + ""#"" + type;
+-    } else if (tableName.startsWith(""hadoop."") || tableName.startsWith(""hive."")) {
+-      // HiveCatalog and HadoopCatalog prepend a logical name which we need to drop for Spark 2.4
++    } else if (tableName.startsWith(""hadoop."")) {
++      // Load a path by HadoopCatalog or HadoopTables
++      return table().location() + ""#"" + type;
++    } else if (tableName.startsWith(""hive."")) {
++      // HiveCatalog prepend a logical name which we need to drop for Spark 2.4
+       return tableName.replaceFirst(""(hadoop\\.)|(hive\\.)"", """") + ""."" + type;
+     } else {
+       return tableName + ""."" + type;",Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path.
+901,"@@ -1,4 +1,5 @@
+ require 'fileutils'
++require 'digest'
+
+ module RSpec
+   module Core","This require isn't need anymore, right?"
+902,"@@ -32,6 +32,7 @@ import (
+ 	""github.com/mysteriumnetwork/node/session""
+ 	""github.com/mysteriumnetwork/node/session/balance""
+ 	""github.com/mysteriumnetwork/node/session/promise""
++	""github.com/mysteriumnetwork/payments/crypto""
+ 	""github.com/pkg/errors""
+ )
+ ",a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments..
+903,"@@ -889,7 +889,7 @@ trait MarcAdvancedTrait
+                 'http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd',
+                 'http://www.w3.org/2001/XMLSchema-instance'
+             );
+-            $xml->record->addAttribute('type', 'Bibliographic');
++            $xml->record->addAttribute('type', $this->xmlType);
+             return $xml->record->asXML();
+         }
+ ","I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all."
+904,"@@ -2,6 +2,10 @@ package protocol
+
+ import ""time""
+
++// NonForwardSecurePacketSizeReduction is the number of bytes a non forward-secure packet has to be smaller than a forward-secure packet
++// This makes sure that those packets can always be retransmitted without splitting the contained StreamFrames
++const NonForwardSecurePacketSizeReduction = 50
++
+ // DefaultMaxCongestionWindow is the default for the max congestion window
+ const DefaultMaxCongestionWindow = 1000
+ ","I would prefer to not have a magic number, but construct this value out of other constants we already have."
+905,"@@ -101,6 +101,15 @@ def setup_authentication(config):
+     from configuration.
+     """"""
+     config.include('pyramid_multiauth')
++    settings = config.get_settings()
++
++    policies = aslist(settings['multiauth.policies'])
++    if 'basicauth' in policies:
++        config.add_api_capability(
++            ""basicauth"",
++            description=""Very basic authentication sessions. Not for production use."",
++            url=""http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html"",
++        )
+
+     # Track policy used, for prefixing user_id and for logging.
+     def on_policy_selected(event):","The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess."
+906,"@@ -31,8 +31,8 @@ import (
+ 	_ ""gocloud.dev/secrets/awskms""
+ 	_ ""gocloud.dev/secrets/azurekeyvault""
+ 	_ ""gocloud.dev/secrets/gcpkms""
+-	_ ""gocloud.dev/secrets/hashivault""
+ 	_ ""gocloud.dev/secrets/localsecrets""
++	_ ""gocloud.dev/secrets/vault""
+ )
+
+ const helpSuffix = `",? The package is named `hashivault`.
+907,"@@ -240,6 +240,9 @@ static int config_ini_handler(void *user, const char *section, const char *name,
+ 		if (strcmp(name, ""xwayland"") == 0) {
+ 			if (strcasecmp(value, ""true"") == 0) {
+ 				config->xwayland = true;
++			} else if (strcasecmp(value, ""lazy"") == 0) {
++				config->xwayland = true;
++				config->xwayland_lazy = true;
+ 			} else if (strcasecmp(value, ""false"") == 0) {
+ 				config->xwayland = false;
+ 			} else {","I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`"
+908,"@@ -28,7 +28,6 @@ import (
+ 	fakeclientset ""k8s.io/client-go/kubernetes/fake""
+ 	certutil ""k8s.io/client-go/util/cert""
+ 	""k8s.io/client-go/util/keyutil""
+-
+ 	fakeaggregatorclientset ""k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/fake""
+ )
+ ",Remove this line by accident?
+909,"@@ -16,12 +16,13 @@
+
+ package com.palantir.baseline.plugins;
+
++import java.util.Collections;
+ import java.util.Objects;
+ import org.gradle.api.Plugin;
+ import org.gradle.api.Project;
+ import org.gradle.api.artifacts.Dependency;
+-import org.gradle.api.plugins.JavaPluginConvention;
+ import org.gradle.api.tasks.SourceSet;
++import org.gradle.api.tasks.SourceSetContainer;
+ import org.gradle.api.tasks.compile.JavaCompile;
+
+ public final class BaselineImmutables implements Plugin<Project> {","Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?"
+910,"@@ -201,7 +201,10 @@ func CreateGitIgnore(targetDir string, ignores ...string) error {
+
+ 	if fileutil.FileExists(gitIgnoreFilePath) {
+ 		sigFound, err := fileutil.FgrepStringInFile(gitIgnoreFilePath, DdevFileSignature)
+-		util.CheckErr(err)
++		if err != nil {
++			return err
++		}
++
+ 		// If we sigFound the file and did not find the signature in .ddev/.gitignore, warn about it.
+ 		if !sigFound {
+ 			util.Warning(""User-managed %s will not be managed/overwritten by ddev"", gitIgnoreFilePath)","Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where ""can't happen"" but Things Can Happen."
+911,"@@ -275,6 +275,15 @@ func (b *ofFlowBuilder) MatchARPOp(op uint16) FlowBuilder {
+ 	return b
+ }
+
++// MatchIPDscp adds match condition for matching DSCP field in the IP header. Note, OVS use TOS to present DSCP, and
++// the field name is shown as ""nw_tos"" with OVS command line, and the value is calculated by shifting the given value
++// left 2 bits.
++func (b *ofFlowBuilder) MatchIPDscp(dscp uint8) FlowBuilder {
++	b.matchers = append(b.matchers, fmt.Sprintf(""nw_tos=%d"", dscp<<2))
++	b.Match.IpDscp = dscp
++	return b
++}
++
+ // MatchConjID adds match condition for matching conj_id.
+ func (b *ofFlowBuilder) MatchConjID(value uint32) FlowBuilder {
+ 	b.matchers = append(b.matchers, fmt.Sprintf(""conj_id=%d"", value))",What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?
+912,"@@ -329,12 +329,17 @@ extern ""C"" bool isValidMolBlob(char *data, int len) {
+   return res;
+ }
+
+-extern ""C"" char *makeMolText(CROMol data, int *len, bool asSmarts) {
++extern ""C"" char *makeMolText(CROMol data, int *len, bool asSmarts,
++                             bool cxSmiles) {
+   ROMol *mol = (ROMol *)data;
+
+   try {
+     if (!asSmarts) {
+-      StringData = MolToSmiles(*mol, true);
++      if (!cxSmiles) {
++        StringData = MolToSmiles(*mol);
++      } else {
++        StringData = MolToCXSmiles(*mol);
++      }
+     } else {
+       StringData = MolToSmarts(*mol, false);
+     }",I'm assuming that asSmarts & cxSmiles == asSmarts
+913,"@@ -780,7 +780,9 @@ class LabelledData(param.Parameterized):
+         except:
+             self.warning(""Could not unpickle custom style information."")
+         self.__dict__.update(d)
+-
++        # TODO: super's setstate not called?
++        if ""param"" not in self.__dict__:
++            self.param = type(self.param)(self.__class__, self=self)
+
+
+ class Dimensioned(LabelledData):",Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken.
+914,"@@ -30,8 +30,8 @@ namespace Examples.Console
+     internal class InstrumentationWithActivitySource : IDisposable
+     {
+         private const string RequestPath = ""/api/request"";
+-        private SampleServer server = new SampleServer();
+-        private SampleClient client = new SampleClient();
++        private readonly SampleServer server = new SampleServer();
++        private readonly SampleClient client = new SampleClient();
+
+         public void Start(ushort port = 19999)
+         {","Curious, do we consider this as pedantic for example code?"
+915,"@@ -609,7 +609,7 @@ class AdminController extends Controller
+
+         $formType = $this->useLegacyFormComponent() ? 'easyadmin' : 'JavierEguiluz\\Bundle\\EasyAdminBundle\\Form\\Type\\EasyAdminFormType';
+
+-        return $this->get('form.factory')->createNamedBuilder('form', $formType, $entity, $formOptions);
++        return $this->get('form.factory')->createNamedBuilder(strtolower($this->entity['name']), $formType, $entity, $formOptions);
+     }
+
+     /**","Should we convert the entity name to snake case using `Doctrine\Common\Inflector\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?"
+916,"@@ -12,9 +12,15 @@ func NewClientFake(IP string) Client {
+
+ type clientFake struct {
+ 	ip string
++	outboundIp string
+ }
+
+-func (client *clientFake) GetIp() (string, error) {
++func (client *clientFake) GetPublicIP() (string, error) {
++	log.Info(IPIFY_API_LOG_PREFIX, ""IP faked: "", client.ip)
++	return client.ip, nil
++}
++
++func (client *clientFake) GetOutboundIP() (string, error) {
+ 	log.Info(IPIFY_API_LOG_PREFIX, ""IP faked: "", client.ip)
+ 	return client.ip, nil
+ }",Should be `client.outboundIp`
+917,"@@ -31,6 +31,9 @@
+ // THE POSSIBILITY OF SUCH DAMAGE.
+ //
+
++using System.IO;
++using System.Threading.Tasks;
++
+ namespace NLog.UnitTests.LayoutRenderers
+ {
+     using System;",Must these `using` statements not go inside the `namespace` block?
+918,"@@ -92,8 +92,8 @@ type fboMutexLevel mutexLevel
+
+ const (
+ 	fboMDWriter fboMutexLevel = 1
+-	fboHead                   = 2
+-	fboBlock                  = 3
++	fboHead     fboMutexLevel = 2
++	fboBlock    fboMutexLevel = 3
+ )
+
+ func (o fboMutexLevel) String() string {",Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.)
+919,"@@ -12,11 +12,7 @@ define([], function() {
+     }
+
+     function uploadContent(connectionManager, server, options) {
+-        return new Promise(function(resolve, reject) {
+-            require([""contentuploader""], function(ContentUploader) {
+-                (new ContentUploader).uploadImages(connectionManager, server).then(resolve, reject)
+-            })
+-        })
++        return new Promise().resolve();
+     }
+
+     function syncMedia(connectionManager, server, options) {",shouldn't we `reject` here instead?
+920,"@@ -167,10 +167,12 @@ func printActionProto(action *iotextypes.Action) (string, error) {
+ 	if err != nil {
+ 		return """", output.NewError(output.ConvertError, ""failed to convert bytes into address"", err)
+ 	}
++	//ioctl action should display IOTX unit instead Raul
++	gasPriceUnitIOTX, err := util.StringToIOTX(action.Core.GasPrice)
+ 	result := fmt.Sprintf(""\nversion: %d  "", action.Core.GetVersion()) +
+ 		fmt.Sprintf(""nonce: %d  "", action.Core.GetNonce()) +
+ 		fmt.Sprintf(""gasLimit: %d  "", action.Core.GasLimit) +
+-		fmt.Sprintf(""gasPrice: %s Rau\n"", action.Core.GasPrice) +
++		fmt.Sprintf(""gasPrice: %s IOTX\n"", gasPriceUnitIOTX) +
+ 		fmt.Sprintf(""senderAddress: %s %s\n"", senderAddress.String(),
+ 			Match(senderAddress.String(), ""address""))
+ 	switch {","check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct"
+921,"@@ -34,7 +34,7 @@ func newHarness(t *testing.T) (drivertest.Harness, error) {
+ 	return &harness{vars: map[string][]byte{}}, nil
+ }
+
+-func (h *harness) MakeWatcher(ctx context.Context, name string, decoder *runtimevar.Decoder, wait time.Duration) (driver.Watcher, error) {
++func (h *harness) MakeWatcher(ctx context.Context, name string, decoder *runtimevar.Decoder) (driver.Watcher, error) {
+ 	rawVal, found := h.vars[name]
+ 	if !found {
+ 		// The variable isn't set. Create a Variable that always returns an error.","Just curious, was wait not used at all before?"
+922,"@@ -7,9 +7,10 @@ package manifest
+ import (
+ 	""errors""
+ 	""fmt""
++	""github.com/google/shlex""
+ 	""path/filepath""
+ 	""strconv""
+-	""strings""
++	//""strings""
+
+ 	""github.com/aws/aws-sdk-go/aws""
+ 	""gopkg.in/yaml.v3""",nit: can we remove this?
+923,"@@ -44,11 +44,11 @@ public class NotificationStore {
+         }
+     }
+
+-    public Notification get(int index) {
++    public synchronized Notification get(int index) {
+         return store.get(index);
+     }
+
+-    public void add(Notification n) {
++    public synchronized void add(Notification n) {
+         log.info(""Notification received: "" + n.text);
+         for (int i = 0; i < store.size(); i++) {
+             if (get(i).id == n.id) {",is it not a problem when one synchronized function is called by other?
+924,"@@ -1,6 +1,7 @@
+ ActiveAdmin.register Account do
+-  permit_params :level
+-  actions :index, :show, :edit
++  permit_params :login, :email, :level, :country_code, :location, :url, :hide_experience, :email_master, :email_posts,
++                :email_kudos, :email_new_followers, :twitter_account, :affiliation_type, :organization_name
++  actions :index, :show, :edit, :update
+
+   controller do
+     defaults finder: :fetch_by_login_or_email","We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!"
+925,"@@ -20,7 +20,7 @@ return [
+     'alpha_dash'           => 'O campo :attribute deve conter apenas letras, números e traços.',
+     'alpha_num'            => 'O campo :attribute deve conter apenas letras e números .',
+     'array'                => 'O campo :attribute deve conter um array.',
+-    'attached'             => 'This :attribute is already attached.',
++    'attached'             => 'Este :attribute já está ligado.',
+     'before'               => 'O campo :attribute deve conter uma data anterior a :date.',
+     'before_or_equal'      => 'O campo :attribute deve conter uma data inferior ou igual a :date.',
+     'between'              => [","""Este :attribute j est anexado."" sounds better."
+926,"@@ -0,0 +1,6 @@
++
++if __name__ == ""__main__"":
++    import doctest
++    import databricks.koalas as ks
++    from databricks.koalas import frame, series
++    doctest.testmod(frame, extraglobs={""ks"": ks})","This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files."
+927,"@@ -301,5 +301,3 @@ var failedIssuanceMu sync.RWMutex
+ // If this value is recent, do not make any on-demand certificate requests.
+ var lastIssueTime time.Time
+ var lastIssueTimeMu sync.Mutex
+-
+-var errNoCert = errors.New(""no certificate available"")",This error was unused
+928,"@@ -212,6 +212,11 @@ type (
+ 		PreviousRangeID int64
+ 	}
+
++	// CloseShardRequest is used to notify persistence that we're unloading a shard
++	CloseShardRequest struct {
++		ShardID int32
++	}
++
+ 	// AddTasksRequest is used to write new tasks
+ 	AddTasksRequest struct {
+ 		ShardID int32","Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching."
+929,"@@ -0,0 +1,5 @@
++<% if trail.complete? %>
++  <%= render ""completed_trails/trail"", trail: trail %>
++<% else %>
++  <%= render ""trails/incomplete_trail"", trail: trail %>
++<% end %>",Does this make more sense as `trails/_trail` now?
+930,"@@ -435,6 +435,17 @@ func (agent *ecsAgent) getEC2InstanceID() string {
+ 	return instanceID
+ }
+
++// getoutpostARN gets the Outpost ARN from the metadata service
++func (agent *ecsAgent) getoutpostARN() string {
++	outpostARN, err := agent.ec2MetadataClient.OutpostARN()
++	if err != nil {
++		seelog.Warnf(
++			""Unable to obtain Outpost ARN from EC2 Metadata: %v"", err)
++		return """"
++	}
++	return outpostARN
++}
++
+ // newStateManager creates a new state manager object for the task engine.
+ // Rest of the parameters are pointers and it's expected that all of these
+ // will be backfilled when state manager's Load() method is invoked","synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows."
+931,"@@ -12,6 +12,10 @@ class PythonMappings
+     fun.add_mapping(""py_env"", Python::VirtualEnv.new)
+
+     fun.add_mapping(""py_docs"", Python::GenerateDocs.new)
++
++	fun.add_mapping(""py_install"", Python::Install.new)
++
++	fun.add_mapping(""py_prep"", Python::Prep.new)
+   end
+ end
+ ","Too much indentation here. Should match the lines above, which have four spaces."
+932,"@@ -15,14 +15,6 @@ BOOST_AUTO_TEST_CASE(test_incompatible_with_mld)
+         osrm::exception);
+ }
+
+-BOOST_AUTO_TEST_CASE(test_incompatible_with_corech)
+-{
+-    // Note - CH-only data can't be used with the CoreCH algorithm
+-    BOOST_CHECK_THROW(
+-        getOSRM(OSRM_TEST_DATA_DIR ""/ch/monaco.osrm"", osrm::EngineConfig::Algorithm::CoreCH),
+-        osrm::exception);
+-}
+-
+ BOOST_AUTO_TEST_CASE(test_incompatible_with_ch)
+ {
+     // Can't use the CH algorithm with MLD data",Same here we still need this test to make sure the fallback works.
+933,"@@ -0,0 +1,8 @@
++using System;
++namespace MvvmCross.iOS.Views.Presenters.Attributes
++{
++    public interface IMvxOverridePresentationAttribute
++    {
++        MvxBasePresentationAttribute OverridePresentationAttribute();
++    }
++}",I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one.
+934,"@@ -430,7 +430,7 @@ export function unmount(vnode, parentVNode, skipRemove) {
+ 			}
+ 		}
+
+-		r.base = r._parentDom = null;
++		r.base = r._parentDom = r._vnode = vnode._component = null;
+ 	}
+
+ 	if ((r = vnode._children)) {",could we switch to `undefined` here?
+935,"@@ -94,6 +94,7 @@ public class SyncManager {
+         this.smartStore = smartStore;
+         this.restClient = restClient;
+         SyncState.setupSyncsSoupIfNeeded(smartStore);
++        SyncState.cleanupSyncsSoupIfNeeded(smartStore);
+     }
+
+     /**",The cleanup call
+936,"@@ -288,10 +288,11 @@ define(['apphost', 'globalize', 'connectionManager', 'itemHelper', 'appRouter',
+                 icon: 'album'
+             });
+         }
+-
+-        if (options.openArtist !== false && item.ArtistItems && item.ArtistItems.length) {
++        // Show Album Artist by default, as a song can have multiple artists, which specific one would this option refer to?
++        // Although some albums can have multiple artists, it's not as common as songs.
++        if (options.openArtist !== false && item.AlbumArtists && item.AlbumArtists.length) {
+             commands.push({
+-                name: globalize.translate('ViewArtist'),
++                name: globalize.translate('ViewAlbumArtist'),
+                 id: 'artist',
+                 icon: 'person'
+             });","I think ""View artist"" is a bit more standard and expected. Or even ""Go to artist"" to take the Spotify terminology as-is."
+937,"@@ -196,6 +196,9 @@ module Bolt
+       # This works on deeply nested data structures composed of Hashes, Arrays, and
+       # and plain-old data types (int, string, etc).
+       def unwrap_sensitive_args(arguments)
++        # Skip this if Puppet isn't loaded
++        return arguments unless defined?(Puppet::Pops::Types::PSensitiveType::Sensitive)
++
+         case arguments
+         when Array
+           # iterate over the array, unwrapping all elements",It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values.
+938,"@@ -30,3 +30,7 @@ from extensive_tm_test_base import ExtensiveTemporalMemoryTest
+ class ExtensiveTemporalMemoryTestCPP(ExtensiveTemporalMemoryTest, unittest.TestCase):
+   def getTMClass(self):
+     return nupic.bindings.algorithms.TemporalMemory
++
++
++if __name__ == ""__main__"":
++  unittest.main()",We were trying to move away from this to force people to always run tests under py.test.
+939,"@@ -933,6 +933,8 @@ from selenium.webdriver.common.keys import Keys
+
+         browser = self._check_platform()
+
++        body.append(self._get_selenium_options())
++
+         if browser == 'firefox':
+             body.extend(self._get_firefox_options() + self._get_firefox_profile() + [self._get_firefox_webdriver()])
+ ",1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions
+940,"@@ -681,7 +681,9 @@ class ProxyListenerS3(ProxyListener):
+
+                 # fix content-type: https://github.com/localstack/localstack/issues/618
+                 #                   https://github.com/localstack/localstack/issues/549
+-                if 'text/html' in response.headers.get('Content-Type', ''):
++                #                   https://github.com/localstack/localstack/issues/854
++                if 'text/html' in response.headers.get('Content-Type', '') \
++                        and not response_content_str.startswith('<!doctype html'):
+                     response.headers['Content-Type'] = 'application/xml; charset=utf-8'
+
+                 reset_content_length = True",should be a case insensitive match though no? DOCTYPE and doctype are both widely used
+941,"@@ -0,0 +1,15 @@
++class AccountWidgetsController < WidgetsController
++  before_action :set_account
++  before_action :render_gif_image
++  before_action :account_context, only: :index
++
++  def index
++    @widgets = AccountWidget.create_widgets(params[:account_id])
++  end
++
++  private
++
++  def set_account
++    @account = Account.from_param(params[:account_id]).first!
++  end
++end",We must have a `fail ParamNotFound` here for cases where `@account.nil?`.
+942,"@@ -144,6 +144,7 @@ namespace Datadog.Trace.Vendors.Newtonsoft.Json.Serialization
+             return property;
+         }
+
++#if !NETCOREAPP
+         private bool TryGetValue(string key, out JsonProperty item)
+         {
+             if (Dictionary == null)",How come this change was needed?
+943,"@@ -25,3 +25,13 @@ const (
+ 	UART_TX_PIN = 6
+ 	UART_RX_PIN = 8
+ )
++
++// ADC pins
++const (
++	ADC0 = 3
++	ADC1 = 4
++	ADC2 = 28
++	ADC3 = 29
++	ADC4 = 30
++	ADC5 = 31
++)","Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?"
+944,"@@ -224,7 +224,9 @@ func (gsf *GraphSyncFetcher) fetchRemainingTipsets(ctx context.Context, starting
+ // non-recursively
+ func (gsf *GraphSyncFetcher) fetchBlocks(ctx context.Context, cids []cid.Cid, targetPeer peer.ID) error {
+ 	selector := gsf.ssb.ExploreFields(func(efsb selectorbuilder.ExploreFieldsSpecBuilder) {
+-		efsb.Insert(""messages"", gsf.ssb.Matcher())
++		efsb.Insert(""messages"", gsf.ssb.ExploreFields(func(messagesSelector selectorbuilder.ExploreFieldsSpecBuilder) {
++			messagesSelector.Insert(""secpRoot"", gsf.ssb.Matcher())
++		}))
+ 		efsb.Insert(""messageReceipts"", gsf.ssb.Matcher())
+ 	}).Node()
+ 	var wg sync.WaitGroup","I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!"
+945,"@@ -1,7 +1,7 @@
+ C2::Application.configure do
+   config.action_mailer.preview_path = ""#{Rails.root}/lib/mail_previews""
+   config.action_mailer.register_preview_interceptor :css_inline_styler
+-  config.action_mailer.asset_host = ""http://localhost:5000""
++  config.action_mailer.asset_host = ""http://2c429f18.ngrok.io"" || ""http://localhost:5000""
+   config.action_controller.perform_caching = false
+   config.action_mailer.delivery_method = :letter_opener_web
+   config.active_record.migration_error = :page_load",what is this default about? I am not using ngrok atm so would prefer an env var.
+946,"@@ -93,6 +93,19 @@ return [
+
+     'backendSkin' => 'Backend\Skins\Standard',
+
++    /*
++    |--------------------------------------------------------------------------
++    | Determines if logging in backend should run UpdateManager
++    |--------------------------------------------------------------------------
++    |
++    | If value is true it runs UpdateMananger after login in backend.
++    | It's recommended to set this value to 'false' in production enviroments
++    | because it cleares cache on every login in backend.
++    |
++    */
++
++    'runUpdateManagerAfterBackendLogin' => true,
++
+     /*
+     |--------------------------------------------------------------------------
+     | Determines which modules to load","@Samuell1 Might be better to say ""Automatically check for plugin updates on login""."
+947,"@@ -1,4 +1,6 @@
++using System;
+ using System.Diagnostics;
++using System.Runtime.CompilerServices;
+
+ namespace Datadog.Trace.Util
+ {",Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed
+948,"@@ -73,6 +73,19 @@ func (*mockStatsEngine) GetTaskHealthMetrics() (*ecstcs.HealthMetadata, []*ecstc
+ 	return nil, nil, nil
+ }
+
++// TestDisableMetrics tests the StartMetricsSession will return immediately if
++// the metrics was disabled
++func TestDisableMetrics(t *testing.T) {
++	params := TelemetrySessionParams{
++		Cfg: &config.Config{
++			DisableMetrics:           true,
++			DisableDockerHealthCheck: true,
++		},
++	}
++
++	StartMetricsSession(params)
++}
++
+ func TestFormatURL(t *testing.T) {
+ 	endpoint := ""http://127.0.0.0.1/""
+ 	wsurl := formatURL(endpoint, testClusterArn, testInstanceArn)","just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?"
+949,"@@ -198,8 +198,9 @@ func TestInferModulePath(t *testing.T) {
+ 					t.Error(err)
+ 				}
+ 			}()
+-
+-			pctx := newTestProcessContext(dir)
++			srcDir := filepath.Join(dir, ""src"")
++			os.Mkdir(srcDir, 0777)
++			pctx := newTestProcessContext(srcDir)
+ 			gopath, cleanup := tc.testGOPATH(dir)
+ 			defer cleanup()
+ 			pctx.env = []string{gopath}",We should fail the test if this returns `err != nil`.
+950,"@@ -140,6 +140,9 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c
+ 	}
+
+ 	updated = false
++	// Fun extra variable to keep track of whether we should increment metricProvisionFailedTerminal
++	// later; because we only want to do that if (we change that status and) the status update succeeds.
++	provisionFailedTerminal := false
+ 	conditions, updated = controllerutils.SetClusterDeploymentConditionWithChangeCheck(conditions,
+ 		hivev1.ProvisionStoppedCondition,
+ 		stopped.Status,",What is the drawback of not having this flag as a gating condition to report the metric?
+951,"@@ -22,9 +22,14 @@ import (
+ )
+
+ func gracefullyStopProcess(pid int) error {
++	fmt.Printf(""Graceful stop..."")
+ 	err := syscall.Kill(pid, syscall.SIGINT)
+ 	if err != nil {
+ 		return fmt.Errorf(""kill: %v"", err)
+ 	}
+ 	return nil
+ }
++
++func getAppName() string {
++	return filepath.Base(os.Args[0])
++}","`getProcessName()` will be less ambiguous, since Caddy has ""apps"" that it runs internally."
+952,"@@ -4741,6 +4741,7 @@ const char * const DMLFormats[] =
+     ""<exec cmd=\""!DumpIL /i %s\"">%s</exec>"",         // DML_IL
+     ""<exec cmd=\""!DumpRCW -cw /d %s\"">%s</exec>"",    // DML_ComWrapperRCW
+     ""<exec cmd=\""!DumpCCW -cw /d %s\"">%s</exec>"",    // DML_ComWrapperCCW
++    ""<exec cmd=\""dps %s L2\"">%s</exec>"",             // DML_TaggedMemory (hardcoded current size to 2 pointer sizes)
+ };
+
+ void ConvertToLower(__out_ecount(len) char *buffer, size_t len)","Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a ""scratch memory"" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?"
+953,"@@ -64,6 +64,13 @@ nebula::cpp2::ErrorCode ScanEdgeProcessor::checkAndBuildContexts(const cpp2::Sca
+   std::vector<cpp2::EdgeProp> returnProps = {*req.return_columns_ref()};
+   ret = handleEdgeProps(returnProps);
+   buildEdgeColName(returnProps);
++  ret = buildFilter(req, [](const cpp2::ScanEdgeRequest& r) -> const std::string* {
++    if (r.filter_ref().has_value()) {
++      return r.get_filter();
++    } else {
++      return nullptr;
++    }
++  });
+   return ret;
+ }
+ ",How about just override the `buildFilter`? Passing another function here is a little weird.
+954,"@@ -71,8 +71,9 @@ var (
+
+ 	ignoredPackages = app.Flag(""ignored-packages"", ""Space separated list of specs ignoring rebuilds if their dependencies have been updated. Will still build if all of the spec's RPMs have not been built."").String()
+
+-	pkgsToBuild   = app.Flag(""packages"", ""Space separated list of top-level packages that should be built. Omit this argument to build all packages."").String()
+-	pkgsToRebuild = app.Flag(""rebuild-packages"", ""Space separated list of base package names packages that should be rebuilt."").String()
++	pkgsToBuild     = app.Flag(""packages"", ""Space separated list of top-level packages that should be built. Omit this argument to build all packages."").String()
++	pkgsToRebuild   = app.Flag(""rebuild-packages"", ""Space separated list of base package names packages that should be rebuilt."").String()
++	rpmHydratedTest = app.Flag(""rpm-hydrated-test"", ""Is this just a TestRPM build with all RPMs hydrated?"").String()
+
+ 	logFile  = exe.LogFileFlag(app)
+ 	logLevel = exe.LogLevelFlag(app)","This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in."
+955,"@@ -2042,6 +2042,7 @@ bool SwiftLanguageRuntime::GetDynamicTypeAndAddress_Promise(
+     address.SetLoadAddress(val_ptr_addr, &m_process->GetTarget());
+     return true;
+   } break;
++  case swift::MetadataKind::Function:
+   case swift::MetadataKind::Optional:
+   case swift::MetadataKind::Struct:
+   case swift::MetadataKind::Tuple: {",Is this needed?
+956,"@@ -348,7 +348,7 @@ export default Ember.Controller.extend(BillingCategories, EKMixin,
+       confirmDeleteValue(value) {
+         let i18n = this.get('i18n');
+         let title = i18n.t('admin.lookup.titles.deleteLookupValue');
+-        let message = i18n.t('admin.lookup.messages.deleteLookupValue', { value });
++        let message = i18n.t('messages.delete_singular', { name: value.concat(' value') });
+         this.displayConfirm(title, message, 'deleteValue', Ember.Object.create({
+           valueToDelete: value
+         }));",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.
+957,"@@ -18,6 +18,8 @@ package container
+ import (
+ 	""context""
+
++	""github.com/chaos-mesh/chaos-mesh/pkg/selector/generic""
++
+ 	""go.uber.org/fx""
+ 	v1 ""k8s.io/api/core/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""",how about moving it under L26
+958,"@@ -0,0 +1,17 @@
++/**
++ * Memoize a function.
++ * @method memoize
++ * @memberof axe.utils
++ * @param {Function} fn Function to memoize
++ * @return {Function}
++ */
++axe._memoizedFns = [];
++axe.utils.memoize = function(fn) {
++	// keep track of each function that is memoized so it can be cleared at
++	// the end of a run. each memoized function has its own cache, so there is
++	// no method to clear all memoized caches. instead, we have to clear each
++	// individual memoized function ourselves.
++	const memoized = axe.imports.memoize(fn);
++	axe._memoizedFns.push(memoized);
++	return memoized;
++};",I think this needs to be tested
+959,"@@ -2,6 +2,9 @@ class Trail < ApplicationRecord
+   extend FriendlyId
+
+   include PgSearch
++
++  DEFAULT_IMAGE_URL = ""https://images.thoughtbot.com/upcase/trail-title-cards/default.jpg""
++
+   multisearchable against: [:name, :description], if: :published?
+
+   validates :name, :description, presence: true",Style/MutableConstant: Freeze mutable objects assigned to constants.
+960,"@@ -155,16 +155,15 @@ public final class DeflateWithPresetDictCompressionMode extends CompressionMode
+
+   private static class DeflateWithPresetDictCompressor extends Compressor {
+
+-    final byte[] dictBytes;
+-    final int blockLength;
++    private final int dictLength, blockLength;
+     final Deflater compressor;
+     byte[] compressed;
+     boolean closed;
+
+     DeflateWithPresetDictCompressor(int level, int dictLength, int blockLength) {
+-      compressor = new Deflater(level, true);
++      compressor = BugfixDeflater_JDK8252739.createDeflaterInstance(level, true, dictLength);
+       compressed = new byte[64];
+-      this.dictBytes = new byte[dictLength];
++      this.dictLength = dictLength;
+       this.blockLength = blockLength;
+     }
+ ","Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken."
+961,"@@ -95,7 +95,7 @@ public class FSTTester<T> {
+     return br;
+   }
+
+-  static String getRandomString(Random random) {
++  public static String getRandomString(Random random) {
+     final String term;
+     if (random.nextBoolean()) {
+       term = TestUtil.randomRealisticUnicodeString(random);",Looks like this should be publicly accessible for tests in any modules?
+962,"@@ -19,7 +19,7 @@ if (is_array($env = @include dirname(__DIR__).'/.env.local.php')) {
+     throw new RuntimeException('Please run ""composer require symfony/dotenv"" to load the "".env"" files configuring the application.');
+ } else {
+     $path = dirname(__DIR__).'/.env';
+-    $dotenv = new Dotenv(false);
++    $dotenv = new Dotenv(true);
+
+     // load all the .env files
+     if (method_exists($dotenv, 'loadEnv')) {",Allow putenv is necessary to be able to get environment variables with `getenv`?
+963,"@@ -0,0 +1,17 @@
++#include <iostream>
++#include <conio.h>
++using namespace std;
++
++int main()
++{
++	int year;
++	cout<<""Enter year to check\n"";
++	cin>>year;
++	if((year%4==0 && year%100!=0) || year%400==0){
++		cout<<""leap year.\n"";
++	}
++	else{
++		cout<<"" Not leap year.\n"";
++	}
++	return 0;
++}",use function to check it. - don't do everything in main
+964,"@@ -50,7 +50,7 @@ class BaseRulesEngine(object):
+         self.full_rules_path = rules_file_path.strip()
+         self.snapshot_timestamp = snapshot_timestamp
+
+-    def build_rule_book(self):
++    def build_rule_book(self, global_configs):
+         """"""Build RuleBook from the rules definition file.""""""
+         raise NotImplementedError('Implement in a child class.')
+ ",Sorry I'm confused. Why not kwarg this like the others?
+965,"@@ -7171,15 +7171,15 @@ const instr_info_t vex_W_extensions[][2] = {
+      * registers are identical.  We don't bother trying to detect that.
+      */
+     {OP_vpgatherdd,0x66389018,""vpgatherdd"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+-    {OP_vpgatherdq,0x66389058,""vpgatherdq"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vpgatherdq,0x66389058,""vpgatherdq"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 67 */
+-    {OP_vpgatherqd,0x66389118,""vpgatherqd"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vpgatherqd,0x66389118,""vpgatherqd"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+     {OP_vpgatherqq,0x66389158,""vpgatherqq"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 68 */
+     {OP_vgatherdps,0x66389218,""vgatherdps"",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+-    {OP_vgatherdpd,0x66389258,""vgatherdpd"",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vgatherdpd,0x66389258,""vgatherdpd"",Vvd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 69 */
+-    {OP_vgatherqps,0x66389318,""vgatherqps"",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vgatherqps,0x66389318,""vgatherqps"",Vvs,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+     {OP_vgatherqpd,0x66389358,""vgatherqpd"",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 70 */
+     {OP_vpmaskmovd,0x66388c18,""vpmaskmovd"",Vx,xx,Hx,Mx,xx, mrm|vex|reqp|predcx,x,tvexw[71][0]},","First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So ""vpgatherdq"" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess."
+966,"@@ -118,6 +118,9 @@ class ExternalProgramTask(luigi.Task):
+         file_object.seek(0)
+         return ''.join(map(lambda s: s.decode('utf-8'), file_object.readlines()))
+
++    def build_tracking_url(self, logs_output):
++        return logs_output
++
+     def run(self):
+         args = list(map(str, self.program_args()))
+ ",Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method.
+967,"@@ -121,10 +121,7 @@ bool Creature::canSee(const Position& pos) const
+
+ bool Creature::canSeeCreature(const Creature* creature) const
+ {
+-	if (!canSeeInvisibility() && creature->isInvisible()) {
+-		return false;
+-	}
+-	return true;
++	return canSeeInvisibility() && creature->isInvisible();
+ }
+
+ void Creature::setSkull(Skulls_t newSkull)",You introduced a bug here.
+968,"@@ -261,6 +261,14 @@ namespace Microsoft.DotNet.Build.Tasks.VersionTools
+                 ""true"",
+                 StringComparison.OrdinalIgnoreCase);
+
++            string oldValue = step.GetMetadata(""ReplacementSubstituteOld"");
++            string newValue = step.GetMetadata(""ReplacementSubstituteNew"");
++
++            if (!string.IsNullOrEmpty(oldValue) && !string.IsNullOrEmpty(newValue))
++            {
++                updater.ReplacementTransform = v => v.Replace(oldValue, newValue);
++            }
++
+             return updater;
+         }
+ ",Should we log a warning/error if only one is specified and not the other?
+969,"@@ -463,4 +463,15 @@ func (c *fakeClient) ReportApplicationLiveStateEvents(ctx context.Context, req *
+ 	return &pipedservice.ReportApplicationLiveStateEventsResponse{}, nil
+ }
+
++func (c *fakeClient) GetLatestEvent(ctx context.Context, req *pipedservice.GetLatestEventRequest, opts ...grpc.CallOption) (*pipedservice.GetLatestEventResponse, error) {
++	c.logger.Info(""fake client received GetLatestEvent rpc"", zap.Any(""request"", req))
++	return &pipedservice.GetLatestEventResponse{
++		Event: &model.Event{
++			Id:        ""dev"",
++			Name:      ""dev"",
++			ProjectId: ""dev"",
++		},
++	}, nil
++}
++
+ var _ pipedservice.PipedServiceClient = (*fakeClient)(nil)",`ctx` is unused in GetLatestEvent
+970,"@@ -128,6 +128,14 @@ void nano_daemon::daemon::run (boost::filesystem::path const & data_path, nano::
+ 				logger.always_log (boost::format (""Open file descriptors limit is %1%"") % file_descriptor_limit);
+ 			}
+
++			// a 0-valued port means for the node 'let the OS decide'; however, for the daemon start up, if
++			// the user hasn't specified a port in the config, we must use the default peering port for the network
++			//
++			if (!config.node.peering_port)
++			{
++				config.node.peering_port = network_params.network.default_node_port;
++			}
++
+ 			auto node (std::make_shared<nano::node> (io_ctx, data_path, config.node, opencl_work, flags));
+ 			if (!node->init_error ())
+ 			{","This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to ""-1"" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well."
+971,"@@ -10,7 +10,6 @@ __all__ = [
+
+ class ImageTransform(object):
+     """"""Preprocess an image.
+-
+     1. rescale the image to expected size
+     2. normalize the image
+     3. flip the image (if needed)",The blank line between the summary and detailed description is better to be kept.
+972,"@@ -167,6 +167,11 @@ func (a *API) Setup() {
+ 	a.setMetadataEndpointsKey()
+ 	a.writeShapeNames()
+ 	a.resolveReferences()
++
++	if !a.NoRemoveUnusedShapes {
++		a.removeUnusedShapes()
++	}
++
+ 	a.fixStutterNames()
+ 	a.renameExportable()
+ 	a.applyShapeNameAliases()","Curiously, are these indents intended or should they be aligned?"
+973,"@@ -1130,7 +1130,9 @@ def getControlFieldSpeech(attrs,ancestorAttrs,fieldType,formatConfig=None,extraD
+ 	else:
+ 		tableID = None
+
+-	roleText=getSpeechTextForProperties(reason=reason,role=role)
++	roleText=attrs.get('roleText')
++	if not roleText:
++		roleText=getSpeechTextForProperties(reason=reason,role=role)
+ 	stateText=getSpeechTextForProperties(reason=reason,states=states,_role=role)
+ 	keyboardShortcutText=getSpeechTextForProperties(reason=reason,keyboardShortcut=keyboardShortcut) if config.conf[""presentation""][""reportKeyboardShortcuts""] else """"
+ 	ariaCurrentText=getSpeechTextForProperties(reason=reason,current=ariaCurrent)","What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if."
+974,"@@ -4801,7 +4801,15 @@ master_signal_handler_C(byte *xsp)
+         return;
+     }
+ #endif
+-    dcontext_t *dcontext = get_thread_private_dcontext();
++    /* We avoid using safe_read_tls_magic during detach. This thread may already have
++     * lost its TLS. A safe read may result into a race affecting asynchronous non-alarm
++     * signals (xref i#3535) between delivering the SIGSEGV and restoring the app's signal
++     * handlers. We don't need the thread's private dcontext anymore here at this point.
++     * Note that there is still a small race window if the signal gets delivered after the
++     * detach has finished, i.e. doing_detach is false. This is an issue in particular if
++     * the app has started re-attaching.
++     */
++    dcontext_t *dcontext = doing_detach ? NULL : get_thread_private_dcontext();
+
+ #ifdef MACOS
+ #    ifdef X64",This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit().
+975,"@@ -561,5 +561,4 @@ public class TestJdbcCatalog {
+     String nsString = JdbcUtil.namespaceToString(ns);
+     Assert.assertEquals(ns, JdbcUtil.stringToNamespace(nsString));
+   }
+-
+ }",Can you remove this change?
+976,"@@ -48,7 +48,7 @@ func ValidateCertificateForACMEIssuer(crt *cmapi.CertificateSpec, issuer *cmapi.
+ 	el := field.ErrorList{}
+
+ 	if crt.IsCA {
+-		el = append(el, field.Invalid(specPath.Child(""isCA""), crt.KeyAlgorithm, ""ACME does not support CA certificates""))
++		el = append(el, field.Invalid(specPath.Child(""isCA""), crt.IsCA, ""ACME does not support CA certificates""))
+ 	}
+
+ 	if crt.Subject != nil && len(crt.Subject.Organizations) != 0 {","Oh, was that a bug in the validation?"
+977,"@@ -134,6 +134,10 @@ public class OnlineFeedViewActivity extends AppCompatActivity {
+         } else {
+             Log.d(TAG, ""Activity was started with url "" + feedUrl);
+             setLoadingLayout();
++            //Remove subscribeonandroid.com from feed URL in order to subscribe to the actual feed URL
++            if(feedUrl.contains(""subscribeonandroid.com"")){
++                feedUrl = feedUrl.replaceFirst(""((www.)?(subscribeonandroid.com/))"","""");
++            }
+             if (savedInstanceState == null) {
+                 startFeedDownload(feedUrl, null, null);
+             } else {","Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent."
+978,"@@ -145,10 +145,12 @@ TEST(UpdateEdgeTest, Set_Filter_Yield_Test) {
+     decltype(req.return_columns) tmpColumns;
+     tmpColumns.emplace_back(Expression::encode(val1));
+     tmpColumns.emplace_back(Expression::encode(val2));
+-    std::string name = folly::to<std::string>(3002);
+-    std::string prop = ""tag_3002_col_2"";
+-    auto* sourcePropExp = new SourcePropertyExpression(&name, &prop);
++    delete val1;
++    delete val2;
++    auto* sourcePropExp = new SourcePropertyExpression(
++        new std::string(folly::to<std::string>(3002)), new std::string(""tag_3002_col_2""));
+     tmpColumns.emplace_back(Expression::encode(sourcePropExp));
++    delete sourcePropExp;
+
+     req.set_return_columns(std::move(tmpColumns));
+     req.set_insertable(false);","Actually, I don't think we need to create object on heap."
+979,"@@ -84,7 +84,7 @@ void GenerateImports(grpc_generator::File *file, grpc_generator::Printer *printe
+ 	}
+ 	printer->Print(""import (\n"");
+ 	printer->Indent();
+-	printer->Print(vars, ""$context$ \""golang.org/x/net/context\""\n"");
++	printer->Print(vars, ""$context$ \""context\""\n"");
+ 	printer->Print(vars, ""$grpc$ \""google.golang.org/grpc\""\n"");
+ 	printer->Outdent();
+ 	printer->Print("")\n\n"");","this is a file we copy from gRPC, sp ideally it be fixed upstream as well.."
+980,"@@ -14,7 +14,6 @@
+ package zipkin2.storage.cassandra.v1;
+
+ import com.datastax.driver.core.Session;
+-import com.google.common.cache.CacheBuilderSpec;
+ import java.nio.ByteBuffer;
+ import java.util.ArrayList;
+ import java.util.LinkedHashSet;","changes like this, just strangle guava usages to be replaced by DelayLimiter into one place"
+981,"@@ -27,8 +27,8 @@ const Widget = ( {
+ 	className,
+ 	slug,
+ 	noPadding,
+-	header: Header,
+-	footer: Footer,
++	Header,
++	Footer,
+ } ) => {
+ 	return (
+ 		<div","PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`."
+982,"@@ -221,7 +221,7 @@ int get_ctest_gpu(const char* local_rank_str) {
+   }
+
+   auto const* comma = std::strchr(resource_str, ',');
+-  if (!comma || strncmp(resource_str, ""id:"", 3)) {
++  if (!comma || strncmp(resource_str, ""id:"", 3) != 0) {
+     std::ostringstream ss;
+     ss << ""Error: invalid value of "" << ctest_resource_group_id_name << "": '""
+        << resource_str << ""'. Raised by Kokkos::Impl::get_ctest_gpu()."";",maybe extra paren around `strncmp(...) != 0`
+983,"@@ -510,6 +510,8 @@ public class Windows implements TrayListener, TopBarWidget.Delegate, TitleBarWid
+
+         TelemetryWrapper.resetOpenedWindowsCount(mRegularWindows.size(), false);
+         TelemetryWrapper.resetOpenedWindowsCount(mPrivateWindows.size(), true);
++        GleanMetricsService.resetOpenedWindowsCount(mRegularWindows.size(), false);
++        GleanMetricsService.resetOpenedWindowsCount(mPrivateWindows.size(), true);
+     }
+
+     public boolean isPaused() {",We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed
+984,"@@ -31,7 +31,7 @@ import java.util.function.Function;
+
+ import com.google.common.annotations.VisibleForTesting;
+
+-public class BftForksSchedule<C extends BftConfigOptions> {
++public class BftForksSchedule<C> {
+
+   private final NavigableSet<ForkSpec<C>> forks =
+       new TreeSet<>(",Rename to ForksSchedule? Maybe in separate PR.
+985,"@@ -1,11 +1,12 @@
+-import pytest
+ import time
+ from unittest import mock
+
++import pytest
++
+ from pyramid import testing
+
+-from kinto.core.storage import exceptions
+ from kinto.core.cache import heartbeat
++from kinto.core.storage import exceptions
+
+
+ class CacheTest:",Why a blank line here?
+986,"@@ -14,6 +14,10 @@ class Subscription < ActiveRecord::Base
+     notifier.send_notifications
+   end
+
++  def active?
++    deactivated_on.nil?
++  end
++
+   private
+
+   def self.subscriber_emails","I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality."
+987,"@@ -36,6 +36,10 @@ public class EnvironmentVariableDefaultProvider implements IDefaultValueProvider
+
+   @Override
+   public String defaultValue(final ArgSpec argSpec) {
++    if (!argSpec.isOption()) {
++      return null; // skip default for positional params
++    }
++
+     return envVarNames((OptionSpec) argSpec)
+         .map(environment::get)
+         .filter(Objects::nonNull)",What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?
+988,"@@ -1415,7 +1415,13 @@ void ProtocolGame::sendBasicData()
+ 		msg.addByte(0);
+ 		msg.add<uint32_t>(0);
+ 	}
++
+ 	msg.addByte(player->getVocation()->getClientId());
++
++	if (version >= 1100) {
++		msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00); // prey data
++	}
++
+ 	msg.add<uint16_t>(0xFF); // number of known spells
+ 	for (uint8_t spellId = 0x00; spellId < 0xFF; spellId++) {
+ 		msg.addByte(spellId);",Why would you add those if client version min is set to 1100?
+989,"@@ -7,12 +7,13 @@
+ package snapshotsync
+
+ import (
++	reflect ""reflect""
++	sync ""sync""
++
+ 	proto ""github.com/golang/protobuf/proto""
+ 	protoreflect ""google.golang.org/protobuf/reflect/protoreflect""
+ 	protoimpl ""google.golang.org/protobuf/runtime/protoimpl""
+ 	emptypb ""google.golang.org/protobuf/types/known/emptypb""
+-	reflect ""reflect""
+-	sync ""sync""
+ )
+
+ const (","You can delete this, it will now need to live in `gointerfaces` package"
+990,"@@ -3,7 +3,7 @@
+   <%= render 'previous_next_doc' %>
+
+
+-<% @page_title = t('blacklight.search.show.title', :document_title => document_show_html_title, :application_name => application_name) -%>
++<% @page_title = t('blacklight.search.show.title', :document_title => document_show_html_title, :application_name => application_name).html_safe -%>
+ <% content_for(:head) { render_link_rel_alternates } -%>
+ <%# this should be in a partial -%>
+ ","Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work."
+991,"@@ -1435,6 +1435,8 @@ public class MessageList extends K9Activity implements MessageListFragmentListen
+     public void displayMessageSubject(String subject) {
+         if (mDisplayMode == DisplayMode.MESSAGE_VIEW) {
+             mActionBarSubject.setText(subject);
++        } else {
++            mActionBarSubject.showSubjectInMessageHeader();
+         }
+     }
+ ",What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?
+992,"@@ -65,7 +65,7 @@ func NewProvider(opts ...ProviderOption) (*Provider, error) {
+ 		namedTracer: make(map[string]*tracer),
+ 	}
+ 	tp.config.Store(&Config{
+-		DefaultSampler:       ProbabilitySampler(defaultSamplingProbability),
++		DefaultSampler:       AlwaysSample(),
+ 		IDGenerator:          defIDGenerator(),
+ 		MaxAttributesPerSpan: DefaultMaxAttributesPerSpan,
+ 		MaxEventsPerSpan:     DefaultMaxEventsPerSpan,",Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change.
+993,"@@ -63,9 +63,9 @@ func (s *svc) UpdateDeployment(ctx context.Context, clientset, cluster, namespac
+ 	}
+
+ 	newDeployment := oldDeployment.DeepCopy()
+-	mergeLabelsAndAnnotations(newDeployment, fields)
++	mergeDeploymentLabelsAndAnnotations(newDeployment, fields)
+
+-	patchBytes, err := generateDeploymentStrategicPatch(oldDeployment, newDeployment)
++	patchBytes, err := GenerateStrategicPatch(oldDeployment, newDeployment, appsv1.Deployment{})
+ 	if err != nil {
+ 		return err
+ 	}",can you delete the `generateDeploymentStrategicPatch` function as well?
+994,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...
+995,"@@ -50,6 +50,10 @@ StatusOr<OptRule::TransformResult> LimitPushDownRule::transform(
+   const auto proj = static_cast<const Project *>(projGroupNode->node());
+   const auto gn = static_cast<const GetNeighbors *>(gnGroupNode->node());
+
++  DCHECK(graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()));
++  if (!graph::ExpressionUtils::isEvaluableExpr(limit->countExpr())) {
++    return TransformResult::noTransform();
++  }
+   int64_t limitRows = limit->offset() + limit->count();
+   if (gn->limit() >= 0 && limitRows >= gn->limit()) {
+     return TransformResult::noTransform();",Don't use DCHECK to debug your code if it's the regular branch you need to handle.
+996,"@@ -46,11 +46,6 @@ public interface AntlrNode extends Node {
+         throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");
+     }
+
+-    @Override
+-    default String getImage() {
+-        throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");
+-    }
+-
+     @Override
+     default void setImage(final String image) {
+         throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");",You should return null here instead. Null is an acceptable default value for the image attribute.
+997,"@@ -246,9 +246,14 @@ export function useErrorBoundary(cb) {
+ function flushAfterPaintEffects() {
+ 	afterPaintEffects.some(component => {
+ 		if (component._parentDom) {
+-			component.__hooks._pendingEffects.forEach(invokeCleanup);
+-			component.__hooks._pendingEffects.forEach(invokeEffect);
+-			component.__hooks._pendingEffects = [];
++			try {
++				component.__hooks._pendingEffects.forEach(invokeCleanup);
++				component.__hooks._pendingEffects.forEach(invokeEffect);
++				component.__hooks._pendingEffects = [];
++			} catch (e) {
++				options._catchError(e, component._vnode);
++				return true;
++			}
+ 		}
+ 	});
+ 	afterPaintEffects = [];",react bails as well?
+998,"@@ -7,7 +7,6 @@ namespace Shopsys\FrameworkBundle\Model\Security;
+ class Roles
+ {
+     public const ROLE_ADMIN = 'ROLE_ADMIN';
+-    public const ROLE_ADMIN_AS_CUSTOMER = 'ROLE_ADMIN_AS_CUSTOMER';
+     public const ROLE_LOGGED_CUSTOMER = 'ROLE_LOGGED_CUSTOMER';
+     public const ROLE_SUPER_ADMIN = 'ROLE_SUPER_ADMIN';
+ ",Can you please tell me why you did this?
+999,"@@ -168,9 +168,12 @@ module.exports = class Webcam extends Plugin {
+       this.opts.modes.indexOf('video-only') !== -1 ||
+       this.opts.modes.indexOf('picture') !== -1
+
++    const videoConstraints = this.opts.videoConstraints ?? {}
++    videoConstraints.facingMode = this.opts.facingMode
++
+     return {
+       audio: acceptsAudio,
+-      video: acceptsVideo ? { facingMode: this.opts.facingMode } : false
++      video: acceptsVideo ? videoConstraints : false
+     }
+   }
+ ",Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set
+1000,"@@ -1,7 +1,10 @@
+ class Video < ActiveRecord::Base
++  extend FriendlyId
++
+   belongs_to :watchable, polymorphic: true
+
+   validates :published_on, presence: true
++  validates :slug, presence: true, uniqueness: true
+   validates :title, presence: true
+   validates :watchable_id, presence: true
+   validates :watchable_type, presence: true",There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?
+1001,"@@ -79,7 +79,10 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(Buil
+ 	// keep functions interoperable, pass int64 types as pointers to
+ 	// stack-allocated values.
+ 	// Use -wasm-abi=generic to disable this behaviour.
+-	if config.Options.WasmAbi == ""js"" && strings.HasPrefix(config.Triple(), ""wasm"") {
++	if config.Options.WasmAbi != """" {
++		config.Target.WasmAbi = config.Options.WasmAbi
++	}
++	if config.Target.WasmAbi == ""js"" {
+ 		err := transform.ExternalInt64AsPtr(mod)
+ 		if err != nil {
+ 			return err","Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc)."
+1002,"@@ -159,6 +159,14 @@ func newTestEnv(inboundOptions []InboundOption, outboundOptions []OutboundOption
+ 	testRouter := newTestRouter(procedures)
+
+ 	t := NewTransport()
++	if err := t.Start(); err != nil {
++		return nil, err
++	}
++	defer func() {
++		if err != nil {
++			err = multierr.Append(err, t.Stop())
++		}
++	}()
+
+ 	listener, err := net.Listen(""tcp"", ""127.0.0.1:0"")
+ 	if err != nil {",The nil check is not necessary for these. Append checks both sides for nil.
+1003,"@@ -62,6 +62,7 @@ func main() {
+ 			trace.WithAttributes(attrs...),
+ 			trace.ChildOf(spanCtx),
+ 		)
++		span.SetAttributes(entries...)
+ 		defer span.End()
+
+ 		span.AddEvent(ctx, ""handling this..."")","Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes."
+1004,"@@ -60,5 +60,12 @@ func (t *topologyAPI) GetTopology(ctx context.Context, req *topologyv1.GetTopolo
+ }
+
+ func (t *topologyAPI) SearchTopology(ctx context.Context, req *topologyv1.SearchTopologyRequest) (*topologyv1.SearchTopologyResponse, error) {
+-	return nil, errors.New(""not implemented"")
++	resources, err := t.topology.SearchTopology(ctx, req)
++	if err != nil {
++		return nil, err
++	}
++
++	return &topologyv1.SearchTopologyResponse{
++		Resources: resources,
++	}, nil
+ }",nit: rename this in proto and update impl to `Search` to avoid stutter
+1005,"@@ -78,7 +78,8 @@ class SliderController extends AdminBaseController
+             ->from(SliderItem::class, 's')
+             ->where('s.domainId = :selectedDomainId')
+             ->setParameter('selectedDomainId', $this->adminDomainTabsFacade->getSelectedDomainId())
+-            ->orderBy('s.position');
++            ->orderBy('s.position')
++            ->addOrderBy('s.id');
+         $dataSource = new QueryBuilderDataSource($queryBuilder, 's.id');
+
+         $grid = $this->gridFactory->create('sliderItemList', $dataSource);",is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend)
+1006,"@@ -18,8 +18,10 @@ import (
+ )
+
+ var (
+-	claimFromRewardingFundBaseGas    = uint64(10000)
+-	claimFromRewardingFundGasPerByte = uint64(100)
++	// ClaimFromRewardingFundBaseGas represents the base intrinsic gas for claimFromRewardingFund
++	ClaimFromRewardingFundBaseGas = uint64(10000)
++	// ClaimFromRewardingFundGasPerByte represents the claimFromRewardingFund payload gas per uint
++	ClaimFromRewardingFundGasPerByte = uint64(100)
+ )
+
+ // ClaimFromRewardingFund is the action to claim reward from the rewarding fund",`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`)
+1007,"@@ -89,9 +89,11 @@ namespace RDKit {
+   }
+   PyObject *GetSubstructMatch(const ROMol &mol, const ROMol &query,bool useChirality=false,
+                             bool useQueryQueryMatches=false){
+-    NOGIL gil;
+     MatchVectType matches;
+-    SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);
++    {
++      NOGIL gil;
++      SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);
++    }
+     return convertMatches(matches);
+   }
+ ",How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?
+1008,"@@ -29,6 +29,11 @@ type chainState interface {
+ 	LatestState(ctx context.Context) (state.Tree, error)
+ }
+
++// BlockTimer defines a interface to a struct that can give the current block height.
++type BlockTimer interface {
++	BlockHeight() (uint64, error)
++}
++
+ // PublishFunc is a function the Sender calls to publish a message to the network.
+ type PublishFunc func(topic string, data []byte) error
+ ",blockheighter would be more clear
+1009,"@@ -949,5 +949,15 @@ void OptimizerUtils::copyIndexScanData(const nebula::graph::IndexScan* from,
+   to->setFilter(from->filter() == nullptr ? nullptr : from->filter()->clone());
+ }
+
++Status OptimizerUtils::compareAndSwapBound(std::pair<Value, bool>& a, std::pair<Value, bool>& b) {
++  if (a.first > b.first) {
++    std::swap(a, b);
++  } else if (a.first < b.first) {  // do nothing
++  } else if (a.second > b.second) {
++    std::swap(a, b);
++  }
++  return Status::OK();
++}
++
+ }  // namespace graph
+ }  // namespace nebula",This is so weird as a utility function.
+1010,"@@ -58,7 +58,8 @@ func TestPlanQuery(t *testing.T) {
+ 		return m
+ 	}
+
+-	cmpopt := cmp.AllowUnexported(dynamodb.ScanInput{}, dynamodb.QueryInput{}, dynamodb.AttributeValue{})
++	// Ignores the ConsistentRead field from both QueryInput and ScanInput.
++	cmpopt := cmp.FilterPath(func(p cmp.Path) bool { return p.Last().String() == "".ConsistentRead"" }, cmp.Ignore())
+
+ 	for _, test := range []struct {
+ 		desc string",Why? What would happen if you did not?
+1011,"@@ -752,7 +752,9 @@ public class SmartStore  {
+         String[] pathElements = path.split(""[.]"");
+         Object o = soup;
+         for (String pathElement : pathElements) {
+-            o = ((JSONObject) o).opt(pathElement);
++        	if (o != null) {
++                o = ((JSONObject) o).opt(pathElement);
++        	}
+         }
+         return o;
+     }",Unrelated bugfix for NPE.
+1012,"@@ -387,7 +387,7 @@ class AdminController extends Controller
+             throw new \Exception(sprintf('The ""%s"" property is not a switchable toggle.', $propertyName));
+         }
+
+-        if (!$propertyMetadata['canBeSet']) {
++        if (!$propertyMetadata['isWritable']) {
+             throw new \Exception(sprintf('It\'s not possible to toggle the value of the ""%s"" boolean property of the ""%s"" entity.', $propertyName, $this->entity['name']));
+         }
+ ",What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?
+1013,"@@ -524,6 +524,17 @@
+                 dataType: ""json""
+             });
+         },
++        fetchSegmentMap: function() {
++            return CV.$.ajax({
++                type: ""GET"",
++                url: countlyCommon.API_PARTS.data.r + '/data-manager/event-segment',
++                data: {
++                    ""app_id"": countlyCommon.ACTIVE_APP_ID,
++                    ""preventRequestAbort"": true,
++                },
++                dataType: ""json""
++            });
++        },
+         fetchRefreshSelectedEventsData: function(context) {
+             return CV.$.ajax({
+                 type: ""GET"",","This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?"
+1014,"@@ -219,7 +219,7 @@ func (o *deploySvcOpts) generateWorkerServiceRecommendedActions() {
+ 	retrieveEnvVarCode := ""const eventsQueueURI = process.env.COPILOT_QUEUE_URI""
+ 	actionRetrieveEnvVar := fmt.Sprintf(
+ 		`Update %s's code to leverage the injected environment variable ""COPILOT_QUEUE_URI"".
+-In JavaScript you can write %s.`,
++  In JavaScript you can write %s.`,
+ 		o.name,
+ 		color.HighlightCode(retrieveEnvVarCode),
+ 	)",Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?
+1015,"@@ -3277,7 +3277,7 @@ bool CoreChecks::PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool
+                                                     VkQueryResultFlags flags) const {
+     if (disabled.query_validation) return false;
+     bool skip = false;
+-    skip |= ValidateQueryPoolStride(""VUID-vkGetQueryPoolResults-flags-00814"", ""VUID-vkGetQueryPoolResults-flags-00815"", stride,
++    skip |= ValidateQueryPoolStride(""VUID-vkGetQueryPoolResults-flags-02827"", ""VUID-vkGetQueryPoolResults-flags-00815"", stride,
+                                     ""dataSize"", dataSize, flags);
+     skip |= ValidateGetQueryPoolResultsFlags(queryPool, flags);
+     skip |= ValidateGetQueryPoolResultsQueries(queryPool, firstQuery, queryCount);","The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation."
+1016,"@@ -74,11 +74,12 @@ namespace Nethermind.Store
+             db[key.ToBigEndianByteArrayWithoutLeadingZeros()] = value;
+         }
+
+-        public static byte[] Get(this IDb db, long key)
+-        {
+-            return db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
+-        }
+-
++        public static byte[] Get(this IDb db, long key) => db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
++
++        public static byte[] ToDbKey(this long key) => key.ToBigEndianByteArrayWithoutLeadingZeros();
++
++        public static byte[] ToDbKey(this Keccak key) => key.Bytes;
++
+         public static void Delete(this IDb db, long key)
+         {
+             db.Remove(key.ToBigEndianByteArrayWithoutLeadingZeros());",Iguess you should use ToDbKey here
+1017,"@@ -179,16 +179,7 @@ func (x *blockIndexer) DeleteTipBlock(blk *block.Block) error {
+ func (x *blockIndexer) Height() (uint64, error) {
+ 	x.mutex.RLock()
+ 	defer x.mutex.RUnlock()
+-
+-	index, err := db.GetCountingIndex(x.kvStore, totalBlocksBucket)
+-	if err != nil {
+-		if errors.Cause(err) == db.ErrBucketNotExist || errors.Cause(err) == db.ErrNotExist {
+-			// counting index does not exist yet
+-			return 0, nil
+-		}
+-		return 0, err
+-	}
+-	return index.Size() - 1, nil
++	return x.tbk.Size() - 1, nil
+ }
+
+ // GetBlockHash returns the block hash by height","x.tbk is the ""index"" below, and is done in Start()"
+1018,"@@ -8,6 +8,7 @@ namespace Datadog.Trace.Util
+     /// </summary>
+     internal static class DomainMetadata
+     {
++        private const string IsAppInsightKey = ""DD_IsAppInsight"";
+         private const string UnknownName = ""unknown"";
+         private static Process _currentProcess;
+         private static bool _processDataPoisoned;","Do we already have a convention for this? If not, would we consider ""DataDog.IsAppInsights"". And then use ""DataDog."" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)"
+1019,"@@ -95,6 +95,16 @@ static int cb_firehose_init(struct flb_output_instance *ins,
+         ctx->time_key_format = DEFAULT_TIME_KEY_FORMAT;
+     }
+
++    tmp = flb_output_get_property(""log_key"", ins);
++    if (tmp) {
++        ctx->log_key = tmp;
++    }
++
++    if (ctx->log_key && ctx->time_key) {
++        flb_plg_error(ctx->ins, ""'time_key' and 'log_key' can not be used together"");
++        goto error;
++    }
++
+     tmp = flb_output_get_property(""endpoint"", ins);
+     if (tmp) {
+         ctx->custom_endpoint = FLB_TRUE;",this assignment is not necessary if the offsetof() is used in the configmap
+1020,"@@ -268,11 +268,6 @@ func (p *Protocol) claimFromAccount(sm protocol.StateManager, addr address.Addre
+ 	balance := big.NewInt(0).Sub(acc.balance, amount)
+ 	if balance.Cmp(big.NewInt(0)) < 0 {
+ 		return errors.New(""no enough available balance"")
+-	} else if balance.Cmp(big.NewInt(0)) == 0 {
+-		// If the account balance is cleared, delete if from the store
+-		if err := p.deleteState(sm, accKey); err != nil {
+-			return err
+-		}
+ 	} else {
+ 		acc.balance = balance
+ 		if err := p.putState(sm, accKey, &acc); err != nil {",I'd rather leave a TODO here at least.
+1021,"@@ -115,10 +115,10 @@ class BatchViewTest(BaseWebTest, unittest.TestCase):
+         request = {""path"": ""/mushrooms/""}  # trailing slash
+         body = {""requests"": [request]}
+         resp = self.app.post_json(""/batch"", body, headers=self.headers)
+-        collection = resp.json[""responses""][0]
+-        self.assertEqual(collection[""status""], 200)
+-        self.assertEqual(collection[""path""], ""/v0/mushrooms"")
+-        self.assertEqual(collection[""body""], {""data"": []})
++        objects = resp.json[""responses""][0]
++        self.assertEqual(objects[""status""], 200)
++        self.assertEqual(objects[""path""], ""/v0/mushrooms"")
++        self.assertEqual(objects[""body""], {""data"": []})
+
+     def test_body_is_transmitted_during_redirect(self):
+         request = {",Shouldn't this be `resource`?
+1022,"@@ -37,13 +37,12 @@ namespace {
+ /** CPU implementation of evaluation layer forward prop. */
+ void fp_cpu(lbann_comm& comm,
+             const AbsDistMat& input,
+-            DataType& value,
+-            Al::request& req) {
++            DataType& value) {
+   const auto& local_input = input.LockedMatrix();
+   const auto& local_height = local_input.Height();
+   const auto& local_width = local_input.Width();
+   const auto& mini_batch_size = input.Width();
+-  value = DataType(0);
++  value = 0;
+ #pragma omp parallel for reduction(+:value) collapse(2)
+   for (El::Int col = 0; col < local_width; ++col) {
+     for (El::Int row = 0; row < local_height; ++row) {",Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?
+1023,"@@ -24,7 +24,7 @@ module Travis
+           sh.export 'TRAVIS_RUBY_VERSION', config[:rvm], echo: false if rvm?
+         end
+
+-        def setup
++        def configure
+           super
+           setup_rvm if rvm?
+         end",Do we need to change occurences where `setup` was called before?
+1024,"@@ -61,6 +61,16 @@ func (a *API) resolveReferences() {
+ 			o.ErrorRefs[i].Shape.IsError = true
+ 		}
+ 	}
++
++	// TODO put this somewhere better
++	for _, s := range a.Shapes {
++		switch s.Type {
++		case ""list"":
++			s.MemberRef.Shape.UsedInList = true
++		case ""map"":
++			s.ValueRef.Shape.UsedInMap = true
++		}
++	}
+ }
+
+ // A referenceResolver provides a way to resolve shape references to",Is this TODO still valid? Or are we going to put this somewhere else later?
+1025,"@@ -15,12 +15,17 @@ def generate_data(test_user_id, user_name, from_ts, num_records):
+     test_data = []
+     artist_msid = str(uuid.uuid4())
+
+-    for i in range(num_records):
++    if (from_ts == None):  #check for playing now listens
++        timestamp = None
++    else:
+         from_ts += 1   # Add one second
++        timestamp = datetime.utcfromtimestamp(from_ts)
++
++    for i in range(num_records):
+         item = Listen(
+             user_name=user_name,
+             user_id=test_user_id,
+-            timestamp=datetime.utcfromtimestamp(from_ts),
++            timestamp= timestamp,
+             artist_msid=artist_msid,
+             recording_msid=str(uuid.uuid4()),
+             data={",We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`
+1026,"@@ -460,9 +460,13 @@ void tm_process_req_requestregioninfo(CTmTxMessage * pp_msg)
+        TM_Txid_legacy lv_transid;
+    } u;
+
+-   char tname[2000], ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
++   char tname[2000];
++   tname[299] = '\0';
++/*
++   char ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
+    tname[299] = '\0', ername[49] = '\0', rname[99] = '\0', offline[19] = '\0';
+    regid[199]= '\0', hostname[199]='\0', port[99]='\0';
++*/
+
+    TMTrace(2, (""tm_process_req_requestregioninfo ENTRY.\n""));
+    HashMapArray* map = HbaseTM_process_request_regions_info();",Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before.
+1027,"@@ -28,3 +28,9 @@ type PeerAdder interface {
+ type ClosestPeerer interface {
+ 	ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
+ }
++
++// ScoreFunc is implemented by components that need to score peers in a different way than XOR distance.
++type ScoreFunc func(peer swarm.Address) (score float32)
++
++// EachPeerFunc is a callback that is called with a peer and its PO
++type EachPeerFunc func(swarm.Address, uint8) (stop, jumpToNext bool, err error)",ScoreFunc is not used in this PR. Maybe to add it later when needed?
+1028,"@@ -171,9 +171,9 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
+ 		http.SetCookie(w, cookie)
+ 	}
+
+-	if redirects := md.HeaderMD.Get(""Location""); len(redirects) > 0 {
+-		w.Header().Set(""Location"", redirects[0])
+-
++	// Redirect if it's the browser (non-XHR).
++	redirects := md.HeaderMD.Get(""Location"")
++	if len(redirects) > 0 && isBrowser(copyRequestHeadersFromResponseWriter(w)) {
+ 		code := http.StatusFound
+ 		if st := md.HeaderMD.Get(""Location-Status""); len(st) > 0 {
+ 			headerCodeOverride, err := strconv.Atoi(st[0])",super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`
+1029,"@@ -4,12 +4,8 @@
+  *  (found in the LICENSE.Apache file in the root directory)
+  */
+ #include <gtest/gtest.h>
+-#include <cstdlib>
+-#include <thread>
+-#include <mutex>
+-#include <atomic>
+-#include ""common/concurrent/Barrier.h""
+-#include ""common/thread/GenericThreadPool.h""
++#include ""concurrent/Barrier.h""
++#include ""thread/GenericThreadPool.h""
+
+ namespace vesoft {
+ namespace concurrent {","Need to include ""common/base/Base.h"" in front of this line"
+1030,"@@ -1,6 +1,5 @@
+ import getRole from '../aria/get-role';
+-import matches from '../matches/matches';
+-import nativeElementType from './native-element-type';
++import getElementSpec from '../standards/get-element-spec';
+ import nativeTextMethods from './native-text-methods';
+
+ /**",Changes in this file should go into a separate PR.
+1031,"@@ -243,10 +243,15 @@ public class PhpSurfaceNamer extends SurfaceNamer {
+         if (token.equals(InitFieldConfig.RANDOM_TOKEN)) {
+           stringParts.add(""time()"");
+         } else {
+-          stringParts.add(""\"""" + token + ""\"""");
++          stringParts.add(quoted(token));
+         }
+       }
+     }
+     return Joiner.on("". "").join(stringParts);
+   }
++
++  @Override
++  public String quoted(String text) {
++    return ""\'"" + text + ""\'"";
++  }
+ }",Please ensure that this will not start putting single quotes where double quotes are expected.
+1032,"@@ -68,7 +68,7 @@ type Manager struct {
+ }
+
+ // ProvideConfig provides the config for consumer
+-func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
++func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int, int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
+ 	key := &wg.ConsumerConfig{}
+ 	err := json.Unmarshal(publicKey, key)
+ 	if err != nil {","`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too."
+1033,"@@ -76,9 +76,8 @@ func Search(ctx *context.APIContext) {
+ 	})
+ }
+
+-// https://github.com/gogits/go-gogs-client/wiki/Repositories#list-your-repositories
+-func ListMyRepos(ctx *context.APIContext) {
+-	ownRepos, err := models.GetUserRepositories(ctx.User.ID, true, 1, ctx.User.NumRepos)
++func listUserRepos(ctx *context.APIContext, u *models.User) {
++	ownRepos, err := models.GetUserRepositories(u.ID, true, 1, u.NumRepos)
+ 	if err != nil {
+ 		ctx.Error(500, ""GetRepositories"", err)
+ 		return","This does not look right, you're listing all private repositories.."
+1034,"@@ -20,4 +20,6 @@ C2::Application.routes.draw do
+   get 'bookmarklet', to: redirect('bookmarklet.html')
+   get ""/498"", :to => ""errors#token_authentication_error""
+
++  match ""*path"" => ""application#xss_options_request"", :via => :options
++
+ end",An OPTIONS request should respond from _any_ path? Seems weird to me...
+1035,"@@ -40,6 +40,8 @@ class MediaAdmin extends Admin
+             ->add('category', null, array(
+                 'show_filter' => false,
+             ))
++            ->add('width')
++            ->add('height')
+         ;
+
+         $providers = array();",you need to add the content type
+1036,"@@ -12,6 +12,14 @@ namespace Datadog.Trace
+     {
+         private static Task _traceAgentMonitor;
+         private static Task _dogStatsDMonitor;
++        private static Process _traceAgentProcess;
++        private static Process _dogStatsProcess;
++
++        public static void StopSubProcesses()
++        {
++            SafelyKillProcess(_traceAgentProcess, ""Failed to halt the sub-process trace agent"");
++            SafelyKillProcess(_dogStatsProcess, ""Failed to halt the sub-process stats agent"");
++        }
+
+         public static void StartStandaloneAgentProcessesWhenConfigured()
+         {",Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally.
+1037,"@@ -61,8 +61,8 @@ callee_info_t default_callee_info;
+ int
+ get_clean_call_switch_stack_size(void)
+ {
+-#ifdef AARCH64
+-    /* Stack size needs to be 16 byte aligned on ARM */
++#if defined(AARCH64) || defined(X64)
++    /* Stack size needs to be 16 byte aligned on ARM and x64. */
+     return ALIGN_FORWARD(sizeof(priv_mcontext_t), 16);
+ #else
+     return sizeof(priv_mcontext_t);","This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined."
+1038,"@@ -271,7 +271,8 @@ final class MySQLSpanStore implements SpanStore {
+           .selectDistinct(ZIPKIN_SPANS.NAME)
+           .from(ZIPKIN_SPANS)
+           .join(ZIPKIN_ANNOTATIONS)
+-          .on(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
++          .on(ZIPKIN_SPANS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH))
++          .and(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
+           .and(ZIPKIN_SPANS.ID.eq(ZIPKIN_ANNOTATIONS.SPAN_ID))
+           .where(ZIPKIN_ANNOTATIONS.ENDPOINT_SERVICE_NAME.eq(serviceName))
+           .orderBy(ZIPKIN_SPANS.NAME)",guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?
+1039,"@@ -53,6 +53,7 @@ module Beaker
+     class_option :'xml-time-order', :type => :boolean, :group => 'Beaker run'
+     class_option :'debug-errors', :type => :boolean, :group => 'Beaker run'
+     class_option :'exec_manual_tests', :type => :boolean, :group => 'Beaker run'
++    class_option :'test-tag-exclude', :type => :string, :group => 'Beaker run'
+
+     # The following are listed as deprecated in beaker --help, but needed now for
+     # feature parity for beaker 3.x.",Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function.
+1040,"@@ -143,7 +143,10 @@ namespace OpenTelemetry.Context.Propagation
+                         break;
+                     }
+
+-                    if (NameValueHeaderValue.TryParse(pair, out NameValueHeaderValue baggageItem))
++                    var decodedPair = WebUtility.UrlDecode(pair);
++                    var escapedPair = string.Join(""="", decodedPair.Split('=').Select(Uri.EscapeDataString));
++
++                    if (NameValueHeaderValue.TryParse(escapedPair, out NameValueHeaderValue baggageItem))
+                     {
+                         if (string.IsNullOrEmpty(baggageItem.Name) || string.IsNullOrEmpty(baggageItem.Value))
+                         {","This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?"
+1041,"@@ -55,10 +55,17 @@ public class PvPUtil
+ 	public static boolean isAttackable(Client client, Player player)
+ 	{
+ 		int wildernessLevel = 0;
+-		if (!(client.getVar(Varbits.IN_WILDERNESS) == 1 || WorldType.isPvpWorld(client.getWorldType())))
++		if (!(client.getVar(Varbits.IN_WILDERNESS) == 1
++				|| WorldType.isPvpWorld(client.getWorldType())
++				|| client.getWorldType().contains(WorldType.DEADMAN)
++		))
+ 		{
+ 			return false;
+ 		}
++		if (client.getWorldType().contains(WorldType.DEADMAN))
++		{
++			return true;
++		}
+ 		if (WorldType.isPvpWorld(client.getWorldType()))
+ 		{
+ 			if (client.getVar(Varbits.IN_WILDERNESS) != 1)",This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls.
+1042,"@@ -600,11 +600,11 @@ class SABLRetinaHead(BaseDenseHead, BBoxTestMixin):
+                 bbox_cls_pred.contiguous(),
+                 bbox_reg_pred.contiguous()
+             ]
+-            bboxes, confids = self.bbox_coder.decode(
++            bboxes, confidences = self.bbox_coder.decode(
+                 anchors.contiguous(), bbox_preds, max_shape=img_shape)
+             mlvl_bboxes.append(bboxes)
+             mlvl_scores.append(scores)
+-            mlvl_confids.append(confids)
++            mlvl_confids.append(confidences)
+         mlvl_bboxes = torch.cat(mlvl_bboxes)
+         if rescale:
+             mlvl_bboxes /= mlvl_bboxes.new_tensor(scale_factor)",do we also need to change `mlvl_confid` -> `mlvl_confidences`>
+1043,"@@ -125,7 +125,8 @@ type Config struct {
+ 	MetadataAddr string `config:""hostname;127.0.0.1;die-on-fail""`
+ 	MetadataPort int    `config:""int(0,65535);8775;die-on-fail""`
+
+-	InterfacePrefix string `config:""iface-list;cali;non-zero,die-on-fail""`
++	InterfacePrefix  string `config:""iface-list;cali;non-zero,die-on-fail""`
++	InterfaceExclude string `config:""iface-list;kube-ipvs0""`
+
+ 	ChainInsertMode             string `config:""oneof(insert,append);insert;non-zero,die-on-fail""`
+ 	DefaultEndpointToHostAction string `config:""oneof(DROP,RETURN,ACCEPT);DROP;non-zero,die-on-fail""`","I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?"
+1044,"@@ -180,7 +180,7 @@ def transform_path(path):
+     path = utils.expand_windows_drive(path)
+     # Drive dependent working directories are not supported, e.g.
+     # E:filename is invalid
+-    if re.match(r'[A-Z]:[^\\]', path, re.IGNORECASE):
++    if re.fullmatch(r'[A-Z]:[^\\]', path, re.IGNORECASE):
+         return None
+     # Paths like COM1, ...
+     # See https://github.com/qutebrowser/qutebrowser/issues/82","This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`."
+1045,"@@ -108,6 +108,14 @@ func determineResourceHealth(key ResourceKey, obj *unstructured.Unstructured) (s
+ 		return determineClusterRoleHealth(obj)
+ 	case KindClusterRoleBinding:
+ 		return determineClusterRoleBindingHealth(obj)
++	case KindVirtualService:
++		return determineVirtualService(obj)
++	case KindDestinationRule:
++		return determineDestinationRule(obj)
++	case KindGateway:
++		return determineGateway(obj)
++	case KindServiceEntry:
++		return determineServiceEntry(obj)
+ 	default:
+ 		desc = ""Unimplemented or unknown resource""
+ 		return","Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point."
+1046,"@@ -40,7 +40,7 @@ import (
+ // themselves.
+ func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter, mcMetrics Collector) {
+ 	selector := simple.NewWithInexpensiveDistribution()
+-	proc := processor.New(selector, exportmetric.StatelessExportKindSelector())
++	proc := processor.NewFactory(selector, exportmetric.StatelessExportKindSelector())
+ 	cont := controller.New(proc, controller.WithExporter(exp))
+ 	require.NoError(t, cont.Start(ctx))
+ ",Does codecov not run this test? Not sure how else it would not be covered.
+1047,"@@ -30,8 +30,9 @@ func main() {
+
+ // rootCmd represents the base command when called without any subcommands
+ var rootCmd = &cobra.Command{
+-	Use:  ""multisend [command]"",
+-	Args: cobra.ExactArgs(1),
++	Use:   ""multisend 'JSON_DATA'"",
++	Short: ""multisend bytecode generator"",
++	Args:  cobra.ExactArgs(1),
+ 	RunE: func(cmd *cobra.Command, args []string) error {
+ 		output, err := multiSend(args)
+ 		if err == nil {",can we add some sample of JSON_DATA format in the usage?
+1048,"@@ -25,13 +25,13 @@ namespace Datadog.Trace.Logging
+             _logProvider = logProvider;
+         }
+
+-        public void Initialize(IScopeManager scopeManager, string defaultServiceName, string version, string env)
++        public void Initialize(string defaultServiceName, string version, string env)
+         {
+             _versionProperty = version;
+             _environmentProperty = env;
+             _serviceProperty = defaultServiceName;
+-            _traceIdProperty = CreateTracerProperty(scopeManager, t => t.Active?.Span.TraceId.ToString());
+-            _spanIdProperty = CreateTracerProperty(scopeManager, t => t.Active?.Span.SpanId.ToString());
++            _traceIdProperty = CreateTracerProperty(() => Tracer.Instance.DistributedSpanContext?[HttpHeaderNames.TraceId]);
++            _spanIdProperty = CreateTracerProperty(() => Tracer.Instance.DistributedSpanContext?[HttpHeaderNames.ParentId]);
+         }
+
+         public IDisposable Register()",Using `Tracer.Instance` in here is problematic for testing   It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!
+1049,"@@ -22,7 +22,10 @@ import javax.annotation.Nullable;
+  */
+ @AutoValue
+ public abstract class InitFieldConfig {
++  public static final String projectIdVariableName = ""project_id"";
++
+   private static final String randomValueToken = ""$RANDOM"";
++  private static final String projectIdToken = ""$PROJECT_ID"";
+
+   public abstract String fieldPath();
+ ",make all of these `static final` fields UPPER_SNAKE - they are constants.
+1050,"@@ -3298,7 +3298,8 @@ int32 Mob::AffectMagicalDamage(int32 damage, uint16 spell_id, const bool iBuffTi
+
+ 	// If this is a DoT, use DoT Shielding...
+ 	if (iBuffTic) {
+-		damage -= (damage * itembonuses.DoTShielding / 100);
++		int total_dotshielding = itembonuses.DoTShielding + itembonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT];
++		damage -= (damage * total_dotshielding / 100);
+
+ 		if (spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT]) {
+ 			slot = spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_BUFFSLOT];","No possible chance for weird overflows here, right?"
+1051,"@@ -39,9 +39,13 @@ import org.apache.lucene.search.Weight;
+  * @lucene.experimental
+  */
+ public abstract class ValueSourceScorer extends Scorer {
++  // Fixed cost for a single iteration of the TwoPhaseIterator instance
++  private static final int DEF_COST = 5;
++
+   protected final FunctionValues values;
+   private final TwoPhaseIterator twoPhaseIterator;
+   private final DocIdSetIterator disi;
++  private float externallyMutableCost;
+
+   protected ValueSourceScorer(Weight weight, LeafReaderContext readerContext, FunctionValues values) {
+     super(weight);",Or we could use a Float object to more clearly show as user-settable via non-null?
+1052,"@@ -107,7 +107,7 @@ namespace Nethermind.Merge.Plugin.Handlers.V1
+
+             if (headUpdated && shouldUpdateHead)
+             {
+-                _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header);
++                _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header, finalizedHeader);
+                 _stateProvider.ResetStateTo(newHeadBlock.StateRoot!);
+                 if (_logger.IsInfo) _logger.Info($""Block {forkchoiceState.HeadBlockHash} was set as head"");
+             }",finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero
+1053,"@@ -48,6 +48,7 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
+
+ 		setupDataDiskStepName := fmt.Sprintf(""setup-data-disk-%v"", dataDiskIndex)
+ 		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v"", dataDiskIndex)
++		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%s-%v"", w.ID(), dataDiskIndex)
+
+ 		setupDataDiskStep := daisy.NewStep(setupDataDiskStepName, w, time.Hour)
+ 		setupDataDiskStep.CreateDisks = &daisy.CreateDisks{","Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them."
+1054,"@@ -8469,8 +8469,13 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+                 'For argument ""inplace"" expected type bool, received type {}.'
+                 .format(type(inplace).__name__))
+
+-        sdf = self._sdf.filter(expr)
+-        internal = self._internal.copy(sdf=sdf)
++        data_columns = [label[0] for label in self._internal.column_labels]
++        sdf = self._sdf.select(self._internal.index_scols
++                               + [scol.alias(col) for scol, col
++                                  in zip(self._internal.column_scols, data_columns)]) \
++            .filter(expr)
++        internal = self._internal.copy(sdf=sdf,
++                                       column_scols=[scol_for(sdf, col) for col in data_columns])
+
+         if inplace:
+             self._internal = internal","If we support multi-index column later, we need to rename to fit the pandas' requirement."
+1055,"@@ -0,0 +1,11 @@
++package aws
++
++// JSONValue is a representation of a grab bag type that will be marshaled
++// into a json string. This type can be used just like any other map.
++//
++//	Example:
++//	values := JSONValue{
++//		""Foo"": ""Bar"",
++//	}
++//	values[""Baz""] = ""Qux""
++type JSONValue map[string]interface{}","I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it."
+1056,"@@ -724,6 +724,7 @@ void Container::internalAddThing(uint32_t, Thing* thing)
+
+ void Container::startDecaying()
+ {
++	Item::startDecaying();
+ 	for (Item* item : itemlist) {
+ 		item->startDecaying();
+ 	}",sorry for nitpicking but I would love a new line under this line
+1057,"@@ -21,5 +21,5 @@ package node
+ type OptionsTransactor struct {
+ 	TransactorEndpointAddress string
+ 	RegistryAddress           string
+-	AccountantID              string
++	ChannelImplementation     string
+ }","ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?"
+1058,"@@ -67,4 +67,11 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files referenced by given metadata location.
++   */
++  default RemoveFiles removeFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
++  }
+ }",Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with.
+1059,"@@ -31,7 +31,7 @@ public abstract class IntraFeedSortDialog {
+
+         int idxCurrentSort = -1;
+         for  (int i = 0; i < values.length; i++) {
+-            if (currentSortOrder == values[i]) {
++            if (currentSortOrder == values[i] || currentSortOrder == null) {
+                 idxCurrentSort = i;
+                 break;
+             }",Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?
+1060,"@@ -72,6 +72,8 @@ public class Notification {
+     public static final int OMNIPOD_POD_NOT_ATTACHED = 59;
+     public static final int CARBS_REQUIRED = 60;
+     public static final int IMPORTANCE_HIGH = 2;
++    public static final int OMNIPOD_POD_SUSPENDED = 61;
++    public static final int OMNIPOD_POD_ALERTS_UPDATED = 62;
+
+     public static final String CATEGORY_ALARM = ""alarm"";
+ ",Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?
+1061,"@@ -48,7 +48,7 @@ void prepareMolForDrawing(RWMol &mol, bool kekulize, bool addChiralHs,
+   if (kekulize) {
+     try {
+       MolOps::Kekulize(mol, false);  // kekulize, but keep the aromatic flags!
+-    } catch(const RDKit::AtomKekulizeException &e) {
++    } catch (const RDKit::AtomKekulizeException &e) {
+       std::cerr << e.what() << std::endl;
+     }
+   }",Should this be boost logged?
+1062,"@@ -57,9 +57,10 @@ def find_notifiers(notifier_name):
+ # pylint: enable=inconsistent-return-statements
+
+
+-def convert_to_timestamp(violations):
++def convert_to_timestamp(session, violations):
+     """"""Convert violation created_at_datetime to timestamp string.
+     Args:
++        session (object): session object to work on.
+         violations (sqlalchemy_object): List of violations as sqlalchemy
+             row/record object with created_at_datetime.
+     Returns:",What is the reason for doing expunge here? This method is purely for converting the timestamp.
+1063,"@@ -86,9 +86,15 @@ class TypeToSchema extends TypeUtil.SchemaVisitor<Schema> {
+     List<Schema.Field> fields = Lists.newArrayListWithExpectedSize(fieldSchemas.size());
+     for (int i = 0; i < structFields.size(); i += 1) {
+       Types.NestedField structField = structFields.get(i);
++      String origFieldName = structField.name();
++      boolean isValid = validAvroName(origFieldName);
++      String fieldName =  isValid ? origFieldName : sanitize(origFieldName);
+       Schema.Field field = new Schema.Field(
+-          structField.name(), fieldSchemas.get(i), null,
++          sanitize(fieldName), fieldSchemas.get(i), null,
+           structField.isOptional() ? JsonProperties.NULL_VALUE : null);
++      if (!isValid) {
++        field.addProp(AvroSchemaUtil.ORIGINAL_FIELD_NAME_PROP, origFieldName);
++      }
+       field.addProp(AvroSchemaUtil.FIELD_ID_PROP, structField.fieldId());
+       fields.add(field);
+     }",This calls sanitize twice if the name isn't valid.
+1064,"@@ -0,0 +1,13 @@
++class Proposal < ActiveRecord::Base
++  has_one :cart
++
++  validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
++  validates :status, presence: true, inclusion: {in: Approval::STATUSES}
++
++  after_initialize :set_default_flow
++
++
++  def set_default_flow
++    self.flow ||= 'parallel'
++  end
++end",Is there an equivalent that'd allow zero or one?
+1065,"@@ -234,6 +234,13 @@ func (m *taskExecutor) repeatWith() (err error) {
+ 			m.resetK8sClient(resource)
+ 		}
+
++		if rwExec.isTaskObjectNameRepeat() {
++			// if repetition is based on task object name itself, then the task's
++			// object name needs to be set
++			m.metaTaskExec.setObjectName(resource)
++			m.objectName = resource
++		}
++
+ 		// set the currently active repeat resource
+ 		util.SetNestedField(m.templateValues, resource, string(v1alpha1.ListItemsTLP), string(v1alpha1.CurrentRepeatResourceLITP))
+ ",Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties.
+1066,"@@ -47,7 +47,7 @@ func accountImport(args []string) string {
+ 	}
+ 	wallet := cfg.Wallet
+ 	fmt.Printf(""#%s: Enter your private key, which will not be exposed on the screen.\n"", name)
+-	privateKeyBytes, err := terminal.ReadPassword(syscall.Stdin)
++	privateKeyBytes, err := terminal.ReadPassword(int(syscall.Stdin))
+ 	if err != nil {
+ 		log.L().Error(""fail to get private key"", zap.Error(err))
+ 		return err.Error()",unnecessary conversion (from `unconvert`)
+1067,"@@ -30,7 +30,6 @@ int main (int argc, char *argv[])
+     int universe_size;
+     char *kvsname;
+     char *val;
+-    char pmi_fd[16];
+     char pmi_rank[16];
+     char pmi_size[16];
+     int result;",typo in commit message `openening`
+1068,"@@ -10,7 +10,10 @@
+
+ #include <mpi.h>
+
+-#include <adios2.h>
++#define ADIOS_HAVE_PHDF5 // so hdf5 related items are loaded in ADIOS_CPP.h
++//#include ""ADIOS_CPP.h""
++#include ""adios2.h""
++#include ""adios2/engine/hdf5/HDF5ReaderP.h""
+
+ int main(int argc, char *argv[])
+ {",User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include <adios2.h>`
+1069,"@@ -20,7 +20,8 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
+
+     def test_buckets_are_global_to_every_users(self):
+         self.app.patch_json(self.record_url,
+-                            {'permissions': {'read': [Authenticated]}},
++                            {'data': {},
++                             'permissions': {'read': [Authenticated]}},
+                             headers=self.headers)
+         self.app.get(self.record_url, headers=get_user_headers('alice'))
+ ",nit: I guess we can omit this (unless you had a reason to specify it)
+1070,"@@ -74,6 +74,11 @@ func (c *client) isSolicitedLeafNode() bool {
+ 	return c.kind == LEAF && c.leaf.remote != nil
+ }
+
++// Returns true if this is a solicited leafnode and is not configured to be treated as a hub.
++func (c *client) isSpokeLeafNode() bool {
++	return c.kind == LEAF && c.leaf.remote != nil && !c.leaf.remote.Hub
++}
++
+ func (c *client) isUnsolicitedLeafNode() bool {
+ 	return c.kind == LEAF && c.leaf.remote == nil
+ }",Why is Hub public?
+1071,"@@ -114,7 +114,6 @@ func (agent *ecsAgent) capabilities() ([]*ecs.Attribute, error) {
+ 	}
+
+ 	capabilities = agent.appendTaskENICapabilities(capabilities)
+-	capabilities = agent.appendENITrunkingCapabilities(capabilities)
+
+ 	capabilities = agent.appendDockerDependentCapabilities(capabilities, supportedVersions)
+ ",why is this deleted?
+1072,"@@ -1,5 +1,6 @@
+ <div class=""<%= trail.unstarted? ? ""unstarted"" : ""started"" %>"">
+   <section class=""trail <%= topic_class(trail.topic) %>"">
++    <p class=""prerequisite"">Hey, before you start this...Have you done the <a href="""">Intro to Rails</a> tutorial?</p>
+     <header>
+       <span class=""topic-label""><%= trail.topic.name %></span>
+       <h1><%= link_to trail.name, trail %></h1>",Maybe move that into a partial
+1073,"@@ -158,10 +158,13 @@ func TestBlockDAO(t *testing.T) {
+ 		require := require.New(t)
+
+ 		ctx := context.Background()
+-		dao := NewBlockDAO(kvstore, indexer, false, config.Default.DB)
++		testDBFile, _ := ioutil.TempFile(os.TempDir(), ""db"")
++		cfg := config.Default.DB
++		cfg.DbPath = testDBFile.Name()
++		dao := NewBlockDAO(kvstore, indexer, false, cfg)
+ 		require.NoError(dao.Start(ctx))
+ 		defer func() {
+-			require.NoError(dao.Stop(ctx))
++			dao.Stop(ctx)
+ 		}()
+
+ 		// receipts for the 3 blocks",Error return value of `dao.Stop` is not checked (from `errcheck`)
+1074,"@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
+ 	if docrootRelPath != """" {
+ 		app.Docroot = docrootRelPath
+ 		if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
+-			util.Failed(""The docroot provided (%v) does not exist"", docrootRelPath)
++			output.UserOut.Warnf(""Warning: the provided docroot at %s does not currently exist."", docrootRelPath)
+ 		}
+ 	} else if !cmd.Flags().Changed(""docroot"") {
+ 		app.Docroot = ddevapp.DiscoverDefaultDocroot(app)",util.Warning()? Easier to say.
+1075,"@@ -38,6 +38,14 @@ func Trie(tx ethdb.Tx, slowChecks bool, quit <-chan struct{}) {
+ 			if errc != nil {
+ 				panic(errc)
+ 			}
++			select {
++			default:
++			case <-quit:
++				return
++			case <-logEvery.C:
++				log.Info(""trie account integrity"", ""key"", fmt.Sprintf(""%x"", k))
++			}
++
+ 			hasState, hasBranch, hasHash, hashes, _ := trie.UnmarshalTrieNode(v)
+ 			AssertSubset(k, hasBranch, hasState)
+ 			AssertSubset(k, hasHash, hasState)",this default is kinda superfluous (although i see it was already there before PR )
+1076,"@@ -53,11 +53,7 @@ public class NodeList<N extends Node> implements List<N>, Iterable<N>, HasParent
+     private List<AstObserver> observers = new ArrayList<>();
+
+     public NodeList() {
+-        this((Node) null);
+-    }
+-
+-    public NodeList(Node parent) {
+-        setParentNode(parent);
++        parentNode = null;
+     }
+
+     public NodeList(Collection<N> n) {",How is this related?
+1077,"@@ -3,6 +3,7 @@ class SubscriptionsController < ApplicationController
+
+   def new
+     @plans = IndividualPlan.featured.active.ordered
++    @team_plans = TeamPlan.featured.ordered
+   end
+
+   def edit","I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions."
+1078,"@@ -1,8 +1,8 @@
+ shared_examples_for 'disables OpenSSH roaming' do
+   let(:disable_ssh_roaming) { %(echo -e ""Host *\n  UseRoaming no\n"" | cat - $HOME/.ssh/config > $HOME/.ssh/config.tmp && mv $HOME/.ssh/config.tmp $HOME/.ssh/config) }
+-  let(:sexp) { sexp_find(subject, [:if, ""$(sw_vers -productVersion | cut -d . -f 2) -lt 12""]) }
++  let(:sexp) { sexp_find(subject, [:if, %(""$(sw_vers -productVersion 2>/dev/null | cut -d . -f 2)"" -lt 12)]) }
+
+   it 'disables OpenSSH roaming' do
+-    sexp.should include_sexp [:cmd, disable_ssh_roaming]
++    expect(sexp).to include_sexp [:cmd, disable_ssh_roaming]
+   end
+ end","The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style."
+1079,"@@ -172,7 +172,7 @@ bool ReaderProxy::requested_changes_set(std::vector<SequenceNumber_t>& seqNumSet
+     {
+         auto chit = m_changesForReader.find(ChangeForReader_t(*sit));
+
+-        if(chit != m_changesForReader.end() && chit->isValid())
++        if(chit != m_changesForReader.end())
+         {
+             ChangeForReader_t newch(*chit);
+             newch.setStatus(REQUESTED);",Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?
+1080,"@@ -44,9 +44,12 @@ import {
+ 	isDataZeroForReporting,
+ } from '../util';
+
+-const { __ } = wp.i18n;
+-const { Component, Fragment } = wp.element;
+-const { isEmpty } = lodash;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { Component, Fragment } from '@wordpress/element';
++import { isEmpty } from 'lodash';
+
+ class AnalyticsDashboardWidgetTopLevel extends Component {
+ 	constructor( props ) {",`lodash` shouldn't be grouped under WordPress dependencies
+1081,"@@ -69,7 +69,7 @@ class GenericDataFile
+   /**
+    * Used by Avro reflection to instantiate this class when reading manifest files.
+    */
+-  public GenericDataFile(org.apache.avro.Schema avroSchema) {
++  GenericDataFile(org.apache.avro.Schema avroSchema) {
+     this.avroSchema = avroSchema;
+
+     Types.StructType schema = AvroSchemaUtil.convert(avroSchema).asNestedType().asStructType();",This needs to be public so that Avro can call it.
+1082,"@@ -18,18 +18,7 @@
+ /**
+  * External dependencies
+  */
+-import data, { TYPE_CORE } from 'GoogleComponents/data';
+-import SvgIcon from 'GoogleUtil/svg-icon';
+-
+-export * from './storage';
+-
+-const { apiFetch } = wp;
+-const {
+-	addFilter,
+-	applyFilters,
+-} = wp.hooks;
+-
+-const {
++import {
+ 	map,
+ 	isNull,
+ 	isUndefined,",`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies.
+1083,"@@ -245,6 +245,13 @@ class DataFrame(_Frame):
+             else:
+                 super(DataFrame, self).__init__(_InternalFrame(
+                     data, data_columns=index.data_columns, index_map=index.index_map))
++        elif isinstance(data, ks.Series):
++            assert index is None
++            assert columns is None
++            assert dtype is None
++            assert not copy
++            data = data.to_dataframe()
++            super(DataFrame, self).__init__(data._internal)
+         else:
+             if isinstance(data, pd.DataFrame):
+                 assert index is None",I think he meant the docstring in this constructor. yea we should fix
+1084,"@@ -150,7 +150,18 @@ public abstract class BinaryDictionary implements Dictionary {
+         throw new IllegalStateException(""unknown resource scheme "" + resourceScheme);
+     }
+   }
+-
++
++  public static InputStream getResource(ResourceScheme scheme, String path) throws IOException {
++    switch(scheme) {
++      case CLASSPATH:
++        return getClassResource(path);
++      case FILE:
++        return Files.newInputStream(Paths.get(path));
++      default:
++        throw new IllegalStateException(""unknown resource scheme "" + scheme);
++    }
++  }
++
+   // util, reused by ConnectionCosts and CharacterDefinition
+   public static InputStream getClassResource(Class<?> clazz, String suffix) throws IOException {
+     final InputStream is = clazz.getResourceAsStream(clazz.getSimpleName() + suffix);","so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?"
+1085,"@@ -525,8 +525,11 @@ namespace SkylineNightly
+
+         private void DownloadSkylineTester(string skylineTesterZip, RunMode mode)
+         {
+-            // Make sure we can negotiate with HTTPS servers that demand TLS 1.2 (default in dotNet 4.6, but has to be turned on in 4.5)
+-            ServicePointManager.SecurityProtocol |= (SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12);
++            // The current recommendation from MSFT for future-proofing HTTPS https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls
++            // is don't specify TLS levels at all, let the OS decide. But we worry that this will mess up Win7 and Win8 installs, so we continue to specify explicitly
++            var Tls13 = (SecurityProtocolType)12288; // From decompiled SecurityProtocolType - compiler has no definition for some reason
++            ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12 | Tls13;
++
+             using (var client = new WebClient())
+             {
+                 client.Credentials = new NetworkCredential(TEAM_CITY_USER_NAME, TEAM_CITY_USER_PASSWORD);",It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288
+1086,"@@ -70,16 +70,6 @@ export default [
+         updated_by: 1,
+         value: ''
+     },
+-    {
+-        id: 12,
+-        key: 'labs',
+-        value: '{""subscribers"":true}',
+-        type: 'blog',
+-        created_at: '2015-01-12T18:29:01.000Z',
+-        created_by: 1,
+-        updated_at: '2015-10-27T17:39:58.288Z',
+-        updated_by: 1
+-    },
+     {
+         id: 13,
+         created_at: '2015-09-11T09:44:30.810Z',","Similar to the above, put this setting back but keep the value as `'{}'`"
+1087,"@@ -130,7 +130,7 @@ def refresh_listen_count_aggregate():
+            Assuming today is 2022-01-01 and this function is called for year_offset 1 and
+            year_count 1 then all of 2021 will be refreshed.
+     """"""
+-
++    logger.info(""Starting to refresh continuous aggregates:"")
+     timescale.init_db_connection(config.SQLALCHEMY_TIMESCALE_URI)
+
+     end_ts = int(datetime.now().timestamp()) - SECONDS_IN_A_YEAR","As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up"
+1088,"@@ -33,12 +33,4 @@
+ <div id=""about"" class=""card"">
+   <h2 class='card-header collapsed collapse-toggle' data-toggle=""collapse"" data-target=""#about-content""><a href=""/rails/info/properties"">About your application&rsquo;s environment</a></h2>
+   <div id=""about-content"" class=""card-body collapse""></div>
+-</div>
+-
+-<script>
+-  Blacklight.onLoad(function() {
+-    $('#about .card-header').one('click', function() {
+-      $($(this).data('target')).load($(this).find('a').attr('href'));
+-    });
+-  });
+-</script>
++</div>",I'm curious about why this needed to be removed.
+1089,"@@ -17,10 +17,10 @@ from scapy.config import conf
+ from scapy.base_classes import BasePacket,BasePacketList
+ from scapy.utils import do_graph,hexdump,make_table,make_lined_table,make_tex_table,get_temp_file
+
+-from scapy.consts import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
++from scapy.extlib import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
+ from functools import reduce
+ import scapy.modules.six as six
+-from scapy.modules.six.moves import filter, range, zip
++from scapy.modules.six.moves import range, zip
+
+
+ #############",why did you remove `zip`? It is used!
+1090,"@@ -90,7 +90,7 @@ func (bs *BrokerStatus) MarkTopicUnknown(reason, format string, args ...interfac
+ 	brokerCondSet.Manage(bs).MarkUnknown(BrokerConditionTopic, reason, format, args...)
+ }
+
+-func (bs *BrokerStatus) MarkTopicReady() {
++func (bs *BrokerStatus) MarkTopicReady(_ string) {
+ 	brokerCondSet.Manage(bs).MarkTrue(BrokerConditionTopic)
+ }
+ ",Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?
+1091,"@@ -1,4 +1,4 @@
+-<?php namespace TestVendor\Goto;
++<?php namespace TestVendor\_Goto;
+
+ use System\Classes\PluginBase;
+ ","before php8 ""goto"" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4"
+1092,"@@ -85,6 +85,7 @@ func (t *Transport) NewInbound(listener net.Listener, options ...InboundOption)
+ }
+
+ // NewSingleOutbound returns a new Outbound for the given adrress.
++// Note: This does not support TLS. See TLS example in doc.go.
+ func (t *Transport) NewSingleOutbound(address string, options ...OutboundOption) *Outbound {
+ 	return newSingleOutbound(t, address, options...)
+ }","nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen."
+1093,"@@ -226,11 +226,17 @@ func (o *Outbound) CallOneway(ctx context.Context, treq *transport.Request) (tra
+ 		return nil, yarpcerrors.InvalidArgumentErrorf(""request for http oneway outbound was nil"")
+ 	}
+
+-	_, err := o.call(ctx, treq)
++	// res is used to close the response body to avoid memory/connection leak
++	// even when the response body is empty
++	res, err := o.call(ctx, treq)
+ 	if err != nil {
+ 		return nil, err
+ 	}
+
++	if err = res.Body.Close(); err != nil {
++		return nil, yarpcerrors.Newf(yarpcerrors.CodeInternal, err.Error())
++	}
++
+ 	return time.Now(), nil
+ }
+ ",I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors
+1094,"@@ -8,7 +8,7 @@ import java.util.regex.Pattern;
+
+ public class EmailAddressValidator implements Validator {
+     private static final Pattern EMAIL_ADDRESS_PATTERN = Pattern.compile(
+-          ""[a-zA-Z0-9\\+\\.\\_\\%\\-\\+]{1,256}"" +
++          ""[a-zA-Z0-9\\+\\.\\_\\%\\-]{1,256}"" +
+           ""\\@"" +
+           ""[a-zA-Z0-9][a-zA-Z0-9\\-]{0,64}"" +
+           ""("" +",We're already matching +. Not sure why this changed.
+1095,"@@ -34,6 +34,14 @@ class Configuration implements ConfigurationInterface
+             ->children()
+                 ->scalarNode('db_driver')->isRequired()->end()
+                 ->scalarNode('default_context')->isRequired()->end()
++                ->scalarNode('category_manager')
++                    ->info('if sonata-project/classification exists will set ""sonata.classification.manager.category"" | if you want to define your own category manager you need to implement \Sonata\MediaBundle\Model\CategoryManagerInterface and set the service name here')
++                    ->defaultValue(null)
++                ->end()
++                ->scalarNode('force_disable_category')
++                    ->info('true IF you really want to disable the relation with category')
++                    ->defaultValue(false)
++                ->end()
+             ->end()
+         ;
+ ","Please add line breaks, so the line doesn't exceed 80 chars."
+1096,"@@ -29,11 +29,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""AspNetCoreInstrumentation""/> class.
+         /// </summary>
+-        /// <param name=""activitySource"">ActivitySource adapter instance.</param>
+         /// <param name=""options"">Configuration options for ASP.NET Core instrumentation.</param>
+-        public AspNetCoreInstrumentation(ActivitySourceAdapter activitySource, AspNetCoreInstrumentationOptions options)
++        public AspNetCoreInstrumentation(AspNetCoreInstrumentationOptions options)
+         {
+-            this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(new HttpInListener(""Microsoft.AspNetCore"", options, activitySource), null);
++            this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(new HttpInListener(""Microsoft.AspNetCore"", options), null);
+             this.diagnosticSourceSubscriber.Subscribe();
+         }
+ ",I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!
+1097,"@@ -243,7 +243,7 @@ _ostree_delta_compute_similar_objects (OstreeRepo                 *repo,
+ {
+   gboolean ret = FALSE;
+   g_autoptr(GHashTable) ret_modified_regfile_content =
+-    g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)g_ptr_array_unref);
++    g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);
+   g_autoptr(GPtrArray) from_sizes = NULL;
+   g_autoptr(GPtrArray) to_sizes = NULL;
+   guint i, j;",I'm not sure how this one didn't segfault before.
+1098,"@@ -27,6 +27,13 @@ import (
+ )
+
+ var _ = Describe(""Endpoints"", func() {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	for _, trueOrFalse := range []bool{true, false} {
+ 		kubeIPVSEnabled := trueOrFalse
+ 		var rrConfigNormalMangleReturn = Config{",Same points as in other test file.
+1099,"@@ -16,14 +16,7 @@
+  */
+ package org.apache.lucene.analysis.hunspell;
+
+-import java.io.BufferedInputStream;
+-import java.io.BufferedOutputStream;
+-import java.io.BufferedReader;
+-import java.io.IOException;
+-import java.io.InputStream;
+-import java.io.InputStreamReader;
+-import java.io.LineNumberReader;
+-import java.io.OutputStream;
++import java.io.*;
+ import java.nio.charset.Charset;
+ import java.nio.charset.CharsetDecoder;
+ import java.nio.charset.CodingErrorAction;","Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question."
+1100,"@@ -4,7 +4,11 @@ describe TrailWithProgress do
+   it ""decorates its component"" do
+     user = double(""user"")
+     trail = build_stubbed(:trail)
+-    trail_with_progress = TrailWithProgress.new(trail, user: user)
++    trail_with_progress = TrailWithProgress.new(
++      trail,
++      user: user,
++      status_finder: double(StatusFinder),
++    )
+
+     expect(trail_with_progress).to be_a(SimpleDelegator)
+     expect(trail_with_progress.name).to eq(trail.name)",Put a comma after the last parameter of a multiline method call.
+1101,"@@ -183,6 +183,11 @@ fpga_result errors_filter(fpga_properties *filter, int argc, char *argv[])
+ 							  FPGA_ACCELERATOR);
+ 			ON_FPGAINFO_ERR_GOTO(
+ 				res, out, ""setting type to FPGA_ACCELERATOR"");
++
++			res = fpgaPropertiesSetInterface(*filter,
++				FPGA_IFC_DFL);
++			ON_FPGAINFO_ERR_GOTO(
++				res, out, ""setting type to FPGA_IFC_DFL"");
+ 			break;
+ 		case VERB_ALL:
+ 		default:",Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday.
+1102,"@@ -18,6 +18,13 @@ var _ specsruntime.Syscalls = (*syscalls)(nil)
+
+ // VerifySignature implements Syscalls.
+ func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) error {
++	// Dragons: this lets all id addresses off the hook -- we need to remove this
++	// once market actor code actually checks proposal signature.  Depending on how
++	// that works we may want to do id address to pubkey address lookup here or we
++	// might defer that to VM
++	if signer.Protocol() == address.ID {
++		return nil
++	}
+ 	return crypto.ValidateSignature(plaintext, signer, signature)
+ }
+ ","Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here."
+1103,"@@ -5,7 +5,7 @@
+ Purpose
+
+ Shows how to run an EMRFS command as a job step on an Amazon EMR cluster. This
+-can be used to automate ERMFS commands and is an alternative to connecting through
++can be used to automate EMRFS commands and is an alternative to connecting through
+ SSH to run the commands manually.
+ """"""
+ ",electronic medical record file system (EMRFS)
+1104,"@@ -438,6 +438,7 @@ var directives = []string{
+ 	""mailout"",   // github.com/SchumacherFM/mailout
+ 	""awslambda"", // github.com/coopernurse/caddy-awslambda
+ 	""filter"",    // github.com/echocat/caddy-filter
++	""maxrequestbody"",
+ }
+
+ const (","Put this higher in the list, like after ""bind"", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts."
+1105,"@@ -37,13 +37,11 @@ import (
+ )
+
+ var (
+-	ErrInvalidOrderType = status.Errorf(codes.InvalidArgument, ""invalid order type"")
+-	ErrAskNotFound      = status.Errorf(codes.NotFound, ""ask not found"")
+-	ErrDeviceNotFound   = status.Errorf(codes.NotFound, ""device not found"")
+-	ErrMinerNotFound    = status.Errorf(codes.NotFound, ""miner not found"")
+-	errDealNotFound     = status.Errorf(codes.NotFound, ""deal not found"")
+-	errTaskNotFound     = status.Errorf(codes.NotFound, ""task not found"")
+-	errImageForbidden   = status.Errorf(codes.PermissionDenied, ""specified image is forbidden to run"")
++	ErrDeviceNotFound = status.Errorf(codes.NotFound, ""device not found"")
++	ErrMinerNotFound  = status.Errorf(codes.NotFound, ""miner not found"")
++	errDealNotFound   = status.Errorf(codes.NotFound, ""deal not found"")
++	errTaskNotFound   = status.Errorf(codes.NotFound, ""task not found"")
++	errImageForbidden = status.Errorf(codes.PermissionDenied, ""specified image is forbidden to run"")
+
+ 	hubAPIPrefix = ""/sonm.Hub/""
+ ",oh come on :(
+1106,"@@ -76,7 +76,7 @@ public class ProtocolHandshake {
+
+         if (result.isPresent()) {
+           Result toReturn = result.get();
+-          LOG.info(String.format(""Detected dialect: %s"", toReturn.dialect));
++          LOG.finest(String.format(""Detected dialect: %s"", toReturn.dialect));
+           return toReturn;
+         }
+       }",This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users.
+1107,"@@ -30,6 +30,7 @@ def get_gcloud_info():
+         str: GCP project id
+         str: GCP Authenticated user
+         bool: Whether or not the installer is running in cloudshell
++        bool: Whether or not authenticated user is a service account
+     """"""
+     return_code, out, err = utils.run_command(
+         ['gcloud', 'info', '--format=json'])",Remove as this is not needed anymore.
+1108,"@@ -10,3 +10,11 @@ class Interface:
+ class DoNothing: pass
+
+ class DoNothing2: pass
++
++class DoSomething:
++    def __init__(self, a_string: str, optional_int: int = None):
++        self.my_string = a_string
++        self.my_int = optional_int
++
++    def do_it(self, new_int: int) -> int:
++        return self.my_int + new_int",This new class is for checking that #4551 works correctly with PlantUML output too.
+1109,"@@ -168,6 +168,11 @@ func (c *controller) buildCertificates(ctx context.Context, ing *networkingv1bet
+ 					Kind:  issuerKind,
+ 					Group: issuerGroup,
+ 				},
++				Usages: []cmapi.KeyUsage{
++					cmapi.UsageDigitalSignature,
++					cmapi.UsageKeyEncipherment,
++					cmapi.UsageServerAuth, // default for web facing certificates as per https://support.apple.com/en-us/HT210176
++				},
+ 			},
+ 		}
+ ",Will this cause all certificates to be re-issued?
+1110,"@@ -215,6 +215,10 @@ fpga_result  enum_max10_metrics_info(struct _fpga_handle *_handle,
+ 		}
+ 		metric_name[strlen(metric_name)-1] = '\0';
+
++		if (tmp) {
++			free(tmp);
++		}
++
+ 		// Metrics typw
+ 		result = read_sensor_sysfs_file(pglob.gl_pathv[i], SENSOR_SYSFS_TYPE, (void **)&tmp, &tot_bytes);
+ 		if (FPGA_OK != result) {",I think tmp is also leaked at the end of this loop if no error cases are encountered.
+1111,"@@ -165,13 +165,14 @@ class BuildAvroProjection extends AvroCustomOrderSchemaVisitor<Schema, Schema.Fi
+       try {
+         Schema keyValueSchema = array.getElementType();
+         Schema.Field keyField = keyValueSchema.getFields().get(0);
++        Schema.Field keyProjection = element.get().getField(""key"");
+         Schema.Field valueField = keyValueSchema.getFields().get(1);
+         Schema.Field valueProjection = element.get().getField(""value"");
+
+         // element was changed, create a new array
+-        if (valueProjection.schema() != valueField.schema()) {
++        if (keyProjection.schema() != keyField.schema() || valueProjection.schema() != valueField.schema()) {
+           return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(),
+-              AvroSchemaUtil.getFieldId(keyField), keyField.name(), keyField.schema(),
++              AvroSchemaUtil.getFieldId(keyField), keyField.name(), keyProjection.schema(),
+               AvroSchemaUtil.getFieldId(valueField), valueField.name(), valueProjection.schema());
+         } else if (!(array.getLogicalType() instanceof LogicalMap)) {
+           return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(),","The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data."
+1112,"@@ -26,14 +26,13 @@ void UseExecutor::execute() {
+
+     auto spaceName = *sentence_->space();
+     // Check from the cache, if space not exists, schemas also not exist
+-    auto status = ectx()->schemaManager()->checkSpaceExist(spaceName);
+-    if (!status.ok()) {
++    auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);
++    if (spaceId < 0) {
+         DCHECK(onError_);
+         onError_(Status::Error(""Space not found for `%s'"", spaceName.c_str()));
+         return;
+     }
+
+-    auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);
+     session->setSpace(*sentence_->space(), spaceId);
+     FLOG_INFO(""Graph space switched to `%s', space id: %d"", sentence_->space()->c_str(), spaceId);
+ ","Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used."
+1113,"@@ -17,11 +17,15 @@ import (
+ 	""context""
+ 	""encoding/json""
+ 	""fmt""
++	""io""
+ 	""os""
+ 	""strings""
++	""time""
+
+ 	""github.com/shirou/gopsutil/process""
+
++	jrpc ""github.com/ethereum/go-ethereum/rpc""
++
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/bpm""
+ 	pb ""github.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon/pb""",Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird.
+1114,"@@ -68,12 +68,13 @@ class ControlField(Field):
+ 			or (role in (controlTypes.ROLE_TABLE, controlTypes.ROLE_TABLECELL, controlTypes.ROLE_TABLEROWHEADER, controlTypes.ROLE_TABLECOLUMNHEADER) and not formatConfig[""reportTables""])
+ 			or (role in (controlTypes.ROLE_LIST, controlTypes.ROLE_LISTITEM) and controlTypes.STATE_READONLY in states and not formatConfig[""reportLists""])
+ 			or (role in (controlTypes.ROLE_FRAME, controlTypes.ROLE_INTERNALFRAME) and not formatConfig[""reportFrames""])
++			or (role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT) and not formatConfig[""reportRevisions""])
+ 		):
+ 			# This is just layout as far as the user is concerned.
+ 			return self.PRESCAT_LAYOUT
+
+ 		if (
+-			role in (controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)
++			role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT,controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)
+ 			or (role == controlTypes.ROLE_EDITABLETEXT and controlTypes.STATE_MULTILINE not in states and (controlTypes.STATE_READONLY not in states or controlTypes.STATE_FOCUSABLE in states))
+ 			or (role == controlTypes.ROLE_LIST and controlTypes.STATE_READONLY not in states)
+ 		):",Could you split this into multiple lines?
+1115,"@@ -19,14 +19,11 @@
+
+ package org.apache.iceberg;
+
+-import java.util.Collection;
+ import java.util.List;
+ import java.util.Set;
+-import org.apache.iceberg.expressions.Expression;
+ import org.apache.iceberg.io.CloseableIterable;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.relocated.com.google.common.collect.FluentIterable;
+-import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+ import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+ import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+ import org.apache.iceberg.relocated.com.google.common.collect.Sets;",Doesn't the snapshot ID start off as null? It seems like we don't need to set it here.
+1116,"@@ -93,7 +93,7 @@ func (t *V4Trie) Get(cidr V4CIDR) interface{} {
+ }
+
+ func (t *V4Trie) LookupPath(buffer []V4TrieEntry, cidr V4CIDR) []V4TrieEntry {
+-	return t.root.lookupPath(buffer, cidr)
++	return t.root.lookupPath(buffer[:0], cidr)
+ }
+
+ // LPM does a longest prefix match on the trie","I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?"
+1117,"@@ -173,7 +173,9 @@ func (c *Expected) validateMining(ctx context.Context,
+ 	parentWeight fbig.Int,
+ 	parentReceiptRoot cid.Cid) error {
+
+-	powerTable := NewPowerTableView(c.state.StateView(parentStateRoot))
++	stateView := c.state.StateView(parentStateRoot)
++	sigValidator := NewSignatureValidator(stateView)
++	powerTable := NewPowerTableView(stateView)
+
+ 	for i := 0; i < ts.Len(); i++ {
+ 		blk := ts.At(i)",nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors.
+1118,"@@ -169,6 +169,13 @@ func (c *CStorPoolController) cStorPoolAddEventHandler(cStorPoolGot *apis.CStorP
+ 					glog.Infof(""Pool %v is online"", string(pool.PoolPrefix)+string(cStorPoolGot.GetUID()))
+ 					c.recorder.Event(cStorPoolGot, corev1.EventTypeNormal, string(common.AlreadyPresent), string(common.MessageResourceAlreadyPresent))
+ 					common.SyncResources.IsImported = true
++					if GetHash(cStorPoolGot) == """" {
++						hash, err := common.CalculateHash(cStorPoolGot.Spec.Disks.DiskList)
++						if err != nil {
++							glog.Errorf(""Failed to update openebs.io/csp-disk-hash value: %v"", err)
++						}
++						UpdateHash(cStorPoolGot, hash)
++					}
+ 					return string(apis.CStorPoolStatusOnline), nil
+ 				}
+ 				glog.Infof(""Pool %v already present"", string(pool.PoolPrefix)+string(cStorPoolGot.GetUID()))",need to fix the error message here
+1119,"@@ -17,7 +17,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+         internal const string DEFAULT_POLICY_NAME = ""default"";
+
+         public PropertyBagDictionary() : base() { }
+-
++        //CA1026 not fixed
+         public PropertyBagDictionary(
+             PropertyBagDictionary initializer = null,
+             IEqualityComparer<string> comparer = null)",Unsure of how to handle this one.
+1120,"@@ -1268,7 +1268,9 @@ public class FlowRunner extends EventHandler<Event> implements Runnable {
+
+   public void kill() {
+     synchronized (this.mainSyncObj) {
+-      if (isKilled()) {
++      if (isKilled() || this.flowFinished) {
++        this.logger.info(
++            ""Dropping Kill action as execution "" + this.execId + "" is already finished."");
+         return;
+       }
+       this.logger.info(""Kill has been called on execution "" + this.execId);","Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled."
+1121,"@@ -0,0 +1,11 @@
++package common
++
++// DefaultRetrySettings indicates what the ""default"" retry settings
++// are if it is not specified on an Activity or for any unset fields
++// if a policy is explicitly set on a Child Workflow
++type DefaultRetrySettings struct {
++	InitialIntervalInSeconds   int32
++	MaximumIntervalCoefficient float64
++	BackoffCoefficient         float64
++	MaximumAttempts            int32
++}","replace ""Child Workflow"" with ""any workflow"""
+1122,"@@ -426,7 +426,9 @@ footer {
+ 								<span class=""name"">{{html .Name}}</span>
+ 							</a>
+ 						</td>
+-						{{- if .IsDir}}
++						{{- if .IsSymlink }}
++						<td data-order=""-1"">symbolic link</td>
++						{{- else if .IsDir}}
+ 						<td data-order=""-1"">&mdash;</td>
+ 						{{- else}}
+ 						<td data-order=""{{.Size}}"">{{.HumanSize}}</td>","Instead of showing the words ""symbolic link"" under the ""Size"" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?"
+1123,"@@ -47,9 +47,10 @@ class DateRange implements FilterEncoder, FacetBuilder
+      * Parses the given date range from a GET parameter and returns a Solr
+      * date range filter.
+      *
+-     * @param string $rangeFilter The range filter query string from the query URL
++     * @param string $dateRange
+      * @param array $configuration Facet configuration
+      * @return string Lucene query language filter to be used for querying Solr
++     * @internal param string $rangeFilter The range filter query string from the query URL
+      */
+     public function decodeFilter($dateRange, array $configuration = array())
+     {",Please add back the description of the parameter
+1124,"@@ -17,7 +17,7 @@ function GraphiteBrowser () {
+   var searchPanel = createSearchPanel();
+   var completerPanel = createCompleterPanel();
+   var treeRoot = treePanel.getRootNode();
+-
++
+   this.trees = {
+     graphite: treeRoot.findChild('id', 'GraphiteTree'),
+     mygraphs: treeRoot.findChild('id', 'MyGraphsTree'),",Superfluous space inserted.
+1125,"@@ -8,7 +8,9 @@
+  * @returns {Object}
+  */
+ dom.urlPropsFromAttribute = function urlPropsFromAttribute(node, attribute) {
+-	const value = node[attribute];
++	const value = !node.ownerSVGElement
++		? node[attribute]
++		: node.getAttribute(attribute);
+ 	if (!value) {
+ 		return undefined;
+ 	}","Didn't fix the problem. `href=""""` for SVG will still result in `undefined` getting returned by this function."
+1126,"@@ -69,13 +69,13 @@ BOOST_AUTO_TEST_CASE(test_route_same_coordinates_fixture)
+                                                    json::Object{{
+                                                        {""location"", location},
+                                                        {""bearing_before"", 0},
+-                                                       {""bearing_after"", 58},
++                                                       {""bearing_after"", 238},
+                                                        {""type"", ""depart""},
+                                                    }}},
+                                                   {""intersections"",
+                                                    json::Array{{json::Object{
+                                                        {{""location"", location},
+-                                                        {""bearings"", json::Array{{58}}},
++                                                        {""bearings"", json::Array{{238}}},
+                                                         {""entry"", json::Array{{json::True()}}},
+                                                         {""out"", 0}}}}}}}}},
+ ",This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?
+1127,"@@ -90,10 +90,10 @@ class AppModule(appModuleHandler.AppModule):
+ 			# Move the review cursor so others can't access its previous position.
+ 			self._oldReviewPos = api.getReviewPosition()
+ 			self._oldReviewObj = self._oldReviewPos.obj
+-			api.setNavigatorObject(eventHandler.lastQueuedFocusObject)
++			api.setNavigatorObject(eventHandler.lastQueuedFocusObject, isFocus=True)
+
+ 	def event_appModule_loseFocus(self):
+ 		if not config.conf[""reviewCursor""][""followFocus""]:
+-			api.setReviewPosition(self._oldReviewPos)
++			api.setReviewPosition(self._oldReviewPos, isCaret=False)
+ 			del self._oldReviewPos, self._oldReviewObj
+ 		inputCore.manager._captureFunc = None","As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject."
+1128,"@@ -38,7 +38,7 @@ module Selenium
+         port
+       end
+
+-      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
++      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL].freeze
+       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+       IGNORED_ERRORS.freeze
+ ",We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it.
+1129,"@@ -368,5 +368,9 @@ func consolidateAutomationPolicies(aps []*caddytls.AutomationPolicy) []*caddytls
+ 		return len(aps[i].Subjects) > len(aps[j].Subjects)
+ 	})
+
++	for i := 0; i < len(aps); i++ {
++		sort.Strings(aps[i].Subjects)
++	}
++
+ 	return aps
+ }",Why is this needed?
+1130,"@@ -215,6 +215,9 @@ func RegisterRoutes(m *macaron.Macaron) {
+ 		}, reqToken())
+
+ 		// Repositories
++		m.Get(""/users/:username/repos"", repo.ListUserRepos)
++		m.Get(""/orgs/:org/repos"", repo.ListOrgRepos)
++
+ 		m.Combo(""/user/repos"", reqToken()).Get(repo.ListMyRepos).
+ 			Post(bind(api.CreateRepoOption{}), repo.Create)
+ 		m.Post(""/org/:org/repos"", reqToken(), bind(api.CreateRepoOption{}), repo.CreateOrgRepo)",Why not put two other routes after this line (221)?
+1131,"@@ -25,9 +25,10 @@ ExecutionEngine::~ExecutionEngine() {
+
+ Status ExecutionEngine::init(std::shared_ptr<folly::IOThreadPoolExecutor> ioExecutor) {
+     auto addrs = network::NetworkUtils::toHosts(FLAGS_meta_server_addrs);
+-    if (!addrs.ok()) {
++    if (!addrs.ok() || addrs.value().empty()) {
+         return addrs.status();
+     }
++
+     metaClient_ = std::make_unique<meta::MetaClient>(ioExecutor, std::move(addrs.value()));
+     metaClient_->init();
+ ","If FLAGS_meta_server_addrs is not empty, in which case ""toHosts"" return empty array?"
+1132,"@@ -216,6 +216,8 @@ void ResetFactory()
+    */
+   Settings.I2C_clockSpeed = DEFAULT_I2C_CLOCK_SPEED;
+
++  Settings.JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES);
++
+ #ifdef PLUGIN_DESCR
+   strcpy_P(Settings.Name, PSTR(PLUGIN_DESCR));
+ #endif // ifdef PLUGIN_DESCR","There is a function to output a ""JSONBool"" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess."
+1133,"@@ -90,8 +90,9 @@ class SampledPlot:
+             sampled = data._sdf.sample(fraction=float(self.fraction))
+             return DataFrame(data._internal.copy(sdf=sampled)).to_pandas()
+         elif isinstance(data, Series):
++            scol = data._kdf._internal.data_scols[0]
+             sampled = data._kdf._sdf.sample(fraction=float(self.fraction))
+-            return DataFrame(data._kdf._internal.copy(sdf=sampled)).to_pandas()
++            return DataFrame(data._kdf._internal.copy(sdf=sampled, scol=scol)).to_pandas()
+         else:
+             ValueError(""Only DataFrame and Series are supported for plotting."")
+ ","oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick."
+1134,"@@ -1,6 +1,7 @@
+ <% administrator = Role.new(administrator: true, editor: true, commenter: true) %>
+ <% editor = Role.new(editor: true, commenter: true) %>
+ <% commenter = Role.new(commenter: true) %>
++<% administerable = @plan.administerable_by?(current_user) %>
+
+ <h2><%= _('Set plan visibility') %></h2>
+ <p class=""form-control-static""><%= _('Public or organisational visibility is intended for finished plans. You must answer at least %{percentage}%% of the questions to enable these options. Note: test plans are set to private visibility by default.') % { :percentage => Rails.application.config.default_plan_percentage_answered } %></p>",Thanks for moving this up with the rest of the variables. Much tidier :)
+1135,"@@ -38,6 +38,12 @@ import (
+ // DefaultAccountantFailureCount defines how many times we're allowed to fail to reach accountant in a row before announcing the failure.
+ const DefaultAccountantFailureCount uint64 = 3
+
++// DefaultPaymentInfo represents the default payment info for the alpha release
++var DefaultPaymentInfo = dto.PaymentPerTime{
++	Price:    money.NewMoney(0.001, money.CurrencyMyst),
++	Duration: 1 * time.Minute,
++}
++
+ // InvoiceFactoryCreator returns a payment engine factory.
+ func InvoiceFactoryCreator(
+ 	dialog communication.Dialog,",I think `Rate` is a more precise and concise term for `PaymentPerTime`.
+1136,"@@ -213,7 +213,7 @@ namespace pwiz.Skyline.Util
+                 {
+                     // No leading + or - : is it because description starts with a label, or because + mode is implied?
+                     var limit = input.IndexOfAny(new[] { '+', '-', ']' });
+-                    if (limit < 0)
++                    if (limit < posNext)
+                     {
+                         return null;
+                     }","I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the ""M"". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?"
+1137,"@@ -263,7 +263,12 @@ class OrderController extends BaseFrontController
+
+         /* check cart count */
+         $this->checkCartNotEmpty();
+-
++
++        /* check stock not empty */
++        if(true === ConfigQuery::checkAvailableStock()) {
++          $this->checkStockNotEmpty();
++        }
++
+         /* check delivery address and module */
+         $this->checkValidDelivery();
+ ","if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution."
+1138,"@@ -46,7 +46,7 @@ import (
+ 	""github.com/prometheus/common/version""
+ 	""golang.org/x/sync/errgroup""
+ 	v1 ""k8s.io/api/core/v1""
+-	""k8s.io/klog/v2""
++	klogv2 ""k8s.io/klog/v2""
+ )
+
+ const (",Any specific reason for this change? klog should work correctly here.
+1139,"@@ -243,6 +243,9 @@ class Storage(StorageBase):
+         VALUES (:object_id, :parent_id,
+                 :collection_id, (:data)::JSONB,
+                 from_epoch(:last_modified))
++        ON CONFLICT (id, parent_id, collection_id) DO UPDATE
++        SET data = (:data)::JSONB,
++            last_modified = from_epoch(:last_modified)
+         RETURNING id, as_epoch(last_modified) AS last_modified;
+         """"""
+         placeholders = dict(object_id=record[id_field],",we don't mention `last_modified` here?
+1140,"@@ -1,6 +1,10 @@
+-const html = require('yo-yo')
+ const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl
+
+ module.exports = (props) => {
+   const isHidden = Object.keys(props.files).length === 0",same deal about the global state maybe interfering as in ActionBrowseTagline
+1141,"@@ -172,5 +172,17 @@ namespace Nethermind.Core.Test.Caching
+
+             count.Should().Be(itemsToKeep);
+         }
++
++        [Test]
++        public void Wrong_capacity_number_at_constructor()
++        {
++            int maxCapacity = 0;
++
++            Assert.Throws<ArgumentOutOfRangeException>(() =>
++                {
++                    LruCache<int, int> cache = new LruCache<int, int>(maxCapacity, ""test"");
++                });
++
++        }
+     }
+ }",so sweet to see a test as the first thing
+1142,"@@ -161,6 +161,12 @@ struct flb_config *flb_config_init()
+     config->http_port    = flb_strdup(FLB_CONFIG_HTTP_PORT);
+ #endif
+
++    config->http_proxy = getenv(""HTTP_PROXY"");
++    if (strcmp(config->http_proxy, """")) {
++        /* Proxy should not be set when the `HTTP_PROXY` is set to """" */
++        config->http_proxy = NULL;
++    }
++
+     config->cio          = NULL;
+     config->storage_path = NULL;
+     config->storage_input_plugin = NULL;","usually when HTTP_PROXY="""" (empty), proxy should be disabled. could you set it to NULL when it's empty string?"
+1143,"@@ -62,6 +62,10 @@ class SimpleResizer implements ResizerInterface
+         if ($settings['height'] == null) {
+             $settings['height'] = (int) ($settings['width'] * $size->getHeight() / $size->getWidth());
+         }
++
++        if ($settings['width'] == null) {
++            $settings['width'] = (int) ($settings['height'] * $size->getWidth() / $size->getHeight());
++        }
+
+         return $this->computeBox($media, $settings);
+     }",Can you throw an exception if width or height are both null
+1144,"@@ -26,8 +26,8 @@ import (
+ )
+
+ var (
+-	HTTPSchemeHTTP  = HTTPSchemeKey.String(""http"")
+-	HTTPSchemeHTTPS = HTTPSchemeKey.String(""https"")
++	httpSchemeHTTP  = HTTPSchemeKey.String(""http"")
++	httpSchemeHTTPS = HTTPSchemeKey.String(""https"")
+ )
+
+ // NetAttributesFromHTTPRequest generates attributes of the net",This is a breaking change. I guess these might have been intentionally exported.
+1145,"@@ -225,6 +225,8 @@ abstract class BaseTableScan implements TableScan {
+     long splitSize;
+     if (options.containsKey(TableProperties.SPLIT_SIZE)) {
+       splitSize = Long.parseLong(options.get(TableProperties.SPLIT_SIZE));
++    } else if (options.containsKey(TableProperties.METADATA_SPLIT_SIZE)) {
++      splitSize = Long.parseLong(options.get(TableProperties.METADATA_SPLIT_SIZE));
+     } else {
+       splitSize = targetSplitSize(ops);
+     }","I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans."
+1146,"@@ -267,6 +267,10 @@ const (
+ 	Add Operator = '+'
+ 	// Subtract implements binary - (only works on integers)
+ 	Subtract = '-'
++	// Multiply implements multiplication between two types
++	Multiply = '×'
++	// Divide implements division, currently only between integers
++	Divide = '÷'
+ 	// Modulo implements % (including string interpolation)
+ 	Modulo = '%'
+ 	// LessThan implements <","wait a sec, shouldn't this be `'*'`?"
+1147,"@@ -127,6 +127,9 @@ func (oi *OVFImporter) buildDaisyVars(bootDiskImageURI string, machineType strin
+ 	varMap[""boot_disk_image_uri""] = bootDiskImageURI
+ 	if oi.params.IsInstanceImport() {
+ 		varMap[""instance_name""] = oi.params.InstanceNames
++		if oi.params.ComputeServiceAccount != """" {
++			varMap[""compute_service_account""] = oi.params.ComputeServiceAccount
++		}
+ 	} else {
+ 		varMap[""machine_image_name""] = oi.params.MachineImageName
+ 	}",It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ )
+1148,"@@ -21,6 +21,7 @@ from selenium.webdriver.remote.remote_connection import RemoteConnection
+ class FirefoxRemoteConnection(RemoteConnection):
+     def __init__(self, remote_server_addr, keep_alive=True):
+         RemoteConnection.__init__(self, remote_server_addr, keep_alive)
++        self._commands[""GET_CONTEXT""] = ('GET', '/session/$sessionId/moz/context')
+
+         self._commands[""SET_CONTEXT""] = (""POST"", ""/session/$sessionId/moz/context"")
+         self._commands[""ELEMENT_GET_ANONYMOUS_CHILDREN""] = \",Nit: Group this with the other commands by moving it down one line.
+1149,"@@ -512,6 +512,9 @@ public class VectorizedPageIterator extends BasePageIterator {
+         throw new ParquetDecodingException(""could not read page in col "" + desc, e);
+       }
+     } else {
++      if (dataEncoding != Encoding.PLAIN) {
++        throw new UnsupportedOperationException(""Unsupported encoding: "" + dataEncoding);
++      }
+       plainValuesReader = new ValuesAsBytesReader();
+       plainValuesReader.initFromPage(valueCount, in);
+       dictionaryDecodeMode = DictionaryDecodeMode.NONE;","I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like ""Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file"""
+1150,"@@ -101,6 +101,10 @@ class RangeBase(luigi.WrapperTask):
+     now = luigi.IntParameter(
+         default=None,
+         description=""set to override current time. In seconds since epoch"")
++    param_name = luigi.Parameter(
++        default=None,
++        description=""parameter name used to pass in parameterized value. Defaults to None, meaning use first positional parameter"",
++        positional=False)
+
+     @property
+     def of_cls(self):","Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere."
+1151,"@@ -9,8 +9,8 @@ const expect = require('chai').expect,
+   MongoError = require('../../../lib/core/error').MongoError,
+   ReadPreference = require('../../../lib/core/topologies/read_preference');
+
+-const rsWithPrimaryPath = f('%s/../spec/max-staleness/ReplicaSetWithPrimary', __dirname);
+-const rsWithoutPrimaryPath = f('%s/../spec/max-staleness/ReplicaSetNoPrimary', __dirname);
++const rsWithPrimaryPath = f('%s/../../spec/max-staleness/ReplicaSetWithPrimary', __dirname);
++const rsWithoutPrimaryPath = f('%s/../../spec/max-staleness/ReplicaSetNoPrimary', __dirname);
+
+ describe('Max Staleness', function() {
+   describe('ReplicaSet without primary', function() {","Since we're here, can we use a template?"
+1152,"@@ -214,3 +214,10 @@ def postgres_db_info_resource(init_context):
+         dialect='postgres',
+         load_table=_do_load,
+     )
++
++
++if __name__ == '__main__':
++    # This is a brutal hack. When the SparkSession is created for the first time there is a lengthy
++    # download process from Maven. This allows us to run python -m airline_demo.resources in the
++    # Dockerfile and avoid a long runtime delay before each containerized solid executes.
++    spark_session_local.resource_fn(None)",saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?
+1153,"@@ -49,10 +49,10 @@ var _ = Context(""with initialized Felix, etcd datastore, 3 workloads"", func() {
+ 		defaultProfile := api.NewProfile()
+ 		defaultProfile.Name = ""default""
+ 		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.EgressRules = []api.Rule{{Action: ""allow""}}
++		defaultProfile.Spec.EgressRules = []api.Rule{{Action: api.Allow}}
+ 		defaultProfile.Spec.IngressRules = []api.Rule{{
+-			Action: ""allow"",
+-			Source: api.EntityRule{Tag: ""default""},
++			Action: api.Allow,
++			Source: api.EntityRule{Selector: ""default == ''""},
+ 		}}
+ 		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+ 		Expect(err).NotTo(HaveOccurred())",`has(default)` i think is the preferred way of doing this
+1154,"@@ -35,9 +35,11 @@ class ScalarSpaceEncoderTest(unittest.TestCase):
+   def testScalarSpaceEncoder(self):
+     """"""scalar space encoder""""""
+     # use of forced=True is not recommended, but used in the example for readibility, see scalar.py
+-    sse = ScalarSpaceEncoder(1,1,2,False,2,1,1,None,0,False,""delta"", forced=True)
++    sse = ScalarSpaceEncoder(w=21,minval=1,maxval=2,n=100,radius=1,
++            resolution=1,name=""SP1"",verbosity=0,clipInput=False,space=""delta"")
+     self.assertTrue(sse.isDelta())
+-    sse = ScalarSpaceEncoder(1,1,2,False,2,1,1,None,0,False,""absolute"", forced=True)
++    sse = ScalarSpaceEncoder(w=21,minval=1,maxval=2,n=100,radius=1,
++            resolution=1,name=""sp2"",verbosity=0,clipInput=False,space=""absolute"")
+     self.assertFalse(sse.isDelta())
+
+      ",always put a space after a comma
+1155,"@@ -289,6 +289,10 @@ public class LFMainActivity extends SharedMediaActivity {
+                     mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
+                     editMode = true;
+                 }
++                else
++                {
++                    selectAllPhotosUpToFav(getImagePosition(m.getPath()));
++                }
+             } else selectAllPhotosUpTo(getImagePosition(m.getPath()), mediaAdapter);
+             return true;
+         }","@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280."
+1156,"@@ -111,7 +111,7 @@ class WebDriver(object):
+
+     def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
+                  desired_capabilities=None, browser_profile=None, proxy=None,
+-                 keep_alive=False, file_detector=None):
++                 keep_alive=False, file_detector=None, options=None):
+         """"""
+         Create a new driver that will issue commands using the wire protocol.
+ ",@AutomatedTester @davehunt thoughts on a new keyword argument?
+1157,"@@ -44,7 +44,7 @@ public class NodeStatus {
+   public NodeStatus(
+       NodeId nodeId,
+       URI externalUri,
+-      int maxSessionCount,
++      Integer maxSessionCount,
+       Set<Slot> slots,
+       Availability availability) {
+     this.nodeId = Require.nonNull(""Node id"", nodeId);",This change shouldn't be necessary for this PR. Please remove it.
+1158,"@@ -27,7 +27,8 @@ import (
+ )
+
+ func testAlertmanagerInstanceNamespacesAllNs(t *testing.T) {
+-	ctx := framework.NewTestCtx(t)
++	testCtx := framework.NewTestCtx(t)
++	ctx := &testCtx
+ 	defer ctx.Cleanup(t)
+
+ 	// create 3 namespaces:","This variable is mostly unused, how about we make `NewTestCtx` return a pointer?"
+1159,"@@ -7,6 +7,10 @@ import (
+ 	""k8s.io/klog/v2""
+ )
+
++const (
++	maxPayloadLen = 32 * 1 << 20 // 32Mi
++)
++
+ type Reader struct {
+ 	reader io.Reader
+ }",What is the basis of this value?
+1160,"@@ -28,6 +28,7 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+
++#include ""gce_metadata.h""
+ #include ""stackdriver.h""
+ #include ""stackdriver_conf.h""
+ ",Nit: was this extra blank line added intentionally?
+1161,"@@ -5837,6 +5837,12 @@ initialize_exception_record(EXCEPTION_RECORD* rec, app_pc exception_address,
+     case ILLEGAL_INSTRUCTION_EXCEPTION:
+         rec->ExceptionCode = EXCEPTION_ILLEGAL_INSTRUCTION;
+         break;
++    case GUARD_PAGE_EXCEPTION:
++        rec->ExceptionCode = STATUS_GUARD_PAGE_VIOLATION;
++        rec->NumberParameters = 2;
++        rec->ExceptionInformation[0]=EXCEPTION_EXECUTE_FAULT /* execution tried */;
++        rec->ExceptionInformation[1]=(ptr_uint_t)exception_address;
++        break;
+     default:
+         ASSERT_NOT_REACHED();
+     }",nit: inconsistent spacing around =
+1162,"@@ -12,7 +12,6 @@
+ namespace Sonata\MediaBundle\Model;
+
+ use Imagine\Image\Box;
+-use Sonata\ClassificationBundle\Model\CategoryInterface;
+ use Symfony\Component\Validator\Context\ExecutionContextInterface;
+ use Symfony\Component\Validator\ExecutionContextInterface as LegacyExecutionContextInterface;
+ ",We still need this import
+1163,"@@ -60,7 +60,7 @@ public class TestBinPackStrategy extends TableTestBase {
+     }
+
+     @Override
+-    public Set<DataFile> rewriteFiles(String groupId, List<FileScanTask> filesToRewrite) {
++    public Set<DataFile> rewriteFiles(List<FileScanTask> filesToRewrite) {
+       throw new UnsupportedOperationException();
+     }
+   }","We are pulling this because we removed ""groupID"" state and put it into the strategy implementations"
+1164,"@@ -17,8 +17,7 @@
+ #include <CL/sycl.hpp>
+
+ #include ""gtest/gtest.h""
+-#define ONEAPI_DAL_DATA_PARALLEL
+-#include ""oneapi/dal/algo/kmeans_init.hpp""
++#include ""oneapi/dal/algo/kmeans_init/compute.hpp""
+ #include ""oneapi/dal/table/homogen.hpp""
+ #include ""oneapi/dal/table/row_accessor.hpp""
+ ",Is this file actually related to PCA?
+1165,"@@ -6,7 +6,7 @@ import createEnableTracking from './createEnableTracking';
+ import createTrackEvent from './createTrackEvent';
+
+ const DEFAULT_CONFIG = {
+-	isFirstAdmin: false,
++	isOwner: false,
+ 	trackingEnabled: false,
+ 	trackingID: '',
+ 	referenceSiteURL: '',","See above, this should probably remain `isFirstAdmin`."
+1166,"@@ -499,7 +499,7 @@ type ArrayExpression struct {
+
+ 	Elements []Expression
+
+-	typ MonoType
++	Type MonoType
+ }
+
+ func (*ArrayExpression) NodeType() string { return ""ArrayExpression"" }",Why the change to make it public? The expression interface has the `TypeOf` method?
+1167,"@@ -1562,7 +1562,7 @@ namespace NLog.UnitTests.Targets
+         }
+
+         [Fact]
+-        public void Single_Archive_File_Rolls_Correctly()
++        public void SingleArchiveFileRollsCorrectly()
+         {
+             var tempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+             var tempFile = Path.Combine(tempPath, ""file.txt"");","don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO"
+1168,"@@ -28,6 +28,11 @@ type identityRegistrationDto struct {
+ 	Registered bool `json:""registered""`
+ }
+
++type identityUnlockingDto struct {
++	Id         string `json:""id""`
++	Passphrase string `json:""passphrase""`
++}
++
+ type identitiesApi struct {
+ 	idm             identity.IdentityManagerInterface
+ 	mysteriumClient server.Client",`Id` defines REST resource address and should not be in payload
+1169,"@@ -20,8 +20,11 @@ def main():
+         nargs='+',
+         default=[100, 300, 1000],
+         help='proposal numbers, only used for recall evaluation')
++    parser.add_argument(
++        '--class_wise', action='store_true', help='whether eval class wise ap')
+     args = parser.parse_args()
+-    coco_eval(args.result, args.types, args.ann, args.max_dets)
++    coco_eval(args.result, args.types, args.ann, args.max_dets,
++              args.class_wise)
+
+
+ if __name__ == '__main__':",We can omit the underscore and just use `classwise`.
+1170,"@@ -77,10 +77,12 @@ class MediaAdminController extends Controller
+         $datagrid->setValue('context', null, $context);
+
+         // retrieve the main category for the tree view
+-        $category = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);
++        $rootCategory = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);
++        // This should be safe as the root category has to exist for a given context but I do not like fatal errors
++        $rootCategoryId = !empty($rootCategory) ? $rootCategory->getId() : null;
+
+         if (!$filters) {
+-            $datagrid->setValue('category', null, $category);
++            $datagrid->setValue('category', null, $rootCategoryId);
+         }
+         if ($request->get('category')) {
+             $categoryByContext = $this->container->get('sonata.classification.manager.category')->findOneBy(array(",Why not throw an exception instead then?
+1171,"@@ -71,8 +71,7 @@ abstract class DataIterator<T> implements CloseableIterator<T> {
+
+   InputFile getInputFile(FileScanTask task) {
+     Preconditions.checkArgument(!task.isDataTask(), ""Invalid task type"");
+-
+-    return inputFiles.get(task.file().path().toString());
++    return getInputFile(task.file().path().toString());
+   }
+
+   InputFile getInputFile(String location) {",Looks like this doesn't need to change. Can you revert this?
+1172,"@@ -3,6 +3,7 @@ import sys
+ from cliquet.scripts import cliquet
+ from pyramid.scripts import pserve
+ from pyramid.paster import bootstrap
++from config import template
+
+ CONFIG_FILE = 'config/kinto.ini'
+ ",please import it like `from kinto.config import template`
+1173,"@@ -173,7 +173,7 @@ public final class Configuration {
+   }
+
+   public boolean isIsolationFilterOpen(String microservice) {
+-    String p = getStringProperty(""false"",
++    String p = getStringProperty(""true"",
+         PROP_ROOT + microservice + ""."" + FILTER_ISOLATION + FILTER_OPEN,
+         PROP_ROOT + FILTER_ISOLATION + FILTER_OPEN);
+     return Boolean.parseBoolean(p);","There are lots of default value changed, not sure if it break the old behavior."
+1174,"@@ -10,13 +10,15 @@ import (
+ 	""context""
+ 	""encoding/hex""
+ 	""math/big""
++	""net""
++	""strconv""
+
+-	""github.com/golang/protobuf/jsonpb""
+ 	""github.com/golang/protobuf/proto""
+-	peerstore ""github.com/libp2p/go-libp2p-peerstore""
+ 	""github.com/pkg/errors""
+ 	""github.com/prometheus/client_golang/prometheus""
+ 	""go.uber.org/zap""
++	""google.golang.org/grpc""
++	""google.golang.org/grpc/reflection""
+
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/actpool""",File is not `goimports`-ed (from `goimports`)
+1175,"@@ -29,9 +29,9 @@ namespace Nethermind.Cli.Modules
+         public object[] Peers() => NodeManager.Post<object[]>(""admin_peers"").Result;
+
+         [CliFunction(""admin"", ""addPeer"")]
+-        public string AddPeer(string enode) => NodeManager.Post<string>(""admin_addPeer"", enode).Result;
++        public string AddPeer(string enode, bool addToStaticNodes = false) => NodeManager.Post<string>(""admin_addPeer"", enode, addToStaticNodes).Result;
+
+         [CliFunction(""admin"", ""removePeer"")]
+-        public string RemovePeer(string enode) => NodeManager.Post<string>(""admin_removePeer"", enode).Result;
++        public string RemovePeer(string enode, bool addToStaticNodes = false) => NodeManager.Post<string>(""admin_removePeer"", enode, addToStaticNodes).Result;
+     }
+ }",parameter should be called removeFromStaticNodes
+1176,"@@ -221,7 +221,9 @@ class RequestContext:
+ ServiceRequestHandler = Callable[[RequestContext, ServiceRequest], Optional[ServiceResponse]]
+
+
+-def handler(operation: str = None, context: bool = True, expand: bool = True):
++def handler(
++    operation: str = None, context: bool = True, expand: bool = True, override: bool = False
++):
+     """"""
+     Decorator that indicates that the given function is a handler
+     """"""","The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto."
+1177,"@@ -14,6 +14,18 @@ class Subscription < ActiveRecord::Base
+     notifier.send_notifications
+   end
+
++  def active?
++    deactivated_on.nil?
++  end
++
++  def deactivate
++    update_column(:deactivated_on, Date.today)
++  end
++
++  def activate
++    update_column(:deactivated_on, nil)
++  end
++
+   private
+
+   def self.subscriber_emails","Is this method actually being used anywhere? If not, I think we should remove it."
+1178,"@@ -400,7 +400,7 @@ namespace AutoRest.Extensions
+                 {
+                     var bodyParameterType = bodyParameter.ModelType as CompositeType;
+                     if (bodyParameterType != null &&
+-                        (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant) <= Settings.Instance.PayloadFlatteningThreshold ||
++                        (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant && !p.IsReadOnly) <= Settings.Instance.PayloadFlatteningThreshold ||
+                          bodyParameter.ShouldBeFlattened()))
+                     {
+                         var parameterTransformation = new ParameterTransformation",Thanks! I somehow lost this between my far too many branchs.
+1179,"@@ -30,13 +30,14 @@ import socket
+ import sys
+
+ from .firefox_binary import FirefoxBinary
++from .options import Options
+ from .remote_connection import FirefoxRemoteConnection
+ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+ from selenium.webdriver.firefox.extension_connection import ExtensionConnection
+ from selenium.webdriver.firefox.firefox_profile import FirefoxProfile
+ from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
+ from .service import Service
+-from .options import Options
++from .webelement import FirefoxWebElement
+
+
+ class WebDriver(RemoteWebDriver):",i think this should get put into its own file. This could start to grow :)
+1180,"@@ -39,6 +39,13 @@ const (
+ 	// variable containers' config, which will be used by the AWS SDK to fetch
+ 	// credentials.
+ 	awsSDKCredentialsRelativeURIPathEnvironmentVariableName = ""AWS_CONTAINER_CREDENTIALS_RELATIVE_URI""
++	// pauseContainerName is the internal name for the pause container
++	pauseContainerName = ""~internal~ecs~pause""
++	// pauseContainerImage is container image used to create the pause container
++	// TODO: Modify this to amazon/amazon-ecs-pause or something similar
++	pauseContainerImage = ""gcr.io/google_containers/pause:latest""
++	// networkModeNone specifies the string used to define the `none` docker networking mode
++	networkModeNone = ""none""
+ )
+
+ // TaskOverrides are the overrides applied to a task",Can you add a TODO for loading the tarball of the pause image into Docker?
+1181,"@@ -259,7 +259,6 @@ public class ProcessJob extends AbstractProcessJob {
+         }
+         throw new RuntimeException(e);
+       } finally {
+-        this.process = null;
+         info(""Process completed ""
+             + (success ? ""successfully"" : ""unsuccessfully"") + "" in ""
+             + ((System.currentTimeMillis() - startMs) / 1000) + "" seconds."");",Is there any value in setting the process to null like this?
+1182,"@@ -35,6 +35,14 @@ void SoftmaxWithLossLayer<Dtype>::Reshape(
+     const vector<Blob<Dtype>*>& bottom, const vector<Blob<Dtype>*>& top) {
+   LossLayer<Dtype>::Reshape(bottom, top);
+   softmax_layer_->Reshape(softmax_bottom_vec_, softmax_top_vec_);
++  softmax_axis_ = this->layer_param_.softmax_param().axis();
++  outer_num_ = bottom[0]->count(0, softmax_axis_);
++  inner_num_ = bottom[0]->count(softmax_axis_ + 1);
++  CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count())
++      << ""Number of labels must match number of predictions; ""
++      << ""e.g., if softmax axis == 1 and prediction shape is (N, C, H, W), ""
++      << ""label count (number of labels) must be N*H*W, ""
++      << ""with integer values in {0, 1, ..., C-1}."";
+   if (top.size() >= 2) {
+     // softmax output
+     top[1]->ReshapeLike(*bottom[0]);",This could be a good time to add a check that the prediction and target dimensions (except channel) agree?
+1183,"@@ -3920,6 +3920,11 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb)
+             if (!bb_process_interrupt(dcontext, bb))
+                 break;
+         }
++#ifdef AARCH64
++        /* OP_isb, when mangled, has a potential side exit. */
++        else if (instr_get_opcode(bb->instr) == OP_isb)
++            break;
++#endif
+ #if 0/*i#1313, i#1314*/
+         else if (instr_get_opcode(bb->instr) == OP_getsec) {
+             /* XXX i#1313: if we support CPL0 in the future we'll need to","The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs."
+1184,"@@ -83,7 +83,7 @@ define([""userSettings""], function (userSettings) {
+
+             if (html += '<div class=""listPaging"">', showControls) {
+                 html += '<span style=""vertical-align:middle;"">';
+-                html += (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd + "" of "" + totalRecordCount;
++                html += Globalize.translate(""ListPaging"").replace(""{0}"", (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd).replace(""{1}"", totalRecordCount);
+                 html += ""</span>"";
+             }
+ ",The translate library has a method to replace the variables.
+1185,"@@ -155,6 +155,18 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         with self.assertRaisesRegex(TypeError, msg):
+             ds.isin(1)
+
++    def test_fillna(self):
++        ps = pd.Series([np.nan, 2, 3, 4, np.nan, 6], name='x')
++        ks = koalas.from_pandas(ps)
++
++        self.assert_eq(ks.fillna(0), ps.fillna(0))
++        self.assert_eq(ks.fillna(0, inplace=True), ps.fillna(0, inplace=True))
++        self.assert_eq(ks.fillna({'x': 0}), ps.fillna({'x': 0}))
++
++        s_nan = pd.Series([0], index=['x'], dtype=int)
++        self.assert_eq(ks.fillna(s_nan),
++                       ps.fillna(s_nan))
++
+     def test_dropna(self):
+         ps = pd.Series([np.nan, 2, 3, 4, np.nan, 6], name='x')
+ ","i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following ""ks"" because ks has been changed."
+1186,"@@ -124,6 +124,7 @@ with outfile.open(""w"") as f, contextlib.redirect_stdout(f):
+             tls.TlsClienthelloHook,
+             tls.TlsStartClientHook,
+             tls.TlsStartServerHook,
++            tls.TlsHandshakeHook,
+         ]
+     )
+ ","Any proposals how to make the naming somehow include the ""completed"" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?"
+1187,"@@ -157,6 +157,7 @@ namespace Nethermind.Blockchain.Synchronization
+
+                 if (headersSynced > 0)
+                 {
++                    _blockTree.Flush();
+                     _syncReport.FullSyncBlocksDownloaded.Update(_blockTree.BestSuggestedHeader?.Number ?? 0);
+                     _syncReport.FullSyncBlocksKnown = bestPeer.HeadNumber;
+                 }","it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?"
+1188,"@@ -220,10 +220,10 @@ class JSTree extends AbstractBase
+             if ('collection' === $type && !$this->collectionsEnabled) {
+                 $type = 'record';
+             }
+-            $url = $this->getUrlFromRouteCache($type, $node->id);
++            $url = $this->getUrlFromRouteCache($type, urlencode($node->id));
+             return $type === 'collection'
+                 ? $url . '#tabnav'
+-                : $url . '#tree-' . preg_replace('/\W/', '-', $node->id);
++                : $url . '#tree-' . preg_replace('/\W/', '-', urlencode($node->id));
+         }
+     }
+ ","There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?"
+1189,"@@ -142,7 +142,11 @@ class EditorManager {
+
+     if (editorClass) {
+       this.activeEditor = getEditorInstance(editorClass, this.instance);
++      this.activeEditor.row = row; // pre-preparation needed by getEditedCell
++      this.activeEditor.col = col;
+       const td = this.activeEditor.getEditedCell();
++      this.activeEditor.row = null; // restore the un-initialized state
++      this.activeEditor.col = null;
+       this.activeEditor.prepare(row, col, prop, td, originalValue, cellProperties);
+
+     } else {",Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?
+1190,"@@ -280,7 +280,11 @@ func (cs *ChainService) HandleAction(_ context.Context, actPb *iotextypes.Action
+ 	if err := act.LoadProto(actPb); err != nil {
+ 		return err
+ 	}
+-	return cs.actpool.Add(act)
++	err := cs.actpool.Add(act)
++	if err != nil {
++		log.L().Info(err.Error())
++	}
++	return err
+ }
+
+ // HandleBlock handles incoming block request.",Change this to Debug Level
+1191,"@@ -521,9 +521,9 @@ namespace NLog.Targets
+             {
+                 _allLayoutsAreThreadSafe = _allLayouts.All(layout => layout.ThreadSafe);
+             }
+-            StackTraceUsage = _allLayouts.DefaultIfEmpty().Max(layout => layout?.StackTraceUsage ?? StackTraceUsage.None);
+-            if (this is IUsesStackTrace usesStackTrace && usesStackTrace.StackTraceUsage > StackTraceUsage)
+-                StackTraceUsage = usesStackTrace.StackTraceUsage;
++            StackTraceUsage = _allLayouts.DefaultIfEmpty().Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));
++            if (this is IUsesStackTrace usesStackTrace)
++                StackTraceUsage |= usesStackTrace.StackTraceUsage;
+             _scannedForLayouts = true;
+         }
+ ","I refactored the Aggregate, those are hard to read"
+1192,"@@ -290,14 +290,6 @@ describe('region', function() {
+     assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+   });
+
+-  it('treats iframe elements as regions', function() {
+-    var checkArgs = checkSetup(
+-      '<iframe id=""target""></iframe><div role=""main"">Content</div>'
+-    );
+-
+-    assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+-  });
+-
+   it('returns the outermost element as the error', function() {
+     var checkArgs = checkSetup(
+       '<div id=""target""><p>This is random content.</p></div><div role=""main""><h1 id=""mainheader"" tabindex=""0"">Introduction</h1></div>'","This is now done in the after method, so this test won't pass any more."
+1193,"@@ -152,10 +152,14 @@ class ApplicationController < ActionController::Base
+     # have we identified the user?
+     if @user
+       # check if the user has been banned
+-      if @user.blocks.active.exists?
+-        # NOTE: need slightly more helpful message than this.
++      user_block =  @user.blocks.active.take
++      unless user_block.nil?
+         set_locale
+-        report_error t(""application.setup_user_auth.blocked""), :forbidden
++        if  @user.blocks.active.take.zero_hour?
++          report_error  t(""application.setup_user_auth.blocked_zero_hour""), :forbidden
++        else
++          report_error t(""application.setup_user_auth.blocked""), :forbidden
++        end
+       end
+
+       # if the user hasn't seen the contributor terms then don't",What was the point of creating `user_block` if you're then not going to use it ;-)
+1194,"@@ -22,9 +22,6 @@ from decorator import decorator
+ import types
+ import logging
+
+-from databricks.koalas.frame import PandasLikeDataFrame
+-from databricks.koalas.series import PandasLikeSeries
+-
+ logger = logging.getLogger('spark')
+
+ _TOUCHED_TEST = ""_pandas_updated""","@ueshin, I thought we can remove this entire file. Does that require some more works?"
+1195,"@@ -39,7 +39,7 @@ def evaluateTokens(requestContext, tokens):
+       return float(tokens.number.scientific[0])
+
+   elif tokens.string:
+-    return str(tokens.string)[1:-1]
++    return unicode(tokens.string)[1:-1]
+
+   elif tokens.boolean:
+     return tokens.boolean[0] == 'true'",Just `return tokens.string[1:-1]` is enough
+1196,"@@ -0,0 +1,3 @@
++resources :quizzes, only: [:show] do
++  resources :questions, only: [:show]
++end",1 trailing blank lines detected.
+1197,"@@ -29,7 +29,7 @@ public class LeftButton extends Button {
+         super(name);
+         this.name = name;
+         this.getStyleClass().add(""leftButton"");
+-        this.setPrefWidth(Double.MAX_VALUE);
++        this.setMaxWidth(Double.MAX_VALUE);
+         this.setAlignment(Pos.CENTER_LEFT);
+         this.setPadding(new Insets(2));
+     }",Isn't this the default max width? In any case I would prefer to see these definitions in the css files.
+1198,"@@ -34,10 +34,11 @@ func redirParse(c *caddy.Controller) ([]Rule, error) {
+ 	cfg := httpserver.GetConfig(c)
+
+ 	initRule := func(rule *Rule, defaultCode string, args []string) error {
+-		if cfg.TLS.Enabled {
+-			rule.FromScheme = ""https""
+-		} else {
+-			rule.FromScheme = ""http""
++		rule.FromScheme = func() string {
++			if cfg.TLS.Enabled {
++				return ""https""
++			}
++			return ""http""
+ 		}
+
+ 		var (","Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)"
+1199,"@@ -21,8 +21,8 @@
+ # IN THE SOFTWARE.
+ #-------------------------------------------------------------------------------
+ from datatable.lib._datatable import (
+-	Ftrl,
+ 	aggregate,
++	Ftrl,
+ 	kfold,
+ 	kfold_random,
+ )",Looks like this file has tabs instead of spaces.
+1200,"@@ -649,6 +649,19 @@ func (engine *DockerTaskEngine) deleteTask(task *apitask.Task) {
+ 		}
+ 	}
+
++	for _, container := range task.Containers {
++		for _, resource := range container.GetResources() {
++			err := resource.Cleanup()
++			if err != nil {
++				seelog.Warnf(""Task engine [%s]/[%s]: unable to cleanup resource %s: %v"",
++					task.Arn, container.Name, resource.GetName(), err)
++			} else {
++				seelog.Infof(""Task engine [%s]/[%s]: resource %s cleanup complete"",
++					task.Arn, container.Name, resource.GetName())
++			}
++		}
++	}
++
+ 	if execcmd.IsExecEnabledTask(task) {
+ 		// cleanup host exec agent log dirs
+ 		if tID, err := task.GetID(); err != nil {",Hmm should we clean up container resources before task resources here? or the order does not really matter here?
+1201,"@@ -44,7 +44,6 @@ def temporary_download_dir(quteproc, tmpdir):
+     unwritable.ensure(dir=True)
+     unwritable.chmod(0)
+
+-
+ @bdd.given(""I clean old downloads"")
+ def clean_old_downloads(quteproc):
+     quteproc.send_cmd(':download-cancel --all')",Please undo this :wink:
+1202,"@@ -25,6 +25,12 @@ class ApiClient < ActiveRecord::Base
+   include DeviseInvitable::Inviter
+   include ValidationMessages
+
++  # ================
++  # = Associations =
++  # ================
++
++  has_many :plans
++
+   # If the Client_id or client_secret are nil generate them
+   before_validation :generate_credentials,
+                     if: Proc.new { |c| c.client_id.blank? || c.client_secret.blank? }",thanks for adding this missing association
+1203,"@@ -11,6 +11,11 @@ namespace Microsoft.AspNet.Server.Kestrel.Https
+     public static class HttpsApplicationBuilderExtensions
+     {
+         public static IApplicationBuilder UseKestrelHttps(this IApplicationBuilder app, X509Certificate2 cert)
++        {
++            return app.UseKestrelHttps(new HttpsConnectionFilterOptions { ServerCertificate = cert});
++        }
++
++        public static IApplicationBuilder UseKestrelHttps(this IApplicationBuilder app, HttpsConnectionFilterOptions options)
+         {
+             var serverInfo = app.ServerFeatures.Get<IKestrelServerInformation>();
+ ",Should I remove this in favor of the HttpsConnectionFilterOptions overload?
+1204,"@@ -109,6 +109,15 @@ class DbalStatusQuery implements StatusQueryInterface
+         return array_values($result);
+     }
+
++    public function getMaxIndex(): ?int
++    {
++        return $this->connection->createQueryBuilder()
++            ->select('max(index)')
++            ->from(self::STATUS_TABLE)
++            ->execute()
++            ->fetchOne();
++    }
++
+     private function getQuery(Language $language): QueryBuilder
+     {
+         return $this->connection->createQueryBuilder()","This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme"
+1205,"@@ -32,6 +32,10 @@ class Auth extends Controller
+     public function __construct()
+     {
+         parent::__construct();
++
++		// Add JS File to unistall SW to avoid Cookie Cache Issues when Signin, see github issue: #3707
++		$this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js');
++
+         $this->layout = 'auth';
+     }
+ ",Spaces not tabs
+1206,"@@ -160,6 +160,15 @@ class FsDriverNode extends FsDriverBase {
+ 		}
+ 	}
+
++	async readDir(path) {
++		try {
++			// return fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10
++			return fs.readdirSync(path); // For Node v8
++		} catch (error) {
++			throw this.fsErrorToJsError_(error, path);
++		}
++	}
++
+ 	// Always overwrite destination
+ 	async copy(source, dest) {
+ 		try {","To get the files inside a directory, please use `readDirStats()`."
+1207,"@@ -34,8 +34,11 @@ const LocalConfigFileName string = "".plzconfig.local""
+ // for a particular machine (eg. build machine with different caching behaviour).
+ const MachineConfigFileName = ""/etc/plzconfig""
+
+-const TestContainerDocker = ""docker""
+-const TestContainerNone = ""none""
++const (
++	ContainerImplementationNone   = ""none""
++	ContainerImplementationDocker = ""docker""
++	ContainerImplementationPlz    = ""plz""
++)
+
+ func readConfigFile(config *Configuration, filename string) error {
+ 	log.Debug(""Reading config from %s..."", filename)","might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things"
+1208,"@@ -0,0 +1,5 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package batchstore_test","File is empty, consider removing?"
+1209,"@@ -237,6 +237,16 @@ def _refresh_credentials():
+     return result
+
+
++def logged_in():
++    """"""
++    Return registry URL if Quilt client is authenticated. Otherwise
++    return `None`.
++    """"""
++    url = get_registry_url()
++    if url in _load_auth():
++        return url
++
++
+ class QuiltProvider(CredentialProvider):
+     METHOD = 'quilt-registry'
+     CANONICAL_NAME = 'QuiltRegistry'","This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful."
+1210,"@@ -23,8 +23,9 @@ type Config struct {
+ 	L1CrossDomainMessengerAddress common.Address
+ 	L1FeeWalletAddress            common.Address
+ 	AddressManagerOwnerAddress    common.Address
+-	L1ETHGatewayAddress           common.Address
+ 	GasPriceOracleOwnerAddress    common.Address
++	L1StandardBridgeAddress       common.Address
++	GasPriceOracleAddress         common.Address
+ 	// Turns on checking of state for L2 gas price
+ 	EnableL2GasPolling bool
+ 	// Deployment Height of the canonical transaction chain",Was the addition of `GasPriceOracleAddress` here erroneous?
+1211,"@@ -121,6 +121,11 @@ module Beaker
+           :project                => 'Beaker',
+           :department             => 'unknown',
+           :created_by             => ENV['USER'] || ENV['USERNAME'] || 'unknown',
++          :host_tags              => {
++                                      :project    => 'Beaker',
++                                      :department => 'unknown',
++                                      :created_by => ENV['USER'] || ENV['USERNAME'] || 'unknown'
++          },
+           :openstack_api_key      => ENV['OS_PASSWORD'],
+           :openstack_username     => ENV['OS_USERNAME'],
+           :openstack_auth_url     => ""#{ENV['OS_AUTH_URL']}/tokens"",","I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department]."
+1212,"@@ -149,8 +149,12 @@ public class SessionStore implements
+         if (BuildConfig.DEBUG) {
+             mStoreSubscription = ComponentsAdapter.get().getStore().observeManually(browserState -> {
+                 Log.d(LOGTAG, ""Session status BEGIN"");
+-                browserState.getTabs().forEach(tabSessionState -> Log.d(LOGTAG, ""BrowserStore Session: "" + tabSessionState.getId()));
+-                mSessions.forEach(session -> Log.d(LOGTAG, ""SessionStore Session: "" + session.getId()));
++                for (int i=0; i<browserState.getTabs().size(); i++) {
++                    Log.d(LOGTAG, ""BrowserStore Session: "" + browserState.getTabs().get(i).getId());
++                }
++                for (int i=0; i<mSessions.size(); i++) {
++                    Log.d(LOGTAG, ""SessionStore Session: "" + mSessions.get(i).getId());
++                }
+                 Log.d(LOGTAG, ""Session status END"");
+                 return null;
+             });",How was this causing the exception?
+1213,"@@ -57,6 +57,12 @@ define(['connectionManager', 'userSettings', 'events'], function (connectionMana
+             currentDateTimeCulture = currentCulture;
+         }
+         ensureTranslations(currentCulture);
++        // FIXME: See GH #1027 and #913. This should be configurable and not strictly based on locale.
++        if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk') {
++            require([""css!jellyfin-noto/css/TC""]);
++        } else {
++            require([""css!jellyfin-noto/css/SC""]);
++        }
+     }
+
+     function ensureTranslations(culture) {","I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case."
+1214,"@@ -96,7 +96,7 @@ class MultiTermIntervalsSource extends IntervalsSource {
+
+   @Override
+   public void visit(String field, QueryVisitor visitor) {
+-
++    visitor.visitLeaf(new IntervalQuery(field, this));
+   }
+
+   @Override",Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer.
+1215,"@@ -9,11 +9,11 @@ class CancellationAlternative
+   end
+
+   def discount_percentage_vs_current_plan_annualized
+-    ((1 - (@discounted_plan.price / (@current_plan.price * 12.0))) * 100).
++    ((1 - (@discounted_plan.price_in_dollars / (@current_plan.price_in_dollars * 12.0))) * 100).
+       round(0)
+   end
+
+   def discount_plan_price
+-    @discounted_plan.price
++    @discounted_plan.price_in_dollars
+   end
+ end",Line is too long. [96/80]
+1216,"@@ -167,6 +167,9 @@ func (s *Solver) buildDefaultPod(ch *cmacme.Challenge) *corev1.Pod {
+ 			OwnerReferences: []metav1.OwnerReference{*metav1.NewControllerRef(ch, challengeGvk)},
+ 		},
+ 		Spec: corev1.PodSpec{
++			NodeSelector: map[string]string{
++				""kubernetes.io/os"": ""linux"",
++			},
+ 			RestartPolicy: corev1.RestartPolicyOnFailure,
+ 			Containers: []corev1.Container{
+ 				{","My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?"
+1217,"@@ -24,7 +24,7 @@ import (
+ type Controller string
+
+ type Object struct {
+-	Object v1alpha1.InnerObject
++	Object v1alpha1.InnerObjectWithSelector
+ 	Name   string
+ }
+ ","Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`"
+1218,"@@ -20,8 +20,12 @@ var (
+ 	once    sync.Once
+ )
+
+-// GetContext gets global context instance
+-func GetContext(contextType string) *Context {
++func init()  {
++	InitContext(MsgCtxTypeChannel)
++}
++
++// InitContext gets global context instance
++func InitContext(contextType string) {
+ 	once.Do(func() {
+ 		context = &Context{}
+ 		switch contextType {",Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly.
+1219,"@@ -619,6 +619,14 @@ class WebDriver(object):
+         else:
+             return self.execute(Command.GET_WINDOW_HANDLES)['value']
+
++    def minimize_window(self):
++        """"""
++        Miniimizes the current window that webdriver is using
++        """"""
++        if self.w3c:
++            command = Command.W3C_MINIMIZE_WINDOW
++            self.execute(command, {""windowHandle"": ""current""})
++
+     def maximize_window(self):
+         """"""
+         Maximizes the current window that webdriver is using",This `if` is not necessary
+1220,"@@ -255,6 +255,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 		// (as above, don't diff props during hydration)
+ 		if (!isHydrating) {
+ 			if (('value' in newProps) && newProps.value!==undefined && newProps.value !== dom.value) dom.value = newProps.value==null ? '' : newProps.value;
++			// preact/#1899
++			// We need this value for input masking.
++			dom._lastValue = dom.value;
++
+ 			if (('checked' in newProps) && newProps.checked!==undefined && newProps.checked !== dom.checked) dom.checked = newProps.checked;
+ 		}
+ 	}","should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (""next state"")."
+1221,"@@ -717,6 +717,7 @@ module Beaker
+         args << ""--parseonly"" if opts[:parseonly]
+         args << ""--trace"" if opts[:trace]
+         args << ""--parser future"" if opts[:future_parser]
++        args << ""--modulepath #{opts[:modulepath]}"" if opts[:modulepath]
+
+         # From puppet help:
+         # ""... an exit code of '2' means there were changes, an exit code of",Please update the yard docs to indicate this new option.
+1222,"@@ -52,6 +52,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Scheme sets the scheme of the load balancer (defaults to Internet-facing)
+ 	// +optional
+ 	Scheme *ClassicELBScheme `json:""scheme,omitempty""`
++
++	// Subnets specifies the subnets that should be used by the load balancer
++	// +optional
++	Subnets Subnets `json:""subnets,omitempty""`
+ }
+
+ // AWSClusterStatus defines the observed state of AWSCluster","Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?"
+1223,"@@ -185,7 +185,10 @@ func initDB(db *gorm.DB, dbType string, log hclog.Logger) (err error) {
+ 		return sqlError.Wrap(err)
+ 	}
+
+-	if err := tx.Assign(Migration{Version: latestSchemaVersion}).FirstOrCreate(&Migration{}).Error; err != nil {
++	if err := tx.Assign(Migration{
++		Version:     latestSchemaVersion,
++		CodeVersion: codeVersion.String(),
++	}).FirstOrCreate(&Migration{}).Error; err != nil {
+ 		tx.Rollback()
+ 		return sqlError.Wrap(err)
+ 	}",It would be great if this could be captured by a test.
+1224,"@@ -441,10 +441,15 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int32, isAdvancedVis
+ 		ESIndexMaxResultWindow:            dc.GetIntProperty(dynamicconfig.FrontendESIndexMaxResultWindow, 10000),
+ 		IndexerConcurrency:                dc.GetIntProperty(dynamicconfig.WorkerIndexerConcurrency, 100),
+ 		ESProcessorNumOfWorkers:           dc.GetIntProperty(dynamicconfig.WorkerESProcessorNumOfWorkers, 1),
+-		ESProcessorBulkActions:            dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 1000),
+-		ESProcessorBulkSize:               dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 2<<24), // 16MB
+-		ESProcessorFlushInterval:          dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 1*time.Second),
+-		ESProcessorAckTimeout:             dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
++		// Should be not greater than NumberOfShards(512)/NumberOfHistoryNodes(4) * VisibilityTaskWorkerCount(10) divided by workflow distribution factor (2 at least).
++		// Otherwise, visibility queue processors won't be able to fill up bulk with documents and bulk will flush due to interval, not number of actions.
++		ESProcessorBulkActions: dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 100),
++		// 16MB - just a sanity check. With ES document size ~1Kb it should never be reached.
++		ESProcessorBulkSize: dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 16*1024*1024),
++		// Under high load bulk processor should flush due to number of BulkActions reached.
++		// Although, under small load it would never be the case and bulk processor will flush every this interval.
++		ESProcessorFlushInterval: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 200*time.Millisecond),
++		ESProcessorAckTimeout:    dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
+
+ 		EnableCrossNamespaceCommands: dc.GetBoolProperty(dynamicconfig.EnableCrossNamespaceCommands, true),
+ 	}","1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option"
+1225,"@@ -60,5 +60,5 @@ func (a *ChecksumAddress) UnmarshalText(text []byte) error {
+ // MarshalText implements the encoding.TextMarshaler interface
+ func (a ChecksumAddress) MarshalText() (text []byte, err error) {
+ 	addr := basics.Address(a)
+-	return []byte(addr.GetChecksumAddress().String()), nil
++	return []byte(addr.String()), nil
+ }",Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?
+1226,"@@ -248,7 +248,7 @@ events.on(serverNotifications, 'RestartRequired', function (e, apiClient) {
+         [
+             {
+                 action: 'restart',
+-                title: globalize.translate('ButtonRestart'),
++                title: globalize.translate('HeaderRestart'),
+                 icon: getIconUrl()
+             }
+         ];","Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general."
+1227,"@@ -1250,7 +1250,7 @@ namespace Nethermind.Blockchain
+
+         public Keccak HeadHash => Head?.Hash;
+         public Keccak GenesisHash => Genesis?.Hash;
+-        public Keccak PendingHash => BestSuggestedHeader?.Hash;
++        public Keccak PendingHash => Head?.Hash;
+
+         public Block FindBlock(Keccak blockHash, BlockTreeLookupOptions options)
+         {","I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?"
+1228,"@@ -206,6 +206,7 @@ type SyncStatus struct {
+ type SyncSetCommonSpec struct {
+ 	// Resources is the list of objects to sync from RawExtension definitions.
+ 	// +optional
++	// +kubebuilder:pruning:PreserveUnknownFields
+ 	Resources []runtime.RawExtension `json:""resources,omitempty""`
+
+ 	// ResourceApplyMode indicates if the Resource apply mode is ""Upsert"" (default) or ""Sync"".",This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it.
+1229,"@@ -2,8 +2,10 @@ class Topic < ActiveRecord::Base
+   # Associations
+   has_many :classifications
+   with_options(through: :classifications, source: :classifiable) do |options|
++    options.has_many :exercises, source_type: 'Exercise'
+     options.has_many :products, source_type: 'Product'
+     options.has_many :topics, source_type: 'Topic'
++    options.has_many :videos, source_type: 'Video'
+     options.has_many :workshops, source_type: 'Workshop'
+   end
+   has_one :trail",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+1230,"@@ -38,7 +38,7 @@
+ #include ""common/xutil.h""
+ #include ""xkb.h""
+
+-/* XStringToKeysym() and XKeysymToString */
++/* XStringToKeysym() */
+ #include <X11/Xlib.h>
+ #include <xkbcommon/xkbcommon.h>
+ #include <glib.h>",Some day (tm) I will also get rid of that one. But today is not that day...
+1231,"@@ -206,6 +206,17 @@ class CombineAssets
+         // Disable cache always
+         $this->storagePath = null;
+
++        // Prefix all assets
++        if($localPath) {
++            if (substr($localPath, -1) !== '/') {
++                $localPath = $localPath.'/';
++            }
++            $assets = array_map(function($asset) use ($localPath) {
++                if (substr($asset, 0, 1) === '@') return $asset;
++                return $localPath.$asset;
++            }, $assets);
++        }
++
+         list($assets, $extension) = $this->prepareAssets($assets);
+
+         $rewritePath = File::localToPublic(dirname($destination));",Add a space between if and opening parenthesis please (i.e. `if (`)
+1232,"@@ -827,8 +827,9 @@ class Series(_Frame, IndexOpsMixin, Generic[T]):
+         Name: my_name, dtype: int64
+         """"""
+         if index is None:
+-            return self
+-        scol = self._scol.alias(index)
++            scol = self._scol
++        else:
++            scol = self._scol.alias(index)
+         if kwargs.get('inplace', False):
+             self._internal = self._internal.copy(scol=scol)
+             return self",nit: `rename` instead of `alias`?
+1233,"@@ -113,11 +113,17 @@ func (d *Driver) freeDevices() (string, string, error) {
+ 		return """", """", err
+ 	}
+ 	devPrefix := ""/dev/sd""
++
+ 	for _, dev := range self.BlockDeviceMappings {
+ 		if dev.DeviceName == nil {
+ 			return """", """", fmt.Errorf(""Nil device name"")
+ 		}
+ 		devName := *dev.DeviceName
++
++		// sda1 is reserved for the root device, skip
++		if devName == ""/dev/sda1"" {
++			continue
++		}
+ 		if !strings.HasPrefix(devName, devPrefix) {
+ 			devPrefix = ""/dev/xvd""
+ 			if !strings.HasPrefix(devName, devPrefix) {",Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped.
+1234,"@@ -92,7 +92,6 @@ func (q *ChannelEventQueue) dispatchMessage() {
+ 		event := model.MessageToEvent(&msg)
+ 		select {
+ 		case rChannel <- event:
+-		default:
+ 		}
+ 	}
+ }","I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?"
+1235,"@@ -539,11 +539,12 @@ class EAP_MD5(EAP):
+         ByteEnumField(""code"", 1, eap_codes),
+         ByteField(""id"", 0),
+         FieldLenField(""len"", None, fmt=""H"", length_of=""optional_name"",
+-                      adjust=lambda p, x: x + p.value_size + 6),
++                adjust=lambda p, x: (x + p.value_size + 6) if p.value_size is not None else 6),
+         ByteEnumField(""type"", 4, eap_types),
+-        FieldLenField(""value_size"", 0, fmt=""B"", length_of=""value""),
++        FieldLenField(""value_size"", None, fmt=""B"", length_of=""value""),
+         XStrLenField(""value"", '', length_from=lambda p: p.value_size),
+-        XStrLenField(""optional_name"", '', length_from=lambda p: p.len - p.value_size - 6)
++        XStrLenField(""optional_name"", '',
++                length_from=lambda p: (p.len - p.value_size - 6) if p.len is not None and p.value_size is not None else 0)
+     ]
+
+ ","Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`."
+1236,"@@ -238,6 +238,10 @@ type Container struct {
+
+ 	Secrets []*Secret `locationName:""secrets"" type:""list""`
+
++	StartTimeout *int64 `locationName:""startTimeout"" type:""integer""`
++
++	StopTimeout *int64 `locationName:""stopTimeout"" type:""integer""`
++
+ 	VolumesFrom []*VolumeFrom `locationName:""volumesFrom"" type:""list""`
+ }
+ ",Can we make sure ECS service treats it as int64 as well?
+1237,"@@ -178,6 +178,15 @@ class UIProperty(UIA):
+ 			return value
+ 		return value.replace(CHAR_LTR_MARK,'').replace(CHAR_RTL_MARK,'')
+
++class ReadOnlyEditBox(IAccessible):
++#Used for read-only edit boxes in a properties window.
++#These can contain dates that include unwanted left-to-right and right-to-left indicator characters.
++
++	def _get_windowText(self):
++		WindowText = super(ReadOnlyEditBox, self).windowText
++		if  WindowText  is not None and controlTypes.STATE_READONLY in self.states:
++			return WindowText.replace(CHAR_LTR_MARK,'').replace(CHAR_RTL_MARK,'')
++		return WindowText
+
+ class AppModule(appModuleHandler.AppModule):
+ ","Please follow the naming convention for variables, i.e. `windowText`."
+1238,"@@ -21,8 +21,8 @@ import (
+
+ 	yaml ""github.com/ghodss/yaml""
+ 	""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
++	castv1alpha1 ""github.com/openebs/maya/pkg/castemplate/v1alpha1""
+ 	m_k8s_client ""github.com/openebs/maya/pkg/client/k8s""
+-	""github.com/openebs/maya/pkg/engine""
+ 	menv ""github.com/openebs/maya/pkg/env/v1alpha1""
+ 	""github.com/pkg/errors""
+ 	v1_storage ""k8s.io/api/storage/v1""",alias can be `cast`
+1239,"@@ -97,13 +97,14 @@ static h2o_iovec_t events_status_final(void *priv, h2o_globalconf_t *gconf, h2o_
+                        "" \""http2-errors.inadequate-security\"": %"" PRIu64 "", \n""
+                        "" \""http2.read-closed\"": %"" PRIu64 "", \n""
+                        "" \""http2.write-closed\"": %"" PRIu64 "", \n""
+-                       "" \""ssl.errors\"": %"" PRIu64 ""\n"",
++                       "" \""ssl.errors\"": %"" PRIu64 "", \n""
++                       "" \""memory.mmap_errors\"": %"" PRIu64 ""\n"",
+                        H1_AGG_ERR(400), H1_AGG_ERR(403), H1_AGG_ERR(404), H1_AGG_ERR(405), H1_AGG_ERR(416), H1_AGG_ERR(417),
+                        H1_AGG_ERR(500), H1_AGG_ERR(502), H1_AGG_ERR(503), H2_AGG_ERR(PROTOCOL), H2_AGG_ERR(INTERNAL),
+                        H2_AGG_ERR(FLOW_CONTROL), H2_AGG_ERR(SETTINGS_TIMEOUT), H2_AGG_ERR(STREAM_CLOSED), H2_AGG_ERR(FRAME_SIZE),
+                        H2_AGG_ERR(REFUSED_STREAM), H2_AGG_ERR(CANCEL), H2_AGG_ERR(COMPRESSION), H2_AGG_ERR(CONNECT),
+                        H2_AGG_ERR(ENHANCE_YOUR_CALM), H2_AGG_ERR(INADEQUATE_SECURITY), esc->h2_read_closed, esc->h2_write_closed,
+-                       esc->ssl_errors);
++                       esc->ssl_errors, (uint64_t)mmap_errors);
+     pthread_mutex_destroy(&esc->mutex);
+     free(esc);
+     return ret;","Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`."
+1240,"@@ -57,7 +57,7 @@ import javax.lang.model.element.Name;
+         name = ""CatchSpecificity"",
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+-        severity = BugPattern.SeverityLevel.SUGGESTION,
++        severity = BugPattern.SeverityLevel.WARNING,
+         summary = ""Prefer more specific error types than Exception and Throwable. When methods are updated to throw new""
+                 + "" checked exceptions they expect callers to handle failure types explicitly. Catching broad""
+                 + "" types defeats the type system. By catching the most specific types possible we leverage""",I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?
+1241,"@@ -72,7 +72,7 @@ class CppGenerator : public BaseGenerator {
+     }
+     for (auto it = parser_.included_files_.begin();
+          it != parser_.included_files_.end(); ++it) {
+-      auto noext = flatbuffers::StripExtension(it->first);
++      auto noext = flatbuffers::StripExtension(it->second);
+       auto basename = flatbuffers::StripPath(noext);
+       if (basename != file_name_) {
+         code_ += ""#include \"""" + parser_.opts.include_prefix +",This should now be made into `if (it->second.empty())` ?
+1242,"@@ -126,13 +126,19 @@ class WebEngineSearch(browsertab.AbstractSearch):
+     def __init__(self, parent=None):
+         super().__init__(parent)
+         self._flags = QWebEnginePage.FindFlags(0)
++        self.num_of_searches = 0
+
+     def _find(self, text, flags, callback, caller):
+         """"""Call findText on the widget.""""""
+         self.search_displayed = True
++        self.num_of_searches += 1
+
+         def wrapped_callback(found):
+             """"""Wrap the callback to do debug logging.""""""
++            self.num_of_searches -= 1
++            if self.num_of_searches > 0:
++                return
++
+             found_text = 'found' if found else ""didn't find""
+             if flags:
+                 flag_text = 'with flags {}'.format(debug.qflags_key(","Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about."
+1243,"@@ -100,7 +100,7 @@ func TestMultiplePropagators(t *testing.T) {
+ 	// generates the valid span context out of thin air
+ 	{
+ 		ctx := ootaProp.Extract(bg, ns)
+-		sc := trace.RemoteSpanContextFromContext(ctx)
++		sc := trace.SpanContextFromContext(ctx)
+ 		require.True(t, sc.IsValid(), ""oota prop failed sanity check"")
+ 	}
+ 	// sanity check for real propagators, ensuring that they",Should these assert that the extracted `SpanContext` is remote?
+1244,"@@ -27,6 +27,9 @@ class ApproxMaxIoUAssigner(MaxIoUAssigner):
+             ignoring any bboxes.
+         ignore_wrt_candidates (bool): Whether to compute the iof between
+             `bboxes` and `gt_bboxes_ignore`, or the contrary.
++        match_low_quality (bool): Whether to allow quality matches. This is
++            usually allowed for RPN and single stage detectors, but not allowed
++            in the second stage.
+         gpu_assign_thr (int): The upper bound of the number of GT for GPU
+             assign. When the number of gt is above this threshold, will assign
+             on CPU device. Negative values mean not assign on CPU.",typo: allow low quality matches.
+1245,"@@ -49,7 +49,7 @@ func ResolveDataDir(dataDir string) (string, error) {
+ 	return filepath.Join(dataDir, ""server""), err
+ }
+
+-func StartServer(ctx context.Context, config *Config) error {
++func StartServer(ctx context.Context, config *Config, cfg *cmds.Server) error {
+ 	if err := setupDataDirAndChdir(&config.ControlConfig); err != nil {
+ 		return err
+ 	}","At some point we need to condense down and refactor our ""configs"" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference."
+1246,"@@ -39,7 +39,8 @@ module Blacklight
+     def options
+       {
+         class: classes,
+-        ""aria-hidden"": (true if aria_hidden)
++        ""aria-hidden"": (true if aria_hidden),
++        ""aria-label"": icon_label
+       }
+     end
+ ",Can we add the `if label` conditional to this please?
+1247,"@@ -40,6 +40,7 @@ setup(
+     packages=['databricks', 'databricks.koalas', 'databricks.koalas.missing'],
+     extras_require={
+         'spark': ['pyspark>=2.4.0'],
++        'mlflow': ['mlflow>=0.2.0'],
+     },
+     python_requires='>=3.5',
+     install_requires=[","@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow"
+1248,"@@ -669,6 +669,8 @@ const REGISTERED_HOOKS = [
+    * @param {CellRange} sourceRange The range values will be filled from.
+    * @param {CellRange} targetRange The range new values will be filled into.
+    * @param {string} direction Declares the direction of the autofill. Possible values: `up`, `down`, `left`, `right`.
++   * @param {boolean} hasFillDataChanged Indicates whether the original fillData has been changed in
++   *                                     the `beforeAutofill` hook.
+    */
+   'afterAutofill',
+ ","If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?"
+1249,"@@ -37,13 +37,18 @@ from .execution_context import (
+     SystemPipelineExecutionContext,
+ )
+
+-
+ from .errors import DagsterInvariantViolationError
+
+ from .events import construct_event_logger
+
+ from .execution_plan.create import create_execution_plan_core
+
++from .execution_plan.intermediates_manager import (
++    FileSystemIntermediateManager,
++    InMemoryIntermediatesManager,
++    IntermediatesManager,
++)
++
+ from .execution_plan.objects import (
+     ExecutionPlan,
+     ExecutionStepEvent,",`Intermediates` or `Intermediate`
+1250,"@@ -95,6 +95,8 @@ class visibility_of(object):
+
+
+ def _element_if_visible(element, visibility=True):
++    if isinstance(element, str) or isinstance(element, dict):
++           raise StaleElementReferenceException(""Invalid locator"")
+     return element if element.is_displayed() == visibility else False
+
+ ",This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.
+1251,"@@ -52,8 +52,9 @@ func (c *Cluster) Bootstrap(ctx context.Context, snapshot bool) error {
+ 			// instance of etcd in the event that etcd certificates are unavailable,
+ 			// reading the data, and comparing that to the data on disk, all the while
+ 			// starting normal etcd.
+-			isHTTP := c.config.JoinURL != """" && c.config.Token != """"
+-			if isInitialized && !isHTTP {
++			// isHTTP := c.config.JoinURL != """" && c.config.Token != """"
++			if isInitialized {
++				logrus.Info(""Only reconciling with datastore"")
+ 				tmpDataDir := filepath.Join(c.config.DataDir, ""db"", ""tmp-etcd"")
+ 				os.RemoveAll(tmpDataDir)
+ 				if err := os.Mkdir(tmpDataDir, 0700); err != nil {","If this code isn't needed, it should be removed."
+1252,"@@ -145,10 +145,13 @@ func (md *metricsDriver) uploadMetrics(ctx context.Context, protoMetrics []*metr
+ 		if md.metricsClient == nil {
+ 			return errNoClient
+ 		}
+-		_, err := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{
+-			ResourceMetrics: protoMetrics,
+-		})
+-		return err
++		req := func(ctx context.Context) error {
++			_, err := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{
++				ResourceMetrics: protoMetrics,
++			})
++			return err
++		}
++		return doRequest(ctx, req, md.connection.cfg.RetrySettings, md.connection.stopCh)
+ 	}()
+ 	if err != nil {
+ 		md.connection.setStateDisconnected(err)",Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?
+1253,"@@ -99,8 +99,8 @@ var _ = Describe(""init flow"", func() {
+ 			Expect(len(app.Variables)).To(Equal(5))
+ 			expectedVars := map[string]string{
+ 				""ECS_CLI_APP_NAME"":           appName,
+-				""ECS_CLI_ENVIRONMENT_NAME"":   ""test"",
+-				""ECS_CLI_LB_DNS"":             strings.TrimPrefix(app.Routes[0].URL, ""http://""),
++				""COPILOT_ENVIRONMENT_NAME"":   ""test"",
++				""COPILOT_LB_DNS"":             strings.TrimPrefix(app.Routes[0].URL, ""http://""),
+ 				""ECS_CLI_PROJECT_NAME"":       projectName,
+ 				""ECS_APP_DISCOVERY_ENDPOINT"": fmt.Sprintf(""%s.local"", projectName),
+ 			}",we'll probably tackle these e2e tests at the end
+1254,"@@ -0,0 +1,19 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++using BenchmarkDotNet.Attributes;
++using MicroBenchmarks;
++
++namespace System.Net.Tests
++{
++    [BenchmarkCategory(Categories.CoreFX)]
++    public class DnsTests
++    {
++        [Benchmark]
++        public IPHostEntry GetHostEntry() => Dns.GetHostEntry(""34.206.253.53"");
++
++        [Benchmark]
++        public string GetHostName() => Dns.GetHostName();
++    }
++}",what is this address pointing to? what are we measuring here? I want to have a better understanding.
+1255,"@@ -101,7 +101,8 @@ public class JdbcFlowTriggerInstanceLoaderImpl implements FlowTriggerInstanceLoa
+           + ""project_json, flow_exec_id \n""
+           + ""FROM execution_dependencies JOIN (\n""
+           + ""SELECT trigger_instance_id FROM execution_dependencies WHERE trigger_instance_id not in (\n""
+-          + ""SELECT distinct(trigger_instance_id)  FROM execution_dependencies WHERE dep_status =  0 or dep_status = 4)\n""
++          + ""SELECT distinct(trigger_instance_id)  FROM execution_dependencies WHERE dep_status =""
++          + ""  0 or dep_status = 3)\n""
+           + ""GROUP BY trigger_instance_id\n""
+           + ""ORDER BY  min(starttime) desc limit %s) temp on execution_dependencies""
+           + "".trigger_instance_id in (temp.trigger_instance_id);"";","Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here."
+1256,"@@ -1,3 +1,9 @@
++// Copyright 2017 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++// +build windows
++
+ package libdokan
+
+ import (",Hah I had `gorename` failing without this too.
+1257,"@@ -597,6 +597,12 @@ namespace Datadog.Trace
+                     writer.WritePropertyName(""appsec_blocking_enabled"");
+                     writer.WriteValue(Security.Instance.Settings.BlockingEnabled);
+
++                    writer.WritePropertyName(""rules_file_path"");
++                    writer.WriteValue(Security.Instance.Settings.Rules ?? ""(none)"");
++
++                    writer.WritePropertyName(""libddwaf_version"");
++                    writer.WriteValue(Security.Instance.DdlibWafVersion?.ToString() ?? ""(none)"");
++
+                     writer.WriteEndObject();
+                 }
+ ",maybe prefix these with `appsec_` for consistency?
+1258,"@@ -7,11 +7,19 @@ import (
+ 	""crypto/x509""
+ 	""errors""
+ 	""fmt""
++	""github.com/spiffe/spire/pkg/common/profiling""
++	""net/http""
++	_ ""net/http/pprof""
+ 	""net/url""
+ 	""path""
++	""runtime""
++
++	""strconv""
+ 	""sync""
+ 	""syscall""
+
++	_ ""golang.org/x/net/trace""
++
+ 	""github.com/spiffe/spire/pkg/agent/catalog""
+ 	""github.com/spiffe/spire/pkg/agent/endpoints""
+ 	""github.com/spiffe/spire/pkg/agent/manager""",nit: this should be down further with the other github imports
+1259,"@@ -560,6 +560,11 @@ def main():
+ 	else:
+ 		log.debug(""initializing updateCheck"")
+ 		updateCheck.initialize()
++	# If running from source, try to disconnect from the console we may have been executed in.
++	# NVDA may reconnect to read it later,
++	# but it is better to assume we are not connected to anything at the start.
++	if ctypes.windll.kernel32.FreeConsole() != 0:
++		log.debug(""Freed from parent console process."")
+ 	log.info(""NVDA initialized"")
+ 	postNvdaStartup.notify()
+ ",Why is this change necessary or related to the rest of the PR?
+1260,"@@ -31,7 +31,7 @@ class ConsoleReport extends Report
+             $issue_string .= 'INFO';
+         }
+
+-        $issue_reference = $issue_data->link ? ' (see ' . $issue_data->link . ')' : '';
++        $issue_reference = $issue_data->link ? ' - see: ' . $issue_data->link : '';
+
+         $issue_string .= ': ' . $issue_data->type
+             . ' - ' . $issue_data->file_name . ':' . $issue_data->line_from . ':' . $issue_data->column_from","Hm, I wonder if the `see:` prefix is even necessary?"
+1261,"@@ -261,7 +261,13 @@ import 'emby-button';
+
+                 minutes = minutes || 1;
+
+-                miscInfo.push(`${Math.round(minutes)} mins`);
++                if (item.UserData?.PlaybackPositionTicks) {
++                    let remainingMinutes = (item.RunTimeTicks - item.UserData.PlaybackPositionTicks) / 600000000;
++                    remainingMinutes = remainingMinutes || 1;
++                    miscInfo.push(`${Math.round(minutes)} mins (${Math.round(remainingMinutes)} remaining)`);
++                } else {
++                    miscInfo.push(`${Math.round(minutes)} mins`);
++                }
+             }
+         }
+ ",This should be translated.
+1262,"@@ -294,13 +294,15 @@ class Booster {
+   void ResetConfig(const char* parameters) {
+     UNIQUE_LOCK(mutex_)
+     auto param = Config::Str2Map(parameters);
+-    if (param.count(""num_class"")) {
++    Config new_config;
++    new_config.Set(param);
++    if (param.count(""num_class"") && new_config.num_class != config_.num_class) {
+       Log::Fatal(""Cannot change num_class during training"");
+     }
+-    if (param.count(""boosting"")) {
++    if (param.count(""boosting"") && new_config.boosting != config_.boosting) {
+       Log::Fatal(""Cannot change boosting during training"");
+     }
+-    if (param.count(""metric"")) {
++    if (param.count(""metric"") && new_config.metric != config_.metric) {
+       Log::Fatal(""Cannot change metric during training"");
+     }
+     CheckDatasetResetConfig(config_, param);","I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed."
+1263,"@@ -356,9 +356,9 @@ describe 'run_task' do
+
+       is_expected.to run.with_params(task_name, hostname, task_params).and_raise_error(
+         Puppet::ParseError,
+-        /Task\ test::params:\n
++        %r{Task\ test::params:\n
+          \s*has\ no\ parameter\ named\ 'foo'\n
+-         \s*has\ no\ parameter\ named\ 'bar'/x
++         \s*has\ no\ parameter\ named\ 'bar'}x
+       )
+     end
+ ","These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals."
+1264,"@@ -1564,7 +1564,7 @@ func (r *ReconcileClusterDeployment) mergePullSecrets(cd *hivev1.ClusterDeployme
+ 	globalPullSecretName := os.Getenv(constants.GlobalPullSecret)
+ 	var globalPullSecret string
+ 	if len(globalPullSecretName) != 0 {
+-		globalPullSecret, err = controllerutils.LoadSecretData(r.Client, globalPullSecretName, constants.HiveNamespace, corev1.DockerConfigJsonKey)
++		globalPullSecret, err = controllerutils.LoadSecretData(r.Client, globalPullSecretName, controllerutils.GetHiveNamespace(), corev1.DockerConfigJsonKey)
+ 		if err != nil {
+ 			return """", errors.Wrap(err, ""global pull secret could not be retrieved"")
+ 		}",Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand.
+1265,"@@ -23,11 +23,13 @@ class TestKinesis(unittest.TestCase):
+
+         # create stream and assert 0 consumers
+         client.create_stream(StreamName=stream_name, ShardCount=1)
++        sleep(1)
+         assert_consumers(0)
+
+         # create consumer and assert 1 consumer
+         consumer_name = 'cons1'
+         response = client.register_stream_consumer(StreamARN=stream_arn, ConsumerName=consumer_name)
++        sleep(1)
+         self.assertEqual(response['Consumer']['ConsumerName'], consumer_name)
+         # boto3 converts the timestamp to datetime
+         self.assertTrue(isinstance(response['Consumer']['ConsumerCreationTimestamp'], datetime))",kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here.
+1266,"@@ -145,13 +145,8 @@ std::unique_ptr<nebula::kvstore::KVStore> initKV(std::vector<nebula::HostAddr> p
+     LOG(ERROR) << ""Meta version is invalid"";
+     return nullptr;
+   } else if (version == nebula::meta::MetaVersion::V1) {
+-    auto ret = nebula::meta::MetaVersionMan::updateMetaV1ToV2(engine);
+-    if (!ret.ok()) {
+-      LOG(ERROR) << ""Update meta from V1 to V2 failed "" << ret;
+-      return nullptr;
+-    }
+-
+-    nebula::meta::MetaVersionMan::setMetaVersionToKV(engine, nebula::meta::MetaVersion::V2);
++    LOG(ERROR) << ""Can't upgrade meta from V1 to V3"";
++    return nullptr;
+   } else if (version == nebula::meta::MetaVersion::V2) {
+     auto ret = nebula::meta::MetaVersionMan::updateMetaV2ToV3(engine);
+     if (!ret.ok()) {",Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?
+1267,"@@ -26,7 +26,7 @@ func (repo *nodeAttestorRepository) Constraints() catalog.Constraints {
+ }
+
+ func (repo *nodeAttestorRepository) Versions() []catalog.Version {
+-	return []catalog.Version{nodeAttestorV0{}}
++	return []catalog.Version{nodeAttestorV1{}}
+ }
+
+ func (repo *nodeAttestorRepository) LegacyVersion() (catalog.Version, bool) {","I think that V0 is missing here, which will prevent plugins that haven't been converted to work."
+1268,"@@ -4,6 +4,7 @@ const withBundleAnalyzer = require(""@next/bundle-analyzer"")({
+ })
+
+ module.exports = withBundleAnalyzer({
++  // sitemap: () => [{uri: ""/wow"", type: ""pages"", verb: ""get""}],
+   middleware: [
+     sessionMiddleware({
+       unstable_isAuthorized: unstable_simpleRolesIsAuthorized,",Should we remove this?
+1269,"@@ -6,12 +6,14 @@ import (
+
+ 	""go.uber.org/zap""
+
++	""github.com/docker/distribution/reference""
+ 	""github.com/docker/docker/api/types""
+ 	""github.com/docker/docker/api/types/container""
+ 	""github.com/docker/docker/api/types/network""
+ 	""github.com/docker/docker/client""
+ 	""github.com/gliderlabs/ssh""
+ 	log ""github.com/noxiouz/zapctx/ctxlog""
++	""io""
+ )
+
+ type containerDescriptor struct {",Put on top of the import.
+1270,"@@ -46,6 +46,7 @@ domReady( () => {
+ 	Modules.registerModule(
+ 		'analytics',
+ 		{
++			name: 'Analytics',
+ 			settingsEditComponent: SettingsEdit,
+ 			settingsViewComponent: SettingsView,
+ 			setupComponent: SetupMain,","See above, this shouldn't be added."
+1271,"@@ -505,8 +505,8 @@ public enum ItemMapping
+ 	ITEM_ANGUISH_ORNAMENT_KIT(ANGUISH_ORNAMENT_KIT, NECKLACE_OF_ANGUISH_OR),
+ 	ITEM_OCCULT_NECKLACE(OCCULT_NECKLACE, OCCULT_NECKLACE_OR),
+ 	ITEM_OCCULT_ORNAMENT_KIT(OCCULT_ORNAMENT_KIT, OCCULT_NECKLACE_OR),
+-	ITE_AMULET_OF_FURY(AMULET_OF_FURY, AMULET_OF_FURY_OR),
+-	ITE_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR),
++	ITEM_AMULET_OF_FURY(AMULET_OF_FURY, AMULET_OF_FURY_OR),
++	ITEM_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR),
+
+ 	// Ensouled heads
+ 	ITEM_ENSOULED_GOBLIN_HEAD(ENSOULED_GOBLIN_HEAD_13448, ENSOULED_GOBLIN_HEAD),","This'll likely get fixed upstream, we should let them deal with it."
+1272,"@@ -93,6 +93,7 @@ type Options struct {
+ 	LightNodeLimit int
+ 	WelcomeMessage string
+ 	Transaction    []byte
++	HostFactory    func(context.Context, ...libp2p.Option) (host.Host, error)
+ }
+
+ func New(ctx context.Context, signer beecrypto.Signer, networkID uint64, overlay swarm.Address, addr string, ab addressbook.Putter, storer storage.StateStorer, lightNodes *lightnode.Container, swapBackend handshake.SenderMatcher, logger logging.Logger, tracer *tracing.Tracer, o Options) (*Service, error) {","Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval."
+1273,"@@ -111,6 +111,18 @@ class Time {
+ 	sleep(seconds) {
+ 		return this.msleep(seconds * 1000);
+ 	}
++
++
++	goBackInTime(n, timeDuration) {
++		// Note that we are starting from the first ms of the current timeDuration
++		// eg. If we go back by one day we are subtracting (24*60*60*1000) ms from the start ms of today
++		return moment().startOf(timeDuration).subtract(n, timeDuration).format('x');
++	}
++
++	goForwardInTime(n, timeDuration) {
++		return moment().startOf(timeDuration).add(n, timeDuration).format('x');
++	}
++
+ }
+
+ const time = new Time();","As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is ""n"" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be ""day"", ""hours"", etc. but from your example it seems to be milliseconds)."
+1274,"@@ -71,7 +71,11 @@ class AppModule(appModuleHandler.AppModule):
+ 			ui.message(_(""No track playing""))
+ 		return elapsedAndTotalTime
+
+-	def script_reportRemainingTime(self,gesture):
++	def script_reportRemainingTime(self, gesture):
++		import config
++		from languageHandler import setLanguage
++		lang = config.conf[""general""][""language""]
++		setLanguage(lang)
+ 		elapsedTime, totalTime = self.getElapsedAndTotalIfPlaying()
+ 		if elapsedTime is None or totalTime is None:
+ 			# Translators: Reported if the remaining time can not be calculated in Foobar2000","Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage."
+1275,"@@ -276,7 +276,7 @@ var _ = Describe(""Application deployment in edge_core Testing"", func() {
+ 		It(""TC_TEST_APP_DEPLOYMENT_16: Test application deployment with container network configuration as port mapping"", func() {
+ 			//Generate the random string and assign as a UID
+ 			UID = ""deployment-app-"" + edge.GetRandomString(10)
+-			port := []v1.ContainerPort{{HostPort: 10255, ContainerPort: 10255, Protocol: v1.ProtocolTCP, HostIP: ""127.0.0.1""}}
++			port := []v1.ContainerPort{{HostPort: 10256, ContainerPort: 10256, Protocol: v1.ProtocolTCP, HostIP: ""127.0.0.1""}}
+ 			IsAppDeployed := HandleAddAndDeletePods(http.MethodPut, ctx.Cfg.TestManager+AppHandler, UID, []v1.Container{{Name: UID, Image: ctx.Cfg.AppImageUrl[0], Ports: port, ImagePullPolicy: v1.PullIfNotPresent}}, v1.RestartPolicyOnFailure)
+ 			Expect(IsAppDeployed).Should(BeTrue())
+ 			CheckPodRunningState(ctx.Cfg.EdgedEndpoint+AppHandler, UID)",why is this changed ?
+1276,"@@ -182,8 +182,9 @@ func (l *ActionList) Get(doc Document, fps ...FieldPath) *ActionList {
+ // mod ""a.b"": 2, then either Update will fail, or it will succeed with the result
+ // {a: {b: 2}}.
+ //
+-// Update does not modify its doc argument. To obtain the new value of the document,
+-// call Get after calling Update.
++// Update does not modify its doc argument, except to set the new revision. To obtain
++// the new value of the document, call Get after calling Update.
++// TODO(jba): test that doc's revision field is updated.
+ func (l *ActionList) Update(doc Document, mods Mods) *ActionList {
+ 	return l.add(&Action{
+ 		kind: driver.Update,","Should this be ""the new revision value""?"
+1277,"@@ -13,7 +13,7 @@
+
+ return [
+     'accepted'             => ':attribute må aksepteres.',
+-    'accepted_if'          => 'The :attribute must be accepted when :other is :value.',
++    'accepted_if'          => 'Dette feltet må aksepteres når :other er :value.',
+     'active_url'           => ':attribute er ikke en gyldig URL.',
+     'after'                => ':attribute må være en dato etter :date.',
+     'after_or_equal'       => ':attribute må være en dato etter eller lik :date.',",You have deleted :attribute
+1278,"@@ -1,12 +1,11 @@
+ /*
+- * Licensed to the Apache Software Foundation (ASF) under one or more
+- * contributor license agreements.  See the NOTICE file distributed with
+- * this work for additional information regarding copyright ownership.
+- * The ASF licenses this file to You under the Apache License, Version 2.0
+- * (the ""License""); you may not use this file except in compliance with
+- * the License.  You may obtain a copy of the License at
++ * Copyright 2017 Huawei Technologies Co., Ltd
+  *
+- *     http://www.apache.org/licenses/LICENSE-2.0
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *    http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an ""AS IS"" BASIS,",The license header should be updated to the Apache one.
+1279,"@@ -22,6 +22,10 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+         [Trait(""RunOnWindows"", ""True"")]
+         public void HttpClient()
+         {
++            int expectedSpanCount = EnvironmentHelper.IsCoreClr() ? 2 : 1;
++            const string expectedOperationName = ""http.request"";
++            const string expectedServiceName = ""Samples.HttpMessageHandler-http-client"";
++
+             int agentPort = TcpPortProvider.GetOpenPort();
+             int httpPort = TcpPortProvider.GetOpenPort();
+ ",@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?
+1280,"@@ -883,3 +883,17 @@ instr_is_exclusive_store(instr_t *instr)
+     return (opcode == OP_strex || opcode == OP_strexb || opcode == OP_strexd ||
+             opcode == OP_strexh);
+ }
++
++DR_API
++bool
++instr_is_scatter(instr_t *instr)
++{
++    return false;
++}
++
++DR_API
++bool
++instr_is_gather(instr_t *instr)
++{
++    return false;
++}",Not sure about this one -- did you check somehow?
+1281,"@@ -157,8 +157,15 @@ module Beaker
+         @options = @options.merge(env_vars)
+
+         if @options.is_pe?
+-          @options['pe_ver']           = Beaker::Options::PEVersionScraper.load_pe_version(@options[:pe_dir], @options[:pe_version_file])
+-          @options['pe_ver_win']       = Beaker::Options::PEVersionScraper.load_pe_version(@options[:pe_dir], @options[:pe_version_file_win])
++          @options['HOSTS'].each_key do |name, val|
++            if @options['HOSTS'][name]['platform'] =~ /windows/
++              @options['HOSTS'][name]['pe_ver_win'] = @options['HOSTS'][name]['pe_ver_win'] || Beaker::Options::PEVersionScraper.load_pe_version(
++                                   @options['HOSTS'][name][:pe_dir] || @options[:pe_dir], @options[:pe_version_file_win])
++            else
++              @options['HOSTS'][name]['pe_ver'] = @options['HOSTS'][name]['pe_ver'] || Beaker::Options::PEVersionScraper.load_pe_version(
++                                   @options['HOSTS'][name][:pe_dir] || @options[:pe_dir], @options[:pe_version_file])
++            end
++          end
+         else
+           @options['puppet_ver']       = @options[:puppet]
+           @options['facter_ver']       = @options[:facter]",Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?
+1282,"@@ -97,7 +97,9 @@ public class ProductActivity extends BaseActivity {
+         String[] menuTitles = getResources().getStringArray(R.array.nav_drawer_items_product);
+
+         ProductFragmentPagerAdapter adapterResult = new ProductFragmentPagerAdapter(getSupportFragmentManager());
+-        adapterResult.addFragment(new SummaryProductFragment(), menuTitles[0]);
++        SummaryProductFragment summaryProductFragment = new SummaryProductFragment();
++
++        adapterResult.addFragment(summaryProductFragment, menuTitles[0]);
+         adapterResult.addFragment(new IngredientsProductFragment(), menuTitles[1]);
+         adapterResult.addFragment(new NutritionProductFragment(), menuTitles[2]);
+         adapterResult.addFragment(new NutritionInfoProductFragment(), menuTitles[3]);","Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients"
+1283,"@@ -119,9 +119,6 @@ type StressInstance struct {
+ 	// UID is the instance identifier
+ 	// +optional
+ 	UID string `json:""uid""`
+-	// StartTime specifies when the instance starts
+-	// +optional
+-	StartTime *metav1.Time `json:""startTime""`
+ }
+
+ // GetDuration gets the duration of StressChaos",Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused.
+1284,"@@ -489,6 +489,10 @@ module Beaker
+             end
+
+           rescue Exception => teardown_exception
++            if !host.is_pe?
++              dump_puppet_log(host)
++            end
++
+             if original_exception
+               logger.error(""Raised during attempt to teardown with_puppet_running_on: #{teardown_exception}\n---\n"")
+               raise original_exception","My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception."
+1285,"@@ -53,10 +53,11 @@ static infer_result<task::classification> call_daal_kernel(
+
+     const std::int64_t dummy_seed = 777;
+     const auto data_use_in_model = daal_knn::doNotUse;
+-    daal_knn::Parameter daal_parameter(desc.get_class_count(),
+-                                       desc.get_neighbor_count(),
+-                                       dummy_seed,
+-                                       data_use_in_model);
++    daal_knn::Parameter daal_parameter(
++        dal::detail::integral_cast<size_t>(desc.get_class_count()),
++        dal::detail::integral_cast<size_t>(desc.get_neighbor_count()),
++        dal::detail::integral_cast<int>(dummy_seed),
++        data_use_in_model);
+
+     interop::status_to_exception(interop::call_daal_kernel<Float, daal_knn_kd_tree_kernel_t>(
+         ctx,",Should it be `int64_t`?
+1286,"@@ -26,10 +26,14 @@ import java.util.concurrent.TimeUnit;
+
+ import com.google.common.base.Stopwatch;
+ import org.apache.logging.log4j.Logger;
++import org.apache.tuweni.bytes.Bytes;
++import org.apache.tuweni.concurrent.ExpiringMap;
+ import org.apache.tuweni.units.bigints.UInt256;
+
+ public class PoWSolver {
+
++  private static final long POW_JOB_TTL = 1000 * 60 * 5; // 5 minutes
++  private static final int MAX_OMMER_DEPTH = 8;
+   private static final Logger LOG = getLogger();
+
+   public static class PoWSolverJob {",is this value related to something ?
+1287,"@@ -23,6 +23,6 @@ namespace Nethermind.TxPool
+ {
+     public interface ITxSender
+     {
+-        ValueTask<Keccak?> SendTransaction(Transaction tx, TxHandlingOptions txHandlingOptions);
++        ValueTask<(Keccak?, AddTxResult?)> SendTransaction(Transaction tx, TxHandlingOptions txHandlingOptions);
+     }
+ }","Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?"
+1288,"@@ -136,6 +136,7 @@ public class Name {
+   private String toUnderscore(CaseFormat caseFormat) {
+     List<String> newPieces = new ArrayList<>();
+     for (NamePiece namePiece : namePieces) {
++      namePiece = replaceAcronyms(namePiece);
+       newPieces.add(namePiece.caseFormat.to(caseFormat, namePiece.identifier));
+     }
+     return Joiner.on('_').join(newPieces);",I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings.
+1289,"@@ -53,7 +53,7 @@ public class TypeTest {
+         assertTrue(type.isArrayType());
+         ArrayType arrayType = type.asArrayType();
+         final ArrayType[] s = new ArrayType[1];
+-        type.ifArrayType(t -> s[0] = t);
++        type.ifArrayType(t -> s[0] = (ArrayType)t);
+         assertNotNull(s[0]);
+     }
+ }",Huh? The point is that a cast isn't necessary
+1290,"@@ -35,4 +35,12 @@ const (
+ 	//
+ 	// Default is ""true""
+ 	CreateDefaultStorageConfig menv.ENVKey = ""OPENEBS_IO_CREATE_DEFAULT_STORAGE_CONFIG""
++
++	// InstallCRD is the environment
++	// variable that flags if maya apiserver should install the CRDs
++	// As the installation moves towards helm 3, the responsibility of installing
++	// CRDs can be pushed to helm.
++	//
++	// Default is ""true""
++	InstallCRD menv.ENVKey = ""OPENEBS_IO_INSTALL_CRD""
+ )",can we name it like `InstallV1Alpha1CRDs` ?
+1291,"@@ -79,6 +79,7 @@ const (
+ 	deleteAfterAnnotation      = ""hive.openshift.io/delete-after""
+ 	tryInstallOnceAnnotation   = ""hive.openshift.io/try-install-once""
+ 	tryUninstallOnceAnnotation = ""hive.openshift.io/try-uninstall-once""
++	hiveutilCreatedLabel       = ""hive.openshift.io/hiveutil-created""
+ 	cloudAWS                   = ""aws""
+ 	cloudAzure                 = ""azure""
+ 	cloudGCP                   = ""gcp""",I need something to match when creating selectorsyncsets so added this label.
+1292,"@@ -47,7 +47,9 @@ module RSpec
+         return nil if line == '-e:1'.freeze
+         line
+       rescue SecurityError
++        # :nocov:
+         nil
++        # :nocov:
+       end
+
+       # @private","Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose."
+1293,"@@ -1,11 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to add a cross-origin resource sharing (CORS)
++# configuration containing a single rule to an Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.s3_ruby_bucket_cors.rb]
++
+ require 'aws-sdk-s3'
+
+-# Adds a cross-origin resource sharing (CORS) configuration containing
+-#   a single rule to an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - An Amazon S3 bucket.",Simple Storage **Service**
+1294,"@@ -471,6 +471,9 @@ func (r *Repository) LoadIndex(ctx context.Context) error {
+ 		return err
+ 	}
+
++	// remove obsolete indexes
++	validIndex.Sub(r.idx.Obsolete())
++
+ 	// remove index files from the cache which have been removed in the repo
+ 	return r.PrepareCache(validIndex)
+ }",Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository.
+1295,"@@ -0,0 +1,19 @@
++class FeedbackController < ApplicationController
++  # note that index is rendered implicitly as it's just a template
++
++  def create
++    message = []
++    [:bug, :context, :expected, :actually, :comments, :satisfaction, :referral].each do |key|
++      if !params[key].blank?
++        message << ""#{key}: #{params[key]}""
++      end
++    end
++    message = message.join(""\n"")
++    if !message.blank?
++      if current_user
++        message += ""\nuser: #{current_user.email_address}""
++      end
++      CommunicartMailer.feedback(message).deliver
++    end
++  end
++end",We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker.
+1296,"@@ -1482,7 +1482,9 @@ Blockly.WorkspaceSvg.prototype.updateToolbox = function(tree) {
+     this.options.languageTree = tree;
+     this.flyout_.show(tree.childNodes);
+   }
+-  this.toolbox_.position();
++  if (this.toolbox_) {
++    this.toolbox_.position();
++  }
+ };
+
+ /**","move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox."
+1297,"@@ -364,10 +364,10 @@ namespace pwiz.Skyline.EditUI
+                             var peptideDocNode = tuple.Item2;
+                             HashSet<Protein> proteins = new HashSet<Protein>();
+                             var peptideGroupDocNode = PeptideGroupDocNodes.First(g => ReferenceEquals(g.PeptideGroup, peptideGroup));
+-                            List<Protein> proteinsForSequence;
+-                            if (sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out proteinsForSequence))
++                            // ReSharper disable once ConditionIsAlwaysTrueOrFalse
++                            if (peptideGroupDocNode != null)
+                             {
+-                                if (peptideGroupDocNode != null)
++                                if (sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out var proteinsForSequence))
+                                 {
+                                     foreach (var protein in proteinsForSequence)
+                                     {","Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?"
+1298,"@@ -17,7 +17,9 @@ var fetch = {},
+     _ = require('underscore'),
+     crypto = require('crypto'),
+     usage = require('./usage.js'),
+-    plugins = require('../../../plugins/pluginManager.js');
++    STATUS_MAP = require('../jobs/job').STATUS_MAP,
++    plugins = require('../../../plugins/pluginManager.js'),
++    countlyDb = plugins.dbConnection();
+
+ /**
+ * Prefetch event data, either by provided key or first event in the list and output result to browser","Let's not create new connection, but rather user `common.db` one"
+1299,"@@ -0,0 +1,11 @@
++module OpenGraphHelper
++  def open_graph_tags
++    tag('meta', property: 'og:image', content: image_url('learn/learn-ralph.png'))
++  end
++
++  private
++
++  def image_url(filename)
++    URI.join(root_url, image_path(filename))
++  end
++end",Can this use asset_path rather than defining an image_url helper?
+1300,"@@ -0,0 +1,19 @@
++import { always } from 'ramda';
++
++/**
++ * A function that returns empty string.
++ *
++ * @func stubString
++ * @memberOf RA
++ * @since {@link https://char0n.github.io/ramda-adjunct/2.1.0|v2.1.0}
++ * @category Function
++ * @sig ... -> ''
++ * @return {''}
++ * @example
++ *
++ * RA.stubString(); //=> ''
++ * RA.stubString(1, 2, 3); //=> ''
++ */
++const stubString = always('');
++
++export default stubString;",Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that
+1301,"@@ -61,3 +61,11 @@ type Priority struct {
+ 	PolicyPriority float64
+ 	RulePriority   int32
+ }
++
++// OFPolicyRule groups all configurations that the openflow module needs to install flow for PolicyRule.
++type OFPolicyRule struct {
++	OfID        uint32
++	OfRule      *PolicyRule
++	NpName      string
++	NpNamespace string
++}","Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName.."
+1302,"@@ -485,9 +485,13 @@ class Functions
+
+             // bcmath
+             'bcscale',
+-
++
+             // json
+             'json_last_error',
++
++            // opcache
++            'opcache_compile_file', 'opcache_get_configuration', 'opcache_get_status',
++            'opcache_invalidate', 'opcache_is_script_cached', 'opcache_reset',
+         ];
+
+         if (\in_array(strtolower($function_id), $impure_functions, true)) {","I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?"
+1303,"@@ -127,6 +127,10 @@ class StepDelegatingExecutor(Executor):
+                     running_steps[step.key] = step
+
+             last_check_step_health_time = pendulum.now(""UTC"")
++
++            # Order of events is important here. During an interation, we call handle_event, then get_steps_to_execute,
++            # then is_complete. get_steps_to_execute updates the state of ActiveExecution, and without it
++            # is_complete can return true when we're just between steps.
+             while not active_execution.is_complete:
+
+                 if active_execution.check_for_interrupts():",Could also consider modifying the ActiveExecution...
+1304,"@@ -1522,3 +1522,19 @@ def get_iterating_dictionary_name(
+         return node.iter.as_string()
+
+     return None
++
++
++def get_subscript_const_value(node: astroid.Subscript) -> astroid.Const:
++    """"""
++    Returns the value (subscript.slice) of a Subscript node,
++    also supports python <3.9 windows where node.slice might be an Index
++    node
++    """"""
++    value = node.slice
++    if isinstance(value, astroid.Index):
++        value = value.value
++    inferred = safe_infer(value)
++    if not isinstance(inferred, astroid.Const):
++        raise ValueError(""Subscript.slice cannot be inferred as an astroid.Const"")
++
++    return inferred",Does it make sense to change that to a custom error instead of `ValueError`?
+1305,"@@ -259,7 +259,7 @@ func (vm *VM) ApplyTipSetMessages(blocks []interpreter.BlockMessagesInfo, head b
+
+ 		// Pay block reward.
+ 		// Dragons: missing final protocol design on if/how to determine the nominal power
+-		rewardMessage := makeBlockRewardMessage(blk.Miner, minerPenaltyTotal, minerGasRewardTotal, blk.TicketCount)
++		rewardMessage := makeBlockRewardMessage(blk.Miner, minerPenaltyTotal, minerGasRewardTotal, 1)
+ 		if _, err := vm.applyImplicitMessage(rewardMessage, rnd); err != nil {
+ 			return nil, err
+ 		}",I guess this will need to change soon.
+1306,"@@ -37,10 +37,9 @@ import (
+ // The header directive goes second so that headers
+ // can be manipulated before doing redirects.
+ var directiveOrder = []string{
++	""map"",
+ 	""root"",
+-
+ 	""header"",
+-
+ 	""redir"",
+ 	""rewrite"",
+ ",Restore this spacing - not sure why it has to be removed?
+1307,"@@ -16,7 +16,10 @@
+
+ // clang-format off
+ // Dont't remove `format off`, it prevent reordering of win-includes.
+-#define _POSIX_C_SOURCE 200112L // For stat from stat/stat.h and fseeko() (POSIX extensions).
++
++#  define _XOPEN_SOURCE 700L
++#  define _POSIX_C_SOURCE 200809L
++
+ #ifdef _WIN32
+ #  ifndef WIN32_LEAN_AND_MEAN
+ #    define WIN32_LEAN_AND_MEAN","These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?"
+1308,"@@ -504,7 +504,7 @@ SubPlan GoPlanner::mToNStepsPlan(SubPlan& startVidPlan) {
+   }
+
+   const auto& projectInput =
+-      (joinInput || joinDst) ? loopBody->outputVar() : sampleLimit->outputVar();
++      (loopBody != getDst) ? loopBody->outputVar() : sampleLimit->outputVar();
+   loopBody = Project::make(qctx, loopBody, goCtx_->yieldExpr);
+   loopBody->setInputVar(projectInput);
+   loopBody->setColNames(std::move(goCtx_->colNames));",Why not delete these codes?
+1309,"@@ -112,7 +112,7 @@ bool StorageServer::start() {
+     metaClient_ = std::make_unique<meta::MetaClient>(ioThreadPool_,
+                                                      metaAddrs_,
+                                                      options);
+-    if (!metaClient_->waitForMetadReady()) {
++    if (!metaClient_->waitForMetadReady(FLAGS_meta_client_retry_times)) {
+         LOG(ERROR) << ""waitForMetadReady error!"";
+         return false;
+     }","If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data."
+1310,"@@ -7,7 +7,7 @@
+ import pytest
+ import random
+ import datatable as dt
+-from datatable import f, stype, ltype
++from datatable import f, stype, ltype, first, count
+ from tests import list_equals
+
+ ",looks like you don't need to import first and count here anymore
+1311,"@@ -2511,6 +2511,18 @@ func (e *historyEngineImpl) NotifyNewTransferTasks(
+ 	}
+ }
+
++func (e *historyEngineImpl) NotifyNewVisibilityTasks(
++	tasks []persistence.Task,
++) {
++
++	if len(tasks) > 0 {
++		// TODO (alex): add visibility processor
++		// task := tasks[0]
++		// clusterName := e.clusterMetadata.ClusterNameForFailoverVersion(task.GetVersion())
++		// e.visibilityProcessor.NotifyNewTask(clusterName, tasks)
++	}
++}
++
+ func (e *historyEngineImpl) NotifyNewReplicationTasks(
+ 	tasks []persistence.Task,
+ ) {","FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint"
+1312,"@@ -36,6 +36,8 @@ import org.springframework.http.HttpMethod;
+ import org.springframework.http.ResponseEntity;
+ import org.springframework.web.client.RestTemplate;
+
++import com.netflix.config.DynamicPropertyFactory;
++
+ public class SpringmvcClient {
+   private static RestTemplate templateUrlWithServiceName = new CseRestTemplate();
+ ",This import can be removed.
+1313,"@@ -48,6 +48,10 @@ func ParseResource(s string, resParser ResourceParser) (resARN Resource, err err
+ 		return nil, InvalidARNError{ARN: a, Reason: ""service is not supported""}
+ 	}
+
++	if strings.HasPrefix(a.Region, ""fips-"") || strings.HasSuffix(a.Region, ""-fips"") {
++		return nil, InvalidARNError{ARN: a, Reason: ""FIPS region not allowed in ARN""}
++	}
++
+ 	if len(a.Resource) == 0 {
+ 		return nil, InvalidARNError{ARN: a, Reason: ""resource not set""}
+ 	}","1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?"
+1314,"@@ -8,10 +8,14 @@ name of the service that is used by Boto 3.
+ This factory is used by the make_stubber fixture found in the set of common fixtures.
+ """"""
+
+-from test_tools.s3_stubber import S3Stubber
+ from test_tools.dynamodb_stubber import DynamoStubber
++from test_tools.iam_stubber import IamStubber
++from test_tools.lambda_stubber import LambdaStubber
+ from test_tools.pinpoint_stubber import PinpointStubber
++from test_tools.s3_stubber import S3Stubber
++from test_tools.s3control_stubber import S3ControlStubber
+ from test_tools.sqs_stubber import SqsStubber
++from test_tools.sts_stubber import StsStubber
+
+
+ class StubberFactoryNotImplemented(Exception):",is this phrase completed in a next line? Or forgot to add... what?
+1315,"@@ -0,0 +1,11 @@
++_base_ = [
++    '../_base_/models/mask_rcnn_r50_fpn.py',
++    '../_base_/datasets/deepfashion.py', '../_base_/schedules/schedule_1x.py',
++    '../_base_/default_runtime.py'
++]
++model = dict(
++    roi_head=dict(
++        bbox_head=dict(num_classes=15), mask_head=dict(num_classes=15)))
++# runtime settings
++total_epochs = 12
++workflow = [('train', 5)]","`('train', 5)` and `('train', 1)` are actually the same."
+1316,"@@ -205,8 +205,8 @@ func (bt *backpressureTracker) beforeDiskBlockCachePut(blockResources int64) (
+ 	return availableResources
+ }
+
+-func (bt *backpressureTracker) getLimitInfo() (used int64, limit int64) {
+-	return bt.used, bt.limit
++func (bt *backpressureTracker) getLimitInfo() (used int64, limit float64) {
++	return bt.used, bt.currLimit()
+ }
+
+ type backpressureTrackerStatus struct {",Would it be too complicated to refactor `currLimit` to be an `int64`?
+1317,"@@ -23,6 +23,13 @@ module RSpec
+       def assertions
+         @assertions ||= 0
+       end
++
++      RSPEC_SKIP_IMPLEMENTATION = ::RSpec::Core::Pending.instance_method(:skip)
++      # Minitest::Assertions has it's own `skip`, we need to make sure
++      # RSpec::Core::Pending#skip is used instead.
++      def skip(*args)
++        RSPEC_SKIP_IMPLEMENTATION.bind(self).call(*args)
++      end
+     end
+   end
+ end",Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston
+1318,"@@ -92,6 +92,10 @@ type IoChaosSpec struct {
+ // IoChaosStatus defines the observed state of IoChaos
+ type IoChaosStatus struct {
+ 	ChaosStatus `json:"",inline""`
++
++	// Instances always specifies podnetworkchaos generation or empty
++	// +optional
++	Instances map[string]int64 `json:""instances,omitempty""`
+ }
+
+ func (obj *IoChaos) GetSelectorSpecs() map[string]interface{} {",Should be podiochaos?
+1319,"@@ -35,6 +35,10 @@ import api
+ import guiHelper
+ import winVersion
+
++# Temporary: #8599: add cp65001 codec
++#            #7105: upgrading to python 3 should fix this issue. See https://bugs.python.org/issue13216
++codecs.register(lambda name: codecs.lookup('utf-8') if name == 'cp65001' else None)
++
+ try:
+ 	import updateCheck
+ except RuntimeError:","Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though."
+1320,"@@ -154,6 +154,18 @@ namespace OpenTelemetry.Metrics
+                         {
+                             var metricStreamConfig = metricStreamConfigs[i];
+                             var metricStreamName = metricStreamConfig?.Name ?? instrument.Name;
++
++                            if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName))
++                            {
++                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(
++                                    metricStreamName,
++                                    instrument.Meter.Name,
++                                    ""Metric name is invalid."",
++                                    ""The name must comply with the OpenTelemetry specification."");
++
++                                continue;
++                            }
++
+                             if (this.metricStreamNames.ContainsKey(metricStreamName))
+                             {
+                                 // TODO: Log that instrument is ignored","in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)"
+1321,"@@ -1654,9 +1654,10 @@ class TargetLocator {
+    *     when the driver has changed focus to the specified window.
+    */
+   window(nameOrHandle) {
++    let paramName = this.driver_.getExecutor().w3c ? 'handle' : 'name';
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter(paramName, nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ",I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs
+1322,"@@ -0,0 +1,5 @@
++_base_ = '../cascade_rcnn/cascade_mask_rcnn_r50_fpn_20e_coco.py'
++model = dict(
++    pretrained=  # NOQA
++    'https://shanghuagao.oss-cn-beijing.aliyuncs.com/res2net/res2net101_v1b_26w_4s_mmdetv2-f0a600f9.pth',  # NOQA
++    backbone=dict(type='Res2Net', depth=101, scale=4, base_width=26))",You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later.
+1323,"@@ -17,3 +17,12 @@
+  */
+
+ export const STORE_NAME = 'modules/pagespeed-insights';
++
++// Form ID for PageSpeed widget.
++export const FORM_DASH_WIDGET = 'pagespeedWidget';
++// Report strategies.
++export const STRATEGY_MOBILE = 'mobile';
++export const STRATEGY_DESKTOP = 'desktop';
++// Report data sources.
++export const DATA_SRC_LAB = 'data_lab';
++export const DATA_SRC_FIELD = 'data_field';","May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?"
+1324,"@@ -151,7 +151,7 @@ module.exports = class AwsS3Multipart extends Plugin {
+       const onError = (err) => {
+         this.uppy.log(err)
+         this.uppy.emit('upload-error', file, err)
+-        err.message = `Failed because: ${err.message}`
++        err.message = `${err.message}`
+
+         queuedRequest.done()
+         this.resetUploaderReferences(file.id)",I guess this assignment is now redundant?
+1325,"@@ -218,7 +218,9 @@ func (s *Server) handleSingleRPC(ctx context.Context, req *RPCReq) *RPCRes {
+ 		return backendRes
+ 	}
+
+-	backendRes, err = s.backendGroups[group].Forward(ctx, req)
++	// NOTE: We call into the specific backend here to ensure that the RPCRes is synchronized with the blockNum.
++	var blockNum uint64
++	backendRes, blockNum, err = s.backendGroups[group].Forward(ctx, req)
+ 	if err != nil {
+ 		log.Error(
+ 			""error forwarding RPC request"",",See above note re: blockNum synchronization.
+1326,"@@ -10,8 +10,10 @@ import (
+ 	""time""
+
+ 	""github.com/andres-erbsen/clock""
++	""github.com/cenkalti/backoff/v3""
+ 	observer ""github.com/imkira/go-observer""
+ 	""github.com/spiffe/spire/pkg/agent/client""
++	spire_backoff ""github.com/spiffe/spire/pkg/agent/common/backoff""
+ 	""github.com/spiffe/spire/pkg/agent/manager/cache""
+ 	""github.com/spiffe/spire/pkg/agent/svid""
+ 	""github.com/spiffe/spire/pkg/common/bundleutil""",wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?
+1327,"@@ -44,7 +44,6 @@
+ #include ""disassemble.h""
+ #include ""instr.h""
+ #include ""instr_create.h""
+-
+ #include ""codec.h""
+
+ ",Or maybe put into alphabetical order with the other #includes.
+1328,"@@ -235,8 +235,11 @@ func watchConfigFile(filename, adapterName string) {
+ 		return false
+ 	}
+
++	ticker := time.NewTicker(1 * time.Second)
++	defer ticker.Stop()
++
+ 	// begin poller
+-	for range time.Tick(1 * time.Second) {
++	for range ticker.C {
+ 		// get the file info
+ 		info, err := os.Stat(filename)
+ 		if err != nil {",This runs the entire duration of the program; this change is not needed.
+1329,"@@ -20,6 +20,10 @@ export class TouchScroll extends BasePlugin {
+     return PLUGIN_PRIORITY;
+   }
+
++  static get ALWAYS_UPDATE() {
++    return true;
++  }
++
+   constructor(hotInstance) {
+     super(hotInstance);
+ ","I don't feel well about the `ALWAYS_UPDATE` option   &nbsp; sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the ""observability"" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)"
+1330,"@@ -34,6 +34,11 @@
+  * by asynch interrupt.
+  */
+
++/* clang-format off */
++/* XXX: clang-format incorrectly detected a tab difference at ""clang-format on""
++ * below. This is why ""clang-format off"" has been moved outside the ifdef until
++ * bug is fixed.
++ */
+ #ifndef ASM_CODE_ONLY /* C code */
+ #    include ""configure.h""
+ #    ifndef UNIX","A ""tab difference""? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?"
+1331,"@@ -31,12 +31,7 @@ import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.grid.sessionmap.local.LocalSessionMap;
+ import org.openqa.selenium.netty.server.NettyServer;
+ import org.openqa.selenium.remote.SessionId;
+-import org.openqa.selenium.remote.http.HttpClient;
+-import org.openqa.selenium.remote.http.HttpHandler;
+-import org.openqa.selenium.remote.http.HttpRequest;
+-import org.openqa.selenium.remote.http.HttpResponse;
+-import org.openqa.selenium.remote.http.TextMessage;
+-import org.openqa.selenium.remote.http.WebSocket;
++import org.openqa.selenium.remote.http.*;
+ import org.openqa.selenium.remote.tracing.DefaultTestTracer;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ ",Could you please leave the explicit imports?
+1332,"@@ -265,6 +265,9 @@ public abstract class GapicInterfaceConfig implements InterfaceConfig {
+     }
+     List<T> methodConfigs = new ArrayList<>();
+     for (MethodConfigProto methodConfigProto : interfaceConfigProto.getMethodsList()) {
++      if (methodConfigMap.get(methodConfigProto.getName()) == null) {
++        continue;
++      }
+       methodConfigs.add(methodConfigMap.get(methodConfigProto.getName()));
+     }
+     return methodConfigs;",Can we check for containsKey here?
+1333,"@@ -35,9 +35,14 @@ import (
+ 	""golang.org/x/tools/go/types/typeutil""
+ )
+
++const usage = ""usage: wire [gen] [PKG] | wire show [...] | wire check [...]""
++
+ func main() {
+ 	var err error
+ 	switch {
++	case len(os.Args) == 2 && (os.Args[1] == ""help"" || os.Args[1] == ""-h"" || os.Args[1] == ""-help"" || os.Args[1] == ""--help""):
++		fmt.Fprintln(os.Stderr, usage)
++		os.Exit(2)
+ 	case len(os.Args) == 1 || len(os.Args) == 2 && os.Args[1] == ""gen"":
+ 		err = generate(""."")
+ 	case len(os.Args) == 2 && os.Args[1] == ""show"":",Exit successfully. We served the help the user wanted.
+1334,"@@ -15,13 +15,13 @@ import (
+ // RepoRoot is the root of the Please repository
+ var RepoRoot string
+
+-// initialWorkingDir is the directory we began in. Early on we chdir() to the repo root but for
++// InitialWorkingDir is the directory we began in. Early on we chdir() to the repo root but for
+ // some things we need to remember this.
+-var initialWorkingDir string
++var InitialWorkingDir string
+
+-// initialPackage is the initial subdir of the working directory, ie. what package did we start in.
+-// This is similar but not identical to initialWorkingDir.
+-var initialPackage string
++// InitialPackagePath is the initial subdir of the working directory, ie. what package did we start in.
++// This is similar but not identical to InitialWorkingDir.
++var InitialPackagePath string
+
+ // usingBazelWorkspace is true if we detected a Bazel WORKSPACE file to find our repo root.
+ var usingBazelWorkspace bool",Had to rename this because `InitialPackage()` already existed.
+1335,"@@ -19,4 +19,15 @@ module IntegrationSpecHelper
+       }
+     )
+   end
++
++  def with_18f_procurement_env_variables(setup_vars=nil)
++    old_approver_email = ENV['GSA18F_APPROVER_EMAIL']
++    old_purchaser_email = ENV['GSA18F_PURCHASER_EMAIL']
++
++    ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'
++    ENV['GSA18F_PURCHASER_EMAIL'] = 'test_purchaser@some-dot-gov.gov'
++    yield
++    ENV['GSA18F_APPROVER_EMAIL'] = old_approver_email
++    ENV['GSA18F_PURCHASER_EMAIL'] = old_purchaser_email
++  end
+ end",Can we put this in a different helper?
+1336,"@@ -603,6 +603,9 @@ insert_push_all_registers(dcontext_t *dcontext, clean_call_info_t *cci,
+                                   DR_REG_LIST_LENGTH_ARM, DR_REG_LIST_ARM));
+     }
+     dstack_offs += 15 * XSP_SZ;
++
++    /* Make dstack_offs 8-byte algined, as we only accounted for 31 4-byte slots */
++    dstack_offs += XSP_SZ;
+     ASSERT(cci->skip_save_flags    ||
+            cci->num_simd_skip != 0 ||
+            cci->num_regs_skip != 0 ||","I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD."
+1337,"@@ -46,4 +46,10 @@ public class Info extends AbstractApiBean {
+     public Response getServer() {
+         return response( req -> ok(systemConfig.getDataverseServer()));
+     }
++
++    @GET
++    @Path(""apiTermsOfUse"")
++    public Response getTermsOfUse() {
++        return response( req -> ok(systemConfig.getApiTermsOfUse()));
++    }
+ }","If you want, you could change this to `allowCors(response` (like in ""version"", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set."
+1338,"@@ -1616,4 +1616,9 @@ public class MessageList extends K9Activity implements MessageListFragmentListen
+             }
+         }
+     }
++
++    @Override
++    public void onConfigurationChanged(Configuration newConfig) {
++        super.onConfigurationChanged(newConfig);
++    }
+ }",Why do we need to override this if all we're doing is passing it up?
+1339,"@@ -356,6 +356,9 @@ void CmpSeabaseDDL::createSeabaseTableLike(
+         query += keyClause;
+       }
+
++  // send any user CQDs down
++  Lng32 retCode = sendAllControls(FALSE, FALSE, TRUE);
++
+   ExeCliInterface cliInterface(STMTHEAP, NULL, NULL,
+   CmpCommon::context()->sqlSession()->getParentQid());
+ ","Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?"
+1340,"@@ -1,11 +1,16 @@
+ import os
+
++import packaging.version
++import requests
++
+ from ..defines import GCP_CREDS_LOCAL_FILE
+ from ..module_build_spec import ModuleBuildSpec
+ from ..utils import connect_sibling_docker_container, network_buildkite_container
+ from .test_images import publish_test_images, test_image_depends_fn
+
+ SCRIPT_PATH = os.path.dirname(os.path.abspath(__file__))
++DAGSTER_FROM_SOURCE = ""current_branch""
++DAGSTER_EARLIEST_RELEASE = ""0.12.4""
+
+
+ def integration_suite_extra_cmds_fn(version):",EARLIEST_TESTED_RELEASE might be slightly more clear
+1341,"@@ -81,7 +81,7 @@ MSG_STATE_CONFIDENCE = 2
+ # Allow stopping after the first semicolon/hash encountered,
+ # so that an option can be continued with the reasons
+ # why it is active or disabled.
+-OPTION_RGX = re.compile(r""\s*#.*\bpylint:\s*([^;#]+)[;#]{0,1}"")
++OPTION_RGX = re.compile(r'.*#\s*pylint:\s*([^;#]+)[;#]?.*')
+
+ # The line/node distinction does not apply to fatal errors and reports.
+ _SCOPE_EXEMPT = ""FR""","I think replacing `.*` with `\s*` from after the hash makes sense, but not the rest of the changes."
+1342,"@@ -220,6 +220,8 @@ type NetworkPolicyRule struct {
+ 	// action “nil” defaults to Allow action, which would be the case for rules created for
+ 	// K8s Network Policy.
+ 	Action *secv1alpha1.RuleAction `json:""action,omitempty"" protobuf:""bytes,6,opt,name=action,casttype=github.com/vmware-tanzu/antrea/pkg/apis/security/v1alpha1.RuleAction""`
++	// EnableLogging indicates whether or not to generate logs when rules are matched. Default to false.
++	EnableLogging bool `json:""enableLogging"" protobuf:""varint,7,opt,name=enableLogging""`
+ }
+
+ // Protocol defines network protocols supported for things like container ports.",interesting .. did not know varint tag covered bool as well
+1343,"@@ -35,6 +35,11 @@ struct st_duration_stats_t {
+     struct gkc_summary *process_time;
+     struct gkc_summary *response_time;
+     struct gkc_summary *total_time;
++
++    /**
++     * average event loop latency per worker thread
++     */
++    H2O_VECTOR(uint64_t) evloop_latency_ms;
+ };
+
+ struct st_duration_agg_stats_t {","Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms."
+1344,"@@ -187,7 +187,7 @@ Block.prototype.getTransactionHashes = function getTransactionHashes() {
+     return [Block.Values.NULL_HASH];
+   }
+   for (var t = 0; t < this.txs.length; t++) {
+-    hashes.push(this.txs[t].hash());
++    hashes.push(this.txs[t]._getHash());
+   }
+   return hashes;
+ };",getHash should be a public and without an `_` if used here.
+1345,"@@ -71,6 +71,10 @@ func (dv *DefaultBlockValidator) ValidateSemantic(ctx context.Context, child *ty
+
+ // ValidateSyntax validates a single block is correctly formed.
+ func (dv *DefaultBlockValidator) ValidateSyntax(ctx context.Context, blk *types.Block) error {
++	// hack validate genesisblock
++	if blk.Height == 0 {
++		return nil
++	}
+ 	now := uint64(dv.Now().Unix())
+ 	if uint64(blk.Timestamp) > now {
+ 		return fmt.Errorf(""block %s with timestamp %d generate in future at time %d"", blk.Cid().String(), blk.Timestamp, now)",Unrelated to these changes -- we will probably want some special handling for genesis block validation.
+1346,"@@ -75,6 +75,10 @@ type diskBlockCacheSetter interface {
+ 	MakeDiskBlockCacheIfNotExists() error
+ }
+
++type diskBlockCacheFractionSetter interface {
++	SetDiskBlockCacheFraction(float64)
++}
++
+ type clockGetter interface {
+ 	Clock() Clock
+ }","This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!"
+1347,"@@ -56,6 +56,8 @@ func (d *Driver) AddPeer(ctx context.Context, addr swarm.Address) error {
+ 		d.mtx.Unlock()
+ 		return nil
+ 	}
++
++	d.receivedPeers[addr.ByteString()] = struct{}{}
+ 	d.mtx.Unlock()
+
+ 	connectedPeers := d.p2pService.Peers()","@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?"
+1348,"@@ -0,0 +1,19 @@
++<% if display_response_actions?(cart, current_user) %>
++  <div id='reply-section'>
++    <p>
++      <%= link_to ""Approve"",
++          approval_response_path(approver_action: 'approve',
++                                 cart_id: cart.id,
++                                 scheme: 'https',
++                                 user_id: current_user.id,
++                                 ), class: 'form-button' %>
++
++      <%= link_to ""Reject"",
++          approval_response_path(approver_action: 'reject',
++                                 cart_id: cart.id,
++                                 scheme: 'https',
++                                 user_id: current_user.id,
++                                 ), class: 'reject-link' %>
++    </p>
++  </div>
++<% end %>",Minor: can we put the conditional outside of the partial?
+1349,"@@ -887,7 +887,8 @@ class AsyncSniffer(object):
+
+                 if isinstance(offline, Packet):
+                     tempfile_written, offline = _write_to_pcap([offline])
+-                elif isinstance(offline, list) and \
++                elif (isinstance(offline, list) or
++                        isinstance(offline, PacketList)) and \
+                         all(isinstance(elt, Packet) for elt in offline):
+                     tempfile_written, offline = _write_to_pcap(offline)
+ ",We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent..
+1350,"@@ -29,6 +29,9 @@ var (
+ executions and is good for jobs which need to run frequently. ""Fixed Schedule""
+ lets you use a predefined or custom cron schedule and is good for less-frequent
+ jobs or those which require specific execution schedules.`
++
++	fmtJobInitTypeHelp = `A %s is a task which can be programmatically run, either on a schedule or via
++service code in response to events.`
+ )
+
+ const (","How "" via service code in response to event.""? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way"
+1351,"@@ -65,7 +65,6 @@ PER_YIELD = 1024
+
+ def generate_model_handle():
+     """"""Generate random model handle.
+-
+     Returns:
+         str: random bytes for handle
+     """"""",Please move unrelated formatting changes to their own PR (same with the resources.py file).
+1352,"@@ -2171,6 +2171,7 @@ class CommandDispatcher:
+
+         window = self._tabbed_browser.window()
+         if window.isFullScreen():
+-            window.showNormal()
++            window.setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)
+         else:
++            window._state_before_fullscreen = window.windowState()
+             window.showFullScreen()",Make this a public attribute (remove the leading `_`) if you want to access it from the outside.
+1353,"@@ -116,7 +116,7 @@ define(['layoutManager', 'browser', 'actionsheet', 'css!./emby-select', 'registe
+             inputId++;
+         }
+
+-        if (!browser.firefox) {
++        if (browser) {
+             this.classList.add('emby-select-withcolor');
+
+ 			if (layoutManager.tv) {",this conditional is useless now so it should be removed
+1354,"@@ -262,8 +262,8 @@ void AccessFlatBufferTest(const uint8_t *flatbuf, size_t length,
+   auto vecofstructs = monster->testarrayofsortedstruct();
+   if (vecofstructs) {  // not filled in monster_test.bfbs
+     for (size_t i = 0; i < vecofstructs->size()-1; i++) {
+-      auto left = vecofstructs->Get(i);
+-      auto right = vecofstructs->Get(i+1);
++      auto left = vecofstructs->Get(static_cast<flatbuffers::uoffset_t>(i));
++      auto right = vecofstructs->Get(static_cast<flatbuffers::uoffset_t>(i+1));
+       TEST_EQ(true, (left->KeyCompareLessThan(right)));
+     }
+     TEST_NOTNULL(vecofstructs->LookupByKey(3));","`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts."
+1355,"@@ -197,7 +197,14 @@ public abstract class GapicProductConfig implements ProductConfig {
+     }
+
+     // Toggle on/off proto annotations parsing.
+-    ProtoParser protoParser = new ProtoParser(getDefaultLanguageFeatureConfig(language, null));
++    ProtoParser protoParser;
++    // TODO(andrealin): Expose command-line option for toggling proto annotations parsing.
++    if (configProto == null) {
++      // By default, enable proto annotations parsing when no GAPIC config is given.
++      protoParser = new ProtoParser(true);
++    } else {
++      protoParser = new ProtoParser(getDefaultLanguageFeatureConfig(language, null));
++    }
+     if (configProto == null) {
+       configProto = ConfigProto.getDefaultInstance();
+     }","Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer."
+1356,"@@ -138,7 +138,7 @@ describe.skip('Buffering Proxy', function() {
+           if (die) {
+             request.connection.destroy();
+           } else {
+-            if (doc.ismaster) {
++            if (doc.ismaster || doc.hello) {
+               request.reply(primary[currentIsMasterIndex]);
+             } else if (doc.insert) {
+               request.reply({ ok: 1, n: 1 });","I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution"
+1357,"@@ -7,6 +7,10 @@
+   <%= json_api_link_tag %>
+ <% end %>
+
++<% content_for(:skip_links) do -%>
++  <a href=""#documents"" class=""element-invisible element-focusable"" data-turbolinks=""false"">Skip to first result</a>
++<% end %>
++
+ <% content_for(:container_header) do -%>
+   <h1 class=""sr-only top-content-title""><%= t('blacklight.search.header') %></h1>
+ ","I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option)."
+1358,"@@ -1323,11 +1323,9 @@ VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceDisplayPropertiesKHR(VkPhysicalD
+         instance_data->instance_dispatch_table.GetPhysicalDeviceDisplayPropertiesKHR(physicalDevice, pPropertyCount, pProperties);
+
+     lock.lock();
+-    if (result == VK_SUCCESS) {
+-        if (pProperties) {
+-            for (uint32_t i = 0; i < *pPropertyCount; ++i) {
+-                CreateObject(physicalDevice, pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
+-            }
++    if ((result == VK_SUCCESS || result == VK_INCOMPLETE) && pProperties) {
++        for (uint32_t i = 0; i < *pPropertyCount; ++i) {
++            CreateObject(physicalDevice, pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
+         }
+     }
+     lock.unlock();",This was already in vkGetPhysicalDeviceDisplayProperties2KHR...
+1359,"@@ -498,3 +498,7 @@ type tasksStopper interface {
+ type serviceLinkedRoleCreator interface {
+ 	CreateECSServiceLinkedRole() error
+ }
++
++type dockerEngineValidator interface {
++	IsDockerEngineRunning() (string, error)
++}","nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`"
+1360,"@@ -322,12 +322,12 @@ def define_model(model_name, dbengine, model_seed):
+         cai_resource_name = Column(String(4096))
+         cai_resource_type = Column(String(512))
+         full_name = Column(String(2048), nullable=False)
+-        type_name = Column(get_string_by_dialect(dbengine.dialect.name, 512),
++        type_name = Column(get_string_by_dialect(dbengine.dialect.name, 700),
+                            primary_key=True)
+         parent_type_name = Column(
+-            get_string_by_dialect(dbengine.dialect.name, 512),
++            get_string_by_dialect(dbengine.dialect.name, 700),
+             ForeignKey('{}.type_name'.format(resources_tablename)))
+-        name = Column(String(256), nullable=False)
++        name = Column(String(1024), nullable=False)
+         type = Column(String(128), nullable=False)
+         policy_update_counter = Column(Integer, default=0)
+         display_name = Column(String(256), default='')","If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size"
+1361,"@@ -20,6 +20,13 @@ def GetSizePrefix(buf, offset):
+ 	""""""Extract the size prefix from a buffer.""""""
+ 	return encode.Get(packer.int32, buf, offset)
+
++def GetBufferIdentifier(buf, offset, size_prefixed = False):
++        """"""Extract the file_identifier from a buffer""""""
++        offset+=(number_types.UOffsetTFlags.bytewidth if size_prefixed else 0) + number_types.UOffsetTFlags.bytewidth # offset sizeof(root table offset) + sizeof(size prefix) if present
++        return buf[offset:offset+encode.FILE_IDENTIFIER_LENGTH]
++def BufferHasIdentifier(buf, offset, file_identifier, size_prefixed = False):
++        return GetBufferIdentifier(buf, offset, size_prefixed)==file_identifier
++
+ def RemoveSizePrefix(buf, offset):
+ 	""""""
+ 	Create a slice of a size-prefixed buffer that has","When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments."
+1362,"@@ -41,7 +41,7 @@ class BasicResBlock(nn.Module):
+             out_channels,
+             kernel_size=1,
+             bias=False,
+-            activation=None,
++            act_cfg=None,
+             conv_cfg=conv_cfg,
+             norm_cfg=norm_cfg)
+ ","We may follow the argument order: conv_cfg, norm_cfg, act_cfg."
+1363,"@@ -60,6 +60,19 @@ module Selenium
+
+         class << self
+           def chrome(opts = {})
++            define_method(:options) { @capabilities[:chrome_options] ||= {} }
++            define_method(""options="") { |value| @capabilities[:chrome_options] = value }
++            define_method(""profile="") do |profile|
++              profile_json = profile.as_json
++              options['args'] ||= []
++              if options['args'].none? { |arg| arg =~ /user-data-dir/ }
++                options['args'] << ""--user-data-dir=#{profile_json[:directory]}""
++              end
++              options['extensions'] = profile_json[:extensions]
++            end
++            alias_method :chrome_options, :options
++            alias_method :chrome_options=, :options=
++
+             new({
+               browser_name: 'chrome',
+               javascript_enabled: true,",`options['binary'] = WebDriver::Chrome.path` if set?
+1364,"@@ -5,6 +5,7 @@
+  */
+
+ #include <errno.h>
++#include <folly/ssl/Init.h>
+ #include <signal.h>
+ #include <string.h>
+ #include <thrift/lib/cpp2/server/ThriftServer.h>",folly library should be put on the top.
+1365,"@@ -35,6 +35,7 @@ let CAMEL_REG = /-?(?=[A-Z])/g;
+ function setProperty(dom, name, value, oldValue, isSvg) {
+ 	let v;
+ 	if (name==='class' || name==='className') name = isSvg ? 'class' : 'className';
++	const ns = isSvg && (name !== (name = name.replace(/^xlink:?/, '')));
+
+ 	if (name==='style') {
+ ","Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?"
+1366,"@@ -134,7 +134,7 @@ class DataProvider {
+    * @returns {boolean}
+    */
+   _isHiddenRow(row) {
+-    return this.hot.hasHook('hiddenRow') && this.hot.runHooks('hiddenRow', row);
++    return this.hot.rowIndexMapper.isHidden(this.hot.toPhysicalRow(row));
+   }
+
+   /**",Please add it to the `REMOVED_HOOKS` constant.
+1367,"@@ -1,7 +1,9 @@
+ describe('fieldset', function () {
+ 	'use strict';
+ 	var fixture = document.getElementById('fixture');
++	var shadowSupport = axe.testUtils.shadowSupport;
+ 	var fixtureSetup = axe.testUtils.fixtureSetup;
++
+ 	var checkContext = {
+ 		_data: null,
+ 		data: function (d) {","This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result"
+1368,"@@ -25,6 +25,12 @@ class AccountsController < ApplicationController
+     render json: Chart.new(@account).commits_by_language(params[:scope])
+   end
+
++  def label_as_spammer
++    @account = Account.find_by(id: params[:id])
++    Account::Access.new(@account).spam!
++    render template: 'accounts/disabled'
++  end
++
+   private
+
+   def account",Is this access protected so that only admins can access this route?
+1369,"@@ -328,7 +328,7 @@ void wlr_output_layout_closest_point(struct wlr_output_layout *layout,
+ 		return;
+ 	}
+
+-	double min_x = DBL_MAX, min_y = DBL_MAX, min_distance = DBL_MAX;
++	double min_x = 0, min_y = 0, min_distance = DBL_MAX;
+ 	struct wlr_output_layout_output *l_output;
+ 	wl_list_for_each(l_output, &layout->outputs, link) {
+ 		if (reference != NULL && reference != l_output->output) {","What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?"
+1370,"@@ -1637,6 +1637,11 @@ func (o *consumer) processNextMsgReq(_ *subscription, c *client, _, reply string
+ 		return
+ 	}
+
++	if o.maxp > 0 && batchSize > o.maxp {
++		sendErr(409, ""Exceeded MaxAckPending"")
++		return
++	}
++
+ 	// In case we have to queue up this request.
+ 	wr := waitingRequest{client: c, reply: reply, n: batchSize, noWait: noWait, expires: expires}
+ ",I think you want to look at current pending + batchSize and if that is > o.maxp no?
+1371,"@@ -189,7 +189,7 @@ func (h *Harness) testSpan(tracerFactory func() trace.Tracer) {
+ 			span.AddEventWithTimestamp(context.Background(), time.Now(), ""test event"")
+ 		},
+ 		""#SetStatus"": func(span trace.Span) {
+-			span.SetStatus(codes.Internal, ""internal"")
++			span.SetStatus(codes.Ok, ""internal"")
+ 		},
+ 		""#SetName"": func(span trace.Span) {
+ 			span.SetName(""new name"")",Should this be `codes.Error`? `codes.Internal` was an error status before.
+1372,"@@ -26,6 +26,11 @@ class AccountsController < ApplicationController
+     @projects, @logos = @account.project_core.used
+     @twitter_detail = TwitterDetail.new(@account)
+     page_context[:page_header] = 'accounts/show/header'
++    respond_to do |format|
++      format.html
++      format.xml
++      format.json
++    end
+   end
+
+   def me",I don't think you need these lines.
+1373,"@@ -195,7 +195,7 @@ type tlfJournal struct {
+ 	// Invariant: this tlfJournal acquires exactly
+ 	// blockJournal.getStoredBytes() and
+ 	// blockJournal.getStoredFiles() until shutdown.
+-	DiskLimiter DiskLimiter
++	diskLimiter DiskLimiter
+
+ 	// All the channels below are used as simple on/off
+ 	// signals. They're buffered for one object, and all sends are","You didn't mean to export this, right?"
+1374,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-show-topics.rb demonstrates how to list Amazon Simple Notification Services (SNS) topics using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",Simple Notification **Service** (singular)
+1375,"@@ -313,6 +313,7 @@ type client struct {
+ 	replayMutex   sync.RWMutex
+ 	nodeConfig    *config.NodeConfig
+ 	networkConfig *config.NetworkConfig
++	egressConfig  *config.EgressConfig
+ 	gatewayOFPort uint32
+ 	// ovsDatapathType is the type of the datapath used by the bridge.
+ 	ovsDatapathType ovsconfig.OVSDatapathType",Do we still need this?
+1376,"@@ -108,9 +108,6 @@ public abstract class AbstractEeaSendRawTransaction implements JsonRpcMethod {
+         final Transaction privateMarkerTransaction =
+             createPrivateMarkerTransaction(privateTransaction, user);
+
+-        LOG.error(""CHEESE"");
+-        LOG.error(privateMarkerTransaction.getHash());
+-
+         return transactionPool
+             .addLocalTransaction(privateMarkerTransaction)
+             .either(",We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?
+1377,"@@ -217,7 +217,7 @@ import 'css!./imageeditor';
+             reload(context, null, focusContext);
+         }, function () {
+             import('alert').then(({default: alert}) => {
+-                alert(globalize.translate('DefaultErrorMessage'));
++                alert(globalize.translate('MessageDefaultError'));
+             });
+         });
+     }",This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?
+1378,"@@ -35,12 +35,13 @@ import (
+ 	""antrea.io/antrea/pkg/features""
+ )
+
+-func skipIfNetworkPolicyStatsDisabled(tb testing.TB, data *TestData) {
+-	skipIfFeatureDisabled(tb, data, features.NetworkPolicyStats, true, true)
++func skipIfNetworkPolicyStatsDisabled(tb testing.TB) {
++	skipIfFeatureDisabled(tb, features.NetworkPolicyStats, true, true)
+ }
+
+-func TestNetworkPolicyStats(t *testing.T) {
+-	skipIfNotIPv4Cluster(t)
++// TestNetworkPolicy is the top-level test which contains all subtests for
++// NetworkPolicy related test cases so they can share setup, teardown.
++func TestNetworkPolicy(t *testing.T) {
+ 	skipIfHasWindowsNodes(t)
+
+ 	data, err := setupTest(t)",I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898
+1379,"@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti
+ 	epType := tc.EpTypeHost
+ 	if ifaceName == ""tunl0"" {
+ 		epType = tc.EpTypeTunnel
++	} else if ifaceName == ""wireguard.cali"" {
++		epType = tc.EpTypeWireguard
+ 	}
+ 	ap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)
+ 	ap.HostIP = m.hostIP",nit: a switch perhaps?
+1380,"@@ -14,7 +14,7 @@
+     <![endif]-->
+
+     <title><%= render_page_title %></title>
+-    <link href=""<%= opensearch_catalog_path(:format => 'xml', :only_path => false) %>"" title=""<%= application_name%>"" type=""application/opensearchdescription+xml"" rel=""search""/>
++    <%= opensearch_description_tag application_name, opensearch_catalog_path(:format => 'xml', :only_path => false) %>
+     <%= favicon_link_tag asset_path('favicon.ico') %>
+     <%= stylesheet_link_tag    ""application"" %>
+     <%= javascript_include_tag ""application"" %>",Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?
+1381,"@@ -281,7 +281,7 @@ func (j journalMDOps) getRange(
+ 	[]ImmutableRootMetadata, error) {
+ 	// Grab the range from the journal first.
+ 	jirmds, err := j.getRangeFromJournal(ctx, id, bid, mStatus, start, stop)
+-	if err != nil {
++	if err != nil && err != errTLFJournalDisabled {
+ 		return nil, err
+ 	}
+ ",Just noticed this while debugging -- it's unlikely to be causing issues in practice.
+1382,"@@ -75,7 +75,7 @@ describe( 'setting up the Analytics module with no existing account and no exist
+ 		await expect( page ).toClick( '.googlesitekit-analytics__select-country' );
+ 		await expect( page ).toClick( '.mdc-menu-surface--open li', { text: /united kingdom/i } );
+
+-		await expect( page ).toMatchElement( 'p', { text: /need to give Site Kit permission to create an Analytics account/i } );
++		await expect( page ).toMatchElement( 'p', { text: /need to give Site Kit permission to create an Analytics account/i, timeout: 750 } );
+
+ 		await Promise.all( [
+ 			page.waitForNavigation(), // User is sent directly to OAuth.",That seems unrelated - did that fix a random test failure you noticed while working on this issue?
+1383,"@@ -98,8 +98,11 @@ public abstract class BaseMetastoreTableOperations implements TableOperations {
+       LOG.info(""Nothing to commit."");
+       return;
+     }
++    TableMetadata updated = (base != null && base.file() != null) ?
++            metadata.addPreviousMetadata(base.file().location(), base.lastUpdatedMillis()) : metadata;
+
+-    doCommit(base, metadata);
++    doCommit(base, updated);
++    deleteRemovedMetadata(updated);
+     requestRefresh();
+   }
+ ","This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it."
+1384,"@@ -82,3 +82,18 @@ def flip_tensor(src_tensor, flip_direction):
+     else:
+         out_tensor = torch.flip(src_tensor, [2, 3])
+     return out_tensor
++
++
++def collect_mlvl_tensor_single(mlvl_tensors, batch_id, detach=True):
++    assert isinstance(mlvl_tensors, (list, tuple))
++    num_levels = len(mlvl_tensors)
++
++    if detach:
++        mlvl_tensor_list = [
++            mlvl_tensors[i][batch_id].detach() for i in range(num_levels)
++        ]
++    else:
++        mlvl_tensor_list = [
++            mlvl_tensors[i][batch_id] for i in range(num_levels)
++        ]
++    return mlvl_tensor_list",We need to know why all the tensors are detached in `get_bboxed`.
+1385,"@@ -309,3 +309,13 @@ class Foo:
+
+     def method(self):
+         print(self.__class__.__ham)
++
++
++class TypeSelfCallInMethod:
++    """"""Regression test for issue 5569""""""
++    @classmethod
++    def b(cls) -> None:
++        cls.__a = ''  # [unused-private-member]
++
++    def a(self):
++        return type(self).__a",Unrelated but shouldn't this raise `attribute-defined-outside-init`?
+1386,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low."
+1387,"@@ -98,8 +98,7 @@ class Phase < ActiveRecord::Base
+   # TODO: Move this to Plan model as `num_answered_questions(phase=nil)`
+   # Returns the number of answered question for the phase.
+   def num_answered_questions(plan)
+-    return 0 if plan.nil?
+-    sections.to_a.sum { |s| s.num_answered_questions(plan) }
++    plan&.num_answered_questions.to_i
+   end
+
+   # Returns the number of questions for a phase. Note, this method becomes useful",You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!
+1388,"@@ -23,9 +23,10 @@
+       <div class=""checkbox"">
+         <%= f.label :published, raw(""#{f.check_box :published, as: :check_boxes, 'data-toggle': 'tooltip', title: _(""Check this box when you are ready for this guidance to appear on user's plans."")} #{_('Published?')}"") %>
+       </div>
+-
+-      <%= f.submit _('Save'), name: ""edit_guidance_submit"", class: ""btn btn-primary"" %>
+-      <%= link_to _('Cancel'), admin_index_guidance_path, class: ""btn btn-primary"", role: 'button' %>
++      <div class=""form-group clear-fix"">
++        <%= f.submit _('Save'), name: ""edit_guidance_submit"", class: ""btn btn-primary"" %>
++        <%= link_to _('Cancel'), admin_index_guidance_path, class: ""btn btn-primary"", role: 'button' %>
++      </div>
+     <%end%>
+   </div>
+ </div>",do you mean 'clearfix' class?
+1389,"@@ -391,6 +391,7 @@ MongoClient.connect = function(url, options, callback) {
+  * Starts a new session on the server
+  *
+  * @param {SessionOptions} [options] optional settings for a driver session
++ * @param {boolean} [options.causalConsistency=true] Enables or disables causal consistency for the session.
+  * @return {ClientSession} the newly established session
+  */
+ MongoClient.prototype.startSession = function(options) {",`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here.
+1390,"@@ -46,9 +46,7 @@ import java.lang.reflect.Method;
+
+ import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
+ import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
+-import static org.mockito.ArgumentMatchers.any;
+-import static org.mockito.ArgumentMatchers.anyString;
+-import static org.mockito.ArgumentMatchers.eq;
++import static org.mockito.ArgumentMatchers.*;
+ import static org.mockito.Mockito.*;
+
+ /**",This should not be included since there are no code changes.
+1391,"@@ -56,6 +56,18 @@ func askCredentials(c *context.Context, status int, text string) {
+
+ func HTTPContexter() macaron.Handler {
+ 	return func(c *context.Context) {
++		if len(setting.HTTP.AccessControlAllowOrigin) > 0 {
++			// Set CORS headers for browser-based git clients
++			c.Resp.Header().Set(""Access-Control-Allow-Origin"", setting.HTTP.AccessControlAllowOrigin)
++			c.Resp.Header().Set(""Access-Control-Allow-Headers"", ""Content-Type, Authorization"")
++
++			// Handle preflight OPTIONS request
++			if c.Req.Method == ""OPTIONS"" {
++				c.Status(http.StatusOK)
++				return
++			}
++		}
++
+ 		ownerName := c.Params("":username"")
+ 		repoName := strings.TrimSuffix(c.Params("":reponame""), "".git"")
+ 		repoName = strings.TrimSuffix(repoName, "".wiki"")","If all we need just response 200, then we could use `c.Status(http.StatusOK)` here."
+1392,"@@ -683,6 +683,11 @@ func loadConfigFromDatastore(
+ 		Name:      ""node."" + hostname,
+ 		Namespace: """",
+ 	}, """")
++	n, err := client.Get(ctx, model.ResourceKey{
++		Kind:      apiv2.KindNode,
++		Name:      hostname,
++		Namespace: """",
++	}, """")
+ 	if _, ok := err.(errors2.ErrorResourceDoesNotExist); err != nil && !ok {
+ 		return
+ 	}",Should be checking for error here
+1393,"@@ -431,7 +431,7 @@ class Form extends WidgetBase
+             $this->fields = [];
+         }
+
+-        $this->allTabs->outside = new FormTabs(FormTabs::SECTION_OUTSIDE, $this->config);
++        $this->allTabs->outside = new FormTabs(FormTabs::SECTION_OUTSIDE, (array)$this->config);
+         $this->addFields($this->fields);
+
+         /*",Put a space between `(array)` and `$this` and I'll merge it
+1394,"@@ -0,0 +1,6 @@
++package runtime
++
++// Stack is a stub, not implemented
++func Stack(buf []byte, all bool) int {
++	return 0
++}","You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for."
+1395,"@@ -0,0 +1,13 @@
++package com.fsck.k9.notification;
++
++
++class NotificationHolder {
++    public final int notificationId;
++    public final NotificationContent content;
++
++
++    public NotificationHolder(int notificationId, NotificationContent content) {
++        this.notificationId = notificationId;
++        this.content = content;
++    }
++}","the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other"
+1396,"@@ -23,10 +23,7 @@
+  */
+ package net.runelite.client.plugins.freezetimers;
+
+-import java.util.ArrayList;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
+ import javax.inject.Singleton;
+ import lombok.extern.slf4j.Slf4j;
+ import net.runelite.api.Actor;",Avoid wildcard imports
+1397,"@@ -71,7 +71,7 @@ type (
+ 		GetContractState(hash.PKHash, hash.Hash32B) (hash.Hash32B, error)
+ 		SetContractState(hash.PKHash, hash.Hash32B, hash.Hash32B) error
+ 		// Candidate pool
+-		candidates() (uint64, []*Candidate)
++		Candidates() (uint64, []*Candidate)
+ 		CandidatesByHeight(uint64) ([]*Candidate, error)
+ 	}
+ ",Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method
+1398,"@@ -101,6 +101,13 @@ module.exports = function(url, options, callback) {
+         record = record[0].join('');
+         const parsedRecord = qs.parse(record);
+         const items = Object.keys(parsedRecord);
++        if (
++          Object.keys(items)
++            .map(k => k.toLowerCase())
++            .indexOf('loadbalanced') !== -1
++        ) {
++          return callback(new MongoParseError('Load balancer mode requires driver version 4+'));
++        }
+         if (items.some(item => item !== 'authSource' && item !== 'replicaSet')) {
+           return callback(
+             new MongoParseError('Text record must only set `authSource` or `replicaSet`')",same question here as I have on the other file regarding doing this check here vs L112 vs not at all
+1399,"@@ -1,3 +1,5 @@
++// +build !openbsd
++
+ package fuse
+
+ import (",Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well.
+1400,"@@ -35,7 +35,6 @@ class BZAObject(dict):
+         self.token = None
+         self.log = logging.getLogger(self.__class__.__name__)
+         self.http_session = requests.Session()
+-        self.http_request = self.http_session.request
+
+         # copy infrastructure from prototype
+         if isinstance(proto, BZAObject):","this is used as important way of mocking for unit tests, FYI"
+1401,"@@ -156,6 +156,7 @@ if not config.style_17:
+     options.Points = Options('plot', show_frame=True)
+
+ options.Histogram = Options('style', line_color='black', fill_color=Cycle())
++options.Distribution = Options('style', muted_alpha=0.2)
+ options.ErrorBars = Options('style', color='black')
+ options.Spread = Options('style', color=Cycle(), alpha=0.6, line_color='black')
+ options.Bars = Options('style', color=Cycle(), line_color='black', width=0.8)","Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above."
+1402,"@@ -566,7 +566,7 @@ namespace pwiz.SkylineTest
+             // Bad terminus
+             AssertEx.DeserializeError<StaticMod>(""<static_modification name=\""Mod\"" terminus=\""X\"" formula=\""C23N\"" />"");
+             // Bad formula
+-            AssertEx.DeserializeError<StaticMod, ArgumentException>(""<static_modification name=\""Mod\"" aminoacid=\""K\"" formula=\""C23NHe2\"" />"");
++            AssertEx.DeserializeError<StaticMod, ArgumentException>(""<static_modification name=\""Mod\"" aminoacid=\""K\"" formula=\""C23NHx2\"" />"");
+             // Terminal label without amino acid
+             AssertEx.DeserializeError<StaticMod>(""<static_modification name=\""15N\"" terminus=\""C\"" label_13C=\""true\""/>"");
+             // Formula and labeled atoms","Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?"
+1403,"@@ -486,6 +486,12 @@ class histogram(Operation):
+     bin_range = param.NumericTuple(default=None, length=2,  doc=""""""
+       Specifies the range within which to compute the bins."""""")
+
++    bins = param.ClassSelector(default=None, class_=(np.ndarray, list), doc=""""""
++      An explicit set of bin edges."""""")
++
++    cumulative = param.Boolean(default=False, doc=""""""
++      Whether to compute the cumulative histogram"""""")
++
+     dimension = param.String(default=None, doc=""""""
+       Along which dimension of the Element to compute the histogram."""""")
+ ",What about tuples or pandas series? Do we want to support lots of different types or force a single type?
+1404,"@@ -294,10 +294,6 @@ public class ZkStateReader implements SolrCloseable {
+     log.debug(""Loading collection config from: [{}]"", path);
+
+     try {
+-      if (zkClient.exists(path, true) == false) {
+-        log.warn(""No collection found at path {}."", path);
+-        throw new KeeperException.NoNodeException(""No collection found at path: "" + path);
+-      }
+       byte[] data = zkClient.getData(path, null, null, true);
+       if (data == null) {
+         log.warn(""No config data found at path {}."", path);","Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(""No collection found at path: "" + path);` Just a thought, I'm not even sure it's worth it."
+1405,"@@ -17,7 +17,7 @@ class Project < ActiveRecord::Base
+   validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: { case_sensitive: false }
+   validates :description, length: 0..800, allow_nil: true # , if: proc { |p| p.validate_url_name_and_desc == 'true' }
+   validates_each :url, :download_url, allow_blank: true do |record, field, value|
+-    record.errors.add(field, I18n.t(:not_a_valid_url)) unless value.valid_http_url?
++    record.errors.add(field, I18n.t(:not_a_valid_url)) unless value.blank? || value.valid_http_url?
+   end
+   before_validation :clean_strings_and_urls
+   after_save :update_organzation_project_count","I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not."
+1406,"@@ -212,8 +212,7 @@ module Bolt
+
+         return unless !stdout.empty? && stdout.to_i < 3
+
+-        msg = ""Detected PowerShell 2 on controller. PowerShell 2 is deprecated and ""\
+-              ""support will be removed in Bolt 3.0.""
++        msg = ""Detected PowerShell 2 on controller. PowerShell 2 is unsupported.""
+         Bolt::Logger.deprecation_warning(""PowerShell 2 controller"", msg)
+       end
+     end","Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from ""removing support""."
+1407,"@@ -44,7 +44,12 @@ module Bolt
+
+       # Returns options this transport supports
+       def self.options
+-        raise NotImplementedError, ""self.options() must be implemented by the transport class""
++        raise NotImplementedError,
++              ""self.options() or self.filter_options(unfiltered) must be implemented by the transport class""
++      end
++
++      def self.filter_options(unfiltered)
++        unfiltered.select { |k| options.include?(k) }
+       end
+
+       def self.validate(_options)",This is kind of confusing with the other `filter_options`.
+1408,"@@ -160,7 +160,12 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
+ 		return fs.opsByFav[fav]
+ 	}()
+ 	if ops != nil {
+-		return ops.deleteFromFavorites(ctx, fs.favs)
++		err := ops.deleteFromFavorites(ctx, fs.favs)
++		if _, ok := err.(OpsCantHandleFavorite); !ok {
++			return err
++		}
++		// If the ops couldn't handle the delete, fall through to
++		// going directly via Favorites.
+ 	}
+
+ 	if isLoggedIn {",Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server.
+1409,"@@ -457,7 +457,7 @@ void CmpSeabaseDDL::dropSeabaseSchema(StmtDDLDropSchema * dropSchemaNode)
+
+    bool isVolatile = (memcmp(schName.data(),""VOLATILE_SCHEMA"",strlen(""VOLATILE_SCHEMA"")) == 0);
+    int32_t length = 0;
+-   int32_t rowCount = 0;
++   Int64 rowCount = 0;
+    bool someObjectsCouldNotBeDropped = false;
+    char errorObjs[1010];
+    Queue * objectsQueue = NULL;","It doesn't look like this particular ""rowCount"" variable is used anywhere. I suppose we could delete it. The code change is harmless though."
+1410,"@@ -380,6 +380,10 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+
+ 	status, _ := s.serveHTTP(w, r)
+
++	if status == 204 {
++		w.WriteHeader(http.StatusNoContent)
++	}
++
+ 	// Fallback error response in case error handling wasn't chained in
+ 	if status >= 400 {
+ 		DefaultErrorFunc(w, r, status)","Hmm, probably we should instead write whatever `status` is returned instead of coding a special case."
+1411,"@@ -128,6 +128,10 @@ func parsedRuleToProtoRule(in *ParsedRule) *proto.Rule {
+ 		}
+ 	}
+
++	if in.HTTPMatch != nil {
++		out.HttpMatch = &proto.HTTPMatch{Methods: in.HTTPMatch.Methods}
++	}
++
+ 	// Fill in the ICMP fields.  We can't follow the pattern and make a
+ 	// convertICMP() function because we can't name the return type of the
+ 	// function (it's private to the protobuf package).","Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?"
+1412,"@@ -11,6 +11,7 @@ class User < ActiveRecord::Base
+
+   has_many :approvals
+   has_many :observations
++  has_many :observers, through: :observers, source: :user
+   has_many :comments
+
+   # we do not use rolify gem (e.g.) but declare relationship like any other.",why this recursive relationship definition?
+1413,"@@ -40,7 +40,8 @@ type Procedure struct {
+ 	// HandlerSpec specifiying which handler and rpc type.
+ 	HandlerSpec HandlerSpec
+
+-	// Encoding of the handler, for introspection.
++	// Encoding of the handler, optional, used for introspection, and used for
++	// routing if present.
+ 	Encoding Encoding
+
+ 	// Signature of the handler, for introspection. This should be a snippet of","More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change)."
+1414,"@@ -66,6 +66,10 @@
+ //   are included because they call NewRangeReader.)
+ // - NewWriter, from creation until the call to Close.
+ //
++// It also collects the following metrics:
++// - gocloud.dev/blob/bytes_read: the total number of bytes read, by provider.
++// - gocloud.dev/blob/bytes_written: the total number of bytes written, by provider.
++//
+ // To enable trace collection in your application, see ""Configure Exporter"" at
+ // https://opencensus.io/quickstart/go/tracing.
+ // To enable metric collection in your application, see ""Exporting stats"" at","Not part of this PR, but should the section above say what the name of the metric is for each method?"
+1415,"@@ -75,13 +75,13 @@ namespace OpenTelemetry.Exporter
+
+                         case MetricType.LongGauge:
+                             {
+-                                // TODOs
++                                valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
+                                 break;
+                             }
+
+                         case MetricType.DoubleGauge:
+                             {
+-                                // TODOs
++                                valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
+                                 break;
+                             }
+ ","there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs."
+1416,"@@ -95,7 +95,7 @@ func (t *Terminal) run(ctx context.Context) {
+ 	for {
+ 		select {
+ 		case <-ctx.Done():
+-			if IsProcessBackground() {
++			if IsProcessBackground(t.fd) {
+ 				// ignore all messages, do nothing, we are in the background process group
+ 				continue
+ 			}",This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?
+1417,"@@ -61,7 +61,10 @@ void DataMan::add_stream(json p_jmsg)
+         man->init(p_jmsg);
+         this->add_next(method, man);
+     }
+-    add_man_to_path(""zfp"", method);
++    if (p_jmsg[""compress_method""] != nullptr)
++    {
++        add_man_to_path(p_jmsg[""compress_method""], method);
++    }
+ }
+
+ void DataMan::flush() { flush_next(); }","Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[""compress_method""])`"
+1418,"@@ -146,6 +146,17 @@ public class LibraryFeaturePanel extends FeaturePanel<LibraryFeaturePanel, Libra
+         // get container
+         // TODO: smarter way using container manager
+         final String executablePath = shortcutCreationDTO.getExecutable().getAbsolutePath();
++        if (!executablePath.startsWith(getContainersPath())) {
++            Platform.runLater(() -> {
++                final ErrorDialog errorDialog = ErrorDialog.builder()
++                        .withMessage(tr(""Creating shortcut to executable outside of a container is not supported""))
++                        .withOwner(getScene().getWindow())
++                        .build();
++
++                errorDialog.showAndWait();
++            });
++            return;
++        }
+         final String pathInContainers = executablePath.replace(getContainersPath(), """");
+         final String[] split = pathInContainers.split(""/"");
+         final String engineContainer = split[0];","Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?"
+1419,"@@ -0,0 +1,14 @@
++from kinto.core.events import ResourceChanged
++
++from .listener import on_resource_changed
++
++
++def includeme(config):
++    config.add_api_capability('quotas',
++                              description='Quotas Management on Buckets.',
++                              url='https://kinto.readthedocs.io')
++
++    # Listen to every resources (except history)
++    config.add_subscriber(on_resource_changed, ResourceChanged,
++                          for_resources=('bucket', 'group',
++                                         'collection', 'record'))",nitpick: _and collections_
+1420,"@@ -42,6 +42,8 @@ struct rp_generator_t {
+     int is_websocket_handshake;
+     int had_body_error; /* set if an error happened while fetching the body so that we can propagate the error */
+     h2o_timer_t send_headers_timeout;
++    unsigned req_done : 1;
++    unsigned res_done : 1;
+ };
+
+ struct rp_ws_upgrade_info_t {",I believe these need to be explicitly initialized in `proxy_send_prepare`
+1421,"@@ -160,6 +160,7 @@ class TaskProcess(multiprocessing.Process):
+             # Need to have different random seeds if running in separate processes
+             random.seed((os.getpid(), time.time()))
+
++        t0 = time.time() # Failed task start time
+         status = FAILED
+         expl = ''
+         missing = []",This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block.
+1422,"@@ -1,6 +1,15 @@
+ */
+
+
++/**
++ * The border color when the client is marked.
++ * It has priority over the rest of beautiful border color properties.
++ * Note that only solid colors are supported.
++ * @beautiful beautiful.border_color_marked
++ * @param color
++ * @see request::border
++ */
++
+ /**
+  * The fallback border color when the client is floating.
+  *","The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?"
+1423,"@@ -0,0 +1,19 @@
++module.exports = {
++  roots: [
++    ""<rootDir>/javascript/grid-ui/src""
++  ],
++  testMatch: [
++    ""<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx""
++  ],
++  transform: {
++    ""^.+\\.(ts|tsx)$"": ""ts-jest""
++  },
++  moduleFileExtensions: [""ts"", ""tsx"", ""js"", ""jsx"", ""json"", ""node""],
++  snapshotSerializers: [""enzyme-to-json/serializer""],
++  setupFilesAfterEnv: [""<rootDir>/setupTests.ts""],
++  testEnvironment: ""jsdom"",
++  moduleNameMapper: {
++    "".+\\.(svg|png|jpg|css)$"": ""identity-obj-proxy"",
++    ""selenium/javascript/grid-ui/(.*)"": ""<rootDir>/$1""
++  }
++}","We don't need this file, we can use the one that is in the grid-ui directory"
+1424,"@@ -48,6 +48,10 @@ public class BazelIgnoreParser {
+
+     try {
+       for (String path : FileOperationProvider.getInstance().readAllLines(bazelIgnoreFile)) {
++        if (!isEmptyLine(path)) {
++          continue;
++        }
++
+         if (path.endsWith(""/"")) {
+           // .bazelignore allows the ""/"" path suffix, but WorkspacePath doesn't.
+           path = path.substring(0, path.length() - 1);",FYI: inlined this method in the internal review.
+1425,"@@ -17,10 +17,8 @@ import org.junit.Test;
+ import org.junit.runner.RunWith;
+
+ import java.util.ArrayList;
+-import java.util.Arrays;
+ import java.util.Date;
+ import java.util.List;
+-import java.util.concurrent.CountDownLatch;
+ import java.util.concurrent.TimeUnit;
+
+ import de.danoeh.antennapod.core.feed.Feed;","Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff"
+1426,"@@ -47,7 +47,7 @@ namespace OpenTelemetry.Exporter
+             foreach (var metric in exporter.Metrics)
+             {
+                 var builder = new PrometheusMetricBuilder()
+-                    .WithName(metric.Name)
++                    .WithName(metric.Meter.Name + metric.Name)
+                     .WithDescription(metric.Description);
+
+                 switch (metric.MetricType)","Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter."
+1427,"@@ -78,10 +78,17 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+
++        $config = $this->getConfig();
++        $allowConnectingCards = !empty(
++            $config->Catalog
++                ->auth_based_library_cards
++        ) &&
++            ($this->getAuthManager()->getAuthMethod() == 'Shibboleth');
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'allowConnectingCards' => $allowConnectingCards,
+             ]
+         );
+     }","The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction."
+1428,"@@ -1791,7 +1791,7 @@ create_and_initialize_module_data(app_pc start, app_pc end, app_pc entry_point,
+             copy->segments[i].end = os_segments[i].end;
+             copy->segments[i].prot = os_segments[i].prot;
+         }
+-    } else
++    } else if (segments != NULL)
+         memcpy(copy->segments, segments, num_segments*sizeof(module_segment_data_t));
+     copy->timestamp = timestamp;
+ # ifdef MACOS","One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too."
+1429,"@@ -106,7 +106,11 @@ class User < ActiveRecord::Base
+
+   def self.from_oauth_hash(auth_hash)
+     user_data = auth_hash.extra.raw_info.to_hash
+-    self.find_or_create_by(email_address: user_data['email'])
++    user = self.for_email(user_data['email'])
++    if user_data['first_name'].present? && user_data['last_name'].present?
++      user.update_attributes(first_name: user_data['first_name'], last_name: user_data['last_name'])
++    end
++    user
+   end
+
+   def role_on(proposal)",I'm surprised rubocop isn't picking up singe quotes?
+1430,"@@ -251,14 +251,7 @@ import (
+ var _ time.Duration
+ var _ strings.Reader
+ var _ aws.Config
+-
+-func parseTime(layout, value string) *time.Time {
+-	t, err := time.Parse(layout, value)
+-	if err != nil {
+-		panic(err)
+-	}
+-	return &t
+-}
++var _, _ = protocol.ParseTime(""unixTimestamp"", ""2016-09-27T15:50Z"")
+
+ `))
+ ",Is this line still needed?
+1431,"@@ -153,10 +153,8 @@ bool EDPSimple::createSEDPEndpoints()
+         watt.endpoint.multicastLocatorList = this->mp_PDP->getLocalParticipantProxyData()->m_metatrafficMulticastLocatorList;
+         //watt.endpoint.remoteLocatorList = m_discovery.initialPeersList;
+         watt.endpoint.durabilityKind = TRANSIENT_LOCAL;
+-        watt.times.nackResponseDelay.seconds = 0;
+-        watt.times.nackResponseDelay.fraction = 0;
+-        watt.times.initialHeartbeatDelay.seconds = 0;
+-        watt.times.initialHeartbeatDelay.fraction = 0;
++        watt.times.heartbeatPeriod.seconds = 1;
++        watt.times.heartbeatPeriod.fraction = 0;
+         if(mp_RTPSParticipant->getRTPSParticipantAttributes().throughputController.bytesPerPeriod != UINT32_MAX &&
+                 mp_RTPSParticipant->getRTPSParticipantAttributes().throughputController.periodMillisecs != 0)
+             watt.mode = ASYNCHRONOUS_WRITER;","Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?"
+1432,"@@ -21,9 +21,10 @@ import inputCore
+
+ #: The directory in which liblouis braille tables are located.
+ TABLES_DIR = r""louis\tables""
++PATTERNS_TABLE = os.path.join(TABLES_DIR, ""braille-patterns.cti"")
+
+-#: The table file names and information.
+-TABLES = (
++#: The braille table file names and information.
++tables = [
+ 	# (fileName, displayName, supportsInput),
+ 	# Translators: The name of a braille table displayed in the
+ 	# braille settings dialog.","nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots."
+1433,"@@ -104,9 +104,6 @@ type Builder struct {
+
+ 	// MachineNetwork is the subnet to use for the cluster's machine network.
+ 	MachineNetwork string
+-
+-	// SkipMachinePoolGeneration is set to skip generating MachinePool objects
+-	SkipMachinePoolGeneration bool
+ }
+
+ // Validate ensures that the builder's fields are logically configured and usable to generate the cluster resources.",Why are we removing the option to skip machine pool generation?
+1434,"@@ -0,0 +1,9 @@
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpStartLineHandler
++    {
++        void OnStartLine(HttpMethod method, HttpVersion version, Span<byte> target, Span<byte> path, Span<byte> query, Span<byte> customMethod);
++    }
++}","""Request line"" here too."
+1435,"@@ -1292,6 +1292,19 @@ void Corpse::LootItem(Client *client, const EQApplicationPacket *app)
+ 		std::vector<EQ::Any> args;
+ 		args.push_back(inst);
+ 		args.push_back(this);
++		if (RuleB(Zone, UseZoneController)) {
++			if (entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)){
++				if (parse->EventNPC(EVENT_LOOT_ZONE, entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)->CastToNPC(), client, buf, 0, &args) != 0) {
++					lootitem->auto_loot = -1;
++					client->MessageString(Chat::Red, LOOT_NOT_ALLOWED, inst->GetItem()->Name);
++					client->QueuePacket(app);
++					delete inst;
++					return;
++				}
++			}
++		}
++
++
+ 		if (parse->EventPlayer(EVENT_LOOT, client, buf, 0, &args) != 0) {
+ 			lootitem->auto_loot = -1;
+ 			client->MessageString(Chat::Red, LOOT_NOT_ALLOWED, inst->GetItem()->Name);",Please remove this.
+1436,"@@ -15,6 +15,7 @@ class Organization::Affiliated < Organization::AccountFacts
+     accounts = @organization.accounts.joins([:person, :positions])
+     accounts = accounts.group('accounts.id, people.kudo_position').order('kudo_position nulls last')
+     accounts.paginate(per_page: limit, page: page)
++    Account.paginate_by_sql(accounts.to_sql, per_page: limit, page: page)
+   end
+
+   def projects(page = 1, limit = 10)","Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated."
+1437,"@@ -75,6 +75,12 @@ class Analysis < ActiveRecord::Base
+     end.compact.join(' AND ')
+   end
+
++  def allowed_tuples
++    [].tap do |tuples|
++      analysis_sloc_sets.each { |analysis_sloc_set| tuples << analysis_sloc_set.allowed_tuples }
++    end.compact.join(' AND ')
++  end
++
+   def angle
+     (Math.atan(hotness_score) * 180 / Math::PI).round(3)
+   end",This can be simplified as discussed before.
+1438,"@@ -1,7 +1,14 @@
+ package execute
+
+-import ""github.com/influxdata/flux""
++import (
++	""github.com/influxdata/flux""
++	""github.com/influxdata/flux/execute/table""
++)
+
+ func NewProcessMsg(tbl flux.Table) ProcessMsg {
+ 	return &processMsg{table: tbl}
+ }
++
++func NewProcessChunkMsg(chunk table.Chunk) ProcessChunkMsg {
++	return &processChunkMsg{chunk: chunk}
++}",Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?
+1439,"@@ -12,7 +12,7 @@ describe('Transaction deserialization', function() {
+     vectors_valid.forEach(function(vector) {
+       if (vector.length > 1) {
+         var hexa = vector[1];
+-        Transaction(hexa).serialize().should.equal(hexa);
++        Transaction(hexa).serialize(true).should.equal(hexa);
+         index++;
+       }
+     });",does this boolean indicate unsafe serialization?
+1440,"@@ -332,6 +332,13 @@ class Realm {
+      */
+     static deleteFile(config) {}
+
++    /**
++     * Copy bundled Realm files to app's default file folder.
++     * This is not implemented for node.js.
++     * @throws {Error} If an I/O error occured or method is not implemented.
++     */
++    static copyBundledRealmFiles() {}
++
+     /**
+      * Get a list of subscriptions. THIS METHOD IS IN BETA AND MAY CHANGE IN FUTURE VERSIONS.
+      * @param {string} name - Optional parameter to query for either a specific name or pattern (using",Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case).
+1441,"@@ -246,8 +246,15 @@ public abstract class PageStreamingConfig {
+     if (pageSizeField == null) {
+       // TODO: Conform to design doc spec, once approved, for using non-standard paging fields
+       //       (such as max_results for page_size)
+-      if (language == TargetLanguage.JAVA && transportProtocol == TransportProtocol.HTTP) {
+-        pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++      if (transportProtocol == TransportProtocol.HTTP) {
++        if (language == TargetLanguage.JAVA) {
++          pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++        } else if (language == TargetLanguage.PHP) {
++          FieldModel resourcesField = ProtoPageStreamingTransformer.getResourcesField(methodModel);
++          if (resourcesField != null && !resourcesField.isMap()) {
++            pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++          }
++        }
+       }
+     }
+     ProtoField responseTokenField =",Do we not need this in Java because Java *is* handling map responses?
+1442,"@@ -279,6 +279,14 @@ class Task(object):
+                 except BaseException:
+                     logger.exception(""Error in event callback for %r"", event)
+
++    @property
++    def accepted_messages(self):
++        """"""
++        Configures which scheduler messages can be received and returns them. When falsy, this tasks
++        does not accept any message. When True, all messages are accepted.
++        """"""
++        return False
++
+     @property
+     def task_module(self):
+         ''' Returns what Python module to import to get access to this class. '''","Maybe ""For configuring which scheduler messages can be received.""?"
+1443,"@@ -141,7 +141,7 @@ class SyncThumbsCommand extends BaseCommand
+             }
+
+             //clear entity manager for saving memory
+-            $this->getMediaManager()->getEntityManager()->clear();
++            $this->getMediaManager()->getObjectManager()->clear();
+
+             if ($batchesLimit > 0 && $batchCounter == $batchesLimit) {
+                 break;","It will stop working with orm, so this is not a good fix, Try using some method in a common interface"
+1444,"@@ -40,7 +40,11 @@ namespace OpenTelemetry.Collector.Dependencies
+         {
+             this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(
+                 new Dictionary<string, Func<ITracer, Func<HttpRequestMessage, ISampler>, ListenerHandler>>()
+-                { { ""HttpHandlerDiagnosticListener"", (t, s) => new HttpHandlerDiagnosticListener(t, s) } },
++                {
++                    { ""HttpHandlerDiagnosticListener"", (t, s) => new HttpHandlerDiagnosticListener(t, s) },
++                    { ""Azure.Clients"", (t, s) => new AzureSdkDiagnosticListener(""Azure.Clients"", t, sampler) },
++                    { ""Azure.Pipeline"", (t, s) => new AzureSdkDiagnosticListener(""Azure.Pipeline"", t, sampler) },
++                },
+                 tracer,
+                 x =>
+                 {",`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`
+1445,"@@ -83,9 +83,14 @@ public class PojoOperationGenerator extends AbstractOperationGenerator {
+     bodyModel = new ModelImpl();
+     bodyModel.setType(ModelImpl.OBJECT);
+     for (ParameterGenerator parameterGenerator : bodyFields) {
+-      SwaggerUtils.addDefinitions(swagger, parameterGenerator.getGenericType());
++      parameterGenerator.setHttpParameterType(HttpParameterType.BODY);
++      scanMethodParameter(parameterGenerator);
++
+       Property property = ModelConverters.getInstance().readAsProperty(parameterGenerator.getGenericType());
++      property.setDescription(parameterGenerator.getGeneratedParameter().getDescription());
+       bodyModel.addProperty(parameterGenerator.getParameterName(), property);
++
++      parameterGenerator.setHttpParameterType(null);
+     }
+     swagger.addDefinition(simpleRef, bodyModel);
+ ",This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?
+1446,"@@ -741,7 +741,7 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
+ 			return nil, nil, err
+ 		}
+ 		log.Debug(""Completed remote build action for %s"", target)
+-		if err := c.verifyActionResult(target, command, digest, response.Result, false, isTest); err != nil {
++		if err := c.verifyActionResult(target, command, digest, response.Result, c.state.Config.Remote.VerifyOutputs && !isTest, isTest); err != nil {
+ 			return metadata, response.Result, err
+ 		}
+ 		c.locallyCacheResults(target, digest, metadata, response.Result)",Why did this change?
+1447,"@@ -55,11 +55,14 @@ func (c *client) DescribeTable(ctx context.Context, region string, tableName str
+
+ 	globalSecondaryIndexes := getGlobalSecondaryIndexes(result.Table.GlobalSecondaryIndexes)
+
++	status := newProtoForTableStatus(result.Table.TableStatus)
++
+ 	ret := &dynamodbv1.Table{
+ 		Name:                   aws.ToString(result.Table.TableName),
+ 		Region:                 region,
+ 		GlobalSecondaryIndexes: globalSecondaryIndexes,
+ 		ProvisionedThroughput:  currentCapacity,
++		Status:                 status,
+ 	}
+ 	return ret, nil
+ }",nit: `status` collides with imported package named `status`
+1448,"@@ -584,6 +584,14 @@ func (l *Ledger) trackerEvalVerified(blk bookkeeping.Block, accUpdatesLedger led
+ 	return eval(context.Background(), accUpdatesLedger, blk, false, nil, nil)
+ }
+
++// IsWritingCatchpointFile returns true when a catchpoint file is being generated. The function is used by the catchup service so
++// that the memory pressure could be decreased until the catchpoint file writing is complete.
++func (l *Ledger) IsWritingCatchpointFile() bool {
++	l.trackerMu.RLock()
++	defer l.trackerMu.RUnlock()
++	return l.accts.IsWritingCatchpointFile()
++}
++
+ // A txlease is a transaction (sender, lease) pair which uniquely specifies a
+ // transaction lease.
+ type txlease struct {","""memory pressure could be decreased"" --> ""to avoid memory pressure"""
+1449,"@@ -426,8 +426,11 @@ class TestTimescaleListenStore(DatabaseTestCase):
+         self.assertEqual(count + 1, int(cache.get(user_key, decode=False) or 0))
+
+     def test_delete_listens(self):
+-        self._create_test_data(self.testuser_name)
+-        listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=self.testuser_name, to_ts=1400000300)
++        uid = random.randint(2000, 1 << 31)
++        testuser = db_user.get_or_create(uid, ""user_%d"" % uid)
++        testuser_name = testuser['musicbrainz_id']
++        self._create_test_data(testuser_name)
++        listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=testuser_name, to_ts=1400000300)
+         self.assertEqual(len(listens), 5)
+         self.assertEqual(listens[0].ts_since_epoch, 1400000200)
+         self.assertEqual(listens[1].ts_since_epoch, 1400000150)",I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect.
+1450,"@@ -169,6 +169,11 @@ export class CollapsibleColumns extends BasePlugin {
+         });
+
+       } else if (Array.isArray(collapsibleColumns)) {
++
++        this.headerStateManager.mapState(() => {
++          return { collapsible: false };
++        });
++
+         this.headerStateManager.mergeStateWith(collapsibleColumns);
+       }
+     }",I'm thinking about covering this change with the test. Can you do that?
+1451,"@@ -41,7 +41,7 @@ var (
+
+ // NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
+ type NATProviderPinger interface {
+-	PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
++	PingProvider(ip string, cPorts, pPorts []int, proxyPort int) (*net.UDPConn, error)
+ }
+
+ // NATPinger is responsible for pinging nat holes",Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?
+1452,"@@ -373,7 +373,13 @@ func (dg *dockerGoClient) pullImage(image string, authData *apicontainer.Registr
+ 		return CannotGetDockerClientError{version: dg.version, err: err}
+ 	}
+
+-	authConfig, err := dg.getAuthdata(image, authData)
++	sdkAuthConfig, err := dg.getAuthdata(image, authData)
++	authConfig := docker.AuthConfiguration{
++		Username:      sdkAuthConfig.Username,
++		Password:      sdkAuthConfig.Password,
++		Email:         sdkAuthConfig.Email,
++		ServerAddress: sdkAuthConfig.ServerAddress,
++	}
+ 	if err != nil {
+ 		return wrapPullErrorAsNamedError(err)
+ 	}",Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?
+1453,"@@ -31,6 +31,8 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
+
+         public string BlobNamePrefix { get; set; }
+
++        public ITaskItem[] BlobNames { get; set; }
++
+         public override bool Execute()
+         {
+             return ExecuteAsync().GetAwaiter().GetResult();",Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?
+1454,"@@ -22,5 +22,7 @@ describe('Client Side Encryption', function() {
+     return testContext.setup(this.configuration);
+   });
+
+-  generateTopologyTests(testSuites, testContext);
++  generateTopologyTests(testSuites, testContext, spec => {
++    return !spec.description.match(/type=regex/);
++  });
+ });",Can you leave a note about why we are skipping regex tests?
+1455,"@@ -55,10 +55,15 @@ var initCmd = &cmds.Command{
+ 		if err != nil {
+ 			return err
+ 		}
+-		rep, err := repo.CreateRepo(repoDir, newConfig)
++
++		if err := repo.InitFSRepo(repoDir, newConfig); err != nil {
++			return err
++		}
++		rep, err := repo.OpenFSRepo(repoDir)
+ 		if err != nil {
+ 			return err
+ 		}
++
+ 		// The only error Close can return is that the repo has already been closed
+ 		defer rep.Close() // nolint: errcheck
+ ","This was the only caller of CreateRepo, so I inlined it."
+1456,"@@ -109,6 +109,8 @@ type VaultAuth struct {
+ 	TokenSecretRef SecretKeySelector `json:""tokenSecretRef,omitempty""`
+ 	// This Secret contains a AppRole and Secret
+ 	AppRole VaultAppRole `json:""appRole,omitempty""`
++	// Where the authentication path is mounted in Vault.
++	AuthPath string `json:""authPath,omitempty""`
+ }
+
+ type VaultAppRole struct {","As this is already a child of `auth`, I think we can shorten this to `path`"
+1457,"@@ -297,6 +297,14 @@ class UIATextInfo(textInfos.TextInfo):
+ 		elif position==textInfos.POSITION_LAST:
+ 			self._rangeObj=self.obj.UIATextPattern.documentRange
+ 			self.collapse(True)
++		elif position in (textInfos.POSITION_FIRSTVISIBLE, textInfos.POSITION_LASTVISIBLE):
++			try:
++				visiRanges = self.obj.UIATextPattern.GetVisibleRanges()
++				element = 0 if position == textInfos.POSITION_FIRSTVISIBLE else visiRanges.length - 1
++				self._rangeObj = visiRanges.GetElement(0)
++			except COMError:
++				# Error: FIRST_VISIBLE position not supported by the UIA text pattern.
++				raise NotImplementedError
+ 		elif position==textInfos.POSITION_ALL or position==self.obj:
+ 			self._rangeObj=self.obj.UIATextPattern.documentRange
+ 		elif isinstance(position,UIA) or isinstance(position,UIAHandler.IUIAutomationElement):","This call should use element, not 0 I think."
+1458,"@@ -223,6 +223,8 @@ type Options struct {
+ 	ChunkSize                   fs.SizeSuffix        `config:""chunk_size""`
+ 	NoChunk                     bool                 `config:""no_chunk""`
+ 	Enc                         encoder.MultiEncoder `config:""encoding""`
++	FetchUntilEmptyPage         bool                 `config:""fetch_until_empty_page""`
++	PartialPageFetchThreshold   int                  `config:""partial_page_fetch_threshold""`
+ }
+
+ // Fs represents a remote swift server",This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above.
+1459,"@@ -170,8 +170,8 @@ module Selenium
+
+           def macosx_path
+             path = ""/Applications/Firefox.app/Contents/MacOS/firefox-bin""
+-            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(path)
+-            path = Platform.find_binary(""firefox-bin"") unless File.exist?(path)
++            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(File.expand_path(path))
++            path = Platform.find_binary(""firefox-bin"") unless File.exist?(File.expand_path?(path))
+
+             path
+           end",I don't think this one needs to be changed since the only previous path is already an absolute one.
+1460,"@@ -200,7 +200,7 @@ public class BaseExpireSnapshotsSparkAction
+   }
+
+   private Dataset<Row> buildValidFileDF(TableMetadata metadata) {
+-    Table staticTable = newStaticTable(metadata, this.table.io());
++    Table staticTable = newStaticTable(metadata, this.table.io(), table.locationProvider());
+     return appendTypeString(buildValidDataFileDF(staticTable), DATA_FILE)
+         .union(appendTypeString(buildManifestFileDF(staticTable), MANIFEST))
+         .union(appendTypeString(buildManifestListDF(staticTable), MANIFEST_LIST));",Since we kept the original constructor we might not need this change now.
+1461,"@@ -130,6 +130,7 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+     }
+
+     refreshFromMetadataLocation(metadataLocation);
++    LOG.debug(""Refreshed [{}]"", fullName);
+   }
+
+   @Override","There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one."
+1462,"@@ -21,6 +21,8 @@ import (
+ 	""net/http""
+ 	""time""
+
++	""github.com/pipe-cd/pipe/pkg/filestore/minio""
++
+ 	jwtgo ""github.com/dgrijalva/jwt-go""
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""",This should be in the last group.
+1463,"@@ -106,6 +106,7 @@ namespace Datadog.Trace.Agent
+                     {
+                         // stop retrying
+                         Log.Error(exception, ""An error occurred while sending traces to the agent at {0}"", _tracesEndpoint);
++                        _statsd?.Send();
+                         return false;
+                     }
+ ","I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named ""unit test improvements"""
+1464,"@@ -0,0 +1,8 @@
++// +k8s:deepcopy-gen=package,register
++// +k8s:conversion-gen=github.com/munnerz/cert-manager/pkg/apis/certmanager
++// +k8s:openapi-gen=true
++// +k8s:defaulter-gen=TypeMeta
++
++// Package v1alpha1 is the v1alpha1 version of the API.
++// +groupName=certmanager.k8s.io
++package v1alpha1","I've gone with this group name, however I'm open to suggestions on alternatives!"
+1465,"@@ -32,6 +32,7 @@ public class RpcApis {
+   public static final RpcApi TX_POOL = new RpcApi(""TXPOOL"");
+   public static final RpcApi TRACE = new RpcApi(""TRACE"");
+   public static final RpcApi PLUGINS = new RpcApi(""PLUGINS"");
++  public static final RpcApi QUORUM = new RpcApi(""QUORUM"");
+
+   public static final List<RpcApi> DEFAULT_JSON_RPC_APIS = Arrays.asList(ETH, NET, WEB3);
+ ",should this be GOQUORUM
+1466,"@@ -49,7 +49,7 @@ type (
+ var cpuprofile = flag.String(""cpuprofile"", """", ""write cpu profile to file"")
+
+ // Validate for the byzantine node uses the actual block validator and returns the opposite
+-func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B) error {
++func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B, checkCoinbase bool) error {
+ 	//err := v.val.Validate(blk, tipHeight, tipHash)
+ 	//if err != nil {
+ 	//	return nil","I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0."
+1467,"@@ -24,14 +24,13 @@ import (
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/db""
+ 	""github.com/iotexproject/iotex-core/state""
+-	""github.com/iotexproject/iotex-core/state/factory""
+ 	""github.com/iotexproject/iotex-core/test/identityset""
+ 	""github.com/iotexproject/iotex-core/test/mock/mock_chainmanager""
+ 	""github.com/iotexproject/iotex-election/test/mock/mock_committee""
+ 	""github.com/iotexproject/iotex-election/types""
+ )
+
+-func initConstruct(t *testing.T) (Protocol, context.Context, factory.WorkingSet, *types.ElectionResult) {
++func initConstruct(t *testing.T) (Protocol, context.Context, protocol.StateManager, *types.ElectionResult) {
+ 	require := require.New(t)
+ 	ctrl := gomock.NewController(t)
+ 	defer ctrl.Finish()","same here, move it out"
+1468,"@@ -42,11 +42,17 @@
+ //@HEADER
+ */
+
++#ifndef KOKKOS_TOOLS_INDEPENDENT_BUILD
+ #include <Kokkos_Macros.hpp>
+ #include <Kokkos_Tuners.hpp>
++#endif
++
+ #include <impl/Kokkos_Profiling.hpp>
+-#if defined(KOKKOS_ENABLE_LIBDL)
++#include <impl/Kokkos_Profiling_Interface.hpp>
++
++#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)
+ #include <dlfcn.h>
++#define KOKKOS_TOOLS_ENABLE_LIBDL
+ #endif
+
+ #include <algorithm>",Can you elaborate on why you need different behavior depending on Tools being built independently or not?
+1469,"@@ -18,7 +18,8 @@ class AnnotationsController < ApplicationController
+     guid_save = guidance.present? ? guidance.save : true
+
+     if ex_save && guid_save
+-      redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: _('Information was successfully created.')
++      typ = (!ex_save && !guid_save ? 'example answer and guidance' : (!guid_save ? 'guidance' : 'example answer'))
++      redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: success_message(typ, _('created'))
+     else
+       @section = @question.section
+       @phase = @section.phase","because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`"
+1470,"@@ -5,6 +5,7 @@ import (
+ 	""testing""
+
+ 	""github.com/stretchr/testify/assert""
++	""golang.org/x/net/context""
+
+ 	""github.com/sonm-io/core/insonmnia/structs""
+ 	pb ""github.com/sonm-io/core/proto""",why not context from stdlib?
+1471,"@@ -48,7 +48,7 @@ func GenerateCRC32(
+ 	return Checksum{
+ 		Value:   checksum,
+ 		Version: payloadVersion,
+-		Flavor:  FlavorIEEECRC32OverThriftBinary,
++		Flavor:  FlavorIEEECRC32OverProto3Binary,
+ 	}, nil
+ }
+ ",Just saw this and wasn't able to hold myself from renaming :-).
+1472,"@@ -278,9 +278,7 @@ describe('src/Core', () => {
+       plugins: {},
+       totalProgress: 0
+     })
+-    expect(core.plugins.acquirer[0].mocks.uninstall.mock.calls.length).toEqual(
+-      1
+-    )
++    expect(core.plugins[Object.keys(core.plugins)[0]].length).toEqual(0)
+   })
+
+   describe('upload hooks', () => {",Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too
+1473,"@@ -109,7 +109,7 @@ module RSpec
+         def warn_if_key_taken(source, key, new_block)
+           return unless existing_block = example_block_for(source, key)
+
+-          Kernel.warn <<-WARNING.gsub(/^ +\|/, '')
++          RSpec.warn_with <<-WARNING.gsub(/^ +\|/, '')
+             |WARNING: Shared example group '#{key}' has been previously defined at:
+             |  #{formatted_location existing_block}
+             |...and you are now defining it at:","`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(."
+1474,"@@ -12,6 +12,19 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/types""
+ )
+
++// MessageTimeOut is the number of tipsets we should receive before timing out messages
++const MessageTimeOut = 6
++
++type timedmessage struct {
++	message *types.SignedMessage
++	addedAt uint64
++}
++
++// BlockTimer defines a interface to a struct that can give the current block height.
++type BlockTimer interface {
++	BlockHeight() (uint64, error)
++}
++
+ // MessagePool keeps an unordered, de-duplicated set of Messages and supports removal by CID.
+ // By 'de-duplicated' we mean that insertion of a message by cid that already
+ // exists is a nop. We use a MessagePool to store all messages received by this node","FYI In the message queue I use the term ""stamp"" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to ""blocks"" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the ""business logic"". This is just an observation, take or ignore as you wish."
+1475,"@@ -508,8 +508,13 @@ def remove_xml_preamble(response):
+ # --------------
+ def get_lifecycle(bucket_name):
+     bucket_name = normalize_bucket_name(bucket_name)
++    exists, code, body = is_bucket_available(bucket_name)
++    if not exists:
++        return requests_response(body, status_code=code)
++
+     lifecycle = BUCKET_LIFECYCLE.get(bucket_name)
+     status_code = 200
++
+     if not lifecycle:
+         # TODO: check if bucket actually exists
+         lifecycle = {",Can we remove the `TODO` statement here? (as this is actually fixed in this PR)
+1476,"@@ -198,6 +198,7 @@ public class Account implements BaseAccount, StoreConfig {
+     private SortType mSortType;
+     private Map<SortType, Boolean> mSortAscending = new HashMap<SortType, Boolean>();
+     private ShowPictures mShowPictures;
++    private DisplayPreference mDisplayPreference;
+     private boolean mIsSignatureBeforeQuotedText;
+     private Expunge mExpungePolicy = Expunge.EXPUNGE_IMMEDIATELY;
+     private int mMaxPushFolders;",m prefix no longer in code style
+1477,"@@ -168,6 +168,10 @@ func (kvb *kvStoreWithBuffer) MustDelete(ns string, key []byte) {
+ 	kvb.buffer.Delete(ns, key, ""failed to delete %x in %s"", key, ns)
+ }
+
++func (kvb *kvStoreWithBuffer) Filter(ns string, c Condition) ([][]byte, [][]byte, error) {
++	return kvb.store.Filter(ns, c)
++}
++
+ func (kvb *kvStoreWithBuffer) WriteBatch(b batch.KVStoreBatch) (err error) {
+ 	b.Lock()
+ 	defer func() {",need to filter the entities in buffer as well
+1478,"@@ -12,6 +12,7 @@ import java.nio.charset.Charset;
+ import java.security.MessageDigest;
+
+ public class FastBlurTransformation extends BitmapTransformation {
++    private static final String ID=""de.danoeh.antennapod.core.glide.FastBlurTransformation"";
+
+     private static final String TAG = FastBlurTransformation.class.getSimpleName();
+ ",Please add spaces before and after the equals sign
+1479,"@@ -49,7 +49,7 @@
+ #endif
+ #include ""common/sql.error_event.pb.h""
+ #include ""common/sql.info_event.pb.h""
+-#include ""wrapper/amqpwrapper.h""
++//#include ""wrapper/amqpwrapper.h""
+ #include ""sq_sql_eventids.h""
+ #include ""common/evl_sqlog_eventnum.h""
+ ",This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely.
+1480,"@@ -7,12 +7,13 @@ module RSpec::Core::Formatters
+     it 'produces the expected full output' do
+       output = run_example_specs_with_formatter('failures')
+       expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
+-        |./spec/rspec/core/resources/formatter_specs.rb:4:is marked as pending but passes
+-        |./spec/rspec/core/resources/formatter_specs.rb:36:fails
+-        |./spec/rspec/core/resources/formatter_specs.rb:40:fails twice
+-        |./spec/rspec/core/resources/formatter_specs.rb:47:fails with a backtrace that has no file
+-        |./spec/rspec/core/resources/formatter_specs.rb:53:fails with a backtrace containing an erb file
+-        |./spec/rspec/core/resources/formatter_specs.rb:71:raises
++        |./spec/rspec/core/resources/formatter_specs.rb:4:Expected example to fail since it is pending, but it passed.
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:37:expected: 2 got: 1 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:41:expected: 2 got: 1 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:42:expected: 4 got: 3 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:50:foo
++        |/foo.html.erb:1:Exception
++        |./spec/rspec/core/resources/formatter_specs.rb:71:boom
+       EOS
+     end
+   end",":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?"
+1481,"@@ -35,7 +35,7 @@ class WebDriver(ChromiumDriver):
+     def __init__(self, executable_path=""chromedriver"", port=DEFAULT_PORT,
+                  options=None, service_args=None,
+                  desired_capabilities=None, service_log_path=DEFAULT_SERVICE_LOG_PATH,
+-                 chrome_options=None, service=None, keep_alive=True):
++                 chrome_options=None, service=None, keep_alive=True, create_no_window=False):
+         """"""
+         Creates a new instance of the chrome driver.
+         Starts the service and then creates new instance of chrome driver.",We shouldn't add this as a new `kwarg` here. This should all be done on the options class
+1482,"@@ -134,6 +134,7 @@ module Beaker
+           :openstack_keyname      => ENV['OS_KEYNAME'],
+           :openstack_network      => ENV['OS_NETWORK'],
+           :openstack_region       => ENV['OS_REGION'],
++          :openstack_volume_support => ENV['OS_VOL_SUPPORT'] || true,
+           :jenkins_build_url      => nil,
+           :validate               => true,
+           :configure              => true,",Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?
+1483,"@@ -38,6 +38,8 @@
+ #include <flux/core.h>
+ #include ""heaptrace.h""
+
++static flux_msg_handler_t **handlers = NULL;
++
+ static void start_cb (flux_t *h, flux_msg_handler_t *mh,
+                       const flux_msg_t *msg, void *arg)
+ {","In C, file scope variables are already initialized to 0 so the ""= NULL"" is redundant. Not a big deal."
+1484,"@@ -2,7 +2,7 @@
+
+ var nodeName = node.nodeName.toUpperCase(),
+ 	nodeType = node.type,
+-	doc = document;
++	doc = axe.commons.dom.getRootNode(node);
+
+ if (node.getAttribute('aria-disabled') === 'true' || axe.commons.dom.findUp(node, '[aria-disabled=""true""]')) {
+ 	return false;","on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used"
+1485,"@@ -57,6 +57,7 @@ namespace OpenTelemetry.Internal
+             {
+                 throw new ArgumentOutOfRangeException(
+                     nameof(milliseconds),
++                    milliseconds,
+                     string.Format(CultureInfo.InvariantCulture, ""milliseconds must be between {0} and {1}"", MinMilliseconds, MaxMilliseconds));
+             }
+ ","nit: just to be similar to others, can you change to interpolation?"
+1486,"@@ -111,6 +111,9 @@ type ControllerOptions struct {
+ 	// CertificateRequest -> Order. Slice of string literals that are
+ 	// treated as prefixes for annotation keys.
+ 	CopiedAnnotationPrefixes []string
++
++	//Return full Certchain including root cert for k8s CSRs
++	FullCertChain bool
+ }
+
+ const (","Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?"
+1487,"@@ -10,6 +10,7 @@ class TargetType(Enum):
+     PANDAS = 'pandas'
+     FILE = 'file'
+
++SERVER_TIME_F = ""%Y-%m-%dT%H:%M:%S""
+ DATEF = '%F'
+ TIMEF = '%T'
+ DTIMEF = '%s %s' % (DATEF, TIMEF)","Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format)."
+1488,"@@ -212,8 +212,11 @@ func (r *createOrUpdate) Apply(obj *unstructured.Unstructured, subresources ...s
+ 		return
+ 	}
+ 	resource, err = r.options.Getter.Get(obj.GetName(), metav1.GetOptions{})
+-	if err != nil && apierrors.IsNotFound(errors.Cause(err)) {
+-		return r.options.Creator.Create(obj, subresources...)
++	if err != nil {
++		if apierrors.IsNotFound(errors.Cause(err)) {
++			return r.options.Creator.Create(obj, subresources...)
++		}
++		return nil, err
+ 	}
+ 	return r.options.Updater.Update(resource, obj, subresources...)
+ }","expected statement, found 'else' (and 1 more errors)"
+1489,"@@ -16,6 +16,17 @@ func FakeID(b byte, public bool) ID {
+ 	return ID{bytes}
+ }
+
++// FakeIDRandomOrBust creates a fake public or private TLF ID from the given
++// byte, and fill the rest with empty bytes.
++func FakeIDRandomOrBust(b byte, public bool) ID {
++	id, err := MakeRandomID(public)
++	if err != nil {
++		panic(err)
++	}
++	id.id[0] = b
++	return id
++}
++
+ // FakeIDByte returns the byte used to create a fake TLF ID with
+ // FakeID.
+ func FakeIDByte(id ID) byte {",IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`.
+1490,"@@ -0,0 +1,7 @@
++package constants
++
++const (
++	DeviceControllerModuleName   = ""devicecontroller""
++	CloudHubControllerModuleName = ""cloudhub""
++	EdgeControllerModuleName     = ""edgecontroller""
++)",What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?
+1491,"@@ -8,11 +8,12 @@ using System;
+ using System.Collections.Generic;
+ using System.IO;
+ using System.Linq;
+-using System.Reflection.Metadata;
+-using System.Reflection.PortableExecutable;
+ using System.Text;
+ using Newtonsoft.Json.Linq;
+ using Newtonsoft.Json;
++using System.Security.Cryptography;
++using System.Reflection.PortableExecutable;
++using System.Reflection.Metadata;
+
+ namespace Microsoft.DotNet.Build.Tasks
+ {",We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version.
+1492,"@@ -737,8 +737,10 @@ analyze_clean_call(dcontext_t *dcontext, clean_call_info_t *cci, instr_t *where,
+      * unless multiple regs are able to be skipped.
+      * XXX: This should probably be in arch-specific clean_call_opt.c.
+      */
++
+     if ((cci->num_simd_skip == 0 /* save all xmms */ &&
+-         cci->num_regs_skip == 0 /* save all regs */ &&
++        /* save all regs except 2, because XSP and XBP are commonly callee saved */
++         cci->num_regs_skip <= 2 &&
+          !cci->skip_save_flags) ||
+         always_out_of_line)
+         cci->out_of_line_swap = true;","Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change."
+1493,"@@ -23,6 +23,7 @@ import (
+ 	""go.opentelemetry.io/otel/api/kv""
+ 	""go.opentelemetry.io/otel/api/metric""
+ 	""go.opentelemetry.io/otel/api/metric/registry""
++	""go.opentelemetry.io/otel/sdk/instrumentation""
+ )
+
+ // This file contains the forwarding implementation of metric.Provider",Should the API have a dependency on the SDK?
+1494,"@@ -1475,7 +1475,7 @@ describe('Change Streams', function() {
+     }
+   });
+
+-  it('should resume piping of Change Streams when a resumable error is encountered', {
++  it.skip('should resume piping of Change Streams when a resumable error is encountered', {
+     metadata: {
+       requires: {
+         generators: true,",Is this a sometimes leaky test?
+1495,"@@ -96,7 +96,11 @@ func (v ConstraintGenerator) typeof(n Node) (PolyType, error) {
+ 		ftv := n.ExternType.freeVars(nil)
+ 		subst := make(Substitution, len(ftv))
+ 		for _, tv := range ftv {
+-			subst[tv] = v.cs.f.Fresh()
++			f := v.cs.f.Fresh()
++			for ftv.contains(f) {
++				f = v.cs.f.Fresh()
++			}
++			subst[tv] = f
+ 		}
+ 		t := subst.ApplyType(n.ExternType)
+ 		// Check if this type knows about its kind constraints","It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix."
+1496,"@@ -368,6 +368,11 @@ This initializes all modules such as audio, IAccessible, keyboard, mouse, and GU
+ 		wxLang=locale.FindLanguageInfo(lang.split('_')[0])
+ 	if hasattr(sys,'frozen'):
+ 		locale.AddCatalogLookupPathPrefix(os.path.join(os.getcwdu(),""locale""))
++	# #8064: Wx might know the language, but may not actually contain a translation database for that language.
++	# If we try to initialize this language, wx will show a warning dialog.
++	# Therefore treat this situation like wx not knowing the language at all.
++	if not locale.IsAvailable(wxLang.Language):
++		wxLang=None
+ 	if wxLang:
+ 		try:
+ 			locale.Init(wxLang.Language)",It might make sense to log this.
+1497,"@@ -340,12 +340,10 @@ module Blacklight
+       # too. These model names should not be `#dup`'ed or we might break ActiveModel::Naming.
+       def deep_copy
+         deep_dup.tap do |copy|
+-          copy.repository_class = self.repository_class
+-          copy.response_model = self.response_model
+-          copy.document_model = self.document_model
+-          copy.document_presenter_class = self.document_presenter_class
+-          copy.search_builder_class = self.search_builder_class
+-          copy.facet_paginator_class = self.facet_paginator_class
++          %w(repository_class response_model document_model document_presenter_class search_builder_class facet_paginator_class).each do |klass|
++            # Don't copy if nil, so as not to prematurely autoload default classes
++            copy.send(""#{klass}="", send(klass)) unless fetch(klass.to_sym, nil).nil?
++          end
+         end
+       end
+       alias_method :inheritable_copy, :deep_copy",Line is too long. [84/80]
+1498,"@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+
+
+ class Options(object):
++    KEY = ""goog:chromeOptions""
+
+     def __init__(self):
+         self._binary_location = ''",nice touch since Google likes to change things every now and then.
+1499,"@@ -0,0 +1,19 @@
++# Provides a helper utility for loading branding configs.
++module Branding
++
++  module_function
++
++  # Loads branding config from YAML file.
++  #
++  # @param keys [Array<Object>] A list of the keys to return configs for.
++  #
++  # @example Return a value
++  #   Branding.fetch(:settings, :should_work) # => true
++  #   Branding.fetch(:settings, :email) # => 'user@example.com'
++  #   Branding.fetch(:settings, :missing) # => nil
++  # @return [Object] The value of the config
++  def fetch(*keys)
++    keys = keys.map(&:to_sym)
++    Rails.configuration.branding.dig(*keys)
++  end
++end",Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :)
+1500,"@@ -29,6 +29,7 @@ class ResourceType(object):
+     FOLDER = 'folder'
+     PROJECT = 'project'
+     GROUP = 'group'
++    BACKEND_SERVICE = 'backend_service'
+     FORWARDING_RULE = 'forwarding_rule'
+     BUCKETS_ACL = 'buckets_acl'
+     CLOUDSQL_ACL = 'cloudsql_instances'",nit: Would you mind alpha-sorting this?
+1501,"@@ -55,6 +55,8 @@ public class ManifestFiles {
+    * @return a {@link ManifestReader}
+    */
+   public static ManifestReader read(ManifestFile manifest, FileIO io, Map<Integer, PartitionSpec> specsById) {
++    Preconditions.checkArgument(manifest.content() == ManifestContent.DATA,
++        ""Cannot read a delete manifest with a ManifestReader: %s"", manifest);
+     InputFile file = io.newInputFile(manifest.path());
+     InheritableMetadata inheritableMetadata = InheritableMetadataFactory.fromManifest(manifest);
+     return new ManifestReader(file, specsById, inheritableMetadata);","For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?"
+1502,"@@ -4,7 +4,7 @@
+   plan_title = @plan.title
+   user_name = @plan.owner.name
+   helpdesk_email = Rails.configuration.branding[:organisation][:helpdesk_email]
+-  contact_us_url = Rails.configuration.branding[:organisation][:contact_us_url]
++  contact_us = Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url
+   email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
+ %>
+ <% FastGettext.with_locale FastGettext.default_locale do %>",that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise.
+1503,"@@ -56,7 +56,7 @@ return [
+         'choose_file' => 'Datei auswählen',
+         'close' => 'Schließen',
+         'create' => 'Erstellen',
+-        'create_and_add_another' => 'Erstellen und weitere hinzufügen',
++        'create_and_add_another' => 'Erstellen und weiteres Element hinzufügen',
+         'create_and_continue' => 'Erstellen und weiter bearbeiten',
+         'save' => 'Speichern',
+         'save_and_continue' => 'Speichern und weiter bearbeiten',","We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other  "
+1504,"@@ -50,6 +50,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+
+   public abstract List<LongRunningOperationDetailView> longRunningDescriptors();
+
++  public abstract List<GrpcStreamingDetailView> grpcStreamingDescriptors();
++
+   public abstract List<String> methodKeys();
+
+   public abstract String clientConfigPath();",Is PHP the first dynamic MVVM language with grpc streaming support?
+1505,"@@ -41,6 +41,7 @@ SmilesMolSupplier::SmilesMolSupplier(const std::string &fileName,
+   if (!tmpStream || (!(*tmpStream)) || (tmpStream->bad())) {
+     std::ostringstream errout;
+     errout << ""Bad input file "" << fileName;
++    if (tmpStream) { delete tmpStream; }
+     throw BadFileException(errout.str());
+   }
+   dp_inStream = static_cast<std::istream *>(tmpStream);",the `if` isn't necessary here; it's safe to call `delete` on `nullptr`
+1506,"@@ -156,6 +156,12 @@ ReturnCode_t DataWriter::assert_liveliness()
+     return impl_->assert_liveliness();
+ }
+
++bool DataWriter::remove_all_changes(
++        size_t* removed)
++{
++    return impl_->remove_all_changes(removed);
++}
++
+ } // namespace dds
+ } // namespace fastdds
+ } // namespace eprosima",Change if the method's name finally changes to `clear_history` as proposed elsewhere
+1507,"@@ -34,9 +34,8 @@ def showHelp(helpId: str):
+ 		noHelpMessage = _(""No help available here."")
+ 		queueHandler.queueFunction(queueHandler.eventQueue, ui.message, noHelpMessage)
+ 		return
+-
+-	import gui
+-	helpFile = gui.getDocFilePath(""userGuide.html"")
++	import documentationUtils
++	helpFile = documentationUtils.getDocFilePath(""userGuide.html"")
+ 	if helpFile is None:
+ 		# Translators: Message shown when trying to display context sensitive help,
+ 		# indicating that	the user guide could not be found.",can this one also be moved to the top of the file?
+1508,"@@ -26,6 +26,8 @@ type AppliedToGroup struct {
+ 	metav1.ObjectMeta
+ 	// Pods is a list of Pods selected by this group.
+ 	Pods []GroupMemberPod
++	// GroupMembers is a list of resources selected by this group.
++	GroupMembers []GroupMember
+ }
+
+ // PodReference represents a Pod Reference.","So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?"
+1509,"@@ -1,13 +1,9 @@
+-using System;
+-using System.Collections.Generic;
+-
+-namespace Datadog.Tracer
++namespace Datadog.Tracer
+ {
+     public static class Tags
+     {
+-        public const string Service = ""Datadog.Service"";
+-        public const string Resource = ""Datadog.Resource"";
+-        public const string Error = ""Datadog.Error"";
+-        public const string Type = ""Datadog.Type"";
++        public const string ServiceName = ""service.name"";
++        public const string ResourceName = ""resource.name"";
++        public const string SpanType = ""span.type"";
+     }
+ }",Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?
+1510,"@@ -19,7 +19,7 @@ REPORT_FREQUENCY = 5000
+ SUBSCRIBER_NAME = ""bq""
+ KEYSPACE_NAME_INCOMING = ""ilisten""
+ KEYSPACE_NAME_UNIQUE = ""ulisten""
+-APP_CREDENTIALS_FILE = ""bigquery-credentials.json""
++APP_CREDENTIALS_FILE = os.environ['GOOGLE_APPLICATION_CREDENTIALS']
+
+ # TODO:
+ #   Big query hardcoded data set ids",will this fail if the env variable doesn't exist? Is this the preferred behaviour?
+1511,"@@ -325,8 +325,9 @@ class SpatialPooler(object):
+
+     # Initialize a tiny random tie breaker. This is used to determine winning
+     # columns where the overlaps are identical.
+-    self._tieBreaker = 0.01*numpy.array([self._random.getReal64() for i in
+-                                        xrange(self._numColumns)])
++    self._tieBreaker = numpy.array([0.01 * self._random.getReal64() for i in
++                                      xrange(self._numColumns)],
++                                    dtype=realDType)
+
+     # 'self._connectedSynapses' is a similar matrix to 'self._permanences'
+     # (rows represent cortical columns, columns represent input bits) whose",bad line wrap
+1512,"@@ -1245,6 +1245,14 @@ void rai::bootstrap_server::receive_header_action (boost::system::error_code con
+ 					});
+ 					break;
+ 				}
++				case rai::message_type::bulk_pull_blocks:
++				{
++					auto this_l (shared_from_this ());
++					boost::asio::async_read (*socket, boost::asio::buffer (receive_buffer.data () + 8, sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (bulk_pull_blocks_mode) + sizeof (uint32_t)), [this_l](boost::system::error_code const & ec, size_t size_a) {
++						this_l->receive_bulk_pull_blocks_action (ec, size_a);
++					});
++					break;
++				}
+ 				case rai::message_type::frontier_req:
+ 				{
+ 					auto this_l (shared_from_this ());",What does the `8` here represent? Can you give it a name?
+1513,"@@ -0,0 +1,12 @@
++from pymatgen.ext.matproj import MPRester, TaskType
++import os
++material_ids = [""mp-32800"", ""mp-23494""]
++task_types = [TaskType.GGA_OPT, TaskType.GGA_UNIFORM]
++file_patterns = [""vasprun*"", ""OUTCAR*""]
++with MPRester(os.environ[""MP_API_KEY""]) as mpr:
++    meta, urls = mpr.get_download_info(
++        material_ids, task_types=task_types, file_patterns=file_patterns
++    )
++
++print(meta)
++print(urls)","`MPRester(os.environ[""MP_API_KEY""])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?"
+1514,"@@ -11,7 +11,7 @@
+ #
+ # It's strongly recommended to check this file into your version control system.
+
+-ActiveRecord::Schema.define(:version => 20121114193521) do
++ActiveRecord::Schema.define(:version => 20121212214215) do
+
+   create_table ""announcements"", :force => true do |t|
+     t.datetime ""created_at"",        :null => false",Looks like there may be more changes to this file than intended?
+1515,"@@ -117,7 +117,7 @@ func (eb *eventbus) pubCloudMsgToEdge() {
+ 			body, ok := accessInfo.GetContent().(map[string]interface{})
+ 			if !ok {
+ 				klog.Errorf(""Message is not map type"")
+-				return
++				continue
+ 			}
+ 			message := body[""message""].(map[string]interface{})
+ 			topic := message[""topic""].(string)","when message type is not expected, contine to next loop instead of return to finish infinite loop"
+1516,"@@ -2,6 +2,13 @@ package cmd
+
+ import (
+ 	""fmt""
++	""os""
++	osexec ""os/exec""
++	""path/filepath""
++	""strings""
++	""testing""
++	""time""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.
+1517,"@@ -84,6 +84,10 @@ func (r *AWSMachine) ValidateUpdate(old runtime.Object) error {
+ 	delete(oldAWSMachineSpec, ""providerID"")
+ 	delete(newAWSMachineSpec, ""providerID"")
+
++	// allow changes to instanceID
++	delete(oldAWSMachineSpec, ""instanceID"")
++	delete(newAWSMachineSpec, ""instanceID"")
++
+ 	// allow changes to additionalTags
+ 	delete(oldAWSMachineSpec, ""additionalTags"")
+ 	delete(newAWSMachineSpec, ""additionalTags"")",instanceID should stay the same for a AWSMachine?
+1518,"@@ -77,6 +77,7 @@ def _launch_local_catalog():
+     env = dict(REGISTRY_URL=""http://localhost:5000"",
+                S3_PROXY_URL=open_config[""s3Proxy""],
+                ALWAYS_REQUIRE_AUTH=""false"",
++               NO_DOWNLOAD=""false"",
+                CATALOG_MODE=""LOCAL"",
+                SSO_AUTH=""DISABLED"",
+                PASSWORD_AUTH=""ENABLED"",",Since this is a dict don't you want `False` or do we clean that up elsewhere?
+1519,"@@ -23,6 +23,7 @@ from luigi.scheduler import DISABLED, DONE, FAILED, CentralPlannerScheduler
+
+ luigi.notifications.DEBUG = True
+ WORKER = 'myworker'
++HOST = 'localhost'
+
+
+ class CentralPlannerTest(unittest.TestCase):",what's the reason you had to add the `host` argument to all `get_work` calls?
+1520,"@@ -37,6 +37,13 @@ public class UpdatePermissionRootCommand extends AbstractCommand<Dataverse> {
+ 		}
+ 	}
+
++    @Override
++    public boolean onSuccess(CommandContext ctxt, Object r) {
++        return ctxt.dataverses().index((Dataverse) r,true);
++    }
++
++
++    //TODO: Review this as this will never be an instance of Dataset, will it?
+     @Override
+     public Map<String, Set<Permission>> getRequiredPermissions() {
+         // for data file check permission on owning dataset",This will never be a dataset so we can simplify the code here
+1521,"@@ -89,6 +89,15 @@ public abstract class AbstractBlockProcessor implements BlockProcessor {
+
+   private final MiningBeneficiaryCalculator miningBeneficiaryCalculator;
+
++  public AbstractBlockProcessor(final AbstractBlockProcessor blockProcessor) {
++    this(
++        blockProcessor.transactionProcessor,
++        blockProcessor.transactionReceiptFactory,
++        blockProcessor.blockReward,
++        blockProcessor.miningBeneficiaryCalculator,
++        blockProcessor.skipZeroBlockRewards);
++  }
++
+   public AbstractBlockProcessor(
+       final TransactionProcessor transactionProcessor,
+       final MainnetBlockProcessor.TransactionReceiptFactory transactionReceiptFactory,",This should be moved into the PrivacyBlockProcessor instead of adding the constructor here.
+1522,"@@ -38,7 +38,7 @@ import (
+ 	""github.com/pipe-cd/pipe/pkg/crypto""
+ 	""github.com/pipe-cd/pipe/pkg/datastore""
+ 	""github.com/pipe-cd/pipe/pkg/git""
+-	""github.com/pipe-cd/pipe/pkg/insight""
++	insightfilestore ""github.com/pipe-cd/pipe/pkg/insight/insightstore""
+ 	""github.com/pipe-cd/pipe/pkg/model""
+ 	""github.com/pipe-cd/pipe/pkg/redis""
+ 	""github.com/pipe-cd/pipe/pkg/rpc/rpcauth""","nit: Remove ""insightfilestore"". I think ""insightstore"" is good enough and as I see we are using that name at other places too."
+1523,"@@ -5,8 +5,8 @@ module RSpec::Core::Formatters
+   BisectProgressFormatter = Class.new(remove_const :BisectProgressFormatter) do
+     RSpec::Core::Formatters.register self
+
+-    def bisect_round_finished(notification)
+-      return super unless notification.round == 3
++    def bisect_round_started(notification)
++      return super unless @round_count == 3
+
+       Process.kill(""INT"", Process.pid)
+       # Process.kill is not a synchronous call, so to ensure the output",It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though...
+1524,"@@ -29,6 +29,8 @@ from qutebrowser.mainwindow.statusbar.percentage import Percentage
+ def percentage(qtbot):
+     """"""Fixture providing a Percentage widget.""""""
+     widget = Percentage()
++    # Force immedate update of percentage widget
++    widget.set_perc.throttle_set(-1)
+     qtbot.add_widget(widget)
+     return widget
+ ","I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists."
+1525,"@@ -1,7 +1,7 @@
+ 'use strict';
+
+ const Aspect = {
+-  SKIP_SESSION: Symbol('SKIP_SESSION')
++  SKIP_SESSION: 'SKIP_SESSION'
+ };
+
+ /**",why remove `Symbol`?
+1526,"@@ -121,7 +121,7 @@ function getPunctuationRegExp() {
+ 	 * Reference: https://en.wikipedia.org/wiki/Supplemental_Punctuation
+ 	 * -> \u2E00-\u2E7F Reference
+ 	 */
+-	return /[\u2000-\u206F\u2E00-\u2E7F\\'!""#$%&()*+,\-.\/:;<=>?@\[\]^_`{|}~]/g;
++	return /[\u2000-\u206F\u2E00-\u2E7F\\'!""#$%&£¢¥§€()*+,\-.\/:;<=>?@\[\]^_`{|}~±]/g;
+ }
+
+ /**","Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\u20A0-\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)"
+1527,"@@ -71,6 +71,7 @@ setup(
+     # Metadata
+     author='Philippe BIONDI',
+     author_email='phil(at)secdev.org',
++    maintainer='Pierre LALET, Guillaume VALADON',
+     description='Scapy: interactive packet manipulation tool',
+     license='GPLv2',
+     url='http://www.secdev.org/projects/scapy',","You have forgotten a coma `,`"
+1528,"@@ -35,7 +35,8 @@ def single_gpu_test(model, data_loader, show=False, out_dir=None):
+                 img_show = mmcv.imresize(img_show, (ori_w, ori_h))
+
+                 if out_dir:
+-                    out_file = osp.join(out_dir, img_meta['filename'])
++                    out_file = osp.join(out_dir,
++                                        osp.basename(img_meta['filename']))
+                 else:
+                     out_file = None
+ ","For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior."
+1529,"@@ -788,7 +788,12 @@ public class FlexBuffers {
+                 if (io == other.length) {
+                     // in our buffer we have an additional \0 byte
+                     // but this does not exist in regular Java strings, so we return now
+-                    return c1 - c2;
++                    int cmp = c1 - c2;
++                    if (cmp != 0 || bb.get(ia) == '\0') {
++                        return cmp;
++                    } else {
++                        return 1;
++                    }
+                 }
+             }
+             while (c1 == c2);","if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\0'` to get the same effect?"
+1530,"@@ -33,7 +33,11 @@ import org.apache.iceberg.exceptions.AlreadyExistsException;
+ public class CachingCatalog implements Catalog {
+
+   public static Catalog wrap(Catalog catalog) {
+-    return new CachingCatalog(catalog);
++    return wrap(catalog, true);
++  }
++
++  public static Catalog wrap(Catalog catalog, Boolean caseSensitive) {
++    return new CachingCatalog(catalog, caseSensitive);
+   }
+
+   private final Cache<TableIdentifier, Table> tableCache = Caffeine.newBuilder()",nit: can this be a primitive value?
+1531,"@@ -333,9 +333,14 @@ func (b Browse) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
+
+ 	// Browsing navigation gets messed up if browsing a directory
+ 	// that doesn't end in ""/"" (which it should, anyway)
+-	if !strings.HasSuffix(r.URL.Path, ""/"") {
+-		staticfiles.RedirectToDir(w, r)
+-		return 0, nil
++	u := r.Context().Value(httpserver.OriginalURLCtxKey).(url.URL)
++	if u.Path == """" {
++		u.Path = ""/""
++	}
++	if u.Path[len(u.Path)-1] != '/' {
++		u.Path += ""/""
++		http.Redirect(w, r, u.String(), http.StatusMovedPermanently)
++		return http.StatusMovedPermanently, nil
+ 	}
+
+ 	return b.ServeListing(w, r, requestedFilepath, bc)","This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`."
+1532,"@@ -197,7 +197,7 @@ class Engine(object):
+         # :type exception: BaseException
+         exception = None
+         try:
+-            modules = [self.provisioning, self.aggregator] + self.reporters
++            modules = [self.aggregator, self.provisioning] + self.reporters
+             modules += self.services
+             for module in modules:
+                 try:",Why change this?
+1533,"@@ -5,9 +5,9 @@ declare(strict_types=1);
+ namespace Shopsys\FrameworkBundle\Component\Error;
+
+ use Psr\Log\LoggerInterface;
+-use Symfony\Component\HttpKernel\EventListener\ExceptionListener;
++use Symfony\Component\HttpKernel\EventListener\ErrorListener;
+
+-class NotLogFakeHttpExceptionsExceptionListener extends ExceptionListener
++class NotLogFakeHttpExceptionsExceptionListener extends ErrorListener
+ {
+     /**
+      * @var \Shopsys\FrameworkBundle\Component\Error\ErrorIdProvider|null",  _nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?
+1534,"@@ -82,6 +82,7 @@ namespace AutoRest.AzureResourceSchema
+                     JsonSchema resourceDefinition = new JsonSchema();
+                     resourceDefinition.JsonType = ""object"";
+
++                    resourceDefinition.ResourceType = resourceType;
+                     resourceDefinition.AddProperty(""type"", JsonSchema.CreateStringEnum(resourceType), true);
+                     resourceDefinition.AddProperty(""apiVersion"", JsonSchema.CreateStringEnum(apiVersion), true);
+ ","Why not just look for the ""type"" property instead of creating a ResourceType property?"
+1535,"@@ -360,7 +360,8 @@ func (bc *blockchain) context(ctx context.Context, tipInfoFlag bool) (context.Co
+ 		protocol.WithBlockchainCtx(
+ 			ctx,
+ 			protocol.BlockchainCtx{
+-				Tip: tip,
++				Tip:     tip,
++				ChainID: config.ChainID(),
+ 			},
+ 		),
+ 		bc.config.Genesis,",should use `bc.config.Blockchain.ChainID`
+1536,"@@ -17,13 +17,12 @@ import java.util.Collections;
+ import java.util.List;
+ import org.springframework.boot.context.properties.ConfigurationProperties;
+ import zipkin.storage.elasticsearch.ElasticsearchStorage;
+-import zipkin.storage.elasticsearch.NativeClient;
+
+ @ConfigurationProperties(""zipkin.storage.elasticsearch"")
+ public class ZipkinElasticsearchStorageProperties {
+-  /** @see NativeClient.Builder#cluster(String) */
++  /** @see ElasticsearchStorage.Builder#cluster(String) */
+   private String cluster = ""elasticsearch"";
+-  /** @see NativeClient.Builder#hosts(List) */
++  /** @see ElasticsearchStorage.Builder#hosts(List) */
+   private List<String> hosts = Collections.singletonList(""localhost:9300"");
+   /** @see ElasticsearchStorage.Builder#index(String) */
+   private String index = ""zipkin"";",this doesn't need to know about NativeClient
+1537,"@@ -233,7 +233,8 @@ class ViolationAccess(object):
+                 violation.get('full_name', ''),
+                 violation.get('resource_data', ''),
+                 violation.get('violation_data', ''),
+-                violation.get('rule_name', '')
++                violation.get('rule_name', ''),
++                violation.get('resource_name', '')
+             )
+
+             violation = Violation(","I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required."
+1538,"@@ -14,8 +14,11 @@ static void surface_attach(struct wl_client *client,
+ 		struct wl_resource *resource,
+ 		struct wl_resource *buffer, int32_t sx, int32_t sy) {
+ 	struct wlr_surface *surface = wl_resource_get_user_data(resource);
++	int scale = surface->current.scale;
+ 	surface->pending.invalid |= WLR_SURFACE_INVALID_BUFFER;
+ 	surface->pending.buffer = buffer;
++	surface->texture->height_from_buffer = surface->texture->height / scale;
++	surface->texture->width_from_buffer = surface->texture->width / scale;
+ }
+
+ static void surface_damage(struct wl_client *client,","The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`."
+1539,"@@ -179,6 +179,8 @@ class Listen(object):
+             'time' : self.ts_since_epoch,
+             'tags' : {
+                 'user_name' : escape(self.user_name),
++                'artist_msid' : self.artist_msid,
++                'recording_msid' : self.recording_msid,
+             },
+             'fields' : {
+                 'artist_name' : self.data['artist_name'],",Why are you using these tags to carry these msids?
+1540,"@@ -439,8 +439,8 @@ int flb_config_set_property(struct flb_config *config,
+                         flb_free(*s_val); /* release before overwriting */
+                     }
+
+-                    *s_val = malloc(flb_sds_len(tmp) * sizeof(char));
+-                    strncpy(*s_val, tmp, flb_sds_len(tmp));
++                    *s_val = malloc(flb_sds_len(tmp) * sizeof(char) + 1);
++                    strcpy(*s_val, tmp);
+                     flb_sds_destroy(tmp);
+                     break;
+                 default:",flb_strdup() should do the work here. note: use Fluent Bit memory wrappers
+1541,"@@ -0,0 +1,6 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++//go:generate sh -c ""protoc -I . -I \""$(go list -f '{{ .Dir }}' -m github.com/gogo/protobuf)/protobuf\"" --gogofaster_out=. retrieval.proto""
++package pb",This line should be separated from the package declaration by one line as it is not the package description.
+1542,"@@ -411,7 +411,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet(nil)
++				ws, err := sf.NewWorkingSet()
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 410 (from `govet`)"
+1543,"@@ -1,15 +1,14 @@
+ package task_config
+
+ import (
++	""strings""
++	""time""
++
++	ds ""github.com/c2h5oh/datasize""
+ 	""github.com/sonm-io/core/insonmnia/structs""
+ 	""github.com/sonm-io/core/proto""
+ )
+
+-type DurationConfig struct {
+-	Since string `yaml:""since"" required:""true""`
+-	Until string `yaml:""until"" required:""true""`
+-}
+-
+ type RatingConfig struct {
+ 	Buyer    int64 `yaml:""buyer"" required:""true""`
+ 	Supplier int64 `yaml:""supplier"" required:""true""`",Maybe next time better to make separate PR?
+1544,"@@ -254,6 +254,14 @@ class MaskTestMixin(object):
+         ori_shapes = tuple(meta['ori_shape'] for meta in img_metas)
+         scale_factors = tuple(meta['scale_factor'] for meta in img_metas)
+
++        if all(det_bbox.shape[0] == 0 for det_bbox in det_bboxes):
++            if torch.onnx.is_in_onnx_export():
++                raise RuntimeError('[ONNX Error] Can not record MaskHead '
++                                   'as it has not been executed this time')
++            segm_results = [[[] for _ in range(self.mask_head.num_classes)]
++                            for _ in range(len(det_bboxes))]
++            return segm_results
++
+         # The length of proposals of different batches may be different.
+         # In order to form a batch, a padding operation is required.
+         if isinstance(det_bboxes, list):","line 316 also handles this case, need to simplify the logic."
+1545,"@@ -122,9 +122,12 @@ type Options struct {
+ }
+
+ // openBucket returns a GCS Bucket that communicates using the given HTTP client.
+-func openBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient, opts *Options) (driver.Bucket, error) {
++func openBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient, opts *Options) (*bucket, error) {
+ 	if client == nil {
+-		return nil, errors.New(""OpenBucket requires an HTTP client"")
++		return nil, errors.New(""gcsblob.OpenBucket: client is required"")
++	}
++	if bucketName == """" {
++		return nil, errors.New(""gcsblob.OpenBucket: bucketName is required"")
+ 	}
+ 	c, err := storage.NewClient(ctx, option.WithHTTPClient(&client.Client))
+ 	if err != nil {","We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?"
+1546,"@@ -983,7 +983,11 @@ bool RTPSParticipantImpl::sendSync(
+
+         for (auto& send_resource : send_resource_list_)
+         {
+-            send_resource->send(msg->buffer, msg->length, destination_loc);
++            // Calculate next timeout.
++            std::chrono::microseconds timeout =
++                std::chrono::duration_cast<std::chrono::microseconds>(max_blocking_time_point - std::chrono::steady_clock::now());
++
++            send_resource->send(msg->buffer, msg->length, destination_loc, timeout);
+         }
+     }
+ ",Line too long
+1547,"@@ -638,6 +638,9 @@ MagicEffectNames magicEffectNames = {
+ 	{""orangeteleport"",	CONST_ME_ORANGETELEPORT},
+ 	{""greyteleport"",	CONST_ME_GREYTELEPORT},
+ 	{""lightblueteleport"",	CONST_ME_LIGHTBLUETELEPORT},
++	{""fatal"", 			CONST_ME_FATAL},
++	{""dodge"", 			CONST_ME_DODGE},
++	{""hourglass"",		CONST_ME_HOURGLASS},
+ };
+
+ ShootTypeNames shootTypeNames = {",This isn't aligned though.
+1548,"@@ -533,7 +533,8 @@ class PAAHead(ATSSHead):
+         cls_scores. Besides, score voting is used when `` score_voting``
+         is set to True.
+         """"""
+-        assert with_nms, 'PAA only supports ""with_nms=True"" now'
++        assert with_nms, 'PAA only supports ""with_nms=True"" now and it is ' \
++                         'mean PAAHead does not support test-time augmentation'
+         assert len(cls_scores) == len(bbox_preds) == len(mlvl_anchors)
+         batch_size = cls_scores[0].shape[0]
+ ",it is mean -> it means PAAHead does not support test-time augmentation.
+1549,"@@ -119,6 +119,7 @@ from invenio.legacy.bibcatalog.api import BIBCATALOG_SYSTEM
+ from invenio.legacy.bibdocfile.config import CFG_BIBDOCFILE_ICON_SUBFORMAT_RE, \
+     CFG_BIBDOCFILE_DEFAULT_ICON_SUBFORMAT
+ from invenio.utils.hash import md5
++from invenio.legacy.bibdocfile.registry import plugins
+
+ import invenio.legacy.template
+ ",@lnielsen-cern thanks. I missed it :(
+1550,"@@ -97,7 +97,7 @@ const AnalyticsAdSenseDashboardWidgetTopPagesTable = ( { data } ) => {
+ 		chartsEnabled: false,
+ 		links: rows.map( ( row ) => row.dimensions[ 1 ] || '/' ),
+ 		PrimaryLink: withSelect( ( select, { href = '/' } ) => {
+-			const serviceURL = select( STORE_NAME ).getServiceReportURL( 'content-pages', {
++			const serviceURL = select( STORE_NAME ).getServiceReportURL( 'content-drilldown', {
+ 				'explorer-table.plotKeys': '[]',
+ 				'_r.drilldown': `analytics.pagePath:${ href }`,
+ 			} );","@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?"
+1551,"@@ -16,6 +16,7 @@
+
+ from apiclient import discovery
+ from oauth2client.client import GoogleCredentials
++
+ from retrying import retry
+
+ from google.cloud.security.common.gcp_api._supported_apis import SUPPORTED_APIS",nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library.
+1552,"@@ -123,6 +123,13 @@ type PrometheusSpec struct {
+ 	// The labels to add to any time series or alerts when communicating with
+ 	// external systems (federation, remote storage, Alertmanager).
+ 	ExternalLabels map[string]string `json:""externalLabels,omitempty""`
++	// Enable access to prometheus web admin API. Defaults to the value of `false`.
++	// WARNING: Enabling the admin APIs enables mutating endpoints, to delete data,
++	// shutdown Prometheus, and more. Enabling this should be done with care and the
++	// user is advised to add additional authentication authorization via a proxy to
++	// ensure only clients authorized to perform these actions can do so.
++	// For more information see https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
++	EnableAdminAPI string `json:""enableAdminAPI,omitempty""`
+ 	// The external URL the Prometheus instances will be available under. This is
+ 	// necessary to generate correct URLs. This is necessary if Prometheus is not
+ 	// served from root of a DNS name.",This should be a bool
+1553,"@@ -5129,12 +5129,12 @@ SwiftASTContext::GetReferentType(const CompilerType &compiler_type) {
+
+   if (compiler_type.IsValid() &&
+       llvm::dyn_cast_or_null<SwiftASTContext>(compiler_type.GetTypeSystem())) {
+-    swift::CanType swift_can_type(GetCanonicalSwiftType(compiler_type));
+-    swift::TypeBase *swift_type = swift_can_type.getPointer();
+-    if (swift_type && llvm::isa<swift::WeakStorageType>(swift_type))
++    swift::Type swift_type(GetSwiftType(compiler_type));
++    swift::TypeBase *swift_typebase = swift_type.getPointer();
++    if (swift_type && llvm::isa<swift::WeakStorageType>(swift_typebase))
+       return compiler_type;
+
+-    auto ref_type = swift_can_type->getReferenceStorageReferent();
++    auto ref_type = swift_type->getReferenceStorageReferent();
+     return CompilerType(GetASTContext(), ref_type);
+   }
+ ",`if (llvm::dyn_cast_or_null<swift::WeakStorageType>(GetSwiftType(compiler_type).getPointer())` ?
+1554,"@@ -144,13 +144,13 @@ func (e *deployExecutor) generateCanaryManifests(manifests []provider.Manifest,
+
+ 	// Find config map manifests and duplicate them for CANARY variant.
+ 	configMaps := findConfigMapManifests(manifests)
+-	configMaps = duplicateManifests(configMaps, suffix)
+-	canaryManifests = append(canaryManifests, configMaps...)
++	canaryConfigMaps := duplicateManifests(configMaps, suffix)
++	canaryManifests = append(canaryManifests, canaryConfigMaps...)
+
+ 	// Find secret manifests and duplicate them for CANARY variant.
+ 	secrets := findSecretManifests(manifests)
+-	secrets = duplicateManifests(secrets, suffix)
+-	canaryManifests = append(canaryManifests, secrets...)
++	canarySecrets := duplicateManifests(secrets, suffix)
++	canaryManifests = append(canaryManifests, canarySecrets...)
+
+ 	// Generate new workload manifests for CANARY variant.
+ 	// The generated ones will mount to the new ConfigMaps and Secrets.","The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated."
+1555,"@@ -19,9 +19,10 @@ use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
+ class ErgonodeAccountExtension extends Extension implements PrependExtensionInterface
+ {
+     /**
++     * @throws \Exception
++     *
+      * @param array $configs
+      *
+-     * @throws \Exception
+      */
+     public function load(array $configs, ContainerBuilder $container): void
+     {",are this docs neccesary ?
+1556,"@@ -46,8 +46,8 @@ import java.util.List;
+ public class HttpCommandProcessor implements CommandProcessor {
+
+   private String pathToServlet;
+-  private String browserStartCommand;
+-  private String browserURL;
++  private final String browserStartCommand;
++  private final String browserURL;
+   private String sessionId;
+   private String extensionJs;
+   private String rcServerLocation;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+1557,"@@ -13,6 +13,8 @@ void SoftmaxWithLossLayer<Dtype>::LayerSetUp(
+   LossLayer<Dtype>::LayerSetUp(bottom, top);
+   LayerParameter softmax_param(this->layer_param_);
+   softmax_param.set_type(""Softmax"");
++  // no loss weight for the Softmax internal layer.
++  softmax_param.clear_loss_weight();
+   softmax_layer_ = LayerRegistry<Dtype>::CreateLayer(softmax_param);
+   softmax_bottom_vec_.clear();
+   softmax_bottom_vec_.push_back(bottom[0]);","This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored."
+1558,"@@ -242,7 +242,17 @@ var filesToIgnore = map[string]bool{
+
+ func ignoreFile(filename string) bool {
+ 	_, base := path.Split(filename)
+-	return filesToIgnore[base] || strings.HasPrefix(base, ""._"")
++	if filesToIgnore[base] || strings.HasPrefix(base, ""._"") {
++		return true
++	}
++	// Treat the files to ignore as prefixes, since if they ever
++	// conflict they'll have the conflict suffix.
++	for prefix := range filesToIgnore {
++		if strings.HasPrefix(base, prefix) {
++			return true
++		}
++	}
++	return false
+ }
+
+ // processNotification adds the notification to the recomputer's",Is there an easy way to check for conflict suffix to avoid false positives here?
+1559,"@@ -59,7 +59,7 @@ module Bolt
+         run_opts = {}
+         run_opts[:run_as] = opts['_run_as'] if opts['_run_as']
+         begin
+-          task = apply_prep.get_task(opts['task'], params)
++          task = @context.get_validated_task(opts['task'], params)
+         rescue Bolt::Error => e
+           raise Bolt::Plugin::PluginError::ExecutionError.new(e.message, name, 'puppet_library')
+         end",`apply_prep.run_task` also seems like it can just use `@context.run_task`
+1560,"@@ -36,6 +36,9 @@ define([""events"", ""layoutManager"", ""inputManager"", ""userSettings"", ""libraryMenu""
+                 showYear: true,
+                 centerText: true
+             });
++
++            // FIXME: Wait for all sections to load
++            autoFocus(page);
+         });
+     }
+ ",do you have any idea on how to fix it?
+1561,"@@ -159,3 +159,19 @@ class GCSTargetTest(_GCSBaseTestCase, FileSystemTargetTestMixin):
+
+     def create_target(self, format=None):
+         return gcs.GCSTarget(bucket_url(self.id()), format=format, client=self.client)
++
++    def test_close_twice(self):
++        # Ensure gcs._DeleteOnCloseFile().close() can be called multiple times
++        tgt = self.create_target()
++
++        with tgt.open('w') as dst:
++            dst.write('data')
++        assert dst.closed
++        dst.close()
++        assert dst.closed
++
++        with tgt.open() as src:
++            assert src.read().strip() == 'data'
++        assert src.closed
++        src.close()
++        assert src.closed","You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running."
+1562,"@@ -90,6 +90,15 @@ func (eni *ENIAttachment) StopAckTimer() {
+ 	eni.ackTimer.Stop()
+ }
+
++// HasExpired returns true if the ENI attachment object has exceeded the
++// threshold for notifying the backend of the attachment
++func (eni *ENIAttachment) HasExpired() bool {
++	eni.guard.RLock()
++	defer eni.guard.RUnlock()
++
++	return time.Now().After(eni.ExpiresAt)
++}
++
+ // String returns a string representation of the ENI Attachment
+ func (eni *ENIAttachment) String() string {
+ 	eni.guard.RLock()",When does 'expiresAt' change? Do you need this?
+1563,"@@ -75,3 +75,15 @@ const Outfit* Outfits::getOutfitByLookType(PlayerSex_t sex, uint16_t lookType) c
+ 	}
+ 	return nullptr;
+ }
++
++const Outfit* Outfits::getOutfitByLookType(uint16_t lookType) const
++{
++	for (uint8_t sex = 0; sex <= 1; sex++) {
++		for (const Outfit& outfit : outfits[sex]) {
++			if (outfit.lookType == lookType) {
++				return &outfit;
++			}
++		}
++	}
++	return nullptr;
++}",There are enums for genders + `PLAYERSEX_LAST`.
+1564,"@@ -23,9 +23,14 @@ func TestCalculateRollupFee(t *testing.T) {
+ 			data := make([]byte, 0, tt.dataLen)
+ 			fee := CalculateRollupFee(data, tt.gasUsed, big.NewInt(tt.dataPrice), big.NewInt(tt.executionPrice))
+
+-			dataFee := uint64((RollupBaseTxSize + len(data)) * int(tt.dataPrice))
++			zeroes, ones := zeroesAndOnes(data)
++			zeroesCost := zeroes * 4
++			onesCost := (96 + ones) * 16
++			dataCost := zeroesCost + onesCost
++			dataFee := int64(dataCost) * tt.dataPrice
++
+ 			executionFee := uint64(tt.executionPrice) * tt.gasUsed
+-			expectedFee := dataFee + executionFee
++			expectedFee := uint64(dataFee) + executionFee
+ 			if fee.Cmp(big.NewInt(int64(expectedFee))) != 0 {
+ 				t.Errorf(""rollup fee check failed: expected %d, got %s"", expectedFee, fee.String())
+ 			}",Should this use the constants as well? Or intentionally covering the fact that the constants may change
+1565,"@@ -58,7 +58,10 @@ class TopNContainer(object):
+     return self.extras
+
+   def __len__(self):
+-    return self._size
++    if self._size >= 0:
++      return self._size
++    else:
++      return len(self.best)
+
+   def __getitem__(self, which):
+     return self.best[which], self.extras[which]",The case of a negative size (= keep all elements) was not handled in this function.
+1566,"@@ -70,13 +70,13 @@ var keys = map[Key]string{
+ 	EnableNamespaceNotActiveAutoForwarding: ""system.enableNamespaceNotActiveAutoForwarding"",
+ 	TransactionSizeLimit:                   ""system.transactionSizeLimit"",
+ 	MinRetentionDays:                       ""system.minRetentionDays"",
+-	MaxWorkflowTaskTimeout:                 ""system.maxWorkflowTaskTimeout"",
+ 	DisallowQuery:                          ""system.disallowQuery"",
+ 	EnableBatcher:                          ""worker.enableBatcher"",
+ 	EnableParentClosePolicyWorker:          ""system.enableParentClosePolicyWorker"",
+ 	EnableStickyQuery:                      ""system.enableStickyQuery"",
+ 	EnablePriorityTaskProcessor:            ""system.enablePriorityTaskProcessor"",
+ 	EnableAuthorization:                    ""system.enableAuthorization"",
++	EnableInfiniteTimeout:                  ""system.enableInfiniteTimeout"",
+
+ 	// size limit
+ 	BlobSizeLimitError:     ""limit.blobSize.error"",",I think we should keep this dynamic config knob for operations purpose.
+1567,"@@ -60,7 +60,6 @@ class TestCharacterOffsets(unittest.TestCase):
+ 		obj = BasicTextProvider(text=u""\U0001f926\U0001f60a\U0001f44d"") # 🤦😊👍
+ 		ti = obj.makeTextInfo(Offsets(5, 5))
+ 		ti.expand(textInfos.UNIT_CHARACTER) # Range at 👍
+-		self.assertEqual(ti.offsets, (4, 6)) # Two offsets
+ 		ti.move(textInfos.UNIT_CHARACTER, -1)
+ 		ti.expand(textInfos.UNIT_CHARACTER) # Range at 😊
+ 		self.assertEqual(ti.offsets, (2, 4)) # Two offsets",Was this intentional? Perhaps this could be replaced with another way to check the offsets?
+1568,"@@ -86,6 +86,7 @@ type PipelineManifest struct {
+ 	Version PipelineSchemaMajorVersion `yaml:""version""`
+ 	Source  *Source                    `yaml:""source""`
+ 	Stages  []PipelineStage            `yaml:""stages""`
++	// ArtifactBuckets?
+ }
+
+ // Source defines the source of the artifacts to be built and deployed.","the buckets are created via the stackset, customers don't need to provide them"
+1569,"@@ -25,7 +25,7 @@ module Blacklight
+     # Execute a search query against solr
+     # @param [Hash] solr query parameters
+     def search params = {}
+-      send_and_receive blacklight_config.solr_path, { qt: blacklight_config.qt }.merge(params)
++      send_and_receive blacklight_config.solr_path, params.merge({ qt: blacklight_config.qt })
+     end
+
+     ##",This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`)
+1570,"@@ -6,6 +6,7 @@ module Travis
+
+         def setup
+           super
++          cmd ""export PATH=/usr/local/ghc/#{ghc_version}/bin/:$PATH""
+           cmd 'cabal update', fold: 'cabal', retry: true
+         end
+ ","This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think."
+1571,"@@ -374,7 +374,7 @@ define([""appSettings"", ""browser"", ""events"", ""htmlMediaHelper""], function (appSet
+             return -1 !== supportedFeatures.indexOf(command.toLowerCase());
+         },
+         preferVisualCards: browser.android || browser.chrome,
+-        moreIcon: browser.android ? ""dots-vert"" : ""dots-horiz"",
++        moreIcon: browser.android ? ""more_vert"" : ""more_horiz"",
+         getSyncProfile: getSyncProfile,
+         getDefaultLayout: function () {
+             if (window.NativeShell) {",We should deprecate this at some point.
+1572,"@@ -49,7 +49,9 @@ class FCOSHead(nn.Module):
+                      use_sigmoid=True,
+                      loss_weight=1.0),
+                  conv_cfg=None,
+-                 norm_cfg=dict(type='GN', num_groups=32, requires_grad=True)):
++                 norm_cfg=dict(type='GN', num_groups=32, requires_grad=True),
++                 center_sampling=False,
++                 center_sample_radius=1.5):
+         super(FCOSHead, self).__init__()
+
+         self.num_classes = num_classes",Move these two arguments before `loss_cls`.
+1573,"@@ -93,10 +93,16 @@ func GenerateSelfSignedX509CA(commonName string, extUsage []x509.ExtKeyUsage, ke
+ }
+
+ // GenerateServerX509UsingCA generates a TLS serverCert that is self-signed
+-func GenerateServerX509UsingCA(commonName string, ca *tls.Certificate) (*tls.Certificate, *rsa.PrivateKey, error) {
++func GenerateServerX509UsingCAAndSerialNumber(commonName string, serialNumber int64, ca *tls.Certificate) (*tls.Certificate, *rsa.PrivateKey, error) {
+ 	now := time.Now().UTC()
+
+-	i := mathrand.Int63n(100000000000000000)
++	var i int64
++	if serialNumber == 0 {
++		i = mathrand.Int63n(100000000000000000)
++	} else {
++		i = serialNumber
++	}
++
+ 	template := &x509.Certificate{
+ 		SerialNumber: big.NewInt(i),
+ 		Subject: pkix.Name{",[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) }
+1574,"@@ -14,8 +14,8 @@ namespace Microsoft.CodeAnalysis.Sarif.ConvertToSarif
+         public string InputFilePath { get; internal set; }
+
+         [Option(
+-            'f',
+-            ""format"",
++            't',
++            ""tool"",
+             HelpText = ""The tool format of the input file."")]
+         public ToolFormat ToolFormat { get; internal set; }
+ ",-f short form here collided with --force. :)
+1575,"@@ -12,6 +12,5 @@ describe('preact', () => {
+ 		expect(cloneElement).to.be.a('function');
+ 		expect(createContext).to.be.a('function');
+ 		expect(options).to.exist.and.be.an('object');
+-		// expect(rerender).to.be.a('function');
+ 	});
+ });",I think it is better to describe in the release note that `rerender()` was removed.
+1576,"@@ -3,5 +3,5 @@ VERSION = ""."".join(str(i) for i in IVERSION)
+ PATHOD = ""pathod "" + VERSION
+ MITMPROXY = ""mitmproxy "" + VERSION
+
+-if __name__ == ""__main__"":
++if __name__ == ""__main__"":  # pragma: no cover
+     print(VERSION)","We could also test this easily with `runpy.run_module`, what do you think?"
+1577,"@@ -388,8 +388,10 @@ func decode(v reflect.Value, d Decoder) error {
+ 		if err != nil {
+ 			return err
+ 		}
+-		v.Set(reflect.ValueOf(val))
+-		return nil
++		if v.Type().AssignableTo(reflect.TypeOf(val)) {
++			v.Set(reflect.ValueOf(val))
++			return nil
++		}
+ 	}
+
+ 	// Handle implemented interfaces first.","Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice."
+1578,"@@ -133,7 +133,8 @@ func runAPIAndWait(ctx context.Context, nd *node.Node, config *config.Config, re
+ 		ctx:          context.Background(),
+ 		api:          api,
+ 		porcelainAPI: nd.PorcelainAPI,
+-		blockpAPI:    nd.BlockAPI,
++		blockAPI:     nd.BlockAPI,
++		retrievalAPI: nd.RetrievalAPI,
+ 	}
+
+ 	cfg := cmdhttp.NewServerConfig()",I know this is after the fact but imo blockAPI should be blockMiningAPI.
+1579,"@@ -13,7 +13,11 @@ use Ergonode\SharedKernel\Domain\AbstractCode;
+
+ class AttributeCode extends AbstractCode
+ {
+-    public const PATTERN = '/^([a-zA-Z0-9_]+)$/';
++    public const NOT_SYSTEM_ATTRIBUTE_PATTERN = '/^(?!'.self::SYSTEM_ATTRIBUTE_PREFIX.')[a-zA-Z0-9_]+$/';
++
++    public const SYSTEM_ATTRIBUTE_PATTERN = '/^'.self::SYSTEM_ATTRIBUTE_PREFIX.'[a-zA-Z0-9_]+$/';
++
++    public const SYSTEM_ATTRIBUTE_PREFIX = 'esa_';
+
+     public function __construct(string $value)
+     {",it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it
+1580,"@@ -0,0 +1,17 @@
++/* Copyright (c) 2019 vesoft inc. All rights reserved.
++ *
++ * This source code is licensed under Apache 2.0 License,
++ * attached with Common Clause Condition 1.0, found in the LICENSES directory.
++ */
++
++#include ""LookUpEdgeIndexProcessor.h""
++
++namespace nebula {
++namespace storage {
++
++void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
++    UNUSED(req);
++}
++}  // namespace storage
++}  // namespace nebula
++","Similar to the code block when we use prefix, maybe we can unify them to base?"
+1581,"@@ -100,6 +100,15 @@ func (in *PodChaos) ValidateScheduler(spec *field.Path) field.ErrorList {
+ 			allErrs = append(allErrs, err...)
+ 		}
+ 		break
++	case PodNotReadyAction:
++		// We choose to ignore the Duration property even user define it
++		if in.Spec.Scheduler == nil {
++			allErrs = append(allErrs, field.Invalid(schedulerField, in.Spec.Scheduler, ValidatePodchaosSchedulerError))
++		} else {
++			_, err := ParseCron(in.Spec.Scheduler.Cron, schedulerField.Child(""cron""))
++			allErrs = append(allErrs, err...)
++		}
++		break
+ 	default:
+ 		err := fmt.Errorf(""podchaos[%s/%s] have unknown action type"", in.Namespace, in.Name)
+ 		log.Error(err, ""Wrong PodChaos Action type"")",I think `Duration` is useful for this action and we shouldn't ignore it.
+1582,"@@ -243,13 +243,10 @@ func (s *stream) Write(p []byte) (int, error) {
+ 		s.mutex.Lock()
+ 	}
+
+-	if err != nil {
+-		return 0, err
+-	}
+ 	if s.err != nil {
+-		return len(p) - len(s.dataForWriting), s.err
++		err = s.err
+ 	}
+-	return len(p), nil
++	return len(p) - len(s.dataForWriting), err
+ }
+
+ func (s *stream) GetWriteOffset() protocol.ByteCount {","Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`."
+1583,"@@ -84,6 +84,12 @@ namespace Impl {
+ HIPLockArrays g_host_hip_lock_arrays = {nullptr, nullptr, 0};
+
+ void initialize_host_hip_lock_arrays() {
++#ifdef KOKKOS_ENABLE_IMPL_DESUL_ATOMICS
++  desul::Impl::init_lock_arrays();
++
++  DESUL_ENSURE_HIP_LOCK_ARRAYS_ON_DEVICE();
++#endif
++
+   if (g_host_hip_lock_arrays.atomic != nullptr) return;
+   HIP_SAFE_CALL(hipMalloc(
+       &g_host_hip_lock_arrays.atomic,","Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?"
+1584,"@@ -69,12 +69,13 @@ class ImportSimpleProductCommandHandler
+             );
+
+             if (!empty($attributesToRedispatch)) {
+-                $this->commandBus->dispatch(new ImportProductAttributesValueCommand(
++                $ImportProductAttributesValueCommand = new ImportProductAttributesValueCommand(
+                     $command->getId(),
+                     $command->getImportId(),
+                     $attributesToRedispatch,
+                     $command->getSku()
+-                ));
++                );
++                $this->commandBus->dispatch($ImportProductAttributesValueCommand, true);
+             }
+             $this->repository->markLineAsSuccess($command->getId(), $product->getId());
+         } catch (ImportException $exception) {",Variable name should start from lowercase latter
+1585,"@@ -47,12 +47,12 @@ import (
+ // certificate, ca, and private key is stored into the target Secret to
+ // complete Issuing the Certificate.
+ func TestIssuingController(t *testing.T) {
+-	config, stopFn := framework.RunControlPlane(t)
+-	defer stopFn()
+-
+-	ctx, cancel := context.WithTimeout(context.Background(), time.Second*20)
++	ctx, cancel := context.WithTimeout(context.Background(), time.Second*40)
+ 	defer cancel()
+
++	config, stopFn := framework.RunControlPlane(t, ctx)
++	defer stopFn()
++
+ 	// Build, instantiate and run the issuing controller.
+ 	kubeClient, factory, cmCl, cmFactory := framework.NewClients(t, config)
+ 	controllerOptions := controllerpkg.CertificateOptions{",Why has this timeout doubled?
+1586,"@@ -113,7 +113,7 @@ type Config struct {
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;30""`
+ 	IptablesLockFilePath               string        `config:""file;/run/xtables.lock""`
+-	IptablesLockTimeoutSecs            time.Duration `config:""seconds;30""`
++	IptablesLockTimeoutSecs            time.Duration `config:""seconds;0""`
+ 	IptablesLockProbeIntervalMillis    time.Duration `config:""millis;50""`
+ 	IpsetsRefreshInterval              time.Duration `config:""seconds;10""`
+ 	MaxIpsetSize                       int           `config:""int;1048576;non-zero""`","Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?"
+1587,"@@ -335,6 +335,13 @@ class WebEngineCaret(browsertab.AbstractCaret):
+         """"""
+         if js_elem is None:
+             return
++        if js_elem == ""focused"":
++            # we had a focused element, not a selected one. Just send <enter>
++            if tab:
++                self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)
++            else:
++                self._tab.key_press(Qt.Key_Enter)
++
+         assert isinstance(js_elem, dict), js_elem
+         elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)
+         if tab:","You're missing a `return` here, but I'll add it :smile:"
+1588,"@@ -116,7 +116,7 @@ static bool gles2_render_texture_with_matrix(struct wlr_renderer *wlr_renderer,
+ 	struct wlr_gles2_renderer *renderer =
+ 		gles2_get_renderer_in_context(wlr_renderer);
+ 	struct wlr_gles2_texture *texture =
+-		get_gles2_texture_in_context(wlr_texture);
++		gles2_get_texture(wlr_texture);
+
+ 	struct wlr_gles2_tex_shader *shader = NULL;
+ 	GLenum target = 0;",Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer.
+1589,"@@ -234,7 +234,8 @@ class RouteFactory(object):
+         required_permission = self.method_permissions.get(method)
+
+         # For create permission, the object id is the plural endpoint.
+-        collection_path = service.collection_path.format(**request.matchdict)
++        plural_endpoint = service.collection_path.decode('utf-8')
++        collection_path = plural_endpoint.format(**request.matchdict)
+
+         # In the case of a ""PUT"", check if the targetted record already
+         # exists, return ""write"" if it does, ""create"" otherwise.",This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils.
+1590,"@@ -28,6 +28,8 @@ module Mongoid
+           raise Errors::InvalidDiscriminatorKeyTarget.new(self, self.superclass)
+         end
+
++        self._clear_types if self.respond_to?(:_clear_types)
++
+         if value
+           Mongoid::Fields::Validators::Macro.validate_field_name(self, value)
+           value = value.to_s",Why is the respond_to check here?
+1591,"@@ -229,7 +229,7 @@ class FunctionDocblockManipulator
+                 continue;
+             }
+
+-            if ($chars[$i] === '\\' || preg_match('/\w/', $char)) {
++            if ($char === '\\' || preg_match('/\w/', $char)) {
+                 if ($this->return_typehint_start === null) {
+                     $this->return_typehint_start = $i + $end_bracket_position + 1;
+                 }","@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment."
+1592,"@@ -22,7 +22,7 @@ TEST(DeleteVertexTest, SimpleTest) {
+     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
+     // Add vertices
+     {
+-        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr);
++        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr);
+         cpp2::AddVerticesRequest req;
+         req.space_id = 0;
+         req.overwritable = false;",I have a question? How do I construct a indexManager for testcase?
+1593,"@@ -73,6 +73,9 @@ int __FPGA_API__ opae_plugin_configure(opae_api_adapter_table *adapter,
+ {
+ 	UNUSED_PARAM(jsonConfig);
+
++	if (adapter == NULL || adapter->plugin.dl_handle == NULL)
++		return -1;
++
+ 	adapter->fpgaOpen = dlsym(adapter->plugin.dl_handle, ""xfpga_fpgaOpen"");
+ 	adapter->fpgaClose =
+ 		dlsym(adapter->plugin.dl_handle, ""xfpga_fpgaClose"");",These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( ).
+1594,"@@ -554,15 +554,14 @@ class SearchRequest
+
+     /**
+      * Method to check if the query string is an empty string
+-     * (also empty string or whitespaces only are handled as empty).
++     * (also whitespaces only are handled as empty).
+      *
+      * When no query string is set (null) the method returns false.
+      * @return bool
+      */
+     public function getRawUserQueryIsEmptyString()
+     {
+-        $path = $this->prefixWithNamespace('q');
+-        $query = $this->argumentsAccessor->get($path, null);
++        $query = $this->getRawUserQuery();
+
+         if ($query === null) {
+             return false;",Please take a care about prefixing.
+1595,"@@ -70,6 +70,17 @@ public interface WorldUpdater extends MutableWorldView {
+     return account == null ? createAccount(address) : account;
+   }
+
++  /**
++   * Retrieves the provided account for a sender of a transaction if it exists, or creates it if it
++   * doesn't.
++   *
++   * @param address the address of the account.
++   * @return the account {@code address}, or {@code null} if the account does not exist.
++   */
++  default EvmAccount getOrCreateSenderAccount(final Address address) {
++    return getOrCreate(address);
++  }
++
+   /**
+    * Retrieves the provided account, returning a modifiable object (whose updates are accumulated by
+    * this updater).",this line doesn't match what the rest says
+1596,"@@ -1,4 +1,4 @@
+-// +build !linux linux,android
++// +build windows linux,android
+
+ /*
+  * Copyright (C) 2017 The ""MysteriumNetwork/node"" Authors.","Since it's not working for linux, maybe leave the !linux in there as well?"
+1597,"@@ -60,6 +60,9 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) error {
+
+ 	// Copy Sources up to parent resolving relative paths as we go.
+ 	for k, v := range i.w.Sources {
++		if v == """" {
++			continue
++		}
+ 		if _, ok := s.w.Sources[k]; ok {
+ 			return fmt.Errorf(""source %q already exists in workflow"", k)
+ 		}","Should we remove the key-value pair entirely? Same for workflows in general. We have a ""sourceExists"" method that checks if a key is there if I remember correctly."
+1598,"@@ -96,7 +96,7 @@ public class ContentSoqlSyncDownTarget extends SoqlSyncDownTarget {
+
+     @Override
+     public JSONArray startFetch(SyncManager syncManager, long maxTimeStamp) throws IOException, JSONException {
+-        String queryToRun = maxTimeStamp > 0 ? SoqlSyncDownTarget.addFilterForReSync(getQuery(), maxTimeStamp) : getQuery();
++        String queryToRun = maxTimeStamp > 0 ? SoqlSyncDownTarget.addFilterForReSync(getQuery(), getModificationDateFieldName(), maxTimeStamp) : getQuery();
+         syncManager.getRestClient().sendSync(RestRequest.getRequestForResources(syncManager.apiVersion)); // cheap call to refresh session
+         RestRequest request = buildQueryRequest(syncManager.getRestClient().getAuthToken(), queryToRun);
+         RestResponse response = syncManager.sendSyncWithSmartSyncUserAgent(request);",Unrelated bug fix
+1599,"@@ -173,15 +173,15 @@ define(['serverNotifications', 'playbackManager', 'events', 'globalize', 'requir
+             };
+
+             if (status === 'completed') {
+-                notification.title = globalize.translate('PackageInstallCompleted').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallCompleted', installation.Name + ' ' + installation.Version);
+                 notification.vibrate = true;
+             } else if (status === 'cancelled') {
+-                notification.title = globalize.translate('PackageInstallCancelled').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallCancelled', installation.Name + ' ' + installation.Version);
+             } else if (status === 'failed') {
+-                notification.title = globalize.translate('PackageInstallFailed').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallFailed', installation.Name + ' ' + installation.Version);
+                 notification.vibrate = true;
+             } else if (status === 'progress') {
+-                notification.title = globalize.translate('InstallingPackage').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('InstallingPackage', installation.Name + ' ' + installation.Version);
+
+                 notification.actions =
+                 [",We probably want to let the translation library handle the string replacement for these as well.
+1600,"@@ -272,8 +272,7 @@ func newAdminMembershipCommands() []cli.Command {
+ 		{
+ 			Name:  ""list_db"",
+ 			Usage: ""List cluster membership items"",
+-			Flags: append(
+-				getDBFlags(),
++			Flags: []cli.Flag{
+ 				cli.StringFlag{
+ 					Name:  FlagHeartbeatedWithin,
+ 					Value: ""15m"",","should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any."
+1601,"@@ -21,6 +21,11 @@ class ProposalPolicy
+     !@proposal.approved?
+   end
+
++  def approve_reject?
++    actionable_approvers = @proposal.currently_awaiting_approvers
++    actionable_approvers.include? @user
++  end
++
+   def edit?
+     self.test_all(:edit?)
+   end",What do you think about prefixing the Policy method names with `can_`?
+1602,"@@ -29,11 +29,10 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+
+-/* HTTP Credentials Endpoints have a standard set of JSON Keys */
+-#define AWS_HTTP_RESPONSE_ACCESS_KEY   ""AccessKeyId""
+-#define AWS_HTTP_RESPONSE_SECRET_KEY   ""SecretAccessKey""
+-#define AWS_HTTP_RESPONSE_TOKEN        ""Token""
+-#define AWS_HTTP_RESPONSE_EXPIRATION   ""Expiration""
++#define AWS_CREDENTIAL_RESPONSE_ACCESS_KEY   ""AccessKeyId""
++#define AWS_CREDENTIAL_RESPONSE_SECRET_KEY   ""SecretAccessKey""
++#define AWS_HTTP_RESPONSE_TOKEN              ""Token""
++#define AWS_CREDENTIAL_RESPONSE_EXPIRATION   ""Expiration""
+
+ #define ECS_CREDENTIALS_HOST           ""169.254.170.2""
+ #define ECS_CREDENTIALS_HOST_LEN       13","Based on the docs, credential process can return a key `SessionToken`"
+1603,"@@ -9,8 +9,12 @@ export default Ember.Mixin.create({
+
+     if (birthDate) {
+       if (birthDate.getFullYear === undefined) {
+-        birthDate = moment(birthDate, 'l').toDate();
++        birthDate = moment(birthDate, 'LLL').toDate();
+       }
++
++      birthDate.setHours(0, 0, 0, 0);
++      today.setHours(0, 0, 0, 0);
++
+       if (birthDate.getFullYear !== undefined) {
+         years = today.getFullYear() - birthDate.getFullYear();
+         if (today.getMonth() < birthDate.getMonth()",I think this if should be removed (see issue)
+1604,"@@ -19,6 +19,7 @@ import (
+
+ 	log ""github.com/sirupsen/logrus""
+
++	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/libcalico-go/lib/set""
+ )
+ ",I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build.
+1605,"@@ -19,6 +19,7 @@
+ # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+
+ """"""Generate the html documentation based on the asciidoc files.""""""
++from typing import List, Tuple
+
+ import re
+ import os","nitpick: Please move this down to the other imports, as it's a Python stdlib import."
+1606,"@@ -13,7 +13,8 @@
+ // limitations under the License.
+
+ // Package blob provides an easy and portable way to interact with blobs
+-// within a storage location, hereafter called a ""bucket"".
++// within a storage location, hereafter called a ""bucket"". See
++// https://gocloud.dev/howto/blob/ for getting started guides.
+ //
+ // It supports operations like reading and writing blobs (using standard
+ // interfaces from the io package), deleting blobs, and listing blobs in a","""for getting started guides"" reads a bit weird, like it's missing punctuation. Maybe just ""for a tutorial""?"
+1607,"@@ -50,9 +50,9 @@ class Formats extends AbstractBase
+      * Constructor
+      *
+      * @param bool $enabled is this tab enabled?
+-     * @param bool $urc     use recaptcha?
++     * @param bool $uc     use captcha?
+      */
+-    public function __construct($enabled = true, $urc = false)
++    public function __construct($enabled = true, $uc = false)
+     {
+         $this->enabled = $enabled;
+     }","This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here."
+1608,"@@ -42,7 +42,11 @@ func (m *VerticaRowReader) GetNextRow() ([]values.Value, error) {
+ 	row := make([]values.Value, len(m.columns))
+ 	for i, col := range m.columns {
+ 		switch col := col.(type) {
+-		case bool, int, uint, int64, uint64, float64, string:
++		case int:
++			row[i] = values.NewInt(int64(col))
++		case uint:
++			row[i] = values.NewUInt(uint64(col))
++		case bool, int64, uint64, float64, string:
+ 			row[i] = values.New(col)
+ 		case time.Time:
+ 			row[i] = values.NewTime(values.ConvertTime(col))","Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is."
+1609,"@@ -14,7 +14,7 @@ import net.sourceforge.pmd.RuleViolation;
+ /**
+  * A {@link RuleViolation} implementation that is immutable, and therefore cache friendly
+  */
+-public final class CachedRuleViolation implements RuleViolation {
++public class CachedRuleViolation implements RuleViolation {
+
+     private final CachedRuleMapper mapper;
+ ","if you are not dealing with cache now, please revert these changes. On their own they make little sense"
+1610,"@@ -56,7 +56,7 @@ public abstract class NodeGenerator extends Generator {
+                     throw new AssertionError(f(""Wanted to regenerate a method with signature %s in %s, but it wasn't there."", callable.getSignature(), containingClassOrInterface.getNameAsString()));
+                 });
+     }
+-
++
+     private void addMethod(
+             ClassOrInterfaceDeclaration containingClassOrInterface,
+             CallableDeclaration<?> callable,",Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it.
+1611,"@@ -0,0 +1,7 @@
++package de.danoeh.antennapod.core.event;
++
++public class ShowRemainTimeUpdateEvent {
++    public ShowRemainTimeUpdateEvent() {
++
++    }
++}","I think it would be better to use an `ItemUpdatedEvent` like for the ""prefer streaming"" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future."
+1612,"@@ -0,0 +1,17 @@
++class AddSlugToProducts < ActiveRecord::Migration
++  def change
++    add_column :products, :slug, :string, null: true
++
++    products = select_all(""select id, name from products"")
++    products.each do |product|
++      update(<<-SQL)
++        UPDATE products
++          SET slug='#{product[""name""].parameterize}'
++          WHERE id=#{product[""id""]}
++      SQL
++    end
++
++    change_column_null :products, :slug, false
++    add_index :products, :slug, unique: true
++  end
++end",I think we have to manually write a down for this migration.
+1613,"@@ -454,14 +454,13 @@ class _InternalFrame(object):
+         assert isinstance(sdf, spark.DataFrame)
+
+         if index_map is None:
+-            # Here is when Koalas DataFrame is created directly from Spark DataFrame.
+-            assert not any(SPARK_INDEX_NAME_PATTERN.match(name) for name in sdf.schema.names), \
++            assert not any(SPARK_INDEX_NAME_PATTERN.match(name) for name in sdf.columns), \
+                 ""Index columns should not appear in columns of the Spark DataFrame. Avoid "" \
+-                ""index colum names [%s]."" % SPARK_INDEX_NAME_PATTERN
++                ""index column names [%s]."" % SPARK_INDEX_NAME_PATTERN
+
+             # Create default index.
+-            index_map = [(SPARK_INDEX_NAME_FORMAT(0), None)]
+-            sdf = _InternalFrame.attach_default_index(sdf)
++            sdf, index_column = _InternalFrame.attach_default_index(sdf)
++            index_map = [(index_column, None)]
+
+         if NATURAL_ORDER_COLUMN_NAME not in sdf.columns:
+             sdf = sdf.withColumn(NATURAL_ORDER_COLUMN_NAME, F.monotonically_increasing_id())","I don't think we still need this check, but I'd leave it as an assertion for now."
+1614,"@@ -203,4 +203,9 @@ class Cart < ActiveRecord::Base
+       0.0
+     end
+   end
++
++  # may be replaced with paper-trail or similar at some point
++  def version
++    self.updated_at.to_i
++  end
+ end","Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?"
+1615,"@@ -215,6 +215,10 @@ namespace ScenarioMeasurement
+                 }
+                 TraceEventSession.Merge(files.ToArray(), traceFileName);
+
++                if (guiApp)
++                {
++                    appExe = Path.Join(workingDir, appExe);
++                }
+                 string commandLine = $""\""{appExe}\"""";
+                 if (!String.IsNullOrEmpty(appArgs))
+                 {",wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is
+1616,"@@ -329,8 +329,14 @@ public class ConfigCenterClient {
+
+     public void refreshConfig(String configcenter, boolean wait) {
+       CountDownLatch latch = new CountDownLatch(1);
++      String encodeServiceName = """";
++      try {
++        encodeServiceName = URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), ""UTF-8"");
++      } catch (UnsupportedEncodingException e) {
++        LOGGER.error(""encode error: {}"",e.getMessage());
++      }
++      String path = URIConst.ITEMS + ""?dimensionsInfo="" + encodeServiceName;
+       clientMgr.findThreadBindClientPool().runOnContext(client -> {
+-        String path = URIConst.ITEMS + ""?dimensionsInfo="" + StringUtils.deleteWhitespace(serviceName);
+         IpPort ipPort = NetUtils.parseIpPortFromURI(configcenter);
+         HttpClientRequest request = client.get(ipPort.getPort(), ipPort.getHostOrIp(), path, rsp -> {
+           if (rsp.statusCode() == HttpResponseStatus.OK.code()) {","1.not format code 2.failed but still continue? 3.""UTF-8"" can changed to java.nio.charset.StandardCharsets.UTF_8.name()"
+1617,"@@ -74,6 +74,7 @@ from typing import Any, Callable, Iterator, List, Optional, Pattern, Tuple
+ import astroid
+ import astroid.exceptions
+ from astroid import bases, nodes
++from astroid.brain import brain_dataclasses
+
+ from pylint.checkers import BaseChecker, utils
+ from pylint.checkers.utils import (","I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?"
+1618,"@@ -54,6 +54,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Http
+
+                     InitializeHeaders();
+
++                    if (_corruptedRequest)
++                    {
++                        await ProduceEnd();
++                        return;
++                    }
++
+                     while (!_requestProcessingStopping && !TakeMessageHeaders(SocketInput, FrameRequestHeaders))
+                     {
+                         if (SocketInput.RemoteIntakeFin)",This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic.
+1619,"@@ -292,7 +292,7 @@ class _RunData(object):
+         direct_access_sources = set()
+         for backend in backend_service.backends:
+             instance_group = self.find_instance_group_by_url(
+-                backend.get('group'))
++                backend.get('resourceGroup'))
+             if not instance_group:
+                 continue
+ ","Please make the change in the CAI inventory, rather than changing the scanner."
+1620,"@@ -6,7 +6,7 @@ package net.sourceforge.pmd.lang.jsp.ast;
+
+ import net.sourceforge.pmd.lang.ast.AbstractNode;
+
+-public class AbstractJspNode extends AbstractNode implements JspNode {
++public abstract class AbstractJspNode extends AbstractNode implements JspNode {
+
+     protected JspParser parser;
+ ","adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0"
+1621,"@@ -16,6 +16,7 @@ describe IndividualPlan do
+
+   it_behaves_like 'a Plan with countable subscriptions'
+   it_behaves_like 'a Plan for public listing'
++  it_behaves_like 'Purchaseable plan'
+
+   describe '.active' do
+     it 'only includes active plans' do","This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind."
+1622,"@@ -304,14 +304,15 @@ size_t network_prefix)
+ bool nano::server_socket::limit_reached_for_incoming_subnetwork_connections (std::shared_ptr<nano::socket> const & new_connection)
+ {
+ 	debug_assert (strand.running_in_this_thread ());
+-	if (node.flags.disable_max_peers_per_subnetwork)
++	if (node.flags.disable_max_peers_per_subnetwork || nano::transport::is_ipv4_or_v4_mapped_address (new_connection->remote.address ()))
+ 	{
+ 		// If the limit is disabled, then it is unreachable.
++		// If the address is IPv4 we don't check for a network limit, since its address space isn't big as IPv6 /64.
+ 		return false;
+ 	}
+ 	auto const counted_connections = socket_functions::count_subnetwork_connections (
+ 	connections_per_address,
+-	nano::transport::mapped_from_v4_or_v6 (new_connection->remote.address ()),
++	new_connection->remote.address ().to_v6 (),
+ 	node.network_params.network.ipv6_subnetwork_prefix_for_limiting);
+ 	return counted_connections >= node.network_params.network.max_peers_per_subnetwork;
+ }",I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped)
+1623,"@@ -41,7 +41,7 @@ gboolean
+ ot_remote_builtin_delete_cookie (int argc, char **argv, GCancellable *cancellable, GError **error)
+ {
+   g_autoptr(OstreeRepo) repo = NULL;
+-  g_autoptr(GOptionContext) context = g_option_context_new (""NAME DOMAIN PATH COOKIE_NAME- Remote one cookie from remote"");
++  g_autoptr(GOptionContext) context = g_option_context_new (""NAME DOMAIN PATH COOKIE_NAME- Remove one cookie from remote"");
+
+   if (!ostree_option_context_parse (context, option_entries, &argc, &argv,
+                                     OSTREE_BUILTIN_FLAG_NONE, &repo, cancellable, error))",It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree.
+1624,"@@ -29,7 +29,7 @@ import org.openqa.selenium.remote.service.DriverService;
+  *
+  * @see <a href=""https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/client/command_executor.py"">List of ChromeWebdriver commands</a>
+  */
+-class ChromeDriverCommandExecutor extends DriverCommandExecutor {
++public class ChromeDriverCommandExecutor extends DriverCommandExecutor {
+
+   private static final ImmutableMap<String, CommandInfo> CHROME_COMMAND_NAME_TO_URL = ImmutableMap.of(
+       ChromeDriverCommand.LAUNCH_APP,",This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?
+1625,"@@ -84,7 +84,9 @@ public class CompareObjectsWithEqualsRule extends AbstractJavaRule {
+                 ASTReferenceType type1 = ((Node) nd1.getAccessNodeParent())
+                         .getFirstDescendantOfType(ASTReferenceType.class);
+                 // skip, if it is an enum
+-                if (type0.getType() != null && type0.getType().equals(type1.getType()) && type0.getType().isEnum()) {
++                if (type0.getType() != null && type0.getType().equals(type1.getType())
++                    // It may be a custom enum class or an explicit Enum class usage
++                    && (type0.getType().isEnum() || type0.getType() == java.lang.Enum.class)) {
+                     return data;
+                 }
+ ","it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here."
+1626,"@@ -49,6 +49,15 @@ class QuteSchemeHandler(schemehandler.SchemeHandler):
+
+     """"""Scheme handler for qute: URLs.""""""
+
++    handlers = dict()
++
++    @classmethod
++    def addHandler(cls, name):
++        """"""Add a handler to the qute: sheme.""""""
++        def namedecorator(function):
++            cls.handlers[name] = function
++        return namedecorator
++
+     def createRequest(self, _op, request, _outgoing_data):
+         """"""Create a new request.
+ ",Please use `{}` instead of `dict()`
+1627,"@@ -20,11 +20,12 @@
+  * External dependencies
+  */
+ import PropTypes from 'prop-types';
++import { useInView } from 'react-intersection-observer';
+
+ /**
+  * WordPress dependencies
+  */
+-import { useCallback } from '@wordpress/element';
++import { useCallback, useEffect } from '@wordpress/element';
+ import { __ } from '@wordpress/i18n';
+
+ /**",I have concerns about using this in more places before #3278 - I'll take a look at that again shortly.
+1628,"@@ -37,7 +37,16 @@ func TestConvert(t *testing.T) {
+ 	testLog := newTestLog()
+ 	testLog.Topics = topics
+ 	testLog.NotFixTopicCopyBug = true
+-	receipt := &Receipt{1, 1, hash.ZeroHash256, 1, ""test"", []*Log{testLog}, nil, ""balance not enough""}
++	receipt := &Receipt{
++		Status:             1,
++		BlockHeight:        1,
++		ActionHash:         hash.ZeroHash256,
++		GasConsumed:        1,
++		ContractAddress:    ""test"",
++		TxIndex:            1,
++		logs:               []*Log{testLog},
++		executionRevertMsg: ""balance not enough"",
++	}
+
+ 	typeReceipt := receipt.ConvertToReceiptPb()
+ 	require.NotNil(typeReceipt)",new field needs to be asserted
+1629,"@@ -190,6 +190,7 @@ void Host::appendLogsInternal(folly::EventBase* eb,
+             {
+                 std::lock_guard<std::mutex> g(self->lock_);
+                 self->setResponse(r);
++                self->lastLogIdSent_ = self->logIdToSend_;
+             }
+             self->noMoreRequestCV_.notify_all();
+             return;","when send log failed, why update the last sent log id?"
+1630,"@@ -127,12 +127,12 @@ public final class Tuple0 implements Tuple, Comparable<Tuple0>, Serializable {
+     }
+
+     @Override
+-    public <T> Tuple1<T> prepend(T value) {
++    public <T> Tuple1<T> append(T value) {
+        return new Tuple1<>(value);
+     }
+
+     @Override
+-    public <T> Tuple1<T> append(T value) {
++    public <T> Tuple1<T> prepend(T value) {
+        return new Tuple1<>(value);
+     }
+ ","what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think"
+1631,"@@ -291,6 +291,8 @@ type BackupInfo struct {
+ 	// Timestamp is the timestamp at which the source volume
+ 	// was backed up to cloud
+ 	Timestamp time.Time
++	// Metadata associated with the backup
++	Metadata map[string]string
+ 	// Status indicates if this backup was successful
+ 	Status string
+ }",Why is this necessary? Could you provide some context?
+1632,"@@ -46,7 +46,9 @@ public class HTMLTestResults {
+   private final HTMLSuiteResult suite;
+
+   private static final String HEADER = ""<html>\n"" +
+-      ""<head><style type='text/css'>\n"" +
++      ""<head>\n""+
++      ""<meta charset=\""UTF-8\"">\n""+
++      ""<style type='text/css'>\n"" +
+       ""body, table {\n"" +
+       ""    font-family: Verdana, Arial, sans-serif;\n"" +
+       ""    font-size: 12;\n"" +","Is there a recommended quote style for attributes? I see single and double here, double further down."
+1633,"@@ -772,6 +772,17 @@ var _ = Describe(""Session"", func() {
+ 			Expect(mconn.written[0][0] & 0x02).ToNot(BeZero()) // Public Reset
+ 			Expect(sess.runClosed).To(BeClosed())
+ 		})
++
++		It(""unblocks WaitUntilClosed when the run loop exists"", func() {
++			returned := make(chan struct{})
++			go func() {
++				sess.WaitUntilClosed()
++				close(returned)
++			}()
++			Consistently(returned).ShouldNot(BeClosed())
++			sess.Close(nil)
++			Eventually(returned).Should(BeClosed())
++		})
+ 	})
+
+ 	Context(""receiving packets"", func() {",Please use an atomic bool.
+1634,"@@ -0,0 +1,19 @@
++namespace Datadog.Trace.ClrProfiler
++{
++    internal static class WebHelpers
++    {
++        public static void DecorateWebSpan(
++            this Span span,
++            string resourceName,
++            string method,
++            string host,
++            string httpUrl)
++        {
++            span.Type = SpanTypes.Web;
++            span.ResourceName = resourceName;
++            span.SetTag(Tags.HttpMethod, method);
++            span.SetTag(Tags.HttpRequestHeadersHost, host);
++            span.SetTag(Tags.HttpUrl, httpUrl);
++        }
++    }
++}",Consider naming this class `SpanExtensions` to follow C# conventions.
+1635,"@@ -81,11 +81,6 @@ namespace Datadog.Trace.Logging
+             {
+                 // Don't let this exception bubble up as this logger is for debugging and is non-critical
+             }
+-            finally
+-            {
+-                // Log some information to correspond with the app domain
+-                SharedLogger.Information(FrameworkDescription.Create().ToString());
+-            }
+         }
+
+         public static ILogger GetLogger(Type classType)","FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions."
+1636,"@@ -34,6 +34,8 @@ module Beaker
+           Beaker::Fusion
+         when /blimpy/
+           Beaker::Blimper
++        when /ec2/
++          Beaker::AwsSdk
+         when /vcloud/
+           if options['pooling_api']
+             Beaker::VcloudPooled","Ah, so we are going to need to update node/host files for this to work?"
+1637,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users."
+1638,"@@ -11,9 +11,15 @@ class ObservationsController < ApplicationController
+   end
+
+   def destroy
+-    self.observation.destroy
+-    flash[:success] = ""Deleted Observation""
+-    redirect_to proposal_path(self.observation.proposal_id)
++    proposal = observation.proposal
++    if current_user == observation.user
++      redirect_path = ""/proposals""
++    else
++      redirect_path = proposal_path(proposal)
++    end
++    observation.destroy
++    flash[:success] = ""Deleted Observation for #{proposal.public_id}""
++    redirect_to redirect_path
+   end
+
+   protected",used named path (`proposals_path`) instead?
+1639,"@@ -107,7 +107,10 @@ class Sierra extends AbstractBase implements TranslatorAwareInterface
+             . ""FROM sierra_view.bib_view ""
+             . ""LEFT JOIN sierra_view.bib_record_item_record_link ON ""
+             . ""(bib_view.id = bib_record_item_record_link.bib_record_id) ""
+-            . ""WHERE bib_view.record_num = $1;"";
++            . ""INNER JOIN sierra_view.item_view ON ""
++            . ""(bib_record_item_record_link.item_record_id = item_view.id ""
++            . ""WHERE bib_view.record_num = $1 ""
++            . ""AND item_view.is_suppressed = false;"";
+         $record_ids = pg_query_params(
+             $this->db, $get_record_ids_query, [$this->idStrip($id)]
+         );","Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!"
+1640,"@@ -256,6 +256,13 @@ func (o *Outbound) call(ctx context.Context, treq *transport.Request) (*transpor
+
+ 	span.SetTag(""http.status_code"", response.StatusCode)
+
++	// Service name match validation, return yarpcerrors.CodeInternal error if not match
++	if match, resSvcName := checkServiceMatch(treq.Service, response.Header); !match {
++		return nil, transport.UpdateSpanWithErr(span,
++			yarpcerrors.InternalErrorf(""service name sent from the request ""+
++				""does not match the service name received in the response, sent %q, got: %q"", treq.Service, resSvcName))
++	}
++
+ 	tres := &transport.Response{
+ 		Headers:          applicationHeaders.FromHTTPHeaders(response.Header, transport.NewHeaders()),
+ 		Body:             response.Body,",Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?
+1641,"@@ -63,6 +63,7 @@ class AzureBlobClient(FileSystem):
+             * `token_credential` - A token credential used to authenticate HTTPS requests. The token value should be updated before its expiration.
+         """"""
+         self.options = {""account_name"": account_name, ""account_key"": account_key, ""sas_token"": sas_token}
++        kwargs[""protocol""] = kwargs.get(""protocol"") or ""https""  # Default protocol to https if it's not set
+         self.kwargs = kwargs
+
+     @property","if using dict.get, this could just be `kwargs.get('protocol', 'https')`"
+1642,"@@ -443,6 +443,14 @@ public class SurfaceNamer extends NameFormatterDelegator {
+     return getNotImplementedString(""SurfaceNamer.getAsyncApiMethodExampleName"");
+   }
+
++  public String getGrpcStreamingApiMethodName(Method method) {
++    return getApiMethodName(method);
++  }
++
++  public String getGrpcStreamingApiMethodExampleName(Interface interfaze, Method method) {
++    return getGrpcStreamingApiMethodName(method);
++  }
++
+   /**
+    * The name of a variable to hold a value for the given proto message field
+    * (such as a flattened parameter).",Add docs to the new methods here
+1643,"@@ -28,9 +28,11 @@ namespace Nethermind.Trie.Pruning
+             _memoryLimit = memoryLimit;
+         }
+
++        public bool Enabled => true;
++
+         public bool ShouldPrune(in long currentMemory)
+         {
+             return currentMemory >= _memoryLimit;
+         }
+     }
+-}
++}",what does it mean enabled?
+1644,"@@ -128,7 +128,7 @@ public class SmartStore  {
+     public static synchronized void changeKey(SQLiteDatabase db, String oldKey, String newKey) {
+     	synchronized(db) {
+ 	        if (newKey != null && !newKey.trim().equals("""")) {
+-	            db.execSQL(""PRAGMA rekey = '"" + newKey + ""'"");
++	            db.query(""PRAGMA rekey = '"" + newKey + ""'"");
+ 	            DBOpenHelper.reEncryptAllFiles(db, oldKey, newKey);
+ 	        }
+     	}","Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok)."
+1645,"@@ -83,11 +83,11 @@ func retrieveFeeds(ctx *middleware.Context, ctxUserID, userID, offset int64, isP
+ }
+
+ func Dashboard(ctx *middleware.Context) {
+-	ctx.Data[""Title""] = ctx.Tr(""dashboard"")
++  ctxUser := getDashboardContextUser(ctx)
++	ctx.Data[""Title""] = ctxUser.DisplayName() + "" "" + ctx.Tr(""dashboard"")
+ 	ctx.Data[""PageIsDashboard""] = true
+ 	ctx.Data[""PageIsNews""] = true
+
+-	ctxUser := getDashboardContextUser(ctx)
+ 	if ctx.Written() {
+ 		return
+ 	}","Maybe we could remove `"" "" + ctx.Tr(""dashboard"")` completely?"
+1646,"@@ -1,13 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-# SPDX - License - Identifier: Apache - 2.0
++# SPDX-License-Identifier: Apache-2.0
++
++# Purpose
++# This code demonstrates how to copy an object from one Amazon Simple Storage Solution (Amazon S3) bucket to another,
++# changing the object's server-side encryption state during the copy operation.
+
+ # snippet-start:[s3.ruby.copy_object_encrypt_copy.rb]
+ require 'aws-sdk-s3'
+
+-# Copies an object from one Amazon S3 bucket to another,
+-#   changing the object's server-side encryption state during
+-#   the copy operation.
+-#
+ # Prerequisites:
+ #
+ # - A bucket containing an object to be copied.",Simple Storage **Service**
+1647,"@@ -42,6 +42,15 @@ type jsonHandler struct {
+ 	handler reflect.Value
+ }
+
++type jsonHandler2 struct {
++	handler reflect.Value
++}
++
++func (h jsonHandler2) Handle(ctx context.Context, reqBody interface{}) (interface{}, error) {
++	results := h.handler.Call([]reflect.Value{reflect.ValueOf(ctx), reflect.ValueOf(reqBody)})
++	return results[0].Interface(), results[1].Interface().(error)
++}
++
+ func (h jsonHandler) Handle(ctx context.Context, req *yarpc.Request, reqBuf *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
+ 	if err := yarpcencoding.ExpectEncodings(req, Encoding); err != nil {
+ 		return nil, nil, err",Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error.
+1648,"@@ -23,8 +23,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+         // Matches the default LimitRequestFields in Apache httpd.
+         private int _maxRequestHeaderCount = 100;
+
+-        // Matches the default http.sys connection timeout.
+-        private TimeSpan _connectionTimeout = TimeSpan.FromMinutes(2);
++        // Matches the default http.sys connectionTimeout.
++        private TimeSpan _keepAliveTimeout = TimeSpan.FromMinutes(2);
++
++        private TimeSpan _requestHeadersTimeout = TimeSpan.FromSeconds(30);
+
+         /// <summary>
+         /// Gets or sets the maximum size of the response buffer before write",Where did we take this default from?
+1649,"@@ -122,6 +122,8 @@ const baseSelectors = {
+ 	 * @param {Object}         options                     Options for generating the report.
+ 	 * @param {string}         options.startDate           Required, unless dateRange is provided. Start date to query report data for as YYYY-mm-dd.
+ 	 * @param {string}         options.endDate             Required, unless dateRange is provided. End date to query report data for as YYYY-mm-dd.
++	 * @param {string}         [options.compareStartDate]  Optional. Start date to compare report data for as YYYY-mm-dd.
++	 * @param {string}         [options.compareEndDate]    Optional. End date to compare report data for as YYYY-mm-dd.
+ 	 * @param {string}         options.dateRange           Required, alternative to startDate and endDate. A date range string such as 'last-28-days'.
+ 	 * @param {boolean}        [options.compareDateRanges] Optional. Only relevant with dateRange. Default false.
+ 	 * @param {boolean}        [options.multiDateRange]    Optional. Only relevant with dateRange. Default false.",Let's move these down to be after all required arguments rather than in between.
+1650,"@@ -90,6 +90,10 @@ namespace FlatBuffers
+             _objectStart = 0;
+             _numVtables = 0;
+             _vectorNumElems = 0;
++            if (_sharedStringMap != null)
++            {
++                _sharedStringMap.Clear();
++            }
+         }
+
+         /// <summary>","Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table."
+1651,"@@ -107,7 +107,8 @@ func (i *Inbound) start() error {
+ 		return errRouterNotSet
+ 	}
+
+-	handler := newHandler(i)
++	handler := newHandler(i, i.t.options.logger)
++	// handler := &handler{i: i, logger: i.t.options.logger}
+
+ 	server := grpc.NewServer(
+ 		grpc.CustomCodec(customCodec{}),",did you mean to delete this line?
+1652,"@@ -420,6 +420,10 @@ public class DatasetField implements Serializable {
+         } else if (template != null) {
+             return template.getDataverse();
+         } else {
++
++            System.out.print(""getDataverseException: "" + this.datasetFieldType.getDisplayName());
++            System.out.print(""getDataverseException Compound: "" + this.getCompoundDisplayValue());
++            System.out.print(""getDataverseException Regular: "" + this.getDisplayValue());
+             throw new IllegalStateException(""DatasetField is in an illegal state: no dataset version, compound value, or template is set as its parent."");
+         }
+     }",Should we use logger instead?
+1653,"@@ -5,7 +5,7 @@ describe AnalyticsHelper do
+     it ""is true when ENV['ANALYTICS'] is present"" do
+       ENV['ANALYTICS'] = 'anything'
+
+-      expect(analytics?).to be_true
++      expect(analytics?).to be true
+
+       ENV['ANALYTICS'] = nil
+     end",I think it would be preferred to do `expect(helper).to be_analytics`
+1654,"@@ -10089,7 +10089,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+
+         if key is None:
+             raise KeyError(""none key"")
+-        if isinstance(key, (str, tuple, list)):
++        if isinstance(key, (str, tuple, list, pd.Index)):
+             return self.loc[:, key]
+         elif isinstance(key, slice):
+             if any(type(n) == int or None for n in [key.start, key.stop]):","Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now."
+1655,"@@ -183,7 +183,7 @@ func (s *resetorSuite) TestResetWorkflowExecution_NoReplication() {
+ 	currRunID := uuid.New().String()
+ 	we := commonpb.WorkflowExecution{
+ 		WorkflowId: wid,
+-		RunId:      forkRunID,
++		RunId:      """",
+ 	}
+ 	request.ResetRequest = &workflowservice.ResetWorkflowExecutionRequest{
+ 		Namespace:                 ""testNamespace"",","If there any other tests, I would make it optional there also."
+1656,"@@ -54,6 +54,7 @@ Workshops::Application.routes.draw do
+   end
+
+   match '/watch' => 'high_voltage/pages#show', as: :watch, id: 'watch'
++  match '/my-accounts' => 'high_voltage/pages#show', as: :watch, id: 'my-accounts'
+
+   match '/directions' => ""high_voltage/pages#show"", as: :directions, id: ""directions""
+   match '/group-training' => ""high_voltage/pages#show"", as: :group_training, id: ""group-training""","This can be removed too, right?"
+1657,"@@ -248,7 +248,7 @@ public class SettingsExporter {
+
+
+         // Write outgoing server settings
+-        ServerSettings outgoing = Transport.decodeTransportUri(account.getTransportUri());
++        ServerSettings outgoing = Transport.decodeTransportUri(account.getTransportUri(0));
+         serializer.startTag(null, OUTGOING_SERVER_ELEMENT);
+         serializer.attribute(null, TYPE_ATTRIBUTE, outgoing.type);
+ ","If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them."
+1658,"@@ -28,5 +28,14 @@ namespace Datadog.Trace.RuntimeMetrics
+         public const string CpuUserTime = ""runtime.dotnet.cpu.user"";
+         public const string CpuSystemTime = ""runtime.dotnet.cpu.system"";
+         public const string CpuPercentage = ""runtime.dotnet.cpu.percent"";
++
++        public const string CurrentRequests = ""runtime.dotnet.aspnetcore.requests.current"";
++        public const string FailedRequests = ""runtime.dotnet.aspnetcore.requests.failed"";
++        public const string TotalRequests = ""runtime.dotnet.aspnetcore.requests.total"";
++        public const string RequestQueueLength = ""runtime.dotnet.aspnetcore.requests.queue_length"";
++
++        public const string CurrentConnections = ""runtime.dotnet.aspnetcore.connections.current"";
++        public const string ConnectionQueueLength = ""runtime.dotnet.aspnetcore.connections.queue_length"";
++        public const string TotalConnections = ""runtime.dotnet.aspnetcore.connections.total"";
+     }
+ }",nit: Can we prefix these variables with `AspNetCore`?
+1659,"@@ -47,12 +47,18 @@ describe ""transpiling YAML plans"" do
+   }
+   PLAN
+
+-  it 'transpiles a yaml plan' do
++  it 'transpiles a YAML plan from a path' do
+     expect {
+       run_cli(%W[plan convert #{plan_path}])
+     }.to output(output_plan).to_stdout
+   end
+
++  it 'transpiles a YAML plan from a plan name' do
++    expect {
++      run_cli(%W[plan convert yaml::conversion -m #{modulepath}])
++    }.to output(output_plan).to_stdout
++  end
++
+   it 'plan show output is the same for the original plan and converted plan', ssh: true do
+     Dir.mktmpdir do |tmpdir|
+       FileUtils.mkdir_p(File.join(tmpdir, 'plans'))",Can this also include a quick test for transpiling by name?
+1660,"@@ -59,10 +59,11 @@ func (client *clientRest) NodeRegister(proposal dto_discovery.ServiceProposal) (
+ 	return
+ }
+
+-func (client *clientRest) NodeSendStats(nodeKey string, sessionList []dto.SessionStatsDeprecated) (err error) {
++func (client *clientRest) NodeSendStats(nodeKey string) (err error) {
+ 	response, err := client.doPostRequest(""node_send_stats"", dto.NodeStatsRequest{
+-		NodeKey:  nodeKey,
+-		Sessions: sessionList,
++		NodeKey: nodeKey,
++		// TODO: remove this struct in favor of `SessionStats`
++		Sessions: []dto.SessionStats{},
+ 	})
+ 	if err == nil {
+ 		defer response.Body.Close()",This TODO can be removed
+1661,"@@ -5,13 +5,13 @@ using UIKit;
+
+ namespace MvvmCross.iOS.Support.Presenters
+ {
+-	public interface IMvxTabBarViewController
+-	{
+-		void ShowTabView(UIViewController viewController, bool wrapInNavigationController, string tabTitle, string tabIconName);
++    public interface IMvxTabBarViewController
++    {
++        void ShowTabView(UIViewController viewController, bool wrapInNavigationController, string tabTitle, string tabIconName, string tabAccessibilityIdentifier);
+
+-		bool ShowChildView(UIViewController viewController);
++        bool ShowChildView(UIViewController viewController);
+
+-		bool CloseChildViewModel(IMvxViewModel viewModel);
+-	}
++        bool CloseChildViewModel(IMvxViewModel viewModel);
++    }
+ }
+ ",can we make tabAccessibilityIdentifier = null as default?
+1662,"@@ -80,8 +80,9 @@ func initProvider() func() {
+ 	pusher.Start()
+
+ 	return func() {
+-		bsp.Shutdown() // shutdown the processor
+-		handleErr(exp.Shutdown(context.Background()), ""failed to stop exporter"")
++		ctx := context.Background()
++		_ = bsp.Shutdown(ctx) // shutdown the processor
++		handleErr(exp.Shutdown(ctx), ""failed to stop exporter"")
+ 		pusher.Stop() // pushes any last exports to the receiver
+ 	}
+ }",Should we print this error?
+1663,"@@ -31,7 +31,7 @@ def multiclass_nms(multi_bboxes,
+         tuple: (bboxes, labels, indices (optional)), tensors of shape (k, 5),
+             (k), and (k). Labels are 0-based.
+     """"""
+-    num_classes = multi_scores.size(1) - 1
++    num_classes = int(multi_scores.size(1) - 1)
+     # exclude background category
+     if multi_bboxes.shape[1] > 4:
+         bboxes = multi_bboxes.view(multi_scores.size(0), -1, 4)",For which reason do we need to convert this to int here?
+1664,"@@ -19,7 +19,7 @@ func setFreezer(dirPath string, state configs.FreezerState) error {
+ 		// freeze the container (since without the freezer cgroup, that's a
+ 		// no-op).
+ 		if state == configs.Undefined || state == configs.Thawed {
+-			err = nil
++			return nil
+ 		}
+ 		return errors.Wrap(err, ""freezer not supported"")
+ 	}","FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`"
+1665,"@@ -1,8 +1 @@
+-<h1><%= plan.title %></h1>
+-
+-<% if plan.visibility == 'is_test' %>
+-  <div class=""roadmap-info-box"">
+-    <i class=""fa fa-exclamation-circle"" aria-hidden=""true""></i>
+-    <span><%= _('This is a') %> <strong><%= _('test plan') %></strong>.</span>
+-  </div>
+-<% end %>
++<h1><%= plan.title %></h1> ",Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?
+1666,"@@ -107,13 +107,12 @@ func TestEnvAdd_Execute(t *testing.T) {
+ 				prog:          mockSpinner,
+ 			},
+ 			expectedEnv: archer.Environment{
+-				Name:    ""env"",
+-				Project: ""project"",
+-				//TODO update these to real values
+-				AccountID:          ""1234"",
+-				Region:             ""1234"",
+-				Prod:               true,
+-				PublicLoadBalancer: true,
++				Name:        ""env"",
++				Project:     ""project"",
++				AccountID:   ""1234"",
++				Region:      ""1234"",
++				RegistryURL: ""902697171733.dkr.ecr.eu-west-3.amazonaws.com/project/env"",
++				Prod:        true,
+ 			},
+ 			mocking: func() {
+ 				gomock.InOrder(",seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below.
+1667,"@@ -14,7 +14,9 @@
+
+ import abc
+ import logging
++import datetime
+ import parameter
++import target
+ import warnings
+ import traceback
+ import pyparsing as pp",Are these imports needed?
+1668,"@@ -139,6 +139,13 @@ describe('text.formControlValue', function() {
+ 				axe.utils
+ 					.querySelectorAll(axe._tree[0], '#fixture input')
+ 					.forEach(function(target) {
++						// Safari and IE11 do not support the color input type
++						// and thus treat them as text inputs. ignore fallback
++						// inputs
++						if (target.actualNode.type === 'text') {
++							return;
++						}
++
+ 						assert.equal(
+ 							nativeTextboxValue(target),
+ 							'',","I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way."
+1669,"@@ -96,11 +96,12 @@ public class CopyOneFile implements Closeable {
+         // Paranoia: make sure the primary node is not smoking crack, by somehow sending us an already corrupted file whose checksum (in its
+         // footer) disagrees with reality:
+         long actualChecksumIn = in.readLong();
+-        if (actualChecksumIn != checksum) {
++        // CheckSum is written in Big Endian so we need to reverse bytes
++        if (actualChecksumIn != Long.reverseBytes(checksum)) {
+           dest.message(""file "" + tmpName + "": checksum claimed by primary disagrees with the file's footer: claimed checksum="" + checksum + "" vs actual="" + actualChecksumIn);
+           throw new IOException(""file "" + name + "": checksum mismatch after file copy"");
+         }
+-        out.writeLong(checksum);
++        out.writeLong(actualChecksumIn);
+         bytesCopied += Long.BYTES;
+         close();
+ ",IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?
+1670,"@@ -512,6 +512,13 @@ func prune(opts PruneOptions, gopts GlobalOptions, repo restic.Repository, usedB
+ 		DeleteFiles(gopts, repo, removePacksFirst, restic.PackFile)
+ 	}
+
++	// delete obsolete index files (index files that have already been superseded)
++	obsoleteIndexes := (repo.Index()).(*repository.MasterIndex).Obsolete()
++	if len(obsoleteIndexes) != 0 {
++		Verbosef(""deleting unused index files...\n"")
++		DeleteFiles(gopts, repo, obsoleteIndexes, restic.IndexFile)
++	}
++
+ 	if len(repackPacks) != 0 {
+ 		Verbosef(""repacking packs\n"")
+ 		bar := newProgressMax(!gopts.Quiet, uint64(len(repackPacks)), ""packs repacked"")",I think we also need something similar for `rebuild-index`?
+1671,"@@ -20,12 +20,14 @@ import (
+ 	""github.com/spiffe/spire/pkg/common/telemetry""
+ 	""github.com/spiffe/spire/pkg/common/util""
+ 	""github.com/spiffe/spire/pkg/server""
++	bundleClient ""github.com/spiffe/spire/pkg/server/bundle/client""
+ )
+
+ const (
+-	defaultConfigPath = ""conf/server/server.conf""
+-	defaultSocketPath = ""/tmp/spire-registration.sock""
+-	defaultLogLevel   = ""INFO""
++	defaultConfigPath         = ""conf/server/server.conf""
++	defaultSocketPath         = ""/tmp/spire-registration.sock""
++	defaultLogLevel           = ""INFO""
++	defaultBundleEndpointPort = 443
+ )
+
+ // runConfig represents available configurables for file and CLI options",I think convention is snake case for import naming?
+1672,"@@ -303,7 +303,13 @@ public class TiDAGRequest implements Serializable {
+         // double read case
+         if (!hasPk) {
+           // add handle column
+-          indexScanBuilder.addColumns(handleColumn);
++          if (!tableInfo.isCommonHandle()) {
++            indexScanBuilder.addColumns(handleColumn);
++          } else {
++            for (TiIndexColumn col : tableInfo.getPrimaryKey().getIndexColumns()) {
++              indexScanBuilder.addColumns(tableInfo.getColumn(col.getName()).toProto(tableInfo));
++            }
++          }
+           ++colCount;
+           addRequiredIndexDataType();
+         }",i think haspk is false?
+1673,"@@ -113,6 +113,7 @@ var opts struct {
+ 		FailingTestsOk  bool         `long:""failing_tests_ok"" hidden:""true"" description:""Exit with status 0 even if tests fail (nonzero only if catastrophe happens)""`
+ 		NumRuns         int          `long:""num_runs"" short:""n"" description:""Number of times to run each test target.""`
+ 		TestResultsFile cli.Filepath `long:""test_results_file"" default:""plz-out/log/test_results.xml"" description:""File to write combined test results to.""`
++		SurefireDir     cli.Filepath `long:""surefir_dir"" default:""plz-out/surefire-reports"" description:""Directory to copy XML test results to.""`
+ 		ShowOutput      bool         `short:""s"" long:""show_output"" description:""Always show output of tests, even on success.""`
+ 		Debug           bool         `short:""d"" long:""debug"" description:""Allows starting an interactive debugger on test failure. Does not work with all test types (currently only python/pytest, C and C++). Implies -c dbg unless otherwise set.""`
+ 		Failed          bool         `short:""f"" long:""failed"" description:""Runs just the test cases that failed from the immediately previous run.""`",you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option)
+1674,"@@ -104,7 +104,7 @@ func (s *historyArchiverSuite) SetupTest() {
+ 	s.Assertions = require.New(s.T())
+ 	s.container = &archiver.HistoryBootstrapContainer{
+ 		Logger:        log.NewNoopLogger(),
+-		MetricsClient: metrics.NewClient(scope, metrics.HistoryArchiverScope),
++		MetricsClient: metrics.NewClient(&metrics.ClientConfig{}, scope, metrics.HistoryArchiverScope),
+ 	}
+
+ 	s.controller = gomock.NewController(s.T())","instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil."
+1675,"@@ -101,7 +101,7 @@ class HashableJSON(json.JSONEncoder):
+         elif isinstance(obj, np.ndarray):
+             return obj.tolist()
+         if pd and isinstance(obj, (pd.Series, pd.DataFrame)):
+-            return repr(sorted(list(obj.to_dict().items())))
++            return obj.to_csv().encode('utf-8')
+         elif isinstance(obj, self.string_hashable):
+             return str(obj)
+         elif isinstance(obj, self.repr_hashable):","A fair bit faster, although still not great, hence also adding a hashkey."
+1676,"@@ -0,0 +1,17 @@
++<div class=""started"">
++  <section class=""trail"">
++    <header>
++      <h1><%= trail.name %></h1>
++      <span class=""numerical-progress"">
++        <%= pluralize(
++          trail.steps_remaining_for(current_user),
++          ""step""
++        ) %> remaining
++      </span>
++    </header>
++
++    <section class=""progress"">
++      <%= render partial: ""trails/exercise"", collection: trail.exercises %>
++    </section>
++  </section>
++</div>","If we're going to leave this in here, how about we at least pull it into partial?"
+1677,"@@ -75,7 +75,7 @@ func TestCtlInstall(t *testing.T) {
+ 			testApiServer, cleanup := install_framework.NewTestInstallApiServer(t)
+ 			defer cleanup()
+
+-			ctx, cancel := context.WithTimeout(context.TODO(), time.Second*20)
++			ctx, cancel := context.WithTimeout(context.Background(), time.Second*40)
+ 			defer cancel()
+
+ 			if test.prerun {","This `context` is used correctly, there is nothing left TO DO."
+1678,"@@ -230,12 +230,9 @@ function countDocuments(coll, query, options, callback) {
+   delete options.limit;
+   delete options.skip;
+
+-  coll.aggregate(pipeline, options, (err, result) => {
++  coll.aggregate(pipeline, options).toArray((err, docs) => {
+     if (err) return handleCallback(callback, err);
+-    result.toArray((err, docs) => {
+-      if (err) return handleCallback(err);
+-      handleCallback(callback, null, docs.length ? docs[0].n : 0);
+-    });
++    handleCallback(callback, null, docs.length ? docs[0].n : 0);
+   });
+ }
+ ",If `docs` is an empty array there will be an error
+1679,"@@ -150,7 +150,8 @@ func (u *staticUpstream) From() string {
+
+ func (u *staticUpstream) NewHost(host string) (*UpstreamHost, error) {
+ 	if !strings.HasPrefix(host, ""http"") &&
+-		!strings.HasPrefix(host, ""unix:"") {
++		!strings.HasPrefix(host, ""unix:"") &&
++		!strings.HasPrefix(host, ""quic:"") {
+ 		host = ""http://"" + host
+ 	}
+ 	uh := &UpstreamHost{","Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?"
+1680,"@@ -55,7 +55,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2
+             get
+             {
+                 var dataset = new TheoryData<H2SpecTestCase>();
+-                var toSkip = new[] { ""http2/5.1/8"" };
++                var toSkip = new string[] { /*""http2/5.1/8""*/ };
+
+                 foreach (var testcase in H2SpecCommands.EnumerateTestCases())
+                 {",just remove the entire variable.
+1681,"@@ -202,7 +202,10 @@ Available options are:
+       end
+       define('--modulepath MODULES',
+              ""List of directories containing modules, separated by '#{File::PATH_SEPARATOR}'"") do |modulepath|
+-        @options[:modulepath] = modulepath.split(File::PATH_SEPARATOR)
++        # When specified from the CLI, modulepath entries are relative to pwd
++        @options[:modulepath] = modulepath.split(File::PATH_SEPARATOR).map do |moduledir|
++          File.expand_path(moduledir)
++        end
+       end
+       define('--boltdir FILEPATH',
+              'Specify what Boltdir to load config from (default: autodiscovered from current working dir)') do |path|",Maybe we should put that in the option description?
+1682,"@@ -211,8 +211,8 @@ public class BesuNodeConfigurationBuilder {
+     return this;
+   }
+
+-  public BesuNodeConfigurationBuilder keyFilePath(final String keyFilePath) {
+-    this.keyFilePath = Optional.of(keyFilePath);
++  public BesuNodeConfigurationBuilder keyFilePath(final Optional<String> keyFilePath) {
++    this.keyFilePath = keyFilePath;
+     return this;
+   }
+ ",Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?
+1683,"@@ -125,7 +125,7 @@ public class Parquet {
+     public WriteBuilder forTable(Table table) {
+       schema(table.schema());
+       setAll(table.properties());
+-      metricsConfig(MetricsConfig.fromProperties(table.properties()));
++      metricsConfig(MetricsConfig.forTable(table));
+       return this;
+     }
+ ",Shall we do the same for ORC and Avro?
+1684,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+ {
+ #if NET46",Should be a space between line
+1685,"@@ -6,7 +6,14 @@
+
+         public static byte[] GeneratePrivateKey()
+         {
+-            byte[] bytes = new byte[32];
++            var bytes = new byte[32];
++            SecureRandom.GetBytes(bytes);
++            return bytes;
++        }
++
++        public static byte[] GenerateRandomBytes(int lenght)
++        {
++            var bytes = new byte[lenght];
+             SecureRandom.GetBytes(bytes);
+             return bytes;
+         }","if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used"
+1686,"@@ -1,4 +1,4 @@
+-<figure class=""video_tutorial card"">
++<figure class=""video_tutorial tile"">
+   <%= link_to video_tutorial, title: ""The #{video_tutorial.name} online video tutorial details"" do %>
+     <h5>Video Tutorial</h5>
+     <%= image_tag(video_tutorial.product_image.url) %>","Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR."
+1687,"@@ -53,8 +53,6 @@
+
+ static size_t expectedNumberOfContextVariables;
+ static int64_t expectedContextVariableValue;
+-static std::unordered_map<size_t, Kokkos::Tools::Experimental::SetOrRange>
+-    candidate_value_map;
+
+ int main() {
+   Kokkos::initialize();",Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this.
+1688,"@@ -60,9 +60,12 @@ def average_precision(recalls, precisions, mode='area'):
+ def tpfp_imagenet(det_bboxes,
+                   gt_bboxes,
+                   gt_bboxes_ignore=None,
++                  gt_bboxes_group_of=None,
+                   default_iou_thr=0.5,
++                  ioa_thr=None,
+                   area_ranges=None,
+-                  use_legacy_coordinate=False):
++                  use_legacy_coordinate=False,
++                  use_group_of=False):
+     """"""Check if detected bboxes are true positive or false positive.
+
+     Args:",I recommend move all openimage related logic to a new function
+1689,"@@ -12,6 +12,8 @@ const (
+
+ type Cgroup struct {
+ 	Name string `json:""name""`
++	// indicates that this is an externally passed, fully created cgroup
++	ExternalCgroup bool `json:""external_cgroup""`
+
+ 	// name of parent cgroup or slice
+ 	Parent string `json:""parent""`","We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty."
+1690,"@@ -0,0 +1,16 @@
++<ul class=""teachers"">
++  <li>
++    <%= teacher_gravatar section_teacher.teacher, 92 %>
++    <h2>
++      <span>
++        <%= t '.header',
++              city: section_teacher.section.city,
++              count: @section_teachers.size %>
++      </span>
++      <%= section_teacher.teacher.name %>
++    </h2>
++    <section class=""bio"">
++      <%= raw textilize(section_teacher.teacher.bio) %>
++    </section>
++  </li>
++</ul>",I like how you used the count on the translate call to handle this.
+1691,"@@ -139,11 +139,13 @@ class QueryBuilder implements QueryBuilderInterface
+             $finalQuery->setString($this->getNormalizedQueryString($query));
+         }
+         $string = $finalQuery->getString() ?: '*:*';
+-
+         // Highlighting is enabled if we have a field list set.
+         $highlight = !empty($this->fieldsToHighlight);
+
+         if ($handler = $this->getSearchHandler($finalQuery->getHandler(), $string)) {
++            if ($handler->hasDismax()) {
++                $string = $handler->prepareDismaxQueryString($string);
++            }
+             if (!$handler->hasExtendedDismax()
+                 && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string)
+             ) {","Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look)."
+1692,"@@ -0,0 +1,9 @@
++package com.fsck.k9;
++
++import java.util.*;
++
++public class SputnikTest {
++    public void sputnikTest() {
++        return;
++    }
++}",[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._.
+1693,"@@ -42,6 +42,9 @@ class BaseWebTest(object):
+
+     def get_app_settings(self, additional_settings=None):
+         settings = cliquet_support.DEFAULT_SETTINGS.copy()
++        settings['cliquet.cache_backend'] = 'cliquet.cache.memory'
++        settings['cliquet.storage_backend'] = 'cliquet.storage.memory'
++        settings['cliquet.permission_backend'] = 'cliquet.permission.redis'
+         settings['cliquet.project_name'] = 'cloud storage'
+         settings['cliquet.project_docs'] = 'https://kinto.rtfd.org/'
+         settings['multiauth.authorization_policy'] = (","So, why everything is in memory but the permission backend?"
+1694,"@@ -283,8 +283,9 @@ public class UiSetupWizardImplementation implements SetupWizard {
+      */
+     @Override
+     public String browse(String textToShow, String directory, List<String> allowedExtensions) {
++        final List<String> copiedAllowedExtensions = allowedExtensions != null ? List.copyOf(allowedExtensions) : null;
+         return messageSender.runAndWait(
+-                message -> setupUi.showBrowseStep(message, textToShow, new File(directory), allowedExtensions));
++                message -> setupUi.showBrowseStep(message, textToShow, new File(directory), copiedAllowedExtensions));
+     }
+
+     /**",Are you sure it should be null and not an empty List?
+1695,"@@ -22,10 +22,12 @@ namespace Microsoft.DotNet.Build.Tasks
+         // Additional Dependencies to add to the project.json. May Optionally contain a version.
+         // Will Override dependencies present in the project if there is a conflict.
+         // AdditionalDependencies required metadata:  Name, Version
+-
+         [Required]
+         public ITaskItem[] AdditionalDependencies { get; set; }
+
++        // Framework section which the additional dependencies apply to.  Empty is the default dependencies section.
++        public string[] Frameworks { get; set; }
++
+         public string BuildNumberOverrideStructureRegex { get; set; }
+
+         // Permit overriding package versions found in project.json with custom build number version.","Unfortunately I think the assumption of ""empty"" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated."
+1696,"@@ -121,8 +121,8 @@ namespace Microsoft.AspNet.Server.KestrelTests
+             IDictionary<string, StringValues> headers = new FrameRequestHeaders();
+             var kv1 = new KeyValuePair<string, StringValues>(""host"", new[] { ""localhost"" });
+             var kv2 = new KeyValuePair<string, StringValues>(""custom"", new[] { ""value"" });
+-            var kv1b = new KeyValuePair<string, StringValues>(""host"", new[] { ""localhost"" });
+-            var kv2b = new KeyValuePair<string, StringValues>(""custom"", new[] { ""value"" });
++            var kv1b = new KeyValuePair<string, StringValues>(""host"", new[] { ""not-localhost"" });
++            var kv2b = new KeyValuePair<string, StringValues>(""custom"", new[] { ""not-value"" });
+
+             Assert.False(headers.ContainsKey(""host""));
+             Assert.False(headers.ContainsKey(""custom""));",This test was verifying the wrong thing.
+1697,"@@ -9,7 +9,7 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
+     util.updateBranding()
+   }
+
+-  util.buildMuon()
++  util.buildMuon('brave')
+ }
+
+ module.exports = build",pls pr a name change fro muon here too separately.
+1698,"@@ -198,7 +198,11 @@ func (opts *InitAppOpts) deployEnv() error {
+
+ 			return err
+ 		}
++		if err := opts.envStore.CreateEnvironment(&env); err != nil {
++			opts.spinner.Stop(""Error!"")
+
++			return err
++		}
+ 		opts.spinner.Stop(""Done!"")
+ 	}
+ 	return nil","nit: we can use `defer opts.spinner.Stop(""Error!"")` after l.180 to make it slightly neater"
+1699,"@@ -7367,6 +7367,7 @@ check_thread_vm_area(dcontext_t *dcontext, app_pc pc, app_pc tag, void **vmlist,
+             read_lock(&executable_areas->lock);
+         ok = lookup_addr(executable_areas, pc, &area);
+         if (ok && TEST(VM_DELAY_READONLY, area->vm_flags)) {
++            bool is_allocated_mem;
+             /* need to mark region read only for consistency
+              * need to upgrade to write lock, have to release lock first
+              * then recheck conditions after grabbing hotp + write lock */",This is declared in the wrong block
+1700,"@@ -57,6 +57,10 @@ func (ctx *ChannelContext) Cleanup(module string) {
+
+ // Send send msg to a module. Todo: do not stuck
+ func (ctx *ChannelContext) Send(module string, message model.Message) {
++	// check if msg is sync
++	if message.Header.Sync {
++		klog.Warningf(""Get a sync-msg when use beehive.Send(),msg.Header:{%v},msg.Route:{%v}"",message.Header,message.Router)
++	}
+ 	// avoid exception because of channel colsing
+ 	// TODO: need reconstruction
+ 	defer func() {","In fact it would be useful for debug, i prefer combine them into one debug level log."
+1701,"@@ -24,7 +24,9 @@ var alertDefine = {
+ 	crash: {
+ 		target: [
+ 			{ value: 'Total crashes', name: 'Total crashes' },
+-			{ value: 'New crash occurence', name: 'New crash occurence' }
++			{ value: 'New crash occurence', name: 'New crash occurence' },
++			{ value: 'None fatal crash per session', name: 'None fatal crash per session' },
++			{ value: 'Fatal crash per session', name: 'Fatal crash per session' },
+ 		],
+ 		condition: [
+ 			{ value: 'increased by at least', name: 'increased by at least' },","We would need to localize them eventually too, just FYI"
+1702,"@@ -70,7 +70,7 @@ void sequential_model::write_proto(lbann_data::Model* proto) {
+   model::write_proto(proto);
+   //Add layers
+   if (m_comm->am_world_master()) {
+-    proto->set_name(name());
++    proto->set_name(type());
+     for(size_t l = 0; l < m_layers.size(); l++) {
+       auto layer_proto = proto->add_layer();
+       m_layers[l]->write_proto(layer_proto);",It looks like the proto code needs to change the function name from set_name to set_type to be consistent.
+1703,"@@ -0,0 +1,16 @@
++// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package factory
++
++//go:generate go run ../../../scripts/generate/mockgen.go github.com/aws/amazon-ecs-agent/agent/ssm/factory SSMClientCreator mocks/factory_mocks.go",I think we can avoid using this pattern for this use case.
+1704,"@@ -25,7 +25,9 @@
+ #include <pthread.h>
+ #include <pwd.h>
+ #include <signal.h>
++#ifndef __ANDROID__
+ #include <spawn.h>
++#endif
+ #include <stdint.h>
+ #include <stdlib.h>
+ #include <string.h>",Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`.
+1705,"@@ -139,9 +139,10 @@ public class NodeStatus {
+     return slots.stream().anyMatch(slot -> slot.getSession() == null);
+   }
+
++  // Check if the Node's max session limit is not exceeded and has a free slot that supports the capability.
+   public boolean hasCapacity(Capabilities caps) {
+-    return slots.stream()
+-      .anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps));
++    return slots.stream().filter(slot -> slot.getSession() != null).count() < maxSessionCount
++           && slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps));
+   }
+
+   public int getMaxSessionCount() {",Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance.
+1706,"@@ -49,6 +49,19 @@ func (t RootType) String() string {
+ 	}
+ }
+
++func tlfTypeToPath(t tlf.Type) string {
++	switch t {
++	case tlf.Private:
++		return string(libkbfs.PrivatePathType)
++	case tlf.Public:
++		return string(libkbfs.PublicPathType)
++	case tlf.SingleTeam:
++		return string(libkbfs.SingleTeamPathType)
++	default:
++		return ""<unknown TLF type>""
++	}
++}
++
+ // Debug tag ID for an individual FS in keybase pages.
+ const ctxOpID = ""KBP""
+ ","Technically the ""right"" variables to use would be the ones in `libgit/autogit_node_wrappers.go"", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier."
+1707,"@@ -27,6 +27,18 @@ class CommunicartMailer < ActionMailer::Base
+     )
+   end
+
++  def notification_for_approver_removed(to_email, approval, alert_partial=nil)
++    @approval = approval
++    @alert_partial = alert_partial
++    proposal = approval.proposal
++    send_proposal_email(
++      from_email: user_email_with_name(proposal.requester),
++      to_email: to_email,
++      proposal: proposal,
++      template_name: 'proposal_notification_email'
++    )
++  end
++
+   def proposal_observer_email(to_email, proposal)
+     # TODO have the from_email be whomever triggered this notification
+     send_proposal_email(",Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`
+1708,"@@ -67,8 +67,9 @@ class SliderController extends AdminBaseController
+      */
+     public function listAction()
+     {
+-        $queryBuilder = $this->getDoctrine()->getManager()->createQueryBuilder();
+-        $queryBuilder
++        /** @var \Doctrine\ORM\EntityManager $em */
++        $em = $this->getDoctrine()->getManager();
++        $queryBuilder = $em->createQueryBuilder()
+             ->select('s')
+             ->from(SliderItem::class, 's')
+             ->where('s.domainId = :selectedDomainId')",i hope there is some extension in phpstan for this
+1709,"@@ -1025,6 +1025,7 @@ public class Dictionary {
+     assert morphSep > 0;
+     assert morphSep > flagSep;
+     int sep = flagSep < 0 ? morphSep : flagSep;
++    if (sep == 0) return 0;
+
+     CharSequence toWrite;
+     String beforeSep = line.substring(0, sep);","We don't store empty dictionary entries anymore: they bring no benefits, only trouble."
+1710,"@@ -625,6 +625,15 @@ class CppGenerator : public BaseGenerator {
+     return false;
+   }
+
++  bool VectorElementUserFacing(const Type& type) const {
++    // Normally, in non-Object-API, we use the non-user-facing type when
++    // emitting the Vector element type, however in the case of enums
++    // we want to avoid that when using scoped-enums.
++    return opts_.g_cpp_std >= cpp::CPP_STD_17 &&
++           opts_.scoped_enums &&
++           IsEnum(type);
++  }
++
+   void GenComment(const std::vector<std::string> &dc, const char *prefix = """") {
+     std::string text;
+     ::flatbuffers::GenComment(dc, &text, nullptr, prefix);",Optional: This function is C++ specific and could be declared as `static`.
+1711,"@@ -831,13 +831,15 @@ public class ZMSClient implements Closeable {
+      *
+      * @param domainName name of the domain
+      * @param members    include all members for group roles as well
++     * @param tagKey     query all roles with given tag name
++     * @param tagValue  query all roles with given tag key and value
+      * @return list of roles
+      * @throws ZMSClientException in case of failure
+      */
+-    public Roles getRoles(String domainName, Boolean members) {
++    public Roles getRoles(String domainName, Boolean members, String tagKey, String tagValue) {
+         updatePrincipal();
+         try {
+-            return client.getRoles(domainName, members);
++            return client.getRoles(domainName, members, tagKey, tagValue);
+         } catch (ResourceException ex) {
+             throw new ZMSClientException(ex.getCode(), ex.getData());
+         } catch (Exception ex) {","we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility"
+1712,"@@ -32,5 +32,12 @@ ADDITIONAL
+     def warn_deprecation(message)
+       warn message
+     end
++
++    # @private
++    #
++    # Used internally to send deprecation warnings to io
++    def warn(message)
++      RSpec.configuration.deprecation_io.puts(message)
++    end
+   end
+ end",I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`.
+1713,"@@ -0,0 +1,10 @@
++// Startup script for Phusion Passenger that uses next.js cli
++// Run `blitz build` before starting
++const path = require('path')
++
++const blitzPath = path.join(__dirname, 'node_modules', 'next', 'dist', 'bin', 'next');
++
++process.argv.length = 1;
++process.argv.push(blitzPath, 'start');
++
++require(blitzPath);",I think we should use a `blitz` bin instead
+1714,"@@ -101,7 +101,10 @@ class DictInterface(Interface):
+
+     @classmethod
+     def validate(cls, dataset):
+-        dimensions = dataset.dimensions(label='name')
++        if dataset._virtual_vdims:
++            dimensions = dataset.dimensions('key', label='name')
++        else:
++            dimensions = dataset.dimensions(label='name')
+         not_found = [d for d in dimensions if d not in dataset.data]
+         if not_found:
+             raise DataError('Following columns specified as dimensions '","Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?"
+1715,"@@ -155,6 +155,16 @@ func (s *VolumeServer) create(
+ 				err.Error())
+ 		}
+
++		if spec.IsPureVolume() {
++			id, err = s.driver(ctx).Create(locator, source, spec)
++			if err != nil {
++				return """", status.Errorf(
++					codes.Internal,
++					""Failed to create snapshot for Pure FA volume: %v"",
++					err.Error())
++			}
++			return id, nil
++		}
+ 		// Check ownership
+ 		// Snapshots just need read access
+ 		if !parent.IsPermitted(ctx, api.Ownership_Read) {",was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer
+1716,"@@ -1,3 +1,19 @@
++/*
++ * Copyright 2012 LinkedIn Corp.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License""); you may not
++ * use this file except in compliance with the License. You may obtain a copy of
++ * the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS, WITHOUT
++ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
++ * License for the specific language governing permissions and limitations under
++ * the License.
++ */
++
+ package azkaban.user;
+
+ /**",please update the year. it can be setup in intellij template.
+1717,"@@ -144,6 +144,16 @@ public class PreventTokenLoggingTests {
+         passSlf4j(""log.trace(message);"");
+     }
+
++    @Test
++    public void testSlf4jTraceNullMessageNoArgs() {
++        passSlf4j(""log.trace(null);"");
++    }
++
++    @Test
++    public void testSlf4jTraceNullArg() {
++        passSlf4j(""log.trace(message, arg1, null);"");
++    }
++
+     @Test
+     public void testSlf4jDebug() {
+         passSlf4j(""log.debug(message, arg1);"");",what's the use-case for this?
+1718,"@@ -1281,6 +1281,9 @@ class _Frame(object):
+             raise ValueError(""Grouper for '{}' not 1-dimensional"".format(type(by)))
+         if not len(by):
+             raise ValueError('No group keys passed!')
++        if not isinstance(as_index, bool):
++            raise TypeError('as_index must be an boolean; however, '
++                            'got [%s]' % type(as_index))
+         if isinstance(df_or_s, DataFrame):
+             df = df_or_s  # type: DataFrame
+             col_by = [_resolve_col(df, col_or_s) for col_or_s in by]",nit: `as_index must be an boolean` -> `as_index must be a boolean`
+1719,"@@ -26,5 +26,7 @@ interface BaseModuleInterface
+
+     public function postDeactivation(ConnectionInterface $con = null);
+
++    public function update($currentVersion, $newVersion, ConnectionInterface $con = null);
++
+     public function destroy(ConnectionInterface $con = null, $deleteModuleData = false);
+ }",What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :)
+1720,"@@ -34,6 +34,8 @@ function assertServerError (res) {
+ }
+
+ module.exports = class AwsS3Multipart extends Plugin {
++  static VERSION = require('../package.json').version
++
+   constructor (uppy, opts) {
+     super(uppy, opts)
+     this.type = 'uploader'","Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?"
+1721,"@@ -270,7 +270,7 @@ public class OAuthWebviewHelper {
+      * @return login url
+      */
+     protected String getLoginUrl() {
+-    	return SalesforceSDKManager.getInstance().getLoginServerManager().getSelectedLoginServer().url;
++    	return SalesforceSDKManager.getInstance().getLoginServerManager().getSelectedLoginServer().url.trim();
+     }
+
+     /**",Fix for URISyntaxException.
+1722,"@@ -121,6 +121,10 @@ mainLoop:
+ 				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no link index."")
+ 				continue
+ 			}
++			if routeUpd.Dst == nil {
++				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no destination"")
++				continue
++			}
+
+ 			idx := routeUpd.LinkIndex
+ 			oldUpds := updatesByIfaceIdx[idx]",Would be good to UT this case
+1723,"@@ -44,6 +44,8 @@ module.exports = {
+     'arrow-body-style': ['warn', 'as-needed'],
+     'no-param-reassign': ['error', { props: false }],
+     'import/prefer-default-export': 'off',
++    'import/no-extraneous-dependencies': 'off',
++    'import/no-unresolved': 'off',
+     'no-console': 'off',
+     'eol-last': ['error', 'always'],
+     'no-debugger': 'error',",Why we need to add this?
+1724,"@@ -1,6 +1,6 @@
+-require 'spec_helper'
++require 'rails_helper'
+
+-describe Api::V1::CompletionsController, '#show' do
++describe Api::V1::CompletionsController, '#show', type: :controller do
+   it 'returns a 401 when users are not authenticated' do
+     get :index
+     expect(response.code).to eq ""401""",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+1725,"@@ -2259,11 +2259,12 @@ type JSInfo struct {
+ 	Disabled bool            `json:""disabled,omitempty""`
+ 	Config   JetStreamConfig `json:""config,omitempty""`
+ 	JetStreamStats
+-	StreamCnt    int          `json:""total_streams,omitempty""`
+-	ConsumerCnt  int          `json:""total_consumers,omitempty""`
+-	MessageCnt   uint64       `json:""total_messages,omitempty""`
+-	MessageBytes uint64       `json:""total_message_bytes,omitempty""`
+-	Meta         *ClusterInfo `json:""meta_cluster,omitempty""`
++	APICalls  int64        `json:""current_api_calls""`
++	Streams   int          `json:""total_streams,omitempty""`
++	Consumers int          `json:""total_consumers,omitempty""`
++	Messages  uint64       `json:""total_messages,omitempty""`
++	Bytes     uint64       `json:""total_message_bytes,omitempty""`
++	Meta      *ClusterInfo `json:""meta_cluster,omitempty""`
+ 	// aggregate raft info
+ 	AccountDetails []*AccountDetail `json:""account_details,omitempty""`
+ }",This is ok to change since I believe that these were added just in main and not in public release.
+1726,"@@ -26,7 +26,7 @@ import (
+ )
+
+ func MakeAuditLogsOrDie(client *Client,
+-	auditlogsName, methodName, project, resourceName, serviceName, targetName string,
++	auditlogsName, methodName, project, resourceName, serviceName, targetName, pubsubServiceAccount string,
+ 	so ...kngcptesting.CloudAuditLogsSourceOption,
+ ) {
+ 	so = append(so, kngcptesting.WithCloudAuditLogsSourceServiceName(serviceName))","Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change."
+1727,"@@ -197,6 +197,16 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+             {
+                 _issueLogJsonWriter.CloseResults();
+
++                if (_run.ConfigurationNotifications != null)
++                {
++                    _issueLogJsonWriter.WriteConfigurationNotifications(_run.ConfigurationNotifications);
++                }
++
++                if (_run.ToolNotifications != null)
++                {
++                    _issueLogJsonWriter.WriteToolNotifications(_run.ToolNotifications);
++                }
++
+                 if (_run?.Invocation?.StartTime != new DateTime())
+                 {
+                     _run.Invocation.EndTime = DateTime.UtcNow;",_jaw drops_ I would have sworn I wrote those lines. Good catch.
+1728,"@@ -3,6 +3,7 @@
+
+ // Clean up after resolve / reject
+ function cleanup() {
++	axe._memoizedFns.forEach(fn => fn.clear());
+ 	axe._cache.clear();
+ 	axe._tree = undefined;
+ 	axe._selectorData = undefined;",This needs to be tested.
+1729,"@@ -1019,4 +1019,18 @@ describe Mongoid::Relations::Embedded::One do
+       end
+     end
+   end
++
++  context ""when parent validation of child is set to false"" do
++
++    let(:building) do
++      building = Building.create
++      building.building_address = BuildingAddress.new
++      building.save
++      building.reload
++    end
++
++    it ""parent successfully embeds an invalid child"" do
++      expect(building.building_address).to be_a(BuildingAddress)
++    end
++  end
+ end",I believe you're missing the comparison after 'be'
+1730,"@@ -94,12 +94,15 @@ func (s *KVStoreForTrie) Put(key []byte, value []byte) error {
+ func (s *KVStoreForTrie) Get(key []byte) ([]byte, error) {
+ 	trieKeystoreMtc.WithLabelValues(""get"").Inc()
+ 	v, err := s.cb.Get(s.bucket, key)
+-	if err != nil {
+-		if v, err = s.dao.Get(s.bucket, key); err != nil {
+-			return nil, errors.Wrapf(err, ""failed to get key %x"", key)
++	if errors.Cause(err) == ErrNotExist {
++		if v, err = s.dao.Get(s.bucket, key); errors.Cause(err) == ErrNotExist {
++			return nil, errors.Wrapf(ErrNotExist, ""failed to get key %x"", key)
+ 		}
+ 		// TODO: put it back to cache
+ 	}
++	if errors.Cause(err) == ErrAlreadyDeleted {
++		return nil, errors.Wrapf(ErrNotExist, ""failed to get key %x"", key)
++	}
+ 	return v, err
+ }
+ ",move 103~105 to in front of 97?
+1731,"@@ -2,6 +2,9 @@
+ package com.fsck.k9.helper;
+
+
++import java.io.File;
++import java.io.FileOutputStream;
++import java.io.IOException;
+ import java.util.ArrayList;
+ import java.util.List;
+ import java.util.regex.Matcher;",Lots of unnecessary imports left in this file.
+1732,"@@ -805,8 +805,9 @@ bool CoreChecks::ValidateDescriptorSetBindingData(const CMD_BUFFER_STATE *cb_nod
+         for (uint32_t i = index_range.start; i < index_range.end; ++i, ++array_idx) {
+             uint32_t index = i - index_range.start;
+             const auto *descriptor = descriptor_set->GetDescriptorFromGlobalIndex(i);
++            const auto descriptor_class = descriptor->GetClass();
+
+-            if (descriptor->GetClass() == DescriptorClass::InlineUniform) {
++            if (descriptor_class == DescriptorClass::InlineUniform) {
+                 // Can't validate the descriptor because it may not have been updated.
+                 continue;
+             } else if (!descriptor->updated) {",Does this actually produce different code?
+1733,"@@ -0,0 +1,7 @@
++if (node.getAttribute('onFocus') === 'this.blur()') {
++  return false;
++}
++if (node.getAttribute('onFocus').indexOf('this.blur()') > -1) {
++  return undefined;
++}
++return true;",This should account for whitespace. Simply putting `.trim()` on the attribute value should do.
+1734,"@@ -105,6 +105,9 @@ func newVXLANManager(
+ 		blackHoleProto = dpConfig.DeviceRouteProtocol
+ 	}
+
++	noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
++	bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
++
+ 	brt := routetable.New(
+ 		[]string{routetable.InterfaceNone},
+ 		4,",I don't think we need these. Simpler just to put `routetable.TargetType...` inline below.
+1735,"@@ -176,6 +176,11 @@ def get_port_from_custom_rules(method, path, data, headers):
+             # assume that this is an S3 POST request with form parameters or multipart form in the body
+             return config.PORT_S3
+
++    if stripped and '/' in stripped:
++        if method == 'PUT':
++            # assume that this is an S3 PUT bucket object request with URL path `/<bucket>/object`
++            return config.PORT_S3
++
+     # detect S3 requests sent from aws-cli using --no-sign-request option
+     if 'aws-cli/' in headers.get('User-Agent', ''):
+         return config.PORT_S3",Nested if statement. You can merge both statements nested together to create one
+1736,"@@ -45,6 +45,15 @@ public abstract class AbstractTest {
+         return System.getProperty(""java.version"").startsWith(""9."");
+     }
+
++    protected boolean isJava10() {
++        return System.getProperty(""java.version"").startsWith(""10."");
++    }
++
++    protected boolean isJavaVersionAbove9() {
++        String jdkVersion = System.getProperty(""java.version"");
++        return Integer.parseInt(jdkVersion.substring(0,jdkVersion.indexOf('.'))) >= 9;
++    }
++
+     protected boolean isJava8() {
+         return System.getProperty(""java.version"").startsWith(""1.8."");
+     }","Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer."
+1737,"@@ -31,7 +31,7 @@ TEST(Load, SSTLoad) {
+     EXPECT_EQ(ResultCode::SUCCESSED, engine->ingest(files));
+
+     std::string result;
+-    EXPECT_EQ(ResultCode::SUCCESSED, engine->get(""key"", result));
++    EXPECT_EQ(ResultCode::SUCCESSED, engine->get(""key"", &result));
+     EXPECT_EQ(result, ""value"");
+ }
+ }   // namespace kvstore","For your reference in future, I sugguest to use the `ASSERT_*` family."
+1738,"@@ -68,6 +68,7 @@
+ #include ""modify.h""
+ #include ""universe.h""
+ #include ""variable.h""
++#include ""fmt/format.h""
+
+ #include <cstring>
+ ","no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`."
+1739,"@@ -17,7 +17,10 @@ limitations under the License.
+ package v1alpha1
+
+ import (
++	""os""
++
+ 	""github.com/pkg/errors""
++	""k8s.io/apimachinery/pkg/types""
+
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/upgrade/v1alpha1""
+ 	cast ""github.com/openebs/maya/pkg/castemplate/v1alpha1""",Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`
+1740,"@@ -1059,8 +1059,14 @@ func (fbo *folderBranchOps) GetTLFCryptKeys(ctx context.Context,
+ func (fbo *folderBranchOps) GetOrCreateRootNode(
+ 	ctx context.Context, h *TlfHandle, branch BranchName) (
+ 	node Node, ei EntryInfo, err error) {
+-	err = errors.New(""GetOrCreateRootNode is not supported by "" +
+-		""folderBranchOps"")
++	err = errors.New(""GetOrCreateRootNode is not supported by folderBranchOps"")
++	return
++}
++
++func (fbo *folderBranchOps) GetRootNode(
++	ctx context.Context, h *TlfHandle, branch BranchName) (
++	node Node, ei EntryInfo, err error) {
++	err = errors.New(""GetRootNode is not supported by folderBranchOps"")
+ 	return
+ }
+ ",Might as well fix these bare returns by making them `return errors.New(...` directly.
+1741,"@@ -66,7 +66,7 @@ public class Benchmarks {
+           .sender(Address.ZERO)
+           .value(Wei.ZERO)
+           .apparentValue(Wei.ZERO)
+-          .code(new Code(Bytes.EMPTY))
++          .code(new Code(Bytes.EMPTY, org.hyperledger.besu.datatypes.Hash.EMPTY))
+           .depth(1)
+           .completer(__ -> {})
+           .address(Address.ZERO)",we can use import here
+1742,"@@ -35,8 +35,6 @@ func EchoBehavior(addr string) Result {
+ 		ctx,
+ 		// TODO get Service from client
+ 		&json.Request{
+-			Caller:    ""client"",
+-			Service:   ""yarpc-test"",
+ 			Procedure: ""echo"",
+ 			Body:      &server.EchoRequest{Token: token},
+ 			TTL:       3 * time.Second,",thx for removing these
+1743,"@@ -55,7 +55,11 @@ public final class XmlReportFailuresSupplier implements FailuresSupplier {
+     @Override
+     public List<Failure> getFailures() throws IOException {
+         File sourceReport = reporting.getReports().findByName(""xml"").getDestination();
+-        return XmlUtils.parseXml(reportHandler, new FileInputStream(sourceReport)).failures();
++        try {
++            return XmlUtils.parseXml(reportHandler, new FileInputStream(sourceReport)).failures();
++        } catch (Exception e) {
++            throw new RuntimeException(String.format(""Failed to parse failures XML: %s"", sourceReport), e);
++        }
+     }
+
+     @Override","I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was"
+1744,"@@ -542,6 +542,7 @@ func TestCreateInstanceValidateMachineType(t *testing.T) {
+ 		shouldErr bool
+ 	}{
+ 		{""good case"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/%s"", testProject, testZone, testMachineType), false},
++		{""good case2"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/%s"", testProject, testZone, testMachineType), false},
+ 		{""bad machine type case"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/bad-mt"", testProject, testZone), true},
+ 		{""bad project case"", fmt.Sprintf(""projects/p2/zones/%s/machineTypes/%s"", testZone, testMachineType), true},
+ 		{""bad zone case"", fmt.Sprintf(""projects/%s/zones/z2/machineTypes/%s"", testProject, testMachineType), true},","How is this different than ""good case""?"
+1745,"@@ -33,7 +33,7 @@ const (
+
+ // Client is wrapper of ECS client.
+ type Client interface {
+-	ServiceExists(ctx context.Context, clusterName string, services []string) (bool, error)
++	ServiceExists(ctx context.Context, clusterName string, services string) (bool, error)
+ 	CreateService(ctx context.Context, service types.Service) (*types.Service, error)
+ 	UpdateService(ctx context.Context, service types.Service) (*types.Service, error)
+ 	RegisterTaskDefinition(ctx context.Context, taskDefinition types.TaskDefinition) (*types.TaskDefinition, error)",the last parameter name should be `serviceName` as is in the implementation
+1746,"@@ -178,7 +178,7 @@ public class PrettyPrintVisitorTest {
+     @Test
+     public void multilineJavadocGetsFormatted() {
+         CompilationUnit cu = new CompilationUnit();
+-        cu.addClass(""X"").addMethod(""abc"").setJavadocComment("" line1\n   line2 *\n * line3"");
++        cu.addClass(""X"").addMethod(""abc"").setJavadocComment(""line1\n   line2 *\n * line3"");
+
+         assertEqualsNoEol(""public class X {\n"" +
+                 ""\n"" +","@ftomassetti - okay, this is a little meh."
+1747,"@@ -11,7 +11,8 @@ import (
+
+ // Portable analogs of some common system call errors.
+ var (
+-	ErrUnsupported = errors.New(""operation not supported"")
++	errUnsupported = errors.New(""operation not supported"")
++	notImplemented = errors.New(""os: not implemented"")
+ )
+
+ // Stdin, Stdout, and Stderr are open Files pointing to the standard input,","Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:"
+1748,"@@ -11,7 +11,7 @@ if (typeof define === 'function' && define.amd) {
+ 	});
+ }
+ if (typeof module === 'object' && module.exports && typeof axeFunction.toString === 'function') {
+-    axe.source = '(' + axeFunction.toString() + ')(this, this.document);';
++    axe.source = '(' + axeFunction.toString() + ')(typeof window === ""object"" ? window : this);';
+     module.exports = axe;
+ }
+ if (typeof window.getComputedStyle === 'function') {","hey, aren't we supposed to be passing in two parameters here?"
+1749,"@@ -18,6 +18,7 @@ bitcore.encoding.BufferWriter = require('./lib/encoding/bufferwriter');
+ bitcore.encoding.Varint = require('./lib/encoding/varint');
+
+ // main bitcoin library
++bitcore.Unit = require('./lib/unit');
+ bitcore.Address = require('./lib/address');
+ bitcore.BIP32 = require('./lib/bip32');
+ bitcore.Block = require('./lib/block');",please keep alphabetical ordering :)
+1750,"@@ -43,11 +43,14 @@ import org.openqa.selenium.remote.internal.CircularOutputStream;
+
+ import java.io.File;
+ import java.io.IOException;
++import java.io.InputStream;
+ import java.io.InputStreamReader;
++import java.io.OutputStream;
+ import java.io.PrintWriter;
+ import java.io.Reader;
+ import java.net.ConnectException;
+ import java.net.Socket;
++import java.nio.charset.StandardCharsets;
+ import java.util.List;
+ import java.util.Map;
+ ",Selenium must compile against Java 6. Revert this line.
+1751,"@@ -147,7 +147,7 @@ func (r *Reconciler) reconcilePullSubscription(ctx context.Context, source *v1al
+ 			logging.FromContext(ctx).Desugar().Error(""Failed to get PullSubscription"", zap.Error(err))
+ 			return nil, fmt.Errorf(""failed to get PullSubscription: %w"", err)
+ 		}
+-		newPS := resources.MakePullSubscription(source.Namespace, source.Name, &source.Spec.PubSubSpec, source, source.Spec.Topic, r.receiveAdapterName, resourceGroup)
++		newPS := resources.MakePullSubscription(source.Namespace, source.Name, &source.Spec.PubSubSpec, source, source.Spec.Topic, r.receiveAdapterName, """", resourceGroup)
+ 		logging.FromContext(ctx).Desugar().Debug(""Creating PullSubscription"", zap.Any(""ps"", newPS))
+ 		ps, err = r.RunClientSet.PubsubV1alpha1().PullSubscriptions(newPS.Namespace).Create(newPS)
+ 		if err != nil {","what is that `""""`, the adapterType? can you add `"""" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference.."
+1752,"@@ -2003,7 +2003,8 @@ Document.prototype.$__dirty = function() {
+   // gh-2558: if we had to set a default and the value is not undefined,
+   // we have to save as well
+   all = all.concat(this.$__.activePaths.map('default', function(path) {
+-    if (path === '_id' || !_this.getValue(path)) {
++    var pType = typeof _this.getValue(path);
++    if (path === '_id' || (!_this.getValue(path) && pType !== 'boolean')) {
+       return;
+     }
+     return {","This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?"
+1753,"@@ -0,0 +1,13 @@
++/**
++ * Note:
++ * Check
++ * - if element is focusable
++ * - if element is in focus order via `tabindex`
++ */
++const isFocusable = virtualNode.isFocusable;
++
++let tabIndex = virtualNode.actualNode.getAttribute('tabindex');
++tabIndex =
++	tabIndex && !isNaN(parseInt(tabIndex, 10)) ? parseInt(tabIndex) : null;
++
++return tabIndex ? isFocusable && tabIndex >= 0 : isFocusable;",Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary.
+1754,"@@ -241,6 +241,7 @@ describe ""BoltServer::TransportApp"" do
+                                    password: target[:password],
+                                    port: target[:port]
+                                  })
++      body[:target]['host-key-check'] = false if transport == 'ssh'
+
+       post(path, JSON.generate(body), 'CONTENT_TYPE' => 'text/json')
+     end","This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged."
+1755,"@@ -25,7 +25,7 @@ class BatchActionFormModel
+     /**
+      * @Assert\Type(""boolean"")
+      */
+-    public bool $autoEndOnErrors = true;
++    public ?bool $autoEndOnErrors = true;
+
+     /**
+      * @Assert\Valid()",Why is that? Should be redundant as the default value exists.
+1756,"@@ -252,6 +252,7 @@ type Config struct {
+ 	DebugSimulateCalcGraphHangAfter time.Duration `config:""seconds;0""`
+ 	DebugSimulateDataplaneHangAfter time.Duration `config:""seconds;0""`
+ 	DebugPanicAfter                 time.Duration `config:""seconds;0""`
++	DebugSimulateDataRace           bool          `config:""bool;false""`
+
+ 	// Configure where Felix gets its routing information.
+ 	// - workloadIPs: use workload endpoints to construct routes.","Are all fields beginning with ""Debug"" automatically `;local` ? (I guess so, but just checking.)"
+1757,"@@ -115,6 +115,13 @@ public interface Table {
+    */
+   UpdateSchema updateSchema();
+
++  /**
++   * Create a new {@link UpdateNameMapping} to update name mapping of this table and commit the change.
++   *
++   * @return a new {@link UpdateNameMapping}
++   */
++  UpdateNameMapping updateNameMapping();
++
+   /**
+    * Create a new {@link UpdateProperties} to update table properties and commit the changes.
+    *","While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to."
+1758,"@@ -540,7 +540,7 @@ static Int64 SikGcInterval = -1;
+ void SsmpGlobals::work()
+ {
+
+-  getIpcEnv()->getAllConnections()->waitOnAll(getStatsMergeTimeout());
++  getIpcEnv()->getAllConnections()->waitOnAll(0);
+   finishPendingSscpMessages();
+
+   // Cleanup IpcEnvironment","We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0."
+1759,"@@ -252,6 +252,13 @@ func Compile(pkgName string, machine llvm.TargetMachine, config *compileopts.Con
+
+ 	c.loadASTComments(lprogram)
+
++	// Forcibly preload special types.
++	runtimePkg := c.ir.Program.ImportedPackage(""runtime"")
++	c.getLLVMType(runtimePkg.Type(""_interface"").Type())
++	c.getLLVMType(runtimePkg.Type(""_string"").Type())
++	c.getLLVMType(runtimePkg.Type(""hashmap"").Type())
++	c.getLLVMType(runtimePkg.Type(""channel"").Type())
++
+ 	// Declare runtime types.
+ 	// TODO: lazily create runtime types in getLLVMRuntimeType when they are
+ 	// needed. Eventually this will be required anyway, when packages are",Is this really necessary? I would expect these types to be included with the loop below.
+1760,"@@ -41,8 +41,17 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+
+             traceId.CopyTo(bytes);
+
+-            this.High = BitConverter.ToInt64(bytes, 0);
+-            this.Low = BitConverter.ToInt64(bytes, 8);
++            if (BitConverter.IsLittleEndian)
++            {
++                Array.Reverse(bytes);
++                this.High = BitConverter.ToInt64(bytes, 8);
++                this.Low = BitConverter.ToInt64(bytes, 0);
++            }
++            else
++            {
++                this.High = BitConverter.ToInt64(bytes, 0);
++                this.Low = BitConverter.ToInt64(bytes, 8);
++            }
+         }
+
+         public long High { get; set; }",You could do span<byte> and it's magic of typecast to int for better efficiency
+1761,"@@ -87,8 +87,9 @@ Object.keys(rulesGroupByDocumentFragment).forEach(key => {
+ 				return;
+ 			}
+
+-			// check if transform style exists
+-			const transformStyleValue = cssRule.style.transform || false;
++			// check if transform style exists (don't forget vendor prefixes)
++			const transformStyleValue =
++				cssRule.style.transform || cssRule.style.webkitTransform || false;
+ 			// transformStyleValue -> is the value applied to property
+ 			// eg: ""rotate(-90deg)""
+ 			if (!transformStyleValue) {","Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?"
+1762,"@@ -241,15 +241,10 @@ namespace MvvmCross.Droid.Support.V7.RecyclerView
+
+         protected virtual void OnItemsSourceCollectionChanged(object sender, NotifyCollectionChangedEventArgs e)
+         {
+-            if (Looper.MainLooper == Looper.MyLooper())
+-            {
+-                NotifyDataSetChanged(e);
+-            }
+-            else
+-            {
+-                var h = new Handler(Looper.MainLooper);
+-                h.Post(() => NotifyDataSetChanged(e));
+-            }
++            if (Looper.MainLooper != Looper.MyLooper())
++                MvxBindingLog.Error(""All collection changes "");
++
++            NotifyDataSetChanged(e);
+         }
+
+         public virtual void NotifyDataSetChanged(NotifyCollectionChangedEventArgs e)",Is there something missing from the message here?
+1763,"@@ -48,3 +48,14 @@ from luigi import event
+ from luigi.event import Event
+
+ from .tools import range  # just makes the tool classes available from command line
++
++
++__all__ = [
++    'task', 'Task', 'Config', 'ExternalTask', 'WrapperTask', 'namespace',
++    'target', 'Target', 'File', 'LocalTarget', 'rpc', 'RemoteScheduler',
++    'RPCError', 'parameter', 'Parameter', 'DateParameter', 'MonthParameter',
++    'YearParameter', 'DateHourParameter', 'DateMinuteParameter', 'range',
++    'DateIntervalParameter', 'TimeDeltaParameter', 'IntParameter',
++    'FloatParameter', 'BooleanParameter', 'BoolParameter', 'TaskParameter',
++    'configuration', 'interface', 'file', 'run', 'build', 'event', 'Event'
++]","Hmm, what does this syntax mean?"
+1764,"@@ -98,7 +98,12 @@ func (r *nDCActivityReplicatorImpl) SyncActivity(
+ 		RunId:      request.RunId,
+ 	}
+
+-	context, release, err := r.historyCache.getOrCreateWorkflowExecution(ctx, namespaceID, execution)
++	context, release, err := r.historyCache.getOrCreateWorkflowExecution(
++		ctx,
++		namespaceID,
++		execution,
++		callerTypeAPI,
++	)
+ 	if err != nil {
+ 		// for get workflow execution context, with valid run id
+ 		// err will not be of type EntityNotExistsError",should this be callerTypeTask?
+1765,"@@ -56,6 +56,10 @@ class PlanPolicy < ApplicationPolicy
+     @plan.administerable_by?(@user.id)
+   end
+
++  def set_test?
++    @plan.administerable_by?(@user.id)
++  end
++
+ # TODO: These routes are no lonmger used
+ =begin
+   def section_answers?","Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details"
+1766,"@@ -47,8 +47,7 @@ namespace Nethermind.Blockchain
+         private readonly LruCache<Keccak, BlockHeader> _headerCache = new LruCache<Keccak, BlockHeader>(CacheSize);
+         private readonly LruCache<long, ChainLevelInfo> _blockInfoCache = new LruCache<long, ChainLevelInfo>(CacheSize);
+
+-        private const int MaxQueueSize = 10_000_000;
+-
++        private const int BestKnownSearchLimit = 256_000_000;
+         public const int DbLoadBatchSize = 4000;
+
+         private long _currentDbLoadBatchEnd;","Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?"
+1767,"@@ -66,6 +66,7 @@ public class HiveTableBaseTest extends HiveMetastoreTest {
+     tableLocation.getFileSystem(hiveConf).delete(tableLocation, true);
+     catalog.dropTable(TABLE_IDENTIFIER, false /* metadata only, location was already deleted */);
+   }
++
+   private static String getTableBasePath(String tableName) {
+     String databasePath = metastore.getDatabasePath(DB_NAME);
+     return Paths.get(databasePath, tableName).toAbsolutePath().toString();",Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?
+1768,"@@ -66,7 +66,7 @@ function HelpMenu( { children } ) {
+
+ 	const handleMenuSelected = useCallback( () => {
+ 		toggleMenu( false );
+-	} );
++	}, [] );
+
+ 	return (
+ 		<div className=""googlesitekit-dropdown-menu googlesitekit-dropdown-menu__icon-menu googlesitekit-help-menu mdc-menu-surface--anchor"">","There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now"
+1769,"@@ -33,6 +33,7 @@ const (
+ 	BalanceRecord     HashID = ""BR""
+ 	Credential        HashID = ""CR""
+ 	Genesis           HashID = ""GE""
++	Logic             HashID = ""LO""
+ 	Message           HashID = ""MX""
+ 	NetPrioResponse   HashID = ""NPR""
+ 	OneTimeSigKey1    HashID = ""OT1""","This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses."
+1770,"@@ -0,0 +1,8 @@
++from django.test import TestCase
++from graphite.worker_pool.pool import stop_pool
++
++
++class BaseTestCase(TestCase):
++
++  def tearDown(self):
++    stop_pool()","nit: you could have named it just ""TestCase"" (if django's TestCase was imported differently)"
+1771,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.
+1772,"@@ -42,7 +42,6 @@ std::string lldb_private::formatters::swift::SwiftOptionalSummaryProvider::
+ // retrieve the value of the Some case..
+ static PointerOrSP
+ ExtractSomeIfAny(ValueObject *optional,
+-                 lldb::DynamicValueType dynamic_value = lldb::eNoDynamicValues,
+                  bool synthetic_value = false) {
+   if (!optional)
+     return nullptr;","All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?"
+1773,"@@ -109,7 +109,8 @@ def main():
+     logger.info('Environment info:\n' + dash_line + env_info + '\n' +
+                 dash_line)
+     meta['env_info'] = env_info
+-
++    meta['config_dict'] = dict(cfg)
++    meta['config_file'] = args.config
+     # log some basic info
+     logger.info(f'Distributed training: {distributed}')
+     logger.info(f'Config:\n{cfg.pretty_text}')",Better to use the absolute path.
+1774,"@@ -45,8 +45,8 @@ const (
+ 	// VoucherInterval defines how many block pass before creating a new voucher
+ 	VoucherInterval = 1000
+
+-	// ChannelExpiryBuffer defines how long the channel remains open past the last voucher
+-	ChannelExpiryBuffer = 2000
++	// ChannelExpiryInterval defines how long the channel remains open past the last voucher
++	ChannelExpiryInterval = 2000
+
+ 	// CreateChannelGasPrice is the gas price of the message used to create the payment channel
+ 	CreateChannelGasPrice = 0","this is 16 hours, is that enough?"
+1775,"@@ -0,0 +1,16 @@
++package tracing
++
++import (
++	""context""
++
++	""go.opencensus.io/trace""
++)
++
++// AddErrorEndSpan will end `span` and adds `err` to `span` iff err is not nil.
++// This is a helper method to cut down on boiler plate.
++func AddErrorEndSpan(ctx context.Context, span *trace.Span, err *error) {
++	if *err != nil {
++		span.AddAttributes(trace.StringAttribute(""error"", (*err).Error()))
++	}
++	span.End()
++}",  removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes.
+1776,"@@ -71,9 +71,10 @@ func (b *EthAPIBackend) GetEthContext() (uint64, uint64) {
+ 	return bn, ts
+ }
+
+-func (b *EthAPIBackend) GetRollupContext() (uint64, uint64) {
++func (b *EthAPIBackend) GetRollupContext() (uint64, uint64, uint64) {
+ 	i := uint64(0)
+ 	q := uint64(0)
++	v := uint64(0)
+ 	index := b.eth.syncService.GetLatestIndex()
+ 	if index != nil {
+ 		i = *index",Can you replace these single letter variables with full names?
+1777,"@@ -1,13 +1,16 @@
+ // Copyright (c) .NET Foundation. All rights reserved.
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
++using System;
+ using System.IO;
++using Microsoft.AspNet.Http.Features;
+
+ namespace Microsoft.AspNet.Server.Kestrel.Filter
+ {
+     public class ConnectionFilterContext
+     {
+         public ServerAddress Address { get; set; }
+-        public Stream Connection { get; set;  }
++        public Stream Connection { get; set; }
++        public Action<IFeatureCollection> PrepareRequest { get; set; }
+     }
+ }","At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context."
+1778,"@@ -679,9 +679,9 @@ class Upgrade
+         // Eliminate obsolete config override settings:
+         unset($newConfig['Extra_Config']);
+
+-        // Update generator if it is default value:
++        // Update generator if it contains a version number:
+         if (isset($newConfig['Site']['generator'])
+-            && $newConfig['Site']['generator'] == 'VuFind ' . $this->from
++            && preg_match('/^VuFind (\d+\.?)+$/', $newConfig['Site']['generator'])
+         ) {
+             $newConfig['Site']['generator'] = 'VuFind ' . $this->to;
+         }","Would it be too greedy to preg_replace `VuFind (\d+\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is."
+1779,"@@ -91,7 +91,7 @@ public abstract class ManagedResourceStorage {
+       zkClient = ((ZkSolrResourceLoader)resourceLoader).getZkController().getZkClient();
+       try {
+         zkConfigName = ((ZkSolrResourceLoader)resourceLoader).getZkController().
+-            getZkStateReader().readConfigName(collection);
++            getZkStateReader().getClusterState().getCollection(collection).getConfigName();
+       } catch (Exception e) {
+         log.error(""Failed to get config name due to"", e);
+         throw new SolrException(ErrorCode.SERVER_ERROR,","BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state."
+1780,"@@ -191,7 +191,10 @@ public class FindFiles {
+       Snapshot snapshot = snapshotId != null ?
+           ops.current().snapshot(snapshotId) : ops.current().currentSnapshot();
+
+-      CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, snapshot.manifests())
++      // snapshot could be null when the table just gets created
++      Iterable<ManifestFile> manifests = (snapshot != null) ? snapshot.manifests() : CloseableIterable.empty();
++
++      CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, manifests)
+           .filterData(rowFilter)
+           .filterFiles(fileFilter)
+           .filterPartitions(partitionFilter)","If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable."
+1781,"@@ -0,0 +1,11 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.codestyle;
++
++import net.sourceforge.pmd.testframework.PmdRuleTst;
++
++public class ArrayInitializationVerbosenessRuleTest extends PmdRuleTst {
++  // no additional unit tests
++}",this class should be named `ArrayInitializationVerbosenessTest` to work
+1782,"@@ -338,9 +338,17 @@ module Bolt
+
+     private def update_logs(logs)
+       logs.each_with_object({}) do |(key, val), acc|
+-        next unless val.is_a?(Hash)
++        # Remove any disabled logs
++        next if val == 'disable'
+
+         name = normalize_log(key)
++
++        # But otherwise it has to be a Hash
++        unless val.is_a?(Hash)
++          raise Bolt::ValidationError,
++                ""config of log #{name} must be a Hash, received #{val.class} #{val.inspect}""
++        end
++
+         acc[name] = val.slice('append', 'level')
+                        .transform_keys(&:to_sym)
+ ",Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`.
+1783,"@@ -44,6 +44,7 @@ func TestAddrsNewAndList(t *testing.T) {
+
+ func TestWalletBalance(t *testing.T) {
+ 	tf.IntegrationTest(t)
++	t.Skip(""not working"")
+ 	ctx := context.Background()
+
+ 	builder := test.NewNodeBuilder(t)",It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip.
+1784,"@@ -85,9 +85,13 @@ export default function LegacyAdSenseDashboardWidgetOverview( props ) {
+ 			}
+ 		}
+ 	}, [
+-		currentDataLoaded && previousDataLoaded, // All reports are fetched.
+-		!! currentError || !! previousError, // Whether there is an error or not.
+-		JSON.stringify( currentRangeData ),
++		currentDataLoaded,
++		currentError,
++		currentRangeData,
++		handleDataError,
++		handleDataSuccess,
++		previousDataLoaded,
++		previousError,
+ 	] );
+
+ 	if ( ! currentDataLoaded || ! previousDataLoaded ) {",As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that)
+1785,"@@ -47,12 +47,13 @@
+
+ namespace lbann {
+
+-lbann_comm* initialize(int& argc, char**& argv, int seed) {
++world_comm_ptr initialize(int& argc, char**& argv, int seed) {
+   // Initialize Elemental.
+   El::Initialize(argc, argv);
+   // Create a new comm object.
+   // Initial creation with every process in one model.
+-  auto* comm = new lbann_comm(0);
++  auto comm = world_comm_ptr{new lbann_comm(0), &lbann::finalize };
++
+ #if defined(LBANN_TOPO_AWARE)
+   // Determine the number of NUMA nodes present.
+   hwloc_topology_t topo;",Should we be doing this with `make_unique` or something?
+1786,"@@ -35,9 +35,11 @@ class ProposalMailer < ApplicationMailer
+     )
+   end
+
+-  def proposal_updated_no_action_required(user, proposal, modifier = nil)
++  def proposal_updated_no_action_required(user = User.last, proposal = Proposal.last, modifier = nil)
+     @proposal = proposal.decorate
+     @modifier = modifier || NullUser.new
++    # Example ideal data to consume
++    @changes = [{verb: 'modified', result: 'this to that'},{verb: 'added', result: 'that'},{verb: 'modified', result: 'this to that'}]
+     assign_threading_headers(@proposal)
+
+     mail(","we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier."
+1787,"@@ -14,9 +14,10 @@ import (
+ 	""strconv""
+ 	""strings""
+
++	""go/parser""
++
+ 	""github.com/aykevl/go-llvm""
+ 	""github.com/aykevl/tinygo/ir""
+-	""go/parser""
+ 	""golang.org/x/tools/go/loader""
+ 	""golang.org/x/tools/go/ssa""
+ )","Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated."
+1788,"@@ -106,7 +106,7 @@ import javax.lang.model.element.Name;
+ @AutoService(BugChecker.class)
+ @BugPattern(
+         name = ""StrictUnusedVariable"",
+-        altNames = {""unused"", ""StrictUnusedVariable""},
++        altNames = {""unused"", ""UnusedVariable""},
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+         summary = ""Unused."",",It's unnecessary to duplicate the `name`.
+1789,"@@ -68,7 +68,7 @@ final class MediaType extends AbstractType implements LoggerAwareInterface
+         $builder->addModelTransformer($dataTransformer);
+
+         $builder->addEventListener(FormEvents::SUBMIT, static function (FormEvent $event): void {
+-            if ($event->getForm()->has('unlink') && null !== $event->getForm()->get('unlink')->getData()) {
++            if ($event->getForm()->has('unlink') && true === $event->getForm()->get('unlink')->getData()) {
+                 $event->setData(null);
+             }
+         });",this was a mistake when adding phpstan strict plugin
+1790,"@@ -197,6 +197,14 @@ export function diffChildren(
+
+ 						newParentVNode._nextDom = oldDom;
+ 					}
++				} else if (
++					oldDom &&
++					oldVNode._dom == oldDom &&
++					oldDom.parentNode != parentDom
++				) {
++					// The above condition is handle null placeholders. See test in placeholder.test.js:
++					// `efficiently replace null placeholders in parent rerenders`
++					oldDom = getDomSibling(oldVNode);
+ 				}
+ 			}
+ ",Nit: I think it should be `to handle` here.
+1791,"@@ -2810,7 +2810,7 @@ public class MessagingController implements Runnable {
+
+                     LocalMessage message = localFolder.getMessage(uid);
+                     if (message == null
+-                    || message.getId() == 0) {
++                            || message.getId() == 0) {
+                         throw new IllegalArgumentException(""Message not found: folder="" + folder + "", uid="" + uid);
+                     }
+                     // IMAP search results will usually need to be downloaded before viewing.",Please don't make unrelated changes or let your tools make unrelated changes.
+1792,"@@ -18,7 +18,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ )
+
+-var numAccounts int
++var numAccounts uint
+
+ // accountCreateCmd represents the account create command
+ var accountCreateCmd = &cobra.Command{",`numAccounts` is a global variable (from `gochecknoglobals`)
+1793,"@@ -855,6 +855,9 @@ class PluginManager
+         if ($pluginPath = self::instance()->getPluginPath($id)) {
+             File::deleteDirectory($pluginPath);
+         }
++
++        // actually remove the plugin from our internal container
++        unset($this->plugins[$id]);
+     }
+
+     /**",Is the ID correctly normalized at this point?
+1794,"@@ -0,0 +1,11 @@
++package commands
++
++import (
++	""context""
++
++	""github.com/ledgerwatch/erigon/p2p""
++)
++
++func (api *ErigonImpl) NodeInfo(ctx context.Context) ([]p2p.NodeInfo, error) {
++	return api.ethBackend.NodeInfo(ctx, 0)
++}","if 0 is a special constant meaning ""no limit"" let's make it a constant and name it correctly :)"
+1795,"@@ -140,8 +140,8 @@ func run(ctx context.Context) {
+ 		} else {
+ 			setOsConfig(resp)
+ 			setPatchPolicies(resp.PatchPolicies)
+-			runInventory()
+ 		}
++		runInventory()
+
+ 		select {
+ 		case <-ticker.C:",Curious about the reason behind this change
+1796,"@@ -18,7 +18,7 @@ func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) (err error) {
+ 	// Put block in storage wired to an exchange so this node and other
+ 	// nodes can fetch it.
+ 	log.Debugf(""putting block in bitswap exchange: %s"", b.Cid().String())
+-	blkCid, err := node.OnlineStore.Put(ctx, b)
++	blkCid, err := node.cborStore.Put(ctx, b)
+ 	if err != nil {
+ 		return errors.Wrap(err, ""could not add new block to online storage"")
+ 	}","wait, i thought the cborstore was for state tree?"
+1797,"@@ -1101,7 +1101,19 @@ class Package(object):
+
+         self._fix_sha256()
+         pkg = self._materialize(dest)
++
++        def physical_key_is_temp_file(pk):
++            if not file_is_local(pk):
++                return False
++            return pathlib.Path(parse_file_url(urlparse(pk))).parent == APP_DIR_TEMPFILE_DIR
++        temp_file_logical_keys = [lk for lk, entry in self.walk() if physical_key_is_temp_file(entry.physical_keys[0])]
++
+         self._delete_temporary_files()  # Now that data has been pushed, delete tmp files created by pkg.set('KEY', obj)
++
++        # Update old package to point to the materialized location of the file since the tempfile no longest exists
++        for lk in temp_file_logical_keys:
++            self.set(lk, pkg[lk])
++
+         pkg.build(name, registry=registry, message=message)
+         return pkg
+ ","This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?"
+1798,"@@ -25,6 +25,11 @@ import io.swagger.converter.ModelConverters;
+ import io.swagger.models.properties.Property;
+
+ public class DefaultResponseTypeProcessor implements ResponseTypeProcessor {
++  @Override
++  public Class<?> getResponseType() {
++    // not care for this.
++    return null;
++  }
+
+   @Override
+   public Property process(OperationGenerator operationGenerator) {",How about name it with NullResponseTypeProcessor
+1799,"@@ -580,6 +580,8 @@ Dataset* DatasetLoader::CostructFromSampleData(double** sample_values,
+       BinType bin_type = BinType::NumericalBin;
+       if (categorical_features_.count(i)) {
+         bin_type = BinType::CategoricalBin;
++        bool feat_is_unconstrained = ((config_.monotone_constraints.size() == 0) || (config_.monotone_constraints[i] == 0));
++        CHECK(feat_is_unconstrained);
+       }
+       bin_mappers[i].reset(new BinMapper());
+       if (config_.max_bin_by_feature.empty()) {",Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly.
+1800,"@@ -575,7 +575,7 @@ class decimate(ElementOperation):
+        The x_range as a tuple of min and max y-value. Auto-ranges
+        if set to None."""""")
+
+-    def _process(self, element, key=None):
++    def _apply(self, element, key=None):
+         if not isinstance(element, Dataset):
+             raise ValueError(""Cannot downsample non-Dataset types."")
+         if element.interface not in column_interfaces:","Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays."
+1801,"@@ -131,6 +131,9 @@ const (
+
+ 	// MachineNameTagKey is the key for machine name.
+ 	MachineNameTagKey = ""MachineName""
++
++	// NodeRoleTagValue describes the value for the node role.
++	NodeRoleTagValue = ""node""
+ )
+
+ // ClusterTagKey generates the key for resources associated with a cluster.",Let's use this constant when ASG is created as well (currently hardcoded).
+1802,"@@ -152,6 +152,10 @@ CREATE_PACKAGE_HASHES = textwrap.dedent(f""""""\
+     FROM named_packages
+ """""")
+
++# All GROUP BY statements are supposed to be:
++# - in the order from most unique values to least unique
++# - integers rather than strings
++
+ OBJECT_ACCESS_COUNTS = textwrap.dedent(""""""\
+     SELECT
+         eventname,",Oh is `bucket` actually higher cardinality than `eventname`?
+1803,"@@ -33,6 +33,7 @@ import sip
+ from PyQt5.QtCore import QUrl
+ # so it's available for :debug-pyeval
+ from PyQt5.QtWidgets import QApplication  # pylint: disable=unused-import
++from PyQt5.QtWebEngineWidgets import QWebEngineProfile  # pylint: disable=unused-import
+
+ from qutebrowser.browser import qutescheme
+ from qutebrowser.utils import log, objreg, usertypes, message, debug, utils",You can't rely on QtWebEngine being available - but why do you need to import this here at all?
+1804,"@@ -234,6 +234,12 @@ setup(
+ 		],
+ 		""packages"": [
+ 			""NVDAObjects"",
++			# As of py2exe 0.11.0.0 if the forcibly included package contains subpackages
++			# they need to  be listed explicitly (py2exe issue 113).
++			""NVDAObjects.IAccessible"",
++			""NVDAObjects.JAB"",
++			""NVDAObjects.UIA"",
++			""NVDAObjects.window"",
+ 			""virtualBuffers"",
+ 			""appModules"",
+ 			""comInterfaces"",",How did you determine these - and how can we be confident that nothing is missing?
+1805,"@@ -0,0 +1,3 @@
++<h2>Workshops</h2>
++<h2>Videos</h2>
++<h2>Books</h2>",What is this page going to do that is different than the products index we already have?
+1806,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.
+1807,"@@ -3,9 +3,10 @@ module Travis
+     class Script
+       module Addons
+         class Deploy
+-          VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node]
++          VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node, :go]
+           USE_RUBY           = '1.9.3'
+-          attr_accessor :script, :config, :allow_failure
++          HASH_CONFIG_KEYS = [:s3_options]
++          attr_accessor :script, :hash_config, :config, :allow_failure
+
+           def initialize(script, config)
+             @silent = false",Is this intended to be here? Seems it belongs to a different PR.
+1808,"@@ -20,7 +20,7 @@ namespace Xunit.ConsoleClient
+         {
+             try
+             {
+-                SetConsoleForegroundColor(ConsoleColor.White);
++                Console.ForegroundColor = ConsoleColor.White;
+ #if !NETCORE
+                 var netVersion = Environment.Version;
+ #else","These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays"
+1809,"@@ -58,7 +58,11 @@ logger = logging.getLogger('luigi-interface')
+
+ try:
+     import boto3
+-    client = boto3.client('ecs')
++    try:
++        import botocore.exceptions
++        client = boto3.client('ecs')
++    except botocore.exceptions.NoRegionError:
++        logger.warning('Your AWS config is missing Region information, ECSTask requires a working config.')
+ except ImportError:
+     logger.warning('boto3 is not installed. ECSTasks require boto3')
+ ",Umm... this isn't relevant to this PR
+1810,"@@ -24,6 +24,7 @@ namespace Xunit
+         Netcoreapp = 0x1000,
+         Uap = 0x2000,
+         UapAot = 0x4000,
+-        NetcoreCoreRT = 0x8000
++        NetcoreCoreRT = 0x8000,
++        All = ~0
+     }
+ }",While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0.
+1811,"@@ -0,0 +1,7 @@
++// Copyright 2021 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++// Package main provides the bee binary viper-cobra
++// command definitions.
++package main","Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands."
+1812,"@@ -7,15 +7,11 @@ const Router = Ember.Router.extend({
+ });
+
+ Router.map(function() {
+-  this.route('admin', {
+-    resetNamespace: true
+-  }, function() {
++  this.route('admin', function() {
+     this.route('address');
+     this.route('loaddb');
+     this.route('lookup', { path: '/' });
+-    this.route('users', {
+-      resetNamespace: true
+-    }, function() {
++    this.route('users', function() {
+       this.route('edit', { path: '/edit/:user_id' });
+     });
+     this.route('roles');","This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`"
+1813,"@@ -150,4 +150,19 @@ return [
+
+     'secure' => false,
+
++    /*
++    |--------------------------------------------------------------------------
++    | Same-Site Cookies
++    |--------------------------------------------------------------------------
++    |
++    | This option determines how your cookies behave when cross-site requests
++    | take place, and can be used to mitigate CSRF attacks. By default, we
++    | do not enable this as other CSRF protection services are in place.
++    |
++    | Supported: ""lax"", ""strict""
++    |
++    */
++
++    'same_site' => null,
++
+ ];",Could you provide more information on what exactly each of those three options do?
+1814,"@@ -1,10 +1,12 @@
+ using System.Collections.Generic;
++using System;
+
+ namespace ScenarioMeasurement
+ {
+     public class LinuxTraceSession : ITraceSession
+     {
+-        public string TraceFilePath { get { return perfCollect?.TraceFilePath; } }
++        public string TraceFilePath {
++            get { return perfCollect?.TraceFilePath;} }
+         private PerfCollect perfCollect;
+         private Dictionary<TraceSessionManager.KernelKeyword, PerfCollect.KernelKeyword> kernelKeywords;
+         private Dictionary<TraceSessionManager.ClrKeyword, PerfCollect.ClrKeyword> clrKeywords;",Why this line break?
+1815,"@@ -27,6 +27,7 @@ import (
+ 	admissionregistrationv1 ""k8s.io/api/admissionregistration/v1""
+ 	""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions""
+ 	apiextensionsinstall ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/install""
++	apiextensionsv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+ 	v1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""",We're importing this twice with different aliases.
+1816,"@@ -98,6 +98,7 @@ if __name__ == ""__main__"":
+                 ""grpcio-tools==1.32.0"",
+                 ""isort>=4.3.21,<5"",
+                 ""mock==3.0.5"",
++                ""pandera<0.8.0"",
+                 ""protobuf==3.13.0"",  # without this, pip will install the most up-to-date protobuf
+                 ""pylint==2.6.0"",
+                 ""pytest-cov==2.10.1"",",We should avoid adding a pandera dependency to Dagster itself.
+1817,"@@ -163,9 +163,16 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
+
+     public void setPermission(PostgrePrivilegeType privilegeType, boolean permit) {
+         for (ObjectPermission permission : permissions) {
+-            if (permission.privilegeType == privilegeType) {
++            if (permission.privilegeType != privilegeType) {
+                 if (permit) {
+                     permission.permissions |= GRANTED;
++                    ObjectPermission[] tempPermission = new ObjectPermission[this.permissions.length+1];
++                    for(int i = 0; i < this.permissions.length; i++) {
++                	tempPermission[i] = this.permissions[i];
++                    }
++                    tempPermission[this.permissions.length] = new ObjectPermission(privilegeType, permission.getGrantor(), permission.permissions);
++                    this.permissions = tempPermission;
++
+                 } else {
+                     permission.permissions = 0;
+                 }",Can be replaced with `org.jkiss.utils.ArrayUtils#add`.
+1818,"@@ -653,7 +653,12 @@ public class ZkController implements Closeable {
+     customThreadPool.submit(() -> Collections.singleton(overseer).parallelStream().forEach(IOUtils::closeQuietly));
+
+     try {
+-      customThreadPool.submit(() -> electionContexts.values().parallelStream().forEach(IOUtils::closeQuietly));
++      customThreadPool.submit(() -> {
++        Collection<ElectionContext> values = electionContexts.values();
++        synchronized (electionContexts) {
++          values.forEach(IOUtils::closeQuietly);
++        }
++      });
+
+     } finally {
+ ","While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object."
+1819,"@@ -335,6 +335,18 @@ func ValidateACMEChallengeSolverDNS01(p *cmacme.ACMEChallengeSolverDNS01, fldPat
+ 				if len(p.AzureDNS.TenantID) == 0 {
+ 					el = append(el, field.Required(fldPath.Child(""azureDNS"", ""tenantID""), """"))
+ 				}
++				if len(p.AzureDNS.ManagedIdentityClientID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS"", ""managedIdentityClientID""), ""managed identity can not be used at the same time as clientID, tenantID or clientSecret""))
++				}
++				if len(p.AzureDNS.ManagedIdentityResourceID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS"", ""managedIdentityResourceID""), ""managed identity can not be used at the same time as clientID, tenantID or clientSecret""))
++				}
++			} else {
++				// using managed identity
++				if len(p.AzureDNS.ManagedIdentityClientID) > 0 && len(p.AzureDNS.ManagedIdentityResourceID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS""), ""managedIdentityClientID and managedIdentityResourceID connot both be specified""))
++				}
++
+ 			}
+ 			// SubscriptionID must always be defined
+ 			if len(p.AzureDNS.SubscriptionID) == 0 {",Should these restrictions also be reflected in the API docs?
+1820,"@@ -209,6 +209,13 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	// restore original request before invoking error handler chain (issue #3717)
++	origReq := r.Context().Value(OriginalRequestCtxKey).(http.Request)
++	r.Method = origReq.Method
++	r.RemoteAddr = origReq.RemoteAddr
++	r.RequestURI = origReq.RequestURI
++	cloneURL(origReq.URL, r.URL)
++
+ 	// prepare the error log
+ 	logger := errLog
+ 	if s.Logs != nil {",What about the request headers if someone uses `request_header`? :thinking:
+1821,"@@ -54,7 +54,12 @@ func (r *ReconcileHiveConfig) deployExternalDNS(hLog log.FieldLogger, h *resourc
+ 	deployment := resourceread.ReadDeploymentV1OrDie(asset)
+
+ 	// Make AWS-specific changes to external-dns deployment
+-	deployment.Spec.Template.Spec.Containers[0].Args = append(deployment.Spec.Template.Spec.Containers[0].Args, ""--provider=aws"")
++	args := deployment.Spec.Template.Spec.Containers[0].Args
++	args = append(args, ""--provider=aws"")
++	for _, domain := range instance.Spec.ManagedDomains {
++		args = append(args, fmt.Sprintf(""--domain-filter=%s"", domain))
++	}
++	deployment.Spec.Template.Spec.Containers[0].Args = args
+
+ 	if len(instance.Spec.ExternalDNS.Image) > 0 {
+ 		deployment.Spec.Template.Spec.Containers[0].Image = instance.Spec.ExternalDNS.Image","Verify that external-dns allows setting this parameter multiple times (that it's not ""last one wins"")."
+1822,"@@ -80,6 +80,7 @@ class Docker(base.Base):
+               - nofile:262144:262144
+             dns_servers:
+               - 8.8.8.8
++            etc_hosts: ""{'host1.example.com': '10.3.1.5'}""
+             networks:
+               - name: foo
+               - name: bar",Maybe 2 host/ip values could be used in the example?
+1823,"@@ -139,7 +139,9 @@ namespace Datadog.Trace.Tests.Sampling
+
+             var limiter = new RateLimiter(maxTracesPerInterval: intervalLimit);
+
+-            var traceContext = new TraceContext(Tracer.Instance);
++            var tracerInstance = new Tracer();
++
++            var traceContext = new TraceContext(tracerInstance);
+
+             var barrier = new Barrier(parallelism + 1);
+ ","We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`."
+1824,"@@ -89,7 +89,8 @@ int main(int argc, char *argv[]) {
+     lbann_data::Model *pb_model = pb.mutable_model();
+
+     auto model = build_model_from_prototext(argc, argv, pb_trainer, pb,
+-                                            comm.get(), opts, io_thread_pool, true);
++                                            comm.get(), opts, trainer->get_name(), io_thread_pool,
++                                            trainer->get_callbacks(), true);
+
+     if (opts->has_string(""create_tarball"")) {
+       return EXIT_SUCCESS;","IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?"
+1825,"@@ -217,7 +217,7 @@ void ledger_processor::state_block (rai::state_block const & block_a)
+ void ledger_processor::state_block_impl (rai::state_block const & block_a)
+ {
+ 	auto hash (block_a.hash ());
+-	auto existing (ledger.store.block_exists (transaction, hash));
++	auto existing (ledger.store.block_exists (transaction, block_a.type (), hash));
+ 	result.code = existing ? rai::process_result::old : rai::process_result::progress; // Have we seen this block before? (Unambiguous)
+ 	if (result.code == rai::process_result::progress)
+ 	{",Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state
+1826,"@@ -296,17 +296,8 @@ func pruneRepository(gopts GlobalOptions, repo restic.Repository) error {
+ 	}
+
+ 	if len(removePacks) != 0 {
+-		bar = newProgressMax(!gopts.Quiet, uint64(len(removePacks)), ""packs deleted"")
+-		bar.Start()
+-		for packID := range removePacks {
+-			h := restic.Handle{Type: restic.DataFile, Name: packID.String()}
+-			err = repo.Backend().Remove(ctx, h)
+-			if err != nil {
+-				Warnf(""unable to remove file %v from the repository\n"", packID.Str())
+-			}
+-			bar.Report(restic.Stat{Blobs: 1})
+-		}
+-		bar.Done()
++		Verbosef(""remove %d old packs\n"", len(removePacks))
++		DeleteFiles(gopts, repo, removePacks, restic.DataFile)
+ 	}
+
+ 	Verbosef(""done\n"")",As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?
+1827,"@@ -35,7 +35,7 @@ return [
+     'digits'               => ':attribute 必须是 :digits 位的数字。',
+     'digits_between'       => ':attribute 必须是介于 :min 和 :max 位的数字。',
+     'dimensions'           => ':attribute 图片尺寸不正确。',
+-    'distinct'             => ':attribute 已經存在。',
++    'distinct'             => ':attribute 已经存在。',
+     'email'                => ':attribute 不是一个合法的邮箱。',
+     'exists'               => ':attribute 不存在。',
+     'file'                 => ':attribute 必须是文件。',",It should be simplified character. `` -> ``
+1828,"@@ -33,5 +33,9 @@ namespace Nethermind.Trie
+         void VisitLeaf(TrieNode node, TrieVisitContext trieVisitContext, byte[] value = null);
+
+         void VisitCode(Keccak codeHash, TrieVisitContext trieVisitContext);
++
++        bool VisitAccounts => true;
++
++        int ParallelLevels => -1;
+     }
+ }","I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism"
+1829,"@@ -20,7 +20,7 @@ import java.util.stream.Collector;
+ import static javaslang.collection.Comparators.naturalComparator;
+
+ /**
+- * An {@link HashMap}-based implementation of {@link Multimap}
++ * An {@link TreeMap}-based implementation of {@link Multimap}
+  *
+  * @param <K> Key type
+  * @param <V> Value type",'A' instead of 'An' here
+1830,"@@ -37,7 +37,7 @@ import (
+
+ const (
+ 	// DefaultTimeout is the default timeout used to make calls
+-	DefaultTimeout = 10 * time.Second
++	DefaultTimeout = time.Second * 10
+ 	// DefaultLongPollTimeout is the long poll default timeout used to make calls
+ 	DefaultLongPollTimeout = time.Minute * 3
+ )","Can you flip it back (here and in other places)? It is more natural to represent ""10 seconds"" as `10 * time.Second`."
+1831,"@@ -133,6 +133,11 @@ def test_classifier(output, centers, client, listen_port):
+         centers=centers
+     )
+
++    X_1, y_1, w_1, dX_1, dy_1, dw_1 = _create_data(
++        objective='classification',
++        output='array'
++    )
++
+     params = {
+         ""n_estimators"": 10,
+         ""num_leaves"": 10","Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix."
+1832,"@@ -0,0 +1,6 @@
++<div class=""text-box-wrapper"">
++  <div class=""text-box"">
++    <h3><%= t('.added_to_github_repo') %></h3>
++    <p>Give it a few seconds for the background job to work, and then <%= link_to 'check out the repo', @purchaseable.github_url %>.</p>
++  </div>
++</div>","To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places."
+1833,"@@ -1,6 +1,8 @@
+ package de.danoeh.antennapod.adapter;
+
+ import android.content.Context;
++import android.view.View;
++
+ import androidx.appcompat.app.AlertDialog;
+
+ import de.danoeh.antennapod.R;",Please revert the lines above. Not touching unrelated code keeps the git history clean.
+1834,"@@ -0,0 +1,3 @@
++# Copyright (c) Open-MMLab. All rights reserved.
++
++__version__ = '2.3.0rc0'",`short_version` and `version_info`
+1835,"@@ -52,7 +52,7 @@ type TaskStateChange struct {
+ 	Reason string
+
+ 	// Task is a pointer to the task involved in the state change that gives the event handler a hook into storing
+-	// what status was sent.  This is used to ensure the same event is handled only once.
++	// what stats was sent.  This is used to ensure the same event is handled only once.
+ 	Task *Task
+ }
+ ",This is supposed to be `status`. Why did you change this?
+1836,"@@ -1,3 +1,6 @@
++// Copyright 2012-2017 Apcera Inc. All rights reserved.
++// Copyright 2018 Synadia Communications Inc. All rights reserved.
++
+ package server
+
+ import (",I will change all of these at some point next week.
+1837,"@@ -42,7 +42,7 @@ namespace Datadog.Trace.ClrProfiler
+         /// </summary>
+         public string TargetAssembly
+         {
+-            get => throw new NotSupportedException(""Use property TargetAssemblies instead of TargetAssembly."");
++            get => string.Empty;
+             set => TargetAssemblies = new[] { value };
+         }
+ ","I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging."
+1838,"@@ -106,7 +106,8 @@ func determineDeploymentHealth(obj *unstructured.Unstructured) (status model.Kub
+ 	d := &appsv1.Deployment{}
+ 	err := scheme.Scheme.Convert(obj, d, nil)
+ 	if err != nil {
+-		desc = fmt.Sprintf(""Failed while convert %T to %T: %v"", obj, d, err)
++		status = model.KubernetesResourceState_OTHER
++		desc = fmt.Sprintf(""Unexpected error while calculating: failed while convert %T to %T: %v"", obj, d, err)
+ 		return
+ 	}
+ ","nit: `""Unexpected error while calculating: unable to convert %T to %T: %v""`"
+1839,"@@ -87,6 +87,10 @@ public abstract class SampleConfig {
+   @JsonProperty(""packagePrefix"")
+   public abstract String packagePrefix();
+
++  /** Returns a sample application name. */
++  @JsonProperty(""appName"")
++  public abstract String appName();
++
+   /** Returns a map of method names to methods. */
+   @JsonProperty(""methods"")
+   public abstract Map<String, MethodInfo> methods();","I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer."
+1840,"@@ -53,6 +53,8 @@ export * from './standalone';
+ export * from './storage';
+ export * from './i18n';
+ export * from './helpers';
++export * from './sort-object-map-by-key';
++export * from './convert-array-to-keyed-object-map';
+
+ /**
+  * Remove a parameter from a URL string.","Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files."
+1841,"@@ -0,0 +1 @@
++require ""#{Rails.root}/app/models/acts_as_editable/acts_as_editable.rb""","Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_."
+1842,"@@ -23,6 +23,9 @@ public abstract class GrpcStreamingDetailView {
+
+   public abstract String methodName();
+
++  @Nullable
++  public abstract String upperCamelMethodName();
++
+   public abstract GrpcStreamingType grpcStreamingType();
+
+   @Nullable","I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation."
+1843,"@@ -47,6 +47,13 @@
+ 		}                                                              \
+ 	} while (false);
+
++#define VALIDATE_NAME(_N)                                                      \
++	do {                                                                   \
++		if (_N[0] == '.' || _N[0] == '/') {                            \
++			FPGA_MSG(""%s is not a valid input"", _N);               \
++			return FPGA_INVALID_PARAM;                             \
++		}                                                              \
++	} while (false);
+
+ fpga_result __FPGA_API__ xfpga_fpgaTokenGetObject(fpga_token token, const char *name,
+ 						  fpga_object *object, int flags)","What if .. appears, but not as the first character, eg ""errors/../../../../../../../../../../../""?"
+1844,"@@ -81,7 +81,7 @@ class Guidance < ActiveRecord::Base
+
+   # Returns whether or not a given user can view a given guidance
+   # we define guidances viewable to a user by those owned by a guidance group:
+-  #   owned by the managing curation center
++  #   owned by the default orgs
+   #   owned by a funder organisation
+   #   owned by an organisation, of which the user is a member
+   #","Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`"
+1845,"@@ -122,6 +122,8 @@ public class AzkabanWebServer extends AzkabanServer {
+   private static final int MAX_FORM_CONTENT_SIZE = 10 * 1024 * 1024;
+   private static final String DEFAULT_TIMEZONE_ID = ""default.timezone.id"";
+   private static final String DEFAULT_STATIC_DIR = """";
++
++  @Deprecated
+   private static AzkabanWebServer app;
+   private final VelocityEngine velocityEngine;
+ ",why not removing it?
+1846,"@@ -84,9 +84,9 @@ func NewCliApp() *cli.App {
+ 			EnvVar: ""TEMPORAL_CLI_TLS_CA"",
+ 		},
+ 		cli.BoolFlag{
+-			Name:   FlagTLSEnableHostVerification,
+-			Usage:  ""validates hostname of temporal cluster against server certificate"",
+-			EnvVar: ""TEMPORAL_CLI_TLS_ENABLE_HOST_VERIFICATION"",
++			Name:   FlagTLSDisableHostVerification,
++			Usage:  ""whether to validates hostname of temporal cluster against server certificate"",
++			EnvVar: ""TEMPORAL_CLI_TLS_DISABLE_HOST_VERIFICATION"",
+ 		},
+ 		cli.StringFlag{
+ 			Name:   FlagTLSServerName,","same nit here: maybe word as - ""disables validation of the temporal cluster's server certificate"""
+1847,"@@ -59,6 +59,7 @@ public class TestFlinkCatalogDatabase extends FlinkCatalogTestBase {
+   @Test
+   public void testDefaultDatabase() {
+     sql(""USE CATALOG %s"", catalogName);
++    sql(""show tables"");
+
+     Assert.assertEquals(""Should use the current catalog"", getTableEnv().getCurrentCatalog(), catalogName);
+     Assert.assertEquals(""Should use the configured default namespace"",",Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?
+1848,"@@ -60,7 +60,7 @@ static bool is_a_code_line (const unsigned char *line)
+
+ static bool isLuaIdentifier (char c)
+ {
+-	return (bool) !(isspace(c)  || c == '(' || c == ')' || c == '=');
++	return (bool) !(isspace(c)  || c == '(' || c == ')' || c == '=' || c == '.' || c == ':');
+ }
+
+ static void extract_next_token (const char *begin, const char *end_sentinel, vString *name)","Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log."
+1849,"@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
+ 		c.VXLANMTU = hostMTU - vxlanMTUOverhead
+ 	}
+ 	if c.Wireguard.MTU == 0 {
+-		if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == ""WorkloadIPs"" {
++		if c.Wireguard.EncryptHostTraffic {
+ 			// The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes,
+ 			// see https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-tcpip-performance-tuning#azure-and-vm-mtu
+ 			// for details.",This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS.
+1850,"@@ -71,7 +71,7 @@ var (
+
+ const (
+ 	projectFlagDescription  = ""Name of the project.""
+-	appFlagDescription      = ""Name of the application.""
++	svcFlagDescription      = ""Name of the service.""
+ 	envFlagDescription      = ""Name of the environment.""
+ 	pipelineFlagDescription = ""Name of the pipeline.""
+ 	profileFlagDescription  = ""Name of the profile.""",Do we need to change this flag as well?
+1851,"@@ -10,7 +10,9 @@ module.exports = function (grunt) {
+ 				return grunt.file.read(fn);
+ 			}).join('\n');
+
+-			grunt.file.write(fileset.dest, 'exports.source = ' + JSON.stringify(source) + ';');
++			var file = grunt.file.read(fileset.dest);
++
++			grunt.file.write(fileset.dest, file + 'module.exports.source = ' + JSON.stringify(source) + ';');
+ 		});
+ 	});
+ };",Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?
+1852,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings."
+1853,"@@ -76,7 +76,15 @@ module Bolt
+       target = request['target']
+       plan_vars = shadow_vars('plan', request['plan_vars'], target['facts'])
+       target_vars = shadow_vars('target', target['variables'], target['facts'])
+-      topscope_vars = target_vars.merge(plan_vars)
++
++      # Merge plan vars with target vars, while maintaining the order of the plan
++      # vars. It's critical that the order of plan vars is not changed, as Puppet
++      # will deserialize the variables in the order they appear. Variables may
++      # contain local references to variables that appear earlier in a plan. If
++      # these variables are moved before the variable they reference, Puppet will
++      # be unable to deserialize the data and raise an error.
++      topscope_vars = target_vars.reject { |k, _v| plan_vars.key?(k) }.merge(plan_vars)
++
+       env_conf = { modulepath: request['modulepath'],
+                    facts: target['facts'],
+                    variables: topscope_vars }",Only one line of code? What a simple issue!
+1854,"@@ -111,10 +111,8 @@ func NewHandler(
+ 		status:          common.DaemonStatusInitialized,
+ 		config:          config,
+ 		tokenSerializer: common.NewProtoTaskTokenSerializer(),
+-		rateLimiter: quotas.NewDynamicRateLimiter(
+-			func() float64 {
+-				return float64(config.RPS())
+-			},
++		rateLimiter: quotas.NewDefaultIncomingDynamicRateLimiter(
++			func() float64 { return float64(config.RPS()) },
+ 		),
+ 	}
+ ",Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?
+1855,"@@ -126,12 +126,14 @@ func (n *NetworkPolicyController) deleteCNP(old interface{}) {
+ 	n.deleteDereferencedAddressGroups(oldInternalNP)
+ }
+
+-// reprocessCNP is triggered by Namespace ADD/UPDATE/DELETE events when they impact the
+-// per-namespace rules of a CNP.
+-func (n *NetworkPolicyController) reprocessCNP(cnp *crdv1alpha1.ClusterNetworkPolicy) {
++// reprocessCNP is triggered when a CNP may be impacted by non-ClusterNetworkPolicy events, including Namespace events
++// (for per-namespace rules) and ClusterGroup events (for ClusterGroup reference).
++func (n *NetworkPolicyController) reprocessCNP(cnp *crdv1alpha1.ClusterNetworkPolicy, enqueueAppliedToGroup bool) {
+ 	key := internalNetworkPolicyKeyFunc(cnp)
+ 	n.internalNetworkPolicyMutex.Lock()
+ 	oldInternalNPObj, exist, _ := n.internalNetworkPolicyStore.Get(key)
++	// The internal NetworkPolicy may haven't been created yet. It's fine to skip processing this CNP as addCNP will
++	// create it eventually.
+ 	if !exist {
+ 		klog.V(2).Infof(""Cannot find the original internal NetworkPolicy, skip reprocessCNP"")
+ 		n.internalNetworkPolicyMutex.Unlock()","Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the ""old"" internalNP to `internalNetworkPolicyStore`."
+1856,"@@ -22,6 +22,11 @@ module CartsHelper
+     current_linear_approval?(cart, user)
+   end
+
++  # Todo: Move this to an NCR specific template?
++  def display_restart?(cart, user)
++    cart.ncr? && user == cart.requester && (cart.pending? || cart.rejected?)
++  end
++
+   def parallel_approval_is_pending?(cart, user)
+     return false unless cart.parallel?
+     if approval = Approval.find_by(cart_id: cart.id, user_id: user.id)",Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?
+1857,"@@ -45,6 +45,7 @@ module Mongoid
+         # @param [ Hash ] attributes The attributes hash to attempt to set.
+         # @param [ Hash ] options The options defined.
+         def initialize(association, attributes, options = {})
++          attributes = attributes&.to_h if attributes.respond_to?(:keys)
+           if attributes.respond_to?(:with_indifferent_access)
+             @attributes = attributes.with_indifferent_access.sort do |a, b|
+               a[0].to_i <=> b[0].to_i",What is the purpose of `&` on this line?
+1858,"@@ -58,5 +58,5 @@ export function isValidPropertySelection( value ) {
+  * @return {boolean} TRUE if the web data stream ID is valid, otherwise FALSE.
+  */
+ export function isValidWebDataStreamID( webDataStreamID ) {
+-	return typeof webDataStreamID === 'string' && /\d+/.test( webDataStreamID );
++	return typeof webDataStreamID === 'string' && /^[a-zA-Z0-9]+$/.test( webDataStreamID );
+ }","See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function."
+1859,"@@ -628,7 +628,12 @@ func (s *Server) createLeafNode(conn net.Conn, remote *leafNodeCfg) *client {
+
+ 		c.mu.Unlock()
+ 		// Error will be handled below, so ignore here.
+-		c.parse([]byte(info))
++		err = c.parse([]byte(info))
++		if err != nil {
++			c.Debugf(""Error reading remote leafnode's INFO: %s"", err)
++			c.closeConnection(ReadError)
++			return nil
++		}
+ 		c.mu.Lock()
+
+ 		if !c.flags.isSet(infoReceived) {",Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap.
+1860,"@@ -313,6 +313,15 @@ def speakObjectProperties(obj,reason=controlTypes.REASON_QUERY,index=None,**allo
+ 	newPropertyValues['current']=obj.isCurrent
+ 	if allowedProperties.get('placeholder', False):
+ 		newPropertyValues['placeholder']=obj.placeholder
++	# When speaking an object due to a focus change, the 'selected' state should not be reported if only one item is selected.
++	# This is because that one item will be the focused object, and saying selected is redundant.
++	# Rather, 'unselected' will be spoken for an unselected object if 1 or more items are selected.
++
++	states=newPropertyValues.get('states')
++	if states is not None and reason==controlTypes.REASON_FOCUS:
++		if controlTypes.STATE_SELECTABLE in states and controlTypes.STATE_SELECTED in states and obj.selectionContainer and obj.selectionContainer.getSelectedItemsCount(2)==1:
++			states.discard(controlTypes.STATE_SELECTED)
++			states.discard(controlTypes.STATE_SELECTABLE)
+ 	#Get the speech text for the properties we want to speak, and then speak it
+ 	text=getSpeechTextForProperties(reason,**newPropertyValues)
+ 	if text:",Could you split these conditions up over multiple lines please.
+1861,"@@ -33,7 +33,7 @@ func (t *tag) parseJSONTag(structTag reflect.StructTag) {
+ }
+
+ func (t *tag) parseTagStr(tagStr string) {
+-	parts := strings.SplitN(tagStr, "","", 2)
++	parts := strings.SplitN(tagStr, "","", 3)
+ 	if len(parts) == 0 {
+ 		return
+ 	}",I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag.
+1862,"@@ -69,10 +69,8 @@ services:
+     image: {{ .router_image }}:{{ .router_tag }}
+     container_name: nginx-proxy
+     ports:
+-      - ""80:80""
+-      - {{ .mailhogport }}:{{ .mailhogport }}
+-      - {{ .dbaport }}:{{ .dbaport }}
+-      - {{ .dbport }}:{{ .dbport }}
++      {{ range $port := .ports }}- ""{{ $port }}:{{ $port }}""
++      {{ end }}
+     volumes:
+       - /var/run/docker.sock:/tmp/docker.sock:ro
+ networks:","So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here  . The format of the ports directive is ""host:container"". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports."
+1863,"@@ -1176,7 +1176,9 @@ func (s *ContextImpl) transitionLocked(request contextRequest) {
+ 		s.state = contextStateStopping
+ 		// The change in state should cause all write methods to fail, but just in case, set this also,
+ 		// which will cause failures at the persistence level
+-		s.shardInfo.RangeId = -1
++		if s.shardInfo != nil {
++			s.shardInfo.RangeId = -1
++		}
+ 		// This will cause the controller to remove this shard from the map and then call s.stop()
+ 		go s.closeCallback(s)
+ 	}","An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead."
+1864,"@@ -960,3 +960,8 @@ func SessionInfoFromProtocol(session keybase1.Session) (SessionInfo, error) {
+ 		VerifyingKey:   verifyingKey,
+ 	}, nil
+ }
++
++// NodeMetadata has metadata about a node needed for higher level operations.
++type NodeMetadata struct {
++	LastWriter keybase1.UID
++}","Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?"
+1865,"@@ -49,9 +49,9 @@ ewmh_client_update_hints(lua_State *L)
+         state[i++] = _NET_WM_STATE_MODAL;
+     if(c->fullscreen)
+         state[i++] = _NET_WM_STATE_FULLSCREEN;
+-    if(c->maximized_vertical)
++    if(c->maximized_vertical || c->maximized)
+         state[i++] = _NET_WM_STATE_MAXIMIZED_VERT;
+-    if(c->maximized_horizontal)
++    if(c->maximized_horizontal || c->maximized)
+         state[i++] = _NET_WM_STATE_MAXIMIZED_HORZ;
+     if(c->sticky)
+         state[i++] = _NET_WM_STATE_STICKY;","For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between."
+1866,"@@ -88,12 +88,6 @@ var (
+ 	prelude = []string{
+ 		""universe"",
+ 		""influxdata/influxdb"",
+-		""math"",
+-		""strings"",
+-		""regexp"",
+-		""date"",
+-		""json"",
+-		""http"",
+ 	}
+ 	preludeScope = &scopeSet{
+ 		packages: make([]*interpreter.Package, len(prelude)),","Why did you remove these packages from the prelude, will your new functions not work without this change?"
+1867,"@@ -36,10 +36,14 @@ GetProcessor::asyncProcess(PartitionID part,
+                            const std::vector<std::string>& keys) {
+     folly::Promise<std::pair<PartitionID, kvstore::ResultCode>> promise;
+     auto future = promise.getFuture();
++    std::vector<std::string> kvKeys;
++    std::transform(keys.begin(), keys.end(), std::back_inserter(kvKeys),
++                   [part](const auto& key) { return NebulaKeyUtils::kvKey(part, key); });
+
+-    executor_->add([this, p = std::move(promise), part, keys] () mutable {
++    executor_->add([this, p = std::move(promise), part, &keys,
++                    kvKeys = std::move(kvKeys)] () mutable {
+         std::vector<std::string> values;
+-        auto ret = this->kvstore_->multiGet(space_, part, keys, &values);
++        auto ret = this->kvstore_->multiGet(space_, part, kvKeys, &values);
+         if (ret == kvstore::ResultCode::SUCCEEDED) {
+             std::lock_guard<std::mutex> lg(this->lock_);
+             for (int32_t i = 0; i < static_cast<int32_t>(keys.size()); i++) {",We'd better reserve enough space before using kvKeys to avoid extra malloc.
+1868,"@@ -213,3 +213,12 @@ func GetLocalPVType(pv *v1.PersistentVolume) string {
+ 	}
+ 	return """"
+ }
++
++// GetNodeHostname extracts the Hostname from the labels on the Node
++func GetNodeHostname(n *v1.Node) string {
++	hostname, found := n.Labels[KeyNodeHostname]
++	if found {
++		return hostname
++	}
++	return n.Name
++}",would it make sense to return empty or error if label doesn't exists?
+1869,"@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
+ exports.rmDir = function(path) {
+   return new promise.Promise(function(fulfill, reject) {
+     var numAttempts = 0;
++    var maxAttempts = 5;
++    var attemptTimeout = 250;
+     attemptRm();
+     function attemptRm() {
+       numAttempts += 1;
+       rimraf(path, function(err) {
+         if (err) {
+-          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+-            attemptRm();
++          if (err.code === 'ENOTEMPTY' && numAttempts <= maxAttempts) {
++            setTimeout(attemptRm, attemptTimeout);
+             return;
+           }
+           reject(err);",Don't penalize everyone with 250ms delay b/c some machines have problems.
+1870,"@@ -119,6 +119,15 @@ func (s SortedCidSet) Equals(s2 SortedCidSet) bool {
+ 	return true
+ }
+
++// String returns a string listing the cids in the set.
++func (s SortedCidSet) String() string {
++	out := ""{""
++	for it := s.Iter(); !it.Complete(); it.Next() {
++		out = fmt.Sprintf(""%s %s"", out, it.Value().String())
++	}
++	return out + "" }""
++}
++
+ // MarshalJSON serializes the set to JSON.
+ func (s SortedCidSet) MarshalJSON() ([]byte, error) {
+ 	return json.Marshal(s.s)",Probably want a space after the second %s?
+1871,"@@ -206,7 +206,7 @@ func (h *historyArchiver) Get(
+ 	dirPath := URI.Path()
+ 	exists, err := directoryExists(dirPath)
+ 	if err != nil {
+-		return nil, serviceerror.NewInternal(err.Error())
++		return nil, serviceerror.NewUnavailable(err.Error())
+ 	}
+ 	if !exists {
+ 		return nil, serviceerror.NewInvalidArgument(archiver.ErrHistoryNotExist.Error())",This seems like an internal error still?
+1872,"@@ -85,7 +85,7 @@ describe PurchasesController do
+
+       post :create, purchase: customer_params(stripe_token), product_id: product.to_param
+
+-      FakeStripe.should have_charged(1500).to('test@example.com').with_token(stripe_token)
++      expect(FakeStripe).to have_charged(1500).to('test@example.com').with_token(stripe_token)
+     end
+   end
+ ",Line is too long. [94/80]
+1873,"@@ -125,10 +125,16 @@ func (a *ClusterIdentityAllocator) Run(stopCh <-chan struct{}) {
+ 	}
+ }
+
++type ClusterIdentity struct {
++	UUID uuid.UUID
++}
++
+ // ClusterIdentityProvider is an interface used to retrieve the cluster identity information (UUID),
+-// as provided by the user or generated by the Antrea Controller.
++// as provided by the user or generated by the Antrea Controller. It also returns the time at which
++// the antrea-cluster-identity was created, which can typically be considered as the time at which
++// Antrea was deployed to the cluster.
+ type ClusterIdentityProvider interface {
+-	Get() (uuid.UUID, error)
++	Get() (ClusterIdentity, time.Time, error)
+ }
+
+ type clusterIdentityProvider struct {","out of curiosity, why creating another struct to wrap it?"
+1874,"@@ -9549,8 +9549,15 @@ bool Bot::UseDiscipline(uint32 spell_id, uint32 target) {
+ 			if(spells[spell_id].timer_id > 0 && spells[spell_id].timer_id < MAX_DISCIPLINE_TIMERS)
+ 				SetDisciplineRecastTimer(spells[spell_id].timer_id, spell.recast_time);
+ 		} else {
+-			uint32 remain = (GetDisciplineRemainingTime(this, spells[spell_id].timer_id) / 1000);
+-			GetOwner()->Message(Chat::White, ""%s can use this discipline in %d minutes %d seconds."", GetCleanName(), (remain / 60), (remain % 60));
++			uint32 remaining_time = (GetDisciplineRemainingTime(this, spells[spell_id].timer_id) / 1000);
++			GetOwner()->Message(
++				Chat::White,
++				fmt::format(
++					""{} can use this Discipline in {}."",
++					GetCleanName(),
++					ConvertSecondsToTime(remaining_time)
++				).c_str()
++			);
+ 			return false;
+ 		}
+ 	}",discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const.
+1875,"@@ -135,6 +135,7 @@ public abstract class ResourceDescriptorConfig {
+                       .setEntityId(nameMap.get(p).toUpperCamel())
+                       .setEntityName(overrideConfig.getEntityName())
+                       .setCommonResourceName(overrideConfig.getCommonResourceName())
++                      .setAssignedProtoFile(protoFile)
+                       .build();
+                 } else {
+                   return SingleResourceNameConfig.newBuilder()","I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace."
+1876,"@@ -63,6 +63,8 @@ NATURAL_ORDER_COLUMN_NAME = ""__natural_order__""
+
+ HIDDEN_COLUMNS = {NATURAL_ORDER_COLUMN_NAME}
+
++SERIES_DEFAULT_NAME = ""0""
++
+
+ class InternalFrame(object):
+     """"""",How about `SPARK_DEFAULT_SERIES_NAME`?
+1877,"@@ -36,9 +36,18 @@ public class TableProperties {
+   public static final String COMMIT_TOTAL_RETRY_TIME_MS = ""commit.retry.total-timeout-ms"";
+   public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes
+
+-  public static final String COMMIT_NUM_STATUS_CHECKS = ""commit.num-status-checks"";
++  public static final String COMMIT_NUM_STATUS_CHECKS = ""commit.status-checks.num-retries"";
+   public static final int COMMIT_NUM_STATUS_CHECKS_DEFAULT = 3;
+
++  public static final String COMMIT_STATUS_CHECKS_MIN_WAIT_MS = ""commit.status-check.min-wait-ms"";
++  public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L; // 1s
++
++  public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS = ""commit.status-check.max-wait-ms"";
++  public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L; // 1 minute
++
++  public static final String COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS = ""commit.status-check.total-timeout-ms"";
++  public static final long COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS_DEFAULT = 1800000; // 30 minutes
++
+   public static final String MANIFEST_TARGET_SIZE_BYTES = ""commit.manifest.target-size-bytes"";
+   public static final long MANIFEST_TARGET_SIZE_BYTES_DEFAULT = 8388608; // 8 MB
+ ","The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?"
+1878,"@@ -6,6 +6,12 @@ var setupDatabase = require('./shared').setupDatabase;
+
+ describe('Authentication', function() {
+   before(function() {
++    const configuration = this.configuration;
++    if (configuration.usingUnifiedTopology()) {
++      // The unified topology does not currently support authentication
++      return this.skip();
++    }
++
+     return setupDatabase(this.configuration);
+   });
+ ",Side note: I'd love to see more of these fields exposed on configuration.
+1879,"@@ -5,7 +5,7 @@
+   contact_us = (Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url)
+   email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
+   user_name = User.find_by(email: @resource.email).nil? ?  @resource.email : User.find_by(email: @resource.email).name(false)
+-  inviter_name = @resource.is_a?(User) ? @resource.invited_by.name(false) : @resource.invited_by.name
++  inviter_name = @resource.invited_by.name
+ %>
+ <% FastGettext.with_locale FastGettext.default_locale do %>
+   <p>","In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?"
+1880,"@@ -33,6 +33,8 @@ public class MutableQbftConfigOptions extends MutableBftConfigOptions implements
+         qbftConfigOptions.getValidatorContractAddress().map(String::toLowerCase);
+   }
+
++  // TODO-lucas do I need to implement getStartBlock here?
++
+   @Override
+   public Optional<String> getValidatorContractAddress() {
+     return validatorContractAddress;","I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not."
+1881,"@@ -89,5 +89,10 @@ namespace Nethermind.JsonRpc
+         ///
+         /// </summary>
+         public const int ExecutionError = -32015;
++
++        /// <summary>
++        /// Request exceedes defined tracer timeout limit
++        /// </sumary>
++        public const int TracerTimeout = -32016;
+     }
+ }",what is the number thrown by Geth?
+1882,"@@ -2036,8 +2036,8 @@ common.checkDatabaseConfigMatch = (apiConfig, frontendConfig) => {
+                 // mongodb0.example.com:27017
+                 let apiMongoHost = apiConfig.split(""/"")[2];
+                 let frontendMongoHost = frontendConfig.split(""/"")[2];
+-                let apiMongoDb = apiConfig.split(""/"")[3];
+-                let frontendMongoDb = frontendConfig.split(""/"")[3];
++                let apiMongoDb = apiConfig.split(""/"")[3].split('?')[0];
++                let frontendMongoDb = frontendConfig.split(""/"")[3].split('?')[0];
+                 if (apiMongoHost === frontendMongoHost && apiMongoDb === frontendMongoDb) {
+                     return true;
+                 }","This would still crash on malformed database connection string like ""test"""
+1883,"@@ -0,0 +1,14 @@
++package interfaces
++
++import ""context""
++
++type pluginNameKey struct{}
++
++func PluginNameFromHostServiceContext(ctx context.Context) (string, bool) {
++	name, ok := ctx.Value(pluginNameKey{}).(string)
++	return name, ok
++}
++
++func WithPluginName(ctx context.Context, name string) context.Context {
++	return context.WithValue(ctx, pluginNameKey{}, name)
++}","it is not an interface, maybe we can move to another package?"
+1884,"@@ -4,14 +4,15 @@ import { stopPropagation, stopImmediatePropagation, isImmediatePropagationStoppe
+ import { getEditorInstance } from './editors';
+ import EventManager from './eventManager';
+ import { EditorState } from './editors/_baseEditor';
++import { getParentWindow } from './helpers/dom/element';
+
+ class EditorManager {
+   /**
+    * @param {Handsontable} instance
+-   * @param {GridSettings} priv
++   * @param {GridSettings} tableMeta
+    * @param {Selection} selection
+    */
+-  constructor(instance, priv, selection) {
++  constructor(instance, tableMeta, selection) {
+     /**
+      * Instance of {@link Handsontable}
+      *",Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?
+1885,"@@ -13,7 +13,15 @@ import (
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ )
+
++func isCpuSet(cgroup *configs.Cgroup) bool {
++	return cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuMax != """"
++}
++
+ func setCpu(dirPath string, cgroup *configs.Cgroup) error {
++	if !isCpuSet(cgroup) {
++		return nil
++	}
++
+ 	// NOTE: .CpuShares is not used here. Conversion is the caller's responsibility.
+ 	if cgroup.Resources.CpuWeight != 0 {
+ 		if err := fscommon.WriteFile(dirPath, ""cpu.weight"", strconv.FormatUint(cgroup.Resources.CpuWeight, 10)); err != nil {",Not sure whether this validation is useful.
+1886,"@@ -422,6 +422,17 @@ class PromptContainer(QWidget):
+         except UnsupportedOperationError:
+             pass
+
++    @cmdutils.register(instance='prompt-container', scope='window',
++                       modes=[usertypes.KeyMode.prompt])
++    def prompt_yank(self):
++        """"""Yank URLs or other data in prompts.""""""
++        question = self._prompt.question
++        s = None
++        if question and hasattr(question, 'yank_text'):
++            s = question.yank_text
++        utils.set_clipboard(s)
++        message.info(""Yanked download URL to clipboard: {}"".format(s))
++
+
+ class LineEdit(QLineEdit):
+ ","Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?"
+1887,"@@ -121,8 +121,10 @@ def buffer_s3response(s3response):
+             found_records = True
+         elif 'Progress' in event:
+             logger_.info(""select progress: %s"", event['Progress'].get('Details'))
++            print(event['Progress'].get('Details'))
+         elif 'Stats' in event:
+             logger_.info(""select stats: %s"", event['Stats'])
++            print(event['Stats'])
+         elif 'End' in event:
+             # End event indicates that the request finished successfully
+             end_event_received = True","If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead."
+1888,"@@ -115,7 +115,7 @@ func DefaultNodeOptions() *MobileNodeOptions {
+ 		EtherClientRPC:                  metadata.Testnet2Definition.EtherClientRPC,
+ 		FeedbackURL:                     ""https://feedback.mysterium.network"",
+ 		QualityOracleURL:                ""https://testnet2-quality.mysterium.network/api/v1"",
+-		IPDetectorURL:                   ""https://api.ipify.org/?format=json"",
++		IPDetectorURL:                   ""https://testnet2-location.mysterium.network/api/v1/location"",
+ 		LocationDetectorURL:             ""https://testnet2-location.mysterium.network/api/v1/location"",
+ 		TransactorEndpointAddress:       metadata.Testnet2Definition.TransactorAddress,
+ 		TransactorRegistryAddress:       metadata.Testnet2Definition.RegistryAddress,",We should drop ipify in all places i guess
+1889,"@@ -137,8 +137,8 @@ type ConsensusParams struct {
+ 	DownCommitteeSize      uint64
+ 	DownCommitteeThreshold uint64
+
+-	FilterTimeoutSmallLambdas             uint64
+-	FilterTimeoutPeriod0SmallLambdas      uint64
++	AgreementFilterTimeout        time.Duration
++	AgreementFilterTimeoutPeriod0 time.Duration
+
+ 	FastRecoveryLambda    time.Duration // time between fast recovery attempts
+ 	FastPartitionRecovery bool          // set when fast partition recovery is enabled","Add explanations around these variables - what do they mean, how they should be configured, etc."
+1890,"@@ -106,6 +106,11 @@ class SiteController < ApplicationController
+     @locale = params[:about_locale] || I18n.locale
+   end
+
++  def communities
++    OsmCommunityIndex::LocalChapter.add_to_i18n # this should be called on app init
++    @local_chapters = OsmCommunityIndex::LocalChapter.local_chapters
++  end
++
+   def export; end
+
+   def offline; end","One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website."
+1891,"@@ -321,4 +321,16 @@ public interface GauntletConfig extends Config
+ 	{
+ 		return false;
+ 	}
++
++	@ConfigItem(
++			position = 21,
++			keyName = ""displayResources"",
++			name = ""Show raw resources gathered"",
++			description = ""Displays how much of each resource you have gathered."",
++			titleSection = ""resources""
++	)
++	default boolean displayGatheredResources()
++	{
++		return false;
++	}
+ }",To much tabs here (1 tab)
+1892,"@@ -135,12 +135,12 @@ public class ExecutionLogsDao {
+     }
+   }
+
+-  int removeExecutionLogsByTime(final long millis)
++  int removeExecutionLogsByTime(final long millis, final int recordCleanupLimit)
+       throws ExecutorManagerException {
+     final String DELETE_BY_TIME =
+-        ""DELETE FROM execution_logs WHERE upload_time < ?"";
++        ""DELETE FROM execution_logs WHERE upload_time < ? LIMIT ?"";
+     try {
+-      return this.dbOperator.update(DELETE_BY_TIME, millis);
++      return this.dbOperator.update(DELETE_BY_TIME, millis, recordCleanupLimit);
+     } catch (final SQLException e) {
+       logger.error(""delete execution logs failed"", e);
+       throw new ExecutorManagerException(",This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch.
+1893,"@@ -1319,10 +1319,10 @@ func (s *timerQueueActiveTaskExecutorSuite) TestWorkflowTimeout_ContinueAsNew_Re
+ 	// need to override the workflow retry policy
+ 	executionInfo := mutableState.executionInfo
+ 	executionInfo.HasRetryPolicy = true
+-	executionInfo.WorkflowExpirationTime = s.now.Add(1000 * time.Second)
++	executionInfo.WorkflowExpirationTime = timestamp.TimeNowPtrUtcAddSeconds(1000)
+ 	executionInfo.MaximumAttempts = 10
+-	executionInfo.InitialInterval = 1
+-	executionInfo.MaximumInterval = 1
++	executionInfo.InitialInterval = timestamp.DurationFromSeconds(1)
++	executionInfo.MaximumInterval = timestamp.DurationFromSeconds(1)
+ 	executionInfo.BackoffCoefficient = 1
+
+ 	di := addWorkflowTaskScheduledEvent(mutableState)","I don't like this helper func :-). Yeah, definitely don't like."
+1894,"@@ -18,17 +18,7 @@ describe( 'PageSpeed Insights Activation', () => {
+ 	beforeAll( async () => {
+ 		await page.setRequestInterception( true );
+ 		useRequestInterception( ( request ) => {
+-			if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
+-				request.respond( { status: 200 } );
+-			} else if (
+-				request
+-					.url()
+-					.match(
+-						'google-site-kit/v1/modules/pagespeed-insights/data/pagespeed'
+-					)
+-			) {
+-				request.respond( { status: 200, body: JSON.stringify( {} ) } );
+-			} else if (
++			if (
+ 				request
+ 					.url()
+ 					.match(","Same here. This should remain unchanged. Please, add it back."
+1895,"@@ -2052,6 +2052,9 @@ Collection.prototype.mapReduce = function(map, reduce, options, callback) {
+  */
+ Collection.prototype.initializeUnorderedBulkOp = function(options) {
+   options = options || {};
++  if (this.s.options.ignoreUndefined) {
++    options.ignoreUndefined = this.s.options.ignoreUndefined;
++  }
+   options.promiseLibrary = this.s.promiseLibrary;
+   return unordered(this.s.topology, this, options);
+ };",@kvwalker should this method have `ignoreUndefined` supported as an `option`?
+1896,"@@ -52,10 +52,11 @@ func New(_ *any.Any, logger *zap.Logger, _ tally.Scope) (service.Service, error)
+ 		return nil, errors.New(""experiment store wrong type"")
+ 	}
+
+-	transformer := NewTransformer()
++	sugaredLogger := logger.Sugar()
++	transformer := NewTransformer(sugaredLogger)
+ 	return &storer{
+ 		client.DB(),
+-		logger.Sugar(),
++		sugaredLogger,
+ 		&transformer,
+ 	}, nil
+ }","we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?"
+1897,"@@ -388,7 +388,6 @@ class ServerCallback(MessageCallback):
+         if not self._queue:
+             self._active = False
+             return
+-        self._queue = []
+         # Get unique event types in the queue
+         events = list(OrderedDict([(event.event_name, event)
+                                    for event in self._queue]).values())",Not evident from looking at this diff but the queue is already being cleared four lines below.
+1898,"@@ -293,6 +293,16 @@ func (pool *TransactionPool) computeFeePerByte() uint64 {
+ // checkSufficientFee take a set of signed transactions and verifies that each transaction has
+ // sufficient fee to get into the transaction pool
+ func (pool *TransactionPool) checkSufficientFee(txgroup []transactions.SignedTxn) error {
++	// Special case: the compact cert transaction, if issued from the
++	// special compact-cert-sender address, in a singleton group, pays
++	// no fee.
++	if len(txgroup) == 1 {
++		t := txgroup[0].Txn
++		if t.Type == protocol.CompactCertTx && t.Sender == transactions.CompactCertSender && t.Fee.IsZero() {
++			return nil
++		}
++	}
++
+ 	// get the current fee per byte
+ 	feePerByte := pool.computeFeePerByte()
+ ",Why is this a 'transaction' and not in the block header?
+1899,"@@ -2,12 +2,14 @@
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+ using System.IO;
++using System.Security.Cryptography.X509Certificates;
+
+ namespace Microsoft.AspNet.Server.Kestrel.Filter
+ {
+     public class ConnectionFilterContext
+     {
+         public ServerAddress Address { get; set; }
+-        public Stream Connection { get; set;  }
++        public Stream Connection { get; set; }
++        public X509Certificate2 ClientCertificate { get; set; }
+     }
+ }",This doesn't fit the abstraction level. Should we have a property bag for extra stuff?
+1900,"@@ -616,11 +616,12 @@ def build_sdist(sdist_directory, config_settings=None):
+     files += glob.glob(""src/core/**/*.cc"", recursive=True)
+     files += glob.glob(""src/core/**/*.h"", recursive=True)
+     files += glob.glob(""ci/xbuild/*.py"")
++    files += glob.glob(""docs/**/*.rst"", recursive=True)
+     files += [f for f in glob.glob(""tests/**/*.py"", recursive=True)]
+     files += [f for f in glob.glob(""tests_random/*.py"")]
+     files += [""src/datatable/include/datatable.h""]
+     files.sort()
+-    files += [""ci/ext.py"", ""ci/__init__.py""]
++    files += [""ci/ext.py"", ""ci/__init__.py"", ""ci/gendoc.py""]
+     files += [""pyproject.toml""]
+     files += [""LICENSE""]
+     # See `is_source_distribution()`","Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often."
+1901,"@@ -244,6 +244,7 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey,
+ 		return nil, fmt.Errorf(""p2p service: %w"", err)
+ 	}
+ 	b.p2pService = p2ps
++	defer p2ps.Ready()
+
+ 	if !o.Standalone {
+ 		if natManager := p2ps.NATManager(); natManager != nil {",do we really need the `Ready` call if startup fails midway?
+1902,"@@ -17,7 +17,9 @@ namespace storage {
+
+ TEST(AddVerticesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddVerticesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddVerticesProcessor::instance(kv.get(),",You can avoid changing the code if there are parameter defaults. right ?
+1903,"@@ -214,7 +214,7 @@ describe('Components', () => {
+
+ 		let good, bad;
+ 		let root = render(<GoodContainer ref={c=>good=c} />, scratch);
+-		expect(scratch.innerText, 'new component with key present').to.equal('A\nB');
++		expect(scratch.textContent, 'new component with key present').to.equal('AB');
+ 		expect(Comp.prototype.componentWillMount).to.have.been.calledTwice;
+ 		expect(sideEffect).to.have.been.calledTwice;
+ ",I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers.
+1904,"@@ -4252,10 +4252,15 @@ void command_corpsefix(Client *c, const Seperator *sep)
+
+ void command_reloadworld(Client *c, const Seperator *sep)
+ {
+-	c->Message(Chat::White, ""Reloading quest cache and repopping zones worldwide."");
++	int world_repop = atoi(sep->arg[1]);
++	if (world_repop == 0)
++		c->Message(Chat::White, ""Reloading quest cache worldwide."");
++	else
++		c->Message(Chat::White, ""Reloading quest cache and repopping zones worldwide."");
++
+ 	auto pack = new ServerPacket(ServerOP_ReloadWorld, sizeof(ReloadWorld_Struct));
+ 	ReloadWorld_Struct* RW = (ReloadWorld_Struct*) pack->pBuffer;
+-	RW->Option = ((atoi(sep->arg[1]) == 1) ? 1 : 0);
++	RW->Option = world_repop;
+ 	worldserver.SendPacket(pack);
+ 	safe_delete(pack);
+ }","I know this is legal, but I prefer we put brackets on our calls"
+1905,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteServerCertificate.java demonstrates how to delete an AWS Identity and Access Management (IAM) server certificate.]
++//snippet-sourcedescription:[DeleteServerCertificate.java demonstrates how to delete an AWS Identity and Access Management (AWS IAM) server certificate.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+1906,"@@ -0,0 +1,18 @@
++package org.openqa.selenium;
++
++/**
++ * Created by James Reed on 11/04/2016.
++ * Thrown to indicate that a click was attempted on an element but was intercepted by another
++ * element on top of it
++ */
++public class InterceptingElementException extends InvalidElementStateException {
++
++  public InterceptingElementException(String message) {
++    super(message);
++  }
++
++  public InterceptingElementException(String message, Throwable cause) {
++    super(message, cause);
++  }
++
++}",We keep who wrote the code anonymous.
+1907,"@@ -135,10 +135,14 @@ export const readableLargeNumber = ( number, currencyCode = false ) =>  {
+ 	if ( false !== currencyCode && '' !== readableNumber ) {
+ 		const formatedParts = new Intl.NumberFormat( navigator.language, { style: 'currency', currency: currencyCode } ).formatToParts( number );
+
+-		const decimal = formatedParts.find( part => 'decimal' === part.type ).value;
++		let decimal = formatedParts.find( part => 'decimal' === part.type );
++		if ( ! isUndefined( decimal ) ) {
++			decimal = decimal.value;
++		}
++
+ 		const currency = formatedParts.find( part => 'currency' === part.type ).value;
+
+-		if ( 1000 > number ) {
++		if ( 1000 > number && ! isUndefined( decimal ) ) {
+ 			readableNumber = Number.isInteger( number ) ? number : number.replace( '.', decimal );
+ 		}
+ ","Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`)."
+1908,"@@ -26,6 +26,15 @@ import ""context""
+
+ // Outbound is the common interface for all outbounds
+ type Outbound interface {
++	// Transports returns the transports that used by this outbound, so they
++	// can be collected for lifecycle management, typically by a Dispatcher.
++	//
++	// Though most outbounds only use a single transport, composite outbounds
++	// may use multiple transport protocols, particularly for shadowing traffic
++	// across multiple transport protocols during a transport protocol
++	// migration.
++	Transports() []Transport
++
+ 	// Sets up the outbound to start making calls.
+ 	//
+ 	// This MUST block until the outbound is ready to start sending requests.","Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?"
+1909,"@@ -28,6 +28,7 @@ import (
+
+ func testAlertmanagerInstanceNamespacesAllNs(t *testing.T) {
+ 	ctx := framework.NewTestCtx(t)
++
+ 	defer ctx.Cleanup(t)
+
+ 	// create 3 namespaces:","nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup."
+1910,"@@ -7,6 +7,12 @@ use JavierEguiluz\Bundle\EasyAdminBundle\Exception\EntityNotFoundException;
+ use Symfony\Component\EventDispatcher\GenericEvent;
+ use Symfony\Component\HttpFoundation\Request;
+
++/**
++ * Adds some custom attributes to the request object to store information
++ * related to EasyAdmin.
++ *
++ * @author Maxime Steinhausser
++ */
+ class RequestPostInitializeListener
+ {
+     /** @var Request|null */",Feel free to use the full notation with my email address: `Maxime Steinhausser <maxime.steinhausser@gmail.com>` :smile:
+1911,"@@ -44,7 +44,6 @@ const FCGINullRequestID uint8 = 0
+
+ // FCGIKeepConn describes keep connection mode.
+ const FCGIKeepConn uint8 = 1
+-const doubleCRLF = ""\r\n\r\n""
+
+ const (
+ 	// BeginRequest is the begin request flag.",This was unused across the codebase
+1912,"@@ -2278,7 +2278,8 @@ func (js *jetStream) processConsumerAssignment(ca *consumerAssignment) {
+
+ 	acc, err := s.LookupAccount(ca.Client.serviceAccount())
+ 	if err != nil {
+-		// TODO(dlc) - log error
++		js.mu.Unlock()
++		s.Warnf(""Account lookup for consumer create failed: %v"", err)
+ 		return
+ 	}
+ ",Should we put in which account we were trying to look up?
+1913,"@@ -55,6 +55,7 @@ class InventoryTypeClass(object):
+     RESOURCE = 'resource'
+     IAM_POLICY = 'iam_policy'
+     GCS_POLICY = 'gcs_policy'
++    Supported_TypeClass = [RESOURCE, IAM_POLICY, GCS_POLICY]
+
+
+ class InventoryIndex(BASE):",either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names.
+1914,"@@ -31,6 +31,7 @@ CREATE TABLE notes (
+ 	is_todo INT NOT NULL DEFAULT 0,
+ 	todo_due INT NOT NULL DEFAULT 0,
+ 	todo_completed INT NOT NULL DEFAULT 0,
++	pinned INT NOT NULL DEFAULT 0,
+ 	source TEXT NOT NULL DEFAULT """",
+ 	source_application TEXT NOT NULL DEFAULT """",
+ 	application_data TEXT NOT NULL DEFAULT """",",This is not going to work. You need to add a migration to the database.
+1915,"@@ -308,6 +308,7 @@ class Manager {
+      * @param {Object} apiClient The ApiClient.
+      */
+     resumeGroupPlayback(apiClient) {
++        // TODO: rename this method, it's not clear what it does.
+         this.followGroupPlayback(apiClient).then(() => {
+             this.queueCore.startPlayback(apiClient);
+         });",Should these methods be renamed in this PR?
+1916,"@@ -154,6 +154,18 @@ namespace OpenTelemetry.Metrics
+                         {
+                             var metricStreamConfig = metricStreamConfigs[i];
+                             var metricStreamName = metricStreamConfig?.Name ?? instrument.Name;
++
++                            if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName))
++                            {
++                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(
++                                    instrument.Name,
++                                    instrument.Meter.Name,
++                                    ""Metric name is invalid."",
++                                    ""The name must comply with the OpenTelemetry specification."");
++
++                                continue;
++                            }
++
+                             if (this.metricStreamNames.ContainsKey(metricStreamName))
+                             {
+                                 // TODO: Log that instrument is ignored","we need to include the `metricStreamName` which is invalid, so users know whats causing the issue."
+1917,"@@ -93,8 +93,10 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+                 var pdbFilePath = Path.ChangeExtension(binaryPath, "".pdb"");
+                 using (var pdbReader = new PortablePdbReader(new FileHelper().GetStream(pdbFilePath, FileMode.Open, FileAccess.Read)))
+                 {
+-                    // Load assembly
+-                    var asm = AssemblyLoadContext.Default.LoadFromAssemblyPath(binaryPath);
++                    // At this point, the assembly should be already loaded into the load context. We query for a reference to
++                    // find the types and cache the symbol information. Let the loader follow default lookup order instead of
++                    // forcing load from a specific path.
++                    var asm = Assembly.Load(AssemblyLoadContext.GetAssemblyName(binaryPath));
+
+                     foreach (var type in asm.GetTypes())
+                     {",Please run Platform tests `DiaSessionTests`.
+1918,"@@ -741,6 +741,7 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte,
+             return pc;
+         }
+         *is_evex = true;
++        SYSLOG_INTERNAL_WARNING_ONCE(MSG_AVX_512_SUPPORT_INCOMPLETE_STRING "" @"" PFX, pc);
+         info = &evex_prefix_extensions[0][1];
+     } else {
+         /* not evex */",This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers.
+1919,"@@ -37,6 +37,10 @@ function matchesParentDomain(srvAddress, parentDomain) {
+ function parseSrvConnectionString(uri, options, callback) {
+   const result = URL.parse(uri, true);
+
++  if (options.directConnection || options.directconnection) {
++    return callback(new MongoParseError('directConnection not supported with SRV URI'));
++  }
++
+   if (result.hostname.split('.').length < 3) {
+     return callback(new MongoParseError('URI does not have hostname, domain name and tld'));
+   }",is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options.
+1920,"@@ -230,11 +230,11 @@ func BenchmarkFloat64LastValueAdd(b *testing.B) {
+
+ // Histograms
+
+-func benchmarkInt64HistogramAdd(b *testing.B, name string) {
++func BenchmarkInt64HistogramAdd(b *testing.B) {
+ 	ctx := context.Background()
+ 	fix := newFixture(b)
+ 	labs := makeLabels(1)
+-	mea := fix.meterMust().NewInt64Histogram(name)
++	mea := fix.meterMust().NewInt64Histogram(""int64.histogram"")
+
+ 	b.ResetTimer()
+ ",Does the name suffix hardcode something? Not clear how changing the name fixes this.
+1921,"@@ -39,4 +39,14 @@ public interface JmxExecutorManagerMBean {
+
+   @DisplayName(""OPERATION: getPrimaryExecutorHostPorts"")
+   public List<String> getPrimaryExecutorHostPorts();
++
++  @DisplayName(""OPERATION: isQueueProcessorActive"")
++  public boolean isQueueProcessorActive();
++
++  @DisplayName(""OPERATION: getUndispatchedFlows"")
++  public String getUndispatchedFlows();
++
++  @DisplayName(""OPERATION: getQueueProcessorThreadState"")
++  public String getQueueProcessorThreadState();
++
+ }",Is undispatched same as queued? getQueuedFlows?
+1922,"@@ -1,5 +1,5 @@
+ /**
+- * core/site data store: connection info tests.
++ * Core site data store: connection info tests.
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for all similar cases below."
+1923,"@@ -80,13 +80,14 @@ func TestSingleImageImportLoggableBuilder(t *testing.T) {
+ 						uefiBootable:          isUEFIDetectedValue,
+ 						biosBootable:          biosBootableValue,
+ 					},
+-					traceLogs: traceLogs,
++					traceLogs: append(traceLogs, traceLogs...),
+ 				}
+ 				assert.Equal(t, expected, NewSingleImageImportLoggableBuilder().
+ 					SetDiskAttributes(format, sourceGb, targetGb).
+ 					SetUEFIMetrics(isUEFICompatibleImageValue, isUEFIDetectedValue, biosBootableValue, bootFSValue).
+ 					SetInflationAttributes(matchResultValue, inflationTypeValue, inflationTimeValue, shadowInflationTimeValue).
+-					SetTraceLogs(traceLogs).
++					AppendTraceLogs(traceLogs).
++					AppendTraceLogs(traceLogs).
+ 					Build())
+ 			}
+ 		}",Why is this done twice?
+1924,"@@ -55,6 +55,11 @@ func (it *DeadlineReconciler) Reconcile(request reconcile.Request) (reconcile.Re
+ 		return reconcile.Result{}, client.IgnoreNotFound(err)
+ 	}
+
++	if ConditionEqualsTo(node.Status, v1alpha1.ConditionDeadlineExceed, corev1.ConditionTrue) {
++		// if this node deadline is exceed, try propagating to children node
++		return reconcile.Result{}, it.propagateDeadlineToChildren(ctx, &node)
++	}
++
+ 	if node.Spec.Deadline == nil {
+ 		return reconcile.Result{}, nil
+ 	}","This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?"
+1925,"@@ -175,8 +175,8 @@ func TestEnvironment(state *BuildState, target *BuildTarget, testDir string) Bui
+ 	if target.HasLabel(""cc"") {
+ 		env = append(env, ""GCNO_DIR=""+path.Join(RepoRoot, GenDir, target.Label.PackageName))
+ 	}
+-	if state.DebugTests {
+-		env = append(env, ""DEBUG=true"")
++	if state.DebugFailingTests {
++		env = append(env, ""DEBUG_TEST_FAILURE=true"")
+ 	}
+ 	if target.Test.Sandbox && len(state.Config.Sandbox.Dir) > 0 {
+ 		env = append(env, ""SANDBOX_DIRS=""+strings.Join(state.Config.Sandbox.Dir, "",""))",This was renamed to avoid any confusion with the more general case of debugging via `plz debug`
+1926,"@@ -88,9 +88,11 @@ public class Converter {
+   static byte[] convertUtf8ToBytes(Object val, int prefixLength) {
+     requireNonNull(val, ""val is null"");
+     if (val instanceof byte[]) {
+-      return new String((byte[]) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);
++      return new String((byte[]) val).substring(0, Math.min(((byte[]) val).length, prefixLength))
++          .getBytes(StandardCharsets.UTF_8);
+     } else if (val instanceof String) {
+-      return ((String) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);
++      return ((String) val).substring(0, Math.min(((String) val).length(), prefixLength))
++          .getBytes(StandardCharsets.UTF_8);
+     }
+     throw new TypeException(
+         String.format(""Cannot cast %s to bytes"", val.getClass().getSimpleName()));","String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean."
+1927,"@@ -2067,9 +2067,13 @@ CheckedError Parser::ParseEnum(const bool is_union, EnumDef **dest) {
+   const auto strict_ascending = (false == opts.proto_mode);
+   EnumValBuilder evb(*this, *enum_def, strict_ascending);
+   EXPECT('{');
+-  // A lot of code generatos expect that an enum is not-empty.
+-  if ((is_union || Is('}')) && !opts.proto_mode) {
+-    evb.CreateEnumerator(""NONE"");
++  if(is_union && !opts.proto_mode) {
++    // Every union has the NONE field, mapped to a special `void` type.
++    evb.CreateEnumerator(""NONE"", BASE_TYPE_NONE);
++    ECHECK(evb.AcceptEnumerator());
++  } else if (Is('}') && !opts.proto_mode) {
++    // Most code generators expect that an enum is not-empty.
++    evb.CreateEnumerator(""NONE"", 0);
+     ECHECK(evb.AcceptEnumerator());
+   }
+   std::set<std::pair<BaseType, StructDef *>> union_types;","Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`."
+1928,"@@ -38,4 +38,6 @@ public interface Alerter {
+   void alertOnFailedExecutorHealthCheck(Executor executor,
+       List<ExecutableFlow> executions,
+       ExecutorManagerException e, List<String> alertEmails);
++
++  String getAzkabanURL();
+ }","Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed."
+1929,"@@ -316,6 +316,8 @@ class BaseDetector(nn.Module, metaclass=ABCMeta):
+                 i = int(i)
+                 color_mask = color_masks[labels[i]]
+                 mask = segms[i]
++                if mask.dtype != np.bool:
++                    mask = np.array(mask, dtype=bool)
+                 img[mask] = img[mask] * 0.5 + color_mask * 0.5
+         # if out_file specified, do not show image in window
+         if out_file is not None:",The above 3 lines can be written as: `mask = segms[i].astype(bool)`
+1930,"@@ -27,6 +27,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ 	""github.com/iotexproject/iotex-core/protogen/iotexapi""
++	""github.com/iotexproject/iotex-address/address""
+ )
+
+ // Flags",File is not `gofmt`-ed with `-s` (from `gofmt`)
+1931,"@@ -631,7 +631,10 @@ void nano::node::start ()
+ 		{
+ 			network.port = bootstrap.port;
+ 		}
++
++		logger.always_log (boost::str (boost::format (""Node started with peering port `%1%`."") % network.port));
+ 	}
++
+ 	if (!flags.disable_backup)
+ 	{
+ 		backup_wallet ();",Thought it's good to have this logged down so that we can check the used value in the logs.
+1932,"@@ -83,7 +83,8 @@ type AWSMachineSpec struct {
+ // AWSMachineStatus defines the observed state of AWSMachine
+ type AWSMachineStatus struct {
+ 	// Ready is true when the provider resource is ready.
+-	Ready *bool `json:""ready,omitempty""`
++	// +optional
++	Ready bool `json:""ready""`
+
+ 	// Addresses contains the AWS instance associated addresses.
+ 	Addresses []v1.NodeAddress `json:""addresses,omitempty""`",I don't think you can call this optional unless it's a pointer - remove this?
+1933,"@@ -116,6 +116,11 @@ public class OfflineEditFragment extends BaseFragment {
+
+     @OnClick(R.id.buttonSendAll)
+     protected void onSendAllProducts() {
++        List<SendProduct> listSaveProduct = SendProduct.listAll(SendProduct.class);
++        if (listSaveProduct.size() == 0) {
++            Toast.makeText(getActivity(), R.string.txtNoData, Toast.LENGTH_LONG).show();
++            return;
++        }
+         new MaterialDialog.Builder(getActivity())
+                 .title(R.string.txtDialogsTitle)
+                 .content(R.string.txtDialogsContentSend)",@naofum please use `isEmpty`method instead
+1934,"@@ -280,12 +280,12 @@ bool gen_jit_and_run(compile_t* c, int* exit_code, jit_symbol_t* symbols,
+
+   auto resolver = orc::createLambdaResolver(local_lookup, external_lookup);
+ #if PONY_LLVM >= 500
+-  auto maybe_handle = compile_layer.addModule(module, resolver);
++  auto nullable_handle = compile_layer.addModule(module, resolver);
+
+-  if(!maybe_handle)
++  if(!nullable_handle)
+     return false;
+
+-  auto handle = maybe_handle.get();
++  auto handle = nullable_handle.get();
+ #else
+   std::vector<decltype(module)> module_set{module};
+   auto handle = compile_layer.addModuleSet(std::move(module_set), mem_mgr,",i think this is unrelated and needs to be reverted. need to discuss at sync.
+1935,"@@ -19,8 +19,10 @@ import org.hyperledger.besu.datatypes.Hash;
+
+ import java.util.Optional;
+
++import org.apache.tuweni.bytes.Bytes;
++
+ /** A block header capable of being processed. */
+-public class ProcessableBlockHeader {
++public class ProcessableBlockHeader implements org.hyperledger.besu.plugin.data.BlockHeader {
+
+   protected final Hash parentHash;
+ ","Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me."
+1936,"@@ -1372,6 +1372,14 @@ Connection.prototype.setClient = function setClient(client) {
+   return this;
+ };
+
++Connection.prototype.syncIndexes = async function syncIndexes() {
++  const result = [];
++  for (const model in this.models) {
++    result.push(await this.model(model).syncIndexes());
++  }
++  return result;
++};
++
+ /**
+  * Switches to a different database using the same connection pool.
+  *",Love how we can finally use async/await in the codebase.
+1937,"@@ -3531,6 +3531,7 @@ void nano::rpc_handler::wallet_representative_set ()
+ {
+ 	rpc_control_impl ();
+ 	auto wallet (wallet_impl ());
++	bool update_existing_accounts (request.get<bool> (""update_existing_accounts"", false));
+ 	if (!ec)
+ 	{
+ 		std::string representative_text (request.get<std::string> (""representative""));","Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM"
+1938,"@@ -40,10 +40,8 @@ type Connection struct {
+ 	// For invalid and closed connections: StopTime is the time when connection was updated last.
+ 	// For established connections: StopTime is latest time when it was polled.
+ 	StopTime time.Time
+-	// IsActive flag helps in cleaning up connections when they are not in conntrack any module more.
+-	IsActive bool
+-	// DoExport flag helps in tagging connections that can be exported by Flow Exporter
+-	DoExport           bool
++	// IsPresent flag helps in cleaning up connections when they are not in conntrack table anymore.
++	IsPresent          bool
+ 	Zone               uint16
+ 	Mark               uint32
+ 	StatusFlag         uint32",when is this consumed? I'm probably missing it but I can't find it right now
+1939,"@@ -418,6 +418,10 @@ void GroupByAgg::generateCacheKey(CacheWA &cwa) const
+     groupExpr_.rebuildExprTree(ITM_ITEM_LIST);
+   if (grpExpr) {
+     cwa += "" gBy:"";
++
++    if (isRollup())
++      cwa += "" roll:"";
++
+     grpExpr->generateCacheKey(cwa);
+   }
+ }","I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a)."
+1940,"@@ -14,10 +14,15 @@
+  */
+ package com.google.api.codegen.transformer.nodejs;
+
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
++import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",can use `getParamTypeName` instead
+1941,"@@ -184,14 +184,14 @@ class AdminController extends Controller
+     {
+         $this->dispatch(EasyAdminEvents::PRE_EDIT);
+
+-        if ($this->request->isXmlHttpRequest()) {
+-            return $this->ajaxEdit();
+-        }
+-
+         $id = $this->request->query->get('id');
+         $easyadmin = $this->request->attributes->get('easyadmin');
+         $entity = $easyadmin['item'];
+
++        if ($this->request->isXmlHttpRequest() && $this->request->query->has('property')) {
++            return $this->toggleBooleanProperty($entity, $this->request->query->get('property'), $this->request->query->get('newValue'));
++        }
++
+         $fields = $this->entity['edit']['fields'];
+
+         $editForm = $this->executeDynamicMethod('create<EntityName>EditForm', array($entity, $fields));",Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method
+1942,"@@ -186,6 +186,18 @@ class BrowserPage(QWebPage):
+             errpage.encoding = 'utf-8'
+             return True
+
++    def chooseFile(self, parent_frame: QWebFrame, suggested_file: str):
++        """"""Override chooseFiles to (optionally) invoke custom file uploader.""""""
++        handler = config.val.fileselect.handler
++        if handler == ""default"":
++            return super().chooseFile(parent_frame, suggested_file)
++
++        selected_file = shared.choose_file(multiple=False)
++        if selected_file == []:
++            return ''
++        else:
++            return selected_file[0]
++
+     def _handle_multiple_files(self, info, files):
+         """"""Handle uploading of multiple files.
+ ","Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break."
+1943,"@@ -329,6 +329,15 @@ func (e *ETCD) join(ctx context.Context, clientAccessInfo *clientaccess.Info) er
+ 	}
+
+ 	for _, member := range members.Members {
++		memberNodeName := strings.Split(member.Name, ""-"")[0]
++		if memberNodeName == e.config.ServerNodeName {
++			// make sure to remove the name file if a duplicate node name is used
++			nameFile := nameFile(e.config)
++			if err := os.Remove(nameFile); err != nil {
++				return err
++			}
++			return errors.New(""Failed to join etcd cluster due to duplicate node names, please use unique node name for the server"")
++		}
+ 		for _, peer := range member.PeerURLs {
+ 			u, err := url.Parse(peer)
+ 			if err != nil {",How will this code behave with hostnames that contain hyphens?
+1944,"@@ -735,6 +735,15 @@ namespace pwiz.Skyline.Model
+                 moleculeIdKeys.Add(MoleculeAccessionNumbers.TagSMILES, smiles);
+             }
+
++            var keggCol = ColumnIndex(SmallMoleculeTransitionListColumnHeaders.idKEGG);
++            var kegg = NullForEmpty(row.GetCell(keggCol));
++            if (kegg != null)
++            {
++                // Should have form like C07481 but we'll accept anything for now, having no proper parser
++                kegg = kegg.Trim();
++                moleculeIdKeys.Add(MoleculeAccessionNumbers.TagKEGG, kegg);
++            }
++
+             return !moleculeIdKeys.Any()
+                 ? MoleculeAccessionNumbers.EMPTY
+                 : new MoleculeAccessionNumbers(moleculeIdKeys);","I think this is redundant since ""NullForEmpty"" already calls ""Trim()""."
+1945,"@@ -317,6 +317,8 @@ type CloudBackupRestoreRequest struct {
+ }
+
+ type CloudBackupGroupCreateResponse struct {
++	// ID for this group of backups
++	GroupCloudBackupID string
+ 	// Names of the tasks performing this group backup
+ 	Names []string
+ }",Change this to IDs too?
+1946,"@@ -221,6 +221,11 @@ public class RaidsPlugin extends Plugin
+ 	@Getter
+ 	private final List<String> layoutWhitelist = new ArrayList<>();
+
++	@Getter
++	private final ImmutableSet<String> list_of_DC_SCOUT_RAIDS = ImmutableSet.of(
++		""SCPFCCSPCF"", ""CSPFCCCSSF"", ""SCFPCSCPCF"", ""PCSFCPCSCF"", ""SCCFCPSCSF"", ""SCPFCCCSSF"",
++		""SCPFCPCSCF""
++	);
+ 	@Getter
+ 	private Raid raid;
+ ","private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar."
+1947,"@@ -173,7 +173,7 @@ STATIC fpga_result parse_perf_attributes(struct udev_device *dev,
+ 			globfree(&pglob);
+ 			return FPGA_EXCEPTION;
+ 		}
+-		if (fscanf(file, ""%s"", attr_value) != 1) {
++		if (fscanf(file, ""%127s"", attr_value) != 1) {
+ 			OPAE_ERR(""Failed to read %s"", pglob.gl_pathv[i]);
+ 			goto out;
+ 		}",attr_value is 128 bytes?
+1948,"@@ -54,7 +54,9 @@ class HTTPRequest(Request):
+         msg = ""Option 'url' is mandatory for request but not found in %s"" % config
+         self.url = self.config.get(""url"", TaurusConfigError(msg))
+         self.label = self.config.get(""label"", self.url)
+-        self.method = self.config.get(""method"", ""GET"").upper()
++        self.method = self.config.get(""method"", ""GET"")
++        if not has_variable_pattern(self.method):
++            self.method = self.method.upper()
+
+         # TODO: add method to join dicts/lists from scenario/request level?
+         self.headers = self.config.get(""headers"", {})",if it's unpredictable - why uppercase it at all?
+1949,"@@ -25,6 +25,7 @@ type KubeCloudInstTool struct {
+ func (cu *KubeCloudInstTool) InstallTools() error {
+ 	cu.SetOSInterface(GetOSInterface())
+ 	cu.SetKubeEdgeVersion(cu.ToolVersion)
++	fmt.Println(""beforeinstallkubeedge"")
+
+ 	err := cu.InstallKubeEdge()
+ 	if err != nil {",Please remove all these debug prints. It doesn't look good.
+1950,"@@ -74,6 +74,7 @@ type VMContext interface {
+ 	BlockHeight() *types.BlockHeight
+ 	IsFromAccountActor() bool
+ 	Charge(cost types.GasUnits) error
++	SampleChainRandomness(sampleHeight *types.BlockHeight) ([]byte, error)
+
+ 	CreateNewActor(addr address.Address, code cid.Cid, initalizationParams interface{}) error
+ ",Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter.
+1951,"@@ -58,8 +58,14 @@ func GetBackoffForNextSchedule(cronSchedule string, startTime time.Time, closeTi
+ 	if err != nil {
+ 		return NoBackoff
+ 	}
++
++	if closeTime.Before(startTime) {
++		closeTime = startTime
++	}
++
+ 	startUTCTime := startTime.In(time.UTC)
+ 	closeUTCTime := closeTime.In(time.UTC)
++
+ 	nextScheduleTime := schedule.Next(startUTCTime)
+ 	// Calculate the next schedule start time which is nearest to the close time
+ 	for nextScheduleTime.Before(closeUTCTime) {","I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately."
+1952,"@@ -348,6 +348,10 @@ type CloudBackupGenericRequest struct {
+ 	CredentialUUID string
+ 	// All if set to true, backups for all clusters in the cloud are processed
+ 	All bool
++	// StatusFilter indicates backups based on status
++	StatusFilter CloudBackupStatusType
++	// TagFilter indicates backups based on tag
++	TagFilter string
+ }
+
+ type CloudBackupInfo struct {","Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage"
+1953,"@@ -50,9 +50,15 @@ class Summon extends SolrDefault
+      * returned as an array of chunks, increasing from least specific to most
+      * specific.
+      *
++     * @param bool $extended Whether to return a keyed array with the following
++     * keys:
++     * - heading: the actual subject heading chunks
++     * - type: heading type
++     * - source: source vocabulary
++     *
+      * @return array
+      */
+-    public function getAllSubjectHeadings()
++    public function getAllSubjectHeadings($extended = false)
+     {
+         $retval = [];
+         $topic = isset($this->fields['SubjectTerms']) ?","I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names."
+1954,"@@ -261,7 +261,7 @@ public class XCJFQuery extends Query {
+     }
+
+     private DocSet getDocSet() throws IOException {
+-      SolrClientCache solrClientCache = new SolrClientCache();
++      SolrClientCache solrClientCache = searcher.getCore().getCoreContainer().getSolrClientCache();
+       TupleStream solrStream;
+       if (zkHost != null || solrUrl == null) {
+         solrStream = createCloudSolrStream(solrClientCache);",Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?
+1955,"@@ -38,6 +38,9 @@ type (
+ 	ClusterMetadataRow struct {
+ 		ImmutableData         []byte
+ 		ImmutableDataEncoding string
++		Data                  []byte
++		DataEncoding          string
++		Version               int64
+ 	}
+
+ 	// ClusterMembershipRow represents a row in the cluster_membership table",according to the PR (schema changes?) these 2 field should be removed?
+1956,"@@ -373,16 +373,13 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo, kubeCli client.Cli
+ 					Mode:     v1alpha1.PodMode(exp.Scope.Mode),
+ 					Value:    exp.Scope.Value,
+ 				},
++				ContainerNames: exp.Target.StressChaos.ContainerNames,
+ 			},
+ 			Stressors:         stressors,
+ 			StressngStressors: exp.Target.StressChaos.StressngStressors,
+ 		},
+ 	}
+
+-	if exp.Target.StressChaos.ContainerName != nil {
+-		chaos.Spec.ContainerNames = []string{*exp.Target.StressChaos.ContainerName}
+-	}
+-
+ 	if exp.Scheduler.Duration != """" {
+ 		chaos.Spec.Duration = &exp.Scheduler.Duration
+ 	}",Panic here if `exp.Target.StressChaos.CintainerName` is nil.
+1957,"@@ -93,4 +93,16 @@ public interface LeafCollector {
+    */
+   void collect(int doc) throws IOException;
+
++  /**
++   * Optionally creates a view of the scorerIterator where only competitive documents
++   * in the scorerIterator are kept and non-competitive are skipped.
++   *
++   * Collectors should delegate this method to their comparators if
++   * their comparators provide the skipping functionality over non-competitive docs.
++   * The default is to return the same iterator which is interpreted as the collector doesn't filter any documents.
++   */
++  default DocIdSetIterator filterIterator(DocIdSetIterator scorerIterator) {
++    return scorerIterator;
++  }
++
+ }",This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better.
+1958,"@@ -227,6 +227,7 @@ public class IcebergInputFormat<T> extends InputFormat<Void, T> {
+
+     private CloseableIterable<T> open(FileScanTask currentTask, Schema readSchema) {
+       DataFile file = currentTask.file();
++      LOG.debug(""Opening [{}] for read"", file);
+       // TODO we should make use of FileIO to create inputFile
+       InputFile inputFile = HadoopInputFile.fromLocation(file.path(), context.getConfiguration());
+       CloseableIterable<T> iterable;",Aren't there already logs for this from the underlying file system implementation?
+1959,"@@ -75,7 +75,7 @@ class SearchHandlerTest extends TestCase
+     {
+         $spec = ['DismaxParams' => [['foo', 'bar'], ['mm', '100%']], 'DismaxFields' => ['field1', 'field2']];
+         $hndl = new SearchHandler($spec);
+-        $defaults = ['CustomMunge' => [], 'DismaxHandler' => 'dismax', 'QueryFields' => [], 'FilterQuery' => []];
++        $defaults = ['CustomMunge' => [], 'DismaxHandler' => 'dismax', 'QueryFields' => [], 'FilterQuery' => [], 'DismaxMunge' => []];
+         $this->assertEquals($spec + $defaults, $hndl->toArray());
+     }
+ ",It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how.
+1960,"@@ -62,6 +62,9 @@ class kubernetes(luigi.Config):
+     kubernetes_namespace = luigi.OptionalParameter(
+         default=None,
+         description=""K8s namespace in which the job will run"")
++    max_retrials_to_get_pods = luigi.IntParameter(
++        default=0,
++        description=""Max retrials to get pods' informations"")
+
+
+ class KubernetesJobTask(luigi.Task):","`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?"
+1961,"@@ -213,6 +213,7 @@ class Shopware6ChannelForm extends AbstractType
+                 AttributeIdType::class,
+                 [
+                     'label' => 'Attribute Product Meta Title',
++                    'help' => 'Value in product it should contain 255 characters or less.',
+                     'choices' => array_flip($textareaAttributeDictionary),
+                     'property_path' => 'attributeProductMetaTitle',
+                     'required' => false,",Value in product should contain 255 characters or less.
+1962,"@@ -169,12 +169,12 @@ func main() {
+ 				logger.Error().Msg(fmt.Sprintf(""Node %d: Can not get State height"", i))
+ 			}
+ 			bcHeights[i] = chains[i].TipHeight()
+-			minTimeout = int(configs[i].Consensus.RollDPoS.Delay/time.Second - configs[i].Consensus.RollDPoS.ProposerInterval/time.Second)
++			minTimeout = int(configs[i].Consensus.RollDPoS.Delay/time.Second - configs[i].Consensus.RollDPoS.FSM.ProposerInterval/time.Second)
+ 			netTimeout = 0
+ 			if timeout > minTimeout {
+ 				netTimeout = timeout - minTimeout
+ 			}
+-			idealHeight[i] = uint64((time.Duration(netTimeout) * time.Second) / configs[i].Consensus.RollDPoS.ProposerInterval)
++			idealHeight[i] = uint64((time.Duration(netTimeout) * time.Second) / configs[i].Consensus.RollDPoS.FSM.ProposerInterval)
+
+ 			logger.Info().Msg(fmt.Sprintf(""Node#%d blockchain height: %d"", i, bcHeights[i]))
+ 			logger.Info().Msg(fmt.Sprintf(""Node#%d state      height: %d"", i, stateHeights[i]))",line is 133 characters (from `lll`)
+1963,"@@ -78,7 +78,7 @@ module RSpec
+       end
+
+       def file_options
+-        custom_options_file ? [custom_options] : [global_options, local_options]
++        custom_options_file ? [custom_options] : [global_options, local_options, personal_options]
+       end
+
+       def env_options","since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?"
+1964,"@@ -52,7 +52,7 @@ module Blacklight::Solr
+     protected
+
+       def build_connection
+-        RSolr.connect(connection_config)
++        RSolr.connect(connection_config.merge(adapter: connection_config[:http_adapter]))
+       end
+   end
+ end",Will we want to refactor this when we drop rsolr 1.x support?
+1965,"@@ -63,7 +63,7 @@ func Request(path string, info *clientaccess.Info, requester HTTPRequester) ([]b
+ 	return requester(u.String(), clientaccess.GetHTTPClient(info.CACerts), username, password)
+ }
+
+-func getNodeNamedCrt(nodeName, nodePasswordFile string) HTTPRequester {
++func getNodeNamedCrt(nodeName, nodeIP, nodePasswordFile string) HTTPRequester {
+ 	return func(u string, client *http.Client, username, password string) ([]byte, error) {
+ 		req, err := http.NewRequest(http.MethodGet, u, nil)
+ 		if err != nil {",should this really be multiple IPs?
+1966,"@@ -0,0 +1 @@
++<%= render partial: ""proposal"", locals: { proposal: @proposal}  %>","Hmm, is that partial used in multiple places? Maybe we can just move that file in here."
+1967,"@@ -0,0 +1,16 @@
++// Copyright 2014-2015 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package async
++
++//go:generate mockgen.sh github.com/aws/amazon-ecs-agent/agent/async Cache mocks/async_mocks.go",Should be 2014-2016
+1968,"@@ -1976,6 +1976,11 @@ namespace pwiz.Skyline.Model
+         private static Type GetColumnType(string value, IFormatProvider provider)
+         {
+             double result;
++            var quote = @"""""""";
++            if (value.StartsWith(quote) && value.EndsWith(quote))
++            {
++                value = value.Substring(1, value.Length - 2);
++            }
+             if (double.TryParse(value, NumberStyles.Number, provider, out result))
+                 return typeof(double);
+             else if (FastaSequence.IsExSequence(value))","Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields."
+1969,"@@ -2733,6 +2733,7 @@ describe('Find', function() {
+               cursors[0].next(function(err) {
+                 test.equal(null, err);
+
++                cursors[0].close();
+                 client.close();
+                 done();
+               });","similarly here, are the these cursors not being closed when the client is closed?"
+1970,"@@ -22,7 +22,7 @@ import (
+ )
+
+ var (
+-	supportedPolicies = make(map[string]func() Policy)
++	supportedPolicies = make(map[string]func(string) Policy)
+ )
+
+ type staticUpstream struct {",Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args.
+1971,"@@ -36,6 +36,7 @@ func serviceLoggedIn(ctx context.Context, config Config, session SessionInfo,
+ 			log.CWarningf(ctx,
+ 				""Failed to enable existing journals: %v"", err)
+ 		}
++		jServer.MakeFBOsForExistingJournals(ctx)
+ 	}
+ 	err := config.MakeDiskBlockCacheIfNotExists()
+ 	if err != nil {",Should this happen even if the above failed?
+1972,"@@ -1,5 +1,5 @@
+ /*
+-Copyright 2017 The OpenEBS Authors.
++Copyright 2018 The OpenEBS Authors.
+
+ Licensed under the Apache License, Version 2.0 (the ""License"");
+ you may not use this file except in compliance with the License.",Please dont change this .
+1973,"@@ -382,7 +382,7 @@ void nano::active_transactions::cleanup_election (nano::unique_lock<nano::mutex>
+ 			node.network.publish_filter.clear (block);
+ 		}
+ 	}
+-	node.logger.try_log (boost::str (boost::format (""Election erased for root %1%"") % election.qualified_root.to_string ()));
++	node.logger.try_log (boost::str (boost::format (""Election erased for root %1%, confirmed: %2$b"") % election.qualified_root.to_string () % election.confirmed ()));
+ }
+
+ std::vector<std::shared_ptr<nano::election>> nano::active_transactions::list_active (std::size_t max_a)",There is a strange $b that looks wrong.
+1974,"@@ -1166,12 +1166,16 @@ def getControlFieldSpeech(attrs,ancestorAttrs,fieldType,formatConfig=None,extraD
+ 	# speakStatesFirst: Speak the states before the role.
+ 	speakStatesFirst=role==controlTypes.ROLE_LINK
+
++	containerContainsText="""" #: used for item counts for lists
++
+ 	# Determine what text to speak.
+ 	# Special cases
+ 	if speakEntry and childControlCount and fieldType==""start_addedToControlFieldStack"" and role==controlTypes.ROLE_LIST and controlTypes.STATE_READONLY in states:
+ 		# List.
+-		# Translators: Speaks number of items in a list (example output: list with 5 items).
+-		return roleText+"" ""+_(""with %s items"")%childControlCount
++		# #7652: containerContainsText variable is set here, but the actual generation of all other output is handled further down in the general cases section.
++		# This ensures that properties such as name, states and level etc still get reported appropriately.
++		# Translators: Number of items in a list (example output: list with 5 items).
++		containerContainsText=_(""with %s items"")%childControlCount
+ 	elif fieldType==""start_addedToControlFieldStack"" and role==controlTypes.ROLE_TABLE and tableID:
+ 		# Table.
+ 		return "" "".join((nameText,roleText,stateText, getSpeechTextForProperties(_tableID=tableID, rowCount=attrs.get(""table-rowcount""), columnCount=attrs.get(""table-columncount"")),levelText))","Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the ""General"" section."
+1975,"@@ -18,6 +18,7 @@ module Travis
+           CLEANUPS.each do |find_arg|
+             sh.raw ""find #{find_arg[:directory]} -name #{find_arg[:glob]} -delete 2>/dev/null""
+           end
++          sh.export 'PATH', '$JAVA_HOME:$PATH'
+         end
+
+         def install","It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added."
+1976,"@@ -9,6 +9,7 @@ bool generate_uuid(char out[static 37]) {
+ 	return true;
+ }
+ #else
++#include <assert.h>
+ #include <string.h>
+ #include <stdlib.h>
+ ",Should move this to within the `#else` block as it's only used there.
+1977,"@@ -41,6 +41,9 @@ class ProductListPage extends AbstractPage
+         $context = $this->getProductListCompomentContext();
+
+         $this->productListComponent->addProductToCartByName($productName, $quantity, $context);
++
++        $this->tester->waitForAjax();
++        $this->tester->wait(1);
+     }
+
+     /**",is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method.
+1978,"@@ -94,8 +94,8 @@ abstract class AbstractSolrTask extends AbstractTask {
+     public function __sleep()
+     {
+         $properties = get_object_vars($this);
+-        // avoid serialization if the site object
+-        unset($properties['site']);
++        // avoid serialization if the site and logger object
++        unset($properties['site'], $properties['logger']);
+         return array_keys($properties);
+     }
+-}
++}","Maybe you can correct the typo ""if"" too :)"
+1979,"@@ -298,6 +298,9 @@ type KeybaseService interface {
+ 	// popups spawned.
+ 	Identify(ctx context.Context, assertion, reason string) (UserInfo, error)
+
++	IdentifyForChat(ctx context.Context, assertion, reason string) (
++		UserInfo, *keybase1.IdentifyTrackBreaks, error)
++
+ 	// LoadUserPlusKeys returns a UserInfo struct for a
+ 	// user with the specified UID.
+ 	// If you have the UID for a user and don't require Identify to","I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?"
+1980,"@@ -51,10 +51,18 @@ public:
+      */
+     bool load(handle src, bool)
+     {
++        // Import mpi4py if it does not exist.
++        if (!PyMPIComm_Get)
++        {
++            if (import_mpi4py() < 0)
++            {
++                throw std::runtime_error(
++                        ""ERROR: mpi4py not loaded correctly\n""); /* Python 2.X */
++            }
++        }
+         // If src is not actually a MPI4PY communicator, the next
+         // call returns nullptr, and we return false to indicate the conversion
+         // failed.
+-
+         MPI_Comm *mpiCommPtr = PyMPIComm_Get(src.ptr());
+         if (mpiCommPtr == nullptr)
+         {","I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?"
+1981,"@@ -142,13 +142,14 @@ func (cache *httpCache) retrieve(target *core.BuildTarget, key []byte) (bool, er
+ 	resp, err := cache.client.Do(req)
+ 	if err != nil {
+ 		return false, err
+-	} else if resp.StatusCode == http.StatusNotFound {
++	}
++	defer resp.Body.Close()
++	if resp.StatusCode == http.StatusNotFound {
+ 		return false, nil // doesn't exist - not an error
+ 	} else if resp.StatusCode != http.StatusOK {
+ 		b, _ := ioutil.ReadAll(resp.Body)
+ 		return false, fmt.Errorf(""%s"", string(b))
+ 	}
+-	defer resp.Body.Close()
+ 	gzr, err := gzip.NewReader(resp.Body)
+ 	if err != nil {
+ 		return false, err",This seems like a more interesting change. Maybe we should re-name the PR
+1982,"@@ -20,6 +20,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal
+                                                IApplicationTransportFeature,
+                                                ITransportSchedulerFeature,
+                                                IConnectionLifetimeFeature,
++                                               IConnectionHeartbeatFeature,
++                                               IConnectionLifetimeNotificationFeature,
+                                                IBytesWrittenFeature
+     {
+         // NOTE: When feature interfaces are added to or removed from this TransportConnection class implementation,",Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough.
+1983,"@@ -102,6 +102,7 @@ public class CSharpCommonTransformer {
+         .typeName(typeName)
+         .setCallName("""")
+         .addCallName("""")
++        .getCallName("""")
+         .isMap(false)
+         .isArray(false)
+         .isPrimitive(false)","Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags."
+1984,"@@ -444,6 +444,7 @@ ExWorkProcRetcode ExHbaseScanSQTaskTcb::work(short &rc)
+   Lng32 retcode = 0;
+   rc = 0;
+   Lng32 remainingInBatch = batchSize_;
++  NABoolean isFirstBatch = false;
+
+   while (1)
+     {","Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?"
+1985,"@@ -116,6 +116,14 @@ nebula::cpp2::HostAddr MetaServiceUtils::parseHostKey(folly::StringPiece key) {
+     return host;
+ }
+
++std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) {
++    std::string key;
++    key.reserve(kEdgesTable.size() + sizeof(GraphSpaceID));
++    key.append(kEdgesTable.data(), kEdgesTable.size());
++    key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
++    return key;
++}
++
+ std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId,
+                                             EdgeType edgeType,
+                                             int64_t version) {",You could reserve a const space to save the extra computation.
+1986,"@@ -15,6 +15,8 @@ namespace System.IO.Tests
+         private readonly string _testPath200 = PerfUtils.CreateString(200);
+         private readonly string _testPath500 = PerfUtils.CreateString(500);
+         private readonly string _testPath1000 = PerfUtils.CreateString(1000);
++        private readonly string _testPathNoRedundantSegments = ""/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/Path.cs"";
++        private readonly string _testPathWithRedundantSegments = ""/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/..//./Path.cs"";
+
+         [Benchmark]
+         public string Combine() => Path.Combine(_testPath, _testPath10);",Did you consider adding rooted paths like `C:\ProgramData` and paths with flipped separators?
+1987,"@@ -93,10 +93,11 @@ func startDnsServer() {
+ 		Port: 53,
+ 	}
+ 	udpConn, err := net.ListenUDP(""udp"", laddr)
+-	defer udpConn.Close()
+ 	if err != nil {
+ 		klog.Errorf(""Dns server Start error : %s"", err)
++		return
+ 	}
++	defer udpConn.Close()
+ 	dnsConn = udpConn
+ 	for {
+ 		req := make([]byte, bufSize)",does this line cause a panic if it is above the if condition ?
+1988,"@@ -0,0 +1,5 @@
++package org.phoenicis.javafx.components.library.utils;
++
++public enum LibraryDetailsPanels {
++    ShortcutDetails, ShortcutCreation, ShortcutEditing, Closed;
++}",Maybe `LibraryDetailsPanelType` would be clearer.
+1989,"@@ -149,7 +149,6 @@ static void runlevel_cb (runlevel_t *r, int level, int rc, double elapsed,
+ static void runlevel_io_cb (runlevel_t *r, const char *name,
+                             const char *msg, void *arg);
+
+-static int create_persistdir (attr_t *attrs, uint32_t rank);
+ static int create_rundir (attr_t *attrs);
+ static int create_broker_rundir (overlay_t *ov, void *arg);
+ static int create_dummyattrs (flux_t *h, uint32_t rank, uint32_t size);","minor nit - add ""persist-filesystem"" and ""persist-directory"" into commit message, as its something people may search on (maybe applies to a few other commit messages)"
+1990,"@@ -7662,8 +7662,6 @@ bool CoreChecks::ValidateEventStageMask(const ValidationStateTracker *state_data
+     return skip;
+ }
+
+-static const VkQueueFlagBits kQueueTypeArray[] = {VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT, VK_QUEUE_TRANSFER_BIT};
+-
+ bool CoreChecks::CheckStageMaskQueueCompatibility(VkCommandBuffer command_buffer, VkPipelineStageFlags stage_mask,
+                                                   VkQueueFlags queue_flags, const char *function, const char *src_or_dest,
+                                                   const char *error_code) const {",I verified offline with @jeremyg-lunarg this should be removed.
+1991,"@@ -65,6 +65,7 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) DError {
+ 	i.Workflow.Logger = i.Workflow.parent.Logger
+ 	i.Workflow.Name = s.name
+ 	i.Workflow.DefaultTimeout = s.Timeout
++	fmt.Println(""incldued_wf name:"", i.Workflow.Name, "" timeout:"", i.Workflow.DefaultTimeout)
+
+ 	var errs DError
+ Loop:","This should be removed? If not, typo in incldued_wf"
+1992,"@@ -19,6 +19,7 @@ export const variant = ({
+
+ export default variant
+
+-export const buttonStyle = variant({ key: 'buttons' })
++export const buttonStyle =
++  variant({ key: 'buttons' }) || variant({ key: 'buttonStyles' })
+ export const textStyle = variant({ key: 'textStyles', prop: 'textStyle' })
+ export const colorStyle = variant({ key: 'colorStyles', prop: 'colors' })","Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work   I might be missing something, but are the tests all passing locally?"
+1993,"@@ -68,6 +68,15 @@ type MatchFile struct {
+ 	//
+ 	// Default is first_exist.
+ 	TryPolicy string `json:""try_policy,omitempty""`
++
++	// A list of delimiters to use to split the path in two
++	// when trying files. If empty, no splitting will
++	// occur, and the path will be tried as-is. For each
++	// split value, the left-hand side of the split,
++	// including the split value, will be the path tried.
++	// For example, the path `/remote.php/dav/` using the
++	// split value `.php` would try the file `/remote.php`.
++	SplitPath []string `json:""split_path,omitempty""`
+ }
+
+ // CaddyModule returns the Caddy module information.",Do you think the godoc should mention that all delimiters will be suffixed with `/`?
+1994,"@@ -111,6 +111,8 @@ public class NavigationURLBar extends FrameLayout {
+                 return;
+             else if (aURL.startsWith(""resource:"") || SessionStore.get().isHomeUri(aURL))
+                 aURL = """";
++            else if (aURL.startsWith(""data:"") && SessionStore.get().isCurrentSessionPrivate())
++                aURL = SessionStore.PRIVATE_BROWSING_URI;
+             else
+                 index = aURL.indexOf(""://"");
+         }","what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,&times;`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug."
+1995,"@@ -312,6 +312,7 @@ class DeleteFileIndex {
+   static class Builder {
+     private final FileIO io;
+     private final Set<ManifestFile> deleteManifests;
++    private long minSequenceNumber = 0L;
+     private Map<Integer, PartitionSpec> specsById = null;
+     private Expression dataFilter = Expressions.alwaysTrue();
+     private Expression partitionFilter = Expressions.alwaysTrue();","I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct."
+1996,"@@ -68,7 +68,7 @@ public class ImageVersionDaoImpl implements ImageVersionDao {
+           + ""values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"";
+   private static final String SELECT_IMAGE_VERSION_BASE_QUERY =
+       ""select iv.id, iv.path, iv.description, ""
+-          + ""iv.version, cast(replace(iv.version, '.', '') as unsigned integer) as int_version, ""
++          + ""iv.version, cast(replace(iv.version, '.', '') as integer) as int_version, ""
+           + ""it.name, iv.state, iv.release_tag, iv.created_on, iv.created_by, iv.modified_on, ""
+           + ""iv.modified_by from image_versions iv, image_types it where it.id = iv.type_id"";
+   /**",For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing.
+1997,"@@ -57,6 +57,8 @@ const defaultState = {
+ 	editorNoteStatuses: {},
+ };
+
++const MAX_HISTORY = 200;
++
+ const stateUtils = {};
+
+ const derivedStateCache_ = {};",Are there tests for this? What happens when you get to limit?
+1998,"@@ -174,7 +174,7 @@ module Bolt
+         data['config'] = {}
+       end
+
+-      unless Bolt::Util.windows? || data['config']['transport']
++      unless data['config']['transport']
+         data['config']['transport'] = 'local' if target.name == 'localhost'
+       end
+ ",Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`.
+1999,"@@ -73,6 +73,15 @@ public class OpenPgpKeyPreference extends Preference {
+
+     @Override
+     protected void onClick() {
++        bindServiceAndGetSignKeyId(new Intent());
++    }
++
++    private void bindServiceAndGetSignKeyId(final Intent data) {
++        if (mServiceConnection != null) {
++            getSignKeyId(data);
++            return;
++        }
++
+         // bind to service
+         mServiceConnection = new OpenPgpServiceConnection(
+                 getContext().getApplicationContext(),","maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die"
+2000,"@@ -61,5 +61,6 @@ namespace Nethermind.Core.Specs.Forks
+         public bool IsEip1052Enabled => true;
+         public bool IsEip1283Enabled => false;
+         public bool IsEip1234Enabled => true;
++        public bool IsEip1344Enabled => false;
+     }
+ }",Can we add Istanbul with this first EIP please? (or as a separate issue)
+2001,"@@ -71,10 +71,10 @@ func (sn Snapshot) ID() backend.ID {
+ func (sn *Snapshot) fillUserInfo() error {
+ 	usr, err := user.Current()
+ 	if err != nil {
+-		return err
++		return nil
+ 	}
+-
+ 	sn.Username = usr.Username
++
+ 	uid, err := strconv.ParseInt(usr.Uid, 10, 32)
+ 	if err != nil {
+ 		return err",I don't understand this change
+2002,"@@ -2248,7 +2248,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, PrintError):
+             encrypted_e.setText(encrypted.decode('ascii'))
+         except BaseException as e:
+             traceback.print_exc(file=sys.stdout)
+-            self.show_warning(str(e))
++            self.show_warning(""Invalid Public key"")
+
+     def encrypt_message(self, address=''):
+         d = WindowModalDialog(self, _('Encrypt/decrypt Message'))",Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`
+2003,"@@ -0,0 +1,13 @@
++var landmarks = axe.commons.aria.getRolesByType('landmark');
++var parent = axe.commons.dom.getComposedParent(node);
++while (parent){
++	var role = parent.getAttribute('role');
++	if (!role && (parent.tagName.toLowerCase() !== 'form')){
++		role = axe.commons.aria.implicitRole(parent);
++	}
++	if (role && landmarks.includes(role)){
++		return false;
++	}
++	parent = axe.commons.dom.getComposedParent(parent);
++}
++return true;",This needs to work with `role=form` too.
+2004,"@@ -1039,6 +1039,11 @@ Blockly.BlockSvg.prototype.handleDragFree_ = function(oldXY, newXY, e) {
+     }
+   }
+
++  // Always update previews for output connections.
++  if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {
++    updatePreviews = true;
++  }
++
+   if (updatePreviews) {
+     var candidateIsLast = (localConnection == lastOnStack);
+     this.updatePreviews(closestConnection, localConnection, radiusConnection,","This should be before the if on line 1028, which should turn into an else if"
+2005,"@@ -27,6 +27,13 @@ type ClusterNetworkPolicySpecBuilder struct {
+ 	Name string
+ }
+
++type ACNPRuleAppliedToSpec struct {
++	PodSelector         map[string]string
++	NSSelector          map[string]string
++	PodSelectorMatchExp *[]metav1.LabelSelectorRequirement
++	NSSelectorMatchExp  *[]metav1.LabelSelectorRequirement
++}
++
+ func (b *ClusterNetworkPolicySpecBuilder) Get() *secv1alpha1.ClusterNetworkPolicy {
+ 	if b.Spec.Ingress == nil {
+ 		b.Spec.Ingress = []secv1alpha1.Rule{}","Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?"
+2006,"@@ -98,10 +98,10 @@ func (r *RTTStats) UpdateRTT(sendDelta, ackDelay time.Duration, now time.Time) {
+ 	r.updateRecentMinRTT(sendDelta, now)
+
+ 	// Correct for ackDelay if information received from the peer results in a
+-	// positive RTT sample. Otherwise, we use the sendDelta as a reasonable
+-	// measure for smoothedRTT.
++	// an RTT sample at least as large as minRTT. Otherwise, only use the
++	// sendDelta.
+ 	sample := sendDelta
+-	if sample > ackDelay {
++	if sample-r.minRTT >= ackDelay {
+ 		sample -= ackDelay
+ 	}
+ 	r.latestRTT = sample","Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?"
+2007,"@@ -10,8 +10,8 @@ namespace Microsoft.CodeAnalysis.Sarif
+     /// <summary>
+     /// Defines methods to support the comparison of objects of type SarifLog for equality.
+     /// </summary>
+-    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.31.0.0"")]
+-    public sealed class SarifLogEqualityComparer : IEqualityComparer<SarifLog>
++    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.32.0.0"")]
++    internal sealed class SarifLogEqualityComparer : IEqualityComparer<SarifLog>
+     {
+         internal static readonly SarifLogEqualityComparer Instance = new SarifLogEqualityComparer();
+ ","Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one."
+2008,"@@ -19,6 +19,10 @@ class GuidancePolicy < ApplicationPolicy
+     user.can_modify_guidance? && guidance.in_group_belonging_to?(user.org_id)
+   end
+
++  def index?
++    admin_index?
++  end
++
+   def admin_index?
+     user.can_modify_guidance?
+   end",nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies
+2009,"@@ -612,3 +612,14 @@ TEST_F(BadPonyTest, FieldReferenceInDefaultArgument)
+
+   TEST_ERRORS_1(src, ""can't reference 'this' in a default argument"");
+ }
++
++
++TEST_F(BadPonyTest, DefaultArgScope)
++{
++  const char* src =
++    ""actor A\n""
++    ""  fun foo(x: None = (let y = None; y)) =>\n""
++    ""    y"";
++
++  TEST_ERRORS_1(src, ""can't find declaration of 'y'"");
++}","Small formatting thing, but can you remove the space before the semicolon?"
+2010,"@@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+
+             var reading = Task.Run(async () =>
+             {
+-                int remaining = InnerLoopCount * _writeLenght;
++                long remaining = InnerLoopCount * _writeLenght;
+                 while (remaining != 0)
+                 {
+                     var result = await _pipe.Reader.ReadAsync();","Not new, but nit: _writeLeng*th*."
+2011,"@@ -133,6 +133,13 @@ func TestComposeCmd(t *testing.T) {
+ 	assert.Error(err)
+ }
+
++func TestCheckCompose(t *testing.T) {
++	assert := asrt.New(t)
++
++	err := CheckDockerCompose()
++	assert.NoError(err)
++}
++
+ func TestGetAppContainers(t *testing.T) {
+ 	assert := asrt.New(t)
+ 	sites, err := GetAppContainers(""dockertest"")","Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions."
+2012,"@@ -3,11 +3,12 @@ package volume
+ import (
+ 	""crypto/tls""
+ 	""encoding/json""
+-	""github.com/libopenstorage/openstorage/api""
+-	""github.com/stretchr/testify/require""
+ 	""net/http""
+ 	""net/http/httptest""
+ 	""testing""
++
++	""github.com/libopenstorage/openstorage/api""
++	""github.com/stretchr/testify/require""
+ )
+
+ func TestClientTLS(t *testing.T) {",Remove this file from the PR
+2013,"@@ -488,7 +488,7 @@ Blockly.Variables.renameVariable = function(workspace, variable,
+   var validate = Blockly.Variables.nameValidator_.bind(null, varType);
+
+   var promptText = promptMsg.replace('%1', variable.name);
+-  Blockly.prompt(promptText, '',
++  Blockly.prompt(promptText, variable.name,
+       function(newName, additionalVars) {
+         if (variable.isCloud &&
+             newName.length > 0 && newName.indexOf(Blockly.Variables.CLOUD_PREFIX) == 0 ) {","I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:"
+2014,"@@ -16,7 +16,8 @@ struct wlr_pointer *create_libinput_pointer(
+ 		wlr_log(WLR_ERROR, ""Unable to allocate wlr_pointer"");
+ 		return NULL;
+ 	}
+-	wlr_pointer_init(wlr_pointer, NULL);
++	wlr_pointer_init(wlr_pointer, NULL,
++		libinput_device_config_tap_get_finger_count(libinput_dev) > 0);
+ 	return wlr_pointer;
+ }
+ ",I think I would rather fish this interface through than use it as the basis for heuristics.
+2015,"@@ -153,7 +153,7 @@ namespace pwiz.Skyline.Controls.Graphs
+             public static float QValueCutoff
+             {
+                 get => Properties.Settings.Default.DetectionsQValueCutoff;
+-                set => Properties.Settings.Default.DetectionsQValueCutoff = value;
++                set => Properties.Settings.Default.DetectionsQValueCutoff = value;
+             }
+
+             public static TargetType TargetType","Probably not worth making this line-ending change, since it is the only change to this file."
+2016,"@@ -1180,8 +1180,13 @@ encode_opnd_x0(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ static inline bool
+ decode_opnd_memx0(uint enc, int opcode, byte *pc, OUT opnd_t *opnd)
+ {
++#ifdef DR_HOST_NOT_TARGET
++    CLIENT_ASSERT(opnd_size_in_bytes(OPSZ_CACHE_LINE) == 64, ""OPSZ_CACHE_LINE != 64"");
++#endif
+     *opnd = opnd_create_base_disp(decode_reg(extract_uint(enc, 0, 5), true, false),
+-                                  DR_REG_NULL, 0, 0, OPSZ_sys);
++                                  DR_REG_NULL, 0, 0, OPSZ_CACHE_LINE);
++    if (!opnd_set_base_aligned(opnd, true))
++        return false;
+     return true;
+ }
+ ","Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?"
+2017,"@@ -3,7 +3,7 @@ package hardware
+ import (
+ 	""github.com/shirou/gopsutil/mem""
+ 	""github.com/sonm-io/core/insonmnia/hardware/cpu""
+-	""github.com/sonm-io/core/insonmnia/hardware/gpu""
++	pb ""github.com/sonm-io/core/proto""
+ )
+
+ // Hardware accumulates the finest hardware information about system the miner",No pb please
+2018,"@@ -0,0 +1,11 @@
++require 'migrate'
++class AddJoinTableBetweenUsersAndChangesets < ActiveRecord::Migration
++  def change
++    create_table :changesets_subscribers, id: false do |t|
++      t.column :subscriber_id, :bigint, null: false
++      t.column :changeset_id, :bigint, null: false
++    end
++    add_foreign_key :changesets_subscribers, [:subscriber_id], :users, [:id]
++    add_foreign_key :changesets_subscribers, [:changeset_id], :changesets, [:id]
++  end
++end","We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset."
+2019,"@@ -0,0 +1,13 @@
++package slackbot
++
++import (
++	""github.com/slack-go/slack""
++)
++
++func sendBotReply(client *slack.Client, channel, message string) error {
++	_, _, err := client.PostMessage(channel, slack.MsgOptionText(message, false))
++	if err != nil {
++		return err
++	}
++	return nil
++}","use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on."
+2020,"@@ -64,9 +64,7 @@ def implements(
+     obj: ""BaseChecker"",
+     interface: Union[Type[""Interface""], Tuple[Type[""Interface""], ...]],
+ ) -> bool:
+-    """"""Return whether the given object (maybe an instance or class) implements
+-    the interface.
+-    """"""
++    """"""Does the given object (maybe an instance or class) implements the interface.""""""
+     kimplements = getattr(obj, ""__implements__"", ())
+     if not isinstance(kimplements, (list, tuple)):
+         kimplements = (kimplements,)","""not to be used elsewhere other than"""
+2021,"@@ -205,6 +205,7 @@ class SparkAppenderFactory implements FileAppenderFactory<InternalRow> {
+         case PARQUET:
+           return Parquet.writeDeletes(file.encryptingOutputFile())
+               .createWriterFunc(msgType -> SparkParquetWriters.buildWriter(lazyEqDeleteSparkType(), msgType))
++              .setAll(properties)
+               .overwrite()
+               .rowSchema(eqDeleteRowSchema)
+               .withSpec(spec)","Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ..."
+2022,"@@ -0,0 +1,7 @@
++class AddIndexToSubscriptions < ActiveRecord::Migration
++  def change
++    add_index :subscriptions, :user_id
++    add_index :subscriptions, :team_id
++    add_index :subscriptions, [:plan_id, :plan_type]
++  end
++end",These additions seem unrelated to this change?
+2023,"@@ -126,4 +126,8 @@ public class TableProperties {
+
+   public static final String SNAPSHOT_ID_INHERITANCE_ENABLED = ""compatibility.snapshot-id-inheritance.enabled"";
+   public static final boolean SNAPSHOT_ID_INHERITANCE_ENABLED_DEFAULT = false;
++
++  public static final String ENGINE_HIVE_ENABLED = ""engine.hive.enabled"";
++  public static final String ENGINE_HIVE_ENABLED_HIVE_CONF = ""iceberg.engine.hive.enabled"";
++  public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+ }","Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?"
+2024,"@@ -95,19 +95,6 @@ func (r *ChaosCollector) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
+ 		manageFlag = true
+ 	}
+
+-	if obj.IsDeleted() {
+-		if !manageFlag {
+-			if err = r.archiveExperiment(req.Namespace, req.Name); err != nil {
+-				r.Log.Error(err, ""failed to archive experiment"")
+-			}
+-		} else {
+-			if err = r.event.DeleteByUID(ctx, string(chaosMeta.GetUID())); err != nil {
+-				r.Log.Error(err, ""failed to delete experiment related events"")
+-			}
+-		}
+-		return ctrl.Result{}, nil
+-	}
+-
+ 	if err := r.setUnarchivedExperiment(req, obj); err != nil {
+ 		r.Log.Error(err, ""failed to archive experiment"")
+ 		// ignore error here",The related statements should also be deleted.
+2025,"@@ -455,6 +455,10 @@ class ELBConnection(AWSQueryConnection):
+                     'LoadBalancerName'          : lb_name,
+                     'LoadBalancerPort'          : lb_port,
+                  }
++        if policies:
++            self.build_list_params(params, policies, 'PolicyNames.member.%d')
++        else:
++            params[""PolicyNames""] = """"
+         self.build_list_params(params, policies, 'PolicyNames.member.%d')
+         return self.get_status('SetLoadBalancerPoliciesOfListener', params)
+ ",Shouldn't this line be removed?
+2026,"@@ -0,0 +1,7 @@
++bad_names = set([
++    'TEAM',
++    'PUBLIC'
++])
++
++def blacklisted_name(username):
++    return username in bad_names","Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const."
+2027,"@@ -294,6 +294,7 @@ public class PasscodeActivity extends Activity {
+                 launchBiometricAuth();
+             } else {
+                 setMode(PasscodeMode.Check);
++                newMode = PasscodeMode.Check;
+             }
+             break;
+         }","Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted."
+2028,"@@ -51,7 +51,7 @@ import org.tikv.kvproto.Coprocessor.KeyRange;
+ public class ScanAnalyzer {
+   private static final double INDEX_SCAN_COST_FACTOR = 1.2;
+   private static final double TABLE_SCAN_COST_FACTOR = 1.0;
+-  private static final double DOUBLE_READ_COST_FACTOR = TABLE_SCAN_COST_FACTOR * 3;
++  private static final double DOUBLE_READ_COST_FACTOR = 0.2; // TABLE_SCAN_COST_FACTOR * 3;
+
+   public static class ScanPlan {
+     ScanPlan(",Need change it back?
+2029,"@@ -0,0 +1,12 @@
++# Be sure to restart your server when you modify this file.
++
++# Your secret key is used for verifying the integrity of signed cookies.
++# If you change this key, all old signed cookies will become invalid!
++
++# Make sure the secret is at least 30 characters and all random,
++# no regular words or you'll be exposed to dictionary attacks.
++# You can use `rake secret` to generate a secure secret key.
++
++# Make sure your secret_key_base is kept private
++# if you're sharing your code publicly.
++OpenStreetMap::Application.config.secret_key_base = '8be565e2e25831d88231f4bcfd83dfc3ab33957c4f33bb3cff7a279f7820ec4d0c1111f246bb347c68859c0b46b4e591be9179a53a5a7165a9936000d6d2be41'",Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?
+2030,"@@ -2,6 +2,7 @@ using System;
+ using System.Collections.Concurrent;
+ using System.Collections.Generic;
+ using System.IO;
++using Datadog.Trace.ExtensionMethods;
+ using Datadog.Trace.Logging;
+ using Newtonsoft.Json;
+ using Newtonsoft.Json.Linq;",nit: Looks like this can be removed now
+2031,"@@ -54,15 +54,9 @@ func (p *PKI) Provision(ctx caddy.Context) error {
+ 	p.ctx = ctx
+ 	p.log = ctx.Logger(p)
+
+-	// if this app is initialized at all, ensure there's at
+-	// least a default CA that can be used: the standard CA
+-	// which is used implicitly for signing local-use certs
+ 	if p.CAs == nil {
+ 		p.CAs = make(map[string]*CA)
+ 	}
+-	if _, ok := p.CAs[DefaultCAID]; !ok {
+-		p.CAs[DefaultCAID] = new(CA)
+-	}
+
+ 	for caID, ca := range p.CAs {
+ 		err := ca.Provision(ctx, caID, p.log)","Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil."
+2032,"@@ -260,11 +260,15 @@ static void on_context_dispose(h2o_handler_t *_self, h2o_context_t *ctx)
+
+ void h2o_status_register(h2o_pathconf_t *conf)
+ {
++    static int handler_registered = 0;
+     struct st_h2o_root_status_handler_t *self = (void *)h2o_create_handler(conf, sizeof(*self));
+     self->super.on_context_init = on_context_init;
+     self->super.on_context_dispose = on_context_dispose;
+     self->super.on_req = on_req;
+-    h2o_config_register_status_handler(conf->global, requests_status_handler);
+-    h2o_config_register_status_handler(conf->global, events_status_handler);
+-    h2o_config_register_status_handler(conf->global, durations_status_handler);
++    if (!handler_registered) {
++        handler_registered++;
++        h2o_config_register_status_handler(conf->global, requests_status_handler);
++        h2o_config_register_status_handler(conf->global, events_status_handler);
++        h2o_config_register_status_handler(conf->global, durations_status_handler);
++    }
+ }",Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?
+2033,"@@ -20,7 +20,7 @@ def function():
+     #todo: no space after hash
+
+     # +1: [fixme]
+-	# FIXME: this is broken
++    # FIXME: this is broken
+     # +1: [fixme]
+     # ./TODO: find with notes
+ 	# +1: [fixme]","I think the functional test should not change here, this is probably a test in itself :)"
+2034,"@@ -31,7 +31,16 @@ import (
+ 	""github.com/gogits/gogs/modules/setting""
+ )
+
+-var Sanitizer = bluemonday.UGCPolicy().AllowAttrs(""class"").Matching(regexp.MustCompile(`[\p{L}\p{N}\s\-_',:\[\]!\./\\\(\)&]*`)).OnElements(""code"")
++func BuildSanitizer() (p *bluemonday.Policy) {
++	p = bluemonday.UGCPolicy()
++	p.AllowAttrs(""class"").Matching(regexp.MustCompile(`[\p{L}\p{N}\s\-_',:\[\]!\./\\\(\)&]*`)).OnElements(""code"")
++
++	p.AllowAttrs(""type"").Matching(regexp.MustCompile(`^checkbox$`)).OnElements(""input"")
++	p.AllowAttrs(""checked"", ""disabled"").OnElements(""input"")
++	return p
++}
++
++var Sanitizer = BuildSanitizer()
+
+ // EncodeMD5 encodes string to md5 hex value.
+ func EncodeMD5(str string) string {",Why this to be a public function?
+2035,"@@ -21,7 +21,7 @@ module Travis
+         end
+
+         def set(var, value, options = {})
+-          cmd ""export #{var}=#{value}"", options.merge(log: false)
++          cmd ""export #{var}=#{value}"", options.merge(log: false, timing: false)
+         end
+
+         def echo(string, options = {})",I think we can remove the timing for export env vars
+2036,"@@ -29,8 +29,10 @@ limitations under the License.
+ // limitations under the License.
+
+ Modifies:
+-- Remove interface ""Provider""
+-- Remove import ""k8s.io/kubernetes/pkg/proxy/config""
++- Replace import ""k8s.io/kubernetes/pkg/proxy/config"" with ""github.com/vmware-tanzu/antrea/third_party/proxy/config""
++- Remove config.EndpointSliceHandler, config.NodeHandler from Provider interface type
++- Remove NodeHandler, EndpointSliceHandler, Sync() from Provider interface
++- Add Run(), GetServiceByIP() to Provider interface
+ */
+
+ package proxy",wrong import grouping
+2037,"@@ -232,8 +232,7 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
+                         if (newValue.equals(""page"")) {
+                             final Context context = ui.getActivity();
+                             final String[] navTitles = context.getResources().getStringArray(R.array.back_button_go_to_pages);
+-                            final String[] navTags = new String[3];
+-                            System.arraycopy(MainActivity.NAV_DRAWER_TAGS, 0, navTags, 0, 3);
++                            final String[] navTags = context.getResources().getStringArray(R.array.back_button_go_to_pages_tags);
+                             final String choice[] = { UserPreferences.getBackButtonGoToPage() };
+
+                             AlertDialog.Builder builder = new AlertDialog.Builder(context);",There is a doubled semicolon ;)
+2038,"@@ -40,6 +40,10 @@
+
+
+ #include <math.h>
++#include <zlib.h>
++#include ""openssl/md5.h""
++#include <openssl/sha.h>
++
+ #define MathSqrt(op, err) sqrt(op)
+
+ #include <ctype.h>",I'm wondering why this isn't <openssl/md5.h>. Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?
+2039,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?
+2040,"@@ -229,6 +229,16 @@ bool Mob::CastSpell(uint16 spell_id, uint16 target_id, CastingSlot slot,
+ 		return false;
+ 	}
+
++	if (IsEffectInSpell(spell_id, SE_Charm) && !PassCharmTargetRestriction(entity_list.GetMobID(target_id))) {
++		if (IsClient()) {
++			CastToClient()->SendSpellBarEnable(spell_id);
++		}
++		if (casting_spell_id && IsNPC()) {
++			CastToNPC()->AI_Event_SpellCastFinished(false, static_cast<uint16>(casting_spell_slot));
++		}
++		return false;
++	}
++
+ 	if (HasActiveSong() && IsBardSong(spell_id)) {
+ 		LogSpells(""Casting a new song while singing a song. Killing old song [{}]"", bardsong);
+ 		//Note: this does NOT tell the client","We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable."
+2041,"@@ -63,6 +63,7 @@ def define_violation(dbengine):
+         full_name = Column(String(1024))
+         inventory_data = Column(Text(16777215))
+         inventory_index_id = Column(String(256))
++        invocation_id = Column(DateTime())
+         resource_id = Column(String(256), nullable=False)
+         resource_type = Column(String(256), nullable=False)
+         rule_name = Column(String(256))","This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`."
+2042,"@@ -412,6 +412,18 @@ func (tx Transaction) TxAmount() basics.MicroAlgos {
+ 	}
+ }
+
++// GetReceiverAddress returns the address of the receiver. If the transaction has no receiver, it returns the empty address.
++func (tx Transaction) GetReceiverAddress() basics.Address {
++	switch tx.Type {
++	case protocol.PaymentTx:
++		return tx.PaymentTxnFields.Receiver
++	case protocol.AssetTransferTx:
++		return tx.AssetTransferTxnFields.AssetReceiver
++	default:
++		return basics.Address{}
++	}
++}
++
+ // EstimateEncodedSize returns the estimated encoded size of the transaction including the signature.
+ // This function is to be used for calculating the fee
+ func (tx Transaction) EstimateEncodedSize() int {",should the 'Receiver' be the clawback address in case of clawback transaction?
+2043,"@@ -19,10 +19,16 @@ package command
+ import (
+ 	""errors""
+ 	""flag""
+-
+ 	""github.com/spf13/cobra""
+ )
+
++const (
++	// VolumeAPIPath is the api path to get volume information
++	VolumeAPIPath      = ""/latest/volumes/""
++	controllerStatusOk = ""running""
++	volumeStatusOK     = ""Running""
++)
++
+ var (
+ 	volumeCommandHelpText = `
+ The following commands helps in operating a Volume such as create, list, and so on.",@ashishranjan738 -- Where are these consts used? in which pkg?
+2044,"@@ -81,12 +81,12 @@ autodoc_default_options = {
+     ""show-inheritance"": True,
+ }
+
++# Generate autosummary pages. Output should be set with: `:toctree: pythonapi/`
++autosummary_generate = ['Python-API.rst']
++
+ # Add any paths that contain templates here, relative to this directory.
+ templates_path = ['_templates']
+
+-# Generate autosummary pages. Output should be set with: `:toctree: pythonapi/`
+-autosummary_generate = True
+-
+ # The suffix(es) of source filenames.
+ # You can specify multiple suffix as a list of string:
+ # source_suffix = ['.rst', '.md']",The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller.
+2045,"@@ -1862,8 +1862,8 @@ func (fbo *folderBranchOps) unembedBlockChanges(
+
+ 	md.AddRefBytes(uint64(info.EncodedSize))
+ 	md.AddDiskUsage(uint64(info.EncodedSize))
+-	changes.Info = info
+ 	md.data.cachedChanges = *changes
++	changes.Info = info
+ 	changes.Ops = nil
+ 	return nil
+ }","Having it above kept the block info in the cached changes, which could end up confusing things quite a bit."
+2046,"@@ -409,15 +409,7 @@ HELP
+                 outputter.print_event(node, event)
+               end
+             when 'task'
+-              task_name = options[:object]
+-
+-              path, metadata = load_task_data(task_name, @config[:modulepath])
+-              input_method = metadata['input_method']
+-
+-              input_method ||= 'both'
+-              executor.run_task(
+-                nodes, path, input_method, options[:task_options]
+-              ) do |node, event|
++              execute_task(executor, options) do |node, event|
+                 outputter.print_event(node, event)
+               end
+             when 'file'","If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.)."
+2047,"@@ -199,7 +199,7 @@ func (c *client) InstallTunnelFlows(tunnelOFPort uint32) error {
+
+ func (c *client) Initialize() error {
+ 	// Initiate connections to target OFswitch, and create tables on the switch.
+-	if err := c.bridge.Connect(maxRetryForOFSwitch); err != nil {
++	if err := c.bridge.Connect(maxRetryForOFSwitch, make(chan struct{})); err != nil {
+ 		return err
+ 	}
+ ","Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?"
+2048,"@@ -1001,6 +1001,12 @@ void RaftPart::processAppendLogResponses(const AppendLogResponses& resps,
+     LOG_EVERY_N(WARNING, 100) << idStr_ << ""Only "" << numSucceeded
+                               << "" hosts succeeded, Need to try again"";
+     usleep(1000);
++    {
++      std::lock_guard<std::mutex> g(raftLock_);
++      // wal could be rollback between two cycles, if we still use the old lastLogId, we may always
++      // get E_RAFT_NO_WAL_FOUND
++      lastLogId = std::min(wal_->lastLogId(), lastLogId);
++    }
+     replicateLogs(eb, std::move(iter), currTerm, lastLogId, committedId, prevLogTerm, prevLogId);
+   }
+ }","There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details."
+2049,"@@ -164,7 +164,7 @@ class OrderFlow extends FormFlow
+         $request = $this->getRequest()->request;
+         $requestParameters = $request->all();
+         $requestParameters['flow_order_step'] = $step->getNumber();
+-        $requestParameters[$step->getFormType()->getName()] = $stepData;
++        $requestParameters[$step->getFormType()] = $stepData;
+         $request->replace($requestParameters);
+     }
+ }","Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you."
+2050,"@@ -62,6 +62,19 @@ gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
+ EOM
+ yum -y install google-osconfig-agent
+ echo 'inventory install done'`
++var installInventoryYumEL6 = `sleep 10
++cat > /etc/yum.repos.d/google-osconfig-agent.repo <<EOM
++[google-osconfig-agent]
++name=Google OSConfig Agent Repository
++baseurl=https://packages.cloud.google.com/yum/repos/google-osconfig-agent-el6-unstable
++enabled=1
++gpgcheck=0
++repo_gpgcheck=1
++gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
++       https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg
++EOM
++yum -y install google-osconfig-agent
++echo 'inventory install done'`
+
+ type inventoryTestSetup struct {
+ 	image       string","i was confused by keyword ""inventory"" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong)."
+2051,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities"
+2052,"@@ -1,5 +1,6 @@
+ import { options, createElement as h, render } from 'preact';
+ import { useEffect, useState } from 'preact/hooks';
++import sinon from 'sinon';
+
+ import { setupScratch, teardown } from '../../../test/_util/helpers';
+ import { act } from '../../src';",This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file.
+2053,"@@ -12,6 +12,18 @@ import (
+ 	""github.com/lucas-clemente/quic-go/utils""
+ )
+
++const (
++	// Maximum reordering in time space before time based loss detection considers a packet lost.
++	// In fraction of an RTT.
++	timeReorderingFraction = 1.0 / 8
++	// defaultRTOTimeout is the RTO time on new connections
++	defaultRTOTimeout = 500 * time.Millisecond
++	// Minimum time in the future an RTO alarm may be set for.
++	minRTOTimeout = 200 * time.Millisecond
++	// maxRTOTimeout is the maximum RTO time
++	maxRTOTimeout = 60 * time.Second
++)
++
+ var (
+ 	// ErrDuplicateOrOutOfOrderAck occurs when a duplicate or an out-of-order ACK is received
+ 	ErrDuplicateOrOutOfOrderAck = errors.New(""SentPacketHandler: Duplicate or out-of-order ACK"")",Maybe move all the Loss Recovery constants to a separate file.
+2054,"@@ -145,6 +145,7 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError {
+ }
+
+ type diskAttachment struct {
++	diskName           string
+ 	mode               string
+ 	attacher, detacher *Step
+ }",this field is added so that we can find disk name by device name from attachments
+2055,"@@ -1,5 +1,6 @@
+ package com.fsck.k9.activity;
+
++
+ import android.content.BroadcastReceiver;
+ import android.content.Context;
+ import android.content.Intent;",Unnecessary new line
+2056,"@@ -1893,13 +1893,15 @@ func (c *linuxContainer) currentState() (*State, error) {
+ 			state.NamespacePaths[ns.Type] = ns.GetPath(pid)
+ 		}
+ 		for _, nsType := range configs.NamespaceTypes() {
+-			if !configs.IsNamespaceSupported(nsType) {
++			if _, ok := state.NamespacePaths[nsType]; ok {
+ 				continue
+ 			}
+-			if _, ok := state.NamespacePaths[nsType]; !ok {
+-				ns := configs.Namespace{Type: nsType}
+-				state.NamespacePaths[ns.Type] = ns.GetPath(pid)
++			if !configs.IsNamespaceSupported(nsType) {
++				continue
+ 			}
++			ns := configs.Namespace{Type: nsType}
++			state.NamespacePaths[ns.Type] = ns.GetPath(pid)
++
+ 		}
+ 	}
+ 	return state, nil","First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`"
+2057,"@@ -1,7 +1,5 @@
+-<section class=""assets-wrapper"">
+-  <div class=""assets"">
+-    <%= render ""videos/download_link"", download_type_key: ""OriginalFile"", download_type: ""original"", size_display: ""Original (720p)"", clip: clip %>
+-    <%= render ""videos/download_link"", download_type_key: ""IphoneVideoFile"", download_type: ""iphone"", size_display: ""iPhone"", clip: clip %>
+-    <%= render ""videos/download_link"", download_type_key: ""HdMp4VideoFile"", download_type: ""hd_mp4"", size_display: ""HD MP4"", clip: clip %>
+-  </div>
++<section class=""download-links"">
++  <%= render ""videos/download_link"", download_type_key: ""OriginalFile"", download_type: ""original"", size_display: ""Original (720p)"", clip: clip %>
++  <%= render ""videos/download_link"", download_type_key: ""IphoneVideoFile"", download_type: ""iphone"", size_display: ""iPhone"", clip: clip %>
++  <%= render ""videos/download_link"", download_type_key: ""HdMp4VideoFile"", download_type: ""hd_mp4"", size_display: ""HD MP4"", clip: clip %>
+ </section>",What changed in the styles that means we don't need this?
+2058,"@@ -275,13 +275,13 @@ namespace Microsoft.DotNet.Build.Tasks
+            }
+         }
+
+-        private JToken GetFrameworkDependenciesSection(JObject projectJsonRoot, string framework = null)
++        private JObject GetFrameworkDependenciesSection(JObject projectJsonRoot, string framework = null)
+         {
+             if(string.IsNullOrWhiteSpace(framework))
+             {
+-                return projectJsonRoot[""dependencies""];
++                return (JObject) projectJsonRoot[""dependencies""];
+             }
+-            return projectJsonRoot.SelectToken(""frameworks."" + NewtonsoftEscapeJProperty(framework) + "".dependencies"");
++            return (JObject) projectJsonRoot[""frameworks""][framework][""dependencies""];
+         }
+
+         // Generate the combines dependencies from the projectjson jObject and from AdditionalDependencies",This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method.
+2059,"@@ -165,6 +165,10 @@ class Histogram(Element2D):
+     vdims = param.List(default=[Dimension('Frequency')], bounds=(1,1))
+
+     def __init__(self, values, edges=None, **params):
++        if edges is not None:
++            self.warning(""Histogram edges should be supplied as a tuple ""
++                         ""along with the values, passing the edges will ""
++                         ""be deprecated in holoviews 2.0."")
+         self.values, self.edges, settings = self._process_data(values, edges)
+         settings.update(params)
+         super(Histogram, self).__init__((self.values, self.edges), **settings)",Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else.
+2060,"@@ -892,6 +892,7 @@ spec:
+                     values:
+                     - {{ $targetAffinityVal }}
+                 topologyKey: kubernetes.io/hostname
++                namespaces: [{{.Volume.runNamespace}}]
+           {{- end }}
+           containers:
+           - args:",What does this contain? Is it PVC namespace or is it openebs?
+2061,"@@ -0,0 +1,18 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
++{
++    /// <summary>
++    /// Represents a minimum data rate for the request body of an HTTP request.
++    /// </summary>
++    public interface IHttpRequestBodyMinimumDataRateFeature
++    {
++        /// <summary>
++        /// The minimum data rate in bytes/second at which the request body should be received.
++        /// Setting this property to null indicates no minimum data rate should be enforced.
++        /// This limit has no effect on upgraded connections which are always unlimited.
++        /// </summary>
++        MinimumDataRate MinimumDataRate { get; set; }
++    }
++}","Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions."
+2062,"@@ -426,11 +426,12 @@ LGBM_SE LGBM_BoosterGetEvalNames_R(LGBM_SE handle,
+   LGBM_SE buf_len,
+   LGBM_SE actual_len,
+   LGBM_SE eval_names,
+-  LGBM_SE call_state) {
++  LGBM_SE call_state,
++  LGBM_SE data_idx) {
+
+   R_API_BEGIN();
+   int len;
+-  CHECK_CALL(LGBM_BoosterGetEvalCounts(R_GET_PTR(handle), &len));
++  CHECK_CALL(LGBM_BoosterGetEvalCounts(R_GET_PTR(handle), R_AS_INT(data_idx), &len));
+   std::vector<std::vector<char>> names(len);
+   std::vector<char*> ptr_names(len);
+   for (int i = 0; i < len; ++i) {","this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument."
+2063,"@@ -182,9 +182,13 @@ final class MediaController
+     public function getMediumFormatsAction($id): FOSRestView
+     {
+         $media = $this->getMedium($id);
++        $mediaContext = $media->getContext();
+
+         $formats = [MediaProviderInterface::FORMAT_REFERENCE];
+-        $formats = array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($media->getContext())));
++
++        if (null !== $mediaContext) {
++            $formats = array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($mediaContext)));
++        }
+
+         $provider = $this->mediaPool->getProvider($media->getProviderName());
+ ",Shouldn't we throw an exception if the context is null instead ?
+2064,"@@ -13,6 +13,9 @@ var DdevVersion = ""v0.3.0-dev"" // Note that this is overridden by make
+ // for examples defining version constraints.
+ var DockerVersionConstraint = "">= 17.05.0-ce""
+
++// DockerComposeVersionConstraint is the current minimum version of docker-compose required for ddev.
++var DockerComposeVersionConstraint = "">= 1.10.0""
++
+ // WebImg defines the default web image used for applications.
+ var WebImg = ""drud/nginx-php-fpm-local"" // Note that this is overridden by make
+ ","These should both be const, not var right?"
+2065,"@@ -0,0 +1,8 @@
++from mmcv.utils import Registry, build_from_cfg
++
++MATCH_COST = Registry('Match Cost')
++
++
++def build_match_cost(cfg, default_args=None):
++    """"""Builder of IoU calculator.""""""
++    return build_from_cfg(cfg, MATCH_COST, default_args)","Rename the directory, match_costers -> match_costs"
+2066,"@@ -64,6 +64,13 @@ class DeleteModelTest(BaseTest):
+         records = result['data']
+         self.assertEqual(len(records), 1)
+
++    def test_delete_collection_gives_number_of_deletable_records_in_headers(self):
++        self.resource.request.GET = {'_limit': '1'}
++        self.resource.collection_delete()
++        headers = self.last_response.headers
++        count = headers['Total-Records']
++        self.assertEquals(int(count), 2)
++
+
+ class IsolatedModelsTest(BaseTest):
+     def setUp(self):","I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate"
+2067,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())
+2068,"@@ -130,13 +130,13 @@ func NewExportPipeline(config Config, options ...controller.Option) (*Exporter,
+ // InstallNewPipeline instantiates a NewExportPipeline and registers it globally.
+ // Typically called as:
+ //
+-// 	hf, err := prometheus.InstallNewPipeline(prometheus.Config{...})
++// 	exporter, err := prometheus.InstallNewPipeline(prometheus.Config{...})
+ //
+ // 	if err != nil {
+ // 		...
+ // 	}
+-// 	http.HandleFunc(""/metrics"", hf)
+-// 	defer pipeline.Stop()
++// 	http.HandleFunc(""/metrics"", exporter)
++// 	defer exporter.Controller().Stop(context.TODO())
+ // 	... Done
+ func InstallNewPipeline(config Config, options ...controller.Option) (*Exporter, error) {
+ 	exp, err := NewExportPipeline(config, options...)",Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?
+2069,"@@ -380,14 +380,6 @@ describe ""Bolt::CLI"" do
+         cli = Bolt::CLI.new(%w[command run uptime --password opensesame --nodes foo])
+         expect(cli.parse).to include(password: 'opensesame')
+       end
+-
+-      it ""prompts the user for password if not specified"" do
+-        allow(STDIN).to receive(:noecho).and_return('opensesame')
+-        allow(STDOUT).to receive(:print).with('Please enter your password: ')
+-        allow(STDOUT).to receive(:puts)
+-        cli = Bolt::CLI.new(%w[command run uptime --nodes foo --password])
+-        expect(cli.parse).to include(password: 'opensesame')
+-      end
+     end
+
+     describe ""key"" do",Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests.
+2070,"@@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+
+         public void PrepareContinuation(Http2ContinuationFrameFlags flags, int streamId)
+         {
+-            PayloadLength = MinAllowedMaxFrameSize - HeaderLength;
++            PayloadLength = (int)_maxFrameSize;
+             Type = Http2FrameType.CONTINUATION;
+             ContinuationFlags = flags;
+             StreamId = streamId;",Remove this since it always has to be set afterwards.
+2071,"@@ -11,7 +11,7 @@ import ""testing""
+ // bob writes a multi-block file while unmerged, no conflicts
+ func TestCrUnmergedWriteMultiblockFile(t *testing.T) {
+ 	test(t,
+-		blockSize(20), users(""alice"", ""bob""),
++		blockSize(20), blockChangeSize(20*1024), users(""alice"", ""bob""),
+ 		as(alice,
+ 			mkdir(""a""),
+ 		),","These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching."
+2072,"@@ -25,8 +25,13 @@ class LeafNode(Node):
+     self.reader = reader
+     self.is_leaf = True
+
+-  def fetch(self, startTime, endTime):
+-    return self.reader.fetch(startTime, endTime)
++  def fetch(self, startTime, endTime, now=None, requestContext=None):
++    try:
++      result = self.reader.fetch(startTime, endTime, now, requestContext)
++    except TypeError:
++      result = self.reader.fetch(startTime, endTime)
++
++    return result
+
+   @property
+   def intervals(self):","Is that `try..except` block really needed? I mean, when it could fail?"
+2073,"@@ -101,7 +101,7 @@ module.exports = function(config) {
+
+ 		files: [
+ 			{ pattern: 'test/polyfills.js', watched: false },
+-			{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/test/{browser,shared}/**.test.js', watched: false }
++			{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/test/{browser,shared}/suspense.test.js', watched: false }
+ 		],
+
+ 		preprocessors: {",If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :)
+2074,"@@ -65,7 +65,13 @@ LAMBDA_DEFAULT_STARTING_POSITION = 'LATEST'
+ LAMBDA_ZIP_FILE_NAME = 'original_lambda_archive.zip'
+ LAMBDA_JAR_FILE_NAME = 'original_lambda_archive.jar'
+
+-DEFAULT_BATCH_SIZE = 10
++INVALID_PARAMETER_VALUE_EXCEPTION = 'InvalidParameterValueException'
++
++BATCH_SIZE_MAP = {
++    'kinesis': (100, 10000),
++    'dynamodb': (100, 1000),
++    'sqs': (10, 10)
++}
+
+ app = Flask(APP_NAME)
+ ","nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name."
+2075,"@@ -1322,7 +1322,8 @@ public class MenuEntrySwapperPlugin extends Plugin
+
+ 		if (this.swapCoalBag)
+ 		{
+-			menuManager.addPriorityEntry(""Empty"", ""Coal bag"");
++			menuManager.addPriorityEntry(""Empty"", ""Coal bag"").setPriority(90);
++			menuManager.addPriorityEntry(""Fill"", ""Coal bag"").setPriority(100);
+ 		}
+
+ 		if (this.swapBones)",aren't these the wrong way around?
+2076,"@@ -2027,6 +2027,10 @@ public class CoreContainer {
+     return configSetsHandler;
+   }
+
++  public ConfigSetService getCoreConfigService() {
++    return this.coreConfigService;
++  }
++
+   public String getHostName() {
+     return this.hostName;
+   }",Lets call this getConfigSetService and maybe rename the field now (or later)
+2077,"@@ -27,8 +27,8 @@ import (
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/schema""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+-	""k8s.io/klog""
+-	""k8s.io/klog/klogr""
++	""k8s.io/klog/v2""
++	""k8s.io/klog/v2/klogr""
+
+ 	""github.com/jetstack/cert-manager/pkg/api""
+ )",Could / should we make these constants and give them a type?
+2078,"@@ -63,6 +63,13 @@ const (
+
+ 	deleteAfterAnnotation    = ""hive.openshift.io/delete-after"" // contains a duration after which the cluster should be cleaned up.
+ 	tryInstallOnceAnnotation = ""hive.openshift.io/try-install-once""
++
++	platformAWS       = ""aws""
++	platformAzure     = ""azure""
++	platformGCP       = ""GCP""
++	platformBaremetal = ""baremetal""
++	platformUnknown   = ""unknown platform""
++	regionUnknown     = ""unknown region""
+ )
+
+ var (",lets stick with lowercase for consistency.
+2079,"@@ -17,10 +17,9 @@ limitations under the License.
+ package acme
+
+ import (
+-	corev1 ""k8s.io/api/core/v1""
+-
+ 	cmacme ""github.com/jetstack/cert-manager/pkg/apis/acme/v1""
+ 	cmmeta ""github.com/jetstack/cert-manager/pkg/apis/meta/v1""
++	corev1 ""k8s.io/api/core/v1""
+ )
+
+ // IsFinalState will return true if the given ACME State is a 'final' state.",ordering of imports went wrong
+2080,"@@ -84,6 +84,11 @@ public class AllDataFilesTable extends BaseMetadataTable {
+       this.fileSchema = fileSchema;
+     }
+
++    @Override
++    protected String tableType() {
++      return String.valueOf(MetadataTableType.ALL_DATA_FILES);
++    }
++
+     @Override
+     protected TableScan newRefinedScan(TableOperations ops, Table table, Schema schema, TableScanContext context) {
+       return new AllDataFilesTableScan(ops, table, schema, fileSchema, context);",I think these can all be .name() to get the value we are looking for
+2081,"@@ -2622,6 +2622,16 @@ class FunctionCallTest extends TestCase
+                     array_push();',
+                 'error_message' => 'TooFewArguments',
+             ],
++            'printOnlyString' => [
++                '<?php
++                    print [];',
++                'error_message' => 'InvalidArgument',
++            ],
++            'printReturns1' => [
++                '<?php
++                    (print ""test"") === 2;',
++                'error_message' => 'TypeDoesNotContainType',
++            ],
+         ];
+     }
+ }",Is this a good place for these test cases?
+2082,"@@ -45,6 +45,7 @@ class Job(object):
+         self.vault = vault
+         if response_data:
+             for response_name, attr_name, default in self.ResponseDataElements:
++                print response_name, attr_name
+                 setattr(self, attr_name, response_data[response_name])
+         else:
+             for response_name, attr_name, default in self.ResponseDataElements:",Did you mean to leave the print statement?
+2083,"@@ -184,6 +184,9 @@ Interpreter.false = new Buffer([]);
+
+ Interpreter.MAX_SCRIPT_ELEMENT_SIZE = 520;
+
++Interpreter.LOCKTIME_THRESHOLD = 500000000;
++Interpreter.LOCKTIME_THRESHOLD_BN = new BN(500000000);
++
+ // flags taken from bitcoind
+ // bitcoind commit: b5d1b1092998bc95313856d535c632ea5a8f9104
+ Interpreter.SCRIPT_VERIFY_NONE = 0;",I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`
+2084,"@@ -23,9 +23,7 @@ package com.github.javaparser.ast.visitor;
+
+ import com.github.javaparser.ast.Node;
+
+-import java.util.ArrayList;
+-import java.util.LinkedList;
+-import java.util.Queue;
++import java.util.*;
+
+ /**
+  * Iterate over all the nodes in (a part of) the AST.","@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`."
+2085,"@@ -416,7 +416,7 @@ func timerTypeFromThrift(
+ func timerTypeToReason(
+ 	timerType timerType,
+ ) string {
+-	return fmt.Sprintf(""cadenceInternal:Timeout %v"", timerTypeToThrift(timerType))
++	return fmt.Sprintf(""cadenceInternal:Timeout TimeoutType%v"", timerTypeToThrift(timerType))
+ }
+
+ // Len implements sort.Interface",Need to add type name here to be compatible with proto string representation.
+2086,"@@ -40,7 +40,7 @@ public class BazelBuild {
+     if (target == null || """".equals(target)) {
+       throw new IllegalStateException(""No targets specified"");
+     }
+-    log.info(""\nBuilding "" + target + "" ..."");
++    log.finest(""\nBuilding "" + target + "" ..."");
+
+     ImmutableList.Builder<String> builder = ImmutableList.builder();
+     builder.add(""bazel"", ""build"", target);",This is to let people know that the tooling is doing something during a build. Please leave.
+2087,"@@ -17,8 +17,8 @@ MINIMALIST_COLLECTION = {'data': dict()}
+ MINIMALIST_GROUP = {'data': dict(members=['fxa:user'])}
+ MINIMALIST_RECORD = {'data': dict(name=""Hulled Barley"",
+                                   type=""Whole Grain"")}
+-USER_PRINCIPAL = 'basicauth:8a931a10fc88ab2f6d1cc02a07d3a81b5d4768f' \
+-                 '6f13e85c5d8d4180419acb1b4'
++USER_PRINCIPAL = 'basicauth:aaedca130273574dd2bd6c3acad57f3545b662a974fa4320' \
++                 '236f25fe474676d6'
+
+
+ class BaseWebTest(object):",Why is the principal changing here?
+2088,"@@ -26,6 +26,11 @@
+ // The default URL opener will use credentials from the environment variables
+ // AZURE_STORAGE_ACCOUNT, AZURE_STORAGE_KEY, and AZURE_STORAGE_SAS_TOKEN.
+ // AZURE_STORAGE_ACCOUNT is required, along with one of the other two.
++// AZURE_BLOB_DOMAIN can optionally be used to provide an Azure Environment
++// blob storage domain to use. If no AZURE_BLOB_DOMAIN is provided, the
++// default Azure public domain ""blob.core.windows.net"" will be used. Check
++// the Azure Developer Guide for your particular cloud environment to see
++// the proper blob storage domain name to provide.
+ // To customize the URL opener, or for more details on the URL format,
+ // see URLOpener.
+ // See https://gocloud.dev/concepts/urls/ for background information.",Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones.
+2089,"@@ -0,0 +1,18 @@
++const Plugin = require('../../core/Plugin')
++
++module.exports = class ProgressBar extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++
++    this.id = opts.id
++    this.type = 'progressindicator'
++  }
++
++  install () {
++    this.opts.onInstall()
++  }
++
++  uninstall () {
++    this.opts.onUninstall()
++  }
++}",I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?
+2090,"@@ -1,6 +1,9 @@
+ package v1alpha1
+
+ import (
++	""errors""
++	""strings""
++
+ 	v1 ""k8s.io/api/core/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ ",can we use `github.com/pkg/errors`?
+2091,"@@ -72,15 +72,15 @@ func Compile(scope Scope, f *semantic.FunctionExpression, in semantic.MonoType)
+ // inType and mapping any variables to the value in the other record.
+ // If the input type is not a type variable, it will check to ensure
+ // that the type in the input matches or it will return an error.
+-func substituteTypes(subst map[uint64]semantic.MonoType, inType, in semantic.MonoType) error {
++func substituteTypes(subst map[uint64]semantic.MonoType, inferredType, actualType semantic.MonoType) error {
+ 	// If the input isn't a valid type, then don't consider it as
+ 	// part of substituting types. We will trust type inference has
+ 	// the correct type and that we are just handling a null value
+ 	// which isn't represented in type inference.
+-	if in.Nature() == semantic.Invalid {
++	if actualType.Nature() == semantic.Invalid {
+ 		return nil
+-	} else if inType.Kind() == semantic.Var {
+-		vn, err := inType.VarNum()
++	} else if inferredType.Kind() == semantic.Var {
++		vn, err := inferredType.VarNum()
+ 		if err != nil {
+ 			return err
+ 		}",I changed the name of the arguments here just to help make the code clearer.
+2092,"@@ -404,7 +404,10 @@ class Callable(param.Parameterized):
+     allowing their inputs (and in future outputs) to be defined.
+     This makes it possible to wrap DynamicMaps with streams and
+     makes it possible to traverse the graph of operations applied
+-    to a DynamicMap.
++    to a DynamicMap. Additionally a Callable will memoize the last
++    returned value based on the arguments to the function and the
++    state of all streams on its inputs, avoiding calling the function
++    unncessarily.
+     """"""
+
+     callable_function = param.Callable(default=lambda x: x, doc=""""""",I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better.
+2093,"@@ -5425,7 +5425,7 @@ SyncOpBeginRenderPass::SyncOpBeginRenderPass(CMD_TYPE cmd, const SyncValidator &
+             // TODO: Revisit this when all attachment validation is through SyncOps to see if we can discard the plain pointer copy
+             // Note that this a safe to presist as long as shared_attachments is not cleared
+             attachments_.reserve(shared_attachments_.size());
+-            for (const auto attachment : shared_attachments_) {
++            for (const auto &attachment : shared_attachments_) {
+                 attachments_.emplace_back(attachment.get());
+             }
+         }","@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up."
+2094,"@@ -16,10 +16,16 @@
+ //
+
+ using System;
++using System.Collections.Generic;
+ using System.IO;
+ using System.Linq;
+ using System.Reflection;
+ using FluentAssertions;
++using Nethermind.Core;
++using Nethermind.Logging;
++using Nethermind.Monitoring.Config;
++using Nethermind.Monitoring.Metrics;
++using Nethermind.Runner;
+ using NUnit.Framework;
+
+ namespace Nethermind.Monitoring.Test",minor: typo (knowMetricsTypes -> knownMetricsTypes)
+2095,"@@ -503,7 +503,13 @@ ConstValue* OptRangeSpec::getConstOperand(ItemExpr* predExpr, Lng32 constInx)
+   // currently support. Predicates involving types not yet supported will be
+   // treated as residual predicates.
+   if (QRDescGenerator::typeSupported(static_cast<ConstValue*>(right)->getType()))
++  {
++    /* add constvalue ‘not casespecific’ to type_*/
++      ((CharType*)getType())->setCaseinsensitive(
++              ((CharType *)(((ConstValue*)(right))->getType()))->isCaseinsensitive());
++
+     return static_cast<ConstValue*>(right);
++  }
+   else
+     return NULL;
+ } // getConstOperand()","This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons."
+2096,"@@ -637,6 +637,16 @@ public class MethodResolutionLogic {
+         throw new UnsupportedOperationException(typeDeclaration.getClass().getCanonicalName());
+     }
+
++    public static SymbolReference<ResolvedMethodDeclaration> solveMethodInFQN(String fqn, String name,
++                                                                             List<ResolvedType> argumentsTypes, boolean staticOnly, TypeSolver typeSolver) {
++        SymbolReference<ResolvedReferenceTypeDeclaration> typeRef = typeSolver.tryToSolveType(fqn);
++        if (typeRef.isSolved()) {
++            return solveMethodInType(typeRef.getCorrespondingDeclaration(), name, argumentsTypes,
++                    staticOnly, typeSolver);
++        }
++        return SymbolReference.unsolved(ResolvedMethodDeclaration.class);
++    }
++
+     private static void inferTypes(ResolvedType source, ResolvedType target, Map<ResolvedTypeParameterDeclaration, ResolvedType> mappings) {
+
+ ",I would throw an exception if the type is not solved
+2097,"@@ -52,11 +52,8 @@ func TestDifficulty(t *testing.T) {
+
+ 	// files are 2 years old, contains strange values
+ 	dt.skipLoad(""difficultyCustomHomestead\\.json"")
+-	dt.skipLoad(""difficultyMorden\\.json"")
+-	dt.skipLoad(""difficultyOlimpic\\.json"")
+
+ 	dt.config(""Ropsten"", *params.RopstenChainConfig)
+-	dt.config(""Morden"", *params.RopstenChainConfig)
+ 	dt.config(""Frontier"", params.ChainConfig{})
+
+ 	dt.config(""Homestead"", params.ChainConfig{",if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?
+2098,"@@ -0,0 +1,14 @@
++module Beaker
++  module Shared
++    module Timed
++
++      def run_and_report_duration &block
++        start = Time.now
++        block.call
++        Time.now - start
++      end
++
++    end
++  end
++end
++",I feel like we do this in a lot of places should we move that out into its own PR?
+2099,"@@ -12,7 +12,7 @@ import 'css!./style';
+         fillImageElement(elem, source);
+     }
+
+-    async function itemBlurhashing(target, blurhashstr) {
++    function itemBlurhashing(target, blurhashstr) {
+         if (blurhash.isBlurhashValid(blurhashstr)) {
+             // Although the default values recommended by Blurhash developers is 32x32, a size of 18x18 seems to be the sweet spot for us,
+             // improving the performance and reducing the memory usage, while retaining almost full blur quality.","Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?"
+2100,"@@ -239,7 +239,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+             ""with statement assignment and exception handler assignment."",
+         ),
+         ""R1705"": (
+-            'Unnecessary ""%s"" after ""return""',
++            'Unnecessary ""%s"" after ""return"" remove it and de-indent all the code inside it',
+             ""no-else-return"",
+             ""Used in order to highlight an unnecessary block of ""
+             ""code following an if containing a return statement. ""","I think here should be a comma before remove, in all the cases"
+2101,"@@ -12,11 +12,16 @@ class OHEMSampler(BaseSampler):
+                  context,
+                  neg_pos_ub=-1,
+                  add_gt_as_proposals=True,
++                 stages=0,
+                  **kwargs):
+         super(OHEMSampler, self).__init__(num, pos_fraction, neg_pos_ub,
+                                           add_gt_as_proposals)
+-        self.bbox_roi_extractor = context.bbox_roi_extractor
+-        self.bbox_head = context.bbox_head
++        if not hasattr(context, ""num_stages""):
++            self.bbox_roi_extractor = context.bbox_roi_extractor
++            self.bbox_head = context.bbox_head
++        else:
++            self.bbox_roi_extractor = context.bbox_roi_extractor[stages]
++            self.bbox_head = context.bbox_head[stages]
+
+     def hard_mining(self, inds, num_expected, bboxes, labels, feats):
+         with torch.no_grad():",Single quote is used by default in this project.
+2102,"@@ -177,10 +177,8 @@ func (c *Controller) updateSpc(oldSpc, newSpc interface{}) {
+ 		c.recorder.Event(spc, corev1.EventTypeWarning, ""Update"", message)
+ 		return
+ 	}
+-	// Enqueue spc only when there is a pending pool to be created.
+-	if c.isPoolPending(spc) {
+-		c.enqueueSpc(newSpc)
+-	}
++	// Don't reconcile on spc
++	return
+ }
+
+ // deleteSpc is the delete event handler for spc.",S1023: redundant `return` statement (from `gosimple`)
+2103,"@@ -43,3 +43,6 @@ func (s *webhook) Run(ctx context.Context) error {
+
+ func (s *webhook) Notify(event model.Event) {
+ }
++
++func (s *webhook) Close(ctx context.Context) {
++}",`ctx` is unused in Close
+2104,"@@ -0,0 +1,9 @@
++<?php
++
++namespace Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory;
++
++use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
++
++class HeurekaCategoryNotFoundException extends NotFoundHttpException
++{
++}","I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions."
+2105,"@@ -0,0 +1,7 @@
++_base_ = './tood_r101_fpn_mstrain_2x_coco.py'
++
++model = dict(
++    backbone=dict(
++        dcn=dict(type='DCNv2', deformable_groups=1, fallback_on_stride=False),
++        stage_with_dcn=(False, True, True, True)),
++    bbox_head=dict(num_dcn_on_head=2))","Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?"
+2106,"@@ -548,6 +548,14 @@ AM_COND_IF(BUILDOPT_SYSTEMD_AND_LIBMOUNT,
+   AC_DEFINE([BUILDOPT_LIBSYSTEMD_AND_LIBMOUNT], 1, [Define if systemd and libmount]))
+ if test x$with_libsystemd = xyes; then OSTREE_FEATURES=""$OSTREE_FEATURES systemd""; fi
+
++AC_ARG_WITH(modern-grub,
++	    AS_HELP_STRING([--with-modern-grub],
++                           [Omit grub linux and initrd suffixes for EFI/BIOS booting on GRUB >2.02 (default: no)]),,
++              [with_modern_grub=no])
++AS_IF([ test x$with_modern_grub = xyes], [
++  AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])
++])
++
+ AC_ARG_WITH(builtin-grub2-mkconfig,
+             AS_HELP_STRING([--with-builtin-grub2-mkconfig],
+                            [Use a builtin minimal grub2-mkconfig to generate a GRUB2 configuration file (default: no)]),,","Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?"
+2107,"@@ -27,13 +27,13 @@ import (
+ // Instance is a compute instance.
+ type Instance struct {
+ 	*api.Instance
+-	client        daisyCompute.Client
++	Client        daisyCompute.Client
+ 	Project, Zone string
+ }
+
+ // Cleanup deletes the Instance.
+ func (i *Instance) Cleanup() {
+-	if err := i.client.DeleteInstance(i.Project, i.Zone, i.Name); err != nil {
++	if err := i.Client.DeleteInstance(i.Project, i.Zone, i.Name); err != nil {
+ 		fmt.Printf(""Error deleting instance: %v\n"", err)
+ 	}
+ }","Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)"
+2108,"@@ -138,9 +138,11 @@ Workshops::Application.routes.draw do
+   get '/group-training' => ""pages#show"", as: :group_training, id: ""group-training""
+   get '/humans-present/oss' => redirect('https://www.youtube.com/watch?v=VMBhumlUP-A')
+   get '/backbone.js' => redirect('/backbone')
+-  get '/backbone-js-on-rails' => redirect('/products/1-backbone-js-on-rails')
+-  get '/geocoding-on-rails' => redirect('/products/22-geocoding-on-rails')
++  get ""/backbone-js-on-rails"" => redirect(""/products/1-backbone-js-on-rails""), as: :backbone_js_on_rails
++  get ""/geocoding-on-rails"" => redirect(""/products/22-geocoding-on-rails""), as: :geocoding_on_rails
+   get '/geocodingonrails' => redirect('/products/22-geocoding-on-rails')
++  get ""/ios-on-rails"" => redirect(""/products/25-ios-on-rails-beta""), as: :ios_on_rails
++  get ""/ruby-science"" => redirect(""/products/13-ruby-science""), as: :ruby_science
+   get '/gettingstartedwithios' => redirect('/workshops/24-getting-started-with-ios-development?utm_source=podcast')
+   get '/5by5' => redirect('/workshops/19-design-for-developers?utm_source=5by5')
+   get '/rubyist-booster-shot' => ""pages#show"", as: :rubyist_booster_shot, id: ""rubyist-booster-shot""",Line is too long. [104/80]
+2109,"@@ -93,6 +93,8 @@ func TestReconcileClusterPool(t *testing.T) {
+ 		expectedMissingDependenciesMessage string
+ 		expectedAssignedClaims             int
+ 		expectedUnassignedClaims           int
++		expectedAssignedCDs                int
++		expectedRunning                    int
+ 		expectedLabels                     map[string]string // Tested on all clusters, so will not work if your test has pre-existing cds in the pool.
+ 		// Map, keyed by claim name, of expected Status.Conditions['Pending'].Reason.
+ 		// (The clusterpool controller always sets this condition's Status to True.)",Since CD updates (assignment & power state) are now done in this controller...
+2110,"@@ -13,10 +13,18 @@ const MongooseError = require('./mongooseError');
+  * @api private
+  */
+
+-function ParallelValidateError(doc) {
++function ParallelValidateError(doc, opts) {
+   const msg = 'Can\'t validate() the same doc multiple times in parallel. Document: ';
+   MongooseError.call(this, msg + doc._id);
+   this.name = 'ParallelValidateError';
++  if (opts && opts.parentStack) {
++    // Provide a full async stack, most recent first
++    this.stack = this.stack + '\n\n' + opts.parentStack.join('\n\n');
++  }
++  // You need to know to look for this, but having it can be very helpful
++  // for tracking down issues when combined with the deepStackTrace schema
++  // option
++  this.conflictStack = opts && opts.conflictStack;
+ }
+
+ /*!",Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets.
+2111,"@@ -0,0 +1,17 @@
++class CommentCreator
++  def initialize(parsed_email)
++    @parsed_email = parsed_email
++  end
++
++  def run
++    Comment.create(
++      comment_text: parsed_email.comment_text,
++      user: parsed_email.comment_user,
++      proposal: parsed_email.proposal
++    )
++  end
++
++  private
++
++  attr_reader :parsed_email
++end","on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought"
+2112,"@@ -238,7 +238,7 @@ TEST_F(BlackBoxPersistence, AsyncRTPSAsReliableWithPersistence)
+
+     ASSERT_TRUE(reader.isInitialized());
+
+-    writer.make_persistent(db_file_name(), guid_prefix()).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();
++    writer.make_persistent(db_file_name(), guid_prefix()).history_depth(10).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();
+
+     ASSERT_TRUE(writer.isInitialized());
+ ",This line is too long
+2113,"@@ -54,7 +54,7 @@ func run(ctx context.Context) {
+ 	ticker := time.NewTicker(config.SvcPollInterval())
+ 	for {
+ 		if err := config.SetConfig(); err != nil {
+-			logger.Errorf(err.Error())
++			logger.Fatalf(err.Error())
+ 		}
+
+ 		// This sets up the patching system to run in the background.","This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set"
+2114,"@@ -93,7 +93,7 @@ func (t *V4Trie) Get(cidr V4CIDR) interface{} {
+ }
+
+ func (t *V4Trie) LookupPath(buffer []V4TrieEntry, cidr V4CIDR) []V4TrieEntry {
+-	return t.root.lookupPath(buffer, cidr)
++	return t.root.lookupPath(buffer[:0], cidr)
+ }
+
+ // LPM does a longest prefix match on the trie","I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?"
+2115,"@@ -0,0 +1,18 @@
++<table style=""font-size: 15px; font-style: italic; margin: 15px; background-color: #eee; width: 520px"">
++  <tr>
++    <td style=""width: 50px; vertical-align: top; padding: 15px"">
++      <%= link_to(
++          image_tag(
++            attachments[""avatar.png""].url,
++            alt: @user_message_author,
++            title: @user_message_author
++          ),
++          user_url(@user_message_author, :host => SERVER_URL),
++          :target => ""_blank""
++      ) %>
++    </td>
++    <td style=""text-align: left; vertical-align: top; padding-right: 10px"">
++      <%= captured %>
++    </td>
++  </tr>
++</table>","I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?"
+2116,"@@ -220,6 +220,9 @@ type NetworkPolicyRule struct {
+ 	// action “nil” defaults to Allow action, which would be the case for rules created for
+ 	// K8s Network Policy.
+ 	Action *secv1alpha1.RuleAction `json:""action,omitempty"" protobuf:""bytes,6,opt,name=action,casttype=github.com/vmware-tanzu/antrea/pkg/apis/security/v1alpha1.RuleAction""`
++	// EnableLogging is used to indicate if agent should generate logs
++	// when rules are matched. Should be default to false.
++	EnableLogging bool `json:""enableLogging"" protobuf:""varint,7,opt,name=enableLogging""`
+ }
+
+ // Protocol defines network protocols supported for things like container ports.","Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false."
+2117,"@@ -124,6 +124,16 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+     status = rocksdb::DB::Open(options, path, &db);
+   }
+   CHECK(status.ok()) << status.ToString();
++  if (!readonly && spaceId_ != 0 /* only for storage*/) {
++    rocksdb::ReadOptions readOptions;
++    std::string dataVersionValue = """";
++    status = db->Get(readOptions, NebulaKeyUtils::dataVersionKey(), &dataVersionValue);
++    if (status.IsNotFound()) {
++      rocksdb::WriteOptions writeOptions;
++      status = db->Put(writeOptions, NebulaKeyUtils::dataVersionKey(), ""3.0"");
++    }
++    CHECK(status.ok()) << status.ToString();
++  }
+   db_.reset(db);
+   extractorLen_ = sizeof(PartitionID) + vIdLen;
+   partsNum_ = allParts().size();",use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?
+2118,"@@ -372,10 +372,15 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
+         path = None
+
+     if check_exists:
+-        if path is not None and os.path.exists(path):
+-            log.url.debug(""URL is a local file"")
+-        else:
+-            path = None
++        if path is not None:
++            try:
++                if os.path.exists(path):
++                    log.url.debug(""URL is a local file"")
++            except UnicodeEncodeError:
++                log.url.debug(
++                    ""URL contains characters which are not present in the "" \
++                    ""current locale"")
++                path = None
+
+     return path
+ ","No need for the `\` here, inside parentheses whitespace is ignored by Python."
+2119,"@@ -171,6 +171,10 @@ eqp31wM9il1n+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV
+ 			input:  ""{http.request.tls.client.san.ips.0}"",
+ 			expect: ""127.0.0.1"",
+ 		},
++		{
++			input:  ""{http.request.tls.client.certificate_pem}"",
++			expect: ""<empty>"",
++		},
+ 	} {
+ 		actual := repl.ReplaceAll(tc.input, ""<empty>"")
+ 		if actual != tc.expect {",This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above.
+2120,"@@ -391,8 +391,6 @@ static void wlr_surface_flush_damage(struct wlr_surface *surface,
+ release:
+ 	pixman_region32_clear(&surface->current->surface_damage);
+ 	pixman_region32_clear(&surface->current->buffer_damage);
+-
+-	wlr_surface_state_release_buffer(surface->current);
+ }
+
+ static void wlr_surface_commit_pending(struct wlr_surface *surface) {",need to rename this now.
+2121,"@@ -42,7 +42,16 @@ public class ExpectValidPrivateTransactionReceipt implements PrivateCondition {
+         node.execute(transactions.getPrivateTransactionReceipt(transactionHash));
+     assertThat(actualReceipt)
+         .usingRecursiveComparison()
+-        .ignoringFields(""commitmentHash"", ""logs"")
++        .ignoringFields(
++            ""commitmentHash"",
++            ""logs"",
++            ""blockHash"",
++            ""blockNumber"",
++            ""logsBloom"",
++            ""transactionIndex"") // TODO: The fields blockHash, blockNumber, logsBloom and
++        // transactionIndex have to be ignored as the class
++        // org.web3j.protocol.besu.response.privacy.PrivateTransactionReceipt does not contain these
++        // fields
+         .isEqualTo(expectedReceipt);
+
+     assertThat(actualReceipt.getLogs().size()).isEqualTo(expectedReceipt.getLogs().size());",NIT: This shouldn't be a TODO. It is just a note isn't it?
+2122,"@@ -1644,6 +1644,8 @@ class CommandDispatcher:
+         """"""
+         try:
+             elem.set_value(text)
++        except webelem.OrphanedError as e:
++            message.warning('Edited element vanished')
+         except webelem.Error as e:
+             raise cmdexc.CommandError(str(e))
+ ","I changed this to an error, that seems more appropriate than a warning here."
+2123,"@@ -492,7 +492,7 @@ func (sct *SmartContractTest) run(r *require.Assertions) {
+ 		if receipt.Status == uint64(iotextypes.ReceiptStatus_Success) {
+ 			numLog := 0
+ 			for _, l := range receipt.Logs {
+-				if !action.IsSystemLog(l) {
++				if !l.IsEvmTransfer() {
+ 					numLog++
+ 				}
+ 			}","This change could mute unit test failure, but it is better to update unit tests"
+2124,"@@ -165,6 +165,8 @@ class NotificationData {
+         activeNotifications.remove(holder);
+
+         int notificationId = holder.notificationId;
++        notificationIdsInUse.delete(notificationId);
++
+         if (!additionalNotifications.isEmpty()) {
+             NotificationContent newContent = additionalNotifications.removeFirst();
+             NotificationHolder replacement = createNotificationHolder(notificationId, newContent);",All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?
+2125,"@@ -26,17 +26,14 @@ import (
+ 	""sync""
+ 	""time""
+
+-	""github.com/ethersphere/bee/pkg/sctx""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ )
+
+ var (
+ 	TagUidFunc  = rand.Uint32
+-	ErrNotFound = errors.New(""tag not found"")
++	NotFoundErr = errors.New(""tag not found"")
+ )
+
+-type TagsContextKey struct{}
+-
+ // Tags hold tag information indexed by a unique random uint32
+ type Tags struct {
+ 	tags *sync.Map","keep as `ErrNotFound`, it is the same convention as in other packages"
+2126,"@@ -10,13 +10,15 @@ var ip = {},
+     extIP = require('external-ip'),
+     plugins = require('../../../plugins/pluginManager.js');
+
++
+ /**
+  * Function to get the hostname/ip address/url to access dashboard
+  * @param  {function} callback - callback function that returns the hostname
+  */
+ ip.getHost = function(callback) {
+     // If host is set in config.js use that, otherwise get the external IP from ifconfig.me
+-    var domain = plugins.getConfig(""api"").domain;
++    var domain = plugins.getConfig(""api"").domain,
++        offlineMode = plugins.getConfig(""api"").offline_mode;
+     if (typeof domain !== ""undefined"" && domain !== """") {
+         if (domain.indexOf(""://"") === -1) {
+             domain = ""http://"" + domain;","Same here, we need to call `callback` in else branch"
+2127,"@@ -160,7 +160,7 @@ public class CertFailedRefreshNotificationTask implements NotificationTask {
+             }
+
+             String expiryTime =  getTimestampAsString(certRecord.getExpiryTime());
+-            String hostName = (certRecord.getHostName() != null) ? certRecord.getHostName() : """";
++            String hostName = certRecord.getHostName();
+             certDetails.append(AthenzUtils.extractPrincipalServiceName(certRecord.getService())).append(';')
+                     .append(certRecord.getProvider()).append(';')
+                     .append(certRecord.getInstanceId()).append(';')",At this point we already check that the record is valid and so it could never be nulll
+2128,"@@ -126,6 +126,7 @@ class UserController < ApplicationController
+          (params[:user][:auth_provider] == current_user.auth_provider &&
+           params[:user][:auth_uid] == current_user.auth_uid)
+         update_user(current_user, params)
++        @title = t ""user.account.title""
+       else
+         session[:new_user_settings] = params
+         redirect_to auth_url(params[:user][:auth_provider], params[:user][:auth_uid])",Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?
+2129,"@@ -130,6 +130,7 @@ void MetaClient::heartBeatThreadFunc() {
+             localLastUpdateTime_ = metadLastUpdateTime_;
+         }
+     }
++    uploadSession();
+ }
+
+ bool MetaClient::loadUsersAndRoles() {",why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete
+2130,"@@ -0,0 +1,17 @@
++_base_ = './retinanet_regnetx-1.6GF_fpn_mstrain_640-800_3x_coco.py'
++model = dict(
++    pretrained='open-mmlab://regnetx_3.2gf',
++    backbone=dict(
++        _delete_=True,
++        type='RegNet',
++        arch='regnetx_3.2gf',
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++    neck=dict(
++        type='FPN',
++        in_channels=[96, 192, 432, 1008],
++        out_channels=256,
++        num_outs=5))",out_channels/num_outs/type are unnecessary
+2131,"@@ -6,6 +6,17 @@ let null_dict = null_dictionary || {}
+ // eslint-disable-next-line no-undef
+ assert_true(dict.X !== undefined && dict.doSomething !== undefined);  // Testing successful object creation.
+
++
++/*
++    It seems that Object.values(dict) is not supported on JSC for non-static fields, it would be interesting to
++    review this in the future.
++    verify_object_fields(Object.values(dict).length)
++ */
++
++// eslint-disable-next-line no-undef
++verify_object_fields(Object.keys(dict).length)
++
++
+ null_dict.hello(true);  // Testing method call from object.
+ null_dict.alo(true); // Testing method call from object <again>.
+ ",You can create an issue for it and put it on the backlog so we don't forget it.
+2132,"@@ -21,7 +21,11 @@ func (i *startContainerInterceptor) InterceptResponse(r *http.Response) error {
+ 		return err
+ 	}
+
+-	cidrs, ok := i.proxy.weaveCIDRsFromConfig(container.Config)
++	if !validNetworkMode(container.HostConfig) {
++		Debug.Printf(""Ignoring container %s with --net=%s"", container.ID, networkMode(container.HostConfig))
++		return nil
++	}
++	cidrs, ok := i.proxy.weaveCIDRsFromConfig(container.Config, container.HostConfig)
+ 	if !ok {
+ 		Debug.Print(""No Weave CIDR, ignoring"")
+ 		return nil","So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log."
+2133,"@@ -436,11 +436,10 @@ def install(session, package, hash=None, version=None, tag=None):
+     if pkghash != hash_contents(response_contents):
+         raise CommandException(""Mismatched hash. Try again."")
+
+-    pkgobj = store.create_package(owner, pkg, PackageFormat.HDF5)
++    pkgobj = store.create_package(owner, pkg)
+     try:
+         pkgobj.install(response_contents, response_urls)
+     except PackageException as ex:
+-        pkgobj.clear_contents()
+         raise CommandException(""Failed to install the package: %s"" % ex)
+
+ def access_list(session, package):","An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package."
+2134,"@@ -34,10 +34,17 @@ type MiningBlock struct {
+ 	RemoteTxs types.TransactionsStream
+ }
+
++// In case we are proposing during proof-of-stake and we are supplied with header fields already
++type PresetHeaderFields struct {
++	Timestamp uint64
++	Random    common.Hash
++}
++
+ type MiningState struct {
+ 	MiningConfig    *params.MiningConfig
+ 	PendingResultCh chan *types.Block
+ 	MiningResultCh  chan *types.Block
++	ProposeBlockCh  chan *types.Block
+ 	MiningBlock     *MiningBlock
+ }
+ ",Let's add fee recipient as well.
+2135,"@@ -239,6 +239,7 @@ class FileDownloadTarget(_DownloadTarget):
+     def __init__(self, filename):
+         # pylint: disable=super-init-not-called
+         self.filename = filename
++        # pylint: enable=super-init-not-called
+
+     def suggested_filename(self):
+         return os.path.basename(self.filename)","No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function."
+2136,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher
+2137,"@@ -55,6 +55,15 @@ class ProposalDecorator < Draper::Decorator
+     ""#{number_approved} of #{total_approvers} approved.""
+   end
+
++  def table_waiting_text
++    actionable_step = currently_awaiting_steps.first
++    if actionable_step
++      actionable_step.decorate.waiting_text
++    else
++      I18n.t(""decorators.steps.approval.status.waiting"")
++    end
++  end
++
+   def step_text_for_user(key, user)
+     step = existing_approval_for(user)
+     klass = step.class.name.demodulize.downcase.to_sym",this name seems pretty vague -- thoughts on a more descriptive method name?
+2138,"@@ -1,4 +1,4 @@
+-// <copyright file=""MeterFactory.cs"" company=""OpenTelemetry Authors"">
++// <copyright file=""MeterFactory.cs"" company=""OpenTelemetry Authors"">
+ // Copyright The OpenTelemetry Authors
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");",what changed in this line?
+2139,"@@ -43,13 +43,16 @@ import { isZeroReport } from '../../modules/search-console/util/is-zero-report';
+ import sumObjectListValue from '../../util/sum-object-list-value';
+ const { useSelect } = Data;
+
++// reportArgs is declared in this higher scope so that it can be used by hasData.
++let reportArgs;
++
+ const AdminBarClicks = ( { className } ) => {
+ 	const url = useSelect( ( select ) => select( CORE_SITE ).getCurrentEntityURL() );
+ 	const { compareStartDate, endDate } = useSelect( ( select ) => select( CORE_USER ).getDateRangeDates( {
+ 		compare: true,
+ 		offsetDays: DATE_RANGE_OFFSET,
+ 	} ) );
+-	const reportArgs = {
++	reportArgs = {
+ 		startDate: compareStartDate,
+ 		endDate,
+ 		dimensions: 'date',","Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though."
+2140,"@@ -38,7 +38,6 @@ class ExceptionListener
+             return $event->getException()->getMessage();
+         }
+
+-        /** @var \JavierEguiluz\Bundle\EasyAdminBundle\Exception\BaseException */
+         $exception = $event->getException();
+         $exceptionClassName = basename(str_replace('\\', '/', get_class($exception)));
+ ","This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN."
+2141,"@@ -228,10 +228,16 @@ func (p *ReverseProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request, extr
+
+ 		outreq.Write(backendConn)
+
++		errCh := make(chan error, 1)
+ 		go func() {
+-			io.Copy(backendConn, conn) // write tcp stream to backend.
++			_, err := io.Copy(backendConn, conn) // write tcp stream to backend.
++			errCh <- err
+ 		}()
+-		io.Copy(conn, backendConn) // read tcp stream from backend.
++		go func() {
++			_, err := io.Copy(conn, backendConn) // read tcp stream from backend.
++			errCh <- err
++		}()
++		<-errCh
+ 	} else {
+ 		defer res.Body.Close()
+ 		for _, h := range hopHeaders {",This looks like you're not collecting everything from the error channel.
+2142,"@@ -1,10 +1,10 @@
+ class CheckoutMailer < BaseMailer
+   def receipt(checkout)
+-    @checkout = checkout
++    @plan = checkout.plan
+
+     mail(
+-      to: @checkout.user_email,
+-      subject: ""Your receipt for #{@checkout.plan_name}""
++      to: checkout.user_email,
++      subject: ""Your receipt for #{@plan.name}""
+     )
+   end
+ end",This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution.
+2143,"@@ -77,7 +77,7 @@ class Image implements EntityFileUploadInterface
+      * @param string $entityName
+      * @param int $entityId
+      * @param string|null $type
+-     * @param string $temporaryFilename
++     * @param string|null $temporaryFilename
+      */
+     public function __construct($entityName, $entityId, $type, $temporaryFilename)
+     {",is there any scenario when `$temporaryFilename` can be null?
+2144,"@@ -171,6 +171,7 @@ class FlinkTypeToType extends FlinkTypeVisitor<Type> {
+   }
+
+   @Override
++  @SuppressWarnings(""ReferenceEquality"")
+   public Type visit(RowType rowType) {
+     List<Types.NestedField> newFields = Lists.newArrayListWithExpectedSize(rowType.getFieldCount());
+     boolean isRoot = root == rowType;","this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`"
+2145,"@@ -260,6 +260,7 @@ static void roots_drag_icon_handle_surface_commit(struct wl_listener *listener,
+ 		void *data) {
+ 	struct roots_drag_icon *icon =
+ 		wl_container_of(listener, icon, surface_commit);
++	roots_drag_icon_update_position(icon);
+ 	roots_drag_icon_damage_whole(icon);
+ }
+ ","No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`"
+2146,"@@ -102,11 +102,13 @@ def build_model_from_cfg(config_path, checkpoint_path, cfg_options=None):
+     return model
+
+
+-def preprocess_example_input(input_config):
++def preprocess_example_input(input_config, device=torch.device('cpu')):
+     """"""Prepare an example input image for ``generate_inputs_and_wrap_model``.
+
+     Args:
+         input_config (dict): customized config describing the example input.
++        device (<class 'torch.device'>): device type (CPU or CUDA)
++            for the one_img.
+
+     Returns:
+         tuple: (one_img, one_meta), tensor of the example input image and \",Have you tested exporting to ONNX with `device=cuda`?
+2147,"@@ -78,10 +78,14 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) {
+ // Validate returns an error if the values provided by flags are invalid.
+ func (o *jobLogsOpts) Validate() error {
+ 	if o.appName != """" {
+-		_, err := o.configStore.GetApplication(o.appName)
+-		if err != nil {
++		if _, err := o.configStore.GetApplication(o.appName); err != nil {
+ 			return err
+ 		}
++		if o.name != """" {
++			if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {
++				return err
++			}
++		}
+ 	}
+
+ 	if o.since != 0 && o.humanStartTime != """" {",Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`
+2148,"@@ -147,6 +147,19 @@ class Auth extends Controller
+      */
+     public function restore_onSubmit()
+     {
++        // Force Trusted Host verification on password reset link generation
++        // regardless of config to protect against host header poisoning
++        $trustedHosts = Config::get('app.trustedHosts', false);
++        if ($trustedHosts === false) {
++            $url = Config::get('app.url', null);
++            if (!empty($url)) {
++                // Explicitly only allow the APP_URL host and subdomains
++                Request::setTrustedHosts(['^(.+\.)?' . preg_quote(parse_url($url, PHP_URL_HOST)) . '$']);
++                // Trigger the host validation logic
++                Request::getHost();
++            }
++        }
++
+         $rules = [
+             'login' => 'required|between:2,255'
+         ];","@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless."
+2149,"@@ -259,7 +259,7 @@ func (c *NetworkPolicyController) triggerParentGroupSync(grp *antreatypes.Group)
+ // triggerCNPUpdates triggers processing of ClusterNetworkPolicies associated with the input ClusterGroup.
+ func (c *NetworkPolicyController) triggerCNPUpdates(cg *crdv1alpha3.ClusterGroup) error {
+ 	// If a ClusterGroup is added/updated, it might have a reference in ClusterNetworkPolicy.
+-	cnps, err := c.cnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)
++	cnps, err := c.acnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)
+ 	if err != nil {
+ 		klog.Errorf(""Error retrieving ClusterNetworkPolicies corresponding to ClusterGroup %s"", cg.Name)
+ 		return err","i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs"
+2150,"@@ -257,12 +257,12 @@ describe('text.accessibleTextVirtual', function() {
+ 		axe.testUtils.flatTreeSetup(fixture);
+
+ 		var target = axe.utils.querySelectorAll(axe._tree, '#t2label')[0];
+-		// Chrome 72: This is This is a label of
+-		// Firefox 62: This is ARIA Label
+-		// Safari 12.0: This is This is a label of
++		// Chrome 86: This is This is a label of
++		// Firefox 82: This is ARIA Label everything
++		// Safari 14.0: This is This is a label of everything
+ 		assert.equal(
+ 			axe.commons.text.accessibleTextVirtual(target),
+-			'This is This is a label of'
++			'This is This is a label of everything'
+ 		);
+ 	});
+ ",Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?
+2151,"@@ -156,6 +156,10 @@ func (s *stream) Close() error {
+ 	return nil
+ }
+
++func (s *stream) FullClose() error {
++	return s.Close()
++}
++
+ type record struct {
+ 	b      []byte
+ 	c      int","This method should behave as intended, to block until it reads an EOF from the other side."
+2152,"@@ -1924,7 +1924,7 @@ func GitFsck() {
+ 			repo := bean.(*Repository)
+ 			repoPath := repo.RepoPath()
+ 			if err := git.Fsck(repoPath, setting.Cron.RepoHealthCheck.Timeout, setting.Cron.RepoHealthCheck.Args...); err != nil {
+-				desc := fmt.Sprintf(""Fail to health check repository '%s': %v"", repoPath, err)
++				desc := fmt.Sprintf(""Health check failed on repository '%s': %v"", repoPath, err)
+ 				log.Warn(desc)
+ 				if err = CreateRepositoryNotice(desc); err != nil {
+ 					log.Error(3, ""CreateRepositoryNotice: %v"", err)","I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?"
+2153,"@@ -141,9 +141,15 @@ namespace Datadog.Trace
+             if (AzureAppServices.Metadata?.IsRelevant ?? false)
+             {
+                 span.SetTag(Tags.AzureAppServicesSiteName, AzureAppServices.Metadata.SiteName);
++                span.SetTag(Tags.AzureAppServicesSiteKind, AzureAppServices.Metadata.SiteKind);
++                span.SetTag(Tags.AzureAppServicesSiteType, AzureAppServices.Metadata.SiteType);
+                 span.SetTag(Tags.AzureAppServicesResourceGroup, AzureAppServices.Metadata.ResourceGroup);
+                 span.SetTag(Tags.AzureAppServicesSubscriptionId, AzureAppServices.Metadata.SubscriptionId);
+                 span.SetTag(Tags.AzureAppServicesResourceId, AzureAppServices.Metadata.ResourceId);
++                span.SetTag(Tags.AzureAppServicesInstanceId, AzureAppServices.Metadata.InstanceId);
++                span.SetTag(Tags.AzureAppServicesInstanceName, AzureAppServices.Metadata.InstanceName);
++                span.SetTag(Tags.AzureAppServicesOperatingSystem, AzureAppServices.Metadata.OperatingSystem);
++                span.SetTag(Tags.AzureAppServicesRuntime, AzureAppServices.Metadata.Runtime);
+             }
+
+             // set the origin tag to the root span of each trace/subtrace","All these calls make me think we should refactor how traces are started and allow ""source tags"" that we initialize a trace with. I'd like to do this in a follow up."
+2154,"@@ -1,6 +1,6 @@
+ // DO NOT EDIT: This file is autogenerated via the builtin command.
+
+-package v1_test
++package v1
+
+ import (
+ 	ast ""github.com/influxdata/flux/ast""",This file shouldn't be in this PR
+2155,"@@ -1881,7 +1881,7 @@ class ArrayAssignmentTest extends TestCase
+                     takesArray($a);',
+                 'error_message' => 'InvalidScalarArgument',
+             ],
+-            'nonEmptyAssignmentToListElementChangeType' => [
++            'SKIPPED-nonEmptyAssignmentToListElementChangeType' => [ // Should be LessSpecificReturnStatement?
+                 '<?php
+                     /**
+                      * @param non-empty-list<string> $arr","This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list<string>' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list<string>`. Thoughts?"
+2156,"@@ -123,7 +123,7 @@ public class RestrictedDefaultPrivacyController implements PrivacyController {
+       final String privacyUserId,
+       final Optional<PrivacyGroup> maybePrivacyGroup) {
+     try {
+-      LOG.trace(""Storing private transaction in enclave"");
++      LOG.info(""Storing private transaction in enclave"");
+       final SendResponse sendResponse =
+           sendRequest(privateTransaction, privacyUserId, maybePrivacyGroup);
+       return sendResponse.getKey();",Are you going to change that back?
+2157,"@@ -51,6 +51,16 @@ tune ?= generic
+ cpu ?= $(arch)
+ fpu ?=
+ bits ?= $(shell getconf LONG_BIT)
++staticbuild ?= false
++
++# Set static building if requested
++ifeq (true,$(staticbuild))
++  use += llvm_link_static
++else
++  ifneq (false,$(staticbuild))
++    $(error staticbuild must be true or false)
++  endif
++endif
+
+ ifndef verbose
+   SILENT = @","we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change."
+2158,"@@ -1088,6 +1088,7 @@ function createFunctionsMenu() {
+         {text: 'Power', handler: applyFuncToEachWithInput('pow', 'Please enter a power factor')},
+         {text: 'Square Root', handler: applyFuncToEach('squareRoot')},
+         {text: 'Time-adjusted Derivative', handler: applyFuncToEachWithInput('perSecond', ""Please enter a maximum value if this metric is a wrapping counter (or just leave this blank)"", {allowBlank: true})},
++	{text: 'Delay', handler: applyFuncToEachWithInput('scale', 'Please enter the number of steps to delay')},
+         {text: 'Integral', handler: applyFuncToEach('integral')},
+         {text: 'Percentile Values', handler: applyFuncToEachWithInput('percentileOfSeries', ""Please enter the percentile to use"")},
+         {text: 'Non-negative Derivative', handler: applyFuncToEachWithInput('nonNegativeDerivative', ""Please enter a maximum value if this metric is a wrapping counter (or just leave this blank)"", {allowBlank: true})},",Note this should be `delay` instead of `scale` here. I'll fix this in my branch.
+2159,"@@ -87,7 +87,6 @@ class Uppy {
+     this.upload = this.upload.bind(this)
+
+     this.emitter = ee()
+-    this.on = this.emitter.on.bind(this.emitter)
+     this.off = this.emitter.off.bind(this.emitter)
+     this.once = this.emitter.once.bind(this.emitter)
+     this.emit = this.emitter.emit.bind(this.emitter)","`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?"
+2160,"@@ -1,4 +1,11 @@
+ # Copyright (c) OpenMMLab. All rights reserved.
++import random
++
++import torch
++import torch.distributed as dist
++import torch.nn.functional as F
++from mmcv.runner import get_dist_info
++
+ from ..builder import DETECTORS
+ from .single_stage import SingleStageDetector
+ ","Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future."
+2161,"@@ -38,6 +38,7 @@ import (
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ttime""
+
+ 	""context""
++
+ 	""github.com/cihub/seelog""
+ 	""github.com/pkg/errors""
+ )",Can you move this up along with the other builtin libraries?
+2162,"@@ -633,6 +633,12 @@ class GeneralSettingsPanel(SettingsPanel):
+ 			if globalVars.appArgs.secure:
+ 				item.Disable()
+ 			settingsSizerHelper.addItem(item)
++			# Translators: The label of a checkbox in general settings to toggle allowing of usage stats gathering
++			item=self.allowUsageStatsCheckBox=wx.CheckBox(self,label=_(""Allow the NVDA project to gather NVDA usage statistics""))
++			item.Value=config.conf[""update""][""allowUsageStats""]
++			if globalVars.appArgs.secure:
++				item.Disable()
++			settingsSizerHelper.addItem(item)
+ 			# Translators: The label of a checkbox in general settings to toggle startup notifications
+ 			# for a pending NVDA update.
+ 			item=self.notifyForPendingUpdateCheckBox=wx.CheckBox(self,label=_(""Notify for &pending update on startup""))",I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now.
+2163,"@@ -309,6 +309,14 @@ var opts struct {
+ 				Targets []core.BuildLabel `position-arg-name:""targets"" description:""Additional targets to load rules from""`
+ 			} `positional-args:""true""`
+ 		} `command:""rules"" description:""Prints built-in rules to stdout as JSON""`
++		Changes struct {
++			Before          string `short:""b"" long:""before"" description:""Revision to check out for the state before""`
++			After           string `short:""a"" long:""after"" required:""true"" description:""Revision to check out for the state after""`
++			CheckoutCommand string `long:""checkout_command"" default:""git checkout %s"" description:""Command to run to check out the before/after revisions.""`
++			Args            struct {
++				Files cli.StdinStrings `positional-arg-name:""files"" description:""Files to consider changed""`
++			} `positional-args:""true""`
++		} `command:""changes"" description:""Calculates the difference between two different states of the build graph""`
+ 	} `command:""query"" description:""Queries information about the build graph""`
+ }
+ ","Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here."
+2164,"@@ -381,6 +381,17 @@ class FDst(_Rex):
+         return f.server_conn.address and self.re.search(r)
+
+
++class FDstIP(_Rex):
++    code = ""ip""
++    help = ""Match destination ip address""
++    is_binary = False
++
++    def __call__(self, f):
++        if not f.server_conn or not f.server_conn.ip_address:
++            return False
++        return f.server_conn.ip_address and self.re.search(f.server_conn.ip_address[0])
++
++
+ class FReplay(_Action):
+     code = ""replay""
+     help = ""Match replayed flows""",Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :)
+2165,"@@ -60,7 +60,7 @@ namespace Nethermind.Core
+         public long GasUsed { get; set; }
+         public long GasLimit { get; set; }
+         public UInt256 Timestamp { get; set; }
+-        public DateTime TimestampDate => DateTimeOffset.FromUnixTimeSeconds((long) Timestamp).DateTime;
++        public DateTime TimestampDate => DateTimeOffset.FromUnixTimeSeconds((long) Timestamp).LocalDateTime;
+         public byte[] ExtraData { get; set; }
+         public Keccak MixHash { get; set; }
+         public ulong Nonce { get; set; }",Why local and not UTC?
+2166,"@@ -172,7 +172,8 @@ ExSqlComp::ReturnStatus ExSqlComp::createServer()
+   //
+   if (ret == ERROR)
+   {
+-	error(arkcmpErrorServer);
++	if ((!diagArea_->contains(-2013)) && (!diagArea_->contains(-2012))) // avoid generating redundant error
++	  error(arkcmpErrorServer);
+ 	if (getenv(""DEBUG_SERVER""))
+ 	  MessageBox(NULL, ""ExSqlComp:createServer"", ""error "", MB_OK|MB_ICONINFORMATION);
+   }",2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?
+2167,"@@ -8,6 +8,7 @@ package factory
+
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""sort""
+
+ 	""github.com/iotexproject/go-pkgs/hash""",move to line 14 below
+2168,"@@ -107,7 +107,7 @@ public class Rectangle2D {
+     return eastRelation;
+   }
+
+-  /** Checks if the rectangle intersects the provided triangle **/
++  /** Checks if the rectangle crosses the provided triangle **/
+   public boolean intersectsTriangle(int aX, int aY, int bX, int bY, int cX, int cY) {
+     // 1. query contains any triangle points
+     if (queryContainsPoint(aX, aY) || queryContainsPoint(bX, bY) || queryContainsPoint(cX, cY)) {",the method name should match teh docs
+2169,"@@ -278,13 +278,16 @@ func getOps(config Config, id TlfID) *folderBranchOps {
+ 		getOpsNoAdd(FolderBranch{id, MasterBranch})
+ }
+
++// TODO: Test MDv3.
++
+ // createNewRMD creates a new RMD for the given name. Returns its ID
+ // and handle also.
+ func createNewRMD(t *testing.T, config Config, name string, public bool) (
+ 	TlfID, *TlfHandle, *RootMetadata) {
+ 	id := FakeTlfID(1, public)
+ 	h := parseTlfHandleOrBust(t, config, name, public)
+-	rmd := newRootMetadataOrBust(t, id, h)
++	rmd, err := makeInitialRootMetadata(config.MetadataVersion(), id, h)
++	require.NoError(t, err)
+ 	return id, h, rmd
+ }
+ ",Won't this happen automatically when we flip the default version in the config?
+2170,"@@ -312,7 +312,7 @@ func TestLocalExec(t *testing.T) {
+ 		err = app.Exec(""web"", true, ""pwd"")
+ 		assert.NoError(err)
+ 		out := stdout()
+-		assert.Contains(out, ""/var/www/html/docroot"")
++		assert.Contains(out, ""/var/www/html"")
+
+ 		stdout = testcommon.CaptureStdOut()
+ 		switch app.GetType() {",This would also change back to /var/www/html/docroot if we go that way.
+2171,"@@ -0,0 +1,7 @@
++import { getImplicitRole } from '../commons/aria';
++
++function hasImplicitChromiumRoleMatches(node, virtualNode) {
++  return getImplicitRole(virtualNode) !== null;
++}
++
++export default hasImplicitChromiumRoleMatches;",This still needs to use the new option. We'll need tests for it too.
+2172,"@@ -0,0 +1,16 @@
++#appModules/egui.py
++#A part of NonVisual Desktop Access (NVDA)
++#Copyright (C) 2020 Pavol Kecskemety <pavol.kecskemety@eset.sk>
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++
++import appModuleHandler
++
++class AppModule(appModuleHandler.AppModule):
++
++	def event_NVDAObject_init(self, obj):
++		obj.description = None
++		obj.shouldAllowIAccessibleFocusEvent=True
++
++		if obj.name == obj.value:
++			obj.value = None",We are no longer including file name in the source files.
+2173,"@@ -4,6 +4,9 @@ class ApplicationController < ActionController::Base
+   # Look for template overrides before rendering
+   before_filter :prepend_view_paths
+
++  # Set current user (see set_current_user)
++  before_filter :set_current_user
++
+   include GlobalHelpers
+   include Pundit
+   helper_method GlobalHelpers.instance_methods",no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers.
+2174,"@@ -169,4 +169,8 @@ public class EthProtocol implements SubProtocol {
+     public static final int V65 = 65;
+     public static final int V66 = 66;
+   }
++
++  public static boolean isEth66Compatible(final Capability capability) {
++    return capability.getName().equals(NAME) && capability.getVersion() >= ETH66.getVersion();
++  }
+ }","Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?"
+2175,"@@ -193,6 +193,7 @@ RSpec.describe RSpec::Core::Example, :parent_metadata => 'sample' do
+         expect(RSpec::Matchers).not_to receive(:generated_description)
+         example_group.example { assert 5 == 5 }
+         example_group.run
++        RSpec::Mocks.space.reset_all
+       end
+
+       it ""uses the file and line number"" do","Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?"
+2176,"@@ -428,6 +428,9 @@ func (cg *configGenerator) convertSlackConfig(ctx context.Context, in monitoring
+ 			return nil, errors.Errorf(""failed to get key %q from secret %q"", in.APIURL.Key, in.APIURL.Name)
+ 		}
+ 		out.APIURL = strings.TrimSpace(url)
++		if _, err := ValidateURL(out.APIURL); err != nil {
++			return nil, errors.Wrapf(err, ""invalid 'apiURL' %s in slack config"", out.APIURL)
++		}
+ 	}
+
+ 	var actions []slackAction","since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently)."
+2177,"@@ -21,11 +21,11 @@ import (
+
+ func TestExtendPartialURL(t *testing.T) {
+ 	want := ""projects/foo/zones/bar/disks/baz""
+-	if s := extendPartialURL(""zones/bar/disks/baz"", ""foo""); s != want {
++	if s := normalizeToPartialURL(""zones/bar/disks/baz"", ""foo""); s != want {
+ 		t.Errorf(""got: %q, want: %q"", s, want)
+ 	}
+
+-	if s := extendPartialURL(""projects/foo/zones/bar/disks/baz"", ""gaz""); s != want {
++	if s := normalizeToPartialURL(""projects/foo/zones/bar/disks/baz"", ""gaz""); s != want {
+ 		t.Errorf(""got: %q, want %q"", s, want)
+ 	}
+ }",TestNormalize... I would also split them
+2178,"@@ -49,7 +49,7 @@ def readObjects(obj):
+ 	_startGenerator(readObjectsHelper_generator(obj))
+
+ def generateObjectSubtreeSpeech(obj,indexGen):
+-	index=indexGen.next()
++	index=next(indexGen)
+ 	speech.speakObject(obj,reason=controlTypes.REASON_SAYALL,index=index)
+ 	yield obj,index
+ 	child=obj.simpleFirstChild",All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition.
+2179,"@@ -89,8 +89,10 @@ func (l *twoRandomChoicesList) Remove(peer peer.StatusPeer, _ peer.Identifier, p
+ }
+
+ func (l *twoRandomChoicesList) Choose(_ *transport.Request) peer.StatusPeer {
+-	l.m.RLock()
+-	defer l.m.RUnlock()
++	// Usage of a wite lock because r.random.Intn is not thread safe
++	// see: https://golang.org/pkg/math/rand/
++	l.m.Lock()
++	defer l.m.Unlock()
+
+ 	numSubs := len(l.subscribers)
+ 	if numSubs == 0 {","Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that ""large"" write lock really but lock namely for ""rand"". Or least use a separate Lock (Mutex), namely for ""rand"" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair."
+2180,"@@ -2,6 +2,11 @@
+ # For details: https://github.com/PyCQA/pylint/blob/master/COPYING
+
+ import re
++import sys
++
++from astroid.__pkginfo__ import version as astroid_version
++
++from pylint.__pkginfo__ import version as pylint_version
+
+ # Allow stopping after the first semicolon/hash encountered,
+ # so that an option can be continued with the reasons",Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?
+2181,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.
+2182,"@@ -94,7 +94,7 @@ class BazelBuildFileView {
+     goPkg = goPkg.replaceFirst(""cloud\\/"", """");
+
+     String goImport = """";
+-    if (isCloud) {
++    if (isCloud || protoPkg.contains(""cloud"")) {
+       goImport = ""cloud.google.com/go/"";
+       goPkg = goPkg.replaceFirst(""v(.+);"", ""apiv$1;"");
+     } else {","This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(""cloud"")` from here to the place where `assembleGoImportPath` is called."
+2183,"@@ -1693,7 +1693,9 @@ Ex_Lob_Error ExLob::readDataToLocalFile(char *fileName,  Int64 offset, Int64 siz
+     // open the targte file for writing
+     int filePerms = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
+     int openFlags = O_RDWR ; // O_DIRECT needs mem alignment
+-    if ((LobTgtFileFlags)fileflags == Lob_Append_Or_Error )
++    if (((LobTgtFileFlags)fileflags == Lob_Append_Or_Error ) ||
++	((LobTgtFileFlags)fileflags == Lob_Error_Or_Create ) ||
++	((LobTgtFileFlags)fileflags == Lob_Append_Or_Create))
+       openFlags |= O_APPEND;
+     else
+       openFlags |= O_TRUNC;",Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.)
+2184,"@@ -124,7 +124,7 @@ public class DockerOptions {
+       for (int i = 0; i < maxContainerCount; i++) {
+         node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
+       }
+-      LOG.info(String.format(
++      LOG.finest(String.format(
+           ""Mapping %s to docker image %s %d times"",
+           caps,
+           name,",This change prevents a user understanding how their server is configured. Best to leave at `info` level.
+2185,"@@ -471,8 +471,10 @@ void TSSLSocket::checkHandshake() {
+       }
+     } while (rc == 2);
+   } else {
+-    // set the SNI hostname
+-    SSL_set_tlsext_host_name(ssl_, getHost().c_str());
++    /* OpenSSL < 0.9.8f does not have SSL_set_tlsext_host_name() */
++    #if defined(SSL_set_tlsext_host_name) // set the SNI hostname
++      SSL_set_tlsext_host_name(ssl_, getHost().c_str());
++    #endif
+     do {
+       rc = SSL_connect(ssl_);
+       if (rc <= 0) {",Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library.
+2186,"@@ -367,7 +367,7 @@ var (
+ 		},
+ 	}
+
+-	readBlockProducersByHeightTests = []struct {
++	readActiveBlockProducersByHeightTests = []struct {
+ 		// Arguments
+ 		protocolID            string
+ 		protocolType          string",`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`)
+2187,"@@ -447,10 +447,10 @@ public class SyncManager {
+         int totalSize = target.getTotalSize();
+         sync.setTotalSize(totalSize);
+         updateSync(sync, SyncState.Status.RUNNING, 0, callback);
+-
++        final String idField = sync.getTarget().getIdFieldName();
+         while (records != null) {
+             // Save to smartstore
+-            saveRecordsToSmartStore(soupName, records, mergeMode);
++            saveRecordsToSmartStore(soupName, records, mergeMode, idField);
+             countSaved += records.length();
+             maxTimeStamp = Math.max(maxTimeStamp, target.getLatestModificationTimeStamp(records));
+ ",Falls back on `Constants.ID` if there's no custom field set.
+2188,"@@ -509,6 +509,7 @@ public class FileAccessIO<T extends DvObject> extends StorageIO<T> {
+
+         try {
+             in = new FileInputStream(getFileSystemPath().toFile());
++            in.skip(this.getOffset());
+         } catch (IOException ex) {
+             // We don't particularly care what the reason why we have
+             // failed to access the file was.","I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()"
+2189,"@@ -32,6 +32,11 @@ public class MethodNameDeclaration extends AbstractNameDeclaration {
+         return p.isVarargs();
+     }
+
++    public boolean isPrimitiveReturnType() {
++        return getMethodNameDeclaratorNode().getParent().getResultType().getChild(0)
++                .getChild(0) instanceof ASTPrimitiveType;
++    }
++
+     public ASTMethodDeclarator getMethodNameDeclaratorNode() {
+         return (ASTMethodDeclarator) node;
+     }","In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge."
+2190,"@@ -83,6 +83,7 @@ func main() {
+ 			tch.NewInbound(channel, tch.ListenAddr("":28941"")),
+ 			http.NewInbound("":24034""),
+ 		},
++		Interceptors: yarpc.Interceptors{requestLogInterceptor{}},
+ 	})
+
+ 	handler := handler{items: make(map[string]string)}","If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter."
+2191,"@@ -1011,5 +1011,13 @@ func (e *ETCD) GetMembersClientURLs(ctx context.Context) ([]string, error) {
+
+ // RemoveSelf will remove the member if it exists in the cluster
+ func (e *ETCD) RemoveSelf(ctx context.Context) error {
+-	return e.removePeer(ctx, e.name, e.address, true)
++	if err := e.removePeer(ctx, e.name, e.address, true); err != nil {
++		return err
++	}
++
++	// backup the data dir to avoid issues when re-enabling etcd
++	oldDataDir := etcdDBDir(e.config) + ""-old-"" + strconv.Itoa(int(time.Now().Unix()))
++
++	// move the data directory to a temp path
++	return os.Rename(etcdDBDir(e.config), oldDataDir)
+ }",Is there anything we should do in the event we're unable to renaming the directory?
+2192,"@@ -17,12 +17,17 @@ limitations under the License.
+ package main
+
+ import (
+-	""github.com/google/knative-gcp/pkg/broker/ingress""
+ 	""go.uber.org/zap""
++
++	""github.com/google/knative-gcp/pkg/broker/ingress""
+ 	""knative.dev/pkg/logging""
+ 	""knative.dev/pkg/signals""
+ )
+
++// main creates and starts an ingress handler using default options.
++// 1. it listens on port 8080
++// 2. it reads ""GOOGLE_CLOUD_PROJECT"" env var for pubsub project.
++// 3. it expects broker configmap mounted at ""/var/run/cloud-run-events/broker/targets""
+ func main() {
+ 	// Since we pass nil, a default config with no error will be returned.
+ 	cfg, _ := logging.NewConfigFromMap(nil)",How is this env var populated? Can this be retrieved from cluster metadata?
+2193,"@@ -61,10 +61,11 @@ func (s *Service) reconcileInternetGateways() error {
+ 		EC2Client:   s.scope.EC2,
+ 		BuildParams: s.getGatewayTagParams(*gateway.InternetGatewayId),
+ 	})
+-
+ 	if err != nil {
++		record.Warnf(s.scope.Cluster, ""FailedTagInternetGateway"", ""Failed to tag managed Internet Gateway %q: %v"", gateway.InternetGatewayId, err)
+ 		return errors.Wrapf(err, ""failed to tag internet gateway %q"", *gateway.InternetGatewayId)
+ 	}
++	record.Eventf(s.scope.Cluster, ""SuccessfulTagInternetGateway"", ""Tagged managed Internet Gateway %q"", gateway.InternetGatewayId)
+
+ 	return nil
+ }","Should probably skip the success event here, since it could be a noop."
+2194,"@@ -1840,7 +1840,8 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
+                 chaptercardbuilder.buildChapterCards(item, chapters, {
+                     itemsContainer: scenesContent,
+                     backdropShape: 'overflowBackdrop',
+-                    squareShape: 'overflowSquare'
++                    squareShape: 'overflowSquare',
++                    imageBlurhashes: item.ImageBlurHashes
+                 });
+             });
+         } else {",I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan
+2195,"@@ -509,9 +509,6 @@ func DecryptDecode(ctx context.Context, k *secrets.Keeper, post Decode) Decode {
+ }
+
+ // DecoderByName returns a *Decoder based on decoderName.
+-// It is intended to be used by VariableURLOpeners in driver packages.
+-var DecoderByName = decoderByName
+-
+ // Supported values include:
+ //   - empty string: Returns the default from the URLOpener.Decoder, or
+ //       BytesDecoder if URLOpener.Decoder is nil (which is true if you're","Let's keep this line in the docstring, to let end users know they shouldn't be using this directly."
+2196,"@@ -39,13 +39,10 @@ func (p *Protocol) validateCreateStake(ctx context.Context, act *action.CreateSt
+ 	if act.Amount().Cmp(p.config.MinStakeAmount) == -1 {
+ 		return errors.Wrap(ErrInvalidAmount, ""stake amount is less than the minimum requirement"")
+ 	}
+-	if act.GasPrice().Sign() < 0 {
+-		return errors.Wrap(action.ErrGasPrice, ""negative value"")
+-	}
+ 	if !p.inMemCandidates.ContainsName(act.Candidate()) {
+ 		return errors.Wrap(ErrInvalidCanName, ""cannot find candidate in candidate center"")
+ 	}
+-	return nil
++	return act.AbstractAction.SelfCheck()
+ }
+
+ func (p *Protocol) validateUnstake(ctx context.Context, act *action.Unstake) error {",can do the same for other validateXXX()
+2197,"@@ -512,7 +512,7 @@ ReturnCode_t PublisherImpl::wait_for_acknowledgments(
+
+ const DomainParticipant* PublisherImpl::get_participant() const
+ {
+-    return participant_->get_participant();
++    return const_cast<const DomainParticipantImpl*>(participant_)->get_participant();
+ }
+
+ const Publisher* PublisherImpl::get_publisher() const",Why is this necessary?
+2198,"@@ -21,6 +21,7 @@ import os
+ import sys
+ import sphinx
+ from sphinx.errors import VersionRequirementError
++import datetime
+
+ curr_path = os.path.dirname(os.path.realpath(__file__))
+ libpath = os.path.join(curr_path, '../python-package/')",Please move this import upper to other similar imports
+2199,"@@ -1749,6 +1749,14 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
+                 arch_mcontext_reset_stolen_reg(dcontext, mc);
+             }
+         });
++        IF_AARCHXX({
++            // XXX i#4495: Consider saving stolen reg's application value.
++            set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
++            // XXX: This path is tested by linux.thread-reset and linux.clone-reset.
++            // We just haven't run those on ARM yet.
++            IF_ARM(ASSERT_NOT_TESTED());
++        });
++
+         /* We send all threads, regardless of whether was in DR or not, to
+          * re-interp from translated cxt, to avoid having to handle stale
+          * local state problems if we simply resumed.","Include the key word ""translated"". Otherwise the reader will find this confusing."
+2200,"@@ -263,6 +263,7 @@ public abstract class ElasticsearchStorage extends zipkin2.storage.StorageCompon
+   public abstract int namesLookback();
+
+   @Override
++  @Memoized // Memoized to reduce garbage as this is effectively a singleton.
+   public SpanStore spanStore() {
+     ensureIndexTemplates();
+     return new ElasticsearchSpanStore(this);",why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations.
+2201,"@@ -106,7 +106,7 @@ function nativeSelectValue(node) {
+   }
+
+   const options = querySelectorAll(vNode, 'option');
+-  const selectedOptions = options.filter(option => option.hasAttr('selected'));
++  const selectedOptions = options.filter(option => option.actualNode.selected);
+
+   // browser automatically selects the first option
+   if (!selectedOptions.length) {","I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug."
+2202,"@@ -8,13 +8,15 @@ from kinto.core.storage import (
+     DEFAULT_ID_FIELD, DEFAULT_MODIFIED_FIELD, DEFAULT_DELETED_FIELD,
+     MISSING)
+ from kinto.core.storage.postgresql.client import create_from_config
++from kinto.core.storage.postgresql.migrator import Migrator
+ from kinto.core.utils import COMPARISON
+
+
+ logger = logging.getLogger(__name__)
++HERE = os.path.abspath(os.path.dirname(__file__))
+
+
+-class Storage(StorageBase):
++class Storage(StorageBase, Migrator):
+     """"""Storage backend using PostgreSQL.
+
+     Recommended in production (*requires PostgreSQL 9.4 or higher*).",ditto about use of `abspath`
+2203,"@@ -30,13 +30,13 @@ public class Euler05Test {
+     }
+
+     private static long smallestPositiveNumberEvenlyDivisibleByAllNumbersFrom1To(int max) {
+-        final long smallestStepsNeeded = max * (max - 1);
+-        return Stream.gen(smallestStepsNeeded, prev -> prev + smallestStepsNeeded)
+-                .findFirst(val -> isEvenlyDivisibleByAllNumbersFrom1To(max, val))
+-                .get();
++        return Stream.rangeClosed(2, max)
++                .map(PrimeNumbers::factorization)
++                .reduce((m1, m2) -> m1.merged(m2, Math::max))
++                .foldLeft(1L, (xs, x) -> xs * pow(x.key, x.value));
+     }
+
+-    private static boolean isEvenlyDivisibleByAllNumbersFrom1To(int max, long val) {
+-        return !Stream.rangeClosed(1, max).exists(d -> val % d != 0);
++    private static long pow(long a, long p) {
++        return Stream.rangeClosed(1, p).fold(1L, (xs, x) -> xs * a);
+     }
+ }",this reduces the runtime by 50 times
+2204,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....
+2205,"@@ -956,10 +956,10 @@ public class TryTest extends AbstractValueTest {
+
+     private static <T, X extends Throwable> Try<T> failure(Class<X> exceptionType) {
+         try {
+-            final X exception = exceptionType.newInstance();
++            final X exception = exceptionType.getConstructor().newInstance();
+             return Try.failure(exception);
+-        } catch (InstantiationException | IllegalAccessException x) {
+-            throw new IllegalStateException(""Error instantiating "" + exceptionType);
++        } catch (Throwable e) {
++            throw new IllegalStateException(""Error instantiating "" + exceptionType, e);
+         }
+     }
+ ",direct `newInstance` call is also deprecated now
+2206,"@@ -15,14 +15,15 @@ import (
+ 	""syscall""
+ 	""time""
+
++	""github.com/vishvananda/netlink""
++	weaveapi ""github.com/weaveworks/weave/api""
++	""github.com/weaveworks/weave/common""
++	""golang.org/x/sys/unix""
+ 	api ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/client-go/informers""
+ 	""k8s.io/client-go/kubernetes""
+ 	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/cache""
+-
+-	weaveapi ""github.com/weaveworks/weave/api""
+-	""github.com/weaveworks/weave/common""
+ )
+
+ type nodeInfo struct {","We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo."
+2207,"@@ -184,7 +184,7 @@ abstract class SnapshotProducer<ThisT> implements SnapshotUpdate<ThisT> {
+   /**
+    * Returns the snapshot summary from the implementation and updates totals.
+    */
+-  private Map<String, String> summary(TableMetadata previous) {
++  protected Map<String, String> summary(TableMetadata previous) {
+     Map<String, String> summary = summary();
+
+     if (summary == null) {",Why was this change needed?
+2208,"@@ -53,12 +53,14 @@ def get_if_raw_addr(ifname):
+     try:
+         fd = os.popen(""%s %s"" % (conf.prog.ifconfig, ifname))
+     except OSError, msg:
+-        raise Scapy_Exception(""Failed to execute ifconfig: (%s)"" % msg)
++        warning(""Failed to execute ifconfig: (%s)"" % msg)
++        return ""\0\0\0\0""
+
+     # Get IPv4 addresses
+     addresses = [l for l in fd.readlines() if l.find(""netmask"") >= 0]
+     if not addresses:
+-        raise Scapy_Exception(""No IPv4 address found on %s !"" % ifname)
++        warning(""No IPv4 address found on %s !"" % ifname)
++        return ""\0\0\0\0""
+
+     # Pack the first address
+     address = addresses[0].split(' ')[1]","can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(""netmask"") >= 0]`)"
+2209,"@@ -51,8 +51,8 @@ test_name ""C100554: \
+     message = ""The plan was expected to notify but did not""
+     assert_match(/Notice:/, result.stdout, message)
+     winrm_nodes.each do |node|
+-      message = ""The plan was expceted to mention the host #{node.hostname} with _output""
+-      assert_match(/#{node.hostname}""=>{""_output""=>/, result.stdout, message)
++      message = ""The plan was expected to mention the host #{node.hostname} with _output""
++      assert_match(/#{node.hostname}"",""status"":""success""/, result.stdout, message)
+     end
+
+     winrm_nodes.each do |node|",Why does this check differ from `plan_ssh.rb`?
+2210,"@@ -10,8 +10,8 @@ import (
+ 	""encoding/json""
+ 	""strconv""
+
++	""github.com/iotexproject/go-fsm""
+ 	""github.com/prometheus/client_golang/prometheus""
+-	""github.com/zjshen14/go-fsm""
+ 	""go.uber.org/zap""
+
+ 	""github.com/iotexproject/iotex-core/consensus""",File is not `goimports`-ed (from `goimports`)
+2211,"@@ -16,7 +16,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+     {
+         public const int MaxPooledWriteReqs = 1024;
+
+-        private const int _maxPendingWrites = 3;
+         private const int _maxBytesPreCompleted = 65536;
+         private const int _initialTaskQueues = 64;
+         private const int _maxPooledWriteContexts = 32;","It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it."
+2212,"@@ -34,6 +34,8 @@ int main (int argc, char * const * argv)
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
++		(""debug_clear_online_weight"", ""clear online_weights table"")
++		(""debug_dump_online_weight"", ""dump online_weights table"")
+ 		(""debug_dump_representatives"", ""List representatives and weights"")
+ 		(""debug_account_count"", ""Display the number of accounts"")
+ 		(""debug_mass_activity"", ""Generates fake debug activity"")",We have cli --online_weight_clear in cli.cpp
+2213,"@@ -225,7 +225,9 @@ func HTTPServerAttributesFromHTTPRequest(serverName, route string, request *http
+ 		attrs = append(attrs, HTTPRouteKey.String(route))
+ 	}
+ 	if values, ok := request.Header[""X-Forwarded-For""]; ok && len(values) > 0 {
+-		attrs = append(attrs, HTTPClientIPKey.String(values[0]))
++		if addresses := strings.Split(values[0], "",""); len(addresses) > 0 {
++			attrs = append(attrs, HTTPClientIPKey.String(addresses[0]))
++		}
+ 	}
+
+ 	return append(attrs, httpCommonAttributesFromHTTPRequest(request)...)",So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?
+2214,"@@ -93,6 +93,8 @@ public class WebUtils {
+         return ""Killing"";
+       case DISPATCHING:
+         return ""Dispatching"";
++      case EXECUTION_STOPPED:
++        return ""Execution stopped, crashed executor/container"";
+       default:
+     }
+     return ""Unknown"";","How is this message used? Can we remove the ""crashed executor/container"" part which is an implementation detail?"
+2215,"@@ -247,7 +247,8 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+         .put(GET_LOG, post(""/session/:sessionId/log""))
+         .put(GET_AVAILABLE_LOG_TYPES, get(""/session/:sessionId/log/types""))
+
+-        .put(STATUS, get(""/status""));
++        .put(STATUS, get(""/status""))
++        .put(HEAP_SNAPSHOT, get(""/session/:sessionId/chromium/heap_snapshot""));
+
+         nameToUrl = builder.build();
+   }","Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?"
+2216,"@@ -4,7 +4,13 @@
+   <div class=""text-box"">
+
+     <% if @purchaseable.video_available?(@video) %>
+-      <%= render 'watch_video', video: @video, purchase: @purchase %>
++      <div class=""purchase-return-link"">
++        <%=link_to ""Back"", purchase_path(@purchase)%>
++      </div>
++
++      <h3 class=""video-headline"">Watch or Download Video</h3>
++
++      <%= render 'watch_video', video: @video %>
+     <% else %>
+       <p>This video is not yet available. It will be released on <%= @purchaseable.video_available_on(@video).to_s(:simple) %></p>
+     <% end %>",Space after `=`.
+2217,"@@ -59,6 +59,7 @@ public class EdgeInvocation extends AbstractRestInvocation {
+     this.responseEx = new VertxServerResponseToHttpServletResponse(context.response());
+     this.httpServerFilters = httpServerFilters;
+     requestEx.setAttribute(RestConst.REST_REQUEST, requestEx);
++    setAfterCreateInvocationHandler(invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));
+   }
+
+   public void edgeInvoke() {",if just need to do something after createInvocation just override and call super first is enough?
+2218,"@@ -11,7 +11,7 @@ describe Travis::Build::Script::Scala do
+   end
+
+   it_behaves_like 'a build script'
+-  # it_behaves_like 'a jdk build'
++  it_behaves_like 'a jvm build'
+
+   it 'sets TRAVIS_SCALA_VERSION' do
+     should set 'TRAVIS_SCALA_VERSION', '2.10.0'","By the way, I fixed `announce` method (missing `super` call to announce JDK version)"
+2219,"@@ -505,9 +505,10 @@ public final class TreeSet<T> implements SortedSet<T>, Serializable {
+         }
+     }
+
++    @SuppressWarnings(""unchecked"")
+     @Override
+-    public boolean contains(T element) {
+-        return tree.contains(element);
++    public boolean contains(Object element) {
++        return tree.contains((T) element);
+     }
+
+     @Override",I'm not sure about that... This line can produce <code>ClassCastException</code> if <code>Comparator</code> do not check this.
+2220,"@@ -737,7 +737,7 @@ type MDOps interface {
+ 	// which may not yet be reflected in the MD if the TLF hasn't been rekeyed since it
+ 	// entered into a conflicting state.
+ 	GetLatestHandleForTLF(ctx context.Context, id TlfID) (
+-		*BareTlfHandle, error)
++		BareTlfHandle, error)
+ }
+
+ // KeyOps fetches server-side key halves from the key server.","There wasn't any special reason for this to return a pointer, right?"
+2221,"@@ -14,15 +14,15 @@ import org.mozilla.vrbrowser.R;
+ import org.mozilla.vrbrowser.ui.views.UIButton;
+ import org.mozilla.vrbrowser.ui.widgets.NotificationManager.Notification.NotificationPosition;
+
+-import java.util.HashMap;
+ import java.util.Iterator;
+ import java.util.Map;
++import java.util.concurrent.ConcurrentHashMap;
+
+ public class NotificationManager {
+
+     private static final int DEFAULT_DURATION = 3000;
+
+-    private static HashMap<Integer, NotificationData> mData = new HashMap<>();
++    private static ConcurrentHashMap<Integer, NotificationData> mData = new ConcurrentHashMap<>();
+
+     private static class NotificationData {
+ ",Why the need for a `ConcurrentHashMap`?
+2222,"@@ -272,8 +272,13 @@ class Note extends BaseItem {
+ 				let bProp = b[order.by];
+ 				if (typeof aProp === 'string') aProp = aProp.toLowerCase();
+ 				if (typeof bProp === 'string') bProp = bProp.toLowerCase();
+-				if (aProp < bProp) r = +1;
+-				if (aProp > bProp) r = -1;
++
++				if (order.by == 'title' && Setting.value('titleNaturalSort')) {
++					r = this.naturalSortCompare(aProp, bProp, false);
++				} else {
++					if (aProp < bProp) r = +1;
++					if (aProp > bProp) r = -1;
++				}
+ 				if (order.dir == 'ASC') r = -r;
+ 				if (r !== 0) return r;
+ 			}",New code should use strict equality `===`
+2223,"@@ -84,6 +84,19 @@ describe ""apply"" do
+         resources = result[0]['result']['report']['resource_statuses']
+         expect(resources).to include('Notify[hello world]')
+       end
++
++      it 'applies the deferred type' do
++        result = run_cli_json(%w[plan run basic::defer] + config_flags)
++        expect(result).not_to include('kind')
++        expect(result[0]['status']).to eq('success')
++        resources = result[0]['result']['report']['resource_statuses']
++
++        local_pid = resources['Notify[local pid]']['events'][0]['desired_value'][/(\d+)/, 1]
++        raise 'local pid was not found' if local_pid.nil?
++        remote_pid = resources['Notify[remote pid]']['events'][0]['desired_value'][/(\d+)/, 1]
++        raise 'remote pid was not found' if remote_pid.nil?
++        expect(local_pid).not_to eq(remote_pid)
++      end
+     end
+   end
+ end",`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\d+)/)` seems clearer.
+2224,"@@ -54,7 +54,7 @@ const (
+ // Time out individual tests after 10 seconds.
+ var individualTestTimeout = 10 * time.Second
+
+-func kbfsOpsInit(t *testing.T, changeMd bool) (mockCtrl *gomock.Controller,
++func kbfsOpsInit(t *testing.T) (mockCtrl *gomock.Controller,
+ 	config *ConfigMock, ctx context.Context, cancel context.CancelFunc) {
+ 	ctr := NewSafeTestReporter(t)
+ 	mockCtrl = gomock.NewController(ctr)",Removed now-unneeded param.
+2225,"@@ -107,6 +107,7 @@ VIEW DATA STRUCTURES
+   go-filecoin show                   - Get human-readable representations of filecoin objects
+
+ NETWORK COMMANDS
++  go-filecoin bitswap                - Explore libp2p bitswap
+   go-filecoin bootstrap              - Interact with bootstrap addresses
+   go-filecoin dht                    - Interact with the dht
+   go-filecoin id                     - Show info about the network peers","(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?"
+2226,"@@ -85,7 +85,7 @@ storiesOf( 'Analytics Module', module )
+ 				title={ __( 'Top acquisition sources over the last 28 days', 'google-site-kit' ) }
+ 				headerCtaLink=""https://analytics.google.com""
+ 				headerCtaLabel={ __( 'See full stats in Analytics', 'google-site-kit' ) }
+-				footerCtaLabel={ __( 'Analytics', 'google-site-kit' ) }
++				footerCtaLabel={ _x( 'Analytics', 'Service name', 'google-site-kit' ) }
+ 				footerCtaLink=""https://analytics.google.com""
+ 			>
+ 				<div className=""mdc-layout-grid"">",The `_x` function needs to be imported at the top of the file (in addition to `__`)
+2227,"@@ -78,8 +78,9 @@ namespace pwiz.SkylineTestFunctional
+             RunUI(() =>
+             {
+                 propDialog.SetQValueTo(0.003f);
++                propDialog.OkDialog();
+             });
+-            OkDialog(propDialog, propDialog.OkDialog);
++            WaitForClosedForm(propDialog);
+             WaitForCondition(() => (DetectionsGraphController.Settings.QValueCutoff == 0.003f));
+             AssertDataCorrect(pane, 0, 0.003f);
+ ",This is functionally equivalent to the code it replaces.
+2228,"@@ -26,6 +26,8 @@ import (
+ type ENI struct {
+ 	// ID is the id of eni
+ 	ID string `json:""ec2Id""`
++	// ENIType is the type of ENI, valid value: ""default"", ""vlan""
++	ENIType string `json:"",omitempty""`
+ 	// IPV4Addresses is the ipv4 address associated with the eni
+ 	IPV4Addresses []*ENIIPV4Address
+ 	// IPV6Addresses is the ipv6 address associated with the eni","can you change the field name here to ""InterfaceAssociationProtocol""? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload"
+2229,"@@ -1,5 +1,5 @@
+ /**
+- * core/widgets data store: widget tests.
++ * Widgets data store: widget tests.
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for the other cases."
+2230,"@@ -301,6 +301,19 @@ public class MetricRegistry implements MetricSet {
+         });
+     }
+
++    /**
++     * Return the {@link Gauge} registered under this name; or create and register
++     * a new {@link SettableGauge} if none is registered.
++     *
++     * @param name the name of the metric
++     * @return a new or pre-existing {@link SettableGauge}
++     * @since 4.2
++     */
++    @SuppressWarnings(""unchecked"")
++    public <T> SettableGauge<T> gauge(String name) {
++        return getOrAdd(name, MetricBuilder.GAUGES);
++    }
++
+     /**
+      * Return the {@link Gauge} registered under this name; or create and register
+      * a new {@link Gauge} using the provided MetricSupplier if none is registered.","Shouldn't line 313 be public \<T\> SettableGauge\<T\> **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well."
+2231,"@@ -287,7 +287,7 @@ def _has_bare_super_call(fundef_node):
+     return False
+
+
+-def _safe_infer_call_result(node, caller, context=None):
++def _safe_infer_call_result(node, caller, context=None): # pylint: disable=inconsistent-return-statements
+     """"""
+     Safely infer the return value of a function.
+ ",I would prefer to just fix the occurences of this new check rather than disable them
+2232,"@@ -117,9 +117,9 @@ public class UITestUtils {
+     public void addHostedFeedData() throws IOException {
+         if (feedDataHosted) throw new IllegalStateException(""addHostedFeedData was called twice on the same instance"");
+         for (int i = 0; i < NUM_FEEDS; i++) {
+-            Feed feed = new Feed(0, null, ""Title "" + i, ""http://example.com/"" + i, ""Description of feed "" + i,
++            Feed feed = new Feed(0, null, ""Title "" + i, ""https://news.google.com/news/rss?"" + i, ""Description of feed "" + i,
+                     ""http://example.com/pay/feed"" + i, ""author "" + i, ""en"", Feed.TYPE_RSS2, ""feed"" + i, null, null,
+-                    ""http://example.com/feed/src/"" + i, false);
++                    ""https://news.google.com/news/rss?"" + i, false);
+
+             // create items
+             List<FeedItem> items = new ArrayList<>();","The tests should be fixed in #4841, so this is no longer needed"
+2233,"@@ -0,0 +1,17 @@
++<?php
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Core\Infrastructure\Exception;
++
++class SerializationException extends SerializerException
++{
++    public function __construct(string $message, \Throwable $previous = null)
++    {
++        parent::__construct($message, $previous);
++    }
++}",I think it should been in `SharedKernel` module.
+2234,"@@ -317,6 +317,9 @@ type ACMEChallengeSolverHTTP01IngressTemplate struct {
+ 	// will override the in-built values.
+ 	// +optional
+ 	ACMEChallengeSolverHTTP01IngressObjectMeta `json:""metadata""`
++
++	// OverrideNginxIngressWhitelistAnnotation add description here
++	OverrideNginxIngressWhitelistAnnotation string `json:""overrideNginxIngressWhitelistAnnotation,omitempty""`
+ }
+
+ type ACMEChallengeSolverHTTP01IngressObjectMeta struct {",Can we add some description for this field?
+2235,"@@ -45,6 +45,7 @@ public class ProtoConverter extends Visitor<Expr, Object> {
+           .put(TimestampType.class, ""Time"")
+           .put(BytesType.class, ""String"")
+           .put(StringType.class, ""String"")
++          .put(TimeType.class, ""Duration"")
+           .build();
+
+   private final IdentityHashMap<Expression, DataType> typeMap;",Should its name be Time or Duration? I can see them both.
+2236,"@@ -31,6 +31,14 @@ type Option interface {
+ 	applyGRPCOption(*otlpconfig.Config)
+ }
+
++func asGRPCOptions(opts []Option) []otlpconfig.GRPCOption {
++	converted := make([]otlpconfig.GRPCOption, len(opts))
++	for i, o := range opts {
++		converted[i] = otlpconfig.NewGRPCOption(o.applyGRPCOption)
++	}
++	return converted
++}
++
+ // RetryConfig defines configuration for retrying batches in case of export
+ // failure using an exponential backoff.
+ type RetryConfig retry.Config",Is this used anywhere?
+2237,"@@ -205,6 +205,17 @@ func TestMerge(t *testing.T) {
+ 	}
+ }
+
++func TestEmpty(t *testing.T) {
++	var res *resource.Resource
++	require.Equal(t, """", res.SchemaURL())
++	require.Equal(t, """", res.String())
++	require.Equal(t, []attribute.KeyValue(nil), res.Attributes())
++
++	it := res.Iter()
++	require.Equal(t, 0, it.Len())
++	require.True(t, res.Equal(res))
++}
++
+ func TestDefault(t *testing.T) {
+ 	res := resource.Default()
+ 	require.False(t, res.Equal(resource.Empty()))",I believe that you can use `assert` instead of `require` here and in the following lines
+2238,"@@ -177,7 +177,7 @@ func (pb *Actor) CreateChannel(vmctx exec.VMContext, target address.Address, eol
+
+ 	err := withPayerChannels(ctx, storage, payerAddress, func(byChannelID exec.Lookup) error {
+ 		// check to see if payment channel is duplicate
+-		_, err := byChannelID.Find(ctx, channelID.KeyString())
++		err := byChannelID.Find(ctx, channelID.KeyString(), &PaymentChannel{})
+ 		if err != hamt.ErrNotFound { // we expect to not find the payment channel
+ 			if err == nil {
+ 				return Errors[ErrDuplicateChannel]",In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported).
+2239,"@@ -0,0 +1,8 @@
++package trojan
++
++var (
++	Contains    = contains
++	HashBytes   = hashBytes
++	PadBytes    = padBytesLeft
++	IsPotential = isPotential
++)",is this a new pattern we use in bee? interesting
+2240,"@@ -382,7 +382,13 @@ func (f *FsS3) Mkdir() error {
+ 	if err, ok := err.(*s3.Error); ok {
+ 		if err.Code == ""BucketAlreadyOwnedByYou"" {
+ 			return nil
++		} else if err.Code == ""BucketAlreadyExists"" {
++			// Unfortunately Qstack are not reliably returning
++			// BucketAlreadyOwnedByYou, but instead BucketAlreadyExists.
++			// Carry on and wait for potential failure later.
++			return nil
+ 		}
++
+ 	}
+ 	return err
+ }","If you think this PR works, i'll clean this up before resubmitting."
+2241,"@@ -148,6 +148,10 @@ public final class Const {
+   public static final String PATH_CHECKSESSION = ""checksession"";
+
+   public static final String URL_PREFIX = ""urlPrefix"";
+-
++
+   public static final String INSTANCE_PUBKEY_PRO = ""publickey"";
++
++  public static final String GROUPID = ""io.servicecomb"";
++
++  public static final String ARTIFACTID = ""java-chassis"";
+ }",are you sure you can read version by this artifactid?
+2242,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.
+2243,"@@ -388,10 +388,13 @@ func (c *client) parse(buf []byte) error {
+ 					arg = buf[c.as : i-c.drop]
+ 				}
+ 				var err error
+-				if c.typ == CLIENT {
++				switch c.typ {
++				case CLIENT:
+ 					err = c.processSub(arg)
+-				} else {
++				case ROUTER:
+ 					err = c.processRemoteSub(arg)
++				case GATEWAY:
++					err = c.processGatewaySubjectSub(arg)
+ 				}
+ 				if err != nil {
+ 					return err",Should we do our own vtable?
+2244,"@@ -41,7 +41,6 @@ module C2
+     }
+     config.roadie.url_options = config.action_mailer.default_url_options
+
+-    config.exceptions_app = self.routes
+     config.autoload_paths << Rails.root.join('lib')
+
+     config.assets.precompile << 'common/communicarts.css'",This is the actual fix.
+2245,"@@ -173,7 +173,7 @@ const (
+ 	// cache idx expiration
+ 	defaultCacheIdxExpiration = 5 * time.Minute
+ 	// default sync interval
+-	defaultSyncInterval = 10 * time.Second
++	defaultSyncInterval = 60 * time.Second
+ 	// coalesceMinimum
+ 	coalesceMinimum = 16 * 1024
+ 	// maxFlushWait is maximum we will wait to gather messages to flush.","If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide."
+2246,"@@ -341,11 +341,12 @@ type Decoder interface {
+ 	// (0, false).
+ 	MapLen() (int, bool)
+
+-	// If MapLen returned true, the DecodeMap will be called. It should iterate over
+-	// the fields of the value being decoded, invoking the callback on each with the
+-	// field name and a Decoder for the field value. If the callback returns false,
+-	// DecodeMap should return immediately.
+-	DecodeMap(func(string, Decoder) bool)
++	// DecodeMap iterates over the fields of the value being decoded, invoke the
++	// callback on each with field name, a Decoder for the field value, and a bool
++	// to indicate whether or not to use exact match for the field names. It should
++	// be called when MapLen returns true or decoding a struct. If the callback
++	// returns false, DecodeMap should return immediately.
++	DecodeMap(func(string, Decoder, bool) bool)
+
+ 	// AsInterface should decode the value into the Go value that best represents it.
+ 	AsInterface() (interface{}, error)",should be called => will be called
+2247,"@@ -133,12 +133,11 @@ func (c *roundCalculator) roundInfo(
+ ) (roundNum uint32, roundStartTime time.Time, err error) {
+ 	lastBlockTime := time.Unix(c.chain.GenesisTimestamp(), 0)
+ 	if height > 1 {
+-		var lastBlock *block.Footer
+-		if lastBlock, err = c.chain.BlockFooterByHeight(height - 1); err != nil {
++		var lastBlock *block.Header
++		if lastBlock, err = c.chain.BlockHeaderByHeight(height - 1); err != nil {
+ 			return
+ 		}
+-		lastBlockCommitTime := lastBlock.CommitTime()
+-		lastBlockTime = lastBlockTime.Add(lastBlockCommitTime.Sub(lastBlockTime) / c.blockInterval * c.blockInterval)
++		lastBlockTime = lastBlockTime.Add(lastBlock.Timestamp().Sub(lastBlockTime) / c.blockInterval * c.blockInterval)
+ 	}
+ 	if !lastBlockTime.Before(now) {
+ 		err = errors.Errorf(","not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different ""last block time"", some use ""commit time"", some use ""block time"". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion."
+2248,"@@ -190,10 +190,12 @@ public class CreateCollectionCmd implements OverseerCollectionMessageHandler.Cmd
+       try {
+         replicaPositions = buildReplicaPositions(ocmh.cloudManager, clusterState, clusterState.getCollection(collectionName), message, shardNames, sessionWrapper);
+       } catch (Assign.AssignmentException e) {
+-        ZkNodeProps deleteMessage = new ZkNodeProps(""name"", collectionName);
+-        new DeleteCollectionCmd(ocmh).call(clusterState, deleteMessage, results);
++        deleteCollection(clusterState, results, collectionName);
+         // unwrap the exception
+         throw new SolrException(ErrorCode.SERVER_ERROR, e.getMessage(), e.getCause());
++      } catch (SolrException e) {
++        deleteCollection(clusterState, results, collectionName);
++        throw e;
+       }
+
+       if (replicaPositions.isEmpty()) {",So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?
+2249,"@@ -316,13 +316,13 @@ def test_debug_logger_object():
+         assert dt.options.debug.enabled is True
+
+         DT = dt.rbind([])
+-        assert ""dt.rbind([]) {"" in logger.msg
++        assert ""datatable.rbind([]) {"" in logger.msg
+         assert re.search(r""} # \d+(?:\.\d+)?(?:[eE][+-]?\d+)? s"", logger.msg)
+         logger.msg = """"
+
+         with pytest.raises(TypeError):
+             dt.rbind(4)
+-        assert ""dt.rbind(4) {"" in logger.msg
++        assert ""datatable.rbind(4) {"" in logger.msg
+         assert re.search(r""} # \d+(?:\.\d+)?(?:[eE][+-]?\d+)? s \(failed\)"", logger.msg)
+
+ ",`dt` won't work for some reason?
+2250,"@@ -96,7 +96,7 @@ def add_db(doctest_namespace):
+     doctest_namespace[""db""] = db_name
+
+
+-@pytest.fixture(autouse=os.getenv(""KOALAS_USAGE_LOGGER"", None) is not None)
++@pytest.fixture(autouse=os.getenv(""KOALAS_USAGE_LOGGER"", """") != """")
+ def add_caplog(caplog):
+     with caplog.at_level(logging.INFO, logger=""databricks.koalas.usage_logger""):
+         yield","Is this because ""KOALAS_USAGE_LOGGER"" can be `None` ??"
+2251,"@@ -0,0 +1,16 @@
++using Nethermind.Int256;
++
++namespace Nethermind.JsonRpc.Modules.Eth
++{
++    public static class GasPriceConfig
++    {
++        public const int NoHeadBlockChangeErrorCode = 7; //Error code used in debug mode when the head block is not changed
++        public const int PercentileOfSortedTxs = 60; //Percentile of sortedTxList indexes to choose as gas price
++        public const int DefaultBlocksLimit = 20; //Limit for how many blocks we check txs in to add to sortedTxList
++        public const int DefaultGasPrice = 1; //Tx price added to sortedTxList for a block that has 0 txs (now adds 1 tx)
++        public const int SoftTxLimit = 40; //If a block adds only 1 tx price, the block is not counted towards BlocksLimit if sortedTxList.Count() + blocksLeftToCheck <= SoftTxLimit (after price is added to sortedTxList)
++        public const int DefaultBaseFee = 200; //Minimum price a transaction sender has to pay
++        public const int TxLimitFromABlock = 3; //Maximum number of tx we can add to sortedTxList from one block
++        public static readonly UInt256 _maxGasPrice = 500; //Maximum gas price we can return
++    }
++}",I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config
+2252,"@@ -38,7 +38,9 @@ import (
+ func TestNew(t *testing.T) {
+ 	ctx, _ := SetupFakeContext(t)
+
+-	c := NewController(ctx, configmap.NewStaticWatcher(
++	ctor := NewConstructor(&dataresidency.StoreSingleton{})
++
++	c := ctor(ctx, configmap.NewStaticWatcher(
+ 		&corev1.ConfigMap{
+ 			ObjectMeta: metav1.ObjectMeta{
+ 				Name:      logging.ConfigMapName(),",I would inline the constructor as well
+2253,"@@ -107,10 +107,10 @@ TEST(Scanner, Basic) {
+     };                                                               \
+     GraphScanner lexer;                                              \
+     lexer.setReadBuffer(input);                                      \
+-    nebula::GraphParser::semantic_type dumyyylval;                   \
+-    nebula::GraphParser::location_type dumyyyloc;                    \
++    nebula::GraphParser::semantic_type dummyyylval;                  \
++    nebula::GraphParser::location_type dummyyyloc;                   \
+     try {                                                            \
+-      auto token = lexer.yylex(&dumyyylval, &dumyyyloc);             \
++      auto token = lexer.yylex(&dummyyylval, &dummyyyloc);           \
+       if (token != 0) {                                              \
+         return AssertionFailure() << ""Lexical error should've ""      \
+                                   << ""happened for `"" << STR << ""'""; \",I'm not confident about this...
+2254,"@@ -34,6 +34,10 @@ import (
+ 	""github.com/jetstack/cert-manager/pkg/util/pki""
+ )
+
++var (
++	certificateRequestGvk = v1alpha1.SchemeGroupVersion.WithKind(""CertificateRequest"")
++)
++
+ func (c *Controller) Sync(ctx context.Context, cr *v1alpha1.CertificateRequest) (err error) {
+ 	c.metrics.IncrementSyncCallCount(ControllerName)
+ ",There is also `v1alpha1.CertificateRequestKind` I think?
+2255,"@@ -49,6 +49,10 @@ func SenderJob(name string, envVars []corev1.EnvVar) *batchv1.Job {
+ 	return baseJob(name, ""sender"", envVars)
+ }
+
++func BrokerSenderJob(name string, envVars []corev1.EnvVar) *batchv1.Job {
++	return baseJob(name, ""sender_gcpbroker"", envVars)
++}
++
+ // baseJob will return a base Job that has imageName and envVars set for its PodTemplateSpec.
+ func baseJob(name, imageName string, envVars []corev1.EnvVar) *batchv1.Job {
+ 	return &batchv1.Job{","Can we rename it to make it less confusing? Instead of ""sender-gcpbroker"", maybe name it to ""retryable-sender"""
+2256,"@@ -136,9 +136,8 @@ public class UnboundPredicate<T> extends Predicate<T, UnboundTerm<T>> implements
+     Literal<T> lit = literal().to(boundTerm.type());
+
+     if (lit == null) {
+-      throw new ValidationException(String.format(
+-          ""Invalid value for conversion to type %s: %s (%s)"",
+-          boundTerm.type(), literal().value(), literal().value().getClass().getName()));
++      throw new ValidationException(""Invalid value for conversion to type %s: %s (%s)"",
++          boundTerm.type(), literal().value(), literal().value().getClass().getName());
+
+     } else if (lit == Literals.aboveMax()) {
+       switch (op()) {","So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called."
+2257,"@@ -47,6 +47,19 @@ class OPFMetricsTest(unittest.TestCase):
+ < OPFMetricsTest.DELTA)
+
+
++  def testNRMSE(self):
++    nrmse = getModule(MetricSpec(""nrmse"", None, None,
++{""verbosity"" : OPFMetricsTest.VERBOSITY}))
++    gt = [9, 4, 5, 6]
++    p = [0, 13, 8, 3]
++    for i in xrange(len(gt)):
++      nrmse.addInstance(gt[i], p[i])
++    target = 1.342
++
++    self.assertTrue(abs(nrmse.getMetric()[""value""]-target)\
++< OPFMetricsTest.DELTA)
++
++
+   def testWindowedRMSE(self):
+     wrmse = getModule(MetricSpec(""rmse"", None, None,
+ {""verbosity"": OPFMetricsTest.VERBOSITY, ""window"":3}))",Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway
+2258,"@@ -90,6 +90,19 @@ try:
+ except ImportError:
+     GRAPHVIZ_INSTALLED = False
+
++""""""datatable""""""
++try:
++    from datatable import DataTable
++    DT_INSTALLED = True
++except ImportError:
++    DT_INSTALLED = False
++
++    class DataTable(object):
++        """"""Dummy class for DataTable.""""""
++
++        pass
++
++
+ """"""sklearn""""""
+ try:
+     from sklearn.base import BaseEstimator","@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`."
+2259,"@@ -37,7 +37,7 @@ module RSpec
+           profile.slowest_examples.each do |example|
+             @output.puts ""  #{example.full_description}""
+             @output.puts ""    #{bold(Helpers.format_seconds(example.execution_result.run_time))} "" \
+-                         ""#{bold(""seconds"")} #{format_caller(example.location)}""
++                         ""#{bold('seconds')} #{format_caller(example.location)}""
+           end
+         end
+ ",We're fine with double quotes here. Just for future reference.
+2260,"@@ -242,9 +242,5 @@ func (c call) maxAttemptsError(err error) {
+ }
+
+ func getErrorName(err error) string {
+-	errCode := yarpcerrors.ErrorCode(err)
+-	if errCode == yarpcerrors.CodeOK {
+-		return ""unknown_internal_yarpc""
+-	}
+-	return errCode.String()
++	return yarpcerrors.ErrorCode(err).String()
+ }","can we keep this around? We should make sure we can distinguish between properly wrapped errors and ""unwrapped"" errors"
+2261,"@@ -14265,6 +14265,10 @@ void PIPELINE_STATE::initGraphicsPipeline(ValidationStateTracker *state_data, co
+         }
+     }
+     graphicsPipelineCI.initialize(pCreateInfo, uses_color_attachment, uses_depthstencil_attachment);
++    if (graphicsPipelineCI.pInputAssemblyState) {
++        topology_at_rasterizer = graphicsPipelineCI.pInputAssemblyState->topology;
++    }
++
+     stage_state.resize(pCreateInfo->stageCount);
+     for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
+         const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];","`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first."
+2262,"@@ -1,6 +1,10 @@
+ const path = require(""path"");
++const { CleanWebpackPlugin} = require(""clean-webpack-plugin"");
+ const CopyPlugin = require(""copy-webpack-plugin"");
+
++// assets.js
++const Assets = require('./assets');
++
+ module.exports = {
+     context: path.resolve(__dirname, ""src""),
+     entry: ""./bundle.js"",",Should we just inline the assets here? I can't think of an advantage to having them in a separate file.
+2263,"@@ -175,13 +175,13 @@ func (t *endpointsChangesTracker) Update(em types.EndpointsMap) map[k8sproxy.Ser
+ 		for spn, endpoints := range change.current {
+ 			em[spn] = endpoints
+ 		}
+-		detectStaleConnections(change.previous, change.current, staleEndpoints)
++		detectStale(change.previous, change.current, staleEndpoints)
+ 	}
+ 	return staleEndpoints
+ }
+
+-// detectStaleConnections updates staleEndpoints with detected stale connections.
+-func detectStaleConnections(oldEndpointsMap, newEndpointsMap types.EndpointsMap, staleEndpoints map[k8sproxy.ServicePortName]map[string]k8sproxy.Endpoint) {
++// detectStale updates staleEndpoints with detected stale endpoints.
++func detectStale(oldEndpointsMap, newEndpointsMap types.EndpointsMap, staleEndpoints map[k8sproxy.ServicePortName]map[string]k8sproxy.Endpoint) {
+ 	for svcPortName, epList := range oldEndpointsMap {
+ 		for _, ep := range epList {
+ 			stale := true",detectStaleEndpoints to be more specific?
+2264,"@@ -100,6 +100,8 @@ class SpatialPoolerCompatabilityTest(unittest.TestCase):
+                            cppSp.getMinPctOverlapDutyCycles())
+     self.assertAlmostEqual(pySp.getMinPctActiveDutyCycles(),
+                            cppSp.getMinPctActiveDutyCycles())
++#    self.assertEqual(pySp.getRandomSP(),  #FIXME enable when done in C++ too
++#                     cppSP.getRandomSP())
+
+     numColumns = pySp.getNumColumns()
+     numInputs = pySp.getNumInputs()","Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost."
+2265,"@@ -78,7 +78,7 @@ func NewStorageMiningSubmodule(minerAddr address.Address, ds datastore.Batching,
+ 		PoStGenerator:    postGen,
+ 		minerNode:        minerNode,
+ 		storageMiner:     storageMiner,
+-		heaviestTipSetCh: c.HeaviestTipSetCh,
++		heaviestTipSetCh: make(chan interface{}),
+ 		poster:           poster.NewPoster(minerAddr, m.Outbox, s, c.State, stateViewer, mw),
+ 	}
+ ",Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method.
+2266,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (IAM) policy.]
++//snippet-sourcedescription:[GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (AWS IAM) policy.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+2267,"@@ -76,7 +76,7 @@ public class TestEdgeDriver extends RemoteWebDriver implements WebStorage, Locat
+                 .findFirst().orElseThrow(WebDriverException::new);
+
+         service = (EdgeDriverService) builder.withVerbose(true).withLogFile(logFile.toFile()).build();
+-        LOG.info(""edgedriver will log to "" + logFile);
++        LOG.fine(""edgedriver will log to "" + logFile);
+         service.start();
+         Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));
+       }",This is deliberately at this level.
+2268,"@@ -63,8 +63,10 @@ func stake2Transfer(args []string) error {
+
+ 	var payload []byte
+ 	if len(args) == 3 {
+-		payload = make([]byte, 2*len([]byte(args[2])))
+-		hex.Encode(payload, []byte(args[2]))
++		payload, err = hex.DecodeString(args[2])
++		if err != nil {
++			return output.NewError(output.ConvertError, ""failed to decode data"", err)
++		}
+ 	}
+
+ 	sender, err := signer()",payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go
+2269,"@@ -37,7 +37,14 @@ class PricingGroupDataFixture extends AbstractReferenceFixture
+
+         $pricingGroupData->name = 'Obyčejný zákazník';
+         $domainId = 2;
+-        $this->createPricingGroup($pricingGroupData, $domainId, self::PRICING_GROUP_ORDINARY_DOMAIN_2);
++
++        $alreadyCreatedDemoPricingGroupsByDomain = $this->pricingGroupFacade->getByDomainId($domainId);
++        if (count($alreadyCreatedDemoPricingGroupsByDomain) > 0) {
++            $pricingGroup = reset($alreadyCreatedDemoPricingGroupsByDomain);
++
++            $this->pricingGroupFacade->edit($pricingGroup->getId(), $pricingGroupData);
++            $this->addReference(self::PRICING_GROUP_ORDINARY_DOMAIN_2, $pricingGroup);
++        }
+
+         $pricingGroupData->name = 'VIP zákazník';
+         $domainId1 = 2;",should this be kept in the `else` branch?
+2270,"@@ -32,10 +32,11 @@ import (
+ 	""strings""
+ 	""time""
+
++	""sync""
++
+ 	""cloud.google.com/go/storage""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/daisy/compute""
+ 	""google.golang.org/api/option""
+-	""sync""
+ )
+
+ const defaultTimeout = ""10m""","Why not put this below ""strings""?"
+2271,"@@ -33,6 +33,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+         {
+         }
+
++        /// <summary>
++        /// For testing purposes.
++        /// </summary>
++        public int UvPipeCount => _dispatchPipes.Count;
++
+         private UvPipeHandle ListenPipe { get; set; }
+
+         public async Task StartAsync(",Make it `internal` if it's just for testing.
+2272,"@@ -1,4 +1,4 @@
+-# pylint: disable=missing-docstring,pointless-statement,expression-not-assigned,too-few-public-methods,import-error,no-init,wrong-import-position,no-else-return
++# pylint: disable=missing-docstring,pointless-statement,expression-not-assigned,too-few-public-methods,import-error,no-init,wrong-import-position,no-else-return, logical-tautology
+
+ # standard types
+ 1 in [1, 2, 3]",What is triggering this message in this file?
+2273,"@@ -212,7 +212,7 @@ def start_workers(args, actions, context, analyzer_config_map, skp_handler,
+         pool.map_async(check,
+                        analyzed_actions,
+                        1,
+-                       callback=worker_result_handler).get(float('inf'))
++                       callback=worker_result_handler).get()
+
+         pool.close()
+     except Exception:",Are you sure this should be removed?
+2274,"@@ -121,8 +121,7 @@ public class DefaultTrustedSocketFactory implements TrustedSocketFactory {
+
+
+     private Context context;
+-    private ProxySettings proxySettings;
+-
++    private ProxySettings proxySettings = new ProxySettings(false, """", 0);
+
+     public DefaultTrustedSocketFactory(Context context, ProxySettings proxySettings) {
+         this.context = context;",What's that good for? The field is initialized in the constructor.
+2275,"@@ -484,12 +484,14 @@ class _Connection(object):
+         if not isinstance(self.connection, SSL.Connection):
+             if not getattr(self.wfile, ""closed"", False):
+                 try:
+-                    self.wfile.flush()
+-                    self.wfile.close()
++                    if self.wfile:
++                        self.wfile.flush()
++                        self.wfile.close()
+                 except exceptions.TcpDisconnect:
+                     pass
+
+-            self.rfile.close()
++            if self.rfile:
++                self.rfile.close()
+         else:
+             try:
+                 self.connection.shutdown()",This shouldn't be necessary (same below). Do you have a traceback for me?
+2276,"@@ -13,6 +13,8 @@ import (
+ 	""strconv""
+ 	""syscall"" // only for Signal
+
++	""github.com/opencontainers/runc/libcontainer/logs""
++
+ 	""github.com/opencontainers/runc/libcontainer/cgroups""
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ 	""github.com/opencontainers/runc/libcontainer/intelrdt""",No newline needed here.
+2277,"@@ -7,11 +7,12 @@ package libkbfs
+ import (
+ 	""errors""
+ 	""fmt""
+-	""io/ioutil""
+ 	""os""
+ 	""path/filepath""
+ 	""sync""
+
++	""github.com/keybase/kbfs/ioutil""
++
+ 	""github.com/keybase/client/go/logger""
+ 	""github.com/keybase/kbfs/kbfscodec""
+ 	""github.com/keybase/kbfs/kbfscrypto""",Why a separate block?
+2278,"@@ -2531,10 +2531,16 @@ reg_get_size(reg_id_t reg)
+         return OPSZ_SCALABLE;
+     if (reg >= DR_REG_P0 && reg <= DR_REG_P15)
+         return OPSZ_SCALABLE_PRED;
++    if (reg == DR_REG_CNTVCT_EL0)
++        return OPSZ_8;
++    if (reg >= DR_REG_NZCV && reg <= DR_REG_FPSR)
++        return OPSZ_8;
+ #    endif
+     if (reg == DR_REG_TPIDRURW || reg == DR_REG_TPIDRURO)
+         return OPSZ_PTR;
+ #endif
++    LOG(GLOBAL, LOG_ANNOTATIONS, 2, ""reg=%d, %s, last reg=%d\n"", reg,
++        get_register_name(reg), DR_REG_LAST_ENUM);
+     CLIENT_ASSERT(false, ""reg_get_size: invalid register"");
+     return OPSZ_NA;
+ }",Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?
+2279,"@@ -684,11 +684,10 @@ is_private_key = lambda x: is_xprv(x) or is_private_key_list(x)
+ is_bip32_key = lambda x: is_xprv(x) or is_xpub(x)
+
+
+-def bip44_derivation(account_id):
+-    if bitcoin.TESTNET:
+-        return ""m/44'/1'/%d'""% int(account_id)
+-    else:
+-        return ""m/44'/0'/%d'""% int(account_id)
++def bip44_derivation(account_id, segwit=False):
++    bip  = 49 if segwit else 44
++    coin = 1 if bitcoin.TESTNET else 0
++    return ""m/%d'/%d'/%d'"" % (bip, coin, int(account_id))
+
+ def from_seed(seed, passphrase):
+     t = seed_type(seed)","`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you."
+2280,"@@ -129,10 +129,10 @@ namespace pwiz.Skyline.Controls.Graphs
+         public void SetQValueTo(float qValue)
+         {
+             if (qValue == .01f)
+-                rbQValue01.Select();
++                rbQValue01.Checked = true;
+             else
+             {
+-                rbQValueCustom.Select();
++                rbQValueCustom.Checked = true;
+                 txtQValueCustom.Text = qValue.ToString(CultureInfo.CurrentCulture);
+             }
+         }","Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though."
+2281,"@@ -111,7 +111,14 @@ func (p *VSphereCloudBuilder) addClusterDeploymentPlatform(o *Builder, cd *hivev
+ }
+
+ func (p *VSphereCloudBuilder) addMachinePoolPlatform(o *Builder, mp *hivev1.MachinePool) {
+-	mp.Spec.Platform.VSphere = &hivev1vsphere.MachinePool{}
++	mp.Spec.Platform.VSphere = &hivev1vsphere.MachinePool{
++		NumCPUs:           2,
++		NumCoresPerSocket: 1,
++		MemoryMiB:         8192,
++		OSDisk: hivev1vsphere.OSDisk{
++			DiskSizeGB: 120,
++		},
++	}
+ }
+
+ func (p *VSphereCloudBuilder) addInstallConfigPlatform(o *Builder, ic *installertypes.InstallConfig) {","Seems a little low, but is this an installer default?"
+2282,"@@ -10,6 +10,19 @@ from kinto.core import utils
+ logger = structlog.get_logger()
+
+
++def reset_logger():
++    """"""Hack to work around https://github.com/hynek/structlog/issues/71.
++
++    This clears a magic field in the logger so that it will regenerate
++    the right kind of logger on its next use.
++
++    Do this when you call structlog.configure(). Otherwise, some parts
++    of the logger will be outdated and you may get strange behavior.
++
++    """"""
++    logger._logger = None
++
++
+ def decode_value(value):
+     try:
+         return six.text_type(value)",Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger.
+2283,"@@ -31,11 +31,8 @@ type Block struct {
+ 	// holders for an epoch.
+ 	Parents SortedCidSet `json:""parents""`
+
+-	// ParentWeightNum is the numerator of the aggregate chain weight of the parent set.
+-	ParentWeightNum Uint64 `json:""parentWeightNumerator""`
+-
+-	// ParentWeightDenom is the denominator of the aggregate chain weight of the parent set
+-	ParentWeightDenom Uint64 `json:""parentWeightDenominator""`
++	// ParentWeight is the aggregate chain weight of the parent set.
++	ParentWeight Uint64 `json:""parentWeight""`
+
+ 	// Height is the chain height of this block.
+ 	Height Uint64 `json:""height""`",This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time
+2284,"@@ -464,11 +464,9 @@ func TestNodeCacheGCReal(t *testing.T) {
+
+ 	childNode1 = nil
+ 	runtime.GC()
+-	_ = <-finalizerChan
++	<-finalizerChan
+
+-	if len(ncs.nodes) != 2 {
+-		t.Errorf(""Expected %d nodes, got %d"", 2, len(ncs.nodes))
+-	}
++	require.Len(t, ncs.nodes, 1)
+
+ 	// Make sure childNode2 isn't GCed until after this point.
+ 	func(interface{}) {}(childNode2)",Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior.
+2285,"@@ -45,7 +45,7 @@ func TestValidJsonAccount(t *testing.T) {
+         ""domain"": {
+             ""fulldomain"": ""fooldom"",
+             ""password"": ""secret"",
+-            ""subdomain"": ""subdoom"",
++            ""subdomain"": ""subdom"",
+             ""username"": ""usernom""
+         }
+     }`)","Afaict, nothing cares"
+2286,"@@ -507,7 +507,9 @@ func decryptMDPrivateData(ctx context.Context, codec kbfscodec.Codec,
+ 		}
+ 	}
+
+-	// Re-embed the block changes if it's needed.
++	// Re-embed the block changes if it's needed.  TODO: we don't need
++	// to do this in minimal mode, since there's no node cache
++	// (KBFS-2026).
+ 	err := reembedBlockChanges(
+ 		ctx, codec, bcache, bops, rmdWithKeys.TlfID(),
+ 		&pmd, rmdWithKeys, log)","I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?"
+2287,"@@ -5,7 +5,7 @@ using System.Linq;
+
+ namespace Datadog.Trace.Headers
+ {
+-    internal class NameValueHeadersCollection : IHeadersCollection
++    internal readonly struct NameValueHeadersCollection : IHeadersCollection
+     {
+         private readonly NameValueCollection _headers;
+ ",Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?
+2288,"@@ -19,9 +19,12 @@ package org.hyperledger.besu.ethereum.api.query;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.Log;
+ import org.hyperledger.besu.ethereum.core.LogTopic;
++import org.hyperledger.besu.ethereum.core.LogsBloomFilter;
+
+ import java.util.Arrays;
+ import java.util.List;
++import java.util.Objects;
++import java.util.stream.Collectors;
+
+ import com.google.common.collect.Lists;
+ ",These are just aliases now
+2289,"@@ -1,4 +1,4 @@
+-<% content_for :page_title, @video.title %>
++<% content_for :page_title, @video.title.html_safe %>
+
+ <% content_for :landing_page_back_link do %>
+   <%= link_to '&larr; All Videos'.html_safe, '/the-weekly-iteration' %>",Does this mean we can remove `raw` from `_head_contents` partial?
+2290,"@@ -113,7 +113,9 @@ class CapacitorSplashScreen {
+     `;
+
+     this.mainWindowRef.on('closed', () => {
+-      this.splashWindow.close();
++      if (this.splashWindow && !this.splashWindow.isDestroyed) {
++        this.splashWindow.close();
++      }
+     });
+
+     this.splashWindow.loadURL(`data:text/html;charset=UTF-8,${splashHtml}`, {baseURLForDataURL: `file://${rootPath}/splash_assets/`});","`isDestroyed` is a function, not a property. This condition will always return false."
+2291,"@@ -30,6 +30,8 @@ const (
+ 	Version_1_28 DockerVersion = ""1.28""
+ 	Version_1_29 DockerVersion = ""1.29""
+ 	Version_1_30 DockerVersion = ""1.30""
++	Version_1_31 DockerVersion = ""1.31""
++	Version_1_32 DockerVersion = ""1.32""
+ )
+
+ // getKnownAPIVersions returns all of the API versions that we know about.",Why are we adding these versions?
+2292,"@@ -271,6 +271,8 @@ def process_one_user(user):
+     spotify.update_latest_listened_at(user.user_id, latest_listened_at)
+     spotify.update_last_updated(user.user_id)
+
++    current_app.logger.info('imported %d listens for %s' % (len(listens), str(user)))
++
+
+ def process_all_spotify_users():
+     """""" Get a batch of users to be processed and import their Spotify plays.","fyi, you can do this by doing `.info(""string %s %s"", formatparam, formatparam2)` instead of doing a string format with `""str"" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important"
+2293,"@@ -0,0 +1,17 @@
++<%= render ""offerings/meta"", offering: @offering %>
++
++<p>
++  We're adding you to the GitHub repository, and we'll redirect you as soon it's
++  ready. You may receive an email from GitHub asking you to confirm your
++  membership, so make sure to take quick look in your inbox.
++</p>
++
++<% content_for :javascript do %>
++  <script type=""text/javascript"">
++    (function () {
++      setTimeout(function reload() {
++        window.location.reload();
++      }, 5000);
++    })();
++  </script>
++<% end -%>","Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`"
+2294,"@@ -33,16 +33,16 @@ import (
+ 	""sync""
+ 	""time""
+
++	""crypto/tls""
+ 	""github.com/aws/amazon-ecs-agent/agent/config""
++	""github.com/aws/amazon-ecs-agent/agent/utils""
++	""github.com/aws/amazon-ecs-agent/agent/utils/cipher""
+ 	""github.com/aws/amazon-ecs-agent/agent/wsclient/wsconn""
+ 	""github.com/aws/aws-sdk-go/aws/credentials""
+ 	""github.com/aws/aws-sdk-go/private/protocol/json/jsonutil""
+ 	""github.com/cihub/seelog""
+ 	""github.com/gorilla/websocket""
+ 	""github.com/pkg/errors""
+-	""github.com/aws/amazon-ecs-agent/agent/utils/cipher""
+-	""crypto/tls""
+-	""github.com/aws/amazon-ecs-agent/agent/utils""
+ )
+
+ const (",Can you move `crypto/tls` into the block at the top with all the other stdlib imports?
+2295,"@@ -403,7 +403,7 @@ for steps in config['predictionSteps']:
+                  params={'errorMetric': 'aae', 'window': 1000, 'steps': steps}))
+   control['metrics'].append(
+       MetricSpec(field=config['predictedField'], metric='multiStep',
+-                 inferenceElement='multiStepBestPredictions',
++                 inferenceElement='anomalyScore',
+                  params={'errorMetric': 'altMAPE', 'window': 1000, 'steps': steps}))
+   control['metrics'].append(
+       MetricSpec(field=config['predictedField'], metric='trivial',",What is the motivation for this change?
+2296,"@@ -74,9 +74,15 @@ type Topic interface {
+ // Subscription receives published messages.
+ type Subscription interface {
+ 	// ReceiveBatch should return a batch of messages that have queued up
+-	// for the subscription on the server. If no messages are available
+-	// yet, it must block until there is at least one, or the context is
+-	// done.
++	// for the subscription on the server.
++	//
++	// If there is a transient failure, this method should not retry but
++	// should return a nil slice and an error. The concrete API will take
++	// care of retry logic.
++	//
++	// If the service returns no messages for some other reason, this
++	// method should return the empty slice of messages and not attempt to
++	// retry.
+ 	//
+ 	// ReceiveBatch is only called sequentially for individual
+ 	// Subscriptions.","OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting."
+2297,"@@ -45,7 +45,10 @@ Status MatchValidator::validateImpl() {
+
+         auto matchClauseCtx = getContext<MatchClauseContext>();
+         matchClauseCtx->aliasesUsed = aliasesUsed;
+-        NG_RETURN_IF_ERROR(validatePath(matchClause->path(), *matchClauseCtx));
++        if (matchClause->path()->pathSize() > 1) {
++          return Status::SemanticError(""Multi paths not supported."");
++        }
++        NG_RETURN_IF_ERROR(validatePath(matchClause->path()->path(0) /* TODO */, *matchClauseCtx));
+         if (matchClause->where() != nullptr) {
+           auto whereClauseCtx = getContext<WhereClauseContext>();
+           whereClauseCtx->aliasesUsed = &matchClauseCtx->aliasesGenerated;",The data structure of `MatchClauseContext` may need to be redesigned.
+2298,"@@ -236,8 +236,13 @@ func testSendReceive(t *testing.T, newHarness HarnessMaker) {
+ 	}
+ 	defer cleanup()
+
+-	want := publishN(ctx, t, top, 3)
+-	got := receiveN(ctx, t, sub, len(want))
++	wantChan := make(chan []*pubsub.Message)
++	gotChan := make(chan []*pubsub.Message)
++	n := 3
++	go func() { gotChan <- receiveN(ctx, t, sub, n) }()
++	go func() { wantChan <- publishN(ctx, t, top, n) }()
++	want := <-wantChan
++	got := <-gotChan
+
+ 	// Check that the received messages match the sent ones.
+ 	if diff := diffMessageSets(got, want); diff != """" {","You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called."
+2299,"@@ -50,7 +50,7 @@ class ProposalsController < ApplicationController
+   end
+
+   def approve
+-    approval = proposal.existing_approval_for(current_user)
++    approval = proposal.existing_step_for(current_user)
+     approval.update_attributes!(completer: current_user)
+     approval.approve!
+     flash[:success] = ""You have approved #{proposal.public_id}.""",how do we know that the step in question is an approval type step?
+2300,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+
+ import com.google.common.base.Predicate;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.
+2301,"@@ -0,0 +1,7 @@
++module io.vavr {
++  requires io.vavr.match;
++  exports io.vavr;
++  exports io.vavr.collection;
++  exports io.vavr.control;
++  exports io.vavr.concurrent;
++}","Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?"
+2302,"@@ -293,7 +293,12 @@ hipError_t hipCreateTextureObject(hipTextureObject_t* pTexObject, const hipResou
+         hsa_ext_sampler_descriptor_t samplerDescriptor;
+         fillSamplerDescriptor(samplerDescriptor, pTexDesc->addressMode[0], pTexDesc->filterMode,
+                               pTexDesc->normalizedCoords);
+-
++        if(hipResourceTypeLinear == pResDesc->resType) {
++           samplerDescriptor.filter_mode = HSA_EXT_SAMPLER_FILTER_MODE_NEAREST;
++           samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_BORDER;
++        } else if(!pTexDesc->normalizedCoords) {
++            samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_EDGE;
++        }
+         hsa_access_permission_t permission = HSA_ACCESS_PERMISSION_RW;
+         if (HSA_STATUS_SUCCESS != hsa_ext_image_create_with_layout(
+                                       *agent, &imageDescriptor, devPtr, permission,",Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?
+2303,"@@ -0,0 +1,19 @@
++# frozen_string_literal: true
++
++module Faker
++  class Show < Base
++    class << self
++      def adult_musical
++        fetch('show.adult_musical')
++      end
++
++      def kids_musical
++        fetch('show.kids_musical')
++      end
++
++      def play
++        fetch('show.play')
++      end
++    end
++  end
++end",This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`.
+2304,"@@ -58,6 +58,14 @@ Puppet::Functions.create_function(:run_task) do
+     end || (raise Puppet::ParseError, 'Task parameters did not match')
+     task = task_signature.task
+
++    if executor.noop
++      if task.supports_noop
++        use_args['_noop'] = true
++      else
++        raise Puppet::ParseError, 'Task does not support noop'
++      end
++    end
++
+     # Ensure that that given targets are all Target instances
+     targets = [targets] unless targets.is_a?(Array)
+     targets = targets.flatten.map { |t| t.is_a?(String) ? Puppet::Pops::Types::TypeFactory.target.create(t) : t }",I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though.
+2305,"@@ -11,6 +11,7 @@ import (
+
+ 	""github.com/CoderZhi/go-ethereum/common""
+ 	""github.com/CoderZhi/go-ethereum/core/types""
++
+ 	""github.com/iotexproject/iotex-core/address""
+ 	""github.com/iotexproject/iotex-core/logger""
+ 	""github.com/iotexproject/iotex-core/pkg/hash""",File is not `goimports`-ed
+2306,"@@ -35,12 +35,15 @@ class CollectionViewTest(BaseWebTest, unittest.TestCase):
+                           headers=self.headers,
+                           status=400)
+
+-    def test_unknown_bucket_raises_404(self):
++    def test_unknown_bucket_raises_403(self):
+         other_bucket = self.collections_url.replace('beers', 'sodas')
+-        self.app.get(other_bucket, headers=self.headers, status=404)
++        self.app.get(other_bucket, headers=self.headers, status=403)
+
+     def test_collections_are_isolated_by_bucket(self):
+-        other_bucket = self.collection_url.replace('beers', 'water')
++        other_bucket = self.collection_url.replace('beers', 'sodas')
++        self.app.put_json('/buckets/sodas',
++                          MINIMALIST_BUCKET,
++                          headers=self.headers)
+         self.app.get(other_bucket, headers=self.headers, status=404)
+
+ ",why should unknown raise a 403?
+2307,"@@ -87,11 +87,11 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			c._vnode = newVNode;
+
+ 			// Invoke getDerivedStateFromProps
+-			let s = c._nextState || c.state;
++			if (c._nextState==null) {
++				c._nextState = c.state;
++			}
+ 			if (newType.getDerivedStateFromProps!=null) {
+-				oldState = assign({}, c.state);
+-				if (s===c.state) s = c._nextState = assign({}, s);
+-				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
++				assign(c._nextState==c.state ? (c._nextState = assign({}, c._nextState)) : c._nextState, newType.getDerivedStateFromProps(newVNode.props, c._nextState));
+ 			}
+
+ 			// Invoke pre-render lifecycle methods","The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?"
+2308,"@@ -36,6 +36,8 @@ flags.DEFINE_string('groups_service_account_key_file', None,
+                     'runnning locally.')
+ flags.DEFINE_integer('max_admin_api_calls_per_day', 150000,
+                      'Admin SDK queries per day.')
++flags.DEFINE_integer('max_results_admin_api', 500,
+++                     'maxResult param for the Admin SDK list() method')
+
+
+ class AdminDirectoryClient(_base_client.BaseClient):",nit: align the leftmost quotes
+2309,"@@ -98,6 +98,11 @@ type AgentConfig struct {
+ 	// APIPort is the port for the antrea-agent APIServer to serve on.
+ 	// Defaults to 10350.
+ 	APIPort int `yaml:""apiPort,omitempty""`
++
++	// ClusterMembershipPort is the server port used by the antrea-agent to run a gossip-based cluster membership protocol. Currently it's used only when the Egress feature is enabled.
++	// Defaults to 10351.
++	ClusterMembershipPort int `yaml:""clusterPort,omitempty""`
++
+ 	// Enable metrics exposure via Prometheus. Initializes Prometheus metrics listener
+ 	// Defaults to true.
+ 	EnablePrometheusMetrics bool `yaml:""enablePrometheusMetrics,omitempty""`","Probably ""server port"" -> ""TCP port"""
+2310,"@@ -91,7 +91,11 @@ public class Lucene80Codec extends Codec {
+    *             flushed/merged segments.
+    */
+   public Lucene80Codec(Mode mode) {
+-    super(""Lucene80"");
++    this(""Lucene80"", mode);
++  }
++
++  protected Lucene80Codec(String name, Mode mode) {
++    super(name);
+     this.storedFieldsFormat = new Lucene50StoredFieldsFormat(Objects.requireNonNull(mode));
+     this.defaultFormat = new Lucene50PostingsFormat();
+   }",can you use FilterCodec instead?
+2311,"@@ -407,6 +407,19 @@ class Setting extends BaseModel {
+ 			tagHeaderIsExpanded: { value: true, type: Setting.TYPE_BOOL, public: false, appTypes: ['desktop'] },
+ 			folderHeaderIsExpanded: { value: true, type: Setting.TYPE_BOOL, public: false, appTypes: ['desktop'] },
+ 			editor: { value: '', type: Setting.TYPE_STRING, subType: 'file_path_and_args', public: true, appTypes: ['cli', 'desktop'], label: () => _('Text editor command'), description: () => _('The editor command (may include arguments) that will be used to open a note. If none is provided it will try to auto-detect the default editor.') },
++			'export.pdfPageSize': { value: 'A4', type: Setting.TYPE_STRING, isEnum: true, public: true, appTypes: ['desktop'], label: () => _('Page size for PDF export'), options: () => {
++				return {
++					'A4': _('A4'),
++					'Letter': _('Letter'),
++				};
++			}},
++			'export.pdfPageOrientation': { value: false, type: Setting.TYPE_BOOL, isEnum: true, public: true, appTypes: ['desktop'], label: () => _('Page orientation for PDF export'), options: () => {
++				return {
++					false: _('Portrait'),
++					true: _('Landscape'),
++				};
++			}},
++
+
+ 			'net.customCertificates': {
+ 				value: '',","I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values ""portrait"" and ""landscape""? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`"
+2312,"@@ -12,3 +12,11 @@ var dbSchemaVersion = Migration{
+ 		return CommitProgress(db, nil, true)
+ 	},
+ }
++
++var dbSchemaVersion2 = Migration{
++	Name: ""db_schema_version2"",
++	Up: func(db ethdb.Database, tmpdir string, progress []byte, CommitProgress etl.LoadCommitHandler) (err error) {
++		// This migration is no-op, but it forces the migration mechanism to apply it and thus write the DB schema version info
++		return CommitProgress(db, nil, true)
++	},
++}",I think this migration should fail for MDBX if it uses old table names
+2313,"@@ -224,7 +224,7 @@ module Beaker
+       # @raise [ArgumentError] if a hosts file is generated, but it can't
+       #   be read by the HostsFileParser
+       def parse_hosts_options
+-        if File.exists?(@options[:hosts_file])
++        if @options[:hosts_file].nil? || File.exists?(@options[:hosts_file])
+           #read the hosts file that contains the node configuration and hypervisor info
+           return Beaker::Options::HostsFileParser.parse_hosts_file(@options[:hosts_file])
+         end","Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad."
+2314,"@@ -91,6 +91,14 @@ namespace NLog
+         /// Loads NLog config created by the method <paramref name=""configBuilder""/>
+         /// </summary>
+         public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, Action<ISetupLoadConfigurationBuilder> configBuilder)
++        {
++            return LoadConfiguration(setupBuilder, true, configBuilder);
++        }
++
++        /// <summary>
++        /// Loads NLog config created by the method <paramref name=""configBuilder""/>
++        /// </summary>
++        public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, bool applyOnReload, Action<ISetupLoadConfigurationBuilder> configBuilder)
+         {
+             var config = setupBuilder.LogFactory._config;
+             var setupConfig = new SetupLoadConfigurationBuilder(setupBuilder.LogFactory, config);",I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?
+2315,"@@ -410,7 +410,7 @@ public class MultiPhraseQuery extends Query {
+    * <p>
+    * Note: positions are merged during freq()
+    */
+-  static class UnionPostingsEnum extends PostingsEnum {
++  public static class UnionPostingsEnum extends PostingsEnum {
+     /** queue ordered by docid */
+     final DocsQueue docsQueue;
+     /** cost of this enum: sum of its subs */",This is used in o.a.l.sandbox.search.PhraseWildcardQuery.
+2316,"@@ -42,6 +42,7 @@ type stateDB struct {
+ 	dao                db.KVStore // the underlying DB for account/contract storage
+ 	timerFactory       *prometheustimer.TimerFactory
+ 	workingsets        *lru.Cache // lru cache for workingsets
++	protocolView       protocol.Dock
+ }
+
+ // StateDBOption sets stateDB construction parameter",view should be loaded on start for both statedb and factory
+2317,"@@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Http
+         private ConnectionFilterContext _filterContext;
+         private LibuvStream _libuvStream;
+         private FilteredStreamAdapter _filteredStreamAdapter;
+-        private Task _readInputContinuation;
++        private Task _readInputTask;
+
+         private readonly SocketInput _rawSocketInput;
+         private readonly SocketOutput _rawSocketOutput;",Why rename? Just curious...
+2318,"@@ -309,12 +309,14 @@ public class VideoplayerActivity extends MediaplayerActivity {
+     public void onStartTrackingTouch(SeekBar seekBar) {
+         super.onStartTrackingTouch(seekBar);
+         videoControlsHider.stop();
++        controls.setVisibility(View.GONE);
+     }
+
+     @Override
+     public void onStopTrackingTouch(SeekBar seekBar) {
+         super.onStopTrackingTouch(seekBar);
+         setupVideoControlsToggler();
++        controls.setVisibility(View.VISIBLE);
+     }
+
+     @Override",Is this needed? I think it calls the super function that already does that.
+2319,"@@ -538,7 +538,9 @@ class BBoxHead(BaseModule):
+         labels = labels.view(1, 1, -1).expand_as(scores)
+         labels = labels.reshape(batch_size, -1)
+         scores = scores.reshape(batch_size, -1)
+-        bboxes = bboxes.reshape(batch_size, -1, 4)
++        if self.reg_class_agnostic:
++            bboxes = bboxes.reshape(batch_size, -1, 4)
++            bboxes = bboxes.repeat(1, self.num_classes, 1)
+
+         max_size = torch.max(img_shape)
+         # Offset bboxes of each class so that bboxes of different labels","This might slow down the inference time, are we sure we need to do that?"
+2320,"@@ -23,11 +23,9 @@ import (
+ )
+
+ func Example() {
+-	// This example is used in https://gocloud.dev/howto/sql/#aws
+-
+-	// import _ ""gocloud.dev/mysql/awsmysql""
+-
+-	// Variables set up elsewhere:
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/mysql/awsmysql""
++	// PRAGMA(gocloud.dev): Skip until next blank line.
+ 	ctx := context.Background()
+
+ 	// Replace these with your actual settings.","This would read better if you add ""Skip code/lines"" or (exclude/hide code if you follow my earlier suggestion"")"
+2321,"@@ -34,6 +34,13 @@ import java.util.HashSet;
+ import java.util.Map;
+ import javax.imageio.ImageIO;
+ import org.apache.commons.io.IOUtils;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
+
+ public class DatasetUtil {
+ ",Looks like glassfish went a bit nuts doing a refactor
+2322,"@@ -84,6 +84,17 @@ namespace OpenTelemetry.Trace.Export.Internal
+             return Task.WhenAll(tasks);
+         }
+
++        public override Task ForceFlushAsync(CancellationToken cancellationToken)
++        {
++            var tasks = new List<Task>();
++            foreach (var processor in this.processors)
++            {
++                tasks.Add(processor.ForceFlushAsync(cancellationToken));
++            }
++
++            return Task.WhenAll(tasks);
++        }
++
+         public void Dispose()
+         {
+             foreach (var processor in this.processors)",nit: allocate the list using the number of processors.
+2323,"@@ -142,10 +142,10 @@ public class PartitionSpec implements Serializable {
+
+   public String partitionToPath(StructLike data) {
+     StringBuilder sb = new StringBuilder();
+-    Class<?>[] javaClasses = javaClasses();
+-    for (int i = 0; i < javaClasses.length; i += 1) {
++    Class<?>[] initializedClasses = javaClasses();
++    for (int i = 0; i < initializedClasses.length; i += 1) {
+       PartitionField field = fields[i];
+-      String valueString = field.transform().toHumanString(get(data, i, javaClasses[i]));
++      String valueString = field.transform().toHumanString(get(data, i, initializedClasses[i]));
+
+       if (i > 0) {
+         sb.append(""/"");",Was this change triggered by baseline?
+2324,"@@ -36,17 +36,13 @@ class OrgThirtyDayActivity < ActiveRecord::Base
+     private
+
+     def with_commits_and_affiliates
+-      orgs = Organization.arel_table
+       joins(:organization)
+-        .where(id: orgs[:thirty_day_activity_id])
+         .where(arel_table[:thirty_day_commit_count].gt(0)
+         .and(arel_table[:affiliate_count].gt(0)))
+     end
+
+     def with_thirty_day_commit_count
+-      orgs = Organization.arel_table
+       joins(:organization)
+-        .where(id: orgs[:thirty_day_activity_id])
+         .where.not(thirty_day_commit_count: nil)
+         .order(thirty_day_commit_count: :desc)
+         .limit(5)",This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there.
+2325,"@@ -39,6 +39,7 @@ public class RestExplorerApp extends Application {
+ 	public void onCreate() {
+ 		super.onCreate();
+ 		SalesforceSDKManager.initNative(getApplicationContext(), new KeyImpl(), ExplorerActivity.class);
++		SalesforceSDKManager.getInstance().setBrowserLoginEnabled(true);
+
+ 		/*
+ 		 * Un-comment the line below to enable push notifications in this app.",Setting browser based login as the default for `RestAPIExplorer`.
+2326,"@@ -231,6 +231,11 @@ void DataParallelTreeLearner<TREELEARNER_T>::FindBestSplitsFromHistograms(const
+   }
+
+   // sync global best info
++  auto max_cat_threshold = this->config_->max_cat_threshold;
++  int splitInfoSize = SplitInfo::Size(max_cat_threshold);
++  if (input_buffer_.size() < splitInfoSize * 2) {
++    input_buffer_.resize(splitInfoSize * 2);
++  }
+   SyncUpGlobalBestSplit(input_buffer_.data(), input_buffer_.data(), &smaller_best_split, &larger_best_split, this->config_->max_cat_threshold);
+
+   // set best split",maybe we can do this in Init function?
+2327,"@@ -2086,10 +2086,15 @@ func (wh *WorkflowHandler) ResetWorkflowExecution(ctx context.Context, request *
+ 	if request == nil {
+ 		return nil, errRequestNotSet
+ 	}
+-
+ 	if request.GetNamespace() == """" {
+ 		return nil, errNamespaceNotSet
+ 	}
++	if request.GetRequestId() == """" {
++		return nil, errRequestIDNotSet
++	}
++	if len(request.GetRequestId()) > wh.config.MaxIDLengthLimit() {
++		return nil, errRequestIDTooLong
++	}
+
+ 	if err := wh.validateExecution(request.WorkflowExecution); err != nil {
+ 		return nil, err","How about if request ID not set, service should generate a random uuid?"
+2328,"@@ -105,7 +105,7 @@ func TestPerformUpdateWithUpdatesDisabled(t *testing.T) {
+ 		Reason:            ptr(""Updates are disabled"").(*string),
+ 	}})
+
+-	u.performUpdateHandler(statemanager.NewNoopStateManager(), engine.NewTaskEngine(cfg, nil, nil, nil, nil, nil, nil))(&ecsacs.PerformUpdateMessage{
++	u.performUpdateHandler(statemanager.NewNoopStateManager(), engine.NewTaskEngine(cfg, nil, nil, nil, nil, nil, nil, nil))(&ecsacs.PerformUpdateMessage{
+ 		ClusterArn:           ptr(""cluster"").(*string),
+ 		ContainerInstanceArn: ptr(""containerInstance"").(*string),
+ 		MessageId:            ptr(""mid"").(*string),",minor: this is an opportunity for you to split these long lines into multiple lines :)
+2329,"@@ -259,7 +259,10 @@ class RequestsParser(object):
+             req = ensure_is_dict(raw_requests, key, ""url"")
+             if not require_url and ""url"" not in req:
+                 req[""url""] = None
+-            requests.append(self.__parse_request(req))
++            try:
++                requests.append(self.__parse_request(req))
++            except:
++                raise TaurusConfigError(""Wrong request:\n %s"" % req)
+         return requests
+
+     def extract_requests(self, require_url=True):","It would be nice to have exception dumped somewhere (debug logs, info logs)."
+2330,"@@ -84,6 +84,13 @@ type Topic interface {
+ 	// https://github.com/google/go-cloud/blob/master/internal/docs/design.md#as
+ 	// for more background.
+ 	As(i interface{}) bool
++
++	// As allows providers to expose provider-specific types.
++	//
++	// See
++	// https://github.com/google/go-cloud/blob/master/internal/docs/design.md#as
++	// for more background.
++	MessageAs(m *Message, i interface{}) bool
+ }
+
+ // Subscription receives published messages.","So I don't think this is right, as discussed on #657."
+2331,"@@ -65,10 +65,16 @@ GROUP_IDS = """"""
+     SELECT group_id from groups_{0};
+ """"""
+
+-GROUP_USERS = """"""
++GROUP_ID = """"""
++    SELECT group_id
++    FROM groups_{1}
++    WHERE group_email = ""{0}"";
++""""""
++
++GROUP_MEMBERS = """"""
+     SELECT group_id, member_role, member_type, member_id, member_email
+-    FROM group_members_{0}
+-    WHERE member_status = ""ACTIVE"" and member_type = ""USER"";
++    FROM group_members_{1}
++    WHERE group_id = ""{0}"";
+ """"""
+
+ BUCKETS = """"""","should the group_id = ""{0}"" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized."
+2332,"@@ -89,7 +89,12 @@ class HierarchicHTTPRequest(HTTPRequest):
+                 raise TaurusConfigError(""Items from upload-files must specify parameter name"")
+
+             path_exc = TaurusConfigError(""Items from upload-files must specify path to file"")
+-            file_dict[""path""] = get_full_path(self.engine.find_file(file_dict.get(""path"", path_exc)))
++            path = str(file_dict.get(""path"", path_exc))
++            if not path.startswith('$'):    # exclude varables
++                path = get_full_path(self.engine.find_file(path))   # prepare full path for jmx
++
++            file_dict[""path""] = path
++
+             mime = mimetypes.guess_type(file_dict[""path""])[0] or ""application/octet-stream""
+             file_dict.get('mime-type', mime)
+         self.content_encoding = self.config.get('content-encoding', None)","Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code."
+2333,"@@ -20,6 +20,11 @@ class FormTestModel extends Model
+     {
+         return ['dropdown', 'options'];
+     }
++
++    public function staticMethodOptions()
++    {
++        return ['static', 'method'];
++    }
+ }
+
+ class FormHelper",@bennothommo can you revert this section? It shouldn't be required.
+2334,"@@ -92,9 +92,13 @@ module Ncr
+       ""ncr""
+     end
+
+-    # @todo - this is pretty ugly
+     def public_identifier
+-      self.cart.id
++      fiscal_year = self.created_at.year
++      if self.created_at.month >= 10
++        fiscal_year += 1
++      end
++      fiscal_year = fiscal_year % 100   # convert to two-digit
++      ""FY"" + fiscal_year.to_s.rjust(2, ""0"") + "" ##{self.id}""
+     end
+
+     def total_price",Minor: maybe move the above to a `#fiscal_year` method?
+2335,"@@ -62,3 +62,13 @@ class BuildTest(QuiltTestCase):
+             'Expected dataframes to have same # columns'
+         del os.environ[""QUILT_PACKAGE_FORMAT""]
+         # TODO add more integrity checks, incl. negative test cases
++
++    def test_generate_buildfile(self):
++        mydir = os.path.dirname(__file__)
++        path = os.path.join(mydir, 'data')
++        buildfilepath = os.path.join(path, 'build.yml')
++        assert not os.path.exists(buildfilepath)
++        build.generate_build_file(path)
++        assert os.path.exists(buildfilepath)
++        build.build_package('test_hdf5', 'generated', buildfilepath)
++        os.remove(buildfilepath)",You should use the current directory instead - it's a temporary directory that will get removed when the test is done.
+2336,"@@ -549,7 +549,7 @@ public class ContainerizedDispatchManagerTest {
+         this.containerizedDispatchManager.getExecutionDispatcher(this.flow1.getExecutionId()));
+     thread.start();
+     synchronized (thread) {
+-      thread.wait();
++      thread.join();
+     }
+     assertThat(flow1.getStatus()).isEqualTo(Status.FAILED);
+     verify(onExecutionEventListener).onExecutionEvent(this.flow1, Constants.RESTART_FLOW);",I think we don't need synchronization here.
+2337,"@@ -92,7 +92,7 @@ public final class OAuth2AuthorizedClientArgumentResolver implements HandlerMeth
+ 							clientRegistrationId.flatMap(id -> Mono.error(new IllegalStateException(
+ 									""Unable to resolve the Authorized Client with registration identifier \""""
+ 											+ id
+-											+ ""\"". An \""authenticated\"" or \""unauthenticated\"" session is required. To allow for unauthenticated access, ensure ServerHttpSecurity.anonymous() is configured.""))))
++											+ ""\"". An \""authenticated\"" or \""anonymous\"" request is required. To allow for anonymous access, ensure ServerHttpSecurity.anonymous() is configured.""))))
+ 					.flatMap(zipped -> {
+ 						String registrationId = zipped.getT1();
+ 						String username = zipped.getT2();",I don't think this should be changed since on the reactive side we don't support anonymous users.
+2338,"@@ -116,7 +116,7 @@ module Mongoid
+
+           before_destroy do
+             if record = __send__(name)
+-              record[cache_column] = (record[cache_column] || 0) - 1
++              record[cache_column] = (record[cache_column] || 0) - 1 unless record.frozen?
+
+               if record.persisted?
+                 record.class.decrement_counter(cache_column, record._id)",Maybe this `if` should be on line 118?
+2339,"@@ -45,8 +45,8 @@ type (
+ 	// the less than equal bucket count for the pre-determined boundaries.
+ 	state struct {
+ 		bucketCounts []float64
+-		count        metric.Number
+ 		sum          metric.Number
++		count        int64
+ 	}
+ )
+ ",Cool. (I thought I had fixed this already in #812.)
+2340,"@@ -36,7 +36,7 @@ module Bolt
+
+     TRANSPORT_OPTIONS = %i[password run-as sudo-password extensions
+                            private-key tty tmpdir user connect-timeout
+-                           cacert token-file service-url].freeze
++                           cacert token-file service-url interpreters].freeze
+
+     # TODO: move these to the transport themselves
+     TRANSPORT_SPECIFIC_DEFAULTS = {",I intend to do this as soon as I have tests passing.
+2341,"@@ -0,0 +1,7 @@
++#!/usr/bin/python3
++
++import sys
++import os
++sys.stdin.read()
++with open(os.environ['QUTE_FIFO'], 'wb') as fifo:
++    fifo.write(b':message-info ""stdin closed""\n')",Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it.
+2342,"@@ -263,6 +263,11 @@ size_t wlr_session_find_gpus(struct wlr_session *session,
+ 		return explicit_find_gpus(session, ret_len, ret, explicit);
+ 	}
+
++#ifdef __FreeBSD__
++	// XXX: libudev-devd does not return any GPUs (yet?)
++	return explicit_find_gpus(session, ret_len, ret, ""/dev/drm/0"");
++#else
++
+ 	struct udev_enumerate *en = udev_enumerate_new(session->udev);
+ 	if (!en) {
+ 		wlr_log(L_ERROR, ""Failed to create udev enumeration"");",Did you file a bug to follow up on this?
+2343,"@@ -156,10 +156,13 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+     this.io = io;
+     this.encryptionManager = encryptionManager;
+     this.caseSensitive = caseSensitive;
+-
+-    this.batchReadsEnabled = options.get(""vectorization-enabled"").map(Boolean::parseBoolean).orElseGet(() ->
+-        PropertyUtil.propertyAsBoolean(table.properties(),
+-            TableProperties.PARQUET_VECTORIZATION_ENABLED, TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
++    boolean batchReadsSparkSessionConf = SparkSession.active().sparkContext().getConf()
++            .getBoolean(""read.parquet.vectorization.enabled"", true);
++    boolean batchReadsEnabledTableProp = options.get(""vectorization-enabled"").map(Boolean::parseBoolean).orElseGet(() ->
++            PropertyUtil.propertyAsBoolean(table.properties(),
++                    TableProperties.PARQUET_VECTORIZATION_ENABLED,
++                    TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
++    this.batchReadsEnabled = !batchReadsSparkSessionConf ? false : batchReadsEnabledTableProp;
+     this.batchSize = options.get(""batch-size"").map(Integer::parseInt).orElseGet(() ->
+         PropertyUtil.propertyAsInt(table.properties(),
+           TableProperties.PARQUET_BATCH_SIZE, TableProperties.PARQUET_BATCH_SIZE_DEFAULT));",Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?
+2344,"@@ -1,4 +1,6 @@
+ RSpec::Support.require_rspec_core ""formatters/base_formatter""
++require 'pathname'
++
+
+ module RSpec
+   module Core","This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines."
+2345,"@@ -1426,6 +1426,13 @@ public class DatasetsIT {
+
+         // This should fail, because we are attempting to link the dataset
+         // to its own dataverse:
++        Response publishTargetDataverse = UtilIT.publishDataverseViaNativeApi(dataverseAlias,  apiToken);
++        publishTargetDataverse.prettyPrint();
++                        publishTargetDataverse.then().assertThat()
++                        .statusCode(OK.getStatusCode());
++
++        Response publishDatasetForLinking = UtilIT.publishDatasetViaNativeApi(datasetId, ""major"", apiToken);
++
+         Response createLinkingDatasetResponse = UtilIT.createDatasetLink(datasetId.longValue(), dataverseAlias, apiToken);
+         createLinkingDatasetResponse.prettyPrint();
+         createLinkingDatasetResponse.then().assertThat()",It would be nice to fix the indentation above.
+2346,"@@ -9334,8 +9334,8 @@ return [
+ 'openssl_x509_export_to_file' => ['bool', 'certificate'=>'string|resource', 'output_filename'=>'string', 'no_text='=>'bool'],
+ 'openssl_x509_fingerprint' => ['string|false', 'certificate'=>'string|resource', 'digest_algo='=>'string', 'binary='=>'bool'],
+ 'openssl_x509_free' => ['void', 'certificate'=>'resource'],
+-'openssl_x509_parse' => ['array|false', 'certificate'=>'string|resource', 'short_names='=>'bool'],
+-'openssl_x509_read' => ['resource|false', 'certificate'=>'string|resource'],
++'openssl_x509_parse' => ['array|false', 'certificate'=>'OpenSSLCertificate|string', 'short_names'=>'bool|null'],
++'openssl_x509_read' => ['OpenSSLCertificate|false', 'certificate'=>'OpenSSLCertificate|string'],
+ 'ord' => ['int', 'character'=>'string'],
+ 'OuterIterator::current' => ['mixed'],
+ 'OuterIterator::getInnerIterator' => ['Iterator'],","`short_names` is still optional, so `=` that indicates it has to stay there."
+2347,"@@ -153,6 +153,10 @@ func (agent *ecsAgent) appendFirelensFluentbitCapabilities(capabilities []*ecs.A
+ 	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentbit)
+ }
+
++func (agent *ecsAgent) appendEFSCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityEFS)
++}
++
+ func (agent *ecsAgent) appendFirelensLoggingDriverCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+ 	return appendNameOnlyAttribute(capabilities, capabilityPrefix+capabilityFirelensLoggingDriver)
+ }",missing calling of this method
+2348,"@@ -9,10 +9,12 @@ import (
+ 	""fmt""
+ 	""text/template""
+
++	""github.com/aws/aws-sdk-go/aws""
++	""github.com/aws/aws-sdk-go/service/cloudformation""
+ 	""github.com/fatih/structs""
+ 	""gopkg.in/yaml.v3""
+
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	archerCfn ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy/cloudformation""
+ 	""github.com/aws/amazon-ecs-cli-v2/templates""
+ )
+ ","We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point."
+2349,"@@ -25,6 +25,8 @@ import (
+ // Stress chaos is a chaos to generate plenty of stresses over a collection of pods.
+
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ // +chaos-mesh:experiment
+
+ // StressChaos is the Schema for the stresschaos API",`StressChaos` does not contains a field .spec.action
+2350,"@@ -1931,7 +1931,12 @@ class FunctionCallTest extends TestCase
+                       return $b[""a""];
+                     }
+
+-                    a([""a"" => ""hello""]);',
++                    function b(string $str): string
++                    {
++                        return $str;
++                    }
++
++                    a([""a"" => b(""hello"")]);',
+                 'error_message' => 'InvalidScalarArgument',
+             ],
+             'objectLikeKeyChecksAgainstDifferentTKeyedArray' => [","Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`."
+2351,"@@ -27,6 +27,8 @@
+ #include ""cast_utils.h""
+ #include ""layer_validation_tests.h""
+
++#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
++
+ class MessageIdFilter {
+   public:
+     MessageIdFilter(const char *filter_string) {",I this used anyplace?
+2352,"@@ -102,7 +102,7 @@ public class TestHiveMetastore {
+         .transportFactory(new TTransportFactory())
+         .protocolFactory(new TBinaryProtocol.Factory())
+         .minWorkerThreads(3)
+-        .maxWorkerThreads(5);
++        .maxWorkerThreads(8);
+
+     return new TThreadPoolServer(args);
+   }",Why was this change required?
+2353,"@@ -39,6 +39,7 @@ public class AuthorizationException extends ProcessEngineException {
+
+   protected final String userId;
+   protected final List<MissingAuthorization> missingAuthorizations;
++  protected final boolean missingAdminRole;
+
+   // these properties have been replaced by the list of missingAuthorizations
+   // and are only left because this is a public API package and users might","I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think.  "
+2354,"@@ -14,6 +14,9 @@ import com.google.flatbuffers.*;
+ public final class Monster extends Table {
+   public static Monster getRootAsMonster(ByteBuffer _bb) { return getRootAsMonster(_bb, new Monster()); }
+   public static Monster getRootAsMonster(ByteBuffer _bb, Monster obj) { _bb.order(ByteOrder.LITTLE_ENDIAN); return (obj.__assign(_bb.getInt(_bb.position()) + _bb.position(), _bb)); }
++  public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb) { return getSizePrefixedRootAsMonster(_psbb, new Monster()); }
++  public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb, Monster obj) { ByteBuffer _bb = _psbb.slice(); _bb.position(4); return getRootAsMonster(_bb, obj); }
++  public static int getSizePrefix(ByteBuffer _bb) { _bb.order(ByteOrder.LITTLE_ENDIAN); return _bb.getInt(_bb.position()); }
+   public static boolean MonsterBufferHasIdentifier(ByteBuffer _bb) { return __has_identifier(_bb, ""MONS""); }
+   public void __init(int _i, ByteBuffer _bb) { bb_pos = _i; bb = _bb; }
+   public Monster __assign(int _i, ByteBuffer _bb) { __init(_i, _bb); return this; }","Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?"
+2355,"@@ -45,10 +45,11 @@ import getNoDataComponent from '../../../../components/legacy-notifications/noda
+ import getDataErrorComponent from '../../../../components/legacy-notifications/data-error';
+ import HelpLink from '../../../../components/HelpLink';
+ import { getCurrentDateRangeDayCount } from '../../../../util/date-range';
+-import { STORE_NAME } from '../../datastore/constants';
++import { STORE_NAME, DATE_RANGE_OFFSET } from '../../datastore/constants';
+ import { CORE_USER } from '../../../../googlesitekit/datastore/user/constants';
+ import { CORE_SITE } from '../../../../googlesitekit/datastore/site/constants';
+ import { untrailingslashit } from '../../../../util';
++import { generateDateRangeArgs } from '../../util/report-date-range-args';
+
+ const { useSelect } = Data;
+ ",Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`.
+2356,"@@ -21,11 +21,14 @@ async function proceedToSetUpAnalytics() {
+ 	await Promise.all( [
+ 		expect( page ).toClick( '.googlesitekit-cta-link', { text: /set up analytics/i } ),
+ 		page.waitForSelector( '.googlesitekit-setup-module--analytics' ),
+-		page.waitForResponse( ( res ) => res.url().match( 'analytics/data' ) ),
++		page.waitForResponse( ( res ) => res.url().match( 'analytics/data/accounts-properties-profiles' ) ),
+ 	] );
+ }
+
+-const EXISTING_PROPERTY_ID = 'UA-00000001-1';
++const existingTag = {
++	accountID: '999',
++	propertyID: 'UA-999-9',
++};
+
+ describe( 'setting up the Analytics module with no existing account and with an existing tag', () => {
+ 	beforeAll( async () => {",I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?
+2357,"@@ -11,13 +11,13 @@ import (
+ 	""strings""
+ )
+
+-type identityManager struct {
+-	keystoreManager keystoreInterface
++type IdentityManager struct {
++	KeystoreManager keystoreInterface
+ }
+
+-func NewIdentityManager(keydir string) *identityManager {
+-	return &identityManager{
+-		keystoreManager: keystore.NewKeyStore(keydir, keystore.StandardScryptN, keystore.StandardScryptP),
++func NewIdentityManager(keydir string) *IdentityManager {
++	return &IdentityManager{
++		KeystoreManager: keystore.NewKeyStore(keydir, keystore.StandardScryptN, keystore.StandardScryptP),
+ 	}
+ }
+ ",This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`
+2358,"@@ -34,6 +34,10 @@ import (
+
+ const transportName = ""redis""
+
++const maxConnectRetries = 100
++
++var connectRetryDelay = 10 * time.Millisecond
++
+ // Inbound is a redis inbound that reads from the given queueKey. This will
+ // wait for an item in the queue or until the timout is reached before trying
+ // to read again.",Is this too frequent?
+2359,"@@ -21,6 +21,7 @@ class UploadModel
+ {
+     private const FILE_EXTENSIONS = [
+         'csv',
++        'zip',
+     ];
+
+     /**","will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?"
+2360,"@@ -34,6 +34,7 @@ from .http import UpstreamConnectLayer
+ from .http1 import Http1Layer
+ from .http2 import Http2Layer
+ from .rawtcp import RawTCPLayer
++from .socks_client import SocksClientLayer
+
+ __all__ = [
+     ""Layer"", ""ServerConnectionMixin"", ""Kill"",",Needs to be mentioned in `__all__` below.
+2361,"@@ -349,6 +349,13 @@ signalfd_thread_exit(dcontext_t *dcontext, thread_sig_info_t *info)
+     TABLE_RWLOCK(sigfd_table, write, unlock);
+ }
+
++bool
++is_repeat_handle_pre_extended_syscall_sigmasks(dcontext_t *dcontext)
++{
++    thread_sig_info_t *info = (thread_sig_info_t *)dcontext->signal_field;
++    return info->pre_syscall_app_sigprocmask_valid;
++}
++
+ bool
+ handle_pre_extended_syscall_sigmasks(dcontext_t *dcontext, kernel_sigset_t *sigmask,
+                                      size_t sizemask)","What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?"
+2362,"@@ -139,8 +139,10 @@ public interface DataFile {
+   DataFile copy();
+
+   /**
+-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
+-   * information is used for planning scan tasks whose boundaries are determined by these offsets.
++   * @return List of offsets for blocks of a file, if applicable, null otherwise.
++   * When available, this information is used for planning scan tasks whose boundaries
++   * are determined by these offsets.It is important that the returned list is sorted
++   * in ascending order.
+    */
+   List<Long> splitOffsets();
+ }","Nit: missing a space. I think we should phrase the new content a little differently. ""It is important"" isn't very clear. I think it should be ""offsets will be returned in sorted order."""
+2363,"@@ -10,8 +10,10 @@ import (
+ 	""crypto/md5""
+ 	""encoding/base64""
+ 	""encoding/hex""
++	""encoding/json""
+ 	""fmt""
+ 	""io""
++	""io/ioutil""
+ 	""net/http""
+ 	""net/url""
+ 	""path""",Can you remove this blank line and put the added import in sorted order (likely your editor will do this)
+2364,"@@ -606,12 +606,16 @@ static int listener_setup_ssl(h2o_configurator_command_t *cmd, h2o_configurator_
+                                                                 : ""share/h2o/fetch-ocsp-response"";
+         if (ocsp_update_interval != 0) {
+             switch (conf.run_mode) {
+-            case RUN_MODE_WORKER:
++            case RUN_MODE_WORKER: {
++                int err;
+                 ssl_config->ocsp_stapling.interval =
+                     ocsp_update_interval; /* is also used as a flag for indicating if the updater thread was spawned */
+                 ssl_config->ocsp_stapling.max_failures = ocsp_max_failures;
+-                pthread_create(&ssl_config->ocsp_stapling.updater_tid, NULL, ocsp_updater_thread, ssl_config);
+-                break;
++                err = pthread_create(&ssl_config->ocsp_stapling.updater_tid, NULL, ocsp_updater_thread, ssl_config);
++                if (err != 0) {
++                    fprintf(stderr, ""[OCSP Stapling] pthread_create for ocsp_updater_thread failed. errno:%d\n"", err);
++                }
++            } break;
+             case RUN_MODE_MASTER:
+             case RUN_MODE_DAEMON:
+                 /* nothing to do */","Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?"
+2365,"@@ -37,6 +37,15 @@ import { __, _x, sprintf } from '@wordpress/i18n';
+ import { Component, Fragment } from '@wordpress/element';
+ import { addFilter, removeFilter } from '@wordpress/hooks';
+
++/**
++ * Internal dependencies
++ */
++import { isValidAccountID, isValidContainerID } from './util';
++
++const ACCOUNT_CREATE = 'account_create';
++const ACCOUNT_CHOOSE = 'account_choose';
++const CONTAINER_CREATE = 'container_create';
++
+ class TagmanagerSetup extends Component {
+ 	constructor( props ) {
+ 		super( props );","I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an ""empty"" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container."
+2366,"@@ -101,3 +101,16 @@ Blockly.scratchBlocksUtils.isShadowArgumentReporter = function(block) {
+   return (block.isShadow() && (block.type == 'argument_reporter_boolean' ||
+       block.type == 'argument_reporter_string_number'));
+ };
++
++/**
++ * Compare strings with natural number sorting.
++ * @param {string} str1 First input.
++ * @param {string} str2 Second input.
++ * @return {number} -1, 0, or 1 to signify greater than, equality, or less than.
++ */
++Blockly.scratchBlocksUtils.compareStrings = function(str1, str2) {
++  return str1.localeCompare(str2, undefined, {
++    sensitivity: 'base',
++    numeric: true
++  });
++};","I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error."
+2367,"@@ -114,12 +114,11 @@ func getEngine() (*xorm.Engine, error) {
+ 		}
+ 	case ""postgres"":
+ 		host, port := ""127.0.0.1"", ""5432""
+-		fields := strings.Split(DbCfg.Host, "":"")
+-		if len(fields) > 0 && len(strings.TrimSpace(fields[0])) > 0 {
+-			host = fields[0]
+-		}
+-		if len(fields) > 1 && len(strings.TrimSpace(fields[1])) > 0 {
+-			port = fields[1]
++		if strings.Contains(DbCfg.Host, "":"") && !strings.HasSuffix(DbCfg.Host, ""]"") {
++			host = DbCfg.Host[0:strings.LastIndex(DbCfg.Host, "":"")]
++			port = DbCfg.Host[strings.LastIndex(DbCfg.Host, "":"")+1:]
++		} else if len(DbCfg.Host) > 0 {
++			host = DbCfg.Host
+ 		}
+
+ 		if host[0] == '/' { // looks like a unix socket","1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, "":"")` to a variable and reuse."
+2368,"@@ -157,6 +157,7 @@ type Options struct {
+ 	NoLog                 bool          `json:""-""`
+ 	NoSigs                bool          `json:""-""`
+ 	NoSublistCache        bool          `json:""-""`
++	NoHeaderSupport       bool          `json:""-""`
+ 	DisableShortFirstPing bool          `json:""-""`
+ 	Logtime               bool          `json:""-""`
+ 	MaxConn               int           `json:""max_connections""`","Do you envision ""new"" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a ""private"" (non exported) option."
+2369,"@@ -51,7 +51,7 @@ type Connection struct {
+ func (c *Connection) Start(options connection.ConnectOptions) (err error) {
+ 	var config wg.ServiceConfig
+ 	if err := json.Unmarshal(options.SessionConfig, &config); err != nil {
+-		return err
++		return errors.Wrap(err, ""failed to unmarshal connection config"")
+ 	}
+ 	c.config.Provider = config.Provider
+ 	c.config.Consumer.IPAddress = config.Consumer.IPAddress",For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR.
+2370,"@@ -110,7 +110,7 @@ func init() {
+ 	addTxnFlags(freezeAssetCmd)
+
+ 	infoAssetCmd.Flags().Uint64Var(&assetID, ""assetid"", 0, ""ID of the asset to look up"")
+-	infoAssetCmd.Flags().StringVar(&assetUnitName, ""asset"", """", ""Unit name of the asset to look up"")
++	infoAssetCmd.Flags().StringVar(&assetUnitName, ""unit"", """", ""Unit name of the asset to look up"")
+ 	infoAssetCmd.Flags().StringVar(&assetCreator, ""creator"", """", ""Account address of the asset creator"")
+ }
+ ","I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use."
+2371,"@@ -0,0 +1,19 @@
++// +build windows
++
++package terminal
++
++import (
++	""syscall""
++)
++
++// HideConsole hides the console window and activates another window
++func HideConsole() {
++	getConsoleWindow := syscall.NewLazyDLL(""kernel32.dll"").NewProc(""GetConsoleWindow"")
++	showWindow := syscall.NewLazyDLL(""user32.dll"").NewProc(""ShowWindow"")
++	if getConsoleWindow.Find() == nil && showWindow.Find() == nil {
++		hwnd, _, _ := getConsoleWindow.Call()
++		if hwnd != 0 {
++			showWindow.Call(hwnd, 0)
++		}
++	}
++}",Which windows gets activated? A random other window?
+2372,"@@ -62,6 +62,11 @@ func (a *Publisher) Start(ctx context.Context) error {
+ }
+
+ func (a *Publisher) receive(ctx context.Context, event cloudevents.Event, resp *cloudevents.EventResponse) error {
++	// Upgrade to supported transport version.
++	if event.SpecVersion() != cloudevents.VersionV03 {
++		event.Context = event.Context.AsV03()
++	}
++
+ 	if _, r, err := a.outbound.Send(ctx, event); err != nil {
+ 		return err
+ 	} else if r != nil {","Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?"
+2373,"@@ -228,4 +228,10 @@ public class TableProperties {
+
+   public static final String MERGE_CARDINALITY_CHECK_ENABLED = ""write.merge.cardinality-check.enabled"";
+   public static final boolean MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT = true;
++
++  public static final String WATERMARK_FIELD_NAME = ""write.watermark.field"";
++  public static final String WATERMARK_FIELD_NAME_DEFAULT = """";
++
++  public static final String WATERMARK_VALUE = ""write.watermark"";
++  public static final long WATERMARK_VALUE_DEFAULT = -1;
+ }","In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this."
+2374,"@@ -67,6 +67,16 @@ func (h TlfHandle) IsReader(user keybase1.UID) bool {
+ 	return ok
+ }
+
++// ResolvedReadersMap returns a map of resolved readers from uid to usernames.
++func (h TlfHandle) ResolvedReadersMap() map[keybase1.UID]libkb.NormalizedUsername {
++	return h.resolvedReaders
++}
++
++// ResolvedWritersMap returns a map of resolved writers from uid to usernames.
++func (h TlfHandle) ResolvedWritersMap() map[keybase1.UID]libkb.NormalizedUsername {
++	return h.resolvedWriters
++}
++
+ func (h TlfHandle) unsortedResolvedWriters() []keybase1.UID {
+ 	if len(h.resolvedWriters) == 0 {
+ 		return nil","Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit."
+2375,"@@ -439,10 +439,12 @@ function createTopology(mongoClient, topologyType, options, callback) {
+     }
+
+     const MongoClient = loadClient();
+-    const connectionString =
+-      os.platform() === 'win32'
+-        ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
+-        : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    let connectionString =
++      mongoClient.s.options.cryptdConnectionString != null
++        ? mongoClient.s.options.cryptdConnectionString
++        : os.platform() === 'win32'
++          ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
++          : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
+
+     const mongocryptdClient = new MongoClient(connectionString, { useUnifiedTopology: true });
+     mongocryptdClient.connect(err => {","I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?"
+2376,"@@ -427,7 +427,8 @@ if __name__ == ""__main__"":  # pragma: no cover
+                 tls_start.ssl_conn.set_accept_state()
+             else:
+                 tls_start.ssl_conn.set_connect_state()
+-                tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni)
++                if tls_start.context.client.sni is not None:
++                    tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.encode())
+
+         await SimpleConnectionHandler(reader, writer, opts, {
+             ""next_layer"": next_layer,",Do we still support handshakes without SNI present?
+2377,"@@ -131,7 +131,7 @@ module Substitutors
+       when :post_replacements
+         text = sub_post_replacements text
+       else
+-        warn %(asciidoctor: WARNING: unknown substitution type #{type})
++        logger.warn %(unknown substitution type #{type})
+       end
+     end
+     text = restore_passthroughs text if has_passthroughs","Maybe it's because I work too much on a centralized logging system but it could be great to add a ""category"" like ""attribute"", ""substitution"", ""include directive"", ""macro"", ""extension""..."
+2378,"@@ -45,7 +45,7 @@ def normalizeName(name):
+     """"""Normalize the class name to remove ambiguity
+
+     This function removes the white spaces in the name, and also
+-    remove the pointer declaration ""*"" (it have no sense in python) """"""
++    remove the pointer declaration ""*"" (it have no sense in python)""""""
+
+     name = name.replace("" "", """")
+     name = name.replace(""*"", """")",it have no sense in python -> it makes no sense in python
+2379,"@@ -29,11 +29,13 @@ import (
+ type Pool struct {
+ 	start, capacity int
+ 	rand            *rand.Rand
++	openvpnPort     int
+ }
+
+ // ServicePortSupplier provides port needed to run a service on
+ type ServicePortSupplier interface {
+ 	Acquire() (Port, error)
++	OpenvpnPort() (Port, error)
+ }
+
+ // NewPool creates a port pool that will provide ports from range 40000-50000",maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here.
+2380,"@@ -413,7 +413,7 @@ function createTopology(mongoClient, topologyType, options, callback) {
+   // Open the connection
+   topology.connect(options, (err, newTopology) => {
+     if (err) {
+-      topology.close(true);
++      if (topology) topology.close();
+       return callback(err);
+     }
+ ",how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?
+2381,"@@ -0,0 +1,13 @@
++require 'spec_helper'
++
++describe Widgets::PlanChurnsController do
++  it 'returns the current churn for the requested plan' do
++    plan = stub(current_churn: 10)
++    PlanFinder.stubs(where: [plan])
++
++    get :show, format: :json, sku: 'sku'
++
++    expect(PlanFinder).to have_received(:where).with(sku: 'sku')
++    expect(number_widget_first_value).to eq 10
++  end
++end",Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?
+2382,"@@ -141,8 +141,6 @@ func NewMinEdgeSiteConfig() *EdgeSiteConfig {
+ 			APIVersion: path.Join(GroupName, APIVersion),
+ 		},
+ 		DataBase: &edgecoreconfig.DataBase{
+-			DriverName: DataBaseDriverName,
+-			AliasName:  DataBaseAliasName,
+ 			DataSource: DataBaseDataSource,
+ 		},
+ 		KubeAPIConfig: &cloudcoreconfig.KubeAPIConfig{",We need to do the same for edgecore
+2383,"@@ -378,8 +378,15 @@ namespace TestPlatform.CommunicationUtilities.UnitTests
+             this.mockDataSerializer.Setup(ds => ds.DeserializeMessage(rawMessage)).Returns(message);
+             this.mockDataSerializer.Setup(ds => ds.DeserializePayload<TestRunCompletePayload>(message)).Returns(payload);
+
++            var waitHandle = new AutoResetEvent(false);
++            mockHandler.Setup(mh => mh.HandleTestRunComplete(It.IsAny<TestRunCompleteEventArgs>(),
++                It.IsAny<TestRunChangedEventArgs>(), It.IsAny<ICollection<AttachmentSet>>(), It.IsAny<ICollection<string>>())).Callback
++                (() => waitHandle.Set());
++
+             this.testRequestSender.StartTestRun(runCriteria, mockHandler.Object);
+
++            waitHandle.WaitOne();
++
+             this.mockCommunicationManager.Verify(mc => mc.SendMessage(MessageType.StartTestExecutionWithTests, runCriteria), Times.Once);
+             this.mockDataSerializer.Verify(ds => ds.DeserializeMessage(rawMessage), Times.Once);
+             mockHandler.Verify(mh => mh.HandleTestRunComplete(null, null, null, null), Times.Once);",This fix has nothing to do with the product change. Just a fix I am making for the test issue.
+2384,"@@ -94,8 +94,7 @@ namespace OpenTelemetry.Trace
+             }
+             else if (this.Exporter != null)
+             {
+-                // TODO: Make this BatchingActivityProcessor once its available.
+-                exportingProcessor = new SimpleActivityProcessor(this.Exporter);
++                exportingProcessor = new BatchingActivityProcessor(this.Exporter);
+                 this.Processors.Add(exportingProcessor);
+             }
+ ",Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta.
+2385,"@@ -1,4 +1,4 @@
+-require 'rspec/support/reentrant_mutex'
++RSpec::Support.require_rspec_support 'reentrant_mutex'
+
+ module RSpec
+   module Core","Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one."
+2386,"@@ -27,6 +27,7 @@ namespace MvvmCross.Platforms.Ios.Binding.Views
+             : base(tableView)
+         {
+             _cellIdentifier = new NSString(cellIdentifier);
++            tableView.RegisterNibForCellReuse(UINib.FromName(cellIdentifier, NSBundle.MainBundle), cellIdentifier);
+         }
+
+         public MvxSimpleTableViewSource(UITableView tableView, string nibName, string cellIdentifier = null,",What happens if there is no NIB/XIB with that name?
+2387,"@@ -79,7 +79,7 @@ type Server struct {
+ 	ap               actpool.ActPool
+ 	gs               *gasstation.GasStation
+ 	broadcastHandler BroadcastOutbound
+-	cfg              config.API
++	cfg              config.Config
+ 	registry         *protocol.Registry
+ 	blockListener    *blockListener
+ 	grpcserver       *grpc.Server",this is not necessary?
+2388,"@@ -19,6 +19,7 @@ import (
+
+ 	""github.com/aws/amazon-ecs-agent/agent/taskresource""
+ 	asmauthres ""github.com/aws/amazon-ecs-agent/agent/taskresource/asmauth""
++	asmsecretres ""github.com/aws/amazon-ecs-agent/agent/taskresource/asmsecret""
+ 	cgroupres ""github.com/aws/amazon-ecs-agent/agent/taskresource/cgroup""
+ 	ssmsecretres ""github.com/aws/amazon-ecs-agent/agent/taskresource/ssmsecret""
+ 	""github.com/aws/amazon-ecs-agent/agent/taskresource/volume""","typo: `asmsecrets ""github...`"
+2389,"@@ -269,14 +269,14 @@ function neve_sanitize_meta_ordering( $value ) {
+ 	);
+
+ 	if ( empty( $value ) ) {
+-		return $allowed;
++		return wp_json_encode( $allowed );
+ 	}
+
+ 	$decoded = json_decode( $value, true );
+
+ 	foreach ( $decoded as $val ) {
+ 		if ( ! in_array( $val, $allowed, true ) ) {
+-			return $allowed;
++			return wp_json_encode( $allowed );
+ 		}
+ 	}
+ ","I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it  "
+2390,"@@ -79,6 +79,12 @@ func (i *Inbound) SetRegistry(registry transport.Registry) {
+ 	i.registry = registry
+ }
+
++// Transports returns the inbound's HTTP transport.
++func (i *Inbound) Transports() []transport.Transport {
++	// TODO factor out transport and return it here.
++	return []transport.Transport{}
++}
++
+ // Start starts the inbound with a given service detail, opening a listening
+ // socket.
+ func (i *Inbound) Start() error {",Should we put a TODO here to route the http.Transport through here?
+2391,"@@ -177,7 +177,7 @@ func RemoveManagementInterface(networkName string) error {
+ 	var err error
+ 	var maxRetry = 3
+ 	var i = 0
+-	cmd := fmt.Sprintf(""Get-VMSwitch -Name %s  | Set-VMSwitch -AllowManagementOS $false "", networkName)
++	cmd := fmt.Sprintf(""Get-VMSwitch -ComputerName $(hostname) -Name %s  | Set-VMSwitch -ComputerName $(hostname) -AllowManagementOS $false "", networkName)
+ 	// Retry the operation here because an error is returned at the first invocation.
+ 	for i < maxRetry {
+ 		_, err = ps.RunCommand(cmd)","Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly."
+2392,"@@ -131,9 +131,13 @@ func runCliTool(logger *log.Logger, testCase *junitxml.TestCase, cmdString strin
+ }
+
+ // RunTestCommand runs given test command
+-func RunTestCommand(cmd string, args []string, logger *log.Logger, testCase *junitxml.TestCase) bool {
++func RunTestCommand(cmd string, args []string, logger *log.Logger, testCase *junitxml.TestCase, allowError bool) bool {
+ 	if err := runCliTool(logger, testCase, cmd, args); err != nil {
+-		Failure(testCase, logger, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		if allowError {
++			logger.Printf(""[%v] %v"", testCase.Name, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		} else {
++			Failure(testCase, logger, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		}
+ 		return false
+ 	}
+ 	return true","`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means ""maybe an error can occur, and that's okay"" -- what's an example of this?"
+2393,"@@ -29,7 +29,11 @@ var Xrc20Cmd = &cobra.Command{
+ var xrc20ContractAddress string
+
+ func xrc20Contract() (address.Address, error) {
+-	return alias.IOAddress(xrc20ContractAddress)
++	addr, err := alias.IOAddress(xrc20ContractAddress)
++	if err != nil {
++		return nil, output.NewError(output.FlagError, ""invalid xrc20 address flag"", err)
++	}
++	return addr, nil
+ }
+
+ type amountMessage struct {",return statements should not be cuddled if block has more than two lines (from `wsl`)
+2394,"@@ -10,11 +10,12 @@ import java.util.*;
+ import java.util.concurrent.TimeUnit;
+
+ import static java.lang.management.ManagementFactory.*;
++import sun.reflect.generics.reflectiveObjects.NotImplementedException;
+
+ /**
+  * A collection of Java Virtual Machine metrics.
+  */
+-public class VirtualMachineMetrics {
++public class VirtualMachineMetrics implements Metric {
+     public static class GarbageCollector {
+         private final long runs, timeMS;
+ ",Why does VirtualMachineMetrics have to implement Metric?
+2395,"@@ -64,16 +64,12 @@ func TestSingleAccountManager_SignVote(t *testing.T) {
+ 	require.NoError(err)
+ 	voteeAddress, err := iotxaddress.GetAddressByPubkey(iotxaddress.IsTestnet, iotxaddress.ChainID, votePubKey)
+ 	require.NoError(err)
+-	rawVote, err := action.NewVote(uint64(1), voterAddress.RawAddress, voteeAddress.RawAddress, uint64(100000), big.NewInt(10))
++	vote, err := action.NewVote(uint64(1), voterAddress.RawAddress, voteeAddress.RawAddress, uint64(100000), big.NewInt(10))
+ 	require.NoError(err)
+-	signedVote, err := m.SignVote(rawVote)
+-	require.NoError(err)
+-	require.NotNil(signedVote)
++	require.NoError(m.SignVote(vote))
+
+ 	require.NoError(accountManager.Remove(rawAddr1))
+-	signedVote, err = m.SignVote(rawVote)
+-	require.Equal(ErrNumAccounts, errors.Cause(err))
+-	require.Nil(signedVote)
++	require.Equal(ErrNumAccounts, errors.Cause(m.SignVote(vote)))
+ }
+
+ func TestSingleAccountManager_SignHash(t *testing.T) {",line is 121 characters
+2396,"@@ -93,7 +93,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
+ 		}
+ 	}
+ 	// Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
+-	else if (name[0] === 'o' && name[1] === 'n') {
++	else if (name.slice(0, 2) === 'on') {
+ 		let useCapture = name !== (name = name.replace(/Capture$/, ''));
+ 		let nameLower = name.toLowerCase();
+ 		name = (nameLower in dom ? nameLower : name).slice(2);",How's that linked esbench looking with slice?
+2397,"@@ -131,14 +131,11 @@ class RemoteFileSystem(luigi.target.FileSystem):
+         return exists
+
+     def _ftp_exists(self, path, mtime):
+-        path_parts = path.split('/')
+-        path = '/'.join(path_parts[:-1])
+-        fn = path_parts[-1]
+-
+-        files = self.conn.nlst(path)
++        dirname = os.path.dirname(path)
++        files = self.conn.nlst(dirname)
+
+         exists = False
+-        if fn in files:
++        if path in files:
+             if mtime:
+                 mdtm = self.conn.sendcmd('MDTM ' + path)
+                 modified = datetime.datetime.strptime(mdtm[4:], ""%Y%m%d%H%M%S"")","The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join."
+2398,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+
+   public abstract void remove(SessionId id);
+
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.
+2399,"@@ -335,6 +335,9 @@ func (s *session) run() error {
+
+ 	var closeErr closeError
+ 	handshakeEvent := s.handshakeEvent
++	var pacingDeadline time.Time
++
++	s.maybeResetTimer(time.Time{})
+
+ runLoop:
+ 	for {",Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc.
+2400,"@@ -715,9 +715,9 @@ void testCanonicalize() {
+   TautomerEnumerator te(new TautomerCatalog(tautparams.get()));
+
+   for (const auto &itm : canonTautomerData) {
+-    std::unique_ptr<ROMol> mol{SmilesToMol(itm.first)};
++    ROMOL_SPTR mol{SmilesToMol(itm.first)};
+     TEST_ASSERT(mol);
+-    std::unique_ptr<ROMol> res{te.canonicalize(*mol)};
++    ROMOL_SPTR res{te.canonicalize(*mol)};
+     TEST_ASSERT(res);
+     TEST_ASSERT(MolToSmiles(*res) == itm.second);
+   }",I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?
+2401,"@@ -51,7 +51,7 @@ import static org.apache.lucene.util.IOUtils.closeWhileHandlingException;
+ public class ContainerPluginsApi {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+-  public static final String PLUGIN = ""plugin"";
++  public static final String PLUGINS = ""plugin"";
+   private final Supplier<SolrZkClient> zkClientSupplier;
+   private final CoreContainer coreContainer;
+   public final Read readAPI = new Read();",why change the variable name at all?
+2402,"@@ -123,6 +123,9 @@ axe.utils.getFlattenedTree = function (node, shadowId) {
+ axe.utils.getNodeFromTree = function (vNode, node) {
+ 	var found;
+
++	if (vNode.actualNode === node) {
++		return vNode;
++	}
+ 	vNode.children.forEach((candidate) => {
+ 		var retVal;
+ ","Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?"
+2403,"@@ -269,6 +269,14 @@ public class MessageViewFragment extends Fragment implements ConfirmationDialogF
+         return mMessageView.getMessageHeaderView().additionalHeadersVisible();
+     }
+
++    public boolean isAccountReportSpamEnabled() {
++        try {
++            return (mAccount != null && !mAccount.getReportSpamRecipient().isEmpty());
++        } catch (Exception e) {
++            return false;
++        }
++    }
++
+     private void delete() {
+         if (mMessage != null) {
+             // Disable the delete button after it's tapped (to try to prevent",Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null
+2404,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.
+2405,"@@ -202,7 +202,9 @@ namespace Microsoft.DotNet.Build.Tasks.Packaging
+                                {
+                                    Id = d.ItemSpec,
+                                    Version = d.GetVersion(),
+-                                   TargetFramework = d.GetTargetFramework()
++                                   TargetFramework = d.GetTargetFramework(),
++                                   Include = d.GetValueList(""Include""),
++                                   Exclude = d.GetValueList(""Exclude"")
+                                };
+
+             return (from dependency in dependencies",Do we actually use Include anywhere yet or is this just for completion?
+2406,"@@ -321,6 +321,10 @@ def data(readonly=False):
+              SettingValue(typ.String(none_ok=True), 'en-US,en'),
+              ""Value to send in the `accept-language` header.""),
+
++            ('referer-header',
++             SettingValue(typ.Referer(), 'same-domain'),
++             ""Send the Referer header""),
++
+             ('user-agent',
+              SettingValue(typ.UserAgent(none_ok=True), ''),
+              ""User agent to send. Empty to send the default.""),",It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:
+2407,"@@ -95,7 +95,7 @@ define([""loading"", ""dialogHelper"", ""dom"", ""jQuery"", ""components/libraryoptionsed
+
+     function getFolderHtml(pathInfo, index) {
+         var html = """";
+-        return html += '<div class=""listItem listItem-border lnkPath"" style=""padding-left:.5em;"">', html += '<div class=""' + (pathInfo.NetworkPath ? ""listItemBody two-line"" : ""listItemBody"") + '"">', html += '<div class=""listItemBodyText"">' + pathInfo.Path + ""</div>"", pathInfo.NetworkPath && (html += '<div class=""listItemBodyText secondary"">' + pathInfo.NetworkPath + ""</div>""), html += ""</div>"", html += '<button type=""button"" is=""paper-icon-button-light"""" class=""listItemButton btnRemovePath"" data-index=""' + index + '""><i class=""md-icon"">remove_circle</i></button>', html += ""</div>""
++        return html += '<div class=""listItem listItem-border lnkPath"" style=""padding-left:.5em;"">', html += '<div class=""' + (pathInfo.NetworkPath ? ""listItemBody two-line"" : ""listItemBody"") + '"">', html += '<div class=""listItemBodyText"">' + pathInfo.Path + ""</div>"", pathInfo.NetworkPath && (html += '<div class=""listItemBodyText secondary"">' + pathInfo.NetworkPath + ""</div>""), html += ""</div>"", html += '<button type=""button"" is=""paper-icon-button-light"""" class=""listItemButton btnRemovePath"" data-index=""' + index + '""><i class=""material-icons"">remove_circle</i></button>', html += ""</div>""
+     }
+
+     function renderPaths(page) {",seems we missed de-uglifying this one
+2408,"@@ -52,6 +52,14 @@ const (
+ 	TransactionPolicyPassive TransactionPolicy = 1
+ )
+
++type NewWorkflowType int
++
++const (
++	NewWorkflowUnspecified NewWorkflowType = iota
++	NewWorkflowRetry
++	NewWorkflowCron
++)
++
+ func (policy TransactionPolicy) Ptr() *TransactionPolicy {
+ 	return &policy
+ }",i guess these types & cron / retry specific belong to a dedicated util / struct
+2409,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below
+2410,"@@ -710,7 +710,8 @@
+                 }
+             },
+             skin: { default: ""main"", type: String},
+-            disabled: {type: Boolean, default: false}
++            disabled: {type: Boolean, default: false},
++            direction: { default: ""vertical"", type: String}
+         },
+         computed: {
+             topClasses: function() {",`direction` is referenced nowhere. Do I miss something?
+2411,"@@ -1,4 +1,3 @@
+-import deparam from 'npm:deparam';
+ import destroyApp from '../helpers/destroy-app';
+ import startApp from '../helpers/start-app';
+ import {Response} from 'ember-cli-mirage';",The two places this was used have been removed so we can fully remove this dependency.
+2412,"@@ -16,7 +16,6 @@
+
+ package agreement
+
+-//go:generate dbgen -i agree.sql -p agreement -n agree -o agreeInstall.go
+ import (
+ 	""context""
+ 	""database/sql""",This is a duplicate generation of the same file as below.
+2413,"@@ -200,7 +200,9 @@ def _non_dist_train(model,
+             seed=cfg.seed) for ds in dataset
+     ]
+     # put model on gpus
+-    model = MMDataParallel(model, device_ids=range(cfg.gpus)).cuda()
++    gpu_ids = range(cfg.gpus) if cfg.gpu_ids is None else cfg.gpu_ids
++    assert len(gpu_ids) == cfg.gpus
++    model = MMDataParallel(model.cuda(gpu_ids[0]), device_ids=gpu_ids)
+
+     # build runner
+     optimizer = build_optimizer(model, cfg.optimizer)",We may deprecate `gpus` if `gpu_ids` is specified.
+2414,"@@ -80,7 +80,7 @@ public class Connection implements Closeable {
+       serialized.put(""sessionId"", sessionId);
+     }
+
+-    LOG.info(JSON.toJson(serialized.build()));
++    LOG.finest(JSON.toJson(serialized.build()));
+     socket.sendText(JSON.toJson(serialized.build()));
+
+     if (!command.getSendsResponse() ) {",Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier.
+2415,"@@ -5,6 +5,8 @@ import { render } from './render';
+ import { rerender } from './render-queue';
+ import options from './options';
+
++c && _='b=[85,1,-1],d=Array(
1,0,4,	onpoimov(>{dd=>d%2),90+e.x=	e-12}),setIval(()=>{a1])%
,f
*2])
*f+a,(
<=a||!a1!f2|
<f!(=||(		0einnerText(d,e)=>e%
?d:""\\n""+d))},
;
100]	e].fill(=d.map(]*=-1)|((||3,c.	d[b[)&&/
|0,0)]=e=nter=(+';for(Y in $='	
')with(_.split($[Y]))_=join(pop());eval(_)
++
+ export default {
+ 	h,
+ 	createElement,",unnecessary spaces here are doubling the size of this otherwise extremely useful addition
+2416,"@@ -339,7 +339,7 @@ partial class Build
+        .Executes(() =>
+        {
+            // start by copying everything from the tracer home dir
+-           CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge);
++           CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge, FileExistsPolicy.OverwriteIfNewer);
+
+            if (IsWin)
+            {","I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out."
+2417,"@@ -371,6 +371,7 @@ void test3() {
+     }
+ #endif
+     {
++      std::cout << ""test3_5"" << std::endl;
+       std::ofstream outs((nameBase + "".svg"").c_str());
+       MolDraw2DSVG drawer(200, 200, outs);
+       drawer.drawOptions() = options;",this should probably be removed
+2418,"@@ -74,7 +74,7 @@ func TestConfigDaemon(t *testing.T) {
+ 		jsonOut := op1.ReadStdout()
+ 		bootstrapConfig := config.NewDefaultConfig().Bootstrap
+ 		bootstrapConfig.Addresses = []string{""fake1"", ""fake2""}
+-		someJSON, err := json.MarshalIndent(bootstrapConfig, """", ""\t"")
++		someJSON, err := json.Marshal(bootstrapConfig)
+ 		require.NoError(t, err)
+ 		assert.Equal(t, fmt.Sprintf(""%s\n"", string(someJSON)), jsonOut)
+ ","Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?"
+2419,"@@ -159,6 +159,11 @@ type NetworkSpec struct {
+ 	// This is optional - if not provided new security groups will be created for the cluster
+ 	// +optional
+ 	SecurityGroupOverrides map[SecurityGroupRole]string `json:""securityGroupOverrides,omitempty""`
++
++	// AdditionalIngressRules is an optional map from security group role to a set of additional ingress
++	// rules to add to the security group rules created for that role
++	// +optional
++	AdditionalIngressRules map[SecurityGroupRole]IngressRules `json:""additionalIngressRules,omitempty""`
+ }
+
+ // VPCSpec configures an AWS VPC.",Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome.
+2420,"@@ -387,7 +387,7 @@ public final class ORCSchemaUtil {
+         .map(Integer::parseInt);
+   }
+
+-  static int fieldId(TypeDescription orcType) {
++  public static int fieldId(TypeDescription orcType) {
+     String idStr = orcType.getAttributeValue(ICEBERG_ID_ATTRIBUTE);
+     Preconditions.checkNotNull(idStr, ""Missing expected '%s' property"", ICEBERG_ID_ATTRIBUTE);
+     return Integer.parseInt(idStr);",Can we avoid making this public with the other updates?
+2421,"@@ -165,8 +165,8 @@ void DataTransformer<Dtype>::Transform(const vector<Datum> & datum_vector,
+   const int width = transformed_blob->width();
+
+   CHECK_GT(datum_num, 0) << ""There is no datum to add"";
+-  CHECK_LE(datum_num, num) <<
+-    ""The size of datum_vector must be smaller than transformed_blob->num()"";
++  CHECK_EQ(datum_num, num) <<
++    ""The size of datum_vector must be equals to transformed_blob->num()"";
+   Blob<Dtype> uni_blob(1, channels, height, width);
+   for (int item_id = 0; item_id < datum_num; ++item_id) {
+     int offset = transformed_blob->offset(item_id);",Why did you change this equal instead of less or equal?
+2422,"@@ -30,11 +30,11 @@ import org.apache.tuweni.units.bigints.UInt256;
+ public interface WorldStateArchive {
+   Hash EMPTY_ROOT_HASH = Hash.wrap(MerklePatriciaTrie.EMPTY_TRIE_NODE_HASH);
+
+-  Optional<WorldState> get(final Hash rootHash);
++  Optional<WorldState> get(final Hash rootHash, Hash blockHash);
+
+-  boolean isWorldStateAvailable(final Hash rootHash);
++  boolean isWorldStateAvailable(final Hash rootHash, Hash blockHash);
+
+-  Optional<MutableWorldState> getMutable(final Hash rootHash);
++  Optional<MutableWorldState> getMutable(final Hash rootHash, Hash blockHash);
+
+   MutableWorldState getMutable();
+ ",missing final for the blockHash field
+2423,"@@ -1,5 +1,5 @@
+-require 'factory_girl_rails'
++require 'factory_bot_rails'
+
+ RSpec.configure do |config|
+-  config.include FactoryGirl::Syntax::Methods
+-end
++  config.include FactoryBot::Syntax::Methods
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+2424,"@@ -126,5 +126,8 @@ class L2Norm(nn.Module):
+         self.scale = scale
+
+     def forward(self, x):
+-        norm = x.pow(2).sum(1, keepdim=True).sqrt() + self.eps
+-        return self.weight[None, :, None, None].expand_as(x) * x / norm
++        # normalization layer convert to FP32
++        float_x = x.float()
++        norm = float_x.pow(2).sum(1, keepdim=True).sqrt() + self.eps
++        return (self.weight[None, :, None, None].float().expand_as(float_x) *
++                float_x / norm).type_as(x)",`x_float` instead of `float_x`.
+2425,"@@ -5,6 +5,9 @@ import dialogHelper from '../../components/dialogHelper/dialogHelper';
+ import keyboardnavigation from '../../scripts/keyboardNavigation';
+ import { appRouter } from '../../components/appRouter';
+ import ServerConnections from '../../components/ServerConnections';
++// eslint-disable-next-line import/named, import/namespace
++import { Swiper } from 'swiper/swiper-bundle.esm';
++import 'swiper/swiper-bundle.css';
+
+ export class ComicsPlayer {
+     constructor() {","Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR."
+2426,"@@ -145,12 +145,15 @@ func TestFuncHookRun(t *testing.T) {
+
+ 	fHook := configs.NewFunctionHook(func(s *specs.State) error {
+ 		if !reflect.DeepEqual(state, s) {
+-			t.Errorf(""Expected state %+v to equal %+v"", state, s)
++			return fmt.Errorf(""expected state %+v to equal %+v"", state, s)
+ 		}
+ 		return nil
+ 	})
+
+-	fHook.Run(state)
++	err := fHook.Run(state)
++	if err != nil {
++		t.Fatal(err)
++	}
+ }
+
+ func TestCommandHookRun(t *testing.T) {","Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing."
+2427,"@@ -41,6 +41,7 @@ import (
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ttime""
+
+ 	""github.com/cihub/seelog""
++	""github.com/docker/docker/api/types""
+ 	""github.com/docker/docker/api/types/volume""
+ 	docker ""github.com/fsouza/go-dockerclient""
+ )","I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer."
+2428,"@@ -1853,8 +1853,12 @@ presys_SetContextThread(dcontext_t *dcontext, reg_t *param_base)
+     /* FIXME : we are going to read and write to cxt, which may be unsafe */
+     ASSERT(tid != 0xFFFFFFFF);
+     LOG(THREAD, LOG_SYSCALLS|LOG_THREADS, IF_DGCDIAG_ELSE(1, 2),
+-        ""syscall: NtSetContextThread handle=""PFX"" tid=%d cxt->Xip=""PFX""\n"",
+-        thread_handle, tid, cxt->CXT_XIP);
++        ""syscall: NtSetContextThread handle=""PFX"" tid=%d cxt->Xip=""PFX"" flags=""PFX""\n"",
++        thread_handle, tid, cxt->CXT_XIP, cxt->ContextFlags);
++    if (get_thread_id() == tid) {
++        /* Simple case when called on own thread. */
++        return execute_syscall;
++    }
+     mutex_lock(&thread_initexit_lock); /* need lock to lookup thread */
+     if (intercept_asynch_for_thread(tid, false/*no unknown threads*/)) {
+         priv_mcontext_t mcontext;","If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control."
+2429,"@@ -333,5 +333,8 @@ public interface OpenFoodAPIService {
+      */
+     @GET(""state/to-be-completed/{page}.json"")
+     Call<Search> getIncompleteProducts(@Path(""page"") int page);
++
++    @GET(""/.json"")
++    Call<Search> getTotalProductCount();
+ }
+ ",@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit.
+2430,"@@ -21,10 +21,14 @@ type Value struct {
+ 	Uint64  uint64
+ 	Float64 float64
+ 	String  string
+-	Bytes   []byte
+
+-	// TODO See how segmentio/stats handles this type, it's much smaller.
+-	// TODO Lazy value type?
++	// Note: this type could be made smaller by using a
++	// core.Number to represent four of these fields, e.g.,
++	// struct {
++	//   Type   ValueType
++	//   String string
++	//   Number Number
++	// }
+ }
+
+ const (",There's no core.Number yet. ;)
+2431,"@@ -24,6 +24,18 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	snapshotrevertHelpText = `
++Usage: mayactl snapshot revert [options]
++
++$ mayactl snapshot revert --volname <vol> --snapname <snap>
++
++This command rolls back the volume data to the specified snapshot.
++Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post.
++This command should be used cautiously and only when there is an issue with the current state of the data.
++`
++)
++
+ /*type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string","..., ...will be posted."
+2432,"@@ -14,7 +14,7 @@ func (f *Filecoin) ShowBlock(ctx context.Context, ref cid.Cid) (*types.Block, er
+
+ 	sRef := ref.String()
+
+-	if err := f.RunCmdJSONWithStdin(ctx, nil, &out, ""go-filecoin"", ""show"", ""block"", sRef); err != nil {
++	if err := f.RunCmdJSONWithStdin(ctx, nil, &out, ""go-filecoin"", ""show"", ""header"", sRef); err != nil {
+ 		return nil, err
+ 	}
+ ",Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`.
+2433,"@@ -25,6 +25,7 @@ CONFIG_PATH = BASE_PATH / 'config.yml'
+ OPEN_DATA_URL = ""https://open.quiltdata.com""
+
+ PACKAGE_NAME_FORMAT = r""([\w-]+/[\w-]+)(?:/(.+))?$""
++DISABLE_TQDM = os.getenv('QUILT_USE_TQDM', '').lower() != 'true'
+
+ ## CONFIG_TEMPLATE
+ # Must contain every permitted config key, as well as their default values (which can be 'null'/None).","@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better."
+2434,"@@ -46,7 +46,7 @@ func testENIAckTimeout(t *testing.T, attachmentType string) {
+
+ 	taskEngineState := dockerstate.NewTaskEngineState()
+
+-	expiresAt := time.Now().Add(time.Duration(waitTimeoutMillis) * time.Millisecond)
++	expiresAt := time.Now().Add(time.Millisecond * waitTimeoutMillis)
+ 	err := addENIAttachmentToState(attachmentType, attachmentArn, taskArn, randomMAC, expiresAt, taskEngineState)
+ 	assert.NoError(t, err)
+ 	assert.Len(t, taskEngineState.(*dockerstate.DockerTaskEngineState).AllENIAttachments(), 1)",unrelated but just changing for consistency with code below it
+2435,"@@ -78,12 +78,8 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		component.props = previousProps;
+ 		component.state = previousState;
+ 		component.context = previousContext;
+-		if (opts!==FORCE_RENDER
+-			&& component.shouldComponentUpdate
+-			&& component.shouldComponentUpdate(props, state, context) === false) {
+-			skip = true;
+-		}
+-		else if (component.componentWillUpdate) {
++		skip = opts!==FORCE_RENDER && component.shouldComponentUpdate && component.shouldComponentUpdate(props, state, context) === false;
++		if (component.componentWillUpdate) {
+ 			component.componentWillUpdate(props, state, context);
+ 		}
+ 		component.props = props;",This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates.
+2436,"@@ -56,6 +56,12 @@ PERMISSIONS_INHERITANCE_TREE = {
+             'group': ['write', 'read']
+         },
+     },
++    'history': {
++        'read': {
++            'bucket': ['write', 'read'],
++            'history': ['write', 'read']
++        },
++    },
+     'collection': {
+         'write': {
+             'bucket': ['write'],",We should add write inheritance too.
+2437,"@@ -12,6 +12,9 @@ from localstack.constants import DEFAULT_SERVICE_PORTS, LOCALHOST, PATH_USER_REQ
+
+ TRUE_VALUES = ('1', 'true')
+
++# java options to Lambda
++
++JAVA_OPTS = os.environ.get('JAVA_OPTS', '').strip()
+
+ # randomly inject faults to Kinesis
+ KINESIS_ERROR_PROBABILITY = float(os.environ.get('KINESIS_ERROR_PROBABILITY', '').strip() or 0.0)","Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README."
+2438,"@@ -25,6 +25,8 @@ import (
+ 	""google.golang.org/grpc/codes""
+ 	""google.golang.org/grpc/status""
+
++	""github.com/google/uuid""
++
+ 	""github.com/pipe-cd/pipe/pkg/app/api/analysisresultstore""
+ 	""github.com/pipe-cd/pipe/pkg/app/api/applicationlivestatestore""
+ 	""github.com/pipe-cd/pipe/pkg/app/api/commandstore""",Should be in the same import group.
+2439,"@@ -119,7 +119,8 @@ class _TLSMsgListField(PacketListField):
+             remain, ret = s[:l], s[l:]
+
+         if remain == b"""":
+-            if pkt.tls_session.tls_version > 0x0200 and pkt.type == 23:
++            if ((pkt.tls_session.tls_version or 0x0303 > 0x0200) and
++                hasattr(pkt, ""type"") and pkt.type == 23):
+                 return ret, [TLSApplicationData(data=b"""")]
+             else:
+                 return ret, [Raw(load=b"""")]",Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below.
+2440,"@@ -45,7 +45,8 @@ import java.nio.file.Path;
+ import static com.github.javaparser.ParseStart.*;
+ import static com.github.javaparser.Problem.PROBLEM_BY_BEGIN_POSITION;
+ import static com.github.javaparser.Providers.*;
+-import static com.github.javaparser.utils.Utils.assertNotNull;
++import static com.github.javaparser.utils.Utils.assertNotNull;import org.apache.log4j.Logger;
++
+
+ /**
+  * Parse Java source code and creates Abstract Syntax Trees.",javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j.
+2441,"@@ -86,6 +86,16 @@ public class FileUtil implements java.io.Serializable  {
+     private static final Logger logger = Logger.getLogger(FileUtil.class.getCanonicalName());
+
+     private static final String[] TABULAR_DATA_FORMAT_SET = {""POR"", ""SAV"", ""DTA"", ""RDA""};
++    // The list of formats for which we need to re-test, if we want to attempt
++    // to ingest the file again:
++    // Example: We have added support for Stata-13+; the new ingest plugin is called
++    // when the file type is detected as ""application/x-stata-1[345]"". But the
++    // previously uploaded, but not ingested stata files are in the database
++    // typed as ""application/x-stata"". So we want to run the new-and-improved
++    // DTA check that will re-identify the specific DTA flavor.
++    // If similar cases are introduced in the future, the affected formats will
++    // need to be added to the list.
++    private static final String[] TABULAR_DATA_FORMATS_RETEST = {""DTA""};
+
+     private static Map<String, String> STATISTICAL_FILE_EXTENSION = new HashMap<String, String>();
+    ",Why not just retest all? it's not expensive (I think).
+2442,"@@ -17,8 +17,8 @@
+ package mock_ecr
+
+ import (
+-	ecr0 ""github.com/aws/amazon-ecs-agent/agent/ecr""
+-	ecr ""github.com/aws/amazon-ecs-agent/agent/ecr/model/ecr""
++	ecr ""github.com/aws/amazon-ecs-agent/agent/ecr""
++	ecr0 ""github.com/aws/amazon-ecs-agent/agent/ecr/model/ecr""
+ 	gomock ""github.com/golang/mock/gomock""
+ )
+ ",ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0
+2443,"@@ -112,12 +112,13 @@ module Travis
+                   'cdbs qpdf texinfo libssh2-1-dev devscripts '\
+                   ""#{optional_apt_pkgs}"", retry: true
+
+-                r_filename = ""R-#{r_version}-$(lsb_release -cs).xz""
+-                r_url = ""https://travis-ci.rstudio.org/#{r_filename}""
++                r_filename = ""r-#{r_version}_1_amd64.deb""
++                os_version = ""$(lsb_release -ds | perl -a -e '$F[1] =~ tr/[.]//d; print $F[1]')""
++                r_url = ""https://cdn.rstudio.com/r/ubuntu-#{os_version}/pkgs/#{r_filename}""
+                 sh.cmd ""curl -fLo /tmp/#{r_filename} #{r_url}"", retry: true
+-                sh.cmd ""tar xJf /tmp/#{r_filename} -C ~""
+-                sh.export 'PATH', ""${TRAVIS_HOME}/R-bin/bin:$PATH"", echo: false
+-                sh.export 'LD_LIBRARY_PATH', ""${TRAVIS_HOME}/R-bin/lib:$LD_LIBRARY_PATH"", echo: false
++                sh.cmd ""sudo apt-get install gdebi-core""
++                sh.cmd ""sudo gdebi r-#{r_version}_1_amd64.deb""
++                sh.export 'PATH', ""/opt/R/#{r_version}/bin:$PATH"", echo: false
+                 sh.rm ""/tmp/#{r_filename}""
+
+                 sh.cmd ""sudo mkdir -p /usr/local/lib/R/site-library $R_LIBS_USER""",This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?
+2444,"@@ -54,7 +54,7 @@ namespace OpenTelemetry.Context.Propagation
+                     return SpanContext.Blank;
+                 }
+
+-                var traceparent = traceparentCollection.First();
++                var traceparent = traceparentCollection?.First();
+                 var traceparentParsed = this.TryExtractTraceparent(traceparent, out var traceId, out var spanId, out var traceoptions);
+
+                 if (!traceparentParsed)",I don't understand why this change is in this PR?
+2445,"@@ -1,5 +1,8 @@
+ # frozen_string_literal: true
+ module Blacklight::FacetsHelperBehavior
++  extend Deprecation
++  self.deprecation_horizon = 'blacklight 8.0'
++
+   include Blacklight::Facet
+
+   ##","It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`"
+2446,"@@ -44,8 +44,15 @@ PersonObject.prototype.description = function() {
+ PersonObject.prototype.toString = function() {
+     return this.name;
+ };
+-Object.setPrototypeOf(PersonObject, Realm.Object);
+-Object.setPrototypeOf(PersonObject.prototype, Realm.Object.prototype);
++
++// Object.setPrototypeOf doesn't work on JSC on Android. The code below achieves the same thing.
++//Object.setPrototypeOf(PersonObject, Realm.Object);
++//Object.setPrototypeOf(PersonObject.prototype, Realm.Object.prototype);
++
++PersonObject.__proto__ = Realm.Object.__proto__;
++PersonObject.prototype.__proto__ = Realm.Object.prototype.__proto__;
++
++
+ exports.PersonObject = PersonObject;
+
+ exports.PersonList = {",The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`.
+2447,"@@ -233,6 +233,14 @@ func (m *taskManagerImpl) CreateTasks(request *CreateTasksRequest) (*CreateTasks
+ }
+
+ func (m *taskManagerImpl) GetTasks(request *GetTasksRequest) (*GetTasksResponse, error) {
++	if request.MinTaskID >= request.MaxTaskID {
++		panic(fmt.Sprintf(
++			""taskManagerImpl encountered MinTaskID >= MaxTaskID: %v vs %v"",
++			request.MinTaskID,
++			request.MaxTaskID,
++		))
++	}
++
+ 	internalResp, err := m.taskStore.GetTasks(request)
+ 	if err != nil {
+ 		return nil, err","the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?"
+2448,"@@ -971,7 +971,7 @@ void* ponyint_pool_realloc_size(size_t old_size, size_t new_size, void* p)
+     new_p = pool_alloc_size(new_adj_size);
+   }
+
+-  memcpy(new_p, p, new_size);
++  memcpy(new_p, p, old_size);
+
+   if(old_index < POOL_COUNT)
+     ponyint_pool_free(old_index, p);","Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?"
+2449,"@@ -109,6 +109,7 @@ namespace pwiz.Skyline.ToolsUI
+                 return OverwriteOrInParallel(_parent, toolCollectionName, toolCollectionVersion, reportList, foundVersion, newCollectionName);
+             }
+
++            // ReSharper disable once MemberHidesStaticFromOuterClass
+             public string InstallProgram(ProgramPathContainer programPathContainer,
+                                          ICollection<ToolPackage> packages,
+                                          string pathToInstallScript)",This is the only one that worries me a bit. It would be good if Brendan signed off on it.
+2450,"@@ -57,6 +57,8 @@ public abstract class OptionalArrayMethodView implements ApiMethodView {
+
+   public abstract boolean isLongrunningOperation();
+
++  public abstract boolean hasLongrunningReturnValue();
++
+   public static Builder newBuilder() {
+     return new AutoValue_OptionalArrayMethodView.Builder();
+   }",`LongRunningOperationDetailView` already has `isEmptyOperation`.
+2451,"@@ -471,6 +471,9 @@ class RemoteConnection(object):
+             request.add_header('Accept', 'application/json')
+             request.add_header('Content-Type', 'application/json;charset=UTF-8')
+
++            base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))
++            request.add_header(""Authorization"", ""Basic %s"" % base64string)
++
+             if password_manager:
+                 opener = url_request.build_opener(url_request.HTTPRedirectHandler(),
+                                                   HttpErrorHandler(),","This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'"
+2452,"@@ -15,12 +15,7 @@ class Theme < ActiveRecord::Base
+
+   validates :title, presence: {message: _(""can't be blank"")}
+
+-  # EVALUATE CLASS AND INSTANCE METHODS BELOW
+-  #
+-  # What do they do? do they do it efficiently, and do we need them?
+-
+-
+-
++  scope :updated_at_desc, -> { self.all.order(updated_at: 'DESC') }
+   ##
+   # returns the title of the theme
+   #","Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works."
+2453,"@@ -10,7 +10,7 @@ module Faker
+         end
+
+         return if digits < 1
+-        return 0 if digits == 1
++        return Base.rand(0..9).round if digits == 1
+
+         # Ensure the first digit is not zero
+         ([non_zero_digit] + generate(digits - 1)).join.to_i","I believe `Base.` is unnecessary in this case, as the class already extends `Base`."
+2454,"@@ -76,12 +76,13 @@ import ServerConnections from '../ServerConnections';
+         return '';
+     }
+
+-    function getImageUrl(item, width) {
++    function getImageUrl(item, size) {
+         const apiClient = ServerConnections.getApiClient(item.ServerId);
+         let itemId;
+
+         const options = {
+-            maxWidth: width,
++            fillWidth: size,
++            fillHeight: size,
+             type: 'Primary'
+         };
+ ",Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?
+2455,"@@ -13,7 +13,8 @@ var reportsInstance = {},
+     localize = require('../../../api/utils/localization.js'),
+     common = require('../../../api/utils/common.js'),
+     log = require('../../../api/utils/log')('reports:reports'),
+-    versionInfo = require('../../../frontend/express/version.info');
++    versionInfo = require('../../../frontend/express/version.info'),
++    offlineMode = plugins.getConfig(""api"").offline_mode;
+
+ versionInfo.page = (!versionInfo.title) ? ""https://count.ly"" : null;
+ versionInfo.title = versionInfo.title || ""Countly"";","Here also, let's not cache value on top of file, but use `plugins.getConfig(""api"").offline_mode` directly where it is needed"
+2456,"@@ -78,10 +78,15 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+
++        $config = $this->getConfig();
++        $shibboleth = isset($config->Catalog->shibboleth_library_cards) &&
++            $config->Catalog->shibboleth_library_cards &&
++            ($this->getAuthManager()->getAuthMethod() == 'Shibboleth');
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'shibboleth' => $shibboleth,
+             ]
+         );
+     }",You can combine the two checks into a single `!empty()` check.
+2457,"@@ -599,6 +599,10 @@ func validateOptions(o *Options) error {
+ 		return fmt.Errorf(""lame duck grace period (%v) should be strictly lower than lame duck duration (%v)"",
+ 			o.LameDuckGracePeriod, o.LameDuckDuration)
+ 	}
++	if int64(o.MaxPayload) > o.MaxPending {
++		return fmt.Errorf(""max_payload (%v) cannot be higher than max_pending (%v)"",
++			o.MaxPayload, o.MaxPending)
++	}
+ 	// Check that the trust configuration is correct.
+ 	if err := validateTrustedOperators(o); err != nil {
+ 		return err",Should we add a warning for anything over say 8M? Just suggesting that is not recommended?
+2458,"@@ -9,11 +9,9 @@ import (
+ 	""sync""
+
+ 	keybase1 ""github.com/keybase/client/go/protocol""
+-
+-	""golang.org/x/net/context""
+ )
+
+-func checkMDPerms(ctx context.Context, codec Codec, kbpki KBPKI,
++func checkMDPerms(codec Codec, currentUID keybase1.UID,
+ 	mergedMasterHead *RootMetadataSigned, checkWrite bool,
+ 	newMd *RootMetadataSigned) (bool, error) {
+ 	if mergedMasterHead == nil {",Looks like there are no callers left of this function.
+2459,"@@ -267,7 +267,7 @@ func logProgress(ctx context.Context, label BuildLabel) {
+ // If the command times out the returned error will be a context.DeadlineExceeded error.
+ // If showOutput is true then output will be printed to stderr as well as returned.
+ // It returns the stdout only, combined stdout and stderr and any error that occurred.
+-func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput bool, argv []string) ([]byte, []byte, error) {
++func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput, attachStdin bool, argv []string) ([]byte, []byte, error) {
+ 	if timeout == 0 {
+ 		if defaultTimeout == 0 {
+ 			timeout = 10 * time.Minute",Should there still be a ` bool` trailing `showOutput`?
+2460,"@@ -24,6 +24,7 @@ import (
+ 	""sync""
+
+ 	""github.com/ghodss/yaml""
++	""github.com/pingcap/chaos-mesh/api/v1alpha1""
+
+ 	ctrl ""sigs.k8s.io/controller-runtime""
+ ",Did we can change to v1
+2461,"@@ -43,6 +43,9 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi
+
+ 	try {
+ 		outer: if (oldVNode.type===Fragment || newType===Fragment) {
++			// Passing the ancestorComponent here is needed for catchErrorInComponent to properly traverse upwards through fragments
++			// to find a parent Suspense
++			c = { _ancestorComponent: ancestorComponent };
+ 			diffChildren(parentDom, newVNode, oldVNode, context, isSvg, excessDomChildren, mounts, c, oldDom);
+
+ 			// Mark dom as empty in case `_children` is any empty array. If it isn't",Can you please double check that this won't break anything?
+2462,"@@ -124,6 +124,7 @@ namespace Nethermind.Runner.JsonRpc
+                     string.Empty,
+                     new IpcSocketsHandler(socket),
+                     RpcEndpoint.IPC,
++                    null,
+                     _jsonRpcProcessor,
+                     _jsonRpcService,
+                     _jsonRpcLocalStats,","optionals, shouldn't need to be stated explicitly"
+2463,"@@ -7,13 +7,15 @@ import (
+ // VersionNumber is a version number as int
+ type VersionNumber int
+
+-// gquicVersion0 is the ""base"" for gQUIC versions
+-// e.g. version 39 is gquicVersion + 0x39
+-const gquicVersion0 = 0x51303300
++// gQUIC version range as defined in the wiki: https://github.com/quicwg/base-drafts/wiki/QUIC-Versions
++const (
++	gquicVersion0   = 0x51303030
++	maxGquicVersion = 0x51303439
++)
+
+ // The version numbers, making grepping easier
+ const (
+-	Version37 VersionNumber = gquicVersion0 + 0x37 + iota
++	Version37 VersionNumber = gquicVersion0 + 3*0x100 + 0x7 + iota
+ 	Version38
+ 	Version39
+ 	VersionTLS         VersionNumber = 101",That seems quite low - why not just 0x5130ffff?
+2464,"@@ -76,7 +76,8 @@ class Net(Gen):
+         self.repr=net
+         self.parsed,self.netmask = self._parse_net(net)
+
+-
++    def __str__(self):
++        return self.repr
+
+     def __iter__(self):
+         for d in xrange(*self.parsed[3]):",Why is this needed ?
+2465,"@@ -77,6 +77,14 @@ module Bolt
+         File.exist?(path) ? read_yaml_hash(path, file_name) : {}
+       end
+
++      def first_runs_free
++        Bolt::Config.user_path + '.first_runs_free'
++      end
++
++      def first_run?
++        Bolt::Config.user_path && !File.exist?(first_runs_free)
++      end
++
+       # Accepts a path with either 'plans' or 'tasks' in it and determines
+       # the name of the module
+       def module_name(path)","`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case."
+2466,"@@ -113,6 +113,9 @@ func (a networkAction) String() string {
+ 	if a.t() == ignore || a.t() == disconnect {
+ 		return fmt.Sprintf(""%v: %5v"", a.t().String(), a.Err)
+ 	}
++	if a.Tag == protocol.ProposalPayloadTag {
++		return fmt.Sprintf(""%v: %2v: %5v"", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value())
++	}
+ 	return fmt.Sprintf(""%v: %2v"", a.t().String(), a.Tag)
+ }
+ ",nit: use %s for strings and %v for objects.
+2467,"@@ -8,16 +8,6 @@ class TTemplateParamClass extends TClassString
+      */
+     public $param_name;
+
+-    /**
+-     * @var string
+-     */
+-    public $as;
+-
+-    /**
+-     * @var ?TNamedObject
+-     */
+-    public $as_type;
+-
+     /**
+      * @var string
+      */","Same as before, the properties already exists in parent"
+2468,"@@ -25,11 +25,11 @@ if __name__ == ""__main__"":
+     copy_file(os.path.join(source, ""lib_lightgbm.dll""), os.path.join(windows_folder_path, ""lib_lightgbm.dll""))
+     copy_file(os.path.join(source, ""lightgbm.exe""), os.path.join(windows_folder_path, ""lightgbm.exe""))
+     version = open(os.path.join(current_dir, os.path.pardir, 'VERSION.txt')).read().strip().replace('rc', '-rc')
+-    nuget_str = r""""""<?xml version=""1.0""?>
++    nuget_str = f""""""<?xml version=""1.0""?>
+     <package xmlns=""http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"">
+     <metadata>
+         <id>LightGBM</id>
+-        <version>%s</version>
++        <version>{version, datetime.datetime.now().year}</version>
+         <authors>Guolin Ke</authors>
+         <owners>Guolin Ke</owners>
+         <licenseUrl>https://github.com/microsoft/LightGBM/blob/master/LICENSE</licenseUrl>",This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`.
+2469,"@@ -274,7 +274,7 @@ static int pause_device(sd_bus_message *msg, void *userdata,
+ 		goto error;
+ 	}
+
+-	if (major == DRM_MAJOR) {
++	if (major == DRM_MAJOR && strcmp(type, ""gone"") != 0) {
+ 		assert(session->has_drm);
+ 		session->base.active = false;
+ 		wlr_signal_emit_safe(&session->base.session_signal, session);","Maybe we should only set active = false if `strcmp(type, ""pause"") == 0`?"
+2470,"@@ -37,6 +37,12 @@ module Selenium
+         def bridge_class
+           Bridge
+         end
++
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
+       end # Driver
+     end # Firefox
+   end # WebDriver",Same here. and all others.
+2471,"@@ -18,6 +18,8 @@ import (
+ 	""github.com/keybase/kbfs/libfs""
+ 	""github.com/keybase/kbfs/libfuse""
+ 	""github.com/keybase/kbfs/libkbfs""
++
++	_ ""github.com/songgao/stacktraces/on/SIGUSR2""
+ )
+
+ var runtimeDir = flag.String(""runtime-dir"", os.Getenv(""KEYBASE_RUNTIME_DIR""), ""runtime directory"")","Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`."
+2472,"@@ -113,9 +113,10 @@ RTPSParticipant* RTPSDomain::createParticipant(
+         PParam.builtin.initialPeersList.push_back(local);
+     }
+
+-    GuidPrefix_t guidP(PParam.prefix);
++    // Generate a new GuidPrefix_t
++
++    GuidPrefix_t guidP;
+
+-    if (guidP == c_GuidPrefix_Unknown)
+     {
+         // Make a new participant GuidPrefix_t up
+         int pid = System::GetPID();",I think this blank line may be removed
+2473,"@@ -272,12 +272,17 @@ class BookmarkManager(UrlMarkManager):
+         elif len(parts) == 1:
+             self.marks[parts[0]] = ''
+
+-    def add(self, url, title):
++    def add(self, url, title, toggle=False):
+         """"""Add a new bookmark.
+
++        Return True if the bookmark was added, and False if it was
++        removed (which only happens if toggle is True).
++
+         Args:
+             url: The url to add as bookmark.
+             title: The title for the new bookmark.
++            toggle: remove the bookmark instead of raising an error if it
++                    already exists.
+         """"""
+         if not url.isValid():
+             errstr = urlutils.get_errstring(url)","I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`."
+2474,"@@ -630,6 +630,7 @@ EmmcSwitchBusWidth (
+   UINT8       Index;
+   UINT8       Value;
+   UINT8       CmdSet;
++  UINT32      DevStatus;
+
+   //
+   // Write Byte, the Value field is written into the byte pointed by Index.","@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start"
+2475,"@@ -0,0 +1,10 @@
++class CloudTag
++  TAGS_LIST = YAML.load File.read(""#{Rails.root}/config/tags_list.yml"")
++
++  class << self
++    def list
++      index = TAGS_LIST.length - Time.now.day
++      TAGS_LIST[index].sort { |a, b| a[0] <=> b[0] }
++    end
++  end
++end",How about YAML.load_file()
+2476,"@@ -33,7 +33,9 @@ public class ContainerizationMetricsImpl implements ContainerizationMetrics {
+   private Meter podCompleted, podRequested, podScheduled, initContainerRunning,
+       appContainerStarting, podReady, podInitFailure, podAppFailure;
+   private Meter flowSubmitToExecutor, flowSubmitToContainer;
++  private Meter executionStopped, containerDispatchFail;
+   private Histogram timeToDispatch;
++  private boolean isInitialized = false;
+
+   @Inject
+   public ContainerizationMetricsImpl(MetricsManager metricsManager) {","Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`."
+2477,"@@ -974,6 +974,13 @@ drwrap_exit(void)
+     if (count != 0)
+         return;
+
++    drmgr_unregister_bb_app2app_event(drwrap_event_bb_app2app);
++    drmgr_unregister_bb_instrumentation_event(drwrap_event_bb_analysis);
++    drmgr_unregister_module_unload_event(drwrap_event_module_unload);
++    dr_unregister_delete_event(drwrap_fragment_delete);
++
++    drmgr_unregister_tls_field(tls_idx);
++
+     hashtable_delete(&replace_table);
+     hashtable_delete(&replace_native_table);
+     hashtable_delete(&wrap_table);",Check the return value of the drmgr ones.
+2478,"@@ -345,7 +345,10 @@ class FileUpload extends FormWidgetBase
+     protected function loadAssets()
+     {
+         $this->addCss('css/fileupload.css', 'core');
+-        $this->addJs('js/fileupload.js', 'core');
++        $this->addJs('js/fileupload.js', [
++            'build' => 'core',
++            'data-cfasync'  => 'false'
++        ]);
+     }
+
+     /**",This should be `'cache'`
+2479,"@@ -36,7 +36,7 @@ type RepoWrangler interface {
+ 	// GetOldRepo opens and returns the old repo with read-only access
+ 	GetOldRepo() (*os.File, error)
+ 	// MakeNewRepo creates and returns the new repo dir with read/write permissions
+-	MakeNewRepo() (*os.File, error)
++	MakeNewRepo() error
+ 	// GetOldRepoPath returns the full path of the old repo
+ 	GetOldRepoPath() string
+ 	// GetNewRepoPath returns the full path of the old repo","The name ""old"" might cause confusion here. After installation, the ""old"" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like ""target"" or ""canonical""?"
+2480,"@@ -1744,6 +1744,7 @@ Collection.prototype.aggregate = function(pipeline, options, callback) {
+   options = Object.assign({}, options);
+   // Ensure we have the right read preference inheritance
+   options.readPreference = resolveReadPreference(options, { db: this.s.db, collection: this });
++  command.readPreference = options.readPreference;
+
+   // If explain has been specified add it
+   if (options.explain) {","I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?"
+2481,"@@ -91,8 +91,9 @@ func SpawnIntermediateHashesStage(s *StageState, u Unwinder, tx kv.RwTx, cfg Tri
+ 		if cfg.checkRoot && root != expectedRootHash {
+ 			log.Error(fmt.Sprintf(""[%s] Wrong trie root of block %d: %x, expected (from header): %x. Block hash: %x"", logPrefix, to, root, expectedRootHash, headerHash))
+ 			if to > s.BlockNumber {
+-				log.Warn(""Unwinding due to incorrect root hash"", ""to"", to-1)
+-				u.UnwindTo(to-1, headerHash)
++				unwindTo := (to + s.BlockNumber) / 2 // Binary search for the correct block, biased to the lower numbers
++				log.Warn(""Unwinding due to incorrect root hash"", ""to"", unwindTo)
++				u.UnwindTo(unwindTo, headerHash)
+ 			}
+ 		} else if err = s.Update(tx, to); err != nil {
+ 			return trie.EmptyRoot, err",During genesis sync it can unwind 5M blocks?
+2482,"@@ -852,6 +852,7 @@ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivities() {
+ }
+
+ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivitiesWithZeroDispatch() {
++	s.T().Skip(""Racy - times out ~50% of the time running locally with --race"")
+ 	// Set a short long poll expiration so we don't have to wait too long for 0 throttling cases
+ 	s.matchingEngine.config.LongPollExpirationInterval = dynamicconfig.GetDurationPropertyFnFilteredByTaskQueueInfo(20 * time.Millisecond)
+ 	dispatchLimitFn := func(wc int, tc int64) float64 {",was it caused by the removal of removeTaskQueueManager() from this test?
+2483,"@@ -61,7 +61,7 @@ module Blacklight::CatalogHelperBehavior
+   # @see #page_entries_info
+   # @return [String]
+   def item_page_entry_info
+-    t('blacklight.search.entry_pagination_info.other', :current => number_with_delimiter(search_session[:counter]), :total => number_with_delimiter(search_session[:total]), :count => search_session[:total].to_i).html_safe
++    t('blacklight.search.entry_pagination_info.other', :current => number_with_delimiter(search_session['counter']), :total => number_with_delimiter(search_session['total']), :count => search_session['total'].to_i).html_safe
+   end
+
+   ##","Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but.."
+2484,"@@ -146,6 +146,8 @@ struct PROC_RESOURCES {
+                 atp->needs_shmem = false;
+             }
+         }
++        if (rp->rr_sim_misses_deadline) return false;
++            // Don't schedule if the result is simulated to miss its deadline
+         if (rp->schedule_backoff > gstate.now) return false;
+         if (rp->uses_gpu()) {
+             if (gpu_suspend_reason) return false;","So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one."
+2485,"@@ -10717,6 +10717,11 @@ int LuaScriptInterface::luaItemTypeCreate(lua_State* L)
+ 		id = Item::items.getItemIdByName(getString(L, 2));
+ 	}
+
++	if (id == 0) {
++		lua_pushnil(L);
++		return 1;
++	}
++
+ 	const ItemType& itemType = Item::items[id];
+ 	pushUserdata<const ItemType>(L, &itemType);
+ 	setMetatable(L, -1, ""ItemType"");","You should add the check above this line instead. If string is empty, don't even call the function."
+2486,"@@ -101,6 +101,13 @@ public class DynamoDBCertRecordStoreConnection implements CertRecordStoreConnect
+     }
+
+     private X509CertRecord itemToX509CertRecord(Item item) {
++        boolean clientCert;
++        try {
++            clientCert = item.getBoolean(KEY_CLIENT_CERT);
++        } catch (Exception ex) {
++            LOGGER.warn(""clientCert for item doesn't exist. Will set it to false. Item: {}"", item.toString());
++            clientCert = false;
++        }
+         X509CertRecord certRecord = new X509CertRecord();
+         certRecord.setProvider(item.getString(KEY_PROVIDER));
+         certRecord.setInstanceId(item.getString(KEY_INSTANCE_ID));",If clientCert attribute doesn't exist for some reason I set it to false.
+2487,"@@ -301,7 +301,11 @@ module Travis
+               cmd_opts = {retry: true, assert: false, echo: 'Installing caching utilities'}
+               if casher_branch == 'production'
+                 static_file_location = ""https://#{app_host}/files/#{name}"".output_safe
+-                sh.cmd curl_cmd(flags, location, static_file_location), cmd_opts
++                app_host_flags = flags
++                if Travis::Build.config&.ssl&.verify == false
++                  app_host_flags += ' -k '
++                end
++                sh.cmd curl_cmd(app_host_flags, location, static_file_location), cmd_opts
+                 sh.if ""$? -ne 0"" do
+                   cmd_opts[:echo] = ""Installing caching utilities from the Travis CI server (#{static_file_location}) failed, failing over to using GitHub (#{remote_location})""
+                   sh.cmd curl_cmd(flags, location, remote_location), cmd_opts","Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?"
+2488,"@@ -211,11 +211,11 @@ void Creature::onWalk()
+ 				forceUpdateFollowPath = true;
+ 			}
+ 		} else {
++			stopEventWalk();
++
+ 			if (listWalkDir.empty()) {
+ 				onWalkComplete();
+ 			}
+-
+-			stopEventWalk();
+ 		}
+ 	}
+ ",Walk should actually be completed (`onWalkCompleted`) after the event is stopped.   This also makes it possible for monster to walk by smaller paths.
+2489,"@@ -31,6 +31,17 @@ func NewSimpleJoiner(getter storage.Getter) file.Joiner {
+ }
+
+ func (s *simpleJoiner) Size(ctx context.Context, address swarm.Address) (dataSize int64, err error) {
++	// Handle size based on weather the root chunk is encrypted or not
++	toDecrypt := len(address.Bytes()) == swarm.EncryptedReferenceSize
++
++	var key encryption.Key
++	addrBytes := address.Bytes()
++	if toDecrypt {
++		addrBytes = address.Bytes()[:swarm.HashSize]
++		key = address.Bytes()[swarm.HashSize : swarm.HashSize+encryption.KeyLength]
++	}
++
++	address = swarm.NewAddress(addrBytes)
+ 	// retrieve the root chunk to read the total data length the be retrieved
+ 	rootChunk, err := s.getter.Get(ctx, storage.ModeGetRequest, address)
+ 	if err != nil {",typo in `weather` (should be `whether`)
+2490,"@@ -35,6 +35,7 @@ var (
+ 	sourceOS               = flag.String(""source-os"", """", fmt.Sprintf(""OS version of the source instance to upgrade. Supported values: %v"", strings.Join(upgrader.SupportedSourceOSVersions(), "", "")))
+ 	targetOS               = flag.String(""target-os"", """", fmt.Sprintf(""Version of the OS after upgrade. Supported values: %v"", strings.Join(upgrader.SupportedTargetOSVersions(), "", "")))
+ 	timeout                = flag.String(""timeout"", """", ""Maximum time limit for an upgrade. For example, if the time limit is set to 2h, the upgrade times out after two hours. For more information about time duration formats, see $ gcloud topic datetimes"")
++	useStagingInstallMedia = flag.Bool(""use-staging-install-media"", false, ""Use staging install media. This flag is for testing only. Set to true to upgrade with staging windows install media."")
+ 	scratchBucketGcsPath   = flag.String(""scratch-bucket-gcs-path"", """", ""Scratch GCS bucket. This setting overrides the workflow setting."")
+ 	oauth                  = flag.String(""oauth"", """", ""Path to OAuth .json file. This setting overrides the workflow setting."")
+ 	ce                     = flag.String(""compute-endpoint-override"", """", ""API endpoint. This setting overrides the default API endpoint setting."")","Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image."
+2491,"@@ -351,7 +351,8 @@ static bool ReadAAPairs(
+     return false;
+   }
+   unsigned n = 0;
+-  fscanf(fp, ""%d"", &n);
++  int num_scan = fscanf(fp, ""%d"", &n);
++  RDUNUSED_PARAM(num_scan);
+
+   char buffer[80];
+ ","I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken."
+2492,"@@ -17,7 +17,9 @@ namespace storage {
+
+ TEST(AddEdgesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddEdgesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddEdgesProcessor::instance(kv.get(),","Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?"
+2493,"@@ -0,0 +1,14 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core
++{
++    public class RequestBodyTimeout
++    {
++        public TimeSpan MinimumTime { get; set; }
++        public TimeSpan? MaximumTime { get; set; }
++        public double? MinimumRate { get; set; }
++    }
++}","Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations."
+2494,"@@ -0,0 +1,12 @@
++package testutils
++
++import (
++	""os""
++	""path""
++)
++
++func TestDataFile(name string) string {
++	dir, _ := os.Getwd()
++
++	return path.Join(dir, ""testdata"", name)
++}","Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?"
+2495,"@@ -1823,7 +1823,9 @@ class CSharpGenerator : public BaseGenerator {
+             code += ""[idx"" + NumToString(j++) + ""]"";
+           }
+           code += "";"";
+-          for (size_t i = 0; i < array_only_lengths.size(); ++i) { code += ""}""; }
++          for (size_t i = 0; i < array_only_lengths.size(); ++i) {
++            code += ""}"";
++          }
+         } else {
+           code += ""_o"";
+           for (size_t i = 0; i < array_lengths.size(); ++i) {",This change is due to `clang_format` and is not related to this PR.
+2496,"@@ -359,6 +359,11 @@ block_all_signals_except(kernel_sigset_t *oset, int num_signals,
+         kernel_sigdelset(&set, va_arg(ap, int));
+     }
+     va_end(ap);
++    /* We never block SIGSEGV or SIGBUS: we need them for various safe reads and to
++     * properly report crashes.
++     */
++    kernel_sigdelset(&set, SIGSEGV);
++    kernel_sigdelset(&set, SIGBUS);
+     sigprocmask_syscall(SIG_SETMASK, &set, oset, sizeof(set));
+ }
+ ","Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for."
+2497,"@@ -0,0 +1,13 @@
++package de.danoeh.antennapod.core.storage;
++
++import android.support.annotation.NonNull;
++
++import de.danoeh.antennapod.core.feed.FeedFile;
++
++public interface FeedFileDownloadStatusRequesterInterface {
++    /**
++     * @return {@code true} if the named feedfile is in the downloads list
++     */
++    boolean isDownloadingFile(@NonNull FeedFile item);
++
++}",Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests.
+2498,"@@ -27,6 +27,7 @@ public class ManifestFileBean implements ManifestFile {
+   private String path = null;
+   private Long length = null;
+   private Integer partitionSpecId = null;
++  private Integer content = null;
+   private Long addedSnapshotId = null;
+
+   public String getPath() {",why not just use `ManifestContent` instead of `Integer`?
+2499,"@@ -260,8 +260,16 @@ namespace Nethermind.TxPool
+             }
+
+             Metrics.PendingTransactionsReceived++;
+-
+-            if (!_validator.IsWellFormed(tx, _specProvider.GetSpec()))
++
++            IReleaseSpec releaseSpec = _specProvider.GetSpec();
++            if (tx.Type == TxType.AccessList && !releaseSpec.IsEip2930Enabled)
++            {
++                Metrics.PendingTransactionsDiscarded++;
++                if (_logger.IsTrace) _logger.Trace($""Skipped adding transaction {tx.ToString(""  "")}, wrong transaction type {tx.Type}."");
++                return AddTxResult.Invalid;
++            }
++
++            if (!_validator.IsWellFormed(tx, releaseSpec))
+             {
+                 // It may happen that other nodes send us transactions that were signed for another chain or don't have enough gas.
+                 Metrics.PendingTransactionsDiscarded++;",can we do that in TxValidator?
+2500,"@@ -66,6 +66,7 @@ type OnewayOutbound interface {
+
+ // Outbounds encapsulates outbound types for a service
+ type Outbounds struct {
+-	Unary  UnaryOutbound
+-	Oneway OnewayOutbound
++	ServiceName string
++	Unary       UnaryOutbound
++	Oneway      OnewayOutbound
+ }",We definitely want some detailed and thoughtful docs being added to this type.
+2501,"@@ -467,7 +467,7 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane {
+ 	}
+
+ 	// TODO Integrate XDP and BPF infra.
+-	if !config.BPFEnabled && dp.xdpState == nil {
++	if !config.BPFEnabled && config.XDPEnabled && dp.xdpState == nil {
+ 		xdpState, err := NewXDPState(config.XDPAllowGeneric)
+ 		if err == nil {
+ 			if err := xdpState.WipeXDP(); err != nil {","We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart."
+2502,"@@ -25,6 +25,18 @@ DEFINE_int32(clean_wal_interval_secs, 600, ""inerval to trigger clean expired wal
+ namespace nebula {
+ namespace kvstore {
+
++#define SPACE_EXIST_RETURN_IF_ERROR(...)                                                           \
++    do {                                                                                           \
++        auto s = (__VA_ARGS__);                                                                    \
++        if (!ok(s)) {                                                                              \
++            if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND) {                              \
++                LOG(INFO) << ""Space "" << spaceId << "" does not exist, skip it."";                   \
++                return ResultCode::SUCCEEDED;                                                      \
++            }                                                                                      \
++            return error(s);                                                                       \
++        }                                                                                          \
++    } while (0)                                                                                    \
++
+ NebulaStore::~NebulaStore() {
+     LOG(INFO) << ""Cut off the relationship with meta client"";
+     options_.partMan_.reset();",If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?
+2503,"@@ -17,6 +17,8 @@ class ResLayer(nn.Sequential):
+             Default: None
+         norm_cfg (dict): dictionary to construct and config norm layer.
+             Default: dict(type='BN')
++        reverse (bool): Reverse the order of planes in layer sequence.
++            False for ResNet, True for Houglass. Default: False
+     """"""
+
+     def __init__(self,","It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network."
+2504,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)
+2505,"@@ -273,6 +273,11 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+             ""consider using the list, dict or set constructor. ""
+             ""It is faster and simpler."",
+         ),
++        ""R1722"": (
++            ""Consider using sys.exit()"",
++            ""consider-using-sys-exit"",
++            ""Instead of using exit() or quit(), consider using the sys.exit()."",
++        ),
+     }
+     options = (
+         (","I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that."
+2506,"@@ -315,7 +315,7 @@ func (c *controller) certificateRequiresIssuance(ctx context.Context, log logr.L
+ 	}
+
+ 	// validate the common name is correct
+-	expectedCN := pki.CommonNameForCertificate(crt)
++	expectedCN := crt.Spec.CommonName
+ 	if expectedCN != cert.Subject.CommonName {
+ 		log.Info(""certificate common name is not as expected, re-issuing"")
+ 		return true","If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here."
+2507,"@@ -23,8 +23,15 @@ import pytest
+ from PyQt5.QtCore import Qt
+
+ from qutebrowser.mainwindow import prompt as promptmod
+-from qutebrowser.utils import usertypes
+-
++from qutebrowser.utils import usertypes, objreg
++from qutebrowser.misc import cmdhistory
++
++@pytest.fixture(autouse=True)
++def test_init(fake_save_manager, data_tmpdir, config_stub):
++    cmdhistory.init()
++    yield
++    objreg.delete('command-history')
++    objreg.delete('fprompt-history')
+
+ class TestFileCompletion:
+ ","This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so."
+2508,"@@ -292,6 +292,10 @@ class PySparkTask(SparkSubmitTask):
+         if self.deploy_mode == ""cluster"":
+             return [self.run_pickle]
+
++    @property
++    def pickle_protocol(self):
++        return configuration.get_config().getint(self.spark_version, ""pickle-protocol"", pickle.DEFAULT_PROTOCOL)
++
+     def setup(self, conf):
+         """"""
+         Called by the pyspark_runner with a SparkConf instance that will be used to instantiate the SparkContext",why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`)
+2509,"@@ -31,6 +31,18 @@ func TestDefaultOptions(t *testing.T) {
+ 	}
+ }
+
++func TestOptions_RandomPort(t *testing.T) {
++	opts := &Options{
++		Port: RANDOM_PORT,
++	}
++	processOptions(opts)
++
++	if opts.Port != 0 {
++		t.Fatalf(""Process of options should have resolved random port to ""+
++			""zero.\nexpected: %d\ngot: %d\n"", 0, opts.Port)
++	}
++}
++
+ func TestConfigFile(t *testing.T) {
+ 	golden := &Options{
+ 		Host:        ""apcera.me"",",nit: Think it can be one line..
+2510,"@@ -12,10 +12,7 @@
+  */
+ package org.camunda.bpm.application;
+
+-import java.util.Collections;
+-import java.util.List;
+-import java.util.Map;
+-import java.util.ServiceLoader;
++import java.util.*;
+ import java.util.concurrent.Callable;
+
+ import javax.script.ScriptEngine;",please inline imports
+2511,"@@ -85,8 +85,7 @@ func (p *setnsProcess) start() (err error) {
+ 	if err = p.execSetns(); err != nil {
+ 		return newSystemErrorWithCause(err, ""executing setns process"")
+ 	}
+-	// We can't join cgroups if we're in a rootless container.
+-	if !p.config.Rootless && len(p.cgroupPaths) > 0 {
++	if len(p.cgroupPaths) > 0 {
+ 		if err := cgroups.EnterPid(p.cgroupPaths, p.pid()); err != nil {
+ 			return newSystemErrorWithCausef(err, ""adding pid %d to cgroups"", p.pid())
+ 		}","This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though."
+2512,"@@ -34,6 +34,7 @@ var skip = map[string]string{
+ 	""task_per_line"":               ""join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)"",
+ 	""rowfn_with_import"":           ""imported libraries are not visible in user-defined functions (https://github.com/influxdata/flux/issues/1000)"",
+ 	""string_trim"":                 ""cannot reference a package function from within a row function"",
++	""integral_columns"":            ""aggregates changed to operate on just a single columnm."",
+ }
+
+ var querier = querytest.NewQuerier()",Should we update integral to operate on a single column as well?
+2513,"@@ -91,7 +91,9 @@ static std::atomic<int> num_uvm_allocations(0);
+ }  // namespace
+
+ void DeepCopyCuda(void *dst, const void *src, size_t n) {
+-  KOKKOS_IMPL_CUDA_SAFE_CALL(cudaMemcpy(dst, src, n, cudaMemcpyDefault));
++  cudaStream_t s = cuda_get_deep_copy_stream();
++  KOKKOS_IMPL_CUDA_SAFE_CALL(
++      cudaMemcpyAsync(dst, src, n, cudaMemcpyDefault, s));
+ }
+
+ void DeepCopyAsyncCuda(const Cuda &instance, void *dst, const void *src,",Doesn't belong to this PR
+2514,"@@ -26,7 +26,7 @@ type ECSClient interface {
+ 	// ContainerInstanceARN if successful. Supplying a non-empty container
+ 	// instance ARN allows a container instance to update its registered
+ 	// resources.
+-	RegisterContainerInstance(existingContainerInstanceArn string, attributes []*ecs.Attribute) (string, error)
++	RegisterContainerInstance(existingContainerInstanceArn string, attributes []*ecs.Attribute, registrationToken string) (string, error)
+ 	// SubmitTaskStateChange sends a state change and returns an error
+ 	// indicating if it was submitted
+ 	SubmitTaskStateChange(change TaskStateChange) error","Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc."
+2515,"@@ -68,6 +68,7 @@ public class UserAccount {
+ 	private static final String TAG = ""UserAccount"";
+ 	private static final String FORWARD_SLASH = ""/"";
+ 	private static final String UNDERSCORE = ""_"";
++	private static final String SF_APP_FEATURE_CODE_USER_AUTH = ""UA"";
+
+ 	private String authToken;
+ 	private String refreshToken;",Could we shorten this constant to maybe `FEATURE_USER_AUTH`?
+2516,"@@ -14,6 +14,10 @@ import (
+ 	""golang.org/x/net/context""
+ )
+
++const (
++	numRekeyWorkers = 8
++)
++
+ type rekeyQueueEntry struct {
+ 	id tlf.ID
+ 	ch chan error",Any particular reason for 8? I feel like we could probably handle more...
+2517,"@@ -91,6 +91,13 @@ class CodeSetAdminTest < ActionDispatch::IntegrationTest
+     assert_response :redirect
+   end
+
++  it 'should update retry_count' do
++    login_as admin
++    job = create(:fetch_job, repository: create(:repository))
++    put admin_job_path(job), job: { retry_count: 3 }
++    job.reload.retry_count.must_equal 3
++  end
++
+   it 'should delete job' do
+     login_as admin
+     job = create(:fetch_job, repository: create(:repository))","Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository."
+2518,"@@ -1,7 +1,7 @@
+ <tr class=""m-shared-email_status"">
+   <td colspan=""2"" padding=""10"">
+     <table id=""status-container-detail"" width=""770"" class=""col-md-12"">
+-      <tr class=""status-header-container"">
++      <tr class=""status-header-container cancelled"">
+         <td>
+           <strong>Approval Status</strong>
+         </td>","Should the ""cancelled"" class be added regardless of the proposal's state?"
+2519,"@@ -115,7 +115,6 @@ const validOptions = require('./operations/mongo_client_ops').validOptions;
+  */
+ function MongoClient(url, options) {
+   if (!(this instanceof MongoClient)) return new MongoClient(url, options);
+-
+   // Set up event emitter
+   EventEmitter.call(this);
+ ","nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes."
+2520,"@@ -624,9 +624,15 @@ exports.populate = function populate(path, select, model, match, options, subPop
+
+   var ret = [];
+   var paths = path.split(' ');
++  var models = undefined;
++  if (typeof model === 'string') {
++    models = model.split(' ');
++  }
+   options = exports.clone(options, { retainKeyOrder: true });
+   for (var i = 0; i < paths.length; ++i) {
+-    ret.push(new PopulateOptions(paths[i], select, match, options, model, subPopulate));
++    var _model = model;
++    if (models && i < models.length) _model = models[i];
++    ret.push(new PopulateOptions(paths[i], select, match, options, _model, subPopulate));
+   }
+
+   return ret;",Seems kinda dangerous - what if models length is different from paths length?
+2521,"@@ -412,7 +412,7 @@ func stageSenders(db kv.RwDB, ctx context.Context) error {
+ 	s := stage(sync, tx, nil, stages.Senders)
+ 	log.Info(""Stage"", ""name"", s.ID, ""progress"", s.BlockNumber)
+
+-	cfg := stagedsync.StageSendersCfg(db, chainConfig, tmpdir)
++	cfg := stagedsync.StageSendersCfg(db, chainConfig, tmpdir, prune.Mode{})
+ 	if unwind > 0 {
+ 		u := sync.NewUnwindState(stages.Senders, s.BlockNumber-unwind, s.BlockNumber)
+ 		err = stagedsync.UnwindSendersStage(u, tx, cfg, ctx)",set real one plz (get it from DB).
+2522,"@@ -180,8 +180,9 @@ static fpga_result send_uafu_event_request(fpga_handle handle,
+ 	struct _fpga_handle *_handle = (struct _fpga_handle *)handle;
+ 	struct fpga_port_info port_info  = {.argsz = sizeof(port_info),
+ 						.flags = 0 };
+-	struct fpga_port_uafu_irq_set uafu_irq = {.argsz = sizeof(uafu_irq),
+-						.flags = 0};
++	uint8_t uafu_irq_buf[sizeof(struct fpga_port_uafu_irq_set)+sizeof(int32_t)];
++	struct fpga_port_uafu_irq_set *uafu_irq =
++		(struct fpga_port_uafu_irq_set *) uafu_irq_buf;
+
+ 	if (uafu_operation != FPGA_IRQ_ASSIGN && uafu_operation != FPGA_IRQ_DEASSIGN) {
+ 		FPGA_ERR(""Invalid UAFU operation requested"");",Should this be initialized to zeroes?
+2523,"@@ -419,7 +419,7 @@ public abstract class FacetProcessor<FacetRequestT extends FacetRequest>  {
+       }
+       count = result.size();  // don't really need this if we are skipping, but it's free.
+     } else {
+-      if (q == null) {
++      if (q == null || fcontext.base.size() == 0) {
+         count = fcontext.base.size();
+       } else {
+         count = fcontext.searcher.numDocs(q, fcontext.base);","The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)"
+2524,"@@ -1,16 +1,14 @@
+-
+ package net.runelite.client.plugins.wildernesslocations;
+
++
+ import java.util.Arrays;
+ import java.util.HashMap;
+-import java.util.List;
+ import java.util.Map;
+ import java.util.Objects;
+-import java.util.Set;
+-import java.util.function.Consumer;
+ import javax.inject.Inject;
++
++import lombok.Getter;
+ import net.runelite.api.Client;
+-import net.runelite.api.Player;
+ import net.runelite.api.Varbits;
+ import net.runelite.api.coords.WorldArea;
+ import net.runelite.api.coords.WorldPoint;",re-add the type in the annotation here
+2525,"@@ -226,9 +226,11 @@ func GetLatestVersion() (string, error) {
+ 	//Download the tar from repo
+ 	versionURL := ""curl -k "" + latestReleaseVersionURL
+ 	cmd := exec.Command(""sh"", ""-c"", versionURL)
++	var stderr bytes.Buffer
++	cmd.Stderr = &stderr
+ 	latestReleaseData, err := cmd.Output()
+ 	if err != nil {
+-		return """", err
++		return """", fmt.Errorf(""%v:%v"", err, stderr.String())
+ 	}
+
+ 	latestRelease := &latestReleaseVersion{}",Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?
+2526,"@@ -13,6 +13,11 @@ func ShouldRotateX509(now time.Time, cert *x509.Certificate) bool {
+ 	return shouldRotate(now, cert.NotBefore, cert.NotAfter)
+ }
+
++// X509Expired returns true if the given X509 cert has expired
++func X509Expired(now time.Time, cert *x509.Certificate) bool {
++	return !now.Before(cert.NotAfter)
++}
++
+ // JWTSVIDExpiresSoon determines if the given JWT SVID should be rotated
+ // based on presented current time, the JWT's expiration.
+ // Also returns true if the JWT is already expired.","there's enough ""nots"" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)"
+2527,"@@ -21,7 +21,7 @@ import (
+
+ 	""github.com/ghodss/yaml""
+
+-	""istio.io/fortio/log""
++	""fortio.org/fortio/log""
+ 	""istio.io/tools/isotope/convert/pkg/graph""
+ 	""istio.io/tools/isotope/convert/pkg/graph/size""
+ 	""istio.io/tools/isotope/convert/pkg/graph/svc""",File is not `goimports`-ed (from `goimports`)
+2528,"@@ -73,6 +73,11 @@ class Config(param.ParameterizedFunction):
+        recommended that users switch this on to update any uses of
+        __call__ as it will be deprecated in future."""""")
+
++    rtol = param.Number(default=10e-6, doc=""""""
++      The tolerance used to enforce regular sampling for gridded data
++      where regular sampling is expected. Expressed as the maximal
++      allowable sampling difference between sample locations."""""")
++
+     def __call__(self, **params):
+         self.set_param(**params)
+         return self",The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses).
+2529,"@@ -80,7 +80,7 @@ public class PreferencesTest {
+         }
+         clickPreference(R.string.user_interface_label);
+         clickPreference(R.string.pref_set_theme_title);
+-        onView(withText(otherTheme)).perform(click());
++        clickPreference(otherTheme);
+         Awaitility.await().atMost(1000, MILLISECONDS)
+                 .until(() -> UserPreferences.getTheme() != theme);
+     }",Be careful. This is not a preference but an option in a dialog.
+2530,"@@ -30,8 +30,11 @@ func (s *svc) DescribeDeployment(ctx context.Context, clientset, cluster, namesp
+ }
+
+ func ProtoForDeployment(cluster string, deployment *appsv1.Deployment) *k8sapiv1.Deployment {
++	if deployment.ClusterName == """" {
++		deployment.ClusterName = cluster
++	}
+ 	return &k8sapiv1.Deployment{
+-		Cluster:     cluster,
++		Cluster:     deployment.ClusterName,
+ 		Namespace:   deployment.Namespace,
+ 		Name:        deployment.Name,
+ 		Labels:      deployment.Labels,","this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty"
+2531,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?
+2532,"@@ -121,8 +121,13 @@ Blockly.BlockSvg.INLINE = -1;
+  */
+ Blockly.BlockSvg.prototype.initSvg = function() {
+   goog.asserts.assert(this.workspace.rendered, 'Workspace is headless.');
++  // ""Input shapes"" for each input. Used to draw ""holes"" for unoccupied value inputs.
++  this.inputShapes_ = {};
+   for (var i = 0, input; input = this.inputList[i]; i++) {
+     input.init();
++    if (input.type === Blockly.INPUT_VALUE) {
++      this.initInputShape(input);
++    }
+   }
+   var icons = this.getIcons();
+   for (i = 0; i < icons.length; i++) {",You're using scare quotes on these terms instead of defining them.
+2533,"@@ -13,6 +13,9 @@ var DdevVersion = ""v0.3.0-dev"" // Note that this is overridden by make
+ // for examples defining version constraints.
+ var DockerVersionConstraint = "">= 17.05.0-ce""
+
++// DockerComposeVersionConstraint is the current minimum version of docker-compose required for ddev.
++var DockerComposeVersionConstraint = "">= 1.10.0""
++
+ // WebImg defines the default web image used for applications.
+ var WebImg = ""drud/nginx-php-fpm-local"" // Note that this is overridden by make
+ ","These should both be const, not var right?"
+2534,"@@ -78,9 +78,7 @@ public class SettingsManager {
+
+     public void save() {
+         Settings settings = load();
+-        try {
+-            File file = new File(settingsFileName);
+-            OutputStream outputStream = new FileOutputStream(file);
++        try (OutputStream outputStream = new FileOutputStream(new File(settingsFileName))) {
+             DefaultPropertiesPersister persister = new DefaultPropertiesPersister();
+             persister.store(settings.getProperties(), outputStream, ""Phoenicis User Settings"");
+         } catch (Exception e) {",Can you catch a more specific exception here? Thanks :-)
+2535,"@@ -80,6 +80,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 			r.Log.Error(err, ""failed to recover chaos"")
+ 			return ctrl.Result{Requeue: true}, nil
+ 		}
++		return ctrl.Result{}, nil
+ 	}
+
+ 	// Start failure action","This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it."
+2536,"@@ -11,7 +11,11 @@ from mmcv.runner import get_dist_info
+ from mmdet.core import tensor2imgs
+
+
+-def single_gpu_test(model, data_loader, show=False, out_dir=None):
++def single_gpu_test(model,
++                    data_loader,
++                    show=False,
++                    out_dir=None,
++                    score_thr=0.3):
+     model.eval()
+     results = []
+     dataset = data_loader.dataset","During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better."
+2537,"@@ -1,7 +1,7 @@
+-<header class=""banner"" role=""banner"">
++<header class=""banner"">
+   <div class=""container"">
+     <a class=""brand"" href=""<?= esc_url(home_url('/')); ?>""><?php bloginfo('name'); ?></a>
+-    <nav role=""navigation"">
++    <nav class=""site-nav"">
+       <?php
+       if (has_nav_menu('primary_navigation')) :
+         wp_nav_menu(['theme_location' => 'primary_navigation', 'menu_class' => 'nav']);","can you make this `nav-primary` please? i'd like to roll with this since the `<ul>` class is `nav`, and primary is the name of the navigation menu"
+2538,"@@ -49,7 +49,16 @@ app.factory('CalendarListItem', function($rootScope, $window, Calendar, WebCal,
+ 			},
+ 			publicSharingURL: {
+ 				get: () => {
+-					return $rootScope.root + 'p/' + context.calendar.publicToken;
++					let displayname = context.calendar.displayname
++						.replace(/\s+/g, '-').replace(/[^\w\-]+/g, '')
++						.replace(/\-\-+/g, '-').replace(/^-+/, '')
++						.replace(/-+$/, '');
++
++					if (displayname === '') {
++						return $rootScope.root + 'p/' + context.calendar.publicToken;
++					} else {
++						return $rootScope.root + 'p/' + context.calendar.publicToken + '/' + displayname;
++					}
+ 				}
+ 			},
+ 			publicEmbedURL: {",@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?
+2539,"@@ -292,7 +292,7 @@ HashedCollectionConfig::SwiftObjectAtAddress(
+   if (error.Fail())
+     return nullptr;
+
+-  CompilerType anyObject_type = ast_ctx->FindQualifiedType(""Swift.AnyObject"");
++  CompilerType anyObject_type = ast_ctx->GetAnyObjectType();
+   if (!anyObject_type)
+     return nullptr;
+ ","I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method."
+2540,"@@ -81,7 +81,8 @@ Blockly.FlyoutExtensionCategoryHeader.prototype.createDom = function() {
+   var marginX = 15;
+   var marginY = 10;
+
+-  var statusButtonX = (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale;
++  var statusButtonX = this.workspace_.RTL ? (marginX - this.flyoutWidth_ + statusButtonWidth) :
++      (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale;
+
+   if (this.imageSrc_) {
+     /** @type {SVGElement} */",Why are you dividing by scale in the LTR case but not the RTL case?
+2541,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename
+2542,"@@ -61,8 +61,8 @@ export default function createLegacySettingsWrapper( moduleSlug, moduleComponent
+ 		useEffect( () => {
+ 			removeAllFilters( `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` );
+ 			addFilter(
+-				'googlesitekit.ModuleSettingsDetails-tagmanager',
+-				'googlesitekit.TagManagerModuleSettings',
++				`googlesitekit.ModuleSettingsDetails-${ moduleSlug }`,
++				'googlesitekit.SettingsLegacy',
+ 				fillFilterWithComponent( moduleComponent )
+ 			);
+ 			return () => removeAllFilters( `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` );",I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules
+2543,"@@ -33,12 +33,15 @@ package azkaban;
+ public class Constants {
+
+   // Azkaban Flow Versions
+-  public static final String AZKABAN_FLOW_VERSION_2_0 = ""2.0"";
++  public static final double VERSION_2_0 = 2.0;
+
+   // Flow 2.0 file suffix
+   public static final String PROJECT_FILE_SUFFIX = "".project"";
+   public static final String FLOW_FILE_SUFFIX = "".flow"";
+
++  // Flow 2.0 node type
++  public static final String FLOW_NODE_TYPE = ""flow"";
++
+   // Names and paths of various file names to configure Azkaban
+   public static final String AZKABAN_PROPERTIES_FILE = ""azkaban.properties"";
+   public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";",isn't AZKABAN_FLOW_VERSION_2_0 more explicit?
+2544,"@@ -308,9 +308,7 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
+                 /*case ONEDRIVE:
+                     signInOneDrive();
+                     break;*/
+-
+-                default:
+-                    SnackBarHandler.show(coordinatorLayout, R.string.feature_not_present);
++                default://do nothing
+             }
+         } else {
+             AlertDialog alertDialog = new AlertDialog.Builder(this)",Please don't leave an empty default
+2545,"@@ -15,6 +15,7 @@
+  * See the License for the specific language governing permissions and
+  * limitations under the License.
+  */
++
+ /**
+  * External dependencies
+  */","This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`."
+2546,"@@ -84,7 +84,9 @@ module Travis
+             sh.cmd 'sudo chmod 2777 /usr/local/lib/R /usr/local/lib/R/site-library'
+
+           when 'osx'
+-            sh.cmd 'brew update', retry: true
++            # We want to update, but we don't need the 800+ lines of
++            # output.
++            sh.cmd 'brew update >/dev/null', retry: true
+
+             # Install from latest CRAN binary build for OS X
+             sh.cmd ""wget #{config[:cran]}/bin/macosx/R-latest.pkg "" +",You can also use `echo: false` instead. Either is fine; I'm just pointing it out.
+2547,"@@ -115,12 +115,13 @@ namespace NLog.Layouts
+         /// </summary>
+         protected override void InitializeLayout()
+         {
+-            base.InitializeLayout();
+             if (!WithHeader)
+             {
+                 Header = null;
+             }
+
++            base.InitializeLayout();
++
+             switch (Delimiter)
+             {
+                 case CsvColumnDelimiterMode.Auto:",what's the reason for this moved line?
+2548,"@@ -986,6 +986,10 @@ import 'programStyles';
+                 lines = [];
+             }
+
++            if (overlayText && showTitle) {
++                lines = [item.Name];
++            }
++
+             const addRightTextMargin = isOuterFooter && options.cardLayout && !options.centerText && options.cardFooterAside !== 'none' && layoutManager.mobile;
+
+             html += getCardTextLines(lines, cssClass, !options.overlayText, isOuterFooter, options.cardLayout, addRightTextMargin, options.lines);","I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?"
+2549,"@@ -97,10 +97,10 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+             out int startLineNumber,
+             out int endLineNumber)
+         {
+-            var startPoint = methodDebugDefinition.GetSequencePoints().OrderBy(s => s.StartLine).FirstOrDefault();
++            var startPoint = methodDebugDefinition.GetSequencePoints().OrderBy(s => s.StartLine).FirstOrDefault(s => s.IsHidden == false);
+             startLineNumber = startPoint.StartLine;
+             var endPoint =
+-                methodDebugDefinition.GetSequencePoints().OrderByDescending(s => s.StartLine).FirstOrDefault();
++                methodDebugDefinition.GetSequencePoints().OrderByDescending(s => s.StartLine).FirstOrDefault(s => s.IsHidden == false);
+             endLineNumber = endPoint.StartLine;
+         }
+ ",`s => s.IsHidden == false` What's the purpose of adding this?
+2550,"@@ -45,6 +45,7 @@ const (
+ 	optionNameGatewayMode          = ""gateway-mode""
+ 	optionNameClefSignerEnable     = ""clef-signer-enable""
+ 	optionNameClefSignerEndpoint   = ""clef-signer-endpoint""
++	optionNameClefSignerAddress    = ""clef-signer-address""
+ 	optionNameSwapEndpoint         = ""swap-endpoint""
+ 	optionNameSwapFactoryAddress   = ""swap-factory-address""
+ 	optionNameSwapInitialDeposit   = ""swap-initial-deposit""","I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address"
+2551,"@@ -202,6 +202,7 @@ class TestCase(unittest.TestCase):
+         # ofile.write(mb)
+         # ofile.close()
+
++    #@unittest.skip
+     def test6ChangeBondLength(self):
+         m = Chem.MolFromSmiles('CC')
+         rdDepictor.Compute2DCoords(m)",you can just remove this
+2552,"@@ -297,6 +297,13 @@ func buildUpgradeTask(kind, name, openebsNamespace string) *apis.UpgradeTask {
+ 				PoolName: name,
+ 			},
+ 		}
++	case ""storagePoolClaim"":
++		utaskObj.Name = ""upgrade-cstor-pool-"" + name
++		utaskObj.Spec.ResourceSpec = apis.ResourceSpec{
++			StoragePoolClaim: &apis.StoragePoolClaim{
++				SPCName: name,
++			},
++		}
+ 	case ""cstorVolume"":
+ 		utaskObj.Name = ""upgrade-cstor-volume-"" + name
+ 		utaskObj.Spec.ResourceSpec = apis.ResourceSpec{",I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR.
+2553,"@@ -7,6 +7,10 @@
+   <%= render 'trails' %>
+ </section>
+
++<% if locked_features.any? %>
++  <%= render 'locked_features' %>
++<% end %>
++
+ <% if current_user_has_access_to?(:exercises) %>
+   <p class=""product-headline"">Hone your skills by completing these exercises</p>
+   <%= render 'products/exercises' %>","Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?"
+2554,"@@ -70,7 +70,7 @@ def run(args):
+         sys.exit(usertypes.Exit.ok)
+
+     if args.temp_basedir:
+-        args.basedir = tempfile.mkdtemp()
++        args.basedir = tempfile.mkdtemp(prefix='qutebrowser-prefix-')
+
+     quitter = Quitter(args)
+     objreg.register('quitter', quitter)","As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`"
+2555,"@@ -40,7 +40,8 @@ namespace Nethermind.Db
+
+         public DbOnTheRocks(string basePath, string dbPath, IDbConfig dbConfig, ILogManager logManager = null) // TODO: check column families
+         {
+-            var fullPath = Path.Combine(basePath, dbPath);
++            var directory = PathUtils.GetExecutingDirectory();
++            var fullPath = Path.Combine(directory, basePath, dbPath);
+             var logger = logManager?.GetClassLogger();
+             if (!Directory.Exists(fullPath))
+             {",basepath can be absoluta path and this needs to be supported
+2556,"@@ -280,7 +280,7 @@ void ConfigPanelWidget::updateIconThemeSettings()
+ void ConfigPanelWidget::addPosition(const QString& name, int screen, LXQtPanel::Position position)
+ {
+     if (LXQtPanel::canPlacedOn(screen, position))
+-        ui->comboBox_position->addItem(name, QVariant::fromValue((ScreenPosition){screen, position}));
++        ui->comboBox_position->addItem(name, QVariant::fromValue(ScreenPosition{screen, position}));
+ }
+
+ ",Didn't get to the commit message
+2557,"@@ -0,0 +1,14 @@
++class DesignForDevelopersResourcesController < ApplicationController
++  layout ""d4d_resources""
++
++  def index
++  end
++
++  def show
++    if template_exists?(params[:id], params[:controller])
++      render params[:id]
++    else
++      raise ActiveRecord::RecordNotFound
++    end
++  end
++end",What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does.
+2558,"@@ -527,6 +527,7 @@ void nano::json_handler::account_balance ()
+ 		auto balance (node.balance_pending (account, include_only_confirmed));
+ 		response_l.put (""balance"", balance.first.convert_to<std::string> ());
+ 		response_l.put (""pending"", balance.second.convert_to<std::string> ());
++		response_l.put (""receivable"", balance.second.convert_to<std::string> ());
+ 	}
+ 	response_errors ();
+ }",Is it kept for compatibility?
+2559,"@@ -537,10 +537,16 @@ func (m *StorageMinerNodeConnector) getMinerWorkerAddress(ctx context.Context, t
+ 		return address.Undef, xerrors.Errorf(""failed to get tip state: %w"", err)
+ 	}
+
+-	_, waddr, err := m.stateViewer.StateView(root).MinerControlAddresses(ctx, m.minerAddr)
++	view := m.stateViewer.StateView(root)
++	_, waddr, err := view.MinerControlAddresses(ctx, m.minerAddr)
+ 	if err != nil {
+ 		return address.Undef, xerrors.Errorf(""failed to get miner control addresses: %w"", err)
+ 	}
+
+-	return waddr, nil
++	workerSigner, err := view.AccountSignerAddress(ctx, waddr)
++	if err != nil {
++		return address.Undef, xerrors.Errorf(""failed to lookup signing address for worker address: %s: %w"", waddr.String(), err)
++	}
++
++	return workerSigner, nil
+ }",I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together.
+2560,"@@ -310,6 +310,10 @@ class DBUpgrader {
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS +
+                     "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_SKIP_ENDING + "" INTEGER DEFAULT 0;"");
+         }
++        if (oldVersion < 1090001) { // fixme / todo: fix  version
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS +
++                    "" ADD COLUMN "" + PodDBAdapter.KEY_EPISODE_NOTIFICATION + "" INTEGER DEFAULT 0;"");
++        }
+     }
+
+ }","It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`."
+2561,"@@ -150,7 +150,7 @@ func (task *UpdateTask) execCQLStmts(ver string, stmts []string) error {
+ 		log.Println(rmspaceRegex.ReplaceAllString(stmt, "" ""))
+ 		e := task.db.Exec(stmt)
+ 		if e != nil {
+-			return fmt.Errorf(""error executing CQL statement:%v"", e)
++			return fmt.Errorf(""error executing statement:%v"", e)
+ 		}
+ 	}
+ 	log.Printf(""---- Done ----\n"")",What about method name itself? Do we run this for SQL too?
+2562,"@@ -42,7 +42,7 @@ public class SalesforceHybridTestActivity extends SalesforceDroidGapActivity {
+ 	static String refreshToken = ""5Aep861KIwKdekr90IDidO4EhfJiYo3fzEvTvsEgM9sfDpGX0qFFeQzHG2mZeUH_.XNSBE0Iz38fnWsyYYkUgTz"";
+ 	static String authToken = ""--will-be-set-through-refresh--"";
+ 	static String identityUrl = ""https://test.salesforce.com"";
+-	static String instanceUrl = ""https://cs1.salesforce.com"";
++	static String instanceUrl = ""https://mobilesdk.cs1.my.salesforce.com"";
+ 	static String loginUrl = ""https://test.salesforce.com"";
+ 	static String orgId = ""00DS0000003E98jMAC"";
+ 	static String userId = ""005S0000004s2iyIAA"";",`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`.
+2563,"@@ -200,7 +200,10 @@ adios2_error adios2_variable_name(char *name, size_t *size,
+         const adios2::core::VariableBase *variableBase =
+             reinterpret_cast<const adios2::core::VariableBase *>(variable);
+         *size = variableBase->m_Name.size();
+-        variableBase->m_Name.copy(name, *size);
++        if (name)
++        {
++            variableBase->m_Name.copy(name, *size);
++        }
+         return adios2_error_none;
+     }
+     catch (...)",Let's use `if(name != nullptr)` to remove ambiguity
+2564,"@@ -1027,4 +1027,12 @@ public class SurfaceNamer extends NameFormatterDelegator {
+   public String getReleaseAnnotation(ReleaseLevel releaseLevel) {
+     return getNotImplementedString(""SurfaceNamer.getReleaseAnnotation"");
+   }
++
++  public String getMetadataIdentifier() {
++    return getNotImplementedString(""SurfaceNamer.getMetadataIdentifier"");
++  }
++
++  public String getMetadataName() {
++    return getNotImplementedString(""SurfaceNamer.getMetadataName"");
++  }
+ }","I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`."
+2565,"@@ -37,6 +37,15 @@ import org.apache.logging.log4j.Logger;
+ public class BftValidatorsValidationRule implements AttachedBlockHeaderValidationRule {
+
+   private static final Logger LOGGER = LogManager.getLogger();
++  private final boolean extraDataValidatorsAndVoteMustBeEmpty;
++
++  public BftValidatorsValidationRule() {
++    this(false);
++  }
++
++  public BftValidatorsValidationRule(final boolean extraDataValidatorsAndVoteMustBeEmpty) {
++    this.extraDataValidatorsAndVoteMustBeEmpty = extraDataValidatorsAndVoteMustBeEmpty;
++  }
+
+   @Override
+   public boolean validate(",This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance.
+2566,"@@ -163,6 +163,15 @@ public interface Set<T> extends Traversable<T>, Function1<T, Boolean>, Serializa
+      */
+     Set<T> removeAll(Iterable<? extends T> elements);
+
++    /**
++     * Reverse the order of all given elements in this set, if present.
++     *
++     * @return A new set consisting of the elements in reverse order of this set
++     */
++    default Set<T> reverse() {
++        throw new UnsupportedOperationException(""Operation not supported"");
++    }
++
+     /**
+      * Converts this Vavr {@code Set} to a {@code java.util.Set} while preserving characteristics
+      * like insertion order ({@code LinkedHashSet}) and sort order ({@code SortedSet}).","This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue."
+2567,"@@ -366,6 +366,10 @@ class S3Connection(AWSAuthConnection):
+         if version_id is not None:
+             params['VersionId'] = version_id
+
++        if response_headers is not None:
++            for header, value in response_headers.items():
++                params[header] = value
++
+         http_request = self.build_base_http_request(method, path, auth_path,
+                                                     headers=headers, host=host,
+                                                     params=params)",we can replace `for` with `params.update(response_headers)`
+2568,"@@ -118,13 +118,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Https
+                 return certificate2;
+             }
+
+-#if NETSTANDARD1_3
+-            // conversion X509Certificate to X509Certificate2 not supported
+-            // https://github.com/dotnet/corefx/issues/4510
+             return null;
+-#else
+-            return new X509Certificate2(certificate);
+-#endif
+         }
+
+         private class HttpsAdaptedConnection : IAdaptedConnection",Any chance this is available in .NET Core 2.0 now?
+2569,"@@ -8,16 +8,15 @@ package blocksync
+
+ import (
+ 	""context""
+-	""net""
+
+ 	""github.com/golang/protobuf/proto""
++	peerstore ""github.com/libp2p/go-libp2p-peerstore""
+ 	""go.uber.org/zap""
+
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""
+ 	""github.com/iotexproject/iotex-core/config""
+-	""github.com/iotexproject/iotex-core/p2p/node""
+ 	""github.com/iotexproject/iotex-core/pkg/lifecycle""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/routine""","I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?"
+2570,"@@ -26,8 +26,11 @@
+
+ #define LBANN_INPUT_LAYER_INSTANTIATE
+ #include ""lbann/layers/io/input_layer.hpp""
+-#include ""lbann/utils/profiling.hpp""
++
+ #include ""lbann/callbacks/imcomm.hpp""
++#include ""lbann/execution_contexts/execution_context.hpp""
++#include ""lbann/execution_contexts/sgd_execution_context.hpp""
++#include ""lbann/utils/profiling.hpp""
+ #include ""lbann/utils/serialize.hpp""
+
+ namespace lbann {",Why do we need both includes here?
+2571,"@@ -600,7 +600,7 @@ public class SmartStore  {
+ 	    	List<String> soupNames = new ArrayList<String>();
+ 	        Cursor cursor = null;
+ 			try {
+-				cursor = DBHelper.getInstance(db).query(db, SOUP_NAMES_TABLE, new String[]{SOUP_NAME_COL}, null, null, null);
++				cursor = DBHelper.getInstance(db).query(db, SOUP_NAMES_TABLE, new String[]{SOUP_NAME_COL}, SOUP_NAME_COL, null, null);
+ 	            if (cursor.moveToFirst()) {
+ 	                do {
+ 	                    soupNames.add(cursor.getString(0));",SmartStoreInspectorTest expected results in a certain order
+2572,"@@ -310,6 +310,11 @@ const conduit::Node& data_reader_jag_conduit::get_conduit_node(const conduit::No
+ }
+
+ bool data_reader_jag_conduit::load_conduit_node(const size_t i, const std::string& key, conduit::Node& node) const {
++
++  if (m_io_thread_pool != nullptr && m_using_random_node.count(m_io_thread_pool->get_local_thread_id())) {
++    LBANN_ERROR(""previously retrieved a random conduit node from data_store, so shouldn't be here"");
++  }
++
+   const sample_t& s = m_sample_list[i];
+   const std::string& sample_name = s.second;
+   const std::string path = sample_name + key;",I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`
+2573,"@@ -175,6 +175,9 @@ public class UnusedAssignmentRule extends AbstractJavaRule {
+                 if (isIgnorablePrefixIncrement(entry.rhs)) {
+                     continue;
+                 }
++                if (isUsedLocalVarWithoutInitializer(entry, result.usedVariables)) {
++                    continue;
++                }
+
+                 Set<AssignmentEntry> killers = result.killRecord.get(entry);
+                 final String reason;","I don't think we need to maintain a separate set. The problem here is that the ""assignment"" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix."
+2574,"@@ -209,4 +209,9 @@ public interface TableScan {
+    */
+   boolean isCaseSensitive();
+
++  /**
++   * Returns the target split size for this scan.
++   */
++  long targetSplitSize();
++
+ }","Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic."
+2575,"@@ -1550,7 +1550,8 @@ func (c *client) flushSignal() {
+ func (c *client) traceMsg(msg []byte) {
+ 	maxTrace := c.srv.getOpts().MaxTracedMsgLen
+ 	if maxTrace > 0 && (len(msg)-LEN_CR_LF) > maxTrace {
+-		c.Tracef(""<<- MSG_PAYLOAD: [\""%s...\""]"", msg[:maxTrace])
++		tm := fmt.Sprintf(""%q"", msg[:maxTrace])
++		c.Tracef(""<<- MSG_PAYLOAD: [\""%s...\""]"", tm[1:maxTrace+1])
+ 	} else {
+ 		c.Tracef(""<<- MSG_PAYLOAD: [%q]"", msg[:len(msg)-LEN_CR_LF])
+ 	}",Not sure what is this change doing?
+2576,"@@ -272,8 +272,9 @@ def revoke_user_code_tokens(user):
+         db.session.delete(code)
+     revoke_tokens(user)
+
+-def get_exp(mins=30):
+-    return datetime.utcnow() + timedelta(minutes=mins)
++def get_exp(mins=None):
++    delta = timedelta(minutes=mins) if mins is not None else timedelta(days=90)
++    return datetime.utcnow() + delta
+
+ def issue_token(user, exp=None):
+     uuid = generate_uuid()","this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default."
+2577,"@@ -267,6 +267,11 @@ public final class RememberMeConfigurer<H extends HttpSecurityBuilder<H>>
+ 		validateInput();
+ 		String key = getKey();
+ 		RememberMeServices rememberMeServices = getRememberMeServices(http, key);
++		if (key == null) {
++			if (rememberMeServices instanceof AbstractRememberMeServices) {
++			    key = ((AbstractRememberMeServices) rememberMeServices).getKey();
++			}
++		}
+ 		http.setSharedObject(RememberMeServices.class, rememberMeServices);
+ 		LogoutConfigurer<H> logoutConfigurer = http.getConfigurer(LogoutConfigurer.class);
+ 		if (logoutConfigurer != null && this.logoutHandler != null) {",Please use a tab for indentation instead of spaces.
+2578,"@@ -40,7 +40,7 @@ import java.util.stream.Collector;
+  * @since 2.0.0
+  */
+ @SuppressWarnings(""deprecation"")
+-public final class Queue<T> extends AbstractsQueue<T, Queue<T>> implements LinearSeq<T>, Kind1<Queue<T>, T> {
++public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements LinearSeq<T>, Kind1<Queue<T>, T> {
+
+     private static final long serialVersionUID = 1L;
+ ",I can't believe we didn't see this typo before :))
+2579,"@@ -25,6 +25,9 @@ from Queue import Empty, Queue
+ from google.cloud.forseti.services.inventory.base import crawler
+ from google.cloud.forseti.services.inventory.base import gcp
+ from google.cloud.forseti.services.inventory.base import resources
++from google.cloud.forseti.common.util import log_util
++
++LOGGER = log_util.get_logger(__name__)
+
+
+ class CrawlerConfig(crawler.CrawlerConfig):","If the logger isn't used, it probably doesn't need to be added."
+2580,"@@ -0,0 +1,4 @@
++var script = document.createElement('script')
++script.type = 'text/javascript'
++script.src = '{}'
++document.head.appendChild(script)",These files should in `/javascript/brython`
+2581,"@@ -54,11 +54,15 @@ func (ci *CreateImages) UnmarshalJSON(b []byte) error {
+
+ func imageUsesAlphaFeatures(imagesAlpha []*ImageAlpha) bool {
+ 	for _, imageAlpha := range imagesAlpha {
+-		if imageAlpha != nil && len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 {
+-			return true
++		if imageAlpha != nil && imageAlpha.RolloutOverride != nil {
++			if len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 {
++				return true
++			}
+ 		}
+-		if imageAlpha != nil && len(imageAlpha.Deprecated.StateOverride.DefaultRolloutTime) > 0 {
+-			return true
++		if imageAlpha != nil && imageAlpha.Deprecated != nil && imageAlpha.Deprecated.StateOverride != nil {
++			if len(imageAlpha.Deprecated.StateOverride.DefaultRolloutTime) > 0 {
++				return true
++			}
+ 		}
+ 	}
+ 	return false","minor, you can squash these into one `if`"
+2582,"@@ -73,7 +73,7 @@ func (s *transmissionTaskSuite) TearDownTest() {
+
+ func (s *transmissionTaskSuite) TestHandleTransmissionTask_RegisterNamespaceTask_IsGlobalNamespace() {
+ 	taskType := replicationgenpb.ReplicationTaskType_NamespaceTask
+-	id := primitives.NewUUID()
++	id := primitives.NewUUID().String()
+ 	name := ""some random namespace test name""
+ 	status := namespacepb.NamespaceStatus_Registered
+ 	description := ""some random test description""","Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`."
+2583,"@@ -581,7 +581,7 @@ namespace pwiz.Skyline.Controls.Graphs
+                     requestContext.Settings = null;
+                 }
+
+-                if (GraphSummary.IsHandleCreated)
++                if (GraphSummary.IsHandleCreated && !GraphSummary.Disposing)
+                 {
+                     try
+                     {",Add a TODO here to revisit if this was problematic.
+2584,"@@ -23,7 +23,11 @@ class SSDHead(AnchorHead):
+         anchor_generator (dict): Config dict for anchor generator
+         bbox_coder (dict): Config of bounding box coder.
+         reg_decoded_bbox (bool): If true, the regression loss would be
+-            applied on decoded bounding boxes. Default: False
++            applied directly on decoded bounding boxes, meaning both the
++            predicted boxes and regression targets are with absolute
++            coordinates format. Default False. Note generally it should be
++            set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`
++            in the bbox head.
+         train_cfg (dict): Training config of anchor head.
+         test_cfg (dict): Testing config of anchor head.
+     """"""  # noqa: W605",Note generally it -> It
+2585,"@@ -51,6 +51,7 @@ model* instantiate_model(lbann_comm* comm,
+   if (type == ""directed_acyclic_graph_model"") {
+     return new directed_acyclic_graph_model(comm, mini_batch_size, obj, opt);
+   }
++#if 0
+   if (type == ""recurrent_model"") {
+     const auto& params = proto_model.recurrent();
+     return new recurrent_model(comm,",Is this relevant to this PR?
+2586,"@@ -102,7 +102,7 @@ module Beaker
+         end
+         if block_hosts.is_a? Array
+           if block_hosts.length > 0
+-            if opts[:run_in_parallel]
++            if opts[:run_in_parallel] == true
+               # Pass caller[1] - the line that called block_on - for logging purposes.
+               result = block_hosts.map.each_in_parallel(caller[1]) do |h|
+                 run_block_on h, &block","Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement."
+2587,"@@ -25,6 +25,11 @@ import (
+ 	""go.opentelemetry.io/otel/codes""
+ )
+
++var (
++	HTTPSchemeHTTP  = HTTPSchemeKey.String(""http"")
++	HTTPSchemeHTTPS = HTTPSchemeKey.String(""https"")
++)
++
+ // NetAttributesFromHTTPRequest generates attributes of the net
+ // namespace as specified by the OpenTelemetry specification for a
+ // span.  The network parameter is a string that net.Dial function",Is this just moved out of the other files? It doesn't seem like this was generated like the other files.
+2588,"@@ -0,0 +1,14 @@
++using System.IO;
++using System.Threading.Tasks;
++
++namespace HttpOverStream
++{
++    internal interface IHttpContent
++    {
++        long? Length { get; }
++
++        void CopyTo(Stream destination);
++
++        Task CopyToAsync(Stream destination);
++    }
++}","I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions."
+2589,"@@ -98,7 +98,9 @@ namespace Nethermind.Mev.Test
+             protected override IBlockProducer CreateTestBlockProducer(TxPoolTxSource txPoolTxSource, ISealer sealer, ITransactionComparerProvider transactionComparerProvider)
+             {
+                 MiningConfig miningConfig = new() {MinGasPrice = UInt256.One};
+-
++
++                MevBlockProducerTransactionsExecutorFactory mevExecutorFactory = new(SpecProvider, LogManager);
++
+                 BlockProducerEnvFactory blockProducerEnvFactory = new(
+                     DbProvider,
+                     BlockTree, ",this looks already too complicated...
+2590,"@@ -176,6 +176,18 @@ TEST(RocksEngineTest, OptionTest) {
+             engine->setDBOption(""max_background_compactions"", ""bad_value""));
+ }
+
++TEST(RocksEngineTest, CompactTest) {
++    fs::TempDir rootPath(""/tmp/rocksdb_compact_test.XXXXXX"");
++    auto engine = std::make_unique<RocksEngine>(0, rootPath.path());
++    std::vector<KV> data;
++    for (int32_t i = 2; i < 8;  i++) {
++        data.emplace_back(folly::stringPrintf(""key_%d"", i),
++                          folly::stringPrintf(""value_%d"", i));
++    }
++    EXPECT_EQ(ResultCode::SUCCEEDED, engine->multiPut(std::move(data)));
++    EXPECT_EQ(ResultCode::SUCCEEDED, engine->compactAll());
++}
++
+ }  // namespace kvstore
+ }  // namespace nebula
+ ","As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future."
+2591,"@@ -85,7 +85,9 @@ public class Catalog implements AutoCloseable {
+       if (tableMap == null) {
+         tableMap = loadTables(db);
+       }
+-      return ImmutableList.copyOf(tableMap.values());
++      Collection<TiTableInfo> tables = tableMap.values();
++      tables.removeIf(TiTableInfo::isView);
++      return ImmutableList.copyOf(tables);
+     }
+
+     public TiTableInfo getTable(TiDBInfo db, String tableName) {",should we add a TODO here?
+2592,"@@ -35,14 +35,12 @@ import { Component, render } from '@wordpress/element';
+ import { loadTranslations } from './util';
+ import './components/notifications';
+ import DashboardDetailsApp from './components/dashboard-details/dashboard-details-app';
+-import ErrorHandler from './components/ErrorHandler';
++import Root from './components/root';
+
+ class GoogleSitekitDashboardDetails extends Component {
+ 	render() {
+ 		return (
+-			<ErrorHandler>
+-				<DashboardDetailsApp />
+-			</ErrorHandler>
++			<DashboardDetailsApp />
+ 		);
+ 	}
+ }",This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now.
+2593,"@@ -191,7 +191,7 @@ func (s *nDCTransactionMgrSuite) TestBackfillWorkflow_CurrentWorkflow_Active_Clo
+ 	versionHistory := versionhistory.New([]byte(""branch token""), []*historyspb.VersionHistoryItem{
+ 		{EventId: lastWorkflowTaskStartedEventID, Version: lastWorkflowTaskStartedVersion},
+ 	})
+-	histories := versionhistory.NewVHS(versionHistory)
++	histories := versionhistory.NewVersionHistories(versionHistory)
+
+ 	releaseCalled := false
+ ",NewVHS -> NewVersionHistories this one looks better
+2594,"@@ -36,10 +36,17 @@ module Selenium
+       SOCKET_LOCK_TIMEOUT = 45
+       STOP_TIMEOUT        = 20
+
++      @executable = nil
++      @missing = ''
++
++      class << self
++        attr_accessor :executable, :missing_text
++      end
++
+       attr_accessor :host
+
+       def initialize(executable_path, port, *extra_args)
+-        @executable_path = executable_path
++        @executable_path = binary_path(executable_path)
+         @host            = Platform.localhost
+         @port            = Integer(port)
+         @extra_args      = extra_args",Is this `@missing_text` ?
+2595,"@@ -25,6 +25,7 @@ CONFIG_PATH = BASE_PATH / 'config.yml'
+ OPEN_DATA_URL = ""https://open.quiltdata.com""
+
+ PACKAGE_NAME_FORMAT = r""[\w-]+/[\w-]+$""
++SUBPACKAGE_NAME_FORMAT = r""([\w-]+/[\w-]+)(?:/(.+))?$""
+
+ ## CONFIG_TEMPLATE
+ # Must contain every permitted config key, as well as their default values (which can be 'null'/None).","Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path."
+2596,"@@ -56,9 +56,9 @@ module.exports = class FileCard extends Component {
+       {this.props.fileCardFor &&
+         <div style=""width: 100%; height: 100%;"">
+           <div class=""uppy-DashboardContent-bar"">
+-            <h2 class=""uppy-DashboardContent-title"">Editing <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
+-            <button class=""uppy-DashboardContent-back"" type=""button"" title=""Finish editing file""
+-              onclick={this.handleClick}>Done</button>
++            <h2 class=""uppy-DashboardContent-title"">{this.props.i18n('editing')} <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
++            <button class=""uppy-DashboardContent-back"" type=""button"" title={this.props.i18n('finishEditingFile')}
++              onclick={this.handleClick}>{this.props.i18n('done')}</button>
+           </div>
+           <div class=""uppy-DashboardFileCard-inner"">
+             <div class=""uppy-DashboardFileCard-preview"" style={{ backgroundColor: getFileTypeIcon(file.type).color }}>","we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `<span/>` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho."
+2597,"@@ -254,6 +254,9 @@ fpga_result enum_thermalmgmt_metrics(fpga_metric_vector *vector,
+
+ 	for (i = 0; i < pglob.gl_pathc; i++) {
+
++		if (!pglob.gl_pathv)
++			continue;
++
+ 		char *dir_name = strrchr(pglob.gl_pathv[i], '/');
+
+ 		if (!dir_name)",Probably want break instead of continue.
+2598,"@@ -305,7 +305,7 @@ func testMQTTDefaultOptions() *Options {
+
+ func testMQTTRunServer(t testing.TB, o *Options) *Server {
+ 	t.Helper()
+-	o.NoLog = false
++	o.NoLog = true
+ 	if o.StoreDir == _EMPTY_ {
+ 		o.StoreDir = createDir(t, ""mqtt_js"")
+ 	}",This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?
+2599,"@@ -83,11 +83,11 @@ public final class StringBuilderConstantParameters
+                     .build();
+         }
+         List<ExpressionTree> arguments = result.get();
+-        Stream<String> prefixStream = arguments.stream().findFirst()
++        Stream<String> prefixStream = arguments.stream()
++                .findFirst()
+                 .map(ASTHelpers::getType)
+-                .filter(type ->
+-                        ASTHelpers.isSameType(type, state.getTypeFromString(""java.lang.String""), state))
+-                .map(ignored -> Stream.<String>of())
++                .filter(type -> ASTHelpers.isSameType(type, state.getTypeFromString(""java.lang.String""), state))
++                .map(ignored -> Stream.<String>empty())
+                 .orElseGet(() -> Stream.of(""\""\""""));
+
+         return buildDescription(tree)",does adding a `Stream.<String>empty()` help here?
+2600,"@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
+     {'name': 'cloudsql_acl', 'enabled': False},
+     {'name': 'iam_policy', 'enabled': True}
+ ]}
++
++NONEXISTENT_ENABLED = {'scanners': [
++    {'name': 'bigquery', 'enabled': False},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': False},
++    {'name': 'non_exist_scanner', 'enabled': True}
++]}
++
++ALL_EXIST = {'scanners': [
++    {'name': 'bigquery', 'enabled': True},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': True},
++    {'name': 'iam_policy', 'enabled': True}
++]}","This is not being used anymore, so can be removed."
+2601,"@@ -127,6 +127,17 @@ type PodIPs struct {
+ 	ipStrings []string
+ }
+
++func (p PodIPs) String() string {
++	res := """"
++	if p.ipv4 != nil {
++		res += fmt.Sprintf(""IPv4: %s, "", p.ipv4.String())
++	}
++	if p.ipv6 != nil {
++		res += fmt.Sprintf(""IPv6: %s, "", p.ipv6.String())
++	}
++	return fmt.Sprintf(""%sIP strings: %s"", res, strings.Join(p.ipStrings, "", ""))
++}
++
+ func (p *PodIPs) hasSameIP(p1 *PodIPs) bool {
+ 	if len(p.ipStrings) == 0 && len(p1.ipStrings) == 0 {
+ 		return true",Is it called some where?
+2602,"@@ -20,10 +20,11 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""fmt""
+-	. ""github.com/openebs/maya/pkg/msg/v1alpha1""
++	""reflect""
++
++	_ ""github.com/openebs/maya/pkg/msg/v1alpha1""
+ 	ft ""k8s.io/client-go/third_party/forked/golang/template""
+ 	jp ""k8s.io/client-go/util/jsonpath""
+-	""reflect""
+ )
+
+ type selection struct {",Please remove this extra blank line.
+2603,"@@ -176,7 +176,7 @@ public class CheckUnusedDependenciesTask extends DefaultTask {
+         return ignore.get().contains(BaselineExactDependencies.asString(artifact));
+     }
+
+-    @Input
++    @InputFiles
+     public final Provider<List<Configuration>> getDependenciesConfigurations() {
+         return dependenciesConfigurations;
+     }","this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before."
+2604,"@@ -14,3 +14,13 @@ func TestNewSnapshot(t *testing.T) {
+ 	_, err := restic.NewSnapshot(paths, nil, ""foo"", time.Now())
+ 	rtest.OK(t, err)
+ }
++
++func TestTagList(t *testing.T) {
++	paths := []string{""/home/foobar""}
++	tags := []string{""""}
++
++	sn, _ := restic.NewSnapshot(paths, nil, ""foo"", time.Now())
++
++	r := sn.HasTags(tags)
++	rtest.Assert(t, r, ""Failed to match untagged snapshot"")
++}","Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?"
+2605,"@@ -1,5 +1,8 @@
+ // Copyright (c) Microsoft. All rights reserved.
+
++using System.IO;
++using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads;
++
+ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+ {
+     using System;",nit: please move these inside namespace.
+2606,"@@ -139,6 +139,13 @@ var (
+ 		Value:  metadata.Testnet3Definition.Testnet3HermesURL,
+ 		Hidden: true,
+ 	}
++	// FlagPaymentsDuringSessionDebug sets if we're in debug more for the payments done in a VPN session.
++	FlagPaymentsDuringSessionDebug = cli.BoolFlag{
++		Name:   ""payments.during-session-debug"",
++		Usage:  ""Set debug mode for payments made during a session, it will bypass any price validation and allow absurd prices during sessions"",
++		Value:  false,
++		Hidden: true,
++	}
+ )
+
+ // RegisterFlagsPayments function register payments flags to flag list.",may users try to abuse it?
+2607,"@@ -242,8 +242,9 @@ public class FlatBufferBuilder {
+         int new_buf_size = old_buf_size == 0 ? 1 : old_buf_size << 1;
+         bb.position(0);
+         ByteBuffer nbb = bb_factory.newByteBuffer(new_buf_size);
++        new_buf_size = nbb.capacity(); // TODO - Maybe we get the buffer's `limit()`
+         nbb.position(new_buf_size - old_buf_size);
+-        nbb.put(bb);
++       nbb.put(bb);
+         return nbb;
+     }
+ ",why is this space removed?
+2608,"@@ -1,3 +1,4 @@
++//go:build !windows
+ // +build !windows
+
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.",Can we remove this other line now then?
+2609,"@@ -52,6 +52,7 @@ PERFECT_FILES = [
+     'qutebrowser/misc/checkpyver.py',
+     'qutebrowser/misc/guiprocess.py',
+     'qutebrowser/misc/editor.py',
++    'qutebrowser/misc/cmdhistory.py'
+
+     'qutebrowser/mainwindow/statusbar/keystring.py',
+     'qutebrowser/mainwindow/statusbar/percentage.py',",There's a comma missing here at the end :wink:
+2610,"@@ -19,13 +19,8 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         [Required]
+         public string AccountKey { get; set; }
+
+-        [Required]
+         public ITaskItem[] ItemsToPush { get; set; }
+
+-        public string IndexDirectory { get; set; }
+-
+-        public bool PublishFlatContainer { get; set; }
+-
+         public bool Overwrite { get; set; }
+
+         public override bool Execute()",Why is this not required any longer?
+2611,"@@ -6,11 +6,13 @@ package admin
+
+ import (
+ 	""github.com/Unknwon/com""
++        ""github.com/Unknwon/paginater""
+
+ 	""github.com/gogits/gogs/models""
+ 	""github.com/gogits/gogs/modules/base""
+ 	""github.com/gogits/gogs/modules/log""
+ 	""github.com/gogits/gogs/modules/middleware""
++	""github.com/gogits/gogs/modules/setting""
+ )
+
+ const (",Indentation seems a bit fucked up here. Run `go fmt`.
+2612,"@@ -650,6 +650,9 @@ func (api *Server) GetLogs(
+ 	ctx context.Context,
+ 	in *iotexapi.GetLogsRequest,
+ ) (*iotexapi.GetLogsResponse, error) {
++	if in.GetFilter() == nil {
++		return nil, status.Error(codes.InvalidArgument, ""empty filter"")
++	}
+ 	switch {
+ 	case in.GetByBlock() != nil:
+ 		req := in.GetByBlock()",any chance in == nil? same below
+2613,"@@ -150,15 +150,15 @@ static int create_spawnproc(h2o_configurator_command_t *cmd, yoml_t *node, const
+     }
+
+     /* create socket */
+-    if ((listen_fd = socket(AF_UNIX, SOCK_STREAM, 0)) == -1) {
++    if ((listen_fd = h2o_sysfn(socket, AF_UNIX, SOCK_STREAM, 0)) == -1) {
+         h2o_configurator_errprintf(cmd, node, ""socket(2) failed: %s"", strerror(errno));
+         goto Error;
+     }
+-    if (bind(listen_fd, (void *)sa, sizeof(*sa)) != 0) {
++    if (h2o_sysfn(bind, listen_fd, (void *)sa, sizeof(*sa)) != 0) {
+         h2o_configurator_errprintf(cmd, node, ""bind(2) failed: %s"", strerror(errno));
+         goto Error;
+     }
+-    if (listen(listen_fd, H2O_SOMAXCONN) != 0) {
++    if (h2o_sysfn(listen, listen_fd, H2O_SOMAXCONN) != 0) {
+         h2o_configurator_errprintf(cmd, node, ""listen(2) failed: %s"", strerror(errno));
+         goto Error;
+     }",We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro.
+2614,"@@ -2895,7 +2895,8 @@ struct SemaphoreSubmitState {
+             (pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) {
+             if (unsignaled_semaphores.count(semaphore) ||
+                 (!(signaled_semaphores.count(semaphore)) && !(pSemaphore->signaled) && !core->SemaphoreWasSignaled(semaphore))) {
+-                const auto &vuid = GetQueueSubmitVUID(loc, SubmitError::kSemCannotBeSignalled);
++                auto error = core->device_extensions.vk_khr_timeline_semaphore ? SubmitError::kTimelineCannotBeSignalled : SubmitError::kBinaryCannotBeSignalled;
++                const auto &vuid = GetQueueSubmitVUID(loc, error);
+                 skip |= core->LogError(
+                     objlist, pSemaphore->scope == kSyncScopeInternal ? vuid : kVUID_Core_DrawState_QueueForwardProgress,
+                     ""%s Queue %s is waiting on semaphore (%s) that has no way to be signaled."", loc.Message().c_str(),","the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the ""VK_KHR_timeline_semaphore is enabled *variant* of the ""binary cannot be signaled"" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)"
+2615,"@@ -2541,7 +2541,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         return DataFrame(sdf, self._metadata.copy())
+
+     # TODO: percentiles, include, and exclude should be implemented.
+-    def describe(self) -> 'DataFrame':
++    def describe(self, percentiles=None) -> 'DataFrame':
+         """"""
+         Generate descriptive statistics that summarize the central tendency,
+         dispersion and shape of a dataset's distribution, excluding",Could you add a type hint? `percentiles: Optional[List[float]] = None`
+2616,"@@ -0,0 +1,16 @@
++module Ncr
++  module WorkOrdersHelper
++    def approver_options
++      # @todo should this list be limited by client/something else?
++      # @todo is there a better order? maybe by current_user's use?
++      User.order(:email_address).pluck(:email_address)
++    end
++
++    def building_options
++      custom = Ncr::WorkOrder.where.not(building_number: nil).pluck('DISTINCT building_number')
++      all = custom + Ncr::BUILDING_NUMBERS
++      # @todo is there a better order? maybe by current_user's use?
++      all.uniq.sort
++    end
++  end
++end","Maybe putting ones they've used before first would be good, but this is fine for now."
+2617,"@@ -105,6 +105,9 @@ func newVXLANManager(
+ 		blackHoleProto = dpConfig.DeviceRouteProtocol
+ 	}
+
++	noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
++	bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
++
+ 	brt := routetable.New(
+ 		[]string{routetable.InterfaceNone},
+ 		4,",I don't think we need these. Simpler just to put `routetable.TargetType...` inline below.
+2618,"@@ -43,7 +43,8 @@ class Dispatcher
+     when 'parallel'
+       ParallelDispatcher.new
+     when 'linear'
+-      if cart.ncr?
++      # @todo: dynamic dispatch for selection
++      if cart.proposal.client_data_legacy.client == ""ncr""
+         NcrDispatcher.new
+       else
+         LinearDispatcher.new",Why this instead of the old way?
+2619,"@@ -549,10 +549,14 @@ void Mob::SetInvisible(uint8 state)
+ 	invisible = state;
+ 	SendAppearancePacket(AT_Invis, invisible);
+ 	// Invis and hide breaks charms
+-
+ 	auto formerpet = GetPet();
+-	if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden))
+-		formerpet->BuffFadeByEffect(SE_Charm);
++	if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden || invisible_animals || invisible_undead)) {
++		if (RuleB(Pets, LivelikeBreakCharmOnInvis) || (!RuleB(Pets, LivelikeBreakCharmOnInvis) && IsInvisible(formerpet))) {
++			formerpet->BuffFadeByEffect(SE_Charm);
++		}
++
++		LogRules(""Pets:LivelikeBreakCharmOnInvis for [{}] | Invis [{}] - Hidden [{}] - Shroud of Stealth [{}] - IVA [{}] - IVU [{}]"", GetCleanName(), invisible, hidden, improved_hidden, invisible_animals, invisible_undead);
++	}
+ }
+
+ //check to see if `this` is invisible to `other`","Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)"
+2620,"@@ -964,6 +964,9 @@ func loadPluginConfig(subrepoConfig *core.Configuration, packageState *core.Buil
+ 	contextPackage := &core.Package{SubrepoName: packageState.CurrentSubrepo}
+ 	configValueDefinitions := subrepoConfig.PluginConfig
+ 	for key, definition := range configValueDefinitions {
++		if definition.ConfigKey == """" {
++			definition.ConfigKey = strings.ReplaceAll(key, ""_"", """")
++		}
+ 		fullConfigKey := fmt.Sprintf(""%v.%v"", pluginName, definition.ConfigKey)
+ 		value, ok := extraVals[strings.ToLower(definition.ConfigKey)]
+ 		if !ok {",We don't want to write this back to the definition do we? Probably just want to create a local variable for it.
+2621,"@@ -964,6 +964,7 @@ public class PlaybackService extends MediaBrowserServiceCompat {
+
+         @Override
+         public void onPlaybackEnded(MediaType mediaType, boolean stopPlaying) {
++            PlaybackPreferences.clearCurrentlyPlayingTemporaryPlaybackSpeed();
+             PlaybackService.this.onPlaybackEnded(mediaType, stopPlaying);
+         }
+     };",Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place.
+2622,"@@ -421,6 +421,7 @@ void LXQtTaskButton::activateWithDraggable()
+     // in progress to allow drop it into an app
+     raiseApplication();
+     KWindowSystem::forceActiveWindow(mWindow);
++    xcb_flush(QX11Info::connection());
+ }
+
+ /************************************************",We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?
+2623,"@@ -0,0 +1,8 @@
++using System;
++
++namespace Collections.Core
++{
++    public class Class1
++    {
++    }
++}",This class can be removed?
+2624,"@@ -13,8 +13,10 @@ import (
+ 	""net""
+ 	""strconv""
+
++	""github.com/iotexproject/iotex-core/action/protocol""
++
+ 	""github.com/golang/protobuf/proto""
+-	grpc_prometheus ""github.com/grpc-ecosystem/go-grpc-prometheus""
++	""github.com/grpc-ecosystem/go-grpc-prometheus""
+ 	""github.com/pkg/errors""
+ 	""go.uber.org/zap""
+ 	""google.golang.org/grpc""",File is not `goimports`-ed (from `goimports`)
+2625,"@@ -72,9 +72,7 @@ type Config struct {
+
+ 	// Logger provides a logger for the dispatcher. The default logger is a
+ 	// no-op.
+-	// TODO(shah): Export this when we're ready to deploy a branch in
+-	// demo-yarpc-go.
+-	logger *zap.Logger
++	Logger *zap.Logger
+ }
+
+ // Inbounds contains a list of inbound transports. Each inbound transport","To minimize the possibility of regret, perhaps we name this `ZapLogger`."
+2626,"@@ -40,8 +40,9 @@ IntercomRails.config do |config|
+     user_hash: Proc.new { |current_user| OpenSSL::HMAC.hexdigest(""sha256"",
+                                                                  ENV['INTERCOM_API_SECRET'],
+                                                                  current_user.email) },
+-
+-    :plan => Proc.new { |current_user| current_user.plan_name },
++    plan: :plan_name,
++    has_logged_in_to_forum: :has_logged_in_to_forum?
++    has_active_subscription: :has_active_subscription?
+   }
+
+   # == User -> Company association","This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user."
+2627,"@@ -20,13 +20,11 @@
+ # ----------------------------------------------------------------------
+
+ """"""
+-Template file used by the OPF Experiment Generator to generate the actual
+-description.py file by replacing $XXXXXXXX tokens with desired values.
+-
+-This description.py file was generated by:
+-'~/nupic/eng/lib/python2.6/site-packages/nupic/frameworks/opf/expGenerator/ExpGenerator.py'
++Anomaly hotgym example
+ """"""
+
++from nupic.algorithms.anomaly import Anomaly
++
+ from nupic.frameworks.opf.expdescriptionapi import ExperimentDescriptionAPI
+
+ from nupic.frameworks.opf.expdescriptionhelpers import (","`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes."
+2628,"@@ -42,8 +42,18 @@ testUtils.checkSetup = function (content, options, target) {
+ 		target = options;
+ 		options = {};
+ 	}
++	// Normalize target, allow it to be the inserted node or '#target'
++	target = target || (content instanceof Node ? content : '#target');
+ 	testUtils.fixtureSetup(content);
+-	var node = axe.utils.querySelectorAll(axe._tree[0], target || '#target')[0];
++
++	var node;
++	if (typeof target === 'string') {
++		node = axe.utils.querySelectorAll(axe._tree[0], target)[0];
++	} else if (target instanceof Node) {
++		node = axe.utils.getNodeFromTree(axe._tree[0], target);
++	} else {
++		node = target;
++	}
+ 	return [node.actualNode, options, node];
+ };
+ ",We needed this testutils file after all
+2629,"@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		big.NewInt(10),
+ 	)
+ 	pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
+-	sig, _ := hex.DecodeString(""9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01"")
++	sig, _ := hex.DecodeString(""c05c3ff8c9820038c03881c97f544593619ca4d1617c7c6d695aaf828339da9616877649d70948094a05a86b171320d1aae9afa4432606be3b263f808e11816e00"")
+ 	bd := &action.EnvelopeBuilder{}
+ 	elp := bd.SetAction(tsf0).
+ 		SetDestinationAddress(ta.Addrinfo[""producer""].Bech32()).",line is 161 characters (from `lll`)
+2630,"@@ -19,6 +19,8 @@ import (
+ 	""fmt""
+ 	""time""
+
++	""github.com/chaos-mesh/chaos-mesh/pkg/controllerutils""
++
+ 	dnspb ""github.com/chaos-mesh/k8s_dns_chaos/pb""
+ 	""github.com/go-logr/logr""
+ 	""golang.org/x/sync/errgroup""",Please re-format/groupimport this line. You might need a little manual work.
+2631,"@@ -35,7 +35,11 @@ type DaisyWorker interface {
+ // designed to be run once and discarded. In other words, don't run RunAndReadSerialValue
+ // twice on the same instance.
+ func NewDaisyWorker(wf *daisy.Workflow, env EnvironmentSettings, logger logging.Logger) DaisyWorker {
+-	return &defaultDaisyWorker{wf, env, logger}
++	worker := &defaultDaisyWorker{wf, env, logger}
++	worker.env.ApplyToWorkflow(worker.wf)
++	worker.env.ApplyWorkerCustomizations(worker.wf)
++	daisy_utils.UpdateAllInstanceNoExternalIP(worker.wf, worker.env.NoExternalIP)
++	return worker
+ }
+
+ type defaultDaisyWorker struct {","minor, you can just use `wf` instead of `worker.wf`"
+2632,"@@ -161,11 +161,12 @@ public final class HttpRequestUtilsTest {
+   @Test
+   public void testGetJsonBodyForSingleMapObject() throws IOException, ServletException {
+     final HttpServletRequest httpRequest = Mockito.mock(HttpServletRequest.class);
+-    final String originalString = ""  {\n"" + ""    \""action\"": \""update\"",\n"" + ""    \""table\"": \""ramp\"",\n""
+-        + ""    \""conditions\"" : {\n"" + ""      \""rampId\"" : \""dali\""\n"" + ""    },\n""
+-        + ""    \""values\"": {\n""
+-        + ""      \""rampStage\"": 2,\n"" + ""      \""lastUpdatedTime\"": 1566259437000\n"" + ""    }\n""
+-        + ""  }\n"";
++    final String originalString =
++        ""  {\n"" + ""    \""action\"": \""update\"",\n"" + ""    \""table\"": \""ramp\"",\n""
++            + ""    \""conditions\"" : {\n"" + ""      \""rampId\"" : \""dali\""\n"" + ""    },\n""
++            + ""    \""values\"": {\n""
++            + ""      \""rampStage\"": 2,\n"" + ""      \""lastUpdatedTime\"": 1566259437000\n"" + ""    }\n""
++            + ""  }\n"";
+     final InputStream inputStream = new ByteArrayInputStream(originalString.getBytes(UTF_8));
+     final InputStreamReader inputStreamReader = new InputStreamReader(inputStream, UTF_8);
+     final BufferedReader bufferedReader = new BufferedReader(inputStreamReader);",I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string.
+2633,"@@ -21,6 +21,7 @@ import (
+ 	""text/template""
+
+ 	errors ""github.com/openebs/maya/pkg/errors/v1alpha1""
++	templates ""github.com/openebs/maya/pkg/upgrade/templates""
+ 	appsv1 ""k8s.io/api/apps/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	types ""k8s.io/apimachinery/pkg/types""","could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: """") (from `typecheck`)"
+2634,"@@ -182,7 +182,7 @@ namespace OpenTelemetry.Exporter.Prometheus.Tests
+             // Once a pull model is implemented, we'll not have this issue and we need to add tests
+             // at that time.
+
+-            // If in future, there is a official .NET Prometheus Client library, and OT Exporter
++            // If in future, there is a official .NET Prometheus Client library, and OTel Exporter
+             // choses to take a dependency on it, then none of these concerns arise.
+         }
+     }",a official -> an official
+2635,"@@ -37,7 +37,7 @@ class ProxyListenerKinesis(ProxyListener):
+     def forward_request(self, method, path, data, headers):
+         data, encoding_type = self.decode_content(data or '{}', True)
+         action = headers.get('X-Amz-Target', '').split('.')[-1]
+-        if action == 'RegisterStreamConsumer':
++        if action == 'RegisterStreamConsumer' and config.KINESIS_PROVIDER == 'kinesalite':
+             stream_arn = data.get('StreamARN', '').strip('"" ')
+             cons_arn = data.get('ConsumerARN', '').strip('"" ')
+             cons_name = data.get('ConsumerName', '').strip('"" ')",I only want the proxy request for this to run for kinesalite.
+2636,"@@ -272,7 +272,7 @@ var DatePicker = React.createClass({displayName: 'DatePicker',
+       React.DOM.div(null,
+         DateInput({
+           date: this.props.selected,
+-          dateFormat: this.props.dateFormat,
++          dateFormat: this.props.dateFormat,
+           focus: this.state.focus,
+           onBlur: this.handleBlur,
+           onFocus: this.handleFocus, ",White space boya?
+2637,"@@ -79,6 +79,9 @@ type StackEvent cloudformation.StackEvent
+ // StackDescription represents an existing AWS CloudFormation stack.
+ type StackDescription cloudformation.Stack
+
++// StackSummary represents a summary of an existing AWS CloudFormation stack.
++type StackSummary cloudformation.StackSummary
++
+ // SDK returns the underlying struct from the AWS SDK.
+ func (d *StackDescription) SDK() *cloudformation.Stack {
+ 	raw := cloudformation.Stack(*d)",Maybe ditch these since `StackSummary` is not used anymore.
+2638,"@@ -21,14 +21,15 @@ class BaseSemanticHead(BaseModule, metaclass=ABCMeta):
+                  num_classes,
+                  init_cfg=None,
+                  loss_seg=dict(
+-                     type='CrossEntropyLoss', ignore_index=-1,
++                     type='CrossEntropyLoss',
++                     ignore_index=255,
+                      loss_weight=1.0)):
+         super(BaseSemanticHead, self).__init__(init_cfg)
+         self.loss_seg = build_loss(loss_seg)
+         self.num_classes = num_classes
+
+     @force_fp32(apply_to=('seg_preds', ))
+-    def loss(self, seg_preds, gt_semantic_seg, label_bias=1):
++    def loss(self, seg_preds, gt_semantic_seg):
+         """"""Get the loss of semantic head.
+
+         Args:",suggest to indicate the value range & meaning in docstring
+2639,"@@ -20,7 +20,7 @@ const (
+ 	// calls.
+ 	listenAddress = "":9500""
+ 	// metricsPath is the endpoint of exporter.
+-	metricsPath = ""/metrics""
++	metricsPath = ""/metrics/""
+ 	// controllerAddress is the address where jiva controller listens.
+ 	controllerAddress = ""http://localhost:9501""
+ 	// casType is the type of container attached storage (CAS) from which","not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also"
+2640,"@@ -24,6 +24,10 @@ import (
+ 	""github.com/projectcalico/felix/stringutils""
+ )
+
++func (r *DefaultRuleRenderer) CleanupEndPoint(ifaceName string) {
++	r.epmm.RemoveEndPointMark(ifaceName)
++}
++
+ func (r *DefaultRuleRenderer) WorkloadDispatchChains(
+ 	endpoints map[proto.WorkloadEndpointID]*proto.WorkloadEndpoint,
+ ) []*Chain {",The rule renderer isn't meant to be stateful so probably best to move this out of here
+2641,"@@ -57,6 +57,7 @@ func setupContainerdConfig(ctx context.Context, cfg *config.Node) error {
+ 		DisableCgroup:         disableCgroup,
+ 		IsRunningInUserNS:     isRunningInUserNS,
+ 		PrivateRegistryConfig: privRegistries.Registry(),
++		ExtraRuntimes:         findNvidiaContainerRuntimes(nil),
+ 	}
+
+ 	selEnabled, selConfigured, err := selinuxStatus()","passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?"
+2642,"@@ -3,12 +3,12 @@
+ 'use strict';
+
+ var clone = require('clone');
+-var dot = require('@deque/dot');
++var doT = require('@deque/dot');
+ var templates = require('./templates');
+ var buildManual = require('./build-manual');
+ var entities = new (require('html-entities').AllHtmlEntities)();
+ var packageJSON = require('../package.json');
+-var dotRegex = /\{\{.+?\}\}/g;
++var doTRegex = /\{\{.+?\}\}/g;
+
+ var axeVersion = packageJSON.version.substring(
+   0,",IMO `dot` should be preferred. Remember `aXe`?
+2643,"@@ -59,6 +59,7 @@ namespace AppDomain.Instance
+                 return -10;
+             }
+
++            Console.ReadKey();
+             return 0;
+         }
+     }","Not a huge deal but this will block tests, also, don't they stay open by default now?"
+2644,"@@ -70,7 +70,7 @@ func makeLevels(min logrus.Level) []logrus.Level {
+ }
+
+ func makeTelemetryState(cfg TelemetryConfig, hookFactory hookFactory) (*telemetryState, error) {
+-	history := createLogBuffer(cfg.LogHistoryDepth)
++	history := createLogBuffer(2)
+ 	if cfg.SessionGUID == """" {
+ 		cfg.SessionGUID = uuid.NewV4().String()
+ 	}",Could you make it a local constant for now ?
+2645,"@@ -950,6 +950,10 @@ class UserResource(object):
+                 if has_invalid_value:
+                     raise_invalid(self.request, **error_details)
+
++            if field in ('id', 'collection_id'):
++                if isinstance(value, int):
++                    value = str(value)
++
+             filters.append(Filter(field, value, operator))
+
+         return filters",What is this `collection_id` field here?
+2646,"@@ -698,7 +698,10 @@ class Automaton(six.with_metaclass(Automaton_metaclass)):
+     # Services
+     def debug(self, lvl, msg):
+         if self.debug_level >= lvl:
+-            log_interactive.debug(msg)
++            if conf.interactive:
++                log_interactive.debug(msg)
++            else:
++                print(msg)
+
+     def send(self, pkt):
+         if self.state.state in self.interception_points:",Is there a reason why we don't use logging for this?
+2647,"@@ -0,0 +1,18 @@
++<?php
++
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Core\Infrastructure\Exception;
++
++class DenoralizationException extends NormalizerException
++{
++    public function __construct(string $message, \Throwable $previous = null)
++    {
++        parent::__construct($message, $previous);
++    }
++}",Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around
+2648,"@@ -34,6 +34,7 @@ def test_simple_json_output():
+         (""column"", 0),
+         (""line"", 1),
+         (""message"", ""Line too long (1/2)""),
++        (""message-id"", ""C0301""),
+         (""module"", ""0123""),
+         (""obj"", """"),
+         (""path"", ""0123""),",IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`.
+2649,"@@ -1427,6 +1427,7 @@ int GetSpellStatValue(uint32 spell_id, const char* stat_identifier, uint8 slot)
+ 	else if (id == ""descnum"") { return spells[spell_id].descnum; }
+ 	else if (id == ""effectdescnum"") { return spells[spell_id].effectdescnum; }
+ 	else if (id == ""npc_no_los"") { return spells[spell_id].npc_no_los; }
++	else if (id == ""feedbackable"") { return spells[spell_id].reflectable; }
+ 	else if (id == ""reflectable"") { return spells[spell_id].reflectable; }
+ 	else if (id == ""bonushate"") { return spells[spell_id].bonushate; }
+ 	else if (id == ""endurcost"") { return spells[spell_id].EndurCost; }","Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?"
+2650,"@@ -0,0 +1,11 @@
++class AddUsersAllowedToTeams < ActiveRecord::Migration
++  def up
++    add_column :teams, :max_users, :integer
++
++    change_column_null :teams, :max_users, false, 0
++  end
++
++  def down
++    remove_column :teams, :max_users
++  end
++end",How should we set this for existing teams?
+2651,"@@ -145,6 +145,11 @@ func TestInstallManager(t *testing.T) {
+ 			expectPasswordSecret:          true,
+ 			expectProvisionMetadataUpdate: true,
+ 		},
++		{
++			name:        ""infraID already set on cluster provision"", // fatal error
++			existing:    []runtime.Object{testClusterDeployment(), testClusterProvisionWithInfraIDSet()},
++			expectError: true,
++		},
+ 	}
+ 	for _, test := range tests {
+ 		t.Run(test.name, func(t *testing.T) {","It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog."
+2652,"@@ -23,11 +23,11 @@ import (
+ 	""testing""
+ 	""time""
+
++	""github.com/mysteriumnetwork/go-openvpn/openvpn""
++	""github.com/mysteriumnetwork/go-openvpn/openvpn/middlewares/state""
+ 	""github.com/mysteriumnetwork/node/client/stats""
+ 	""github.com/mysteriumnetwork/node/communication""
+ 	""github.com/mysteriumnetwork/node/identity""
+-	""github.com/mysteriumnetwork/node/openvpn""
+-	""github.com/mysteriumnetwork/node/openvpn/middlewares/state""
+ 	""github.com/mysteriumnetwork/node/server""
+ 	""github.com/mysteriumnetwork/node/service_discovery/dto""
+ 	""github.com/mysteriumnetwork/node/session""",I hate then some internal process specific middleware leaks into connection manager :( todo later.
+2653,"@@ -102,7 +102,14 @@ def setupNupic():
+     name = ""nupic"",
+     version = version,
+     packages = findPackages(repositoryDir),
++    # A lot of this stuff may not be packaged properly, most if it was added in
++    # an effort to get a binary package prepared for nupic.regression testing
++    # on Travis-CI, but it wasn't done the right way. I'll be refactoring a lot
++    # of this for https://github.com/numenta/nupic/issues/408, so this will be
++    # changing soon. -- Matt
+     package_data = {
++      ""nupic.support.configuration_base"": [""nupic-default.xml""],
++      ""nupic.support.__init__"": [""nupic-logging.conf""],
+       ""nupic"": [""README.md"", ""LICENSE.txt"",
+                 ""CMakeLists.txt"", ""*.so"", ""*.dll"", ""*.dylib""],
+       ""nupic.bindings"": [""_*.so"", ""_*.dll""],",Reflects where these files were moved for `pkg_resources`.
+2654,"@@ -1,8 +1,12 @@
+ import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
+ import { translationMacro as t } from 'ember-i18n';
++import Ember from 'ember';
++const { computed } = Ember;
+
+ export default AbstractIndexRoute.extend({
+-  pageTitle: t('admin.textReplacements.pageTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('admin.textReplacements.pageTitle');
++  }),
+   hideNewButton: true,
+
+   model() {",This should be computed('i18n.locale'....
+2655,"@@ -1351,6 +1351,12 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
+ 									// Add a route to felix[1] to be able to reach the nodeport
+ 									_, err = eth20.RunCmd(""ip"", ""route"", ""add"", felixes[1].IP+""/32"", ""via"", ""10.0.0.20"")
+ 									Expect(err).NotTo(HaveOccurred())
++									// This multi-NIC scenario works only if the kernel's RPF check
++									// is not strict so we need to override it for the test and must
++									// be set properly when product is deployed. We reply on
++									// iptables to do require check for us.
++									felixes[1].Exec(""sysctl"", ""-w"", ""net.ipv4.conf.eth0.rp_filter=2"")
++									felixes[1].Exec(""sysctl"", ""-w"", ""net.ipv4.conf.eth20.rp_filter=2"")
+ 								})
+
+ 								By(""setting up routes to .20 net on dest node to trigger RPF check"", func() {",Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?
+2656,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.
+2657,"@@ -36,14 +36,14 @@ type morqaTransport struct {
+ }
+
+ func (transport *morqaTransport) SendEvent(event Event) error {
+-	if metric := mapEventToMetric(event); metric != nil {
+-		return transport.morqaClient.SendMetric(metric)
++	if id, metric := mapEventToMetric(event); metric != nil {
++		return transport.morqaClient.SendMetric(id, metric)
+ 	}
+
+ 	return fmt.Errorf(""event not implemented"")
+ }
+
+-func mapEventToMetric(event Event) *metrics.Event {
++func mapEventToMetric(event Event) (string, *metrics.Event) {
+ 	switch event.EventName {
+ 	case startupEventName:
+ 		return nodeVersionToMetricsEvent(event.Application)",Not sure how useful is unlock event.
+2658,"@@ -31,8 +31,8 @@ import (
+ // This code is copied from memdocstore/codec.go, with some changes:
+ // - special treatment for primitive.Binary
+
+-func encodeDoc(doc driver.Document) (map[string]interface{}, error) {
+-	var e encoder
++func encodeDoc(doc driver.Document, lowercaseFields bool) (map[string]interface{}, error) {
++	e := encoder{lowercaseFields: lowercaseFields}
+ 	if err := doc.Encode(&e); err != nil {
+ 		return nil, err
+ 	}",Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection.
+2659,"@@ -82,11 +82,13 @@ public class HiveIcebergOutputCommitter extends OutputCommitter {
+
+   /**
+    * Collects the generated data files and creates a commit file storing the data file list.
+-   * @param context The job context
++   * @param ctx The task attempt context
+    * @throws IOException Thrown if there is an error writing the commit file
+    */
+   @Override
+-  public void commitTask(TaskAttemptContext context) throws IOException {
++  public void commitTask(TaskAttemptContext ctx) throws IOException {
++    TaskAttemptContext context = TezUtil.enrichContextWithAttemptWrapper(ctx);
++
+     TaskAttemptID attemptID = context.getTaskAttemptID();
+     String fileForCommitLocation = generateFileForCommitLocation(context.getJobConf(),
+         attemptID.getJobID(), attemptID.getTaskID().getId());",What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type.
+2660,"@@ -352,8 +352,14 @@ bool TurnLaneHandler::isSimpleIntersection(const LaneDataVector &lane_data,
+             if (lane_data.back().tag == TurnLaneType::uturn)
+                 return findBestMatchForReverse(lane_data[lane_data.size() - 2].tag, intersection);
+
+-            BOOST_ASSERT(lane_data.front().tag == TurnLaneType::uturn);
+-            return findBestMatchForReverse(lane_data[1].tag, intersection);
++            // TODO(mokob): #2730 have a look please
++            // BOOST_ASSERT(lane_data.front().tag == TurnLaneType::uturn);
++            // return findBestMatchForReverse(lane_data[1].tag, intersection);
++            //
++            if (lane_data.front().tag == TurnLaneType::uturn)
++                return findBestMatchForReverse(lane_data[1].tag, intersection);
++
++            return findBestMatch(data.tag, intersection);
+         }();
+         std::size_t match_index = std::distance(intersection.begin(), best_match);
+         all_simple &= (matched_indices.count(match_index) == 0);","Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me."
+2661,"@@ -21,12 +21,12 @@ namespace Nethermind.Merge.Plugin.Data
+ {
+     public class Result
+     {
+-        public static readonly Result Success = new Result() {Value = true};
+-        public static readonly Result Fail = new Result() {Value = false};
++        public static readonly Result OK = new() {success = true};
++        public static readonly Result Fail = new() {success = false};
+
+-        public static implicit operator Result(bool value) => value ? Success : Fail;
++        public static implicit operator Result(bool value) => value ? OK : Fail;
+
+         [JsonPropertyName(""success"")]
+-        public bool Value { get; init; }
++        public bool success { get; init; }
+     }
+ }","There was a [JsonPropertyName(""success"")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?"
+2662,"@@ -246,7 +246,8 @@ namespace Nethermind.Runner.Ethereum.Steps
+                 case SealEngineType.AuRa:
+                     AbiEncoder abiEncoder = new AbiEncoder();
+                     _context.ValidatorStore = new ValidatorStore(_context.DbProvider.BlockInfosDb);
+-                    IAuRaValidatorProcessor validatorProcessor = new AuRaAdditionalBlockProcessorFactory(_context.StateProvider, abiEncoder, _context.TransactionProcessor, _context.BlockTree, _context.ReceiptStorage, _context.ValidatorStore, _context.LogManager)
++                    ITransactionProcessorFactory readOnlyTransactionProcessorFactory = new ReadOnlyTransactionProcessorFactory(new ReadOnlyDbProvider(_context.DbProvider, false), _context.BlockTree, _context.SpecProvider, _context.LogManager);
++                    IAuRaValidatorProcessor validatorProcessor = new AuRaAdditionalBlockProcessorFactory(_context.StateProvider, abiEncoder, _context.TransactionProcessor, readOnlyTransactionProcessorFactory, _context.BlockTree, _context.ReceiptStorage, _context.ValidatorStore, _context.LogManager)
+                         .CreateValidatorProcessor(_context.ChainSpec.AuRa.Validators);
+
+                     AuRaStepCalculator auRaStepCalculator = new AuRaStepCalculator(_context.ChainSpec.AuRa.StepDuration, _context.Timestamper);    ","we can just use read env here, pretty sure"
+2663,"@@ -91,6 +91,7 @@ class MergeCells extends BasePlugin {
+     this.autofillCalculations = new AutofillCalculations(this);
+     this.selectionCalculations = new SelectionCalculations();
+
++    this.hot.selection.transformation.addLocalHook('afterTransformStart', (...args) => this.onAfterLocalTransformStart(...args));
+     this.addHook('afterInit', (...args) => this.onAfterInit(...args));
+     this.addHook('beforeKeyDown', (...args) => this.onBeforeKeyDown(...args));
+     this.addHook('modifyTransformStart', (...args) => this.onModifyTransformStart(...args));",Could you replace local hook with global hook `afterModifyTransformStart`?
+2664,"@@ -854,3 +854,10 @@ class FileArchive(Archive):
+     def listing(self):
+         ""Return a list of filename entries currently in the archive""
+         return ['.'.join([f,ext]) if ext else f for (f,ext) in self._files.keys()]
++
++    def clear(self):
++        ""Clears the file archive""
++        self._files.clear()
++
++
++","You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs."
+2665,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?
+2666,"@@ -38,7 +38,7 @@ namespace OpenTelemetry.Trace
+         /// <summary>
+         /// Gets or sets attributes known prior to span creation.
+         /// </summary>
+-        public IDictionary<string, object> Attributes { get; set; }
++        public IEnumerable<KeyValuePair<string, object>> Attributes { get; set; }
+
+         /// <summary>
+         /// Gets or sets Links factory. Use it to deserialize list of <see cref=""Link""/> lazily","As far as I can tell, `IDictionary<string, object>` implements `IEnumerable<KeyValuePair,string, object>>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue."
+2667,"@@ -124,7 +124,7 @@ public class DockerOptions {
+       for (int i = 0; i < maxContainerCount; i++) {
+         node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
+       }
+-      LOG.info(String.format(
++      LOG.finest(String.format(
+           ""Mapping %s to docker image %s %d times"",
+           caps,
+           name,",This change prevents a user understanding how their server is configured. Best to leave at `info` level.
+2668,"@@ -32,6 +32,15 @@ import (
+ 	""google.golang.org/grpc/status""
+ )
+
++var (
++	ephemeralDenyList = []string{
++		api.SpecPriorityAlias,
++		api.SpecPriority,
++		api.SpecSticky,
++		api.SpecScale,
++	}
++)
++
+ func (s *OsdCsiServer) NodeGetInfo(
+ 	ctx context.Context,
+ 	req *csi.NodeGetInfoRequest,",I will add the following to the list: - api.SpecScale - api.SpecSticky
+2669,"@@ -58,7 +58,7 @@ bool EprosimaClient::init()
+
+ 	//CREATE RTPSParticipant
+ 	ParticipantAttributes PParam;
+-	PParam.rtps.defaultSendPort = 10042;
++	//PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
+ 	PParam.rtps.builtin.domainId = 80;
+ 	PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
+ 	PParam.rtps.builtin.use_SIMPLE_RTPSParticipantDiscoveryProtocol = true;","As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line"
+2670,"@@ -158,7 +158,6 @@ namespace OpenTelemetry.Resources.Tests
+                 { ""dynamic"", new { } },
+                 { ""array"", new int[1] },
+                 { ""complex"", this },
+-                { ""float"", 0.1f },
+             };
+
+             var resource = new Resource(attributes);","since we are now no longer expecting an input of float to return an empty string, i have removed this test case."
+2671,"@@ -36,6 +36,18 @@ func MakeCounter(metric MetricName) *Counter {
+ 	return c
+ }
+
++func NewCounter(name, desc string) *Counter {
++	c := &Counter{
++		name:          name,
++		description:   desc,
++		values:        make([]*counterValues, 0),
++		labels:        make(map[string]int),
++		valuesIndices: make(map[int]int),
++	}
++	c.Register(nil)
++	return c
++}
++
+ // Register registers the counter with the default/specific registry
+ func (counter *Counter) Register(reg *Registry) {
+ 	if reg == nil {",It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`
+2672,"@@ -24,5 +24,5 @@ using System.Runtime.CompilerServices;
+ #else
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.Jaeger.Tests"")]
+ [assembly: InternalsVisibleTo(""Benchmarks"")]
+-[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2] // Used by Moq.
++[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")] // Used by Moq.
+ #endif",Do you know why do we need this?
+2673,"@@ -7,6 +7,7 @@ using System.Collections.Generic;
+ using System.Linq;
+ using MvvmCross.Platform.Ios.Presenters;
+ using MvvmCross.Platform.Ios.Presenters.Attributes;
++using MvvmCross.iOS.Views;
+ using MvvmCross.ViewModels;
+ using UIKit;
+ ",I guess this using is what causes the build to fail
+2674,"@@ -239,6 +239,7 @@ DECLARE_THREAD_FN(ponyint_asio_backend_dispatch)
+   close(b->wakeup);
+   ponyint_messageq_destroy(&b->q);
+   POOL_FREE(asio_backend_t, b);
++  pony_unregister_thread();
+   return NULL;
+ }
+ ",I like the explicit unregister approach.
+2675,"@@ -25,8 +25,11 @@ namespace OpenTelemetry.Metrics
+         Type:
+             0x10: Sum
+             0x20: Gauge
+-            0x30: Histogram
+-            0x40: Summary (reserved)
++            0x40: Histogram
++            0x50: HistogramWithMinMax (reserved)
++            0x60: ExponentialHistogram (reserved)
++            0x70: ExponentialHistogramWithMinMax (reserved)
++            0x80: Summary (reserved)
+
+         Point kind:
+             0x04: I1 (signed 1-byte integer)","We should able to use 0x30 as summary, and make 0x80 reserved for future."
+2676,"@@ -104,7 +104,7 @@ namespace Datadog.Trace.ClrProfiler
+         {
+             tags = null;
+
+-            if (!tracer.Settings.IsIntegrationEnabled(integrationId) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
++            if (!tracer.Settings.IsIntegrationEnabled(integrationId) || PlatformHelpers.PlatformStrategy.ShouldSkipClientSpan(tracer.ActiveScope) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
+             {
+                 // integration disabled, don't create a scope, skip this trace
+                 return null;",This allows strategic exclusion of http spans.
+2677,"@@ -19,8 +19,10 @@ final class SearchDto
+     private $searchableProperties;
+     /** @var string[]|null */
+     private $appliedFilters;
++    /** @var string[]|null */
++    private $strictTextSearchFields;
+
+-    public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $defaultSort, array $customSort, ?array $appliedFilters)
++    public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $defaultSort, array $customSort, ?array $appliedFilters, ?array $strictTextSearchFields)
+     {
+         $this->request = $request;
+         $this->searchableProperties = $searchableProperties;",why not just `string[]` instead of nullable
+2678,"@@ -150,7 +150,7 @@ func (e *Extractor) listPackages(query ...string) ([]*jsonPackage, error) {
+ 	// TODO(schroederc): support GOPACKAGESDRIVER
+ 	args := append([]string{""list"",
+ 		""-compiler="" + e.BuildContext.Compiler,
+-		""-tags="" + strings.Join(e.BuildContext.BuildTags, "",""),
++		""-tags="" + strings.Join(e.BuildContext.BuildTags, "" ""),
+ 		""-installsuffix="" + e.BuildContext.InstallSuffix,
+ 		""-test"",
+ 		""-deps"",",How does this work? Why isn't each tag after the first picked up as a new arg/flag?
+2679,"@@ -37,5 +37,10 @@ namespace Datadog.Trace
+         /// The id of the container where the traced application is running.
+         /// </summary>
+         public const string ContainerId = ""Datadog-Container-ID"";
++
++        /// <summary>
++        /// The resource id of the site instance in azure app services where the traced application is running.
++        /// </summary>
++        public const string AzureAppServicesResourceId = ""Datadog-AzureAppServices-Resource-ID"";
+     }
+ }",This key is actually yet to be determined. Meeting with the backend team and Garner to discuss.
+2680,"@@ -1298,12 +1298,8 @@ bool CoreChecks::ValidateImageUpdate(VkImageView image_view, VkImageLayout image
+                                      const char *func_name, std::string *error_code, std::string *error_msg) {
+     *error_code = ""VUID-VkWriteDescriptorSet-descriptorType-00326"";
+     auto iv_state = GetImageViewState(image_view);
+-    if (!iv_state) {
+-        std::stringstream error_str;
+-        error_str << ""Invalid VkImageView: "" << report_data->FormatHandle(image_view).c_str();
+-        *error_msg = error_str.str();
+-        return false;
+-    }
++    assert(iv_state);
++
+     // Note that when an imageview is created, we validated that memory is bound so no need to re-check here
+     // Validate that imageLayout is compatible with aspect_mask and image format
+     //  and validate that image usage bits are correct for given usage",Why remove the crash protection? We're just going to get a bug filed on it.
+2681,"@@ -24,6 +24,10 @@ export const HEADERS = {
+   TEXT_PLAIN: 'text/plain',
+   TEXT_HTML: 'text/html',
+   FORWARDED_PROTO: 'X-Forwarded-Proto',
++  XFRAMES_OPTIONS: 'X-Frame-Options',
++  CSP: 'Content-Security-Policy',
++  CTO: 'X-Content-Type-Options',
++  XSS: 'X-XSS-Protection',
+   ETAG: 'ETag',
+   JSON_CHARSET: 'application/json; charset=utf-8',
+   OCTET_STREAM: 'application/octet-stream; charset=utf-8',",Maybe be consistent and name it `FRAME_OPTIONS`.
+2682,"@@ -170,15 +170,6 @@ Blockly.Connection.prototype.connect_ = function(childConnection) {
+       if (!orphanBlock.outputConnection) {
+         throw 'Orphan block does not have an output connection.';
+       }
+-      // Attempt to reattach the orphan at the end of the newly inserted
+-      // block.  Since this block may be a row, walk down to the end
+-      // or to the first (and only) shadow block.
+-      var connection = Blockly.Connection.lastConnectionInRow_(
+-          childBlock, orphanBlock);
+-      if (connection) {
+-        orphanBlock.outputConnection.connect(connection);
+-        orphanBlock = null;
+-      }
+     } else if (parentConnection.type == Blockly.NEXT_STATEMENT) {
+       // Statement connections.
+       // Statement blocks may be inserted into the middle of a stack.","This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all."
+2683,"@@ -72,8 +72,10 @@ class TestStringMethods(testtools.TestCase):
+
+     def test_parse_provisioning_output_failure_00(self):
+         res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_FAILED)
++
+         self.assertFalse(res)
+
+     def test_parse_provisioning_output_success_00(self):
+         res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_SUCCESS)
++
+         self.assertTrue(res)",Could probably move these constants too?
+2684,"@@ -100,9 +100,8 @@ func (cmd *Command) Start() (err error) {
+ 			case <-time.After(1 * time.Minute):
+ 				err := cmd.mysteriumClient.PingProposal(proposal, signer)
+ 				if err != nil {
+-					//TODO failed to refresh proposal. Stop everything?
+ 					log.Error(""Failed to ping proposal"", err)
+-					cmd.Kill()
++					// do not stop server on missing ping to discovery. More on this in MYST-362 and MYST-370
+ 				}
+ 			case <-stopPinger:
+ 				log.Info(""Stopping proposal pinger"")",Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?
+2685,"@@ -26,7 +26,6 @@ import org.apache.solr.common.params.SolrParams;
+ import org.apache.solr.request.SolrQueryRequest;
+ import org.apache.solr.response.transform.DocTransformer;
+ import org.apache.solr.response.transform.TransformerFactory;
+-import org.bouncycastle.util.Strings;
+ import org.junit.After;
+ import org.junit.BeforeClass;
+ import org.junit.Test;",Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split.
+2686,"@@ -193,9 +193,11 @@ class SynthDriver(SynthDriver):
+ 		voices=OrderedDict()
+ 		for v in _espeak.getVoiceList():
+ 			l=v.languages[1:]
++			# #7167: Some languages names require unicode characters EG: Norwegian Bokmål
++			name=v.name.decode(""UTF-8"")
+ 			# #5783: For backwards compatibility, voice identifies should always be lowercase
+ 			identifier=os.path.basename(v.identifier).lower()
+-			voices[identifier]=VoiceInfo(identifier,v.name,l)
++			voices[identifier]=VoiceInfo(identifier,name,l)
+ 		return voices
+
+ 	def _get_voice(self):","nit: I think this would be more readable as ""Some language names contain Unicode characters""."
+2687,"@@ -1,3 +1,9 @@
++#NVDAHelper.py
++#A part of NonVisual Desktop Access (NVDA)
++#Copyright (C) 2017-2018 NV Access Limited, Peter Vagner, Davy Kager
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++
+ import os
+ import sys
+ import _winreg","Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?"
+2688,"@@ -1,7 +1,6 @@
+-import { createElement, createContext } from '../../';
++import { createElement, createContext } from '../../src';
+ import { expect } from 'chai';
+
+-/** @jsx createElement */
+ /* eslint-env browser, mocha */
+
+ describe('createContext', () => {",Oh interesting - does web-test-runner not resolve package.json files?
+2689,"@@ -5,6 +5,7 @@
+       selected={startDate}
+       onChange={date => setStartDate(date)}
+       locale={fi}
++      ariaDayPrefix=""Päivä""
+     />
+   );
+ };","Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly."
+2690,"@@ -21,11 +21,18 @@ export function setComponentProps(component, props, opts, context, mountAll) {
+ 	if ((component.__key = props.key)) delete props.key;
+
+ 	if (!component.base || mountAll) {
+-		if (component.componentWillMount) component.componentWillMount();
++		if (component.componentWillMount) {
++			options.warn(""'componentWillMount' is deprecated"");
++			component.componentWillMount();
++		}
+ 	}
+ 	else if (component.componentWillReceiveProps) {
++		options.warn(""'componentWillReceiveProps' is deprecated"");
+ 		component.componentWillReceiveProps(props, context);
+ 	}
++	if (component.getDerivedStateFromProps) {
++		component.setState(component.getDerivedStateFromProps(props, component.state));
++	}
+
+ 	if (context && context!==component.context) {
+ 		if (!component.prevContext) component.prevContext = component.context;",I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core.
+2691,"@@ -96,6 +96,10 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
+ 	private String lastAlertMessage;
+ 	private JSONArray lastResults;
+
++	// Default queries
++	private String SOUPS_QUERY = String.format(""select %s from %s"", SmartStore.SOUP_NAME_COL, SmartStore.SOUP_ATTRS_TABLE);
++	private String INDICES_QUERY = String.format(""select %s, %s, %s from %s"", SmartStore.SOUP_NAME_COL, SmartStore.PATH_COL, SmartStore.COLUMN_TYPE_COL, SmartStore.SOUP_INDEX_MAP_TABLE);
++
+ 	/**
+ 	 * Create intent to bring up inspector
+ 	 * @param parentActivity","Use `String.format(Locale.US, ...) to avoid the `Lint` warning."
+2692,"@@ -34,9 +34,17 @@ type AppliedToGroup struct {
+
+ // PodReference represents a Pod Reference.
+ type PodReference struct {
+-	// The name of this pod.
++	// The name of this Pod.
+ 	Name string
+-	// The namespace of this pod.
++	// The Namespace of this Pod.
++	Namespace string
++}
++
++// ServiceReference represents reference to a v1.Service.
++type ServiceReference struct {
++	// The name of this Service.
++	Name string
++	// The Namespace of this Service.
+ 	Namespace string
+ }
+ ",nit: ServiceReference represents a reference to a v1.Service.
+2693,"@@ -73,7 +73,7 @@ type GcpChaosSpec struct {
+ 	// The device name of the disk to detach.
+ 	// Needed in disk-loss.
+ 	// +optional
+-	DeviceName *string `json:""deviceName,omitempty""`
++	DeviceName *[]string `json:""deviceName,omitempty""`
+ }
+
+ // GcpChaosStatus represents the status of a GcpChaos","since it changes to the array, how about change the name to `DeviceNames`"
+2694,"@@ -41,6 +41,12 @@ const (
+ 	// top level property
+ 	ConfigTLP TopLevelProperty = ""Config""
+
++	// RuntimeTLP is a top level property supported by CAS template engine
++	//
++	// The policy specific properties are placed with RuntimeTLP as the
++	// top level property
++	RuntimeTLP TopLevelProperty = ""Runtime""
++
+ 	// VolumeTLP is a top level property supported by CAS template engine
+ 	//
+ 	// The properties provided by the caller are placed with VolumeTLP",Can we avoid this. upgrade engine code should take care of this.
+2695,"@@ -36,3 +36,4 @@ ACTIVATE_SALT = 'activate'
+ PASSWORD_RESET_SALT = 'reset'
+ MAX_LINK_AGE = 60 * 60 * 24 # 24 hours
+ CODE_EXP_MINUTES = 10
++TOKEN_EXP_DEFAULT = {'days': 90}",should also be alphabetized or at least grouped and alphabetized within group
+2696,"@@ -287,6 +287,7 @@ def _try_import_backends():
+         assert results.webengine_error is not None
+
+     return results
++    # pylint: enable=unused-variable
+
+
+ def _handle_ssl_support(fatal=False):","No need for this, as pylint already only turns things off for this function and it's needed for the entire function."
+2697,"@@ -29,6 +29,7 @@ const (
+
+ var (
+ 	errUnmarshalBuildOpts = errors.New(""can't unmarshal build field into string or compose-style map"")
++	errUnmarshalCountOpts = errors.New(""can't unmarshal count field into task count or auto scaling config"")
+ )
+
+ var dockerfileDefaultName = ""Dockerfile""","nit: can we remove ""can't"" from the error message?"
+2698,"@@ -114,7 +114,14 @@ func NewCStorVolumeReplicaController(
+ 			q.Operation = common.QOpAdd
+ 			glog.Infof(""cStorVolumeReplica Added event : %v, %v"", cVR.ObjectMeta.Name, string(cVR.ObjectMeta.UID))
+ 			controller.recorder.Event(cVR, corev1.EventTypeNormal, string(common.SuccessSynced), string(common.MessageCreateSynced))
+-			cVR.Status.Phase = apis.CVRStatusPending
++
++			// For New request phase of cVR will be empty
++			if IsEmptyStatus(cVR) {
++				cVR.Status.Phase = apis.CVRStatusPending
++			} else {
++				cVR.Status.Phase = apis.CVRStatusRecreate
++			}
++
+ 			cVR, _ = controller.clientset.OpenebsV1alpha1().CStorVolumeReplicas(cVR.Namespace).Update(cVR)
+ 			controller.enqueueCStorReplica(cVR, q)
+ 		},","instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas"
+2699,"@@ -38,9 +38,10 @@ const (
+ 	DefaultDownloadURL = ""https://download.docker.com""
+ 	DockerPreqReqList  = ""apt-transport-https ca-certificates curl gnupg-agent software-properties-common""
+
+-	KubernetesDownloadURL = ""https://apt.kubernetes.io/""
+-	KubernetesGPGURL      = ""https://packages.cloud.google.com/apt/doc/apt-key.gpg""
+-
++	KubernetesDownloadURL     = ""https://apt.kubernetes.io/""
++	KubernetesGPGURL          = ""https://packages.cloud.google.com/apt/doc/apt-key.gpg""
++	KubernetesBaseurl         = ""https://packages.cloud.google.com/yum/repos/kubernetes-el7-x86_64""
++	KubernetesGpgkey          = ""https://packages.cloud.google.com/yum/doc/yum-key.gpg https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg""
+ 	KubeEdgeDownloadURL       = ""https://github.com/kubeedge/kubeedge/releases/download""
+ 	KubeEdgePath              = ""/etc/kubeedge/""
+ 	KubeEdgeConfPath          = KubeEdgePath + ""kubeedge/edge/conf""","Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used."
+2700,"@@ -11,8 +11,12 @@ var Parser             = imports.Parser || require('./util/BinaryParser');
+ var Step               = imports.Step || require('step');
+ var buffertools        = imports.buffertools || require('buffertools');
+ var error              = imports.error || require('./util/error');
++var networks           = imports.networks || require('./networks');
++var WalletKey          = imports.WalletKey || require('./WalletKey');
++var PrivateKey         = imports.PrivateKey || require('./PrivateKey');
+
+ var COINBASE_OP = Buffer.concat([util.NULL_HASH, new Buffer('FFFFFFFF', 'hex')]);
++var DEFAULT_FEE = 0.0001;
+
+ function TransactionIn(data) {
+   if (""object"" !== typeof data) {","I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR."
+2701,"@@ -17,13 +17,13 @@
+  * </thead>
+  * <tbody>
+  * <tr><td>{@linkplain javaslang.collection.Array}</td><td><small>const</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td></tr>
+- * <tr><td>{@linkplain javaslang.collection.CharSeq}</td><td><small>const</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>linear</small></td></tr>
+- * <tr><td><em>{@linkplain javaslang.collection.Iterator}</em></td><td><small>const</small></td><td><small>const</small></td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td></tr>
++ * <tr><td>{@linkplain javaslang.collection.CharSeq}</td><td><small>const</small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
++ * <tr><td>{@linkplain javaslang.collection.Iterator}</td><td><small>const</small></td><td><small>const</small></td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td></tr>
+  * <tr><td>{@linkplain javaslang.collection.List}</td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>linear</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.Queue}</td><td><small>const</small></td><td><small>const<sup>a</sup></small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>const</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.PriorityQueue}</td><td><small>log</small></td><td><small>log</small></td><td><small>&mdash;</small></td><td><small>&mdash;</small></td><td><small>log</small></td><td><small>log</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.Stream}</td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const<sup>lazy</sup></small></td><td><small>const<sup>lazy</sup></small></td></tr>
+- * <tr><td>{@linkplain javaslang.collection.Vector}</td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
++ * <tr><td>{@linkplain javaslang.collection.Vector}</td><td><small>const</small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
+  * </tbody>
+  * </table>
+  * <br>","oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)"
+2702,"@@ -232,15 +232,12 @@ class ResourceTags extends Gateway
+      *
+      * @return void
+      */
+-    public function destroyLinks($resource, $user, $list = null, $tag = null)
++    public function destroyResourceLinks($resource, $user, $list = null, $tag = null)
+     {
+         $callback = function ($select) use ($resource, $user, $list, $tag) {
+             $select->where->equalTo('user_id', $user);
+             if (null !== $resource) {
+-                if (!is_array($resource)) {
+-                    $resource = [$resource];
+-                }
+-                $select->where->in('resource_id', $resource);
++                $select->where->in('resource_id', (array)$resource);
+             }
+             if (null !== $list) {
+                 if (true === $list) {","Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release."
+2703,"@@ -43,6 +43,7 @@ func init() {
+ 	RegisterGlobalOption(""local_certs"", parseOptTrue)
+ 	RegisterGlobalOption(""key_type"", parseOptSingleString)
+ 	RegisterGlobalOption(""auto_https"", parseOptAutoHTTPS)
++	RegisterGlobalOption(""servers"", parseServerOptions)
+ }
+
+ func parseOptTrue(d *caddyfile.Dispenser) (interface{}, error) {","A reminder that we should discuss whether to rename this to ""sockets"" or ""listeners""."
+2704,"@@ -39,6 +39,7 @@ using eprosima::fastdds::dds::Log;
+
+ using eprosima::fastrtps::rtps::RTPSDomain;
+ using eprosima::fastrtps::rtps::RTPSParticipant;
++using eprosima::fastrtps::rtps::RTPSParticipantAttributes;
+
+ namespace eprosima {
+ namespace fastdds {",Why do you need to include this using declaration?
+2705,"@@ -59,7 +59,7 @@ namespace Microsoft.AspNet.Server.Kestrel.GeneratedCode
+             {
+                 ulong mask = 0;
+                 ulong comp = 0;
+-                for (var scan = 0; scan != count; ++scan)
++                for (var scan = 0; scan < count; scan++)
+                 {
+                     var ch = (byte)name[offset + count - scan - 1];
+                     var isAlpha = (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');",@halter73 where is this file generated from?
+2706,"@@ -19,6 +19,7 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+     [SuppressMessage(""StyleCop.CSharp.LayoutRules"", ""SA1516:Elements must be separated by blank line"", Justification = ""This is an auto-generated file."")]
+     public class PackageVersions
+     {
++#if TRUE
+         public static IEnumerable<object[]> MongoDB =>
+
+             new List<object[]>",What do these `#if TRUE` accomplish?
+2707,"@@ -39,6 +39,11 @@ namespace OpenTelemetry.Instrumentation
+
+         public void OnNext(KeyValuePair<string, object> value)
+         {
++            if (Sdk.SuppressInstrumentation)
++            {
++                return;
++            }
++
+             if (!this.handler.SupportsNullActivity && Activity.Current == null)
+             {
+                 InstrumentationEventSource.Log.NullActivity(value.Key);","Probably a good optimization to have this, but I don't think it's strictly required. For ""legacy"" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?"
+2708,"@@ -1,6 +1,6 @@
+ <%= @activity %>
+
+-<%= t(""mailer.proposal_link_text"",
+-      proposal_url: proposal_url(@proposal)) %>
++<%= t(""mailer.view_request_cta"") %>
++<%= proposal_url(@proposal) %>
+
+ <%= t(""mailer.footer"", feedback_url: feedback_url) %>",@jessieay Intentionally moving away from passing a param?
+2709,"@@ -1378,13 +1378,12 @@ class PAIA extends DAIA
+             $lastname = $nameArr[0];
+         } else {
+             $nameArr = explode(' ', $username);
+-            $firstname = $nameArr[0];
+-            $lastname = '';
+-            array_shift($nameArr);
++            $firstname = '';
++            $lastname = array_pop($nameArr);
+             foreach ($nameArr as $value) {
+-                $lastname .= ' ' . $value;
++                $firstname .= ' ' . $value;
+             }
+-            $lastname = trim($lastname);
++            $firstname = trim($firstname);
+         }
+
+         // TODO: implement parsing of user details according to types set","I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?"
+2710,"@@ -1,5 +1,4 @@
+ #!/usr/bin/env node
+-'use strict'
+
+ const userAgent = process.env.npm_config_user_agent
+ if (!userAgent) {","hmm, we actually should _add_ `'use strict'` everywhere  "
+2711,"@@ -905,7 +905,7 @@ public class JdbcProjectImpl implements ProjectLoader {
+                   propsName);
+
+       if (properties == null || properties.isEmpty()) {
+-        logger.warn(""Project "" + projectId + "" version "" + projectVer + "" property "" + propsName
++        logger.debug(""Project "" + projectId + "" version "" + projectVer + "" property "" + propsName
+             + "" is empty."");
+         return null;
+       }","it's not just fetching override properties here, right?"
+2712,"@@ -200,6 +200,7 @@ func (acsSession *session) Start() error {
+ 			if shouldReconnectWithoutBackoff(acsError) {
+ 				// If ACS closed the connection, there's no need to backoff,
+ 				// reconnect immediately
++				seelog.Info(""ACS Websocket connection closed for a valid reason"")
+ 				acsSession.backoff.Reset()
+ 				sendEmptyMessageOnChannel(connectToACS)
+ 			} else {",Is it worth logging the error?
+2713,"@@ -16,6 +16,19 @@ import watchdog.events
+ from watchdog.observers import polling
+
+
++class NS:
++    def __init__(self, ns):
++        self.__dict__[""ns""] = ns
++
++    def __getattr__(self, key):
++        if key not in self.ns:
++            raise AttributeError(""No such element: %s"", key)
++        return self.ns[key]
++
++    def __setattr__(self, key, value):
++        self.__dict__[""ns""][key] = value
++
++
+ def parse_command(command):
+     """"""
+         Returns a (path, args) tuple.",What's the point of this class?
+2714,"@@ -411,7 +411,7 @@ import template from './libraryoptionseditor.template.html';
+             parent.querySelector('.chkEnableEmbeddedEpisodeInfosContainer').classList.add('hide');
+         }
+
+-        parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies');
++        parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies' && contentType !== 'mixed');
+
+         return populateMetadataSettings(parent, contentType);
+     }","I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`."
+2715,"@@ -7,6 +7,9 @@ package libkbfs
+ import (
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/syndtr/goleveldb/leveldb""
++	""os""
++	sysPath ""path""
+ 	""sort""
+ 	""strings""
+ 	""sync""","Please put this down with the other ""github.com"" imports."
+2716,"@@ -67,7 +67,7 @@ void nano::block_processor::add (std::shared_ptr<nano::block> block_a, uint64_t
+ 	add (info);
+ }
+
+-void nano::block_processor::add (nano::unchecked_info const & info_a)
++void nano::block_processor::add (nano::unchecked_info const & info_a, bool push_front_preference)
+ {
+ 	if (!nano::work_validate (info_a.block->root (), info_a.block->block_work ()))
+ 	{",Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter
+2717,"@@ -53,8 +53,16 @@ public class InclusiveManifestEvaluator {
+   }
+
+   public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter) {
++    this(spec, rowFilter, true);
++  }
++
++  public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter, boolean caseSensitive) {
+     this.struct = spec.partitionType();
+-    this.expr = Binder.bind(struct, rewriteNot(Projections.inclusive(spec).project(rowFilter)), true);
++    this.expr = Binder.bind(
++            struct,
++            rewriteNot(Projections.inclusive(spec, caseSensitive).project(rowFilter)),
++            caseSensitive
++    );
+   }
+
+   /**","Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments."
+2718,"@@ -14,8 +14,8 @@
+  */
+ package com.google.api.codegen.transformer.csharp;
+
+-import com.google.api.codegen.transformer.ApiMethodTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.StaticLangApiMethodTransformer;
+ import com.google.api.codegen.viewmodel.SimpleParamDocView;
+ import com.google.api.codegen.viewmodel.StaticLangApiMethodView;
+ import com.google.api.tools.framework.model.TypeRef;","Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used..."
+2719,"@@ -67,7 +67,16 @@ def main(global_config, config=None, **settings):
+     # Scan Kinto views.
+     kwargs = {}
+     flush_enabled = asbool(settings.get('flush_endpoint_enabled'))
+-    if not flush_enabled:
++
++    if flush_enabled:
++        config.add_api_capability(
++            ""flush_endpoint"",
++            description=""The __flush__ endpoint can be used to remove all ""
++                        ""data from all backends."",
++            url=""http://kinto.readthedocs.org/en/latest/configuration/""
++                ""settings.html#activating-the-flush-endpoint""
++        )
++    else:
+         kwargs['ignore'] = 'kinto.views.flush'
+     config.scan(""kinto.views"", **kwargs)
+ ",nitpick: I wonder if we should name it `flush` only (?)
+2720,"@@ -0,0 +1,19 @@
++package hub
++
++import ""github.com/prometheus/client_golang/prometheus""
++
++var (
++	tasksGauge = prometheus.NewGauge(prometheus.GaugeOpts{
++		Name: ""sonm_tasks_current"",
++		Help: ""Number of currently running tasks"",
++	})
++	dealsGauge = prometheus.NewGauge(prometheus.GaugeOpts{
++		Name: ""sonm_deals_current"",
++		Help: ""Number of currently running tasks"",
++	})
++)
++
++func init() {
++	prometheus.MustRegister(tasksGauge)
++	prometheus.MustRegister(dealsGauge)
++}","Why gauges, not counters?"
+2721,"@@ -45,7 +45,7 @@ const (
+ 	// hash of origin cluster name and <server> is 6 characters hash of origin server pub key.
+ 	gwReplyPrefix    = ""_GR_.""
+ 	gwReplyPrefixLen = len(gwReplyPrefix)
+-	gwHashLen        = 6
++	gwHashLen        = sysHashLen
+ 	gwClusterOffset  = gwReplyPrefixLen
+ 	gwServerOffset   = gwClusterOffset + gwHashLen + 1
+ 	gwSubjectOffset  = gwServerOffset + gwHashLen + 1","Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more."
+2722,"@@ -93,6 +93,8 @@ public class WebUtils {
+         return ""Killing"";
+       case DISPATCHING:
+         return ""Dispatching"";
++      case POD_FAILED:
++        return ""Pod Failure"";
+       default:
+     }
+     return ""Unknown"";",Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool
+2723,"@@ -30,6 +30,14 @@ const (
+ 	requestTimeout = 60 * time.Second
+ )
+
++// Fetcher defines an interface that may be used to fetch data from the network.
++type Fetcher interface {
++	// FetchTipSets will only fetch TipSets that evaluate to `false` when passed to `done`,
++	// this includes the provided `ts`. The TipSet that evaluates to true when
++	// passed to `done` will be in the returned slice. The returns slice of TipSets is in Traversal order.
++	FetchTipSets(context.Context, types.TipSetKey, peer.ID, func(types.TipSet) (bool, error)) ([]types.TipSet, error)
++}
++
+ // interface conformance check
+ var _ Fetcher = (*GraphSyncFetcher)(nil)
+ ",Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored...
+2724,"@@ -42,7 +42,7 @@ func init() {
+ // MatchExpression matches requests by evaluating a
+ // [CEL](https://github.com/google/cel-spec) expression.
+ // This enables complex logic to be expressed using a comfortable,
+-// familiar syntax.
++// familiar syntax. The standard definitions of CEL functions and operators can be found [here](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions).
+ //
+ // This matcher's JSON interface is actually a string, not a struct.
+ // The generated docs are not correct because this type has custom",I know it has no effect but my eyes can't help. Is that line not too long?
+2725,"@@ -645,13 +645,6 @@ func (r *DefaultRuleRenderer) filterOutputChain(ipVersion uint8) *Chain {
+ 		},
+ 	)
+
+-	// Jump to chain for blocking service CIDR loops.
+-	rules = append(rules,
+-		Rule{
+-			Action: JumpAction{Target: ChainCIDRBlock},
+-		},
+-	)
+-
+ 	return &Chain{
+ 		Name:  ChainFilterOutput,
+ 		Rules: rules,",Does that mean we disable service loop prevention for packet generated by local host?
+2726,"@@ -107,6 +107,7 @@ module Beaker
+         when host['platform'] =~ /cumulus/
+           check_and_install_packages_if_needed(host, CUMULUS_PACKAGES)
+         when (host['platform'] =~ /windows/ and host.is_cygwin?)
++          raise RuntimeError, ""cygwin is not installed on #{host}"" if !host.cygwin_installed?
+           check_and_install_packages_if_needed(host, WINDOWS_PACKAGES)
+         when (host['platform'] =~ /windows/ and not host.is_cygwin?)
+           check_and_install_packages_if_needed(host, PSWINDOWS_PACKAGES)","It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?"
+2727,"@@ -73,8 +73,8 @@ public class ManifestFiles {
+    * @return a manifest writer
+    */
+   public static ManifestWriter write(PartitionSpec spec, OutputFile outputFile) {
+-    // always use a v1 writer for appended manifests because sequence number must be inherited
+-    return write(1, spec, outputFile, null);
++    // always use a v2 writer to preserve sequence numbers, but use null for sequence number so appends inherit
++    return write(2, spec, outputFile, null);
+   }
+
+   /**",Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?
+2728,"@@ -47,4 +47,7 @@ public class SparkWriteOptions {
+
+   // Checks if input schema and table schema are same(default: true)
+   public static final String CHECK_ORDERING = ""check-ordering"";
++
++  // File scan task set ID that is being rewritten
++  public static final String REWRITTEN_FILE_SCAN_TASK_SET_ID = ""rewritten-file-scan-task-set-id"";
+ }",Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?
+2729,"@@ -82,6 +82,15 @@ type TestFields struct {
+ 	NoOutput bool `name:""no_test_output""`
+ }
+
++type DebugFields struct {
++	// Shell command to debug targets.
++	Command string `name:""debug_cmd""`
++	// Like tools but available to the debug_cmd instead
++	tools []BuildInput `name:""debug_tools""`
++	// Named debug tools, similar to named sources.
++	namedTools map[string][]BuildInput `name:""debug_tools""`
++}
++
+ // A BuildTarget is a representation of a build target and all information about it;
+ // its name, dependencies, build commands, etc.
+ type BuildTarget struct {",Nice! Good idea to move these out of the main struct.
+2730,"@@ -201,7 +201,10 @@ func CreateGitIgnore(targetDir string, ignores ...string) error {
+
+ 	if fileutil.FileExists(gitIgnoreFilePath) {
+ 		sigFound, err := fileutil.FgrepStringInFile(gitIgnoreFilePath, DdevFileSignature)
+-		util.CheckErr(err)
++		if err != nil {
++			return err
++		}
++
+ 		// If we sigFound the file and did not find the signature in .ddev/.gitignore, warn about it.
+ 		if !sigFound {
+ 			util.Warning(""User-managed %s will not be managed/overwritten by ddev"", gitIgnoreFilePath)","Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where ""can't happen"" but Things Can Happen."
+2731,"@@ -16,10 +16,13 @@ import java.util.Map;
+  * @see com.fsck.k9.mail.store.StoreConfig#getTransportUri()
+  */
+ public class ServerSettings {
++
++    public enum Type { IMAP, SMTP, WebDAV, POP3 }
++
+     /**
+-     * Name of the store or transport type (e.g. ""IMAP"").
++     * Name of the store or transport type (e.g. IMAP).
+      */
+-    public final String type;
++    public final Type type;
+
+     /**
+      * The host name of the server.","Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(""WebDAV"")."
+2732,"@@ -1,7 +1,14 @@
+-/*global axe */
+-
++/* global axe */
++/**
++ * Converts space delimited token list to an Array
++ * @method tokenList
++ * @memberof axe.commons.utils
++ * @instance
++ * @param  {String} str
++ * @return {Array}
++ */
+ axe.utils.tokenList = function (str) {
+ 	'use strict';
+
+ 	return str.trim().replace(/\s{2,}/g, ' ').split(' ');
+-};
++};","It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice."
+2733,"@@ -3,7 +3,9 @@ let nodeName = node.nodeName.toUpperCase();
+ let type = (node.getAttribute('type') || '').toLowerCase();
+ let label = node.getAttribute('value');
+
+-this.data(label);
++if (label) {
++	this.data('has-label');
++}
+
+ if (nodeName === 'INPUT' && ['submit', 'reset'].includes(type)) {
+ 	return label === null;","The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was."
+2734,"@@ -267,6 +267,14 @@ func (a *WebAPI) SyncApplication(ctx context.Context, req *webservice.SyncApplic
+ 		return nil, err
+ 	}
+
++	claims, err := rpcauth.ExtractClaims(ctx)
++	if err != nil {
++		return nil, err
++	}
++	if app.ProjectId != claims.Role.ProjectId {
++		return nil, status.Error(codes.PermissionDenied, ""application cannot be synced"")
++	}
++
+ 	cmd := model.Command{
+ 		Id:            uuid.New().String(),
+ 		PipedId:       app.PipedId,","nit: ""The current project does not have requested application"""
+2735,"@@ -14,6 +14,7 @@ use Ergonode\SharedKernel\Domain\AbstractCode;
+ class AttributeCode extends AbstractCode
+ {
+     public const PATTERN = '/^([a-zA-Z0-9_]+)$/';
++    public const FORBIDDEN = ['id'];
+
+     public function __construct(string $value)
+     {",Extend Unit test for this class
+2736,"@@ -62,6 +62,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string AppSecRules = ""DD_APPSEC_RULES"";
+
++        /// <summary>
++        /// Configuration key indicating the optional name of the custom header to take into account for the ip address.
++        /// Default is value is null (do not override).
++        /// </summary>
++        public const string AppSecCustomIpHeader = ""DD_APPSEC_IPHEADER"";
++
++        /// <summary>
++        /// Configuration key indicating the optional name of the custom header to take into account for the ip address.
++        /// Default is value is null (do not override).
++        /// </summary>
++        public const string AppSecExtraHeaders = ""DD_APPSEC_EXTRA_HEADERS"";
++
+         /// <summary>
+         /// Configuration key for enabling or disabling the Tracer's debug mode.
+         /// Default is value is false (disabled).",This is this a copy / paste error from above.
+2737,"@@ -0,0 +1,8 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.typeresolution.typeinterference;
++
++public class Variable {
++}",this package has to be renamed to `typeinference`
+2738,"@@ -124,6 +124,9 @@ module.exports = {
+         let credentials = Realm.Credentials.anonymous();
+         let user = await app.logIn(credentials);
+         TestCase.assertInstanceOf(user, Realm.User);
++        TestCase.assertNotNull(user.deviceId);
++        TestCase.assertNotNull(user.providerType);
++        TestCase.assertEqual(user.providerType, ""anon-user"");
+         await user.logOut();
+     },
+ ",This cancels the above null-check I guess.
+2739,"@@ -31,9 +31,9 @@ public final class Configuration {
+   //// 2.1 configuration items
+   public static final String PROP_ROOT = ""servicecomb.loadbalance."";
+
+-  public static final String RPOP_SERVER_EXPIRED_IN_SECONDS = ""servicecomb.loadbalance.stats.serverExpiredInSeconds"";
++  public static final String PROP_SERVER_EXPIRED_IN_SECONDS = ""servicecomb.loadbalance.stats.serverExpiredInSeconds"";
+
+-  public static final String RPOP_TIMER_INTERVAL_IN_MINIS = ""servicecomb.loadbalance.stats.timerIntervalInMilis"";
++  public static final String PROP_TIMER_INTERVAL_IN_MILLIS = ""servicecomb.loadbalance.stats.timerIntervalInMilis"";
+
+   public static final String PROP_RULE_STRATEGY_NAME = ""strategy.name"";
+ ",change to timerIntervalInMillis
+2740,"@@ -121,6 +121,8 @@ return [
+         'email' => 'Email',
+         'role_field' => 'Role',
+         'role_comment' => 'Roles define user permissions, which can be overriden on the user level, on the Permissions tab.',
++        'role_none' => 'None',
++        'role_none_comment' => 'This administrator does not belong to any rules.',
+         'groups' => 'Groups',
+         'groups_comment' => 'Specify which groups this account should belong to.',
+         'avatar' => 'Avatar',",`any rules` should be `any roles`
+2741,"@@ -105,13 +105,12 @@ public class AllEpisodesFragment extends EpisodesListFragment {
+     @NonNull
+     @Override
+     protected List<FeedItem> loadData() {
+-        return feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes(0, page * EPISODES_PER_PAGE));
++        return DBReader.getRecentlyPublishedEpisodesFiltered(0, page * EPISODES_PER_PAGE, feedItemFilter);
+     }
+
+     @NonNull
+     @Override
+     protected List<FeedItem> loadMoreData() {
+-        return feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes((page - 1) * EPISODES_PER_PAGE,
+-                EPISODES_PER_PAGE));
++        return DBReader.getRecentlyPublishedEpisodesFiltered((page - 1) * EPISODES_PER_PAGE, EPISODES_PER_PAGE, feedItemFilter);
+     }
+ }","Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication."
+2742,"@@ -29,9 +29,11 @@ from qutebrowser.utils import message
+ from qutebrowser.config import config
+ from qutebrowser.keyinput import keyparser
+ from qutebrowser.utils import usertypes, log, objreg, utils
++from qutebrowser.config.parsers import keyconf
+
+
+-STARTCHARS = "":/?""
++conf = keyconf.KeyConfigParser(None, None)
++STARTCHARS = conf.get_bindings_for('normal').keys()
+ LastPress = usertypes.enum('LastPress', ['none', 'filtertext', 'keystring'])
+
+ ","I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound."
+2743,"@@ -69,7 +69,6 @@ public abstract class TomcatServerBootstrap extends EmbeddedServerBootstrap {
+       .useLegacyLocalRepo(true).configureViaPlugin();
+
+     WebArchive wa = ShrinkWrap.create(WebArchive.class, ""rest-test.war"").setWebXML(webXmlPath)
+-        .addAsLibraries(resolver.resolve(""org.codehaus.jackson:jackson-jaxrs:1.6.5"").withTransitivity().asFile())
+         .addAsLibraries(resolver.addDependencies(
+             MavenDependencies.createDependency(""org.mockito:mockito-core"", ScopeType.TEST, false,
+             MavenDependencies.createExclusion(""org.hamcrest:hamcrest-core""))).resolve()",@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?
+2744,"@@ -40,10 +40,16 @@ type Miner struct {
+ 	// PeerID is the peer ID to set as the miners owner
+ 	PeerID string
+
+-	// Power is the amount of power this miner should start off with
++	// NumCommittedSectors is the number of sectors that this miner has
++	// committed to the network.
++	//
++	// TODO: This struct needs a field which represents the size of sectors
++	// that this miner has committed. For now, sector size is configured by
++	// the StorageMarketActor's ProofsMode.
++	//
+ 	// TODO: this will get more complicated when we actually have to
+-	// prove real files
+-	Power uint64
++	// prove real files.
++	NumCommittedSectors uint64
+ }
+
+ // GenesisCfg is",uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?
+2745,"@@ -109,7 +109,6 @@ type initStorageOpts struct {
+ 	ws    wsAddonManager
+ 	store store
+
+-	app *config.Application
+ 	sel wsSelector
+ }
+ ","Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it."
+2746,"@@ -337,6 +337,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		}
+ 	}
+
++	// Get the remote host
++	remoteHost, _, err := net.SplitHostPort(r.RemoteAddr)
++	if err != nil {
++		remoteHost = r.RemoteAddr
++	}
++
+ 	if vh, ok := s.vhosts[host]; ok {
+ 		status, _ := vh.stack.ServeHTTP(w, r)
+ ","To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone."
+2747,"@@ -221,7 +221,13 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= p.foundationBonusP2StartEpoch && epochNum <= p.foundationBonusP2EndEpoch) {
++	var grantFB bool
++	if a.hasFoundationBonusExtension() {
++		grantFB = a.grantFoundationBonus(epochNum)
++	} else {
++		grantFB = epochNum <= a.foundationBonusLastEpoch || (epochNum >= p.cfg.FoundationBonusP2StartEpoch && epochNum <= p.cfg.FoundationBonusP2EndEpoch)
++	}
++	if grantFB {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb"
+2748,"@@ -222,8 +222,7 @@ class RandomFlip(object):
+             flipped[..., 1::4] = h - bboxes[..., 3::4]
+             flipped[..., 3::4] = h - bboxes[..., 1::4]
+         else:
+-            raise ValueError(
+-                'Invalid flipping direction ""{}""'.format(direction))
++            raise ValueError(f'Invalid flipping direction ""{direction}""')
+         return flipped
+
+     def __call__(self, results):",Use single quote to wrap the str.
+2749,"@@ -100,7 +100,7 @@ public enum JsonRpcError {
+       ""The permissioning whitelist configuration file is out of sync.  The changes have been applied, but not persisted to disk""),
+   WHITELIST_RELOAD_ERROR(
+       -32000,
+-      ""Error reloading permissions file. Please use perm_getAccountsWhitelist and perm_getNodesWhitelist to review the current state of the whitelists""),
++      ""Error reloading permissions file. Please use perm_getAccountsWhitelist and perm_getNodesAllowlist to review the current state of the whitelists""),
+   PERMISSIONING_NOT_ENABLED(-32000, ""Node/Account whitelisting has not been enabled""),
+   NON_PERMITTED_NODE_CANNOT_BE_ADDED_AS_A_PEER(-32000, ""Cannot add a non-permitted node as a peer""),
+ ",Is the plan to rename this later?
+2750,"@@ -340,7 +340,9 @@ class ChoiceAuth extends AbstractBase
+             return false;
+         }
+
+-        if (!in_array($this->strategy, $this->strategies)) {
++        if ('Email' !== $this->strategy
++            && !in_array($this->strategy, $this->strategies)
++        ) {
+             throw new InvalidArgumentException(""Illegal setting: {$this->strategy}"");
+         }
+         $authenticator = $this->getPluginManager()->get($this->strategy);",Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?
+2751,"@@ -130,6 +130,9 @@ func makeJournalServer(
+ 	bcache BlockCache, dirtyBcache DirtyBlockCache, bserver BlockServer,
+ 	mdOps MDOps, onBranchChange branchChangeListener,
+ 	onMDFlush mdFlushListener, diskLimiter diskLimiter) *JournalServer {
++	if len(dir) == 0 {
++		panic(""dir unexpectedly empty"")
++	}
+ 	jServer := JournalServer{
+ 		config:                  config,
+ 		log:                     log,","This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe ""dir"" -> ""dir string""?"
+2752,"@@ -53,6 +53,9 @@ namespace Kokkos {
+ namespace Experimental {
+
+ bool HPX::m_hpx_initialized = false;
++bool HPX::m_was_initialized = false;
++bool HPX::m_was_finalized   = false;
++
+ std::atomic<uint32_t> HPX::m_next_instance_id{1};
+ #if defined(KOKKOS_ENABLE_HPX_ASYNC_DISPATCH)
+ std::atomic<uint32_t> HPX::m_active_parallel_region_count{0};",Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?
+2753,"@@ -108,8 +108,8 @@ func NewMetadata(
+ 		}
+ 		versionToClusterName[info.InitialFailoverVersion] = clusterName
+
+-		if info.Enabled && (len(info.RPCName) == 0 || len(info.RPCAddress) == 0) {
+-			panic(fmt.Sprintf(""Cluster %v: rpc name / address is empty"", clusterName))
++		if info.Enabled && info.RPCAddress == """" {
++			panic(fmt.Sprintf(""Cluster %v: RPCAddress is empty"", clusterName))
+ 		}
+ 	}
+ ",also check RPCName?
+2754,"@@ -76,9 +76,11 @@ import org.springframework.security.oauth2.client.userinfo.ReactiveOAuth2UserSer
+ import org.springframework.security.oauth2.client.web.server.AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository;
+ import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationCodeGrantWebFilter;
+ import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationRequestRedirectWebFilter;
++import org.springframework.security.oauth2.client.web.server.ServerAuthorizationRequestRepository;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationCodeAuthenticationTokenConverter;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationRequestResolver;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizedClientRepository;
++import org.springframework.security.oauth2.client.web.server.WebSessionOAuth2ServerAuthorizationRequestRepository;
+ import org.springframework.security.oauth2.client.web.server.authentication.OAuth2LoginAuthenticationWebFilter;
+ import org.springframework.security.oauth2.core.endpoint.OAuth2AuthorizationRequest;
+ import org.springframework.security.oauth2.core.oidc.user.OidcUser;",Remove unused import
+2755,"@@ -182,7 +182,7 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) {
+ 	newInst := &Instance{serverType: newCaddyfile.ServerType(), wg: i.wg}
+
+ 	// attempt to start new instance
+-	err := startWithListenerFds(newCaddyfile, newInst, restartFds)
++	err := startWithListenerFds(newCaddyfile, newInst, restartFds, false)
+ 	if err != nil {
+ 		return i, err
+ 	}",I assume there will never be a scenario where justValidate is expected to be true on a restart
+2756,"@@ -356,6 +356,9 @@ public class PMD {
+
+         sortFiles(configuration, files);
+
++        // Make sure the cache is listening for analysis results
++        ctx.getReport().addListener(configuration.getAnalysisCache());
++
+         /*
+          * Check if multithreaded support is available. ExecutorService can also
+          * be disabled if threadCount is not positive, e.g. using the","Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?"
+2757,"@@ -3,7 +3,7 @@ module Travis
+     class Script
+       class C < Script
+         DEFAULTS = {
+-          compiler: 'gcc'
++          compiler: ''
+         }
+
+         def export","I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in ""`command not found`"" (though not critical), and the cache slug will lack this information (also not critical)."
+2758,"@@ -33,6 +33,9 @@ const instanceMethods = {
+     },
+
+     async callFunction(name, args, service = undefined) {
++        if (!args) {
++            args = [];
++        }
+         const cleanedArgs = cleanArguments(args);
+         const stringifiedArgs = EJSON.stringify(cleanedArgs, { relaxed: false });
+         const result = await promisify(cb => this._callFunction(name, stringifiedArgs, service, cb));",Why do this rather than `args = []` in the function signature?
+2759,"@@ -22,6 +22,8 @@ module Bolt
+         %w[service-url cacert token-file task-environment local-validation]
+       end
+
++      PROVIDED_FEATURES = ['puppet-agent'].freeze
++
+       def self.validate(options)
+         validation_flag = options['local-validation']
+         unless !!validation_flag == validation_flag",I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though
+2760,"@@ -1640,6 +1640,11 @@ class Dataset(object):
+         if self.handle is None or other.handle is None:
+             raise ValueError('Both source and target Datasets must be constructed before adding features')
+         _safe_call(_LIB.LGBM_DatasetAddFeaturesFrom(self.handle, other.handle))
++        if other.data is None:
++            self.data = None
++        if self.data is not None:
++            # FIXME: concat two dataset
++            self.data = [self.data, other.data]
+         return self
+
+     def _dump_text(self, filename):",@StrikerRUS here may need to concat two data by col.
+2761,"@@ -64,7 +64,7 @@ public interface NodeWithJavadoc<N extends Node> {
+      */
+     @SuppressWarnings(""unchecked"")
+     default N setJavadocComment(String comment) {
+-        return setJavadocComment(new JavadocComment(comment));
++        return setJavadocComment(new JavadocComment("" "" + comment));
+     }
+
+     default N setJavadocComment(JavadocComment comment) {",Why the space?
+2762,"@@ -38,10 +38,10 @@ public interface ZalcanoConfig extends Config
+ {
+
+ 	@ConfigTitleSection(
+-		keyName = ""zalcanoTitle"",
+-		name = ""Zalcano"",
+-		description = """",
+-		position = 0
++			keyName = ""zalcanoTitle"",
++			name = ""Zalcano"",
++			description = """",
++			position = 0
+ 	)
+ 	default Title zalcanoTitle()
+ 	{",please resolve the extra indentation
+2763,"@@ -69,8 +69,9 @@ namespace pwiz.Skyline.Model.Lib
+         protected override bool StateChanged(SrmDocument document, SrmDocument previous)
+         {
+             return previous == null ||
+-                !ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) ||
+-                !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults);
++                   !ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) ||
++                   !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) ||
++                   !ReferenceEquals(document.Id, previous.Id);
+         }
+
+         protected override string IsNotLoadedExplained(SrmDocument document)",More proof that this check is needed always.
+2764,"@@ -86,9 +86,7 @@ lbann_comm::~lbann_comm() {
+     }
+   }
+ #ifdef LBANN_HAS_ALUMINUM
+-  for (auto&& c : al_comms) {
+-    delete c.second;
+-  }
++  m_al_comms.clear();
+   allreduces::Finalize();
+ #endif
+ }",`m_al_comms` now contains smart pointers.
+2765,"@@ -80,6 +80,10 @@ namespace AutoRest.CSharp
+                 {
+                     return ""new "" + type.Name + ""()"";
+                 }
++                if (type is EnumType && (type as EnumType).ModelAsString)
++                {
++                    return Instance.QuoteValue(defaultValue);
++                }
+                 if (primaryType != null)
+                 {
+                     if (primaryType.KnownPrimaryType == KnownPrimaryType.String)",Did you do a test run with the compare script? I'm nervous about what happens on all the generators...
+2766,"@@ -390,6 +390,19 @@ func (c *client) initClient() {
+ 	}
+ }
+
++// RemoteAddress expose the Address of the client connection,
++// nil when not connected or unknown
++func (c *client) RemoteAddress() net.Addr {
++	c.mu.Lock()
++	defer c.mu.Unlock()
++
++	if c.nc == nil {
++		return nil
++	}
++
++	return c.nc.RemoteAddr()
++}
++
+ // Helper function to report errors.
+ func (c *client) reportErrRegisterAccount(acc *Account, err error) {
+ 	if err == ErrTooManyAccountConnections {","For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not."
+2767,"@@ -196,6 +196,6 @@ public class TestDataSourceOptions {
+         .option(""split-size"", String.valueOf(562L)) // 562 bytes is the size of SimpleRecord(1,""a"")
+         .load(tableLocation);
+
+-    Assert.assertEquals(""Spark partitions should match"", 2, resultDf.javaRDD().getNumPartitions());
++    Assert.assertEquals(""Spark partitions should match"", 4, resultDf.javaRDD().getNumPartitions());
+   }
+ }",This change is suspicious. Why did the number of partitions increase?
+2768,"@@ -20,8 +20,7 @@ class ProposalPolicy
+   end
+
+   def can_create!
+-    # TODO restrict by client_slug
+-    true
++    slug_matches? || @user.admin?
+   end
+   alias_method :can_new!, :can_create!
+ ","I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?"
+2769,"@@ -1710,10 +1710,11 @@ namespace pwiz.Skyline.EditUI
+         private void UpdateMoleculeType()
+         {
+             bool isPeptide = radioPeptide.Checked;
+-            btnCustomMoleculeColumns.Enabled = radioMolecule.Checked;
++            btnCustomMoleculeColumns.Enabled = true;
+             Settings.Default.TransitionListInsertPeptides = isPeptide; // Remember for next time
+
+-            //Skip updating if nothing needs to be changed
++            // Skip updating if nothing needs to be changed
++            // This should probably be taken out when we add smarter column selection as its currently hard coded for the number of columns
+             if ((isPeptide && gridViewTransitionList.ColumnCount == 5) || (!isPeptide && gridViewTransitionList.ColumnCount == 6))
+                 return;
+ ",Should there be any changes to this file at all?
+2770,"@@ -87,6 +87,7 @@ func parseTLS(h Helper) ([]ConfigValue, error) {
+ 	var folderLoader caddytls.FolderLoader
+ 	var certSelector caddytls.CustomCertSelectionPolicy
+ 	var acmeIssuer *caddytls.ACMEIssuer
++	var autoPolicy *caddytls.AutomationPolicy
+ 	var internalIssuer *caddytls.InternalIssuer
+ 	var issuers []certmagic.Issuer
+ 	var onDemand bool","The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here."
+2771,"@@ -36,8 +36,11 @@ var SwaggerPetstore = ( /** @lends SwaggerPetstore */ function() {
+    * {@link https://github.com/request/request#requestoptions-callback Options doc}
+    */
+   function SwaggerPetstore(baseUri, options) {
+-    SwaggerPetstore['super_'].call(this, options);
+-
++    if (!options) {
++      options = {};
++    }
++    SwaggerPetstore['super_'].call(this, options.credentials, options);
++
+     this.baseUri = baseUri;
+     if (this.baseUri === null || this.baseUri === undefined) {
+       this.baseUri = 'http://localhost:12510/api';",This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state
+2772,"@@ -23,13 +23,15 @@ import { createTestRegistry } from './utils';
+  * Renders the given UI into a container to make assertions.
+  *
+  * @since 1.7.1
++ * @since 1.25.0 Added `features` option.
+  * @see {@link https://testing-library.com/docs/react-testing-library/api#render}
+  * @private
+  *
+- * @param {*}        ui                    Any valid React child element.
+- * @param {Object}   options               Render options.
+- * @param {Function} options.setupRegistry A function which accepts the registry instance to configure it.
+- * @param {Function} options.registry      A specific registry instance to use. Defaults to a fresh test registry with all stores.
++ * @param {*}        ui                      Any valid React child element.
++ * @param {Object}   [options]               Optional. Render options.
++ * @param {string[]} [options.features]      Feature flags to enable for this hook render.
++ * @param {Function} [options.setupRegistry] A function which accepts the registry instance to configure it.
++ * @param {Object}   [options.registry]      A specific registry instance to use. Defaults to a fresh test registry with all stores.
+  * @return {Object} An object containing all of {@link https://testing-library.com/docs/react-testing-library/api#render-result} as well as the `registry`.
+  */
+ const customRender = ( ui, options = {} ) => {",Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed.
+2773,"@@ -251,14 +251,14 @@ std::string CPlusPlusLanguage::MethodName::GetScopeQualifiedName() {
+ bool CPlusPlusLanguage::IsCPPMangledName(const char *name) {
+   // FIXME!! we should really run through all the known C++ Language plugins
+   // and ask each one if this is a C++ mangled name
+-
++
+   if (name == nullptr)
+     return false;
+-
+-  // MSVC style mangling
++
++  // MSVC style mangling
+   if (name[0] == '?')
+     return true;
+-
++
+   return (name[0] != '\0' && name[0] == '_' && name[1] == 'Z');
+ }
+ ",This looks like a bunch of whitespace fixing that's unrelated. Can you revert?
+2774,"@@ -25,7 +25,7 @@ class AppKernel extends Kernel
+             new Symfony\Bundle\SecurityBundle\SecurityBundle(),
+             new Symfony\Bundle\TwigBundle\TwigBundle(),
+             new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
+-            new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
++            // new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
+             new Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle(),
+             new EasyCorp\Bundle\EasyAdminBundle\EasyAdminBundle(),
+             new EasyCorp\Bundle\EasyAdminBundle\Tests\Fixtures\AppTestBundle\AppTestBundle(),",should be removed instead
+2775,"@@ -88,10 +88,14 @@ public class TestRegExp extends LuceneTestCase {
+     assertTrue(a.toString().length() > 0);
+   }
+
++
++  boolean caseSensitiveQuery = true;
++
+   public void testCoreJavaParity() {
+     // Generate random doc values and random regular expressions
+     // and check for same matching behaviour as Java's Pattern class.
+     for (int i = 0; i < 1000; i++) {
++      caseSensitiveQuery = true;
+       checkRandomExpression(randomDocValue(1 + random().nextInt(30)));
+     }
+   }",should use randomization ?
+2776,"@@ -102,7 +102,7 @@ func (c *CmdVolumeOptions) RunVolumeInfo(cmd *cobra.Command) error {
+ 	// controller's IP, status, iqn, replica IPs etc.
+ 	volumeInfo, err := NewVolumeInfo(mapiserver.GetURL()+VolumeAPIPath+c.volName, c.volName, c.namespace)
+ 	if err != nil {
+-		return err
++		return nil
+ 	}
+
+ 	// Initiallize an instance of ReplicaCollection, json response recieved from the replica controller. Collection contains status and other information of replica.",returning nil because we want to mayactl to exit with 0 status code.
+2777,"@@ -112,7 +112,7 @@ static void send_response(struct st_h2o_status_collector_t *collector)
+     resp[cur_resp++] = (h2o_iovec_t){H2O_STRLIT(""\n}\n"")};
+
+     req->res.status = 200;
+-    h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CONTENT_TYPE, H2O_STRLIT(""text/plain; charset=utf-8""));
++    h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CONTENT_TYPE, H2O_STRLIT(""application/json; charset=utf-8""));
+     h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CACHE_CONTROL, H2O_STRLIT(""no-cache, no-store""));
+     h2o_start_response(req, &generator);
+     h2o_send(req, resp, h2o_memis(req->input.method.base, req->input.method.len, H2O_STRLIT(""HEAD"")) ? 0 : nr_resp, 1);",Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...)
+2778,"@@ -9,12 +9,12 @@ namespace Microsoft.CodeAnalysis.Sarif
+     /// <summary>
+     /// The state of a result relative to a baseline of a previous run.
+     /// </summary>
+-    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.28.0.0"")]
+     [Flags]
++    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.30.0.0"")]
+     public enum SuppressionStates
+     {
+         None,
+-        SuppressedInSource = 0x1,
+-        SuppressedInBaseline = 0x2
++        SuppressedInSource = 1,
++        SuppressedInBaseline = 2
+     }
+ }",`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved
+2779,"@@ -376,6 +376,9 @@ configRetry:
+ 	} else {
+ 		// Use the syncer locally.
+ 		syncer = felixsyncer.New(backendClient, datastoreConfig.Spec, syncerToValidator)
++
++		log.Info(""using resource updates where applicable"")
++		configParams.SetUseResourceUpdates(true)
+ 	}
+ 	log.WithField(""syncer"", syncer).Info(""Created Syncer"")
+ ",I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API.
+2780,"@@ -62,8 +62,13 @@ func main() {
+ 		ddata, err := ioutil.ReadFile(os.Args[3])
+ 		failFast(err)
+
++		programstr := fmt.Sprintf(""%s"", pdata)
++
++		programbytes, err := logic.AssembleString(programstr)
++		failFast(err)
++
+ 		dsig := sec.Sign(logic.Msg{
+-			ProgramHash: crypto.HashObj(logic.Program(pdata)),
++			ProgramHash: crypto.HashObj(logic.Program(programbytes)),
+ 			Data:        ddata,
+ 		})
+ ",Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?
+2781,"@@ -257,6 +257,12 @@ class VirtualBufferTextInfo(browseMode.BrowseModeDocumentTextInfo,textInfos.offs
+ 		return lineStart.value,lineEnd.value
+
+ 	def _normalizeControlField(self,attrs):
++
++		ariaCurrent = attrs.get(""IAccessible2::attribute_current"")
++		if ariaCurrent != None:
++			attrs['current']= ariaCurrent
++			del attrs[""IAccessible2::attribute_current""]
++
+ 		tableLayout=attrs.get('table-layout')
+ 		if tableLayout:
+ 			attrs['table-layout']=tableLayout==""1""",Extraneous blank line.
+2782,"@@ -43,5 +43,5 @@ var errWalletNotFound = fmt.Errorf(""wallet not found"")
+ var errSQLiteWrongType = fmt.Errorf(""sqlite wallet driver returned wrong wallet type"")
+ var errNameTooLong = fmt.Errorf(""wallet name too long, must be <= %d bytes"", sqliteMaxWalletNameLen)
+ var errIDTooLong = fmt.Errorf(""wallet id too long, must be <= %d bytes"", sqliteMaxWalletIDLen)
+-var errMsigWrongAddr = fmt.Errorf(""given multisig preimage hashes to wrong address"")
++var errMsigWrongAddr = fmt.Errorf(""given multisig preimage hashes to neither Sender or AuthAddr"")
+ var errMsigWrongKey = fmt.Errorf(""given key is not a possible signer for this multisig"")",nit: syntax : neither -> nor
+2783,"@@ -45,11 +45,11 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.Log4Net
+                 loggingEvent.Properties[CorrelationIdentifier.VersionKey] = tracer.Settings.ServiceVersion ?? string.Empty;
+                 loggingEvent.Properties[CorrelationIdentifier.EnvKey] = tracer.Settings.Environment ?? string.Empty;
+
+-                var span = tracer.ActiveScope?.Span;
+-                if (span is not null)
++                var spanContext = tracer.DistributedSpanContext;
++                if (spanContext is not null)
+                 {
+-                    loggingEvent.Properties[CorrelationIdentifier.TraceIdKey] = span.TraceId;
+-                    loggingEvent.Properties[CorrelationIdentifier.SpanIdKey] = span.SpanId;
++                    loggingEvent.Properties[CorrelationIdentifier.TraceIdKey] = spanContext[HttpHeaderNames.TraceId];
++                    loggingEvent.Properties[CorrelationIdentifier.SpanIdKey] = spanContext[HttpHeaderNames.ParentId];
+                 }
+             }
+ ",Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not.
+2784,"@@ -689,8 +689,9 @@ public class ExecutionController extends EventHandler implements ExecutorManager
+             this.maxConcurrentRunsPerFlowMap);
+         if (running.size() > maxConcurrentRuns) {
+           this.commonMetrics.markSubmitFlowSkip();
+-          throw new ExecutorManagerException(""Flow "" + flowId
+-              + "" has more than "" + maxConcurrentRuns + "" concurrent runs. Skipping"",
++          throw new ExecutorManagerException(""Flow with id "" +
++              (exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId)
++              + "" has more than "" + maxConcurrentRuns + "" concurrent runs. Execution not created."",
+               ExecutorManagerException.Reason.SkippedExecution);
+         } else if (options.getConcurrentOption().equals(
+             ExecutionOptions.CONCURRENT_OPTION_PIPELINE)) {","Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `<flowId,flowDefinitionId>` ?"
+2785,"@@ -1774,6 +1774,7 @@ return [
+ 'DateTime::add' => ['static', 'interval'=>'DateInterval'],
+ 'DateTime::createFromFormat' => ['static|false', 'format'=>'string', 'time'=>'string', 'timezone='=>'?DateTimeZone'],
+ 'DateTime::createFromImmutable' => ['static', 'datetTimeImmutable'=>'DateTimeImmutable'],
++'DateTime::createFromInterface' => ['DateTimeInterface', 'self'],
+ 'DateTime::diff' => ['DateInterval|false', 'datetime2'=>'DateTimeInterface', 'absolute='=>'bool'],
+ 'DateTime::format' => ['string|false', 'format'=>'string'],
+ 'DateTime::getLastErrors' => ['array{warning_count:int,warnings:array<int,string>,error_count:int,errors:array<int,string>}'],",Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`.
+2786,"@@ -114,12 +114,6 @@ function getArrayBuffer (chunk) {
+
+ function getFileType (file) {
+   const fileExtension = file.name ? getFileNameAndExtension(file.name).extension : null
+-
+-  if (file.isRemote) {
+-    // some remote providers do not support file types
+-    return file.type ? file.type : mimeTypes[fileExtension]
+-  }
+-
+   // check if mime type is set in the file object
+   if (file.type) {
+     return file.type",this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks.
+2787,"@@ -71,7 +71,7 @@ class Feature extends BaseI18nLoop implements PropelSearchLoopInterface
+             new Argument(
+                 'order',
+                 new TypeCollection(
+-                    new Type\EnumListType(array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'manual', 'manual_reverse'))
++                    new Type\EnumListType(array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'alpha_reverse' , 'manual', 'manual_reverse'))
+                 ),
+                 'manual'
+             ),",Please could you remove the useless space.
+2788,"@@ -1082,12 +1082,14 @@ public final class OrdsSegmentTermsEnum extends BaseTermsEnum {
+       if (FST.targetHasArcs(arc)) {
+         // System.out.println(""  targetHasArcs"");
+         result.grow(1+upto);
+-
++        if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
++          assert(arc.target >= 0);
++          assert(arc.target < Integer.MAX_VALUE);
++        }
+         fr.index.readFirstRealTargetArc(arc.target, arc, fstReader);
+
+         if (arc.bytesPerArc != 0) {
+           // System.out.println(""  array arcs"");
+-
+           int low = 0;
+           int high = arc.numArcs-1;
+           int mid = 0;",What's the point of this block (and isn't it effectively dead code)?
+2789,"@@ -5,7 +5,7 @@ class ForumSessionsController < ApplicationController
+   def new
+     sso = DiscourseSignOn.parse(
+       request.query_string,
+-      ENV[""DISCOURSE_SSO_SECRET""]
++      ENV.fetch(""DISCOURSE_SSO_SECRET""),
+     )
+     populate_sso_for_current_user(sso)
+     track_forum_access",Put a comma after the last parameter of a multiline method call.
+2790,"@@ -0,0 +1,6 @@
++from dagster import job, SourceHashVersionStrategy
++
++
++@job(version_strategy=SourceHashVersionStrategy())
++def the_job():
++    ...",Newline at end of file plz
+2791,"@@ -18,7 +18,10 @@ package v1alpha3
+
+ import (
+ 	""fmt""
++	""github.com/aws/aws-sdk-go/aws""
++	""k8s.io/apimachinery/pkg/types""
+ 	""reflect""
++	clusterv1 ""sigs.k8s.io/cluster-api/api/v1alpha3""
+ )
+
+ // Tags defines a map of tags.","Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily."
+2792,"@@ -1028,4 +1028,18 @@ class Queue
+             ]
+         );
+     }
++
++    /**
++     * Sets the timestamp of when an item last has been indexed.
++     *
++     * @param Item $item
++     */
++    public function updateIndexQueueByItem(Item $item)
++    {
++        $GLOBALS['TYPO3_DB']->exec_UPDATEquery(
++            'tx_solr_indexqueue_item',
++            'uid = ' . (int)$item->getIndexQueueUid(),
++            ['indexed' => time()]
++        );
++    }
+ }","Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like ""updateIndexTimeByItem(Item $item)"""
+2793,"@@ -95,6 +95,8 @@ class visibility_of(object):
+
+
+ def _element_if_visible(element, visibility=True):
++    if isinstance(element, str) or isinstance(element, dict):
++           raise StaleElementReferenceException(""Invalid locator"")
+     return element if element.is_displayed() == visibility else False
+
+ ",This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.
+2794,"@@ -45,6 +45,10 @@
+ #include <Kokkos_Macros.hpp>
+ #ifdef KOKKOS_ENABLE_CUDA
+
++#include <Kokkos_Core.hpp>
++#include <Kokkos_Cuda.hpp>
++#include <Kokkos_CudaSpace.hpp>
++
+ #include <cstdlib>
+ #include <iostream>
+ #include <sstream>",I assume this came from format?
+2795,"@@ -56,6 +56,13 @@ class ReIndexTask extends AbstractTask
+      */
+     protected $indexingConfigurationsToReIndex = array();
+
++    /**
++     * Clear Index for selected sites and record types
++     *
++     * @var boolean
++     */
++    protected $clearSearchIndex;
++
+
+     /**
+      * Purges/commits all Solr indexes, initializes the Index Queue",I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code.
+2796,"@@ -237,6 +237,8 @@ func (km *KeyManagerStandard) getTLFCryptKeyParams(
+ 				kbfscrypto.CryptPublicKey{},
+ 				localMakeRekeyReadError(err)
+ 		}
++		km.log.CDebugf(ctx, ""Trying to decrypt with keys = %s"",
++			dumpConfig().Sdump(keys))
+ 		var index int
+ 		clientHalf, index, err = crypto.DecryptTLFCryptKeyClientHalfAny(ctx,
+ 			keys, flags&getTLFCryptKeyPromptPaper != 0)",Do we really need this? Seems like it would pollute the logs pretty badly.
+2797,"@@ -9,6 +9,8 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure
+ {
+     public struct MemoryPoolIterator2
+     {
++        private readonly static int _vectorSpan = Vector<byte>.Count;
++
+         private MemoryPoolBlock2 _block;
+         private int _index;
+ ",`Vector<byte>.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const.
+2798,"@@ -208,6 +208,9 @@ class PostgresqlStorageMigrationTest(unittest.TestCase):
+ class PostgresqlPermissionMigrationTest(unittest.TestCase):
+     def __init__(self, *args, **kw):
+         super(PostgresqlPermissionMigrationTest, self).__init__(*args, **kw)
++        from kinto.core.utils import sqlalchemy
++        if sqlalchemy is None:
++            return
+
+         from .test_permission import PostgreSQLPermissionTest
+         settings = PostgreSQLPermissionTest.settings.copy()",Can we use a skipIf decorator instead?
+2799,"@@ -3,6 +3,14 @@
+ module Faker
+   class Number < Base
+     class << self
++      ##
++      # Produce a random number.
++      #
++      # @param digits [Integer] Number of digits that the generated number should have.
++      # @return [Integer]
++      #
++      # @example
++      #   Faker::Number.number(digits: 10) #=> 1968353479
+       def number(legacy_digits = NOT_GIVEN, digits: 10)
+         warn_for_deprecated_arguments do |keywords|
+           keywords << :digits if legacy_digits != NOT_GIVEN",Missing version tags
+2800,"@@ -60,6 +60,11 @@ module Bolt
+         print_table('tasks' => tasks, 'modulepath' => modulepath)
+       end
+
++      def print_plugin_list(plugins, modulepath)
++        plugins.delete(:validate_resolve_reference)
++        print_table('plugins' => plugins, 'modulepath' => modulepath)
++      end
++
+       def print_plan_info(plan)
+         path = plan.delete('module')
+         plan['module_dir'] = if path.start_with?(Bolt::Config::Modulepath::MODULES_PATH)",I think this should also filter out `validate_resolve_reference` hooks.
+2801,"@@ -18,8 +18,8 @@ using System;
+ using System.Diagnostics;
+ using System.Security;
+ using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation;
+-using OpenTelemetry.Trace;
+ using OpenTelemetry.Metrics;
++using OpenTelemetry.Trace;
+
+ namespace OpenTelemetry.Exporter
+ {","unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution."
+2802,"@@ -1,9 +1,8 @@
+ # -*- coding: UTF-8 -*-
+-#globalCommands.py
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2006-2018 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Łukasz Golonka
++# Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Łukasz Golonka, Jakub Lukowicz
+
+ import time
+ import itertools",Feel free to remove this line
+2803,"@@ -25,7 +25,7 @@ module Subscriptions
+   end
+
+   def click_upcase_call_to_action_in_header
+-    click_link ""Upcase Membership""
++    click_link I18n.t(""shared.subscriptions.single_user"")
+   end
+
+   def settings_page",~~Should this match the key updated above?~~ :+1:
+2804,"@@ -180,7 +180,9 @@ func isDirExcludedByFile(dir, tagFilename, header string) bool {
+ 		Warnf(""could not open exclusion tagfile: %v"", err)
+ 		return false
+ 	}
+-	defer f.Close()
++	defer func() {
++		_ = f.Close()
++	}()
+ 	buf := make([]byte, len(header))
+ 	_, err = io.ReadFull(f, buf)
+ 	// EOF is handled with a dedicated message, otherwise the warning were too cryptic",`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`.
+2805,"@@ -10,11 +10,10 @@ import (
+
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/porcelain""
+-	""github.com/filecoin-project/go-filecoin/types""
+ )
+
+ // MinerCreate runs the `miner create` command against the filecoin process
+-func (f *Filecoin) MinerCreate(ctx context.Context, pledge uint64, collateral *types.AttoFIL, options ...ActionOption) (address.Address, error) {
++func (f *Filecoin) MinerCreate(ctx context.Context, pledge uint64, collateral *big.Int, options ...ActionOption) (address.Address, error) {
+ 	var out address.Address
+
+ 	sPledge := fmt.Sprintf(""%d"", pledge)",collateral is in FIL
+2806,"@@ -84,6 +84,11 @@ func (q *ChannelEventQueue) dispatchMessage() {
+ 			log.LOGGER.Warnf(""node id is not found in the message"")
+ 			continue
+ 		}
++		_, ok := q.channelPool.Load(nodeID)
++		if !ok {
++			rChannel := make(chan model.Event, rChanBufSize)
++			q.channelPool.LoadOrStore(nodeID, rChannel)
++		}
+ 		rChannel, err := q.getRChannel(nodeID)
+ 		if err != nil {
+ 			log.LOGGER.Infof(""fail to get dispatch channel for %s"", nodeID)",We should not create channel of node which are not connected.
+2807,"@@ -40,6 +40,7 @@ class MongoCredentials {
+    * @param {string} [options.username] The username used for authentication
+    * @param {string} [options.password] The password used for authentication
+    * @param {string} [options.source] The database that the user should authenticate against
++   * @param {string} [options.db] see options.source
+    * @param {string} [options.mechanism] The method used to authenticate
+    * @param {object} [options.mechanismProperties] Special properties used by some types of auth mechanisms
+    */","I think the docstring should say something like ""Alias for the `source` option"" or something similar."
+2808,"@@ -129,6 +129,14 @@ public class Product implements Serializable {
+     private String nutritionDataPer;
+     @JsonProperty(""no_nutrition_data"")
+     private String noNutritionData;
++    @JsonProperty(""other_information_fr"")
++    private String otherInformation;
++    @JsonProperty(""conservation_conditions_fr"")
++    private String conservationConditions;
++    @JsonProperty(""recycling_instructions_to_discard_fr"")
++    private String recyclingInstructionsToDiscard;
++    @JsonProperty(""recycling_instructions_to_recycle_fr"")
++    private String recyclingInstructionsToRecycle;
+     @JsonProperty(""warning"")
+     private String warning;
+     @JsonProperty(""customer_service"")",Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned
+2809,"@@ -132,6 +132,7 @@ struct st_h2o_http3client_req_t {
+ static int handle_input_expect_data_frame(struct st_h2o_http3client_req_t *req, const uint8_t **src, const uint8_t *src_end,
+                                           int err, const char **err_desc);
+ static void start_request(struct st_h2o_http3client_req_t *req);
++static void destroy_request(struct st_h2o_http3client_req_t *req);
+
+ static struct st_h2o_http3client_conn_t *find_connection_for_origin(h2o_httpclient_ctx_t *ctx, const h2o_url_scheme_t *scheme,
+                                                                     h2o_iovec_t authority)",Declaration here is `static` but the definition at the bottom is non-static?
+2810,"@@ -65,6 +65,9 @@ type WriterOptions struct {
+ 	// write in a single request, if supported. Larger objects will be split into
+ 	// multiple requests.
+ 	BufferSize int
++	// Content-MD5 which may be used as a message integrity check (MIC)
++	// https://tools.ietf.org/html/rfc1864
++	ContentMD5 string
+ 	// Metadata holds key/value strings to be associated with the blob.
+ 	// Keys are guaranteed to be non-empty and lowercased.
+ 	Metadata map[string]string","Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`."
+2811,"@@ -610,11 +610,11 @@ func (i *Initializer) configureGatewayInterface(gatewayIface *interfacestore.Int
+ 	gatewayIface.IPs = []net.IP{}
+ 	if i.networkConfig.TrafficEncapMode.IsNetworkPolicyOnly() {
+ 		// Assign IP to gw as required by SpoofGuard.
+-		if i.nodeConfig.NodeIPv4Addr != nil {
++		if i.nodeConfig.NodeTransportIPv4Addr != nil {
+ 			i.nodeConfig.GatewayConfig.IPv4 = i.nodeConfig.NodeTransportIPv4Addr.IP
+ 			gatewayIface.IPs = append(gatewayIface.IPs, i.nodeConfig.NodeTransportIPv4Addr.IP)
+ 		}
+-		if i.nodeConfig.NodeIPv6Addr != nil {
++		if i.nodeConfig.NodeTransportIPv6Addr != nil {
+ 			i.nodeConfig.GatewayConfig.IPv6 = i.nodeConfig.NodeTransportIPv6Addr.IP
+ 			gatewayIface.IPs = append(gatewayIface.IPs, i.nodeConfig.NodeTransportIPv6Addr.IP)
+ 		}",Was it a bug?
+2812,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done
+2813,"@@ -66,6 +66,7 @@ def replace_variables(win_id, arglist):
+         'url:host': lambda: _current_url(tabbed_browser).host(),
+         'clipboard': utils.get_clipboard,
+         'primary': lambda: utils.get_clipboard(selection=True),
++        'link_hovered': lambda: tabbed_browser._now_focused._last_hovered_link,
+     }
+     for key in list(variables):
+         modified_key = '{' + key + '}'","You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead."
+2814,"@@ -0,0 +1,10 @@
++class InvitationMailer < BaseMailer
++  def invitation(invitation_id)
++    @invitation = Invitation.find(invitation_id)
++
++    mail(
++      to: @invitation.email,
++      subject: 'Invitation'
++    )
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+2815,"@@ -0,0 +1,15 @@
++namespace Fixtures.Azure.SwaggerBatSubscriptionIdApiVersion
++{
++    using System;
++    using System.Collections;
++    using System.Collections.Generic;
++    using System.Threading;
++    using System.Threading.Tasks;
++    using Microsoft.Rest;
++    using Microsoft.Azure;
++    using Models;
++
++    public static partial class MicrosoftAzureTestUrlExtensions
++    {
++    }
++}",We should file a bug for this - we don't need the extensions class if there are no operations on the client
+2816,"@@ -415,6 +415,8 @@ func (p *csiPlugin) NewMounter(
+ 	}
+ 	klog.V(4).Info(log(""created path successfully [%s]"", dataDir))
+
++	mounter.MetricsProvider = NewMetricsCsi(volumeHandle, dir, csiDriverName(driverName))
++
+ 	// persist volume info data for teardown
+ 	node := string(p.host.GetNodeName())
+ 	volData := map[string]string{",Is it possible to import from k8s instead of copy in? :)
+2817,"@@ -25,7 +25,7 @@ class ProjectCacheProvider extends \Psalm\Internal\Provider\ProjectCacheProvider
+      *
+      * @return void
+      */
+-    public function processSuccessfulRun($start_time)
++    public function processSuccessfulRun(float $start_time)
+     {
+         $this->last_run = (int) $start_time;
+     }",`@param float` can be dropped here.
+2818,"@@ -35,7 +35,7 @@ import java.util.NoSuchElementException;
+ public abstract class CoprocessIterator<T> implements Iterator<T> {
+   protected final TiSession session;
+   protected final List<RegionTask> regionTasks;
+-  protected final DAGRequest dagRequest;
++  protected DAGRequest dagRequest;
+   protected final DataType[] handleTypes;
+   //  protected final ExecutorCompletionService<Iterator<SelectResponse>> completionService;
+   protected RowReader rowReader;",maybe we can leave this change un-reverted.
+2819,"@@ -5,7 +5,7 @@
+
+ package net.sourceforge.pmd.lang.java.ast;
+
+-public class ASTMethodDeclarator extends AbstractJavaNode {
++public class ASTMethodDeclarator extends AbstractJavaAccessNode {
+     public ASTMethodDeclarator(int id) {
+         super(id);
+     }","I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode"
+2820,"@@ -0,0 +1,16 @@
++package net.runelite.api.events.player.headicon;
++
++import lombok.Getter;
++import net.runelite.api.Player;
++import net.runelite.api.events.Event;
++
++public abstract class PlayerHeadIconChanged implements Event
++{
++	@Getter
++	private final Player player;
++
++	public PlayerHeadIconChanged(Player player)
++	{
++		this.player = player;
++	}
++}",delete this class
+2821,"@@ -378,7 +378,7 @@ window.PopulatorView = countlyView.extend({
+             if ([""true"", ""false""].indexOf(s) !== -1) {
+                 return s === ""true"";
+             }
+-            else if (/^[1-9][0-9]+|0$/.test(s)) {
++            else if (/^[1-9][0-9]+|0|[1-9]$/.test(s)) {
+                 return parseInt(s);
+             }
+             else {",Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick.
+2822,"@@ -58,7 +58,7 @@ TDTWriter::TDTWriter(std::ostream *outStream, bool takeOwnership) {
+   df_writeNames = true;
+ }
+
+-TDTWriter::~TDTWriter() throw() {
++TDTWriter::~TDTWriter() {
+   // close the writer if it's still open:
+   if (dp_ostream != nullptr) close();
+ }",I've been meaning to fix this for a while. Thanks.
+2823,"@@ -27,10 +27,12 @@ public class Program
+     {
+         using var otel = Sdk.CreateTracerProvider(b => b
+             .AddActivitySource(""MyCompany.MyProduct.MyLibrary"")
+-            .AddProcessorPipeline(pipeline =>
+-            {
+-                pipeline.AddProcessor(current => new MyActivityProcessor());
+-            }));
++
++            // TODO: seems buggy if you remove A and B here, MyActivityProcessor(C).OnEnd is not called.
++            // TODO: should the dispose order be C, B, A or A, B C?
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""A"")))
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""B"")))
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""C""))));
+
+         using (var activity = MyActivitySource.StartActivity(""SayHello""))
+         {","This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?"
+2824,"@@ -11,13 +11,14 @@ from __future__ import absolute_import
+ from __future__ import print_function
+ from scapy.error import Scapy_Exception
+ import scapy.modules.six as six
++from scapy.compat import *
+
+ ###############################
+ ## Direct Access dictionary  ##
+ ###############################
+
+ def fixname(x):
+-    if x and x[0] in ""0123456789"":
++    if x and str(x[0]) in ""0123456789"":
+         x = ""n_""+x
+     return x.translate(""________________________________________________0123456789_______ABCDEFGHIJKLMNOPQRSTUVWXYZ______abcdefghijklmnopqrstuvwxyz_____________________________________________________________________________________________________________________________________"")
+ ","If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?"
+2825,"@@ -96,8 +96,8 @@ public class TwoPhaseCommitter {
+    */
+   private static final int TXN_COMMIT_BATCH_SIZE = 768 * 1024;
+
+-  /** unit is second */
+-  private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3000;
++  /** unit is millisecond */
++  private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3600000;
+
+   private static final long MAX_RETRY_TIMES = 3;
+ ",3.6 seconds? what does it stand for?
+2826,"@@ -834,6 +834,19 @@ module Beaker
+         sign_certificate_for(default)
+       end
+
++      # Get a facter fact from a provided host
++      #
++      # @param [Host] host  The host to query the fact for
++      # @param [String] name The name of the fact to query for
++      # @!macro common_opts
++      #
++      # @returns String The value of the fact 'name' on the provided host
++      # @raise  [FailTest] Raises an exception if call to facter fails
++      def fact host, name, opts= {}
++        result = on host, facter(name, opts)
++        result.stdout.chomp
++      end
++
+     end
+   end
+ end","If the command fails, is stdout nil or """"?"
+2827,"@@ -84,10 +84,10 @@ public interface AutoRestValidationTest {
+      * used by Retrofit to perform actually REST calls.
+      */
+     interface AutoRestValidationTestService {
+-        @GET(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}"")
++        @GET(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}"")
+         Call<ResponseBody> validationOfMethodParameters(@Path(""subscriptionId"") String subscriptionId, @Path(""resourceGroupName"") String resourceGroupName, @Path(""id"") int id, @Query(""apiVersion"") String apiVersion);
+
+-        @PUT(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}"")
++        @PUT(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}"")
+         Call<ResponseBody> validationOfBody(@Path(""subscriptionId"") String subscriptionId, @Path(""resourceGroupName"") String resourceGroupName, @Path(""id"") int id, @Body Product body, @Query(""apiVersion"") String apiVersion);
+
+     }",Why is api-version now removed in the generated code?
+2828,"@@ -0,0 +1,3 @@
++from mmdet.utils import Registry
++
++OPTIMIZERS = Registry('optimizer')",We may register all built-in optimizers of PyTorch here to simplify the builder.
+2829,"@@ -109,7 +109,8 @@ std::string BaseGenerator::WrapInNameSpace(const Namespace *ns,
+                                            const std::string &name) const {
+   if (CurrentNameSpace() == ns) return name;
+   std::string qualified_name = qualifying_start_;
+-  for (auto it = ns->components.begin(); it != ns->components.end(); ++it)
++  auto &components = ns->components;
++  for (auto it = components.begin(); it != components.end(); ++it)
+     qualified_name += *it + qualifying_separator_;
+   return qualified_name + name;
+ }",No need for this new variable.
+2830,"@@ -87,11 +87,11 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			c._vnode = newVNode;
+
+ 			// Invoke getDerivedStateFromProps
+-			let s = c._nextState || c.state;
++			if (c._nextState==null) {
++				c._nextState = c.state;
++			}
+ 			if (newType.getDerivedStateFromProps!=null) {
+-				oldState = assign({}, c.state);
+-				if (s===c.state) s = c._nextState = assign({}, s);
+-				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
++				c.setState(newType.getDerivedStateFromProps(newVNode.props, c._nextState));
+ 			}
+
+ 			// Invoke pre-render lifecycle methods",doesn't this enqueue a double render or is that safeguarded somehow
+2831,"@@ -878,7 +878,9 @@ func (a *Account) randomClient() *client {
+ 	}
+ 	var c *client
+ 	for c = range a.clients {
+-		break
++		if c.acc == a {
++			break
++		}
+ 	}
+ 	return c
+ }",But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route.
+2832,"@@ -194,7 +194,18 @@ std::shared_ptr<Engine> ADIOS::Open(const std::string &name,
+                                     ""HDF5 library, can't use HDF5\n"");
+ #endif
+     }
+-
++    else if (type == ""HDF5Reader"") // -Junmin
++    {
++//#if defined(ADIOS_HAVE_PHDF5) && defined(ADIOS_HAVE_MPI)
++#ifdef ADIOS_HAVE_PHDF5
++        //#ifdef ADIOS_HAVE_MPI
++        return std::make_shared<HDF5Reader>(*this, name, accessMode, mpiComm,
++                                            method);
++#else
++        throw std::invalid_argument(""ERROR: this version didn't compile with ""
++                                    ""HDF5 library, can't use HDF5\n"");
++#endif
++    }
+     else
+     {
+         if (m_DebugMode == true)","Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`"
+2833,"@@ -282,6 +282,7 @@ module RSpec
+           context ""with a non-string and a string"" do
+             it ""concats the args"" do
+               expect(group_value_for Object, 'group').to eq(""Object group"")
++              expect(group_value_for 'group', Object).to eq(""group Object"")
+             end
+           end
+ ","Would be nice to put this in a separate context named `""with a string and a non-string""` (since that's what it is -- it's definitely not a non-string and a string!)."
+2834,"@@ -1265,7 +1265,7 @@ void ResStatisticsStatement::setStatistics(SRVR_STMT_HDL *pSrvrStmt, SQLSTATS_TY
+ #define MAX_PERTABLE_STATS_DESC		30
+
+ #define MAX_MASTERSTATS_ENTRY		31
+-#define MAX_MEASSTATS_ENTRY			34
++#define MAX_MEASSTATS_ENTRY			26
+ #define MAX_PERTABLE_ENTRY			14
+
+ 	int i;",Should MAX_PERTABLE_ENTRY here be 10 ?
+2835,"@@ -29,6 +29,17 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+         private static readonly ArraySegment<byte> _emptyData = new ArraySegment<byte>(new byte[0]);
+         private static readonly byte[] _hex = Encoding.ASCII.GetBytes(""0123456789abcdef"");
+
++        private static readonly byte[] _bytesConnectionClose = Encoding.ASCII.GetBytes(""\r\nConnection: close"");
++        private static readonly byte[] _bytesConnectionKeepAlive = Encoding.ASCII.GetBytes(""\r\nConnection: keep-alive"");
++        private static readonly byte[] _bytesTransferEncodingChunked = Encoding.ASCII.GetBytes(""\r\nTransfer-Encoding: chunked"");
++        private static readonly byte[] _bytesHttpVersion1_0 = Encoding.ASCII.GetBytes(""HTTP/1.0 "");
++        private static readonly byte[] _bytesHttpVersion1_1 = Encoding.ASCII.GetBytes(""HTTP/1.1 "");
++        private static readonly byte[] _bytesContentLengthZero = Encoding.ASCII.GetBytes(""\r\nContent-Length: 0"");
++        private static readonly byte[] _bytesSpace = Encoding.ASCII.GetBytes("" "");
++        private static readonly byte[] _bytesServer = Encoding.ASCII.GetBytes(""\r\nServer: Kestrel"");
++        private static readonly byte[] _bytesDate = Encoding.ASCII.GetBytes(""Date: "");
++        private static readonly byte[] _bytesEndHeaders = Encoding.ASCII.GetBytes(""\r\n\r\n"");
++
+         private readonly object _onStartingSync = new Object();
+         private readonly object _onCompletedSync = new Object();
+         private readonly FrameRequestHeaders _requestHeaders = new FrameRequestHeaders();",Should move these out of frame into a static class? Similar to reason phrases?
+2836,"@@ -608,7 +608,7 @@ std::vector<RouteStep> buildIntersections(std::vector<RouteStep> steps)
+     {
+         auto &step = steps[step_index];
+         const auto instruction = step.maneuver.instruction;
+-        if (instruction.type == TurnType::Suppressed)
++        if (instruction.type == TurnType::Suppressed || instruction.type == TurnType::UseLane)
+         {
+             BOOST_ASSERT(steps[last_valid_instruction].mode == step.mode);
+             // count intersections. We cannot use exit, since intersections can follow directly",That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?
+2837,"@@ -21,14 +21,13 @@ import (
+
+ 	""github.com/iotexproject/go-pkgs/hash""
+ 	""github.com/iotexproject/iotex-address/address""
+-	""github.com/iotexproject/iotex-proto/golang/iotextypes""
+-
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/db/trie""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/state""
++	""github.com/iotexproject/iotex-proto/golang/iotextypes""
+ )
+
+ type (","no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs"
+2838,"@@ -600,6 +600,14 @@ static void
+ app_exit_event(void)
+ {
+     check_stack_alignment();
++
++#if defined(LINUX) && defined(X86_64)
++    /* i#4335: Test allocation of more than 2.8GB in unreachable heap */
++    for (int i = 0; i != 50; ++i)
++    {
++        malloc(100000000);
++    }
++#endif
+ }
+
+ DR_EXPORT void",Looks like a clang-format style violation: should turn Travis red.
+2839,"@@ -127,6 +127,11 @@ MESSAGE
+
+       # Run all examples if none match the configured filters (default: `false`).
+       add_setting :run_all_when_everything_filtered
++
++      # Allow user to configure their own success/pending/failure colors
++      add_setting :success_color
++      add_setting :pending_color
++      add_setting :failure_color
+
+       # Seed for random ordering (default: generated randomly each run).
+       #","I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that."
+2840,"@@ -31,6 +31,13 @@ import { STORE_NAME, AMP_MODE_PRIMARY, AMP_MODE_SECONDARY } from './constants';
+
+ const { createRegistrySelector } = Data;
+
++function getSiteInfoProperty( propName ) {
++	return createRegistrySelector( ( select ) => () => {
++		const siteInfo = select( STORE_NAME ).getSiteInfo() || {};
++		return siteInfo[ propName ];
++	} );
++}
++
+ // Actions
+ const RECEIVE_SITE_INFO = 'RECEIVE_SITE_INFO';
+ ","Not sure if this needs a doc block or not since it's completely internal, but   for cleaning this up. (@felixarntz docs?)"
+2841,"@@ -616,7 +616,8 @@ libponyc.benchmarks.buildoptions += -DLLVM_BUILD_MODE=$(LLVM_BUILD_MODE)
+
+ libgbenchmark.buildoptions := \
+   -Wshadow -pedantic -pedantic-errors \
+-  -Wfloat-equal -fstrict-aliasing -Wstrict-aliasing -Wno-invalid-offsetof \
++  -fstrict-aliasing -Wstrict-aliasing \
++  -Wno-invalid-offsetof -Wno-deprecated-declarations \
+   -DHAVE_POSIX_REGEX -DHAVE_STD_REGEX -DHAVE_STEADY_CLOCK
+
+ ifneq ($(ALPINE),)",The change here is to address what exactly?
+2842,"@@ -101,9 +101,14 @@ const (
+ // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob.
+ type Options struct {
+ 	// Credential represents the authorizer for SignedURL.
+-	// Required to use SignedURL.
++	// Required to use SignedURL. If you're using MSI for authentication, this will
++	// attempt to be loaded lazily the first time you call SignedURL.
+ 	Credential azblob.StorageAccountCredential
+
++	// IsMSIEnvironment represents if the blob storage is being authenticated via
++	// a Managed System Identity.
++	IsMSIEnvironment bool
++
+ 	// SASToken can be provided along with anonymous credentials to use
+ 	// delegated privileges.
+ 	// See https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1#shared-access-signature-parameters.","Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`."
+2843,"@@ -23,7 +23,7 @@
+
+ ExplicitBitVect::ExplicitBitVect(unsigned int size, bool bitsSet) {
+   d_size = 0;
+-  dp_bits = 0;
++  dp_bits = nullptr;
+   d_numOnBits = 0;
+   _initForSize(size);
+   if (bitsSet) {",Was this done automatically or by hand?
+2844,"@@ -136,6 +136,18 @@ module Bolt
+       end
+       private :expand_targets
+
++      def remove_target(current_group, target, desired_group)
++        if current_group.name == desired_group
++          current_group.remove_target(target)
++        end
++        current_group.groups.each do |child_group|
++          # If target was in current group, remove it from all child groups
++          desired_group = child_group.name if current_group.name == desired_group
++          remove_target(child_group, target, desired_group)
++        end
++      end
++      private :remove_target
++
+       def add_target(current_group, target, desired_group)
+         if current_group.name == desired_group
+           current_group.add_target(target)","This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?"
+2845,"@@ -3194,7 +3194,7 @@ void CoreChecks::PostCallRecordCreateDevice(VkPhysicalDevice gpu, const VkDevice
+             std::copy(std::istreambuf_iterator<char>(read_file), {}, std::back_inserter(validation_cache_data));
+             read_file.close();
+         } else {
+-            LogInfo(core_checks->device, ""VUID-NONE"",
++            LogInfo(core_checks->device, ""UNASSIGNED-cache-file-error"",
+                     ""Cannot open shader validation cache at %s for reading (it may not exist yet)"",
+                     core_checks->validation_cache_path.c_str());
+         }",Should this be a constant somewhere?
+2846,"@@ -17,5 +17,9 @@
+ using System.Runtime.CompilerServices;
+
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Tests"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.Http"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.AspNet"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.AspNetCore"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.GrpcNetClient"" + AssemblyInfo.PublicKey)]
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"" + AssemblyInfo.MoqPublicKey)]
+ [assembly: InternalsVisibleTo(""Benchmarks"" + AssemblyInfo.PublicKey)]",nit: sort alphabetically.
+2847,"@@ -28,6 +28,10 @@ import org.apache.solr.common.SolrException;
+  * @lucene.internal
+  */
+ class JsonQueryConverter {
++  public static final String paramsPrefix = ""_tt"";
++
++  public static final Object contextKey = JsonQueryConverter.class.getSimpleName();
++
+   private int numParams = 0;
+
+   String toLocalParams(Object jsonQueryObject, Map<String, String[]> additionalParams) {","Now, It's redundant, I suppose."
+2848,"@@ -70,6 +70,8 @@ type ChooserList interface {
+ //
+ // peerlist.List and ListImplementation compose well with sharding schemes the
+ // degenerate to returning the only available peer.
++//
++// Deprecated in favor of ""go.uber.org/yarpc/peer/peerlist/v2"".Implementation.
+ type ListImplementation interface {
+ 	transport.Lifecycle
+ ","nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use ""go.uber.org/yarpc/peer/peerlist/v2"".Implementation instead."
+2849,"@@ -41,9 +41,9 @@ func lookupTelemetryEndpoint(cfg config.Local, genesisNetwork protocol.NetworkID
+ 	for _, bootstrapID := range bootstrapArray {
+ 		addrs, err := ReadFromSRV(""telemetry"", bootstrapID, cfg.FallbackDNSResolverAddress)
+ 		if err != nil {
+-			log.Warnf(""An issue occurred reading telemetry entry for: %s"", bootstrapID)
++			log.Infof(""An issue occurred reading telemetry entry for: %s"", bootstrapID)
+ 		} else if len(addrs) == 0 {
+-			log.Warnf(""No telemetry entry for: %s"", bootstrapID)
++			log.Infof(""No telemetry entry for: %s"", bootstrapID)
+ 		} else {
+ 			return addrs[0]
+ 		}","nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well."
+2850,"@@ -4,7 +4,16 @@ namespace Datadog.Trace.ClrProfiler
+ {
+     internal static class NativeMethods
+     {
+-        [DllImport(""Datadog.Trace.ClrProfiler.Native.dll"")]
+-        public static extern bool IsProfilerAttached();
++        public static class Windows
++        {
++            [DllImport(""Datadog.Trace.ClrProfiler.Native.dll"")]
++            public static extern bool IsProfilerAttached();
++        }
++
++        public static class Linux
++        {
++            [DllImport(""Datadog.Trace.ClrProfiler.Native.so"")]
++            public static extern bool IsProfilerAttached();
++        }
+     }
+ }","I believe this can be fixed with the original code if you just omit the "".dll"" file extension so it reads `[DllImport(""Datadog.Trace.ClrProfiler.Native"")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`."
+2851,"@@ -71,6 +71,11 @@ class UpdateManager {
+                 UserPreferences.setEpisodeCleanupValue(oldValueInDays * 24);
+             } // else 0 or special negative values, no change needed
+         }
++        if (oldVersionCode < 1070197) {
++            if (prefs.getBoolean(UserPreferences.PREF_MOBILE_UPDATE_OLD, false)) {
++                prefs.edit().putString(UserPreferences.PREF_MOBILE_UPDATE, ""everything"").apply();
++            }
++        }
+     }
+
+ }","couldn't we just read the boolean as a string (I would assume that this return ""true"" or ""false""), migrate if to its new value and keep using the same pref key?"
+2852,"@@ -126,6 +126,7 @@ static int skip_file_check = 0;
+
+ static int cache_mode = 1;
+
++static int json_input = 0;
+ static int jx_input = 0;
+ static char *jx_context = NULL;
+ ","If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know."
+2853,"@@ -40,12 +40,12 @@ namespace Microsoft.Sarif.Viewer
+         {
+             if (serviceProvider == null)
+             {
+-                throw new ArgumentNullException(""serviceProvider"");
++                throw new ArgumentNullException(nameof(serviceProvider));
+             }
+
+             if (region == null)
+             {
+-                throw new ArgumentNullException(""location"");
++                throw new ArgumentNullException(nameof(region));
+             }
+
+             m_serviceProvider = serviceProvider;",This one was wrong.
+2854,"@@ -1697,9 +1697,14 @@ type Observer interface {
+ 	// updated locally, but not yet saved at the server.
+ 	LocalChange(ctx context.Context, node Node, write WriteRange)
+ 	// BatchChanges announces that the nodes have all been updated
+-	// together atomically.  Each NodeChange in changes affects the
+-	// same top-level folder and branch.
+-	BatchChanges(ctx context.Context, changes []NodeChange)
++	// together atomically.  Each NodeChange in `changes` affects the
++	// same top-level folder and branch. `allAffectedNodeIDs` is a
++	// list of all the nodes that had their underlying data changed,
++	// even if it wasn't an user-visible change (e.g., if a
++	// subdirectory was updated, the directory block for the TLF root
++	// is updated but that wouldn't be visible to a user).
++	BatchChanges(ctx context.Context, changes []NodeChange,
++		allAffectedNodeIDs []NodeID)
+ 	// TlfHandleChange announces that the handle of the corresponding
+ 	// folder branch has changed, likely due to previously-unresolved
+ 	// assertions becoming resolved.  This indicates that the listener",What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected.
+2855,"@@ -1065,7 +1065,6 @@ error:
+  * process, mode_switch_buf_sz is maximum size for switch code, and
+  * mode_switch_data is the address where the app stack pointer is stored.
+  */
+-
+ static size_t
+ generate_switch_mode_jmp_to_hook(HANDLE phandle, byte *local_code_buf,
+                                  byte *mode_switch_buf, byte *hook_location,","> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64."
+2856,"@@ -200,6 +200,12 @@ module RSpec::Core
+         @exception_presenter.fully_formatted(failure_number, colorizer)
+       end
+
++      # @return [Array] The failure information fully formatted in the way that
++      #   RSpec's built-in formatters emit, split by line.
++      def fully_formatted_lines(failure_number, colorizer=::RSpec::Core::Formatters::ConsoleCodes)
++        @exception_presenter.fully_formatted_lines(failure_number, colorizer)
++      end
++
+     private
+
+       def initialize(example, exception_presenter=Formatters::ExceptionPresenter::Factory.new(example).build)","Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already."
+2857,"@@ -14,18 +14,10 @@
+  */
+ package com.google.api.codegen;
+
+-/**
+- * A SnippetSetRunner takes the element, snippet file, and context as input and then uses the
+- * Snippet Set templating engine to generate an output document.
+- */
++/** Defines the SNIPPET_RESOURCE_ROOT. */
+ public final class SnippetSetRunner {
+
+   /** The path to the root of snippet resources. */
+   public static final String SNIPPET_RESOURCE_ROOT =
+       SnippetSetRunner.class.getPackage().getName().replace('.', '/');
+-
+-  public interface Generator<Element> {
+-    /** Runs the code generation. */
+-    GeneratedResult generate(Element element, String snippetFileName, CodegenContext context);
+-  }
+ }",Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?
+2858,"@@ -60,6 +60,10 @@ type rule struct {
+ 	// The parent Policy ID. Used to identify rules belong to a specified
+ 	// policy for deletion.
+ 	PolicyUID types.UID
++	// The metadata of parent Policy. Used to associate the rule with Policy
++	// for troubleshooting purpose (logging and CLI).
++	PolicyName      string
++	PolicyNamespace string
+ }
+
+ // hashRule calculates a string based on the rule's content.","Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?"
+2859,"@@ -11,7 +11,6 @@ import (
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/client-go/tools/cache""
+-	""k8s.io/client-go/util/workqueue""
+ 	""k8s.io/klog""
+
+ 	beehiveContext ""github.com/kubeedge/beehive/pkg/core/context""","For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?"
+2860,"@@ -865,7 +865,8 @@ public abstract class ProcessEngineConfigurationImpl extends ProcessEngineConfig
+
+
+   // telemetry ///////////////////////////////////////////////////////
+-  protected boolean telemetryEnabled = false;
++  /** if set to true the telemetry will be enabled from the first engine start*/
++  protected boolean telemetryInitialized = false;
+   /** The endpoint which telemetry is sent to */
+   protected String telemetryEndpoint = ""https://api.telemetry.camunda.cloud/pings"";
+ ","I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime."
+2861,"@@ -105,5 +105,10 @@ namespace Microsoft.Rest.Generator.NodeJS
+                 return requiredParams.ToString();
+             }
+         }
++
++        public bool ContainsTimeSpan
++        {
++            get { return this.Methods.FirstOrDefault(m => m.Parameters.FirstOrDefault(p => p.Type == PrimaryType.TimeSpan) != null) != null; }
++        }
+     }
+ }",please use new line to maintain reasonable line width
+2862,"@@ -67,6 +67,9 @@ func (s *server) fileUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 	var fileSize uint64
+
+ 	ta := s.createTag(w, r)
++	if ta == nil {
++		return
++	}
+
+ 	// Add the tag to the context
+ 	r = r.WithContext(context.WithValue(r.Context(), tags.TagsContextKey{}, ta))",I would skip this check or add an internal server error response.
+2863,"@@ -7,6 +7,12 @@ const createDist = (buildConfig = config.defaultBuildConfig, options) => {
+   config.buildConfig = buildConfig
+   config.update(options)
+
++  if (config.notarize) {
++    notarize = config.notarize
++    notary_user = config.notary_user
++    notary_password = config.notary_password
++  }
++
+   util.updateBranding()
+   fs.removeSync(path.join(config.outputDir, 'dist'))
+   config.buildTarget = 'create_dist'",missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one
+2864,"@@ -538,11 +538,10 @@ func TestDdevImportDB(t *testing.T) {
+ 				assert.True(settingsHashSalt)
+ 			case ""wordpress"":
+ 				// nolint: vetshadow
+-				hasAuthSalt, err := fileutil.FgrepStringInFile(app.SiteSettingsPath, ""SECURE_AUTH_SALT"")
++				hasAuthSalt, err := fileutil.FgrepStringInFile(app.SiteLocalSettingsPath, ""SECURE_AUTH_SALT"")
+ 				assert.NoError(err)
+ 				assert.True(hasAuthSalt)
+ 			}
+-
+ 		}
+
+ 		if site.DBTarURL != """" {","This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath."
+2865,"@@ -26,10 +26,13 @@ import (
+ 	""os/exec""
+ 	""path/filepath""
+ 	""strings""
++
++	ecpb ""kythe.io/kythe/proto/extraction_config_go_proto""
+ )
+
+ // kytheConfigFileName The name of the Kythe extraction config
+ const kytheExtractionConfigFile = "".kythe-extraction-config""
++const defaultConfigDir = ""kythe/go/extractors/config/default""
+
+ // Repo is a container of input/output parameters for doing extraction on remote
+ // repositories.",It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?
+2866,"@@ -29,12 +29,15 @@ func Agent(config *config.Agent) error {
+ 	defer logs.FlushLogs()
+
+ 	startKubelet(config)
+-	startKubeProxy(config)
++
++	if !config.DisableKubeProxy {
++		return startKubeProxy(config)
++	}
+
+ 	return nil
+ }
+
+-func startKubeProxy(cfg *config.Agent) {
++func startKubeProxy(cfg *config.Agent) error {
+ 	argsMap := map[string]string{
+ 		""proxy-mode"":           ""iptables"",
+ 		""healthz-bind-address"": ""127.0.0.1"",",Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it.
+2867,"@@ -5,6 +5,8 @@ export default Ember.Controller.extend({
+   barcodeUri: function() {
+     let id = this.get('model.id');
+     let name = this.get('model.name');
++
++    /* eslint new-cap: ['error', { 'capIsNew': false }]  */
+     return Ember.$(document).JsBarcode(id, {
+       width: 1,
+       height: 20,",@btecu why is this override needed here? I'm not seeing a `new` being used here.
+2868,"@@ -2527,7 +2527,11 @@ func (s *Server) leafNodeFinishConnectProcess(c *client) {
+ 	c.mu.Unlock()
+
+ 	// Make sure we register with the account here.
+-	c.registerWithAccount(acc)
++	if err := c.registerWithAccount(acc); err != nil {
++		c.Errorf(""Registering leaf with account %s resulted in error: %v"", acc.Name, err)
++		c.closeConnection(ProtocolViolation)
++		return
++	}
+ 	s.addLeafNodeConnection(c, _EMPTY_, _EMPTY_, false)
+ 	s.initLeafNodeSmapAndSendSubs(c)
+ 	if sendSysConnectEvent {",Should it not be more something like: `MaxAccountConnectionsExceeded` here?
+2869,"@@ -180,6 +180,13 @@ func TestTrimComputeEndpoint(t *testing.T) {
+ 		parseAndValidate(t, ""-compute_endpoint_override"", ""  http://endpoint "").ComputeEndpoint)
+ }
+
++func TestTrimComputeServiceAccount(t *testing.T) {
++	assert.Equal(t, """",
++		parseAndValidate(t, ""-compute_service_account"", "" 	"").ComputeServiceAccount)
++	assert.Equal(t, ""default"",
++		parseAndValidate(t, ""-compute_service_account"", "" default	"").ComputeServiceAccount)
++}
++
+ func TestGcsLogsDisabled(t *testing.T) {
+ 	assert.False(t, parseAndValidate(t, ""-disable_gcs_logging=false"").GcsLogsDisabled)
+ 	assert.True(t, parseAndValidate(t, ""-disable_gcs_logging=true"").GcsLogsDisabled)",minor: use a non-default CE service account for testing (since default is handled in a specific way in the code)
+2870,"@@ -84,6 +84,10 @@ func TestBootstrapWindowedPoSt(t *testing.T) {
+ 	wd, _ := os.Getwd()
+ 	genCfgPath := filepath.Join(wd, "".."", ""fixtures/setup.json"")
+ 	presealPath := filepath.Join(wd, "".."", ""fixtures/genesis-sectors"")
++	// setup presealed sectors and uncomment to run test against sectors with larger sector size
++	//genCfgPath := filepath.Join(""./512"", ""setup.json"")
++	//presealPath := ""./512""
++
+ 	genTime := int64(1000000000)
+ 	blockTime := 1 * time.Second
+ 	fakeClock := clock.NewFake(time.Unix(genTime, 0))","This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop)."
+2871,"@@ -90,7 +90,9 @@ module Beaker
+       # @return nil
+       # @api public
+       def resolve_symlinks!
+-        @options[:hosts_file] = File.realpath(@options[:hosts_file]) if @options[:hosts_file]
++        if @options[:hosts_file] && !@options[:hosts_file_generated]
++          @options[:hosts_file] = File.realpath(@options[:hosts_file])
++        end
+       end
+
+       #Converts array of paths into array of fully qualified git repo URLS with expanded keywords","So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this ""option"" to detect that?"
+2872,"@@ -20,16 +20,11 @@
+
+ package http
+
+-import (
+-	""fmt""
+-
+-	""go.uber.org/yarpc/api/yarpcerrors""
+-)
+-
+-// TODO: Should we expose the maps as public variables to document the mappings?
++import ""go.uber.org/yarpc/api/yarpcerrors""
+
+ var (
+-	_codeToHTTPStatusCode = map[yarpcerrors.Code]int{
++	// CodeToStatusCode maps all Codes to their corresponding HTTP status code.
++	CodeToStatusCode = map[yarpcerrors.Code]int{
+ 		yarpcerrors.CodeOK:                 200,
+ 		yarpcerrors.CodeCancelled:          499,
+ 		yarpcerrors.CodeUnknown:            500,","Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections."
+2873,"@@ -351,6 +351,15 @@ class WebKitCaret(browsertab.AbstractCaret):
+     def selection(self, callback):
+         callback(self._widget.selectedText())
+
++    def reverse_selection(self):
++        self._tab.run_js_async(""""""{
++            let sel = window.getSelection();
++            sel.setBaseAndExtent(
++                sel.extentNode, sel.extentOffset, sel.baseNode,
++                sel.baseOffset
++            );
++        }"""""")
++
+     def _follow_selected(self, *, tab=False):
+         if QWebSettings.globalSettings().testAttribute(
+                 QWebSettings.JavascriptEnabled):",This could probably use `const` as well?
+2874,"@@ -40,7 +40,7 @@ import (
+ // file.  The Restore method replaces the contents of the original with the
+ // backup, overwriting any changes that were made since the backup was created.
+ type File struct {
+-	orig, tmp string // file paths
++	Orig, Tmp string // file paths
+ }
+
+ // New creates a backup copy of the specified file, located in the same",it doesn't look like these need to be exported?
+2875,"@@ -5,6 +5,7 @@ package fs
+ import (
+ 	""bytes""
+ 	""errors""
++	""fmt""
+ 	""io/ioutil""
+ 	""os""
+ 	""path/filepath""","I think you should remove ""fmt"" here. And change `fmt.Errorf` to `errors.Errorf`."
+2876,"@@ -0,0 +1,6 @@
++class AddVideoAttributesToProducts < ActiveRecord::Migration
++  def change
++    add_column :products, :length_in_days, :integer
++    add_column :products, :resources, :text, default: """", null: false
++  end
++end","Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else."
+2877,"@@ -11,7 +11,7 @@ import (
+ // one of the workers, it is returned. FinalFunc is always run, regardless of
+ // any other previous errors.
+ func RunWorkers(ctx context.Context, count int, workerFunc func() error, finalFunc func()) error {
+-	wg, ctx := errgroup.WithContext(ctx)
++	wg, _ := errgroup.WithContext(ctx)
+
+ 	// run workers
+ 	for i := 0; i < count; i++ {","If the context is unused, this is equivalent to `var wg errgroup.Group`."
+2878,"@@ -47,6 +47,8 @@ public interface HighlightParams {
+
+   // sizing
+   public static final String FRAGSIZE    = HIGHLIGHT+"".fragsize""; // OH, FVH, UH
++  public static final String FRAGALIGNRATIO = HIGHLIGHT+"".fragAlignRatio""; // UH
++  public static final String FRAGSIZEISMINIMUM = HIGHLIGHT+"".fragsizeIsMinimum""; // UH
+   public static final String FRAGMENTER  = HIGHLIGHT+"".fragmenter""; // OH
+   public static final String INCREMENT   = HIGHLIGHT+"".increment""; // OH
+   public static final String REGEX       = ""regex""; // OH",very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize
+2879,"@@ -98,6 +98,10 @@ def is_local_interface(host):
+   if ':' in host:
+     host = host.split(':',1)[0]
+
++  # If ""localhost"" or a loopback IP has been specified it is a deliberate reference
++  if host == 'localhost' or host.startswith('127.'):
++    return False
++
+   try:
+     sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
+     sock.connect( (host, 4242) )","Given that 115 returns `True`, why would this be `False` here?"
+2880,"@@ -367,6 +367,17 @@ public class OAuth2LoginConfigurerTests {
+ 		assertThat(this.response.getRedirectedUrl()).matches(""http://localhost/oauth2/authorization/google"");
+ 	}
+
++	// gh-6802
++	@Test
++	public void oauth2LoginWithOneClientConfiguredAndFormLoginThenRedirectDefaultLoginPage() throws Exception {
++		loadConfig(OAuth2LoginConfigFormLogin.class);
++		String requestUri = ""/"";
++		this.request = new MockHttpServletRequest(""GET"", requestUri);
++		this.request.setServletPath(requestUri);
++		this.springSecurityFilterChain.doFilter(this.request, this.response, this.filterChain);
++		assertThat(this.response.getRedirectedUrl()).matches(""http://localhost/login"");
++	}
++
+ 	// gh-5347
+ 	@Test
+ 	public void oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage()",Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`
+2881,"@@ -270,6 +270,9 @@ bool LatencyTestPublisher::init(int n_sub, int n_sam, bool reliable, uint32_t pi
+     PubDataparam.topic.topicName = pt.str();
+     PubDataparam.times.heartbeatPeriod.seconds = 0;
+     PubDataparam.times.heartbeatPeriod.fraction = 4294967 * 100;
++    PubDataparam.qos.m_liveliness.lease_duration = c_TimeInfinite;
++    PubDataparam.qos.m_liveliness.announcement_period = Duration_t(1, 0);
++
+     if (!reliable)
+     {
+         PubDataparam.qos.m_reliability.kind = BEST_EFFORT_RELIABILITY_QOS;",Why this new configuration?
+2882,"@@ -245,8 +245,14 @@ public class IcebergPigInputFormat<T> extends InputFormat<Void, T> {
+
+     private Object convertPartitionValue(Type type, Object value) {
+       if (type.typeId() == Types.BinaryType.get().typeId()) {
+-        ByteBuffer buffer = (ByteBuffer) value;
+-        return new DataByteArray(buffer.get(new byte[buffer.remaining()]).array());
++        ByteBuffer dupe = ((ByteBuffer) value).duplicate();
++        if (dupe.hasArray()) {
++          return new DataByteArray(dupe.array());
++        } else {
++          byte[] bytes = new byte[dupe.remaining()];
++          dupe.get(bytes);
++          return new DataByteArray(bytes);
++        }
+       }
+
+       return value;","I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`."
+2883,"@@ -28,15 +28,15 @@ namespace OpenTelemetry.Metrics
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""SpanContext""/>.</param>
++        /// <param name=""spanReference"">the associated <see cref=""SpanReference""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in SpanContext context, T value);
++        public abstract void Add(in SpanReference spanReference, T value);
+
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""Baggage""/>.</param>
++        /// <param name=""spanReference"">the associated <see cref=""Baggage""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in Baggage context, T value);
++        public abstract void Add(in Baggage spanReference, T value);
+     }
+ }",`spanReference` -> `baggage`
+2884,"@@ -32,9 +32,8 @@ module.exports = function(config, auth, storage) {
+     });
+   });
+
+-  router.get('/-/logo', function(req, res) {
+-    res.sendFile(_.get(config, 'web.logo') || `${env.APP_ROOT}/static/logo-sm.png`
+-    );
++  router.get('/-/verdaccio/logo', function(req, res) {
++    res.send(_.get(config, 'web.logo') || '/-/static/logo.png');
+   });
+
+   router.get('/', function(req, res) {",Why the `/-/verdaccio/` ?
+2885,"@@ -478,8 +478,7 @@ func TestAppDeployOpts_pushAddonsTemplateToS3Bucket(t *testing.T) {
+
+ 			opts := appDeployOpts{
+ 				appDeployVars: appDeployVars{
+-					AppName:      tc.inputApp,
+-					enableAddons: true,
++					AppName: tc.inputApp,
+ 					GlobalOpts: &GlobalOpts{
+ 						projectName: tc.inputProject,
+ 					},",Has been waiting for a million years
+2886,"@@ -31,6 +31,10 @@ msg.Number = {};
+ msg.Number.min = ""Path `{PATH}` ({VALUE}) is less than minimum allowed value ({MIN})."";
+ msg.Number.max = ""Path `{PATH}` ({VALUE}) is more than maximum allowed value ({MAX})."";
+
++msg.Date = {};
++msg.Date.min = ""Path `{PATH}` ({VALUE}) is before than minimum allowed value ({MIN})."";
++msg.Date.max = ""Path `{PATH}` ({VALUE}) is after than maximum allowed value ({MAX})."";
++
+ msg.String = {};
+ msg.String.enum = ""`{VALUE}` is not a valid enum value for path `{PATH}`."";
+ msg.String.match = ""Path `{PATH}` is invalid ({VALUE})."";",Minor grammar detail: the 'than' is unnecessary
+2887,"@@ -4873,10 +4873,11 @@ class Series(Frame, IndexOpsMixin, Generic[T]):
+         >>> kser.item()
+         10
+         """"""
+-        item_top_two = self[:2]
++        scol = self.spark_column
++        item_top_two = self._internal._sdf.select(scol).head(2)
+         if len(item_top_two) != 1:
+             raise ValueError(""can only convert an array of size 1 to a Python scalar"")
+-        return item_top_two[0]
++        return item_top_two[0][0]
+
+     def _cum(self, func, skipna, part_cols=()):
+         # This is used to cummin, cummax, cumsum, etc.",I think you can just simply fix this line to `self[:2].to_pandas()`
+2888,"@@ -1229,6 +1229,14 @@ class WebDriver {
+     if (target && cdpTargets.indexOf(target.toLowerCase()) === -1) {
+       throw new error.InvalidArgumentError('invalid target value')
+     }
++
++    if (debuggerAddress.match(/\/se\/cdp/)) {
++      if (debuggerAddress.match(""ws:\/\/"", ""http:\/\/"")) {
++        return debuggerAddress.replace(""ws:\/\/"", ""http:\/\/"")
++      }
++      return debuggerAddress
++    }
++
+     const path = '/json/version'
+     let request = new http.Request('GET', path)
+     let client = new http.HttpClient('http://' + debuggerAddress)",if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?
+2889,"@@ -20,6 +20,6 @@
+  * Internal dependencies
+  */
+ import Data from 'googlesitekit-data';
+-import { registerStore } from 'assets/js/googlesitekit/datastore/site';
++import { registerStore } from './googlesitekit/datastore/site';
+
+ registerStore( Data );",I could add a resolver for this (like above) but it seems more sensible to just change the one reference!
+2890,"@@ -44,11 +44,14 @@ public class TimestampMoreRecentThanParent implements DetachedBlockHeaderValidat
+
+   private boolean validateHeaderSufficientlyAheadOfParent(
+       final long timestamp, final long parentTimestamp) {
+-    if ((timestamp - minimumSecondsSinceParent) < parentTimestamp) {
++    final long actualTimeSinceParent = timestamp - parentTimestamp;
++    if (actualTimeSinceParent < minimumSecondsSinceParent) {
+       LOG.trace(
+-          ""Invalid block header: timestamp {} is not sufficiently newer than parent timestamp {}"",
++          ""Invalid block header: timestamp {} is only {} seconds newer than parent timestamp {}. Minimum {} seconds"",
+           timestamp,
+-          parentTimestamp);
++          actualTimeSinceParent,
++          parentTimestamp,
++          minimumSecondsSinceParent);
+       return false;
+     }
+ ","not sure ""actual"" adds value - secondsSinceParent is probably closer."
+2891,"@@ -159,7 +159,7 @@ module Blacklight::SearchHelper
+   # Get the solr response when retrieving only a single facet field
+   # @return [Blacklight::SolrResponse] the solr response
+   def get_facet_field_response(facet_field, user_params = params || {}, extra_controller_params = {})
+-    query = search_builder.with(user_params).merge(extra_controller_params).merge(solr_facet_params(facet_field, user_params, extra_controller_params))
++    query = search_builder.with(user_params).facet(facet_field).merge(extra_controller_params)
+     repository.search(query)
+   end
+ ",Line is too long. [94/80]
+2892,"@@ -585,4 +585,7 @@ return [
+         'image_size' => 'Image size:',
+         'selected_size' => 'Selected:'
+     ],
++    'repeater' => [
++        'min_items_error' => 'You cannot delete any item. You should modify the existing.'
++    ]
+ ];",The error should be `At least :number items are required`
+2893,"@@ -172,11 +172,9 @@ func (s *server) Ping(in *pb.Request, stream pb.Simulator_PingServer) error {
+ 	// message type of 1999 means that it's a dummy message to allow the engine to pass back proposed blocks
+ 	if in.InternalMsgType != dummyMsgType {
+ 		msg := CombineMsg(in.InternalMsgType, msgValue)
+-		switch msg.(type) {
+-		case *iproto.ProposePb:
+-			err = s.nodes[in.PlayerID].HandleBlockPropose(msg.(*iproto.ProposePb), done)
+-		case *iproto.EndorsePb:
+-			err = s.nodes[in.PlayerID].HandleEndorse(msg.(*iproto.EndorsePb), done)
++		switch cMsg := msg.(type) {
++		case *iproto.ConsensusPb:
++			err = s.nodes[in.PlayerID].HandleConsensusMsg(cMsg, done)
+ 		}
+ 		if err != nil {
+ 			logger.Error().Err(err).Msg(""failed to handle view change"")",singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)
+2894,"@@ -506,11 +506,7 @@ type encryptionKeyGetter interface {
+ 		kbfscrypto.TLFCryptKey, error)
+ }
+
+-// KeyManager fetches and constructs the keys needed for KBFS file
+-// operations.
+-type KeyManager interface {
+-	encryptionKeyGetter
+-
++type mdDecryptionKeyGetter interface {
+ 	// GetTLFCryptKeyForMDDecryption gets the crypt key to use for the
+ 	// TLF with the given metadata to decrypt the private portion of
+ 	// the metadata.  It finds the appropriate key from mdWithKeys",Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better.
+2895,"@@ -6316,7 +6316,8 @@ Lng32 SQL_EXEC_DeleteHbaseJNI()
+       threadContext->incrNumOfCliCalls();
+
+       HBaseClient_JNI::deleteInstance();
+-      HiveClient_JNI::deleteInstance();
++      // The Hive client persists across connections
++      // HiveClient_JNI::deleteInstance();
+    }
+    catch(...)
+    {",Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?
+2896,"@@ -22,7 +22,7 @@ const illegalCommandFields = [
+   'raw',
+   'readPreference',
+   'session',
+-  'writeConcern'
++  'readConcern'
+ ];
+
+ class CreateCollectionOperation extends CommandOperation {",Does this mean we do not support writeConcern on `createCollection`?
+2897,"@@ -36,7 +36,7 @@ func TestProducer_RequestSessionDestroy(t *testing.T) {
+ 	assert.NoError(t, err)
+
+ 	destroySender := &fakeDestroySender{}
+-	err = RequestSessionDestroy(destroySender, sid)
++	err = RequestSessionDestroy(destroySender, sid.ID)
+ 	assert.NoError(t, err)
+ }
+ ","I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`."
+2898,"@@ -379,7 +379,11 @@ func (s *Service) getSecurityGroupIngressRules(role infrav1.SecurityGroupRole) (
+ 				Protocol:    infrav1.SecurityGroupProtocolTCP,
+ 				FromPort:    6443,
+ 				ToPort:      6443,
+-				CidrBlocks:  []string{anyIPv4CidrBlock},
++				SourceSecurityGroupIDs: []string{
++					s.scope.SecurityGroups()[infrav1.SecurityGroupAPIServerLB].ID,
++					s.scope.SecurityGroups()[infrav1.SecurityGroupControlPlane].ID,
++					s.scope.SecurityGroups()[infrav1.SecurityGroupNode].ID,
++				},
+ 			},
+ 			{
+ 				Description:            ""etcd"",",We'll need `infrav1.SecurityGroupBastion` as well
+2899,"@@ -1470,6 +1470,15 @@ func Rcat(fdst fs.Fs, dstFileName string, in io.ReadCloser, modTime time.Time) (
+ 	return dst, nil
+ }
+
++// PublicLink adds a ""readable by anyone with link"" permission on the given file or folder.
++func PublicLink(f fs.Fs, fileName string) (string, error) {
++	doPublicLink := f.Features().PublicLink
++	if doPublicLink == nil {
++		return """", errors.Errorf(""%v doesn't support public links"", f)
++	}
++	return doPublicLink(fileName)
++}
++
+ // Rmdirs removes any empty directories (or directories only
+ // containing empty directories) under f, including f.
+ func Rmdirs(f fs.Fs, dir string, leaveRoot bool) error {",This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage.
+2900,"@@ -243,12 +243,12 @@ public class SmartStoreLoadTest extends InstrumentationTestCase {
+         // Without indexing for new index specs
+         alterSoup(""Adding one index / no re-indexing"", false, new IndexSpec[]{new IndexSpec(""k_0"", indexType), new IndexSpec(""k_1"", indexType)});
+         alterSoup(""Adding one index / dropping one index / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_2"", indexType)});
+-        alterSoup(""Dropping two indexes / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_3"", indexType)});
++        alterSoup(""Dropping one index / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_0"", indexType)});
+
+         // With indexing for new index specs
+         alterSoup(""Adding one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_1"", indexType)});
+         alterSoup(""Adding one index / dropping one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_2"", indexType)});
+-        alterSoup(""Dropping two indexes / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_3"", indexType)});
++        alterSoup(""Dropping one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType)});
+     }
+
+     private void alterSoup(String msg, boolean reIndexData, IndexSpec[] indexSpecs) throws JSONException {",That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing
+2901,"@@ -52,6 +52,13 @@ public class AttachmentView extends FrameLayout {
+     public String contentType;
+     public long size;
+     public ImageView iconView;
++
++    /**
++     * Regular expression that represents characters that aren't allowed
++     * to be used in file names saved using K-9
++     */
++    private static final String specialCharacters = new String(""[^\\d\\s\\w!"" +
++    		""#\\$%&'\\(\\)\\-@\\^_`\\{\\}~.,]"");
+
+     private AttachmentFileDownloadCallback callback;
+ ",Expression that uses a negation pattern to exclude all characters that aren't in the expression.
+2902,"@@ -82,6 +82,10 @@ const (
+ 	// feature is supported on the server. If any non-empty value is set,
+ 	// this indicates true.
+ 	BothResponseErrorHeader = ""Rpc-Both-Response-Error""
++
++	// Echo ServiceHeader in Request header which can be used by clients/HC to
++	// validate request went to the correct service
++	RespondServiceHeader = ""Rpc-Respond-Service-Header""
+ )
+
+ // Valid values for the Rpc-Status header.","Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead."
+2903,"@@ -135,7 +135,7 @@ func addCustomCommands(rootCmd *cobra.Command) error {
+ 				}
+
+ 				descSuffix := "" (shell "" + service + "" container command)""
+-				if serviceDirOnHost[0:1] == ""."" {
++				if commandSet == targetGlobalCommandPath {
+ 					descSuffix = "" (global shell "" + service + "" container command)""
+ 				}
+ 				commandToAdd := &cobra.Command{","The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!"
+2904,"@@ -38,7 +38,7 @@ import (
+ 	controllerconfig ""antrea.io/antrea/pkg/config/controller""
+ )
+
+-const waitEgressRealizedTimeout = 3 * time.Second
++const waitEgressRealizedTimeout = 15 * time.Second
+
+ func TestEgress(t *testing.T) {
+ 	skipIfProviderIs(t, ""kind"", ""pkt_mark field is not properly supported for OVS userspace (netdev) datapath."")",Would membership take 10+ seconds to detect the failed node?
+2905,"@@ -227,11 +227,14 @@ def _sanitize_markdown(mdtext):
+
+ def _load_introduction(path):
+     ""Loads the introduction text from a Markdown file""
++    if not os.path.exists(path):
++        return None
++
+     try:
+         with open(path) as f:
+             return _sanitize_markdown(f.read())
+-    except:
+-        return None
++    except Exception as err:
++        raise RuntimeError(f'Makrdown file ""{path}"" could not be loaded: {err}')
+
+
+ def _load_skill(path, course):","hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?"
+2906,"@@ -0,0 +1,14 @@
++package cmd
++
++import (
++	""github.com/mitchellh/go-homedir""
++	""path/filepath""
++)
++
++func GetDirectory(paths ...string) string {
++	dir, _ := homedir.Dir()
++
++	dir = filepath.Join(dir, "".mysterium"", filepath.Join(paths...))
++
++	return dir
++}",This function does not need to be public
+2907,"@@ -60,14 +60,14 @@ export default function SetupForm( { finishSetup } ) {
+ 		>
+ 			<ErrorNotice />
+
++			<ExistingTagNotice />
++
+ 			{ ( !! accounts.length && ! hasExistingTag ) && (
+-				<p>
++				<p style={ { marginBottom: 0 } }>
+ 					{ __( 'Please select the account information below. You can change this view later in your settings.', 'google-site-kit' ) }
+ 				</p>
+ 			) }
+
+-			<ExistingTagNotice />
+-
+ 			<div className=""googlesitekit-setup-module__inputs"">
+ 				<AccountSelect />
+ ",  Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set.
+2908,"@@ -119,7 +119,7 @@ namespace AutoRest.Ruby.Azure.TemplateModels
+                 if (ReturnType.Body is CompositeType)
+                 {
+                     CompositeType compositeType = (CompositeType)ReturnType.Body;
+-                    if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension))
++                    if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension) && this.Extensions.ContainsKey(""nextMethodName""))
+                     {
+                         bool isNextLinkMethod = this.Extensions.ContainsKey(""nextLinkMethod"") && (bool)this.Extensions[""nextLinkMethod""];
+                         bool isPageable = (bool)compositeType.Extensions[AzureExtensions.PageableExtension];","> && this.Extensions.ContainsKey(""nextMethodName"") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(""nextMethodName"")` condition or we don't need line 124 #Closed"
+2909,"@@ -1,16 +1,5 @@
+-import { options } from 'preact';
+ import { assign } from './util';
+
+-let oldVNodeHook = options.vnode;
+-options.vnode = vnode => {
+-	if (vnode.type && vnode.type._forwarded && vnode.ref) {
+-		vnode.props.ref = vnode.ref;
+-		vnode.ref = null;
+-	}
+-
+-	if (oldVNodeHook) oldVNodeHook(vnode);
+-};
+-
+ /**
+  * Pass ref down to a child. This is mainly used in libraries with HOCs that
+  * wrap components. Using `forwardRef` there is an easy way to get a reference",Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it.
+2910,"@@ -52,11 +52,11 @@ namespace NLog.LayoutRenderers
+         private readonly string _baseDir;
+
+ #if !SILVERLIGHT && !NETSTANDARD1_3
+-
+         /// <summary>
+         /// cached
+         /// </summary>
+         private string _processDir;
++#endif
+
+         /// <summary>
+         /// Use base dir of current process.","Please use "".NET Core 3"" - i'm trying hard to use one form, and this is the one MS advices"
+2911,"@@ -87,6 +87,11 @@ func StartSession(params *TelemetrySessionParams, statsEngine stats.Engine) erro
+ 			seelog.Errorf(""Error: lost websocket connection with ECS Telemetry service (TCS): %v"", tcsError)
+ 			params.time().Sleep(backoff.Duration())
+ 		}
++		select {
++		case <-params.Ctx.Done():
++			return nil
++		default:
++		}
+ 	}
+ }
+ ","Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited."
+2912,"@@ -29,6 +29,7 @@ import qutebrowser
+ from qutebrowser.utils import docutils
+ from qutebrowser.browser import pdfjs
+
++from end2end.features.test_scroll_bdd import check_scrolled, check_not_scrolled
+
+ bdd.scenarios('misc.feature')
+ ","Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time."
+2913,"@@ -356,7 +356,7 @@ TEST(svm_thunder_dense_test, can_classify_any_two_labels) {
+
+         auto support_indices_table = result_train.get_support_indices();
+         const auto support_indices = row_accessor<const float>(support_indices_table).pull();
+-        for (size_t i = 0; i < support_indices.get_count(); i++) {
++        for (std::int64_t i = 0; i < support_indices.get_count(); i++) {
+             ASSERT_EQ(support_indices[i], i);
+         }
+ ",Does this changes affect process building dynamic libraries anyhow?
+2914,"@@ -26,7 +26,7 @@ import struct
+ import time
+ from scapy.packet import *
+ from scapy.fields import *
+-from scapy.contrib.ppi import PPIGenericFldHdr, addPPIType
++from scapy.layers.dot11 import *
+ from scapy.error import warning
+ import scapy.modules.six as six
+ from scapy.modules.six.moves import range",Could you limit what is imported here?
+2915,"@@ -1078,12 +1078,15 @@ def do_set_function_code(lambda_function: LambdaFunction):
+     if not lambda_cwd:
+         return
+
+-    # get local lambda working directory
++    # get local lambda code archive path
+     tmp_file = os.path.join(lambda_cwd, LAMBDA_ZIP_FILE_NAME)
+
+     if not zip_file_content:
+         zip_file_content = load_file(tmp_file, mode=""rb"")
+
++    # override lambda archive with fresh code if we got an update
++    save_file(tmp_file, zip_file_content)
++
+     # Set the appropriate lambda handler.
+     lambda_handler = generic_handler
+     is_java = lambda_executors.is_java_lambda(runtime)","just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up"
+2916,"@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
+ func icmpPkt(src, dst string) packet {
+ 	return packetWithPorts(1, src+"":0"", dst+"":0"")
+ }
++func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
++	return packet{
++		protocol: 1,
++		srcAddr:  src,
++		srcPort:  0,
++		dstAddr:  dst,
++		dstPort:  (icmpCode << 8) | (icmpType),
++	}
++}
+
+ var polProgramTests = []polProgramTest{
+ 	// Tests of actions and flow control.
+-
+ 	{
+ 		PolicyName: ""no tiers"",
+ 		DroppedPackets: []packet{",Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain
+2917,"@@ -127,11 +127,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+         {
+             using (var response = await client.SendAsync(request).ConfigureAwait(false))
+             {
+-                if (response.StatusCode != HttpStatusCode.OK &&
+-                    response.StatusCode != HttpStatusCode.Accepted)
+-                {
+-                    var statusCode = (int)response.StatusCode;
+-                }
++                // disposing response
+             }
+         }
+ ",We can do away with assigning the response here too.
+2918,"@@ -18,7 +18,7 @@ function ngGridFlexibleHeightPlugin (opts) {
+                 }
+             }
+
+-            var newViewportHeight = naturalHeight + 2;
++            var newViewportHeight = naturalHeight + 3;
+             if (!self.scope.baseViewportHeight || self.scope.baseViewportHeight !== newViewportHeight) {
+                 self.grid.$viewport.css('height', newViewportHeight + 'px');
+                 self.grid.$root.css('height', (newViewportHeight + extraHeight) + 'px');",Bumping the newViewportHeight
+2919,"@@ -47,7 +47,7 @@ import org.apache.solr.util.LongIterator;
+  *   <li><a href=""https://github.com/aggregateknowledge/postgresql-hll"">postgresql-hll</a>, and</li>
+  *   <li><a href=""https://github.com/aggregateknowledge/js-hll"">js-hll</a></li>
+  * </ul>
+- * when <a href=""https://github.com/aggregateknowledge/postgresql-hll/blob/master/STORAGE.markdown"">properly serialized</a>.
++ * when <a href=""https://github.com/aggregateknowledge/postgresql-hll/blob/secondaryy/STORAGE.markdown"">properly serialized</a>.
+  */
+ public class HLL implements Cloneable {
+     // minimum and maximum values for the log-base-2 of the number of registers",Is this change correct? Looks like a typo and not sure this should be changed?
+2920,"@@ -43,6 +43,14 @@ def _read_stdin():
+     return sys.stdin.read()
+
+
++def _load_reporter_by_class(reporter_class: str) -> type:
++    qname = reporter_class
++    module_part = astroid.modutils.get_module_part(qname)
++    module = astroid.modutils.load_module_from_name(module_part)
++    class_name = qname.split(""."")[-1]
++    return getattr(module, class_name)
++
++
+ # Python Linter class #########################################################
+
+ MSGS = {",I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?
+2921,"@@ -35,4 +35,4 @@ namespace System.MathBenchmarks
+             }
+         }
+     }
+-}
++}","nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)"
+2922,"@@ -57,9 +57,16 @@ namespace AutoRest.Swagger.Model.Utilities
+                                                     .Where(modelName => !(IsBaseResourceModelName(modelName))
+                                                                         && serviceDefinition.Definitions.ContainsKey(modelName)
+                                                                         && IsAllOfOnModelNames(modelName, serviceDefinition.Definitions, xmsAzureResourceModels));
++
++            var unfilteredResourceCandidates = resourceModels.Union(modelsAllOfOnXmsAzureResources);
++
++            // Now filter all the resource models that are returned from a POST operation only
++            var postOpResourceModels = serviceDefinition.Paths.Values.SelectMany(pathObj => pathObj.Where(opObj => opObj.Key.EqualsIgnoreCase(""post""))
++                                                                     .SelectMany(opObj => opObj.Value.Responses?.Select(resp => resp.Value?.Schema?.Reference?.StripDefinitionPath())))
++                                                                     .Where(model => !string.IsNullOrWhiteSpace(model));
+
+-            // return the union
+-            return resourceModels.Union(modelsAllOfOnXmsAzureResources);
++            // if any model is returned only by a POST operation, disregard it
++            return unfilteredResourceCandidates.Except(postOpResourceModels);
+
+         }
+ ","I don't see the ""only"" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same ""level"". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj<HERE>.Where` and lines won't be that long."
+2923,"@@ -20,7 +20,8 @@ Puppet::DataTypes.create_type('Target') do
+       vars => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
+       facts => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
+       features => { type => Optional[Array[String[1]]], kind => given_or_derived },
+-      plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived }
++      plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
++      resources => { type => Optional[Hash[String[1], ResourceInstance]], kind => given_or_derived }
+     },
+     functions => {
+       host => Callable[[], Optional[String]],","It seems like most of these will never be nil, are they optional just in case?"
+2924,"@@ -88,7 +88,7 @@ public class TableCodecTest {
+       try {
+         byte[] bytes = TableCodec.encodeRow(tblInfo.getColumns(), values, tblInfo.isPkHandle());
+         // testing the correctness via decodeRow
+-        Row row = TableCodec.decodeRow(bytes, tblInfo.getColumns());
++        Row row = TableCodec.decodeRow(bytes, -1, tblInfo);
+         for (int j = 0; j < tblInfo.getColumns().size(); j++) {
+           assertEquals(row.get(j, null), values[j]);
+         }","`.addColumn(""c1"", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31"
+2925,"@@ -56,8 +56,10 @@ public class RowKey extends Key implements Serializable {
+     Object obj = handle.getValue();
+     if (obj instanceof Long) {
+       return new RowKey(tableId, (long) obj);
++    } else if (obj instanceof Integer) {
++      return new RowKey(tableId, ((Integer) obj).longValue());
+     }
+-    throw new TiExpressionException(""Cannot encode row key with non-long type"");
++    throw new TiExpressionException(""Cannot encode row key with non-long or non-integer type"");
+   }
+
+   public static RowKey createMin(long tableId) {",how about `Cannot encode row key with non-integer type` directly?
+2926,"@@ -42,6 +42,9 @@ public interface ExecutorLoader {
+   Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
+       throws ExecutorManagerException;
+
++  Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
++      throws ExecutorManagerException;
++
+   Pair<ExecutionReference, ExecutableFlow> fetchActiveFlowByExecId(int execId)
+       throws ExecutorManagerException;
+ ",The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?
+2927,"@@ -26,6 +26,17 @@ module Travis
+                 sh.cmd ""wget -q -O tmate.tar.xz #{static_build_linux_url}"", echo: false, retry: true
+                 sh.cmd ""tar --strip-components=1 -xf tmate.tar.xz"", echo: false
+               end
++              sh.elif ""$(uname) = 'FreeBSD'"" do
++                sh.cmd 'sudo pkg install -y libevent msgpack libssh', echo: true
++                sh.cmd 'git clone https://github.com/tmate-io/tmate.git', echo: true
++                sh.cd 'tmate', echo: false, stack: true
++                sh.cmd 'git checkout 2.4.0', echo: true
++                sh.cmd './autogen.sh', echo: true
++                sh.cmd './configure', echo: true
++                sh.cmd 'make', echo: true
++                sh.cmd 'sudo make install', echo: true
++                sh.cd :back, echo: false, stack: true
++              end
+               sh.else do
+                 sh.echo ""We are setting up the debug environment. This may take a while...""
+                 sh.cmd ""brew update &> /dev/null"", echo: false, retry: true",Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`.
+2928,"@@ -0,0 +1,5 @@
++// Package importpath is used to implement a test on Go import paths.
++package importpath
++
++// Answer is the answer to Life, the Universe and Everything.
++const Answer = 42",ultra nit: missing Oxford comma :P
+2929,"@@ -729,6 +729,16 @@ class SparkFrameMethods(object):
+         == Physical Plan ==
+         ...
+
++        >>> df.spark.explain(""extended"")  # doctest: +SKIP
++        == Parsed Logical Plan ==
++        ...
++        == Analyzed Logical Plan ==
++        ...
++        == Optimized Logical Plan ==
++        ...
++        == Physical Plan ==
++        ...
++
+         >>> df.spark.explain(mode=""extended"")  # doctest: +ELLIPSIS
+         == Parsed Logical Plan ==
+         ...",This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now.
+2930,"@@ -13,5 +13,6 @@ import (
+ // like sending and awaiting mined ones.
+ type Message interface {
+ 	Send(ctx context.Context, from, to types.Address, val *types.AttoFIL, method string, params ...interface{}) (*cid.Cid, error)
++	Query(ctx context.Context, from, to types.Address, method string, params ...interface{}) ([][]byte, *exec.FunctionSignature, error)
+ 	Wait(ctx context.Context, msgCid *cid.Cid, cb func(blk *types.Block, msg *types.SignedMessage, receipt *types.MessageReceipt, signature *exec.FunctionSignature) error) error
+ }",BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?
+2931,"@@ -562,14 +562,14 @@ func (c *ConfigLocal) MaxDirBytes() uint64 {
+ 	return c.maxDirBytes
+ }
+
+-// ResetCaches implements the Config interface for ConfigLocal.
+-func (c *ConfigLocal) ResetCaches() {
++func (c *ConfigLocal) resetCachesWithoutShutdown() DirtyBlockCache {
+ 	c.lock.Lock()
+ 	defer c.lock.Unlock()
+ 	c.mdcache = NewMDCacheStandard(5000)
+ 	c.kcache = NewKeyCacheStandard(5000)
+ 	// Limit the block cache to 10K entries or 1024 blocks (currently 512MiB)
+ 	c.bcache = NewBlockCacheStandard(c, 10000, MaxBlockSizeBytesDefault*1024)
++	oldDirtyBcache := c.dirtyBcache
+ 	minFactor := 1
+ 	if maxParallelBlockPuts > 10 {
+ 		minFactor = maxParallelBlockPuts / 10",please move this down to immediately above the assignment to `c.dirtyBcache`
+2932,"@@ -63,3 +63,19 @@ func Example() {
+ 	// Output:
+ 	// foo.com running on port 80
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	// This example watches a variable based on a file-based blob.Bucket with JSON.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""blob://myvar.json?bucket=file:///mypath&decoder=json"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}","Don't need the `, err` part since you've already handled it."
+2933,"@@ -222,4 +222,18 @@ TEST_CASE(""negative charge queries. Part of testing changes for github #2604"",
+     CHECK(nWarnings == 1);
+     CHECK(nErrors == 0);
+   }
++}
++
++TEST_CASE(""GithHub #2954: Reaction Smarts with Dative Bonds not parsed"",
++          ""[Reaction, Bug]"") {
++
++  SECTION(""Rxn Smart Processing with Dative Bond"") {
++    unique_ptr<ChemicalReaction> rxn(
++      RxnSmartsToChemicalReaction(""[O:1].[H+]>>[O:1]->[H+]"")
++    );
++    REQUIRE(rxn);
++    auto k = rxn->getProducts()[0]->getNumAtoms();
++    CHECK(k == 2);
++  }
++
+ }",Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`)
+2934,"@@ -54,6 +54,15 @@ func (c *Cluster) newListener(ctx context.Context) (net.Listener, http.Handler,
+ 			MinVersion:   c.config.TLSMinVersion,
+ 			CipherSuites: c.config.TLSCipherSuites,
+ 		},
++		RegenerateCerts: func() bool {
++			const regenerateDynamicListenerFile = ""dynamic-cert-regenerate""
++			dynamicListenerRegenFilePath := filepath.Join(c.config.DataDir, ""tls"", regenerateDynamicListenerFile)
++			if _, err := os.Stat(dynamicListenerRegenFilePath); err == nil {
++				os.Remove(dynamicListenerRegenFilePath)
++				return true
++			}
++			return false
++		},
+ 	})
+ }
+ ",What happens if the certificate rotation fails and we are prematurely removing this file?
+2935,"@@ -97,6 +97,18 @@ func (s *Single) IsRunning() bool {
+
+ // Introspect returns a ChooserStatus with a single PeerStatus.
+ func (s *Single) Introspect() introspection.ChooserStatus {
++	if !s.once.IsRunning() {
++		return introspection.ChooserStatus{
++			Name: ""Single"",
++			Peers: []introspection.PeerStatus{
++				{
++					Identifier: s.pid.Identifier(),
++					State: ""uninitialized"",
++				},
++			},
++		}
++	}
++
+ 	peerStatus := s.p.Status()
+ 	peer := introspection.PeerStatus{
+ 		Identifier: s.p.Identifier(),",does this change belong here?
+2936,"@@ -291,6 +291,8 @@ func (w *Workflow) populate() error {
+ 		""DATETIME"":  now.Format(""20060102150405""),
+ 		""TIMESTAMP"": strconv.FormatInt(now.Unix(), 10),
+ 		""USERNAME"":  w.username,
++		""WFDIR"":     w.workflowDir,
++		""CWD"":       os.Getwd(),
+ 	}
+
+ 	var replacements []string",This returns an error
+2937,"@@ -131,6 +131,8 @@ type Config struct {
+ 	Ipv6Support    bool `config:""bool;true""`
+ 	IgnoreLooseRPF bool `config:""bool;false""`
+
++	// FIXME Add this to libcalico-go
++	IptablesBackend                    string        `config:""oneof(legacy,nft);legacy;local""`
+ 	RouteRefreshInterval               time.Duration `config:""seconds;90""`
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;1""`","If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?"
+2938,"@@ -53,7 +53,10 @@ func TestBlockPropsManyNodes(t *testing.T) {
+ 	connect(t, nodes[1], nodes[2])
+ 	connect(t, nodes[2], nodes[3])
+
+-	baseTS := minerNode.ChainReader.Head()
++	head := minerNode.ChainReader.GetHead()
++	headTipSetAndState, err := minerNode.ChainReader.GetTipSetAndState(ctx, head)
++	require.NoError(err)
++	baseTS := headTipSetAndState.TipSet
+ 	require.NotNil(t, baseTS)
+ 	proof := testhelpers.MakeRandomPoSTProofForTest()
+ ",Looks like that helper function is general enough that it should reside in testhelpers
+2939,"@@ -456,6 +456,11 @@ func writeDrupal6DdevSettingsFile(settings *DrupalSettings, filePath string) err
+ // WriteDrushrc writes out drushrc.php based on passed-in values.
+ // This works on Drupal 6 and Drupal 7 or with drush8 and older
+ func WriteDrushrc(app *DdevApp, filePath string) error {
++	// Ignore because this is a settings file.
++	if app.DisableSettingsManagement {
++		return nil
++	}
++
+ 	if fileutil.FileExists(filePath) {
+ 		// Check if the file is managed by ddev.
+ 		signatureFound, err := fileutil.FgrepStringInFile(filePath, DdevFileSignature)","This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually."
+2940,"@@ -10,8 +10,10 @@ test_name 'use the provision subcommand' do
+     delete_root_folder_contents
+     on(default, 'beaker init')
+     result = on(default, 'beaker provision --hosts centos6-64')
++    assert_match(/ERROR/, result.raw_output)
++    on(default, 'beaker init --hosts centos6-64')
++    result = on(default, 'beaker provision')
+     assert_match(/Using available host/, result.stdout)
+-
+     subcommand_state = on(default, ""cat #{SubcommandUtil::SUBCOMMAND_STATE}"").stdout
+     subcommand_state = YAML.parse(subcommand_state).to_ruby
+     assert_equal(true, subcommand_state['provisioned'])",I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work.
+2941,"@@ -470,8 +470,8 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
+ 		publicSubnets, err := o.selVPC.PublicSubnets(envInitPublicSubnetsSelectPrompt, """", o.importVPC.ID)
+ 		if err != nil {
+ 			if err == selector.ErrSubnetsNotFound {
+-				log.Warningf(`No existing public subnets were found in VPC %s.
+-If you proceed without public subnets, you will not be able to deploy Load Balanced Web Services in this environment.
++				log.Warningf(`No existing subnets were found in VPC %s.
++If you proceed without specifying public subnets, you will not be able to deploy Load Balanced Web Services in this environment.
+ `, o.importVPC.ID)
+ 			} else {
+ 				return fmt.Errorf(""select public subnets: %w"", err)","Should we say ""specifying two public subnets""?"
+2942,"@@ -32,6 +32,8 @@ func (current *PubSubSource) CheckImmutableFields(ctx context.Context, og apis.I
+ 		return nil
+ 	}
+
++	// TODO: revisit this.
++
+ 	// All of the fields are immutable because the controller doesn't understand when it would need
+ 	// to delete and create a new Receive Adapter with updated arguments. We could relax it slightly
+ 	// to allow a nil Sink -> non-nil Sink, but I don't think it is needed yet.",Issue number? When? Why?
+2943,"@@ -35,6 +35,7 @@ from ._sapi4 import (
+ 	VOICECHARSET
+ )
+ import config
++import speech
+ import nvwave
+ import weakref
+ ",You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`.
+2944,"@@ -108,7 +108,7 @@ public abstract class BaseTestIceberg {
+     newCatalog.setConf(hadoopConfig);
+     newCatalog.initialize(""nessie"", ImmutableMap.of(""ref"", ref,
+         CatalogProperties.URI, uri,
+-        ""auth_type"", ""NONE"",
++        ""auth-type"", ""NONE"",
+         CatalogProperties.WAREHOUSE_LOCATION, temp.toUri().toString()
+     ));
+     return newCatalog;","Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself  "
+2945,"@@ -146,12 +146,12 @@ func (db *taskQueueDB) CreateTasks(tasks []*persistencespb.AllocatedTaskInfo) (*
+ // GetTasks returns a batch of tasks between the given range
+ func (db *taskQueueDB) GetTasks(minTaskID int64, maxTaskID int64, batchSize int) (*persistence.GetTasksResponse, error) {
+ 	return db.store.GetTasks(&persistence.GetTasksRequest{
+-		NamespaceID:  db.namespaceID.String(),
+-		TaskQueue:    db.taskQueueName,
+-		TaskType:     db.taskType,
+-		BatchSize:    batchSize,
+-		ReadLevel:    minTaskID,  // exclusive
+-		MaxReadLevel: &maxTaskID, // inclusive
++		NamespaceID: db.namespaceID.String(),
++		TaskQueue:   db.taskQueueName,
++		TaskType:    db.taskType,
++		PageSize:    batchSize,
++		MinTaskID:   minTaskID, // exclusive
++		MaxTaskID:   maxTaskID, // inclusive
+ 	})
+ }
+ ","maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive,"
+2946,"@@ -70,7 +70,7 @@ const (
+
+ 	NvidiaVisibleDevicesEnvVar = ""NVIDIA_VISIBLE_DEVICES""
+ 	GPUAssociationType         = ""gpu""
+-	NvidiaRuntime              = ""nvidia""
++	NvidiaRuntime              = ""ecs-nvidia""
+
+ 	arnResourceSections  = 2
+ 	arnResourceDelimiter = ""/""",You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian.
+2947,"@@ -177,10 +177,10 @@ func newLeafNodeCfg(remote *RemoteLeafOpts) *leafNodeCfg {
+ 	if len(remote.DenyExports) > 0 || len(remote.DenyImports) > 0 {
+ 		perms := &Permissions{}
+ 		if len(remote.DenyExports) > 0 {
+-			perms.Subscribe = &SubjectPermission{Deny: remote.DenyExports}
++			perms.Publish = &SubjectPermission{Deny: remote.DenyExports}
+ 		}
+ 		if len(remote.DenyImports) > 0 {
+-			perms.Publish = &SubjectPermission{Deny: remote.DenyImports}
++			perms.Subscribe = &SubjectPermission{Deny: remote.DenyImports}
+ 		}
+ 		cfg.perms = perms
+ 	}","Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of ""foo"" it means that it would reject a subscription (hence subscribe permission) on ""foo"" from the other side. Now you are changing to simply not allowing this server to publish on ""foo"". I am not saying this is wrong, but we completely flip the meaning."
+2948,"@@ -159,6 +159,12 @@ dsts_first(void)
+     return TESTANY(DR_DISASM_INTEL | DR_DISASM_ARM, DYNAMO_OPTION(disasm_mask));
+ }
+
++static inline bool
++opmask_with_dsts(void)
++{
++    return TESTANY(DR_DISASM_INTEL | DR_DISASM_ATT, DYNAMO_OPTION(disasm_mask));
++}
++
+ static void
+ internal_instr_disassemble(char *buf, size_t bufsz, size_t *sofar INOUT,
+                            dcontext_t *dcontext, instr_t *instr);","> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing"
+2949,"@@ -192,7 +192,7 @@ func (kc *KMDController) StartKMD(args KMDStartArgs) (alreadyRunning bool, err e
+ 			return false, errors.New(""bad kmd data dir"")
+ 		}
+ 		if (dataDirStat.Mode() & 0077) != 0 {
+-			logging.Base().Errorf(""%s: kmd data dir exists but is too permissive (%o)"", kc.kmdDataDir, dataDirStat.Mode()&0777)
++			logging.Base().Errorf(""%s: kmd data dir exists but is too permissive (%o), change to (%o)"", kc.kmdDataDir, dataDirStat.Mode()&0777, dataDirStat.Mode()&0077)
+ 			return false, errors.New(""kmd data dir not secure"")
+ 		}
+ 	} else {","I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`"
+2950,"@@ -386,8 +386,8 @@ func (s *stream) SetDeadline(t time.Time) error {
+ }
+
+ // CloseRemote makes the stream receive a ""virtual"" FIN stream frame at a given offset
+-func (s *stream) CloseRemote(offset protocol.ByteCount) {
+-	s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: offset})
++func (s *stream) CloseRemote(offset uint64) {
++	s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: protocol.ByteCount(offset)})
+ }
+
+ // Cancel is called by session to indicate that an error occurred","The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC"
+2951,"@@ -260,6 +260,17 @@ bool IsDetrimentalSpell(uint16 spell_id)
+ 	return !IsBeneficialSpell(spell_id);
+ }
+
++bool IsInvisSpell(uint16 spell_id)
++{
++	if (IsEffectInSpell(spell_id, SE_Invisibility) ||
++		IsEffectInSpell(spell_id, SE_Invisibility2) ||
++		IsEffectInSpell(spell_id, SE_InvisVsUndead) ||
++		IsEffectInSpell(spell_id, SE_InvisVsUndead2) ||
++		IsEffectInSpell(spell_id, SE_InvisVsAnimals))
++		return true;
++	return false;
++}
++
+ bool IsInvulnerabilitySpell(uint16 spell_id)
+ {
+ 	return IsEffectInSpell(spell_id, SE_DivineAura);",I dig the helper function!
+2952,"@@ -0,0 +1,2 @@
++// package samples contains sample programs using the pubsub API.
++package samples",Please add the Copyright header.
+2953,"@@ -37,6 +37,7 @@ import sys
+ import tempfile
+
+ import luigi
++from ..target import FileSystemTarget
+
+ logger = logging.getLogger('luigi-interface')
+ ",Is this the best way to import `FileSystemTarget`?
+2954,"@@ -2751,10 +2751,10 @@ static void
+ replace_thread_id(thread_id_t old, thread_id_t new)
+ {
+ #ifdef HAVE_TLS
+-    thread_id_t new_tid = new;
++    int32_t new_tid = (int32_t) new; /* can't use thread_id_t since it's 64-bits on x64 */
+     ASSERT(is_thread_tls_initialized());
+     DOCHECK(1, {
+-        thread_id_t old_tid;
++        int32_t old_tid; /* can't use thread_id_t since it's 64-bits on x64 */
+         READ_TLS_INT_SLOT_IMM(TLS_THREAD_ID_OFFSET, old_tid);
+         ASSERT(old_tid == old);
+     });","Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg."
+2955,"@@ -13311,7 +13311,11 @@ public:
+         HRESULT Status;
+
+         ICorDebugProcess* pCorDebugProcess;
+-        IfFailRet(g_pRuntime->GetCorDebugInterface(&pCorDebugProcess));
++        if (FAILED(Status = g_pRuntime->GetCorDebugInterface(&pCorDebugProcess)))
++        {
++            ExtOut(""\n\n\n!clrstack -i is unsupported on this target.\nThe ICorDebug interface cannot be constructed.\n"");
++            return Status;
++        }
+
+         ExtOut(""\n\n\nDumping managed stack and managed variables using ICorDebug.\n"");
+         ExtOut(""=============================================================================\n"");",Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?
+2956,"@@ -52,7 +52,13 @@ def _dagster_home():
+             'DAGSTER_HOME is not set, check is_dagster_home_set before invoking.'
+         )
+
+-    return os.path.expanduser(dagster_home_path)
++    dagster_home_path = os.path.expanduser(dagster_home_path)
++
++    if not os.path.isabs(dagster_home_path):
++        raise DagsterInvariantViolationError(
++            'DAGSTER_HOME must be absolute path'
++        )
++    return dagster_home_path
+
+
+ def _check_run_equality(pipeline_run, candidate_run):",print out what we got here in the error
+2957,"@@ -43,6 +43,9 @@ See the file COPYING for details.
+ 	)); \
+ } while (false)
+
++//Stores select query before evaluation
++struct jx *select_expr = NULL;
++
+ static struct jx *jx_check_errors(struct jx *j);
+
+ static struct jx *jx_eval_null(struct jx_operator *op, struct jx *left, struct jx *right) {",Does this need to be global?
+2958,"@@ -1349,7 +1349,7 @@ public final class TreeMap<K, V> implements SortedMap<K, V>, Serializable {
+
+     @Override
+     public Seq<V> values() {
+-        return iterator().map(Tuple2::_2).toStream();
++        return map(Tuple2::_2);
+     }
+
+     // -- Object","Yep, could be simplified. Now looks like other *Map.values() impls"
+2959,"@@ -183,6 +183,15 @@ class ApiContext extends \Imbo\BehatApiExtension\Context\ApiContext
+         $this->assertJsonObjectContainsKeys('configuration,columns,collection,info');
+     }
+
++    /**
++     * @Then /^print last api response$/
++     */
++    public function printLastApiResponse(): void
++    {
++        $this->requireResponse();
++        echo $this->response->getBody();
++    }
++
+     /**
+      * {@inheritDoc}
+      */",This method will be for debug?
+2960,"@@ -9,9 +9,16 @@ import (
+ 	""errors""
+ )
+
++// ErrInvalidPassword is returned when the password for decrypting content where
++// private key is stored is not valid.
+ var ErrInvalidPassword = errors.New(""invalid password"")
+
++// Service for managing keystore private keys.
+ type Service interface {
++	// Key returns private key for specified name that was encrypted with
++	// provided password. If the private key does not exists it creates new one
++	// with name and password, and returns with created set to true.
+ 	Key(name, password string) (k *ecdsa.PrivateKey, created bool, err error)
++	// Exists returns true if the key with specified name exists.
+ 	Exists(name string) (bool, error)
+ }","// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true."
+2961,"@@ -45,6 +45,19 @@ class DiagramEntity(Figure):
+         self.node = node
+
+
++class PackageEntity(DiagramEntity):
++    """"""A diagram object representing a package""""""
++
++
++class ClassEntity(DiagramEntity):
++    """"""A diagram object representing a class""""""
++
++    def __init__(self, title, node):
++        super().__init__(title=title, node=node)
++        self.attrs = None
++        self.methods = None
++
++
+ class ClassDiagram(Figure, FilterMixIn):
+     """"""main class diagram handling""""""
+ ","Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``."
+2962,"@@ -43,7 +43,8 @@ class _MissingPandasLikeDataFrame(object):
+     blocks = unsupported_property('blocks', deprecated=True)
+
+     # Functions
+-    add = unsupported_function('add')
++    add_prefix = unsupported_function('add_prefix')
++    add_suffix = unsupported_function('add_suffix')
+     agg = unsupported_function('agg')
+     aggregate = unsupported_function('aggregate')
+     align = unsupported_function('align')",These two functions should be available now.
+2963,"@@ -651,10 +651,17 @@ type localOpenFile struct {
+ 	o    *Object           // object that is open
+ 	in   io.ReadCloser     // handle we are wrapping
+ 	hash *hash.MultiHasher // currently accumulating hashes
++	fd   *os.File          // file object reference
+ }
+
+ // Read bytes from the object - see io.Reader
+ func (file *localOpenFile) Read(p []byte) (n int, err error) {
++	// Check if file has the same size and modTime
++	fi, err := file.fd.Stat()
++	if file.o.size != fi.Size() || file.o.modTime != fi.ModTime() {
++		return 0, errors.New(""can't copy - source file is being updated"")
++	}
++
+ 	n, err = file.in.Read(p)
+ 	if n > 0 {
+ 		// Hash routines never return an error",`fi` is what the result of Stat is called elsewhere in this file not `finfo`
+2964,"@@ -62,15 +62,6 @@ RSpec.describe Blacklight::OpenStructWithHashAccess do
+     end
+   end
+
+-  describe ""#replace"" do
+-    subject { described_class.new a: 1 }
+-
+-    it ""can use #replace to reorder the hash"" do
+-      subject.replace b: 1
+-      expect(subject.b).to eq 1
+-    end
+-  end
+-
+   describe ""#sort_by"" do
+     subject { described_class.new c: 3, b: 1, a: 2 }
+ ",I'm confused; are we just dropping these methods without deprecation?
+2965,"@@ -16,12 +16,18 @@ void AddEdgesProcessor::process(const cpp2::AddEdgesRequest& req) {
+     auto spaceId = req.get_space_id();
+     auto version =
+         std::numeric_limits<int64_t>::max() - time::WallClock::fastNowInMicroSec();
++    // Switch version to big-endian, make sure the key is in ordered.
++    version = folly::Endian::big(version);
++
+     callingNum_ = req.parts.size();
+     CHECK_NOTNULL(kvstore_);
+     std::for_each(req.parts.begin(), req.parts.end(), [&](auto& partEdges){
+         auto partId = partEdges.first;
+         std::vector<kvstore::KV> data;
+         std::for_each(partEdges.second.begin(), partEdges.second.end(), [&](auto& edge){
++            VLOG(4) << ""PartitionID: "" << partId << "", VertexID: "" << edge.key.src
++                    << "", EdgeType: "" << edge.key.edge_type << "", EdgeRanking: "" << edge.key.ranking
++                    << "", VertexID: "" << edge.key.dst << "", EdgeVersion: "" << version;
+             auto key = NebulaKeyUtils::edgeKey(partId, edge.key.src, edge.key.edge_type,
+                                                edge.key.ranking, edge.key.dst, version);
+             data.emplace_back(std::move(key), std::move(edge.get_props()));",can we use PC's time to version in Distributed Systems?
+2966,"@@ -100,9 +100,11 @@
+         <% cart.comments.each do |c| %>
+           <div class='comment-item'>
+             <div class='row'>
+-              <p class='comment-sender col-sm-6 col-xs-12'>
+-                <strong>requester@test.com</strong>
+-              </p>
++              <% unless c.user.nil? %>
++                <p class='comment-sender col-sm-6 col-xs-12'>
++                  <strong><%= c.user_full_name %></strong>
++                </p>
++              <% end %>
+               <p class='comment-date col-sm-6 col-xs-12'>
+                 <%= date_with_tooltip(c.created_at) %>
+               </p>","is this ""unless"" actually needed?"
+2967,"@@ -94,6 +94,10 @@ final class Stemmer {
+     }
+
+     List<CharsRef> list = new ArrayList<>();
++    if (length == 0) {
++      return list;
++    }
++
+     RootProcessor processor =
+         (stem, formID, stemException) -> {
+           list.add(newStem(stem, stemException));","We don't accept empty words for lookup anymore, again"
+2968,"@@ -0,0 +1,18 @@
++#!/usr/bin/env node
++
++const fs = require('fs')
++const yarnOut = fs.readFileSync(0, {encoding: 'utf8'})
++
++const [installTimeString] = /(?<=^Done in )\d+\.\d+(?=s\.$)/m.exec(yarnOut)
++const installTime = Number(installTimeString)
++
++console.log(`Install time: ${installTime}s`)
++
++if (installTime < 30) {
++  console.log(""We're below 30 secs. That's awesome!"")
++} else if (installTime < 50) {
++  console.log(""We're below 50 secs. That's fine!"")
++} else {
++  console.log(""We're above 50 secs. That's not great!"")
++  process.exit(1)
++}",We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?
+2969,"@@ -101,6 +101,7 @@ class Command(object):
+     EXECUTE_ASYNC_SCRIPT = ""executeAsyncScript""
+     SET_SCRIPT_TIMEOUT = ""setScriptTimeout""
+     SET_TIMEOUTS = ""setTimeouts""
++    W3C_MINIMIZE_WINDOW = ""w3cMinimizeWindow""
+     MAXIMIZE_WINDOW = ""windowMaximize""
+     W3C_MAXIMIZE_WINDOW = ""w3cMaximizeWindow""
+     GET_LOG = ""getLog""",No need for this to be `W3C_` since there is no JWP equivalent
+2970,"@@ -1,5 +1,12 @@
+ module RSpec
+   module Core
++    if defined?(::Random)
++      RandomNumberGenerator = ::Random
++    else
++      require 'rspec/core/backport_random'
++      RandomNumberGenerator = RSpec::Core::Backports::Random
++    end
++
+     # @private
+     module Ordering
+       # @private","As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :)."
+2971,"@@ -480,3 +480,13 @@ func (s *Server) NumSubscriptions() uint32 {
+ 	stats := s.sl.Stats()
+ 	return stats.NumSubs
+ }
++
++// Addr will return the net.Addr object for the current listener.
++func (s *Server) Addr() net.Addr {
++	s.mu.Lock()
++	defer s.mu.Unlock()
++	if s.listener == nil {
++		return nil
++	}
++	return s.listener.Addr()
++}",Is this ever actually used?
+2972,"@@ -158,7 +158,7 @@ func (w *Waiter) receiptFromTipSet(ctx context.Context, msgCid cid.Cid, ts conse
+ 	if err != nil {
+ 		return nil, err
+ 	}
+-	res, err := consensus.ProcessTipSet(ctx, ts, st, vm.NewStorageMap(w.bs))
++	res, err := consensus.NewDefaultProcessor().ProcessTipSet(ctx, st, vm.NewStorageMap(w.bs), ts)
+ 	if err != nil {
+ 		return nil, err
+ 	}","this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky"
+2973,"@@ -1749,6 +1749,10 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
+                 arch_mcontext_reset_stolen_reg(dcontext, mc);
+             }
+         });
++        IF_AARCHXX({
++            set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
++            IF_ARM(ASSERT_NOT_TESTED());
++        });
+         /* We send all threads, regardless of whether was in DR or not, to
+          * re-interp from translated cxt, to avoid having to handle stale
+          * local state problems if we simply resumed.",Do we need to save the existing value of the stolen reg somehow?
+2974,"@@ -94,7 +94,8 @@ class AdminDirectoryClient(_base_client.BaseClient):
+             api_errors.ApiExecutionError
+         """"""
+         members_stub = self.service.members()
+-        request = members_stub.list(groupKey=group_key)
++        request = members_stub.list(groupKey=group_key,
++                                    maxResults=500)
+         results_by_member = []
+
+         # TODO: Investigate yielding results to handle large group lists.",maxResults should come from FLAGS once #244 is submitted.
+2975,"@@ -12,6 +12,8 @@ using Datadog.Trace.TestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+
++#if NETCOREAPP
++
+ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+ {
+     [CollectionDefinition(nameof(HttpMessageHandlerTests), DisableParallelization = true)]",is this wanted?
+2976,"@@ -268,6 +268,14 @@ def get_docker_executable():
+     return distutils.spawn.find_executable('docker')
+
+
++def get_linode_executable():
++    try:
++        pytest.importorskip('linode')
++        return True
++    except Exception:
++        return False
++
++
+ def get_lxc_executable():
+     return distutils.spawn.find_executable('lxc-start')
+ ",What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this.
+2977,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?
+2978,"@@ -21,6 +21,7 @@ program
+   .option('--target_arch <target_arch>', 'target architecture')
+   .option('--target_apk_base <target_apk_base>', 'target Android OS apk (classic, modern, mono)')
+   .option('--submodule_sync', 'run submodule sync')
++  .option('--ignore_chromium', 'do not update chromium')
+   .option('--init', 'initialize all dependencies')
+   .option('--all', 'This flag is deprecated and no longer has any effect')
+   .option('--force', 'force reset all projects to origin/ref')","I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?"
+2979,"@@ -57,13 +57,15 @@ var (
+ 		ta.Keyinfo[""alfa""].PriKey, 3, big.NewInt(10), []byte{}, testutil.TestGasLimit,
+ 		big.NewInt(testutil.TestGasPriceInt64))
+
+-	testTransferPb = testTransfer.Proto()
++	testTransferHash = testTransfer.Hash()
++	testTransferPb   = testTransfer.Proto()
+
+ 	testExecution, _ = testutil.SignedExecution(ta.Addrinfo[""bravo""].String(),
+ 		ta.Keyinfo[""bravo""].PriKey, 1, big.NewInt(0), testutil.TestGasLimit,
+ 		big.NewInt(testutil.TestGasPriceInt64), []byte{})
+
+-	testExecutionPb = testExecution.Proto()
++	testExecutionHash = testExecution.Hash()
++	testExecutionPb   = testExecution.Proto()
+
+ 	testTransfer1, _ = testutil.SignedTransfer(ta.Addrinfo[""charlie""].String(), ta.Keyinfo[""producer""].PriKey, 1,
+ 		big.NewInt(10), []byte{}, testutil.TestGasLimit, big.NewInt(testutil.TestGasPriceInt64))",`testExecutionPb` is a global variable (from `gochecknoglobals`)
+2980,"@@ -127,17 +127,6 @@ class ImageProvider extends FileProvider
+         return array_merge($params, $options);
+     }
+
+-    /**
+-     * {@inheritdoc}
+-     */
+-    public function getReferenceImage(MediaInterface $media)
+-    {
+-        return sprintf('%s/%s',
+-            $this->generatePath($media),
+-            $media->getProviderReference()
+-        );
+-    }
+-
+     /**
+      * {@inheritdoc}
+      */","~Method is public and removing it would be a BC Break, you can deprecate it if you want.~"
+2981,"@@ -113,7 +113,7 @@ func (i *interpreter) interpretStatements(s *scope, statements []*Statement) (re
+ 			} else {
+ 				err = fmt.Errorf(""%s"", r)
+ 			}
+-			log.Debug(""%s"", debug.Stack())
++			log.Debug(""%v:\n %s"", err,  debug.Stack())
+ 		}
+ 	}()
+ 	return s.interpretStatements(statements), nil // Would have panicked if there was an error",this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace.
+2982,"@@ -157,6 +157,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --include-prefix       Prefix this path to any generated include statements.\n""
+     ""    PATH\n""
+     ""  --keep-prefix          Keep original prefix of schema include statement.\n""
++    ""  --keep-namespaces      Keep full namespace paths of imported types in Rust.\n""
+     ""  --no-fb-import         Don't include flatbuffers import statement for TypeScript.\n""
+     ""  --no-ts-reexport       Don't re-export imported dependencies for TypeScript.\n""
+     ""  --short-names          Use short function names for JS and TypeScript.\n""",Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them.
+2983,"@@ -88,6 +88,9 @@ type URLOpener struct{}
+ //  - file://localhost/c:/foo/bar
+ //    -> Also passes ""c:\foo\bar"".
+ func (*URLOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.Bucket, error) {
++	for param := range u.Query() {
++		return nil, fmt.Errorf(""open bucket %q: invalid query parameter %q"", u, param)
++	}
+ 	return OpenBucket(mungeURLPath(u.Path, os.PathSeparator), nil)
+ }
+ ",Should unsupported query parameters just be ignored? I think that's more common than error out.
+2984,"@@ -52,9 +52,9 @@ def namespace(namespace=None):
+     Call to set namespace of tasks declared after the call.
+
+     If called without arguments or with ``None`` as the namespace, the namespace
+-    is reset, which is recommended to do at the end of any file where the
+-    namespace is set to avoid unintentionally setting namespace on tasks outside
+-    of the scope of the current file.
++    is reset to :py:attr:`Register._UNSET_NAMESPACE`., which is recommended to do
++    at the end of any file where the namespace is set to avoid unintentionally
++    setting namespace on tasks outside of the scope of the current file.
+
+     The namespace of a Task can also be changed by specifying the property
+     ``task_namespace``. This solution has the advantage that the namespace","Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of ""being unset"". Perhaps the docs become more natural if we remove the ""If called without arguments or with ..."" part and just say ""you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah"". Something like that. Just a suggestion."
+2985,"@@ -426,8 +426,16 @@ class WinWordCollectionQuicknavIterator(object):
+ 			if self.direction==""previous"":
+ 				index=itemCount-(index-1)
+ 			collectionItem=items[index]
+-			item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
+-			itemRange=item.rangeObj
++			try:
++				item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
++				itemRange=item.rangeObj
++			except:
++				values = (self.itemType, self.direction, itemCount, index)
++				message = (""Error iterating over item with ""+
++				(""type: %s, iteration direction: %s, total item count: %s, item at index: %s"" % values )+
++				""\nThis could be caused by an issue with some element within or a corruption of the word document."")
++				log.debugWarning(message ,exc_info=True)
++				continue
+ 			# Skip over the item we're already on.
+ 			if not self.includeCurrent and isFirst and ((self.direction==""next"" and itemRange.start<=self.rangeObj.start) or (self.direction==""previous"" and itemRange.end>self.rangeObj.end)):
+ 				continue","I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors."
+2986,"@@ -328,6 +328,7 @@ var directives = []string{
+ 	""git"",    // github.com/abiosoft/caddy-git
+
+ 	// directives that add middleware to the stack
++	""minify"", // github.com/hacdias/caddy-minify
+ 	""log"",
+ 	""gzip"",
+ 	""errors"",","Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed."
+2987,"@@ -31,7 +31,8 @@ type Tracer struct {
+ 	// Version is the instrumentation version.
+ 	Version string
+
+-	config *config
++	config   *config
++	provider *TracerProvider
+ }
+
+ // Start creates a span. If t is configured with a SpanRecorder its OnStart",nit: we could remove the `config` field as it is a duplicate of the `provider.config` field.
+2988,"@@ -112,7 +112,8 @@ class ForsetiServerInstaller(ForsetiInstaller):
+             # Create firewall rule to open only port tcp:50051
+             # within the internal network (ip-ranges - 10.128.0.0/9)
+             gcloud.create_firewall_rule(
+-                self.format_firewall_rule_name('forseti-server-allow-grpc'),
++                self.format_firewall_rule_name(
++                    'forseti-server-allow-grpc-internal'),
+                 [self.gcp_service_account],
+                 constants.FirewallRuleAction.ALLOW,
+                 ['tcp:50051'],",Nit: from the Internet.
+2989,"@@ -7,11 +7,15 @@
+ package hdwallet
+
+ import (
++	""bytes""
+ 	""fmt""
+ 	""io/ioutil""
+
++	ecrypt ""github.com/ethereum/go-ethereum/crypto""
++	""github.com/iotexproject/go-pkgs/crypto""
++	""github.com/iotexproject/iotex-address/address""
++	hdwallet ""github.com/miguelmota/go-ethereum-hdwallet""
+ 	""github.com/spf13/cobra""
+-
+ 	""github.com/tyler-smith/go-bip39""
+
+ 	""github.com/iotexproject/iotex-core/ioctl/config""","this is internal package, move to bottom and run 'make fmt'"
+2990,"@@ -0,0 +1,14 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System.Threading;
++
++namespace Microsoft.AspNetCore.Connections.Features
++{
++    public interface IConnectionLifetimeNotificationFeature
++    {
++        CancellationToken ConnectionClosing { get; set; }
++
++        void Close();
++    }
++}",Why is this better than ApplicationStopping?
+2991,"@@ -70,8 +70,8 @@ type ChallengeSpec struct {
+ 	// +optional
+ 	Wildcard bool `json:""wildcard""`
+
+-	// Type is the type of ACME challenge this resource represents, e.g. ""dns01""
+-	// or ""http01"".
++	// Type is the type of ACME challenge this resource represents.
++	// One of ""http-01"" or ""dns-01"".
+ 	Type ACMEChallengeType `json:""type""`
+
+ 	// Token is the ACME challenge token for this challenge.",Maybe worth expanding that these 2 are supported by cert-manager but other values exist
+2992,"@@ -169,7 +169,7 @@ class MediaExtension extends \Twig_Extension
+
+         $options = array_merge($defaultOptions, $options);
+
+-        $options['src'] = $provider->generatePublicUrl($media, $format);
++        $options = $provider->getHelperProperties($media, $format, $options);
+
+         return $this->render($provider->getTemplate('helper_thumbnail'), array(
+             'media'    => $media,","Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065"
+2993,"@@ -125,6 +125,10 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+         params.add(""--rpc-http-authentication-credentials-file"");
+         params.add(node.jsonRpcConfiguration().getAuthenticationCredentialsFile());
+       }
++      if (node.jsonRpcConfiguration().getAuthenticationPublicKeyFile() != null) {
++        params.add(""--rpc-http-authentication-public-key-file"");
++        params.add(node.jsonRpcConfiguration().getAuthenticationPublicKeyFile().getAbsolutePath());
++      }
+     }
+
+     if (node.wsRpcEnabled()) {","What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?"
+2994,"@@ -57,6 +57,12 @@ type CertificateSpec struct {
+ 	// Organization is the organization to be used on the Certificate
+ 	Organization []string `json:""organization,omitempty""`
+
++	// Certificate default Duration
++	Duration metav1.Duration `json:""duration,omitempty""`
++
++	// Certificate renew before expiration duration
++	RenewBefore metav1.Duration `json:""renewBefore,omitempty""`
++
+ 	// DNSNames is a list of subject alt names to be used on the Certificate
+ 	DNSNames []string `json:""dnsNames,omitempty""`
+ ","The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0."
+2995,"@@ -120,7 +120,7 @@ public interface GenericToken<T extends GenericToken<T>> {
+                     + "") must come before "" + to + "" (at "" + to.getStartInDocument() + "")""
+             );
+         }
+-        return IteratorUtil.generate(from, t -> t == to ? null : t.getNext());
++        return IteratorUtil.generate(from, t -> t.equals(to) ? null : t.getNext());
+     }
+
+ ","I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?"
+2996,"@@ -22,11 +22,12 @@ type ns struct {
+ 	ipt iptables.Interface // interface to iptables
+ 	ips ipset.Interface    // interface to ipset
+
+-	name      string                     // k8s Namespace name
+-	nodeName  string                     // my node name
+-	namespace *coreapi.Namespace         // k8s Namespace object
+-	pods      map[types.UID]*coreapi.Pod // k8s Pod objects by UID
+-	policies  map[types.UID]interface{}  // k8s NetworkPolicy objects by UID
++	name            string                     // k8s Namespace name
++	nodeName        string                     // my node name
++	namespaceUID    types.UID                  // k8s Namespace UID
++	namespaceLabels map[string]string          // k8s Namespace labels
++	pods            map[types.UID]*coreapi.Pod // k8s Pod objects by UID
++	policies        map[types.UID]interface{}  // k8s NetworkPolicy objects by UID
+
+ 	uid     types.UID     // surrogate UID to own allPods selector
+ 	allPods *selectorSpec // hash:ip ipset of all pod IPs in this namespace","It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil."
+2997,"@@ -17,6 +17,7 @@ const (
+ 	GithubV1ProviderName   = ""GitHubV1""
+ 	CodeCommitProviderName = ""CodeCommit""
+ 	BitbucketProviderName  = ""Bitbucket""
++	DefaultImage           = ""aws/codebuild/amazonlinux2-x86_64-standard:3.0""
+
+ 	pipelineManifestPath = ""cicd/pipeline.yml""
+ )",Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private
+2998,"@@ -251,7 +251,7 @@ def reporter():
+ @pytest.fixture
+ def init_linter(linter: PyLinter) -> PyLinter:
+     linter.open()
+-    linter.set_current_module(""toto"")
++    linter.set_current_module(""toto"", ""mydir/toto"")
+     linter.file_state = FileState(""toto"")
+     return linter
+ ","I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR."
+2999,"@@ -154,7 +154,9 @@ public class ExportService {
+             if (releasedVersion == null) {
+                 throw new ExportException(""No released version for dataset "" + dataset.getGlobalId().toString());
+             }
+-            final JsonObjectBuilder datasetAsJsonBuilder = JsonPrinter.jsonAsDatasetDto(releasedVersion);
++            // We pass settingsService into the JsonPrinter constructor to check the :ExcludeEmailFromExport setting.
++            JsonPrinter jsonPrinter = new JsonPrinter(settingsService);
++            final JsonObjectBuilder datasetAsJsonBuilder = jsonPrinter.jsonAsDatasetDto(releasedVersion);
+             JsonObject datasetAsJson = datasetAsJsonBuilder.build();
+
+             Iterator<Exporter> exporters = loader.iterator();",Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.)
+3000,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those,
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?
+3001,"@@ -75,6 +75,14 @@ type diskBlockCacheSetter interface {
+ 	MakeDiskBlockCacheIfNotExists() error
+ }
+
++type diskBlockCacheFractionSetter interface {
++	SetDiskBlockCacheFraction(float64)
++}
++
++type syncBlockCacheFractionSetter interface {
++	SetSyncBlockCacheFraction(float64)
++}
++
+ type clockGetter interface {
+ 	Clock() Clock
+ }",This should go in `ConfigLocal` (and then re-generate the mocks).
+3002,"@@ -51,10 +51,10 @@ class releaseTestCase(SparkTestCase):
+             if entry['release_name'] != '':
+                 expected[entry['user_name']].append({
+                     'release_name': entry['release_name'],
+-                    'release_msid': entry['release_msid'],
+-                    'release_mbid': entry['release_mbid'],
++                    'release_msid': entry['release_msid'] or None,
++                    'release_mbid': entry['release_mbid'] or None,
+                     'artist_name': entry['artist_name'],
+-                    'artist_msid': entry['artist_msid'],
++                    'artist_msid': entry['artist_msid'] or None,
+                     'artist_mbids': entry['artist_mbids'],
+                     'listen_count': entry['count']
+                 })",Nitty but entry.get for the same thing
+3003,"@@ -10,11 +10,12 @@ import (
+ 	""github.com/opencontainers/runc/libcontainer/logs""
+ 	_ ""github.com/opencontainers/runc/libcontainer/nsenter""
+ 	""github.com/sirupsen/logrus""
+-	""github.com/urfave/cli""
+ )
+
+ func init() {
+ 	if len(os.Args) > 1 && os.Args[1] == ""init"" {
++		// This is the golang entry point for runc init, executed
++		// before main() but after libcontainer/nsenter's nsexec().
+ 		runtime.GOMAXPROCS(1)
+ 		runtime.LockOSThread()
+ ",Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs.
+3004,"@@ -100,6 +100,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+                         ""ThreadCount must be positive."");
+                 }
+
++                if (!Constants.ECONNRESET.HasValue)
++                {
++                    _logger.LogWarning(""Unable to determine ECONNRESET value on this platform."");
++                }
++
+                 if (!Constants.EADDRINUSE.HasValue)
+                 {
+                     _logger.LogWarning(""Unable to determine EADDRINUSE value on this platform."");",nit: add new line after this block
+3005,"@@ -1111,10 +1111,10 @@ Blockly.Css.CONTENT = [
+   '}',
+
+   '.scratchCategoryMenu {',
+-    'width: 60px;',
++    'width: 3.25rem;',
+     'background: $colour_toolbox;',
+     'color: $colour_toolboxText;',
+-    'font-size: .7em;',
++    'font-size: .7rem;',
+     'user-select: none;',
+     '-webkit-user-select: none;',
+     '-moz-user-select: none;',","I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?"
+3006,"@@ -20,10 +20,11 @@ import urllib2
+
+ import jinja2
+
+-from retrying import retry
+ import sendgrid
+ from sendgrid.helpers import mail
+
++from retrying import retry
++
+ from google.cloud.security.common.util import errors as util_errors
+ from google.cloud.security.common.util import log_util
+ from google.cloud.security.common.util import retryable_exceptions",retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?
+3007,"@@ -133,12 +133,12 @@ public interface List<T> extends Seq<T>, Stack<T> {
+             @SuppressWarnings(""unchecked"")
+             final List<T> list = (List<T>) elements;
+             return list;
+-        } else if (elements instanceof ArrayList) {
++        } else if (elements instanceof ArrayList || elements instanceof Vector) {
+             @SuppressWarnings(""unchecked"")
+-            final ArrayList<T> arrayList = (ArrayList<T>) elements;
++            final java.util.List<T> indexedList = (java.util.List<T>) elements;
+             List<T> result = Nil.instance();
+-            for (int i = arrayList.size() - 1; i >= 0; i--) {
+-                final T element = arrayList.get(i);
++            for (int i = indexedList.size() - 1; i >= 0; i--) {
++                final T element = indexedList.get(i);
+                 result = result.prepend(element);
+             }
+             return result;",you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector.
+3008,"@@ -355,10 +355,17 @@ public class EditImageActivity extends EditBaseActivity implements View.OnClickL
+
+     private void addToUndoList() {
+         try{
++            TODO:// implement a more efficient way, like storing only the difference of bitmaps or
++            // steps followed to edit
++
+             bitmapsForUndo.add(mainBitmap.copy(mainBitmap.getConfig(),true));
+         }catch (OutOfMemoryError error){
+-            //Snackbar.make(getWindow().getDecorView().getRootView(),""Out of Memory. steps = "" + bitmapsForUndo.size(),Snackbar.LENGTH_LONG).show();
+-
++            /**
++             * When outOfMemory exception throws then to make space, remove the last edited step
++             * from list and added the new operation in the end.
++             */
++            bitmapsForUndo.remove(0);
++            bitmapsForUndo.add(mainBitmap.copy(mainBitmap.getConfig(),true));
+         }
+     }
+ ","remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list."
+3009,"@@ -1,4 +1,4 @@
+-//  Copyright 2019 Google Inc. All Rights Reserved.
++//  Copyright 2020 Google Inc. All Rights Reserved.
+ //
+ //  Licensed under the Apache License, Version 2.0 (the ""License"");
+ //  you may not use this file except in compliance with the License.",this is a existing file so let's keep 2019
+3010,"@@ -42,7 +42,7 @@ public class RemoteNetworkConnection implements NetworkConnection {
+   @Override
+   public ConnectionType setNetworkConnection(
+       ConnectionType type) {
+-    Map<String, ConnectionType> mode = ImmutableMap.of(""type"", type);
++    Map<String, Integer> mode = ImmutableMap.of(""type"", type.getBitMask());
+     return new ConnectionType(((Number) executeMethod.execute(DriverCommand.SET_NETWORK_CONNECTION,
+                                                             ImmutableMap
+                                                                 .of(""parameters"", mode)))",can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)
+3011,"@@ -257,7 +257,7 @@ namespace Nethermind.AuRa.Test.Transactions
+                 TransactionPermissionContractVersions =
+                     new LruCache<Keccak, UInt256>(PermissionBasedTxFilter.Cache.MaxCacheSize, nameof(TransactionPermissionContract));
+
+-                var trieStore = new ReadOnlyTrieStore(new TrieStore(DbProvider.StateDb, LimboLogs.Instance));
++                var trieStore = new TrieStore(DbProvider.StateDb, LimboLogs.Instance).AsReadOnly(DbProvider.StateDb);
+                 IReadOnlyTxProcessorSource txProcessorSource = new ReadOnlyTxProcessingEnv(
+                     DbProvider,
+                     trieStore,",AsReadOnly() would be better here
+3012,"@@ -427,9 +427,12 @@ class Collection {
+      * @param {function(collection, changes)} callback - A function to be called when changes occur.
+      *   The callback function is called with two arguments:
+      *   - `collection`: the collection instance that changed,
+-     *   - `changes`: a dictionary with keys `insertions`, `modifications` and `deletions`,
+-     *      each containing a list of indices that were inserted, updated or deleted respectively. If
+-     *      partial sync is enabled, an additional key `partial_sync` is added.
++     *   - `changes`: a dictionary with keys `insertions`, `newModifications`, `oldModifications`
++     *      and `deletions`, each containing a list of indices in the collection that were
++     *      inserted, updated or deleted respectively. `deletions` and `oldModifications` are
++     *      indices into the collection before the change happened, while `insertions` and
++     *      `newModifications` are indices into the new version of the collection. If partial sync
++     *      is enabled, an additional key `partial_sync` is added.
+      *   - `changes.partial_sync`: `error` indicates if an error has occurred, `old_state` is the previous
+      *      state, and `new_state` is the current state.
+      * @throws {Error} If `callback` is not a function.",I suggest that we use `query_based_sync` instead of `partial_sync`.
+3013,"@@ -15,6 +15,11 @@
+ // Package azureblob provides a blob implementation that uses Azure Storage’s
+ // BlockBlob. Use OpenBucket to construct a *blob.Bucket.
+ //
++// NOTE: SignedURLs for PUT created with this package are not fully portable;
++// they will not work unless the PUT request includes a ""x-ms-blob-type"" header
++// set to ""BlockBlob"".
++// See https://stackoverflow.com/questions/37824136/put-on-sas-blob-url-without-specifying-x-ms-blob-type-header.
++//
+ // URLs
+ //
+ // For blob.OpenBucket, azureblob registers for the scheme ""azblob"".",How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how.
+3014,"@@ -38,11 +38,14 @@ import java.util.List;
+  */
+ public class DynamicLangApiMethodTransformer {
+   private final ApiMethodParamTransformer apiMethodParamTransformer;
+-  private final InitCodeTransformer initCodeTransformer = new InitCodeTransformer();
++  private final InitCodeTransformer initCodeTransformer;
+   private final LongRunningTransformer lroTransformer = new LongRunningTransformer();
+
+-  public DynamicLangApiMethodTransformer(ApiMethodParamTransformer apiMethodParamTransformer) {
++  public DynamicLangApiMethodTransformer(
++      ApiMethodParamTransformer apiMethodParamTransformer,
++      InitCodeTransformer initCodeTransformer) {
+     this.apiMethodParamTransformer = apiMethodParamTransformer;
++    this.initCodeTransformer = initCodeTransformer;
+   }
+
+   public OptionalArrayMethodView generateMethod(MethodTransformerContext context) {","I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?"
+3015,"@@ -151,14 +151,15 @@
+ //
+ // Representing Keys
+ //
+-// The key of a docstore document is some function of its contents, usually a field.
++// The key of a docstore document is its unique identifier, usually a field.
+ // Keys never appear alone in the docstore API, only as part of a document. For
+ // instance, to retrieve a document by key, you pass the Collection.Get method
+ // a document as a struct pointer or map with the key field populated, and docstore
+-// populates the rest of that argument with the stored contents.
++// populates the rest of that argument with the stored contents. Docstore
++// doesn't take zero-value key.
+ //
+-// When you open a collection using the OpenCollection method of the service-specific driver or
+-// a URL, you specify how to extract the key from a document.
++// When you open a collection using the constructor of the service-specific
++// driver or a URL, you specify how to extract the key from a document.
+ // Usually, you provide the name of the key field, as in the example below:
+ //
+ //   coll, err := memdocstore.OpenCollection(""SSN"", nil)","""Constructor"" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?"
+3016,"@@ -114,7 +114,7 @@ class TestCtuFailure(unittest.TestCase):
+         """""" Test that Clang indeed logs the AST import events when using
+         on-demand mode.
+         """"""
+-        self.__set_up_test_dir('ctu_on_demand_failure')
++        self.__set_up_test_dir('ctu_failure')
+
+         output = self.__do_ctu_all(on_demand=True,
+                                    extra_args=[""--verbose"", ""debug""])",Why do we have to change the test dir?
+3017,"@@ -65,9 +65,11 @@ dom.isNativelyFocusable = function(el) {
+ 			return el.type !== 'hidden';
+ 		case 'TEXTAREA':
+ 		case 'SELECT':
+-		case 'DETAILS':
++		case 'SUMMARY':
+ 		case 'BUTTON':
+ 			return true;
++		case 'DETAILS':
++			return !el.querySelector('summary');
+ 	}
+ 	return false;
+ };",This should test the flattened tree instead. details > summary works across shadow tree boundaries.
+3018,"@@ -0,0 +1,17 @@
++// MvxBindingLog.cs
++
++// MvvmCross is licensed using Microsoft Public License (Ms-PL)
++// Contributions and inspirations noted in readme.md and license.txt
++//
++// Project Lead - Stuart Lodge, @slodge, me@slodge.com
++
++using MvvmCross.Platform;
++using MvvmCross.Platform.Logging;
++
++namespace MvvmCross
++{
++    internal static class MvxAndroidLog
++    {
++        internal static IMvxLog Instance { get; } = Mvx.Resolve<IMvxLogProvider>().GetLogFor(""MvxAndroid"");
++    }
++}",Not sure I am a big fan of these duplicated Log classes.
+3019,"@@ -39,6 +39,10 @@ import (
+
+ const (
+ 	reasonDomainVerified = ""DomainVerified""
++	CleanUpError         = ""CleanUpError""
++	PresentError         = ""PresentError""
++	Presented            = ""Presented""
++	Failed               = ""Failed""
+ )
+
+ // solver solves ACME challenges by presenting the given token and key in an","It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` ."
+3020,"@@ -32,7 +32,7 @@ const constexpr double LOOKAHEAD_DISTANCE_WITHOUT_LANES = 10.0;
+ // smaller widths, ranging from 2.5 to 3.25 meters. As a compromise, we use
+ // the 3.25 here for our angle calculations
+ const constexpr double ASSUMED_LANE_WIDTH = 3.25;
+-const constexpr double FAR_LOOKAHEAD_DISTANCE = 30.0;
++const constexpr double FAR_LOOKAHEAD_DISTANCE = 20.0;
+
+ // The count of lanes assumed when no lanes are present. Since most roads will have lanes for both
+ // directions or a lane count specified, we use 2. Overestimating only makes our calculations safer,","Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far."
+3021,"@@ -78,6 +78,12 @@ typedef enum {
+ 	CONTAINER_MODE_UMBRELLA
+ } container_mode_t;
+
++struct environment {
++	char *tarball;     /* Conda environemnt as produced by conda-pack. */
++	char *expansion;   /* Directory in cache/. Only set when environemnt has been expanded.*/
++	int error;         /* Whether the expansion had an error. 1 for yes, 0 for no. */
++};
++
+ #define DOCKER_WORK_DIR ""/home/worker""
+
+ // In single shot mode, immediately quit when disconnected.",Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda.
+3022,"@@ -28,6 +28,8 @@ func TestStore_ListProjects(t *testing.T) {
+ 	cowProjectString, err := marshal(cowProject)
+ 	require.NoError(t, err, ""Marshal project should not fail"")
+
++	lastPageInPaginatedResp := false
++
+ 	testCases := map[string]struct {
+ 		mockGetParametersByPath func(t *testing.T, param *ssm.GetParametersByPathInput) (*ssm.GetParametersByPathOutput, error)
+ ",Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses
+3023,"@@ -130,6 +130,9 @@ class BaseSnapshot implements Snapshot {
+     if (dataManifests == null) {
+       this.dataManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
+           manifest -> manifest.content() == ManifestContent.DATA));
++    }
++
++    if (deleteManifests == null) {
+       this.deleteManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
+           manifest -> manifest.content() == ManifestContent.DELETES));
+     }",What about using `dataManifests == null || deleteManifests == null`?
+3024,"@@ -469,7 +469,7 @@ public class IndexSearcher {
+
+       @Override
+       public TopScoreDocCollector newCollector() throws IOException {
+-        return TopScoreDocCollector.create(cappedNumHits, after, TOTAL_HITS_THRESHOLD);
++        return TopScoreDocCollector.create(cappedNumHits, after, new GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD));
+       }
+
+       @Override",The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice.
+3025,"@@ -15,10 +15,14 @@
+ package openflow
+
+ import (
++	""antrea.io/antrea/pkg/agent/config""
++	""antrea.io/antrea/pkg/agent/openflow/cookie""
+ 	""fmt""
++	""k8s.io/client-go/tools/cache""
+ 	""net""
+ 	""strconv""
+ 	""strings""
++	""sync""
+
+ 	""k8s.io/apimachinery/pkg/util/intstr""
+ 	""k8s.io/klog/v2""",move this to below `antrea.io` import section
+3026,"@@ -80,6 +80,8 @@ namespace OpenTelemetry.Trace
+         /// </summary>
+         /// <param name=""activity"">Activity instance.</param>
+         /// <param name=""kind"">Activity execution kind.</param>
++        /// <remarks>This extension method should only be used on <see cref=""Activity""/> instances that were created
++        /// via older means that predate <see cref=""ActivitySource""/>.</remarks>
+         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+         public static void SetKind(this Activity activity, ActivityKind kind)
+         {",Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?
+3027,"@@ -320,6 +320,18 @@ func (b *EthAPIBackend) SendTx(ctx context.Context, signedTx *types.Transaction)
+ 			if len(signedTx.Data()) > b.MaxCallDataSize {
+ 				return fmt.Errorf(""Calldata cannot be larger than %d, sent %d"", b.MaxCallDataSize, len(signedTx.Data()))
+ 			}
++			// The gas price must be a multiple of a gwei
++			if new(big.Int).Mod(signedTx.GasPrice(), big.NewInt(1e6)).Cmp(common.Big0) != 0 {
++				return errors.New(""Gas price must be a multiple of 1,000,000 wei"")
++			}
++			// If there is a value field set then reject transactions that
++			// contain calldata. The feature of sending transactions with value
++			// and calldata will be added in the future.
++			if signedTx.Value().Cmp(common.Big0) != 0 {
++				if len(signedTx.Data()) > 0 {
++					return errors.New(""Cannot send transactions with value and calldata"")
++				}
++			}
+ 		}
+ 		return b.eth.syncService.ApplyTransaction(signedTx)
+ 	}",gas price don't need to be a multiple cuz we support allll gas prices now
+3028,"@@ -81,5 +81,10 @@ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.Interfaces
+         /// Send the request to abort the test run
+         /// </summary>
+         void SendTestRunAbort();
++
++        /// <summary>
++        /// handle client process exit
++        /// </summary>
++        void OnClientProcessExit();
+     }
+ }",We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?
+3029,"@@ -1167,6 +1167,8 @@ def main(args,
+                   'address.\n')
+         else:
+             print('Error occurred on the server side, message: {}'.format(e))
++    except Exception as e:  # pylint: disable=broad-except
++        print ('Error occurred, message: {}'.format(e.message))
+     return config
+
+ ","It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first."
+3030,"@@ -18,7 +18,8 @@ return [
+             'widget_title_default' => 'Website',
+             'online' => 'Online',
+             'maintenance' => 'In maintenance',
+-            'manage_themes' => 'Manage themes'
++            'manage_themes' => 'Manage themes',
++            'customize_theme' => 'Customize Theme'
+         ]
+     ],
+     'theme' => [","This already exists under the `theme` lang key, please remove this."
+3031,"@@ -223,6 +223,10 @@ class SetupUsingGCP extends Component {
+ 		return (
+ 			<Fragment>
+ 				<Header />
++				{ /*
++					Note: this component doesn't use hooks and thus can't access the
++					feature flags, so we don't render the HelpMenu here.
++				*/ }
+ 				<div className=""googlesitekit-wizard"">
+ 					<div className=""mdc-layout-grid"">
+ 						<div className=""mdc-layout-grid__inner"">",Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet).
+3032,"@@ -29,7 +29,7 @@ module Beaker
+         v_file << ""    v.vm.box = '#{host['box']}'\n""
+         v_file << ""    v.vm.box_url = '#{host['box_url']}'\n"" unless host['box_url'].nil?
+         v_file << ""    v.vm.base_mac = '#{randmac}'\n""
+-        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""255.255.0.0\""\n""
++        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
+         v_file << ""  end\n""
+         @logger.debug ""created Vagrantfile for VagrantHost #{host.name}""
+       end",I believe that you end up printing out the result of the assignment here instead of the netmask.
+3033,"@@ -0,0 +1,11 @@
++export const CREDENTIALS = {
++  user: 'test',
++  password: 'test'
++};
++
++export const TARBALL = 'tarball-blahblah-file.name';
++export const PORT_SERVER_APP = '55550';
++export const PORT_SERVER_1 = '55551';
++export const PORT_SERVER_2 = '55552';
++export const PORT_SERVER_3 = '55553';
++export const DOMAIN_SERVERS = 'localhost';",We have to update the filename here.
+3034,"@@ -121,6 +121,11 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""                         (see the --cpp-str-flex-ctor option to change this behavior).\n""
+     ""  --cpp-str-flex-ctor    Don't construct custom string types by passing std::string\n""
+     ""                         from Flatbuffers, but (char* + length).\n""
++    ""  --cpp-field-case STYLE Generate C++ fields using selected case style.\n""
++    ""                         Supported STYLE values:\n""
++    ""                          * 'unchanged' - leave unchanged (default);\n""
++    ""                          * 'upper' - schema snake_case emits UpperCamel;\n""
++    ""                          * 'lower' - schema snake_case emits lowerCamel.\n""
+     ""  --cpp-std CPP_STD      Generate a C++ code using features of selected C++ standard.\n""
+     ""                         Supported CPP_STD values:\n""
+     ""                          * 'c++0x' - generate code compatible with old compilers;\n""",The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case.
+3035,"@@ -95,9 +95,6 @@ ot_admin_builtin_upgrade (int argc, char **argv, GCancellable *cancellable, GErr
+                                                   ""override-commit"", NULL);
+         }
+
+-      /* Should we consider requiring --discard-hotfix here? */
+-      origin_changed |= g_key_file_remove_key (origin, ""origin"", ""unlocked"", NULL);
+-
+       if (origin_changed)
+         {
+           /* XXX GCancellable parameter is not used. */","I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat."
+3036,"@@ -18,6 +18,9 @@ package org.hyperledger.besu.evmtool;
+ import org.hyperledger.besu.config.GenesisConfigOptions;
+ import org.hyperledger.besu.consensus.clique.CliqueProtocolSchedule;
+ import org.hyperledger.besu.consensus.ibft.IbftBlockHeaderFunctions;
++import org.hyperledger.besu.crypto.KeyPairSecurityModule;
++import org.hyperledger.besu.crypto.NodeKey;
++import org.hyperledger.besu.crypto.SECP256K1;
+ import org.hyperledger.besu.ethereum.core.BlockHeaderFunctions;
+ import org.hyperledger.besu.ethereum.mainnet.ProtocolSchedule;
+ ",In my opinion I think it is possible to add `private final` here
+3037,"@@ -265,7 +265,7 @@ func (p *Builder) writeProgramHeader() {
+ 	p.b.LoadMapFD(R1, uint32(p.stateMapFD)) // R1 = 0 (64-bit immediate)
+ 	p.b.Call(HelperMapLookupElem)           // Call helper
+ 	// Check return value for NULL.
+-	p.b.JumpEqImm64(R0, 0, ""deny"")
++	p.b.JumpEqImm64(R0, 0, ""exit"")
+ 	// Save state pointer in R9.
+ 	p.b.Mov64(R9, R0)
+ 	p.b.LabelNextInsn(""policy"")","Feel like ""exit"" doesn't convey that the packet will be dropped. ""drop-and-exit"" or ""error-exit"" maybe?"
+3038,"@@ -1330,7 +1330,7 @@ static bool check_main_create(pass_opt_t* opt, ast_t* ast)
+   if(ast_childcount(params) != 1)
+   {
+     ast_error(opt->check.errors, params,
+-      ""the create constructor of a Main actor must take a single Env ""
++      ""A Main actor must have a create constructor which takes a single Env ""
+       ""parameter"");
+     ok = false;
+   }","How do you feel about ""The Main actor"" instead of ""A Main actor"", while we're already here changing the message?"
+3039,"@@ -38,6 +38,7 @@ public interface PermissionNameProvider {
+     COLL_READ_PERM(""collection-admin-read"", null),
+     CORE_READ_PERM(""core-admin-read"", null),
+     CORE_EDIT_PERM(""core-admin-edit"", null),
++    ZK_READ_PERM(""zk-read"", null),
+     READ_PERM(""read"", ""*""),
+     UPDATE_PERM(""update"", ""*""),
+     CONFIG_EDIT_PERM(""config-edit"", unmodifiableSet(new HashSet<>(asList(""*"", null)))),","I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?"
+3040,"@@ -103,7 +103,7 @@ def as_spark_type(tpe) -> types.DataType:
+     """"""
+     # TODO: Add ""boolean"" and ""string"" types.
+     # ArrayType
+-    if tpe in (np.ndarray,):
++    if tpe in (list, np.ndarray,):
+         return types.ArrayType(types.StringType())
+     elif hasattr(tpe, ""__origin__"") and issubclass(tpe.__origin__, list):
+         return types.ArrayType(as_spark_type(tpe.__args__[0]))",Is this reasonable?
+3041,"@@ -21,6 +21,7 @@ class AutoAugment(object):
+             augment images.
+
+     Examples:
++        TODO: Implement 'Shear', 'Sharpness' and 'Rotate' transforms
+         >>> replace = (104, 116, 124)
+         >>> policies = [
+         >>>     [",We may move this TODO to Line15.
+3042,"@@ -263,7 +263,12 @@ class OrderController extends BaseFrontController
+
+         /* check cart count */
+         $this->checkCartNotEmpty();
+-
++
++        /* check stock not empty */
++        if(true === ConfigQuery::checkAvailableStock()) {
++          return $this->checkStockNotEmpty();
++        }
++
+         /* check delivery address and module */
+         $this->checkValidDelivery();
+ ","You have to verify the return type. If it's a reponse, return it. Otherwise do nothing."
+3043,"@@ -44,15 +44,17 @@
+
+ #include <Kokkos_Core.hpp>
+ #include <Kokkos_Timer.hpp>
+-#include <bench.hpp>
+ #include <cstdlib>
+
++template <class T>
++void run_stride_unroll(int, int, int, int, int, int, int, int);
++
+ int main(int argc, char* argv[]) {
+   Kokkos::initialize();
+
+   if (argc < 10) {
+     printf(""Arguments: N K R D U F T S\n"");
+-    printf(""  P:   Precision (1==float, 2==double)\n"");
++    printf(""  P:   Precision (1==float, 2==double, 3==int32_t, 4==int64_t)\n"");
+     printf(""  N,K: dimensions of the 2D array to allocate\n"");
+     printf(""  R:   how often to loop through the K dimension with each team\n"");
+     printf(""  D:   distance between loaded elements (stride)\n"");",No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch)
+3044,"@@ -203,6 +203,8 @@ class TestPython3Checker(testutils.CheckerTestCase):
+             '[x for x in {}]',
+             'func({})',
+             'a, b = {}',
++            'max({}())',
++            'min({}())',
+         ]
+         non_iterating_code = [
+             'x = __({}())',","these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?"
+3045,"@@ -90,7 +90,7 @@ public class TestAvroNameMapping extends TestAvroReadProjection {
+     projected = writeAndRead(writeSchema, readSchema, record, nameMapping);
+     Record projectedL1 = ((Map<String, Record>) projected.get(""location"")).get(""l1"");
+     Assert.assertNotNull(""Field missing from table mapping is renamed"", projectedL1.getSchema().getField(""long_r2""));
+-    Assert.assertNull(""location.value.long, should not be read"", projectedL1.get(""long_r2""));
++    Assert.assertNull(""location.value.long, should not be read"", projectedL1.get(""long""));
+   }
+
+   @Test",Why did this need to change?
+3046,"@@ -0,0 +1,14 @@
++// Copyright (c) 2019 IoTeX Foundation
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package factory
++
++import ""github.com/iotexproject/iotex-core/action/protocol""
++
++// BranchDB defines the interface of an branch state db, which could start a new transaction
++type BranchDB interface {
++	NewTransaction() (protocol.Transaction, error)
++}",/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`)
+3047,"@@ -128,6 +128,7 @@ public class ZkStateReader implements SolrCloseable {
+
+   public static final String CONFIGS_ZKNODE = ""/configs"";
+   public final static String CONFIGNAME_PROP = ""configName"";
++  public final static String COLLECTION_CONFIG_PROP = ""collection.configName"";
+
+   public static final String SAMPLE_PERCENTAGE = ""samplePercentage"";
+ ",Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name.
+3048,"@@ -60,8 +60,11 @@ public class ITZipkinMetricsHealth {
+   }
+
+   @Test public void healthIsOK() throws Exception {
+-    assertThat(get(""/health"").isSuccessful())
+-      .isTrue();
++    Response check = get(""/health"");
++    assertThat(check.isSuccessful()).isTrue();
++    assertThat(check.body().string()).isEqualTo(
++      ""{\""status\"":\""UP\"",\""zipkin\"":{\""status\"":\""UP\"",\""details\"":{\""InMemoryStorage{}\"":{\""status\"":\""UP\""}}}}""
++    );
+
+     // ensure we don't track health in prometheus
+     assertThat(scrape())",in preparation of directly writing the /health endpoint one day.. we should have content checks.
+3049,"@@ -10,7 +10,7 @@ import (
+ type MultipleIDMatchesError struct{ prefix string }
+
+ func (e *MultipleIDMatchesError) Error() string {
+-	return fmt.Sprintf(""multiple IDs with prefix %s found"", e.prefix)
++	return fmt.Sprintf(""multiple IDs with prefix %q found"", e.prefix)
+ }
+
+ // A NoIDByPrefixError is returned by Find() when no ID for a given prefix",question (non-blocking): Is there a benefit from using `%q` instead of `%s`?
+3050,"@@ -26,7 +26,6 @@ std::string MetaUtils::spaceKey(GraphSpaceID spaceId) {
+     return key;
+ }
+
+-
+ std::string MetaUtils::spaceVal(int32_t partsNum, int32_t replicaFactor, const std::string& name) {
+     std::string val;
+     val.reserve(256);",I would suggest to keep two empty lines between functions in cpp files
+3051,"@@ -178,7 +178,7 @@ void runTests(int64_t numElements) {
+     {
+         test(0x01, C_d, C_h, numElements, syncNone, true /*expectMismatch*/);
+         test(0x02, C_d, C_h, numElements, syncNullStream, false /*expectMismatch*/);
+-        test(0x04, C_d, C_h, numElements, syncOtherStream, true /*expectMismatch*/);
++        test(0x04, C_d, C_h, numElements, syncOtherStream, false /*expectMismatch*/);
+         test(0x08, C_d, C_h, numElements, syncDevice, false /*expectMismatch*/);
+
+         // Sending a marker to to null stream may synchronize the otherStream",This change causes the test to fail on both rocm-1.9.x and rocm-head.
+3052,"@@ -0,0 +1,17 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd;
++
++/**
++ * This interface allows to determine which rule violations are fixable, and with which class the fixes will be made.
++ */
++public interface AutoFixableRuleViolation extends RuleViolation {
++
++    /**
++     * Obtain the class which will attempt to fix the AST.
++     * @return
++     */
++    Class<? extends RuleViolationFix> getRuleViolationFixer();
++}",I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package
+3053,"@@ -266,7 +266,18 @@ def parse_compile_commands_json(logfile, parseLogOptions):
+         results = option_parser.parse_options(command)
+
+         action.original_command = command
+-        action.analyzer_options = results.compile_opts
++
++        # If the original include directory could not be found
++        # in the filesystem, it is possible that it was provided
++        # relative to the working directory in the compile json.
++        compile_opts = results.compile_opts
++        for i, opt in enumerate(compile_opts):
++            if opt.startswith('-I'):
++                inc_dir = opt[2:].strip()
++                if not os.path.isdir(inc_dir):
++                    compile_opts[i] = '-I' + \
++                        os.path.join(entry['directory'], inc_dir)
++        action.analyzer_options = compile_opts
+
+         action.lang = results.lang
+         action.target = results.arch",Use `os.path.join` for path concatenation.
+3054,"@@ -18,11 +18,13 @@ from .retina_head import RetinaHead
+ from .retina_sepbn_head import RetinaSepBNHead
+ from .rpn_head import RPNHead
+ from .ssd_head import SSDHead
++from .yolact_head import YolactHead, YolactProtonet, YolactSegmHead
+
+ __all__ = [
+     'AnchorFreeHead', 'AnchorHead', 'GuidedAnchorHead', 'FeatureAdaption',
+     'RPNHead', 'GARPNHead', 'RetinaHead', 'RetinaSepBNHead', 'GARetinaHead',
+     'SSDHead', 'FCOSHead', 'RepPointsHead', 'FoveaHead',
+     'FreeAnchorRetinaHead', 'ATSSHead', 'FSAFHead', 'NASFCOSHead',
+-    'PISARetinaHead', 'PISASSDHead', 'GFLHead', 'CornerHead'
++    'PISARetinaHead', 'PISASSDHead', 'GFLHead', 'CornerHead', 'YolactHead',
++    'YolactSegmHead', 'YolactProtonet'
+ ]","Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead"
+3055,"@@ -43,7 +43,7 @@ type harness struct {
+ }
+
+ func (h *harness) MakeDriver(ctx context.Context) (driver.Crypter, error) {
+-	return &Crypter{
++	return &crypter{
+ 		keyID: &KeyID{
+ 			ProjectID: projectID,
+ 			Location:  location,",The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%.
+3056,"@@ -1038,7 +1038,14 @@ class CommentAnalyzer
+
+
+                     if ($method_tree_child->children) {
+-                        $param_type = Type::getTypeFromTree($method_tree_child->children[0], $codebase);
++                        try {
++                            $param_type = Type::getTypeFromTree($method_tree_child->children[0], $codebase);
++                        } catch (TypeParseTreeException $e) {
++                            $msg = 'Badly-formatted @method parameters for ' . $method_entry;
++                            $msg .= '; have you checked if a variable passed by reference has a space between';
++                            $msg .= ' the ampersand and the start of the variable?';
++                            throw new DocblockParseException($msg);
++                        }
+                         $docblock_lines[] = '@param \\' . $param_type . ' '
+                             . ($method_tree_child->variadic ? '...' : '')
+                             . $method_tree_child->name;",I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar.
+3057,"@@ -83,7 +83,16 @@ public class AntlrBaseNode extends ParserRuleContext implements AntlrNode {
+
+     @Override
+     public Node jjtGetChild(final int index) {
+-        return (Node) children.get(index); // TODO: review if all children are Nodes
++        try {
++            return (Node) children.get(index);
++        } catch (final ClassCastException e) {
++            return new AntlrBaseNode();
++        }
++    }
++
++    @Override
++    public String getImage() {
++        return getText();
+     }
+
+     @Override","The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose."
+3058,"@@ -12,14 +12,14 @@ module RSpec
+
+       def initialize
+         @full_backtrace = false
+-        @exclusion_patterns = [] << Regexp.union(
++        @system_exclusion_patterns = [] << Regexp.union(
+           *[""/lib\d*/ruby/"",
+             ""org/jruby/"",
+             ""bin/"",
+             ""/gems/"",
+             ""lib/rspec/(core|expectations|matchers|mocks)""].
+-          map {|s| Regexp.new(s.gsub(""/"", File::SEPARATOR))}
+-        )
++          map {|s| Regexp.new(s.gsub(""/"", File::SEPARATOR))})
++        @exclusion_patterns = [] + @system_exclusion_patterns
+         @inclusion_patterns = [Regexp.new(Dir.getwd)]
+       end
+ ",The `[] +` seems weird to me. Why is it there?
+3059,"@@ -1,7 +1,7 @@
+ class FollowUp < ActiveRecord::Base
+   belongs_to :course
+-  validates_presence_of :email
+-  validates_format_of :email, with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i, on: :create
++  EMAIL_FORMAT = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i
++  validates :email, presence: true, format: { with: EMAIL_FORMAT }, on: :create
+
+   scope :have_not_notified, where(notified_at: nil)
+ ",Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?
+3060,"@@ -251,6 +251,17 @@ func checksum(bytes []byte) string {
+ 	return hex.EncodeToString(d[:])
+ }
+
++func isEmptyYaml(yaml []byte) bool {
++	isEmpty := true
++	lines := bytes.Split(yaml, []byte(""\n""))
++	for _, k := range lines {
++		if string(k) != ""---"" && !bytes.HasPrefix(k, []byte(""#"")) && string(k) != """" {
++			isEmpty = false
++		}
++	}
++	return isEmpty
++}
++
+ func yamlToObjects(in io.Reader) ([]runtime.Object, error) {
+ 	var result []runtime.Object
+ 	reader := yamlDecoder.NewYAMLReader(bufio.NewReaderSize(in, 4096))",What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?
+3061,"@@ -376,7 +376,7 @@ module OrgAdmin
+           # Load the funder's template(s)
+           templates = Template.valid.publicly_visible.where(published: true, org_id: funder_id).to_a
+
+-          if org_id.present?
++          unless org_id.blank?
+             # Swap out any organisational cusotmizations of a funder template
+             templates.each do |tmplt|
+               customization = Template.valid.find_by(published: true, org_id: org_id, customization_of: tmplt.dmptemplate_id)",if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374).
+3062,"@@ -3403,6 +3403,13 @@ void Client::Handle_OP_AutoFire(const EQApplicationPacket *app)
+ 		DumpPacket(app);
+ 		return;
+ 	}
++
++	if (GetTarget() == this) {
++		this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++		auto_fire = false;
++		return;
++	}
++
+ 	bool *af = (bool*)app->pBuffer;
+ 	auto_fire = *af;
+ 	auto_attack = false;",Don't need this-> here.
+3063,"@@ -20,6 +20,9 @@ The metadata server is only accessible on GCE.
+ import httplib
+ import socket
+
++from google.auth.compute_engine import _metadata
++from google.auth.transport import requests
++
+ from google.cloud.forseti.common.util import errors
+ from google.cloud.forseti.common.util import logger
+ ","I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended."
+3064,"@@ -1095,7 +1095,7 @@ class Resource:
+                         send_alert(self.request, message, url)
+                     operator = COMPARISON.LT
+
+-                if value == """":
++                if value == """" or isinstance(value, dict):
+                     raise_invalid(self.request, **error_details)
+
+                 filters.append(Filter(self.model.modified_field, value, operator))",There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number).
+3065,"@@ -179,6 +179,18 @@ Status GoExecutor::prepareFrom() {
+                 status = Status::Error();
+                 break;
+             }
++            if (expr->isFunCallExpression()) {
++                auto *funcExpr = static_cast<FunctionCallExpression*>(expr);
++                if (*(funcExpr->name()) == ""near"") {
++                    auto v = Expression::asString(value.value());
++                    std::vector<VertexID> result;
++                    folly::split("","", v, result, true);
++                    starts_.insert(starts_.end(),
++                                   std::make_move_iterator(result.begin()),
++                                   std::make_move_iterator(result.end()));
++                    continue;
++                }
++            }
+             auto v = value.value();
+             if (!Expression::isInt(v)) {
+                 status = Status::Error(""Vertex ID should be of type integer"");","FYI, It won't have any benefit to move from trivial types."
+3066,"@@ -37,6 +37,7 @@ const (
+ 	capabilityDockerPluginInfix                 = ""docker-plugin.""
+ 	attributeSeparator                          = "".""
+ 	capabilityPrivateRegistryAuthASM            = ""private-registry-authentication.secretsmanager""
++	capabilitySecretEnvSSM                      = ""secrets-ssm-environment-variables""
+ )
+
+ // capabilities returns the supported capabilities of this agent / docker-client pair.","i missed these discussions- but ` ""secrets-ssm-environment-variables""` is what was agreed upon with cp?"
+3067,"@@ -20,6 +20,7 @@ import (
+ 	""google.golang.org/protobuf/types/known/anypb""
+ 	""gopkg.in/yaml.v3""
+
++	""github.com/gogo/protobuf/jsonpb""
+ 	gatewayv1 ""github.com/lyft/clutch/backend/api/config/gateway/v1""
+ 	""github.com/lyft/clutch/backend/middleware/timeouts""
+ )",whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?
+3068,"@@ -127,6 +127,7 @@ public class RepositoriesPanel extends StackPane {
+         this.addButton.setText(tr(""Add""));
+         this.addButton.setOnAction((ActionEvent event) -> {
+             AddRepositoryDialog dialog = new AddRepositoryDialog();
++            dialog.initOwner(this.getParent().getScene().getWindow());
+
+             Optional<RepositoryLocation<? extends Repository>> successResult = dialog.showAndWait();
+ ",Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?
+3069,"@@ -108,6 +108,7 @@ if __name__ == ""__main__"":
+                 ""pytest-xdist==2.1.0"",
+                 ""pytest==6.1.1"",
+                 ""responses==0.10.*"",
++                ""scikit-learn<1.0.0"",  # scikit-learn 1.0 requires python 3.7
+                 ""snapshottest==0.6.0"",
+                 ""tox==3.14.2"",
+                 ""tox-pip-version==0.0.7"",","Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there)."
+3070,"@@ -274,7 +274,6 @@ Status DataCollectExecutor::collectMultiplePairShortestPath(const std::vector<st
+ Status DataCollectExecutor::collectPathProp(const std::vector<std::string>& vars) {
+   DataSet ds;
+   ds.colNames = colNames_;
+-  DCHECK(!ds.colNames.empty());
+   // 0: vertices's props, 1: Edges's props 2: paths without prop
+   DCHECK_EQ(vars.size(), 3);
+ ",Why remove this?
+3071,"@@ -145,13 +145,3 @@ def test_completion_item_focus(tree, count, expected, completionview):
+         completionview.completion_item_focus(direction)
+     idx = completionview.selectionModel().currentIndex()
+     assert filtermodel.data(idx) == expected
+-
+-
+-def test_completion_item_focus_no_model(completionview):
+-    """"""Test that next/prev won't crash with no model set.
+-
+-    This can happen if completion.show and completion.auto-open are False.
+-    Regression test for issue #1722.
+-    """"""
+-    completionview.completion_item_focus('prev')
+-    completionview.completion_item_focus('next')","Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)"
+3072,"@@ -27,6 +27,7 @@ const SET_PERMISSION_SCOPE_ERROR = 'SET_PERMISSION_SCOPE_ERROR';
+
+ export const INITIAL_STATE = {
+ 	permissionError: null,
++	capabilities: global._googlesitekitUserData?.permissions || {},
+ };
+
+ export const actions = {","Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately."
+3073,"@@ -234,3 +234,17 @@ def repeat_command(win_id, count=None):
+     cmd = runners.last_command[mode_manager.mode]
+     commandrunner = runners.CommandRunner(win_id)
+     commandrunner.run(cmd[0], count if count is not None else cmd[1])
++
++@cmdutils.register(debug=True,name='debug-log-capacity')
++def log_capacity(capacity: int):
++    """"""Choose number of lines for your log.
++
++    Args:
++       capacity: Number of lines for the log.
++    """"""
++    if capacity < 0:
++        raise cmdexc.CommandError(""Please choose log capacity above 0."")
++    else:
++        log.ram_handler.change_log_capacity(capacity)
++
++","Please add a space after the comma here (generally, with arguments there's always a space after commas)."
+3074,"@@ -17,7 +17,7 @@ package org.hyperledger.besu.config.experimental;
+ import picocli.CommandLine.Option;
+
+ /**
+- * Flags defined in those class must be used with cautious, and strictly reserved to experimental
++ * Flags defined in those class must be used with caution, and strictly reserved to experimental
+  * EIPs.
+  */
+ public class ExperimentalEIPs {","From the context, should it say ""Flags defined in this class must be used with caution..."" ?"
+3075,"@@ -0,0 +1,19 @@
++module.exports = {
++  roots: [
++    ""<rootDir>/javascript/grid-ui/src""
++  ],
++  testMatch: [
++    ""<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx""
++  ],
++  transform: {
++    ""^.+\\.(ts|tsx)$"": ""ts-jest""
++  },
++  moduleFileExtensions: [""ts"", ""tsx"", ""js"", ""jsx"", ""json"", ""node""],
++  snapshotSerializers: [""enzyme-to-json/serializer""],
++  setupFilesAfterEnv: [""<rootDir>/setupTests.ts""],
++  testEnvironment: ""jsdom"",
++  moduleNameMapper: {
++    "".+\\.(svg|png|jpg|css)$"": ""identity-obj-proxy"",
++    ""selenium/javascript/grid-ui/(.*)"": ""<rootDir>/$1""
++  }
++}","We don't need this file, we can use the one that is in the grid-ui directory"
+3076,"@@ -28,6 +28,7 @@ const (
+ 	infoNoAccounts                 = ""Did not find any account. Please import or create a new one.""
+ 	infoRenamedAccount             = ""Renamed account '%s' to '%s'""
+ 	infoImportedKey                = ""Imported %s""
++	infoExportedKey                = ""Imported key for account %s: \""%s\""""
+ 	infoImportedNKeys              = ""Imported %d key%s""
+ 	infoCreatedNewAccount          = ""Created new account with address %s""
+ 	errorNameAlreadyTaken          = ""The account name '%s' is already taken, please choose another.""","""Exported key for account""?"
+3077,"@@ -37,6 +37,7 @@ namespace pwiz.Skyline.Util.Extensions
+     {
+         public const string EXT_CSV = "".csv""; // Not L10N
+         public const string EXT_TSV = "".tsv""; // Not L10N
++        public const string CRLF = ""\r\n""; // Not L10N
+
+         public static string FILTER_CSV
+         {",Normally we use Environment.NewLine unless you really want it to always be \r\n
+3078,"@@ -697,13 +697,6 @@ func (c *AuRa) verifyFamily(chain consensus.ChainHeaderReader, e consensus.Epoch
+ 	return nil
+ }
+
+-// VerifyHeaders is similar to VerifyHeader, but verifies a batch of headers. The
+-// method returns a quit channel to abort the operations and a results channel to
+-// retrieve the async verifications (the order is that of the input slice).
+-func (c *AuRa) VerifyHeaders(chain consensus.ChainHeaderReader, headers []*types.Header, _ []bool) error {
+-	return nil
+-}
+-
+ // VerifyUncles implements consensus.Engine, always returning an error for any
+ // uncles as this consensus mechanism doesn't permit uncles.
+ func (c *AuRa) VerifyUncles(chain consensus.ChainReader, header *types.Header, uncles []*types.Header) error {",why did you remove `verifyHeaders`?
+3079,"@@ -66,14 +66,14 @@ class RegistrationsController < Devise::RegistrationsController
+           if other_org.nil?
+             redirect_to(after_sign_up_error_path_for(resource), alert: _('You cannot be assigned to other organisation since that option does not exist in the system. Please contact your system administrators.')) and return
+           end
+-          params[:user][:org_id] = other_org.id
++          params[:user][:org_id] = other_org.id
+         end
+         build_resource(sign_up_params)
+         if resource.save
+           if resource.active_for_authentication?
+             set_flash_message :notice, :signed_up if is_navigational_format?
+             sign_up(resource_name, resource)
+-            UserMailer.welcome_notification(current_user).deliver
++            UserMailer.welcome_notification(current_user).deliver_now
+             unless oauth.nil?
+               # The OAuth provider could not be determined or there was no unique UID!
+               unless oauth['provider'].nil? || oauth['uid'].nil?",Thanks for cleaning up these deprecated calls
+3080,"@@ -110,13 +110,13 @@ def _create_user(username, password='', email=None, is_admin=False,
+                  requires_activation=True, requires_reset=False):
+     def check_conflicts(username, email):
+         if not VALID_USERNAME_RE.match(username):
+-            raise ValidationException(""Unacceptable username."")
++            raise ValidationException(""Invalid username."")
+         if blacklisted_name(username):
+-            raise ValidationException(""Unacceptable username."")
++            raise ValidationException(""Invalid username."")
+         if email is None:
+             raise ValidationException(""Must provide email."")
+         if not VALID_EMAIL_RE.match(email):
+-            raise ValidationException(""Unacceptable email."")
++            raise ValidationException(""Invalid email."")
+         if User.query.filter_by(name=username).one_or_none():
+             raise ConflictException(""Username already taken."")
+         if User.query.filter_by(email=email).one_or_none():","@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently."
+3081,"@@ -115,7 +115,7 @@ func parseResource(resource string) (string, string, string) {
+
+ // is resource type require remote query
+ func requireRemoteQuery(resType string) bool {
+-	return resType == model.ResourceTypeConfigmap || resType == model.ResourceTypeSecret || resType == constants.ResourceTypeService || resType == constants.ResourceTypeEndpoints
++	return resType == model.ResourceTypeConfigmap || resType == model.ResourceTypeSecret || resType == constants.ResourceTypeEndpoints
+ }
+
+ func isConnected() bool {",We support process remoteQuery for Service. Why are we removing it ?
+3082,"@@ -6,10 +6,17 @@ require 'bolt/task'
+ require 'json'
+
+ class TransportAPI < Sinatra::Base
++  # This disables Sinatra's error page generation
++  set :show_exceptions, false
++
+   get '/' do
+     200
+   end
+
++  get '/500_error' do
++    raise 'Unexpected error'
++  end
++
+   post '/ssh/run_task' do
+     content_type :json
+ ",This is specifically for testing?
+3083,"@@ -71,7 +71,6 @@ class TagsController extends AbstractAdmin
+     {
+         $view = $this->createViewModel();
+         $view->setTemplate('admin/tags/home');
+-        $view->statistics = $this->getTable('resourcetags')->getStatistics(true);
+         return $view;
+     }
+ ",I think this is related to the social stats and probably does not need to be removed.
+3084,"@@ -13,6 +13,7 @@ import { PhysicalIndexToValueMap as IndexToValueMap } from './../../translations
+ const privatePool = new WeakMap();
+ const COLUMN_SIZE_MAP_NAME = 'autoColumnSize';
+
++/* eslint-disable jsdoc/require-description-complete-sentence */
+ /**
+  * @plugin AutoColumnSize
+  *","Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins."
+3085,"@@ -58,6 +58,13 @@ func (c *azureClient) GetVirtualMachineResourceID(ctx context.Context, principal
+ 	}
+
+ 	values := result.Values()
++	for len(values) == 0 {
++		nerr := result.NextWithContext(ctx)
++		if nerr != nil {
++			return """", errs.Wrap(nerr)
++		}
++		values = result.Values()
++	}
+ 	if len(values) == 0 {
+ 		return """", errs.New(""principal %q not found"", principalID)
+ 	}",This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`.
+3086,"@@ -1358,6 +1358,10 @@ func (exp *Service) GetBlockOrActionByHash(hashStr string) (explorer.GetBlkOrAct
+ 		return explorer.GetBlkOrActResponse{Execution: &exe}, nil
+ 	}
+
++	if exe, err := exp.GetAddressDetails(hashStr); err == nil {
++		return explorer.GetBlkOrActResponse{AddressDetails: &exe}, nil
++	}
++
+ 	return explorer.GetBlkOrActResponse{}, nil
+ }
+ ",unknown field AddressDetails in struct literal (from `typecheck`)
+3087,"@@ -33,7 +33,13 @@ func sessionForRegion(region string) (*session.Session, error) {
+ 		return s.(*session.Session), nil
+ 	}
+
+-	ns, err := session.NewSession(aws.NewConfig().WithRegion(region))
++	ns, err := session.NewSessionWithOptions(session.Options{
++		// Provide SDK Config options, such as Region.
++		Config: aws.Config{
++			Region: aws.String(region),
++		},
++	})
++
+ 	if err != nil {
+ 		return nil, err
+ 	}","Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?"
+3088,"@@ -67,9 +67,9 @@ namespace pwiz.Skyline.Model.Results
+                 var newTimeIntensities = GetTimeIntensities(Source);
+                 if (newTimeIntensities != null)
+                 {
+-                    if (oldTimeIntensities != null)
++                    if (oldTimeIntensities != null && oldTimeIntensities.NumPoints > 0)
+                     {
+-                        var oldTime = oldTimeIntensities.Times[ScanIndex];
++                        var oldTime = oldTimeIntensities.Times[Math.Min(ScanIndex, oldTimeIntensities.NumPoints - 1)];
+                         ScanIndex = newTimeIntensities.IndexOfNearestTime(oldTime);
+                     }
+                     else",Not sure what this is. Bad merge?
+3089,"@@ -1318,9 +1318,12 @@ func (s *Server) updateAccountWithClaimJWT(acc *Account, claimJWT string) error
+ 	if acc == nil {
+ 		return ErrMissingAccount
+ 	}
+-	if acc.claimJWT != """" && acc.claimJWT == claimJWT && !acc.incomplete {
++	acc.mu.Lock()
++	sameClaim := acc.claimJWT != """" && acc.claimJWT == claimJWT && !acc.incomplete
++	acc.mu.Unlock()
++	if sameClaim {
+ 		s.Debugf(""Requested account update for [%s], same claims detected"", acc.Name)
+-		return ErrAccountResolverSameClaims
++		return nil
+ 	}
+ 	accClaims, _, err := s.verifyAccountClaims(claimJWT)
+ 	if err == nil && accClaims != nil {",I think this may be a RW lock.
+3090,"@@ -1,4 +1,4 @@
+-package pluginhelper
++package helpers
+
+ import (
+ 	""bytes""",Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?
+3091,"@@ -810,6 +810,14 @@ void Client::SendTradeskillSearchResults(
+ 				continue;
+ 			}
+ 		}
++
++		//Check if we need to learn it before sending them the recipe..
++		DBTradeskillRecipe_Struct spec;
++		if (content_db.GetTradeRecipe(recipe_id, objtype, someid, this->CharacterID(), &spec)) {
++			if ((spec.must_learn & 0xf) && !spec.has_learnt) {
++				continue;
++			}
++		}
+
+ 		auto               outapp = new EQApplicationPacket(OP_RecipeReply, sizeof(RecipeReply_Struct));
+ 		RecipeReply_Struct *reply = (RecipeReply_Struct *) outapp->pBuffer;",Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check
+3092,"@@ -386,6 +386,8 @@ class Index(IndexOpsMixin):
+         array([0, 1, 2, 3])
+         >>> ks.DataFrame({'a': ['a', 'b', 'c']}, index=[[1, 2, 3], [4, 5, 6]]).index.to_numpy()
+         array([(1, 4), (2, 5), (3, 6)], dtype=object)
++        >>> ks.DataFrame({'a': ['a', 'b', 'c']}, index=[[1, 2, 3], [4, 5, 6]]).index.to_numpy(copy=True)
++        array([(1, 4), (2, 5), (3, 6)], dtype=object)
+         """"""
+         result = np.asarray(self.to_pandas()._values, dtype=dtype)
+         if copy:",too long here. (104 > 100)
+3093,"@@ -210,7 +210,14 @@ namespace Nethermind.DataMarketplace.Subprotocols
+             }
+
+             Logger.Warn($""GETTING MESSAGE: ndm.{NdmMessageCode.GetDescription(message.PacketType)}"");
+-            MessageHandlers[message.PacketType](message);
++            try
++            {
++                MessageHandlers[message.PacketType](message);
++            }
++            catch(KeyNotFoundException)
++            {
++                Logger.Error(""$There is no handler registered for this message"");
++            }
+         }
+
+         protected virtual void Handle(HiMessage message)",Use TryGetValue instead of catching exception
+3094,"@@ -4,12 +4,12 @@ feature 'Admin manages mentors' do
+   scenario 'creating a new mentor' do
+     user = create(:admin)
+
+-    visit admin_path(as: user)
++    visit admin_root_path(as: user)
+     click_link 'Mentors'
+-    click_link 'Add new'
++    click_link 'New mentor'
+     select(user.name, from: 'User')
+-    click_button 'Save'
++    click_button 'Create Mentor'
+
+-    expect(page).to have_content('Mentor successfully created')
++    expect(page).to have_content('Mentor was successfully created')
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+3095,"@@ -61,6 +61,17 @@ namespace fastrtps {
+ namespace rtps {
+
+
++static void add_statistics_sent_submessage(
++        CacheChange_t* change,
++        size_t num_locators)
++{
++    static_cast<void>(change);
++    static_cast<void>(num_locators);
++
++#ifdef FASTDDS_STATISTICS
++    change->num_sent_submessages += num_locators;
++#endif // ifdef FASTDDS_STATISTICS
++}
+
+ /**
+  * Loops over all the readers in the vector, applying the given routine.",I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct.
+3096,"@@ -74,10 +74,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+             }
+         }
+
+-        // Review: This is called when a CancellationToken fires mid-write. In HTTP/1.x, this aborts the entire connection.
+-        // Should we do that here?
++        // This is called when a CancellationToken fires mid-write. In HTTP/1.x, this aborts the entire connection.
++        // For HTTP/2 we abort the stream.
+         void IHttpOutputAborter.Abort(ConnectionAbortedException abortReason)
+         {
++            _stream.ResetAndAbort(abortReason, Http2ErrorCode.INTERNAL_ERROR);
+             Dispose();
+         }
+ ","You add a stream back reference for trailers, and all of the sudden we have tight coupling!  "
+3097,"@@ -2,6 +2,7 @@ using System;
+ using System.Collections;
+ using System.Collections.Concurrent;
+ using System.Collections.Generic;
++using System.Linq;
+ using Datadog.Trace.ClrProfiler.Emit;
+ using Datadog.Trace.ExtensionMethods;
+ using Datadog.Trace.Headers;",I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file.
+3098,"@@ -65,14 +65,14 @@
+ 	return modules;
+ }([
+ /* 0 */
+-/***/ function(module, exports, __webpack_require__) {
++/***/ (function(module, exports, __webpack_require__) {
+
+ 	module.exports = __webpack_require__(1);
+
+
+-/***/ },
++/***/ }),
+ /* 1 */
+-/***/ function(module, exports, __webpack_require__) {
++/***/ (function(module, exports, __webpack_require__) {
+
+ 	'use strict';
+ ","Please avoid committing build artifacts, as they produce unnecessary conflicts and noise."
+3099,"@@ -101,7 +101,7 @@ class RetryWrapper:
+
+         if name in self.__unwrap_methods:
+             return partial(x.__func__, self)
+-        elif hasattr(x, ""__call__""):
++        elif callable(x):
+             return self.__wrap_method_with_call_and_maybe_retry(x)
+         else:
+             return x",this is vendored code so i would hesitate to make random changes to it
+3100,"@@ -34,7 +34,13 @@ type payoutInfo struct {
+ 	// in Ethereum address format
+ 	// required: true
+ 	// example: 0x000000000000000000000000000000000000000a
+-	EthAddress   string `json:""ethAddress""`
++	EthAddress string `json:""ethAddress""`
++}
++
++// swagger:model ReferralInfoDTO
++type referralInfo struct {
++	// required: true
++	// example: ABC123
+ 	ReferralCode string `json:""referral_code""`
+ }
+ ",We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case
+3101,"@@ -10,6 +10,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+     public static class HttpContextIntegration
+     {
+         private const string IntegrationName = ""HttpContext"";
++        private const string DefaultHttpContextTypeName = ""HttpContext"";
+         private static readonly ILog Log = LogProvider.GetLogger(typeof(HttpContextIntegration));
+
+         /// <summary>","Should this be `""Microsoft.AspNetCore.Http.DefaultHttpContext""`?"
+3102,"@@ -68,7 +68,6 @@ interface ArrayType<T> {
+     /** Repeatedly group an array into equal sized sub-trees */
+     default Object grouped(Object array, int groupSize) {
+         final int arrayLength = lengthOf(array);
+-        assert arrayLength > groupSize;
+         final Object results = obj().newInstance(1 + ((arrayLength - 1) / groupSize));
+         obj().setAt(results, 0, copyRange(array, 0, groupSize));
+ ","removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/"
+3103,"@@ -47,8 +47,14 @@ class MessageDefinitionStore:
+         self._messages_definitions[message.msgid] = message
+         self._msgs_by_category[message.msgid[0]].append(message.msgid)
+
++    # We disable the message here because MessageDefinitionStore is only
++    # initialized once and due to the size of the class does not run the
++    # risk of creating a large memory leak.
++    # See discussion in: https://github.com/PyCQA/pylint/pull/5673
+     @functools.lru_cache()
+-    def get_message_definitions(self, msgid_or_symbol: str) -> List[MessageDefinition]:
++    def get_message_definitions(  # pylint: disable=lru-cache-decorating-method
++        self, msgid_or_symbol: str
++    ) -> List[MessageDefinition]:
+         """"""Returns the Message definition for either a numeric or symbolic id.
+
+         The cache has no limit as its size will likely stay minimal. For each message we store",Do we want to raise on the function or on the decorator?
+3104,"@@ -38,7 +38,7 @@ class Listen(object):
+             user_name=j.get('user_name', """"),
+             timestamp=datetime.utcfromtimestamp(float(j['listened_at'])),
+             artist_msid=j['track_metadata']['additional_info'].get('artist_msid'),
+-            album_msid=j['track_metadata']['additional_info'].get('album_msid'),
++            album_msid=j['track_metadata']['additional_info'].get('release_msid'),
+             recording_msid=j.get('recording_msid'),
+             data=j.get('track_metadata')
+         )",How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?
+3105,"@@ -96,13 +96,13 @@ func (n *Namespaces) Remove(t NamespaceType) bool {
+ 	return true
+ }
+
+-func (n *Namespaces) Add(t NamespaceType, path string) {
++func (n *Namespaces) Add(t NamespaceType, path string) bool {
+ 	i := n.index(t)
+ 	if i == -1 {
+ 		*n = append(*n, Namespace{Type: t, Path: path})
+-		return
++		return true
+ 	}
+-	(*n)[i].Path = path
++	return false
+ }
+
+ func (n *Namespaces) index(t NamespaceType) int {","You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that."
+3106,"@@ -10,6 +10,16 @@
+  * @return {Boolean} the element's hidden status
+  */
+ dom.isHiddenWithCSS = function isHiddenWithCSS(el, descendentVisibilityValue) {
++	const vNode = axe.utils.getNodeFromTree(el);
++
++	if (vNode._isHiddenWithCSS === void 0) {
++		vNode._isHiddenWithCSS = _isHiddenWithCSS(el, descendentVisibilityValue);
++	}
++
++	return vNode._isHiddenWithCSS;
++};
++
++function _isHiddenWithCSS(el, descendentVisibilityValue) {
+ 	if (el.nodeType === 9) {
+ 		// 9 === Node.DOCUMENT
+ 		return false;",@straker should this not push to `vnode._cache.isHiddenWithCSS`?
+3107,"@@ -12,8 +12,8 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+
+-// Package driver provides the interface for providers of runtimevar.  This serves as a contract
+-// of how the runtimevar API uses a provider implementation.
++// Package driver defines an interface that the runtimevar package uses to
++// interact with the underlying runtime configuration services.
+ package driver // import ""gocloud.dev/runtimevar/driver""
+
+ import (","""an interface"" in conceptual sense vs ""interfaces"" or ""set of interfaces"", referring to the Go interfaces - database/sql uses the latter, should we?"
+3108,"@@ -335,8 +335,11 @@ public class DownloadService extends Service {
+                             && String.valueOf(HttpURLConnection.HTTP_GONE).equals(status.getReasonDetailed());
+                     boolean httpBadReq = status.getReason() == DownloadError.ERROR_HTTP_DATA_ERROR
+                             && String.valueOf(HttpURLConnection.HTTP_BAD_REQUEST).equals(status.getReasonDetailed());
++                    boolean ioError = status.getReason() == DownloadError.ERROR_IO_ERROR;
++                    boolean connectError = status.getReason() == DownloadError.ERROR_CONNECTION_ERROR;
+
+-                    if (httpNotFound || forbidden || notEnoughSpace || wrongFileType || httpGone || httpBadReq ) {
++                    if (httpNotFound || forbidden || notEnoughSpace || wrongFileType
++                            || httpGone || httpBadReq || ioError || connectError) {
+                         try {
+                             DBWriter.saveFeedItemAutoDownloadFailed(item).get();
+                         } catch (ExecutionException | InterruptedException e) {","This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)"
+3109,"@@ -247,7 +247,8 @@ func (brq *blockRetrievalQueue) PutInCaches(ctx context.Context,
+
+ // checkCaches copies a block into `block` if it's in one of our caches.
+ func (brq *blockRetrievalQueue) checkCaches(ctx context.Context,
+-	kmd KeyMetadata, ptr BlockPointer, block Block) (PrefetchStatus, error) {
++	kmd KeyMetadata, ptr BlockPointer, block Block, doSync bool) (
++	PrefetchStatus, error) {
+ 	// Attempt to retrieve the block from the cache. This might be a specific
+ 	// type where the request blocks are CommonBlocks, but that direction can
+ 	// Set correctly. The cache will never have CommonBlocks.",Can you make this accept an action instead?
+3110,"@@ -33,3 +33,16 @@ When /^I should see an image with name ""([^""]*)""$/ do |image_name|
+   page.should have_selector(""img"", src: /#{image_name}/)
+ end
+
++When /^a product named ""([^""]*)""$/ do |product_name|
++   create(:product, fulfillment_method: ""fetch"", name: product_name, product_type: ""screencast"")
++end
++
++When /^a video download product named ""([^""]*)""$/ do |product_name|
++   product = create(:product, fulfillment_method: ""fetch"", name: product_name, product_type: ""screencast"")
++   create(:download, download_file_name: ""test.txt"", description: ""test desc"", product: product)
++   create(:video, product: product)
++end
++
++Given /^there is a github product named ""([^""]*)""$/ do |product_name|
++  create(:product, fulfillment_method: ""github"", name: product_name, product_type: ""book"")
++end",Tab inconsistency here (3 spaces instead of 2 spaces)
+3111,"@@ -56,14 +56,15 @@ func defaultConfig() Genesis {
+ 			EnableGravityChainVoting: true,
+ 		},
+ 		Rewarding: Rewarding{
+-			InitBalanceStr:                 unit.ConvertIotxToRau(1200000000).String(),
++			InitBalanceStr:                 unit.ConvertIotxToRau(200000000).String(),
+ 			BlockRewardStr:                 unit.ConvertIotxToRau(16).String(),
+-			EpochRewardStr:                 unit.ConvertIotxToRau(300000).String(),
++			EpochRewardStr:                 unit.ConvertIotxToRau(12500).String(),
++			AleutianEpochRewardStr:         unit.ConvertIotxToRau(15000).String(),
+ 			NumDelegatesForEpochReward:     100,
+ 			ExemptAddrStrsFromEpochReward:  []string{},
+-			FoundationBonusStr:             unit.ConvertIotxToRau(2880).String(),
++			FoundationBonusStr:             unit.ConvertIotxToRau(80).String(),
+ 			NumDelegatesForFoundationBonus: 36,
+-			FoundationBonusLastEpoch:       365,
++			FoundationBonusLastEpoch:       8760,
+ 		},
+ 	}
+ }",these change means we are changing epoch to 1 hour?
+3112,"@@ -46,6 +46,11 @@ import core
+ import keyboardHandler
+ import characterProcessing
+ from . import guiHelper
++
++#: The size that settings panel text descriptions should be wrapped at.
++# Ensure self.scaleSize is used to adjust for OS scaling adjustments.
++PANEL_DESCRIPTION_WIDTH = 544
++
+ try:
+ 	import updateCheck
+ except RuntimeError:",Why this is defined in the middle of imports?
+3113,"@@ -14,8 +14,10 @@
+ # limitations under the License.
+ #
+
++import importlib
+ from distutils.version import LooseVersion
+
++_backends = {}
+ import matplotlib
+ import numpy as np
+ import pandas as pd",Could you move this to the original position?
+3114,"@@ -160,7 +160,7 @@ func (s *Source) Owner() (string, error) {
+ 	if err != nil {
+ 		return """", err
+ 	}
+-	return oAndR.repo, nil
++	return oAndR.owner, nil
+ }
+
+ // PipelineStage represents configuration for each deployment stage",Is there a test that'd have caught this?
+3115,"@@ -419,7 +419,7 @@ func (s *VisibilityPersistenceSuite) TestFilteringByType() {
+
+ 	// List open with filtering
+ 	resp, err2 := s.VisibilityMgr.ListOpenWorkflowExecutionsByType(&visibility.ListWorkflowExecutionsByTypeRequest{
+-		ListWorkflowExecutionsRequest: visibility.ListWorkflowExecutionsRequest{
++		ListWorkflowExecutionsRequest: &visibility.ListWorkflowExecutionsRequest{
+ 			NamespaceID:       testNamespaceUUID,
+ 			PageSize:          2,
+ 			EarliestStartTime: startTime,",ListWorkflowExecutionsRequest <- this can be nil?
+3116,"@@ -809,10 +809,14 @@ module Beaker
+       # This wraps the method `stub_hosts_on` and makes the stub specific to
+       # the forge alias.
+       #
++      # forge api v1 canonical source is forge.puppetlabs.com
++      # forge api v3 canonical source is forgeapi.puppetlabs.com
++      #
+       # @param machine [String] the host to perform the stub on
+       def stub_forge_on(machine)
+         @forge_ip ||= Resolv.getaddress(forge)
+         stub_hosts_on(machine, 'forge.puppetlabs.com' => @forge_ip)
++        stub_hosts_on(machine, 'forgeapi.puppetlabs.com' => @forge_ip)
+       end
+
+       # This wraps the method `stub_hosts` and makes the stub specific to","Do we need to continue to support the old link, or is it dead dead dead?"
+3117,"@@ -108,6 +108,14 @@ namespace Datadog.Trace.Configuration
+             GlobalTags = GlobalTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
+                                    .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
+
++            HeaderTags = source?.GetDictionary(ConfigurationKeys.HeaderTags) ??
++                         // default value (empty)
++                         new ConcurrentDictionary<string, string>();
++
++            // Filter out tags with empty keys or empty values, and trim whitespace
++            HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
++                                   .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
++
+             DogStatsdPort = source?.GetInt32(ConfigurationKeys.DogStatsdPort) ??
+                             // default value
+                             8125;",Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`.
+3118,"@@ -325,10 +325,12 @@ func validateRegisteredAttributes(expectedAttributes, actualAttributes []*ecs.At
+ }
+
+ func (client *APIECSClient) getAdditionalAttributes() []*ecs.Attribute {
++	osFamilyStr := config.GetOSFamilyType()
++	seelog.Infof(""Server OSFamily string: %s"", osFamilyStr)
+ 	return []*ecs.Attribute{
+ 		{
+ 			Name:  aws.String(""ecs.os-type""),
+-			Value: aws.String(config.OSType),
++			Value: aws.String(osFamilyStr),
+ 		},
+ 	}
+ }",this seems like more of a Debugf statement
+3119,"@@ -972,10 +972,11 @@ void CoreChecks::RecordBarrierArrayValidationInfo(const char *func_name, CMD_BUF
+             bool mode_concurrent = handle_state ? handle_state->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT : false;
+             if (!mode_concurrent) {
+                 const auto typed_handle = BarrierTypedHandle(barrier);
+-                cb_state->eventUpdates.emplace_back(
+-                    [this, func_name, cb_state, typed_handle, src_queue_family, dst_queue_family](VkQueue queue) {
+-                        return ValidateConcurrentBarrierAtSubmit(queue, func_name, cb_state, typed_handle, src_queue_family,
+-                                                                 dst_queue_family);
++                cb_state->queue_submit_functions.emplace_back(
++                    [func_name, cb_state, typed_handle, src_queue_family, dst_queue_family](
++                        const ValidationStateTracker *device_data, const QUEUE_STATE *queue_state) {
++                        return ValidateConcurrentBarrierAtSubmit(device_data, queue_state, func_name, cb_state, typed_handle,
++                                                                 src_queue_family, dst_queue_family);
+                     });
+             }
+         }","We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern."
+3120,"@@ -194,6 +194,12 @@ func (c *AwsEndpointDiscoveryTest) TestDiscoveryIdentifiersRequiredRequest(input
+
+ 	output = &TestDiscoveryIdentifiersRequiredOutput{}
+ 	req = c.newRequest(op, input, output)
++
++	// if a custom endpoint is provided for the request,
++	// we skip endpoint discovery workflow
++	if req.Config.Endpoint != nil {
++		return
++	}
+ 	de := discovererDescribeEndpoints{
+ 		Required:      true,
+ 		EndpointCache: c.endpointCache,",Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped.
+3121,"@@ -80,7 +80,7 @@ describe('debug', () => {
+ 	it('should print an error on double jsx conversion', () => {
+ 		let Foo = <div />;
+ 		let fn = () => render(h(<Foo />), scratch);
+-		expect(fn).to.throw(/createElement/);
++		expect(fn).to.throw(/JSX twice/);
+ 	});
+
+ 	it('should add __source to the vnode in debug mode.', () => {",This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol.
+3122,"@@ -40,3 +40,8 @@ func (i *Initializer) initHostNetworkFlows() error {
+ func (i *Initializer) getTunnelPortLocalIP() net.IP {
+ 	return nil
+ }
++
++// registerServiceforOS returns immediately on Linux.
++func (i *Initializer) registerServiceforOS() error {
++	return  nil
++}","I think this is added to wrong file. You wanted to add to cmd/agent/, right?"
+3123,"@@ -348,10 +348,12 @@ public class ExpectedConditions {
+                                                                     final String text) {
+
+     return new ExpectedCondition<Boolean>() {
++      private String elementText = null;
++
+       @Override
+       public Boolean apply(WebDriver driver) {
+         try {
+-          String elementText = element.getText();
++          elementText = element.getText();
+           return elementText.contains(text);
+         } catch (StaleElementReferenceException e) {
+           return null;","Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal."
+3124,"@@ -117,6 +117,7 @@ type NetworkConfig struct {
+ 	CNIVersion string          `json:""cniVersion,omitempty""`
+ 	Name       string          `json:""name,omitempty""`
+ 	Type       string          `json:""type,omitempty""`
++	DeviceID   string          `json:""deviceID""` // PCI address of a VF
+ 	MTU        int             `json:""mtu,omitempty""`
+ 	DNS        cnitypes.DNS    `json:""dns""`
+ 	IPAM       ipam.IPAMConfig `json:""ipam,omitempty""`","Could we consider a more explicit name, like `devicePciAddress`?"
+3125,"@@ -109,10 +109,14 @@ public class WindowsUtils {
+      * quote (\""?)
+      */
+     // TODO We should be careful, in case Windows has ~1-ified the executable name as well
+-    pattern.append(""\""?.*?\\\\"");
+-    pattern.append(executable.getName());
++    pattern.append(""(\""?.*?\\\\)?"");
++    String execName = executable.getName();
++    pattern.append(execName);
++    if (!execName.endsWith("".exe"")) {
++      pattern.append(""(\\.exe)?"");
++    }
+     pattern.append(""\""?"");
+-    for (String arg : cmdarray) {
++    for (int i = 1; i < cmdarray.length; i++) {
+       /*
+        * There may be a space, but maybe not (\\s?), may be a quote or maybe not (\""?), but then
+        * turn on block quotation (as if *everything* had a regex backslash in front of it) with \Q.",Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it.
+3126,"@@ -610,8 +610,9 @@ class SolrService extends \Apache_Solr_Service
+             $solrconfigXmlUrl = $this->_scheme . '://'
+                 . $this->_host . ':' . $this->_port
+                 . $this->_path . 'admin/file/?file=solrconfig.xml';
++            $response= $this->_sendRawGet($solrconfigXmlUrl);
+
+-            $solrconfigXml = simplexml_load_file($solrconfigXmlUrl);
++            $solrconfigXml = simplexml_load_string($response->getRawResponse());
+             if ($solrconfigXml === false) {
+                 throw new \InvalidArgumentException('No valid xml response from schema file: ' . $solrconfigXmlUrl);
+             }",Is this supposed to be part of this PR?
+3127,"@@ -17,6 +17,13 @@ const getHasListItem = (hasListItem, tagName, isListItemRole) => {
+ 	return hasListItem || (tagName === 'LI' && isListItemRole) || isListItemRole;
+ };
+
++const getIsHidden = actualNode => {
++	return (
++		window.getComputedStyle(actualNode, null).getPropertyValue('display') ===
++		'none'
++	);
++};
++
+ let base = {
+ 	badNodes: [],
+ 	isEmpty: true,","DRY, worth extracting this method to axe.utils"
+3128,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher
+3129,"@@ -142,9 +142,14 @@ class KeyConfigParser(QObject):
+     def save(self):
+         """"""Save the key config file.""""""
+         log.destroy.debug(""Saving key config to {}"".format(self._configfile))
+-        with qtutils.savefile_open(self._configfile, encoding='utf-8') as f:
+-            data = str(self)
+-            f.write(data)
++
++        try:
++            with qtutils.savefile_open(self._configfile,
++                                       encoding='utf-8') as f:
++                data = str(self)
++                f.write(data)
++        except OSError as e:
++            message.error(""Could not save key config: {}"".format(e))
+
+     @cmdutils.register(instance='key-config', maxsplit=1, no_cmd_split=True,
+                        no_replace_variables=True)","`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here."
+3130,"@@ -228,7 +228,6 @@ func (t *Transport) startSubscriber(ctx context.Context, sub subscriptionWithTop
+ 	}
+ 	// Ok, ready to start pulling.
+ 	err := conn.Receive(ctx, func(ctx context.Context, m *pubsub.Message) {
+-		logger.Info(""got an event!"")
+ 		msg := &Message{
+ 			Attributes: m.Attributes,
+ 			Data:       m.Data,","Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line."
+3131,"@@ -185,6 +185,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Please.DownloadLocation = ""https://get.please.build""
+ 	config.Please.NumOldVersions = 10
+ 	config.Parse.BuiltinPleasings = true
++	config.Parse.BuildFileName = []string{""BUILD""}
+ 	config.Build.Arch = cli.NewArch(runtime.GOOS, runtime.GOARCH)
+ 	config.Build.Lang = ""en_GB.UTF-8"" // Not the language of the UI, the language passed to rules.
+ 	config.Build.Nonce = ""1402""       // Arbitrary nonce to invalidate config when needed.",Don't think this should be here. The default is set somewhere else.
+3132,"@@ -1229,7 +1229,13 @@ class CloudTaurusTest(BaseCloudTest):
+     def stop_test(self):
+         if self.master:
+             self.log.info(""Ending cloud test..."")
+-            self.master.stop()
++            if not self._last_status:
++                self.get_master_status()
++
++            if self._last_status[""progress""] >= 100:
++                self.master.stop()
++            else:
++                self.master.terminate()
+
+     def get_test_status_text(self):
+         if not self._sessions:","Not really important in this PR, but does BlazeMeter describe ""progress"" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client."
+3133,"@@ -124,6 +124,14 @@ public interface ContentFile<F> {
+    */
+   List<Integer> equalityFieldIds();
+
++  /**
++   * Returns the sort order id of this file, which describes how the file is ordered.
++   * This information will be useful for merging data and equality delete files more efficiently
++   * when they share the same sort order id.
++   */
++  default Integer sortOrderId() {
++    return null;
++  }
+
+   /**
+    * Copies this file. Manifest readers can reuse file instances; use",nit: `<p>` after the line
+3134,"@@ -228,6 +228,7 @@ setup(
+ 		(""libArm64/%s""%version, glob(""libArm64/*.dll"") + glob(""libArm64/*.exe"")),
+ 		(""waves"", glob(""waves/*.wav"")),
+ 		(""images"", glob(""images/*.ico"")),
++		(""fonts"", glob(""fonts/*.ttf"")),
+ 		(""louis/tables"",glob(""louis/tables/*"")),
+ 		(""COMRegistrationFixes"", glob(""COMRegistrationFixes/*.reg"")),
+ 		(""."", glob(""../miscDeps/python/*.dll"")),","Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup"
+3135,"@@ -33,9 +33,6 @@ func (uq *uniQueue) enque(blk *peerBlock) {
+ }
+
+ func (uq *uniQueue) dequeAll() []*peerBlock {
+-	if len(uq.blocks) == 0 {
+-		return nil
+-	}
+ 	blks := uq.blocks
+ 	uq.blocks = []*peerBlock{}
+ 	uq.hashes = map[hash.Hash256]bool{}",i think it's OK to leave this?
+3136,"@@ -30,7 +30,7 @@ import org.apache.flink.table.types.logical.SymbolType;
+ import org.apache.flink.table.types.logical.YearMonthIntervalType;
+ import org.apache.flink.table.types.logical.ZonedTimestampType;
+
+-abstract class FlinkTypeVisitor<T> implements LogicalTypeVisitor<T> {
++public abstract class FlinkTypeVisitor<T> implements LogicalTypeVisitor<T> {
+
+   // ------------------------- Unsupported types ------------------------------
+ ","Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed."
+3137,"@@ -3,11 +3,11 @@ WELCOME_DIALOG_TEXT = (
+ 	""down the NVDA key while pressing other keys. By default, the numpad Insert and main Insert keys ""
+ 	""may both be used as the NVDA key. You can also configure NVDA to use the Caps Lock as the NVDA ""
+ 	""key. Press NVDA plus n at any time to activate the NVDA menu. From this menu, you can configure ""
+-	""NVDA, get help and access other NVDA functions.\n""
+-	""Options  grouping\n""
++	""NVDA, get help and access other NVDA functions.  \n""
++	""Options  grouping  \n""
+ 	""Keyboard layout:  combo box  desktop  collapsed  Alt plus k""
+ )
+ QUIT_DIALOG_TEXT = (
+-	""Exit NVDA  dialog\n""
++	""Exit NVDA  dialog  \n""
+ 	""What would you like to do?  combo box  Exit  collapsed  Alt plus d""
+ )",No line at end of file warning
+3138,"@@ -24,6 +24,8 @@ namespace Nethermind.Blockchain.Processing
+ {
+     public class OneTimeChainProcessor : IBlockchainProcessor
+     {
++        public CompositeBlockTracerFactory BlockTracerFactory { get; } = new();
++
+         private readonly IBlockchainProcessor _processor;
+         private readonly IReadOnlyDbProvider _readOnlyDbProvider;
+ ","This looks unused, shouldn't it point to inner processor in any way?"
+3139,"@@ -6995,11 +6995,6 @@ NABoolean RelRoot::isUpdatableBasic(NABoolean isView,
+   // QSTUFF
+
+     {
+-      // if child is a FirstN node, skip it.
+-      if ((child(0)->castToRelExpr()->getOperatorType() == REL_FIRST_N) &&
+-	  (child(0)->child(0)))
+-	scan = (Scan *)child(0)->child(0)->castToRelExpr();
+-      else
+ 	scan = (Scan *)child(0)->castToRelExpr();
+     }
+ ","There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary."
+3140,"@@ -213,4 +213,14 @@ public class GoSurfaceNamer extends SurfaceNamer {
+   public String getCreateStubFunctionName(Interface service) {
+     return getGrpcClientTypeName(service).replace(""."", "".New"");
+   }
++
++  @Override
++  public String getStaticLangStreamingReturnTypeName(Method method, MethodConfig methodConfig) {
++    // Unsafe string manipulation: The name looks like ""LibraryService_StreamShelvesClient"",
++    // neither camel or underscore.
++    return String.format(
++        ""%s_%sClient"",
++        converter.getTypeName(method.getParent()).getNickname(),
++        method.getSimpleName());
++  }
+ }","I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?"
+3141,"@@ -63,6 +63,8 @@ storiesOf( 'PageSpeed Insights Module/Components', module )
+ 				<DashboardPageSpeedWidget { ...widgetComponentProps } />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} )
+ 	.add( 'Dashboard widget (loading)', () => {
+ 		freezeFetch( /^\/google-site-kit\/v1\/modules\/pagespeed-insights\/data\/pagespeed/ );",All stories in this file also need the default padding.
+3142,"@@ -26,13 +26,14 @@ using Microsoft.AspNetCore.TestHost;
+ using Microsoft.Extensions.DependencyInjection;
+ using Microsoft.Extensions.Hosting;
+ using OpenTelemetry.Metrics;
++using OpenTelemetry.Tests;
+ using Xunit;
+
+ namespace OpenTelemetry.Exporter.Prometheus.Tests
+ {
+     public sealed class PrometheusExporterMiddlewareTests
+     {
+-        private const string MeterName = ""PrometheusExporterMiddlewareTests.Meter"";
++        private static readonly string MeterName = Utils.GetCurrentMethodName();
+
+         [Fact]
+         public async Task PrometheusExporterMiddlewareIntegration()",Curious - what would be the actual value?
+3143,"@@ -168,7 +168,8 @@ def main():
+         # checkpoints as meta data
+         cfg.checkpoint_config.meta = dict(
+             mmdet_version=__version__ + get_git_hash()[:7],
+-            CLASSES=datasets[0].CLASSES)
++            CLASSES=datasets[0].CLASSES,
++            PALETTE=datasets[0].PALETTE)
+     # add an attribute for visualization convenience
+     model.CLASSES = datasets[0].CLASSES
+     train_detector(",Is it necessary to record the palette in the checkpoint? Any reason?
+3144,"@@ -3,9 +3,10 @@ import listenbrainz.webserver
+ import pika
+ import time
+ import threading
++import socketio
+
+ from flask import current_app
+-
++from listenbrainz.webserver.views.api_tools import LISTEN_TYPE_PLAYING_NOW, LISTEN_TYPE_IMPORT
+
+ class FollowDispatcher(threading.Thread):
+ ",Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?
+3145,"@@ -167,6 +167,13 @@ describe Ncr::WorkOrder do
+       user = create(:user, client_slug: 'ncr')
+       expect(wo.slug_matches?(user)).to eq(true)
+     end
++
++    it ""identifies eligible observers"" do
++      wo = create(:ba80_ncr_work_order)
++      user = create(:user, client_slug: 'ncr')
++      expect(wo.proposal.eligible_observers.to_a).to include(user)
++      expect(wo.proposal.eligible_observers.to_a).to_not include(wo.observers)
++    end
+   end
+
+   describe '#organization' do",should we have a similar test for gsa18f procurements?
+3146,"@@ -113,9 +113,9 @@ func TestProtocol_HandleTransfer(t *testing.T) {
+ 			GasLimit:    testutil.TestGasLimit,
+ 		})
+
+-		sender, err := accountutil.AccountState(sm, v.caller.String())
++		sender, err := accountutil.AccountState(sm, v.caller)
+ 		require.NoError(err)
+-		recipient, err := accountutil.AccountState(sm, v.recipient)
++		recipient, err := accountutil.AccountStateByHash160(sm, v.recipient)
+ 		require.NoError(err)
+ 		gasFee := new(big.Int).Mul(v.gasPrice, new(big.Int).SetUint64(gas))
+ ","change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`"
+3147,"@@ -0,0 +1,6 @@
++class NcrDispatcher < LinearDispatcher
++
++  def requires_approval_notice? approval
++    approval.cart_approvals.approvable.order('position ASC').last == approval
++  end
++end",Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher.
+3148,"@@ -26,6 +26,12 @@ namespace Nethermind.JsonRpc
+         [ConfigItem(Description = ""Host for JSON RPC calls. Ensure the firewall is configured when enabling JSON RPC. If it does not work with 117.0.0.1 try something like 10.0.0.4 or 192.168.0.1"", DefaultValue = ""\""127.0.0.1\"""")]
+         string Host { get; set; }
+
++        [ConfigItem(Description = ""Defines whether the JSON RPC tracers will have timeout enabled. Default timeout is 5 seconds per tracer usage."", DefaultValue = ""false"")]
++        bool TracerTimeoutEnabled { get; set; }
++
++        [ConfigItem(Description = ""JSON RPC tracers' timeout value given in seconds."", DefaultValue = ""5"")]
++        int TracerTimeout { get; set; }
++
+         [ConfigItem(Description = ""Base file path for diagnostic JSON RPC recorder."", DefaultValue = ""\""logs/rpc.log_1.txt\"""")]
+         string RpcRecorderBaseFilePath { get; set; }
+ ","remove this and always enable tracer, just set the default timeout to something higher (20 seconds)"
+3149,"@@ -39,6 +39,7 @@ public class ScriptDTO {
+     private final Boolean free;
+     private final Boolean requiresPatch;
+     private final String script;
++    private final URI icon;
+
+     private ScriptDTO(Builder builder) {
+         this.scriptName = builder.scriptName;",Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object.
+3150,"@@ -333,6 +333,13 @@ var opts struct {
+ 				Targets []core.BuildLabel `positional-arg-name:""targets"" description:""Targets to query"" required:""true""`
+ 			} `positional-args:""true""`
+ 		} `command:""roots"" description:""Show build labels with no dependents in the given list, from the list.""`
++		Filter struct {
++			IncludeLabels    []string `long:""in"" description:""Include any targets with matching labels""`
++			ExcludeLabels    []string `long:""ex"" description:""Exclude any targets with matching labels""`
++			Args struct {
++				Targets []core.BuildLabel `positional-arg-name:""targets"" description:""Targets to filter""`
++			} `positional-args:""true""`
++		} `command:""filter"" description:""Filter the given set of targets according to some rules""`
+ 	} `command:""query"" description:""Queries information about the build graph""`
+ }
+ ",can't these just use the global `include` and `exclude` flags?
+3151,"@@ -28,7 +28,7 @@ def bbox2delta(proposals, gt, means=[0, 0, 0, 0], stds=[1, 1, 1, 1]):
+     stds = deltas.new_tensor(stds).unsqueeze(0)
+     deltas = deltas.sub_(means).div_(stds)
+
+-    return deltas
++    return deltas.cuda()
+
+
+ def delta2bbox(rois,",Is this still necessary?
+3152,"@@ -52,7 +52,7 @@ namespace Examples.Console
+                 .AddPrometheusExporter(opt =>
+                 {
+                     opt.StartHttpListener = true;
+-                    opt.HttpListenerPrefixes = new string[] { $""http://*:{port}/"" };
++                    opt.HttpListenerPrefixes = new string[] { $""http://localhost:{port}/"" };
+                 })
+                 .Build();
+ ",Interesting! Happen to catch an exception message or anything I can look into?
+3153,"@@ -103,15 +103,10 @@ Promise.prototype.error = function (err) {
+  * @api public
+  */
+
+-Promise.prototype.resolve = function (err, val) {
+-  if (err) return this.error(err);
+-  return this.fulfill(val);
+-}
+-
+ /**
+  * Adds a single function as a listener to both err and complete.
+  *
+- * It will be executed with traditional node.js argument position when the promise is resolved.
++ * It will be executed with traditional node.js argument position when the promise is resolved.
+  *
+  *     promise.addBack(function (err, args...) {
+  *       if (err) return handleError(err);",did this get moved to mpromise? I don't recall if it's in that lib or not.
+3154,"@@ -81,14 +81,16 @@ type ProviderModeConfig struct {
+ type ConsumerConfig struct {
+ 	PublicKey string `json:""PublicKey""`
+ 	// IP is needed when provider is behind NAT. In such case provider parses this IP and tries to ping consumer.
+-	IP string `json:""IP,omitempty""`
++	IP    string `json:""IP,omitempty""`
++	Ports []int  `json:""Ports""`
+ }
+
+ // ServiceConfig represent a Wireguard service provider configuration that will be passed to the consumer for establishing a connection.
+ type ServiceConfig struct {
+ 	// LocalPort and RemotePort are needed for NAT hole punching only.
+-	LocalPort  int `json:""-""`
+-	RemotePort int `json:""-""`
++	LocalPort  int   `json:""-""`
++	RemotePort int   `json:""-""`
++	Ports      []int `json:""ports""`
+
+ 	Provider struct {
+ 		PublicKey string",json objects should be `camelCase`
+3155,"@@ -0,0 +1,11 @@
++package types
++
++// SectorSize is the amount of bytes in a sector. This amount will be slightly
++// greater than the number of user bytes which can be written to a sector due to
++// bit-padding.
++type SectorSize uint64
++
++const (
++	OneKiBSectorSize = SectorSize(iota)
++	TwoHundredFiftySixMiBSectorSize
++)",QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose.
+3156,"@@ -23,10 +23,11 @@ using System.Linq;
+ using Microsoft.Extensions.Logging;
+ using OpenTelemetry.Exporter;
+ using OpenTelemetry.Logs;
++using OpenTelemetry.Tests;
+ using OpenTelemetry.Trace;
+ using Xunit;
+
+-namespace OpenTelemetry.Tests.Logs
++namespace OpenTelemetry.Logs.Tests
+ {
+     public sealed class LogRecordTest : IDisposable
+     {",Maybe with this change we can remove `using OpenTelemetry.Logs`.
+3157,"@@ -164,9 +164,10 @@ func (h *Handler) handleAddProject(w http.ResponseWriter, r *http.Request) {
+ 	}
+
+ 	var (
+-		id            = r.FormValue(""ID"")
+-		description   = r.FormValue(""Description"")
+-		sharedSSOName = r.FormValue(""SharedSSO"")
++		id                  = r.FormValue(""ID"")
++		description         = r.FormValue(""Description"")
++		sharedSSOName       = r.FormValue(""SharedSSO"")
++		viewerRoleAsDefault = r.FormValue(""ViewerRoleAsDefault"") == ""on""
+ 	)
+ 	if id == """" {
+ 		http.Error(w, ""invalid id"", http.StatusBadRequest)",Fix this name too.
+3158,"@@ -2018,7 +2018,7 @@ class BibFormatObject(object):
+             # If record is given as parameter
+             self.xml_record = xml_record
+             self.record = create_record(xml_record)[0]
+-            recID = record_get_field_value(self.record, ""001"") or None
++            recID = int(record_get_field_value(self.record, ""001"")) or None
+
+         try:
+             assert isinstance(recID, (int, long, type(None))), 'Argument of wrong type!'",why this is an issue?
+3159,"@@ -110,9 +110,13 @@ abstract class Type
+         ?string $namespace,
+         array $aliased_classes,
+         ?string $this_class,
+-        bool $allow_self = false
++        bool $allow_self = false,
++        bool $was_static = false
+     ) : string {
+         if ($allow_self && $value === $this_class) {
++            if ($was_static) {
++                return '$this';
++            }
+             return 'self';
+         }
+ ",The condition should be inverse?
+3160,"@@ -33,12 +33,16 @@ package azkaban;
+ public class Constants {
+
+   // Azkaban Flow Versions
+-  public static final String AZKABAN_FLOW_VERSION_2_0 = ""2.0"";
++  public static final String AZKABAN_FLOW_VERSION = ""Azkaban-Flow-Version"";
++  public static final Double VERSION_2_0 = 2.0;
+
+   // Flow 2.0 file suffix
+   public static final String PROJECT_FILE_SUFFIX = "".project"";
+   public static final String FLOW_FILE_SUFFIX = "".flow"";
+
++  // Flow 2.0 node type
++  public static final String NODE_TYPE_FLOW = ""flow"";
++
+   // Names and paths of various file names to configure Azkaban
+   public static final String AZKABAN_PROPERTIES_FILE = ""azkaban.properties"";
+   public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";","this seems to be a property key name, so should it be a inside configurationkey.java?"
+3161,"@@ -105,7 +105,7 @@ func (v *VolumeDestroy) Execute() ([]byte, error) {
+ 		return nil, err
+ 	}
+ 	// execute command here
+-	return exec.Command(bin.ZFS, v.Command).CombinedOutput()
++	return exec.Command(bin.BASH, ""-c"", v.Command).CombinedOutput()
+ }
+
+ // Build returns the VolumeDestroy object generated by builder",G204: Subprocess launching should be audited (from `gosec`)
+3162,"@@ -284,6 +284,10 @@ class Task(object):
+         # TODO(erikbern): we should think about a language-agnostic mechanism
+         return self.__class__.__module__
+
++    @property
++    def run_on_main_process(self):
++        return False
++
+     _visible_in_registry = True  # TODO: Consider using in luigi.util as well
+
+     __not_user_specified = '__not_user_specified'","Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run."
+3163,"@@ -57,3 +57,18 @@ export function isValidDimensions( dimensions ) {
+ 		return dimension.hasOwnProperty( 'name' ) && typeof dimension.name === 'string';
+ 	} );
+ }
++
++/**
++ * Verifies provided dimensionFilters to make sure they match allowed values found in dimensions.
++ *
++ * @since n.e.x.t
++ *
++ * @param {Object} dimensionFilters The dimension filters to check.
++ * @return {boolean} TRUE if dimension filters are valid, otherwise FALSE.
++ */
++export function isValidDimensionFilters( dimensionFilters ) {
++	// Ensure every dimensionFilter key corresponds to a valid dimension.
++	return Object.keys( dimensionFilters ).every(
++		( dimension ) => typeof dimensionFilters[ dimension ] === 'string'
++	);
++}",We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values.
+3164,"@@ -31,7 +31,8 @@ import (
+ )
+
+ var (
+-	_ yarpc.Router = (*MapRouter)(nil)
++	_ yarpc.Router                = (*MapRouter)(nil)
++	_ yarpc.UnaryTransportHandler = &unaryTransportHandler{}
+ )
+
+ type serviceProcedure struct {","let's do a pointer cast of nil, similar to the `MapRouter` above"
+3165,"@@ -280,6 +280,8 @@ abstract class Abstract_Builder implements Builder {
+ 					'default'           => '{ ""mobile"": ""0"", ""tablet"": ""0"", ""desktop"": ""0"" }',
+ 				]
+ 			);
++
++			do_action( 'neve_add_settings_to_hfg_rows', SettingsManager::get_instance(), $row_setting_id, $row_id );
+ 		}
+
+ 		SettingsManager::get_instance()->add(","action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern."
+3166,"@@ -158,6 +158,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Https.Internal
+                 if ((_options.HttpProtocols & HttpProtocols.Http2) != 0)
+                 {
+                     sslOptions.ApplicationProtocols.Add(SslApplicationProtocol.Http2);
++                    // https://tools.ietf.org/html/rfc7540#section-9.2.1
++                    sslOptions.AllowRenegotiation = false;
+                 }
+
+                 if ((_options.HttpProtocols & HttpProtocols.Http1) != 0)",I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?
+3167,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?
+3168,"@@ -25,9 +25,8 @@ import (
+ )
+
+ func ExampleOpenCollection() {
+-	// This example is used in https://gocloud.dev/howto/docstore#dynamodb-ctor.
+-
+-	// import _ ""gocloud.dev/docstore/awsdynamodb""
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/docstore/awsdynamodb""
+
+ 	sess, err := session.NewSession()
+ 	if err != nil {",I don't think you need the blank import here. This one uses awsdynamodb directly.
+3169,"@@ -121,11 +121,11 @@ public abstract class DeleteFilter<T> {
+     return applyEqDeletes(applyPosDeletes(records));
+   }
+
+-  private List<Predicate<T>> applyEqDeletes() {
+-    List<Predicate<T>> isInDeleteSets = Lists.newArrayList();
++  private Predicate<T> buildEqDeletePredicate() {
+     if (eqDeletes.isEmpty()) {
+-      return isInDeleteSets;
++      return null;
+     }
++    Predicate<T> isDeleted = t -> false;
+
+     Multimap<Set<Integer>, DeleteFile> filesByDeleteIds = Multimaps.newMultimap(Maps.newHashMap(), Lists::newArrayList);
+     for (DeleteFile delete : eqDeletes) {","I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`."
+3170,"@@ -246,6 +246,15 @@ def __build_clangsa_config_handler(args, context):
+     config_handler.compiler_sysroot = context.compiler_sysroot
+     config_handler.system_includes = context.extra_system_includes
+     config_handler.includes = context.extra_includes
++
++    if 'ctu_phases' in args:
++        config_handler.ctu_dir = os.path.join(args.output_path,
++                                              args.ctu_dir)
++        config_handler.ctu_in_memory = args.ctu_in_memory
++        config_handler.log_file = args.logfile
++        config_handler.path_env_extra = context.path_env_extra
++        config_handler.ld_lib_path_extra = context.ld_lib_path_extra
++
+     try:
+         with open(args.clangsa_args_cfg_file, 'rb') as sa_cfg:
+             config_handler.analyzer_extra_arguments = \",What is this and the next entry in config_handler used for?
+3171,"@@ -244,3 +244,9 @@ func NewWithDefault(keyFilePath string, certFilePath string) (m upstreamca.Upstr
+
+ 	return m, err
+ }
++
++func NewEmpty () (m upstreamca.UpstreamCa) {
++	return &memoryPlugin{
++		mtx:&sync.RWMutex{},
++	}
++}","will your editor integrate `gofmt`, `goimports`, etc...?"
+3172,"@@ -78,7 +78,12 @@ public class ProductPhotosFragment extends BaseFragment implements ImagesAdapter
+     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
+         super.onViewCreated(view, savedInstanceState);
+         Intent intent = getActivity().getIntent();
+-        final State state = (State) intent.getExtras().getSerializable(""state"");
++        State state;
++        if(intent!=null && intent.getExtras()!=null && intent.getExtras().getSerializable(""state"")!=null){
++            state = (State) intent.getExtras().getSerializable(""state"");
++        }else{
++            state = ProductFragment.mState;
++        }
+         product = state.getProduct();
+         mFragment = this;
+         // initialize the arraylist",looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting.
+3173,"@@ -218,6 +218,15 @@ def __add_filtering_arguments(parser, defaults=None, diff_mode=False):
+                          default=init_default('severity'),
+                          help=""Filter results by severities."")
+
++    f_group.add_argument('--bug-path-length',
++                         type=str,
++                         dest='bug_path_length',
++                         default=argparse.SUPPRESS,
++                         help=""Filter results by bug path length. This has ""
++                              ""the following format: <minimum_bug_path_length>""
++                              "":<maximum_bug_path_length>. Valid values are: ""
++                              ""\""4:10\"", \""4:\"", \"":10\"""")
++
+     f_group.add_argument('--tag',
+                          nargs='*',
+                          dest=""tag"",","Please add some valid examples to help message like `""4:10""`, `""4:""`, `"":10""`"
+3174,"@@ -490,7 +490,10 @@ EOS
+         #   end
+         def its(attribute, &block)
+           RSpec.deprecate(""Use of rspec-core's `its` method"", :replacement => 'the rspec-its gem')
+-          describe(attribute) do
++          description = attribute
++          description = description.to_s if Symbol === description
++
++          describe(description) do
+             if Array === attribute
+               let(:__its_subject) { subject[*attribute] }
+             else",Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?
+3175,"@@ -15,9 +15,6 @@ import (
+ 	""github.com/stretchr/testify/require""
+ )
+
+-// BlockTimeTest is the block time used by workers during testing
+-const BlockTimeTest = time.Second
+-
+ // MineDelayTest is the mining delay used by schedulers during testing
+ const MineDelayTest = time.Millisecond * 500
+ ",Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it.
+3176,"@@ -12,7 +12,7 @@ class Practice
+   end
+
+   def incomplete_trails
+-    trails.select(&:incomplete?)
++    trails.select(&:incomplete?).partition(&:in_progress?).flatten
+   end
+
+   private",What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?
+3177,"@@ -205,7 +205,6 @@ const (
+ 	FlagTLSKeyPath                        = ""tls_key_path""
+ 	FlagTLSCaPath                         = ""tls_ca_path""
+ 	FlagTLSEnableHostVerification         = ""tls_enable_host_verification""
+-	FlagGRPC                              = ""grpc""
+ )
+
+ var flagsForExecution = []cli.Flag{",Flag is removed because it is only gRPC now.
+3178,"@@ -38,6 +38,17 @@ class Role(base.Base):
+     .. option:: molecule init role --role-name foo
+
+         Initialize a new role.
++
++    .. program:: molecule init role --role-name foo --template path
++
++    .. option:: molecule init role --role-name foo --template path
++
++        Initialize a new role using a local *cookiecutter* template. This
++        allows the customization of a role while still using the default
++        generated ``molecule`` folder. This is similar to an
++        ``ansible-galaxy init`` skeleton. Please refer to the ``init scenario``
++        command in order to customise the default generated ``molecule``
++        folder.
+     """"""
+
+     def __init__(self, command_args):","Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?"
+3179,"@@ -640,9 +640,17 @@ class StdlibChecker(DeprecatedMixin, BaseChecker):
+                     encoding_arg = utils.get_argument_from_call(
+                         node, position=0, keyword=""encoding""
+                     )
++                elif open_module == ""pathlib"" and node.func.attrname == ""write_text"":
++                    encoding_arg = utils.get_argument_from_call(
++                        node, position=1, keyword=""encoding""
++                    )
++                elif open_module == ""pathlib"":
++                    encoding_arg = utils.get_argument_from_call(
++                        node, position=2, keyword=""encoding""
++                    )
+                 else:
+                     encoding_arg = utils.get_argument_from_call(
+-                        node, position=None, keyword=""encoding""
++                        node, position=3, keyword=""encoding""
+                     )
+             except utils.NoSuchArgumentError:
+                 self.add_message(""unspecified-encoding"", node=node)",Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean
+3180,"@@ -9,6 +9,7 @@ import (
+ 	""errors""
+ 	""sync""
+
++	""github.com/ethersphere/bee/pkg/recovery""
+ 	""github.com/ethersphere/bee/pkg/storage""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ 	""github.com/ethersphere/bee/pkg/tags""",why depend on recovery???
+3181,"@@ -388,7 +388,7 @@ func initializeDynamicConfig(
+
+ 	// the done channel is used by dynamic config to stop refreshing
+ 	// and CLI does not need that, so just close the done channel
+-	doneChan := make(chan struct{})
++	doneChan := make(chan interface{})
+ 	close(doneChan)
+ 	dynamicConfigClient, err := dynamicconfig.NewFileBasedClient(
+ 		&serviceConfig.DynamicConfigClient,","the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`"
+3182,"@@ -196,7 +196,7 @@ func NewGasPriceOracle(cfg *Config) (*GasPriceOracle, error) {
+ 	address := cfg.gasPriceOracleAddress
+ 	contract, err := bindings.NewGasPriceOracle(address, l2Client)
+ 	if err != nil {
+-		return nil, err
++		return nil, wrapErr(err, ""error creating contract binding"")
+ 	}
+
+ 	// Fetch the current gas price to use as the current price",Do you mean to have gas_oracle changes in this PR?
+3183,"@@ -1,6 +1,5 @@
+-<%= render Blacklight::System::ModalComponent.new do |component| %>
+-  <% component.title { t('blacklight.email.form.title') } %>
+-
+-  <%= render partial: '/shared/flash_msg' %>
+-  <span data-blacklight-modal=""close""></span>
+-<% end %>
++<turbo-stream action=""append"" target=""main-flashes"">
++  <template>
++    <%= render '/shared/flash_msg' %>
++  </template>
++</turbo-stream>",Is this effectively requiring browsers support javascript?
+3184,"@@ -61,10 +61,11 @@ public class FingerprintAuthDialogFragment extends DialogFragment {
+     @Override
+     public void onCreate(Bundle savedInstanceState) {
+         super.onCreate(savedInstanceState);
++        Boolean isDarkTheme = SalesforceSDKManager.getInstance().isDarkTheme(getActivity());
+
+         // Do not create a new Fragment when the Activity is re-created such as orientation changes.
+         setRetainInstance(true);
+-        setStyle(DialogFragment.STYLE_NORMAL, android.R.style.Theme_Material_Light_Dialog);
++        setStyle(DialogFragment.STYLE_NORMAL, (isDarkTheme ? R.style.SalesforceSDK_Dialog_Dark : R.style.SalesforceSDK_Dialog));
+     }
+
+     @Override",Lowercase `boolean` - use the primitive type.
+3185,"@@ -174,7 +174,12 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+                 }
+                 else
+                 {
+-                    Log.LogError($""Item '{item}' already exists in {relativeBlobPath}."");
++                    bool blobExists = await feed.CheckIfBlobExists(relativeBlobPath);
++
++                    if (blobExists)
++                    {
++                        Log.LogError($""Item '{item}' already exists in {relativeBlobPath}."");
++                    }
+                 }
+             }
+             catch (Exception exc)",This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true.
+3186,"@@ -480,12 +480,15 @@ static void read_surface_net_wm_state(struct wlr_xwm *xwm,
+ 	xsurface->fullscreen = 0;
+ 	xcb_atom_t *atom = xcb_get_property_value(reply);
+ 	for (uint32_t i = 0; i < reply->value_len; i++) {
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_FULLSCREEN])
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_FULLSCREEN]) {
+ 			xsurface->fullscreen = true;
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT])
++		}
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT]) {
+ 			xsurface->maximized_vert = true;
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ])
++		}
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ]) {
+ 			xsurface->maximized_horz = true;
++		}
+ 	}
+ }
+ ",Can you replace these by `else if` please?
+3187,"@@ -0,0 +1,12 @@
++/**
++ * Changes the currently selected date range.
++ *
++ * Currently only identifiable by the option values.
++ *
++ * @param {string} fromRange The currently selected date range.
++ * @param {string} toRange The new date range to select.
++ */
++export async function switchDateRange( fromRange, toRange ) {
++	await expect( page ).toClick( '.mdc-select__selected-text', { text: new RegExp( fromRange, 'i' ) } );
++	await expect( page ).toClick( '.mdc-menu-surface--open .mdc-list-item', { text: new RegExp( toRange, 'i' ) } );
++}","Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange`   But doesn't seem to be a common thing in the code base."
+3188,"@@ -30,7 +30,10 @@ var tableGrid = tableUtils.toGrid(node);
+
+ // Look for all the bad headers
+ var out = headers.reduce(function (res, header) {
+-	if (header.id && reffedHeaders.indexOf(header.id) !== -1) {
++	if (
++		header.getAttribute('id') &&
++		reffedHeaders.includes(header.getAttribute('id'))
++	) {
+ 		return (!res ? res : true);
+ 	}
+ ",Does this code fit on one line under 80 characters? It would be more consistent with our existing style.
+3189,"@@ -61,8 +61,13 @@ func ParseArtifactListFromMultipleYamls(multipleYamls MultiYamlFetcher) (artifac
+ // installed
+ func RegisteredArtifactsFor070() (list ArtifactList) {
+
++	//Note: CRDs have to be installed first. Keep this at top of the list.
++	list.Items = append(list.Items, OpenEBSCRDArtifactsFor070().Items...)
++
+ 	list.Items = append(list.Items, JivaVolumeArtifactsFor070().Items...)
+ 	//Contains the read/list/delete CAST for supporting older volumes
++	//The CAST defined here are provided as fallback options to corresponding
++	//0.7.0 CAST
+ 	list.Items = append(list.Items, JivaVolumeArtifactsFor060().Items...)
+ 	list.Items = append(list.Items, JivaPoolArtifactsFor070().Items...)
+ ",Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`.
+3190,"@@ -0,0 +1,9 @@
++// +build pico
++
++package main
++
++import ""machine""
++
++var (
++	interruptPin = machine.GP10
++)",Why do you configure the UART like this? It's already configured by default.
+3191,"@@ -39,7 +39,8 @@
+ #include ""opae/access.h""
+ #include ""opae/utils.h""
+ #include ""opae/manage.h""
+-#include ""opae/manage.h""
++#include ""opae/enum.h""
++#include ""opae/properties.h""
+ #include ""bitstream_int.h""
+ #include ""common_int.h""
+ #include ""intel-fpga.h""","Wow. Good catch. ""This `#include` was brought to you by the department of redundancy department."" ;)"
+3192,"@@ -20,10 +20,11 @@ import (
+ 	""context""
+ 	""time""
+
++	""github.com/go-logr/logr""
+ 	""golang.org/x/crypto/acme""
+-	""k8s.io/klog""
+
+ 	""github.com/jetstack/cert-manager/pkg/acme/client""
++	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ )
+
+ const (","Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely."
+3193,"@@ -917,6 +917,7 @@ void *cuda_resize_scratch_space(std::int64_t bytes, bool force_shrink) {
+
+ void cuda_prefetch_pointer(const Cuda &space, const void *ptr, size_t bytes,
+                            bool to_device) {
++  if ((ptr == nullptr) || (bytes == 0)) return;
+   cudaPointerAttributes attr;
+   cudaPointerGetAttributes(&attr, ptr);
+   // I measured this and it turns out prefetching towards the host slows",Should this be using the `CUDA_SAFE_CALL` macro here?
+3194,"@@ -298,8 +298,8 @@ namespace Xunit.ConsoleClient
+                     {
+                         lock (consoleLock)
+                         {
+-                            Console.ForegroundColor = ConsoleColor.Red;
+-                            Console.WriteLine(""ERROR:       {0} has no tests to run"", Path.GetFileNameWithoutExtension(assembly.AssemblyFilename));
++                            Console.ForegroundColor = ConsoleColor.Yellow;
++                            Console.WriteLine(""Warning:       {0} has no tests to run"", Path.GetFileNameWithoutExtension(assembly.AssemblyFilename));
+                             Console.ForegroundColor = ConsoleColor.Gray;
+                         }
+                     }",What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level.
+3195,"@@ -1139,6 +1139,10 @@ func (mset *stream) processMirrorMsgs() {
+
+ 	// Grab stream quit channel.
+ 	mset.mu.Lock()
++	if mset.mirror == nil {
++		mset.mu.Unlock()
++		return
++	}
+ 	msgs, mch, qch := mset.mirror.msgs, mset.mirror.msgs.mch, mset.qch
+ 	// Set the last seen as now so that we don't fail at the first check.
+ 	mset.mirror.last = time.Now()","and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that."
+3196,"@@ -258,6 +258,7 @@ static void surface_move_state(struct wlr_surface *surface,
+ 	}
+ 	if ((next->invalid & WLR_SURFACE_INVALID_OPAQUE_REGION)) {
+ 		// TODO: process buffer
++		pixman_region32_copy(&state->opaque, &next->opaque);
+ 		pixman_region32_clear(&next->opaque);
+ 	}
+ 	if ((next->invalid & WLR_SURFACE_INVALID_INPUT_REGION)) {",`next->opaque` should not be cleared.
+3197,"@@ -525,6 +525,7 @@ func (s *Server) processClientOrLeafAuthentication(c *client, opts *Options) boo
+ 			c.Debugf(""Account JWT not signed by trusted operator"")
+ 			return false
+ 		}
++		// this only executes IF there's an issuer on the Juc - otherwise the account is already
+ 		if juc.IssuerAccount != """" && !acc.hasIssuer(juc.Issuer) {
+ 			c.Debugf(""User JWT issuer is not known"")
+ 			return false","already what? I know what, but seems like smth. is missing in this sentence"
+3198,"@@ -1,6 +1 @@
+-$(""div.card-for-activity"").replaceWith('<%=j render partial: 'proposals/details/activity', locals: {events: @events} %>');
+-$(""div.card-for-activity textarea:first"").focus();
+-$(""#add_a_comment"").attr('disabled', true);
+-$(""div.card-for-activity textarea:first"").on('input',function(){
+-  $(""#add_a_comment"").attr('disabled', false);
+-});
++window.c2.activityCardController.update('<%=j render partial: 'proposals/details/activity', locals: {events: @events} %>');",Can you put spaces after the `{`and before the `}`
+3199,"@@ -21,11 +21,12 @@ import logging
+ import logging.handlers
+ import os
+
++from google.cloud.forseti import __version__
+
+ DEFAULT_LOG_FMT = ('%(asctime)s %(levelname)s '
+                    '%(name)s(%(funcName)s): %(message).1024s')
+
+-SYSLOG_LOG_FMT = ('%(levelname)s [forseti-security] '
++SYSLOG_LOG_FMT = ('%(levelname)s [forseti-security] %(__version__)s '
+                   '%(name)s(%(funcName)s): %(message).1024s')
+
+ # %(asctime)s is used as the marker by multiline parser to determine",We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`
+3200,"@@ -1112,7 +1112,7 @@ func (c *client) flushOutbound() bool {
+ 	}
+
+ 	// Check to see if we can reuse buffers.
+-	if len(cnb) > 0 {
++	if len(cnb) > 0 && n >= int64(len(cnb[0])) {
+ 		oldp := cnb[0][:0]
+ 		if cap(oldp) >= int(c.out.sz) {
+ 			// Replace primary or secondary if they are nil, reusing same buffer.",Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?
+3201,"@@ -37,6 +37,7 @@ var (
+ type QueueLoad struct {
+ 	Key       string
+ 	Operation string
++	Object interface{}
+ }
+
+ func Start() error {",can we make use of storagepoolclaim type rather than the generic interface{} type?
+3202,"@@ -652,6 +652,8 @@ func (k *Kad) Start(_ context.Context) error {
+ 	k.wg.Add(1)
+ 	go k.manage()
+
++	k.AddPeers(k.previouslyConnected()...)
++
+ 	go func() {
+ 		select {
+ 		case <-k.halt:","this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first"
+3203,"@@ -185,7 +185,7 @@ Blockly.ScratchBlocks.ProcedureUtils.removeAllInputs_ = function() {
+  */
+ Blockly.ScratchBlocks.ProcedureUtils.createAllInputs_ = function(connectionMap) {
+   // Split the proc into components, by %n, %b, and %s (ignoring escaped).
+-  var procComponents = this.procCode_.split(/(?=[^\\]\%[nbs])/);
++  var procComponents = this.procCode_.split(/(?=[^\\]%[nbs])/);
+   procComponents = procComponents.map(function(c) {
+     return c.trim(); // Strip whitespace.
+   });",Is this actually a lint related change?
+3204,"@@ -15,6 +15,7 @@
+ module Blacklight::Document
+   autoload :ActiveModelShim, 'blacklight/document/active_model_shim'
+   autoload :SchemaOrg, 'blacklight/document/schema_org'
++  autoload :CacheKey, 'blacklight/document/cache_key'
+   autoload :DublinCore, 'blacklight/document/dublin_core'
+   autoload :Email, 'blacklight/document/email'
+   autoload :SemanticFields, 'blacklight/document/semantic_fields'",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+3205,"@@ -226,6 +226,12 @@ def opt_str_param(obj, param_name, default=None):
+     return default if obj is None else obj
+
+
++def opt_nonempty_str_param(obj, param_name, default=None):
++    if obj is not None and not isinstance(obj, string_types):
++        raise_with_traceback(_param_type_mismatch_exception(obj, str, param_name))
++    return default if obj is None or obj == '' else obj
++
++
+ def bool_param(obj, param_name):
+     if not isinstance(obj, bool):
+         raise_with_traceback(_param_type_mismatch_exception(obj, bool, param_name))",what does this do that str_param does not?
+3206,"@@ -39,6 +39,11 @@ func GRPCDialOption(api string) grpc.DialOption {
+ 	return grpc.WithUserAgent(userAgentString(api))
+ }
+
++// AzureUserAgentPrefix returns a prefix that is used to set Azure SDK User-Agent to help with diagnostics.
++func AzureUserAgentPrefix() string {
++	return fmt.Sprintf(""%s/%s"", prefix, version)
++}
++
+ func userAgentString(api string) string {
+ 	return fmt.Sprintf(""%s/%s/%s"", prefix, api, version)
+ }","For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?"
+3207,"@@ -1,6 +1,14 @@
+ import os
+ import pickle
+
++from io import BytesIO
++
++try:
++    import boto3
++    import botocore
++except ImportError:
++    pass
++
+ from dagster import check, seven
+ from dagster.utils import mkdir_p
+ ",what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?
+3208,"@@ -2777,6 +2777,14 @@ void nano::active_transactions::confirm_frontiers (nano::transaction const & tra
+ 		size_t elections_count (0);
+ 		for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && elections_count < max_elections; ++i)
+ 		{
++			{
++				std::lock_guard<std::mutex> guard (mutex);
++				if (stopped)
++				{
++					break;
++				}
++			}
++
+ 			nano::account_info info (i->second);
+ 			if (info.block_count != info.confirmation_height)
+ 			{","May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`"
+3209,"@@ -165,7 +165,7 @@ folly::SemiFuture<StorageRpcResponse<cpp2::ExecResponse>> GraphStorageClient::ad
+       evb,
+       std::move(requests),
+       [=](cpp2::GraphStorageServiceAsyncClient* client, const cpp2::AddEdgesRequest& r) {
+-        return useToss ? client->future_addEdgesAtomic(r) : client->future_addEdges(r);
++        return useToss ? client->future_chainAddEdges(r) : client->future_addEdges(r);
+       });
+ }
+ ","In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?"
+3210,"@@ -22,6 +22,9 @@ import (
+ 	""strconv""
+ 	""strings""
+
++	""github.com/prometheus/prometheus/pkg/rulefmt""
++	thanostypes ""github.com/thanos-io/thanos/pkg/store/storepb""
++
+ 	monitoringv1 ""github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1""
+ 	namespacelabeler ""github.com/prometheus-operator/prometheus-operator/pkg/namespace-labeler""
+ ",`go.sum` needs to be updated for this. Please run `go mod tidy`
+3211,"@@ -28,6 +28,17 @@ const (
+ 	MachineFinalizer = ""awsmachine.infrastructure.cluster.x-k8s.io""
+ )
+
++// SecretBackend defines variants for backend secret storage.
++type SecretBackend string
++
++var (
++	// SecretBackendSSMParameterStore defines AWS Systems Manager Parameter Store as the secret backend
++	SecretBackendSSMParameterStore = SecretBackend(""ssm-parameter-store"")
++
++	// SecretBackendSecretsManager defines AWS Secrets Manager as the secret backend
++	SecretBackendSecretsManager = SecretBackend(""secrets-manager"")
++)
++
+ // AWSMachineSpec defines the desired state of AWSMachine
+ type AWSMachineSpec struct {
+ 	// ProviderID is the unique identifier as specified by the cloud provider.","Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?"
+3212,"@@ -40,9 +40,11 @@ namespace OpenTelemetry.Metrics
+             var options = new OtlpExporterOptions();
+             configure?.Invoke(options);
+
+-            var metricExporter = new OtlpMetricsExporter(options);
+-            var metricReader = new PeriodicExportingMetricReader(metricExporter, options.MetricExportIntervalMilliseconds);
+-            return builder.AddMetricReader(metricReader);
++            // var metricExporter = new OtlpMetricsExporter(options);
++            // var metricReader = new PeriodicExportingMetricReader(metricExporter, options.MetricExportIntervalMilliseconds);
++            // return builder.AddMetricReader(metricReader);
++
++            return builder;
+         }
+     }
+ }",Same thing with the OtlpExporter
+3213,"@@ -70,7 +70,6 @@ const char * jx_operator_string( jx_operator_t type )
+ 		case JX_OP_NOT:	return "" not "";
+ 		// note that the closing bracket/paren is in jx_print_subexpr
+ 		case JX_OP_LOOKUP: return ""["";
+-		case JX_OP_CALL: return ""("";
+ 		case JX_OP_SLICE: return "":"";
+ 		default:        return ""???"";
+ 	}",Should not be removed.
+3214,"@@ -1,17 +1,12 @@
+-[ 'foss', 'puppet', 'ezbake', 'module' ].each do |lib|
+-    require ""beaker/dsl/install_utils/#{lib}_utils""
+-end
+ require ""beaker/dsl/install_utils/pe_defaults""
++require 'beaker-puppet'
+
+ module Beaker
+   module DSL
+     # Collection of installation methods and support
+     module InstallUtils
+-      include DSL::InstallUtils::PuppetUtils
+       include DSL::InstallUtils::PEDefaults
+-      include DSL::InstallUtils::FOSSUtils
+-      include DSL::InstallUtils::ModuleUtils
+-      include DSL::InstallUtils::EZBakeUtils
++      include BeakerPuppet::InstallUtils
+     end
+   end
+ end","Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?"
+3215,"@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take
+     }
+
+     public void submit() {
++      dispatcher.beforeClickOn(element, driver);
+       element.submit();
++      dispatcher.afterClickOn(element, driver);
+     }
+
+     public void sendKeys(CharSequence... keysToSend) {","this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate."
+3216,"@@ -119,7 +119,7 @@ module Ncr
+       if self.pending?
+         self.currently_awaiting_approvers.first.email_address
+       else
+-        self.approving_official.email_address
++        self.approving_official ? self.approving_official.email_address : self.system_approver_emails.first
+       end
+     end
+ ",this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: )
+3217,"@@ -4,6 +4,10 @@
+
+ package net.sourceforge.pmd.lang.java.typeresolution.typedefinition;
+
++import net.sourceforge.pmd.annotation.InternalApi;
++
++@Deprecated
++@InternalApi
+ public interface TypeDefinition {
+     /**
+      * Get the raw Class type of the definition.","Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway..."
+3218,"@@ -86,8 +86,12 @@ class Interface(param.Parameterized):
+
+     datatype = None
+
++    # Denotes whether the interface expects gridded data
+     gridded = False
+
++    # Denotes whether the interface expects multiple ragged arrays
++    multi = False
++
+     @classmethod
+     def register(cls, interface):
+         cls.interfaces[interface.datatype] = interface",Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?
+3219,"@@ -399,6 +399,7 @@ func (oi *OVFImporter) setUpImportWorkflow() (*daisy.Workflow, error) {
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""error parsing workflow %q: %v"", ovfImportWorkflow, err)
+ 	}
++	workflow.ForceCleanupOnError = true
+ 	return workflow, nil
+ }
+ ","Per my understanding, this flag only impacts ""NoCleanup"" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks."
+3220,"@@ -40,7 +40,7 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+-public class SparkStreamingWrite extends SparkBatchWrite implements StreamingWrite {
++class SparkStreamingWrite extends BaseBatchWrite implements StreamingWrite {
+
+   private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingWrite.class);
+   private static final String QUERY_ID_PROPERTY = ""spark.sql.streaming.queryId"";","In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here."
+3221,"@@ -95,10 +95,10 @@ const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes
+ 	{""magicpointspercent"", ITEM_PARSE_MAGICPOINTSPERCENT},
+ 	{""criticalhitchance"", ITEM_PARSE_CRITICALHITCHANCE},
+ 	{""criticalhitamount"", ITEM_PARSE_CRITICALHITAMOUNT},
+-	{""hitpointsleechchance"", ITEM_PARSE_HITPOINTSLEECHCHANCE},
+-	{""hitpointsleechamount"", ITEM_PARSE_HITPOINTSLEECHAMOUNT},
+-	{""manapointsleechchance"", ITEM_PARSE_MANAPOINTSLEECHCHANCE},
+-	{""manapointsleechamount"", ITEM_PARSE_MANAPOINTSLEECHAMOUNT},
++	{""lifeleechchance"", ITEM_PARSE_LIFELEECHCHANCE},
++	{""lifeleechamount"", ITEM_PARSE_LIFELEECHAMOUNT},
++	{""manaleechchance"", ITEM_PARSE_MANALEECHCHANCE},
++	{""manaleechamount"", ITEM_PARSE_MANALEECHAMOUNT},
+ 	{""fieldabsorbpercentenergy"", ITEM_PARSE_FIELDABSORBPERCENTENERGY},
+ 	{""fieldabsorbpercentfire"", ITEM_PARSE_FIELDABSORBPERCENTFIRE},
+ 	{""fieldabsorbpercentpoison"", ITEM_PARSE_FIELDABSORBPERCENTPOISON},",Shouldn't this be called `hp` instead of `life`?
+3222,"@@ -106,7 +106,7 @@ public class BaseServer<T extends BaseServer> implements Server<T> {
+       FilterHolder
+           filterHolder = servletContextHandler.addFilter(CrossOriginFilter.class, ""/*"", EnumSet
+           .of(DispatcherType.REQUEST));
+-      filterHolder.setInitParameter(""allowedOrigins"", ""*"");
++      filterHolder.setInitParameter(""allowedMethods"", ""GET,POST,PUT,DELETE,HEAD"");
+
+       // Warning user
+       LOG.warning(""You have enabled CORS requests from any host. ""","Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all."
+3223,"@@ -5757,4 +5757,3 @@ bool Game::reload(ReloadTypes_t reloadType)
+ 	}
+ 	return true;
+ }
+-",Undo this modification
+3224,"@@ -170,7 +170,7 @@ namespace OpenTelemetry.Exporter.Zipkin.Tests
+             var traceId = useShortTraceIds ? TraceId.Substring(TraceId.Length - 16, 16) : TraceId;
+
+             Assert.Equal(
+-                $@""[{{""""traceId"""":""""{traceId}"""",""""name"""":""""Name"""",""""parentId"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(activity.ParentSpanId)}"""",""""id"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(context.SpanId)}"""",""""kind"""":""""CLIENT"""",""""timestamp"""":{timestamp},""""duration"""":60000000,""""localEndpoint"""":{{""""serviceName"""":""""OpenTelemetry Exporter""""{ipInformation}}},""""annotations"""":[{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event1""""}},{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event2""""}}],""""tags"""":{{""""stringKey"""":""""value"""",""""longKey"""":""""1"""",""""longKey2"""":""""1"""",""""doubleKey"""":""""1"""",""""doubleKey2"""":""""1"""",""""boolKey"""":""""True"""",""""library.name"""":""""CreateTestActivity""""}}}}]"",
++                $@""[{{""""traceId"""":""""{traceId}"""",""""name"""":""""Name"""",""""parentId"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(activity.ParentSpanId)}"""",""""id"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(context.SpanId)}"""",""""kind"""":""""CLIENT"""",""""timestamp"""":{timestamp},""""duration"""":60000000,""""localEndpoint"""":{{""""serviceName"""":""""OpenTelemetry Exporter""""{ipInformation}}},""""annotations"""":[{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event1""""}},{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event2""""}}],""""tags"""":{{""""stringKey"""":""""value"""",""""longKey"""":1,""""longKey2"""":1,""""doubleKey"""":1.0,""""doubleKey2"""":1.0,""""boolKey"""":true,""""library.name"""":""""CreateTestActivity""""}}}}]"",
+                 Responses[requestId]);
+         }
+ ","Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes."
+3225,"@@ -335,6 +335,8 @@ public class Camera extends Plugin {
+       returnBase64(call, exif, bitmapOutputStream);
+     } else if (settings.getResultType() == CameraResultType.URI) {
+       returnFileURI(call, exif, bitmap, u, bitmapOutputStream);
++    } else if (settings.getResultType() == CameraResultType.BASE64NOMETADATA) {
++      returnBase64NoMetadata(call, exif, bitmapOutputStream);
+     } else {
+       call.reject(INVALID_RESULT_TYPE_ERROR);
+     }","Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core"
+3226,"@@ -83,7 +83,7 @@ func buildImportParams() *ovfimportparams.OVFImportParams {
+ 		ShieldedIntegrityMonitoring: *shieldedIntegrityMonitoring, ShieldedSecureBoot: *shieldedSecureBoot,
+ 		ShieldedVtpm: *shieldedVtpm, Tags: *tags, Zone: *zoneFlag, BootDiskKmskey: *bootDiskKmskey,
+ 		BootDiskKmsKeyring: *bootDiskKmsKeyring, BootDiskKmsLocation: *bootDiskKmsLocation,
+-		BootDiskKmsProject: *bootDiskKmsProject, Timeout: *timeout, Project: *project,
++		BootDiskKmsProject: *bootDiskKmsProject, Timeout: *timeout, Project: project,
+ 		ScratchBucketGcsPath: *scratchBucketGcsPath, Oauth: *oauth, Ce: *ce,
+ 		GcsLogsDisabled: *gcsLogsDisabled, CloudLogsDisabled: *cloudLogsDisabled,
+ 		StdoutLogsDisabled: *stdoutLogsDisabled, NodeAffinityLabelsFlag: nodeAffinityLabelsFlag,","Can you explain the history of the bug a bit, and why this fixes it?"
+3227,"@@ -0,0 +1,11 @@
++module MentorHelper
++  def mentor_image(mentor)
++    image_tag gravatar_url(mentor.email, size: '300')
++  end
++
++  def mentor_contact_link(mentor)
++    mail_to mentor.email,
++      I18n.t('dashboard.show.contact_your_mentor',
++             mentor_name: mentor.first_name)
++  end
++end","What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion..."
+3228,"@@ -80,7 +80,7 @@ namespace OpenTelemetry.Exporter
+                 {
+                     string valueDisplay = string.Empty;
+                     StringBuilder tagsBuilder = new StringBuilder();
+-                    for (int i = 0; i < metricPoint.Keys.Length; i++)
++                    for (int i = 0; i < ((metricPoint.Keys == null) ? 0 : metricPoint.Keys.Length); i++)
+                     {
+                         tagsBuilder.Append(metricPoint.Keys[i]);
+                         tagsBuilder.Append("":"");",Looks like this will make the check in every loop. Consider extracting the null check.
+3229,"@@ -11,6 +11,14 @@ module RSpec::Core
+       expect(Module.private_methods & seg_methods).to eq([])
+     end
+
++    module SharedExampleGroup
++      describe Registry do
++        it 'can safely be reset' do
++          expect { Registry.clear }.to_not raise_error
++        end
++      end
++    end
++
+     %w[share_examples_for shared_examples_for shared_examples shared_context].each do |shared_method_name|
+       describe shared_method_name do
+         it ""is exposed to the global namespace"" do","Maybe `it ""can safely be reset when there are not yet any shared example groups""`? That's the edge case that wasn't working, right?"
+3230,"@@ -19,7 +19,8 @@ import (
+ 	""fmt""
+ 	""net/http""
+
+-	""github.com/aws/amazon-ecs-agent/agent/asm/factory""
++	factory ""github.com/aws/amazon-ecs-agent/agent/asm/factory""
++	ssmfactory ""github.com/aws/amazon-ecs-agent/agent/ssm/factory""
+ 	""github.com/aws/amazon-ecs-agent/agent/config""
+ 	""github.com/aws/amazon-ecs-agent/agent/credentials""
+ 	""github.com/aws/amazon-ecs-agent/agent/ec2""",naming: please use `asmfactory`
+3231,"@@ -54,9 +54,12 @@ func (c *Client) buildCommand(target *core.BuildTarget, inputRoot *pb.Directory,
+ 	}
+ 	// We can't predict what variables like this should be so we sneakily bung something on
+ 	// the front of the command. It'd be nicer if there were a better way though...
+-	const commandPrefix = ""export TMP_DIR=\""`pwd`\"" && ""
++	var commandPrefix = ""export TMP_DIR=\""`pwd`\"" && ""
+ 	// TODO(peterebden): Remove this nonsense once API v2.1 is released.
+ 	files, dirs := outputs(target)
++	if len(target.Outputs()) == 1 { // $OUT is relative when running remotely; make it absolute
++		commandPrefix += ""export OUT=\""$TMP_DIR/$OUT\"" && ""
++	}
+ 	cmd, err := core.ReplaceSequences(c.state, target, c.getCommand(target))
+ 	return &pb.Command{
+ 		Platform: c.platform,",FYI you could use a raw string for this which removes the need for escaping the inner quotes.
+3232,"@@ -984,3 +984,19 @@ class TestGetSetClipboard:
+     def test_supports_selection(self, clipboard_mock, selection):
+         clipboard_mock.supportsSelection.return_value = selection
+         assert utils.supports_selection() == selection
++
++
++@pytest.mark.parametrize('keystr, expected', [
++    ('<Control-x>', True),
++    ('<Meta-x>', True),
++    ('<Ctrl-Alt-y>', True),
++    ('x', False),
++    ('X', False),
++    ('<Escape>', True),
++    ('foobar', False),
++    ('foo>', False),
++    ('<foo', False),
++    ('<<', False),
++])
++def test_is_special_key(keystr, expected):
++    assert utils.is_special_key(keystr) == expected",2 blank lines here (between functions)
+3233,"@@ -23,8 +23,13 @@ import java.util.Set;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+
+ class BaseRewriteFiles extends MergingSnapshotProducer<RewriteFiles> implements RewriteFiles {
++
+   BaseRewriteFiles(String tableName, TableOperations ops) {
+-    super(tableName, ops);
++    this(tableName, ops, ops.current().spec());
++  }
++
++  BaseRewriteFiles(String tableName, TableOperations ops, PartitionSpec spec) {
++    super(tableName, ops, spec);
+
+     // replace files must fail if any of the deleted paths is missing and cannot be deleted
+     failMissingDeletePaths();",Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts.
+3234,"@@ -1279,10 +1279,13 @@ class Codebase
+         }
+
+         foreach ($reference_map as $start_pos => [$end_pos, $possible_reference]) {
+-            if ($offset < $start_pos || $possible_reference[0] !== '*') {
++            if ($offset < $start_pos) {
+                 continue;
+             }
+-
++            // If the reference precedes a ""::"" then treat it as a class reference.
++            if ($offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::') {
++                return [$possible_reference, '::', $offset];
++            }
+             if ($offset - $end_pos === 0) {
+                 $recent_type = $possible_reference;
+ ","As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!"
+3235,"@@ -59,4 +59,19 @@ class BackgroundRepository implements Repository {
+     public void setFilter(CombinedAppsFilter filter) {
+         delegatedRepository.setFilter(filter);
+     }
++
++    @Override
++    public boolean equals(Object o) {
++        if (this == o) return true;
++        if (o == null || getClass() != o.getClass()) return false;
++
++        BackgroundRepository that = (BackgroundRepository) o;
++
++        return delegatedRepository != null ? delegatedRepository.equals(that.delegatedRepository) : that.delegatedRepository == null;
++    }
++
++    @Override
++    public int hashCode() {
++        return delegatedRepository != null ? delegatedRepository.hashCode() : 0;
++    }
+ }","Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible"
+3236,"@@ -56,15 +56,17 @@ func TestPinger_Provider_Consumer_Ping_Flow(t *testing.T) {
+
+ 	// Create provider's UDP proxy listener to which pinger should hand off connection.
+ 	// In real world this proxy represents started VPN service (WireGuard or OpenVPN).
+-	proxyBuf := make([]byte, 1024)
++	ch := make(chan string)
+ 	go func() {
+ 		addr, _ := net.ResolveUDPAddr(""udp4"", fmt.Sprintf(""127.0.0.1:%d"", providerProxyPort))
+ 		conn, err := net.ListenUDP(""udp4"", addr)
+ 		assert.NoError(t, err)
+
+ 		for {
+-			_, err := conn.Read(proxyBuf)
++			proxyBuf := make([]byte, 1024)
++			n, err := conn.Read(proxyBuf)
+ 			assert.NoError(t, err)
++			ch <- string(proxyBuf[:n])
+ 		}
+ 	}()
+ ",Allocate buffer once outside loop.
+3237,"@@ -1262,3 +1262,11 @@ TEST (network, filter)
+ 	node1.network.inbound (keepalive, std::make_shared<nano::transport::channel_loopback> (node1));
+ 	ASSERT_EQ (1, node1.stats.count (nano::stat::type::message, nano::stat::detail::invalid_network));
+ }
++
++TEST (network, fill_keepalive_self)
++{
++	nano::system system{ 2 };
++	std::array<nano::endpoint, 8> target;
++	system.nodes[0]->network.fill_keepalive_self (target);
++	ASSERT_TRUE (target[2].port () == system.nodes[1]->network.port);
++}",It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail.
+3238,"@@ -43,8 +43,11 @@ public class WebApplicationExceptionHandler implements ExceptionMapper<WebApplic
+         switch (ex.getResponse().getStatus()) {
+             // BadRequest
+             case 400:
++                // It's strange to have these ""startsWith"" conditionals here. They both come from Access.java.
+                 if ( (ex.getMessage()+"""").toLowerCase().startsWith(""tabular data required"")) {
+                     jrb.message(BundleUtil.getStringFromBundle(""access.api.exception.metadata.not.available.for.nontabular.file""));
++                } else if ((ex.getMessage() + """").toLowerCase().startsWith(""no permission to download file"")) {
++                    jrb.message(""You do not have permission to download this file."");
+                 } else {
+                     jrb.message(""Bad Request. The API request cannot be completed with the parameters supplied. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."");
+                     jrb.request(request);",Should this be in a bundle?
+3239,"@@ -291,9 +291,8 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation
+
+         private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncCallback, Activity activity, object result, bool forceResponseCopy)
+         {
+-            // We could be executing on a different thread now so set the activity.
+-            Debug.Assert(Activity.Current == null || Activity.Current == activity, ""There was an unexpected active Activity on the result thread."");
+-            if (Activity.Current == null)
++            // We could be executing on a different thread now so restore the activity if needed.
++            if (Activity.Current != activity)
+             {
+                 Activity.Current = activity;
+             }","When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble."
+3240,"@@ -63,13 +63,16 @@ func WrapNetwork(net network.GossipNode, log logging.Logger) agreement.Network {
+ 	i.net = net
+ 	i.log = log
+
++	return i
++}
++
++func (i *networkImpl) Start() {
+ 	handlers := []network.TaggedMessageHandler{
+ 		{Tag: protocol.AgreementVoteTag, MessageHandler: network.HandlerFunc(i.processVoteMessage)},
+ 		{Tag: protocol.ProposalPayloadTag, MessageHandler: network.HandlerFunc(i.processProposalMessage)},
+ 		{Tag: protocol.VoteBundleTag, MessageHandler: network.HandlerFunc(i.processBundleMessage)},
+ 	}
+-	net.RegisterHandlers(handlers)
+-	return i
++	i.net.RegisterHandlers(handlers)
+ }
+
+ func messageMetadataFromHandle(h agreement.MessageHandle) *messageMetadata {",what was the point in moving handlers registration into a separate method?
+3241,"@@ -30,6 +30,9 @@ func newSyncCache(state *core.BuildState, remoteOnly bool) core.Cache {
+ 	if state.Config.Cache.HTTPURL != """" {
+ 		mplex.caches = append(mplex.caches, newHTTPCache(state.Config))
+ 	}
++	if state.Config.Cache.RetrieveCommand != """" {
++		mplex.caches = append(mplex.caches, newCmdCache(state.Config))
++	}
+ 	if len(mplex.caches) == 0 {
+ 		return &noopCache{}
+ 	} else if len(mplex.caches) == 1 {",At this point we probably want to ensure there's a store command set.
+3242,"@@ -106,8 +106,13 @@ HDPrivateKey._getDerivationIndexes = function(path) {
+   }
+
+   var indexes = steps.slice(1).map(function(step) {
+-    var index = parseInt(step);
+-    index += step != index.toString() ? HDPrivateKey.Hardened : 0;
++    var index = step ? +step : NaN;
++
++    var isHardened = isNaN(index) && step[step.length-1] == ""'"";
++    if (isHardened) {
++      index = (+(step.slice(0, -1))) + HDPrivateKey.Hardened;
++    }
++
+     return index;
+   });
+ ","This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function"
+3243,"@@ -151,6 +151,10 @@ namespace Nethermind.Vault.JsonRpc
+         {
+             try
+             {
++                if (message.StartsWith(""0x""))
++                {
++                    throw new Exception($""Vault message should not be in hex; message: {message}"");
++                }
+                 string result = await _vaultService.Sign(Guid.Parse(vaultId), Guid.Parse(keyId), message);
+                 return ResultWrapper<string>.Success(result);
+             }","Don't throw base exception, specify more precise type"
+3244,"@@ -5,6 +5,16 @@ import torch
+
+
+ def cast_tensor_type(inputs, src_type, dst_type):
++    """"""Recursive converted Tensor in inputs from src_type to dst_type.
++
++    Args:
++        inputs: Inputs that to be casted.
++        src_type (torch.dtype): Source type..
++        dst_type (torch.dtype): Destination type.
++
++    Returns:
++        The same type with inputs, but all contained Tensors have been cast.
++    """"""
+     if isinstance(inputs, torch.Tensor):
+         return inputs.to(dst_type)
+     elif isinstance(inputs, str):",Recursive -> Recursively converted -> convert
+3245,"@@ -947,7 +947,8 @@ class CSharpGenerator : public BaseGenerator {
+       }
+       // JVM specifications restrict default constructor params to be < 255.
+       // Longs and doubles take up 2 units, so we set the limit to be < 127.
+-      if (has_no_struct_fields && num_fields && num_fields < 127) {
++      if ((has_no_struct_fields || opts.generate_object_based_api) &&
++          num_fields && num_fields < 127) {
+         struct_has_create = true;
+         // Generate a table constructor of the form:
+         // public static int createName(FlatBufferBuilder builder, args...)",why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs.
+3246,"@@ -432,7 +432,7 @@ func acsWsURL(endpoint, cluster, containerInstanceArn string, taskEngine engine.
+ 	query.Set(""agentVersion"", version.Version)
+ 	query.Set(""seqNum"", ""1"")
+ 	if dockerVersion, err := taskEngine.Version(); err == nil {
+-		query.Set(""dockerVersion"", ""DockerVersion: ""+dockerVersion)
++		query.Set(""dockerVersion"", dockerVersion)
+ 	}
+ 	query.Set(sendCredentialsURLParameterName, acsSessionState.getSendCredentialsURLParameter())
+ 	return acsURL + ""?"" + query.Encode()","just to confirm, so backend will deal with both old format and new format?"
+3247,"@@ -91,7 +91,7 @@ namespace Datadog.Trace
+         }
+
+         private static T? ParseEnum<T>(IHeadersCollection headers, string headerName)
+-            where T : struct
++            where T : struct, Enum
+         {
+             var headerValues = headers.GetValues(headerName).ToList();
+ ","huh, look at that, I wasn't aware you could constrain a type by Enum"
+3248,"@@ -229,6 +229,15 @@ PYBIND11_MODULE(ADIOS2_PYTHON_MODULE_NAME, m)
+                  const bool opBool = adios ? true : false;
+                  return opBool;
+              })
++        .def(pybind11::init<const bool>(),
++             ""adios2 module starting point ""
++             ""non-MPI, constructs an ADIOS class ""
++             ""object"",
++             pybind11::arg(""debugMode"") = true)
++        .def(pybind11::init<const std::string &, const bool>(),
++             ""adios2 module starting point non-MPI, constructs an ADIOS class ""
++             ""object"",
++             pybind11::arg(""configFile""), pybind11::arg(""debugMode"") = true)
+ #if ADIOS2_USE_MPI
+         .def(pybind11::init<const adios2::py11::MPI4PY_Comm, const bool>(),
+              ""adios2 module starting point, constructs an ADIOS class object"",","Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?"
+3249,"@@ -0,0 +1,17 @@
++/* Copyright 2016 Google Inc
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *      http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package com.google.api.codegen.viewmodel;
++
++public interface ParamView {}","What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism"
+3250,"@@ -1,12 +1,11 @@
+ package startupshutdown
+
+ import (
+-	""log""
+-	""os""
+-	""os/exec""
+ 	""strings""
+
++	""github.com/google/uuid""
+ 	""github.com/mholt/caddy""
++	""github.com/mholt/caddy/onevent/hook""
+ )
+
+ func init() {","We added a library to generate a UUID for the request_id directive ""github.com/nu7hatch/gouuid"" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?"
+3251,"@@ -161,16 +161,13 @@ func (p *Pinger) PingProvider(ip string, localPorts, remotePorts []int, proxyPor
+ 	return localPort, remotePort, err
+ }
+
+-func (p *Pinger) ping(conn *net.UDPConn, ttl int, stop <-chan struct{}) error {
+-	// Windows detects that 1 TTL is too low and throws an exception during send
+-	i := 0
+-
++func (p *Pinger) ping(conn *net.UDPConn, remoteAddr *net.UDPAddr, ttl int, stop <-chan struct{}) error {
+ 	err := ipv4.NewConn(conn).SetTTL(ttl)
+ 	if err != nil {
+ 		return errors.Wrap(err, ""pinger setting ttl failed"")
+ 	}
+
+-	for {
++	for i := 1; time.Duration(i)*p.pingConfig.Interval < p.pingConfig.Timeout; i++ {
+ 		select {
+ 		case <-stop:
+ 			return nil","Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)"
+3252,"@@ -2513,7 +2513,7 @@ stack_alloc(size_t size, byte *min_addr)
+ #else
+         /* For UNIX we just mark it as inaccessible. */
+         if (!DYNAMO_OPTION(guard_pages))
+-            make_unwritable(guard, PAGE_SIZE);
++            set_protection(guard, PAGE_SIZE, MEMPROT_READ);
+ #endif
+     }
+ ",I guess it's not no-access to match Windows where guard pages are readable.
+3253,"@@ -103,7 +103,9 @@ module Ncr
+         self.proposal.update(status: 'approved')
+       else
+         approvers = emails.map{|e| User.for_email(e)}
++        removed_approvers_to_notify = self.proposal.approvals.non_pending.map(&:user) - approvers
+         self.proposal.approvers = approvers
++        Dispatcher.on_approver_removal(self.proposal, removed_approvers_to_notify)
+       end
+     end
+ ","Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model."
+3254,"@@ -94,6 +94,16 @@ class TaskException(Exception):
+     pass
+
+
++GetWorkResponse = collections.namedtuple('GetWorkResponse', (
++    'task_id',
++    'running_tasks',
++    'n_pending_tasks',
++    'n_unique_pending',
++    'n_pending_last_scheduled',
++    'worker_state'
++))
++
++
+ class TaskProcess(multiprocessing.Process):
+
+     """""" Wrap all task execution in this class.",Add trailing comma
+3255,"@@ -28,7 +28,7 @@ func StartModules() {
+ // GracefulShutdown is if it gets the special signals it does modules cleanup
+ func GracefulShutdown() {
+ 	c := make(chan os.Signal)
+-	signal.Notify(c, syscall.SIGINT, syscall.SIGHUP, syscall.SIGTERM, syscall.SIGKILL,
++	signal.Notify(c, syscall.SIGINT, syscall.SIGHUP, syscall.SIGTERM,
+ 		syscall.SIGQUIT, syscall.SIGILL, syscall.SIGTRAP, syscall.SIGABRT)
+ 	select {
+ 	case s := <-c:",I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?
+3256,"@@ -241,6 +241,7 @@ class Setting extends BaseModel {
+ 					let output = {};
+ 					output[Setting.THEME_LIGHT] = _('Light');
+ 					output[Setting.THEME_DARK] = _('Dark');
++					output[Setting.THEME_OLED_DARK] = _('OLED dark');
+ 					if (platform !== 'mobile') {
+ 						output[Setting.THEME_DRACULA] = _('Dracula');
+ 						output[Setting.THEME_SOLARIZED_LIGHT] = _('Solarised Light');","As it is a mobile only theme, please make sure the option appears only on mobile"
+3257,"@@ -364,3 +364,14 @@ def _get_non_negative_param(param, default=None):
+         if value < 0:
+             raise APIBadRequest(""'{}' should be a non-negative integer"".format(param))
+     return value
++
++
++def parse_param_list(params):
++    param_list = []
++    for param in params.split("",""):
++        param = param.strip()
++        if not param:
++            continue
++        param_list.append(param)
++
++    return param_list",Would like a docstring and type annotations here
+3258,"@@ -11,7 +11,7 @@ module Mongoid
+
+     included do
+       cattr_accessor :shard_key_fields
+-      self.shard_key_fields = []
++      self.shard_key_fields = {}
+     end
+
+     # Get the shard key fields.",This is an API change. Why was it made?
+3259,"@@ -1,5 +1,7 @@
+ // Copyright (c) Microsoft. All rights reserved.
+
++using Microsoft.VisualStudio.TestPlatform.CoreUtilities.Tracing;
++
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Discovery
+ {
+     using System;",Please move using inside namespace.
+3260,"@@ -511,7 +511,7 @@ namespace Nethermind.Blockchain
+             }
+         }
+
+-        private AddBlockResult Suggest(Block? block, BlockHeader header, bool shouldProcess = true, bool? setAsMain = null)
++        private AddBlockResult Suggest(Block? block, BlockHeader header, bool shouldProcess = true, bool? setAsMain = null, bool poSEnabled = false)
+         {
+ #if DEBUG
+             /* this is just to make sure that we do not fall into this trap when creating tests */",shall we create some enum flags for setasmain shouldprocess and pos?
+3261,"@@ -141,6 +141,16 @@ exit /B %errorlevel%
+             # therefore, this command will always exit 0 if either service is installed
+             on host, Command.new(""sc query puppet || sc query pe-puppet"", [], { :cmdexe => true })
+
++            # (PA-514) value for PUPPET_AGENT_STARTUP_MODE should be present in
++            # registry and honored after install/upgrade.
++            reg_query_command = %Q(reg query ""HKLM\\SOFTWARE\\Wow6432Node\\Puppet Labs\\PuppetInstaller"" /v ""RememberedPuppetAgentStartupMode"" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
++            on host, Command.new(reg_query_command, [], { :cmdexe => true })
++
++            start_mode = msi_opts['PUPPET_AGENT_STARTUP_MODE'] == ""Automatic"" ? ""Auto"" : msi_opts['PUPPET_AGENT_STARTUP_MODE']
++            service_query_command = %Q('WMIC SERVICE where (Name like ""%Puppet"" AND StartMode=""#{start_mode}"") | findstr Puppet')
++
++            on host, Command.new(service_query_command, [], { :cmdexe => true })
++
+             # emit the misc/versions.txt file which contains component versions for
+             # puppet, facter, hiera, pxp-agent, packaging and vendored Ruby
+             [",Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?
+3262,"@@ -17,15 +17,10 @@
+ # You should have received a copy of the GNU General Public License
+ # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+
++# pylint: disable=unused-import
+ import pytest
+ import pytest_bdd as bdd
+
+-# pylint: disable=unused-import
+ from end2end.features.test_yankpaste_bdd import init_fake_clipboard
+
+-
+-pytestmark = pytest.mark.qtwebengine_todo(""Caret mode is not implemented"",
+-                                          run=False)
+-
+-
+ bdd.scenarios('caret.feature')",Why not simply remove the `pytest` import now that it's not needed anymore? :wink:
+3263,"@@ -0,0 +1,12 @@
++// Copyright (c) Microsoft.  All Rights Reserved.
++// Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
++
++using Microsoft.VisualStudio.TestTools.UnitTesting;
++
++namespace Microsoft.CodeAnalysis.Sarif.Core
++{
++    [TestClass]
++    public class TagsTests
++    {
++    }
++}","Yeah, not filled in yet."
+3264,"@@ -28,6 +28,13 @@
+     </div>
+   </div>
+
++  <div class=""row"">
++    <div class=""form-group col-xs-12"">
++      <%= f.check_box :active, style: 'width: auto' %>
++      <%= f.label :active, _('Active'), class: 'control-label' %>
++    </div>
++  </div>
++
+   <div class=""row"">
+     <div class=""form-group col-xs-6"">
+       <%= f.label :starts_at, _('Start'), class: 'control-label' %>",don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick
+3265,"@@ -218,6 +218,13 @@ public class Catalog implements AutoCloseable {
+     Objects.requireNonNull(database, ""database is null"");
+     Objects.requireNonNull(tableName, ""tableName is null"");
+     TiTableInfo table = metaCache.getTable(database, tableName);
++
++    if (table == null) {
++      // reload cache if table not exists
++      reloadCache();
++      table = metaCache.getTable(database, tableName);
++    }
++
+     if (showRowId && table != null) {
+       return table.copyTableWithRowId();
+     } else {",should we also do `reloadCache` when database is null?
+3266,"@@ -47,6 +47,15 @@ void SetMCSBondTyper(MCSParameters &p, BondComparator bondComp) {
+   }
+ }
+
++ROMol *getQueryMol(MCSResult &mcsRes) {
++  ROMol *res;
++  {
++    NOGIL gil;
++    res = new ROMol(*mcsRes.QueryMol);
++  }
++  return res;
++}
++
+ MCSResult *FindMCSWrapper(python::object mols, bool maximizeBonds,
+                           double threshold, unsigned timeout, bool verbose,
+                           bool matchValences, bool ringMatchesRingOnly,",Why not just return QueryMol directly? Why require the copy?
+3267,"@@ -84,6 +84,15 @@ def retry_test(func):
+     assert success
+     return result
+
++
++def scapy_path(fname):
++    """"""Resolves a path relative to scapy's root folder""""""
++    if fname.startswith('/'):
++        fname = fname[1:]
++    return os.path.abspath(os.path.join(
++        os.path.dirname(__file__), '../../', fname
++    ))
++
+ #    Import tool    #
+
+ ",Could you add a docstring?
+3268,"@@ -23,4 +23,5 @@ module ApplicationHelper
+   def display_search_ui?
+     current_user && current_user.client_model && !client_disabled?
+   end
++
+ end",looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?
+3269,"@@ -46,7 +46,7 @@ public class EqualsVisitor implements GenericVisitor<Boolean, Visitable> {
+     }
+
+     private EqualsVisitor() {
+-    // hide constructor
++        // hide constructor
+     }
+
+     /**",@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:
+3270,"@@ -33,12 +33,15 @@ class ArgInfo:
+
+     """"""Information about an argument.""""""
+
+-    def __init__(self, win_id=False, count=False, flag=None, hide=False,
+-                 metavar=None, completion=None, choices=None):
++    def __init__(self, win_id=False, count=False, hide=False, metavar=None,
++                 zero_count=False, flag=None, completion=None, choices=None):
+         if win_id and count:
+             raise TypeError(""Argument marked as both count/win_id!"")
++        if zero_count and not count:
++            raise TypeError(""Zero_count Argument cannot exist without count!"")
+         self.win_id = win_id
+         self.count = count
++        self.zero_count = zero_count
+         self.flag = flag
+         self.hide = hide
+         self.metavar = metavar",nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here.
+3271,"@@ -2693,7 +2693,7 @@ func (a *Account) hasIssuer(issuer string) bool {
+ // hasIssuerNoLock is the unlocked version of hasIssuer
+ func (a *Account) hasIssuerNoLock(issuer string) bool {
+ 	// same issuer
+-	if a.Issuer == issuer {
++	if a.Name == issuer {
+ 		return true
+ 	}
+ 	for i := 0; i < len(a.signingKeys); i++ {",change the name of the function to match its functionality? account IsIssuing?
+3272,"@@ -84,6 +84,19 @@ class _Frame(object):
+         """"""
+         return _spark_col_apply(self, F.abs)
+
++    def groupby(self, by):
++        from databricks.koalas.groupby import GroupBy
++        from databricks.koalas.series import Series
++        if isinstance(by, str):
++            by = [by]
++        elif isinstance(by, Series):
++            by = [by]
++        else:
++            by = list(by)
++        if len(by) == 0:
++            raise ValueError('No group keys passed!')
++        return GroupBy(self, by=by)
++
+     def compute(self):
+         """"""Alias of `toPandas()` to mimic dask for easily porting tests.""""""
+         return self.toPandas()",for later: add docstring (can just copy paste Pandas')
+3273,"@@ -4,10 +4,10 @@
+ package cli
+
+ import (
+-	""fmt""
+ 	""testing""
+
+ 	climocks ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/cli/mocks""
++	archerMocks ""github.com/aws/amazon-ecs-cli-v2/mocks""
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/stretchr/testify/require""
+ )","nit: @sonofachamp pointed out to me that the idiomatic way is ""archermocks"" (lowercase for package names)"
+3274,"@@ -31,8 +31,7 @@ import (
+ )
+
+ var (
+-	errRouterNotSet          = errors.New(""router not set"")
+-	errRouterHasNoProcedures = errors.New(""router has no procedures"")
++	errRouterNotSet = errors.New(""router not set"")
+
+ 	_ transport.Inbound = (*Inbound)(nil)
+ )","Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?"
+3275,"@@ -42,10 +42,16 @@ import org.apache.iceberg.util.ThreadPools;
+ public class AllDataFilesTable extends BaseMetadataTable {
+   private final TableOperations ops;
+   private final Table table;
++  private final String name;
+
+   public AllDataFilesTable(TableOperations ops, Table table) {
++    this(ops, table, table.name() + "".all_data_files"");
++  }
++
++  public AllDataFilesTable(TableOperations ops, Table table, String name) {
+     this.ops = ops;
+     this.table = table;
++    this.name = name;
+   }
+
+   @Override",We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too.
+3276,"@@ -4424,11 +4424,15 @@ function _execPopulateQuery(mod, match, select, assignmentOpts, callback) {
+     limit: mod.options.limit,
+     perDocumentLimit: mod.options.perDocumentLimit
+   }, mod.options.options);
++
+   if (mod.count) {
+     delete queryOptions.skip;
+   }
+
+-  if (queryOptions.perDocumentLimit != null) {
++  if (queryOptions.perDocumentLimit != null && queryOptions.limit != null) {
++    throw new Error('Can not use `limit` and `perDocumentLimit` at the same time. Model `' + mod.model.modelName + '`.' );
++  }
++  else if (queryOptions.perDocumentLimit != null) {
+     queryOptions.limit = queryOptions.perDocumentLimit;
+     delete queryOptions.perDocumentLimit;
+   } else if (queryOptions.limit != null) {",I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing.
+3277,"@@ -41,13 +41,13 @@ var (
+
+ // NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
+ type NATProviderPinger interface {
+-	PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
++	PingProvider(params Params, proxyPort int) (*net.UDPConn, error)
+ }
+
+ // NATPinger is responsible for pinging nat holes
+ type NATPinger interface {
+ 	NATProviderPinger
+-	PingTarget(*Params)
++	PingTarget(Params)
+ 	BindServicePort(key string, port int)
+ 	Start()
+ 	Stop()","Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls"
+3278,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....
+3279,"@@ -0,0 +1,7 @@
++<figure>
++  <img src=""/assets/upcase/testimonial_thumbs/anthony-lee.jpg"" alt=""Anthony"">
++  <p class=""quotee"">Anthony Lee<strong>Professional</strong> </p>
++</figure>
++<blockquote>
++  <p><strong>I am really loving upcase.</strong> The most valuable part for me was how I was able to dissect ""upcase"" app and see how it was built. Having the access to the repo and seeing how codes were structured was such a priceless lesson.</p>
++</blockquote>",`image_tag` in the `testimonials` files?
+3280,"@@ -255,9 +255,10 @@ public class ExecutionFlowDao {
+             + ""SET status=?,update_time=?,start_time=?,end_time=?,enc_type=?,flow_data=? ""
+             + ""WHERE exec_id=?"";
+
+-    final String json = JSONUtils.toJSON(flow.toObject());
+     byte[] data = null;
+     try {
++      // If this action fails, the execution must be failed.
++      final String json = JSONUtils.toJSON(flow.toObject());
+       final byte[] stringData = json.getBytes(""UTF-8"");
+       data = stringData;
+       // Todo kunkun-tang: use a common method to transform stringData to data.","I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List<Map<String, Object>> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());"
+3281,"@@ -33,7 +33,7 @@ export default Controller.extend(SettingsSaveMixin, {
+     }),
+
+     iconImageSource: computed('model.icon', function () {
+-        return this.get('model.icon') || '';
++        return this.get('model.icon') || '/favicon.ico';
+     }),
+
+     coverImageSource: computed('model.cover', function () {","So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know  "
+3282,"@@ -120,8 +120,16 @@ int main(int argc, char **argv)
+     MPI_Init(nullptr, nullptr);
+ #endif
+
+-    ::testing::InitGoogleTest(&argc, argv);
+-    int result = RUN_ALL_TESTS();
++    int result = -1;
++    try
++    {
++        ::testing::InitGoogleTest(&argc, argv);
++        result = RUN_ALL_TESTS();
++    }
++    catch (std::exception &e)
++    {
++        result = 1;
++    }
+
+ #ifdef ADIOS2_HAVE_MPI
+     MPI_Finalize();",Why swallow the exception here rather than propagate it?
+3283,"@@ -340,7 +340,8 @@ class _InternalFrame(object):
+                  index_map: Optional[List[IndexMap]] = None,
+                  scol: Optional[spark.Column] = None,
+                  data_columns: Optional[List[str]] = None,
+-                 column_index: Optional[List[Tuple[str]]] = None) -> None:
++                 column_index: Optional[List[Tuple[str]]] = None,
++                 column_names: Optional[List[str]] = None) -> None:
+         """"""
+         Create a new internal immutable DataFrame to manage Spark DataFrame, column fields and
+         index fields and names.",How about `column_index_names`? `column_names` sounds ambiguous.
+3284,"@@ -89,6 +89,7 @@ public class TableProperties {
+   public static final String METADATA_COMPRESSION = ""write.metadata.compression-codec"";
+   public static final String METADATA_COMPRESSION_DEFAULT = ""none"";
+
++  public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics.column."";
+   public static final String DEFAULT_WRITE_METRICS_MODE = ""write.metadata.metrics.default"";
+   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = ""truncate(16)"";
+ }",+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure.
+3285,"@@ -2264,8 +2264,8 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils):
+
+     def test_cumprod(self):
+         pdf = pd.DataFrame(
+-            [[2.0, 1.0], [5, None], [1.0, 1.0], [2.0, 4.0], [4.0, 9.0]],
+-            columns=list(""AB""),
++            [[2.0, 1.0, 1], [5, None, 2], [1.0, 1.0, 3], [2.0, 4.0, 4], [4.0, 9.0, 5]],
++            columns=list(""ABC""),
+             index=np.random.rand(5),
+         )
+         kdf = ks.from_pandas(pdf)",Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types.
+3286,"@@ -20,8 +20,11 @@ Wrappers around spark that correspond to common pandas functions.
+ import pyspark
+ import numpy as np
+ import pandas as pd
++from ._dask_stubs.compatibility import string_types
++from ._dask_stubs.utils import derived_from
+ from .typing import Col, pandas_wrap
+-from pyspark.sql import Column, DataFrame
++from pyspark.sql import Column, DataFrame, functions as F
++from pyspark.sql.types import NumericType
+
+
+ def default_session():","we should sort the headers like in spark: public packages, then pyspark, then internal"
+3287,"@@ -53,7 +53,9 @@ func newPeer(address string, t *Transport) (*grpcPeer, error) {
+ 			grpc.MaxCallSendMsgSize(t.options.clientMaxSendMsgSize),
+ 		),
+ 	}
+-	if t.options.clientTLS {
++	if t.options.clientTLSConfig != nil {
++		dialOptions = append(dialOptions, grpc.WithTransportCredentials(credentials.NewTLS(t.options.clientTLSConfig)))
++	} else if t.options.clientTLS {
+ 		dialOptions = append(dialOptions, grpc.WithTransportCredentials(credentials.NewClientTLSFromCert(nil, """")))
+ 	} else {
+ 		dialOptions = append(dialOptions, grpc.WithInsecure())",looks like we should drop this var from the transport options struct
+3288,"@@ -721,17 +721,6 @@ func TestValidateDuration(t *testing.T) {
+ 			},
+ 			errs: []*field.Error{field.Invalid(fldPath.Child(""renewBefore""), usefulDurations[""ten years""].Duration, fmt.Sprintf(""certificate duration %s must be greater than renewBefore %s"", cmapi.DefaultCertificateDuration, usefulDurations[""ten years""].Duration))},
+ 		},
+-		""default renewBefore is bigger than the set duration"": {
+-			cfg: &internalcmapi.Certificate{
+-				Spec: internalcmapi.CertificateSpec{
+-					Duration:   usefulDurations[""one hour""],
+-					CommonName: ""testcn"",
+-					SecretName: ""abc"",
+-					IssuerRef:  validIssuerRef,
+-				},
+-			},
+-			errs: []*field.Error{field.Invalid(fldPath.Child(""renewBefore""), cmapi.DefaultRenewBefore, fmt.Sprintf(""certificate duration %s must be greater than renewBefore %s"", usefulDurations[""one hour""].Duration, cmapi.DefaultRenewBefore))},
+-		},
+ 		""renewBefore is bigger than the duration"": {
+ 			cfg: &internalcmapi.Certificate{
+ 				Spec: internalcmapi.CertificateSpec{","Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation."
+3289,"@@ -21,6 +21,19 @@ def anchor_inside_flags(flat_anchors,
+                         valid_flags,
+                         img_shape,
+                         allowed_border=0):
++    """"""Check whether the anchors are inside the border
++
++    Args:
++        flat_anchors (torch.Tensor): Flatten anchors
++        valid_flags (torch.Tensor): An existing valid flags of anchors
++        img_shape (tuple(int)): Shape of current image
++        allowed_border (int, optional): The border to allow the valid anchor.
++            Defaults to 0.
++
++    Returns:
++        torch.Tensor: Flags indicating whether the anchors are inside a
++            valid range.
++    """"""
+     img_h, img_w = img_shape[:2]
+     if allowed_border >= 0:
+         inside_flags = valid_flags & \","For tensors, it is better to illustrate the shape."
+3290,"@@ -42,6 +42,11 @@ describe( 'Site Kit admin bar component display', () => {
+ 					status: 200,
+ 					body: JSON.stringify( mockBatchResponse[ 'modules::search-console::searchanalytics::e74216dd17533dcb67fa2d433c23467c' ] ),
+ 				} );
++			} else if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
++				request.respond( {
++					status: 200,
++					body: JSON.stringify( mockBatchResponse ),
++				} );
+ 			} else {
+ 				request.continue();
+ 			}","This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness."
+3291,"@@ -127,6 +127,15 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests
+             Assert.Equal(2, activityProcessor.Invocations.Count); // begin and end was called
+             var activity = (Activity)activityProcessor.Invocations[1].Arguments[0];
+
++#if !NETCOREAPP2_1
++            // ASP.NET Core after 2.x is W3C aware and hence Activity created by it
++            // must be used.
++            Assert.Equal(""Microsoft.AspNetCore.Hosting.HttpRequestIn"", activity.OperationName);
++#else
++            // ASP.NET Core before 3.x is not W3C aware and hence Activity created by it
++            // is always ignored and new one is created by the Instrumentation
++            Assert.Equal(""ActivityCreatedByHttpInListener"", activity.OperationName);
++#endif
+             Assert.Equal(ActivityKind.Server, activity.Kind);
+             Assert.Equal(""api/Values/{id}"", activity.DisplayName);
+             Assert.Equal(""/api/values/2"", activity.GetTagValue(SpanAttributeConstants.HttpPathKey) as string);",nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural.
+3292,"@@ -486,12 +486,13 @@ func (a *Account) IsExportService(service string) bool {
+ // IsExportServiceTracking will indicate if given publish subject is an export service with tracking enabled.
+ func (a *Account) IsExportServiceTracking(service string) bool {
+ 	a.mu.RLock()
+-	defer a.mu.RUnlock()
+ 	ea, ok := a.exports.services[service]
+ 	if ok && ea == nil {
++		a.mu.RUnlock()
+ 		return false
+ 	}
+ 	if ok && ea != nil && ea.latency != nil {
++		a.mu.RUnlock()
+ 		return true
+ 	}
+ 	// FIXME(dlc) - Might want to cache this is in the hot path checking for","for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?"
+3293,"@@ -99,6 +99,15 @@ func (rcv *Monster) InventoryBytes() []byte {
+ 	return nil
+ }
+
++func (rcv *Monster) MutateInventory(j int, n byte) bool {
++	o := flatbuffers.UOffsetT(rcv._tab.Offset(14))
++	if o != 0 {
++		a := rcv._tab.Vector(o)
++		return rcv._tab.MutateByte(a+flatbuffers.UOffsetT(j*1), n)
++	}
++	return false
++}
++
+ func (rcv *Monster) Color() Color {
+ 	o := flatbuffers.UOffsetT(rcv._tab.Offset(16))
+ 	if o != 0 {","The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not."
+3294,"@@ -8,6 +8,7 @@ import (
+ 	""time""
+
+ 	""github.com/filecoin-project/go-filecoin/types""
++	files ""github.com/ipfs/go-ipfs-files""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ ",nit: there should be a newline between `types` and `go-ipfs-files`.
+3295,"@@ -0,0 +1,5 @@
++package reacher
++
++var (
++	RetryAfter = &retryAfterDuration
++)","would be nice to have this as a parameter (Options), re: technical debt discussions"
+3296,"@@ -10,10 +10,13 @@ import java.util.List;
+ import java.util.Objects;
+ import java.util.stream.Collectors;
+
++import org.apache.commons.lang3.ArrayUtils;
++
+ import net.sourceforge.pmd.PMDVersion;
+ import net.sourceforge.pmd.util.fxdesigner.app.DesignerRoot;
+ import net.sourceforge.pmd.util.fxdesigner.util.DesignerUtil;
+
++import com.sun.javafx.fxml.builder.ProxyBuilder;
+ import javafx.application.Application;
+ import javafx.collections.ObservableList;
+ import javafx.fxml.FXMLLoader;",complete ignorance here  but is it ok to import this from `com.sun`? can it break under non-oracle JREs?
+3297,"@@ -61,6 +61,13 @@ func (tr *tracer) Start(ctx context.Context, name string, o ...apitrace.SpanOpti
+ 	span := startSpanInternal(name, parent, remoteParent, opts)
+ 	span.tracer = tr
+
++	if span.IsRecordingEvents() {
++		sps, _ := spanProcessors.Load().(spanProcessorMap)
++		for sp := range sps {
++			sp.OnStart(span.data)
++		}
++	}
++
+ 	ctx, end := startExecutionTracerTask(ctx, name)
+ 	span.executionTracerTaskEnd = end
+ 	return newContext(ctx, span), span",Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() &&  )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?
+3298,"@@ -650,6 +650,13 @@ func (c *CStorVolumeReplicaController) syncCvr(cvr *apis.CStorVolumeReplica) {
+ 	} else {
+ 		cvr.Status.Capacity = *capacity
+ 	}
++
++	err = volumereplica.GetAndUpdateSnapshotInfo(c.clientset, cvr)
++	if err != nil {
++		klog.Errorf(
++			""Unable to update snapshot list details in cvr %s status err: %v"",
++			cvr.Name, err)
++	}
+ }
+
+ func (c *CStorVolumeReplicaController) reconcileVersion(cvr *apis.CStorVolumeReplica) (",just calling UpdateSnapshotInfo() should be fine
+3299,"@@ -156,8 +156,8 @@ namespace Datadog.Trace.Logging
+                 return rate;
+             }
+
+-            // We don't want to rate limit messages by default when in debug mode
+-            return GlobalSettings.Source.DebugEnabled ? 0 : DefaultLogMessageRateLimit;
++            // By default, we don't rate limit log messages;
++            return 0;
+         }
+
+         private static string GetLogDirectory()",Was `DefaultLogMessageRateLimit` not configurable anywhere?
+3300,"@@ -167,6 +167,19 @@ func TestPullImageGlobalTimeout(t *testing.T) {
+ 	wait.Done()
+ }
+
++func TestPullImageInactivityTimeout(t *testing.T) {
++	mockDocker, client, testTime, _, _, done := dockerClientSetup(t)
++	defer done()
++
++	testTime.EXPECT().After(gomock.Any()).AnyTimes()
++	mockDocker.EXPECT().PullImage(&pullImageOptsMatcher{""image:latest""}, gomock.Any()).Return(
++		docker.ErrInactivityTimeout).Times(maximumPullRetries) // expected number of retries
++
++	metadata := client.PullImage(""image"", nil)
++	assert.Error(t, metadata.Error, ""Expected error for pull inactivity timeout"")
++	assert.Equal(t, ""CannotPullContainerError"", metadata.Error.(api.NamedError).ErrorName(), ""Wrong error type"")
++}
++
+ func TestPullImage(t *testing.T) {
+ 	mockDocker, client, testTime, _, _, done := dockerClientSetup(t)
+ 	defer done()",Please use the `assert` instead. Same below.
+3301,"@@ -18,6 +18,7 @@ return array(
+     'A currency with code ""%name"" already exists.' => 'A currency with code ""%name"" already exists.',
+     'A descriptive title' => 'A descriptive title',
+     'A message with name ""%name"" already exists.' => 'A message with name ""%name"" already exists.',
++    'A name suche as Europe or Overseas' => 'A name suche as Europe or Overseas',
+     'A product with reference %ref already exists. Please choose another reference.' => 'A product with reference %ref already exists. Please choose another reference.',
+     'A short description, used when a summary or an introduction is required' => 'A short description, used when a summary or an introduction is required',
+     'A short text, used when an additional or supplemental information is required.' => 'A short text, used when an additional or supplemental information is required.',","Owww, I think I found a typo. `suche`"
+3302,"@@ -131,8 +131,6 @@ void search(SearchEngineData<Algorithm> &engine_working_data,
+                                     source_phantom.GetReverseWeightPlusOffset(),
+                                 source_phantom.reverse_segment_id.id);
+         }
+-        BOOST_ASSERT(forward_heap.Size() > 0);
+-        BOOST_ASSERT(reverse_heap.Size() > 0);
+
+         search(engine_working_data,
+                facade,",This can happen because we could get `PhantomNodes` that are not admissible as source/target right?
+3303,"@@ -19,6 +19,9 @@ func init() {
+ 	if !structsEqual(&tls.ClientSessionState{}, &qtls.ClientSessionState{}) {
+ 		panic(""qtls.ClientSessionState not compatible with tls.ClientSessionState"")
+ 	}
++	if !structsEqual(&tls.ClientSessionState{}, &clientSessionState{}) {
++		panic(""clientSessionState not compatible with tls.ClientSessionState"")
++	}
+ }
+
+ func structsEqual(a, b interface{}) bool {",Should we add a note here to file a bug if this ever happens?
+3304,"@@ -455,7 +455,14 @@ func (api *BasicMarketAPI) GetDealChangeRequestInfo(ctx context.Context, dealID
+ }
+
+ func (api *BasicMarketAPI) GetNumBenchmarks(ctx context.Context) (int, error) {
+-	return NumCurrentBenchmarks, nil
++	num, err := api.marketContract.GetBenchmarksQuantity(getCallOptions(ctx))
++	if err != nil {
++		return 0, err
++	}
++	if !num.IsInt64() {
++		return 0, errors.New(""benchmarks quantity overflows int64"")
++	}
++	return int(num.Int64()), nil
+ }
+
+ type ProfileRegistry struct {","overflow is still possible, isn't it?"
+3305,"@@ -37,6 +37,9 @@ RSpec.configure do |config|
+   config.use_transactional_fixtures = false
+   config.use_instantiated_fixtures  = false
+   config.fixture_path = ""#{::Rails.root}/spec/fixtures""
++  config.infer_base_class_for_anonymous_controllers = false
++  config.order = ""random""
++  config.fail_fast = true
+
+   config.include Paperclip::Shoulda::Matchers
+   config.include EmailSpec::Helpers","This seems more like a personal preference, so maybe this should be in your `~/.rspec`?"
+3306,"@@ -31,8 +31,8 @@ else:
+     THREAD_EXCEPTION = thread.error
+
+ if WINDOWS:
+-    from scapy.arch.pcapdnet import PcapTimeoutElapsed
+-    recv_error = PcapTimeoutElapsed
++    from scapy.error import Scapy_Exception
++    recv_error = Scapy_Exception
+ else:
+     recv_error = ()
+ ",To avoid a circular import between pcapdnet and automaton
+3307,"@@ -1490,8 +1490,7 @@ class CommandDispatcher:
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+     def view_source(self):
+         """"""Show the source of the current page in a new tab.""""""
+-        # pylint: disable=no-member
+-        # WORKAROUND for https://bitbucket.org/logilab/pylint/issue/491/
++
+         tab = self._current_widget()
+         if tab.data.viewing_source:
+             raise cmdexc.CommandError(""Already viewing source!"")",Please remove this blank line.
+3308,"@@ -70,6 +70,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, s *v1alpha1.CloudAuditLo
+ 	ctx = logging.WithLogger(ctx, c.Logger.With(zap.Any(""auditlogsource"", s)))
+
+ 	s.Status.InitializeConditions()
++	s.Status.WorkloadIdentityStatus.InitWorkloadIdentityStatus()
+ 	s.Status.ObservedGeneration = s.Generation
+
+ 	// If GCP ServiceAccount is provided, reconcile workload identity.","it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though"
+3309,"@@ -1681,6 +1681,16 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+                 }
+             }
+         }
++
++        auto provoking_vertex_state_ci = lvl_find_in_chain<VkPipelineRasterizationProvokingVertexStateCreateInfoEXT>(
++            pPipeline->graphicsPipelineCI.pRasterizationState->pNext);
++        if (provoking_vertex_state_ci &&
++            provoking_vertex_state_ci->provokingVertexMode == VK_PROVOKING_VERTEX_MODE_LAST_VERTEX_EXT &&
++            !enabled_features.provoking_vertex_features.provokingVertexLast) {
++            skip |= LogError(
++                device, ""VUID-VkPipelineRasterizationProvokingVertexStateCreateInfoEXT-provokingVertexMode-04883"",
++                ""provokingVertexLast feature is not enabled."");
++        }
+     }
+
+     if ((pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT) && !pPipeline->graphicsPipelineCI.pVertexInputState) {",I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility.
+3310,"@@ -50,6 +50,7 @@ def _column_op(f):
+     :param self: Koalas Series
+     :param args: arguments that the function `f` takes.
+     """"""
++
+     @wraps(f)
+     def wrapper(self, *args):
+         assert all((not isinstance(arg, Series)) or (arg._kdf is self._kdf) for arg in args), \","It's fine for this PR, but in the future try to minimize unrelated changes."
+3311,"@@ -202,11 +202,11 @@ class Ansible(base.Base):
+     ::
+
+         ANSIBLE_ROLES_PATH:
+-          $ephemeral_directory/roles/:$project_directory/../
++          $ephemeral_directory/roles/:$project_directory/../:$HOME/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles
+         ANSIBLE_LIBRARY:
+-          $ephemeral_directory/library/:$project_directory/library/
++          $ephemeral_directory/modules/:$project_directory/library/:$HOME/.ansible/plugins/modules:/usr/share/ansible/plugins/modules
+         ANSIBLE_FILTER_PLUGINS:
+-          $ephemeral_directory/plugins/filters/:$project_directory/filter/plugins/
++          $ephemeral_directory/plugins/filter/:$project_directory/filter/plugins/:$HOME/.ansible/plugins/filter:/usr/share/ansible/plugins/modules
+
+     Environment variables can be passed to the provisioner.  Variables in this
+     section which match the names above will be appened to the above defaults,",The library -> modules and filters -> filter path changes are breaking changes or?
+3312,"@@ -1,6 +1,9 @@
+ import logging
++import os
+ from typing import TYPE_CHECKING
+
++import boto3
++import botocore.config
+ import pytest
+
+ from localstack.utils.aws import aws_stack","Can we encapsulate this check (`os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD""`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)"
+3313,"@@ -22,7 +22,9 @@ export function h(nodeName, attributes) {
+ 	}
+ 	while (stack.length) {
+ 		if ((child = stack.pop()) && child.pop!==undefined) {
+-			for (i=child.length; i--; ) stack.push(child[i]);
++			[].concat(child).reverse().forEach((item) => {
++				stack.push(item);
++			});
+ 		}
+ 		else {
+ 			if (child===true || child===false) child = null;","An `if` statement would be better here. Functions, concat and reverse are all very expensive."
+3314,"@@ -156,3 +156,12 @@ func (c *factory) ERC20Address(ctx context.Context) (common.Address, error) {
+ 	}
+ 	return erc20Address, nil
+ }
++
++// DiscoverFactoryAddress returns the canonical factory for this chainID
++func DiscoverFactoryAddress(chainID int64) (common.Address, bool) {
++	if chainID == 5 {
++		// goerli
++		return common.HexToAddress(""0x334394E8c891E77b1449084aaDD659920BB25247""), true
++	}
++	return common.Address{}, false
++}",`Log here: connect to default factory for goerli network <address>`
+3315,"@@ -125,9 +125,11 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+
+ 	var approvers []string
+
+-	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+-		if v.Event == ""DEPLOYMENT_WAIT_APPROVAL"" {
+-			approvers = v.Slack
++	if ds.GenericDeploymentConfig.DeploymentNotification != nil {
++		for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
++			if e := ""EVENT_"" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {
++				approvers = v.Slack
++			}
+ 		}
+ 	}
+ ","nits, should add `break` to avoid redundant iterations."
+3316,"@@ -56,6 +56,15 @@ namespace Nethermind.Store.Test
+             provider.Commit(SpuriousDragon.Instance);
+             Assert.False(provider.AccountExists(_address1));
+         }
++
++        [Test]
++        public void Eip_158_account_dont_exists_after_zero_value_transfer()
++        {
++            ISnapshotableDb stateDb = new StateDb(new MemDb());
++            StateProvider provider = new StateProvider(stateDb, Substitute.For<IDb>(), Logger);
++            provider.AddToBalance(_address1, 0, SpuriousDragon.Instance);
++            provider.AccountExists(_address1).Should().BeFalse();
++        }
+
+         [Test]
+         public void Eip_158_touch_zero_value_system_account_is_not_deleted()","I think we want an exception here, there should never be a transfer to a nonexisting account."
+3317,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users."
+3318,"@@ -79,11 +79,11 @@ class TestSklearn(unittest.TestCase):
+                                          '../../examples/lambdarank/rank.test.query'))
+         gbm = lgb.LGBMRanker()
+         gbm.fit(X_train, y_train, group=q_train, eval_set=[(X_test, y_test)],
+-                eval_group=[q_test], eval_at=[1, 3], early_stopping_rounds=5, verbose=False,
+-                callbacks=[lgb.reset_parameter(learning_rate=lambda x: 0.95 ** x * 0.1)])
+-        self.assertLessEqual(gbm.best_iteration_, 12)
+-        self.assertGreater(gbm.best_score_['valid_0']['ndcg@1'], 0.6173)
+-        self.assertGreater(gbm.best_score_['valid_0']['ndcg@3'], 0.6479)
++                eval_group=[q_test], eval_at=[1, 3], early_stopping_rounds=10, verbose=False,
++                callbacks=[lgb.reset_parameter(learning_rate=lambda x: max(0.01, 0.1 - 0.01 * x))])
++        self.assertLessEqual(gbm.best_iteration_, 25)
++        self.assertGreater(gbm.best_score_['valid_0']['ndcg@1'], 0.60)
++        self.assertGreater(gbm.best_score_['valid_0']['ndcg@3'], 0.60)
+
+     def test_regression_with_custom_objective(self):
+         def objective_ls(y_true, y_pred):",Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`.
+3319,"@@ -87,6 +87,10 @@ module Bolt
+         impl
+       end
+
++      def select_interpreter(executable, interpreters)
++        interpreters[Pathname(executable).extname] if interpreters
++      end
++
+       def reject_transport_options(target, options)
+         if target.options['run-as']
+           options.reject { |k, _v| k == '_run_as' }","I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much ""magic""? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?"
+3320,"@@ -1235,12 +1235,15 @@ ostree_sysroot_get_subbootversion (OstreeSysroot   *self)
+  * ostree_sysroot_get_booted_deployment:
+  * @self: Sysroot
+  *
++ * This function may only be called if the sysroot is loaded.
++ *
+  * Returns: (transfer none) (nullable): The currently booted deployment, or %NULL if none
+  */
+ OstreeDeployment *
+ ostree_sysroot_get_booted_deployment (OstreeSysroot       *self)
+ {
+-  g_return_val_if_fail (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED, NULL);
++  g_assert (self);
++  g_assert (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED);
+
+   return self->booted_deployment;
+ }","In this and the one below, should we assert `self != NULL` first?"
+3321,"@@ -147,7 +147,7 @@ class GalleryControllerTest extends \PHPUnit_Framework_TestCase
+         $view = $galleryController->postGalleryMediaGalleryhasmediaAction(1, 2, new Request());
+
+         $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
+-        $this->assertSame(200, $view->getStatusCode(), 'Should return 200');
++        $this->assertSame(200, $view->getResponse()->getStatusCode(), 'Should return 200');
+     }
+
+     public function testPostGalleryMediaGalleryhasmediaInvalidAction()",Why this is needed?
+3322,"@@ -149,6 +149,12 @@ class PackageEntry:
+         """"""
+         self._meta['user_meta'] = meta
+
++    def get_meta(self):
++        """"""
++        Gets the user_meta for this PackageEntry.
++        """"""
++        return self.meta or None
++
+     def _verify_hash(self, read_bytes):
+         """"""
+         Verifies hash of bytes",we already have .meta() so I don't think we want get_meta() for PackageEntry
+3323,"@@ -83,7 +83,8 @@ public abstract class CoprocessorIterator<T> implements Iterator<T> {
+         session,
+         SchemaInfer.create(dagRequest),
+         dagRequest.getPushDownType(),
+-        dagRequest.getStoreType()) {
++        dagRequest.getStoreType(),
++        dagRequest.getStartTs().getVersion()) {
+       @Override
+       public Row next() {
+         return rowReader.readRow(schemaInfer.getTypes().toArray(new DataType[0]));",question: can we always get the startts from dagrequest?
+3324,"@@ -114,9 +114,11 @@ describe( 'AccountSelect', () => {
+ 	it( 'should pre-select the property and profile IDs when changed', () => {
+ 		const { accounts, properties, profiles } = fixtures.accountsPropertiesProfiles;
+ 		const { getByText, container, registry } = render( <AccountSelect />, { setupRegistry } );
++		const propertyID = fixtures.accountsPropertiesProfiles.properties[ 0 ].id;
++		const accountID = fixtures.accountsPropertiesProfiles.properties[ 0 ].accountId;
+
+-		registry.dispatch( STORE_NAME ).receiveProperties( properties );
+-		registry.dispatch( STORE_NAME ).receiveProfiles( profiles );
++		registry.dispatch( STORE_NAME ).receiveProperties( properties, { accountID } );
++		registry.dispatch( STORE_NAME ).receiveProfiles( profiles, { propertyID } );
+
+ 		// Click the label to expose the elements in the menu.
+ 		fireEvent.click( container.querySelector( '.mdc-floating-label' ) );","Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above."
+3325,"@@ -142,6 +142,10 @@ module Bolt
+         @unresolved_targets[t_name] = target
+       end
+
++      def remove_target(target)
++        @resolved_targets.delete(target.name)
++      end
++
+       def add_target(target)
+         @resolved_targets[target.name] = { 'name' => target.name }
+       end","This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?"
+3326,"@@ -200,7 +200,7 @@ public abstract class AbstractCallOperation extends AbstractOperation {
+               .sender(sender(frame))
+               .value(value(frame))
+               .apparentValue(apparentValue(frame))
+-              .code(new Code(contract != null ? contract.getCode() : Bytes.EMPTY))
++              .code(frame.getWorldState().getContract(contract).orElse(new Code()))
+               .blockHeader(frame.getBlockHeader())
+               .depth(frame.getMessageStackDepth() + 1)
+               .isStatic(isStatic(frame))",So what happens if I try to get code on a EOA?
+3327,"@@ -2400,15 +2400,8 @@ class VariablesChecker(BaseChecker):
+             return
+
+         # Attempt to check unpacking is properly balanced
+-        values: Optional[List] = None
+-        if isinstance(inferred, (nodes.Tuple, nodes.List)):
+-            values = inferred.itered()
+-        elif isinstance(inferred, astroid.Instance) and any(
+-            ancestor.qname() == ""typing.NamedTuple"" for ancestor in inferred.ancestors()
+-        ):
+-            values = [i for i in inferred.values() if isinstance(i, nodes.AssignName)]
+-
+-        if values:
++        values = self._get_values_to_unpack(inferred)
++        if values is not None:
+             if len(targets) != len(values):
+                 # Check if we have starred nodes.
+                 if any(isinstance(target, nodes.Starred) for target in targets):",Can't we return an empty list and then just compare the lengths? Thereby removing this `if`.
+3328,"@@ -151,6 +151,7 @@ class Uppy {
+     this.addFile = this.addFile.bind(this)
+     this.removeFile = this.removeFile.bind(this)
+     this.pauseResume = this.pauseResume.bind(this)
++    this.passesRestrictions = this.passesRestrictions.bind(this)
+
+     // ___Why throttle at 500ms?
+     //    - We must throttle at >250ms for superfocus in Dashboard to work well (because animation takes 0.25s, and we want to wait for all animations to be over before refocusing).",Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me.
+3329,"@@ -17,7 +17,7 @@ import (
+
+ // Lookup is the interface for time based feed lookup
+ type Lookup interface {
+-	At(ctx context.Context, at, after int64) (swarm.Chunk, error)
++	At(ctx context.Context, at, after int64) (chunk swarm.Chunk, currentIndex, nextIndex Index, err error)
+ }
+
+ // Getter encapsulates a chunk Getter getter and a feed and provides",TODO: in fact At when used with noncurrent time should not return a next index. only latest should..
+3330,"@@ -165,7 +165,11 @@ export function diff(
+ 			tmp = c.render(c.props, c.state, c.context);
+ 			let isTopLevelFragment =
+ 				tmp != null && tmp.type == Fragment && tmp.key == null;
+-			newVNode._children = isTopLevelFragment ? tmp.props.children : tmp;
++			newVNode._children = isTopLevelFragment
++				? tmp.props.children
++				: Array.isArray(tmp)
++				? tmp
++				: [tmp];
+
+ 			if (c.getChildContext != null) {
+ 				context = assign(assign({}, context), c.getChildContext());","There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it"
+3331,"@@ -33,8 +33,7 @@ import javaslang.match.annotation.Patterns;
+     // -- javaslang.collection
+
+     // List
+-    @Unapply static <T> Tuple2<T, List<T>> List(List.Cons<T> cons) { return Tuple.of(cons.head(), cons.tail()); }
+-    @Unapply static <T> Tuple0 List(List.Nil<T> nil) { return Tuple.empty(); }
++    @Unapply static <T> Tuple2<T, List<T>> List(List<T> cons) { return Tuple.of(cons.head(), cons.tail()); }
+
+     // Stream
+     @Unapply static <T> Tuple2<T, Stream<T>> Stream(Stream.Cons<T> cons) { return Tuple.of(cons.head(), cons.tail()); }","@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p"
+3332,"@@ -22,7 +22,7 @@
+ *  This copyright notice MUST APPEAR in all copies of the script!
+ ***************************************************************/
+ use TYPO3\CMS\Core\Utility\GeneralUtility;
+-
++use ApacheSolrForTypo3\Solr\Facet\Facet;
+ /**
+  * Query group facet renderer.
+  *",Please leave two empty lines after the `use` statement
+3333,"@@ -27,6 +27,7 @@ import (
+ 	""bytes""
+ 	""fmt""
+ 	""io/ioutil""
++	""k8s.io/kubernetes/pkg/kubelet/cm""
+ 	""os""
+ 	""path""
+ 	""path/filepath""",Please move this import in the 3rd group which is for external dependencies
+3334,"@@ -63,7 +63,7 @@ def _path_hash(path, transform, kwargs):
+     return digest_string(srcinfo)
+
+ def _is_internal_node(node):
+-    is_leaf = not node or node.get(RESERVED['file'])
++    is_leaf = not node or isinstance(node.get(RESERVED['file']), str)
+     return not is_leaf
+
+ def _pythonize_name(name):",So what exactly is this fixing? The unit test is passing with or without this change.
+3335,"@@ -601,8 +601,18 @@ bool FileBasedWal::linkCurrentWAL(const char* newPath) {
+         LOG(INFO) << idStr_ << ""Create link failed, there is no wal files!"";
+         return false;
+     }
++    if (!fs::FileUtils::makeDir(newPath)) {
++        LOG(INFO) << idStr_ << ""Link file parent dir make failed : "" << newPath;
++        return false;
++    }
++
+     auto it = walFiles_.rbegin();
+-    if (link(it->second->path(), newPath) != 0) {
++
++    // Using the original wal file name.
++    auto targetFile = folly::stringPrintf(""%s/%s"", newPath,
++            it->second->path() + std::string(it->second->path()).rfind('/') + 1);
++
++    if (link(it->second->path(), targetFile.data()) != 0) {
+         LOG(INFO) << idStr_ << ""Create link failed for "" << it->second->path()
+                   << "" on "" << newPath << "", error:"" << strerror(errno);
+         return false;","auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(""%019ld.wal"", it->first));"
+3336,"@@ -42,6 +42,16 @@ public class SnapshotUtil {
+     return ancestorIds(table.currentSnapshot(), table::snapshot);
+   }
+
++  /**
++   * @return List of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
++   * This method assumes that fromSnapshotId is an ancestor of toSnapshotId
++   */
++  public static List<Long> snapshotIdsBetween(Table table, long fromSnapshotId, long toSnapshotId) {
++    List<Long> snapshotIds = Lists.newArrayList(ancestorIds(table.snapshot(toSnapshotId),
++        snapshotId -> snapshotId != fromSnapshotId ? table.snapshot(snapshotId) : null));
++    return snapshotIds;
++  }
++
+   public static List<Long> ancestorIds(Snapshot snapshot, Function<Long, Snapshot> lookup) {
+     List<Long> ancestorIds = Lists.newArrayList();
+     Snapshot current = snapshot;",I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me.
+3337,"@@ -367,11 +367,10 @@ class Connection implements TranslatorAwareInterface, LoggerAwareInterface
+                     explode(':', $functionConfig['updateFields'])
+                 );
+             }
+-            if (isset($functionConfig['helpText'])) {
+-                $response['helpText'] = $this->getHelpText(
+-                    $functionConfig['helpText']
+-                );
+-            }
++            $response['helpText']
++                = $this->getHelpText($functionConfig['helpText'] ?? '');
++            $response['updateHelpText']
++                = $this->getHelpText($functionConfig['updateHelpText'] ?? '');
+             if (isset($functionConfig['consortium'])) {
+                 $response['consortium'] = $functionConfig['consortium'];
+             }","Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?"
+3338,"@@ -17,7 +17,7 @@ module RSpec
+       # @param [IO] out
+       def run(err, out)
+         @configuration.error_stream = err
+-        @configuration.output_stream ||= out
++        @configuration.output_stream = out
+         @options.configure(@configuration)
+         @configuration.load_spec_files
+         @world.announce_filters","Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it...."
+3339,"@@ -4,6 +4,7 @@ class Proposal < ActiveRecord::Base
+   workflow_column :status
+
+   has_one :cart
++  belongs_to :clientdata, polymorphic: true
+
+   validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
+ ",Thinking this should have an underscore.
+3340,"@@ -316,14 +316,14 @@ def test_message_state_scope(init_linter: PyLinter) -> None:
+
+     linter = init_linter
+     linter.disable(""C0202"")
+-    assert MSG_STATE_SCOPE_CONFIG == linter.get_message_state_scope(""C0202"")
++    assert MSG_STATE_SCOPE_CONFIG == linter._get_message_state_scope(""C0202"")
+     linter.disable(""W0101"", scope=""module"", line=3)
+-    assert MSG_STATE_SCOPE_CONFIG == linter.get_message_state_scope(""C0202"")
+-    assert MSG_STATE_SCOPE_MODULE == linter.get_message_state_scope(""W0101"", 3)
++    assert MSG_STATE_SCOPE_CONFIG == linter._get_message_state_scope(""C0202"")
++    assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(""W0101"", 3)
+     linter.enable(""W0102"", scope=""module"", line=3)
+-    assert MSG_STATE_SCOPE_MODULE == linter.get_message_state_scope(""W0102"", 3)
++    assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(""W0102"", 3)
+     linter.config = FakeConfig()
+-    assert MSG_STATE_CONFIDENCE == linter.get_message_state_scope(
++    assert MSG_STATE_CONFIDENCE == linter._get_message_state_scope(
+         ""this-is-bad"", confidence=interfaces.INFERENCE
+     )
+ ",To accommodate the change to the method being private.
+3341,"@@ -90,6 +90,7 @@ namespace AutoRest.Swagger.Model
+         [CollectionRule(typeof(BodyTopLevelProperties))]
+         [CollectionRule(typeof(HttpVerbValidation))]
+         [CollectionRule(typeof(DeleteMustHaveEmptyRequestBody))]
++        [CollectionRule(typeof(PropertiesNamesCamelCase))]
+         public Dictionary<string, Dictionary<string, Operation>> Paths { get; set; }
+
+         /// <summary>",Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc
+3342,"@@ -0,0 +1,11 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.design;
++
++import net.sourceforge.pmd.testframework.PmdRuleTst;
++
++public class MutableStaticState extends PmdRuleTst {
++    // no additional unit tests
++}","Please rename this class that it ends with the suffix ""Test"" - otherwise the tests won't be executed."
+3343,"@@ -0,0 +1,7 @@
++// This file is here, in part, so that users whose code editors are
++// set to automatically format files with Prettier have a config to detect.
++// Many users only run Prettier when a config is present, so this file makes
++// sure one can be detected, even though we aren't doing anything with it.
++module.exports = {
++	...require('@wordpress/prettier-config'),
++}","As a JS file, this should also receive our standard file header."
+3344,"@@ -1784,7 +1784,9 @@ short HashJoin::codeGen(Generator * generator) {
+   UInt16 numBMOsInFrag = (UInt16)generator->getFragmentDir()->getNumBMOs();
+
+   double memQuota = 0;
+-
++  double memQuotaRatio;
++  Lng32 numStreams;
++  double bmoMemoryUsagePerNode = getEstimatedRunTimeMemoryUsage(TRUE, &numStreams).value();
+   if (mmu != 0) {
+     memQuota = mmu;
+     hashj_tdb->setMemoryQuotaMB(mmu);","I take it memQuotaRatio is an ""out"" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case."
+3345,"@@ -49,7 +49,6 @@ func NewPullSubscription(name, namespace string, so ...PullSubscriptionOption) *
+ 	for _, opt := range so {
+ 		opt(s)
+ 	}
+-	s.SetDefaults(gcpauthtesthelper.ContextWithDefaults())
+ 	return s
+ }
+ ","It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions."
+3346,"@@ -186,6 +186,13 @@ type AssetParams struct {
+ 	// created.
+ 	Total uint64 `codec:""t""`
+
++	// Decimals specifies the number of digits to display after the decimal
++	// place when displaying this asset. A value of 0 represents an asset
++	// that is not divisible, a value of 1 represents an asset divisible
++	// into tenths, and so on. This value must be between 0 and 19
++	// (inclusive).
++	Decimals uint32 `codec:""dc""`
++
+ 	// DefaultFrozen specifies whether slots for this asset
+ 	// in user accounts are frozen by default or not.
+ 	DefaultFrozen bool `codec:""df""`","not dramatic, but why 32bits if we allow a range that is smaller than 8?"
+3347,"@@ -0,0 +1,8 @@
++package dto
++
++type ClientPromise struct {
++	SerialNumber int
++	IssuerId int
++	BenefiterId int
++	Amount int
++}",- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`
+3348,"@@ -193,6 +193,18 @@ public abstract class Either<L, R> implements io.vavr.Iterable<R>, io.vavr.Value
+     /**
+      * Maps either the left or the right side of this disjunction.
+      *
++     * <pre>{@code
++     *Either<?, AtomicInteger> success = Either.right(new AtomicInteger(42));
++     *
++     * //prints ""Right(42)""
++     * System.out.println(success.bimap(Function1.identity(), AtomicInteger::get));
++     *
++     * Either<Exception, ?> failure = Either.left(new Exception(""error""));
++     *
++     * //prints ""Left(error)""
++     * System.out.println(failure.bimap(Exception::getMessage, Function1.identity()));
++     * }</pre>
++     *
+      * @param leftMapper  maps the left value if this is a Left
+      * @param rightMapper maps the right value if this is a Right
+      * @param <X>         The new left type of the resulting Either",one space missing at the beginning
+3349,"@@ -43,8 +43,9 @@ type RequestDrivenWebServiceProps struct {
+
+ // AppRunnerInstanceConfig contains the instance configuration properties for an App Runner service.
+ type AppRunnerInstanceConfig struct {
+-	CPU    *int `yaml:""cpu""`
+-	Memory *int `yaml:""memory""`
++	CPU      *int   `yaml:""cpu""`
++	Memory   *int   `yaml:""memory""`
++	Platform string `yaml:""platform,omitempty""`
+ }
+
+ // NewRequestDrivenWebService creates a new Request-Driven Web Service manifest with default values.","I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `""""` if the environment manifest config doesn't specify `platform`   . If it gets overridden as `""""`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!  "
+3350,"@@ -26,7 +26,10 @@ exports = module.exports = function(grunt, options) {
+ 					'http://' + host + ':<%= connect.test.options.port %>/test/commons/',
+ 					'http://' +
+ 						host +
+-						':<%= connect.test.options.port %>/test/integration/rules/'
++						':<%= connect.test.options.port %>/test/integration/rules/',
++					'http://' +
++						host +
++						':<%= connect.test.options.port %>/test/integration/api/external/'
+ 				],
+ 				run: true,
+ 				growlOnSuccess: false,","I like the new directory `/api`, what is the thinking behind `/external`?"
+3351,"@@ -2844,11 +2844,10 @@ func (s *Server) updateAccountClaimsWithRefresh(a *Account, ac *jwt.AccountClaim
+ 	// update account signing keys
+ 	a.signingKeys = nil
+ 	signersChanged := false
+-	if len(ac.SigningKeys) > 0 {
+-		// insure copy the new keys and sort
+-		a.signingKeys = append(a.signingKeys, ac.SigningKeys...)
+-		sort.Strings(a.signingKeys)
++	for k, _ := range ac.SigningKeys {
++		a.signingKeys = append(a.signingKeys, k)
+ 	}
++	sort.Strings(a.signingKeys)
+ 	if len(a.signingKeys) != len(old.signingKeys) {
+ 		signersChanged = true
+ 	} else {",staticcheck flags this: replace with `for k := ..`
+3352,"@@ -132,8 +132,8 @@ def GMLAN_InitDiagnostics(
+         p = GMLAN() / GMLAN_PM(subfunction=""enableProgrammingMode"")
+         if verbose:
+             print(""Sending %s"" % repr(p))
+-        sock.send(p)
+         time.sleep(0.05)
++        sock.sr1(p, timeout=0.001, verbose=False)
+         return True
+     return False
+ ",There's already a sleep right above
+3353,"@@ -1249,9 +1249,16 @@ class AssertionFinder
+                         $if_types[$var_id] = [[$assertion->rule[0][0]]];
+                     }
+                 } elseif (\is_string($assertion->var_id)
+-                    && $expr instanceof PhpParser\Node\Expr\MethodCall
++                    && (
++                        $expr instanceof PhpParser\Node\Expr\MethodCall
++                        || $expr instanceof PhpParser\Node\Expr\StaticCall
++                    )
+                 ) {
+-                    $if_types[$assertion->var_id] = [[$assertion->rule[0][0]]];
++                    $var_id = $assertion->var_id;
++                    if (strpos($var_id, 'self::') === 0) {
++                        $var_id = $this_class_name . '::' . substr($var_id, 6);
++                    }
++                    $if_types[$var_id] = [[$assertion->rule[0][0]]];
+                 }
+
+                 if ($if_types) {","This feels hacky, is there a better way?"
+3354,"@@ -22,9 +22,14 @@
+ # IN THE SOFTWARE.
+ #
+ from math import ceil
+-from boto.compat import json, map, six
++from boto.compat import json, six
+ import requests
+
++try:
++    from collections import OrderedDict
++except ImportError:
++    from ordereddict import OrderedDict
++
+
+ class SearchServiceException(Exception):
+     pass","Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break."
+3355,"@@ -36,14 +36,14 @@ namespace Fixtures.Azure.AcceptanceTestsAzureBodyDuration
+         public Uri BaseUri { get; set; }
+
+         /// <summary>
+-        /// Gets or sets json serialization settings.
++        /// Gets JSON serialization settings.
+         /// </summary>
+         public JsonSerializerSettings SerializationSettings { get; private set; }
+
+         /// <summary>
+-        /// Gets or sets json deserialization settings.
++        /// Gets JSON deserialization settings.
+         /// </summary>
+-        public JsonSerializerSettings DeserializationSettings { get; private set; }
++        public JsonSerializerSettings DeserializationSettings { get; private set; }
+
+         /// <summary>
+         /// Gets Azure subscription credentials.","""Gets the JSON serialization settings."" would be better?"
+3356,"@@ -38,6 +38,15 @@ func (s *server) setupRouting() {
+ 	handle(router, ""/bytes"", jsonhttp.MethodHandler{
+ 		""POST"": http.HandlerFunc(s.bytesUploadHandler),
+ 	})
++
++	handle(router, ""/file"", jsonhttp.MethodHandler{
++		""POST"": http.HandlerFunc(s.bzzFileUploadHandler),
++	})
++
++	handle(router, ""/file/{addr}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.bzzFileDownloadHandler),
++	})
++
+ 	handle(router, ""/bytes/{address}"", jsonhttp.MethodHandler{
+ 		""GET"": http.HandlerFunc(s.bytesGetHandler),
+ 	})",The endpoint should be in plural `/files`.
+3357,"@@ -141,6 +141,9 @@ AtomPDBResidueInfo *AtomGetPDBResidueInfo(Atom *atom) {
+   return (AtomPDBResidueInfo *)res;
+ }
+
++struct MDLDummy {};
++struct DaylightDummy {};
++
+ // FIX: is there any reason at all to not just prevent the construction of
+ // Atoms?
+ std::string atomClassDoc =","??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go."
+3358,"@@ -40,7 +40,7 @@ func InitContext(contextType string) {
+ 	})
+ }
+
+-func GetContext() gocontext.Context{
++func GetContext() gocontext.Context {
+ 	return context.ctx
+ }
+ func Done() <-chan struct{} {",I think this line is gofmt issue? @daixiang0
+3359,"@@ -94,6 +94,16 @@ func TestSubrepoLabel(t *testing.T) {
+ 	assert.EqualValues(t, BuildLabel{PackageName: """", Name: """"}, label.SubrepoLabel())
+ }
+
++func TestParseBuildLabelParts(t *testing.T) {
++	target1 := ""@unittest_cpp//:unittest_cpp""
++	targetNewSyntax := ""@unittest_cpp""
++	pkg, name, subrepo := parseBuildLabelParts(target1, ""/"", nil)
++	pkg2, name2, subrepo2 := parseBuildLabelParts(targetNewSyntax, ""/"", nil)
++	assert.Equal(t, pkg, pkg2)
++	assert.Equal(t, name, name2)
++	assert.Equal(t, subrepo, subrepo2)
++}
++
+ func TestMain(m *testing.M) {
+ 	// Used to support TestComplete, the function it's testing re-execs
+ 	// itself thinking that it's actually plz.","probably better to assert the values directly; technically you could pass this test with an implementation that always returned """" for the subrepo for example."
+3360,"@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		big.NewInt(10),
+ 	)
+ 	pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
+-	sig, _ := hex.DecodeString(""3584fe777dd090e1a7a825896f532485ea2cc35d7c300c6c56f0e2e78b51c6ded33f7d0069f4f6f6b6762306466fcff6f261bb30d9e1550f2f8be4f988e740903fd734209cb60101"")
++	sig, _ := hex.DecodeString(""9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01"")
+ 	bd := &action.EnvelopeBuilder{}
+ 	elp := bd.SetAction(tsf0).
+ 		SetDestinationAddress(ta.Addrinfo[""producer""].Bech32()).",line is 161 characters (from `lll`)
+3361,"@@ -19,13 +19,14 @@
+
+ package org.apache.iceberg.catalog;
+
++import java.io.Serializable;
+ import java.util.Arrays;
+ import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+
+ /**
+  * A namespace in a {@link Catalog}.
+  */
+-public class Namespace {
++public class Namespace implements Serializable {
+   private static final Namespace EMPTY_NAMESPACE = new Namespace(new String[] {});
+   private static final Joiner DOT = Joiner.on('.');
+ ",Are these changes needed?
+3362,"@@ -78,12 +78,12 @@ public final class UserUtils {
+       }
+
+       try {
+-        Path dir = Paths.get(fileName).getParent();
++        final Path dir = Paths.get(fileName).getParent();
+         if (!dirToFilesMap.containsKey(dir)) {
+-          // There is not entry for this directory, create a watchkey
++          // There is no entry for this directory, create a watchkey
+           WatchKey watchKey = dir.register(watchService,
+               new WatchEvent.Kind[]{StandardWatchEventKinds.ENTRY_MODIFY},
+-              SensitivityWatchEventModifier.HIGH);
++              SensitivityWatchEventModifier.LOW);
+           keys.put(watchKey, dir);
+         }
+         // Add the config file to dir map","It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?"
+3363,"@@ -3,7 +3,9 @@
+ namespace Thelia\Model;
+
+ use Thelia\Model\Base\CategoryDocumentI18n as BaseCategoryDocumentI18n;
++use Thelia\Model\Tools\I18nTimestampableTrait;
+
+ class CategoryDocumentI18n extends BaseCategoryDocumentI18n
+ {
++    use I18nTimestampableTrait;
+ }",missing use statement for importing the full namespace
+3364,"@@ -35,6 +35,9 @@ var ErrInsufficientHosts = &shared.InternalServiceError{Message: ""Not enough hos
+ // ErrListenerAlreadyExist is thrown on a duplicate AddListener call from the same listener
+ var ErrListenerAlreadyExist = errors.New(""Listener already exist for the service"")
+
++// ErrIncorrectAddressFormat is thrown on incorrect address format
++var ErrIncorrectAddressFormat = errors.New(""Incorrect address format"")
++
+ type (
+
+ 	// ChangedEvent describes a change in membership",Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?
+3365,"@@ -285,7 +285,7 @@ describe('Core_selection', () => {
+     selectCell(0, 0);
+     keyDownUp('arrow_left');
+
+-    expect(getSelected()).toEqual([[0, 0, 0, 0]]);
++    expect(getSelected()).toEqual([[4, 4, 4, 4]]);
+   });
+
+   it('should fix start range if provided is out of bounds (to the top)', () => {",These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file.
+3366,"@@ -60,7 +60,17 @@ namespace Nethermind.Evm.TransactionProcessing
+             /// <summary>
+             /// Commit and later restore state, use for CallAndRestore
+             /// </summary>
+-            CommitAndRestore = Commit | Restore
++            CommitAndRestore = Commit | Restore,
++
++            /// <summary>
++            /// Zero Gas price
++            /// </summary>
++            ZeroGasPrice = 4,
++
++            /// <summary>
++            /// Commit and restore with zero gas price
++            /// </summary>
++            CommitAndRestoreWithZeroGasPrice = CommitAndRestore | ZeroGasPrice
+         }
+
+         public TransactionProcessor(",I would prefer flag SkipGasPricingValidation
+3367,"@@ -1492,6 +1492,13 @@ void nano::work_watcher::add (std::shared_ptr<nano::block> block_a)
+ 	}
+ }
+
++bool nano::work_watcher::is_watched (nano::qualified_root const root_a)
++{
++	std::unique_lock<std::mutex> lock (mutex);
++	auto exists (blocks.find (root_a));
++	return exists != blocks.end ();
++}
++
+ void nano::wallets::do_wallet_actions ()
+ {
+ 	std::unique_lock<std::mutex> action_lock (action_mutex);",could be `const &` ?
+3368,"@@ -75,6 +75,7 @@ module.exports = class Dashboard extends Plugin {
+       defaultTabIcon: defaultTabIcon,
+       showProgressDetails: false,
+       hideUploadButton: false,
++      hideProgressAfterFinish: false,
+       note: null,
+       closeModalOnClickOutside: false,
+       locale: defaultLocale,",The docs should also be updated with the new option.
+3369,"@@ -157,6 +157,15 @@ def send_email(subject, message, sender, recipients, image_png=None):
+         send_email_smtp(config, sender, subject, message, recipients, image_png)
+
+
++def send_notification(subject, message, topic):
++    import boto.sns
++    config = configuration.get_config()
++    con = boto.sns.connect_to_region(config.get('sns', 'region', 'us-east-1'),
++                                     aws_access_key_id=config.get('sns', 'AWS_ACCESS_KEY', None),
++                                     aws_secret_access_key=config.get('sns', 'AWS_SECRET_KEY', None))
++    con.publish(topic, message, subject[:100])
++
++
+ def send_error_email(subject, message):
+     """"""
+     Sends an email to the configured error-email.",Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?
+3370,"@@ -31,7 +31,7 @@ func run() error {
+ 		return fmt.Errorf(""failed to load config file: %s"", err)
+ 	}
+
+-	logger := logging.BuildLogger(cfg.Logging.Level)
++	logger := logging.BuildLogger(*cfg.Logging.Level)
+ 	ctx := log.WithLogger(context.Background(), logger)
+
+ 	key, err := cfg.Eth.LoadKey()",Out of the scope.
+3371,"@@ -151,4 +151,12 @@ if (typeof Object.assign != 'function') {
+     }
+     return to;
+   };
+-}
++}
++
++
++NodeList.prototype.forEach = function(callback, thisArg) {
++  thisArg = thisArg || window;
++  for (var i = 0; i < this.length; i++) {
++      callback.call(thisArg, this[i], i, this);
++  }
++};",I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation.
+3372,"@@ -89,6 +89,11 @@ function _getItem(name) {
+  * @param {Function} editorClass Editor class.
+  */
+ function _register(name, editorClass) {
++  if (name && typeof name !== 'string') {
++    editorClass = name;
++    name = editorClass.EDITOR_TYPE;
++  }
++
+   const editorWrapper = new RegisteredEditor(editorClass);
+
+   if (typeof name === 'string') {","I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?"
+3373,"@@ -1,7 +1,6 @@
+ // Copyright 2020 The Swarm Authors. All rights reserved.
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+-
+ package p2p
+
+ import (","This line should not be removed, as it is not the description of the package, but a copyright header."
+3374,"@@ -37,6 +37,8 @@ type DiskBlockCacheMetadata struct {
+ 	TriggeredPrefetch bool `codec:""HasPrefetched""`
+ 	// whether the block's triggered prefetches are complete
+ 	FinishedPrefetch bool
++	// the last tag with which the block was marked
++	Tag string
+ }
+
+ // lruEntry is an entry for sorting LRU times",Wouldn't it be more space efficient to make this a `byte` enum or bitfield?
+3375,"@@ -207,13 +207,13 @@ class PostgresTarget(luigi.Target):
+         connection.autocommit = True
+         cursor = connection.cursor()
+         if self.use_db_timestamps:
+-            sql = """""" CREATE TABLE {marker_table} (
++            sql = """""" CREATE TABLE IF NOT EXISTS {marker_table} (
+                       update_id TEXT PRIMARY KEY,
+                       target_table TEXT,
+                       inserted TIMESTAMP DEFAULT NOW())
+-                """""".format(marker_table=self.marker_table)
++                  """""".format(marker_table=self.marker_table)
+         else:
+-            sql = """""" CREATE TABLE {marker_table} (
++            sql = """""" CREATE TABLE IF NOT EXISTS {marker_table} (
+                       update_id TEXT PRIMARY KEY,
+                       target_table TEXT,
+                       inserted TIMESTAMP);","Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`."
+3376,"@@ -0,0 +1,13 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.ast;
++
++/**
++ * Marker interface for type body declarations.
++ *
++ * @author Clément Fournier
++ */
++public interface ASTAnyTypeBodyDeclaration extends JavaNode {
++}","Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields"
+3377,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities"
+3378,"@@ -30,6 +30,15 @@ import org.apache.iceberg.io.LocationProvider;
+  */
+ public interface Table {
+
++  /**
++   * Return the full name for this table.
++   *
++   * @return this table's name
++   */
++  default String name() {
++    return toString();
++  }
++
+   /**
+    * Refresh the current table metadata.
+    */",It is debatable whether we have to default this. I did this to avoid breaking custom implementations.
+3379,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done
+3380,"@@ -8,7 +8,7 @@ import (
+ 	""fmt""
+ 	""strings""
+
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/addons""
++	addon ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon""
+ 	awscloudformation ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/cloudformation""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/ecr""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/s3""","we shouldn't need the ""addon"" rename"
+3381,"@@ -1,4 +1,6 @@
+ class Admin::DecksController < ApplicationController
++  before_filter :must_be_admin
++
+   def index
+     @decks = Deck.all
+   end",These are covered by routing constraints.
+3382,"@@ -32,7 +32,7 @@ import (
+ func (s *Service) InstanceIfExists(instanceID *string) (*v1alpha1.Instance, error) {
+ 	glog.V(2).Infof(""Looking for instance %q"", *instanceID)
+ 	input := &ec2.DescribeInstancesInput{
+-		InstanceIds: []*string{instanceID},
++		InstanceIds: aws.StringSlice([]string{*instanceID}),
+ 	}
+
+ 	out, err := s.EC2.DescribeInstances(input)",Could we use just a normal string here?
+3383,"@@ -1,6 +1,8 @@
+ import { VNode } from './vnode';
+ import options from './options';
++import { iterableToArray, isFunction } from './util';
+
++const hasSymbolSupport = isFunction(Symbol) && Symbol.iterator;
+
+ const stack = [];
+ ",`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however.
+3384,"@@ -140,6 +140,10 @@ void nano::election_scheduler::run ()
+ 					election->transition_active ();
+ 				}
+ 			}
++			else
++			{
++				lock.unlock ();
++			}
+ 			notify ();
+ 			lock.lock ();
+ 		}",Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero.
+3385,"@@ -189,7 +189,7 @@ func dispense(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	tx, err := c.SendPaymentFromUnencryptedWallet(cfg.Source, target, uint64(cfg.Fee), uint64(cfg.Amount), nil)
++	tx, err := c.SendPaymentFromUnencryptedWallet(cfg.Source, target, uint64(cfg.Fee), uint64(cfg.Amount), [32]byte{}, nil)
+ 	if err != nil {
+ 		http.Error(w, fmt.Sprintf(""failed to dispense money - %v"", err), http.StatusInternalServerError)
+ 		return","do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if ""no"" this is fine, if ""yes"" it's probably still fine"
+3386,"@@ -19,13 +19,14 @@ package org.openqa.selenium.remote;
+
+ import com.google.common.collect.ImmutableMap;
+
++import org.openqa.selenium.DeviceRotation;
+ import org.openqa.selenium.Rotatable;
+ import org.openqa.selenium.ScreenOrientation;
+
+ import java.lang.reflect.Method;
+
+ public class AddRotatable implements AugmenterProvider {
+-
++
+   public Class<?> getDescribedInterface() {
+     return Rotatable.class;
+   }","you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)"
+3387,"@@ -35,6 +35,12 @@ export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, Paginat
+                 });
+             }
+
++            // we need to load the roles into ember cache
++            // invites return role_id only and we do not offer a /role/:id endpoint
++            this.get('store').query('role', {permissions: 'assign'}).then((roles) => {
++                modelPromises.roles = roles;
++            });
++
+             return RSVP.hash(modelPromises);
+         });
+     },","This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async."
+3388,"@@ -0,0 +1,19 @@
++const landmarks = axe.commons.aria.getRolesByType('landmark');
++const sectioning = ['article', 'aside', 'main', 'navigation', 'section'];
++const nodeIsHeader = node.tagName.toLowerCase() === 'header' && node.getAttribute('role') !== 'banner';
++var parent = axe.commons.dom.getComposedParent(node);
++
++while (parent){
++	var role = parent.getAttribute('role');
++	if (!role && (parent.tagName.toLowerCase() !== 'form')){
++		role = axe.commons.aria.implicitRole(parent);
++	}
++  if (role && nodeIsHeader && sectioning.includes(role)){
++    return true;
++  }
++	if (role && landmarks.includes(role)){
++		return false;
++	}
++	parent = axe.commons.dom.getComposedParent(parent);
++}
++return true;","This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test."
+3389,"@@ -63,13 +63,13 @@ public class PackageListeners {
+   }
+
+   synchronized void packagesUpdated(List<PackageLoader.Package> pkgs) {
+-    MDCLoggingContext.setCore(core);
++    if(core != null) MDCLoggingContext.setCore(core);
+     try {
+       for (PackageLoader.Package pkgInfo : pkgs) {
+         invokeListeners(pkgInfo);
+       }
+     } finally {
+-      MDCLoggingContext.clear();
++      if(core != null) MDCLoggingContext.clear();
+     }
+   }
+ ",Why do we need this check? setCore already handles nulls.
+3390,"@@ -121,7 +121,7 @@ def _inject(target_type, inject_type):
+     # Inject all the methods from the hierarchy:
+     setattr(target_type, ""__getattr__"", inject_type.__getattr__)
+     setattr(target_type, ""__getitem__"", inject_type.__getitem__)
+-    for attr in [""__iter__"", ""__len__"", ""__invert__"", ""__setitem__""]:
++    for attr in [""__iter__"", ""__len__"", ""__invert__"", ""__setitem__"", ""__dir__""]:
+         if hasattr(inject_type, attr):
+             setattr(target_type, attr, inject_type.__dict__[attr])
+     for t in mro:","good catch, thanks. This is going to make the user experience much better."
+3391,"@@ -1,4 +1,4 @@
+-import { options } from 'preact';
++import { Component, options } from 'preact';
+
+ /** @type {number} */
+ let currentIndex;",TODO: remove this unused import
+3392,"@@ -591,7 +591,7 @@ func (s *HandlerTestSuite) TestValidateJWTSVID() {
+ 			},
+ 			workloadUpdate: &cache.WorkloadUpdate{},
+ 			code:           codes.InvalidArgument,
+-			msg:            ""token contains an invalid number of segments"",
++			msg:            ""square/go-jose: compact JWS format must have three parts"",
+ 		},
+ 		{
+ 			name: ""validated by our trust domain bundle"",","Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned ""could not parse token"" or something instead?"
+3393,"@@ -9,12 +9,14 @@ module Travis
+         }
+
+         def install
+-          self.if   '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
++          self.if   '-f ./gradlew',    './gradlew assemble', fold: 'install', retry: true
++          self.elif '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
+           self.elif '-f pom.xml',      'mvn install -DskipTests=true -B', fold: 'install', retry: true # Otherwise mvn install will run tests which. Suggestion from Charles Nutter. MK.
+         end
+
+         def script
+-          self.if   '-f build.gradle', 'gradle check'
++          self.if   '-f ./gradlew',    './gradlew check'
++          self.elif '-f build.gradle', 'gradle check'
+           self.elif '-f pom.xml',      'mvn test -B'
+           self.else                    'ant test'
+         end",I think `-f gradlew` is better for code unity
+3394,"@@ -40,4 +40,10 @@ public class FlinkConfigOptions {
+           .intType()
+           .defaultValue(100)
+           .withDescription(""Sets max infer parallelism for source operator."");
++
++  public static final ConfigOption<Integer> SOURCE_READER_FETCH_RECORD_BATCH_SIZE = ConfigOptions
++      .key(""source.iceberg.reader.fetch-record-batch-size"")
++      .intType()
++      .defaultValue(2048)
++      .withDescription(""The target record batch size for split reader fetch."");
+ }",Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?
+3395,"@@ -1,4 +1,4 @@
+-using System;
++using System;
+ using System.Collections.Generic;
+ using System.Globalization;
+ using System.Linq.Expressions;",Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes
+3396,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[UpdateServerCertificate.java demonstrates how to update the name of an AWS Identity and Access Management (IAM) server certificate.]
++//snippet-sourcedescription:[UpdateServerCertificate.java demonstrates how to update the name of an AWS Identity and Access Management (AWS IAM) server certificate.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+3397,"@@ -83,14 +83,10 @@ func NewCommand(licenseCommandName string) *cli.Command {
+ 			cmd.RegisterSignalCallback(func() { errorChannel <- nil })
+
+ 			cmdService := &serviceCommand{
+-				tequilapi:    client.NewClient(nodeOptions.TequilapiAddress, nodeOptions.TequilapiPort),
+-				errorChannel: errorChannel,
+-				identityHandler: identity_selector.NewHandler(
+-					di.IdentityManager,
+-					di.MysteriumAPI,
+-					identity.NewIdentityCache(nodeOptions.Directories.Keystore, ""remember.json""),
+-					di.SignerFactory),
+-				ap: parseAccessPolicyFlag(ctx),
++				tequilapi:       client.NewClient(nodeOptions.TequilapiAddress, nodeOptions.TequilapiPort),
++				errorChannel:    errorChannel,
++				identityHandler: di.IdentitySelector,
++				ap:              parseAccessPolicyFlag(ctx),
+ 			}
+
+ 			go func() {",You dont use this dependency anymore
+3398,"@@ -86,6 +86,8 @@ public abstract class AbstractSmartStoreTest extends SmartStoreTestCase {
+
+ 		assertTrue(""ENABLE_FTS4 flag not found in compile options"", compileOptions.contains(""ENABLE_FTS4""));
+ 		assertTrue(""ENABLE_FTS3_PARENTHESIS flag not found in compile options"", compileOptions.contains(""ENABLE_FTS3_PARENTHESIS""));
++		assertTrue(""ENABLE_FTS5 flag not found in compile options"", compileOptions.contains(""ENABLE_FTS5""));
++		assertTrue(""ENABLE_JSON1 flag not found in compile options"", compileOptions.contains(""ENABLE_JSON1""));
+ 	}
+
+ 	/**",Here is the test that checks that the sqlcipher in use was compiled with the right flags
+3399,"@@ -199,6 +199,8 @@ public class LoginServerManager {
+ 		} catch (Exception e) {
+ 			Log.w(""LoginServerManager.getLoginServersFromRuntimeConfig"",
+ 					""Exception thrown while attempting to read array, attempting to read string value instead"");
++		}
++		if (mdmLoginServers == null) {
+ 			final String loginServer = runtimeConfig.getString(ConfigKey.AppServiceHosts);
+ 			if (!TextUtils.isEmpty(loginServer)) {
+ 				mdmLoginServers = new String[] {loginServer};","Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work."
+3400,"@@ -16,8 +16,12 @@
+
+ package io.servicecomb.provider.springmvc.reference;
+
++import java.net.URI;
++
+ import org.junit.Assert;
+ import org.junit.Test;
++import org.springframework.web.client.RestClientException;
++import org.springframework.web.client.RestTemplate;
+
+ public class TestRestTemplateBuilder {
+ ",this test only covers the happy path. what about no acceptable rest template found?
+3401,"@@ -582,7 +582,7 @@ public class DistributorTest {
+         );
+
+         Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession();
+-        LOG.info(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
++        LOG.finer(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
+
+         boolean inFirefoxNodes = firefoxNodes.stream().anyMatch(node -> node.getUri().equals(firefoxSession.getUri()));
+         boolean inChromeNodes = chromeNodes.stream().anyMatch(node -> node.getUri().equals(chromeSession.getUri()));","Since this is in a test, I imagine that the choice of `info` level was deliberate."
+3402,"@@ -3,9 +3,10 @@ package langserver
+ import (
+ 	""context""
+ 	""github.com/stretchr/testify/assert""
+-	""strings""
+ 	""testing""
+
++	""core""
++	""strings""
+ 	""tools/build_langserver/lsp""
+ )
+ ",this should probably be named somewhere if you want to reuse it.
+3403,"@@ -191,6 +191,14 @@ const (
+ 	// path where we mount in the SSH key for connecting to the bare metal libvirt provisioning host.
+ 	LibvirtSSHPrivKeyPathEnvVar = ""LIBVIRT_SSH_PRIV_KEY_PATH""
+
++	// BoundServiceAccountSigningKeyEnvVar contains the path to the bound service account signing key and
++	// is set in the install pod for AWS STS clusters.
++	BoundServiceAccountSigningKeyEnvVar = ""AWS_BOUND_SA_SIGNING_KEY""
++
++	// BoundServiceAccountSigningKeyFile is the Secret key and projected filename where an AWS STS
++	// SA signing key will be projected into the install pod.
++	BoundServiceAccountSigningKeyFile = ""bound-service-account-signing-key.key""
++
+ 	// FakeClusterInstallEnvVar is the environment variable Hive will set for the installmanager pod to request
+ 	// a fake install.
+ 	FakeClusterInstallEnvVar = ""FAKE_INSTALL""",needs a rename to not include AWS
+3404,"@@ -15,13 +15,11 @@
+ *******************************************************************************/
+
+ #include ""oneapi/dal/algo/rbf_kernel/backend/gpu/compute_kernel.hpp""
+-#include ""oneapi/dal/backend/interop/common_dpc.hpp""
+-#include ""oneapi/dal/backend/interop/table_conversion.hpp""
+-
++#include ""oneapi/dal/backend/primitives/reduction.hpp""
++#include ""oneapi/dal/backend/primitives/blas.hpp""
++#include ""oneapi/dal/backend/math.hpp""
+ #include ""oneapi/dal/table/row_accessor.hpp""
+
+-#include <daal/src/algorithms/kernel_function/oneapi/kernel_function_rbf_kernel_oneapi.h>
+-
+ namespace oneapi::dal::rbf_kernel::backend {
+
+ using dal::backend::context_gpu;",Isn't sigma have `double` type?
+3405,"@@ -977,6 +977,7 @@ TEST (rpc, wallet_create_seed)
+ 	nano::system system (24000, 1);
+ 	scoped_io_thread_name_change scoped_thread_name_io;
+ 	nano::raw_key seed;
++	seed.data = 1;
+ 	auto prv = nano::deterministic_key (seed, 0);
+ 	auto pub (nano::pub_key (prv));
+ 	auto node = system.nodes.front ();",May be better use nano::keypair that generates ramdom value?
+3406,"@@ -25,7 +25,11 @@ const isPromiseLike = require('../utils').isPromiseLike;
+ function addToOperationsList(bulkOperation, docType, document) {
+   // Get the bsonSize
+   const bsonSize = bson.calculateObjectSize(document, {
+-    checkKeys: false
++    checkKeys: false,
++
++    // Since we don't know what the user selected for BSON options here,
++    // err on the safe side, and check the size with ignoreUndefined: false.
++    ignoreUndefined: false
+   });
+
+   // Throw error if the doc is bigger than the max BSON size","I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?"
+3407,"@@ -257,6 +257,10 @@ public class SyncManager {
+                             break;
+                     }
+                     updateSync(sync, SyncState.Status.DONE, 100, callback);
++                } catch (RestClient.RefreshTokenRevokedException re) {
++                    logger.e(this, ""runSync"", re);
++                    // Do not do anything - let the logout go through!
++
+                 } catch (Exception e) {
+                     logger.e(this, ""runSync"", e);
+                     // Update status to failed","The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user."
+3408,"@@ -27,6 +27,11 @@ func TestCodestar_WaitUntilStatusAvailable(t *testing.T) {
+ 		connection := &CodeStar{}
+ 		connectionARN := ""mockConnectionARN""
+
++		ctrl := gomock.NewController(t)
++		defer ctrl.Finish()
++		m := mocks.NewMockapi(ctrl)
++		m.EXPECT().GetConnection(gomock.Any()).AnyTimes()
++
+ 		// WHEN
+ 		err := connection.WaitUntilConnectionStatusAvailable(ctx, connectionARN)
+ ",huh does this work without a `Return`?
+3409,"@@ -134,11 +134,7 @@ module RSpec
+                 # no-op, required metadata has already been set by the `skip`
+                 # method.
+               rescue Exception => e
+-                if pending?
+-                  metadata[:execution_result][:pending_exception] = e
+-                else
+-                  set_exception(e)
+-                end
++                set_exception(e)
+               ensure
+                 run_after_each
+               end","Don't think we want this line, right? (Plus ""failing"" is spelled wrong)."
+3410,"@@ -105,6 +105,10 @@ public class FeedItemMenuHandler {
+
+         setItemVisibility(menu, R.id.remove_item, fileDownloaded);
+
++        if (selectedItem.getFeed().isLocalFeed()) {
++            setItemVisibility(menu, R.id.share_item, false);
++        }
++
+         return true;
+     }
+ ","I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example."
+3411,"@@ -199,14 +199,6 @@ class BackendMenuBuilder implements BackendMenuBuilderInterface
+             ],
+         ]);
+
+-        $menu->getChild('Maintenance')->addChild('Fixtures', [
+-            'uri' => '',
+-            'extras' => [
+-                'name' => $t->trans('caption.fixtures_dummy_content'),
+-                'icon' => 'fa-hat-wizard',
+-            ],
+-        ]);
+-
+         $menu->getChild('Maintenance')->addChild('Clear the cache', [
+             'uri' => $this->urlGenerator->generate('bolt_clear_cache'),
+             'extras' => [","Why remove this one? It doesn't work yet, but we'll add it sooner or later."
+3412,"@@ -304,12 +304,12 @@ type docstruct struct {
+ 	DocstoreRevision interface{}
+ 	Etag             interface{}
+
+-	I  int                    `docstore:""i""`
+-	U  uint                   `docstore:""u""`
+-	F  float64                `docstore:""f""`
+-	St string                 `docstore:""st""`
+-	B  bool                   `docstore:""b""`
+-	M  map[string]interface{} `docstore:""m""`
++	I  int
++	U  uint
++	F  float64
++	St string
++	B  bool
++	M  map[string]interface{}
+ }
+
+ func nonexistentDoc() docmap { return docmap{KeyField: ""doesNotExist""} }",Why did you remove the struct tags?
+3413,"@@ -178,6 +178,11 @@ class FinalStatus(Reporter, AggregatorListener, FunctionalAggregatorListener):
+     def __dump_xml(self, filename):
+         self.log.info(""Dumping final status as XML: %s"", filename)
+         root = etree.Element(""FinalStatus"")
++        report_info = get_bza_report_info(self.engine, self.log)
++        if report_info:
++            link, text = report_info[0]
++            report_element = etree.Element(""BlazeMeterReport"", link=link, name=text)
++            root.append(report_element)
+         if self.last_sec:
+             for label, kpiset in iteritems(self.last_sec[DataPoint.CUMULATIVE]):
+                 root.append(self.__get_xml_summary(label, kpiset))","Let's be neutral with tag names. Let's just have ""ReportURL"""
+3414,"@@ -265,7 +265,8 @@ func TestEmptySpanData(t *testing.T) {
+ func TestSpanData(t *testing.T) {
+ 	// Full test of span data transform.
+
+-	startTime := time.Now()
++	// March 31, 2020 5:01:26 1234nanos (UTC)
++	startTime := time.Unix(1585674086, 1234)
+ 	endTime := startTime.Add(10 * time.Second)
+ 	spanData := &export.SpanData{
+ 		SpanContext: core.SpanContext{",Use an explicit time to ensure conversion is not copy-paste and wrong.
+3415,"@@ -804,7 +804,11 @@ void handle_lookup_account_poll(GUI_RPC_CONN& grc) {
+             grc.lookup_account_op.error_num
+         );
+     } else {
+-        grc.mfout.printf(""%s"", grc.lookup_account_op.reply.c_str());
++        const char *p = grc.lookup_account_op.reply.c_str();
++        const char *q = strstr(p, ""<account_out"");
++        if (!q) q = strstr(p, ""<error"");
++        if (!q) q = ""<account_out/>\n"";
++        grc.mfout.printf(""%s"", q);
+     }
+ }
+ ",The logic now is to look for `<account_out` if that is present return the string starting from there. If it is not present look for `<error` and return the string from there (which can produce malformed XML because you do not check if the closing tag matches). If this is also not found return an empty `<account_out/>`. This `<error>` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?
+3416,"@@ -0,0 +1,12 @@
++class Api::V1::VideosController < ApiController
++  def index
++    show = find_show
++    render json: { videos: show.videos }
++  end
++
++  private
++
++  def find_show
++    Show.friendly.find(params[:show_id])
++  end
++end",Use nested module/class definitions instead of compact style.
+3417,"@@ -56,6 +56,7 @@ var individualTestTimeout = 10 * time.Second
+
+ func kbfsOpsInit(t *testing.T, changeMd bool) (mockCtrl *gomock.Controller,
+ 	config *ConfigMock, ctx context.Context, cancel context.CancelFunc) {
++	t.Log(""Init KBFSOps"")
+ 	ctr := NewSafeTestReporter(t)
+ 	mockCtrl = gomock.NewController(ctr)
+ 	config = NewConfigMock(mockCtrl, ctr)","Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it."
+3418,"@@ -95,7 +95,7 @@ public class FreezeTimersOverlay extends Overlay
+ 	{
+ 		final Player player = playerDespawned.getPlayer();
+ 		// All despawns ok: death, teleports, log out, runs away from screen
+-		if (config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng() | config.TB())
++		if (config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng())
+ 		{
+ 			this.remove(player);
+ 		}",showNPCs is not needed
+3419,"@@ -0,0 +1,12 @@
++package ssm
++
++import ""fmt""
++
++// ErrParameterAlreadyExists occurs when the parameter with name already existed.
++type ErrParameterAlreadyExists struct {
++	name string
++}
++
++func (e *ErrParameterAlreadyExists) Error() string {
++	return fmt.Sprintf(""parameter %s already exists"", e.name)
++}",Docstring for public function pls
+3420,"@@ -1539,3 +1539,16 @@ func TestSSIReApplyDuration(t *testing.T) {
+ 		}
+ 	}
+ }
++
++func TestFilterApplyError(t *testing.T) {
++	err1 := ""error when creating \""/tmp/apply-475927931\"": namespaces \""openshift-am-config\"" not found""
++	expectedFilteredErr1 := ""namespaces \""openshift-am-config\"" not found""
++	if filterApplyError(err1) != expectedFilteredErr1 {
++		t.Fatalf(""expected temporary file to be trimmed from error message"")
++	}
++
++	err2 := ""unable to parse \""[ { \\\""op\\\"": \\\""replace\\\"", \\\""path\\\"": \\\""/data/foo\\\"", \\\""value\\\"": \\\""baz-json\\\"" ]\"": yaml: did not find expected ',' or '}'""
++	if filterApplyError(err2) != err2 {
++		t.Fatalf(""expected error message to be unchanged"")
++	}
++}",This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails.
+3421,"@@ -715,7 +715,7 @@ int main(int argc, char **argv)
+ #endif
+     }
+
+-    if (ctx.http3 != NULL) {
++    if (ctx.protocol_selector.ratio.http3 > 0) {
+         h2o_quic_close_all_connections(&ctx.http3->h3);
+         while (h2o_quic_num_connections(&ctx.http3->h3) != 0) {
+ #if H2O_USE_LIBUV","Should this if block better be changed to `#if H2O_USE_LIBUV \n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op."
+3422,"@@ -87,8 +87,11 @@ export function useReducer(reducer, initialState, init) {
+ 			init == null ? invokeOrReturn(null, initialState) : init(initialState),
+
+ 			action => {
+-				hookState._value[0] = reducer(hookState._value[0], action);
+-				hookState._component.setState({});
++				const nextValue = reducer(hookState._value[0], action);
++				if (!Object.is(hookState._value[0], nextValue)) {
++					hookState._value[0] = nextValue;
++					hookState._component.setState({});
++				}
+ 			}
+ 		];
+ 	}",`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?
+3423,"@@ -22,7 +22,11 @@ class AddUserOperation extends CommandOperation {
+     const options = this.options;
+
+     // Get additional values
+-    let roles = Array.isArray(options.roles) ? options.roles : [];
++    let roles = Array.isArray(options.roles)
++      ? options.roles
++      : typeof options.roles === 'string'
++      ? [options.roles]
++      : [];
+
+     // If not roles defined print deprecated message
+     // TODO: handle deprecation properly","This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)"
+3424,"@@ -80,6 +80,17 @@ public interface CollectionAdminParams {
+    */
+   String COLL_CONF = ""collection.configName"";
+
++  /**
++   * The name of the collection with which a collection is to be co-located
++   */
++  String WITH_COLLECTION = ""withCollection"";
++
++  /**
++   * The reverse-link to WITH_COLLECTION flag. It is stored in the cluster state of the `withCollection`
++   * and points to the collection on which the `withCollection` was specified.
++   */
++  String COLOCATED_WITH = ""COLOCATED_WITH"";
++
+   /**
+    * Used by cluster properties API as a wrapper key to provide defaults for collection, cluster etc.
+    *",It would be helpful to explicit here what this really means and assumes.
+3425,"@@ -46,6 +46,9 @@ type AddressKey struct {
+ 	PriKey      keypair.PrivateKey
+ }
+
++//ExpectedBalances records expectd balances of admins and delegates
++var ExpectedBalances map[string]*big.Int
++
+ // LoadAddresses loads key pairs from key pair path and construct addresses
+ func LoadAddresses(keypairsPath string, chainID uint32) ([]*AddressKey, error) {
+ 	// Load Senders' public/private key pairs",`ExpectedBalances` is a global variable (from `gochecknoglobals`)
+3426,"@@ -1,7 +1,7 @@
+ module RSpec
+   module Core
+     module Formatters
+-      # This class extracts code snippets by looking at the backtrace of the passed error
++      # Extracts code snippets by looking at the backtrace of the passed error and applies synax highlighting and line numbers using html.
+       class SnippetExtractor
+         class NullConverter; def convert(code, pre); code; end; end
+ ","This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use."
+3427,"@@ -57,11 +57,14 @@ func addAccountToMemResolver(s *Server, pub, jwtclaim string) {
+ 	s.mu.Unlock()
+ }
+
+-func createClient(t *testing.T, s *Server, akp nkeys.KeyPair) (*client, *bufio.Reader, string) {
++func createClient(t *testing.T, s *Server, akp nkeys.KeyPair, optIssuerAccount string) (*client, *bufio.Reader, string) {
+ 	t.Helper()
+ 	nkp, _ := nkeys.CreateUser()
+ 	pub, _ := nkp.PublicKey()
+ 	nuc := jwt.NewUserClaims(pub)
++	if optIssuerAccount != """" {
++		nuc.IssuerAccount = optIssuerAccount
++	}
+ 	ujwt, err := nuc.Encode(akp)
+ 	if err != nil {
+ 		t.Fatalf(""Error generating user JWT: %v"", err)","Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the """""
+3428,"@@ -129,6 +129,9 @@ public class SPRequestHandler {
+
+     private void handleError(String error) {
+         SalesforceSDKLogger.e(TAG, ""Error received from IDP app: "" + error);
++        if (authCallback != null) {
++            authCallback.receivedErrorResponse(error);
++        }
+     }
+
+     private void handleSuccess(String code, String loginUrl) {",Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`.
+3429,"@@ -3,6 +3,7 @@ var assert = require('assert');
+ var Transform = require('stream').Transform;
+ const MongoError = require('../../lib/core').MongoError;
+ var MongoNetworkError = require('../../lib/core').MongoNetworkError;
++var mongoErrorContextSymbol = require('../../lib/core').mongoErrorContextSymbol;
+ var setupDatabase = require('./shared').setupDatabase;
+ var delay = require('./shared').delay;
+ var co = require('co');",I thought we got rid of this thing?
+3430,"@@ -83,15 +83,8 @@ class TaintNodeData
+     public $column_to;
+
+     /**
+-     * @param string $label
+-     * @param string $entry_path_type
+-     * @param ?string $entry_path_description
+      * @param int $line_from
+      * @param int $line_to
+-     * @param string $file_name
+-     * @param string $file_path
+-     * @param string $snippet
+-     * @param string $selected_text
+      * @param int $from
+      * @param int $to
+      * @param int $snippet_from",Please convert int params as well.
+3431,"@@ -84,7 +84,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                 var lastComponent = components.Last();
+                 messageLines.Add(
+                     string.Format(
+-                        CultureInfo.InvariantCulture, ""{0}:{1} {2} {3}: {4}"",
++                        CultureInfo.InvariantCulture, ""{0}{1}: {2} {3}: {4}"",
+                         lastComponent.Uri.AbsolutePath,
+                         lastComponent.Region.FormatForVisualStudio(),
+                         result.Kind.FormatForVisualStudio(),","Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue."
+3432,"@@ -230,6 +230,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+
++        /// <summary>
++        /// Configuration key for the application's servers http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpServerErrorStatuses""/>
++        public const string HttpServerErrors = ""DD_HTTP_SERVER_ERROR_STATUSES"";
++
++        /// <summary>
++        /// Configuration key for the application's client http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpClientErrorStatuses""/>
++        public const string HttpClientErrors = ""DD_HTTP_CLIENT_ERROR_STATUSES"";
++
+         /// <summary>
+         /// String format patterns used to match integration-specific configuration keys.
+         /// </summary>","Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer ""codes"" over ""statuses"", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)"
+3433,"@@ -134,8 +134,17 @@ struct flb_systemd_config *flb_systemd_config_create(struct flb_input_instance *
+         sd_journal_add_disjunction(ctx->j);
+     }
+
+-    /* Always seek to head */
+-    sd_journal_seek_head(ctx->j);
++    /* Seek to head by default or tail if specified in configuration */
++    tmp = flb_input_get_property(""read_from_tail"", i_ins);
++    if (tmp && strcasecmp(tmp, ""true"") == 0) {
++        sd_journal_seek_tail(ctx->j);
++
++        /* Skip last entry */
++        sd_journal_next_skip(ctx->j, 1);
++    }
++    else {
++        sd_journal_seek_head(ctx->j);
++    }
+
+     /* Check if we have a cursor in our database */
+     if (ctx->db) {","would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff."
+3434,"@@ -178,7 +178,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                                 analyzeOptions.Verbose,
+                                 targets,
+                                 analyzeOptions.ComputeTargetsHash,
+-                                Prerelease)),
++                                Prerelease,
++                                null)),
+                     (ex) =>
+                     {
+                         Errors.LogExceptionCreatingLogFile(context, filePath, ex);","`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)"
+3435,"@@ -61,6 +61,10 @@ class BaseDetector(nn.Module):
+         """"""
+         pass
+
++    @abstractmethod
++    async def async_test(self, img, img_meta, **kwargs):
++        pass
++
+     @abstractmethod
+     def simple_test(self, img, img_meta, **kwargs):
+         pass",maybe renamed to `async_simple_test` if we consider supporting aug test later on?
+3436,"@@ -113,7 +113,7 @@ module Mongoid #:nodoc:
+     # @return [ Document ] A new document.
+     def initialize(attrs = nil)
+       @new_record = true
+-      @attributes = default_attributes
++      @attributes = apply_default_attributes
+       process(attrs) do |document|
+         yield self if block_given?
+         identify","So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?"
+3437,"@@ -42,9 +42,9 @@ namespace OpenTelemetry.Metrics.Aggregators
+         {
+             return new DoubleSumData
+             {
+-                StartTimestamp = new DateTime(this.GetLastStartTimestamp().Ticks),
++                StartTimestamp = new DateTime(this.GetLastStartTimestamp().Ticks, DateTimeKind.Utc),
+                 Sum = this.checkPoint,
+-                Timestamp = new DateTime(this.GetLastEndTimestamp().Ticks),
++                Timestamp = new DateTime(this.GetLastEndTimestamp().Ticks, DateTimeKind.Utc),
+             };
+         }
+ ",We could move this to the base class and remove all these changes. What do you think?
+3438,"@@ -13,6 +13,7 @@ feature ""subscriber requests access to beta trail"" do
+
+     click_on ""Request Access""
+
++    expect(page).to have_content(I18n.t(""beta.replies.flashes.success""))
+     expect(page).not_to have_content(""Exciting Beta Trail"")
+   end
+ end","While we're doing some translation work, could you extract this button text and the other static text from the view?"
+3439,"@@ -181,6 +181,12 @@ public class JobCallbackUtil {
+         String headersKeyPerSequence =
+             headersKey.replace(SEQUENCE_TOKEN, sequenceStr);
+         String headersValue = props.get(headersKeyPerSequence);
++
++		// replace all the tokens in the header
++		if(headersValue != null)  {
++			headersValue = replaceTokens(headersValue, contextInfo, false);
++		}
++
+         privateLogger.info(""headers: "" + headersValue);
+         Header[] headers = parseHttpHeaders(headersValue);
+         if (headers != null) {",Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs).
+3440,"@@ -60,7 +60,7 @@ module.exports = {
+         TestCase.assertEqual(defaultRealm.schemaVersion, 0);
+
+         TestCase.assertThrows(function() {
+-            new Realm({schemaVersion: 1});
++            new Realm({schemaVersion: 1, schema: []});
+         }, ""Realm already opened at a different schema version"");
+
+         TestCase.assertEqual(new Realm().schemaVersion, 0);",This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent.
+3441,"@@ -2712,6 +2712,7 @@ dr_get_os_version(dr_os_version_info_t *info)
+     get_os_version_ex(&ver, &sp_major, &sp_minor);
+     if (info->size > offsetof(dr_os_version_info_t, version)) {
+         switch (ver) {
++        case WINDOWS_VERSION_10_1803: info->version = DR_WINDOWS_VERSION_10_1803; break;
+         case WINDOWS_VERSION_10_1709: info->version = DR_WINDOWS_VERSION_10_1709; break;
+         case WINDOWS_VERSION_10_1703: info->version = DR_WINDOWS_VERSION_10_1703; break;
+         case WINDOWS_VERSION_10_1607: info->version = DR_WINDOWS_VERSION_10_1607; break;","The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version."
+3442,"@@ -0,0 +1,6 @@
++var aria = 'aria-hidden';
++if (node && node.hasAttribute(aria)) {
++	return false;
++}
++
++return true;",Just do: `return node.hasAttribute('aria-hidden')`
+3443,"@@ -10,6 +10,18 @@ describe ""Saved Searches"" do
+     click_link 'Saved Searches'
+     expect(page).to have_content 'You have no saved searches'
+   end
++
++  it 'can be saved and forgotten from a search result' do
++    visit catalog_index_path(q: 'book')
++    within '.search-widgets' do
++      click_button 'save'
++    end
++    expect(page).to have_content 'Successfully saved your search.'
++    within '.search-widgets' do
++      click_button 'forget'
++    end
++    expect(page).to have_content 'Successfully removed that saved search.'
++  end
+
+   describe ""with a saved search 'book'"" do
+     before do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+3444,"@@ -9,7 +9,10 @@ namespace Datadog.Trace.Util
+     internal static class DomainMetadata
+     {
+         private const string UnknownName = ""unknown"";
+-        private static Process _currentProcess;
++        private static bool _initialized;
++        private static string _currentProcessName;
++        private static string _currentProcessMachineName;
++        private static int _currentProcessId;
+         private static bool _processDataPoisoned;
+         private static bool _domainDataPoisoned;
+         private static bool? _isAppInsightsAppDomain;",Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?
+3445,"@@ -114,10 +114,17 @@ func run(ctx context.Context, cfg cmds.Agent, proxy proxy.Proxy) error {
+ 			return err
+ 		}
+ 	}
++
++	notifySocket := os.Getenv(""NOTIFY_SOCKET"")
++	os.Unsetenv(""NOTIFY_SOCKET"")
++
+ 	if err := setupTunnelAndRunAgent(ctx, nodeConfig, cfg, proxy); err != nil {
+ 		return err
+ 	}
+
++	os.Setenv(""NOTIFY_SOCKET"", notifySocket)
++	systemd.SdNotify(true, ""READY=1\n"")
++
+ 	coreClient, err := coreClient(nodeConfig.AgentConfig.KubeConfigKubelet)
+ 	if err != nil {
+ 		return err",Did it not work out to wait until after containerd and kubelet are started?
+3446,"@@ -159,6 +159,10 @@ const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes
+ 	{""elementenergy"", ITEM_PARSE_ELEMENTENERGY},
+ 	{""elementdeath"", ITEM_PARSE_ELEMENTDEATH},
+ 	{""elementholy"", ITEM_PARSE_ELEMENTHOLY},
++	{""cooldownreduction"", ITEM_PARSE_COOLDOWNREDUCTION},
++	{""increasedamage"", ITEM_PARSE_INCREASEDAMAGE},
++	{""increasehealing"", ITEM_PARSE_INCREASEHEALING},
++	{""increasemanaget"", ITEM_PARSE_INCREASEMANAGAIN},
+ 	{""walkstack"", ITEM_PARSE_WALKSTACK},
+ 	{""blocking"", ITEM_PARSE_BLOCKING},
+ 	{""allowdistread"", ITEM_PARSE_ALLOWDISTREAD},","variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, ""damage boost +x%"" - healingboost, ITEM_PARSE_HEALINGBOOST, ""healing power +y%"" - managainboost, ITEM_PARSE_MANAGAINBOOST, ""mana restoration +z%"" alternatively the other names can stay, because ""increase"" convention isn't that bad, just change mana values to: - ""increasemanarestored"", ITEM_PARSE_INCREASEMANARESTORED, ""mana restoration +z%"""
+3447,"@@ -24,6 +24,7 @@ CREATE_TABLE = """"""
+         `complete_time` datetime DEFAULT NULL,
+         `status` enum('SUCCESS','RUNNING','FAILURE',
+                       'PARTIAL_SUCCESS','TIMEOUT') DEFAULT NULL,
++        `has_all_data` bool DEFAULT NULL,
+         `schema_version` varchar(255) DEFAULT NULL,
+         `cycle_timestamp` varchar(255) DEFAULT NULL,
+          PRIMARY KEY (`id`),",Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?
+3448,"@@ -35,11 +35,15 @@ final class IdGenerator implements GeneratorInterface
+
+     public function generatePath(MediaInterface $media): string
+     {
+-        $mediaId = (int) $media->getId();
++        $id = $media->getId();
+
+-        $rep_first_level = (int) ($mediaId / $this->firstLevel);
+-        $rep_second_level = (int) (($mediaId - ($rep_first_level * $this->firstLevel)) / $this->secondLevel);
++        if (!is_numeric($id)) {
++            return '';
++        }
+
+-        return sprintf('%s/%04s/%02s', $media->getContext(), $rep_first_level + 1, $rep_second_level + 1);
++        $repFirstLevel = (int) ($id / $this->firstLevel);
++        $repSecondLevel = (int) (($id - ($repFirstLevel * $this->firstLevel)) / $this->secondLevel);
++
++        return sprintf('%s/%04s/%02s', $media->getContext() ?? '', $repFirstLevel + 1, $repSecondLevel + 1);
+     }
+ }","Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?"
+3449,"@@ -48,8 +48,16 @@ import javax.net.ssl.SSLSocketFactory;
+  */
+ public class SalesforceTLSSocketFactory extends SSLSocketFactory {
+
++    private static SalesforceTLSSocketFactory INSTANCE;
+     private SSLSocketFactory ssLSocketFactory;
+
++    public static SalesforceTLSSocketFactory getInstance() throws KeyManagementException, NoSuchAlgorithmException {
++        if (INSTANCE == null) {
++            INSTANCE = new SalesforceTLSSocketFactory();
++        }
++        return INSTANCE;
++    }
++
+     public SalesforceTLSSocketFactory() throws KeyManagementException, NoSuchAlgorithmException {
+         final SSLContext context = SSLContext.getInstance(""TLS"");
+         context.init(null, null, null);",This should be made private.
+3450,"@@ -267,6 +267,7 @@ func (a *Agent) bootstrap() error {
+ 			BaseSVID:       a.BaseSVID,
+ 			BaseSVIDKey:    a.baseSVIDKey,
+ 			BaseRegEntries: regEntries,
++			BaseSVIDPath:   a.getBaseSVIDPath(),
+ 			Logger:         a.config.Log,
+ 		}
+ ",perhaps this is better modeled as a pkg-level var?
+3451,"@@ -86,6 +86,10 @@
+ #include ""CmpMain.h""
+
+ #define MAX_NODE_NAME 9
++#define MAX_PRECISION_ALLOWED  18
++#define HIVE_MAX_PRECISION_ALLOWED  38
++#define MAX_SCALE_ALLOWED     6
++#define MAX_NUM_LEN     16
+
+ #include ""SqlParserGlobals.h""
+ ","I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds."
+3452,"@@ -775,6 +775,14 @@ func (a *FakeWebAPI) GetProject(ctx context.Context, req *webservice.GetProjectR
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }
+
++func (a *FakeWebAPI) UpdateProjectStaticUser(ctx context.Context, req *webservice.UpdateProjectStaticUserRequest) (*webservice.UpdateProjectStaticUserResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *FakeWebAPI) UpdateProjectSingleSignOn(ctx context.Context, req *webservice.UpdateProjectSingleSignOnRequest) (*webservice.UpdateProjectSingleSignOnResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
+ func (a *FakeWebAPI) GetMe(ctx context.Context, req *webservice.GetMeRequest) (*webservice.GetMeResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`ctx` is unused in UpdateProjectStaticUser
+3453,"@@ -35,4 +35,10 @@ public class JSTypeNameGenerator extends TypeNameGenerator {
+   public String getStringFormatExample(String format) {
+     return getStringFormatExample(format, ""Date.toISOString()"", ""Date.toISOString()"");
+   }
++
++  @Override
++  public String getDiscoveryDocUrl(String apiName, String apiVersion) {
++    return String.format(
++        ""https://content.googleapis.com/discovery/v1/apis/%s/%s/rest"", apiName, apiVersion);
++  }
+ }","Why is this not the default, and why only for JS?"
+3454,"@@ -0,0 +1,7 @@
++class ProjectBadge < ActiveRecord::Base
++  belongs_to :project
++  belongs_to :repository
++
++  validates :url, presence: true
++  validates :repository_id, presence: true, uniqueness: { scope: :project_id }
++end",A repository has many badges so we should also add type column in scope.
+3455,"@@ -82,7 +82,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+             });
+
+             Assert.AreEqual(1, result.CodeFlows.Count);
+-            result.CodeFlows[0].Should().Equal(new[]
++            result.CodeFlows.First().Locations.ToArray().Should().Equal(new[]
+                     {
+                         new AnnotatedCodeLocation {
+                             PhysicalLocation = new PhysicalLocation {","Now a hash set, so can't index into it."
+3456,"@@ -273,6 +273,11 @@ module Bolt
+         !!File::ALT_SEPARATOR
+       end
+
++      # Returns true if running in PowerShell.
++      def powershell?
++        !!ENV['PSModulePath']
++      end
++
+       # Accept hash and return hash with top level keys of type ""String"" converted to symbols.
+       def symbolize_top_level_keys(hsh)
+         hsh.each_with_object({}) { |(k, v), h| k.is_a?(String) ? h[k.to_sym] = v : h[k] = v }",@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?
+3457,"@@ -63,7 +63,7 @@ public class BodyProcessorCreator implements ParamValueProcessorCreator {
+       }
+
+       String contentType = request.getContentType();
+-      if (contentType != null && !contentType.startsWith(MediaType.APPLICATION_JSON)) {
++      if (contentType != null && !contentType.toLowerCase().startsWith(MediaType.APPLICATION_JSON)) {
+         // TODO: we should consider body encoding
+         return IOUtils.toString(inputStream, ""UTF-8"");
+       }",1.toLowerCase(Locale.US)? 2.where is accept bug fix?
+3458,"@@ -105,16 +105,9 @@ def test_execute_with_invalid_driver(
+ ):
+     _command_args['driver_name'] = 'ec3'
+
+-    with pytest.raises(SystemExit) as e:
++    with pytest.raises(KeyError):
+         _instance.execute()
+
+-    assert 1 == e.value.code
+-
+-    msg = (
+-        'The specified template directory ({template_dir})' ' does not exist'
+-    ).format(template_dir=_instance._resolve_template_dir('scenario/driver/ec3'))
+-    patched_logger_critical.assert_called_once_with(msg)
+-
+
+ def test_execute_with_custom_template(
+     temp_dir, custom_template_dir, custom_readme_content, _command_args",We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?
+3459,"@@ -90,6 +90,7 @@ namespace Nethermind.DataMarketplace.Core.Services
+         {
+             var txData = _abiEncoder.Encode(AbiEncodingStyle.IncludeSignature, ContractData.DepositAbiSig,
+                 deposit.Id.Bytes, deposit.Units, deposit.ExpiryTime);
++            var nonce = await _blockchainBridge.GetNonceAsync(onBehalfOf);
+             Transaction transaction = new Transaction
+             {
+                 Value = deposit.Value,",check Lukasz's fix with NonceReserving - is that not better?
+3460,"@@ -106,11 +106,8 @@ Blockly.FieldColour.prototype.setValue = function(colour) {
+   }
+   this.colour_ = colour;
+   if (this.sourceBlock_) {
+-    this.sourceBlock_.setColour(
+-      colour,
+-      this.sourceBlock_.getColourSecondary(),
+-      this.sourceBlock_.getColourTertiary()
+-    );
++    // Set the primary, secondary and tertiary colour to this value.
++    this.sourceBlock_.setColour(colour, colour, colour);
+   }
+ };
+ ",Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow.
+3461,"@@ -643,6 +643,8 @@ func (hd *HeaderDownload) SaveExternalAnnounce(hash common.Hash) {
+ }
+
+ func (hd *HeaderDownload) getLink(linkHash common.Hash) (*Link, bool) {
++	hd.lock.RLock()
++	defer hd.lock.RUnlock()
+ 	if link, ok := hd.links[linkHash]; ok {
+ 		return link, true
+ 	}","Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)"
+3462,"@@ -63,4 +63,9 @@ public class GermanKeyboard extends BaseKeyboard {
+     public String getSpaceKeyText(String aComposingText) {
+         return StringUtils.getStringByLocale(mContext, R.string.settings_language_german, getLocale());
+     }
++
++    @Override
++    public String[] getDomains(String... domains) {
++        return super.getDomains("".de"");
++    }
+ }","German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`."
+3463,"@@ -38,8 +38,6 @@ final class CompositeIndexer {
+         CacheBuilder.from(spec).<PartitionKeyToTraceId, Pair<Long>>build().asMap();
+     Indexer.Factory factory = new Indexer.Factory(session, indexTtl, sharedState);
+     this.indexers = ImmutableSet.of(
+-        factory.create(new InsertTraceIdByServiceName(bucketCount)),
+-        factory.create(new InsertTraceIdBySpanName()),
+         factory.create(new InsertTraceIdByAnnotation(bucketCount))
+     );
+   }","since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this"
+3464,"@@ -83,6 +83,10 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl {
+       ""/export/apps/azkaban/azkaban-exec-server/current/plugins/jobtypes"";
+   public static final String IMAGE = ""image"";
+   public static final String VERSION = ""version"";
++  public static final String NSCD_SOCKET_VOLUME_NAME = ""nscd-socket"";
++  public static final String NSCD_SOCKET_HOST_PATH = ""/var/run/nscd/socket"";
++  public static final String HOST_PATH_TYPE = ""Socket"";
++  public static final String NSCD_SOCKET_VOLUME_MOUNT_PATH = ""/var/run/nscd/socket"";
+
+   private final String namespace;
+   private final ApiClient client;","Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it."
+3465,"@@ -533,7 +533,12 @@ func (a *Account) EnableJetStream(limits *JetStreamAccountLimits) error {
+ 				s.Warnf(""  Error adding Stream %q to Template %q: %v"", cfg.Name, cfg.Template, err)
+ 			}
+ 		}
+-		mset, err := a.AddStream(&cfg.StreamConfig)
++		// TODO: We should not rely on the stream name.
++		// However, having a StreamConfig property, such as AllowNoSubject,
++		// was not accepted because it does not make sense outside of the
++		// MQTT use-case. So need to revisit this.
++		mqtt := cfg.StreamConfig.Name == mqttStreamName
++		mset, err := a.addStreamWithStore(&cfg.StreamConfig, nil, mqtt)
+ 		if err != nil {
+ 			s.Warnf(""  Error recreating Stream %q: %v"", cfg.Name, err)
+ 			continue",Could be a non-public field. `allowNoSubject`
+3466,"@@ -588,12 +588,12 @@ func (c *Client) execute(tid int, target *core.BuildTarget, command *pb.Command,
+ 	} else if target.IsTextFile {
+ 		return c.buildTextFile(target, command, digest)
+ 	}
+-	return c.reallyExecute(tid, target, command, digest, needStdout, isTest)
++	return c.reallyExecute(tid, target, command, digest, needStdout, isTest, (c.state.ForceRerun && isTest) || (!isTest && c.state.ForceRebuild))
+ }
+
+ // reallyExecute is like execute but after the initial cache check etc.
+ // The action & sources must have already been uploaded.
+-func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Command, digest *pb.Digest, needStdout, isTest bool) (*core.BuildMetadata, *pb.ActionResult, error) {
++func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Command, digest *pb.Digest, needStdout, isTest, skipCacheLookup bool) (*core.BuildMetadata, *pb.ActionResult, error) {
+ 	executing := false
+ 	updateProgress := func(metadata *pb.ExecuteOperationMetadata) {
+ 		if c.state.Config.Remote.DisplayURL != """" {",Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`)
+3467,"@@ -62,6 +62,12 @@ class Autocomplete
+         return array('results' => $this->processResults($paginator->getCurrentPageResults(), $backendConfig['entities'][$entity]));
+     }
+
++    /**
++     * @param array $entities
++     * @param array $targetEntityConfig
++     *
++     * @return array
++     */
+     private function processResults($entities, $targetEntityConfig)
+     {
+         $results = array();",what about adding typehints instead? I don't think we need to add docblocks for every private methods.
+3468,"@@ -76,6 +76,7 @@ func createVolumeBuilder(cStorVolumeReplica *apis.CStorVolumeReplica, fullVolNam
+ 	openebsTargetIP := ""io.openebs:targetip="" + cStorVolumeReplica.Spec.TargetIP
+
+ 	createVolAttr = append(createVolAttr, ""create"",
++		""-b"", ""4K"", ""-s"", ""-o"", ""compression=on"",
+ 		""-V"", cStorVolumeReplica.Spec.Capacity, fullVolName,
+ 		""-o"", openebsTargetIP, ""-o"", openebsVolname)
+ ","Is it fine to pass the ""-o compression=on"" in the middle instead of at the end ?"
+3469,"@@ -18,14 +18,18 @@ module Bolt
+     attr_reader :noop, :transports
+     attr_accessor :run_as
+
++    # FIXME: There must be a better way
++    # https://makandracards.com/makandra/36011-ruby-do-not-mix-optional-and-keyword-arguments
+     def initialize(concurrency = 1,
+                    analytics = Bolt::Analytics::NoopClient.new,
+                    noop = nil,
+-                   bundled_content: nil)
++                   bundled_content: nil,
++                   load_config: true)
+       @analytics = analytics
+       @bundled_content = bundled_content
+       @logger = Logging.logger[self]
+       @plan_logging = false
++      @load_config = load_config
+
+       @transports = Bolt::TRANSPORTS.each_with_object({}) do |(key, val), coll|
+         coll[key.to_s] = Concurrent::Delay.new do",Probably make them all keyword arguments.
+3470,"@@ -521,11 +521,7 @@ define([""loading"", ""appRouter"", ""layoutManager"", ""connectionManager"", ""cardBuild
+         renderDetails(page, item, apiClient, context);
+         renderTrackSelections(page, instance, item);
+
+-        if (dom.getWindowSize().innerWidth >= 1000) {
+-            backdrop.setBackdrops([item]);
+-        } else {
+-            backdrop.clear();
+-        }
++        backdrop.clear();
+
+         renderDetailPageBackdrop(page, item, apiClient);
+         var canPlay = reloadPlayButtons(page, item);",Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds.
+3471,"@@ -41,7 +41,7 @@ namespace AutoRest.Swagger.Validation
+         /// <summary>
+         /// The severity of this message (ie, debug/info/warning/error/fatal, etc)
+         /// </summary>
+-        public override Category Severity => Category.Error;
++        public override Category Severity => Category.Warning;
+
+         ///// <summary>
+         ///// Validates whether property names are camelCase in body parameters.",why are we turning this one into a Warning?
+3472,"@@ -631,7 +631,7 @@ public class GUI implements CPDListener {
+             int separatorPos = sourceId.lastIndexOf(File.separatorChar);
+             label = ""..."" + sourceId.substring(separatorPos);
+         } else {
+-            label = '(' + sourceIDs.size() + "" separate files)"";
++            label = '(' + String.valueOf(sourceIDs.size()) + "" separate files)"";
+         }
+
+         match.setLabel(label);",Wouldn't it be better to use double quotes for the opening parenthesis ?
+3473,"@@ -716,7 +716,7 @@ bool IOLoginData::savePlayer(Player* player)
+ 	if (!player->isOffline()) {
+ 		query << ""`onlinetime` = `onlinetime` + "" << (time(nullptr) - player->lastLoginSaved) << ',';
+ 	}
+-	query << ""`blessings` = "" << static_cast<uint32_t>(player->blessings);
++	query << ""`blessings` = "" << static_cast<uint32_t>(player->blessings.to_ulong());
+ 	query << "" WHERE `id` = "" << player->getGUID();
+
+ 	DBTransaction transaction;",Remove the cast
+3474,"@@ -1,4 +1,4 @@
+-// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
++// Copyright (c) 2016-2018 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");
+ // you may not use this file except in compliance with the License.",What criteria do we use to bump the copyright years? An update to the module?
+3475,"@@ -267,6 +267,7 @@ class Resize:
+                     interpolation='nearest',
+                     backend=self.backend)
+             results['gt_semantic_seg'] = gt_seg
++            results[key] = gt_seg
+
+     def __call__(self, results):
+         """"""Call function to resize images, bounding boxes, masks, semantic",should we rm line 269?
+3476,"@@ -68,7 +68,9 @@ class NVDASpyLib:
+
+ 	# callbacks for extension points
+ 	def _onNvdaStartupComplete(self):
+-		self._isNvdaStartupComplete = True
++		# Queue the setting of the completion variable,
++		# To ensure that NvDA's core loop has started running, and it has processed initial focus.
++		queueHandler.queueFunction(queueHandler.eventQueue, lambda: setattr(self, '_isNvdaStartupComplete', True))
+
+ 	def _onNvdaSpeech(self, speechSequence=None):
+ 		if not speechSequence:","Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect."
+3477,"@@ -25,6 +25,13 @@ FactoryGirl.define do
+         cart.save!
+       end
+
++      factory :cart_with_all_approvals_approved do
++        after :create do |cart|
++          cart.approvals.each {|a| a.update_attribute :status, 'approved'}
++          cart.update_attribute :status, 'approved'
++        end
++      end
++
+       factory :cart_with_approvals_and_items do
+         after :create do |cart|
+           cart.cart_items << FactoryGirl.create(:cart_item, cart_id: cart.id)",Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point.
+3478,"@@ -291,9 +291,13 @@ func (o *Outbound) callWithPeer(
+ 	if response.StatusCode >= 200 && response.StatusCode < 300 {
+ 		appHeaders := applicationHeaders.FromHTTPHeaders(
+ 			response.Header, transport.NewHeaders())
+-		appError := response.Header.Get(ApplicationStatusHeader) == ApplicationErrorStatus
++		appError := fromApplicationStatusValue(response.Header.Get(ApplicationStatusHeader))
++		acceptResponseError := fromAcceptValue(response.Header.Get(AcceptResponseErrorHeader))
+ 		return &transport.Response{
+-			Headers:          appHeaders,
++			Headers: appHeaders,
++			Features: transport.ResponseFeatures{
++				AcceptResponseError: acceptResponseError,
++			},
+ 			Body:             response.Body,
+ 			ApplicationError: appError,
+ 		}, nil","wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?"
+3479,"@@ -66,7 +66,9 @@ public class ProtoParserTest {
+     testDataLocator = TestDataLocator.create(GapicCodeGeneratorAnnotationsTest.class);
+     testDataLocator.addTestDataSource(CodegenTestUtil.class, ""testsrc/common"");
+
+-    model = CodegenTestUtil.readModel(testDataLocator, tempDir, protoFiles, new String[0]);
++    model =
++        CodegenTestUtil.readModel(
++            testDataLocator, tempDir, protoFiles, new String[] {""library.yaml""});
+
+     libraryProtoFile =
+         model",Adding in the service yaml `library.yaml` here.
+3480,"@@ -63,7 +63,7 @@ func (a BasicAuth) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error
+
+ 			// let upstream middleware (e.g. fastcgi and cgi) know about authenticated
+ 			// user; this replaces the request with a wrapped instance
+-			r = r.WithContext(context.WithValue(r.Context(),
++			*r = *r.WithContext(context.WithValue(r.Context(),
+ 				httpserver.RemoteUserCtxKey, username))
+ 		}
+ 	}",Why is this dereference needed?
+3481,"@@ -36,7 +36,8 @@ import (
+ // * `tlfNode` allows auto-creation of subdirectories representing
+ //   valid repository checkouts of the corresponding TLF, e.g.
+ //   `.kbfs_autogit/private/chris/dotfiles`.  It wraps child nodes in
+-//   two ways, as both a `readonlyNode` and a `repoNode`.
++//   two ways, as both a `readonlyNode` and a `repoNode`.  It allows
++//   repo directories to be removed via `RemoveDir`.
+ // * `repoNode` allow auto-clone and auto-pull of the corresponding
+ //   repository on its first access.  When the directory corresponding
+ //   to the node is read for the first time for this KBFS instance,",Might want to add that this only happens if you have write permissions to the folder.
+3482,"@@ -53,6 +53,12 @@ type Config struct {
+ 	// to use based on region.
+ 	EndpointResolver endpoints.Resolver
+
++	// EnforceShouldRetryCheck is used in the AfterRetryHandler to always call
++	// ShouldRetry. If this is set and ShouldRetry is called, then the request's
++	// Retryable field can be either nil or set. Proper handling of the Retryable
++	// field is important when setting this field.
++	EnforceShouldRetryCheck *bool
++
+ 	// The region to send requests to. This parameter is required and must
+ 	// be configured globally or on a per-client basis unless otherwise
+ 	// noted. A full list of regions is found in the ""Regions and Endpoints""",Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled.
+3483,"@@ -59,6 +59,6 @@ func Register(registry transport.Registry, service Service) {
+ 	proto := service.Protocol()
+ 	for method, h := range service.Handlers() {
+ 		handler := thriftHandler{Handler: h, Protocol: proto}
+-		registry.Register(procedureName(name, method), handler)
++		registry.Register("""", procedureName(name, method), handler)
+ 	}
+ }",assume the user will be able to register for a custom service name in future?
+3484,"@@ -27,7 +27,9 @@ using System.Threading.Tasks;
+ using JetBrains.Annotations;
+ using pwiz.Common.Collections;
+ using pwiz.Common.SystemUtil;
+-using pwiz.Skyline.Util;
++using pwiz.Skyline.Util;
++
++
+ // ReSharper disable InconsistentlySynchronizedField
+
+ namespace pwiz.Skyline.Controls.Graphs",The extra two empty lines seem unnecessary. Please review your diffs more carefully.
+3485,"@@ -28,7 +28,7 @@ type API interface {
+ 	LiveToken() TokenAPI
+ 	SideToken() TokenAPI
+ 	TestToken() TestTokenAPI
+-	OracleUSD() OracleAPI
++	OracleAPI
+ }
+
+ type ProfileRegistryAPI interface {",What the reason to embed the Oracle?
+3486,"@@ -53,6 +53,8 @@ Workshops::Application.routes.draw do
+     resources :purchases, only: :index
+   end
+
++  match 'pages/new-topics' => 'pages#show', id: 'new-topics'
++
+   match '/auth/:provider/callback', to: 'auth_callbacks#create'
+
+   match '/watch' => 'high_voltage/pages#show', as: :watch, id: 'watch'",Shouldn't this happen automatically with High Voltage?
+3487,"@@ -505,7 +505,7 @@ public class InitCodeTransformer {
+         InitValue initValue = initValueConfig.getResourceNameBindingValues().get(entityName);
+         switch (initValue.getType()) {
+           case Variable:
+-            entityValue = context.getNamer().localVarName(Name.from(initValue.getValue()));
++            entityValue = context.getNamer().varReference(Name.from(initValue.getValue()));
+             break;
+           case Random:
+             entityValue = context.getNamer().injectRandomStringGeneratorCode(initValue.getValue());",This is changed because we need `projectId` to be printed as `$projectId` in PHP.
+3488,"@@ -1,7 +1,7 @@
+ <div class=""row"">
+   <div class=""col-md-12"">
+     <h1>
+-      <%= _('Template History') %>
++      <%= templates.first.customization_of.present? ? _('Template Customisation History') : _('Template History') %>
+       <div class=""pull-right"">
+         <%= link_to _('View all templates'), referrer, class: ""btn btn-primary"" %>
+       </div>",This title change seems more accurate to me however not sure if this will confuse users.
+3489,"@@ -117,7 +117,8 @@ private
+     # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL
+     return nil if value =~ /^https?:\/\//
+
+-    if key == ""wikipedia""
++    # match wikipedia or xxxxx:wikipedia
++    if key =~ /^(?:.*:)*wikipedia$/
+       # This regex should match Wikipedia language codes, everything
+       # from de to zh-classical
+       if value =~ /^([a-z-]{2,12}):(.+)$/i","Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested"
+3490,"@@ -505,7 +505,13 @@ class RAMHandler(logging.Handler):
+             if record.levelno >= minlevel:
+                 lines.append(fmt(record))
+         return '\n'.join(lines)
+-
++
++    def change_log_capacity(self, capacity):
++        """"""
++        change log capacity according to user specifcation
++        """"""
++        ram_handler = RAMHandler(capacity=capacity)
++        self._data = collections.deque(self._data, maxlen=capacity)
+
+ class ColoredFormatter(logging.Formatter):
+ ",Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?
+3491,"@@ -25,7 +25,11 @@ void CreateEdgeIndexProcessor::process(const cpp2::CreateEdgeIndexReq& req) {
+     auto ret = getEdgeIndexID(space, indexName);
+     if (ret.ok()) {
+         LOG(ERROR) << ""Create Edge Index Failed: "" << indexName << "" have existed"";
+-        resp_.set_code(cpp2::ErrorCode::E_EXISTED);
++        if (req.get_if_not_exists()) {
++            resp_.set_code(cpp2::ErrorCode::SUCCEEDED);
++        } else {
++            resp_.set_code(cpp2::ErrorCode::E_EXISTED);
++        }
+         onFinished();
+         return;
+     }",Move the line 27 to line 31 is better?
+3492,"@@ -4704,6 +4704,11 @@ func (fbo *folderBranchOps) applyMDUpdatesLocked(ctx context.Context,
+ 				return err
+ 			}
+ 		}
++		if rmd.IsRekeySet() {
++			fbo.rekeyFSM.Event(NewRekeyRequestEvent())
++		} else {
++			fbo.rekeyFSM.Event(NewRekeyNotNeededEvent())
++		}
+ 		appliedRevs = append(appliedRevs, rmd)
+ 	}
+ 	if len(appliedRevs) > 0 {","In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it."
+3493,"@@ -66,12 +66,6 @@ RSpec.configure do |config|
+   # particularly slow.
+   config.profile_examples = 10
+
+-  # Run specs in random order to surface order dependencies. If you find an
+-  # order dependency and want to debug it, you can fix the order by providing
+-  # the seed, which is printed after each run.
+-  #     --seed 1234
+-  config.order = :random
+-
+   # Seed global randomization in this process using the `--seed` CLI option.
+   # Setting this allows you to use `--seed` to deterministically reproduce
+   # test failures related to randomization by passing the same `--seed` value","I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme."
+3494,"@@ -156,11 +156,15 @@ function isVisible(el, screenReader, recursed) {
+   }
+
+   // hidden from visual users
++  const elHeight = parseInt(style.getPropertyValue('height'));
+   if (
+     !screenReader &&
+     (isClipped(style) ||
+       style.getPropertyValue('opacity') === '0' ||
+-      (getScroll(el) && parseInt(style.getPropertyValue('height')) === 0))
++      (getScroll(el) && elHeight === 0) ||
++      (style.getPropertyValue('position') === 'absolute' &&
++        elHeight <= 1 &&
++        style.getPropertyValue('overflow') === 'hidden'))
+   ) {
+     return false;
+   }",Is there a reason you left this at 0?
+3495,"@@ -267,6 +267,11 @@ public final class RememberMeConfigurer<H extends HttpSecurityBuilder<H>>
+ 		validateInput();
+ 		String key = getKey();
+ 		RememberMeServices rememberMeServices = getRememberMeServices(http, key);
++		if (key == null) {
++			if (rememberMeServices instanceof AbstractRememberMeServices) {
++				key = ((AbstractRememberMeServices) rememberMeServices).getKey();
++			}
++		}
+ 		http.setSharedObject(RememberMeServices.class, rememberMeServices);
+ 		LogoutConfigurer<H> logoutConfigurer = http.getConfigurer(LogoutConfigurer.class);
+ 		if (logoutConfigurer != null && this.logoutHandler != null) {","The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`."
+3496,"@@ -88,11 +88,18 @@ namespace Datadog.Trace.ClrProfiler
+                 return null;
+             }
+
++            var commandType = command.GetType();
++            if (tracer.Settings.AdoNetExcludedTypes.Contains(commandType.FullName))
++            {
++                // AdoNet type disabled, don't create a scope, skip this trace
++                return null;
++            }
++
+             Scope scope = null;
+
+             try
+             {
+-                string dbType = GetDbType(command.GetType().Name);
++                string dbType = GetDbType(commandType.Name);
+
+                 if (dbType == null)
+                 {",NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path)
+3497,"@@ -18,6 +18,9 @@ package v1alpha1
+
+ import (
+ 	ndm ""github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1""
++
++	""strings""
++
+ 	errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/resource""",should rearrange so as to follow import ordering.
+3498,"@@ -65,7 +65,7 @@ func (s *validateOperationWorkflowModeStateSuite) TestCreateMode_UpdateCurrent()
+ 	stateToError := map[enumsspb.WorkflowExecutionState]bool{
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_CREATED:   false,
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING:   false,
+-		enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: true,
++		enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE:    true,
+ 	}
+ ",what is the use case for create workflow with completed state?
+3499,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....
+3500,"@@ -0,0 +1,15 @@
++#include <impl/Kokkos_Tools.hpp>
++
++int main(int argc, char* argv[]) {
++  Kokkos::Tools::initialize(argc, argv);
++  Kokkos::Tools::pushRegion(
++      ""The unanimous Declaration of the thirteen united States of America, ""
++      ""When in the Course of human events, it becomes necessary for one people ""
++      ""to dissolve the political bands which have connected them with another, ""
++      ""and to assume among the powers of the earth, the separate and equal ""
++      ""station to which the Laws of Nature and of Nature's God entitle them, a ""
++      ""decent respect to the opinions of mankind requires that they should ""
++      ""declare the causes which impel them to the separation."");
++  Kokkos::Tools::popRegion();
++  Kokkos::Tools::finalize();
++}",Missing the license
+3501,"@@ -210,11 +210,9 @@ func (p *ReplicationTaskProcessorImpl) eventLoop() {
+ 			))
+
+ 		case <-cleanupTimer.C:
+-			if p.config.EnableCleanupReplicationTask() {
+-				if err := p.cleanupReplicationTasks(); err != nil {
+-					p.logger.Error(""Failed to clean up replication messages."", tag.Error(err))
+-					p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupFailure)
+-				}
++			if err := p.cleanupReplicationTasks(); err != nil {
++				p.logger.Error(""Failed to clean up replication messages."", tag.Error(err))
++				p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupFailure)
+ 			}
+ 			cleanupTimer.Reset(backoff.JitDuration(
+ 				p.config.ReplicationTaskProcessorCleanupInterval(shardID),",Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?
+3502,"@@ -37,7 +37,6 @@
+         #include ""tbb/tbb.h""
+         #include <tbb/task_arena.h>
+         #include <tbb/task_scheduler_observer.h>
+-        #include <tbb/task_scheduler_init.h>
+         #include <tbb/parallel_reduce.h>
+         #include <tbb/blocked_range.h>
+         #include <tbb/tick_count.h>","Potentially it'll be good to remove all of them excluding ""tbb/tbb.h"" But let's do it next time  "
+3503,"@@ -1210,3 +1210,19 @@ def is_nan(x):
+         return np.isnan(x)
+     except:
+         return False
++
++
++def bound_range(vals, density):
++    """"""
++    Computes a bounding range from a number of evenly spaced samples.
++    Will raise an error if samples are not evenly spaced within
++    tolerance.
++    """"""
++    low, high = vals.min(), vals.max()
++    invert = False
++    if vals[0] > vals[1]:
++        invert = True
++    if not density:
++        density = round(1./((high-low)/(len(vals)-1)), sys.float_info.dig)
++    halfd = 0.5/density
++    return low-halfd, high+halfd, density, invert",I would just mention which tolerance - namely as reported by ``sys.float_info``
+3504,"@@ -18,8 +18,9 @@ class ProposalsController < ApplicationController
+
+   def index
+     @CLOSED_PROPOSAL_LIMIT = 10
++
+     @pending_data = self.listing.pending
+-    @approved_data = self.listing.approved(@CLOSED_PROPOSAL_LIMIT)
++    @approved_data = self.listing.approved.alter_query{ |rel| rel.limit(@CLOSED_PROPOSAL_LIMIT) }
+     @cancelled_data = self.listing.cancelled
+   end
+ ",:+1: Ideally this'll become something you could pass in to the config
+3505,"@@ -775,7 +775,7 @@ void RaftPart::replicateLogs(folly::EventBase* eb,
+             return resp.get_error_code() == cpp2::ErrorCode::SUCCEEDED
+                     && !hosts[index]->isLearner();
+         })
+-        .then(executor_.get(), [self = shared_from_this(),
++        .via(executor_.get()).then([self = shared_from_this(),
+                    eb,
+                    it = std::move(iter),
+                    currTerm,",Should using `thenValue` to replace `then` ?
+3506,"@@ -130,6 +130,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+
+         private void OnError(object sender, EventArgs eventArgs)
+         {
++            if (!Tracer.Instance.Settings.IsIntegrationEnabled(IntegrationName))
++            {
++                // integration disabled
++                return;
++            }
++
+             try
+             {
+                 if (!TryGetContext(sender, out var httpContext) || httpContext.Error == null ||",This follows the convention of each callback starting with the `IsIntegrationEnabled` check.
+3507,"@@ -26,11 +26,15 @@ namespace OpenTelemetry.Metrics
+         private long sumLong = 0;
+         private SumMetricLong sumMetricLong;
+         private DateTimeOffset startTimeExclusive;
++        private bool isDeltaValue;
++        private bool isMonotonicValue;
+
+-        internal SumMetricAggregatorLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair<string, object>[] attributes)
++        internal SumMetricAggregatorLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair<string, object>[] attributes, bool isDeltaValue, bool isMonotonicValue)
+         {
+             this.startTimeExclusive = startTimeExclusive;
+             this.sumMetricLong = new SumMetricLong(name, description, unit, meter, startTimeExclusive, attributes);
++            this.isDeltaValue = isDeltaValue;
++            this.isMonotonicValue = isMonotonicValue;
+         }
+
+         public void Update<T>(T value)","this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)"
+3508,"@@ -0,0 +1,12 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Transport
++{
++    public interface IConnectionHandler
++    {
++        IConnectionContext OnConnection(IConnectionInformation connectionInfo, IScheduler inputWriterScheduler, IScheduler outputReaderScheduler);
++    }
++}",Add the PipeFactory here
+3509,"@@ -23,15 +23,12 @@ import (
+ 	""github.com/pkg/errors""
+
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+-	""github.com/chaos-mesh/chaos-mesh/controllers/common""
+ )
+
+ type Delegate struct {
+ 	impl interface{}
+ }
+
+-var _ common.ChaosImpl = (*Delegate)(nil)
+-
+ func (i *Delegate) callAccordingToAction(action, methodName string, defaultPhase v1alpha1.Phase, args ...interface{}) (v1alpha1.Phase, error) {
+ 	implType := reflect.TypeOf(i.impl).Elem()
+ 	implVal := reflect.ValueOf(i.impl)",please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`
+3510,"@@ -97,4 +97,15 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> {
+    * @return this for method chaining
+    */
+   ExpireSnapshots executeWith(ExecutorService executorService);
++
++  /**
++   * Allows expiration of snapshots without any cleanup of underlying manifest or data files.
++   * <p>
++   * Allows control in removing data and manifest files which may be more efficiently removed using
++   * a distributed framework through the actions API.
++   *
++   * @param clean setting this to false will skip deleting expired manifests and files
++   * @return this for method chaining
++   */
++  ExpireSnapshots cleanExpiredFiles(boolean clean);
+ }",nit: is this added deliberately?
+3511,"@@ -8,6 +8,8 @@ class SiteControllerTest < ActionController::TestCase
+   def setup
+     Object.const_set(""ID_KEY"", client_applications(:oauth_web_app).key)
+     Object.const_set(""POTLATCH2_KEY"", client_applications(:oauth_web_app).key)
++
++    stub_request(:get, ""http://api.hostip.info/country.php?ip=0.0.0.0"")
+   end
+
+   ##",Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?
+3512,"@@ -495,6 +495,16 @@ function applyWriteConcern(target, sources, options) {
+   return target;
+ }
+
++/**
++ * Checks if a given value is a Promise
++ *
++ * @param {*} maybePromise
++ * @return true if the provided value is a Promise
++ */
++function isPromiseLike(maybePromise) {
++  return maybePromise && typeof maybePromise.then === 'function';
++}
++
+ exports.filterOptions = filterOptions;
+ exports.mergeOptions = mergeOptions;
+ exports.translateOptions = translateOptions;","we don't use this anymore, so we can delete it."
+3513,"@@ -283,6 +283,8 @@ func initTelemetry(genesis bookkeeping.Genesis, log logging.Logger, dataDirector
+ 			fmt.Fprintln(os.Stdout, ""error loading telemetry config"", err)
+ 			return
+ 		}
++		fmt.Fprintln(os.Stdout, ""algoh telemetry configured from file:"", telemetryConfig.FilePath)
++
+
+ 		// Apply telemetry override.
+ 		telemetryConfig.Enable = logging.TelemetryOverride(*telemetryOverride)","nit: change to ""Telemetry configuration loaded from '%s'"""
+3514,"@@ -182,7 +182,8 @@ func TestSerialiseBlockWitness(t *testing.T) {
+ 	if err := bwb.WriteTo(&b); err != nil {
+ 		t.Errorf(""Could not make block witness: %v"", err)
+ 	}
+-	expected := common.FromHex(""0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c75657300582023181a62d35fe01562158be610f84e047f99f5e74d896da21682d925964ece3a0601024704010402040304"")
++
++	expected := common.FromHex(""0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c756573005820858f70a4b1e6aa71a7edc574d2ca946495a038aa37ce13dc7b7ed15661a6ff2f0601024704010402040304"")
+ 	if !bytes.Equal(expected, b.Bytes()) {
+ 		t.Errorf(""Expected %x, got: %x"", expected, b.Bytes())
+ 	}",Why did this value change?
+3515,"@@ -23,6 +23,7 @@ import (
+ 	duckv1 ""knative.dev/pkg/apis/duck/v1""
+ 	""knative.dev/pkg/kmeta""
+
++	gcpduckv1alpha1 ""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1""
+ 	""github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1""
+ )
+ ",maybe `duckpubsubv1alpha1` ?
+3516,"@@ -327,6 +327,16 @@ class FirefoxProfile(object):
+                     rc.append(node.data)
+             return ''.join(rc).strip()
+
++        def parse_manifest_json(content):
++            """"""Extracts the details from the contents of a WebExtensions `manifest.json` file.""""""
++            manifest = json.loads(content)
++            return {
++                'id': manifest['applications']['gecko']['id'],
++                'version': manifest['version'],
++                'name': manifest['version'],
++                'unpack': False,
++            }
++
+         if not os.path.exists(addon_path):
+             raise IOError('Add-on path does not exist: %s' % addon_path)
+ ",The id is not mandatory for web extensions. Could you update this to support a web extension without an id?
+3517,"@@ -31,11 +31,6 @@ import (
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+ )
+
+-const (
+-	serviceName = ""pubsub.googleapis.com""
+-	methodName  = ""google.pubsub.v1.Publisher.CreateTopic""
+-)
+-
+ func CloudAuditLogsSourceWithTestImpl(t *testing.T, authConfig lib.AuthConfig) {
+ 	project := os.Getenv(lib.ProwProjectKey)
+ ","I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself."
+3518,"@@ -97,9 +97,11 @@ func (t *tty) recvtty(process *libcontainer.Process, socket *os.File) error {
+ 	// set raw mode to stdin and also handle interrupt
+ 	stdin, err := console.ConsoleFromFile(os.Stdin)
+ 	if err != nil {
++		epollConsole.Close()
+ 		return err
+ 	}
+ 	if err := stdin.SetRaw(); err != nil {
++		epollConsole.Close()
+ 		return fmt.Errorf(""failed to set the terminal from the stdin: %v"", err)
+ 	}
+ 	go handleInterrupt(stdin)",I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it.
+3519,"@@ -1048,6 +1048,12 @@ stats (config.stat_config),
+ vote_uniquer (block_uniquer),
+ startup_time (std::chrono::steady_clock::now ())
+ {
++	if (config.websocket_config.enabled)
++	{
++		websocket_server = std::make_shared<nano::websocket::listener> (*this, nano::tcp_endpoint (boost::asio::ip::address_v6::any (), config.websocket_config.port));
++		this->websocket_server->run ();
++	}
++
+ 	wallets.observer = [this](bool active) {
+ 		observers.wallet.notify (active);
+ 	};",The bind address should be configurable.
+3520,"@@ -68,6 +68,11 @@ class LocalRepository implements Repository {
+         return fetchCategories(categoryDirectories);
+     }
+
++    @Override
++    public void delete() {
++        // nothing to do
++    }
++
+     private List<CategoryDTO> fetchCategories(File[] categoryDirectories) {
+         final List<CategoryDTO> results = new ArrayList<>();
+ ",Maybe the empty `delete()` should be implemented as default in the interface.
+3521,"@@ -24,7 +24,7 @@ class HDF5OutputLayerTest : public ::testing::Test {
+  protected:
+   HDF5OutputLayerTest()
+       : output_file_name_(tmpnam(NULL)),
+-        input_file_name_(""src/caffe/test/test_data/sample_data.h5""),
++        input_file_name_(CMAKE_SOURCE_DIR  ""caffe/test/test_data/sample_data.h5""),
+         blob_data_(new Blob<Dtype>()),
+         blob_label_(new Blob<Dtype>()),
+         num_(5),",How to ensure CMAKE_SOURCE_DIR is set correctly?
+3522,"@@ -106,7 +106,7 @@ func (ws *workingSet) LoadOrCreateAccountState(addr string, init *big.Int) (*Acc
+ 	switch {
+ 	case errors.Cause(err) == ErrStateNotExist:
+ 		account := Account{
+-			Balance:      init,
++			Balance:      big.NewInt(0).SetBytes(init.Bytes()),
+ 			VotingWeight: big.NewInt(0),
+ 		}
+ 		ws.cachedStates[addrHash] = &account",safer to make a copy of incoming *big.Int
+3523,"@@ -19,6 +19,8 @@ import ""time""
+ const (
+ 	// ListContainersTimeout is the timeout for the ListContainers API.
+ 	ListContainersTimeout = 10 * time.Minute
++	// ListImagesTimeout is the timeout for the ListImages API
++	ListImagesTimeout = 10 * time.Minute
+ 	// LoadImageTimeout is the timeout for the LoadImage API. It's set
+ 	// to much lower value than pullImageTimeout as it involves loading
+ 	// image from either a file or STDIN",how did we choose this value? does this hold good for Windows too?
+3524,"@@ -0,0 +1,17 @@
++// +build nocriu
++
++package libcontainer
++
++import (
++	""errors""
++)
++
++var errNotEnabled = errors.New(""Checkpoint/restore not supported"")
++
++func (c *linuxContainer) Checkpoint(opts *CheckpointOpts) error {
++	return errNotEnabled
++}
++
++func (c *linuxContainer) Restore(process *Process, opts *CheckpointOpts) error {
++	return errNotEnabled
++}","To follow the other build tags, maybe we can call it `criu`?"
+3525,"@@ -20,9 +20,10 @@ module Bolt
+       log_destination: STDERR
+     }.freeze
+
+-    TRANSPORT_OPTIONS = %i[insecure password run_as sudo sudo_password key tty user].freeze
++    TRANSPORT_OPTIONS = %i[insecure password run_as sudo sudo_password key tty user connect_timeout].freeze
+
+     TRANSPORT_DEFAULTS = {
++      connect_timeout: 10,
+       insecure: false,
+       tty: false
+     }.freeze",Should we load this from the config file too?
+3526,"@@ -128,6 +128,12 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 		}
+
+ 		nextRecover := now.Add(*duration)
++		// TODO(at15): this should be validated in webhook instead of throwing error at runtime.
++		// User can give a cron with interval shorter than duration.
++		// Example:
++		//  duration: ""10s""
++		//  scheduler:
++		//    cron: ""@every 5s
+ 		if nextStart.Before(nextRecover) {
+ 			err := fmt.Errorf(""nextRecover shouldn't be later than nextStart"")
+ 			r.Log.Error(err, ""nextRecover is later than nextStart. Then recover can never be reached"",",Can you file an issue for this?
+3527,"@@ -122,7 +122,7 @@ class Connection extends EventEmitter {
+       if (issue.isTimeout) {
+         op.cb(
+           new MongoNetworkTimeoutError(`connection ${this.id} to ${this.address} timed out`, {
+-            beforeHandshake: !!this[kIsMaster]
++            beforeHandshake: this[kIsMaster] == null
+           })
+         );
+       } else if (issue.isClose) {",@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests
+3528,"@@ -51,6 +51,19 @@ module Bolt
+       end
+     end
+
++    def setup_inventory(inventory)
++      config = Bolt::Config.default
++      config.overwrite_transport_data(inventory['config']['transport'],
++                                      Bolt::Util.symbolize_top_level_keys(inventory['config']['transports']))
++
++      bolt_inventory = Bolt::Inventory.new(inventory['data'],
++                                           config,
++                                           Bolt::Util.symbolize_top_level_keys(inventory['target_hash']))
++
++      bolt_inventory.collect_groups
++      bolt_inventory
++    end
++
+     def compile_catalog(request)
+       pal_main = request['code_ast'] || request['code_string']
+       target = request['target']",This whole function feels messy. I don't have a better idea at the moment though.
+3529,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long
+3530,"@@ -0,0 +1,18 @@
++package mock
++
++import (
++	""context""
++
++	""github.com/influxdata/flux/dependencies/influxdb""
++)
++
++type MockProvider struct {
++	influxdb.UnimplementedProvider
++	WriterForFn func(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error)
++}
++
++var _ influxdb.Provider = &MockProvider{}
++
++func (m MockProvider) WriterFor(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error) {
++	return m.WriterForFn(ctx, conf)
++}",Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?
+3531,"@@ -187,10 +187,10 @@ function innerDiffNode(dom, vchildren, context, mountAll, absorb) {
+ 		min = 0,
+ 		len = originalChildren.length,
+ 		childrenLen = 0,
+-		vlen = vchildren && vchildren.length,
++		vlen = vchildren ? vchildren.length : 0,
+ 		j, c, vchild, child;
+
+-	if (len) {
++	if (len!==0) {
+ 		for (let i=0; i<len; i++) {
+ 			let child = originalChildren[i],
+ 				props = child[ATTR_KEY],","This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract."
+3532,"@@ -41,6 +41,7 @@ public class NutritionProductFragment extends BaseFragment implements CustomTabA
+     @BindView(R.id.listNutrientLevels) ListView lv;
+     @BindView(R.id.textServingSize) TextView serving;
+     @BindView(R.id.textCarbonFootprint) TextView carbonFootprint;
++    @BindView(R.id.txtNoDataString)TextView noTextString;
+     private CustomTabActivityHelper customTabActivityHelper;
+     private Uri nutritionScoreUri;
+ ",missing space before `TextView`
+3533,"@@ -616,6 +616,16 @@ Attr_ReadValue Item::readAttr(AttrTypes_t attr, PropStream& propStream)
+ 			break;
+ 		}
+
++		case ATTR_OPENCONTAINER: {
++			int32_t openContainer;
++			if (!propStream.read<int32_t>(openContainer)) {
++				return ATTR_READ_ERROR;
++			}
++
++			setIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER, openContainer);
++			break;
++		}
++
+ 		//these should be handled through derived classes
+ 		//If these are called then something has changed in the items.xml since the map was saved
+ 		//just read the values","so this attribute is used as u8 in code, but saves as int32? Why?"
+3534,"@@ -41,7 +41,7 @@ from nupic.encoders.random_distributed_scalar import RandomDistributedScalarEnco
+ # Map class to Cap'n Proto schema union attribute
+ _CLASS_ATTR_MAP = {
+   ScalarEncoder: ""scalarEncoder"",
+-  AdaptiveScalarEncoder: ""adaptivescalar"",
++  AdaptiveScalarEncoder: ""adaptiveScalarEncoder"",
+   DateEncoder: ""dateEncoder"",
+   LogEncoder: ""logEncoder"",
+   CategoryEncoder: ""categoryEncoder"",",can RDSE be added to the list? It has its capnp files.
+3535,"@@ -35,11 +35,11 @@ import (
+
+ // certificateToInjectableFunc converts a given certificate to the reconcile requests for the corresponding injectables
+ // (webhooks, api services, etc) that reference it.
+-type certificateToInjectableFunc func(log logr.Logger, cl client.Client, certName types.NamespacedName) []ctrl.Request
++type certificateToInjectableFunc func(log logr.Logger, cl client.Reader, certName types.NamespacedName) []ctrl.Request
+
+ // buildCertToInjectableFunc creates a certificateToInjectableFunc that maps from certificates to the given type of injectable.
+ func buildCertToInjectableFunc(listTyp runtime.Object, resourceName string) certificateToInjectableFunc {
+-	return func(log logr.Logger, cl client.Client, certName types.NamespacedName) []ctrl.Request {
++	return func(log logr.Logger, cl client.Reader, certName types.NamespacedName) []ctrl.Request {
+ 		log = log.WithValues(""type"", resourceName)
+ 		objs := listTyp.DeepCopyObject()
+ 		if err := cl.List(context.Background(), objs, client.MatchingFields{injectFromPath: certName.String()}); err != nil {","These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client."
+3536,"@@ -1495,6 +1495,7 @@ mangle_direct_call(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+     if (target == (app_pc)retaddr) {
+         LOG(THREAD, LOG_INTERP, 3, ""found call to next instruction "" PFX ""\n"", target);
+     } else {
++        /* XXX i#3307: necessary to instr_set_translation_mangling_epilogue? */
+         check_return_handle_call(dcontext, ilist, next_instr);
+     }
+     /* now do the normal thing for a call */","No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push."
+3537,"@@ -4,6 +4,7 @@
+
+ import flatbuffers
+ from flatbuffers.compat import import_numpy
++from tests.namespace_test.NamespaceC.TableInC import TableInC, TableInCT
+ np = import_numpy()
+
+ class SecondTableInA(object):",this is generated code.. these changes will need to be made in the code generator to have them stick.
+3538,"@@ -1,8 +1,9 @@
++/* global xit */
+ describe('hidden content', function () {
+ 	'use strict';
+
+-  var fixture = document.getElementById('fixture');
+-
++	var fixture = document.getElementById('fixture');
++	var shadowSupport = document.body && typeof document.body.attachShadow === 'function';
+ 	var checkContext = {
+ 		_data: null,
+ 		data: function (d) {",Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?
+3539,"@@ -9,6 +9,7 @@ const ignoreNsNotFound = shared.ignoreNsNotFound;
+ const loadSpecTests = require('../spec').loadSpecTests;
+ const chai = require('chai');
+ const expect = chai.expect;
++const runUnifiedTest = require('./unified-spec-runner/runner').runUnifiedTest;
+
+ describe('APM', function() {
+   before(function() {",Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way.
+3540,"@@ -577,7 +577,7 @@ SchemaString.prototype.$conditionalHandlers =
+       $gte: handleSingle,
+       $lt: handleSingle,
+       $lte: handleSingle,
+-      $options: handleSingle,
++      $options: String,
+       $regex: handleSingle,
+       $not: handleSingle
+     });","Why is this change necessary? `handleSingle()` will cast it to a string, no?"
+3541,"@@ -228,4 +228,13 @@ public interface Table {
+    * @return a {@link LocationProvider} to provide locations for new data files
+    */
+   LocationProvider locationProvider();
++
++  /**
++   * Return the name of this table.
++   *
++   * @return this table's name
++   */
++  default String name() {
++    return ""table("" + hashCode() + "")"";
++  }
+ }","This newly added method should be well defined, should it return `TableIdentifier` or just `String`?"
+3542,"@@ -18,7 +18,8 @@ use Ergonode\Core\Infrastructure\Model\RelationshipGroup;
+
+ class ProductMultimediaRelationshipStrategy implements RelationshipStrategyInterface
+ {
+-    private const MESSAGE = 'Object has active relationships with multimedia %relations%';
++    private const ONE_MESSAGE = 'Multimedia has a relation with product';
++    private const MULTIPLE_MESSAGE = 'Multimedia has %count% relations with some products';
+
+     private ProductQueryInterface $productQuery;
+ ",have a relation with a product
+3543,"@@ -129,8 +129,11 @@ var _ = Describe(""health tests"", func() {
+
+ 		AfterEach(func() {
+ 			for _, name := range podsToCleanUp {
+-				err := k8sInfra.K8sClient.CoreV1().Pods(""default"").Delete(name, &metav1.DeleteOptions{})
+-				Expect(err).NotTo(HaveOccurred())
++				// It is possible for a local pod to be deleted by GC if node is gone.
++				if k8sInfra.PodExist(""default"", name) {
++					err := k8sInfra.K8sClient.CoreV1().Pods(""default"").Delete(name, &metav1.DeleteOptions{})
++					Expect(err).NotTo(HaveOccurred())
++				}
+ 			}
+ 			podsToCleanUp = nil
+ 		})","I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says ""pod has already been deleted""?"
+3544,"@@ -65,13 +65,8 @@ class DbTaskHistory(task_history.TaskHistory):
+             yield session
+         else:
+             session = self.session_factory()
+-            try:
++            with session.transaction:
+                 yield session
+-            except:
+-                session.rollback()
+-                raise
+-            else:
+-                session.commit()
+
+     def __init__(self):
+         config = configuration.get_config()",SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer.
+3545,"@@ -88,11 +88,11 @@ func (q *actQueue) Overlaps(act *iproto.ActionPb) bool {
+ 	switch {
+ 	case act.GetTransfer() != nil:
+ 		tsf := &action.Transfer{}
+-		tsf.ConvertFromTransferPb(act.GetTransfer())
++		tsf.ConvertFromActionPb(act)
+ 		nonce = tsf.Nonce
+ 	case act.GetVote() != nil:
+ 		vote := &action.Vote{}
+-		vote.ConvertFromVotePb(act.GetVote())
++		vote.ConvertFromActionPb(act)
+ 		nonce = vote.Nonce
+ 	}
+ 	return q.items[nonce] != nil",This switch statement can be removed. Just return q.items[act.Nonce] != nil
+3546,"@@ -119,7 +119,7 @@ public class AvoidInstantiatingObjectsInLoopsRule extends AbstractJavaRule {
+                  */
+                 n = n.getParent();
+             } else if (n.getParent() instanceof ASTForStatement && n.getParent().getNumChildren() > 1
+-                    && n == n.getParent().getChild(1)) {
++                    && n.equals(n.getParent().getChild(1))) {
+                 // it is the second child of a ForStatement - which means
+                 // we are dealing with a for-each construct
+                 // In that case, we can ignore this allocation expression, as","I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations..."
+3547,"@@ -29,6 +29,9 @@ namespace ResultsComparer
+         [Option(""csv"", HelpText = ""Path to exported CSV results. Optional."")]
+         public FileInfo CsvPath { get; set; }
+
++        [Option('f', ""filter"", HelpText = ""Filter the benchmarks by name using glob pattern(s). Optional."")]
++        public IEnumerable<string> Filters { get; set; }
++
+         [Usage(ApplicationAlias = """")]
+         public static IEnumerable<Example> Examples
+         {",What's the scenario for passing multiple filters?
+3548,"@@ -201,9 +201,10 @@ bool Part::commitLogs(std::unique_ptr<LogIterator> iter) {
+     LogID lastId = -1;
+     TermID lastTerm = -1;
+     while (iter->valid()) {
+-        lastId = iter->logId();
+-        lastTerm = iter->logTerm();
+-        auto log = iter->logMsg();
++        auto logEntry = iter->logEntry();
++        lastId = std::get<0>(logEntry);
++        lastTerm = std::get<1>(logEntry);
++        auto log = std::get<3>(logEntry);
+         if (log.empty()) {
+             VLOG(3) << idStr_ << ""Skip the heartbeat!"";
+             ++(*iter);",move to after check log.empty()
+3549,"@@ -19,6 +19,7 @@
+ # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+
+ """""" Comments and reviews for records: web interface """"""
++from docutils.nodes import note
+
+ __lastupdated__ = """"""$Date$""""""
+ ",This line needs to be removed
+3550,"@@ -68,7 +68,7 @@ type CloudBuildSourceSpec struct {
+
+ const (
+ 	// CloudBuildSource CloudEvent type
+-	CloudBuildSourceEvent = ""com.google.cloud.build.event""
++	CloudBuildSourceEvent = ""google.cloud.cloudbuild.build.v1.statusChanged""
+ 	// CloudBuildSourceBuildId is the Pub/Sub message attribute key with the CloudBuildSource's buildId.
+ 	CloudBuildSourceBuildId = ""buildId""
+ 	// CloudBuildSourceBuildStatus is the Pub/Sub message attribute key with the CloudBuildSource's build status.",Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?
+3551,"@@ -0,0 +1,8 @@
++// Package vsphere contains vSphere-specific structures for installer
++// configuration and management.
++// +k8s:deepcopy-gen=package,register
++// +k8s:conversion-gen=github.com/openshift/hive/pkg/apis/hive
++package vsphere
++
++// Name is name for the vsphere platform.
++const Name string = ""vsphere""",This is unused.
+3552,"@@ -32,9 +32,13 @@ namespace OpenTelemetry.Instrumentation.Http
+         public bool SetHttpFlavor { get; set; }
+
+         /// <summary>
+-        /// Gets or sets <see cref=""ITextFormat""/> for context propagation. Default value: <see cref=""TraceContextFormat""/>.
++        /// Gets or sets <see cref=""ITextFormat""/> for context propagation. Default value: <see cref=""CompositePropagator""/>.
+         /// </summary>
+-        public ITextFormat TextFormat { get; set; } = new TraceContextFormat();
++        public ITextFormat TextFormat { get; set; } = new CompositePropagator(new System.Collections.Generic.List<ITextFormat>
++        {
++            new TraceContextFormat(),
++            new BaggageFormat(),
++        });
+
+         /// <summary>
+         /// Gets or sets an optional callback method for filtering <see cref=""HttpWebRequest""/> requests that are sent through the instrumentation.",Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?
+3553,"@@ -0,0 +1,8 @@
++class TwitterPlayerCardsController < ApplicationController
++  layout false
++
++  def show
++    response.headers.delete(""X-Frame-Options"")
++    @video = Video.find(params[:video_id])
++  end
++end",Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?
+3554,"@@ -138,6 +138,9 @@ func (u *staticUpstream) NewHost(host string) (*UpstreamHost, error) {
+ 				if uh.Unhealthy {
+ 					return true
+ 				}
++				if uh.Dynamic {
++					return false
++				}
+ 				if uh.Fails >= u.MaxFails &&
+ 					u.MaxFails != 0 {
+ 					return true",Backends with hostnames that depend on the request are always up?
+3555,"@@ -4,6 +4,8 @@ import functools
+ import colander
+ import venusian
+ import six
++from jsonpatch import JsonPatchException
++from jsonpointer import JsonPointerException
+ from pyramid import exceptions as pyramid_exceptions
+ from pyramid.decorator import reify
+ from pyramid.security import Everyone","I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation"
+3556,"@@ -11,10 +11,6 @@ module Travis
+   module Build
+     class Script
+       class Julia < Script
+-        DEFAULTS = {
+-          julia: 'release',
+-        }
+-
+         def export
+           super
+ ","make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?"
+3557,"@@ -20,7 +20,10 @@
+ //
+ // For secrets.OpenKeeper, azurekeyvault registers for the scheme ""azurekeyvault"".
+ // The default URL opener will use Dial, which gets default credentials from the
+-// environment.
++// environment, unless the AZURE_KEYVAULT_AUTH_VIA_CLI environment variable is
++// set to true, in which case it uses DialUsingCLIAuth to get credentials from the
++// ""az"" command line.
++//
+ // To customize the URL opener, or for more details on the URL format,
+ // see URLOpener.
+ // See https://gocloud.dev/concepts/urls/ for background information.","nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`."
+3558,"@@ -34,10 +34,10 @@ type Validator struct {
+ }
+
+ // NewValidator return Validator instance
+-func NewValidator(sessionManager session.Manager, extractor identity.Extractor) *Validator {
++func NewValidator(sessionStorage *session.Storage, extractor identity.Extractor) *Validator {
+ 	return &Validator{
+ 		clientMap: &clientMap{
+-			sessionManager:   sessionManager,
++			sessions:         sessionStorage,
+ 			sessionClientIDs: make(map[session.SessionID]int),
+ 			sessionMapLock:   sync.Mutex{},
+ 		},",Depend on interfaces not on structures
+3559,"@@ -180,7 +180,7 @@ void signalHandler(int sig) {
+     case SIGTERM:
+       FLOG_INFO(""Signal %d(%s) received, stopping this server"", sig, ::strsignal(sig));
+       if (gStorageServer) {
+-        gStorageServer->stop();
++        gStorageServer->notifyStop();
+       }
+       break;
+     default:","This fix looks good. My concern, don't forget to fix metad too!"
+3560,"@@ -196,13 +196,15 @@ func makeMDJournalWithIDJournal(
+ 	}
+
+ 	if earliest != nil {
+-		if earliest.BID() != latest.BID() {
++		if earliest.BID() != latest.BID() &&
++			!(earliest.BID() == NullBranchID &&
++				latest.BID() == LocalSquashBranchID) {
+ 			return nil, fmt.Errorf(
+ 				""earliest.BID=%s != latest.BID=%s"",
+ 				earliest.BID(), latest.BID())
+ 		}
+-		log.CDebugf(nil, ""Initializing with branch ID %s"", earliest.BID())
+-		journal.branchID = earliest.BID()
++		log.CDebugf(nil, ""Initializing with branch ID %s"", latest.BID())
++		journal.branchID = latest.BID()
+ 	}
+
+ 	return &journal, nil","Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?"
+3561,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?
+3562,"@@ -50,6 +50,11 @@ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {
+
++// port use if the ros environment variable doesn't specified one
++const uint16_t DEFAULT_ROS2_SERVER_PORT = 11811;
++// default server guidPrefix
++const char* DEFAULT_ROS2_SERVER_GUIDPREFIX = ""44.49.53.43.53.45.52.56.45.52.5F.30"";
++
+ GUID_t RemoteServerAttributes::GetParticipant() const
+ {
+     return GUID_t(guidPrefix, c_EntityId_RTPSParticipant);",Again use of `constexpr` is recomended.
+3563,"@@ -8,6 +8,12 @@ from ..core.operation import Operation
+ from .chart import Points
+ from .path import Path
+
++try:
++    from datashader.layout import LayoutAlgorithm as ds_layout
++except:
++    ds_layout = None
++
++
+ class graph_redim(redim):
+     """"""
+     Extension for the redim utility that allows re-dimensioning",Minor point but I would call this ``redim_graph`` instead.
+3564,"@@ -26,12 +26,14 @@ import (
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/schema""
+-	""k8s.io/klog""
++	""k8s.io/utils/pointer""
+ 	infrav1 ""sigs.k8s.io/cluster-api-provider-aws/pkg/apis/infrastructure/v1alpha2""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/scope""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/ec2""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/elb""
++	""sigs.k8s.io/cluster-api/pkg/apis/cluster/common""
+ 	clusterv1 ""sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha2""
++	""sigs.k8s.io/cluster-api/pkg/controller/noderefutil""
+ 	capierrors ""sigs.k8s.io/cluster-api/pkg/errors""
+ 	""sigs.k8s.io/cluster-api/pkg/util""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""","As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above"
+3565,"@@ -40,15 +40,11 @@ func (service *servicePFCtl) Add(rule RuleForwarding) {
+ func (service *servicePFCtl) Start() error {
+ 	err := service.ipForward.Enable()
+ 	if err != nil {
+-		return err
++		log.Warn(natLogPrefix, ""Failed to enable IP forwarding: "", err)
+ 	}
+
+ 	service.clearStaleRules()
+-	err = service.enableRules()
+-	if err != nil {
+-		return err
+-	}
+-	return nil
++	return service.enableRules()
+ }
+
+ func (service *servicePFCtl) Stop() {","Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`"
+3566,"@@ -256,6 +256,9 @@ OpenStreetMap::Application.routes.draw do
+   # directions
+   get ""/directions"" => ""directions#search""
+
++  # set home location
++  match ""/set_home_loc"" => ""user#set_home_location"", :via => [:get, :post]
++
+   # export
+   post ""/export/finish"" => ""export#finish""
+   get ""/export/embed"" => ""export#embed""","Whatever the decision is about the request type to use, this should only match what is needed and not the other one."
+3567,"@@ -1025,7 +1025,9 @@ Blockly.BlockSvg.prototype.handleDragFree_ = function(oldXY, newXY, e) {
+   }
+
+   var updatePreviews = true;
+-  if (Blockly.localConnection_ && Blockly.highlightedConnection_) {
++  if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {
++    updatePreviews = true; // Always update previews for output connections.
++  } else if (Blockly.localConnection_ && Blockly.highlightedConnection_) {
+     var xDiff = Blockly.localConnection_.x_ + dxy.x -
+         Blockly.highlightedConnection_.x_;
+     var yDiff = Blockly.localConnection_.y_ + dxy.y -","...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too."
+3568,"@@ -70,8 +70,7 @@ class BigqueryRulesEngine(bre.BaseRulesEngine):
+         self.rule_book = BigqueryRuleBook(self._load_rule_definitions())
+
+     # TODO: The naming is confusing and needs to be fixed in all scanners.
+-    def find_policy_violations(self, parent_project, bq_acl,
+-                               force_rebuild=False):
++    def find_violations(self, parent_project, bq_acl, force_rebuild=False):
+         """"""Determine whether Big Query datasets violate rules.
+
+         Args:","Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?"
+3569,"@@ -1667,6 +1667,13 @@ void ErrorTest() {
+   TestError(""enum X:byte { Y, Y }"", ""value already"");
+   TestError(""enum X:byte { Y=2, Z=2 }"", ""unique"");
+   TestError(""table X { Y:int; } table X {"", ""datatype already"");
++  TestError(""table X { A:bool; } table Y { } union X {"",
++            ""enum clashes with datatype"");
++  TestError(""union X { X, Y } table X {"", ""datatype clashes with enum"");
++  TestError(""namespace A; table X { } namespace A; union X {"",
++            ""enum clashes with datatype"");
++  TestError(""namespace A; union X { } namespace A; table X {"",
++            ""datatype clashes with enum"");
+   TestError(""struct X (force_align: 7) { Y:int; }"", ""force_align"");
+   TestError(""struct X {}"", ""size 0"");
+   TestError(""{}"", ""no root"");",This seems like an incomplete schema definition. will that have any effect on the tests?
+3570,"@@ -22,7 +22,10 @@ DatasetLoader::DatasetLoader(const Config& io_config, const PredictFunction& pre
+   label_idx_ = 0;
+   weight_idx_ = NO_SPECIFIC;
+   group_idx_ = NO_SPECIFIC;
+-  SetHeader(filename);
++  if (filename != nullptr && CheckCanLoadFromBin(filename) == """") {
++    // SetHeader should only be called when loading from text file
++    SetHeader(filename);
++  }
+   store_raw_ = false;
+   if (io_config.linear_tree) {
+     store_raw_ = true;","The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == """"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == """") { ... }`"
+3571,"@@ -148,8 +148,7 @@ func (m *BackgroundProcessManager) StartProcess(cmd *ManagedProcess) (*process.P
+ 	go func() {
+ 		err := cmd.Wait()
+ 		if err != nil {
+-			err, ok := err.(*exec.ExitError)
+-			if ok {
++			if err, ok := err.(*exec.ExitError); ok {
+ 				status := err.Sys().(syscall.WaitStatus)
+ 				if status.Signaled() && status.Signal() == syscall.SIGTERM {
+ 					log.Info(""process stopped with SIGTERM signal"")","I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch"
+3572,"@@ -145,6 +145,18 @@ folly::Future<StatusOr<std::vector<SpaceIdName>>> MetaClient::listSpaces() {
+                 });
+ }
+
++
++folly::Future<StatusOr<bool>> MetaClient::dropSpace(std::string name) {
++    cpp2::DropSpaceReq req;
++    req.set_space_name(std::move(name));
++    return getResponse(std::move(req), [] (auto client, auto request) {
++                    return client->future_dropSpace(request);
++                }, [] (cpp2::ExecResp&& resp) -> bool {
++                    return resp.code == cpp2::ErrorCode::SUCCEEDED;
++                });
++}
++
++
+ folly::Future<StatusOr<bool>> MetaClient::addHosts(const std::vector<HostAddr>& hosts) {
+     std::vector<nebula::cpp2::HostAddr> thriftHosts;
+     thriftHosts.resize(hosts.size());",`Status` has identical semantics with `StatusOr<bool>`.
+3573,"@@ -75,6 +75,7 @@ var allowedPaths = []string{
+ 	""/readyz"",
+ 	""/mutate/acnp"",
+ 	""/mutate/anp"",
++	""/mutate/addlabels"",
+ 	""/validate/tier"",
+ 	""/validate/acnp"",
+ 	""/validate/anp"",",why is this named in a different style from other paths?
+3574,"@@ -73,13 +73,13 @@ func (r *AWSClusterReconciler) Reconcile(req ctrl.Request) (_ ctrl.Result, reter
+ 		return reconcile.Result{}, err
+ 	}
+
+-	if isPaused(cluster, awsCluster) {
+-		log.Info(""AWSCluster or linked Cluster is marked as paused. Won't reconcile"")
++	if cluster == nil {
++		log.Info(""Cluster Controller has not yet set OwnerRef"")
+ 		return reconcile.Result{}, nil
+ 	}
+
+-	if cluster == nil {
+-		log.Info(""Cluster Controller has not yet set OwnerRef"")
++	if util.IsPaused(cluster, awsCluster) {
++		log.Info(""AWSCluster or linked Cluster is marked as paused. Won't reconcile"")
+ 		return reconcile.Result{}, nil
+ 	}
+ ",Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused
+3575,"@@ -25,13 +25,18 @@ import (
+ 	api ""google.golang.org/api/compute/v1""
+ )
+
++type platformPkgManagerTuple struct {
++	platform   string
++	pkgManager string
++}
++
+ const (
+ 	packageInstalledString    = ""package is installed""
+ 	packageNotInstalledString = ""package is not installed""
+ )
+
+ var (
+-	pkgManagers = []string{""apt"", ""yum""}
++	tuples = []platformPkgManagerTuple{{""debian"", ""apt""}, {""centos"", ""yum""}, {""rhel"", ""yum""}}
+ )
+
+ // vf is the the vertificationFunction that is used in each testSetup during assertion of test case.","I don't see pkgManager used anywhere, is there a reason we need this?"
+3576,"@@ -182,7 +182,7 @@ public class CoreDescriptor {
+    */
+   public CoreDescriptor(String name, Path instanceDir, Map<String, String> coreProps,
+                         Properties containerProperties, ZkController zkController) {
+-    this.instanceDir = instanceDir;
++    this.instanceDir = instanceDir.toAbsolutePath();
+
+     originalCoreProperties.setProperty(CORE_NAME, name);
+ ","A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory."
+3577,"@@ -4188,7 +4188,8 @@ function getModelsMapForPopulate(model, docs, options) {
+       foreignField = foreignField.call(doc);
+     }
+
+-    const localFieldPath = modelSchema.paths[localField];
++    const localFieldPathType = modelSchema._getPathType(localField);
++    const localFieldPath = localFieldPathType === 'real' ? modelSchema.paths[localField] : localFieldPathType.schema;
+     const localFieldGetters = localFieldPath ? localFieldPath.getters : [];
+     let ret;
+ ",There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array.
+3578,"@@ -56,7 +56,13 @@ class User < ActiveRecord::Base
+
+   scope :search, -> (term) {
+     search_pattern = ""%#{term}%""
+-    where(""firstname LIKE ? OR surname LIKE ? OR email LIKE ?"", search_pattern, search_pattern, search_pattern)
++    # MySQL does not support standard string concatenation and since concat_ws or concat functions do
++    # not exist for sqlite, we have to come up with this conditional
++    if ActiveRecord::Base.connection.adapter_name == ""Mysql2""
++      where(""concat_ws(' ', firstname, surname) LIKE ? OR email LIKE ?"", search_pattern, search_pattern)
++    else
++      where(""firstname || ' ' || surname LIKE ? OR email LIKE ?"", search_pattern, search_pattern)
++    end
+   }
+
+   # EVALUATE CLASS AND INSTANCE METHODS BELOW",Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though
+3579,"@@ -5,11 +5,12 @@
+ package ens
+
+ import (
++	""bytes""
+ 	""errors""
+ 	""fmt""
+ 	""strings""
+
+-	""github.com/ethereum/go-ethereum/accounts/abi/bind""
++	""github.com/ethereum/go-ethereum/common""
+ 	""github.com/ethereum/go-ethereum/ethclient""
+ 	goens ""github.com/wealdtech/go-ens/v3""
+ ","NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address."
+3580,"@@ -26,6 +26,7 @@ Upcase::Application.routes.draw do
+   draw :teams
+   draw :trails
+   draw :users
++  draw :vanity
+   draw :videos
+
+   root to: ""homes#show""",I'm curious why you are using `draw` in this route file?
+3581,"@@ -195,7 +195,18 @@ func Diff(ctx *context.Context) {
+ }
+
+ func RawDiff(ctx *context.Context) {
+-	panic(""not implemented"")
++	userName := ctx.Repo.Owner.Name
++	repoName := ctx.Repo.Repository.Name
++	commitID := ctx.Params("":sha"")
++	diffType := ctx.Params("":ext"")
++
++	diff, err := models.GetRawDiff(models.RepoPath(userName, repoName),
++		commitID, diffType)
++	if err != nil {
++		ctx.Handle(404, ""GetRawDiff"", err)
++		return
++	}
++	ctx.HandleText(200, diff)
+ }
+
+ func CompareDiff(ctx *context.Context) {","Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly."
+3582,"@@ -3,7 +3,7 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
+-#if NET461 || NET452
++#if NET461
+
+ using System;
+ using System.Linq;",I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point
+3583,"@@ -21,6 +21,8 @@ import (
+ // Compatible with Okta offline access, a holdover from previous defaults.
+ var defaultScopes = []string{oidc.ScopeOpenID, oidc.ScopeOfflineAccess, ""email""}
+
++const clutchProviderName = ""clutch""
++
+ type OIDCProvider struct {
+ 	provider *oidc.Provider
+ 	verifier *oidc.IDTokenVerifier","to fix the docs build failure, make this const var named without the suffix `Name`"
+3584,"@@ -682,6 +682,7 @@ func checkClientTLSCertSubject(c *client, fn tlsMapAuthFn) bool {
+ 				return true
+ 			}
+ 		}
++		fallthrough
+ 	case hasURIs:
+ 		for _, u := range cert.URIs {
+ 			if match, ok := fn(u.String(), nil); ok {","This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted."
+3585,"@@ -0,0 +1,15 @@
++package com.fsck.k9.service;
++
++
++import java.io.File;
++import java.io.IOException;
++
++import android.net.Uri;
++
++
++public interface FileProviderInterface {
++
++    File createProvidedFile() throws IOException;
++    Uri getUriForProvidedFile(File file, String mimeType) throws IOException;
++
++}",Same here. Feels like the wrong location.
+3586,"@@ -42,7 +42,9 @@ from qutebrowser.keyinput import modeman
+ from qutebrowser.utils import (message, usertypes, log, qtutils, urlutils,
+                                objreg, utils)
+ from qutebrowser.utils.usertypes import KeyMode
+-from qutebrowser.misc import editor, guiprocess
++from qutebrowser.misc import editor, guiprocess, mhtml
++from qutebrowser.browser.downloads import (_path_suggestion as
++                                           download_path_suggestion)
+
+
+ class CommandDispatcher:",Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`.
+3587,"@@ -40,6 +40,8 @@ func init() {
+ 	flag.StringVar(&revoke, ""revoke"", """", ""Hostname for which to revoke the certificate"")
+ 	flag.StringVar(&serverType, ""type"", ""http"", ""Type of server to run"")
+ 	flag.BoolVar(&version, ""version"", false, ""Show version"")
++	flag.StringVar(&caddytls.HTTPChallengePort, ""external-port-80-is-local-port"", ""80"", ""Local port exposed externally as port 80"")
++	flag.StringVar(&caddytls.TLSSNIChallengePort, ""external-port-443-is-local-port"", ""443"", ""Local port exposed externally as port 443"")
+
+ 	caddy.RegisterCaddyfileLoader(""flag"", caddy.LoaderFunc(confLoader))
+ 	caddy.SetDefaultCaddyfileLoader(""default"", caddy.LoaderFunc(defaultLoader))","Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)"
+3588,"@@ -19,6 +19,14 @@ module Blacklight
+         end
+       end
+     end
++
++    initializer ""blacklight.secret_key"" do |app|
++      if app.respond_to?(:secrets)
++        Blacklight.secret_key ||= app.secrets.secret_key_base
++      elsif app.config.respond_to?(:secret_key_base)
++        Blacklight.secret_key ||= app.config.secret_key_base
++      end
++    end
+
+   end
+-end
++end","Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?"
+3589,"@@ -390,6 +390,9 @@ public:
+     m_nopayload_elems_bitmask =
+         enum_impl_strategy.getBitMaskForNoPayloadElements();
+
++    if (enum_decl->isObjC())
++      m_is_objc_enum = true;
++
+     LOG_PRINTF(LIBLLDB_LOG_TYPES, ""m_nopayload_elems_bitmask = %s"",
+                Dump(m_nopayload_elems_bitmask).c_str());
+ ",Does this not apply to C enums on Linux?
+3590,"@@ -511,7 +511,11 @@ function makeOperationHandler(server, connection, cmd, options, callback) {
+           session.serverSession.isDirty = true;
+         }
+
+-        if (supportsRetryableWrites(server) && !inActiveTransaction(session, cmd)) {
++        if (
++          isRetryableWriteError(err) &&
++          supportsRetryableWrites(server) &&
++          !inActiveTransaction(session, cmd)
++        ) {
+           err.addErrorLabel('RetryableWriteError');
+         }
+ ",Should this check if the error is `RetryableWriteError` before adding the label?
+3591,"@@ -1,6 +1,8 @@
+ const Plugin = require('../core/Plugin')
+ const { findDOMElement } = require('../core/Utils')
+-const getFormData = require('get-form-data').default
++// Rollup uses get-form-data's ES modules build, and rollup-plugin-commonjs automatically resolves `.default`.
++// So, if we are being built using rollup, this require() won't have a `.default` property.
++const getFormData = require('get-form-data').default || require('get-form-data')
+
+ /**
+  * Form","Oh wow, that's one complicated require :)"
+3592,"@@ -1,6 +1,6 @@
+ // snippet-comment:[These are tags for the AWS doc team's sample catalog. Do not remove.]
+ // snippet-sourceauthor:[Doug-AWS]
+-// snippet-sourcedescription:[Using context.Context with SDK requests.]
++// snippet-sourcedescription:[request_context.go shows how to usie context.Context with SDK requests.]
+ // snippet-keyword:[Extending the SDK]
+ // snippet-keyword:[Go]
+ // snippet-service:[aws-go-sdk]","do you mean how to ""use"""
+3593,"@@ -400,8 +400,9 @@ describe('forwardRef', () => {
+ 		const Transition = ({ children }) => {
+ 			const state = useState(0);
+ 			forceTransition = state[1];
+-			expect(children.ref).to.not.be.undefined;
+-			if (state[0] === 0) expect(children.props.ref).to.be.undefined;
++			// TODO: ref exists on the backing node
++			// expect(children.ref).to.not.be.undefined;
++			// if (state[0] === 0) expect(children.props.ref).to.be.undefined;
+ 			return children;
+ 		};
+ ",We can't really test this anymore since ref and props.ref are at the backing node level now
+3594,"@@ -56,6 +56,7 @@ abstract class BaseDataReader<T> implements Closeable {
+
+   private CloseableIterator<T> currentIterator;
+   private T current = null;
++  private FileScanTask currentTask = null;
+
+   BaseDataReader(CombinedScanTask task, FileIO io, EncryptionManager encryptionManager) {
+     this.tasks = task.files().iterator();",Did you intend to set this in the constructor?
+3595,"@@ -106,11 +106,15 @@ func (s *Service) createInstance(machine *actuators.MachineScope, bootstrapToken
+ 		Role:        aws.String(machine.Role()),
+ 	})
+
++	var err error
+ 	// Pick image from the machine configuration, or use a default one.
+ 	if machine.MachineConfig.AMI.ID != nil {
+ 		input.ImageID = *machine.MachineConfig.AMI.ID
+ 	} else {
+-		input.ImageID = s.defaultAMILookup(machine.Region())
++		input.ImageID, err = s.defaultAMILookup(""ubuntu"", ""18.04"", machine.Machine.Spec.Versions.Kubelet)
++		if err != nil {
++			return nil, err
++		}
+ 	}
+
+ 	// Pick subnet from the machine configuration, or default to the first private available.","This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?"
+3596,"@@ -1,5 +1,6 @@
++#ifdef USE_OPENCV
+ #include <opencv2/core/core.hpp>
+-
++#endif  // USE_OPENCV
+ #include <stdint.h>
+
+ #include <string>",This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure.
+3597,"@@ -30,7 +30,7 @@ func (r *ReconcileHiveConfig) deployHiveAPI(hLog log.FieldLogger, h *resource.He
+
+ 	err := util.ApplyAsset(h, ""config/apiserver/hiveapi-cluster-role-binding.yaml"", hLog)
+ 	if err != nil {
+-		return err
++		hLog.WithError(err).Error(""unable to apply hiveapi cluster role binding"")
+ 	}
+
+ 	err = util.ApplyAsset(h, ""config/apiserver/service.yaml"", hLog)",Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday.
+3598,"@@ -33,6 +33,7 @@ class Proposal < ActiveRecord::Base
+   has_many :steps
+   has_many :individual_steps, ->{ individual }, class_name: 'Steps::Individual'
+   has_many :approvers, through: :individual_steps, source: :user
++  has_many :completers, through: :individual_steps, source: :completer
+   has_many :api_tokens, through: :individual_steps
+   has_many :attachments, dependent: :destroy
+   has_many :approval_delegates, through: :approvers, source: :outgoing_delegations","I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days."
+3599,"@@ -11,7 +11,6 @@ namespace AutoRest.Swagger.Validation
+     public class OperationParametersValidation : TypedRule<SwaggerParameter>
+     {
+         private const string SubscriptionId = ""subscriptionid"";
+-        private const string ApiVersion = ""api-version"";
+
+         /// <summary>
+         /// Id of the Rule.",Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation.
+3600,"@@ -77,6 +77,8 @@ class Thelia extends Kernel
+         );
+         $serviceContainer = Propel::getServiceContainer();
+         $serviceContainer->setAdapterClass('thelia', 'mysql');
++        $serviceContainer->setDefaultDatasource('thelia');
++
+         $manager = new ConnectionManagerSingle();
+         $manager->setConfiguration($definePropel->getConfig());
+         $serviceContainer->setConnectionManager('thelia', $manager);","@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database."
+3601,"@@ -92,7 +92,9 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+             var controllerContext = (IHttpControllerContext)state.State;
+
+             // some fields aren't set till after execution, so populate anything missing
+-            AspNetWebApi2Integration.UpdateSpan(controllerContext, scope.Span, (AspNetTags)scope.Span.Tags, Enumerable.Empty<KeyValuePair<string, string>>());
++            var span = scope.Span as IHasTags;
++            var aspNetTags = span.Tags as AspNetTags;
++            AspNetWebApi2Integration.UpdateSpan(controllerContext, scope.Span, aspNetTags, Enumerable.Empty<KeyValuePair<string, string>>());
+
+             if (exception != null)
+             {",Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility.
+3602,"@@ -2,7 +2,8 @@ const request = require('request')
+ // @ts-ignore
+ const purest = require('purest')({ request })
+ const logger = require('../logger')
+-
++const DRIVE_FILE_FIELDS = 'kind,id,name,mimeType,ownedByMe,permissions(role,emailAddress),size,modifiedTime,iconLink,thumbnailLink'
++const DRIVE_FILES_FIELDS = `kind,nextPageToken,incompleteSearch,files(${DRIVE_FILE_FIELDS})`
+ /**
+  * @class
+  * @implements {Provider}",why do we need to explicitly declare these fields?
+3603,"@@ -99,12 +99,8 @@ class OaiController extends AbstractBase
+                 $this->getRequest()->getQuery()->toArray(),
+                 $this->getRequest()->getPost()->toArray()
+             );
+-            $server = new $serverClass(
+-                $this->serviceLocator->get('VuFind\Search\Results\PluginManager'),
+-                $this->serviceLocator->get('VuFind\Record\Loader'),
+-                $this->serviceLocator->get('VuFind\Db\Table\PluginManager'),
+-                $config, $baseURL, $params
+-            );
++            $server = $this->serviceLocator->get('VuFind\OAI\Server');
++            $server->init($config, $baseURL, $params);
+             $server->setRecordLinkHelper(
+                 $this->getViewRenderer()->plugin('recordLink')
+             );","Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\OAI\Server\Auth`. Should be easy enough since it can share the same factory."
+3604,"@@ -265,6 +265,12 @@ describe Beaker do
+   context ""validate_host"" do
+     subject { dummy_class.new }
+
++    before(:each) do
++      # Must reset additional_pkgs between each test as it hangs around
++      #Beaker::HostPrebuiltSteps.class_variable_set(:@@additional_pkgs, [])
++      Beaker::HostPrebuiltSteps.module_eval(%q{@@additional_pkgs = []})
++    end
++
+     it ""can validate unix hosts"" do
+
+       hosts.each do |host|",This is no longer needed and should be removed.
+3605,"@@ -57,8 +57,12 @@ func ParseFlags(ctx *cli.Context) service.Options {
+ }
+
+ // ParseJSONOptions function fills in Openvpn options from JSON request
+-func ParseJSONOptions(request json.RawMessage) (service.Options, error) {
++func ParseJSONOptions(request *json.RawMessage) (service.Options, error) {
++	if request == nil {
++		return Options{}, nil
++	}
++
+ 	var opts Options
+-	err := json.Unmarshal(request, &opts)
++	err := json.Unmarshal(*request, &opts)
+ 	return opts, err
+ }","could use named return params here to avoid declaring the opts, and using naked returns instead."
+3606,"@@ -84,6 +84,11 @@ module.exports = class Instagram extends Plugin {
+   }
+
+   getItemIcon (item) {
++    if (!item.images) {
++      return <svg viewBox=""0 0 58 58"" opacity=""0.6"">
++        <path d=""M36.537 28.156l-11-7a1.005 1.005 0 0 0-1.02-.033C24.2 21.3 24 21.635 24 22v14a1 1 0 0 0 1.537.844l11-7a1.002 1.002 0 0 0 0-1.688zM26 34.18V23.82L34.137 29 26 34.18z"" /><path d=""M57 6H1a1 1 0 0 0-1 1v44a1 1 0 0 0 1 1h56a1 1 0 0 0 1-1V7a1 1 0 0 0-1-1zM10 28H2v-9h8v9zm-8 2h8v9H2v-9zm10 10V8h34v42H12V40zm44-12h-8v-9h8v9zm-8 2h8v9h-8v-9zm8-22v9h-8V8h8zM2 8h8v9H2V8zm0 42v-9h8v9H2zm54 0h-8v-9h8v9z"" />
++      </svg>
++    }
+     return <img src={item.images.thumbnail.url} />
+   }
+ ","this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case."
+3607,"@@ -58,12 +58,14 @@ type syncChainSelector interface {
+ 	// IsHeaver returns true if tipset a is heavier than tipset b and false if
+ 	// tipset b is heavier than tipset a.
+ 	IsHeavier(ctx context.Context, a, b types.TipSet, aStateID, bStateID cid.Cid) (bool, error)
++	// NewWeight returns the weight of a tipset
++	NewWeight(ctx context.Context, ts types.TipSet, stRoot cid.Cid) (uint64, error)
+ }
+
+ type syncStateEvaluator interface {
+ 	// RunStateTransition returns the state root CID resulting from applying the input ts to the
+ 	// prior `stateRoot`.  It returns an error if the transition is invalid.
+-	RunStateTransition(ctx context.Context, ts types.TipSet, tsMessages [][]*types.SignedMessage, tsReceipts [][]*types.MessageReceipt, ancestors []types.TipSet, stateID cid.Cid) (cid.Cid, error)
++	RunStateTransition(ctx context.Context, ts types.TipSet, tsMessages [][]*types.SignedMessage, tsReceipts [][]*types.MessageReceipt, ancestors []types.TipSet, parentWeight uint64, stateID cid.Cid) (cid.Cid, error)
+ }
+
+ // Syncer updates its chain.Store according to the methods of its","""... after protocol version 1""?"
+3608,"@@ -32,7 +32,7 @@ from scapy.compat import (
+ _mib_re_integer = re.compile(r""^[0-9]+$"")
+ _mib_re_both = re.compile(r""^([a-zA-Z_][a-zA-Z0-9_-]*)\(([0-9]+)\)$"")
+ _mib_re_oiddecl = re.compile(
+-    r""$\s*([a-zA-Z0-9_-]+)\s+OBJECT([^:\{\}]|\{[^:]+\})+::=\s*\{([^\}]+)\}"", re.M)
++    r""$\s*([a-zA-Z0-9_-]+)\s+OBJECT[^:\{\}]+::=\s*\{([^\}]+)\}"", re.M)
+ _mib_re_strings = re.compile(r'""[^""]*""')
+ _mib_re_comments = re.compile(r'--.*(\r|\n)')
+ ",Is there a unit test that covers this regexp? I am afraid that changing it might break things =/
+3609,"@@ -57,7 +57,7 @@ public class RubyNameFormatter implements NameFormatter {
+
+   @Override
+   public String varReference(Name name) {
+-    return ""@"" + name.toLowerUnderscore();
++    return name.toLowerUnderscore();
+   }
+
+   @Override","This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers."
+3610,"@@ -27,9 +27,9 @@ class PaymentImageUploadCest
+         $me->amOnPage('/admin/payment/edit/1');
+         $entityEditPage->uploadTestImage(self::IMAGE_UPLOAD_FIELD_ID, self::TEST_IMAGE_NAME);
+         $me->clickByName(self::SAVE_BUTTON_NAME);
+-        $me->seeTranslationAdmin('Payment <strong><a href=""{{ url }}"">%name%</a></strong> modified', 'messages', [
++        $me->seeTranslationAdmin('Payment <strong><a href=""{{ url }}"">{{ name }}</a></strong> modified', 'messages', [
+             '{{ url }}' => '',
+-            '%name%' => t('Credit card', [], 'dataFixtures', $me->getAdminLocale()),
++            '{{ name }}' => t('Credit card', [], 'dataFixtures', $me->getAdminLocale()),
+         ]);
+     }
+ }",Why this change was needed? Because in `po` files it's with curly braces?
+3611,"@@ -370,14 +370,14 @@ patch_branch(dr_isa_mode_t isa_mode, cache_pc branch_pc, cache_pc target_pc,
+     ASSERT(ALIGNED(branch_pc, 4) && ALIGNED(target_pc, 4));
+     if ((enc & 0xfc000000) == 0x14000000) { /* B */
+         ASSERT(off + 0x8000000 < 0x10000000);
+-        *pc_writable = (0x14000000 | (0x03ffffff & off >> 2));
++        *pc_writable = (0x14000000 | (0x03ffffff & (off >> 2)));
+     } else if ((enc & 0xff000010) == 0x54000000 ||
+                (enc & 0x7e000000) == 0x34000000) { /* B.cond, CBNZ, CBZ */
+-        ASSERT(off + 0x40000 < 0x80000);
+-        *pc_writable = (enc & 0xff00001f) | (0x00ffffe0 & off >> 2 << 5);
++        ASSERT(off + 0x100000 < 0x200000);
++        *pc_writable = (enc & 0xff00001f) | (0x00ffffe0 & (off >> 2 << 5));
+     } else if ((enc & 0x7e000000) == 0x36000000) { /* TBNZ, TBZ */
+-        ASSERT(off + 0x2000 < 0x4000);
+-        *pc_writable = (enc & 0xfff8001f) | (0x0007ffe0 & off >> 2 << 5);
++        ASSERT(off + 0x8000 < 0x10000);
++        *pc_writable = (enc & 0xfff8001f) | (0x0007ffe0 & (off >> 2 << 5));
+     } else
+         ASSERT(false);
+     if (hot_patch)","Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review."
+3612,"@@ -0,0 +1,3 @@
++module.exports = {
++  presets: [require.resolve('@docusaurus/core/lib/babel/preset')],
++};",seems to be redundant (mention `docusaurus`   )
+3613,"@@ -206,6 +206,12 @@ public interface Table {
+    */
+   Rollback rollback();
+
++  /**
++   *
++   * @return
++   */
++  CherryPick cherrypick();
++
+   /**
+    * Create a new {@link Transaction transaction API} to commit multiple table operations at once.
+    *","Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?"
+3614,"@@ -52,7 +52,7 @@ static struct internal_amazon_batch_amazon_ids{
+ 	char* aws_secret_access_key;
+ 	char* aws_region;
+ 	char* aws_email;
+-	char* master_env_prefix;
++	char* manager_env_prefix;
+ }initialized_data;
+
+ static unsigned int gen_guid(){","Maybe just `env_prefix`, I don't think this is referring to the WQ manager."
+3615,"@@ -11,7 +11,6 @@ import android.widget.FrameLayout;
+
+ import com.bytehamster.lib.preferencesearch.SearchPreferenceResult;
+ import com.bytehamster.lib.preferencesearch.SearchPreferenceResultListener;
+-
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.core.preferences.UserPreferences;
+ import de.danoeh.antennapod.fragment.preferences.AutoDownloadPreferencesFragment;",Unrelated line change :)
+3616,"@@ -2,9 +2,13 @@ package net
+
+ import (
+ 	""strings""
++	""syscall""
++	""time""
+
+ 	""github.com/coreos/go-iptables/iptables""
+ 	""github.com/pkg/errors""
++	""github.com/sirupsen/logrus""
++	utilwait ""k8s.io/apimachinery/pkg/util/wait""
+ )
+
+ // AddChainWithRules creates a chain and appends given rules to it.","I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that."
+3617,"@@ -228,6 +228,9 @@
+         * @returns {string} encode string
+         */
+         countlyCommon.encodeSomeHtml = function(html, options) {
++            if (countlyGlobal.company) {
++                html.replace(""Countly"", countlyGlobal.company);
++            }
+             if (options) {
+                 return filterXSS(html, options);
+             }","I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string"
+3618,"@@ -207,7 +207,9 @@ function isNodeShuttingDownError(err) {
+  * @param {Server} server
+  */
+ function isSDAMUnrecoverableError(error, server) {
+-  if (error instanceof MongoParseError) {
++  // NOTE: null check is here for a strictly pre-CMAP world, a timeout or
++  //       close event are considered unrecoverable
++  if (error instanceof MongoParseError || error == null) {
+     return true;
+   }
+ ",ticket for the 4.0 epic?
+3619,"@@ -87,6 +87,10 @@ def main():
+     if cfg.get('cudnn_benchmark', False):
+         torch.backends.cudnn.benchmark = True
+     cfg.model.pretrained = None
++    if cfg.model.get('neck', False):
++        if cfg.model.neck.get('rfp_backbone', False):
++            if cfg.model.neck.rfp_backbone.get('pretrained', False):
++                cfg.model.neck.rfp_backbone.pretrained = None
+     cfg.data.test.test_mode = True
+
+     # init distributed env first, since logger depends on the dist info.","`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value."
+3620,"@@ -5,7 +5,7 @@ module Blacklight
+   module Facet
+
+     def facet_paginator field_config, display_facet
+-      Blacklight::Solr::FacetPaginator.new(display_facet.items,
++      blacklight_config.facet_paginator_class.new(display_facet.items,
+         sort: display_facet.sort,
+         offset: display_facet.offset,
+         limit: facet_limit_for(field_config.key))",Trailing whitespace detected.
+3621,"@@ -38,6 +38,7 @@ type TargetSpec struct {
+ 	AutoStackSize    *bool    `json:""automatic-stack-size""` // Determine stack size automatically at compile time.
+ 	DefaultStackSize uint64   `json:""default-stack-size""`   // Default stack size if the size couldn't be determined at compile time.
+ 	CFlags           []string `json:""cflags""`
++	CXXFlags         []string `json:""cxxflags""`
+ 	LDFlags          []string `json:""ldflags""`
+ 	LinkerScript     string   `json:""linkerscript""`
+ 	ExtraFiles       []string `json:""extra-files""`",I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file.
+3622,"@@ -352,12 +352,13 @@ instrument_annotation(dcontext_t *dcontext, IN OUT app_pc *start_pc,
+ #    endif
+
+     instr_init(dcontext, &scratch);
+-    TRY_EXCEPT(my_dcontext, { identify_annotation(dcontext, &layout, &scratch); },
+-               { /* EXCEPT */
+-                 LOG(THREAD, LOG_ANNOTATIONS, 2,
+-                     ""Failed to instrument annotation at "" PFX ""\n"", *start_pc);
+-                 /* layout.type is already ANNOTATION_TYPE_NONE */
+-               });
++    TRY_EXCEPT(
++        my_dcontext, { identify_annotation(dcontext, &layout, &scratch); },
++        { /* EXCEPT */
++          LOG(THREAD, LOG_ANNOTATIONS, 2, ""Failed to instrument annotation at "" PFX ""\n"",
++              *start_pc);
++          /* layout.type is already ANNOTATION_TYPE_NONE */
++        });
+     if (layout.type != ANNOTATION_TYPE_NONE) {
+         LOG(GLOBAL, LOG_ANNOTATIONS, 2,
+             ""Decoded %s annotation %s. Next pc now "" PFX "".\n"",","Update year range in Copyright notice, and elsewhere too."
+3623,"@@ -179,10 +179,10 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
+ // ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
+ // configuration for AWS
+ type ACMEIssuerDNS01ProviderRoute53 struct {
+-	AccessKeyID     string            `json:""accessKeyID""`
+-	SecretAccessKey SecretKeySelector `json:""secretAccessKeySecretRef""`
+-	HostedZoneID    string            `json:""hostedZoneID""`
+-	Region          string            `json:""region""`
++	AccessKeyIDRef     SecretKeySelector `json:""accessKeyIDSecretRef""`
++	SecretAccessKeyRef SecretKeySelector `json:""secretAccessKeySecretRef""`
++	HostedZoneID       string            `json:""hostedZoneID""`
++	Region             string            `json:""region""`
+ }
+
+ // ACMEIssuerDNS01ProviderAzureDNS is a structure containing the","Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?"
+3624,"@@ -36,7 +36,7 @@ class UsersController < ApplicationController
+   def save
+     @title = t ""users.new.title""
+
+-    if params[:decline]
++    if params[:decline] || !params[:read_tou] || params[:read_tou] == ""0""
+       if current_user
+         current_user.terms_seen = true
+ ","You don't actually need both tests here as ""truthiness"" means that `""0""` is false and hence the first test will be true..."
+3625,"@@ -39,7 +39,15 @@ feature 'User downgrades subscription', js: true do
+
+     click_button I18n.t('subscriptions.confirm_cancel')
+
+-    expect(page).to have_content ""Scheduled for cancellation on February 19, 2013""
+     expect(page).to have_content I18n.t('subscriptions.flashes.cancel.success')
++
++    click_link I18n.t('subscriptions.reject_refund')
++
++    expect(page).to have_content(
++      I18n.t(
++        'subscriptions.cancellation_scheduled_on',
++        date: 'February 19, 2013'
++      )
++    )
+   end
+ end",Everything else in here is using `I18n`. Should we do that here to be consistent?
+3626,"@@ -242,8 +242,8 @@ type Config struct {
+ 	PrometheusGoMetricsEnabled      bool   `config:""bool;true""`
+ 	PrometheusProcessMetricsEnabled bool   `config:""bool;true""`
+
+-	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;tcp:22,udp:68,tcp:179,tcp:2379,tcp:2380,tcp:5473,tcp:6443,tcp:6666,tcp:6667;die-on-fail""`
+-	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:5473,tcp:6443,tcp:6666,tcp:6667;die-on-fail""`
++	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;0.0.0.0/0:tcp:22,0.0.0.0/0:udp:68,0.0.0.0/0:tcp:179,0.0.0.0/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail""`
++	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;0.0.0.0/0:udp:53,0.0.0.0/0:udp:67,0.0.0.0/0:tcp:179,0.0.0.0/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail""`
+
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
+ 	NATPortRange       numorstring.Port   `config:""portrange;""`",What do you think about changing the ordering to be `<protocol>:<cidr>:<port>`? I think it matches the most with what we previously had so that it doesn't change too much for our users.
+3627,"@@ -442,9 +442,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule,
+       if (rootedAtAtom == -1) {
+         rootedAtAtom = std::rand() % mol.getNumAtoms();
+         // need to find an atom id between 0 and mol.getNumAtoms() exclusively
+-        PRECONDITION(rootedAtAtom < 0 || static_cast<unsigned int>(
+-                                             rootedAtAtom) < mol.getNumAtoms(),
+-                     ""rootedAtomAtom must be less than the number of atoms"");
++        PRECONDITION(
++            static_cast<unsigned int>(rootedAtAtom) < mol.getNumAtoms(),
++            ""rootedAtomAtom must be less than the number of atoms"");
+       }
+     }
+ ",I'm fairly sure this precondition is always true due to the mod (%)
+3628,"@@ -404,7 +404,7 @@ final class ReaderPool implements Closeable {
+   private boolean noDups() {
+     Set<String> seen = new HashSet<>();
+     for(SegmentCommitInfo info : readerMap.keySet()) {
+-      assert !seen.contains(info.info.name);
++      assert !seen.contains(info.info.name) : ""seen twice: "" + info.info.name ;
+       seen.add(info.info.name);
+     }
+     return true;","I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!"
+3629,"@@ -731,6 +731,8 @@ func loadConfigFromFile(configFile string) (c Local, err error) {
+ 	}
+
+ 	// Migrate in case defaults were changed
++	// If a config file does not have version, it is assumed to be zero.
++	// All fields listed in migrate() might be changed if an actual value matches to default value from a previous version.
+ 	c, err = migrate(c)
+ 	return
+ }",1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0.
+3630,"@@ -633,6 +633,14 @@ class Config
+         return $config;
+     }
+
++    /**
++     * Computes the hash to use for a cache folder from CLI flags and from the config file's xml contents
++     */
++    public function computeHash(): string
++    {
++        return sha1($this->hash . ':' . $this->level);
++    }
++
+     /**
+      * Creates a new config object from an XML string
+      * @param  string|null      $current_dir Current working directory, if different to $base_dir",I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?
+3631,"@@ -3077,14 +3077,12 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         2018-04-09 00:00:00  1
+         2018-04-12 01:00:00  4
+         """"""
+-        from databricks.koalas.indexes import DatetimeIndex
+-
+         axis = validate_axis(axis)
+
+         if axis != 0:
+             raise NotImplementedError(""between_time currently only works for axis=0"")
+
+-        if not isinstance(self.index, DatetimeIndex):
++        if not isinstance(self.index, ks.DatetimeIndex):
+             raise TypeError(""Index must be DatetimeIndex"")
+
+         kdf = self.copy()",Could you also update it in `at_time`?
+3632,"@@ -143,8 +143,9 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+       } catch (IOException ioe) {
+         LOG.warn(""Failed to get Hadoop Filesystem"", ioe);
+       }
++      Boolean localityFallback = LOCALITY_WHITELIST_FS.contains(scheme);
+       this.localityPreferred = options.get(""locality"").map(Boolean::parseBoolean)
+-          .orElse(LOCALITY_WHITELIST_FS.contains(scheme));
++          .orElse(localityFallback);
+     } else {
+       this.localityPreferred = false;
+     }",Because schema is non-final we can't just switch this to a lambda
+3633,"@@ -136,7 +136,7 @@ namespace NLog.Conditions
+             }
+             catch (Exception exception)
+             {
+-                if (exception.MustBeRethrown())
++                if (exception.MustBeRethrown(""While resolving function '{0}' follwing exception occured: {1}"", functionName, exception))
+                 {
+                     throw;
+                 }",proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes.
+3634,"@@ -41,9 +41,14 @@ public class InvocationStartProcessingEventListener implements EventListener {
+   public void process(Event data) {
+     InvocationStartProcessingEvent event = (InvocationStartProcessingEvent) data;
+     InvocationMonitor monitor = registryMonitor.getInvocationMonitor(event.getOperationName());
++    //TODO:current java chassis unable know invocation type before starting process,so all type WaitInQueue increment(-1) (decrement)
+     monitor.getWaitInQueue().increment(-1);
++    monitor.setInvocationMonitorType(event.getInvocationType());
+     if (InvocationType.PRODUCER.equals(event.getInvocationType())) {
+       monitor.getLifeTimeInQueue().update(event.getInQueueNanoTime());
++      monitor.getProducerCall().increment();
++    } else {
++      monitor.getConsumerCall().increment();
+     }
+   }
+ }",why? event.getInvocationType is not you want?
+3635,"@@ -29,6 +29,7 @@ import (
+ type Info struct {
+ 	ID                string   `json:""server_id""`
+ 	Version           string   `json:""version""`
++	GitHash           string   `json:""git_hash""`
+ 	GoVersion         string   `json:""go""`
+ 	Host              string   `json:""host""`
+ 	Port              int      `json:""port""`",nit: how about `GitSHA`?
+3636,"@@ -93,6 +93,7 @@ an example.
+ */
+
+ #define MAX_REMOTE_JOBS_DEFAULT 100
++#define FAIL_DIR ""makeflow.failed.%d""
+
+ static sig_atomic_t makeflow_abort_flag = 0;
+ static int makeflow_failed_flag = 0;","If you move the other functions, this should also be moved to `makeflow_gc.h`."
+3637,"@@ -55,8 +55,12 @@ def _send_listens_to_queue(listen_type, listens):
+     for listen in listens:
+         if listen_type == LISTEN_TYPE_PLAYING_NOW:
+             try:
+-                expire_time = listen[""track_metadata""][""additional_info""].get(""duration"",
+-                                    current_app.config['PLAYING_NOW_MAX_DURATION'])
++                if 'duration' in listen['track_metadata']['additional_info']:
++                    expire_time = listen['track_metadata']['additional_info']['duration']
++                elif 'duration_ms' in listen['track_metadata']['additional_info']:
++                    expire_time = listen['track_metadata']['additional_info']['duration_ms'] // 1000
++                else:
++                    expire_time = current_app.config['PLAYING_NOW_MAX_DURATION']
+                 redis_connection._redis.put_playing_now(listen['user_id'], listen, expire_time)
+             except Exception as e:
+                 current_app.logger.error(""Redis rpush playing_now write error: "" + str(e))","This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read."
+3638,"@@ -93,7 +93,9 @@ export function coerceToVNode(possibleVNode) {
+
+ 	// Clone vnode if it has already been used. ceviche/#57
+ 	if (possibleVNode._dom!=null) {
+-		return createVNode(possibleVNode.type, possibleVNode.props, possibleVNode.text, possibleVNode.key, null);
++		let vnode = createVNode(possibleVNode.type, possibleVNode.props, possibleVNode.text, possibleVNode.key, null);
++		vnode._dom = possibleVNode._dom;
++		return vnode;
+ 	}
+
+ 	return possibleVNode;",Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!)
+3639,"@@ -1964,6 +1964,8 @@ mangle_return(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+             instr_set_src(popf, 1, memop);
+             PRE(ilist, instr, popf);
+         }
++        /* Mangles single step exception after a popf. */
++        mangle_single_step(dcontext, ilist, popf);
+
+ #ifdef X64
+         /* In x64 mode, iret additionally does pop->RSP and pop->ss. */",I think that the iret handling is not yet good.
+3640,"@@ -78,7 +78,7 @@ const DeviceSizeTabBar = ( {
+ 						{ icon }
+ 					</Tab>
+ 				);
+-			}
++			},
+ 			) }
+ 		</TabBar>
+ 	);","Huh, that's kinda weird. I get it, but it's unexpected to me..."
+3641,"@@ -172,15 +172,6 @@ func (t *Tag) Done(s State) bool {
+ 	return err == nil && n == total
+ }
+
+-// DoneSplit sets total count to SPLIT count and sets the associated swarm hash for this tag
+-// is meant to be called when splitter finishes for input streams of unknown size
+-func (t *Tag) DoneSplit(address swarm.Address) int64 {
+-	total := atomic.LoadInt64(&t.Split)
+-	atomic.StoreInt64(&t.Total, total)
+-	t.Address = address
+-	return total
+-}
+-
+ // Status returns the value of state and the total count
+ func (t *Tag) Status(state State) (int64, int64, error) {
+ 	count, seen, total := t.Get(state), atomic.LoadInt64(&t.Seen), atomic.LoadInt64(&t.Total)",why is this removed? it is important when you upload from stream of unknown size
+3642,"@@ -3,7 +3,7 @@ class ApiToken < ActiveRecord::Base
+
+   before_create :generate_token
+
+-  belongs_to :approval
++  belongs_to :approval, class_name: 'Approvals::Individual'
+   has_one :proposal, through: :approval
+   has_one :user, through: :approval
+ ","Out of curiosity, why is this needed? Does it enforce what class can be assigned?"
+3643,"@@ -174,6 +174,11 @@ func (a *Agent) initEndpoints() error {
+ 		return fmt.Errorf(""Error creating GRPC listener: %s"", err)
+ 	}
+
++	if addr.Network() == ""unix"" {
++		// Any process should be able to use this unix socket
++		os.Chmod(addr.String(), os.ModePerm)
++	}
++
+ 	go func() {
+ 		a.config.ErrorCh <- a.grpcServer.Serve(listener)
+ 	}()","non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar"
+3644,"@@ -34,6 +34,8 @@ namespace Nethermind.Mev
+         }
+
+         public IBlockProcessor.IBlockTransactionsExecutor Create(ReadOnlyTxProcessingEnv readOnlyTxProcessingEnv) =>
+-            new MevBlockProductionTransactionsExecutor(readOnlyTxProcessingEnv, _specProvider, _logManager);
++            LastExecutor = new MevBlockProductionTransactionsExecutor(readOnlyTxProcessingEnv, _specProvider, _logManager);
++
++        public MevBlockProductionTransactionsExecutor LastExecutor { get; private set; } = null!;
+     }
+ }","factory should be stateless if possible, looks like much complexity added"
+3645,"@@ -527,6 +527,12 @@ class BigQueryLoadTask(MixinBigQueryBulkComplete, luigi.Task):
+         """"""	Indicates if BigQuery should allow quoted data sections that contain newline characters in a CSV file. The default value is false.""""""
+         return False
+
++    @property
++    def project_id(self):
++        """"""Project ID on which to run the BigQuery Job
++        """"""
++        return self.output().table.project_id
++
+     def run(self):
+         output = self.output()
+         assert isinstance(output, BigQueryTarget), 'Output must be a BigQueryTarget, not %s' % (output)",Could you please add short description for the default value as well?
+3646,"@@ -744,7 +744,7 @@ func (bc *blockchain) commitBlock(blk *Block) error {
+ 	if bc.sf != nil {
+ 		ExecuteContracts(blk, bc)
+ 		if err := bc.sf.CommitStateChanges(blk.Height(), blk.Transfers, blk.Votes, blk.Executions); err != nil {
+-			return err
++			logger.Fatal().Err(err).Msgf(""Failed to commit state changes on height %d"", blk.Height())
+ 		}
+ 	}
+ 	// write smart contract receipt into DB","Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction"
+3647,"@@ -107,6 +107,18 @@ public class TableProperties {
+   public static final String DELETE_PARQUET_COMPRESSION_LEVEL = ""write.delete.parquet.compression-level"";
+   public static final String PARQUET_COMPRESSION_LEVEL_DEFAULT = null;
+
++  public static final String PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT =
++      ""write.parquet.row-group-check-min-record-count"";
++  public static final String DELETE_PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT =
++      ""write.delete.parquet.row-group-check-min-record-count"";
++  public static final String PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT_DEFAULT = ""100"";
++
++  public static final String PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT =
++      ""write.parquet.row-group-check-max-record-count"";
++  public static final String DELETE_PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT =
++      ""write.delete.parquet.row-group-check-max-record-count"";
++  public static final String PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT_DEFAULT = ""10000"";
++
+   public static final String AVRO_COMPRESSION = ""write.avro.compression-codec"";
+   public static final String DELETE_AVRO_COMPRESSION = ""write.delete.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";",this can be integer
+3648,"@@ -69,6 +69,8 @@ class CompletionView(QTreeView):
+                 {{ color['completion.category.border.top'] }};
+             border-bottom: 1px solid
+                 {{ color['completion.category.border.bottom'] }};
++            font: {{ font['completion.category'] }};
++
+         }
+
+         QTreeView::item:selected, QTreeView::item:selected:hover {",nitpick: Please remove the blank line here
+3649,"@@ -4,6 +4,7 @@ class Way < ActiveRecord::Base
+   include ConsistencyValidations
+
+   set_table_name 'current_ways'
++  foreign_key 'changeset_id'
+
+   belongs_to :changeset
+ ",What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?
+3650,"@@ -798,6 +798,12 @@ public class CoreContainer {
+     SecurityConfHandler.SecurityConfig securityConfig = securityConfHandler.getSecurityConfig(false);
+     initializeAuthorizationPlugin((Map<String, Object>) securityConfig.getData().get(""authorization""));
+     initializeAuthenticationPlugin((Map<String, Object>) securityConfig.getData().get(""authentication""));
++    if (authenticationPlugin != null && authenticationPlugin.plugin.getMetricRegistry() == null) {
++      authenticationPlugin.plugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, ""/authentication"");
++    }
++    if (pkiAuthenticationPlugin != null && pkiAuthenticationPlugin.getMetricRegistry() == null) {
++      pkiAuthenticationPlugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, ""/authentication/pki"");
++    }
+   }
+
+   private static void checkForDuplicateCoreNames(List<CoreDescriptor> cds) {","Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called."
+3651,"@@ -130,6 +130,16 @@ TalkActionResult_t TalkActions::playerSaySpell(Player* player, SpeakClasses type
+ 			}
+ 		}
+
++		if (it->second.fromLua) {
++			if (it->second.getNeedAccess() && !player->getGroup()->access) {
++				return TALKACTION_CONTINUE;
++			}
++
++			if (player->getAccountType() < it->second.getRequiredAccountType()) {
++				return TALKACTION_BREAK;
++			}
++		}
++
+ 		if (it->second.executeSay(player, words, param, type)) {
+ 			return TALKACTION_CONTINUE;
+ 		} else {",shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?
+3652,"@@ -72,6 +72,8 @@ public class CliqueMiningAcceptanceTest extends AcceptanceTestBase {
+     cluster.stopNode(minerNode2);
+     cluster.stopNode(minerNode3);
+     minerNode1.verify(net.awaitPeerCount(0));
++    minerNode1.verify(clique.blockIsCreatedByProposer(minerNode1));
++
+     minerNode1.verify(clique.noNewBlockCreated(minerNode1));
+   }
+ ",does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?
+3653,"@@ -91,6 +91,12 @@ var _ topicreconciler.Interface = (*Reconciler)(nil)
+ func (r *Reconciler) ReconcileKind(ctx context.Context, topic *v1.Topic) reconciler.Event {
+ 	ctx = logging.WithLogger(ctx, r.Logger.With(zap.Any(""topic"", topic)))
+
++	if v, present := topic.Annotations[v1.LoggingE2ETestAnnotation]; present {
++		// This is added purely for the TestCloudLogging E2E tests, which verify that the log line
++		// is written if this annotation is present.
++		logging.FromContext(ctx).Desugar().Error(""Adding log line for the TestCloudLogging E2E tests"", zap.String(v1.LoggingE2EFieldName, v))
++	}
++
+ 	topic.Status.InitializeConditions()
+ 	topic.Status.ObservedGeneration = topic.Generation
+ ",I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future.
+3654,"@@ -960,11 +960,8 @@ class DataFrame(_Frame, Generic[T]):
+         #     sum  12.0  NaN
+         #
+         # Aggregated output is usually pretty much small. So it is fine to directly use pandas API.
+-        pdf = kdf.to_pandas().transpose().reset_index()
+-        pdf = pdf.groupby(['level_1']).apply(
+-            lambda gpdf: gpdf.drop('level_1', 1).set_index('level_0').transpose()
+-        ).reset_index(level=1)
+-        pdf = pdf.drop(columns='level_1')
++        pdf = kdf.to_pandas().stack(level=1)
++        pdf.index = pdf.index.droplevel()
+         pdf.columns.names = [None]
+         pdf.index.names = [None]
+ ",We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns.
+3655,"@@ -14,8 +14,13 @@ namespace Datadog.Trace.ClrProfiler
+         private static readonly Lazy<bool> _enabled = new Lazy<bool>(
+             () =>
+             {
++#if NETSTANDARD2_0
++                // TODO: figure out configuration in .NET Standard 2.0
++                return true;
++#else
+                 string setting = ConfigurationManager.AppSettings[""Datadog.Tracing:Enabled""];
+                 return !string.Equals(setting, bool.FalseString, StringComparison.InvariantCultureIgnoreCase);
++#endif
+             },
+             LazyThreadSafetyMode.PublicationOnly);
+ ","What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now."
+3656,"@@ -28,9 +28,9 @@ namespace OpenTelemetry.Metrics
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""SpanContext""/>.</param>
++        /// <param name=""context"">the associated <see cref=""SpanReference""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in SpanContext context, T value);
++        public abstract void Add(in SpanReference context, T value);
+
+         /// <summary>
+         /// Adds the given value to the bound counter metric.",should the parameters be called reference or context?
+3657,"@@ -184,7 +184,7 @@ module Bolt
+
+             begin
+               if writable && index < in_buffer.length
+-                to_print = in_buffer[index..-1]
++                to_print = in_buffer.byteslice(index..-1)
+                 written = inp.write_nonblock to_print
+                 index += written
+ ",Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work.
+3658,"@@ -166,6 +166,7 @@ def get_filename_question(*, suggested_filename, url, parent=None):
+     q.title = ""Save file to:""
+     q.text = ""Please enter a location for <b>{}</b>"".format(
+         html.escape(url.toDisplayString()))
++    q.yank_text = url.toString()
+     q.mode = usertypes.PromptMode.download
+     q.completed.connect(q.deleteLater)
+     q.default = _path_suggestion(suggested_filename)",This should be `toDisplayString()` to not contain e.g. passwords.
+3659,"@@ -180,6 +180,10 @@ class <%= controller_name.classify %>Controller < ApplicationController
+     # If there are more than this many search results, no spelling (""did you
+     # mean"") suggestion is offered.
+     config.spell_max = 5
++
++    # Configuration for autocomplete suggestor
++    config.autocomplete_enabled = true
++    config.autocomplete_path = 'suggest'
+   end
+
+ end ",Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?
+3660,"@@ -25,7 +25,7 @@ import (
+
+ 	""github.com/caddyserver/caddy/v2""
+ 	""github.com/caddyserver/caddy/v2/caddyconfig/caddyfile""
+-	""github.com/gogo/protobuf/proto""
++	""github.com/golang/protobuf/proto""
+ 	""github.com/golang/protobuf/ptypes/timestamp""
+ 	""github.com/google/cel-go/cel""
+ 	""github.com/google/cel-go/checker/decls""","Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the ""google.golang.org/protobuf/proto"" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown."
+3661,"@@ -4,14 +4,3 @@ get ""/pages/*id"" => ""pages#show"", format: false
+ get ""/subscribe"" => ""promoted_catalogs#show"", as: 'subscribe'
+ get ""/privacy"" => ""pages#show"", as: :privacy, id: 'privacy'
+ get ""/terms"" => ""pages#show"", as: :terms, id: 'terms'
+-
+-get(
+-  ""/group-training"" => ""pages#show"",
+-  as: :group_training,
+-  id: ""group-training""
+-)
+-get(
+-  ""/rubyist-booster-shot"" => ""pages#show"",
+-  as: :rubyist_booster_shot,
+-  id: ""rubyist-booster-shot""
+-)",Are these gone routes? Do we need to 301 them?
+3662,"@@ -18,10 +18,13 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/vmware-tanzu/antrea/pkg/apis/networking/v1beta1""
++	""github.com/vmware-tanzu/antrea/pkg/controller/networkpolicy""
+ 	""io""
+ 	""os""
+ 	""reflect""
+ 	""sort""
++	""strconv""
+ 	""strings""
+ 	""text/tabwriter""
+ ",move them to internal group of imports
+3663,"@@ -124,6 +124,7 @@ func (c *CStorPoolController) cStorPoolEventHandler(operation common.QueueOperat
+ 		status, err := c.getPoolStatus(cStorPoolGot)
+ 		return status, err
+ 	}
++	glog.Errorf(""Please handle cStorPool '%s' event on '%s'"", string(operation), string(cStorPoolGot.ObjectMeta.Name))
+ 	return string(apis.CStorPoolStatusInvalid), nil
+ }
+ ",can we rewrite this as: `ignored event '%s' for cstor pool '%s'`
+3664,"@@ -4,6 +4,8 @@ module Test
+   end
+
+   class ClientRequest < ActiveRecord::Base
++    belongs_to :approving_official, class_name: User
++
+     def self.purchase_amount_column_name
+       :amount
+     end",not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?
+3665,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",This change should also probably go into the corresponding method of the abstract By class?
+3666,"@@ -127,9 +127,6 @@ module.exports = function(config, auth, storage) {
+       } else {
+         next(HTTPError[err.message ? 401 : 500](err.message));
+       }
+-
+-      let base = Utils.combineBaseUrl(Utils.getWebProtocol(req), req.get('host'), config.url_prefix);
+-      res.redirect(base);
+     });
+   });
+ ",why this remove?
+3667,"@@ -54,7 +54,7 @@ type Reader interface {
+ 	Stat(ctx context.Context, path string) (os.FileInfo, error)
+
+ 	// Open opens an existing file for reading, as os.Open.
+-	Open(ctx context.Context, path string) (io.ReadCloser, error)
++	Open(ctx context.Context, path string) (FileReader, error)
+
+ 	// Glob returns all the paths matching the specified glob pattern, as
+ 	// filepath.Glob.","As the test failures indicate, making this change is going to mean changing everything which currently implements this interface."
+3668,"@@ -13,7 +13,7 @@ get(
+ get ""/humans-present/oss"" => redirect( ""https://www.youtube.com/watch?v=VMBhumlUP-A"")
+ get ""/ios-on-rails"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+ get ""/ios-on-rails-beta"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+-get ""/live"" => redirect(OfficeHours.url)
++get ""/live"" => redirect(""http://forum.upcase.com"")
+ get ""/pages/tmux"" => redirect(""https://www.youtube.com/watch?v=CKC8Ph-s2F4"")
+ get ""/prime"" => redirect(""/subscribe"")
+ get ""/products/:id/purchases/:lookup"" => redirect(""/purchases/%{lookup}"")",Do we want to redirect this to the forum or something in case people have it linked/bookmarked?
+3669,"@@ -21,7 +21,7 @@ export default Component.extend({
+     }),
+
+     backgroundStyle: computed('member.{name,email}', function () {
+-        let name = this.member.name || this.member.email;
++        let name = this.member.name || this.member.email || 'NM';
+         if (name) {
+             let color = stringToHslColor(name, 55, 55);
+             return htmlSafe(`background-color: ${color}`);","@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)"
+3670,"@@ -4,5 +4,6 @@ import attr from 'ember-data/attr';
+ export default DS.Model.extend({
+     name: attr('string'),
+     email: attr('string'),
+-    createdAt: attr('moment-utc')
++    createdAt: attr('moment-utc'),
++    subscriptions: attr('member-subscription')
+ });",@kevinansfield Would be cool if you can take a   if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin
+3671,"@@ -31,10 +31,12 @@ try:
+   import matplotlib.pyplot as plt
+   import matplotlib.cm as cm
+ except ImportError:
+-  # Suppress; we log it at debug level to avoid polluting the logs of apps
+-  # and services that don't care about plotting
+-  logging.debug(""Cannot import matplotlib. Plot class will not work."",
+-                exc_info=True)
++  # Suppress this optional dependency on matplotlib. NOTE we don't log this,
++  # because python logging implicitly adds the StreamHandler to root logger when
++  # calling `logging.debug`, etc., which may undermine an application's logging
++  # configuration.
++  plt = None
++  cm = None
+
+
+ ",This is the common way of dealing with optional dependencies
+3672,"@@ -67,8 +67,8 @@ func (t testHelper) AvailableEndpoints() *corev1.Endpoints {
+ 	}
+ }
+
+-func (t testHelper) ReadyDependencyStatus() *duckv1.KResource {
+-	kr := &duckv1.KResource{}
++func (t testHelper) ReadyDependencyStatus() *duckv1.Source {
++	kr := &duckv1.Source{}
+ 	kr.Status.SetConditions(apis.Conditions{{
+ 		Type:   ""Ready"",
+ 		Status: corev1.ConditionTrue,",nit: we can replace all `kr` in this file with like `src`.
+3673,"@@ -101,7 +101,7 @@ ReadPreference.fromOptions = function(options) {
+   if (typeof readPreference === 'string') {
+     return new ReadPreference(readPreference, readPreferenceTags);
+   } else if (!(readPreference instanceof ReadPreference) && typeof readPreference === 'object') {
+-    const mode = readPreference.mode || readPreference.preference;
++    const mode = readPreference.mode;
+     if (mode && typeof mode === 'string') {
+       return new ReadPreference(mode, readPreference.tags, {
+         maxStalenessSeconds: readPreference.maxStalenessSeconds",same concern here as above
+3674,"@@ -147,7 +147,7 @@ module Mongoid
+       def raw
+         validate_out!
+         cmd = command
+-        opts = { read: cmd.delete(:read) } if cmd[:read]
++        opts = { read: criteria.options.fetch(:read) } if criteria.options[:read]
+         @map_reduce.database.command(cmd, (opts || {}).merge(session: _session)).first
+       end
+       alias :results :raw","Thank you for this, I gather this repairs failures that I've seen in another PR."
+3675,"@@ -159,7 +159,7 @@ abstract class BaseSparkAction<ThisT, R> implements Action<ThisT, R> {
+         .repartition(spark.sessionState().conf().numShufflePartitions()) // avoid adaptive execution combining tasks
+         .as(Encoders.bean(ManifestFileBean.class));
+
+-    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF(""file_path"");
++    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF(""file_path"").distinct();
+   }
+
+   protected Dataset<Row> buildManifestFileDF(Table table) {","This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?"
+3676,"@@ -1516,6 +1516,11 @@ func (c *ClusterManager) NodeRemoveDone(nodeID string, result error) {
+ 			nodeID, err)
+ 		logrus.Errorf(msg)
+ 	}
++
++	// Remove osdconfig data from etcd
++	if err := c.configManager.DeleteNodeConf(nodeID); err != nil {
++		logrus.Warn(""error removing node from osdconfig:"", err)
++	}
+ }
+
+ func (c *ClusterManager) replayNodeDecommission() {",can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?
+3677,"@@ -6684,7 +6684,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+
+         return self._internal.copy(sdf=sdf, data_columns=columns, column_index=idx)
+
+-    def melt(self, id_vars=None, value_vars=None, var_name='variable',
++    def melt(self, id_vars=None, value_vars=None, var_name=None,
+              value_name='value'):
+         """"""
+         Unpivot a DataFrame from wide format to long format, optionally",Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well.
+3678,"@@ -608,6 +608,17 @@ def test_query_parser_path_params_with_slashes():
+     assert params == {""ResourceArn"": resource_arn}
+
+
++def test_parse_cloudtrail_with_botocore():
++    _botocore_parser_integration_test(
++        service=""cloudtrail"",
++        action=""DescribeTrails"",
++        headers={
++            ""X-Amz-Target"": ""com.amazonaws.cloudtrail.v20131101.CloudTrail_20131101.DescribeTrails""
++        },
++        trailNameList=[""t1""],
++    )
++
++
+ # TODO Add additional tests (or even automate the creation)
+ # - Go to the Boto3 Docs (https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/index.html)
+ # - Look for boto3 request syntax definition for services that use the protocol you want to test","I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?"
+3679,"@@ -83,7 +83,7 @@ export default AbstractEditController.extend(ChargeActions, PatientSubmodule, {
+         closeModalOnConfirm: false,
+         confirmAction: 'deleteCharge',
+         title: this.get('i18n').t('procedures.titles.deleteMedicationUsed'),
+-        message: this.get('i18n').t('procedures.messages.deleteMedication'),
++        message: this.get('i18n').t('messages.delete_singular', { name: 'medication' }),
+         chargeToDelete: charge,
+         updateButtonAction: 'confirm',
+         updateButtonText: this.get('i18n').t('buttons.ok')",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.
+3680,"@@ -8,12 +8,12 @@ export default class Provider {
+   constructor (opts) {
+     this.opts = opts
+     this.provider = opts.provider
+-    this.id = this.provider
++    this.id = opts.id || this.provider
+     this.name = this.opts.name || _getName(this.id)
+   }
+
+   auth () {
+-    return fetch(`${this.opts.host}/${this.provider}/authorize`, {
++    return fetch(`${this.opts.host}/${this.id}/auth`, {
+       method: 'get',
+       credentials: 'include',
+       headers: {","in case you want to rename one of the plugins when instantiating, from options?"
+3681,"@@ -22,6 +22,7 @@ from libcodechecker.logger import add_verbose_arguments
+ from libcodechecker.logger import LoggerFactory
+
+ LOG = LoggerFactory.get_new_logger('ANALYZE')
++CTU_FUNC_MAP_CMD = 'clang-func-mapping'
+
+
+ class OrderedCheckersAction(argparse.Action):","This default variable should be moved into a config variable, created by `package_context`, and read from `config\package_layout.json`."
+3682,"@@ -202,4 +202,16 @@ describe('Walkontable.ViewportColumnsCalculator', () => {
+     expect(calc.stretchAllColumnsWidth.length).toBe(0);
+     expect(calc.needVerifyLastColumnWidth).toBe(true);
+   });
++
++  it('should calculate the number of columns based on a default width, ' +
++    'when the width returned from the function is not a number', () => {
++    const calc = new Walkontable.ViewportColumnsCalculator(200, 0, 1000, () => (void 0 + 1));
++    expect(calc.startColumn).toBe(0);
++    expect(calc.startPosition).toBe(0);
++    expect(calc.endColumn).toBe(3);
++
++    const visibleCalc = new Walkontable.ViewportColumnsCalculator(200, 0, 1000, () => (void 0 + 1), null, true);
++    expect(visibleCalc.startColumn).toBe(0);
++    expect(visibleCalc.endColumn).toBe(3);
++  });
+ });",Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks.
+3683,"@@ -313,6 +313,7 @@ void CudaInternal::initialize(int cuda_device_id, cudaStream_t stream) {
+
+   enum { WordSize = sizeof(size_type) };
+
++#ifndef KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK
+ #ifdef KOKKOS_ENABLE_DEPRECATED_CODE
+   if (!HostSpace::execution_space::is_initialized()) {
+ #else","So the intention is you configure with `-CMAKE_CXX_FLAGS=""-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK""`?"
+3684,"@@ -396,7 +396,7 @@ void AssignHsResidueInfo(RWMol &mol) {
+           h_label = h_label.substr(3, 1) + h_label.substr(0, 3);
+           AtomPDBResidueInfo *newInfo = new AtomPDBResidueInfo(
+               h_label, max_serial, """", info->getResidueName(),
+-              info->getResidueNumber(), info->getChainId(), """",
++              info->getResidueNumber(), info->getChainId(), """", 1.0, 0.0,
+               info->getIsHeteroAtom());
+           mol.getAtomWithIdx(*begin)->setMonomerInfo(newInfo);
+ ",This was a bug.
+3685,"@@ -210,6 +210,19 @@ class ImageExtension extends Twig_Extension
+         $htmlAttributes = $attributes;
+         unset($htmlAttributes['type'], $htmlAttributes['size']);
+
++        $useLazyLoading = array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;
++        $isAttributeClassExistsAndNotEmpty = array_key_exists('class', $attributes) && $attributes['class'] !== '';
++        $htmlAttributes['class'] = sprintf(
++            '%s%s',
++            $useLazyLoading ? 'lazy' : '',
++            $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : ''
++        );
++
++        if ($useLazyLoading) {
++            $htmlAttributes['data-src'] = $htmlAttributes['src'];
++            $htmlAttributes['src'] = '';
++        }
++
+         return $this->templating->render('@ShopsysFramework/Common/image.html.twig', [
+             'attr' => $htmlAttributes,
+             'additionalImagesData' => $additionalImagesData,",Is OK that we don't have some placeholder?
+3686,"@@ -447,11 +447,11 @@ func (node *Node) setupStorageMining(ctx context.Context) error {
+ 		PoStProofType: postProofType,
+ 		SealProofType: sealProofType,
+ 		Miner:         minerAddr,
+-		WorkerThreads: 1,
++		WorkerThreads: 2,
+ 		Paths: []fs.PathConfig{
+ 			{
+ 				Path:   sectorDir,
+-				Cache:  false,
++				Cache:  true,
+ 				Weight: 1,
+ 			},
+ 		},",Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1.
+3687,"@@ -16,8 +16,11 @@
+
+ package azkaban.metrics;
+
++import static azkaban.ServiceProvider.SERVICE_PROVIDER;
++
+ import com.codahale.metrics.Meter;
+ import com.codahale.metrics.MetricRegistry;
++import com.google.inject.Inject;
+ import java.util.concurrent.atomic.AtomicLong;
+
+ /**",Sort of believe We should put MetricManager in constructor parameter given this case.
+3688,"@@ -28,11 +28,13 @@ import org.apache.iceberg.transforms.Transform;
+  */
+ public class PartitionField implements Serializable {
+   private final int sourceId;
++  private final int fieldId;
+   private final String name;
+   private final Transform<?, ?> transform;
+
+-  PartitionField(int sourceId, String name, Transform<?, ?> transform) {
++  PartitionField(int sourceId, int fieldId, String name, Transform<?, ?> transform) {
+     this.sourceId = sourceId;
++    this.fieldId = fieldId;
+     this.name = name;
+     this.transform = transform;
+   }",Do we need to check `fieldId` is larger than 1000?
+3689,"@@ -356,10 +356,7 @@ void StatefulWriter::unsent_change_added_to_history(
+                     periodic_hb_event_->restart_timer(max_blocking_time);
+                 }
+
+-                if ( (mp_listener != nullptr) && this->is_acked_by_all(change) )
+-                {
+-                    mp_listener->onWriterChangeReceivedByAll(this, change);
+-                }
++                check_acked_status();
+
+                 if (disable_positive_acks_ && last_sequence_number_ == SequenceNumber_t())
+                 {",I think this should be called after the if below (the one for disable positive acks)
+3690,"@@ -271,7 +271,7 @@ public class SparkTableUtil {
+    * @param metricsConfig a metrics conf
+    * @return a List of DataFile
+    */
+-  public static List<DataFile> listPartition(Map<String, String> partition, String uri, String format,
++  public static List<DataFile> listPartition(Map<String, String> partition, URI uri, String format,
+                                              PartitionSpec spec, Configuration conf, MetricsConfig metricsConfig) {
+     if (format.contains(""avro"")) {
+       return listAvroPartition(partition, uri, spec, conf);",I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path).
+3691,"@@ -5,11 +5,13 @@ import (
+ 	""path/filepath""
+ 	""testing""
+
++	""github.com/aws/aws-sdk-go/internal/sdktesting""
+ 	""github.com/aws/aws-sdk-go/internal/shareddefaults""
+ )
+
+ func TestSharedCredentialsProvider(t *testing.T) {
+-	os.Clearenv()
++
++	sdktesting.StashEnv()
+
+ 	p := SharedCredentialsProvider{Filename: ""example.ini"", Profile: """"}
+ 	creds, err := p.Retrieve()",Should these restore the stashed env after the test runs?
+3692,"@@ -402,7 +402,10 @@ def is_default_argument(
+     if not scope:
+         scope = node.scope()
+     if isinstance(scope, (nodes.FunctionDef, nodes.Lambda)):
+-        for default_node in scope.args.defaults:
++        all_defaults = scope.args.defaults + [
++            d for d in scope.args.kw_defaults if d is not None
++        ]
++        for default_node in all_defaults:
+             for default_name_node in default_node.nodes_of_class(nodes.Name):
+                 if default_name_node is node:
+                     return True",We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``.
+3693,"@@ -119,6 +119,14 @@ type accountDelta struct {
+ 	new basics.AccountData
+ }
+
++// accountDeltaCount is an extention to accountDelta that is being used by the commitRound function for counting the
++// number of changes we've made per account. The ndeltas is used execlusively for consistency checking - making sure that
++// all the pending changes were written and that there are no outstanding writes missing.
++type accountDeltaCount struct {
++	accountDelta
++	ndeltas int
++}
++
+ // catchpointState is used to store catchpoint related variables into the catchpointstate table.
+ type catchpointState string
+ ","Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?"
+3694,"@@ -21,13 +21,12 @@ import net.sourceforge.pmd.lang.rule.xpath.JaxenXPathRuleQuery;
+ import net.sourceforge.pmd.lang.rule.xpath.SaxonXPathRuleQuery;
+ import net.sourceforge.pmd.lang.rule.xpath.XPathRuleQuery;
+ import net.sourceforge.pmd.properties.EnumeratedProperty;
+-import net.sourceforge.pmd.properties.PropertySource;
+ import net.sourceforge.pmd.properties.StringProperty;
+
+ /**
+  * Rule that tries to match an XPath expression against a DOM view of an AST.
+- *
+- * <p>This rule needs a ""xpath"" property value in order to function.
++ * <p>
++ * <p>This rule needs a ""xpath"" property value in order to function.</p>
+  */
+ public class XPathRule extends AbstractRule {
+ ","Our checkstyle config likes it better when the `<p>` is before the first word of the next paragraph, and not on a blank line"
+3695,"@@ -1498,6 +1498,8 @@ func (c *linuxContainer) criuSwrk(process *Process, req *criurpc.CriuReq, opts *
+ 	if err := cmd.Start(); err != nil {
+ 		return err
+ 	}
++	// we close criuServer so that even if CRIU crashes or unexpectedly exits, runc will not hang.
++	criuServer.Close()
+ 	// cmd.Process will be replaced by a restored init.
+ 	criuProcess := cmd.Process
+ ","This looks to be the only place where we return early before the close below, so if the ""double close"" is bothering people, closing manually here (and removing the `defer`) could be an option"
+3696,"@@ -91,8 +91,8 @@ gulp.task( 'default', () => {
+ 	);
+ } );
+
+-gulp.task( 'qunit', function() {
+-	execSync( 'node-qunit-phantomjs ./tests/qunit/index.html', { stdio: [ 0, 1, 2 ] } );
++gulp.task( 'jest', function() {
++	execSync( 'npm run test:js', { stdio: [ 0, 1, 2 ] } );
+ } );
+
+ gulp.task( 'phpunit', function() {",This task can probably be deleted since we don't need gulp to run Jest.
+3697,"@@ -23,6 +23,9 @@ require 'socket'
+ module Selenium
+   module WebDriver
+     class SocketPoller
++      NOT_CONNECTED_ERRORS = [Errno::ECONNREFUSED, Errno::ENOTCONN, SocketError]
++      NOT_CONNECTED_ERRORS << Errno::EPERM if Platform.cygwin?
++
+       def initialize(host, port, timeout = 0, interval = 0.25)
+         @host     = host
+         @port     = Integer(port)",Doesn't this need to include `Errno::ECONNRESET` to fix the issue?
+3698,"@@ -28,6 +28,19 @@ module Faker
+       def quote
+         fetch('movie.quote')
+       end
++
++      ##
++      # Produces a qirector from a movie.
++      #
++      # @return [String]
++      #
++      # @example
++      #   Faker::Movie.qirector #=> ""Quentin Tarantino""
++      #
++      # @faker.version next
++      def director
++        fetch('movie.director')
++      end
+     end
+   end
+ end",never heard of a qirector... what's their role again? (also should be 'for a movie')
+3699,"@@ -86,6 +86,14 @@ kvstore::ResultCode QueryBoundProcessor::processVertex(PartitionID partId, Verte
+             }
+         }
+         vResp.set_tag_data(std::move(td));
++    } else if (tagContexts_.empty() && onlyVertexProps_) {
++        std::vector<cpp2::TagData> td;
++        auto ret = collectVertexProps(partId, vId, td);
++        if (ret != kvstore::ResultCode::ERR_KEY_NOT_FOUND
++                && ret != kvstore::ResultCode::SUCCEEDED) {
++            return ret;
++        }
++        vResp.set_tag_data(std::move(td));
+     }
+
+     if (onlyVertexProps_) {","Implement the ""collect all props for one vertex"" logic inside QueryVertexPropsProcessor"
+3700,"@@ -311,6 +311,10 @@ bool rai::uint256_union::decode_dec (std::string const & text)
+ 		{
+ 			stream >> number_l;
+ 			*this = number_l;
++			if (!stream.eof ())
++			{
++				result = true;
++			}
+ 		}
+ 		catch (std::runtime_error &)
+ 		{","This is to prevent parsing things like ""1.1"" as ""1"" until we implement it properly."
+3701,"@@ -25,7 +25,7 @@ import os
+ import shutil
+
+ from nupic.data.file_record_stream import FileRecordStream
+-from nupic.frameworks.opf.experiment_runner import runExperiment
++from nupic.frameworks.opf.experiment_runner import runExperiment, _getCheckpointParentDir
+ from nupic.support import initLogging
+ from nupic.support.unittesthelpers.testcasebase import (
+     unittest, TestCaseBase as HelperTestCaseBase)",Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use.
+3702,"@@ -2050,6 +2050,13 @@ class AdvancedPanelControls(wx.Panel):
+ 		self.UIAInMSWordCheckBox.SetValue(config.conf[""UIA""][""useInMSWordWhenAvailable""])
+ 		self.UIAInMSWordCheckBox.defaultValue = self._getDefaultValue([""UIA"", ""useInMSWordWhenAvailable""])
+
++		# Translators: This is the label for a checkbox in the
++		#  Advanced settings panel.
++		label = _(""Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)"")
++		self.ConsoleUIACheckBox=UIAGroup.addItem(wx.CheckBox(self, label=label))
++		self.ConsoleUIACheckBox.SetValue(config.conf[""UIA""][""consoleUIA""])
++		self.ConsoleUIACheckBox.defaultValue = self._getDefaultValue([""UIA"", ""consoleUIA""])
++
+ 		# Translators: This is the label for a group of advanced options in the
+ 		#  Advanced settings panel
+ 		label = _(""Browse mode"")",Why is a restart necessary?
+3703,"@@ -458,7 +458,11 @@ func (task *Task) addGPUResource(cfg *config.Config) error {
+ 				container.GPUIDs = append(container.GPUIDs, association.Name)
+ 			}
+ 		}
+-		task.populateGPUEnvironmentVariables()
++		// For external instances, GPU IDs are handled by resources struct
++		// For internal instances, GPU IDs are handled by env var
++		if !cfg.External.Enabled() {
++			task.populateGPUEnvironmentVariables()
++		}
+ 		task.NvidiaRuntime = cfg.NvidiaRuntime
+ 	}
+ 	return nil",Should setting the task runtime also go under the above if condition?
+3704,"@@ -32,6 +32,8 @@ import (
+
+ var isDNSLabel = regexp.MustCompile(`^[a-zA-Z0-9]([-]*[a-zA-Z0-9])+$`).MatchString
+
++const _defaultListEntriesPageSize = 50
++
+ //Handler service is used to register SPIFFE IDs, and the attestation logic that should
+ //be performed on a workload before those IDs can be issued.
+ type Handler struct {",SPIRE uses the leadingLowerCase convention for unexported constants
+3705,"@@ -1,11 +1,12 @@
+ // Copyright (c) Microsoft.  All Rights Reserved.
+ // Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
+
+-using Microsoft.CodeAnalysis.Sarif.Readers;
+ using System;
+ using System.CodeDom.Compiler;
+ using System.Collections.Generic;
+ using System.Runtime.Serialization;
++using Microsoft.CodeAnalysis.Sarif.Readers;
++using Newtonsoft.Json;
+
+ namespace Microsoft.CodeAnalysis.Sarif
+ {",The newest JSchema code generator orders `System` usings first.
+3706,"@@ -82,10 +82,17 @@ public class HiveIcebergSerDe extends AbstractSerDe {
+     }
+
+     String[] selectedColumns = ColumnProjectionUtils.getReadColumnNames(configuration);
+-    Schema projectedSchema = selectedColumns.length > 0 ? tableSchema.select(selectedColumns) : tableSchema;
++    Schema projectedSchema = tableSchema;
++
++    boolean caseSensitive = configuration.getBoolean(InputFormatConfig.CASE_SENSITIVE,
++            InputFormatConfig.CASE_SENSITIVE_DEFAULT);
++    if (selectedColumns.length > 0) {
++      projectedSchema = caseSensitive ? tableSchema.select(selectedColumns)
++              : tableSchema.caseInsensitiveSelect(selectedColumns);
++    }
+
+     try {
+-      this.inspector = IcebergObjectInspector.create(projectedSchema);
++      this.inspector = IcebergObjectInspector.create(projectedSchema, caseSensitive);
+     } catch (Exception e) {
+       throw new SerDeException(e);
+     }","I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced  "
+3707,"@@ -79,7 +79,7 @@ func (c *CStorPoolController) cStorPoolEventHandler(operation common.QueueOperat
+ 		common.SyncResources.Mux.Lock()
+ 		status, err := c.cStorPoolAddEventHandler(cStorPoolGot)
+ 		common.SyncResources.Mux.Unlock()
+-
++		pool.PoolAddEventHandled = true
+ 		return status, err
+
+ 	case common.QOpDestroy:",Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?
+3708,"@@ -600,11 +600,11 @@ func (c *coroutineLoweringPass) lowerFuncsPass() {
+ 			continue
+ 		}
+
+-		if len(fn.normalCalls) == 0 {
+-			// No suspend points. Lower without turning it into a coroutine.
++		if len(fn.normalCalls) == 0 && fn.fn.FirstBasicBlock().FirstInstruction().IsAAllocaInst().IsNil() {
++			// No suspend points or stack allocations. Lower without turning it into a coroutine.
+ 			c.lowerFuncFast(fn)
+ 		} else {
+-			// There are suspend points, so it is necessary to turn this into a coroutine.
++			// There are suspend points or stack allocations, so it is necessary to turn this into a coroutine.
+ 			c.lowerFuncCoro(fn)
+ 		}
+ 	}","I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible)."
+3709,"@@ -135,11 +135,19 @@ func chainsForIfaces(ifaceMetadata []string,
+ 	epMarkMapper rules.EndpointMarkMapper,
+ 	host bool,
+ 	tableKind string) []*iptables.Chain {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	log.WithFields(log.Fields{
+ 		""ifaces"":    ifaceMetadata,
+ 		""host"":      host,
+ 		""tableKind"": tableKind,
+ 	}).Debug(""Calculating chains for interface"")
++
+ 	chains := []*iptables.Chain{}
+ 	dispatchOut := []iptables.Rule{}
+ 	dispatchIn := []iptables.Rule{}",Why isn't this 4789 (which I think is the Felix default)?
+3710,"@@ -57,6 +57,10 @@ const (
+ 	MessageResourceFailCreate EventReason = ""Resource creation failed""
+ 	// SuccessImported holds status for corresponding imported resource.
+ 	SuccessImported EventReason = ""Imported""
++	// FailureImported holds status for corresponding imported resource.
++	FailureImported EventReason = ""Import failure""
++	// FailureImportOperations holds status for corresponding imported resource.
++	FailureImportOperations EventReason = ""Failure Import operations""
+ 	// MessageResourceImported holds message for corresponding imported resource.
+ 	MessageResourceImported EventReason = ""Resource imported successfully""
+ 	// FailureStatusSync holds status for corresponding failed status sync of resource.","Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason<Action><Entity/Adjective of the Entity><Sucess/Failure>`"
+3711,"@@ -457,4 +457,5 @@ void Init_binary_protocol_accelerated() {
+   rb_define_method(bpa_class, ""read_set_end"", rb_thrift_binary_proto_read_set_end, 0);
+
+   rbuf_ivar_id = rb_intern(""@rbuf"");
++  rb_global_variable(&rbuf_ivar_id);
+ }",I suspect this isn't needed because I think `rb_intern` gets marked already.
+3712,"@@ -96,7 +96,7 @@ public class InternalSelenseTestBase extends SeleneseTestBase {
+       return;
+     }
+
+-    log.info(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
++    log.finest(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
+
+     Path dir =
+       InProject.locate(""java/client/build/production/com/thoughtworks/selenium/webdriven"");",This change is incorrect: the current log level is correct.
+3713,"@@ -80,7 +80,8 @@ public class BKDWriter implements Closeable {
+   //public static final int VERSION_CURRENT = VERSION_START;
+   public static final int VERSION_LEAF_STORES_BOUNDS = 5;
+   public static final int VERSION_SELECTIVE_INDEXING = 6;
+-  public static final int VERSION_CURRENT = VERSION_SELECTIVE_INDEXING;
++  public static final int VERSION_LOW_CARDINALITY_LEAVES= 7;
++  public static final int VERSION_CURRENT = VERSION_LOW_CARDINALITY_LEAVES;
+
+   /** How many bytes each docs takes in the fixed-width offline format */
+   private final int bytesPerDoc;",Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR.
+3714,"@@ -268,7 +268,10 @@ public class ExecutorServlet extends HttpServlet implements ConnectorParams {
+         continue;
+       }
+
+-      if (flow.getUpdateTime() > updateTime) {
++      // After removing runningFlows cache from web server, flow info will be fetched from DB directly,
++      // updateTime will be synced between web server and executor. So below if condition will always be true.
++      // TODO: will remove UpdaterThread in executorManager and deprecate handleAjaxUpdateRequest()
++      if (flow.getUpdateTime() >= updateTime) {
+         updateList.add(flow.toUpdateObject(updateTime));
+       }
+     }",Please follow the todo naming convention.
+3715,"@@ -28,6 +28,9 @@ import (
+ // +k8s:openapi-gen=true
+ // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
++// +kubebuilder:printcolumn:name=""Ready"",type=""string"",JSONPath="".status.conditions[?(@.type==\""Ready\"")].status"",description=""""
++// +kubebuilder:printcolumn:name=""Status"",type=""string"",JSONPath="".status.conditions[?(@.type==\""Ready\"")].message"",description=""""
++// +kubebuilder:printcolumn:name=""Age"",type=""date"",JSONPath="".metadata.creationTimestamp"",description=""CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.""
+ // +kubebuilder:subresource:status
+ // +kubebuilder:resource:path=clusterissuers,scope=Cluster
+ type ClusterIssuer struct {",These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds`   /assign @JoshVanL /unassign
+3716,"@@ -257,9 +257,11 @@ class YOLOV3Head(BaseDenseHead, BBoxTestMixin):
+             # (h, w, num_anchors*num_attrib) -> (h*w*num_anchors, num_attrib)
+             pred_map = pred_map.permute(1, 2, 0).reshape(-1, self.num_attrib)
+
+-            pred_map[..., :2] = torch.sigmoid(pred_map[..., :2])
+-            bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i],
+-                                               pred_map[..., :4], stride)
++            xy = torch.sigmoid(pred_map[..., :2])
++            xywh = torch.cat((xy, pred_map[..., 2:4]), axis=-1)
++            bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i], xywh,
++                                               stride)
++
+             # conf and cls
+             conf_pred = torch.sigmoid(pred_map[..., 4]).view(-1)
+             cls_pred = torch.sigmoid(pred_map[..., 5:]).view(",Is this really necessary to work around this way? The old version works fine with me when converting to ONNX.
+3717,"@@ -71,7 +71,7 @@ type s3Blob struct {
+
+ func (bb *s3Blob) Write(p []byte) (int, error) {
+ 	if bb.final {
+-		return 0, errors.New(""blob already closed"")
++		return 0, errors.New(""Blob already closed"")
+ 	}
+
+ 	n, err := bb.buf.Write(p)","Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)"
+3718,"@@ -168,6 +168,7 @@ module Beaker
+
+       options[:recursive]=File.directory?(source) if options[:recursive].nil?
+
++      @logger.debug ""going to upload! #{source} to #{@hostname}:#{target}""
+       @ssh.scp.upload! source, target, options
+
+       result = Result.new(@hostname, [source, target])",Is this a testing debug statement?
+3719,"@@ -849,7 +849,11 @@ var connect = function(self, url, options, callback) {
+   }
+
+   // Parse the string
+-  var object = parse(url, options);
++  var object;
++  parse(url, options, function(err, connectionStringObject) {
++    if (err) return console.log(err);
++    object = connectionStringObject;
++  });
+   var _finalOptions = createUnifiedOptions({}, object);
+   _finalOptions = mergeOptions(_finalOptions, object, false);
+   _finalOptions = createUnifiedOptions(_finalOptions, options);","you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`."
+3720,"@@ -238,9 +238,9 @@ thread ([this]() {
+
+ void nano::worker::run ()
+ {
++	std::unique_lock<std::mutex> lk (mutex);
+ 	while (!stopped)
+ 	{
+-		std::unique_lock<std::mutex> lk (mutex);
+ 		if (!queue.empty ())
+ 		{
+ 			auto func = queue.front ();","This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with."
+3721,"@@ -27,6 +27,10 @@ import (
+ 	""strings""
+ 	""time""
+
++	""github.com/mysteriumnetwork/node/cmd/commands""
++
++	remote_config ""github.com/mysteriumnetwork/node/config/remote""
++
+ 	""github.com/chzyer/readline""
+ 	""github.com/rs/zerolog/log""
+ 	""github.com/urfave/cli/v2""","Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can."
+3722,"@@ -1128,12 +1128,16 @@ encode_opnd_imm5(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ static inline bool
+ decode_opnd_imm6(uint enc, int opcode, byte *pc, OUT opnd_t *opnd)
+ {
++    if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))
++        return false;
+     return decode_opnd_int(10, 6, false, 0, OPSZ_6b, 0, enc, opnd);
+ }
+
+ static inline bool
+ encode_opnd_imm6(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ {
++    if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))
++        return false;
+     return encode_opnd_int(10, 6, false, 0, 0, opnd, enc_out);
+ }
+ ",Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below.
+3723,"@@ -125,9 +125,6 @@ function generateTopologyTests(testSuites, testContext, filter) {
+       describe(suiteName, {
+         metadata: { requires },
+         test: function () {
+-          beforeEach(() => prepareDatabaseForSuite(testSuite, testContext));
+-          afterEach(() => testContext.cleanupAfterSuite());
+-
+           testSuite.tests.forEach(spec => {
+             it(spec.description, function () {
+               if (","I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change"
+3724,"@@ -213,6 +213,9 @@ class LoadAnnotations:
+             annotation. Default: False.
+         poly2mask (bool): Whether to convert the instance masks from polygons
+             to bitmaps. Default: True.
++        normed_bbox (bool): Whether to convert bbox from relative value to
++            absolute value. Only used in OpenImage Dataset.
++            Default: False.
+         file_client_args (dict): Arguments to instantiate a FileClient.
+             See :class:`mmcv.fileio.FileClient` for details.
+             Defaults to ``dict(backend='disk')``.",Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`
+3725,"@@ -32,10 +32,10 @@ func (*testTraceProvider) Tracer(_ string, _ ...trace.TracerOption) trace.Tracer
+ func TestMultipleGlobalTracerProvider(t *testing.T) {
+ 	p1 := testTraceProvider{}
+ 	p2 := trace.NoopProvider{}
+-	global.SetTraceProvider(&p1)
+-	global.SetTraceProvider(&p2)
++	global.SetTracerProvider(&p1)
++	global.SetTracerProvider(&p2)
+
+-	got := global.TraceProvider()
++	got := global.TracerProvider()
+ 	want := &p2
+ 	if got != want {
+ 		t.Fatalf(""Provider: got %p, want %p\n"", got, want)",Should we change the name of this test struct to be `testTracerProvider` as well?
+3726,"@@ -21,13 +21,14 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/config""
+-	""github.com/iotexproject/iotex-core/explorer""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/probe""
++	""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ 	""github.com/iotexproject/iotex-core/server/itx""
+ 	""github.com/iotexproject/iotex-core/testutil""
+ 	""github.com/iotexproject/iotex-core/tools/util""
++	""google.golang.org/grpc""
+ )
+
+ const (","""google.golang.org/grpc"" should be together with ""go.uber.org/zap"" all """"github.com/iotexproject/iotex-core/*"" stay together"
+3727,"@@ -700,6 +700,12 @@ class WebEngineTab(browsertab.AbstractTab):
+         self._inject_early_js('js', js_code, subframes=True)
+         self._init_stylesheet()
+
++        js_code_print = utils.read_file('javascript/print.js')
++        self._inject_early_js('js',
++                              js_code_print,
++                              subframes=True,
++                              world=QWebEngineScript.MainWorld)
++
+         greasemonkey = objreg.get('greasemonkey')
+         greasemonkey.scripts_reloaded.connect(self._inject_userscripts)
+         self._inject_userscripts()",No need for a separate variable here - just call `utils.read_file` directly below.
+3728,"@@ -150,8 +150,18 @@ func (ctx *ChannelContext) SendResp(message model.Message) {
+
+ 	ctx.anonChsLock.RLock()
+ 	defer ctx.anonChsLock.RUnlock()
++
++	deadline := time.Now().Add(MessageTimeoutDefault)
++	sendTimer := time.NewTimer(time.Until(deadline))
++
+ 	if channel, exist := ctx.anonChannels[anonName]; exist {
+-		channel <- message
++		select {
++		case channel <- message:
++		case <-sendTimer.C:
++			klog.Warning(""timeout when SendResp message"")
++			return
++		}
++		sendTimer.Stop()
+ 		return
+ 	}
+ ","Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?"
+3729,"@@ -29,7 +29,8 @@ type SyncStage byte
+
+ const (
+ 	Headers   SyncStage = iota // Headers are downloaded, their Proof-Of-Work validity and chaining is verified
+-	Bodies                     // Block bodies are downloaded, TxHash and UncleHash are getting verified, ""From"" recovered from signatures
++	Bodies                     // Block bodies are downloaded, TxHash and UncleHash are getting verified
++	Senders                    // ""From"" recovered from signatures, bodies re-written
+ 	Execution                  // Executing each block w/o buildinf a trie
+ 	HashCheck                  // Checking the root hash
+ 	Finish                     // Nominal stage after all other stages","maybe we will have something like `Bodies []byte(""bodies"")` instead of them being a number? with numbers we are making it harder to insert stages mid-process."
+3730,"@@ -82,11 +82,11 @@ type Endpoint struct {
+ // GroupMember represents resource member to be populated in Groups.
+ // This supersedes GroupMemberPod, and will eventually replace it.
+ type GroupMember struct {
+-	// ExternalEntity maintains the reference to the ExternalEntity.
+-	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,1,opt,name=externalEntity""`
+-
+ 	// Pod maintains the reference to the Pod.
+-	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,2,opt,name=pod""`
++	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,1,opt,name=pod""`
++
++	// ExternalEntity maintains the reference to the ExternalEntity.
++	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,2,opt,name=externalEntity""`
+
+ 	// Endpoints maintains a list of EndPoints associated with this groupMember.
+ 	Endpoints []Endpoint `json:""endpoints,omitempty"" protobuf:""bytes,3,rep,name=endpoints""`","out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?"
+3731,"@@ -334,6 +334,10 @@ func (manager *connectionManager) Disconnect() error {
+ 	manager.cleanConnection()
+ 	manager.setStatus(statusNotConnected())
+
++	manager.eventPublisher.Publish(StateEventTopic, StateEvent{
++		State:       NotConnected,
++		SessionInfo: manager.sessionInfo,
++	})
+ 	return nil
+ }
+ ",Could we public events if `manager.serStatus()`?
+3732,"@@ -134,7 +134,9 @@ module.exports = class Plugin {
+     }
+
+     this.uppy.log(`Not installing ${callerPluginName}`)
+-    throw new Error(`Invalid target option given to ${callerPluginName}`)
++    throw new Error(`Invalid target option given to ${callerPluginName}. Please make sure that the element
++      exists on the page, or that the plugin you are targeting has been installed. Check that the <script> tag initializing Uppy
++      comes at the bottom of the page, before the </body> (see https://github.com/transloadit/uppy/issues/1042).`)
+   }
+
+   render (state) {","could be misread as `<body>`, maybe something redundant but very clear like ""before the closing `</body>` tag""?"
+3733,"@@ -510,12 +510,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+             var testLogger = new TestApplicationErrorLogger();
+             var serviceContext = new TestServiceContext { Log = new TestKestrelTrace(testLogger) };
+
+-            using (var server = new TestServer(httpContext =>
++            using (var server = new TestServer(async httpContext =>
+             {
+                 httpContext.Response.ContentLength = 11;
+-                httpContext.Response.Body.Write(Encoding.ASCII.GetBytes(""hello,""), 0, 6);
+-                httpContext.Response.Body.Write(Encoding.ASCII.GetBytes("" world""), 0, 6);
+-                return Task.CompletedTask;
++                await httpContext.Response.Body.WriteAsync(Encoding.ASCII.GetBytes(""hello,""), 0, 6);
++                await httpContext.Response.Body.WriteAsync(Encoding.ASCII.GetBytes("" world""), 0, 6);
+             }, serviceContext))
+             {
+                 using (var connection = server.CreateConnection())","This test is specifically checking behavior on sync I/O (note there are tests with Write in the name, and other tests with WriteAsync). Enable sync I/O here."
+3734,"@@ -0,0 +1,11 @@
++class WeeklyIterationDripMailerPreview < ActionMailer::Preview
++  def weekly_update
++    user = User.new(name: 'John Doe')
++    video = Video.first.tap do |video|
++      video.email_body_text = 'Email body text'
++      video.email_cta_label = 'Click Here!'
++    end
++
++    WeeklyIterationDripMailer.weekly_update(user: user, video: video)
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+3735,"@@ -56,6 +56,8 @@ type CStorVolumeClaimSpec struct {
+ 	// CStorVolumeRef has the information about where CstorVolumeClaim
+ 	// is created from.
+ 	CStorVolumeRef *corev1.ObjectReference `json:""cstorVolumeRef,omitempty""`
++	// CstorVolumeSource contains the source volumeID+Snapshot combaination
++	CstorVolumeSource string `json:""cstorVolumeSource,omitempty""`
+ }
+
+ // CStorVolumeClaimPublish contains info related to attachment of a volume to a node.",nit: Should we have something like `volumeName@snapShotname` and this will be filled only if it is a clone creation
+3736,"@@ -164,10 +164,13 @@ func WriteWordpressConfig(wordpressConfig *WordpressConfig, filePath string) err
+ 		return err
+ 	}
+
+-	// Ensure target directory is writable.
++	// Ensure target directory exists and is writeable
+ 	dir := filepath.Dir(filePath)
+-	err = os.Chmod(dir, 0755)
+-	if err != nil {
++	if err = os.Chmod(dir, 0755); os.IsNotExist(err) {
++		if err = os.MkdirAll(dir, 0755); err != nil {
++			return err
++		}
++	} else if err != nil {
+ 		return err
+ 	}
+ ",This seems like an improved pattern :)
+3737,"@@ -53,7 +53,11 @@ def get_hdfs_syntax():
+     override this setting with ""cdh3"" or ""apache1"" in the hadoop section of the config in
+     order to use the old syntax
+     """"""
+-    return configuration.get_config().get(""hadoop"", ""version"", ""cdh4"").lower()
++    try:
++        import snakebite
++        return configuration.get_config().get(""hadoop"", ""version"", ""snakebite"").lower()
++    except ImportError:
++        return configuration.get_config().get(""hadoop"", ""version"", ""cdh4"").lower()
+
+
+ def load_hadoop_cmd():","I think it would be better to have a separate configuration option for specifying which HDFS interaction layer to use instead of using the existing hadoop version option. I think there are still cases where things might have to rely on Hadoop version for other things, and overwriting that information with ""snakebite"" would make that difficult. The existing hadoop version option could still be used to distinguish the different HDFS CLI flavours."
+3738,"@@ -575,10 +575,15 @@ module Bolt
+       outputter.print_task_info(pal.get_task(task_name))
+     end
+
++    # Filters a list of content by matching substring.
++    #
++    private def filter_content(content, filter)
++      return content unless content && filter
++      content.select { |name,| name.include?(filter) }
++    end
++
+     def list_tasks
+-      tasks = pal.list_tasks
+-      tasks.select! { |task| task.first.include?(options[:filter]) } if options[:filter]
+-      tasks.select! { |task| config.project.tasks.include?(task.first) } unless config.project.tasks.nil?
++      tasks = filter_content(pal.list_tasks(filter_content: true), options[:filter])
+       outputter.print_tasks(tasks, pal.user_modulepath)
+     end
+ ",Why are we filtering content twice? It seems like just filtering it in PAL should work.
+3739,"@@ -17,11 +17,11 @@
+  */
+
+ export const ACCOUNT_STATUS_NONE = 'none';
++export const ACCOUNT_STATUS_MULTIPLE = 'multiple';
+ export const ACCOUNT_STATUS_DISAPPROVED = 'disapproved';
+ export const ACCOUNT_STATUS_GRAYLISTED = 'graylisted';
+-export const ACCOUNT_STATUS_MULTIPLE = 'multiple';
+-export const ACCOUNT_STATUS_NO_CLIENT = 'no-client';
+ export const ACCOUNT_STATUS_PENDING = 'pending';
++export const ACCOUNT_STATUS_NO_CLIENT = 'no-client';
+ export const ACCOUNT_STATUS_APPROVED = 'approved';
+
+ // TODO: Expand the statuses provided here to be more specific in case the",These should probably move to `constants.js`
+3740,"@@ -21,6 +21,8 @@ import com.google.common.base.Charsets;
+ import com.google.common.io.ByteStreams;
+ import com.google.common.net.MediaType;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.apache.http.Header;
+ import org.apache.http.HttpEntity;
+ import org.apache.http.HttpHost;","Again, you don't want to depend on glassfish."
+3741,"@@ -0,0 +1,15 @@
++# frozen_string_literal: true
++
++module Faker
++  module Space
++    class << self
++      extend Gem::Deprecate
++
++      def launch_vehicule
++        Faker::Space.launch_vehicule
++      end
++
++      deprecate :launch_vehicule, 'Faker::Space.launch_vehicule', 2019, 06
++    end
++  end
++end","it should be `Faker::Space.launch_vehicle`, otherwise it will crash"
+3742,"@@ -630,6 +630,18 @@ namespace NLog.Targets
+ #endif
+             byte[] bytes = this.GetBytesToWrite(logEvent);
+
++            // Clean up old archives if this is the first time a log record has been written to
++            // this log file and the archiving system is date/time based.
++            if (this.ArchiveNumbering == ArchiveNumberingMode.Date && this.ArchiveEvery != FileArchivePeriod.None)
++            {
++                FileInfo fileInfo = new FileInfo(fileName);
++                if (!fileInfo.Exists)
++                {
++                    string fileNamePattern = this.GetFileNamePattern(fileName, logEvent, fileInfo);
++                    this.DeleteOldDateArchive(fileNamePattern);
++                }
++            }
++
+             if (this.ShouldAutoArchive(fileName, logEvent, bytes.Length))
+             {
+                 this.InvalidateCacheItem(fileName);",Isn't it quite expensive to check whether the file exists on every write?
+3743,"@@ -165,7 +165,9 @@ webdriver.Builder.prototype.build = function() {
+   } else {
+     var url = this.serverUrl_;
+     var client;
+-    if (url[0] == '/') {
++    if (webdriver.http.CorsClient.isAvailable()) {
++      client = new webdriver.http.XhrClient(url);
++    } else if (url[0] == '/') {
+       var origin = window.location.origin ||
+           (window.location.protocol + '//' + window.location.host);
+       client = new webdriver.http.XhrClient(origin + url);",Please hide this behind a flag and add a setter function to the builder.
+3744,"@@ -1009,6 +1009,7 @@ func (vd *volAPI) Routes() []*Route {
+ 		{verb: ""POST"", path: backupPath(""/restore"", volume.APIVersion), fn: vd.cloudBackupRestore},
+ 		{verb: ""GET"", path: backupPath("""", volume.APIVersion), fn: vd.cloudBackupEnumerate},
+ 		{verb: ""DELETE"", path: backupPath("""", volume.APIVersion), fn: vd.cloudBackupDelete},
++		{verb: ""DELETE"", path: backupPath(""/all"", volume.APIVersion), fn: vd.cloudBackupDeleteAll},
+ 		{verb: ""GET"", path: backupPath(""/status"", volume.APIVersion), fn: vd.cloudBackupStatus},
+ 		{verb: ""GET"", path: backupPath(""/catalog"", volume.APIVersion), fn: vd.cloudBackupCatalog},
+ 		{verb: ""GET"", path: backupPath(""/history"", volume.APIVersion), fn: vd.cloudBackupHistory},",old api should be deprecated if we don't intend on using it anymore. Again this should happen through swagger api and then removed from next release. We should also release not this as a breaking change. (same with all the other cloudsnap api renames.
+3745,"@@ -59,7 +59,7 @@ public class VertxRestTransport extends AbstractTransport {
+     }
+
+     if (!NetUtils.canTcpListen(ep.getSocketAddress().getAddress(), ep.getPort())) {
+-      log.info(""can not listen {}, skip {}."", ep.getSocketAddress(), this.getClass().getName());
++      log.warn(""can not listen {}, port may have been occupied, this may cause client report error when being accessed. skip {}."", ep.getSocketAddress(), this.getClass().getName());
+       return false;
+     }
+ ","so strange...... canTcpListen is to detect, if this transport can init when customers deployed vertx and servlet rest transport, we must detect which one will be used only both of them refused to init is a problem. we have already print that......"
+3746,"@@ -38,6 +38,8 @@ import com.salesforce.androidsdk.util.JSONObjectHelper;
+  */
+ public class QuerySpec {
+ 	private static final String SELECT_COUNT = ""SELECT count(*) "";
++    private static final String SELECT_COUNT_FORM = SELECT_COUNT + "" FROM (%s)"";
++
+ 	// Constants
+ 	private static final String SELECT = ""SELECT  "";
+ 	private static final String FROM = ""FROM "";","Did you mean for this to be `FORM`, instead of `FROM`?"
+3747,"@@ -94,6 +94,13 @@ type AWSMachineSpec struct {
+ 	// +kubebuilder:validation:MaxItems=2
+ 	NetworkInterfaces []string `json:""networkInterfaces,omitempty""`
+
++	// UncompressedUserData specify whether the user data is gzip-compressed before it is sent to ec2 instance.
++	// cloud-init has built-in support for gzip-compressed user data
++	// user data stored in aws secret manager is always gzip-compressed.
++	//
++	// +optional
++	UncompressedUserData *bool `json:""uncompressedUserData,omitempty""`
++
+ 	// CloudInit defines options related to the bootstrapping systems where
+ 	// CloudInit is used.
+ 	// +optional",What are your thoughts on the long term solution for the naming of this variable? Do you think we should revert the logic when we are ready to make the next set of breaking API changes?
+3748,"@@ -92,14 +92,15 @@ module RSpec
+         command = spec_command
+
+         begin
+-          puts command if verbose
++          $stdout.puts(command}) if verbose
+           success = system(command)
+         rescue
+-          puts failure_message if failure_message
++          $stderr.puts failure_message if failure_message
+         end
++
+         if fail_on_error && !success
+-          $stderr.puts ""#{command} failed""
+-          exit $?.exitstatus
++          $stderr.puts(""#{command} failed"") if verbose
++          exit($?.exitstatus)
+         end
+       end
+ ",There's a syntax error on this line.
+3749,"@@ -834,7 +834,7 @@ fpga_result clear_port_errors(fpga_handle afu_handle)
+ 	result = fpgaObjectRead64(port_error_object, &value, 0);
+ 	if (result != FPGA_OK) {
+ 		OPAE_ERR(""Failed to Read Object "");
+-		return result;
++		goto out;
+ 	}
+
+ 	printf(""\n \n Port error CSR : 0x%lx \n"", value);",You lose the value of `result` when you `goto out`
+3750,"@@ -497,8 +497,9 @@ Blockly.Scrollbar.prototype.onScroll_ = function() {
+  * @param {number} value The distance from the top/left end of the bar.
+  */
+ Blockly.Scrollbar.prototype.set = function(value) {
++  var ratio = this.ratio_ == undefined ? 0 : this.ratio_;
+   // Move the scrollbar slider.
+-  this.svgKnob_.setAttribute(this.horizontal_ ? 'x' : 'y', value * this.ratio_);
++  this.svgKnob_.setAttribute(this.horizontal_ ? 'x' : 'y', value * ratio);
+   this.onScroll_();
+ };
+ ","Just a style thing, why not `this.ratio_ || 0`?"
+3751,"@@ -186,7 +186,8 @@ func CIDRFromCalicoNet(ipNet calinet.IPNet) CIDR {
+
+ func CIDRFromIPNet(ipNet *net.IPNet) CIDR {
+ 	ones, _ := ipNet.Mask.Size()
+-	ip := FromNetIP(ipNet.IP)
++	// Mask the IP before creating the CIDR so that we have it in canonical format.
++	ip := FromNetIP(getMaskedIp(ipNet))
+ 	if ip.Version() == 4 {
+ 		return V4CIDR{
+ 			addr:   ip.(V4Addr),","I think the stdlib's `net.IP` has a `Mask()` method, does that do what we need?"
+3752,"@@ -106,9 +106,9 @@ func strOr(s string, ss ...string) string {
+ 	return """"
+ }
+
+-// substitute runs replacer on string elements within a complex data structure
++// Substitute runs replacer on string elements within a complex data structure
+ // (except those contained in private data structure fields).
+-func substitute(v reflect.Value, replacer *strings.Replacer) {
++func Substitute(v reflect.Value, replacer *strings.Replacer) {
+ 	traverseData(v, func(val reflect.Value) dErr {
+ 		switch val.Interface().(type) {
+ 		case string:",Why does substitute need to be public? Are we allowing/encouraging variable usage when using Daisy as a library?
+3753,"@@ -335,6 +335,11 @@ class WebEngineCaret(browsertab.AbstractCaret):
+         """"""
+         if js_elem is None:
+             return
++        if js_elem == ""focused"":
++            # we had a focused element, not a selected one. Just send <enter>
++            self._tab.key_press(Qt.Key_Enter)
++            return
++
+         assert isinstance(js_elem, dict), js_elem
+         elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)
+         if tab:","We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?"
+3754,"@@ -146,7 +146,7 @@ func New(
+
+ 	dynamicCollection := dynamicconfig.NewCollection(params.DynamicConfig, logger)
+
+-	dispatcher := params.RPCFactory.CreateDispatcher()
++	dispatcher := params.RPCFactory.CreateTChannelDispatcher()
+ 	membershipMonitor, err := params.MembershipFactory.Create(dispatcher)
+ 	if err != nil {
+ 		return nil, err",This file looks like anti pattern `ServiceLocator` and lucky it's not used anywhere. Can I remove it? (in separate PR).
+3755,"@@ -466,6 +466,10 @@ public class DatasetUtil {
+      * size for tabular files.
+      */
+     public static String getDownloadSize(DatasetVersion dsv, boolean original) {
++        return FileSizeChecker.bytesToHumanReadable(getDownloadSizeNumeric(dsv, original));
++    }
++
++    public static Long getDownloadSizeNumeric(DatasetVersion dsv, boolean original) {
+         long bytes = 0l;
+         for (FileMetadata fileMetadata : dsv.getFileMetadatas()) {
+             DataFile dataFile = fileMetadata.getDataFile();","we can just have this method call the next, passing in the file metadatas (deduplication of logic)"
+3756,"@@ -480,6 +480,17 @@ class TabBar(QTabBar):
+             new_idx = super().insertTab(idx, icon, '')
+         self.set_page_title(new_idx, text)
+
++    def wheelEvent(self, event):
++        """"""Override wheelEvent to make the action configurable.""""""
++        if config.get('tabs', 'mousewheel-tab-switching'):
++            super().wheelEvent(event)
++        else:
++            tabbed_browser = objreg.get('tabbed-browser', scope='window',
++                                        window=self._win_id)
++            focused_tab = tabbed_browser.currentWidget()
++            if focused_tab is not None:
++                focused_tab.wheelEvent(event)
++
+
+ class TabBarStyle(QCommonStyle):
+ ","What happens here if you send the `wheelEvent` directly to the `tabbed_browser` and let it take care of propagating it to its children (i.e. the focused tab)? If that works, I guess that'd be cleaner."
+3757,"@@ -21,6 +21,10 @@ from .compat import (PANDAS_INSTALLED, DataFrame, Series, is_dtype_sparse,
+ from .libpath import find_lib_path
+
+
++def _log_callback(msg):
++    """"""Redirect logs from native library into Python console""""""
++    print(""{0:s}"".format(decode_string(msg)), end='')
++
+ def _load_lib():
+     """"""Load LightGBM library.""""""
+     lib_path = find_lib_path()",it seems python 2 don't support `end=''`. @StrikerRUS @henry0312 any better solution? or we drop the support of python 2?
+3758,"@@ -4135,6 +4135,12 @@ bool PreCallValidateCreateImageView(layer_data *device_data, const VkImageViewCr
+             }
+         }
+     }
++	else
++	{
++		skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
++                                HandleToUint64(create_info->image), ""VUID-VkImageViewCreateInfo-image-parameter"",
++                                ""vkCreateImageView() image handle is VK_NULL_HANDLE. Image is either not created or it is destroyed at this point."");
++	}
+     return skip;
+ }
+ ",This test already exists in the object_tracker layer.
+3759,"@@ -64,7 +64,8 @@ public class EthGetCode extends AbstractBlockParameterOrBlockHashMethod {
+   @Override
+   protected String resultByBlockHash(final JsonRpcRequestContext request, final Hash blockHash) {
+     final Address address = request.getRequiredParameter(0, Address.class);
+-    if (GoQuorumOptions.goQuorumCompatibilityMode && privacyParameters.isPresent()) {
++    final boolean isGoQuorumCompatibilityMode = GoQuorumOptions.goQuorumCompatibilityMode;
++    if (isGoQuorumCompatibilityMode && privacyParameters.isPresent()) {
+       // get from private state if we can
+       final Optional<BlockHeader> blockHeader =
+           blockchainQueries.get().getBlockHeaderByHash(blockHash);","Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?"
+3760,"@@ -122,6 +122,10 @@ class FastAppend extends SnapshotProducer<AppendFiles> implements AppendFiles {
+   public List<ManifestFile> apply(TableMetadata base) {
+     List<ManifestFile> newManifests = Lists.newArrayList();
+
++    if (base.currentSnapshot() != null) {
++      newManifests.addAll(base.currentSnapshot().deleteManifests());
++    }
++
+     try {
+       ManifestFile manifest = writeManifest();
+       if (manifest != null) {",The addition of delete files in `newManifests` far above the addition of data files threw me a bit. Is it intentional to ensure the delete files are at the front of the list?
+3761,"@@ -68,7 +68,7 @@ module Bolt
+         # though, since that will resolve any nested references and we want to
+         # leave it to the group to do that lazily.
+         groups = @plugins.resolve_top_level_references(groups)
+-
++        raise ValidationError.new(""Groups must be an Array"", nil) unless groups.is_a?(Array)
+         @groups = Array(groups).map { |g| Group.new(g, plugins) }
+       end
+ ",Interesting. The call to `Array(groups)` below this would seem to indicate this doesn't _have_ to be an array. I think the problem is actually that passing a hash to `Array()` actually converts the hash to an array of key/value pairs rather than wrapping it in an array. So maybe `Array(groups)` should be `groups = [groups] unless groups.is_a?(Array)`.
+3762,"@@ -140,4 +140,10 @@ public class TableProperties {
+
+   public static final String GC_ENABLED = ""gc.enabled"";
+   public static final boolean GC_ENABLED_DEFAULT = true;
++
++  public static final String MAX_SNAPSHOT_AGE_MS = ""history.expire.max-snapshot-age-ms"";
++  public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days
++
++  public static final String RETAIN_MIN_NUM_SNAPSHOTS = ""history.expire.retain-min-num-snapshots"";
++  public static final int RETAIN_MIN_NUM_SNAPSHOTS_DEFAULT = 1;
+ }",This is not a particularly good default but we need it to keep the old behavior.
+3763,"@@ -117,13 +117,6 @@ func TestPaymentBrokerRedeemWithCondition(t *testing.T) {
+ 	blockHeightParam := types.NewBlockHeight(43)
+ 	redeemerParams := []interface{}{blockHeightParam}
+
+-	sys := setup(t)
+-	require.NoError(t, sys.st.SetActor(context.TODO(), toAddress, actor.NewActor(pbTestActorCid, types.NewZeroAttoFIL())))
+-
+-	callRedeem := func(condition *types.Predicate, params []interface{}) (*consensus.ApplicationResult, error) {
+-		return sys.applySignatureMessage(sys.target, 100, types.NewBlockHeight(0), 0, ""redeem"", 0, condition, params...)
+-	}
+-
+ 	// All the following tests attempt to call PBTestActor.ParamsNotZero with a condition.
+ 	// PBTestActor.ParamsNotZero takes 3 parameter: an Address, a uint64 sector id, and a BlockHeight
+ 	// If any of these are zero values the method throws an error indicating the condition is false.",We have other tests to assert all properties of a condition are valid. It's enough to assert the condition is not nil here.
+3764,"@@ -30,7 +30,7 @@ import (
+
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/config""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/openflow""
+-	opsv1alpha1 ""github.com/vmware-tanzu/antrea/pkg/apis/ops/v1alpha1""
++	opsv1alpha1 ""github.com/vmware-tanzu/antrea/pkg/apis/crd/v1alpha1""
+ 	binding ""github.com/vmware-tanzu/antrea/pkg/ovs/openflow""
+ )
+ ",shouldn't the import be renamed `crdv1alpha1` by convention? It seems that you took care of renaming everywhere else...
+3765,"@@ -86,6 +86,19 @@ const (
+
+ 	// DefaultMinSupportedCNIVersion denotes the minimum version of cni spec required
+ 	DefaultMinSupportedCNIVersion = ""0.3.0""
++
++	// pauseContainerTarball is the path to the pause container tarball
++	pauseContainerTarballPath = ""/images/amazon-ecs-pause.tar""
++)
++
++var (
++	// PauseContainerTag is the tag for the pause container image. The linker's load
++	// flags are used to populate this value from the Makefile
++	PauseContainerTag = """"
++
++	// PauseContainerImageName is the name of the pause container image. The linker's
++	// load flags are used to populate this value from the Makefile
++	PauseContainerImageName = """"
+ )
+
+ // Merge merges two config files, preferring the ones on the left. Any nil or",nit: Can Linux-specific paths be moved to a conditionally-compiled file for Linux?
+3766,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+
+   public abstract void remove(SessionId id);
+
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.
+3767,"@@ -279,8 +279,10 @@ func (r *runner) waitForJournal(ctx context.Context) error {
+ // unrecognized attributes are ignored. The list ends with a blank
+ // line.
+ func (r *runner) handleList(ctx context.Context, args []string) (err error) {
+-	if len(args) > 0 {
+-		return errors.New(""Lists for non-fetches unsupported for now"")
++	if len(args) == 1 && args[0] == ""for-push"" {
++		r.log.CDebugf(ctx, ""Treating for-push the same as a regular list"")
++	} else if len(args) > 0 {
++		return errors.Errorf(""Bad list request: %v"", args)
+ 	}
+
+ 	repo, err := r.initRepoIfNeeded(ctx)",Git doc seems to suggest `for-push` is a optimization. Do we have a plan/ticket for treating them differently?
+3768,"@@ -449,7 +449,8 @@ debug_tls:When 1, print some TLS session secrets when they are computed.
+                    ""mobileip"", ""netbios"", ""netflow"", ""ntp"", ""ppp"", ""pptp"",
+                    ""radius"", ""rip"", ""rtp"", ""skinny"", ""smb"", ""snmp"",
+                    ""tftp"", ""x509"", ""bluetooth"", ""dhcp6"", ""llmnr"",
+-                   ""sctp"", ""vrrp"", ""ipsec"", ""lltd"", ""vxlan"", ""eap""]
++                   ""sctp"", ""vrrp"", ""ipsec"", ""lltd"", ""vxlan"", ""eap"",
++                   ""ltp"", ""bp""]
+     contribs = dict()
+     crypto_valid = isCryptographyValid()
+     crypto_valid_advanced = isCryptographyAdvanced()",This not necessary since you moved the layers to `contrib/`.
+3769,"@@ -1088,7 +1088,7 @@ module Bolt
+       end
+       define('--log-level LEVEL',
+              ""Set the log level for the console. Available options are"",
+-             ""trace, debug, info, warn, error, fatal, any."") do |level|
++             ""trace, debug, info, warn, error, fatal."") do |level|
+         @options[:log] = { 'console' => { 'level' => level } }
+       end
+       define('--clear-cache',","I think this also needs to be removed from `resources/bolt_bash_completion.sh`, `rakelib/pwsh.rake`, `lib/bolt_spec/plans.rb`, and `lib/bolt/config/options.rb`."
+3770,"@@ -63,7 +63,7 @@ describe 'PasswordResetsController' do
+       account.update_attribute(:email, 'ThisIsMyAddress@MyDomain.com')
+
+       assert_difference(['ActionMailer::Base.deliveries.size'], 1) do
+-        post :create, password_reset: {email: account.email.downcase}
++        post :create, password_reset: { email: account.email.downcase }
+       end
+       must_respond_with :redirect
+       flash[:success].must_equal I18n.t('password_resets.create.success')",I fixed this today with a direct push to master. My build was failing otherwise.
+3771,"@@ -0,0 +1,16 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.autofix.rule;
++
++import net.sourceforge.pmd.autofix.RuleViolationFix;
++import net.sourceforge.pmd.lang.ast.Node;
++
++public class DeleteRuleViolationFix implements RuleViolationFix {
++
++    @Override
++    public void applyFixesToNode(final Node node) {
++        node.remove();
++    }
++}","not sure why this is in a ""rule"" child package from the interface..."
+3772,"@@ -19,12 +19,14 @@ class Folder extends BaseItem {
+ 		return {
+ 			id: null,
+ 			title: '',
++			icon: '',
+ 		};
+ 	}
+
+ 	static fieldToLabel(field) {
+ 		const fieldsToLabels = {
+ 			title: _('title'),
++			icon: _('icon'),
+ 			last_note_user_updated_time: _('updated date'),
+ 		};
+ ","Not needed, please remove."
+3773,"@@ -66,7 +66,7 @@ static h2o_iovec_t rewrite_location(h2o_mem_pool_t *pool, const char *location,
+         goto NoRewrite;
+     if (loc_parsed.scheme != &H2O_URL_SCHEME_HTTP)
+         goto NoRewrite;
+-    if (!h2o_lcstris(loc_parsed.host.base, loc_parsed.host.len, match->host.base, match->host.len))
++    if (!h2o_url_compare_hosts(loc_parsed.host, match->host, match->host_is_unix_path))
+         goto NoRewrite;
+     if (h2o_url_get_port(&loc_parsed) != h2o_url_get_port(match))
+         goto NoRewrite;","Shouldn't the logic be: * the result is a mismatch if either is a unix path but the other is not * if both are unix paths, then perform case-sensitive comparison * if both are not unix paths, then perform case-insensitive comparison"
+3774,"@@ -11,6 +11,6 @@ import (
+ 	_ ""github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway""
+ 	_ ""github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2""
+ 	_ ""github.com/shurcooL/vfsgen""
+-	_ ""google.golang.org/protobuf/cmd/protoc-gen-go""
+ 	_ ""google.golang.org/grpc/cmd/protoc-gen-go-grpc""
++	_ ""google.golang.org/protobuf/cmd/protoc-gen-go""
+ )",This is just rearranging it alphabetically
+3775,"@@ -798,6 +798,7 @@ def test_chromium_version_unpatched(qapp):
+     assert version._chromium_version() not in ['', 'unknown', 'unavailable']
+
+
++# pylint: disable=too-many-locals
+ @pytest.mark.parametrize(['git_commit', 'frozen', 'style', 'with_webkit',
+                           'known_distribution'], [
+     (True, False, True, True, True),  # normal",I think this disables it for the rest of the file - you should be able to use it inside of the function instead.
+3776,"@@ -61,9 +61,9 @@ final class MediaExtension extends AbstractExtension
+     }
+
+     /**
+-     * @param MediaInterface $media
+-     * @param string         $format
+-     * @param array          $options
++     * @param MediaInterface|int|string $media
++     * @param string                    $format
++     * @param array                     $options
+      *
+      * @return string
+      */","this could receive the MediaInterface directly or an identifier, it is correct to type it with int|string? or just use mixed?"
+3777,"@@ -89,4 +89,15 @@ final class MultiLeafFieldComparator implements LeafFieldComparator {
+     }
+   }
+
++  @Override
++  public Object leafValue(int docID) throws IOException {
++    Object[] valuesArray = new Object[comparators.length];
++
++    for (int i = 0; i < comparators.length; i++) {
++      valuesArray[i] = comparators[i].leafValue(docID);
++    }
++
++    return valuesArray;
++  }
++
+ }",Why not return `Object[]`?
+3778,"@@ -46,12 +46,14 @@ public class GenericManifestFile
+   private String manifestPath = null;
+   private Long length = null;
+   private int specId = -1;
++  private long sequenceNumber = 0;
++  private long minSequenceNumber = 0;
+   private Long snapshotId = null;
+   private Integer addedFilesCount = null;
+-  private Long addedRowsCount = null;
+   private Integer existingFilesCount = null;
+-  private Long existingRowsCount = null;
+   private Integer deletedFilesCount = null;
++  private Long addedRowsCount = null;
++  private Long existingRowsCount = null;
+   private Long deletedRowsCount = null;
+   private List<PartitionFieldSummary> partitions = null;
+ ","Looks like we are trying to match the new ordering of fields in `ManifestFile`. Earlier, we co-located `...FilesCount` with `...RowsCount` to match the ordering of methods in `ManifestFile` and args in constructors. Is this change intentional?"
+3779,"@@ -933,11 +933,13 @@ void Monster::onThinkDefense(uint32_t interval)
+ 			Monster* summon = Monster::createMonster(summonBlock.name);
+ 			if (summon) {
+ 				const Position& summonPos = getPosition();
+-
+-				addSummon(summon);
+-
++				summon->setDropLoot(false);
++				summon->setLossSkill(false);
++				summon->setMaster(this);
+ 				if (!g_game.placeCreature(summon, summonPos, false, summonBlock.force)) {
+-					removeSummon(summon);
++					summon->setDropLoot(false);
++					summon->setLossSkill(true);
++					summon->setMaster(nullptr);
+ 				} else {
+ 					g_game.addMagicEffect(getPosition(), CONST_ME_MAGIC_BLUE);
+ 					g_game.addMagicEffect(summon->getPosition(), CONST_ME_TELEPORT);",You're already setting drop loot to false just above.
+3780,"@@ -20,6 +20,7 @@ type Management struct {
+
+ 	listenerShutdownStarted chan bool
+ 	listenerShutdownWaiter  sync.WaitGroup
++	once                    sync.Once
+ }
+
+ type ManagementMiddleware interface {",`once` is very generic and doesn't specify it's purpose - `closeOnce`?
+3781,"@@ -79,7 +79,7 @@ public class HiveTableBaseTest extends HiveMetastoreTest {
+     return getTableLocationPath(tableName).toString();
+   }
+
+-  private static String metadataLocation(String tableName) {
++  protected static String metadataLocation(String tableName) {
+     return Paths.get(getTableBasePath(tableName), ""metadata"").toString();
+   }
+ ",Why did this need to change from `private`? Oh for the test below. And this is only a test class too.
+3782,"@@ -0,0 +1,7 @@
++require 'test_helper'
++
++class NotificationAcknowledgementTest < ActiveSupport::TestCase
++  # test ""the truth"" do
++  #   assert true
++  # end
++end",Should test the `has?` method here
+3783,"@@ -78,7 +78,18 @@ final class SavedSearchesTest extends \VuFindTest\Integration\MinkTestCase
+     public function testSaveSearch()
+     {
+         $page = $this->performSearch('test');
+-        $this->clickCss($page, '.fa.fa-save');
++        $links = $page->findAll('css', '.searchtools a');
++        $saveLink = null;
++        foreach ($links as $link) {
++            if ($this->checkVisibility($link)
++                && str_contains($link->getHtml(), 'Save Search')
++            ) {
++                $saveLink = $link;
++                break;
++            }
++        }
++        $this->assertNotNull($link);
++        $link->click();
+         $this->snooze();
+         $this->clickCss($page, '.createAccountLink');
+         $this->snooze();","I think you want to be asserting/clicking $saveLink, not $link."
+3784,"@@ -95,6 +95,7 @@ def sensor(
+ def asset_sensor(
+     asset_key: AssetKey,
+     pipeline_name: Optional[str] = None,
++    target_name: Optional[str] = None,
+     name: Optional[str] = None,
+     solid_selection: Optional[List[str]] = None,
+     mode: Optional[str] = None,","We don't have `target_name` on `@sensor` - why introduce it for `@asset_sensor`? If we do want to introduce it everywhere, can we just call it `job_name` to avoid introducing a new term?"
+3785,"@@ -0,0 +1,9 @@
++using System.Collections.Generic;
++
++namespace Microsoft.DotNet.Build.Tasks.Feed
++{
++    public class SleetSettings
++    {
++        public List<SleetSource> Sources { get; set; }
++    }
++}",Missing copyright header (+other new files).
+3786,"@@ -104,12 +104,7 @@ class TypeToSparkType extends TypeUtil.SchemaVisitor<DataType> {
+         throw new UnsupportedOperationException(
+             ""Spark does not support time fields"");
+       case TIMESTAMP:
+-        Types.TimestampType timestamp = (Types.TimestampType) primitive;
+-        if (timestamp.shouldAdjustToUTC()) {
+-          return TimestampType$.MODULE$;
+-        }
+-        throw new UnsupportedOperationException(
+-            ""Spark does not support timestamp without time zone fields"");
++        return TimestampType$.MODULE$;
+       case STRING:
+         return StringType$.MODULE$;
+       case UUID:","Could we do the flag check here as well to check whether or not we have enabled the ""Handle without timezone"" flag here as well? We may be using this not on the read path (like in the migrate/snapshot code) and it would be good to catch it here as well and make sure users know what is happening."
+3787,"@@ -2,7 +2,7 @@ import os
+ from typing import Dict, List
+
+ from dagster import SensorDefinition
+-from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext
++from dagster.core.definitions.pipeline_definition_definition_sensor import PipelineFailureSensorContext
+ from dagster_slack import make_slack_on_pipeline_failure_sensor
+ from hacker_news_assets.utils.slack_message import build_slack_message_blocks
+ ",why is the file named `pipeline_definition_definition_sensor`?
+3788,"@@ -6,6 +6,10 @@ _ts = None
+
+ def init_timescale_connection(logger, conf):
+     global _ts
++
++    if not conf[""SQLALCHEMY_TIMESCALE_URI""]:
++        return None
++
+     while True:
+         try:
+             _ts = TimescaleListenStore(conf, logger)","None not needed, can just be `return`. not important for this release"
+3789,"@@ -104,7 +104,12 @@ const topPageTemplate = `
+     <div class=""g-recaptcha"" data-sitekey=""{{.RecaptchaSiteKey}}"">
+     </div>
+     <div>
+-      <input id=""target"" placeholder=""target address"">
++      The dispensed Algos have no monetary value and should only be used to test applications.
++      <p>This service is gracefully provided to enable development on the Algorand blockchain test networks.
++      <p>Please do not abuse it by requesting millions of Algos.
++    </div>
++    <div>
++      <input id=""target"" placeholder=""target address"" size=""80"">
+       <button id=""dispense"">Dispense</button>
+     </div>
+     <div>",I think it's missing closing `</p>` tags in line 108 and 109 unless they don't matter...
+3790,"@@ -579,10 +579,12 @@ public abstract class ProcessEngineConfigurationImpl extends ProcessEngineConfig
+   protected ScriptingEnvironment scriptingEnvironment;
+   protected List<ScriptEnvResolver> scriptEnvResolvers;
+   protected ScriptFactory scriptFactory;
++  protected String scriptEngineNameJavaScript;
+   protected boolean autoStoreScriptVariables = false;
+   protected boolean enableScriptCompilation = true;
+   protected boolean enableScriptEngineCaching = true;
+   protected boolean enableFetchScriptEngineFromProcessApplication = true;
++  protected boolean enableScriptEngineLoadExternalResources = false;
+
+   /**
+    * When set to false, the following behavior changes:",So it seems that loading a script file from the classpath needs to be enabled explicitly now since this is `false` by default. Is it possible to enable this via the YAML config file in a Camunda Platform Run distribution?
+3791,"@@ -5,8 +5,7 @@
+ const config = require('@purest/providers')
+ const dropbox = require('./dropbox')
+ const drive = require('./drive')
+-const instagram = require('./instagram')
+-const instagramGraph = require('./instagram/graph')
++const instagram = require('./instagram/graph')
+ const facebook = require('./facebook')
+ const onedrive = require('./onedrive')
+ const zoom = require('./zoom')",can we delete any code in the provider implementation? i imagine the entire thing is unused now?
+3792,"@@ -148,6 +148,7 @@ func wrapErrorWithClusterIssuerStatusCondition(client clientset.ClusterIssuerInt
+
+ // WaitForCertificateCondition waits for the status of the named Certificate to contain
+ // a condition whose type and status matches the supplied one.
++// Deprecated: this function is not used anymore
+ func WaitForCertificateCondition(client clientset.CertificateInterface, name string, condition v1.CertificateCondition, timeout time.Duration) (*v1.Certificate, error) {
+ 	var certificate *v1.Certificate = nil
+ 	pollErr := wait.PollImmediate(500*time.Millisecond, timeout,",I suggest we remove all these unused functions. I don't expect any external projects to be importing packages from `cert-manager/test/...`
+3793,"@@ -150,15 +150,10 @@ void DataManWriter::MetadataThread(const std::string &address)
+     while (m_Listening)
+     {
+         auto request = tpm.ReceiveRequest();
+-        if (request == nullptr)
++        if (request && request->size() > 0)
+         {
+-            continue;
+-        }
+-        if (request->size() >= 0)
+-        {
+-            m_AggregatedMetadataMutex.lock();
++            std::lock_guard lck(m_AggregatedMetadataMutex);
+             tpm.SendReply(m_AggregatedMetadata);
+-            m_AggregatedMetadataMutex.unlock();
+         }
+     }
+ }",Looks like the template argument doesn't resolve by default so you need `std::lock_guard<std::mutex> lck`
+3794,"@@ -128,12 +128,6 @@ public final class ArrayCreationLevel extends Node implements NodeWithAnnotation
+         return this;
+     }
+
+-    @Override
+-    @Generated(""com.github.javaparser.generator.core.node.GetNodeListsGenerator"")
+-    public List<NodeList<?>> getNodeLists() {
+-        return Arrays.asList(getAnnotations());
+-    }
+-
+     @Generated(""com.github.javaparser.generator.core.node.RemoveMethodGenerator"")
+     public ArrayCreationLevel removeDimension() {
+         return setDimension((Expression) null);",Are we removing this public method? Could it be useful to someone? Maybe we could implement it once in Node using the metamodel
+3795,"@@ -47,6 +47,10 @@ class Plan < ActiveRecord::Base
+     self == self.class.popular
+   end
+
++  def includes_exercises?
++    sku != THE_WEEKLY_ITERATION_SKU
++  end
++
+   def subscription_interval
+     stripe_plan.interval
+   end",I think this method is unused now?
+3796,"@@ -115,6 +115,11 @@ func run(o *Options) error {
+ 		appliedToGroupStore,
+ 		networkPolicyStore)
+
++	var networkPolicyStatusController *networkpolicy.StatusController
++	if features.DefaultFeatureGate.Enabled(features.AntreaPolicy) {
++		networkPolicyStatusController = networkpolicy.NewStatusController(crdClient, networkPolicyStore, cnpInformer, anpInformer)
++	}
++
+ 	endpointQuerier := networkpolicy.NewEndpointQuerier(networkPolicyController)
+
+ 	controllerQuerier := querier.NewControllerQuerier(networkPolicyController, o.config.APIPort)",I know we discussed this before and decided to reuse the AntreaPolicy gate. But do you think realization status will introduce much overhead or not?
+3797,"@@ -0,0 +1,11 @@
++package constants
++
++const (
++	RunController = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/cloud/; sudo nohup ./edgecontroller > edgecontroller.log 2>&1 &""
++	RunEdgecore   = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/edge/; sudo nohup ./edge_core > edge_core.log 2>&1 &""
++	RunEdgeSite   = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/edgesite/; sudo nohup ./edgesite > edgesite.log 2>&1 &""
++
++	AppHandler        = ""/api/v1/namespaces/default/pods""
++	NodeHandler       = ""/api/v1/nodes""
++	DeploymentHandler = ""/apis/apps/v1/namespaces/default/deployments""
++)",please add a blank line at the end of this file. Applicable to similar cases below
+3798,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression."
+3799,"@@ -588,6 +588,10 @@ class JoinQuery extends Query {
+             // use the filterCache to get a DocSet
+             if (toTermsEnum.docFreq() >= minDocFreqTo || resultBits == null) {
+               // use filter cache
++              if (! toSearcher.getFilterCache().isAsync()) {
++                throw new SolrException(SolrException.ErrorCode.INVALID_STATE,
++                    ""Using join queries with synchronous filterCache is not supported! Details can be found in Solr Reference Guide under 'query-settings-in-solrconfig'."");
++              }
+               DocSet toTermSet = toSearcher.getDocSet(toDeState);
+               resultListDocs += toTermSet.size();
+               if (resultBits != null) {",filterCache can be null
+3800,"@@ -10,6 +10,7 @@ import (
+ 	""bytes""
+ 	""context""
+ 	""encoding/hex""
++	""github.com/iotexproject/iotex-core/db""
+ 	""sync""
+ 	""time""
+ ",File is not `goimports`-ed (from `goimports`)
+3801,"@@ -375,6 +375,8 @@ const char *get_parameter(char *cmd, SERVER_CONN *server_conn) {
+ const char *set_parameter(char *cmd, SERVER_CONN *server_conn, CLIENT_CONN *client_conn) {
+     const char *param_name = strstr(cmd, SET_PARAM_CMD) + SET_PARAM_CMD_LEN;
+     const char *param_value;
++    if (!param_name)
++	return SET_PARAM_CMD_FAIL_RSP;
+     if (strstr(param_name, SERVER_LOOPBACK_MODE_PARAM) == param_name) {
+         param_value = param_name + SERVER_LOOPBACK_MODE_PARAM_LEN;
+         if (strnlen(param_value, 1) == 1) {","If strstr returns NULL, the check on 378 won't fire, because param_name will be at least SET_PARAM_CMD_LEN."
+3802,"@@ -47,13 +47,12 @@ services::Status buildProgram(ClKernelFactoryIface & kernelFactory, const TypeId
+     return status;
+ }
+
+-services::Status sum_singlepass(ExecutionContextIface & context, ClKernelFactoryIface & kernelFactory, Layout vectorsLayout,
+-                                const UniversalBuffer & vectors, uint32_t nVectors, uint32_t vectorSize, uint32_t workItemsPerGroup,
+-                                SumReducer::Result & result)
++services::Status sum_singlepass(ExecutionContextIface & context, ClKernelFactoryIface & kernelFactory, const UniversalBuffer & vectors,
++                                uint32_t nVectors, uint32_t vectorSize, SumReducer::Result & result)
+ {
+     services::Status status;
+
+-    auto sum_kernel = kernelFactory.getKernel(""sum_singlepass"", status);
++    auto sum_kernel = kernelFactory.getKernel(""sum_singlesubgroup"", status);
+     DAAL_CHECK_STATUS_VAR(status);
+
+     // no need to check overflow for nVectors * vectorSize due to we already have buffer vectors of such size","Does this change affect the performance of other algorithms, except KMeans?"
+3803,"@@ -142,13 +142,13 @@ func TestListenerAddrEqual(t *testing.T) {
+ 		addr   string
+ 		expect bool
+ 	}{
+-		{ln1, "":1234"", false},
+-		{ln1, ""0.0.0.0:1234"", false},
++		{ln1, "":"" + ln2port, false},
++		{ln1, ""0.0.0.0:"" + ln2port, false},
+ 		{ln1, ""0.0.0.0"", false},
+ 		{ln1, "":"" + ln1port, true},
+ 		{ln1, ""0.0.0.0:"" + ln1port, true},
+ 		{ln2, "":"" + ln2port, false},
+-		{ln2, ""127.0.0.1:1234"", false},
++		{ln2, ""127.0.0.1:"" + ln1port, false},
+ 		{ln2, ""127.0.0.1"", false},
+ 		{ln2, ""127.0.0.1:"" + ln2port, true},
+ 	} {",What do these changes have to do with the request ID?
+3804,"@@ -48,11 +48,11 @@
+ #include <cstdio>
+ #include <cstdlib>
+
+-typedef Kokkos::DefaultExecutionSpace Device;
+-typedef Kokkos::HostSpace::execution_space Host;
++using Device = Kokkos::DefaultExecutionSpace;
++using Host   = Kokkos::HostSpace::execution_space;
+
+-typedef Kokkos::TeamPolicy<Device> team_policy;
+-typedef team_policy::member_type team_member;
++using team_policy = Kokkos::TeamPolicy<Device>;
++using team_member = team_policy::member_type;
+
+ static const int TEAM_SIZE = 16;
+ ",I'm kind of surprised this doesn't require `typename`?
+3805,"@@ -17,6 +17,7 @@
+ package agreement
+
+ import (
++	""github.com/algorand/go-algorand/logging""
+ 	""time""
+
+ 	""github.com/algorand/go-algorand/config""",nit: move this one down.
+3806,"@@ -137,8 +137,14 @@ class Bars(Chart):
+
+ class BoxWhisker(Chart):
+     """"""
+-    BoxWhisker represent data as a distributions highlighting
+-    the median, mean and various percentiles.
++    BoxWhisker allows representing the distribution of data grouped
++    into one or more groups by summarizing the data using quartiles.
++    The boxes of a BoxWhisker element represent the first, second and
++    third quartiles. The whiskers follow the Tukey boxplot definition
++    representing the lowest datum still within 1.5 IQR of the lower
++    quartile, and the highest datum still within 1.5 IQR of the upper
++    quartile. Any points falling outside this range are shown as
++    distinct outlier points.
+     """"""
+
+     group = param.String(default='BoxWhisker', constant=True)",maybe 'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just *a* definition for boxplots...
+3807,"@@ -55,9 +55,11 @@ var (
+ 	// NOTE: The $Format strings are replaced during 'git archive' thanks to the
+ 	// companion .gitattributes file containing 'export-subst' in this same
+ 	// directory.  See also https://git-scm.com/docs/gitattributes
+-	gitVersion   = ""v0.0.0-master+$Format:%h$""
++	gitVersion   = Default
+ 	gitCommit    = ""$Format:%H$"" // sha1 from git, output of $(git rev-parse HEAD)
+ 	gitTreeState = """"            // state of git tree, either ""clean"" or ""dirty""
+
+ 	buildDate = ""1970-01-01T00:00:00Z"" // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ')
+ )
++
++const Default = ""v1.9.0""",I feel we should not fix this.
+3808,"@@ -25,9 +25,9 @@
+ #include <fastdds/rtps/reader/RTPSReader.h>
+ #include <fastdds/rtps/writer/RTPSWriter.h>
+
+-#include <fastdds/rtps/transport/UDPv4Transport.h>
+-#include <fastdds/rtps/transport/UDPv6Transport.h>
+-#include <fastdds/rtps/transport/test_UDPv4Transport.h>
++#include <rtps/transport/UDPv4Transport.h>
++#include <rtps/transport/UDPv6Transport.h>
++#include <rtps/transport/test_UDPv4Transport.h>
+
+ #include <fastrtps/xmlparser/XMLProfileManager.h>
+ ",I think these are not necessary
+3809,"@@ -476,7 +476,8 @@ Cross-TU analysis. By default, no CTU analysis is run when
+                               action='store_true',
+                               dest='ctu_reanalyze_on_failure',
+                               default=argparse.SUPPRESS,
+-                              help=""If Cross-TU analysis is enabled and fails ""
++                              help=""DEPRECATED. The flag will be removed. ""
++                                   ""If Cross-TU analysis is enabled and fails ""
+                                    ""for some reason, try to re analyze the ""
+                                    ""same translation unit without ""
+                                    ""Cross-TU enabled."")",Please update the user guide too.
+3810,"@@ -459,8 +459,9 @@ class Folio extends AbstractAPI implements
+             foreach ($this->getPagedResults(
+                 'locations', '/locations'
+             ) as $location) {
+-                $locationMap[$location->id]
+-                    = $location->discoveryDisplayName ?? $location->name;
++                $name = $location->discoveryDisplayName ?? $location->name;
++                $code = $location->code;
++                $locationMap[$location->id] = [$name, $code];
+             }
+         }
+         $this->putCachedData($cacheKey, $locationMap);","If you use `compact('name', 'code')` here, you'll get an associative array, which might make the rest of the code more readable (instead of using hard-coded 0/1 indexes)."
+3811,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright (c) 2011, salesforce.com, inc.
++ * Copyright (c) 2014, salesforce.com, inc.
+  * All rights reserved.
+  * Redistribution and use of this software in source and binary forms, with or
+  * without modification, are permitted provided that the following conditions",Should it be 2011-14 instead ;-)
+3812,"@@ -51,6 +51,10 @@ func New(cfg *any.Any, logger *zap.Logger, scope tally.Scope) (service.Service,
+ 		return nil, err
+ 	}
+
++	if pgcfg.MaxIdleConnections > 2 {
++		sqlDB.SetMaxIdleConns(int(pgcfg.MaxIdleConnections))
++	}
++
+ 	return &client{logger: logger, scope: scope, sqlDB: sqlDB}, nil
+ }
+ ",I want to write some type of test for this but there are not Getter methods to assert this value. I tried to extract the value via the stats that are exposed without luck.
+3813,"@@ -574,6 +574,15 @@ class ApiClient(object):
+             group_key (str): key of the group to get.
+         """"""
+
++    @abc.abstractmethod
++    def iter_gsuite_group_settings(self, gsuite_id):
++        """"""Iterate Gsuite group settings from GCP API.
++
++        Args:
++            gsuite_id (str): Gsuite id.
++        """"""
++
++
+     @abc.abstractmethod
+     def iter_gsuite_groups(self, gsuite_id):
+         """"""Iterate Gsuite groups from GCP API.","This needs to take the group id, not the gsuite id."
+3814,"@@ -47,8 +47,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+         }
+
+         private const string EmptyResult = @""{
+-  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0-beta.5"""",
+-  """"version"""": """"1.0.0-beta.5"""",
++  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0"""",
++  """"version"""": """"1.0.0"""",
+   """"runs"""": [
+     {
+       """"tool"""": {",These should use the constants defined in JsonTests.cs
+3815,"@@ -67,7 +67,7 @@ function DashboardClicksWidget() {
+
+ 	if ( error ) {
+ 		trackEvent( 'plugin_setup', 'search_console_error', error.message );
+-		return getDataErrorComponent( __( 'Search Console', 'google-site-kit' ), error.message );
++		return getDataErrorComponent( 'search-console', error );
+ 	}
+
+ 	if ( ! data || ! data.length ) {","Kind of unrelated to this PR, but let's update this to `getDataErrorComponent( 'search-console', error.message, false, false, false, error )` so that everything is passed as expected."
+3816,"@@ -38,6 +38,15 @@ class LoadImageFromFile(object):
+         self.file_client = None
+
+     def __call__(self, results):
++        """"""Call functions to load image and get image meta information.
++
++        Args:
++            results (dict): Result dict from :obj:`dataset`.
++
++        Returns:
++            dict: The dict contains loaded image and meta information.
++        """"""
++
+         if self.file_client is None:
+             self.file_client = mmcv.FileClient(**self.file_client_args)
+ ",:obj:\`dataset\` cannot be correctly rendered
+3817,"@@ -28,4 +28,10 @@ module Blacklight::User
+   def existing_bookmark_for(document)
+     bookmarks_for_documents([document]).first
+   end
++
++  ##
++  # @return [String] a user-displayable login/identifier for the user account
++  def to_s
++    email
++  end
+ end","I think `email` is something we get from devise, and I think the goal of putting it in the generator was not to tie others to that particular implementation?"
+3818,"@@ -108,15 +108,16 @@ func NewBatchSpanProcessor(e export.SpanBatcher, opts ...BatchSpanProcessorOptio
+ 	bsp.stopWait.Add(1)
+ 	go func(ctx context.Context) {
+ 		defer ticker.Stop()
++		batch := make([]*export.SpanData, 0, bsp.o.MaxExportBatchSize)
+ 		for {
+ 			select {
+ 			case <-bsp.stopCh:
+-				bsp.processQueue()
++				bsp.processQueue(&batch)
+ 				close(bsp.queue)
+ 				bsp.stopWait.Done()
+ 				return
+ 			case <-ticker.C:
+-				bsp.processQueue()
++				bsp.processQueue(&batch)
+ 			}
+ 		}
+ 	}(context.Background())","If the span producers pushing to the queue do so faster than the this can drain, it will cause this to hang. I'm guessing we can update the `enqueue` method to check if the `stopCh` is closed and not send any more spans while this flushes what has already been pushed."
+3819,"@@ -106,9 +106,9 @@ abstract class Gallery implements GalleryInterface
+         return $this->defaultFormat;
+     }
+
+-    final public function setGalleryItems(Collection $galleryItems): void
++    final public function setGalleryItems(iterable $galleryItems): void
+     {
+-        $this->galleryItems = new ArrayCollection();
++        $this->galleryItems->clear();
+
+         foreach ($galleryItems as $galleryItem) {
+             $this->addGalleryItem($galleryItem);","Not sure about that, an array is iterable right? But if I pass array, that clear method wont work"
+3820,"@@ -6,9 +6,14 @@ import (
+ 	""crypto/x509""
+ 	""crypto/x509/pkix""
+ 	""encoding/pem""
++	""fmt""
++	""io/ioutil""
++	""path/filepath""
++	""sync""
+ 	""testing""
+
+-	""github.com/spiffe/sri/pkg/server/ca""
++	""github.com/spiffe/go-spiffe""
++	iface ""github.com/spiffe/sri/pkg/common/plugin""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ ","make sure the config changes stuck. are there any invalid config values? maybe write tests around empty `trust_domain`, negative/missing `ttl`, invalid `key_size`, etc..."
+3821,"@@ -5,7 +5,7 @@ var WebDriver = require('selenium-webdriver');
+
+ module.exports = function(grunt) {
+ 	/**
+-	 * Keep injecting scripts until window.mochaResults is set
++	 * Keep injecting scripts until `window.__mochaResult__` is set
+ 	 */
+ 	function collectTestResults(driver) {
+ 		// inject a script that waits half a second",Why are you changing this?
+3822,"@@ -29,6 +29,10 @@ module Ncr
+     validates :expense_type, inclusion: {in: EXPENSE_TYPES}, presence: true
+     validates :vendor, presence: true
+     validates :building_number, presence: true
++    validates :rwa_number, format: {
++      with: /[a-zA-Z][0-9]{7}/,
++      message: ""one letter followed by 7 numbers""
++    }, allow_blank: true
+     # TODO validates :proposal, presence: true
+
+     def set_defaults","@phirefly Can we look at a list of RWAs, or ask someone to double-check that this format is correct? Otherwise :shipit:"
+3823,"@@ -72,6 +72,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy {
+           .format(""iceberg"")
+           .option(SparkWriteOptions.REWRITTEN_FILE_SCAN_TASK_SET_ID, groupID)
+           .option(SparkWriteOptions.TARGET_FILE_SIZE_BYTES, writeMaxFileSize())
++          .option(SparkWriteOptions.DISTRIBUTION_MODE, ""none"")
+           .mode(""append"")
+           .save(table.name());
+ ",Still request a local sort for bin-packing based on the defined table sort order.
+3824,"@@ -151,13 +151,16 @@ def request_model(rank, itr, lmbda, alpha):
+ @click.option(""--days"", type=int, default=7, help=""Request recommendations to be generated on history of given number of days"")
+ @click.option(""--top"", type=int, default=20, help=""Calculate given number of top artist."")
+ @click.option(""--similar"", type=int, default=20, help=""Calculate given number of similar artist."")
+-def request_candidate_sets(days, top, similar):
++@click.option(""--user-id"", ""users"", callback=parse_list, default=[], multiple=True,
++                                    help=""Generate candidate set for given users. Generate for all active users by default."")
++def request_candidate_sets(days, top, similar, users):
+     """""" Send the cluster a request to generate candidate sets.
+     """"""
+     params = {
+         'recommendation_generation_window': days,
+         ""top_artist_limit"": top,
+         ""similar_artist_limit"": similar,
++        ""users"": users
+     }
+     send_request_to_spark_cluster(_prepare_query_message('cf_recording.recommendations.candidate_sets', params=params))
+ ","As with the other PR, user name is better."
+3825,"@@ -125,6 +125,12 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount uint64) er
+ 	if err != nil {
+ 		return err
+ 	}
++
++	balance, err := s.chequebook.AvailableBalance(ctx)
++	if err != nil {
++		return err
++	}
++	s.metrics.AvailableBalance.Set(float64(balance.Int64()))
+ 	s.metrics.TotalSent.Add(float64(amount))
+ 	return nil
+ }",a peer's accounting lock is held during `Pay`. we should avoid adding additional blockchain calls here if possible.
+3826,"@@ -66,6 +66,12 @@ module.exports = function(realmConstructor) {
+
+         setConstructorOnPrototype(realmConstructor.Sync.User);
+         setConstructorOnPrototype(realmConstructor.Sync.Session);
++    } else {
++        Object.defineProperty(realmConstructor, 'Sync', {
++            get: function () {
++                throw new Error(""Sync is not enabled. Note that the developer edition of the Node.JS SDK for Realm does not include sync on Linux."");
++            }
++        })
+     }
+
+     // TODO: Remove this now useless object.","Maybe wording could be improved. Is this ""not enabled"" or it is ""not available"". Not sure about that."
+3827,"@@ -120,7 +120,11 @@ func (it *TaskReconciler) Reconcile(ctx context.Context, request reconcile.Reque
+
+ 	// update the status about conditional tasks
+ 	if len(pods) > 0 && (pods[0].Status.Phase == corev1.PodFailed || pods[0].Status.Phase == corev1.PodSucceeded) {
+-		if !conditionalBranchesEvaluated(node) {
++		evaluated, err := it.conditionalBranchesEvaluated(ctx, node)
++		if err != nil {
++			return reconcile.Result{}, err
++		}
++		if !evaluated {
+ 			it.eventRecorder.Event(&node, recorder.TaskPodPodCompleted{PodName: pods[0].Name})
+ 			// task pod is terminated
+ 			updateError := retry.RetryOnConflict(retry.DefaultRetry, func() error {",I looked at the new `conditionalBranchesEvaluated` function and it looks like the part added is a duplicate of the line above?
+3828,"@@ -53,6 +53,9 @@ import (
+ //           May be missing, but should be present when data is.
+ //   - refs: The list of references to the block, encoded as a serialized
+ //           blockRefInfo. May be missing.
++//   - f:    Presence of this file indicates the block has been successfully
++//           flushed to the server.  However, the data might still be
++//           in the store.
+ //
+ // Future versions of the disk store might add more files to this
+ // directory; if any code is written to move blocks around, it should","can you put this flag in `blockRefInfo` instead? It would be a shame to add one more file per block, especially since we've run into inode limits. I guess `blockRefInfo` should maybe then be renamed to `blockInfo` or something. But we're stuck with the filename."
+3829,"@@ -43,5 +43,9 @@ func (c *ConsumerConfigParser) Parse(config json.RawMessage) (ip string, port in
+ 	if err != nil {
+ 		return """", 0, """", errors.Wrap(err, ""parsing consumer address:port failed"")
+ 	}
+-	return cfg.IP, cfg.Port, openvpn.ServiceType, nil
++
++	if cfg.IP == nil {
++		return """", 0, """", nil
++	}
++	return *cfg.IP, cfg.Port, openvpn.ServiceType, nil
+ }",Shouldn't we keep other parameters if only IP is empty? Or maybe return an error if it's a mandatory argument?
+3830,"@@ -118,7 +118,8 @@ class NdIndexableMappingTest(ComparisonTestCase):
+         data = [((0, 0.5), 'a'), ((1, 0.5), 'b')]
+         ndmap = MultiDimensionalMapping(data, kdims=[self.dim1, self.dim2])
+         redimmed = ndmap.redim(intdim='Integer')
+-        self.assertEqual(redimmed.kdims, [Dimension('Integer'), Dimension('floatdim')])
++        self.assertEqual(redimmed.kdims, [Dimension('Integer', type=int),
++                                          Dimension('floatdim', type=float)])
+
+     def test_idxmapping_add_dimension(self):
+         ndmap = MultiDimensionalMapping(self.init_items_1D_list, kdims=[self.dim1])",Was this just wrong before? The names indicated types but type wasn't specified. I guess the tests passed as comparison worked with ``type=None``?
+3831,"@@ -146,7 +146,8 @@ public class OrcMetrics {
+       if (icebergColOpt.isPresent()) {
+         final Types.NestedField icebergCol = icebergColOpt.get();
+         final int fieldId = icebergCol.fieldId();
+-        final MetricsMode metricsMode = effectiveMetricsConfig.columnMode(icebergCol.name());
++        final String colName = schema.findColumnName(icebergCol.fieldId());
++        final MetricsMode metricsMode = effectiveMetricsConfig.columnMode(colName);
+
+         columnSizes.put(fieldId, colStat.getBytesOnDisk());
+ ",icebergCol.name() is the unqualified column name
+3832,"@@ -45,7 +45,7 @@ class MetricAlarm(object):
+     def __init__(self, connection=None, name=None, metric=None,
+                  namespace=None, statistic=None, comparison=None, threshold=None,
+                  period=None, evaluation_periods=None, unit=None, description='',
+-                 dimensions=[]):
++                 dimensions=[], alarm_actions=[], insufficient_data_actions=[], ok_actions=[]):
+         """"""
+         Creates a new Alarm.
+ ","It's generally a bad idea to use mutable types like lists as default values for parameters. Lots of strange, difficult to debug side effects can occur. I see that there was already one example of this prior to this commit which probably explains why it seemed innocuous to add more but I'm going to rework this before committing to master."
+3833,"@@ -10,6 +10,7 @@ module.exports = {
+     'prettier',
+     'prettier/@typescript-eslint',
+     'plugin:prettier/recommended',
++    'eslint-config-prettier'
+   ],
+   globals: {
+     Atomics: 'readonly',","We run prettier as an eslint plugin, so this harmful"
+3834,"@@ -39,7 +39,7 @@ using namespace eprosima::fastrtps::types;
+ HelloWorldPublisher::HelloWorldPublisher()
+     : mp_participant(nullptr)
+     , mp_publisher(nullptr)
+-    , m_DynType(nullptr)
++    , m_DynType(DynamicType_ptr(nullptr))
+ {
+ }
+ ",Check if the TypeDescriptor and MemberDescriptor includes are necessary
+3835,"@@ -4,10 +4,11 @@ import (
+ 	gocontext ""context""
+ 	""encoding/json""
+ 	""fmt""
+-	""k8s.io/apimachinery/pkg/api/errors""
+ 	""os""
+ 	""syscall""
+
++	""k8s.io/apimachinery/pkg/api/errors""
++
+ 	corev1 ""k8s.io/api/core/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/types""",delete the empty line here.
+3836,"@@ -302,6 +302,16 @@ describe Subscription do
+     end
+   end
+
++  describe ""#reactivate"" do
++    it ""unsets scheduled_for_deactivation_on"" do
++      subscription = create(:subscription, scheduled_for_deactivation_on: 1.day.from_now)
++      subscription.reactivate
++      subscription.reload
++
++      expect(subscription.scheduled_for_deactivation_on).to be_nil
++    end
++  end
++
+   def setup_cutomer
+     stripe_customer = double(
+       ""StripeCustomer"",",Line is too long. [89/80]
+3837,"@@ -200,7 +200,7 @@ public class JsonHttpRemoteConfig {
+     }
+   }
+
+-  private UrlMapper getUrlMapper(String method) {
++  protected UrlMapper getUrlMapper(String method) {
+     if (""DELETE"".equals(method)) {
+       return deleteMapper;
+     } else if (""GET"".equals(method)) {","You don't need to expose this method to do what you want. There are already public addNewGetMapping, addNewPostMapping, and addNewDeleteMapping methods."
+3838,"@@ -782,7 +782,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+         }
+
+         [Fact]
+-        public async Task HeadResponseCanContainContentLengthHeaderButBodyNotWritten()
++        public async Task HeadResponseBodyNotWritten()
+         {
+             using (var server = new TestServer(async httpContext =>
+             {",This test passes in `dev`. Why wouldn't this work?
+3839,"@@ -1,6 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX-License-Identifier: Apache-2.0
+
++""""""
++Purpose
++
++Shows how to use the AWS SDK for Python (Boto3) with PyTest and the AWS Device Farm
++browser testing feature.
++""""""
++
++# snippet-start:[python.example_code.device-farm.Scenario_BrowserTesting]
+ import datetime
+ import os
+ import subprocess",ARN -> Amazon Resource Number (ARN)
+3840,"@@ -153,10 +153,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+
+             var hostBuilder = new WebHostBuilder()
+                .UseKestrel()
+-               .ConfigureServices(services =>
+-               {
+-                   services.AddSingleton<ILoggerFactory>(new KestrelTestLoggerFactory(testLogger));
+-               })
++               .UseLoggerFactory(_ => new KestrelTestLoggerFactory(testLogger))
+                .Configure(ConfigureEchoAddress);
+
+             using (var host = hostBuilder.Build())",Why not use the overload that takes an instance?
+3841,"@@ -7,16 +7,13 @@
+ package account
+
+ import (
+-	""context""
+ 	""fmt""
++	""strings""
+
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""
+-	grpc ""google.golang.org/grpc""
+
+-	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/config""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+-	pb ""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ )
+
+ // TODO: use wallet config later",`Blockchian` is a misspelling of `Blockchain` (from `misspell`)
+3842,"@@ -44,7 +44,7 @@ type NvidiaGPUManager struct {
+ 	DriverVersion string                `json:""DriverVersion""`
+ 	GPUIDs        []string              `json:""GPUIDs""`
+ 	GPUDevices    []*ecs.PlatformDevice `json:""-""`
+-	lock          sync.RWMutex          `json:""-""`
++	lock          sync.RWMutex
+ }
+
+ const (",`agent/gpu/nvidia_gpu_manager_unix.go:47: struct field lock has json tag but is not exported`
+3843,"@@ -11,6 +11,9 @@ from localstack.utils.aws.aws_models import LambdaFunction
+ from localstack.constants import LAMBDA_TEST_ROLE
+
+
++TEST_ARN = 'arn:aws:sqs:eu-west-1:000000000000:testq'
++
++
+ class TestLambdaAPI(unittest.TestCase):
+     CODE_SIZE = 50
+     CODE_SHA_256 = '/u60ZpAA9bzZPVwb8d4390i5oqP1YAObUwV03CZvsWA='",nit: better rename to `TEST_QUEUE_ARN` or `TEST_EVENT_SOURCE_ARN`
+3844,"@@ -1097,9 +1097,9 @@ func (c *Operator) sync(key string) error {
+ 		return err
+ 	}
+
+-	// If no service monitor selectors are configured, the user wants to
+-	// manage configuration themselves.
+-	if p.Spec.ServiceMonitorSelector != nil {
++	// If no service monitor selectors or additional scrape configs are configured,
++	// the user wants to manage configuration themselves.
++	if p.Spec.ServiceMonitorSelector != nil || p.Spec.AdditionalScrapeConfigs != nil {
+ 		// We just always regenerate the configuration to be safe.
+ 		if err := c.createOrUpdateConfigurationSecret(p, ruleConfigMapNames); err != nil {
+ 			return errors.Wrap(err, ""creating config failed"")",Would this mean that podMonitorSelectors suffer from the same issue if they are the only configuration set?
+3845,"@@ -110,6 +110,17 @@ func (c *fakeClient) ReportPipedMeta(ctx context.Context, req *pipedservice.Repo
+ 	return &pipedservice.ReportPipedMetaResponse{}, nil
+ }
+
++// GetEnvironment finds and returns the environment for the specified ID.
++func (c *fakeClient) GetEnvironment(ctx context.Context, req *pipedservice.GetEnvironmentRequest, opts ...grpc.CallOption) (*pipedservice.GetEnvironmentResponse, error) {
++	c.logger.Info(""fake client received GetEnvironment rpc"", zap.Any(""request"", req))
++	return &pipedservice.GetEnvironmentResponse{
++		Environment: &model.Environment{
++			Id:   ""dev"",
++			Name: ""dev"",
++		},
++	}, nil
++}
++
+ // ListApplications returns a list of registered applications
+ // that should be managed by the requested piped.
+ // Disabled applications should not be included in the response.",`ctx` is unused in GetEnvironment
+3846,"@@ -89,6 +89,11 @@ namespace pwiz.Skyline.FileUI
+             }
+         }
+
++        public void OKDialog()
++        {
++            DialogResult = DialogResult.OK;
++        }
++
+         private void cbShowText_CheckedChanged(object sender, System.EventArgs e)
+         {
+             LineText.Visible = cbShowText.Checked;",We usually use OkDialog()
+3847,"@@ -970,6 +970,12 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       description = ""Enable flexible (onchain) privacy groups (default: ${DEFAULT-VALUE})"")
+   private final Boolean isFlexiblePrivacyGroupsEnabled = false;
+
++  @Option(
++      names = {""--privacy-unrestricted-enabled""},
++      description =
++          ""Enable unrestricted (stores payload onchain) privacy (default: ${DEFAULT-VALUE})"")
++  private final Boolean isUnrestrictedPrivacyEnabled = false;
++
+   @Option(
+       names = {""--target-gas-limit""},
+       description =","could we please change that to something that indicates that this feature is not ""production"" ready!"
+3848,"@@ -0,0 +1,5 @@
++_base_ = './mask_rcnn_swim-t-p4-w7_fpn_fp16_ms-crop-3x_coco.py'
++model = dict(
++    pretrained=\
++    'https://download.openmmlab.com/mmclassification/v0/swin-transformer/swin_small_224_b16x64_300e_imagenet_20210615_110219-7f9d988b.pth',  # noqa
++    backbone=dict(depths=[2, 2, 18, 2]))",swim -> swin. Other configs and file names also should be modified.
+3849,"@@ -47,7 +47,7 @@ class BigQueryClient(_base_client.BaseClient):
+         return RateLimiter(FLAGS.max_bigquery_api_calls_per_100_seconds,
+                            self.DEFAULT_QUOTA_TIMESPAN_PER_SECONDS)
+
+-    def get_bigquery_projectids(self):
++    def get_bigquery_projectids(self, key='projects'):
+         """"""Request and page through bigquery projectids.
+
+         Returns: A list of project_ids enabled for bigquery.","nit: arg description for ""key""?"
+3850,"@@ -244,6 +244,15 @@ func (tlf *TLF) Setattr(ctx context.Context, req *fuse.SetattrRequest, resp *fus
+ 	return dir.Setattr(ctx, req, resp)
+ }
+
++// Fsync implements the fs.NodeFsyncer interface for TLF.
++func (tlf *TLF) Fsync(ctx context.Context, req *fuse.FsyncRequest) (err error) {
++	dir, err := tlf.loadDir(ctx)
++	if err != nil {
++		return err
++	}
++	return dir.Fsync(ctx, req)
++}
++
+ var _ fs.Handle = (*TLF)(nil)
+
+ var _ fs.NodeOpener = (*TLF)(nil)","If we don't have a `dir` yet, we wouldn't need to do a sync right? If so, perhaps we can just `getStoredDir()` like `Attr()`?"
+3851,"@@ -1637,10 +1637,13 @@ privload_mem_is_elf_so_header(byte *mem)
+     /* libdynamorio should be ET_DYN */
+     if (elf_hdr->e_type != ET_DYN)
+         return false;
+-    /* ARM or X86 */
++        /* ARM or X86 */
++#        ifndef DR_HOST_NOT_TARGET
+     if (elf_hdr->e_machine !=
+-        IF_X86_ELSE(IF_X64_ELSE(EM_X86_64, EM_386), IF_X64_ELSE(EM_AARCH64, EM_ARM)))
++        IF_HOST_X86_ELSE(IF_HOST_X64_ELSE(EM_X86_64, EM_386),
++                         IF_HOST_X64_ELSE(EM_AARCH64, EM_ARM)))
+         return false;
++#        endif
+     if (elf_hdr->e_ehsize != sizeof(ELF_HEADER_TYPE))
+         return false;
+     return true;",I still don't seem to fully understand this. Why are we testing the host if DR_HOST_NOT_TARGET is not set?
+3852,"@@ -34,9 +34,9 @@ import (
+
+ func TestBzzFiles(t *testing.T) {
+ 	var (
+-		fileUploadResource   = ""/bzz""
++		fileUploadResource   = ""/v1/bzz""
+ 		targets              = ""0x222""
+-		fileDownloadResource = func(addr string) string { return ""/bzz/"" + addr }
++		fileDownloadResource = func(addr string) string { return ""/v1/bzz/"" + addr }
+ 		simpleData           = []byte(""this is a simple text"")
+ 		storerMock           = smock.NewStorer()
+ 		statestoreMock       = statestore.NewStateStore()","in the current implementation, both schemes are supported (you can call either `/bzz` or `/v1/bzz`). i would suggest to keep it this way"
+3853,"@@ -44,9 +44,12 @@ module.exports = class Client {
+       body: data
+     }).then((response) => response.json()).then((assembly) => {
+       if (assembly.error) {
+-        const error = new Error(assembly.error)
++        const error = new Error(assembly)
+         error.message = assembly.error
+-        error.details = assembly.reason
++        error.details = assembly.message
++        if (assembly.assembly_id) {
++          error.details += ' ' + `assembly_id: ${assembly.assembly_id}`
++        }
+         throw error
+       }
+ ","hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?"
+3854,"@@ -315,7 +315,10 @@ class Typo3PageIndexer
+         $document->setField('rootline', $rootline);
+
+         // access
+-        $document->setField('access', (string)$this->pageAccessRootline);
++        $access = (string)$this->pageAccessRootline;
++        if (trim($access) !== """") {
++            $document->setField('access', $access);
++        }
+         if ($this->page->page['endtime']) {
+             $document->setField('endtime', $pageRecord['endtime']);
+         }",This should never be empty. The access field always needs a value of at least `c:0` or `r:0`
+3855,"@@ -6,11 +6,16 @@ import (
+ 	""encoding/json""
+
+ 	""github.com/influxdata/flux/ast""
++	""github.com/influxdata/flux/internal/parser""
+ 	""github.com/influxdata/flux/internal/token""
+ 	""github.com/influxdata/flux/libflux/go/libflux""
+ )
+
+ func parseFile(f *token.File, src []byte) (*ast.File, error) {
++	if !useRustParser() {
++		return parser.ParseFile(f, src), nil
++	}
++
+ 	astFile := libflux.Parse(string(src))
+ 	defer astFile.Free()
+ ","Another question is, do we want to call `os.Getenv()` every time we parse a file? That seems a lot."
+3856,"@@ -33,6 +33,10 @@ public interface Tuple {
+      */
+     Seq<?> toSeq();
+
++    <A> Tuple append(A v);
++
++    <A> Tuple prepend(A v);
++
+     // -- factory methods
+
+     /**",minor: please rename all occurrences of `A` to `T`. please also rename `v` to `value`.
+3857,"@@ -52,11 +52,13 @@ namespace Nethermind.Synchronization.ParallelSync
+             add { }
+             remove { }
+         }
+-
++
++        public int FastSyncLag => (Current & SyncMode.Beam) == SyncMode.Beam ? SyncModeSelectorConstants.BeamSyncFastSyncLag : SyncModeSelectorConstants.NotBeamSyncFastSyncLag;
++
+         public event EventHandler<SyncModeChangedEventArgs> Changing
+         {
+             add { }
+             remove { }
+         }
+     }
+-}
++}",Do we want it to be so dynamic? My first idea was to base it on SyncConfig.BeamSync .
+3858,"@@ -42,7 +42,7 @@ public class RemoteNetworkConnection implements NetworkConnection {
+   @Override
+   public ConnectionType setNetworkConnection(
+       ConnectionType type) {
+-    Map<String, ConnectionType> mode = ImmutableMap.of(""type"", type);
++    Map<String, Integer> mode = ImmutableMap.of(""type"", type.getBitMask());
+     return new ConnectionType(((Number) executeMethod.execute(DriverCommand.SET_NETWORK_CONNECTION,
+                                                             ImmutableMap
+                                                                 .of(""parameters"", mode)))",can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice)
+3859,"@@ -68,6 +68,13 @@ def test_plot_importance(params, breast_cancer_split, train_data):
+     assert ax2.patches[2].get_facecolor() == (0, .5, 0, 1.)  # g
+     assert ax2.patches[3].get_facecolor() == (0, 0, 1., 1.)  # b
+
++    ax3 = lgb.plot_importance(gbm0, title='t @importance_type@', xlabel='x @importance_type@', ylabel='y @importance_type@')
++    assert isinstance(ax3, matplotlib.axes.Axes)
++    assert ax3.get_title() == 't @importance_type@'
++    assert ax3.get_xlabel() == 'x split'
++    assert ax3.get_ylabel() == 'y @importance_type@'
++    assert len(ax3.patches) <= 30
++
+     gbm2 = lgb.LGBMClassifier(n_estimators=10, num_leaves=3, silent=True, importance_type=""gain"")
+     gbm2.fit(X_train, y_train)
+ ",I'm confused by these tests. Shouldn't the template string `@importance_type@` have been replaced with the actual value of `importance_type`?
+3860,"@@ -25,7 +25,7 @@ import (
+ type harness struct{}
+
+ func (h *harness) MakeDriver(ctx context.Context) (driver.Keeper, error) {
+-	return NewKeeper(ByteKey(""very secret secret"")), nil
++	return &keeper{secretKey: ByteKey(""very secret secret"")}, nil
+ }
+
+ func (h *harness) Close() {}",Let's keep using NewKeeper so that it got covered by tests.
+3861,"@@ -70,6 +70,9 @@ import org.apache.solr.core.CoreContainer;
+ import org.apache.solr.handler.admin.CollectionsHandler;
+ import org.apache.solr.handler.component.HttpShardHandler;
+ import org.apache.solr.logging.MDCLoggingContext;
++import org.apache.solr.store.blob.process.BlobDeleteManager;
++import org.apache.solr.store.blob.process.BlobDeleteProcessor;
++import org.apache.solr.store.shared.SharedStoreManager;
+ import org.apache.solr.store.shared.metadata.SharedShardMetadataController;
+ import org.apache.solr.update.UpdateShardHandler;
+ import org.apache.zookeeper.CreateMode;",I only see new imports. Is there any functional change in this file?
+3862,"@@ -1141,6 +1141,18 @@ func (bc *blockchain) pickAndRunActions(ctx context.Context, actionMap map[strin
+ 		executedActions = append(executedActions, grant)
+ 	}
+
++	if raCtx.BlockHeight == 1 {
++		tsf, err := bc.createMemorialTransfer(raCtx.Producer.String(), raCtx.ActionGasLimit)
++		receipt, err = ws.RunAction(raCtx, tsf)
++		if err != nil {
++			return hash.ZeroHash256, nil, nil, err
++		}
++		if receipt != nil {
++			receipts = append(receipts, receipt)
++		}
++		executedActions = append(executedActions, tsf)
++	}
++
+ 	blockMtc.WithLabelValues(""gasConsumed"").Set(float64(bc.config.Genesis.BlockGasLimit - raCtx.GasLimit))
+
+ 	return ws.UpdateBlockLevelInfo(raCtx.BlockHeight), receipts, executedActions, nil",ineffectual assignment to `err` (from `ineffassign`)
+3863,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`)
+3864,"@@ -163,6 +163,18 @@ def FindMolChiralCenters(mol, force=True, includeUnassigned=False, includeCIP=Tr
+         centers.append((idx, code))
+   return centers
+
++import warnings
++def WrapLogs():
++  warnings.warn(""Deprecated: use the rdkit.rdBase.LogTo*() functions instead."", DeprecationWarning)
++  rdBase.LogToPythonStderr()
++
++def LogWarningMsg(msg):
++  warnings.warn(""Deprecated: use rdkit.rdBase.LogWarningMsg() instead."", DeprecationWarning)
++  rdBase.LogWarningMsg(msg)
++
++def LogErrorMsg(msg):
++  warnings.warn(""Deprecated: use rdkit.rdBase.LogErrorMsg() instead."", DeprecationWarning)
++  rdBase.LogErrorMsg(msg)
+
+ #------------------------------------
+ #","Make sure the old logging functions still work, but add deprecation warnings (unfortunately Python suppresses deprecation warnings by default, so I'm not sure if anyone'll notice)."
+3865,"@@ -252,14 +252,17 @@ public class ManagementAuthorizationTest extends AuthorizationTest {
+
+   public void testTelemetryEnabledAsCamundaAdmin() {
+     // given
++    disableAuthorization();
++    managementService.enableTelemetry(true);
++    enableAuthorization();
+     identityService.setAuthentication(userId, Collections.singletonList(Groups.CAMUNDA_ADMIN));
+
+     // when
+-    managementService.enableTelemetry(true);
++    managementService.enableTelemetry(false);
+
+     // then
+     String telemetryPropertyValue = TelemetryHelper.fetchConfigurationProperty(processEngineConfiguration).getValue();
+-    assertThat(Boolean.parseBoolean(telemetryPropertyValue)).isTrue();
++    assertThat(Boolean.parseBoolean(telemetryPropertyValue)).isFalse();
+   }
+
+ }","Not directly related to the topic of this ticket: I think this API design is a bit confusing. To disable delemetry, I would write `managementService.enableTelemetry(false)` which is not intuitive to read. Maybe `toggleTelemetry` instead of `enableTelemetry` is more clear."
+3866,"@@ -163,9 +163,11 @@ namespace Microsoft.Sarif.Viewer
+                         HelpLink = rule?.HelpUri?.ToString()
+                     };
+
+-                    CaptureAnnotatedCodeLocationCollections(result.Stacks, AnnotatedCodeLocationKind.Stack, sarifError);
++                    IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotationsFromStacks(result.Stacks);
++
++                    CaptureAnnotatedCodeLocationCollections(stackLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+                     CaptureAnnotatedCodeLocationCollections(result.CodeFlows, AnnotatedCodeLocationKind.CodeFlow, sarifError);
+-                     CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
++                    CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+
+                     if (region != null)
+                     {",Again I suggest returning `AnnotatedCodeLocation[][]`.
+3867,"@@ -16,11 +16,14 @@ package ec2
+ import (
+ 	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/aws-sdk-go/service/ec2""
++	""github.com/golang/glog""
+ 	""github.com/pkg/errors""
+ 	""sigs.k8s.io/cluster-api-provider-aws/cloud/aws/providerconfig/v1alpha1""
+ )
+
+ func (s *Service) reconcileInternetGateways(in *v1alpha1.Network) error {
++	glog.V(2).Infof(""Reconciling internet gateways"")
++
+ 	igs, err := s.describeVpcInternetGateways(&in.VPC)
+ 	if IsNotFound(err) {
+ 		ig, err := s.createInternetGateway(&in.VPC)",We should probably require an increased verbosity to output for anything below the cluster itself to avoid spamming the logs. It would also be good to give additional context as to what we are attempting to reconcile since the controller has multiple workers.
+3868,"@@ -32,5 +32,7 @@ type OptionsNetwork struct {
+ 	EtherClientRPC       string
+ 	EtherPaymentsAddress string
+
++	EnableDNS bool
++
+ 	QualityOracle string
+ }",Not needed anymore
+3869,"@@ -80,6 +80,17 @@ namespace Datadog.Trace.ClrProfiler
+                 Log.Error(ex, ""ByRef instrumentation cannot be enabled: "");
+             }
+
++            try
++            {
++                Log.Debug(""Enabling calltarget state by ref."");
++                NativeMethods.EnableCallTargetStateByRef();
++                Log.Information(""CallTarget State ByRef enabled."");
++            }
++            catch (Exception ex)
++            {
++                Log.Error(ex, ""CallTarget state ByRef cannot be enabled: "");
++            }
++
+             try
+             {
+                 Log.Debug(""Sending CallTarget integration definitions to native library."");","Am I right in thinking this completely avoids the situation where `enable_calltarget_state_by_ref` is `true`, but the managed integrations don't expect a by ref argument? For example, if there's an exception here, that seems like a fatal problem, as we would have a mismatch for jit rewriting? We should disable instrumentation entirely in that case shouldn't we? i.e. if this (or the existing `EnableByRefInstrumentation`) calls fail, should we bail out of this method entirely as we can't safely instrument?"
+3870,"@@ -40,6 +40,15 @@ const (
+
+ package {{ .Package }}
+
++type ResourceTypes int
++
++const (
++	Unknown ResourceTypes = iota
++	{{- range .KnownTypes }}
++    {{ . }}
++    {{- end }}
++)
++
+ // Instance describes a single resource annotation
+ type Instance struct {
+ 	// The name of the annotation.",nit: spaces seem off
+3871,"@@ -20,7 +20,7 @@
+
+ #include ""PBFParser.h""
+
+-PBFParser::PBFParser(const char * fileName) : externalMemory(NULL){
++PBFParser::PBFParser(ExtractorCallbacks* em, ScriptingEnvironment& se, const char * fileName) : BaseParser( em, se ) {
+ 	GOOGLE_PROTOBUF_VERIFY_VERSION;
+ 	//TODO: What is the bottleneck here? Filling the queue or reading the stuff from disk?
+ 	//NOTE: With Lua scripting, it is parsing the stuff. I/O is virtually for free.",shouldn't the em parameter be called ec?
+3872,"@@ -132,7 +132,7 @@ func validateTrustedOperators(o *Options) error {
+ 		if o.TrustedKeys == nil {
+ 			o.TrustedKeys = make([]string, 0, 4)
+ 		}
+-		o.TrustedKeys = append(o.TrustedKeys, opc.Issuer)
++		o.TrustedKeys = append(o.TrustedKeys, opc.Subject)
+ 		o.TrustedKeys = append(o.TrustedKeys, opc.SigningKeys...)
+ 	}
+ 	for _, key := range o.TrustedKeys {","Please change this to use o.DidSign(o) as implements this logic without performing any of these checks that duplicate something that JWT can do correctly. If the JWT deserialized properly, and DidSign returns true, the JWT was signed by one of the listed operator keys."
+3873,"@@ -0,0 +1,19 @@
++package de.danoeh.antennapod.core.util.comparator;
++
++import java.util.Comparator;
++
++import de.danoeh.antennapod.core.feed.FeedItem;
++import de.danoeh.antennapod.core.feed.SearchResult;
++
++public class InReverseChronologicalOrder implements Comparator<SearchResult> {
++    /**
++     * Compare items and sort it on chronological order.
++     */
++    @Override
++    public int compare(SearchResult o1, SearchResult o2) {
++        if ((o1.getComponent() instanceof FeedItem) &&
++           (o2.getComponent() instanceof FeedItem))
++            return ((FeedItem) o2.getComponent()).getPubDate().compareTo(((FeedItem) o1.getComponent()).getPubDate());
++        return 0;
++    }
++}","Talking about style, IMO extracting either `getComponent()` or `getPubDate()` to variables would make this line easier to read."
+3874,"@@ -0,0 +1,18 @@
++// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package task
++
++// Option defines a function that can be executed in some task API methods in order to perform custom configurations
++// of the task
++type Option func(*Task) error",package header missing
+3875,"@@ -11,7 +11,11 @@ options._catchError = function(error, newVNode, oldVNode) {
+ 		for (; (vnode = vnode._parent); ) {
+ 			if ((component = vnode._component) && component._childDidSuspend) {
+ 				// Don't call oldCatchError if we found a Suspense
+-				return component._childDidSuspend(error, newVNode._component);
++				return component._childDidSuspend(
++					error,
++					newVNode._component,
++					oldVNode && oldVNode._hydrateDom && oldVNode._hydrating
++				);
+ 			}
+ 		}
+ 	}","Just a thought (doesn't change the output or anything) - do you think we'll ever want to access the other properties of `oldVNode` from within `_childDidSuspend`? If so we could pass `oldVNode` here and then check these properties in the _childDidSuspend implementation. I don't have strong feelings either way, just occurred to me."
+3876,"@@ -0,0 +1,15 @@
++<?php
++
++namespace Sonata\MediaBundle\PHPCR;
++
++use Doctrine\ODM\PHPCR\DocumentRepository;
++use Doctrine\ODM\PHPCR\Id\RepositoryIdInterface;
++
++class GalleryHasMediaRepository extends DocumentRepository implements RepositoryIdInterface
++{
++    public function generateId($document, $parent = null)
++    {
++        return '/cms/gallery-has-media/'  . uniqid();
++    }
++}
++",We should be configuring the base paths somewhere..
+3877,"@@ -311,6 +311,17 @@ def test_ssd_anchor_generator():
+     else:
+         device = 'cpu'
+
++    # min_sizes max_sizes must set at the same time
++    with pytest.raises(AssertionError):
++        anchor_generator_cfg = dict(
++            type='SSDAnchorGenerator',
++            scale_major=False,
++            min_sizes=[48, 100, 150, 202, 253, 300],
++            max_sizes=None,
++            strides=[8, 16, 32, 64, 100, 300],
++            ratios=[[2], [2, 3], [2, 3], [2, 3], [2], [2]])
++        build_anchor_generator(anchor_generator_cfg)
++
+     anchor_generator_cfg = dict(
+         type='SSDAnchorGenerator',
+         scale_major=False,",May also need to test the normal functionality with min/max_sizes
+3878,"@@ -73,6 +73,7 @@ var MainnetDefinition = NetworkDefinition{
+ 		ChainID:            1,
+ 		MystAddress:        ""0x4Cf89ca06ad997bC732Dc876ed2A7F26a9E7f361"",
+ 		EtherClientRPC: []string{
++			""https://ethereum1.mysterium.network/"",
+ 			""https://main-light.eth.linkpool.io/"",
+ 		},
+ 	},",We can remove this one. It's just a random one I got for free for testing.
+3879,"@@ -7,6 +7,7 @@
+ package blocksync
+
+ import (
++	""github.com/iotexproject/iotex-core/db""
+ 	""sync""
+
+ 	""github.com/iotexproject/iotex-core/actpool""",File is not `goimports`-ed (from `goimports`)
+3880,"@@ -65,7 +65,11 @@ class AddFiles extends Component {
+
+   renderMyDeviceAcquirer = () => {
+     return (
+-      <div class=""uppy-DashboardTab"" role=""presentation"">
++      <div
++        class=""uppy-DashboardTab""
++        role=""presentation""
++        data-acquirer-id=""Local""
++      >
+         <button
+           type=""button""
+           class=""uppy-DashboardTab-btn""",(maybe this should be MyDevice or just removed entirely?)
+3881,"@@ -337,6 +337,10 @@ func (payloadHandler *payloadRequestHandler) handleUnrecognizedTask(task *ecsacs
+ 		TaskARN: *task.Arn,
+ 		Status:  apitaskstatus.TaskStopped,
+ 		Reason:  UnrecognizedTaskError{err}.Error(),
++		// The real task cannot be extracted from payload message, so we send an empty task.
++		// This is necessary because the task handler will not send an event whose
++		// Task is nil.
++		Task: &apitask.Task{},
+ 	}
+
+ 	payloadHandler.taskHandler.AddStateChangeEvent(taskEvent, payloadHandler.ecsClient)","Can you do a nil check here, as the task isn't always nil here?"
+3882,"@@ -30,9 +30,12 @@ import Layout from 'GoogleComponents/layout/layout';
+  */
+ import { isDataZeroForReporting, getTopPagesReportDataDefaults } from '../util';
+
+-const { __ } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class AnalyticsDashboardWidgetPopularPagesTable extends Component {
+ 	static renderLayout( component ) {",`lodash` shouldn't be grouped under WordPress dependencies
+3883,"@@ -76,7 +76,11 @@ public class DiscoveryConfiguration {
+                   ""enode://011f758e6552d105183b1761c5e2dea0111bc20fd5f6422bc7f91e0fabbec9a6595caf6239b37feb773dddd3f87240d99d859431891e4a642cf2a0a9e6cbb98a@51.141.78.53:30303"",
+                   ""enode://176b9417f511d05b6b2cf3e34b756cf0a7096b3094572a8f6ef4cdcb9d1f9d00683bf0f83347eebdf3b81c3521c2332086d9592802230bf528eaf606a1d9677b@13.93.54.137:30303"",
+                   ""enode://46add44b9f13965f7b9875ac6b85f016f341012d84f975377573800a863526f4da19ae2c620ec73d11591fa9510e992ecc03ad0751f53cc02f7c7ed6d55c7291@94.237.54.114:30313"",
+-                  ""enode://b5948a2d3e9d486c4d75bf32713221c2bd6cf86463302339299bd227dc2e276cd5a1c7ca4f43a0e9122fe9af884efed563bd2a1fd28661f3b5f5ad7bf1de5949@18.218.250.66:30303"")
++                  ""enode://b5948a2d3e9d486c4d75bf32713221c2bd6cf86463302339299bd227dc2e276cd5a1c7ca4f43a0e9122fe9af884efed563bd2a1fd28661f3b5f5ad7bf1de5949@18.218.250.66:30303"",
++                  ""enode://c1f8b7c2ac4453271fa07d8e9ecf9a2e8285aa0bd0c07df0131f47153306b0736fd3db8924e7a9bf0bed6b1d8d4f87362a71b033dc7c64547728d953e43e59b2@52.64.155.147:30303"",
++                  ""enode://f4a9c6ee28586009fb5a96c8af13a58ed6d8315a9eee4772212c1d4d9cebe5a8b8a78ea4434f318726317d04a3f531a1ef0420cf9752605a562cfe858c46e263@213.186.16.82:30303"",
++                  // Ethereum Foundation bootnode
++                  ""enode://a61215641fb8714a373c80edbfa0ea8878243193f57c96eeb44d0bc019ef295abd4e044fd619bfc4c59731a73fb79afe84e9ab6da0c743ceb479cbb6d263fa91@3.11.147.67:30303"")
+               .map(EnodeURL::fromString)
+               .collect(toList()));
+ ",Does order matter? Should we sort by enode key to make duplication checking easier?
+3884,"@@ -132,11 +132,11 @@ func (ash *Handler) Provision(ctx caddy.Context) error {
+ 		return err
+ 	}
+
+-	acmeAuth, err := acme.NewAuthority(
+-		auth.GetDatabase().(nosql.DB),     // stores all the server state
+-		ash.Host,                          // used for directory links; TODO: not needed
+-		strings.Trim(ash.PathPrefix, ""/""), // used for directory links
+-		auth)                              // configures the signing authority
++	acmeAuth, err := acme.New(auth, acme.AuthorityOptions{
++		DB:     auth.GetDatabase().(nosql.DB),     // stores all the server state
++		DNS:    ash.Host,                          // used for directory links; TODO: not needed
++		Prefix: strings.Trim(ash.PathPrefix, ""/""), // used for directory links
++	})
+ 	if err != nil {
+ 		return err
+ 	}",Can you explain this too? This seems to go beyond linting.
+3885,"@@ -151,12 +151,6 @@ describe('Components', () => {
+ 		expect(scratch.innerHTML).to.equal('');
+ 	});
+
+-	// Test for #651
+-	it('should set enumerable boolean attribute', () => {
+-		render(<input spellcheck={false} />, scratch);
+-		expect(scratch.firstChild.spellcheck).to.equal(false);
+-	});
+-
+ 	// Test for Issue #73
+ 	it('should remove orphaned elements replaced by Components', () => {
+ 		class Comp extends Component {",I just moved this into the render.js UT file since this test doesn't actually use an components
+3886,"@@ -163,6 +163,8 @@ var ConfigCommand *cobra.Command = &cobra.Command{
+ 			util.Failed(""Could not write ddev config file: %v"", err)
+ 		}
+
++		_,_ = app.CreateSettingsFile()
++
+ 		// If a provider is specified, prompt about whether to do an import after config.
+ 		switch provider {
+ 		case ddevapp.DefaultProviderName:",We do have to capture and check the err here right? I don't think we need to capture the location of the file though for this context.
+3887,"@@ -8,7 +8,6 @@ import time
+ import sys
+ import logging
+ from logging.handlers import RotatingFileHandler
+-import os
+ from listenbrainz.listenstore import InfluxListenStore
+ import redis
+ ",an unused import
+3888,"@@ -152,6 +152,9 @@ func parseTLS(h Helper) ([]ConfigValue, error) {
+ 			// policy that is looking for any tag but the last one to be
+ 			// loaded won't find it, and TLS handshakes will fail (see end)
+ 			// of issue #3004)
++
++			tlsCertTags := h.state[""tlsCertTags""].(map[string]string)
++
+ 			tag, ok := tlsCertTags[certFilename]
+ 			if !ok {
+ 				// haven't seen this cert file yet, let's give it a tag","If this value doesn't exist (do an `, ok := ...` check), we should initialize and store it"
+3889,"@@ -1,6 +1,3 @@
+-import { or } from 'ramda';
+-
+-
+-const MIN_SAFE_INTEGER = or(Number.MIN_SAFE_INTEGER, -(2 ** 53) - 1);
++const MIN_SAFE_INTEGER = Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1;
+
+ export default MIN_SAFE_INTEGER;",Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1)
+3890,"@@ -175,8 +175,7 @@ class Serial(IoBase):
+ 		self._origTimeout = self._ser.timeout
+ 		# We don't want a timeout while we're waiting for data.
+ 		self._setTimeout(None)
+-		self.inWaiting = self._ser.inWaiting
+-		super(Serial, self).__init__(self._ser.hComPort, onReceive)
++		super(Serial, self).__init__(self._ser._port_handle, onReceive)
+
+ 	def read(self, size=1):
+ 		data = self._ser.read(size)","This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do."
+3891,"@@ -581,7 +581,7 @@ uint32_t wlr_xdg_toplevel_set_maximized(struct wlr_xdg_surface *surface,
+ 	assert(surface->role == WLR_XDG_SURFACE_ROLE_TOPLEVEL);
+ 	surface->toplevel->server_pending.maximized = maximized;
+
+-	return schedule_xdg_surface_configure(surface);
++	return wlr_xdg_surface_schedule_configure(surface);
+ }
+
+ uint32_t wlr_xdg_toplevel_set_fullscreen(struct wlr_xdg_surface *surface,","This function is what **the compositor** calls when it wants to fullscreen a client, not what the client calls."
+3892,"@@ -98,12 +98,13 @@ func TestTraceflow(t *testing.T) {
+ 		t.Fatal(err)
+ 	}
+
+-	// Creates 4 traceflows:
++	// Creates 6 traceflows:
+ 	// 1. node1Pods[0] -> node1Pods[1], intra node1.
+ 	// 2. node1Pods[0] -> node2Pods[0], inter node1 and node2.
+ 	// 3. node1Pods[0] -> node1IPs[1], intra node1.
+ 	// 4. node1Pods[0] -> node2IPs[0], inter node1 and node2.
+ 	// 5. node1Pods[0] -> service, inter node1 and node2.
++	// 6. node1Pods[0] -> not existed Pod
+ 	testcases := []testcase{
+ 		{
+ 			name: ""intraNodeTraceflow"",",s/not existed Pod/non-existing Pod
+3893,"@@ -62,10 +62,10 @@ type ECSStatusDescriber struct {
+ 	env string
+ 	svc string
+
+-	svcDescriber serviceDescriber
+-	ecsSvcGetter ecsServiceGetter
+-	cwSvcGetter  alarmStatusGetter
+-	aasSvcGetter autoscalingAlarmNamesGetter
++	ecsSvcDescriber serviceDescriber
++	ecsSvcGetter    ecsServiceGetter
++	cwSvcGetter     alarmStatusGetter
++	aasSvcGetter    autoscalingAlarmNamesGetter
+ }
+
+ // AppRunnerStatusDescriber retrieves status of an AppRunner service.",Why did we not leave this as just `svcDescriber`?
+3894,"@@ -11,12 +11,12 @@
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+-
+ """"""Provides the data access object (DAO) for Groups.""""""
+
++from Queue import Queue
++
+ from google.cloud.security.common.data_access import dao
+ from google.cloud.security.common.data_access.sql_queries import select_data
+-from google.cloud.security.common.gcp_type import group_member
+ from google.cloud.security.common.util import log_util
+
+ LOGGER = log_util.get_logger(__name__)",nit: I think we've been (in)consistent in leaving a blank line here.
+3895,"@@ -47,13 +47,15 @@ def define_violation(dbengine):
+         __tablename__ = violations_tablename
+
+         id = Column(Integer, primary_key=True)
+-        model_handle = Column(String(256))
++        inventory_index_id = Column(String(256))
+         resource_id = Column(String(256), nullable=False)
+         resource_type = Column(String(256), nullable=False)
++        full_name = Column(String(1024))
+         rule_name = Column(String(256))
+         rule_index = Column(Integer, default=0)
+         violation_type = Column(String(256), nullable=False)
+         data = Column(Text)
++        inventory_data = Column(Text)
+
+         def __repr__(self):
+             """"""String representation.",Maybe we can change it to a more generic name like source_id.
+3896,"@@ -2019,7 +2019,7 @@ func testKeyManagerRekeyAddDeviceWithPromptViaFolderAccess(t *testing.T, ver Met
+ 		defer ops.mdWriterLock.Unlock(lState)
+
+ 		// Now cause a paper prompt unlock via a folder access
+-		errCh := make(chan error)
++		errCh := make(chan error, 1)
+ 		go func() {
+ 			_, err := GetRootNodeForTest(ctx, config2Dev2, name, false)
+ 			select {","What's the theory on why this could fix the hang? It seems like the call to `GetRootNodeForTest` will always need to call into the crypto object before returning an error, and so it should block on that `c` receive, after which the test immediately drains `errCh`. So I don't quite see how buffering would help..."
+3897,"@@ -2003,8 +2003,16 @@ decode_operand(decode_info_t *di, byte optype, opnd_size_t opsize, opnd_t *opnd)
+         return true;
+     }
+     case TYPE_H: {
+-        /* part of AVX: vex.vvvv selects xmm/ymm register */
++        /* As part of AVX and AVX-512, vex.vvvv selects xmm/ymm/zmm register. Note that
++         * vex.vvvv and evex.vvvv are a union.
++         */
+         reg_id_t reg = (~di->vex_vvvv) & 0xf; /* bit-inverted */
++        if (TEST(PREFIX_EVEX_VV, di->prefixes)) {
++            /* This assumes that the register ranges of DR_REG_XMM, DR_REG_YMM, and
++             * DR_REG_ZMM are contiguous.
++             */
++            reg += 16;
++        }
+         *opnd = opnd_create_reg(((TEST(PREFIX_VEX_L, di->prefixes) &&
+                                   /* see .LIG notes above */
+                                   expand_subreg_size(opsize) != OPSZ_16)",Maybe add an assert in arch_init or somewhere?
+3898,"@@ -100,6 +100,7 @@ func TestcaseNetworkDelay(
+ 	err := cli.Create(ctx, networkDelay.DeepCopy())
+ 	framework.ExpectNoError(err, ""create network chaos error"")
+
++	// nolint
+ 	wait.Poll(time.Second, 15*time.Second, func() (done bool, err error) {
+ 		result = probeNetworkCondition(c, networkPeers, ports, false)
+ 		if len(result[networkConditionBlocked]) != 0 || len(result[networkConditionSlow]) != 3 {",I wonder what does this `// nolint` ignore? And what are the standards that you choose which error to fix and which to ignore?
+3899,"@@ -441,7 +441,10 @@ public class HttpSolrCall {
+     } else {
+       if (!retry) {
+         // we couldn't find a core to work with, try reloading aliases & this collection
+-        cores.getZkController().getZkStateReader().aliasesManager.update();
++        if(!cores.getZkController().getZkStateReader().aliasesManager.update()) {
++          //no change. go back
++          return;
++        }
+         cores.getZkController().zkStateReader.forceUpdateCollection(collectionName);
+         action = RETRY;
+       }","what about the line below, forceUpdateCollection?"
+3900,"@@ -72,9 +72,13 @@ module Beaker
+     def cmd_line host, cmd = @command, env = @environment, pc = @prepend_cmds
+       env_string = host.environment_string( env )
+       prepend_commands = host.prepend_commands( cmd, pc, :cmd_exe => @cmdexe )
++      if host[:platform] =~ /cisco_nexus/ && host[:user] != 'root'
++          append_command = '""'
++        cmd = cmd.gsub('""') { '\\""' }
++      end
+
+       # This will cause things like `puppet -t -v agent` which is maybe bad.
+-      cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string]
++      cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string, append_command]
+       cmd_line_array.compact.reject( &:empty? ).join( ' ' )
+     end
+ ",Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?
+3901,"@@ -31,7 +31,7 @@ export const refreshAuthentication = async () => {
+
+ 		// We should really be using state management. This is terrible.
+ 		global.googlesitekit.setup = global.googlesitekit.setup || {};
+-		global.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
++		global.googlesitekit.setup.authenticated = response.authenticated;
+ 		global.googlesitekit.setup.requiredScopes = response.requiredScopes;
+ 		global.googlesitekit.setup.grantedScopes = response.grantedScopes;
+ 		global.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;",I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route. All updates to the JS components above wouldn't be necessary.
+3902,"@@ -36,7 +36,7 @@ function sendCommandToFrame(node, parameters, resolve, reject) {
+         reject(err('No response from frame', node));
+       }
+     }, 0);
+-  }, 500);
++  }, parameters.options?.pingWaitTime ?? 500);
+
+   // send 'axe.ping' to the frame
+   respondable(win, 'axe.ping', null, undefined, () => {","Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here."
+3903,"@@ -11,11 +11,15 @@ TEST_DATA = '{""StreamName"": ""NotExistingStream""}'
+ class KinesisListenerTest(unittest.TestCase):
+
+     def test_describe_stream_summary_is_redirected(self):
+-        describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'}
++        if config.KINESIS_PROVIDER == 'kinesalite':
++            describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'}
+
+-        response = UPDATE_KINESIS.forward_request('POST', '/', TEST_DATA, describe_stream_summary_header)
++            response = UPDATE_KINESIS.forward_request('POST', '/', TEST_DATA,
++                describe_stream_summary_header)
+
+-        self.assertEqual(response, True)
++            self.assertEqual(response, True)
++        else:
++            self.assertTrue(True)
+
+     def test_random_error_on_put_record(self):
+         put_record_header = {'X-Amz-Target': 'Kinesis_20131202.PutRecord'}",I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock
+3904,"@@ -3,7 +3,7 @@
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee
++#Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee
+
+ from copy import deepcopy
+ import os",Please add your name to the list of copyright holders.
+3905,"@@ -50,6 +50,12 @@ public class IpPortManager {
+
+   private boolean autoDiscoveryInited = false;
+
++  private int maxRetryTimes;
++
++  public int getMaxRetryTimes() {
++    return maxRetryTimes;
++  }
++
+   public IpPortManager(ServiceRegistryConfig serviceRegistryConfig, InstanceCacheManager instanceCacheManager) {
+     this.serviceRegistryConfig = serviceRegistryConfig;
+     this.instanceCacheManager = instanceCacheManager;","Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?"
+3906,"@@ -439,7 +439,7 @@ type CloneLink struct {
+ 	Git   string
+ }
+
+-func (repo *Repository) cloneLink(isWiki bool) *CloneLink {
++func (repo *Repository) cloneLink(isWiki bool, signedUserName string) *CloneLink {
+ 	repoName := repo.Name
+ 	if isWiki {
+ 		repoName += "".wiki""","Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method."
+3907,"@@ -65,6 +65,13 @@ namespace Datadog.Trace
+             AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit;
+             AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException;
+             Console.CancelKeyPress += Console_CancelKeyPress;
++
++            // If configured, add/remove the correlation identifiers into the
++            // LibLog logging context when a scope is activated/closed
++            if (Settings.LogsInjectionEnabled)
++            {
++                new LibLogCorrelationIdentifierScopeSubscriber(_scopeManager);
++            }
+         }
+
+         /// <summary>",How would you feel about a static method to express intent?
+3908,"@@ -75,7 +75,8 @@ func (t LoggableTLSConnState) MarshalLogObject(enc zapcore.ObjectEncoder) error
+ 	enc.AddUint16(""version"", t.Version)
+ 	enc.AddUint16(""cipher_suite"", t.CipherSuite)
+ 	enc.AddString(""proto"", t.NegotiatedProtocol)
+-	enc.AddBool(""proto_mutual"", t.NegotiatedProtocolIsMutual)
++	// NegotiatedProtocolIsMutual is deprecated - it's always true
++	enc.AddBool(""proto_mutual"", true)
+ 	enc.AddString(""server_name"", t.ServerName)
+ 	if len(t.PeerCertificates) > 0 {
+ 		enc.AddString(""client_common_name"", t.PeerCertificates[0].Subject.CommonName)",Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?
+3909,"@@ -16,8 +16,7 @@
+
+ package account
+
+-//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go
+-//go:generate dbgen -i part.sql -p account -n part -o partInstall.go
++//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go -h ../../scripts/LICENSE_HEADER
+ import (
+ 	""database/sql""
+ 	""fmt""","the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either."
+3910,"@@ -97,3 +97,11 @@ func (c *TTLCache) Delete(key interface{}) error {
+ 	c.entries.Delete(key)
+ 	return nil
+ }
++
++func (c *TTLCache) GetAll() ([]interface{}, error) {
++	return nil, cache.ErrUnimplemented
++}
++
++func (c *TTLCache) PutHash(k interface{}, v interface{}) error {
++	return cache.ErrUnimplemented
++}",`k` is unused in PutHash
+3911,"@@ -277,4 +277,12 @@ public class Utils {
+ 		Method method = clazz.getDeclaredMethod(methodName, argTypes);
+ 		return method.invoke(null, args);
+ 	}
++
++	public static void copyStream(InputStream input, OutputStream output) throws IOException {
++		byte[] buffer = new byte[1024];
++		int bytesRead;
++		while ((bytesRead = input.read(buffer)) != -1) {
++			output.write(buffer, 0, bytesRead);
++		}
++	}
+ }",Use IOUtils instead
+3912,"@@ -27,6 +27,8 @@ type idmFake struct {
+ 	unlockFails          bool
+ }
+
++// NewIdentityManagerFake creates fake identity manager for testing purposes
++// TODO each caller should use it's own mocked manager part instead of global one
+ func NewIdentityManagerFake(existingIdentities []Identity, newIdentity Identity) *idmFake {
+ 	return &idmFake{"""", """", existingIdentities, newIdentity, false}
+ }","It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited."
+3913,"@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+
+
+ class Options(object):
++    KEY = ""goog:chromeOptions""
+
+     def __init__(self):
+         self._binary_location = ''",nice touch since Google likes to change things every now and then.
+3914,"@@ -1174,7 +1174,8 @@ public final class SolrCore implements SolrInfoBean, Closeable {
+   }
+
+   private CircuitBreakerManager initCircuitBreakerManager() {
+-    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(solrConfig);
++    final PluginInfo info = solrConfig.getPluginInfo(CircuitBreakerManager.class.getName());
++    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(info.initArgs);
+
+     return circuitBreakerManager;
+   }",Make `CircuitBreakerManager` implement `PluginInfoInitialized`
+3915,"@@ -679,7 +679,7 @@ class _ServerCapabilities:
+ def _as_uint32(x: int) -> QVariant:
+     """"""Convert the given int to an uint32 for DBus.""""""
+     variant = QVariant(x)
+-    successful = variant.convert(QVariant.Type.UInt)
++    successful = variant.convert(QMetaType(QMetaType.Type.UInt.value))
+     assert successful
+     return variant
+ ","This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type."
+3916,"@@ -59,6 +59,12 @@ type Writer struct {
+
+ 	// These fields exist only when w is not created in the first place when
+ 	// NewWriter is called.
++	//
++	// A ctx is stored in the Writer since we need to pass it into NewTypedWriter
++	// when we finished detecting the content type of the object and create the
++	// underlying driver.Writer. This step happens inside Write or Close and
++	// neither of them take a context.Context as an argument. The ctx must be set
++	// to nil after we have done passing it.
+ 	ctx    context.Context
+ 	bucket driver.Bucket
+ 	key    string","Nit: finished -> finish, ""done passing it"" -> ""passed it""."
+3917,"@@ -46,5 +46,18 @@ module C2
+     config.autoload_paths << Rails.root.join('lib')
+
+     config.assets.precompile << 'common/communicarts.css'
++
++    # Paperclip's attachment settings are determined by S3 env vars
++    if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY']
++      Paperclip::Attachment.default_options.merge!(
++        bucket: ENV['S3_BUCKET_NAME'],
++        s3_credentials: {
++          access_key_id: ENV['S3_ACCESS_KEY_ID'],
++          secret_access_key: ENV['S3_SECRET_ACCESS_KEY']
++        },
++        s3_permissions: :private,
++        storage: :s3,
++      )
++    end
+   end
+ end",Maybe mention that it will be saved to the filesystem otherwise?
+3918,"@@ -108,7 +108,11 @@ namespace pwiz.Skyline.FileUI
+             {
+                 for (var i = 0; i < numColumns; i++)
+                 {
+-                    dataGrid.Columns[i].ToolTipText =
++                    // In the case when we don't have user provided headers, we still want localized headers that can be translated,
++                    // this replaces the autogenerated strings with a localized version
++                    dataGrid.Columns[i].HeaderText = string.Format(Resources.ImportTransitionListColumnSelectDlg_DisplayData_Column_) + (i+1).ToString();
++
++                    dataGrid.Columns[i].ToolTipText =
+                         string.Format(Resources.ImportTransitionListColumnSelectDlg_DisplayData_The_input_text_did_not_appear_to_contain_column_headers__Use_the_dropdown_control_to_assign_column_meanings_for_import_);
+                 }
+             }","Probably cleaner and more general to do this: string,Format(""Column {0}"", i+1) That way if the local language has a convention like ""3 column, this is"" it still works."
+3919,"@@ -74,11 +74,14 @@ func (v *validator) verifyActions(blk *Block, containCoinbase bool) error {
+ 	// Verify transfers, votes, executions, witness, and secrets (balance is checked in RunActions)
+ 	confirmedNonceMap := make(map[string]uint64)
+ 	accountNonceMap := make(map[string][]uint64)
++
++	transfers, votes, executions := action.ClassifyActions(blk.Actions)
+ 	var wg sync.WaitGroup
+-	wg.Add(len(blk.Transfers) + len(blk.Votes) + len(blk.Executions))
++	wg.Add(len(transfers) + len(votes) + len(executions))
++
+ 	var correctAction uint64
+ 	var coinbaseCount uint64
+-	for _, tsf := range blk.Transfers {
++	for _, tsf := range transfers {
+ 		// Verify Address
+ 		// Verify Gas
+ 		// Verify Nonce",This can be uniformed too
+3920,"@@ -16,14 +16,14 @@ type mock struct {
+ 	peers           []swarm.Address
+ 	closestPeer     swarm.Address
+ 	closestPeerErr  error
+-	addPeerErr      error
++	AddPeersErr     error
+ 	marshalJSONFunc func() ([]byte, error)
+ 	mtx             sync.Mutex
+ }
+
+-func WithAddPeerErr(err error) Option {
++func WithAddPeersErr(err error) Option {
+ 	return optionFunc(func(d *mock) {
+-		d.addPeerErr = err
++		d.AddPeersErr = err
+ 	})
+ }
+ ",It looks to me that this does not have to be exported.
+3921,"@@ -61,6 +61,14 @@ public abstract class ApiConfig {
+     }
+   }
+
++  /**
++   * Creates an ApiConfig with no content. Exposed for testing.
++   */
++  public static ApiConfig createDummyApiConfig() {
++    return new AutoValue_ApiConfig(ImmutableMap.<String, InterfaceConfig> builder().build(), null,
++        false);
++  }
++
+   private static String getPackageName(ConfigProto configProto) {
+     Map<String, LanguageSettingsProto> settingsMap = configProto.getLanguageSettings();
+     String language = configProto.getLanguage();","It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code."
+3922,"@@ -511,18 +511,6 @@ public class DataversePage implements java.io.Serializable {
+         }
+         setEditInputLevel(false);
+     }
+-
+-    public void toggleInputLevel( Long mdbId, long dsftId){
+-        for (MetadataBlock mdb : allMetadataBlocks) {
+-            if (mdb.getId().equals(mdbId)) {
+-                for (DatasetFieldType dsftTest : mdb.getDatasetFieldTypes()) {
+-                    if (dsftTest.getId().equals(dsftId)) {
+-                            dsftTest.setRequiredDV(!dsftTest.isRequiredDV());
+-                    }
+-                }
+-            }
+-        }
+-    }
+
+     public void updateInclude(Long mdbId, long dsftId) {
+         List<DatasetFieldType> childDSFT = new ArrayList<>();","Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)"
+3923,"@@ -186,6 +186,10 @@ func (h *Helper) ValidateIssuedCertificateRequest(cr *cmapi.CertificateRequest,
+ 		}
+ 	}
+
++	if !apiutil.CertificateRequestHasApproved(cr) {
++		return nil, fmt.Errorf(""CertificateRequest does not have an Approved condition: %+v"", cr.Status.Conditions)
++	}
++
+ 	return cert, nil
+ }
+ ",Suggestion: `.. does not have an Approved condition set to true`
+3924,"@@ -77,6 +77,7 @@ class BlazeMeterUploader(Reporter, AggregatorListener):
+         self.client.user_id = self.parameters.get(""user-id"", None)
+         self.client.data_signature = self.parameters.get(""signature"", None)
+         self.client.kpi_target = self.parameters.get(""kpi-target"", self.client.kpi_target)
++        self.client.delete_files_before_test = False
+
+         if not self.client.test_id:
+             try:",I would say that client class should have default of False and Cloud prov should enable deleting.
+3925,"@@ -1,4 +1,4 @@
+-// Copyright (c) .NET Foundation. All rights reserved.
++// Copyright (c) .NET Foundation. All rights reserved.
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+ using System;",Did this remove the BOM or something?
+3926,"@@ -99,6 +99,10 @@ public class BlockHeaderValidator<C> {
+     return parent;
+   }
+
++  public void addRule(final AttachedBlockHeaderValidationRule<C> rule) {
++    this.rules.add(new Rule<>(false, rule, rule.includeInLightValidation()));
++  }
++
+   private static class Rule<C> {
+     private final boolean detachedSupported;
+     private final AttachedBlockHeaderValidationRule<C> rule;","This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created."
+3927,"@@ -383,7 +383,7 @@ def outputDeviceNameToID(name, useDefaultIfInvalid=False):
+
+ fileWavePlayer = None
+ fileWavePlayerThread=None
+-def playWaveFile(fileName, async=True):
++def playWaveFile(fileName, asynchronous=True):
+ 	""""""plays a specified wave file.
+ """"""
+ 	global fileWavePlayer, fileWavePlayerThread",May be add information about parameters to the doc string while at it?
+3928,"@@ -43,8 +43,8 @@ public enum RpcMethod {
+   PRIV_DELETE_PRIVACY_GROUP(""priv_deletePrivacyGroup""),
+   PRIV_FIND_PRIVACY_GROUP(""priv_findPrivacyGroup""),
+   PRIV_DISTRIBUTE_RAW_TRANSACTION(""priv_distributeRawTransaction""),
++  PRIV_GET_TRANSACTION_COUNT_LEGACY(""priv_getTransactionCountLegacy""),
+   EEA_SEND_RAW_TRANSACTION(""eea_sendRawTransaction""),
+-  EEA_GET_TRANSACTION_COUNT(""eea_getTransactionCount""),
+   ETH_ACCOUNTS(""eth_accounts""),
+   ETH_BLOCK_NUMBER(""eth_blockNumber""),
+   ETH_CALL(""eth_call""),",Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?
+3929,"@@ -3901,9 +3901,6 @@ void CoreChecks::PreCallRecordFreeMemory(VkDevice device, VkDeviceMemory mem, co
+
+     // Clear mem binding for any bound objects
+     for (auto obj : mem_info->obj_bindings) {
+-        log_msg(report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, get_debug_report_enum[obj.type], obj.handle,
+-                kVUID_Core_MemTrack_FreedMemRef, ""VK Object %s still has a reference to mem obj %s."",
+-                report_data->FormatHandle(obj.handle).c_str(), report_data->FormatHandle(mem_info->mem).c_str());
+         BINDABLE *bindable_state = nullptr;
+         switch (obj.type) {
+             case kVulkanObjectTypeImage:","This one should probably be added to the list in #24 . It's possibly indicative of an issue, but there isn't a VUID for it."
+3930,"@@ -139,13 +139,11 @@ def build_network_url(project, network):
+       The fully qualified network url for the given project/network.
+     """"""
+     return (u'%(root)s%(api_name)s/%(version)s/projects/%(project)s/global/'
+-            'networks/%(network)s') % {
+-                'api_name': API_NAME,
+-                'network': network,
+-                'project': project,
+-                'root': API_ROOT,
+-                'version': API_VERSION
+-            }
++            'networks/%(network)s') % {'api_name': API_NAME,
++                                       'network': network,
++                                       'project': project,
++                                       'root': API_ROOT,
++                                       'version': API_VERSION}
+
+
+ class ComputeFirewallAPI(object):","Why this indentation change? Seems the original indentation would be fine, and leaves more room."
+3931,"@@ -145,7 +145,7 @@ class MultiDimensionalMapping(Dimensioned):
+             raise KeyError('Key has to match number of dimensions.')
+
+
+-    def _add_item(self, dim_vals, data, sort=True):
++    def _add_item(self, dim_vals, data, sort=True, update=True):
+         """"""
+         Adds item to the data, applying dimension types and ensuring
+         key conforms to Dimension type and values.",Would be nice to know what the `update` argument does in the docstring.
+3932,"@@ -1,10 +1,10 @@
+-import StringIO
+ from pathod import log
+ from netlib.exceptions import TcpDisconnect
+-import netlib.tcp
+
++from six.moves import cStringIO
+
+-class DummyIO(StringIO.StringIO):
++
++class DummyIO(cStringIO):
+
+     def start_log(self, *args, **kwargs):
+         pass",I think we can just use `io.BytesIO` here.
+3933,"@@ -155,13 +155,14 @@ func NewGCPgRPCConn(ctx context.Context, t *testing.T, endPoint, api string) (*g
+ }
+
+ // NewAzureTestPipeline creates a new connection for testing against Azure Blob.
+-func NewAzureTestPipeline(ctx context.Context, t *testing.T, accountName string, accountKey string) (pipeline pipeline.Pipeline, done func(), httpClient *http.Client) {
++func NewAzureTestPipeline(ctx context.Context, t *testing.T, api, accountName, accountKey string) (pipeline pipeline.Pipeline, done func(), httpClient *http.Client) {
+ 	mode := recorder.ModeReplaying
+ 	if *Record {
+ 		mode = recorder.ModeRecording
+ 	}
+
+ 	azMatchers := &replay.ProviderMatcher{
++		Headers: []string{""User-Agent""},
+ 		URLScrubbers: []*regexp.Regexp{
+ 			regexp.MustCompile(`se=[^?]*`),
+ 			regexp.MustCompile(`sig=[^?]*`),",This ensures that the User-Agent header matches during replay.
+3934,"@@ -3517,6 +3517,7 @@ XDDkwd__(SUBQUERY_UNNESTING,			""ON""),
+  XDDui1__(USTAT_MIN_ROWCOUNT_FOR_LOW_SAMPLE,    ""1000000""),
+  XDDui1__(USTAT_MIN_ROWCOUNT_FOR_SAMPLE,        ""10000""),
+   DDflt0_(USTAT_MODIFY_DEFAULT_UEC,             ""0.05""),
++  DDflt0_(USTAT_NAHEAP_ESTIMATED_MAX,           ""1.3""),  // estimated max memory allocation feasible with NAHEAP.
+  XDDui1__(USTAT_NECESSARY_SAMPLE_MAX,           ""5000000""), // Maximum sample size with NECESSARY
+   DDui1__(USTAT_NUM_MC_GROUPS_FOR_KEYS,         ""10""),
+  XDDpct__(USTAT_OBSOLETE_PERCENT_ROWCOUNT,      ""15""),",What units are used for this default?
+3935,"@@ -47,7 +47,13 @@ public struct Ability : IFlatbufferObject
+
+ public class AbilityT
+ {
++#if ENABLE_JSON_SERIALIZATION
++  [Newtonsoft.Json.JsonProperty(""id"")]
++#endif
+   public uint Id { get; set; }
++#if ENABLE_JSON_SERIALIZATION
++  [Newtonsoft.Json.JsonProperty(""distance"")]
++#endif
+   public uint Distance { get; set; }
+
+   public AbilityT() {","I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified"
+3936,"@@ -584,8 +584,7 @@ class MainWindow(QWidget):
+         quit_texts = []
+         # Ask if multiple-tabs are open
+         if 'multiple-tabs' in config.val.confirm_quit and tab_count > 1:
+-            quit_texts.append(""{} {} open."".format(
+-                tab_count, ""tab is"" if tab_count == 1 else ""tabs are""))
++            quit_texts.append(""{} tabs are open."".format(tab_count))
+         # Ask if multiple downloads running
+         if 'downloads' in config.val.confirm_quit and download_count > 0:
+             quit_texts.append(""{} {} running."".format(","Doesn't this change the behavior (edit: oh, I see, never mind)."
+3937,"@@ -216,11 +216,15 @@ module Travis
+               sh.cmd 'sudo ln -f -s /lib/i386-linux-gnu/libpam.so.0 /lib/libpam.so.0'
+               sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so'
+             end
+-            sh.if '$(uname -m) != ppc64le && $(lsb_release -cs) = trusty' do
++            sh.elif '$(lsb_release -cs) = trusty' do
+               sh.cmd 'sudo dpkg --add-architecture i386'
+               gemstone_install_linux_dependencies
+               sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so'
+             end
++            sh.elif '$(lsb_release -cs) = xenial || $(lsb_release -cs) = bionic' do
++              sh.cmd 'sudo dpkg --add-architecture i386'
++              gemstone_install_linux_dependencies
++            end
+           end
+
+           def gemstone_install_linux_dependencies",I think you need a `do` at the end of this line.
+3938,"@@ -5,7 +5,7 @@
+       <%= link_to(t('blacklight.search.sort.label', :field =>current_sort_field.label), ""#"") %> <span class=""caret""></span>
+       <ul>
+         <%- blacklight_config.sort_fields.each do |sort_key, field| %>
+-          <li><%= link_to(field.label, url_for(params_for_search(:sort => sort_key))) %></li>
++          <li><%= link_to(field.label, params_for_search(params.merge(:sort => sort_key))) %></li>
+         <%- end -%>
+       </ul>
+     </li>",Not passing in a `:params` key here.
+3939,"@@ -308,6 +308,7 @@ func (r *ReconcileClusterClaim) reconcileForDeletedCluster(claim *hivev1.Cluster
+ func (r *ReconcileClusterClaim) reconcileForNewAssignment(claim *hivev1.ClusterClaim, cd *hivev1.ClusterDeployment, logger log.FieldLogger) (reconcile.Result, error) {
+ 	logger.Info(""cluster assigned to claim"")
+ 	cd.Spec.ClusterPoolRef.ClaimName = claim.Name
++	cd.Spec.PowerState = hivev1.RunningClusterPowerState
+ 	if err := r.Update(context.Background(), cd); err != nil {
+ 		logger.WithError(err).Log(controllerutils.LogLevel(err), ""could not set claim for ClusterDeployment"")
+ 		return reconcile.Result{}, err","Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to create / update powerstate on gcp/azure/etc. I'd pitch we put this onto the pool spec and make you opt in."
+3940,"@@ -5,13 +5,14 @@
+
+ // The conditions looks weird, but it seems like _OR_GREATER is not supported yet in all environments
+ // We can trim all the additional conditions when this is fixed
+-#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0
++#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0 || NET6_0
+
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Net;
+ using System.Threading.Tasks;
++using Datadog.Trace.IntegrationTestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+ ",I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong.
+3941,"@@ -236,6 +236,15 @@ func (r *RollDPoS) CurrentState() fsm.State {
+ 	return r.cfsm.CurrentState()
+ }
+
++// Activate activates or pauses the roll-DPoS consensus. When it is deactivated, the node will finish the current
++// consensus round if it is doing the work and then return the the initial state
++func (r *RollDPoS) Activate(active bool) { r.ctx.Activate(active) }
++
++// Active is true if the roll-DPoS consensus is active, or false if it is stand-by
++func (r *RollDPoS) Active() bool {
++	return r.ctx.Active() || r.cfsm.CurrentState() != consensusfsm.InitState
++}
++
+ // Builder is the builder for RollDPoS
+ type Builder struct {
+ 	cfg config.Config",what's the second part for?
+3942,"@@ -79,7 +79,7 @@ public class DirectSolrSpellCheckerTest extends SolrTestCaseJ4 {
+       return null;
+     });
+   }
+-
++
+   @Test
+   public void testOnlyMorePopularWithExtendedResults() throws Exception {
+     assertQ(req(""q"", ""teststop:fox"", ""qt"", ""/spellCheckCompRH"", SpellCheckComponent.COMPONENT_NAME, ""true"", SpellingParams.SPELLCHECK_DICT, ""direct"", SpellingParams.SPELLCHECK_EXTENDED_RESULTS, ""true"", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, ""true""),","It's not clear to me what the ""super"" test above is for. As far as I can see, the test runs a spellcheck for ""super"" but then uses ""fob"" as the index into suggestions, which will never find an entry."
+3943,"@@ -24,7 +24,7 @@ import (
+ 	""google.golang.org/grpc/status""
+
+ 	logfilter ""github.com/iotexproject/iotex-core/api/logfilter""
+-	""github.com/iotexproject/iotex-core/ioctl/util""
++	ioctlUtil ""github.com/iotexproject/iotex-core/ioctl/util""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ )
+ ",revert this file change
+3944,"@@ -74,9 +74,9 @@ class FileState:
+         #
+         # 1.   def meth8(self):
+         # 2.        """"""test late disabling""""""
+-        # 3.        pylint: disable=not-callable
++        # 3.        pylint: disable=not-callable, useless-suppression
+         # 4.        print(self.blip)
+-        # 5.        pylint: disable=no-member
++        # 5.        pylint: disable=no-member, useless-suppression
+         # 6.        print(self.bla)
+         #
+         # E1102 should be disabled from line 1 to 6 while E1101 from line 5 to 6",I think this is the most elegant way to allow us to still fail on `I`.
+3945,"@@ -415,10 +415,15 @@ class AdminController extends Controller
+             ->from($entityClass, 'entity')
+         ;
+
++        $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();
++        $searchQuery = addcslashes($searchQuery, implode('', $wildcards));
++
+         foreach ($searchableFields as $name => $metadata) {
+-            $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();
+-            $searchQuery = addcslashes($searchQuery, implode('', $wildcards));
+-            $query->orWhere('entity.'.$name.' LIKE :query')->setParameter('query', '%'.$searchQuery.'%');
++            if (in_array($metadata['fieldType'], array('text', 'string'))) {
++                $query->orWhere('entity.'.$name.' LIKE :fuzzy_value')->setParameter('fuzzy_value', '%'.$searchQuery.'%');
++            } else {
++                $query->orWhere('entity.'.$name.' = :exact_value')->setParameter('exact_value', $searchQuery);
++            }
+         }
+
+         $paginator = new Pagerfanta(new DoctrineORMAdapter($query, false));",Wouldn't it be better to use a sql `IN ( :exact_value )` ?
+3946,"@@ -9,9 +9,14 @@ module Bolt
+
+       @shell = shell
+       @endpoint = ""http://#{host}:#{port}/wsman""
+-      @connection = ::WinRM::Connection.new(endpoint: @endpoint,
+-                                            user: @user,
+-                                            password: @password)
++      options = { endpoint: @endpoint,
++                  user: @user,
++                  password: @password }
++      if @timeout then
++        options[:receive_timeout] = @timeout
++        options[:operation_timeout] = @timeout
++      end
++      @connection = ::WinRM::Connection.new(options)
+       @connection.logger = @transport_logger
+     end
+ ",So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior.
+3947,"@@ -68,7 +68,7 @@ class ApacheBenchmarkExecutor(ScenarioExecutor, WidgetProvider, HavingInstallabl
+         return self.widget
+
+     def __first_http_request(self):
+-        for request in self.scenario.get_requests():
++        for request in self.get_requests():
+             if isinstance(request, HTTPRequest):
+                 return request
+         return None","So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way."
+3948,"@@ -2436,10 +2436,10 @@ public:
+ 		}
+ 		else if (message_a.response)
+ 		{
+-			auto node_id (message_a.response->first);
+-			connection->remote_node_id = node_id;
++			nano::account node_id (message_a.response->first);
+ 			if (!connection->node->network.syn_cookies.validate (nano::transport::map_tcp_to_endpoint (connection->remote_endpoint), node_id, message_a.response->second) && node_id != connection->node->node_id.pub)
+ 			{
++				connection->remote_node_id = node_id;
+ 				connection->type = nano::bootstrap_server_type::realtime;
+ 				++connection->node->bootstrap.realtime_count;
+ 				connection->finish_request_async ();","This existed already, but seeing as you are changing the variable to have an explicit type it could be made a const reference to remove a copy."
+3949,"@@ -0,0 +1,11 @@
++module Faker
++  class FamousLastWords < Base
++    flexible :famous_last_words
++
++    class << self
++      def name
++        fetch('famous_last_words.phrase')
++      end
++    end
++  end
++end",I don't think this code is being tested; this method can be removed without the test failing
+3950,"@@ -298,6 +298,11 @@ public class FrameFragment extends BaseEditFragment {
+     // Asynchronous loading of thumbnails
+     private class asyncThumbs extends AsyncTask<Void, Void, Void> {
+
++        @Override
++        protected void onPreExecute() {
++            arrayList=new ArrayList<>();
++        }
++
+         @Override
+         protected Void doInBackground(Void... params) {
+             arrayList = new ArrayList<>();",@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?
+3951,"@@ -0,0 +1,13 @@
++describe Gsa18f::ProcurementPolicy do
++  subject { described_class }
++
++  permissions :can_create? do
++    with_feature 'RESTRICT_ACCESS' do
++      it ""doesn't allow someone with a non-GSA email to create"" do
++        user = User.new(email_address: 'intruder@some.com')
++        procurement = Gsa18f::Procurement.new
++        expect(subject).not_to permit(user, procurement)
++      end
++    end
++  end
++end","This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)"
+3952,"@@ -18,13 +18,13 @@ define(['dom', 'scroller', 'browser', 'layoutManager', 'focusManager', 'register
+
+     function onFocus(e) {
+
+-        if (layoutManager.tv) {
++        /*if (layoutManager.tv) {
+
+             if (this.focusTimeout) {
+                 clearTimeout(this.focusTimeout);
+             }
+             this.focusTimeout = setTimeout(getFocusCallback(this, e), 700);
+-        }
++        }*/
+     }
+
+     function getTabPanel(tabs, index) {","Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process..."
+3953,"@@ -23,3 +23,10 @@ import (
+ type ConnTrackDumper interface {
+ 	DumpFlows(zoneFilter uint16) ([]*flowexporter.Connection, error)
+ }
++
++// ConnTrackInterfacer is an interface created to consume the required dump functions from either the third party
++// conntrack library or internal packages depending on OVS datapath type or OS.
++type ConnTrackInterfacer interface {
++	GetConnTrack(config interface{}) error // suggest a different name for config if it is not appropriate
++	DumpFilter(filter interface{}) ([]*flowexporter.Connection, error)
++}","I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called ""Get*"" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pretty clear to me that this interface needs to be rethought. An interface where all the parameters are themselves arbitrary objects (`interface{}`), whose actual type depends on the specific interface implementation, is not a helpful abstraction"
+3954,"@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap;
+ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.Multimap;
+
++import org.openqa.selenium.devtools.target.model.SessionId;
+ import org.openqa.selenium.json.Json;
+ import org.openqa.selenium.json.JsonInput;
+ import org.openqa.selenium.remote.http.HttpClient;",It fills me with endless sadness that we can't use Selenium's own `SessionId` here.
+3955,"@@ -2269,7 +2269,12 @@ public class ZkStateReader implements SolrCloseable {
+       log.debug(""Checking ZK for most up to date Aliases {}"", ALIASES);
+       // Call sync() first to ensure the subsequent read (getData) is up to date.
+       zkClient.getSolrZooKeeper().sync(ALIASES, null, null);
+-      Stat stat = new Stat();
++      Stat stat = zkClient.exists(ALIASES, null, true);
++      if (stat.getVersion() <= aliases.getZNodeVersion()) {
++        //we already have the latest version.
++        return false;
++      }
++      stat = new Stat();
+       final byte[] data = zkClient.getData(ALIASES, null, stat, true);
+       return setIfNewer(Aliases.fromJSON(data, stat.getVersion()));
+     }","Interesting. So you've found that it's faster to request only the ""Stat"" without the data so long as this is the typical path?"
+3956,"@@ -33,6 +33,7 @@ var skip = map[string]string{
+ 	""yield"":                       ""yield requires special test case (https://github.com/influxdata/flux/issues/535)"",
+ 	""task_per_line"":               ""join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)"",
+ 	""rowfn_with_import"":           ""imported libraries are not visible in user-defined functions (https://github.com/influxdata/flux/issues/1000)"",
++	""string_trim"":                 ""cannot reference a package function from within a row function"",
+ }
+
+ var querier = querytest.NewQuerier()",Is this a future fix? I thought the local identifier scope and the package issue were the same one.
+3957,"@@ -247,7 +247,17 @@ class TextInfoQuickNavItem(QuickNavItem):
+ class BrowseModeTreeInterceptor(treeInterceptorHandler.TreeInterceptor):
+ 	scriptCategory = inputCore.SCRCAT_BROWSEMODE
+ 	disableAutoPassThrough = False
+-	APPLICATION_ROLES = (controlTypes.ROLE_APPLICATION, controlTypes.ROLE_DIALOG)
++
++	def _isApplicationObject(self,obj):
++		""""""
++		Checks whether the given object in this browseMode treeInterceptor is an application (I.e. although the root of the object is represented in the treeInterceptor, its content is not).
++		I.e. an application or modal dialog.
++		""""""
++		if obj.role==controlTypes.ROLE_APPLICATION:
++			return True
++		elif obj.role==controlTypes.ROLE_DIALOG and controlTypes.STATE_MODAL in obj.states:
++			return True
++		return False
+
+ 	def _get_currentNVDAObject(self):
+ 		raise NotImplementedError","Not super important, but this line could be split up."
+3958,"@@ -150,6 +150,17 @@ void h2o_context_dispose(h2o_context_t *ctx)
+     h2o_filecache_destroy(ctx->filecache);
+     ctx->filecache = NULL;
+
++    /* clear storage */
++    for (i = 0; i != ctx->storage.size; ++i) {
++        h2o_context_storage_item_t item = ctx->storage.entries[i];
++        if (item.data != NULL) {
++            if (item.dispose != NULL) {
++                item.dispose(item.data);
++            }
++        }
++    }
++    free(ctx->storage.entries);
++
+     /* TODO assert that the all the getaddrinfo threads are idle */
+     h2o_multithread_unregister_receiver(ctx->queue, &ctx->receivers.hostinfo_getaddr);
+     h2o_multithread_destroy_queue(ctx->queue);",Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up).
+3959,"@@ -33,6 +33,7 @@ inline void SyncedMemory::to_cpu() {
+       CaffeMallocHost(&cpu_ptr_, size_);
+       own_cpu_data_ = true;
+     }
++    Caffe::set_mode(Caffe::GPU);
+     caffe_memcpy(size_, gpu_ptr_, cpu_ptr_);
+     head_ = SYNCED;
+     break;","Why set to GPU, is it CPU?"
+3960,"@@ -1,10 +1,16 @@
+ import AppointmentIndexRoute from 'hospitalrun/appointments/index/route';
+ import moment from 'moment';
+ import { translationMacro as t } from 'ember-i18n';
++import Ember from 'ember';
++
++const { computed } = Ember;
++
+ export default AppointmentIndexRoute.extend({
+   editReturn: 'appointments.today',
+   modelName: 'appointment',
+-  pageTitle: t('appointments.todayTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('appointments.todayTitle');
++  }),
+
+   _modelQueryParams() {
+     let endOfDay = moment().endOf('day').toDate().getTime();",This should be `computed('i18n.locale'....`
+3961,"@@ -49,7 +49,7 @@ type Session struct {
+ 	DataTransferred DataTransferred
+ 	TokensEarned    uint64
+ 	Last            bool
+-	done            chan struct{}
++	Done            chan struct{}
+ }
+
+ // newSession creates a blank new session with an ID.",can we not expose the channel directly? or at least expose it as a read only channel?
+3962,"@@ -88,6 +88,17 @@ AS_IF([test ""$YACC"" != ""bison -y""], [AC_MSG_ERROR([bison not found but required]
+
+ PKG_PROG_PKG_CONFIG
+
++# PKG_CHECK_VAR added to pkg-config 0.28
++m4_define_default(
++    [PKG_CHECK_VAR],
++    [AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])
++     AS_IF([test -z ""$$1""], [$1=`$PKG_CONFIG --variable=""$3"" ""$2""`])
++     AS_IF([test -n ""$$1""], [$4], [$5])])
++
++PKG_CHECK_VAR(bashcompdir, [bash-completion], [completionsdir], ,
++  bashcompdir=""${sysconfdir}/bash_completion.d"")
++AC_SUBST(bashcompdir)
++
+ AM_PATH_GLIB_2_0(,,AC_MSG_ERROR([GLib not found]))
+
+ dnl When bumping the gio-unix-2.0 dependency (or glib-2.0 in general),",Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds.
+3963,"@@ -0,0 +1,13 @@
++package cstor
++
++import (
++	""github.com/openebs/maya/cmd/cstor-volume-grpc/app/command""
++)
++
++func Snapshot(volName, snapName, targetIP string) (interface{}, error) {
++	return command.CreateSnapshot(volName, snapName, targetIP)
++}
++
++func SnapshotDelete(volName, snapName, targetIP string) (interface{}, error) {
++	return command.DestroySnapshot(volName, snapName, targetIP)
++}",We will be removing this maya/volume package completely. Do not use this.
+3964,"@@ -67,7 +67,7 @@ static train_result call_daal_kernel(const context_gpu& ctx,
+
+     daal::algorithms::classifier::ModelPtr model_ptr(new daal_knn::Model(column_count));
+     if (!model_ptr) {
+-        throw bad_alloc();
++        throw host_bad_alloc();
+     }
+
+     auto knn_model = static_cast<daal_knn::Model*>(model_ptr.get());",Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?
+3965,"@@ -42,14 +42,15 @@ type MinerCreateResult struct {
+
+ var minerCreateCmd = &cmds.Command{
+ 	Helptext: cmdkit.HelpText{
+-		Tagline: ""Create a new file miner with <pledge> sectors and <collateral> FIL"",
++		Tagline: ""Create a new file miner with <collateral> FIL"",
+ 		ShortDescription: `Issues a new message to the network to create the miner, then waits for the
+ message to be mined as this is required to return the address of the new miner.
+-Collateral must be greater than 0.001 FIL per pledged sector.`,
++Collateral will be committed at the rate of 0.001FIL per sector. When the
++miner's collateral drops below 0.001FIL, the miner will not be able to commit
++additional sectors.`,
+ 	},
+ 	Arguments: []cmdkit.Argument{
+-		cmdkit.StringArg(""pledge"", true, false, ""The size of the pledge (in sectors) for the miner""),
+-		cmdkit.StringArg(""collateral"", true, false, ""The amount of collateral in FIL to be sent (minimum 0.001 FIL per sector)""),
++		cmdkit.StringArg(""collateral"", true, false, ""The amount of collateral, in FIL""),
+ 	},
+ 	Options: []cmdkit.Option{
+ 		cmdkit.StringOption(""from"", ""Address to send from""),","Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height."
+3966,"@@ -0,0 +1,5 @@
++# -----------------------------------------------------------------------------
++#                     The CodeChecker Infrastructure
++#   This file is distributed under the University of Illinois Open Source
++#   License. See LICENSE.TXT for details.
++# -----------------------------------------------------------------------------",Please update the license header in each source file. For more information see: #2697
+3967,"@@ -144,8 +144,9 @@ class HttpClient {
+  * @param {function(!Error)} onError The function to call if the request fails.
+  * @param {?string=} opt_data The data to send with the request.
+  * @param {?RequestOptions=} opt_proxy The proxy server to use for the request.
++ * @param {!number=} retries The current number of retries.
+  */
+-function sendRequest(options, onOk, onError, opt_data, opt_proxy) {
++function sendRequest(options, onOk, onError, opt_data, opt_proxy, retries) {
+   var hostname = options.hostname;
+   var port = options.port;
+ ",!numbers -> numbers
+3968,"@@ -64,6 +64,6 @@ namespace AutoRest.Swagger.Validation.Core
+         /// <summary>
+         /// The collection of rules that apply to all properties regardless of other rules.
+         /// </summary>
+-        public static IEnumerable<Rule> UniversalRules = new[] { new NoControlCharacters() };
++        public static IEnumerable<Rule> UniversalRules = new List<Rule>();
+     }
+ }","so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about ""universal"". In case of this rule, even control characters may have their place in Swaggers, e.g. in `examples` sections where you can have raw response bodies where control characters are perfectly valid."
+3969,"@@ -115,7 +115,8 @@ module.exports = function exec(command, opt_options) {
+
+   var proc = childProcess.spawn(command, options.args || [], {
+     env: options.env || process.env,
+-    stdio: options.stdio || 'ignore'
++    stdio: options.stdio || 'ignore',
++    detached: true
+   });
+
+   // This process should not wait on the spawned child, however, we do","You're welcome to surface this option through the API, but I'm not going to make this the default behavior."
+3970,"@@ -76,10 +76,10 @@ func buildBinary(source, target string) error {
+ 	if !ok {
+ 		targetArch = runtime.GOARCH
+ 	}
+-	return buildBinaryFor(source, target, targetOS, targetArch)
++	return buildBinaryFor(source, target, targetOS, targetArch, false)
+ }
+
+-func buildBinaryFor(source, target, targetOS, targetArch string) error {
++func buildBinaryFor(source, target, targetOS, targetArch string, buildStatic bool) error {
+ 	log.Info().Msgf(""Building %s -> %s %s/%s"", source, target, targetOS, targetArch)
+
+ 	buildDir, err := filepath.Abs(path.Join(""build"", target))","Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability."
+3971,"@@ -44,8 +44,11 @@ namespace OpenTelemetry.Metrics
+
+             var options = new InMemoryExporterOptions();
+             configure?.Invoke(options);
+-            var exporter = new InMemoryMetricExporter(exportedItems, options);
+-            return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));
++
++            // var exporter = new InMemoryMetricExporter(exportedItems, options);
++            // return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));
++
++            return builder;
+         }
+     }
+ }",I'll fix the InMemoryExporter right after this PR lands
+3972,"@@ -11098,7 +11098,7 @@ bool CoreChecks::ValidateCreateSwapchain(const char *func_name, VkSwapchainCreat
+
+     auto physical_device_state = GetPhysicalDeviceState();
+     if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) {
+-        if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
++        if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
+                     HandleToUint64(physical_device), kVUID_Core_DrawState_SwapchainCreateBeforeQuery,
+                     ""%s: surface capabilities not retrieved for this physical device"", func_name))
+             return true;","Good call, none of these are technically invalid"
+3973,"@@ -20,7 +20,7 @@ partial class Build
+         .OnlyWhenStatic(() => IsWin)
+         .Executes(() =>
+         {
+-            var project = ProfilerDirectory.GlobFiles(""**/Datadog.AutoInstrumentation.Profiler.Native.Windows.vcxproj"").Single();
++            var project = ProfilerDirectory.GlobFiles(""**/Datadog.Profiler.Native.Windows.vcxproj"").Single();
+
+             // run: msbuild /property:Configuration=${{matrix.configuration}} /property:Platform=${{matrix.platform}}  dd-continuous-profiler-dotnet\src\ProfilerEngine\Datadog.AutoInstrumentation.Profiler.Native.Windows\Datadog.AutoInstrumentation.Profiler.Native.Windows.WithTests.proj
+             // If we're building for x64, build for x86 too",this one should be updated too
+3974,"@@ -39,6 +39,7 @@ public final class InvocationFactory {
+         operationMeta,
+         swaggerArguments);
+     invocation.addContext(Const.SRC_MICROSERVICE, getMicroserviceName());
++    invocation.addContext(Const.SRC_INSTANCE, getInstanceId());
+     return invocation;
+   }
+ ",maybe need to add microserviceId too.
+3975,"@@ -0,0 +1,6 @@
++""""""Tests for missing-param-doc and missing-type-doc for Numpy style docstrings
++with accept-no-param-doc = no
++""""""
++# pylint: disable=invalid-name, unused-argument, undefined-variable
++# pylint: disable=line-too-long, too-few-public-methods, missing-class-docstring
++# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements","I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything ?"
+3976,"@@ -939,12 +939,10 @@ describe('Core_alter', () => {
+       expect(spec().$container.find('tr:eq(6) td:eq(0)').html()).toEqual('b1');
+     });
+
+-    it('should not add more source rows than defined in maxRows when trimming rows using the modifyRow hook', () => {
++    it('should not add more source rows than defined in maxRows when trimming rows using the TrimRows plugin', () => {
+       const hot = handsontable({
+         data: Handsontable.helper.createSpreadsheetData(10, 4),
+-        modifyRow(row) {
+-          return [8, 9].indexOf(row) > -1 ? null : row;
+-        },
++        trimRows: [8, 9],
+         maxRows: 10
+       });
+ ",It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`.
+3977,"@@ -688,6 +688,17 @@ static int on_config_mime_setdefaulttype(h2o_configurator_command_t *cmd, h2o_co
+     return 0;
+ }
+
++static const char *get_ext(h2o_configurator_command_t *cmd, yoml_t *node)
++{
++    if (strcmp(node->data.scalar, ""default"") == 0) {
++        return node->data.scalar;
++    } else if  (assert_is_extension(cmd, node) == 0) {
++        return node->data.scalar + 1;
++    } else {
++        return NULL;
++    }
++}
++
+ static int on_config_custom_handler(h2o_configurator_command_t *cmd, h2o_configurator_context_t *ctx, yoml_t *node)
+ {
+     static const char *ignore_commands[] = {""extension"", NULL};","The function seems to either return ""default"" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?"
+3978,"@@ -110,6 +110,8 @@ type Container struct {
+ 	Image string
+ 	// ImageID is the local ID of the image used in the container
+ 	ImageID string
++	// ImageDigest is the sha-256 digest of the container image as pulled from the repository
++	ImageDigest string
+ 	// Command is the command to run in the container which is specified in the task definition
+ 	Command []string
+ 	// CPU is the cpu limitation of the container which is specified in the task definition",this may require a statefile version update
+3979,"@@ -4,6 +4,9 @@ namespace Shopsys\FrameworkBundle\Component\Csv;
+
+ use Symfony\Component\Filesystem\Exception\FileNotFoundException;
+
++/**
++ * @deprecated Class is obsolete and will be removed in the next major. Use SplFileObject::fgetcsv() instead.
++ */
+ class CsvReader
+ {
+     /**","I like when `@deprecated` contains how to resolve it - eg. ""use `SplFileObject::fgetcsv()` instead"". The information in upgrade notes is usefull only during upgrade."
+3980,"@@ -7,8 +7,8 @@ package mock
+ import (
+ 	gomock ""github.com/golang/mock/gomock""
+ 	gcpclient ""github.com/openshift/hive/pkg/gcpclient""
+-	v1 ""google.golang.org/api/compute/v1""
+-	v10 ""google.golang.org/api/dns/v1""
++	compute ""google.golang.org/api/compute/v1""
++	dns ""google.golang.org/api/dns/v1""
+ 	reflect ""reflect""
+ )
+ ",Nice to see that your local environment is up-to-date now for these changes.
+3981,"@@ -1268,7 +1268,13 @@ var AppRouter = Backbone.Router.extend({
+         }
+
+         // Init sidebar based on the current url
+-        self.sidebar.init();
++        if (countlyVue.sideBarComponent) {
++            var selectedMenuItem = countlyVue.sideBarComponent.$store.getters[""countlySidebar/getSelectedMenuItem""];
++            var currLink = ""#"" + Backbone.history.fragment;
++            if (selectedMenuItem.item.url !== currLink) {
++                countlyVue.sideBarComponent.$store.dispatch(""countlySidebar/updateSelectedMenuItem"", null);
++            }
++        }
+     },
+     sidebar: {
+         init: function() {","Instead of setting it to null, i think lets set it to {}"
+3982,"@@ -23,8 +23,8 @@ import (
+ )
+
+ const (
+-	TPRGroup   = ""monitoring.coreos.com""
+-	TPRVersion = ""v1alpha1""
++	Group   = ""monitoring.coreos.com""
++	Version = ""v1alpha1""
+ )
+
+ type MonitoringV1alpha1Interface interface {","We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the ""alpha"" stamp."
+3983,"@@ -59,6 +59,15 @@ AS_CASE($ax_cv_cxx_compiler_vendor,
+ AX_CXX_COMPILE_STDCXX([11], [noext], [mandatory])
+
+ X_AC_ENABLE_SANITIZER
++if test ""x$san_enabled"" != ""xno"" ; then
++  AC_DEFINE([DEEPBIND], [0],
++            [deepbind is unsupported with asan, musl and so-forth])
++else
++  AC_DEFINE([DEEPBIND], [RTLD_DEEPBIND],
++            [deepbind is unsupported with asan, musl and so-forth])
++fi
++
++
+ LT_INIT
+ AC_PROG_AWK
+ ",I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define.
+3984,"@@ -393,7 +393,7 @@ func init() {
+ 	proto.RegisterType((*StatusResponse)(nil), ""bpfki.StatusResponse"")
+ }
+
+-func init() { proto.RegisterFile(""bpfki.proto"", fileDescriptor_62eed357eb71de0e) }
++func init() { protoregistry.GlobalFiles.RegisterFile(""bpfki.proto"", fileDescriptor_62eed357eb71de0e) }
+
+ var fileDescriptor_62eed357eb71de0e = []byte{
+ 	// 518 bytes of a gzipped FileDescriptorProto",Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file.
+3985,"@@ -15,6 +15,7 @@ import java.util.List;
+  *
+  * @author Brian Remedios
+  */
++@Deprecated
+ public class IntegerPropertyTest extends AbstractNumericPropertyDescriptorTester<Integer> {
+
+     private static final int MIN = 1;",We should make sure that we cover the testcases in a new unit test class.
+3986,"@@ -0,0 +1,19 @@
++package proofs
++
++// #cgo LDFLAGS: -L${SRCDIR}/../proofs/lib -lfilecoin_proofs
++// #cgo pkg-config: ${SRCDIR}/../proofs/lib/pkgconfig/libfilecoin_proofs.pc
++// #include ""../proofs/include/libfilecoin_proofs.h""
++import ""C""
++import (
++	""unsafe""
++)
++
++func SectorSize(ssType Mode) uint64 {
++	scfg, err := CProofsMode(ssType)
++	if err != nil {
++		return 0
++	}
++
++	numFromC := C.get_max_user_bytes_per_staged_sector((*C.ConfiguredStore)(unsafe.Pointer(scfg)))
++	return uint64(numFromC)
++}","Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser"
+3987,"@@ -192,7 +192,7 @@ func (p *Plugin) setConfig(config *pluginConfig) error {
+ 		p.cancelWatcher()
+ 		p.cancelWatcher = nil
+ 	}
+-	if config.WebhookLabel != """" {
++	if config.WebhookLabel != """" || config.APIServiceLabel != """" {
+ 		p.cancelWatcher = cancelWatcher
+ 	}
+ ","Super curious how you noticed this, as SPIRE itself currently only configures once...?"
+3988,"@@ -21,11 +21,18 @@ public class NotFoundExceptionHandler implements ExceptionMapper<NotFoundExcepti
+     @Override
+     public Response toResponse(NotFoundException ex){
+         String uri = request.getRequestURI();
++        String exMessage = ex.getMessage();
++        String outputMessage;
++        if (exMessage != null && exMessage.startsWith(""Datafile"")) {
++            outputMessage = exMessage;
++        } else {
++            outputMessage = ""endpoint does not exist on this server. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."";
++        }
+         return Response.status(404)
+                 .entity( Json.createObjectBuilder()
+                              .add(""status"", ""ERROR"")
+                              .add(""code"", 404)
+-                             .add(""message"", ""'"" + uri + ""' endpoint does not exist on this server. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."")
++                             .add(""message"", ""'"" + uri + ""' "" + outputMessage)
+                         .build())
+                 .type(""application/json"").build();
+         ","This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it ""DataFile""."
+3989,"@@ -18,5 +18,6 @@ package azkaban.db;
+
+ public class AzDBUtil {
+
+-  static final int MAX_DB_RETRY_COUNT = 5;
++  // A very big Integer
++  static final int MAX_DB_RETRY_COUNT = 999999;
+ }","if it keeps reconnecting for too long, how should we get alerted?"
+3990,"@@ -263,7 +263,11 @@ void* CNSKListenerSrvr::OpenTCPIPSession()
+ //LCOV_EXCL_STOP
+ 	}
+
+-
++    TCP_SetKeepalive(nSocketFnum,
++            srvrGlobal->clientKeepaliveStatus,
++            srvrGlobal->clientKeepaliveIdletime,
++            srvrGlobal->clientKeepaliveIntervaltime,
++            srvrGlobal->clientKeepaliveRetrycount);
+ 	pnode = GTransport.m_TCPIPSystemSrvr_list->ins_node(nSocketFnum);
+
+ 	if (pnode == NULL)",it's better to use single name style in one name.
+3991,"@@ -70,7 +70,7 @@ bool EprosimaServer::init()
+ {
+ 	//CREATE RTPSParticipant
+ 	ParticipantAttributes PParam;
+-	PParam.rtps.defaultSendPort = 10042;
++	//PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
+ 	PParam.rtps.builtin.domainId = 80;
+ 	PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
+ 	PParam.rtps.builtin.use_SIMPLE_RTPSParticipantDiscoveryProtocol = true;","As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line"
+3992,"@@ -95,7 +95,8 @@ func (cf CloudFormation) DelegateDNSPermissions(project *archer.Project, account
+ 	deployProject.DNSDelegationAccounts = append(dnsDelegatedAccounts, accountID)
+ 	updatedProjectConfig := stack.NewProjectStackConfig(&deployProject)
+
+-	if err := cf.update(updatedProjectConfig); err != nil {
++	// swallow the errChangeSetEmpty error since it just means there were no updates needed.
++	if err := cf.update(updatedProjectConfig); err != nil && err != errChangeSetEmpty {
+ 		return fmt.Errorf(""updating project to allow DNS delegation: %w"", err)
+ 	}
+ ",Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?
+3993,"@@ -153,13 +153,12 @@ public abstract class VectorWriter implements Closeable {
+     private final DocIDMerger<VectorValuesSub> docIdMerger;
+     private final int[] ordBase;
+     private final int cost;
+-    private final int size;
++    private int size;
+
+     private int docId;
+     private VectorValuesSub current;
+-    // For each doc with a vector, record its ord in the segments being merged. This enables random
+-    // access into the
+-    // unmerged segments using the ords from the merged segment.
++    /* For each doc with a vector, record its ord in the segments being merged. This enables random access into the unmerged segments using the ords from the merged segment.
++     */
+     private int[] ordMap;
+     private int ord;
+ ","Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it"
+3994,"@@ -47,10 +47,11 @@ type Selector struct {
+
+ // SpiffeIDSpec defines the desired state of SpiffeID
+ type SpiffeIDSpec struct {
+-	ParentId string   `json:""parentId""`
+-	SpiffeId string   `json:""spiffeId""`
+-	Selector Selector `json:""selector""`
+-	DnsNames []string `json:""dnsNames,omitempty""`
++	ParentId      string   `json:""parentId""`
++	SpiffeId      string   `json:""spiffeId""`
++	Selector      Selector `json:""selector""`
++	DnsNames      []string `json:""dnsNames,omitempty""`
++	FederatesWith []string `json:""federatesWith,omitempty""`
+ }
+
+ // SpiffeIDStatus defines the observed state of SpiffeID","I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?"
+3995,"@@ -215,13 +215,12 @@ public abstract class RSSceneMixin implements RSScene
+
+ 		for (int z = minLevel; z < maxY; ++z)
+ 		{
+-			RSTile[][] planeTiles = tiles[z];
+
+ 			for (int x = minTileX; x < maxTileX; ++x)
+ 			{
+ 				for (int y = minTileZ; y < maxTileZ; ++y)
+ 				{
+-					RSTile tile = planeTiles[x][y];
++					RSTile tile = tiles[z][x][y];
+ 					if (tile != null)
+ 					{
+ 						if (tile.getPhysicalLevel() <= plane",revert this for parity
+3996,"@@ -15,6 +15,10 @@
+ #include <valgrind/helgrind.h>
+ #endif
+
++#define INITIAL_BATCH 100
++#define INCR_BATCH 50
++#define DECR_BATCH 25
++
+ enum
+ {
+   FLAG_BLOCKED = 1 << 0,","INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where ""in the know"" folks could use to try and tune makes sense. These values were choosen mostly ""at random"" and have worked out for us thus far."
+3997,"@@ -27,6 +27,11 @@ static tagWriter *writerTable [WRITER_COUNT] = {
+
+ static tagWriter *writer;
+
++extern void setCustomTagWriter(tagWriter *w)
++{
++	writer = w;
++}
++
+ extern void setTagWriter (writerType wtype)
+ {
+ 	writer = writerTable [wtype];",Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type.
+3998,"@@ -1,6 +1,7 @@
+ module RequestSpecHelper
+   def get_json(url)
+     get(url)
++    puts response.pretty_inspect
+     JSON.parse(response.body)
+   end
+ ",I think this was left it accidentally :)
+3999,"@@ -64,12 +64,12 @@ func IsNamespaceSupported(ns NamespaceType) bool {
+
+ func NamespaceTypes() []NamespaceType {
+ 	return []NamespaceType{
++		NEWUSER, // Keep user NS always first, don't move it.
++		NEWIPC,
++		NEWUTS,
+ 		NEWNET,
+ 		NEWPID,
+ 		NEWNS,
+-		NEWUTS,
+-		NEWIPC,
+-		NEWUSER,
+ 	}
+ }
+ ",Can you finish re-ordering this list to match the one that was deleted?
+4000,"@@ -342,6 +342,10 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo) error {
+ 		chaos.Spec.Duration = &exp.Scheduler.Duration
+ 	}
+
++	if exp.Target.StressChaos.ContainerName != nil {
++		chaos.Spec.ContainerName = exp.Target.StressChaos.ContainerName
++	}
++
+ 	return s.kubeCli.Create(context.Background(), chaos)
+ }
+ ",Do we need to check if `exp.Target.StressChaos` is `nil`?
+4001,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[CreateAccessKey.java demonstrates how to create an access key for an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[CreateAccessKey.java demonstrates how to create an access key for an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+4002,"@@ -110,7 +110,6 @@ spec:
+   run:
+     tasks:
+     - cstor-volume-create-getstorageclass-default
+-    - cstor-volume-create-getpvc-default
+     - cstor-volume-create-listclonecstorvolumereplicacr-default
+     - cstor-volume-create-listcstorpoolcr-default
+     - cstor-volume-create-puttargetservice-default",not calling this is going to impact current functionality which depends on PVC.. let us still call this and set the values to default as 'none' (or empty) by handling the error from 'get' operation
+4003,"@@ -306,7 +306,9 @@ int ioctl(int fd, unsigned long request, ...)
+ 			if (gEnableIRQ && fme_irq->evtfd >= 0) {
+ 				uint64_t data = 1;
+ 				// Write to the eventfd to signal one IRQ event.
+-				write(fme_irq->evtfd, &data, sizeof(data));
++				if (write(fme_irq->evtfd, &data, sizeof(data)) != sizeof(data)) {
++					FPGA_ERR(""IRQ write < 8 bytes"");
++				}
+ 			}
+ 			retval = 0;
+ 			errno = 0;",`!=` is no the same as `<`
+4004,"@@ -0,0 +1,8 @@
++from .transformer import (FFN, MultiheadAttention, Transformer,
++                          TransformerDecoder, TransformerDecoderLayer,
++                          TransformerEncoder, TransformerEncoderLayer)
++
++__all__ = [
++    'FFN', 'MultiheadAttention', 'Transformer', 'TransformerDecoder',
++    'TransformerDecoderLayer', 'TransformerEncoder', 'TransformerEncoderLayer'
++]",No need to create a dir for transformer. Simply move transformer.py into mmdet/models/utils/
+4005,"@@ -531,6 +531,10 @@ public class MainActivity extends CastEnabledActivity {
+             bottomSheetCallback.onSlide(null, 1.0f);
+         } else if (Intent.ACTION_VIEW.equals(intent.getAction())) {
+             handleDeeplink(intent.getData());
++        } else if (Intent.ACTION_CREATE_SHORTCUT.equals(intent.getAction())) {
++            intent = new Intent(this, SelectSubscriptionActivity.class);
++            intent.setAction(Intent.ACTION_CREATE_SHORTCUT);
++            startActivity(intent);
+         }
+         // to avoid handling the intent twice when the configuration changes
+         setIntent(new Intent(MainActivity.this, MainActivity.class));",Can't you just add `SelectSubscriptionActivity` directly to the manifest instead of opening `MainActivity` that then starts it?
+4006,"@@ -46,6 +46,7 @@ var (
+ 	rpmsDir   = app.Flag(""rpm-dir"", ""Directory containing built RPMs."").Required().ExistingDir()
+ 	distTag   = app.Flag(""dist-tag"", ""The distribution tag the SPEC will be built with."").Required().String()
+ 	workerTar = app.Flag(""worker-tar"", ""Full path to worker_chroot.tar.gz.  If this argument is empty, specs will be parsed in the host environment."").ExistingFile()
++	runCheck  = app.Flag(""run-check"", ""Run the check during package build"").Bool()
+ 	logFile   = exe.LogFileFlag(app)
+ 	logLevel  = exe.LogLevelFlag(app)
+ )","Maybe say ""the spec's %check section"" so it's clearer what we mean."
+4007,"@@ -649,7 +649,7 @@ class ColumnSorting extends BasePlugin {
+    * @returns {Number} Physical row index.
+    */
+   onModifyRow(row, source) {
+-    if (this.blockPluginTranslation === false && source !== this.pluginName) {
++    if (this.blockPluginTranslation === false && source !== this.pluginName && this.isSorted()) {
+       const rowInMapper = this.rowsMapper.getValueByIndex(row);
+       row = rowInMapper === null ? row : rowInMapper;
+     }","I think after change this check `rowInMapper === null` is always false, so it's useless."
+4008,"@@ -166,7 +166,7 @@ func initClocks() {
+ 	nxp.ClockIpLpi2c2.Enable(false) //
+ 	nxp.ClockIpLpi2c3.Enable(false) //
+ 	nxp.DivIpLpi2c.Div(0)           // divide LPI2C_CLK_PODF (DIV1)
+-	nxp.MuxIpLpi2c.Mux(0)           // LPI2C select PLL3_SW_60M
++	nxp.MuxIpLpi2c.Mux(1)           // LPI2C select OSC
+
+ 	nxp.ClockIpCan1.Enable(false)  // disable CAN
+ 	nxp.ClockIpCan2.Enable(false)  //",ClockIpLpi2c4.Enable() is required. The same change is required for enablePeripheralClocks().
+4009,"@@ -67,6 +67,9 @@ type PrometheusSpec struct {
+ 	Version string `json:""version,omitempty""`
+ 	// Tag of Prometheus container image to be deployed. Defaults to the value of `version`.
+ 	Tag string `json:""tag,omitempty""`
++	// Sha of Prometheus container image to be deployed. Defaults to the value of `version`.
++	// Similar to a tag, but the sha explicitly deploys an immutable container image.
++	Sha string `json:""sha,omitempty""`
+ 	// When a Prometheus deployment is paused, no actions except for deletion
+ 	// will be performed on the underlying objects.
+ 	Paused bool `json:""paused,omitempty""`","nit: this should be `SHA` since it is an acronym for `Secure Hash Algorithm`, no?"
+4010,"@@ -27,6 +27,13 @@ import jstz from 'jstz'
+  * @returns {String} Current timezone of user
+  */
+ export default () => {
++	if (window.Intl && typeof window.Intl === 'object') {
++		const { timeZone } = Intl.DateTimeFormat().resolvedOptions()
++		if (timeZone) {
++			return timeZone
++		}
++	}
++
+ 	const determinedTimezone = jstz.determine()
+ 	if (!determinedTimezone) {
+ 		return 'UTC'",Not sure if Intl can be defined but not `Intl.DateTimeFormat`. Both seem to have the same percentage on CanIUse.
+4011,"@@ -121,7 +121,7 @@ func (p *Provisioner) Provision(opts pvController.VolumeOptions) (*v1.Persistent
+ 	if reqMap != nil {
+ 		size = pvc.Spec.Resources.Requests[""storage""]
+ 	}
+-	sendEventOrIgnore(name, size.String(), stgType, analytics.VolumeProvision)
++	sendEventOrIgnore(pvc.Name, name, size.String(), stgType, analytics.VolumeProvision)
+ 	if stgType == ""hostpath"" {
+ 		return p.ProvisionHostPath(opts, pvCASConfig)
+ 	}","PTAL, looks like the order of PVC & PV is reversed for different storage-engine types, for Jiva/CStor the args sent to sendEventOrIgnore are `PV, PVCName`."
+4012,"@@ -65,7 +65,7 @@ import vn.mbm.phimp.me.utils.RSSPhotoItem_Personal;
+ @SuppressWarnings(""deprecation"")
+ public class PhimpMe extends AppCompatActivity implements BottomNavigationView.OnNavigationItemSelectedListener //, android.view.GestureDetector.OnGestureListener
+ {
+-    public static Context ctx;
++    public static Context ctx ;
+     public static File DataDirectory;
+     public static final String PREFS_NAME = ""PhimpMePrefs"";
+     public static final String DATABASE_NAME = ""PhimpMe"";",Remove the trailing white space
+4013,"@@ -21,7 +21,7 @@ mmcv_version = digit_version(mmcv.__version__)
+
+
+ assert (mmcv_version >= digit_version(mmcv_minimum_version)
+-        and mmcv_version <= digit_version(mmcv_maximum_version)), \
++        and mmcv_version < digit_version(mmcv_maximum_version)), \
+     f'MMCV=={mmcv.__version__} is used but incompatible. ' \
+     f'Please install mmcv>={mmcv_minimum_version}, <={mmcv_maximum_version}.'
+ ",No need to modify this.
+4014,"@@ -14,7 +14,7 @@ import (
+ 	madns ""github.com/multiformats/go-multiaddr-dns""
+ )
+
+-func Discover(ctx context.Context, addr ma.Multiaddr, f func(ma.Multiaddr) (stop bool, err error)) (stopped bool, err error) {
++func Discover(ctx context.Context, addr ma.Multiaddr, f func(ma.Multiaddr) (bool, error)) (bool, error) {
+ 	if comp, _ := ma.SplitFirst(addr); comp.Protocol().Name != ""dnsaddr"" {
+ 		return f(addr)
+ 	}",would be nice at some point to clean this signature up... not relevant for this PR
+4015,"@@ -342,6 +342,12 @@ class Configurator
+                     ),
+                     $fieldConfiguration
+                 );
++
++                // if the 'type' is not set explicitly for a virtual field,
++                // consider it as a string, so the backend displays its contents
++                if (null === $normalizedConfiguration['type']) {
++                    $normalizedConfiguration['type'] = 'text';
++                }
+             } else {
+                 // this is a regular field that exists as a property of the related Doctrine entity
+                 $normalizedConfiguration = array_replace(","Here, is it `null` because it is `null` in `$fieldConfiguration`, or because it has been set to `null` above in the `array_replace` ? If it doesn't exists at all in `$fieldConfiguration`, I think you should add `type => 'text'` above in the `array_replace`."
+4016,"@@ -620,7 +620,7 @@ public class JavaParserFacade {
+      * references an outer class -- as its ancestor, return the declaration corresponding to the class name specified.
+      */
+     protected Node findContainingTypeDeclOrObjectCreationExpr(Node node, String className) {
+-        if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().equals(className)) {
++        if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().endsWith(className)) {
+             return node;
+         }
+         if (node instanceof EnumDeclaration) {","I was thinking about this for #2928 too, which also uses `endsWith`... Presumably `SomeOtherObject` would match `endsWith(""Object"")`, meaning that something more sophisticated like splitting it then iterating right to left would be needed in order to do this robustly?"
+4017,"@@ -51,5 +51,15 @@ namespace OpenTelemetry.Exporter.Zipkin
+         /// </summary>
+         public int? MaxPayloadSizeInBytes { get; set; } = DefaultMaxPayloadSizeInBytes;
+ #endif
++
++        /// <summary>
++        /// Gets or sets the exporter type for Zipkin Exporter.
++        /// </summary>
++        public ExporterType ExporterType { get; set; } = ExporterType.BatchExportProcessor;
++
++        /// <summary>
++        /// Gets or sets get or sets the BatchExportProcessor options.
++        /// </summary>
++        public BatchExportProcessorOptions BatchExportProcessorOptions { get; set; } = new BatchExportProcessorOptions();
+     }
+ }","I think this name is a bit confusing because if you asked someone what type of exporter they were using they would probably say Zipkin or Jaeger, etc. How about `ProcessorType` with `Simple` and `Batch` definitions?"
+4018,"@@ -95,6 +95,12 @@ func (a *FakeWebAPI) RegisterPiped(ctx context.Context, req *webservice.Register
+ 	}, nil
+ }
+
++func (a *FakeWebAPI) RecreatePipedKey(ctx context.Context, req *webservice.RecreatePipedKeyRequest) (*webservice.RecreatePipedKeyResponse, error) {
++	return &webservice.RecreatePipedKeyResponse{
++		Key: ""9bf9752a-54a2-451a-a541-444add56f96b"",
++	}, nil
++}
++
+ func (a *FakeWebAPI) EnablePiped(ctx context.Context, req *webservice.EnablePipedRequest) (*webservice.EnablePipedResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`req` is unused in RecreatePipedKey
+4019,"@@ -85,11 +85,11 @@ export default function SetupAccountApproved() {
+ 			__( 'Site Kit detected AdSense code for a different account %s on your site. For a better ads experience, you should remove AdSense code that’s not linked to this AdSense account.', 'google-site-kit' ),
+ 			parseAccountID( existingTag )
+ 		);
+-		uncheckedMessage = __( 'By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.', 'google-site-kit' );
++		uncheckedMessage = __( 'Please note that Adsense will not show ads on your website unless you’ve already placed the code.', 'google-site-kit' );
+ 	} else {
+ 		// No existing tag.
+ 		showProfile = false;
+-		uncheckedMessage = __( 'By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.', 'google-site-kit' );
++		uncheckedMessage = __( 'Please note that Adsense will not show ads on your website unless you’ve already placed the code.', 'google-site-kit' );
+ 	}
+
+ 	return (","The ""Adsense"" term needs to be capitalized - I just noticed this was wrong through ACs and IB, so not a problem of the PR itself really. I'll quickly fix it."
+4020,"@@ -45,11 +45,15 @@ func init() {
+ 	beam.RegisterFunction(defToDecorPiece)
+ 	beam.RegisterFunction(fileToDecorPiece)
+ 	beam.RegisterFunction(groupCrossRefs)
++	beam.RegisterFunction(groupEdges)
+ 	beam.RegisterFunction(keyByPath)
+ 	beam.RegisterFunction(keyRef)
+ 	beam.RegisterFunction(moveSourceToKey)
+ 	beam.RegisterFunction(nodeToDecorPiece)
++	beam.RegisterFunction(nodeToEdges)
++	beam.RegisterFunction(nodeToReverseEdges)
+ 	beam.RegisterFunction(refToDecorPiece)
++	beam.RegisterFunction(reverseEdge)
+ 	beam.RegisterFunction(toDefinition)
+ 	beam.RegisterFunction(toEnclosingFile)
+ 	beam.RegisterFunction(toFiles)",do which methods need to be registered? is it basically just the ones that are directly referenced in ParDo calls? (The Beam GoDoc doesn't say anything about it. :/ )
+4021,"@@ -143,7 +143,8 @@ public class Access extends AbstractApiBean {
+
+         downloadInstance.setFileCitationEndNote(datasetService.createCitationXML(datasetVersion, fileMetadata));
+         downloadInstance.setFileCitationRIS(datasetService.createCitationRIS(datasetVersion, fileMetadata));
+-
++        downloadInstance.setFileCitationBibtex(datasetService.createCitationBibtex(datasetVersion, fileMetadata));
++
+         ByteArrayOutputStream outStream = null;
+         outStream = new ByteArrayOutputStream();
+ ",@bmckinney does this mean that the bibtex citation will be available via API?
+4022,"@@ -28,11 +28,11 @@ if sys.version_info < (3,):
+     ])
+
+ POSTGRESQL_REQUIREMENTS = REQUIREMENTS + [
+-    'cliquet[postgresql]>=2.14,<3'
++    'cliquet[postgresql]>=2.15,<3'
+ ]
+
+ MONITORING_REQUIREMENTS = REQUIREMENTS + [
+-    'cliquet[monitoring]>=2.14,<3'
++    'cliquet[monitoring]>=2.15,<3'
+ ]
+
+ FXA_REQUIREMENTS = REQUIREMENTS + [",We should probably tag the cliquet-fxa version as well.
+4023,"@@ -317,7 +317,7 @@ static socklen_t parse_hostport(h2o_mem_pool_t *pool, h2o_iovec_t host, h2o_iove
+                 4 &&
+             parsed_len == host.len && d1 <= UCHAR_MAX && d2 <= UCHAR_MAX && d3 <= UCHAR_MAX && d4 <= UCHAR_MAX) {
+             if (sscanf(port.base, ""%"" SCNd32 ""%n"", &_port, &parsed_len) == 1 && parsed_len == port.len && _port <= USHRT_MAX) {
+-                struct sockaddr_in sin;
++                struct sockaddr_in sin = {};
+                 sin.sin_family = AF_INET;
+                 sin.sin_port = htons(_port);
+                 sin.sin_addr.s_addr = ntohl((d1 << 24) + (d2 << 16) + (d3 << 8) + d4);","IIRC we need to use memset, because an empty brace is not C99 comformant, and because we cannot use `{0}` because how the struct is organized is not defined in POSIX (the initializer cannot be `{0}` if the first property of the struct is a struct)."
+4024,"@@ -434,6 +434,11 @@ type NetworkPolicyPeer struct {
+ 	//  Exact FQDNs, i.e. ""google.com"", ""db-svc.default.svc.cluster.local""
+ 	//  Wildcard expressions, i.e. ""*wayfair.com"".
+ 	FQDN string `json:""fqdn,omitempty""`
++	// Select all Pods with the ServiceAccount matched by this field, as
++	// workloads in AppliedTo/To/From fields.
++	// Cannot be set with any other selector.
++	// +optional
++	ServiceAccounts []ServiceAccount `json:""serviceAccounts,omitempty""`
+ }
+
+ type PeerNamespaces struct {","Will we be adding this to `AppliedTo` as well? If not, any reason why not?"
+4025,"@@ -813,6 +813,13 @@ Tries to force this object to take the focus.
+ 		""""""
+ 		return False
+
++	def shouldAcceptShowHideCaretEvent(self):
++		""""""Some objects/applications send show/hide caret events when we don't expect it, such as when the cursor is blinking.
++		@return: if show/hide caret events should be accepted for this object.
++		@rtype: Boolean
++		""""""
++		return True
++
+ 	def reportFocus(self):
+ 		""""""Announces this object in a way suitable such that it gained focus.
+ 		""""""","Just a note that this feels weird being on the base NVDAObject rather than IAccessible, but right now, I understand that's how it has to be because we fire MSAA caret events on the focus object regardless of whether it's IAccessible. I think we should consider restricting these caret events to focus objects that are IAccessible subclasses in future, but that change is probably too risky for this PR. CC @MichaelDCurran for his thoughts."
+4026,"@@ -71,7 +71,9 @@ class PaymentController extends AdminBaseController
+     {
+         $paymentEditData = $this->paymentEditDataFactory->createDefault();
+
+-        $form = $this->createForm(PaymentEditFormType::class, $paymentEditData);
++        $form = $this->createForm(PaymentEditFormType::class, $paymentEditData, [
++            'payment_detail' => null,
++        ]);
+         $form->handleRequest($request);
+
+         if ($form->isSubmitted() && $form->isValid()) {",This change and other similar ones should not be part of this commit. This commit is about adding a ImageUploadType not fixing controllers and stuff.
+4027,"@@ -57,6 +57,7 @@ const (
+ 	leafNodeConnectEventSubj = ""$SYS.ACCOUNT.%s.LEAFNODE.CONNECT"" // for internal use only
+ 	remoteLatencyEventSubj   = ""$SYS.LATENCY.M2.%s""
+ 	inboxRespSubj            = ""$SYS._INBOX.%s.%s""
++	accConnzReqSubj          = ""$SYS.REQ.ACCOUNT.PING.CONNZ""
+
+ 	// FIXME(dlc) - Should account scope, even with wc for now, but later on
+ 	// we can then shard as needed.","I am a bit confused about PING here. Ping is implied and it overlaps with ""$SYS.REQ.ACCOUNT.%s.%s"" where the last token is what is requested (CONNZ) and the one before is the requested account id."
+4028,"@@ -708,3 +708,15 @@ func (v *volumeClient) CloudMigrateStatus() (*api.CloudMigrateStatusResponse, er
+ 	}
+ 	return statusResponse, nil
+ }
++
++// Du specified volume id and specifically path (if provided)
++func (v *volumeClient) Catalog(id, subfolder, maxDepth string) (api.CatalogResponse, error) {
++	var catalog api.CatalogResponse
++
++	req := v.c.Get().Resource(volumePath + ""/catalog"").Instance(id)
++	if err := req.QueryOption(api.OptCatalogSubFolder, subfolder).QueryOption(api.OptCatalogMaxDepth, maxDepth).Do().Unmarshal(&catalog); err != nil {
++		return catalog, err
++	}
++
++	return catalog, nil
++}","nit: use the OptSubFolder constants. Also in the client you are using ""maxdepth"" but in the server the constant for ""depth"" is being used."
+4029,"@@ -76,8 +76,8 @@ describe('Config file', () => {
+     test('parse docker.yaml', () => {
+       const config = new Config(parseConfigFile(resolveConf('docker')));
+       checkDefaultUplink(config);
+-      expect(config.storage).toBe('/verdaccio/storage');
+-      expect(config.auth.htpasswd.file).toBe('/verdaccio/conf/htpasswd');
++      expect(config.storage).toBe('/verdaccio/storage/data');
++      expect(config.auth.htpasswd.file).toBe('/verdaccio/storage/htpasswd');
+       checkDefaultConfPackages(config);
+     });
+ ","I also moved this to `/verdaccio/storage` since it's written in runtime, and the approach here is to make the configuration by default read-only."
+4030,"@@ -318,13 +318,13 @@ public class NodeJSGapicContext extends GapicContext implements NodeJSContext {
+         resourceTypeName = ""a "" + jsTypeName(resourceType);
+       }
+       return callbackMessage
+-          + ""\n@returns {Stream|gax.EventEmitter}\n""
++          + ""\n@returns {Stream|Promise}\n""
+           + ""  An object stream which emits ""
+           + resourceTypeName
+           + "" on 'data' event.\n""
+           + ""  When the callback is specified or streaming is suppressed through options,\n""
+-          + ""  it will return an event emitter to handle the call status and the callback\n""
+-          + ""  will be called with the response object."";
++          + ""  it will return a promise that resolves to the response object. The promise\n""
++          + ""  has cancel method which cancels the ongoing API call."";
+     }
+
+     MessageType returnMessageType = method.getOutputMessage();",nit: s/has cancel method/has a cancel method
+4031,"@@ -5,6 +5,16 @@ describe Quiz do
+
+   it { should have_many(:questions).dependent(:destroy) }
+
++  describe "".with_questions"" do
++    it ""returns only quizzes with questions"" do
++      first_quiz, second_quiz = create_pair(:quiz)
++
++      question = create(:question, quiz: first_quiz)
++
++      expect(Quiz.with_questions).to eq([first_quiz])
++    end
++  end
++
+   describe ""#first_question"" do
+     it ""returns the first question"" do
+       quiz = create(:quiz)",Useless assignment to variable - `second_quiz`. Use `_` or `_second_quiz` as a variable name to indicate that it won't be used.
+4032,"@@ -81,6 +81,9 @@ func (g Gzip) Validate() error {
+ // used in the Accept-Encoding request headers.
+ func (Gzip) AcceptEncoding() string { return ""gzip"" }
+
++// Suffix returns the filename suffix of precompressed files.
++func (Gzip) Suffix() string { return "".gz"" }
++
+ // NewEncoder returns a new gzip writer.
+ func (g Gzip) NewEncoder() encode.Encoder {
+ 	writer, _ := gzip.NewWriterLevel(nil, g.Level)",Is this still needed since there's the `GzipPrecompressed` type?
+4033,"@@ -29,6 +29,13 @@ from PyRegion import PyRegion
+ from nupic.algorithms.cla_classifier_factory import CLAClassifierFactory
+
+
++class _NumCatgoriesNotSpecified(Exception):
++  pass
++
++
++class _UnknownOutput(Exception):
++  pass
++
+
+ class CLAClassifierRegion(PyRegion):
+   """"""",this is spelled wrong and also not used so remove it
+4034,"@@ -65,6 +65,7 @@ public abstract class ServerWebExchangeMatchers {
+ 	 * Matches any exchange
+ 	 * @return the matcher to use
+ 	 */
++	@SuppressWarnings(""Convert2Lambda"")
+ 	public static ServerWebExchangeMatcher anyExchange() {
+ 		// we don't use a lambda to ensure a unique equals and hashcode
+ 		// which otherwise can cause problems with adding multiple entries to an ordered LinkedHashMap",It might be right here that's the issue ^
+4035,"@@ -71,8 +71,10 @@ public interface SortedMap<K, V> extends Map<K, V>, Ordered<K> {
+     /**
+      * Returns the underlying key-comparator which defines the order of the elements contained in this map.
+      *
++     * @deprecated Use {@link SortedMap#comparator()} instead
+      * @return This map's key-comparator.
+      */
++    @Deprecated
+     Comparator<K> keyComparator();
+
+     /**",@danieldietrich let's leave existing extension. Here we just mark `keyComparator()` with `@Deprecated` annotation
+4036,"@@ -21,6 +21,7 @@ OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWA
+  * HIT_END
+  */
+
++#include <io.h>
+ #include <iostream>
+ #include <vector>
+ #include <stdio.h>",This breaks CI. I am not sure why you need to include io.h in this file especially on linux.
+4037,"@@ -48,7 +48,7 @@ export function render(vnode, parentDom, replaceNode) {
+ 			? [replaceNode]
+ 			: oldVNode
+ 			? null
+-			: parentDom.firstChild
++			: parentDom.childNodes.length
+ 			? slice.call(parentDom.childNodes)
+ 			: null,
+ 		commitQueue,",this seems equivalent
+4038,"@@ -371,10 +371,10 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int, storeType strin
+
+ 		BlobSizeLimitError:     dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitError, 2*1024*1024),
+ 		BlobSizeLimitWarn:      dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitWarn, 512*1024),
+-		HistorySizeLimitError:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitError, 200*1024*1024),
+-		HistorySizeLimitWarn:   dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitWarn, 50*1024*1024),
+-		HistoryCountLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitError, 200*1024),
+-		HistoryCountLimitWarn:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitWarn, 50*1024),
++		HistorySizeLimitError:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitError, 20*1024*1024),
++		HistorySizeLimitWarn:   dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitWarn, 5*1024*1024),
++		HistoryCountLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitError, 20*1024),
++		HistoryCountLimitWarn:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitWarn, 5*1024),
+
+ 		ThrottledLogRPS:   dc.GetIntProperty(dynamicconfig.HistoryThrottledLogRPS, 4),
+ 		EnableStickyQuery: dc.GetBoolPropertyFnWithNamespaceFilter(dynamicconfig.EnableStickyQuery, true),","change size to 50MB criticial, 10MB warn... change count to 50k critical, 5k warn..."
+4039,"@@ -1033,9 +1033,9 @@ public class FacetComponent extends SearchComponent {
+       }
+
+       for (Entry<String,List<NamedList<Object>>> pivotFacetResponseFromShard : pivotFacetResponsesFromShard) {
+-        PivotFacet masterPivotFacet = fi.pivotFacets.get(pivotFacetResponseFromShard.getKey());
+-        masterPivotFacet.mergeResponseFromShard(shardNumber, rb, pivotFacetResponseFromShard.getValue());
+-        masterPivotFacet.removeAllRefinementsForShard(shardNumber);
++        PivotFacet primaryPivotFacet = fi.pivotFacets.get(pivotFacetResponseFromShard.getKey());
++        primaryPivotFacet.mergeResponseFromShard(shardNumber, rb, pivotFacetResponseFromShard.getValue());
++        primaryPivotFacet.removeAllRefinementsForShard(shardNumber);
+       }
+     }
+     ","This has nothing to do with master/slave replication. Is this something we want to change too? If so, I guess this is an aggregation?"
+4040,"@@ -91,9 +91,12 @@ module RSpec
+           end
+
+           def dispatch_specs(run_descriptor)
+-            fork { run_specs(run_descriptor) }
++            pid = fork { run_specs(run_descriptor) }
+             # We don't use Process.waitpid here as it was causing bisects to
+-            # block due to the file descriptor limit on OSX / Linux.
++            # block due to the file descriptor limit on OSX / Linux. We need
++            # to detach the process to avoid having zombie process and consume
++            # slot in the kernel process table.
++            Process.detach(pid)
+           end
+
+         private","Maybe it makes sense to mention that those zombies are not forever, but only up to the moment when the parent process exits? Is that correct according to your observations, @benoittgt ? Please disregard this note if zombies remain after."
+4041,"@@ -543,7 +543,18 @@ def apply_patches():
+ def start_apigateway(port=None, backend_port=None, asynchronous=None, update_listener=None):
+     port = port or config.PORT_APIGATEWAY
+     apply_patches()
+-    result = start_moto_server(
++
++    # Why here?
++    # 1. The moto mocking has to happen before any usage of botocore, the import will register
++    #    a 'before-send-handler' event, thus intercepting the call to aws.
++    # 2. Then we start the specific service mocking, which basically starts the service backend.
++    #
++    from moto import mock_apigateway
++
++    mock = mock_apigateway()
++    mock.start()
++
++    return start_moto_server(
+         key=""apigateway"",
+         name=""API Gateway"",
+         asynchronous=asynchronous,",moto mock setup needs to happen before boto usage.
+4042,"@@ -199,6 +199,8 @@ def train(params, train_set, num_boost_round=100,
+         callbacks = set()
+     else:
+         for i, cb in enumerate(callbacks):
++            if hasattr(cb, 'first_metric_only') and cb.first_metric_only and feval is not None:
++                raise LightGBMError(""`first_metric_only` and `feval` are not available at the same time."")
+             cb.__dict__.setdefault('order', i - len(callbacks))
+         callbacks = set(callbacks)
+ ","`hasattr(cb, 'first_metric_only') and cb.first_metric_only` -> `getattr(cb, 'first_metric_only', False)`"
+4043,"@@ -107,3 +107,17 @@ func getProtoRequest(ctx context.Context, transportRequest *transport.Request, n
+ 	}
+ 	return ctx, call, request, nil
+ }
++
++type streamHandler struct {
++	handle     func(ServerStream) error
++}
++
++func newStreamHandler(
++	handle func(ServerStream) error,
++) *streamHandler {
++	return &streamHandler{handle}
++}
++
++func (s *streamHandler) HandleStream(stream transport.ServerStream) error {
++	return s.handle(stream)
++}",no newline for function
+4044,"@@ -240,7 +240,7 @@ static void config_head_handle_set_scale(struct wl_client *client,
+ 		return;
+ 	}
+
+-	double scale =  wl_fixed_to_double(scale_fixed);
++	float scale =  wl_fixed_to_double(scale_fixed);
+ 	if (scale <= 0) {
+ 		wl_resource_post_error(config_head_resource,
+ 			ZWLR_OUTPUT_CONFIGURATION_HEAD_V1_ERROR_INVALID_SCALE,","This makes me feel icky. We could also go the route of making `wlr_output.scale` a double instead of a float, but that would be a more widely reaching change."
+4045,"@@ -219,7 +219,7 @@ PQRYRES XMLColumns(PGLOBAL g, char *db, char *tab, PTOS topt, bool info)
+     while (true) {
+       if (!vp->atp &&
+ 				!(node = (vp->nl) ? vp->nl->GetItem(g, vp->k++, tdp->Usedom ? node : NULL)
+-				                  : NULL))
++				                  : NULL)) {
+         if (j) {
+           vp = lvlp[--j];
+ ","Again, would be awesome if you could remove the tabs in these 3-4 lines as well."
+4046,"@@ -234,9 +234,14 @@ util::json::Object makeRouteStep(guidance::RouteStep step, util::json::Value geo
+     util::json::Object route_step;
+     route_step.values[""distance""] = std::round(step.distance * 10) / 10.;
+     route_step.values[""duration""] = std::round(step.duration * 10) / 10.;
+-    route_step.values[""name""] = std::move(step.name);
+-    if (!step.ref.empty())
++    route_step.values[""way_name""] = std::move(step.name);
++    if (step.ref.empty())
++        route.step.values[""name""] = std::move(step.name);
++    else
++    {
++        route_step.values[""name""] = std::move(step.name) << "" ("" << std::move(step.ref) << "")"";
+         route_step.values[""ref""] = std::move(step.ref);
++    }
+     if (!step.pronunciation.empty())
+         route_step.values[""pronunciation""] = std::move(step.pronunciation);
+     if (!step.destinations.empty())",You're moving multiple times from `step.name`; you're not allowed to do that. Instead you have to copy the `step.name` string and (if you want to) move once at the very last.
+4047,"@@ -124,15 +124,15 @@ app.controller('EditorController', ['$scope', 'TimezoneService', 'AutoCompletion
+ 		$scope.validate = function() {
+ 			var error = false;
+ 			if ($scope.properties.summary === null || $scope.properties.summary.value.trim() === '') {
+-				OC.Notification.showTemporary(t('calendar', 'Please add a title!'));
++				OC.Notification.showTemporary(t('calendar', 'Please add a title.'));
+ 				error = true;
+ 			}
+ 			if ($scope.calendar === null || typeof $scope.calendar === 'undefined') {
+-				OC.Notification.showTemporary(t('calendar', 'Please select a calendar!'));
++				OC.Notification.showTemporary(t('calendar', 'Please select a calendar.'));
+ 				error = true;
+ 			}
+ 			if (!$scope.properties.checkDtStartBeforeDtEnd()) {
+-				OC.Notification.showTemporary(t('calendar', 'The event ends before it starts!'));
++				OC.Notification.showTemporary(t('calendar', 'The event can not end before it starts.'));
+ 				error = true;
+ 			}
+ ",What about `may not end`? @jancborchardt
+4048,"@@ -1236,7 +1236,7 @@ func (a *WebAPI) validateApprover(stages []*model.PipelineStage, commander, stag
+ 			return nil
+ 		}
+ 	}
+-	return status.Error(codes.FailedPrecondition, fmt.Sprintf(""Could not approve the stage because %q isn't set as an approver."", commander))
++	return status.Error(codes.FailedPrecondition, fmt.Sprintf(""You can't approve this deployment because you (%s) are not in the approver list: %v"", commander, approvers))
+ }
+
+ func (a *WebAPI) GetApplicationLiveState(ctx context.Context, req *webservice.GetApplicationLiveStateRequest) (*webservice.GetApplicationLiveStateResponse, error) {","If you think about it, the status should be PermissionDenied?"
+4049,"@@ -260,8 +260,7 @@ class MappingJobQueue(threading.Thread):
+                         low_quality_rate=stats[""low_quality""] - stats[""last_low_quality""],
+                         no_match_rate=stats[""no_match""] - stats[""last_no_match""],
+                         listens_per_sec=listens_per_sec,
+-                        listen_count=stats[""listen_count""],
+-                        listens_matched=stats[""listens_matched""],
++                        listens_matched_p=stats[""listens_matched""] / stats[""listen_count""] * 100.0,
+                         legacy_index_date=datetime.date.fromtimestamp(self.legacy_listens_index_date).strftime(""%Y-%m-%d""))
+
+             stats[""last_exact_match""] = stats[""exact_match""]",Calculation looks good but don't know what format etc grafana expects this to be in.
+4050,"@@ -722,6 +722,18 @@ class TestDockerClient:
+         assert env_variable in stdout
+         assert ""EXISTING_VAR=test_var"" in stdout
+
++    def test_run_with_additional_arguments_add_host(self, docker_client: ContainerClient):
++        additional_flags = ""--add-host sometest.localstack.cloud:127.0.0.1""
++        stdout, _ = docker_client.run_container(
++            ""alpine"",
++            remove=True,
++            command=[""getent"", ""hosts"", ""sometest.localstack.cloud""],
++            additional_flags=additional_flags,
++        )
++        stdout = stdout.decode(config.DEFAULT_ENCODING)
++        assert ""127.0.0.1"" in stdout
++        assert ""sometest.localstack.cloud"" in stdout
++
+     def test_get_container_ip_non_existing_container(self, docker_client: ContainerClient):
+         with pytest.raises(NoSuchContainer):
+             docker_client.get_container_ip(""hopefully_non_existent_container_%s"" % short_uid())",nit: We could use the `to_str(..)` util here. (let's not bother changing for this PR..   )
+4051,"@@ -29,6 +29,7 @@ import (
+ 	""time""
+
+ 	""github.com/gogo/protobuf/types""
++	executiongenproto ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	tasklistpb ""go.temporal.io/temporal-proto/tasklist""
+ )
+ ","Can you rename alias to `executiongenpb`. The rule is package+""pb"" for `temporal-proto` and package+""genpb"" for server protos."
+4052,"@@ -261,7 +261,9 @@ func addNodeToResults(n *node, results *SublistResult) {
+ 		if i := findQSliceForSub(qr[0], results.qsubs); i >= 0 {
+ 			results.qsubs[i] = append(results.qsubs[i], qr...)
+ 		} else {
+-			results.qsubs = append(results.qsubs, qr)
++			copyqr := make([]*subscription, len(qr))
++			copy(copyqr, qr)
++			results.qsubs = append(results.qsubs, copyqr)
+ 		}
+ 	}
+ }",Any noticeable performance hit? Any other way to avoid the allocation and copy even of the array?
+4053,"@@ -234,8 +234,8 @@ func (i2c I2C) readByte() byte {
+ func (i2c I2C) readLastByte() byte {
+ 	for i2c.Bus.EVENTS_RXDREADY == 0 {
+ 	}
+-	i2c.Bus.EVENTS_RXDREADY = 0
+ 	i2c.signalStop() // signal 'stop' now, so it is sent when reading RXD
++	i2c.Bus.EVENTS_RXDREADY = 0
+ 	return byte(i2c.Bus.RXD)
+ }
+ ",What if you remove this line entirely from here?
+4054,"@@ -124,11 +124,13 @@ class PAFPN(FPN):
+                     outs.append(F.max_pool2d(outs[-1], 1, stride=2))
+             # add conv layers on top of original feature maps (RetinaNet)
+             else:
+-                if self.extra_convs_on_inputs:
++                if self.add_extra_convs == 'on_input':
+                     orig = inputs[self.backbone_end_level - 1]
+                     outs.append(self.fpn_convs[used_backbone_levels](orig))
+-                else:
++                elif self.add_extra_convs == 'on_output':
+                     outs.append(self.fpn_convs[used_backbone_levels](outs[-1]))
++                else:
++                    raise NotImplementedError
+                 for i in range(used_backbone_levels + 1, self.num_outs):
+                     if self.relu_before_extra_convs:
+                         outs.append(self.fpn_convs[i](F.relu(outs[-1])))",`on_lateral` can also be implemented
+4055,"@@ -67,11 +67,14 @@ public class ItunesAdapter extends ArrayAdapter<PodcastSearchResult> {
+
+         //Set the title
+         viewHolder.titleView.setText(podcast.title);
+-        if(podcast.feedUrl != null && !podcast.feedUrl.contains(""itunes.apple.com"")) {
+-            viewHolder.urlView.setText(podcast.feedUrl);
+-            viewHolder.urlView.setVisibility(View.VISIBLE);
++        if(podcast.author != null && ! podcast.author.trim().isEmpty()) {
++            viewHolder.authorView.setText(podcast.author);
++            viewHolder.authorView.setVisibility(View.VISIBLE);
++        } else if(podcast.feedUrl != null && !podcast.feedUrl.contains(""itunes.apple.com"")) {
++            viewHolder.authorView.setText(podcast.feedUrl);
++            viewHolder.authorView.setVisibility(View.VISIBLE);
+         } else {
+-            viewHolder.urlView.setVisibility(View.GONE);
++            viewHolder.authorView.setVisibility(View.GONE);
+         }
+
+         //Update the empty imageView with the image from the feed",Please add a space between `if` and `(`.
+4056,"@@ -30,6 +30,12 @@ import (
+ const (
+ 	PoolOperator           = ""zpool""
+ 	StatusNoPoolsAvailable = ""no pools available""
++	ZpoolStatusDegraded    = ""DEGRADED""
++	ZpoolStatusFaulted     = ""FAULTED""
++	ZpoolStatusOffline     = ""OFFLINE""
++	ZpoolStatusOnline      = ""ONLINE""
++	ZpoolStatusRemoved     = ""REMOVED""
++	ZpoolStatusUnavail     = ""UNAVAIL""
+ )
+
+ //PoolAddEventHandled is a flag representing if the pool has been initially imported or created","This statuses might have been better off with some custom status type. However, good for now."
+4057,"@@ -165,9 +165,11 @@ func GetIPNetDeviceByName(ifaceName string) (v4IPNet *net.IPNet, v6IPNet *net.IP
+ 		if ipNet, ok := addr.(*net.IPNet); ok {
+ 			if ipNet.IP.IsGlobalUnicast() {
+ 				if ipNet.IP.To4() != nil {
++					if v4IPNet == nil {
++						v4IPNet = ipNet
++					}
++				} else if v6IPNet == nil {
+ 					v6IPNet = ipNet
+-				} else {
+-					v4IPNet = ipNet
+ 				}
+ 			}
+ 		}",Thanks for catching the bug. Here your change lets `v4IPNet` and `v6IPNet` take the first IPv4/IPv6 address in `addrList`. Maybe choose the last one also works and makes code simpler? What's your idea? @tnqn
+4058,"@@ -680,8 +680,12 @@ class UserResource(object):
+         try:
+             return self.model.get_record(record_id)
+         except storage_exceptions.RecordNotFoundError:
+-            response = http_error(HTTPNotFound(),
+-                                  errno=ERRORS.INVALID_RESOURCE_ID)
++            detail_dict = {
++                ""id"": record_id,
++                ""resource_name"": ""record""
++            }
++            response = http_error(HTTPNotFound(), errno=ERRORS.INVALID_RESOURCE_ID,
++                                  details=detail_dict)
+             raise response
+
+     def _add_timestamp_header(self, response, timestamp=None):",nitpick: you can name this variable just `details`
+4059,"@@ -0,0 +1,18 @@
++#include ""general.h""
++#include ""parse.h""
++
++static void installJadeParser (const langType language)
++{
++  addTagRegex(language, ""^mixin[ \t]*([a-sA-Z0-9_]+)"", ""\\1"", ""d,definition"", NULL);
++}
++
++
++extern parserDefinition* JadeParser (void)
++{
++  static const char* extensions[] = { ""jade"", NULL };
++  parserDefinition* def = parserNew(""Jade"");
++  def->extensions       = extensions;
++  def->initialize       = installJadeParser;
++  def->method           = METHOD_REGEX;
++  return def;
++}","The character class in the regex should probably be ""[a-zA-Z0-9_]""."
+4060,"@@ -290,12 +290,6 @@ public class GlobalSettings {
+         s.put(""pgpSignOnlyDialogCounter"", Settings.versions(
+                 new V(45, new IntegerRangeSetting(0, Integer.MAX_VALUE, 0))
+         ));
+-        s.put(""openPgpProvider"", Settings.versions(
+-                new V(46, new StringSetting(K9.NO_OPENPGP_PROVIDER))
+-        ));
+-        s.put(""openPgpSupportSignOnly"", Settings.versions(
+-                new V(47, new BooleanSetting(false))
+-        ));
+         s.put(""fontSizeMessageViewBCC"", Settings.versions(
+                 new V(48, new FontSizeSetting(FontSizes.FONT_DEFAULT))
+         ));",Please also increment `Settings.VERSION` and update `AccountSettings`.
+4061,"@@ -18,6 +18,12 @@ import (
+ 	""time""
+ )
+
++var builddate string // set by the Makefile
++
++func versionString() string {
++	return ""Weave of "" + builddate
++}
++
+ func ensureInterface(ifaceName string, wait bool) (iface *net.Interface, err error) {
+ 	iface, err = findInterface(ifaceName)
+ 	if err == nil || !wait {","I think this should just say ""build <date>"". And when builddate wasn't set, e.g. somebody built weave with 'go build' or some other way, this should return ""unknown""."
+4062,"@@ -142,7 +142,8 @@ public class BaseRewriteManifestsSparkAction
+
+   @Override
+   public RewriteManifests.Result execute() {
+-    JobGroupInfo info = newJobGroupInfo(""REWRITE-MANIFESTS"", ""REWRITE-MANIFESTS"");
++    JobGroupInfo info = newJobGroupInfo(""REWRITE-MANIFESTS"",
++        String.format(""Rewriting manifests(staging location=%s) of %s"", stagingLocation, table.name()));
+     return withJobGroupInfo(info, this::doExecute);
+   }
+ ",Can we move this into a separate var and call it `desc` like below?
+4063,"@@ -19,6 +19,14 @@ package io.servicecomb.demo.pojo.server;
+ import java.util.Arrays;
+ import java.util.List;
+
++import javax.ws.rs.core.MediaType;
++
++import org.springframework.web.bind.annotation.RequestBody;
++import org.springframework.web.bind.annotation.RequestMapping;
++import org.springframework.web.bind.annotation.RequestMethod;
++import org.springframework.web.bind.annotation.RequestParam;
++import org.springframework.web.bind.annotation.ResponseBody;
++
+ import io.servicecomb.demo.server.Test;
+ import io.servicecomb.demo.server.TestRequest;
+ import io.servicecomb.demo.server.User;",why RpcSchema need this annotations?
+4064,"@@ -1673,7 +1673,9 @@ func (s *Server) debugSubscribers(sub *subscription, c *client, subject, reply s
+ 		}
+ 		// Cleanup the WC entry.
+ 		s.mu.Lock()
+-		delete(s.sys.replies, replySubj)
++		if s.sys != nil && s.sys.replies != nil {
++			delete(s.sys.replies, replySubj)
++		}
+ 		s.mu.Unlock()
+ 		// Send the response.
+ 		s.sendInternalAccountMsg(nil, reply, atomic.LoadInt32(&nsubs))","Not sure it makes sense to send the reply if we did not delete from the map, but I guess it does not hurt.."
+4065,"@@ -187,10 +187,11 @@ DataMap.prototype.getSchema = function() {
+  * @returns {Number} Returns number of created rows.
+  */
+ DataMap.prototype.createRow = function(index, amount, source) {
+-  var row,
+-    colCount = this.instance.countCols(),
+-    numberOfCreatedRows = 0,
+-    currentIndex;
++  let row = null;
++  let colCount = this.instance.countCols();
++  let numberOfCreatedRows = 0;
++  let currentIndex = null;
++  let continueProcess = null;
+
+   if (!amount) {
+     amount = 1;",Most of these variables can be moved after `return` or to the body of `if` statement.
+4066,"@@ -115,6 +115,10 @@ public enum JsonRpcError {
+   DECODE_ERROR(-50100, ""Unable to decode the private signed raw transaction""),
+   GET_PRIVATE_TRANSACTION_NONCE_ERROR(-50100, ""Unable to determine nonce for account in group.""),
+
++  // Privacy multi-tenancy errors
++  PRIVACY_MULTI_TENANCY_NO_TOKEN(-50100, ""No token provided""),
++  PRIVACY_MULTI_TENANCY_NO_ENCLAVE_PUBLIC_KEY(-50100, ""No privacy enclave public key""),
++
+   CANT_CONNECT_TO_LOCAL_PEER(-32100, ""Cannot add local node as peer.""),
+
+   // Invalid input errors","nit: Is this actually just a http ""unauthorised"" response? Or is that too vague? If this is the right way to go ... is ""token"" the right word"" Or do we want to say something else?"
+4067,"@@ -247,7 +247,7 @@ module Bolt
+
+     def puppetdb_client
+       return @puppetdb_client if @puppetdb_client
+-      puppetdb_config = Bolt::PuppetDB::Config.load_config(nil, config.puppetdb)
++      puppetdb_config = Bolt::PuppetDB::Config.load_config(nil, config.puppetdb, config.boltdir.path)
+       @puppetdb_client = Bolt::PuppetDB::Client.new(puppetdb_config)
+     end
+ ","We check for `$future` in PuppetDB::Config, so this won't change behavior if you don't have `future` set."
+4068,"@@ -1279,6 +1279,8 @@ class _Frame(object):
+             col_by = [_resolve_col(df, col_or_s) for col_or_s in by]
+             return DataFrameGroupBy(df_or_s, col_by, as_index=as_index)
+         if isinstance(df_or_s, Series):
++            if not isinstance(by[0], Series):
++                raise KeyError(by[0])
+             col = df_or_s  # type: Series
+             anchor = df_or_s._kdf
+             col_by = [_resolve_col(anchor, col_or_s) for col_or_s in by]","I think you should remove `if isinstance(by, str):`,. We also should fix the error message `raise ValueError('Not a valid index: TODO')` to match with pandas'"
+4069,"@@ -48,6 +48,7 @@ namespace OpenTelemetry.Instrumentation.Grpc.Implementation
+
+             activity.SetKind(ActivityKind.Client);
+             activity.DisplayName = grpcMethod?.Trim('/');
++            activity.SetCustomProperty(""GrpcHandler.Request"", request);
+
+             this.activitySource.Start(activity);
+ ","Curious - do we want this to be `OTel.GrpcHandler.Request`? For example, if someone is debugging a crash dump, they would get some hint that it was added by OpenTelemetry."
+4070,"@@ -52,6 +52,12 @@ public interface TableOperations {
+    * Implementations must check that the base metadata is current to avoid overwriting updates.
+    * Once the atomic commit operation succeeds, implementations must not perform any operations that
+    * may fail because failure in this method cannot be distinguished from commit failure.
++   * <p></p>
++   * Implementations must throw a CommitStateUnknownException in cases where it cannot be determined if the
++   * commit succeeded or failed. For example if a network partition causes the confirmation of the commit to be lost,
++   * the implementation should throw a CommitStateUnknownException. This is important because downstream users of
++   * this API need to know whether they can clean up the commit or not, if the state is unknown then it is not safe
++   * to remove any files. All other exceptions will be treated as if the commit has failed.
+    *
+    * @param base     table metadata on which changes were based
+    * @param metadata new table metadata with updates",nit: unnecessary `</p>`
+4071,"@@ -194,7 +194,16 @@ std::shared_ptr<Engine> ADIOS::Open(const std::string &name,
+                                     ""HDF5 library, can't use HDF5\n"");
+ #endif
+     }
+-
++    else if (type == ""HDF5Reader"") // -Junmin
++    {
++#if defined(ADIOS_HAVE_PHDF5) && defined(ADIOS_HAVE_MPI)
++        return std::make_shared<HDF5Reader>(*this, name, accessMode, mpiComm,
++                                            method);
++#else
++        throw std::invalid_argument(""ERROR: this version didn't compile with ""
++                                    ""HDF5 library, can't use HDF5\n"");
++#endif
++    }
+     else
+     {
+         if (m_DebugMode == true)",Should just be `#ifdef ADIOS2_HAVE_HDF5`
+4072,"@@ -1691,7 +1691,11 @@ def add_default_resource_props(
+         props[""LogGroupName""] = resource_name
+
+     elif res_type == ""AWS::Lambda::Function"" and not props.get(""FunctionName""):
+-        props[""FunctionName""] = ""{}-lambda-{}"".format(stack_name[:45], short_uid())
++        # FunctionName is up to 64 characters long
++        random_id_part = short_uid()
++        resource_id_part = resource_id[:24]
++        stack_name_part = stack_name[: 63 - 2 - (len(random_id_part) + len(resource_id_part))]
++        props[""FunctionName""] = f""{stack_name_part}-{resource_id_part}-{random_id_part}""
+
+     elif res_type == ""AWS::SNS::Topic"" and not props.get(""TopicName""):
+         props[""TopicName""] = ""topic-%s"" % short_uid()","FYI: I deployed a stack with multiple lengths for the stack name and resource id to cloudformation, to see how it truncates the parts for the final FunctionName"
+4073,"@@ -301,7 +301,6 @@ func (w *WorkloadInitializer) newLoadBalancedWebServiceManifest(i *ServiceProps)
+ 		},
+ 		Port:        i.Port,
+ 		HealthCheck: i.HealthCheck,
+-		AppDomain:   i.appDomain,
+ 		Path:        ""/"",
+ 	}
+ 	existingSvcs, err := w.Store.ListServices(i.App)",Did we not use this field @_@
+4074,"@@ -83,6 +83,10 @@ const Config = function () {
+   this.extraGnArgs = {}
+   this.extraNinjaOpts = []
+   this.braveSafetyNetApiKey = getNPMConfig(['brave_safetynet_api_key']) || ''
++  this.androidKeystorePath = getNPMConfig(['android_keystore_path']) || ''
++  this.androidKeyAlias = getNPMConfig(['android_key_alias']) || ''
++  this.androidKeystorePassword = getNPMConfig(['android_keystore_password']) || ''
++  this.androidKeyPassword = getNPMConfig(['android_key_password']) || ''
+ }
+
+ Config.prototype.buildArgs = function () {",shouldn't this be `android_keystore_name`?
+4075,"@@ -39,7 +39,12 @@ func (c *controller) issuersForSecret(secret *corev1.Secret) ([]*v1alpha2.Cluste
+ 		}
+ 		if (iss.Spec.ACME != nil && iss.Spec.ACME.PrivateKey.Name == secret.Name) ||
+ 			(iss.Spec.CA != nil && iss.Spec.CA.SecretName == secret.Name) ||
+-			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.TokenSecretRef.Name == secret.Name) {
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.TokenSecretRef != nil &&
++				iss.Spec.Vault.Auth.TokenSecretRef.Name == secret.Name) ||
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.Kubernetes != nil &&
++				iss.Spec.Vault.Auth.Kubernetes.SecretRef.Name == secret.Name) ||
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.AppRole != nil &&
++				iss.Spec.Vault.Auth.AppRole.SecretRef.Name == secret.Name) {
+ 			affected = append(affected, iss)
+ 			continue
+ 		}",Double check the issuers package too :)
+4076,"@@ -170,7 +170,7 @@ TYPING_NAMES = frozenset(
+
+
+ class VariableVisitConsumerAction(Enum):
+-    """"""Used after _visit_consumer to determine the action to be taken
++    """"""Used after _check_consumer to determine the action to be taken
+
+     Continue -> continue loop to next consumer
+     Return -> return and thereby break the loop",This is out of date right? Now that `_is_first_level_self_reference` uses it as well? Perhaps we should make the docstring more general and not refer to method names that could change.
+4077,"@@ -305,6 +305,7 @@ func createK8sAppMonitoring(
+ }
+
+ func testPromRemoteWriteWithTLS(t *testing.T) {
++	t.Parallel()
+ 	// can't extend the names since ns cannot be created with more than 63 characters
+ 	tests := []testFramework.PromRemoteWriteTestConfig{
+ 		// working configurations","This test alone takes around 10-12 minutes to run. It has 20 subtests each of which takes around one minute. We should see if we there are redundant subtests that we can remove, or look for a way to optimize them."
+4078,"@@ -10,11 +10,14 @@ import options from '../options';
+  * @param {boolean} isSvg Whether or not this node is an SVG node
+  */
+ export function diffProps(dom, newProps, oldProps, isSvg) {
+-	for (let i in newProps) {
+-		if (i!=='children' && i!=='key' && (!oldProps || ((i==='value' || i==='checked') ? dom : oldProps)[i]!==newProps[i])) {
+-			setProperty(dom, i, newProps[i], oldProps[i], isSvg);
++	let keys = Object.keys(newProps).sort();
++	for (let i = 0; i < keys.length; i++) {
++		let k = keys[i];
++		if (k!=='children' && k!=='key' && (!oldProps || ((k==='value' || k==='checked') ? dom : oldProps)[k]!==newProps[k])) {
++			setProperty(dom, k, newProps[k], oldProps[k], isSvg);
+ 		}
+ 	}
++
+ 	for (let i in oldProps) {
+ 		if (i!=='children' && i!=='key' && (!newProps || !(i in newProps))) {
+ 			setProperty(dom, i, null, oldProps[i], isSvg);","Good call, we need to keep that check :+1:"
+4079,"@@ -11,5 +11,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+         bool ParseRequestLine(TRequestHandler handler, in ReadOnlySequence<byte> buffer, out SequencePosition consumed, out SequencePosition examined);
+
+         bool ParseHeaders(TRequestHandler handler, in ReadOnlySequence<byte> buffer, out SequencePosition consumed, out SequencePosition examined, out int consumedBytes);
++
++        bool ParseRequestLine(TRequestHandler handler, ref BufferReader<byte> reader);
++
++        bool ParseHeaders(TRequestHandler handler, ref BufferReader<byte> reader);
+     }
+ }",Should the interface have 2 `ParseHeaders` methods?
+4080,"@@ -87,9 +87,11 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+   private static final String HIVE_LOCK_CHECK_MIN_WAIT_MS = ""iceberg.hive.lock-check-min-wait-ms"";
+   private static final String HIVE_LOCK_CHECK_MAX_WAIT_MS = ""iceberg.hive.lock-check-max-wait-ms"";
+   private static final String HIVE_TABLE_LEVEL_LOCK_EVICT_MS = ""iceberg.hive.table-level-lock-evict-ms"";
++  private static final String HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES = ""hive.iceberg.metadata.refresh.max.retries"";
+   private static final long HIVE_ACQUIRE_LOCK_TIMEOUT_MS_DEFAULT = 3 * 60 * 1000; // 3 minutes
+   private static final long HIVE_LOCK_CHECK_MIN_WAIT_MS_DEFAULT = 50; // 50 milliseconds
+   private static final long HIVE_LOCK_CHECK_MAX_WAIT_MS_DEFAULT = 5 * 1000; // 5 seconds
++  private static final int HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES_DEFAULT = 2;
+   private static final long HIVE_TABLE_LEVEL_LOCK_EVICT_MS_DEFAULT = TimeUnit.MINUTES.toMillis(10);
+   private static final DynMethods.UnboundMethod ALTER_TABLE = DynMethods.builder(""alter_table"")
+       .impl(IMetaStoreClient.class, ""alter_table_with_environmentContext"",",Nit: Does this make more sense as `iceberg.hive.metadata...`? The rest of the configs seem to start with `iceberg.hive`.
+4081,"@@ -184,6 +184,17 @@ func ValidateACMEIssuerDNS01Config(iss *v1alpha1.ACMEIssuerDNS01Config, fldPath
+ 				}
+ 			}
+ 		}
++		if p.DNSMadeEasy != nil {
++			if numProviders > 0 {
++				el = append(el, field.Forbidden(fldPath.Child(""dnsmadeeasy""), ""may not specify more than one provider type""))
++			} else {
++				numProviders++
++				el = append(el, ValidateSecretKeySelector(&p.DNSMadeEasy.SecretKey, fldPath.Child(""dnsmadeeasy"", ""secretKeySecretRef""))...)
++				if len(p.DNSMadeEasy.APIKey) == 0 {
++					el = append(el, field.Required(fldPath.Child(""dnsmadeeasy"", ""apiKey""), """"))
++				}
++			}
++		}
+ 		if p.Route53 != nil {
+ 			if numProviders > 0 {
+ 				el = append(el, field.Forbidden(fldPath.Child(""route53""), ""may not specify more than one provider type""))",Is `baseURL` not required?
+4082,"@@ -101,6 +101,7 @@ class EmbeddingRPNHead(nn.Module):
+         """"""Forward function in testing stage.""""""
+         return self._decode_init_proposals(img, img_metas)
+
++    # TODO: is right ?
+     def show_result(self, data):
+         """"""Show the init proposals in EmbeddingRPN.
+ ","Just delete it, `embedding_rpn_head` is not a `Detector` which should have `show_result`."
+4083,"@@ -7,6 +7,12 @@ namespace Datadog.Trace.ClrProfiler.ExtensionMethods
+         internal static string GetHttpMethod(this ISpan span)
+             => span.GetTag(Tags.HttpMethod);
+
++        internal static string GetHost(this ISpan span)
++            => span.GetTag(Tags.HttpRequestHeadersHost);
++
++        internal static string GetAbsoluteUrl(this ISpan span)
++            => span.GetTag(Tags.HttpUrl);
++
+         internal static void DecorateWebServerSpan(
+             this Span span,
+             string resourceName,","Where do we _get_ tag values? edit: I mean, where are these `GetFoo()` methods called from? It just seems weird to me that we are getting tag values from spans. I thought we only ever _set_ tags on spans."
+4084,"@@ -197,6 +197,7 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
+ 	if err != nil {
+ 		return nil, err
+ 	}
++	log.Printf(""Reading kzip with %v encoding"", pref)
+ 	return &Reader{
+ 		zip:         archive,
+ 		root:        root,",This seems like log spam. Maybe expose the encoding as a method and log at the point of interest?
+4085,"@@ -464,7 +464,7 @@ PCO_PROTOCOL_TYPES = {
+     0x000c: 'P-CSCF IPv4 Address Request',
+     0x0010: 'IPv4 Link MTU Request',
+     0x8021: 'IPCP',
+-    0xc023: 'Password Authentification Protocol',
++    0xc023: 'Password Authentication Protocol',
+     0xc223: 'Challenge Handshake Authentication Protocol',
+ }
+ ","I looked up that one, and it seems correct: Authentification is French, Authentication seems to be correct"
+4086,"@@ -22,9 +22,13 @@
+ """"""
+ Plot class used in monitor mixin framework.
+ """"""
+-import matplotlib.pyplot as plt
+-import matplotlib.cm as colorModel
++import traceback
+
++try:
++  # We import in here to avoid creating a matplotlib dependency in nupic.
++  import matplotlib.pyplot as plt
++except ImportError:
++  print traceback.format_exc() + ""\n""
+
+
+ class Plot(object):","Can we print a more human-friendly warning here, saying that plotting won't work or something along those lines?"
+4087,"@@ -1,13 +1,15 @@
+ import html
+ import time
+ from typing import Optional, Tuple
+-from mitmproxy import connections
++
+ from mitmproxy import flow
+ from mitmproxy import version
+ from mitmproxy.net import http
++from mitmproxy.proxy import context
+
+ HTTPRequest = http.Request
+ HTTPResponse = http.Response
++HTTPMessage = http.Message
+
+
+ class HTTPFlow(flow.Flow):",@mhils didn't we try to get rid of these (now empty) wrapper classes?
+4088,"@@ -19,6 +19,7 @@ import (
+
+ 	log ""github.com/sirupsen/logrus""
+
++	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/libcalico-go/lib/set""
+ )
+ ",I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build.
+4089,"@@ -137,4 +137,13 @@ public interface Catalog {
+    * @throws NoSuchTableException if the table does not exist
+    */
+   Table loadTable(TableIdentifier identifier);
++
++  /**
++   * Register a table.
++   *
++   * @param identifier a table identifier
++   * @param metadataFileLocation the location of a metadata file
++   * @return a Table instance
++   */
++  Table registerTable(TableIdentifier identifier, String metadataFileLocation);
+ }","Maybe, `import` would be a better name."
+4090,"@@ -21,10 +21,11 @@ import java.util.List;
+ public class ProtoPagingParameters implements PagingParameters {
+   private static final String PARAMETER_PAGE_TOKEN = ""page_token"";
+   private static final String PARAMETER_NEXT_PAGE_TOKEN = ""next_page_token"";
+-  private static final String PARAMETER_MAX_RESULTS = ""page_size"";
++  private static final String PARAMETER_PAGE_SIZE = ""page_size"";
++  private static final String PARAMETER_MAX_RESULTS = ""max_results"";
+
+   private static final ImmutableList<String> IGNORED_PARAMETERS =
+-      ImmutableList.of(PARAMETER_PAGE_TOKEN, PARAMETER_MAX_RESULTS);
++      ImmutableList.of(PARAMETER_PAGE_TOKEN, PARAMETER_PAGE_SIZE);
+
+   @Override
+   public String getNameForPageToken() {",Wouldn't we want `PARAMETER_MAX_RESULTS` in here as well? (I might be miunderstanding how this is used)
+4091,"@@ -21,4 +21,8 @@ RSpec.configure do |config|
+
+   Capybara.default_host = ""http://localhost:3000""
+   OmniAuth.config.test_mode = true
++
++  config.before(:suite) do
++    Role.ensure_system_roles_exist
++  end
+ end",We can re-use the config in our tests.
+4092,"@@ -308,7 +308,7 @@ AC_MSG_RESULT([$LIBS])
+ # Dependencies that themselves have a pkg-config file available.
+ #
+ PC_REQUIRES=""""
+-AS_IF([test ""$pmix_hwloc_support_will_build"" = ""yes""],
++AS_IF([test ""$pmix_hwloc_source"" != ""cobuild""],
+       [PC_REQUIRES=""$PC_REQUIRES hwloc""])
+ AS_IF([test $pmix_libevent_support -eq 1],
+       [PC_REQUIRES=""$PC_REQUIRES libevent""])","Wouldn't we have the same issue with the internal libevent? IIRC, the integration is pretty close to an exact duplicate. Or does the libevent m4 code already take that into account when setting this variable? PMIx _requires_ libevent, so it isn't like pmix_libevent_support can be anything other than 1. I'm okay with leaving this question for separate resolution - just wondering why we don't have the same issue here."
+4093,"@@ -51,6 +51,9 @@ func (h *tlsHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		strings.Contains(ua, ""Trident"") {
+ 		checked = true
+ 		mitm = !info.looksLikeEdge()
++	} else if strings.Contains(ua, ""CRiOS"") {
++		checked = true
++		mitm = !info.looksLikeChromeOniOS()
+ 	} else if strings.Contains(ua, ""Chrome"") {
+ 		checked = true
+ 		mitm = !info.looksLikeChrome()","The actual User-Agent string uses ""CriOS"" not ""CRiOS"""
+4094,"@@ -19,10 +19,8 @@ namespace Nethermind.Core
+ {
+     public interface IKeyValueStoreWithBatching : IKeyValueStore
+     {
+-        byte[]? this[byte[] key] { get; set; }
+-
+         void StartBatch();
+-
++
+         void CommitBatch();
+     }
+-}
++}","Unused code deletion. Is that a desired thing? No implementation of this actually used this indexer, so removing it seemed reasonable (and was suggested by the compiler). Maybe this had an indexer so plugins could use it? This change is definitely pushing the limits of what is appropriate in a ""cleanup"" as it is changing public API surface area."
+4095,"@@ -489,6 +489,14 @@ module Beaker
+             end
+
+           rescue Exception => teardown_exception
++            begin
++              if !host.is_pe?
++                dump_puppet_log(host)
++              end
++            rescue Exception => dumping_exception
++              logger.error(""Raised during attempt to dump puppet logs: #{dumping_exception}"")
++            end
++
+             if original_exception
+               logger.error(""Raised during attempt to teardown with_puppet_running_on: #{teardown_exception}\n---\n"")
+               raise original_exception",We'd lose the data here from the original teardown_exception and only get the dump_exception - I fear that that could make the actual error difficult to track if it cascades.
+4096,"@@ -266,6 +266,9 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 					dom.innerHTML = newHtml && newHtml.__html || '';
+ 				}
+ 			}
++			if (newVNode.props.multiple && newVNode.type==='select') {
++				dom.multiple = newVNode.props.multiple;
++			}
+ 			diffChildren(dom, newVNode, oldVNode, context, newVNode.type==='foreignObject' ? false : isSvg, excessDomChildren, mounts, ancestorComponent);
+ 			diffProps(dom, newVNode.props, oldProps, isSvg);
+ 		}",At this point in `diff()` we should know if we're dealing with a `component` or a native `html` element. We can reuse that information in this if-statement here :+1:
+4097,"@@ -215,7 +215,7 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch {
++	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= a.foundationBonusP2StartEpoch && epochNum <= a.foundationBonusP2EndEpoch) {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","somewhere in reward protocol, we need to do if epoch is Fairbank { a.foundationBonusP2StartEpoch = genesis.xxx a.foundationBonusP2EndEpoch = genesis.yyy p.state(sm, adminKey, &a) } that is to write the 2 new values at Fairbank height then this logic can follow"
+4098,"@@ -200,6 +200,10 @@ if __name__ == '__main__':
+     inventory_dao.initialize(SQL_ENGINE)
+     scanner_dao.initialize(SQL_ENGINE)
+
++    # Drop and recreate the CloudAssetInventory table
++    inventory_dao.CaiTemporaryStore.__table__.drop(SQL_ENGINE)
++    inventory_dao.CaiTemporaryStore.__table__.create(SQL_ENGINE)
++
+     # Find all the child classes inherited from declarative base class.
+     SCANNER_DAO_CLASSES = _find_subclasses(scanner_dao.BASE)
+ ","Dropping and recreating would delete all t he previous records, are they any important?"
+4099,"@@ -50,6 +50,15 @@ func (m *mockCgroupManager) Destroy() error {
+ 	return nil
+ }
+
++func (m *mockCgroupManager) Exists() bool {
++	paths := m.GetPaths()
++	if paths != nil {
++		_, err := os.Lstat(paths[""devices""])
++		return err == nil
++	}
++	return false
++}
++
+ func (m *mockCgroupManager) GetPaths() map[string]string {
+ 	return m.paths
+ }","While it is technically OK to use `m.GetPaths()` here, and it's a mock code so it doesn't really matter, I'd still like to have `m.Path(""devices"")` used here, because since commit 714c91e9f73a1512808476eb532b4aa36bbb7530 we're not supposed to use GetPaths() for anything other than state save/restore."
+4100,"@@ -481,6 +481,12 @@ func buildImage(mountPointMap, mountPointToFsTypeMap, mountPointToMountArgsMap m
+ 		setupChrootPackages = append(setupChrootPackages, toolingPackage.Name)
+ 	}
+
++	logger.Log.Infof(""HidepidDisabled is %v."", systemConfig.HidepidDisable)
++	hidepidEnable := true
++	if systemConfig.HidepidDisable {
++		hidepidEnable = false
++	}
++
+ 	if systemConfig.ReadOnlyVerityRoot.Enable {
+ 		// We will need the veritysetup package (and its dependencies) to manage the verity disk, add them to our
+ 		// image setup environment (setuproot chroot or live installer).","Let's be consistent everywhere: either ""Disable""/""Enable"" or ""Disabled""/""Enabled"". I'm voting for the latter.:)"
+4101,"@@ -2041,6 +2041,10 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       if (isPruningEnabled()) {
+         throw new ParameterException(commandLine, String.format(""%s %s"", ""Pruning"", errorSuffix));
+       }
++      if (isGoQuorumCompatibilityMode) {
++        throw new ParameterException(
++            commandLine, String.format(""%s %s"", ""GoQuorum mode"", errorSuffix));
++      }
+
+       if (isPrivacyMultiTenancyEnabled
+           && !jsonRpcConfiguration.isAuthenticationEnabled()",this works and is the smallest possible change but we could definitely fail earlier
+4102,"@@ -1,3 +1,4 @@
++//go:build !arm64
+ // +build !arm64
+
+ package nodeps","Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these"
+4103,"@@ -25,6 +25,8 @@ class NotesScreenComponent extends BaseScreenComponent {
+ 	constructor() {
+ 		super();
+
++		this.prevFolderId_ = null;
++
+ 		this.onAppStateChange_ = async () => {
+ 			// Force an update to the notes list when app state changes
+ 			const newProps = Object.assign({}, this.props);",Could you explain the logic with prevFolderId?
+4104,"@@ -0,0 +1,13 @@
++package testutil
++
++import ""github.com/facebookgo/clock""
++
++// TimestampNow get now timestamp from new clock
++func TimestampNow() uint64 {
++	return TimestampNowFromClock(clock.New())
++}
++
++// TimestampNowFromClock get now timestamp from specific clock
++func TimestampNowFromClock(c clock.Clock) uint64 {
++	return uint64(c.Now().Unix())
++}",Please add license header
+4105,"@@ -47,12 +47,13 @@
+
+ namespace lbann {
+
+-lbann_comm* initialize(int& argc, char**& argv, int seed) {
++lbann_comm_ptr initialize(int& argc, char**& argv, int seed) {
+   // Initialize Elemental.
+   El::Initialize(argc, argv);
+   // Create a new comm object.
+   // Initial creation with every process in one model.
+-  auto* comm = new lbann_comm(0);
++  auto comm = lbann_comm_ptr{new lbann_comm(0), &lbann::finalize };
++
+ #if defined(LBANN_TOPO_AWARE)
+   // Determine the number of NUMA nodes present.
+   hwloc_topology_t topo;","It bothers me that the user calls `initialize` without also calling `finalize`. It seems to me that we're essentially making `lbann_comm` a singleton object. Going further down this path, we would put `initialize` inside `lbann_comm`'s constructor and `finalize` in the destructor. This has it's own weirdness - the user must make sure it's lifespan matches the beginning and end of the program. We may also run into the case where someone might want multiple instances of `lbann_comm`, but this is not too important."
+4106,"@@ -353,6 +353,7 @@ void test4() {
+   smi = MolToSmiles(*m);
+   CHECK_INVARIANT(smi == ""c1cc[cH-]c1"", smi);
+   TEST_ASSERT(m->getConformer().is3D() == false);
++  delete m;
+
+   BOOST_LOG(rdInfoLog) << "" Finished <---------- "" << std::endl;
+ }",We should probably make a unique_ptr<ROMol> typedef in ROMol.h and start using that liberally.
+4107,"@@ -555,9 +555,13 @@ DefaultSettings.prototype = {
+    * ```
+    *
+    * @type {Boolean|String|Object}
+-   * @default true
++   * @default fillHandle: {
++       autoInsertRow: false,
++     }
+    */
+-  fillHandle: true,
++  fillHandle: {
++    autoInsertRow: false,
++  },
+
+   /**
+    * Allows to specify the number of fixed (or *frozen*) rows at the top of the table.",Can you add missing asterisk?
+4108,"@@ -243,7 +243,15 @@ public class Name {
+   }
+
+   public String toUpperCamelAndDigits() {
+-    char[] upper = toUpperCamel().toCharArray();
++    return capitalizeDigitsAfterNumbers(toUpperCamel());
++  }
++
++  public String toLowerCamelAndDigits() {
++    return capitalizeDigitsAfterNumbers(toLowerCamel());
++  }
++
++  private String capitalizeDigitsAfterNumbers(String camelCaseIdentifier) {
++    char[] upper = camelCaseIdentifier.toCharArray();
+     boolean digit = false;
+     for (int i = 0; i < upper.length; i++) {
+       if (Character.isDigit(upper[i])) {","late to the party, but I bet it meant to be `capitalizeLettersAfterNumbers` :)"
+4109,"@@ -235,6 +235,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+     private RecipientPresenter recipientPresenter;
+     private MessageBuilder currentMessageBuilder;
+     private boolean mFinishAfterDraftSaved;
++    private boolean firstTimeEmptyObject = true;
+
+     @Override
+     public void onFocusChange(View v, boolean hasFocus) {","The Activity is recreated on configuration changes and the value of the field is lost. So, e.g. pressing 'send' once will display the error message. If you rotate the device and press 'send' again, the message will show another time. Use `onSaveInstanceState()` and `onRetainInstanceState()` to save and restore the value of the field."
+4110,"@@ -643,7 +643,7 @@ func (s *Server) reloadOptions(curOpts, newOpts *Options) error {
+ 	if err != nil {
+ 		return err
+ 	}
+-	// Create a context that is used to pass special info that we may need
++	// Create a ctx that is used to pass special info that we may need
+ 	// while applying the new options.
+ 	ctx := reloadContext{oldClusterPerms: curOpts.Cluster.Permissions}
+ 	s.setOpts(newOpts)","Looks like a ""find and replace"" unintended change here"
+4111,"@@ -590,12 +590,13 @@ class SPRegion(PyRegion):
+     inputVector = numpy.array(rfInput[0]).astype('uint32')
+     outputVector = numpy.zeros(self._sfdr.getNumColumns()).astype('uint32')
+
+-    # Switch to using a random SP if learning mode is off and the SP hasn't
+-    # learned anything yet.
++    # Don't strip unlearned columns if learning is off and the SP hasn't
++    # learned anything yet. This acts as a random SP.
+     if (not self.learningMode) and (self._sfdr.getIterationLearnNum() == 0):
+-      self._sfdr.compute(inputVector, self.learningMode, outputVector, False)
++      self._sfdr.compute(inputVector, self.learningMode, outputVector)
+     else:
+       self._sfdr.compute(inputVector, self.learningMode, outputVector)
++      self._sfdr.stripUnlearnedColumns(outputVector)
+
+     self._spatialPoolerOutput[:] = outputVector[:]
+ ",haven't we got rid off `randomSP` recently? (I think `not learn` implied that)
+4112,"@@ -97,6 +97,7 @@ func (in *{{.Type}}) GetChaos() *ChaosInstance {
+ 		Kind:      Kind{{.Type}},
+ 		StartTime: in.CreationTimestamp.Time,
+ 		Action:    """",
++		Status:    string(in.GetStatus().Experiment.Phase),
+ 		UID:       string(in.UID),
+ 	}
+ ",Why we need use `in.GetStatus()` function here? Can we use `in.Status.xxxx` directly?
+4113,"@@ -93,7 +93,10 @@ func RenewManagedCertificates(allowPrompts bool) (err error) {
+ 				continue
+ 			}
+
+-			// this works well because managed certs are only associated with one name per config
++			// This works well because managed certs are only associated with one name per config.
++			// Note, the renewal inside here may not actually occur and no error will be returned
++			// due to renewal lock (i.e. because a renewal is already happening). This lack of
++			// error is by intention to force cache invalidation as though it has renewed.
+ 			err := cert.Config.RenewCert(allowPrompts)
+
+ 			if err != nil {","@cretz Just a thought: what if another renewal process updates the certificate between the beginning of this for loop (above on line 67) and actually calling RenewCert? Even though we have a read lock on the certCache, something else could have renewed it by now, and finished, which would cause this certificate to be renewed twice. Could you double-check my thinking here and see if that's a plausible 'race' condition? I wonder if the lock needs to be put over this whole function. (It's still early here; I could be wrong...)"
+4114,"@@ -57,13 +57,13 @@ PDEBUG_SYSTEM_OBJECTS g_ExtSystem;
+
+ // Queries for all debugger interfaces.
+ #ifndef FEATURE_PAL
+-extern ""C"" HRESULT
++HRESULT
+ ExtQuery(PDEBUG_CLIENT client)
+ {
+     HRESULT Status;
+     g_ExtClient = client;
+ #else
+-extern ""C"" HRESULT
++HRESULT
+ ExtQuery(ILLDBServices* services)
+ {
+     // Initialize the PAL and extension suppport in one place and only once.",We don't need this for the PInvoke?
+4115,"@@ -661,6 +661,10 @@ func (s *scheduler) getMentionedAccounts(ctx context.Context, event model.Notifi
+ 		return nil, err
+ 	}
+
++	if ds.GenericDeploymentConfig.DeploymentNotification == nil {
++		return nil, nil
++	}
++
+ 	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+ 		if e := ""EVENT_"" + v.Event; e == event.String() {
+ 			return v.Slack, nil","nits, I think add a log (using s.logger) to show why does this return with no error is better."
+4116,"@@ -334,7 +334,10 @@ func (a *WebAPI) getPiped(ctx context.Context, pipedID string) (*model.Piped, er
+ // It gives back error unless the piped belongs to the project.
+ func (a *WebAPI) validatePipedBelongsToProject(ctx context.Context, pipedID, projectID string) error {
+ 	pid, err := a.pipedProjectCache.Get(pipedID)
+-	if err == nil && pid == projectID {
++	if err == nil {
++		if pid != projectID {
++			return status.Error(codes.PermissionDenied, ""Requested piped doesn't belong to the project you logged in"")
++		}
+ 		return nil
+ 	}
+ ","Btw, It would be nice if we have some tests for those validation functions."
+4117,"@@ -23,6 +23,8 @@ public abstract class PathTemplateCheckView {
+
+   public abstract String paramName();
+
++  public abstract String methodName();
++
+   public static Builder newBuilder() {
+     return new AutoValue_PathTemplateCheckView.Builder();
+   }","Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?"
+4118,"@@ -3,7 +3,8 @@
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2010-2015 NV Access Limited, Mesar Hameed
++#Copyright (C) 2010-2019 NV Access Limited, Mesar Hameed, Takuya Nishimoto
++#Copyright (C) 2018-2019 Takuya Nishimoto
+
+ """"""Utilities related to NVDA Key Commands documents.
+ """"""",Please remove this line
+4119,"@@ -599,7 +599,7 @@ void CBOINCGUIApp::OnInitCmdLine(wxCmdLineParser &parser) {
+ #if (defined(__WXMAC__) && defined(_DEBUG))
+     parser.AddLongOption(""NSDocumentRevisionsDebugMode"", _(""Not used: workaround for bug in XCode 4.2""));
+ #endif
+-    parser.AddSwitch(""nd"", ""no-daemon"", _(""Not run the daemon""));
++    parser.AddSwitch(""nd"", ""no-daemon"", _(""Don't run the client""));
+ }
+
+ ",You could change the name of the command line switch too. Short options are typically one character after hyphen. wxWidgets' command line parser seems to handle `-nd` without confusing it with `-n` or `-d` but I'm not sure if that's by design or by accident. I'd remove the short option. `--no-daemon` is with hyphen but the rest of Manager and client uses underscore. Please change that.
+4120,"@@ -69,8 +69,8 @@ func AddFlags(flagSet *pflag.FlagSet) {
+ 	flags.BoolVarP(flagSet, &fs.Config.IgnoreCaseSync, ""ignore-case-sync"", """", fs.Config.IgnoreCaseSync, ""Ignore case when synchronizing"")
+ 	flags.BoolVarP(flagSet, &fs.Config.NoTraverse, ""no-traverse"", """", fs.Config.NoTraverse, ""Don't traverse destination file system on copy."")
+ 	flags.BoolVarP(flagSet, &fs.Config.NoUpdateModTime, ""no-update-modtime"", """", fs.Config.NoUpdateModTime, ""Don't update destination mod-time if files identical."")
+-	flags.StringVarP(flagSet, &fs.Config.CompareDest, ""compare-dest"", """", fs.Config.CompareDest, ""use DIR to server side copy flies from."")
+-	flags.StringVarP(flagSet, &fs.Config.CopyDest, ""copy-dest"", """", fs.Config.CopyDest, ""Compare dest to DIR also."")
++    flags.StringVarP(flagSet, &fs.Config.CompareDest, ""compare-dest"", """", fs.Config.CompareDest, ""Include additional server-side path during comparison."")
++    flags.StringVarP(flagSet, &fs.Config.CopyDest, ""copy-dest"", """", fs.Config.CopyDest, ""Implies --compare-dest but also copies files from path into destination."")
+ 	flags.StringVarP(flagSet, &fs.Config.BackupDir, ""backup-dir"", """", fs.Config.BackupDir, ""Make backups into hierarchy based in DIR."")
+ 	flags.StringVarP(flagSet, &fs.Config.Suffix, ""suffix"", """", fs.Config.Suffix, ""Suffix to add to changed files."")
+ 	flags.BoolVarP(flagSet, &fs.Config.SuffixKeepExtension, ""suffix-keep-extension"", """", fs.Config.SuffixKeepExtension, ""Preserve the extension when using --suffix."")",File is not `goimports`-ed (from `goimports`)
+4121,"@@ -439,7 +439,7 @@ func (r *RpmRepoCloner) clonePackage(baseArgs []string, enabledRepoOrder ...stri
+ 		logger.Log.Debugf(""stderr: %s"", stderr)
+
+ 		if err != nil {
+-			logger.Log.Errorf(""tdnf error (will continue if the only errors are toybox conflicts):\n '%s'"", stderr)
++			logger.Log.Debugf(""tdnf error (will continue if the only errors are toybox conflicts):\n '%s'"", stderr)
+ 		}
+
+ 		// ============== TDNF SPECIFIC IMPLEMENTATION ==============","Why are we mentioning toybox in this message? AND it still says ""tdnf error"". What's the actual error? Should it be resolved instead of flagged?"
+4122,"@@ -473,6 +473,7 @@ describe('GridFS Stream', function () {
+                     // Fail if user tries to abort an aborted stream
+                     uploadStream.abort().then(null, function (error) {
+                       expect(error.toString()).to.equal(
++                        // TODO(NODE-3405): Replace with MongoStreamClosedError
+                         'MongoDriverError: Cannot call abort() on a stream twice'
+                       );
+                       client.close(done);",You can remove these if they've been resolved in NODE-3405 and this isn't depending on it
+4123,"@@ -1,7 +1,7 @@
+ <%# locals: { phase } %>
+ <div class=""row"" id=""<%= dom_id(phase) %>"">
+   <div class=""col-xs-12"">
+-    <h4>
++    <h4 class=''>
+       <%= _('Instructions') %>
+       <a href=""<%= edit_plan_path(plan_id, phase_id: phase.id) %>"" class=""btn btn-default pull-right""><%= _('Write plan') %></a>
+     </h4>",don't need the class here if its empty
+4124,"@@ -4,11 +4,15 @@ import Ember from 'ember';
+ import moment from 'moment';
+ import { translationMacro as t } from 'ember-i18n';
+
++const { computed } = Ember;
++
+ export default AppointmentIndexRoute.extend(DateFormat, {
+   editReturn: 'appointments.search',
+   filterParams: ['appointmentType', 'provider', 'status'],
+   modelName: 'appointment',
+-  pageTitle: t('appointments.searchTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('appointments.searchTitle');
++  }),
+
+   queryParams: {
+     appointmentType: { refreshModel: true },",This should be computed('i18n.locale'....
+4125,"@@ -348,8 +348,8 @@ class BigQueryClient:
+             status = self.client.jobs().get(projectId=project_id, jobId=job_id).execute(num_retries=10)
+             if status['status']['state'] == 'DONE':
+                 if status['status'].get('errorResult'):
+-                    raise Exception('BigQuery job failed: {}'.format(status['status']['errorResult']))
+-                return
++                    raise BigQueryExecutionError(job_id, status['status']['errorResult'])
++                return job_id
+
+             logger.info('Waiting for job %s:%s to complete...', project_id, job_id)
+             time.sleep(5)",Please add return and return type description to docstring of this method.
+4126,"@@ -51,8 +51,10 @@ class ContributionsController < ApplicationController
+   private
+
+   def set_contributor
+-    @contributor = ContributorFact.where(names: { id: params[:id] }).where(analysis_id: @project.best_analysis_id)
+-                   .eager_load(:name).first
++    id = params[:id].to_i
++    @contributor = Contribution.find(id).name_fact if id > (1 << 32)
++    @contributor ||= ContributorFact.where(names: { id: id }).where(analysis_id: @project.best_analysis_id)
++                     .eager_load(:name).first
+     fail ParamRecordNotFound unless @contributor
+   end
+ ",What does 1 << 32 do? In irb typing this yields 4294967296. I didn't find the append operator in Numeric or Integer.
+4127,"@@ -79,6 +79,16 @@ module RSpec
+         RSpec.configuration.format_docstrings_block.call(description)
+       end
+
++      # @attr_accessor
++      #
++      # Holds the completion status of the example (nil if not completed)
++      attr_accessor :succeeded
++
++      # Convenience method for getting success status of example
++      def succeeded?
++        @succeeded
++      end
++
+       # @attr_reader
+       #
+       # Returns the first exception raised in the context of running this","We generally use metadata for this sort of thing, indeed there is a `metadata[:execution_result]`."
+4128,"@@ -483,6 +483,8 @@ class SpreadPlot(ElementPlot):
+     style_opts = line_properties + fill_properties
+     _plot_methods = dict(single='patch')
+
++    _stream_data = False # Plot does not support streaming data
++
+     def get_data(self, element, ranges, style):
+          mapping = dict(x='x', y='y')
+          xvals = element.dimension_values(0)",This was very confusing until I realized this might refer to the *bokeh* use of the word 'streaming'.
+4129,"@@ -47,6 +47,10 @@ type TaskHandler struct {
+ 	tasksToEvents map[string]*eventList
+ 	// tasksToEventsLock for locking the map
+ 	tasksToEventsLock sync.RWMutex
++	// batchMap is used to collect container events
++	// between task transitions
++	batchMap     map[string][]api.ContainerStateChange
++	batchMapLock sync.RWMutex
+ }
+
+ // NewTaskHandler returns a pointer to TaskHandler","Can you rename this as `tasksToContainerStates` ? If you do that, you can rename the lock as well"
+4130,"@@ -177,7 +177,7 @@ public class UserAccountManager {
+ 	 */
+ 	public Account getCurrentAccount() {
+         final Account[] accounts = accountManager.getAccountsByType(accountType);
+-        if (accounts == null || accounts.length == 0) {
++        if (accounts.length == 0) {
+         	return null;
+         }
+ ",Fixing `lint` warnings that have existed for a while.
+4131,"@@ -452,6 +452,18 @@ public interface Iterator<T> extends java.util.Iterator<T>, Traversable<T> {
+         return io.vavr.collection.Collections.fill(n, s);
+     }
+
++    /**
++     * Returns a Iterator containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Iterator
++     * @param n       The number of elements
++     * @param element The element
++     * @return An iterator of {@code n} sequence elements, where each element is the given {@code element}.
++     */
++    static <T> Iterator<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element);
++    }
++
+     /**
+      * Creates an Iterator of characters starting from {@code from}, extending to {@code toExclusive - 1}.
+      * <p>","An iterator **of {\@code n} sequential elements,** where each element ~are~ **is the** given {\@code element}."
+4132,"@@ -3,11 +3,13 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
++using Datadog.Trace.Configuration;
++
+ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AdoNet.MySql
+ {
+     internal static class MySqlConstants
+     {
+-        public const string SqlCommandIntegrationName = ""MySqlCommand"";
++        public const string SqlCommandIntegrationName = nameof(IntegrationIds.AdoNet);
+
+         internal struct MySqlDataClientData : IAdoNetClientData
+         {","If all of the `SqlCommandIntegrationName` values are the same, can we just remove it from `IAdoNetClientData` entirely and put the constant there?"
+4133,"@@ -17,6 +17,8 @@ limitations under the License.
+ package venafi
+
+ import (
++	""github.com/go-logr/logr""
++	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ 	corelisters ""k8s.io/client-go/listers/core/v1""
+
+ 	apiutil ""github.com/jetstack/cert-manager/pkg/api/util""",Maybe regroup this import with the other cert-manager packages.
+4134,"@@ -167,6 +167,8 @@ public class UserPreferences {
+         int theme = getTheme();
+         if (theme == R.style.Theme_AntennaPod_Dark) {
+             return R.style.Theme_AntennaPod_Dark_NoTitle;
++        }else if (theme == R.style.Theme_AntennaPod_TrueBlack){
++            return R.style.Theme_AntennaPod_TrueBlack_NoTitle;
+         } else {
+             return R.style.Theme_AntennaPod_Light_NoTitle;
+         }",There are spaces missing ;) Just have a look at the code style of the `if` statement above
+4135,"@@ -55,6 +55,9 @@ func (w *DefaultWorker) Generate(
+ 	mq := NewMessageQueue(pending)
+ 	candidateMsgs := orderMessageCandidates(mq.Drain())
+ 	candidateMsgs = w.filterPenalizableMessages(ctx, candidateMsgs)
++	if len(candidateMsgs) > block.BlockMessageLimit {
++		candidateMsgs = candidateMsgs[:block.BlockMessageLimit]
++	}
+
+ 	var blsAccepted []*types.SignedMessage
+ 	var secpAccepted []*types.SignedMessage","We should pass the size limit as a parameter to Drain so that we don't take messages out of the pool and then drop them. It's ok to merge as is, I will file an issue."
+4136,"@@ -1059,7 +1059,16 @@ encode_with_patch_list(dcontext_t *dcontext, patch_list_t *patch, instrlist_t *i
+             instr_encode_to_copy(dcontext, inst, vmcode_get_writable_addr(pc), pc);
+         byte *nxt_pc = vmcode_get_executable_addr(nxt_writable_pc);
+         ASSERT(nxt_pc != NULL);
++#ifdef AARCH64
++        /* Unlike X86 and ARM/AArch32 which use 1 instruction for an indirect jump,
++         * AArch64 requires 2 instructions: LDR+BR, see INSTR_CREATE_ldr()
++         * followed by XINST_CREATE_jump_reg() calls in
++         * emit_special_ibl_xfer().
++         */
++        len = (int)(nxt_pc - pc) + AARCH64_INSTR_SIZE;
++#else
+         len = (int)(nxt_pc - pc);
++#endif
+         pc = nxt_pc;
+
+         if (cur < patch->num_relocations && inst == patch->entry[cur].where.instr) {",Patch lists are used in many places so this is going to break other updates. This should just be a local change in emit_special_ibl_xfer() to pass the second-to-last instruction instead of the last instruction.
+4137,"@@ -38,7 +38,7 @@ char const * test_genesis_data = R""%%%({
+ 	""source"": ""B0311EA55708D6A53C75CDBF88300259C6D018522FE3D4D0A242E431F9E8B6D0"",
+ 	""representative"": ""xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo"",
+ 	""account"": ""xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo"",
+-	""work"": ""9680625b39d3363d"",
++	""work"": ""7b42a00ee91d5810"",
+ 	""signature"": ""ECDA914373A2F0CA1296475BAEE40500A7F0A7AD72A5A80C81D7FAB7F6C802B2CC7DB50F5DD0FB25B2EF11761FA7344A158DD5A700B21BD47DE5BD0F63153A02""
+ 	})%%%"";
+ ","@argakiig previous work was above live threshold, causing the high difficulty to bleed into other blocks when genesis open was processed in tests."
+4138,"@@ -1,4 +1,4 @@
+-class RemoveDiscountPercentageAndDiscountTitleFromProducts < ActiveRecord::Migration
++class RemoveDiscountPercentageAndDiscountTitleFromProducts < ActiveRecord::Migration[4.2]
+   def change
+     remove_column :products, :discount_percentage, :integer
+     remove_column :products, :discount_title, :string",Metrics/LineLength: Line is too long. [89/80]
+4139,"@@ -30,6 +30,7 @@ type SystemConfig struct {
+ 	Encryption         RootEncryption      `json:""Encryption""`
+ 	RemoveRpmDb        bool                `json:""RemoveRpmDb""`
+ 	ReadOnlyVerityRoot ReadOnlyVerityRoot  `json:""ReadOnlyVerityRoot""`
++	HidepidDisable     bool                `json:""HidepidDisable""`
+ }
+
+ // GetRootPartitionSetting returns a pointer to the partition setting describing the disk which",Please also extend the config tests now to include the new field.
+4140,"@@ -53,6 +53,7 @@ namespace NLog.Layouts
+         public JsonLayout()
+         {
+             this.Attributes = new List<JsonAttribute>();
++            this.RenderEmptyLiteral = true;
+         }
+
+         /// <summary>",I think it's wise to keep the behavior backwards-compatible (so `false` as default)
+4141,"@@ -47,7 +47,7 @@ module Selenium
+
+         opts[:path] ||= '/'
+         opts[:secure] ||= false
+-
++        opts[:sameSite]
+         obj = opts.delete(:expires)
+         opts[:expiry] = seconds_from(obj).to_i if obj
+ ","We don't need this line, do we?"
+4142,"@@ -0,0 +1,4 @@
++# Proprietary German backlinks service.
++# They keep requesting invalid formats.
++User-agent: SEOkicks-Robot
++Disallow: /",I don't know if we've actually had this problem on Upcase. I'd lean towards having a blank file unless (like on robots) we see multiple errors per week from this crawler.
+4143,"@@ -179,7 +179,13 @@ static void render_decorations(struct roots_view *view,
+ 	float matrix[16];
+ 	wlr_matrix_project_box(&matrix, &project_box, WL_OUTPUT_TRANSFORM_NORMAL,
+ 		view->rotation, &output->transform_matrix);
+-	float color[4] = { 0.2, 0.2, 0.2, 1 };
++	float color[4]	= { 0.2, 0.2, 0.2, 1 };
++	if (view_get_activated(view)) {
++		color[0] = 0.09804;
++		color[1] = 0.09804;
++		color[2] = 0.43921;
++	}
++
+ 	wlr_render_colored_quad(desktop->server->renderer, &color, &matrix);
+ }
+ ","I'm not good at picking colors, if anyone else has a preference."
+4144,"@@ -50,6 +50,10 @@ class FoldersScreenUtils {
+ 			this.refreshFolders();
+ 		}, 1000);
+ 	}
++
++	static cancelTimers() {
++		if (this.scheduleRefreshFoldersIID_) clearTimeout(this.scheduleRefreshFoldersIID_);
++	}
+ }
+
+ module.exports = { FoldersScreenUtils };","Note that even if you cancel the timer, the refreshFolders function might still be running since it's async. Could that be a problem for the test units? One big issue I had with tests is they sometimes would work and sometimes fail randomly, and that's because there are still code running in the background. One example was the ItemChange class, which saves data asynchronously. So I've implemented a waitForAllSaved(), which can be used for test units, to make sure nothing is running once the test ends. So just wondering if we might end up with this issue here."
+4145,"@@ -0,0 +1,16 @@
++'use strict';
++
++const tsd = require('tsd').default;
++const { expect } = require('chai');
++
++describe('Exported Types', () => {
++  it('should be as expected', async () => {
++    const diagnostics = await tsd();
++    if (diagnostics.length !== 0) {
++      const messages = diagnostics
++        .map(d => `${d.fileName}:${d.line}:${d.column} - [${d.severity}]: ${d.message}`)
++        .join('\n');
++      expect.fail('\n' + messages);
++    }
++  });
++});","can we make this something more descriptive? like... types should compile? I'm still not sure exactly what this is testing... this says ""Exported types"" - but what does tsd actually look at?"
+4146,"@@ -48,17 +48,12 @@ public class BridgeWebChromeClient extends WebChromeClient {
+     callback.onCustomViewHidden();
+     super.onShowCustomView(view, callback);
+   }
+-
+-  @Override
+-  public void onHideCustomView() {
+-    super.onHideCustomView();
+-  }
+
+   @Override
+   public void onPermissionRequest(final PermissionRequest request) {
+     boolean isRequestPermissionRequired = android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M;
+
+-    List<String> permissionList = new ArrayList<String>();
++    List<String> permissionList = new ArrayList<>();
+     if (Arrays.asList(request.getResources()).contains(""android.webkit.resource.VIDEO_CAPTURE"")) {
+       permissionList.add(Manifest.permission.CAMERA);
+     }",this method is need for full screen video button to appear in players
+4147,"@@ -26,6 +26,7 @@ type HeadersCfg struct {
+ 	penalize          func(context.Context, []headerdownload.PenaltyItem)
+ 	wakeUpChan        chan struct{}
+ 	batchSize         datasize.ByteSize
++	increment         *uint64
+ }
+
+ func StageHeadersCfg(",Why is this a pointer?
+4148,"@@ -30,12 +30,16 @@ import org.apache.iceberg.expressions.Expression;
+ import org.apache.iceberg.expressions.Expressions;
+ import org.apache.iceberg.expressions.UnboundPredicate;
+ import org.apache.iceberg.relocated.com.google.common.base.Objects;
++import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.types.Type;
+ import org.apache.iceberg.util.UnicodeUtil;
+
+ abstract class Truncate<T> implements Transform<T, T> {
+   @SuppressWarnings(""unchecked"")
+   static <T> Truncate<T> get(Type type, int width) {
++    Preconditions.checkArgument(width > 0,
++        ""The width of truncate must larger than zero,but is %s"", width);
++
+     switch (type.typeId()) {
+       case INTEGER:
+         return (Truncate<T>) new TruncateInteger(width);",nit: Space after comma
+4149,"@@ -853,6 +853,11 @@ class XLongField(LongField):
+         return lhex(self.i2h(pkt, x))
+
+
++class XLELongField(LELongField, XLongField):
++    def i2repr(self, pkt, x):
++        return XLongField.i2repr(self, pkt, x)
++
++
+ class IEEEFloatField(Field):
+     def __init__(self, name, default):
+         Field.__init__(self, name, default, ""f"")",A similar field is already define in `scapy/layers/bluetooth.py`. Can you merge both definitions ?
+4150,"@@ -204,6 +204,19 @@ class CppGenerator : public BaseGenerator {
+     if (num_includes) code_ += """";
+   }
+
++  void GenExtraIncludes() {
++    if(parser_.opts.cpp_includes.empty()) {
++      return;
++    }
++    // non-const copy needed for std::strtok
++    std::string data = parser_.opts.cpp_includes;
++    for(char* pch = std::strtok(&data[0], "","");
++        pch != nullptr; pch = std::strtok(nullptr, "","")) {
++      code_ += ""#include <"" + std::string(pch) + "">"";
++    }
++    code_ += """";
++  }
++
+   std::string EscapeKeyword(const std::string &name) const {
+     return keywords_.find(name) == keywords_.end() ? name : name + ""_"";
+   }","`std::strtok` isn't necessary. The `std::string::find_first_of` is better C++ alternative to `std::strtok`. For example, see `CheckedError Parser::ParseEnumFromString` method."
+4151,"@@ -3,9 +3,6 @@ namespace Psalm\CodeLocation;
+
+ class DocblockTypeLocation extends \Psalm\CodeLocation
+ {
+-    /** @var int */
+-    public $raw_line_number;
+-
+     public function __construct(
+         \Psalm\FileSource $file_source,
+         int $file_start,",This property is already declared in a parent with the same visibility/type/value. This one is redundant.
+4152,"@@ -78,6 +78,8 @@ def autorun_get_interactive_session(cmds, **kargs):
+             self.s = """"
+         def write(self, x):
+             self.s += x
++        def flush(self):
++            pass
+
+     sw = StringWriter()
+     sstdout,sstderr = sys.stdout,sys.stderr","This is required, otherwise multiprocessing will (for some reason) crash"
+4153,"@@ -19,6 +19,7 @@ package main
+ import (
+ 	""encoding/base64""
+ 	""fmt""
++	""github.com/algorand/go-algorand/data/basics""
+ 	""io""
+ 	""io/ioutil""
+ 	""os""",Please put in a separate line-separated block
+4154,"@@ -100,7 +100,7 @@ func (cmd *Command) Wait() error {
+ func (cmd *Command) Kill() error {
+ 	err := cmd.connectionManager.Disconnect()
+ 	if err != nil {
+-		return err
++		fmt.Printf(""Disconnect error: %s\n"", err)
+ 	}
+
+ 	cmd.httpApiServer.Stop()","Should error be eaten? If so, not clear why"
+4155,"@@ -145,4 +145,7 @@ class AuthorizationPolicy(core_authorization.AuthorizationPolicy):
+
+
+ class RouteFactory(core_authorization.RouteFactory):
+-    pass
++    def __init__(self, request):
++        super(RouteFactory, self).__init__(request)
++        if self.on_collection and self.resource_name == 'bucket':
++            self.force_empty_list = True","This attribute is not defined if the condition is not met. Instead, you could define another RouteFactory (e.g. `BucketRouteFactory` with a class attribute like `allow_empty_list`)"
+4156,"@@ -103,6 +103,13 @@ func WithCondition(cond hivev1.ClusterDeploymentCondition) Option {
+ 	}
+ }
+
++// WithInstalledTimestamp adds the specified InstalledTimestamp to ClusterDeployment.Status
++func WithInstalledTimestamp(timestamp metav1.Time) Option {
++	return func(clusterDeployment *hivev1.ClusterDeployment) {
++		clusterDeployment.Status.InstalledTimestamp = &timestamp
++	}
++}
++
+ func WithUnclaimedClusterPoolReference(namespace, poolName string) Option {
+ 	return WithClusterPoolReference(namespace, poolName, """")
+ }",Can we use the existing `InstalledTimestamp` function?
+4157,"@@ -975,14 +975,15 @@ public class AddProductActivity extends AppCompatActivity {
+         if (!editionMode) {
+             if (addProductOverviewFragment.areRequiredFieldsEmpty()) {
+                 viewPager.setCurrentItem(0, true);
+-            } else if (isNutritionDataAvailable() && addProductNutritionFactsFragment.containsInvalidValue()) {
++            } else if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) {
+                 viewPager.setCurrentItem(2, true);
+             } else {
+                 saveProduct();
+             }
+         } else {
+             // edit mode, therefore do not check whether front image is empty or not however do check the nutrition facts values.
+-            if ((isNutritionDataAvailable()) && addProductNutritionFactsFragment.containsInvalidValue()) {
++            if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) {
++                // If there are any invalid field and there is nutrition data, scroll to the nutrition fragmento
+                 viewPager.setCurrentItem(2, true);
+             } else {
+                 saveEditedProduct();","weird naming: `is` but `fields` (plural or singular ?) . If the method checks if the fragment has an invalid value, then ""hasInvalidValue"" or ""containsInvalidValue"" is fine no ?"
+4158,"@@ -28,7 +28,7 @@ LISTENS_PER_PAGE = 25
+ user_bp = Blueprint(""user"", __name__)
+
+
+-@user_bp.route(""/<user_name>"")
++@user_bp.route(""/<user_name>/"")
+ def profile(user_name):
+     # Which database to use to showing user listens.
+     db_conn = webserver.timescale_connection._ts",Does this mean that `listenbrainz.org/user/iliekcomputers` will start getting 404s?
+4159,"@@ -23,7 +23,11 @@ module Blacklight
+       # CatalogController.include ModuleDefiningNewMethod
+       # CatalogController.search_params_logic += [:new_method]
+       # CatalogController.search_params_logic.delete(:we_dont_want)
+-      self.search_params_logic = [:default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr, :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr, :add_sorting_to_solr, :add_group_config_to_solr ]
++      self.search_params_logic = [
++        :default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr,
++        :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr,
++        :add_sorting_to_solr, :add_group_config_to_solr, :add_facet_paging_to_solr
++      ]
+
+       if self.respond_to?(:helper_method)
+         helper_method(:facet_limit_for)",Line is too long. [82/80]
+4160,"@@ -28,6 +28,7 @@ CAN_INV_FILTER = 0x20000000
+
+ class CANSocket(SuperSocket):
+     desc = ""read/write packets at a given CAN interface using PF_CAN sockets""
++    async_select_unrequired = True
+
+     def __init__(self, iface=None, receive_own_messages=False,
+                  can_filters=None, remove_padding=True, basecls=CAN):",That's a strange name =)
+4161,"@@ -48,6 +48,17 @@ describe CommunicartMailer do
+       end
+     end
+
++    context 'custom templates' do
++      it 'renders a default template when an origin is not indicated' do
++        expect(mail.body.encoded).to include('Purchase Request')
++      end
++
++      it 'renders a custom template when origin is indicated' do
++        approval.cart.properties << Property.create!(property: 'origin', value:'whsc')
++        expect(mail.body.encoded).to include('White House Service Center: Purchase Request')
++      end
++    end
++
+   end
+
+   describe 'approval reply received email' do",Thoughts on this? I'm not crazy about the brittleness of this but haven't found a good way to test more generically that a specific (custom) template has been rendered.
+4162,"@@ -30,6 +30,7 @@ createMethods(Results.prototype, objectTypes.RESULTS, [
+     'filtered',
+     'sorted',
+     'snapshot',
++    'subscribe',
+     'isValid',
+     'indexOf',
+     'min',",Have we reached binding-level agreement on the `subscribe` terminology? My only concern is that it doesn't seem descriptive enough and may be confused with subscribing for notifications.
+4163,"@@ -138,7 +138,9 @@ func (tr *tracer) newRecordingSpan(psc, sc trace.SpanContext, name string, sr Sa
+ 	}
+
+ 	for _, l := range config.Links() {
+-		s.addLink(l)
++		if l.SpanContext.IsValid() {
++			s.addLink(l)
++		}
+ 	}
+
+ 	s.SetAttributes(sr.Attributes...)",would it not be safer to move this condition to the `addLink` method?
+4164,"@@ -611,6 +611,13 @@ func (h *Handler) reverseProxy(rw http.ResponseWriter, req *http.Request, di Dia
+
+ 	rw.WriteHeader(res.StatusCode)
+
++	// for some apps which need a correct response header to start http2 streaming,
++	// it's important to explicit flush headers to the client before copy streaming data.
++	if req.ProtoMajor == 2 && res.ContentLength == -1 {
++		if wf, ok := rw.(http.Flusher); ok {
++			wf.Flush()
++		}
++	}
+ 	err = h.copyResponse(rw, res.Body, h.flushInterval(req, res))
+ 	res.Body.Close() // close now, instead of defer, to populate res.Trailer
+ 	if err != nil {","I think this might read better: > some apps need the response headers before starting to stream content with http2, so it's important to explicitly flush the headers to the client before streaming the data."
+4165,"@@ -47,6 +47,13 @@ public interface FileScanTask extends ScanTask {
+    */
+   PartitionSpec spec();
+
++  /**
++   * The partition data for the file of this task.
++   *
++   * @return the partition data for the file of this task
++   */
++  StructLike partition();
++
+   /**
+    * The starting position of this scan range in the file.
+    *","What does this return if there is no partition? I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar."
+4166,"@@ -493,7 +493,16 @@ func DeleteRepo(
+
+ 	_, _, err = kbfsOps.Lookup(ctx, repoNode, normalizedRepoName)
+ 	if err != nil {
+-		return err
++		// For the common ""repo doesn't exist"" case, use an error type that the
++		// client can recognize.
++		switch errors.Cause(err).(type) {
++		case libkbfs.NoSuchNameError:
++			return libkb.RepoDoesntExistError{
++				Name: repoName,
++			}
++		default:
++			return err
++		}
+ 	}
+
+ 	deletedReposNode, err := lookupOrCreateDir(","Also, it might be worth returning this for the above lookup on `kbfsRepoDir` as well, which could happen if someone tries to delete a repo in a TLF that has never had any repos at all."
+4167,"@@ -171,6 +171,12 @@ var (
+ 		Usage: ""IP address to bind API to"",
+ 		Value: ""127.0.0.1"",
+ 	}
++	// FlagTequilapiAllowedHostnames Restrict hostnames in requests' Host header to following domains.
++	FlagTequilapiAllowedHostnames = cli.StringFlag{
++		Name:  ""tequilapi.allowed-hostnames"",
++		Usage: ""Comma separated list of allowed domains. Prepend value with dot for wildcard mask"",
++		Value: "".localhost, localhost, .localdomain"",
++	}
+ 	// FlagTequilapiPort port for listening for incoming API requests.
+ 	FlagTequilapiPort = cli.IntFlag{
+ 		Name:  ""tequilapi.port"",",Can this be `Hidden: true` as we already have a bunch of flags that are printed on `--help` and this seems like an average person should not care about it.
+4168,"@@ -488,11 +488,13 @@ class Controller
+
+         $useCache = !Config::get('cms.twigNoCache');
+         $isDebugMode = Config::get('app.debug', false);
++        $strictVariables = (Config::get('cms.enableTwigStrictVariables', null) !== null) ?: $isDebugMode;
+         $forceBytecode = Config::get('cms.forceBytecodeInvalidation', false);
+
+         $options = [
+             'auto_reload' => true,
+             'debug' => $isDebugMode,
++            'strict_variables' => $strictVariables,
+         ];
+
+         if ($useCache) {",Wouldn't this set $strictVariables = true when Config::get returns false?
+4169,"@@ -16,6 +16,7 @@ import javax.json.JsonReader;
+ import javax.xml.parsers.DocumentBuilder;
+ import javax.xml.parsers.DocumentBuilderFactory;
+ import static junit.framework.Assert.assertEquals;
++import org.junit.Ignore;
+ import org.junit.Test;
+ import org.xml.sax.ErrorHandler;
+ import org.xml.sax.InputSource;",was this meant to be checked in?
+4170,"@@ -156,4 +156,8 @@ const (
+ 	// attempt to reconnect a route, gateway or leaf node connection.
+ 	// The default is to report every attempt.
+ 	DEFAULT_RECONNECT_ERROR_REPORTS = 1
++
++	// DEFAULT_RTT_MEASUREMENT_INTERVAL	is how often we want to measure RTT from
++	// this server to clients, routes, gateways or leafnode connections.
++	DEFAULT_RTT_MEASUREMENT_INTERVAL = time.Hour
+ )",check spaces after const name...
+4171,"@@ -67,7 +67,10 @@ func (agent *ecsAgent) appendVolumeDriverCapabilities(capabilities []*ecs.Attrib
+
+ func (agent *ecsAgent) appendNvidiaDriverVersionAttribute(capabilities []*ecs.Attribute) []*ecs.Attribute {
+ 	if agent.resourceFields != nil && agent.resourceFields.NvidiaGPUManager != nil {
+-		capabilities = appendNameOnlyAttribute(capabilities, attributePrefix+capabilityNvidiaDriverVersionInfix+agent.resourceFields.NvidiaGPUManager.GetDriverVersion())
++		driverVersion := agent.resourceFields.NvidiaGPUManager.GetDriverVersion()
++		if driverVersion != """" {
++			capabilities = appendNameOnlyAttribute(capabilities, attributePrefix+capabilityNvidiaDriverVersionInfix+driverVersion)
++		}
+ 	}
+ 	return capabilities
+ }","If the GPU setting is enabled, resourceFields.NvidiaGPUManager will be nil, right?"
+4172,"@@ -363,7 +363,11 @@ HELP
+             when 'command'
+               executor.run_command(nodes, options[:object])
+             when 'script'
+-              executor.run_script(nodes, options[:object], options[:leftovers])
++              script = options[:object]
++              unless file_exist?(script)
++                raise Bolt::CLIError, ""The script '#{script}' does not exist""
++              end
++              executor.run_script(nodes, script, options[:leftovers])
+             when 'task'
+               task_name = options[:object]
+ ",We should probably verify that it's readable too
+4173,"@@ -355,7 +355,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+                                     throw new InvalidDataException(""Expected key value before dictionary data."");
+                                 }
+
+-                                string value = xmlReader.ReadElementContentAsString();
++                                xmlReader.ReadElementContentAsString();
+                                 readerMoved = true;
+                                 keyName = string.Empty;
+                                 break;","See, here's an example where you removed the variable but kept the call, which makes sense."
+4174,"@@ -78,12 +78,12 @@ public class FeedParserTask implements Callable<FeedHandlerResult> {
+         }
+
+         if (successful) {
+-            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(),
+-                    DownloadError.SUCCESS, successful, reasonDetailed);
++            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(), DownloadError.SUCCESS,
++                                                successful, reasonDetailed, request.isInitiatedByUser());
+             return result;
+         } else {
+-            downloadStatus = new DownloadStatus(feed, request.getTitle(),
+-                    reason, successful, reasonDetailed);
++            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(), reason, successful,
++                                                reasonDetailed, request.isInitiatedByUser());
+             return null;
+         }
+     }","Please use `request.getTitle()` instead of `feed.getHumanReadableIdentifier()`: In this case, `feed` does not have a human readable title yet"
+4175,"@@ -254,7 +254,7 @@ func waitForClef(logger logging.Logger, maxRetries uint64, endpoint string) (ext
+ 			return nil, err
+ 		}
+ 		maxRetries--
+-		logger.Errorf(""cannot connect to clef signer: %v"", err)
++		logger.Warningf(""failing to connect to clef signer: %v"", err)
+
+ 		time.Sleep(5 * time.Second)
+ 	}",I think the wording on the left is better
+4176,"@@ -69,7 +69,7 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // YARPC.
+ func Interceptor(interceptor func(yarpcHandler http.Handler) http.Handler) InboundOption {
+ 	return func(i *Inbound) {
+-		i.interceptor = interceptor
++		i.interceptors = append(i.interceptors, interceptor)
+ 	}
+ }
+ ",Please update the method described to point out that it maintains a chain of interceptors and they will be called in the same order passed in the options.
+4177,"@@ -37,9 +37,16 @@ namespace Datadog.Trace.ClrProfiler.Managed.Loader
+             }
+
+             var path = Path.Combine(ManagedProfilerDirectory, $""{assemblyName}.dll"");
++
+             if (File.Exists(path))
+             {
+-                StartupLogger.Debug(""Loading {0}"", path);
++                if (args.Name.StartsWith(""Datadog.Trace, Version="") && args.Name != AssemblyName)
++                {
++                    StartupLogger.Debug(""Trying to load {0} which does not match the expected version ({1})"", args.Name, AssemblyName);
++                    return null;
++                }
++
++                StartupLogger.Debug(""Resolving {0}, loading {1}"", args.Name, path);
+                 return Assembly.LoadFrom(path);
+             }
+ ",Is this case purely hypothetical or did it solve an issue that occurred in your testing? I'm trying to understand this change a little better
+4178,"@@ -431,7 +431,7 @@ func (p *ReplicationTaskProcessorImpl) putReplicationTaskToDLQ(replicationTask *
+ 	p.metricsClient.Scope(
+ 		metrics.ReplicationDLQStatsScope,
+ 		metrics.TargetClusterTag(p.sourceCluster),
+-		metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())),
++		metrics.InstanceTag(strconv.Itoa(int(p.shard.GetShardID()))),
+ 	).UpdateGauge(
+ 		metrics.ReplicationDLQMaxLevelGauge,
+ 		float64(request.TaskInfo.GetTaskId()),",Use instead `convert.Int32ToString` that was added in #762 for this purpose.
+4179,"@@ -473,7 +473,7 @@ public final class HashSet<T> implements Kind1<HashSet<?>, T>, Set<T>, Serializa
+
+     @Override
+     public HashSet<T> add(T element) {
+-        return new HashSet<>(tree.put(element, element));
++        return contains(element) ? this : new HashSet<>(tree.put(element, element));
+     }
+
+     @Override","If key is present, tree.put(k,v) needs to return a new instance for Maps and the same instance for Sets. Therefore we currently perform an additional 'contains' check for Sets. A future optimization may add an additional flag `replace` to the backing HAMT.put() / RedBlackTree.insert() methods. Sets set it to replace=false, Maps set it to replace=true. But for now this solution is working for us."
+4180,"@@ -0,0 +1,18 @@
++""""""Test to see we don't crash on this code in pandas.
++See: https://github.com/pandas-dev/pandas/blob/master/pandas/core/arrays/sparse/array.py
++Code written van G van Rossum here: https://github.com/python/typing/issues/684""""""
++# pylint: disable=no-member, redefined-builtin, invalid-name, missing-class-docstring
++
++from typing import TYPE_CHECKING
++
++if TYPE_CHECKING:
++    from enum import Enum
++
++    class ellipsis(Enum):
++        Ellipsis = ""...""
++
++    Ellipsis = ellipsis.Ellipsis
++
++
++else:
++    ellipsis = type(Ellipsis)",This is a regression test for code I found while working on this.
+4181,"@@ -6503,8 +6503,15 @@ ex_expr::exp_return_type ex_function_json_object_field_text::eval(char *op_data[
+         Int32 prec2 = ((SimpleType *)getOperand(2))->getPrecision();
+         len2 = Attributes::trimFillerSpaces( op_data[2], prec2, len2, cs );
+     }
++
+     char *rltStr = NULL;
+-    JsonReturnType ret = json_extract_path_text(&rltStr, op_data[1], 1, op_data[2]);
++    char *jsonStr = new(heap) char[len1+1];
++    char *jsonAttr = new(heap) char[len2+1];
++    strncpy(jsonStr, op_data[1], len1);
++    jsonStr[len1] = '\0';
++    strncpy(jsonAttr, op_data[2], len2);
++    jsonAttr[len2] = '\0';
++    JsonReturnType ret = json_extract_path_text(&rltStr, jsonStr, 1, jsonAttr);
+     if (ret != JSON_OK)
+     {
+         ExRaiseJSONError(heap, diagsArea, ret);","I'm wondering if we need to delete jsonStr and jsonAttr after the json_extract_path_text call to avoid unnecessary heap pressure. Though if json_extract_path_text itself does new's on the same heap, we'd get heap fragmentation. Another approach would be to allocate these on the stack instead, avoiding both concerns: char jsonStr[len1+1]; char jsonAttr[len2+1]; ..."
+4182,"@@ -67,14 +67,14 @@ def lambda_handler(request):
+     user_size = request.args.get('size', DEFAULT_SIZE)
+     user_source = request.args.get('_source', [])
+     # 0-indexed starting position (for pagination)
+-    user_from = request.args.get('from', 0)
++    user_from = int(request.args.get('from', 0))
+     terminate_after = None  # see if we can skip os.getenv('MAX_DOCUMENTS_PER_SHARD')
+
+     if not user_indexes or not isinstance(user_indexes, str):
+         raise ValueError(""Request must include index=<comma-separated string of indices>"")
+
+-    if not isinstance(user_from, int) or user_from < 0:
+-        raise ValueError(""'from' must be a positive integer"")
++    if user_from < 0:
++        raise ValueError(""'from' must be a non-negative integer"")
+
+     if action == 'packages':
+         query = request.args.get('query', '')",Does it come as `str`?
+4183,"@@ -290,7 +290,7 @@ public class IngredientsProductFragment extends BaseFragment implements IIngredi
+             substanceProduct.append("" "");
+
+             String allergen;
+-            for (int i = 0; i < allergens.size() - 1; i++) {
++            for (int i = 0; i <= allergens.size() - 1; i++) {
+                 allergen = allergens.get(i);
+                 substanceProduct.append(Utils.getClickableText(allergen, allergen, SearchType.ALLERGEN, getActivity(), customTabsIntent));
+                 substanceProduct.append("", "");",This should actually read as the following `for (int i = 0; i < allergens.size(); i++)`
+4184,"@@ -1192,6 +1192,10 @@ func (b *ColListTableBuilder) SetValue(i, j int, v values.Value) error {
+ }
+
+ func (b *ColListTableBuilder) AppendValue(j int, v values.Value) error {
++	if v.IsNull() {
++		return b.AppendNil(j)
++	}
++
+ 	switch v.Type() {
+ 	case semantic.Bool:
+ 		return b.AppendBool(j, v.Bool())","This is so useful and safety, I want to propose making AppendBool, AppendInt, etc. all private functions, and forcing us to use AppendValue(j, values.New(false)), etc."
+4185,"@@ -140,7 +140,9 @@ export function useImperativeHandle(ref, createHandle, args) {
+ 	const state = getHookState(currentIndex++);
+ 	if (argsChanged(state._args, args)) {
+ 		state._args = args;
+-		ref.current = createHandle();
++			if (ref) {
++				ref.current = createHandle();
++			}
+ 	}
+ }
+ ","Really, really small nit   I believe there's 3x tabs in here? And should it be just 2x?"
+4186,"@@ -748,6 +748,17 @@ Use this only if v4 signatures don't work, eg pre Jewel/v10 CEPH.`,
+ See: [AWS S3 Transfer acceleration](https://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration-examples.html)`,
+ 			Default:  false,
+ 			Advanced: true,
++		}, {
++			Name:     ""leave_parts_on_error"",
++			Provider: ""AWS"",
++			Help: `If true avoid calling abort upload on a failure, leaving all successfully uploaded parts on S3 for manual recovery.
++
++It should be set to true for resuming uploads across different sessions.
++
++WARNING: Storing parts of an incomplete multipart upload counts towards space usage on S3 and will add additional costs if not cleaned up.
++`,
++			Default:  false,
++			Advanced: true,
+ 		}},
+ 	})
+ }",Perhaps note that rclone can't do this yet?
+4187,"@@ -285,3 +285,14 @@ func (c *client) doRequest(
+
+ 	return res, requestError{}
+ }
++
++// ConfigureTransports converts an net/http HTTP/1 Transport to a http3.RoundTripper
++// Uses the original TLS config, if present, relying on the clone created on a
++// new connection.
++func ConfigureTransports(t1 *http.Transport) *RoundTripper {
++	roundtripper := &RoundTripper{
++		TLSClientConfig: t1.TLSClientConfig,
++		QuicConfig:      &quic.Config{},
++	}
++	return roundtripper
++}",You probably don't need to set an empty config here.
+4188,"@@ -12,6 +12,19 @@ from ..element import Element
+ from .grid import GridInterface
+ from .interface import Interface, DataError, dask_array_module
+
++try:
++    import cftime
++    cftime_types = (
++        cftime._cftime.DatetimeGregorian,
++        cftime._cftime.Datetime360Day,
++        cftime._cftime.DatetimeJulian,
++        cftime._cftime.DatetimeNoLeap,
++        cftime._cftime.DatetimeProlepticGregorian
++    )
++    util.datetime_types += cftime_types
++except:
++    cftime_types = ()
++
+
+ class XArrayInterface(GridInterface):
+ ","I think you are missing `cftime.DatetimeAllLeap` here. That said, all of these are subclasses of `cftime.datetime`, so I think you could get away with just using `cftime.datetime` here, rather than enumerating all of the different subclasses (since `cftime_types` is only used for instance checks)."
+4189,"@@ -37,6 +37,11 @@ const (
+ 	StoragePoolClaimCPK CasPoolKey = ""openebs.io/storage-pool-claim""
+ 	// CStorPoolClusterCPK is the CStorPoolcluster label
+ 	CStorPoolClusterCPK CasPoolKey = ""openebs.io/cstor-pool-cluster""
++	// CStorPoolInstanceCPK is the CStorPoolInstance label
++	CStorPoolInstanceCPK CasPoolKey = ""openebs.io/cstor-pool-instance""
++	// PredecessorBlockDeviceCPK is the annotation on the block device claim
++	// holding previous block device name
++	PredecessorBlockDeviceCPK CasPoolKey = ""openebs.io/bd-predecessor""
+ 	// NdmDiskTypeCPK is the node-disk-manager disk type e.g. 'sparse' or 'disk'
+ 	NdmDiskTypeCPK CasPoolKey = ""ndm.io/disk-type""
+ 	// NdmBlockDeviceTypeCPK is the node-disk-manager blockdevice type e.g. // 'blockdevice'",don't we need to set this label on pool pods? I don't see them being set
+4190,"@@ -27,7 +27,7 @@ struct train_kernel_cpu<Float, method::brute_force> {
+     train_result operator()(const context_cpu& ctx,
+                             const descriptor_base& desc,
+                             const train_input& input) const {
+-        throw unimplemented_error(""k-NN brute force method is not implemented for CPU!"");
++        throw unimplemented_error(""k-NN brute force method is not implemented for CPU"");
+         return train_result();
+     }
+ };","can remove, it isn't reachable."
+4191,"@@ -160,7 +160,7 @@ describe Cancellation do
+       subscription = build_stubbed(:subscription, plan: subscribed_plan)
+       cancellation = Cancellation.new(subscription)
+
+-      expect(cancellation.can_downgrade_instead?).to be_true
++      expect(cancellation.can_downgrade_instead?).to be true
+     end
+
+     it 'returns true if the subscribed plan is not the downgrade plan' do",`expect(cancellation).to be_can_downgrade_instead` would be preferred :rainbow: :rainbow:
+4192,"@@ -65,6 +65,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+                         }
+                     }
+
++                    if (_socket.IsClosed)
++                    {
++                        break;
++                    }
++
+                     if (result.IsCancelled)
+                     {
+                         // Send a FIN","Gross. The OS should timeout writes for completely unresponsive clients to begin with. Long term, the better solution is to enforce a minimum minimum data rate for responses. This might require a way to cancel LibuvAwaitables, but it definitely not OK to immediately kill the socket and any ongoing writes just because the request processing loop completed. You could consider doing that after some kind of timeout, but at that point you might as well just enforce a minimum rate."
+4193,"@@ -66,7 +66,8 @@ void mesh_reader::load() {
+   select_subset_of_data();
+ }
+
+-bool mesh_reader::fetch_datum(CPUMat& X, int data_id, int mb_idx, int tid) {
++bool mesh_reader::fetch_datum(CPUMat& X, int data_id, int mb_idx, thread_pool& io_thread_pool) {
++  //  int tid = io_thread_pool.get_local_thread_id();
+   if (m_random_flips) {
+     fast_rng_gen& gen = get_fast_generator();
+     std::uniform_int_distribution<int> dist(0, 1);","If this is not used, we should just delete the line."
+4194,"@@ -89,11 +89,7 @@ func defaultExec(
+ 	// for transporting shell-style streams
+ 	exec, err := remotecommand.NewSPDYExecutor(config, ""POST"", req.URL())
+ 	if err != nil {
+-		return nil, errors.Wrapf(
+-			err,
+-			""failed to exec into pod {%s}: failed to connect to the provided server"",
+-			name,
+-		)
++		return nil, err
+ 	}
+
+ 	// Stream initiates transport of standard shell streams",Are there other callers to this function. How will they be impacted.
+4195,"@@ -23,7 +23,7 @@
+ Defines an interface which all Auth handlers need to implement.
+ """"""
+
+-from plugin import Plugin
++from .plugin import Plugin
+
+ class NotReadyToAuthenticate(Exception):
+   pass","Let's be consistent. The majority of boto code does not use relative imports. Let's just stick to the existing standard of ""from boto.package.subpackage import Thing""."
+4196,"@@ -207,6 +207,12 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+   // CLI options defined by user at runtime.
+   // Options parsing is done with CLI library Picocli https://picocli.info/
+
++  @Option(
++      names = ""--identity"",
++      paramLabel = ""<String>"",
++      description = ""Identification for this node in the Client ID"")
++  private final Optional<String> identityString = Optional.empty();
++
+   // Completely disables P2P within Besu.
+   @Option(
+       names = {""--p2p-enabled""},",Suggestion: specify `arity` for this option.
+4197,"@@ -264,6 +264,9 @@ class SpikesPlot(PathPlot):
+     position = param.Number(default=0., doc=""""""
+       The position of the lower end of each spike."""""")
+
++    show_legend = param.Boolean(default=True, doc=""""""
++        Whether to show legend for the plot."""""")
++
+     style_opts = (['color', 'cmap', 'palette'] + line_properties)
+
+     def get_extents(self, element, ranges):","This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend."
+4198,"@@ -641,7 +641,7 @@ public final class Span implements Serializable { // for Spark and Flink jobs
+    */
+   public static String normalizeTraceId(String traceId) {
+     if (traceId == null) throw new NullPointerException(""traceId == null"");
+-    int length = traceId.length();
++    int length = traceId.trim().length();
+     if (length == 0) throw new IllegalArgumentException(""traceId is empty"");
+     if (length > 32) throw new IllegalArgumentException(""traceId.length > 32"");
+     int zeros = validateHexAndReturnZeroPrefix(traceId);",trim has performance impact and this is the lowest level library... seems the trim if occurs should happen in the UI or Query controller instead..
+4199,"@@ -80,6 +80,7 @@ class Request(testprocess.Line):
+
+             '/500-inline': [http.client.INTERNAL_SERVER_ERROR],
+         }
++        # pylint: enable=no-member
+         for i in range(15):
+             path_to_statuses['/redirect/{}'.format(i)] = [http.client.FOUND]
+         for suffix in ['', '1', '2', '3', '4', '5', '6']:",Probably also needed for the `http.client.FOUND` below?
+4200,"@@ -97,6 +97,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""                     Default value is \""T\""\n""
+     ""  --no-js-exports    Removes Node.js style export lines in JS.\n""
+     ""  --goog-js-export   Uses goog.exports* for closure compiler exporting in JS.\n""
++    ""  --es6-js-export    Uses ECMAScript 6 export style lines in JS.\n""
+     ""  --go-namespace     Generate the overrided namespace in Golang.\n""
+     ""  --go-import        Generate the overrided import for flatbuffers in Golang.\n""
+     ""                     (default is \""github.com/google/flatbuffers/go\"")\n""",Can you also add this to Compiler.md ?
+4201,"@@ -144,8 +144,9 @@ class HttpClient {
+  * @param {function(!Error)} onError The function to call if the request fails.
+  * @param {?string=} opt_data The data to send with the request.
+  * @param {?RequestOptions=} opt_proxy The proxy server to use for the request.
++ * @param {!number=} retries The current number of retries.
+  */
+-function sendRequest(options, onOk, onError, opt_data, opt_proxy) {
++function sendRequest(options, onOk, onError, opt_data, opt_proxy, retries) {
+   var hostname = options.hostname;
+   var port = options.port;
+ ",!numbers -> numbers
+4202,"@@ -413,9 +413,9 @@ public class JavaSurfaceNamer extends SurfaceNamer {
+    * <p>All Google cloud java libraries have package names like ""com.google.cloud.library.v1"" and
+    * the respective examples have package names like
+    * ""com.google.cloud.examples.library.v1.snippets"". This method assumes {@code packageName} has
+-   * the format of ""com.google.(.+).artifact.name"". This works for both existing libraries and the
+-   * baseline test. We will need to adjust this if in the future there are libraries that do not
+-   * follow the package name format assumed here.
++   * the format of ""com.google.orgname.artifact.name"", where ""artifact.name"" could be empty. This
++   * works for both existing libraries and the baseline test. We will need to adjust this if in the
++   * future there are libraries that do not follow the package name format assumed here.
+    */
+   @Override
+   public String getExamplePackageName() {",This description doesn't seem quite right for the longrunning case - `longrunning` isn't an orgname.
+4203,"@@ -93,4 +93,11 @@ public interface LeafCollector {
+    */
+   void collect(int doc) throws IOException;
+
++  /*
++   * optionally returns an iterator over competitive documents
++   */
++  default DocIdSetIterator iterator() {
++    return null;
++  }
++
+ }","maybe give it a more descriptive name, e.g. `competitiveFilter`"
+4204,"@@ -106,7 +106,7 @@ public class JWTVerificationkeyResolver implements VerificationKeyResolver {
+         }
+       }
+
+-      // Add all keys into a master list
++      // Add all keys into a primary list
+       if (issuerConfig.usesHttpsJwk()) {
+         keysSource = ""["" + String.join("", "", issuerConfig.getJwksUrls()) + ""]"";
+         for (HttpsJwks hjwks : issuerConfig.getHttpsJwks()) {","This occurrence of ""master"" is unrelated to master/slave replication. Maybe simply remove the word ""master"" or replace it with ""reference"" but ""primary"" doesn't really make sense."
+4205,"@@ -15,6 +15,7 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/actor/builtin/miner""
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/exec""
++	""github.com/filecoin-project/go-filecoin/proofs""
+ 	""github.com/filecoin-project/go-filecoin/types""
+ 	""github.com/filecoin-project/go-filecoin/vm/errors""
+ )","BLOCKING: This is a problem. We shouldn't be introducing new dependencies on proofs into actors. The miner has some dependencies that should be removed (#2555). This could be accomplished either by moving `proofs.Mode` to `types.ProofsMode` or by forgoing a new type altogether and replacing it with a boolean. The later would have the additional advantage of reducing the number of types we have to export through ABI. I get why `proofs.Mode` has value as a type over a boolean, but I'm not sure it's worth it here."
+4206,"@@ -74,7 +74,9 @@ func verifyReceiveMessage(r *request.Request) {
+ 		for _, msg := range out.Messages {
+ 			err := checksumsMatch(msg.Body, msg.MD5OfBody)
+ 			if err != nil {
+-				ids = append(ids, *msg.MessageId)
++				if msg.MessageId != nil {
++					ids = append(ids, *msg.MessageId)
++				}
+ 			}
+ 		}
+ 		if len(ids) > 0 {",We probably want to log the fact that a `MessageId` was not present in the response. In addition the `RequestID` from `request.Request` should be included in the message so that the user is aware of the issue.
+4207,"@@ -38,10 +38,11 @@ apiFetchMock.mockImplementation( ( ...args ) => {
+
+ const setupRegistry = ( { dispatch } ) => {
+ 	const { id, webPropertyId, accountId } = fixtures.propertiesProfiles.profiles[ 0 ];
++	const propertyID = webPropertyId;
+ 	dispatch( STORE_NAME ).setAccountID( accountId );
+ 	dispatch( STORE_NAME ).setPropertyID( webPropertyId );
+ 	dispatch( STORE_NAME ).setProfileID( id );
+-	dispatch( STORE_NAME ).receiveProfiles( fixtures.propertiesProfiles.profiles );
++	dispatch( STORE_NAME ).receiveProfiles( fixtures.propertiesProfiles.profiles, { propertyID } );
+ };
+
+ const setupRegistryWithExistingTag = ( { dispatch } ) => {","It feels a bit strange to re-assign that here, as that line itself has no context on why it's reassigned. I'd prefer if we could pass `{ propertyID: webPropertyId }` below instead (that's how we do that elsewhere too). This also applies to other similar re-assignments below - let's rather pass the values within the objects as applicable, since then there is more clear context on why this ""rename"" / ""reassignment"" is necessary (because of an object expecting specific properties)."
+4208,"@@ -172,6 +172,7 @@ module.exports = function(grunt) {
+                     'frontend/express/public/core/events/javascripts/countly.overview.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.details.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.details.models.js',
++                    'frontend/express/public/core/events/javascripts/countly.compare.models.js',
+                     'frontend/express/public/core/user-management/javascripts/countly.overview.models.js',
+                     'frontend/express/public/core/user-management/javascripts/countly.overview.views.js'
+                 ],",remove this in the new pr aswell when moving compare to plugins as discussed.
+4209,"@@ -210,10 +210,16 @@ Status YieldClauseWrapper::prepare(
+     yieldColsHolder_ = std::make_unique<YieldColumns>();
+     for (auto *col : cols) {
+         if (col->expr()->isInputExpression()) {
++            if (inputs == nullptr) {
++                return Status::Error(""Inputs nullptr."");
++            }
+             if (needAllPropsFromInput(col, inputs, yields)) {
+                 continue;
+             }
+         } else if (col->expr()->isVariableExpression()) {
++            if (varHolder == nullptr) {
++                return Status::Error(""VarHolder nullptr."");
++            }
+             auto ret = needAllPropsFromVar(col, varHolder, yields);
+             if (!ret.ok()) {
+                 return std::move(ret).status();","check varHolder is nullptr is redundant, ExecutionContext ensure"
+4210,"@@ -0,0 +1,8 @@
++module UnsubscribesHelper
++  def unsubscribe_token_verifier
++    @_unsubscribe_token_verifier ||= ActiveSupport::MessageVerifier.new(
++      ENV.fetch(""UNSUBSCRIBE_SECRET_BASE""),
++      digest: ""SHA256"".freeze,
++    )
++  end
++end",Make these frozen constants?
+4211,"@@ -55,8 +55,9 @@ def browseableMessage(message,title=None,isHtml=False):
+ 	if not title:
+ 		# Translators: The title for the dialog used to present general NVDA messages in browse mode.
+ 		title = _(""NVDA Message"")
+-	isHtmlArgument = ""true"" if isHtml else ""false""
+-	dialogString = u""{isHtml};{title};{message}"".format( isHtml = isHtmlArgument , title=title , message=message )
++	if not isHtml:
++		message = f""<pre>{message.replace('<', '&lt;')}</pre>""
++	dialogString = f""{title};{message}""
+ 	dialogArguements = automation.VARIANT( dialogString )
+ 	gui.mainFrame.prePopup()
+ 	windll.mshtml.ShowHTMLDialogEx( ",Please use something like html.escape() to ensure that the text is totally safe to include within html. &lt; is not enough.
+4212,"@@ -130,7 +130,7 @@ func (s *Service) RetrieveChunk(ctx context.Context, addr swarm.Address, origin
+ 		var (
+ 			peerAttempt  int
+ 			peersResults int
+-			resultC      = make(chan retrievalResult, maxSelects)
++			resultC      = make(chan retrievalResult, 2)
+ 		)
+
+ 		requestAttempt := 0","why is a buffered channel larger than 1 needed here? the separate goroutines can just try to write to the channel with a select-default block, and then it is not needed. i find the current implementation a bit convoluted, maybe we could simplify it a bit? not sure why it is needed for example to communicate an empty result. these patterns can be simplified using waitgroups"
+4213,"@@ -11,7 +11,7 @@
+ #
+ # It's strongly recommended that you check this file into your version control system.
+
+-ActiveRecord::Schema.define(version: 20150410155813) do
++ActiveRecord::Schema.define(version: 20150415145819) do
+
+   # These are extensions that must be enabled in order to support this database
+   enable_extension ""plpgsql""",There seem to be more changes in here than I'd expect (mostly `limit: 255` additions).
+4214,"@@ -38,6 +38,10 @@ namespace OpenTelemetry.Context.Propagation
+         private static readonly int VersionAndTraceIdAndSpanIdLength = ""00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-"".Length;
+         private static readonly int OptionsLength = ""00"".Length;
+         private static readonly int TraceparentLengthV0 = ""00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-00"".Length;
++        private static readonly int TraceStateKeyMaxLength = 256;
++        private static readonly int TraceStateKeyTenentMaxLength = 241;
++        private static readonly int TraceStateKeyVendorMaxLength = 14;
++        private static readonly int TraceStateValueMaxLength = 256;
+
+         /// <inheritdoc/>
+         public override ISet<string> Fields => new HashSet<string> { TraceState, TraceParent };","I'm not sure, but I think it's `Tenant`"
+4215,"@@ -15,8 +15,9 @@ namespace Datadog.Trace.Configuration
+         /// <paramref name=""data""/>.
+         /// </summary>
+         /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
++        /// <param name=""allowOptionalMappings"">Determines whether to create dictionary entries when the input has no value mapping</param>
+         /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
+-        public static IDictionary<string, string> ParseCustomKeyValues(string data)
++        public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)
+         {
+             var dictionary = new ConcurrentDictionary<string, string>();
+ ","Not sure if it's an issue, but this is a breaking change in a public API. Maybe we should add as an overload without optional parameter instead and delegate the existing call to this one?"
+4216,"@@ -147,6 +147,11 @@ func (o *Outbound) Transports() []transport.Transport {
+ 	return []transport.Transport{o.transport}
+ }
+
++// Chooser returns the outbound's peer chooser.
++func (o *Outbound) Chooser() peer.Chooser {
++	return o.chooser
++}
++
+ // Start the HTTP outbound
+ func (o *Outbound) Start() error {
+ 	return o.once.Start(o.chooser.Start)","as opposed to exposing the chooser function and increasing our API exposure for the purpose of tests, can we move the HTTP transport config test into this package?"
+4217,"@@ -461,6 +461,17 @@ error_conn:
+ 	return 0;
+ }
+
++static void wlr_drm_connector_set_dpms(struct wlr_output *output, enum dpms_enum level) {
++	struct wlr_drm_connector *conn = (struct wlr_drm_connector *)output;
++	struct wlr_drm_backend *drm = (struct wlr_drm_backend *)output->backend;
++
++    if (drmModeObjectSetProperty (drm->fd, conn->id,
++                DRM_MODE_OBJECT_CONNECTOR,
++                conn->props.dpms, level) < 0)
++        wlr_log(L_ERROR, ""Failed to set dpms state for %s"", conn->output.name);
++
++}
++
+ static bool wlr_drm_connector_set_mode(struct wlr_output *output,
+ 		struct wlr_output_mode *mode) {
+ 	struct wlr_drm_connector *conn = (struct wlr_drm_connector *)output;",This is using the legacy DRM interface. DPMS levels have been removed from the atomic interface IIRC. Should we handle DPMS levels at all?
+4218,"@@ -162,13 +162,13 @@ type confirmedTx struct {
+ 	watch   *transactionWatch
+ }
+
+-// potentiallyConfirmedWatches returns all watches with nonce less than what was specified
++// potentiallyConfirmedWatches returns all watches with nonce less than or equal what was specified
+ func (tm *transactionMonitor) potentiallyConfirmedWatches(nonce uint64) (watches []*transactionWatch) {
+ 	tm.lock.Lock()
+ 	defer tm.lock.Unlock()
+
+ 	for watch := range tm.watches {
+-		if watch.nonce < nonce {
++		if watch.nonce <= nonce {
+ 			watches = append(watches, watch)
+ 		}
+ 	}","I think this was correct before. The nonce passed in here is the nonce at a block (which is the next nonce not yet used, e.g. 0 if the account was never used, 1 if only the tx with nonce 0 has been sent). So if the in-block nonce is 12, then a transaction with nonce 12 cannot have been included yet."
+4219,"@@ -0,0 +1,13 @@
++const { NativeModules, Platform } = require('react-native');
++
++const ext = (Platform.OS === 'android' && NativeModules.ShareExtension) ?
++	{
++		data: () => NativeModules.ShareExtension.data(),
++		close: () => NativeModules.ShareExtension.close(),
++	} :
++	{
++		data: () => {},
++		close: () => {},
++	};
++
++export default ext;","Please name the file ShareExtension.js, as you import it under this name (also could you convert it to TypeScript please?)"
+4220,"@@ -45,6 +45,7 @@ type ClusterOpts struct {
+ 	TLSTimeout     float64           `json:""-""`
+ 	TLSConfig      *tls.Config       `json:""-""`
+ 	TLSMap         bool              `json:""-""`
++	TLSInsecure    bool              `json:""tls_insecure""`
+ 	ListenStr      string            `json:""-""`
+ 	Advertise      string            `json:""-""`
+ 	NoAdvertise    bool              `json:""-""`","Not sure if we need it, but if we set it, be sure to add `,omitempty`."
+4221,"@@ -17,7 +17,7 @@ var (
+ 	errGetLengthNotForVersionNegotiation = errors.New(""PublicHeader: GetLength cannot be called for VersionNegotiation packets"")
+ )
+
+-// The PublicHeader of a QUIC packet
++// The PublicHeader of a QUIC packet.
+ type PublicHeader struct {
+ 	Raw                  []byte
+ 	ConnectionID         protocol.ConnectionID","It's the whole `PublicHeader` that will change soon, and we should state that here, not in the member functions. If Jana's proposal for a new header is accepted, we might also want to rename the fields here. For example, there won't be a dedicated version flag anymore, so a more appropriate name might be `ContainsVersion` instead of `VersionFlag`."
+4222,"@@ -1003,8 +1003,8 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+     }
+
+     @Override
+-    public int indexOf(Character element, int from) {
+-        return back.indexOf(element, from);
++    public int indexOf(Object element, int from) {
++        return back.indexOf((Character) element, from);
+     }
+
+     @Override",I think `element` can stay of type `Character` because `Character` is a final class. The we do not need the cast in the line below.
+4223,"@@ -260,6 +260,15 @@ public interface ASTAnyTypeDeclaration
+     }
+
+
++    /**
++     * Returns true if this is a regular interface declaration (not an annotation).
++     * Note that {@link #isInterface()} counts annotations in.
++     */
++    default boolean isRegularInterface() {
++        return false;
++    }
++
++
+     /** Returns true if this is an {@linkplain ASTAnnotationTypeDeclaration annotation type declaration}. */
+     default boolean isAnnotation() {
+         return this instanceof ASTAnnotationTypeDeclaration;","Not sure, if we should do it the other way round. If you ask be in the middle of the night, whether Interface should return true as ""isInterface"" and what Annotation would return. I'd tell you, Annotations should return false.... I want to say, on first glance, I'd say, it's easier to have ""isInterface"" and ""isAnnotation"" rather than ""isInterface"", ""isAnnotation"" and ""isRegularInterface""... But I see, we also have ""isRegularClass"".... We still have the possibility to change the semantics of those APIs in PMD 7 *Update:* Or in other words: What is less surprising? That isInterface returns true for annotations or that it returns false?"
+4224,"@@ -67,7 +67,6 @@ def lambda_handler(request):
+             raise ValueError(""'packages' action searching indexes that don't end in '_packages'"")
+         _source = user_source
+         size = user_size
+-        terminate_after = None
+     elif action == 'search':
+         query = request.args.get('query', '')
+         my_fields = user_fields or [",This will potentially skip package results. Do we really want that?
+4225,"@@ -787,7 +787,7 @@ const std::map<llvm::StringRef, hipCounter> CUDA_RUNTIME_TYPE_NAME_MAP {
+   {""cudaErrorInvalidPc"",                                               {""hipErrorInvalidPc"",                                        """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 718
+   // CUDA_ERROR_LAUNCH_FAILED
+   {""cudaErrorLaunchFailure"",                                           {""hipErrorLaunchFailure"",                                    """", CONV_NUMERIC_LITERAL, API_RUNTIME}}, // 719
+-  // no analogue
++  // CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE
+   {""cudaErrorCooperativeLaunchTooLarge"",                               {""hipErrorCooperativeLaunchTooLarge"",                        """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 720
+   // CUDA_ERROR_NOT_PERMITTED
+   {""cudaErrorNotPermitted"",                                            {""hipErrorNotPermitted"",                                     """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 800",Please remove `HIP_UNSUPPORTED`
+4226,"@@ -438,7 +438,7 @@ type (
+
+ 	// CreateWorkflowExecutionResponse is the response to CreateWorkflowExecutionRequest
+ 	CreateWorkflowExecutionResponse struct {
+-		HistorySize int64
++		NewMutableStateStats MutableStateStatus
+ 	}
+
+ 	// GetWorkflowExecutionRequest is used to retrieve the info of a workflow execution","if this is a ""Status"" type then the variable name ""Stats"" (which implies ""statistics"") seems wrong (or at least confusing to me)"
+4227,"@@ -35,6 +35,10 @@ const (
+ 	exportKeystorePath    = ""/var/lib/sonm/worker_keystore""
+ )
+
++var (
++	leakedInsecureKey = common.HexToAddress(""0x8125721c2413d99a33e351e1f6bb4e56b6b633fd"")
++)
++
+ type options struct {
+ 	version     string
+ 	cfg         *Config",maybe will be better to put it into the default worker's config rather than hardcoding the address?
+4228,"@@ -2737,14 +2737,11 @@ describe('Find', function() {
+         var db = client.db(configuration.db);
+         var collection = db.collection('shouldNotMutateUserOptions');
+         var options = { raw: 'TEST' };
+-        collection.find({}, options, function(error) {
+-          test.equal(null, error);
+-          test.equal(undefined, options.skip);
+-          test.equal(undefined, options.limit);
+-          test.equal('TEST', options.raw);
+-          client.close();
+-          done();
+-        });
++        expect(() => collection.find({}, options)).to.throw(
++          'raw should be of type boolean, but is of type string.'
++        );
++        client.close();
++        done();
+       });
+     }
+   });","It seems like this is not meant to test the option failure, but rather that `raw` can be set. This may be a superfluous test now, and we might want to delete it."
+4229,"@@ -715,6 +715,16 @@ struct roots_seat_view *roots_seat_view_from_view(
+ 	return seat_view;
+ }
+
++static void release_fullscreen(struct roots_output *output) {
++	if (output->fullscreen_view) {
++		if (output->fullscreen_view->set_fullscreen) {
++			output->fullscreen_view->set_fullscreen(
++				output->fullscreen_view, false);
++		}
++		view_set_fullscreen(output->fullscreen_view, false, output->wlr_output);
++	}
++}
++
+ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
+ 	// Make sure the view will be rendered on top of others, even if it's
+ 	// already focused in this seat",This is already done by `view_set_fullscreen`
+4230,"@@ -101,6 +101,15 @@ func (pr *PeerRing) RemoveAll() []peer.Peer {
+ 	return peers
+ }
+
++// All returns a snapshot of all the peers from the ring as a list.
++func (pr *PeerRing) All() []peer.Peer {
++	peers := make([]peer.Peer, 0, len(pr.peerToNode))
++	for _, node := range pr.peerToNode {
++		peers = append(peers, getPeerForRingNode(node))
++	}
++	return peers
++}
++
+ func (pr *PeerRing) popNode(node *ring.Ring) peer.Peer {
+ 	p := getPeerForRingNode(node)
+ ","mmm I followed the convention of this collection. It has Add, Remove, RemoveAll, so All sounds reasonable. Else It would likely be AddPeer, RemovePeer, RemovePeers and Peers."
+4231,"@@ -65,6 +65,15 @@ class FlagFacade
+         return $this->flagRepository->getByIds($flagIds);
+     }
+
++    /**
++     * @param string $uuid
++     * @return \Shopsys\FrameworkBundle\Model\Product\Flag\Flag
++     */
++    public function getByUuid(string $uuid): Flag
++    {
++        return $this->flagRepository->getByUuid($uuid);
++    }
++
+     /**
+      * @param \Shopsys\FrameworkBundle\Model\Product\Flag\FlagData $flagData
+      * @return \Shopsys\FrameworkBundle\Model\Product\Flag\Flag","_nitpick_ I'm thinking about whether this method should be in the previous commit or not. I know it's not yet used there, but in theory, neither do UUID itself."
+4232,"@@ -760,6 +760,13 @@ void RaftPart::replicateLogs(folly::EventBase* eb,
+             break;
+         }
+
++        if (term_ != currTerm) {
++            VLOG(2) << idStr_ << ""Term has been updated, previous ""
++                    << currTerm << "", current "" << term_;
++            currTerm = term_;
++            break;
++        }
++
+         hosts = hosts_;
+     } while (false);
+ ","""break"" is right? You skip the line 768."
+4233,"@@ -0,0 +1,19 @@
++# RailsAdmin config file. Generated on May 30, 2012 16:34
++# See github.com/sferik/rails_admin for more informations
++
++RailsAdmin.config do |config|
++  config.authenticate_with do
++    unless current_user
++      session[:return_to] = request.url
++      redirect_to ""/sign_in"", :alert => ""You must first log in or sign up before accessing this page.""
++    end
++  end
++
++  config.authorize_with do
++    redirect_to ""/"", :alert => ""You are not authorized to access that page"" unless current_user.admin?
++  end
++
++  config.current_user_method { current_user }
++
++  config.main_app_name = ['Workshops', 'Admin']
++end",Can this use the route helper instead?
+4234,"@@ -44,6 +44,7 @@ var Set = wire.NewSet(
+ // The zero value is a server with the default options.
+ type Server struct {
+ 	reqlog        requestlog.Logger
++	Handler       http.Handler
+ 	healthHandler health.Handler
+ 	te            trace.Exporter
+ 	sampler       trace.Sampler",Why is this field exported and others aren't?
+4235,"@@ -273,6 +273,7 @@ var testFiles = [
+   , '/test/functional/byo_promises_tests.js'
+
+   // Functionality tests
++  , '/test/functional/dns_txt_records_tests.js'
+   , '/test/functional/mongo_client_tests.js'
+   , '/test/functional/collection_tests.js'
+   , '/test/functional/db_tests.js'",should we rename this like `mongodb_srv_tests.js`?
+4236,"@@ -46,7 +46,7 @@ class SearchConsoleDashboardWidgetSiteStats extends Component {
+ 	setOptions() {
+ 		const { selectedStats, series, vAxes } = this.props;
+
+-		const pageTitle = '' === googlesitekit.pageTitle ? '' : sprintf( __( 'Search Traffic Summary for %s', 'google-site-kit' ), decodeHtmlEntity( googlesitekit.pageTitle ) );
++		const pageTitle = googlesitekit.pageTitle && googlesitekit.pageTitle.length ? sprintf( __( 'Search Traffic Summary for %s', 'google-site-kit' ), decodeHtmlEntity( googlesitekit.pageTitle ) ) : '';
+
+ 		const options = {
+ 			chart: {","This should still have a value when there is no page title, e.g. just `__( 'Search Traffic Summary', 'google-site-kit' )`."
+4237,"@@ -60,7 +60,10 @@ import static org.apache.solr.common.params.CollectionParams.CollectionAction.*;
+ import static org.apache.solr.common.params.CommonAdminParams.ASYNC;
+ import static org.apache.solr.common.params.CommonAdminParams.NUM_SUB_SHARDS;
+
+-
++/**
++ * Index split request processed by Overseer. Requests from here go to the host of the parent shard,
++ * and are processed by @link.
++ */
+ public class SplitShardCmd implements OverseerCollectionMessageHandler.Cmd {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+   private static final int MIN_NUM_SUB_SHARDS = 2;",Oops.. meant to link to SplitOp here. I'll clean up in my next commit
+4238,"@@ -14,6 +14,10 @@ import android.widget.Toast;
+ import com.afollestad.materialdialogs.MaterialDialog;
+ import com.fasterxml.jackson.databind.JsonNode;
+ import com.firebase.jobdispatcher.JobParameters;
++
++import io.reactivex.SingleObserver;
++import io.reactivex.android.schedulers.AndroidSchedulers;
++import io.reactivex.disposables.Disposable;
+ import io.reactivex.schedulers.Schedulers;
+ import okhttp3.MediaType;
+ import okhttp3.OkHttpClient;",Remove these unnecessary imports that you've added.
+4239,"@@ -28,8 +28,8 @@ from qutebrowser.utils import usertypes
+
+
+ # Note this has entries for success/error/warn from widgets.webview:LoadStatus
+-UrlType = usertypes.enum('UrlType', ['success', 'error', 'warn', 'hover',
+-                                     'normal'])
++UrlType = usertypes.enum('UrlType', ['success', 'success_https', ' error',
++                                     'warn', 'hover', 'normal'])
+
+
+ class UrlText(textbase.TextBase):","That space shouldn't be here :wink: This lead to an exception whenever a page with an error was loaded, e.g. an inexistent host - I just fixed that :smile:"
+4240,"@@ -735,7 +735,7 @@ class TLSServerAutomaton(Automaton):
+                                                                 self.local_port)
+             return
+         self.socket, addr = s.accept()
+-        self.remote_ip, self.remote_port = addr
++        self.remote_ip, self.remote_port = addr, self.local_port
+
+         raise self.WAITING_FOR_ClientHello()
+ ",It seems this is not the way to fix issue #505.
+4241,"@@ -104,7 +104,7 @@ def binary_cross_entropy(pred,
+     if weight is not None:
+         weight = weight.float()
+     loss = F.binary_cross_entropy_with_logits(
+-        pred, label.float(), pos_weight=class_weight, reduction='none')
++        pred, label.float(), weight=class_weight, reduction='none')
+     # do the reduction for the weighted loss
+     loss = weight_reduce_loss(
+         loss, weight, reduction=reduction, avg_factor=avg_factor)",Please take a look at the docstring of `F.binary_cross_entropy_with_logits`. `weight` should be a tensor that matches the input tensor shape. It is Not the class-aware weight. `pos_weight` should be a vector with a length equal to the number of classes.
+4242,"@@ -85,12 +85,15 @@ func TestSuite(
+ 			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Windows 2012 R2 two disks, Network setting (path)""))
+ 		machineImageImportStorageLocationTestCase := junitxml.NewTestCase(
+ 			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Centos 7.4, Storage location""))
++		machineImageImportNetworkTagsTestCase := junitxml.NewTestCase(
++			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Import with network tags""))
+
+ 		testsMap[testType] = map[*junitxml.TestCase]func(
+ 			context.Context, *junitxml.TestCase, *log.Logger, *testconfig.Project, e2e.CLITestType){}
+ 		testsMap[testType][machineImageImportUbuntu3DisksNetworkSettingsNameTestCase] = runOVFMachineImageImportUbuntu3DisksNetworkSettingsName
+ 		testsMap[testType][machineImageImportWindows2012R2TwoDisksNetworkSettingsPathTestCase] = runOVFMachineImageImportWindows2012R2TwoDisksNetworkSettingsPath
+ 		testsMap[testType][machineImageImportStorageLocationTestCase] = runOVFMachineImageImportCentos74StorageLocation
++		testsMap[testType][machineImageImportNetworkTagsTestCase] = runOVFMachineImageImportWithNetworkTags
+ 	}
+
+ 	// gcloud only tests","Same here, merge with an existing test."
+4243,"@@ -28,7 +28,7 @@ EFI_DRIVER_BINDING_PROTOCOL  gSdMmcPciHcDriverBinding = {
+   NULL
+ };
+
+-#define SLOT_INIT_TEMPLATE  {0, UnknownSlot, 0, 0, 0, 0,\
++#define SLOT_INIT_TEMPLATE  {0, UnknownSlot, 0, 0, 0,\
+                                {EDKII_SD_MMC_BUS_WIDTH_IGNORE,\
+                                EDKII_SD_MMC_CLOCK_FREQ_IGNORE,\
+                                {EDKII_SD_MMC_DRIVER_STRENGTH_IGNORE}}}",@aimanrosli23 Could you help to confirm if you do not revert the change in below commit: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency
+4244,"@@ -76,8 +76,10 @@ public class AvroSchemaUtil {
+     return TypeUtil.visit(type, new TypeToSchema(names));
+   }
+
+-  public static Type convert(Schema schema) {
+-    return AvroSchemaVisitor.visit(schema, new SchemaToType(schema));
++  public static org.apache.iceberg.Schema convert(Schema schema) {
++    final Type type = AvroSchemaVisitor.visit(schema, new SchemaToType(schema));
++    final List<Types.NestedField> fields = type.asNestedType().asStructType().fields();
++    return new org.apache.iceberg.Schema(fields);
+   }
+
+   static boolean hasIds(Schema schema) {",Can we do this without a breaking API change? What about adding a different name to convert directly to a Schema?
+4245,"@@ -1,7 +1,8 @@
+ 'use strict';
+
+-var MongoClient = require('../../').MongoClient,
+-  expect = require('chai').expect;
++const Promise = require('bluebird');
++const MongoClient = require('../../').MongoClient;
++const expect = require('chai').expect;
+
+ function connectToDb(url, db, options, callback) {
+   if (typeof options === 'function') {",Why do we need to pull bluebird in here?
+4246,"@@ -121,9 +121,10 @@ public class FlowPreparer extends AbstractFlowPreparer {
+           (flowPrepCompletionTime - criticalSectionStartTime) / 1000,
+           flow.getExecutionId(), execDir.getPath());
+     } catch (final Exception ex) {
+-      FileIOUtils.deleteDirectorySilently(tempDir);
+       LOGGER.error(""Error in preparing flow execution {}"", flow.getExecutionId(), ex);
+       throw new ExecutorManagerException(ex);
++    } finally {
++      FileIOUtils.deleteDirectorySilently(tempDir);
+     }
+   }
+ ","If *two* threads successfully download the same project into two different temp dirs, and one of them successfully renames one to its final destination, the `if`on line 102 will be false _in the other thread_, and it would leave its temp dir behind."
+4247,"@@ -37,6 +37,7 @@ struct pool_entry_t {
+     h2o_socket_export_t sockinfo;
+     h2o_socketpool_target_t *target;
+     h2o_linklist_t link;
++    h2o_linklist_t target_link;
+     uint64_t added_at;
+ };
+ ",I would appreciate it if you could rename `link` to `all_link` so that the roles of the two links (the other is `target_link`) become clearer.
+4248,"@@ -826,10 +826,16 @@ class InitialDevelopmentTests(unittest.TestCase):
+ 			""Testing testing "",
+ 			speech.PitchCommand(offset=100),
+ 			""1 2 3 4"",
+-			smi.create_ConfigProfileTriggerCommand(t1, True, expectedToBecomeIndex=1),
+-			smi.create_ConfigProfileTriggerCommand(t2, True, expectedToBecomeIndex=2),
++			ExpectedIndex(1),
++			# The preceeding index is expected,
++			# as the following profile trigger commands will cause the utterance to be split here.
++			ConfigProfileTriggerCommand(t1, True),
++			ConfigProfileTriggerCommand(t2, True),
+ 			""5 6 7 8"",
+-			smi.create_ConfigProfileTriggerCommand(t1, False, expectedToBecomeIndex=3),
++			ExpectedIndex(2),
++			# The preceeding index is expected,
++			# as the following profile trigger commands will cause the utterance to be split here.
++			ConfigProfileTriggerCommand(t1, False),
+ 			""9 10 11 12""
+ 		]
+ 		with smi.expectation():","Is there a reason not to use `smi.create_expectedIndex` here (and in other places)? The `smi.create_expectedIndex` function will also check to make sure that you don't accidentally skip or duplicate any indexes. With the goal of avoiding errors in the test. It does mean that you have to be diligent with how the expected indexes are created, which can be annoying too. My logic was that it is better to be annoyed by constraints during development time than to find out some time later that the test didn't do what I thought."
+4249,"@@ -43,8 +43,8 @@ class StripeSubscription
+   def create_customer
+     new_stripe_customer = Stripe::Customer.create(
+       card: @checkout.stripe_token,
+-      description: @checkout.email,
+-      email: @checkout.email
++      description: @checkout.user_email,
++      email: @checkout.user_email,
+     )
+     @checkout.stripe_customer_id = new_stripe_customer.id
+   end",Put a comma after the last parameter of a multiline method call.
+4250,"@@ -29,7 +29,7 @@ type ImageWithPort struct {
+ type LBFargateConfig struct {
+ 	RoutingRule      `yaml:""http,flow""`
+ 	ContainersConfig `yaml:"",inline""`
+-	Public           bool               `yaml:""public""`
++	Public           *bool              `yaml:""public""` // A pointer because we don't want the environment override to default to false.
+ 	Scaling          *AutoScalingConfig `yaml:"",flow""`
+ }
+ ",I don't know if we even need this parameter.
+4251,"@@ -1,5 +1,5 @@
+ """"""Test that we are emitting arguments-differ when the arguments are different.""""""
+-# pylint: disable=missing-docstring, too-few-public-methods, unused-argument,useless-super-delegation, useless-object-inheritance
++# pylint: disable= arguments-renamed, missing-docstring, too-few-public-methods, unused-argument,useless-super-delegation, useless-object-inheritance
+
+ class Parent(object):
+ ",What is the new result of this file if we keep it the same than before? It's just to picture easily what changed in this MR :) (thinking is hard)
+4252,"@@ -165,7 +165,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+
+                     using (var reader = new StreamReader(stream, Encoding.ASCII))
+                     {
+-                        var response = reader.ReadToEnd();
++                        var response = await reader.ReadToEndAsync();
+                         Assert.Contains($""bytesRead: {data.Length}"", response);
+                     }
+                 }",This needs to be synchronous for the timeout to work.
+4253,"@@ -23,11 +23,7 @@ Where
+ <% if purchaseable.city.present? %><%= purchaseable.city %>, <% end %><%= purchaseable.state %> <%= purchaseable.zip %>
+ <% end -%>
+
+-<% unless purchaseable.starts_immediately? -%>
+-We will be in touch before <%= purchase.starts_on.to_s(:simple) %> with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.
+-<% end -%>
+-
+-<%= purchaseable.reminder_email %>
++We will be in touch before the workshop with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.
+
+ <% if purchaseable.workshop.announcement.present? -%>
+ <%= purchaseable.workshop.announcement.message %>",Can you break this onto multiple lines?
+4254,"@@ -298,11 +298,11 @@ const instr_info_t A32_ext_bit7[][2] = {
+  */
+ const instr_info_t A32_ext_bit19[][2] = {
+   { /* 0 */
+-    {EXT_SIMD8,         0xf2800000, ""(ext simd8  0)"", xx, xx, xx, xx, xx, no, x, 0},
+-    {EXT_SIMD5,         0xf2880000, ""(ext simd5  0)"", xx, xx, xx, xx, xx, no, x, 0},
++    {EXT_SIMD8,         0xf2800010, ""(ext simd8  0)"", xx, xx, xx, xx, xx, no, x, 0},
++    {EXT_SIMD5,         0xf2880010, ""(ext simd5  0)"", xx, xx, xx, xx, xx, no, x, 0},
+   }, { /* 1 */
+-    {EXT_SIMD8,         0xf3800000, ""(ext simd8  1)"", xx, xx, xx, xx, xx, no, x, 1},
+-    {EXT_SIMD5,         0xf3880000, ""(ext simd5  1)"", xx, xx, xx, xx, xx, no, x, 1},
++    {EXT_SIMD8,         0xf3800010, ""(ext simd8  1)"", xx, xx, xx, xx, xx, no, x, 1},
++    {EXT_SIMD5,         0xf3880010, ""(ext simd5  1)"", xx, xx, xx, xx, xx, no, x, 1},
+   },
+ };
+ ","OK, it looks like all children have bit 4 set, but it doesn't really matter at this split point: just informative, nothing reads it."
+4255,"@@ -32,6 +32,12 @@ type DNSZoneSpec struct {
+ 	// Zone is the DNS zone to host
+ 	Zone string `json:""zone""`
+
++	// LinkToParentDomain specifies whether DNS records should
++	// be automatically created to link this DNSZone with a
++	// parent domain.
++	// +optional
++	LinkToParentDomain bool `json:""linkToParentDomain,omitempty""`
++
+ 	// AWS specifies AWS-specific cloud configuration
+ 	// +optional
+ 	AWS *AWSDNSZoneSpec `json:""aws,omitempty""`","Sorry for the very basic question but why do we still have a DNSZone CRD in light of the DNSEndpoint, I don't fully understand the differences."
+4256,"@@ -0,0 +1,17 @@
++package session
++
++import (
++	""testing""
++	""github.com/stretchr/testify/assert""
++)
++
++func TestManagerHasUniqueSessionsStored(t *testing.T) {
++	manager := Manager{}
++	length := 10
++
++	for i := 0; i < length; i++ {
++		manager.Create()
++	}
++
++	assert.Len(t, manager.Sessions, length)
++}",Looks like loop with overhead. You can: - create SID - test private function `sessionIsUnique()`
+4257,"@@ -54,6 +54,7 @@ public class UserPreferences {
+     private static final String PREF_SHOW_DOWNLOAD_REPORT = ""prefShowDownloadReport"";
+     public static final String PREF_BACK_BUTTON_BEHAVIOR = ""prefBackButtonBehavior"";
+     private static final String PREF_BACK_BUTTON_GO_TO_PAGE = ""prefBackButtonGoToPage"";
++    public static final String PREF_QUEUE_SORT_ORDER = ""prefQueueSortOrder"";
+
+     // Queue
+     private static final String PREF_QUEUE_ADD_TO_FRONT = ""prefQueueAddToFront"";","In my opinion, it would be better to have two separate settings. One that stores if sorting is enabled and one that stores the order. That allows to toggle automatic sort without having to re-select the order."
+4258,"@@ -1,7 +1,10 @@
+ package main
+
+-import ""github.com/spiffe/sri/control_plane/cli""
+-import ""os""
++import (
++	""os""
++
++	""github.com/spiffe/sri/control_plane/cli""
++)
+
+ func main() {
+ 	control_plane_cli.Run(os.Args)",/me can't wait to rename this repo :)
+4259,"@@ -18,10 +18,14 @@ const handleCallback = require('../utils').handleCallback;
+ const indexInformationDb = require('./db_ops').indexInformation;
+ const isObject = require('../utils').isObject;
+ const Long = require('mongodb-core').BSON.Long;
++const makeLazyLoader = require('../utils').makeLazyLoader;
+ const MongoError = require('mongodb-core').MongoError;
+ const ReadPreference = require('mongodb-core').ReadPreference;
+ const toError = require('../utils').toError;
+
++const collLoader = makeLazyLoader(`${__dirname}/../collection`);
++const dbLoader = makeLazyLoader(`${__dirname}/../db`);
++
+ /**
+  * Group function helper
+  * @ignore",nit: maybe call these `loadCollection()/loadDb()`
+4260,"@@ -562,6 +562,19 @@ class Task(object):
+         Default behavior is to send an None value""""""
+         pass
+
++    def on_external_failure(self):
++        """"""
++        Override for custom error handling for failed external tasks.
++
++        This method gets called if a task is an :py:class:`luigi.task.ExternalTask`, or if a
++        :py:class:`luigi.task.Task`'s :py:meth:`run` method is not implemented.
++
++        The returned value is json encoded and sent to the scheduler as the `expl` argument.
++
++        Default behavior is to send a None value
++        """"""
++        pass
++
+     @contextmanager
+     def no_unpicklable_properties(self):
+         """"""",Did you consider just do `return Task is an external data dependency and data does not exist (yet?).'`? Less `None`'s and `ifs`.
+4261,"@@ -2,13 +2,10 @@
+       <li class=""cite"">
+         <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect{|doc| doc.document_id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
+       </li>
+-      <li class=""refworks"">
+-        <%= render :partial => 'catalog/refworks_form', :locals => {:documents=>@document_list} %>
+-      </li>
+-
+-      <li class=""endnote"">
+-        <%= link_to t('blacklight.tools.endnote'), endnote_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}, :format => 'endnote'), {:class => 'btn btn-default'}%>
+-      </li>
++      <% if defined? BlacklightMarc %>
++        <%= render partial: 'bookmarks/refworks' %>
++        <%= render partial: 'bookmarks/endnote' %>
++      <% end %>
+       <li class=""email"">
+         <%= link_to t('blacklight.tools.email'), email_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}), :class=>""btn btn-default"", :id => ""emailLink"", :data => {:ajax_modal => ""trigger""} %>
+       </li>","Some day, we really need to make these toolbars pluggable.."
+4262,"@@ -100,7 +100,11 @@ class WebEngineAction(browsertab.AbstractAction):
+         """"""Save the current page.""""""
+         self._widget.triggerPageAction(QWebEnginePage.SavePage)
+
+-    def show_source(self):
++    def show_source(self, pygment):
++        if pygment:
++            self._show_source_pygment()
++            return
++
+         try:
+             self._widget.triggerPageAction(QWebEnginePage.ViewSource)
+         except AttributeError:",This should be `pygment=False` like in `browsertab.py`
+4263,"@@ -766,6 +766,11 @@ func (s *Server) createClient(conn net.Conn) *client {
+ 		return c
+ 	}
+
++	// If there is a max subscriptions specified, add to the client.
++	if opts.MaxSubs > 0 {
++		c.msubs = opts.MaxSubs
++	}
++
+ 	// If there is a max connections specified, check that adding
+ 	// this new client would not push us over the max
+ 	if opts.MaxConn > 0 && len(s.clients) >= opts.MaxConn {",Should this be moved down (or up) to under the client lock instead of server lock?
+4264,"@@ -273,8 +273,6 @@ fpga_result __FPGA_API__ xfpga_fpgaGetMetricsByIndex(fpga_handle handle,
+ 			result = FPGA_OK;
+ 		}
+
+-	} else {
+-		result = FPGA_INVALID_PARAM;
+ 	}
+
+ out_unlock:",Why are we removing this?
+4265,"@@ -76,7 +76,7 @@ module Gsa18f
+
+     # @todo - this is pretty ugly
+     def public_identifier
+-      self.cart.id
++      ""##{self.cart.id}""
+     end
+
+     def total_price",What do you think about using `self.id` ?
+4266,"@@ -442,7 +442,17 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			retry := 0
++			for err != nil && retry < 10 {
++				// Set Ready and Live to false
++				healthAggregator.Report(healthName, &health.HealthReport{Live: false, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Warn(""Retrying to start Typha"")
++				retry++
++			}
++			if err != nil && retry > 10 {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()","Please log once here at Error level ""Failed to connect to Typha, will retry..."""
+4267,"@@ -1,5 +1,5 @@
+ # frozen_string_literal: true
+
+ module Faker #:nodoc:
+-  VERSION = '2.18.0'
++  VERSION = '2.18.1'
+ end",Can you revert this change? The `VERSION` value will be updated after maintainer determines the version at release.
+4268,"@@ -25,13 +25,13 @@ public interface DefinitionConst {
+
+   String nameKey = ""name"";
+
+-  String qulifiedServiceNameKey = serviceDescriptionKey + ""."" + nameKey;
++  String qualifiedServiceNameKey = serviceDescriptionKey + ""."" + nameKey;
+
+-  String qulifiedServiceVersionKey = serviceDescriptionKey + "".version"";
++  String qualifiedServiceVersionKey = serviceDescriptionKey + "".version"";
+
+-  String qulifiedServiceDescKey = serviceDescriptionKey + "".description"";
++  String qualifiedServiceDescKey = serviceDescriptionKey + "".description"";
+
+-  String qulifiedServiceRoleKey = serviceDescriptionKey + "".role"";
++  String qualifiedServiceRoleKey = serviceDescriptionKey + "".role"";
+
+   String allowCrossAppKey = ""allowCrossApp"";
+ ",It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string.
+4269,"@@ -108,8 +108,12 @@ module RSpec
+       #   or the configured failure exit code (1 by default) if specs
+       #   failed.
+       def run_specs(example_groups)
+-        @configuration.reporter.report(@world.example_count(example_groups)) do |reporter|
++        examples_count = @world.example_count(example_groups)
++        @configuration.reporter.report(examples_count) do |reporter|
+           @configuration.with_suite_hooks do
++            if examples_count == 0 && @configuration.fail_if_no_examples
++              return @configuration.failure_exit_code
++            end
+             example_groups.map { |g| g.run(reporter) }.all? ? 0 : @configuration.failure_exit_code
+           end
+         end","This should be `@configuration.failure_exit_code`, we don't want to hard code 1."
+4270,"@@ -359,11 +359,10 @@ Blockly.FieldVariable.prototype.onItemSelected = function(menu, menuItem) {
+ };
+
+ /**
+- * Whether this field references any Blockly variables.  If true it may need to
+- * be handled differently during serialization and deserialization.  Subclasses
+- * may override this.
+- * @return {boolean} True if this field has any variable references.
++ * Overrides referencesVariables(), indicating this field refers to a variable.
++ * @return {boolean} True.
+  * @package
++ * @override
+  */
+ Blockly.FieldVariable.prototype.referencesVariables = function() {
+   return true;",Changed per review in Blockly.
+4271,"@@ -968,12 +968,13 @@ func (c *client) bridgeAndUplinkFlows(uplinkOfport uint32, bridgeLocalPort uint3
+ 			Cookie(c.cookieAllocator.Request(category).Raw()).
+ 			Done(),
+ 		// Forward the packet to conntrackTable if it enters the OVS pipeline from the bridge interface and is sent to
+-		// local Pods.
++		// local Pods. Set the packet with MAC rewrite mark, so that the dstMAC will be re-written with real MAC in
++		// the L3Routing table, and it could be forwarded to the valid OVS interface.
+ 		c.pipeline[ClassifierTable].BuildFlow(priorityHigh).
+ 			MatchProtocol(binding.ProtocolIP).
+ 			MatchInPort(bridgeLocalPort).
+ 			MatchDstIPNet(localSubnet).
+-			Action().SetDstMAC(globalVirtualMAC).
++			Action().LoadRegRange(int(marksReg), macRewriteMark, macRewriteMarkRange).
+ 			Action().GotoTable(conntrackTable).
+ 			Cookie(c.cookieAllocator.Request(category).Raw()).
+ 			Done(),",Hi @wenyingd . so what's the original dst MAC of the reply packet from kube-proxy?
+4272,"@@ -402,6 +402,15 @@ class MisdesignChecker(BaseChecker):
+                 ""statement (see R0916)."",
+             },
+         ),
++        (
++            ""exclude-too-few-public-methods"",
++            {
++                ""default"": (),
++                ""type"": ""csv"",
++                ""metavar"": ""<comma separated list of class names>"",
++                ""help"": ""List of qualified class names to ignore when counting public methods (see R0903)"",
++            },
++        ),
+     )
+
+     def __init__(self, linter=None):","Note: I wasn't sure what the right wording would be for this, so I used existing language from elsewhere in the codebase."
+4273,"@@ -113,3 +113,13 @@ class Config(object):
+         # grab config_file default from molecule if it's not set in the user-supplied ansible options
+         if 'config_file' not in self.config['ansible']:
+             self.config['ansible']['config_file'] = self.config['molecule']['config_file']
++
++    def populate_instance_names(self, platform):
++        """"""
++        Updates instances section of config with an additional key containing the full instance name
++
++        :return: None
++        """"""
++        for instance in self.config['vagrant']['instances']:
++            instance['vm_name'] = utilities.format_instance_name(instance['name'], platform,
++                                                                 self.config['vagrant']['instances'])",Docstring for `platform`.
+4274,"@@ -85,7 +85,9 @@ func Main() {
+ 	if err != nil {
+ 		fmt.Fprintf(os.Stderr, ""%s: %v\n"", subcommand.Name, err)
+ 	}
+-
++	if err := cleanup(); err != nil {
++		fmt.Fprintf(os.Stderr, ""error restoring console to functional state: %v\n"", err)
++	}
+ 	os.Exit(exitCode)
+ }
+ ",This should be called before any `os.Exit` otherwise it could still mess up things.
+4275,"@@ -7,16 +7,16 @@ package MyGame.Example;
+  */
+ public final class Color {
+   private Color() { }
+-  public static final byte Red = 1;
++  public static final int Red = 1;
+   /**
+    * \brief color Green
+    * Green is bit_flag with value (1u << 1)
+    */
+-  public static final byte Green = 2;
++  public static final int Green = 2;
+   /**
+    * \brief color Blue (1u << 3)
+    */
+-  public static final byte Blue = 8;
++  public static final int Blue = 8;
+
+   public static final String[] names = { ""Red"", ""Green"", """", """", """", """", """", ""Blue"", };
+ ",shouldn't this be `short` ?
+4276,"@@ -63,15 +63,15 @@ func (c *CmdVolumeOptions) RunVolumesList(cmd *cobra.Command) error {
+ 	}
+
+ 	out := make([]string, len(cvols.Items)+2)
+-	out[0] = ""Namespace|Name|Status|Type""
+-	out[1] = ""---------|----|------|----""
++	out[0] = ""Namespace|Name|Status|Type|Capacity""
++	out[1] = ""---------|----|------|----|--------""
+ 	for i, items := range cvols.Items {
+ 		if len(items.Status.Reason) == 0 {
+ 			items.Status.Reason = volumeStatusOK
+ 		}
+-		out[i+2] = fmt.Sprintf(""%s|%s|%s|%s"", items.ObjectMeta.Namespace,
++		out[i+2] = fmt.Sprintf(""%s|%s|%s|%s|%s"", items.ObjectMeta.Namespace,
+ 			items.ObjectMeta.Name,
+-			items.Status.Reason, items.Spec.CasType)
++			items.Status.Reason, items.Spec.CasType, items.Spec.Capacity)
+ 	}
+ 	if len(out) == 2 {
+ 		fmt.Println(""No Volumes are running"")",Can you please paste the output of `volume list` command which will show capacity of a openebs volume.
+4277,"@@ -83,10 +83,15 @@ public class MetricRegistry implements MetricSet {
+      * @param metric the metric
+      * @param <T>    the type of the metric
+      * @return {@code metric}
+-     * @throws IllegalArgumentException if the name is already registered
++     * @throws IllegalArgumentException if the name is already registered or metric variable is null
+      */
+     @SuppressWarnings(""unchecked"")
+     public <T extends Metric> T register(String name, T metric) throws IllegalArgumentException {
++
++        if (metric == null) {
++            throw new IllegalArgumentException(""metric variable must not be null !!!"");
++        }
++
+         if (metric instanceof MetricRegistry) {
+             final MetricRegistry childRegistry = (MetricRegistry)metric;
+             final String childName = name;","I'd make this a `throw new NullPointerException(""metric == null"");` instead"
+4278,"@@ -27,6 +27,7 @@ extern ""C"" {
+ #include ""ScriptingEnvironment.h""
+ #include ""../typedefs.h""
+ #include ""../Util/OpenMPWrapper.h""
++#include ""../Util/LuaUtil.h""
+
+ ScriptingEnvironment::ScriptingEnvironment() {}
+ ScriptingEnvironment::ScriptingEnvironment(const char * fileName) {",Include should be order lexicographically.
+4279,"@@ -538,7 +538,7 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+                 final PasscodeManager passcodeManager = mgr.getPasscodeManager();
+                 passcodeManager.storeMobilePolicyForOrg(account, id.screenLockTimeout * 1000 * 60, id.pinLength);
+                 passcodeManager.setTimeoutMs(id.screenLockTimeout * 1000 * 60);
+-                passcodeManager.setMinPasscodeLength(id.pinLength);
++                boolean changeRequired = passcodeManager.setMinPasscodeLength((Activity) getContext(), id.pinLength);
+
+                 /*
+                  * Checks if a passcode already exists. If a passcode has NOT","We need to pass in the Activity context here, so that LoginActivity is used, and so that LoginActivity can get onActivityResult from the PasscodeActivity. Without this, the application context is used, and we don't get a callback when the passcode is done."
+4280,"@@ -39,4 +39,10 @@ class Tracepoint < ActiveRecord::Base
+     el1 << (XML::Node.new(""time"") << timestamp.xmlschema) if print_timestamp
+     el1
+   end
++
++  # Return points of trackable traces in original order
++  scope :trackable_ordered, -> { joins(:trace).where(:gpx_files => { :visibility => %w[trackable identifiable] }).order(""gpx_id DESC, trackid ASC, timestamp ASC"") }
++
++  # Hide the order of points of non-trackable traces for privacy
++  scope :non_trackable_unordered, -> { joins(:trace).where(:gpx_files => { :visibility => %w[public private] }).order(""gps_points.latitude"", ""gps_points.longitude"") }
+ end","Can you move these to the top please, for consistency with other models - normally we put scopes immediately after the associations at the top of the model. As to names I agree with @gravitystorm that these names may be confusing but I'm not sure the ones I suggested are perfect either so I'm not really sure what's best. The goal of my names was just to separate point which could be ordered (as `ordered`) from those which can't (as `unordered`) but I realise that may not be very clear from the names."
+4281,"@@ -1117,7 +1117,10 @@ public class PlaybackService extends MediaBrowserServiceCompat {
+                 // only mark the item as played if we're not keeping it anyways
+                 DBWriter.markItemPlayed(item, FeedItem.PLAYED, ended);
+                 // don't know if it actually matters to not autodownload when smart mark as played is triggered
+-                DBWriter.removeQueueItem(PlaybackService.this, ended, item);
++                boolean shouldRepeat = UserPreferences.getShouldRepeatEpisode();
++                if (!shouldRepeat) {
++                    DBWriter.removeQueueItem(PlaybackService.this, ended, item);
++                }
+                 // Delete episode if enabled
+                 FeedPreferences.AutoDeleteAction action =
+                         item.getFeed().getPreferences().getCurrentAutoDelete();",Looks like the episode should also not be deleted when repeating
+4282,"@@ -13,6 +13,7 @@ package proxy
+
+ import (
+ 	""crypto/tls""
++	""github.com/mholt/caddy/caddyhttp/httpserver""
+ 	""io""
+ 	""net""
+ 	""net/http""",I feel like goimports would move this import line by the other non-std packages... can you double-check that? Run goimports or set up your editor to run it on save. :+1:
+4283,"@@ -60,6 +60,19 @@ module Selenium
+
+         class << self
+           def chrome(opts = {})
++            define_method(:options) { @capabilities[:chrome_options] ||= {} }
++            define_method(""options="") { |value| @capabilities[:chrome_options] = value }
++            define_method(""profile="") do |profile|
++              profile_json = profile.as_json
++              options['args'] ||= []
++              if options['args'].none? { |arg| arg =~ /user-data-dir/ }
++                options['args'] << ""--user-data-dir=#{profile_json[:directory]}""
++              end
++              options['extensions'] = profile_json[:extensions]
++            end
++            alias_method :chrome_options, :options
++            alias_method :chrome_options=, :options=
++
+             new({
+               browser_name: 'chrome',
+               javascript_enabled: true,",`options['binary'] = WebDriver::Chrome.path` if set?
+4284,"@@ -134,6 +134,9 @@ var (
+ 		DB: DB{
+ 			UseBadgerDB: false,
+ 			NumRetries:  3,
++			SQLITE3: SQLITE3{
++				SQLite3File:	""./explorer.db"",
++			},
+ 		},
+ 	}
+ ",File is not `goimports`-ed (from `goimports`)
+4285,"@@ -19,13 +19,18 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     /// </summary>
+     public class ListenOptions : IEndPointInformation, IConnectionBuilder
+     {
++        internal const string Http2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experimental.Http2"";
++
+         private FileHandleType _handleType;
++        private HttpProtocols _protocols = HttpProtocols.Http1;
++        internal bool _isHttp2Supported;
+         private readonly List<Func<ConnectionDelegate, ConnectionDelegate>> _components = new List<Func<ConnectionDelegate, ConnectionDelegate>>();
+
+         internal ListenOptions(IPEndPoint endPoint)
+         {
+             Type = ListenType.IPEndPoint;
+             IPEndPoint = endPoint;
++            AppContext.TryGetSwitch(Http2ExperimentSwitch, out _isHttp2Supported);
+         }
+
+         internal ListenOptions(string socketPath)",Nit: Supported -> Enabled.
+4286,"@@ -128,7 +128,7 @@ class ImportTest(QuiltTestCase):
+
+         # Modify an existing dataframe
+         csv = package1.dataframes2.csv._data()
+-        csv.set_value(0, 'Int0', 42)
++        csv.at[0, 'Int0'] = 42
+
+         # Add a new dataframe
+         df = pd.DataFrame(dict(a=[1, 2, 3]))",Yay! I was too lazy to fix this.
+4287,"@@ -28,8 +28,7 @@ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/versioned""
+ 	""github.com/openebs/maya/pkg/debug""
+-	merrors ""github.com/openebs/maya/pkg/errors/v1alpha1""
+-	pkg_errors ""github.com/pkg/errors""
++	errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""",other declaration of errors (from `typecheck`)
+4288,"@@ -13,12 +13,15 @@ import (
+ )
+
+ var (
+-	errValueEmpty      = errors.New(""value must not be empty"")
+-	errValueTooLong    = errors.New(""value must not exceed 255 characters"")
+-	errValueBadFormat  = errors.New(""value must start with a letter and contain only lower-case letters, numbers, and hyphens"")
+-	errValueNotAString = errors.New(""value must be a string"")
++	errValueEmpty        = errors.New(""value must not be empty"")
++	errValueTooLong      = errors.New(""value must not exceed 255 characters"")
++	errValueBadFormat    = errors.New(""value must start with a letter and contain only lower-case letters, numbers, and hyphens"")
++	errValueNotAString   = errors.New(""value must be a string"")
++	errInvalidGitHubRepo = errors.New(""Please enter a valid GitHub repository, e.g. https://github.com/myCompany/myRepo"")
+ )
+
++var githubRepoExp = regexp.MustCompile(`https:\/\/github\.com\/(?P<owner>.+)\/(?P<repo>.+)`)
++
+ func validateProjectName(val interface{}) error {
+ 	if err := basicNameValidation(val); err != nil {
+ 		return fmt.Errorf(""project name %v is invalid: %w"", val, err)",nit: error starts with capital letter
+4289,"@@ -1616,16 +1616,7 @@ public class ImapStore extends Store {
+                 ImapList flags = fetchList.getKeyedList(""FLAGS"");
+                 if (flags != null) {
+                     for (int i = 0, count = flags.size(); i < count; i++) {
+-                        String flag = flags.getString(i);
+-                        if (flag.equalsIgnoreCase(""\\Deleted"")) {
+-                            message.setFlagInternal(Flag.DELETED, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Answered"")) {
+-                            message.setFlagInternal(Flag.ANSWERED, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Seen"")) {
+-                            message.setFlagInternal(Flag.SEEN, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Flagged"")) {
+-                            message.setFlagInternal(Flag.FLAGGED, true);
+-                        }
++                        message.setFlagInternal(Flag.valueOfByRealName(flags.getString(i)), true);
+                     }
+                 }
+             }","the original code ignores \Draft and \Recent, whereas your change will not. what this matters, i'm not sure."
+4290,"@@ -381,6 +381,8 @@ func TestQuotaReclamationDeletedBlocks(t *testing.T) {
+ 	}
+
+ 	// Stall the puts that comes as part of the sync call.
++	oldBServer := config2.BlockServer()
++	defer config2.SetBlockServer(oldBServer)
+ 	onWriteStalledCh, writeUnstallCh, ctxStall := StallBlockOp(
+ 		ctx, config2, StallableBlockPut)
+ ",Why was this necessary?
+4291,"@@ -111,6 +111,7 @@ var opts struct {
+ 	Test struct {
+ 		FailingTestsOk  bool         `long:""failing_tests_ok"" hidden:""true"" description:""Exit with status 0 even if tests fail (nonzero only if catastrophe happens)""`
+ 		NumRuns         int          `long:""num_runs"" short:""n"" default:""1"" description:""Number of times to run each test target.""`
++		Rerun           bool         `long:""rerun"" description:""To force rerunning tests for a target""`
+ 		Sequentially    bool         `long:""sequentially"" description:""Whether to run multiple runs of the same test sequentially""`
+ 		TestResultsFile cli.Filepath `long:""test_results_file"" default:""plz-out/log/test_results.xml"" description:""File to write combined test results to.""`
+ 		SurefireDir     cli.Filepath `long:""surefire_dir"" default:""plz-out/surefire-reports"" description:""Directory to copy XML test results to.""`",Can you also do this for Cover?
+4292,"@@ -4978,6 +4978,16 @@ bool CoreChecks::ValidateImageSubresourceRange(const uint32_t image_mip_count, c
+         }
+     }
+
++    if (subresourceRange.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
++        if (subresourceRange.aspectMask &
++            (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT)) {
++            skip |= LogError(image, ""VUID-VkImageSubresourceRange-aspectMask-01670"",
++                             ""%s: aspectMask includes both VK_IMAGE_ASPECT_COLOR_BIT and one of VK_IMAGE_ASPECT_PLANE_0_BIT, ""
++                             ""VK_IMAGE_ASPECT_PLANE_1_BIT, or VK_IMAGE_ASPECT_PLANE_2_BIT."",
++                             cmd_name);
++        }
++    }
++
+     return skip;
+ }
+ ","So I tried adding this VU a long time ago, thought it would be this simple of a check, but turns out there were other validation in the way for getting here in `ValidateImageAspectMask` I assume that is what is failing CI here, realized it would require some more refactoring"
+4293,"@@ -0,0 +1,6 @@
++class Arel::Table
++  def coalesce_and_sum(column, value)
++    coalesce_result = Arel::Nodes::NamedFunction.new('COALESCE', [self[column], value])
++    Arel::Nodes::NamedFunction.new('SUM', [coalesce_result], column.to_s)
++  end
++end","This method is not needed for postgresql, by default sum function omits null values so we can remove this file"
+4294,"@@ -378,7 +378,10 @@ dnl We have separate checks for libsystemd and the unit dir for historical reaso
+ PKG_CHECK_MODULES([LIBSYSTEMD], [libsystemd], [have_libsystemd=yes], [have_libsystemd=no])
+ AM_CONDITIONAL(BUILDOPT_LIBSYSTEMD, test x$have_libsystemd = xyes)
+ AM_COND_IF(BUILDOPT_LIBSYSTEMD,
+-           AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd]))
++           AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd])
++           systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)
++           AC_SUBST(systemdsystemgeneratordir)
++           )
+
+ AS_IF([test ""x$have_libsystemd"" = ""xyes""], [
+   with_systemd=yes",Can you provide a `--with-systemdsystemgeneratordir` option here? So that I can do unprivileged installs without completely turning off systemd. I can add it as a follow-up PR too.
+4295,"@@ -396,11 +396,10 @@ class CLAModel(Model):
+       inferences = self._multiStepCompute(rawInput=inputRecord)
+     # For temporal classification. Not used, and might not work anymore
+     elif self._isClassificationModel():
+-      inferences = self._classificationCompute()
+-
+-    results.inferences.update(inferences)
+-
+-    inferences = self._anomalyCompute()
++      inferences = self._classifcationCompute()
++    else:
++      inferences = self._anomalyCompute()
++
+     results.inferences.update(inferences)
+
+     # -----------------------------------------------------------------------",`classification` is misspelled
+4296,"@@ -152,7 +152,7 @@ public class SampleTransformer {
+     // to
+     // use is the first one on the list, since we set it in the overload of generateSamples.
+     if (methodSampleViews.size() > 0) {
+-      methodViewBuilder.initCode(methodSampleViews.get(0).initCode());
++      methodViewBuilder.initCode(methodSampleViews.get(0).methodInitCode());
+
+       // Don't emit samples that were specifically generated for backward-compatibility. We only
+       // wanted them for initCode above.",Can you change this to `sampleInitCode`?
+4297,"@@ -823,6 +823,7 @@ public class TiDAGRequest implements Serializable {
+       sb.append("", Limit: "");
+       sb.append(""["").append(limit).append(""]"");
+     }
++    sb.append("", startTs: "").append(startTs.getVersion());
+     return sb.toString();
+   }
+ ",I added a startTs information in `TiDagRequest` output. Not really sure if it is useful? @zhexuany
+4298,"@@ -27,7 +27,12 @@ function collectResultsFromFrames(
+   frames.forEach(frame => {
+     const tabindex = parseInt(frame.node.getAttribute('tabindex'), 10);
+     const focusable = isNaN(tabindex) || tabindex >= 0;
++
+     const rect = frame.node.getBoundingClientRect();
++    let width = parseInt(frame.node.getAttribute('width'), 10);
++    let height = parseInt(frame.node.getAttribute('height'), 10);
++    width = isNaN(width) ? rect.width : width;
++    height = isNaN(height) ? rect.height : height;
+
+     var params = {
+       options: options,",This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5).
+4299,"@@ -22,10 +22,11 @@ class PublicPagesController < ApplicationController
+     @template = Template.live(params[:id])
+     # covers authorization for this action.
+     # Pundit dosent support passing objects into scoped policies
++    skip_authorization
+     unless PublicPagePolicy.new(@template).template_export?
+-      raise Pundit::NotAuthorizedError
++      redirect_to public_templates_path, notice: ""You are not authorized to export that template"" and return
++      #raise Pundit::NotAuthorizedError
+     end
+-    skip_authorization
+     # now with prefetching (if guidance is added, prefetch annottaions/guidance)
+     @template = Template.includes(
+       :org,",prefer to just add this to the `verify_authorized` exception list above since we're already making exceptions.
+4300,"@@ -139,10 +139,17 @@ class Populator
+
+         $dependent_classlikes[$fq_classlike_name_lc] = true;
+
+-        $this->populateDataFromTraits($storage, $storage_provider, $dependent_classlikes);
++        foreach ($storage->used_traits as $used_trait_lc => $_) {
++            $this->populateDataFromTrait($storage, $storage_provider, $dependent_classlikes, $used_trait_lc);
++        }
+
+         if ($storage->parent_classes) {
+-            $this->populateDataFromParentClass($storage, $storage_provider, $dependent_classlikes);
++            $this->populateDataFromParentClass(
++                $storage,
++                $storage_provider,
++                $dependent_classlikes,
++                reset($storage->parent_classes)
++            );
+         }
+
+         if (!strpos($fq_classlike_name_lc, '\\')",was there a reason to not loop over parent classes here?
+4301,"@@ -1,6 +1,8 @@
+-import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
+ import Ember from 'ember';
++import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
+ import UserSession from 'hospitalrun/mixins/user-session';
++
++const { computed } = Ember;
+ /**
+  * Abstract route for top level modules (eg patients, inventory, users)
+  */",@billybonks Why move `import Ember from 'ember';` to the top?
+4302,"@@ -1,7 +1,16 @@
+ class Approval < ActiveRecord::Base
+-  include ThreeStateWorkflow
+-
+-  workflow_column :status
++  include WorkflowModel
++  workflow do
++    state :pending do
++      event :make_actionable, transitions_to: :actionable
++    end
++    state :actionable do
++      event :approve, transitions_to: :approved
++      event :reject, transitions_to: :rejected
++    end
++    state :approved
++    state :rejected
++  end
+
+   belongs_to :proposal
+   has_one :cart, through: :proposal",Everything's so simple (a `ThreeStateWorkflow`) until it isn't :smirk:
+4303,"@@ -57,8 +57,9 @@ class OperationTests(ComparisonTestCase):
+     def test_image_contours(self):
+         img = Image(np.array([[0, 1, 0], [3, 4, 5.], [6, 7, 8]]))
+         op_contours = contours(img, levels=[0.5])
+-        contour = Contours([[(-0.5,  0.416667, 0.5), (-0.25, 0.5, 0.5)],
+-                             [(0.25, 0.5, 0.5), (0.5, 0.45, 0.5)]],
++        contour = Contours([[(-0.5,  0.416667, 0.5), (-0.25, 0.5, 0.5),
++                             (np.NaN, np.NaN, 0.5), (0.25, 0.5, 0.5),
++                             (0.5, 0.45, 0.5)]],
+                             vdims=img.vdims)
+         self.assertEqual(op_contours, contour)
+ ",I don't quite understand where the NaNs come from...
+4304,"@@ -45,8 +45,8 @@ func LoadTestConfig(addr string, allowMultiConnsPerHost bool) *config.Network {
+ 	config := config.Config{
+ 		NodeType: config.DelegateType,
+ 		Network: config.Network{
+-			Host:                    host,
+-			Port:                    port,
++			Host: host,
++			Port: port,
+ 			MsgLogsCleaningInterval: 2 * time.Second,
+ 			MsgLogRetention:         10 * time.Second,
+ 			HealthCheckInterval:     time.Second,",File is not `goimports`-ed
+4305,"@@ -354,6 +354,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Go.PleaseGoTool = ""//_please:please_go""
+ 	config.Go.EmbedTool = ""//_please:please_go_embed""
+ 	config.Python.PexTool = ""//_please:please_pex""
++	config.Python.WheelResolverTool = ""//_please:wheel_resolver""
+ 	config.Java.JavacWorker = ""//_please:javac_worker""
+ 	config.Java.JarCatTool = ""//_please:jarcat""
+ 	config.Java.JUnitRunner = ""//_please:junit_runner""",I wonder if we should look at moving the Python stuff to a plugin and doing this there rather than adding to core plz at this point?
+4306,"@@ -44,8 +44,7 @@ class Syntax(base.BaseCommand):
+         ansible = ansible_playbook.AnsiblePlaybook(self.molecule.config.config[
+             'ansible'])
+         ansible.add_cli_arg('syntax-check', True)
+-        ansible.add_cli_arg('inventory-file', 'localhost,')
+-
++        ansible.add_cli_arg('inventory_file', 'localhost,')
+         utilities.print_info(""Checking playbooks syntax ..."")
+
+         return ansible.execute(hide_errors=True)",This is the actual bug fix. I prob should have broken this out into two PRs.
+4307,"@@ -235,6 +235,16 @@ namespace Nethermind.Core.Specs
+         /// </summary>
+         bool IsEip3198Enabled { get; }
+
++        /// <summary>
++        /// Difficulty Bomb Delay to Q2/2022
++        /// </summary>
++        bool IsEip3238Enabled { get; }
++
++        /// <summary>
++        /// Reduction in refunds
++        /// </summary>
++        bool IsEip3529Enabled { get; }
++
+         /// <summary>
+         /// Should transactions be validated against chainId.
+         /// </summary>","I am not sure if we need this, we already have DifficultyBombDelays"
+4308,"@@ -389,6 +389,9 @@ namespace Nethermind.Blockchain.Synchronization
+                             }
+                         }
+                     }
++
++                    delaySource.Dispose();
++                    linkedSource.Dispose();
+                 }, token);
+         }
+ ","move to finally - I can see at least one return that would omit it, also any exception and so on"
+4309,"@@ -122,7 +122,9 @@ func NewProtocol(
+ 	if cfg.Consensus.Scheme != config.RollDPoSScheme {
+ 		return nil, nil
+ 	}
+-	if !genesisConfig.EnableGravityChainVoting || electionCommittee == nil || genesisConfig.GravityChainStartHeight == 0 {
++
++	if !genesisConfig.EnableGravityChainVoting || genesisConfig.GravityChainStartHeight == 0 ||
++		(electionCommittee == nil && stakingV2 == nil) {
+ 		delegates := genesisConfig.Delegates
+ 		if uint64(len(delegates)) < genesisConfig.NumDelegates {
+ 			return nil, errors.New(""invalid delegate address in genesis block"")",remove `genesisConfig.GravityChainStartHeight == 0`
+4310,"@@ -4,6 +4,10 @@ declare(strict_types=1);
+
+ use Doctrine\Common\Annotations\AnnotationRegistry;
+
++$symfonyDumpFunctionPath = 'vendor/symfony/var-dumper/Resources/functions/dump.php';
++
++file_exists(__DIR__ . '/../' . $symfonyDumpFunctionPath) ? require_once __DIR__ . '/../' . $symfonyDumpFunctionPath : require_once __DIR__ . '/../../' . $symfonyDumpFunctionPath;
++
+ /* @var \Composer\Autoload\ClassLoader $loader */
+ $loader = file_exists(__DIR__ . '/../vendor/autoload.php') ? require __DIR__ . '/../vendor/autoload.php' : require __DIR__ . '/../../vendor/autoload.php';
+ ",this might kill whole application if `var-dumper` will not be installed. What about two separate file_exists conditions (monorepo/project)?
+4311,"@@ -163,6 +163,11 @@ var ConfigCommand *cobra.Command = &cobra.Command{
+ 			util.Failed(""Could not write ddev config file: %v"", err)
+ 		}
+
++		_, err = app.CreateSettingsFile()
++		if err != nil {
++			util.Failed(""Could not write settings file: %w"", err)
++		}
++
+ 		// If a provider is specified, prompt about whether to do an import after config.
+ 		switch provider {
+ 		case ddevapp.DefaultProviderName:",Hrm. Maybe this isn't the correct spot to run this? Because it errors if the app type doesn't support settings. But we want to check that before running it.
+4312,"@@ -1359,7 +1359,7 @@ def get_terminal_width():
+         else:
+             return None
+
+-def pretty_routes(rtlst, header, sortBy=0):
++def pretty_list(rtlst, header, sortBy=0):
+     """"""Pretty route list, and add header""""""
+     _l_header = len(header[0])
+     _space = ""  """,Why are you changing this name ?
+4313,"@@ -579,6 +579,12 @@ def in_docker():
+     """"""
+     if OVERRIDE_IN_DOCKER:
+         return True
++
++    # check things from Dockerfile
++    # TODO: is it enough? can we remove all the checks bellow?
++    if __file__.startswith(""/opt/code/localstack/"") and os.environ.get(""USER"") == ""localstack"":
++        return True
++
+     if os.path.exists(""/.dockerenv""):
+         return True
+     if not os.path.exists(""/proc/1/cgroup""):","as we discussed, maybe it would be better to - [ ] set OVERRIDE_IN_DOCKER=1 in the Dockerfile - [ ] replace the if statement with `os.path.exists(""/run/.containerenv"")` as @dfangl suggested"
+4314,"@@ -455,6 +455,11 @@ def is_ancestor_name(
+     return False
+
+
++def is_being_called(node: astroid.node_classes.NodeNG) -> bool:
++    """"""return True if node is the function being called in a Call node""""""
++    return isinstance(node.parent, astroid.Call) and node.parent.func is node
++
++
+ def assign_parent(node: astroid.node_classes.NodeNG) -> astroid.node_classes.NodeNG:
+     """"""return the higher parent which is not an AssignName, Tuple or List node""""""
+     while node and isinstance(node, (astroid.AssignName, astroid.Tuple, astroid.List)):",I like this style of doing things better than having super big conditional without explanation. Even though I know this won't be re-used it's nice to have a function if only for clarity.
+4315,"@@ -22,7 +22,10 @@ module RSpec
+         end
+
+         def example_group_finished(_notification)
+-          @group_level -= 1
++          if @group_level > 0
++            @group_level -= 1
++          end
++          @group_level
+         end
+
+         def example_passed(passed)",Our preference here is to either have inline statements e.g. `@group_level -= 1 if @group_level > 0` but stylistically here I think `return @group_level if @group_level == 0` might be nicer. As it stands however our rubocop is picking this up as a fail :(
+4316,"@@ -20,6 +20,16 @@
+ package org.apache.iceberg.spark.actions;
+
+ import org.apache.iceberg.actions.TestRemoveOrphanFilesAction;
++import org.junit.Ignore;
+
+ public class TestRemoveOrphanFilesAction3 extends TestRemoveOrphanFilesAction {
++
++  /**
++  * Todo: Its failing for Spark3, so has to fix it in the parent class.
++  * Ignoring for now, as still Spark3 is not supported.
++  *
++  */
++  @Ignore
++  public void testOlderThanTimestampWithPartitionWithWhitSpace() {
++  }
+ }","Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why"
+4317,"@@ -399,3 +399,11 @@ def get_partition_set_execution_param_data(recon_repo, partition_set_name, parti
+         return ExternalPartitionExecutionErrorData(
+             serializable_error_info_from_exc_info(sys.exc_info())
+         )
++
++
++def get_notebook_data(notebook_path):
++    check.str_param(notebook_path, ""notebook_path"")
++
++    with open(os.path.abspath(notebook_path), ""rb"") as f:
++        content = f.read()
++        return content","something about the arbitrary file access part here makes me nervous. Can we keep the `if not path.endswith("".ipynb"")` check from before here as well? Just imagining a weird attack scenario where somebody somehow uses this to get access to confidental files or something"
+4318,"@@ -51,6 +51,14 @@ module Blacklight
+       deprecation_deprecate :solr_search_params_logic=
+     end
+
++    def search_builder_class
++      Blacklight::Solr::SearchBuilder
++    end
++
++    def search_builder processor_chain = search_params_logic
++      search_builder_class.new(processor_chain, self)
++    end
++
+
+     # @returns a params hash for searching solr.
+     # The CatalogController #index action uses this.",I wonder if we should push this and the search_params_logic into the blacklight config.
+4319,"@@ -38,6 +38,7 @@ func TestClient(t *testing.T) {
+ 	cfg := config.Default
+ 	cfg.API.Port = testutil.RandomPort()
+ 	ctx := context.Background()
++	cfg.Genesis.KamchatkaBlockHeight = 10
+
+ 	mockCtrl := gomock.NewController(t)
+ 	defer mockCtrl.Finish()","don't need this line, since it is not tested here?"
+4320,"@@ -197,6 +197,7 @@ class EmrConnection(AWSQueryConnection):
+                     steps=[],
+                     bootstrap_actions=[],
+                     instance_groups=None,
++                    ami_version=""1.0"",
+                     additional_info=None):
+         """"""
+         Runs a job flow",I wonder if adding this new param in the middle of the param list might screw up some existing code that is depending on the old parameter order. Might be better to add it to the end of the parameter list?
+4321,"@@ -178,7 +178,8 @@ public final class BaselineErrorProne implements Plugin<Project> {
+
+         errorProneOptions.setEnabled(true);
+         errorProneOptions.setDisableWarningsInGeneratedCode(true);
+-        errorProneOptions.setExcludedPaths(project.getBuildDir().getAbsolutePath() + ""/.*"");
++        errorProneOptions.setExcludedPaths(
++                String.format(""%s/(build|src/generated.*)/.*"", project.getProjectDir().getAbsolutePath()));
+         errorProneOptions.check(""EqualsHashCode"", CheckSeverity.ERROR);
+         errorProneOptions.check(""EqualsIncompatibleType"", CheckSeverity.ERROR);
+         errorProneOptions.check(""StreamResourceLeak"", CheckSeverity.ERROR);",I wonder if this absolute path is gonna affect the build-cache relocatability of these compile tasks??
+4322,"@@ -18,10 +18,13 @@ class CommandOperationV2 extends OperationBase {
+     this.readPreference = ReadPreference.resolve(parent, this.options);
+     this.readConcern = resolveReadConcern(parent, this.options);
+     this.writeConcern = resolveWriteConcern(parent, this.options);
++    this.session = options && options.session;
++    this.inTransaction = this.session && this.session.inTransaction();
++    if (this.inTransaction) this.writeConcern = undefined;
+     this.explain = false;
+
+     if (operationOptions && typeof operationOptions.fullResponse === 'boolean') {
+-      this.fullResponse = true;
++      this.fullResponse = operationOptions.fullResponse;
+     }
+
+     // TODO: A lot of our code depends on having the read preference in the options. This should",possible bug if `fullResponse` is false
+4323,"@@ -19,9 +19,11 @@
+
+ """"""A HintManager to draw hints over links.""""""
+
+-import math
+-import functools
+ import collections
++import functools
++import math
++import re
++from string import ascii_lowercase
+
+ from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QEvent, Qt, QUrl,
+                           QTimer)",nitpick: Please only `import string` here and use `string.ascii_lowercase` - I really like to see what module stuff is coming from without looking at the imports.
+4324,"@@ -2822,10 +2822,10 @@ exports.shouldCorrectlyLogoutFromTheDatabaseWithPromises = {
+
+               db.close();
+               test.done();
+-            }).catch(function(err) {  })
+-          }).catch(function(err) {  })
+-        }).catch(function(err) {  })
+-      }).catch(function(err) {  })
++            }).catch(function(err) {  console.dir(err )})
++          }).catch(function(err) {  console.dir(err )})
++        }).catch(function(err) {  console.dir(err )})
++      }).catch(function(err) {  console.dir(err )})
+     });
+     // END
+   }",nitpick: the only reason we have a catch for every one of these promises is because the test isn't properly chaining promises (returning them within each `then`). We could reduce the `catch` with `console.dir` to a single instance if that was done
+4325,"@@ -85,6 +85,8 @@ TEST(NebulaCodec, encode) {
+     // check empty values
+     std::vector<boost::any> emptyV;
+     std::string emptyEncoded = codec.encode(emptyV);
++
++
+     SchemaWriter emptyWriter;
+     auto emptySchema = std::make_shared<ResultSchemaProvider>(emptyWriter.moveSchema());
+     auto emptyReader = RowReader::getRowReader(emptyEncoded, emptySchema);",why do this?
+4326,"@@ -17,7 +17,7 @@ class MediaLibrary extends SystemMediaLibrary
+      */
+     protected function init()
+     {
+-        traceLog('Class Cms\Classes\MediaLibrary has been deprecated, use System\Classes\MediaLibrary instead.');
++        traceLog('Class Cms\Classes\MediaLibrary has been deprecated, use ' . SystemMediaLibrary::class . ' instead.');
+         parent::init();
+     }
+ }","For consistency, would it not be best to also replace the first class name? `traceLog('Class ' . static::class . ' has been deprecated, use ' . SystemMediaLibrary::class . ' instead.')`"
+4327,"@@ -123,6 +123,9 @@ type PrometheusSpec struct {
+ 	// The labels to add to any time series or alerts when communicating with
+ 	// external systems (federation, remote storage, Alertmanager).
+ 	ExternalLabels map[string]string `json:""externalLabels,omitempty""`
++	// Enable access to prometheus web admin API. Defaults to the value of `true`.
++	// For more information see https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
++	EnableAdminApi string `json:""enableAdminApi,omitempty""`
+ 	// The external URL the Prometheus instances will be available under. This is
+ 	// necessary to generate correct URLs. This is necessary if Prometheus is not
+ 	// served from root of a DNS name.",this should be `EnabledAdminAPI` and the json string should then be `enableAdminAPI`
+4328,"@@ -4,6 +4,8 @@ from listenbrainz import webserver
+ from werkzeug.serving import run_simple
+ import os
+ import click
++import sqlalchemy
++from time import sleep
+
+ from listenbrainz.utils import safely_import_config
+ safely_import_config()",Noticed some missing imports in manage.py so thought I'd add them
+4329,"@@ -301,15 +301,10 @@ func (exp *flowExporter) sendFlowRecords() error {
+ 			exp.numDataSetsSent = exp.numDataSetsSent + 1
+
+ 			if flowexporter.IsConnectionDying(&record.Conn) {
+-				// If the connection is in dying state or connection is not in conntrack table,
+-				// we will delete the flow records from records map.
+-				klog.V(2).Infof(""Deleting the inactive flow records with key: %v from record map"", key)
+-				if err := exp.flowRecords.DeleteFlowRecordWithoutLock(key); err != nil {
+-					return err
+-				}
+-				if err := exp.conntrackConnStore.SetExportDone(key); err != nil {
+-					return err
+-				}
++				// If the connection is in dying state or connection is not in conntrack
++				// table, we set the DyingAndDoneExport flag to do the deletion later.
++				record.DyingAndDoneExport = true
++				exp.flowRecords.AddFlowRecordWithoutLock(&key, &record)
+ 			} else {
+ 				exp.flowRecords.ValidateAndUpdateStats(key, record)
+ 			}","as a future improvement, maybe we should just change `ForAllFlowRecordsDo` so that `updateOrSendFlowRecord` uses a flow record pointer instead of a copy of stored flow record. This whole code is executed with the lock any way."
+4330,"@@ -37,6 +37,7 @@ import java.util.function.Consumer;
+  * A literal string.
+  * <br/><code>""Hello World!""</code>
+  * <br/><code>""\""\n""</code>
++ * <br/><code>""\u2122""</code>
+  * <br/><code>""™""</code>
+  * <br/><code>""💩""</code>
+  *",I am not sure what GitHub wants to tell me with this icon here :)
+4331,"@@ -385,8 +385,8 @@ BOOST_AUTO_TEST_CASE(valid_nearest_urls)
+
+ BOOST_AUTO_TEST_CASE(valid_tile_urls)
+ {
+-    TileParameters reference_1{1, 2, 3};
+-    auto result_1 = parseParameters<TileParameters>(""tile(1,2,3).mvt"");
++    TileParameters reference_1{1, 2, 12};
++    auto result_1 = parseParameters<TileParameters>(""tile(1,2,12).mvt"");
+     BOOST_CHECK(result_1);
+     BOOST_CHECK_EQUAL(reference_1.x, result_1->x);
+     BOOST_CHECK_EQUAL(reference_1.y, result_1->y);",can we also check for smaller zoom levels returning valid error codes?
+4332,"@@ -15,6 +15,16 @@ namespace ScenarioMeasurement
+             Console.WriteLine(message);
+         }
+
++        public void LogHeader1(string message)
++        {
++            Console.WriteLine($""=============== {message} ================ "");
++        }
++
++        public void LogHeader2(string message)
++        {
++            Console.WriteLine($""***{message}***"");
++        }
++
+         public void LogVerbose(string message)
+         {
+             Console.WriteLine(message);","1) These names are not great, doesn't help explain what they do. 2) Instead of methods like this that hard code some number of = and *, why not a method that takes the string, defaults to a char to surround with, and a width? 3) Do we really even need headers like this in the output? Maybe we ditch them."
+4333,"@@ -2943,7 +2943,7 @@ describe('AutocompleteEditor', () => {
+
+       keyDownUp('arrow_up');
+
+-      expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[0, 0, 0, 0]]);
++      expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[11, 0, 11, 0]]);
+       done();
+     }, 200);
+   });","The autocomplete editor shouldn't change its own behavior, I assume that `autoWrapCol` and `autoWrapRow` options should be set to `false` in handsontable editor."
+4334,"@@ -266,7 +266,7 @@ func testInstallTunnelFlows(t *testing.T, config *testConfig) {
+ }
+
+ func testInstallServiceFlows(t *testing.T, config *testConfig) {
+-	err := c.InstallClusterServiceFlows()
++	err := c.InstallClusterServiceFlows(true, true)
+ 	if err != nil {
+ 		t.Fatalf(""Failed to install Openflow entries to skip service CIDR from egress table: %v"", err)
+ 	}","out of curiosity, with IPv6 introduced, why there's no change to the expected output of openflow in the test?"
+4335,"@@ -67,7 +67,10 @@ byte *
+ decode_eflags_usage(dcontext_t *dcontext, byte *pc, uint *usage,
+                     dr_opnd_query_flags_t flags)
+ {
+-    *usage = 0; /* FIXME i#1569 */
++    /* As long as precise flag information is not provided we conservatively
++     * assume each instructions may read or write all flags.
++    */
++    *usage = EFLAGS_WRITE_ALL | EFLAGS_READ_ALL; /* FIXME i#2263 */
+     return pc + 4;
+ }
+ ",nit: grammar: instruction
+4336,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.
+4337,"@@ -69,7 +69,12 @@ func Add(mgr manager.Manager) error {
+
+ // newReconciler returns a new reconcile.Reconciler
+ func newReconciler(mgr manager.Manager) reconcile.Reconciler {
+-	return &ReconcileHiveConfig{Client: mgr.GetClient(), scheme: mgr.GetScheme(), restConfig: mgr.GetConfig(), mgr: mgr}
++	return &ReconcileHiveConfig{
++		Client:     mgr.GetClient(),
++		scheme:     mgr.GetScheme(),
++		restConfig: mgr.GetConfig(),
++		mgr:        mgr,
++	}
+ }
+
+ // add adds a new Controller to mgr with r as the reconcile.Reconciler",i think this missed the reconciler to callsite change
+4338,"@@ -990,6 +990,10 @@ public class SurfaceNamer extends NameFormatterDelegator {
+     return getNotImplementedString(""SurfaceNamer.getGrpcClientImportName"");
+   }
+
++  public String getClientConfigImportModule(Interface service) {
++    return getNotImplementedString(""SurfaceNamer.getClientConfigImportModule"");
++  }
++
+   /////////////////////////////////// Docs & Annotations //////////////////////////////////////////
+
+   /** The documentation name of a parameter for the given lower-case field name. */",Please reuse `getClientConfigPath`.
+4339,"@@ -19,7 +19,7 @@ const { eachAsyncSeries, ns } = require('../../../src/utils');
+
+ const chai = require('chai');
+ chai.use(require('chai-subset'));
+-chai.use(require('../../functional/spec-runner/matcher').default);
++chai.use(require('../../tools/spec-runner/matcher').default);
+
+ const expect = chai.expect;
+ ","Should we use the shared chai-addon.js file here? Actually we should consolidate any `chai.use` calls, I see 20 instances, quick win?"
+4340,"@@ -109,7 +109,7 @@ namespace Nethermind.Network.P2P.ProtocolHandlers
+                     HandleHello(Deserialize<HelloMessage>(msg.Data));
+
+                     foreach (Capability capability in
+-                        _agreedCapabilities.GroupBy(c => c.ProtocolCode).Select(c => c.OrderBy(v => v.Version).Last()))
++                        _agreedCapabilities.GroupBy(c => c.ProtocolCode).Select(c => c.OrderBy(v => v.Version).Last()).OrderBy(c => c.ProtocolCode))
+                     {
+                         if (Logger.IsTrace) Logger.Trace($""{Session} Starting protocolHandler for {capability.ProtocolCode} v{capability.Version} on {Session.RemotePort}"");
+                         SubprotocolRequested?.Invoke(this, new ProtocolEventArgs(capability.ProtocolCode, capability.Version));",Maybe move _agreedCapabilities and _availableCapabilities from List to SortedSet ? We could order them by code and then by version already.
+4341,"@@ -3031,11 +3031,9 @@ func (o *consumer) setInitialPendingAndStart() {
+ 		// Here we are filtered.
+ 		dp := o.cfg.DeliverPolicy
+ 		if dp == DeliverLastPerSubject && o.hasSkipListPending() && o.sseq < o.lss.resume {
+-			if o.lss != nil {
+-				ss := mset.store.FilteredState(o.lss.resume, o.cfg.FilterSubject)
+-				o.sseq = o.lss.seqs[0]
+-				o.sgap = ss.Msgs + uint64(len(o.lss.seqs))
+-			}
++			ss := mset.store.FilteredState(o.lss.resume+1, o.cfg.FilterSubject)
++			o.sseq = o.lss.seqs[0]
++			o.sgap = ss.Msgs + uint64(len(o.lss.seqs))
+ 		} else if ss := mset.store.FilteredState(o.sseq, o.cfg.FilterSubject); ss.Msgs > 0 {
+ 			o.sgap = ss.Msgs
+ 			// See if we should update our starting sequence.","I see the `+1` issue, but we used to check if `o.lss != nil` and we don't anymore, so we are sure that it won't be nil here, right?"
+4342,"@@ -8,6 +8,11 @@
+   <% @documents&.each do |document| %>
+     <h1 class=""modal-title""><%= document_heading(document) %></h1>
+
++    <% if document.respond_to?(:export_as_preferred_citation_txt) %>
++      <h2><%= t('blacklight.citation.preferred') %></h2>
++      <%= document.send(:export_as_preferred_citation_txt).html_safe %><br/><br/>
++    <% end %>
++
+     <% if document.respond_to?(:export_as_mla_citation_txt) %>
+       <h2><%= t('blacklight.citation.mla') %></h2>
+       <%= document.send(:export_as_mla_citation_txt).html_safe %><br/><br/>",why is the `send` needed?
+4343,"@@ -106,8 +106,9 @@ def bbox2result(bboxes, labels, num_classes):
+     if bboxes.shape[0] == 0:
+         return [np.zeros((0, 5), dtype=np.float32) for i in range(num_classes)]
+     else:
+-        bboxes = bboxes.cpu().numpy()
+-        labels = labels.cpu().numpy()
++        if isinstance(bboxes, torch.Tensor):
++            bboxes = bboxes.cpu().numpy()
++            labels = labels.cpu().numpy()
+         return [bboxes[labels == i, :] for i in range(num_classes)]
+
+ ","Is this necessary? If so, we need to update the docstring."
+4344,"@@ -116,8 +116,8 @@ module Ncr
+
+     # the highest approver on the stack, pending preferred if status indicates
+     def current_approver_email_address
+-      if self.individual_approvals.pending.first
+-        self.individual_approvals.pending.first.user.email_address
++      if self.pending?
++        self.individual_approvals.where(status: 'actionable').first.user.email_address
+       else
+         self.approving_official.email_address
+       end",Checking for actionable here instead of grabbing the first pending approval. I tested this with proposal ID 265 on staging.
+4345,"@@ -100,7 +100,10 @@ class CallbackChecker(QObject):
+         if self._result is self.UNSET:
+             with self._qtbot.waitSignal(self.got_result, timeout=2000):
+                 pass
+-        assert self._result == expected
++        self._assert_result(self._result, expected)
++
++    def _assert_result(self, result, expected):
++        assert result == expected
+
+
+ @pytest.fixture",I made this change because I wasn't getting printouts of the 'result' value when the assert was inlined for some reason. I think it's related to creating new CallbackCheckers maybe?
+4346,"@@ -0,0 +1,11 @@
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpParser
++    {
++        bool ParseStartLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpStartLineHandler;
++
++        bool ParseHeaders<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpHeadersHandler;
++    }
++}","nit: the correct name is ""request line"", so let's use the right one here :)"
+4347,"@@ -8,9 +8,12 @@ import os
+ SQLALCHEMY_DATABASE_URI = os.environ['SQLALCHEMY_DATABASE_URI']
+
+ REGISTRY_URL = os.environ['REGISTRY_URL']
+-CATALOG_HOST = os.environ['CATALOG_HOST']
+
+-CATALOG_URL = 'https://%s' % CATALOG_HOST
++CATALOG_URL = os.environ.get('CATALOG_URL')
++if not CATALOG_URL.startswith(""https""):
++    print(""WARNING: INSECURE CONNECTION TO CATALOG"")
++    # require verbose environment variable to be defined
++    assert os.environ['ALLOW_INSECURE_CATALOG_ACCESS']
+
+ PACKAGE_BUCKET_NAME = os.environ['PACKAGE_BUCKET_NAME']
+ ","This should now use `[]`, so it crashes if the var is missing"
+4348,"@@ -162,6 +162,19 @@ static CALI_BPF_INLINE int skb_nat_l4_csum_ipv4(struct __sk_buff *skb, size_t of
+ 	return ret;
+ }
+
++static CALI_BPF_INLINE int update_state_map(struct cali_tc_state *state)
++{
++	int key = 0;
++	struct cali_tc_state *map_state = cali_v4_state_lookup_elem(&key);
++	if (!map_state) {
++		// Shouldn't be possible; the map is pre-allocated.
++		CALI_INFO(""State map lookup failed: DROP\n"");
++		return -1;
++	}
++	*map_state = *state;
++	return 0;
++}
++
+ static CALI_BPF_INLINE int forward_or_drop(struct __sk_buff *skb,
+ 					   struct cali_tc_state *state,
+ 					   struct fwd *fwd)",you could use `bpf_map_update_elem` with `BPF_EXIST`
+4349,"@@ -57,7 +57,7 @@ public class S3OutputFile extends BaseS3File implements OutputFile {
+     try {
+       return new S3OutputStream(client(), uri(), awsProperties());
+     } catch (IOException e) {
+-      throw new UncheckedIOException(""Filed to create output stream for location: "" + uri(), e);
++      throw new UncheckedIOException(""Failed to create output stream for location: "" + uri(), e);
+     }
+   }
+ ",thanks for noticing this! But I think we should not have it in this PR.
+4350,"@@ -414,6 +414,11 @@ Transaction.prototype.lockUntilDate = function(time) {
+   if (_.isDate(time)) {
+     time = time.getTime() / 1000;
+   }
++
++    for (var i = 0; i < this.inputs.length; i++) {
++      this.inputs[i].sequence = Input.DEFAULT_LOCKTIME_SEQNUMBER;
++    }
++
+   this.nLockTime = time;
+   return this;
+ };","A few things: - This may not serialize because I think the property for the sequence number on an input is `.sequenceNumber`. - There should be tests to cover these statements - Indentation is incorrect (should be two spaces, as similar to the statements above)"
+4351,"@@ -89,3 +89,16 @@ class BaseNotification(object):
+         output_filename = filename_template.format(
+             self.resource, self.cycle_timestamp, output_timestamp)
+         return output_filename
++
++    @classmethod
++    def check_data_format(cls, data_format):
++        """"""Raise `InvalidDataFormatError` unless `data_format` is supported.
++
++        Args:
++            data_format (string): should be either 'csv' or 'json'
++
++        Raises:
++            InvalidDataFormatError: if not valid
++        """"""
++        if data_format not in cls.supported_data_formats:
++            raise InvalidDataFormatError('GCS uploader', data_format)","If this is a base method that could be used by others, should you hardcode 'GCS uploader' here?"
+4352,"@@ -386,6 +386,18 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+         return result;
+     }
+
++    @Override
++    public CharSeq padTo(int length, Character element) {
++        if(length <= back.length()) {
++            return this;
++        }
++        final StringBuilder sb = new StringBuilder(back);
++        for (int i = 0; i < length - back.length(); i++) {
++            sb.append(element);
++        }
++        return new CharSeq(sb.toString());
++    }
++
+     public CharSeq mapChars(CharUnaryOperator mapper) {
+         Objects.requireNonNull(mapper, ""mapper is null"");
+         if (isEmpty()) {",just a little thing: let's introduce a `final int bound = length - back.length();` that saves us calculating the bound each time checking the loop condition.
+4353,"@@ -87,6 +87,16 @@ func (s *server) setupRouting() {
+ 		""GET"": http.HandlerFunc(s.peerBalanceHandler),
+ 	})
+
++	router.Handle(""/settlements"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.settlementsHandler),
++	})
++	router.Handle(""/settlements/{peer}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.peerSettlementsHandler),
++	})
++	router.Handle(""/settlements/pay/{peer}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.payPeerHandler),
++	})
++
+ 	baseRouter.Handle(""/"", web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""debug api access""),
+ 		handlers.CompressHandler,","I think that this should be a POST method, as it changes the state. Get requests should not change the state. With different method, I would suggest to have the handler under `""/settlements/{peer}""` path."
+4354,"@@ -31,6 +31,7 @@ var errShortRemoteTip = errors.New(""Unexpected remote less than tip"")
+ // L2GasPrice slot refers to the storage slot that the execution price is stored
+ // in the L2 predeploy contract, the GasPriceOracle
+ var l2GasPriceSlot = common.BigToHash(big.NewInt(1))
++var l2GasPriceOracleAddress = common.HexToAddress(""0x420000000000000000000000000000000000000F"")
+
+ // SyncService implements the main functionality around pulling in transactions
+ // and executing them. It can be configured to run in both sequencer mode and in",This is the default value?
+4355,"@@ -1,8 +1,8 @@
+ import os
+ import codecs
+-
++from time import strftime
+ from cliquet import utils as cliquet_utils
+-
++from kinto import __version__
+ from kinto import logger
+
+ HERE = os.path.abspath(os.path.dirname(__file__))","The spaces are actually legitimate here: in python, you: - first import standard library modules (hint: time is one) - then import 3rd party library modules - then import the modules from you project (here kinto). Between each block you need an empty line."
+4356,"@@ -571,7 +571,7 @@ func (pi *PackageInfo) MarkedSource(obj types.Object) *cpb.MarkedSource {
+ // the object has its own non-blank name, that is used; otherwise if the object
+ // is of a named type, that type's name is used. Otherwise the result is ""_"".
+ func objectName(obj types.Object) string {
+-	if name := obj.Name(); name != """" && name != """" {
++	if name := obj.Name(); name != """" {
+ 		return name // the object's given name
+ 	} else if name := typeName(obj.Type()); name != """" {
+ 		return name // the object's type's name","Haha, whoa, I'm not sure how I let that one go by. :)"
+4357,"@@ -577,6 +577,7 @@ public class DownloadInstanceWriter implements MessageBodyWriter<DownloadInstanc
+         }
+     }
+
++    // TODO: Return "".md"" for ""text/markdown"" as well as other extensions in MimeTypeDetectionByFileExtension.properties
+     private String getFileExtension(AuxiliaryFile auxFile) {
+         String fileExtension = """";
+         if (auxFile == null) {",FWIW: We have FileUtil.generateOriginalExtension for tabular files but it uses a hardcoded list rather than the properties file.
+4358,"@@ -297,6 +297,9 @@ func StartDataplaneDriver(configParams *config.Config,
+ 				InterfaceName:       configParams.WireguardInterfaceName,
+ 				MTU:                 configParams.WireguardMTU,
+ 				RouteSource:         configParams.RouteSource,
++				// currently, AKS *must* encrypt hostnetwork traffic, while it is optional on EKS
++				HostEncryptionEnabled: configParams.KubernetesProvider() == config.ProviderAKS ||
++					(configParams.WireguardHostEncryptionEnabled && configParams.KubernetesProvider() == config.ProviderEKS),
+ 			},
+ 			IPIPMTU:                        configParams.IpInIpMtu,
+ 			VXLANMTU:                       configParams.VXLANMTU,","I would consider extracting this logic in to a helper function to make it a bit more readable, but that's just my opinion."
+4359,"@@ -252,6 +252,7 @@ type Config struct {
+ 	DebugSimulateCalcGraphHangAfter time.Duration `config:""seconds;0""`
+ 	DebugSimulateDataplaneHangAfter time.Duration `config:""seconds;0""`
+ 	DebugPanicAfter                 time.Duration `config:""seconds;0""`
++	DebugSimulateDataRace           bool          `config:""bool;false""`
+
+ 	// Configure where Felix gets its routing information.
+ 	// - workloadIPs: use workload endpoints to construct routes.","Are all fields beginning with ""Debug"" automatically `;local` ? (I guess so, but just checking.)"
+4360,"@@ -54,6 +54,10 @@ class EvalHook(Hook):
+                  save_best=None,
+                  rule=None,
+                  **eval_kwargs):
++        warnings.warn(
++            'DeprecationWarning: EvalHook and DistEvalHook is a deprecated, '
++            'please use ""mmcv.runner.EvalHook"" or ""mmcv.runner.DistEvalHook"" '
++            'instead')
+         if not isinstance(dataloader, DataLoader):
+             raise TypeError('dataloader must be a pytorch DataLoader, but got'
+                             f' {type(dataloader)}')","We should let this module inherits from the EvalHook supported in MMCV, and only override the `__init__` function by adding the warnings. The other functions can use those in MMCV."
+4361,"@@ -267,14 +267,15 @@ public class PostgreExecutionContext extends JDBCExecutionContext implements DBC
+         }
+     }
+
+-    void setSessionRole(final DBRProgressMonitor monitor) throws DBCException {
++    private void setSessionRole(@NotNull DBRProgressMonitor monitor) throws DBCException {
+         final String roleName = getDataSource().getContainer().getConnectionConfiguration().getProviderProperty(PostgreConstants.PROP_CHOSEN_ROLE);
+         if (CommonUtils.isEmpty(roleName)) {
+             return;
+         }
+         try (JDBCSession session = openSession(monitor, DBCExecutionPurpose.UTIL, ""Set active role"")) {
+             try (JDBCStatement dbStat = session.createStatement()) {
+-                dbStat.executeUpdate(""SET ROLE "" + roleName);
++                String sql = ""SET ROLE "" + getDataSource().getSQLDialect().getQuotedIdentifier(roleName, false, true);
++                dbStat.executeUpdate(sql);
+             }
+         } catch (SQLException e) {
+             throw new DBCException(e, this);",Let's use prepared statements here instead
+4362,"@@ -2,7 +2,11 @@
+  * External dependencies
+  */
+ import { storiesOf } from '@storybook/react';
+-import Button from 'GoogleComponents/button';
++
++/**
++ * Internal dependencies
++ */
++import Button from '../assets/js/components/button';
+
+ storiesOf( 'Global', module )
+ 	.add( 'Buttons', () => {",Just leaving this in one place but thanks so much for re-organising all these imports.
+4363,"@@ -43,6 +43,7 @@
+ #endif
+
+ /* List of instrumentation functions. */
++#ifdef X86
+ #define FUNCTIONS() \
+         FUNCTION(empty) \
+         FUNCTION(empty_1arg) \","Ditto, here and below"
+4364,"@@ -61,7 +61,7 @@ export function initDebug() {
+ 		}
+
+ 		for (const key in vnode.props) {
+-			if (key[0]==='o' && key[1]==='n' && typeof vnode.props[key]!=='function' && vnode.props[key]!=null) {
++			if (key[0]==='o' && key[1]==='n' && typeof vnode.props[key]!=='function' && vnode.props[key]!=null && typeof vnode.type!=='function') {
+ 				throw new Error(
+ 					`Component's ""${key}"" property should be a function, ` +
+ 					`but got [${typeof vnode.props[key]}] instead\n` +",Let's move the check outside the `for`-loop so that we don't have to do it for every prop. If we change it to check for `vnode.type === 'string'` we can automatically skip checking text nodes which don't have props
+4365,"@@ -19,6 +19,17 @@ class TablePlot(BokehPlot, GenericElementPlot):
+
+     height = param.Number(default=None)
+
++    finalize_hooks = param.HookList(default=[], doc=""""""
++        Optional list of hooks called when finalizing a column
++        (deprecated in favor of hooks). The hook is passed the plot
++        object and the displayed object, and other plotting handles
++        can be accessed via plot.handles."""""")
++
++    hooks = param.HookList(default=[], doc=""""""
++        Optional list of hooks called when finalizing a column.  The
++        hook is passed the plot object and the displayed object, and
++        other plotting handles can be accessed via plot.handles."""""")
++
+     width = param.Number(default=400)
+
+     style_opts = (","Seems like the docstring here should simply be ""Deprecated; use `hooks` instead.""."
+4366,"@@ -62,6 +62,8 @@ public class FeedItemlistAdapter extends BaseAdapter {
+
+         if(UserPreferences.getTheme() == R.style.Theme_AntennaPod_Dark) {
+             playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_dark);
++        } else if(UserPreferences.getTheme() == R.style.Theme_AntennaPod_TrueBlack) {
++            playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_trueblack);
+         } else {
+             playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_light);
+         }","It would be nice to have an `attr` in `styles.xml` for this, so we don't need the same `if` statement in multiple places"
+4367,"@@ -0,0 +1,10 @@
++class CreateTeachersJoinTable < ActiveRecord::Migration
++  def change
++    create_table :teachers do |t|
++      t.belongs_to :user
++      t.belongs_to :workshop
++    end
++
++    add_index :teachers, [:user_id, :workshop_id], unique: true
++  end
++end",How about `null: false` on these two lines? Also `t.timestamps null: false`?
+4368,"@@ -183,6 +183,12 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+       }
+       threw = false;
+     } catch (TException | UnknownHostException e) {
++      if (e.getMessage().contains(""Table/View 'HIVE_LOCKS' does not exist"")) {
++        LOG.error(""Failed to acquire locks from metastore because 'HIVE_LOCKS' doesn't exist, "" +
++            ""this probably happened when using embedded metastore or doesn't create transactional"" +
++            "" meta table. Please reconfigure and start the metastore."", e);
++      }
++
+       throw new RuntimeException(String.format(""Metastore operation failed for %s.%s"", database, tableName), e);
+
+     } catch (InterruptedException e) {","This recommendation isn't very helpful because it isn't clear what ""the metastore"" is. How about this instead: ""To fix this, use an alternative metastore""."
+4369,"@@ -87,6 +87,11 @@ public class SymbolTable {
+     return desiredName + suffix;
+   }
+
++  /** Returns true if a {@code symbol} is already used. */
++  public boolean isSymbolUsed(Name symbol) {
++    return symbolTable.contains(symbol.toLowerUnderscore());
++  }
++
+   /**
+    * Returns the next numeric suffix that makes desiredName unique.
+    *","The `SymbolTable` deals only with symbols, I think we can just call this `isUsed` here."
+4370,"@@ -165,7 +165,9 @@ webdriver.Builder.prototype.build = function() {
+   } else {
+     var url = this.serverUrl_;
+     var client;
+-    if (url[0] == '/') {
++    if (webdriver.http.CorsClient.isAvailable()) {
++      client = new webdriver.http.XhrClient(url);
++    } else if (url[0] == '/') {
+       var origin = window.location.origin ||
+           (window.location.protocol + '//' + window.location.host);
+       client = new webdriver.http.XhrClient(origin + url);",Please hide this behind a flag and add a setter function to the builder.
+4371,"@@ -339,6 +339,9 @@ class EC2VPC(GenericBaseModel):
+                 )
+                 for rt in resp[""RouteTables""]:
+                     for assoc in rt.get(""Associations"", []):
++                        # skipping Main association (accommodating recent upstream change)
++                        if assoc.get(""Main""):
++                            continue
+                         ec2_client.disassociate_route_table(
+                             AssociationId=assoc[""RouteTableAssociationId""]
+                         )","Just a side-node, no need to change it here: The term ""recent"" might be confusing at a later point in time."
+4372,"@@ -36,7 +36,9 @@ module.exports = {
+             this.assertEqual(val1 && val1.getTime(), val2.getTime(), errorMessage, depth + 1);
+         }
+         else if (type === 'object') {
+-            for (const key of Object.keys(val1)) {
++            var keys = val1.keys !== undefined ? val1.keys() : Object.keys(val1);
++
++            for (const key of keys) {
+                 const message = errorMessage ? `${errorMessage}: ${key}` : key;
+                 this.assertEqual(val1[key], val2[key], message, depth + 1);
+             }",When can it be undefined? Wouldn't that be a bug?
+4373,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+
+ import com.google.common.base.Predicate;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.
+4374,"@@ -430,7 +430,7 @@ class KoalasBoxPlot(BoxPlot):
+                 ).alias(""{}_{}%"".format(colname, int(q * 100)))
+                 for q in [0.25, 0.50, 0.75]
+             ],
+-            F.mean(colname).alias(""{}_mean"".format(colname))
++            F.mean(colname).alias(""{}_mean"".format(colname)),
+         ).toPandas()
+
+         # Computes IQR and Tukey's fences","Could you remove `,' at the end?"
+4375,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?
+4376,"@@ -137,11 +137,11 @@ type AccountData struct {
+ 	// is expected to have copy-by-value semantics.
+ 	Assets map[AssetIndex]AssetHolding `codec:""asset,allocbound=-""`
+
+-	// SpendingKey is the address against which signatures/multisigs/logicsigs should be checked.
++	// EffectiveAddr is the address against which signatures/multisigs/logicsigs should be checked.
+ 	// If empty, the address of the account whose AccountData this is is used.
+-	// A transaction may change an account's SpendingKey to ""re-key"" the account.
++	// A transaction may change an account's EffectiveAddr to ""re-key"" the account.
+ 	// This allows key rotation, changing the members in a multisig, etc.
+-	SpendingKey Address `codec:""spend""`
++	EffectiveAddr Address `codec:""spend""`
+ }
+
+ // AccountDetail encapsulates meaningful details about a given account, for external consumption",do you want to rename the codec tag here too?
+4377,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";
++  String STOP_CASTING = ""stopCasting"";
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`
+4378,"@@ -106,6 +106,13 @@ def _auto_patch():
+     import os
+     import logging
+
++    from pyspark.sql import dataframe as df, functions as F
++    from databricks.koalas import functions
++
++    for name in functions.__all__:
++        if not hasattr(F, name):
++            setattr(F, name, getattr(functions, name))
++
+     # Attach a usage logger.
+     logger_module = os.getenv(""KOALAS_USAGE_LOGGER"", None)
+     if logger_module is not None:",Hm.. should we auto-patch? I am less sure on this yet as `percentile_approx` seems a Spark function and auto-patching it in Koalas seems a bit counterintuitive.
+4379,"@@ -4,12 +4,14 @@ declare(strict_types=1);
+
+ namespace Tests\ShopBundle\Test;
+
++use Psr\Container\ContainerInterface;
+ use Shopsys\FrameworkBundle\Component\DataFixture\PersistentReferenceFacade;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
+ use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
+ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
++use Zalas\Injector\PHPUnit\TestCase\ServiceContainerTestCase;
+
+-abstract class FunctionalTestCase extends WebTestCase
++abstract class FunctionalTestCase extends WebTestCase implements ServiceContainerTestCase
+ {
+     /**
+      * @var \Symfony\Bundle\FrameworkBundle\Client",I found domain use in `AllFeedsTest::getAllFeedExportCreationData` and class AllFeedsTest is descendant of `FunctionalTestCase`. I think so we can rewrite this too..
+4380,"@@ -91,6 +91,13 @@ class IcebergFilesCommitter extends AbstractStreamOperator<Void>
+   private transient Table table;
+   private transient long maxCommittedCheckpointId;
+
++  // There're two cases that we restore from flink checkpoints: the first case is restoring from snapshot created by the
++  // same flink job; another case is restoring from snapshot created by another different job. For the second case, we
++  // need to maintain the old flink job's id in flink state backend to find the max-committed-checkpoint-id when
++  // traversing iceberg table's snapshots.
++  private static final ListStateDescriptor<String> JOB_ID_DESCRIPTOR = new ListStateDescriptor<>(
++      ""iceberg-flink-job-id"", BasicTypeInfo.STRING_TYPE_INFO);
++  private transient ListState<String> jobIdState;
+   // All pending checkpoints states for this function.
+   private static final ListStateDescriptor<SortedMap<Long, List<DataFile>>> STATE_DESCRIPTOR = buildStateDescriptor();
+   private transient ListState<SortedMap<Long, List<DataFile>>> checkpointsState;","I am wondering if it is better to consolidate all committer checkpoint states into a single structure, e.g. Pojo class or Avro record which are Flink supported state types for schema evolution."
+4381,"@@ -56,9 +56,10 @@ class SignalFilter(QObject):
+         Return:
+             A partial function calling _filter_signals with a signal.
+         """"""
+-        return functools.partial(self._filter_signals, signal, tab)
++        log_signal = debug.signal_name(signal) not in self.BLACKLIST
++        return functools.partial(self._filter_signals, signal, log_signal, tab)
+
+-    def _filter_signals(self, signal, tab, *args):
++    def _filter_signals(self, signal, log_signal, tab, *args):
+         """"""Filter signals and trigger TabbedBrowser signals if needed.
+
+         Triggers signal if the original signal was sent from the _current_ tab","I assume this is a performance optimization to only check this once when creating the signal filter? While you're at it, maybe make `BLACKLIST` a set instead?"
+4382,"@@ -36,6 +36,18 @@ class DatabaseDriverNode {
+ 		});
+ 	}
+
++	loadExtension(path) {
++		return new Promise((resolve, reject) => {
++			this.db_.loadExtension(path, (error) => {
++				if (error) {
++					reject(error);
++					return;
++				}
++				resolve();
++			});
++		});
++	}
++
+ 	selectAll(sql, params = null) {
+ 		if (!params) params = {};
+ 		return new Promise((resolve, reject) => {",Please use async/await and try/catch
+4383,"@@ -1065,11 +1065,9 @@ void GenStruct(StructDef &struct_def, std::string *code_ptr) {
+       }
+     }
+   // generate object accessors if is nested_flatbuffer
++  if (field.nested_flatbuffer != nullptr) {
+   auto nested = field.attributes.Lookup(""nested_flatbuffer"");
+-  if (nested) {
+-    auto nested_qualified_name =
+-      parser_.namespaces_.back()->GetFullyQualifiedName(nested->constant);
+-    auto nested_type = parser_.structs_.Lookup(nested_qualified_name);
++	auto nested_type = nested->type.struct_def;
+     auto nested_type_name = WrapInNameSpace(*nested_type);
+     auto nestedMethodName = MakeCamel(field.name, lang_.first_camel_upper)
+       + ""As"" + nested_type_name;","Like I said, this code looks incorrect. Why is it still looking up the attribute? Why is it getting the type from `nested->type.struct_def` instead of `field.nested_flatbuffer`? Are you running `generate_code.sh`, because I think `nested->type.struct_def` would be null?"
+4384,"@@ -1664,6 +1664,7 @@ TEST_F(VkLayerTest, DescriptorUpdateTemplateEntryWithInlineUniformBlock) {
+         m_device_extension_names.push_back(VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME);
+     } else {
+         printf(""%s Push Descriptor Extension not supported, push descriptor cases skipped.\n"", kSkipPrefix);
++        return;
+     }
+
+     ASSERT_NO_FATAL_FAILURE(InitState(nullptr, nullptr, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT));","Actually, I'm not sure why lines 1663-1668 are here. Looks like Push descriptors aren't used in the test at all. @ziga-lunarg?"
+4385,"@@ -250,7 +250,7 @@ public class NodeJSGapicContext extends GapicContext implements NodeJSContext {
+    */
+   public List<String> fieldPropertyComment(Field field) {
+     String commentType = fieldTypeCardinalityComment(field);
+-    String fieldName = wrapIfKeywordOrBuiltIn(field.getSimpleName());
++    String fieldName = lowerUnderscoreToLowerCamel(field.getSimpleName());
+     return convertToCommentedBlock(
+         fieldComment(String.format(""@property {%s} %s"", commentType, fieldName), null, field));
+   }",Don't we still want to check it it's a keyword?
+4386,"@@ -14,7 +14,7 @@ class AttachmentDecorator < Draper::Decorator
+         class: ""image-with-border""
+       )
+     else
+-      ""<br><table><tr><td><strong><u>#{link_text}</u></strong></td></tr></table>""
++      ""#{link_text}""
+     end
+   end
+ ",this can just me `link_text` :tomato:
+4387,"@@ -2045,3 +2045,15 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+             kser = ks.from_pandas(pser)
+             expected = pser
+             self.assert_eq(kser.explode(), expected)
++
++    def test_argsort(self):
++        pser = pd.Series(np.random.rand(5), index=np.random.rand(5), name=""Koalas"")
++        kser = ks.from_pandas(pser)
++        self.assert_eq(pser.argsort().sort_index(), kser.argsort().sort_index())
++
++        # MultiIndex
++        pser.index = pd.MultiIndex.from_tuples(
++            [(""a"", ""v""), (""b"", ""w""), (""c"", ""x""), (""d"", ""y""), (""e"", ""z"")]
++        )
++        kser = ks.from_pandas(pser)
++        self.assert_eq(pser.argsort().sort_index(), kser.argsort().sort_index())",What if the Series contains null values?
+4388,"@@ -177,14 +177,11 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                 {
+                     new Location
+                     {
+-                         AnalysisTarget = new List<PhysicalLocationComponent>
+-                         {
+-                             new PhysicalLocationComponent
+-                             {
+-                                 Uri = TestAnalysisTarget.CreateUriForJsonSerialization(),
+-                                 Region = region
+-                             },
+-                         }
++                        AnalysisTarget = new PhysicalLocation
++                        {
++                            Uri = TestAnalysisTarget.CreateUriForJsonSerialization(),
++                            Region = region
++                        }
+                     }
+                 },
+                 FormattedMessage = new FormattedMessage","Every place you see a change like this, it's because `PhysicalLocation` is now its own object, not an array of `PhysicalLocationComponent` objects. The `Uri` is the key into the `FileInfo` dictionary."
+4389,"@@ -7,7 +7,7 @@ from mmdet.core.bbox.iou_calculators import bbox_overlaps
+ from mmdet.models import HEADS
+ from mmdet.models.dense_heads import ATSSHead
+
+-eps = 1e-12
++EPS = 1e-12
+ try:
+     import sklearn.mixture as skm
+ except ImportError:",Like in atss_head
+4390,"@@ -233,6 +233,16 @@ func (pool *TransactionPool) test(txgroup []transactions.SignedTxn) error {
+ 	// requires a flat MinTxnFee).
+ 	feePerByte = feePerByte * pool.feeThresholdMultiplier
+
++	// The threshold grows exponentially if there are multiple blocks
++	// pending in the pool.
++	if pool.numPendingWholeBlocks > 1 {
++		// golang has no convenient integer exponentiation, so we just
++		// do this in a loop
++		for i := 0; i < int(pool.numPendingWholeBlocks)-1; i++ {
++			feePerByte *= pool.expFeeFactor
++		}
++	}
++
+ 	for _, t := range txgroup {
+ 		feeThreshold := feePerByte * uint64(t.GetEncodedLength())
+ 		if t.Txn.Fee.Raw < feeThreshold {","nit : I think it would be better to have the multiplier being calculated along with `pool.numPendingWholeBlocks`, so that we could always multiply the feePerByte with that multiplier. Not only that it would be faster, but it would also have constant time. btw - Correct me if I'm wrong, but with this change, you're practically rolling back your previous change while making it `pool.expFeeFactor` adjustable, right ?"
+4391,"@@ -1,4 +1,5 @@
+ class CommentsController < ApplicationController
++  before_filter :authenticate_user!
+
+   def index
+     @commentable = find_commentable",Is there a reason we _wouldn't_ want to do this? A bit of a security hole :grimacing:
+4392,"@@ -0,0 +1,14 @@
++package azkaban.project;
++
++import java.io.File;
++import java.io.FileInputStream;
++import java.io.FileNotFoundException;
++import org.yaml.snakeyaml.Yaml;
++
++
++public class ProjectSpecLoader {
++
++  public ProjectSpec load(File projectSpecFile) throws FileNotFoundException {
++    return new Yaml().loadAs(new FileInputStream(projectSpecFile), ProjectSpec.class);
++  }
++}",Please add a copyright notice to all new files. Is there a tool to check and auto update copyright notices?
+4393,"@@ -132,7 +132,7 @@ class UserFormType extends AbstractType
+                     new Email(['message' => 'Please enter valid e-mail']),
+                     new UniqueEmail(['ignoredEmail' => $user !== null ? $user->getEmail() : null]),
+                 ],
+-                'label' => t('Email'),
++                'label' => t('E-mail'),
+             ]);
+
+         $builderRegisteredCustomerGroup = $builder->create('registeredCustomer', GroupType::class, [","A new translation dump should be made after this change (removing the ""Email"" message)"
+4394,"@@ -9,7 +9,9 @@ function owns(node, virtualTree, role, ariaOwned) {
+ 	if (node === null) {
+ 		return false;
+ 	}
+-	var implicit = implicitNodes(role),
++	var implicit = implicitNodes(role).map(
++			implicitSelector => implicitSelector + ':not([role])'
++		),
+ 		selector = ['[role=""' + role + '""]'];
+
+ 	if (implicit) {",CI is failing saying `expected [TypeError: null is not an object (evaluating 'implicitNodes(role).map')] to equal null`.
+4395,"@@ -572,12 +572,12 @@ describe('createRoot()', () => {
+ 			});
+
+ 			it('should avoid reapplying innerHTML when __html property of dangerouslySetInnerHTML attr remains unchanged', () => {
++				let thing;
++
+ 				class Thing extends Component {
+-					constructor(props) {
+-						super(props);
+-						props.ref(this);
+-					}
+ 					render() {
++						thing = this;
++
+ 						// eslint-disable-next-line react/no-danger
+ 						return (
+ 							<div dangerouslySetInnerHTML={{ __html: '<span>same</span>' }} />",@JoviDeCroock I replaced the refs here with simple assignments.
+4396,"@@ -84,7 +84,7 @@ public class TestHiveMetastore {
+   private ExecutorService executorService;
+   private TServer server;
+   private HiveMetaStore.HMSHandler baseHandler;
+-  private HiveClientPool clientPool;
++  protected HiveClientPool clientPool; // Exposed for testing.
+
+   /**
+    * Starts a TestHiveMetastore with the default connection pool size (5).",nit: Could we use VisibleForTesting annotation here?
+4397,"@@ -24,6 +24,10 @@ class PostTest < ActiveSupport::TestCase
+     post.must :save
+   end
+
++  it ""should sort 'by_unanswered'"" do
++    Post.by_unanswered.must_equal Post.joins(:topic).where(""posts_count = '1'"").order('created_at desc')
++  end
++
+   it 'posts should have an associated topic' do
+     topic = create(:topic_with_posts)
+     topic.posts[0].topic.must_equal topic",Can we create some post records to assert sort_by
+4398,"@@ -178,6 +178,7 @@ func New(ctx context.Context, o Options) (*Service, error) {
+ 		peerID := stream.Conn().RemotePeer()
+ 		i, err := s.handshakeService.Handle(NewStream(stream), peerID)
+ 		if err != nil {
++			_ = stream.Reset()
+ 			if err == handshake.ErrNetworkIDIncompatible {
+ 				s.logger.Warningf(""peer %s has a different network id."", peerID)
+ 			}",is this necessary?
+4399,"@@ -68,6 +68,8 @@ namespace Datadog.Trace.TestHelpers
+         /// </summary>
+         public int Port { get; }
+
++        public List<Func<Span, bool>> Filters { get; private set; } = new List<Func<Span, bool>>();
++
+         public IImmutableList<Span> Spans { get; private set; } = ImmutableList<Span>.Empty;
+
+         public IImmutableList<NameValueCollection> RequestHeaders { get; private set; } = ImmutableList<NameValueCollection>.Empty;",What is the purpose of this? It seems like it is used to indicate whether there is a filter on a span. But what filter? Could there eventually be multiple filters per span? Just not understanding.
+4400,"@@ -52,6 +52,13 @@ type ChaosCondition struct {
+ 	Reason string `json:""reason""`
+ }
+
++const (
++	Injecting string = ""injecting""
++	Running   string = ""running""
++	Finished  string = ""finished""
++	Paused    string = ""paused""
++)
++
+ type DesiredPhase string
+
+ const (",using a certain type instead of using string directly.
+4401,"@@ -761,7 +761,7 @@ func TestCrConflictMergedRenameSetMtimeFile(t *testing.T) {
+ 	)
+ }
+
+-// alice and both both rename(the same file, causing a copy.),
++// alice and both both rename the same file, causing a copy.,
+ func TestCrConflictRenameSameFile(t *testing.T) {
+ 	test(t,
+ 		users(""alice"", ""bob""),","fix trailing ,"
+4402,"@@ -16,7 +16,7 @@
+       <% end %>
+       ... <%= t'trace.trace.ago', :time_in_words_ago => time_ago_in_words(trace.timestamp) %></span>
+       <%= link_to t('trace.trace.more'), {:controller => 'trace', :action => 'view', :display_name => trace.user.display_name, :id => trace.id}, {:title => t('trace.trace.trace_details')} %> /
+-      <%= link_to_if trace.inserted?, t('trace.trace.map'), {:controller => 'site', :action => 'index', :anchor => ""map=14/#{trace.latitude}/#{trace.longitude}""}, {:title => t('trace.trace.view_map')} %> /
++      <%= link_to_if trace.inserted?, t('trace.trace.map'), {:controller => 'site', :action => 'index', :mlat => ""#{trace.latitude}"", :mlon => ""#{trace.longitude}"", :anchor => ""map=14/#{trace.latitude}/#{trace.longitude}""}, {:title => t('trace.trace.view_map')} %> /
+       <%= link_to t('trace.trace.edit'), {:controller => 'site', :action => 'edit', :gpx => trace.id }, {:title => t('trace.trace.edit_map')} %>
+       <span class=""trace_<%= trace.visibility %>""><%= t('trace.trace.' + trace.visibility) %></span>
+       <br />",I've fixed it for this change but for future reference there's no point doing string substitution for a single value like that - it will just slow things down. Just use `:mlat => trace.latitude` etc instead.
+4403,"@@ -10,11 +10,7 @@ namespace Ergonode\Product\Application\Model\Product\Attribute\Update;
+
+ use Symfony\Component\Validator\Constraints as Assert;
+ use Ergonode\Attribute\Application\Validator as AttributeAssert;
+-use Ergonode\Product\Application\Validator as ProductAssert;
+
+-/**
+- * @ProductAssert\ProductAttribute()
+- */
+ class UpdateAttributeValueFormModel
+ {
+     /**",The form no logger needs validation?
+4404,"@@ -42,7 +42,7 @@ namespace OpenTelemetry.Metrics
+             if (this.getMetrics != null)
+             {
+                 var metricsToExport = this.getMetrics(this.isDelta);
+-                if (metricsToExport != null)
++                if (metricsToExport != null && metricsToExport.Metrics.Count > 0)
+                 {
+                     Batch<MetricItem> batch = new Batch<MetricItem>(metricsToExport);
+                     this.exporter.Export(batch);","there'd be more changes in the area, when we implement ""clean-up"" of aggregators if no new updates. (i think we currently send metricitem to exporters with zero as value)"
+4405,"@@ -52,7 +52,9 @@ class CollectionViewTest(BaseWebTest, unittest.TestCase):
+         self.app.put_json('/buckets/sodas',
+                           MINIMALIST_BUCKET,
+                           headers=self.headers)
+-        self.app.get(other_bucket, headers=self.headers, status=404)
++        resp = self.app.get(other_bucket, headers=self.headers, status=404)
++        self.assertIn('id', resp.json['details'])
++        self.assertIn('resource_name', resp.json['details'])
+
+     def test_create_permissions_can_be_added_on_collections(self):
+         collection = MINIMALIST_COLLECTION.copy()","Usually we only keep the assertions that are relevant to the specification (ie. the test title). For example, the test on the values of id and details is not properly relevant for the spec _collections are isolated by bucket_. I suggest that you only keep the assertions regarding `details` in dedicated tests similar to `test_unknown_collection_raises_404` from `test_views_records.py`, but for each of bucket, group, collection and record in the other `test_views_` files."
+4406,"@@ -28,7 +28,7 @@ public class FieldAccessGenericParameter<T extends GenericClass<String, GenericC
+     <C extends Number> FieldAccessGenericParameter() {
+         C constructorGeneric = null;
+
+-        // access type dependant on constructor type arugments
++        // access type dependant on constructor type arguments
+         // Primary[Prefix[Name[localGeneric]]]
+         constructorGeneric = null; // Number
+     }","The test sources are ok though, you don't need to remove those changes"
+4407,"@@ -72,7 +72,7 @@ define(['itemHelper', 'mediaInfo', 'indicators', 'connectionManager', 'layoutMan
+         var apiClient = connectionManager.getApiClient(item.ServerId);
+
+         var options = {
+-            width: width,
++            maxWidth: width * 2,
+             type: ""Primary""
+         };
+ ","`maxWidth: width * 2,` Potentially, this will be the same as `getImageUrl`: 80px or 500px. I can't verify this - need for normal LiveTV tuner."
+4408,"@@ -161,9 +161,11 @@ public class EnginesFilter extends AbstractFilter {
+      * @return True if the given engine category fulfills the filter, false otherwise
+      */
+     public boolean filter(EngineCategoryDTO engineCategory) {
+-        return searchTerm.map(
+-                searchTerm -> engineCategory.getSubCategories().stream().anyMatch(engineSubCategory -> engineSubCategory
+-                        .getPackages().stream().anyMatch(version -> version.getVersion().contains(searchTerm))))
++        return searchTerm
++                .map(searchTerm -> engineCategory.getSubCategories().stream()
++                        .anyMatch(engineSubCategory -> engineSubCategory.getPackages().stream()
++                                .anyMatch(version -> version.getVersion().toLowerCase()
++                                        .contains(searchTerm.toLowerCase()))))
+                 .orElse(true);
+     }
+ ",Not really related to this issue but should we use fuzzy search here as well (like for apps)?
+4409,"@@ -11,10 +11,10 @@ const mdUsageStr = `Usage:
+   kbfstool md [<subcommand>] [<args>]
+
+ The possible subcommands are:
+-  dump		Dump metadata objects
+-  check		Check metadata objects and their associated blocks for errors
+-  reset		Reset a broken top-level folder
+-
++  dump	      Dump metadata objects
++  check	      Check metadata objects and their associated blocks for errors
++  reset	      Reset a broken top-level folder
++  forceQR     Append a fake quota reclamation record to the folder history
+ `
+
+ func mdMain(ctx context.Context, config libkbfs.Config, args []string) (exitStatus int) {",isn't the usual capitalization for subcommands force-qr? (don't care too much about it)
+4410,"@@ -38,7 +38,7 @@ import java.lang.reflect.Proxy;
+         name = ""ProxyNonConstantType"",
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = LinkType.CUSTOM,
+-        severity = SeverityLevel.SUGGESTION,
++        severity = SeverityLevel.WARNING,
+         summary = ""Proxy instances should be created using constant types known at compile time to allow native-image ""
+                 + ""behavior to match hotspot. Methods which build proxies should take a ""
+                 + ""`Function<InvocationHandler, ? extends T>` instead of arbitrary class references. """,Do you know how many repos have hit this?
+4411,"@@ -1,3 +1,13 @@
++<% if @filter.present? %>
++  <p><%= _(<<-TEXT
++    The data on the usage dashboard is historical in nature. This means that the number of records below may not
++    match the count shown on the usage dashboard. For example if one of your users created a plan in October and
++    then removed that plan in November, it would have been included on the usage dashboard's total for October but
++    would not appear in the list below.
++  TEXT
++  ) %></p>
++<% end %>
++
+ <div class=""table-responsive"">
+   <table class=""table table-hover"" id=""my-plans"">
+     <thead>",I'll be interested to see if our gettext rake tasks will pick up on this text to translate
+4412,"@@ -933,6 +933,7 @@ void LuaScriptInterface::pushInstantSpell(lua_State* L, const InstantSpell& spel
+ 	setField(L, ""mlevel"", spell.getMagicLevel());
+ 	setField(L, ""mana"", spell.getMana());
+ 	setField(L, ""manapercent"", spell.getManaPercent());
++	setField(L, ""params"", spell.getHasParam());
+
+ 	setMetatable(L, -1, ""Spell"");
+ }","I think you need to change line 928 value from 6 to 7 too, since now table will have 7 values"
+4413,"@@ -126,3 +126,14 @@ def test_split_into_nhot_long(seed, st):
+     assert set(f1.names) == set(fr.names)
+     f1 = f1[..., fr.names]
+     assert f1.to_list() == fr.to_list()
++
++
++def test_split_into_nhot_view():
++  f0 = dt.Frame(A=[""cat,dog,mouse"", ""mouse"", None, ""dog, cat""])
++  f1 = dt.split_into_nhot(f0[::-1, :])
++  f2 = dt.split_into_nhot(f0[3, :])
++  assert set(f1.names) == {""cat"", ""dog"", ""mouse""}
++  assert f1[:, [""cat"", ""dog"", ""mouse""]].to_list() == \
++         [[1, 0, 0, 1], [1, 0, 0, 1], [0, 0, 1, 1]]
++  assert set(f2.names) == {""cat"", ""dog""}
++  assert f2[:, [""cat"", ""dog""]].to_list() == [[1], [1]]","Does `f0[::-1, :]` mean all the rows taken in a reverse order?"
+4414,"@@ -30,7 +30,7 @@ public class JavaProcessJobTest
+     "" By JULIE BOSMAN \n"" +
+     ""Published: August 11, 2010 \n"" +
+     "" \n"" +
+-    ""Twelve years later, it may be Joe Fox�s turn to worry. Readers have gone from skipping small \n"" +
++    ""Twelve years later, it may be Joe Fox���s turn to worry. Readers have gone from skipping small \n"" +
+     ""bookstores to wondering if they need bookstores at all. More people are ordering books online  \n"" +
+     ""or plucking them from the best-seller bin at Wal-Mart"";
+ ",Looks like there are strange characters here.
+4415,"@@ -97,7 +97,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+
+ 		status.Experiment.Phase = v1alpha1.ExperimentPhaseFinished
+ 		status.FailedMessage = emptyString
+-	} else if chaos.IsPaused() {
++	} else if chaos.GetPause() != """" {
+ 		if status.Experiment.Phase == v1alpha1.ExperimentPhaseRunning {
+ 			r.Log.Info(""Pausing"")
+ ",It is better to have a check to ensure the format is valid.
+4416,"@@ -22,14 +22,16 @@ namespace AutoRest.Go.TemplateModels
+         private readonly string lroDescription = "" This method may poll for completion. Polling can be canceled by passing the cancel channel argument. "" +
+                                                  ""The channel will be used to cancel polling and any outstanding HTTP requests."";
+
++        public readonly bool NextAlreadyDefined;
+
+-        public MethodTemplateModel(Method source, string owner, string packageName, MethodScopeProvider methodScope)
++        public MethodTemplateModel(Method source, string owner, string packageName, MethodScopeProvider methodScope, bool next)
+         {
+             this.LoadFrom(source);
+
+             MethodScope = methodScope;
+             Owner = owner;
+             PackageName = packageName;
++            NextAlreadyDefined = next;
+
+             var parameter = Parameters.Find(p => p.Type.IsPrimaryType(KnownPrimaryType.Stream)
+                                                 && !(p.Location == ParameterLocation.Body || p.Location == ParameterLocation.FormData));",How about `nextAlreadyDefined` variable name in method signature?
+4417,"@@ -459,7 +459,7 @@ func (s *clientIntegrationSuite) TestClientDataConverter_WithChild() {
+
+ 	// to ensure custom data converter is used, this number might be different if client changed.
+ 	d := dc.(*testDataConverter)
+-	s.Equal(3, d.NumOfCallToPayloads)
++	s.Equal(2, d.NumOfCallToPayloads)
+ 	s.Equal(2, d.NumOfCallFromPayloads)
+ }
+ ","In older SDK versions the data converter was called 3 times but now it is 2. This is because logic was changed deep in the interceptor chains on when values are serialized and encoded and such. Previously we invoked the data converter on results _even if there was an error_ (and most of the time they were nil). Now we don't do such a thing, resulting in fewer calls."
+4418,"@@ -17,6 +17,7 @@ limitations under the License.
+ package main
+
+ import (
++	""github.com/google/knative-gcp/pkg/reconciler/events/build""
+ 	// The following line to load the gcp plugin (only required to authenticate against GKE clusters).
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+ ",formatting... can this import go next to the other sources ones?
+4419,"@@ -286,10 +286,10 @@ const char *options_list_str =
+     ""       -early             Requests early injection (the default).\n""
+     ""       -late              Requests late injection.\n""
+ #        endif
+-    ""       -attach <pid>      Attach to the process with the given pid.  Pass 0\n""
+-    ""                          for pid to launch and inject into a new process.\n""
+     ""       -logdir <dir>      Logfiles will be stored in this directory.\n""
+ #    endif
++    ""       -attach <pid>      Attach to the process with the given pid.  Pass 0\n""
++    ""                          for pid to launch and inject into a new process.\n""
+     ""       -use_dll <dll>     Inject given dll instead of configured DR dll.\n""
+     ""       -force             Inject regardless of configuration.\n""
+     ""       -exit0             Return a 0 exit code instead of the app's exit code.\n""",I don't understand why anyone would pass 0? If you don't want to attach to an existing process you just wouldn't pass -attach. I would remove that sentence and make 0 an invalid argument.
+4420,"@@ -77,8 +77,6 @@ void (*volatile s_current_function)(ThreadsExec &, const void *);
+ const void *volatile s_current_function_arg = nullptr;
+
+ struct Sentinel {
+-  Sentinel() {}
+-
+   ~Sentinel() {
+     if (s_thread_pool_size[0] || s_thread_pool_size[1] ||
+         s_thread_pool_size[2] || s_current_reduce_size ||",This change is responsible for #2775
+4421,"@@ -88,7 +88,11 @@ namespace Datadog.Trace.Tests.RuntimeMetrics
+                 writer.PushEvents();
+
+                 statsd.Verify(
+-                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), It.IsAny<string[]>()),
++                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), new[] { ""exception_type:CustomException1"" }),
++                    Times.Never);
++
++                statsd.Verify(
++                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), new[] { ""exception_type:CustomException2"" }),
+                     Times.Never);
+             }
+         }","Should we add this to the other ""never"" verification in lines 71-73 above, too?"
+4422,"@@ -175,12 +175,12 @@ class CaiApiClientImpl(gcp.ApiClientImpl):
+             dict: Generator of datasets.
+         """"""
+
+-        resources = list(self.dao.iter_cai_assets(
++        resources = self.dao.iter_cai_assets(
+             ContentTypes.resource,
+             'google.cloud.bigquery.Dataset',
+             '//cloudresourcemanager.googleapis.com/projects/{}'.format(
+                 project_number),
+-            self.session))
++            self.session)
+
+         for dataset in resources:
+             yield dataset","Fixed this since it no longer needed to be switched from a generator to a list, this was missed when I cleaned up the dataset code in an earlier PR."
+4423,"@@ -70,7 +70,7 @@ public class NodeOptions {
+       Capabilities caps = info.getCanonicalCapabilities();
+       builders.stream()
+           .filter(builder -> builder.score(caps) > 0)
+-          .peek(builder -> LOG.info(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
++          .peek(builder -> LOG.finest(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
+           .forEach(builder -> {
+             DriverService.Builder freePortBuilder = builder.usingAnyFreePort();
+ ",This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave.
+4424,"@@ -5,5 +5,17 @@ class ContributorFact < NameFact
+         .where(analysis_id: project.best_analysis_id)
+         .where.not(name_id: Position.where.not(name_id: nil).where(project_id: project.id).select(:name_id))
+     end
++
++    def first_for_name_id_and_project_id(name_id, project_id)
++      sql = <<-SQL
++        SELECT name_facts.* FROM name_facts
++          INNER JOIN projects ON projects.best_analysis_id = name_facts.analysis_id
++          WHERE ( name_facts.name_id = #{name_id.to_i} OR name_facts.name_id IN (
++            SELECT AA.preferred_name_id FROM analysis_aliases AA
++            WHERE AA.analysis_id = projects.best_analysis_id AND AA.commit_name_id = #{name_id.to_i}))
++          AND projects.id = #{project_id.to_i} AND type='ContributorFact'
++        SQL
++      ContributorFact.find_by_sql(sql).first
++    end
+   end
+ end","Can we convert this to an arel as below ContributorFact .joins(:project).where(projects: { id: project_id}) .where('name_id = ? or name_id in (?)', name_id, AnalysisAlias.select(:preferred_name_id) .joins(:project) .where(commit_name_id: name_id) )"
+4425,"@@ -11,6 +11,12 @@ import (
+ type DevicesGroup struct {
+ }
+
++type CgroupParams struct {
++	initpid int
++}
++
++var cg CgroupParams
++
+ func (s *DevicesGroup) Name() string {
+ 	return ""devices""
+ }",Does this cause issues if you have lots of load on the machine? Having a global variable for this seems like a bad idea IMO.
+4426,"@@ -1374,7 +1374,15 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       privacyParametersBuilder.setEnabled(true);
+       privacyParametersBuilder.setEnclaveUrl(privacyUrl);
+       if (privacyPublicKeyFile() != null) {
+-        privacyParametersBuilder.setEnclavePublicKeyUsingFile(privacyPublicKeyFile());
++        try {
++          privacyParametersBuilder.setEnclavePublicKeyUsingFile(privacyPublicKeyFile());
++        } catch (final IOException e) {
++          throw new ParameterException(
++              commandLine, ""Problem with privacy-public-key-file: "" + e.getMessage(), e);
++        } catch (final IllegalArgumentException e) {
++          throw new ParameterException(
++              commandLine, ""Contents of privacy-public-key-file invalid: "" + e.getMessage(), e);
++        }
+       } else {
+         throw new ParameterException(
+             commandLine, ""Please specify Enclave public key file path to enable privacy"");",We probably don't need to print the msg with e.getMessage(). It will be printed by the logger since we are passing the exception as a parameter.
+4427,"@@ -29,17 +29,6 @@ from molecule.verifier import testinfra
+ from molecule.verifier.lint import flake8
+
+
+-@pytest.fixture
+-def _patched_testinfra_get_tests(mocker):
+-    m = mocker.patch('molecule.verifier.testinfra.Testinfra._get_tests')
+-    m.return_value = [
+-        'foo.py',
+-        'bar.py',
+-    ]
+-
+-    return m
+-
+-
+ @pytest.fixture
+ def _verifier_section_data():
+     return {",Can we get a test with multiple directories as per the initial example?
+4428,"@@ -317,8 +317,15 @@ def getStatusBar():
+ 	if not location:
+ 		return None
+ 	left, top, width, height = location
+-	bottom = top + height - 1
+-	obj = getDesktopObject().objectFromPoint(left, bottom)
++	x=1
++	while x<12:
++		bottom = top + height - x
++		if left<0:
++			left=0
++		obj = getDesktopObject().objectFromPoint(left, bottom)
++		if obj and obj.role == controlTypes.ROLE_STATUSBAR:
++			break
++		x=x+2
+
+ 	# We may have landed in a child of the status bar, so search the ancestry for a status bar.
+ 	while obj and not obj.role == controlTypes.ROLE_STATUSBAR:",I assume this is because you were seeing cases where left was a negative number? When?
+4429,"@@ -11,10 +11,10 @@
+    See the README file in the top-level LAMMPS directory.
+ ------------------------------------------------------------------------- */
+
+-#include ""fix_deposit.h""
+-#include <mpi.h>
+ #include <cmath>
++#include <cstdlib>
+ #include <cstring>
++#include ""fix_deposit.h""
+ #include ""atom.h""
+ #include ""atom_vec.h""
+ #include ""molecule.h""",this is undoing recent changes for increased consistency of include file statements. please restore to the original.
+4430,"@@ -24,12 +24,13 @@ public class BaselineErrorProneExtension {
+
+     private static final ImmutableList<String> DEFAULT_PATCH_CHECKS = ImmutableList.of(
+             // Baseline checks
++            ""LambdaMethodReference"",
++            ""OptionalOrElseMethodInvocation"",
+             ""PreferBuiltInConcurrentKeySet"",
+             ""PreferCollectionTransform"",
+             ""PreferListsPartition"",
+             ""PreferSafeLoggableExceptions"",
+             ""PreferSafeLoggingPreconditions"",
+-            ""OptionalOrElseMethodInvocation"",
+
+             // Built-in checks
+             ""ArrayEquals"",","If these are applied in order, should `LambdaMethoReference` come after `OptionalOrElseMethodInvocation`"
+4431,"@@ -42,7 +42,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+         /// A dictionary whose keys are the strings representing the locations of scanned files
+         /// and whose values provide information about those files.
+         /// </param>
+-        void WriteFiles(IDictionary<string, IList<FileData>> fileDictionary);
++        void WriteFiles(IDictionary<string, FileData> filesDictionary);
+
+         /// <summary>
+         /// Write information about the logical locations where results were produced to",Why this rename?
+4432,"@@ -149,7 +149,7 @@ def _patch_sysmodules():
+     try:
+         yield
+     finally:
+-        if mock_main:
++        if mock_main and sys.version_info < (3, 3):
+             sys.modules.pop(""__main__"")
+
+ ",Why do we do this check here? `sys.version_info` cannot be less than 3.3 as pylint does not support older versions. I think we should avoid popping `__main__` altogether.
+4433,"@@ -199,6 +199,7 @@ def serv_cmd(codechecker_cfg, test_config):
+                        '--port',
+                        str(codechecker_cfg['viewer_port'])
+                        ])
++    # server_cmd.extend(['--verbose', 'debug'])
+
+     psql_cfg = codechecker_cfg.get('pg_db_config')
+     if psql_cfg:",This can be removed too.
+4434,"@@ -371,8 +371,11 @@ func (md *MDServerMemory) Put(ctx context.Context, rmds *RootMetadataSigned) err
+
+ 	// Consistency checks
+ 	if head != nil {
+-		err := head.MD.CheckValidSuccessorForServer(
+-			md.config.Crypto(), &rmds.MD)
++		id, err := md.config.Crypto().MakeMdID(&head.MD)
++		if err != nil {
++			return err
++		}
++		err = head.MD.CheckValidSuccessorForServer(id, &rmds.MD)
+ 		if err != nil {
+ 			return err
+ 		}","I'm a little worried about the new extra calls to `MakeMdId`, since in most local-server KBFS profiles, hashing is the biggest CPU user, and not re-using the value calculated by the client will result in even more hashing. That said, I understand why you did it this way, and I don't have a concrete suggestion on how to make it better. Just something to keep in mind; plus it might be worth comparing the test speed before and after this change to make sure it didn't slow things down too much."
+4435,"@@ -29,9 +29,12 @@ import PreviewTable from 'GoogleComponents/preview-table';
+  */
+ import { isDataZeroForReporting, getTopPagesReportDataDefaults } from '../util';
+
+-const { __ } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class WPAnalyticsDashboardWidgetTopPagesTable extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies
+4436,"@@ -1,6 +1,7 @@
++# -*- coding: UTF-8 -*-
+ #appModules/miranda32.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2012 NVDA Contributors
++#Copyright (C) 2006-2019 NV Access Limited, Aleksey Sadovoy, Peter Vágner, Joseph Lee, Bill Dengler
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ","Just curious, but how did you work out that Aleksey Sadovoy, Peter Vgner and Joseph Lee contributed to this file? Did you look at the repository history?"
+4437,"@@ -264,6 +264,19 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+                 _post.Reference();
+                 _post.Dispose();
+
++                // We need this walk because we call ReadStop on 2 places:
++                // 1. On the dispatch pipe UvPipeHandle after reading the correct message
++                // 2. On on accepted connections when there's back pressure
++                // Calling ReadStop makes the handle as in-active which means the loop can
++                // end while there's still valid handles around. This makes loop.Dispose throw
++                // with an EBUSY. To avoid that, we walk all of the handles and dispose them.
++                Walk(ptr =>
++                {
++                    var handle = UvMemory.FromIntPtr<UvHandle>(ptr);
++                    // handle can be null because UvMemory.FromIntPtr looks up a weak reference
++                    handle?.Dispose();
++                });
++
+                 // Ensure the Dispose operations complete in the event loop.
+                 _loop.Run();
+ ",You could call OnStopRude() directly here to do the same thing.
+4438,"@@ -643,6 +643,8 @@ func (a *WebAPI) ListUnregisteredApplications(ctx context.Context, _ *webservice
+ 		return &webservice.ListUnregisteredApplicationsResponse{}, nil
+ 	}
+
++	// TODO: Eliminate apps registered by another Piped
++	//   In case that multiple Pipeds watches the same repo, it could be happen that one Piped report App-1 as an unregistered app even though another Piped register that app.
+ 	sort.Slice(allApps, func(i, j int) bool {
+ 		return allApps[i].Path < allApps[j].Path
+ 	})","This TODO and this `sort` depend on how the UI looks like. So I think we should fix the UI before continuing on updating this web API. For example, in case the UI flow is as below, this API will receive a Piped ID and then return just ones belonging to that Piped. - User picks where they want to deploy first (select one Piped and one cloud provider) - Then API will be called to show the list of suggested apps for that Piped and cloud provider - User picks app they want to create"
+4439,"@@ -24,6 +24,16 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	snapshotrevertHelpText = `
++Usage: mayactl snapshot revert [options]
++
++$ mayactl snapshot revert --volname <vol> --snapname <snap>
++
++This command displays status of available snapshotrevert.
++`
++)
++
+ /*type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string","This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. This command should be used cautiously and only when there is an issue with the current state of the data."
+4440,"@@ -567,9 +567,12 @@ func TestAwslogsDriver(t *testing.T) {
+ 		})
+ 	}()
+
++	strs := strings.Split(*testTask.TaskArn, ""/"")
++	taskId := strs[len(strs)-1]
++
+ 	params := &cloudwatchlogs.GetLogEventsInput{
+ 		LogGroupName:  aws.String(awslogsLogGroupName),
+-		LogStreamName: aws.String(containerId),
++		LogStreamName: aws.String(fmt.Sprintf(""ecs-functional-tests/awslogs/%s"", taskId)),
+ 	}
+ 	resp, err := cwlClient.GetLogEvents(params)
+ 	if err != nil {",should this be a separate/new functional test?
+4441,"@@ -458,6 +458,19 @@ describe Mongoid::QueryCache do
+       end
+     end
+
++   context 'when querying colleciton larger than the batch size' do
++     before do
++       101.times { Band.create! }
++     end
++
++     it 'does not raise an exception when querying multiple times' do
++       expect do
++         Band.all.to_a
++         Band.all.to_a
++       end.not_to raise_error
++     end
++   end
++
+     context ""when query caching is enabled and the batch_size is set"" do
+
+       around(:each) do |example|",Can these also assert at least the length of arrays returned and ideally contents?
+4442,"@@ -822,7 +822,7 @@ class Scheduler(object):
+             task.family = family
+         if not getattr(task, 'module', None):
+             task.module = module
+-        if not task.param_visibilities:
++        if not getattr(task, 'param_visibilities', None):
+             task.param_visibilities = _get_default(param_visibilities, {})
+         if not task.params:
+             task.set_params(params)","`hasattr(task, 'param_visibilities')` is more concise with the same effect, but either one works."
+4443,"@@ -364,6 +364,12 @@ MSGS = {
+         ""end up in having multiple values passed for the aforementioned parameter in ""
+         ""case the method is called with keyword arguments."",
+     ),
++    ""W1114"": (
++        ""Positional arguments are out of order"",
++        ""arguments-out-of-order"",
++        ""Attributes given to a function call have are being passed in a different order ""
++        ""to the function's definition"",
++    ),
+ }
+
+ # builtin sequence types in Python 2 and 3.","I would hedge this a little, maybe `Positional arguments appear to be out of order`. After all, it's just a guess."
+4444,"@@ -192,7 +192,8 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
+
+     @Override
+     public void showError() {
+-        SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in));
++        Snackbar snackbar = SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in));
++        snackbar.show();
+     }
+
+     @Override","you can directly call show() method from **SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)).show();** no need to create an extra object and then call the show method."
+4445,"@@ -306,6 +306,19 @@ StatusOr<std::vector<HostAddr>> NetworkUtils::toHosts(const std::string& peersSt
+     return hosts;
+ }
+
++std::string NetworkUtils::toHosts(const std::vector<HostAddr>& hosts) {
++    std::string hostsString = """";
++    for (auto& host : hosts) {
++        std::string addrStr = network::NetworkUtils::ipFromHostAddr(host);
++        int32_t port = network::NetworkUtils::portFromHostAddr(host);
++        hostsString += folly::stringPrintf(""%s:%d, "", addrStr.c_str(), port);
++    }
++    if (!hostsString.empty()) {
++        hostsString.resize(hostsString.size() - 2);
++    }
++    return hostsString;
++}
++
+ std::string NetworkUtils::ipFromHostAddr(const HostAddr& host) {
+     return intToIPv4(host.first);
+ }",concatHosts may be a better func name to explain this?
+4446,"@@ -0,0 +1,19 @@
++import { always } from 'ramda';
++
++/**
++ * A function that returns new empty string.
++ *
++ * @func stubString
++ * @memberOf RA
++ * @since {@link https://char0n.github.io/ramda-adjunct/2.1.0|v2.1.0}
++ * @category Function
++ * @sig ... -> ''
++ * @return {''}
++ * @example
++ *
++ * RA.stubString(); //=> ''
++ * RA.stubString(1, 2, 3); //=> ''
++ */
++const stubString = always('');
++
++export default stubString;",A function that returns empty string.
+4447,"@@ -194,7 +194,12 @@ func parsePackage(state *core.BuildState, label, dependent core.BuildLabel, subr
+ 		}
+ 	} else {
+ 		filename, dir := buildFileName(state, label.PackageName, subrepo)
+-		if filename == """" {
++		if filename != """" {
++			pkg.Filename = filename
++			if err := state.Parser.ParseFile(state, pkg, pkg.Filename); err != nil {
++				return nil, err
++			}
++		} else if packageName != """" || state.Config.FeatureFlags.RemovePleasings {
+ 			exists := core.PathExists(dir)
+ 			// Handle quite a few cases to provide more obvious error messages.
+ 			if dependent != core.OriginalTarget && exists {","If it's not the root package, or if it is the root package but we don't add the psudo :pleasings rule there, print an error."
+4448,"@@ -17,7 +17,9 @@ import (
+ 	""strconv""
+
+ 	""github.com/go-playground/validator/v10""
++
+ 	corev1 ""k8s.io/api/core/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/util/validation""
+ )
+ ",can delete this line
+4449,"@@ -76,6 +76,18 @@ generic_data_store::generic_data_store(generic_data_reader *reader, model *m) :
+   if (opts->has_bool(""verbose"") && opts->get_bool(""verbose"")) {
+     m_verbose = true;
+   }
++
++  if (opts->has_string(""use_tarball"")) {
++    m_dir = m_reader->get_local_file_dir();
++  }
++
++  if (m_comm->get_num_models() != 1) {
++    if (m_master) {
++      std::cerr << ""\nFATAL ERROR: data store classes currently assume there is\n""
++                << ""a single model; please ask Dave Hysom to fix!\n\n"";
++    }
++    exit(9);
++  }
+ }
+
+ void generic_data_store::get_minibatch_index_vector() {",Will it still be an issue if all the models use the same data set?
+4450,"@@ -37,6 +37,8 @@ class WidgetsController < ApplicationController
+   def handle_xml_format
+     return unless request_format == 'xml'
+     @type = WIDGET_TYPES.select { |klass| controller_name.include?(klass) }[0]
++    @parent = @widget.send(@type)
++    fail ParamRecordNotFound unless @parent
+     render template: 'widgets/metadata'
+   end
+ end",How does this controller_name method work? Does this method grab the context of the url request? Wouldn't this always result in 'widget'?
+4451,"@@ -18,6 +18,9 @@
+  *  limitations under the License.
+  */
+
++#define FS_CHUNK_SIZE_DEBUG(op)  {flb_debug(""[%d] %s -> fs_chunks_size = %zu"", __LINE__, op->name, op->fs_chunks_size);}
++#define FS_CHUNK_SIZE_DEBUG_MOD(op, chunk, mod)  {flb_debug(""[%d] %s -> fs_chunks_size = %zu mod=%zd chunk=%s"", __LINE__, op->name, op->fs_chunks_size, mod, flb_input_chunk_get_name(chunk));}
++
+ #include <fluent-bit/flb_info.h>
+ #include <fluent-bit/flb_input.h>
+ #include <fluent-bit/flb_input_chunk.h>",Let's get rid of these for the final version and if you get rid of the macro I left last time I'd be more than grateful.
+4452,"@@ -36,6 +36,8 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 1, ""_file"", Types.StringType.get(), ""Path of the file in which a row is stored"");
+   public static final NestedField ROW_POSITION = NestedField.required(
+       Integer.MAX_VALUE - 2, ""_pos"", Types.LongType.get(), ""Ordinal position of a row in the source data file"");
++  public static final NestedField DELETE_MARK = NestedField.required(
++      Integer.MAX_VALUE - 3, ""_deleted"", Types.BooleanType.get(), ""Delete mark denotes whether row is deleted or not"");
+
+   // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+   public static final NestedField DELETE_FILE_PATH = NestedField.required(","Instead of `DELETE_MARK`, how about `IS_DELETED`? I don't think that ""mark"" is clear enough to describe what this is. Similarly, I think the docs should be ""Whether the row has been deleted"". There's no need to include ""delete mark"" because that's identifying something that is not defined (this column is _deleted and ""mark"" is not introduced), and ""or not"" is unnecessary because it is implied by ""whether""."
+4453,"@@ -179,6 +179,19 @@ def init_worker(checked_num, action_num):
+     progress_actions = action_num
+
+
++def get_dependent_headers(buildaction, archive):
++    LOG.debug(""Generating dependent headers via compiler..."")
++    try:
++        dependencies = set(create_dependencies(buildaction))
++    except Exception as ex:
++        LOG.debug(""Couldn't create dependencies:"")
++        LOG.debug(str(ex))
++        # TODO append with buildaction
++        archive.writestr(""no-sources"", str(ex))
++        dependencies = set()
++    return dependencies
++
++
+ def check(check_data):
+     """"""
+     Invoke clang with an action which called by processes.",Does it make sense to have this very thin wrapper that only calls `create_dependencies`? And maybe having `create_dependencies` return a set would be better than convert here?
+4454,"@@ -401,7 +401,7 @@ int h2o_get_compressible_types(const h2o_headers_t *headers)
+     return compressible_types;
+ }
+
+-h2o_iovec_t h2o_build_destination(h2o_req_t *req, const char *prefix, size_t prefix_len)
++h2o_iovec_t h2o_build_destination(h2o_req_t *req, const char *prefix, size_t prefix_len, int escape)
+ {
+     h2o_iovec_t parts[4];
+     size_t num_parts = 0;",How about renaming `escape` to `use_path_normalized` or something to better indicate that it is a selection between `path` and `path_normalized`?
+4455,"@@ -41,4 +41,8 @@ public interface Accountable {
+     return Collections.emptyList();
+   }
+
++  /**
++   * An accountable that always returns 0
++   */
++  Accountable NULL_ACCOUNTABLE = () -> 0;
+ }",Interface members are always `static final` right?
+4456,"@@ -0,0 +1,17 @@
++// +build nintendoswitch
++
++package runtime
++
++import (
++	""unsafe""
++)
++
++// Result svcOutputDebugString(const char *str, u64 size)
++//go:export svcOutputDebugString
++func svcOutputDebugString(str *byte, size uint64) uint64
++
++//go:export malloc
++func extalloc(size uintptr) unsafe.Pointer
++
++//export free
++func extfree(ptr unsafe.Pointer)","It seems to me that this could be in the runtime_nintendoswitch.go file, or is there a reason to keep it separate?"
+4457,"@@ -1857,8 +1857,6 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
+     log->PutCString(s.c_str());
+   }
+
+-  swift::performSILLinking(sil_module.get());
+-
+   if (m_swift_ast_context->HasErrors()) {
+     DiagnoseSwiftASTContextError();
+     return 1;",I was actually looking at this code over the weekend and wondering whether we were trying to link here. I assume it's been cargo culted from something else in the compiler.
+4458,"@@ -0,0 +1,14 @@
++<div class=""form-group"">
++  <%= f.label _('Name'), for: :name, class: ""control-label"" %>
++  <%= f.text_field :name, as: :string, class: ""form-control"", 'data-toggle': 'tooltip', title: _('Add an appropriate name for your guidance group. This name will be used to tell the end user where the guidance has come from. It will be appended to text identifying the theme e.g. ""[guidance group name]: guidance on data sharing"" so we suggest you just use the institution or department name.'), 'aria-required': true %>
++</div>
++
++<div class=""checkbox"">
++  <%= f.label :published, raw(""#{f.check_box :published, 'data-toggle': 'tooltip', title: _('Check this box when you are ready for guidance associated with this group to appear on user\'s plans.')} #{_('Published')}"") %>
++</div>
++
++<div class=""checkbox"">
++  <%= f.label :optional_subset, raw(""#{f.check_box :optional_subset, 'data-toggle': 'tooltip', title: _('If the guidance is only meant for a subset of users e.g. those in a specific college or institute, check this box.  Users will be able to select to display this subset guidance when answering questions in the \'create plan\' wizard.')} #{_('Optional Subset (e.g. School/Department)')}"") %>
++</div>
++
++<%= f.submit _('Save'), class: 'btn btn-primary' %>",nice extraction of the form for being used at new/edit. We should have more of these
+4459,"@@ -37,8 +37,8 @@ using namespace RDKit;
+  * Version 2 taken from J. Chem. Inf. Model. 56, 1 (2016)
+  *
+  * torsion-angle potential form:
+- * V = V1*(1 + s1*cos(1x)) + V2*(1 + s2*cos(2x)) + V3*(1 + s3*cos(1x))
+- *     + V4*(1 + s4*cos(1x)) + V5*(1 + s5*cos(1x)) + V6*(1 + s6*cos(1x))
++ * V = V1*(1 + s1*cos(1x)) + V2*(1 + s2*cos(2x)) + V3*(1 + s3*cos(3x))
++ *     + V4*(1 + s4*cos(4x)) + V5*(1 + s5*cos(5x)) + V6*(1 + s6*cos(6x))
+  *
+  * format: [SMARTS, s1, V1, s2, V2, s3, V3, s4, V4, s5, V5, s6, V6]
+  */",Are the coefficients the actual bug fix?
+4460,"@@ -218,8 +218,8 @@ class PostgresTarget(luigi.Target):
+
+         try:
+             cursor.execute(sql)
+-        except psycopg2.ProgrammingError as e:
+-            if e.pgcode == psycopg2.errorcodes.DUPLICATE_TABLE:
++        except (psycopg2.ProgrammingError, psycopg2.IntegrityError) as e:
++            if e.pgcode in [psycopg2.errorcodes.DUPLICATE_TABLE, psycopg2.errorcodes.UNIQUE_VIOLATION]:
+                 pass
+             else:
+                 raise",Why are the error code options in a list and not a tuple?
+4461,"@@ -135,7 +135,7 @@ class ExternalProjectAccessRuleBookTest(ForsetiTestCase):
+     TEST_ANCESTORS = [Project('123'),
+                       Folder('456'),
+                       Organization('7890')]
+-    TEST_BAD_ANC = [Project('123'),
++    TEST_BAD_ANCESTORS = [Project('123'),
+                     Folder('456'),
+                     Organization('ABC')]
+ ",Need alignment with the preceding line.
+4462,"@@ -28,10 +28,8 @@ public class MainnetProtocolSchedule {
+
+   public static final BigInteger DEFAULT_CHAIN_ID = BigInteger.ONE;
+
+-  public static ProtocolSchedule create() {
+-    return fromConfig(
+-        GenesisConfigFile.mainnet().getConfigOptions(), PrivacyParameters.DEFAULT, false);
+-  }
++  public static final ProtocolSchedule DEFAULT =
++      fromConfig(GenesisConfigFile.getMainnetConfigOptions(), PrivacyParameters.DEFAULT, false);
+
+   /**
+    * Create a Mainnet protocol schedule from a config object","Changing from a static method to a constant is inessential to Type Transactions and has a long reach, adding many unneeded files and diff lines."
+4463,"@@ -92,13 +92,14 @@ public final class TreeSet<T> implements SortedSet<T>, Serializable {
+
+     public static <T extends Comparable<? super T>> TreeSet<T> ofAll(java.lang.Iterable<? extends T> values) {
+         Objects.requireNonNull(values, ""values is null"");
+-        return new TreeSet<>(RedBlackTree.ofAll(values));
++        return values.iterator().hasNext() ? new TreeSet<>(RedBlackTree.ofAll(values)) : empty();
+     }
+
++    @SuppressWarnings(""unchecked"")
+     public static <T> TreeSet<T> ofAll(Comparator<? super T> comparator, java.lang.Iterable<? extends T> values) {
+         Objects.requireNonNull(comparator, ""comparator is null"");
+         Objects.requireNonNull(values, ""values is null"");
+-        return new TreeSet<>(RedBlackTree.ofAll(comparator, values));
++        return values.iterator().hasNext() ? new TreeSet<>(RedBlackTree.ofAll(comparator, values)) : (TreeSet<T>) empty();
+     }
+
+     /**","There is one caveat: javaslang.collection.Iterator is Iterable. With Iterator it does not work. Let's revert this line. Does this happen elsewhere, too? I will double-check the code..."
+4464,"@@ -659,7 +659,7 @@ class SimpleConfig(Logger):
+             except:
+                 pass
+
+-    def format_amount(self, x, is_diff=False, whitespaces=False):
++    def format_amount(self, x, is_diff = True, whitespaces = False, add_thousands_sep = True):
+         return format_satoshis(
+             x,
+             num_zeros=self.num_zeros,",Why change the default value of `is_diff`?
+4465,"@@ -37,7 +37,7 @@ readme_note = """"""
+ with open('README.rst') as fobj:
+     long_description = ""\n\n"" + readme_note + ""\n\n"" + fobj.read()
+
+-install_requires = ['python-dateutil>=2.7.5,<3']
++install_requires = ['python-dateutil>=2.7.5,<3', 'tenacity>=6.3.0']
+
+ # Can't use python-daemon>=2.2.0 if on windows
+ #     See https://pagure.io/python-daemon/issue/18","I think tacking on `,<7` would be a wise precaution in case of future incompatible changes in tenacity."
+4466,"@@ -38,7 +38,7 @@ final class NoDriverManager implements GalleryManagerInterface, MediaManagerInte
+      * @param int|null $limit
+      * @param int|null $offset
+      */
+-    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null): array
++    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
+     {
+         throw new NoDriverException();
+     }",I don't think is necessary to remove the return type
+4467,"@@ -128,7 +128,11 @@ public class AuthenticatorService extends Service {
+             final String userId = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_USER_ID), passcodeHash);
+             final String orgId = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_ORG_ID), passcodeHash);
+             final String username = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_USERNAME), passcodeHash);
+-            final String clientSecret = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_CLIENT_SECRET), passcodeHash);
++            final String encClientSecret = mgr.getUserData(account, AuthenticatorService.KEY_CLIENT_SECRET);
++            String clientSecret = null;
++            if (encClientSecret != null) {
++                clientSecret = ForceApp.decryptWithPasscode(encClientSecret, passcodeHash);
++            }
+             final Bundle resBundle = new Bundle();
+             try {
+                 final TokenEndpointResponse tr = OAuth2.refreshAuthToken(HttpAccess.DEFAULT, new URI(loginServer), clientId, refreshToken, clientSecret);","Also added this check, since client secret is not used except in the IP bypass scenario."
+4468,"@@ -151,6 +151,8 @@ const baseActions = {
+ 				return;
+ 			}
+
++			// Clear any profile ID selection in the case that selection falls to the getProfiles resolver.
++			registry.dispatch( STORE_NAME ).setProfileID( '' );
+ 			registry.dispatch( STORE_NAME ).setPropertyID( propertyID );
+
+ 			if ( PROPERTY_CREATE === propertyID ) {","That's unrelated, but shouldn't there also be a call to `setInternalWebPropertyID`, making it empty, for this case? Otherwise, when selecting to create a new property, any previous internal web property ID will still be in state, potentially causing problems."
+4469,"@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
+ 		out, err := system.RunCommand(DdevBin, args)
+ 		assert.NoError(err)
+ 		assert.Contains(string(out), ""Server started"")
+-		assert.Contains(string(out), ""GET"")
+
+ 		cleanup()
+ 	}",I wonder if we should trigger a PHP error and ensure it ends up in the log?
+4470,"@@ -247,6 +247,16 @@ describe TopicsController do
+     topic.closed.must_equal false
+   end
+
++  # TODO: Will need to figure out how javascript will affect the testing.
++  it 'admin can get to move_topic page' do
++    login_as admin
++    get :move_topic, id: topic.id
++    must_respond_with :success
++    must_render_template 'topics/move'
++  end
++
++  # TODO: This test is off, verify the behavior
++  # TODO: Will need to figure out how javascript will affect the testing.
+   it 'admin can move a topic' do
+     different_topic = create(:topic)
+     login_as admin",The `move_topic` action be a `post` request since it changes the state of the object.
+4471,"@@ -366,6 +366,9 @@ func doTestResults(tid int, state *core.BuildState, target *core.BuildTarget, ru
+
+ 	if runRemotely {
+ 		metadata, err = state.RemoteClient.Test(tid, target, run)
++		if metadata == nil {
++			metadata = new(core.BuildMetadata)
++		}
+ 	} else {
+ 		var stdout []byte
+ 		stdout, err = prepareAndRunTest(tid, state, target, run)",Should we just return a non-nil metadata from `Test`?
+4472,"@@ -15,6 +15,10 @@ class MailPreview < MailView
+     CommunicartMailer.comment_added_email(comment, email)
+   end
+
++  def whsc_email
++    CommunicartMailer.cart_notification_email(email, pending_approval)
++  end
++
+
+   private
+ ",Noticing this is really just the same as cart_notification_email. Would be nice to be able to view custom templates. I may update this with some set up that will make viewing specific custom emails easily.
+4473,"@@ -59,13 +59,8 @@ import static org.apache.solr.common.cloud.ZkStateReader.PULL_REPLICAS;
+ import static org.apache.solr.common.cloud.ZkStateReader.READ_ONLY;
+ import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR;
+ import static org.apache.solr.common.cloud.ZkStateReader.TLOG_REPLICAS;
+-import static org.apache.solr.common.params.CollectionAdminParams.ALIAS;
+-import static org.apache.solr.common.params.CollectionAdminParams.COLL_CONF;
+-import static org.apache.solr.common.params.CollectionAdminParams.COUNT_PROP;
+-import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_PARAM;
+-import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_SHUFFLE_PARAM;
+-import static org.apache.solr.common.params.CollectionAdminParams.ROUTER_PREFIX;
+-import static org.apache.solr.common.params.CollectionAdminParams.SKIP_NODE_ASSIGNMENT;
++import static org.apache.solr.common.params.CollectionAdminParams.*;
++import static org.apache.solr.common.params.CollectionAdminParams.COLOCATED_WITH;
+
+ /**
+  * This class is experimental and subject to change.",please don't use wildcard imports
+4474,"@@ -219,6 +219,8 @@ describe('Formulas general', () => {
+   });
+
+   it('should recalculate table after changing cell value (by reference)', () => {
++    let sourceDataReference = null;
++
+     const afterChange = jasmine.createSpy();
+     const hot = handsontable({
+       data: getDataSimpleExampleFormulas(),",Should we even fix this test? IMO it should be refactored to check that values are recalculated after `setSourceDataAtCell` and `setSourceDataAtRowProp` calls. This will be the correct way to alter the data since now and we're not testing this use case.
+4475,"@@ -46,11 +46,6 @@ class ModelRole(enum.IntEnum):
+
+     item = Qt.UserRole
+
+-
+-# Remember the last used directory
+-last_used_directory = None
+-
+-
+ # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads
+ # redrawn.
+ _REFRESH_INTERVAL = 500","I'm not sure if this is standard practice, but I would prefer to leave this initialization here, if only to show that such a variable exists in this file (instead of inferring it from the globals). It can also cause weird issues if, for example, `init` isn't run before other methods."
+4476,"@@ -353,6 +353,7 @@ RDKit::SparseIntVect<boost::uint32_t> *MorganFingerprintHelper(
+     res = RDKit::MorganFingerprints::getFingerprint(
+         mol, static_cast<unsigned int>(radius), invars, froms, useChirality,
+         useBondTypes, useCounts, false, bitInfoMap);
++          throw ""Value of nbits is Negative""
+   } else {
+     res = RDKit::MorganFingerprints::getHashedFingerprint(
+         mol, static_cast<unsigned int>(radius),",This isn't how you throw an exception in C++. I'd suggest you take a look elsewhere in the RDKit C++ codebase and see how ValueError exceptions are thrown. Hint: there's a function called `throw_value_error()` that you may find useful.
+4477,"@@ -662,7 +662,7 @@ TEST (active_transactions, restart_dropped)
+ 	}
+ 	// Verify the block was updated in the ledger
+ 	{
+-		auto block (node.store.block_get (node.store.tx_begin_read (), send1->hash ()));
++		auto block (node.store.block_get (node.store.tx_begin_write (), send1->hash ()));
+ 		ASSERT_EQ (work2, block->block_work ());
+ 	}
+ 	// Drop election",Was changing this to a write transaction required?
+4478,"@@ -21,7 +21,8 @@ type Predicate struct {
+ 	Method string `json:""method""`
+
+ 	// Params are the parameters (or a subset of the parameters) used to call the actor method.
+-	Params []byte `json:""params""`
++	// The must all be individually abi encodable.
++	Params []interface{} `json:""params""`
+ }
+
+ // PaymentVoucher is a voucher for a payment channel that can be transferred off-chain but guarantees a future payment.","nit: I think ""They""?"
+4479,"@@ -0,0 +1,7 @@
++namespace Nethermind.Core2
++{
++    public static class SszLimit
++    {
++        public const ulong ValidatorRegistryLimit = 1_099_511_627_776;
++    }
++}",is it a result of some multiplication or some other meaningful number? would be nice to display as a power of something or the mult
+4480,"@@ -5,11 +5,11 @@ module Features
+       forum
+       office_hours
+       shows
+-      source_code
+-      video_tutorials
+     )
++    LICENSEABLE_FEATURES = %w(repositories video_tutorials)
+     FULFILLABLE_FEATURES = %w(mentor)
+-    ALL_FEATURES = GENERIC_FEATURES + FULFILLABLE_FEATURES
++    ALL_FEATURES = GENERIC_FEATURES + LICENSEABLE_FEATURES +
++      FULFILLABLE_FEATURES
+
+     def initialize(user:)
+       @user = user","I think this class is a good example of where Payload could significantly improve things. I'm okay with this class as it stands. If you merge this in, I'd like to have a go at refactoring it after introducing Payload."
+4481,"@@ -2,6 +2,7 @@
+ from __future__ import unicode_literals
+ import unittest
+ import os
++import pytest
+
+ import colander
+ import mock","Just a small tip: I think you don't need to include pytest here. You can run tests using: - `pytest tests/path/to/my/test` under the virtualenv to run a single test. - `pytest tests/` under the virtualenv to run all the tests. - `make tests` to run all the tests for all python versions, like travis do. Hope this helps! :)"
+4482,"@@ -31,6 +31,15 @@ from .options import Store
+ from .util import unique_iterator, group_sanitizer, label_sanitizer
+
+
++def sanitizer(name, replacements={':':'_', '/':'_', '\\':'_'}):
++    """"""
++    String sanitizer to avoid problematic characters in filenames.
++    """"""
++    for k,v in replacements.items():
++        name = name.replace(k,v)
++    return name
++
++
+ class Reference(param.Parameterized):
+     """"""
+     A Reference allows access to an object to be deferred until it is",Might be worth sorting the replacement items so this is deterministic.
+4483,"@@ -29,6 +29,11 @@ type ChaosDashboardConfig struct {
+ 	EnableLeaderElection bool   `envconfig:""ENABLE_LEADER_ELECTION""`
+ 	Database             *DatabaseConfig
+ 	PersistTTL           *PersistTTLConfig
++	// ClusterScoped means control Chaos Object in cluster level(all namespace),
++	ClusterScoped bool `envconfig:""CLUSTER_SCOPED"" default:""true""`
++	// TargetNamespace is the target namespace to injecting chaos.
++	// It only works with ClusterScoped is false;
++	TargetNamespace string `envconfig:""TARGET_NAMESPACE"" default:""""`
+ }
+
+ // PersistTTLConfig defines the configuration of ttl",Should we set the default `TargetNamespace ` to `chaos-testing`? I noticed that the installation script defaults to chaos-testing.
+4484,"@@ -31,7 +31,6 @@ namespace MvvmCross.ViewModels
+         {
+             try
+             {
+-                await Task.Yield();
+                 await task;
+             }
+             catch(Exception e)",Why was this `Task.Yield` removed? It was added in purpose.
+4485,"@@ -162,8 +162,13 @@ public abstract class DiscoGapicMethodConfig extends MethodConfig {
+     }
+
+     Iterable<FieldConfig> requiredFieldConfigs =
+-        DiscoGapicMethodConfig.createFieldNameConfigs(
+-            DiscoGapicMethodConfig.getRequiredFields(
++        createFieldNameConfigs(
++            diagCollector,
++            messageConfigs,
++            defaultResourceNameTreatment,
++            fieldNamePatterns,
++            resourceNameConfigs,
++            getRequiredFields(
+                 diagCollector, methodModel, methodConfigProto.getRequiredFieldsList()));
+
+     Iterable<FieldConfig> optionalFieldConfigs =","You'll also want to do this below, for the `optionalFieldConfigs`. See `GapicMethodConfig.java:180`."
+4486,"@@ -134,7 +134,8 @@ Status GoExecutor::prepareOver() {
+         if (clause == nullptr) {
+             LOG(FATAL) << ""Over clause shall never be null"";
+         }
+-        edge_ = ectx()->schemaManager()->toEdgeType(*clause->edge());
++        auto space = ectx()->rctx()->session()->space();
++        edge_ = ectx()->schemaManager()->toEdgeType(space, *clause->edge());
+         reversely_ = clause->isReversely();
+         if (clause->alias() != nullptr) {
+             expCtx_->addAlias(*clause->alias(), AliasKind::Edge, *clause->edge());","We'd better use ""spaceId"" as variable name here. Because i can't figure out the really type for ""space"" at the first glimpse due to ""auto"" used."
+4487,"@@ -37,6 +37,7 @@ partial class Build
+     AbsolutePath ArtifactsDirectory => Artifacts ?? (OutputDirectory / ""artifacts"");
+     AbsolutePath WindowsTracerHomeZip => ArtifactsDirectory / ""windows-tracer-home.zip"";
+     AbsolutePath BuildDataDirectory => RootDirectory / ""build_data"";
++    AbsolutePath LibSqreenDirectory => RootDirectory / ""packages"" / ""libsqreen.1.1.2.2"";
+
+     AbsolutePath SourceDirectory => RootDirectory / ""src"";
+     AbsolutePath TestsDirectory => RootDirectory / ""test"";",I assume we have a package reference somewhere that pulls down the nuget package?
+4488,"@@ -575,12 +575,9 @@ func (s *Server) initEventTracking() {
+ 	}
+ 	s.sys.inboxPre = subject
+ 	// This is for remote updates for connection accounting.
+-
+-	for _, subj := range []string{accConnsEventSubjOld, accConnsEventSubjNew} {
+-		subject = fmt.Sprintf(subj, ""*"")
+-		if _, err := s.sysSubscribe(subject, s.remoteConnsUpdate); err != nil {
+-			s.Errorf(""Error setting up internal tracking for %s: %v"", subject, err)
+-		}
++	subject = fmt.Sprintf(accConnsEventSubjOld, ""*"")
++	if _, err := s.sysSubscribe(subject, s.remoteConnsUpdate); err != nil {
++		s.Errorf(""Error setting up internal tracking for %s: %v"", subject, err)
+ 	}
+ 	// This will be for responses for account info that we send out.
+ 	subject = fmt.Sprintf(connsRespSubj, s.info.ID)","But why introduce publish on `accConnsEventSubjNew` subject if we never subscribe on that subject. What is the plan then? Replace subscription on ""old"" with ""new"" at one point? Not sure about all that.."
+4489,"@@ -269,7 +269,7 @@ void *ap6_thread(void *thread_context)
+ 	int ret;
+ 	struct timespec ts = { .tv_sec = 0, .tv_nsec = 100000 }; /* 100ms */
+
+-	fpga_token fme_token;
++	fpga_token fme_token = NULL;
+ 	fpga_handle fme_handle;
+ 	fpga_properties filter;
+ 	fpga_result res;",can we use `nullptr` for consistency?
+4490,"@@ -38,7 +38,7 @@ class DomainRouterFactory
+     protected $routerConfiguration;
+
+     /**
+-     * @var \Symfony\Component\Routing\Router[]
++     * @var \Shopsys\FrameworkBundle\Component\Router\DomainRouter[]
+      */
+     protected $routersByDomainId = [];
+ ","strange, for templating\EngineBundle it was `\Symfony\Bundle\FrameworkBundle\`"
+4491,"@@ -1545,7 +1545,7 @@ ostree_sysroot_simple_write_deployment (OstreeSysroot      *sysroot,
+           g_ptr_array_add (new_deployments, g_object_ref (deployment));
+         }
+
+-      if (!added_new)
++      if ((!added_new) && is_merge_or_booted)
+         {
+           g_ptr_array_add (new_deployments, g_object_ref (new_deployment));
+           added_new = TRUE;","But if we're on the merge deployment, and the next one is the booted deployment, we'll still be inserting between the merge and booted deployment, right? It seems like we would need e.g. `met_merge` and `met_booted` vars to keep track."
+4492,"@@ -1,3 +1,7 @@
+-return !axe.commons.aria.isValidRole(node.getAttribute('role'), {
+-	allowAbstract: true
+-});
++return (
++	axe.utils.tokenList(virtualNode.attr('role')).filter(role => {
++		return !axe.commons.aria.isValidRole(role, {
++			allowAbstract: true
++		});
++	}).length > 0
++);","Can you put the output of this into data, and list which roles are invalid? Same thing with abstract role. I know that's not strictly part of this PR, but it'd make the messaging about this a bunch better."
+4493,"@@ -20,15 +20,15 @@ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.tests.acceptance.dsl.WaitUtils;
+ import org.hyperledger.besu.tests.acceptance.dsl.condition.Condition;
+ import org.hyperledger.besu.tests.acceptance.dsl.node.Node;
+-import org.hyperledger.besu.tests.acceptance.dsl.transaction.ibft2.Ibft2Transactions;
++import org.hyperledger.besu.tests.acceptance.dsl.transaction.bft.BftTransactions;
+
+ import java.util.Map;
+
+ public class ExpectProposals implements Condition {
+-  private final Ibft2Transactions ibftTwo;
++  private final BftTransactions ibftTwo;
+   private final Map<Address, Boolean> proposers;
+
+-  public ExpectProposals(final Ibft2Transactions ibftTwo, final Map<Address, Boolean> proposers) {
++  public ExpectProposals(final BftTransactions ibftTwo, final Map<Address, Boolean> proposers) {
+     this.ibftTwo = ibftTwo;
+     this.proposers = proposers;
+   }",rename ibftTwo arg to bft
+4494,"@@ -38,7 +38,7 @@ module Blacklight::SearchContext
+   end
+
+   def find_search_session
+-    if agent_is_crawler?
++    if agent_is_crawler? || skip_session_tracking?
+       nil
+     elsif params[:search_context].present?
+       find_or_initialize_search_session_from_params JSON.parse(params[:search_context])",Should we go ahead and push `agent_is_crawler?` into the `skip_session_tracking?` method?
+4495,"@@ -88,8 +88,11 @@ class CustomDataset(Dataset):
+                 self.proposal_file = osp.join(self.data_root,
+                                               self.proposal_file)
+         # load annotations (and proposals)
+-        with self.file_client.get_local_path(self.ann_file) as local_path:
+-            self.data_infos = self.load_annotations(local_path)
++        try:
++            with self.file_client.get_local_path(self.ann_file) as local_path:
++                self.data_infos = self.load_annotations(local_path)
++        except AttributeError:
++            raise AttributeError('Please upgrade mmcv to >= 1.3.16')
+
+         if self.proposal_file is not None:
+             with self.file_client.get_local_path(",How about we raise a warning here and simply change to use self.data_infos = self.load_annotations(self.ann_file)
+4496,"@@ -1,9 +1,9 @@
+ # -*- coding: UTF-8 -*-
+-#synthDrivers/_espeak.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2007-2017 NV Access Limited, Peter Vágner
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# synthDrivers/_espeak.py
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2007-2020 NV Access Limited, Peter Vágner
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+ import time
+ import nvwave",Please remove this line to comply with the standard for copyright headers.
+4497,"@@ -21,6 +21,9 @@ namespace Nethermind.Consensus.AuRa.Validators
+ {
+     internal static class AuRaValidatorsCollectionExtensions
+     {
+-        public static int MinSealersForFinalization(this IList<Address> validators) => validators.Count / 2 + 1;
++        public static int MinSealersForFinalization(this IList<Address> validators, bool twoThirds = false)
++        {
++            return (twoThirds ? validators.Count * 2 / 3 : validators.Count / 2) + 1;
++        }
+     }
+ }",seems incorrect - for 5 validators it will tell that 3 is enough to seal and you need 4 2/3 * 5 is 3.3
+4498,"@@ -19,11 +19,16 @@
+
+ package org.apache.iceberg.hive;
+
+-import java.io.Closeable;
+-import java.util.Arrays;
++
++import com.github.benmanes.caffeine.cache.Cache;
++import com.github.benmanes.caffeine.cache.Caffeine;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.Set;
++import java.util.concurrent.Executors;
++import java.util.concurrent.ScheduledExecutorService;
++import java.util.concurrent.ScheduledFuture;
++import java.util.concurrent.TimeUnit;
+ import java.util.stream.Collectors;
+ import org.apache.hadoop.conf.Configurable;
+ import org.apache.hadoop.conf.Configuration;",Nit: please remove unnecessary whitespace changes.
+4499,"@@ -73,9 +73,16 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
+
+     List<SampleFieldView> fields = new ArrayList<>();
+     for (FieldInfo field : methodInfo.fields().values()) {
++      String name = field.name();
++      // Since the requestBody is named `resource`, all fields named `resource`
++      // are renamed by the Node.js client library generator to `resource_`.
++      if (name.equals(""resource"")) {
++        name = ""resource_"";
++      }
++
+       fields.add(
+           SampleFieldView.newBuilder()
+-              .name(field.name())
++              .name(name)
+               .defaultValue(typeTable.getZeroValueAndSaveNicknameFor(field.type()))
+               .example(field.example())
+               .description(field.description())",Is this captured in a test?
+4500,"@@ -38,9 +38,10 @@ import org.apache.lucene.search.MaxScoreAccumulator.DocAndScore;
+  */
+ public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
+
+-  abstract static class ScorerLeafCollector implements LeafCollector {
++  /** Scorable leaf collector */
++  public abstract static class ScorerLeafCollector implements LeafCollector {
+
+-    Scorable scorer;
++    protected Scorable scorer;
+
+     @Override
+     public void setScorer(Scorable scorer) throws IOException {",This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.
+4501,"@@ -1,11 +1,11 @@
+ # optimizer
+ optimizer = dict(type='SGD', lr=0.02, momentum=0.9, weight_decay=0.0001)
+-optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
++optimizer_config = dict(grad_clip=None)
+ # learning policy
+ lr_config = dict(
+     policy='step',
+     warmup='linear',
+     warmup_iters=500,
+-    warmup_ratio=1.0 / 3,
++    warmup_ratio=1.0 / 1000,
+     step=[8, 11])
+ total_epochs = 12",We may also do the same for `schedule_2x.py` and `schedule_20e.py`.
+4502,"@@ -4,6 +4,7 @@ class User < ActiveRecord::Base
+   has_many :traces, -> { where(:visible => true) }
+   has_many :diary_entries, -> { order(:created_at => :desc) }
+   has_many :diary_comments, -> { order(:created_at => :desc) }
++  has_and_belongs_to_many :diary_entries_subscriptions, :class_name => ""DiaryEntry"", :join_table => ""diary_entries_subscribers"", :foreign_key => ""subscriber_id""
+   has_many :messages, -> { where(:to_user_visible => true).order(:sent_on => :desc).preload(:sender, :recipient) }, :foreign_key => :to_user_id
+   has_many :new_messages, -> { where(:to_user_visible => true, :message_read => false).order(:sent_on => :desc) }, :class_name => ""Message"", :foreign_key => :to_user_id
+   has_many :sent_messages, -> { where(:from_user_visible => true).order(:sent_on => :desc).preload(:sender, :recipient) }, :class_name => ""Message"", :foreign_key => :from_user_id","Should foreign key here be something like `diary_entry_id`? Or above, in `diary_entry.rb`, it should be `diary_entry_id`?"
+4503,"@@ -54,12 +54,13 @@ type (
+ 		namespaceEntry          *cache.NamespaceCacheEntry
+
+ 		// internal state
+-		hasBufferedEvents           bool
+-		failWorkflowTaskInfo        *failWorkflowTaskInfo
+-		activityNotStartedCancelled bool
+-		continueAsNewBuilder        mutableState
+-		stopProcessing              bool // should stop processing any more commands
+-		mutableState                mutableState
++		hasBufferedEvents                 bool
++		failWorkflowTaskInfo              *failWorkflowTaskInfo
++		activityNotStartedCancelled       bool
++		continueAsNewBuilder              mutableState
++		stopProcessing                    bool // should stop processing any more commands
++		mutableState                      mutableState
++		initiatedChildExecutionsInSession map[string]struct{} // Set of initiated child executions in the workflow task
+
+ 		// validation
+ 		attrValidator    *commandAttrValidator",session is a new term. Should we call more like currentCommandBatch or something else?
+4504,"@@ -514,7 +514,7 @@ func (s *namespaceHandlerGlobalNamespaceEnabledNotMasterClusterSuite) TestUpdate
+ 	_, err := s.MetadataManager.CreateNamespace(&persistence.CreateNamespaceRequest{
+ 		Namespace: &persistenceblobs.NamespaceDetail{
+ 			Info: &persistenceblobs.NamespaceInfo{
+-				Id:          uuid.NewRandom(),
++		Id:          uuid.New(),
+ 				Name:        namespace,
+ 				Status:      namespacepb.NamespaceStatus_Registered,
+ 				Description: description,",Will go fmt before squash.
+4505,"@@ -148,6 +148,7 @@ func DefaultConfig() Config {
+ 		DockerGraphPath:         ""/var/lib/docker"",
+ 		ReservedMemory:          0,
+ 		AvailableLoggingDrivers: []dockerclient.LoggingDriver{dockerclient.JsonFileDriver},
++		PrivilegedCapable:       true,
+ 	}
+ }
+ ","Setting this to `true` means that it will always get merged in. The way merging is done here is that if a value is its zero value (`false` for `bool`), the value is considered unchanged. In order for this to work, you'll need to change this to be a `*bool` type instead."
+4506,"@@ -101,7 +101,6 @@ func newDefaultBootstrapConfig() *BootstrapConfig {
+ // MiningConfig holds all configuration options related to mining.
+ type MiningConfig struct {
+ 	MinerAddress            address.Address `json:""minerAddress""`
+-	BlockSignerAddress      address.Address `json:""blockSignerAddress""`
+ 	AutoSealIntervalSeconds uint            `json:""autoSealIntervalSeconds""`
+ 	StoragePrice            *types.AttoFIL  `json:""storagePrice""`
+ }","It was decided that blockSignerAddress is not only redundant (use the miner owner public key instead which is already stored), but does not belong in config."
+4507,"@@ -70,6 +70,7 @@ setup(
+         'tenacity>=5.1.1',
+         'tqdm>=4.32',
+         'requests_futures==1.0.0',
++        'jsonschema==3.*',
+     ],
+     extras_require={
+         'pyarrow': [",are we not asking for trouble here by not pinning this? or does 3.* imply all of the draft versions we'd try to validate?
+4508,"@@ -39,10 +39,8 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
+     results1 = createAndRunNetwork(TPRegion,
+                                    ""bottomUpOut"",
+                                    checkpointMidway=False,
+-                                   temporalImp=""tm_py"")
++                                   temporalImp=""tm_cpp"")
+
+-    # temporalImp=""tm_py"" here is a temporary placeholder value until C++ TM is
+-    # finished, at which point it should be changed to ""cpp""
+     results2 = createAndRunNetwork(TPRegion,
+                                    ""bottomUpOut"",
+                                    checkpointMidway=False,","No, we want to compare `tm_py` and `tm_cpp` in this test."
+4509,"@@ -47,6 +47,9 @@ const (
+ 	// TODO(liu-cong) configurable timeout
+ 	decoupleSinkTimeout = 30 * time.Second
+
++	// Limit for request payload in bytes (100Mb)
++	maxRequestBodyBytes = 100000000
++
+ 	// EventArrivalTime is used to access the metadata stored on a
+ 	// CloudEvent to measure the time difference between when an event is
+ 	// received on a broker and before it is dispatched to the trigger function.",Let me know if we'd rather have this as an env variable.
+4510,"@@ -80,10 +80,10 @@ func NewVaultServiceAccount(name string) *corev1.ServiceAccount {
+ 	}
+ }
+
+-func NewVaultServiceAccountRole(namespace string) *rbacv1.ClusterRole {
++func NewVaultServiceAccountRole(namespace, serviceAccountName string) *rbacv1.ClusterRole {
+ 	return &rbacv1.ClusterRole{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: fmt.Sprintf(""auth-delegator:%s:vault"", namespace),
++			Name: fmt.Sprintf(""auth-delegator:%s:%s"", namespace, serviceAccountName),
+ 		},
+ 		Rules: []rbacv1.PolicyRule{
+ 			{",question: what is happening here?
+4511,"@@ -14,6 +14,8 @@ public abstract class AbstractSetTest extends AbstractTraversableRangeTest {
+     @Override
+     abstract protected <T> Set<T> empty();
+
++    abstract protected <T> Set<T> emptyWithNull();
++
+     @Override
+     abstract protected <T> Set<T> of(T element);
+ ",\[Checkstyle\] ERROR: 'protected' modifier out of order with the JLS suggestions\.
+4512,"@@ -4,6 +4,18 @@ const chai = require('chai');
+ const expect = chai.expect;
+ chai.use(require('chai-subset'));
+
++const EJSON = require('mongodb-extjson');
++const getKmsProviders = localKey => {
++  const result = EJSON.parse(process.env.CSFLE_KMS_PROVIDERS || 'NOT_PROVIDED');
++  if (localKey) {
++    result.local = { key: localKey };
++  }
++
++  return result;
++};
++
++const noop = () => {};
++
+ // Tests for the ClientEncryption type are not included as part of the YAML tests.
+
+ // In the prose tests LOCAL_MASTERKEY refers to the following base64:",Can we use EJSON from bson here? and in doing so avoid bringing in the deprecated `mongodb-extjson` lib `const { EJSON } = require('bson')`
+4513,"@@ -262,9 +262,6 @@ class GridPlot(CompositePlot):
+     show_legend = param.Boolean(default=False, doc=""""""
+         Legends add to much clutter in a grid and are disabled by default."""""")
+
+-    tick_format = param.String(default=""%.2f"", doc=""""""
+-        Formatting string for the GridPlot ticklabels."""""")
+-
+     xaxis = param.ObjectSelector(default='bottom',
+                                  objects=['bottom', 'top', None], doc=""""""
+         Whether and where to display the xaxis, supported options are",So this parameter is now deprecated?
+4514,"@@ -269,6 +269,7 @@ rseq_shared_fragment_flushtime_update(dcontext_t *dcontext)
+     rseq_clear_tls_ptr(dcontext);
+ }
+
++#ifdef HAVE_RSEQ
+ bool
+ rseq_is_registered_for_current_thread(void)
+ {","Actually, it looks like HAVE_RSEQ is only used to determine whether the rseq.h header is around, which then only determines whether the regression test is built: it does not affect whether the core handles an application using rseq. The core rseq mangling code and all the code in rseq_linux.c is always enabled. I believe the idea is that we want DR built on one machine to work on as many others as possible, rather than requiring a custom build for every variant of kernel feature or whatnot. What is the top-level problem being solved here? If it requires disabling or enabling the core handling rseq, probably a separate option should be put in place and maybe HAVE_RSEQ renamed to make it clearer what its consequences are."
+4515,"@@ -3,8 +3,7 @@ package cache
+ import (
+ 	""sync""
+
+-	""github.com/gofrs/uuid""
+-	""github.com/spiffe/spire/pkg/common/selector""
++	""github.com/spiffe/spire/proto/spire/common""
+ )
+
+ type Subscriber interface {",I don't see a corresponding call to freeSelectorSet... am I missing something?
+4516,"@@ -2,13 +2,13 @@ require ""rails_helper""
+
+ describe AuthCallbacksController do
+   context '#create' do
+-    it 'redirects to the dashboard path without an auth origin' do
++    it 'redirects to the practice path without an auth origin' do
+       request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:github]
+       request.env['omniauth.origin'] = nil
+
+       get :create, provider: 'github'
+
+-      should redirect_to(dashboard_url)
++      should redirect_to(practice_url)
+     end
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+4517,"@@ -40,9 +40,10 @@ namespace OpenTelemetry.Trace
+         public const string HttpRouteKey = ""http.route"";
+         public const string HttpFlavorKey = ""http.flavor"";
+
+-        public const string DatabaseTypeKey = ""db.type"";
+-        public const string DatabaseInstanceKey = ""db.instance"";
++        public const string DatabaseSystemKey = ""db.system"";
++        public const string DatabaseNameKey = ""db.name"";
+         public const string DatabaseStatementKey = ""db.statement"";
++        public const string DatabaseStatementTypeKey = ""db.statement_type"";
+ #pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+     }
+ }",Is this part of spec?
+4518,"@@ -3725,6 +3725,18 @@ client_thread_run(void)
+     byte *xsp;
+     GET_STACK_PTR(xsp);
+     void *crec = get_clone_record((reg_t)xsp);
++    /* i#2335: we support setup separate from start, and we want to allow a client
++     * to create a client thread during init, but we do not support that thread
++     * executing until the app has started (b/c we have no signal handlers in place).
++     */
++    /* i#3973: in addition to _executing_ a client thread before the
++     * app has started, if we even create the thread before
++     * dynamo_initialized is set, we will not copy tls blocks.  By
++     * waiting for the app to be started before dynamo_thread_init is
++     * called, we ensure this race condition can never happen, since
++     * dynamo_initialized will always be set before the app is started.
++     */
++    wait_for_event(dr_app_started, 0);
+     IF_DEBUG(int rc =)
+     dynamo_thread_init(get_clone_record_dstack(crec), NULL, crec, true);
+     ASSERT(rc != -1); /* this better be a new thread */","Hmm, do we need to do this for Windows too? It won't have this private loader TLS issue but it will run DR code in a separate thread before DR init is fully done which I think violates some assumptions. For Windows we would move this wait from win32/os.c to win32/callback.s intercept_new_thread where it checks whether it's a client thread right before calling dynamo_thread_init. If you do not want to deal with Windows you could bail on my suggestion and leave the issue open (or maybe file a new issue) for Windows, or if you want to put the suggested core/win32/ change in place and your new test passes on Appveyor we could then claim to have fully solved this related issue too for all platforms."
+4519,"@@ -840,3 +840,8 @@ def kinesis_get_latest_records(stream_name, shard_id, count=10, env=None):
+         while len(result) > count:
+             result.pop(0)
+     return result
++
++
++def get_lambda_name_from_arn(arn):
++    attributes = arn.split(':')
++    return attributes[-1]",We can remove this function and use `lambda_function_name(..)` in this file instead.
+4520,"@@ -17,10 +17,12 @@
+
+ package metrics
+
+-import ""time""
++import (
++	""time""
++)
+
+-// CreateSender creates metrics sender with appropriate transport
+-func CreateSender(disableMetrics bool, metricsAddress string) *Sender {
++// NewSender creates metrics sender with appropriate transport
++func NewSender(disableMetrics bool, metricsAddress, applicationVersion string) *Sender {
+ 	var transport Transport
+ 	if disableMetrics {
+ 		transport = NewNoopTransport()",nitpick: `ApplicationVersion` could be `AppVersion`. It's smaller but gives the same understanding for purposes of the field.
+4521,"@@ -537,6 +537,9 @@ func (handler *DCRedirectionHandlerImpl) PollWorkflowTaskQueue(
+ 		return err
+ 	})
+
++	if resp == nil && err == nil {
++		return &workflowservice.PollWorkflowTaskQueueResponse{}, nil
++	}
+ 	return resp, err
+ }
+ ",nit: maybe prefer `resp = &workflowservice.PollWorkflowTaskQueueResponse{}` over adding another function exit points especially for non-error cases?
+4522,"@@ -107,6 +107,10 @@ module Mongoid
+     #
+     # @since 6.0.0
+     def client
++      client_options = send(:client_options)
++      if client_options[:read].is_a?(Symbol)
++        client_options = client_options.merge(read: {mode: client_options[:read]})
++      end
+       @client ||= (client = Clients.with_name(client_name)
+                     client = client.use(database_name) if database_name_option
+                     client.with(client_options))","Do we specifically need to keep the read preference as a symbol for use elsewhere? If not, I think it would be cleaner to just modify the options before caching them in the `client_options` method so that we don't do this check every time. If we do need it a a symbol elsewhere, I'd suggest either putting `return @client if @client` at the top of the method (and changing the assignment below from `||=` to `=`) or moving this within the parenthetical block in the last assignment so that we don't repeat this work."
+4523,"@@ -69,7 +69,8 @@ module.exports = class Webcam extends Plugin {
+         'picture'
+       ],
+       mirror: true,
+-      facingMode: 'user'
++      facingMode: 'user',
++      preferredMimeType: null
+     }
+
+     // merge default options with the ones set by user","Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option."
+4524,"@@ -398,6 +398,8 @@ static bool ImageLayoutMatches(const VkImageAspectFlags aspect_mask, VkImageLayo
+
+ // Utility type for ForRange callbacks
+ struct LayoutUseCheckAndMessage {
++    using LayoutEntry = image_layout_map::ImageSubresourceLayoutMap::LayoutEntry;
++    using RangeGenerator = image_layout_map::ImageSubresourceLayoutMap::LayoutEntry;
+     const static VkImageAspectFlags kDepthOrStencil = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT;
+     const ImageSubresourceLayoutMap *layout_map;
+     const VkImageAspectFlags aspect_mask;",That doesn't make sense. LayoutEntry doesn't match the generator concept.
+4525,"@@ -284,7 +284,7 @@ func TestAppDeployOpts_getAppDockerfilePath(t *testing.T) {
+
+ 	mockError := errors.New(""mockError"")
+ 	mockManifest := []byte(`name: appA
+-type: 'Load Balanced Web App'
++type: 'Load Balanced Web Svc'
+ image:
+   build: appA/Dockerfile
+ `)","I think the customer visible strings should be ""Service"" instead of ""Svc"" to make it obvious to them"
+4526,"@@ -108,13 +108,13 @@ public class JavaProcessJobTest {
+     props.put(AbstractProcessJob.WORKING_DIR, workingDir.getCanonicalPath());
+     props.put(""type"", ""java"");
+     props.put(""fullPath"", ""."");
+-
++
+     props.put(CommonJobProperties.PROJECT_NAME, ""test_project"");
+     props.put(CommonJobProperties.FLOW_ID, ""test_flow"");
+     props.put(CommonJobProperties.JOB_ID, ""test_job"");
+     props.put(CommonJobProperties.EXEC_ID, ""123"");
+     props.put(CommonJobProperties.SUBMIT_USER, ""test_user"");
+-
++    props.put(""execute.as.user"", ""false"");
+
+     job = new JavaProcessJob(""testJavaProcess"", props, props, log);
+   }",Explain why this property is necessary?
+4527,"@@ -141,7 +141,8 @@ func securityDeposit(ps *EVMParams, stateDB vm.StateDB, gasLimit *uint64) error
+ func ExecuteContracts(blk *Block, ws state.WorkingSet, bc Blockchain) {
+ 	gasLimit := GasLimit
+ 	blk.receipts = make(map[hash.Hash32B]*Receipt)
+-	for idx, execution := range blk.Executions {
++	_, _, executions := action.ClassifyActions(blk.Actions)
++	for idx, execution := range executions {
+ 		// TODO (zhi) log receipt to stateDB
+ 		if receipt, _ := executeContract(blk, ws, idx, execution, bc, &gasLimit); receipt != nil {
+ 			blk.receipts[execution.Hash()] = receipt",It should accept executions as the input
+4528,"@@ -25,7 +25,10 @@ def single_gpu_test(model,
+         with torch.no_grad():
+             result = model(return_loss=False, rescale=True, **data)
+
++        batch_size = len(result)
+         if show or out_dir:
++            assert batch_size == 1, 'show or out during test only support ' \
++                                    'batch size of 1'
+             img_tensor = data['img'][0]
+             img_metas = data['img_metas'][0].data[0]
+             imgs = tensor2imgs(img_tensor, **img_metas[0]['img_norm_cfg'])",Is this limitation necessary?
+4529,"@@ -81,9 +81,13 @@ type IssuerSpec struct {
+ }
+
+ type IssuerConfig struct {
+-	ACME  *ACMEIssuer  `json:""acme,omitempty""`
+-	CA    *CAIssuer    `json:""ca,omitempty""`
+-	Vault *VaultIssuer `json:""vault,omitempty""`
++	ACME       *ACMEIssuer       `json:""acme,omitempty""`
++	CA         *CAIssuer         `json:""ca,omitempty""`
++	Vault      *VaultIssuer      `json:""vault,omitempty""`
++	SelfSigned *SelfSignedIssuer `json:""selfSigned,omitempty""`
++}
++
++type SelfSignedIssuer struct {
+ }
+
+ type VaultIssuer struct {",:question: Should there be validation to ensure that only one of these attributes is used?
+4530,"@@ -33,11 +33,11 @@
+  */
+ namespace VuFind\Search\Solr;
+
++use Interop\Container\ContainerInterface;
+ use Laminas\EventManager\EventInterface;
+-
+ use Laminas\EventManager\SharedEventManagerInterface;
+-use Laminas\ServiceManager\ServiceLocatorInterface;
+-use VuFindSearch\Backend\BackendInterface;
++
++use VuFindSearch\Backend\Solr\Backend;
+
+ /**
+  * Solr merged record handling listener.","I would recommend using Psr\Container\ContainerInterface here instead of Interop\Container\ContainerInterface; both currently work, but the Interop version is deprecated and will eventually be removed, so using the Psr version will save us time in the future."
+4531,"@@ -312,7 +312,7 @@ func TestLocalExec(t *testing.T) {
+ 		err = app.Exec(""web"", true, ""pwd"")
+ 		assert.NoError(err)
+ 		out := stdout()
+-		assert.Contains(out, ""/var/www/html/docroot"")
++		assert.Contains(out, ""/var/www/html"")
+
+ 		stdout = testcommon.CaptureStdOut()
+ 		switch app.GetType() {",This would also change back to /var/www/html/docroot if we go that way.
+4532,"@@ -12,7 +12,7 @@ import info.nightscout.androidaps.MainApp;
+  */
+
+ public class SP {
+-    private static SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(MainApp.instance().getApplicationContext());
++    public static SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(MainApp.instance().getApplicationContext());
+
+     static public Map<String, ?> getAll() {
+         return sharedPreferences.getAll();","Does this need to be public? Can't one of the helper functions below pass the data? If it really needs to be public, could it be write-protected?"
+4533,"@@ -216,11 +216,6 @@ func RunAPIAndWait(ctx context.Context, nd *node.Node, config *config.APIConfig,
+ }
+
+ func CreateServerEnv(ctx context.Context, nd *node.Node) *Env {
+-	var storageAPI *storage.API
+-	if nd.StorageProtocol != nil {
+-		storageAPI = storage.NewAPI(nd.StorageProtocol.StorageClient, nd.StorageProtocol.StorageProvider, nd.PieceManager())
+-	}
+-
+ 	return &Env{
+ 		blockMiningAPI: nd.BlockMining.BlockMiningAPI,
+ 		drandAPI:       nd.DrandAPI,","Thanks. Now that you've improved this we should just init and expose the StorageAPI on the node, like the other.s"
+4534,"@@ -116,6 +116,15 @@ public class Key implements Comparable<Key> {
+     return toRawKey(Arrays.copyOf(value, value.length + 1));
+   }
+
++  /**
++   * nextPrefix key will be key with next available rid.
++   *
++   * @return a new key current rid+1.
++   */
++  public Key nextPrefix() {
++    return toRawKey(prefixNext(value));
++  }
++
+   /**
+    * The prefixNext key for bytes domain
+    *",it will be better if you can provide some examples
+4535,"@@ -21,6 +21,8 @@ public abstract class LongRunningOperationDetailView {
+
+   public abstract String operationReturnType();
+
++  public abstract String operationResponseType();
++
+   public static Builder newBuilder() {
+     return new AutoValue_LongRunningOperationDetailView.Builder();
+   }","""return type"" and ""response type"" have never really been contrasted before, and it's unclear what their meaning is here. Could you clarify?"
+4536,"@@ -10,6 +10,7 @@ import sys
+ import traceback
+ import subprocess
+ import shlex
++import json
+
+ # TODO: This is a cross-subpackage import!
+ from libcodechecker.log import build_action",Import order has been violated here.
+4537,"@@ -250,11 +250,14 @@ func (api *API) MessagePreview(ctx context.Context, from, to address.Address, me
+ // it does not change any state. It is use to interrogate actor state. The from address
+ // is optional; if not provided, an address will be chosen from the node's wallet.
+ func (api *API) MessageQuery(ctx context.Context, optFrom, to address.Address, method types.MethodID, baseKey block.TipSetKey, params ...interface{}) ([][]byte, error) {
+-	snapshot, err := api.actorState.Snapshot(ctx, baseKey)
+-	if err != nil {
+-		return [][]byte{}, err
+-	}
+-	return snapshot.Query(ctx, optFrom, to, method, params...)
++	// Dragons: delete
++
++	// snapshot, err := api.actorState.Snapshot(ctx, baseKey)
++	// if err != nil {
++	// 	return [][]byte{}, err
++	// }
++	// return snapshot.Query(ctx, optFrom, to, method, params...)
++	return [][]byte{}, nil
+ }
+
+ // Snapshot returns a interface to the chain state a a particular tipset",Are you suggesting deleting the concept of message querying from plumbing (sounds like more trouble than its worth) or suggesting deleting the snapshot based implementation?
+4538,"@@ -114,6 +114,9 @@ func addJoinOtherFlags(cmd *cobra.Command, joinOptions *types.JoinOptions) {
+
+ 	cmd.Flags().StringVar(&joinOptions.TarballPath, types.TarballPath, joinOptions.TarballPath,
+ 		""Use this key to set the temp directory path for KubeEdge tarball, if not exist, download it"")
++
++	cmd.Flags().StringVarP(&joinOptions.Labels, types.Labels, ""l"", joinOptions.Labels,
++		`use this key to set the customized labels for node. you can input customized labels like {""key1"":""value1"", ""key2"":""value2""}`)
+ }
+
+ // newJoinOptions returns a struct ready for being used for creating cmd join flags.","I recommend using StringSliceVarP to resolve the label flag, like `-l key1=value1,key2=value2`. What do you think?"
+4539,"@@ -711,6 +711,18 @@ class Form extends WidgetBase
+             }
+         }
+     }
++    /**
++     * Add tab icons
++     *
++     * @param array $icons
++     * @return void
++     */
++    public function addTabIcons(array $icons)
++    {
++        $this->allTabs->primary->icons = $icons;
++        $this->allTabs->secondary->icons = $icons;
++        $this->allTabs->outside->icons = $icons;
++    }
+
+     /**
+      * Add tab fields.","@Samuell1 Will assigning the same icons array to all the tabs result in, for example, a primary tab called ""Colours"" and secondary tab called ""Colours"" having the same icon?"
+4540,"@@ -437,6 +437,9 @@ def initTranslation():
+ 	finally:
+ 		del callerFrame # Avoid reference problems with frames (per python docs)
+
++def getTranslatedMessage(translatedMessage):
++	return _(translatedMessage)
++
+ def _translatedManifestPaths(lang=None, forBundle=False):
+ 	if lang is None:
+ 		lang = languageHandler.getLanguage() # can't rely on default keyword arguments here.",A docstring for this function please.
+4541,"@@ -0,0 +1,12 @@
++using System;
++using System.Collections.Generic;
++using System.Text;
++using Microsoft.AspNetCore.Hosting.Server.Features;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
++{
++    internal class ServerAddressesFeature : IServerAddressesFeature
++    {
++        public ICollection<string> Addresses { get; } = new List<string>();
++    }
++}",heads up @JunTaoLuo
+4542,"@@ -167,12 +167,12 @@ namespace NLog
+                 if (SkipAssembly(stackFrame))
+                     continue;
+
+-                if (stackFrame.GetMethod().Name == ""MoveNext"")
++                if (stackFrame.GetMethod()?.Name == ""MoveNext"")
+                 {
+                     if (stackFrames.Length > i)
+                     {
+                         var nextStackFrame = stackFrames[i + 1];
+-                        var declaringType = nextStackFrame.GetMethod().DeclaringType;
++                        var declaringType = nextStackFrame.GetMethod()?.DeclaringType;
+                         if (declaringType == typeof(System.Runtime.CompilerServices.AsyncTaskMethodBuilder) ||
+                             declaringType == typeof(System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>))
+                         {",".GetMethod() cannot return null now, correct?"
+4543,"@@ -11,7 +11,7 @@ define(['events', 'playbackManager', 'dom', 'browser', 'css!./iconosd', 'materia
+     function getOsdElementHtml() {
+         var html = '';
+
+-        html += '<i class=""material-icons iconOsdIcon volume_up""></i>';
++        html += '<i class=""material-icons iconOsdIcon""></i>';
+
+         html += '<div class=""iconOsdProgressOuter""><div class=""iconOsdProgressInner""></div></div>';
+ ","Same thing here, I think the proper fix is elsewhere."
+4544,"@@ -585,6 +585,17 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
+                    openType //
+                    );
+
++                if ((retcode < 0) &&
++                    ((errno == ENOENT) || (errno == EAGAIN)))
++                  {
++                    ComDiagsArea * diagsArea = NULL;
++                    ExRaiseSqlError(getHeap(), &diagsArea,
++                                    (ExeErrorCode)(EXE_HIVE_DATA_MOD_CHECK_ERROR));
++                    pentry_down->setDiagsArea(diagsArea);
++                    step_ = HANDLE_ERROR_AND_DONE;
++                    break;
++                  }
++
+                 // preopen next range.
+                 if ( (currRangeNum_ + 1) < (beginRangeNum_ + numRanges_) )
+                   {","errno is a global variable that might be set by any system library call. It is dangerous to rely on it except right after the system call where it is set. But in this code, it looks like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the latter function saved errno after whatever system library call it calls, and returns that as an ""out"" parameter, which this code could then check."
+4545,"@@ -50,7 +50,8 @@ class PackageNode(object):
+     def __repr__(self):
+         finfo = self._package.get_path()[:-len(PackageStore.PACKAGE_FILE_EXT)]
+         pinfo = self._prefix
+-        return ""<%s %r %r>"" % (self.__class__.__name__, finfo, pinfo)
++        kinfo = '\n'.join(self._keys()) if hasattr(self, '_keys') else ''
++        return ""<%s %r:%r>\n%s"" % (self.__class__.__name__, finfo, pinfo, kinfo)
+
+
+ class GroupNode(PackageNode):",`hasattr` is kinda terrible; just append extra info in the subclass.
+4546,"@@ -75,6 +75,16 @@ DAY = HOUR * 24
+ WEEK = DAY * 7
+ MONTH = DAY * 31
+ YEAR = DAY * 365
++
++# Set a flag to indicate whether the '%l' option can be used safely.
++# On Windows, in particular the %l option in strftime is not supported.
++#(It is not one of the documented Python formatters).
++try:
++    datetime.now().strftime(""%a %l%p"")
++    percent_l_supported = True
++except ValueError, e:
++    percent_l_supported = False
++
+ xAxisConfigs = (
+   dict(seconds=0.00,  minorGridUnit=SEC,  minorGridStep=5,  majorGridUnit=MIN,  majorGridStep=1,  labelUnit=SEC,  labelStep=5,  format=""%H:%M:%S"", maxInterval=10*MIN),
+   dict(seconds=0.07,  minorGridUnit=SEC,  minorGridStep=10, majorGridUnit=MIN,  majorGridStep=1,  labelUnit=SEC,  labelStep=10, format=""%H:%M:%S"", maxInterval=20*MIN),","Fair warning, the way that exception block is written won't work in python3 Python 3.2.3 (default, Jun 8 2012, 05:36:09) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type ""help"", ""copyright"", ""credits"" or ""license"" for more information. > > > try: > > > ... raise ValueError(""foo"") > > > ... except ValueError,e: > > > File ""<stdin>"", line 3 > > > except ValueError, e: > > > ^ > > > SyntaxError: invalid syntax"
+4547,"@@ -43,12 +43,15 @@ module Beaker
+         end
+         port = container.json[""NetworkSettings""][""Ports""][""22/tcp""][0][""HostPort""]
+
++        forward_ssh_agent = @options['forward_ssh_agent'] || false
++
+         # Update host metadata
+         host['ip']  = ip
+         host['port'] = port
+         host['ssh']  = {
+           :password => root_password,
+           :port => port,
++          :forward_agent => forward_ssh_agent,
+         }
+
+         @logger.debug(""node available as  ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@#{ip} -p #{port}"")",This only updates the metadata and not the actual thing you are trying to solve for the docker hypervisor.
+4548,"@@ -0,0 +1,18 @@
++// Copyright The OpenTelemetry Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
++/*
++Package debug provides access to enable internal debugging of opentelemetry.
++*/
++package debug // import ""go.opentelemetry.io/otel/internal/debug""",should this package be internal? don't we want to use it e.g. in go-contrib?
+4549,"@@ -31,7 +31,7 @@ import (
+ //
+ // A Document can be represented as a map[string]int or a pointer to a struct. For
+ // structs, the exported fields are the document fields.
+-type Document = interface{}
++type Document interface{}
+
+ // A Collection is a set of documents.
+ // TODO(jba): make the docstring look more like blob.Bucket.","Just curious, why did you make this change?"
+4550,"@@ -1576,6 +1576,8 @@ def get_dummies(
+             ""Length of 'prefix' ({}) did not match the length of ""
+             ""the columns being encoded ({})."".format(len(prefix), len(column_labels))
+         )
++    elif isinstance(prefix, dict):
++        prefix = [prefix[column_label[0]] for column_label in column_labels]
+
+     all_values = _reduce_spark_multi(
+         kdf._sdf, [F.collect_set(kdf._internal.spark_column_for(label)) for label in column_labels]","Can you handle error cases such as `pd.get_dummies(pdf, prefix={""A"": ""foo""})`?"
+4551,"@@ -166,8 +166,12 @@ func (agent *TestAgent) StartAgent() error {
+ 		Links: agent.Options.ContainerLinks,
+ 	}
+
++	if os.Getenv(""ECS_FTEST_FORCE_NET_HOST"") != """" {
++		hostConfig.NetworkMode = ""host""
++	}
++
+ 	if agent.Options != nil {
+-		// Override the default docker envrionment variable
++		// Override the default docker environment variable
+ 		for key, value := range agent.Options.ExtraEnvironment {
+ 			envVarExists := false
+ 			for i, str := range dockerConfig.Env {",Where is this environment variable being set?
+4552,"@@ -22,9 +22,7 @@ class Registry(object):
+             module (:obj:`nn.Module`): Module to be registered.
+         """"""
+         if not issubclass(module_class, nn.Module):
+-            raise TypeError(
+-                'module must be a child of nn.Module, but got {}'.format(
+-                    type(module_class)))
++            raise TypeError(f'module must be a child of nn.Module, but got {module_class}')
+         module_name = module_class.__name__
+         if module_name in self._module_dict:
+             raise KeyError('{} is already registered in {}'.format(",`module_class ` is already a class and `type(module_class)` always returns `<class 'type'>`
+4553,"@@ -110,6 +110,17 @@ class SparkFileWriterFactory extends BaseFileWriterFactory<InternalRow> {
+     builder.createWriterFunc(SparkOrcWriter::new);
+   }
+
++  @Override
++  protected void configureEqualityDelete(ORC.DeleteWriteBuilder builder) {
++    builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema, typDesc));
++  }
++
++  @Override
++  protected void configurePositionDelete(ORC.DeleteWriteBuilder builder) {
++    builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema, typDesc));
++    builder.transformPaths(path -> UTF8String.fromString(path.toString()));
++  }
++
+   private StructType dataSparkType() {
+     if (dataSparkType == null) {
+       Preconditions.checkNotNull(dataSchema(), ""Data schema must not be null"");",Nit: The lambda can be replaced with a method reference: `SparkOrcWriter::new` I think.
+4554,"@@ -1265,6 +1265,13 @@ def is_number(obj):
+     else: return False
+
+
++def is_int(obj, int_like=False):
++    real_int = isinstance(obj, int) or getattr(getattr(obj, 'dtype', None), 'kind', 'o') in 'ui'
++    if real_int or (int_like and hasattr(obj, 'is_integer') and obj.is_integer()):
++        return True
++    return False
++
++
+ class ProgressIndicator(param.Parameterized):
+     """"""
+     Baseclass for any ProgressIndicator that indicates progress","It would be nice to have a docstring that says what range of integer-like objects will be accepted, as well as what the int_like argument is meant for."
+4555,"@@ -0,0 +1,5 @@
++class CreateLicensesView < ActiveRecord::Migration
++  def change
++    create_view :licenses
++  end
++end",How do we manage updates to this view down the road?
+4556,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.
+4557,"@@ -1174,8 +1174,11 @@ public abstract class BasePointsFormatTestCase extends BaseIndexFileFormatTestCa
+
+     Document doc = new Document();
+     doc.add(new IntPoint(""id"", 0));
+-    w.addDocument(doc);
+-    // now we write another segment where the id field does have points:
++    IllegalArgumentException ex =
++        expectThrows(IllegalArgumentException.class, () -> w.addDocument(doc));
++    assertEquals(
++        ""cannot change field \""id\"" from index options=DOCS to inconsistent index options=NONE"",
++        ex.getMessage());
+
+     w.forceMerge(1);
+     IOUtils.close(w, dir);","I think we should refactor or drop this test, as it is not testing the points format now, but IndexingChain/FieldsInfos' logic. Maybe we could rename the test `testMergeMissing` and configure the first segment to not have the `id` field at all."
+4558,"@@ -6,15 +6,6 @@ module RSpec
+       # @private
+       # Produces progress output while bisecting.
+       class BisectProgressFormatter < BaseTextFormatter
+-        # We've named all events with a `bisect_` prefix to prevent naming collisions.
+-        Formatters.register self, :bisect_starting, :bisect_original_run_complete,
+-                            :bisect_round_started, :bisect_individual_run_complete,
+-                            :bisect_complete, :bisect_repro_command,
+-                            :bisect_failed, :bisect_aborted,
+-                            :bisect_round_ignoring_ids, :bisect_round_detected_multiple_culprits,
+-                            :bisect_dependency_check_started, :bisect_dependency_check_passed,
+-                            :bisect_dependency_check_failed
+-
+         def bisect_starting(notification)
+           @round_count = 0
+           options = notification.original_cli_args.join(' ')",not sure I follow why all this goes away?
+4559,"@@ -46,7 +46,7 @@ def test_insert_mode(file_name, source, input_text, auto_insert, quteproc):
+         quteproc.press_keys(input_text)
+     elif source == 'clipboard':
+         quteproc.send_cmd(':debug-set-fake-clipboard ""{}""'.format(input_text))
+-        quteproc.send_cmd(':paste-primary')
++        quteproc.send_cmd(':insert-text {clipboard}')
+
+     quteproc.send_cmd(':hint all')
+     quteproc.send_cmd(':follow-hint a')","Is this `{clipboard}` or `{primary}`, as the deprecation message for `:paste-primary` says?"
+4560,"@@ -46,6 +46,18 @@ var (
+ 		Usage: ""OpenVPN subnet netmask"",
+ 		Value: ""255.255.255.0"",
+ 	}
++	// FlagOpenVPNPriceMinute sets the price per minute for provided OpenVPN service.
++	FlagOpenVPNPriceMinute = cli.Uint64Flag{
++		Name:  ""openvpn.price-minute"",
++		Usage: ""Sets the price of the OpenVPN service per minute."",
++		Value: 50000,
++	}
++	// FlagOpenVPNPriceGB sets the price per GiB for provided OpenVPN service.
++	FlagOpenVPNPriceGB = cli.Uint64Flag{
++		Name:  ""openvpn.price-gb"",
++		Usage: ""Sets the price of the OpenVPN service per minute."",
++		Value: 7000000,
++	}
+ )
+
+ // RegisterFlagsServiceOpenvpn registers OpenVPN CLI flags for parsing them later","Human unreadable. IMHO user should input MYST value: 0.0006 @chompomonim, opinions?"
+4561,"@@ -643,15 +643,6 @@ class NVDAObject(documentBase.TextContainerObject,baseObject.ScriptableObject):
+ 				return self.presType_layout
+ 			if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN,controlTypes.ROLE_TABLECELL) and (not config.conf[""documentFormatting""][""reportTables""] or not config.conf[""documentFormatting""][""reportTableCellCoords""]):
+ 				return self.presType_layout
+-		if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN):
+-			try:
+-				table=self.table
+-			except NotImplementedError:
+-				table=None
+-			if table:
+-				# This is part of a real table, so the cells will report row/column information.
+-				# Therefore, this object is just for layout.
+-				return self.presType_layout
+ 		return self.presType_content
+
+ 	def _get_simpleParent(self):","May be you could elaborate on why you removed this? I see some of this logic has been moved to ia2Web, but couldn't there be cases outside ia2Web (i.e. UIA) in which case ROLE_TABLEROW and ROLE_TABLECOLUMN are mapped to objects, in which case these objects will be of presentation type content erroneously?"
+4562,"@@ -2637,10 +2637,10 @@ void Game::playerAcceptTrade(uint32_t playerId)
+ 	player->setTradeState(TRADE_ACCEPT);
+
+ 	if (tradePartner->getTradeState() == TRADE_ACCEPT) {
+-		Item* tradeItem1 = player->tradeItem;
+-		Item* tradeItem2 = tradePartner->tradeItem;
++		Item* playerTradeItem = player->tradeItem;
++		Item* tradePartnerItem = tradePartner->tradeItem;
+
+-		if (!g_events->eventPlayerOnTradeAccept(player, tradePartner, tradeItem1, tradeItem2)) {
++		if (!g_events->eventPlayerOnTradeAccept(player, tradePartner, playerTradeItem, tradePartnerItem)) {
+ 			internalCloseTrade(player);
+ 			return;
+ 		}",This is not consistent. Either rename the first to `tradePlayerItem` (which is ugly) or the second to `partnerTradeItem` (:+1:)
+4563,"@@ -50,6 +50,7 @@ func deps() {
+ 		""go get -u github.com/alecthomas/gometalinter"",
+ 		""gometalinter --install"",
+ 		""go get -u github.com/stretchr/testify"",
++		""go get -u github.com/xeipuuv/gojsonschema"",
+ 	}
+
+ 	for _, name := range list {",is there a reason we don't want to gx this dependency?
+4564,"@@ -26,6 +26,18 @@
+
+ require_once(""../inc/util.inc"");
+
++// strip leading AMD or NVIDIA
++//
++function strip_vendor($model) {
++    foreach (array(""AMD "", ""NVIDIA "") as $maker) {
++        $n = strlen($maker);
++        if (substr($model, 0, $n) == $maker) {
++            return substr($model, $n);
++        }
++    }
++    return $model;
++}
++
+ // take a host.serialnum field (which may encode several GPUs)
+ // and extract the model name for the given vendor
+ //","I'd suggest to add ""ATI "" and ""Intel(R) "" to this list"
+4565,"@@ -127,8 +127,8 @@ class Status extends ReportWidgetBase
+             }
+         }
+
+-        foreach ($missingPlugins as $pluginCode) {
+-            $warnings[] = Lang::get('backend::lang.warnings.plugin_missing', ['name' => '<strong>'.$pluginCode.'</strong>']);
++        foreach ($missingPlugins as $plugin) {
++            $warnings[] = Lang::get('backend::lang.warnings.plugin_missing', ['name' => '<strong>'.$plugin['code'].'</strong>']);
+         }
+
+         return $warnings;","This is using a different lang key, we should switch it to using the new key and remove the old key if it is no longer used."
+4566,"@@ -76,8 +76,9 @@ type SpecHandler interface {
+ }
+
+ var (
+-	nameRegex       = regexp.MustCompile(api.Name + ""=([0-9A-Za-z_-]+),?"")
+-	nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=([0-9A-Za-z_-]+),?"")
++	nameRegex = regexp.MustCompile(api.Name + ""=([0-9A-Za-z_-]+),?"")
++	//nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=([0-9A-Za-z_-]+),*"")
++	nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=('[0-9A-Za-z,_-]+'),*|"" + api.SpecNodes + ""=([0-9A-Za-z_-]+),*"")
+ 	parentRegex     = regexp.MustCompile(api.SpecParent + ""=([A-Za-z]+),?"")
+ 	sizeRegex       = regexp.MustCompile(api.SpecSize + ""=([0-9A-Za-z]+),?"")
+ 	scaleRegex      = regexp.MustCompile(api.SpecScale + ""=([0-9]+),?"")","shouldn't this work? nodesRegex = regexp.MustCompile(api.SpecNodes + ""=(('[0-9A-Za-z,_-]+')|([0-9A-Za-z_-]+)),?"")"
+4567,"@@ -1,5 +1,6 @@
+ class Account::Encrypter
+-  def before_create(account)
++  def before_validation(account)
++    return unless account.new_record?
+     assign_activation_code_to_random_hash(account)
+     encrypt_salt(account)
+   end","You mentioned this change was prompted because the `before_create` action was actually a defect. This will be done only for a new record; why is `before_validation`, which will be called repeatedly as accounts get updated and saved, correct whereas `before_create` is not? It looks like one would want to assign and activation code, etc., only once."
+4568,"@@ -95,6 +95,19 @@ namespace Datadog.Trace
+                 }
+             }
+
++            if (Settings.GlobalSamplingRate != null)
++            {
++                var globalRate = (float)Settings.GlobalSamplingRate;
++                if (globalRate < 0f || globalRate > 1f)
++                {
++                    Log.Warning(""{0} configuration of {1} is out of range"", ConfigurationKeys.GlobalSamplingRate, Settings.GlobalSamplingRate);
++                }
++                else
++                {
++                    Sampler.RegisterRule(new GlobalSamplingRule(globalRate));
++                }
++            }
++
+             // Register callbacks to make sure we flush the traces before exiting
+             AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit;
+             AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException;",What's the rationale for a default setting to not use a GlobalSamplingRate of 1? I don't know much about the sampling rate stuff
+4569,"@@ -24,7 +24,8 @@ module Windows
+         'group'         => 'Administrators',
+         'puppetpath'    => '`cygpath -smF 35`/PuppetLabs/puppet/etc',
+         'puppetvardir'  => '`cygpath -smF 35`/PuppetLabs/puppet/var',
+-        'puppetbindir'  => '`cygpath -F 38`/Puppet Labs/Puppet Enterprise/bin',
++        #if an x86 Program Files dir exists then use it, default to just Program Files
++        'puppetbindir'  => '$( [ -d ""/cygdrive/c/Program Files (x86)"" ] && echo ""/cygdrive/c/Program Files (x86)"" || echo ""/cygdrive/c/Program Files"" )/Puppet Labs/Puppet Enterprise/bin',
+         'pathseparator' => ';',
+       })
+     end","Don't we know if it's 64 by this point? Do we have to test for the directory on every call, or can't we just split the value based on the platform?"
+4570,"@@ -35,6 +35,19 @@ class NoteListUtils {
+ 				})
+ 			);
+
++			menu.append(
++				new MenuItem({
++					label: _('Assign Notebook'),
++					click: async () => {
++						props.dispatch({
++							type: 'WINDOW_COMMAND',
++							name: 'moveToFolder',
++							noteIds: noteIds,
++						});
++					},
++				})
++			);
++
+ 			menu.append(
+ 				new MenuItem({
+ 					label: _('Duplicate'),",It's not async
+4571,"@@ -66,11 +66,11 @@ namespace Examples.Console
+                 AppContext.SetSwitch(""System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport"", true);
+
+                 providerBuilder
+-                    .AddOtlpExporter(o =>
++                    .AddOtlpExporter((exporterOptions, metricReaderOptions) =>
+                     {
+-                        o.MetricReaderType = MetricReaderType.Periodic;
+-                        o.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
+-                        o.AggregationTemporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
++                        metricReaderOptions.MetricReaderType = MetricReaderType.Periodic;
++                        metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
++                        metricReaderOptions.Temporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
+                     });
+             }
+             else","Maybe we could add some use of `exporterOptions` in this example, otherwise the proper code would replace this variable name with an underscore?"
+4572,"@@ -41,6 +41,11 @@ class Search extends WidgetBase
+      */
+     public $scope;
+
++    /**
++     * @var bool Search on every key stroke.
++     */
++    public $everykey = true;
++
+     //
+     // Object properties
+     //","Maybe would be better to rename it to ""onEveryKey"" or ""fireOnEveryKey""."
+4573,"@@ -832,7 +832,7 @@ public class FilePage implements java.io.Serializable {
+             // Always allow preview for PrivateUrlUser
+             return true;
+         } else {
+-            return FileUtil.isPreviewAllowed(fileMetadata);
++            return fileDownloadHelper.isPreviewAllowed(fileMetadata);
+         }
+     }
+ ","if we're switching to calling FileDownloadHelper, we can just call that directly from the xhtml (see line 357 for example) and then remove this method completely. This is because the other thing it does is check PrivateURLUser, but the FileDownloadHelper method already does that. (and while we're at it, we can remove the method from FileUtil as this is the only place that method is called)"
+4574,"@@ -274,11 +274,7 @@ public abstract class GapicInterfaceConfig implements InterfaceConfig {
+   }
+
+   public GapicMethodConfig getMethodConfig(String methodSimpleName, String fullName) {
+-    GapicMethodConfig methodConfig = getMethodConfigMap().get(methodSimpleName);
+-    if (methodConfig == null) {
+-      throw new IllegalArgumentException(""no method config for method '"" + fullName + ""'"");
+-    }
+-    return methodConfig;
++    return getMethodConfigMap().get(methodSimpleName);
+   }
+
+   @Override",is `fullName` still required as a parameter?
+4575,"@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
+           getClass().getClassLoader())
+           .asSubclass(Routable.class);
+       Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
+-      LOG.info(""Bound legacy RC support"");
++      LOG.finest(""Bound legacy RC support"");
+       return constructor.newInstance(sessions);
+     } catch (ReflectiveOperationException e) {
+       // Do nothing.",This informational message is important to users. Please leave.
+4576,"@@ -470,7 +470,6 @@ func (o *initEnvOpts) deployEnv(app *config.Application) error {
+ 		Name:                     o.Name,
+ 		AppName:                  o.AppName(),
+ 		Prod:                     o.IsProduction,
+-		PublicLoadBalancer:       true, // TODO: configure this based on user input or service Type needs?
+ 		ToolsAccountPrincipalARN: caller.RootUserARN,
+ 		AppDNSName:               app.Domain,
+ 		AdditionalTags:           app.Tags,",Why do we want to remove this one? Are we planning to substitute it?
+4577,"@@ -4,13 +4,14 @@ import (
+ 	""fmt""
+ 	""testing""
+
+-	""github.com/golang/protobuf/proto""
++	legacyProto ""github.com/golang/protobuf/proto"" // nolint: staticcheck // deprecated library needed until WithDetails can take v2
+ 	""github.com/spiffe/spire/pkg/common/nodeutil""
+ 	""github.com/spiffe/spire/proto/spire/common""
+ 	""github.com/spiffe/spire/proto/spire/types""
+ 	""github.com/stretchr/testify/require""
+ 	""google.golang.org/grpc/codes""
+ 	""google.golang.org/grpc/status""
++	""google.golang.org/protobuf/proto""
+ )
+
+ func TestIsAgentBanned(t *testing.T) {",We may create an issue to track this so we don't forget?
+4578,"@@ -1,9 +1,12 @@
+ class ApplicationController < ActionController::Base
++  helper AvatarHelper
++  helper ButtonHelper
++
+   protect_from_forgery with: :exception
+
+   attr_reader :page_context
+   helper_method :page_context
+-
++
+   before_action :store_location
+
+   def initialize(*params)",This file has the executable bit set.
+4579,"@@ -177,6 +177,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
++	db.logger.Info(""setting db capacity to :"", db.capacity)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","Improve the formatting of the message `.Infof(""setting db capacity to: %v"", db.capacity)` There is a space before `:` and this way it is easier to see the formatting."
+4580,"@@ -434,12 +434,13 @@ RTPSParticipantImpl* RTPSDomainImpl::find_local_participant(
+ RTPSReader* RTPSDomainImpl::find_local_reader(
+         const GUID_t& reader_guid)
+ {
+-    std::lock_guard<std::mutex> guard(RTPSDomain::m_mutex);
++    std::unique_lock<std::mutex> lock(RTPSDomain::m_mutex);
+     for (const RTPSDomain::t_p_RTPSParticipant& participant : RTPSDomain::m_RTPSParticipants)
+     {
+         if (participant.second->getGuid().guidPrefix == reader_guid.guidPrefix)
+         {
+             // Participant found, forward the query
++            lock.unlock();
+             return participant.second->find_local_reader(reader_guid);
+         }
+     }","This lock cannot be released here, as it is protecting m_RTPSParticipants and the participant reference."
+4581,"@@ -967,6 +967,8 @@ Query.prototype.find = function (conditions, callback) {
+     this.merge(conditions);
+   }
+
++  prepareDiscriminatorCriteria(this);
++
+   try {
+     this.cast(this.model);
+     this._castError = null;",we'll need this in `_findAndModify` too
+4582,"@@ -148,7 +148,7 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
+ 		isGlobal = bundle == null || !bundle.containsKey(IS_GLOBAL_STORE) || bundle.getBoolean(IS_GLOBAL_STORE) || !hasUser;
+ 		// dbName is set to DBOpenHelper.DEFAULT_DB_NAME
+ 		//   if no bundle, or no value for dbName in bundle
+-		dbName = bundle == null || !bundle.containsKey(DB_NAME) ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME);
++		dbName = bundle == null || !bundle.containsKey(DB_NAME) ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ 	}
+
+ 	private void setupSpinner() {","This is the fix for the crash. The function to create the intent to launch this activity requires `dbName`, so it has to be set to `null`. In such cases, the value for `dbName` will be set to `null` and cause issues throughout this activity. This adds a default value if the explicitly assigned value in `null`."
+4583,"@@ -412,6 +412,11 @@ class WordDocument(UIADocumentWithTableNavigation,WordDocumentNode,WordDocumentB
+ 	# Microsoft Word duplicates the full title of the document on this control, which is redundant as it appears in the title of the app itself.
+ 	name=u""""
+
++	def event_textChange(self):
++		# Ensure Braille is updated when text changes,
++		# As Microsoft Word does not fire caret events when typing text, even though the caret does move.
++		braille.handler.handleCaretMove(self)
++
+ 	def event_UIA_notification(self, activityId=None, **kwargs):
+ 		# #10851: in recent Word 365 releases, UIA notification will cause NVDA to announce edit functions
+ 		# such as ""delete back word"" when Control+Backspace is pressed.","Shouldn't we also trigger vision update here, so that if someone has caret highlighting enabled the correct character is highlighted?"
+4584,"@@ -338,7 +338,11 @@ public class GoGapicSurfaceTransformer implements ModelToViewTransformer<ProtoAp
+   void addXExampleImports(InterfaceContext context, Iterable<? extends MethodModel> methods) {
+     ImportTypeTable typeTable = context.getImportTypeTable();
+     typeTable.saveNicknameFor(""context;;;"");
+-    typeTable.saveNicknameFor(context.getProductConfig().getPackageName() + "";;;"");
++    typeTable.saveNicknameFor(
++        context.getProductConfig().getPackageName()
++            + "";""
++            + context.getNamer().getLocalPackageName()
++            + "";;"");
+
+     for (MethodModel method : methods) {
+       method.getAndSaveRequestTypeName(context.getImportTypeTable(), context.getNamer());","Woah, how does this change, which includes semicolons, result in the baseline change? Are the semicolon chars just part of the internal representation of the import type?"
+4585,"@@ -51,7 +51,7 @@ class _NvdaLocationData:
+ 		self.whichNVDA = builtIn.get_variable_value(""${whichNVDA}"", ""source"")
+ 		if self.whichNVDA == ""source"":
+ 			self._runNVDAFilePath = _pJoin(self.repoRoot, ""source/nvda.pyw"")
+-			self.baseNVDACommandline = f""pyw -3.7-32 {self._runNVDAFilePath}""
++			self.baseNVDACommandline = f""pyw {self._runNVDAFilePath}""
+ 		elif self.whichNVDA == ""installed"":
+ 			self._runNVDAFilePath = _pJoin(_expandvars('%PROGRAMFILES%'), 'nvda', 'nvda.exe')
+ 			self.baseNVDACommandline = f'""{str(self._runNVDAFilePath)}""'",Can't you just use runnvda.bat here?
+4586,"@@ -23,17 +23,6 @@
+ #include ""selectors.h""
+ #include ""vstring.h""
+
+-/* To get rid of unused parameter warning in
+- * -Wextra */
+-#ifdef UNUSED
+-#elif defined(__GNUC__)
+-# define UNUSED(x) UNUSED_ ## x __attribute__((unused))
+-#elif defined(__LCLINT__)
+-# define UNUSED(x) /*@unused@*/ x
+-#else
+-# define UNUSED(x) x
+-#endif
+-
+ typedef enum {
+ 	K_INTERFACE,
+ 	K_IMPLEMENTATION,","these definitions of UNUSED aren't the same as the one you imported, so callers should be fixed (if any)"
+4587,"@@ -404,6 +404,7 @@ func (client *cniClient) createIPAMNetworkConfig(cfg *Config) (string, *libcni.N
+
+ 	ipamNetworkConfig := IPAMNetworkConfig{
+ 		Name:       ECSIPAMPluginName,
++		Type:       ECSIPAMPluginName,
+ 		CNIVersion: client.cniVersion,
+ 		IPAM:       ipamConfig,
+ 	}",is type a free string too?
+4588,"@@ -27,15 +27,16 @@ class WrapFunction(nn.Module):
+         return self.wrapped_function(*args, **kwargs)
+
+
+-def ort_validate(model, feats, onnx_io='tmp.onnx'):
++def ort_validate(model_func, feats, onnx_io='tmp.onnx'):
+     """"""Validate the output of the onnxruntime backend is the same as the output
+     generated by torch.
+
+     Args:
+-        model (nn.Module): the model to be verified
++        model_func : the function of model to be verified
+         feats (list(torch.Tensor) | torch.Tensor): the input of model
+         onnx_io (str): the name of onnx output file
+     """"""
++    model = WrapFunction(model_func)
+     model.cpu().eval()
+     with torch.no_grad():
+         torch.onnx.export(",here input could be a normal function or an instance of torch.nn.Module.
+4589,"@@ -65,6 +65,7 @@ module Travis
+           sh.echo 'Please open any issues at https://github.com/travis-ci/travis-ci/issues/new and cc @domenkozar @garbas @matthewbauer @grahamc', ansi: :green
+
+           sh.cmd ""nix-env --version""
++          sh.cmd ""nix-instantiate --eval -E 'with import <nixpkgs> {}; lib.version or lib.nixpkgsVersion'""
+         end
+
+         def script","Example output: ""19.03.git.a7f4a860d0c"" At some point `nixpkgsVersion` was renamed to `version` since someone may use an old channel we fallback to `nixpkgsVersion` for backwards compatibility."
+4590,"@@ -39,8 +39,6 @@ class LanguageTreeReadAction
+
+
+     /**
+-     * @IsGranted(""SETTINGS_READ"")
+-     *
+      * @SWG\Tag(name=""Language"")
+      * @SWG\Parameter(
+      *     name=""language"",",Class import is therefore redundant I guess :)
+4591,"@@ -58,11 +58,13 @@ const (
+ 	infoTryingToStopNode             = ""Trying to stop the node...""
+ 	infoNodeSuccessfullyStopped      = ""The node was successfully stopped.""
+ 	infoNodeStatus                   = ""Last committed block: %d\nTime since last block: %s\nSync Time: %s\nLast consensus protocol: %s\nNext consensus protocol: %s\nRound for next consensus protocol: %d\nNext consensus protocol supported: %v""
++	warnNodeCreationIPFailure        = ""Parsing passed IP %v failed: need a valid IPv4 or IPv6 address with a specified port number. Acting as though IP was not supplied.""
+ 	errorNodeNotDetected             = ""Algorand node does not appear to be running: %s""
+ 	errorNodeStatus                  = ""Cannot contact Algorand node: %s.""
+ 	errorNodeFailedToStart           = ""Algorand node failed to start: %s""
+ 	errorNodeRunning                 = ""Node must be stopped before writing APIToken""
+ 	errorNodeFailGenToken            = ""Cannot generate API token: %s""
++	errorNodeCreation                = ""Error during node creation: %v""
+ 	errorKill                        = ""Cannot kill node: %s""
+ 	errorCloningNode                 = ""Error cloning the node: %s""
+ 	infoNodeCloned                   = ""Node cloned successfully to: %s""","If parsing fails, don't act as no IP specified. Error out."
+4592,"@@ -187,7 +187,9 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+
+     final Object updateSync = new Object();
+
+-    public enum CHARTTYPE {PRE,BAS, IOB, COB, DEV, SEN};
++    public enum CHARTTYPE {PRE, BAS, IOB, COB, DEV, SEN}
++
++    ;
+     private static final ScheduledExecutorService worker = Executors.newSingleThreadScheduledExecutor();
+     private static ScheduledFuture<?> scheduledUpdate = null;
+ ",... here the semicolon wanted to run away from the enum ;)
+4593,"@@ -76,12 +76,12 @@ public class ReplicateFromLeader {
+       }
+       log.info(""Will start replication from leader with poll interval: {}"", pollIntervalStr );
+
+-      NamedList<Object> slaveConfig = new NamedList<>();
+-      slaveConfig.add(""fetchFromLeader"", Boolean.TRUE);
+-      slaveConfig.add(ReplicationHandler.SKIP_COMMIT_ON_MASTER_VERSION_ZERO, switchTransactionLog);
+-      slaveConfig.add(""pollInterval"", pollIntervalStr);
++      NamedList<Object> secondaryConfig = new NamedList<>();
++      secondaryConfig.add(""fetchFromLeader"", Boolean.TRUE);
++      secondaryConfig.add(ReplicationHandler.SKIP_COMMIT_ON_MASTER_VERSION_ZERO, switchTransactionLog);
++      secondaryConfig.add(""pollInterval"", pollIntervalStr);
+       NamedList<Object> replicationConfig = new NamedList<>();
+-      replicationConfig.add(""slave"", slaveConfig);
++      replicationConfig.add(""secondary"", secondaryConfig);
+
+       String lastCommitVersion = getCommitVersion(core);
+       if (lastCommitVersion != null) {","Note that this is in the context of SolrCloud, so ""secondary"" doesn't apply and should be instead follower"
+4594,"@@ -1578,11 +1578,11 @@ EOF
+     assert_response :success, ""can't get changesets by closed-ness""
+     assert_changesets [3, 5, 6, 7, 8, 9]
+
+-    get :query, :closed => ""true"", :user => users(:normal_user).id
++    get :query, :closed => ""true"", :user => users(:normal_user)
+     assert_response :success, ""can't get changesets by closed-ness and user""
+     assert_changesets [3, 6, 8]
+
+-    get :query, :closed => ""true"", :user => users(:public_user).id
++    get :query, :closed => ""true"", :user => users(:public_user)
+     assert_response :success, ""can't get changesets by closed-ness and user""
+     assert_changesets [7]
+ ",This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell.
+4595,"@@ -4177,9 +4177,11 @@ RelExpr * FileScan::preCodeGen(Generator * generator,
+ 	 TRUE);
+
+       if (isHiveTable())
+-	// assign individual files and blocks to each ESPs
+-	((NodeMap *) getPartFunc()->getNodeMap())->assignScanInfos(hiveSearchKey_);
+-       generator->setProcessLOB(TRUE);
++        {
++          // assign individual files and blocks to each ESPs
++          ((NodeMap *) getPartFunc()->getNodeMap())->assignScanInfos(hiveSearchKey_);
++          generator->setProcessLOB(TRUE);
++        }
+     }
+
+   ",Need to ensure this is set to TRU for LOB datatype access too not just for hive .
+4596,"@@ -1772,7 +1772,11 @@ class Series(_Frame, IndexOpsMixin):
+
+     # ----------------------------------------------------------------------
+
+-    def _reduce_for_stat_function(self, sfun):
++    def _reduce_for_stat_function(self, sfun, numeric_only=None):
++        """"""
++        :param sfun: the stats function to be used for aggregation
++        :param numeric_only: not used by this implementation, but passed down by stats functions
++        """"""
+         from inspect import signature
+         num_args = len(signature(sfun).parameters)
+         col_sdf = self._scol","You're using the Sphinx docstring style here (maybe because it's the default in PyCharm?). Instead, you should use the NumPy style (that you've also used in other places) to be more consistent with the rest of the project."
+4597,"@@ -142,8 +142,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+                 }
+                 else if (!hasListenOptions && !hasServerAddresses)
+                 {
+-                    _logger.LogDebug($""No listening endpoints were configured. Binding to {Constants.DefaultIPEndPoint} by default."");
+-                    listenOptions.Add(new ListenOptions(Constants.DefaultIPEndPoint));
++                    _logger.LogDebug($""No listening endpoints were configured. Binding to {Constants.DefaultServerAddress} by default."");
++
++                    // ""localhost"" for both IPv4 and IPv6 can't be represented as an IPEndPoint.
++                    StartLocalhost(engine, ServerAddress.FromUrl(Constants.DefaultServerAddress));
++
++                    // If StartLocalhost doesn't throw, there is at least one listener.
++                    // The port cannot change for ""localhost"".
++                    _serverAddresses.Addresses.Add(Constants.DefaultServerAddress);
++
++                    return;
+                 }
+                 else if (!hasListenOptions)
+                 {",Don't really need this since the rest of the method will no-op but it's also safe to return early.
+4598,"@@ -19,11 +19,13 @@
+
+ #include <fastdds/rtps/messages/RTPSMessageCreator.h>
+ #include <fastdds/rtps/messages/CDRMessage.h>
+-#include <fastrtps/qos/ParameterList.h>
+
+ #include <fastdds/dds/log/Log.hpp>
+
++#include ""../../fastdds/core/policy/ParameterList.hpp""
++
+ using namespace eprosima::fastrtps;
++using ParameterList = eprosima::fastdds::dds::ParameterList;
+
+ namespace eprosima {
+ namespace fastrtps {",Don't use relative paths. src directory is already on the include search path
+4599,"@@ -0,0 +1,5 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++// [assembly: BenchmarkDotNet.Attributes.AspNetCoreBenchmark]",this file can be removed
+4600,"@@ -98,7 +98,7 @@ public class CodeFirstSpringmvc extends CodeFirstSpringmvcBase {
+
+   @RequestMapping(path = ""/uploadWithoutAnnotation"", method = RequestMethod.POST, produces = MediaType.TEXT_PLAIN_VALUE, consumes = MediaType.MULTIPART_FORM_DATA_VALUE)
+   public String fileUploadWithoutAnnotation(MultipartFile file1, MultipartFile file2,
+-      @RequestAttribute(""name"") String name) {
++      @RequestAttribute(name = ""name"", required = false) String name) {
+     return super.fileUpload(file1, file2, name);
+   }
+ ",Do we have test cases that name is null?
+4601,"@@ -109,8 +109,16 @@ type SumIntAgg struct {
+
+ func (a *SumIntAgg) DoInt(vs *array.Int64) {
+ 	// https://issues.apache.org/jira/browse/ARROW-4081
+-	if vs.Len() > 0 {
+-		a.sum += math.Int64.Sum(vs)
++	if l := vs.Len() - vs.NullN(); l > 0 {
++		if vs.NullN() == 0 {
++			a.sum += math.Int64.Sum(vs)
++		} else {
++			for i := 0; i < vs.Len(); i++ {
++				if vs.IsValid(i) {
++					a.sum += vs.Value(i)
++				}
++			}
++		}
+ 	}
+ }
+ func (a *SumIntAgg) Type() flux.ColType {","in a separate PR, I'll check for a table that is empty/all-null and skip this function call completely."
+4602,"@@ -47,7 +47,7 @@ public class WebUtils {
+     try {
+       azkabanEventReporter = ServiceProvider.SERVICE_PROVIDER
+           .getInstance(AzkabanEventReporter.class);
+-    } catch (NullPointerException | ConfigurationException e) {
++    } catch (Exception e) {
+       Logger.getLogger(WebUtils.class.getName()).warn(""AzkabanEventReporter not configured"", e);
+     }
+   }","We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null."
+4603,"@@ -112,7 +112,12 @@ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context,
+ 					// The values only have the same type when `null`.
+
+ 					outer: if (oldDom==null || oldDom.parentNode!==parentDom) {
+-						parentDom.appendChild(newDom);
++						// Skip appendind if the last element is the same as the new dom
++						// node. This is necessary to prevent the last element losing focus
++						// if it had focus before the diff.
++						if (parentDom.lastChild!==newDom) {
++							parentDom.appendChild(newDom);
++						}
+ 					}
+ 					else {
+ 						// `j<oldChildrenLength; j+=2` is an alternative to `j++<oldChildrenLength/2`",Can't we add the check here?
+4604,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests
+4605,"@@ -40,6 +40,8 @@ type GenericDeploymentSpec struct {
+ 	// The maximum length of time to execute deployment before giving up.
+ 	// Default is 6h.
+ 	Timeout Duration `json:""timeout,omitempty"" default:""6h""`
++	// List of encrypted secrets and targets that should be decoded before using.
++	Encryption *SecretEncryption `json:""encryption""`
+ }
+
+ func (s *GenericDeploymentSpec) Validate() error {",Tell me if you have a better field name for this.
+4606,"@@ -1084,8 +1084,8 @@ partial class Build
+                         ""Samples.AspNetCoreMvc30"" => Framework == TargetFramework.NETCOREAPP3_0,
+                         ""Samples.AspNetCoreMvc31"" => Framework == TargetFramework.NETCOREAPP3_1,
+                         ""Samples.AspNetCore2"" => Framework == TargetFramework.NETCOREAPP2_1,
+-                        ""Samples.AspNetCore5"" => Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NETCOREAPP3_0,
+-                        ""Samples.GraphQL4"" => Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NET5_0,
++                        ""Samples.AspNetCore5"" => Framework == TargetFramework.NET6_0 || Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NETCOREAPP3_0,
++                        ""Samples.GraphQL4"" => Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NET6_0,
+                         var name when projectsToSkip.Contains(name) => false,
+                         var name when multiPackageProjects.Contains(name) => false,
+                         ""Samples.AspNetCoreRazorPages"" => true,","FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority"
+4607,"@@ -364,16 +364,11 @@ void getNbrAtomAndBondIds(unsigned int aid, const RDKit::ROMol *mol,
+   unsigned int na = mol->getNumAtoms();
+   URANGE_CHECK(aid, na);
+
+-  RDKit::ROMol::ADJ_ITER nbrIdx, endNbrs;
+-  boost::tie(nbrIdx, endNbrs) = mol->getAtomNeighbors(mol->getAtomWithIdx(aid));
+-
+-  unsigned int ai, bi;
+-  while (nbrIdx != endNbrs) {
+-    ai = (*nbrIdx);
+-    bi = mol->getBondBetweenAtoms(aid, ai)->getIdx();
++  for (auto ai : boost::make_iterator_range(
++           mol->getAtomNeighbors(mol->getAtomWithIdx(aid)))) {
++    auto bi = mol->getBondBetweenAtoms(aid, ai)->getIdx();
+     aids.push_back(ai);
+     bids.push_back(bi);
+-    nbrIdx++;
+   }
+ }
+ ","This is just `mol->atomNeightors()`, is it?"
+4608,"@@ -40,10 +40,11 @@ using daal_kmeans_lloyd_dense_ucapi_kernel_t =
+     daal_kmeans::internal::KMeansDenseLloydBatchKernelUCAPI<Float>;
+
+ template <typename Float>
+-struct infer_kernel_gpu<Float, method::by_default> {
+-    infer_result operator()(const dal::backend::context_gpu& ctx,
+-                            const descriptor_base& params,
+-                            const infer_input& input) const {
++struct infer_kernel_gpu<Float, method::by_default, task::clustering> {
++    infer_result<task::clustering> operator()(const dal::backend::context_gpu& ctx,
++                                              const descriptor_base<task::clustering>& params,
++                                              const infer_input<task::clustering>& input) const {
++        using Task = task::clustering;
+         auto& queue = ctx.get_queue();
+         interop::execution_context_guard guard(queue);
+ ",This alias is just for a single occurrence. Maybe it ins't necessary?
+4609,"@@ -1198,7 +1198,7 @@ class CppGenerator : public BaseGenerator {
+         code_ += ""    }"";
+       }
+     }
+-    code_ += ""    default: return false;"";
++    code_ += ""    default: return true;"";
+     code_ += ""  }"";
+     code_ += ""}"";
+     code_ += """";",You can delete this `NONE` case.
+4610,"@@ -5420,8 +5420,8 @@ TEST_F(VkLayerTest, RenderPassCreateAttachmentReadOnlyButCleared) {
+     }
+ }
+
+-TEST_F(VkLayerTest, RenderPassCreateAttachmentUsedTwiceColor) {
+-    TEST_DESCRIPTION(""Attachment is used simultaneously as two color attachments. This is usually unintended."");
++TEST_F(VkLayerTest, RenderPassCreateAttachmentMismatchingLayoutsColor) {
++    TEST_DESCRIPTION(""Attachment is used simultaneously as two color attachments with different layouts."");
+
+     // Check for VK_KHR_get_physical_device_properties2
+     if (InstanceExtensionSupported(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME)) {",@cnorthrop -- here is a test with a name change. Is this going to affect your internal CI?
+4611,"@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
+   private ChromeDriverCommand() {}
+
+   static final String LAUNCH_APP = ""launchApp"";
++  static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
++      = ""sendCommandForDownloadChromeHeadLess"";
++
+ }","Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way."
+4612,"@@ -122,6 +122,10 @@ class core(task.Config):
+     parallel_scheduling = parameter.BoolParameter(
+         default=False,
+         description='Use multiprocessing to do scheduling in parallel.')
++    parallel_scheduling_processes = parameter.IntParameter(
++        default=None,
++        description='The number of processes to use for scheduling in parallel.'
++                    ' The default is the number of available CPUs')
+     assistant = parameter.BoolParameter(
+         default=False,
+         description='Run any task from the scheduler.')","I think this will cause a warning, can you set the default to zero (`0`)?"
+4613,"@@ -2,7 +2,7 @@ package client_connection
+
+ import (
+ 	""errors""
+-	""github.com/mysterium/node/service_discovery/dto""
++	id ""github.com/mysterium/node/identity""
+ )
+
+ type State string","confusing naming. Identity from ""id"" package :/ why we need alias here? (and in other imports)"
+4614,"@@ -355,9 +355,11 @@ def data(readonly=False):
+              ""Hide the window decoration when using wayland ""
+              ""(requires restart)""),
+
+-            ('show-keyhints',
+-             SettingValue(typ.Bool(), 'true'),
+-             ""Show possible keychains based on the current keystring""),
++            ('keyhint-blacklist',
++             SettingValue(typ.List(none_ok=True), ''),
++             ""Keychains that shouldn't be shown in the keyhint dialog\n\n""
++             ""Globs are supported, so ';*' will blacklist all keychains""
++             ""starting with ';'. Use '*' to disable keyhints""),
+
+             readonly=readonly
+         )),","It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work."
+4615,"@@ -150,7 +150,7 @@ module.exports = {
+         TestCase.assertEqual(obj.arrayCol1[-1], undefined);
+         TestCase.assertEqual(obj.arrayCol1['foo'], undefined);
+
+-        for (let field of Object.keys(prim)) {
++        for (let field of Object.keys(Object.getPrototypeOf(prim))) {
+             TestCase.assertEqual(prim[field][2], undefined);
+             TestCase.assertEqual(prim[field][-1], undefined);
+             TestCase.assertEqual(prim[field]['foo'], undefined);",Perhaps use the new `.keys()` method here instead?
+4616,"@@ -79,9 +79,10 @@ func (b *builder) kubernetesDiff(
+ 		}
+ 	}
+
+-	result, err := provider.DiffList(oldManifests, newManifests,
++	result, err := provider.DiffList(
++		oldManifests,
++		newManifests,
+ 		diff.WithEquateEmpty(),
+-		diff.WithIgnoreAddingMapKeys(),
+ 		diff.WithCompareNumberAndNumericString(),
+ 	)
+ 	if err != nil {","We don't need this option because plan-preview is comparing between 2 commits, not using the live state."
+4617,"@@ -37,6 +37,11 @@ module Beaker
+       # @param [Proc] block The actions to be performed in this step.
+       def step step_name, &block
+         logger.notify ""\n  * #{step_name}\n""
++        if @options
++          @options[:current_test_info] ||= {}
++          @options[:current_test_info][:step] ||= {}
++          @options[:current_test_info][:step][:name] = step_name
++        end
+         yield if block_given?
+       end
+ ","I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution."
+4618,"@@ -237,7 +237,8 @@ func (card *DRICard) readPowerConsumption() (float64, error) {
+ 	return 0, fmt.Errorf(""cannot find average power consumption param in the amdgpu_pm_info"")
+ }
+
+-func (card *DRICard) Metrics() (*DRICardMetrics, error) {
++// Status returns hardware stats for the card
++func (card *DRICard) Status() (*DRICardMetrics, error) {
+ 	if len(card.HwmonPath) == 0 {
+ 		return nil, fmt.Errorf(""metrics interface is not available for %s"", card.Name)
+ 	}",So `Status` returns metrics?
+4619,"@@ -3,6 +3,8 @@ class OrganizationsController < ApplicationController
+   helper RatingsHelper
+
+   before_action :find_organization
++  before_action :set_outside_committers, only: :outside_committers
++  before_action :organization_context, only: :outside_committers
+
+   def outside_projects
+     @outside_projects = @organization.outside_projects((params[:page] || 1), 20)","Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument(s) for all the four methods. What do you think?"
+4620,"@@ -56,7 +56,15 @@ public final class IcebergDateObjectInspectorHive3 extends AbstractPrimitiveJava
+
+   @Override
+   public Object copyObject(Object o) {
+-    return o == null ? null : new Date((Date) o);
++    if (o == null) {
++      return null;
++    }
++
++    if (o instanceof Date) {
++      return new Date((Date) o);
++    } else {
++      return o;
++    }
+   }
+
+ }",Why would this be called to copy a non-Date object?
+4621,"@@ -77,13 +77,13 @@ func (msg *Boolmsg) Serialize() []byte {
+ 	native.PutUint16(buf[0:2], uint16(msg.Len()))
+ 	native.PutUint16(buf[2:4], msg.Type)
+ 	if msg.Value {
+-		buf[4] = 1
++		native.PutUint32(buf[4:8], uint32(1))
+ 	} else {
+-		buf[4] = 0
++		native.PutUint32(buf[4:8], uint32(0))
+ 	}
+ 	return buf
+ }
+
+ func (msg *Boolmsg) Len() int {
+-	return unix.NLA_HDRLEN + 1
++	return unix.NLA_HDRLEN + 4 // alignment
+ }",This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once.
+4622,"@@ -71,7 +71,7 @@ func DefaultConfig() Config {
+ 		PauseContainerTag:                   DefaultPauseContainerTag,
+ 		AWSVPCBlockInstanceMetdata:          false,
+ 		ContainerMetadataEnabled:            false,
+-		TaskCPUMemLimit:                     DefaultEnabled,
++		TaskCPUMemLimit:                     BooleanDefaultTrue{Value: NotSet},
+ 		CgroupPath:                          defaultCgroupPath,
+ 		TaskMetadataSteadyStateRate:         DefaultTaskMetadataSteadyStateRate,
+ 		TaskMetadataBurstRate:               DefaultTaskMetadataBurstRate,","Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are ""default false"" config vars not affected by this bug?"
+4623,"@@ -9,7 +9,7 @@ class RolesController < ApplicationController
+     authorize @role
+
+     access_level = params[:role][:access_level].to_i
+-    @role.set_access_level(access_level)
++    @role.access_level = access_level
+     message = ''
+     if params[:user].present?
+       if @role.plan.owner.present? && @role.plan.owner.email == params[:user]",Replaced this method with a ruby idiomatic setter.
+4624,"@@ -2,7 +2,7 @@
+  * The Forgotten Server - a free and open-source MMORPG server emulator
+  * Copyright (C) 2017 Mark Samman <mark.samman@gmail.com>
+  *
+- * This program is free software; you can redistribute it and/or modify
++ * This program is free tisoftware; you can redistribute it and/or modify
+  * it under the terms of the GNU General Public License as published by
+  * the Free Software Foundation; either version 2 of the License, or
+  * (at your option) any later version.",wrong place hehe
+4625,"@@ -0,0 +1,14 @@
++require 'travis/build/appliances/base'
++
++module Travis
++  module Build
++    module Appliances
++      class RestartMysql < Base
++        def apply
++          sh.cmd '(ls /var/run/mysqld/mysqld.sock >& /dev/null) || sudo service mysql restart'
++        end
++      end
++    end
++  end
++end
++","Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon"
+4626,"@@ -30,12 +30,12 @@ class Proposal < ActiveRecord::Base
+   has_many :individual_approvals, ->{ individual }, class_name: 'Approvals::Individual'
+   has_many :approvers, through: :individual_approvals, source: :user
+   has_many :api_tokens, through: :individual_approvals
+-  has_many :attachments
++  has_many :attachments, dependent: :destroy
+   has_many :approval_delegates, through: :approvers, source: :outgoing_delegates
+-  has_many :comments
++  has_many :comments, dependent: :destroy
+   has_many :observations, -> { where(""proposal_roles.role_id in (select roles.id from roles where roles.name='observer')"") }
+   has_many :observers, through: :observations, source: :user
+-  belongs_to :client_data, polymorphic: true
++  belongs_to :client_data, polymorphic: true, dependent: :destroy
+   belongs_to :requester, class_name: 'User'
+
+   # The following list also servers as an interface spec for client_datas","Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice?"
+4627,"@@ -1452,6 +1452,7 @@ static void establish_tunnel(h2o_req_t *req, h2o_tunnel_t *tunnel, uint64_t idle
+     h2o_iovec_t datagram_flow_id = {};
+
+     if (stream->tunnel == NULL) {
++        tunnel->destroy(tunnel);
+         /* the tunnel has been closed in the meantime */
+         return;
+     }","This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach."
+4628,"@@ -5,8 +5,8 @@
+
+ nano::error nano::node_pow_server_config::serialize_toml (nano::tomlconfig & toml) const
+ {
+-	toml.put (""enable"", enable, ""Enable or disable starting Nano PoW Server as a child process.\ntype:bool"");
+-	toml.put (""nano_pow_server_path"", pow_server_path, ""Path to the nano_pow_server executable.\ntype:string,path"");
++	toml.put (""enable"", enable, ""Enable or disable starting Nano PoW Server as a child process\ntype:bool"");
++	toml.put (""nano_pow_server_path"", pow_server_path, ""Path to the nano_pow_server executable\ntype:string,path"");
+ 	return toml.get_error ();
+ }
+ ",Did you mean to remove the periods here while newly adding to other locations?
+4629,"@@ -2014,7 +2014,7 @@ func (bps *blockPutState) removeOtherBps(other *blockPutState) {
+ 	// slice length.
+ 	newLen := len(bps.blockStates) - len(other.blockStates)
+ 	if newLen <= 0 {
+-		newLen = 1
++		newLen = 0
+ 	}
+
+ 	// Remove any blocks that appear in `other`.",the check can now be `if newLen < 0`
+4630,"@@ -8,18 +8,13 @@ import (
+ 	""os""
+ 	""time""
+
+-	""github.com/google/uuid""
+ 	log ""github.com/sirupsen/logrus""
+ 	""github.com/spf13/cobra""
+ 	""github.com/spf13/pflag""
+
+ 	apiextv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+-	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+-	""k8s.io/client-go/kubernetes""
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+-	""k8s.io/client-go/tools/leaderelection""
+-	""k8s.io/client-go/tools/leaderelection/resourcelock""
+ 	""k8s.io/klog""
+ 	apiregistrationv1 ""k8s.io/kube-aggregator/pkg/apis/apiregistration/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client/config""","If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...)"
+4631,"@@ -28,14 +28,13 @@ typedef boost::tokenizer<boost::char_separator<char> > tokenizer;
+ namespace ForceFields {
+ namespace MMFF {
+
+-class std::unique_ptr<MMFFAromCollection> MMFFAromCollection::ds_instance = nullptr;
+-
+ extern const std::uint8_t defaultMMFFArom[];
+
+ MMFFAromCollection *MMFFAromCollection::getMMFFArom(
+     const std::uint8_t *mmffArom) {
+-  if (!ds_instance || mmffArom) {
+-    ds_instance.reset(new MMFFAromCollection(mmffArom));
++  static std::unique_ptr<MMFFAromCollection> ds_instance(new MMFFAromCollection(nullptr));
++  if(mmffArom){
++    return new MMFFAromCollection(mmffArom);
+   }
+   return ds_instance.get();
+ }",Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not.
+4632,"@@ -360,6 +360,15 @@ class LocalStorage implements IStorage {
+       name,
+       (data, cb) => {
+         if (data._attachments[filename]) {
++          // get version form _attachments;
++          // there aways had 'version' in verdaccio publish package.
++          // but there was no 'version' in package witch unlink form npmjs
++          // see https://github.com/verdaccio/verdaccio/issues/1359
++          const version = data._attachments[filename].version;
++          if (version && data.versions[version] && data.time[version]) {
++            delete data.versions[version];
++            delete data.time[version];
++          }
+           delete data._attachments[filename];
+           cb();
+         } else {",form => from
+4633,"@@ -28,6 +28,7 @@ public interface Rule extends PropertySource {
+      * The property descriptor to universally suppress violations with messages
+      * matching a regular expression.
+      */
++    // TODO 7.0.0 use PropertyDescriptor<Pattern>
+     StringProperty VIOLATION_SUPPRESS_REGEX_DESCRIPTOR = new StringProperty(""violationSuppressRegex"",
+             ""Suppress violations with messages matching a regular expression"", null, Integer.MAX_VALUE - 1);
+ ","Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is then automatically converted into a Pattern."
+4634,"@@ -66,7 +66,9 @@ public class GoGapicSurfaceTransformerTest {
+             locator,
+             new String[] {""myproto_gapic.yaml""});
+
+-    productConfig = GapicProductConfig.create(model, configProto, TargetLanguage.GO);
++    productConfig =
++        GapicProductConfig.create(
++            model, configProto, ""google.example.myproto.v1"", TargetLanguage.GO);
+
+     if (model.getDiagReporter().getDiagCollector().hasErrors()) {
+       throw new IllegalStateException(","Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer."
+4635,"@@ -94,7 +94,7 @@ class CheckCompoundPattern {
+   CharsRef expandReplacement(CharsRef word, int breakPos) {
+     if (replacement != null && charsMatch(word, breakPos, replacement)) {
+       return new CharsRef(
+-          word.subSequence(0, breakPos)
++          new String(word.chars, 0, word.offset + breakPos)
+               + endChars
+               + beginChars
+               + word.subSequence(breakPos + replacement.length(), word.length));",Include all compounds parts from the very beginning for the case check to work later
+4636,"@@ -461,7 +461,7 @@ func get(envInfo *cmds.Agent, proxy proxy.Proxy) (*config.Node, error) {
+ 	}
+
+ 	if !nodeConfig.Docker && nodeConfig.ContainerRuntimeEndpoint == """" {
+-		nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.Containerd.Address
++		nodeConfig.AgentConfig.RuntimeSocket = ""unix://"" + nodeConfig.Containerd.Address
+ 	} else {
+ 		nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.ContainerRuntimeEndpoint
+ 		nodeConfig.AgentConfig.CNIPlugin = true","if the user specifies a url scheme on the cli this is going to cause problems, no?"
+4637,"@@ -726,7 +726,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
+             disableIndicators: true,
+             disableHoverMenu: true,
+             overlayPlayButton: true,
+-            width: dom.getWindowSize().innerWidth * 0.25
++            width: dom.getWindowSize().innerWidth * 0.5
+         });
+
+         elem.innerHTML = cardHtml;",How about that `scaleFactor`?
+4638,"@@ -273,6 +273,19 @@ class NonDivArithmeticOpAnalyzer
+         }
+     }
+
++    /**
++     * @param int|float $result
++     */
++    private static function getNumericalType($result): Type\Union
++    {
++        if ($result <= PHP_INT_MAX && $result >= PHP_INT_MIN) {
++            /** @var int $result */
++            return Type::getInt(false, $result);
++        }
++
++        return Type::getFloat($result);
++    }
++
+     /**
+      * @param  string[]        &$invalid_left_messages
+      * @param  string[]        &$invalid_right_messages","`assert(is_int($result));` would be preferable I think, even if we know it can't ever be false"
+4639,"@@ -162,14 +162,14 @@ class Cart
+     /**
+      * @return \Shopsys\FrameworkBundle\Model\Order\Item\QuantifiedProduct[]
+      */
+-    public function getQuantifiedProductsIndexedByItemId()
++    public function getQuantifiedProducts()
+     {
+-        $quantifiedProductsByItemId = [];
++        $quantifiedProducts = [];
+         foreach ($this->items as $item) {
+-            $quantifiedProductsByItemId[$item->getId()] = new QuantifiedProduct($item->getProduct(), $item->getQuantity());
++            $quantifiedProducts[] = new QuantifiedProduct($item->getProduct(), $item->getQuantity());
+         }
+
+-        return $quantifiedProductsByItemId;
++        return $quantifiedProducts;
+     }
+
+     /**",I'm unfortunately unable to review whether you've changed everything that used to use cartIds
+4640,"@@ -3,14 +3,15 @@ package de.danoeh.antennapod.dialog;
+ import android.app.Dialog;
+ import android.content.Context;
+ import android.content.SharedPreferences;
++import android.util.Log;
++
+ import androidx.annotation.Nullable;
+ import androidx.annotation.VisibleForTesting;
+-import android.util.Log;
++import androidx.appcompat.app.AlertDialog;
+
+ import java.lang.ref.WeakReference;
+ import java.util.concurrent.TimeUnit;
+
+-import androidx.appcompat.app.AlertDialog;
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.core.util.IntentUtils;
+ ",Please don't touch unrelated files to keep the git history clean
+4641,"@@ -0,0 +1,19 @@
++module AbTests
++  class LandingHeadlineTest < Base
++    def setup
++      variation(ab_test(test_name, ""orig"", ""v1""))
++    end
++
++    def finish
++      finished(test_name)
++    end
++
++  private
++
++    def variation(key)
++      # The :name value isn't needed in all variations. Passing it when it is
++      # not needed allows for simpler code and will do no harm.
++      I18n.t(""headlines.landing.#{key}"", name: I18n.t('shared.subscription.name'))
++    end
++  end
++end","Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that?"
+4642,"@@ -54,7 +54,7 @@ def gen_gaussian_target(heatmap, center, radius, k=1):
+     masked_heatmap = heatmap[y - top:y + bottom, x - left:x + right]
+     masked_gaussian = gaussian_kernel[radius - top:radius + bottom,
+                                       radius - left:radius + right]
+-    out_heatmap = torch.zeros_like(heatmap)
++    out_heatmap = heatmap
+     torch.max(
+         masked_heatmap,
+         masked_gaussian * k,",Will this change the input `heatmap`? Is this behavior expected or not?
+4643,"@@ -411,7 +411,7 @@ func init() {
+ 	runtime.RegisterPackageValue(""strings"", ""lastIndex"",
+ 		generateDualArgStringFunctionReturnInt(""lastIndex"", []string{stringArgV, substr}, strings.LastIndex))
+ 	runtime.RegisterPackageValue(""strings"", ""lastIndexAny"",
+-		generateDualArgStringFunctionReturnInt(""lastIndexAny"", []string{stringArgV, substr}, strings.LastIndexAny))
++		generateDualArgStringFunctionReturnInt(""lastIndexAny"", []string{stringArgV, chars}, strings.LastIndexAny))
+ 	runtime.RegisterPackageValue(""strings"", ""isDigit"",
+ 		generateUnicodeIsFunction(""isDigit"", unicode.IsDigit))
+ 	runtime.RegisterPackageValue(""strings"", ""isLetter"",","If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now?"
+4644,"@@ -1,8 +1,3 @@
+-/*
+-   Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-   SPDX-License-Identifier: Apache-2.0
+-*/
+-
+ package com.spring.sns;
+
+ import org.springframework.beans.factory.annotation.Autowired;",Need copyright/license info.
+4645,"@@ -3,10 +3,8 @@ package admissioncontroller
+ import (
+ 	""fmt""
+ 	""net/http""
+-	""strings""
+
+ 	admissionv1beta1 ""k8s.io/api/admission/v1beta1""
+-	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/klog/v2""
+
+ 	rulesv1 ""github.com/kubeedge/kubeedge/cloud/pkg/apis/rules/v1""","Is this `info log` necessary? If it is not useful, can you consider deleting it?"
+4646,"@@ -103,7 +103,7 @@ func TestConfigLoadEncryptedFailures(t *testing.T) {
+ 	err = config.Data().Load()
+ 	require.Error(t, err)
+
+-	// This file contains invalid base64 characters.
++	// This file's header starts with RCLONE_ENCRYPT_V1 instead of V0.
+ 	assert.NoError(t, config.SetConfigPath(""./testdata/enc-too-new.conf""))
+ 	err = config.Data().Load()
+ 	require.Error(t, err)","Unrelated change, but seems to be the correct purpose of the test."
+4647,"@@ -142,6 +142,7 @@ module.exports = class DragDrop extends Plugin {
+     const restrictions = this.uppy.opts.restrictions
+     return (
+       <input
++        id={'input-' + this.id}
+         class=""uppy-DragDrop-input""
+         type=""file""
+         tabindex={-1}",Should it be `'uppy-input-`?
+4648,"@@ -191,7 +191,7 @@ static inline double mtrace(int n,double A[8][8],double B[8][8]) {
+
+ void PairMGPT::make_triplet(bond_data *ij_bond,bond_data *ik_bond,
+                              triplet_data *triptr) {
+-  if (1) {
++  if (true) {
+     const trmul_fun tr_mul = linalg.tr_mul;
+     tr_mul(&(ij_bond->H.m[1][0]), &(ik_bond->H.m[1][0]) ,&(triptr->H1H2.m[1][0]) );
+     tr_mul(&(ij_bond->Hx.m[1][0]),&(ik_bond->H.m[1][0]) ,&(triptr->H1xH2.m[1][0]));",what's the reasoning to keep these always true or dead-code blocks?
+4649,"@@ -351,4 +351,13 @@ $(document).ready(function() {
+             }
+         });
+     }
++
++    $('body').on('click', '.tab-buttons > div', function() {
++        if ($(this).next().length === 1) {
++            $('.widget-content').addClass('hide-zoom');
++        }
++        else {
++            $('.widget-content').removeClass('hide-zoom');
++        }
++    });
+ });","It would be a good practice to do `.off('click', '.tab-buttons > div').on('click', '.tab-buttons > div', function() {`"
+4650,"@@ -307,9 +307,12 @@ func buildControllerContext(ctx context.Context, opts *options.ControllerOptions
+ 		KubeSharedInformerFactory: kubeSharedInformerFactory,
+ 		SharedInformerFactory:     sharedInformerFactory,
+ 		GWShared:                  gwSharedInformerFactory,
+-		Namespace:                 opts.Namespace,
+-		Clock:                     clock.RealClock{},
+-		Metrics:                   metrics.New(log, clock.RealClock{}),
++		// TODO (@jakexks) / code reviewer: should this be automatically enabled or disabled based on discovering the gateway
++		// api or a flag?
++		GatewaySolverEnabled: true,
++		Namespace:            opts.Namespace,
++		Clock:                clock.RealClock{},
++		Metrics:              metrics.New(log, clock.RealClock{}),
+ 		ACMEOptions: controller.ACMEOptions{
+ 			HTTP01SolverImage:                 opts.ACMEHTTP01SolverImage,
+ 			HTTP01SolverResourceRequestCPU:    HTTP01SolverResourceRequestCPU,","I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 should also use this `GatewaySolverEnabled` flag I think."
+4651,"@@ -1180,6 +1180,7 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+
+     try {
+       configureLogging(true);
++      instantiateSignatureAlgorithmFactory();
+       configureNativeLibs();
+       logger.info(""Starting Besu version: {}"", BesuInfo.nodeName(identityString));
+       // Need to create vertx after cmdline has been parsed, such that metricsSystem is configurable","I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu."
+4652,"@@ -1,11 +1,16 @@
++from typing import TYPE_CHECKING
++
+ from astroid import nodes
+
+ from pylint.checkers import BaseChecker
+ from pylint.interfaces import IAstroidChecker
+
++if TYPE_CHECKING:
++    from pylint.lint import PyLinter
+
+-# This is our checker class.
+ # Checkers should always inherit from `BaseChecker`.
++
++
+ class MyAstroidChecker(BaseChecker):
+     """"""Add class member attributes to the class local's dictionary.""""""
+ ",Why remove this?
+4653,"@@ -490,6 +490,18 @@ class Builder {
+     return this;
+   }
+
++  /**
++   * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
++   * child process when creating IE sessions locally.
++   *
++   * @param {ie.ServiceBuilder} service the service to use.
++   * @return {!Builder} a self reference.
++   */
++  setIeService(service) {
++    this.ieService_ = service;
++    return this;
++  }
++
+   /**
+    * Set {@linkplain edge.Options options} specific to Microsoft's Edge browser
+    * for drivers created by this builder. Any proxy settings defined on the",`this.ieService_` should be initialized to null in the constructor.
+4654,"@@ -394,7 +394,7 @@ int main(int argc, char **argv)
+         cflags.push_back(generate_header_filter_cflag(response_header_filters));
+     }
+
+-    ebpf::BPF *bpf = new ebpf::BPF();
++    std::unique_ptr<ebpf::BPF> bpf(new ebpf::BPF());
+     std::vector<ebpf::USDT> probes;
+
+     bool selective_tracing = false;","Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value."
+4655,"@@ -19,8 +19,11 @@ package controller
+ import (
+ 	""errors""
+ 	""fmt""
++	""strings""
+ 	""time""
+
++	apiutil ""github.com/jetstack/cert-manager/pkg/api/util""
++
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+
+ 	cmapi ""github.com/jetstack/cert-manager/pkg/apis/certmanager/v1""",nit: move to last block
+4656,"@@ -15,8 +15,8 @@ import (
+ 	""syscall""
+
+ 	""github.com/hashicorp/hcl""
+-	""github.com/spiffe/spire/helpers""
+ 	""github.com/spiffe/spire/pkg/agent""
++	""github.com/spiffe/spire/pkg/common/logger""
+ )
+
+ const (","nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces"
+4657,"@@ -272,6 +272,12 @@ namespace NLog.Targets
+         [ArrayParameter(typeof(DatabaseParameterInfo), ""parameter"")]
+         public IList<DatabaseParameterInfo> Parameters { get; } = new List<DatabaseParameterInfo>();
+
++        /// <summary>
++        /// Configures isolated transaction batch writing. If supported by the database, then it will improve insert performance.
++        /// </summary>
++        /// <docgen category='Performance Tuning Options' order='10' />
++        public System.Data.IsolationLevel? IsolationLevel { get; set; }
++
+ #if !NETSTANDARD
+         internal DbProviderFactory ProviderFactory { get; set; }
+ ",Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss?
+4658,"@@ -24,15 +24,8 @@ var (
+
+ // Action is the action can be Executed in protocols. The method is added to avoid mistakenly used empty interface as action.
+ type Action interface {
+-	SetEnvelopeContext(SealedEnvelope)
+-	SanityCheck() error
+-}
+-
+-type actionPayload interface {
+-	Serialize() []byte
+ 	Cost() (*big.Int, error)
+ 	IntrinsicGas() (uint64, error)
+-	SetEnvelopeContext(SealedEnvelope)
+ 	SanityCheck() error
+ }
+ ",do we still need SanityCheck()? seems they all return nil now
+4659,"@@ -94,7 +94,6 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
+    * @type {HTMLElement}
+    */
+   this.rootElement = rootElement;
+-  /* eslint-enable jsdoc/require-description-complete-sentence */
+   /**
+    * The nearest document over container.
+    *","What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is legacy."
+4660,"@@ -48,4 +48,4 @@ doc.css(""h1, h2, h3, h4, h5, h6"").each do |header|
+ end
+
+ puts ""\n==================================================\n""
+-puts ""!!! Don't forget to set a summary: https://#{ENV.fetch(""APP_DOMAIN"")}/admin/video/#{video.id}/edit""
++puts ""!!! Don't forget to set a summary: https://thoughtbot.com/upcase/admin/video/#{video.id}/edit""",Line is too long. [100/80]
+4661,"@@ -532,8 +532,12 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
+ 		return err
+ 	}
+
+-	if !gopts.JSON && parentSnapshotID != nil {
+-		p.V(""using parent snapshot %v\n"", parentSnapshotID.Str())
++	if !gopts.JSON {
++		if parentSnapshotID != nil {
++			p.P(""using parent snapshot %v\n"", parentSnapshotID.Str())
++		} else {
++			p.P(""no parent snapshot found, will read all files\n"")
++		}
+ 	}
+
+ 	selectByNameFilter := func(item string) bool {","I suggest ""no parent snapshot found, will read all data\n""."
+4662,"@@ -48,9 +48,7 @@ namespace NLog.UnitTests
+         {
+             using (new NoThrowNLogExceptions())
+             {
+-                LogManager.ThrowExceptions = true;
+-
+-                LogManager.Configuration = XmlLoggingConfiguration.CreateFromXmlString(@""
++                var config = XmlLoggingConfiguration.CreateFromXmlString(@""
+                 <nlog throwExceptions='false'>
+                     <targets><target type='MethodCall' name='test' methodName='Throws' className='NLog.UnitTests.LogFactoryTests, NLog.UnitTests.netfx40' /></targets>
+                     <rules>",`LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load?
+4663,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return ""'"" + value + ""'"";
+ 	} else {
+-		return '""""';
++		return ""'"";
+ 	}
+ }
+ ","It should be return ""''""; I will fix it"
+4664,"@@ -100,11 +100,10 @@ public class AcceptanceTest extends STBBaseTst {
+         ASTMethodDeclaration node = acu.findDescendantsOfType(ASTMethodDeclaration.class).get(0);
+         Scope s = node.getScope();
+         Map<NameDeclaration, List<NameOccurrence>> m = s.getDeclarations();
+-        for (Iterator<NameDeclaration> i = m.keySet().iterator(); i.hasNext();) {
+-            NameDeclaration d = i.next();
+-            assertEquals(""buz"", d.getImage());
+-            assertEquals(""ArrayList"", ((TypedNameDeclaration) d).getTypeImage());
+-            List<NameOccurrence> u = m.get(d);
++        for (Map.Entry<NameDeclaration, List<NameOccurrence>> entry : m.entrySet()) {
++            assertEquals(""buz"", entry.getKey().getImage());
++            assertEquals(""ArrayList"", ((TypedNameDeclaration) entry.getKey()).getTypeImage());
++            List<NameOccurrence> u = m.get(entry.getKey());
+             assertEquals(1, u.size());
+             NameOccurrence o = u.get(0);
+             int beginLine = o.getLocation().getBeginLine();","This is wrong, should be `entry.getValue()`"
+4665,"@@ -363,7 +363,7 @@ func (r *ReconcileControlPlaneCerts) getServingCertificatesJSONPatch(cd *hivev1.
+ 			additional.Domain, remoteSecretName(bundle.CertificateSecretRef.Name, cd)))
+ 	}
+
+-	var kubeAPIServerNamedCertsTemplate = `[ { ""op"": ""replace"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [ %s ] } ]`
++	var kubeAPIServerNamedCertsTemplate = `[ { ""op"": ""add"", ""path"": ""/spec/servingCerts"", ""value"": {} }, { ""op"": ""add"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [  ] }, { ""op"": ""replace"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [ %s ] } ]`
+ 	namedCerts := buf.String()
+ 	return fmt.Sprintf(kubeAPIServerNamedCertsTemplate, namedCerts), nil
+ ","nit: why can't we combine the two add operations into one so that we add `{""nameCertificates"": []}` to `/spec/servingCerts` ?"
+4666,"@@ -3,13 +3,14 @@
+ // See the LICENSE file in the project root for more information.
+
+ // ==++==
+-//
+-
+-//
++//
++
++//
+ // ==--==
+ #include <assert.h>
+ #include ""sos.h""
+ #include ""safemath.h""
++#include ""holder.h""
+
+
+ // This is the increment for the segment lookup data",These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs.
+4667,"@@ -19,11 +19,13 @@ public abstract class RoomHandler
+
+ 	protected final Client client;
+ 	protected final TheatrePlugin plugin;
++	protected final TheatreConfig config;
+
+-	protected RoomHandler(final Client client, final TheatrePlugin plugin)
++	protected RoomHandler(final Client client, final TheatrePlugin plugin, TheatreConfig config)
+ 	{
+ 		this.client = client;
+ 		this.plugin = plugin;
++		this.config = config;
+ 	}
+
+ 	public abstract void onStart();",why does this suddenly need a config ref
+4668,"@@ -99,6 +99,10 @@ module.exports = function(config) {
+ 		customLaunchers: sauceLabs ? sauceLabsLaunchers : travisLaunchers,
+
+ 		files: [
++			// We can't load this up front because it's ES2015 and we need it only
++			// for certain tests that run under those conditions. We also can't load
++			// it via CDN because { included: false } won't work.
++			{ pattern: 'custom-elements-es5-adapter.js', included: false },
+ 			{ pattern: 'polyfills.js', watched: false },
+ 			{ pattern: '{browser,shared}/**.js', watched: false }
+ 		],","Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it."
+4669,"@@ -67,6 +67,10 @@ exclude = [""AuthalicMatrixCoefficients"",
+            ""vnl_file_matrix"",
+            ""vnl_file_vector"",
+            ""vnl_fortran_copy"",
++           ""CosineWindowFunction"",
++           ""HammingWindowFunction"",
++           ""LanczosWindowFunction"",
++           ""WelchWindowFunction"",
+            ]
+
+ total = 0","Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)."
+4670,"@@ -27,7 +27,7 @@ import (
+ // This little bit of wrapping needs to be done because go doesn't do
+ // covariance, but it does coerce *time.Timer into stoppable implicitly if we
+ // write it out like so.
+-var afterFunc = func(c clock.Clock, d time.Duration, f func()) stoppable {
++func afterFunc(c clock.Clock, d time.Duration, f func()) stoppable {
+ 	t := c.NewTimer(d)
+
+ 	go func() {","Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability?"
+4671,"@@ -27,8 +27,7 @@ MolDraw2DQt::MolDraw2DQt(int width, int height, QPainter &qp, int panelWidth,
+ // ****************************************************************************
+ void MolDraw2DQt::setColour(const DrawColour &col) {
+   MolDraw2D::setColour(col);
+-  QColor this_col(int(255.0 * col.get<0>()), int(255.0 * col.get<1>()),
+-                  int(255.0 * col.get<2>()));
++  QColor this_col(int(255.0 * col.r), int(255.0 * col.g), int(255.0 * col.b));
+
+   QPen pen(this_col);
+   pen.setJoinStyle(Qt::RoundJoin);",I'm assuming that MolDraw2Qt drops the alpha channel?
+4672,"@@ -24,6 +24,9 @@ namespace System.Text.Json.Serialization.Tests
+     [GenericTypeArguments(typeof(HashSet<string>))]
+     [GenericTypeArguments(typeof(ArrayList))]
+     [GenericTypeArguments(typeof(Hashtable))]
++    [GenericTypeArguments(typeof(SimpleStructWithProperties))]
++    [GenericTypeArguments(typeof(LargeStructWithProperties))]
++    [GenericTypeArguments(typeof(int))]
+     public class ReadJson<T>
+     {
+         private string _serialized;","the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer."
+4673,"@@ -472,7 +472,18 @@ class Composition(collections.Hashable, collections.Mapping, MSONable):
+
+         Returns:
+             Composition with that formula.
++
++        Notes:
++            In the case of Metallofullerene formula (e.g. Y3N@C80),
++            the @ mark will be dropped and passed to parser.
+         """"""
++        print(formula)
++        # for Metallofullerene like ""Y3N@C80""
++        if ""@"" in formula:
++            print(formula)
++            formula = formula.replace(""@"", """")
++            print(formula)
++
+         def get_sym_dict(f, factor):
+             sym_dict = collections.defaultdict(float)
+             for m in re.finditer(r""([A-Z][a-z]*)\s*([-*\.\d]*)"", f):","Pls remove the print statements. Also, you do not need the if statement."
+4674,"@@ -112,7 +112,7 @@ def patch_moto():
+
+     # escape message responses to allow for special characters like ""<""
+     sqs_responses.RECEIVE_MESSAGE_RESPONSE = sqs_responses.RECEIVE_MESSAGE_RESPONSE.replace(
+-        ""<StringValue>{{ value.string_value }}</StringValue>"",
++        ""<StringValue><![CDATA[{{ value.string_value }}]]></StringValue>"",
+         ""<StringValue>{{ _escape(value.string_value) }}</StringValue>"",
+     )
+ ","Thanks for this fix @eltone !   Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks"
+4675,"@@ -91,6 +91,7 @@ func newSimpleClientV7(url string) (*clientV7, error) {
+ 	var err error
+ 	if client, err = elastic.NewClient(
+ 		elastic.SetURL(url),
++		elastic.SetSniff(false),
+ 		elastic.SetRetrier(retrier),
+ 	); err != nil {
+ 		return nil, err",Should this be instead a configurable option?
+4676,"@@ -64,6 +64,13 @@ func (c *CreateDisks) run(ctx context.Context, s *Step) DError {
+ 				}
+ 			}
+
++			// Get the source snapshot link if using a source snapshot.
++			if cd.SourceSnapshot != """" {
++				if snapshot, ok := w.snapshots.get(cd.SourceSnapshot); ok {
++					cd.SourceSnapshot = snapshot.link
++				}
++			}
++
+ 			w.LogStepInfo(s.name, ""CreateDisks"", ""Creating disk %q."", cd.Name)
+ 			if err := w.ComputeClient.CreateDisk(cd.Project, cd.Zone, &cd.Disk); err != nil {
+ 				// Fallback to pd-standard to avoid quota issue.",unit test needs an update?
+4677,"@@ -12,7 +12,6 @@ module.exports = class Provider extends RequestClient {
+     super(uppy, opts)
+     this.provider = opts.provider
+     this.id = this.provider
+-    this.authProvider = opts.authProvider || this.provider
+     this.name = this.opts.name || _getName(this.id)
+     this.pluginId = this.opts.pluginId
+     this.tokenKey = `companion-${this.pluginId}-auth-token`",I realised that this is not used anywhere
+4678,"@@ -187,6 +187,7 @@ func watchConfig(cfg *config.Config, stopCh <-chan struct{}) {
+ 				case <-stopCh:
+ 					close(sigChan)
+ 					return
++				default:
+ 				}
+ 			}
+ 		}()",why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time?
+4679,"@@ -1477,6 +1477,8 @@ func handleUSB(intr interrupt.Interrupt) {
+ 			// clear stall request
+ 			setEPINTENCLR(0, sam.USB_DEVICE_EPINTENCLR_STALL1)
+ 		}
++	} else {
++		sendZlp()
+ 	}
+
+ 	// Now the actual transfer handlers, ignore endpoint number 0 (setup)",This line appears to have caused the regression. What is it supposed to be doing?
+4680,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done
+4681,"@@ -39,13 +39,11 @@ namespace OpenTelemetry.Metrics
+             configure?.Invoke(options);
+
+             var exporter = new PrometheusExporter(options);
+-
+-            var metricReader = new BaseExportingMetricReader(exporter);
+-            exporter.CollectMetric = metricReader.Collect;
++            var reader = new BaseExportingMetricReader(exporter);
+
+             var metricsHttpServer = new PrometheusExporterMetricsHttpServer(exporter);
+             metricsHttpServer.Start();
+-            return builder.AddMetricReader(metricReader);
++            return builder.AddMetricReader(reader);
+         }
+     }
+ }","@alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be OKAY. A better version could be - we only start the HTTP server once the exporter/reader are fully ready and both are hooked up to the provider."
+4682,"@@ -224,7 +224,13 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore
+
+                 if (!process.HasExited)
+                 {
+-                    process.Kill();
++                    // Try shutting down gracefully
++                    await SubmitRequest(aspNetCorePort, ""/shutdown"");
++
++                    if (!process.WaitForExit(5000))
++                    {
++                        process.Kill();
++                    }
+                 }
+
+                 SpanTestHelpers.AssertExpectationsMet(Expectations, spans);","As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too?"
+4683,"@@ -0,0 +1,16 @@
++using System;
++using System.Net.Http;
++
++namespace OpenTelemetry.Exporter
++{
++    public interface IHttpClientFactoryExporterOptions
++    {
++        /// <summary>
++        /// Gets or sets the factory function called to create the <see
++        /// cref=""HttpClient""/> instance that will be used at runtime to
++        /// transmit telemetry over HTTP. The returned instance will be reused
++        /// for all export invocations.
++        /// </summary>
++        public Func<HttpClient> HttpClientFactory { get; set; }
++    }
++}",Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself.
+4684,"@@ -12,6 +12,6 @@ return [
+     |
+     */
+
+-    'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'failed' => 'یہ تفصیلات درست نہیں ہیں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈ میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing
+4685,"@@ -149,7 +149,7 @@ class KeywordArgument(object):
+     func = lambda arg=arg: arg * arg # [undefined-variable]
+
+     arg2 = 0
+-    func2 = lambda arg2=arg2: arg2 * arg2
++    func3 = lambda arg2=arg2: arg2 * arg2
+
+ # Don't emit if the code is protected by NameError
+ try:",change of name is not needed
+4686,"@@ -120,10 +120,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         self.assertEqual(kser.name, ""renamed"")
+         self.assert_eq(kser, pser)
+
+-        pser.name = None
+-        kser.name = None
+-        self.assertEqual(kser.name, None)
+-        self.assert_eq(kser, pser)
++        # pser.name = None
++        # kser.name = None
++        # self.assertEqual(kser.name, None)
++        # self.assert_eq(kser, pser)
+
+         pidx = pser.index
+         kidx = kser.index",Hm .. so this case doesn't work anymore?
+4687,"@@ -22,7 +22,8 @@
+ import os
+ import tempfile
+
+-from PyQt5.QtCore import pyqtSignal, pyqtSlot, QObject, QProcess
++from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QProcess,
++    QFileSystemWatcher)
+
+ from qutebrowser.config import config
+ from qutebrowser.utils import message, log",Please indent this so it lines up with the `(`
+4688,"@@ -23,10 +23,11 @@ function roots_scripts() {
+   if (is_single() && comments_open() && get_option('thread_comments')) {
+     wp_enqueue_script('comment-reply');
+   }
+-
+-  wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
++
++  // Not included by default since this code is used for debugging javas in the console. Uncomment next line and wp_enqueue_script below to use it.
++  //wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
+   wp_register_script('roots_main', get_template_directory_uri() . '/js/main.js', false, null, false);
+-  wp_enqueue_script('roots_plugins');
++  //wp_enqueue_script('roots_plugins');
+   wp_enqueue_script('roots_main');
+ }
+ ",We should still register the script. Just not enqueue it.
+4689,"@@ -20,7 +20,7 @@ module Mongoid #:nodoc:
+     def changes
+       {}.tap do |hash|
+         changed.each do |name|
+-          change = attribute_change(name)
++          change = [changed_attributes[name], attributes[name]] if attribute_changed?(name)
+           hash[name] = change if change[0] != change[1]
+         end
+       end",I think this can stay as a method. And we can write our own attribute_change(name) as required.
+4690,"@@ -142,7 +142,8 @@ namespace MvvmCross.DroidX.RecyclerView
+
+         protected virtual View InflateViewForHolder(ViewGroup parent, int viewType, IMvxAndroidBindingContext bindingContext)
+         {
+-            return bindingContext.BindingInflate(viewType, parent, false);
++            var layoutId = ItemTemplateSelector.GetItemLayoutId (viewType);
++            return bindingContext.BindingInflate(layoutId, parent, false);
+         }
+
+         public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position)","@alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which makes sense - the template selector can return the layout id based on the index of the item in the list."
+4691,"@@ -96,6 +96,9 @@ class BQTable(collections.namedtuple('BQTable', 'project_id dataset_id table_id'
+         return ""bq://"" + self.project_id + ""/"" + \
+                self.dataset.dataset_id + ""/"" + self.table_id
+
++    def __str__(self):
++        return ""%s:%s.%s"" % (self.project_id, self.dataset_id, self.table_id)
++
+
+ class BigqueryClient(object):
+     """"""A client for Google BigQuery.",Can you change this to use `.format()`?
+4692,"@@ -308,13 +308,15 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+
+-	if dropEncap {
++	if dropEncap && r.Config.DropVXLANPacketsFromWorkloads {
+ 		rules = append(rules, Rule{
+ 			Match: Match().ProtocolNum(ProtoUDP).
+ 				DestPorts(uint16(r.Config.VXLANPort)),
+ 			Action:  DropAction{},
+ 			Comment: []string{""Drop VXLAN encapped packets originating in pods""},
+ 		})
++	}
++	if dropEncap && r.Config.DropIPIPPacketsFromWorkloads {
+ 		rules = append(rules, Rule{
+ 			Match:   Match().ProtocolNum(ProtoIPIP),
+ 			Action:  DropAction{},",Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set?
+4693,"@@ -47,11 +47,11 @@ type SectorBuilder interface {
+ 	// which will fit into a newly-provisioned staged sector.
+ 	GetMaxUserBytesPerStagedSector() (uint64, error)
+
+-	// GeneratePoST creates a proof-of-spacetime for the replicas managed by
++	// GeneratePoSt creates a proof-of-spacetime for the replicas managed by
+ 	// the SectorBuilder. Its output includes the proof-of-spacetime proof which
+ 	// is posted to the blockchain along with any faults. The proof can be
+ 	// verified by the VerifyPoSt method on the Verifier interface.
+-	GeneratePoST(GeneratePoSTRequest) (GeneratePoSTResponse, error)
++	GeneratePoSt(GeneratePoStRequest) (GeneratePoStResponse, error)
+
+ 	// Close signals that this SectorBuilder is no longer in use. SectorBuilder
+ 	// metadata will not be deleted when Close is called; an equivalent",new casing is less ELiTE
+4694,"@@ -179,6 +179,14 @@ bool wlr_renderer_blit_dmabuf(struct wlr_renderer *r,
+ 	return r->impl->blit_dmabuf(r, dst, src);
+ }
+
++GLuint wlr_renderer_renderbuffer_from_image(struct wlr_renderer *r,
++		EGLImageKHR image) {
++	if (!r->impl->renderbuffer_from_image) {
++		return false;
++	}
++	return r->impl->renderbuffer_from_image(image);
++}
++
+ bool wlr_renderer_format_supported(struct wlr_renderer *r,
+ 		enum wl_shm_format fmt) {
+ 	return r->impl->format_supported(r, fmt);",This leaks EGL/GL implementation details into the generic renderer interface.
+4695,"@@ -32,6 +32,16 @@ module Travis
+       end
+     end
+
++    class DeployConditionError < DeployConfigError
++      def initialize(msg = ""The \\`deploy.on\\` should be a hash (dictionary)."")
++        super
++      end
++
++      def doc_path
++        '/user/deployment#Conditional-Releases-with-on%3A'
++      end
++    end
++
+     class AptSourcesConfigError < CompilationError
+       def initialize(msg = ""\\`apt\\` should be a hash with key \\`sources\\` and an array as a value."")
+         super","Maybe add *key* i.e. `""The \\`deploy.on\\` key should be a hash (dictionary).`"
+4696,"@@ -75,7 +75,7 @@ class StatusGridBuilder implements GridBuilderInterface
+     {
+         $result = [];
+         foreach ($this->statusQuery->getAllStatuses($language) as $code => $status) {
+-            $result[] = new StatusOption($code, $code, new Color($status['color']), $status['name']);
++            $result[] = new StatusOption($code, $status['code'], new Color($status['color']), $status['name']);
+         }
+
+         return $result;","its be good also change $code na $id, actual name is misleading and that was probably actual error generator"
+4697,"@@ -10,9 +10,8 @@ from listenbrainz.listenstore import ListenStore
+
+ class RedisListenStore(ListenStore):
+
+-    RECENT_LISTENS_KEY = ""lb_recent_listens""
+-    RECENT_LISTENS_MAX = 100
+-    RECENT_LISTENS_MAX_TIME_DIFFERENCE = 300
++    RECENT_LISTENS_KEY = ""lb_recent_sorted""
++    RECENT_LISTENS_MAX = 100
+
+     def __init__(self, log, conf):
+         super(RedisListenStore, self).__init__(log)","I changed the name of the key, to make deployment easier."
+4698,"@@ -545,6 +545,7 @@ func environmentConfig() (Config, error) {
+ 		NvidiaRuntime:                       os.Getenv(""ECS_NVIDIA_RUNTIME""),
+ 		TaskMetadataAZDisabled:              utils.ParseBool(os.Getenv(""ECS_DISABLE_TASK_METADATA_AZ""), false),
+ 		CgroupCPUPeriod:                     parseCgroupCPUPeriod(),
++		SpotInstanceDrainingEnabled:         utils.ParseBool(os.Getenv(""ECS_SPOT_INSTANCE_DRAINING_ENABLED""), false),
+ 	}, err
+ }
+ ","isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false."
+4699,"@@ -3,6 +3,8 @@ Provides Dimension objects for tracking the properties of a value,
+ axis or map dimension. Also supplies the Dimensioned abstract
+ baseclass for classes that accept Dimension values.
+ """"""
++from __future__ import unicode_literals
++
+ import re
+ from operator import itemgetter
+ ",Do you think we might need this anywhere else in HoloViews?
+4700,"@@ -3,7 +3,9 @@ export function getDisplayPlayMethod(session) {
+         return null;
+     }
+
+-    if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
++    if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect && session.TranscodingInfo.IsAudioDirect) {
++        return 'Remux';
++    } else if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
+         return 'DirectStream';
+     } else if (session.PlayState.PlayMethod === 'Transcode') {
+         return 'Transcode';",@MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case.
+4701,"@@ -36,7 +36,7 @@ module Asciidoctor
+         opts_parser = OptionParser.new do |opts|
+           opts.banner = <<-EOS
+ Usage: asciidoctor [OPTION]... [FILE]
+-Translate the AsciiDoc source FILE into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
++Translate the AsciiDoc source FILE, or multiple FILE(s) into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
+ By default, the output is written to a file with the basename of the source file and the appropriate extension.
+ Example: asciidoctor -b html5 source.asciidoc
+ ",I have followed the convention of `cp`
+4702,"@@ -8390,11 +8390,11 @@ return [
+ 'mysql_xdevapi\tableupdate::where' => ['mysql_xdevapi\TableUpdate', 'where_expr'=>'string'],
+ 'mysqli::__construct' => ['void', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null'],
+ 'mysqli::autocommit' => ['bool', 'enable'=>'bool'],
+-'mysqli::begin_transaction' => ['bool', 'flags='=>'int', 'name='=>'string'],
++'mysqli::begin_transaction' => ['bool', 'flags='=>'int', 'name='=>'?string'],
+ 'mysqli::change_user' => ['bool', 'username'=>'string', 'password'=>'string', 'database'=>'string'],
+ 'mysqli::character_set_name' => ['string'],
+ 'mysqli::close' => ['bool'],
+-'mysqli::commit' => ['bool', 'flags='=>'int', 'name='=>'string'],
++'mysqli::commit' => ['bool', 'flags='=>'int', 'name='=>'?string'],
+ 'mysqli::connect' => ['bool', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null'],
+ 'mysqli::debug' => ['bool', 'options'=>'string'],
+ 'mysqli::disable_reads_from_master' => ['bool'],",The docs say it's `false|null`
+4703,"@@ -130,9 +130,14 @@ func (c *localCircuitBreaker) checkAndSet() {
+
+ // Config represents the configuration of a circuit breaker.
+ type Config struct {
++	// The threshold over sliding window that would trip the circuit breaker
+ 	Threshold float64 `json:""threshold""`
+-	Type      string  `json:""type""`
+-	TripTime  string  `json:""trip_time""`
++	// Possible values: latency, error_ratio, and status_ratio. It
++	// defaults to latency.
++	Type string `json:""type""`
++	// How long to wait after the circuit is tripped before allowing operations to resume.
++	// The default is 5s.
++	TripTime string `json:""trip_time""`
+ }
+
+ const (","Thinking on it more, I actually really like your idea to rename `type` to `factor`."
+4704,"@@ -45,7 +45,11 @@ public class MessageWebView extends WebView {
+          * will network images that are already in the WebView cache.
+          *
+          */
+-        getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
++        try {
++            getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
++        } catch(SecurityException e) {
++            Timber.e(e, ""SecurityException in blockNetworkData(final boolean shouldBlockNetworkData)"");
++        }
+     }
+
+ ","This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I suggest changing the message to: ""Failed to unblock network loads. Missing INTERNET permission?"""
+4705,"@@ -1,11 +1,9 @@
+-# -*- coding: UTF-8 -*-
+-#shlobj.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2017 NV Access Limited, Babbage B.V.
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2009-2021 NV Access Limited, Babbage B.V.
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+-""""""
++r""""""
+ This module wraps the SHGetFolderPath function in shell32.dll and defines the necessary contstants.
+ CSIDL (constant special item ID list) values provide a unique system-independent way to
+ identify special folders used frequently by applications, but which may not have the same name",Feel free to add your own name while at it.
+4706,"@@ -30,11 +30,11 @@ import (
+ )
+
+ var (
+-	alias    string
+ 	bytecode []byte
+ 	gasLimit uint64
+ 	gasPrice int64
+ 	nonce    uint64
++	signer   string
+ )
+
+ // ActionCmd represents the account command",`signer` is a global variable (from `gochecknoglobals`)
+4707,"@@ -74,8 +74,12 @@ module Mongoid
+         # @return [ String ] The normalized key.
+         #
+         # @since 1.0.0
+-        def normalized_key(name, serializer)
+-          serializer && serializer.localized? ? ""#{name}.#{::I18n.locale}"" : name
++        def normalized_key(name, serializer, opts = {})
++          if serializer && serializer.localized? && opts[:localize] != false
++            ""#{name}.#{::I18n.locale}""
++          else
++            name
++          end
+         end
+
+         # Get the pair of objects needed to store the value in a hash by the",shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?)
+4708,"@@ -17,6 +17,7 @@ from .number_types import (UOffsetTFlags, SOffsetTFlags, VOffsetTFlags)
+
+ from . import encode
+ from . import packer
++import pickle
+
+ from . import compat
+ from .compat import range_func",This can also be removed.
+4709,"@@ -32,7 +32,8 @@ SYNOPSIS
+                           const char *key);
+
+  int flux_kvs_txn_symlink (flux_kvs_txn_t *txn, int flags,
+-                           const char *key, const char *target);
++                           const char *key, const char *ns,
++                           const char *target);
+
+  int flux_kvs_txn_put_raw (flux_kvs_txn_t *txn, int flags,
+                            const char *key, const void *data, int len);","Not critical but ""common"" is not that helpful in the commit title. Maybe go with ""libkvs/txn:"" for this one?"
+4710,"@@ -277,6 +277,7 @@ class YamlConfig(QObject):
+             self._mark_changed()
+
+         self._migrate_bool(settings, 'tabs.favicons.show', 'always', 'never')
++        self._migrate_bool(settings, 'scrolling.bar', 'when_searching', 'never')
+         self._migrate_bool(settings, 'qt.force_software_rendering',
+                            'software-opengl', 'none')
+ ","It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new feature). I fixed this in cc0f5fc6d400e12833ba729049e31d16cf836d53."
+4711,"@@ -27,7 +27,7 @@ class RRDReader(BaseReader):
+     def _convert_fs_path(fs_path):
+         if isinstance(fs_path, six.text_type):
+             fs_path = fs_path.encode(sys.getfilesystemencoding())
+-        return os.path.realpath(fs_path)
++        return os.path.realpath(fs_path).decode(""utf-8"")
+
+     def __init__(self, fs_path, datasource_name):
+         self.fs_path = RRDReader._convert_fs_path(fs_path)",.decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes..
+4712,"@@ -0,0 +1,9 @@
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpHeadersHandler
++    {
++        void OnHeader(Span<byte> name, Span<byte> value);
++    }
++}","An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill."
+4713,"@@ -51,15 +51,10 @@ namespace NLog
+         private const int StackTraceSkipMethods = 0;
+
+         [System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Naming"", ""CA2204:Literals should be spelled correctly"", Justification = ""Using 'NLog' in message."")]
+-        internal static void Write([NotNull] Type loggerType, TargetWithFilterChain targets, LogEventInfo logEvent, LogFactory factory)
++        internal static void Write([NotNull] Type loggerType, [NotNull] TargetWithFilterChain targetsForLevel, LogEventInfo logEvent, LogFactory factory)
+         {
+-            if (targets == null)
+-            {
+-                return;
+-            }
+-
+ #if !NETSTANDARD1_0 || NETSTANDARD1_5
+-            StackTraceUsage stu = targets.GetStackTraceUsage();
++            StackTraceUsage stu = targetsForLevel.GetStackTraceUsage();
+             if (stu != StackTraceUsage.None && !logEvent.HasStackTrace)
+             {
+ #if NETSTANDARD1_5","Resharper annotations, always +1"
+4714,"@@ -46,6 +46,8 @@ var accountCreateAddCmd = &cobra.Command{
+ func init() {
+ 	accountCreateAddCmd.Flags().BoolVar(&CryptoSm2, ""sm2"", false,
+ 		config.TranslateInLang(flagSm2Usage, config.UILanguage))
++	accountCreateAddCmd.Flags().MarkHidden(""sm2"")
++
+ }
+
+ func accountCreateAdd(args []string) error {","same here, CryptoSm2 won't be changed once command is compiled"
+4715,"@@ -655,6 +655,13 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+ 		try {
+ 			certChain = KeyChain.getCertificateChain(activity, alias);
+ 			key = KeyChain.getPrivateKey(activity, alias);
++			activity.runOnUiThread(new Runnable() {
++
++                @Override
++                public void run() {
++                	loadLoginPage();
++                }
++            });
+ 		} catch (KeyChainException e) {
+ 			e.printStackTrace();
+ 		} catch (InterruptedException e) {",Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread.
+4716,"@@ -52,7 +52,7 @@ func (v *ConfigValidator) Validate(config *configs.Config) error {
+ 	}
+ 	for _, c := range warns {
+ 		if err := c(config); err != nil {
+-			logrus.WithError(err).Warnf(""invalid configuration"")
++			logrus.WithError(err).Warn(""invalid configuration"")
+ 		}
+ 	}
+ 	return nil",Technically it doesn't belong here; let me remove it.
+4717,"@@ -78,7 +78,7 @@ MARKER_FILE_LIGHT_VERSION = ""%s/.light-version"" % dirs.static_libs
+ IMAGE_NAME_SFN_LOCAL = ""amazon/aws-stepfunctions-local""
+ ARTIFACTS_REPO = ""https://github.com/localstack/localstack-artifacts""
+ SFN_PATCH_URL_PREFIX = (
+-    f""{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunctions-local-patch""
++    f""{ARTIFACTS_REPO}/raw/b2d48a8a8715dd31de2af75b0aa04c0c0091fa3c/stepfunctions-local-patch""
+ )
+ SFN_PATCH_CLASS1 = ""com/amazonaws/stepfunctions/local/runtime/Config.class""
+ SFN_PATCH_CLASS2 = (",remember to update the hash once the upstream PR is merged
+4718,"@@ -45,10 +45,8 @@ public class SFDCFcmListenerService extends FirebaseMessagingService {
+     @Override
+     public void onMessageReceived(RemoteMessage message) {
+         if (message != null && SalesforceSDKManager.hasInstance()) {
+-            final PushNotificationInterface pnInterface = SalesforceSDKManager.getInstance().getPushNotificationReceiver();
+-            if (pnInterface != null) {
+-                pnInterface.onPushMessageReceived(message);
+-            }
++            final PushNotificationDecryptor pnDecryptor = PushNotificationDecryptor.getInstance();
++            pnDecryptor.onPushMessageReceived(message);
+         }
+     }
+ }","Sends the incoming message to the decryptor, which will then forward it to the interface once processing is complete."
+4719,"@@ -317,10 +317,15 @@ func (ctx *invocationContext) Send(toAddr address.Address, methodNum abi.MethodN
+ 		}
+ 	}()
+
++	// DRAGONS: remove these once specs actors project enforces Send params
+ 	// replace nil params with empty value
+ 	if params == nil {
+ 		params = &adt_spec.EmptyValue{}
+ 	}
++	// replace non pointer with pointer
++	if _, ok := params.(adt_spec.EmptyValue); ok {
++		params = &adt_spec.EmptyValue{}
++	}
+
+ 	// check if side-effects are allowed
+ 	if !ctx.allowSideEffects {","FYI This will go the other way, with nil being the correct value for ""no params"""
+4720,"@@ -162,8 +162,10 @@ namespace pwiz.Skyline.Model.Lib
+                 var thatPeptideKey = thatItem.LibraryKey as PeptideLibraryKey;
+                 if (thatPeptideKey == null)
+                 {
+-                    result.Add(thatItem.LibraryKey);
+-                    nonPeptideKeySet.Add(thatItem.LibraryKey);
++                    if (nonPeptideKeySet.Add(thatItem.LibraryKey))
++                    {
++                        result.Add(thatItem.LibraryKey); // First time we've seen it, add to list
++                    }
+                     continue;
+                 }
+                 PeptideLibraryKey[] thisKeysWithUnmodSeq;",Is this necessary? Are there duplicates in your LibKeyIndex?
+4721,"@@ -35,6 +35,7 @@ func (m *MockActionIterator) EXPECT() *MockActionIteratorMockRecorder {
+
+ // Next mocks base method
+ func (m *MockActionIterator) Next() (action.SealedEnvelope, bool) {
++	m.ctrl.T.Helper()
+ 	ret := m.ctrl.Call(m, ""Next"")
+ 	ret0, _ := ret[0].(action.SealedEnvelope)
+ 	ret1, _ := ret[1].(bool)",Why will the gomock files be regenerated? It seems to be irrelevant
+4722,"@@ -97,6 +97,7 @@ func newPlanner(
+ 		pipedConfig:              pipedConfig,
+ 		plannerRegistry:          registry.DefaultRegistry(),
+ 		appManifestsCache:        appManifestsCache,
++		cancelledCh:              make(chan *model.ReportableCommand, 1),
+ 		nowFunc:                  time.Now,
+ 		logger:                   logger,
+ 	}",I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity?
+4723,"@@ -14,7 +14,7 @@
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+ #
+-from helpers import LuigiTestCase
++from helpers import LuigiTestCase, RunOnceTask
+
+ import luigi
+ import luigi.task",It seems like you accidentally pulled some unrelated changes to util_test into this.
+4724,"@@ -15,6 +15,7 @@
+ //  along with the Nethermind. If not, see <http://www.gnu.org/licenses/>.
+
+ using Nethermind.Blockchain;
++using Nethermind.Blockchain.Bloom;
+ using Nethermind.Blockchain.Filters;
+ using Nethermind.Blockchain.Receipts;
+ using Nethermind.Blockchain.TxPools;",do not toucm NDM please - there will be lots of conflicts
+4725,"@@ -357,7 +357,7 @@ class XLSXWriter extends TextResponseWriter {
+       if (v instanceof IndexableField) {
+         IndexableField f = (IndexableField)v;
+         if (v instanceof Date) {
+-          output.append(((Date) val).toInstant().toString() + ""; "");
++          output.append(((Date) v).toInstant().toString() + ""; "");
+         } else {
+           output.append(f.stringValue() + ""; "");
+         }",This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild?
+4726,"@@ -48,6 +48,8 @@ class Testinfra(base.Base):
+           name: testinfra
+           options:
+             n: 1
++            v: True
++            setup-show: True
+
+     The testing can be disabled by setting `enabled` to False.
+ ",This looks out of scope for this particular PR.
+4727,"@@ -39,6 +39,14 @@ import (
+ // Warning when user configures leafnode TLS insecure
+ const leafnodeTLSInsecureWarning = ""TLS certificate chain and hostname of solicited leafnodes will not be verified. DO NOT USE IN PRODUCTION!""
+
++const (
++	leafDefaultFirstPingInterval = int64(time.Second)
++)
++
++var (
++	leafFirstPingInterval = leafDefaultFirstPingInterval
++)
++
+ type leaf struct {
+ 	// Used to suppress sub and unsub interest. Same as routes but our audience
+ 	// here is tied to this leaf node. This will hold all subscriptions except this",Don't need () if only one.
+4728,"@@ -26,6 +26,7 @@ public class AbstractMailer {
+   private boolean usesAuth;
+
+   private String mailHost;
++  private String mailPort;
+   private String mailUser;
+   private String mailPassword;
+   private String mailSender;",Why not have mailPort as int since your are already parsing while calling t.connect ?
+4729,"@@ -38,7 +38,7 @@ with open('README.rst') as fobj:
+
+ install_requires = [
+     'tornado>=4.0,<5',
+-    'python-daemon<3.0',
++    'python-daemon<3.0'
+ ]
+
+ if os.environ.get('READTHEDOCS', None) == 'True':","In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :)"
+4730,"@@ -739,6 +739,11 @@ class SolrDefault extends AbstractBase
+         // Get LCCN from Index
+         $raw = isset($this->fields['lccn']) ? $this->fields['lccn'] : '';
+
++        // First call number only.
++        if (is_array($raw)) {
++            $raw = reset($raw);
++        }
++
+         // Remove all blanks.
+         $raw = preg_replace('{[ \t]+}', '', $raw);
+ ","Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations)."
+4731,"@@ -44,6 +44,8 @@ type Config struct {
+ 	Manager                       Manager
+ 	Attestor                      Attestor
+ 	AllowUnauthenticatedVerifiers bool
++	AllowedForeignJWTClaims       map[string]bool
++	TrustDomain                   spiffeid.TrustDomain
+ }
+
+ type Handler struct {","i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false"
+4732,"@@ -69,6 +69,7 @@ const (
+ 	History
+ 	Matching
+ 	Worker
++	Server
+ 	NumServices
+ )
+ ","This is very unclear what Server means. We need a better name, maybe ServerExtension?"
+4733,"@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
+ 		out, err := system.RunCommand(DdevBin, args)
+ 		assert.NoError(err)
+ 		assert.Contains(string(out), ""Server started"")
+-		assert.Contains(string(out), ""GET"")
+
+ 		cleanup()
+ 	}",I wonder if we should trigger a PHP error and ensure it ends up in the log?
+4734,"@@ -232,7 +232,9 @@
+         * @returns {string} decoded string
+         */
+         countlyCommon.decodeHtml = function(html) {
+-            return (html + """").replace(/&amp;/g, '&');
++            var textArea = document.createElement('textarea');
++            textArea.innerHTML = html;
++            return textArea.value;
+         };
+
+ ",Hmmm not sure about this. Is it fine @ar2rsawseen?
+4735,"@@ -7,5 +7,5 @@ public interface Installer {
+     /**
+      * runs the installer
+      */
+-    void run();
++    void go();
+ }",Why do you prefer `go` over `run`?
+4736,"@@ -822,7 +822,7 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+                                           TestRunCompleteArgs = dummyCompleteArgs
+                                       };
+             var runComplete = CreateMessage(MessageType.ExecutionComplete, completepayload);
+-
++
+             this.mockCommunicationManager.Setup(cm => cm.ReceiveMessageAsync(It.IsAny<CancellationToken>())).Returns(Task.FromResult(message1));
+             mockLauncher.Setup(ml => ml.LaunchTestHost(It.IsAny<TestProcessStartInfo>()))
+                 .Callback<TestProcessStartInfo>((startInfo) =>","Unintentional, please remove"
+4737,"@@ -18,6 +18,10 @@ class Subscription < ActiveRecord::Base
+   after_create :add_user_to_mailing_list
+   after_create :add_user_to_github_team
+
++  def self.active
++    where(deactivated_on: nil)
++  end
++
+   def self.deliver_welcome_emails
+     recent.each do |subscription|
+       subscription.deliver_welcome_email",What was the reason behind moving this?
+4738,"@@ -1,12 +1,8 @@
+-<%= t ""user_mailer.gpx_notification.your_gpx_file"" %>
+-<strong><%= @trace_name %></strong>
+-<%= t ""user_mailer.gpx_notification.with_description"" %>
+-<em><%= @trace_description %></em>
+-<% if @trace_tags.length>0 %>
+-  <%= t ""user_mailer.gpx_notification.and_the_tags"" %>
+-  <em><% @trace_tags.each do |tag| %>
+-    <%= tag.tag.rstrip %>
+-  <% end %></em>
++<% trace_name = tag.strong(@trace_name) %>
++<% trace_description = tag.em(@trace_description) %>
++<% if @trace_tags.length > 0 %>
++  <% tags = @trace_tags.map { tag.tag.rstrip.join("" "") } %>
++  <%= t "".description_with_tags_html"", :trace_name => trace_name, :trace_description => trace_description, :tags => tags %>
+ <% else %>
+-  <%= t ""user_mailer.gpx_notification.and_no_tags"" %>
++  <%= t "".description_with_no_tags_html"", :trace_name => trace_name, :trace_description => trace_description %>
+ <% end %>",Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect>
+4739,"@@ -72,6 +72,14 @@ class Realm {
+      */
+     get isInTransaction() {}
+
++    /**
++     * Indicated is this Realm is closed.
++     * @type {boolean}
++     * @readonly
++     * @since 2.1.0
++     */
++     get isClosed() {}
++
+     /**
+      * Gets the sync session if this is a synced Realm
+      * @type {Session}",`Indicates if this Realm has been closed.`?
+4740,"@@ -55,7 +55,6 @@ class _MissingPandasLikeSeries(object):
+     compress = unsupported_function('compress')
+     convert_objects = unsupported_function('convert_objects')
+     copy = unsupported_function('copy')
+-    corr = unsupported_function('corr')
+     cov = unsupported_function('cov')
+     cummax = unsupported_function('cummax')
+     cummin = unsupported_function('cummin')",how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series?
+4741,"@@ -168,11 +168,11 @@ func (syncer *DefaultSyncer) tipSetState(ctx context.Context, tsKey types.Sorted
+ 	if !syncer.chainStore.HasTipSetAndState(ctx, tsKey.String()) {
+ 		return nil, errors.Wrap(ErrUnexpectedStoreState, ""parent tipset must be in the store"")
+ 	}
+-	tsas, err := syncer.chainStore.GetTipSetAndState(tsKey)
++	tssr, err := syncer.chainStore.GetTipSetStateRoot(tsKey)
+ 	if err != nil {
+ 		return nil, err
+ 	}
+-	st, err := state.LoadStateTree(ctx, syncer.stateStore, tsas.TipSetStateRoot, builtin.Actors)
++	st, err := state.LoadStateTree(ctx, syncer.stateStore, tssr, builtin.Actors)
+ 	if err != nil {
+ 		return nil, err
+ 	}","Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552."
+4742,"@@ -11,11 +11,15 @@ using MicroBenchmarks;
+ namespace System.Collections
+ {
+     [BenchmarkCategory(Categories.CoreCLR, Categories.Collections, Categories.GenericCollections)]
+-    [GenericTypeArguments(typeof(int))] // value type
+-    [GenericTypeArguments(typeof(string))] // reference type
++    [GenericTypeArguments(typeof(int))] // value type, Array sort in native code
++    [GenericTypeArguments(typeof(IntStruct))] // custom value type, sort in managed code
++    [GenericTypeArguments(typeof(IntClass))] // custom reference type, sort in managed code, compare fast
++    [GenericTypeArguments(typeof(BigStruct))] // custom value type, sort in managed code
++    [GenericTypeArguments(typeof(string))] // reference type, compare slow
+     [InvocationCount(InvocationsPerIteration)]
+-    public class Sort<T>
++    public class Sort<T> where T : IComparable<T>
+     {
++        static readonly ComparableComparerClass _comparableComparerClass = new ComparableComparerClass();
+         private const int InvocationsPerIteration = 1000;
+
+         [Params(Utils.DefaultCollectionSize)]","@billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types."
+4743,"@@ -31,7 +31,6 @@ from qutebrowser.config import config
+
+
+ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
+-
+     """"""The commandline part of the statusbar.
+
+     Attributes:",Unrelated whitespace change.
+4744,"@@ -133,8 +133,18 @@ bool rai::wallet_store::valid_password (MDB_txn * transaction_a)
+ 	return ok;
+ }
+
+-bool rai::wallet_store::attempt_password (MDB_txn * transaction_a, std::string const & password_a)
++bool rai::wallet_store::attempt_password (rai::transaction * transaction_p, std::string const & password_a)
+ {
++	std::unique_ptr<rai::transaction> writeTransaction;
++
++	if (!transaction_p->open_for_write)
++	{
++		writeTransaction = std::make_unique<rai::transaction> (environment, nullptr, true);
++		transaction_p = writeTransaction.get ();
++	}
++
++	MDB_txn *transaction_a = *transaction_p;
++
+ 	bool result = false;
+ 	{
+ 		std::lock_guard<std::recursive_mutex> lock (mutex);",Slight formatting issue here. There should be a space after the asterisk.
+4745,"@@ -8,7 +8,8 @@
+  */
+ axe.utils.isHidden = function isHidden(el, recursed) {
+ 	'use strict';
+-	var parent;
++	const node = axe.utils.getNodeFromTree(el);
++	let parent, isHidden;
+
+ 	// 9 === Node.DOCUMENT
+ 	if (el.nodeType === 9) {",Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these.
+4746,"@@ -32,9 +32,9 @@ import org.slf4j.LoggerFactory;
+  * @since  [产品/模块版本]
+  */
+ public class TestMgr {
+-    private static Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
++    private static final Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
+
+-    private static List<Throwable> errorList = new ArrayList<>();
++    private static final List<Throwable> errorList = new ArrayList<>();
+
+     private static String msg = """";
+ ",this is a duplicate file of the one in demo-schema. please remove this file.
+4747,"@@ -153,6 +153,7 @@ var (
+ 		utils.Eth1SyncServiceEnable,
+ 		utils.Eth1CanonicalTransactionChainDeployHeightFlag,
+ 		utils.Eth1L1CrossDomainMessengerAddressFlag,
++		utils.Eth1L1FeeWalletAddressFlag,
+ 		utils.Eth1ETHGatewayAddressFlag,
+ 		utils.Eth1ChainIdFlag,
+ 		utils.RollupClientHttpFlag,",Nit: unified names between geth and contracts
+4748,"@@ -42,7 +42,9 @@ func TestClientToServerCommunication(t *testing.T) {
+ 	// Note that the ordering of things here is pretty important; we need to get the
+ 	// client connected & ready to receive events before we push them all into the
+ 	// server and shut it down again.
+-	serverState := core.NewBuildState(5, nil, 4, core.DefaultConfiguration())
++	config := core.DefaultConfiguration()
++	config.Please.NumThreads = 5
++	serverState := core.NewBuildState(config)
+ 	addr, shutdown := initialiseServer(serverState, 0)
+
+ 	// This is a bit awkward. We want to assert that we receive a matching set of",Necessary? Could you just use DefaultBuildState here?
+4749,"@@ -22,7 +22,7 @@ import java.util.ArrayList;
+ import java.util.Arrays;
+ import java.util.Collections;
+ import java.util.Date;
+-import java.util.HashMap;
++import java.util.LinkedHashMap;
+ import java.util.HashSet;
+ import java.util.List;
+ import java.util.Map;",linked hashmap retains order
+4750,"@@ -20,12 +20,12 @@
+ #include <wlr/render/matrix.h>
+ #include <wlr/render/gles2.h>
+ #include <wlr/render.h>
+-#include ""backend/drm.h""
+-#include ""backend/drm-util.h""
++#include ""backend/drm/drm.h""
++#include ""backend/drm/util.h""
+
+ bool wlr_drm_check_features(struct wlr_drm_backend *backend) {
+-	extern const struct wlr_drm_interface legacy_iface;
+-	extern const struct wlr_drm_interface atomic_iface;
++	extern const struct wlr_drm_interface iface_legacy;
++	extern const struct wlr_drm_interface iface_atomic;
+
+ 	if (drmSetClientCap(backend->fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1)) {
+ 		wlr_log(L_ERROR, ""DRM universal planes unsupported"");",And the old names for these variables made more sense imo.
+4751,"@@ -473,7 +473,7 @@ func GetAdditionalGroups(additionalGroups []string, group io.Reader) ([]int, err
+ 				return nil, fmt.Errorf(""Unable to find group %s"", ag)
+ 			}
+ 			// Ensure gid is inside gid range.
+-			if gid < minId || gid > maxId {
++			if gid < minId || gid >= maxId {
+ 				return nil, ErrRange
+ 			}
+ 			gidMap[gid] = struct{}{}",Are you sure this change is correct?
+4752,"@@ -9,8 +9,7 @@ def test_view_image():
+         ""mitmproxy/data/image.png"",
+         ""mitmproxy/data/image.gif"",
+         ""mitmproxy/data/all.jpeg"",
+-        # https://bugs.python.org/issue21574
+-        # ""mitmproxy/data/image.ico"",
++        ""mitmproxy/data/image.ico"",
+     ]:
+         with open(tutils.test_data.path(img), ""rb"") as f:
+             viewname, lines = v(f.read())","The previously linked bug does not apply anymore? If so, this is LGTM!"
+4753,"@@ -84,7 +84,7 @@ func assertNotEqual(t *testing.T, a interface{}, b interface{}) {
+ 	}
+ }
+
+-func TestFailOver(t *testing.T) {
++func Test_FailOver(t *testing.T) {
+ 	tmpDir, err := ioutil.TempDir("""", ""lb-test"")
+ 	if err != nil {
+ 		assertEqual(t, err, nil)",Why are we renaming all of the tests?
+4754,"@@ -24,8 +24,9 @@ import (
+
+ var defaultRFC2136Port = ""53""
+
+-// This function make a valid nameserver as per RFC2136
++// This function returns a valid nameserver (in the form <host>:<port>) for the RFC2136 provider
+ func ValidNameserver(nameserver string) (string, error) {
++	nameserver = strings.TrimSpace(nameserver)
+
+ 	if nameserver == """" {
+ 		return """", fmt.Errorf(""RFC2136 nameserver missing"")","Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here?"
+4755,"@@ -142,9 +142,15 @@ PyObject *GetMolConformers(ROMol &mol) {
+ template <class T>
+ T MolGetProp(const ROMol &mol, const char *key) {
+   T res;
+-  if (!mol.getPropIfPresent(key, res)) {
+-    PyErr_SetString(PyExc_KeyError, key);
+-    throw python::error_already_set();
++  try {
++    if (!mol.getPropIfPresent(key, res)) {
++      PyErr_SetString(PyExc_KeyError, key);
++      throw python::error_already_set();
++    }
++    return res;
++  } catch ( const boost::bad_any_cast &e ) {
++    throw ValueErrorException(std::string(""key `"") + key + ""` exists but does not result in a "" +
++                              GetTypeName<T>());
+   }
+   return res;
+ }","Why not also replace this one with calls to `GetProp<ROMol,T>`?"
+4756,"@@ -259,6 +259,7 @@ class KNNClassifier(object):
+     if doWinners:
+       if (self.numWinners>0) and (self.numWinners < (inputPattern > 0).sum()):
+         sparseInput = numpy.zeros(inputPattern.shape)
++
+         # Don't consider strongly negative numbers as winners.
+         sorted = inputPattern.argsort()[0:self.numWinners]
+         sparseInput[sorted] += inputPattern[sorted]",Still need to remove trailing spaces on this line
+4757,"@@ -0,0 +1,19 @@
++/*
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.apex.ast;
++
++import apex.jorje.semantic.ast.AstNode;
++
++/**
++ * Interface for nodes that can contain comments. Because comments are for the most part lost, the tree builder only
++ * captures whether the node did contain comments of any sort in the source code and not the actual contents of those
++ * comments. This is useful for rules which need to know whether a node did contain comments.
++ */
++public interface ASTCommentContainer<T extends AstNode> extends ApexNode<T> {
++
++    void setContainsComment(boolean containsComment);
++
++    boolean getContainsComment();
++}",Please use the `@Experimental` annotation on this
+4758,"@@ -77,7 +77,7 @@ func (s *LimitedReaderSlurper) Read(reader io.Reader) error {
+ 					// if we received err == nil and n == 0, we should retry calling the Read function.
+ 					continue
+ 				default:
+-					// if we recieved a non-io.EOF error, return it.
++					// if we received a non-io.EOF error, return it.
+ 					return err
+ 				}
+ 			}",I found ~10 more instances of this typo. we can fix those in subsequent PRs.
+4759,"@@ -49,7 +49,7 @@ type InitRes struct {
+ // it returns a result object that contains useful artifacts for later use.
+ // Unlike sharedmain.Main, Init is meant to be run as a helper function in any main
+ // functions, while sharedmain.Main runs controllers with predefined method signatures.
+-func Init(component string, opts ...InitOption) (context.Context, *InitRes) {
++func Init(component string, metricNamespace string, opts ...InitOption) (context.Context, *InitRes) {
+ 	args := newInitArgs(component, opts...)
+ 	ctx := args.ctx
+ 	ProcessEnvConfigOrDie(args.env)","How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace(""trigger""))"
+4760,"@@ -163,6 +163,8 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(""handlePage""))));
+     builder.pageVarName(
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name(), ""page""))));
++    builder.pageTokenName(methodInfo.requestPageTokenName());
++    builder.nextPageTokenName(methodInfo.responsePageTokenName());
+     return builder.build();
+   }
+ }",Just checking: no need for case manipulation?
+4761,"@@ -94,7 +94,7 @@ public class GrpcMetadataGeneratorTool {
+
+   private static void generate(
+       String descriptorSet,
+-      String[] apiConfigs,
++      String[] configs,
+       String inputDir,
+       String outputDir,
+       String languageString,","Same as above, not that descriptive"
+4762,"@@ -5494,10 +5494,12 @@ emit_special_ibl_xfer(dcontext_t *dcontext, byte *pc, generated_code_t *code, ui
+     reg_id_t stub_reg = IF_AARCH64_ELSE(SCRATCH_REG0, SCRATCH_REG1);
+     ushort stub_slot = IF_AARCH64_ELSE(TLS_REG0_SLOT, TLS_REG1_SLOT);
+     IF_X86(size_t len;)
+-    byte *ibl_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_LINKED, ibl_type);
++    byte *ibl_linked_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_LINKED, ibl_type);
++    byte *ibl_unlinked_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_UNLINKED, ibl_type);
+     bool absolute = !code->thread_shared;
+
+-    ASSERT(ibl_tgt != NULL);
++    ASSERT(ibl_linked_tgt != NULL);
++    ASSERT(ibl_unlinked_tgt != NULL);
+     instrlist_init(&ilist);
+     init_patch_list(&patch, absolute ? PATCH_TYPE_ABSOLUTE : PATCH_TYPE_INDIRECT_FS);
+ ",> i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error.
+4763,"@@ -668,6 +668,8 @@ int flb_start(flb_ctx_t *ctx)
+         fd = event->fd;
+         bytes = flb_pipe_r(fd, &val, sizeof(uint64_t));
+         if (bytes <= 0) {
++            pthread_cancel(tid);
++            pthread_join(tid, NULL);
+             ctx->status = FLB_LIB_ERROR;
+             return -1;
+         }",Should we need to invoke pthread_cancel ?
+4764,"@@ -122,7 +122,8 @@ public class ZMSResources {
+     public Domain postUserDomain(@PathParam(""name"") String name, @HeaderParam(""Y-Audit-Ref"") String auditRef, UserDomain detail) {
+         try {
+             ResourceContext context = this.delegate.newResourceContext(this.request, this.response);
+-            context.authorize(""create"", ""user."" + name + "":domain"", null);
++            String userDomainPrefix = System.getProperty(ZMSConsts.ZMS_PROP_USER_DOMAIN, ZMSConsts.USER_DOMAIN) + ""."";
++            context.authorize(""create"", userDomainPrefix + name + "":domain"", null);
+             Domain e = this.delegate.postUserDomain(context, name, auditRef, detail);
+             return e;
+         } catch (ResourceException e) {",this is auto generated file so no changes are allowed here
+4765,"@@ -0,0 +1,13 @@
++if (
++	node.querySelector(
++		'input[type=""submit""]:not([disabled]), img[type=""submit""]:not([disabled]), button[type=""submit""]:not([disabled])'
++	)
++) {
++	return true;
++}
++
++if (!node.querySelectorAll(':not(textarea)').length) {
++	return false;
++}
++
++return undefined;","All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`."
+4766,"@@ -38,7 +38,7 @@ module Travis
+
+         def perl_version
+           # this check is needed because safe_yaml parses the string 5.10 to 5.1
+-          config[:perl] == 5.1 ? ""5.10"" : config[:perl]
++          config[:perl] == 5.1 ? ""5.10"" : config[:perl] == 5.2 ? ""5.20"" : config[:perl]
+         end
+       end
+     end","can you please make this multi line, this version is hard to read."
+4767,"@@ -128,7 +128,7 @@ Blockly.HorizontalFlyout.prototype.setMetrics_ = function(xyRatio) {
+     return;
+   }
+
+-  if (goog.isNumber(xyRatio.x)) {
++  if (typeof xyRatio.x === 'number') {
+     this.workspace_.scrollX = -metrics.contentWidth * xyRatio.x;
+   }
+ ","For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them."
+4768,"@@ -11,6 +11,10 @@ FactoryGirl.define do
+     project_title ""NCR Name""
+     association :proposal, flow: 'linear'
+
++    trait :with_approver do
++      association :proposal, :with_approver, flow: 'linear'
++    end
++
+     trait :with_approvers do
+       association :proposal, :with_approvers, flow: 'linear'
+     end","Work Orders would never have only one approver, right?"
+4769,"@@ -0,0 +1,17 @@
++package com.codahale.metrics.collectd;
++
++enum DataType {
++
++    COUNTER(0), GAUGE(1);
++
++    private final int code;
++
++    private DataType(int code) {
++        this.code = code;
++    }
++
++    public int getCode() {
++        return code;
++    }
++
++}","`code` is written to the message as a `byte`, so I think it's better to declare it in the enum as `byte` as well to avoid a narrowing primitive conversion from `int` to `byte` in runtime."
+4770,"@@ -163,9 +163,11 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
+ 		{
+ 			title: __( 'Earnings', 'google-site-kit' ),
+ 			tooltip: __( 'Earnings', 'google-site-kit' ),
+-			Component: ( { row } ) => numFmt(
+-				row.metrics[ 0 ].values[ 0 ],
+-				currencyFormat,
++			field: 'metrics.0.values.0',
++			Component: ( { fieldValue } ) => (
++				<span>
++					{ numFmt( fieldValue, currencyFormat ) }
++				</span>
+ 			),
+ 		},
+ 	];","This is the only ""extra"" change here."
+4771,"@@ -36,14 +36,15 @@ type SignedMessageValidator interface {
+ }
+
+ type defaultMessageValidator struct {
+-	allowHighNonce bool
++	allowHighNonce          bool
++	bypassBLSSignatureCheck bool
+ }
+
+ // NewDefaultMessageValidator creates a new default validator.
+ // A default validator checks for both permanent semantic problems (e.g. invalid signature)
+ // as well as temporary conditions which may change (e.g. actor can't cover gas limit).
+ func NewDefaultMessageValidator() SignedMessageValidator {
+-	return &defaultMessageValidator{}
++	return &defaultMessageValidator{bypassBLSSignatureCheck: true}
+ }
+
+ // NewOutboundMessageValidator creates a new default validator for outbound messages. This",Please TODO and link to an issue for changing this.
+4772,"@@ -1,9 +1,10 @@
++/* eslint-disable comma-dangle */
+ const en_US = {}
+
+ en_US.strings = {
+   addBulkFilesFailed: {
+     '0': 'Failed to add %{smart_count} file due to an internal error',
+-    '1': 'Failed to add %{smart_count} files due to internal errors',
++    '1': 'Failed to add %{smart_count} files due to internal errors'
+   },
+   addingMoreFiles: 'Adding more files',
+   addMore: 'Add more',",Can we make the script output trailing commas?
+4773,"@@ -0,0 +1,10 @@
++exports.featureFlags = {
++	widgets: {
++		dashboard: {
++			enabled: 'development',
++		},
++		pageDashboard: {
++			enabled: 'development',
++		},
++	},
++};",This file should get a file header
+4774,"@@ -7,7 +7,6 @@
+ #include ""base/Base.h""
+ #include ""kvstore/wal/FileBasedWal.h""
+ #include ""kvstore/wal/FileBasedWalIterator.h""
+-#include ""kvstore/wal/BufferFlusher.h""
+ #include ""fs/FileUtils.h""
+ #include ""time/WallClock.h""
+ ","maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger."
+4775,"@@ -135,6 +135,9 @@ func registerWriteCommand(cmd *cobra.Command) {
+
+ // gasPriceInRau returns the suggest gas price
+ func gasPriceInRau() (*big.Int, error) {
++	if account.CryptoSm2 {
++		return big.NewInt(0), nil
++	}
+ 	gasPrice := gasPriceFlag.Value().(string)
+ 	if len(gasPrice) != 0 {
+ 		return util.StringToRau(gasPrice, util.GasPriceDecimalNum)",we need to pay attention not to use this flag everywhere.
+4776,"@@ -22,7 +22,6 @@ import (
+ )
+
+ type Protocol string
+-type TableIDType uint8
+ type GroupIDType uint32
+ type MeterIDType uint32
+ ","curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place"
+4777,"@@ -74,7 +74,7 @@ func (db *DB) SubscribePush(ctx context.Context) (c <-chan swarm.Chunk, stop fun
+ 					}
+
+ 					select {
+-					case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag).WithStamp(dataItem.Stamp):
++					case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag):
+ 						count++
+ 						// set next iteration start item
+ 						// when its chunk is successfully sent to channel","wait, are we not mising `WithStamp` here?"
+4778,"@@ -66,7 +66,7 @@ func (api *APIImpl) Syncing(ctx context.Context) (interface{}, error) {
+ 		return false, err
+ 	}
+
+-	currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.TxPool)
++	currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.Finish)
+ 	if err != nil {
+ 		return false, err
+ 	}",oh. didn't know we store this stage progress.
+4779,"@@ -91,6 +91,7 @@ function getUnicodeNonBmpRegExp() {
+ 		'\u25A0-\u25FF' + // Geometric Shapes
+ 		'\u2600-\u26FF' + // Misc Symbols
+ 		'\u2700-\u27BF' + // Dingbats
++		'\uE000-\uF8FF' + // Private Use
+ 			']'
+ 	);
+ }","Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also two large ranges of supplementary private-use characters, consisting of most of the code points on Planes 15 and 16: U+F0000..U+FFFFD and U+100000..U+10FFFD. Together those ranges allocate another 131,068 private-use characters. Altogether, then, there are 137,468 private-use characters in Unicode. It looks like we are only ignoring ones in BMP and not the supplementary private-use characters. Shouldn't we consider the supplementary ones too?"
+4780,"@@ -300,7 +300,7 @@ class FunctionCallReturnTypeFetcher
+                                     return new Type\Union([
+                                         $atomic_types['array']->count !== null
+                                             ? new Type\Atomic\TLiteralInt($atomic_types['array']->count)
+-                                            : new Type\Atomic\TInt
++                                            : new Type\Atomic\TPositiveInt
+                                     ]);
+                                 }
+ ",This change is un-tested and requires testing
+4781,"@@ -83,6 +83,11 @@ class notebook_extension(extension):
+
+     logo = param.Boolean(default=True, doc=""Toggles display of HoloViews logo"")
+
++    comms = param.ObjectSelector(
++        default='default', objects=['default', 'ipywidgets', 'vscode'], doc=""""""
++        Whether to render output in Jupyter with the default Jupyter
++        extension or use the jupyter_bokeh ipywidget model."""""")
++
+     inline = param.Boolean(default=True, doc=""""""
+         Whether to inline JS and CSS resources.
+         If disabled, resources are loaded from CDN if one is available."""""")",Should the docstring mention the vscode option?
+4782,"@@ -83,6 +83,8 @@ public class PackageMetadataTransformer {
+         .packageVersionBound(packageConfig.generatedPackageVersionBound(language))
+         .protoPath(packageConfig.protoPath())
+         .shortName(packageConfig.shortName())
++        .gapicConfigName(packageConfig.shortName() + ""_gapic.yaml"")
++        .packageType(packageConfig.packageType())
+         .gaxVersionBound(packageConfig.gaxVersionBound(language))
+         .grpcVersionBound(packageConfig.grpcVersionBound(language))
+         .protoVersionBound(packageConfig.protoVersionBound(language))","ISTM that since `artman` know the ""real"" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen..."
+4783,"@@ -17,7 +17,7 @@ package main
+ import (
+ 	""time""
+
+-	""github.com/docopt/docopt-go""
++	docopt ""github.com/docopt/docopt-go""
+ 	log ""github.com/sirupsen/logrus""
+
+ 	""github.com/projectcalico/felix/iptables""",Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated
+4784,"@@ -17,6 +17,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+         Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken));
+         void Flush();
+         Task FlushAsync(CancellationToken cancellationToken = default(CancellationToken));
+-        void Write<T>(Action<WritableBuffer, T> write, T state);
++        void Write<T>(Action<WritableBuffer, T> write, T state) where T : struct;
+     }
+ }",Should this be `ISocketOutput<T> where T : struct`?
+4785,"@@ -104,4 +104,11 @@ public interface Snapshot {
+    * @return the location of the manifest list for this Snapshot
+    */
+   String manifestListLocation();
++
++  /**
++   * Return this snapshot's sequence number, or 0 if the table has no snapshot yet.
++   *
++   * @return the sequence number of this Snapshot
++   */
++  Long sequenceNumber();
+ }","In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right?"
+4786,"@@ -133,6 +133,11 @@ class NumClassCheckHook(Hook):
+             for name, module in model.named_modules():
+                 if hasattr(module, 'num_classes') and not isinstance(
+                         module, (RPNHead, VGG, FusedSemanticHead, GARPNHead)):
++                    assert type(dataset.CLASSES) is not str, \
++                        (f'`CLASSES` in {dataset.__class__.__name__}'
++                         f'should be a tuple of str.'
++                         f'Add comma if number of classes is 1 as '
++                         f'CLASSES = ({dataset.CLASSES},)')
+                     assert module.num_classes == len(dataset.CLASSES), \
+                         (f'The `num_classes` ({module.num_classes}) in '
+                          f'{module.__class__.__name__} of '","This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module."
+4787,"@@ -36,7 +36,7 @@ if __name__ == ""__main__"":
+             ""boto3"",
+             f""dagster{pin}"",
+             ""packaging"",
+-            ""psycopg2-binary<2.9"",
++            ""psycopg2-binary"",
+             ""requests"",
+         ],
+         extras_require={",Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine?
+4788,"@@ -12,8 +12,9 @@ import (
+ )
+
+ var (
+-	_                  = collection.Entry(&Entry{})
+-	serializedDataSize = swarm.SectionSize * 2
++	_                           = collection.Entry(&Entry{})
++	serializedDataSize          = swarm.SectionSize * 2
++	encryptedSerializedDataSize = swarm.EncryptedHashSize * 2
+ )
+
+ // Entry provides addition of metadata to a data reference.",could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`?
+4789,"@@ -39,9 +39,14 @@ func (r *Reader) Close() error {
+ 	return r.r.Close()
+ }
+
++// ContentType returns the MIME type of the object content.
++func (r *Reader) ContentType() string {
++	return r.r.Attrs().ContentType
++}
++
+ // Size returns the content size of the blob object.
+ func (r *Reader) Size() int64 {
+-	return r.r.Size()
++	return r.r.Attrs().Size
+ }
+
+ // Writer implements io.WriteCloser to write to blob. It must be closed after",s/object content/blob object/ (for consistency with the `Size` docs)
+4790,"@@ -109,16 +109,7 @@ public class CheckJUnitDependencies extends DefaultTask {
+                                 + ""'org.junit.jupiter:junit-jupiter' dependency ""
+                                 + ""because tests use JUnit4 and useJUnitPlatform() is not enabled."");
+             }
+-        } else {
+-            String compileClasspath = ss.getCompileClasspathConfigurationName();
+-            boolean compilingAgainstOldJunit = hasDep(compileClasspath, CheckJUnitDependencies::isJunit4);
+-            Preconditions.checkState(
+-                    !compilingAgainstOldJunit,
+-                    ""Extraneous dependency on JUnit4 (no test mentions JUnit4 classes). Please exclude ""
+-                            + ""this from compilation to ensure developers don't accidentally re-introduce it, e.g.\n\n""
+-                            + ""    configurations."" + compileClasspath + "".exclude module: 'junit'\n\n"");
+         }
+-
+         // sourcesets might also contain Spock classes, but we don't have any special validation for these.
+     }
+ ","Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line?"
+4791,"@@ -215,7 +215,7 @@ func (cfg *Config) newACMEClient(interactive bool) (*acmeClient, error) {
+ // lockKey returns a key for a lock that is specific to the operation
+ // named op being performed related to domainName and this config's CA.
+ func (cfg *Config) lockKey(op, domainName string) string {
+-	return fmt.Sprintf(""%s:%s:%s"", op, domainName, cfg.CA)
++	return fmt.Sprintf(""%s_%s_%s"", op, domainName, cfg.CA)
+ }
+
+ // Obtain obtains a single certificate for name. It stores the certificate",Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one?
+4792,"@@ -758,6 +758,7 @@ class CaiDataAccess(object):
+         except SQLAlchemyError as e:
+             LOGGER.exception('Attempt to delete data from CAI temporary store '
+                              'failed, disabling the use of CAI: %s', e)
++            session.rollback()
+
+         return num_rows
+ ",Thanks for this... is this the only place where the rollback is needed? Are there others?
+4793,"@@ -56,7 +56,7 @@ func TestTriangleEncoding(t *testing.T) {
+ 	}
+ 	t.Run(""encoding block with zero fields works"", func(t *testing.T) {
+ 		testRoundTrip(t, &blk.Block{
+-			BlockSig:        crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
++			BlockSig:        &crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
+ 			BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}},
+ 		})
+ 	})","Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here."
+4794,"@@ -427,9 +427,9 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
+
+ 	case driver.Replace:
+ 		// If the given document has a revision, use it as the precondition (it implies existence).
+-		pc, err := revisionPrecondition(a.Doc)
+-		if err != nil {
+-			return nil, """", err
++		pc, perr := revisionPrecondition(a.Doc)
++		if perr != nil {
++			return nil, """", perr
+ 		}
+ 		// Otherwise, just require that the document exists.
+ 		if pc == nil {",This was definitely a subtle bug right here.
+4795,"@@ -35,6 +35,12 @@ class GithubApi
+     @access_token = data['access_token'].first
+   end
+
++  def secondary_emails
++    return @secondary_emails if @secondary_emails
++    @secondary_emails = fetch_email_responses.select { |hsh| !hsh['primary'] && hsh['verified'] }
++                                             .map { |response| response['email'] }.compact
++  end
++
+   private
+
+   def request","If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**."
+4796,"@@ -48,7 +48,7 @@ func TestBroadcast(t *testing.T) {
+ 		}
+ 	}
+ 	u := func(_ context.Context, _ uint32, _ peerstore.PeerInfo, _ proto.Message) {}
+-	bootnodePort := testutil.RandomPort()
++	bootnodePort := 14689
+ 	cfg := config.Config{
+ 		Network: config.Network{Host: ""127.0.0.1"", Port: bootnodePort},
+ 	}","Can we still random, but if we randomly get a port is used before, we randomly pick again?"
+4797,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low."
+4798,"@@ -11,5 +11,17 @@ module Gsa18f
+       super && self.gsa_if_restricted!
+     end
+     alias_method :can_new!, :can_create!
++
++    def can_cancel!
++      not_cancelled! && check((approver? || delegate? || requester?) && !purchaser?,
++        ""Sorry, you are neither the requester, approver or delegate"")
++    end
++    alias_method :can_cancel_form!, :can_cancel!
++
++    protected
++
++    def purchaser?
++      @procurement.purchaser == @user
++    end
+   end
+ end",what if a purchaser is also an approver? or would that not happen?
+4799,"@@ -125,9 +125,12 @@ def sweep(privkeys, network, config, recipient, fee=None, imax=100):
+         raise BaseException(_('No inputs found. (Note that inputs need to be confirmed)'))
+     total = sum(i.get('value') for i in inputs)
+     if fee is None:
++        if not network.config.has_fee_estimates():
++            raise BaseException('Dynamic fee estimates not available')
+         outputs = [(TYPE_ADDRESS, recipient, total)]
+         tx = Transaction.from_io(inputs, outputs)
+         fee = config.estimate_fee(tx.estimated_size())
++
+     if total - fee < 0:
+         raise BaseException(_('Not enough funds on address.') + '\nTotal: %d satoshis\nFee: %d'%(total, fee))
+     if total - fee < dust_threshold(network):","Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that."
+4800,"@@ -26,6 +26,11 @@ func (s *AuditLogsSourceStatus) GetCondition(t apis.ConditionType) *apis.Conditi
+ 	return auditLogsSourceCondSet.Manage(s).GetCondition(t)
+ }
+
++// GetTopLevelCondition returns the top level condition.
++func (s *AuditLogsSourceStatus) GetTopLevelCondition() *apis.Condition {
++	return auditLogsSourceCondSet.Manage(s).GetTopLevelCondition()
++}
++
+ // IsReady returns true if the resource is ready overall.
+ func (s *AuditLogsSourceStatus) IsReady() bool {
+ 	return auditLogsSourceCondSet.Manage(s).IsHappy()","sorry, I wasn't familiar with this TopLevelCondition... What it would be in this case? The AuditsLogReady condition?"
+4801,"@@ -109,6 +109,7 @@ type DiffTransformation struct {
+
+ 	d     execute.Dataset
+ 	cache execute.TableBuilderCache
++	alloc *memory.Allocator
+
+ 	inputCache *execute.GroupLookup
+ }",Where does the `alloc` field get set?
+4802,"@@ -273,9 +273,10 @@ func setupPostgres(w *DWH) error {
+ 	return nil
+ }
+
+-func runQueryPostgres(db *sql.DB, opts *queryOpts) (*sql.Rows, string, error) {
++func runQueryPostgres(db *sql.DB, opts *queryOpts) (*sql.Rows, int64, error) {
+ 	var (
+ 		query      = fmt.Sprintf(""SELECT * FROM %s %s"", opts.table, opts.selectAs)
++		countQuery = fmt.Sprintf(""SELECT count(*) FROM %s %s"", opts.table, opts.selectAs)
+ 		conditions []string
+ 		values     []interface{}
+ 		numFilters = 1",looks expensive to do it on each query
+4803,"@@ -38,16 +38,16 @@ import model_params
+ _LOGGER = logging.getLogger(__name__)
+
+ _INPUT_DATA_FILE = resource_filename(
+-  ""nupic.datafiles"", ""extra/nyctaxi/nyc_taxi.csv""
++  ""nupic.datafiles"", ""extra/nyctaxi/nycTaxi.csv""
+ )
+ _OUTPUT_PATH = ""anomaly_scores.csv""
+
+ _ANOMALY_THRESHOLD = 0.9
+
+-# minimum metric value of nyc_taxi.csv
++# minimum metric value of nycTaxi.csv
+ _INPUT_MIN = 8
+
+-# maximum metric value of nyc_taxi.csv
++# maximum metric value of nycTaxi.csv
+ _INPUT_MAX = 39197
+
+ ",@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?
+4804,"@@ -209,9 +209,9 @@ module Mongoid
+           # @since 2.1.0
+           def empty?
+             if _loaded?
+-              in_memory.count == 0
++              in_memory.length == 0
+             else
+-              _unloaded.count + _added.count == 0
++              _added.length == 0 && !_unloaded.exists?
+             end
+           end
+ ",Can this simply call `in_memory.empty?` ?
+4805,"@@ -88,6 +88,13 @@ func init() {
+ // CreateSettingsFile creates the settings file (like settings.php) for the
+ // provided app is the apptype has a settingsCreator function.
+ func (app *DdevApp) CreateSettingsFile() (string, error) {
++	// If the user has asked us to skip settings file manipulation, then just bail
++	// out early.
++	if app.OmitSettingsPhp {
++		util.Warning(""Skipping creation of settings file."")
++		return """", nil
++	}
++
+ 	app.SetApptypeSettingsPaths()
+
+ 	// If neither settings file options are set, then don't continue. Return",The styling/wording here probably needs some thought. It's more of a placeholder.
+4806,"@@ -9,10 +9,10 @@ Rails.application.routes.draw do
+
+   resources :stack_entries
+
+-  resources :password_reset, only: [:new, :create] do
++  resources :password_resets, only: [:new, :create] do
+     collection do
+       get :confirm
+-      post :reset
++      patch :reset
+     end
+   end
+   resources :activation_resends, only: [:new, :create]",Using a plural route helps in detecting the path automatically for `= form_for @password_reset`.
+4807,"@@ -9,8 +9,8 @@ const fs = require('fs');
+ const { MongoClient } = require('../../../src');
+ const { TestConfiguration } = require('./config');
+ const { getEnvironmentalOptions } = require('../utils');
+-const { eachAsync } = require('../../../src/utils');
+ const mock = require('../mongodb-mock/index');
++const { inspect } = require('util');
+
+ const MONGODB_URI = process.env.MONGODB_URI || 'mongodb://localhost:27017';
+ const MONGODB_API_VERSION = process.env.MONGODB_API_VERSION;",Is `metadata` required on all tests? I actually just removed the metadata field entirely from a few tests in my PR.
+4808,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?
+4809,"@@ -145,6 +145,10 @@ public class TemporaryFilesystem {
+   }
+
+   public boolean deleteBaseDir() {
+-    return baseDir.delete();
++    boolean wasDeleted = baseDir.delete();
++    if (wasDeleted) {
++      Runtime.getRuntime().removeShutdownHook(shutdownHook);
++    }
++    return wasDeleted;
+   }
+ }","I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways."
+4810,"@@ -232,7 +232,17 @@ func (c *CVCController) updateCVCObj(
+ // 4. Create cstorvolumeclaim resource.
+ // 5. Update the cstorvolumeclaim with claimRef info and bound with cstorvolume.
+ func (c *CVCController) createVolumeOperation(cvc *apis.CStorVolumeClaim) (*apis.CStorVolumeClaim, error) {
+-	_ = cvc.Annotations[string(apis.ConfigClassKey)]
++
++	policyName := cvc.Annotations[string(apis.VolumePolicyKey)]
++	volumePolicy := &apis.CStorVolumePolicy{}
++	var err error
++	if policyName != """" {
++		klog.Infof(""uses cstorvolume policy for volume configuration"")
++		volumePolicy, err = c.clientset.OpenebsV1alpha1().CStorVolumePolicies(getNamespace()).Get(policyName, metav1.GetOptions{})
++		if err != nil {
++			return nil, err
++		}
++	}
+
+ 	klog.V(2).Infof(""creating cstorvolume service resource"")
+ 	svcObj, err := getOrCreateTargetService(cvc)",Better to push getting policy details into a func we can reuse later.
+4811,"@@ -52,6 +52,14 @@ type outbound struct {
+ 	URL    string
+ }
+
++func (o outbound) Start() error {
++	return nil // nothing to do
++}
++
++func (o outbound) Stop() error {
++	return nil // nothing to do
++}
++
+ func (o outbound) Call(ctx context.Context, req *transport.Request) (*transport.Response, error) {
+ 	start := time.Now()
+ 	deadline, _ := ctx.Deadline()","optional: while there's nothing to do, a good way to catch bugs (where we use an outbound without calling `Start`) might be to have this outbound verify that `Start` is called before `Call` or `Stop`"
+4812,"@@ -20,6 +20,9 @@ import (
+ 	""flag""
+ 	""os""
+
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/apis""
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/aws/actuators/cluster""
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/aws/actuators/machine""
+ 	clusterapis ""sigs.k8s.io/cluster-api/pkg/apis""
+ 	""sigs.k8s.io/cluster-api/pkg/apis/cluster/common""
+ 	""sigs.k8s.io/cluster-api/pkg/client/clientset_generated/clientset""","Not a blocker by any means, but I think there is value in keeping the local imports in a separate group."
+4813,"@@ -295,3 +295,14 @@ func TestStartStopFailures(t *testing.T) {
+ 		}
+ 	}
+ }
++
++func TestNoOutboundsForService(t *testing.T) {
++	assert.Panics(t, func() {
++		NewDispatcher(Config{
++			Name: ""test"",
++			Outbounds: Outbounds{
++				""my-test-service"": {},
++			},
++		})
++	})
++}","nit - I would test the error message as well. For panic, you might need to see if the stack contains the error message, instead of equaling."
+4814,"@@ -162,6 +162,18 @@ func substitute(s reflect.Value, replacer *strings.Replacer) {
+ 		case *compute.Client, *storage.Client, context.Context, context.CancelFunc:
+ 			// We specifically do not want to change fields with these types.
+ 			continue
++		case *WaitForInstancesStopped:
++			var newSlice WaitForInstancesStopped
++			for _, v := range *raw.(*WaitForInstancesStopped) {
++				newSlice = append(newSlice, replacer.Replace(v))
++			}
++			f.Set(reflect.ValueOf(&newSlice))
++		case *WaitForInstancesSignal:
++			var newSlice WaitForInstancesSignal
++			for _, v := range *raw.(*WaitForInstancesSignal) {
++				newSlice = append(newSlice, replacer.Replace(v))
++			}
++			f.Set(reflect.ValueOf(&newSlice))
+ 		default:
+ 			if f.Kind() != reflect.Ptr {
+ 				continue",Didn't we have specific logic for handling slices vs structs?
+4815,"@@ -4199,7 +4199,15 @@ void EntityList::QuestJournalledSayClose(Mob *sender, float dist, const char *mo
+ 	buf.WriteInt32(0); // location, client doesn't seem to do anything with this
+ 	buf.WriteInt32(0);
+ 	buf.WriteInt32(0);
+-	buf.WriteString(message);
++
++	// auto inject saylinks (say)
++	if (RuleB(Chat, AutoInjectSaylinksToSay)) {
++		std::string new_message = EQ::SayLinkEngine::InjectSaylinksIfNotExist(message);
++		buf.WriteString(new_message.c_str());
++	}
++	else {
++		buf.WriteString(message);
++	}
+
+ 	auto outapp = new EQApplicationPacket(OP_SpecialMesg, buf);
+ ",`c_str()` is not needed.
+4816,"@@ -310,9 +310,12 @@ func installHandlers(c *ExtraConfig, s *genericapiserver.GenericAPIServer) {
+ 		})
+ 	}
+
++	if features.DefaultFeatureGate.Enabled(features.Egress) || features.DefaultFeatureGate.Enabled(features.ServiceExternalIP) {
++		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/externalippool"", webhook.HandlerForValidateFunc(c.externalIPPoolController.ValidateExternalIPPool))
++	}
++
+ 	if features.DefaultFeatureGate.Enabled(features.Egress) {
+ 		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/egress"", webhook.HandlerForValidateFunc(c.egressController.ValidateEgress))
+-		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/externalippool"", webhook.HandlerForValidateFunc(c.externalIPPoolController.ValidateExternalIPPool))
+ 	}
+
+ 	if features.DefaultFeatureGate.Enabled(features.AntreaIPAM) {",The handler will be installed twice if you don't remove the below one.
+4817,"@@ -35,9 +35,14 @@ public class EthashConfigOptions {
+     return JsonUtil.getLong(ethashConfigRoot, ""fixeddifficulty"");
+   }
+
++  public OptionalLong getEpochLengthActivationBlock() {
++    return JsonUtil.getLong(ethashConfigRoot, ""epochlengthactivation"");
++  }
++
+   Map<String, Object> asMap() {
+     final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
+     getFixedDifficulty().ifPresent(l -> builder.put(""fixeddifficulty"", l));
++    getEpochLengthActivationBlock().ifPresent(a -> builder.put(""epochlengthactivation"", a));
+     return builder.build();
+   }
+ }",How about putting `epochLength` (or something like that) in place of `a` just to make it easier to read
+4818,"@@ -79,6 +79,14 @@ func (graph *BuildGraph) Target(label BuildLabel) *BuildTarget {
+ func (graph *BuildGraph) TargetOrDie(label BuildLabel) *BuildTarget {
+ 	target := graph.Target(label)
+ 	if target == nil {
++		// TODO(jpoole): This is just a small usability message to help with the migration from v15 to v16. We should
++		// probably remove this after a grace period.
++		if label.Subrepo == ""pleasings"" {
++			if _, ok := graph.subrepos[""pleasings""]; !ok {
++				log.Warning(""You've tried to use the pleasings sub-repo. This is no longer included automatically."")
++				log.Warning(""Use `plz init pleasings` to add the pleasings repo to your project."")
++			}
++		}
+ 		log.Fatalf(""Target %s not found in build graph\n"", label)
+ 	}
+ 	return target",Wouldn't this still fire afterwards if you created one called `pleasings`? or am I missing something?
+4819,"@@ -63,14 +63,14 @@ const kbpRecordPrefix = ""_keybase_pages.""
+ // _keybase_pages.meatball.gao.io   TXT ""kbp=/keybase/public/songgao/meatball/""
+ // _keybase_pages.song.gao.io       TXT ""kbp=/keybase/private/songgao,kb_bot/blah""
+ // _keybase_pages.blah.strib.io     TXT ""kbp=/keybase/private/strib#kb_bot/blahblahb"" ""lah/blah/""
+-// _keybase_pages.kbp.jzila.com     TXT ""kbp=git-keybase://private/jzila,kb_bot/kbp.git""
++// _keybase_pages.kbp.jzila.com     TXT ""kbp=git@keybase:private/jzila,kb_bot/kbp.git""
+ func LoadRootFromDNS(log *zap.Logger, domain string) (root Root, err error) {
+ 	var rootPath string
+
+ 	defer func() {
+ 		zapFields := []zapcore.Field{
+ 			zap.String(""domain"", domain),
+-			zap.String(""root_path"", rootPath),
++			zap.String(""kbp_record"", rootPath),
+ 		}
+ 		if err == nil {
+ 			log.Info(""LoadRootFromDNS"", zapFields...)","I don't love this syntax; it doesn't match anything we're currently doing and it's not obvious. Why isn't this `/keybase/private/jzila,kb_bot/.kbfs_autogit/public/jzila/kbp.git`?"
+4820,"@@ -1135,11 +1135,17 @@ public final class Queue<T> extends AbstractsQueue<T, Queue<T>> implements Linea
+         return ofAll(toList().update(index, element));
+     }
+
+-    @SuppressWarnings(""unchecked"")
+     @Override
+     public <U> Queue<Tuple2<T, U>> zip(Iterable<? extends U> that) {
++        return zipWith(that, Tuple::of);
++    }
++
++    @SuppressWarnings(""unchecked"")
++    @Override
++    public <U, R> Queue<R> zipWith(Iterable<? extends U> that, BiFunction<? super T, ? super U, ? extends R> mapper) {
+         Objects.requireNonNull(that, ""that is null"");
+-        return ofAll(toList().zip((Iterable<U>) that));
++        Objects.requireNonNull(mapper, ""mapper is null"");
++        return ofAll(toList().zipWith((Iterable<U>) that, mapper));
+     }
+
+     @Override","Does a type-hint work instead of casting? `return ofAll(toList().<U> zipWith(that, mapper));` (Probably not, just a question.)"
+4821,"@@ -90,11 +90,11 @@ public class TestTableMetadata {
+     long previousSnapshotId = System.currentTimeMillis() - new Random(1234).nextInt(3600);
+     Snapshot previousSnapshot = new BaseSnapshot(
+         ops.io(), previousSnapshotId, null, previousSnapshotId, null, null, null, ImmutableList.of(
+-        new GenericManifestFile(localInput(""file:/tmp/manfiest.1.avro""), SPEC_5.specId())));
++          new GenericManifestFile(localInput(""file:/tmp/manfiest.1.avro""), SPEC_5.specId())));
+     long currentSnapshotId = System.currentTimeMillis();
+     Snapshot currentSnapshot = new BaseSnapshot(
+         ops.io(), currentSnapshotId, previousSnapshotId, currentSnapshotId, null, null, 7, ImmutableList.of(
+-        new GenericManifestFile(localInput(""file:/tmp/manfiest.2.avro""), SPEC_5.specId())));
++          new GenericManifestFile(localInput(""file:/tmp/manfiest.2.avro""), SPEC_5.specId())));
+
+     List<HistoryEntry> snapshotLog = ImmutableList.<HistoryEntry>builder()
+         .add(new SnapshotLogEntry(previousSnapshot.timestampMillis(), previousSnapshot.snapshotId()))",Are these required?
+4822,"@@ -544,6 +544,13 @@ func (c *client) initClient() {
+ 	// Snapshots to avoid mutex access in fast paths.
+ 	c.out.wdl = opts.WriteDeadline
+ 	c.out.mp = opts.MaxPending
++	// Snapshot max control line since currently can not be changed on reload and we
++	// were checking it on each call to parse. If this changes and we allow MaxControlLine
++	// to be reloaded without restart, this code will need to change.
++	c.mcl = int32(opts.MaxControlLine)
++	if c.mcl == 0 {
++		c.mcl = MAX_CONTROL_LINE_SIZE
++	}
+
+ 	c.subs = make(map[string]*subscription)
+ 	c.echo = true","This is consistent for all clients that we will check yes? Seems like we should just use the singleton, maybe pass it to the parse function or since clients have a server pointer set it at server start and just access that way without locks?"
+4823,"@@ -62,7 +62,7 @@ public class JavaTokenizer extends JavaCCTokenizer {
+
+         if (ignoreLiterals && (javaToken.kind == JavaTokenKinds.STRING_LITERAL
+                 || javaToken.kind == JavaTokenKinds.CHARACTER_LITERAL
+-                || javaToken.kind == JavaTokenKinds.DECIMAL_LITERAL
++                || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL
+                 || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL)) {
+             image = String.valueOf(javaToken.kind);
+         }","Note that this is a bug, that should be fixed on master. `DECIMAL_LITERAL` cannot match any token, because it's declared with a `#`."
+4824,"@@ -26,6 +26,8 @@ import (
+ 	""sync/atomic""
+ 	""time""
+
++	""github.com/nats-io/nuid""
++
+ 	""github.com/nats-io/nats-server/v2/server/pse""
+ )
+ ",Don't need extra line here.
+4825,"@@ -637,9 +637,7 @@ namespace Nethermind.JsonRpc.Test.Modules.Proof
+                 .Op(Instruction.DELEGATECALL)
+                 .Done;
+             CallResultWithProof result = TestCallWithCode(code);
+-
+-            // change in test after the modification to how the ReleaseSpec is delivered to the virtual machine
+-            Assert.AreEqual(2 + (_useNonZeroGasPrice ? 1 : 0), result.Accounts.Length);
++            Assert.AreEqual(3, result.Accounts.Length);
+         }
+
+         [Test]","For the first look, this change is strange. Were we passing these tests before?"
+4826,"@@ -21,9 +21,16 @@ import (
+ )
+
+ func gracefullyStopProcess(pid int) error {
+-	cmd := exec.Command(""taskkill"", ""/pid"", strconv.Itoa(pid))
++	fmt.Printf(""Stop..."")
++	// process on windows will not stop unless forced with /f
++	cmd := exec.Command(""taskkill"", ""/pid"", strconv.Itoa(pid), ""/f"")
+ 	if err := cmd.Run(); err != nil {
+ 		return fmt.Errorf(""taskkill: %v"", err)
+ 	}
+ 	return nil
+ }
++
++func matchProcess(appname string, processname string) bool {
++	// on Windows the process name will include the extension
++	return appname == processname+"".exe""
++}","On Windows, doesn't `os.Args[0]` include the `.exe`? What if you run the program like `caddy.exe`?"
+4827,"@@ -112,13 +112,8 @@ type OpenvpnConfigNegotiator struct {
+ 	vpnConfig openvpn_service.VPNConfig
+ }
+
+-// ConsumeConfig doesn't do anything on the openvpn side, since it's not required here
+-func (ocn *OpenvpnConfigNegotiator) ConsumeConfig(json.RawMessage) error {
+-	return nil
+-}
+-
+ // ProvideConfig returns the config for user
+-func (ocn *OpenvpnConfigNegotiator) ProvideConfig() (session.ServiceConfiguration, error) {
++func (ocn *OpenvpnConfigNegotiator) ProvideConfig(json.RawMessage) (session.ServiceConfiguration, error) {
+ 	return &ocn.vpnConfig, nil
+ }
+ ","I don't see anywhere where `ServiceConfiguration` interface implementation would return any kind of error. Not sure if its needed, but we could ALWAYS return a valid 'pseudo' configuration without possibility of error."
+4828,"@@ -36,4 +36,15 @@ public class CommonRenderingUtilTest {
+     assertThat(CommonRenderingUtil.stripQuotes(""'a'bc'"")).isEqualTo(""'a'bc'"");
+     assertThat(CommonRenderingUtil.stripQuotes(""\""a\""bc\"""")).isEqualTo(""\""a\""bc\"""");
+   }
++
++  @Test
++  public void testGetDocLines() {
++    // Check that we don't care which form of line break is used.
++    assertThat(CommonRenderingUtil.getDocLines(""a\nb\nc"")).containsExactly(""a"", ""b"", ""c"").inOrder();
++    assertThat(CommonRenderingUtil.getDocLines(""a\rb\rc"")).containsExactly(""a"", ""b"", ""c"").inOrder();
++    assertThat(CommonRenderingUtil.getDocLines(""a\r\nb\r\nc""))
++        .containsExactly(""a"", ""b"", ""c"")
++        .inOrder();
++    assertThat(CommonRenderingUtil.getDocLines("""")).isEmpty();
++  }
+ }","Do we actually want to split on `\r`? I thought that the ""newline sequence"" was only `\r\n` on windows."
+4829,"@@ -273,10 +273,14 @@ void t_json_generator::write_type_spec(t_type* ttype) {
+     write_key_and_string(""valueTypeId"", get_type_name(vtype));
+     write_type_spec_object(""keyType"", ktype);
+     write_type_spec_object(""valueType"", vtype);
+-  } else if (ttype->is_list() || ttype->is_set()) {
++  } else if (ttype->is_list()) {
+     t_type* etype = ((t_list*)ttype)->get_elem_type();
+     write_key_and_string(""elemTypeId"", get_type_name(etype));
+     write_type_spec_object(""elemType"", etype);
++  } else if (ttype->is_set()) {
++    t_type* etype = ((t_set*)ttype)->get_elem_type();
++    write_key_and_string(""elemTypeId"", get_type_name(etype));
++    write_type_spec_object(""elemType"", etype);
+   }
+ }
+ ",Nit: these lines are duplicated from above. They can be refactored by setting etype in a conditional and putting 282 and 283 below that.
+4830,"@@ -49,7 +49,7 @@ func (s *Server) handleSignals() {
+ 				s.Debugf(""Trapped %q signal"", sig)
+ 				switch sig {
+ 				case syscall.SIGINT:
+-					s.Noticef(""Server Exiting.."")
++					s.Shutdown()
+ 					os.Exit(0)
+ 				case syscall.SIGUSR1:
+ 					// File log re-open for rotating file logs.","I would do an s.Notice(""Initiating Shutdown..."") then after Shutdown() do the original Server Exiting."
+4831,"@@ -57,6 +57,11 @@ namespace Nethermind.DataMarketplace.Consumers.Refunds.Services
+             ulong now = _timestamper.UnixTime.Seconds;
+             if (!deposit.CanClaimRefund(now))
+             {
++                var timeLeftToClaimRefund = deposit.GetTimeLeftToClaimRefund(now);
++                if (timeLeftToClaimRefund > 0)
++                {
++                    if (_logger.IsError) _logger.Info($""Time left to claim a refund: {timeLeftToClaimRefund} seconds."");
++                }
+                 return RefundClaimStatus.Empty;
+             }
+             ",Not sure with how many seconds on average are we dealing with but maybe it's better to have hh:mm:ss format in logs - you can make it with `TimeSpan.FromSeconds(seconds).ToString()`
+4832,"@@ -257,6 +257,12 @@ func (a *ClusterDeploymentValidatingAdmissionHook) validateCreate(admissionSpec
+ 		if aws.Region == """" {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""region""), ""must specify AWS region""))
+ 		}
++		for i, mp := range newObject.Spec.Compute {
++			computePath := specPath.Child(""compute"").Index(i)
++			if mp.Platform.AWS == nil {
++				allErrs = append(allErrs, field.Required(computePath.Child(""aws""), ""must specify platform for compute machine sets""))
++			}
++		}
+ 	}
+ 	if newObject.Spec.Platform.Azure != nil {
+ 		numberOfPlatforms++",Why is this required? The user should be able to omit it and use the defaults.
+4833,"@@ -1353,6 +1353,12 @@ class MouseSettingsPanel(SettingsPanel):
+ 		self.audioDetectBrightnessCheckBox=sHelper.addItem(wx.CheckBox(self,label=audioDetectBrightnessText))
+ 		self.audioDetectBrightnessCheckBox.SetValue(config.conf[""mouse""][""audioCoordinates_detectBrightness""])
+
++		# Translators: This is the label for a checkbox in the
++		# mouse settings panel.
++		handleInjectedMouseControlText = _(""Handle mouse control from other &applications"")
++		self.handleInjectedMouseControlCheckBox=sHelper.addItem(wx.CheckBox(self,label=handleInjectedMouseControlText))
++		self.handleInjectedMouseControlCheckBox.SetValue(config.conf[""mouse""][""handleInjectedMouseControl""])
++
+ 	def onSave(self):
+ 		config.conf[""mouse""][""reportMouseShapeChanges""]=self.shapeCheckBox.IsChecked()
+ 		config.conf[""mouse""][""enableMouseTracking""]=self.mouseTrackingCheckBox.IsChecked()","I don't think the naming of this setting conveys what it does. Maybe something like ""Ignore mouse movement triggered by other applications"""
+4834,"@@ -26,11 +26,12 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation
+         public static readonly OpenTelemetryProtocolExporterEventSource Log = new OpenTelemetryProtocolExporterEventSource();
+
+         [NonEvent]
+-        public void FailedToReachCollector(Exception ex)
++        public void FailedToReachCollector(Uri collectorUri, Exception ex)
+         {
+             if (Log.IsEnabled(EventLevel.Error, EventKeywords.All))
+             {
+-                this.FailedToReachCollector(ex.ToInvariantString());
++                var rawCollectorUri = collectorUri.ToString();
++                this.FailedToReachCollector(rawCollectorUri, ex.ToInvariantString());
+             }
+         }
+ ",Didn't went with backwards compatibility since it's still in beta
+4835,"@@ -82,6 +82,9 @@ python::tuple fragmentMolHelper3(const RDKit::ROMol& mol, python::object ob,
+   std::vector<std::pair<RDKit::ROMOL_SPTR, RDKit::ROMOL_SPTR>> tres;
+   std::unique_ptr<std::vector<unsigned int>> v =
+       pythonObjectToVect<unsigned int>(ob);
++  if (!v) {
++    throw_value_error(""invalid value for bondsToCut"");
++  }
+   bool ok = RDKit::MMPA::fragmentMol(mol, tres, *v, minCuts, maxCuts);
+   python::list pyres;
+   if (ok) {",Perhaps bondsToCut must be None or non empty.
+4836,"@@ -79,6 +79,7 @@ function Sparkline( {
+ 	return (
+ 		<div className=""googlesitekit-analytics-sparkline-chart-wrap"">
+ 			<GoogleChart
++				chartType=""line""
+ 				data={ data }
+ 				options={ chartOptions }
+ 				// eslint-disable-next-line sitekit/camelcase-acronyms","See above, we could avoid adding that (same applies below)."
+4837,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long
+4838,"@@ -1,6 +1,7 @@
+ 'use strict';
+
+ var assert = require('assert');
++const expect = require('chai').expect;
+ var co = require('co');
+ var test = require('./shared').assert;
+ var setupDatabase = require('./shared').setupDatabase;",Should the rest of the file be updated to use `expect` or should this test use the same format as the rest of the tests?
+4839,"@@ -227,6 +227,12 @@ func (a *AWSActuator) Refresh() error {
+ 		}
+ 		logger.Debug(""Found hosted zone"")
+ 		a.zoneID = &zoneID
++
++		// Update dnsZone status now that we have the zoneID
++		if err := a.ModifyStatus(); err != nil {
++			a.logger.WithError(err).Error(""failed to update status after refresh"")
++			return err
++		}
+ 	}
+
+ 	if a.zoneID == nil {",How would you feel about a different approach where the `DeleteAWSRecordSets` gets passed the zone ID and zone name rather than the `DNSZone`?
+4840,"@@ -66,15 +66,17 @@ class PhotoMetricDistortion(object):
+
+ class Expand(object):
+
+-    def __init__(self, mean=(0, 0, 0), to_rgb=True, ratio_range=(1, 4)):
++    def __init__(self, mean=(0, 0, 0), to_rgb=True,
++                 ratio_range=(1, 4), prob=0.5):
+         if to_rgb:
+             self.mean = mean[::-1]
+         else:
+             self.mean = mean
+         self.min_ratio, self.max_ratio = ratio_range
++        self.prob = prob
+
+     def __call__(self, img, boxes, labels):
+-        if random.randint(2):
++        if random.uniform(0, 1) > self.prob:
+             return img, boxes, labels
+
+         h, w, c = img.shape","it seems `random.uniform(0, 1)` similar to `random.randint(2)`, all have 1/2 probabilities."
+4841,"@@ -121,7 +121,11 @@ class AutoScaleConnection(AWSQueryConnection):
+         for i in xrange(1, len(items)+1):
+             if isinstance(items[i-1], dict):
+                 for k, v in items[i-1].iteritems():
+-                    params['%s.member.%d.%s' % (label, i, k)] = v
++                    if isinstance(v, dict):
++                        for kk, vv in v.iteritems():
++                            params['%s.member.%d.%s.%s' % (label, i, k, kk)] = vv
++                    else:
++                        params['%s.member.%d.%s' % (label, i, k)] = v
+             elif isinstance(items[i-1], basestring):
+                 params['%s.member.%d' % (label, i)] = items[i-1]
+ ","Added to support EBS volume creation, used like this: blockDeviceMap = [] blockDeviceMap.append( {'DeviceName':'/dev/sdc', 'VirtualName' : 'ephemeral0'}) blockDeviceMap.append( {'DeviceName':'/dev/sdh', 'Ebs': {'VolumeSize' : '100'} })"
+4842,"@@ -17,6 +17,8 @@ type mockedSigner struct {
+ 	signatureToReturn identity.Signature
+ }
+
++var testMysteriumApiUrl = ""http://testUrl""
++
+ func (signer *mockedSigner) Sign(message []byte) (identity.Signature, error) {
+ 	return signer.signatureToReturn, nil
+ }","We shouldn't depend that url is `mysterium` - it can be just `testRequestURL`. Also, `URL` has to be upper-case."
+4843,"@@ -689,8 +689,9 @@ VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceImageFormatProperties2(VkPhysica
+                                                                        const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
+                                                                        VkImageFormatProperties2 *pImageFormatProperties) {
+     instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
+-    bool skip = PreCallValidateGetPhysicalDeviceImageFormatProperties2(instance_data->report_data, pImageFormatInfo,
+-                                                                       pImageFormatProperties);
++    unique_lock_t lock(global_lock);
++    bool skip = PreCallValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties);
++    lock.unlock();
+     if (skip) {
+         return VK_ERROR_VALIDATION_FAILED_EXT;
+     } else {",We could delay this look-up now and only do it in the non-skip case. I suspect this is true for (almost) all of the top-level refactored functions.
+4844,"@@ -144,6 +144,15 @@ std::string MetaServiceUtils::schemaTagKey(GraphSpaceID spaceId, TagID tagId, in
+     return key;
+ }
+
++std::string MetaServiceUtils::schemaTagPrefix(GraphSpaceID spaceId, TagID tagId) {
++    std::string key;
++    key.reserve(kTagsTable.size() + sizeof(GraphSpaceID) + sizeof(TagID));
++    key.append(kTagsTable.data(), kTagsTable.size());
++    key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
++    key.append(reinterpret_cast<const char*>(&tagId), sizeof(tagId));
++    return key;
++}
++
+ std::string MetaServiceUtils::schemaTagsPrefix(GraphSpaceID spaceId) {
+     std::string key;
+     key.reserve(kTagsTable.size() + sizeof(GraphSpaceID));","Typically, to be simple, we could reserve a const length space."
+4845,"@@ -0,0 +1,2 @@
++from .reader import *
++from .builder import Builder",Need to add a license and copyright header to each file.
+4846,"@@ -7,6 +7,8 @@
+   <% end %>
+
+   <%= form.inputs do %>
++    <%= hidden_field_tag ""coupon_id"" %>
++
+     <% if signed_out? %>
+       <ul class=""checkout-signin-signup-toggle"">
+         <li>","If I'm not mistaken, this line is now outside of the `if signed_out?` block, right? Any concerns about that? Seems odd that we wouldn't accept coupons for signed in users, but I want to make sure we understand the ramifications of this change."
+4847,"@@ -130,7 +130,7 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
+
+     @NotNull
+     @Override
+-    public DBPDataSource getDataSource() {
++    public PostgreDataSource getDataSource() {
+         return owner.getDataSource();
+     }
+ ",Please remove the unused import of DBPDataSource.
+4848,"@@ -43,7 +43,7 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+
+         public void LogError(string data)
+         {
+-            _log.LogError(data);
++            _log.LogWarning(data);
+         }
+
+         public void LogInformation(string data)","I think you should add some extra message here saying it was originally sent as an error, for diagnosability."
+4849,"@@ -144,14 +144,14 @@ void test3() {
+     ExplicitBitVect bv(2048);
+     AvalonTools::getAvalonFP(""c1cocc1"", true, bv, 2048, false, true, 0x006FFF);
+     BOOST_LOG(rdInfoLog) << ""c1cocc1 "" << bv.getNumOnBits() << std::endl;
+-    TEST_ASSERT(bv.getNumOnBits() == 53);
++    TEST_ASSERT(bv.getNumOnBits() == 48);
+   }
+   {
+     ExplicitBitVect bv(2048);
+     AvalonTools::getAvalonFP(""C1=COC=C1"", true, bv, 2048, false, true,
+                              0x006FFF);
+     BOOST_LOG(rdInfoLog) << ""C1=COC=C1 "" << bv.getNumOnBits() << std::endl;
+-    TEST_ASSERT(bv.getNumOnBits() == 53);
++    TEST_ASSERT(bv.getNumOnBits() == 48);
+   }
+
+   BOOST_LOG(rdInfoLog) << ""done"" << std::endl;",I believe that all the changes in this file are not valid for v1.2 of the Avalon toolkit.
+4850,"@@ -509,6 +509,7 @@ public class DBService {
+         } else {
+             // carrying over auditEnabled from original role
+             role.setAuditEnabled(originalRole.getAuditEnabled());
++            mergeOriginalRoleAndMetaRoleAttributes(originalRole, role);
+             requestSuccess = con.updateRole(domainName, role);
+         }
+         ",we cannot change the behavior of the processRole - that method is used in lots of places. this call must be done only in the method where templates are being handled.
+4851,"@@ -63,7 +63,9 @@ const (
+ 	// ECSAgentExecConfigDir is the directory where ECS Agent will write the ExecAgent config files to
+ 	ECSAgentExecConfigDir = ecsAgentExecDepsDir + ""/"" + ContainerConfigDirName
+ 	// HostExecConfigDir is the dir where ExecAgents Config files will live
+-	HostExecConfigDir = hostExecDepsDir + ""/"" + ContainerConfigDirName
++	HostExecConfigDir          = hostExecDepsDir + ""/"" + ContainerConfigDirName
++	ExecAgentLogConfigFileName = ""seelog.xml""
++	ContainerLogConfigFile     = ""configuration/"" + ExecAgentLogConfigFileName
+ )
+
+ var (",I think we probably want to follow the same naming convention that we do with `execAgentConfigFileNameTemplate` (using the SHA in the name of the file). This file might be confgurable in the future and when that happens we will be ready. Plus it's pretty much the same code that we already use for the config file.
+4852,"@@ -380,6 +380,14 @@ static void send_resource_update(struct link *manager)
+ 		total_resources->disk.total    = MAX(0, local_resources->disk.total);
+ 		total_resources->disk.largest  = MAX(0, local_resources->disk.largest);
+ 		total_resources->disk.smallest = MAX(0, local_resources->disk.smallest);
++
++		//if workers are set to expire at some time, send the amount of time left to manager
++		if(manual_wall_time_option != 0) {
++			total_resources->time_left = worker_start_time + manual_wall_time_option - time(0);
++		}
++		else {
++			total_resources->time_left = -1;
++		}
+ 	}
+
+ 	work_queue_resources_send(manager,total_resources,stoptime);","If following above, this would be: end_time = time(0) + manual_wall_time_option, which is simpler. Also, make the check manual_wall_time_option > 0, otherwise negative times would terminate the worker right away."
+4853,"@@ -116,6 +116,10 @@ func (err wrappedFatalError) Cause() error {
+ 	return err.error
+ }
+
++func (err wrappedFatalError) Unwrap() error {
++	return err.error
++}
++
+ // IsFatalError returns true if err conforms to the Fatal interface
+ // and calling the Fatal method returns true.
+ func IsFatalError(err error) (isFatal bool) {",If we aren't using `errors.Is` we don't need the `Unwrap` as we have `Cause` which is what pkg/errors uses.
+4854,"@@ -4,8 +4,9 @@ import (
+ 	""io/ioutil""
+ 	""os""
+
++	""k8s.io/klog""
++
+ 	""github.com/kubeedge/beehive/pkg/common/config""
+-	""github.com/kubeedge/beehive/pkg/common/log""
+ 	""github.com/kubeedge/beehive/pkg/core""
+ 	""github.com/kubeedge/beehive/pkg/core/context""
+ 	""github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/channelq""",redundant empty line
+4855,"@@ -150,6 +150,7 @@ bool ConfigManager::load()
+ 	boolean[ONLINE_OFFLINE_CHARLIST] = getGlobalBoolean(L, ""showOnlineStatusInCharlist"", false);
+ 	boolean[YELL_ALLOW_PREMIUM] = getGlobalBoolean(L, ""yellAlwaysAllowPremium"", false);
+ 	boolean[FORCE_MONSTERTYPE_LOAD] = getGlobalBoolean(L, ""forceMonsterTypesOnLoad"", true);
++	boolean[HOUSE_OWNED_BY_ACCOUNT] = getGlobalBoolean(L, ""houseOwnedByAccount"", false);
+
+ 	string[DEFAULT_PRIORITY] = getGlobalString(L, ""defaultPriority"", ""high"");
+ 	string[SERVER_NAME] = getGlobalString(L, ""serverName"", """");",The config.lua.dist still shows `houseAccountOwner`
+4856,"@@ -11,7 +11,6 @@
+
+ namespace Sonata\MediaBundle\Command;
+
+-use Sonata\ClassificationBundle\Model\ContextInterface;
+ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+ use Symfony\Component\Console\Input\InputInterface;
+ use Symfony\Component\Console\Output\OutputInterface;",I think we can leave this import and use non FQNs in the code.
+4857,"@@ -1654,9 +1654,10 @@ class TargetLocator {
+    *     when the driver has changed focus to the specified window.
+    */
+   window(nameOrHandle) {
++    let paramName = this.driver_.getExecutor().w3c ? 'handle' : 'name';
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter(paramName, nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ",I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs
+4858,"@@ -79,11 +79,9 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
+         {
+             Log.LogMessage(MessageImportance.Low, $""START pushing items to feed"");
+-            Random rnd = new Random();
+
+             try
+             {
+-
+                 bool result = await PushAsync(items.ToList(), allowOverwrite);
+                 return result;
+             }",We should probably exit early if there are no items in the list.
+4859,"@@ -16,7 +16,7 @@ def _private_func3(param1):  # [missing-raises-doc]
+     raise Exception('Example')
+
+
+-def public_func1(param1):  # [missing-param-doc, missing-type-doc]
++def public_func1(param1):  # [missing-any-param-doc]
+     """"""This is a test docstring without params""""""
+     print(param1)
+ ",As we can't use old names we should warn in whats new for 2.12 that this can happen.
+4860,"@@ -0,0 +1,13 @@
++// +build testbincover
++
++package main
++
++import (
++	""testing""
++
++	""github.com/confluentinc/bincover""
++)
++
++func TestBincoverRunMain(t *testing.T) {
++	bincover.RunTest(main)
++}","good job finding this package, I hope it's actively maintained"
+4861,"@@ -82,7 +82,6 @@ void getDevicePCIBusNum(int deviceID, char* pciBusID) {
+
+ int main() {
+     unsetenv(""HIP_VISIBLE_DEVICES"");
+-    unsetenv(""CUDA_VISIBLE_DEVICES"");
+
+     std::vector<std::string> devPCINum;
+     char pciBusID[100];",same changes as in hipEnvVar.cpp
+4862,"@@ -1,6 +1,11 @@
++#ifndef _POSIX_C_SOURCE
++#define _POSIX_C_SOURCE 200809L
++#endif
++#include <string.h>
+ #include <assert.h>
+ #include <libinput.h>
+ #include <stdlib.h>
++#include <wayland-util.h>
+ #include <wlr/backend/session.h>
+ #include <wlr/interfaces/wlr_tablet_tool.h>
+ #include <wlr/types/wlr_input_device.h>",NULL check should be before this line
+4863,"@@ -177,7 +177,7 @@ public class WildernessLocationsPlugin extends Plugin
+ 			|| (this.pvpWorld && WorldType.isAllPvpWorld(client.getWorldType())));
+ 		if (renderLocation)
+ 		{
+-			if (client.getLocalPlayer().getWorldLocation() != worldPoint)
++			if (client.getLocalPlayer() != null && client.getLocalPlayer().getWorldLocation() != worldPoint)
+ 			{
+ 				locationString = WorldLocation.location(client.getLocalPlayer().getWorldLocation());
+ 				worldPoint = client.getLocalPlayer().getWorldLocation();","Seems like client.getlocalplayer is being called a lot, would it be worth it to do final Player player = client.getlocalplayer?"
+4864,"@@ -116,9 +116,9 @@ ex_expr::exp_return_type ex_comp_clause::processNulls(char *op_data[],
+        // then move boolean unknown value to result and return.
+        if (getOperand(i)->getNullFlag() && (!op_data[i])) // missing value
+    	{
+-   	  // move null value to result.
+-   	  *(Lng32 *)op_data[2 * MAX_OPERANDS] = -1;
+-   	  return ex_expr::EXPR_NULL;
++            // move null value to result.
++            *(Lng32 *)op_data[2 * MAX_OPERANDS] = 0;
++            return ex_expr::EXPR_NULL;
+    	}
+      }
+    ","this change is not correct. 3-valued boolean logic requires that comparison of null to another value during intermediate operations should make the result null and not false. The place where null becomes false is at the very end of that expression. As an example, with the changed logic, this expression will return incorrect result. select * from t where not (a = 1); if a is null, the where predicate will become true which is incorrect. With the original 3-valued result, the where pred will become false and not return any result."
+4865,"@@ -95,6 +95,7 @@ func NewReplacer(r *http.Request, rr *ResponseRecorder, emptyValue string) Repla
+ 				dir, _ := path.Split(r.URL.Path)
+ 				return dir
+ 			}(),
++			""{locale}"": r.Header.Get(""Detected-Locale""),
+ 		},
+ 		emptyValue: emptyValue,
+ 	}","This can already be done with `{>Detected-Locale}`, why make another way to do it?"
+4866,"@@ -2376,10 +2376,11 @@ public class DatasetPage implements java.io.Serializable {
+                 requestContext.execute(""PF('selectFilesForRestrict').show()"");
+             return """";
+         } else {
+-            boolean validSelection = false;
++            boolean validSelection = true;
+             for (FileMetadata fmd : selectedFiles) {
+-                if (!fmd.isRestricted() ){
+-                    validSelection = true;
++                if (fmd.isRestricted() == true) {
++                    validSelection = false;
++                    break;
+                 }
+             }
+             if (!validSelection) {",These changes just match the logic update in the next method that was done previously - to assure the whole set of files is valid rather than that there is at least one that would be changed.
+4867,"@@ -30,6 +30,11 @@ func (s *server) bytesUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 		jsonhttp.InternalServerError(w, ""cannot get or create tag"")
+ 		return
+ 	}
++	w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))
++	w.WriteHeader(http.StatusContinue)
++	if f, ok := w.(http.Flusher); ok {
++		f.Flush()
++	}
+
+ 	// Add the tag to the context
+ 	ctx := sctx.SetTag(r.Context(), tag)",Why setting the status to Continue as at the end it is written OK? Status should be written only once.
+4868,"@@ -140,10 +140,10 @@ func deps() {
+ 		cmd(""go get -u github.com/pmezard/go-difflib/difflib""),
+ 		cmd(""./scripts/install-rust-proofs.sh""),
+ 		cmd(""./scripts/install-bls-signatures.sh""),
++		cmd(""./proofs/bin/paramcache""),
++		cmd(""./scripts/copy-groth-params.sh""),
+ 	}
+
+-	cmds = append(cmds, hydrateParamCache()...)
+-
+ 	for _, c := range cmds {
+ 		runCmd(c)
+ 	}","Howdy! You'll want to do this same thing (replace `hydrateParamCache` with `proofs/bin/paramcache` and then do the copy) in `smartdeps`, too."
+4869,"@@ -46,6 +46,16 @@ import (
+
+ // CmdSnaphotCreateOptions holds the options for snapshot
+ // create command
++var (
++	snapshotCreateCommandHelpText = `
++	usage: mayactl snapshot create --volname <vol> --snapname <snap>
++
++	this command creates a volume snapshot
++
++	note: the volume should exit before itself
++	`
++)
++
+ type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string",nit : Remove the extra lines
+4870,"@@ -184,6 +184,7 @@ type Options struct {
+ 	ServerName            string        `json:""server_name""`
+ 	Host                  string        `json:""addr""`
+ 	Port                  int           `json:""port""`
++	DontListen            bool          `json:""dont_listen""`
+ 	ClientAdvertise       string        `json:""-""`
+ 	Trace                 bool          `json:""-""`
+ 	Debug                 bool          `json:""-""`","Instead of adding a new option, I wonder if we could decide on a port that would disable listening. For instance, port set to 0 means that we use default port 4222. Setting to -1 means that we let OS pick a random free port. We could say anything negative lower than -1 (say -2) means disabled? You don't have to update the PR for that, just wondering if that would be better or not and let's see what others think."
+4871,"@@ -2511,6 +2511,9 @@ class ThriftRequestHandler(object):
+             if report.metadata:
+                 return report.metadata.get(""analyzer"", {}).get(""name"")
+
++            if report.check_name.startswith('clang-diagnostic-'):
++                return 'clang-tidy'
++
+         # Processing PList files.
+         _, _, report_files = next(os.walk(report_dir), ([], [], []))
+         all_report_checkers = set()",Should we add some default case if non of the above return some analyzer name? Something like `unknown analyzer`?
+4872,"@@ -115,7 +115,7 @@ module Faker
+           keywords << :special_characters if legacy_special_characters != NOT_GIVEN
+         end
+
+-        min_alpha = mix_case ? 2 : 0
++        min_alpha = mix_case && min_length > 1 ? 2 : 0
+         temp = Lorem.characters(number: min_length, min_alpha: min_alpha)
+         diff_length = max_length - min_length
+ ",Nvm. The original version is best... *hides from the angry rubocop*
+4873,"@@ -100,14 +100,13 @@ func (c *client) Call(
+ 		return nil, err
+ 	}
+
+-	body, cleanup, err := marshal(req.Encoding, protoReq)
++	body, err := marshal(req.Encoding, protoReq)
+ 	if err != nil {
+ 		return nil, yarpcencoding.RequestBodyEncodeError(req, err)
+ 	}
+-	defer cleanup()
+
+ 	reqBuf := &yarpc.Buffer{}
+-	if _, err := reqBuf.Write(body); err != nil {
++	if _, err := reqBuf.Write(body.Bytes()); err != nil {
+ 		return nil, err
+ 	}
+ ","we can drop this and use the returned body above, right?"
+4874,"@@ -142,12 +142,12 @@ module Travis
+
+             def install
+               sh.if ""$(rvm use $(travis_internal_ruby) do ruby -e \""puts RUBY_VERSION\"") = 1.9*"" do
+-                cmd(dpl_install_command(WANT_18), echo: false, assert: !allow_failure, timing: true)
++                cmd(dpl_install_command(WANT_18), echo: true, assert: !allow_failure, timing: true)
+               end
+               sh.else do
+-                cmd(dpl_install_command, echo: false, assert: !allow_failure, timing: true)
++                cmd(dpl_install_command, echo: true, assert: !allow_failure, timing: true)
+               end
+-              sh.cmd ""rm -f dpl-*.gem"", echo: false, assert: false, timing: false
++              sh.cmd ""rm -f $TRAVIS_BUILD_DIR/dpl-*.gem"", echo: false, assert: false, timing: false
+             end
+
+             def run_command(assert = !allow_failure)",Is echoing enabled on purpose here or it's a remainder of your tests?
+4875,"@@ -98,6 +98,7 @@ module Bolt
+     end
+
+     def run_command(targets, command, options = {}, &callback)
++      @logger.notice(options['_description']) if options.key?('_description')
+       @logger.info(""Starting command run '#{command}' on #{targets.map(&:uri)}"")
+       notify = proc { |event| @notifier.notify(callback, event) if callback }
+       options = { '_run_as' => run_as }.merge(options) if run_as",I think this should just be worked into the next message and follow the verbosity of it.
+4876,"@@ -106,6 +106,7 @@ export const selectors = {
+ 	 *
+ 	 * @since 1.14.0
+ 	 *
++	 * @param {Object} urlParams URL parameters to be passed to the query.
+ 	 * @return {(string|undefined)} AdSense account site overview URL (or `undefined` if not loaded).
+ 	 */
+ 	getServiceAccountSiteURL: createRegistrySelector( ( select ) => () => {",This also needs to be reverted.
+4877,"@@ -105,6 +105,13 @@ const (
+ 	TLFJournalBackgroundWorkEnabled
+ )
+
++type tlfJournalPauseType int
++
++const (
++	journalPausedFromConflict tlfJournalPauseType = 1 << iota
++	journalPausedFromSignal
++)
++
+ func (bws TLFJournalBackgroundWorkStatus) String() string {
+ 	switch bws {
+ 	case TLFJournalBackgroundWorkEnabled:","`FromCommand` seems to fit better, since with my suggestion below, all pauses will raise a signal on `needPause`. Also maybe the format `journalPauseConflict` and `journalPauseCommand` is better, since the journal isn't necessarily paused yet once we raise a pause signal."
+4878,"@@ -236,7 +236,7 @@ func IsServiceNonRetryableError(err error) bool {
+ // IsServiceNonRetryableErrorGRPC checks if the error is a non retryable error.
+ func IsServiceNonRetryableErrorGRPC(err error) bool {
+ 	if err == context.DeadlineExceeded {
+-		return true
++		return false
+ 	}
+
+ 	if st, ok := status.FromError(err); ok {",This is fix from another PR #120.
+4879,"@@ -20,7 +20,9 @@ class MultiInterface(Interface):
+
+     datatype = 'multitabular'
+
+-    subtypes = ['dataframe', 'dictionary', 'array', 'dask']
++    subtypes = ['dictionary', 'dataframe', 'array', 'dask']
++
++    multi = True
+
+     @classmethod
+     def init(cls, eltype, data, kdims, vdims):","I *think* it makes sense to try the more general dictionary (i.e standard python literals) format first. Might be other implications I haven't figured out yet. Then again, ``MultiInterface`` is pretty new so it probably doesn't matter wrt backwards compatibility."
+4880,"@@ -32,9 +32,13 @@ class FixMediaContextCommand extends ContainerAwareCommand
+      */
+     public function execute(InputInterface $input, OutputInterface $output)
+     {
++        if (!$this->getContainer()->has('sonata.media.manager.category')) {
++            throw new \LogicException('The classification feature is disabled.');
++        }
++
+         $pool = $this->getContainer()->get('sonata.media.pool');
+         $contextManager = $this->getContainer()->get('sonata.classification.manager.context');
+-        $cateoryManager = $this->getContainer()->get('sonata.classification.manager.category');
++        $categoryManager = $this->getContainer()->get('sonata.media.manager.category');
+
+         foreach ($pool->getContexts() as $context => $contextAttrs) {
+             /** @var ContextInterface $defaultContext */",lol that variable name
+4881,"@@ -31,8 +31,8 @@ const (
+ 	ChainFilterForward = ChainNamePrefix + ""-FORWARD""
+ 	ChainFilterOutput  = ChainNamePrefix + ""-OUTPUT""
+
+-	ChainFailsafeIn  = ChainNamePrefix + ""-FAILSAFE-IN""
+-	ChainFailsafeOut = ChainNamePrefix + ""-FAILSAFE-OUT""
++	ChainFailsafeIn  = ChainNamePrefix + ""-failsafe-in""
++	ChainFailsafeOut = ChainNamePrefix + ""-failsafe-out""
+
+ 	ChainNATPrerouting  = ChainNamePrefix + ""-PREROUTING""
+ 	ChainNATPostrouting = ChainNamePrefix + ""-POSTROUTING""",Upper case is reserved for our versions of top-level chains i.e. the `FORWARD` chain jumps to `cali-FORWARD`.
+4882,"@@ -3373,10 +3373,14 @@ void nano::json_handler::receive ()
+ 					}
+ 					if (!ec)
+ 					{
++						// Representative is only used by receive_action when opening accounts
++						// Set a wallet default representative for new accounts
++						nano::account representative (wallet->store.representative (node.wallets.tx_begin_read ()));
++
+ 						bool generate_work (work == 0); // Disable work generation if ""work"" option is provided
+ 						auto response_a (response);
+ 						// clang-format off
+-						wallet->receive_async(std::move(block), account, node.network_params.ledger.genesis_amount, [response_a](std::shared_ptr<nano::block> block_a) {
++						wallet->receive_async(std::move(block), representative, node.network_params.ledger.genesis_amount, [response_a](std::shared_ptr<nano::block> block_a) {
+ 							if (block_a != nullptr)
+ 							{
+ 								boost::property_tree::ptree response_l;",json_handler::receive () has already started a read tx that can be used here right?
+4883,"@@ -84,6 +84,9 @@ describe( 'CompatibilityChecks', () => {
+ 	it( 'should make API requests to ""setup-checks, health-checks and AMP Project test URL', async () => {
+ 		const token = 'test-token-value';
+
++		global._googlesitekitBaseData = global._googlesitekitBaseData || {};
++		global._googlesitekitBaseData[ 'isWP5.0+' ] = true;
++
+ 		// Mock request to setup-tag.
+ 		fetchMock.postOnce(
+ 			/^\/google-site-kit\/v1\/core\/site\/data\/setup-tag/,",We should add the definition to `.storybook/config.js` as well.
+4884,"@@ -96,7 +96,7 @@ ex_expr::exp_return_type ex_branch_clause::eval(char *op_data[],
+   switch (getOperType())
+     {
+     case ITM_AND:
+-      if (*(Lng32 *)op_data[1] == 0)
++      if (*(Lng32 *)op_data[1] == 0 || *(Lng32 *)op_data[1] == -1)  // null treated as false
+ 	{
+ 	  *(Lng32 *)op_data[0] = 0;
+ 	  setNextClause(branch_clause);","I don't believe this is correct. Consider the query, ""select a from t1x where not(b = 0 and c = 0)"". When B and C are both null, both equal predicates evaluate to null, and the AND evaluates to null. The NOT then also evaluates to null. The WHERE clause should treat the result of the NOT as false. But with this fix, the result of the AND will be false, making the NOT true. There needs to be three cases here for ITM_AND: If the first operand is false, then the AND is false. If the first operand is true, then the result is the second operand. If the first operand is null, then if the second operand is false, the result is false otherwise the result is null. Similar logic needs to be added to the ITM_OR case."
+4885,"@@ -72,7 +72,12 @@ final class IntArrayDocIdSet extends DocIdSet {
+
+     @Override
+     public int advance(int target) throws IOException {
+-      i = Arrays.binarySearch(docs, i + 1, length, target);
++      int bound = 1;
++      int offset = Math.max(0, i);
++      while(offset + bound < length && docs[offset + bound] < target) {
++        bound *= 2;
++      }
++      i = Arrays.binarySearch(docs, offset + bound / 2, Math.min(offset + bound, length), target);
+       if (i < 0) {
+         i = -1 - i;
+       }","`bound/2` is generally the previous bound that we tested, except when `bound` is equal to 1. It won't break in that case since callers are not supposed to call advance on a target that is lte the current doc ID, but this might still make room for bugs?"
+4886,"@@ -65,8 +65,12 @@ function Admin(db, topology, promiseLibrary) {
+  * @method
+  * @param {object} command The command hash
+  * @param {object} [options] Optional settings.
+- * @param {(ReadPreference|string)} [options.readPreference] The preferred read preference (ReadPreference.PRIMARY, ReadPreference.PRIMARY_PREFERRED, ReadPreference.SECONDARY, ReadPreference.SECONDARY_PREFERRED, ReadPreference.NEAREST).
+- * @param {number} [options.maxTimeMS] Number of milliseconds to wait before aborting the query.
++ * @param {boolean} [options.raw=false] Return a raw nodejs Buffer instead of deserializing BSON
++ * @param {boolean} [options.fullResult=false] Return the full envelope instead of just the result document
++ * @param {boolean} [options.serializeFunctions=false] Specify if functions on an object should be serialized
++ * @param {boolean} [options.ignoreUndefined=false] Specify if the BSON serializer should ignore undefined fields
++ * @param {ReadPreference|string} [options.readPreference] Specify read preference if command supports it
++ * @param {ClientSession} [options.session] Session to use for the operation
+  * @param {Admin~resultCallback} [callback] The command result callback
+  * @return {Promise} returns Promise if no callback passed
+  */","Can we remove `raw`, `fullResult`, and `serializeFunctions`?"
+4887,"@@ -110,6 +110,8 @@ type (
+ 		TLS RootTLS `yaml:""tls""`
+ 		// Metrics is the metrics subsystem configuration
+ 		Metrics *Metrics `yaml:""metrics""`
++		// Settings for authentication and authorization
++		Security Security `yaml:""security""`
+ 	}
+
+ 	// RootTLS contains all TLS settings for the Temporal server","[Nit] I don't have a proposed suggestion, but security seems too generic of a name here."
+4888,"@@ -0,0 +1,19 @@
++const config = require('../lib/config')
++const util = require('../lib/util')
++const path = require('path')
++const fs = require('fs-extra')
++
++const createDist = (options) => {
++  config.update(options)
++  config.buildConfig = 'Release'
++
++  let cmdOptions = config.defaultOptions
++  const args = util.buildArgsToString(config.buildArgs())
++
++  fs.removeSync(path.join(config.outputDir, 'dist'))
++  util.run('gn', ['gen', config.outputDir, '--args=""' + args + '""'], cmdOptions)
++  util.run('ninja', ['-C', config.outputDir, 'create_dist'], cmdOptions)
++}
++
++module.exports = createDist
++","do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people"
+4889,"@@ -302,6 +302,10 @@ bool Client::Process() {
+ 		}
+
+ 		if (AutoFireEnabled()) {
++			if (this->GetTarget() == this) {
++				this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++				auto_fire = false;
++			}
+ 			EQ::ItemInstance *ranged = GetInv().GetItem(EQ::invslot::slotRange);
+ 			if (ranged)
+ 			{",Shouldn't need this-> here.
+4890,"@@ -1,4 +1,3 @@
+-# Copyright (c) OpenMMLab. All rights reserved.
+ import math
+
+ import torch",Why delete this?
+4891,"@@ -10,6 +10,17 @@ export function extend(obj, props) {
+ 	return obj;
+ }
+
++/** Invoke or update a ref, depending on whether it is a function or object ref.
++ *  @param {object|function} [ref=null]
++ *  @param {any} [value]
++ */
++export function applyRef(ref, value) {
++	if (ref!=null) {
++		if (typeof ref=='function') ref(value);
++		else ref.current = value;
++	}
++}
++
+ /**
+  * Call a function asynchronously, as soon as possible. Makes
+  * use of HTML Promise to schedule the callback if available,","This line is here to be compatible with the current way `refs` work, right?"
+4892,"@@ -10,7 +10,11 @@
+         <strong><%= name %>
+       </td>
+       <td>
+-        <%= value %>
++        <% if value.class == BigDecimal %>
++          <%= number_to_currency(value) %>
++        <% else %>
++          <%= value %>
++        <% end %>
+       </td>
+     </tr>
+   <%- end %>","Hmm, I wonder if we can safely assume all decimals should be displayed as $$...ok for now I suppose."
+4893,"@@ -443,4 +443,17 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
+       expect(ex.description).to match(/contains the example/)
+     end
+   end
++
++  describe ""setting the current example"" do
++    it ""sets RSpec.current_example to the example that is currently running"" do
++      group = RSpec::Core::ExampleGroup.describe(""an example group"")
++
++      current_examples = []
++      example1 = group.example(""example 1"") { current_examples << RSpec.current_example }
++      example2 = group.example(""example 2"") { current_examples << RSpec.current_example }
++
++      group.run
++      expect(current_examples).to eq([example1, example2])
++    end
++  end
+ end",Good spec :). Very clear and easy to see what it's doing.
+4894,"@@ -0,0 +1,12 @@
++class ExploreController < ApplicationController
++  def orgs
++    @newest_orgs = Organization.active.order('created_at DESC').limit(3)
++    @most_active_orgs = OrgThirtyDayActivity.most_active_orgs
++    @stats_by_sector = OrgStatsBySector.recent
++    @org_by_30_day_commits = OrgThirtyDayActivity.send(""filter_#{params[:filter]}_orgs"")
++  end
++
++  def orgs_by_thirty_day_commit_volume
++    @org_by_30_day_commits = OrgThirtyDayActivity.send(""filter_#{params[:filter]}_orgs"")
++  end
++end",Shouldn't we need to sanitize the `params[:filter]` from a defined expected values?
+4895,"@@ -10,6 +10,18 @@ from dagster.core.launcher.base import LaunchRunContext, RunLauncher
+ from dagster.grpc.types import ExecuteRunArgs
+ from dagster.serdes import ConfigurableClass, serialize_dagster_namedtuple
+ from dagster.utils.backcompat import experimental
++from dagster.utils.backoff import backoff
++
++
++# The ECS API is eventually consistent:
++# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html
++# describe_tasks might initially return nothing even if a task exists.
++class EcsEventualConsistencyTimeout(Exception):
++    pass
++
++
++# 9 retries polls for up to 51.1 seconds with exponential backoff.
++BACKOFF_RETRIES = 9
+
+
+ @dataclass","Should we bite the bullet and poll for the full 5 minutes that AWS recommends? If we do that, we'll probably want to leave some kind of breadcrumb in the event log to let users know why it's taking so long to launch."
+4896,"@@ -36,7 +36,7 @@ import java.util.concurrent.TimeUnit;
+ import java.util.function.Predicate;
+ import java.util.function.Supplier;
+
+-import com.google.common.base.Objects;
++import com.google.common.base.MoreObjects;
+ import org.apache.solr.common.SolrException;
+ import org.apache.solr.common.cloud.Aliases;
+ import org.apache.solr.common.params.CommonParams;",Guava changed `Objects` -> `MoreObjects`
+4897,"@@ -20,8 +20,11 @@
+
+ package mocks
+
+-import mock ""github.com/stretchr/testify/mock""
+-import persistence ""github.com/temporalio/temporal/common/persistence""
++import (
++	mock ""github.com/stretchr/testify/mock""
++
++	persistence ""github.com/temporalio/temporal/common/persistence""
++)
+
+ // MetadataManager is an autogenerated mock type for the MetadataManager type
+ type MetadataManager struct {",All these hand generated mocks can be deleted. I think we already moved everything to gomocks.
+4898,"@@ -1251,7 +1251,7 @@ Document.prototype.inspect = function (options) {
+  */
+
+ Document.prototype.equals = function (doc) {
+-  return this.get('_id') === doc.get('_id');
++  return this.get('_id').equals(doc.get('_id'));
+ };
+
+ /**",what about string/number etc _ids? this will fail.
+4899,"@@ -682,7 +682,7 @@ func TestRemoteMachineSetReconcile(t *testing.T) {
+ 								t.Errorf(""machineset %v has unexpected labels:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Labels, rMS.Labels)
+ 							}
+ 							if !reflect.DeepEqual(eMS.ObjectMeta.Annotations, rMS.ObjectMeta.Annotations) {
+-								t.Errorf(""machineset %v has unexpected annotations:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Labels, rMS.Labels)
++								t.Errorf(""machineset %v has unexpected annotations:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Annotations, rMS.Annotations)
+ 							}
+ 							if !reflect.DeepEqual(eMS.Spec.Template.Spec.Labels, rMS.Spec.Template.Spec.Labels) {
+ 								t.Errorf(""machineset %v machinespec has unexpected labels:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Spec.Template.Spec.Labels, rMS.Spec.Template.Spec.Labels)",Looks like the test had a bug prior to this.
+4900,"@@ -36,7 +36,17 @@ const env = envFromArgs(process.argv);
+ const profilePath = profileFromArgs(process.argv);
+ const isDebugMode = !!process.argv && process.argv.indexOf('--debug') >= 0;
+
+-const wrapper = new ElectronAppWrapper(electronApp, env, profilePath, isDebugMode);
++if (env === 'dev' && process.platform === 'win32') {
++	electronApp.setAsDefaultProtocolClient('joplin', process.execPath, [
++		resolve(process.argv[1])
++	]);
++} else {
++	electronApp.setAsDefaultProtocolClient('joplin');
++}
++
++const initialUrl = process.argv.find((arg) => arg.startsWith('joplin://'));
++
++const wrapper = new ElectronAppWrapper(electronApp, env, profilePath, isDebugMode, initialUrl);
+
+ initBridge(wrapper);
+ ",Should start with joplin://x-callback-url/. Also maybe create a helper function to check if a url is valid?
+4901,"@@ -3,7 +3,7 @@ export default [
+     {
+         created_at: '2015-09-11T09:44:30.805Z',
+         created_by: 1,
+-        id: 1,
++        id: 7,
+         key: 'title',
+         type: 'blog',
+         updated_at: '2015-10-04T16:26:05.195Z',",PR works great. Just out of curiosity: why all the id changes?
+4902,"@@ -56,6 +56,14 @@ struct flb_service_config service_configs[] = {
+      FLB_CONF_TYPE_INT,
+      offsetof(struct flb_config, grace)},
+
++    {FLB_CONF_STR_BACKOFF_BASE,
++     FLB_CONF_TYPE_INT,
++     offsetof(struct flb_config, backoff_base)},
++
++    {FLB_CONF_STR_BACKOFF_CAP,
++     FLB_CONF_TYPE_INT,
++     offsetof(struct flb_config, backoff_cap)},
++
+     {FLB_CONF_STR_DAEMON,
+      FLB_CONF_TYPE_BOOL,
+      offsetof(struct flb_config, daemon)},","config map first value is wrong, it aims to define the ""value type"", that value will lead to an undefined behavior."
+4903,"@@ -13,7 +13,7 @@
+ // limitations under the License.
+
+ // Package fileblob provides a blob implementation that uses the filesystem.
+-// Use OpenBucket to construct a blob.Bucket.
++// Use OpenBucket to construct a *blob.Bucket.
+ //
+ // Blob keys are escaped before being used as filenames, and filenames are
+ // unescaped when they are passed back as blob keys during List. The escape","This doesn't make sense. The thing being constructed is a blob.Bucket. ""Constructing"" the pointer is trivial."
+4904,"@@ -2,7 +2,9 @@
+ # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
+
+ import functools
++import optparse  # pylint: disable=deprecated-module
+
++from pylint.lint import PyLinter
+ from pylint.testutils.checker_test_case import CheckerTestCase
+
+ ",Outch. A configuration/parsing refactor is on the radar but this seems more pressing.
+4905,"@@ -18,7 +18,9 @@ export default Component.extend({
+     stats: null,
+     chartData: null,
+     chartOptions: null,
+-    startDateLabel: '',
++    startDateLabel: computed('membersStats.days', function () {
++        return moment(new Date()).add(-this.membersStats.days + 1, 'days').format(DATE_FORMAT);
++    }),
+
+     selectedRange: computed('membersStats.days', function () {
+         const availableRanges = this.availableRanges;","Unfortunately this won't work when the ""All time"" range is chosen because `memberStats.days` will be `""all-time""` and not a number. What you could do instead is to use `memberStats.stats` as the dependent key and use `Object.keys(memberStats.stats.total_on_date)[0]` to grab the first date in the range and build the label from there."
+4906,"@@ -1,10 +1,11 @@
+ require ""rails_helper""
+
+-feature ""subscriber views video trail"" do
++feature ""user views video trail"" do
+   scenario ""and marks a video as complete"" do
+     trail = create_video_trail
+
+-    sign_in_as_user_with_subscription
++    sign_in
++    click_on I18n.t(""pages.landing.hero_call_to_action"")
+     click_on trail.name
+
+     within trail_steps_list do",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+4907,"@@ -206,7 +206,6 @@ describe('Configure Options', function() {
+       iframe.src = '/test/mock/frames/context.html';
+       iframe.onload = function() {
+         axe.configure(config);
+-        iframe.contentWindow.axe.configure(config);
+
+         axe.run(
+           '#target',","We need this left in as `axe.configure` is for the top-level page `axe` and we still need to configure the axe script inside the iframe as well (so both have to be configured),"
+4908,"@@ -26,6 +26,11 @@ namespace AutoRest.Swagger.Validation
+         /// </summary>
+         public override ValidationCategory ValidationCategory => ValidationCategory.RPCViolation;
+
++        /// <summary>
++        /// What kind of change implementing this rule can cause.
++        /// </summary>
++        public override ValidationChangesImpact ValidationChangesImpact => ValidationChangesImpact.ServiceImpactingChanges;
++
+         public override IEnumerable<ValidationMessage> GetValidationMessages(Dictionary<string, Dictionary<string, Operation>> entity, RuleContext context)
+         {
+             // get all operation objects that are either of get or post type","is this rule serviceimpacting? I'm thinking it's mostly around the modeling of pageable in the swagger, thoughts?"
+4909,"@@ -141,7 +141,7 @@ func (ts *TriggerStatus) MarkDependencyNotConfigured() {
+ 		""DependencyNotConfigured"", ""Dependency has not yet been reconciled."")
+ }
+
+-func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.KResource) {
++func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.Source) {
+ 	kc := ks.Status.GetCondition(apis.ConditionReady)
+ 	if kc == nil {
+ 		ts.MarkDependencyNotConfigured()","same here, replace `ks` and `kc` to something more related to Source."
+4910,"@@ -0,0 +1,19 @@
++using System;
++using System.Collections.Generic;
++using System.Globalization;
++
++namespace MvvmCross.Platform.Converters
++{
++    public class MvxDictionaryValueConverter<TKey, TValue> : MvxValueConverter<TKey, TValue>
++    {
++        protected override TValue Convert(TKey value, Type targetType, object parameter, CultureInfo culture)
++        {
++            if (parameter is Dictionary<TKey, TValue> dict)
++            {
++                TValue x = dict[value];
++                return x;
++            }
++            throw new ArgumentException($""Could not cast {parameter.GetType().Name} to {typeof(Dictionary<TKey, TValue>).Name}"");
++        }
++    }
++}","We should probably ask here if `dict` contains a key with the appropiate value, and leave a trace in case it doesn't, to make it easier to debug for developers."
+4911,"@@ -147,6 +147,11 @@ module Beaker
+                             }
+           } }
+           let(:subcommand_file) {@subcommand_file || {:level => 'fifth'}}
++          let(:homedir_file) {@homedir_file || {:level => 'sixth',
++                                                :ssh => {
++                                                    :auth_methods => 'auth_home_123'
++                                                }
++          }}
+           let(:presets) { {:level => 'lowest',
+                             :ssh => {
+                               :config => 'config123',",this should only be indented 2 spaces
+4912,"@@ -84,7 +84,10 @@ func TestLoadEnvConfig_Creds(t *testing.T) {
+ 				os.Setenv(k, v)
+ 			}
+
+-			cfg := loadEnvConfig()
++			cfg, err := loadEnvConfig()
++			if err != nil {
++				t.Errorf(""failed to load env config, %v"", err)
++			}
+ 			if !reflect.DeepEqual(c.Val, cfg.Creds) {
+ 				t.Errorf(""expect credentials to match.\n%s"",
+ 					awstesting.SprintExpectActual(c.Val, cfg.Creds))","Nit, these Err not nils should be `t.Fatalf` not error. We want to the test to stop if this error occurs."
+4913,"@@ -262,6 +262,10 @@ public class DatasetPage implements java.io.Serializable {
+
+     private Boolean hasRsyncScript = false;
+
++    private Boolean hasTabular = false;
++
++    private Boolean downloadOriginalTracker = false;
++
+     List<ExternalTool> configureTools = new ArrayList<>();
+     List<ExternalTool> exploreTools = new ArrayList<>();
+     Map<Long, List<ExternalTool>> configureToolsByFileId = new HashMap<>();",shouldn't every `Boolean` in this pr be `boolean`?
+4914,"@@ -619,6 +619,14 @@ class WebDriver(object):
+         else:
+             return self.execute(Command.GET_WINDOW_HANDLES)['value']
+
++    def minimize_window(self):
++        """"""
++        Miniimizes the current window that webdriver is using
++        """"""
++        if self.w3c:
++            command = Command.W3C_MINIMIZE_WINDOW
++            self.execute(command, {""windowHandle"": ""current""})
++
+     def maximize_window(self):
+         """"""
+         Maximizes the current window that webdriver is using",This `if` is not necessary
+4915,"@@ -45,5 +45,7 @@ namespace Datadog.Trace.ClrProfiler
+         public const string GenericParameterTask = ""System.Threading.Tasks.Task`1<T>"";
+         public const string ObjectTask = ""System.Threading.Tasks.Task`1<System.Object>"";
+         public const string Int32Task = ""System.Threading.Tasks.Task`1<System.Int32>"";
++
++        public const string HttpConfigurationAction = ""System.Action`1<System.Web.Http.HttpConfiguration>"";
+     }
+ }",Are you using this anywhere? (I couldn't find it.)
+4916,"@@ -250,7 +250,14 @@ func (s *Step) populate(ctx context.Context) dErr {
+ 	return err
+ }
+
++func (s *Step) recordStepTime(startTime time.Time) {
++	endTime := time.Now()
++	s.w.recordStepTime(s.name, startTime, endTime)
++}
++
+ func (s *Step) run(ctx context.Context) dErr {
++	startTime := time.Now()
++	defer s.recordStepTime(startTime)
+ 	impl, err := s.stepImpl()
+ 	if err != nil {
+ 		return s.wrapRunError(err)",Can be inlined
+4917,"@@ -3,6 +3,6 @@ require 'spec_helper'
+ describe Api::V1::CompletionsController, '#show' do
+   it 'returns a 401 when users are not authenticated' do
+     get :index
+-    response.code.should eq '401'
++    expect(response.code).to eq '401'
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+4918,"@@ -1,3 +1,4 @@
++import json
+ import warnings
+
+ import colander",Please use `kinto.core.utils.json`
+4919,"@@ -204,6 +204,16 @@ func (h *Handler) Provision(ctx caddy.Context) error {
+
+ 	// set up upstreams
+ 	for _, upstream := range h.Upstreams {
++		addr, err := caddy.ParseNetworkAddress(upstream.Dial)
++		if err != nil {
++			return err
++		}
++		if addr.PortRangeSize() != 1 {
++			h.logger.Error(""multiple addresses (upstream must map to only one address)"",
++				zap.String(""address"", upstream.Dial),
++			)
++			return fmt.Errorf(""multiple addresses (upstream must map to only one address): %v"", addr)
++		}
+ 		// create or get the host representation for this upstream
+ 		var host Host = new(upstreamHost)
+ 		existingHost, loaded := hosts.LoadOrStore(upstream.String(), host)","Since we're returning the error with the same content, we don't need to log it here; it will get bubbled up and emitted that way."
+4920,"@@ -0,0 +1,11 @@
++""""""Tests for the use of typing.final whenever the py-version is set < 3.8""""""
++# pylint: disable=missing-class-docstring, too-few-public-methods, missing-function-docstring, no-name-in-module
++
++from typing import final
++
++
++@final # [using-final-in-unsupported-version]
++class MyClass:
++    @final # [using-final-in-unsupported-version]
++    def my_method(self):
++        pass",What happens if someone import `typing` and thus uses `@typing.final` instead?
+4921,"@@ -76,7 +76,7 @@ def get_test_dependencies():
+     # Test dependencies exposed as extras, based on:
+     # https://stackoverflow.com/questions/29870629
+     return [
+-        ""pandas"",
++        ""pandas==0.20.0"",
+         ""pytest>=3.1"",
+         ""pytest-cov"",
+         ""pytest-benchmark>=3.1"",",Better remove this dependency altogether
+4922,"@@ -944,4 +944,7 @@ void h2o_cleanup_thread(void)
+     h2o_mem_clear_recycle(&h2o_mem_pool_allocator);
+     h2o_mem_clear_recycle(&h2o_http2_wbuf_buffer_prototype.allocator);
+     h2o_mem_clear_recycle(&h2o_socket_buffer_prototype.allocator);
++
++    extern __thread h2o_buffer_prototype_t h2o__http2client_wbuf_buffer_prototype;
++    h2o_mem_clear_recycle(&h2o__http2client_wbuf_buffer_prototype.allocator);
+ }",Could you please move the declaration to httpclient.h? I think we have a consistent pattern in declaring global variables in header files.
+4923,"@@ -61,11 +61,12 @@ public interface DataFile extends ContentFile<DataFile> {
+       ""Splittable offsets"");
+   Types.NestedField EQUALITY_IDS = optional(135, ""equality_ids"", ListType.ofRequired(136, IntegerType.get()),
+       ""Equality comparison field IDs"");
++  Types.NestedField SORT_ORDER_ID = optional(140, ""sort_order_id"", IntegerType.get(), ""Sort order ID"");
+
+   int PARTITION_ID = 102;
+   String PARTITION_NAME = ""partition"";
+   String PARTITION_DOC = ""Partition data tuple, schema based on the partition spec"";
+-  // NEXT ID TO ASSIGN: 140
++  // NEXT ID TO ASSIGN: 141
+
+   static StructType getType(StructType partitionType) {
+     // IDs start at 100 to leave room for changes to ManifestEntry",We will also need to add this to the spec.
+4924,"@@ -68,15 +68,8 @@ func makeRoundCowState(b roundCowParent, hdr bookkeeping.BlockHeader, prevTimest
+ 		lookupParent: b,
+ 		commitParent: nil,
+ 		proto:        config.Consensus[hdr.CurrentProtocol],
+-		mods: ledgercore.StateDelta{
+-			Accts:         make(map[basics.Address]basics.AccountData),
+-			Txids:         make(map[transactions.Txid]basics.Round),
+-			Txleases:      make(map[ledgercore.Txlease]basics.Round),
+-			Creatables:    make(map[basics.CreatableIndex]ledgercore.ModifiedCreatable),
+-			Hdr:           &hdr,
+-			PrevTimestamp: prevTimestamp,
+-		},
+-		sdeltas: make(map[basics.Address]map[storagePtr]*storageDelta),
++		mods:         ledgercore.MakeStateDelta(&hdr, prevTimestamp),
++		sdeltas:      make(map[basics.Address]map[storagePtr]*storageDelta),
+ 	}
+ }
+ ","In startEvaluator, we have the paysetHint; we should use it to preinitialize the state delta allocation. The number of transactions and the deltas are typically growing in a linear fashion, so preallocating twice as much in the array initializer would be a good idea."
+4925,"@@ -44,6 +44,10 @@ import java.util.List;
+  * </code>
+  */
+ public abstract class By {
++  static {
++    WebDriverException.scheduleIpHostResolving();
++  }
++
+   /**
+    * @param id The value of the ""id"" attribute to search for
+    * @return a By which locates elements by the value of the ""id"" attribute.","we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class."
+4926,"@@ -54,6 +54,10 @@ namespace System.Text.Json.Serialization.Tests
+             await JsonSerializer.SerializeAsync(_memoryStream, _value);
+         }
+
++        [BenchmarkCategory(Categories.CoreFX, Categories.JSON)]
++        [Benchmark]
++        public string SerializeObjectProperty() => JsonSerializer.Serialize(new { Prop = (object)_value });
++
+         [GlobalCleanup]
+         public void Cleanup() => _memoryStream.Dispose();
+     }","Would it be possible to move the creation of the `new { Prop = (object)_value }` out of the benchmark? In the current version, the benchmark includes the cost of creating and serializing the object, while if possible it should be the cost of serialization only."
+4927,"@@ -23,4 +23,6 @@ return [
+     Knp\Bundle\MenuBundle\KnpMenuBundle::class => ['all' => true],
+     Translation\Bundle\TranslationBundle::class => ['all' => true],
+     Symfony\WebpackEncoreBundle\WebpackEncoreBundle::class => ['all' => true],
++    Translation\PlatformAdapter\Loco\Bridge\Symfony\TranslationAdapterLocoBundle::class => ['all' => true],
++    Http\HttplugBundle\HttplugBundle::class => ['all' => true],
+ ];",only dev and local
+4928,"@@ -30,7 +30,7 @@ class DbJobsFailedJobsUpdate extends Migration
+     public function down()
+     {
+         Schema::table($this->getTableName(), function (Blueprint $table) {
+-            $table->tinyInteger('reserved')->unsigned();
++            $table->tinyInteger('reserved')->unsigned()->nullable();
+             $table->dropIndex('jobs_queue_reserved_at_index');
+         });
+ ","This should not be nullable, instead it should be `->default(0);`"
+4929,"@@ -65,8 +65,8 @@ public class IcebergGenerics {
+       return this;
+     }
+
+-    public ScanBuilder select(String... columns) {
+-      this.columns = ImmutableList.copyOf(columns);
++    public ScanBuilder select(String... selectColumns) {
++      this.columns = ImmutableList.copyOf(selectColumns);
+       return this;
+     }
+ ",What about `selectedColumns`? I believe it is frequently used throughout the project.
+4930,"@@ -43,6 +43,7 @@ import org.apache.solr.uninverting.UninvertingReader.Type;
+ public class TextField extends FieldType {
+   protected boolean autoGeneratePhraseQueries;
+   protected boolean enableGraphQueries;
++  protected boolean synonymBoostByPayload;
+   protected SolrQueryParserBase.SynonymQueryStyle synonymQueryStyle;
+
+   /**",I thought we switched the approach from a payload to boost attribute? Besides; it's not clear we need this toggle at all since the user could arrange for this behavior simply by having the new DelimitedBoost filter thing in the chain.
+4931,"@@ -233,15 +233,8 @@ module Unix::Exec
+   def environment_string env
+     return '' if env.empty?
+     env_array = self.environment_variable_string_pair_array( env )
+-
+     environment_string = env_array.join(' ')
+-    command = 'env'
+-    punctuation = ''
+-    if self[:platform] =~ /cisco-5/
+-      command = 'export'
+-      punctuation = ';'
+-    end
+-    ""#{command} #{environment_string}#{punctuation}""
++    ""env #{environment_string}""
+   end
+
+   def environment_variable_string_pair_array env","the previous code used 'export' when platform is cisco-5, presumably because 'env' cannot be used to load variables? I have no idea if that's the case but this env vs export logic is not here"
+4932,"@@ -104,11 +104,15 @@ type CloudInit struct {
+ 	// +optional
+ 	EnableSecureSecretsManager bool `json:""enableSecureSecretsManager,omitempty""`
+
+-	// SecretARN is the Amazon Resource Name of the secret. This is stored
++	// SecretCount is the number of secrets used to form the complete secret
++	// +optional
++	SecretCount int32 `json:""secretCount,omitempty""`
++
++	// SecretPrefix is the prefix for the secret name. This is stored
+ 	// temporarily, and deleted when the machine registers as a node against
+ 	// the workload cluster.
+ 	// +optional
+-	SecretARN string `json:""secretARN,omitempty""`
++	SecretPrefix string `json:""secretPrefix,omitempty""`
+ }
+
+ // AWSMachineStatus defines the observed state of AWSMachine",I'm wondering if we need to add some type of validation here that the SecretCount != 0... Or do we think it would be valid to have a SecretCount of 0?
+4933,"@@ -3752,7 +3752,7 @@ describe('Cursor', function () {
+           db.s.topology,
+           db.s.namespace,
+           {},
+-          { limit: 0, skip: 0, slaveOk: false, readPreference: 42 }
++          { limit: 0, skip: 0, secondaryOk: false, readPreference: 42 }
+         );
+
+         cursor.hasNext(err => {","This test is being skipped. I unskipped it, and it failed in the same way for both `slaveOk: false` and `secondaryOk: false`. I'm not sure how else to test this broken test."
+4934,"@@ -33,6 +33,8 @@ import (
+ // ResponseHeaders.
+ type OutboundCall struct {
+ 	// request attributes to fill if non-nil
++	to              *Identifier
++	from            *Identifier
+ 	headers         []keyValuePair
+ 	shardKey        *string
+ 	routingKey      *string",I don't believe that we need a pointer to an interface for the `to` side of this since we're just assigning a value to the to field.
+4935,"@@ -74,13 +74,18 @@ def later(ms: int, command, win_id):
+
+ @cmdutils.register(maxsplit=1, no_cmd_split=True, no_replace_variables=True)
+ @cmdutils.argument('win_id', win_id=True)
+-def repeat(times: int, command, win_id):
++@cmdutils.argument('count', count=True)
++def repeat(times: int, command, win_id, count=None):
+     """"""Repeat a given command.
+
+     Args:
+         times: How many times to repeat.
+         command: The command to run, with optional args.
+     """"""
++
++    if count is not None:
++        times *= count
++
+     if times < 0:
+         raise cmdexc.CommandError(""A negative count doesn't make sense."")
+     commandrunner = runners.CommandRunner(win_id)",No blank line after the docstring.
+4936,"@@ -17,8 +17,11 @@ package blobvar
+ import (
+ 	""context""
+ 	""errors""
++	""github.com/google/go-cmp/cmp""
++	""io/ioutil""
+ 	""os""
+ 	""path""
++	""path/filepath""
+ 	""testing""
+
+ 	""gocloud.dev/blob""",nit: move this to the group below.
+4937,"@@ -3045,8 +3045,11 @@ short Sort::generateTdb(Generator * generator,
+
+   CostScalar bufferSize = getDefault(GEN_SORT_MAX_BUFFER_SIZE);
+
+-  ULng32 bufferSize_as_ulong =
+-    (ULng32)(MINOF(CostScalar(UINT_MAX), bufferSize)).getValue();
++  UInt32 bufferSize_as_ulong =
++    (UInt32)(MINOF(CostScalar(UINT_MAX), bufferSize)).getValue();
++
++  // allocate buffer to hold atlease one row
++  bufferSize_as_ulong = MAXOF(bufferSize_as_ulong, sortRecLen);
+
+   GenAssert(sortRecLen <= bufferSize_as_ulong,
+       ""Record Len greater than GEN_SORT_MAX_BUFFER_SIZE"");","This is fine, but maybe we should change the variable name to ""bufferSize_as_uint""? Or ""...uint32""?"
+4938,"@@ -57,9 +57,10 @@ module Blacklight::SolrResponse::Spelling
+                 #   origFreq =>
+                 #   suggestion =>  [{ frequency =>, word => }] # for extended results
+                 #   suggestion => ['word'] # for non-extended results
+-                if suggestions.index(""correctlySpelled"")
++                origFreq = term_info['origFreq']
++                if term_info['suggestion'].first.is_a?(Hash) or suggestions.index(""correctlySpelled"")
+                   word_suggestions << term_info['suggestion'].map do |suggestion|
+-                    suggestion['word'] if suggestion['freq'] > term_info['origFreq']
++                    suggestion['word'] if suggestion['freq'] > origFreq
+                   end
+                 else
+                   # only extended suggestions have frequency so we just return all suggestions",Use snake_case for variable names.
+4939,"@@ -1095,7 +1095,7 @@ namespace pwiz.SkylineTestA
+             return count;
+         }
+
+-        [TestMethod]
++        //[TestMethod]
+         public void ConsoleBadRawFileImportTest()
+         {
+             // Run this test only if we can read Thermo's raw files","Obviously, don't merge this to master."
+4940,"@@ -160,6 +160,18 @@ module RSpec::Core
+       end
+     end
+
++    describe ""#exit_early"" do
++      it ""returns the passed exit code"" do
++        expect(reporter.exit_early(42)).to eq(42)
++      end
++
++      it ""reports zero examples"" do
++        allow(reporter).to receive(:report)
++        reporter.exit_early(42)
++        expect(reporter).to have_received(:report).with(0)
++      end
++    end
++
+     describe ""#report"" do
+       it ""supports one arg (count)"" do
+         reporter.report(1) {}","Nearly there! This should assert on the output, take the result of ""start"" and ""finish"" as an example :)"
+4941,"@@ -63,11 +63,11 @@ func NewDriverSub() *driverSub {
+ 	return ds
+ }
+
+-func (s *driverSub) ReceiveBatch(ctx context.Context) ([]*driver.Message, error) {
++func (s *driverSub) ReceiveBatch(ctx context.Context, maxMessages int) ([]*driver.Message, error) {
+ 	for {
+ 		select {
+ 		case <-s.sem:
+-			ms := s.grabQueue()
++			ms := s.grabQueue(maxMessages)
+ 			if len(ms) != 0 {
+ 				return ms, nil
+ 			}",This loop is going to burn CPU if len(s.q) == 0. Maybe a small sleep?
+4942,"@@ -30,7 +30,10 @@ import com.pingcap.tikv.exception.TiClientInternalException;
+ import com.pingcap.tikv.key.Key;
+ import com.pingcap.tikv.util.ConcreteBackOffer;
+ import com.pingcap.tikv.util.Pair;
+-import java.util.*;
++import java.util.ArrayList;
++import java.util.HashMap;
++import java.util.List;
++import java.util.Map;
+ import org.apache.log4j.Logger;
+ import org.tikv.kvproto.Metapb.Peer;
+ import org.tikv.kvproto.Metapb.Store;",can you give a reason why session should be contained in RegionManager?
+4943,"@@ -37,6 +37,16 @@ func TestAuthenticate_WhenSignatureIsCorrect(t *testing.T) {
+ 	assert.Exactly(t, originalSignerID, signerID, ""Original signer should be extracted"")
+ }
+
++func TestAuthenticate_WhenBase64MessageSignatureIsCorrect(t *testing.T) {
++	message := []byte(""MystVpnSessionId:Boop!"")
++	signature := SignatureBase64(""V6ifmvLuAT+hbtLBX/0xm3C0afywxTIdw1HqLmA4onpwmibHbxVhl50Gr3aRUZMqw1WxkfSIVdhpbCluHGBKsgE="")
++
++	extractor := &extractor{}
++	signerID, err := extractor.Extract(message, signature)
++	assert.NoError(t, err)
++	assert.Exactly(t, originalSignerID, signerID, ""Original signer should be extracted"")
++}
++
+ func TestAuthenticate_WhenSignatureIsEmpty(t *testing.T) {
+ 	message := []byte(""Boop!"")
+ 	signature := SignatureHex("""")","You are comparing two signerIDs here, error message should be ""Signers should match"""
+4944,"@@ -57,6 +57,15 @@ type IAMRoleCredentials struct {
+ type TaskIAMRoleCredentials struct {
+ 	ARN                string
+ 	IAMRoleCredentials IAMRoleCredentials
++	lock               sync.RWMutex
++}
++
++// GetIAMRoleCredentials returns the IAM role credentials in the task IAM role struct
++func (role *TaskIAMRoleCredentials) GetIAMRoleCredentials() IAMRoleCredentials {
++	role.lock.RLock()
++	defer role.lock.RUnlock()
++
++	return role.IAMRoleCredentials
+ }
+
+ // GenerateCredentialsEndpointRelativeURI generates the relative URI for the",Who's acquiring this lock for writes?
+4945,"@@ -248,10 +248,10 @@ PublicKey.fromX = function(odd, x) {
+  * @param {String} [compressed] - If the public key is compressed
+  * @returns {null|Error} An error if exists
+  */
+-PublicKey.getValidationError = function(data, compressed) {
++PublicKey.getValidationError = function(data) {
+   var error;
+   try {
+-    new PublicKey(data, compressed);
++    new PublicKey(data);
+   } catch (e) {
+     error = e;
+   }","This throws a linter error, don't use object creation for side effects. I feel like it's kinda messed up that the errors are thrown by the constructor and not that the constructor will throw them"
+4946,"@@ -43,6 +43,18 @@ describe Trail do
+     end
+   end
+
++  describe "".by_topic"" do
++    it ""returns trails sorted by their topic's name"" do
++      create(:trail, topic: create(:topic, name: ""A""))
++      create(:trail, topic: create(:topic, name: ""C""))
++      create(:trail, topic: create(:topic, name: ""B""))
++
++      result = Trail.by_topic.map(&:topic_name)
++
++      expect(result).to eq %w(A B C)
++    end
++  end
++
+   describe "".completed_for"" do
+     it ""shows completed trails for a user"" do
+       _incomplete = create(:trail)",Should there be a `trail.topic_name` method so we don't annoy Demeter?
+4947,"@@ -281,7 +281,7 @@ def _file_to_data_frame(ext, path, target, handler_args):
+
+     return dataframe
+
+-def build_package(username, package, yaml_path, checks_path=None, dry_run=False, env='default'):
++def build_package(team, username, package, yaml_path, checks_path=None, dry_run=False, env='default'):
+     """"""
+     Builds a package from a given Yaml file and installs it locally.
+ ","instead of passing ""None"" it would be more readable to create a constant e.g. TEAM_PUBLIC = None and then call build_package(TEAM_PUBLIC, ...)"
+4948,"@@ -9,6 +9,8 @@ gc_disable();
+ // show all errors
+ error_reporting(-1);
+
++require_once __DIR__ . '/Psalm/Internal/exception_handler.php';
++
+ $valid_short_options = [
+     'h',
+     'v',",Would it make sense to include this file via composer files-autoloading instead?
+4949,"@@ -348,10 +348,12 @@ public class ExpectedConditions {
+                                                                     final String text) {
+
+     return new ExpectedCondition<Boolean>() {
++      private String elementText = null;
++
+       @Override
+       public Boolean apply(WebDriver driver) {
+         try {
+-          String elementText = element.getText();
++          elementText = element.getText();
+           return elementText.contains(text);
+         } catch (StaleElementReferenceException e) {
+           return null;","Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal."
+4950,"@@ -1,9 +1,10 @@
+ package sql_test
+
+ import (
+-	""github.com/influxdata/flux/plan""
+ 	""testing""
+
++	""github.com/influxdata/flux/plan""
++
+ 	""github.com/DATA-DOG/go-sqlmock""
+ 	""github.com/google/go-cmp/cmp""
+ 	""github.com/google/go-cmp/cmp/cmpopts""",Extra newline here. Thanks for moving it under the `testing` import though. This just needs to be grouped with the other imports below it.
+4951,"@@ -71,7 +71,11 @@ public class MimeBodyPart extends BodyPart {
+                 contentType += String.format("";\n name=\""%s\"""", name);
+             }
+             setHeader(MimeHeader.HEADER_CONTENT_TYPE, contentType);
+-            setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""quoted-printable"");
++            if (""8bit"".equals(body.getEncoding())) {
++                setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""8bit"");
++            } else {
++                setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""quoted-printable"");
++            }
+         }
+     }
+ ",Should we ignore case when doing the comparison?
+4952,"@@ -94,6 +94,7 @@ struct wlr_backend *wlr_backend_autocreate(struct wl_display *display) {
+ 		}
+ 	}
+
++#ifdef WLR_HAS_X11_BACKEND
+ 	const char *x11_display = getenv(""DISPLAY"");
+ 	if (x11_display) {
+ 		struct wlr_backend *x11_backend =",The same `ifdef` should apply to `#include <wlr/backend/x11.h>` line 14
+4953,"@@ -183,7 +183,14 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+             catch (Exception ex)
+             {
+                 // profiled app will continue working as expected without this method
+-                Log.ErrorException($""Error resolving {DiagnosticSourceTypeName}.{nameof(BeforeAction)}(...)"", ex);
++                Log.ErrorRetrievingMethod(
++                    exception: ex,
++                    moduleVersionPointer: moduleVersionPtr,
++                    mdToken: mdToken,
++                    opCode: opCode,
++                    instrumentedType: DiagnosticSourceTypeName,
++                    methodName: nameof(BeforeAction),
++                    instanceType: diagnosticSource?.GetType().AssemblyQualifiedName);
+             }
+
+             try","We're instrumenting a static method, so there's no instance in this case. `diagnosticSource` is the first argument."
+4954,"@@ -194,6 +194,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+     private Action action;
+
+     private boolean requestReadReceipt = false;
++    private boolean isHighPriority = false;
+
+     private TextView chooseIdentityButton;
+     private EditText subjectView;","I feel like this belongs in `RecipientPresenter` (which should really be `MetadataPresenter`), but I suppose having it next to requestReadReceipt makes sense as well. feel free to leave as is."
+4955,"@@ -1,6 +1,6 @@
+ Summary:        Open Programmable Acceleration Engine (OPAE) SDK
+ Name:           opae
+-Version:        1.4.0
++Version:        1.4.1
+ Release:        1%{?dist}
+ License:        BSD
+ ExclusiveArch:  x86_64",Let's go back to 1.4.0 until the release is being prepared.
+4956,"@@ -7337,6 +7337,7 @@ pre_system_call(dcontext_t *dcontext)
+              size_t sigsetsize)
+          */
+         /* we also need access to the params in post_system_call */
++        uint errno_val = 0;
+         dcontext->sys_param0 = sys_param(dcontext, 0);
+         dcontext->sys_param1 = sys_param(dcontext, 1);
+         dcontext->sys_param2 = sys_param(dcontext, 2);","I would avoid the term ""errno"" as it implies the glibc variable. Use error_code or status or something."
+4957,"@@ -69,7 +69,7 @@ func (i *inbound) Channel() *tchannel.Channel {
+ 	return i.ch
+ }
+
+-func (i *inbound) Start(h transport.Handler) error {
++func (i *inbound) Start(h transport.Handler, d transport.Dependencies) error {
+ 	sc := i.ch.GetSubChannel(i.ch.ServiceName())
+ 	existing := sc.GetHandlers()
+ 	sc.SetHandler(handler{existing, h})",@abhinav @kriskowal what do you think about putting the handler on `d`?
+4958,"@@ -91,7 +91,7 @@ type BackupOptions struct {
+ 	ExcludeLargerThan       string
+ 	Stdin                   bool
+ 	StdinFilename           string
+-	Tags                    []string
++	Tags                    restic.TagList
+ 	Host                    string
+ 	FilesFrom               []string
+ 	TimeStamp               string",Why `restic.TagLists` and no `restic.TagList` ? Because I'm using `restic.TagList` here and using `restic.TagLists` is a lot of changes
+4959,"@@ -50,6 +50,8 @@ func TestWait(t *testing.T) {
+ 				cancel()
+ 				return ctx
+ 			}(),
++			// Ensure the timer and context do not end simultaneously.
++			delay:    1 * time.Hour,
+ 			expected: context.Canceled,
+ 		},
+ 	}","An hour seems a significant amount of time to wait for within a test, does it need to be that long?"
+4960,"@@ -204,7 +204,7 @@ func (d *RPCFactory) CreateFrontendGRPCConnection(hostName string) *grpc.ClientC
+ 		}
+ 	}
+
+-	return d.dial(hostName, tlsClientConfig)
++	return d.dial(hostName, tlsClientConfig, false)
+ }
+
+ // CreateInternodeGRPCConnection creates connection for gRPC calls","Nit: (newish to golang, don't hesitate to tell me I'm wrong here, but ...) I'd have written this code, just for readability: keepAlive := false return d.dial(hostName, tlsClientConfig, keepAlive) ... or even return d.dial(hostName, tlsClientConfig, false) // keepAlive=false Personally I think Golang should have included named args; I think it's one of the things python got right."
+4961,"@@ -13,6 +13,7 @@ namespace Datadog.Trace.Configuration
+         AspNetMvc,
+         AspNetWebApi2,
+         GraphQL,
++        Msmq,
+         MongoDb,
+         XUnit,
+         NUnit,","I don't think it would cause any version conflict, but I'd feel safer if you declared it last, so that the numerical id of the existing integrations don't change"
+4962,"@@ -135,6 +135,9 @@ func (c *certificateRequestManager) updateCertificateStatus(ctx context.Context,
+ 		ready = cmmeta.ConditionTrue
+ 		reason = ""Ready""
+ 		message = ""Certificate is up to date and has not expired""
++	case apiutil.CertificateRequestHasInvalidRequest(req):
++		reason = ""InvalidRequest""
++		message = fmt.Sprintf(""The CertificateRequest %q is an invalid request"", req.Name)
+ 	case req != nil:
+ 		reason = ""InProgress""
+ 		message = fmt.Sprintf(""Waiting for CertificateRequest %q to complete"", req.Name)","Can we provide some more useful actionable info here? `fmt.Sprintf(""The certificate request could not be completed due to invalid request options: %s"", req.Status.Conditions[InvalidRequestCondition].Message)`"
+4963,"@@ -155,6 +155,7 @@ var (
+ 		API: API{
+ 			UseRDS:    false,
+ 			Port:      14014,
++			Web3Port:  15014, // TODO: port 15014 is used for testing
+ 			TpsWindow: 10,
+ 			GasStation: GasStation{
+ 				SuggestBlockWindow: 20,","yeah, can change to 8545"
+4964,"@@ -16,6 +16,11 @@ use Ergonode\BatchAction\Domain\Entity\BatchActionId;
+ use Ergonode\SharedKernel\Domain\AggregateId;
+ use Symfony\Component\Messenger\Stamp\HandledStamp;
+ use Ergonode\BatchAction\Domain\Repository\BatchActionRepositoryInterface;
++use Ergonode\Core\Application\Security\User\CachedUser;
++use Ergonode\Account\Domain\Repository\UserRepositoryInterface;
++use Ergonode\SharedKernel\Domain\Aggregate\UserId;
++use Ergonode\BatchAction\Domain\Event\BatchActionEndedEvent;
++use Ergonode\Core\Application\Messenger\Stamp\UserStamp;
+
+ class BatchActionTransport implements TransportInterface
+ {",As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense
+4965,"@@ -16,9 +16,14 @@
+
+ package io.servicecomb.transport.rest.vertx;
+
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
++import org.springframework.stereotype.Component;
++
+ import io.servicecomb.core.Const;
+ import io.servicecomb.core.Invocation;
+ import io.servicecomb.core.transport.AbstractTransport;
++import io.servicecomb.foundation.common.net.NetUtils;
+ import io.servicecomb.foundation.common.net.URIEndpointObject;
+ import io.servicecomb.foundation.vertx.SimpleJsonObject;
+ import io.servicecomb.foundation.vertx.VertxUtils;",What's the meaning of null URIEndpointObject?
+4966,"@@ -4,14 +4,17 @@ import os
+ import sys
+ import logging
+ import logging.config
+-from six.moves import input, configparser
++
+ from kinto.core import scripts
+ from pyramid.scripts import pserve
+ from pyramid.paster import bootstrap
+ from kinto import __version__
+ from kinto.config import init
+
+-CONFIG_FILE = 'config/kinto.ini'
++DEFAULT_CONFIG_FILE = 'config/kinto.ini'
++DEFAULT_PORT = 8888
++DEFAULT_LOG_LEVEL = logging.INFO
++DEFAULT_LOG_FORMAT = ""%(levelname)-5.5s  %(message)s""
+
+
+ def main(args=None):",Why did you remove the time? It can be useful if some actions are ran in jobs?
+4967,"@@ -32,7 +32,7 @@ import (
+ 	""github.com/ncw/rclone/lib/pacer""
+ 	""github.com/ncw/rclone/lib/readers""
+ 	""github.com/pkg/errors""
+-	mega ""github.com/t3rm1n4l/go-mega""
++	""github.com/t3rm1n4l/go-mega""
+ )
+
+ const (",File is not `goimports`-ed (from `goimports`)
+4968,"@@ -7,12 +7,12 @@ import (
+ 	""math/big""
+ 	""strings""
+
+-	ethereum ""github.com/sonm-io/go-ethereum""
+-	""github.com/sonm-io/go-ethereum/accounts/abi""
+-	""github.com/sonm-io/go-ethereum/accounts/abi/bind""
+-	""github.com/sonm-io/go-ethereum/common""
+-	""github.com/sonm-io/go-ethereum/core/types""
+-	""github.com/sonm-io/go-ethereum/event""
++	ethereum ""github.com/ethereum/go-ethereum""
++	""github.com/ethereum/go-ethereum/accounts/abi""
++	""github.com/ethereum/go-ethereum/accounts/abi/bind""
++	""github.com/ethereum/go-ethereum/common""
++	""github.com/ethereum/go-ethereum/core/types""
++	""github.com/ethereum/go-ethereum/event""
+ )
+
+ // BasicTokenABI is the input ABI used to generate the binding from.",What the reason to change imports?
+4969,"@@ -83,6 +83,15 @@ public class HiveClientPool extends ClientPool<HiveMetaStoreClient, TException>
+     return client;
+   }
+
++  @Override
++  protected boolean failureDetection(Exception e) {
++    if (super.failureDetection(e) || (e != null && e instanceof MetaException &&
++            e.getMessage().contains(""Got exception: org.apache.thrift.transport.TTransportException""))) {
++      return true;
++    }
++    return false;
++  }
++
+   @Override
+   protected void close(HiveMetaStoreClient client) {
+     client.close();",Nit: continuation indents are 2 indents / 4 spaces.
+4970,"@@ -666,10 +666,15 @@ class JMX(object):
+             parsed_url = parse.urlsplit(default_address)
+             if parsed_url.scheme:
+                 cfg.append(JMX._string_prop(""HTTPSampler.protocol"", parsed_url.scheme))
+-            if parsed_url.hostname:
+-                cfg.append(JMX._string_prop(""HTTPSampler.domain"", parsed_url.hostname))
+-            if parsed_url.port:
+-                cfg.append(JMX._string_prop(""HTTPSampler.port"", parsed_url.port))
++
++            if parsed_url.netloc:
++                netloc = parsed_url.netloc
++                if ':' in netloc:
++                    index = netloc.rfind(':')
++                    cfg.append(JMX._string_prop(""HTTPSampler.port"", netloc[index+1:]))
++                    netloc = netloc[:index]
++
++                cfg.append(JMX._string_prop(""HTTPSampler.domain"", netloc))
+
+         if timeout:
+             cfg.append(JMX._string_prop(""HTTPSampler.connect_timeout"", timeout))","You can use `netloc.rsplit("":"")` for that."
+4971,"@@ -143,7 +143,7 @@ func (w *watcher) run(ctx context.Context, repo git.Repo, repoCfg *config.PipedR
+ 				continue
+ 			}
+ 			if !ok {
+-				w.logger.Error(""configuration file for Image Watcher not found"",
++				w.logger.Info(""configuration file for Image Watcher not found"",
+ 					zap.String(""repo-id"", repoCfg.RepoID),
+ 					zap.Error(err),
+ 				)","nits, I don't get the point of this change  "
+4972,"@@ -0,0 +1,13 @@
++// +build !windows
++
++// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++// SPDX-License-Identifier: Apache-2.0
++
++package log
++
++// Log message prefixes.
++const (
++	successPrefix = ""✔ Success!""
++	errorPrefix   = ""✘ Error!""
++	warningPrefix = ""Note:""
++)","`warningPrefix` looks the same on both platforms, we could move it up to `log.go`."
+4973,"@@ -65,10 +65,10 @@ type Config struct {
+ 	Inbounds  Inbounds
+ 	Outbounds Outbounds
+
+-	// Filter and Interceptor that will be applied to all outgoing and incoming
+-	// requests respectively.
+-	Filter      transport.Filter
+-	Interceptor transport.Interceptor
++	// Filters and Interceptors that will be applied to all outgoing and
++	// incoming requests respectively.
++	Filters      Filters
++	Interceptors Interceptors
+
+ 	Tracer opentracing.Tracer
+ }",What's the motivation behind switching to plural here? I think we want singular cc @abhinav
+4974,"@@ -26,6 +26,19 @@ import (
+ 	""fmt""
+ )
+
++// Wrap returns a new Status that wraps the original error.
++//
++// The Code should never be CodeOK, if it is, this will return nil.
++func Wrap(code Code, err error) *Status {
++	if code == CodeOK {
++		return nil
++	}
++	return &Status{
++		code: code,
++		err:  &wrapError{err: err},
++	}
++}
++
+ // Newf returns a new Status.
+ //
+ // The Code should never be CodeOK, if it is, this will return nil.","What do you think about renaming this method `FromErrorAndCode(code Code, err error) *Status`? One of the benefits is that it will be consistent with the naming of `func FromError(err error) *Status {` which does something almost similar."
+4975,"@@ -35,7 +35,7 @@ namespace Nethermind.JsonRpc
+         [ConfigItem(Description = ""Port number for JSON RPC calls. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = ""8545"")]
+         int Port { get; set; }
+
+-        [ConfigItem(Description = ""Port number for JSON RPC web socket calls. By default same port is used as regular JSON RPC. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = null)]
++        [ConfigItem(Description = ""Port number for JSON RPC web socket calls. By default same port is used as regular JSON RPC. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = ""8545"")]
+         int WebSocketPort { get; set; }
+
+         [ConfigItem(Description = ""Defines which RPC modules should be enabled."", DefaultValue = ""all"")]",we cannot state that by default the same value is used if we stopped using null - it would suggest that when you change JSON RPC and leave WS port default then they would be same.
+4976,"@@ -142,7 +142,7 @@ func chromeTestImpl(version protocol.VersionNumber, url string, blockUntilDone f
+ 	}
+ 	utils.Infof(""Running chrome: %s '%s'"", getChromePath(), strings.Join(args, ""' '""))
+ 	command := exec.Command(path, args...)
+-	session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter)
++	session, err := gexec.Start(command, nil, nil)
+ 	Expect(err).NotTo(HaveOccurred())
+ 	defer session.Kill()
+ 	const pollInterval = 100 * time.Millisecond","I'm still not convinced dropping Chrome logs is the right thing to do, but if you insist "
+4977,"@@ -38,7 +38,7 @@ public class ReflectionParameterDeclaration implements ParameterDeclaration {
+
+     @Override
+     public String getName() {
+-        throw new UnsupportedOperationException();
++        throw new UnsupportedOperationException(""Unable to get the name"");
+     }
+
+     @Override","It would be helpful to include some reasoning here. With the reflection model, it is often the case that names are not available."
+4978,"@@ -82,6 +82,7 @@ func Run() {
+ 	certmagic.UserAgent = appName + ""/"" + appVersion
+
+ 	// Set up process log before anything bad happens
++	caddy.LogDestination = logfile
+ 	switch logfile {
+ 	case ""stdout"":
+ 		log.SetOutput(os.Stdout)","Instead of setting this here, why not have the flag call in the init function set `caddy.LogDestination` directly, and switch on that?"
+4979,"@@ -20,6 +20,7 @@
+  * External dependencies
+  */
+ import { get } from 'lodash';
++import { __ } from '@wordpress/i18n';
+
+ /**
+  * Formats a number using the JS Internationalization Number Format API.","This belongs under ""WordPress dependencies""."
+4980,"@@ -4,6 +4,8 @@ using Datadog.Trace.TestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+
++#if !NET452
++
+ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+ {
+     public class Elasticsearch5Tests : TestHelper",Was there an issue on `net452`?
+4981,"@@ -201,12 +201,17 @@ namespace Microsoft.Cci.Writers.CSharp
+
+             WriteOutParameterInitializations(method);
+
+-            if (_forCompilationThrowPlatformNotSupported)
++            if (_platformNotSupportedExceptionMessage != null)
+             {
+                 Write(""throw new "");
+                 if (_forCompilationIncludeGlobalprefix)
+                     Write(""global::"");
+-                Write(""System.PlatformNotSupportedException(); "");
++                if(_platformNotSupportedExceptionMessage.Equals(""Default""))
++                    Write(""System.PlatformNotSupportedException();"");
++                else if(_platformNotSupportedExceptionMessage.StartsWith(""SR.""))
++                    Write($""System.PlatformNotSupportedException({_platformNotSupportedExceptionMessage}); "");
++                else
++                    Write($""System.PlatformNotSupportedException(\""{_platformNotSupportedExceptionMessage}\""); "");
+             }
+             else if (method.ContainingTypeDefinition.IsValueType && method.IsConstructor)
+             {",Another option is to always write it without quotes. I always have to use SR. And why not?
+4982,"@@ -1,7 +1,7 @@
+ import PropTypes from 'prop-types'
++import deepmerge from 'deepmerge' // < 1kb payload overhead when lodash/merge is > 3kb.
+
+-export const defaultBreakpoints = [40, 52, 64].map(n => n + 'em')
+-
++// PropTypes
+ export const propType = PropTypes.oneOfType([
+   PropTypes.number,
+   PropTypes.string,",This should use the `merge` function added in #473 instead of introducing a new dependency
+4983,"@@ -14480,6 +14480,16 @@ bool CoreChecks::ValidateDescriptorUpdateTemplate(const char *func_name,
+                                  func_name, pd_set, report_data->FormatHandle(pCreateInfo->pipelineLayout).c_str());
+             }
+         }
++    } else if (VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET == pCreateInfo->templateType) {
++        for (const auto &binding : layout->GetBindings()) {
++            if (binding.descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
++                skip |= LogError(
++                    device, ""VUID-VkDescriptorUpdateTemplateCreateInfo-templateType-04615"",
++                    ""%s: pCreateInfo->templateType is VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET, but ""
++                    ""pCreateInfo->descriptorSetLayout contains a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE."",
++                    func_name);
++            }
++        }
+     }
+     for (uint32_t i = 0; i < pCreateInfo->descriptorUpdateEntryCount; ++i) {
+         const auto &descriptor_update = pCreateInfo->pDescriptorUpdateEntries[i];","Shouldn't this say ""a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE"""
+4984,"@@ -12,6 +12,8 @@
+ #include <wlr/types/wlr_tablet_v2.h>
+ #include <wlr/util/log.h>
+
++static const struct wlr_tablet_tool_v2_grab_interface default_tool_interface;
++
+ static const struct wlr_surface_role tablet_tool_cursor_surface_role = {
+ 	.name = ""wp_tablet_tool-cursor"",
+ };",This variable name should probably contain `grab`
+4985,"@@ -0,0 +1,10 @@
++# frozen_string_literal: true
++
++# These configuration settings are used to communicate with the
++# Open Aire Research Project Registry API. For more information about
++# the API and to verify that your configuration settings are correct,
++Rails.configuration.x.open_aire.api_base_url = ""https://api.openaire.eu/""
++# The api_url should contain `%s. This is where the funder is appended!
++Rails.configuration.x.open_aire.search_path = ""projects/dspace/%s/ALL/ALL""
++Rails.configuration.x.open_aire.default_funder = ""H2020""
++Rails.configuration.x.open_aire.active = true",Which initializer should we be using for open_aire? The one in `external_apis` or this one in `initializers`?
+4986,"@@ -8,6 +8,7 @@ import (
+
+ 	inet ""gx/ipfs/QmNgLg1NTw37iWbYPKcyK85YJ9Whs1MkPtJwhfqbNYAyKg/go-libp2p-net""
+ 	pstore ""gx/ipfs/QmPiemjiKBC9VA7vZF82m4x1oygtg2c2YVqag8PX7dN1BD/go-libp2p-peerstore""
++	routing ""gx/ipfs/QmTiRqrF5zkdZyrdsL5qndG1UbeWi8k8N2pYxCtXWrahR2/go-libp2p-routing""
+ 	peer ""gx/ipfs/QmY5Grm8pJdiSSVsYxx4uNRgweY72EmYwuSDbRnbFok3iY/go-libp2p-peer""
+ 	host ""gx/ipfs/QmaoXrM4Z41PD48JY36YqQGKQpLGjyLA2cKcLsES7YddAq/go-libp2p-host""
+ 	logging ""gx/ipfs/QmcuXC5cxs79ro2cUuHs4HQ2bkDLJUYokwL8aivcX6HW3C/go-log""",remove todo on line 28?
+4987,"@@ -0,0 +1,17 @@
++_base_ = [
++    '../_base_/models/retinanet_r50_fpn.py', '../common/mstrain_3x_coco.py'
++]
++# optimizer
++model = dict(
++    pretrained='open-mmlab://resnext101_64x4d',
++    backbone=dict(
++        type='ResNeXt',
++        depth=101,
++        groups=64,
++        base_width=4,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        style='pytorch'))
++optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)",clean unnecessary arguments.
+4988,"@@ -30,6 +30,8 @@ public enum Status {
+   SUCCEEDED(50),
+   KILLING(55),
+   KILLED(60),
++  // EXECUTION_STOPPED refers to a terminal flow status due to crashed executor/container
++  EXECUTION_STOPPED(65),
+   FAILED(70),
+   FAILED_FINISHING(80),
+   SKIPPED(90),",Could the name of the status be confusing to users? It says the execution stopped but is it a temporary stop? Will it continue to run at some point? To me the name does not suggest a final status but a transition one. WDYT @sshardool @jakhani @djaiswal83 @aditya1105
+4989,"@@ -20,7 +20,8 @@
+
+ import testtools
+
+-import molecule.provisioners as provisioners
++from molecule.Provisioners import DockerProvisioner
++import molecule.utilities
+ from molecule.core import Molecule
+ import yaml
+ from molecule.ansible_playbook import AnsiblePlaybook","Since we created a Provisioners directory, can we do the same with the tests, and follow the same structure as the code?"
+4990,"@@ -16,11 +16,12 @@ import (
+ )
+
+ var (
+-	sentryAddr    string // Address of the sentry <host>:<port>
+-	coreAddr      string // Address of the core <host>:<port>
+-	chaindata     string // Path to chaindata
+-	database      string // Type of database (lmdb or mdbx)
+-	mapSizeStr    string // Map size for LMDB
++	sentryAddr    string   // Address of the sentry <host>:<port>
++	sentryAddrs   []string // Address of the sentry <host>:<port>
++	coreAddr      string   // Address of the core <host>:<port>
++	chaindata     string   // Path to chaindata
++	database      string   // Type of database (lmdb or mdbx)
++	mapSizeStr    string   // Map size for LMDB
+ 	freelistReuse int
+ )
+ ",We don't need that one anymore?
+4991,"@@ -40,6 +40,7 @@ from graphite.render.attime import parseATTime
+ from graphite.render.functions import PieFunctions
+ from graphite.render.hashing import hashRequest, hashData
+ from graphite.render.glyph import GraphTypes
++from graphite.storage import STORE
+
+ from django.http import HttpResponse, HttpResponseServerError, HttpResponseRedirect
+ from django.template import Context, loader","Since we're determining the local node's host info in the `Store()` init, we need to import the `STORE` object here. Is this OK, or should I be determining the host info earlier. (When parsing settings?)"
+4992,"@@ -15,7 +15,7 @@ public interface ASTAnyTypeBodyDeclaration extends JavaNode {
+     /**
+      * Returns the child of this declaration,
+      * which can be cast to a more specific node
+-     * type using {@link #getKind()} as a cue.
++     * type using #getKind() as a cue.
+      *
+      * <p>Returns null if this is an empty declaration,
+      * that is, a single semicolon.","I think, there is no `#getKind()` method anymore, is it? The approach would now be testing with instanceof. Or could we return a more specific type than JavaNode now?"
+4993,"@@ -60,6 +60,15 @@ module.exports = (props) => {
+           title: props.title
+         })}
+       </div>
++      <button class=""UppyButton--circular UppyButton--blue Browser-doneBtn""
++              type=""button""
++              aria-label=""Done picking files""
++              title=""Done picking files""
++              onclick=${props.done}>
++        <svg aria-hidden=""true"" class=""UppyIcon"" width=""13px"" height=""9px"" viewBox=""0 0 13 9"">
++          <polygon points=""5 7.293 1.354 3.647 0.646 4.354 5 8.707 12.354 1.354 11.646 0.647"" />
++        </svg>
++      </button>
+     </div>
+   `
+ }",can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`
+4994,"@@ -94,3 +94,14 @@ const (
+ 	NFC1_PIN          Pin = 9
+ 	NFC2_PIN          Pin = 10
+ )
++
++// USB CDC identifiers
++const (
++	usb_STRING_PRODUCT      = ""Particle Argon""
++	usb_STRING_MANUFACTURER = ""Particle""
++)
++
++var (
++	usb_VID uint16 = 0x239A
++	usb_PID uint16 = 0x8029
++)",This is the VID from Adafruit. Doesn't Particle have a different VID? (CC @suda).
+4995,"@@ -97,8 +97,7 @@ static void parseBlock (lexerState *lexer, bool delim, int kind, vString *scope)
+ /* Resets the scope string to the old length */
+ static void resetScope (vString *scope, size_t old_len)
+ {
+-	scope->length = old_len;
+-	scope->buffer[old_len] = '\0';
++	vStringTruncate (scope, old_len);
+ }
+
+ /* Adds a name to the end of the scope string */","The function is only used once, and this body is now only 1 call with the same args (e.g. basically an alias for `vStringTruncate`), it could probably be simply removed. But if you wanna keep the naming for clarity, it also sounds reasonable."
+4996,"@@ -176,8 +176,8 @@ func (k *Kad) manage() {
+ 							k.logger.Debugf(""could not remove peer from addressbook: %s"", peer.String())
+ 						}
+ 					}
+-					k.logger.Debugf(""error connecting to peer from kademlia %s: %v"", bzzAddr.String(), err)
+-					k.logger.Warningf(""connecting to peer %s: %v"", bzzAddr.ShortString(), err)
++					k.logger.Debugf(""could not connect to peer from kademlia %s: %v"", bzzAddr.String(), err)
++					k.logger.Warningf(""could not connect to peer from kademlia %s: %v"", bzzAddr.ShortString(), err)
+ 					// continue to next
+ 					return false, false, nil
+ 				}","please change to `could not connect to peer: %s`. it is not relevant to say ""from kademlia"" in a warning"
+4997,"@@ -103,8 +103,13 @@ StatusOr<DataSet> SubmitJobExecutor::buildResult(meta::cpp2::AdminJobOp jobOp,
+ }
+
+ Value SubmitJobExecutor::convertJobTimestampToDateTime(int64_t timestamp) {
+-  return timestamp > 0 ? Value(time::TimeConversion::unixSecondsToDateTime(timestamp))
+-                       : Value::kEmpty;
++  if (timestamp <= 0) {
++    return Value::kEmpty;
++  }
++
++  DateTime date = time::TimeConversion::unixSecondsToDateTime(timestamp);
++
++  return time::TimeUtils::rmDateTimeStrMs(date.toString());
+ }
+
+ nebula::DataSet SubmitJobExecutor::buildShowResultData(",Why need to remove this? Datetime has microseconds in fact.
+4998,"@@ -105,7 +105,12 @@ func PrivateKeyBytes(key crypto.PrivateKey) []byte {
+ 	case *rsa.PrivateKey:
+ 		keyBytes = x509.MarshalPKCS1PrivateKey(key)
+ 	case *ecdsa.PrivateKey:
+-		keyBytes, _ = x509.MarshalECPrivateKey(key)
++		var err error
++		var t *testing.T
++		keyBytes, err = x509.MarshalECPrivateKey(key)
++		if err != nil {
++			t.Error(err)
++		}
+ 	}
+ 	return keyBytes
+ }","What's up with this, isn't it nil? Why not use the real T value from the test function? @elcore @wmark"
+4999,"@@ -34,7 +34,9 @@ class TCallableObject extends TObject
+         return false;
+     }
+
+-    public function getAssertionString(bool $exact = false): string
++    public function getAssertionString()
++
++    /** @psalm-mutation-free */: string
+     {
+         return 'object';
+     }",this feels weird
+5000,"@@ -21,6 +21,7 @@ public enum NetworkName {
+   SEPOLIA,
+   GOERLI,
+   DEV,
++  PREMERGE,
+   CLASSIC,
+   KOTTI,
+   MORDOR,",I don't think this is the type of network we should be putting in our named networks.
+5001,"@@ -60,7 +60,15 @@ void generic_data_reader::setup() {
+   shuffle_indices();
+ }
+
++std::ofstream debug;
++
+ int lbann::generic_data_reader::fetch_data(CPUMat& X) {
++if (! debug.is_open()) {
++  char b[1024];
++  sprintf(b, ""debug.%d"", m_comm->get_rank_in_world());
++  debug.open(b);
++}
++if (get_role() == ""train"") debug << ""\nstarting fetch_data "";
+   int nthreads = omp_get_max_threads();
+   if(!position_valid()) {
+     throw lbann_exception(",debug? I suspect this will be removed before merge?
+5002,"@@ -42,7 +42,12 @@ describe('Operation (Generators)', function() {
+         // LINE   test = require('assert');
+         // LINE
+         // LINE co(function*() {
+-        // LINE   var client = yield MongoClient.connect('mongodb://localhost:27017/test');
++        // LINE   const client = new MongoClient('mongodb://localhost:27017/test');
++        // LINE   yield client.connect();
++        // LINE
++        // LINE   const client = new MongoClient('mongodb://localhost:27017/test');
++        // LINE   yield client.connect();
++        // LINE
+         // LINE   var db = client.db('test');
+         // REPLACE configuration.writeConcernMax() WITH {w:1}
+         // BEGIN",should this be here twice?
+5003,"@@ -46,8 +46,13 @@ public:
+         width_ = GENERATE(16, 128, 1024);
+         stride_ = GENERATE(16, 128, 1024);
+         height_ = GENERATE(16, 128, 1024, 16384, 32768);
+-        SKIP_IF(width_ > stride_);
+-        REQUIRE(width_ <= stride_);
++        CAPTURE(width_, stride_, height_);
++    }
++
++    void generate_special() {
++        width_ = GENERATE(28, 960, 2000, 3072);
++        height_ = GENERATE(1024, 4096);
++        stride_ = height_;
+         CAPTURE(width_, stride_, height_);
+     }
+ ",`generate_special` - a meaningless name for me. Can we provide more detailed naming?
+5004,"@@ -61,8 +61,8 @@ feature 'Subscriber views subscription invoices' do
+     @current_user.stripe_customer_id = ""cus_NOMATCH""
+     @current_user.save!
+
+-    visit subscriber_invoice_path(""in_1s4JSgbcUaElzU"")
+-
+-    expect(page).to have_content 'ActiveRecord::RecordNotFound'
++    expect {
++      visit subscriber_invoice_path(""in_1s4JSgbcUaElzU"")
++    }.to raise_error ActiveRecord::RecordNotFound
+   end
+ end","This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration."
+5005,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.
+5006,"@@ -139,7 +139,7 @@ public class BaseRemoteProxy implements RemoteProxy {
+       this.id = id;
+     } else {
+       // otherwise assign the remote host as id.
+-      this.id = remoteHost.toExternalForm();
++      this.id = id = ""http://"" + remoteHost.getHost() + "":"" + remoteHost.getPort();
+     }
+
+     maxConcurrentSession = getConfigInteger(RegistrationRequest.MAX_SESSION);",any reason you're assigning to the local variable 'id' too?
+5007,"@@ -28,6 +28,7 @@ import sys
+ import termios
+ from subprocess import CalledProcessError
+
++import molecule.validators as validators
+ import prettytable
+ import sh
+ import vagrant",Need to fix this import :)
+5008,"@@ -46,12 +46,14 @@ func TestBlockGenerator_GenerateBehavior(t *testing.T) {
+ 		Height:    uint64(100),
+ 		StateRoot: newCid(),
+ 	}
++	accountActor := &types.Actor{Code: types.AccountActorCodeCid}
+
+ 	// With no messages.
+ 	nextStateRoot := newCid()
+ 	mpb, mst := &MockProcessBlock{}, &types.MockStateTree{}
+ 	mpb.On(""ProcessBlock"", context.Background(), mock.AnythingOfType(""*types.Block""), mst).Return([]*types.MessageReceipt{}, nil)
+ 	mst.On(""Flush"", context.Background()).Return(nextStateRoot, nil)
++	mst.On(""GetActor"", context.Background(), mock.AnythingOfType(""types.Address"")).Return(accountActor, nil)
+ 	successfulGetStateTree := func(c context.Context, stateRootCid *cid.Cid) (types.StateTree, error) {
+ 		assert.True(stateRootCid.Equals(baseBlock.StateRoot))
+ 		return mst, nil",sorry these tests suck so much we are working to kill them
+5009,"@@ -701,7 +701,7 @@ import 'emby-ratingbutton';
+
+         const player = this;
+         currentRuntimeTicks = playbackManager.duration(player);
+-        updateTimeDisplay(playbackManager.currentTime(player), currentRuntimeTicks, playbackManager.getBufferedRanges(player));
++        updateTimeDisplay(playbackManager.currentTime(player) * 10000, currentRuntimeTicks, playbackManager.getBufferedRanges(player));
+     }
+
+     function releaseCurrentPlayer() {",Why not adjust `currentTime` to be in ms directly?
+5010,"@@ -3697,7 +3697,8 @@ instr_is_reg_spill_or_restore_ex(void *drcontext, instr_t *instr, bool DR_only,
+     if (reg == NULL)
+         reg = &myreg;
+     if (instr_check_tls_spill_restore(instr, spill, reg, &check_disp)) {
+-        if (!DR_only ||
++        /* We do not want to count an mcontext base load as a reg spill/restore. */
++        if ((!DR_only && check_disp != os_tls_offset((ushort)TLS_DCONTEXT_SLOT)) ||
+             (reg_spill_tls_offs(*reg) != -1 &&
+              /* Mangling may choose to spill registers to a not natural tls offset,
+               * e.g. rip-rel mangling will, if rax is used by the instruction. We","> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`."
+5011,"@@ -89,12 +89,10 @@ var (
+ 		Chain: Chain{
+ 			ChainDBPath:                  ""/tmp/chain.db"",
+ 			TrieDBPath:                   ""/tmp/trie.db"",
+-			UseBadgerDB:                  false,
+ 			ID:                           1,
+ 			Address:                      """",
+ 			ProducerPubKey:               keypair.EncodePublicKey(keypair.ZeroPublicKey),
+ 			ProducerPrivKey:              keypair.EncodePrivateKey(keypair.ZeroPrivateKey),
+-			InMemTest:                    false,
+ 			GenesisActionsPath:           """",
+ 			EmptyGenesis:                 false,
+ 			NumCandidates:                101,",this flag not used
+5012,"@@ -625,7 +625,9 @@ class Folio extends AbstractAPI implements
+             'zip' => $profile->personal->addresses[0]->postalCode ?? null,
+             'phone' => $profile->personal->phone ?? null,
+             'mobile_phone' => $profile->personal->mobilePhone ?? null,
+-            'expiration_date' => $profile->expirationDate ?? null,
++            'expiration_date' => $this->dateConverter->convertToDisplayDate(
++                ""Y-m-d H:i"", $profile->expirationDate
++            ) ?? null,
+         ];
+     }
+ ","I don't think `?? null` works here... that's to ensure PHP doesn't throw an ""undefined"" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do: <pre> $expiration = isset($profile->expirationDate) ? $this->dateConverter->convertToDisplayDate(""Y-m-d H:i"", $profile->expirationDate) : null; </pre> And then assigning the `$expiration` value in the return array..."
+5013,"@@ -0,0 +1,8 @@
++import Vue from 'vue'
++import App from './App.vue'
++
++Vue.config.productionTip = false
++
++new Vue({
++  render: h => h(App),
++}).$mount('#app')",An ENV should be used? Are you sure that the Vue examples are built in the production mode?
+5014,"@@ -52,7 +52,7 @@ class NodeResult(
+         warn (Optional[Any]): The ``warn`` field from the results of the executed dbt node.
+         skip (Optional[Any]): The ``skip`` field from the results of the executed dbt node.
+         status (Optional[Union[str,int]]): The status of the executed dbt node (model).
+-        execution_time (float): The execution duration (in seconds) of the dbt node (model).
++        execution_time (Union[float,int]): The execution duration (in seconds) of the dbt node (model).
+         thread_id (str): The dbt thread identifier that executed the dbt node (model).
+         step_timings (List[StepTiming]): The timings for each step in the executed dbt node
+             (model).",Nit: this should actually always be float since we convert it before we construct the namedtuple.
+5015,"@@ -99,7 +99,13 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+         , dataPath_(folly::stringPrintf(""%s/nebula/%d"", dataPath.c_str(), spaceId)) {
+     auto path = folly::stringPrintf(""%s/data"", dataPath_.c_str());
+     if (FileUtils::fileType(path.c_str()) == FileType::NOTEXIST) {
+-        FileUtils::makeDir(path);
++        if (!FileUtils::makeDir(path)) {
++            LOG(FATAL) << ""makeDir "" << path << "" failed"";
++        }
++    }
++
++    if (FileUtils::fileType(path.c_str()) != FileType::DIRECTORY) {
++        LOG(FATAL) << path << "" is not directory"";
+     }
+
+     rocksdb::Options options;","The result of `FileUtils::fileType` could be saved, instead of calling twice."
+5016,"@@ -71,7 +71,10 @@ abstract class BaseProvider implements MediaProviderInterface
+             return;
+         }
+
+-        $this->doTransform($media);
++        try {
++            $this->doTransform($media);
++        } catch (\Exception $e) {
++        }
+     }
+
+     /**",Can you log the exception ?
+5017,"@@ -113,6 +113,9 @@ static int http_post(struct flb_out_http *ctx,
+                         ctx->host, ctx->port,
+                         ctx->proxy, 0);
+
++
++    flb_debug(""[http_client] proxy host: %s port: %i"", c->proxy.host, c->proxy.port);
++
+     /* Allow duplicated headers ? */
+     flb_http_allow_duplicated_headers(c, ctx->allow_dup_headers);
+ ","since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, ""...""), on this case don't need the component prefix since the API will put it there automatically"
+5018,"@@ -25,10 +25,10 @@ import com.yahoo.athenz.common.server.util.ResourceUtils;
+ import com.yahoo.athenz.zts.ZTSConsts;
+ import com.yahoo.athenz.zts.cert.InstanceCertManager;
+ import com.yahoo.athenz.zts.store.DataStore;
++import com.yahoo.rdl.Timestamp;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+-import java.sql.Timestamp;
+ import java.text.MessageFormat;
+ import java.util.*;
+ import java.util.stream.Collectors;","I also took advantage of the changes to change the Timestamps used in this notification from ""java.sql.Timestamp"" to ""com.yahoo.rdl.Timestamp""."
+5019,"@@ -23,6 +23,6 @@ import ""time""
+ const (
+ 	BrokerPort          = 4222
+ 	BrokerMaxReconnect  = -1
+-	BrokerReconnectWait = 4 * time.Second
++	BrokerReconnectWait = 1 * time.Second
+ 	BrokerTimeout       = 5 * time.Second
+ )","It would be nice all these tweaks to be configurable from cmd line, with sensible defaults"
+5020,"@@ -147,9 +147,10 @@ class SQLServer(object):
+
+         if make_url(connection_string).drivername == 'sqlite+pysqlite':
+             # FIXME: workaround for locking errors
+-            return sqlalchemy.create_engine(connection_string,
+-                                            encoding='utf8',
+-                                            connect_args={'timeout': 600})
++            return sqlalchemy.create_engine(
++                connection_string,
++                encoding='utf8',
++                connect_args={'timeout': 600})
+         else:
+             return sqlalchemy.create_engine(connection_string,
+                                             encoding='utf8')",Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this.
+5021,"@@ -318,6 +318,13 @@ module.exports = BaseTest.extend({
+
+             // Should have been multiplied by 100 in the constructor.
+             TestCase.assertEqual(object.intCol, 100);
++
++            // Should be able to create object by passing in constructor.
++            object = realm.create(CustomObject, {intCol: 2});
++            TestCase.assertTrue(object instanceof CustomObject);
++            TestCase.assertTrue(Object.getPrototypeOf(object) == CustomObject.prototype);
++            TestCase.assertEqual(customCreated, 2);
++            TestCase.assertEqual(object.intCol, 200);
+         });
+
+         TestCase.assertThrows(function() {","We should probably test with constructors which aren't in the schema, and functions which aren't constructors."
+5022,"@@ -201,6 +201,19 @@ CudaHostPinnedSpace::CudaHostPinnedSpace() {}
+ // <editor-fold desc=""allocate()""> {{{1
+
+ void *CudaSpace::allocate(const size_t arg_alloc_size) const {
++  return allocate(""[unlabeled]"", arg_alloc_size);
++}
++void *CudaSpace::allocate(const char *
++#if defined(KOKKOS_ENABLE_PROFILING)
++                              arg_label
++#endif
++                          ,
++                          const size_t arg_alloc_size,
++                          const size_t
++#if defined(KOKKOS_ENABLE_PROFILING)
++                              arg_logical_size
++#endif
++                          ) const {
+   void *ptr = nullptr;
+
+   auto error_code = cudaMalloc(&ptr, arg_alloc_size);",this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical.
+5023,"@@ -32,7 +32,7 @@ module Beaker
+             'puppetbin'        => '/opt/puppet/bin/puppet',
+             'puppetbindir'     => '/opt/puppet/bin',
+             'puppetsbindir'    => '/opt/puppet/sbin',
+-            'privatebindir'    => '/opt/puppetlabs/puppet/bin',
++            'privatebindir'    => '/opt/puppet/bin',
+             'puppetvardir'     => '/var/opt/lib/pe-puppet',
+             'hieradatadir'     => '/var/lib/hiera',
+             'hieraconf'        => '/etc/puppetlabs/puppet/hiera.yaml',",This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl
+5024,"@@ -106,13 +106,9 @@ func main() {
+ }
+
+ func initLogger(cfg config.Config) {
+-	addr, err := cfg.BlockchainAddress()
+-	if err != nil {
+-		glog.Fatalln(""Failed to get producer address from pub/kri key: "", err)
+-		return
+-	}
++	addr := cfg.ProducerAddress()
+ 	if err := log.InitGlobal(cfg.Log, zap.Fields(
+-		zap.String(""addr"", addr.String()),
++		zap.String(""iotexAddress"", addr.String()),
+ 		zap.String(""networkAddress"", fmt.Sprintf(""%s:%d"", cfg.Network.Host, cfg.Network.Port)),
+ 	)); err != nil {
+ 		glog.Println(""Cannot config global logger, use default one: "", err)",nit: let's call our address ioAddr from now on
+5025,"@@ -12845,7 +12845,9 @@ bool CoreChecks::PreCallValidateGetBufferDeviceAddressEXT(VkDevice device, const
+
+ void CoreChecks::PreCallRecordGetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice,
+                                                           VkPhysicalDeviceProperties *pPhysicalDeviceProperties) {
+-    if (enabled.gpu_validation && enabled.gpu_validation_reserve_binding_slot) {
++    // There is an implicit layer that can cause this call to return 0 for maxBoundDescriptorSets - Ignore such calls
++    if (enabled.gpu_validation && enabled.gpu_validation_reserve_binding_slot &&
++        pPhysicalDeviceProperties->limits.maxBoundDescriptorSets > 0) {
+         if (pPhysicalDeviceProperties->limits.maxBoundDescriptorSets > 1) {
+             pPhysicalDeviceProperties->limits.maxBoundDescriptorSets -= 1;
+         } else {","You're killing this ""else"" case here which currently flags an error when maxBoundDescriptorSets == 0."
+5026,"@@ -509,6 +509,16 @@ fill_refs_and_checksums_from_summary (GVariant    *summary,
+   return TRUE;
+ }
+
++static gboolean
++remove_null_checksum_refs (gpointer key,
++                           gpointer value,
++                           gpointer user_data)
++{
++  const char *checksum = value;
++
++  return (checksum == NULL);
++}
++
+ /* Given a summary file (@summary_bytes), extract the refs it lists, and use that
+  * to fill in the checksums in the @supported_ref_to_checksum map. This includes
+  * the main refs list in the summary, and the map of collection IDs to further",Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table.
+5027,"@@ -86,8 +86,7 @@ public class Catalog implements AutoCloseable {
+         tableMap = loadTables(db);
+       }
+       Collection<TiTableInfo> tables = tableMap.values();
+-      tables.removeIf(TiTableInfo::isView);
+-      return ImmutableList.copyOf(tables);
++      return tables.stream().filter(TiTableInfo::isNotView).collect(Collectors.toList());
+     }
+
+     public TiTableInfo getTable(TiDBInfo db, String tableName) {",or you can use `filter(x => !x.isView)`
+5028,"@@ -133,7 +133,6 @@ func (c *Cluster) storageBootstrap(ctx context.Context) error {
+ 	}
+
+ 	return c.ReconcileBootstrapData(ctx, bytes.NewBuffer(data), &c.config.Runtime.ControlRuntimeBootstrap)
+-	//return bootstrap.WriteToDiskFromStorage(bytes.NewBuffer(data), &c.runtime.ControlRuntimeBootstrap)
+ }
+
+ // getBootstrapKeyFromStorage will list all keys that has prefix /bootstrap and will check for key that is","Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later."
+5029,"@@ -182,6 +182,7 @@ class AsciiDoc:
+
+         asciidoc_args = ['--theme=qute', '-a toc', '-a toc-placement=manual']
+         self.call(modified_src, dst, *asciidoc_args)
++        # pylint: enable=too-many-locals,too-many-statements
+
+     def _build_website(self):
+         """"""Prepare and build the website.""""""","No need for this, as pylint already only turns things off for this function and it's needed for the entire function."
+5030,"@@ -733,7 +733,7 @@ func (eval *BlockEvaluator) transactionGroup(txgroup []transactions.SignedTxnWit
+ 		txibs = append(txibs, txib)
+
+ 		if eval.validate {
+-			groupTxBytes += len(protocol.Encode(&txib))
++			groupTxBytes += txib.GetEncodedLength()
+ 			if eval.blockTxBytes+groupTxBytes > eval.proto.MaxTxnBytesPerBlock {
+ 				return ErrNoSpace
+ 			}","extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always the case, but this case happens to be on the critical path ). Caching the encoded data of the *first* block could help us repeating the process."
+5031,"@@ -849,8 +849,11 @@ describe Mongoid::Association::Depending do
+
+       it 'adds an error to the parent object' do
+         expect(person.delete).to be(false)
+-        expect(person.errors[:restrictable_posts].first).to be(
+-          Mongoid::Association::Depending::RESTRICT_ERROR_MSG)
++
++        key_message = ""#{Mongoid::Errors::MongoidError::BASE_KEY}.restrict_with_error_dependent_destroy""
++        expect(person.errors[:base].first).to eq(
++          ::I18n.translate(key_message, association: :restrictable_posts)
++        )
+       end
+     end
+ ","This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is."
+5032,"@@ -18,6 +18,7 @@ package ec2
+
+ import (
+ 	""fmt""
++
+ 	""sigs.k8s.io/cluster-api/util/conditions""
+
+ 	errlist ""k8s.io/apimachinery/pkg/util/errors""","similar here for imports, these should be consolidated (and also consolidated with the grouping below)"
+5033,"@@ -231,7 +231,7 @@ class LoadAnnotations:
+         self.with_seg = with_seg
+         self.poly2mask = poly2mask
+         self.file_client_args = file_client_args.copy()
+-        self.file_client = None
++        self.file_client = mmcv.FileClient(**self.file_client_args)
+
+     def _load_bboxes(self, results):
+         """"""Private function to load bounding box annotations.","Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized."
+5034,"@@ -104,8 +104,7 @@ final class SelectTraceIdsFromSpan extends ResultSetFutureCall {
+       Input input =
+           new AutoValue_SelectTraceIdsFromSpan_Input(
+               serviceName,
+-              // % for like, bracing with ░ to ensure no accidental substring match
+-              ""%░"" + annotationKey + ""░%"",
++              annotationKey,
+               timestampRange.startUUID,
+               timestampRange.endUUID,
+               limit);",Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?
+5035,"@@ -29,6 +29,13 @@
+ #include <opae/fpga.h>
+ #include <time.h>
+ #include ""fpga_dma.h""
++#include <getopt.h>
++#include <stdio.h>
++#include <stdint.h>
++#include <errno.h>
++#include <stdbool.h>
++#include <sys/stat.h>
++#include ""safe_string/safe_string.h""
+ /**
+  * \fpga_dma_test.c
+  * \brief User-mode DMA test",Please update the DMA test app in AFU repo once this gets approved.
+5036,"@@ -57,8 +57,8 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend
+         $manager->persist(new SettingValue(PricingSetting::DEFAULT_DOMAIN_CURRENCY, $defaultCurrency->getId(), Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::DEFAULT_AVAILABILITY_IN_STOCK, $defaultInStockAvailability->getId(), SettingValue::DOMAIN_ID_COMMON));
+         $manager->persist(new SettingValue(PricingSetting::FREE_TRANSPORT_AND_PAYMENT_PRICE_LIMIT, null, Domain::FIRST_DOMAIN_ID));
+-        $manager->persist(new SettingValue(SeoSettingFacade::SEO_META_DESCRIPTION_MAIN_PAGE, 'ShopSys Framework - the best solution for your eshop.', Domain::FIRST_DOMAIN_ID));
+-        $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_MAIN_PAGE, 'ShopSys Framework - Title page', Domain::FIRST_DOMAIN_ID));
++        $manager->persist(new SettingValue(SeoSettingFacade::SEO_META_DESCRIPTION_MAIN_PAGE, 'Shopsys Framework - the best solution for your eshop.', Domain::FIRST_DOMAIN_ID));
++        $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_MAIN_PAGE, 'Shopsys Framework - Title page', Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_ADD_ON, '| Demo eshop', Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::TERMS_AND_CONDITIONS_ARTICLE_ID, null, Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::COOKIES_ARTICLE_ID, null, Domain::FIRST_DOMAIN_ID));",There should be a migration for that as well to reflect the change on in-production instances
+5037,"@@ -41,6 +41,7 @@ var _ = BeforeSuite(func() {
+ 	appName = fmt.Sprintf(""e2e-customizedenv-%d"", time.Now().Unix())
+ 	vpcConfig = client.EnvInitRequestVPCConfig{
+ 		CIDR:               ""10.1.0.0/16"",
++		AZs:                `""""`, // Use default AZ options.
+ 		PrivateSubnetCIDRs: ""10.1.2.0/24,10.1.3.0/24"",
+ 		PublicSubnetCIDRs:  ""10.1.0.0/24,10.1.1.0/24"",
+ 	}","Why does it have to be `""""` instead of an empty string  "
+5038,"@@ -107,7 +107,7 @@ module RSpec
+         start(reporter)
+
+         begin
+-          unless pending
++          unless pending or RSpec.configuration.dry_run
+             with_around_each_hooks do
+               begin
+                 run_before_each","This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?"
+5039,"@@ -894,7 +894,7 @@ module RSpec
+       # @private
+       RANDOM_ORDERING = lambda do |list|
+         Kernel.srand RSpec.configuration.seed
+-        ordering = list.sort_by { Kernel.rand(list.size) }
++        ordering = list.shuffle
+         Kernel.srand # reset random generation
+         ordering
+       end",Will this obey the seed set on Kernel?
+5040,"@@ -23,16 +23,9 @@ Puppet::Functions.create_function(:add_facts) do
+         .from_issue_and_stack(Bolt::PAL::Issues::PLAN_OPERATION_NOT_SUPPORTED_WHEN_COMPILING, action: 'add_facts')
+     end
+
+-    inventory = Puppet.lookup(:bolt_inventory) { nil }
+-
+-    unless inventory
+-      raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
+-        Puppet::Pops::Issues::TASK_MISSING_BOLT, action: _('add facts')
+-      )
+-    end
+-
+-    executor = Puppet.lookup(:bolt_executor) { nil }
+-    executor&.report_function_call('add_facts')
++    inventory = Puppet.lookup(:bolt_inventory)
++    executor = Puppet.lookup(:bolt_executor)
++    executor.report_function_call('add_facts')
+
+     inventory.add_facts(target, facts)
+   end","We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate."
+5041,"@@ -68,11 +68,12 @@ public class SurfaceNamer extends NameFormatterDelegator {
+
+   public String getNotImplementedString(String feature) {
+     return ""$ NOT IMPLEMENTED: "" + feature + "" $"";
++    //throw new RuntimeException(feature);
+   }
+
+   /** The full path to the source file  */
+   public String getSourceFilePath(String path, String className) {
+-    return getNotImplementedString(""SurfaceNamer.getSourceFilePath"");
++    return getNotImplementedString(""SurfaceNamer:getSourceFilePath"");
+   }
+
+   /** The name of the class that implements a particular proto interface. */",Why the switch from period to colon?
+5042,"@@ -314,8 +314,9 @@ func environmentConfig() Config {
+ 	imageCleanupDisabled := utils.ParseBool(os.Getenv(""ECS_DISABLE_IMAGE_CLEANUP""), false)
+ 	minimumImageDeletionAge := parseEnvVariableDuration(""ECS_IMAGE_MINIMUM_CLEANUP_AGE"")
+ 	imageCleanupInterval := parseEnvVariableDuration(""ECS_IMAGE_CLEANUP_INTERVAL"")
+-	numImagesToDeletePerCycle, err := strconv.Atoi(os.Getenv(""ECS_NUM_IMAGES_DELETE_PER_CYCLE""))
+-	if err != nil {
++	numImagesToDeletePerCycleEnvVal := os.Getenv(""ECS_NUM_IMAGES_DELETE_PER_CYCLE"")
++	numImagesToDeletePerCycle, err := strconv.Atoi(numImagesToDeletePerCycleEnvVal)
++	if numImagesToDeletePerCycleEnvVal != """" && err != nil {
+ 		seelog.Warnf(""Invalid format for \""ECS_NUM_IMAGES_DELETE_PER_CYCLE\"", expected an integer. err %v"", err)
+ 	}
+ ","Can you just fix the warning instead? It's actually important for this to have a default of `""""` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `""""`, you break the assumptions of `Merge()`."
+5043,"@@ -23,5 +23,15 @@ namespace Nethermind.Baseline.Config
+     {
+         [ConfigItem(Description = ""If 'true' then the Baseline Module is enabled via JSON RPC"", DefaultValue = ""false"")]
+         bool Enabled { get; }
++
++        bool BaselineTreeDbCacheIndexAndFilterBlocks { get; set; }
++        ulong BaselineTreeDbBlockCacheSize { get; set; }
++        ulong BaselineTreeDbWriteBufferSize { get; set; }
++        uint BaselineTreeDbWriteBufferNumber { get; set; }
++
++        bool BaselineTreeMetadataDbCacheIndexAndFilterBlocks { get; set; }
++        ulong BaselineTreeMetadataDbBlockCacheSize { get; set; }
++        ulong BaselineTreeMetadataDbWriteBufferSize { get; set; }
++        uint BaselineTreeMetadataDbWriteBufferNumber { get; set; }
+     }
+-}
++}",let us not add this
+5044,"@@ -41,6 +41,13 @@ type Cgroup struct {
+
+ 	// Rootless tells if rootless cgroups should be used.
+ 	Rootless bool
++
++	// The host UID that should own the cgroup, or nil to accept
++	// the default ownership.  This should only be set when the
++	// cgroupfs is to be mounted read/write.
++	// Not all cgroup manager implementations support changing
++	// the ownership.
++	OwnerUID *int `json:""owner_uid,omitempty""`
+ }
+
+ type Resources struct {",Is there a need for group as well? crun sets both.
+5045,"@@ -62,9 +62,12 @@ namespace OpenTelemetry.Instrumentation.Dependencies.Tests
+         [Fact]
+         public async Task HttpDependenciesInstrumentationInjectsHeadersAsync()
+         {
+-            var spanProcessor = new Mock<SpanProcessor>();
+-            var tracer = TracerFactory.Create(b => b.AddProcessorPipeline(p => p.AddProcessor(_ => spanProcessor.Object)))
+-                .GetTracer(null);
++            var activityProcessor = new Mock<ActivityProcessor>();
++            using var shutdownSignal = OpenTelemetrySdk.EnableOpenTelemetry(b =>
++            {
++                b.SetProcessorPipeline(c => c.AddProcessor(ap => activityProcessor.Object));
++                b.AddHttpWebRequestDependencyInstrumentation();
++            });
+
+             var request = (HttpWebRequest)WebRequest.Create(this.url);
+ ","@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a ""Next"" or make sure that the chain is called. Probably need to do some more work in this area?"
+5046,"@@ -1206,6 +1206,11 @@ Schema.prototype.queue = function(name, args) {
+  *       console.log(this.getFilter());
+  *     });
+  *
++ *     // Equivalent to calling `pre()` on `save`, `findOneAndUpdate`.
++ *     toySchema.pre(['save', 'findOneAndUpdate'], function(next) {
++ *       console.log(this.getFilter());
++ *     });
++ *
+  * @param {String|RegExp} The method name or regular expression to match method name
+  * @param {Object} [options]
+  * @param {Boolean} [options.document] If `name` is a hook for both document and query middleware, set to `true` to run on document middleware.","`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?"
+5047,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.
+5048,"@@ -67,18 +67,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+
+                     if (result.IsCancelled)
+                     {
+-                        // Send a FIN
+-                        _log.ConnectionWriteFin(_connectionId);
+-
+-                        using (var shutdownReq = new UvShutdownReq(_log))
+-                        {
+-                            shutdownReq.Init(_thread);
+-                            var shutdownResult = await shutdownReq.ShutdownAsync(_socket);
+-
+-                            _log.ConnectionWroteFin(_connectionId, shutdownResult.Status);
+-                        }
+-
+-                        // Ensure no data is written after uv_shutdown
+                         break;
+                     }
+ ",I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?
+5049,"@@ -248,7 +248,7 @@ func (a *Agent) Attest() error {
+ 	// Configure TLS
+ 	// TODO: Pick better options here
+ 	tlsConfig := &tls.Config{
+-		RootCAs: a.Config.TrustBundle,
++		InsecureSkipVerify:true,
+ 	}
+ 	dialCreds := grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig))
+ 	conn, err := grpc.Dial(a.Config.ServerAddress.String(), dialCreds)",I think we can get this to work by passing in the root ca cert fixture that upstream ca is using
+5050,"@@ -219,6 +219,18 @@ static batch_job_id_t batch_job_condor_wait (struct batch_queue * q, struct batc
+ 		}
+ 	}
+
++	time_t current;
++	struct tm tm;
++
++	/* Obtain current year, in case HTCondor log lines do not provide a year.
++	   Note that this fallback may give the incorrect year for jobs that run
++	   when the year turns. However, we just need some value to give to a
++	   mktime below, and the current year is preferable than some fixed value.
++	   */
++	time(&current);
++	tm = *localtime(&current);
++	int current_year = tm.tm_year + 1900;
++
+ 	while(1) {
+ 		/*
+ 		   Note: clearerr is necessary to clear any cached end-of-file condition,",Just occurred to me to ask: is the condor log date in localtime or UTC?
+5051,"@@ -686,7 +686,18 @@ public enum Varbits
+ 	/**
+ 	 * 1 is true, 0 is false.
+ 	 */
+-	GAUNTLET_ENTERED(9178);
++	GAUNTLET_ENTERED(9178),
++
++	/**
++	 * 1 if full of Mushrooms, 0 is empty.
++	 */
++	MUSHY_PIT(5809),
++
++	/**
++	 * Current location of Sulliuscep tree.
++	 */
++	SULLIUSCEP_LOCATION(5808);
++
+
+ 	/**
+ 	 * The raw varbit ID.",Can you remove the sculliscep varbits from here too?
+5052,"@@ -1162,6 +1162,12 @@ function update_5_9_2018() {
+     "");
+ }
+
++function update_8_23_2018() {
++    $retval = do_query(""alter table host add index host_cpid (host_cpid)"");
++    return $retval && do_query(""alter table host add index host_domain_name (domain_name)"");
++}
++
++
+ // Updates are done automatically if you use ""upgrade"".
+ //
+ // If you need to do updates manually,",I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here.
+5053,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.
+5054,"@@ -47,8 +47,7 @@
+
+ void h2o_mruby__abort_exc(mrb_state *mrb, const char *mess, const char *file, int line)
+ {
+-    h2o_error_printf(""%s at file: \""%s\"", line %d: %s\n"", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc))));
+-    abort();
++    h2o_fatal(""%s at file: \""%s\"", line %d: %s\n"", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc))));
+ }
+
+ mrb_value h2o_mruby__new_str(mrb_state *mrb, const char *s, size_t len, int is_static, const char *file, int line)","Should we do something like `h2o__fatal(file, line, ""fatal error: %s, %s\n"", mess, RSTRING_PTR(...))` here?"
+5055,"@@ -24,7 +24,8 @@ describe('monitoring', function () {
+     return mock.createServer().then(server => (mockServer = server));
+   });
+
+-  it('should record roundTripTime', function (done) {
++  // TODO: NODE-3819: Unskip flaky tests.
++  it.skip('should record roundTripTime', function (done) {
+     mockServer.setMessageHandler(request => {
+       const doc = request.document;
+       if (isHello(doc)) {",is this one all platforms?
+5056,"@@ -72,7 +72,7 @@ func TestBytes(t *testing.T) {
+ 	t.Run(""not found"", func(t *testing.T) {
+ 		jsonhttptest.Request(t, client, http.MethodGet, resource+""/abcd"", http.StatusNotFound,
+ 			jsonhttptest.WithExpectedJSONResponse(jsonhttp.StatusResponse{
+-				Message: ""not found"",
++				Message: ""Not Found"",
+ 				Code:    http.StatusNotFound,
+ 			}),
+ 		)",why capitals grr?
+5057,"@@ -0,0 +1,17 @@
++package nameserver
++
++import (
++	. ""github.com/zettio/weave/common""
++)
++
++func checkFatal(e error) {
++	if e != nil {
++		Error.Fatal(e)
++	}
++}
++
++func checkWarn(e error) {
++	if e != nil {
++		Warning.Println(e)
++	}
++}",Surely all the above should go into `common`.
+5058,"@@ -249,7 +249,6 @@ def test_failing_unwatch(qtbot, caplog, monkeypatch):
+     assert caplog.records[-1].msg == message
+
+
+-
+ @pytest.mark.parametrize('text, caret_position, result', [
+     ('', 0, (1, 1)),
+     ('a', 0, (1, 1)),","This is an unrelated change, but was failing CI... probably introduced in master."
+5059,"@@ -30,7 +30,10 @@ double getAlignmentTransform(const ROMol &prbMol, const ROMol &refMol,
+   if (atomMap == 0) {
+     // we have to figure out the mapping between the two molecule
+     MatchVectType match;
+-    if (SubstructMatch(refMol, prbMol, match)) {
++    const bool recursionPossible = true;
++    const bool useChirality = false;
++    const bool useQueryQueryMatches = true;
++    if (SubstructMatch(refMol, prbMol, match, recursionPossible, useChirality, useQueryQueryMatches)) {
+       MatchVectType::const_iterator mi;
+       for (mi = match.begin(); mi != match.end(); mi++) {
+         prbPoints.push_back(&prbCnf.getAtomPos(mi->first));","This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem."
+5060,"@@ -81,8 +81,9 @@ import (
+ var endPoint = ""pubsub.googleapis.com:443""
+
+ var sendBatcherOpts = &batcher.Options{
+-	MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC
+-	MaxHandlers:  2,
++	MaxBatchSize:     1000, // The PubSub service limits the number of messages in a single Publish RPC
++	MaxHandlers:      2,
++	MaxBatchByteSize: 10 * 1000 * 1000, // The PubSub service limits the size of request body in a single Publish RPC
+ }
+
+ var defaultRecvBatcherOpts = &batcher.Options{",MB is presumably 1024 * 1024.
+5061,"@@ -22,6 +22,12 @@
+ import DashboardSplashMain from 'GoogleComponents/dashboard-splash/dashboard-splash-main';
+ import { Suspense as ReactSuspense, lazy as ReactLazy } from 'react';
+
++/**
++ * WordPress dependencies
++ */
++import { Component, Fragment, Suspense as WPSuspense, lazy as WPlazy } from '@wordpress/element';
++import { __ } from '@wordpress/i18n';
++
+ /**
+  * Internal dependencies
+  */",Didn't we extract this logic to a `react-features` helper?
+5062,"@@ -24,8 +24,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Filter.Internal
+
+         private bool _canWrite = true;
+
+-        private object _writeLock = new object();
+-
+         public StreamSocketOutput(string connectionId, Stream outputStream, MemoryPool memory, IKestrelTrace logger)
+         {
+             _connectionId = connectionId;","But But, overlapping async writes will get corrupted  "
+5063,"@@ -9,6 +9,7 @@ import (
+
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/chain""
++	""github.com/filecoin-project/go-filecoin/config""
+ 	""github.com/filecoin-project/go-filecoin/metrics""
+ 	""github.com/filecoin-project/go-filecoin/types""
+ )","Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?"
+5064,"@@ -443,9 +443,6 @@ public class PasscodeActivityTest extends
+                     v.onEditorAction(actionCode);
+                 }
+             });
+-            waitSome();
+-            //the enter key will send ACTION_DOWN and ACTION_UP both events out
+-            this.sendKeys(KeyEvent.KEYCODE_ENTER);
+         } catch (Throwable t) {
+             fail(""Failed do editor action "" + actionCode);
+         }","recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed."
+5065,"@@ -46,6 +46,7 @@ Status FindPathValidator::validateWhere(WhereClause* where) {
+   }
+   where->setFilter(ExpressionUtils::rewriteLabelAttr2EdgeProp(expr));
+   auto filter = where->filter();
++  NG_RETURN_IF_ERROR(checkExprDepth(filter));
+
+   auto typeStatus = deduceExprType(filter);
+   NG_RETURN_IF_ERROR(typeStatus);",It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere.
+5066,"@@ -95,7 +95,8 @@ public class DefaultMailCreatorTest {
+     executableFlow.setStatus(Status.FAILED);
+     assertTrue(mailCreator.createErrorEmail(
+         executableFlow, message, azkabanName, scheme, clientHostname, clientPortNumber));
+-    assertEquals(""Flow 'mail-creator-test' has failed on unit-tests"", message.getSubject());
++    assertEquals(""Flow 'mail-creator-test' has failed on unit-tests"",
++        message.getSubject());
+     assertEquals(read(""errorEmail.html""), message.getBody());
+   }
+ ",why split into two lines?
+5067,"@@ -48,8 +48,7 @@ import org.apache.iceberg.types.Types;
+  * represented by a named {@link PartitionField}.
+  */
+ public class PartitionSpec implements Serializable {
+-  // start assigning IDs for partition fields at 1000
+-  private static final int PARTITION_DATA_ID_START = 1000;
++  public static final int PARTITION_DATA_ID_START = 1000;
+
+   private final Schema schema;
+ ",Does this need to be public or can it be package-private?
+5068,"@@ -86,6 +86,11 @@ class FileCard extends Component {
+   render () {
+     const file = this.props.files[this.props.fileCardFor]
+
++    let showEditButton
++    this.props.editors.forEach((target) => {
++      showEditButton = this.props.getPlugin(target.id).сanEditFile(file)
++    })
++
+     return (
+       <div
+         class=""uppy-Dashboard-FileCard""", Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?
+5069,"@@ -313,8 +313,14 @@ public class IntMultimap<T> implements Traversable<T>, Serializable {
+
+     @Override
+     public <U> Seq<Tuple2<T, U>> zip(Iterable<? extends U> that) {
++        return zipWith(that, Tuple::of);
++    }
++
++    @Override
++    public <U, R> Seq<R> zipWith(Iterable<? extends U> that, BiFunction<? super T, ? super U, ? extends R> mapper) {
+         Objects.requireNonNull(that, ""that is null"");
+-        return Stream.ofAll(iterator().zip(that));
++        Objects.requireNonNull(mapper, ""mapper is null"");
++        return Stream.ofAll(iterator().zipWith(that, mapper));
+     }
+
+     @Override",`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?
+5070,"@@ -436,6 +436,7 @@ class Status(AbstractCommand):
+         print(x)
+         print
+         self.molecule._print_valid_platforms()
++        print
+         self.molecule._print_valid_providers()
+
+ ","Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437."
+5071,"@@ -27,11 +27,17 @@ func SetupGenesisNode(ctx context.Context, node *fat.Filecoin, gcURI string, min
+ 		return err
+ 	}
+
+-	if _, err := node.WalletImport(ctx, minerOwner); err != nil {
++	wallet, err := node.WalletImport(ctx, minerOwner)
++	if err != nil {
+ 		return err
+ 	}
+
+-	if _, err := node.MinerUpdatePeerid(ctx, minerAddress, node.PeerID, fat.AOPrice(big.NewFloat(300)), fat.AOLimit(300)); err != nil {
++	if err := node.ConfigSet(ctx, ""wallet.defaultAddress"", wallet[0].String()); err != nil {
++		return err
++	}
++
++	_, err = node.MinerUpdatePeerid(ctx, minerAddress, node.PeerID, fat.AOFromAddr(wallet[0]), fat.AOPrice(big.NewFloat(300)), fat.AOLimit(300))
++	if err != nil {
+ 		return err
+ 	}
+ ","Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?"
+5072,"@@ -30,9 +30,17 @@ export class ComicsPlayer {
+         return this.setCurrentSrc(elem, options);
+     }
+
++    destroy() {
++        // Nothing to do here
++    }
++
+     stop() {
+         this.unbindEvents();
++        const stopInfo = {
++            src: this.item
++        };
+
++        Events.trigger(this, 'stopped', [stopInfo]);
+         this.archiveSource?.release();
+
+         const elem = this.mediaElement;",Could you move it after `stop`?
+5073,"@@ -49,10 +49,10 @@ public final class ClassUtils {
+
+   // 将一系列body parameter包装成一个class
+   public static Class<?> getOrCreateBodyClass(OperationGenerator operationGenerator,
+-      List<BodyParameter> bodyParameters) {
++      List<BodyParameter> bodyParameters, String bodyParamName) {
+     SwaggerGenerator swaggerGenerator = operationGenerator.getSwaggerGenerator();
+     Method method = operationGenerator.getProviderMethod();
+-    String clsName = swaggerGenerator.ensureGetPackageName() + ""."" + method.getName() + ""Body"";
++    String clsName = swaggerGenerator.ensureGetPackageName() + ""."" + bodyParamName;
+     Class<?> cls = getClassByName(swaggerGenerator.getClassLoader(), clsName);
+     if (cls != null) {
+       return cls;",The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)` ?
+5074,"@@ -57,7 +57,6 @@ import static org.apache.solr.cloud.OverseerCollectionMessageHandler.NUM_SLICES;
+ import static org.apache.solr.common.cloud.ZkStateReader.MAX_SHARDS_PER_NODE;
+ import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR;
+
+-@Slow
+ public class ShardSplitTest extends BasicDistributedZkTest {
+
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());",I don't think this should be here?
+5075,"@@ -26,8 +26,9 @@ type SyscallsImpl interface {
+ 	HashBlake2b(data []byte) [32]byte
+ 	ComputeUnsealedSectorCID(ctx context.Context, proof abi.RegisteredProof, pieces []abi.PieceInfo) (cid.Cid, error)
+ 	VerifySeal(ctx context.Context, info abi.SealVerifyInfo) error
+-	VerifyPoSt(ctx context.Context, info abi.PoStVerifyInfo) error
+-	VerifyConsensusFault(ctx context.Context, h1, h2, extra []byte, head block.TipSetKey, view SyscallsStateView, earliest abi.ChainEpoch) (*specsruntime.ConsensusFault, error)
++	VerifyWinningPoSt(ctx context.Context, info abi.WinningPoStVerifyInfo) error
++	VerifyPoSt(ctx context.Context, info abi.WindowPoStVerifyInfo) error
++	VerifyConsensusFault(ctx context.Context, h1, h2, extra []byte, head block.TipSetKey, view SyscallsStateView) (*specsruntime.ConsensusFault, error)
+ }
+
+ type syscalls struct {",Either I'm missing something or specs actors should remove this call cc @anorth
+5076,"@@ -119,12 +119,12 @@ namespace Reporting
+                 var counterWidth = Math.Max(test.Counters.Max(c => c.Name.Length) + 1, 15);
+                 var resultWidth = Math.Max(test.Counters.Max(c => c.Results.Max().ToString(""F3"").Length + c.MetricName.Length) + 2, 15);
+                 ret.AppendLine(test.Name);
+-                ret.AppendLine($""{LeftJustify(""Metric"", counterWidth)}|{LeftJustify(""Average"",resultWidth)}|{LeftJustify(""Min"", resultWidth)}|{LeftJustify(""Max"",resultWidth)}"");
++                ret.AppendLine($""{LeftJustify(""Metric"", counterWidth)}|{LeftJustify(""Average"", resultWidth)}|{LeftJustify(""Min"", resultWidth)}|{LeftJustify(""Max"", resultWidth)}"");
+                 ret.AppendLine($""{new String('-', counterWidth)}|{new String('-', resultWidth)}|{new String('-', resultWidth)}|{new String('-', resultWidth)}"");
+
+-
++
+                 ret.AppendLine(Print(defaultCounter, counterWidth, resultWidth));
+-                foreach(var counter in topCounters)
++                foreach (var counter in topCounters)
+                 {
+                     ret.AppendLine(Print(counter, counterWidth, resultWidth));
+                 }",Please undo all these changes as they are white-space only.
+5077,"@@ -114,9 +114,11 @@ final class CountryConfigurator implements FieldConfiguratorInterface
+     private function generateFormTypeChoices(string $countryCodeFormat): array
+     {
+         $choices = [];
++        $countriesAlpha2 = Countries::getNames();
+         $countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : Countries::getNames();
+         foreach ($countries as $countryCode => $countryName) {
+-            $flagImageName = \in_array($countryCode, self::FLAGS_WITH_IMAGE_FILE, true) ? $countryCode : 'UNKNOWN';
++            $countryCodeAlpha2 = array_search($countryName, $countriesAlpha2, true);
++            $flagImageName = \in_array($countryCodeAlpha2, self::FLAGS_WITH_IMAGE_FILE, true) ? $countryCodeAlpha2 : 'UNKNOWN';
+             $flagImagePath = $this->assetPackages->getUrl(sprintf('bundles/easyadmin/images/flags/%s.png', $flagImageName));
+             $choiceKey = sprintf('<img src=""%s"" class=""country-flag"" loading=""lazy"" alt=""%s""> %s', $flagImagePath, $countryName, $countryName);
+ ",You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : $countriesAlpha2;`
+5078,"@@ -311,7 +311,7 @@ def _comment(string):
+ def _format_option_value(optdict, value):
+     """"""return the user input's value from a 'compiled' value""""""
+     if optdict.get(""type"", None) == ""py_version"":
+-        value = ""."".join(str(item) for item in value)
++        value = ""current Python interpreter version (e.g., '3.8')""
+     elif isinstance(value, (list, tuple)):
+         value = "","".join(_format_option_value(optdict, item) for item in value)
+     elif isinstance(value, dict):",Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did.
+5079,"@@ -95,6 +95,9 @@ def get_listens(user_name):
+     :param max_ts: If you specify a ``max_ts`` timestamp, listens with listened_at less than (but not including) this value will be returned.
+     :param min_ts: If you specify a ``min_ts`` timestamp, listens with listened_at greater than (but not including) this value will be returned.
+     :param count: Optional, number of listens to return. Default: :data:`~webserver.views.api.DEFAULT_ITEMS_PER_GET` . Max: :data:`~webserver.views.api.MAX_ITEMS_PER_GET`
++    :param time_range: This parameter determines the time range the listen search. Each increment of the time_range corresponds to a range of 5 days and the default
++                       time_range of 3 means that 15 days will be searched.
++                       Default: :data:`~webserver.views.api.DEFAULT_TIME_RANGE` . Max: :data:`~webserver.views.api.MAX_TIME_RANGE`
+     :statuscode 200: Yay, you have data!
+     :resheader Content-Type: *application/json*
+     """"""",> the time range the listen search the time range of the listen search?
+5080,"@@ -777,6 +777,8 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte,
+         NULL_TERMINATE_BUFFER(pc_addr);
+         DO_ONCE(SYSLOG(SYSLOG_ERROR, AVX_512_SUPPORT_INCOMPLETE, 2,
+                        get_application_name(), get_application_pid(), pc_addr));
++        if (ZMM_ENABLED())
++            dynamo_preserve_zmm_caller_saved = true;
+ #endif
+         info = &evex_prefix_extensions[0][1];
+     } else {","This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit."
+5081,"@@ -50,6 +50,7 @@ Cluster Options:
+         --routes <rurl-1, rurl-2>    Routes to solicit and connect
+         --cluster <cluster-url>      Cluster URL for solicited routes
+         --no_advertise <bool>        Advertise known cluster IPs to clients
++        --conn_retries <number>      For implicit routes, number of connect retries
+
+
+ Common Options:",would call it connect_retries
+5082,"@@ -3717,3 +3717,15 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils):
+
+         for p_items, k_items in zip(pdf.iteritems(), kdf.iteritems()):
+             self.assert_eq(repr(p_items), repr(k_items))
++
++    def test_tail(self):
++        if LooseVersion(pyspark.__version__) >= LooseVersion(""3.0""):
++            pdf = pd.DataFrame(range(1000))
++            kdf = ks.from_pandas(pdf)
++
++            self.assert_eq(repr(pdf.tail()), repr(kdf.tail()))
++            self.assert_eq(repr(pdf.tail(10)), repr(kdf.tail(10)))
++            self.assert_eq(repr(pdf.tail(-990)), repr(kdf.tail(-990)))
++            self.assert_eq(repr(pdf.tail(0)), repr(kdf.tail(0)))
++            with self.assertRaisesRegex(TypeError, ""bad operand type for unary -: 'str'""):
++                kdf.tail(""10"")",Why are we using `repr`?
+5083,"@@ -21,6 +21,6 @@ class ZMSBinder extends AbstractBinder {
+
+     @Override
+     protected void configure() {
+-        bind(new ZMSImpl()).to(ZMSHandler.class);
++        bind(ZMSImplFactory.getZmsInstance()).to(ZMSHandler.class);
+     }
+ }",I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS.
+5084,"@@ -114,7 +114,11 @@ public class JavaProcessJobTest {
+     props.put(CommonJobProperties.JOB_ID, ""test_job"");
+     props.put(CommonJobProperties.EXEC_ID, ""123"");
+     props.put(CommonJobProperties.SUBMIT_USER, ""test_user"");
+-    props.put(""execute.as.user"", ""false"");
++
++    //The execute-as-user binary requires special permission. It's not convenient to

++    //set up in a unit test that is self contained. So EXECUTE_AS_USER is set to false

++    //so that we don't have to rely on the binary file to change user in the test case.
++    props.put(ProcessJob.EXECUTE_AS_USER, ""false"");
+
+     job = new JavaProcessJob(""testJavaProcess"", props, props, log);
+   }",Consider consolidating the common code in a common setup method in tests?
+5085,"@@ -18,7 +18,7 @@ import static org.assertj.core.api.Assertions.assertThat;
+ import static org.mockito.Mockito.verifyNoInteractions;
+
+ import org.hyperledger.besu.ethereum.eth.EthProtocolConfiguration;
+-import org.hyperledger.besu.util.number.PositiveNumber;
++import org.hyperledger.besu.ethereum.eth.ImmutableEthProtocolConfiguration;
+
+ import org.junit.Test;
+ ",q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?
+5086,"@@ -69,12 +69,12 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter {
+   }
+
+   @Override
+-  public String getNicknameFor(Schema type) {
++  public String getNicknameFor(DiscoveryField type) {
+     return typeNameConverter.getTypeName(type).getNickname();
+   }
+
+   @Override
+-  public String getFullNameFor(Schema type) {
++  public String getFullNameFor(DiscoveryField type) {
+     return typeFormatter.getFullNameFor(type);
+   }
+ ",What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?
+5087,"@@ -353,6 +353,8 @@ func environmentConfig() (Config, error) {
+ 			errs = append(errs, err)
+ 		}
+ 	}
++	containerMetadataEnabled := utils.ParseBool(os.Getenv(""ECS_ENABLE_CONTAINER_METADATA""), false)
++	dataDirOnHost := os.Getenv(""ECS_HOST_DATA_DIR"")
+
+ 	if len(errs) > 0 {
+ 		err = utils.NewMultiError(errs...)","What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `""/var/lib/ecs""` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as whatever's being mounted as `/data` on the host. My main concern is the late-binding/asynchronous failures this could lead to if the wrong host mount was specified. Wondering if there are better alternatives here. Can we at the very least inspect the Agent container and check if `ECS_HOST_DATA_DIR` is mounted? If the answer is that we'll revisit the validation here at some latter stage, that's fine too. But, I want us to be aware of potential failures here."
+5088,"@@ -54,6 +54,11 @@ eprint_version(void)
+ #else
+     const char *has_dbus = ""✘"";
+ #endif
++#ifdef WITH_XCB_ERRORS
++    const char *has_xcb_errors = ""✔"";
++#else
++    const char *has_xcb_errors = ""✘"";
++#endif
+ #ifdef HAS_EXECINFO
+     const char *has_execinfo = ""✔"";
+ #else","btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font which have incompatible dimensions of characters) how do you think is it worth creating an issue to discuss/address it or it could just waste time on bikeshedding?"
+5089,"@@ -21,6 +21,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/server/itx""
++	recoverutil ""github.com/iotexproject/iotex-core/tools/util""
+ )
+
+ // recoveryHeight is the blockchain height being recovered to",alias is not needed
+5090,"@@ -19,7 +19,7 @@ DEFINE_int32(num_accept_threads, 1, ""Number of threads to accept incoming connec
+ DEFINE_bool(reuse_port, true, ""Whether to turn on the SO_REUSEPORT option"");
+ DEFINE_int32(listen_backlog, 1024, ""Backlog of the listen socket"");
+ DEFINE_string(listen_netdev, ""any"", ""The network device to listen on"");
+-DEFINE_string(pid_file, ""nebula-graphd.pid"", ""File to hold the process id"");
++DEFINE_string(pid_file, ""pids/nebula-graphd.pid"", ""File to hold the process id"");
+
+ DEFINE_bool(redirect_stdout, true, ""Whether to redirect stdout and stderr to separate files"");
+ DEFINE_string(stdout_log_file, ""graphd-stdout.log"", ""Destination filename of stdout"");",Do we need to include the path?
+5091,"@@ -1254,8 +1254,8 @@ func (js *jetStream) monitorStream(mset *stream, sa *streamAssignment) {
+
+ 	const (
+ 		compactInterval = 2 * time.Minute
+-		compactSizeMin  = 32 * 1024 * 1024
+-		compactNumMin   = 4
++		compactSizeMin  = 64 * 1024 * 1024
++		compactNumMin   = 8192
+ 	)
+
+ 	t := time.NewTicker(compactInterval)","During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB."
+5092,"@@ -1,5 +1,7 @@
+ package platform
+
++import ""log""
++
+ // App is an interface apps for Drud Local must implement to use shared functionality
+ type App interface {
+ 	Init(string) error","Here I thought you always insisted on ` log ""github.com/Sirupsen/logrus"" ` :) I might do a PR that just globally switches that out wherever we have log."
+5093,"@@ -495,10 +495,9 @@ type KeyMetadata interface {
+ 	GetTlfHandle() *TlfHandle
+
+ 	// HasKeyForUser returns whether or not the given user has
+-	// keys for at least one device at the given key
+-	// generation. Returns false if the TLF is public, or if the
+-	// given key generation is invalid.
+-	HasKeyForUser(keyGen KeyGen, user keybase1.UID) bool
++	// keys for at least one device. Returns an error if the TLF
++	// is public.
++	HasKeyForUser(user keybase1.UID) (bool, error)
+
+ 	// GetTLFCryptKeyParams returns all the necessary info to
+ 	// construct the TLF crypt key for the given key generation,","We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`."
+5094,"@@ -96,6 +96,7 @@ setup(
+         'dev': [
+             ""Flask>=0.10.1, <0.13"",
+             ""flake8>=3.2.1, <3.4"",
++            ""mock>=2.0.0, <3.0"",
+             ""mypy>=0.501, <0.502"",
+             ""rstcheck>=2.2, <4.0"",
+             ""tox>=2.3, <3"",",Please use `from unittest import mock` instead of this package.
+5095,"@@ -405,6 +405,11 @@ Aggregate.prototype.exec = function (callback) {
+
+   prepareDiscriminatorPipeline(this);
+
++  if (this.options.cursor)
++    return this._model
++      .collection
++      .aggregate(this._pipeline, this.options || {});
++
+   this._model
+     .collection
+     .aggregate(this._pipeline, this.options || {}, promise.resolve.bind(promise));","Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks."
+5096,"@@ -68,7 +68,7 @@ Rails.application.configure do
+   config.action_mailer.raise_delivery_errors = false
+   # config.action_mailer.perform_deliveries = true
+   config.action_mailer.delivery_method = :letter_opener_web
+-  config.action_mailer.smtp_settings = { address: 'mailrelay.blackducksoftware.com',
++  config.action_mailer.smtp_settings = { address: 'mailhost.synopsys.com',
+                                          openssl_verify_mode: OpenSSL::SSL::VERIFY_NONE }
+
+   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to","This should remain as mailrelay.blackducksoftware.com for staging. Not sure this will be valid, but it shouldn't go through the production mail server."
+5097,"@@ -74,6 +74,9 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure
+         /// </summary>
+         public MemoryPoolBlock2 Next { get; set; }
+
++#if DEBUG
++        // See http://www.philosophicalgeek.com/2014/09/29/digging-into-net-object-allocation-fundamentals/
++        // for the cost of including a finalizer
+         ~MemoryPoolBlock2()
+         {
+             Debug.Assert(!_pinHandle.IsAllocated, ""Ad-hoc memory block wasn't unpinned"");",Maybe we should have a Debug.Assert for when `Slab != null` to ensure that we are always returning the block (in our tests at least).
+5098,"@@ -106,10 +106,9 @@ options.vnode = vnode => {
+ 	if (typeof type != 'function') {
+ 		// Apply defaultValue to value
+ 		if (props.defaultValue) {
+-			if (!props.value && props.value !== 0) {
++			if (props.value == null && props.value !== 0) {
+ 				props.value = props.defaultValue;
+ 			}
+-			delete props.defaultValue;
+ 		}
+
+ 		// Add support for array select values: <select value={[]} />","Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defaultValue) In the case of uncontrolled we shouldn't enter this branch at all and go for full native dom behavior"
+5099,"@@ -25,9 +25,12 @@ import { getTimeInSeconds, numberFormat } from 'GoogleUtil';
+ import { getDataTableFromData, TableOverflowContainer } from 'GoogleComponents/data-table';
+ import PreviewTable from 'GoogleComponents/preview-table';
+
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class SearchConsoleDashboardWidgetKeywordTable extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies
+5100,"@@ -58,12 +58,13 @@ const (
+ type LabelSelector string
+
+ const (
+-	MayaAPIServerLabelSelector           LabelSelector = ""name=maya-apiserver""
+-	OpenEBSProvisionerLabelSelector      LabelSelector = ""name=openebs-provisioner""
+-	OpenEBSSnapshotOperatorLabelSelector LabelSelector = ""name=openebs-snapshot-operator""
+-	OpenEBSAdmissionServerLabelSelector  LabelSelector = ""app=admission-webhook""
+-	OpenEBSNDMLabelSelector              LabelSelector = ""name=openebs-ndm""
+-	OpenEBSCStorPoolLabelSelector        LabelSelector = ""app=cstor-pool""
++	MayaAPIServerLabelSelector             LabelSelector = ""name=maya-apiserver""
++	OpenEBSProvisionerLabelSelector        LabelSelector = ""name=openebs-provisioner""
++	OpenEBSLocalPVProvisionerLabelSelector LabelSelector = ""name=openebs-localpv-provisioner""
++	OpenEBSSnapshotOperatorLabelSelector   LabelSelector = ""name=openebs-snapshot-operator""
++	OpenEBSAdmissionServerLabelSelector    LabelSelector = ""app=admission-webhook""
++	OpenEBSNDMLabelSelector                LabelSelector = ""name=openebs-ndm""
++	OpenEBSCStorPoolLabelSelector          LabelSelector = ""app=cstor-pool""
+ )
+
+ func parseK8sYaml(yamls string) (k8s.UnstructedList, []error) {",The latest yaml in openebs/master has changed to name=admission-webhook. cc: @prateekpandey14
+5101,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-send-message.rb demonstrates how to send a message using the Amazon Simple Notification Services (SNS) topic using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",using **an** Amazon Simple... Simple Notification **Service** (singular)
+5102,"@@ -55,7 +55,7 @@ void CHECK_RGROUP(RGroupRows::const_iterator &it, std::string expected,
+   }
+   std::string result = str.str();
+
+-  if (expected != result) {
++  if (1 || expected != result) {
+     std::cerr << ""Expected: "" << expected << std::endl;
+     std::cerr << ""Got:      "" << result << std::endl;
+   }",Probably don't intend for this `1 ||` to still be here
+5103,"@@ -353,14 +353,6 @@ bool cvdescriptorset::ValidateDescriptorSetLayoutCreateInfo(
+             VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME);
+     }
+
+-    const bool host_only_pool_set = static_cast<bool>(create_info->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE);
+-    if (push_descriptor_set && host_only_pool_set) {
+-        skip |= val_obj->LogError(val_obj->device, ""VUID-VkDescriptorSetLayoutCreateInfo-flags-04590"",
+-                                  ""vkCreateDescriptorSetLayout(): pCreateInfo->flags cannot contain both ""
+-                                  ""VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR and ""
+-                                  ""VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE."");
+-    }
+-
+     const bool update_after_bind_set = !!(create_info->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT);
+     if (update_after_bind_set && !descriptor_indexing_ext) {
+         skip |= val_obj->LogError(",Looks like this is failing to compile on Windows (VS 2015 I think).
+5104,"@@ -91,6 +91,15 @@ func (q *Query) Limit(n int) *Query {
+ 	return q
+ }
+
++// BeforeQuery takes a callback function that will be called before the Query is
++// executed to the underlying provider's query functionality. The callback takes
++// a parameter, asFunc, that converts its argument to provider-specific types.
++// See https://godoc.org/gocloud.dev#hdr-As for background information.
++func (q *Query) BeforeQuery(beforeQuery func(asFunc func(interface{}) bool) error) *Query {
++	q.dq.BeforeQuery = beforeQuery
++	return q
++}
++
+ // Get returns an iterator for retrieving the documents specified by the query. If
+ // field paths are provided, only those paths are set in the resulting documents.
+ //","nit: call the arg something simple like `f` to avoid repeating ""beforeQuery""."
+5105,"@@ -18,8 +18,15 @@ package auth
+
+ import (
+ 	""context""
++
++	""github.com/libopenstorage/openstorage/pkg/correlation""
+ )
+
++func init() {
++	correlation.RegisterComponent(""auth"")
++	correlation.RegisterGlobalHook()
++}
++
+ const (
+ 	systemGuestRoleName = ""system.guest""
+ )",do you think this should be `osd/auth` as a pkg to make it more unique and void conflicts with other `auth` packages?
+5106,"@@ -36,10 +36,12 @@ namespace Microsoft.DotNet.Build.Tasks
+
+         public bool DebugOnly { get; set; }
+
++        [Output]
++        public string Message { get; set; }
++
+         public override bool Execute()
+         {
+-            bool result = true;
+-
++            Message = """";
+             try
+             {
+                 using (_resxReader = new ResXResourceReader(ResxFilePath))",Why are you passing out the Message?
+5107,"@@ -135,8 +135,8 @@ func (p *Provider) RegisterSpanProcessor(s SpanProcessor) {
+
+ // UnregisterSpanProcessor removes the given SpanProcessor from the list of SpanProcessors
+ func (p *Provider) UnregisterSpanProcessor(s SpanProcessor) {
+-	mu.Lock()
+-	defer mu.Unlock()
++	p.mu.Lock()
++	defer p.mu.Unlock()
+ 	new := make(spanProcessorMap)
+ 	if old, ok := p.spanProcessors.Load().(spanProcessorMap); ok {
+ 		for k, v := range old {","Yikes, this was a bug :grimacing:"
+5108,"@@ -58,7 +58,7 @@ func (h *Handler) FetchX509SVID(_ *workload.X509SVIDRequest, stream workload.Spi
+
+ 	selectors := attestor.New(&config).Attest(pid)
+
+-	subscriber := h.Manager.Subscribe(selectors)
++	subscriber := h.Manager.NewSubscriber(selectors)
+ 	defer subscriber.Finish()
+
+ 	for {","I am not sure which one of these is considered idiomatic go... maybe @azdagron has an opinion here? /me prefers the verb since it's shorter. I guess I don't care _too_ much, but it would be good to get some general agreement so we are all following the same conventions"
+5109,"@@ -62,9 +62,7 @@ var LocalDevSequelproCmd = &cobra.Command{
+ 			""root"", //dbuser
+ 		))
+
+-		if scaffold != true {
+-			exec.Command(""open"", tmpFilePath).Run()
+-		}
++		exec.Command(""open"", tmpFilePath).Run()
+
+ 		color.Cyan(""sequelpro command finished successfully!"")
+ ","Please check this for error and emit appropriate debugging information. I know this was pre-existing code, but we just have to fix things like this as we go."
+5110,"@@ -140,7 +140,7 @@ func InitialURL(c client.Client, cd *hivev1.ClusterDeployment) (string, error) {
+ // the ClusterDeployment to determine if the remote cluster is reachable.
+ func Unreachable(cd *hivev1.ClusterDeployment) (unreachable bool, lastCheck time.Time) {
+ 	cond := utils.FindClusterDeploymentCondition(cd.Status.Conditions, hivev1.UnreachableCondition)
+-	if cond.Status == corev1.ConditionUnknown {
++	if cond == nil || cond.Status == corev1.ConditionUnknown {
+ 		unreachable = true
+ 		return
+ 	}","This seems unrelated, should be a separate PR."
+5111,"@@ -20,6 +20,7 @@
+ //--
+
+ #include ""algorithms/engines/mt2203/mt2203.h""
++#include ""../engine_create_dispatcher.h""
+ #include ""mt2203_batch_impl.h""
+
+ namespace daal","Never use relative includes, prefer full path"
+5112,"@@ -397,6 +397,17 @@ class TestArgument:
+
+         assert str(excinfo.value) == ""Argument marked as both count/win_id!""
+
++    def test_zero_count_and_zero_count_arg(self):
++        with pytest.raises(TypeError) as excinfo:
++            @cmdutils.argument('arg', count=False,
++             zero_count=True)
++            def fun(arg=0):
++                """"""Blah.""""""
++                pass
++
++        assert str(excinfo.value) == (""Zero_count Argument"" +
++                 "" cannot exist without count!"")
++
+     def test_no_docstring(self, caplog):
+         with caplog.at_level(logging.WARNING):
+             @cmdutils.register()","This should fit on the line above without going over the 79-char limit, no?"
+5113,"@@ -22,7 +22,6 @@ describe VideosController do
+       user = create(:subscriber)
+       video = create(:video)
+       create(:license, user: user, licenseable: video.watchable)
+-      controller.stubs(:signed_in?).returns(true)
+       stub_current_user_with(user)
+
+       get :show, id: video",Is this related to the other contents of this pull request?
+5114,"@@ -356,6 +356,7 @@ type WorkloadOpts struct {
+ 	Aliases                  []string
+ 	Tags                     map[string]string        // Used by App Runner workloads to tag App Runner service resources
+ 	NestedStack              *WorkloadNestedStackOpts // Outputs from nested stacks such as the addons stack.
++	AddonsExtraParams        string                   // Additional user defined Parameters for the addons stack.
+ 	Sidecars                 []*SidecarOpts
+ 	LogConfig                *LogConfigOpts
+ 	Autoscaling              *AutoscalingOpts",Should this be `*string`?
+5115,"@@ -51,16 +51,7 @@ var _ = Context(""etcd connection interruption"", func() {
+
+ 	BeforeEach(func() {
+ 		felixes, etcd, client = infrastructure.StartNNodeEtcdTopology(2, infrastructure.DefaultTopologyOptions())
+-
+-		// Install a default profile that allows all ingress and egress, in the absence of any Policy.
+-		defaultProfile := api.NewProfile()
+-		defaultProfile.Name = ""default""
+-		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.Egress = []api.Rule{{Action: api.Allow}}
+-		defaultProfile.Spec.Ingress = []api.Rule{{Action: api.Allow}}
+-		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+-		Expect(err).NotTo(HaveOccurred())
+-
++		infrastructure.CreateDefaultProfile(client, ""default"", map[string]string{""default"": """"}, """")
+ 		// Wait until the tunl0 device appears; it is created when felix inserts the ipip module
+ 		// into the kernel.
+ 		Eventually(func() error {","In the old code here there was no Source Selector, but CreateDefaultProfile will specify a Source Selector of `""""`. Is that equivalent?"
+5116,"@@ -8,10 +8,12 @@ module RSpec
+         # Temporarily support old and new APIs while we transition the other
+         # rspec libs to use a hash for the 2nd arg and no version arg
+         data = Hash === replacement_or_hash ? replacement_or_hash : { :replacement => replacement_or_hash }
++        call_site = caller.find { |line| line !~ %r{/lib/rspec/(core|mocks|expectations|matchers|rails)/} }
++
+         RSpec.configuration.reporter.deprecation(
+           {
+             :deprecated => deprecated,
+-            :call_site => caller(0)[2]
++            :call_site => call_site
+           }.merge(data)
+         )
+       end",We should pick this across for all our deprecation specs
+5117,"@@ -45,8 +45,8 @@ func init() {
+ }
+
+ var (
+-	kindBinary      = flag.String(""kindBinary"", ""kind"", ""path to the kind binary"")
+-	managerImageTar = flag.String(""managerImageTar"", """", ""a script to load the manager Docker image into Docker"")
++	kindBinary    = flag.String(""kindBinary"", ""kind"", ""path to the kind binary"")
++	kubectlBinary = flag.String(""kubectlBinary"", ""kubectl"", ""path to the kubectl binary"")
+ )
+
+ // Cluster represents the running state of a KIND cluster.","Longer term, I think it could be valuable to move this to cluster-api, and then other repos could take advantage of this as well."
+5118,"@@ -1416,7 +1416,7 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
+ 								if testOpts.connTimeEnabled {
+ 									Skip(""FIXME externalClient also does conntime balancing"")
+ 								}
+-
++								externalClient.EnsureBinary(""test-connection"")
+ 								cc.ExpectSome(externalClient, TargetIP(felixes[1].IP), npPort)
+ 								cc.CheckConnectivity()
+ 							})",Is this a related change?
+5119,"@@ -400,6 +400,12 @@ func (a *Actuator) Update(ctx context.Context, cluster *clusterv1.Cluster, machi
+ 		return errors.Errorf(""failed to ensure tags: %+v"", err)
+ 	}
+
++	scope.MachineStatus.InstanceState = &instanceDescription.State
++
++	if err := a.reconcileLBAttachment(scope, machine, instanceDescription); err != nil {
++		return errors.Errorf(""failed to reconcile load balancer attachment: %+v"", err)
++	}
++
+ 	return nil
+ }
+ ","Given that this is repeated, can we do it outside here and the Create call, what do you think about moving it outside?"
+5120,"@@ -44,6 +44,10 @@ function UndoRedo(instance) {
+       return;
+     }
+
++    arrayEach(changes, (change) => {
++      change[1] = instance.propToCol(change[1]);
++    });
++
+     const selected = changesLen > 1 ? this.getSelected() : [[changes[0][0], changes[0][1]]];
+
+     plugin.done(new UndoRedo.ChangeAction(changes, selected));",Changing `prop`=>`col` by reference?   I think you can prepare map `prop`=>`col` in L51.
+5121,"@@ -106,6 +106,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --grpc             Generate GRPC interfaces for the specified languages\n""
+     ""  --schema           Serialize schemas instead of JSON (use with -b)\n""
+     ""  --bfbs-comments    Add doc comments to the binary schema files.\n""
++    ""  --bfbs-builtin-attrs  Add builtin attributes to the binary schema files.\n""
+     ""  --conform FILE     Specify a schema the following schemas should be\n""
+     ""                     an evolution of. Gives errors if not.\n""
+     ""  --conform-includes Include path for the schema given with --conform\n""","I hate to ask, but can we make this flag shorter so it lines up? :("
+5122,"@@ -19,9 +19,9 @@ import (
+ 	appsv1 ""k8s.io/api/apps/v1""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	apiextv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+-	""k8s.io/apimachinery/pkg/api/errors""
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/apimachinery/pkg/apis/meta/v1/unstructured""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/types""
+ 	""k8s.io/client-go/discovery""","Note to reviewers: latent, dedup import"
+5123,"@@ -20,3 +20,18 @@ package agent
+ func (i *Initializer) setupExternalConnectivity() error {
+ 	return nil
+ }
++
++// prepareHostNetwork returns immediately on Linux.
++func (i *Initializer) prepareHostNetwork() error {
++	return nil
++}
++
++// prepareOVSBridge returns immediately on Linux.
++func (i *Initializer) prepareOVSBridge() error {
++	return nil
++}
++
++// initHostNetworkFlows returns immediately on Linux.
++func (i *Initializer) initHostNetworkFlows() error {
++	return nil
++}",Seems this func is no more needed after your refactoring.
+5124,"@@ -67,6 +67,7 @@ public class MemoryUsage {
+             Tuple.of(""^java\\."", ""Java mutable @ ""),
+             Tuple.of(""^fj\\."", ""Functional Java persistent @ ""),
+             Tuple.of(""^org\\.pcollections"", ""PCollections persistent @ ""),
++            Tuple.of(""^io\\.usethesource"", ""Steindorfer persistent @ ""),
+             Tuple.of(""^org\\.eclipse\\.collections"", ""Eclipse Collections persistent @ ""),
+             Tuple.of(""^clojure\\."", ""Clojure persistent @ ""),
+             Tuple.of(""^scalaz\\.Heap"", ""Scalaz persistent @ ""),",already added (see several rows below)
+5125,"@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti
+ 	epType := tc.EpTypeHost
+ 	if ifaceName == ""tunl0"" {
+ 		epType = tc.EpTypeTunnel
++	} else if ifaceName == ""wireguard.cali"" {
++		epType = tc.EpTypeWireguard
+ 	}
+ 	ap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)
+ 	ap.HostIP = m.hostIP",nit: a switch perhaps?
+5126,"@@ -170,7 +170,7 @@ func (c *workflowSizeChecker) failWorkflowSizeExceedsLimit() (bool, error) {
+ 			tag.WorkflowEventCount(historyCount))
+
+ 		attributes := &decisionpb.FailWorkflowExecutionDecisionAttributes{
+-			Failure: failure.NewServerFailure(common.FailureReasonSizeExceedsLimit, false),
++			Failure: failure.NewServerFailure(common.FailureReasonSizeExceedsLimit, true),
+ 		}
+
+ 		if _, err := c.mutableState.AddFailWorkflowEvent(c.completedID, enumspb.RETRY_STATUS_NON_RETRYABLE_FAILURE, attributes); err != nil {",Great you caught this. Super critical to not retry these errors.
+5127,"@@ -77,7 +77,7 @@ enum CoreAdminOperation implements CoreAdminOp {
+     String coreName = params.required().get(CoreAdminParams.NAME);
+     Map<String, String> coreParams = buildCoreParams(params);
+     CoreContainer coreContainer = it.handler.coreContainer;
+-    Path instancePath = coreContainer.getCoreRootDirectory().resolve(coreName);
++    Path instancePath;
+
+     // TODO: Should we nuke setting odd instance paths?  They break core discovery, generally
+     String instanceDir = it.req.getParams().get(CoreAdminParams.INSTANCE_DIR);","Just a little change to make the var effectively final, which is clearer."
+5128,"@@ -30,8 +30,8 @@ def flowdetails(state, flow: http.HTTPFlow):
+     if sc is not None:
+         text.append(urwid.Text([(""head"", ""Server Connection:"")]))
+         parts = [
+-            [""Address"", ""{}:{}"".format(sc.address[0], sc.address[1])],
+-            [""Resolved Address"", ""{}:{}"".format(sc.ip_address[0], sc.ip_address[1])],
++            [""Address"", ""{}"".format(human.format_address(sc.address))],
++            [""Resolved Address"", ""{}"".format(human.format_address(sc.ip_address))],
+         ]
+         if resp:
+             parts.append([""HTTP Version"", resp.http_version])","Using `""{}"".format(...)` is a bit beside the point...  "
+5129,"@@ -149,8 +149,8 @@ class JsonFormatterTest(unittest.TestCase):
+     def test_logger_name(self):
+         JsonLogFormatter.init_from_settings({""project_name"": ""kintowe""})
+         f = JsonLogFormatter()
+-        record = logging.LogRecord(""app.log"", logging.DEBUG, """", 0, ""coucou"", (), None)
+-        result = f.format(record)
++        obj = logging.LogRecord(""app.log"", logging.DEBUG, """", 0, ""coucou"", (), None)
++        result = f.format(obj)
+         logged = json.loads(result)
+         self.assertEqual(logged[""Logger""], ""kintowe"")
+         self.assertEqual(logged[""Type""], ""app.log"")",I think these should remain as they are.
+5130,"@@ -14,6 +14,8 @@ module Beaker
+     WINDOWS_PACKAGES = ['curl']
+     SLES_PACKAGES = ['curl', 'ntp']
+     DEBIAN_PACKAGES = ['curl', 'ntpdate', 'lsb-release']
++    # Packages added at runtime
++    @@additional_pkgs = []
+     ETC_HOSTS_PATH = ""/etc/hosts""
+     ETC_HOSTS_PATH_SOLARIS = ""/etc/inet/hosts""
+     ROOT_KEYS_SCRIPT = ""https://raw.githubusercontent.com/puppetlabs/puppetlabs-sshkeys/master/templates/scripts/manage_root_authorized_keys""","Let's just call this PERF_PACKAGES and have them in the same format as WINDOWS/SLES/DEBIAN_PACKAGES constants - since it is only a single package and, as written, you'd have to update the code to add more package names anyway. Might as well be consistent with the rest of the code."
+5131,"@@ -224,6 +224,18 @@ String getTaskValueName(taskIndex_t TaskIndex, uint8_t TaskValueIndex) {
+   return ExtraTaskSettings.TaskDeviceValueNames[TaskValueIndex];
+ }
+
++/*********************************************************************************************
++ * get the taskPluginID with required checks, INVALID_PLUGIN_ID when invalid
++ ********************************************************************************************/
++pluginID_t getTaskDevicePluginID(taskIndex_t TaskIndex) {
++  if (validTaskIndex(TaskIndex)) {
++    const deviceIndex_t DeviceIndex = getDeviceIndex_from_TaskIndex(TaskIndex);
++
++    return (validDeviceIndex(DeviceIndex) ? Device[DeviceIndex].Number : INVALID_PLUGIN_ID);
++  }
++  return INVALID_PLUGIN_ID;
++}
++
+ /********************************************************************************************\
+    If RX and TX tied together, perform emergency reset to get the system out of boot loops
+  \*********************************************************************************************/",We don't have a `getPluginIDfromTaskIndex` function? I think it should be implemented in Globals/Plugins.h / .cpp
+5132,"@@ -910,8 +910,12 @@ public class QueryComponent extends SearchComponent
+         additionalAdded = addFL(additionalFL, ""score"", additionalAdded);
+       }
+     } else {
+-      // reset so that only unique key is requested in shard requests
+-      sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());
++      if (rb.req.getSearcher().enableLazyFieldLoading) {
++        // reset so that only unique key is requested in shard requests
++        sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());
++      } else {
++        sreq.params.set(CommonParams.FL, ""*"");
++      }
+       if (shardQueryIncludeScore) {
+         additionalAdded = addFL(additionalFL, ""score"", additionalAdded);
+       }","@shalinmangar If lazy field loading isn't enabled, I don't think this actually changes the behavior of `SolrIndexSearcher`, since it was previously ignoring the fields list anyway. What it _should_ do is allow certain distributed queries, like the ones in `DistribJoinFromCollectionTest`, to co-exist with `SolrIndexSearcher#doc()` respecting the `fields` set instead of just discarding it."
+5133,"@@ -5,7 +5,7 @@ package ddevapp
+ const DDevComposeTemplate = `version: '2'
+
+ services:
+-  {{ .plugin }}-{{.name }}-db:
++  db:
+     container_name: {{ .plugin }}-${DDEV_SITENAME}-db
+     image: $DDEV_DBIMAGE
+     volumes:",Should we be using version 3 now?
+5134,"@@ -24,7 +24,11 @@ class PluginListFactory
+
+     public function __invoke(string $current_dir, ?string $config_file_path = null): PluginList
+     {
+-        $config_file = new ConfigFile($current_dir, $config_file_path);
++        try {
++            $config_file = new ConfigFile($current_dir, $config_file_path);
++        } catch (\RuntimeException $exception) {
++            $config_file = null;
++        }
+         $composer_lock = new ComposerLock($this->findLockFiles());
+
+         return new PluginList($config_file, $composer_lock);","Would be better to throw a more specific exception, but for now it will do."
+5135,"@@ -17,8 +17,6 @@ package org.hyperledger.besu.tests.acceptance.dsl.blockchain;
+ import static org.web3j.utils.Convert.Unit.ETHER;
+ import static org.web3j.utils.Convert.Unit.WEI;
+
+-import org.hyperledger.besu.ethereum.core.Wei;
+-
+ import java.math.BigDecimal;
+ import java.math.BigInteger;
+ ",We should not replace Wei with a type that is shared across multiple units. We need this as `Wei` for type and unit safety.
+5136,"@@ -653,8 +653,7 @@ func drupalEnsureWritePerms(app *DdevApp) error {
+
+ 	for _, o := range makeWritable {
+ 		stat, err := os.Stat(o)
+-		// If the file doesn't exist, don't try to set the permissions.
+-		if os.IsNotExist(err) {
++		if err != nil {
+ 			continue
+ 		}
+ ","I'm pretty sure this should emit a util.Warning*(), since we're skipping by here and never hitting anything that will give them a warning about what's happened."
+5137,"@@ -23,6 +23,12 @@ type aspParser struct {
+
+ // newAspParser creates and returns a new asp.Parser.
+ func newAspParser(state *core.BuildState) *asp.Parser {
++	p := GetParserWithBuiltins(state)
++	return p
++}
++
++// GetParserWithBuiltins returns a asp.Parser object with all the builtins loaded
++func GetParserWithBuiltins(state *core.BuildState) *asp.Parser {
+ 	p := asp.NewParser(state)
+ 	log.Debug(""Loading built-in build rules..."")
+ 	dir, _ := rules.AssetDir("""")",This function isn't useful? it's just a clone of GetParserWithBuiltins?
+5138,"@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
+
+     useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    isCpuCircuitBreakerEnabled = getBool(""circuitBreaker/isCpuCircuitBreakerEnabled"", false);
++    isMemoryCircuitBreakerEnabled = getBool(""circuitBreaker/isMemoryCircuitBreakerEnabled"", false);
+     memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 95);
+
+-    validateMemoryBreakerThreshold();
++    cpuCircuitBreakerThreshold = getInt(""circuitBreaker/cpuCircuitBreakerThreshold"", 95);
++
++    validateCircuitBreakerThresholds();
+
+     filterCacheConfig = CacheConfig.getConfig(this, ""query/filterCache"");
+     queryResultCacheConfig = CacheConfig.getConfig(this, ""query/queryResultCache"");","I'm not sure if the boolean flags should always contain `is`, also I generally hate too long names... ;) we already know this is a section for circuit breakers, so the name doesn't have to repeat all of it. How about `cpuBreakerEnabled`, `memoryBreakerEnabled` etc?"
+5139,"@@ -42,4 +42,13 @@ public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+    * @return this for method chaining
+    */
+   RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile> filesToAdd);
++
++  /**
++   * Add a rewrite that replaces one set of deletes with another that contains the same deleted rows.
++   *
++   * @param deletesToDelete files that will be replaced, cannot be null or empty.
++   * @param deletesToAdd files that will be added, cannot be null or empty.
++   * @return this for method chaining
++   */
++  RewriteFiles rewriteDeletes(Set<DeleteFile> deletesToDelete, Set<DeleteFile> deletesToAdd);
+ }","Before we start the replacing equality deletes with position deletes, I think we need to refactor the RewriteFiles API to adjust more cases: 1. Rewrite data files and remove all the delete rows. The files to delete will be a set of data files and a set of delete files, and the files to add will be a set of data files. 2. Replace equality deletes with position deletes, the files to delete will be a set of equality delete files (we will need to ensure that all delete files are equality delete files ? ) , the files to add will be a set of position delete files. 3. Merging small delete files into a bigger delete files. The files to delete will be a set of equality/position delete files, the files to add will be a set of equality/position delete files."
+5140,"@@ -9,10 +9,16 @@ module Blacklight::BlacklightHelperBehavior
+   ##
+   # Get the name of this application from an i18n string
+   # key: blacklight.application_name
++  # Try first in the current locale, then the default locale
+   #
+   # @return [String] the application name
+   def application_name
+-    t('blacklight.application_name')
++    # It's important that we don't use ActionView::Helpers::CacheHelper#cache here
++    # because it returns nil.
++    Rails.cache.fetch 'blacklight/application_name' do
++      t('blacklight.application_name',
++        default: t('blacklight.application_name', locale: I18n.default_locale))
++    end
+   end
+
+   ##",Layout/TrailingWhitespace: Trailing whitespace detected.
+5141,"@@ -80,8 +80,12 @@ public class LibraryManager {
+         List<ShortcutCategoryDTO> shortcuts = new ArrayList<>();
+         for (Map.Entry<String, List<ShortcutDTO>> entry : categoryMap.entrySet()) {
+             entry.getValue().sort(ShortcutDTO.nameComparator());
+-            ShortcutCategoryDTO category = new ShortcutCategoryDTO.Builder().withId(entry.getKey())
+-                    .withName(entry.getKey()).withShortcuts(entry.getValue()).build();
++            ShortcutCategoryDTO category = new ShortcutCategoryDTO.Builder()
++                    .withId(entry.getKey())
++                    .withName(entry.getKey())
++                    .withShortcuts(entry.getValue())
++                    .withIcon(entry.getValue().get(0).getCategoryIcon()) // choose one category icon
++                    .build();
+             shortcuts.add(tr(category));
+         }
+ ",Is it possible that the shortcuts list is empty?
+5142,"@@ -692,6 +692,10 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
+ 		p.V(""start backup on %v"", targets)
+ 	}
+ 	_, id, err := arch.Snapshot(gopts.ctx, targets, snapshotOpts)
++	if errors.Cause(err) == context.Canceled {
++		return errors.Fatal(""canceled"")
++	}
++
+ 	if err != nil {
+ 		return errors.Fatalf(""unable to save snapshot: %v"", err)
+ 	}",This just changes the error message from `unable to save snapshot: [...] context canceled` to `canceled`.
+5143,"@@ -141,7 +141,9 @@ public abstract class AbstractRestInvocation {
+     if (response.getHeaders().getHeaderMap() != null) {
+       for (Entry<String, List<Object>> entry : response.getHeaders().getHeaderMap().entrySet()) {
+         for (Object value : entry.getValue()) {
+-          responseEx.addHeader(entry.getKey(), String.valueOf(value));
++          if (!entry.getKey().equalsIgnoreCase(HttpHeaders.CONTENT_LENGTH)) {
++            responseEx.addHeader(entry.getKey(), String.valueOf(value));
++          }
+         }
+       }
+     }",maybe it's better to remove HttpHeaders.CONTENT_LENGTH after the loop
+5144,"@@ -679,6 +679,12 @@ public interface List<T> extends LinearSeq<T>, Stack<T> {
+
+     @Override
+     default List<T> dropRight(int n) {
++        if (n <= 0) {
++            return this;
++        }
++        if (n >= length()) {
++            return empty();
++        }
+         return reverse().drop(n).reverse();
+     }
+ ",Very cool. We are now collecting the fruits after your length implementation!
+5145,"@@ -0,0 +1,8 @@
++rules:
++  - name: all pubs are in whitelist
++    project: '*'
++    network: '*'
++    is_external_network: True
++    whitelist:
++      - xpn-master:xpn-network
++      - content-insights:default","Is this the same copy of the rules file from above? If so, can just use the copy from above, and this can be dropped."
+5146,"@@ -264,6 +264,13 @@ func (acsSession *session) startACSSession(client wsclient.ClientServer, timer t
+
+ 	client.AddRequestHandler(refreshCredsHandler.handlerFunc())
+
++	// Add handler to ack ENI attach message
++	eniAttachHandler := newAttachENIHandler(acsSession.ctx, cfg.Cluster, acsSession.containerInstanceARN, client, acsSession.taskEngine, acsSession.stateManager)
++	eniAttachHandler.start()
++	defer eniAttachHandler.stop()
++
++	client.AddRequestHandler(eniAttachHandler.handlerFunc())
++
+ 	// Add request handler for handling payload messages from ACS
+ 	payloadHandler := newPayloadRequestHandler(
+ 		acsSession.ctx,",Please break this into multiple lines.
+5147,"@@ -120,7 +120,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+                 {
+                     scope.Span.SetHeaderTags<IHeadersCollection>(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTags, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
+                 }
+-
++                HttpContextHelpers.AddHeaderTagsFromHttpResponse(httpContext, scope);
+                 scope.Span.SetHttpStatusCode(responseMessage.DuckCast<HttpResponseMessageStruct>().StatusCode, isServer: true);
+                 scope.Dispose();
+             }",Shouldn't this new line replace the few lines above?
+5148,"@@ -2,9 +2,9 @@ package options
+
+ import (
+ 	""github.com/influxdata/flux""
+-	""github.com/influxdata/flux/functions/transformations""
++	""github.com/influxdata/flux/stdlib/universe""
+ )
+
+ func init() {
+-	flux.RegisterBuiltInOption(""now"", transformations.SystemTime())
++	flux.RegisterBuiltInOption(""now"", universe.SystemTime())
+ }",Perhaps this belongs in universe?
+5149,"@@ -25,8 +25,11 @@ std::chrono::duration<double, std::milli> hist_time;
+ std::chrono::duration<double, std::milli> find_split_time;
+ std::chrono::duration<double, std::milli> split_time;
+ std::chrono::duration<double, std::milli> ordered_bin_time;
++std::chrono::duration<double, std::milli> refit_leaves_time;
+ #endif  // TIMETAG
+
++double EPS = 1e-12;
++
+ SerialTreeLearner::SerialTreeLearner(const Config* config)
+   :config_(config) {
+   random_ = Random(config_->feature_fraction_seed);",there is a `kEpsilon` you can use directly.
+5150,"@@ -17,9 +17,10 @@ limitations under the License.
+ package ec2
+
+ import (
+-	""sigs.k8s.io/cluster-api/util/conditions""
+ 	""strings""
+
++	""sigs.k8s.io/cluster-api/util/conditions""
++
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/awserrors""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/wait""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/record""","This should be grouped with the below imports, and the two separate groups of imports below should likely also be grouped together"
+5151,"@@ -888,11 +888,11 @@ void cvdescriptorset::DescriptorSet::PerformWriteUpdate(const VkWriteDescriptorS
+ }
+ // Validate Copy update
+ bool cvdescriptorset::DescriptorSet::ValidateCopyUpdate(const debug_report_data *report_data, const VkCopyDescriptorSet *update,
+-                                                        const DescriptorSet *src_set, std::string *error_code,
++                                                        const DescriptorSet *src_set, std::string &error_code,
+                                                         std::string *error_msg) {
+     // Verify dst layout still valid
+     if (p_layout_->IsDestroyed()) {
+-        *error_code = ""VUID-VkCopyDescriptorSet-dstSet-parameter"";
++        error_code = ""VUID-VkCopyDescriptorSet-dstSet-parameter"";
+         string_sprintf(error_msg,
+                        ""Cannot call vkUpdateDescriptorSets() to perform copy update on descriptor set dstSet 0x%"" PRIxLEAST64
+                        "" created with destroyed VkDescriptorSetLayout 0x%"" PRIxLEAST64,","It looks like this error_code field is used to return a string to the caller, not just a const input string to be consumed as in the rest of this PR? If so, my personal preference would be to leave it as a std::string* instead of a reference; I don't know offhand what the VL coding style dictates."
+5152,"@@ -66,6 +66,11 @@ std::string MetaUtils::partVal(const std::vector<nebula::cpp2::HostAddr>& hosts)
+     return val;
+ }
+
++std::string MetaUtils::partPrefix() {
++    static const std::string prefix = kPartsTable;
++    return prefix;
++}
++
+ std::string MetaUtils::partPrefix(GraphSpaceID spaceId) {
+     std::string prefix;
+     static constexpr size_t tableLen = ::strlen(kPartsTable);","If return by value, then why bother to make it `static`?"
+5153,"@@ -369,8 +369,11 @@ def nop():
+
+ @cmdutils.register()
+ @cmdutils.argument('win_id', win_id=True)
+-def version(win_id):
++def version(win_id, paste=False):
+     """"""Show version information.""""""
+     tabbed_browser = objreg.get('tabbed-browser', scope='window',
+                                 window=win_id)
+     tabbed_browser.openurl(QUrl('qute://version'), newtab=True)
++
++    if paste:
++        utils.pastebin_version()","You'll need to add docs for the argument, see e.g. the `debug_log_filter` docstring above."
+5154,"@@ -30,6 +30,7 @@ import (
+ 	""go.opentelemetry.io/otel/codes""
+ 	""go.opentelemetry.io/otel/sdk/instrumentation""
+ 	""go.opentelemetry.io/otel/sdk/resource""
++	sdktrace ""go.opentelemetry.io/otel/sdk/trace""
+ 	tracesdk ""go.opentelemetry.io/otel/sdk/trace""
+ 	""go.opentelemetry.io/otel/semconv""
+ 	""go.opentelemetry.io/otel/trace""","`sdktrace` or `tracesdk`, pick one."
+5155,"@@ -200,11 +200,7 @@ trait ContentMagicTrait
+             }
+         }
+
+-        return [
+-            'filename' => '',
+-            'alt' => '',
+-            'path' => '',
+-        ];
++        return [];
+     }
+
+     /**",can we return null instead?
+5156,"@@ -179,6 +179,12 @@ void exit_event(void)
+     bool success = dr_raw_tls_cfree(tls_offs, NUM_TLS_SLOTS);
+     ASSERT(success);
+     ASSERT(num_lea > 0);
++#ifdef UNIX
++    /* i#2346: delay client threads termination on Windows. */
++    dr_fprintf(STDERR, ""process is exiting\n"");
++    dr_event_signal(child_continue);
++    dr_event_wait(child_dead);
++#endif
+     /* DR should have terminated the client thread for us */
+     dr_event_destroy(child_alive);
+     dr_event_destroy(child_continue);","You mean XXX and ""we should"" or ""NYI"" or sthg. Maybe put it on the ifdef line."
+5157,"@@ -25,3 +25,17 @@ func (w literalLoggable) GetValue(key string) string { return w.strings[key] }
+ func (w literalLoggable) GetValueAsInt64Slice(key string) []int64 { return w.int64s[key] }
+
+ func (w literalLoggable) ReadSerialPortLogs() []string { return w.serials }
++
++// SingleImageImportLoggable returns a Loggable that is pre-initialized with the metadata
++// fields that are relevant when importing a single image file.
++func SingleImageImportLoggable(fileFormat string, sourceSize, resultSize int64, serials []string) Loggable {
++	loggable := literalLoggable{
++		strings: map[string]string{importFileFormat: fileFormat},
++		int64s: map[string][]int64{
++			sourceSizeGb: {sourceSize},
++			targetSizeGb: {resultSize},
++		},
++		serials: serials,
++	}
++	return loggable
++}",minor: can be in-lined in return
+5158,"@@ -14,7 +14,7 @@ module RSpec::Core::Formatters
+         it ""prints a message if provided, ignoring other data"" do
+           formatter.deprecation(:message => ""this message"", :deprecated => ""x"", :replacement => ""y"", :call_site => ""z"")
+           deprecation_stream.rewind
+-          expect(deprecation_stream.read).to eq ""this message""
++          expect(deprecation_stream.read).to eq ""this message\n""
+         end
+
+         it ""includes the method"" do","why the additional ""\n""?"
+5159,"@@ -183,7 +183,7 @@ func (s *streamTable) Do(f func(flux.ColReader) error) error {
+ 	if err := f(s.first); err != nil {
+ 		s.first.Release()
+ 		s.first = nil
+-		return nil
++		return err
+ 	}
+ 	s.first.Release()
+ 	s.first = nil","This seems to be a big omission. If the first buffer reports an error, stream seems to just discard it."
+5160,"@@ -180,9 +180,7 @@ func MakeFull(log logging.Logger, rootDir string, cfg config.Local, phonebookDir
+ 		return nil, err
+ 	}
+
+-	blockListeners := []ledger.BlockListener{
+-		node,
+-	}
++	blockListeners := []ledger.BlockListener{}
+
+ 	if node.config.EnableTopAccountsReporting {
+ 		blockListeners = append(blockListeners, &accountListener)",Maybe move this one down too?
+5161,"@@ -1,12 +1,12 @@
+-using Datadog.Trace.Logging;
++using Datadog.Trace.Logging;
+
+ namespace Datadog.Trace
+ {
+     internal class AsyncLocalScopeManager
+     {
+-        private static ILog _log = LogProvider.For<AsyncLocalScopeManager>();
++        private static readonly ILog _log = LogProvider.For<AsyncLocalScopeManager>();
+
+-        private AsyncLocalCompat<Scope> _currentSpan = new AsyncLocalCompat<Scope>();
++        private readonly AsyncLocalCompat<Scope> _currentSpan = new AsyncLocalCompat<Scope>();
+
+         public Scope Active => _currentSpan.Get();
+ ","We do this in lots of places I'm starting to notice...typically you'd avoid taking concrete dependencies, but we also avoid package dependencies as well which makes sense (i.e. not using an IoC, etc.). Any reason we don't implement some form of poor-man's DI and/or a simple factory instead of new-ing things up everywhere. This may be a simple example (as I'm guessing this is likely the only place this is ever or ever will be used), but separating them doesn't take any more time/effort either really."
+5162,"@@ -77,8 +77,13 @@ func Errf(format string, a ...interface{}) DError {
+ }
+
+ // wrapErrf returns a DError by keeping errors type and replacing original error message.
+-func wrapErrf(e DError, format string, a ...interface{}) DError {
+-	return &dErrImpl{errs: []error{fmt.Errorf(format, a...)}, errsType: e.errorsType(), anonymizedErrs: []string{format}}
++func wrapErrf(e DError, formatPrefix string, a ...interface{}) DError {
++	f := formatPrefix + strings.Join(e.AnonymizedErrs(), ""; "")
++	return &dErrImpl{
++		errs:           []error{fmt.Errorf(fmt.Sprintf(formatPrefix, a...) + e.Error())},
++		errsType:       e.errorsType(),
++		anonymizedErrs: []string{f},
++	}
+ }
+
+ // newErr returns a DError. newErr is used to wrap another error as a DError.",What if formatPrefix doesn't include a space? Will the resulting error have e.Error() stuck at the end without any space?
+5163,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package pushsync provides the pushsync protocol
++// implementation.
+ package pushsync
+
+ import (",that doesn't say a lot to me. Can you please be more specific on the function of pushsync?
+5164,"@@ -1602,6 +1602,15 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+                         }
+                     }
+                 }
++                if (subpass_desc->pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) {
++                    if (pPipeline->graphicsPipelineCI.pDepthStencilState->depthWriteEnable == VK_TRUE) {
++                        skip |= LogError(
++                            device, ""VUID-VkGraphicsPipelineCreateInfo-subpass-04890"",
++                            ""vkCreateGraphicsPipelines(): pCreateInfo[%"" PRIu32
++                            ""]: subpass uses read-only depth aspect layout, but pDepthStencilState->depthWriteEnable is VK_TRUE."",
++                            pipelineIndex);
++                    }
++                }
+             }
+
+             // If subpass uses color attachments, pColorBlendState must be valid pointer",> subpass uses a depth/stencil attachment in renderPass with a read-only layout for the depth aspect Assume - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL count as well seems there is a `NormalizeDepthImageLayout` for this
+5165,"@@ -49,14 +49,14 @@ export function registerDefaults( widgetsAPI ) {
+ 	widgetsAPI.registerWidgetArea( AREA_DASHBOARD_ALL_TRAFFIC, {
+ 		title: __( 'All Traffic', 'google-site-kit' ),
+ 		subtitle: __( 'How people found your site.', 'google-site-kit' ),
+-		style: WIDGET_AREA_STYLES.COMPOSITE,
++		style: WIDGET_AREA_STYLES.BOXES,
+ 		priority: 1,
+ 	}, CONTEXT_DASHBOARD );
+
+ 	widgetsAPI.registerWidgetArea( AREA_DASHBOARD_SEARCH_FUNNEL, {
+ 		title: __( 'Search Funnel', 'google-site-kit' ),
+ 		subtitle: __( 'How your site appeared in Search results and how many visitors you got from Search.', 'google-site-kit' ),
+-		style: WIDGET_AREA_STYLES.COMPOSITE,
++		style: WIDGET_AREA_STYLES.BOXES,
+ 		priority: 2,
+ 	}, CONTEXT_DASHBOARD );
+ ","This shouldn't be altered, you probably meant to update `AREA_PAGE_DASHBOARD_ALL_TRAFFIC` further below :)"
+5166,"@@ -882,7 +882,7 @@ class CmdDockerClient(ContainerClient):
+         if mount_volumes:
+             cmd += [
+                 volume
+-                for host_path, docker_path in mount_volumes
++                for host_path, docker_path in dict(mount_volumes).items()
+                 for volume in [""-v"", f""{host_path}:{docker_path}""]
+             ]
+         if interactive:",what does this change do exactly?
+5167,"@@ -48,7 +48,8 @@ type networkImpl struct {
+ 	proposalCh chan agreement.Message
+ 	bundleCh   chan agreement.Message
+
+-	net network.GossipNode
++	net           network.GossipNode
++	backgroundCtx context.Context
+ }
+
+ // WrapNetwork adapts a network.GossipNode into an agreement.Network.",What's the purpose of this `backgroundCtx` field?
+5168,"@@ -42,7 +42,11 @@ import (
+ // Trie cache generation limit after which to evict trie nodes from memory.
+ var MaxTrieCacheGen = uint32(1024 * 1024)
+
+-const IncarnationLength = 8
++const (
++	IncarnationLength        = 8
++	FirstContractIncarnation = 1
++	AccountIncarnation       = 0
++)
+
+ type StateReader interface {
+ 	ReadAccountData(address common.Address) (*accounts.Account, error)",non contract incarnation
+5169,"@@ -108,10 +108,7 @@ class ErrorHandler(object):
+                         message = value[""value""]
+                         if not isinstance(message, basestring):
+                             value = message
+-                            try:
+-                                message = message['message']
+-                            except TypeError:
+-                                message = None
++                            message = message.get('message', None)
+                     else:
+                         message = value.get('message', None)
+                 except ValueError:",I would recommend to leave out `None` because None is already the default.
+5170,"@@ -90,11 +90,11 @@ func (h *Handler) handleNewStream(s net.Stream) {
+
+ 	switch err := h.processHelloMessage(from, &hello); err {
+ 	case ErrBadGenesis:
+-		log.Warningf(""genesis cid: %s does not match: %s, disconnecting from peer: %s"", &hello.GenesisHash, h.genesis, from)
++		log.Debugf(""genesis cid: %s does not match: %s, disconnecting from peer: %s"", &hello.GenesisHash, h.genesis, from)
+ 		s.Conn().Close() // nolint: errcheck
+ 		return
+ 	case ErrWrongVersion:
+-		log.Warningf(""code not at same version: peer has version %s, daemon has version %s, disconnecting from peer: %s"", hello.CommitSha, h.commitSha, from)
++		log.Debugf(""code not at same version: peer has version %s, daemon has version %s, disconnecting from peer: %s"", hello.CommitSha, h.commitSha, from)
+ 		s.Conn().Close() // nolint: errcheck
+ 		return
+ 	case nil: // ok, noop","Should the ""bad hello message"" case above also disconnect?"
+5171,"@@ -18,6 +18,9 @@ public abstract class InsulinOrefBasePlugin implements PluginBase, InsulinInterf
+
+     public static double MIN_DIA = 5;
+
++    protected static boolean fragmentEnabled = false;
++    protected static boolean fragmentVisible = false;
++
+     long lastWarned = 0;
+
+     @Override",Shouldn't this be in the child and not in the base plugin? Wouldn't having it here enable all derived plugins at once?
+5172,"@@ -226,6 +226,11 @@ FILTERING
+           (options[:full_description] ||= []) << Regexp.compile(Regexp.escape(o))
+         end
+
++        parser.on('-E', '--example-matches STRING', ""Run examples whose full nested names match REGEX (may be"",
++                  ""  used more than once)"") do |o|
++          (options[:full_description] ||= []) << Regexp.compile(o)
++        end
++
+         parser.on('-t', '--tag TAG[:VALUE]',
+                   'Run examples with the specified tag, or exclude examples',
+                   'by adding ~ before the tag.',",Should probably say REGEX or PATTERN rather than string.
+5173,"@@ -179,14 +179,14 @@ func TestHandler(t *testing.T) {
+ 			name:     ""an event with a very large payload"",
+ 			method:   ""POST"",
+ 			path:     ""/ns1/broker1"",
+-			event:    createTestEventWithPayloadSize(""test-event"", 110000000),
++			event:    createTestEventWithPayloadSize(""test-event"", 10000001), // 10Mb + extra byte
+ 			wantCode: nethttp.StatusRequestEntityTooLarge,
+ 		},
+ 		{
+ 			name:          ""malicious requests or requests with unknown Content-Length and a very large payload"",
+ 			method:        ""POST"",
+ 			path:          ""/ns1/broker1"",
+-			event:         createTestEventWithPayloadSize(""test-event"", 110000000),
++			event:         createTestEventWithPayloadSize(""test-event"", 10000001), // 10Mb + extra byte
+ 			contentLength: ptr.Int64(-1),
+ 			wantCode:      nethttp.StatusRequestEntityTooLarge,
+ 		},","I felt we don't need to set it that strict, like if somehow pubsub happens to allow extra 20 bytes for metadata, this test won't work. We would suggest to use 11MB instead."
+5174,"@@ -34,7 +34,7 @@ class AutocompleteTypeConfigurator implements TypeConfiguratorInterface
+         }
+
+         // by default, allow to autocomplete multiple values for OneToMany and ManyToMany associations
+-        if (!isset($options['multiple']) && $metadata['associationType'] & ClassMetadata::TO_MANY) {
++        if (!isset($options['multiple']) && isset($metadata['associationType']) && $metadata['associationType'] & ClassMetadata::TO_MANY) {
+             $options['multiple'] = true;
+         }
+ ","In theory `isset($metadata['associationType'])` is `false` if the linked field is not an association field, isn't?"
+5175,"@@ -84,7 +84,7 @@ Doorkeeper.configure do
+   #
+   # If not specified, Doorkeeper enables all the four grant flows.
+   #
+-  # grant_flows %w(authorization_code implicit password client_credentials)
++  grant_flows %w(authorization_code implicit password client_credentials)
+
+   # Under some circumstances you might want to have applications auto-approved,
+   # so that the user skips the authorization step.",@tute the only thing I needed to enable this like as `password` is not in default flow anymore I think.
+5176,"@@ -52,7 +52,8 @@ class IamPolicyTest(ForsetiTestCase):
+             'serviceAccount:abc@def.gserviceaccount.com',
+             'user:someone@somewhere.tld',
+             'allUsers',
+-            'user:anything'
++            'user:anything',
++            'allAuthenticatedUsers'
+         ]
+
+     # Test IamPolicyMember","nit: to be consistent with `self.members`, please move this up one line, so that it's closer to `allUsers`? You will need to update your test reference."
+5177,"@@ -4,6 +4,7 @@ const config = require('./config')
+ const fs = require('fs-extra')
+
+ const runGClient = (args, options = {}) => {
++  if (options.verbose) args.push('--verbose')
+   options.cwd = options.cwd || config.rootDir
+   options = mergeWithDefault(options)
+   options.env.GCLIENT_FILE = config.gClientFile",we might as well just access `config.gClientVerbose` directly here. If any other options are passed to `gclientSync` or `gclientRunhooks` then the verbose option will be lost the way it's used now
+5178,"@@ -353,6 +353,7 @@ return [
+     'log' => [
+         'menu_label' => 'Log settings',
+         'menu_description' => 'Specify which areas should use logging.',
++        'logging' => 'Logging',
+         'log_events' => 'Log system events',
+         'log_events_comment' => 'Browser requests that may require attention, such as 404 errors.',
+         'log_requests' => 'Log bad requests',",Change the key to `default_tab` instead and I'll merge this
+5179,"@@ -387,8 +387,11 @@ module OrgAdmin
+               end
+             end
+           end
+-        else
+-          # If no funder was selected retrieve the Org's templates
++        end
++
++        # If the no funder was specified OR the funder matches the org
++        if funder_id.blank? || funder_id == org_id
++          # Retrieve the Org's templates
+           templates << Template.organisationally_visible.valid.where(published: true, org_id: org_id, customization_of: nil).to_a
+         end
+         ",we still can end up passing a blank org_id to the scope method if for any reason the params is not present...
+5180,"@@ -236,7 +236,9 @@ public class SaxonXPathRuleQuery extends AbstractXPathRuleQuery {
+         */
+         if (value == null) {
+             return UntypedAtomicValue.ZERO_LENGTH_UNTYPED;
+-
++        } else if (value instanceof Enum) {
++            // enums use their toString
++            return new StringValue(value.toString());
+         } else if (value instanceof String) {
+             return new StringValue((String) value);
+         } else if (value instanceof Boolean) {","I think yes, this makes sense to expose this. +1"
+5181,"@@ -33,7 +33,7 @@ metadata:
+       - name: StorageType
+         value: ""hostpath""
+       - name: BasePath
+-        value: ""/var/openebs/local""
++        value: {{env ""OPENEBS_IO_LOCALPV_HOSTPATH_DIR"" | default ""/var/openebs/local""}}
+ provisioner: openebs.io/local
+ volumeBindingMode: WaitForFirstConsumer
+ reclaimPolicy: Delete",let us put the sample yaml snippet i.e. maya api server deployment that makes use of this env & value
+5182,"@@ -117,12 +117,12 @@ public class ITRabbitMQCollector {
+
+   /** Guards against errors that leak from storage, such as InvalidQueryException */
+   @Test
+-  public void skipsOnSpanConsumerException() throws Exception {
++  public void skipsOnSpanConsumerException() {
+     // TODO: reimplement
+   }
+
+   @Test
+-  public void messagesDistributedAcrossMultipleThreadsSuccessfully() throws Exception {
++  public void messagesDistributedAcrossMultipleThreadsSuccessfully() {
+     // TODO: reimplement
+   }
+ }",What changed to cause this?
+5183,"@@ -81,6 +81,8 @@ func waitForBalanceState(t *testing.T, processor *PromiseProcessor, expectedStat
+
+ type fakeStorage struct{}
+
+-func (fs fakeStorage) Store(issuer string, data interface{}) error  { return nil }
+-func (fs fakeStorage) Delete(issuer string, data interface{}) error { return nil }
+-func (fs fakeStorage) Close() error                                 { return nil }
++func (fs fakeStorage) Store(issuer string, data interface{}) error                         { return nil }
++func (fs fakeStorage) Delete(issuer string, data interface{}) error                        { return nil }
++func (fs fakeStorage) Close() error                                                        { return nil }
++func (fs fakeStorage) StoreSession(bucketName string, key string, value interface{}) error { return nil }
++func (fs fakeStorage) GetAll(issuer string, data interface{}) error                        { return nil }",Repeating big interface in many places shows smtg is wrong with design
+5184,"@@ -0,0 +1,15 @@
++class Accounts::ChartsController < AccountsController
++  include SetAccountByAccountId
++
++  before_action :redirect_if_disabled
++
++  # NOTE: Replaces accounts#commits_history
++  def commits_by_project
++    render json: Chart.new(@account).commits_by_project
++  end
++
++  # NOTE: Replaces accounts#language_experience
++  def commits_by_language
++    render json: Chart.new(@account).commits_by_language(params[:scope])
++  end
++end",Inheriting from `AccountsController` to get access to the `redirect_if_disabled` filter.
+5185,"@@ -1,14 +1,15 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-# SPDX - License - Identifier: Apache - 2.0
++# SPDX-License-Identifier: Apache-2.0
++
++# Purpose
++# This code demonstrates how to copy an object from one Amazon Simple Storage Solution (Amazon S3) bucket to another.
+
+ # snippet-start:[s3.ruby.copy_object_between_buckets.rb]
+ require 'aws-sdk-s3'
+
+-# Copies an object from one Amazon S3 bucket to another.
+-#
+ # Prerequisites:
+ #
+-# - Two S3 buckets (a source bucket and a target bucket).
++# - Two Amazon S3 buckets (a source bucket and a target bucket).
+ # - An object in the source bucket to be copied.
+ #
+ # @param s3_client [Aws::S3::Client] An initialized Amazon S3 client.",Simple Storage **Service**
+5186,"@@ -0,0 +1 @@
++public class A { public int FUNC() { Class<?> cls = null; if(cls == null) return 0; else { B.FUNC3(cls); return 1;} } public void FUNC2(Class<?> arg) { return; }}class B {public static void FUNC3(Class<?> arg) { return; }}",Enter at the end of the file! :-D (and at the end of lines ;-) )
+5187,"@@ -0,0 +1,9 @@
++class RenameScheduledForCancellation < ActiveRecord::Migration
++  def change
++    rename_column(
++      :subscriptions,
++      :scheduled_for_cancellation_on,
++      :scheduled_for_deactivation_on,
++    )
++  end
++end",Put a comma after the last parameter of a multiline method call.
+5188,"@@ -88,7 +88,17 @@ func removeYields(plan *PlanSpec) (*PlanSpec, error) {
+ 			}
+
+ 			newRoot := root.Predecessors()[0]
+-			newRoot.RemoveSuccessor(root)
++			newSucc := make([]PlanNode, 0, len(newRoot.Successors()))
++
++			for _, succ := range newRoot.Successors() {
++				newSucc = append(newSucc, succ)
++				if succ == root {
++					continue
++				}
++			}
++
++			newRoot.ClearSuccessors()
++			newRoot.AddSuccessors(newSucc...)
+ 			plan.Replace(root, newRoot)
+ 			plan.Results[name] = newRoot
+ 			continue",Don't you want to place this check before you add `succ` to `newSucc`?
+5189,"@@ -1,18 +1,6 @@
+ package com.fsck.k9.fragment;
+
+
+-import java.util.ArrayList;
+-import java.util.Collections;
+-import java.util.Comparator;
+-import java.util.EnumMap;
+-import java.util.HashMap;
+-import java.util.HashSet;
+-import java.util.List;
+-import java.util.Map;
+-import java.util.Map.Entry;
+-import java.util.Set;
+-import java.util.concurrent.Future;
+-
+ import android.app.Activity;
+ import android.content.BroadcastReceiver;
+ import android.content.Context;",Commit 676eeeab10884456a5f70ce708a8aa5116ecbaf7 contains a lot of unrelated code style changes. Please get rid of these.
+5190,"@@ -82,7 +82,10 @@ class BokehRenderer(Renderer):
+             if bokeh_version < '0.12.6':
+                 raise RuntimeError('Bokeh png export only supported by versions >=0.12.6.')
+             from bokeh.io import _get_screenshot_as_png
+-            img = _get_screenshot_as_png(plot.state)
++            if bokeh_version > '0.12.6':
++                img = _get_screenshot_as_png(plot.state, None)
++            else:
++                img = _get_screenshot_as_png(plot.state)
+             imgByteArr = BytesIO()
+             img.save(imgByteArr, format='PNG')
+             return imgByteArr.getvalue(), info","Well this sucks, I wish you'd mentioned you were using a private API, perhaps we could have made a public one with better guarantees before `0.12.6` was released."
+5191,"@@ -69,17 +69,10 @@ func New(transport peer.Transport, opts ...ListOption) *List {
+ 			&pendingHeap{},
+ 			plOpts...,
+ 		),
+-		capacity: cfg.capacity,
+ 	}
+ }
+
+ // List is a PeerList which rotates which peers are to be selected in a circle
+ type List struct {
+ 	*peerlist.List
+-	capacity int
+-}
+-
+-// Capacity is the maximum number of peers the peer list will hold.
+-func (l *List) Capacity() int {
+-	return l.capacity
+ }",Consider instead moving this into an _test file so it's public but only usable in tests.
+5192,"@@ -146,10 +146,10 @@ func (s *ec2Ops) waitAttachmentStatus(
+ 	request := &ec2.DescribeVolumesInput{VolumeIds: []*string{&id}}
+ 	actual := """"
+ 	interval := 2 * time.Second
+-	fmt.Printf(""Waiting for state transition to %q"", desired)
++	logrus.Infof(""Waiting for state transition to %q"", desired)
+
+ 	var outVol *ec2.Volume
+-	for elapsed, runs := 0*time.Second, 0; actual != desired && elapsed < timeout; elapsed += interval {
++	for elapsed, runs := 0*time.Second, 0; actual != desired && elapsed < timeout; elapsed, runs = elapsed+interval, runs+1 {
+ 		awsVols, err := s.ec2.DescribeVolumes(request)
+ 		if err != nil {
+ 			return nil, err","Any reason why we want to remove this code ? It helps debugging AWS ebs attach issues. Ideally yes a library should have minimal logging, but there is no way we can track long running AWS attach calls."
+5193,"@@ -87,9 +87,10 @@ func (fs *experimentStore) CreateExperiment(ctx context.Context, config *any.Any
+ 			INSERT INTO experiment_run (
+                 id,
+ 		        experiment_config_id,
+-		        execution_time,
++						execution_time,
++						scheduled_end_time,
+ 		        creation_time)
+-            VALUES ($1, $2, tstzrange($3, $4, '[]'), NOW())`
++            VALUES ($1, $2, tstzrange($3, $4, '[]'), $4, NOW())`
+
+ 	runId := id.NewID()
+ 	_, err = fs.db.ExecContext(ctx, runSql, runId, configID, startTime, endTime)",nit: indentation doesn't match (unfortunately i don't know of a way to automatically lint these sql statements with how we're using them currently)
+5194,"@@ -231,6 +231,7 @@ module RSpec::Core
+       return if @setup
+
+       @setup_default.call
++      setup_profiler
+       @setup = true
+     end
+ ","Should we remove the other `setup_profiler` call site and just let this be the one call site for it, since, AFAIK, the other one is no longer necessary with this? Also, can we make `setup_profiler` private?"
+5195,"@@ -151,7 +151,6 @@ func BuildEnvShowCmd() *cobra.Command {
+ 		GlobalOpts: NewGlobalOpts(),
+ 	}
+ 	cmd := &cobra.Command{
+-		Hidden: true, //TODO remove when ready for production!
+ 		Use:    ""show"",
+ 		Short:  ""Shows info about a deployed environment."",
+ 		Long:   ""Shows info about a deployed environment, including region, account ID, and services."",","Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?"
+5196,"@@ -1,18 +1,3 @@
+ // +build !linux !cgo !seccomp
+
+ package patchbpf
+-
+-import (
+-	""errors""
+-
+-	""github.com/opencontainers/runc/libcontainer/configs""
+-
+-	libseccomp ""github.com/seccomp/libseccomp-golang""
+-)
+-
+-func PatchAndLoad(config *configs.Seccomp, filter *libseccomp.ScmpFilter) error {
+-	if config != nil {
+-		return errors.New(""cannot patch and load seccomp filter without runc seccomp support"")
+-	}
+-	return nil
+-}",perhaps file can be removed altogether (trying to avoid an empty package for these build tags)
+5197,"@@ -980,7 +980,7 @@ get_module_handle_64(const wchar_t *name)
+ {
+     /* Be careful: we can't directly de-ref any ptrs b/c they can be >4GB */
+     LDR_MODULE_64 mod;
+-    if (!get_ldr_module_64(name, NULL, &mod))
++    if (!get_ldr_module_64(name, 0, &mod))
+         return NULL;
+     return mod.BaseAddress;
+ }","NULL change, could you move that out too?"
+5198,"@@ -25,6 +25,10 @@ func formatKV(in []string) string {
+ 	return columnize.Format(in, columnConf)
+ }
+
++func FormatList(in []string) string {
++	return formatList(in)
++}
++
+ // formatList takes a set of strings and formats them into properly
+ // aligned output, replacing any blank fields with a placeholder
+ // for awk-ability.",A brief explanation about this func is required.
+5199,"@@ -32,6 +32,11 @@ class MergedCellsCollection {
+     this.hot = plugin.hot;
+   }
+
++  static IS_OVERLAPPING_WARNING(newMergedCell) {
++    return `The merged cell declared at [${newMergedCell.row}, ${newMergedCell.col}] overlaps with the other ` +
++      'declared merged cell. The overlapping merged cell was not added to the table, please fix your setup.';
++  }
++
+   /**
+    * Get a merged cell from the container, based on the provided arguments. You can provide either the ""starting coordinates""
+    * of a merged cell, or any coordinates from the body of the merged cell.",Could you add description for below static function?
+5200,"@@ -453,7 +453,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
+ 	blocksFetched := uint64(1) // we already got the first block in the previous step.
+ 	var blk *bookkeeping.Block
+ 	var client FetcherClient
+-	for attemptsCount := uint64(1); blocksFetched <= lookback; attemptsCount++ {
++	for attemptsCount := uint64(1); blocksFetched <= lookback; {
+ 		if err := cs.ctx.Err(); err != nil {
+ 			return cs.stopOrAbort()
+ 		}","Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount?"
+5201,"@@ -21,7 +21,7 @@
+
+ """"""Installation script for Python nupic package.""""""
+
+-import os
++import OOOOOOOOOOOos
+ import pkg_resources
+ import sys
+ ",I don't think this will work.
+5202,"@@ -0,0 +1,11 @@
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpParser
++    {
++        bool ParseRequestLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpRequestLineHandler;
++
++        bool ParseHeaders<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined, out int consumedBytes) where T : IHttpHeadersHandler;
++    }
++}",Since http2 is coming do we want to call this something more specific?
+5203,"@@ -11,8 +11,8 @@
+   </div>
+ </nav>
+
+-<%= content_tag :div, class: 'navbar-search navbar navbar-light bg-light', role: 'navigation', aria: { label: t('blacklight.search.header') } do %>
++<div class=""navbar-search navbar navbar-light bg-light"" role=""navigation"">
+   <div class=""<%= container_classes %>"">
+     <%= render_search_bar  %>
+   </div>
+-<% end %>
++</div>","I don't think we want to revert the accessibility issues the tool caught, do we?"
+5204,"@@ -285,8 +285,11 @@ func (rt *RequestTracker) Accept() (conn net.Conn, err error) {
+ 		rt.hostRequests.pruneRequests(rateLimitingWindowStartTime)
+ 		originConnections := rt.hostRequests.countOriginConnections(trackerRequest.remoteHost, rateLimitingWindowStartTime)
+
++		remoteHostIsNonLocal := (!rt.config.DisableLocalhostConnectionRateLimit) || (!isLocalhost(trackerRequest.remoteHost))
++		connectionLimitEnabled := rt.config.ConnectionsRateLimitingWindowSeconds > 0 && rt.config.ConnectionsRateLimitingCount > 0
++
+ 		// check the number of connections
+-		if originConnections > rt.config.ConnectionsRateLimitingCount && rt.config.ConnectionsRateLimitingWindowSeconds > 0 && rt.config.ConnectionsRateLimitingCount > 0 {
++		if originConnections > rt.config.ConnectionsRateLimitingCount && connectionLimitEnabled && remoteHostIsNonLocal {
+ 			rt.hostRequestsMu.Unlock()
+ 			networkConnectionsDroppedTotal.Inc(map[string]string{""reason"": ""incoming_connection_per_ip_tcp_rate_limit""})
+ 			rt.log.With(""connection"", ""tcp"").With(""count"", originConnections).Debugf(""Rejected connection due to excessive connections attempt rate"")",I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local.
+5205,"@@ -105,7 +105,7 @@ export function initDebug() {
+ 					`\n\n${getOwnerStack(vnode)}`
+ 			);
+ 		} else if (type != null && typeof type === 'object') {
+-			if (type._lastDomChild !== undefined && type._dom !== undefined) {
++			if (type._lastDomChildSibling !== undefined && type._dom !== undefined) {
+ 				throw new Error(
+ 					`Invalid type passed to createElement(): ${type}\n\n` +
+ 						'Did you accidentally pass a JSX literal as JSX twice?\n\n' +",Hmm I think I might've messed up this condition here... Need to look more at it
+5206,"@@ -118,11 +118,9 @@ class DocumentQueue:
+         if doc_type == DocTypes.PACKAGE:
+             if not handle or not package_hash or not pointer_file:
+                 raise ValueError(""missing required argument for package document"")
+-            if (
+-                package_stats
+-                and not isinstance(package_stats, dict)
+-                or isinstance(package_stats, dict)
+-                and any(k not in package_stats for k in ['total_files', 'total_bytes'])
++            if not (
++                package_stats is None
++                or isinstance(package_stats, dict) and {'total_files', 'total_bytes'}.issubset(package_stats)
+             ):
+                 raise ValueError(""Malformed package_stats"")
+             body.update({",This also makes the exception to be raised on non-dict falsy values which I think was expected.
+5207,"@@ -173,7 +173,7 @@ class Dataset(Element):
+
+     # In the 1D case the interfaces should not automatically add x-values
+     # to supplied data
+-    _auto_indexable_1d = False
++    _auto_indexable_1d = True
+
+     # Define a class used to transform Datasets into other Element types
+     _conversion_interface = DataConversion",Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR...
+5208,"@@ -6,9 +6,9 @@ setup(
+     py_modules=[""rtool""],
+     install_requires=[
+         ""click>=6.2, <7.0"",
+-        ""twine>=1.6.5, <1.9"",
++        ""twine>=1.6.5, <1.10"",
+         ""pysftp==0.2.8"",
+-        ""cryptography>=1.6, <1.7"",
++        ""cryptography>=1.6, <1.9"",
+     ],
+     entry_points={
+         ""console_scripts"": [","Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well."
+5209,"@@ -0,0 +1,13 @@
++#include <iostream>
++#include <rai/lib/utility.hpp>
++
++void release_assert_internal (bool check, const char * check_expr, const char * file, unsigned int line)
++{
++	if (check)
++	{
++		return;
++	}
++
++	std::cerr << ""Assertion ("" << check_expr << "") failed "" << file << "":"" << line << std::endl;
++	abort();
++}",Will calling `abort()` cause problems for our test suite?
+5210,"@@ -292,6 +292,11 @@ ast_result_t pass_expr(ast_t** astp, pass_opt_t* options)
+     case TK_ADDRESS:    r = expr_addressof(options, ast); break;
+     case TK_DIGESTOF:   r = expr_digestof(options, ast); break;
+
++    case TK_OBJECT:
++      if(!expr_object(options, astp))
++        return AST_FATAL;
++      break;
++
+     case TK_LAMBDA:
+       if(!expr_lambda(options, astp))
+         return AST_FATAL;","for my own edificaton, what's this?"
+5211,"@@ -248,13 +248,14 @@ func (sf *factory) NewWorkingSet() (WorkingSet, error) {
+
+ // Commit persists all changes in RunActions() into the DB
+ func (sf *factory) Commit(ws WorkingSet) error {
++	if ws == nil {
++		return nil
++	}
+ 	sf.mutex.Lock()
+ 	defer sf.mutex.Unlock()
+-	if ws != nil {
+-		if sf.currentChainHeight != ws.Version() {
+-			// another working set with correct version already committed, do nothing
+-			return nil
+-		}
++	if sf.currentChainHeight != ws.Version() {
++		// another working set with correct version already committed, do nothing
++		return nil
+ 	}
+ 	if err := ws.Commit(); err != nil {
+ 		return errors.Wrap(err, ""failed to commit working set"")",make it harmless to commit ws == nil
+5212,"@@ -59,6 +59,8 @@ var locationsReplacement = regexp.MustCompile(`\$\(locations ([^\)]+)\)`)
+ var exeReplacement = regexp.MustCompile(`\$\(exe ([^\)]+)\)`)
+ var outExeReplacement = regexp.MustCompile(`\$\(out_exe ([^\)]+)\)`)
+ var outReplacement = regexp.MustCompile(`\$\(out_location ([^\)]+)\)`)
++var absOutExeReplacement = regexp.MustCompile(`\$\(abs_out_exe ([^\)]+)\)`)
++var absOutReplacement = regexp.MustCompile(`\$\(abs_out_location ([^\)]+)\)`)
+ var dirReplacement = regexp.MustCompile(`\$\(dir ([^\)]+)\)`)
+ var hashReplacement = regexp.MustCompile(`\$\(hash ([^\)]+)\)`)
+ var workerReplacement = regexp.MustCompile(`^(.*)\$\(worker ([^\)]+)\) *([^&]*)(?: *&& *(.*))?$`)","Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go?"
+5213,"@@ -24,8 +24,11 @@ import (
+
+ var _reqBody = []byte(""hello"")
+
+-func yarpcEcho(ctx context.Context, reqMeta yarpc.ReqMeta, body []byte) ([]byte, yarpc.ResMeta, error) {
+-	return body, yarpc.NewResMeta().Headers(reqMeta.Headers()), nil
++func yarpcEcho(ctx context.Context, body []byte) ([]byte, error) {
++	for _, k := range yarpc.HeaderNames(ctx) {
++		yarpc.WriteResponseHeader(ctx, k, yarpc.Header(ctx, k))
++	}
++	return body, nil
+ }
+
+ func httpEcho(t testing.TB) http.HandlerFunc {",That's actually not as bad as I thought it was going to be.
+5214,"@@ -198,6 +198,11 @@ public class DatasetServiceBean implements java.io.Serializable {
+         return em.createQuery(""SELECT o.id FROM Dataset o WHERE o.indexTime IS null ORDER BY o.id DESC"", Long.class).getResultList();
+     }
+
++    //Used in datasets listcurationstatus API
++    public List<Dataset> findAllUnpublished() {
++        return em.createQuery(""SELECT object(o) FROM Dataset o, DvObject d WHERE d.id=o.id and d.publicationDate IS null ORDER BY o.id ASC"", Dataset.class).getResultList();
++    }
++
+     /**
+      * For docs, see the equivalent method on the DataverseServiceBean.
+      * @param numPartitions","Hmm, I'm surprised if we don't already have a ""find all unpublished datasets"" method but I don't really know. Maybe @scolapasta knows."
+5215,"@@ -598,6 +598,12 @@ class Python3Checker(checkers.BaseChecker):
+             ""variables will be deleted outside of the ""
+             ""comprehension."",
+         ),
++        ""C1601"": (
++            ""Consider using Python 3 style super() without arguments"",
++            ""old-style-super"",
++            ""Emitted when calling the super builtin with the current class ""
++            ""and instance. On Python 3 these arguments are the default."",
++        ),
+     }
+
+     _bad_builtins = frozenset(","The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all."
+5216,"@@ -0,0 +1,18 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
++{
++    /// <summary>
++    /// Feature to set the minimum data rate at which the response should be sent.
++    /// </summary>
++    public interface IHttpMinResponseDataRateFeature
++    {
++        /// <summary>
++        /// The minimum data rate in bytes/second at which the response should be sent.
++        /// Setting this property to null indicates no minimum data rate should be enforced.
++        /// This limit has no effect on upgraded connections which are always unlimited.
++        /// </summary>
++        MinDataRate MinDataRate { get; set; }
++    }
++}","I would change ""should be sent"" to ""must be received""."
+5217,"@@ -24,6 +24,8 @@ import (
+ 	""github.com/openebs/maya/pkg/storagepool""
+ )
+
++
++// DeleteStoragePool receives StoragePoolClaim object and deletes it.
+ func DeleteStoragePool(spcGot *v1alpha1.StoragePoolClaim) error {
+ 	// Business logic for deletion of storagepool
+ 	glog.Infof(""Storagepool delete event received for storagepoolclaim %s"", spcGot.Name)",Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.`
+5218,"@@ -58,4 +58,16 @@ public final class RestConst {
+   public static final String CONSUMER_HEADER = ""servicecomb-rest-consumer-header"";
+
+   public static final String READ_STREAM_PART = ""servicecomb-readStreamPart"";
++
++  public static final String UPLOAD_DIR = ""cse.uploads.directory"";
++
++  // limit of one upload file, only available for servlet rest transport
++  public static final String UPLOAD_MAX_FILE_SIZE = ""cse.uploads.maxFileSize"";
++
++  // limit of upload request body
++  public static final String UPLOAD_MAX_SIZE = ""cse.uploads.maxSize"";
++
++  // the size threshold after which files will be written to disk
++  // only available for servlet rest transport
++  public static final String UPLOAD_FILE_SIZE_THRESHOLD = ""cse.uploads.fileSizeThreshold"";
+ }",It's better to use servicecomb now.
+5219,"@@ -58,12 +58,13 @@ var PolicyChain = policies.Chain{
+
+ type controller struct {
+ 	// the policies to use to define readiness - named here to make testing simpler
+-	policyChain              policies.Chain
+-	certificateLister        cmlisters.CertificateLister
+-	certificateRequestLister cmlisters.CertificateRequestLister
+-	secretLister             corelisters.SecretLister
+-	client                   cmclient.Interface
+-	gatherer                 *policies.Gatherer
++	policyChain                      policies.Chain
++	certificateLister                cmlisters.CertificateLister
++	certificateRequestLister         cmlisters.CertificateRequestLister
++	secretLister                     corelisters.SecretLister
++	client                           cmclient.Interface
++	gatherer                         *policies.Gatherer
++	defaultRenewBeforeExpiryDuration time.Duration
+ }
+
+ func NewController(",Make the flag derived default available in the readiness controller
+5220,"@@ -278,6 +278,10 @@ func TestReconcileClusterSync_NoWorkToDo(t *testing.T) {
+ 				}),
+ 			),
+ 		},
++		{
++			name: ""syncset pause"",
++			cd:   cdBuilder(scheme).GenericOptions(testgeneric.WithAnnotation(constants.SyncsetPauseAnnotation, ""true"")).Build(),
++		},
+ 	}
+ 	for _, tc := range cases {
+ 		t.Run(tc.name, func(t *testing.T) {",Confirmed this test fails when the fix is reverted
+5221,"@@ -38,6 +38,9 @@ func NewCollector(options *LogOptions) *Collector {
+
+ // Archive creates ZIP archive containing all node log files.
+ func (c *Collector) Archive() (outputFilepath string, err error) {
++	if c.options.Filepath == """" {
++		return """", errors.New(""file logging is disabled, can't retrieve logs"")
++	}
+ 	filepaths, err := c.logFilepaths()
+ 	if err != nil {
+ 		return """", err",This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`.
+5222,"@@ -14,6 +14,15 @@ class BaseDenseHead(BaseModule, metaclass=ABCMeta):
+     def __init__(self, init_cfg=None):
+         super(BaseDenseHead, self).__init__(init_cfg)
+
++    def init_weights(self):
++        super(BaseDenseHead, self).init_weights()
++        # avoid init_cfg overwrite the initialization of `conv_offset`
++        for m in self.modules():
++            # DeformConv2dPack, ModulatedDeformConv2dPack
++            if hasattr(m, 'conv_offset'):
++                m.conv_offset.weight.data.zero_()
++                m.conv_offset.bias.data.zero_()
++
+     @abstractmethod
+     def loss(self, **kwargs):
+         """"""Compute losses of the head.""""""",DCN should not be able to use `init_cfg`.
+5223,"@@ -28,7 +28,7 @@ namespace OpenTelemetry.Shims.OpenTracing
+         {
+             if (!spanContext.IsValid)
+             {
+-                throw new ArgumentException(nameof(spanContext));
++                throw new ArgumentException($""{nameof(spanContext)} must be valid."");
+             }
+
+             this.SpanContext = spanContext;","It is a bit weird to see a message like ""something must be valid""."
+5224,"@@ -119,10 +119,10 @@ public class Standalone implements CliCommand {
+       LoggingOptions loggingOptions = new LoggingOptions(config);
+       loggingOptions.configureLogging();
+
+-      LOG.info(""Logging configured."");
++      LOG.finest(""Logging configured."");
+
+       DistributedTracer tracer = loggingOptions.getTracer();
+-      LOG.info(""Using tracer: "" + tracer);
++      LOG.finest(""Using tracer: "" + tracer);
+       GlobalDistributedTracer.setInstance(tracer);
+
+       EventBusConfig events = new EventBusConfig(config);","Again. This is part of the start up of the server, and the diagnostics are helpful."
+5225,"@@ -139,6 +139,12 @@ describe Travis::Build::Script::R, :sexp do
+                          echo: true, timing: true]
+   end
+
++  it 'skips PDF manual when LaTeX is disabled' do
++    data[:config][:latex] = false
++    should include_sexp [:cmd, /.*R CMD check.* --no-manual.*/,
++                         echo: true, timing: true]
++  end
++
+   describe 'bioc configuration is optional' do
+     it 'does not install bioc if not required' do
+       should_not include_sexp [:cmd, /.*biocLite.*/,","I think you need a `,` at the end of the line?"
+5226,"@@ -54,10 +54,7 @@ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbEntityOperation;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation.State;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperationType;
+-import org.camunda.bpm.engine.impl.util.DatabaseUtil;
+-import org.camunda.bpm.engine.impl.util.ExceptionUtil;
+-import org.camunda.bpm.engine.impl.util.IoUtil;
+-import org.camunda.bpm.engine.impl.util.ReflectUtil;
++import org.camunda.bpm.engine.impl.util.*;
+
+ /**
+ *",Please avoid wildcard imports.
+5227,"@@ -84,6 +84,9 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
+                     using (HttpClient client = new HttpClient())
+                     {
+                         client.DefaultRequestHeaders.Clear();
++
++                        // In random occassions the request fails if the network is slow and it takes more than 100 seconds to upload 4MB.
++                        client.Timeout = TimeSpan.FromMinutes(5);
+                         Func<HttpRequestMessage> createRequest = () =>
+                         {
+                             DateTime dt = DateTime.UtcNow;",Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL.
+5228,"@@ -238,9 +238,17 @@ func run(o *Options) error {
+ 	}
+
+ 	var egressController *egress.EgressController
++	var nodeIP net.IP
++	if nodeConfig.NodeIPv4Addr != nil {
++		nodeIP = nodeConfig.NodeIPv4Addr.IP
++	} else if nodeConfig.NodeIPv6Addr != nil {
++		nodeIP = nodeConfig.NodeIPv6Addr.IP
++	} else {
++		return fmt.Errorf(""invalid NodeIPAddr in Node config: %v"", nodeConfig)
++	}
+ 	if features.DefaultFeatureGate.Enabled(features.Egress) {
+ 		egressController, err = egress.NewEgressController(
+-			ofClient, antreaClientProvider, crdClient, ifaceStore, routeClient, nodeConfig.Name, nodeConfig.NodeIPv4Addr.IP,
++			ofClient, antreaClientProvider, crdClient, ifaceStore, routeClient, nodeConfig.Name, nodeIP,
+ 			o.config.ClusterMembershipPort, egressInformer, nodeInformer, externalIPPoolInformer,
+ 		)
+ 		if err != nil {","dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family?"
+5229,"@@ -230,7 +230,7 @@ class ServerTLSLayer(_TLSLayer):
+                     server.sni = self.context.client.sni.encode(""idna"")
+                 else:
+                     server.sni = server.address[0].encode(""idna"")
+-                    self.tls[server].set_tlsext_host_name(server.sni)
++                self.tls[server].set_tlsext_host_name(server.sni)
+         self.tls[server].set_connect_state()
+
+         yield from self.process(events.DataReceived(server, b""""))",Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me!
+5230,"@@ -57,12 +57,12 @@ public class TestPerformance extends LuceneTestCase {
+
+   @Test
+   public void en() throws Exception {
+-    checkAnalysisPerformance(""en"", 1_000_000);
++    checkAnalysisPerformance(""en"", 1_200_000);
+   }
+
+   @Test
+   public void en_suggest() throws Exception {
+-    checkSuggestionPerformance(""en"", 1_200);
++    checkSuggestionPerformance(""en"", 3_000);
+   }
+
+   @Test",Hmm what are these magical constant numbers? And why does this change mean they should increase?
+5231,"@@ -36,7 +36,7 @@ import logging.config
+ import urlparse
+ from boto.exception import InvalidUriError
+
+-__version__ = '2.8.0-dev'
++__version__ = '2.8.0'
+ Version = __version__  # for backware compatibility
+
+ UserAgent = 'Boto/%s (%s)' % (__version__, sys.platform)",This change shouldn't be included with this push. Shouldn't push version changes with a pull-request.
+5232,"@@ -97,6 +97,9 @@ func (h handler) handle(ctx context.Context, call inboundCall) {
+
+ 	err := h.callHandler(ctx, call, responseWriter)
+
++	// echo accepted rpc-service in response header in any status
++	responseWriter.addHeader(RespondServiceHeaderKey, call.ServiceName())
++
+ 	// black-hole requests on resource exhausted errors
+ 	if yarpcerrors.FromError(err).Code() == yarpcerrors.CodeResourceExhausted {
+ 		// all TChannel clients will time out instead of receiving an error","nit: let's move this right under where we create the `responseWriter`, before `h.callHandler`"
+5233,"@@ -361,7 +361,7 @@ void nano::mdb_store::upgrade_v14_to_v15 (nano::write_transaction & transaction_
+
+ 		nano::mdb_val value{ data.size (), (void *)data.data () };
+ 		auto s = mdb_put (env.tx (transaction_a), state_blocks_new, nano::mdb_val (hash), value, MDB_APPEND);
+-		release_assert_success (s);
++		release_assert_success<MDB_val, mdb_store> ((*this), s);
+
+ 		// Every so often output to the log to indicate progress
+ 		constexpr auto output_cutoff = 1000000;","The way it was implemented, needed to pass the template values. Please check whether we want this."
+5234,"@@ -36,7 +36,8 @@ var daemonCmd = &cmds.Command{
+ 		cmdkit.BoolOption(OfflineMode, ""start the node without networking""),
+ 		cmdkit.BoolOption(ELStdout),
+ 		cmdkit.BoolOption(IsRelay, ""advertise and allow filecoin network traffic to be relayed through this node""),
+-		cmdkit.StringOption(BlockTime, ""time a node waits before trying to mine the next block"").WithDefault(clock.DefaultEpochDuration.String()),
++		cmdkit.StringOption(BlockTime, ""period a node waits between mining successive blocks"").WithDefault(clock.DefaultEpochDuration.String()),
++		cmdkit.StringOption(PropagationDelay, ""time a node waits after the start of an epoch for blocks to arrive"").WithDefault(clock.DefaultPropagationDelay.String()),
+ 	},
+ 	Run: func(req *cmds.Request, re cmds.ResponseEmitter, env cmds.Environment) error {
+ 		return daemonRun(req, re)","Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't do it yet tho."
+5235,"@@ -18,6 +18,7 @@
+ # WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ # IN THE SOFTWARE.
++from __future__ import print_function
+
+ import errno
+ import httplib",Is this import needed?
+5236,"@@ -68,6 +68,8 @@ storiesOf( 'Dashboard', module )
+ 				<PostSearcher />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} )
+ 	.add( 'URL Search Widget', () => {
+ 		const setupRegistry = ( registry ) => provideSiteInfo( registry );",Dashboard stories also need to have the default padding.
+5237,"@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+
++  /**
++   * If the compaction should commit rewritten data files using the sequence number at compaction start time instead
++   * of optimistically incrementing the latest sequence number.
++   * <p>
++   * This avoids commit conflicts with updates that add newer equality deletes at a higher sequence number.
++   * <p>
++   * Defaults to false.
++   */
++  String USE_STARTING_SEQUENCE_NUMBER = ""use-starting-sequence-number"";
++  boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = false;
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining",Is there a reason why we wouldn't use this as the default?
+5238,"@@ -15,7 +15,7 @@ void CreateEdgeProcessor::process(const cpp2::CreateEdgeReq& req) {
+     {
+         // if there is an edge of the same name
+         // TODO: there exists race condition, we should address it in the future
+-        folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock());
++        folly::SharedMutex::ReadHolder rHolder(LockUtils::tagLock());
+         auto conflictRet = getTagId(req.get_space_id(), edgeName);
+         if (conflictRet.ok()) {
+             LOG(ERROR) << ""Failed to create edge `"" << edgeName",if there is an tag of the same name?
+5239,"@@ -1,10 +1,8 @@
+ package net
+
+ import (
+-	""bytes""
+ 	""errors""
+ 	""fmt""
+-	""os/exec""
+ 	""path/filepath""
+ 	""runtime""
+ ",I'd add `// +build go1.10` to prevent from accidentally compiling with older Go.
+5240,"@@ -1,10 +1,12 @@
++from __future__ import unicode_literals
++
+ import numpy as np
+ import param
+
+ from ..core import (HoloMap, DynamicMap, CompositeOverlay, Layout,
+                     GridSpace, NdLayout, Store)
+ from ..core.util import (match_spec, is_number, wrap_tuple,
+-                         get_overlay_spec, unique_iterator)
++                         get_overlay_spec, unique_iterator, safe_unicode)
+
+
+ def displayable(obj):",Not sure how this import relates to the PR but seems like a good idea anyway...
+5241,"@@ -5,6 +5,7 @@
+ #include ""../CustomBuild/ESPEasyLimits.h""
+ #include ""../DataStructs/DeviceStruct.h""
+ #include ""../../ESPEasy_common.h""
++#include ""../WebServer/HardwarePage.h""
+
+ template<unsigned int N_TASKS>
+ SettingsStruct_tmpl<N_TASKS>::SettingsStruct_tmpl() : ResetFactoryDefaultPreference(0) {","Hmm this is strange, why should the SettingsStruct import something from `WebServer` ? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around."
+5242,"@@ -4,13 +4,16 @@
+ using System;
+ using Microsoft.AspNet.Builder;
+ using Microsoft.AspNet.Http;
++using Microsoft.Framework.Logging;
+
+ namespace SampleApp
+ {
+     public class Startup
+     {
+-        public void Configure(IApplicationBuilder app)
++        public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory)
+         {
++            loggerFactory.MinimumLevel = LogLevel.Debug;
++            loggerFactory.AddConsole(LogLevel.Debug);
+             app.Run(context =>
+             {
+                 Console.WriteLine(""{0} {1}{2}{3}"",",nit: Space between these lines.
+5243,"@@ -353,7 +353,7 @@ class ResultsProvider(object):
+     :type listeners: list[AggregatorListener]
+     """"""
+
+-    def __init__(self):
++    def __init__(self, translator=None):
+         super(ResultsProvider, self).__init__()
+         self.cumulative = BetterDict()
+         self.track_percentiles = []",Why aggregator should have this translator? It's Selenium specifics for now...
+5244,"@@ -136,6 +136,13 @@ public abstract class FieldComparator<T> {
+     }
+   }
+
++  /**
++   * Informs the comparator that sorting is done in reverse.
++   * This is necessary only for skipping functionality.
++   */
++  public void setReverse() {
++  }
++
+
+   /**
+    * Base FieldComparator class for numeric types",I don't understand why this function is needed ? Can't you just pass the information when the `DocComparator` is created in the SortField ?
+5245,"@@ -11,5 +11,7 @@ class MailchimpFulfillmentJob < MailchimpJob
+
+   def subscribe(list_id, email)
+     client.list_subscribe(id: list_id, email_address: email, double_optin: false)
++  rescue Gibbon::MailChimpError => e
++    raise e unless MAILCHIMP_EMAIL_ERROR_CODES.include?(e.code)
+   end
+ end",This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse?
+5246,"@@ -90,6 +90,9 @@ function fetchWithTimeout(input, init) {
+                 url: xhr.responseURL,
+                 headers: xhr.responseHeaders
+             };
++            if (!options.headers) {
++                options.headers = {'content-type': xhr.getResponseHeader('content-type')};
++            }
+             const body = 'response' in xhr ? xhr.response : xhr.responseText;
+             resolve(new Response(body, options));
+         };","It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd."
+5247,"@@ -107,8 +107,16 @@ noreturn static void exec_xwayland(struct wlr_xwayland_server *server) {
+ 		dup2(devnull, STDERR_FILENO);
+ 	}
+
++	const char *xwayland_path = getenv(""WLR_XWAYLAND"");
++	if (xwayland_path) {
++		wlr_log(WLR_INFO, ""Using Xwayland binary to '%s' due to WLR_XWAYLAND"",
++			xwayland_path);
++	} else {
++		xwayland_path = ""Xwayland"";
++	}
++
+ 	// This returns if and only if the call fails
+-	execvp(""Xwayland"", argv);
++	execvp(xwayland_path, argv);
+
+ 	wlr_log_errno(WLR_ERROR, ""failed to exec Xwayland"");
+ 	close(devnull);","Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env."
+5248,"@@ -0,0 +1,13 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. Keep in mind, some components like `forms/checkbox` will be changed to `forms-checkbox`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!design-system-react/components/pill/__examples__/base.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/icon.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/container.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/listbox.jsx')
++];
++
++module.exports = siteStories;","Should we have an avatar, truncate, etc examples, too?"
+5249,"@@ -31,7 +31,6 @@ class _MissingPandasLikeIndex(object):
+
+     # Properties
+     nbytes = unsupported_property('nbytes')
+-    shape = unsupported_property('shape')
+
+     # Deprecated properties
+     strides = unsupported_property('strides', deprecated=True)",could you add this to `docs/source/reference/indexing.rst` ?
+5250,"@@ -3,10 +3,10 @@
+ #  Copyright (C) 2003 Rational Discovery LLC
+ #     All Rights Reserved
+ #
+-import sys
++
++import six
+
+ from rdkit.VLib.Node import VLibNode
+-from rdkit import six
+
+
+ class FilterNode(VLibNode):",Why the change from rdkit.six to six?
+5251,"@@ -78,6 +78,12 @@ def renderView(request):
+
+   # Now we prepare the requested data
+   if requestOptions['graphType'] == 'pie':
++    targets = [target for target in requestOptions['targets'] if target.find(':') < 0]
++    if settings.REMOTE_PREFETCH_DATA and not requestOptions.get('localOnly'):
++      log.rendering(""Prefetching remote data"")
++      pathExpressions = extractPathExpressions(targets)
++      prefetchRemoteData(STORE.remote_stores, requestContext, pathExpressions)
++
+     for target in requestOptions['targets']:
+       if target.find(':') >= 0:
+         try:","Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it."
+5252,"@@ -1892,7 +1892,7 @@ describe('Bulk', function () {
+         expect(result).to.exist;
+
+         bulk.execute(err => {
+-          expect(err).to.match(/Batch cannot be re-executed/);
++          expect(err).to.match(/This batch has already been executed, create new batch to execute/);
+           done();
+         });
+       });",I think we should change this to an instanceOf check for MongoBatchReExecutionError
+5253,"@@ -34,7 +34,7 @@ type ProfileDecoder struct {
+ }
+
+ func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
+-	return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
++	return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
+ }
+
+ func (p *ProfileDecoder) RegisterWith(d *dispatcher.Dispatcher) {",Required by the libcalico-go changes
+5254,"@@ -1193,3 +1193,12 @@ type MutableBareRootMetadataNoImplError struct {
+ func (e MutableBareRootMetadataNoImplError) Error() string {
+ 	return ""Does not implement MutableBareRootMetadata""
+ }
++
++// blockNonExistentError is returned when a block doesn't exist.
++type blockNonExistentError struct {
++	id BlockID
++}
++
++func (e blockNonExistentError) Error() string {
++	return fmt.Sprintf(""block %s does not exist"", e.id)
++}",Explain why we don't reuse the corresponding server error locally?
+5255,"@@ -417,7 +417,7 @@ public class SolrSearchResult {
+                 .add(""is_unpublished_state"", this.isUnpublishedState())
+                 .add(""is_published"", this.isPublishedState())
+                 .add(""is_deaccesioned"", this.isDeaccessionedState())
+-                .add(""date_to_display_on_card"", this.dateToDisplayOnCard);
++                .add(""date_to_display_on_card"", DateUtil.formatDate(this.releaseOrCreateDate));
+
+         // Add is_deaccessioned attribute, even though MyData currently screens any deaccessioned info out
+         //","@JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method)."
+5256,"@@ -20,8 +20,6 @@ var (
+ 	ErrNoConnection = errors.New(""no connection exists"")
+ 	// ErrAlreadyExists error indicates that aciton applieto to manager expects no active connection (i.e. connect)
+ 	ErrAlreadyExists = errors.New(""connection already exists"")
+-	// ErrConnectionCancelled indicates that connection in progress was cancelled by request of api user
+-	ErrConnectionCancelled = errors.New(""connection was cancelled"")
+ 	// ErrOpenvpnProcessDied indicates that Connect method didn't reach ""Connected"" phase due to openvpn error
+ 	ErrOpenvpnProcessDied = errors.New(""openvpn process died"")
+ )",What was wrong with more concrete error?
+5257,"@@ -14,3 +14,17 @@ function roots_get_search_form($form) {
+   return $form;
+ }
+ add_filter('get_search_form', 'roots_get_search_form');
++
++/**
++ * Add page slug to body_class() classes if it doesn't exist
++ */
++function roots_body_class($classes) {
++  // Add post/page slug
++  if (is_single() || is_page() && !is_front_page()) {
++  	if (!in_array(basename(get_permalink()), $classes)) {
++  		$classes[] = basename(get_permalink());
++  	}
++  }
++  return $classes;
++}
++add_filter('body_class', 'roots_body_class');",can you replace the tabs with 2 spaces please to match the rest of the project?
+5258,"@@ -14,6 +14,8 @@ const IntegralKind = ""integral""
+
+ type IntegralOpSpec struct {
+ 	Unit flux.Duration `json:""unit""`
++	TimeSrc string   `json:""timeSrc""`
++	TimeDst string   `json:""timeDst""`
+ 	execute.AggregateConfig
+ }
+ ",Why are we adding it to the integral function?
+5259,"@@ -45,11 +45,11 @@ func XfrmStateAdd(state *XfrmState) error {
+
+ 	msg := &nl.XfrmUsersaInfo{}
+ 	msg.Family = uint16(nl.GetIPFamily(state.Dst))
+-	msg.Id.Daddr.FromIP(state.Dst)
++	msg.ID.Daddr.FromIP(state.Dst)
+ 	msg.Saddr.FromIP(state.Src)
+-	msg.Id.Proto = uint8(state.Proto)
++	msg.ID.Proto = uint8(state.Proto)
+ 	msg.Mode = uint8(state.Mode)
+-	msg.Id.Spi = nl.Swap32(uint32(state.Spi))
++	msg.ID.Spi = nl.Swap32(uint32(state.Spi))
+ 	msg.Reqid = uint32(state.Reqid)
+ 	msg.ReplayWindow = uint8(state.ReplayWindow)
+ 	msg.Lft.SoftByteLimit = nl.XFRM_INF",Same for this file
+5260,"@@ -234,15 +234,14 @@ namespace NLog.Internal.FileAppenders
+                 appender.Flush();
+             }
+         }
+-
++
+         /// <summary>
+         /// Gets the file info for a particular appender.
+         /// </summary>
+         /// <param name=""fileName"">The file name associated with a particular appender.</param>
+-        /// <param name=""lastWriteTime"">The last file write time. The value must be of UTC kind.</param>
+-        /// <param name=""fileLength"">Length of the file.</param>
++        /// <param name=""fileCharacteristics"">The file characteristics, if the file information was retrieved successfully.</param>
+         /// <returns><see langword=""true""/> when the operation succeeded; <see langword=""false""/> otherwise.</returns>
+-        public bool GetFileInfo(string fileName, out DateTime lastWriteTime, out long fileLength)
++        public bool GetFileCharacteristics(string fileName, out FileCharacteristics fileCharacteristics)
+         {
+             foreach (BaseFileAppender appender in appenders)
+             {",Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal?
+5261,"@@ -825,6 +825,11 @@ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
+ 	view_activate(view, true);
+ 	seat->has_focus = true;
+
++	// We want to unconditionally send keyboard input to the view we are
++	// focusing here, so cancel any existing grabs.
++	struct wlr_seat_keyboard_grab *curr_grab = seat->seat->keyboard_state.grab;
++	curr_grab->interface->cancel(curr_grab);
++
+ 	struct wlr_keyboard *keyboard = wlr_seat_get_keyboard(seat->seat);
+ 	if (keyboard != NULL) {
+ 		wlr_seat_keyboard_notify_enter(seat->seat, view->wlr_surface,",probably better to use `wlr_seat_keyboard_end_grab()`.
+5262,"@@ -142,6 +142,9 @@ public class TransactionPool implements BlockAddedObserver {
+
+   public ValidationResult<TransactionInvalidReason> addLocalTransaction(
+       final Transaction transaction) {
++    if (transaction.getChainId().isEmpty() && !configuration.isUnprotectedTransactionsAllowed()) {
++      return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION);
++    }
+     if (!configuration.getTxFeeCap().isZero()
+         && minTransactionGasPrice(transaction).compareTo(configuration.getTxFeeCap()) > 0) {
+       return ValidationResult.invalid(TransactionInvalidReason.TX_FEECAP_EXCEEDED);",Such a large test impact for such a little 3 line change ;)
+5263,"@@ -51,9 +51,9 @@ class Payment extends AbstractTranslatableEntity implements OrderableEntityInter
+     protected $vat;
+
+     /**
+-     * @var Collection
++     * @var \Shopsys\FrameworkBundle\Model\Transport\Transport[]|Collection
+      *
+-     * @ORM\ManyToMany(targetEntity=""Shopsys\FrameworkBundle\Model\Transport\Transport"")
++     * @ORM\ManyToMany(targetEntity=""Shopsys\FrameworkBundle\Model\Transport\Transport"", inversedBy=""payments"", cascade={""persist""})
+      * @ORM\JoinTable(name=""payments_transports"")
+      */
+     protected $transports;","Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport."
+5264,"@@ -0,0 +1,11 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Psalm\Issue;
++
++final class NonInvariantPropertyType extends CodeIssue
++{
++    public const ERROR_LEVEL = -1;
++    public const SHORTCODE = 235159;
++}",This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues.
+5265,"@@ -20,6 +20,9 @@ const (
+ 	// the default configuration provided to ingress-annotation should be
+ 	// created.
+ 	tlsACMEAnnotation = ""kubernetes.io/tls-acme""
++	// editInPlaceAnnotation is used to toggle the use of ingressClass instead
++	// of ingress on the created Certificate resource
++	editInPlaceAnnotation = ""certmanager.k8s.io/edit-in-place""
+ 	// issuerNameAnnotation can be used to override the issuer specified on the
+ 	// created Certificate resource.
+ 	issuerNameAnnotation = ""certmanager.k8s.io/issuer""","We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?)"
+5266,"@@ -665,7 +665,7 @@ public class JobTypeManager {
+   /**
+    +   * Get the keystore load props
+    +   */
+-  public Props getCommonPluginLoadProps() {
++  public Props    getCommonPluginLoadProps() {
+     return this.cachedCommonPluginLoadProps;
+   }
+ ",No need to add this file change for this PR. Please remove it.
+5267,"@@ -8,6 +8,7 @@ import net.sourceforge.pmd.lang.java.ast.ASTImportDeclaration;
+ import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
+
+ public class DontImportJavaLangRule extends AbstractJavaRule {
++    private static final String IMPORT_JAVA_LANG = ""java.lang."";
+
+     @Override
+     public Object visit(ASTImportDeclaration node, Object data) {",this extra dot at the end is causing a couple tests to fail on Travis
+5268,"@@ -853,7 +853,11 @@ Arguments:
+
+ @conf.commands.register
+ def tshark(*args,**kargs):
+-    """"""Sniff packets and print them calling pkt.show(), a bit like text wireshark""""""
+-    sniff(prn=lambda x: x.display(),*args,**kargs)
+-
+-
++    """"""Sniff packets and print them calling pkt.summary(), a bit like text wireshark""""""
++    print(""Capturing on '"" + str(kargs.get('iface') if 'iface' in kargs else conf.iface) + ""'"")
++    i = [0]  # This should be a nonlocal variable, using a mutable object for Python 2 compatibility
++    def _cb(pkt):
++        print(""%5d\t%s"" % (i[0], pkt.summary()))
++        i[0] += 1
++    sniff(prn=_cb, store=False, *args, **kargs)
++    print(""\n%d packet%s captured"" % (i[0], 's' if i[0] > 1 else ''))",Did you try using `global` with a regular integer ?
+5269,"@@ -76,7 +76,7 @@ int Contractor::Run()
+ #ifdef WIN32
+ #pragma message(""Memory consumption on Windows can be higher due to different bit packing"")
+ #else
+-    static_assert(sizeof(extractor::NodeBasedEdge) == 20,
++    static_assert(sizeof(extractor::NodeBasedEdge) == 24,
+                   ""changing extractor::NodeBasedEdge type has influence on memory consumption!"");
+     static_assert(sizeof(extractor::EdgeBasedEdge) == 16,
+                   ""changing EdgeBasedEdge type has influence on memory consumption!"");",windows size might be off
+5270,"@@ -25,10 +25,8 @@
+ #include ""engine/bp/BPFileReader.h""
+ #include ""engine/bp/BPFileWriter.h""
+
+-#ifdef ADIOS_HAVE_DATAMAN // external dependencies
+ #include ""engine/dataman/DataManReader.h""
+ #include ""engine/dataman/DataManWriter.h""
+-#endif
+
+ #ifdef ADIOS_HAVE_ADIOS1 // external dependencies
+ #include ""engine/adios1/ADIOS1Reader.h""",This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds.
+5271,"@@ -1,7 +1,7 @@
+ <%= ""#{@plan.title}"" %>
+ <%= ""----------------------------------------------------------\n"" %>
+ <% if @show_coversheet %>
+-<%= @hash[:attribution].length > 1 ? _(""Creators: "") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
++<%= @hash[:attribution].many? ? _(""Creators: "") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
+ <%= _(""Affiliation: "") + @hash[:affiliation] %>
+   <% if @hash[:funder].present? %>
+ <%= _(""Template: "") + @hash[:funder] %>",thanks for cleaning up these old length checks
+5272,"@@ -189,7 +189,7 @@ func (e *Executor) addBuiltinAnnontations(manifests []provider.Manifest, variant
+ }
+
+ func (e *Executor) applyManifests(ctx context.Context, manifests []provider.Manifest) error {
+-	e.LogPersister.Infof(""Start applying %d manifests"", len(manifests))
++	e.LogPersister.Infof(""Start applying %d manifests to %q namespace"", len(manifests), e.config.Input.Namespace)
+ 	for _, m := range manifests {
+ 		if err := e.provider.ApplyManifest(ctx, m); err != nil {
+ 			e.LogPersister.Errorf(""Failed to apply manifest: %s (%v)"", m.Key.ReadableString(), err)",What will be logged when the `Input.Namespace` was not specified?
+5273,"@@ -102,6 +102,9 @@ public class PMDParameters {
+     @Parameter(names = ""-cache"", description = ""Specify the location of the cache file for incremental analysis."")
+     private String cacheLocation = null;
+
++    @Parameter(names = ""-fix"", description = ""Attempt to automatically fix rule violations found on source files."")
++    private boolean autoFixes = false;
++
+     // this has to be a public static class, so that JCommander can use it!
+     public static class PropertyConverter implements IStringConverter<Properties> {
+ ",I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development
+5274,"@@ -47,5 +47,6 @@ axe.imports = {
+ 	CssSelectorParser: require('css-selector-parser').CssSelectorParser,
+ 	doT: require('@deque/dot'),
+ 	emojiRegexText: require('emoji-regex'),
+-	memoize: require('memoizee')
++	memoize: require('memoizee'),
++	ariaQuery: require('aria-query')
+ };",I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it.
+5275,"@@ -86,18 +86,8 @@ namespace OpenTelemetry
+             return value;
+         }
+
+-        /// <inheritdoc/>
+-        public void Dispose()
+-        {
+-            if (!this.disposed)
+-            {
+-                Slot.Set(this.previousValue);
+-                this.disposed = true;
+-            }
+-        }
+-
+         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+-        internal static int IncrementIfTriggered()
++        public static int IncrementIfTriggered()
+         {
+             var value = Slot.Get();
+ ",@ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other very internal-y spots. /cc @reyang
+5276,"@@ -283,9 +283,12 @@ public class ExecuteFlowAction implements TriggerAction {
+             actions.add(killAct);
+           }
+         }
+-        Trigger slaTrigger =
+-            new Trigger(""azkaban_sla"", ""azkaban"", triggerCond, expireCond,
+-                actions);
++        Trigger slaTrigger = new Trigger.TriggerBuilder(""azkaban_sla"",
++                                                        ""azkaban"",
++                                                        triggerCond,
++                                                        expireCond,
++                                                        actions).build();
++
+         slaTrigger.getInfo().put(""monitored.finished.execution"",
+             String.valueOf(execId));
+         slaTrigger.setResetOnTrigger(false);",would be good to turn these into constants.
+5277,"@@ -158,8 +158,8 @@ func (g *gen) frame() []byte {
+ 		return nil
+ 	}
+ 	var buf bytes.Buffer
+-	buf.WriteString(""// Code generated by gowire. DO NOT EDIT.\n\n"")
+-	buf.WriteString(""//go:generate gowire\n"")
++	buf.WriteString(""// Code generated by wire. DO NOT EDIT.\n\n"")
++	buf.WriteString(""//go:generate wire\n"")
+ 	buf.WriteString(""//+build !wireinject\n\n"")
+ 	buf.WriteString(""package "")
+ 	buf.WriteString(g.prog.Package(g.currPackage).Pkg.Name())",Seems like it should be `generated by Wire` here and in the SUT?
+5278,"@@ -173,7 +173,7 @@ func TestStorageProtocolBasic(t *testing.T) {
+ 		}
+ 	}
+
+-	ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150)
++	ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150, false)
+ 	assert.NoError(err)
+ 	requireQueryDeal := func() (DealState, string) {
+ 		resp, err := c.QueryDeal(ctx, ref.ProposalCid)","I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string ""no duplicates"" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the duplicates boolean is set false. 3. Start out in a state with more than 1 duplicates. Verify that the LastDuplicate field is set to the last duplicate when we propose with a true duplicates bool."
+5279,"@@ -74,7 +74,7 @@ namespace OpenTelemetry
+         {
+             if (timeoutMilliseconds < 0 && timeoutMilliseconds != Timeout.Infinite)
+             {
+-                throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds));
++                throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds), timeoutMilliseconds, $""timeout milliseconds should not be below 0 or infinite, but was: {timeoutMilliseconds}"");
+             }
+
+             if (Interlocked.Increment(ref this.shutdownCount) > 1)",`Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67.
+5280,"@@ -38,6 +38,7 @@ using System.Linq;
+ using Xunit;
+ using NLog.Common;
+ using System.Text;
++using Xunit.Extensions;
+
+ namespace NLog.UnitTests.Common
+ {",I think we need `#if !SILVERLIGHT` here and at the test.
+5281,"@@ -26,6 +26,7 @@ import javafx.collections.transformation.SortedList;
+ import javafx.event.EventHandler;
+ import javafx.scene.input.MouseEvent;
+ import me.xdrop.fuzzywuzzy.FuzzySearch;
++import org.eclipse.jgit.util.StringUtils;
+ import org.phoenicis.javafx.settings.JavaFxSettingsManager;
+ import org.phoenicis.javafx.views.common.ExpandedList;
+ import org.phoenicis.javafx.views.common.ThemeManager;",Can you change this import to the apache dependency? I didn't even know that jgit contains such a method...
+5282,"@@ -34,11 +34,11 @@ func GenerateServiceAccountName(gServiceAccount, clusterName string) string {
+ }
+
+ // MakeServiceAccount creates a K8s ServiceAccount object for the Namespace.
+-func MakeServiceAccount(namespace string, gServiceAccount, clusterName string) *corev1.ServiceAccount {
++func MakeServiceAccount(namespace string, kServiceAccount, gServiceAccount, clusterName string) *corev1.ServiceAccount {
+ 	return &corev1.ServiceAccount{
+ 		ObjectMeta: metav1.ObjectMeta{
+ 			Namespace: namespace,
+-			Name:      GenerateServiceAccountName(gServiceAccount, clusterName),
++			Name:      kServiceAccount,
+ 			Annotations: map[string]string{
+ 				WorkloadIdentityKey: gServiceAccount,
+ 			},","Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler."
+5283,"@@ -50,13 +50,15 @@ interpreted as encoded JSON and formatted accordingly.  If '-r', value
+ is displayed without a newline.  If '-t', the RFC 11 object is displayed.
+ '-a treeobj' causes the lookup to be relative to an RFC 11 snapshot reference.
+
+-*put* [-j|-r|-t] [-n] 'key=value' ['key=value...']::
++*put* [-j|-r|-t] [-n] [-A] 'key=value' ['key=value...']::
+ Store 'value' under 'key' and commit it.  If it already has a value,
+ overwrite it.  If no options, value is stored directly.  If '-j', it is
+ first encoded as JSON, then stored.  If '-r', the value may be read from
+ standard input if specified as ""-"", and may include embedded NULL bytes.
+ If '-t', value is stored as a RFC 11 object.  '-n' prevents the commit
+-from being merged with with other contemporaneous commits.
++from being merged with with other contemporaneous commits.  '-A' appends the
++value to a key instead of overwriting the value.  Append is incompatible with
++the -j option.
+
+ *ls* [-R] [-d] [-F] [-w COLS] [-1] ['key' ...]::
+ Display directory referred to by _key_, or ""."" (root) if unspecified.","should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON."
+5284,"@@ -49,7 +49,7 @@ func init() {
+ 	flags.BoolVarP(cmdFlags, &checkControl, ""check-control"", """", true, ""Check control characters."")
+ 	flags.DurationVarP(cmdFlags, &uploadWait, ""upload-wait"", """", 0, ""Wait after writing a file."")
+ 	flags.BoolVarP(cmdFlags, &checkLength, ""check-length"", """", true, ""Check max filename length."")
+-	flags.BoolVarP(cmdFlags, &checkStreaming, ""check-streaming"", """", true, ""Check uploadxs with indeterminate file size."")
++	flags.BoolVarP(cmdFlags, &checkStreaming, ""check-streaming"", """", true, ""Check uploads with indeterminate file size."")
+ }
+
+ var commandDefinition = &cobra.Command{",I presume this isn't some special term...
+5285,"@@ -79,6 +79,18 @@ function pAsHeadingEvaluate(node, options, virtualNode) {
+   const nextStyle = nextSibling ? getStyleValues(nextSibling) : null;
+   const prevStyle = prevSibling ? getStyleValues(prevSibling) : null;
+
++  if (node && nextSibling) {
++    const headingLength = node.textContent.trim().length;
++    const paragraphLength = nextSibling.textContent.trim().length;
++    if (headingLength > paragraphLength) {
++      return true;
++    } else if (headingLength < paragraphLength / 2) {
++      return false;
++    } else {
++      undefined;
++    }
++  }
++
+   if (!nextStyle || !isHeaderStyle(currStyle, nextStyle, margins)) {
+     return true;
+   }",Did you mean to return here? ;) You'll also need to add an `incomplete` message to the rule metadata.
+5286,"@@ -540,6 +540,14 @@ const (
+ 	//    This is replaced at runtime
+ 	JivaClusterIPHolder JivaAnnotations = ""__CLUSTER_IP__""
+
++	// JivaCloneIPHolder is used as a placeholder for sync controller IP address
++	// which will be used as cloneIP
++	//
++	// NOTE:
++	//    This is replaced at runtime
++	JivaCloneIPHolder JivaAnnotations = ""__CLONE_IP__""
++
++	JivaReplicaTypeHolder JivaAnnotations = ""clone""
+ 	// JivaStorageSizeHolder is used as a placeholder for persistent volume's
+ 	// storage capacity
+ 	//",Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good.
+5287,"@@ -38,6 +38,8 @@ public class RestClientSenderFilter implements ConsumerFilter {
+
+   @Override
+   public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
++    invocation.onStartSendRequest();
++
+     CompletableFuture<Response> future = new RestClientSender(invocation)
+         .send();
+ ",`invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send`
+5288,"@@ -218,8 +218,8 @@ func (ap *actPool) Add(ctx context.Context, act action.SealedEnvelope) error {
+ 	if act.GasPrice().Cmp(ap.cfg.MinGasPrice()) < 0 {
+ 		actpoolMtc.WithLabelValues(""gasPriceLower"").Inc()
+ 		log.L().Info(""action rejected due to low gas price"",
+-			zap.String(""act hash"", hex.EncodeToString(hash[:])),
+-			zap.String(""gas price"", act.GasPrice().String()))
++			zap.String(""actionHash"", hex.EncodeToString(hash[:])),
++			zap.String(""gasPrice"", act.GasPrice().String()))
+ 		return action.ErrUnderpriced
+ 	}
+ 	if err := ap.validate(ctx, act); err != nil {","use ""actionHash"" to be consistent with other places"
+5289,"@@ -4,11 +4,14 @@
+
+ package net.sourceforge.pmd.lang.rule.properties;
+
++import java.util.Collections;
+ import java.util.Enumeration;
+ import java.util.Map;
+
++import net.sourceforge.pmd.EnumeratedPropertyDescriptor;
+ import net.sourceforge.pmd.PropertyDescriptorFactory;
+-import net.sourceforge.pmd.lang.rule.properties.factories.BasicPropertyDescriptorFactory;
++import net.sourceforge.pmd.PropertyDescriptorField;
++import net.sourceforge.pmd.util.CollectionUtil;
+
+ /**
+  * Defines a datatype with a set of preset values of any type as held within a","Can we derive `Class<E>` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me."
+5290,"@@ -5364,6 +5364,17 @@ TEST_F(VkLayerTest, AndroidHardwareBufferCreateYCbCrSampler) {
+     m_errorMonitor->SetUnexpectedError(""VUID-VkSamplerYcbcrConversionCreateInfo-xChromaOffset-01651"");
+     vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
+     m_errorMonitor->VerifyFound();
++
++    m_errorMonitor->ExpectSuccess();
++    efa.externalFormat = AHARDWAREBUFFER_FORMAT_Y8Cb8Cr8_420;
++    sycci.format = VK_FORMAT_UNDEFINED;
++    sycci.ycbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_YCBCR_709;
++    sycci.ycbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_NARROW;
++    // Spec says if we use VkExternalFormatANDROID value of components is ignored.
++    sycci.components = {VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO};
++    vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
++    m_errorMonitor->VerifyNotFound();
++    vk::DestroySamplerYcbcrConversion(dev, ycbcr_conv, nullptr);
+ }
+
+ TEST_F(VkLayerTest, AndroidHardwareBufferPhysDevImageFormatProp2) {","I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set the swizzle to anything I want, so I guess this is valid usage here... but now I am more curious if I have an external format does it not have to follow any component swizzle rules and can be anything regardless of the `ycbcrModel`? (I guess really a question for @critsec and is not a blocking concern for the scope of this PR)"
+5291,"@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
+ 		return """", err
+ 	}
+
+-	if app.SiteStatus() != ""running"" {
+-		return """", errors.New(""app not running locally. Try `ddev start`"")
++	if app.SiteStatus() != platform.SiteRunning {
++		return """", errors.New(""App not running locally. Try `ddev start`"")
+ 	}
+
+ 	db, err := app.FindContainerByType(""db"")","I'd say the error should be an error, not instructions to the user. So error would be something like ""site should be running and is not"""
+5292,"@@ -894,8 +894,11 @@ class SNSTest(unittest.TestCase):
+         return queue_name, queue_arn, queue_url
+
+     def test_publish_sms_endpoint(self):
++        # Clean posible previous sms messages
++        sns_backend = SNSBackend.get()
++        sns_backend.sms_messages = []
++
+         def check_messages():
+-            sns_backend = SNSBackend.get()
+             self.assertEqual(len(list_of_contacts), len(sns_backend.sms_messages))
+
+         list_of_contacts = [""+10123456789"", ""+10000000000"", ""+19876543210""]","Thanks for this PR @pinzon !   Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have duplicates across different tests). We're planning to introduce test parallelization in the near future, and this will help us avoiding undesired side-effects.   Thanks"
+5293,"@@ -21,10 +21,12 @@ import (
+ 	""context""
+ 	""errors""
+ 	""sync""
+-	""time""
++
++	""github.com/asaskevich/EventBus""
+
+ 	log ""github.com/cihub/seelog""
+-	""github.com/mysteriumnetwork/node/client/stats""
++	stats_dto ""github.com/mysteriumnetwork/node/client/stats/dto""
++
+ 	""github.com/mysteriumnetwork/node/communication""
+ 	""github.com/mysteriumnetwork/node/firewall""
+ 	""github.com/mysteriumnetwork/node/identity""",Some weird blocks formation again.
+5294,"@@ -39,7 +39,7 @@ func TestOvirtActuator(t *testing.T) {
+ 			clusterDeployment: testOvirtClusterDeployment(),
+ 			pool:              testOvirtPool(),
+ 			expectedMachineSetReplicas: map[string]int64{
+-				fmt.Sprintf(""%s-worker-0"", testInfraID): 3,
++				fmt.Sprintf(""%s-worker"", testInfraID): 3,
+ 			},
+ 		},
+ 	}",This is worrisome.
+5295,"@@ -219,6 +219,9 @@ type FilesystemTrimDriver interface {
+ 	// AutoFilesystemTrimStatus returns the status of auto fs trim
+ 	// operations on volumes
+ 	AutoFilesystemTrimStatus(request *api.SdkAutoFSTrimStatusRequest) (*api.SdkAutoFSTrimStatusResponse, error)
++	// AutoFilesystemTrimUsage returns the usage of auto fs trim
++	// operations on locally mounted volumes
++	AutoFilesystemTrimUsage(request *api.SdkAutoFSTrimUsageRequest) (*api.SdkAutoFSTrimUsageResponse, error)
+ 	// FilesystemTrimStop stops a filesystem trim background operation on
+ 	// a specified volume, if any
+ 	FilesystemTrimStop(request *api.SdkFilesystemTrimStopRequest) (*api.SdkFilesystemTrimStopResponse, error)","nit try rephrasing to something like "" AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes"""
+5296,"@@ -64,7 +64,7 @@ module Unix
+       h = self.foss_defaults
+       h['puppetserver-confdir'] = '/etc/puppetlabs/puppetserver/conf.d'
+       h['puppetservice']  = 'puppetserver'
+-      h['puppetbindir']   = '/opt/puppetlabs/agent/bin'
++      h['puppetbindir']   = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin'
+       h['puppetbin']      = ""#{h['puppetbindir']}/puppet""
+       h['puppetpath']     = '/etc/puppetlabs/agent'
+       h['puppetconfdir']  = ""#{h['puppetpath']}/config""","currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppetlabs/puppet/bin`"
+5297,"@@ -4,10 +4,10 @@ import Ember from 'ember';
+ import PouchAdapterUtils from 'hospitalrun/mixins/pouch-adapter-utils';
+
+ export default Adapter.extend(PouchAdapterUtils, {
+-    databaseName: 'config',
+-    db:  Ember.computed.alias('pouchDBService.configDB'),
+-    pouchDBService: Ember.inject.service('pouchdb'),
+-
++    databaseName: 'config',
++    database: Ember.inject.service(),
++    db:  Ember.computed.alias('database.configDB'),
++
+     _mapQuery: function(doc, emit) {
+         if (doc._id) {
+             emit(doc._id, null);",any point in keeping this here ?
+5298,"@@ -233,8 +233,8 @@ type GossipData struct {
+ }
+
+ func (g *GossipData) Merge(o router.GossipData) {
+-	checkAndPanic(CaseSensitive(g.Entries))
+-	defer func() { checkAndPanic(CaseSensitive(g.Entries)) }()
++	checkAndPanic(CaseInsensitive(g.Entries))
++	defer func() { checkAndPanic(CaseInsensitive(g.Entries)) }()
+ 	other := o.(*GossipData)
+ 	g.Entries.merge(other.Entries)
+ 	if g.Timestamp < other.Timestamp {",I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver).
+5299,"@@ -1,6 +1,11 @@
+ #include ""engine/routing_algorithms/shortest_path.hpp""
++
++#ifdef OSRM_EXTERNAL_MEMORY
++#include ""routing/routing_base_offline.hpp""
++#else
+ #include ""engine/routing_algorithms/routing_base_ch.hpp""
+ #include ""engine/routing_algorithms/routing_base_mld.hpp""
++#endif
+
+ #include <boost/assert.hpp>
+ #include <boost/optional.hpp>","This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantiate own implementations using private impl headers. Otherwise we again make wrong dependencies into OSRM code and block changes in separate projects."
+5300,"@@ -149,6 +149,8 @@ void PDPSimpleListener::onNewCacheChangeAdded(RTPSReader* reader, const CacheCha
+             {
+                 listener->onParticipantDiscovery(this->mp_SPDP->getRTPSParticipant()->getUserRTPSParticipant(), std::move(info));
+             }
++
++            return; // change already removed from history
+         }
+     }
+ ","Then, where is it removed?"
+5301,"@@ -16,6 +16,7 @@ func TestVHostTrie(t *testing.T) {
+ 		""example.com/foo/bar"",
+ 		""*.example.com/test"",
+ 	})
++	CaseSensitivePath = true
+ 	assertTestTrie(t, trie, []vhostTrieTest{
+ 		{""not-in-trie.com"", false, """", ""/""},
+ 		{""example"", true, ""example"", ""/""},",The tests are not run concurrently? (I don't know. Better check.)
+5302,"@@ -131,7 +131,7 @@ Blockly.FieldTextInput.prototype.showEditor_ = function(opt_quietInput) {
+   var htmlInput = goog.dom.createDom('input', 'blocklyHtmlInput');
+   htmlInput.setAttribute('spellcheck', this.spellcheck_);
+   var fontSize =
+-      (Blockly.FieldTextInput.FONTSIZE * this.workspace_.scale) + 'pt';
++      (Blockly.FieldTextInput.FONTSIZE) + 'pt';
+   div.style.fontSize = fontSize;
+   htmlInput.style.fontSize = fontSize;
+   /** @type {!HTMLInputElement} */",Regardless of scale?
+5303,"@@ -44,6 +44,14 @@ var dataDirectory = flag.String(""d"", """", ""Root Algorand daemon data path"")
+ var versionCheck = flag.Bool(""v"", false, ""Display and write current build version and exit"")
+ var telemetryOverride = flag.String(""t"", """", `Override telemetry setting if supported (Use ""true"", ""false"", ""0"" or ""1"")`)
+
++// the following flags aren't being used by the algoh, but are needed so that the flag package won't complain that
++// these flags were provided but were not defined. We grab all the input flags and pass these downstream to the algod executable
++// as an input arguments.
++var peerOverride = flag.String(""p"", """", ""Override phonebook with peer ip:port (or semicolon separated list: ip:port;ip:port;ip:port...)"")
++var listenIP = flag.String(""l"", """", ""Override config.EndpointAddress (REST listening address) with ip:port"")
++var seed = flag.String(""seed"", """", ""input to math/rand.Seed()"")
++var genesisFile = flag.String(""g"", """", ""Genesis configuration file"")
++
+ const algodFileName = ""algod""
+ const goalFileName = ""goal""
+ ",Nit: should not we hide them from printing out?
+5304,"@@ -196,7 +196,7 @@ test_pipeline = [
+             dict(type='RandomFlip'),
+             dict(type='Normalize', **img_norm_cfg),
+             dict(type='Pad', size_divisor=32),
+-            dict(type='ImageToTensor', keys=['img']),
++            dict(type='DefaultFormatBundle'),
+             dict(type='Collect', keys=['img']),
+         ])
+ ]",What is the reason to modify those things? I noticed it breaks the examples using `asyncio`
+5305,"@@ -33,7 +33,7 @@ import (
+
+ const (
+ 	// Encoding is the name of this encoding.
+-	Encoding transport.Encoding = ""protobuf""
++	Encoding transport.Encoding = ""proto""
+
+ 	rawResponseHeaderKey = ""rpc-protobuf-raw-response""
+ )",WHOOOOOOOPS! so this is a wire protocol breaking change. I deployed a dev version of yarpc 1.9 to demo-yarpc-go and it caused bad request errors because it couldn't determine the procedure anymore. (in coordination with yarpc-prober)
+5306,"@@ -1,5 +1,9 @@
+ 'use strict';
+
++const parseConnectionString = require('./core/uri_parser');
++
++const writeConcernKeys = new Set(['w', 'wtimeout', 'j', 'fsync', 'wtimeoutMS', 'journal']);
++
+ /**
+  * The **WriteConcern** class is a class that represents a MongoDB WriteConcern.
+  * @class","if we keep this, can we stick to our convention of using UPPER_CASE for constants? Otherwise this looks like a floating variable to me."
+5307,"@@ -341,7 +341,7 @@ class GTPPDUSessionContainer(Packet):
+         return p
+
+     def hashret(self):
+-        return struct.pack(""H"", self.seq)
++        return struct.pack(""H"", getattr(self.underlayer, ""seq""))
+
+
+ class GTPEchoRequest(Packet):",You probably don't want to assume that `self.underlayer` has a `seq` attribute.
+5308,"@@ -65,10 +65,6 @@ class DisplayLanguageOptionFactory implements FactoryInterface
+         if (!empty($options)) {
+             throw new \Exception('Unexpected options sent to factory.');
+         }
+-        // We want to construct a separate translator instance for this helper,
+-        // since it configures different language/locale than the core shared
+-        // instance!
+-        $factory = new \VuFind\I18n\Translator\TranslatorFactory();
+-        return new $requestedName($factory($container, Translator::class));
++        return new $requestedName($container->get(Translator::class));
+     }
+ }",This apparently breaks the language selection.
+5309,"@@ -0,0 +1,10 @@
++# This migration comes from acts_as_taggable_on_engine (originally 5)
++# This migration is added to circumvent issue #623 and have special characters
++# work properly
++class ChangeCollationForTagNames < ActiveRecord::Migration
++  def up
++    if ActsAsTaggableOn::Utils.using_mysql?
++      execute(""ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;"")
++    end
++  end
++end","since we're not using mysql, do we need this migration?"
+5310,"@@ -453,6 +453,9 @@ OUTBOUND_HTTP_PROXY = os.environ.get(""OUTBOUND_HTTP_PROXY"", """")
+ # Equivalent to HTTPS_PROXY, but only applicable for external connections
+ OUTBOUND_HTTPS_PROXY = os.environ.get(""OUTBOUND_HTTPS_PROXY"", """")
+
++# Whether to enable the partition adjustment listener (in order to support other partitions that the default)
++PARTITION_ADJUSTMENT = is_env_true(""PARTITION_ADJUSTMENT"")
++
+ # list of environment variable names used for configuration.
+ # Make sure to keep this in sync with the above!
+ # Note: do *not* include DATA_DIR in this list, as it is treated separately",i'm not sure about htis naming here. both the word partition and adjustment are very ambiguous and it's not clear what it does. i would maybe go for something less generic and more concrete like `GOV_CLOUD_SUPPORT`
+5311,"@@ -78,7 +78,13 @@ public class MockExecutorLoader implements ExecutorLoader {
+   @Override
+   public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
+       throws ExecutorManagerException {
+-    return new ConcurrentHashMap<>();
++    return this.activeFlows;
++  }
++
++  @Override
++  public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
++      throws ExecutorManagerException {
++    return this.activeFlows;
+   }
+
+   @Override",unfinishedFlows might not be the same as activeFlows. Will it cause confusion here?
+5312,"@@ -73,3 +73,18 @@ func Example() {
+ 	cfg := snapshot.Value.(MyConfig)
+ 	_ = cfg
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""runtimeconfigurator://myproject/myconfigid/myvar?decoder=string"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}","Same, remove the error handling."
+5313,"@@ -1,14 +1,16 @@
+-// IMvxAppStart.cs
++// IMvxAppStart.cs
+
+ // MvvmCross is licensed using Microsoft Public License (Ms-PL)
+ // Contributions and inspirations noted in readme.md and license.txt
+ //
+ // Project Lead - Stuart Lodge, @slodge, me@slodge.com
+
++using System.Threading.Tasks;
++
+ namespace MvvmCross.Core.ViewModels
+ {
+     public interface IMvxAppStart
+     {
+-        void Start(object hint = null);
++        Task Start(object hint = null);
+     }
+ }",We should not change this at this time.
+5314,"@@ -242,8 +242,8 @@ class AnchorGenerator(object):
+         Args:
+             base_anchors (torch.Tensor): The base anchors of a feature grid.
+             featmap_size (tuple[int]): Size of the feature maps.
+-            stride (tuple[int], optional): Stride of the feature map.
+-                Defaults to (16, 16).
++            stride (tuple[int], optional): Stride of the feature map in order
++                (w, h). Defaults to (16, 16).
+             device (str, optional): Device the tensor will be put on.
+                 Defaults to 'cuda'.
+ ",We may also update the docstring in the AnchorGenerator's arguments at around line 15.
+5315,"@@ -930,7 +930,7 @@ bool CoreChecks::ValidateAndUpdateQFOScoreboard(const debug_report_data *report_
+                        "" duplicates existing barrier submitted in this batch from command buffer %s."",
+                        ""vkQueueSubmit()"", BarrierRecord::BarrierName(), operation, BarrierRecord::HandleName(),
+                        report_data->FormatHandle(barrier.handle).c_str(), barrier.srcQueueFamilyIndex, barrier.dstQueueFamilyIndex,
+-                       report_data->FormatHandle(inserted.first->second).c_str());
++                       report_data->FormatHandle(inserted.first->second->commandBuffer).c_str());
+     }
+     return skip;
+ }",FormatHandle isn't current typesafe w.r.t. requiring *VULKAN* handles... so this slipped through.
+5316,"@@ -21,6 +21,7 @@ import (
+ 	""errors""
+ 	""testing""
+
++	""github.com/asaskevich/EventBus""
+ 	""github.com/stretchr/testify/assert""
+
+ 	""github.com/mysteriumnetwork/node/identity""","What kind of dependency is here, I think we have own implementation of event wo external dependencies"
+5317,"@@ -125,6 +125,18 @@ SYCL::SYCLDevice::SYCLDevice(sycl::device d) : m_device(std::move(d)) {}
+ SYCL::SYCLDevice::SYCLDevice(const sycl::device_selector& selector)
+     : m_device(selector.select_device()) {}
+
++SYCL::SYCLDevice::SYCLDevice(size_t id) {
++  std::vector<sycl::device> gpu_devices =
++      sycl::device::get_devices(sycl::info::device_type::gpu);
++  if (id >= gpu_devices.size()) {
++    std::stringstream error_message;
++    error_message << ""Requested GPU with id "" << id << "" but only ""
++                  << gpu_devices.size() << "" GPU(s) available!\n"";
++    Kokkos::abort(error_message.str().c_str());
++  }
++  m_device = gpu_devices[id];
++}
++
+ sycl::device SYCL::SYCLDevice::get_device() const { return m_device; }
+
+ void SYCL::impl_initialize(SYCL::SYCLDevice d) {",Throw an exception instead
+5318,"@@ -6,6 +6,9 @@ RSpec.describe Org::CreateLastMonthCreatedPlanService do
+   let(:org) do
+     FactoryBot.create(:org, created_at: DateTime.new(2018, 04, 01))
+   end
++  let(:org2) do
++    FactoryBot.create(:org)
++  end
+   let(:template) do
+     FactoryBot.create(:template, org: org)
+   end",we shouldn't need the `FactoryBot.` in these. Ok to leave for now since all of these specs have them. Can clean up later
+5319,"@@ -80,7 +80,7 @@ class File extends FileBase
+             $uploadsPath .= '/protected';
+         }
+
+-        return Url::asset($uploadsPath) . '/';
++        return Storage::url($uploadsPath) . '/';
+     }
+
+     /**",Isn't the better option to actually do `$this->getDisk()->url($uploadsPath)` without changing the filesystems config? Not sure why you think that change is required but it's definitely not getting merged.
+5320,"@@ -1585,7 +1585,7 @@ accessed. Python regular expressions are accepted."",
+             not isinstance(itemmethod, nodes.FunctionDef)
+             or itemmethod.root().name != ""builtins""
+             or not itemmethod.parent
+-            or itemmethod.parent.name not in SEQUENCE_TYPES
++            or itemmethod.parent.frame().name not in SEQUENCE_TYPES
+         ):
+             return None
+ ",Not sure if we need this. It's not tested because it only guards against a new conditional definition of a dunder method in a built-in package. I am fine with leaving it out.
+5321,"@@ -0,0 +1,16 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++using Microsoft.DotNet.Build.Common.Desktop;
++
++namespace Microsoft.DotNet.Build.Tasks.Feed
++{
++    public partial class PushToBlobFeed
++    {
++        static PushToBlobFeed()
++        {
++            AssemblyResolver.Enable();
++        }
++    }
++}","Is this the only task in this library? If so this is good, if not then we should do it for each task."
+5322,"@@ -245,7 +245,7 @@ func (ops *Operations) GetCstorVolumeCountEventually(namespace, lselector string
+ 		cvCount := ops.GetCVCount(namespace, lselector)
+ 		return cvCount
+ 	},
+-		60, 10).Should(Equal(expectedCVCount))
++		120, 10).Should(Equal(expectedCVCount))
+ }
+
+ // GetCstorVolumeReplicaCountEventually gives the count of cstorvolume based on",I am not sure what is 120 and what is 10. Hence unable to review.
+5323,"@@ -47,8 +47,9 @@ type Options struct {
+ 	Location   OptionsLocation
+ 	Transactor OptionsTransactor
+
+-	Openvpn  Openvpn
+-	Firewall OptionsFirewall
++	EnableDNS bool
++	Openvpn   Openvpn
++	Firewall  OptionsFirewall
+ }
+
+ // OptionsKeystore stores the keystore configuration",Not needed anymore
+5324,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package pingpong exposes the simple ping-pong protocol
++// which measures RTT with other peers.
+ package pingpong
+
+ import (",Please not abbreviations
+5325,"@@ -199,6 +199,10 @@ var ValidateResponseHandler = request.NamedHandler{Name: ""core.ValidateResponseH
+ // AfterRetryHandler performs final checks to determine if the request should
+ // be retried and how long to delay.
+ var AfterRetryHandler = request.NamedHandler{Name: ""core.AfterRetryHandler"", Fn: func(r *request.Request) {
++	if !aws.IsReaderSeekable(r.Body) {
++		r.Retryable = aws.Bool(false)
++	}
++
+ 	// If one of the other handlers already set the retry state
+ 	// we don't want to override it based on the service's state
+ 	if r.Retryable == nil || aws.BoolValue(r.Config.EnforceShouldRetryCheck) {",This shouldn't get stomped over on line 207
+5326,"@@ -37,6 +37,7 @@ func (tok Token) String() string {
+ }
+
+ // A Position describes a position in a source file.
++// All properties in Position are zero indexed
+ type Position struct {
+ 	Filename string
+ 	Offset   int",are they not 1-indexed?
+5327,"@@ -272,7 +272,7 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount, checkAllo
+ 	}
+
+ 	currentTime := s.timeNow().Unix()
+-	if currentTime == lastTime.CheckTimestamp {
++	if currentTime == lastTime.CheckTimestamp || currentTime == lastTime.Timestamp {
+ 		return nil, 0, ErrSettlementTooSoon
+ 	}
+ ",I know that previously this check was here but @ralph-pichler replaced it with the `CheckTimestamp` field stating that checking against `Timestamp` was incorrect. @ralph-pichler can you elaborate?
+5328,"@@ -0,0 +1,19 @@
++# Copyright (c) Open-MMLab. All rights reserved.
++
++__version__ = '2.3.0rc0'
++short_version = '2.3.0rc0'
++
++
++def parse_version_info(version_str):
++    version_info = []
++    for x in version_str.split('.'):
++        if x.isdigit():
++            version_info.append(int(x))
++        elif x.find('rc') != -1:
++            patch_version = x.split('rc')
++            version_info.append(int(patch_version[0]))
++            version_info.append(f'rc{patch_version[1]}')
++    return tuple(version_info)
++
++
++version_info = parse_version_info(__version__)",`short_version = __version__`
+5329,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[UpdateAccessKey.java demonstrates how to update the status of an access key for an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[UpdateAccessKey.java demonstrates how to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+5330,"@@ -19,11 +19,12 @@
+
+ package org.apache.iceberg.spark;
+
++import java.io.Serializable;
+ import org.apache.iceberg.StructLike;
+ import org.apache.iceberg.types.Types;
+ import org.apache.spark.sql.Row;
+
+-public class SparkStructLike implements StructLike {
++public class SparkStructLike implements StructLike, Serializable {
+
+   private final Types.StructType type;
+   private Row wrapped;",Required for the SparkDataFile SerDe
+5331,"@@ -2595,16 +2595,8 @@ bool SwiftLanguageRuntime::CouldHaveDynamicValue(ValueObject &in_value) {
+     // Swift class instances are actually pointers, but base class instances
+     // are inlined at offset 0 in the class data. If we just let base classes
+     // be dynamic, it would cause an infinite recursion. So we would usually
+-    // disable it
+-    // But if the base class is a generic type we still need to bind it, and
+-    // that is
+-    // a good job for dynamic types to perform
+-    if (in_value.IsBaseClass()) {
+-      CompilerType base_type(in_value.GetCompilerType());
+-      if (SwiftASTContext::IsFullyRealized(base_type))
+-        return false;
+-    }
+-    return true;
++    // disable it.
++    return !in_value.IsBaseClass();
+   }
+   return var_type.IsPossibleDynamicType(nullptr, false, false, true);
+ }",Do you want to make this an assertion instead?
+5332,"@@ -1,5 +1,5 @@
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2015 NV Access Limited
++#Copyright (C) 2016 NV Access Limited
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ","When updating the copyright, we tend to cover previous years, not just the current. So, if we started the file in 2015, we'd update to say 2015-2016. I'm not sure if there's a legal requirement surrounding this, but it's the convention we and many others have adopted for code."
+5333,"@@ -1180,6 +1180,16 @@ func (fbo *folderBranchOps) SetInitialHeadFromServer(
+ 		return fmt.Errorf(""MD with revision=%d not initialized"", md.Revision())
+ 	}
+
++	// Return early if the head is already set.  This avoids taking
++	// mdWriterLock for no reason.
++	lState := makeFBOLockState()
++	head := fbo.getHead(lState)
++	if head != (ImmutableRootMetadata{}) && head.mdID == md.mdID {
++		fbo.log.CDebugf(ctx, ""Head MD already set to revision %d (%s), no ""+
++			""need to set initial head again"", md.Revision(), md.MergedStatus())
++		return nil
++	}
++
+ 	return runUnlessCanceled(ctx, func() error {
+ 		fb := FolderBranch{md.TlfID(), MasterBranch}
+ 		if fb != fbo.folderBranch {","Wait, so it looks like this function is called _every_ time we fetch the root node, i.e. we do an MD head fetch every time we fetch the root node? Not for this PR, but it seems like we should make that unnecessary, since this function only ever does anything when head is `nil`, i.e. the first time. Maybe add a TODO?"
+5334,"@@ -1948,9 +1948,9 @@ class DomainNameListField(StrLenField):
+     islist = 1
+     padded_unit = 8
+
+-    def __init__(self, name, default, fld=None, length_from=None, padded=False):  # noqa: E501
++    def __init__(self, name, default, length_from=None, padded=False):  # noqa: E501
+         self.padded = padded
+-        StrLenField.__init__(self, name, default, fld, length_from)
++        StrLenField.__init__(self, name, default, length_from=length_from)
+
+     def i2len(self, pkt, x):
+         return len(self.i2m(pkt, x))",Why are you changing this?
+5335,"@@ -35,11 +35,11 @@ func NewConfigParser() *ConsumerConfigParser {
+ }
+
+ // Parse parses the given configuration
+-func (c *ConsumerConfigParser) Parse(config json.RawMessage) (ip string, port int, serviceType services.ServiceType, err error) {
++func (c *ConsumerConfigParser) Parse(config *json.RawMessage) (ip string, port int, serviceType services.ServiceType, err error) {
+ 	// TODO: since we are getting json.RawMessage here and not interface{} type not sure how to handle multiple services
+ 	// since NATPinger is one for all services and we get config from communication channel where service type is not know yet.
+ 	var cfg openvpn.ConsumerConfig
+-	err = json.Unmarshal(config, &cfg)
++	err = json.Unmarshal(*config, &cfg)
+ 	if err != nil {
+ 		return """", 0, """", errors.Wrap(err, ""parsing consumer address:port failed"")
+ 	}","`json.RawMessage` is a `[]byte`, which is already a pointer. Why do we need to have pointer here if we just reading this value?"
+5336,"@@ -29,7 +29,7 @@ func main() {
+ 		cni.ActionAdd.Request,
+ 		cni.ActionCheck.Request,
+ 		cni.ActionDel.Request,
+-		cni_version.PluginSupports(""0.1.0"", ""0.2.0"", ""0.3.0"", ""0.3.1""),
++		cni_version.All,
+ 		fmt.Sprintf(""Antrea CNI %s"", version.GetFullVersionWithRuntimeInfo()),
+ 	)
+ }",should we actually switch to `All` or just add `0.4.0` explicitly to the list of supported CNI versions? What is a new CNI version is released?
+5337,"@@ -23,6 +23,7 @@ from google.cloud.security.notifier import notifier
+
+ from google.cloud.security.common.data_access import csv_writer
+ from google.cloud.security.scanner.audit import fw_rules_engine
++from google.cloud.security.common.gcp_type import resource_util
+ from google.cloud.security.common.data_access import firewall_rule_dao
+ from google.cloud.security.scanner.scanners import base_scanner
+ ",pylint might complain that this isn't alphasorted?
+5338,"@@ -52,6 +52,7 @@ namespace Interop.FunctionalTests
+                 $""--no-sandbox "" +
+                 $""--disable-gpu "" +
+                 $""--allow-insecure-localhost "" +
++                $""--ignore-certificate-errors --enable-features=NetworkService "" +
+                 $""--enable-logging "" +
+                 $""--dump-dom "" +
+                 $""--virtual-time-budget=10000 "" +","It seems that NetworkService is behind a feature flag because it's still experimental. If we see new issues, we should look at flipping this back off."
+5339,"@@ -31,6 +31,19 @@ func (ts *TaskStatus) String() string {
+ 	return ""UNKNOWN""
+ }
+
++// Mapping task status in the agent to that in the backend
++func BackEndStatus(ts *TaskStatus) string {
++	switch *ts {
++	case TaskRunning:
++		return ""RUNNING""
++	case TaskStopped:
++		return ""STOPPED""
++	case TaskDead:
++		return ""STOPPED""
++	}
++	return ""PENDING""
++}
++
+ var containerStatusMap = map[string]ContainerStatus{
+ 	""NONE"":    ContainerStatusNone,
+ 	""UNKNOWN"": ContainerStatusUnknown,","I think it makes more sense to have this be a method on TaskStatus. Also, nit, Backend, not BackEnd."
+5340,"@@ -154,6 +154,10 @@ int HIPInternal::verify_is_initialized(const char *const label) const {
+   return 0 <= m_hipDev;
+ }
+
++uint32_t HIPInternal::impl_get_instance_id() const noexcept {
++  return Kokkos::Tools::Experimental::Impl::idForInstance<
++      Kokkos::Experimental::HIP>(reinterpret_cast<uintptr_t>(this));
++}
+ HIPInternal &HIPInternal::singleton() {
+   static HIPInternal *self = nullptr;
+   if (!self) {",Could you please elaborate on why you need all this magic here? In which cases do you want the same id to be returned? Does this work the same way for all backends?
+5341,"@@ -38,11 +38,8 @@ var (
+ )
+
+ type Config struct {
+-	// Directory in which plugin config files
+-	// reside
+-	ConfigDir string
+-
+-	Log logrus.FieldLogger
++	PluginsConfigs map[string]map[string]common.HclPluginConfig
++	Log            logrus.FieldLogger
+ }
+
+ type catalog struct {",nit: `PluginConfigs` feels a little better
+5342,"@@ -323,7 +323,7 @@ func TestLocalTransfer(t *testing.T) {
+ 	probeSvr := probe.New(7788)
+ 	require.NoError(probeSvr.Start(ctx))
+ 	defer func() {
+-		require.NoError(probeSvr.Stop(ctx))
++		probeSvr.Stop(ctx)
+ 	}()
+
+ 	// Start server","think we need to find out the root-cause and fix, instead of just removing `NoError`? it erred b/c `context canceled`, so call this before context cancelled is the right fix"
+5343,"@@ -405,7 +405,10 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock.
+ 				id, tlfID, context, size)
+ 			dbc := b.config.DiskBlockCache()
+ 			if dbc != nil {
+-				go dbc.Put(ctx, tlfID, id, buf, serverHalf)
++				// This used to be called in a goroutine to prevent blocking
++				// the `Get`. But we need this cached synchronously for
++				// later behavior.
++				dbc.Put(ctx, tlfID, id, buf, serverHalf)
+ 			}
+ 		}
+ 	}()","Please expand ""later behavior"". Presumably something to do with the prefetch logic?"
+5344,"@@ -66,7 +66,7 @@ func (s *server) splitUpload(ctx context.Context, r io.ReadCloser, l int64) (int
+ 		response.Message = ""upload error""
+ 		response.Code = http.StatusInternalServerError
+ 		err = fmt.Errorf(""%s: %v"", response.Message, err)
+-		return response, err
++		return swarm.ZeroAddress, err
+ 	}
+ 	return bytesPostResponse{Reference: address}, nil
+ }","The `response` variable is not used, it can be removed, also the fmt.Errorf."
+5345,"@@ -51,10 +51,7 @@ namespace NLog.Internal
+         internal static bool IsNullOrWhiteSpace(string value)
+         {
+ #if NET3_5
+-
+-            if (value == null) return true;
+-            if (value.Length == 0) return true;
+-            return String.IsNullOrEmpty(value.Trim());
++            return value?.Length > 0 ? string.IsNullOrEmpty(value.Trim()) : true;
+ #else
+             return string.IsNullOrWhiteSpace(value);
+ #endif",Do you find this really easier to read?
+5346,"@@ -11388,8 +11388,9 @@ void RelRoot::setMvBindContext(MvBindContext * pMvBindContext)
+   pMvBindContextForScope_ = pMvBindContext;
+ }
+
+-void RelRoot::addOneRowAggregates(BindWA* bindWA)
++NABoolean RelRoot::addOneRowAggregates(BindWA* bindWA, NABoolean forceGroupByAgg)
+ {
++  NABoolean GroupByAggNodeAdded = FALSE;
+   RelExpr * childOfRoot = child(0);
+   GroupByAgg *aggNode = NULL;
+   // If the One Row Subquery is already enforced by a scalar aggregate",A small nit: This variable should start with a lower case letter.
+5347,"@@ -38,12 +38,13 @@ public class PageStreamingTransformer {
+
+       PageStreamingDescriptorView.Builder descriptor = PageStreamingDescriptorView.newBuilder();
+       descriptor.varName(context.getNamer().getPageStreamingDescriptorName(method));
+-      descriptor.requestTokenFieldName(pageStreaming.getRequestTokenField().getSimpleName());
++      descriptor.requestTokenFieldName(context.getNamer().getRequestTokenFieldName(pageStreaming));
+       if (pageStreaming.hasPageSizeField()) {
+-        descriptor.requestPageSizeFieldName(pageStreaming.getPageSizeField().getSimpleName());
++        descriptor.requestPageSizeFieldName(context.getNamer().getPageSizeFieldName(pageStreaming));
+       }
+-      descriptor.responseTokenFieldName(pageStreaming.getResponseTokenField().getSimpleName());
+-      descriptor.resourcesFieldName(pageStreaming.getResourcesFieldName());
++      descriptor.responseTokenFieldName(
++          context.getNamer().getResponseTokenFieldName(pageStreaming));
++      descriptor.resourcesFieldName(context.getNamer().getResourcesFieldName(pageStreaming));
+       descriptor.methodName(context.getNamer().getMethodKey(method));
+
+       descriptors.add(descriptor.build());",Where is this used for Node?
+5348,"@@ -130,14 +130,14 @@ func (c *Command) handleActions(line string) {
+
+ func (c *Command) connect(argsString string) {
+ 	if len(argsString) == 0 {
+-		info(""Press tab to select identity or create a new one. Connect <your-identity> <node-identity>"")
++		info(""Press tab to select identity or create a new one. Connect <your-id> <provider-id>"")
+ 		return
+ 	}
+
+ 	identities := strings.Fields(argsString)
+
+ 	if len(identities) != 2 {
+-		info(""Please type in the node identity. Connect <your-identity> <node-identity>"")
++		info(""Please type in the provider identity. Connect <your-id> <provider-id>"")
+ 		return
+ 	}
+ ","Is `<your-id>` really easier to understand than `<your-identity>` for CLI user? For me, `identity` seems like a concept we use publicly, and `id` is just an internal shortcut for it."
+5349,"@@ -39,7 +39,11 @@ func (n *NetworkPolicyController) addClusterGroup(curObj interface{}) {
+ 	key := internalGroupKeyFunc(cg)
+ 	klog.V(2).Infof(""Processing ADD event for ClusterGroup %s"", cg.Name)
+ 	newGroup := n.processClusterGroup(cg)
+-	klog.V(2).Infof(""Creating new internal Group %s with selector (%s)"", newGroup.UID, newGroup.Selector.NormalizedName)
++	if newGroup.ServiceReference != nil {
++		klog.V(2).Infof(""Creating new internal Group %s for Service %s/%s"", newGroup.UID, newGroup.ServiceReference.Namespace, newGroup.ServiceReference.Name)
++	} else if newGroup.Selector != nil {
++		klog.V(2).Infof(""Creating new internal Group %s with selector (%s)"", newGroup.UID, newGroup.Selector.NormalizedName)
++	}
+ 	n.internalGroupStore.Create(newGroup)
+ 	n.enqueueInternalGroup(key)
+ }",nit.. `if` .. `else` for logging probably can be avoided.. maybe only log that an internal group was created for cluster group
+5350,"@@ -21,6 +21,7 @@ import (
+ 	""time""
+
+ 	""github.com/aws/amazon-ecs-agent/agent/api""
++	""github.com/aws/amazon-ecs-agent/agent/config""
+ 	""github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks""
+ 	""github.com/aws/amazon-ecs-agent/agent/engine/testdata""
+ 	""github.com/aws/amazon-ecs-agent/agent/eventstream""",There's a lot of changed tests -- but no new tests. You need unit and integration tests for this.
+5351,"@@ -38,16 +38,16 @@ namespace Nethermind.TxPool.Filters
+             _configuredGasLimit = txPoolConfig.GasLimit ?? long.MaxValue;
+         }
+
+-        public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions handlingOptions)
++        public AcceptTxResult Accept(Transaction tx, TxHandlingOptions handlingOptions)
+         {
+             long gasLimit = Math.Min(_chainHeadInfoProvider.BlockGasLimit ?? long.MaxValue, _configuredGasLimit);
+             if (tx.GasLimit > gasLimit)
+             {
+                 if (_logger.IsTrace) _logger.Trace($""Skipped adding transaction {tx.ToString(""  "")}, gas limit exceeded."");
+-                return (false, AddTxResult.GasLimitExceeded);
++                return AcceptTxResult.GasLimitExceeded;
+             }
+
+-            return (true, null);
++            return AcceptTxResult.Accepted;
+         }
+     }
+ }",WithMessage what gas limit is?
+5352,"@@ -2099,7 +2099,7 @@ describe('Cursor', function() {
+    * @ignore
+    * @api private
+    */
+-  it('cursor stream errors', {
++  it.skip('cursor stream errors', {
+     // Add a tag that our runner can trigger on
+     // in this case we are setting that node needs to be higher than 0.10.X to run
+     metadata: { requires: { topology: ['single'] } },",Why are these skipped?
+5353,"@@ -388,6 +388,13 @@ type MetaManager struct {
+ 	// RemoteQueryTimeout indicates remote query timeout (second)
+ 	// default 60
+ 	RemoteQueryTimeout int32 `json:""remoteQueryTimeout,omitempty""`
++	// The config of MetaServer
++	MetaServer `json:""metaServer,omitempty""`
++}
++
++type MetaServer struct {
++	Enable bool
++	Debug  bool
+ }
+
+ // ServiceBus indicates the ServiceBus module config","We'd better add the `json:""metaServer,omitempty""` here"
+5354,"@@ -0,0 +1,17 @@
++#!/usr/bin/env python3
++import platform
++import sys
++from pathlib import Path
++from subprocess import check_call
++
++here = Path(__file__).parent
++
++pip_install = [
++    sys.executable, ""-m"",
++    ""pip"",
++    ""install"",
++    ""--disable-pip-version-check"",
++]
++
++check_call([*pip_install, ""--require-hashes"", ""-r"", f""requirements-{platform.system().lower()}.txt""], cwd=here)
++check_call([*pip_install, ""--no-deps"", ""-e"", ""../..""], cwd=here)","So... when we want to install mitmproxy with pinned dependencies, we first install all pinned dependencies, and then in a second step install mitmproxy as editable, making sure that no additional dependencies are sneaking in.  "
+5355,"@@ -68,7 +68,10 @@ func Sandbox(args []string) error {
+ 		}
+ 	}
+ 	err = syscall.Exec(cmd, args, env)
+-	return fmt.Errorf(""Failed to exec %s: %s"", cmd, err)
++	if err != nil {
++		return fmt.Errorf(""Failed to exec %s: %s"", cmd, err)
++	}
++	return nil
+ }
+
+ func rewriteEnvVars(env []string, from, to string) {","not sure how this got in master, but the linter is unhappy about it so I fixed it here"
+5356,"@@ -15,3 +15,8 @@ const rekeyRecheckInterval = 30 * time.Second
+
+ // rekeyInitialTTL is the maximum number rechecks each rekey request can trigger.
+ const rekeyInitialTTL = 4
++
++// mdserverReconnectBackoffWindow is a backoff window within which we try to
++// wait randomly for before reconnecting to MD server.
++// TODO: increase this to 5 min
++const mdserverReconnectBackoffWindow = 5 * time.Minute","No need for this TODO anymore, right?"
+5357,"@@ -47,7 +47,8 @@ def main(global_config, config=None, **settings):
+
+     # In Kinto API 1.x, a default bucket is available.
+     # Force its inclusion if not specified in settings.
+-    if 'kinto.plugins.default_bucket' not in settings['includes']:
++    if 'kinto.plugins.default_bucket' not in settings['includes'] \
++	 and 'kinto.plugins.default_bucket' not in settings['excludes']:
+         config.include('kinto.plugins.default_bucket')
+
+     # Retro-compatibility with first Kinto clients.","I would assign the key you're looking for into a variable first, and then use it in the comparisons."
+5358,"@@ -855,6 +855,9 @@ class PluginManager
+         if ($pluginPath = self::instance()->getPluginPath($id)) {
+             File::deleteDirectory($pluginPath);
+         }
++
++        // actually remove the plugin from our internal container
++        unset($this->plugins[ $this->normalizeIdentifier($id) ]);
+     }
+
+     /**",Would be better to normalize it at the start of the method to pass through to all the other calls
+5359,"@@ -167,6 +167,7 @@ class CodeEditor extends FormWidgetBase
+         $this->vars['highlightActiveLine'] = $this->highlightActiveLine;
+         $this->vars['useSoftTabs'] = $this->useSoftTabs;
+         $this->vars['showGutter'] = $this->showGutter;
++        $this->vars['safeMode'] = $this->parentForm->model->isSafeMode();
+         $this->vars['language'] = $this->language;
+         $this->vars['margin'] = $this->margin;
+         $this->vars['stretch'] = $this->formField->stretch;",This can't exist here either because the code editor can be used on other models than CMS templates. You could probably implement this as a `hint` property (so `hint: cms::lang.cms_object.safe_mode_enabled`) on the codeeditor formwidget instead though and I'd be fine with that.
+5360,"@@ -888,6 +888,15 @@ class WordDocumentTextInfo(textInfos.TextInfo):
+ 			field['line-prefix']=mapPUAToUnicode.get(bullet,bullet)
+ 		return field
+
++	def scrollIntoView(self):
++		try:
++			self.obj.WinwordWindowObject.ScrollIntoView(self._rangeObj, True)
++		except COMError:
++			log.exception(""Can't scroll"")
++			pass
++
++
++
+ 	def expand(self,unit):
+ 		if unit==textInfos.UNIT_LINE:
+ 			try:",This line is unnecessary.
+5361,"@@ -119,13 +119,4 @@ Recorder::~Recorder() {
+   UpdateBoundary();
+ }
+
+-void Recorder::Log(unsigned id) {
+-#ifndef LLDB_REPRO_INSTR_TRACE
+-  LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), ""Recording {0}: {1}"", id,
+-           m_pretty_func);
+-#else
+-  llvm::errs() << ""Recording "" << id << "": "" << m_pretty_func << ""\n"";
+-#endif
+-}
+-
+ bool lldb_private::repro::Recorder::g_global_boundary;",How did this compile in the first place? Is there a matching declaration in a header that should be removed too?
+5362,"@@ -56,7 +56,8 @@ mrb_value h2o_mruby__new_str(mrb_state *mrb, const char *s, size_t len, const ch
+     if (mrb->exc != NULL)
+         h2o_mruby__abort_exc(mrb, ""h2o_mruby_new_str:precondition failure"", file, line);
+     mrb_value ret = mrb_str_new(mrb, s, len);
+-    h2o_mruby_assert(mrb);
++    if (mrb->exc != NULL)
++        h2o_mruby__abort_exc(mrb, ""h2o_mruby_new_str:failed to create string:"", file, line);
+     return ret;
+ }
+ ","Please remove the colon at the end, and merge the PR once the CI succeeds. Thank you for the PR."
+5363,"@@ -3,8 +3,5 @@
+ package tools
+
+ import (
+-	_ ""github.com/AlekSi/gocoverutil""
+ 	_ ""github.com/golang/protobuf/protoc-gen-go""
+-	_ ""github.com/jteeuwen/go-bindata/go-bindata""
+-	_ ""github.com/mattn/goveralls""
+ )","whoops. this should be protoc-gen-doc, since that is the only bit left that is built out-of-tree (everything else is either downloaded or built via modules already depended on by spire's go.mod)"
+5364,"@@ -0,0 +1,19 @@
++package azkaban.spi;
++
++import java.util.Map;
++
++/**
++ * Implement this interface to report flow and job events. Event reporter
++ * can be turned on by setting the property {@code AZKABAN_EVENT_REPORTING_ENABLED} to true.
++ *
++ * By default, a KafkaAvroEventReporter is provided. Alternate implementations
++ * can be provided by setting the property {@code AZKABAN_EVENT_REPORTING_CLASS_PARAM}
++ * <br><br>
++ * The constructor will be called with a {@code azkaban.utils.Props} object passed as
++ * the only parameter. If such a constructor doesn't exist, then the AzkabanEventReporter
++ * instantiation will fail.
++ */
++public interface AzkabanEventReporter {
++
++  boolean report(EventType eventType, Map<String, String> metadata);
++}",The convention is to use <p> see the google style guide and use checkstyle to check. You can change it later.
+5365,"@@ -134,12 +134,14 @@ class ListElement(list):
+     def startElement(self, name, attrs, connection):
+         for lm in self.list_marker:
+             if name.endswith(lm):
+-                l = ListElement(self.connection, name, self.item_marker,
++                l = ListElement(self.connection, name, self.list_marker,
++                                self.item_marker,
+                                 pythonize_name=self.pythonize_name)
+                 setattr(self, self.get_name(name), l)
+                 return l
+         if name in self.item_marker:
+             e = Element(self.connection, name, parent=self,
++                        self.list_marker, self.item_marker,
+                         pythonize_name=self.pythonize_name)
+             self.append(e)
+             return e",Using non-keyword args after the keyword arg (parent-self) will cause a SyntaxError.
+5366,"@@ -277,6 +277,13 @@ module Faker
+         '%08x-%04x-%04x-%04x-%04x%08x' % ary # rubocop:disable Style/FormatString
+       end
+
++      def user(*args)
++        user_hash = {}
++        args = %w[username email] if args.empty?
++        args.each { |arg| user_hash[:""#{arg}""] = send(arg) }
++        user_hash
++      end
++
+       alias user_name username
+     end
+   end",I think you'll want to add some YARD docs to this method to get the PR approved
+5367,"@@ -4452,12 +4452,13 @@ ostree_repo_query_object_storage_size (OstreeRepo           *self,
+  * @self: Repo
+  * @objtype: Object type
+  * @sha256: ASCII checksum
+- * @out_variant: (out) (transfer full): Metadata
++ * @out_variant: (out) (nullable) (transfer full): Metadata
+  * @error: Error
+  *
+  * Attempt to load the metadata object @sha256 of type @objtype if it
+  * exists, storing the result in @out_variant.  If it doesn't exist,
+- * %NULL is returned.
++ * @out_variant will be set to %NULL and the function will still
++ * return TRUE.
+  */
+ gboolean
+ ostree_repo_load_variant_if_exists (OstreeRepo       *self,","Hmm, AFAICT `*out_variant` isn't explicitly set to `NULL` in the `ENOENT` case."
+5368,"@@ -87,12 +87,18 @@ func (b *clientFactory) SDKClient(c *cli.Context, namespace string) sdkclient.Cl
+ 		hostPort = localHostPort
+ 	}
+
++	tlsConfig, err := b.createTLSConfig(c)
++	if err != nil {
++		b.logger.Fatal(""Failed to create SDK client"", zap.Error(err))
++	}
++
+ 	sdkClient, err := sdkclient.NewClient(sdkclient.Options{
+ 		HostPort:  hostPort,
+ 		Namespace: namespace,
+ 		Logger:    log.NewZapAdapter(b.logger),
+ 		ConnectionOptions: sdkclient.ConnectionOptions{
+ 			DisableHealthCheck: true,
++			TLS:                tlsConfig,
+ 		},
+ 	})
+ 	if err != nil {","Nit: ""Failed to configure TLS for SDK client""?"
+5369,"@@ -89,7 +89,7 @@ def test_plot_split_value_histogram(params, breast_cancer_split, train_data):
+                                          title='Histogram for feature @index/name@ @feature@',
+                                          xlabel='x', ylabel='y', color='r')
+     assert isinstance(ax1, matplotlib.axes.Axes)
+-    title = 'Histogram for feature name {}'.format(gbm1.booster_.feature_name()[27])
++    title = f'Histogram for feature name {gbm1.booster_.feature_name()[27]}'
+     assert ax1.get_title() == title
+     assert ax1.get_xlabel() == 'x'
+     assert ax1.get_ylabel() == 'y'",please update your branch to the latest `master`. This change was already made in #4359
+5370,"@@ -18,6 +18,8 @@ import (
+ 	""crypto/sha1""
+ 	""errors""
+ 	""fmt""
++	""github.com/pingcap/chaos-mesh/controllers""
++	""time""
+
+ 	""golang.org/x/sync/errgroup""
+ ",This line should be formatted
+5371,"@@ -32,6 +32,9 @@ int main (int argc, char * const * argv)
+ 		(""disable_unchecked_drop"", ""Disables drop of unchecked table at startup"")
+ 		(""fast_bootstrap"", ""Increase bootstrap speed for high end nodes with higher limits"")
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
++		(""block_processor_batch_size"",boost::program_options::value<std::size_t> (), ""Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time)"")
++		(""block_processor_full_size"",boost::program_options::value<std::size_t> (), ""Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536"")
++		(""block_processor_verification_size"",boost::program_options::value<std::size_t> (), ""Increase batch signature verification size in block processor, default 0 (2048 * signature checker threads + 1)"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
+ 		(""debug_dump_online_weight"", ""Dump online_weights table"")","""default 65536"" Not sure if it's important to state, but block_processor_full_size has a different default for fast_bootstrap."
+5372,"@@ -23,5 +23,6 @@ namespace Nethermind.TxPool
+         public uint FutureNonceRetention { get; set; } = 16;
+         public int HashCacheSize { get; set; } = 512 * 1024;
+         public long? GasLimit { get; set; } = null;
++
+     }
+ }",remove unnecessary whitespace changes
+5373,"@@ -46,10 +46,6 @@ func TxnPool(s *transactions.SignedTxn, spec transactions.SpecialAddresses, prot
+ 		return errors.New(""empty address"")
+ 	}
+
+-	if s.Sig != (crypto.Signature{}) && !s.Msig.Blank() {
+-		return errors.New(""signedtxn should only have one of Sig or Msig"")
+-	}
+-
+ 	outCh := make(chan error, 1)
+ 	cx := asyncVerifyContext{s, outCh, &proto}
+ 	verificationPool.EnqueueBacklog(context.Background(), stxnAsyncVerify, &cx, nil)",Are these conditions covered elsewhere ?
+5374,"@@ -59,7 +59,14 @@ TurnType::Enum IntersectionHandler::findBasicTurnType(const EdgeID via_edge,
+     if (!on_ramp && onto_ramp)
+         return TurnType::OnRamp;
+
+-    if (in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAMEID)
++    const auto same_name =
++        !util::guidance::requiresNameAnnounced(name_table.GetNameForID(in_data.name_id),
++                                               name_table.GetRefForID(in_data.name_id),
++                                               name_table.GetNameForID(out_data.name_id),
++                                               name_table.GetRefForID(out_data.name_id),
++                                               street_name_suffix_table);
++
++    if (in_data.name_id != EMPTY_NAMEID && out_data.name_id != EMPTY_NAMEID && same_name)
+     {
+         return TurnType::Continue;
+     }",the above check (by transitivity) checked for `in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAME_ID && out_data.name_id != EMPTY_NAME_ID`. The final check of `out_data.name_id != EMPTY_NAME_ID` is missing now.
+5375,"@@ -583,6 +583,11 @@ out_free:
+
+ fpga_result __FPGA_API__ fpgaDestroyEventHandle(fpga_event_handle *event_handle)
+ {
++	//sanity check
++	if (!event_handle) {
++		return FPGA_INVALID_PARAM;
++	}
++
+ 	struct _fpga_event_handle *_eh = (struct _fpga_event_handle *) *event_handle;
+ 	fpga_result result = FPGA_OK;
+ 	int err = 0;","The event handle is being passed by reference, so the dereference on 591 is actually correct. To follow the convention that variables be declared before executable statements, please change the code to the following: struct _fpga_event_handle *_eh; fpga_result result = FPGA_OK; int err = 0; if (!event_handle) { return FPGA_INVALID_PARAM; } _eh = (struct _fpga_event_handle *) *event_handle;"
+5376,"@@ -42,6 +42,7 @@ class named_mutex;
+ #include ""../plugins/nearest.hpp""
+ #include ""../plugins/timestamp.hpp""
+ #include ""../plugins/viaroute.hpp""
++#include ""../plugins/map_matching.hpp""
+ #include ""../server/data_structures/datafacade_base.hpp""
+ #include ""../server/data_structures/internal_datafacade.hpp""
+ #include ""../server/data_structures/shared_barriers.hpp""",reorder includes to be alphabetically ordered
+5377,"@@ -13,7 +13,8 @@ def anchor_target(anchor_list,
+                   cfg,
+                   gt_labels_list=None,
+                   cls_out_channels=1,
+-                  sampling=True):
++                  sampling=True,
++                  need_unmap=True):
+     """"""Compute regression and classification targets for anchors.
+
+     Args:",Rename `need_unmap` to `unmap`.
+5378,"@@ -26,7 +26,6 @@ import (
+ 	""sigs.k8s.io/controller-runtime/pkg/client""
+
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common""
+-	cm ""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/iochaos""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/stresschaos""","In line 28, it has been declared twice, so removing `cm` should not impact, can you explain me little bit? :)"
+5379,"@@ -16,7 +16,10 @@ import (
+
+ const Name = ""clutch.service.topology""
+
+-type Service interface{}
++type Service interface {
++	acquireTopologyCacheLock()
++	startTopologyCache()
++}
+
+ type client struct {
+ 	config *topologyv1.Config","i don't think these unexported functions belong on the public interface, they can exist solely on the struct."
+5380,"@@ -263,6 +263,13 @@ func (h Helper) NewBindAddresses(addrs []string) []ConfigValue {
+ 	return []ConfigValue{{Class: ""bind"", Value: addrs}}
+ }
+
++// WithDispenser returns a new instance based on d. All others Helper
++// fields are copied, so typically maps are shared with this new instance.
++func (h Helper) WithDispenser(d *caddyfile.Dispenser) Helper {
++	h.Dispenser = d
++	return h
++}
++
+ // ParseSegmentAsSubroute parses the segment such that its subdirectives
+ // are themselves treated as directives, from which a subroute is built
+ // and returned.",I'm not entirely clear on why this is necessary?
+5381,"@@ -317,7 +317,7 @@ def save_session(fname="""", session=None, pickleProto=-1):
+     if not fname:
+         fname = conf.session
+         if not fname:
+-            conf.session = fname = utils.get_temp_file(keep=True)
++            conf.session = fname = cast(str, utils.get_temp_file(keep=True))
+     log_interactive.info(""Use [%s] as session file"" % fname)
+
+     if not session:",Why do we need to cast to `str` here?
+5382,"@@ -17,7 +17,6 @@ import org.testfx.api.FxToolkit;
+ public class AppConfigurationInitialisationTest {
+
+ 	@Test
+-	@Ignore
+ 	public void testAppConfigurationInitialisation() throws TimeoutException {
+ 		FxToolkit.registerPrimaryStage();
+ 		FxToolkit.setupFixture(() -> new AnnotationConfigApplicationContext(AppConfiguration.class));",The ignore import above should be unused now and can be removed.
+5383,"@@ -231,4 +231,12 @@ final class MultiTermQueryConstantScoreWrapper<Q extends MultiTermQuery> extends
+
+     };
+   }
++
++  @Override
++  public void visit(QueryVisitor visitor) {
++    QueryVisitor v = visitor.getSubVisitor(Occur.FILTER, this);
++    if (v != null) {
++      query.visit(v);
++    }
++  }
+ }",redundant null check?
+5384,"@@ -11,5 +11,5 @@ func NewRAMDevice() (*sonm.RAMDevice, error) {
+ 		return nil, err
+ 	}
+
+-	return &sonm.RAMDevice{Total: m.Total}, err
++	return &sonm.RAMDevice{Total: m.Total, Available: m.Total}, err
+ }",initialization of available ram is here
+5385,"@@ -603,8 +603,12 @@ Blockly.Field.prototype.getDisplayText_ = function() {
+   // Replace whitespace with non-breaking spaces so the text doesn't collapse.
+   text = text.replace(/\s/g, Blockly.Field.NBSP);
+   if (this.sourceBlock_.RTL) {
+-    // The SVG is LTR, force text to be RTL.
+-    text += '\u200F';
++    // The SVG is LTR, force text to be RTL unless a number.
++    if (this.sourceBlock_.editable_ && this.sourceBlock_.type === 'math_number') {
++      text += '\u200E';
++    } else {
++      text = '\u202B' + text + '\u202C';
++    }
+   }
+   return text;
+ };",Can have negative numbers with the '-' on the right (`10-`) by just using line 610.
+5386,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteUser.java demonstrates how to delete an AWS Identity and Access Management (IAM) user. This is only possible for users with no associated resources.]
++//snippet-sourcedescription:[DeleteUser.java demonstrates how to delete an AWS Identity and Access Management (AWS IAM) user. This is only possible for users with no associated resources.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+5387,"@@ -2381,11 +2381,10 @@ class ThriftRequestHandler(object):
+                 check_commands, check_durations, cc_version, statistics = \
+                     store_handler.metadata_info(metadata_file)
+
+-                if len(check_commands) == 0:
+-                    command = ' '.join(sys.argv)
+-                elif len(check_commands) == 1:
++                command = ''
++                if len(check_commands) == 1:
+                     command = ' '.join(check_commands[0])
+-                else:
++                elif len(check_commands) > 1:
+                     command = ""multiple analyze calls: "" + \
+                               '; '.join([' '.join(com)
+                                          for com in check_commands])",Shouldn't we use store a message which indicates that there was no available checker command? By the way how is it possible that metadata.json doesn't contain the checker command? Maybe this was the case in the earlier versions?
+5388,"@@ -32,6 +32,10 @@ module RSpec
+         @exclusion_patterns = true_or_false ? [] : DEFAULT_EXCLUSION_PATTERNS.dup
+       end
+
++      def full_backtrace
++        @exclusion_patterns.empty?
++      end
++
+       private
+
+       def matches_an_exclusion_pattern?(line)","Given that this is a boolean predicate, maybe it should be `full_backtrace?`."
+5389,"@@ -12,7 +12,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.""""""
+
+-import ldap, traceback
++import traceback
++
++import ldap
+ from django.conf import settings
+ from django.contrib.auth.models import User
+ ",Just curious why the blank line here?
+5390,"@@ -1,3 +1,3 @@
+ from __future__ import (absolute_import, print_function, division)
+
+-from netlib.version import *
++from mitmproxy.version import *","I like the idea, but we don't want a dependency on mitmproxy in pathod."
+5391,"@@ -49,6 +49,16 @@ namespace Datadog.Trace
+
+         private TimeSpan Elapsed => StopwatchHelpers.GetElapsed(Stopwatch.GetTimestamp() - _timestamp);
+
++        /// <summary>
++        /// Gets or sets a collection of propagated internal Datadog tags,
++        /// formatted as ""key1=value1,key2=value2"".
++        /// </summary>
++        /// <remarks>
++        /// We're keeping this as the string representation to avoid having to parse.
++        /// For now, it's relatively easy to append new values when needed.
++        /// </remarks>
++        public string DatadogTags { get; set; }
++
+         public void AddSpan(Span span)
+         {
+             lock (this)",Why not adding this to the interface and keep passing the interface (as the interface is internal I don't get why you're not adding it there)
+5392,"@@ -70,6 +70,7 @@ from typing import Pattern, Tuple
+
+ import astroid
+ from astroid import nodes
++from astroid.const import PY310_PLUS
+
+ from pylint.checkers import BaseChecker, utils
+ from pylint.checkers.utils import (",`PY310` should probably be imported from `pylint.const`
+5393,"@@ -37,6 +37,14 @@ func (w workflowLoggable) GetValue(key string) string {
+ 	return w.wf.GetSerialConsoleOutputValue(key)
+ }
+
++func (w workflowLoggable) GetValueAsBool(key string) bool {
++	v, err := strconv.ParseBool(w.wf.GetSerialConsoleOutputValue(key))
++	if err != nil {
++		return false
++	}
++	return v
++}
++
+ func (w workflowLoggable) GetValueAsInt64Slice(key string) []int64 {
+ 	return getInt64Values(w.wf.GetSerialConsoleOutputValue(key))
+ }",Can we propagate this error up the stack?
+5394,"@@ -83,7 +83,12 @@ public:
+                              const table& result_values) {
+         auto reference = compute_reference(sigma, x_data, y_data);
+         const double tol = te::get_tolerance<Float>(1e-4, 1e-9);
+-        const double diff = la::l_inf_norm(reference, la::matrix<double>::wrap(result_values));
++        const table reference_table = dal::detail::homogen_table_builder{}
++                                          .reset(reference.get_array(),
++                                                 reference.get_row_count(),
++                                                 reference.get_column_count())
++                                          .build();
++        const double diff = te::abs_error(reference_table, result_values);
+         CHECK(diff < tol);
+     }
+ ",Why reference is converted to table?
+5395,"@@ -203,16 +203,15 @@ struct roots_view *view_at(struct roots_desktop *desktop, double lx, double ly,
+ struct roots_desktop *desktop_create(struct roots_server *server,
+ 		struct roots_config *config) {
+ 	struct roots_desktop *desktop = calloc(1, sizeof(struct roots_desktop));
++	assert(desktop);
+ 	wlr_log(L_DEBUG, ""Initializing roots desktop"");
+
+ 	assert(desktop->views = list_create());
+ 	wl_list_init(&desktop->outputs);
+-	wl_list_init(&desktop->output_add.link);
+-	desktop->output_add.notify = output_add_notify;
+-	wl_list_init(&desktop->output_remove.link);
+-	desktop->output_remove.notify = output_remove_notify;
+
++	desktop->output_add.notify = output_add_notify;
+ 	wl_signal_add(&server->backend->events.output_add, &desktop->output_add);
++	desktop->output_remove.notify = output_remove_notify;
+ 	wl_signal_add(&server->backend->events.output_remove,
+ 		&desktop->output_remove);
+ ",You shouldn't use assert for runtime errors.
+5396,"@@ -15,6 +15,7 @@ return array(
+         'vendor/bootstrap.min.js',
+         'vendor/bootstrap-accessibility.min.js',
+         'vendor/validator.min.js',
++        'vendor/form-attr-polyfill.js', // input[form] polyfill, cannot load conditionally, since we need all versions of IE
+         'autocomplete.js',
+         'common.js',
+         'lightbox.js',","Does this really belong in the vendor directory if you wrote it? At very least, should it get its own repo somewhere in addition to being dropped here?"
+5397,"@@ -78,7 +78,7 @@ public class PMDTaskTest {
+             String actual = IOUtils.toString(in, StandardCharsets.UTF_8);
+             // remove any trailing newline
+             actual = actual.replaceAll(""\n|\r"", """");
+-            Assert.assertEquals(""sample.dummy:0:\tTest Rule 2"", actual);
++            Assert.assertEquals(""sample.dummy:0:\tTest Rule 2:\tSampleXPathRule"", actual);
+         }
+     }
+ }",I think it would be better to place the rule name before the message. Messages are of varying lengths and the rule names will end up misaligned
+5398,"@@ -1719,7 +1719,12 @@ class ComparisonChecker(_BasicChecker):
+                       'Used when comparing an object to a literal, which is usually '
+                       'what you do not want to do, since you can compare to a different '
+                       'literal than what was expected altogether.'),
+-           }
++            'R0124': ('Logical tautology in comparison - %s',
++                      'logical-tautology',
++                      'Used when something is compared against itself.',
++                      ),
++
++            }
+
+     def _check_singleton_comparison(self, singleton, root_node, negative_check=False):
+         if singleton.value is True:",Can we remove the argument from this message? A message will include a line number already that points to the place in the code that has the problem. I think we can remove it.
+5399,"@@ -174,7 +174,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
+             _requestBodyMinimumDataRateNotSatisfied(_logger, connectionId, traceIdentifier, rate, null);
+         }
+
+-        public void ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)
++        public virtual void ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)
+         {
+             _responseMinimumDataRateNotSatisfied(_logger, connectionId, traceIdentifier, null);
+         }","This whole class is now a mix of virtual and non-virtual. I tried to see what would happen if I made everything non-virtual in dev, and the build still passes. It turns out that none of the other methods actually need to be virtual. Can you make *all* the logging methods either virtual or not for consistency? Thanks."
+5400,"@@ -58,6 +58,12 @@ var (
+ 		Value: metadata.DefaultNetwork.AccessPolicyOracleAddress,
+ 	})
+
++	mmnAddressFlag = altsrc.NewStringFlag(cli.StringFlag{
++		Name:  ""mmn-address"",
++		Usage: ""URL of my.mysterium.network API"",
++		Value: metadata.DefaultNetwork.MMNAddress,
++	})
++
+ 	brokerAddressFlag = altsrc.NewStringFlag(cli.StringFlag{
+ 		Name:  ""broker-address"",
+ 		Usage: ""URI of message broker"",","This looks a bit cryptic to me, and also it contains a dash. How about `mymysterium.url`?"
+5401,"@@ -0,0 +1,8 @@
++#include<stdio.h>
++
++void main(){
++	int var = 100;
++	if (&var == 0){
++		print(""Got the value"");
++	}
++}","You did notice the no newline at the end of this file, right?"
+5402,"@@ -75,10 +75,10 @@ namespace Microsoft.CodeAnalysis.Sarif
+         public ISet<Stack> Stacks { get; set; }
+
+         /// <summary>
+-        /// An array of arrays of 'annotatedCodeLocation` objects, each inner array of which comprises a code flow (a possible execution path through the code).
++        /// An array of 'codeFlow' objects relevant to the result.
+         /// </summary>
+         [DataMember(Name = ""codeFlows"", IsRequired = false, EmitDefaultValue = false)]
+-        public IList<IList<AnnotatedCodeLocation>> CodeFlows { get; set; }
++        public ISet<CodeFlow> CodeFlows { get; set; }
+
+         /// <summary>
+         /// A grouped set of locations and messages, if available, that represent code areas that are related to this result.","Here's the object model change. `CodeFlows` is a set of objects of type `CodeFlow`, rather than a list of list of `AnnotatedCodeLocation`. Exactly parallel with `Stacks`."
+5403,"@@ -31,6 +31,7 @@ from .core import decode_node, encode_node, find_object_hashes, hash_contents, F
+ from .models import (Access, Customer, Instance, Invitation, Log, Package,
+                      S3Blob, Tag, UTF8_GENERAL_CI, Version)
+ from .schemas import LOG_SCHEMA, PACKAGE_SCHEMA
++from .config import BAN_PUBLIC_USERS
+
+ QUILT_CDN = 'https://cdn.quiltdata.com/'
+ ","Sorry, one more thing... You should use `app.config` instead of importing it directly. See the code below."
+5404,"@@ -44,8 +44,13 @@ public interface VectorizedReader<T> {
+   void setRowGroupInfo(PageReadStore pages, Map<ColumnPath, ColumnChunkMetaData> metadata);
+
+   /**
+-   * Set up the reader to reuse the underlying containers used for storing batches
++   * Setup the reader to reuse the underlying containers used for storing batches
+    */
+   void reuseContainers(boolean reuse);
++
++  /**
++   * Release any resources allocated
++   */
++  void close();
+ }
+ ","This was correct before; ""setup"" is a noun and ""set up"" is the verb form."
+5405,"@@ -61,7 +61,7 @@ class AdSenseSetupWidget extends Component {
+
+ 	async getAccounts() {
+ 		try {
+-			const responseData = await data.get( TYPE_MODULES, 'adsense', 'accounts' );
++			const responseData = await data.get( TYPE_MODULES, 'adsense', 'accounts', { maybeSetAccount: true } );
+
+ 			/**
+ 			 * Defines the account status. Possible values:",What's the reason for this change here? I didn't see it mentioned in the PR and it's a bit of a confusing param name
+5406,"@@ -12,7 +12,9 @@ function Search() {
+ }
+
+ Search.prototype.query = function(q) {
+-  return this.index.search(q)
++	return q === '~'
++		? this.storage.config.localList.get().map( function( package ){ return { ref: package, score: 1 }; } )
++		: this.index.search(q);
+ }
+
+ Search.prototype.add = function(package) {",I wonder why ~ and not a wildcard instead?
+5407,"@@ -63,6 +63,9 @@ public class PojoProducers implements BeanPostProcessor {
+     // aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
+     // 所以，需要先取出原class，再取标注
+     Class<?> beanCls = BeanUtils.getImplClassFromBean(bean);
++    if(beanCls == null) {
++    	return;
++    }
+     RpcSchema rpcSchema = beanCls.getAnnotation(RpcSchema.class);
+     if (rpcSchema == null) {
+       return;","when will this happened? if happened, just ignore it Silently?"
+5408,"@@ -239,8 +239,10 @@ public class TestMergeAppend extends TableTestBase {
+   public void testManifestMergeMinCount() throws IOException {
+     Assert.assertEquals(""Table should start empty"", 0, listManifestFiles().size());
+     table.updateProperties().set(TableProperties.MANIFEST_MIN_MERGE_COUNT, ""2"")
+-        // each manifest file is 5227 bytes, so 12000 bytes limit will give us 2 bins with 3 manifest/data files.
+-        .set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, ""12000"")
++        // Each initial v1/v2 ManifestFile is 5661/6397 bytes respectively. Merging two of the given
++        // manifests make one v1/v2 ManifestFile of 5672/6408 bytes respectively, so 12850 bytes
++        // limit will give us two bins with three manifest/data files.
++        .set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, ""12850"")
+         .commit();
+
+     TableMetadata base = readMetadata();","3x the smaller size would be around 17k, and we need it to be at least about 13k, which is 2x the larger size. I'd probably set this to 15k to split the difference and hopefully avoid needing to update this again as tests change. This is minor, though."
+5409,"@@ -360,7 +360,9 @@ class DateEncoder(Encoder):
+     if input == SENTINEL_VALUE_FOR_MISSING_DATA:
+       output[0:] = 0
+     else:
+-      assert isinstance(input, datetime.datetime)
++      assert isinstance(input, datetime.datetime), (
++          ""Input is type %s, expected datetime. Value: %s"" % (type(input),
++                                                              str(input)))
+
+       # Get the scalar values for each sub-field
+       scalars = self.getScalars(input)","@scottpurdy, strictly speaking, should this scenario raise a ValueError exception instead of AssertionError?"
+5410,"@@ -0,0 +1,7 @@
++package azkaban.spi;
++
++public enum ExecutorType {
++  // Type of executor where flow runs
++  BAREMETAL,
++  KUBERNETES
++}",Can you please add open source disclaimer?
+5411,"@@ -81,13 +81,11 @@ func (u *unaryHandler) Handle(ctx context.Context, transportRequest *transport.R
+ 	var wireError *wirepb.Error
+ 	if appErr != nil {
+ 		responseWriter.SetApplicationError()
+-		wireError = &wirepb.Error{
+-			appErr.Error(),
+-		}
++		wireError = &wirepb.Error{Message: appErr.Error()}
+ 	}
+ 	wireResponse := &wirepb.Response{
+-		responseData,
+-		wireError,
++		Payload: responseData,
++		Error:   wireError,
+ 	}
+ 	protoBuffer := getBuffer()
+ 	defer putBuffer(protoBuffer)",I dont want to do composite keys on purpose to verify at compile time if the message is completely filled out appropriately @sectioneight
+5412,"@@ -1170,6 +1170,8 @@ func TestServer_SendAction(t *testing.T) {
+ 	}}
+
+ 	chain.EXPECT().ChainID().Return(uint32(1)).Times(2)
++	chain.EXPECT().TipHeight().Return(uint64(4)).Times(2)
++	svr.cfg.Genesis.KamchatkaBlockHeight = 10
+ 	ap.EXPECT().Add(gomock.Any(), gomock.Any()).Return(nil).Times(2)
+
+ 	for i, test := range sendActionTests {","don't need this line, since it is not tested in api_test?"
+5413,"@@ -164,7 +164,7 @@ func CheckForCStorPoolCRD(clientset clientset.Interface) {
+ // CheckForCStorVolumeReplicaCRD is Blocking call for checking status of CStorVolumeReplica CRD.
+ func CheckForCStorVolumeReplicaCRD(clientset clientset.Interface) {
+ 	for {
+-		_, err := clientset.OpenebsV1alpha1().CStorVolumeReplicas().List(metav1.ListOptions{})
++		_, err := clientset.OpenebsV1alpha1().CStorVolumeReplicas("""").List(metav1.ListOptions{})
+ 		if err != nil {
+ 			glog.Errorf(""CStorVolumeReplica CRD not found. Retrying after %v"", CRDRetryInterval)
+ 			time.Sleep(CRDRetryInterval)",Does this mean the list operation is done for all the namespaces? How to list the volume replicas per namespace?
+5414,"@@ -136,10 +136,14 @@ def batched_nms(bboxes, scores, inds, nms_cfg):
+     Returns:
+         tuple: kept bboxes and indice.
+     """"""
+-    max_coordinate = bboxes.max()
+-    offsets = inds.to(bboxes) * (max_coordinate + 1)
+-    bboxes_for_nms = bboxes + offsets[:, None]
+     nms_cfg_ = nms_cfg.copy()
++    class_agnostic = nms_cfg_.pop('class_agnostic', False)
++    if not class_agnostic:
++        max_coordinate = bboxes.max()
++        offsets = inds.to(bboxes) * (max_coordinate + 1)
++        bboxes_for_nms = bboxes + offsets[:, None]
++    else:
++        bboxes_for_nms = bboxes
+     nms_type = nms_cfg_.pop('type', 'nms')
+     nms_op = eval(nms_type)
+     dets, keep = nms_op(","I suggest adding `class_agnostic` as an argument of `batched_nms()`, with the default value False."
+5415,"@@ -44,6 +44,7 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 101, ""file_path"", Types.StringType.get(), ""Path of a file in which a deleted row is stored"");
+   public static final NestedField DELETE_FILE_POS = NestedField.required(
+       Integer.MAX_VALUE - 102, ""pos"", Types.LongType.get(), ""Ordinal position of a deleted row in the data file"");
++  public static final String DELETE_FILE_ROW_FIELD_NAME = ""row"";
+   public static final int DELETE_FILE_ROW_FIELD_ID = Integer.MAX_VALUE - 103;
+   public static final String DELETE_FILE_ROW_DOC = ""Deleted row values"";
+ ","@rdblue, did we not add the name on purpose?"
+5416,"@@ -41,12 +41,12 @@ import org.apache.orc.TypeDescription;
+  */
+ public final class ORCSchemaUtil {
+
+-  private enum BinaryType {
++  public enum BinaryType {
+     UUID, FIXED, BINARY
+   }
+
+-  private enum IntegerType {
+-    TIME, INTEGER
++  public enum LongType {
++    TIME, LONG
+   }
+
+   private static class OrcField {",Why is this now public?
+5417,"@@ -111,9 +111,7 @@ module Blacklight::SearchContext
+       response, documents = search_service.previous_and_next_documents_for_search index, search_state.reset(current_search_session.query_params).to_hash
+
+       search_session['total'] = response.total
+-      @search_context_response = response
+-      @previous_document = documents.first
+-      @next_document = documents.last
++      { prev: documents.first, next: documents.last }
+     end
+   rescue Blacklight::Exceptions::InvalidRequest => e
+     logger.warn ""Unable to setup next and previous documents: #{e}""",I guess we should backport some deprecation for this?
+5418,"@@ -57,11 +57,10 @@ module Selenium
+               is_relative = Regexp.last_match(1).strip == '1'
+             when /^Path=(.+)$/
+               path = Regexp.last_match(1).strip
++              p = path_for(name, is_relative, path)
++              @profile_paths[name] = p if p
+             end
+           end
+-
+-          p = path_for(name, is_relative, path)
+-          @profile_paths[name] = p if p
+         end
+
+         def path_for(name, is_relative, path)",Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?
+5419,"@@ -105,6 +105,7 @@ static byte buf[8192];
+ #define IMMARG(sz) opnd_create_immed_int(37, sz)
+ #define TGTARG opnd_create_instr(instrlist_last(ilist))
+ #define REGARG(reg) opnd_create_reg(REG_##reg)
++#define DR_REGARG(reg) opnd_create_reg(DR_REG_##reg)
+ #define REGARG_PARTIAL(reg, sz) opnd_create_reg_partial(REG_##reg, sz)
+ #define VSIBX(sz) (opnd_create_base_disp(REG_XCX, REG_XMM6, 2, 0x42, sz))
+ #define VSIBY(sz) (opnd_create_base_disp(REG_XDX, REG_YMM6, 2, 0x17, sz))",I would say just change REGARG: no need for a separate thing.
+5420,"@@ -0,0 +1,18 @@
++<!DOCTYPE html>
++<html>
++<head>
++  <title>C2</title>
++  <meta name=""viewport"" content=""width=device-width""/>
++  <meta http-equiv=""Content-Type"" content=""text/html; charset=utf-8""/>
++  <link rel=""stylesheet"" type=""text/css"" href=""<%= stylesheet_url(""mailer.css"") %>"">
++</head>
++<body class=""c2-notification"">
++  <%= yield %>
++  <hr>
++  <div id=""footer"" class=""inset"">
++    <p>
++    <%= t(""mailer.feedback_footer_html"", feedback_url: feedback_url) %>
++    </p>
++  </div>
++</body>
++</html>","we can remove this template, it is no longer in use"
+5421,"@@ -45,11 +45,9 @@ module Beaker
+       end
+
+       it ""recursively dumps values"" do
+-        options.merge({'k' => 'v', 'key' => {'subkey' => 'subvalue'}, 'array_key' => ['array1', 'array2'], 'array_key2' => [['subarray1', 'subarray2'], 'anotherval']})
+-        expect(options.dump).to be === ""Options:\n\t\tk : v\n\t\tkey : \n\t\t\tsubkey : subvalue\n\t\tarray_key : \n\t\t\t[\n\t\t\tarray1,\n\t\t\tarray2,\n\t\t\t]\n\t\tarray_key2 : \n\t\t\t[\n\t\t\t[\n\t\t\tsubarray1,\n\t\t\tsubarray2,\n\t\t\t]\n\t\t\tanotherval,\n\t\t\t]\n""
+-
++        options.merge({'k' => { 'key' => {'subkey' => 'subvalue'}}})
++        expect(options.dump).to be === ""Options:\n\t\tk : \n\t\t\tkey : \n\t\t\t\tsubkey : subvalue\n""
+       end
+-
+     end
+   end
+ end",This doesn't look like it has as much coverage of the recursive code as it once did.
+5422,"@@ -107,6 +107,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Defaults to false.
+ 	// +optional
+ 	CrossZoneLoadBalancing bool `json:""crossZoneLoadBalancing,omitempty""`
++
++	// SecurityGroups sets the security groups used by the load balancer
++	// +optional
++	SecurityGroups []SecurityGroup `json:""securityGroups,omitempty""`
+ }
+
+ // AWSClusterStatus defines the observed state of AWSCluster","Do we actually expect users to provide more information here than possibly a SecurityGroup ID? If not, then this should probably use a new type, otherwise users might be confused by what options would be respected/ignored when used in this context."
+5423,"@@ -1,6 +1,8 @@
+ package edu.harvard.iq.dataverse.util;
+
+ import com.ocpsoft.pretty.PrettyContext;
++import com.rometools.utils.Strings;
++
+ import edu.harvard.iq.dataverse.DataFile;
+ import edu.harvard.iq.dataverse.Dataset;
+ import edu.harvard.iq.dataverse.Dataverse;",This seems like a new dependency on rometools. Do we need it?
+5424,"@@ -93,7 +93,7 @@ public class Docker {
+       throw new WebDriverException(""Unable to pull container: "" + name);
+     }
+
+-    LOG.info(String.format(""Pull of %s:%s complete"", name, tag));
++    LOG.fine(String.format(""Pull of %s:%s complete"", name, tag));
+
+     return findImage(new ImageNamePredicate(name, tag))
+         .orElseThrow(() -> new DockerException(",Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.
+5425,"@@ -7,13 +7,12 @@ import (
+ 	""sync/atomic""
+ 	""testing""
+
++	""github.com/sirupsen/logrus/hooks/test""
+ 	""github.com/stretchr/testify/require""
+
+ 	""github.com/spiffe/spire/pkg/common/util""
+ 	""github.com/spiffe/spire/pkg/server/plugin/datastore""
+ 	""github.com/spiffe/spire/pkg/server/plugin/datastore/sql""
+-	spi ""github.com/spiffe/spire/proto/spire/common/plugin""
+-	""github.com/spiffe/spire/test/spiretest""
+ )
+
+ var (","I can not think in a good use for it, but may we allow a way to setup a fake with a hook for logs? this fake is special, and we may need access to some of thoe logs, at the same time it may be an overkill because we dont want to test ""sql"" implementation but results.. but we can create some tests with end to end logs in some scenaries, What do you think about it?"
+5426,"@@ -149,6 +149,10 @@ void dag_close_over_environment(struct dag *d)
+ 			{
+ 				dag_variable_add_value(name, d->default_category->mf_variables, 0, value_env);
+ 			}
++
++			if(!value_env && !strcmp(name, RESOURCES_CORES)) {
++				dag_variable_add_value(name, d->default_category->mf_variables, 0, ""1"");
++			}
+ 		}
+ 	}
+ ","I don't think you should be changing the dag unilaterally at parse time. If cores isn't specified, then it isn't specified."
+5427,"@@ -26,6 +26,16 @@
+ // see URLOpener.
+ // See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
++// Message Delivery Semantics
++//
++// Azure ServiceBus supports at-least-once semantics in the default Peek-Lock
++// mode; applications must call Message.Ack/Nack after processing a message, or
++// it will be redelivered. However, it also supports a Receive-Delete mode,
++// which essentially auto-acks a message when it is delivered, resulting in
++// at-most-once semantics. See SubscriberOptions.AckFuncForReceiveAndDelete.
++// See https://godoc.org/gocloud.dev/pubsub#hdr-At_most_once_and_At_least_once_Delivery
++// for more background.
++//
+ // As
+ //
+ // azuresb exposes the following types for As:","Instead of just ""See SubscriberOptions...."", say something like ""Use ... to choose between the two."""
+5428,"@@ -0,0 +1,10 @@
++import argparse
++from rdkit import Chem
++sdf = Chem.SDMolSupplier(""cdk2.sdf"")
++f = open(""cdk2.smi"",""w"")
++for mol in sdf:
++    name = mol.GetProp(""_Name"")
++    smi = Chem.MolToSmiles( mol )
++    f.write( ""{}\t{}\n"".format(name,smi))
++f.close()
++",Use with statement for `f`
+5429,"@@ -426,3 +426,16 @@ TEST_F(BadPonyTest, AnnotatedIfClause)
+
+   TEST_COMPILE(src);
+ }
++
++TEST_F(BadPonyTest, CapSubtypeInConstrainSubtyping)
++{
++  // From PR #1816
++  const char* src =
++    ""trait T\n""
++    ""  fun alias[X: Any iso](x: X!) : X^\n""
++    ""class C is T\n""
++    ""  fun alias[X: Any tag](x: X!) : X^ => x\n"";
++
++  TEST_ERRORS_1(src,
++    ""type parameter constraint Any tag is not a supertype of Any iso"");
++}","It's a small style point, but could you remove the ""extra"" space before the colon that precedes the return type? This would make it more closely match the prevailing style in these tests and in the standard libraries."
+5430,"@@ -594,6 +594,13 @@ func (md *MDOpsStandard) PruneBranch(
+ 	return md.config.MDServer().PruneBranch(ctx, id, bid)
+ }
+
++// ResolveBranch implements the MDOps interface for MDOpsStandard.
++func (md *MDOpsStandard) ResolveBranch(
++	ctx context.Context, id TlfID, bid BranchID,
++	blocksToDelete []BlockID, rmd *RootMetadata) (MdID, error) {
++	return MdID{}, errors.New(""ResolveBranch not supported by MDOpsStandard"")
++}
++
+ // GetLatestHandleForTLF implements the MDOps interface for MDOpsStandard.
+ func (md *MDOpsStandard) GetLatestHandleForTLF(ctx context.Context, id TlfID) (
+ 	BareTlfHandle, error) {","seems clunky to me to have an `MDOps` interface method that some implementations don't implement. Perhaps define a separate interface, like, `BranchResolver`, and then callers that have an `MDOps` object can check via type assertion?"
+5431,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",This change should also probably go into the corresponding method of the abstract By class?
+5432,"@@ -42,6 +42,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/test/mock/mock_dispatcher""
+ 	ta ""github.com/iotexproject/iotex-core/test/testaddress""
+ 	""github.com/iotexproject/iotex-core/testutil""
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ )
+
+ const (",File is not `gofmt`-ed with `-s` (from `gofmt`)
+5433,"@@ -82,9 +82,9 @@ func (fsrv *FileServer) serveBrowse(dirPath string, w http.ResponseWriter, r *ht
+ 		w.Header().Set(""Content-Type"", ""text/html; charset=utf-8"")
+ 	}
+
+-	buf.WriteTo(w)
++	_, err = buf.WriteTo(w)
+
+-	return nil
++	return err
+ }
+
+ func (fsrv *FileServer) loadDirectoryContents(dir *os.File, urlPath string, repl *caddy.Replacer) (browseListing, error) {","This is likely to return an error value if the client fails to read the response we write, which is why I chose to ignore this error."
+5434,"@@ -649,6 +649,9 @@ class Channel(AbstractChannel):
+     def is_static_remotekey_enabled(self) -> bool:
+         return bool(self.storage.get('static_remotekey_enabled'))
+
++    def is_upfront_shutdown_script_enabled(self) -> bool:
++        return bool(self.storage.get('upfront_shutdown_script_enabled'))
++
+     def get_wallet_addresses_channel_might_want_reserved(self) -> Sequence[str]:
+         ret = []
+         if self.is_static_remotekey_enabled():",this method is not used
+5435,"@@ -1016,7 +1016,15 @@ class AbstractTab(QWidget):
+             return
+
+         sess_manager.save_autosave()
++        self.load_finished.emit(ok)
++
++        if not self.title():
++            self.title_changed.emit(self.url().toDisplayString())
+
++        self.zoom.reapply()
++
++    def _update_load_status(self, ok: bool) -> None:
++        """"""Update the load status after a page finished loading.""""""
+         if ok and not self._has_ssl_errors:
+             if self.url().scheme() == 'https':
+                 self._set_load_status(usertypes.LoadStatus.success_https)","Right now it's a bit unclear that this needs to be called explicitly by the implementing class. If, for example, there's another backend, it won't get this update unless we add the same function as webkit. Could you either add a note to this docstring explaining that this needs to be called, or find some way to automatically trigger this so the webkit override isn't needed (and some override passed on webengine)."
+5436,"@@ -162,7 +162,7 @@ var xdpTestCases = []xdpTest{
+ 			SrcPort: 54321,
+ 		},
+ 		Drop:     false,
+-		Metadata: true,
++		Metadata: false,
+ 	},
+ 	{
+ 		Description: ""6 - Match against a deny policy, must drop"",","Why this change (test name still says ""must pass with metadata"")?"
+5437,"@@ -45,7 +45,8 @@ module Travis
+           end
+
+           def ruby_version
+-            config[:rvm].to_s.gsub(/-(1[89]|2[01])mode$/, '-d\1')
++            vers = config[:rvm].to_s.gsub(/-(1[89]|2[01])mode$/, '-d\1')
++            force_187_p371 vers
+           end
+
+           def setup_rvm",Another nitpick: parens around the arg pretty please
+5438,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)"
+5439,"@@ -877,3 +877,7 @@ type CtxKey string
+ // context.WithValue to access the original request URI that accompanied the
+ // server request. The associated value will be of type string.
+ const URLPathCtxKey CtxKey = ""url_path""
++
++// URIxRewriteCtxKey is a context key used to store original unrewritten
++// URI in context.WithValue
++const URIxRewriteCtxKey CtxKey = ""caddy_rewrite_original_uri""","Oh, I guess I mentioned/pressed this point in the other issue, that this should probably go into the httpserver package. In fact, so should the const above this (URLPathCtxKey). These are specific to the HTTP server."
+5440,"@@ -41,7 +41,7 @@ type ValidationFunc func(certificate *cmapi.Certificate, secret *corev1.Secret)
+
+ // ExpectValidKeysInSecret checks that the secret contains valid keys
+ func ExpectValidKeysInSecret(_ *cmapi.Certificate, secret *corev1.Secret) error {
+-	validKeys := [5]string{corev1.TLSPrivateKeyKey, corev1.TLSCertKey, cmmeta.TLSCAKey, cmapi.AdditionalOutputFormatDERKey, cmapi.AdditionalOutputFormatPEMKey}
++	validKeys := [5]string{corev1.TLSPrivateKeyKey, corev1.TLSCertKey, cmmeta.TLSCAKey, cmapi.CertificateOutputFormatDERKey, cmapi.CertificateOutputFormatCombinedPEMKey}
+ 	nbValidKeys := 0
+ 	for k := range secret.Data {
+ 		for _, k2 := range validKeys {","Not added by you, but we don't really need the '5' here.."
+5441,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?
+5442,"@@ -36,6 +36,7 @@ def _makeKbEmulateScript(scriptName):
+ 		# __name__ must be str; i.e. can't be unicode.
+ 		scriptName = scriptName.encode(""mbcs"")
+ 	func.__name__ = ""script_%s"" % scriptName
++	func.emuGesture = emuGesture
+ 	func.__doc__ = _(""Emulates pressing %s on the system keyboard"") % emuGesture.displayName
+ 	return func
+ ",I don't think this is needed anymore?
+5443,"@@ -91,8 +91,15 @@ func (s *Service) ListAgents(ctx context.Context, req *agentv1.ListAgentsRequest
+ 	// Parse proto filter into datastore request
+ 	if req.Filter != nil {
+ 		filter := req.Filter
++
++		// TODO should this be a helper function?
++		var byBanned *bool
++		if filter.ByBanned != nil {
++			byBanned = &filter.ByBanned.Value
++		}
++
+ 		listReq.ByAttestationType = filter.ByAttestationType
+-		listReq.ByBanned = filter.ByBanned
++		listReq.ByBanned = byBanned
+
+ 		if filter.BySelectorMatch != nil {
+ 			selectors, err := api.SelectorsFromProto(filter.BySelectorMatch.Selectors)",This is the only occurrence I see in the code where we now need to convert from a boolean protobuf wrapper to a boolean pointer. This felt a little cumbersome here; should we consider moving it somewhere else as a helper function?
+5444,"@@ -46,9 +46,6 @@ void HBProcessor::process(const cpp2::HBReq& req) {
+   }
+
+   HostInfo info(time::WallClock::fastNowInMilliSec(), req.get_role(), req.get_git_info_sha());
+-  if (req.version_ref().has_value()) {
+-    info.version_ = *req.version_ref();
+-  }
+   if (req.leader_partIds_ref().has_value()) {
+     ret = ActiveHostsMan::updateHostInfo(kvstore_, host, info, &*req.leader_partIds_ref());
+   } else {",Need you to delete the `version_` from `HostInfo` struct ?
+5445,"@@ -0,0 +1,5 @@
++const { getBaseLang } = axe.commons.utils;
++const primaryLangValue = getBaseLang(node.getAttribute('lang') || '');
++const primaryXmlLangValue = getBaseLang(node.getAttribute('xml:lang') || '');
++
++return primaryLangValue === primaryXmlLangValue;",This could be the cleanest looking check we've got. Great job Jey.
+5446,"@@ -148,7 +148,7 @@ class Controller
+             $url = Request::path();
+         }
+
+-        if (!strlen($url)) {
++        if ('' === $url) {
+             $url = '/';
+         }
+ ","Who invited yoda?   In all seriousness though, wouldn't an `if (empty())` be better here?"
+5447,"@@ -1341,7 +1341,7 @@ define(['playbackManager', 'dom', 'inputManager', 'datetime', 'itemHelper', 'med
+                 });
+             } catch (e) {
+                 require(['appRouter'], function(appRouter) {
+-                    appRouter.showDirect('/');
++                    window.location.href = 'index.html';
+                 });
+             }
+         });","You can use `appRouter.goHome` to do this (It's defined in site.js), it's less hacky than overriding the href."
+5448,"@@ -101,7 +101,14 @@ bool NebulaStore::init() {
+                             enginePtr->removePart(partId);
+                             continue;
+                         } else {
+-                             partIds.emplace_back(partId);
++                             auto it = std::find(partIds.begin(), partIds.end(), partId);
++                             if (it != partIds.end()) {
++                                LOG(INFO) << ""Part "" << partId
++                                          << "" has been loaded, skip current one, remove it!"";
++                                enginePtr->removePart(partId);
++                             } else {
++                                partIds.emplace_back(partId);
++                             }
+                         }
+                     }
+                     if (partIds.empty()) {",When could this happen?
+5449,"@@ -55,8 +55,7 @@ namespace Datadog.Trace.Agent.Transports
+                 await memoryStream.FlushAsync().ConfigureAwait(false);
+                 memoryStream.Seek(0, SeekOrigin.Begin);
+                 var buffer = memoryStream.GetBuffer();
+-                _headers.Add(""Content-Type"", ""application/json"");
+-                var result = await PostSegmentAsync(new ArraySegment<byte>(buffer, 0, (int)memoryStream.Length)).ConfigureAwait(false);
++                var result = await PostSegmentAsync(new ArraySegment<byte>(buffer, 0, (int)memoryStream.Length), ""application/json"").ConfigureAwait(false);
+                 var response = result.Item1;
+                 var request = result.Item2;
+                 if (response.StatusCode != 200 && response.StatusCode != 202)",I assume this was removed because it was redundant? and conflicted with the now dynamic contentType? Edit: Oh I see it being set was moved to the `PostSegmentAsync` call.
+5450,"@@ -21,7 +21,9 @@ public class ProxyConfig {
+     public static ProxyConfig http(String host, int port, String username, String password) {
+         return new ProxyConfig(Proxy.Type.HTTP, host, port, username, password);
+     }
+-
++    public static ProxyConfig socks(String host, int port, String username, String password) {
++        return new ProxyConfig(Proxy.Type.SOCKS, host, port, username, password);
++    }
+     public ProxyConfig(Proxy.Type type, String host, int port, String username, String password) {
+         this.type = type;
+         this.host = host;",Here is a newline missing
+5451,"@@ -126,7 +126,7 @@ module Travis
+
+                 # R-devel builds available at mac.r-project.org
+                 if r_version == 'devel'
+-                  r_url = ""https://mac.r-project.org/el-capitan/R-devel/R-devel-el-capitan.pkg""
++                  r_url = ""http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg""
+
+                 # The latest release is the only one available in /bin/macosx
+                 elsif r_version == r_latest",Did you mean to make this http rather than https?
+5452,"@@ -1,15 +1,14 @@
+ #appModules/audacity.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2010 NVDA Contributors <http://www.nvda-project.org/>
++#Copyright (C) 2006-2018 NVDA Contributors <https://www.nvaccess.org/>
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+
+ import appModuleHandler
+-import winUser
+ import controlTypes
+
+ class AppModule(appModuleHandler.AppModule):
+
+ 	def event_NVDAObject_init(self,obj):
+ 		if obj.windowClassName==""Button"" and not obj.role in [controlTypes.ROLE_MENUBAR, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_POPUPMENU]:
+-			obj.name=winUser.getWindowText(obj.windowHandle).replace('&','')
++			obj.name=obj.name.replace('&','')","The updated copyright header should be: # Copyright (C) 2006-2018 NV Access Limited, yourname"
+5453,"@@ -21,6 +21,7 @@ class PerformanceTestSamplesAggregator
+             $maxQueryCount = 0;
+             $isSuccessful = true;
+             $worstStatusCode = null;
++            $performanceTestSample = null;
+
+             foreach ($performanceTestSamplesOfUrl as $performanceTestSample) {
+                 /* @var $performanceTestSample \Tests\ShopBundle\Performance\Page\PerformanceTestSample */","wow :+1: , i do not even know how this test works."
+5454,"@@ -2,14 +2,12 @@
+ // The .NET Foundation licenses this file to you under the MS-PL license.
+ // See the LICENSE file in the project root for more information.
+
+-
+-using MvvmCross.Plugins;
+ using MvvmCross.UI;
+
+ namespace MvvmCross.Plugin.Visibility.Platform.Uap
+ {
+-    public class Plugin
+-        : IMvxPlugin
++    [MvxPlugin]
++    public class Plugin : IMvxPlugin
+     {
+         public void Load()
+         {",File should be renamed `PlugIn` -> `Plugin`
+5455,"@@ -17,6 +17,7 @@ package egress
+ import (
+ 	""context""
+ 	""fmt""
++	""net""
+ 	""testing""
+ 	""time""
+ ",I scanned the new test cases quickly. Do we have one for an egressIPPool with multiple different IP ranges?
+5456,"@@ -148,6 +148,17 @@ abstract class Abstract_Component implements Component {
+ 		add_action( 'init', [ $this, 'define_settings' ] );
+ 	}
+
++	/**
++	 * Method to filter component loading if needed.
++	 *
++	 * @since   1.0.1
++	 * @access public
++	 * @return bool
++	 */
++	public function should_component_be_active() {
++		return true;
++	}
++
+ 	/**
+ 	 * Method to set protected properties for class.
+ 	 *","you can use a different name, like `maybe_activate` or `is_active` without `component` in the method name as this is used in the class name. E.g: `$component->should_component_be_active` is using twice the `component` word"
+5457,"@@ -114,6 +114,11 @@ class OrderedBulkOperation extends BulkOperationBase {
+    */
+   execute(_writeConcern, options, callback) {
+     const ret = this.bulkExecute(_writeConcern, options, callback);
++
++    if (!(ret && ret.options && ret.callback)) {
++      return ret;
++    }
++
+     options = ret.options;
+     callback = ret.callback;
+ ",I think this might not be a complete enough check: what if `options` is `null`/`undefined`?
+5458,"@@ -0,0 +1,19 @@
++require ""rails_helper""
++
++feature ""Masquerade"" do
++  scenario ""admin masquerades as a user"" do
++    email = ""foo@bar.com""
++    user = create(:user, email: email)
++    admin = create(:user, admin: true)
++
++    sign_in_as(admin)
++    visit admin_users_path
++    click_on(""Masquerade"")
++
++    expect(page).to have_flash(""Now masquerading as #{email}"")
++  end
++
++  def have_flash(text)
++    have_css("".flash"", text: text)
++  end
++end",Useless assignment to variable - `user`.
+5459,"@@ -74,8 +74,8 @@ module Travis
+             sh.echo ""#{release} is not installed. Downloading and installing pre-build binary."", ansi: :yellow
+
+             sh.echo ""Downloading archive: ${archive_url}"", ansi: :yellow
+-            sh.cmd ""wget -o ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}""
+-            sh.cmd ""mkdir -p ~/otp && tar -xf #{archive_name(release)} -C ~/otp/"", echo: true
++            sh.cmd ""wget -O ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}""
++            sh.cmd ""mkdir -p ~/otp && tar -xf ${TRAVIS_HOME}/erlang.tar.bz2 -C ~/otp/"", echo: true
+             sh.cmd ""mkdir -p ~/.kerl"", echo: true
+             sh.cmd ""echo '#{release},#{release}' >> ~/.kerl/otp_builds"", echo: true
+             sh.cmd ""echo '#{release} ${TRAVIS_HOME}/otp/#{release}' >> ~/.kerl/otp_builds"", echo: true","I think we would want to keep `-O` instead. I wonder how this worked before, though.  "
+5460,"@@ -26,13 +26,17 @@ namespace OpenTelemetry.Metrics
+     internal sealed class AggregatorStore
+     {
+         private static readonly ObjectArrayEqualityComparer ObjectArrayComparer = new ObjectArrayEqualityComparer();
++        private static readonly StringArrayEqualityComparer StringArrayComparer = new StringArrayEqualityComparer();
+         private readonly object lockZeroTags = new object();
+         private readonly HashSet<string> tagKeysInteresting;
+         private readonly int tagsKeysInterestingCount;
+
++        private readonly ConcurrentDictionary<string[], string[]> tagKeyCombinations =
++            new ConcurrentDictionary<string[], string[]>(StringArrayComparer);
++
+         // Two-Level lookup. TagKeys x [ TagValues x Metrics ]
+         private readonly ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>> keyValue2MetricAggs =
+-            new ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>>(new StringArrayEqualityComparer());
++            new ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>>(StringArrayComparer);
+
+         private readonly AggregationTemporality temporality;
+         private readonly string name;","another alternate option which doesn't have the risk of too many entries (when user keeps providing keys in different order) Have the dictionary as before If tagKeys lookup fail, sort and lookup again. If fails, insert both original tagKeys and its sorted one to the dictionary. So that we only store atmost 2 entries per key set. And we only do a single lookup in hotpath, as opposed to 2 look ups."
+5461,"@@ -370,6 +370,13 @@ void PlanNode::releaseSymbols() {
+   }
+ }
+
++void PlanNode::updateSymbols() {
++  auto symTbl = qctx_->symTable();
++  for (auto out : outputVars_) {
++    out && symTbl->updateWrittenBy(out->name, out->name, this);
++  }
++}
++
+ std::ostream& operator<<(std::ostream& os, PlanNode::Kind kind) {
+   os << PlanNode::toString(kind);
+   return os;",if (out != nullptr)
+5462,"@@ -79,6 +79,18 @@ def profile(user_name):
+
+     user = _get_user(user_name)
+
++    need_exact = request.args.get(""exact"")
++    if not need_exact:
++        listen_count = db_conn.get_listen_count_for_user(user_name)
++        # round off to nearest 10 as we can't guarantee that the values
++        # are not old, so show approximate values instead
++        if listen_count > 10:
++            listen_count = (listen_count / 10) * 10
++        have_exact = False
++    else:
++        listen_count = db_conn.get_listen_count_for_user(user_name, need_exact = True)
++        have_exact = True
++
+     # Getting data for current page
+     max_ts = request.args.get(""max_ts"")
+     if max_ts is not None:","In the listenstore you catch the exception and then pass it on via Raise. However, here you do not catch the exception. You should catch the exception, but since this is a minor aspect of this page, perhaps show an error message when the count cannot be loaded in time. Then the rest of the page can still be rendered, rather than failing the whole page."
+5463,"@@ -406,13 +406,14 @@ class TabbedBrowser(QWidget):
+         else:
+             yes_action()
+
+-    def close_tab(self, tab, *, add_undo=True, new_undo=True):
++    def close_tab(self, tab, *, add_undo=True, new_undo=True, transfer=False):
+         """"""Close a tab.
+
+         Args:
+             tab: The QWebView to be closed.
+             add_undo: Whether the tab close can be undone.
+             new_undo: Whether the undo entry should be a new item in the stack.
++            transfer: Whether the tab is closing because it is moving to a new window.
+         """"""
+         if config.val.tabs.tabs_are_windows:
+             last_close = 'close'",wouldn't it be simpler to just add `or transfer` here? That way the more complicated set of conditionals down below don't have to get more clauses.
+5464,"@@ -13,8 +13,8 @@
+ # limitations under the License.
+
+ """"""Wrapper for the BigQuery API client.""""""
+-from googleapiclient import errors
+ from httplib2 import HttpLib2Error
++from googleapiclient import errors
+
+ from google.cloud.forseti.common.gcp_api import _base_repository
+ from google.cloud.forseti.common.gcp_api import api_helpers",ditto; please fix everywhere
+5465,"@@ -164,6 +164,18 @@ Home directory can be found in a shared folder called ""home""
+ 			Default:  false,
+ 			Help:     ""Set to skip any symlinks and any other non regular files."",
+ 			Advanced: true,
++		}, {
++			Name:     ""subsystem"",
++			Default:  ""sftp"",
++			Help:     ""Specifies the SSH2 subsystem on the remote host."",
++			Advanced: true,
++		}, {
++			Name:    ""server_command"",
++			Default: """",
++			Help: `Specifies the path or command to run a sftp server on the remote host.
++
++The subsystem option is ignored when server_command is defined.`,
++			Advanced: true,
+ 		}},
+ 	}
+ 	fs.Register(fsi)",Can you break this line into two parts - the first line makes the option help text for `--sftp-server` and its too long! `Specifies the path or command to run a sftp server on the remote host. The subsystem option is ignored when sftp_server is defined.`
+5466,"@@ -45,7 +45,7 @@ class LoopAnalyzer
+         Context &$inner_context = null,
+         bool $is_do = false,
+         bool $always_enters_loop = false
+-    ) {
++    ): ?bool {
+         $traverser = new PhpParser\NodeTraverser;
+
+         $assignment_mapper = new \Psalm\Internal\PhpVisitor\AssignmentMapVisitor($loop_scope->loop_context->self);",I reverted that one in a previous PR because of a CI failure but it was actually unrelated
+5467,"@@ -112,12 +112,13 @@ func Add2ToolsList(toolList map[string]types.ToolsInstaller, flagData map[string
+ 	if kubeVer == """" {
+ 		var latestVersion string
+ 		for i := 0; i < util.RetryTimes; i++ {
+-			latestVersion, err := util.GetLatestVersion()
++			version, err := util.GetLatestVersion()
+ 			if err != nil {
+ 				return err
+ 			}
+-			if len(latestVersion) != 0 {
+-				kubeVer = latestVersion[1:]
++			if len(version) != 0 {
++				kubeVer = version[1:]
++				latestVersion = version
+ 				break
+ 			}
+ 		}","The for loop is useless here, since any error will make the function return."
+5468,"@@ -0,0 +1,16 @@
++#! /usr/bin/env python
++
++
++# import unittest2 as unittest
++
++# from nupic.bindings.algorithms import FlatSpatialPooler as FlatSpatialPooler
++
++# import spatial_pooler_py_api_test as pytest
++
++# pytest.SpatialPooler = FlatSpatialPooler
++
++# SpatialPoolerFlatAPITest = pytest.SpatialPoolerAPITest
++
++
++# if __name__ == ""__main__"":
++#   unittest.main()",Fix file endings here and elsewhere.
+5469,"@@ -1188,7 +1188,7 @@ void CLIENT_STATE::check_project_timeout() {
+         if (p->possibly_backed_off && now > p->min_rpc_time) {
+             p->possibly_backed_off = false;
+             char buf[256];
+-            snprintf(buf, sizeof(buf), ""Backoff ended for %s"", p->get_project_name());
++            snprintf(buf, sizeof(buf), ""Backoff ended for %.128s"", p->get_project_name());
+             request_work_fetch(buf);
+         }
+     }",I'd better increase `buf` length to MAXPATHLEN and not cut p->get_project_name() output twice
+5470,"@@ -172,6 +172,7 @@ func (*impl) createStorageMiner(vmctx runtime.InvocationContext, params CreateSt
+ 				SectorSize:             params.SectorSize,
+ 			})
+ 			if err != nil {
++				fmt.Printf(""here it is: %s\n"", err)
+ 				return fmt.Errorf(""Could not set power table at address: %s"", actorIDAddr)
+ 			}
+ 			return nil","Please remove the prints, even though this code will be trashed."
+5471,"@@ -26,8 +26,8 @@ import (
+ 	""runtime/debug""
+
+ 	""github.com/projectcalico/felix/config""
+-	""github.com/projectcalico/felix/dataplane/external""
+-	""github.com/projectcalico/felix/dataplane/linux""
++	extdataplane ""github.com/projectcalico/felix/dataplane/external""
++	intdataplane ""github.com/projectcalico/felix/dataplane/linux""
+ 	""github.com/projectcalico/felix/ifacemonitor""
+ 	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/felix/logutils""",Not sure if you added deliberately but I've seen these popping up; is goimports adding them?
+5472,"@@ -75,6 +75,9 @@ func (src *AWSCluster) ConvertTo(dstRaw conversion.Hub) error { // nolint
+ 		dst.Spec.NetworkSpec.VPC.AvailabilityZoneSelection = restored.Spec.NetworkSpec.VPC.AvailabilityZoneSelection
+ 	}
+
++	dst.Spec.NetworkSpec.SecurityGroupOverrides = restored.Spec.NetworkSpec.SecurityGroupOverrides
++	dst.Spec.NetworkSpec.TagSecurityGroups = restored.Spec.NetworkSpec.TagSecurityGroups
++
+ 	return nil
+ }
+ ","I think we might need some special handling for `Spec.ControlPlaneLoadBalancer.SecurityGroups`, it looks like we are currently only handling the case that `Spec.ControlPlaneLoadBalancer` is nil."
+5473,"@@ -0,0 +1,18 @@
++_base_ = '../cascade_rcnn/cascade_mask_rcnn_r50_fpn_20e_coco.py'
++
++model = dict(
++    pretrained='open-mmlab://dla60',
++    backbone=dict(
++        type='DLANet',
++        depth=60,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++    neck=dict(
++        type='FPN',
++        in_channels=[128, 256, 512, 1024],
++        out_channels=256,
++        num_outs=5))",Is this from a third-party library?
+5474,"@@ -70,3 +70,18 @@ dom.isNativelyFocusable = function(el) {
+ 	}
+ 	return false;
+ };
++
++/**
++ * Determines if an element is in the focus order, but would not be if its
++ * tabindex were unspecified.
++ * @method insertedIntoFocusOrder
++ * @memberof axe.commons.dom
++ * @instance
++ * @param {HTMLElement} el The HTMLElement
++ * @return {Boolean} True if the element is in the focus order but wouldn't be
++ * if its tabindex were removed. Else, false.
++ */
++dom.insertedIntoFocusOrder = function(el) {
++	return (el.tabIndex > -1 && dom.isFocusable(el) &&
++			!dom.isNativelyFocusable(el));
++};","Please put the `el.tabIndex > -1` in the first part of the expression. The matcher will run on every node on the page, so we should put the fastest part first."
+5475,"@@ -20,14 +20,14 @@ package mysterium
+ import (
+ 	""path/filepath""
+
+-	log ""github.com/cihub/seelog""
+ 	""github.com/mitchellh/go-homedir""
++	""github.com/mysteriumnetwork/go-openvpn/openvpn3""
+ 	""github.com/mysteriumnetwork/node/cmd""
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/node""
+-	""github.com/mysteriumnetwork/node/identity""
+ 	""github.com/mysteriumnetwork/node/metadata""
+-	service_noop ""github.com/mysteriumnetwork/node/services/noop""
++	""github.com/mysteriumnetwork/node/services/openvpn""
++	""github.com/mysteriumnetwork/node/services/openvpn/session""
+ )
+
+ // MobileNode represents node object tuned for mobile devices","`identity` is unused now, is it for future usage?"
+5476,"@@ -9,11 +9,14 @@ Puppet::Functions.create_function(:prompt) do
+   # @param prompt The prompt to display.
+   # @param options A hash of additional options.
+   # @option options [Boolean] sensitive Disable echo back and mark the response as sensitive.
++  #   The returned value will be wrapped by the `Sensitive` data type. To access the raw
++  #   value, use the `unwrap` function (i.e. `$sensitive_value.unwrap`).
+   # @return The response to the prompt.
+   # @example Prompt the user if plan execution should continue
+   #   $response = prompt('Continue executing plan? [Y\N]')
+   # @example Prompt the user for sensitive information
+   #   $password = prompt('Enter your password', 'sensitive' => true)
++  #   out::message(""Password is: ${password.unwrap}"")
+   dispatch :prompt do
+     param 'String', :prompt
+     optional_param 'Hash[String[1], Any]', :options","This would have assisted me a lot! I am on the ""functions"" page more than any other page in the docs"
+5477,"@@ -971,7 +971,7 @@ class JobTask(BaseHadoopJobTask):
+             if self.__module__ == '__main__':
+                 d = pickle.dumps(self)
+                 module_name = os.path.basename(sys.argv[0]).rsplit('.', 1)[0]
+-                d = d.replace(b'(c__main__', ""(c"" + module_name)
++                d = d.replace(b'c__main__', b'c' + module_name.encode('ascii'))
+                 open(file_name, ""wb"").write(d)
+
+             else:",I think it's better we keep `(` and encode with default encoding (utf-8).
+5478,"@@ -52,11 +52,12 @@ class BaselineFormat extends AbstractBaselinePlugin {
+                 java.removeUnusedImports();
+                 // use empty string to specify one group for all non-static imports
+                 java.importOrder("""");
+-                java.trimTrailingWhitespace();
+
+                 if (eclipseFormattingEnabled(project)) {
+                     java.eclipse().configFile(project.file(eclipseXml.toString()));
+                 }
++
++                java.trimTrailingWhitespace();
+             });
+
+             // necessary because SpotlessPlugin creates tasks in an afterEvaluate block",this is gonna be different in an IDE vs from gradlew??
+5479,"@@ -140,3 +140,18 @@ end
+
+ Spork.each_run do
+ end
++
++shared_context ""with isolated syntax"" do
++  orig_matchers_syntax = nil
++  orig_mocks_syntax = nil
++
++  before(:each) do
++    orig_matchers_syntax = RSpec::Matchers.configuration.syntax
++    orig_mocks_syntax = RSpec::Mocks.configuration.syntax
++  end
++
++  after(:each) do
++    RSpec::Matchers.configuration.syntax = orig_matchers_syntax
++    RSpec::Mocks.configuration.syntax = orig_mocks_syntax
++  end
++end",Do we not already have something for isolating syntax?
+5480,"@@ -1,7 +1,7 @@
+ # -*- coding: utf-8 -*-
+ ##
+ ## This file is part of Invenio.
+-## Copyright (C) 2012 CERN.
++## Copyright (C) 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","1: D100 Docstring missing 4: I102 copyright year is outdated, expected 2014 but got 2012 158: D103 Docstring missing 168: D101 Docstring missing 170: D102 Docstring missing 180: D102 Docstring missing 187: D102 Docstring missing"
+5481,"@@ -1,11 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how deny uploads of objects without
++# server-side AWS KMS encryption to an Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3_add_bucket_sses3_encryption_policy]
++
+ require 'aws-sdk-s3'
+
+-# Denies uploads of objects without server-side AWS KMS encryption to
+-#   an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - The Amazon S3 bucket to deny uploading objects without",how **to** deny
+5482,"@@ -19,6 +19,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     /// </summary>
+     public class ListenOptions : IEndPointInformation, IConnectionBuilder
+     {
++        private const string Http2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http2"";
++        private const string Http1AndHttp2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http1AndHttp2"";
++
+         private FileHandleType _handleType;
+         private readonly List<Func<ConnectionDelegate, ConnectionDelegate>> _components = new List<Func<ConnectionDelegate, ConnectionDelegate>>();
+ ",The only beef I have with this is that it's app domain global.
+5483,"@@ -562,8 +562,11 @@ func (ln tcpKeepAliveListener) Accept() (c net.Conn, err error) {
+ 	if err = tc.SetKeepAlive(true); err != nil {
+ 		return
+ 	}
+-	if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {
+-		return
++	// OpenBSD has no user-settable per-socket TCP keepalive
++	if runtime.GOOS != ""openbsd"" {
++		if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {
++			return
++		}
+ 	}
+ 	return tc, nil
+ }",Can you link to the GitHub issue and/or PR so that it is easy for future readers to find out more about this?
+5484,"@@ -3009,3 +3009,18 @@ void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRen
+     // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
+     renderpasses_states.erase(renderPass);
+ }
++
++bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
++                                                               const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) {
++    bool skip = false;
++
++    if (pAllocateInfo) {
++        auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
++        if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
++            skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
++                            ""VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602"",
++                            ""priority (=%f) must be between `0` and `1`, inclusive."", chained_prio_struct->priority);
++        }
++    }
++    return skip;
++}",Typical to report the value found as well as the valid bounds.
+5485,"@@ -151,7 +151,7 @@ var clerkCmd = &cobra.Command{
+ 	},
+ }
+
+-func waitForCommit(client libgoal.Client, txid string) error {
++func waitForCommit(client libgoal.Client, txid string, transactionLastValidRound uint64) error {
+ 	// Get current round information
+ 	stat, err := client.Status()
+ 	if err != nil {",maybe we want 0 as a default value?
+5486,"@@ -193,7 +193,16 @@ func (api *Server) GetAccount(ctx context.Context, in *iotexapi.GetAccountReques
+ 		PendingNonce: pendingNonce,
+ 		NumActions:   numActions,
+ 	}
+-	return &iotexapi.GetAccountResponse{AccountMeta: accountMeta}, nil
++	tipHeight := api.bc.TipHeight()
++	header, err := api.bc.BlockHeaderByHeight(tipHeight)
++	if err != nil {
++		return nil, status.Error(codes.NotFound, err.Error())
++	}
++	hash := header.HashBlock()
++	return &iotexapi.GetAccountResponse{AccountMeta: accountMeta, BlockIdentifier: &iotextypes.BlockIdentifier{
++		Hash:   hex.EncodeToString(hash[:]),
++		Height: tipHeight,
++	}}, nil
+ }
+
+ // GetActions returns actions",can we get height from sf at very beginning of the function and use that as height of the block?
+5487,"@@ -0,0 +1,6 @@
++namespace Microsoft.AspNet.Server.Kestrel
++{
++    public class StandardsPoliceCompileModule : Microsoft.StandardsPolice.StandardsPoliceCompileModule
++    {
++    }
++}",Does this have to be public and in the primary namespace?
+5488,"@@ -1206,6 +1206,15 @@ func (fbo *folderBranchOps) initMDLocked(
+ 		return err
+ 	}
+
++	fbo.headLock.Lock(lState)
++	defer fbo.headLock.Unlock(lState)
++	// Some other thread got here first, so give up and let it go
++	// before we push anything to the servers.
++	if fbo.head != (ImmutableRootMetadata{}) {
++		fbo.log.CDebugf(ctx, ""Head was already set, aborting"")
++		return nil
++	}
++
+ 	if err = PutBlockCheckQuota(ctx, fbo.config.BlockServer(),
+ 		fbo.config.Reporter(), md.TlfID(), info.BlockPointer, readyBlockData,
+ 		md.GetTlfHandle().GetCanonicalName()); err != nil {",I'm a bit confused. Doesn't `mdWriterLock` already synchronizes calls to this function?
+5489,"@@ -120,7 +120,13 @@ final class DailyMotionProvider extends BaseVideoProvider
+
+     public function getReferenceUrl(MediaInterface $media): string
+     {
+-        return sprintf('http://www.dailymotion.com/video/%s', $media->getProviderReference());
++        $providerReference = $media->getProviderReference();
++
++        if (null === $providerReference) {
++            return '';
++        }
++
++        return sprintf('http://www.dailymotion.com/video/%s', $providerReference);
+     }
+
+     protected function doTransform(MediaInterface $media): void","Does it make sense to generate a dailyMotion url without the video reference? It does not to me, but can we throw an exception here?"
+5490,"@@ -24,10 +24,11 @@ import (
+ 	""sort""
+ 	""strings""
+
+-	stringutils ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/string""
+-	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ 	computeBeta ""google.golang.org/api/compute/v0.beta""
+ 	""google.golang.org/api/compute/v1""
++
++	stringutils ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/string""
++	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ )
+
+ const (",Why the separation of imports here?
+5491,"@@ -4,14 +4,14 @@ import (
+ 	""context""
+
+ 	""github.com/influxdata/flux/ast""
+-	""github.com/influxdata/flux/dependencies""
++
+ 	""github.com/influxdata/flux/interpreter""
+ 	""github.com/influxdata/flux/parser""
+ 	""github.com/influxdata/flux/semantic""
+ 	""github.com/influxdata/flux/values""
+ )
+
+-func Eval(ctx context.Context, deps dependencies.Interface, itrp *interpreter.Interpreter, scope values.Scope, importer interpreter.Importer, src string) ([]interpreter.SideEffect, error) {
++func Eval(ctx context.Context, itrp *interpreter.Interpreter, scope values.Scope, importer interpreter.Importer, src string) ([]interpreter.SideEffect, error) {
+ 	pkg := parser.ParseSource(src)
+ 	if ast.Check(pkg) > 0 {
+ 		return nil, ast.GetError(pkg)",Random extra newline.
+5492,"@@ -0,0 +1,18 @@
++/* global dom */
++
++/**
++ * Get all descendents that are focusable from a given node
++ * @method getFocusableElements
++ * @memberof axe.commons.dom
++ * @instance
++ * @param  {Object} virtualNode The virtualNode to assess
++ * @return {Boolean}
++ */
++dom.getFocusableElements = function getFocusableElements(virtualNode) {
++	const descendents = axe.utils.querySelectorAll(virtualNode, '*');
++	const focusableElms = descendents.filter(({ actualNode: el }) => {
++		const isElFocusable = dom.isFocusable(el);
++		return isElFocusable;
++	});
++	return focusableElms;
++};",No need for this variable.
+5493,"@@ -79,6 +79,15 @@ def authentication_required(url, authenticator, abort_on):
+     return answer
+
+
++def _format_msg(msg: str) -> str:
++    """"""Convert message to HTML suitable for rendering.""""""
++    ret = msg
++    ret = html.escape(ret)
++    ret = ret.strip()
++    ret = ret.replace('\n', '<br />')
++    return ret
++
++
+ def javascript_confirm(url, js_msg, abort_on):
+     """"""Display a javascript confirm prompt.""""""
+     log.js.debug(""confirm: {}"".format(js_msg))",Why not use `msg` directly below?
+5494,"@@ -29,9 +29,8 @@ import org.apache.parquet.schema.OriginalType;
+ import org.apache.parquet.schema.PrimitiveType;
+ import org.apache.parquet.schema.Type;
+
+-import static org.apache.parquet.schema.Type.Repetition.REPEATED;
+-
+ public class ParquetTypeVisitor<T> {
++  @SuppressWarnings({""checkstyle:IllegalType"", ""checkstyle:VisibilityModifier""})
+   protected LinkedList<String> fieldNames = Lists.newLinkedList();
+
+   public static <T> T visit(Type type, ParquetTypeVisitor<T> visitor) {",I think other places changed to use `Deque` instead of suppressing the warning.
+5495,"@@ -4,8 +4,11 @@
+ #include ""engine/guidance/toolkit.hpp""
+
+ #include <boost/assert.hpp>
++#include <boost/range/algorithm_ext/erase.hpp>
++
+ #include <iostream>
+-#include <vector>
++#include <cstddef>
++#include <utility>
+
+ using TurnInstruction = osrm::extractor::guidance::TurnInstruction;
+ using TurnType = osrm::extractor::guidance::TurnType;","missing: utility, cstddef also: vector is already included in the header (interface requires vectors as in/out types)"
+5496,"@@ -16,6 +16,9 @@ module.exports = {
+ 		'html',
+ 		'text-summary',
+ 	],
++	globals: {
++		fetchMock: '',
++	},
+ 	rootDir: '../../',
+ 	transform: {
+ 		'^.+\\.[jt]sx?$': '<rootDir>/node_modules/@wordpress/scripts/config/babel-transform',","I'm not sure this is necessary in the config here, as Jest would be setting the global `fetchMock = ''`. See below."
+5497,"@@ -57,7 +57,7 @@ public abstract class Message implements Part, Body {
+         final int MULTIPLIER = 31;
+
+         int result = 1;
+-        result = MULTIPLIER * result + mFolder.getName().hashCode();
++        result = MULTIPLIER * result + (mFolder != null ? mFolder.getName().hashCode() : 0);
+         result = MULTIPLIER * result + mUid.hashCode();
+         return result;
+     }",Can `mFolder == null` happen during regular operations? Or is it only so we can be lazy in tests?
+5498,"@@ -0,0 +1,8 @@
++require ""migrate""
++
++class AddPreferredEmailFormat < ActiveRecord::Migration
++  def change
++    create_enumeration :email_format_enum, %w(text_only multipart)
++    add_column :users, :preferred_email_format, :email_format_enum, :null => false, :default => ""multipart""
++  end
++end",I'd suggest using the actual MIME types here - so `text/plain` and `multipart/alternative` or does that cause problems with what postgres allows for enumeration names? If so then maybe just replace the slash with an underscore?
+5499,"@@ -619,9 +619,9 @@ def package_put(owner, package_name, package_hash):
+             if team_access is None:
+                 raise ApiException(
+                     requests.codes.forbidden,
+-                    (""%(user)s/%(pkg)s is private. To share it with the team, "" +
+-                     ""run `quilt access add %(user)s/%(pkg)s team`."") %
+-                    dict(user=owner, pkg=package_name)
++                    (""%(team)s:%(user)s/%(pkg)s is private. To share it with the team, "" +
++                        ""run `quilt access add %(team)s:%(user)s/%(pkg)s team`."") %
++                    dict(team=app.config['TEAM_NAME'].lower(), user=owner, pkg=package_name)
+                 )
+
+     # Insert an instance if it doesn't already exist.","Ohh. `TeamName` is actually a ""friendly"" name displayed in the Catalog - not the name used in the CLI. So I guess we'll need a new variable here. (That is, this is going to be mainly a `quilt.yaml` change. You won't need the `.lower()`, though.)"
+5500,"@@ -383,6 +383,7 @@ class ConsoleAddon:
+             part in (""response-headers"", ""response-body"", ""set-cookies"") and
+             flow.response is None
+         )
++        flow.backup()
+         if require_dummy_response:
+             flow.response = http.HTTPResponse.make()
+         if part == ""cookies"":","Nit: Don't move it between `require_dummy_response` definition and usage, this can live above or below :)"
+5501,"@@ -377,6 +377,17 @@ type Local struct {
+ 	// connections that are originating from the local machine. Setting this to ""true"", allow to create large
+ 	// local-machine networks that won't trip the incoming connection limit observed by relays.
+ 	DisableLocalhostConnectionRateLimit bool `version[16]:""true""`
++
++	// BlockServiceCustomFallbackEndpoints is a comma delimited list of endpoints which the block service uses to
++	// redirect the http requests to in case it does not have the round. If it is not specified, will check
++	// EnableBlockServiceFallbackToArchiver.
++	BlockServiceCustomFallbackEndpoints string `version[16]:""""`
++
++	// EnableBlockServiceFallbackToArchiver controls whether the block service redirects the http requests to
++	// an archiver or return StatusNotFound (404) when in does not have the requested round, and
++	// BlockServiceCustomFallbackEndpoints is empty.
++	// The archiver is randomly selected, if none is available, will return StatusNotFound (404).
++	EnableBlockServiceFallbackToArchiver bool `version[16]:""true""`
+ }
+
+ // Filenames of config files within the configdir (e.g. ~/.algorand)","With the current code, it not work if `EnableCatchupFromArchiveServers` is disabled. to fix it: in getDNSAddrs, change the predicate to `if wn.config.EnableCatchupFromArchiveServers || wn.config. EnableCatchupFromArchiveServers {` and in the catchup/service.go and catchup/catchpointService.go, use the `PeersPhonebookArchivers` only when `wn.config.EnableCatchupFromArchiveServers` is enabled."
+5502,"@@ -910,8 +910,9 @@ func (cr *ConflictResolver) resolveMergedPaths(ctx context.Context,
+ 	// cache for the merged branch.
+ 	mergedNodeCache := newNodeCacheStandard(cr.fbo.folderBranch)
+ 	// Initialize the root node.  There will always be at least one
+-	// unmerged path.
+-	mergedNodeCache.GetOrCreate(mergedChains.mostRecentMD.data.Dir.BlockPointer,
++	// unmerged path.  Hold it here so it doesn't get gc'd.
++	rootNode, _ := mergedNodeCache.GetOrCreate(
++		mergedChains.mostRecentMD.data.Dir.BlockPointer,
+ 		unmergedPaths[0].path[0].Name, nil)
+
+ 	newPtrs := make(map[BlockPointer]bool)","Why not make `SearchForNodes` do a `GetOrCreate` for the root node? (Not advocating for it, but just wondering if there's another reason than avoiding having to pass in the path.)"
+5503,"@@ -224,6 +224,7 @@ public class DefaultP2PNetwork implements P2PNetwork {
+                 }
+                 dnsPeers.set(peers);
+               });
++      dnsDaemon.start();
+     }
+
+     final int listeningPort = rlpxAgent.start().join();",:+1: amazing that this has been missing since it was originally implemented
+5504,"@@ -101,7 +101,7 @@ class OrcFileAppender<D> implements FileAppender<D> {
+   public long length() {
+     Preconditions.checkState(isClosed,
+         ""Cannot return length while appending to an open file."");
+-    return writer.getRawDataSize();
++    return file.toInputFile().getLength();
+   }
+
+   @Override","Just want to note here that although we do check `length` while writing to choose whether to close and start a new file, that doesn't happen for ORC already so it is fine to use a FS call in this method."
+5505,"@@ -67,8 +67,7 @@ public class PartitionField implements Serializable {
+   public boolean equals(Object other) {
+     if (this == other) {
+       return true;
+-    }
+-    if (other == null || getClass() != other.getClass()) {
++    } else if (!(other instanceof PartitionField)) {
+       return false;
+     }
+ ",nit: I feel multiple `if (...) { return ... }` is more readable than `if ... else ...`.
+5506,"@@ -32,7 +32,7 @@ def setup_test_logging():
+         root.debug(""Already set up logging"")
+
+
+-setup_test_logging()
++# setup_test_logging()
+ logging.info(""Bootstrapped test"")
+
+ ",This is needed for us to work in IDE UTs
+5507,"@@ -282,6 +282,12 @@ commands (copy, sync, etc), and with all other commands too.`,
+ 			Default:  false,
+ 			Help:     ""Only show files that are in the trash.\nThis will show trashed files in their original directory structure."",
+ 			Advanced: true,
++		}, {
++		}, {
++			Name:     ""starred_only"",
++			Default:  false,
++			Help:     ""Only show files that are starred."",
++			Advanced: true,
+ 		}, {
+ 			Name:     ""formats"",
+ 			Default:  """",",File is not `goimports`-ed (from `goimports`)
+5508,"@@ -486,14 +486,14 @@ func DupSecOpt(src string) []string {
+ 		con[""level""] == """" {
+ 		return nil
+ 	}
+-	return []string{""label:user:"" + con[""user""],
+-		""label:role:"" + con[""role""],
+-		""label:type:"" + con[""type""],
+-		""label:level:"" + con[""level""]}
++	return []string{""label=user:"" + con[""user""],
++		""label=role:"" + con[""role""],
++		""label=type:"" + con[""type""],
++		""label=level:"" + con[""level""]}
+ }
+
+ // DisableSecOpt returns a security opt that can be used to disabling SELinux
+ // labeling support for future container processes
+ func DisableSecOpt() []string {
+-	return []string{""label:disable""}
++	return []string{""label=disable""}
+ }","this `label=` is docker specific, while here in libcontainer there shouldn't be any mention to docker. `DisableSecOpt` and `DupSecOpt` should just deal with `disable,role,type,level`. Both CRI-O and docker should just pass `disable,role,type.level` stuff and not `label=...`."
+5509,"@@ -31,6 +31,7 @@ func init() {
+ 	flags.BoolVarP(cmdFlags, &notCreateNewFile, ""no-create"", ""C"", false, ""Do not create the file if it does not exist."")
+ 	flags.StringVarP(cmdFlags, &timeAsArgument, ""timestamp"", ""t"", """", ""Use specified time instead of the current time of day."")
+ 	flags.BoolVarP(cmdFlags, &localTime, ""localtime"", """", false, ""Use localtime for timestamp, not UTC."")
++	flags.BoolVarP(cmdFlags, &recurse, ""recursive"", ""R"", false, ""Recurse into the listing."")
+ }
+
+ var commandDefinition = &cobra.Command{","You need to declare variable `recurse` above, same place as `localTime`."
+5510,"@@ -1565,7 +1565,8 @@ class SpreadingOperation(LinkableOperation):
+             new_data[tuple(vd.name for vd in vdims)] = img
+         else:
+             new_data = array
+-        return element.clone(new_data, **kwargs)
++        return element.clone(new_data, xdensity=element.xdensity,
++                             ydensity=element.ydensity, **kwargs)
+
+
+ ",Why does `clone` not already copy `xdensity` and `ydensity` from what it is cloning?
+5511,"@@ -52,6 +52,11 @@ namespace OpenTelemetry.Metrics
+
+             AggregationTemporality temporality = AggregationTemporality.Cumulative;
+
++            if (meterSources.Count() == 0)
++            {
++                throw new ArgumentException(""No meter was added to the sdk."");
++            }
++
+             foreach (var reader in readers)
+             {
+                 if (reader == null)",Curious - do we do the same for traces (when no ActivitySource / legacy source are added)? (and why we want to do it for metrics?)
+5512,"@@ -801,11 +801,11 @@ SdMmcHcStartSdClock (
+
+   Refer to SD Host Controller Simplified spec 3.0 Section 3.2.1 for details.
+
+-  @param[in] Private         A pointer to the SD_MMC_HC_PRIVATE_DATA instance.
+-  @param[in] Slot            The slot number of the SD card to send the command to.
+-  @param[in] BusTiming       BusTiming at which the frequency change is done.
+-  @param[in] FirstTimeSetup  Flag to indicate whether the clock is being setup for the first time.
+-  @param[in] ClockFreq       The max clock frequency to be set. The unit is KHz.
++  @param[in] PciIo          The PCI IO protocol instance.
++  @param[in] Slot           The slot number of the SD card to send the command to.
++  @param[in] ClockFreq      The max clock frequency to be set. The unit is KHz.
++  @param[in] BaseClkFreq    The base clock frequency of host controller in MHz.
++  @param[in] ControllerVer  The version of host controller.
+
+   @retval EFI_SUCCESS       The clock is supplied successfully.
+   @retval Others            The clock isn't supplied successfully.","@aimanrosli23 For the changes in file SdMmcPciHci.c, please make sure that you do not revert the changes made by the below commits: SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start SHA-1: c67617f3c677c342efde780e229f841f4e0f6c7e * MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands SHA-1: 6d387610855ee27b49cb720de29ed809ea59dadc * MdeModulePkg/SdMmcPciHcDxe: Read response on command completion SHA-1: 63fd7f389874081ea37452b1f79ac013d52755e3 * MdeModulePkg/SdMmcPciHcDxe: Do not map memory for non DMA transfer"
+5513,"@@ -128,11 +128,18 @@ class SelectionAndFilterTests:
+         ('<link href=""javascript://foo"" />', [webelem.Group.all,
+                                               webelem.Group.url]),
+
+-        ('<textarea />', [webelem.Group.all]),
++        ('<textarea />', [webelem.Group.all, webelem.Group.inputs]),
+         ('<select />', [webelem.Group.all]),
+
+         ('<input />', [webelem.Group.all]),
+         ('<input type=""hidden"" />', []),
++        ('<input type=""text"" />', [webelem.Group.inputs]),
++        ('<input type=""email"" />', [webelem.Group.inputs]),
++        ('<input type=""url"" />', [webelem.Group.inputs]),
++        ('<input type=""tel"" />', [webelem.Group.inputs]),
++        ('<input type=""number"" />', [webelem.Group.inputs]),
++        ('<input type=""password"" />', [webelem.Group.inputs]),
++        ('<input type=""search"" />', [webelem.Group.inputs]),
+
+         ('<button />', [webelem.Group.all]),
+         ('<button href=""foo"" />', [webelem.Group.all, webelem.Group.prevnext,",You'll also need to add `webelem.Group.all` everywhere as that matches as well
+5514,"@@ -0,0 +1,14 @@
++$(document).ready(initializeDocument);
++
++function initializeDocument() {
++  //only enable bank account field when BA80 is selected as an expense_type
++  $(""input:radio[name='ncr_proposal[expense_type]']"").click(function(event){
++    if ($(""input:radio[name='ncr_proposal[expense_type]']:checked"").val() == 'BA80') {
++      $('#ncr_proposal_RWA_number').attr('disabled', false);
++    } else {
++      $('#ncr_proposal_RWA_number').attr('disabled', true);
++    }
++  });
++
++  $('#ncr_proposal_building_number').chosen({placeholder_text_multiple: 'If applicable, which building will the charge support?'})
++}",Does this need to be an ERB template?
+5515,"@@ -0,0 +1,18 @@
++package feedbackmock
++
++import (
++	""context""
++
++	feedbackv1 ""github.com/lyft/clutch/backend/api/feedback/v1""
++	""github.com/lyft/clutch/backend/service/feedback""
++)
++
++type svc struct{}
++
++func (s svc) SubmitFeedback(ctx context.Context, id string, feedback *feedbackv1.Feedback, metadata *feedbackv1.FeedbackMetadata) error {
++	return nil
++}
++
++func New() feedback.Service {
++	return &svc{}
++}",do we want to register this in the mock server for testing?
+5516,"@@ -231,10 +231,10 @@ class AnomalyLikelihoodTest(TestCaseBase):
+
+     # Generate an estimate using fake distribution of anomaly scores.
+     data1 = _generateSampleData(mean=0.2)
+-    data1 = data1 + [(2, 2), (2, 2, 2, 2), (), (2)]  # Malformed records
++    data1 = data1[0:1000] + [(2, 2), (2, 2, 2, 2), (), (2)]  # Malformed records
+
+     likelihoods, avgRecordList, estimatorParams = (
+-      an.estimateAnomalyLikelihoods(data1[0:1000])
++      an.estimateAnomalyLikelihoods(data1[0:1004])
+     )
+     self.assertEqual(len(likelihoods), 1000)
+     self.assertEqual(len(avgRecordList), 1000)",shouldnt this be `0:996` (+4) so the 1000s below fit?
+5517,"@@ -49,11 +49,11 @@ class sorted_context(object):
+         self.enabled = enabled
+
+     def __enter__(self):
+-        self._enabled = MultiDimensionalMapping._sorted
+-        MultiDimensionalMapping._sorted = self.enabled
++        self._enabled = MultiDimensionalMapping.sort
++        MultiDimensionalMapping.sort = self.enabled
+
+     def __exit__(self, exc_type, exc_val, exc_tb):
+-        MultiDimensionalMapping._sorted = self._enabled
++        MultiDimensionalMapping.sort = self._enabled
+
+
+ ","The docstring of this context_manager should be updated. As now ``sort=False`` is valid, it should just say it disables sorting regardless of whether the NdMapping has ``sort=True`` or ``sort=False``. I also think the line 'Should only be used if values are guaranteed to be sorted before or after the operation is performed.' should just say something else - maybe just that the initial ordering (whatever it is) should be preserved?"
+5518,"@@ -52,8 +52,8 @@ describe('Lifecycle methods', () => {
+ 			}
+ 		}
+
+-		spyAll(Receiver.prototype);
+ 		spyAll(Receiver);
++		spyAll(Receiver.prototype);
+
+ 		function throwExpectedError() {
+ 			throw (expectedError = new Error('Error!'));",This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form?
+5519,"@@ -699,10 +699,14 @@ class Util:
+     @classmethod
+     def get_java_opts(cls):
+         opts = config.LAMBDA_JAVA_OPTS or ''
+-        if '_debug_port_' in opts:
++        if 'address=_debug_port_' in opts:
+             if not cls.debug_java_port:
+                 cls.debug_java_port = get_free_tcp_port()
+             opts = opts.replace('_debug_port_', ('%s' % cls.debug_java_port))
++        elif 'address=' in opts:
++            if not cls.debug_java_port:
++                cls.debug_java_port = ops.split(""address="")[1]
++
+         return opts
+
+     @classmethod",extract the port and set to `debug_java_port`
+5520,"@@ -93,6 +93,13 @@ def parse_compile_commands_json(logfile, add_compiler_defaults=False):
+     counter = 0
+     for entry in data:
+         sourcefile = entry['file']
++
++        if not os.path.isabs(sourcefile):
++            # Newest versions of intercept-build can create the 'file' in the
++            # JSON Compilation Database as a relative path.
++            sourcefile = os.path.join(os.path.abspath(entry['directory']),
++                                      sourcefile)
++
+         lang = option_parser.get_language(sourcefile[sourcefile.rfind('.'):])
+
+         if not lang:","When the argument list is `[""one"", ""two three""]` then you concatenate it as you do it here, you won't be able to get the original list back with split. You need to annotate the list items better. (Or if you won't do the split by yourself, the called shell will do it. So you need shell escaping. How portable is that?) The main driver to change this in `intercept-build` was to get rid of these concatenation and splitting errors. The current compilation database parser in Clang understands the `arguments` filed... So the question, why don't you pass the command around as a list instead of a string?"
+5521,"@@ -95,6 +95,10 @@ func (a *FakeWebAPI) RegisterPiped(ctx context.Context, req *webservice.Register
+ 	}, nil
+ }
+
++func (a *FakeWebAPI) EnablePiped(ctx context.Context, req *webservice.EnablePipedRequest) (*webservice.EnablePipedResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
+ func (a *FakeWebAPI) DisablePiped(ctx context.Context, req *webservice.DisablePipedRequest) (*webservice.DisablePipedResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`ctx` is unused in EnablePiped
+5522,"@@ -57,7 +57,9 @@ class _Session(object):
+         return hashlib.sha256(auth_string + ""@"" +
+                               _Session.__initial_salt).hexdigest()
+
+-    def __init__(self, token, phash):
++    def __init__(self, token, phash, user, authenticated):
++        self.authenticated = authenticated
++        self.user = user
+         self.token = token
+         self.persistent_hash = phash
+         self.last_access = datetime.now()",Why do we have both a list of valid sessions and an instance variable if a session is destroyed?
+5523,"@@ -258,10 +258,11 @@ func (au *accountUpdates) committedUpTo(rnd basics.Round) basics.Round {
+ 	// Keep track of how many changes to each account we flush to the
+ 	// account DB, so that we can drop the corresponding refcounts in
+ 	// au.accounts.
+-	flushcount := make(map[basics.Address]int)
++	var flushcount map[basics.Address]int
+
+ 	offset := uint64(newBase - au.dbRound)
+ 	err := au.dbs.wdb.Atomic(func(tx *sql.Tx) error {
++		flushcount = make(map[basics.Address]int)
+ 		for i := uint64(0); i < offset; i++ {
+ 			rnd := au.dbRound + basics.Round(i) + 1
+ 			err := accountsNewRound(tx, rnd, au.deltas[i], au.roundTotals[i+1].RewardsLevel, au.protos[i+1])","nit : I think that it would be ""cleaner"" to set the `flushcount` to nil in case of an error nice catch ;-)"
+5524,"@@ -19,13 +19,12 @@
+ package org.phoenicis.repository.repositoryTypes;
+
+ import org.junit.Test;
+-import org.phoenicis.repository.repositoryTypes.NullRepository;
+
+ import static org.junit.Assert.assertEquals;
+
+ public class NullRepositoryTest {
+     @Test
+     public void testNullRepositoryTest() {
+-        assertEquals(0, new NullRepository().fetchInstallableApplications().size());
++        assertEquals(null, new NullRepository().fetchInstallableApplications());
+     }
+ }",You may want to use assertNull
+5525,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.
+5526,"@@ -224,7 +224,6 @@ struct wlr_output *wlr_wl_output_create(struct wlr_backend *_backend) {
+
+ 	wlr_output->width = 640;
+ 	wlr_output->height = 480;
+-	wlr_output->scale = 1;
+ 	strncpy(wlr_output->make, ""wayland"", sizeof(wlr_output->make));
+ 	strncpy(wlr_output->model, ""wayland"", sizeof(wlr_output->model));
+ 	snprintf(wlr_output->name, sizeof(wlr_output->name), ""WL-%zd"",",Why did you remove this?
+5527,"@@ -72,7 +72,12 @@ func mapPort(m portmap.Interface, c chan struct{}, protocol string, extPort, int
+ 		}
+ 	}()
+ 	for {
+-		addMapping(m, protocol, extPort, intPort, name, publisher)
++		err := addMapping(m, protocol, extPort, intPort, name, publisher)
++		if err != nil {
++			log.Infof(""%s, Mapping for port %d failed: %s"", logPrefix, extPort, err)
++		} else {
++			log.Info(""%s, Mapped network port: %d"", logPrefix, extPort)
++		}
+ 		select {
+ 		case <-c:
+ 			return",Why we need another error printouts? We already have it inside addMapping..
+5528,"@@ -215,7 +215,7 @@ bool CoreChecks::ValidateFsOutputsAgainstDynamicRenderingRenderPass(SHADER_MODUL
+     const bool alpha_to_coverage_enabled = pipeline->create_info.graphics.pMultisampleState != NULL &&
+         pipeline->create_info.graphics.pMultisampleState->alphaToCoverageEnable == VK_TRUE;
+
+-    for (uint32_t location = 0; location < pipeline->rp_state->dynamic_rendering_pipeline_create_info.colorAttachmentCount; ++location) {
++    for (uint32_t location = 0; location < location_map.size(); ++location) {
+          const auto output = location_map[location].output;
+
+         if (!output && pipeline->attachments[location].colorWriteMask != 0) {","This LGTM, but I'm curious if this fixed a specific error you were hitting?"
+5529,"@@ -181,7 +181,9 @@ func parseCgroupFromReader(r io.Reader) (map[string]string, error) {
+ 		}
+
+ 		for _, subs := range strings.Split(parts[1], "","") {
+-			cgroups[subs] = parts[2]
++			if subs != """" {
++				cgroups[subs] = parts[2]
++			}
+ 		}
+ 	}
+ 	if err := s.Err(); err != nil {","Actually we rely on this functionality in cgroup v2, where the subsystem is empty."
+5530,"@@ -1,10 +1,12 @@
+-package core
++package core_test
+
+ import (
+ 	""testing""
+ 	""unsafe""
+
+ 	""github.com/google/go-cmp/cmp""
++
++	""go.opentelemetry.io/api/core""
+ 	""go.opentelemetry.io/api/registry""
+ )
+ ",suggestion: use `core` package name
+5531,"@@ -1354,7 +1354,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+
+     # TODO: enable doctests once we drop Spark 2.3.x (due to type coercion logic
+     #  when creating arrays)
+-    def transpose(self, limit: Optional[int] = 1000):
++    def transpose(self, limit: Optional[int] = get_option(""compute.max_rows"")):
+         """"""
+         Transpose index and columns.
+ ",I think we can entirely remove this `limit` parameter for now to be consistent with other APIs.
+5532,"@@ -0,0 +1,9 @@
++from localstack.services.infra import start_moto_server
++from localstack import config
++
++
++def start_rg(port=None, asynchronous=False, update_listener=None):
++    port = port or config.PORT_RESOURCE_GROUPS
++
++    return start_moto_server('resource-groups', port, name='Resource Groups Tagging API',
++        asynchronous=asynchronous, update_listener=update_listener)",nit: `Resource Groups Tagging API` -> `Resource Groups API`
+5533,"@@ -5,10 +5,16 @@
+ package ecr
+
+ import (
++	""encoding/base64""
++	""errors""
+ 	""fmt""
+ 	""strings""
+
++	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/aws-sdk-go/aws/arn""
++	""github.com/aws/aws-sdk-go/aws/session""
++	""github.com/aws/aws-sdk-go/service/ecr""
++	""github.com/aws/aws-sdk-go/service/ecr/ecriface""
+ )
+
+ const (","This type of list + delete always make me a bit uneasy but guess there's no atomic way to do this...... Could you put a todo to retry the ""ClearRepository + delete repo"" flow a few times? Basically, imagine a new image is added right after we call `ListImages`, then `DeleteImages` will not delete that newly added image. Then the delete repo call will fail"
+5534,"@@ -1,5 +1,11 @@
+-define(['dom', 'scrollManager'], function (dom, scrollManager) {
+-    'use strict';
++/* eslint-disable indent */
++
++import dom from 'dom';
++import scrollManager from 'scrollManager';
++
++/* eslint-disable no-unused-expressions */
++'use strict';
++/* eslint-enable no-unused-expressions */
+
+     var scopes = [];
+     function pushScope(elem) {",You can remove this since ES6 modules are strict by default. And thanks for contributing to the Jellyfin Project.
+5535,"@@ -32,7 +32,7 @@ public class TransactionRLPDecoderTest {
+   private static final String FRONTIER_TX_RLP =
+       ""0xf901fc8032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b561ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
+   private static final String EIP1559_TX_RLP =
+-      ""0xf902028032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b5682020f8201711ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
++      ""0xb902060ff902028032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b5682020f8201711ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
+   private static final String GOQUORUM_PRIVATE_TX_RLP =
+       ""0xf88d0b808347b7608080b840290a80a37d198ff06abe189b638ff53ac8a8dc51a0aff07609d2aa75342783ae493b3e3c6b564c0eebe49284b05a0726fb33087b9e0231d349ea0c7b5661c8c526a07144db7045a395e608cda6ab051c86cc4fb42e319960b82087f3b26f0cbc3c2da00223ac129b22aec7a6c2ace3c3ef39c5eaaa54070fd82d8ee2140b0e70b1dca9"";
+ ",Why did eip1559 go from a list (0xf9020280.....) to a wrapped string (0xb902060ff9020280...) and not just concatenation (0x0ff9020280...)? implementation detail or is this how it sits on the wire now?
+5536,"@@ -1334,9 +1334,9 @@ func TestConfigCheckIncludes(t *testing.T) {
+ 	if err == nil {
+ 		t.Errorf(""Expected error processing include files with configuration check enabled: %v"", err)
+ 	}
+-	expectedErr := errors.New(`configs/include_bad_conf_check_b.conf:10:19: unknown field ""monitoring_port""` + ""\n"")
+-	if err != nil && expectedErr != nil && err.Error() != expectedErr.Error() {
+-		t.Errorf(""Expected: \n%q, got\n: %q"", expectedErr.Error(), err.Error())
++	expectedErr := `include_bad_conf_check_b.conf:10:19: unknown field ""monitoring_port""` + ""\n""
++	if err != nil && !strings.HasSuffix(err.Error(), expectedErr) {
++		t.Errorf(""Expected: \n%q, got\n: %q"", expectedErr, err.Error())
+ 	}
+ }
+ ",@wallyqs Since on Windows it would be `\` instead of `/` I just look at the suffix past `configs/`. Let me know if that's ok or not.
+5537,"@@ -1385,5 +1385,12 @@ func (a *WebAPI) GetInsightData(ctx context.Context, req *webservice.GetInsightD
+ 	return &webservice.GetInsightDataResponse{
+ 		UpdatedAt:  updateAt,
+ 		DataPoints: idp,
++		Type:       model.InsightResultType_MATRIX,
++		Matrix: []*model.InsightSampleStream{
++			{
++				Labels:     nil,
++				DataPoints: idp,
++			},
++		},
+ 	}, nil
+ }",nit: Remove this assignment because it is not necessary.
+5538,"@@ -217,7 +217,10 @@ ostree_builtin_summary (int argc, char **argv, GCancellable *cancellable, GError
+       if (opt_raw)
+         flags |= OSTREE_DUMP_RAW;
+
+-      summary_data = ot_file_mapat_bytes (repo->repo_dir_fd, ""summary"", error);
++      glnx_fd_close int fd = -1;
++      if (!glnx_openat_rdonly (repo->repo_dir_fd, ""summary"", TRUE, &fd, error))
++        return FALSE;
++      summary_data = ot_fd_readall_or_mmap (fd, 0, error);
+       if (!summary_data)
+         return FALSE;
+ ","This seems like a common enough pattern to offer an equivalent wrapper in `ot-fs-util.c`, no?"
+5539,"@@ -328,6 +328,7 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
+         boolean isItemHasDownloadLink = media != null && (media instanceof FeedMedia) && ((FeedMedia) media).getDownload_url() != null;
+         menu.findItem(R.id.share_download_url_item).setVisible(isItemHasDownloadLink);
+         menu.findItem(R.id.share_download_url_with_position_item).setVisible(isItemHasDownloadLink);
++        menu.findItem(R.id.share_file).setVisible(((FeedMedia) media).fileExists());
+
+         menu.findItem(R.id.share_item).setVisible(hasWebsiteLink || isItemAndHasLink || isItemHasDownloadLink);
+ ",Wouldn't this crash the app if the user is currently listening to a stream?
+5540,"@@ -530,10 +530,10 @@ type listFn func(remote string, object *swift.Object, isDirectory bool) error
+ //
+ // Set recurse to read sub directories
+ func (f *Fs) listContainerRoot(container, directory, prefix string, addContainer bool, recurse bool, fn listFn) error {
+-	if prefix != """" {
++	if prefix != """" && !strings.HasSuffix(prefix, ""/"") {
+ 		prefix += ""/""
+ 	}
+-	if directory != """" {
++	if directory != """" && !strings.HasSuffix(directory, ""/"") {
+ 		directory += ""/""
+ 	}
+ 	// Options for ObjectsWalk",This looks like an unrelated change? What is it for?
+5541,"@@ -0,0 +1,7 @@
++package csv
++
++import ""sync/atomic""
++
++func (d *tableDecoder) IsDone() bool {
++	return d.empty || atomic.LoadInt32(&d.used) != 0
++}","Wait, what is this doing? Is this a way to create methods that are only accessible from tests?"
+5542,"@@ -93,6 +93,11 @@ func (s *Service) list(c *gin.Context) {
+ 	name := c.Query(""name"")
+ 	ns := c.Query(""namespace"")
+
++	canList := utils.CanListChaos(c, ns)
++	if !canList {
++		return
++	}
++
+ 	metas, err := s.archive.ListMeta(context.Background(), kind, ns, name, true)
+ 	if err != nil {
+ 		c.Status(http.StatusInternalServerError)","Is it more reasonable to return some errors here, such as returning error codes (403 and so on?) ?"
+5543,"@@ -68,7 +68,11 @@ export function createVNode(type, props, key, ref) {
+ 		_parent: null,
+ 		_depth: 0,
+ 		_dom: null,
+-		_lastDomChild: null,
++		// _lastDomChildSibling must be initialized to undefined b/c it will eventually
++		// be set to dom.nextSibling which can return `null` and it is important
++		// to be able to distinguish between an uninitialized _lastDomChildSibling and
++		// a _lastDomChildSibling that has been set to `null`
++		_lastDomChildSibling: undefined,
+ 		_component: null,
+ 		constructor: undefined
+ 	};",Thinking out loud... would `_nextDom` be a better name for this?
+5544,"@@ -165,11 +165,6 @@ class TestSuperfluousParentheses(CheckerTestCase):
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (foo):"", 0),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if ((foo, bar)):"", 0),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (foo(bar)):"", 0),
+-            (
+-                Message(""superfluous-parens"", line=1, args=""return""),
+-                ""return ((x for x in x))"",
+-                0,
+-            ),
+             (Message(""superfluous-parens"", line=1, args=""not""), ""not (foo)"", 0),
+             (Message(""superfluous-parens"", line=1, args=""not""), ""if not (foo):"", 1),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (not (foo)):"", 0),",Turns out the unittests also had a false positive.
+5545,"@@ -24,12 +24,12 @@ namespace OpenTelemetry.Metrics
+     public abstract class Meter
+     {
+         /// <summary>
+-        /// Creates a counter for long with given name.
++        /// Creates a counter for Int64 with given name.
+         /// </summary>
+         /// <param name=""name"">The name of the counter.</param>
+         /// <param name=""monotonic"">indicates if only positive values are expected.</param>
+         /// <returns>The counter instance.</returns>
+-        public abstract Counter<long> CreateLongCounter(string name, bool monotonic = true);
++        public Counter<long> CreateInt64Counter(string name, bool monotonic = true) => this.CreateCounter<long>(name, monotonic);
+
+         /// <summary>
+         /// Creates a counter for double with given name.","I think these method names would be clearer if written as ""Create a {type} counter|gauge|measure with given name"". eg ""Create a int64 counter with given name"" ""Create a double gauge with given name"""
+5546,"@@ -3530,7 +3530,7 @@ int LuaScriptInterface::luaDoChallengeCreature(lua_State* L)
+ int LuaScriptInterface::luaIsValidUID(lua_State* L)
+ {
+ 	//isValidUID(uid)
+-	pushBoolean(L, getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)) != nullptr);
++	pushBoolean(L, getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)));
+ 	return 1;
+ }
+ ","it pushes a boolean, so it has to be explicitly casted to boolean with != nullptr, same with all other similar stuff"
+5547,"@@ -237,6 +237,7 @@ Publisher* ParticipantImpl::createPublisher(
+         delete(pubimpl);
+         return nullptr;
+     }
++    pubimpl->m_history.rebuild_instances();
+     pubimpl->mp_writer = writer;
+     //SAVE THE PUBLISHER PAIR
+     t_p_PublisherPair pubpair;",It would be nice to have an equivalent of this call on `DataWriterImpl::enable`
+5548,"@@ -1112,6 +1112,7 @@ func (a *PipedAPI) CreateDeploymentChain(ctx context.Context, req *pipedservice.
+ 				},
+ 			},
+ 		},
++		Status:    model.ChainBlockStatus_DEPLOYMENT_BLOCK_RUNNING,
+ 		StartedAt: time.Now().Unix(),
+ 	})
+ ",Isn't this PENDING?
+5549,"@@ -30,16 +30,14 @@ function isLandmark(virtualNode) {
+ 	var explictRole = (node.getAttribute('role') || '').trim().toLowerCase();
+
+ 	if (explictRole) {
+-		if (explictRole === 'form') {
+-			return !!aria.labelVirtual(virtualNode);
+-		}
+ 		return landmarkRoles.includes(explictRole);
+ 	} else {
+ 		// Check if the node matches any of the CSS selectors of implicit landmarks
+ 		return implicitLandmarks.some(implicitSelector => {
+ 			let matches = axe.utils.matchesSelector(node, implicitSelector);
+ 			if (node.tagName.toLowerCase() === 'form') {
+-				return matches && !!aria.labelVirtual(virtualNode);
++				let title = node.getAttribute('title') || '';
++				return matches && (!!aria.labelVirtual(virtualNode) || !!axe.commons.text.sanitize(title) );
+ 			}
+ 			return matches;
+ 		});","minor detail, why aim to sanitize title if tile is empty (in some cases)? worth adding an && to check for that."
+5550,"@@ -28,9 +28,8 @@ package com.salesforce.androidsdk.smartsync.target;
+
+ import android.text.TextUtils;
+
+-import com.salesforce.androidsdk.smartstore.store.QuerySpec;
+-import com.salesforce.androidsdk.smartstore.store.SmartStore;
+ import com.salesforce.androidsdk.smartsync.manager.SyncManager;
++import com.salesforce.androidsdk.smartsync.target.ParentChildrenSyncTargetHelper.RelationshipType;
+ import com.salesforce.androidsdk.smartsync.util.ChildrenInfo;
+ import com.salesforce.androidsdk.smartsync.util.Constants;
+ import com.salesforce.androidsdk.smartsync.util.ParentInfo;",Code shared by ParentChildrenSyncDownTarget and ParentChildrenSyncUpTarget moved to ParentChildrenSyncTargetHelper
+5551,"@@ -75,12 +75,12 @@ class Local(Provisioning):
+     def startup(self):
+         self.start_time = time.time()
+
+-        self.available_slots = self.settings.get(""capacity"", None)
+-        if not self.available_slots:
+-            if self.settings.get(""sequential"", False):
+-                self.available_slots = 1
+-            else:
+-                self.available_slots = sys.maxsize      # no limit
++        if self.settings.get(""sequential"", False):
++            self.available_slots = 1
++        else:
++            self.available_slots = self.settings.get(""capacity"", None)
++            if not self.available_slots:
++                self.available_slots = sys.maxsize  # no limit
+
+         for executor in self.executors:
+             start_at = executor.execution.get('start-at', 0)","The bug is not about the priority , But we use 2 config items CAPACITY and SEQUENTIAL to control 1 action: thoughput. If 'sequential' is given to 'False' as default in configfile and then I use 'capacity' to 10 in my test.yml , the 'capacity' 's priority should be higher than default 'sequential'. So, I suggest we use only one 'capacity', it is enough. '1' is sequential, more than 1 is capacity, None is sys.maxsize."
+5552,"@@ -9,10 +9,13 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+
++	tf ""github.com/filecoin-project/go-filecoin/testhelpers/testflags""
+ 	mockplugin ""github.com/filecoin-project/go-filecoin/tools/iptb-plugins/filecoin/mock""
+ )
+
+ func TestStartLogCapture(t *testing.T) {
++	tf.IntegrationTest(t)
++
+ 	assert := assert.New(t)
+ 	require := require.New(t)
+ 	ctx := context.Background()","I don't know if I'd call any of these FAST tests integration tests. They are unit tests for FAST. They use a mock plugin which doesn't actually start any external processes, etc."
+5553,"@@ -27,10 +27,12 @@ const (
+ 	invalidVersion version = ""invalid.version""
+ )
+
++// CurrentVersion returns the version of the calling instance
+ func CurrentVersion() version {
+ 	return version(mver.GetVersion())
+ }
+
++// Version returns the version in version type if present
+ func Version(version string) version {
+ 	switch version {
+ 	case ""0.7.0"":",Can you provide corresponding UT for this.
+5554,"@@ -29,6 +29,8 @@ import (
+ 	""testing""
+ 	""time""
+
++	""golang.org/x/net/context""
++
+ 	""github.com/yarpc/yarpc-go/encoding/raw""
+ 	""github.com/yarpc/yarpc-go/transport""
+ 	""github.com/yarpc/yarpc-go/transport/transporttest""",nit: this should be below the yarpc group
+5555,"@@ -44,6 +44,10 @@ func New(name, tip string, labelNames []string, defaultLabels []string) (*TimerF
+ 		labelNames,
+ 	)
+ 	err := prometheus.Register(vect)
++	switch err.(type) {
++	case prometheus.AlreadyRegisteredError:
++		err = nil
++	}
+
+ 	return &TimerFactory{
+ 		labelNames:    labelNames,",singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`)
+5556,"@@ -442,7 +442,17 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			retry := 0
++			for err != nil && retry < 10 {
++				// Set Ready and Live to false
++				healthAggregator.Report(healthName, &health.HealthReport{Live: false, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Warn(""Retrying to start Typha"")
++				retry++
++			}
++			if err != nil && retry > 10 {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()","Please log once here at Error level ""Failed to connect to Typha, will retry..."""
+5557,"@@ -31,7 +31,7 @@ func TestICMPPortUnreachable(t *testing.T) {
+ 	_, ipv4, _, _, pktBytes, err := testPacketUDPDefault()
+ 	Expect(err).NotTo(HaveOccurred())
+
+-	runBpfUnitTest(t, ""icmp_port_unreachable.c"", func(bpfrun bpfProgRunFn) {
++	runBpfUnitTest(t, ""icmp_port_unreachable.c"", false, func(bpfrun bpfProgRunFn) {
+ 		res, err := bpfrun(pktBytes)
+ 		Expect(err).NotTo(HaveOccurred())
+ 		Expect(res.Retval).To(Equal(0))","Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes."
+5558,"@@ -6,11 +6,14 @@ from pyramid import httpexceptions
+
+
+ class NameGenerator(generators.Generator):
++    regexp = r'^[a-zA-Z0-9][a-zA-Z0-9_-]*$'
++
+     def __call__(self):
+         ascii_letters = ('abcdefghijklmopqrstuvwxyz'
+                          'ABCDEFGHIJKLMOPQRSTUVWXYZ')
+-        alphabet = ascii_letters + string.digits + '-'
+-        letters = [random.choice(alphabet) for x in range(8)]
++        alphabet = ascii_letters + string.digits + '-_'
++        letters = [random.choice(ascii_letters + string.digits)]
++        letters += [random.choice(alphabet) for x in range(7)]
+         return ''.join(letters)
+
+ ",So we fix it only for kinto and not for all cliquet resources?
+5559,"@@ -11,9 +11,10 @@ import (
+ 	""fmt""
+ 	""math/big""
+
+-	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ 	""github.com/pkg/errors""
+
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
++
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""",No empty line between
+5560,"@@ -141,6 +141,9 @@ func main() {
+ 				fatal(err)
+ 			}
+ 		}
++		if err := reviseRootDir(context); err != nil {
++			return err
++		}
+ 		return logs.ConfigureLogging(createLogConfig(context))
+ 	}
+ ",We have `ResolveRootfs` in `libcontainer/utils` so maybe use that one here?
+5561,"@@ -630,6 +630,19 @@ namespace AutoRest.Swagger.Tests
+             messages.AssertOnlyValidationMessage(typeof(SummaryAndDescriptionMustNotBeSame), 1);
+         }
+
++        [Fact]
++        public void LongRunningHasExtensionValidation()
++        {
++            var messages = ValidateSwagger(Path.Combine(Core.Utilities.Extensions.CodeBaseDirectory, ""Resource"", ""Swagger"", ""Validation"", ""long-running-operation-extension.json""));
++            messages.AssertOnlyValidationMessage(typeof(LongRunningOperationsWithLongRunningExtension), 1);
++        }
++
++        [Fact]
++        public void LongRunningHasExtensionTrueValidation()
++        {
++            var messages = ValidateSwagger(Path.Combine(Core.Utilities.Extensions.CodeBaseDirectory, ""Resource"", ""Swagger"", ""Validation"", ""long-running-operation-extension-2.json""));
++            messages.AssertOnlyValidationMessage(typeof(LongRunningOperationsWithLongRunningExtension), 1);
++        }
+     }
+
+     #region Positive tests","Just curious, do we have positive test covered somewhere?"
+5562,"@@ -101,7 +101,7 @@ static void move_resize(struct roots_view *view, double x, double y,
+ 		constrained_height);
+ 	if (serial > 0) {
+ 		roots_surface->pending_move_resize_configure_serial = serial;
+-	} else {
++	} else if(roots_surface->pending_move_resize_configure_serial == 0) {
+ 		view->x = x;
+ 		view->y = y;
+ 	}","Style error, put a space between `if` and `(`"
+5563,"@@ -239,6 +239,13 @@ type Config struct {
+ 	//    	Key: aws.String(""/foo/bar/moo""),
+ 	//    })
+ 	EnableEndpointDiscovery *bool
++
++	// DisableEndpointHostPrefix will disable the SDK's behavior of prefixing
++	// request endpoint hosts with modeled information.
++	//
++	// Disabling this feature is useful when you want to use local endpoints
++	// for testing that do not support the modeled host prefix pattern.
++	DisableEndpointHostPrefix *bool
+ }
+
+ // NewConfig returns a new Config pointer that can be chained with builder","It's a bit odd to have a ""disable<x>"" boolean, though it looks like you already do that for a few other flags."
+5564,"@@ -47,6 +47,7 @@ const (
+ // Timelimits for docker operations enforced above docker
+ const (
+ 	pullImageTimeout        = 2 * time.Hour
++	loadImageTimeout        = 2 * time.Hour
+ 	createContainerTimeout  = 3 * time.Minute
+ 	startContainerTimeout   = 1*time.Minute + 30*time.Second
+ 	stopContainerTimeout    = 1 * time.Minute",Why did you pick two hours for this?
+5565,"@@ -110,8 +110,8 @@ func getNewPassword(gopts GlobalOptions) (string, error) {
+ 	newopts.password = """"
+
+ 	return ReadPasswordTwice(newopts,
+-		""enter password for new key: "",
+-		""enter password again: "")
++		""enter password (new): "",
++		""enter password (again): "")
+ }
+
+ func addKey(gopts GlobalOptions, repo *repository.Repository) error {","What about ""enter new password""? That would be a bit more consistent to the `ReadPasswordTwice` usage in cmd_init."
+5566,"@@ -20,7 +20,7 @@ if not versionInfo.updateVersionType:
+ 	raise RuntimeError(""No update version type, update checking not supported"")
+ import addonAPIVersion
+ # Avoid a E402 'module level import not at top of file' warning, because several checks are performed above.
+-from gui.contextHelp import ContextHelpMixin  # noqa: E402
++import gui.contextHelp  # noqa: E402
+ from gui.dpiScalingHelper import DpiScalingHelperMixin, DpiScalingHelperMixinWithoutInit  # noqa: E402
+ import winVersion
+ import os",Another redundant import
+5567,"@@ -120,7 +120,7 @@ func (c *client) FetchUpdates(ctx context.Context, req *node.FetchX509SVIDReques
+ 	// Close the stream whether there was an error or not
+ 	stream.CloseSend()
+ 	if err != nil {
+-		// TODO: should we try to create a new stream?
++		c.Release()
+ 		return nil, err
+ 	}
+ ","What kind of errors might cause us to reach this point? Could any of them be recoverable i.e. might work if we asked the same server again? Similar question for below, but perhaps with a slightly different answer"
+5568,"@@ -212,14 +212,14 @@ public:
+
+ class triangle_counting_test {
+ public:
+-    using my_graph_type = dal::preview::undirected_adjacency_vector_graph<>;
++    using graph_type = dal::preview::undirected_adjacency_vector_graph<>;
+
+     template <typename GraphType>
+     auto create_graph() {
+         GraphType graph_data;
+-        my_graph_type my_graph;
++        graph_type graph;
+
+-        auto &graph_impl = oneapi::dal::detail::get_impl(my_graph);
++        auto &graph_impl = oneapi::dal::detail::get_impl(graph);
+         auto &vertex_allocator = graph_impl._vertex_allocator;
+         auto &edge_allocator = graph_impl._edge_allocator;
+ ",What is the difference between GraphType and graph_type. Naming should be more accurate.
+5569,"@@ -9,7 +9,7 @@ use Shopsys\FrameworkBundle\Model\Product\Product;
+ class UnitRepository
+ {
+     /**
+-     * @var \Doctrine\ORM\EntityRepository
++     * @var \Doctrine\ORM\EntityManagerInterface
+      */
+     protected $em;
+ ",hmmm in docblock of contructor it is EntityManagerInterface....maybe it should be that way.... :confused:
+5570,"@@ -54,8 +54,13 @@ struct feat_wrapper {
+         .def(""GetPos"",
+              (RDGeom::Point3D(MolChemicalFeature::*)(int) const) &
+                  MolChemicalFeature::getPos,
+-             (python::arg(""self""), python::arg(""confId"") = -1),
++             (python::arg(""self""), python::arg(""confId"")),
+              ""Get the location of the chemical feature"")
++        .def(""GetPosDefault"",
++             (RDGeom::Point3D(MolChemicalFeature::*)() const) &
++                 MolChemicalFeature::getPos,
++             python::arg(""self""),
++             ""Get the location of the default chemical feature (first position)"")
+         .def(""GetAtomIds"", getFeatAtomIds,
+              ""Get the IDs of the atoms that participate in the feature"")
+         .def(""GetMol"", &MolChemicalFeature::getMol,","I'm curious why you went the route of adding a new method name for this. Given that you it would be possible to just have an an overload of `GetPos()`, and that this change breaks existing code, I wonder why you chose to go this way."
+5571,"@@ -33,12 +33,14 @@ export default Component.extend({
+         let subscriptions = this.member.get('stripe');
+         if (subscriptions && subscriptions.length > 0) {
+             return subscriptions.map((subscription) => {
++                const statusLabel = subscription.status === 'past_due' ? 'Past due' : subscription.status;
+                 return {
+                     id: subscription.id,
+                     customer: subscription.customer,
+                     name: subscription.name || '',
+                     email: subscription.email || '',
+                     status: subscription.status,
++                    statusLabel: statusLabel,
+                     startDate: subscription.start_date ? moment(subscription.start_date).format('D MMM YYYY') : '-',
+                     plan: subscription.plan,
+                     amount: parseInt(subscription.plan.amount) ? (subscription.plan.amount / 100) : 0,",Does this need to change `'active'` to `'Active'` and that? Or is that done in CSS or something?
+5572,"@@ -11,6 +11,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     public class Http2Limits
+     {
+         private int _maxStreamsPerConnection = 100;
++        private int _headerTableSize = MaxAllowedHeaderTableSize;
++        private int _maxFrameSize = MinAllowedMaxFrameSize;
++
++        // These are limits defined by the RFC https://tools.ietf.org/html/rfc7540#section-4.2
++        public const int MaxAllowedHeaderTableSize = 4096;
++        public const int MinAllowedMaxFrameSize = 16 * 1024;
++        public const int MaxAllowedMaxFrameSize = 16 * 1024 * 1024 - 1;
+
+         /// <summary>
+         /// Limits the number of concurrent request streams per HTTP/2 connection. Excess streams will be refused.",Why are these constants public? They should also be listed above members.
+5573,"@@ -217,6 +217,8 @@ public class MainnetTransactionValidator {
+     // org.bouncycastle.math.ec.ECCurve.AbstractFp.decompressPoint throws an
+     // IllegalArgumentException for ""Invalid point compression"" for bad signatures.
+     try {
++      // TODO: this is where we are checking the signature. We have to fix the v value if this is a
++      // private transaction
+       transaction.getSender();
+     } catch (final IllegalArgumentException e) {
+       return ValidationResult.invalid(",This TODO isn't related to this change. We should remove it.
+5574,"@@ -27,7 +27,5 @@ import org.apache.iceberg.FieldMetrics;
+ public interface ValueWriter<D> {
+   void write(D datum, Encoder encoder) throws IOException;
+
+-  default Stream<FieldMetrics> metrics() {
+-    return Stream.empty(); // TODO will populate in following PRs
+-  }
++  Stream<FieldMetrics> metrics();
+ }","`FieldMetrics` is parameterized, but this is a bare reference. Could you update it? I think it should be `FieldMetrics<?>` since the metrics are not necessarily for the written value type, `D`."
+5575,"@@ -58,12 +58,11 @@ namespace Examples.Console
+             // Application which decides to enable OpenTelemetry metrics
+             // would setup a MeterProvider and make it default.
+             // All meters from this factory will be configured with the common processing pipeline.
+-            MeterProvider.SetDefault(Sdk.CreateMeterProvider(mb =>
+-            {
+-                mb.SetMetricProcessor(processor);
+-                mb.SetMetricExporter(promExporter);
+-                mb.SetMetricPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs));
+-            }));
++            MeterProvider.SetDefault(Sdk.CreateMeterProviderBuilder()
++                .SetProcessor(processor)
++                .SetExporter(promExporter)
++                .SetPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs))
++                .Build());
+
+             // The following shows how libraries would obtain a MeterProvider.
+             // MeterProvider is the entry point, which provides Meter.",@cijothomas do we want this to be `Set` or `Add`?
+5576,"@@ -42,7 +42,7 @@ namespace Nethermind.JsonRpc
+         public string? IpcUnixDomainSocketPath { get; set; } = null;
+
+         public string[] EnabledModules { get; set; } = ModuleType.DefaultModules.ToArray();
+-        public long? GasCap { get; set; } = 100000000;
++        public long? GasCap { get; set; } = 50000000;
+         public int ReportIntervalSeconds { get; set; } = 300;
+         public bool BufferResponses { get; set; }
+         public string CallsFilterFilePath { get; set; } = ""Data/jsonrpc.filter"";",Why are we dropping GasCap?
+5577,"@@ -45,11 +45,11 @@ namespace OpenTelemetry.Shims.OpenTracing
+
+         public SpanShim(TelemetrySpan span)
+         {
+-            this.Span = span ?? throw new ArgumentNullException(nameof(span));
++            this.Span = span ?? throw new ArgumentNullException(nameof(span), ""Parameter cannot be null"");
+
+             if (!this.Span.Context.IsValid)
+             {
+-                throw new ArgumentException(nameof(this.Span.Context));
++                throw new ArgumentException(""Passed span's context is not valid"", nameof(this.Span.Context));
+             }
+
+             this.spanContextShim = new SpanContextShim(this.Span.Context);",should we end the text with a .?
+5578,"@@ -752,9 +752,10 @@ dispatch_enter_dynamorio(dcontext_t *dcontext)
+            wherewasi == DR_WHERE_APP ||
+            /* If the thread was waiting at check_wait_at_safe_point when getting
+             * suspended, we were in dispatch (ref i#3427). We will be here after the
+-            * thread's context is being reset before sending it native.
++            * thread's context is being reset proactively (due to some -reset_at_*
++            * option) or before sending it native.
+             */
+-           (dcontext->go_native && wherewasi == DR_WHERE_DISPATCH));
++           wherewasi == DR_WHERE_DISPATCH);
+     dcontext->whereami = DR_WHERE_DISPATCH;
+     ASSERT_LOCAL_HEAP_UNPROTECTED(dcontext);
+     ASSERT(check_should_be_protected(DATASEC_RARELY_PROT));","Could this instead keep the `go_native` and add to it ""or the last exit was the special reset exit""?"
+5579,"@@ -42,9 +42,9 @@ ConfigPanelDialog::ConfigPanelDialog(LXQtPanel *panel, QWidget *parent):
+     addPage(mPluginsPage, tr(""Widgets""), QLatin1String(""preferences-plugin""));
+     connect(this, &ConfigPanelDialog::reset, mPluginsPage, &ConfigPluginsWidget::reset);
+
+-    connect(this, &ConfigPanelDialog::accepted, [panel] {
++    connect(this, &ConfigPanelDialog::accepted, this, [panel] {
+         panel->saveSettings();
+-   });
++    });
+ }
+
+ void ConfigPanelDialog::showConfigPanelPage()","Oh, I missed this one: The other instances of `this` you've added as lambda contexts aren't really needed, although they're harmless. However, in the above connection, the missing context is `panel`, not `this`. Please correct it! Clazy may show warnings about lambda contexts (I don't use Clazy) but, if so, that's a problem in clazy: it isn't smart enough to know about them."
+5580,"@@ -160,14 +160,9 @@ class Service(object):
+                     except AttributeError:
+                         pass
+                 self.process.terminate()
+-                self.process.kill()
+                 self.process.wait()
++                self.process.kill()
+                 self.process = None
+         except OSError:
+             # kill may not be available under windows environment
+             pass
+-
+-    def __del__(self):
+-        # subprocess.Popen doesn't send signal on __del__;
+-        # we have to try to stop the launched process.
+-        self.stop()",can we add a try / except around this to make it more stable? I like the idea of any mistakenly un-quit drivers closing down after the process is quit (the java server does this... also i forget to do driver.quit often when i use the command line repl :) )
+5581,"@@ -68,9 +68,12 @@ func (vd *volAPI) cloudMigrateStatus(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	if err := json.NewDecoder(r.Body).Decode(statusReq); err != nil {
+-		vd.sendError(vd.name, method, w, err.Error(), http.StatusBadRequest)
+-		return
++	// Use empty request if nothing was sent
++	if r.ContentLength != 0 {
++		if err := json.NewDecoder(r.Body).Decode(statusReq); err != nil {
++			vd.sendError(vd.name, method, w, err.Error(), http.StatusBadRequest)
++			return
++		}
+ 	}
+
+ 	statusResp, err := d.CloudMigrateStatus(statusReq)",when would this happen? backward compatibility?
+5582,"@@ -0,0 +1,13 @@
++/**
++ * Returns the tagName,
++ * if it is a HTMLElement it gets lowercased
++ * @param  {Element} node element
++ * @return {String}       normalized tagName
++ */
++axe.utils.getTagName = function(node) {
++	if (node.namespaceURI === 'http://www.w3.org/1999/xhtml') {
++		return node.tagName.toLowerCase();
++	}
++
++	return node.tagName;
++};",I'm not sure what the value of this is. So far we've solved this by always doing `tagName.toUpperCase()` for everything. I think we should stick with this.
+5583,"@@ -25,6 +25,16 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	snapshotListCommandHelpText = `
++Usage: mayactl snapshot list [options]
++
++$ mayactl snapshot list --volname <vol>
++
++This command displays status of available snapshot.
++`
++)
++
+ // NewCmdSnapshotCreate creates a snapshot of OpenEBS Volume
+ func NewCmdSnapshotList() *cobra.Command {
+ 	options := CmdSnaphotCreateOptions{}",This command displays available snapshots on a volume.
+5584,"@@ -38,7 +38,7 @@ import (
+ 	""golang.org/x/tools/go/types/typeutil""
+
+ 	cpb ""kythe.io/kythe/proto/common_go_proto""
+-	spb ""kythe.io/kythe/proto/storage_go_proto""
++	stpb ""kythe.io/kythe/proto/storage_go_proto""
+ )
+
+ // EmitOptions control the behaviour of the Emit function. A nil options",`spb` is the standard package name we use for this proto.
+5585,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
+5586,"@@ -369,8 +369,8 @@ func msgToApplication(msg model.Message) (*Application, error) {
+ 	return app, nil
+ }
+
+-// TODO: upgrade to parallel process
+ // Process translate msg to application , process and send resp to edge
++// TODO: upgrade to parallel process
+ func (c *Center) Process(msg model.Message) {
+ 	app, err := msgToApplication(msg)
+ 	if err != nil {",is this pr support parallelly process application?
+5587,"@@ -48,7 +48,9 @@ func MustEnableIssues(ctx *middleware.Context) {
+ }
+
+ func MustEnablePulls(ctx *middleware.Context) {
+-	if !ctx.Repo.Repository.EnablePulls {
++	if !ctx.Repo.Repository.CanEnablePulls() {
++		ctx.Handle(404, ""Unsupported"", nil)
++	} else if !ctx.Repo.Repository.EnablePulls {
+ 		ctx.Handle(404, ""MustEnablePulls"", nil)
+ 	}
+ ","Based on the assumption that when `EnablePulls` is `true`, `CanEnablePulls` must be `true` as well, then this `if` check is redundant. Actually... we have `AllowsPulls` now... why not use that?"
+5588,"@@ -637,7 +637,7 @@ public class ScheduleServlet extends LoginAbstractAzkabanServlet {
+     if (flow == null) {
+       ret.put(""status"", ""error"");
+       ret.put(""message"", ""Flow "" + flowName + "" cannot be found in project ""
+-          + project);
++          + projectName);
+       return;
+     }
+ ",I am not sure why the API requires both project name and project ID as inputs. Wouldn't it introduce more opportunities for clients to make mistakes?
+5589,"@@ -15,7 +15,7 @@ module Ncr
+
+     def edit
+       if self.proposal.approved?
+-        flash[:warning] = ""You are about to modify a fully approved request. Changes will be logged and sent to approvers, and this request may require re-approval, depending on the change.""
++        flash.now[:warning] = ""You are about to modify a fully approved request. Changes will be logged and sent to approvers, and this request may require re-approval, depending on the change.""
+       end
+
+       super","I believe this was happening for several different flash messages - should we add `now` to all flash messages? (there might be a downside to doing that, but I am not sure what it would be)"
+5590,"@@ -46,6 +46,9 @@ class ExceptionListener extends BaseExceptionListener
+         parent::__construct($controller, $logger);
+     }
+
++    /**
++     * {@inheritdoc}
++     */
+     public function onKernelException(GetResponseForExceptionEvent $event)
+     {
+         $exception = $event->getException();","There is no docblock on the parent method. Also, not related, but I forgot to typehint the `$templating` constructor argument above."
+5591,"@@ -669,6 +669,12 @@ func TestDdevXdebugEnabled(t *testing.T) {
+ 	runTime := util.TimeTrack(time.Now(), fmt.Sprintf(""%s %s"", site.Name, t.Name()))
+
+ 	phpVersions := nodeps.ValidPHPVersions
++
++	// arm64 builds from deb.sury.org do not have xdebug in php5.6
++	if runtime.GOARCH == ""arm64"" {
++		t.Log(""Skipping php5.6 test on arm64 because deb.sury.org packages do not include it currently"")
++		delete(phpVersions, ""5.6"")
++	}
+ 	phpKeys := make([]string, 0, len(phpVersions))
+ 	for k := range phpVersions {
+ 		phpKeys = append(phpKeys, k)","Silly me. This shouldn't be done in the tests, but instead in the actual definition of ValidPHPVersions on arm64. Same with Mysql and MariaDB."
+5592,"@@ -42,7 +42,8 @@ final class LatLonShapeBoundingBoxQuery extends ShapeQuery {
+   @Override
+   protected Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
+                                             int maxXOffset, int maxYOffset, byte[] maxTriangle) {
+-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
++    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
++        queryRelation == QueryRelation.INTERSECTS);
+   }
+
+   /** returns true if the query matches the encoded triangle */",Shouldn't this work as well for Disjoint?
+5593,"@@ -514,11 +514,11 @@ func (c *controller) finalizeOrder(ctx context.Context, cl acmecl.Interface, o *
+ 	// if it is already in the 'valid' state, as upon retry we will
+ 	// then retrieve the Certificate resource.
+ 	_, errUpdate := c.updateOrderStatus(ctx, cl, o)
+-	if acmeErr, ok := err.(*acmeapi.Error); ok {
++	if acmeErr, ok := errUpdate.(*acmeapi.Error); ok {
+ 		if acmeErr.StatusCode >= 400 && acmeErr.StatusCode < 500 {
+ 			log.Error(err, ""failed to update Order status due to a 4xx error, marking Order as failed"")
+ 			c.setOrderState(&o.Status, string(cmacme.Errored))
+-			o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", err)
++			o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", errUpdate)
+ 			return nil
+ 		}
+ 	}","You've not updated the `o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", err)` line below here when you changed this, so here we are checking `errUpdate` but will print the contents of `err` instead."
+5594,"@@ -23,6 +23,9 @@ require 'socket'
+ module Selenium
+   module WebDriver
+     class SocketPoller
++      NOT_CONNECTED_ERRORS = [Errno::ECONNREFUSED, Errno::ENOTCONN, SocketError]
++      NOT_CONNECTED_ERRORS << Errno::EPERM if Platform.cygwin?
++
+       def initialize(host, port, timeout = 0, interval = 0.25)
+         @host     = host
+         @port     = Integer(port)",Doesn't this need to include `Errno::ECONNRESET` to fix the issue?
+5595,"@@ -301,6 +301,9 @@ public class Constants {
+     public static final String PROJECT_CACHE_SIZE_PERCENTAGE = ""azkaban""
+         + "".project_cache_size_percentage_of_disk"";
+
++    public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = ""azkaban""
++        + "".project_cache_throttle_percentage"";
++
+     // how many older versions of project files are kept in DB before deleting them
+     public static final String PROJECT_VERSION_RETENTION = ""project.version.retention"";
+ ","Please consider keeping the config key in one line as it will help in case someone is looking at how this config is used. public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = ""azkaban.project_cache_throttle_percentage"";"
+5596,"@@ -46,6 +46,7 @@ type DataStore interface {
+
+ 	ListParentIDEntries(request *ListParentIDEntriesRequest) (*ListParentIDEntriesResponse, error)
+ 	ListSelectorEntries(request *ListSelectorEntriesRequest) (*ListSelectorEntriesResponse, error)
++	ListPowerSelectorEntries(request *ListSelectorEntriesRequest) (*ListSelectorEntriesResponse, error)
+ 	ListSpiffeEntries(request *ListSpiffeEntriesRequest) (*ListSpiffeEntriesResponse, error)
+
+ 	RegisterToken(request *JoinToken) (*common.Empty, error)","This is a hard one, naming-wise... `ListPowerSelectorEntries` is logical given `ListSelectorEntries`. Another option could be `ListMatchingEntries` or even `FindMatchingEntries`. :shrug:"
+5597,"@@ -0,0 +1,4 @@
++package types
++
++// UVarint represent a 32-bit number encoded as varint.
++type UVarint uint",This should be called `Uint` or `Uint32` or simply using our `Uint64` type instead. All of our numbers have varint encoding. It's not inherently a varint.
+5598,"@@ -1513,7 +1513,8 @@ class CommandDispatcher:
+             )
+
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+-    def view_source(self, edit=False):
++    @cmdutils.argument('pygment')
++    def view_source(self, edit=False, pygment=False):
+         """"""Show the source of the current page in a new tab.
+
+         Args:",No need for this when you don't need to customize anything about the argument.
+5599,"@@ -0,0 +1,14 @@
++<!-- TODO: Move this away from using ID attr -->
++<div class=""panel-group section-group""
++     data-modifiable=""<%= modifiable %>""
++     id=""sections_accordion""
++     role=""tablist"">
++  <% sections.each do |section| %>
++    <%= render partial: ""org_admin/sections/section"",
++               object: section,
++               locals: { phase: phase,
++                         template: template,
++                         current_section: current_section,
++                         draggable: section == sections.first } %>
++  <% end%>
++</div>",We're now going to have 3 `#sections_accordion` will need to see how JS behaves. We should probably switch to a class selector instead
+5600,"@@ -0,0 +1,10 @@
++class CreateTestClientRequests < ActiveRecord::Migration
++  def change
++    create_table :test_client_requests do |t|
++      t.decimal :amount
++      t.string :project_title
++
++      t.timestamps null: false
++    end
++  end
++end",did you mean to leave this in here?
+5601,"@@ -54,6 +54,7 @@ var (
+ 	labels               = flag.String(""labels"", """", ""List of label KEY=VALUE pairs to add. Keys must start with a lowercase character and contain only hyphens (-), underscores (_), lowercase characters, and numbers. Values must contain only hyphens (-), underscores (_), lowercase characters, and numbers."")
+ 	storageLocation      = flag.String(""storage_location"", """", ""Location for the imported image which can be any GCS location. If the location parameter is not included, images are created in the multi-region associated with the source disk, image, snapshot or GCS bucket."")
+ 	uefiCompatible       = flag.Bool(""uefi_compatible"", false, ""Enables UEFI booting, which is an alternative system boot method. Most public images use the GRUB bootloader as their primary boot method."")
++	sysprepWindows       = flag.Bool(""sysprep_windows"", false, ""Whether to generalize image using Windows Sysprep."")
+ )
+
+ func importEntry() (*daisy.Workflow, error) {","Mention that it only applies to Windows. This is kind of implied, but better to be explicit."
+5602,"@@ -28,6 +28,8 @@ var (
+ 	autoStake  = true
+ 	index      = uint64(10)
+ 	senderKey  = identityset.PrivateKey(27)
++	zero       = ""0""
++	negtive    = ""-10""
+ )
+
+ func TestCreateStake(t *testing.T) {",again: it is a bad practice to have some global parameters with such common names for unit test purpose.
+5603,"@@ -21,10 +21,7 @@ class Shopware6Connector
+
+     private ?string $token;
+
+-    /**
+-     * @var \DateTimeInterface
+-     */
+-    private $expiresAt;
++    private \DateTimeInterface $expiresAt;
+
+     public function __construct(Configurator $configurator)
+     {",Should we use `\DateTimeInterface` or `DateTimeInterface` and declaration of `DateTimeInterface` in `use`?
+5604,"@@ -7,11 +7,15 @@ import (
+ 	""errors""
+ 	""fmt""
+
++	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/copilot-cli/internal/pkg/aws/cloudformation""
+ 	""github.com/aws/copilot-cli/internal/pkg/deploy""
++
+ 	""github.com/aws/copilot-cli/internal/pkg/deploy/cloudformation/stack""
+ )
+
++const taskStackPrefix = ""task-""
++
+ // DeployTask deploys a task stack and waits until the deployment is done.
+ // If the task stack doesn't exist, then it creates the stack.
+ // If the task stack already exists, it updates the stack.",What do you think of moving this stack related constant to the `stack` pkg?
+5605,"@@ -100,6 +100,9 @@ func TxnPool(s *transactions.SignedTxn, ctx Context, verificationPool execpool.B
+ 	if s.Txn.Src() == zeroAddress {
+ 		return errors.New(""empty address"")
+ 	}
++	if !proto.SupportRekeying && (s.AuthAddr != basics.Address{}) {
++		return errors.New(""nonempty AuthAddr but rekeying not supported"")
++	}
+
+ 	outCh := make(chan error, 1)
+ 	cx := asyncVerifyContext{s: s, outCh: outCh, ctx: &ctx}","Hm, I guess that you're doing this here since `WellFormed` is on a `transactions.Transaction` and not a `transactions.SignedTxn`, but quickly grepping through our code, it looks like we always a `SignedTxn` around when calling `WellFormed` (except maybe some tests?)... this doesn't have to happen here, but maybe we should update that in a separate PR since this really feels like a `WellFormed` check."
+5606,"@@ -39,4 +39,6 @@ storiesOf( 'Global', module )
+ 				<ModulesList />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} );",This story also needs the default padding.
+5607,"@@ -745,7 +745,7 @@ public class MockDirectoryWrapper extends BaseDirectoryWrapper {
+       maybeThrowDeterministicException();
+     }
+     if (!LuceneTestCase.slowFileExists(in, name)) {
+-      throw randomState.nextBoolean() ? new FileNotFoundException(name + "" in dir="" + in) : new NoSuchFileException(name + "" in dir="" + in);
++      throw new NoSuchFileException(name + "" in dir="" + in);
+     }
+
+     // cannot open a file for input if it's still open for output.",Hmm why did we remove the randomness about which (confusingly) different exception to throw here? This randomness was (is?) useful to help test that Lucene indeed catches `FNFE` and `NSFE` interchangeably.
+5608,"@@ -1215,10 +1215,10 @@ ostree_repo_list_collection_refs (OstreeRepo                 *self,
+                   continue;
+                 }
+
+-              if (match_collection_id != NULL && g_strcmp0 (match_collection_id, current_collection_id) != 0)
++              if (match_collection_id != NULL && g_strcmp0 (match_collection_id, remote_collection_id) != 0)
+                 continue;
+               else
+-                  current_collection_id = remote_collection_id;
++                current_collection_id = remote_collection_id;
+             }
+
+           if (!glnx_opendirat (dfd_iter.fd, dent->d_name, TRUE, &subdir_fd, error))","Hm, so before in that case `current_collection_id` looks like it was actually an uninitialized pointer. It seems weird to me that the tests pass both ways. I haven't looked closely at the tests - is there something wrong there that causes this to spuriously pass before?"
+5609,"@@ -46,9 +46,13 @@
+  * If you will separate the definitions for the parsers, you must revise the
+  * code related to the symbol table. */
+ typedef enum {
+-	K_IGNORE = -2,
+-	K_UNDEFINED,
+-	K_CONSTANT,
++	/* parser private items */
++	K_IGNORE = -16,
++	K_DEFINE,
++
++	K_UNDEFINED = KEYWORD_NONE,
++	/* the followings items are also used as indices for VerilogKinds[] and SystemVerilogKinds[] */
++	K_CONSTANT= 0,
+ 	K_EVENT,
+ 	K_FUNCTION,
+ 	K_MODULE,","s it the best way to tag ""foo"" of ""`define foo ..."" with constant kind? Introducing ""d/definition"" kind and tagging the ""foo"" with the definition kind is an alternative way. Using the unified kind ""constant"" in many areas reduces the information that client tools get from a tags file. In my experience, it is better to tag different things with different kinds. If ctags hides the differences, and just reports various language objects as ""constant,"" in some cases, a client tool must parse the raw .sv source file for distinguishing whether a given tag is ""`define""'ed or not. IMHO, ctags should not be too smart. Instead, ctags should be stupid; it should report what it sees in source input files as-is to client tools that will do something smart."
+5610,"@@ -213,7 +213,6 @@ const CASE_TRANSLATION = {
+   tlscafile: 'tlsCAFile',
+   tlscertificatekeyfile: 'tlsCertificateKeyFile',
+   tlscertificatekeyfilepassword: 'tlsCertificateKeyFilePassword',
+-  wtimeout: 'wTimeoutMS',
+   j: 'journal'
+ };
+ ","is this a breaking change? If I'm not mistaken, this is translating a user-provided `wtimeout` in the connection string into `wTimeoutMS`"
+5611,"@@ -0,0 +1,7 @@
++import json
++
++
++def lambda_handler(event, context):
++    # Just print the event was passed to lambda
++    print('{}'.format(json.dumps(event)))
++    return 0","Can we rename this file to `lambda_echo.py`, to be more descriptive and in line with the other files in this directory? (all files in this folder are lambda functions, after all)"
+5612,"@@ -33,9 +33,10 @@ type Seccomp struct {
+ type Action int
+
+ const (
+-	Kill Action = iota - 4
++	Kill Action = iota - 5
+ 	Errno
+ 	Trap
++	Trace
+ 	Allow
+ )
+ ",why not do it like this ? <pre><code> const ( Kill Action = iota Errno Trap Allow Trace ) <pre><code>
+5613,"@@ -265,6 +265,7 @@ namespace NLog.Internal.FileAppenders
+         /// <param name=""expireTime"">The time which prior the appenders considered expired</param>
+         public void CloseAppenders(DateTime expireTime)
+         {
++            lock(this)
+             for (int i = 0; i < this.appenders.Length; ++i)
+             {
+                 if (this.appenders[i] == null)","lock(this) is a bad practise, since you lock the entire instance. cosider: var appenderCache = xxxx. lock(appenderCache) { Thread.Sleep(TimeSpan.FromHours(5)); } while inside AppenderCache instance lock(this) { is blocked 5 hours. } Its always better to make a class private lock objects."
+5614,"@@ -135,7 +135,10 @@ func WithClientInfo(serviceName string, procedures []transport.Procedure, transp
+ 		&ClientInfo{
+ 			clientDispatcher.ClientConfig(serviceName),
+ 			grpcClientConn,
+-			grpcheader.NewContextWrapper().WithCaller(serviceName + ""-client"").WithService(serviceName),
++			grpcheader.NewContextWrapper().
++				WithCaller(serviceName + ""-client"").
++				WithService(serviceName).
++				WithEncoding(""proto""),
+ 		},
+ 	)
+ }",should we use the constant above?
+5615,"@@ -6979,8 +6979,8 @@ os_seek(file_t f, int64 offset, int origin)
+     case OS_SEEK_END:
+         {
+             uint64 file_size = 0;
+-            bool res = os_get_file_size_by_handle(f, &file_size);
+-            ASSERT(res && ""bad file handle?""); /* shouldn't fail */
++            bool result = os_get_file_size_by_handle(f, &file_size);
++            ASSERT(result && ""bad file handle?""); /* shouldn't fail */
+             abs_offset += file_size;
+         }
+         break;",I think something like `size_res` would be more descriptive.
+5616,"@@ -96,9 +96,9 @@ module Bolt
+       @target = target
+       @value = {}
+       @action = 'apply'
+-      value['report'] = report if report
+-      value['_error'] = error if error
+-      value['_output'] = metrics_message if metrics_message
++      @value['report'] = report if report
++      @value['_error'] = error if error
++      @value['_output'] = metrics_message if metrics_message
+     end
+
+     def event_metrics",Oh lol so this was...really more of a bug?
+5617,"@@ -7,11 +7,11 @@ using System.Threading.Tasks;
+
+ namespace Microsoft.Rest
+ {
+-    public class PlatformTaskEx
++    [System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Naming"",
++        ""CA1711:IdentifiersShouldNotHaveIncorrectSuffix"",
++        Justification=""We think with Ex is better than using 2"")]
++    public static class PlatformTaskEx
+     {
+-        //Per FxCop performance rule to prevent the compiler from generating a default constructor.
+-        private PlatformTaskEx() { }
+-
+         public static Task FromResult(object result)
+         {
+ #if NET45","Well, it is providing a platform neutral way of calling Task or TaskEx. We could just call it PlatformTask."
+5618,"@@ -89,7 +89,7 @@ struct wlr_xwayland *wlr_xwayland_create(struct wl_display *wl_display,
+ 	};
+ 	xwayland->server = wlr_xwayland_server_create(wl_display, &options);
+ 	if (xwayland->server == NULL) {
+-		free(xwayland->server);
++		free(xwayland);
+ 		return NULL;
+ 	}
+ ",Typo: this should free `xwayland` instead
+5619,"@@ -19,9 +19,9 @@ package pingpong
+
+ import (
+ 	""bytes""
+-	""crypto/rand""
+ 	""encoding/hex""
+ 	""math""
++	""math/rand""
+ 	""strings""
+ 	""sync""
+ 	""sync/atomic""","Is it ok to use ""math/rand"" instead of ""crypto/rand"" here? Do we need to protect this ID somehow?"
+5620,"@@ -2,7 +2,7 @@ package nats_dialog
+
+ import (
+ 	""fmt""
+-	""github.com/mgutz/logxi/v1""
++	log ""github.com/cihub/seelog""
+ 	""github.com/mysterium/node/communication""
+ 	""github.com/mysterium/node/communication/nats""
+ 	""github.com/mysterium/node/communication/nats_discovery""",Why did we have `logxi` in the first place? Maybe it makes sense to remove it from `glide.lock? It will safe us in the future from using logger which is not working.
+5621,"@@ -269,9 +269,17 @@ public class DataCitation {
+             out.write(title);
+             out.write(""},\r\n"");
+         }
++        if(getUNF() != null){
++            out.write(""UNF = {"");
++            out.write(UNF);
++            out.write(""},\r\n"");
++        }
+         out.write(""year = {"");
+         out.write(year);
+         out.write(""},\r\n"");
++        out.write(""version = {"");
++        out.write(version);
++        out.write(""},\r\n"");
+         out.write(""doi = {"");
+         out.write(persistentId.getAuthority());
+         out.write(""/"");",Is there a reason to use `getUNF()` and `UNF` in the same block?
+5622,"@@ -198,7 +198,7 @@ func TestParse(t *testing.T) {
+ 		},
+ 		{
+ 			name: ""regex match operators"",
+-			raw:  `""a"" =~ /.*/ and ""b"" !~ /c/`,
++			raw:  `""a"" =~ /.*/ and ""b"" !~ /c$/`,
+ 			want: &ast.Program{
+ 				Body: []ast.Statement{
+ 					&ast.ExpressionStatement{",Again this seems odd that megacheck cares
+5623,"@@ -49,6 +49,9 @@ module Bolt
+       @sudo_password = transport_conf[:sudo_password]
+       @run_as = transport_conf[:run_as]
+       @tmpdir = transport_conf[:tmpdir]
++      @service_url = transport_conf[:service_url]
++      @token_file = transport_conf[:token_file]
++      @environment = transport_conf[:environment]
+
+       @logger = init_logger(config[:log_destination], config[:log_level])
+       @transport_logger = init_logger(config[:log_destination], Logger::WARN)",I assume this will resolve to nil if this isn't in the config?
+5624,"@@ -17,6 +17,18 @@ namespace Datadog.Trace.Configuration
+         /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
+         /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
+         public static IDictionary<string, string> ParseCustomKeyValues(string data)
++        {
++            return ParseCustomKeyValues(data, allowOptionalMappings: false);
++        }
++
++        /// <summary>
++        /// Returns a <see cref=""IDictionary{TKey, TValue}""/> from parsing
++        /// <paramref name=""data""/>.
++        /// </summary>
++        /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
++        /// <param name=""allowOptionalMappings"">Determines whether to create dictionary entries when the input has no value mapping</param>
++        /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
++        public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)
+         {
+             var dictionary = new ConcurrentDictionary<string, string>();
+ ","I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)"
+5625,"@@ -76,12 +76,13 @@ class YOLOV3Neck(BaseModule):
+
+     Args:
+         num_scales (int): The number of scales / stages.
+-        in_channels (int): The number of input channels.
+-        out_channels (int): The number of output channels.
+-        conv_cfg (dict): Config dict for convolution layer. Default: None.
+-        norm_cfg (dict): Dictionary to construct and config norm layer.
+-            Default: dict(type='BN', requires_grad=True)
+-        act_cfg (dict): Config dict for activation layer.
++        in_channels (List[int]): The number of input channels  per scale.
++        out_channels (List[int]): The number of output channels  per scale.
++        conv_cfg (dict, optional): Config dict for convolution layer.
++            Default: None.
++        norm_cfg (dict, optional): Dictionary to construct and config norm
++            layer. Default: dict(type='BN', requires_grad=True)
++        act_cfg (dict, optional): Config dict for activation layer.
+             Default: dict(type='LeakyReLU', negative_slope=0.1).
+         init_cfg (dict or list[dict], optional): Initialization config dict.
+             Default: None",` per scale.` -> ` per scale.` need to clean the unnecessary blank space
+5626,"@@ -79,7 +79,8 @@ public class class194 {
+ 		descriptor = ""(IS)Ljava/lang/String;"",
+ 		garbageValue = ""4096""
+ 	)
+-	static final String method3712(int var0) {
++	@Export(""inventoryQuantityFormat"")
++	static final String inventoryQuantityFormat(int var0) {
+ 		if (var0 < 100000) { // L: 421
+ 			return ""<col=ffff00>"" + var0 + ""</col>"";
+ 		} else {",there's no import for Export
+5627,"@@ -51,7 +51,7 @@ func (e *endpoints) ListenAndServe(ctx context.Context) error {
+ 	tcpServer := e.createTCPServer(ctx)
+ 	udsServer := e.createUDSServer(ctx)
+
+-	e.registerNodeAPI(tcpServer)
++	e.registerNodeAPI(tcpServer, udsServer)
+ 	e.registerRegistrationAPI(tcpServer, udsServer)
+
+ 	err := util.RunTasks(ctx,",i don't think we want/need to make the node API available over UDS
+5628,"@@ -113,7 +113,7 @@ class LegalConditionsFacade
+         $articleId = $this->setting->getForDomain($settingKey, $domainId);
+
+         if ($articleId !== null) {
+-            return $this->articleFacade->getById($articleId);
++            return $this->articleFacade->findById($articleId);
+         }
+
+         return null;",How about to skip if and returning null and return a result of `ArticleFacade::findById` directly?
+5629,"@@ -180,6 +180,11 @@ class CoreDocumentArray extends CoreMongooseArray {
+     return arr;
+   }
+
++  map() {
++    const arr = [].concat(Array.prototype.map.apply(this,arguments));
++    return arr;
++  }
++
+   /**
+    * Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
+    *","I think this change is currently unnecessary. I like the idea of `map()`, `filter()`, etc. returning vanilla JavaScript arrays rather than mongoose arrays, but I think that's a bit too heavy of a change for a patch release. I think that all we need for this release is the `if (!parent || parent.$__.populated == null) return;` change."
+5630,"@@ -10,6 +10,11 @@ module Travis
+     BUILD_DIR = File.join(HOME_DIR, 'build')
+
+     class << self
++      def version
++        @version ||= `git rev-parse HEAD 2>/dev/null || \\
++                        echo ""${SOURCE_VERSION:-fafafaf}""`.strip
++      end
++
+       def self.register(key)
+         Travis.services.add(key, self)
+       end","how about ""unknown"" instead of ""fafafaf""?"
+5631,"@@ -0,0 +1,14 @@
++package api2
++
++import (
++	""context""
++
++	""github.com/filecoin-project/go-filecoin/address""
++	""github.com/filecoin-project/go-filecoin/exec""
++)
++
++// Actor is the actor-related Filecoin plumbing interface.
++type Actor interface {
++	// ActorGetSignature returns the signature of the given actor's given method.
++	ActorGetSignature(ctx context.Context, actorAddr address.Address, method string) (_ *exec.FunctionSignature, err error)
++}",nit: do we gain anything from naming the output error `err` in this definition?
+5632,"@@ -188,6 +188,11 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
+                 stopInterval();
+             });
+
++            // Blur foreign element to prevent starting of ""nested"" slideshow
++            if (document.activeElement && !dlg.contains(document.activeElement)) {
++                document.activeElement.blur();
++            }
++
+             inputManager.on(window, onInputCommand);
+             document.addEventListener((window.PointerEvent ? 'pointermove' : 'mousemove'), onPointerMove);
+ ",This can happen with any dialog. Maybe the best place to add this change would be the dialog component instead.
+5633,"@@ -46,6 +46,10 @@ func NewTestEnvironment(ctx context.Context, t *testing.T, fastenvOpts fast.Envi
+ 	env, err := fast.NewEnvironmentMemoryGenesis(big.NewInt(1000000), dir, types.TestProofsMode)
+ 	require.NoError(err)
+
++	defer func() {
++		dumpEnvOutputOnFail(t, env.Processes())
++	}()
++
+ 	// Setup options for nodes.
+ 	options := make(map[string]string)
+ 	options[localplugin.AttrLogJSON] = ""1""                                        // Enable JSON logs","Should this be `TearDown` since it now calls this method? Something I would like to see is, on test failure don't teardown completely instead leave the FAST repo in place with the stderr and stdout files and direct the user to that location. What do you think?"
+5634,"@@ -190,6 +190,8 @@ def getModule(metricSpec):
+     return MetricMAPE(metricSpec)
+   elif metricName == 'multi':
+     return MetricMulti(metricSpec)
++  elif metricName == 'negLL':
++    return MetricNegLogLikelihood(metricSpec)
+   else:
+     raise Exception(""Unsupported metric type: %s"" % metricName)
+ ","There's not particular reason to use a short name. Can we use a more descriptive name for the metric? Perhaps ""negativeLogLikelihood""?"
+5635,"@@ -745,7 +745,10 @@ static void skipArgumentList (tokenInfo *const token, boolean include_newlines,
+ 		while (nest_level > 0 && ! isType (token, TOKEN_EOF))
+ 		{
+ 			readTokenFull (token, FALSE, repr);
+-			if (isType (token, TOKEN_OPEN_PAREN))
++			if (isType (token, TOKEN_KEYWORD) && token->keyword == KEYWORD_function &&
++			    repr == NULL)
++				parseFunction (token);
++			else if (isType (token, TOKEN_OPEN_PAREN))
+ 				nest_level++;
+ 			else if (isType (token, TOKEN_CLOSE_PAREN))
+ 				nest_level--;","not handling in case of `repr` makes the behavior probably a little too unpredictable. Is there a reason not to, apart missing stuff in the `repr`? Does it lead to some problem?"
+5636,"@@ -93,12 +93,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+                             BadHttpRequestException.Throw(RequestRejectionReason.UnexpectedEndOfRequestContent);
+                         }
+
+-                        awaitable = _context.Input.ReadAsync();
+                     }
+                     finally
+                     {
+                         _context.Input.AdvanceTo(consumed, examined);
+                     }
++
++                    awaitable = _context.Input.ReadAsync();
+                 }
+             }
+             catch (Exception ex)",Remove the finally?
+5637,"@@ -378,7 +378,7 @@ reboot_system()
+  *   and then checking error codes; but the problem there is that C:\\
+  *   returns PATH_NOT_FOUND regardless. */
+ bool
+-file_exists(const TCHAR *fn)
++file_exists(const WCHAR *fn)
+ {
+ #ifdef WINDOWS
+     WIN32_FIND_DATA fd;",Build on AArch64 fails because WCHAR is not defined.
+5638,"@@ -20,6 +20,7 @@ import (
+
+ func TestRDWS_Template(t *testing.T) {
+ 	const (
++		envName               = ""test""
+ 		manifestFileName      = ""rdws-manifest.yml""
+ 		stackTemplateFileName = ""rdws.stack.yml""
+ 	)",Do we use this const?
+5639,"@@ -139,3 +139,9 @@ func SetCertificateRequestFailureTime(p metav1.Time) CertificateRequestModifier
+ 		cr.Status.FailureTime = &p
+ 	}
+ }
++
++func SetAnnotations(annotations map[string]string) CertificateRequestModifier {
++	return func(cr *v1alpha2.CertificateRequest) {
++		cr.SetAnnotations(annotations)
++	}
++}",I think this may need to be `SetCertificateRequestAnnotations` as it returns a `CertificateRequestModifier`
+5640,"@@ -234,6 +234,7 @@ class User < ActiveRecord::Base
+   #
+   # Returns UserIdentifier
+   def identifier_for(scheme)
++    scheme = scheme.instance_of?(IdentifierScheme) ? scheme.name : scheme
+     identifiers.by_scheme_name(scheme, ""User"").first
+   end
+ ",it would likely be better to do this in the Identifier.by_scheme_name method itself.
+5641,"@@ -129,6 +129,10 @@ class DatasetContext extends RawDKANEntityContext {
+     }
+
+     switch ($orderby) {
++      case 'Date created':
++        $orderby = 'created';
++        break;
++
+       case 'Date changed':
+         $orderby = 'changed';
+         break;","@janette looking at this test code, I'm pretty sure that it's going to give a false positive. Where is it actually checking the contents of the first four datasets against expected values? All the assertion at the end of the test seems to check is that at least four datasets exist."
+5642,"@@ -68,6 +68,14 @@ module.exports = function (defaults) {
+             optional: ['es6.spec.symbols'],
+             includePolyfill: true
+         },
++        'ember-service-worker': {
++            rootUrl: '/ghost/'
++        },
++        'esw-cache-fallback': {
++            patterns: [
++                '/ghost/api/(.+)'
++            ],
++        },
+         outputPaths: {
+             app: {
+                 js: assetLocation('ghost.js')",Would this break things if Ghost is run in a subdirectory or no?
+5643,"@@ -24,7 +24,11 @@ class ProposalUpdateRecorder
+   end
+
+   def update_comment_format(key)
+-    ""#{bullet}*#{property_name(key)}* was changed "" + former_value(key) + ""to #{new_value(key)}""
++    if key !~ /id/
++      ""#{bullet}*#{property_name(key)}* was changed "" + former_value(key) + ""to #{new_value(key)}""
++    else
++      ""#{bullet}*#{association_name(key)}* was changed "" + former_association_value(key) + ""to #{new_association_value(key)}""
++    end
+   end
+
+   def bullet",maybe switch the order in order to make this a positive assertion instead of a negative one? i.e. `if key =~ /id/` first.
+5644,"@@ -20,6 +20,7 @@ from selenium.common.exceptions import NoSuchFrameException
+ from selenium.common.exceptions import StaleElementReferenceException
+ from selenium.common.exceptions import WebDriverException
+ from selenium.common.exceptions import NoAlertPresentException
++from selenium.common.exceptions import ElementNotVisibleException
+
+ """"""
+  * Canned ""Expected Conditions"" which are generally useful within webdriver",Is this an oversight for some code in the body?
+5645,"@@ -922,6 +922,8 @@ public class AddProductActivity extends AppCompatActivity {
+                         toast.show();
+                         mOfflineSavedProductDao.deleteInTx(mOfflineSavedProductDao.queryBuilder().where(OfflineSavedProductDao.Properties.Barcode.eq(code)).list());
+                         Intent intent = new Intent();
++                        state.setProduct(mProduct);
++                        intent.putExtra(""state"", state);
+                         intent.putExtra(""uploadedToServer"", true);
+                         setResult(RESULT_OK, intent);
+                         finish();",Reason for adding this? I couldn't find where you are retrieving it back.
+5646,"@@ -62,6 +62,10 @@ static void setup_globals(mrb_state *mrb)
+
+     h2o_mruby_eval_expr(mrb, ""$LOAD_PATH << \""#{$H2O_ROOT}/share/h2o/mruby\"""");
+     h2o_mruby_assert(mrb);
++
++    /* require core modules and include built-in libraries */
++    h2o_mruby_eval_expr(mrb, ""require \""preloads.rb\"""");
++    h2o_mruby_assert(mrb);
+ }
+
+ mrb_value h2o_mruby_to_str(mrb_state *mrb, mrb_value v)","Can we expect adequate information emitted to the log in case either requiring preloads.rb or doing the requires in preloads.rb fails? If the answer is yes, I think we can merge this PR right away."
+5647,"@@ -1,2 +1,3 @@
+-class PagesController < ApplicationController
+-end
++class PagesController < HighVoltage::PagesController
++  layout false
++end","How about a `app/views/layouts/pages.html.erb` layout that contains the HTML head, body, wrappers and yield's the `new-topics` template into it? I think we might be able to delete the `app/controllers/pages_controller.rb` file at that point."
+5648,"@@ -2218,7 +2218,9 @@ Document.prototype.isSelected = function isSelected(path) {
+   if (this.$__.selected == null) {
+     return true;
+   }
+-
++  if (!path) {
++    return false;
++  }
+   if (path === '_id') {
+     return this.$__.selected._id !== 0;
+   }","This is a coarse solution. This check is helpful, but you should also add a check in `$__version()` to avoid calling `isSelected()` if `key === false`"
+5649,"@@ -37,8 +37,10 @@ type Planner interface {
+ }
+
+ type Input struct {
+-	// Readonly deployment model.
+-	Deployment                     *model.Deployment
++	ApplicationID                  string
++	ApplicationName                string
++	GitPath                        model.ApplicationGitPath
++	Trigger                        model.DeploymentTrigger
+ 	MostRecentSuccessfulCommitHash string
+ 	PipedConfig                    *config.PipedSpec
+ 	TargetDSP                      deploysource.Provider",Passing only needed data to make it can be reused by `planpreview` package where there is no deployment data.
+5650,"@@ -71,6 +71,9 @@ type Options struct {
+ 	TLSCaCert      string        `json:""-""`
+ 	TLSConfig      *tls.Config   `json:""-""`
+ 	WriteDeadline  time.Duration `json:""-""`
++
++	CustomClientAuth Auth `json:""-""`
++	CustomRouterAuth Auth `json:""-""`
+ }
+
+ // Clone performs a deep copy of the Options struct, returning a new clone",Could we rename those to `CustomClientAuthentication` (same for Router) to remove ambiguity between Authentication and Authorization (permissions)?
+5651,"@@ -1,11 +1,15 @@
+ using System;
++using MvvmCross.Core.Views;
+ using MvvmCross.Forms.Platform;
+
+ namespace MvvmCross.Forms.Views
+ {
+-    public interface IMvxFormsViewPresenter
++    public interface IMvxFormsViewPresenter : IMvxAttributeViewPresenter
+     {
+         MvxFormsApplication FormsApplication { get; set; }
+         IMvxFormsPagePresenter FormsPagePresenter { get; set; }
++
++        bool ClosePlatformViews();
++        bool ShowPlatformHost(Type hostViewModel = null);
+     }
+ }","Is the name ""IMvxFormsViewPresenter"" too close to ""IMvxFormsPagePresenter""? Perhaps something like ""IMvxFormsNativeViewPresenter"" or ""IMvxFormsPlatformViewPresenter"" or inline with Forms naming ""IMvxFormsOnPlatformViewPresenter"""
+5652,"@@ -28,8 +28,8 @@ export function h(nodeName, attributes) {
+ 		if ((child = stack.pop()) instanceof Array) {
+ 			for (i=child.length; i--; ) stack.push(child[i]);
+ 		}
+-		else if (child!=null && child!==false) {
+-			if (typeof child=='number' || child===true) child = String(child);
++		else if (child!=null && child!==true && child!==false) {
++			if (typeof child=='number') child = String(child);
+ 			simple = typeof child=='string';
+ 			if (simple && lastSimple) {
+ 				children[children.length-1] += child;",`typeof child != 'boolean'` maybe?
+5653,"@@ -220,7 +220,7 @@ public class ErrorHandler {
+
+   private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
+
+-    if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
++    if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
+       // Not enough information for us to try to rebuild an error.
+       return null;
+     }",Why && changed to || ?
+5654,"@@ -26,6 +26,11 @@ func init() {
+ 		panic(err)
+ 	}
+
++	InitAddress, err = NewIDAddress(4)
++	if err != nil {
++		panic(err)
++	}
++
+ 	StorageMarketAddress, err = NewIDAddress(2)
+ 	if err != nil {
+ 		panic(err)",nit: not a big deal right now but spec assigns ID 0 to InitAddress
+5655,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
+5656,"@@ -361,6 +361,11 @@ class WebView(QWebView):
+         message.info(self.win_id, ""Zoom level: {}%"".format(perc))
+         self._default_zoom_changed = True
+
++    def setZoomFactor(self, fact):
++        self._zoom.fuzzyval = int(fact * 100)
++        super().setZoomFactor(fact)
++        self._default_zoom_changed = True
++
+     def zoom(self, offset):
+         """"""Increase/Decrease the zoom level.
+ ","There are various places where `setZoomFactor` is used but `fuzzyval` isn't set: - `__init__` and `on_config_changed` (should be okay as `init_neighborlist` gets called which essentially does the same) - `zoom` (calls `zoom_perc` with `fuzzyval=False`), which is used by `:zoom-in` and `:zoom-out`. Are you sure this won't break those calls? (Yes, I know there should be tests for this - I'm working on that.) Other existing places probably should get simplified."
+5657,"@@ -889,12 +889,12 @@ namespace pwiz.Skyline.Model
+             string pathForLibraryFiles, // In case we translate libraries etc
+             ConvertToSmallMoleculesMode mode = ConvertToSmallMoleculesMode.formulas,
+             ConvertToSmallMoleculesChargesMode invertChargesMode = ConvertToSmallMoleculesChargesMode.none,
+-            bool ignoreDecoys=false)
++            bool ignoreDecoys=false, bool addAnnotations = true)
+         {
+             if (mode == ConvertToSmallMoleculesMode.none)
+                 return document;
+             var newdoc = new SrmDocument(document.Settings);
+-            var note = new Annotations(TestingConvertedFromProteomic, null, 1); // Mark this as a testing node so we don't sort it
++            var note = addAnnotations ? new Annotations(TestingConvertedFromProteomic, null, 1) : Annotations.EMPTY; // Optionally mark this as a testing node so we don't sort it
+             var precursorMap = new Dictionary<LibKey, LibKey>(); // Map int,modSeq to adduct,molecule
+
+             var invertCharges = invertChargesMode == ConvertToSmallMoleculesChargesMode.invert;",Is there a benefit to keeping this in RefinementSettings? Or could we move it into its own class in TestUtil?
+5658,"@@ -6,14 +6,10 @@ import (
+
+ // Query represents an active query.
+ type Query interface {
+-	// Spec returns the spec used to execute this query.
+-	// Spec must not be modified.
+-	Spec() *Spec
+-
+-	// Ready returns a channel that will deliver the query results.
++	// Results returns a channel that will deliver the query results.
+ 	// Its possible that the channel is closed before any results arrive,
+ 	// in which case the query should be inspected for an error using Err().
+-	Ready() <-chan map[string]Result
++	Results() <-chan Result
+
+ 	// Done must always be called to free resources. It is safe to call Done
+ 	// multiple times.","I would have expected the Ready method to need to change to be a `<-chan Result` instead of a `<-chan map[string]Result`. The difference being that now the Ready channel can produce more than one set of results. In fact the name Ready is inaccurate now since its not about the query being ready but just a mechanism to deliver results. If this should be a follow up PR that is fine, lets create an issue for it."
+5659,"@@ -36,7 +36,7 @@ public interface ProjectLoader {
+    * @return
+    * @throws ProjectManagerException
+    */
+-  public List<Project> fetchAllActiveProjects() throws ProjectManagerException;
++  List<Project> fetchAllActiveProjects() throws ProjectManagerException;
+
+   /**
+    * Loads whole project, including permissions, by the project id.",why? what if we want to access those methods outside of azkaban-common?
+5660,"@@ -45,9 +45,9 @@ namespace Nethermind.Merge.Plugin.Test
+     {
+         private async Task<MergeTestBlockchain> CreateBlockChain() => await new MergeTestBlockchain(new ManualTimestamper()).Build(new SingleReleaseSpecProvider(Berlin.Instance, 1));
+
+-        private IConsensusRpcModule CreateConsensusModule(MergeTestBlockchain chain)
++        private IEngineRpcModule CreateConsensusModule(MergeTestBlockchain chain)
+         {
+-            return new ConsensusRpcModule(
++            return new EngineRpcModule(
+                 new AssembleBlockHandler(chain.BlockTree, chain.BlockProductionTrigger, chain.Timestamper, chain.LogManager),
+                 new NewBlockHandler(chain.BlockTree, chain.BlockPreprocessorStep, chain.BlockchainProcessor, chain.State, new InitConfig(), chain.LogManager),
+                 new SetHeadBlockHandler(chain.BlockTree, chain.State, chain.LogManager),",Rename file too
+5661,"@@ -27,7 +27,11 @@ func Unmarshal(r *request.Request) {
+ 		decoder := xml.NewDecoder(r.HTTPResponse.Body)
+ 		err := xmlutil.UnmarshalXML(r.Data, decoder, """")
+ 		if err != nil {
+-			r.Error = awserr.New(""SerializationError"", ""failed decoding EC2 Query response"", err)
++			r.Error = awserr.NewRequestFailure(
++				awserr.New(""SerializationError"", ""failed decoding EC2 Query response"", err),
++				r.HTTPResponse.StatusCode,
++				"""",
++			)
+ 			return
+ 		}
+ 	}","Need to populate the `RequestID` field for these errors. This can be obtained from r.RequestID i think, but need to make sure. The `r.RequestID` should of been populated from the `UnmarshalMeta` handler list."
+5662,"@@ -35,8 +35,8 @@ public class LongRunningConfigTest {
+   private static final String GAPIC_CONFIG_METADATA_TYPE = ""HeaderType"";
+   private static final String ANNOTATIONS_RETURN_TYPE_NAME = ""BookType"";
+   private static final String ANNOTATIONS_METADATA_TYPE = ""FooterType"";
+-  private static final boolean TEST_IMPLEMENTS_DELETE = false;
+-  private static final boolean TEST_IMPLEMENTS_CANCEL = false;
++  private static boolean TEST_IMPLEMENTS_DELETE = false;
++  private static boolean TEST_IMPLEMENTS_CANCEL = false;
+   private static int TEST_INITIAL_POLL_DELAY = 5;
+   private static double TEST_POLL_DELAY_MULTIPLIER = 10;
+   private static long TEST_MAX_POLL_DELAY = 12500;",Why is the `final` being removed here?
+5663,"@@ -1,13 +1,14 @@
+ //
+ //  Bismillah ar-Rahmaan ar-Raheem
+ //
+-//  Easylogging++ v9.95.0
++//  Easylogging++ v9.96.4
+ //  Cross-platform logging library for C++ applications
+ //
+-//  Copyright (c) 2017 muflihun.com
++//  Copyright (c) 2012-2018 Muflihun Labs
++//  Copyright (c) 2012-2018 @abumusamq
+ //
+ //  This library is released under the MIT Licence.
+-//  http://labs.muflihun.com/easyloggingpp/licence.php
++//  https://github.com/muflihun/easyloggingpp/blob/master/LICENSE
+ //
+ //  https://github.com/muflihun/easyloggingpp
+ //  https://muflihun.github.io/easyloggingpp",Maybe let's take this opportunity to change easylogging to a git submodule?
+5664,"@@ -30,6 +30,9 @@ func extractFrontMatter(input string) (map[string]interface{}, string, error) {
+ 	}
+ 	firstLine := input[firstLineStart:firstLineEnd]
+
++	// ensure residue windows newline is removed
++	firstLine = strings.Trim(firstLine, ""\r"")
++
+ 	// see what kind of front matter there is, if any
+ 	var closingFence string
+ 	var fmParser func([]byte) (map[string]interface{}, error)",Should we just be generous and elide all extra whitespace? `strings.TrimSpace`
+5665,"@@ -900,18 +900,6 @@ public class SalesforceSDKManager {
+         return context.getString(getSalesforceR().stringAccountType());
+     }
+
+-    /**
+-     * Indicates whether the app is running on a tablet.
+-     *
+-     * @return True if the application is running on a tablet.
+-     */
+-    public static boolean isTablet() {
+-        if ((INSTANCE.context.getResources().getConfiguration().screenLayout & Configuration.SCREENLAYOUT_SIZE_MASK) == Configuration.SCREENLAYOUT_SIZE_XLARGE) {
+-            return true;
+-        }
+-        return false;
+-    }
+-
+     @Override
+     public String toString() {
+         final StringBuilder sb = new StringBuilder();","This is an inaccurate API that has outlived it's purpose. We can't make the determination of phone (vs) tablet, with a 7"" screen in the mix. Also, with the advent of fragments, this API means very little now. It's not being used anywhere, since we switched to `ActionBar`."
+5666,"@@ -230,7 +230,7 @@ public class GridLauncherV3 {
+     }
+
+     configureLogging(common.getLog(), common.getDebug());
+-    log.info(version());
++    log.finest(version());
+     return true;
+   }
+ ",This change means that users can't easily see which version of the selenium server they're using. This is `info` level information.
+5667,"@@ -455,8 +455,8 @@ class AuthTestCase(QuiltTestCase):
+     def testCodeExpires(self):
+         self.code_immediate_expire_mock = mock.patch('quilt_server.auth.CODE_TTL_DEFAULT',
+                                                      {'minutes': 0})
+-        self.code_immediate_expire_mock.start()
+         token = self.getToken()
++        self.code_immediate_expire_mock.start()
+         code_request = self.app.get(
+             '/api/code',
+             headers={","You should just use `with patch(...):`, so it unpatches it automatically. Also, much simpler."
+5668,"@@ -28,14 +28,15 @@ namespace MvvmCross.Navigation
+         private IMvxViewDispatcher _viewDispatcher;
+         public IMvxViewDispatcher ViewDispatcher
+         {
+-            get => _viewDispatcher ?? (IMvxViewDispatcher)MvxMainThreadDispatcher.Instance;
++            get => _viewDispatcher ?? (_viewDispatcher = Mvx.Resolve<IMvxViewDispatcher>());
+             set => _viewDispatcher = value;
+         }
+
+         private IMvxViewsContainer _viewsContainer;
+         protected IMvxViewsContainer ViewsContainer
+         {
+-            get {
++            get
++            {
+                 if (_viewsContainer == null)
+                     _viewsContainer = Mvx.Resolve<IMvxViewsContainer>();
+                 return _viewsContainer;",This didn't use to work for me. Are you sure that returns the correct instance from startup?
+5669,"@@ -65,6 +65,14 @@ public final class MethodCallExpr extends Expression implements NodeWithTypeArgu
+         this(null, scope, new NodeList<>(), new SimpleName(name), new NodeList<>());
+     }
+
++    public MethodCallExpr(final Expression scope, final SimpleName name) {
++        this(null, scope, new NodeList<>(), name, new NodeList<>());
++    }
++
++    public MethodCallExpr(final Expression scope, final String name, final NodeList<Expression> arguments) {
++        this(null, scope, new NodeList<>(), new SimpleName(name), arguments);
++    }
++
+     public MethodCallExpr(final Expression scope, final SimpleName name, final NodeList<Expression> arguments) {
+         this(null, scope, new NodeList<>(), name, arguments);
+     }","Looks good. Eventually we could remove some of these constructors, but for now adding these two seems the way to go"
+5670,"@@ -180,7 +180,7 @@ def parse_bwids(bwolist):
+     return list(ast.literal_eval(bwolist))
+
+
+-def get_holdingpen_objects(ptags=[]):
++def get_holdingpen_objects(ptags=[""Need action""]):
+     """"""Get BibWorkflowObject's for display in Holding Pen.
+
+     Uses DataTable naming for filtering/sorting. Work in progress.",@jalavik should be have somewhere enum/list/registry of possible tags?
+5671,"@@ -155,6 +155,7 @@ class SecurityCenterClient(object):
+                     finding.get('source_properties').get('violation_data'))
+                 raise api_errors.ApiExecutionError(violation_data, e)
+
++    # pylint: disable=logging-too-many-args
+     def list_findings(self, source_id):
+         """"""Lists all the findings in CSCC.
+ ",why is this pylint disable needed?
+5672,"@@ -44,6 +44,7 @@ def GenerateConfig(context):
+
+     FORSETI_HOME = '$USER_HOME/forseti-security'
+     POLICY_LIBRARY_HOME = '$USER_HOME/policy-library'
++    POLICY_LIBRARY_SYNC_ENABLED = 'false'
+
+     DOWNLOAD_FORSETI = (
+         ""git clone {src_path}.git"".format(",The new sync feature is only being supported from within Terraform. Installations using the deprecated method will have this feature disabled.
+5673,"@@ -79,3 +79,7 @@ class DropBlock(nn.Module):
+         factor = (1.0 if self.iter_cnt > self.warmup_iters else self.iter_cnt /
+                   self.warmup_iters)
+         return gamma * factor
++
++    def extra_repr(self):
++        return (f'drop_prob={self.drop_prob}, block_size={self.block_size}, '
++                f'warmup_iters={self.warmup_iters}')","This type of return (f'xxx') is not recommended, it is recommended to return 'xxx'"
+5674,"@@ -2836,8 +2836,11 @@ client_process_bb(dcontext_t *dcontext, build_bb_t *bb)
+ #    ifdef X86
+         if (!d_r_is_avx512_code_in_use()) {
+             if (ZMM_ENABLED()) {
+-                if (instr_may_write_zmm_register(inst))
++                if (instr_may_write_zmm_register(inst)) {
++                    LOG(THREAD, LOG_INTERP, 3, ""Detected AVX-512 code in use\n"");
+                     d_r_set_avx512_code_in_use(true);
++                    proc_set_num_simd_saved(MCXT_NUM_SIMD_SLOTS);
++                }
+             }
+         }
+ #    endif",I would make this level 1 or 2.
+5675,"@@ -0,0 +1,17 @@
++require 'beaker/hypervisor/vagrant'
++
++class Beaker::VagrantFusion < Beaker::Vagrant
++  def provision(provider = 'vmware_fusion')
++    # By default vmware_fusion creates a .vagrant directory relative to the
++    # Vagrantfile path. That means beaker tries to scp the VM to itself unless
++    # we move the VM files elsewhere.
++    ENV['VAGRANT_VMWARE_CLONE_DIRECTORY'] = '~/.vagrant/vmware_fusion'
++    super
++  end
++
++  def self.provider_vfile_section(host, options)
++    ""    v.vm.provider :vmware_fusion do |v|\n"" +
++    ""      v.vmx['memsize'] = '#{options['vagrant_memsize'] ||= '1024'}'\n"" +
++    ""    end\n""
++  end
++end",Is that path in a variable anyway? Not a big fan of hard coding it here.
+5676,"@@ -16,14 +16,18 @@ limitations under the License.
+ package controllers
+
+ import (
++	""bytes""
+ 	""context""
++	""errors""
++	""strings""
++	""text/template""
+
+ 	""github.com/sirupsen/logrus""
+ 	federation ""github.com/spiffe/spire/support/k8s/k8s-workload-registrar/federation""
+ 	spiffeidv1beta1 ""github.com/spiffe/spire/support/k8s/k8s-workload-registrar/mode-crd/api/spiffeid/v1beta1""
+
+ 	corev1 ""k8s.io/api/core/v1""
+-	""k8s.io/apimachinery/pkg/api/errors""
++	k8serrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/types""",nit: Move `IdentityTemplateLabel` to be under `IdentityTemplate` to match the struct in config_crd.go
+5677,"@@ -1,8 +1,13 @@
+ class Analytics
+   include AnalyticsHelper
+
+-  SAMPLER = ""sampler""
+-  SUBSCRIBER = ""subscriber""
++  SAMPLER = ""sampler"".freeze
++  SUBSCRIBER = ""subscriber"".freeze
++  TRACKERS = {
++    ""Video"" => VideoTracker,
++    ""Exercise"" => ExerciseTracker,
++    ""Trail"" => TrailTracker,
++  }.freeze
+
+   class_attribute :backend
+   self.backend = AnalyticsRuby","Not necessarily related to this PR, but don't you think having a centralized place for all interactions with analytics might make this into a very big class? Is that something that you don't worry about until it happens?"
+5678,"@@ -670,6 +670,13 @@ func (w *Workflow) runStep(ctx context.Context, s *Step) DError {
+ 	select {
+ 	case err := <-e:
+ 		return err
++	case <-ctx.Done():
++		if err := ctx.Err(); err == context.DeadlineExceeded {
++			return s.getTimeoutError()
++		} else if err != nil {
++			return Errf(""step %q error: %s"", s.name, err)
++		}
++		return nil
+ 	case <-timeout:
+ 		return s.getTimeoutError()
+ 	}","it seems that my terminal is dead when I press ctrl+c during running daisy cli today, is this PR fixing that?"
+5679,"@@ -403,7 +403,7 @@ func (nc *Config) Build(ctx context.Context) (*Node, error) {
+
+ 	// only the syncer gets the storage which is online connected
+ 	chainSyncer := chain.NewDefaultSyncer(&cstOffline, nodeConsensus, chainStore, fetcher)
+-	msgPool := core.NewMessagePool(chainStore, consensus.NewIngestionValidator(chainStore))
++	msgPool := core.NewMessagePool(chainStore, nc.Repo.Config().Mpool, consensus.NewIngestionValidator(chainStore))
+ 	outbox := core.NewMessageQueue()
+
+ 	// Set up libp2p pubsub","If we are going to add config to specify the maximum message pool size, we should probably also add a parameter for the maximum nonce gap and pass it into the `IngestionValidator`. This could be done in this PR or added as an issue."
+5680,"@@ -12,10 +12,8 @@
+  */
+ package org.camunda.bpm.container.impl.spi;
+
+-import java.util.ArrayList;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
++
+ import org.camunda.bpm.container.impl.ContainerIntegrationLogger;
+ import org.camunda.bpm.engine.impl.ProcessEngineLogger;
+ ",please inline imports
+5681,"@@ -113,7 +113,7 @@ type Config struct {
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;30""`
+ 	IptablesLockFilePath               string        `config:""file;/run/xtables.lock""`
+-	IptablesLockTimeoutSecs            time.Duration `config:""seconds;30""`
++	IptablesLockTimeoutSecs            time.Duration `config:""seconds;0""`
+ 	IptablesLockProbeIntervalMillis    time.Duration `config:""millis;50""`
+ 	IpsetsRefreshInterval              time.Duration `config:""seconds;10""`
+ 	MaxIpsetSize                       int           `config:""int;1048576;non-zero""`","Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?"
+5682,"@@ -313,7 +313,11 @@ class JoplinDatabase extends Database {
+
+ 		// currentVersionIndex < 0 if for the case where an old version of Joplin used with a newer
+ 		// version of the database, so that migration is not run in this case.
+-		if (currentVersionIndex < 0) throw new Error('Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.');
++		if (currentVersionIndex < 0) {
++			this.logger().error(`Cannot convert database from version ${fromVersion} to ${existingDatabaseVersions[existingDatabaseVersions.length-1]}`);
++			const p = require('../package.json');
++			throw new Error(`Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.\n${p.name} version: ${p.version}\nProfile version: ${fromVersion}\nExpected version: ${existingDatabaseVersions[existingDatabaseVersions.length-1]}`);
++		}
+
+ 		if (currentVersionIndex == existingDatabaseVersions.length - 1) return fromVersion;
+ ",Please use packageInfo here instead. As it is used in `app.js`.
+5683,"@@ -49,7 +49,10 @@ public class AnalysisResult {
+             // the analysis will fail and report the error on it's own since the checksum won't match
+         }
+
+-        return 0;
++        // we couldn't read the file, maybe the file doesn't exist
++        // in any case, we can't use the cache. Returning here the timestamp should make
++        // sure, we see that the file changed every time we analyze it.
++        return System.currentTimeMillis();
+     }
+
+     public long getFileChecksum() {","this seems unrelated to the rest of the PR, although related to the original report"
+5684,"@@ -11386,7 +11386,7 @@ NABoolean HbaseAccess::isHbaseFilterPredV2(Generator * generator, ItemExpr * ie,
+   }
+   //check if not an added column with default non null
+   if ((foundBinary || foundUnary)&& (NOT hbaseLookupPred)){
+-        if (colVID.isAddedColumnWithNonNullDefault()){
++        if (colVID.isColumnWithNonNullDefault()){
+             foundBinary=FALSE;
+             foundUnary=FALSE;
+         }",Would a check for added columns with non-null default be sufficient for aligned format?
+5685,"@@ -69,6 +69,7 @@ var (
+ 	hostname                    = flag.String(ovfimportparams.HostnameFlagKey, """", ""Specify the hostname of the instance to be created. The specified hostname must be RFC1035 compliant."")
+ 	machineImageStorageLocation = flag.String(ovfimportparams.MachineImageStorageLocationFlagKey, """", ""GCS bucket storage location of the machine image being imported (regional or multi-regional)"")
+ 	buildID                     = flag.String(""build-id"", """", ""Cloud Build ID override. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. For example, if running multiple imports in parallel in a single Cloud Build run, sharing build ID could cause premature temporary resource clean-up resulting in import failures."")
++	computeServiceAccount       = flag.String(""compute_service_account"", """", ""Compute service account to be used by importer. When empty, the Compute Engine default service account is used."")
+
+ 	nodeAffinityLabelsFlag flags.StringArrayFlag
+ 	currentExecutablePath  string","Is this PR implementing compute service account for OVF import as well? I thought it's only image/one-step import? Btw, OVF importer uses ""-"" instead of ""_"" in flags (should be `compute-service-account`)."
+5686,"@@ -23,7 +23,7 @@ use Symfony\Component\Routing\Annotation\Route;
+ /**
+  * @Route(
+  *     name=""ergonode_product_collection_element_delete"",
+- *     path=""/collections/{collection}/elements/{product}"",
++ *     path=""/collections/{collection}/element/{product}"",
+  *     methods={""DELETE""},
+  *     requirements={
+  *     ""collection""=""[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"",",Why change to element ?? in whole application use plural convention ??
+5687,"@@ -23,7 +23,7 @@ const renderInnerPanel = (props) => {
+ }
+
+ const poweredByUppy = (props) => {
+-  return <a href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
++  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
+     <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
+   </svg><span class=""uppy-Dashboard-poweredByUppy"">Uppy</span></a>
+ }","Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`"
+5688,"@@ -344,6 +344,16 @@ try:
+     cast = image.astype(np.float32)
+     assert cast.dtype == np.float32
+
++    # Test .astype for conversion between vector-like pixel types.
++    components = 3
++    numpyImage = np.random.randint(0, 256, (12,8,components)).astype(np.uint8)
++    input_image = itk.image_from_array(numpyImage, is_vector=True)
++    if (type(input_image) == itk.Image[itk.RGBPixel[itk.UC],2] and
++        hasattr(itk.CastImageFilter, 'IRGBUC2IVF32')):
++        output_pixel_type = itk.Vector[itk.F,components]
++        output_image = input_image.astype(output_pixel_type)
++        assert type(output_image) == itk.Image[output_pixel_type, 2]
++
+ except ImportError:
+     print(""NumPy not imported. Skipping BridgeNumPy tests"")
+     # Numpy is not available, do not run the Bridge NumPy tests","Unrelated to this PR, we should remove this exception. We now require `numpy`."
+5689,"@@ -29,7 +29,7 @@ type SubWorkflow struct {
+ func (s *SubWorkflow) populate(ctx context.Context, st *Step) DError {
+ 	if s.Path != """" {
+ 		var err error
+-		if s.Workflow, err = st.w.NewSubWorkflowFromFile(s.Path); err != nil {
++		if s.Workflow, err = st.w.NewSubWorkflowFromFile(s.Path, s.Vars); err != nil {
+ 			return ToDError(err)
+ 		}
+ 	}","Is the loop over vars and adding them to the subworkflow below in this file needed, since it's already done by NewSubWorkflowFromFile?"
+5690,"@@ -0,0 +1,19 @@
++module LicensesHelper
++  def license_date_range(license)
++    formatted_date_range(license.starts_on, license.ends_on)
++  end
++
++  def formatted_date_range(starts_on, ends_on)
++    if starts_on.nil? || ends_on.nil?
++      nil
++    elsif starts_on == ends_on
++      starts_on.to_s :simple
++    elsif starts_on.year != ends_on.year
++      ""#{starts_on.to_s(:simple)}-#{ends_on.to_s(:simple)}""
++    elsif starts_on.month != ends_on.month
++      ""#{starts_on.strftime(""%B %d"")}-#{ends_on.to_s(:simple)}""
++    else
++      ""#{starts_on.strftime(""%B %d"")}-#{ends_on.strftime(""%d, %Y"")}""
++    end
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+5691,"@@ -0,0 +1,5 @@
++import dagster.pandas_kernel as dagster_pd
++
++
++def simple_csv_input(name):
++    return dagster_pd.dataframe_input(name, sources=[dagster_pd.csv_dataframe_source()])",Having to write this util makes me think that maybe we should have kept the csv_input stuff. I don't know.
+5692,"@@ -21,9 +21,10 @@ var _ BlockOps = (*BlockOpsStandard)(nil)
+
+ // NewBlockOpsStandard creates a new BlockOpsStandard
+ func NewBlockOpsStandard(config Config, queueSize int) *BlockOpsStandard {
++	q := newBlockRetrievalQueue(queueSize, config.Codec(), config.BlockCache())
+ 	bops := &BlockOpsStandard{
+ 		config:  config,
+-		queue:   newBlockRetrievalQueue(queueSize, config.Codec()),
++		queue:   q,
+ 		workers: make([]*blockRetrievalWorker, 0, queueSize),
+ 	}
+ 	bg := &realBlockGetter{config: config}","Passing in and saving a reference to the `BlockCache` at init time is going to break if something calls `config.ResetCaches()`, because it replaces the `BlockCache` instance completely. This happens on user logout or by a manual write to `.kbfs_reset_caches`. So you probably want to give it the whole `config`, or maybe just the `config.BlockCache` function pointer."
+5693,"@@ -462,6 +462,9 @@ func (s *Service) newStreamForPeerID(ctx context.Context, peerID libp2ppeer.ID,
+ 	swarmStreamName := p2p.NewSwarmStreamName(protocolName, protocolVersion, streamName)
+ 	st, err := s.host.NewStream(ctx, peerID, protocol.ID(swarmStreamName))
+ 	if err != nil {
++		if st != nil {
++			_ = st.Close()
++		}
+ 		if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion {
+ 			return nil, p2p.NewIncompatibleStreamError(err)
+ 		}","I am not sure this could happen. st should be nil if the error happens. If it does happen, we could also do st.Reset(), since it is an erroureous state so it closes both sides of the stream."
+5694,"@@ -239,6 +239,7 @@ var requirejs, require, define;
+         }
+
+         function delayedError(e) {
++            console.log(e.stack);
+             return setTimeout(function() {
+                 e.dynaId && trackedErrors[e.dynaId] || (trackedErrors[e.dynaId] = !0, req.onError(e))
+             }), e",I'm guessing this was just added for debugging? Should probably remove it so we aren't modifying 3rd party libs.
+5695,"@@ -15,10 +15,17 @@ module Bolt
+         @object_open = true
+       end
+
++      def print_event(node, event)
++        case event[:type]
++        when :node_result
++          print_result(node, event[:result])
++        end
++      end
++
+       def print_result(node, result)
+         item = {
+           name: node.uri,
+-          status: result.is_a?(Bolt::ErrorResult) ? 'failure' : 'success',
++          status: result.success? ? 'success' : 'failure',
+           result: result.to_result
+         }
+ ","This seems reversed... if `success?` is true, wouldn't we use `success`?"
+5696,"@@ -0,0 +1,12 @@
++namespace Datadog.Trace
++{
++    internal enum LogEventLevel
++    {
++        Verbose,
++        Debug,
++        Information,
++        Warning,
++        Error,
++        Fatal
++    }
++}","This seemed like the easiest way to allow log level checks, it will require an update to the vendors tool, to ignore that file on update."
+5697,"@@ -21,6 +21,11 @@
+     <%= richtext_area :diary_comment, :body, :cols => 80, :rows => 15 %>
+     <%= submit_tag t('diary_entry.view.save_button') %>
+   <% end %>
++  <% if @user and @entry.subscribers.exists?(@user.id) %>
++    <div style='position:relative; top: -30px; left: 130px'><%= link_to t('javascripts.changesets.show.unsubscribe'), diary_entry_unsubscribe_path(:display_name => @entry.user.display_name, :id => @entry.id), :method => :post, :class => :button %></div>
++  <% elsif @user %>
++    <div style='position:relative; top: -30px; left: 130px'><%= link_to t('javascripts.changesets.show.subscribe'), diary_entry_subscribe_path(:display_name => @entry.user.display_name, :id => @entry.id), :method => :post, :class => :button %></div>
++  <% end %>
+ <% end %>
+
+ <%= if_not_logged_in(:div) do %>",Should we disallow entry authors to unsubscribe to their entries?
+5698,"@@ -1,7 +1,7 @@
+ # -*- coding: UTF-8 -*-
+ #core.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner
++#Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner, Derek Riemer
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",2016 should be 2017.
+5699,"@@ -155,7 +155,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+         String curSchemaSumary = existSchema.getSummary();
+         String schemaSummary = Hashing.sha256().newHasher().putString(content, Charsets.UTF_8).hash().toString();
+         if (!schemaSummary.equals(curSchemaSumary)) {
+-          if (microservice.getInstance().getEnvironment().equalsIgnoreCase(""development"")) {
++          if (curSchemaSumary == null || microservice.getInstance().getEnvironment().equalsIgnoreCase(""development"")) {
+             LOGGER.info(
+                 ""schemaId [{}]'s content changes and the current enviroment is development, so re-register it!"",
+                 schemaId);",boolean exists = (existSchema != null) && (existSchema .getSummary() != null);
+5700,"@@ -57,8 +57,8 @@ func NewCmdPoolDescribe() *cobra.Command {
+ 		Use:   ""describe"",
+ 		Short: ""Describes the pools"",
+ 		Long:  poolDescribeCommandHelpText,
+-		Run: func(cmd *cobra.Command, args []string) {
+-			util.CheckErr(options.runPoolDescribe(cmd), util.Fatal)
++		Run: func(_ *cobra.Command, args []string) {
++			util.CheckErr(options.runPoolDescribe(), util.Fatal)
+ 		},
+ 	}
+ ",It does not look idiomatic.
+5701,"@@ -3,9 +3,12 @@ package sql_test
+ import (
+ 	""testing""
+
++	_ ""github.com/mattn/go-sqlite3""
++
+ 	""github.com/DATA-DOG/go-sqlmock""
+ 	""github.com/google/go-cmp/cmp""
+ 	""github.com/google/go-cmp/cmp/cmpopts""
++
+ 	""github.com/influxdata/flux""
+ 	_ ""github.com/influxdata/flux/builtin"" // We need to import the builtins for the tests to work.
+ 	""github.com/influxdata/flux/dependencies/dependenciestest""","Generally, we do not use newlines between project imports, we only separate them from the stdlib imports"
+5702,"@@ -770,6 +770,10 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+             var isProgressClear = state.MediaSource && null == state.MediaSource.RunTimeTicks;
+             nowPlayingPositionSlider.setIsClear(isProgressClear);
+
++            if (nowPlayingItem.RunTimeTicks) {
++                nowPlayingPositionSlider.setKeyboardSteps(userSettings.skipBackLength() * 1000000 / nowPlayingItem.RunTimeTicks, userSettings.skipForwardLength() * 1000000 / nowPlayingItem.RunTimeTicks);
++            }
++
+             if (-1 === supportedCommands.indexOf(""ToggleFullscreen"") || player.isLocalPlayer && layoutManager.tv && playbackManager.isFullscreen(player)) {
+                 view.querySelector("".btnFullscreen"").classList.add(""hide"");
+             } else {",can this long line be wrapped?
+5703,"@@ -1731,6 +1731,12 @@ class ComparisonChecker(_BasicChecker):
+                       'comparison-with-itself',
+                       'Used when something is compared against itself.',
+                       ),
++            'W0143': ('Comparing bare callable, might have skipped parenthesis after callable',
++                      'comparison-with-callable',
++                      'Used when callable is used in a comparison without parenthesis, '
++                      'which means instead of comparing result of callable, '
++                      'callable itself is compared',
++                      ),
+
+             }
+ ",I'd use the same message that I suggested in the release changelog.
+5704,"@@ -53,7 +53,7 @@ function DocumentArray (key, schema, options) {
+     if (!Array.isArray(arr)) arr = [arr];
+     return new MongooseDocumentArray(arr, path, this);
+   });
+-};
++}
+
+ /**
+  * This schema type's name, to defend against minifiers that mangle",Keep semi-colons at end of function defs please
+5705,"@@ -2,13 +2,18 @@
+
+ const OperationBase = require('./operation').OperationBase;
+ const resolveReadPreference = require('../utils').resolveReadPreference;
++const ReadConcern = require('../read_concern');
++const WriteConcern = require('../write_concern');
+
+ class CommandOperationV2 extends OperationBase {
+   constructor(parent, options) {
+     super(options);
+
+     this.ns = parent.s.namespace.withCollection('$cmd');
+-    this.readPreference = resolveReadPreference(parent, options);
++    this.readPreference = resolveReadPreference(parent, this.options);
++    this.readConcern = resolveReadConcern(parent, this.options);
++    this.writeConcern = resolveWriteConcern(parent, this.options);
++    this.explain = false;
+
+     // TODO(NODE-2056): make logger another ""inheritable"" property
+     if (parent.s.logger) {",A little skeptical of `explain` being here. Why is this now a property of all commands?
+5706,"@@ -1,5 +1,7 @@
+-// Copyright (c) Microsoft. All rights reserved.
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+ namespace Microsoft.TestPlatform.Extensions.TrxLogger.ObjectModel
+ {",License copied two times!!
+5707,"@@ -44,7 +44,8 @@ class CustomWaiter:
+
+     """"""
+     def __init__(
+-            self, name, operation, argument, acceptors, client, delay=10, max_tries=60):
++            self, name, operation, argument, acceptors, client, delay=10, max_tries=60,
++            matcher='path'):
+         """"""
+         Subclasses should pass specific operations, arguments, and acceptors to
+         their super class.",... their **superclass**
+5708,"@@ -526,7 +526,7 @@ module Beaker
+         cmdline_args = conf_opts[:__commandline_args__]
+         conf_opts = conf_opts.reject { |k,v| k == :__commandline_args__ }
+
+-        curl_retries = host['master-start-curl-retries'] || options['master-start-curl-retries']
++        curl_retries = host['master-start-curl-retries'] || options['master-start-curl-retries'] || 0
+         logger.debug ""Setting curl retries to #{curl_retries}""
+
+         begin",I'm not sure if this is the right thing to be doing here. It seems like there should be a more systemic fix instead of this patch.
+5709,"@@ -811,6 +811,7 @@ const baseSelectors = {
+ 	/**
+ 	 * Gets the module's screenWidgetContext.
+ 	 *
++	 * Returns `undefined` if dependencies are loading.
+ 	 * Returns `null` if there is no registered context string for the given module.
+ 	 * Returns `string` the registered context string, screenWidgetContext for the given module.
+ 	 *",Not sure why these are up here   can we move these down to be part of the `@return` tag instead? This is what we usually do   (e.g. `getCurrentEntityURL`)
+5710,"@@ -34,12 +34,14 @@ module Blacklight::Document
+     # but extensions should call super and modify hash returned, to avoid
+     # unintentionally erasing values provided by other extensions.
+     def to_semantic_values
+-      @semantic_value_hash ||= self.class.field_semantics.each_with_object(Hash.new([])) do |(key, field_name), hash|
+-        value = self[field_name]
++      @semantic_value_hash ||= self.class.field_semantics.each_with_object(Hash.new([])) do |(key, field_names), hash|
++        ##
++        # Handles single string field_name or an array of field_names
++        value = Array.wrap(field_names).map { |field_name| self[field_name] }.flatten.compact
+
+         # Make single and multi-values all arrays, so clients
+         # don't have to know.
+-        hash[key] = Array.wrap(value) unless value.nil?
++        hash[key] = value unless value.empty?
+       end
+
+       @semantic_value_hash ||= {}",Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.
+5711,"@@ -0,0 +1,18 @@
++package org.openqa.selenium;
++
++/**
++ * Created by James Reed on 11/04/2016.
++ * Thrown to indicate that a click was attempted on an element but was intercepted by another
++ * element on top of it
++ */
++public class InterceptingElementException extends InvalidElementStateException {
++
++  public InterceptingElementException(String message) {
++    super(message);
++  }
++
++  public InterceptingElementException(String message, Throwable cause) {
++    super(message, cause);
++  }
++
++}",We keep who wrote the code anonymous.
+5712,"@@ -25,6 +25,12 @@ func (client *clientFake) NodeRegister(proposal dto_discovery.ServiceProposal) (
+ 	return nil
+ }
+
++func (client *clientFake) RegisterIdentity(identity dto_discovery.Identity) (err error) {
++	log.Info(MYSTERIUM_API_LOG_PREFIX, ""Identity registered: "", identity)
++
++	return nil
++}
++
+ func (client *clientFake) NodeSendStats(nodeKey string, sessionStats []dto.SessionStats) (err error) {
+ 	log.Info(MYSTERIUM_API_LOG_PREFIX, ""Node stats sent: "", nodeKey)
+ ","Mention something in logs, that fake registration was used e.g. `Fake identity registered`"
+5713,"@@ -151,10 +151,12 @@ const baseActions = {
+ 				return;
+ 			}
+
+-			registry.dispatch( STORE_NAME ).setPropertyID( propertyID );
+-
+ 			if ( PROPERTY_CREATE === propertyID ) {
+-				registry.dispatch( STORE_NAME ).setProfileID( PROFILE_CREATE );
++				registry.dispatch( STORE_NAME ).setSettings( {
++					propertyID,
++					profileID: PROFILE_CREATE,
++				} );
++
+ 				return;
+ 			}
+ ","I think it would make sense to also set `internalWebPropertyID` to `''` here. Otherwise, it might keep its previous value (let's say a property was selected before, but then the user chooses ""Create new property""), but since it always should depend on `propertyID`, that would be incorrect."
+5714,"@@ -779,3 +779,18 @@ TEST_CASE(""setDoubleBondNeighborDirections()"", ""[stereochemistry,bug]"") {
+     CHECK(MolToSmiles(*m) == ""C/C=C\\C"");
+   }
+ }
++
++TEST_CASE(""github #2782: addHs() fails on atoms with 'bad' valences"", ""[bug]"") {
++  SECTION(""basics"") {
++    SmilesParserParams ps;
++    ps.sanitize = false;
++    std::unique_ptr<RWMol> m(
++        static_cast<RWMol *>(SmilesToMol(""C=C1=CC=CC=C1"", ps)));
++    REQUIRE(m);
++    bool strict = false;
++    m->updatePropertyCache(strict);
++    CHECK(m->getNumAtoms() == 7);
++    MolOps::addHs(*m);
++    CHECK(m->getNumAtoms() == 14);
++  }
++}",It might be reasonable to add a check that sanitization still fails here.
+5715,"@@ -602,9 +602,8 @@ public class JobRunner extends EventHandler implements Runnable {
+     }
+
+     final int attemptNo = this.node.getAttempt();
+-    logInfo(""Finishing job "" + this.jobId + "" attempt: "" + attemptNo + "" at ""
++    logInfo(""Finishing job "" + this.jobId + (this.node.getAttempt() > 0 ? ("" retry: "" + attemptNo) : """") + "" at ""
+         + this.node.getEndTime() + "" with status "" + this.node.getStatus());
+-
+     fireEvent(Event.create(this, Type.JOB_FINISHED,
+         new EventData(finalStatus, this.node.getNestedId())), false);
+     finalizeLogFile(attemptNo);","Why not use attemptNo instead of another call to getAttempt? Even better, consider using a private method to calculate this string. This logic is in two places."
+5716,"@@ -2,7 +2,7 @@ module ProjectAssociations
+   extend ActiveSupport::Concern
+
+   included do
+-    has_many :links, -> { where(deleted: false) }
++    has_many :links, -> { where(""links.deleted = 'f'"") }
+     has_one :permission, as: :target
+     has_many :analyses
+     has_many :analysis_summaries, through: :analyses",Yuck. Rails bug.
+5717,"@@ -927,6 +927,15 @@ class Packet(six.with_metaclass(Packet_metaclass, BasePacket)):
+             return self.payload.answers(other.payload)
+         return 0
+
++    def layers(self):
++        """"""returns a list of layer classes (including subclasses) in this packet""""""  # noqa: E501
++        layers = []
++        l = self
++        while l:
++            layers.append(l.__class__)
++            l = l.payload.getlayer(0, _subclass=True)
++        return layers
++
+     def haslayer(self, cls):
+         """"""true if self has a layer that is an instance of cls. Superseded by ""cls in self"" syntax.""""""  # noqa: E501
+         if self.__class__ == cls or cls in [self.__class__.__name__,","It's useally a common practice to not use `l` as a variable (we have disabled this test in scapy because our code has tons, but it would have PEP8 failed otherwise), but it would be better not to create any. In general, single letter variables are not liked that much. Especially with windows where the fonts make 1=l How about `lay` ?"
+5718,"@@ -40,6 +40,12 @@ func (s *server) chunkUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))
++	w.WriteHeader(http.StatusContinue)
++	if f, ok := w.(http.Flusher); ok {
++		f.Flush()
++	}
++
+ 	// Add the tag to the context
+ 	ctx := sctx.SetTag(r.Context(), tag)
+ ","DRY these 5 lines into a function call, no?"
+5719,"@@ -113,12 +113,13 @@ func Main() int {
+ 	signal.Notify(term, os.Interrupt, syscall.SIGTERM)
+ 	select {
+ 	case <-term:
+-		fmt.Fprint(os.Stdout, ""Received SIGTERM, exiting gracefully..."")
++		logger.Log(""msg"", ""Received SIGTERM, exiting gracefully..."")
+ 		l.Close()
+ 		close(stopc)
+ 		wg.Wait()
+-	case <-errc:
+-		fmt.Fprintf(os.Stderr, ""Unhandled error received. Exiting..."")
++	case err := <-errc:
++		logger.Log(""msg"", ""Unhandled error received. Exiting..."", ""err"", err)
++		l.Close()
+ 		close(stopc)
+ 		wg.Wait()
+ 		return 1",should we be trying to close here? or just return directly @fabxc ? same goes for `stopc`...
+5720,"@@ -177,7 +177,7 @@ describe Ncr::ApprovalManager do
+
+     context ""for a BA60 or BA61 request"" do
+       it ""uses BA61 tier1 team approver when org code matches"" do
+-        org_letters = %w( 7 J 4 T 1 A C Z )
++        org_letters = %w( 1 4 7 A C J T Z )
+         org_letters.each do |org_letter|
+           org_code = ""P11#{org_letter}XXXX""
+           ncr_org = create(:ncr_organization, code: org_code)",just re-ordered for clarity
+5721,"@@ -69,13 +69,13 @@ func NewVolumeInfo(URL string, volname string, namespace string) (volInfo *Volum
+ 	}
+ 	if resp != nil && resp.StatusCode != 200 {
+ 		if resp.StatusCode == 500 {
+-			fmt.Printf(""Volume: %s not found at M_API server\n"", volname)
++			fmt.Printf(""Volume: %s not found at namespace: %q\n"", volname, namespace)
+ 			err = util.InternalServerError
+ 		} else if resp.StatusCode == 503 {
+ 			fmt.Println(""M_API server not reachable"")
+ 			err = util.ServerUnavailable
+ 		} else if resp.StatusCode == 404 {
+-			fmt.Printf(""Volume: %s not found at M_API server\n"", volname)
++			fmt.Printf(""Volume: %s not found at namespace: %q error: %s\n"", volname, namespace, http.StatusText(resp.StatusCode))
+ 			err = util.PageNotFound
+ 		}
+ 		fmt.Printf(""Received an error from M_API server: statuscode: %d"", resp.StatusCode)","Can you fix this also to print what is the IP address used to connect. Rename --> ""M_API server"" to maya apiservice"
+5722,"@@ -205,6 +205,18 @@ func decodeUTF8(s string, index uintptr) (rune, uintptr) {
+ 	}
+ }
+
++// indexByte returns the index of the first instance of c in the byte slice b,
++// or -1 if c is not present in the byte slice.
++//go:linkname indexByte internal/bytealg.IndexByte
++func indexByte(b []byte, c byte) int {
++	for i, x := range b {
++		if x == c {
++			return i
++		}
++	}
++	return -1
++}
++
+ // indexByteString returns the index of the first instance of c in s, or -1 if c
+ // is not present in s.
+ //go:linkname indexByteString internal/bytealg.IndexByteString","This fails on Go 1.11 because `indexByte` is already defined in strings_go111.go. I would suggest simply renaming one of the two, for example you could rename the other one to `strings_indexByte` (that will be one of the things we'll drop when we drop Go 1.11 support so it's better to make that one look ugly instead of the function that we will likely keep for a longer time)."
+5723,"@@ -868,7 +868,7 @@ CreateParameter(1)
+ Parameter #1 Direction=Input
+ Parameter #1 Name=@level
+ Parameter #1 MockDbType=Int32
+-Parameter #1 Value=""""{0}""""
++Parameter #1 Value={0}
+ Add Parameter Parameter #1
+ CreateParameter(2)
+ Parameter #2 Direction=Input",Now `dbType=' MockDbType.int32 '` is correctly interpreted and the value is rendered as an integer instead of a string; hence no more double quotes.
+5724,"@@ -63,7 +63,7 @@ class Comment extends AbstractAggregateRoot
+     public function changeContent(string $contend): void
+     {
+         if ($contend !== $this->content) {
+-            $this->apply(new CommentContentChangedEvent($this->id, $this->content, $contend, new \DateTime()));
++            $this->apply(new CommentContentChangedEvent($this->id, $contend, new \DateTime()));
+         }
+     }
+ ",typo in `$contend`
+5725,"@@ -28,9 +28,13 @@ import com.netflix.iceberg.TableOperations;
+ import com.netflix.iceberg.Tables;
+ import com.netflix.iceberg.exceptions.AlreadyExistsException;
+ import com.netflix.iceberg.exceptions.NoSuchTableException;
++import com.netflix.iceberg.exceptions.RuntimeIOException;
+ import org.apache.hadoop.conf.Configurable;
+ import org.apache.hadoop.conf.Configuration;
++import org.apache.hadoop.fs.FileSystem;
+ import org.apache.hadoop.fs.Path;
++
++import java.io.IOException;
+ import java.util.Map;
+
+ import static com.netflix.iceberg.TableMetadata.newTableMetadata;",Nit: empty line
+5726,"@@ -185,6 +185,10 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
+ }
+
+ func (fs *KBFSOpsStandard) getOpsNoAdd(fb FolderBranch) *folderBranchOps {
++	if fb == (FolderBranch{}) {
++		panic(""zero FolderBranch in getOps"")
++	}
++
+ 	fs.opsLock.RLock()
+ 	if ops, ok := fs.ops[fb]; ok {
+ 		fs.opsLock.RUnlock()",I figured this was more fool-proof than trying to plumb the error up from everywhere.
+5727,"@@ -192,8 +192,8 @@ func (c *client) initClient() {
+ 	c.cid = atomic.AddUint64(&s.gcid, 1)
+ 	c.bw = bufio.NewWriterSize(c.nc, startBufSize)
+ 	c.subs = make(map[string]*subscription)
+-	c.debug = (atomic.LoadInt32(&debug) != 0)
+-	c.trace = (atomic.LoadInt32(&trace) != 0)
++	c.debug = (atomic.LoadInt32(&c.srv.logging.debug) != 0)
++	c.trace = (atomic.LoadInt32(&c.srv.logging.trace) != 0)
+
+ 	// This is a scratch buffer used for processMsg()
+ 	// The msg header starts with ""MSG "",","We know debug and trace as globals exist and are defaulted to 0. In this instance we need to know that c is non- nil, srv is non-nil and logging is non-nil before we can trust this statement not to panic."
+5728,"@@ -58,7 +58,6 @@ type Provider interface {
+ func NewApp(AppRoot string, provider string) (*DdevApp, error) {
+ 	// Set defaults.
+ 	app := &DdevApp{}
+-	app.ConfigPath = filepath.Join(AppRoot, "".ddev"", ""config.yaml"")
+
+ 	app.AppRoot = AppRoot
+ 	app.ConfigPath = app.GetConfigPath(""config.yaml"")","Good removal here for two reasons: we're redeclaring `app.ConfigPath` immediately below without having used the initial value, and `app.GetConfigPath()` will build the value using the same process as in this line anyway."
+5729,"@@ -193,9 +193,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.Processors
+                 new RunSpecificTestsArgumentProcessor(),
+                 new TestAdapterPathArgumentProcessor(),
+                 new TestCaseFilterArgumentProcessor(),
+-                new OutputArgumentProcessor(),
+                 new BuildBasePathArgumentProcessor(),
+-                new ConfigurationArgumentProcessor(),
+                 new ParentProcessIdArgumentProcessor(),
+                 new PortArgumentProcessor(),
+                 new RunSettingsArgumentProcessor(),",Should BuildBase be removed?
+5730,"@@ -1,13 +1,14 @@
+ package internal_test
+
+ import (
++	""io/ioutil""
+ 	""os""
++	""path""
+ 	""regexp""
+ 	""testing""
+
+-	""github.com/golangci/golangci-lint/pkg/fsutils""
+-	ast ""github.com/stretchr/testify/assert""
+-	req ""github.com/stretchr/testify/require""
++	""github.com/stretchr/testify/assert""
++	""github.com/stretchr/testify/require""
+
+ 	tf ""github.com/filecoin-project/go-filecoin/testhelpers/testflags""
+ 	. ""github.com/filecoin-project/go-filecoin/tools/migration/internal""",this was a bad Goland auto-import that I missed in the previous PR. Thanks to @rkowalick and @acruikshank for catching it
+5731,"@@ -133,10 +133,12 @@ TEST_CASE(""github #2224"", ""[bug, molops, removeHs, query]"") {
+     }
+     {  // but if we add a query feature it's not removed
+       RWMol m2(*mol);
+-      m2.replaceAtom(1, new QueryAtom(1));
++      auto *qa = new QueryAtom(1);
++      m2.replaceAtom(1, qa);
+       m2.getAtomWithIdx(1)->setAtomicNum(1);
+       MolOps::removeHs(m2);
+       CHECK(m2.getNumAtoms() == 2);
++      delete qa;
+     }
+   }
+ }","Good catch here. Reading the code, it actually seems kind of dumb that `replaceAtom` needs to copy the atom it's passed. Ah well, we're more or less stuck with that."
+5732,"@@ -560,6 +560,17 @@ void wlr_output_schedule_frame(struct wlr_output *output) {
+ 		wl_event_loop_add_idle(ev, schedule_frame_handle_idle_timer, output);
+ }
+
++void wlr_output_send_present(struct wlr_output *output, struct timespec *when,
++		unsigned seq, uint32_t flags) {
++	struct wlr_output_event_present event = {
++		.output = output,
++		.when = when,
++		.seq = seq,
++		.flags = flags,
++	};
++	wlr_signal_emit_safe(&output->events.present, &event);
++}
++
+ bool wlr_output_set_gamma(struct wlr_output *output, size_t size,
+ 		const uint16_t *r, const uint16_t *g, const uint16_t *b) {
+ 	if (!output->impl->set_gamma) {",What's the reason for adding the output pointer here? I'd expect it to be derivable from the actual handler that's called.
+5733,"@@ -82,6 +82,10 @@ class Plan < ActiveRecord::Base
+     annual_plan.price
+   end
+
++  def annualized_savings
++    annualized_payment - discounted_annual_payment
++  end
++
+   def annual_plan_sku
+     annual_plan.sku
+   end",I don't see tests for this (or the similar method on `Team`).
+5734,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long
+5735,"@@ -281,8 +281,12 @@ func (c *client) readLoop() {
+ 		c.cache.subs = 0
+
+ 		if err := c.parse(b[:n]); err != nil {
+-			// handled inline
+-			if err != ErrMaxPayload && err != ErrAuthorization {
++			// If client connection has been closed, simply return,
++			// otherwise report a generic parsing error.
++			c.mu.Lock()
++			closed := c.nc == nil
++			c.mu.Unlock()
++			if !closed {
+ 				c.Errorf(""Error reading from client: %s"", err.Error())
+ 				c.sendErr(""Parser Error"")
+ 				c.closeConnection()","We had the checks for those two errors for a reason, why do we not need them anymore?"
+5736,"@@ -19,6 +19,7 @@ from rdkit import Chem
+ from rdkit.Chem.PeriodicTable import numTable
+ from rdkit.Chem import Crippen
+ from rdkit.Chem import rdPartialCharges, rdMolDescriptors
++from rdkit.six.moves import xrange
+ import numpy
+ import bisect
+ radCol = 5",Why didn't you just switch to `range` here too?
+5737,"@@ -32,15 +32,15 @@ import (
+ 	""google.golang.org/api/option""
+ )
+
+-// New returns a GCS Bucket. It handles creation of a client used to communicate
++// NewBucket returns a GCS Bucket. It handles creation of a client used to communicate
+ // to GCS service.
+-func New(ctx context.Context, bucketName string, opts *BucketOptions) (*blob.Bucket, error) {
++func NewBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient) (*blob.Bucket, error) {
+ 	if err := validateBucketChar(bucketName); err != nil {
+ 		return nil, err
+ 	}
+ 	var o []option.ClientOption
+-	if opts != nil {
+-		o = append(o, option.WithTokenSource(opts.TokenSource))
++	if client != nil {
++		o = append(o, option.WithHTTPClient(&client.Client))
+ 	}
+ 	c, err := storage.NewClient(ctx, o...)
+ 	if err != nil {","I don't even think `nil` should be allowed, since it uses global state to get the client."
+5738,"@@ -352,6 +352,9 @@ def qt_message_handler(msg_type, context, msg):
+         # may not be available on the system
+         ""QSslSocket: cannot resolve SSLv3_client_method"",
+         ""QSslSocket: cannot resolve SSLv3_server_method"",
++        # When enabling debugging with QtWebEngine
++        ""Remote debugging server started successfully. Try pointing a ""
++            ""Chromium-based browser to "",
+     ]
+     if sys.platform == 'darwin':
+         suppressed_msgs += [","You somehow got a change from `master` into your branch again, in e6d2167085688264e5ee6a81cfd2a7a8f10ded13. While it's not something terribly bad (as it will be fine after merging), it's kind of confusing, and I have no idea how it happens :laughing: Are you trying to update changes from `master` while working on your branch somehow? How do you do that?"
+5739,"@@ -3083,10 +3083,14 @@ initiate_request (OtPullData                 *pull_data,
+             g_clear_pointer (&delta_from_revision, g_free);
+         }
+
+-      /* This is similar to the below, except we *might* use the previous
+-       * commit, or we might do a scratch delta first.
++      /* If the current ref is different from the target, then this is similar
++       * to the below, except we *might* use the previous commit, or we might do
++       * a scratch delta first.
+        */
+-      initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);
++      if (!(delta_from_revision && g_str_equal (delta_from_revision, to_revision)))
++        initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);
++      else
++        queue_scan_one_metadata_object (pull_data, to_revision, OSTREE_OBJECT_TYPE_COMMIT, NULL, 0, ref);
+     }
+   else
+     {","Minor, can we drop the leading `!` and just swap the if and the else blocks?"
+5740,"@@ -102,7 +102,9 @@ class SCNetRoIHead(CascadeRoIHead):
+         bbox_head = self.bbox_head[stage]
+         bbox_feats = bbox_roi_extractor(
+             x[:len(bbox_roi_extractor.featmap_strides)], rois)
+-        if self.with_semantic and semantic_feat is not None:
++        # bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.
++        if self.with_semantic and semantic_feat is not None \
++                and bbox_feats.shape[0] > 0:
+             bbox_semantic_feat = self.semantic_roi_extractor([semantic_feat],
+                                                              rois)
+             if bbox_semantic_feat.shape[-2:] != bbox_feats.shape[-2:]:",`bbox_feats.shape[0] > 0` requires the number of proposal is not 0.
+5741,"@@ -1,4 +1,4 @@
+-const { h, Component } = require('preact')
++const { Component } = require('preact')
+
+ module.exports = class CloseWrapper extends Component {
+   componentWillUnmount () {","Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining."
+5742,"@@ -15,8 +15,10 @@
+ #include ""domain.h""
+ #include ""error.h""
+ #include ""update.h""
++#include ""force.h""
+
+ #include <cstring>
++#include <fmt/format.h>
+
+ using namespace LAMMPS_NS;
+ ","format.h is not a system header but bundled with LAMMPS. This should be `#include ""fmt/format.h""`"
+5743,"@@ -441,8 +441,15 @@ public final class BKDReader extends PointValues implements Accountable {
+
+   void visitDocValues(int[] commonPrefixLengths, byte[] scratchDataPackedValue, byte[] scratchMinIndexPackedValue, byte[] scratchMaxIndexPackedValue,
+                       IndexInput in, int[] docIDs, int count, IntersectVisitor visitor) throws IOException {
++    if (version >= BKDWriter.VERSION_LOW_CARDINALITY_LEAVES) {
++      visitDocValuesWithCardinality(commonPrefixLengths, scratchDataPackedValue, scratchMinIndexPackedValue, scratchMaxIndexPackedValue, in, docIDs, count, visitor);
++    } else {
++      visitDocValuesNoCardinality(commonPrefixLengths, scratchDataPackedValue, scratchMinIndexPackedValue, scratchMaxIndexPackedValue, in, docIDs, count, visitor);
++    }
++  }
+
+-
++  void visitDocValuesNoCardinality(int[] commonPrefixLengths, byte[] scratchDataPackedValue, byte[] scratchMinIndexPackedValue, byte[] scratchMaxIndexPackedValue,
++                      IndexInput in, int[] docIDs, int count, IntersectVisitor visitor) throws IOException {
+     readCommonPrefixes(commonPrefixLengths, scratchDataPackedValue, in);
+
+     if (numIndexDims != 1 && version >= BKDWriter.VERSION_LEAF_STORES_BOUNDS) {",could we always call visitDocValuesWithCardinality? It seems to include the version check already?
+5744,"@@ -607,6 +607,10 @@ public class RegistrationRequest {
+           + HUB_HOST + "" X -"" + HUB_PORT + "" 5555. The specified config was -"" + HUB_HOST + "" ""
+           + hub + "" -"" + HUB_PORT + "" "" + port);
+     }
++
++    if(port==-1){
++    	throw new GridConfigurationException(""No port was specified in -hub parameter. Example - http://""+hub+"":4444/grid/register"");
++    }
+   }
+
+ ","I think if they _don't_ specify a port, we should assume grid default (which is 4444)"
+5745,"@@ -155,14 +155,12 @@ std::vector<std::string> enumerateTautomerSmiles(
+   cleanup(*mol, params);
+   MolOps::sanitizeMol(*mol);
+
+-  auto *tautparams = new TautomerCatalogParams(params.tautomerTransforms);
+-  //	unsigned int ntautomers = tautparams->getNumTautomers();
+-  TautomerEnumerator te(new TautomerCatalog(tautparams));
++  TautomerEnumerator te(params);
+
+-  std::vector<ROMOL_SPTR> res = te.enumerate(*mol);
++  auto res = te.enumerate(*mol);
+
+   std::vector<std::string> tsmiles;
+-  for (const auto &r : res) {
++  for (const auto &r : res.tautomers) {
+     tsmiles.push_back(MolToSmiles(*r));
+   }
+ ",This looks to be a breaking change. I know it will affect some of my code that uses the Tautomer enumerator.
+5746,"@@ -61,8 +61,12 @@ func (m *bucketlistMessage) String() string {
+ 	if output.Format == """" {
+ 		var lines []string
+ 		lines = append(lines, fmt.Sprintf(""Blockchain Node: %s"", m.Node))
+-		for _, bucket := range m.Bucketlist {
+-			lines = append(lines, bucket.String())
++		if len(m.Bucketlist) == 0 {
++			lines = append(lines, ""Empty bucketlist with given address"")
++		} else {
++			for _, bucket := range m.Bucketlist {
++				lines = append(lines, bucket.String())
++			}
+ 		}
+ 		return strings.Join(lines, ""\n"")
+ 	}",Perhaps remove this line
+5747,"@@ -707,6 +707,9 @@ void removeHs(RWMol &mol, const RemoveHsParameters &ps, bool sanitize) {
+     if (!ps.removeMapped && atom->getAtomMapNum()) {
+       continue;
+     }
++    if (!ps.removeHydrides && atom->getAtomicNum() == 1 && atom->getFormalCharge() == -1) {
++      continue;
++    }
+     bool removeIt = true;
+     if (atom->getDegree() &&
+         (!ps.removeDummyNeighbors || !ps.removeDefiningBondStereo ||","Ah, missed this one. Sorry: you don't need to test the atomic number here. that's taken care of above on line 683."
+5748,"@@ -146,8 +146,11 @@ func (c *roundCalculator) roundInfo(
+ 		}
+ 	}
+ 	if !lastBlockTime.Before(now) {
++		// TODO: if this is the case, the system time is far behind the time of other nodes.
++		// the code below is just to mute the warning, but ""panic"" may be a better choice.
++		time.Sleep(lastBlockTime.Sub(now))
+ 		err = errors.Errorf(
+-			""last block time %s is a future time, vs now %s"",
++			""last block time %s is a future time, vs now %s. it seems that your system time is far behind.\nplease calibrate your system time and restart the chain."",
+ 			lastBlockTime,
+ 			now,
+ 		)","roundInfo() is called by couple of places in consensus for safety, better test/verify the delay of return err due to this Sleep() would not affect the normal functionality, like consensus can still be reached, full-node can correctly sync"
+5749,"@@ -376,8 +376,9 @@ func (sb *RustSectorBuilder) GeneratePoSt(req GeneratePoStRequest) (GeneratePoSt
+ 	defer elapsed(""GeneratePoSt"")()
+
+ 	// flattening the byte slice makes it easier to copy into the C heap
+-	flattened := make([]byte, 32*len(req.CommRs))
+-	for idx, commR := range req.CommRs {
++	commRs := req.SortedCommRs.Values()
++	flattened := make([]byte, 32*len(commRs))
++	for idx, commR := range commRs {
+ 		copy(flattened[(32*idx):(32*(1+idx))], commR[:])
+ 	}
+ ",This 32 could go away too.
+5750,"@@ -146,6 +146,8 @@ class Notification extends Component {
+ 			module,
+ 			moduleName,
+ 			pageIndex,
++			pageSpeedLink,
++			pageSpeedLabel,
+ 		} = this.props;
+
+ 		if ( getCache( `notification::dismissed::${ id }` ) ) {","These props should be less specifically named since the component is generic, for example `anchorLink`, `anchorLinkLabel`."
+5751,"@@ -189,13 +189,13 @@ func (r *AWSMachineReconciler) reconcileDelete(machineScope *scope.MachineScope,
+ 		// and AWSMachine
+ 		// 3. Issue a delete
+ 		// 4. Scale controller deployment to 1
+-		machineScope.V(2).Info(""Unable to locate instance by ID or tags"")
++		machineScope.V(2).Info(""Unable to locate EC2 instance by ID or tags"")
+ 		r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""NoInstanceFound"", ""Unable to find matching EC2 instance"")
+ 		machineScope.AWSMachine.Finalizers = util.Filter(machineScope.AWSMachine.Finalizers, infrav1.MachineFinalizer)
+ 		return reconcile.Result{}, nil
+ 	}
+
+-	machineScope.V(3).Info(""Instance found matching deleted AWSMachine"", ""instanceID"", instance.ID)
++	machineScope.V(3).Info(""EC2 instance found matching deleted AWSMachine"", ""instance-id"", instance.ID)
+
+ 	// Check the instance state. If it's already shutting down or terminated,
+ 	// do nothing. Otherwise attempt to delete it.","In the future, it'd be great if we can separate commits or PRs that aren't in the same scope"
+5752,"@@ -133,7 +133,11 @@ class ScriptableType(AutoPropertyType):
+
+ 	def __new__(meta, name, bases, dict):
+ 		cls = super(ScriptableType, meta).__new__(meta, name, bases, dict)
+-		gestures = getattr(cls, ""_%s__gestures"" % cls.__name__, {})
++		# #8463: To avoid name mangling conflicts, create a copy of the __gestures dictionary.
++		try:
++			gestures = getattr(cls, ""_%s__gestures"" % cls.__name__).copy()
++		except AttributeError:
++			gestures = {}
+ 		# Python 3 incompatible.
+ 		for name, script in dict.iteritems():
+ 			if not name.startswith('script_'):","can you define the string format on a different line, so it can be named, and so that it does not have to be constructed twice?"
+5753,"@@ -91,3 +91,9 @@ class AnsibleGalaxyInstall:
+         except sh.ErrorReturnCode as e:
+             LOG.error('ERROR: {}'.format(e))
+             utilities.sysexit(e.exit_code)
++
++    def download(self, config_file):
++        utilities.print_info('Installing role dependencies ...')
++        self.add_env_arg('ANSIBLE_CONFIG', config_file)
++        self.bake()
++        self.execute()",Can we write a unit test for this.
+5754,"@@ -685,6 +685,8 @@ class AbstractTab(QWidget):
+
+     @pyqtSlot(bool)
+     def _on_load_finished(self, ok):
++        sess_manager = objreg.get('session-manager')
++        sess_manager.session_save('_autosave', quiet=True, force=True)
+         if ok and not self._has_ssl_errors:
+             if self.url().scheme() == 'https':
+                 self._set_load_status(usertypes.LoadStatus.success_https)","Same as above, use `.delete('_autosave')`, not the command handler."
+5755,"@@ -68,18 +68,7 @@ class BatchDataReader extends BaseDataReader<ColumnarBatch> {
+     // update the current file for Spark's filename() function
+     InputFileBlockHolder.set(file.path().toString(), task.start(), task.length());
+
+-    // schema or rows returned by readers
+-    PartitionSpec spec = task.spec();
+-    Set<Integer> idColumns = spec.identitySourceIds();
+-    Schema partitionSchema = TypeUtil.select(expectedSchema, idColumns);
+-    boolean projectsIdentityPartitionColumns = !partitionSchema.columns().isEmpty();
+-
+-    Map<Integer, ?> idToConstant;
+-    if (projectsIdentityPartitionColumns) {
+-      idToConstant = PartitionUtil.constantsMap(task, BatchDataReader::convertConstant);
+-    } else {
+-      idToConstant = ImmutableMap.of();
+-    }
++    Map<Integer, ?> idToConstant = PartitionUtil.constantsMap(task, BatchDataReader::convertConstant);
+
+     CloseableIterable<ColumnarBatch> iter;
+     InputFile location = getInputFile(task);","It isn't necessary to check whether there are projected ID columns. The code is shorter if the values are available by default, even if they aren't used. This fixes the problem where there are constants to add (like `_file`) but no identity partition values are projected."
+5756,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename
+5757,"@@ -6,9 +6,9 @@ package net.sourceforge.pmd.lang.java.rule.bestpractices;
+
+ import java.util.List;
+
++import net.sourceforge.pmd.lang.java.ast.ASTAnyTypeDeclaration;
+ import org.jaxen.JaxenException;
+
+-import net.sourceforge.pmd.lang.ast.AbstractNode;
+ import net.sourceforge.pmd.lang.ast.Node;
+ import net.sourceforge.pmd.lang.java.ast.ASTAllocationExpression;
+ import net.sourceforge.pmd.lang.java.ast.ASTArrayInitializer;","@KroArtem This is the Checkstyle violation. This import should be grouped with other `net.sourceforge.pmd` imports below, in alphabetical order"
+5758,"@@ -47,6 +47,7 @@ import (
+ 	""github.com/ncw/rclone/lib/rest""
+ 	""github.com/ncw/swift""
+ 	""github.com/pkg/errors""
++	""github.com/ncw/rclone/fs""
+ )
+
+ // Register with Fs",File is not `goimports`-ed (from `goimports`)
+5759,"@@ -126,6 +126,10 @@ public class MessageTopView extends LinearLayout implements ShowPicturesControll
+         mHeaderContainer.setOnFlagListener(listener);
+     }
+
++    public void setOnToggleFlagLongClickListener(OnLongClickListener listener){
++        mHeaderContainer.setOnFlagListener(listener);
++    }
++
+     public void showAllHeaders() {
+         mHeaderContainer.onShowAdditionalHeaders();
+     }",This change seems unrelated to copying email addresses to the clipboard. Please limit the scope of pull requests as much as possible.
+5760,"@@ -370,6 +370,13 @@ static void seat_client_send_keymap(struct wlr_seat_client *client,
+ 			continue;
+ 		}
+
++		if (keyboard->keymap == NULL) {
++			wl_keyboard_send_keymap(resource,
++				WL_KEYBOARD_KEYMAP_FORMAT_NO_KEYMAP, keymap_fd, 0);
++			close(keymap_fd);
++			continue;
++		}
++
+ 		void *ptr = mmap(NULL, keyboard->keymap_size, PROT_READ | PROT_WRITE,
+ 				MAP_SHARED, keymap_fd, 0);
+ 		if (ptr == MAP_FAILED) {","I'm assuming that there isn't a way for us to skip sending an fd here (-1?), and that we're allocating this fd just to send a legal but useless value across?"
+5761,"@@ -66,7 +66,11 @@ func TransportSpec(opts ...Option) yarpcconfig.TransportSpec {
+ // All parameters of TransportConfig are optional. This section
+ // may be omitted in the transports section.
+ type TransportConfig struct {
+-	Backoff yarpcconfig.Backoff `config:""backoff""`
++	ServerMaxRecvMsgSize int                 `config:""serverMaxRecvMsgSize""`
++	ServerMaxSendMsgSize int                 `config:""serverMaxSendMsgSize""`
++	ClientMaxRecvMsgSize int                 `config:""clientMaxRecvMsgSize""`
++	ClientMaxSendMsgSize int                 `config:""clientMaxSendMsgSize""`
++	Backoff              yarpcconfig.Backoff `config:""backoff""`
+ }
+
+ // InboundConfig configures a gRPC Inbound.",might be good for the units (bytes?) to be in the variable name.
+5762,"@@ -1,6 +1,6 @@
+ # NOTE: There are several rewrite rules defined in
+ # config/initializers/rack_rewrite.rb which run before these routes.
+-Upcase::Application.routes.draw do
++Rails.application.routes.draw do
+   scope ""upcase"" do
+     root to: ""marketing#show""
+ ",Metrics/BlockLength: Block has too many lines. [166/25]
+5763,"@@ -23,9 +23,9 @@
+ CSV file based implementation of a record stream
+
+ FileRecordStream is class that can read and write .csv files that contain
+-records. The file has 3 header lines that contain for each field the name, type
+-and a special indicator for the fields that serve as the reset field,
+-sequence id field and timestamp field. The other fields
++records. The file has 3 header lines that contain, for each field, the name
++(line 1), type (line 2), and a special indicator (line 3) for those fields that
++serve as the reset field, sequence id field, and timestamp field.
+
+ The header lines look like:
+ ","I'd end the sentence after `special indicator (line 3)`. And then start a new sentence: `The special field can indicate that the field specifies a reset, is a sequence ID, or is a timestamp for the record.`"
+5764,"@@ -105,11 +105,9 @@ def bbox_mapping_back(bboxes, img_shape, scale_factor, flip):
+
+ def bbox2roi(bbox_list):
+     """"""Convert a list of bboxes to roi format.
+-
+     Args:
+         bbox_list (list[Tensor]): a list of bboxes corresponding to a batch
+             of images.
+-
+     Returns:
+         Tensor: shape (n, 5), [batch_ind, x1, y1, x2, y2]
+     """"""",These empty lines can be kept.
+5765,"@@ -176,14 +176,14 @@ public class VelocityResponseWriterTest extends SolrTestCaseJ4 {
+     // The test init properties file turns off being able to use $foreach.index (the implicit loop counter)
+     // The foreach.vm template uses $!foreach.index, with ! suppressing the literal ""$foreach.index"" output
+
+-    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocity"",VelocityResponseWriter.TEMPLATE,""foreach"")));
+-    assertEquals("""", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")));
++    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocity"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
++    assertEquals("""", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
+
+     // Turn off trusted configset, which disables the init properties
+     h.getCoreContainer().getCoreDescriptor(h.coreName).setConfigSetTrusted(false);
+     assertFalse(h.getCoreContainer().getCoreDescriptor(coreName).isConfigSetTrusted());
+
+-    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")));
++    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
+
+     // set the harness back to the default of trusted
+     h.getCoreContainer().getCoreDescriptor(h.coreName).setConfigSetTrusted(true);","For some reason these tests started failing due to an extra `NEWLINE` returned from `h.query()`. Have not tried to check whether this may be a problem for real templates or not, just fixed the failing tests. Anyone with an opinion here?"
+5766,"@@ -42,6 +42,9 @@ type TraceContext struct{}
+ var _ propagation.TextFormat = TraceContext{}
+ var traceCtxRegExp = regexp.MustCompile(""^[0-9a-f]{2}-[a-f0-9]{32}-[a-f0-9]{16}-[a-f0-9]{2}-?"")
+
++// DefaultPropagator is the default trace propagator.
++var DefaultPropagator propagation.TextFormat = TraceContext{}
++
+ func (hp TraceContext) Inject(ctx context.Context, supplier propagation.Supplier) {
+ 	sc := SpanFromContext(ctx).SpanContext()
+ 	if sc.IsValid() {",It is better to have a method than a var.
+5767,"@@ -58,9 +58,11 @@ func (s scannerCtxExecMgrFactory) NewExecutionManager(shardID int32) (persistenc
+ const (
+ 	scannerContextKey = contextKey(0)
+
+-	maxConcurrentActivityExecutionSize     = 10
+-	maxConcurrentWorkflowTaskExecutionSize = 10
+-	infiniteDuration                       = 20 * 365 * 24 * time.Hour
++	maxConcurrentActivityExecutionSize = 10
++	maxConcurrentWorkflowExecutionSize = 10
++	maxConcurrentActivityTaskPollers   = 16
++	maxConcurrentWorkflowTaskPollers   = 16
++	infiniteDuration                   = 20 * 365 * 24 * time.Hour
+
+ 	tqScannerWFID                  = ""temporal-sys-tq-scanner""
+ 	tqScannerWFTypeName            = ""temporal-sys-tq-scanner-workflow""","concurrent poller won't be larger than concurrent execution. Jump from 2 -> 16 seems aggressive. I suggest to use 8. Ideally, this should be dynamic config. :)"
+5768,"@@ -0,0 +1,5 @@
++_base_ = ['./yolact_r50.py']
++
++model = dict(pretrained='torchvision://resnet101', backbone=dict(depth=101))
++
++work_dir = './work_dirs/yolact_r101'",List is redundant.
+5769,"@@ -88,8 +88,9 @@ public class LoginActivity extends BaseActivity implements CustomTabActivityHelp
+
+         setTitle(getString(R.string.txtSignIn));
+         setSupportActionBar(toolbar);
+-        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
+-
++        if(getSupportActionBar()!=null) {
++            getSupportActionBar().setDisplayHomeAsUpEnabled(true);
++        }
+         userLoginUri = Uri.parse(getString(R.string.website) + ""cgi/user.pl"");
+         resetPasswordUri = Uri.parse(getString(R.string.website) + ""cgi/reset_password.pl"");
+ ","Please use a string resource here rather than the hardcoded string ""user"". This allows the app to be multilingual."
+5770,"@@ -18,13 +18,10 @@ package cstorpoolit
+
+ import (
+ 	""testing""
+-
+ 	""time""
+
+ 	. ""github.com/onsi/ginkgo""
+ 	. ""github.com/onsi/gomega""
+-	""github.com/openebs/CITF""
+-	""github.com/openebs/CITF/citf_options""
+ 	apis ""github.com/openebs/CITF/pkg/apis/openebs.io/v1alpha1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )",@aswathkk Why did we remove this import? I guess we are using it.
+5771,"@@ -184,7 +184,6 @@ func (s *Service) Stop() {
+ 	remainingTime = s.sleep(shardOwnershipTransferDelay, remainingTime)
+
+ 	s.GetLogger().Info(""ShutdownHandler: No longer taking rpc requests"")
+-	s.handler.PrepareToStop()
+ 	remainingTime = s.sleep(gracePeriod, remainingTime)
+
+ 	// TODO: Change this to GracefulStop when integration tests are refactored.",Why? I thought this is for graceful shutdown.
+5772,"@@ -59,10 +59,14 @@ module Bolt
+         if result.instance_of? Bolt::TaskResult
+           @stream.puts(indent(2, ::JSON.pretty_generate(result.value)))
+         elsif result.instance_of? Bolt::CommandResult
+-          @stream.puts(indent(2, ""STDOUT:""))
+-          @stream.puts(indent(4, result.stdout))
+-          @stream.puts(indent(2, ""STDERR:""))
+-          @stream.puts(indent(4, result.stderr))
++          unless result.stdout.strip.empty?
++            @stream.puts(indent(2, ""STDOUT:""))
++            @stream.puts(indent(4, result.stdout))
++          end
++          unless result.stderr.strip.empty?
++            @stream.puts(indent(2, ""STDERR:""))
++            @stream.puts(indent(4, result.stderr))
++          end
+         end
+       end
+ ",Can `result.stdout` or `result.stderr` be nil?
+5773,"@@ -130,7 +130,8 @@ public class PyIssueParserProvider implements BlazeIssueParserProvider {
+       if (projectScope.contains(vf)) {
+         return 0;
+       }
+-      return PythonSdkType.isStdLib(vf, sdk) ? 2 : 1;
++      return 2;
++      // return PythonSdkType.isStdLib(vf, sdk) ? 2 : 1;
+     }
+
+     /** defaults to -1 if no line number can be parsed. */",@mprobst Looks like the `isStdLib` function has been removed in the latest Python plugin. Any thoughts on how to handle this? The new version doesn't seem to have any relevant alternatives.
+5774,"@@ -32,6 +32,8 @@ type Config struct {
+ 	RuleRendererOverride rules.RuleRenderer
+ 	IPIPMTU              int
+
++	MaxIPSetSize int
++
+ 	IptablesRefreshInterval time.Duration
+
+ 	RulesConfig rules.Config",How can there be a configured max ipset size? Surely we need to write ipsets with however many members are implied by the Calico datastore?
+5775,"@@ -205,7 +205,7 @@ export default AbstractEditController.extend(IncidentStatuses, FriendlyId, Patie
+
+     showDeleteAttachment(attachment) {
+       let i18n = get(this, 'i18n');
+-      let message = i18n.t('incident.messages.deleteAttachment');
++      let message = i18n.t('messages.delete_singular', { name: 'attachment' });
+       let model = Ember.Object.create({
+         itemToDelete: attachment
+       });",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.
+5776,"@@ -75,6 +75,14 @@ public class ExpressionVisitors {
+       return null;
+     }
+
++    public <T> R isNaN(BoundReference<T> ref) {
++      throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement isNaN"");
++    }
++
++    public <T> R notNaN(BoundReference<T> ref) {
++      throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement notNaN"");
++    }
++
+     public <T> R lt(BoundReference<T> ref, Literal<T> lit) {
+       return null;
+     }",why not be consistent with `isNull` and `notNull` and return null?
+5777,"@@ -41,6 +41,7 @@ type BackendServiceConfig struct {
+ 	*Logging      `yaml:""logging,flow""`
+ 	Sidecars      map[string]*SidecarConfig `yaml:""sidecars""`
+ 	Network       NetworkConfig             `yaml:""network""`
++	DockerLabels  map[string]string         `yaml:""docker_labels,flow""`
+ }
+
+ type imageWithPortAndHealthcheck struct {",Did we forget to remove this field?
+5778,"@@ -60,4 +60,9 @@ public class BaseRefreshableMap<K, V extends IRefreshable> extends HashMap<K, V>
+   public BaseRefreshableMap<K, V> clone() {
+     return (BaseRefreshableMap<K, V>) super.clone();
+   }
++
++  @Override
++  public int elementCount() {
++    return this.values().stream().mapToInt(elem -> elem.elementCount()).sum();
++  }
+ }",What if there is no element?
+5779,"@@ -52,8 +52,15 @@ func (c *Client) uploadAction(target *core.BuildTarget, isTest, isRun bool) (*pb
+ 	return command, digest, err
+ }
+
+-// buildAction creates a build action for a target and returns the command and the action digest digest. No uploading is done.
++// buildAction creates a build action for a target and returns the command and the action digest. No uploading is done.
+ func (c *Client) buildAction(target *core.BuildTarget, isTest, stamp bool) (*pb.Command, *pb.Digest, error) {
++	c.buildActionMutex.Lock()
++	defer c.buildActionMutex.Unlock()
++
++	if d, ok := c.buildActions[target.Label]; ok {
++		return d.command, d.actionDigest, nil
++	}
++
+ 	inputRoot, err := c.uploadInputs(nil, target, isTest)
+ 	if err != nil {
+ 		return nil, nil, err",I think you need to be careful to honour isTest and stamp here.
+5780,"@@ -14,10 +14,16 @@
+  */
+ package com.google.api.codegen.transformer.nodejs;
+
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
++import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
++import com.google.api.tools.framework.model.TypeRef;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",why zero value for `arrayType` for the default value of the optional args?
+5781,"@@ -264,6 +264,14 @@ class Filter extends WidgetBase
+                 $value = post('options.value.' . $scope->scopeName) ?: null;
+                 $this->setScopeValue($scope, $value);
+                 break;
++
++            case 'clear':
++                foreach ($this->getScopes() as $scope) {
++                    $this->setScopeValue($scope, null);
++                }
++
++                return ['.control-filter' => $this->render()];
++                break;
+         }
+
+         /*","@robinbonnes ~~Would you mind putting the array key and value on a new line - it makes it more readable as an array.~~ Never mind, see discussion below."
+5782,"@@ -26,6 +26,7 @@ var version = ""(unreleased version)""
+ func main() {
+ 	var (
+ 		justVersion      bool
++		cniNet, cniIpam  bool
+ 		address          string
+ 		meshAddress      string
+ 		logLevel         string","I've never seen us do this anywhere else - why here? Why not `address, meshAddress string`?"
+5783,"@@ -191,7 +191,9 @@ public class RequestUtil {
+     }
+
+     // implement compat for existing components...
+-    JsonQueryConverter jsonQueryConverter = new JsonQueryConverter();
++    JsonQueryConverter jsonQueryConverter = (JsonQueryConverter) req.getContext()
++        .computeIfAbsent(JsonQueryConverter.contextKey, (k)->new JsonQueryConverter());
++
+     if (json != null && !isShard) {
+       for (Map.Entry<String,Object> entry : json.entrySet()) {
+         String key = entry.getKey();","I think it's necessary only for the earlier ""dynamic"" approach. I suppose it's not necessary in the eager one."
+5784,"@@ -437,4 +437,9 @@ class Configurator
+             ? $this->doctrineTypeToFormTypeMap[$doctrineType]
+             : $doctrineType;
+     }
++
++	public function getBackendConfig()
++	{
++		return $this->backendConfig;
++	}
+ }",Same here than [there](#r26168925)
+5785,"@@ -53,12 +53,12 @@ public class ApplicationDTO {
+         this.typeId = builder.typeId;
+         this.categoryId = builder.categoryId;
+         if (builder.id != null) {
+-            if (builder.id.matches(""^[a-zA-Z0-9_]+$"")) {
++            if (builder.id.matches(""^[a-zA-Z0-9_.]+$"")) {
+                 this.id = builder.id;
+             } else {
+                 LOGGER.warn(String.format(""Application ID (%s) contains invalid characters, will remove them."",
+                         builder.id));
+-                this.id = builder.id.replaceAll(""[^a-zA-Z0-9_]"", """");
++                this.id = builder.id.replaceAll(""[^a-zA-Z0-9_.]"", """");
+             }
+         } else {
+             this.id = null;",Again we should think about moving this pattern to a static final field
+5786,"@@ -186,7 +186,7 @@ class ConfigManager
+     private function doProcessConfig($backendConfig)
+     {
+         $configPasses = array(
+-            new NormalizerConfigPass(),
++            new NormalizerConfigPass($this->container->get('easyadmin.controller_resolver')),
+             new DesignConfigPass($this->container->get('twig'), $this->container->getParameter('kernel.debug')),
+             new MenuConfigPass(),
+             new ActionConfigPass(),",haven't been implemented the `__constructor` for `NormalizerConfigPass` ?
+5787,"@@ -190,3 +190,16 @@ class Collect(object):
+     def __repr__(self):
+         return self.__class__.__name__ + '(keys={}, meta_keys={})'.format(
+             self.keys, self.meta_keys)
++
++
++@PIPELINES.register_module
++class WrapFieldsToLists(object):
++
++    def __call__(self, results):
++        # Wrap dict fields into lists
++        for key, val in results.items():
++            results[key] = [val]
++        return results
++
++    def __repr__(self):
++        return '{}()'.format(self.__class__.__name__)",Docstring is missing.
+5788,"@@ -74,6 +74,7 @@ bool BaseEvents::loadFromXml()
+
+ 		if (!success || !registerEvent(event, node)) {
+ 			delete event;
++			return false;
+ 		}
+ 	}
+ 	return true;","I don't see the reason of this return as it will stop loading in half because an error, thats bad imo. Or you load it all and report errors or you load nothing and terminate, the first is as it always was so I wouldn't change that."
+5789,"@@ -58,9 +58,9 @@ func NewMockKademlia(o ...Option) *Mock {
+ 	return m
+ }
+
+-// AddPeer is called when a peer is added to the topology backlog
++// AddPeers  is called when a peers are added to the topology backlog
+ // for further processing by connectivity strategy.
+-func (m *Mock) AddPeer(ctx context.Context, addr swarm.Address) error {
++func (m *Mock) AddPeers(ctx context.Context, addr ...swarm.Address) error {
+ 	panic(""not implemented"") // TODO: Implement
+ }
+ ",change from AddPeer to AddPeers added a space in some occurrences
+5790,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+5791,"@@ -29,15 +29,15 @@ import (
+ const NodePortLocalChain = ""ANTREA-NODE-PORT-LOCAL""
+
+ // IPTableRules provides a client to perform IPTABLES operations
+-type iptablesRules struct {
++type IPTableRules struct {
+ 	name  string
+ 	table *iptables.Client
+ }
+
+-// NewIPTableRules retruns a new instance of IPTableRules
+-func NewIPTableRules() *iptablesRules {
++// NewIPTableRules returns a new instance of IPTableRules
++func NewIPTableRules() *IPTableRules {
+ 	iptInstance, _ := iptables.New(true, false)
+-	iptRule := iptablesRules{
++	iptRule := IPTableRules{
+ 		name:  ""NPL"",
+ 		table: iptInstance,
+ 	}","Do you remove ""s"" from ""iptables"" to IPTable"" on purpose? I feel it should be ""IPTablesRules""."
+5792,"@@ -16,17 +16,17 @@ package org.hyperledger.besu.ethereum.api.jsonrpc.internal.privacy.methods.priv;
+
+ import org.hyperledger.besu.ethereum.api.jsonrpc.RpcMethod;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequestContext;
++import org.hyperledger.besu.ethereum.api.jsonrpc.internal.methods.JsonRpcMethod;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcResponse;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcSuccessResponse;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.PrivacyParameters;
+
+-public class PrivGetPrivacyPrecompileAddress extends PrivacyApiMethod {
++public class PrivGetPrivacyPrecompileAddress implements JsonRpcMethod {
+
+   private final Integer privacyAddress;
+
+   public PrivGetPrivacyPrecompileAddress(final PrivacyParameters privacyParameters) {
+-    super(privacyParameters);
+     privacyAddress = privacyParameters.getPrivacyAddress();
+   }
+ ","nit: not your problem - but I wonder if this should have been a ""ConstantResponseRpc"" - which takes a name and a value .... maybe a more reusable concept."
+5793,"@@ -26,7 +26,7 @@ import (
+ // instrumentationName is empty, then a implementation defined default name
+ // will be used instead.
+ //
+-// This is short for MeterProvider().Meter(name)
++// This is short for otel.GetMeterProvider().Meter(name)
+ func Meter(instrumentationName string, opts ...metric.MeterOption) metric.Meter {
+ 	return GetMeterProvider().Meter(instrumentationName, opts...)
+ }",These changes have been resolved upstream. We can revert changes to this file when synced.
+5794,"@@ -33,7 +33,7 @@ T = TypeVar(""T"")
+
+ class Partition(Generic[T]):
+     """"""
+-    Partition is the representation of a logical slice across an axis of a pipeline's work
++    A Partition represents a single slice of the entire set of a job's possible work.
+
+     Args:
+         value (Any): The object for this partition",The description predates this diff but I think we can come up with something more grounded.
+5795,"@@ -277,7 +277,17 @@ type VolumeAPISpec struct {
+ 	} `yaml:""metadata""`
+ }
+
+-// -------------Snapshot Structs ----------
++// SnapshotAPISpec hsolds the config for creating asnapshot of volume
++type SnapshotAPISpec struct {
++	Kind       string `yaml:""kind""`
++	APIVersion string `yaml:""apiVersion""`
++	Metadata   struct {
++		Name string `yaml:""name""`
++	} `yaml:""metadata""`
++	Spec struct {
++		VolumeName string `yaml:""volumeName""`
++	} `yaml:""spec""`
++}
+
+ // VolumeSnapshot is volume snapshot object accessible to the user. Upon successful creation of the actual
+ // snapshot by the volume provider it is bound to the corresponding VolumeSnapshotData through","Let the Kind, APIVersion & Metadata follow the rules followed by Volume. What is the reason for a change for snapshot struct ?"
+5796,"@@ -24,14 +24,14 @@ import org.apache.servicecomb.foundation.metrics.registry.GlobalRegistry;
+
+ import com.google.common.eventbus.EventBus;
+ import com.netflix.servo.DefaultMonitorRegistry;
+-import com.netflix.spectator.servo.ServoRegistry;
+
+ public class DefaultRegistryInitializer implements MetricsInitializer {
+   public static final String SERVO_POLLERS = ""servo.pollers"";
+
+   private GlobalRegistry globalRegistry;
+
+-  private ServoRegistry registry;
++  @SuppressWarnings(""deprecation"")
++  private com.netflix.spectator.servo.ServoRegistry registry;
+
+   // create registry before init meters
+   @Override",seems that we did not strong depend servo no need to keep it? change to another one?
+5797,"@@ -142,7 +142,15 @@ boost::property_tree::ptree wait_response (nano::system & system, std::shared_pt
+ void check_block_response_count (nano::system & system, std::shared_ptr<nano::rpc> const & rpc, boost::property_tree::ptree & request, uint64_t size_count)
+ {
+ 	auto response (wait_response (system, rpc, request));
+-	ASSERT_EQ (size_count, response.get_child (""blocks"").front ().second.size ());
++	auto & blocks = response.get_child (""blocks"");
++	if (size_count > 0)
++	{
++		ASSERT_EQ (size_count, blocks.front ().second.size ());
++	}
++	else
++	{
++		ASSERT_TRUE (blocks.empty ());
++	}
+ }
+
+ class scoped_io_thread_name_change",Looks like this used to be UB before with an empty blocks and then calling `.second` on the `.front()`. Did it ever crash though?
+5798,"@@ -121,7 +121,7 @@ function parseRunOn(runOn) {
+ }
+
+ function generateTopologyTests(testSuites, testContext, filter) {
+-  testSuites.forEach(testSuite => {
++  for (const testSuite of testSuites) {
+     // TODO: remove this when SPEC-1255 is completed
+     let runOn = testSuite.runOn;
+     if (!testSuite.runOn) {","Sorry about the code churn here, reworking this use normal loops and async await made debugging far more straight forward. For example, if configuring the fail point fails you find out when stepping over that line vs having to look for the ultimate catch clause that handled it."
+5799,"@@ -56,7 +56,9 @@ const test = (suite, buildConfig = config.defaultBuildConfig, options) => {
+     braveArgs.push('--test-launcher-jobs=' + options.test_launcher_jobs)
+   }
+
++  const args = util.buildArgsToString(config.buildArgs())
+   // Build the tests
++  util.run('gn', ['gen', config.outputDir, '--args=""' + args + '""'], config.defaultOptions)
+   util.run('ninja', ['-C', config.outputDir, suite], config.defaultOptions)
+
+   if (config.targetOS === 'ios') {",this is wrong and should be reverted
+5800,"@@ -120,9 +120,10 @@ func main() {
+ 		log.Fatalf(""Failed to parse usage, exiting: %v"", err)
+ 	}
+ 	buildInfoLogCxt := log.WithFields(log.Fields{
+-		""version"":   buildinfo.GitVersion,
+-		""buildDate"": buildinfo.BuildDate,
+-		""gitCommit"": buildinfo.GitRevision,
++		""version"":    buildinfo.GitVersion,
++		""buildDate"":  buildinfo.BuildDate,
++		""gitCommit"":  buildinfo.GitRevision,
++		""GOMAXPROCS"": runtime.GOMAXPROCS(0),
+ 	})
+ 	buildInfoLogCxt.Info(""Felix starting up"")
+ 	log.Infof(""Command line arguments: %v"", arguments)","I think you'll need to add an import for runtime, before you can merge this PR. (Presumably it was already there for something else when you were working on this, but has since disappeared.)"
+5801,"@@ -74,7 +74,7 @@ import java.util.Set;
+ import static java.util.Collections.singletonList;
+
+ /**
+- * Test class for SyncState.
++ * Test class for SyncManager.
+  */
+ @RunWith(AndroidJUnit4.class)
+ @LargeTest",Unrelated typo fix.
+5802,"@@ -309,6 +309,12 @@ func (r *replacer) getSubstitution(key string) string {
+ 	case ""{dir}"":
+ 		dir, _ := path.Split(r.request.URL.Path)
+ 		return dir
++	case ""{user}"":
++		user, _ := r.request.Context().Value(RemoteUserCtxKey).(string)
++		if user == """" {
++			user = ""-""
++		}
++		return user
+ 	case ""{request}"":
+ 		dump, err := httputil.DumpRequest(r.request, false)
+ 		if err != nil {",I don't think we need an empty value here; any middleware that wants a default value for empty placeholders will pass in what that value should be.
+5803,"@@ -23,7 +23,7 @@ const viewports = require( './viewports' );
+ // This will be passed through with the `backstop` command run with docker.
+ if ( process.argv.includes( '--docker' ) ) {
+ 	const hostname = require( './detect-storybook-host' );
+-	process.argv.push( `--storybook-host=${ hostname }` );
++	process.argv.push( `--storybook-host=http://${ hostname }:9001/` );
+ }
+
+ module.exports = {",Why was this changed?
+5804,"@@ -99,7 +99,7 @@ void KVStoreImpl::init() {
+
+ ResultCode KVStoreImpl::get(GraphSpaceID spaceId, PartitionID partId,
+                             const std::string& key,
+-                            std::string& value) {
++                            std::string* value) {
+     CHECK_AND_RETURN_ENGINE(spaceId, partId);
+     return engine->get(key, value);
+ }","Compared to using traditional enums, I suggest to use `Status` or `StatusOr`, since they are more expressive and informative. Besides, isolating the definitions of error code of individual modules from the ones of the RPC interface is a good practice, isn't it?"
+5805,"@@ -9,11 +9,12 @@ class Acceptance
+   validate :password_if_user_exists, if: :existing_user
+   validate :unused_invitation
+
+-  def initialize(invitation:, current_user: nil, attributes: {})
++  def initialize(invitation:, current_user: Guest.new, attributes: {})
+     @current_user = current_user
+     @invitation = invitation
+-    email = (@current_user || @invitation).email
+-    @attributes = attributes.merge(email: email)
++    @attributes = attributes.merge(
++      email: @current_user.email || @invitation.email,
++    )
+   end
+
+   def save",Use the return of the conditional for variable assignment and comparison.
+5806,"@@ -17,7 +17,9 @@
+
+ from abc import ABCMeta, abstractmethod
+ import os
++from typing import Optional
+ from selenium.webdriver.common.utils import keys_to_typing
++from selenium.types import AnyKey
+
+
+ class FileDetector(metaclass=ABCMeta):","just realised... This breaks things since there is not selenium types module, is there a PR for this?"
+5807,"@@ -9,6 +9,7 @@ package actpool
+ import (
+ 	""bytes""
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""math/big""
+ 	""strings""
+ 	""testing""",move to line 23 below
+5808,"@@ -397,9 +397,7 @@ public class PasscodeManager  {
+      * @param ctx
+      */
+     public void lock(Context ctx) {
+-        locked = true;
+         showLockActivity(ctx, false);
+-        EventsObservable.get().notifyEvent(EventType.AppLocked);
+     }
+
+     /**",the first problem i found in the passcode change flow is that these two lines were happening in 'lock()' but not in 'showLockActivity' which is what the passcode change flow calls. I've just moved them to happen in that method.
+5809,"@@ -326,7 +326,12 @@ class BoundSolidExecutionContext(SolidExecutionContext):
+
+     @property
+     def run_config(self) -> dict:
+-        raise DagsterInvalidPropertyError(_property_msg(""run_config"", ""property""))
++        run_config = {}
++        if self._solid_config:
++            run_config[""solids""] = {self._solid_def.name: self._solid_config}
++        if self.resources:
++            run_config[""resources""] = self.resources._asdict()  # type: ignore[attr-defined]
++        return run_config
+
+     @property
+     def pipeline_def(self) -> PipelineDefinition:","Doing this adds the actual resources themselves to the dictionary. I think for now, there's no way to know what the resource config provided may be, as we don't permit resource config on `build_solid_context`, so this part can be omitted."
+5810,"@@ -0,0 +1,19 @@
++module Subscriber
++  class ResubscriptionsController < ApplicationController
++    def create
++      resubscription = make_resubscription
++      if resubscription.fulfill
++        flash[:notice] = t(""subscriptions.flashes.resubscribe.success"")
++      else
++        flash[:error] = t(""subscriptions.flashes.resubscribe.failure"")
++      end
++      redirect_to my_account_path
++    end
++
++    private
++
++    def make_resubscription
++      Resubscription.new(user: current_user, plan: Plan.professional)
++    end
++  end
++end",1 trailing blank lines detected.
+5811,"@@ -68,6 +68,7 @@ if (global.enableSyncTests) {
+         TESTS.UserTests = require(""./user-tests"");
+         TESTS.SessionTests = require(""./session-tests"");
+         TESTS.UUIDSyncTests= node_require(""./uuid-sync-tests"");
++        TESTS.PartitionValueTests = node_require(""./pv-tests"");
+     }
+ }
+ ","I would personally prefer a filename without an abbreviation, a newcomer to the project wouldn't be able to translate ""pv"" to ""partition-value""."
+5812,"@@ -32,6 +32,10 @@ namespace MvvmCross.Core.ViewModels
+         public static void CallBundleMethod(this IMvxViewModel viewModel, MethodInfo methodInfo, IMvxBundle bundle)
+         {
+             var parameters = methodInfo.GetParameters().ToArray();
++
++            if (bundle == null && parameters.Count() > 0)
++                return;
++
+             if (parameters.Count() == 1
+                 && parameters[0].ParameterType == typeof(IMvxBundle))
+             {",This check looks odd to me. I can't quite grok it. Why is it needed now? What's changed?
+5813,"@@ -228,7 +228,7 @@ func (s *Server) restartJetStream() error {
+ 		MaxStore:  opts.JetStreamMaxStore,
+ 	}
+ 	s.Noticef(""Restarting JetStream"")
+-	err := s.enableJetStream(cfg)
++	err := s.EnableJetStream(&cfg)
+ 	if err != nil {
+ 		s.Warnf(""Can't start JetStream: %v"", err)
+ 		return s.DisableJetStream()",This change is needed because otherwise the path was being changed from `path/store/jetstream` to `path/store/` and files stored differently after re-enabling.
+5814,"@@ -1237,7 +1237,11 @@ describe('Examples', function() {
+       const client = configuration.newClient(configuration.writeConcernMax(), { poolSize: 1 });
+
+       client.connect(function(err, client) {
++        let session;
+         const cleanup = e => {
++          if (session) {
++            session.endSession();
++          }
+           client.close();
+           done(e);
+         };",is this necessary? doesn't `client.close()` imply all sessions will be ended?
+5815,"@@ -19,6 +19,7 @@ package cmd
+
+ import (
+ 	""fmt""
++
+ 	""net""
+ 	""path/filepath""
+ 	""time""","Extra line, it's not needed here."
+5816,"@@ -1,8 +1,10 @@
+ # frozen_string_literal: true
+
+ require 'puppet_pal'
++require 'bolt/pal'
+
+ # Ensure tasks are enabled when rspec-puppet sets up an environment
+ # so we get task loaders.
+ Puppet[:tasks] = true
++Bolt::PAL.load_puppet
+ require 'puppetlabs_spec_helper/module_spec_helper'",Is this OK to add in the spec helper? I need to call `Bolt::PAL.load_puppet` so that I can use the new `Bolt::PAL::Issues` module when verifying that plans forbid functions.
+5817,"@@ -386,6 +386,15 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+         return result;
+     }
+
++    @Override
++    public CharSeq padTo(int length, Character element) {
++        final StringBuilder sb = new StringBuilder(back);
++        for (int i = 0; i < length; i++) {
++            sb.append(element);
++        }
++        return new CharSeq(sb.toString());
++    }
++
+     public CharSeq mapChars(CharUnaryOperator mapper) {
+         Objects.requireNonNull(mapper, ""mapper is null"");
+         if (isEmpty()) {","or is it `i < length - back.length()`? `""12345"".padTo(10, 'a')` should be `12345aaaaa`"
+5818,"@@ -162,7 +162,8 @@ def train_detector(model,
+     # register hooks
+     runner.register_training_hooks(cfg.lr_config, optimizer_config,
+                                    cfg.checkpoint_config, cfg.log_config,
+-                                   cfg.get('momentum_config', None))
++                                   cfg.get('momentum_config', None),
++                                   custom_hooks_config=cfg.get('custom_imports', None))
+     if distributed:
+         if isinstance(runner, EpochBasedRunner):
+             runner.register_hook(DistSamplerSeedHook())",custom_imports -> custom_hooks
+5819,"@@ -34,7 +34,7 @@
+                   <% end %>
+                 </ul>
+               <% else %>
+-                <p><%= raw question[:text][0].gsub(/<tr>(\s|<td>|<\/td>|&nbsp;)*(<\/tr>|<tr>)/,"""") %></p>
++                <p><%= raw question[:text][0].gsub(/<tr>(\s|<td>|<\/td>|&nbsp;)*(<\/tr>|<tr>)/,"""") if question[:text].present? && question[:text][0].present?  %></p>
+               <% end %>
+               <br>
+             <% end %>","I don't get why are we baking new hash structures to represent phases, sections, questions. We are not only loosing the references defined in models but also we have to figure out keys and values for this newly structures."
+5820,"@@ -231,6 +231,10 @@ public class MMapDirectory extends FSDirectory {
+   /** Creates an IndexInput for the file with the given name. */
+   @Override
+   public IndexInput openInput(String name, IOContext context) throws IOException {
++    return openInput(name, context, this.preload);
++  }
++
++  protected IndexInput openInput(String name, IOContext context, boolean preload) throws IOException {
+     ensureOpen();
+     ensureCanRead(name);
+     Path path = directory.resolve(name);",It's somewhat confusing that the `preload` parameter shadows the instance variable; maybe rename the instance variable to `globalPreload` or `preloadDefault` or so to prevent future confusion?
+5821,"@@ -36,6 +36,7 @@ type ScheduledJob struct {
+
+ // ScheduledJobConfig holds the configuration for a scheduled job
+ type ScheduledJobConfig struct {
++	name                    string
+ 	ImageConfig             ImageWithHealthcheck `yaml:""image,flow""`
+ 	ImageOverride           `yaml:"",inline""`
+ 	TaskConfig              `yaml:"",inline""`",Are we setting these values anywhere?
+5822,"@@ -5,8 +5,8 @@
+  */
+
+ #include <gtest/gtest.h>
+-#include <folly/Random.h>
+-#include ""common/base/MurmurHash2.h""
++#include ""base/Base.h""
++#include ""base/MurmurHash2.h""
+
+ namespace vesoft {
+ ",This has to be in front of all other includes
+5823,"@@ -702,8 +702,8 @@ void updateStereoBonds(RWMOL_SPTR product, const ROMol &reactant,
+       Atom *pStart = pBond->getBeginAtom();
+       Atom *pEnd = pBond->getEndAtom();
+
+-      pStart->calcImplicitValence(true);
+-      pEnd->calcImplicitValence(true);
++      pStart->calcImplicitValence(false);
++      pEnd->calcImplicitValence(false);
+
+       if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) {
+         pBond->setStereo(Bond::BondStereo::STEREONONE);",These changes make sense to me. @ricrogz : you wrote (I think ) the original version of this as part of #2553 Do you see any reason to not make the change?
+5824,"@@ -479,7 +479,7 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
+     }
+
+     function getRequestFile() {
+-        var path = self.location.pathname || '';
++        var path = window.self.location.pathname || '';
+
+         var index = path.lastIndexOf('/');
+         if (index !== -1) {",`window.self === window`
+5825,"@@ -474,7 +474,7 @@ func TestSvcInitOpts_Ask(t *testing.T) {
+ 			inDockerfilePath: """",
+
+ 			setupMocks: func(m initSvcMocks) {
+-				m.mockMftReader.EXPECT().ReadWorkloadManifest(wantedSvcName).Return(nil, &workspace.ErrFileNotExists{FileName: wantedSvcName})
++				m.mockMftReader.EXPECT().ReadWorkloadManifest(wantedSvcName).Return(nil, &workspace.ErrWorkspaceNotFound{})
+ 				m.mocktopicSel.EXPECT().Topics(
+ 					gomock.Eq(svcInitPublisherPrompt),
+ 					gomock.Eq(svcInitPublisherHelpPrompt),",maybe we should keep one test case for ErrFileNotExists and update only one file for ErrWorkspaceNotFound?
+5826,"@@ -140,12 +140,7 @@ namespace OpenTelemetry.Trace.Export
+                 this.cts.Dispose();
+                 this.cts = null;
+
+-                // if there are more items, continue until cancellation token allows
+-                while (this.currentQueueSize > 0 && !cancellationToken.IsCancellationRequested)
+-                {
+-                    await this.ExportBatchAsync(cancellationToken).ConfigureAwait(false);
+-                }
+-
++                await this.ForceFlushAsync(cancellationToken);
+                 await this.exporter.ShutdownAsync(cancellationToken);
+
+                 // there is no point in waiting for a worker task if cancellation happens",Please add `ConsigureAwait(false)` here and on `ShutdownAsync` below.
+5827,"@@ -28,8 +28,8 @@ def bad_default(var, default=unknown2):  # [undefined-variable]
+     """"""function with default arg's value set to an nonexistent name""""""
+     print(var, default)
+     print(xxxx)  # [undefined-variable]
+-    augvar += 1  # [undefined-variable]
+-    del vardel  # [undefined-variable]
++    augvar += 1  # [undefined-variable, unused-variable]
++    del vardel  # [undefined-variable, unused-variable]
+
+ LMBD = lambda x, y=doesnotexist: x+y  # [undefined-variable]
+ LMBD2 = lambda x, y: x+z  # [undefined-variable]",Isn't this a false positive? Why are we reporting `unused-variable` on a `del` operation with a `undefined-variable`.
+5828,"@@ -97,7 +97,7 @@ func (client *ClientFake) FindProposals(providerID string) (proposals []dto_disc
+
+ // SendSessionStats heartbeats that session is still active + session upload and download amounts
+ func (client *ClientFake) SendSessionStats(sessionId session.SessionID, sessionStats dto.SessionStats, signer identity.Signer) (err error) {
+-	log.Info(mysteriumAPILogPrefix, ""Session stats sent: "", sessionId)
++	log.Info(mysteriumAPILogPrefix, ""SessionDto stats sent: "", sessionId)
+
+ 	return nil
+ }",Is it correct that `SessionDto` should be here?
+5829,"@@ -103,6 +103,11 @@ func (c *ovsCtlClient) DumpGroups() ([]string, error) {
+ 	return groupList, nil
+ }
+
++func (c *ovsCtlClient) AddMeterEntry(meterId uint32, rate uint32) error {
++	_, err := c.RunOfctlCmd(""add-meter"", fmt.Sprintf(""meter=%d,pktps,band=type=drop,rate=%d"", meterId, rate))
++	return err
++}
++
+ func (c *ovsCtlClient) DumpPortsDesc() ([][]string, error) {
+ 	portsDescDump, err := c.RunOfctlCmd(""dump-ports-desc"")
+ 	if err != nil {","sorry I missed this earlier. We no longer use ovs-ofctl for flow programming AFAIK, why not add this support to ofnet / libOpenflow?"
+5830,"@@ -159,7 +159,10 @@ class Form extends WidgetBase
+      */
+     protected function loadAssets()
+     {
+-        $this->addJs('js/october.form.js', 'core');
++        $this->addJs('js/october.form.js', [
++            'build' => 'core',
++            'cache'  => 'false'
++        ]);
+     }
+
+     /**",Make this consistent with the other definition please `'false'` vs `false`
+5831,"@@ -62,8 +62,13 @@ func CleanupHandler(c <-chan os.Signal) {
+ 	for s := range c {
+ 		debug.Log(""signal %v received, cleaning up"", s)
+ 		fmt.Printf(""%sInterrupt received, cleaning up\n"", ClearLine())
+-		RunCleanupHandlers()
+-		fmt.Println(""exiting"")
+-		os.Exit(0)
++		Exit(0)
+ 	}
+ }
++
++// Exit runs the cleanup handlers and then terminates the process with the
++// given exit code.
++func Exit(code int) {
++	RunCleanupHandlers()
++	os.Exit(code)
++}",I think this is a good way to do it. :+1:
+5832,"@@ -21,7 +21,7 @@ import (
+ 	""os""
+ 	""path/filepath""
+
+-	""github.com/mitchellh/go-homedir""
++	homedir ""github.com/mitchellh/go-homedir""
+ 	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/urfave/cli""
+ )",Why this is needed?
+5833,"@@ -26,11 +26,12 @@ import (
+ )
+
+ // InitializeConnTrackDumper initializes the ConnTrackDumper interface for different OS and datapath types.
+-func InitializeConnTrackDumper(nodeConfig *config.NodeConfig, serviceCIDR *net.IPNet, ovsctlClient ovsctl.OVSCtlClient, ovsDatapathType string) ConnTrackDumper {
++func InitializeConnTrackDumper(nodeConfig *config.NodeConfig, serviceCIDR *net.IPNet, ovsDatapathType string) ConnTrackDumper {
+ 	var connTrackDumper ConnTrackDumper
+ 	if ovsDatapathType == ovsconfig.OVSDatapathSystem {
+ 		connTrackDumper = NewConnTrackSystem(nodeConfig, serviceCIDR)
+ 	} else if ovsDatapathType == ovsconfig.OVSDatapathNetdev {
++		ovsctlClient := ovsctl.NewClient(nodeConfig.OVSBridge)
+ 		connTrackDumper = NewConnTrackOvsAppCtl(nodeConfig, serviceCIDR, ovsctlClient)
+ 	}
+ 	return connTrackDumper",Can we define this directly in the function `NewConnTrackOvsAppCtl` instead of passing this as an argument?
+5834,"@@ -54,6 +54,8 @@ func (s *stream) Write(b []byte) (int, error) {
+ var _ = Describe(""Crypto Setup TLS"", func() {
+ 	var clientConf, serverConf *tls.Config
+
++	// unparam incorrectly complains that the first argument is never used.
++	//nolint:unparam
+ 	initStreams := func() (chan chunk, *stream /* initial */, *stream /* handshake */) {
+ 		chunkChan := make(chan chunk, 100)
+ 		initialStream := newStream(chunkChan, protocol.EncryptionInitial)",False positives are annoying...
+5835,"@@ -0,0 +1,15 @@
++<?php
++
++/**
++ * Copyright © Ergonode Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Multimedia\Infrastructure\Service;
++
++interface SuffixGeneratingServiceInterface
++{
++    public function generateSuffix(string $name, int $iterationIndex): string;
++}","Is the infrastructure layer an appropriate one? I don't think so tbh, more like an application, or even a domain one."
+5836,"@@ -4,12 +4,14 @@
+ using System;
+ using System.Diagnostics;
+ using System.Numerics;
++using System.Runtime.CompilerServices;
+ using System.Threading;
+
+ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Infrastructure
+ {
+     public struct MemoryPoolIterator
+     {
++        private static readonly ulong _powerOfTwoToHighByte = PowerOfTwoToHighByte();
+         private static readonly int _vectorSpan = Vector<byte>.Count;
+
+         private MemoryPoolBlock _block;",Why is this required to turn the static readonlies into jitted const? Is this a bug in the jitter?
+5837,"@@ -2,11 +2,13 @@ from collections import namedtuple
+
+ import traceback
+
+-SerializableErrorInfo = namedtuple('SerializableErrorInfo', 'message stack')
++SerializableErrorInfo = namedtuple('SerializableErrorInfo', 'message stack cls_name')
+
+
+ def serializable_error_info_from_exc_info(exc_info):
+     exc_type, exc_value, exc_tb = exc_info
+     return SerializableErrorInfo(
+-        traceback.format_exception_only(exc_type, exc_value)[0], traceback.format_tb(tb=exc_tb)
++        traceback.format_exception_only(exc_type, exc_value)[0],
++        traceback.format_tb(tb=exc_tb),
++        exc_type.__name__,
+     )","feel free to make this a ""typed"" named tuple (overriding __new__) if you are feeling frisky"
+5838,"@@ -1,6 +1,3 @@
+-import { or } from 'ramda';
+-
+-
+-const MAX_SAFE_INTEGER = or(Number.MAX_SAFE_INTEGER, (2 ** 53) - 1);
++const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (2 ** 53) - 1;
+
+ export default MAX_SAFE_INTEGER;",Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1)
+5839,"@@ -187,7 +187,9 @@ func (d *detector) checkApplication(ctx context.Context, app *model.Application,
+ 	liveManifests = filterIgnoringManifests(liveManifests)
+ 	d.logger.Info(fmt.Sprintf(""application %s has %d live manifests"", app.Id, len(liveManifests)))
+
+-	result, err := provider.DiffList(liveManifests, headManifests,
++	result, err := provider.DiffList(
++		headManifests,
++		liveManifests,
+ 		diff.WithEquateEmpty(),
+ 		diff.WithIgnoreAddingMapKeys(),
+ 		diff.WithCompareNumberAndNumericString(),",The bug was caused by this order change in the last refactoring.
+5840,"@@ -23,6 +23,7 @@ import io
+ import json
+
+ import docker
++from docker.utils import kwargs_from_env
+
+ from molecule import util
+ from molecule.driver import basedriver",This is already imported as docker. You're safe to simply use `docker.utils.kwargs_from_env()` below.
+5841,"@@ -50,6 +50,14 @@ func (ra RunnableActions) Actions() []action.SealedEnvelope {
+ 	return ra.actions
+ }
+
++// AddAction adds actions for block which is building.
++func (ra *RunnableActions) AddAction(act action.SealedEnvelope) {
++	if ra.actions == nil {
++		ra.actions = make([]action.SealedEnvelope, 0)
++	}
++	ra.actions = append(ra.actions, act)
++}
++
+ // RunnableActionsBuilder is used to construct RunnableActions.
+ type RunnableActionsBuilder struct{ ra RunnableActions }
+ ",No need to add this fun. Using RunnableActionsBuilder#AddActions instead
+5842,"@@ -23,6 +23,10 @@ let oldBeforeUnmount = options.unmount;
+ const RAF_TIMEOUT = 100;
+ let prevRaf;
+
++// TODO: these options hooks are also still side-effects and we
++// should minimize side-effects wherever we can, currently compat
++// imports this whole file resulting in a lot of side-effects, would
++// it be better for that reason to integrate hooks into core?
+ options._diff = (internal, vnode) => {
+ 	currentInternal = null;
+ 	if (oldBeforeDiff) oldBeforeDiff(internal, vnode);",I don't think it's possible to do this for hooks
+5843,"@@ -88,7 +88,7 @@ public class SleepJavaJob {
+     System.out.println(""Sec "" + sec);
+     synchronized (this) {
+       try {
+-        this.wait(sec * 1000);
++        this.wait(sec * 1000 + 1);
+       } catch (final InterruptedException e) {
+         System.out.println(""Interrupted "" + this.fail);
+       }",wait(1ms) when sec=0. wait(0ms) waits forever so that's why this is better.
+5844,"@@ -104,8 +104,14 @@ struct listener_ssl_config_t {
+
+ struct listener_config_t {
+     int fd;
++#if defined(__linux__) && defined(SO_REUSEPORT)
++    int domain;
++    int so_reuseport;
++    H2O_VECTOR(int) reuseport_fds;
++#endif
+     struct sockaddr_storage addr;
+     socklen_t addrlen;
++
+     h2o_hostconf_t **hosts;
+     H2O_VECTOR(struct listener_ssl_config_t *) ssl;
+     int proxy_protocol;",Do we need `domain` and `so_reuseport` now that we open new sockets immediately after calling `add_listener`?
+5845,"@@ -34,10 +34,14 @@ public interface HttpClient {
+    * @throws IOException if an I/O error occurs.
+    */
+   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
+-
++
+   /**
+-   * Creates HttpClient instances.
+-   */
++	* Closes the connections associated with this client.
++	*
++	* @throws  IOException  if an I/O error occurs.
++	*/
++  void close() throws IOException;
++
+   interface Factory {
+
+     /**",The formatting seems different from the rest of the code
+5846,"@@ -0,0 +1,18 @@
++package paramhelper
++
++import (
++	""fmt""
++	""strings""
++)
++
++// GetRegion extracts region from a zones
++func GetRegion(zone string) (string, error) {
++	if zone == """" {
++		return """", fmt.Errorf(""zone is empty. Can't determine region"")
++	}
++	zoneStrs := strings.Split(zone, ""-"")
++	if len(zoneStrs) < 2 {
++		return """", fmt.Errorf(""%v is not a valid zone"", zone)
++	}
++	return strings.Join(zoneStrs[:len(zoneStrs)-1], ""-""), nil
++}","What about calling this package ""parameters""? utils\parameters are utils related to parameters."
+5847,"@@ -20,7 +20,7 @@ describe Topic do
+     end
+
+     it 'generates a stripped, url encoded slug based on name' do
+-      @topic.slug.should == 'test+driven+development'
++      expect(@topic.slug).to eq 'test+driven+development'
+     end
+   end
+ ",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+5848,"@@ -52,10 +52,10 @@ public class PublicKeySubCommandTest extends CommandTestAbstract {
+           + System.lineSeparator()
+           + ""This command outputs the node public key. Default output is standard output.""
+           + System.lineSeparator()
+-          + ""      --to=<FILE>   File to write public key to instead of standard output""
+-          + System.lineSeparator()
+           + ""  -h, --help        Show this help message and exit.""
+           + System.lineSeparator()
++          + ""      --to=<FILE>   File to write public key to instead of standard output""
++          + System.lineSeparator()
+           + ""  -V, --version     Print version information and exit.""
+           + System.lineSeparator();
+ ",what is the actual difference here?
+5849,"@@ -96,6 +96,12 @@ public final class DefaultOAuth2AuthorizationRequestResolver implements OAuth2Au
+ 		if (registrationId == null) {
+ 			return null;
+ 		}
++		String[] params = new String[0];
++		if (registrationId.contains(""?"")) {
++			String[] explodedURI = registrationId.split(""\\?"");
++			registrationId = registrationId.split(""\\?"")[0];
++			params = explodedURI[1].split(""&"");
++		}
+
+ 		ClientRegistration clientRegistration = this.clientRegistrationRepository.findByRegistrationId(registrationId);
+ 		if (clientRegistration == null) {",Parsing URLs is hard. Any fixes should avoid manually parsing the URL.
+5850,"@@ -22,7 +22,7 @@ module RSpec
+         end
+
+         def example_group_finished(_notification)
+-          @group_level -= 1
++          @group_level =  @group_level > 0 ? @group_level - 1 : @group_level
+         end
+
+         def example_passed(passed)","This is a private api, it doesn't need to return anything so `@group_level -= 1 if @group_level > 0` is preferred."
+5851,"@@ -432,14 +432,14 @@ NativeHashedStorageHandler::NativeHashedStorageHandler(
+   if (!m_process)
+     return;
+
+-  auto key_stride = key_type.GetByteStride();
++  auto key_stride = key_type.GetByteStride(m_process);
+   if (key_stride) {
+     m_key_stride = *key_stride;
+     m_key_stride_padded = *key_stride;
+   }
+
+   if (value_type) {
+-    auto value_type_stride = value_type.GetByteStride();
++    auto value_type_stride = value_type.GetByteStride(m_process);
+     m_value_stride = value_type_stride ? *value_type_stride : 0;
+     if (SwiftASTContext *swift_ast =
+             llvm::dyn_cast_or_null<SwiftASTContext>(key_type.GetTypeSystem())) {",".GetValueOr(0) ... but really, shouldn't m_value_strife also be optional?"
+5852,"@@ -256,7 +256,7 @@ module.exports = class Tus extends Plugin {
+         }
+       }
+
+-      /** @type {{ [name: string]: string }} */
++      /** @type {Record<string, string>} */
+       const meta = {}
+       const metaFields = Array.isArray(opts.metaFields)
+         ? opts.metaFields",Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing
+5853,"@@ -17,11 +17,11 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+         private static readonly WaitCallback _completePending = CompletePending;
+         protected readonly FrameContext _context;
+
+-        object _sync = new Object();
++        private object _sync = new Object();
+
+-        ArraySegment<byte> _buffer;
+-        Queue<ReadOperation> _reads = new Queue<ReadOperation>();
+-        bool _send100Continue = true;
++        private ArraySegment<byte> _buffer;
++        private Queue<ReadOperation> _reads = new Queue<ReadOperation>();
++        private bool _send100Continue = true;
+
+         public MessageBodyExchanger(FrameContext context)
+         {",Should be readonly
+5854,"@@ -14,7 +14,7 @@ import unittest
+ from rdkit import RDConfig
+ from rdkit import Chem
+ from rdkit.Chem import FragmentCatalog, BuildFragmentCatalog
+-from rdkit.six.moves import cPickle
++from rdkit.six.moves import cPickle  # @UnresolvedImport
+
+
+ def feq(n1, n2, tol=1e-4):","I'm not going to stop accepting the PR, but I really hate these artifacts getting dropped in the Python code just to stop things like coverage checkers and linters from complaining."
+5855,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright 2016 The Kythe Authors. All rights reserved.
++ * Copyright 2020 The Kythe Authors. All rights reserved.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.","FYI modifying an existing file generally doesn't invalidate the copyright date. The date here is when the copy right _begins_, so moving it later is arguably misleading-it still applies. Not a big deal, just something I've seen a few times in passing."
+5856,"@@ -106,7 +106,7 @@ public class BaseServer<T extends BaseServer> implements Server<T> {
+       FilterHolder
+           filterHolder = servletContextHandler.addFilter(CrossOriginFilter.class, ""/*"", EnumSet
+           .of(DispatcherType.REQUEST));
+-      filterHolder.setInitParameter(""allowedOrigins"", ""*"");
++      filterHolder.setInitParameter(""allowedMethods"", ""GET,POST,PUT,DELETE,HEAD"");
+
+       // Warning user
+       LOG.warning(""You have enabled CORS requests from any host. ""","Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all."
+5857,"@@ -449,6 +449,10 @@ public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, Supp
+   Database convertToDatabase(Namespace namespace, Map<String, String> meta) {
+     String warehouseLocation = conf.get(""hive.metastore.warehouse.dir"");
+
++    Preconditions.checkNotNull(
++            warehouseLocation,
++            ""Warehouse location is not set: hive.metastore.warehouse.dir=null"");
++
+     if (!isValidateNamespace(namespace)) {
+       throw new NoSuchNamespaceException(""Namespace does not exist: %s"", namespace);
+     }",Style: indentation should be 4 spaces (2 indents) from the start of `Preconditions`.
+5858,"@@ -587,8 +587,15 @@ class AdminController extends Controller
+         foreach ($entityProperties as $name => $metadata) {
+             $formFieldOptions = $metadata['type_options'];
+
+-            if ('association' === $metadata['fieldType'] && in_array($metadata['associationType'], array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY))) {
+-                continue;
++            if ('association' === $metadata['type']) {
++                // *-to-many associations are not supported yet
++                $toManyAssociations = array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY);
++                if (in_array($metadata['associationType'], $toManyAssociations)) {
++                    continue;
++                }
++
++                // supported associations are displayed using advanced JavaScript widgets
++                $formFieldOptions['attr']['data-use-js-widget'] = 'true';
+             }
+
+             if ('collection' === $metadata['fieldType']) {","I don't know why I suggested a html attribute at first (my bad), or maybe you think it makes sense. Otherwise, what about a simple class ?"
+5859,"@@ -122,6 +122,9 @@ module DMPRoadmap
+       config.branding = config_for(:branding).deep_symbolize_keys
+     end
+
++    # org abbreviation for the root google analytics tracker that gets planted on every page
++    config.tracker_root = ""UoE""
++
+     # The default visibility setting for new plans
+     #   organisationally_visible  - Any member of the user's org can view, export and duplicate the plan
+     #   publicly_visibile         - (NOT advisable because plans will show up in Public DMPs page by default)",Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default.
+5860,"@@ -72,12 +72,13 @@ namespace NLog.Config
+                 }
+                 catch (Exception exception)
+                 {
++                    InternalLogger.Error(exception, ""Failed to add type '{0}'."", t.FullName);
++
+                     if (exception.MustBeRethrown())
+                     {
+                         throw;
+                     }
+-
+-                    InternalLogger.Error(""Failed to add type '"" + t.FullName + ""': {0}"", exception);
++
+                 }
+             }
+         }",Must this not change to `MustBeRethrownImmediately`?
+5861,"@@ -30,11 +30,6 @@ import (
+
+ var (
+ 	pluginName = ""antrea-octant-plugin""
+-	client     *clientset.Clientset
+-	graph      = """"
+-	lastTf     = opsv1alpha1.Traceflow{
+-		ObjectMeta: v1.ObjectMeta{Name: """"},
+-	}
+ )
+
+ const (",Can it be pointer?
+5862,"@@ -303,11 +303,11 @@ export const refreshAuthentication = async () => {
+ 		} );
+
+ 		// We should really be using state management. This is terrible.
+-		window.googlesitekit.setup = window.googlesitekit.setup || {};
+-		window.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
+-		window.googlesitekit.setup.requiredScopes = response.requiredScopes;
+-		window.googlesitekit.setup.grantedScopes = response.grantedScopes;
+-		window.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;
++		global.googlesitekit.setup = global.googlesitekit.setup || {};
++		global.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
++		global.googlesitekit.setup.requiredScopes = response.requiredScopes;
++		global.googlesitekit.setup.grantedScopes = response.grantedScopes;
++		global.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;
+ 	} catch ( e ) { // eslint-disable-line no-empty
+ 	}
+ };",Not related to this issue but this condition seems weak.
+5863,"@@ -58,7 +58,12 @@ trait MarcReaderTrait
+     public function getMarcRecord()
+     {
+         if (null === $this->lazyMarcRecord) {
+-            $marc = trim($this->fields['fullrecord']);
++            // Get preferred MARC field from config, if it is set and is existing:
++            $marcField = (isset($this->mainConfig->Record->preferredMarcField)
++                    && array_key_exists($this->mainConfig->Record->preferredMarcField, $this->fields))
++                ? $this->mainConfig->Record->preferredMarcField : 'fullrecord';
++
++            $marc = trim($this->fields[$marcField]);
+
+             // check if we are dealing with MARCXML
+             if (substr($marc, 0, 1) == '<') {",I think this might be a little more readable in two lines as: <pre> $preferredMarcField = $this->mainConfig->Record->preferredMarcField ?? 'fullrecord'; $marc = trim($this->fields[$preferredMarcField] ?? $this->fields['fullrecord']); </pre>
+5864,"@@ -21,8 +21,9 @@ from . import packer
+ from . import compat
+ from .compat import range_func
+ from .compat import memoryview_type
++from .compat import import_numpy, NumpyRequiredForThisFeature
+
+-
++np = import_numpy()
+ ## @file
+ ## @addtogroup flatbuffers_python_api
+ ## @{",does this still allow this file to be used with Python installations that don't have numpy?
+5865,"@@ -96,7 +96,7 @@ class BazelBuildFileView {
+     String goImport = """";
+     if (isCloud) {
+       goImport = ""cloud.google.com/go/"";
+-      goPkg = goPkg.replaceFirst(""v(.+);"", ""apiv$1;"");
++      goPkg = goPkg.replaceFirst(""\\/v([a-z1-9]+);"", ""\\/apiv$1;"");
+     } else {
+       goImport = ""google.golang.org/"";
+       String pkgName = goPkg.split("";"")[1];","what about 0? Version probably can' start with 0, but v10 is theoretically possible."
+5866,"@@ -52,5 +52,17 @@ namespace Microsoft.VisualStudio.TestPlatform.Utilities.Helpers
+         {
+             return new FileInfo(path).Attributes;
+         }
++
++        /// <inheritdoc/>
++        public bool IsRootedPath(string path)
++        {
++            return Path.IsPathRooted(path);
++        }
++
++        /// <inheritdoc/>
++        public string CombinePath(string source)
++        {
++            return Path.Combine(Directory.GetCurrentDirectory(), source);
++        }
+     }
+ }","Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily. `Path.IsRootedPath` doesn't access the file system. It is string comparison I believe."
+5867,"@@ -276,7 +276,7 @@ spec:
+       iqn: iqn.2016-09.com.openebs.cstor:{{ .Volume.owner }}
+       targetPortal: {{ .TaskResult.cvolcreateputsvc.clusterIP }}:3260
+       targetPort: 3260
+-      status: """"
++      status: ""Init""
+       replicationFactor: {{ $replicaCount }}
+       consistencyFactor: {{ div $replicaCount 2 | floor | add1 }}
+ ---",Do we need to use quote? Why not `status: Init`
+5868,"@@ -20,10 +20,6 @@ from pylint import checkers, interfaces
+ from pylint.checkers import utils
+
+
+-def _is_constant_empty_str(node):
+-    return isinstance(node, nodes.Const) and node.value == """"
+-
+-
+ class CompareToEmptyStringChecker(checkers.BaseChecker):
+     """"""Checks for comparisons to empty string.
+     Most of the times you should use the fact that empty strings are false.","Nice catch ! I don't think I would have caught that, did you search the whole code base for pre-existing functions ?"
+5869,"@@ -1052,6 +1052,19 @@ func TestClusterDeploymentReconcile(t *testing.T) {
+ 				}
+ 			},
+ 		},
++		{
++			name: ""Add cluster region label"",
++			existing: []runtime.Object{
++				testClusterDeploymentWithoutRegionLabel(),
++			},
++			validate: func(c client.Client, t *testing.T) {
++				cd := getCD(c)
++				if assert.NotNil(t, cd, ""missing clusterdeployment"") {
++					//					assert.Equal(t, getClusterRegion(cd), cd.Labels[hivev1.HiveClusterRegionLabel], ""incorrect cluster region label"")
++					assert.Equal(t, getClusterRegion(cd), ""us-east-1"", ""incorrect cluster region label"")
++				}
++			},
++		},
+ 		{
+ 			name: ""Ensure cluster metadata set from provision"",
+ 			existing: []runtime.Object{",Remove this line.
+5870,"@@ -964,12 +964,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [Fact]
+         public async Task ContentLength_Received_SingleDataFrameUnderSize_Reset()
+         {
+-            // I hate doing this, but it avoids exceptions from MemoryPool.Dipose() in debug mode. The problem is since
+-            // the stream's ProcessRequestsAsync loop is never awaited by the connection, it's not really possible to
+-            // observe when all the blocks are returned. This can be removed after we implement graceful shutdown.
+-            Dispose();
+-            InitializeConnectionFields(new DiagnosticMemoryPool(KestrelMemoryPool.CreateSlabMemoryPool(), allowLateReturn: true));
+-
+             var headers = new[]
+             {
+                 new KeyValuePair<string, string>(HeaderNames.Method, ""POST""),","This is no longer called in any of our unit tests, right?"
+5871,"@@ -67,7 +67,7 @@ type rule struct {
+ 	// Priority of the NetworkPolicy to which this rule belong. nil for K8s NetworkPolicy.
+ 	PolicyPriority *float64
+ 	// Priority of the tier that the NetworkPolicy belongs to. nil for K8s NetworkPolicy.
+-	TierPriority *v1beta1.TierPriority
++	TierPriority *uint32
+ 	// Targets of this rule.
+ 	AppliedToGroups []string
+ 	// The parent Policy ID. Used to identify rules belong to a specified","I think typically K8s APIs will use `int32` and not `uint32`. I think we should keep it consistent with the rule `Priority` above. I believe that the rationale for using `int32` in general is: * some programming languages don't have native support for unsigned integers * it's easier to catch sign errors with signed integers, depending on the programming language (it it's negative, it's clearly an error but if it's a very large number, it could be normal or it could be a negative number overflow)"
+5872,"@@ -0,0 +1,7 @@
++class AddStartAndEndDatesToPlans < ActiveRecord::Migration
++  def change
++    add_column :plans, :grant_id, :integer, index: true
++    add_column :plans, :start_date, :datetime
++    add_column :plans, :end_date, :datetime
++  end
++end","If you end up changing grant to an association, this may need to change to a reference to enforce the foreign_key `add_reference :plans, :grant`"
+5873,"@@ -74,7 +74,7 @@ class DashboardModulesAlerts extends Component {
+ 						title={ notification.title || '' }
+ 						description={ notification.description || '' }
+ 						blockData={ notification.blockData || [] }
+-						winImage={ notification.winImage ? `${ global._googlesitekitLegacyData.admin.assetsRoot }images/${ notification.winImage }` : '' }
++						WinImageSVG={ notification.WinImageSVG }
+ 						format={ notification.format || 'small' }
+ 						learnMoreURL={ notification.learnMoreURL || '' }
+ 						learnMoreDescription={ notification.learnMoreDescription || '' }",This won't work because `notification` comes from an API response here. I think this would be the same as the change to `Alert` where it would get `SmallSunSVG`.
+5874,"@@ -120,6 +120,10 @@ func TestEnvironmentConfig(t *testing.T) {
+ 	additionalLocalRoutesJSON := `[""1.2.3.4/22"",""5.6.7.8/32""]`
+ 	os.Setenv(""ECS_AWSVPC_ADDITIONAL_LOCAL_ROUTES"", additionalLocalRoutesJSON)
+ 	defer os.Unsetenv(""ECS_AWSVPC_ADDITIONAL_LOCAL_ROUTES"")
++	os.Setenv(""ECS_ENABLE_CONTAINER_METADATA"", ""true"")
++	os.Setenv(""ECS_HOST_DATA_DIR"", ""/etc/ecs/"")
++	defer os.Unsetenv(""ECS_ENABLE_CONTAINER_METADATA"")
++	defer os.Unsetenv(""ECS_HOST_DATA_DIR"")
+
+ 	conf, err := environmentConfig()
+ 	assert.NoError(t, err)",This is not checked below?
+5875,"@@ -218,6 +218,19 @@ func (c *CloudFormation) TemplateBodyFromChangeSet(changeSetID, stackName string
+ 	return aws.StringValue(out.TemplateBody), nil
+ }
+
++// Outputs returns the outputs of a stack description.
++func (c *CloudFormation) Outputs(stack *Stack) (map[string]string, error) {
++	stackDescription, err := c.Describe(stack.Name)
++	if err != nil {
++		return nil, fmt.Errorf(""retrieve outputs of stack description: %w"", err)
++	}
++	outputs := make(map[string]string)
++	for _, output := range stackDescription.Outputs {
++		outputs[*output.OutputKey] = *output.OutputValue
++	}
++	return outputs, nil
++}
++
+ // Events returns the list of stack events in **chronological** order.
+ func (c *CloudFormation) Events(stackName string) ([]StackEvent, error) {
+ 	return c.events(stackName, func(in *cloudformation.StackEvent) bool { return true })","Will this ever return a ""Stack does not exist"" error? Should we handle it silently here rather than making higher level packages do error checking?"
+5876,"@@ -1,11 +1,11 @@
+-from .data_transfer import copy_file, get_bytes, delete_url, list_url
+-from .packages import Package
++from .backends import get_package_registry
++from .data_transfer import copy_file
+ from .search_util import search_api
+ from .util import (QuiltConfig, QuiltException, CONFIG_PATH,
+                    CONFIG_TEMPLATE, configure_from_default, config_exists,
+-                   configure_from_url, fix_url, get_package_registry,
++                   configure_from_url, fix_url,
+                    load_config, PhysicalKey, read_yaml, validate_package_name,
+-                   write_yaml, get_from_config)
++                   write_yaml)
+ from .telemetry import ApiTelemetry
+
+ ","minor: at this scale, one import per line reads better"
+5877,"@@ -183,7 +183,7 @@ ActiveRecord::Schema.define(version: 20180508151824) do
+     t.string   ""logo_name""
+     t.string   ""contact_email""
+     t.integer  ""org_type"",               default: 0,              null: false
+-    t.text     ""links"",                  default: ""{\""org\"":[]}""
++    t.text     ""links""
+     t.string   ""contact_name""
+     t.boolean  ""feedback_enabled"",       default: false
+     t.string   ""feedback_email_subject""",Should remove the default templates as well.
+5878,"@@ -18,14 +18,14 @@ const stream = require('webpack-stream');
+ const inject = require('gulp-inject');
+ const postcss = require('gulp-postcss');
+ const sass = require('gulp-sass');
+-
+-sass.compiler = require('node-sass')
+
++sass.compiler = require('node-sass');
+
++var config;
+ if (mode.production()) {
+-    var config = require('./webpack.prod.js');
++    config = require('./webpack.prod.js');
+ } else {
+-    var config = require('./webpack.dev.js');
++    config = require('./webpack.dev.js');
+ }
+
+ function serve() {",Why not `let`?
+5879,"@@ -49,6 +49,8 @@ public class ZipkinServer {
+     new SpringApplicationBuilder(ZipkinServer.class)
+       .banner(new ZipkinBanner())
+       .initializers(new ZipkinModuleImporter(), new ZipkinActuatorImporter())
++      // Avoids potentially expensive ns lookup and inaccurate startup timing
++      .logStartupInfo(false)
+       .properties(
+         EnableAutoConfiguration.ENABLED_OVERRIDE_PROPERTY + ""=false"",
+         ""spring.config.name=zipkin-server"").run(args);",ns -> DNS My first reading was this is referring to System.nanoTime and thought hrm?
+5880,"@@ -55,6 +55,7 @@ class ScheduleInstigatorData(
+             # `start_date` on partition-based schedules, which is used to define
+             # the range of partitions)
+             check.opt_float_param(start_timestamp, ""start_timestamp""),
++            # this is a vestigial parameter that is not used and will be removed in the future
+             check.opt_str_param(scheduler, ""scheduler""),
+         )
+ ",is there a reason not to remove the param now? I think the serdes will still work?
+5881,"@@ -39,6 +39,8 @@ class TestBasic(unittest.TestCase):
+         self.assertEqual(bst.current_iteration(), 20)
+         self.assertEqual(bst.num_trees(), 20)
+         self.assertEqual(bst.num_model_per_iteration(), 1)
++        self.assertAlmostEqual(bst.upper_bound(), 3.32, places=2)
++        self.assertAlmostEqual(bst.lower_bound(), -3.13, places=2)
+
+         bst.save_model(""model.txt"")
+         pred_from_matr = bst.predict(X_test)",`places=2` seems to be very poor comparison. Do you have any thoughts why is it fail with more strict checks?
+5882,"@@ -213,6 +213,7 @@ public class ProjectManager {
+       fetchedProject = this.projectsByName.get(name);
+     } else {
+       try {
++        logger.info(""Project "" + name + "" doesn't exist in cache, fetching from DB now."");
+         fetchedProject = this.projectLoader.fetchProjectByName(name);
+       } catch (final ProjectManagerException e) {
+         logger.error(""Could not load project from store."", e);","should we make level debug? Also just FYI, with debug level, we can add more detailed logging for better debuggability without concerning overwhelming logging message"
+5883,"@@ -20,14 +20,16 @@
+ # ----------------------------------------------------------------------
+
+ """"""
+-## @file
+-stats.py defines functions and data structures related to statistical analysis.
++Module of statistical data structures and functions used in learning algorithms
++and for analysis of HTM network inputs and outputs.
+ """"""
+
+ import random
+
+ import numpy
+
++from nupic.bindings.math import GetNTAReal, SparseMatrix
++
+
+ dtype = GetNTAReal()
+ ",I needed to add this import for Sphinx to inspect C++ runtime objects properly. This should be the only code change in this PR.
+5884,"@@ -1,6 +1,8 @@
+ import colander
+
+ from cliquet import resource
++from cliquet.events import ResourceChanged, ACTIONS
++from pyramid.events import subscriber
+
+ from kinto.views import NameGenerator
+ ","Changes in this file aren't related to the PR, are they? You took the opportunity to change the group deletion to using the subscriber too?"
+5885,"@@ -150,6 +150,19 @@ public class MetricsModes {
+     }
+   }
+
++  /**
++   * Auto promote sorted columns to truncate(16) if default is set at Counts or None.
++   * @param defaultMode default mode
++   * @return mode to use
++   */
++  public static MetricsMode promoteSortedColumnDefault(MetricsMode defaultMode) {
++    if (defaultMode == None.get() || defaultMode == Counts.get()) {
++      return Truncate.withLength(16);
++    } else {
++      return defaultMode;
++    }
++  }
++
+   // we cannot serialize/deserialize MetricsMode directly as it breaks reference equality used in metrics utils
+   private abstract static class ProxySerializableMetricsMode implements MetricsMode {
+     Object writeReplace() throws ObjectStreamException {",I'd probably move this into `MetricsConfig` as a private method. Seems like we only use it there.
+5886,"@@ -93,7 +93,7 @@ class Lint(base.Base):
+     ),
+ )
+ def lint(ctx, scenario_name):  # pragma: no cover
+-    """""" Lint the role. """"""
++    """""" Lint the role (dependency, lint). """"""
+     args = ctx.obj.get('args')
+     subcommand = base._get_subcommand(__name__)
+     command_args = {'subcommand': subcommand}",Not clear here what you mean with this list
+5887,"@@ -190,6 +190,7 @@ public class IcebergDecoder<D> extends MessageDecoder.BaseDecoder<D> {
+    * @return true if the buffer is complete, false otherwise (stream ended)
+    * @throws IOException if there is an error while reading
+    */
++  @SuppressWarnings(""checkstyle:InnerAssignment"")
+   private boolean readFully(InputStream stream, byte[] bytes)
+       throws IOException {
+     int pos = 0;","Curious, is there a way we can get around this without suppressing?"
+5888,"@@ -131,6 +131,7 @@ func (manager *Manager) Create(consumerID identity.Identity, issuerID identity.I
+ 	sessionInstance.ConsumerID = consumerID
+ 	sessionInstance.done = make(chan struct{})
+ 	sessionInstance.Config = config
++	sessionInstance.ProposalID = proposalID
+ 	sessionInstance.CreatedAt = time.Now().UTC()
+
+ 	balanceTracker, err := manager.balanceTrackerFactory(consumerID, identity.FromAddress(manager.currentProposal.ProviderID), issuerID)","I don't think we this field in session, it's a serial number for proposal but not unique index itself"
+5889,"@@ -42,6 +42,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+             }
+         }
+
++        [Benchmark(Baseline = true, OperationsPerInvoke = RequestParsingData.InnerLoopCount)]
++        public void PlaintextAbsoluteUri()
++        {
++            for (var i = 0; i < RequestParsingData.InnerLoopCount; i++)
++            {
++                InsertData(RequestParsingData.PlaintextAbsoluteUriRequest);
++                ParseData();
++            }
++        }
++
+         [Benchmark(OperationsPerInvoke = RequestParsingData.InnerLoopCount * RequestParsingData.Pipelining)]
+         public void PipelinedPlaintextTechEmpower()
+         {",Can't have two benchmarks with `Baseline = true`
+5890,"@@ -0,0 +1,19 @@
++
++import { wpApiFetch } from './wp-api-fetch';
++
++import { testClientConfig } from './test-client-config';
++
++/**
++ *
++ * @param {*} config
++ */
++export async function setClientConfig( config = testClientConfig ) {
++	return await wpApiFetch( {
++		path: 'google-site-kit/v1/e2e/auth/client-config',
++		method: 'post',
++		data: {
++			clientID: config.web.client_id,
++			clientSecret: config.web.client_secret,
++		},
++	} );
++}",Same here: Empty line before and no `Internal dependencies` docblock (mandatory anyway once #217 lands).
+5891,"@@ -59,7 +59,7 @@ func newAddCommand(root *command) *cobra.Command {
+
+ 	cmd.Flags().StringVar(&c.repoID, ""repo-id"", c.repoID, ""The repository ID. One the registered repositories in the piped configuration."")
+ 	cmd.Flags().StringVar(&c.appDir, ""app-dir"", c.appDir, ""The relative path from the root of repository to the application directory."")
+-	cmd.Flags().StringVar(&c.configFileName, ""config-file-name"", c.configFileName, ""The configuration file name. Default is .pipe.yaml"")
++	cmd.Flags().StringVar(&c.configFileName, ""config-file-name"", c.configFileName, ""The configuration file name"")
+ 	cmd.Flags().StringVar(&c.description, ""description"", c.description, ""The description of the application."")
+
+ 	cmd.MarkFlagRequired(""app-name"")","sorry, the default value for this field is no longer allowed?"
+5892,"@@ -308,10 +308,10 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+         [Fact]
+         public void UnauthorizedAccessExceptionCreatingSarifLog()
+         {
+-            string path = Environment.GetFolderPath(Environment.SpecialFolder.Windows);
++            string path = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
+             path = Path.Combine(path, Guid.NewGuid().ToString());
+
+-            try
++            using (var stream = File.Create(path, 1, FileOptions.DeleteOnClose))
+             {
+                 // attempt to persist to unauthorized location will raise exception
+                 var options = new TestAnalyzeOptions()",Why does this work? I'd've expected that an admin could create a file anywhere.
+5893,"@@ -53,7 +53,7 @@ module Travis
+
+         def script
+           if config[:solution]
+-            sh.cmd ""xbuild #{config[:solution]}"", timing: true if config[:solution]
++            sh.cmd ""xbuild /p:Configuration=#{config[:configuration] || 'Release'} /p:Platform=\""#{config[:platform] || 'x64'}\"" #{config[:solution]}"", timing: true if config[:solution]
+           else
+             sh.echo 'No solution or script defined, exiting', ansi: :red
+             sh.cmd 'false', echo: false, timing: false",falling back to `x64` seems like a really bad idea given that the VS templates default to x86 these days.
+5894,"@@ -356,7 +356,7 @@ class TestBokehPlotInstantiation(ComparisonTestCase):
+     def tearDown(self):
+         Store.current_backend = self.previous_backend
+         Callback._comm_type = comms.JupyterCommJS
+-        mpl_renderer.comms['default'] = self.default_comm
++        bokeh_renderer.comms['default'] = self.default_comm
+         Callback._callbacks = {}
+
+     def test_overlay_legend(self):",Bit surprised by this. I would have thought either you want to set it for both mpl and bokeh...or alternatively it was only ever meant for bokeh and was always wrong?
+5895,"@@ -490,6 +490,8 @@ given file (report RP0402 must not be disabled)'}
+                 importedname = node.modname
+             else:
+                 importedname = node.names[0][0].split('.')[0]
++        if node.as_string().startswith('from .'):
++            importedname = '.' + importedname
+         self._imports_stack.append((node, importedname))
+
+     @staticmethod","Check modname instead, but only if it's a ImportFrom."
+5896,"@@ -92,6 +92,13 @@ public class TableProperties {
+   public static final String METADATA_COMPRESSION = ""write.metadata.compression-codec"";
+   public static final String METADATA_COMPRESSION_DEFAULT = ""none"";
+
++  public static final String PREVIOUS_METADATA_LOG_MAX_COUNT = ""write.metadata.previous-log-max-count"";
++  public static final int PREVIOUS_METADATA_LOG_MAX_COUNT_DEFAULT = 100;
++
++  // This enables to delete the oldest metadata file after commit.
++  public static final String METADATA_DELETE_AFTER_COMMIT_ENABLED = ""write.metadata.delete-after-commit.enabled"";
++  public static final boolean METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT = false;
++
+   public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics.column."";
+   public static final String DEFAULT_WRITE_METRICS_MODE = ""write.metadata.metrics.default"";
+   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = ""truncate(16)"";",How about `write.metadata.previous-versions-max`? No need to refer to these as a log.
+5897,"@@ -36,6 +36,7 @@ RSpec.configure do |config|
+   end
+
+   config.filter_run_excluding appveyor_agents: true unless ENV['APPVEYOR_AGENTS']
++  config.filter_run_excluding windows: true unless ENV['BOLT_WINDOWS']
+
+   # rspec-mocks config
+   config.mock_with :rspec do |mocks|","We generally do this via tags in the Rakefile, not separate environment variables."
+5898,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename
+5899,"@@ -369,7 +369,13 @@ class CLAModel(Model):
+     results.inferences = {}
+     self._input = inputRecord
+
+-    # -------------------------------------------------------------------------
++    # Check if the input includes the predicted field.
++    if not self._predictedFieldName in self._input:
++      raise ValueError(""Expected predicted field '%s' in input row, ""
++                       ""but was not found! Raw input is: %s""
++                       % (self._predictedFieldName, self._input))
++
++
+     # Turn learning on or off?
+     if '_learning' in inputRecord:
+       if inputRecord['_learning']:",`if X not in Y:`
+5900,"@@ -79,7 +79,7 @@ public class TestHiveShell {
+
+   public void start() {
+     // Create a copy of the HiveConf for the metastore
+-    metastore.start(new HiveConf(hs2Conf));
++    metastore.start(new HiveConf(hs2Conf), 10);
+     hs2Conf.setVar(HiveConf.ConfVars.METASTOREURIS, metastore.hiveConf().getVar(HiveConf.ConfVars.METASTOREURIS));
+     hs2Conf.setVar(HiveConf.ConfVars.METASTOREWAREHOUSE,
+         metastore.hiveConf().getVar(HiveConf.ConfVars.METASTOREWAREHOUSE));","Do we know why the pool is exhausted? In the past, we had a few leaks in the Spark catalog code which led to this. It can be also a valid use case too if we simply need a larger pool."
+5901,"@@ -228,6 +228,11 @@ module Bolt
+       # Set console log to debug if in debug mode
+       if options[:debug]
+         overrides['log'] = { 'console' => { 'level' => :debug } }
++      elsif options[:verbose]
++        configured_level = overrides.dig('log', 'console', 'level')
++        if configured_level.nil? || Bolt::Logger.lower_level?(:notice, configured_level)
++          overrides['log'] = { 'console' => { 'level' => :notice } }
++        end
+       end
+
+       if options[:puppetfile_path]","Logging in Bolt still seems to be a little messy. I think this is more correct than what I had before, but made sure I wouldn't overwrite an existing level. And if console logging gets more options, both debug and verbose need to be fixed here."
+5902,"@@ -7,6 +7,13 @@ std::shared_ptr<request_type> nano::work_peer_request::get_prepared_json_request
+ 	auto request (std::make_shared<boost::beast::http::request<boost::beast::http::string_body>> ());
+ 	request->method (boost::beast::http::verb::post);
+ 	request->set (boost::beast::http::field::content_type, ""application/json"");
++	auto address_string (address.to_string ());
++	auto pos (address_string.find (""::ffff:""));
++	if (pos != std::string::npos)
++	{
++		address_string.replace (pos, 7, """");
++	}
++	request->set (boost::beast::http::field::host, address_string);
+ 	request->target (""/"");
+ 	request->version (11);
+ 	request->body () = request_string_a;","This could be simplified (if including <boost/algorithm/string/erase.hpp> is fine): `auto address_string = boost::algorithm::erase_first_copy (address.to_string (), ""::ffff:"");`"
+5903,"@@ -304,7 +304,7 @@ public class DefaultGridRegistry extends BaseGridRegistry implements GridRegistr
+     if (proxy == null) {
+       return;
+     }
+-    LOG.info(""Registered a node "" + proxy);
++    LOG.finest(""Registered a node "" + proxy);
+     try {
+       lock.lock();
+ ",This is wildly unhelpful to users --- they need to know when a proxy has been registered.
+5904,"@@ -16,8 +16,13 @@ class Topic < ActiveRecord::Base
+   has_one :legacy_trail
+   has_many :trails
+
++  has_attached_file :image, {
++    path: ""topics/:attachment/:id_partition/:style/:filename""
++  }.merge(PAPERCLIP_STORAGE_OPTIONS)
++
+   validates :name, presence: true
+   validates :slug, presence: true, uniqueness: true
++  validates_attachment_content_type :image, content_type: /\Aimage\/.*\Z/
+
+   friendly_id :name, use: [:slugged, :finders]
+ ",Why do we need `do_not_validate_attachment_file_type` is we're doing it in the previous line?
+5905,"@@ -107,10 +107,9 @@ public class LoginActivity extends AccountAuthenticatorActivity
+ 		if (shouldUseCertBasedAuth()) {
+ 			final String alias = RuntimeConfig.getRuntimeConfig(this).getString(ConfigKey.ManagedAppCertAlias);
+ 			KeyChain.choosePrivateKeyAlias(this, webviewHelper, null, null, null, 0, alias);
++		} else {
++			webviewHelper.loadLoginPage();
+ 		}
+-
+-		// Load login page
+-		webviewHelper.loadLoginPage();
+ 	}
+
+     /**",Loading login page right away only for the regular use case.
+5906,"@@ -1,13 +1,17 @@
+ // render modes
+
++/** Do not recursively re-render a component */
+ export const NO_RENDER = 0;
++/** Recursively re-render a component and it's children */
+ export const SYNC_RENDER = 1;
++/** Force a re-render of a component */
+ export const FORCE_RENDER = 2;
++/** Queue asynchronous re-render of a component and it's children */
+ export const ASYNC_RENDER = 3;
+
+
+ export const ATTR_KEY = '__preactattr_';
+
+-// DOM properties that should NOT have ""px"" added when numeric
++/** DOM properties that should NOT have ""px"" added when numeric */
+ export const IS_NON_DIMENSIONAL = /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i;
+ ",IIRC this flag disables re-rendering entirely (`s/recursively //`)
+5907,"@@ -6,17 +6,11 @@ define([""loading""], function(loading) {
+             url: ApiClient.getUrl(""Startup/Complete""),
+             type: ""POST""
+         }).then(function() {
+-            Dashboard.navigate(""dashboard.html"");
+             loading.hide();
++            window.location.href = ""index.html"";
+         });
+     }
+     return function(view, params) {
+         view.querySelector("".btnWizardNext"").addEventListener(""click"", onFinish);
+-        view.addEventListener(""viewshow"", function() {
+-            document.querySelector("".skinHeader"").classList.add(""noHomeButtonHeader"")
+-        });
+-        view.addEventListener(""viewhide"", function() {
+-            document.querySelector("".skinHeader"").classList.remove(""noHomeButtonHeader"")
+-        });
+     };
+ });","Did you test this redirect? @thornbill mentioned it might need `web` at the front, but if this works fine I'd rather leave it this way."
+5908,"@@ -30,7 +30,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+
+             headers[""custom""] = new[] { ""value"" };
+
+-            Assert.NotNull(headers[""custom""]);
+             Assert.Equal(1, headers[""custom""].Count);
+             Assert.Equal(""value"", headers[""custom""][0]);
+         }","FYI, this returned `StringValues` which is a value type (aka can never be null)."
+5909,"@@ -1425,7 +1425,16 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
+ 		valueSize := c.targetData.TypeAllocSize(llvmValueType)
+ 		llvmKeySize := llvm.ConstInt(c.ctx.Int8Type(), keySize, false)
+ 		llvmValueSize := llvm.ConstInt(c.ctx.Int8Type(), valueSize, false)
+-		hashmap := c.createRuntimeCall(""hashmapMake"", []llvm.Value{llvmKeySize, llvmValueSize}, """")
++		sizeHint := llvm.ConstInt(c.uintptrType, 8, false)
++		if expr.Reserve != nil {
++			sizeHint = c.getValue(frame, expr.Reserve)
++			var err error
++			sizeHint, err = c.parseConvert(expr.Reserve.Type(), types.Typ[types.Uintptr], sizeHint, expr.Pos())
++			if err != nil {
++				return llvm.Value{}, err
++			}
++		}
++		hashmap := c.createRuntimeCall(""hashmapMake"", []llvm.Value{llvmKeySize, llvmValueSize, sizeHint}, """")
+ 		return hashmap, nil
+ 	case *ssa.MakeSlice:
+ 		sliceLen := c.getValue(frame, expr.Len)","Oh no, that's a bug."
+5910,"@@ -23,5 +23,5 @@ package yarpc
+ // Response is the low level response representation.
+ type Response struct {
+ 	Headers          Headers
+-	ApplicationError bool
++	ApplicationError error
+ }","Let's leave a note in CHANGES to replace this with an error metadata struct or interface, unless it would be less effort overall to take a run at it in this change."
+5911,"@@ -455,6 +455,10 @@ class Realm {
+  *   This is not supported for `""list""` properties of object types and `""linkingObjects""` properties.
+  * @property {boolean} [indexed] - Signals if this property should be indexed. Only supported for
+  *   `""string""`, `""int""`, and `""bool""` properties.
++ * @property {string} [mapTo] - Set this if the Javascript property name schema differs from the underlying name in the Realm
++ *   file. This can be used to have different naming convention in Javascript than what is being used in the file
++ *   itself. Reading and writing properties must be done using the public key for the property. Queries can be
++ *   done using both the public and the mapped property name.
+  */
+
+ /**","The changelog entry does a better job of explaining how this is used than this description. In particular, this says that you need to set `mapTo` if the underlying name is different, but not that `mapTo` *is* the underlying name."
+5912,"@@ -13,6 +13,7 @@ import (
+ 	""github.com/influxdata/flux/plan""
+ 	""github.com/influxdata/flux/semantic""
+ 	_ ""github.com/lib/pq""
++	_ ""github.com/mattn/go-sqlite3""
+ )
+
+ const FromSQLKind = ""fromSQL""","These imports will probably need to be refactored so they aren't here. That applies for all of the database drivers. The reason for this is because we sometimes want a driver to be available and sometimes we don't. When we include this library in our cloud offering, the sqlite3 connector needs to be gone because it's a security vulnerability and there's no use case for it in a cloud environment. But for flux itself, I can see how sqlite3 would be really useful and so I like this change. But this import needs to only exist within the tests and within the `cmd/flux` package. It cannot be here."
+5913,"@@ -414,7 +414,7 @@ class RelationController extends ControllerBehavior
+      */
+     protected function findExistingRelationIds($checkIds = null)
+     {
+-        $foreignKeyName = $this->relationModel->getKeyName();
++        $foreignKeyName = $this->relationModel->table . '.' . $this->relationModel->getKeyName();
+
+         $results = $this->relationObject
+             ->getBaseQuery()",We can use `getQualifiedKeyName` here instead. I will update.
+5914,"@@ -115,7 +115,7 @@ module.exports = function getIconByMime (fileType) {
+   }
+
+   // Archive
+-  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-gtar', 'x-apple-diskimage', 'x-diskcopy']
++  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-tar', 'x-gzip', 'x-apple-diskimage']
+   if (fileTypeGeneral === 'application' && archiveTypes.indexOf(fileTypeSpecific) !== -1) {
+     return {
+       color: '#00C469',",Could you clarifty why some of those are removed?
+5915,"@@ -774,3 +774,7 @@ func (a *FakeWebAPI) GetCommand(ctx context.Context, req *webservice.GetCommandR
+ 		Command: &cmd,
+ 	}, nil
+ }
++
++func (a *FakeWebAPI) ListDeploymentConfigTemplates(ctx context.Context, req *webservice.ListDeploymentConfigTemplatesRequest) (*webservice.ListDeploymentConfigTemplatesResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}",`ctx` is unused in ListDeploymentConfigTemplates
+5916,"@@ -1,10 +1,13 @@
+ <% if id.nil? || id.identifier == '' %>
+     <% if scheme.name.downcase == 'orcid' %>
+-        <%= link_to _(""Create or connect your ORCID iD""),
+-                     Rails.application.routes.url_helpers.send(""user_orcid_omniauth_authorize_path""),
++        <%= link_to  Rails.application.routes.url_helpers.send(""user_orcid_omniauth_authorize_path""),
+                      id: ""connect-orcid-button"", target: '_blank',
+                      title: _(""ORCID provides a persistent digital identifier that distinguishes you from other researchers. Learn more at orcid.org""),
+-                     'data-toggle': ""tooltip"" %>
++                     'data-toggle': ""tooltip"" do %>
++          <%= image_tag 'https://orcid.org/sites/default/files/images/orcid_16x16.png', alt: _('ORCID logo') %>
++          &nbsp;
++          <%= _(""Create or connect your ORCID iD"") %>
++        <% end %>
+     <% elsif scheme.name.downcase == 'shibboleth' %>
+         <i class=""fa fa-user"" title=""<%= _('Institutional credentials') %>"" aria-hidden=""true""></i>
+         &nbsp;",nice to see the usage of block for a more readable link name
+5917,"@@ -329,9 +329,10 @@ int MPI_File_read(MPI_File fh, void *buf, int count, MPI_Datatype datatype,
+     if (bytes_read != bytes_to_read)
+     {
+         std::snprintf(mpierrmsg, MPI_MAX_ERROR_STRING,
+-                      ""could not read %"" PRId64 "" bytes. read only: %"" PRId64
++                      ""could not read %llu bytes. read only: %llu""
+                       ""\n"",
+-                      bytes_to_read, bytes_read);
++                      (unsigned long long)bytes_to_read,
++                      (unsigned long long)bytes_read);
+         return -2;
+     }
+     *status = bytes_read;","Can these use `static_cast<unsigned long long>` instead? Other than that, it's fine."
+5918,"@@ -258,7 +258,6 @@ def create_app(instance_path=None, static_folder=None, **kwargs_config):
+             except (SyntaxError, ValueError):
+                 pass
+             app.config[cfg_name] = cfg_value
+-            app.logger.debug(""{0} = {1}"".format(cfg_name, cfg_value))
+
+     # ====================
+     # Application assembly",This output is only present when `DEBUG=True`. Does it really bother so much?
+5919,"@@ -1194,11 +1194,7 @@ bool nano::wallet::search_pending ()
+ 						if (wallets.node.ledger.block_confirmed (block_transaction, hash))
+ 						{
+ 							// Receive confirmed block
+-							auto node_l (wallets.node.shared ());
+-							wallets.node.background ([node_l, block, hash]() {
+-								auto transaction (node_l->store.tx_begin_read ());
+-								node_l->receive_confirmed (transaction, block, hash);
+-							});
++							wallets.node.receive_confirmed (block_transaction, block, hash);
+ 						}
+ 						else
+ 						{","I think it should pass wallet transaction as well, otherwise there will be 2 wallet read transactions in 1 threads (next in scan_receivable)"
+5920,"@@ -3651,14 +3651,14 @@ bool MMFFMolProperties::getMMFFVdWParams(const unsigned int idx1,
+     const MMFFVdW *mmffVdWParamsIAtom = (*mmffVdW)(iAtomType);
+     const MMFFVdW *mmffVdWParamsJAtom = (*mmffVdW)(jAtomType);
+     if (mmffVdWParamsIAtom && mmffVdWParamsJAtom) {
+-      mmffVdWParams.R_ij_starUnscaled = Utils::calcUnscaledVdWMinimum(
++      mmffVdWParams.R_ij_starUnscaled = MMFF::Utils::calcUnscaledVdWMinimum(
+           mmffVdW, mmffVdWParamsIAtom, mmffVdWParamsJAtom);
+-      mmffVdWParams.epsilonUnscaled = Utils::calcUnscaledVdWWellDepth(
++      mmffVdWParams.epsilonUnscaled = MMFF::Utils::calcUnscaledVdWWellDepth(
+           mmffVdWParams.R_ij_starUnscaled, mmffVdWParamsIAtom,
+           mmffVdWParamsJAtom);
+       mmffVdWParams.R_ij_star = mmffVdWParams.R_ij_starUnscaled;
+       mmffVdWParams.epsilon = mmffVdWParams.epsilonUnscaled;
+-      Utils::scaleVdWParams(mmffVdWParams.R_ij_star, mmffVdWParams.epsilon,
++      MMFF::Utils::scaleVdWParams(mmffVdWParams.R_ij_star, mmffVdWParams.epsilon,
+                             mmffVdW, mmffVdWParamsIAtom, mmffVdWParamsJAtom);
+       res = true;
+     }",RDKit::Utils is now in the namespace for localeswitcer... We could change it to something else.
+5921,"@@ -211,6 +211,10 @@ class GroupBy(object):
+             kdf = kdf.reset_index(drop=self._should_drop_index)
+
+         if relabeling:
++
++            # For MultiIndex, we need to flatten the tuple, e.g. (('y', 'A'), 'max') needs to be
++            # flattened to ('y', 'A', 'max'), it won't do anything on normal Index.
++            order = [(*levs, method) for levs, method in order]
+             kdf = kdf[order]
+             kdf.columns = columns
+         return kdf","@itholic, can we fix it in `_normalize_keyword_aggregation`?"
+5922,"@@ -1,6 +1,7 @@
+ # This class represents a user's subscription to Learn content
+ class Subscription < ActiveRecord::Base
+   MAILING_LIST = 'Active Subscribers'
++  DOWNGRADED_PLAN = 'prime-maintain'
+
+   belongs_to :user
+   belongs_to :mentor, class_name: User","It seems like we have the main plan in the database but the downgrade plan in the code. Probably okay for now, but as our thinking of how downgrades/plans develops we may want to consolidate."
+5923,"@@ -44,6 +44,10 @@ import java.util.List;
+  * </code>
+  */
+ public abstract class By {
++  static {
++    WebDriverException.scheduleIpHostResolving();
++  }
++
+   /**
+    * @param id The value of the ""id"" attribute to search for
+    * @return a By which locates elements by the value of the ""id"" attribute.","we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class."
+5924,"@@ -42,6 +42,8 @@ const (
+ 	optionNamePaymentTolerance     = ""payment-tolerance""
+ 	optionNameResolverEndpoints    = ""resolver-options""
+ 	optionNameGatewayMode          = ""gateway-mode""
++	optionNameClefSignerEnable     = ""clef-signer-enable""
++	optionNameClefSignerEndpoint   = ""clef-signer-endpoint""
+ )
+
+ func init() {",do we need both flags? maybe infer that `clef-signer-enabled` whenever `clef-signer-endpoint` is defined?
+5925,"@@ -40,7 +40,7 @@ module.exports = {
+     '<rootDir>/test',
+   ],
+   moduleNameMapper: {
+-    '\\.(scss)$': '<rootDir>/node_modules/identity-obj-proxy',
++    '\\.(scss|css)$': '<rootDir>/node_modules/identity-obj-proxy',
+     'github-markdown-css': '<rootDir>/node_modules/identity-obj-proxy',
+     '\\.(png)$': '<rootDir>/node_modules/identity-obj-proxy',
+     '\\.(svg)$': '<rootDir>/test/unit/empty.js'",Do we need this? I didn't see css files (only scss).
+5926,"@@ -29,7 +29,7 @@ class Store:
+
+     if hosts is None:
+       hosts = settings.CLUSTER_SERVERS
+-    remote_hosts = [host for host in hosts if not is_local_interface(host)]
++    remote_hosts = [host for host in hosts if not settings.REMOTE_EXCLUDE_LOCAL or not is_local_interface(host)]
+     self.remote_stores = [ RemoteStore(host) for host in remote_hosts ]
+
+ ",This feels like a weird `if not ... or not` to me. Can you talk out the intent here?
+5927,"@@ -0,0 +1,17 @@
++class AnnualBillingsController < ApplicationController
++  before_filter :authorize
++
++  def new
++    @annualized_payment = current_user.annualized_payment
++    @discounted_annual_payment = current_user.discounted_annual_payment
++  end
++
++  def create
++    AnnualBillingMailer.notification(current_user).deliver
++
++    redirect_to(
++      dashboard_path,
++      notice: ""Thanks! We'll upgrade your account to annual billing.""
++    )
++  end
++end",Align the parameters of a method call if they span more than one line.
+5928,"@@ -17,7 +17,7 @@ namespace ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Opt
+ use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetPackage;
+
+ /**
+- * Class HierarchyPackage
++ * Class OptionsPackage
+  * @package ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options
+  */
+ class OptionsPackage extends AbstractFacetPackage {",`@package *` can be removed as well.
+5929,"@@ -3,7 +3,7 @@ module Beaker
+   # all String methods while adding several platform-specific use cases.
+   class Platform < String
+     # Supported platforms
+-    PLATFORMS = /^(huaweios|cisco_nexus|cisco_ios_xr|(free|open)bsd|osx|centos|fedora|debian|oracle|redhat|scientific|sles|ubuntu|windows|solaris|aix|archlinux|el|eos|cumulus|f5|netscaler)\-.+\-.+$/
++    PLATFORMS = /^(huaweios|cisco_nexus|cisco_ios_xr|(free|open)bsd|osx|centos|fedora|debian|oracle|redhat_fips|redhat|scientific|sles|ubuntu|windows|solaris|aix|archlinux|el|eos|cumulus|f5|netscaler)\-.+\-.+$/
+     # Platform version numbers vs. codenames conversion hash
+     PLATFORM_VERSION_CODES =
+       { :debian => { ""stretch"" => ""9"",",@ScottGarman is there a reason that `redhat_fips` needs to be a beaker platform? Why can't it be another platform that beaker just understands as `redhat`?
+5930,"@@ -274,8 +274,6 @@ void NebulaStore::removePart(GraphSpaceID spaceId, PartitionID partId) {
+         if (partIt != spaceIt->second->parts_.end()) {
+             auto* e = partIt->second->engine();
+             CHECK_NOTNULL(e);
+-            // Stop the raft
+-            partIt->second->stop();
+             raftService_->removePartition(partIt->second);
+             spaceIt->second->parts_.erase(partId);
+             e->removePart(partId);",Where is the other place?
+5931,"@@ -19,10 +19,13 @@
+ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ # IN THE SOFTWARE.
+
++from collections import Sequence
++from boto.vendored.six.moves import UserList
++
+ from boto.s3.user import User
+
+
+-class ResultSet(list):
++class ResultSet(UserList):
+     """"""
+     The ResultSet is used to pass results back from the Amazon services
+     to the client. It is light wrapper around Python's :py:class:`list` class,",Are you subclassing from `UserList` instead of `list` to satisfy some constraint of Jython? My main concern here is that this is a subtle breaking change to the API because `UserList` is not a subclass of `list`. This has the unfortunate side effect of breaking any user that is using `isinstance` checks to see if a `ResultSet` is a `list`.
+5932,"@@ -32,6 +32,14 @@ module AvatarHelper
+     ""<img src='/assets/icons/sm_laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
+   end
+
++  def avatar_laurels(rank)
++    ""<img src='/assets/icons/laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
++  end
++
++  def avatar_tiny_laurels(rank)
++    ""<img src='/assets/icons/tn_laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
++  end
++
+   private
+
+   def avatar_default_size(size)",We can DRY the above three functions
+5933,"@@ -55,14 +55,7 @@ public final class HashMap<K, V> implements Map<K, V>, Serializable {
+      * @return A {@link HashMap} Collector.
+      */
+     public static <K, V> Collector<Tuple2<K, V>, ArrayList<Tuple2<K, V>>, HashMap<K, V>> collector() {
+-        final Supplier<ArrayList<Tuple2<K, V>>> supplier = ArrayList::new;
+-        final BiConsumer<ArrayList<Tuple2<K, V>>, Tuple2<K, V>> accumulator = ArrayList::add;
+-        final BinaryOperator<ArrayList<Tuple2<K, V>>> combiner = (left, right) -> {
+-            left.addAll(right);
+-            return left;
+-        };
+-        final Function<ArrayList<Tuple2<K, V>>, HashMap<K, V>> finisher = HashMap::ofEntries;
+-        return Collector.of(supplier, accumulator, combiner, finisher);
++        return Collections.toListAndThen(HashMap::ofEntries);
+     }
+
+     /**",Only no good is good code. Nice that you were able to remove all this duplicate stuff!
+5934,"@@ -121,7 +121,7 @@ public class PhpSurfaceNamer extends SurfaceNamer {
+
+   @Override
+   public String getRetrySettingsTypeName() {
+-    return ""\\Google\\ApiCore\\RetrySettings"";
++    return ""RetrySettings"";
+   }
+
+   @Override","Looking at the code, it seems very odd that this method even exists in the SurfaceNamer, since it is only implemented and used in the PhpSurfaceNamer, and in fact the RetrySettings class name is hardcoded elsewhere. WDYT of just removing this method from SurfaceNamer and PhpSurfaceNamer?"
+5935,"@@ -107,3 +107,18 @@ func SplitWriteAll(ctx context.Context, s Splitter, r io.Reader, l int64, toEncr
+ 	}
+ 	return addr, nil
+ }
++
++type Loader interface {
++	// Load a reference in byte slice representation and return all content associated with the reference.
++	Load(context.Context, []byte) ([]byte, error)
++}
++
++type Saver interface {
++	// Save an arbitrary byte slice and return the reference byte slice representation.
++	Save(context.Context, []byte) ([]byte, error)
++}
++
++type LoadSaver interface {
++	Loader
++	Saver
++}",these interfaces are defined twice. we should use only one and have it in `storage` package maybe
+5936,"@@ -24,12 +24,16 @@
+ import cPickle as pickle
+ import os
+ import shutil
++import logging
+ from abc import ABCMeta, abstractmethod
+
+ import nupic.frameworks.opf.opfutils as opfutils
+
+-
+ ###############################################################
++# global variable
++global globalModelsStorage
++globalModelsStorage={}
++
+
+ class Model(object):
+   """""" This is the base class that all OPF Model implementations should",This is the wrong context for usage of `global` keyword. It need only be used inside functions.
+5937,"@@ -278,7 +278,7 @@ public abstract class AbstractNode implements Node {
+
+         for (int i = 0; i < node.jjtGetNumChildren(); i++) {
+             Node child = node.jjtGetChild(i);
+-            if (child.getClass() == targetType) {
++            if (targetType.isAssignableFrom(child.getClass())) {
+                 results.add(targetType.cast(child));
+             }
+ ",this change should be described in the changelog. I'll update it when merging if nothing else arises.
+5938,"@@ -52,9 +52,11 @@ const (
+ type (
+ 	// RPCFactory Creates a dispatcher that knows how to transport requests.
+ 	RPCFactory interface {
+-		CreateDispatcher() *yarpc.Dispatcher
++		CreateTChannelDispatcher() *yarpc.Dispatcher
++		CreateGRPCDispatcher() *yarpc.Dispatcher
+ 		CreateRingpopDispatcher() *yarpc.Dispatcher
+ 		CreateDispatcherForOutbound(callerName, serviceName, hostName string) *yarpc.Dispatcher
++		CreateDispatcherForGRPCOutbound(callerName, serviceName, hostName string) *yarpc.Dispatcher
+ 	}
+ )
+ ",Just to stay consistent with naming let's call it CreateGRPCDispatcherForOutbound. Also rename 'CreateDispatcherForOutbound' to 'CreateTChannelDispatcherForOutbound'
+5939,"@@ -88,7 +88,7 @@ public class Docker {
+
+     findImage(new ImageNamePredicate(name, tag));
+
+-    LOG.info(String.format(""Pulling %s:%s"", name, tag));
++    LOG.finest(String.format(""Pulling %s:%s"", name, tag));
+
+     HttpRequest request = new HttpRequest(POST, ""/images/create"");
+     request.addQueryParameter(""fromImage"", name);",This will always need to be displayed to users.
+5940,"@@ -431,3 +431,6 @@ def safe_subn(pattern, repl, target, *args, **kwargs):
+         need a better solution that is aware of the actual content ecoding.
+     """"""
+     return re.subn(str(pattern), str(repl), target, *args, **kwargs)
++
++def bin_safe(s):
++    return ''.join([""\\x{:02x}"".format(ord(i)) if ord(i) < 32 else i for i in s])",This looks very much like `repr` now (we miss 127 though) - maybe just do `repr(x)` + strip outer parantheses?
+5941,"@@ -386,6 +386,7 @@ func (p *replicatorQueueProcessorImpl) generateSyncActivityTask(
+ 						VersionHistory:     versionHistory,
+ 					},
+ 				},
++				VisibilityTime: &taskInfo.VisibilityTimestamp,
+ 			}, nil
+ 		},
+ 	)",I don't see this field is set in task_generator.go. worth to double check if we put the timestamp when creating replication tasks.
+5942,"@@ -236,7 +236,9 @@ const hasNext = (self, callback) => {
+   if (self.s.currentDoc) {
+     return callback(null, true);
+   }
+-
++  if (self.isNotified()) {
++    return callback(null, false);
++  }
+   nextObject(self, function(err, doc) {
+     if (err) return callback(err, null);
+     if (self.s.state === Cursor.CLOSED || self.isDead()) return callback(null, false);",nit: I prefer the space before and after this check to make it very easy to scan when reading through code
+5943,"@@ -454,6 +454,15 @@ Morbi Nulla justo Aenean orci Vestibulum ullamcorper tincidunt mollis et hendrer
+                     logger.Info(createdMessage);
+                 }
+
++                // Make triple-flush to fully exercise the async flushing logic
++                try
++                {
++                    LogManager.Flush(0);
++                }
++                catch (NLog.NLogRuntimeException)
++                { }
++                LogManager.Flush(); // Waits for flush (Scheduled on top of the previous flush)
++                LogManager.Flush(); // Nothing to flush
+             });
+
+ ",should users also do a triple-flush?
+5944,"@@ -302,9 +302,7 @@ func testCodec(t *testing.T, ct CodecTester) {
+ 	type S struct {
+ 		N  *int
+ 		I  int
+-		U  uint
+ 		F  float64
+-		C  complex64
+ 		St string
+ 		B  bool
+ 		By []byte","What is the implication of removing these from the test? I thought the idea was to have all types supported by `docstore` here, and do things in the drivers to make them support them (e.g., list of size 2 for complex). If you're removing them because firestore doesn't have native support, then we're going to end up only testing the intersection of all types supported by all drivers; we need a better way."
+5945,"@@ -217,7 +217,7 @@ class DataViewer(base.GridEditor, layoutwidget.LayoutWidget):
+             ]) -> None:
+         if vals:
+             # Whatever vals is, make it a list of rows containing lists of column values.
+-            if isinstance(vals, str):
++            if not isinstance(vals, list):
+                 vals = [vals]
+             if not isinstance(vals[0], list):
+                 vals = [[i] for i in vals]",Let's also adjust the somewhat weird type signature here as well. This probably should be `typing.Any` instead of `str` in the last line if we intend to support ints.
+5946,"@@ -36,7 +36,7 @@ func makeBucket(t *testing.T) (*blob.Bucket, func()) {
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}
+-	return b, func() {}
++	return b, func() { _ = os.RemoveAll(dir) }
+ }
+ func TestConformance(t *testing.T) {
+ 	drivertest.RunConformanceTests(t, makeBucket, ""../testdata"")",The body can just be `os.RemoveAll(dir)`
+5947,"@@ -42,7 +42,7 @@ public class Cast extends NoOp {
+     } else if (targetDataType instanceof RealType) {
+       casted = castToDouble(value);
+     } else {
+-      throw new UnsupportedOperationException(""only support cast to Long, Double and String"");
++      casted = value;
+     }
+     row.set(pos, targetDataType, casted);
+   }",Is this covered by regression tests? Also you might make a patch onto refactor branch.
+5948,"@@ -54,6 +54,11 @@ public class SolrPing extends SolrRequest<SolrPingResponse> {
+   public ModifiableSolrParams getParams() {
+     return params;
+   }
++
++  @Override
++  public String getRequestType() {
++    return SolrRequestType.QUERY.toString();
++  }
+
+   /**
+    * Remove the action parameter from this request. This will result in the same",This is maybe more of an admin request? WDYT?
+5949,"@@ -109,16 +109,16 @@ public interface TraversableOnce<T> extends Iterable<T> {
+     }
+
+     /**
+-     * Converts this TraversableOnce to a HashMap.
++     * Converts this TraversableOnce to a Map.
+      *
+      * @param f   A function that maps an element to a Map.Entry
+      * @param <K> The key type of a Map Entry
+      * @param <V> The value type of a Map Entry
+      * @return a new HashMap containing the elements mapped to entries
+      */
+-    default <K, V> HashMap<K, V> toHashMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) {
++    default <K, V> Map<K, V> toMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) {
+         Objects.requireNonNull(f, ""f is null"");
+-        return HashMap.<K, V> ofAll(toList().map(f::apply));
++        return Map.<K, V> ofAll(toList().map(f::apply));
+     }
+
+     /**","Here I thought of `toHashMap` and later add `toTreeMap`. But I start to see, what you may have in mind. Alternatively we could provide a `toMap` and `toSortedMap`, which is great, too. On the other hand is always good to be as specific as possible. What do you think?"
+5950,"@@ -79,13 +79,13 @@ type appDeployOpts struct {
+
+ 	projectService   projectService
+ 	ecrService       ecr.Service
+-	workspaceService *workspace.Workspace
++	workspaceService archer.Workspace
+
+ 	prompt  prompter
+ 	spinner progress
+
+-	projectApplications []*archer.Application
+-	projectEnvironments []*archer.Environment
++	localProjectAppNames []string
++	projectEnvironments  []*archer.Environment
+ }
+
+ func (opts appDeployOpts) String() string {",maybe localProjectAppNames? Just a thought.
+5951,"@@ -354,6 +354,7 @@ Blockly.BlockSvg.prototype.getHeightWidth = function() {
+   if (nextBlock) {
+     var nextHeightWidth = nextBlock.getHeightWidth();
+     height += nextHeightWidth.height;
++    height -= Blockly.BlockSvg.NOTCH_HEIGHT; // Exclude height of connected notch.
+     width = Math.max(width, nextHeightWidth.width);
+   }
+   return {height: height, width: width};","This isn't new, but getHeightWidth is now defined in block_svg.js, block_render_svg_horizontal.js, and block_render_svg_vertical.js. One of these should be unnecessary."
+5952,"@@ -156,7 +156,7 @@ func TestGroupTransactionsDifferentSizes(t *testing.T) {
+
+ 		// wait for the txids and check balances
+ 		_, curRound := fixture.GetBalanceAndRound(account0)
+-		confirmed := fixture.WaitForAllTxnsToConfirm(curRound+5, txids)
++		confirmed := fixture.WaitForAllTxnsToConfirm(curRound+10, txids)
+ 		a.True(confirmed, ""txgroup"")
+
+ 		for i, acct := range accts {","I can't see any reason why this would fix a failure in `a.True(confirmed, ""txgroup"")`. We might have an issue elsewhere, but increasing the wait time wouldn't help."
+5953,"@@ -46,6 +46,10 @@ module Beaker
+         @logger.perf_output(""Creating symlink from /etc/sysstat/sysstat.cron to /etc/cron.d"")
+         host.exec(Command.new('ln -s /etc/sysstat/sysstat.cron /etc/cron.d'),:acceptable_exit_codes => [0,1])
+       end
++      if @options[:collect_perf_data] =~ /aggressive/
++        @logger.perf_output(""Enabling aggressive sysstat polling"")
++        host.exec(Command.new('sed -i s/5-55\\\/10/*/ /etc/cron.d/sysstat'))
++      end
+       if host['platform'] =~ PERF_START_PLATFORMS # SLES doesn't need this step
+         host.exec(Command.new('service sysstat start'))
+       end","This section needs to be modified; crontab format differs between OS releases (Debian and CentOS, at least)."
+5954,"@@ -54,7 +54,10 @@ from .results import PipelineExecutionResult
+
+
+ def execute_run_iterator(
+-    pipeline: IPipeline, pipeline_run: PipelineRun, instance: DagsterInstance
++    pipeline: IPipeline,
++    pipeline_run: PipelineRun,
++    instance: DagsterInstance,
++    resume_from_failure: bool = False,
+ ) -> Iterator[DagsterEvent]:
+     check.inst_param(pipeline, ""pipeline"", IPipeline)
+     check.inst_param(pipeline_run, ""pipeline_run"", PipelineRun)","if we think this is likely to be augmented with a additional 'run coordination' features or configuration in the future, we could make it an object of some kind instead (or an enum, if we think there may be other resume modes in the future besides just on/off). Just imagining 6 months in the future, it would be unfortunate if there were 7 new args here as the feature gets more complex"
+5955,"@@ -1,8 +1,10 @@
++from .affine_grid_generator import affine_grid
+ from .context_block import ContextBlock
+ from .dcn import (DeformConv, DeformConvPack, DeformRoIPooling,
+                   DeformRoIPoolingPack, ModulatedDeformConv,
+                   ModulatedDeformConvPack, ModulatedDeformRoIPoolingPack,
+                   deform_conv, deform_roi_pooling, modulated_deform_conv)
++from .grid_sampler import grid_sample
+ from .masked_conv import MaskedConv2d
+ from .nms import nms, soft_nms
+ from .roi_align import RoIAlign, roi_align",`affine_grid` and `grid_sample` are currently unused. We may remove it from `ops/__init__.py` to speedup the loading of mmdet.
+5956,"@@ -215,6 +215,12 @@ func populateClientConfig(config *Config, createdPacketConn bool) *Config {
+ 	if config.IdleTimeout != 0 {
+ 		idleTimeout = config.IdleTimeout
+ 	}
++	attackTimeout := protocol.DefaultAttackTimeout
++	if config.AttackTimeout > 0 {
++		attackTimeout = config.AttackTimeout
++	} else if config.AttackTimeout < 0 {
++		attackTimeout = 0
++	}
+
+ 	maxReceiveStreamFlowControlWindow := config.MaxReceiveStreamFlowControlWindow
+ 	if maxReceiveStreamFlowControlWindow == 0 {",Is there a reason why you need to support negative `AttackTimeout`? Why not just throw an error?
+5957,"@@ -25,6 +25,7 @@ from typing import Any, Optional, List, Tuple, Union, Generic, TypeVar
+
+ import numpy as np
+ import pandas as pd
++import pyspark.sql.functions as F
+ from pandas.api.types import is_list_like, is_dict_like
+ from pandas.core.dtypes.common import infer_dtype_from_object
+ from pandas.core.dtypes.inference import is_sequence",nit: an unnecessary change?
+5958,"@@ -1,15 +1,17 @@
+ package http3
+
+ import (
+-	""fmt""
+ 	""io""
+
+ 	""github.com/lucas-clemente/quic-go""
++	""github.com/marten-seemann/qpack""
+ )
+
++type trailerFunc func([]qpack.HeaderField, error)
++
+ // The body of a http.Request or http.Response.
+ type body struct {
+-	str quic.Stream
++	str RequestStream
+
+ 	// only set for the http.Response
+ 	// The channel is closed when the user is done with this response:","Is trailer parsing something we have to do in this PR? It would be really helpful to separate stuff like this into smaller, self-contained PRs."
+5959,"@@ -153,6 +153,7 @@ module Beaker
+       vm.volumes.each do |vol|
+         @logger.debug ""Deleting volume #{vol.name} for OpenStack host #{vm.name}""
+         vm.detach_volume(vol.id)
++        vol.wait_for { ready? }
+         vol.destroy
+       end
+     end",Any chance of a wait-forever situation here? Is there a reasonable timeout?
+5960,"@@ -79,12 +79,10 @@ func (bs *blockSyncer) P2P() network.Overlay {
+ // Start starts a block syncer
+ func (bs *blockSyncer) Start(ctx context.Context) error {
+ 	logger.Debug().Msg(""Starting block syncer"")
+-	startHeight, err := findSyncStartHeight(bs.bc)
+-	if err != nil {
+-		return err
+-	}
+-	bs.buf.startHeight = startHeight
+-	bs.buf.confirmedHeight = startHeight - 1
++	// FIXME this node may still has issue, if it was following the wrong chain, this is actually a general version of 2, but in 3, we need to rollback blockchain first
++	bs.buf.startHeight = bs.bc.TipHeight() + 1
++	bs.buf.confirmedHeight = bs.bc.TipHeight()
++
+ 	return bs.worker.Start(ctx)
+ }
+ ",line is 165 characters
+5961,"@@ -107,9 +107,13 @@ func (s *IntegrationBase) setupSuite(defaultClusterConfigFile string) {
+
+ 	s.Require().NoError(s.registerArchivalNamespace())
+
+-	// this sleep is necessary because namespacev2 cache gets refreshed in the
+-	// background only every namespaceCacheRefreshInterval period
+-	time.Sleep(namespace.CacheRefreshInterval + time.Second)
++	if clusterConfig.FrontendAddress == """" {
++		// Poke all the in-process namespace caches to refresh without waiting for the usual refresh interval.
++		s.testCluster.RefreshNamespaceCache()
++	} else {
++		// Wait for one whole cycle of the namespace cache v2 refresh interval to be sure that our namespaces are loaded.
++		time.Sleep(namespace.CacheRefreshInterval + time.Second)
++	}
+ }
+
+ func (s *IntegrationBase) setupLogger() {",is this for cross DC case?
+5962,"@@ -199,7 +199,7 @@ if __name__ == '__main__':
+         keywords='computer vision, object detection',
+         url='https://github.com/open-mmlab/mmdetection',
+         packages=find_packages(exclude=('configs', 'tools', 'demo')),
+-        package_data={'mmdet.ops': ['*/*.so']},
++        package_data={'mmcv.ops': ['*/*.so']},
+         classifiers=[
+             'Development Status :: 4 - Beta',
+             'License :: OSI Approved :: Apache Software License',",Remove this line.
+5963,"@@ -668,10 +668,11 @@ import browser from './browser';
+         }
+
+         if (canPlayVp8) {
++            // TODO: Remove vpx entry once servers are migrated
+             profile.TranscodingProfiles.push({
+                 Container: 'webm',
+                 Type: 'Video',
+-                AudioCodec: 'vorbis',
++                AudioCodec: webmAudioCodecs.includes('opus') ? 'opus' : 'vorbis',
+                 VideoCodec: 'vpx',
+                 Context: 'Streaming',
+                 Protocol: 'http',",Maybe it would make sense to use `webmVideoCodecs` here and just append `vpx`. I'm not sure if av1 is currently supported when transcoding to webm though. It looks like it can be included in the mp4 transcoding profile now.
+5964,"@@ -182,7 +182,7 @@ public class StatsValuesFactory {
+       // ""NumericValueSourceStatsValues"" which would have diff parent classes
+       //
+       // part of the complexity here being that the StatsValues API serves two
+-      // masters: collecting concrete Values from things like DocValuesStats and
++      // primaries: collecting concrete Values from things like DocValuesStats and
+       // the distributed aggregation logic, but also collecting docIds which it
+       // then
+       // uses to go out and pull concreate values from the ValueSource","Interestingly, this has nothing to do with replication, no clue what this means here"
+5965,"@@ -251,8 +251,14 @@ func (r *runner) initRepoIfNeeded(ctx context.Context, forCmd string) (
+ 		}()
+ 	}
+
+-	fs, _, err = libgit.GetOrCreateRepoAndID(
+-		ctx, r.config, r.h, r.repo, r.uniqID)
++	// Only allow lazy creates for public and multi-user TLFs.
++	if r.h.Type() == tlf.Public || len(r.h.ResolvedWriters()) > 1 {
++		fs, _, err = libgit.GetOrCreateRepoAndID(
++			ctx, r.config, r.h, r.repo, r.uniqID)
++	} else {
++		fs, _, err = libgit.GetRepoAndID(
++			ctx, r.config, r.h, r.repo, r.uniqID)
++	}
+ 	if err != nil {
+ 		return nil, nil, err
+ 	}",Is that because we don't provide a UI for these?
+5966,"@@ -7,9 +7,11 @@ import (
+ 	""time""
+
+ 	""github.com/influxdata/flux""
++	""github.com/influxdata/flux/codes""
+ 	""github.com/influxdata/flux/execute""
+ 	""github.com/influxdata/flux/execute/executetest""
+ 	_ ""github.com/influxdata/flux/fluxinit/static"" // We need to init flux for the tests to work.
++	""github.com/influxdata/flux/internal/errors""
+ 	""github.com/influxdata/flux/mock""
+ 	""github.com/influxdata/flux/querytest""
+ 	""github.com/influxdata/flux/stdlib/csv""",Standard is either to use `HappyPath` (CamelCase) or `happy path` (lowercase sentence). I usually prefer the latter.
+5967,"@@ -46,7 +46,7 @@ func TestSuggestGasPriceForUserAction(t *testing.T) {
+ 	blkState := blockchain.InMemStateFactoryOption()
+ 	blkMemDao := blockchain.InMemDaoOption()
+ 	blkRegistryOption := blockchain.RegistryOption(&registry)
+-	bc := blockchain.NewBlockchain(cfg, blkState, blkMemDao, blkRegistryOption)
++	bc := blockchain.NewBlockchain(cfg, nil, blkState, blkMemDao, blkRegistryOption)
+ 	bc.Validator().AddActionEnvelopeValidators(protocol.NewGenericValidator(bc))
+ 	exec := execution.NewProtocol(bc, config.NewHeightUpgrade(cfg))
+ 	require.NoError(t, registry.Register(execution.ProtocolID, exec))","instead of using blkMemDao, we could generate a blockMemDao, and then use it as the second parameter."
+5968,"@@ -147,6 +147,10 @@ function eachAsync(arr, eachFn, callback) {
+   }
+ }
+
++function isUnifiedTopology(topology) {
++  return topology.description != null;
++}
++
+ module.exports = {
+   uuidV4,
+   calculateDurationInMs,",nit(2/10): `topology && topology.description != null`;
+5969,"@@ -1,6 +1,8 @@
+ """"""
+ Wrappers around spark that correspond to common pandas functions.
+ """"""
++import sys
++
+ import pyspark.sql
+ import numpy as np
+ import pandas as pd",why the space? I may not know all the style conventions.
+5970,"@@ -21,6 +21,12 @@ describe('dlitem', function () {
+ 		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
+ 	});
+
++	it('should fail if the dlitem has a parent <dl> with a changed role', function(){
++		var checkArgs = checkSetup('<dl role=""menubar""><dt id=""target"">My list item</dl>');
++
++		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
++	});
++
+ 	(shadowSupport.v1 ? it : xit)('should return true in a shadow DOM pass', function () {
+ 		var node = document.createElement('div');
+ 		node.innerHTML = '<dt>My list item </dt>';","Should be ""should fail if the **dt element** has a parent <dl> with a changed role"""
+5971,"@@ -10,7 +10,15 @@ Workshops::Application.configure do
+   config.assets.digest = true
+   config.assets.js_compressor = :uglifier
+   config.assets.precompile += %w( print.css prefilled_input.js )
+-  config.serve_static_assets = false
++
++  # Serve static assets, which allows us to populate the CDN with compressed
++  # assets if a client supports them
++  config.serve_static_assets = true
++
++  # Fiddling with expires values is kind of pointless as we use hashing to bust
++  # caches during redeploys, but it should bump up our google pagespeed
++  # ranking.
++  config.static_cache_control = 'public, max-age=31536000'
+
+   config.eager_load = true
+   config.cache_store = :dalli_store","Just to be clear: 1. This is required for compression, right? 2. This won't actually result in our dynos serving the assets, since they'll be served via the CDN, correct?"
+5972,"@@ -17,10 +17,6 @@ class MediaManager extends BasePHPCRManager
+ {
+     /**
+      * {@inheritdoc}
+-     *
+-     * Warning: previous method signature was : save(MediaInterface $media, $context = null, $providerName = null)
+-     *
+-     * @throws \InvalidArgumentException When entity is an invalid object
+      */
+     public function save($entity, $andFlush = true)
+     {",not sure about removing this ping @Soullivaneuh
+5973,"@@ -12,7 +12,12 @@ class User < ActiveRecord::Base
+   validates :github_username, uniqueness: true, presence: true
+
+   delegate :plan, to: :subscription, allow_nil: true
+-  delegate :scheduled_for_deactivation_on, to: :subscription, allow_nil: true
++  delegate(
++    :scheduled_for_deactivation_on,
++    :scheduled_for_deactivation?,
++    to: :subscription,
++    allow_nil: true
++  )
+
+   before_save :clean_github_username
+ ",Put a comma after the last parameter of a multiline method call.
+5974,"@@ -61,8 +61,8 @@ func TestInstanceIfExists(t *testing.T) {
+ 					Return(nil, awserrors.NewNotFound(""not found""))
+ 			},
+ 			check: func(instance *infrav1.Instance, err error) {
+-				if err != nil {
+-					t.Fatalf(""did not expect error: %v"", err)
++				if err == nil {
++					t.Fatalf(""expects error when instance could not be found: %v"", err)
+ 				}
+
+ 				if instance != nil {","If instance could not be found when the provider id is set, `findInstance()` returns `ErrInstanceNotFoundByID` error. So that during reconcileNormal(), we don't create a new instance. In `reconcileDelete()`, when ErrInstanceNotFoundByID is seen, deletion continues to clean up even if the instance is gone (may be manually deleted)."
+5975,"@@ -38,6 +38,10 @@ namespace pwiz.Skyline.EditUI
+         private readonly bool _originalAlignRtPrediction;
+         private readonly ChromFileInfoId _originalAlignFile;
+
++        private int _idxLastSelected = -1;
++
++        private Tuple<string, HashSet<string>> _memory = Tuple.Create((string)null, new HashSet<string>());
++
+         private SrmDocument Document => _skylineWindow.Document;
+         private GroupByItem SelectedGroupBy => (GroupByItem) comboGroupBy.SelectedItem;
+ ","I would recommend making this a Tuple&lt;ReplicateValue, IColllection&lt;object>> You only need to convert things to strings if you need to persist them in Settings or something. If they only need to live for the life of dialog, you can keep everything as objects. You can use ""null"" for the ReplicateValue for when they have not chosen a property."
+5976,"@@ -33,14 +33,14 @@
+         _source: [""https://www.google.lv"", ""https://www.google.co.in/"", ""https://www.google.ru/"", ""http://stackoverflow.com/questions"", ""http://stackoverflow.com/unanswered"", ""http://stackoverflow.com/tags"", ""http://r.search.yahoo.com/""]
+ 	};
+ 	var eventsMap = {
+-		""Login"": [""Lost"", ""Won"",""[CLY]_star_rating""],
++		""Login"": [""Lost"", ""Won""],
+ 		""Logout"": [],
+ 		""Lost"": [""Won"", ""Achievement"", ""Lost""],
+ 		""Won"": [""Lost"", ""Achievement""],
+ 		""Achievement"": [""Sound"", ""Shared""],
+ 		""Sound"": [""Lost"", ""Won""],
+ 		""Shared"": [""Lost"", ""Won""],
+-		""[CLY]_star_rating"":[""Lost"", ""Won"", ""Achievement""]
++        ""[CLY]_action"":[]
+ 	};
+ 	var pushEvents = [""[CLY]_push_sent"", ""[CLY]_push_open"", ""[CLY]_push_action""];
+ 	var segments  = {","I think there is no point providing action key here, as it will be called specifically, rather than randomly"
+5977,"@@ -31,14 +31,13 @@ namespace Datadog.Trace.ClrProfiler.Integrations.Testing
+
+         private static readonly IntegrationInfo IntegrationId = IntegrationRegistry.GetIntegrationInfo(nameof(IntegrationIds.XUnit));
+         private static readonly Vendors.Serilog.ILogger Log = DatadogLogging.GetLogger(typeof(XUnitIntegration));
+-        private static readonly FrameworkDescription _runtimeDescription;
++        private static readonly FrameworkDescription RuntimeDescription;
+
+         static XUnitIntegration()
+         {
+             // Preload environment variables.
+             CIEnvironmentValues.DecorateSpan(null);
+-
+-            _runtimeDescription = FrameworkDescription.Create();
++            RuntimeDescription = FrameworkDescription.Instance;
+         }
+
+         /// <summary>",`XUnitIntegration` doesn't need to cache this anymore.
+5978,"@@ -13,11 +13,13 @@ files[""awesomerc.lua""].allow_defined_top = true
+ -- This file itself
+ files["".luacheckrc""].ignore = {""111"", ""112"", ""131""}
+
++-- Theme files, ignore max line length
++files[""themes/*""].ignore = {""631""}
++
+ -- Global objects defined by the C code
+ read_globals = {
+     ""awesome"",
+     ""button"",
+-    ""client"",
+     ""dbus"",
+     ""drawable"",
+     ""drawin"",",Can we have something line `# noqa` there instead? I think it's fine like this though.
+5979,"@@ -309,16 +309,17 @@ class AbstractNode
+   #
+   # Returns A String reference or data URI for the target image
+   def image_uri(target_image, asset_dir_key = 'imagesdir')
++    images_base = asset_dir_key ? (attr asset_dir_key, nil, true) : nil
+     if (doc = @document).safe < SafeMode::SECURE && (doc.attr? 'data-uri')
+       if ((Helpers.uriish? target_image) && (target_image = Helpers.encode_spaces_in_uri target_image)) ||
+-          (asset_dir_key && (images_base = doc.attr asset_dir_key) && (Helpers.uriish? images_base) &&
++          (images_base && (Helpers.uriish? images_base) &&
+           (target_image = normalize_web_path target_image, images_base, false))
+         (doc.attr? 'allow-uri-read') ? (generate_data_uri_from_uri target_image, (doc.attr? 'cache-uri')) : target_image
+       else
+         generate_data_uri target_image, asset_dir_key
+       end
+     else
+-      normalize_web_path target_image, (asset_dir_key ? (doc.attr asset_dir_key) : nil)
++      normalize_web_path target_image, images_base
+     end
+   end
+ ",this variable is used in both branches so I've decided to declare it above
+5980,"@@ -382,11 +382,11 @@ public class PasscodeManager  {
+         	return;
+         }
+         Intent i = new Intent(ctx, PasscodeActivity.class);
+-        i.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
+-        i.setFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
+-        i.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
++        i.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
++        i.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
++        i.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
+         if (ctx == SalesforceSDKManager.getInstance().getAppContext()) {
+-            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
++            i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+         }
+         if (ctx instanceof Activity) {
+             ((Activity) ctx).startActivityForResult(i, PASSCODE_REQUEST_CODE);","`setFlags()` overwrites the previous flag, we should be using `addFlags()` to append flags."
+5981,"@@ -105,6 +105,15 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
+ 		}
+
+ 		if repo.IsMirror {
++			if isNameChanged {
++				var err error
++				ctx.Repo.Mirror, err = models.GetMirror(repo.ID)
++				if err != nil {
++					ctx.Handle(500, ""RefreshRepositoryMirror"", err)
++					return
++				}
++			}
++
+ 			if form.Interval > 0 {
+ 				ctx.Repo.Mirror.EnablePrune = form.EnablePrune
+ 				ctx.Repo.Mirror.Interval = form.Interval",Need `return` after this.
+5982,"@@ -13,12 +13,14 @@ use RootedData\Exception\ValidationException;
+  * Json Response Trait.
+  */
+ trait JsonResponseTrait {
++  use CacheableResponseTrait;
+
+   /**
+    * Private.
+    */
+   private function getResponse($message, int $code = 200): JsonResponse {
+-    return new JsonResponse($message, $code, []);
++    $response = new JsonResponse($message, $code, []);
++    return $this->addCacheHeaders($response);
+   }
+
+   /**","I would say we should not use the `CacheableResponseTrait` within the `JsonResponseTrait`. Traits within traits tend to lead to a bad developer experience as it can be really hard to find the actual method you're seeing in the implementing class, and in this case it looks like we're using _both_ the cacheable and the JSON traits in the same controller, so it's redundant anyway. I'd recommend just removing that use statement from `JsonResponseTrait` and make sure `ChaceableResponseTrait` is included everywhere it's needed specifically."
+5983,"@@ -43,7 +43,7 @@ class BoundZmqEventBus implements EventBus {
+     Addresses xpubAddr = deriveAddresses(address, publishConnection);
+     Addresses xsubAddr = deriveAddresses(address, subscribeConnection);
+
+-    LOG.info(String.format(""XPUB binding to %s, XSUB binding to %s"", xpubAddr, xsubAddr));
++    LOG.finest(String.format(""XPUB binding to %s, XSUB binding to %s"", xpubAddr, xsubAddr));
+
+     xpub = context.createSocket(SocketType.XPUB);
+     xpub.setImmediate(true);",This change is unhelpful: it precludes users from knowing which ports are being used for what purpose within the system.
+5984,"@@ -5,7 +5,8 @@ class ApplicationController < ActionController::Base
+   private
+
+   def current_user
+-    User.find_by(email_address: session[:user]['email']) if session[:user].present?
++    # User.find_by(email_address: session[:user]['email']) if session[:user].present?
++    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
+   end
+
+   def signed_in?","Whoa, we weren't doing this before?? Derp."
+5985,"@@ -134,11 +134,16 @@ func (f *ofFlow) CopyToBuilder(priority uint16) FlowBuilder {
+
+ // ToBuilder returns a new FlowBuilder with all the contents of the original Flow.
+ func (f *ofFlow) ToBuilder() FlowBuilder {
+-	// TODO: use exported fields from ofFlow and remove nolint:govet
+-	flow := *f.Flow //nolint:govet
++	flow := &ofctrl.Flow{
++		Table:      f.Flow.Table,
++		CookieID:   f.Flow.CookieID,
++		CookieMask: f.Flow.CookieMask,
++		Match:      f.Flow.Match,
++	}
++	f.Flow.CopyActionsToNewFlow(flow)
+ 	newFlow := ofFlow{
+ 		table:    f.table,
+-		Flow:     &flow,
++		Flow:     flow,
+ 		matchers: f.matchers,
+ 		protocol: f.protocol,
+ 	}","I'm surprised we didn't go with something like `flow := f.Flow.Copy()` to take care of all the fields at once, but as long as it works it's good enough for me"
+5986,"@@ -467,7 +467,7 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane {
+ 	}
+
+ 	// TODO Integrate XDP and BPF infra.
+-	if !config.BPFEnabled && dp.xdpState == nil {
++	if !config.BPFEnabled && config.XDPEnabled && dp.xdpState == nil {
+ 		xdpState, err := NewXDPState(config.XDPAllowGeneric)
+ 		if err == nil {
+ 			if err := xdpState.WipeXDP(); err != nil {","We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart."
+5987,"@@ -5,7 +5,10 @@
+
+ package net.sourceforge.pmd.lang.java.ast;
+
+-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode {
++public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
++
++    QualifiedName qualifiedName;
++
+     public ASTAnnotationTypeDeclaration(int id) {
+         super(id);
+     }","I'd declare this field `qualifiedName` private to hide it. Unless it really needs to be modified from somewhere else... (e.g. unit tests..), but then, we should find a solution, where this field can stay private."
+5988,"@@ -53,7 +53,18 @@ var (
+ 	_ introspection.IntrospectableOutbound = (*Outbound)(nil)
+ )
+
+-var defaultURLTemplate, _ = url.Parse(""http://localhost"")
++const http2AuthorityPseudoHeader = "":authority""
++
++var (
++	defaultURLTemplate, _ = url.Parse(""http://localhost"")
++	// from https://tools.ietf.org/html/rfc7540#section-8.1.2.3
++	http2PseudoHeaders = []string{
++		"":method"",
++		"":scheme"",
++		http2AuthorityPseudoHeader,
++		"":path"",
++	}
++)
+
+ // OutboundOption customizes an HTTP Outbound.
+ type OutboundOption func(*Outbound)","is this exhaustive? or rather, any psudo header started with `:` is un-parsable/invalid in HTTP/1 right?"
+5989,"@@ -113,8 +113,10 @@ describe('Sessions', function () {
+
+           return client
+             .withSession(testCase.operation(client))
+-            .catch(() => expect(client.topology.s.sessionPool.sessions).to.have.length(1))
+-            .then(() => expect(client.topology.s.sessionPool.sessions).to.have.length(1))
++            .then(
++              () => expect(client.topology.s.sessionPool.sessions).to.have.length(1),
++              () => expect(client.topology.s.sessionPool.sessions).to.have.length(1)
++            )
+             .then(() => client.close())
+             .then(() => {
+               // verify that the `endSessions` command was sent",Is this change implying something or just seems fit b/c regardless of outcome the sessions should still be length 1?
+5990,"@@ -48,12 +48,15 @@ public class DiscoveryFragmentGenerator {
+
+     ApiaryConfig apiaryConfig = discovery.getConfig();
+
++    // TODO: Support multiple templates; don't hard-code the zero-index here.
++    Preconditions.checkArgument(configProto.getTemplatesCount() == 1);
+     DiscoveryLanguageProvider languageProvider =
+-        GeneratorBuilderUtil.createLanguageProvider(
+-            configProto.getLanguageProvider(),
++        GeneratorBuilderUtil.createClass(
++            configProto.getTemplates(0).getLanguageProvider(),
+             DiscoveryLanguageProvider.class,
+             new Class<?>[] {Service.class, ApiaryConfig.class},
+             new Object[] {discovery.getService(), apiaryConfig},
++            ""discovery language provider"",
+             new GeneratorBuilderUtil.ErrorReporter() {
+               @Override
+               public void error(String message, Object... args) {","Maybe throw an exception if there is more than one, so that discovering the lack of support is easier when someone tries to use it down the road."
+5991,"@@ -85,8 +85,7 @@ Upcase::Application.routes.draw do
+       resource :trail, controller: ""exercise_trails"", only: [:show]
+     end
+
+-    get ""/new-languages"", to: ""marketing#new_languages""
+-    get ""/new-languages-thanks"", to: ""marketing#new_languages_thanks""
++    get ""/new-language-confirmation"", to: ""new_language_confirmations#index""
+     get '/pages/:id', to: 'high_voltage/pages#show', as: :page, format: false
+     get '/privacy', to: 'pages#show', as: :privacy, id: 'privacy'
+     get '/purchases/:lookup', to: 'pages#show', id: 'purchase-show'",Prefer single-quoted strings when you don't need string interpolation or special symbols.
+5992,"@@ -334,3 +334,11 @@ func NewGCPDialOptions(t *testing.T, recording bool, filename string) (opts []gr
+ 	}
+ 	return opts, done
+ }
++
++// RunTestsDependingOnDocker returns true when either:
++// 1) Not on Travis.
++// 2) On Travis Linux environment, where Docker is available.
++func RunTestsDependingOnDocker() bool {
++	s := os.Getenv(""TRAVIS_OS_NAME"")
++	return s == """" || s == ""linux""
++}","I feel the name of this function could be better, conveying it's a predicate. Something like `HasDockerTestEnvironment` or `CanRunLocalServerTests`, etc."
+5993,"@@ -30,14 +30,14 @@ func NewMonsterStorageClient(cc *grpc.ClientConn) MonsterStorageClient {
+ func (c *monsterStorageClient) Store(ctx context.Context, in *flatbuffers.Builder,
+ 	opts... grpc.CallOption) (* Stat, error) {
+   out := new(Stat)
+-  err := grpc.Invoke(ctx, ""/Example.MonsterStorage/Store"", in, out, c.cc, opts...)
++  err := grpc.Invoke(ctx, ""/MyGame.Example.MonsterStorage/Store"", in, out, c.cc, opts...)
+   if err != nil { return nil, err }
+   return out, nil
+ }
+
+ func (c *monsterStorageClient) Retrieve(ctx context.Context, in *flatbuffers.Builder,
+ 	opts... grpc.CallOption) (MonsterStorage_RetrieveClient, error) {
+-  stream, err := grpc.NewClientStream(ctx, &_MonsterStorage_serviceDesc.Streams[0], c.cc, ""/Example.MonsterStorage/Retrieve"", opts...)
++  stream, err := grpc.NewClientStream(ctx, &_MonsterStorage_serviceDesc.Streams[0], c.cc, ""/MyGame.Example.MonsterStorage/Retrieve"", opts...)
+   if err != nil { return nil, err }
+   x := &monsterStorageRetrieveClient{stream}
+   if err := x.ClientStream.SendMsg(in); err != nil { return nil, err }","This seems unrelated to your PR, how did this end up in here?"
+5994,"@@ -143,7 +143,7 @@ public class InMemoryUserDetailsManager implements UserDetailsManager,
+ 	@Override
+ 	public UserDetails updatePassword(UserDetails user, String newPassword) {
+ 		String username = user.getUsername();
+-		MutableUserDetails mutableUser = this.users.get(username);
++		MutableUserDetails mutableUser = this.users.get(username.toLowerCase());
+ 		mutableUser.setPassword(newPassword);
+ 		return mutableUser;
+ 	}",Is `username` expected to be case insensitive?
+5995,"@@ -18,16 +18,13 @@ import (
+ 	""testing""
+ 	""time""
+
+-	""github.com/iotexproject/iotex-core/pkg/util/fileutil""
+-
+-	""github.com/iotexproject/iotex-core/pkg/unit""
+-
+-	""github.com/iotexproject/iotex-core/test/identityset""
+-
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+
++	""github.com/iotexproject/iotex-core/pkg/util/fileutil""
++	""github.com/iotexproject/iotex-core/pkg/unit""
++	""github.com/iotexproject/iotex-core/test/identityset""
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""
+ 	""github.com/iotexproject/iotex-core/blockchain/genesis""",File is not `gofmt`-ed with `-s` (from `gofmt`)
+5996,"@@ -37,9 +37,9 @@ import net.sourceforge.pmd.util.FileUtil;
+ import net.sourceforge.pmd.util.datasource.DataSource;
+
+ /**
+- *
+- *
++ * @deprecated use {@link TimeTracker} instead
+  */
++@Deprecated
+ public final class Benchmarker {
+
+     private static final Map<String, BenchmarkResult> BENCHMARKS_BY_NAME = new HashMap<>();","Is there any point to the deprecation? If someone was using these APIs, can they continue to do so in any meaningful fashion now that you've disconnected them from the PMD internals? Normally ""compiles but doesn't work"" is considered a bug.  "
+5997,"@@ -104,7 +104,7 @@ class CompletionView(QTreeView):
+     """"""
+
+     resize_completion = pyqtSignal()
+-    selection_changed = pyqtSignal(QItemSelection)
++    selection_changed = pyqtSignal(str)
+
+     def __init__(self, win_id, parent=None):
+         super().__init__(parent)",You can remove the `QItemSelection` import in this file now.
+5998,"@@ -11,12 +11,17 @@ namespace meta {
+
+ void ListSpacesProcessor::process(const cpp2::ListSpacesReq& req) {
+     UNUSED(req);
+-    guard_ = std::make_unique<std::lock_guard<std::mutex>>(
+-                                BaseProcessor<cpp2::ListSpacesResp>::lock_);
++    auto& spaceLock = LockUtils::spaceLock();
++    if (!spaceLock.try_lock_shared()) {
++        resp_.set_code(cpp2::ErrorCode::E_TABLE_LOCKED);
++        onFinished();
++        return;
++    }
+     auto prefix = MetaUtils::spacePrefix();
+     std::unique_ptr<kvstore::KVIterator> iter;
+     auto ret = kvstore_->prefix(kDefaultSpaceId_, kDefaultPartId_, prefix, &iter);
+     if (ret != kvstore::ResultCode::SUCCEEDED) {
++        spaceLock.unlock_shared();
+         resp_.set_code(to(ret));
+         onFinished();
+         return;",Use `std::shared_lock` and `std::try_to_lock_t`. BTW. Why we fail on contention?
+5999,"@@ -37,7 +37,10 @@ module.exports = function(config) {
+         new webpack.DefinePlugin({
+           ""process.env.NODE_ENV"": JSON.stringify(""test"")
+         })
+-      ]
++      ],
++      resolve: {
++        extensions: ["""", "".jsx"", "".js""]
++      }
+     },
+
+     webpackServer: {","Not sure what this actually does, but do you need to add `""""` here? Or does `["".jsx"", "".js""]` work too?"
+6000,"@@ -8,6 +8,7 @@ package blockchain
+
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""io/ioutil""
+ 	""math/big""
+ 	""os""",let's group imports in the order: std third party first party
+6001,"@@ -1062,7 +1062,7 @@ public class JdbcExecutorLoaderTest {
+     return new JdbcExecutorLoader(props,
+         new CommonMetrics(new MetricsManager(new MetricRegistry())), null
+         , null, null, null, null,
+-        null, null);
++        null, null, null);
+   }
+
+   private boolean isTestSetup() {",So the tests run only when the db exists? Else everything passes?
+6002,"@@ -0,0 +1,12 @@
++package bytesink
++
++import ""io""
++
++// ByteSink represents a location to which bytes can be written. The ByteSink
++// should be closed after all bytes have been written.
++type ByteSink interface {
++	io.Writer
++	io.Closer
++	Open() error
++	ID() string
++}","`Remove` is unclear. It seems the point is to allow the `FifoByteSink` to delete the underlying file. There seems to be an implicit contract that consumers of this interface call `Remove` after `Close` without necessarily understanding what `Remove` does. I get that it's a little awkward to have `FifoByteSink` delete the file in `Close`. It would probably be best to just remove this from the interface, since `AddSink` is working with an actual `FifoByteSink`. I would rename it in `FifoByteSync` to `DeleteFile` or `Cleanup` or something that's makes it more clear what's being removed."
+6003,"@@ -0,0 +1,13 @@
++package core
++
++import (
++	""math/big""
++
++	""github.com/filecoin-project/go-filecoin/types""
++)
++
++type Ask struct {
++	Price *big.Int
++	Size  *big.Int
++	Miner types.Address
++}",Mentioned elsewhere but repeating again: would be nice to have units (ideally `Size *Bytes`).
+6004,"@@ -269,7 +269,7 @@ describe ""Bolt::CLI"" do
+         cli.execute(cli.parse)
+       end
+
+-      it 'install modules from Puppetfile with resolving' do
++      it 'install modules from Puppetfile without resolving' do
+         cli = Bolt::CLI.new(%W[module install --project #{project} --no-resolve])
+
+         allow(installer).to receive(:install) do |*args|","I think a test in `spec/integration` might help keep this file a bit more manageable, especially since we're just checking file contents and errors. But basically the same idea!"
+6005,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)"
+6006,"@@ -1105,7 +1105,8 @@ instr_set_label_callback(instr_t *instr, instr_label_callback_t cb)
+ {
+     CLIENT_ASSERT(instr_is_label(instr),
+                   ""only set callback functions for label instructions"");
+-    CLIENT_ASSERT(instr->label_cb == NULL, ""label callback function is already set"");
++    CLIENT_ASSERT(instr->label_cb == NULL || cb == NULL,
++                  ""label callback function is already set"");
+     CLIENT_ASSERT(!TEST(INSTR_RAW_BITS_ALLOCATED, instr->flags),
+                   ""instruction's raw bits occupying label callback memory"");
+     instr->label_cb = cb;","So this means that we can remove a callback via instr_set_label_callback(). Maybe consider adding another API function for removal, and add a new assert here such that cb != NULL?"
+6007,"@@ -30,7 +30,9 @@
+
+   <p><%= _(""Last modified: "") + l(@plan.updated_at.to_date, formats: :short) %></p> <br>
+
+-  <p><%= _(""Copyright information:"") %></p>
+-  <div style=""margin-left: 15px;""><p><%= _("" The above plan creator(s) have agreed that others may use as much of the text of this plan as they would like in their own plans, and customise it as necessary. You do not need to credit the creator(s) as the source of the language used, but using any of the plan's text does not imply that the creator(s) endorse, or have any relationship to, your project or proposal"") %></p></div>
++  <% if @public_plan %>
++    <p><%= _(""Copyright information:"") %></p>
++    <div style=""margin-left: 15px;""><p><%= _("" The above plan creator(s) have agreed that others may use as much of the text of this plan as they would like in their own plans, and customise it as necessary. You do not need to credit the creator(s) as the source of the language used, but using any of the plan's text does not imply that the creator(s) endorse, or have any relationship to, your project or proposal"") %></p></div>
++  <% end %>
+ </div>
+ <hr class=""bottom"" />",why are we using an instance variable instead of accessing the visibility method?
+6008,"@@ -173,6 +173,7 @@ func (h *HTTPTransport) NewTransport(ctx caddy.Context) (*http.Transport, error)
+ 		dialer.Resolver = &net.Resolver{
+ 			PreferGo: true,
+ 			Dial: func(ctx context.Context, _, _ string) (net.Conn, error) {
++				//nolint:gosec
+ 				addr := h.Resolver.netAddrs[weakrand.Intn(len(h.Resolver.netAddrs))]
+ 				return d.DialContext(ctx, addr.Network, addr.JoinHostPort(0))
+ 			},",Ok. Can we just disable this linter?
+6009,"@@ -6,7 +6,7 @@ from listenbrainz import config
+ from listenbrainz import db
+
+ ADMIN_SQL_DIR = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..','admin', 'sql')
+-TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'test_data')
++TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', 'testdata')
+
+
+ class DatabaseTestCase(unittest.TestCase):","this is `test_data` and all other instances are `testdata` - does this change affect any test files, or are there actually no directories called `test_data` in the repo? (I just checked, it seems like there aren't...)"
+6010,"@@ -48,10 +48,6 @@ public class ApiVersionStrings {
+         return getBasePath() + ""/chatter/"";
+     }
+
+-    public static String getBaseConnectPath() {
+-        return getBasePath() + ""/connect/"";
+-    }
+-
+     public static String getBaseSObjectPath() {
+         return getBasePath() + ""/sobjects/"";
+     }",Fixing `lint` warnings that have existed for a while.
+6011,"@@ -24,4 +24,9 @@ const (
+ 	// EnvKeyForInstallConfigName is the environment variable to get the
+ 	// the install config's name
+ 	EnvKeyForInstallConfigName InstallENVKey = ""OPENEBS_IO_INSTALL_CONFIG_NAME""
++	// CASDefaultCstorPoolENVK is the ENV key that specifies wether default cstor pool
++	// should be configured or not
++	// If value is ""true"", default cstor pool will be configured else for ""false""
++	// it will not be configured.
++	CASDefaultCstorPool InstallENVKey = ""OPENEBS_IO_INSTALL_DEFAULT_CSTOR_SPARSE_POOL""
+ )",Better to rename this to CASDefaultCstorSparsePool.
+6012,"@@ -105,4 +105,9 @@ public class S3FileIO implements FileIO {
+     this.awsClientFactory = AwsClientFactories.from(properties);
+     this.s3 = awsClientFactory::s3;
+   }
++
++  @Override
++  public void close() {
++    client().close();
++  }
+ }","Since we'e not 100% sure if `close` will be called more than once, should we set `client` to `null` or add an `AtomicBoolean closed` that will then handle the idempotency issue?"
+6013,"@@ -379,11 +379,15 @@ Intersection MotorwayHandler::fromRamp(const EdgeID via_eid, Intersection inters
+             //
+             //     7         1
+             //          0
++            const auto &first_intersection_name =
++                name_table.GetNameForID(first_intersection_data.name_id).to_string();
++            const auto &second_intersection_name =
++                name_table.GetNameForID(second_intersection_data.name_id).to_string();
+             if (intersection[1].entry_allowed)
+             {
+                 if (isMotorwayClass(intersection[1].eid, node_based_graph) &&
+-                    second_intersection_data.name_id != EMPTY_NAMEID &&
+-                    first_intersection_data.name_id != EMPTY_NAMEID && first_second_same_name)
++                    !second_intersection_name.empty() && !first_intersection_name.empty() &&
++                    first_second_same_name)
+                 {
+                     // circular order indicates a merge to the left (0-3 onto 4
+                     if (angularDeviation(intersection[1].angle, STRAIGHT_ANGLE) <",And here - what happens if name id is invalid
+6014,"@@ -0,0 +1,18 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Bolt\Storage\Query\Directive;
++
++use Bolt\Storage\Query\QueryInterface;
++
++/**
++ *  Directive a raw output of the generated query.
++ */
++class PrintQueryDirective
++{
++    public function __invoke(QueryInterface $query): void
++    {
++        echo $query;
++    }
++}",__toString() is not a part of QueryInterface
+6015,"@@ -43,7 +43,7 @@ from typing import (
+     cast,
+     TYPE_CHECKING,
+ )
+-
++import datetime
+ import numpy as np
+ import pandas as pd
+ from pandas.api.types import is_list_like, is_dict_like, is_scalar",nit: Could you add an empty line between `import datetime` (built-in library block) and `import numpy as np` (third-party library block)?
+6016,"@@ -1284,6 +1284,8 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_TYPE_NAME_MAP{
+   {""CUDA_ERROR_INVALID_PC"",                                            {""hipErrorInvalidPc"",                                        """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 718
+   // cudaErrorLaunchFailure
+   {""CUDA_ERROR_LAUNCH_FAILED"",                                         {""hipErrorLaunchFailure"",                                    """", CONV_NUMERIC_LITERAL, API_DRIVER}}, // 719
++  // cudaErrorCooperativeLaunchTooLarge
++  {""CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE"",                          {""hipErrorCooperativeLaunchTooLarge"",                        """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 720
+   // cudaErrorNotPermitted
+   {""CUDA_ERROR_NOT_PERMITTED"",                                         {""hipErrorNotPermitted"",                                     """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 800
+   // cudaErrorNotSupported",Please remove `HIP_UNSUPPORTED`
+6017,"@@ -30,13 +30,17 @@ import { STORE_NAME as CORE_USER } from '../googlesitekit/datastore/user/constan
+ /**
+  * Gets the current dateRange string.
+  *
+- * @param {string} [dateRange] Optional. The date range slug.
++ * @param {string} [dateRange]      Optional. The date range slug.
++ * @param {boolean} [returnNumber]  Optional. If true, returns the number only.
+  * @return {string} the date range string.
+  */
+-export function getCurrentDateRange( dateRange = getCurrentDateRangeSlug() ) {
++export function getCurrentDateRange( dateRange = getCurrentDateRangeSlug(), returnNumber = false ) {
+ 	const daysMatch = dateRange.match( /last-(\d+)-days/ );
+
+ 	if ( daysMatch && daysMatch[ 1 ] ) {
++		if ( returnNumber ) {
++			return parseInt( daysMatch[ 1 ], 10 );
++		}
+ 		return sprintf(
+ 			/* translators: %s: Number of days matched. */
+ 			_n( '%s day', '%s days', parseInt( daysMatch[ 1 ], 10 ), 'google-site-kit' ),","Having boolean parameters to change function behavior is not a good practice because it violates the principle of functions being responsible for a single task, so the need for this indicates we need to split something out of here instead. We can introduce a function like `getCurrentDateRangeDayCount` or similar, which does this."
+6018,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?
+6019,"@@ -39,17 +39,9 @@ type (
+ 		GetContractState(hash.PKHash, hash.Hash32B) (hash.Hash32B, error)
+ 		SetContractState(hash.PKHash, hash.Hash32B, hash.Hash32B) error
+ 		// Accounts
+-		Balance(string) (*big.Int, error)
+-		AccountState(string) (*Account, error)
+ 		RootHash() hash.Hash32B
+ 		Version() uint64
+ 		Height() uint64
+-		WorkingCandidates() map[hash.PKHash]*Candidate
+-		GetCandidates(height uint64) (CandidateList, error)
+-
+-		State(hash.PKHash, State) (State, error)
+-		CachedState(hash.PKHash, State) (State, error)
+-		PutState(hash.PKHash, State) error
+ 	}
+
+ 	// workingSet implements Workingset interface, tracks pending changes to account/contract in local cache","savedStates is for confirmed states, not needed in working set"
+6020,"@@ -23,6 +23,9 @@ import (
+ 	""github.com/mysteriumnetwork/node/market""
+ )
+
++// ServiceType indicates ""wireguard"" service type
++const ServiceType = ""wireguard""
++
+ // Bootstrap is called on program initialization time and registers various deserializers related to wireguard service
+ func Bootstrap() {
+ 	market.RegisterServiceDefinitionUnserializer(",Why should we move it into `bootstrap.go` file?
+6021,"@@ -24,8 +24,15 @@ const fontSizes = [
+   72
+ ]
+
++const measures = [
++  24,
++  32,
++  48
++]
++
+ module.exports = {
+   breakpoints,
+   space,
+   fontSizes,
++  measures
+ }","In the next major version, I plan on changing the em-unit breakpoints to be pixel values to keep everything consistent. Would be great to handle this with pixels as well, but still allow em-units to be defined with a string"
+6022,"@@ -151,7 +151,7 @@ class TabWidget(QTabWidget):
+
+         fields = self.get_tab_fields(idx)
+         fields['current_title'] = fields['current_title'].replace('&', '&&')
+-        fields['index'] = idx + 1
++        fields['index'] = str(idx + 1).rjust(2)
+
+         title = '' if fmt is None else fmt.format(**fields)
+         tabbar = self.tabBar()","I don't think this will actually align the indexes, if you have > 100 tabs, the tabs over 100 will be misaligned. In addition with less than 10 tabs, there will be a pointless space."
+6023,"@@ -326,7 +326,7 @@ func (v4 *signer) buildCanonicalHeaders(r rule, header http.Header) {
+ 			headerValues[i] = ""host:"" + v4.Request.URL.Host
+ 		} else {
+ 			headerValues[i] = k + "":"" +
+-				strings.Join(v4.Request.Header[http.CanonicalHeaderKey(k)], "","")
++				strings.Join(v4.signedHeaderVals[k], "","")
+ 		}
+ 	}
+ ","hrm, unsigned headers now won't be included."
+6024,"@@ -53,6 +53,7 @@ class CategoryCode
+      */
+     public static function isValid(string $value): bool
+     {
+-        return strlen($value) <= 255;
++        return '' !== $value
++            && strlen($value) < 256;
+     }
+ }",what if `$value = ' ' `?
+6025,"@@ -262,10 +262,16 @@ class SparkWrite {
+   private class DynamicOverwrite extends BaseBatchWrite {
+     @Override
+     public void commit(WriterCommitMessage[] messages) {
++      Iterable<DataFile> files = files(messages);
++      if (Iterables.size(files) == 0) {
++        LOG.info(""Dynamic overwrite is empty, skipping commit"");
++        return;
++      }
++
+       ReplacePartitions dynamicOverwrite = table.newReplacePartitions();
+
+       int numFiles = 0;
+-      for (DataFile file : files(messages)) {
++      for (DataFile file : files) {
+         numFiles += 1;
+         dynamicOverwrite.addFile(file);
+       }",What about using `!files.hasNext` instead? I'm not sure we want to assume that the iterable can be consumed multiple times. Plus there's no need to consume the entire iterable just to check whether it is empty.
+6026,"@@ -85,6 +85,11 @@ Container* Container::getParentContainer()
+ 	return thing->getContainer();
+ }
+
++std::string Container::getName() const {
++	const ItemType& it = items[id];
++	return getNameDescription(it, this, -1, false);
++}
++
+ bool Container::hasParent() const
+ {
+ 	return getID() != ITEM_BROWSEFIELD && dynamic_cast<const Player*>(getParent()) == nullptr;",I think we could add bool addArticle here defaulted to false like its done in item class so std::string Container::getName(bool addArticle /* = false*/) const { and pass that variable to getNameDescription call
+6027,"@@ -47,11 +47,11 @@ public class LockableBottomSheetBehavior<V extends View> extends ViewPagerBottom
+
+     @Override
+     public boolean onStartNestedScroll(CoordinatorLayout coordinatorLayout, V child, View directTargetChild,
+-                                       View target, int nestedScrollAxes) {
++                                       View target, int axes, int type) {
+         boolean handled = false;
+
+         if (!isLocked) {
+-            handled = super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, nestedScrollAxes);
++            handled = super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, axes, type);
+         }
+
+         return handled;",What if a library function on the outside still calls the old method? It is then no longer blocked properly. Have you tested the change?
+6028,"@@ -197,11 +197,15 @@ static mrb_value build_app_response(struct st_mruby_subreq_t *subreq)
+     return resp;
+ }
+
+-static void append_bufs(struct st_mruby_subreq_t *subreq, h2o_iovec_t *inbufs, size_t inbufcnt)
++static void append_bufs(struct st_mruby_subreq_t *subreq, h2o_sendvec_t *inbufs, size_t inbufcnt)
+ {
+-    int i;
++    size_t i;
+     for (i = 0; i != inbufcnt; ++i) {
+-        h2o_buffer_append(&subreq->buf, inbufs[i].base, inbufs[i].len);
++        char *dst = h2o_buffer_reserve(&subreq->buf, inbufs[i].len).base;
++        assert(dst != NULL && ""no memory or disk space; FIXME bail out gracefully"");
++        if (!(*inbufs[i].fill_cb)(&subreq->super, h2o_iovec_init(dst, inbufs[i].len), inbufs + i, 0))
++            h2o_fatal(""FIXME handle error from pull handler"");
++        subreq->buf->size += inbufs[i].len;
+     }
+ }
+ ","@i110 Do you have an idea on how we should propagate errors that occur in this block? The error condition happens when i) `h2o_buffer_reserve` fails to allocate space (happens in master as well), or ii) `fill_cb` returns an error (unique to this PR)."
+6029,"@@ -3,7 +3,7 @@ class ReportMailer < ApplicationMailer
+
+   def budget_status
+     to_email = ENV.fetch('BUDGET_REPORT_RECIPIENT')
+-    date = Time.now.in_time_zone('Eastern Time (US & Canada)').strftime(""%a %m/%d/%y"")
++    date = Time.now.utc.strftime(""%a %m/%d/%y (%Z)"")
+
+     mail(
+       to: to_email,",Does this mean the times will show up in emails as UTC?
+6030,"@@ -191,11 +191,10 @@ options.Bounds = Options('style', color='black')
+ options.Ellipse = Options('style', color='black')
+ options.Polygons = Options('style', color=Cycle(), line_color='black',
+                            cmap=dflt_cmap)
+-options.Rectangles = Options('style', cmap=dflt_cmap)
+-options.Segments = Options('style', cmap=dflt_cmap)
+
+ # Geometries
+-options.Rectangles = Options('style', line_color='black')
++options.Rectangles = Options('style', color=Cycle(), cmap=dflt_cmap, line_color='black')
++options.Segments = Options('style', color='black', cmap=dflt_cmap)
+
+ # Rasters
+ options.Image = Options('style', cmap=config.default_gridded_cmap)",What's the motivation for having one of these be a cycle and the other be a fixed color?
+6031,"@@ -136,7 +136,7 @@ namespace ResultsComparer
+
+             var table = data.ToMarkdownTable().WithHeaders(conclusion.ToString(), conclusion == EquivalenceTestConclusion.Faster ? ""base/diff"" : ""diff/base"", ""Base Median (ns)"", ""Diff Median (ns)"", ""Modality"");
+
+-            foreach (var line in table.ToMarkdown().Split(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries))
++            foreach (var line in table.ToMarkdown().Split(Environment.NewLine))
+                 Console.WriteLine($""| {line.TrimStart()}|""); // the table starts with \t and does not end with '|' and it looks bad so we fix it
+
+             Console.WriteLine();",What will be an empty entry now?
+6032,"@@ -71,6 +71,10 @@ export class ManualColumnResize extends BasePlugin {
+     addClass(this.guide, 'manualColumnResizerGuide');
+   }
+
++  get inlineDir() {
++    return this.hot.isRtl() ? 'right' : 'left';
++  }
++
+   /**
+    * Checks if the plugin is enabled in the handsontable settings. This method is executed in {@link Hooks#beforeInit}
+    * hook and if it returns `true` than the {@link ManualColumnResize#enablePlugin} method is called.",Can I ask you to add jsdoc tag that would mark the prop as `@private`?
+6033,"@@ -113,3 +113,13 @@ func WriteFile(fromFile io.Reader, to string, mode os.FileMode) error {
+ 	// And move it to its final destination.
+ 	return os.Rename(tempFile.Name(), to)
+ }
++
++// IsDirectory checks if a given path is a directory
++func IsDirectory(path string) bool {
++	info, err := os.Stat(path)
++	if err != nil {
++		return false
++	}
++
++	return info.IsDir()
++}",Do you need this? Don't think you use it?
+6034,"@@ -0,0 +1,13 @@
++package com.fsck.k9.widget.list;
++
++
++import android.content.Intent;
++import android.widget.RemoteViewsService;
++
++
++public class MessageListWidgetService extends RemoteViewsService {
++    @Override
++    public RemoteViewsFactory onGetViewFactory(Intent intent) {
++        return new MessageListRemoteViewFactory(this.getApplicationContext());
++    }
++}",`this.` seems unnecessary
+6035,"@@ -244,8 +244,8 @@ def connect_to_service(service_name, client=True, env=None, region_name=None, en
+                 endpoint_url = backend_url
+         config = config or botocore.client.Config()
+         # configure S3 path style addressing
+-        if service_name == 's3':
+-            config.s3 = {'addressing_style': 'path'}
++        # if service_name == 's3':
++        #     config.s3 = {'addressing_style': 'path'}
+         # To, prevent error ""Connection pool is full, discarding connection ..."",
+         # set the environment variable MAX_POOL_CONNECTIONS. Default is 150.
+         config.max_pool_connections = MAX_POOL_CONNECTIONS",nit: can be removed before merging...
+6036,"@@ -2,7 +2,7 @@ describe('ContextMenu', function () {
+   var id = 'testContainer';
+
+   beforeEach(function () {
+-    this.$container = $('<div id=""' + id + '""></div>').appendTo('body');
++    this.$container = $(`<div id=""${id}""></div>`).appendTo('body');
+   });
+
+   afterEach(function () {",Maybe a single quote would be compatible with airbnb style.
+6037,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+
+   public abstract void remove(SessionId id);
+
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.
+6038,"@@ -279,11 +279,9 @@ func TestFormatWithComments(t *testing.T) {
+
+ 	if want := `// hi
+ // there
+-{
+-    _time: r._time,
+-    io_time: r._value,
+-// this is the end
+-}
++{_time: r._time, io_time: r._value
++    // this is the end
++    }
+
+ // minimal
+ foo = (arg=[1, 2]) => 1","@Marwes @wolffcm This is the file where I made a change the the expected output. Its a little bit weird, but I think that the final output makes sense for the most part."
+6039,"@@ -94,9 +94,11 @@ func IsValidAppType(apptype string) bool {
+ func (app *DdevApp) CreateSettingsFile() (string, error) {
+ 	app.SetApptypeSettingsPaths()
+
+-	// If neither settings file options are set, then don't continue
++	// If neither settings file options are set, then don't continue. Return
++	// a nil error because this should not halt execution if the apptype
++	// does not have a settings definition.
+ 	if app.SiteLocalSettingsPath == """" && app.SiteSettingsPath == """" {
+-		return """", fmt.Errorf(""Neither SiteLocalSettingsPath nor SiteSettingsPath is set"")
++		return """", nil
+ 	}
+
+ 	// Drupal and WordPress love to change settings files to be unwriteable.",I think we probably need a util.Warning() here.
+6040,"@@ -0,0 +1,19 @@
++from quilt3.util import PhysicalKey, get_from_config, fix_url
++
++from .base import PackageRegistry
++from .local import LocalPackageRegistryV1
++from .s3 import S3PackageRegistryV1
++
++
++def get_package_registry(path=None) -> PackageRegistry:
++    """""" Returns the package registry for a given path """"""
++    # TODO: Don't check if it's PackageRegistry? Then we need better separation
++    #       to external functions that receive string and internal that receive
++    #       PackageRegistry.
++    if isinstance(path, PackageRegistry):
++        return path
++    if not isinstance(path, PhysicalKey):
++        path = PhysicalKey.from_url(
++            get_from_config('default_local_registry') if path is None else fix_url(path)
++        )
++    return (LocalPackageRegistryV1 if path.is_local() else S3PackageRegistryV1)(path)","Let's make have a signature that's consistent with `PhysicalKey.from_path`. Users should also have access to PhysicalKey since that class is part of the API (e.g., `Package.resolve_hash`)."
+6041,"@@ -0,0 +1,10 @@
++/*eslint no-unused-vars: 0*/
++/* exported utils */
++
++/**
++ * Namespace for imports which holds globals of external dependencies.
++ * @namespace imports
++ * @memberof axe
++ */
++
++var imports = (axe.imports = {});",What is this directive for?
+6042,"@@ -155,6 +155,10 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+                   'if a key is present or a default if not, is simpler and considered '
+                   'more idiomatic, although sometimes a bit slower'
+                  ),
++        'R1716': ('simplify chained comparison',
++                  'chained-comparison',
++                  'Chained comparisons like ""a < b and b < c"" can be simplified as ""a < b < c""',
++                  ),
+     }
+     options = (('max-nested-blocks',
+                 {'default': 5, 'type': 'int', 'metavar': '<int>',",I'd rephrase it as `Simplify chained comparison between the operands`.
+6043,"@@ -296,11 +296,10 @@ class ProductDataFixture
+         $this->clearResources();
+         $this->productsByCatnum = [];
+
+-        $onlyForFirstDomain = false;
+         $this->productDataReferenceInjector->loadReferences(
+             $this->productDataFixtureLoader,
+             $this->persistentReferenceFacade,
+-            $onlyForFirstDomain
++            2
+         );
+     }
+ ","so in the performance data fixtures, there will be references for the second domain only?"
+6044,"@@ -304,7 +304,7 @@ public class DefaultGridRegistry extends BaseGridRegistry implements GridRegistr
+     if (proxy == null) {
+       return;
+     }
+-    LOG.info(""Registered a node "" + proxy);
++    LOG.finest(""Registered a node "" + proxy);
+     try {
+       lock.lock();
+ ",This is wildly unhelpful to users --- they need to know when a proxy has been registered.
+6045,"@@ -203,7 +203,7 @@ class ClientPlayback:
+             # https://github.com/mitmproxy/mitmproxy/issues/2197
+             if hf.request.http_version == ""HTTP/2.0"":
+                 hf.request.http_version = ""HTTP/1.1""
+-                host = hf.request.headers.pop("":authority"")
++                host = hf.request.headers.pop("":authority"", hf.request.pretty_host)
+                 hf.request.headers.insert(0, ""host"", host)
+             self.q.put(hf)
+         ctx.master.addons.trigger(""update"", lst)","If there is no authority header (i.e. someone intentionally deleted it), I would argue we probably don't want a Host header in the replay either. How about we only add it if it exists, and do nothing otherwise?"
+6046,"@@ -65,12 +65,7 @@ func TaskMetadataHandler(state dockerstate.TaskEngineState, ecsClient api.ECSCli
+ 			for _, containerResponse := range taskResponse.Containers {
+ 				networks, err := GetContainerNetworkMetadata(containerResponse.ID, state)
+ 				if err != nil {
+-					errResponseJSON, err := json.Marshal(err.Error())
+-					if e := utils.WriteResponseIfMarshalError(w, err); e != nil {
+-						return
+-					}
+-					utils.WriteJSONToResponse(w, http.StatusInternalServerError, errResponseJSON, utils.RequestTypeContainerMetadata)
+-					return
++					seelog.Warnf(""Error retrieving network metadata for container %s - %s"", containerResponse.ID, err)
+ 				}
+ 				containerResponse.Networks = networks
+ 				responses = append(responses, containerResponse)",is there any unit test that can be updated to verify this?
+6047,"@@ -418,7 +418,18 @@ static int cb_lua_filter(const void *data, size_t bytes,
+         lua_pushstring(ctx->lua->state, tag);
+         lua_pushnumber(ctx->lua->state, ts);
+         lua_pushmsgpack(ctx->lua->state, p);
+-        lua_call(ctx->lua->state, 3, 3);
++        if (ctx->protected_mode) {
++            ret = lua_pcall(ctx->lua->state, 3, 3, 0);
++            if (ret != 0) {
++                flb_plg_error(ctx->ins, ""error code %d: %s"",
++                              ret, lua_tostring(ctx->lua->state, -1));
++                lua_pop(ctx->lua->state, 1);
++                return FLB_FILTER_NOTOUCH;
++            }
++        }
++        else {
++            lua_call(ctx->lua->state, 3, 3);
++        }
+
+         /* Initialize Return values */
+         l_code = 0;","exiting at this point is leaking memory, take a look at the valgrind output. the sbuffer must be destroyed."
+6048,"@@ -0,0 +1,13 @@
++def pytest_addoption(parser):
++    parser.addoption(
++        '--poppler',
++        action='store_true',
++        dest='poppler',
++        default=False,
++        help=""Indicates poppler tools (incl. pdftoppm) installed""
++    )
++
++
++def pytest_configure(config):
++    if not config.option.poppler:
++        setattr(config.option, 'markexpr', 'not poppler')",i think you want a different flag and help like `--ffmpeg` or something; and you need to mark any tests you want skipped
+6049,"@@ -32,9 +32,10 @@ import (
+ 	""github.com/golang/protobuf/proto""
+ 	""github.com/golang/protobuf/ptypes""
+ 	""github.com/golang/protobuf/ptypes/empty""
+-	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
+ 	auditpb ""google.golang.org/genproto/googleapis/cloud/audit""
+ 	logpb ""google.golang.org/genproto/googleapis/logging/v2""
++
++	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
+ )
+
+ const (",this needed to change? or it was just some formatting thing?
+6050,"@@ -278,10 +278,11 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+     params.add(""--auto-log-bloom-caching-enabled"");
+     params.add(""false"");
+
+-    String level = System.getProperty(""root.log.level"");
+-    if (level != null) {
+-      params.add(""--logging="" + level);
+-    }
++    // String level = System.getProperty(""root.log.level"");
++    // if (level != null) {
++    //  params.add(""--logging="" + level);
++    // }
++    params.add(""--logging=TRACE"");
+
+     LOG.info(""Creating besu process with params {}"", params);
+     final ProcessBuilder processBuilder =","What's the advantage of doing it this way over, say, changing the `.circleci/config.yaml` to have `TRACE` as the `root.log.level`?"
+6051,"@@ -49,6 +49,15 @@ class ApiClient(object):
+             dataset_id (str): id of the dataset to query.
+         """"""
+
++    @abc.abstractmethod
++    def fetch_bigquery_iam_policy(self, project_number, dataset_id):
++        """"""Gets IAM policy if a bigquery dataset from gcp API call.
++
++        Args:
++            project_number (str): number of the project to query.
++            dataset_id (str): id of the dataset to query.
++        """"""
++
+     @abc.abstractmethod
+     def iter_bigquery_datasets(self, project_number):
+         """"""Iterate Datasets from GCP API.",typo: if -> of
+6052,"@@ -270,7 +270,10 @@ func (templateContext) funcMarkdown(input interface{}) (string, error) {
+ 	buf.Reset()
+ 	defer bufPool.Put(buf)
+
+-	md.Convert([]byte(inputStr), buf)
++	err := md.Convert([]byte(inputStr), buf)
++	if err != nil {
++		return """", err
++	}
+
+ 	return buf.String(), nil
+ }",It'll be interesting to see who or what this breaks...
+6053,"@@ -96,7 +96,7 @@ public class InternalSelenseTestBase extends SeleneseTestBase {
+       return;
+     }
+
+-    log.info(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
++    log.finest(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
+
+     Path dir =
+       InProject.locate(""java/client/build/production/com/thoughtworks/selenium/webdriven"");",This change is incorrect: the current log level is correct.
+6054,"@@ -58,7 +58,7 @@ type clientFactory struct {
+
+ // NewClientFactory creates a new ClientFactory
+ func NewClientFactory() ClientFactory {
+-	logger := log.NewDefaultLogger()
++	logger := log.NewTestLogger()
+
+ 	return &clientFactory{
+ 		logger: logger,",There are few cases like this where default logger is used from CLI/db tools. I would copy `NewTestLogger` to `NewCLILogger` and use it everywhere in CLI. In future these two might be different.
+6055,"@@ -222,4 +222,16 @@ public abstract class AbstractAuthenticationToken implements Authentication,
+
+ 		return sb.toString();
+ 	}
++
++	protected static Integer extractKeyHash(String key) {
++		Object value = nullSafeValue(key);
++		return value.hashCode();
++	}
++
++	protected static Object nullSafeValue(Object value){
++		if(value == null || """".equals(value)) {
++			throw new IllegalArgumentException(""Cannot pass null or empty values to constructor"");
++		}
++		return value;
++	}
+ }","While it provides re-use, this method does not make sense in `AbstractAuthenticationToken` because it knows nothing of a hash key. Instead, we should move this to a private method within each subclass."
+6056,"@@ -322,7 +322,7 @@ def extract_record_set(records, filters, sorting,
+         paginated = {}
+         for rule in pagination_rules:
+             values = apply_filters(filtered, rule)
+-            paginated.update(((x[id_field], x) for x in values))
++            paginated.update((id(x), x) for x in values)
+         paginated = paginated.values()
+     else:
+         paginated = filtered",index by memory address? I realize I don't understand why we don't just build a list :)
+6057,"@@ -7,6 +7,7 @@ import db.user
+
+ user_bp = Blueprint(""user"", __name__)
+
++
+ @user_bp.route(""/lastfmscraper/<user_id>.js"")
+ @crossdomain()
+ def lastfmscraper(user_id):","Not part of this commit, but we thought that this may not be a good place for this url, as it is in the `/user/` namespace (effectively preventing us having a user called `lastfmscraper`, however rare it may be)"
+6058,"@@ -25,6 +25,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+         internal const string HttpContextKey = ""__Datadog.Trace.ClrProfiler.Integrations.AspNetMvcIntegration"";
+
+         private const string OperationName = ""aspnet-mvc.request"";
++        private const string ChildActionOperationName = ""aspnet-mvc.request.child-action"";
+
+         private const string RouteCollectionRouteTypeName = ""System.Web.Mvc.Routing.RouteCollectionRoute"";
+ ",Does not appear to be used.
+6059,"@@ -0,0 +1,15 @@
++test_name ""C100546: bolt command run should execute command on remote hosts\
++           via ssh"" do
++  step ""execute `bolt command run` via SSH"" do
++    ssh_nodes = select_hosts(roles: ['ssh'])
++    nodes_csv = ssh_nodes.map(&:hostname).join(',')
++    command = 'hostname -f'
++    bolt_command = ""bolt command run --nodes #{nodes_csv} '#{command}'""
++    case bolt['platform']
++    when /windows/
++      execute_powershell_script_on(bolt, bolt_command)
++    else
++      on(bolt, bolt_command)
++    end
++  end
++end","I think this starts a new `powershell.exe` interpreter each time, which is pretty slow to run a single command. Can we just do `on(bolt, ""cmd /c #{bolt_command}"")`? /cc @Iristyle"
+6060,"@@ -1,14 +1,14 @@
+-<% if @purchaseable.collection? %>
++<% if @video_page.purchaseable.collection? %>
+   <% content_for :additional_header_links do %>
+-    <li class=""all-videos""><%= link_to 'All Videos', @purchase %></li>
++    <li class=""all-videos""><%= link_to 'All Videos', @video_page.purchase %></li>
+   <% end %>
+ <% end %>
+
+ <% content_for :subject_block do %>
+-  <h1><%= @purchaseable.name %></h1>
++  <h1><%= @video_page.purchaseable.name %></h1>
+   <h2 class=""tagline"">
+-    <% if @purchaseable.collection? %>
+-      <%= @video.title %>
++    <% if @video_page.purchaseable.collection? %>
++      <%= @video_page.video.title %>
+     <% else %>
+       Watch or download video
+     <% end %>",Can we add a `collection?` method to the `VideoPage` so we don't violate Law of Demeter here?
+6061,"@@ -1250,14 +1250,6 @@ public class ProjectManagerServlet extends LoginAbstractAzkabanServlet {
+       page.add(""errorMsg"", e.getMessage());
+     }
+
+-    final int numBytes = 1024;
+-
+-    // Really sucks if we do a lot of these because it'll eat up memory fast.
+-    // But it's expected that this won't be a heavily used thing. If it is,
+-    // then we'll revisit it to make it more stream friendly.
+-    final StringBuffer buffer = new StringBuffer(numBytes);
+-    page.add(""log"", buffer.toString());
+-
+     page.render();
+   }
+ ",Deleting unused code.
+6062,"@@ -1,6 +1,7 @@
+ import torch
+
+-from ..bbox import PseudoSampler, assign_and_sample, bbox2delta, build_assigner
++from ..bbox import assign_and_sample, bbox2delta, build_assigner
++from ..bbox.samplers.pseudo_sampler import PseudoSampler
+ from ..utils import multi_apply
+
+ ",`PseudoSampler` can also be imported from `..bbox`
+6063,"@@ -19,6 +19,7 @@ package agreementtest
+
+ import (
+ 	""fmt""
++	""github.com/algorand/go-algorand/protocol""
+ 	""strconv""
+ 	""time""
+ ",Could you move this import to where the other `github.com/algorand/go-algorand` imports are?
+6064,"@@ -655,7 +655,7 @@ class Conf(ConfClass):
+     # can, tls, http are not loaded by default
+     load_layers = ['bluetooth', 'bluetooth4LE', 'dhcp', 'dhcp6', 'dns',
+                    'dot11', 'dot15d4', 'eap', 'gprs', 'hsrp', 'inet',
+-                   'inet6', 'ipsec', 'ir', 'isakmp', 'l2', 'l2tp',
++                   'inet6', 'ipsec', 'ir', 'isakmp', 'l2', 'l2tp','l2f',
+                    'llmnr', 'lltd', 'mgcp', 'mobileip', 'netbios',
+                    'netflow', 'ntp', 'ppi', 'ppp', 'pptp', 'radius', 'rip',
+                    'rtp', 'sctp', 'sixlowpan', 'skinny', 'smb', 'smb2', 'snmp',","I'd rather not activate this protocol by default for now, unless there is a good reason for that."
+6065,"@@ -19,11 +19,14 @@ import inspect
+ # pylint: disable=line-too-long
+ from google.cloud.forseti.common.util import logger
+ from google.cloud.forseti.common.util import string_formats
++from google.cloud.forseti.services.inventory.storage import DataAccess
++from google.cloud.forseti.services.scanner import dao as scanner_dao
+ from google.cloud.forseti.notifier.notifiers.base_notification import BaseNotification
+ from google.cloud.forseti.notifier.notifiers import cscc_notifier
++from google.cloud.forseti.notifier.notifiers import email_violations
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+-from google.cloud.forseti.services.inventory.storage import DataAccess
+-from google.cloud.forseti.services.scanner import dao as scanner_dao
++
++
+ # pylint: enable=line-too-long
+
+ ",Remove these 2 blank lines.
+6066,"@@ -606,6 +606,7 @@ func (pool *TxPool) validateTx(tx types.Transaction, local bool) error {
+ func (pool *TxPool) add(tx types.Transaction, local bool) (replaced bool, err error) {
+ 	// If the transaction is already known, discard it
+ 	hash := tx.Hash()
++	fmt.Printf(""aa: %x\n"", hash)
+ 	if pool.all.Get(hash) != nil {
+ 		log.Trace(""Discarding already known transaction"", ""hash"", hash)
+ 		knownTxMeter.Mark(1)",Want to remove this?
+6067,"@@ -2,6 +2,7 @@ package sql
+
+ import (
+ 	""github.com/jinzhu/gorm""
++	// gorm postgres dialect init registration
+ 	_ ""github.com/jinzhu/gorm/dialects/postgres""
+ )
+ ",is this a golint requirement? huh. mixed feelings :)
+6068,"@@ -33,6 +33,14 @@ public class BCryptPasswordEncoderTests {
+ 		String result = encoder.encode(""password"");
+ 		assertThat(result.equals(""password"")).isFalse();
+ 		assertThat(encoder.matches(""password"", result)).isTrue();
++		encoder = new BCryptPasswordEncoder(BCryptPasswordEncoder.BCRYPT_VERSION_2B);
++		result = encoder.encode(""password"");
++		assertThat(result.equals(""password"")).isFalse();
++		assertThat(encoder.matches(""password"", result)).isTrue();
++		encoder = new BCryptPasswordEncoder(BCryptPasswordEncoder.BCRYPT_VERSION_2Y);
++		result = encoder.encode(""password"");
++		assertThat(result.equals(""password"")).isFalse();
++		assertThat(encoder.matches(""password"", result)).isTrue();
+ 	}
+
+ 	@Test",Generally with these tests please split up these tests so that there is a different test for each method
+6069,"@@ -1394,16 +1394,16 @@ void nano::bootstrap_attempt::lazy_add (nano::block_hash const & hash_a)
+ 	}
+ }
+
+-void nano::bootstrap_attempt::lazy_pull_flush ()
++void nano::bootstrap_attempt::lazy_pull_flush (std::unique_lock<std::mutex> & lock_a)
+ {
+-	std::unique_lock<std::mutex> lock (lazy_mutex);
++	std::unique_lock<std::mutex> lazy_lock (lazy_mutex);
+ 	auto transaction (node->store.tx_begin_read ());
+ 	for (auto & pull_start : lazy_pulls)
+ 	{
+ 		// Recheck if block was already processed
+ 		if (lazy_blocks.find (pull_start) == lazy_blocks.end () && !node->store.block_exists (transaction, pull_start))
+ 		{
+-			add_pull (nano::pull_info (pull_start, pull_start, nano::block_hash (0), lazy_max_pull_blocks));
++			pulls.push_back (nano::pull_info (pull_start, pull_start, nano::block_hash (0), lazy_max_pull_blocks));
+ 		}
+ 	}
+ 	lazy_pulls.clear ();",Should something use the lock passed in?
+6070,"@@ -101,7 +101,7 @@ class Docker(base.Base):
+
+     When attempting to utilize a container image with `systemd`_ as your init
+     system inside the container to simulate a real machine, make sure to set
+-    the ``privileged``, ``volume_mounts``, ``command``, and ``environment``
++    the ``privileged``, ``volumes``, ``command``, and ``environment``
+     values. An example using the ``centos:7`` image is below:
+
+     .. note:: Do note that running containers in privileged mode is considerably",Is this dependant on some version of Docker? Do we need to include both or `volumes` is deprecated (or just wrong!?)?
+6071,"@@ -1306,7 +1306,7 @@ public class CollectionsHandler extends RequestHandlerBase implements Permission
+     try (ZkShardTerms zkShardTerms = new ZkShardTerms(collectionName, slice.getName(), zkController.getZkClient())) {
+       // if an active replica is the leader, then all is fine already
+       Replica leader = slice.getLeader();
+-      if (leader != null && leader.getState() == State.ACTIVE) {
++      if (leader != null && leader.getState() == State.ACTIVE && zkShardTerms.getHighestTerm() == zkShardTerms.getTerm(leader.getName())) {
+         throw new SolrException(ErrorCode.SERVER_ERROR,
+             ""The shard already has an active leader. Force leader is not applicable. State: "" + slice);
+       }","I know this is not new code, but should we change `leader.getState() == State.ACTIVE` to `leader.isActive(liveNodes)`?"
+6072,"@@ -105,7 +105,7 @@ public class JavaRuleViolation extends ParametricRuleViolation<JavaNode> {
+     private void setClassNameFrom(JavaNode node) {
+         String qualifiedName = null;
+
+-        if (node.getScope() instanceof ClassScope) {
++        if (node instanceof AbstractAnyTypeDeclaration && node.getScope() instanceof ClassScope) {
+             qualifiedName = ((ClassScope) node.getScope()).getClassName();
+         }
+ ",Why not use ASTAnyTypeDeclaration? AbstractAnyTypeDeclaration is deprecated
+6073,"@@ -119,3 +119,5 @@ from .tools.command import (
+     version_add,
+     version_list,
+ )
++
++from .tools.util import save","A blank line at the very end of each file should eliminate the ""No EOF"" warning we see above"
+6074,"@@ -818,15 +818,12 @@ func (h *Handler) SignalWithStartWorkflowExecution(ctx context.Context, request
+
+ 		// Two simultaneous SignalWithStart requests might try to start a workflow at the same time.
+ 		// This can result in one of the requests failing with one of two possible errors:
+-		//    1) If it is a brand new WF ID, one of the requests can fail with WorkflowExecutionAlreadyStartedError
+-		//       (createMode is persistence.CreateWorkflowModeBrandNew)
+-		//    2) If it an already existing WF ID, one of the requests can fail with a CurrentWorkflowConditionFailedError
+-		//       (createMode is persisetence.CreateWorkflowModeWorkflowIDReuse)
++		//    CurrentWorkflowConditionFailedError || WorkflowConditionFailedError
+ 		// If either error occurs, just go ahead and retry. It should succeed on the subsequent attempt.
+ 		// For simplicity, we keep trying unless the context finishes or we get an error that is not one of the
+ 		// two mentioned above.
+-		_, isExecutionAlreadyStartedErr := err2.(*persistence.WorkflowExecutionAlreadyStartedError)
+-		_, isWorkflowConditionFailedErr := err2.(*persistence.CurrentWorkflowConditionFailedError)
++		_, isCurrentWorkflowConditionFailedErr := err2.(*persistence.CurrentWorkflowConditionFailedError)
++		_, isWorkflowConditionFailedErr := err2.(*persistence.WorkflowConditionFailedError)
+
+ 		isContextDone := false
+ 		select {",These would both be more robust with `errors.As` so that we could safely chain errors.
+6075,"@@ -299,9 +299,9 @@ SwiftArrayBufferHandler::CreateBufferHandler(ValueObject &valobj) {
+
+   // For now we have to keep the old mangled name since the Objc->Swift bindings
+   // that are in Foundation don't get the new mangling.
+-  if (valobj_typename.startswith(SwiftLanguageRuntime::GetCurrentMangledName(""_TtCs23_ContiguousArrayStorage""))
+-      || valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"")
+-      || valobj_typename.startswith(""Swift._ContiguousArrayStorage"")) {
++  if (valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"") ||
++      valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"") ||
++      valobj_typename.startswith(""Swift._ContiguousArrayStorage"")) {
+     CompilerType anyobject_type =
+         valobj.GetTargetSP()->GetScratchClangASTContext()->GetBasicType(
+             lldb::eBasicTypeObjCID);",This is checking the same condition twice?
+6076,"@@ -157,8 +157,16 @@ void lbann_comm::allreduce(AbsDistMat& m,
+ #ifdef LBANN_HAS_GPU
+   if (m.GetLocalDevice() == El::Device::GPU) {
+ #ifdef AL_HAS_NCCL
+-    // Force GPU matrices to use NCCL.
++    // We require NCCL for GPU matrices.
+     t = std::type_index(typeid(::Al::NCCLBackend));
++    // If available, use the MPI-CUDA backend for small matrices.
++#ifdef AL_HAS_MPI_CUDA
++    // Based on runs on Pascal and Ray.
++    if ((El::mpi::Size(c) > 4 && local_size <= 8192) ||
++        (El::mpi::Size(c) >= 16 && local_size <= 32768)) {
++      t = std::type_index(typeid(::Al::MPICUDABackend));
++    }
++#endif  // AL_HAS_MPI_CUDA
+ #else
+     throw lbann_exception(""Allreduce on GPU matrix requires NCCL support in""
+                           "" Aluminum"");","Aren't we able to handle the case where we have MPI-CUDA without NCCL, even if it's suboptimal?"
+6077,"@@ -37,6 +37,12 @@ Copyright (C) 2001-2016 EQEMu Development Team (http://eqemulator.net)
+
+ extern QueryServ* QServ;
+
++namespace detail
++{
++	static const uint32 PhantomStatId = 999999;
++}
++
++
+ void Mob::TemporaryPets(uint16 spell_id, Mob *targ, const char *name_override, uint32 duration_override, bool followme, bool sticktarg, uint16 *eye_id) {
+
+ 	//It might not be a bad idea to put these into the database, eventually..",Wouldn't we want to namespace this `AA` or something similar
+6078,"@@ -395,7 +395,13 @@ func newSession(opts Options, envCfg envConfig, cfgs ...*aws.Config) (*Session,
+ 	// Load additional config from file(s)
+ 	sharedCfg, err := loadSharedConfig(envCfg.Profile, cfgFiles, envCfg.EnableSharedConfig)
+ 	if err != nil {
+-		if _, ok := err.(SharedConfigProfileNotExistsError); !ok {
++		if len(envCfg.Profile) == 0 && !envCfg.EnableSharedConfig && envCfg.Creds.HasKeys() {
++			// Special case where the user has not explicitly specified an AWS_PROFILE,
++			// or session.Options.profile, shared config is not enabled, and the
++			// environment has credentials, allow the shared config file to fail to
++			// load since the user has already provided credentials, and nothing else
++			// is required to be read file. Github(aws/aws-sdk-go#2455)
++		} else if _, ok := err.(SharedConfigProfileNotExistsError); !ok {
+ 			return nil, err
+ 		}
+ 	}","This probably should look beyond envConfig, and include `aws.Config.Credentials` as well."
+6079,"@@ -110,6 +110,7 @@ namespace Nethermind.TxPool
+             _filterPipeline.Add(new TooFarNonceFilter(txPoolConfig, _accounts, _transactions, _logger));
+             _filterPipeline.Add(new TooExpensiveTxFilter(_headInfo, _accounts, _logger));
+             _filterPipeline.Add(new FeeToLowFilter(_headInfo, _accounts, _transactions, _logger));
++            _filterPipeline.Add(new NotEnoughBalanceFilter(_headInfo, _accounts, _logger));
+             _filterPipeline.Add(new ReusedOwnNonceTxFilter(_accounts, _nonces, _logger));
+             if (incomingTxFilter is not null)
+             {",How does this filter differ from TooExpensiveTxFilter?
+6080,"@@ -217,6 +217,17 @@ public class Project {
+     return users;
+   }
+
++  public List<String> getGroupsWithPermission(final Type type) {
++    final ArrayList<String> groups = new ArrayList<>();
++    for (final Map.Entry<String, Permission> entry : this.groupPermissionMap.entrySet()) {
++      final Permission perm = entry.getValue();
++      if (perm.isPermissionSet(type)) {
++        groups.add(entry.getKey());
++      }
++    }
++    return groups;
++  }
++
+   public List<Pair<String, Permission>> getUserPermissions() {
+     final ArrayList<Pair<String, Permission>> permissions =
+         new ArrayList<>();","Use "" List<String>"" instead of ArrayList<String> in declaration."
+6081,"@@ -93,8 +93,10 @@ class ObjectStore(six.with_metaclass(ABCMeta)):
+         return self.set_object(obj, context, runtime_type, paths)
+
+     def get_value(self, context, runtime_type, paths):
+-        if runtime_type in self.TYPE_REGISTRY:
+-            return self.TYPE_REGISTRY[runtime_type].get_object(self, context, runtime_type, paths)
++        if runtime_type.name is not None and runtime_type.name in self.TYPE_REGISTRY:
++            return self.TYPE_REGISTRY[runtime_type.name].get_object(
++                self, context, runtime_type, paths
++            )
+         return self.get_object(context, runtime_type, paths)
+
+ ",we might consider hard throwing when name is None since that is explicitly not working right now and then linking to issue in the exception error message
+6082,"@@ -1,13 +1,19 @@
+
+ package edu.harvard.iq.dataverse;
+
++import edu.harvard.iq.dataverse.util.BundleUtil;
+ import java.io.Serializable;
++import java.util.MissingResourceException;
+ import javax.persistence.Entity;
+ import javax.persistence.GeneratedValue;
+ import javax.persistence.GenerationType;
+ import javax.persistence.Id;
+ import javax.persistence.JoinColumn;
+ import javax.persistence.ManyToOne;
++import javax.persistence.NamedNativeQueries;
++import javax.persistence.NamedNativeQuery;
++import javax.persistence.NamedQueries;
++import javax.persistence.NamedQuery;
+
+ /**
+  *","Just noticed this - why ""like"" and not straight ""="""
+6083,"@@ -1,15 +1,16 @@
+ require 'spec_helper'
+
+ describe Travis::Build::Data::Env do
+-  let(:data) { stub('data', pull_request: '100', config: { env: 'FOO=foo' }, build: {}, job: {}, repository: {}) }
++  let(:data) { stub('data', pull_request: '100', config: { env: 'FOO=foo' }, build: { id: '1', number: '1' }, job: { id: '1', number: '1.1', branch: 'master', commit: '313f61b', commit_range: '313f61b..313f61a' }, repository: { slug: 'travis-ci/travis-ci' }) }
+   let(:env)  { described_class.new(data) }
+
+   it 'vars respond to :key' do
+     env.vars.first.should respond_to(:key)
+   end
+
+-  it 'includes travis env vars' do
+-    env.vars.first.key.should =~ /^TRAVIS_/
++  it 'includes all travis env vars' do
++    travis_vars = env.vars.select { |v| v.key =~ /^TRAVIS_/ && v.value && v.value.length > 0 }
++    travis_vars.length.should == 11
+   end
+
+   it 'includes config env vars' do","is this a new test? if yes, isn't it better to check for each env var is present, and the value, instead of a count?"
+6084,"@@ -160,10 +160,10 @@ public class MicroserviceVersions {
+       setInstances(pulledInstances, rev);
+       validated = true;
+     } catch (Throwable e) {
+-      LOGGER.error(""Failed to setInstances, appId={}, microserviceName={}."",
+-          getAppId(),
+-          getMicroserviceName(),
+-          e);
++      LOGGER.error(String.format(""Failed to setInstances, AppId=%s, MicroserviceName=%s."",
++              getAppId(),
++              getMicroserviceName()),
++              e);
+     }
+   }
+ ","when will lost exception? by my test, never happened."
+6085,"@@ -147,7 +147,8 @@ class BrowserPage(QWebPage):
+                 title=""Open external application for {}-link?"".format(scheme),
+                 text=""URL: <b>{}</b>"".format(
+                     html.escape(url.toDisplayString())),
+-                yes_action=functools.partial(QDesktopServices.openUrl, url))
++                yes_action=functools.partial(QDesktopServices.openUrl, url),
++                url=urlstr)
+             return True
+         elif (info.domain, info.error) in ignored_errors:
+             log.webview.debug(""Ignored error on {}: {} (error domain: {}, """,You should re-stringify it here with `QUrl.FullyEncoded`.
+6086,"@@ -128,9 +128,9 @@ func Wrap(ctx context.Context, topic Topic, msg []byte, recipient *ecdsa.PublicK
+ 	return mine(ctx, odd, f)
+ }
+
+-// Unwrap takes a chunk, a topic and a private key, and tries to decrypt the payload
++// Unwrap takes a private key, a chunk, an array of possible topics and tries to decrypt the payload
+ // using the private key, the prepended ephemeral public key for el-Gamal using the topic as salt
+-func Unwrap(ctx context.Context, key *ecdsa.PrivateKey, chunk swarm.Chunk, topics []Topic) (topic Topic, msg []byte, err error) {
++func Unwrap(key *ecdsa.PrivateKey, chunk swarm.Chunk, quit chan struct{}, topics []Topic) (topic Topic, msg []byte, err error) {
+ 	chunkData := chunk.Data()
+ 	pubkey, err := extractPublicKey(chunkData)
+ 	if err != nil {",i'm not sure why the quit channel is needed in this context
+6087,"@@ -64,13 +64,16 @@ func MakeIngressDeployment(args IngressArgs) *appsv1.Deployment {
+ 	}
+ 	container.Resources = corev1.ResourceRequirements{
+ 		Limits: corev1.ResourceList{
+-			corev1.ResourceMemory: resource.MustParse(""1000Mi""),
++			corev1.ResourceMemory: resource.MustParse(args.MemoryLimit),
+ 		},
+ 		Requests: corev1.ResourceList{
+-			corev1.ResourceMemory: resource.MustParse(""500Mi""),
+-			corev1.ResourceCPU:    resource.MustParse(""1000m""),
++			corev1.ResourceMemory: resource.MustParse(args.MemoryRequest),
++			corev1.ResourceCPU:    resource.MustParse(args.CPURequest),
+ 		},
+ 	}
++	if len(args.CPULimit) > 0 {
++		container.Resources.Limits[corev1.ResourceCPU] = resource.MustParse(args.CPULimit)
++	}
+ 	return deploymentTemplate(args.Args, []corev1.Container{container})
+ }
+ ","When `args.MemoryLimit` is empty, will `MustParse` panic?"
+6088,"@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) {
+ 	r.dirtyIfaces.Add(ifaceName)
+ }
+
++func (r *RouteTable) QueueResync() {
++	r.logCxt.Info(""Queueing a resync."")
++	r.inSync = false
++}
++
+ func (r *RouteTable) Apply() error {
+ 	if !r.inSync {
+ 		links, err := r.dataplane.LinkList()",How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.
+6089,"@@ -23,6 +23,7 @@ import (
+ )
+
+ type nonceWithTTL struct {
++	idx      int
+ 	nonce    uint64
+ 	deadline time.Time
+ }","I add a `idx` property, and it is only use for benchmark `heap.Remove`, is it acceptable?"
+6090,"@@ -1,6 +1,6 @@
+ # -*- coding: UTF-8 -*-
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2018 NV Access Limited, Babbage B.V., Davy Kager
++#Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",daemonic t got inserted.
+6091,"@@ -532,7 +532,8 @@ public class DefaultBlockchain implements MutableBlockchain {
+       if (!genesisHash.get().equals(genesisBlock.getHash())) {
+         throw new InvalidConfigurationException(
+             ""Supplied genesis block does not match stored chain data.\n""
+-                + ""Please specify a different data directory with --data-path or specify the original genesis file with --genesis-file."");
++                + ""Please specify a different data directory with --data-path or specify the""
++                + "" original genesis file with --genesis-file."");
+       }
+     }
+   }",This edit is non-essential.
+6092,"@@ -14,6 +14,14 @@ import {
+
+ const isWeakMapSupported = typeof WeakMap == 'function';
+
++Object.setPrototypeOf =
++	Object.setPrototypeOf ||
++	function(obj, proto) {
++		// eslint-disable-next-line
++		obj.__proto__ = proto;
++		return obj;
++	};
++
+ function getClosestDomNodeParent(parent) {
+ 	if (!parent) return {};
+ 	if (typeof parent.type == 'function') {",Might be safer to ponyfill this?
+6093,"@@ -57,18 +57,11 @@ func Create(dir string) (*Local, error) {
+ 	}
+
+ 	// test if config file already exists
+-	_, err := os.Lstat(backend.Paths.Config)
++	_, err := os.Lstat(filepath.Join(dir, backend.Paths.Config))
+ 	if err == nil {
+ 		return nil, errors.New(""config file already exists"")
+ 	}
+
+-	// test if directories already exist
+-	for _, d := range dirs[1:] {
+-		if _, err := os.Stat(d); err == nil {
+-			return nil, fmt.Errorf(""dir %s already exists"", d)
+-		}
+-	}
+-
+ 	// create paths for data, refs and temp
+ 	for _, d := range dirs {
+ 		err := os.MkdirAll(d, backend.Modes.Dir)",why was this join not necessary before?
+6094,"@@ -163,6 +163,17 @@ public class TestExitableDirectoryReader extends LuceneTestCase {
+     searcher.search(query, 10);
+     reader.close();
+
++    // Set a fairly high timeout value (infinite) and expect the query to complete in that time frame.
++    // Not checking the validity of the result, but checking the sampling kicks in to reduce the number of timeout check
++    CountingQueryTimeout queryTimeout = new CountingQueryTimeout();
++    directoryReader = DirectoryReader.open(directory);
++    exitableDirectoryReader = new ExitableDirectoryReader(directoryReader, queryTimeout);
++    reader = new TestReader(getOnlyLeafReader(exitableDirectoryReader));
++    searcher = new IndexSearcher(reader);
++    searcher.search(query, 10);
++    reader.close();
++    assertEquals(3, queryTimeout.getShouldExitCallCount());
++
+     directory.close();
+   }
+ ","Here we compare to the expected call count 3. Because 3 TermsEnum are created: it is a PrefixQuery and there is one TermsEnum created for AutomatonQuery.intersect() (the next call timeout check is skipped once), then 2 TermsEnum created for the 2 matching terms ""one"" and ""ones""). Would it be clearer to have a separate test method? We could index more docs, for example 50 with a prefix-generated term (e.g. ""term""+increment). There would be a PrefixQuery for ""term"", the same test code, and we would test the TIMEOUT_CHECK_SAMPLING: - 1 TermsEnum for Automaton.intersect(), and the next calls would be sampled (50/TIMEOUT_CHECK_SAMPLING=3) => call count +4 - 1 TermsEnum for each enumerated term => call count +50 We could verify call count = 54 (instead of 101 without sampling)"
+6095,"@@ -28,6 +28,9 @@ module Bolt
+       when 'file'
+         { flags: ACTION_OPTS + %w[tmpdir],
+           banner: FILE_HELP }
++      when 'inventory'
++        { flags: OPTIONS[:inventory] + OPTIONS[:global] + %w[format inventoryfile boltdir configfile],
++          banner: INVENTORY_HELP }
+       when 'plan'
+         case action
+         when 'convert'",Add `--format` as an option. Does it make sense to have all display options available? Also need to add `--inventoryfile` and possibly the global_config_options.
+6096,"@@ -53,5 +53,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
+         /// The type of this object depends on the event, which is given by the above parameter.</para>
+         /// </remarks>
+         public Action<Activity, string, object> Enrich { get; set; }
++
++        /// <summary>
++        /// Gets or sets a value indicating whether the exception will be recorded or not.
++        /// </summary>
++        public bool RecordException { get; set; }
+     }
+ }","Any thoughts on making this false by default? My suggestion is make this opt-in. Storing exception is somewhat expensive, so lets do this only if users opt-in"
+6097,"@@ -88,7 +88,7 @@ public final class HttpCall<V> extends Call.Base<V> {
+       } else {
+         try {
+           callback.onSuccess(parseResponse(response, bodyConverter));
+-        } catch (IOException e) {
++        } catch (Throwable e) {
+           callback.onError(e);
+         }
+       }","usually I do either ` IOException|RuntimeException` or if doing Throwable, use propagateIfFatal"
+6098,"@@ -24,10 +24,14 @@ class Overlayable(object):
+
+     def __mul__(self, other):
+         if type(other).__name__ == 'DynamicMap':
+-            from ..util import Dynamic
+-            def dynamic_mul(element):
++            from .spaces import Callable
++            def dynamic_mul(*args, **kwargs):
++                element = other[args]
+                 return self * element
+-            return Dynamic(other, operation=dynamic_mul)
++            callback = Callable(callable_function=dynamic_mul,
++                                inputs=[self, other])
++            return other.clone(shared_data=False, callback=callback,
++                               streams=[])
+         if isinstance(other, UniformNdMapping) and not isinstance(other, CompositeOverlay):
+             items = [(k, self * v) for (k, v) in other.items()]
+             return other.clone(items)","Wondering whether it should be `self.clone`, or `other.clone` or maybe a new `DynamicMap` declaration entirely. I see this is in the condition where `other` is a `DynamicMap`but is this definitely right in terms of `kdims`? I need to think about it more..."
+6099,"@@ -34,7 +34,7 @@ public interface SolrInfoBean {
+    * Category of Solr component.
+    */
+   enum Category { CONTAINER, ADMIN, CORE, QUERY, UPDATE, CACHE, HIGHLIGHTER, QUERYPARSER, SPELLCHECKER,
+-    SEARCHER, REPLICATION, TLOG, INDEX, DIRECTORY, HTTP, OTHER }
++    SEARCHER, REPLICATION, TLOG, INDEX, DIRECTORY, HTTP, SECURITY, OTHER }
+
+   /**
+    * Top-level group of beans or metrics for a subsystem.",I chose a new category because over time I'd like to add metrics also for Authorization plugins and Auditlog plugins (all components registered in security.json). An alternative could have been `CONTAINER` I guess?
+6100,"@@ -22,6 +22,11 @@ var (
+ 	ErrMinusAmount = errors.New(""invalid amount that is minus"")
+ )
+
++const (
++	// IotxAddressLength defines length of IoTeX address
++	IotxAddressLength = 41
++)
++
+ // ValidateAddress validates IoTeX address
+ func ValidateAddress(addr string) error {
+ 	if _, err := address.FromString(addr); err != nil {",IoAddrLen Golang prefers short variable names
+6101,"@@ -34,7 +34,7 @@ class MediaAdmin extends Admin
+      */
+     public function createQuery($context = 'list')
+     {
+-        $query = $this->getModelManager()->createQuery($this->getClass(), '', $this->root);
++        $query = $this->getModelManager()->createQuery($this->getClass(), 'a', $this->root);
+
+         foreach ($this->extensions as $extension) {
+             $extension->configureQuery($this, $query, $context);",PHPCR-ODM does not allow blank aliases..
+6102,"@@ -358,7 +358,11 @@ public class HttpSolrClient extends BaseHttpSolrClient {
+     if (parser == null) {
+       parser = this.parser;
+     }
+-
++
++    Header[] contextHeaders = new Header[2];
++    contextHeaders[0] = new BasicHeader(CommonParams.SOLR_REQUEST_CONTEXT_PARAM, getContext().toString());
++    contextHeaders[1] = new BasicHeader(CommonParams.SOLR_REQUEST_TYPE_PARAM, request.getRequestType());
++
+     // The parser 'wt=' and 'version=' params are used instead of the original
+     // params
+     ModifiableSolrParams wparams = new ModifiableSolrParams(params);",This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server?
+6103,"@@ -42,6 +42,7 @@
+ //@HEADER
+ */
+
++#include <Kokkos_Core.hpp>
+ #include <Kokkos_Concepts.hpp>
+ #include <SYCL/Kokkos_SYCL_Instance.hpp>
+ #include <KokkosCore_Config_DeclareBackend.hpp>",Why are you including `<Kokkos_Core.hpp>`?
+6104,"@@ -323,7 +323,7 @@ int api_v1_health(struct flb_hs *hs)
+
+     counter_init(hs);
+     /* Create a message queue */
+-    hs->qid_metrics = mk_mq_create(hs->ctx, ""/health"",
++    hs->qid_health = mk_mq_create(hs->ctx, ""/health"",
+                                    cb_mq_health, NULL);
+
+     mk_vhost_handler(hs->ctx, hs->vid, ""/api/v1/health"", cb_health, hs);","So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13"
+6105,"@@ -1470,6 +1470,7 @@ func isValidRuleForXDP(rule *proto.Rule) bool {
+ 		len(rule.DstPorts) == 0 &&
+ 		len(rule.DstNamedPortIpSetIds) == 0 &&
+ 		len(rule.DstIpSetIds) == 0 &&
++		len(rule.DstIpPortSetIds) == 0 &&
+ 		len(rule.NotDstNet) == 0 &&
+ 		len(rule.NotDstPorts) == 0 &&
+ 		len(rule.NotDstIpSetIds) == 0 &&","Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated."
+6106,"@@ -0,0 +1,12 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System;
++
++namespace Microsoft.AspNetCore.Connections.Features
++{
++    public interface IConnectionHeartbeatTickFeature
++    {
++        void OnHeartbeat(Action<DateTimeOffset, object> action, object state);
++    }
++}",cc @anurse This exists now. Kestrel currently passes the current time to all callbacks as an optimization. Just an FYI.
+6107,"@@ -126,7 +126,7 @@ class Entry(MSONable, metaclass=ABCMeta):
+         elif mode == ""formula_unit"":
+             factor = self.composition.get_reduced_composition_and_factor()[1]
+         else:
+-            raise ValueError(f""{mode=} is not an allowed option for normalization"")
++            raise ValueError(f""{mode} is not an allowed option for normalization"")
+
+         return factor
+ ",remove 3.8+ f-string format to allow use in google colab
+6108,"@@ -196,6 +196,10 @@ save_xmm(dcontext_t *dcontext, sigframe_rt_t *frame)
+     int i;
+     sigcontext_t *sc = get_sigcontext_from_rt_frame(frame);
+     kernel_xstate_t *xstate = (kernel_xstate_t *)sc->fpstate;
++    /* For pending signals, the alignment of xstate ultimately depends on the alignment of
++     * the special allocator's blocks. Ths is fragile, and assertions here and at
++     * initialization are providing some coverage for this.
++     */
+     if (!preserve_xmm_caller_saved())
+         return;
+     if (xstate_has_extra_fields) {",Should we assert that xstate is aligned here?
+6109,"@@ -49,8 +49,8 @@ import com.tdunning.math.stats.AVLTreeDigest;
+ //   TestCloudJSONFacetJoinDomain for random field faceting tests with domain modifications
+ //   TestJsonFacetRefinement for refinement tests
+
+-@LuceneTestCase.SuppressCodecs({""Lucene3x"",""Lucene40"",""Lucene41"",""Lucene42"",""Lucene45"",""Appending""})
+-public class TestJsonFacets extends SolrTestCaseHS {
++@LuceneTestCase.SuppressCodecs({""Lucene3x"",""Lucene40"",""Lucene41"",""FST50"",""Direct"",""Lucene42"",""Lucene45"",""Appending"",""BlockTreeOrds"",""FSTOrd50""})
++public class  TestJsonFacets extends SolrTestCaseHS {
+
+   private static SolrInstances servers;  // for distributed testing
+   private static int origTableSize;",any particular reason for suppressing this change?
+6110,"@@ -67,6 +67,17 @@ public abstract class MainnetDifficultyCalculators {
+         return periodCount > 1 ? adjustForPeriod(periodCount, difficulty) : difficulty;
+       };
+
++  public static DifficultyCalculator<Void> DIFFICULTY_BOMB_REMOVED =
++      (time, parent, protocolContext) -> {
++        final BigInteger parentDifficulty = difficulty(parent.getDifficulty());
++        final BigInteger difficulty =
++            ensureMinimumDifficulty(
++                BigInteger.valueOf(Math.max(1 - (time - parent.getTimestamp()) / 10, -99L))
++                    .multiply(parentDifficulty.divide(DIFFICULTY_BOUND_DIVISOR))
++                    .add(parentDifficulty));
++        return difficulty;
++      };
++
+   public static DifficultyCalculator<Void> BYZANTIUM =
+       (time, parent, protocolContext) ->
+           calculateByzantiumDifficulty(time, parent, BYZANTIUM_FAKE_BLOCK_OFFSET);","Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case?"
+6111,"@@ -16,6 +16,19 @@
+ // variables read from a blob.Bucket.
+ // Use NewVariable to construct a *runtimevar.Variable.
+ //
++// URLs
++//
++// For runtimevar.OpenVariable URLs, blobvar registers for the scheme ""blob"".
++// The host+path is used as the blob key. blobvar supports the following URL
++// parameters:
++//   - bucket: The URL to be passed to blob.OpenBucket (required).
++//       blob.OpenBucket will be called once per unique bucket URL.
++//   - decoder: The decoder to use. Defaults to runtimevar.BytesDecoder.
++//       See runtimevar.DecoderByName for supported values.
++//   - wait: The poll interval; supported values are from time.ParseDuration.
++//       Defaults to 30s.
++// Example URL: ""blob://myvar.txt?bucket=fileblob:///foo/bar&decoder=string"".
++//
+ // As
+ //
+ // blobvar exposes the following types for As:","I suggest to use a scheme like ""blobvar"". ""blob"" would potentially collide if we have another API that use the blob package as a driver."
+6112,"@@ -116,6 +116,14 @@ def get_listens(user_name):
+     for listen in listens:
+         listen_data.append(listen.to_api())
+
++    latest_listen = db_conn.fetch_listens(
++        user_name,
++        limit=1,
++        to_ts=max_ts,
++    )
++    latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 else 0
++
++
+     if min_ts:
+         listen_data = listen_data[::-1]
+ ","This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case"
+6113,"@@ -365,7 +365,7 @@ namespace pwiz.Skyline.Properties {
+         }
+
+         /// <summary>
+-        ///   Looks up a localized string similar to An error occurred while trying to display the document &apos;{0}&apos;.
++        ///   Looks up a localized string similar to An error occurred while trying to display the document &apos;{0}&apos;.
+         ///There might be something wrong with default web browser on this computer..
+         /// </summary>
+         public static string ActionTutorial_ExtractTutorial_An_error_occurred_while_trying_to_display_the_document___0____ {",Seems like a lot of unintended changes. Are your line break settings causing these?
+6114,"@@ -231,9 +231,10 @@ def generate_r_docs(app):
+         r-jsonlite=1.5=r351h96ca727_0 \
+         r-matrix=1.2_14=r351h96ca727_0 \
+         r-testthat=2.0.0=r351h29659fb_0 \
+-        cmake=3.14.0=h52cb24c_0
++        cmake=3.14.0=h52cb24c_0 \
++        ca-certificates=2019.11.27=0
+     /home/docs/.conda/bin/conda install -q -y -n r_env -c conda-forge \
+-        r-pkgdown=1.3.0=r351h6115d3f_1000 \
++        r-pkgdown=1.3.0=r35h6115d3f_1001 \
+         r-roxygen2=6.1.1=r35h0357c0b_1001
+     source /home/docs/.conda/bin/activate r_env
+     export TAR=/bin/tar",@StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change?
+6115,"@@ -1,6 +1,5 @@
+-# $Id$
+ #
+-#  Copyright (C) 2003-2006  Rational Discovery LLC
++#  Copyright (C) 2002-2006  greg Landrum and Rational Discovery LLC
+ #
+ #   @@ All Rights Reserved @@
+ #  This file is part of the RDKit.","I'm not arguing with it, but how did you decide to make this change?"
+6116,"@@ -1,7 +1,7 @@
+ # -*- coding: utf-8 -*-
+ ##
+ ## This file is part of Invenio.
+-## Copyright (C) 2011, 2012 CERN.
++## Copyright (C) 2011, 2012, 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 First line should be imperative: 'Call', not 'Calls' 115: D400 First line should end with '.', not 't' 134: D400 First line should end with '.', not 'e' 134: D205 Blank line missing between one-line summary and description"
+6117,"@@ -42,6 +42,14 @@ type ACMEIssuer struct {
+ 	// Only ACME v2 endpoints (i.e. RFC 8555) are supported.
+ 	Server string `json:""server""`
+
++	// PreferredChain is the chain to use if the ACME server outputs multiple.
++	// PreferredChain is no guarantee that this one gets delivered by the ACME
++	// endpoint.
++	// For example, for Let's Encrypt's DST crosssign you would use:
++	// ""DST Root CA X3"" or ""ISRG Root X1"" for the newer Let's Encrypt root CA.
++	// +optional
++	PreferredChain string `json:""preferredChain""`
++
+ 	// Enables or disables validation of the ACME server TLS certificate.
+ 	// If true, requests to the ACME server will not have their TLS certificate
+ 	// validated (i.e. insecure connections will be allowed).","Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate."
+6118,"@@ -16,7 +16,7 @@ type Config struct {
+ 	Storage           *storageConfig     `yaml:""storage"" required:""true""`
+ 	Blockchain        *blockchain.Config `yaml:""blockchain""`
+ 	MetricsListenAddr string             `yaml:""metrics_listen_addr"" default:""127.0.0.1:14004""`
+-	ColdStart         *ColdStartConfig   `yaml:""cold_start""`
++	ColdStart         bool               `yaml:""cold_start""`
+ 	NumWorkers        int                `yaml:""num_workers"" default:""64""`
+ }
+ ",do we really need this behavour to be configurable?
+6119,"@@ -3,7 +3,7 @@
+  */
+
+ var MongooseArray = require('./array')
+-  , ObjectId = require('../drivers/node-mongodb-native/objectid')
++  , ObjectId = require('./objectid')
+   , ObjectIdSchema = require('../schema/objectid')
+   , utils = require('../utils')
+   , util = require('util')",Hmm interesting. Do the tests check out on this?
+6120,"@@ -26,11 +26,15 @@ import java.util.concurrent.TimeUnit;
+
+ import com.google.common.base.Stopwatch;
+ import org.apache.logging.log4j.Logger;
++import org.apache.tuweni.bytes.Bytes;
++import org.apache.tuweni.concurrent.ExpiringMap;
+ import org.apache.tuweni.units.bigints.UInt256;
+
+ public class PoWSolver {
+
++  private static final int MAX_OMMER_DEPTH = 8;
+   private static final Logger LOG = getLogger();
++  private final long powJobTimeToLive;
+
+   public static class PoWSolverJob {
+ ","For another PR, another `--X` candidate."
+6121,"@@ -10,4 +10,5 @@ const (
+ 	GettingStarted = ""Getting Started ✨""
+ 	Develop = ""Develop 🔧""
+ 	Settings = ""Settings""
+-)
++	Release = ""Release""
++)","Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji   at the end? The windows one could be plain."
+6122,"@@ -4,6 +4,8 @@
+
+ package net.sourceforge.pmd.lang.ast.xpath;
+
++import static junit.framework.TestCase.assertTrue;
++
+ import java.util.HashMap;
+ import java.util.Map;
+ ","this is a junit 3 import, not a junit 4"
+6123,"@@ -113,9 +113,16 @@ func TestReconcile(t *testing.T) {
+ 				assert.Equal(t, hivev1.UnsupportedHibernationReason, cond.Reason)
+ 			},
+ 		},
++		{
++			name:        ""clustersync not yet created"",
++			cd:          cdBuilder.Options(o.shouldHibernate).Build(),
++			expectError: true,
++		},
+ 		{
+ 			name: ""start hibernating, no syncsets"",
+ 			cd:   cdBuilder.Options(o.shouldHibernate).Build(),
++			// The clustersync controller creates a ClusterSync even when there are no syncsets
++			cs: csBuilder.Build(),
+ 			setupActuator: func(actuator *mock.MockHibernationActuator) {
+ 				actuator.EXPECT().StopMachines(gomock.Any(), gomock.Any(), gomock.Any()).Times(1).Return(nil)
+ 			},",shouldn't there be a reque expected here?
+6124,"@@ -63,7 +63,7 @@ namespace NLog.Layouts
+         ///
+         /// Thread-agnostic layouts only use contents of <see cref=""LogEventInfo""/> for its output.
+         /// </remarks>
+-        internal bool ThreadAgnostic { get; private set; }
++        internal bool ThreadAgnostic { get; set; }
+
+         /// <summary>
+         /// Gets the level of stack trace information required for rendering.",I prefer to make it `protected set`. What do you think?
+6125,"@@ -178,7 +178,9 @@ type Options struct {
+ 	Gateway               GatewayOpts   `json:""gateway,omitempty""`
+ 	LeafNode              LeafNodeOpts  `json:""leaf,omitempty""`
+ 	JetStream             bool          `json:""jetstream""`
+-	StoreDir              string        `json:""store_dir""`
++	JetStreamMaxMemory    int64         `json:""-""`
++	JetStreamMaxStore     int64         `json:""-""`
++	StoreDir              string        `json:""-""`
+ 	ProfPort              int           `json:""-""`
+ 	PidFile               string        `json:""-""`
+ 	PortsFileDir          string        `json:""-""`",Maybe rename this to JetStreamStoreDir?
+6126,"@@ -52,7 +52,8 @@ var _ = Describe(""UsageReporter with mocked URL and short interval"", func() {
+ 		httpHandler = &requestRecorder{}
+ 		go func() {
+ 			defer GinkgoRecover()
+-			http.Serve(tcpListener, httpHandler)
++			// TODO: Investigate why this call sometimes returns an error.
++			_ = http.Serve(tcpListener, httpHandler)
+ 		}()
+
+ 		// Channels to send data to the UsageReporter.",You can start by logging out the error
+6127,"@@ -31,7 +31,7 @@ namespace Nethermind.JsonRpc.Modules.Eth.GasPrice
+     {
+         private readonly IBlockFinder _blockFinder;
+         private readonly UInt256 _minGasPrice;
+-        public UInt256 FallbackGasPrice => LastGasPrice ?? _minGasPrice;
++        public UInt256 FallbackGasPrice(in UInt256? baseFeePerGas = null) => LastGasPrice ?? GetMinimumGasPrice(baseFeePerGas ?? UInt256.Zero);
+         private ISpecProvider SpecProvider { get; }
+         public UInt256? LastGasPrice { get; set; }
+         public Block? LastHeadBlock { get; set; }","In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header?"
+6128,"@@ -80,7 +80,7 @@ import java.util.function.*;
+  * @param <V> Value type
+  * @author Daniel Dietrich, Ruslan Sennov
+  */
+-public interface Map<K, V> extends Traversable<Tuple2<K, V>>, Function1<K, V>, PartialFunction<K, V>, Serializable {
++public interface Map<K, V> extends Traversable<Tuple2<K, V>>, PartialFunction<K, V>, Serializable {
+
+     long serialVersionUID = 1L;
+ ",follow-up of #2002
+6129,"@@ -162,7 +162,7 @@ public class TiSession implements AutoCloseable {
+         if (tableScanThreadPool == null) {
+           tableScanThreadPool =
+               Executors.newFixedThreadPool(
+-                  conf.getTableScanConcurrency(),
++                  conf.getTableScanConcurrency() / conf.getPartitionPerSplit(),
+                   new ThreadFactoryBuilder().setDaemon(true).build());
+         }
+         res = tableScanThreadPool;","could you give some explanations of what problem do you want to solve by this change, and how/why it works?"
+6130,"@@ -2,16 +2,18 @@
+ // The .NET Foundation licenses this file to you under the MIT license.
+ // See the LICENSE file in the project root for more information.
+
++using System;
+ using System.Collections.Generic;
+ using System.Threading;
+ using System.Threading.Tasks;
++using Xunit;
+ using Xunit.Abstractions;
+ using Xunit.Sdk;
+
+ namespace Xunit.NetCore.Extensions
+ {
+     /// <summary>Wraps another test case that should be skipped.</summary>
+-    internal sealed class SkippedTestCase : IXunitTestCase
++    internal sealed class SkippedTestCase : LongLivedMarshalByRefObject, IXunitTestCase
+     {
+         private readonly IXunitTestCase _testCase;
+         private readonly string _skippedReason;",LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit?
+6131,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.
+6132,"@@ -85,12 +85,11 @@ func Run(ctx context.Context, cfg *config.Node) error {
+ 		}
+
+ 		logrus.Infof(""Running containerd %s"", config.ArgString(args[1:]))
+-		cmd := exec.Command(args[0], args[1:]...)
++		cmd := exec.CommandContext(ctx, args[0], args[1:]...)
+ 		cmd.Stdout = stdOut
+ 		cmd.Stderr = stdErr
+ 		cmd.Env = env
+
+-		addDeathSig(cmd)
+ 		if err := cmd.Run(); err != nil {
+ 			fmt.Fprintf(os.Stderr, ""containerd: %s\n"", err)
+ 		}","Testing on linux with this change, containerd no longer stops when k3s stops."
+6133,"@@ -266,6 +266,11 @@ type Config struct {
+ 	// MaxConnectionReceiveWindow is the connection-level flow control window for receiving data.
+ 	// If this value is zero, it will default to 15 MB.
+ 	MaxConnectionReceiveWindow uint64
++	// AllowConnectionWindowIncrease is called every time the connection flow controller attempts
++	// to increase the connection flow control window.
++	// If set, the caller can prevent an increase of the window. Typically, it would do so to
++	// limit the memory usage.
++	AllowConnectionWindowIncrease func(sess Session, delta int) bool
+ 	// MaxIncomingStreams is the maximum number of concurrent bidirectional streams that a peer is allowed to open.
+ 	// Values above 2^60 are invalid.
+ 	// If not set, it will default to 100.",Maybe [u]int64 to be consistent with other byte-valued vars in this struct?
+6134,"@@ -25,7 +25,9 @@
+     <%- if signed_in? %>
+       <div class=""mycart-link"">
+         <ul class=""header-nav"">
+-            <li><%= link_to(""My Requests"", carts_path) %> <%= image_tag ""img-cart.png"", width: '18px', height:'16px' %></li>
++          <li><%= link_to ""My Requests"", carts_path %> <%= image_tag ""img-cart.png"", width: '18px', height:'16px' %></li>
++          <%# TODO only show to NCR people %>
++          <li><%= link_to ""New Request"", new_ncr_proposal_path %></li>
+         </ul>
+       </div>
+     <%- end %>","This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example."
+6135,"@@ -36,9 +36,12 @@ template <typename Dtype>
+ BasePrefetchingDataLayer<Dtype>::BasePrefetchingDataLayer(
+     const LayerParameter& param)
+     : BaseDataLayer<Dtype>(param),
+-      prefetch_free_(), prefetch_full_() {
+-  for (int i = 0; i < PREFETCH_COUNT; ++i) {
+-    prefetch_free_.push(&prefetch_[i]);
++      prefetch_(param.has_data_param() ?
++                param.data_param().prefetch() : PREFETCH_COUNT),
++      prefetch_free_(), prefetch_full_(), prefetch_current_() {
++  for (int i = 0; i < prefetch_.size(); ++i) {
++    prefetch_[i].reset(new Batch<Dtype>());
++    prefetch_free_.push(prefetch_[i].get());
+   }
+ }
+ ","Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`."
+6136,"@@ -55,6 +55,16 @@ func nodeStatus(node *node.AlgorandFullNode) (res v1.NodeStatus, err error) {
+ 	}, nil
+ }
+
++func txEncode(tx transactions.Transaction, ad transactions.ApplyData) (res v1.Transaction, err error) {
++	switch tx.Type {
++	case protocol.PaymentTx:
++		return paymentTxEncode(tx, ad), nil
++	case protocol.KeyRegistrationTx:
++		return keyregTxEncode(tx, ad), nil
++	}
++	return v1.Transaction{}, errors.New(errUnknownTransactionType)
++}
++
+ func paymentTxEncode(tx transactions.Transaction, ad transactions.ApplyData) v1.Transaction {
+ 	payment := v1.PaymentTransactionType{
+ 		To:           tx.Receiver.String(),",nit : move this into a default clause in the previous switch statement.
+6137,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return ""'"" + value + ""'"";
+ 	} else {
+-		return '""""';
++		return ""'"";
+ 	}
+ }
+ ","It should be return ""''""; I will fix it"
+6138,"@@ -43,14 +43,14 @@ type ClusterEvent interface{}
+ // Specific type of cluster event emitted when new member joins cluster
+ type NewMemberEvent struct {
+ 	endpointsInfo
+-	Id string
++	ID string
+ }
+
+ // Specific type of cluster event emitted when leadership is transferred.
+ // It is not always loss or acquire of leadership of this specific node
+ type LeadershipEvent struct {
+ 	Held            bool
+-	LeaderId        string
++	LeaderID        string
+ 	LeaderEndpoints []string
+ }
+ ","Go standard linter hates `Id`s and likes `ID`s, please do not resist."
+6139,"@@ -71,11 +71,11 @@ module Travis
+           end
+
+           def fetch_ref
+-            cmd ""git fetch origin +#{data.ref}: "", assert: true, timeout: :git_fetch_ref, fold: ""git.#{next_git_fold_number}""
++            cmd ""git fetch origin +#{data.ref}: "", assert: true, timeout: :git_fetch_ref, fold: ""git.#{next_git_fold_number}"", retry: true
+           end
+
+           def git_checkout
+-            cmd ""git checkout -qf #{data.pull_request ? 'FETCH_HEAD' : data.commit}"", assert: true, fold: ""git.#{next_git_fold_number}""
++            cmd ""git checkout -qf #{data.pull_request ? 'FETCH_HEAD' : data.commit}"", assert: true, fold: ""git.#{next_git_fold_number}"", retry: true
+           end
+
+           def submodules?","I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times."
+6140,"@@ -172,7 +172,7 @@ func SetCertificateNotBefore(p metav1.Time) CertificateModifier {
+ 	}
+ }
+
+-func SetCertificateRenewalTIme(p metav1.Time) CertificateModifier {
++func SetCertificateRenewalTime(p metav1.Time) CertificateModifier {
+ 	return func(crt *v1.Certificate) {
+ 		crt.Status.RenewalTime = &p
+ 	}",Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there?
+6141,"@@ -25,6 +25,8 @@ _rtp_payload_types = {
+     31: 'H261',          32: 'MPV',
+     33: 'MP2T',          34: 'H263' }
+
++extension_condition = lambda pkt: pkt.extension
++
+ class RTP(Packet):
+     name=""RTP""
+     fields_desc = [ BitField('version', 2, 2),",Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class ? Would be better i think
+6142,"@@ -72,7 +72,7 @@ module RSpec::Core
+         end
+
+         parser.on('--seed SEED', Integer, 'Equivalent of --order rand:SEED.') do |seed|
+-          options[:order] = ""rand:#{seed}""
++          options[:seed] = seed
+         end
+
+         parser.on('--fail-fast', 'Abort the run on first failure.') do |o|","This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use."
+6143,"@@ -112,6 +112,9 @@ loader_init(void)
+         char name_copy[MAXIMUM_PATH];
+         mod = privload_insert(NULL, privmod_static[i].base, privmod_static[i].size,
+                               privmod_static[i].name, privmod_static[i].path);
++#ifdef CLIENT_INTERFACE
++        mod->is_client = true;
++#endif
+         LOG(GLOBAL, LOG_LOADER, 1, ""%s: processing imports for %s\n"", __FUNCTION__,
+             mod->name);
+         /* save a copy for error msg, b/c mod will be unloaded (i#643) */",Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set.
+6144,"@@ -2167,7 +2167,9 @@ namespace pwiz.Skyline.Model.Lib
+                 }
+                 if (!string.IsNullOrEmpty(OtherKeys))
+                 {
+-                    smallMolLines.Add(new KeyValuePair<string, string> (Resources.SmallMoleculeLibraryAttributes_KeyValuePairs_OtherIDs, OtherKeys.Replace('\t','\n')));
++                    // Add a separate line for each molecule accession number
++                    var accessionNumDict = MoleculeAccessionNumbers.FormatAccessionNumbers(OtherKeys);
++                    smallMolLines.AddRange(accessionNumDict.Select(pair => new KeyValuePair<string, string>(pair.Key, pair.Value)));
+                 }
+                 return smallMolLines;
+             }","Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones."
+6145,"@@ -19,12 +19,7 @@ package org.camunda.bpm.model.cmmn;
+ import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN10_NS;
+ import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN11_NS;
+
+-import java.io.File;
+-import java.io.FileInputStream;
+-import java.io.FileNotFoundException;
+-import java.io.FileOutputStream;
+-import java.io.InputStream;
+-import java.io.OutputStream;
++import java.io.*;
+
+ import org.camunda.bpm.model.cmmn.impl.CmmnParser;
+ import org.camunda.bpm.model.cmmn.impl.instance.ApplicabilityRuleImpl;","As Miklas stated, please avoid wildcard imports."
+6146,"@@ -204,5 +204,4 @@ function server (inputCompanionOptions = {}) {
+   return { app, companionOptions }
+ }
+
+-const { app, companionOptions } = server()
+-module.exports = { app, companionOptions, server }
++module.exports = { server }",Maybe change it to `module.exports = server` ? Becase there's nothing else to export here
+6147,"@@ -24,14 +24,13 @@ import (
+
+ 	""cloud.google.com/go/pubsub""
+ 	""cloud.google.com/go/pubsub/pstest""
++	""google.golang.org/grpc/codes""
+
+ 	reconcilertestingv1 ""github.com/google/knative-gcp/pkg/reconciler/testing/v1""
+ 	""github.com/google/knative-gcp/pkg/utils/authcheck""
+
+ 	""google.golang.org/api/option""
+ 	""google.golang.org/grpc""
+-	""google.golang.org/grpc/codes""
+-
+ 	v1 ""k8s.io/api/apps/v1""
+
+ 	corev1 ""k8s.io/api/core/v1""","This may be an automated change, but the import seems to fit better where it was previously."
+6148,"@@ -0,0 +1,9 @@
++<script type=""text/javascript"">
++  window.analytics||(window.analytics=[]),window.analytics.methods=[""identify"",""track"",""trackLink"",""trackForm"",""trackClick"",""trackSubmit"",""page"",""pageview"",""ab"",""alias"",""ready"",""group"",""on"",""once"",""off""],window.analytics.factory=function(t){return function(){var a=Array.prototype.slice.call(arguments);return a.unshift(t),window.analytics.push(a),window.analytics}};for(var i=0;i<window.analytics.methods.length;i++){var method=window.analytics.methods[i];window.analytics[method]=window.analytics.factory(method)}window.analytics.load=function(t){var a=document.createElement(""script"");a.type=""text/javascript"",a.async=!0,a.src=(""https:""===document.location.protocol?""https://"":""http://"")+""d2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/""+t+""/analytics.min.js"";var n=document.getElementsByTagName(""script"")[0];n.parentNode.insertBefore(a,n)},window.analytics.SNIPPET_VERSION=""2.0.8"",
++  window.analytics.load(""2nexpdgku3"");
++  window.analytics.page();
++</script>
++
++<% if signed_in? %>
++  <%= render 'signed_in_analytics' %>
++<% end %>",Might we want to separate including this snippet and sending the data for signed in users into different partials?
+6149,"@@ -32,7 +32,11 @@ type PeerAdder interface {
+ }
+
+ type ClosestPeerer interface {
+-	ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
++	// ClosestPeer returns the closest connected peer we have in relation to a
++	// given chunk address.
++	// This function will ignore peers with addresses provided in skipPeers.
++	// Returns topology.ErrWantSelf in case base is the closest to the chunk.
++	ClosestPeer(addr swarm.Address, skipPeers ...swarm.Address) (peerAddr swarm.Address, err error)
+ }
+
+ type EachPeerer interface {",closest to the address
+6150,"@@ -18,13 +18,17 @@ const ROW_WIDTHS_MAP_NAME = 'autoRowSize';
+  * @plugin AutoRowSize
+  * @class AutoRowSize
+  * @description
+- * This plugin allows to set row heights based on their highest cells.
++ * The `AutoRowSize` plugin allows you to set row heights based on their highest cells.
+  *
+  * By default, the plugin is declared as `undefined`, which makes it disabled (same as if it was declared as `false`).
+  * Enabling this plugin may decrease the overall table performance, as it needs to calculate the heights of all cells to
+  * resize the rows accordingly.
+  * If you experience problems with the performance, try turning this feature off and declaring the row heights manually.
+  *
++ * But, to display Handsontable's [scrollbar](https://handsontable.com/docs/8.0.0/demo-scrolling.html)
++ * in a proper size, you need to enable the `AutoRowSize` plugin,
++ * by setting the [`autoRowSize`](@/api/options.md#autoRowSize) option to `true`.
++ *
+  * Row height calculations are divided into sync and async part. Each of this parts has their own advantages and
+  * disadvantages. Synchronous calculations are faster but they block the browser UI, while the slower asynchronous
+  * operations don't block the browser UI.",It should be much more clear for end-user
+6151,"@@ -82,7 +82,7 @@ SINGLE_QUOTED_REGEX = re.compile(""(%s)?'''"" % ""|"".join(_PREFIXES))
+ DOUBLE_QUOTED_REGEX = re.compile('(%s)?""""""' % ""|"".join(_PREFIXES))
+ QUOTE_DELIMITER_REGEX = re.compile(""(%s)?(\""|')"" % ""|"".join(_PREFIXES), re.DOTALL)
+
+-MSGS = {
++MSGS = {  # pylint: disable=consider-using-namedtuple
+     ""E1300"": (
+         ""Unsupported format character %r (%#02x) at index %d"",
+         ""bad-format-character"",","Isn't this an example that this will be prone to false positives ? We had nothing to fix in the codebase (And I think there is dict that could be named tuple in the MessageStore/MessageIdStore), but we have a false positives on our checkers."
+6152,"@@ -55,11 +55,11 @@ func TestOpenCensus(t *testing.T) {
+ 	const provider = ""gocloud.dev/blob/memblob""
+
+ 	diff := octest.Diff(te.Spans(), te.Counts(), ""gocloud.dev/blob"", provider, []octest.Call{
+-		{""NewWriter"", gcerrors.OK},
+-		{""NewRangeReader"", gcerrors.OK},
+-		{""Attributes"", gcerrors.OK},
+-		{""Delete"", gcerrors.OK},
+-		{""NewRangeReader"", gcerrors.NotFound},
++		{Method: ""NewWriter"", Code: gcerrors.OK},
++		{Method: ""NewRangeReader"", Code: gcerrors.OK},
++		{Method: ""Attributes"", Code: gcerrors.OK},
++		{Method: ""Delete"", Code: gcerrors.OK},
++		{Method: ""NewRangeReader"", Code: gcerrors.NotFound},
+ 	})
+ 	if diff != """" {
+ 		t.Error(diff)","We control `octest`, so it shouldn't be necessary to provide struct literal keys. This is a case of vet being too picky."
+6153,"@@ -90,5 +90,8 @@ module DMPRoadmap
+     #   is_test                   - (NOT advisable because test plans are excluded from statistics)
+     #   privately_visible         - Only the owner and people they invite can access the plan
+     config.default_plan_visibility = 'privately_visible'
++
++    # The percentage of answered questions needed to enable the plan visibility section of the Share plan page
++    config.default_plan_percentage_answered = 50.00
+   end
+ end",I would put that constant under config/initializers/constant.rb and I would leave application.rb for rails specific.
+6154,"@@ -572,7 +572,18 @@ func (fup folderUpdatePrepper) updateResolutionUsage(ctx context.Context,
+ // addUnrefToFinalResOp makes a resolutionOp at the end of opsList if
+ // one doesn't exist yet, and then adds the given pointer as an unref
+ // block to it.
+-func addUnrefToFinalResOp(ops opsList, ptr BlockPointer) opsList {
++func addUnrefToFinalResOp(ops opsList, ptr BlockPointer,
++	doNotUnref map[BlockPointer]bool) opsList {
++	// Make sure the block ID we want to unref isn't in the ""do not
++	// unref"" list -- it could mean that block has already been GC'd
++	// by the merged branch.  We can't compare pointers directly
++	// because GC'd pointers contain no block context.
++	for noUnref := range doNotUnref {
++		if ptr.ID == noUnref.ID {
++			return ops
++		}
++	}
++
+ 	resOp, ok := ops[len(ops)-1].(*resolutionOp)
+ 	if !ok {
+ 		resOp = newResolutionOp()","Is there a reason not to do something like `if _, ok := doNotUnref[ptr.ID]; ok { return ops }` here?"
+6155,"@@ -539,7 +539,10 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            return self.size, self.location
+
+     @property
+     def screenshot_as_base64(self):",This would return a tuple of two dictionaries. You need to combine them and return a dictionary
+6156,"@@ -29,10 +29,10 @@ class Node(object):
+     def __repr__(self):
+         return self._class_repr()
+
+-    def __call__(self):
+-        return self._data()
++    def __call__(self, asa=None):
++        raise NotImplementedError
+
+-    def _data(self):
++    def _data(self, asa=None):
+         raise NotImplementedError
+
+ ",Why not always forward it to `_data`?
+6157,"@@ -263,7 +263,7 @@ def connect_spotify_callback():
+     return redirect(url_for('profile.connect_spotify'))
+
+
+-@profile_bp.route('/refresh-spotify-token', methods=['GET'])
++@profile_bp.route('/refresh-spotify-token', methods=['POST'])
+ @crossdomain()
+ @api_login_required
+ def refresh_spotify_token():",there are tests that use `client.get` which will fail now
+6158,"@@ -371,7 +371,7 @@ func (fs *FS) mkdirAll(filename string, perm os.FileMode) (err error) {
+ 		switch errors.Cause(err).(type) {
+ 		case libkbfs.NameExistsError:
+ 			// The child directory already exists.
+-		case libkbfs.WriteAccessError:
++		case libkbfs.WriteAccessError, libkbfs.WriteToReadonlyNodeError:
+ 			// If the child already exists, this doesn't matter.
+ 			var lookupErr error
+ 			child, _, lookupErr = fs.config.KBFSOps().Lookup(fs.ctx, n, p)","Whoa, TIL about this syntax."
+6159,"@@ -34,12 +34,14 @@ type fakeHandler struct {
+ }
+
+ func (h fakeHandler) Handle(context.Context, *yarpc.Request, *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
+-	errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
+-	res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
+ 	if h.applicationErr != nil {
++		errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
++		res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
+ 		return res, nil, nil
++	} else if h.err != nil {
++		return nil, nil, h.err
+ 	}
+-	return res, nil, h.err
++	return &yarpc.Response{}, &yarpc.Buffer{}, nil
+ }
+
+ func (h fakeHandler) HandleStream(*yarpc.ServerStream) error {","This is a smell. When is this valid? Perhaps this should be `nil, nil, ErrNoResponse` or some such. While it is usually invalid to have neither a return value or error, we rarely check for the case in other idiomatic Go. Nothing wrong with extra defenses here, but think about it."
+6160,"@@ -0,0 +1,7 @@
++_base_ = './faster_rcnn_r50_fpn_1x_coco.py'
++classes = ('person', 'bicycle', 'car')
++data = dict(
++    train=dict(classes=classes),
++    val=dict(classes=classes),
++    test=dict(classes=classes))
++load_from = 'https://s3.ap-northeast-2.amazonaws.com/open-mmlab/mmdetection/models/faster_rcnn_r50_fpn_1x_20181010-3d1b3351.pth'  # noqa","This URL is outdated, add a `TODO` to fix it."
+6161,"@@ -23,10 +23,13 @@ type (
+ 		Proto() *iotextypes.ActionCore
+ 		LoadProto(pbAct *iotextypes.ActionCore) error
+ 		SetNonce(n uint64)
++		ChainID() uint32
++		SetChainID(chainID uint32)
+ 	}
+
+ 	envelope struct {
+ 		version  uint32
++		chainID  uint32
+ 		nonce    uint64
+ 		gasLimit uint64
+ 		gasPrice *big.Int","`ChainID()` is a getter method, move up to `Nonce()`"
+6162,"@@ -163,6 +163,10 @@ public class FlowTriggerScheduler {
+               flowId, flowTrigger, submitUser, quartzTriggers.isEmpty() ? null
+               : quartzTriggers.get(0), isPaused, flow.isLocked());
+         } catch (final Exception ex) {
++          if (QuartzScheduler.isSerializationBug(ex) && this.scheduler.enableSerializationHack()) {
++            logger.info(""Enable serialization hack"");
++            return getScheduledFlowTriggerJobs();
++          }
+           logger.error(""Unable to get flow trigger by job key {}"", jobKey, ex);
+           scheduledFlowTrigger = null;
+         }","If this condition is not met, shall we just throw the exception rather than logging it? @li-ygerchikov Your thoughts?"
+6163,"@@ -57,6 +57,7 @@ REQUIRED_PACKAGES = [
+     'mock>=2.0.0',
+     'parameterized>=0.6.1',
+     'simple-crypt>=4.1.7',
++    'ruamel.yaml'
+ ]
+
+ if sys.version_info < (2, 7):",nit: alpha-sort `ruamel.yaml` in this list please
+6164,"@@ -58,6 +58,15 @@ public class TableScanUtil {
+
+     Function<FileScanTask, Long> weightFunc = file -> Math.max(file.length(), openFileCost);
+
++    Preconditions.checkArgument(splitSize > 0,
++        ""Cannot create a plan with a split size that is not positive, splitSize = %s"", splitSize);
++
++    Preconditions.checkArgument(lookback > 0,
++        ""Cannot create a plan with a lookback that is not positive, lookback = %s"", lookback);
++
++    Preconditions.checkArgument(openFileCost >= 0,
++        ""Cannot create a plan with a openFileCost that is negative, openFileCost = %s"", openFileCost);
++
+     return CloseableIterable.transform(
+         CloseableIterable.combine(
+             new BinPacking.PackingIterable<>(splitFiles, splitSize, lookback, weightFunc, true),",Remove this because we already added it in another pr
+6165,"@@ -79,7 +79,13 @@ public class ShortcutManager {
+
+             try {
+                 if (shortcutDTO.getIcon() != null) {
+-                    File file = new File(shortcutDTO.getIcon());
++                    File file;
++                    try {
++                        file = new File(shortcutDTO.getIcon());
++                    } catch (IllegalArgumentException e) {
++                        // fallback to phoenicis.png
++                        file = new File(getClass().getResource(""phoenicis.png"").toExternalForm());
++                    }
+                     if (file.exists()) {
+                         FileUtils.copyFile(file, iconFile);
+                     }","Can we maybe move the `File` creation to a new method? I mean both changes look equal to me with the difference of two parts, which could be specified using two input parameters."
+6166,"@@ -9,6 +9,8 @@ class ApiToken < ActiveRecord::Base
+
+   # TODO validates :access_token, presence: true
+   validates :approval_id, presence: true
++  validates :access_token, presence: true, allow_blank: true, length: { minimum: 0, maximum: 255 }
++  validates :user, presence: true, allow_blank: true
+
+   scope :unexpired, -> { where('expires_at >= ?', Time.now) }
+   scope :expired, -> { where('expires_at < ?', Time.now) }",I think we want to require the association with the user...?
+6167,"@@ -110,8 +110,17 @@ func (smsg *SignedMessage) VerifySignature() error {
+ }
+
+ // OnChainLen returns the amount of bytes used to represent the message on chain.
++// Dragons: verify this is the correct way to determine a signed messages size on chain.
+ func (smsg *SignedMessage) OnChainLen() uint32 {
+-	panic(""byteme"")
++	msgBits, err := encoding.Encode(smsg.Message)
++	if err != nil {
++		panic(err)
++	}
++	sigBits, err := encoding.Encode(smsg.Signature)
++	if err != nil {
++		panic(err)
++	}
++	return uint32(len(msgBits) + len(sigBits))
+ }
+
+ func (smsg *SignedMessage) String() string {","I am unsure the below implementation is correct, but need this method to not panic else it borks the chain-validation tests."
+6168,"@@ -19,7 +19,7 @@ A wrapper class for Spark Column to behave similar to pandas Series.
+ """"""
+ import re
+ import inspect
+-from collections import Iterable
++from collections import Iterable, OrderedDict
+ from functools import partial, wraps
+ from typing import Any, Generic, List, Optional, Tuple, TypeVar, Union
+ ",nit: no need this change anymore.
+6169,"@@ -1967,9 +1967,7 @@ class Codebase
+
+         $this->taint_flow_graph->addSource($source);
+
+-        $expr_type->parent_nodes = [
+-            $source->id => $source,
+-        ];
++        $expr_type->parent_nodes[$source->id] = $source;
+     }
+
+     /**","This isn't really that closely related to everything else in this PR, but I'm pretty sure it's a correct change. I'm not familiar enough with the taint feature to know how to test it, but I worry that without this change some of the taint stuff might mess up the `parent_nodes` for a reference."
+6170,"@@ -6,8 +6,9 @@
+ package javaslang;
+
+ import javaslang.collection.Iterator;
+-import javaslang.collection.List;
+ import javaslang.collection.Seq;
++import javaslang.collection.Stream;
++import javaslang.collection.Vector;
+ import javaslang.control.Option;
+
+ import java.io.IOException;",[Checkstyle] ERROR: Unused import - javaslang.collection.Stream.
+6171,"@@ -126,7 +126,7 @@ public class TestPseudoReturnFields extends SolrTestCaseJ4 {
+               ,""//result/doc/str[@name='ssto']""
+               ,""//result/doc/str[@name='subject']""
+
+-              ,""//result/doc[count(*)=4]""
++              ,""//result/doc[count(*)=5]""
+               );
+     }
+   }","The numbers were changed since now _root_ is also added to the doc, increasing the field count by 1."
+6172,"@@ -169,12 +169,6 @@ class ArrayMapReturnTypeProvider implements FunctionReturnTypeProviderInterface
+                                 $function_call_arg->value->items[1]->value->value,
+                                 []
+                             );
+-                        } elseif ($variable_atomic_type instanceof TTemplateParamClass) {
+-                            $fake_method_call = new VirtualStaticCall(
+-                                $function_call_arg->value->items[0]->value,
+-                                $function_call_arg->value->items[1]->value->value,
+-                                []
+-                            );
+                         }
+                     }
+ ",TTemplateParamClass is handled above with the same content in the conditional
+6173,"@@ -597,6 +597,17 @@ class Upgrade
+             }
+         }
+
++        // Upgrade CAPTCHA Options
++        $oldKeys
++            = ['siteKey', 'publicKey', 'secretKey', 'privateKey'];
++        foreach ($oldKeys as $key) {
++            if (isset($newConfig['Captcha'][$key])) {
++                $newConfig['Captcha']['recaptcha_' . $key]
++                    = $newConfig['Captcha'][$key];
++                unset($newConfig['Captcha'][$key]);
++            }
++        }
++
+         // Warn the user about deprecated WorldCat settings:
+         if (isset($newConfig['WorldCat']['LimitCodes'])) {
+             unset($newConfig['WorldCat']['LimitCodes']);",Do we need to add `theme` here?
+6174,"@@ -160,6 +160,9 @@ type Network struct {
+ 	// VPC defines the cluster vpc.
+ 	VPC *VPC `json:""vpc""`
+
++	// InternetGatewayID is the id of the internet gateway associated with the VPC.
++	InternetGatewayID *string `json:""internetGatewayId""`
++
+ 	// Subnets includes all the subnets defined inside the VPC.
+ 	Subnets Subnets `json:""subnets""`
+ }","i think you have to regen the api stuff, `make generate`"
+6175,"@@ -187,9 +187,17 @@ public class SECP256K1 {
+     signer.init(true, privKey);
+
+     final BigInteger[] components = signer.generateSignature(dataHash.toArrayUnsafe());
+-    final BigInteger r = components[0];
+-    BigInteger s = components[1];
+
++    return normaliseSignature(components[0], components[1], keyPair.getPublicKey(), dataHash);
++  }
++
++  public static Signature normaliseSignature(
++      final BigInteger nativeR,
++      final BigInteger nativeS,
++      final PublicKey publicKey,
++      final Bytes32 dataHash) {
++
++    BigInteger s = nativeS;
+     // Automatically adjust the S component to be less than or equal to half the curve
+     // order, if necessary. This is required because for every signature (r,s) the signature
+     // (r, -s (mod N)) is a valid signature of the same message. However, we dislike the",DataHash shouldn't be needed here
+6176,"@@ -110,7 +110,7 @@ public class WebDriverBackedSeleniumHandler implements Routable {
+     StringBuilder printableArgs = new StringBuilder(""["");
+     Joiner.on("", "").appendTo(printableArgs, args);
+     printableArgs.append(""]"");
+-    LOG.info(String.format(""Command request: %s%s on session %s"", cmd, printableArgs, sessionId));
++    LOG.finest(String.format(""Command request: %s%s on session %s"", cmd, printableArgs, sessionId));
+
+     if (""getNewBrowserSession"".equals(cmd)) {
+       // Figure out what to do. If the first arg is ""*webdriver"", check for a session id and use",`info` was chosen deliberately to mirror the old behaviour that users expected.
+6177,"@@ -31,8 +31,8 @@ describeComponent(
+                 component._selectize.setValue(['item 3', 'item 2']);
+             });
+
+-            expect(component.get('value'), 'component value').to.deep.equal(['item 3', 'item 2']);
+-            expect(component.get('selection'), 'component selection').to.deep.equal(['item 3', 'item 2']);
++            expect(component.get('value').toArray(), 'component value').to.deep.equal(['item 3', 'item 2']);
++            expect(component.get('selection').toArray(), 'component selection').to.deep.equal(['item 3', 'item 2']);
+         });
+     }
+ );","For some reason, Safari handles ember arrays differently than Chrome/Firefox. To get around that, we cast the ember array to a regular array to verify the deep equal. (Note: I tried wrapping the expected value in an emberA - which would look like `expect(someEmberArray).to.deep.equal(emberA(['a', 'b']));` but that didn't work either)"
+6178,"@@ -36,6 +36,7 @@ public class VectorHolder {
+   private final Dictionary dictionary;
+   private final NullabilityHolder nullabilityHolder;
+   private final Type icebergType;
++  private final Type originalIcebergType;
+
+   public VectorHolder(
+       ColumnDescriptor columnDescriptor, FieldVector vector, boolean isDictionaryEncoded,","`icebergType` indicates the corresponding iceberg type of the `FieldVector` `originalIcebergType` indicates what the real type we will read from the `FieldVector`. For example, the parquet int backed decimal, the `icebergType` should be integer, `originalIcebergType` is decimal. I intend to only keep the `originalIcebergType`, but listening to your ideas."
+6179,"@@ -43,7 +43,7 @@
+ //  - Reader: *storage.Reader
+ //  - Attributes: storage.ObjectAttrs
+ //  - CopyOptions.BeforeCopy: *storage.Copier
+-//  - WriterOptions.BeforeWrite: *storage.Writer
++//  - WriterOptions.BeforeWrite: **storage.ObjectHandle, *storage.Writer
+ package gcsblob // import ""gocloud.dev/blob/gcsblob""
+
+ import (","The double (and thus triple as seen below) pointer gives me pause. I could imagine providing some larger API surface to smooth it out, but it's likely not worth it."
+6180,"@@ -1011,13 +1011,13 @@ describe('document', function() {
+   });
+
+   describe('Errors', function() {
+-    it('MongooseErrors should be instances of Error (gh-209)', function(done) {
++    it('MongooseError should be instances of Error (gh-209)', function(done) {
+       const MongooseError = require('../lib/error');
+       const err = new MongooseError('Some message');
+       assert.ok(err instanceof Error);
+       done();
+     });
+-    it('ValidationErrors should be instances of Error', function(done) {
++    it('ValidationError should be instances of Error', function(done) {
+       const ValidationError = Document.ValidationError;
+       const err = new ValidationError(new TestDocument);
+       assert.ok(err instanceof Error);","The test name as written was grammatically correct, but now it isn't. Both 'MongooseError' and 'instance' should be both singular or both plural."
+6181,"@@ -125,8 +125,8 @@ public class SmartStoreInspectorActivity extends Activity {
+
+ 	private void readExtras() {
+ 		Bundle bundle = getIntent().getExtras();
+-		isGlobal = bundle.getBoolean(IS_GLOBAL_STORE, false);
+-		dbName = bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
++		isGlobal = bundle == null ? false : bundle.getBoolean(IS_GLOBAL_STORE, false);
++		dbName = bundle == null ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ 	}
+
+ 	/**",SmartStoreInspectorTest was throwing a NPE here
+6182,"@@ -134,9 +134,13 @@ public abstract class DeleteFilter<T> {
+
+       Iterable<CloseableIterable<Record>> deleteRecords = Iterables.transform(deletes,
+           delete -> openDeletes(delete, deleteSchema));
+-      StructLikeSet deleteSet = Deletes.toEqualitySet(
+-          // copy the delete records because they will be held in a set
+-          CloseableIterable.transform(CloseableIterable.concat(deleteRecords), Record::copy),
++
++      // copy the delete records because they will be held in a set
++      CloseableIterable<Record> records = CloseableIterable.transform(CloseableIterable.concat(deleteRecords),
++          Record::copy);
++
++      StructLikeSet deleteSet = Deletes.toEqualitySet(CloseableIterable.transform(records,
++          record -> new InternalRecordWrapper(deleteSchema.asStruct()).wrap(record)),
+           deleteSchema.asStruct());
+
+       Predicate<T> isInDeleteSet = record -> deleteSet.contains(projectRow.wrap(asStructLike(record)));","We prefer line wrapping that keeps arguments to the same method aligned rather than aligning arguments to different levels. Here, the lambda to create an `InternalRecordWrapper` is an argument to `transform`, but it is aligned with `deleteSchema.asStruct()` that is an argument to the outer `toEqualitySet` call. Instead, can you add a newline for each argument to `toEqualitySet`? If the line with the lambda is too long, then you can also add a newline for it that it indented from the start of the line with `transform`, so it is clear that it is an argument to `transform` and not `toEqualitySet`."
+6183,"@@ -173,6 +173,10 @@ import ServerConnections from '../ServerConnections';
+                     value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('<br/>')
+                 });
+             }
++            sessionStats.push({
++                label: globalize.translate('LabelHardwareEncoding'),
++                value: session.TranscodingInfo.HardwareAccelerationType
++            });
+         }
+
+         return sessionStats;","I think it would be a good idea to wrap this in an if like the stats above, just in case."
+6184,"@@ -289,6 +289,9 @@ public class LFMainActivity extends SharedMediaActivity {
+                     mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
+                     editMode = true;
+                 }
++                else {
++                    selectAllPhotosUpToFav(getImagePosition(m.getPath()));
++                }
+             } else selectAllPhotosUpTo(getImagePosition(m.getPath()), mediaAdapter);
+             return true;
+         }","@angmas1 just make one more change here too. Move the else line to the line above it, where the if block ends and remove the braces like in line 280."
+6185,"@@ -21,7 +21,7 @@ func (s *BlkioGroup) Name() string {
+ }
+
+ func (s *BlkioGroup) Apply(path string, d *cgroupData) error {
+-	return join(path, d.pid)
++	return apply(path, d.pid)
+ }
+
+ func (s *BlkioGroup) Set(path string, r *configs.Resources) error {","Looks like the actual rename is missing in this commit edit: Arf, nevermind, I was at the wrong commit  "
+6186,"@@ -67,7 +67,9 @@ module.exports = class Transloadit extends Plugin {
+     this._onRestored = this._onRestored.bind(this)
+     this._getPersistentData = this._getPersistentData.bind(this)
+
+-    if (this.opts.params) {
++    if (this.opts.params ||
++        // No params _and_ no custom getAssemblyOptions is an early error.
++        this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions) {
+       AssemblyOptions.validateParams(this.opts.params)
+     }
+ ","I'm a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)`  "
+6187,"@@ -20,6 +20,15 @@ import (
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ )
+
++var (
++	// These patterns match a key of ""Vars"" in a daisy workflow. All CLI tools use these variables.
++	//
++	// For network and subnet, some workflows use the prefix `import_`.
++	networkPattern               = regexp.MustCompile(""^(import_)?network$"")
++	subnetPattern                = regexp.MustCompile(""^(import_)?subnet$"")
++	computeServiceAccountPattern = regexp.MustCompile(""compute_service_account"")
++)
++
+ // ApplyAndValidateVars is a WorkflowHook that applies vars to a daisy workflow.
+ // To ensure consistency across worker instances, if vars omits network, subnet, or the
+ // compute service account, the modifier will automatically apply these values.",networkVarPattern (etc) then?
+6188,"@@ -138,8 +138,10 @@ module RSpec
+
+         # don't clone the example group because the new example
+         # must belong to the same example group (not a clone).
++        #
++        # block is nil in new_metadata so we have to get it from metadata.
+         Example.new(example_group, description.clone,
+-                    new_metadata, new_metadata[:block])
++                    new_metadata, metadata[:block])
+       end
+
+       # @private","I think it makes sense to do `metadata[:block].clone`, as thats what `new_metadata` is, but somehow it's missing the block from its clone."
+6189,"@@ -51,10 +51,12 @@ class ClosureAnalyzer extends FunctionLikeAnalyzer
+      */
+     public function getClosureId(): string
+     {
+-        return strtolower($this->getFilePath())
+-            . ':' . $this->function->getLine()
+-            . ':' . (int)$this->function->getAttribute('startFilePos')
+-            . ':-:closure';
++        return strtolower(
++            $this->getFilePath()
++                . ':' . $this->function->getLine()
++                . ':' . (int)$this->function->getAttribute('startFilePos')
++                . ':-:closure'
++        );
+     }
+
+     /**",Just realized this should be fixed instead of changing here. Concatenating int should still result in lowercase string.
+6190,"@@ -79,7 +79,7 @@ module Selenium
+             opts[:browser_version] = opts.delete(:version) if opts.key?(:version)
+             opts[:platform_name] = opts.delete(:platform) if opts.key?(:platform)
+
+-            new({browser_name: 'firefox'}.merge(opts))
++            new({browser_name: 'firefox', marionette: true}.merge(opts))
+           end
+
+           alias_method :ff, :firefox",For Se 3.x we shouldn't need to specify `marionette: true`? I'll see if I can figure out where this is getting used that it might be necessary here.
+6191,"@@ -34,14 +34,14 @@ func initStoreTest(ctx context.Context, t *testing.T, dstP *DefaultSyncerTestPar
+ 	requireSetTestChain(t, con, true, dstP)
+ }
+
+-func newChainStore(dstP *DefaultSyncerTestParams) chain.Store {
++func newChainStore(dstP *DefaultSyncerTestParams) *chain.DefaultStore {
+ 	r := repo.NewInMemoryRepo()
+ 	ds := r.Datastore()
+ 	return chain.NewDefaultStore(ds, dstP.genCid)
+ }
+
+ // requirePutTestChain adds all test chain tipsets to the passed in chain store.
+-func requirePutTestChain(t *testing.T, chainStore chain.Store, dstP *DefaultSyncerTestParams) {
++func requirePutTestChain(t *testing.T, chainStore *chain.DefaultStore, dstP *DefaultSyncerTestParams) {
+ 	ctx := context.Background()
+ 	genTsas := &chain.TipSetAndState{
+ 		TipSet:          dstP.genTS,","This should be renamed to `chain.Store`. It was named `DefaultStore` as an alternative to `StoreImpl`, which is the (bad) Java convention."
+6192,"@@ -85,8 +85,12 @@ func (a *AttachDisks) validate(ctx context.Context, s *Step) (errs DError) {
+ 		ad.zone = disk[""zone""]
+
+ 		// Register disk attachments.
+-		errs = addErrs(errs, s.w.instances.w.disks.regAttach(ad.Source, ad.Instance, ad.Mode, s))
+-
++		// If device name is not given explicitly, its device name will be the same as disk name.
++		deviceName := ad.Source
++		if ad.DeviceName != """" {
++			deviceName = ad.DeviceName
++		}
++		errs = addErrs(errs, s.w.instances.w.disks.regAttach(deviceName, ad.Source, ad.Instance, ad.Mode, s))
+ 	}
+ 	return errs
+ }","ad.Source is disk name? Shouldn't the order of initialization be reversed here then? First set ad.DeviceName, if it's empty, set ad.Source? Or this is a different use case? This is the third place where this device/disk default logic is implemented, so another reason to move it to regAttach, if it's possible to be generalized."
+6193,"@@ -26,6 +26,11 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         [Output]
+         public ITaskItem[] PackageInfos { get; set; }
+
++        /// <summary>
++        /// Specify max number of minutes that the lock of the feed container will be hold.
++        /// </summary>
++        public int FeedLockTimeoutMinutes { get; set; } = int.MaxValue;
++
+         public override bool Execute()
+         {
+             return ExecuteAsync().GetAwaiter().GetResult();","typo: ""be hold"" -> ""be held"""
+6194,"@@ -44,10 +44,10 @@ namespace Nethermind.Blockchain.Receipts
+
+         public long? LowestInsertedReceiptBlockNumber
+         {
+-            get => long.MaxValue;
++            get => 1;
+             set { }
+         }
+
+         public long MigratedBlockNumber { get; set; } = 0;
+     }
+-}
++}",I do not think we should have any logic inside the null storage. 1 has a very specific magical meaning. We should either return null here or long.maxValue.
+6195,"@@ -397,7 +397,7 @@ func TestInitProcessEnabled(t *testing.T) {
+ 	}
+ 	agent := RunAgent(t, nil)
+ 	defer agent.Cleanup()
+-	agent.RequireVersion("">=1.14.5"")
++	agent.RequireVersion("">=1.15.0"")
+
+ 	td, err := GetTaskDefinition(""init-process"")
+ 	if err != nil {",Why did this change?
+6196,"@@ -168,7 +168,6 @@ class PlansController < ApplicationController
+     render('/phases/edit', locals: {
+       base_template_org: phase.template.base_org,
+       plan: plan, phase: phase, readonly: readonly,
+-      question_guidance: plan.guidance_by_question_as_hash,
+       guidance_groups: guidance_groups,
+       answers: answers,
+       guidance_service: GuidanceService.new(plan) })","Removed this method. Doesn't seem to be used in the code, and the variable set here doesn't seem to be used in the views."
+6197,"@@ -16,7 +16,12 @@ namespace Microsoft.CodeAnalysis.Sarif
+     {
+         internal const string DEFAULT_POLICY_NAME = ""default"";
+
+-        public PropertyBagDictionary() : base() { }
++        public PropertyBagDictionary() : this(null) { }
++
++        public PropertyBagDictionary(PropertyBagDictionary initializer) :
++            this(initializer, null)
++        {
++        }
+
+         public PropertyBagDictionary(
+             PropertyBagDictionary initializer = null,","Remove the initializers (""`= null`"") from both parameters. Remember that that's why we added the overloads: to ensure that all languages could have the convenience of the abbreviated argument lists (not all languages understand default parameters)."
+6198,"@@ -0,0 +1,13 @@
++package values
++
++import (
++	""github.com/influxdata/flux/semantic""
++)
++
++type Vector interface {
++	Value
++	ElementType() semantic.MonoType
++	Get(i int) Value
++	Set(i int, value Value)
++	Len() int
++}","I think you can just remove most of these attributes outside of `ElementType()`. Instead, this should expose the arrow array. We're not going to use these methods anyway."
+6199,"@@ -5,8 +5,7 @@ import { enqueueRender } from '../render-queue';
+ import { getNodeProps } from './index';
+ import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, removeChildren } from './diff';
+ import { createComponent, collectComponent } from './component-recycler';
+-
+-
++import remove from './remove';
+
+ /** Set a component's `props` (generally derived from JSX attributes).
+  *	@param {Object} props",Thinking this should be `removeNode()` exported from `dom/index.js`. Thoughts?
+6200,"@@ -125,6 +125,10 @@ type Task struct {
+ 	// ENI is the elastic network interface specified by this task
+ 	ENI     *ENI
+ 	eniLock sync.RWMutex
++
++	// memoryCPULimitsEnabled to determine if task supports CPU, memory limits
++	memoryCPULimitsEnabled     bool
++	memoryCPULimitsEnabledLock sync.RWMutex
+ }
+
+ // PostUnmarshalTask is run after a task has been unmarshalled, but before it has been",Does this need to be saved in the state file? Or are we recomputing when the task is read from the state file?
+6201,"@@ -503,11 +503,11 @@ func (s *Sublist) Stats() *SublistStats {
+ 	st := &SublistStats{}
+ 	st.NumSubs = s.count
+ 	st.NumCache = uint32(len(s.cache))
+-	st.NumInserts = s.inserts
+-	st.NumRemoves = s.removes
+-	st.NumMatches = s.matches
+-	if s.matches > 0 {
+-		st.CacheHitRate = float64(s.cacheHits) / float64(s.matches)
++	st.NumInserts = atomic.LoadUint64(&s.inserts)
++	st.NumRemoves = atomic.LoadUint64(&s.removes)
++	st.NumMatches = atomic.LoadUint64(&s.matches)
++	if st.NumMatches > 0 {
++		st.CacheHitRate = float64(atomic.LoadUint64(&s.cacheHits)) / float64(st.NumMatches)
+ 	}
+ 	// whip through cache for fanout stats
+ 	tot, max := 0, 0","Looks like `s.inserts` and `s.removes` are updated under sublist's lock, so I don't think you need atomic for those 2."
+6202,"@@ -39,7 +39,10 @@ void setUseStaticIP(bool enabled) {
+
+ void markGotIP() {
+   lastGetIPmoment = millis();
++  // Create the 'got IP event' so mark the wifiStatus to not have the got IP flag set
++  // This also implies the services are not fully initialized.
+   wifiStatus     &= ~ESPEASY_WIFI_GOT_IP;
++  wifiStatus     &= ~ESPEASY_WIFI_SERVICES_INITIALIZED;
+   processedGotIP = false;
+ }
+ ","@TD-er use bitRead/bitWrite macros, do you use here inversed logic?"
+6203,"@@ -19,11 +19,11 @@
+ /**
+  * External dependencies
+  */
++import fetchMock from 'fetch-mock-jest';
+
+ /**
+  * WordPress dependencies
+  */
+-import apiFetch from '@wordpress/api-fetch';
+ import { createRegistry } from '@wordpress/data';
+
+ /**",The previous `fetch` mock was exposed globally before - can we do the same with `fetchMock` so we don't need to import it in every file?
+6204,"@@ -29,9 +29,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+             HttpRequestHeaders headers,
+             Http2Stream context)
+         {
+-            if (!context.ExpectData)
++            if (context.EndStreamReceived)
+             {
+-                return MessageBody.ZeroContentLengthClose;
++                return ZeroContentLengthClose;
+             }
+
+             return new ForHttp2(context);",Is ExpectData still used anywhere?
+6205,"@@ -230,7 +230,7 @@ class Docstring:
+
+ class SphinxDocstring(Docstring):
+     re_type = r""""""
+-        [~!]?                # Optional link style prefix
++        [~!.]?               # Optional link style prefix
+         \w(?:\w|\.[^\.])*    # Valid python name
+         """"""
+ ","Do you want to allow the character `.` or any character? Because inside a regex `.` means any character, if you want to authorize `.` then you need to add `\.` ."
+6206,"@@ -711,4 +711,18 @@ describe('QueryCursor', function() {
+       assert.deepEqual(arr, ['KICKBOXER', 'IP MAN', 'ENTER THE DRAGON']);
+     });
+   });
++  it('returns array for schema hooks gh-9982', () => {
++    const testSchema = new mongoose.Schema({ name: String });
++    testSchema.post('find', (result) => {
++      assert.ok(Array.isArray(result));
++    });
++    const Movie = db.model('Movie', testSchema);
++    return co(function*() {
++      yield Movie.deleteMany({});
++      yield Movie.create({ name: 'Daniel' }, { name: 'Val' }, { name: 'Daniel' });
++      yield Movie.find({ name: 'Daniel' }).cursor().eachAsync(doc => {
++        assert.ok(Array.isArray(doc));
++      });
++    });
++  });
+ });","`eachAsync()` should pass a doc, not an array of docs, to the callback. This would be a massive breaking change."
+6207,"@@ -323,11 +323,11 @@ func (uc *UpstreamController) updatePodStatus(stop chan struct{}) {
+ 				}
+
+ 			default:
+-				klog.Infof(""pod status operation: %s unsupported"", msg.GetOperation())
++				klog.Warningf(""pod status operation: %s unsupported"", msg.GetOperation())
+ 			}
+-			klog.Infof(""message: %s process successfully"", msg.GetID())
++			klog.V(4).Infof(""message: %s process successfully"", msg.GetID())
+ 		case <-stop:
+-			klog.Info(""stop updatePodStatus"")
++			klog.Warning(""stop updatePodStatus"")
+ 			running = false
+ 		}
+ 	}",please start log with caps letters
+6208,"@@ -10,4 +10,5 @@
+ <%= render 'layouts/typekit' %>
+ <%= csrf_meta_tag %>
+ <%= render 'layouts/ie_shiv' %>
++<%= render 'layouts/visual_website_optimizer' %>
+ <%= yield :head %>",Is this where we want it in relation to the other scripts?
+6209,"@@ -13,6 +13,7 @@
+     _,
+     T
+  */
++ var FEATURE_NAME = ""reports"";
+
+ window.ReportingView = countlyView.extend({
+     featureName: 'reports',","Please wrap this variable within a self invoking anonymous function. (function(){ FEATURE_NAME = ""reports""; //and rest of the js goes here. })();"
+6210,"@@ -393,6 +393,14 @@ func (c *linuxContainer) Signal(s os.Signal, all bool) error {
+ 		if err := c.initProcess.signal(s); err != nil {
+ 			return fmt.Errorf(""unable to signal init: %w"", err)
+ 		}
++		if status == Paused {
++			// For cgroup v1, killing a process in a frozen cgroup
++			// does nothing until it's thawed. Only thaw the cgroup
++			// for SIGKILL.
++			if s, ok := s.(unix.Signal); ok && s == unix.SIGKILL {
++				_ = c.cgroupManager.Freeze(configs.Thawed)
++			}
++		}
+ 		return nil
+ 	}
+ 	return ErrNotRunning","Haven't tried, but what happens currently if `-f` is used and it's not running? (thinking: `-f` should ignore the case and just proceed?) I see we have a special case for `all`"
+6211,"@@ -1,10 +1,11 @@
+ 'use strict';
+ const { MongoClient } = require('../../src');
+ const { expect } = require('chai');
++const { MongoURIError } = require('../../src/error');
+
+ describe('LDAP', function () {
+   if (process.env.MONGODB_URI == null) {
+-    throw new Error(`skipping SSL tests, MONGODB_URI environment variable is not defined`);
++    throw new MongoURIError(`skipping SSL tests, MONGODB_URI environment variable is not defined`);
+   }
+
+   it('Should correctly authenticate against ldap', function (done) {",no need for custom errors in tests unless the tests are intended to mock a specific sort of error
+6212,"@@ -21,4 +21,6 @@ const (
+ 	NvidiaGPUStatusAnnotationKey = ""huawei.com/gpu-status""
+ 	// NvidiaGPUScalarResourceName is the device plugin resource name used for special handling
+ 	NvidiaGPUScalarResourceName = ""nvidia.com/gpu""
++
++	EdgeNodeRoleLabelKey = ""node-role.kubernetes.io/edge""
+ )","This const has already existed in the code, no need to define a new one"
+6213,"@@ -362,7 +362,7 @@ func captureErrorLogs(algohConfig algoh.HostConfig, errorOutput stdCollector, ou
+
+ func reportErrorf(format string, args ...interface{}) {
+ 	fmt.Fprintf(os.Stderr, format, args...)
+-	logging.Base().Fatalf(format, args...)
++	logging.Base().Warnf(format, args...)
+ }
+
+ func sendLogs() {",Would Errorf be better than Warnf?
+6214,"@@ -93,15 +93,16 @@ public class JSExport {
+   }
+
+   public static String getCordovaPluginJS(Context context) {
+-    return getFilesContent(context, ""public/plugins"", """");
++    return getFilesContent(context, ""public/plugins"");
+   }
+
+-  public static String getFilesContent(Context context, String path, String currentContent) {
++  public static String getFilesContent(Context context, String path) {
++    String currentContent = """";
+     try {
+       String[] content = context.getAssets().list(path);
+       if (content.length  > 0) {
+         for (String file: content) {
+-          currentContent += getFilesContent(context, path+""/""+file, currentContent);
++          currentContent += getFilesContent(context, path+""/""+file);
+         }
+       } else {
+         return getJS(context, path);","A good candidate for StringBuilder? Also make sure to add white space around the operators (`path + ""/"" + file`)"
+6215,"@@ -200,4 +200,17 @@ public interface ProjectLoader {
+       throws ProjectManagerException;
+
+   void updateProjectSettings(Project project) throws ProjectManagerException;
++
++  /**
++   * Uploads flow file.
++   */
++  void uploadFlowFile(int projectId, int projectVersion, int flowVersion,
++      File flowFile) throws ProjectManagerException;
++
++  /**
++   * Gets flow file that's uploaded.
++   */
++  File getUploadedFlowFile(int projectId, int projectVersion, String flowName, int
++      flowVersion) throws ProjectManagerException;
++
+ }",Can we have the same argument order as `getUploadedFlowFile`?
+6216,"@@ -46,7 +46,7 @@ type (
+ 		RangeSize                    int64
+ 		GetTasksBatchSize            dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters
+ 		UpdateAckInterval            dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
+-		IdleTaskqueueCheckInterval   dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
++		IdleTaskqueueCheckInterval   dynamicconfig.DurationPropertyFn
+ 		MaxTaskqueueIdleTime         dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
+ 		NumTaskqueueWritePartitions  dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters
+ 		NumTaskqueueReadPartitions   dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters","this dynamic config should still be valid, i.e. operator should have the ability to control each individual task queue just in case"
+6217,"@@ -394,6 +394,17 @@ class VirtualBufferTextInfo(browseMode.BrowseModeDocumentTextInfo,textInfos.offs
+ 		obj = self.obj.getNVDAObjectFromIdentifier(docHandle, nodeId)
+ 		return obj.mathMl
+
++	def scrollIntoView(self):
++		# Scroll the deepest object at this point into view.
++		obj = self.NVDAObjectAtStart
++		if not obj:
++			return
++		if obj == self.obj.rootNVDAObject:
++			# However never scroll to the  document itself
++			return
++		obj.scrollIntoView()
++
++
+ class VirtualBuffer(browseMode.BrowseModeDocumentTreeInterceptor):
+
+ 	TextInfo=VirtualBufferTextInfo",Should these cases be logged? `if not obj` used to be
+6218,"@@ -0,0 +1,19 @@
++require 'travis/build/appliances/base'
++
++module Travis
++  module Build
++    module Appliances
++      class UpdateAptKeys < Base
++        def apply
++          command = <<-EOF
++          if command -v apt-get &>/dev/null && [[ -d /var/lib/apt/lists ]]; then
++            LANG=C apt-key list | awk -F'[ /]+' '/expired:/{printf ""apt-key adv --recv-keys --keyserver keys.gnupg.net %s\\n"", $3}' | sudo sh &>/dev/null
++          fi
++          EOF
++          sh.cmd command, echo: false
++        end
++      end
++    end
++  end
++end
++",Is it OK to assume that keys.gnupg.net has the new key?
+6219,"@@ -128,11 +128,6 @@ class FileSystem(object):
+                              exist, raise luigi.target.MissingParentDirectory
+         :param bool raise_if_exists: raise luigi.target.FileAlreadyExists if
+                                      the folder already exists.
+-
+-        *Note*: This method is optional, not all FileSystem subclasses implements it.
+-
+-        *Note*: parents and raise_if_exists were added in August 2014. Some
+-                implementations might not support these flags yet.
+         """"""
+         raise NotImplementedError(""mkdir() not implemented on {0}"".format(self.__class__.__name__))
+ ","A note for however is curious. I think these two notes add negative value only. In general we want people to implement this method (in particular after this patch). If we leave these old (and currently mis-rendered) notes, file system implementors might not implement this method referring to this."
+6220,"@@ -216,15 +216,12 @@ public class PriorityQueueTest extends AbstractTraversableTest {
+         empty().dequeue();
+     }
+
+-    // -- toSortedQueue
++    // -- toPriorityQueue
+
+     @Test
+-    public void shouldKeepInstanceOfSortedQueue() {
+-        final SerializableComparator<Integer> comparator = naturalComparator();
+-        final PriorityQueue<Integer> queue = PriorityQueue.of(comparator, 1, 3, 2);
+-        if (!queue.isSingleValued()) {
+-            assertThat(queue.toSortedQueue(comparator)).isSameAs(queue);
+-        }
++    public void shouldKeepInstanceOfPriorityQueue() {
++        final PriorityQueue<Integer> queue = PriorityQueue.of(1, 3, 2);
++        assertThat(queue.toPriorityQueue()).isSameAs(queue);
+     }
+
+     // -- property based tests","Comparators (or functions in general) cannot be compared for equality. Therefore `PriorityQueue.of(comparator, ...)` always has to return a new instance."
+6221,"@@ -27,7 +27,7 @@ module Bolt
+
+       @noop = noop
+       @run_as = nil
+-      @pool = Concurrent::CachedThreadPool.new(max_threads: @config[:concurrency])
++      @pool = Concurrent::ThreadPoolExecutor.new(max_threads: @config[:concurrency])
+       @logger.debug { ""Started with #{@config[:concurrency]} max thread(s)"" }
+       @notifier = Bolt::Notifier.new
+     end",It's a little surprising that CachedThreadPool overrides the max_threads argument. This makes sense as a solution though.
+6222,"@@ -42,12 +42,14 @@ def weight_reduce_loss(loss, weight=None, reduction='mean', avg_factor=None):
+     # if avg_factor is not specified, just reduce the loss
+     if avg_factor is None:
+         loss = reduce_loss(loss, reduction)
+-    # otherwise average the loss by avg_factor
+-    else:
+-        if reduction != 'mean':
+-            raise ValueError(
+-                'avg_factor can only be used with reduction=""mean""')
++    # if avg_factor are specified
++    # if reduction is mean, reduce the loss sum by avg factor
++    elif reduction == 'mean':
+         loss = loss.sum() / avg_factor
++    elif reduction == 'none':
++        loss = loss
++    else:
++        raise ValueError('avg_factor can not be used with reduction=""sum""')
+     return loss
+
+ ","```python # if avg_factor is not specified, just reduce the loss if avg_factor is None: loss = reduce_loss(loss, reduction) else: # if reduction is mean, then average the loss by avg_factor if reduction == 'mean': loss = loss.sum() / avg_factor # if reduction is 'none', then do nothing, otherwise raise an error elif reduction != 'none': raise ValueError('avg_factor can not be used with reduction=""sum""')"
+6223,"@@ -46,9 +46,9 @@ class BasicBlock(nn.Module):
+             planes,
+             planes,
+             3,
+-            stride=stride,
+-            padding=dilation,
+-            dilation=dilation,
++            stride=1,
++            padding=1,
++            dilation=1,
+             bias=False)
+         self.add_module(self.norm2_name, norm2)
+ ",`padding` should be 0 instead. Actually you can just remove padding and dilation to use default values.
+6224,"@@ -1447,7 +1447,7 @@ class Aleph extends AbstractBase implements \Laminas\Log\LoggerAwareInterface,
+             $checkout = $finesListSort[$key][""checkout""];
+             $transactiondate = $finesListSort[$key][""transactiondate""];
+             $transactiontype = $finesListSort[$key][""transactiontype""];
+-            $balance += $finesListSort[$key][""amount""];
++            $balance = $finesListSort[$key][""amount""];
+             $id = $finesListSort[$key][""id""];
+             $fine = $finesListSort[$key][""fine""];
+             $finesList[] = [","$balance is initialized to 0 above in line 1428 and then assigned in line 1437. If we're no longer manipulating that value, is there a reason to use a variable at all? It might make the overall code less confusing to make some changes there."
+6225,"@@ -73,9 +73,9 @@ class SeriesPlotTest(ReusedSQLTestCase, TestUtils):
+         pdf = self.pdf1
+         kdf = self.kdf1
+
+-        ax1 = pdf['a'].plot(""bar"", colormap='Paired')
++        ax1 = pdf['a'].plot(kind=""bar"", colormap='Paired')
+         bin1 = self.plot_to_base64(ax1)
+-        ax2 = kdf['a'].plot(""bar"", colormap='Paired')
++        ax2 = kdf['a'].plot(kind=""bar"", colormap='Paired')
+         bin2 = self.plot_to_base64(ax2)
+         self.assertEqual(bin1, bin2)
+ ",Why do we need to explicitly use keyword arguments?
+6226,"@@ -708,7 +708,8 @@ func (c *Client) updateProgress(tid int, target *core.BuildTarget, metadata *pb.
+ 		case pb.ExecutionStage_EXECUTING:
+ 			c.state.LogBuildResult(tid, target.Label, core.TargetBuilding, ""Building..."")
+ 		case pb.ExecutionStage_COMPLETED:
+-			c.state.LogBuildResult(tid, target.Label, core.TargetBuilt, ""Built"")
++			// The build result will be logged in build/build_step.go
++			return
+ 		}
+ 	} else {
+ 		switch metadata.Stage {",Might still want to log this as `TargetBuilding` but with a slightly different message?
+6227,"@@ -6,6 +6,17 @@
+
+ C015_queue_element::C015_queue_element() {}
+
++C015_queue_element::C015_queue_element(C015_queue_element&& other)
++  : idx(other.idx), _timestamp(other._timestamp), TaskIndex(other.TaskIndex)
++  , controller_idx(other.controller_idx), valuesSent(other.valuesSent)
++  , valueCount(other.valueCount)
++{
++  for (byte i = 0; i < VARS_PER_TASK; ++i) {
++    txt[i]  = std::move(other.txt[i]);
++    vPin[i] = other.vPin[i];
++  }
++}
++
+ C015_queue_element::C015_queue_element(const struct EventStruct *event, byte value_count) :
+   idx(event->idx),
+   TaskIndex(event->TaskIndex),","ref. above, this also can be omitted in case `txt = std::move(other.txt);` could work (or copy), consider `std::array<String, VARS_PER_TASK>;`? or a custom object implementing `Object& operator=(Object&&) noexcept;'"
+6228,"@@ -10,7 +10,7 @@
+
+ """"""Looks for try/except statements with too much code in the try clause.""""""
+
+-from astroid.node_classes import For, If, While, With
++from astroid import nodes
+
+ from pylint import checkers, interfaces
+ ","Well done, we forget that one apparentely."
+6229,"@@ -25,17 +25,6 @@ except:
+     xr = None
+
+
+-def toarray(v, index_value=False):
+-    """"""
+-    Interface helper function to turn dask Arrays into numpy arrays as
+-    necessary. If index_value is True, a value is returned instead of
+-    an array holding a single value.
+-    """"""
+-    if dask and isinstance(v, dask.array.Array):
+-        arr =  v.compute()
+-        return arr[()] if index_value else arr
+-    else:
+-        return v
+
+ def compute_edges(edges):
+     """"""",Guess it isn't used. The dask thing was just a prototype so removing it is probably the right thing to do.
+6230,"@@ -12,7 +12,17 @@ from elasticsearch.helpers import bulk
+ from t4_lambda_shared.preview import ELASTIC_LIMIT_BYTES
+
+
+-CONTENT_INDEX_EXTS = [
++def _get_extension_overrides():
++    """"""check the environment for index extension overrides; this is a standalone
++    function so that it can be unit tested""""""
++    return {
++        t.strip().lower()
++        for t in os.getenv(""CONTENT_INDEX_EXTS"", """").split("","")
++        if t.strip().startswith(""."")
++    }
++
++
++CONTENT_INDEX_EXTS = _get_extension_overrides() or {
+     "".csv"",
+     "".ipynb"",
+     "".md"",","This code is correct, but it's a bit confusing to see how (e.g., without the if startswith("".') the or below would break.) I think it will be clearer for the long run if you refactor this just a bit. CONTENT_INDEX_EXTS (all caps) looks like a constant, but is now being set by the environment. Instead, replace the reference to CONTENT_INDEX_EXTS in index.py with a simple call to a method ""get_content_index_exts"" (or similar). Then you can write all the logic into one clean function."
+6231,"@@ -298,4 +298,9 @@ public final class ZMSConsts {
+     public static final int ZMS_DISABLED_AUTHORITY_FILTER = 0x01;
+
+     public static final String ZMS_PROP_STATUS_CHECKER_FACTORY_CLASS = ""athenz.zms.status_checker_factory_class"";
++
++    public static final String ZMS_PROP_ENABLE_PRINCIPAL_STATE_UPDATER        = ""athenz.zms.enable_principal_state_updater"";
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY = ""athenz.zms.principal_state_updater_frequency"";
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY_DEFAULT = ""30""; // in minutes
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_DISABLE_TIMER = ""athenz.zms.disable_principal_state_updater_timer_task"";
+ }",please update the zms conf file to have a small description of these options since by default feature is off and must be enabled
+6232,"@@ -31,7 +31,12 @@ module.exports = class ThumbnailGenerator extends Plugin {
+     const defaultOptions = {
+       thumbnailWidth: null,
+       thumbnailHeight: null,
+-      waitForThumbnailsBeforeUpload: false
++      waitForThumbnailsBeforeUpload: false,
++      lazy: false
++    }
++
++    if (defaultOptions.lazy && defaultOptions.waitForThumbnailsBeforeUpload) {
++      throw new Error('ThumbnailGenerator: The `lazy` and `waitForThumbnailsBeforeUpload` options are mutually exclusive. Please ensure at most one of them is set to `true`.')
+     }
+
+     this.opts = { ...defaultOptions, ...opts }",Should be `this.opts` instead of `defaultOptions`
+6233,"@@ -27,6 +27,7 @@ const pkgVersion = module.exports.version;
+ const pkgName = module.exports.name;
+
+ export const DIST_TAGS = 'dist-tags';
++export const USERS = 'users';
+
+ export function getUserAgent(): string {
+   assert(_.isString(pkgName));",You can reuse `USERS` above as well.
+6234,"@@ -460,11 +460,6 @@ public final class Util {
+           continue;
+         }
+
+-        if (results.size() == topN-1 && maxQueueDepth == topN) {
+-          // Last path -- don't bother w/ queue anymore:
+-          queue = null;
+-        }
+-
+         // We take path and find its ""0 output completion"",
+         // ie, just keep traversing the first arc with
+         // NO_OUTPUT that we can find, since this must lead","Whoa, was this opto breaking something? I guess if this final path is filtered out, we still need the queue? Have you run the suggest benchmarks to see if removing this opto hurt performance?"
+6235,"@@ -191,7 +191,7 @@ final class Collections {
+         if (iterable instanceof Seq) {
+             return (Seq<T>) iterable;
+         } else {
+-            return List.ofAll(iterable);
++            return Stream.ofAll(iterable);
+         }
+     }
+ }","I'm not sure about this, please check the usages. It's only used currently to reverse it, maybe we should eliminate this method completely instead."
+6236,"@@ -638,6 +638,18 @@ class AbstractBase extends AbstractActionController
+         return $check->getTagSetting() !== 'disabled';
+     }
+
++    /**
++     * Are list tags enabled?
++     *
++     * @return bool
++     */
++    protected function listTagsEnabled()
++    {
++        $check = $this->serviceLocator
++            ->get(\VuFind\Config\AccountCapabilities::class);
++        return $check->getListTagSetting() === 'enabled';
++    }
++
+     /**
+      * Store a referer (if appropriate) to keep post-login redirect pointing
+      * to an appropriate location. This is used when the user clicks the","Since this is only used in the MyResearchController, does it need to be placed at the AbstractBase level?"
+6237,"@@ -55,7 +55,7 @@ type SelectorSpec struct {
+ 	// +optional
+ 	AnnotationSelectors map[string]string `json:""annotationSelectors,omitempty""`
+
+-	// PodPhaseSelector is a set of condition of a pod at the current time.
++	// PhaseSelector is a set of condition of a pod at the current time.
+ 	// supported value: Pending / Running / Succeeded / Failed / Unknown
+ 	PodPhaseSelectors []string `json:""phaseSelector,omitempty""`
+ }",why `PhaseSelector` ?
+6238,"@@ -32,6 +32,8 @@ type rawConfig struct {
+ 	RestrictedLicenses []string `json:""restricted_licenses""`
+
+ 	// modules that get completely ignored during analysis
++	AllowlistedModules []string `json:""allowlisted_modules""`
++	// Deprecated. TODO(tbarrella): Clean up
+ 	WhitelistedModules []string `json:""whitelisted_modules""`
+ }
+ ",Does` AllowlistedModules` have the same meaning of `WhitelistedModules`?
+6239,"@@ -357,7 +357,7 @@ return [
+ 'ArithmeticError::getTrace' => ['array<int,array<string,mixed>>'],
+ 'ArithmeticError::getTraceAsString' => ['string'],
+ 'array_change_key_case' => ['array|false', 'input'=>'array', 'case='=>'int'],
+-'array_chunk' => ['array[]', 'input'=>'array', 'size'=>'int', 'preserve_keys='=>'bool'],
++'array_chunk' => ['list<array>', 'input'=>'array', 'size'=>'int', 'preserve_keys='=>'bool'],
+ 'array_column' => ['array', 'array'=>'array', 'column_key'=>'mixed', 'index_key='=>'mixed'],
+ 'array_combine' => ['array|false', 'keys'=>'string[]|int[]', 'values'=>'array'],
+ 'array_count_values' => ['int[]', 'input'=>'array'],","I missed the $preserve_keys=true case when adding this to Phan. For psalm, two separate signatures may make sense"
+6240,"@@ -18,14 +18,19 @@
+ package org.apache.servicecomb.foundation.vertx.server;
+
+ import java.net.InetSocketAddress;
++import java.util.concurrent.atomic.AtomicInteger;
+
++import org.apache.servicecomb.foundation.common.event.EventManager;
+ import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
+ import org.apache.servicecomb.foundation.ssl.SSLCustom;
+ import org.apache.servicecomb.foundation.ssl.SSLOption;
+ import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
+ import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
++import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+ import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+
++import com.netflix.config.DynamicPropertyFactory;
++
+ import io.vertx.core.Vertx;
+ import io.vertx.core.net.NetServer;
+ import io.vertx.core.net.NetServerOptions;",TcpServer will be created for each HighwayServerVerticle instance so the counter number in server is not correct.
+6241,"@@ -109,10 +109,14 @@ public class WindowsUtils {
+      * quote (\""?)
+      */
+     // TODO We should be careful, in case Windows has ~1-ified the executable name as well
+-    pattern.append(""\""?.*?\\\\"");
+-    pattern.append(executable.getName());
++    pattern.append(""(\""?.*?\\\\)?"");
++    String execName = executable.getName();
++    pattern.append(execName);
++    if (!execName.endsWith("".exe"")) {
++      pattern.append(""(\\.exe)?"");
++    }
+     pattern.append(""\""?"");
+-    for (String arg : cmdarray) {
++    for (int i = 1; i < cmdarray.length; i++) {
+       /*
+        * There may be a space, but maybe not (\\s?), may be a quote or maybe not (\""?), but then
+        * turn on block quotation (as if *everything* had a regex backslash in front of it) with \Q.",Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it.
+6242,"@@ -116,6 +116,12 @@ func FindCgroupMountpoint(cgroupPath, subsystem string) (string, error) {
+ 		return """", errUnified
+ 	}
+
++	// If subsystem is empty it means that we are looking for the
++	// cgroups2 path
++	if len(subsystem) == 0 {
++		return hybridMountpoint, nil
++	}
++
+ 	// Avoid parsing mountinfo by trying the default path first, if possible.
+ 	if path := tryDefaultPath(cgroupPath, subsystem); path != """" {
+ 		return path, nil","I'd say ""cgroup2 hybrid path"" instead."
+6243,"@@ -84,15 +84,12 @@ module Bolt
+       {
+         'name' => name,
+         'uri' => uri,
+-        'alias' => @target_alias,
+-        'config' => config.merge(
+-          'transport' => transport,
+-          transport => options
+-        ),
++        'alias' => target_alias,
++        'config' => Bolt::Util.deep_merge(config, 'transport' => transport, transport => options),
+         'vars' => vars,
+         'features' => features,
+         'facts' => facts,
+-        'plugin_hooks' => Bolt::Util.deep_clone(plugin_hooks)
++        'plugin_hooks' => plugin_hooks
+       }
+     end
+ ",I dont see a reason to print URI for `Target`. we do not expose that in inventory v1
+6244,"@@ -131,9 +131,13 @@ type OpExpression struct {
+ type ValueExpression struct {
+ 	String  string
+ 	FString *FString
+-	Int     *struct {
+-		Int int
+-	} // Should just be *int, but https://github.com/golang/go/issues/23498 :(
++	// These are true if this represents one of the boolean singletons
++	True  bool
++	False bool
++	None  bool
++	// True if the Int field is set; this helps us distinguish values of 0.
++	IsInt    bool
++	Int      int
+ 	Bool     string
+ 	List     *List
+ 	Dict     *Dict",Do we still need this?
+6245,"@@ -79,9 +79,13 @@ type Application struct {
+ type Gclient struct {
+ 	// constant tracking-id used to send a hit
+ 	trackID string
++
+ 	// anonymous client-id
+ 	clientID string
+
++	// anonymous campaign source
++	campaignSource string
++
+ 	// https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds
+ 	// (usecase) node-detail
+ 	dataSource string",`campaignSource` is unused (from `structcheck`)
+6246,"@@ -63,6 +63,7 @@ public final class BaselineErrorProne implements Plugin<Project> {
+     private static final Logger log = Logging.getLogger(BaselineErrorProne.class);
+     public static final String EXTENSION_NAME = ""baselineErrorProne"";
+     private static final String ERROR_PRONE_JAVAC_VERSION = ""9+181-r4173-1"";
++    private static final String ASSERTJ_ERROR_PRONE_VERSION = ""0.2.1"";
+     private static final String PROP_ERROR_PRONE_APPLY = ""errorProneApply"";
+     private static final String PROP_REFASTER_APPLY = ""refasterApply"";
+     private static final String DISABLE_PROPERY = ""com.palantir.baseline-error-prone.disable"";",we should discuss how to not hard-code this version
+6247,"@@ -5,8 +5,14 @@ const isResumableError = require('./error').isResumableError;
+ const MongoError = require('./core').MongoError;
+ const ReadConcern = require('./read_concern');
+ const MongoDBNamespace = require('./utils').MongoDBNamespace;
++const Cursor = require('./cursor');
++const relayEvents = require('./core/utils').relayEvents;
++const maxWireVersion = require('./core/utils').maxWireVersion;
+
+-var cursorOptionNames = ['maxAwaitTimeMS', 'collation', 'readPreference'];
++const CHANGE_STREAM_OPTIONS = ['resumeAfter', 'startAfter', 'startAtOperationTime', 'fullDocument'];
++const CURSOR_OPTIONS = ['batchSize', 'maxAwaitTimeMS', 'collation', 'readPreference'].concat(
++  CHANGE_STREAM_OPTIONS
++);
+
+ const CHANGE_DOMAIN_TYPES = {
+   COLLECTION: Symbol('Collection'),",do we have a doclet for this event?
+6248,"@@ -35,10 +35,11 @@ if (isNodeProcess && process.platform === 'win32') {
+ }
+
+ // catching segfaults during testing can help debugging
+-if (isNodeProcess) {
+-    const SegfaultHandler = node_require('segfault-handler');
+-    SegfaultHandler.registerHandler(""crash.log"");
+-}
++//uncomment to enable segfault handler
++//if (isNodeProcess) {
++    //const SegfaultHandler = node_require('segfault-handler');
++    //SegfaultHandler.registerHandler(""crash.log"");
++//}
+
+ var TESTS = {
+     ListTests: require('./list-tests'),",Why don't we want to catch segfaults by default?
+6249,"@@ -137,6 +137,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+             return result;
+         }
+
++        [System.Diagnostics.CodeAnalysis.SuppressMessage(""Reliability"", ""CA2000:Dispose objects before losing scope"", Justification = ""The object should not be disposed"")]
+         private Task SendBatchActivityAsync(IEnumerable<Activity> batchActivity, CancellationToken cancellationToken)
+         {
+             var requestUri = this.options.Endpoint;",You could probably dispose request & content if you `await` the SendAsync.
+6250,"@@ -35,6 +35,16 @@ class UtilsTest(ReusedSQLTestCase, SQLTestUtils):
+         }, index=[0, 1, 3])
+         validate_arguments_and_invoke_function(pdf, self.to_html, pd.DataFrame.to_html, args)
+
++    def to_clipboard(self, sep=',', **kwargs):
++        args = locals()
++
++        pdf = pd.DataFrame({
++            'a': [1, 2, 3],
++            'b': [4, 5, 6],
++        }, index=[0, 1, 3])
++        validate_arguments_and_invoke_function(pdf, self.to_clipboard,
++                                               pd.DataFrame.to_clipboard, args)
++
+     def test_validate_arguments_and_invoke_function(self):
+         # This should pass and run fine
+         self.to_html()",why is this test case here? this file is for testing functionalities in utils.py
+6251,"@@ -31,6 +31,15 @@ class AuthController < ApplicationController
+   def do_user_auth(auth)
+     sign_out
+     user = User.from_oauth_hash(auth)
++    unless ENV[""NO_WELCOME_EMAIL""]
++      send_welcome_mail(user)
++    end
+     sign_in(user)
+   end
++
++  def send_welcome_mail(user)
++    if (Time.current - user.created_at) < 2.seconds
++      WelcomeMailer.welcome_notification(user).deliver_later
++    end
++  end
+ end",why do we have an env var for this? not sure why we'd want to suppress welcome emails but not any others
+6252,"@@ -917,7 +917,13 @@ func (p *parser) parseStringExpression() *ast.StringExpression {
+ 			}
+ 		default:
+ 			// TODO bad expression
+-			return nil
++			loc := p.loc(pos, pos+token.Pos(len(lit)))
++			p.errs = append(p.errs, ast.Error{
++				Msg: fmt.Sprintf(""got unexpected token in string expression %s@%d:%d-%d:%d: %s"", loc.File, loc.Start.Line, loc.Start.Column, loc.End.Line, loc.End.Column, tok),
++			})
++			return &ast.StringExpression{
++				BaseNode: p.position(beg, pos+token.Pos(len(lit))),
++			}
+ 		}
+ 	}
+ }",drop the todo?
+6253,"@@ -383,7 +383,9 @@ void Doors::HandleClick(Client* sender, uint8 trigger) {
+ 	if (!IsDoorOpen() || (open_type == 58)) {
+ 		if (!disable_timer)
+ 			close_timer.Start();
+-		SetOpenState(true);
++
++		if(strncmp(destination_zone_name, ""NONE"", strlen(""NONE"")) == 0)
++			SetOpenState(true);
+ 	} else {
+ 		close_timer.Disable();
+ 		if (!disable_timer)",Maybe use { } here like we are most other places now.
+6254,"@@ -96,6 +96,7 @@ class PartitionData
+     return schema;
+   }
+
++  @Override
+   public Type getType(int pos) {
+     return partitionType.fields().get(pos).type();
+   }","I want to get PartitionData field type, I don't know how to get it in other way."
+6255,"@@ -31,6 +31,9 @@ type Balances interface {
+ 	// A non-nil error means the lookup is impossible (e.g., if the database doesn't have necessary state anymore)
+ 	Get(addr basics.Address, withPendingRewards bool) (basics.AccountData, error)
+
++	// GetEx is like Get(addr, false), but also loads specific creatable
++	GetEx(addr basics.Address, cidx basics.CreatableIndex, ctype basics.CreatableType) (basics.AccountData, error)
++
+ 	Put(basics.Address, basics.AccountData) error
+
+ 	// PutWithCreatable is like Put, but should be used when creating or deleting an asset or application.","I think that a single `Get` method would be preferable, that would have the following parameters: Get(addr basics.Address, withPendingRewards bool, cidx basics.CreatableIndex, ctype basics.CreatableType) where we ignore cidx of -1, and adding support for ctype of ""AssetParams"" or something like that. (i.e. so that this Get call would be good for asset holding/asset params and applications )"
+6256,"@@ -1653,7 +1653,7 @@ char * ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int &err,
+                   // for non-varchar, length of zero indicates a null value.
+                   // For all datatypes, HIVE_DEFAULT_NULL_STRING('\N') indicates a null value.
+                   if (((len == 0) && (tgtAttr && (NOT DFS2REC::isSQLVarChar(tgtAttr->getDatatype())))) ||
+-                      ((len > 0) && (memcmp(sourceData, HIVE_DEFAULT_NULL_STRING, len) == 0)))
++                      ((len > 1) && (memcmp(sourceData, HIVE_DEFAULT_NULL_STRING, len) == 0)))
+                     {
+                       *(short *)&hdfsAsciiSourceData_[attr->getNullIndOffset()] = -1;
+                     }","This can handle the '\\' problem, but if (not possible) the user define '\\' as null, this logic will break. So here, it should be to compare the whole HIVE_DEFAULT_NULL_STRING, and make sure length is equal, as I understand. \N is NULL, but \NA is not NULL, what will happen if there is \NAA ?"
+6257,"@@ -0,0 +1,9 @@
++class ObservationPolicy
++  include ExceptionPolicy
++
++  def can_destroy!
++    role = Role.new(@user, @record.proposal)
++    check(@user.id == @record.user_id || role.client_admin? || @user.admin?,
++          ""Only the observer can delete themself"")
++  end
++end","Hmm, I would think that anyone who can edit the request should be able to delete the observation, in case they accidentally add the wrong person or something."
+6258,"@@ -4,13 +4,9 @@ class PublicPagesController < ApplicationController
+   # GET template_index
+   # -----------------------------------------------------
+   def template_index
+-    template_ids = Template.where(org_id: Org.funder.pluck(:id), visibility: Template.visibilities[:publicly_visible]).valid.pluck(:dmptemplate_id).uniq << Template.where(is_default: true, published: true).pluck(:dmptemplate_id)
+-    @templates = []
+-    template_ids.flatten.each do |tid|
+-      t = Template.live(tid)
+-      @templates << t unless t.nil?
+-    end
+-    @templates = @templates.sort{|x,y| x.title <=> y.title } if @templates.count > 1
++    template_ids = Template.families(Org.funder.pluck(:id)).publicly_visible.pluck(:dmptemplate_id) <<
++    Template.where(is_default: true).valid.published.pluck(:dmptemplate_id)
++    @templates = Template.includes(:org).where(dmptemplate_id: template_ids.uniq.flatten).valid.published.order(title: :asc).page(1)
+   end
+
+   # GET template_export/:id",I know we are doing this other places already. It would be good to refactor this and the paginable publicly_visible so that we are DRY. Can wait until after MVP though when we do general cleanup
+6259,"@@ -576,7 +576,12 @@ update_lookuptable_tls(dcontext_t *dcontext, ibl_table_t *table)
+      * crashing or worse.
+      */
+     state->table_space.table[table->branch_type].lookuptable = table->table;
+-    state->table_space.table[table->branch_type].hash_mask = table->hash_mask;
++    /* Perform a Store-Release, which when combined with a Load-Acquire of the mask
++     * in the IBL itself, ensures the prior store to lookuptable is never
++     * observed before this store to hash_mask on weakly ordered arches.
++     */
++    ATOMIC_PTRSZ_ALIGNED_WRITE(&state->table_space.table[table->branch_type].hash_mask,
++                               table->hash_mask, false);
+ }
+
+ #ifdef DEBUG","I think this should read ""is always observed before"" or ""is never observed after""."
+6260,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright 2002-2020 the original author or authors.
++ * Copyright 2002-2021 the original author or authors.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.",You might consider adding yourself as an author of the class.
+6261,"@@ -1065,7 +1065,8 @@ int ACTIVE_TASK::start(bool test) {
+
+         // hook up stderr to a specially-named file
+         //
+-        (void) freopen(STDERR_FILE, ""a"", stderr);
++        if (freopen(STDERR_FILE, ""a"", stderr) == NULL) {
++        }
+
+         // lower our priority if needed
+         //","If this fails, then 'stderr' is not a valid file handler anymore, and then any further 'write' operations will fail. Maybe some handling of such situation should be added here?"
+6262,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.
+6263,"@@ -262,8 +262,8 @@ class DHCPOptionsField(StrField):
+                 s += chr(len(oval))
+                 s += oval
+
+-            elif (type(o) is str and DHCPRevOptions.has_key(o) and
+-                  DHCPRevOptions[o][1] == None):
++            elif (type(o) is str and DHCPRevOptions.has_key(o) and
++                          DHCPRevOptions[o][1] is None):
+                 s += chr(DHCPRevOptions[o][0])
+             elif type(o) is int:
+                 s += chr(o)+""\0""",I think your indentation is wrong here.
+6264,"@@ -63,7 +63,9 @@ type L3RouteResolver struct {
+ 	blockToRoutes          map[string]set.Set
+ 	allPools               map[string]model.IPPool
+ 	workloadIDToCIDRs      map[model.WorkloadEndpointKey][]cnet.IPNet
++	nodeToCIDRs            map[string]set.Set
+ 	useNodeResourceUpdates bool
++	routeSource            string
+ }
+
+ type l3rrNodeInfo struct {","UT spotted that we weren't marking routes dirty when they targeted at Node and that node's IP changed. e.g., the case where a WEP appears in the syncer before the corresponding node does, so we don't know the node's IP. I added a new map to track the CIDRs for each node so that when the node IP changes we can mark those CIDRs dirty. Right now it's only used for the ""WorkloadIPs"" scenario. Need to decide if the same issue applies in the ""CalicoIPAM' case. I suspect it might. It looks like we have some logic present to detect when our own node IP changes, but we don't seem to handle when a remote node's IP changes."
+6265,"@@ -390,6 +390,14 @@ HELP
+     def execute(options)
+       if options[:mode] == 'plan' || options[:mode] == 'task'
+         begin
++          if Gem.win_platform?
++            # Windows 'fix' for openssl behaving strangely. Prevents very slow operation
++            # of random_bytes later when establishing winrm connections from a Windows host.
++            # See https://github.com/rails/rails/issues/25805 for background.
++            require 'openssl'
++            OpenSSL::Random.random_bytes(1)
++          end
++
+           require_relative '../../vendored/require_vendored'
+         rescue LoadError
+           raise Bolt::CLIError, ""Puppet must be installed to execute tasks""","Given this will 'pause' bolt for a few seconds on older rubies, perhaps emit a debug message saying ""Warming up OpenSSL"" or something to that effect"
+6266,"@@ -85,6 +85,11 @@ class Package(object):
+         self._package = package
+         self._pkg_dir = pkg_dir
+         self._path = path
++        self._format = None
++
++    def set_format(self, pkgformat):
++        """"""Set the format. Only used when building a new package.""""""
++        self._format = pkgformat
+
+     def file(self, hash_list):
+         """"""","Initializing _format to None, but asserting that it's not None later, seems unnecessarily fragile. We shouldn't architect the package class to rely on classes or methods that use it (e.g., build). Let's at least set the format to the default in case we don't create all packages through build.py."
+6267,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",This change should also probably go into the corresponding method of the abstract By class?
+6268,"@@ -0,0 +1,8 @@
++<?php
++namespace Psalm\Issue;
++
++class UnresolvableConstant extends CodeIssue
++{
++    public const ERROR_LEVEL = -1;
++    public const SHORTCODE = 303;
++}",Should this be set to something else?
+6269,"@@ -0,0 +1 @@
++Hi","Whats up with this? It looks like this is rendered on purchases/new for subscribers, so it would result in a dead end?"
+6270,"@@ -1326,13 +1326,13 @@ class StoreOptions(object):
+         return specs
+
+     @classmethod
+-    def propagate_ids(cls, obj, match_id, new_id, applied_keys):
++    def propagate_ids(cls, obj, match_id, new_id, applied_keys, backend=None):
+         """"""
+         Recursively propagate an id through an object for components
+         matching the applied_keys. This method can only be called if
+         there is a tree with a matching id in Store.custom_options
+         """"""
+-        if not new_id in Store.custom_options():
++        if not new_id in Store.custom_options(backend=backend):
+             raise AssertionError(""The set_ids method requires ""
+                                  ""Store.custom_options to contain""
+                                  "" a tree with id %d"" % new_id)",Glad to see this generalized to support the backend argument.
+6271,"@@ -1781,3 +1781,11 @@ func (a *WebAPI) GetInsightApplicationCount(ctx context.Context, req *webservice
+ 		UpdatedAt: c.UpdatedAt,
+ 	}, nil
+ }
++
++func (a *WebAPI) ListDeploymentChains(ctx context.Context, req *webservice.ListDeploymentChainsRequest) (*webservice.ListDeploymentChainsResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""not yet implemented"")
++}
++
++func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDeploymentChainRequest) (*webservice.GetDeploymentChainResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""not yet implemented"")
++}",`ctx` is unused in ListDeploymentChains
+6272,"@@ -154,7 +154,7 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ func (e *Executor) getMentionedAccounts(ctx context.Context, event model.NotificationEventType) ([]string, error) {
+ 	ds, err := e.TargetDSP.GetReadOnly(ctx, e.LogPersister)
+ 	if err != nil {
+-		return nil, fmt.Errorf(""failed to prepare running deploy source data: %w"", err)
++		return nil, fmt.Errorf(""failed to prepare running deploy source data: (%w)"", err)
+ 	}
+
+ 	if ds.GenericDeploymentConfig.DeploymentNotification == nil {","I'd say the format like `""xxx: %w""` is more convention when wrapping an error basically. You refered to anything like this?"
+6273,"@@ -65,7 +65,7 @@ const (
+ 	endpoint            = ""https://127.0.0.1:2379""
+ 	testTimeout         = time.Second * 10
+ 	manageTickerTime    = time.Second * 15
+-	learnerMaxStallTime = time.Minute * 1
++	learnerMaxStallTime = time.Minute * 5
+
+ 	// defaultDialTimeout is intentionally short so that connections timeout within the testTimeout defined above
+ 	defaultDialTimeout = 2 * time.Second","This seems relatively high, is it the recommended value from the etcd folks? Or is this debugging cruft?"
+6274,"@@ -10,11 +10,11 @@ import (
+ 	""google.golang.org/grpc/status""
+ )
+
+-type peerTrackerAttestor struct {
++type PeerTrackerAttestor struct {
+ 	Attestor attestor.Attestor
+ }
+
+-func (a peerTrackerAttestor) Attest(ctx context.Context) ([]*common.Selector, error) {
++func (a PeerTrackerAttestor) Attest(ctx context.Context) ([]*common.Selector, error) {
+ 	watcher, ok := peertracker.WatcherFromContext(ctx)
+ 	if !ok {
+ 		return nil, status.Error(codes.Internal, ""peer tracker watcher missing from context"")","This requires updating the name in the `endpoints` tests, please run `make test`."
+6275,"@@ -37,6 +37,10 @@ std::vector<HostAddr> toHosts(const std::string& peersStr) {
+
+ int main(int argc, char *argv[]) {
+     folly::init(&argc, &argv, true);
++    if (FLAGS_data_path.empty()) {
++        LOG(FATAL) << ""Meta Data Path should not empty"";
++        return EXIT_FAILURE;
++    }
+
+     LOG(INFO) << ""Starting Meta HTTP Service"";
+     nebula::WebService::registerHandler(""/meta"", [] {","LOG(FATAL) means coredump, LOG(ERROR) is better here."
+6276,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change."
+6277,"@@ -375,6 +375,12 @@ func UnmarshalService(in []byte) (interface{}, error) {
+ 			m.BackendServiceConfig.Image.HealthCheck.applyIfNotSet(newDefaultContainerHealthCheck())
+ 		}
+ 		return m, nil
++	case ScheduledJobType:
++		m := newDefaultScheduledJob()
++		if err := yaml.Unmarshal(in, m); err != nil {
++			return nil, fmt.Errorf(""unmarshal to scheduled job: %w"", err)
++		}
++		return m, nil
+ 	default:
+ 		return nil, &ErrInvalidSvcManifestType{Type: typeVal}
+ 	}",It's a bit weird to have `svc.go` to include a `ScheduledJobType`...should we rename this file?
+6278,"@@ -55,7 +55,7 @@ const licenseHeaderPrefix = ""// The MIT License (MIT)""
+
+ var (
+ 	// directories to be excluded
+-	dirBlacklist = []string{""vendor/""}
++	dirBlacklist = []string{""tpb/""}
+ 	// default perms for the newly created files
+ 	defaultFilePerms = os.FileMode(0644)
+ )","For some reason `protoc` doesn't copy license header from `proto` files to generated code. But this code will never be checked in, so it is ok."
+6279,"@@ -898,7 +898,7 @@ public class DatabaseHelper extends OrmLiteSqliteOpenHelper {
+                 PreparedQuery<TemporaryBasal> preparedQuery2 = queryBuilder2.prepare();
+                 List<TemporaryBasal> trList2 = getDaoTemporaryBasal().query(preparedQuery2);
+
+-                if (trList2.size() > 0) {
++                if (trList2.size() > 0 && trList2.get(0).pumpId == 0) { // don't update existing record if it has a pumpId
+                     old = trList2.get(0);
+
+                     old.copyFromPump(tempBasal);","I don't know what the implications of this change are for pumps other than the insight but i would add `|| trList2.get(0).pumpId == temporaryBasal.pumpId` in case we see the same pump event again, in order to not duplicate it in the database."
+6280,"@@ -29,8 +29,8 @@ type (
+ 	Address crypto.Digest
+ )
+
+-// ChecksumAddress is a representation of the short address with a checksum
+-type ChecksumAddress struct {
++// checksumAddress is a representation of the short address with a checksum
++type checksumAddress struct {
+ 	shortAddress Address
+ 	checksum     []byte
+ }",is there anything still referencing `checksumAddress` or can we just delete it?
+6281,"@@ -18,6 +18,7 @@ var (
+ 	// ClusterDeployment conditions that could indicate provisioning problems with a cluster
+ 	// First condition appearing True will be used in the metric labels.
+ 	provisioningDelayCondition = [...]hivev1.ClusterDeploymentConditionType{
++		hivev1.RequirementsMetCondition,
+ 		hivev1.DNSNotReadyCondition,
+ 		hivev1.InstallLaunchErrorCondition,
+ 		hivev1.ProvisionFailedCondition,","The reason I didn't suggest it before is because I didn't want alerts for every tried - but not updated provision, but I can see a value in it from OSD perspective"
+6282,"@@ -2,8 +2,10 @@ if Rails.env.production? || Rails.env.staging?
+   require 'rack/rewrite'
+
+   Rails.configuration.middleware.insert_before(Rack::Runtime, Rack::Rewrite) do
+-    r301 %r{.*}, ""http://#{HOST}$&"", if: Proc.new { |rack_env|
+-      rack_env['SERVER_NAME'] != ""#{HOST}""
+-    }
++    r301(
++      %r{.*},
++      ""http://#{ENV['APP_DOMAIN']}$&"",
++      if: proc { |rack_env| rack_env['SERVER_NAME'] != ""#{ENV['APP_DOMAIN']}"" }
++    )
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+6283,"@@ -61,8 +61,12 @@ func GroupActions(actions []*Action) (beforeGets, getList, writeList, afterGets
+ 	agets := map[interface{}]*Action{}
+ 	cgets := map[interface{}]*Action{}
+ 	writes := map[interface{}]*Action{}
++	var nilkeys []*Action
+ 	for _, a := range actions {
+-		if a.Kind == Get {
++		if a.Key == nil {
++			// Probably a Create.
++			nilkeys = append(nilkeys, a)
++		} else if a.Kind == Get {
+ 			// If there was a prior write with this key, make sure this get
+ 			// happens after the writes.
+ 			if _, ok := writes[a.Key]; ok {","I believe Key is not necessarily nil, it could be empty string. Probably better check a.Kind == Create"
+6284,"@@ -89,7 +89,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             }
+         }
+
+-        public Task WriteAsync<T>(Func<PipeWriter, T, long> callback, T state)
++        public Task WriteAsync<T>(Func<PipeWriter, T, long> callback, T state, CancellationToken cancellationToken)
+         {
+             lock (_contextLock)
+             {",This is only used for headers and therefore isn't used.
+6285,"@@ -15,11 +15,13 @@ import (
+
+ // ProviderCommand defines the shell command to be run for one of the commands (db pull, etc.)
+ type ProviderCommand struct {
+-	Command string `yaml:""command""`
+-	Service string `yaml:""service,omitempty""`
++	Command    string `yaml:""command""`
++	Service    string `yaml:""service,omitempty""`
++	SkipImport bool   `yaml:""skip_import""`
+ }
+
+ // ProviderInfo defines the provider
++// @todo: CodePullCommand unused
+ type ProviderInfo struct {
+ 	EnvironmentVariables map[string]string `yaml:""environment_variables""`
+ 	AuthCommand          ProviderCommand   `yaml:""auth_command""`","Wouldn't it make sense to add a files_import_command and a db_import_command, which could be empty? I guess that leads to potential backward-compatibility problems, but it's worth thinking about. Perhaps add an import-api version to solve that? Overall, I think the actual db import logic and files import logic should be moved into the yaml file. What you you think of that?"
+6286,"@@ -0,0 +1,15 @@
++// DO NOT EDIT: This file is autogenerated via the builtin command.
++
++package csv
++
++import ast ""github.com/influxdata/flux/ast""
++
++var FluxTestPackages = []*ast.Package{&ast.Package{
++	BaseNode: ast.BaseNode{
++		Errors: nil,
++		Loc:    nil,
++	},
++	Files:   []*ast.File{},
++	Package: ""csv_test"",
++	Path:    ""csv"",
++}}","Why do we have this here? I'm not concerned about it really, just curious."
+6287,"@@ -28,11 +28,11 @@ import (
+ type DeltaAction uint64
+
+ const (
+-	// SetBytesAction indicates that a TEAL byte slice should be stored at a key
+-	SetBytesAction DeltaAction = 1
+-
+ 	// SetUintAction indicates that a Uint should be stored at a key
+-	SetUintAction DeltaAction = 2
++	SetUintAction DeltaAction = 1
++
++	// SetBytesAction indicates that a TEAL byte slice should be stored at a key
++	SetBytesAction DeltaAction = 2
+
+ 	// DeleteAction indicates that the value for a particular key should be deleted
+ 	DeleteAction DeltaAction = 3",@justicz Why are these switched here?
+6288,"@@ -0,0 +1,7 @@
++describe 'GET /help' do
++  it ""displays successfully"" do
++    get '/help'
++    expect(response.status).to eq(200)
++    expect(response.body).to include('FAQ')
++  end
++end",Maybe verify that an anchor was created -- that the markdown was processed?
+6289,"@@ -64,7 +64,7 @@ public abstract class TwoPhaseIterator {
+
+     TwoPhaseIteratorAsDocIdSetIterator(TwoPhaseIterator twoPhaseIterator) {
+       this.twoPhaseIterator = twoPhaseIterator;
+-      this.approximation = twoPhaseIterator.approximation;
++      this.approximation = twoPhaseIterator.approximation();
+     }
+
+     @Override","Is this just a minor improvement or is it necessary? If just some minor improvement, I recommend you don't touch Lucene in a Solr PR."
+6290,"@@ -63,7 +63,4 @@ public interface ReadOnlyPDClient {
+
+   /** Close underlining resources */
+   void close() throws InterruptedException;
+-
+-  /** Get associated session * @return the session associated to client */
+-  TiSession getSession();
+ }",why delete this method?
+6291,"@@ -15,13 +15,17 @@
+ package com.google.api.codegen.transformer;
+
+ import com.google.api.codegen.config.MethodContext;
++import com.google.api.codegen.config.OutputContext;
+ import com.google.api.codegen.metacode.InitCodeNode;
+ import com.google.api.codegen.viewmodel.CallingForm;
+ import com.google.api.codegen.viewmodel.ImportSectionView;
+-import com.google.api.codegen.viewmodel.OutputView;
+ import java.util.Collections;
+-import java.util.List;
+
++/**
++ * An implementation of SampleImportTransformer. Subclasses of this class can choose to override
++ * `addSampleBodyImports`, `addOutputImports` and `addInitCodeImports` to save language-specific
++ * types to the type table. Currently used by Java.
++ */
+ public class StandardSampleImportTransformer implements SampleImportTransformer {
+
+   private final ImportSectionTransformer importSectionTransformer;","Does this transform only the `MethodContext`, or also the `OutputContext`? (Looking at the other files, I gather it's the latter.) Might be helpful to mention that here."
+6292,"@@ -1,15 +1,17 @@
+ # A part of NonVisual Desktop Access (NVDA)
+-# Copyright (C) 2009-2018 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala
++# Copyright (C) 2009-2020 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala
+ # This file may be used under the terms of the GNU General Public License, version 2 or later.
+ # For more details see: https://www.gnu.org/licenses/gpl-2.0.htmlimport appModuleHandler
+
+ import calendar
+ import collections
+ import time
+-
+ import api
+ import appModuleHandler
++from NVDAObjects.IAccessible import getNVDAObjectFromEvent
+ import ui
++import windowUtils
++import winUser
+
+ # A named tuple for holding the elapsed and total playing times from Foobar2000's status bar
+ statusBarTimes = collections.namedtuple('StatusBarTimes', ['elapsed', 'total'])",Could you please clean-up this line while at it?
+6293,"@@ -50,6 +50,11 @@ type PubSubSpec struct {
+ 	// This brings in CloudEventOverrides and Sink.
+ 	duckv1.SourceSpec `json:"",inline""`
+
++	// ServiceAccount is the GCP service account which has required permissions to poll from a Cloud Pub/Sub subscription.
++	// If not specified, defaults to use secret.
++	// +optional
++	ServiceAccount *string `json:""serviceAccount,omitempty""`
++
+ 	// Secret is the credential to use to poll from a Cloud Pub/Sub subscription.
+ 	// If not specified, defaults to:
+ 	// Name: google-cloud-key","no need to use a pointer. Just string and check for != """""
+6294,"@@ -133,7 +133,9 @@ public class RestServerVerticle extends AbstractVerticle {
+     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
+     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
+     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+-
++    if (endpointObject.isHttp2Enabled()) {
++      serverOptions.setUseAlpn(true);
++    }
+     if (endpointObject.isSslEnabled()) {
+       SSLOptionFactory factory =
+           SSLOptionFactory.createSSLOptionFactory(SSL_KEY, null);",this means h2 mode? but how h2c can work?
+6295,"@@ -1,9 +1,9 @@
+ # -*- coding: UTF-8 -*-
+-#appModules/explorer.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2019 NV Access Limited, Joseph Lee, Łukasz Golonka
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# appModules/explorer.py
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2006-2019 NV Access Limited, Joseph Lee, Łukasz Golonka, Julien Cochuyt
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+ """"""App module for Windows Explorer (aka Windows shell and renamed to File Explorer in Windows 8).
+ Provides workarounds for controls such as identifying Start button, notification area and others.",This line should not be there
+6296,"@@ -120,7 +120,12 @@ func (t *trie) Start(ctx context.Context) error {
+ 	return t.dao.Commit(t.cb)
+ }
+
+-func (t *trie) Stop(ctx context.Context) error { return t.lifecycle.OnStop(ctx) }
++func (t *trie) Stop(ctx context.Context) error {
++	t.mutex.Lock()
++	defer t.mutex.Unlock()
++
++	return t.lifecycle.OnStop(ctx)
++}
+
+ // TrieDB return the underlying DB instance
+ func (t *trie) TrieDB() db.KVStore {","why do we need lock here? if needed, then we also need to lock in Start()?"
+6297,"@@ -415,6 +415,8 @@ void ProtocolGame::parsePacket(NetworkMessage& msg)
+ 		}
+ 	}
+
++	addGameTask(&Game::playerExecuteParsePacketEvent, player->getID(), recvbyte, new NetworkMessage(msg));
++
+ 	switch (recvbyte) {
+ 		case 0x14: g_dispatcher.addTask(createTask(std::bind(&ProtocolGame::logout, getThis(), true, false))); break;
+ 		case 0x1D: addGameTask(&Game::playerReceivePingBack, player->getID()); break;","this should be on default-switch, uhm? else you will handle twice (c++ and lua). I'm just saying..."
+6298,"@@ -60,7 +60,7 @@ public class Program
+             // turn off the above default. i.e any
+             // instrument which does not match any views
+             // gets dropped.
+-            // .AddView(instrumentName: ""*"", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })
++            // .AddView(instrumentName: ""*"", MetricStreamConfiguration.Drop)
+             .AddConsoleExporter()
+             .Build();
+ ",unrelated minor fix
+6299,"@@ -19,6 +19,7 @@ module Travis
+         def setup
+           super
+           cmd ""nvm use #{config[:node_js]}""
++          cmd ""npm config set spin false"", echo: false
+           if npm_should_disable_strict_ssl?
+             cmd 'echo ""### Disabling strict SSL ###""'
+             cmd 'npm conf set strict-ssl false'","can you add `, echo: false` to the end of this as well. I don't think we need to echo this to the log. You might need to update the spec as well."
+6300,"@@ -88,6 +88,12 @@ class TestHeaders:
+         headers = Headers(Host=""foobarfoo.com"", Accept=""foo/bar"")
+         replacements = headers.replace(""foo"", ""bar"", count=1)
+         assert replacements == 1
++        assert headers[""Host""] == ""barbarfoo.com""
++        assert headers[""Accept""] == ""foo/bar""
++        replacements = headers.replace(""foo"", ""bar"", count=2)
++        assert replacements == 2
++        assert headers[""Host""] == ""barbarbar.com""
++        assert headers[""Accept""] == ""bar/bar""
+
+
+ def test_parse_content_type():","This test does not really verify that we're doing the correct thing now, is it? It seems to pass with and without the patch."
+6301,"@@ -16,7 +16,13 @@ const BlocksTopic = ""/fil/blocks""
+ const MessageTopic = ""/fil/msgs""
+
+ // AddNewBlock processes a block on the local chain and publishes it to the network.
+-func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) error {
++func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) (err error) {
++	ctx = log.Start(ctx, ""Node.AddNewBlock"")
++	log.SetTag(ctx, ""block"", b)
++	defer func() {
++		log.FinishWithErr(ctx, err)
++	}()
++
+ 	if _, err := node.ChainMgr.ProcessNewBlock(ctx, b); err != nil {
+ 		return err
+ 	}",should just be able to defer the call directly here too
+6302,"@@ -916,7 +916,7 @@ class LayoutPlot(GenericLayoutPlot, CompositePlot):
+
+         # Create title handle
+         if self.show_title and len(self.coords) > 1:
+-            title = self.handles['fig'].suptitle('', **self._fontsize('title'))
++            title = self.handles['fig'].suptitle('', y=1.05, **self._fontsize('title'))
+             self.handles['title'] = title
+
+         return layout_subplots, layout_axes, collapsed_layout",Is this a magic number? I assume this makes it look better.
+6303,"@@ -88,8 +88,8 @@ func (ob *Outbox) Send(ctx context.Context, from, to address.Address, value type
+ 			msgSendErrCt.Inc(ctx, 1)
+ 		}
+ 		ob.journal.Write(""Send"",
+-			""to"", to.String(), ""from"", from.String(), ""value"", value.AsBigInt().Uint64(), ""method"", method,
+-			""gasPrice"", gasPrice.AsBigInt().Uint64(), ""gasLimit"", uint64(gasLimit), ""bcast"", bcast,
++			""to"", to.String(), ""from"", from.String(), ""value"", value.Int.Uint64(), ""method"", method,
++			""gasPrice"", gasPrice.Int.Uint64(), ""gasLimit"", uint64(gasLimit), ""bcast"", bcast,
+ 			""params"", params, ""error"", err, ""cid"", out.String())
+ 	}()
+ ",Would welcome a stringification method on big.Int in specs-actors
+6304,"@@ -49,6 +49,8 @@ type (
+ 	WorkingSet interface {
+ 		// states and actions
+ 		RunActions(context.Context, uint64, []action.SealedEnvelope) (hash.Hash32B, map[hash.Hash32B]*action.Receipt, error)
++		RunAction(context.Context, action.SealedEnvelope) (*action.Receipt, error)
++		PersistBlockLevelInfo(blockHeight uint64) hash.Hash32B
+ 		Snapshot() int
+ 		Revert(int) error
+ 		Commit() error",PersistBlockLevelInfo -> UpdateBlockLevelInfo
+6305,"@@ -0,0 +1,10 @@
++_base_ = [
++    'retinanet_pvt_t_fpn_1x_coco.py',
++]
++model = dict(
++    backbone=dict(
++        num_layers=[3, 4, 6, 3],
++        init_cfg=dict(
++            type='Pretrained',
++            checkpoint='https://github.com/whai362/PVT/'
++            'releases/download/v2/pvt_small.pth')))",Type is redundant since it is inherited.
+6306,"@@ -94,6 +94,10 @@ public class TiTableInfo implements Serializable {
+     primaryKeyColumn = primaryKey;
+   }
+
++  public boolean isNotView() {
++    return this.viewInfo == null;
++  }
++
+   public boolean isView() {
+     return this.viewInfo != null;
+   }",better use `!isView()` so that we don't need to modify multiple lines in future.
+6307,"@@ -43,6 +43,12 @@ module RSpec
+
+   extend RSpec::Core::Warnings
+
++  class << self
++    # Setters for shared global objects
++    # @api private
++    attr_writer :configuration, :world
++  end
++
+   # Used to ensure examples get reloaded and user configuration gets reset to
+   # defaults between multiple runs in the same process.
+   #","I know you don't usually open up the singleton class, but I was getting a `private method called` error when trying to use `self.attr_writer` - any idea?"
+6308,"@@ -273,8 +273,13 @@ define(['apphost', 'globalize'], function (appHost, globalize) {
+         },
+
+         canRate: function (item) {
++            var itemType = item.Type;
++
++            if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel' || itemType === 'Season' || itemType === 'Studio') {
++                return false;
++            }
+
+-            if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel') {
++            if (!item.UserData) {
+                 return false;
+             }
+ ","There's no need to create a new variable here, the other checks just use the item type directly."
+6309,"@@ -19,6 +19,14 @@ class Product < ActiveRecord::Base
+     where product_type: 'book'
+   end
+
++  def self.workshops
++    where product_type: 'workshop'
++  end
++
++  def self.videos
++    where product_type: 'video'
++  end
++
+   def self.ordered
+     order(""name asc"")
+   end","Any other possible names? Feels like going with ""workshop"" for this product_type could increase the confusion between course/workshop in the codebase."
+6310,"@@ -114,7 +114,10 @@ const baseResolvers = {
+ 			return;
+ 		}
+
+-		yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );
++		const { error } = yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );
++		if ( error ) {
++			yield errorStoreActions.receiveError( error, 'getURLChannels', [ accountID, clientID ] );
++		}
+ 	},
+ };
+ ","@eugene-manuilov Isn't this already taken care of by `fetchGetURLChannels` via `createFetchStore`? Why is the extra `receiveError` call needed here? (This was already in the IB, but just struck me while reviewing here.)"
+6311,"@@ -22,6 +22,7 @@ import time
+
+ from concurrent import futures
+ import grpc
++import googlecloudprofiler
+
+ from google.cloud.forseti.common.util import logger
+ ",nit: should go before `grpc`?
+6312,"@@ -71,7 +71,7 @@ func init() {
+ }
+
+ func testWorkflow() *Workflow {
+-	ctx, cancel := context.WithCancel(context.Background())
++	cancel := make(chan struct{})
+ 	return &Workflow{
+ 		Name:          testWf,
+ 		GCSPath:       testGCSPath,","Why not using the Cancel? I thought cancelling a ""parent"" context would cascade to ""children"" contexts, cancelling them as well. In short, how does cancel work?"
+6313,"@@ -28,10 +28,12 @@ func (w *contentTypeOverridingResponseWriter) overrideMimeType(
+ 	// by the frontend WebView.
+ 	ty := strings.ToLower(mimeType)
+ 	switch {
+-	// First reject anything containing javascript/xml/html.
++	// First anything textual as text/plain.
++	// Includes javascript, html, xml. (note that the type may be e.g. application/xhtml+xml)
+ 	case strings.Contains(ty, ""javascript"") ||
+ 		strings.Contains(ty, ""xml"") ||
+-		strings.Contains(ty, ""html""):
++		strings.Contains(ty, ""html"") ||
++		strings.HasPrefix(ty, ""text/""):
+ 		return ""text/plain""
+ 	// Pass multimedia types through, and pdf too.
+ 	case strings.HasPrefix(ty, ""audio/"") ||","Could you explain why we default to binary now? It seems it's safer to default to text to avoid stuff getting executed or parsed by browsers accidentally. If we need to add support for particular types, we can add them explicitly right?"
+6314,"@@ -139,6 +139,8 @@ type Config struct {
+ 	MetadataAddr string `config:""hostname;127.0.0.1;die-on-fail""`
+ 	MetadataPort int    `config:""int(0,65535);8775;die-on-fail""`
+
++	OpenstackRegion string `config:""string;;local""`
++
+ 	InterfacePrefix  string `config:""iface-list;cali;non-zero,die-on-fail""`
+ 	InterfaceExclude string `config:""iface-list;kube-ipvs0""`
+ ","Bit worried about the prefix since this seem to be being used for non-Openstack data too (host endpoints). Should we just leave host endpoint status at the old path (or remove it since AIFAIK, it's not used anywhere)?"
+6315,"@@ -68,7 +68,7 @@ public class Timeline {
+
+     private static final Pattern TIMECODE_LINK_REGEX = Pattern.compile(""antennapod://timecode/((\\d+))"");
+     private static final String TIMECODE_LINK = ""<a class=\""timecode\"" href=\""antennapod://timecode/%d\"">%s</a>"";
+-    private static final Pattern TIMECODE_REGEX = Pattern.compile(""\\b(?:(?:(([0-9][0-9])):))?(([0-9][0-9])):(([0-9][0-9]))\\b"");
++    private static final Pattern TIMECODE_REGEX = Pattern.compile(""\\b(?:(?:([01]?\\d|2[0-3]):)?([0-5]?\\d):)?([0-5]?\\d)\\b"");
+     private static final Pattern LINE_BREAK_REGEX = Pattern.compile(""<br */?>"");
+
+ ","This might be a silly question, but what happens to files with durations > 24 hours?"
+6316,"@@ -92,7 +92,7 @@ namespace OpenTelemetry.Trace
+         /// <returns>Returns <see cref=""TracerProviderBuilder""/> for chaining.</returns>
+         internal static TracerProviderBuilder AddDiagnosticSourceInstrumentation<TInstrumentation>(
+             this TracerProviderBuilder tracerProviderBuilder,
+-            Func<ActivitySourceAdapter, TInstrumentation> instrumentationFactory)
++            Func<TInstrumentation> instrumentationFactory)
+             where TInstrumentation : class
+         {
+             if (instrumentationFactory == null)",`AddDiagnosticSourceInstrumentation` method can now be eliminated and simply use `AddInstrumentation`
+6317,"@@ -78,9 +78,9 @@ describe Bolt::Project do
+     describe ""with namespaced project names"" do
+       let(:config) { { 'name' => 'puppetlabs-foo' } }
+
+-      it ""strips namespace and hyphen"" do
+-        project = Bolt::Project.new(config, pwd)
+-        expect(project.name).to eq('foo')
++      it ""raises an error"" do
++        expect { Bolt::Project.new(config, pwd).validate }
++          .to raise_error(/Invalid project name 'puppetlabs-foo' in bolt-project.yaml/)
+       end
+     end
+   end",I think we also need to add `name:` to the bolt-project.yaml files in `spec/fixtures/projects`.
+6318,"@@ -3225,6 +3225,11 @@ func (fbo *folderBranchOps) getAndApplyMDUpdates(ctx context.Context,
+ 	return nil
+ }
+
++// getUnmergedMDUpdates returns a slice of the unmerged MDs for this
++// TLF's current unmerged branch and unmerged branch, between the
++// merge point for the branch and the current head.  The returned MDs
++// are the same instances that are stored in the MD cache, so they
++// should be modified with care.
+ func (fbo *folderBranchOps) getUnmergedMDUpdates(
+ 	ctx context.Context, lState *lockState) (
+ 	MetadataRevision, []*RootMetadata, error) {","worth mentioning the same warning here as in `md_util.go`, I think."
+6319,"@@ -134,8 +134,12 @@ func (p *Provisioner) GetNodeObjectFromHostName(hostName string) (*v1.Node, erro
+ 		Limit:         1,
+ 	}
+ 	nodeList, err := p.kubeClient.CoreV1().Nodes().List(listOptions)
+-	if err != nil {
+-		return nil, errors.Errorf(""Unable to get the Node with the NodeHostName"")
++	if err != nil || nodeList.Items == nil || len(nodeList.Items) == 0 {
++		// After the PV is created and node affinity is set
++		// based on kubernetes.io/hostname label, either:
++		// - hostname label changed on the node or
++		// - the node is deleted from the cluster.
++		return nil, errors.Errorf(""Unable to get the Node with the NodeHostName [%s]"", hostName)
+ 	}
+ 	return &nodeList.Items[0], nil
+ ","Do we need both the checks, for `Items` not nil and `len(Items)`"
+6320,"@@ -349,6 +349,14 @@ ActiveRecord::Schema.define(version: 20160927192531) do
+
+   add_index ""tags"", [""name""], name: ""index_tags_on_name"", unique: true, using: :btree
+
++  create_table ""test_client_requests"", force: :cascade do |t|
++    t.decimal  ""amount""
++    t.string   ""project_title""
++    t.integer  ""approving_official_id""
++    t.datetime ""created_at""
++    t.datetime ""updated_at""
++  end
++
+   create_table ""user_delegates"", force: :cascade do |t|
+     t.integer  ""assigner_id""
+     t.integer  ""assignee_id""",Do you know what this is coming from? It keeps getting deleted/created @nickbristow
+6321,"@@ -63,11 +63,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
+   public static final String ICEBERG_CATALOG_TYPE_HADOOP = ""hadoop"";
+   public static final String ICEBERG_CATALOG_TYPE_HIVE = ""hive"";
+
+-  public static final String HIVE_URI = ""uri"";
+-  public static final String HIVE_CLIENT_POOL_SIZE = ""clients"";
+   public static final String HIVE_CONF_DIR = ""hive-conf-dir"";
+-  public static final String WAREHOUSE_LOCATION = ""warehouse"";
+-
+   public static final String DEFAULT_DATABASE = ""default-database"";
+   public static final String BASE_NAMESPACE = ""base-namespace"";
+ ","Nit: leaving these in place would have reduce the number of files that this needed to touch, and avoided a possible problem removing public fields. I don't think it's worth blocking for this change, but we like to keep patches as small as possible by not breaking references like these."
+6322,"@@ -444,6 +444,7 @@ class AdminController extends Controller
+      */
+     protected function prePersistEntity($entity)
+     {
++        @trigger_error(sprintf('The %s is deprecated since EasyAdmin 1.x and will be removed in 2.0 veresion. Use persistEntity instead', __METHOD__), E_USER_DEPRECATED);
+     }
+
+     /**",`The %s is deprecated...` -> `The %s method is deprecated...`
+6323,"@@ -19,6 +19,9 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/encoding""
+ )
+
++// TODO: If this is gonna stay, it should move to specs-actors
++const BlockMessageLimit = 512
++
+ // Block is a block in the blockchain.
+ type Block struct {
+ 	// control field for encoding struct as an array","No, it wouldn't go there because that code won't reference or enforce it. Here is ok for now."
+6324,"@@ -127,7 +127,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client
+             }
+             catch (Exception exception)
+             {
+-                var completeArgs = new TestRunCompleteEventArgs(null, false, true, exception, new Collection<AttachmentSet>(), TimeSpan.Zero);
++                var completeArgs = new TestRunCompleteEventArgs(null, false, false, exception, new Collection<AttachmentSet>(), TimeSpan.Zero);
+                 eventHandler.HandleLogMessage(TestMessageLevel.Error, exception.Message);
+                 eventHandler.HandleTestRunComplete(completeArgs, null, null, null);
+             }",How will we show that test run aborted (because of a crash) if we don't set aborted to true?
+6325,"@@ -18,8 +18,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal
+ {
+     internal sealed class SocketConnection : TransportConnection
+     {
+-        private const int MinAllocBufferSize = 2048;
+-        public readonly static bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
++        private static readonly int MinAllocBufferSize = KestrelMemoryPool.MinimumSegmentSize / 2;
++        private static readonly bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
+
+         private readonly Socket _socket;
+         private readonly PipeScheduler _scheduler;",Nit: Might as well make this same change to AdaptedPipeline.
+6326,"@@ -42,12 +42,13 @@ public class IcebergTimestampWithZoneObjectInspector extends AbstractPrimitiveJa
+
+   @Override
+   public OffsetDateTime convert(Object o) {
+-    return o == null ? null : OffsetDateTime.ofInstant(((Timestamp) o).toInstant(), ZoneOffset.UTC);
++    return o == null ? null : OffsetDateTime.of(((Timestamp) o).toLocalDateTime(), ZoneOffset.UTC);
+   }
+
+   @Override
+   public Timestamp getPrimitiveJavaObject(Object o) {
+-    return o == null ? null : Timestamp.from(((OffsetDateTime) o).toInstant());
++    return o == null ? null :
++        Timestamp.valueOf(((OffsetDateTime) o).withOffsetSameInstant(ZoneOffset.UTC).toLocalDateTime());
+   }
+
+   @Override",Just to clarify: I see that only the hive2 withZone object inspector is changed. Does that mean that the predicate pushdown problem only occurred on hive2?
+6327,"@@ -11,7 +11,7 @@ module Bolt
+   class ModuleInstaller
+     class Specs
+       class ForgeSpec
+-        NAME_REGEX    = %r{\A[a-z][a-z0-9_]*[-/](?<name>[a-z][a-z0-9_]*)\z}.freeze
++        NAME_REGEX    = %r{\A[a-zA-Z0-9]+[-/](?<name>[a-z][a-z0-9_]*)\z}.freeze
+         REQUIRED_KEYS = Set.new(%w[name]).freeze
+         KNOWN_KEYS    = Set.new(%w[name version_requirement]).freeze
+ ",Based on username requirements for forge.puppet.com - only letters and digits permitted.
+6328,"@@ -73,11 +73,6 @@ public class StructLikeWrapper {
+       return false;
+     }
+
+-    int len = struct.size();
+-    if (len != that.struct.size()) {
+-      return false;
+-    }
+-
+     return comparator.compare(this.struct, that.struct) == 0;
+   }
+ ",Was this removed to ignore the extra columns coming from the file projection?
+6329,"@@ -1,3 +1,5 @@
++// +build !windows
++
+ // Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");","Please can you pull out the shared function into a shared file? I think that'd be pretty easy to do for this module. I think you could: - pull out a function `configureSyslog` that is implemented on Linux, but stubbed on Windows - pull out a function `openLogFile` that is implemented differently on each - share everything else"
+6330,"@@ -26,6 +26,6 @@ public class NotificationServiceFactoryImpl implements NotificationServiceFactor
+
+     @Override
+     public NotificationService create() {
+-        return new EmailNotificationService();
++        return new EmailNotificationService(new AWSEmailProvider());
+     }
+ }","Instead of hardcoding the AWSEmailProvider here, it should come from properties, so that it can be replaced with another EmailProvider for ZMS vs ZTS"
+6331,"@@ -0,0 +1,10 @@
++require_relative '../config/environment'
++
++login = ARGV[0] || :admin_user
++password = ARGV[1] || :admin_password
++email = ARGV[2] || 'admin@example.com'
++
++account = Account.create!(login: login, level: 10, activated_at: Time.current,
++                          email: email, email_confirmation: email,
++                          password: password, password_confirmation: password)
++ManualVerification.create!(account: account, auth_id: account.login)",+1 for creating this script to help people get boot strapped
+6332,"@@ -7,6 +7,7 @@ export const ASYNC_RENDER = 3;
+
+
+ export const ATTR_KEY = '__preactattr_';
++export const ELT_KEY_PREFIX = 'preact-';
+
+ // DOM properties that should NOT have ""px"" added when numeric
+ export const IS_NON_DIMENSIONAL = /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i;",Do you need the prefix?
+6333,"@@ -10558,7 +10558,12 @@ short CmpSeabaseDDL::unregisterNativeTable
+      objectNamePart.data(),
+      objType
+      );
+-
++
++  // drop comment text
++  retcode = deleteFromTextTable(&cliInterface,
++                                objUID,
++                                ComTextType::COM_OBJECT_COMMENT_TEXT,
++                                0);
+   return 0;
+ }
+ ","if retcode is < 0, it should return -1 indicating an error."
+6334,"@@ -1,5 +1,5 @@
+ """"""Emit a message for iteration through dict keys and subscripting dict with key.""""""
+-# pylint: disable=line-too-long,missing-docstring,unsubscriptable-object,too-few-public-methods,redefined-outer-name,use-dict-literal
++# pylint: disable=locally-disabled,useless-suppression,suppressed-message,line-too-long,missing-docstring,unsubscriptable-object,too-few-public-methods,redefined-outer-name,use-dict-literal,iterating-modified-dict
+
+ def bad():
+     a_dict = {1: 1, 2: 2, 3: 3}",Are those necessary? I feel like `useless-suppression` could be avoided here?
+6335,"@@ -309,13 +309,11 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
+             if (codecProfile.Type === 'Audio') {
+                 (codecProfile.Conditions || []).map(function (condition) {
+                     if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitDepth') {
+-                        maxAudioBitDepth = condition.Value;
+-                    }
+-                    if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
+-                        maxAudioSampleRate = condition.Value;
+-                    }
+-                    if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
+-                        maxAudioBitrate = condition.Value;
++                        return maxAudioBitDepth = condition.Value;
++                    } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
++                        return maxAudioSampleRate = condition.Value;
++                    } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
++                        return maxAudioBitrate = condition.Value;
+                     }
+                 });
+             }",Is this equivalent in JavaScript?
+6336,"@@ -16,8 +16,8 @@ void GetEdgeIndexProcessor::process(const cpp2::GetEdgeIndexReq& req) {
+   auto edgeIndexIDRet = getIndexID(spaceID, indexName);
+   if (!nebula::ok(edgeIndexIDRet)) {
+     auto retCode = nebula::error(edgeIndexIDRet);
+-    LOG(ERROR) << ""Get Edge Index SpaceID: "" << spaceID << "" Index Name: "" << indexName
+-               << "" failed, error: "" << apache::thrift::util::enumNameSafe(retCode);
++    LOG(INFO) << ""Get Edge Index SpaceID: "" << spaceID << "" Index Name: "" << indexName
++              << "" failed, error: "" << apache::thrift::util::enumNameSafe(retCode);
+     handleErrorCode(retCode);
+     onFinished();
+     return;","get/list operation is not schema change, it is supposed to use VLOG"
+6337,"@@ -92,7 +92,7 @@ namespace System.Diagnostics.Metrics
+             T delta,
+             params KeyValuePair<string, object?>[] tags)
+         {
+-            this.RecordMeasurement(delta, tags);
++            this.RecordMeasurement(delta, new ReadOnlySpan<KeyValuePair<string, object?>>(tags));
+         }
+     }
+ }","we'll need to delete this whole file, right?"
+6338,"@@ -41,6 +41,13 @@ public interface Table {
+
+   /**
+    * Refresh the current table metadata.
++   *
++   * <p>If this table is associated with a TransactionalCatalog, this refresh will be bounded by
++   * the visibility that the {@code IsolationLevel} of that transaction exposes. For example, if
++   * we are in a context of {@code READ_COMMITTED}, this refresh will update to the latest state
++   * of the table. However, in the case of {@code SERIALIZABLE} where this table hasn't mutated
++   * within this transaction, calling refresh will have no impact as the isolation level
++   * constrains all observations to within the transactional snapshot.
+    */
+   void refresh();
+ ","""this table hasn't mutated within this transaction"" may sound like implying that if this transaction contains table mutation changes, `refresh` may have impact, which I think is not true? I guess what you were saying was if other transactions committed to this table successfully when this transaction is half way through, refresh in this transaction will still return the same state as when this transaction begins."
+6339,"@@ -143,6 +143,18 @@ const (
+ 	VenafiPickupIDAnnotationKey = ""venafi.cert-manager.io/pickup-id""
+ )
+
++// TODO
++const (
++	// TODO
++	CertificateSigningRequestDurationAnnotationKey = ""cert-manager.io/request-duration""
++
++	// TODO
++	CertificateSigningRequestIsCAAnnotationKey = ""cert-manager.io/request-is-ca""
++
++	// TODO
++	CertificateSigningRequestCAAnnotationKey = ""cert-manager.io/ca""
++)
++
+ // KeyUsage specifies valid usage contexts for keys.
+ // See: https://tools.ietf.org/html/rfc5280#section-4.2.1.3
+ //      https://tools.ietf.org/html/rfc5280#section-4.2.1.12",Can we move these into some kind of experimental API group? I don't think we want to call them `v1` just yet :)
+6340,"@@ -31,6 +31,8 @@ class Section < ActiveRecord::Base
+   include ActsAsSortable
+   include VersionableModel
+
++  # Sort order: Number ASC
++  default_scope { order(number: :asc) }
+
+   # ================
+   # = Associations =",  I think this makes a lot of sense but we may want to highlight the change for people doing UAT in case the ordering of sections is off anywhere when customizing or using the drag-drop feature
+6341,"@@ -0,0 +1,4 @@
++var script = document.createElement('script')
++script.type = 'text/javascript'
++script.src = '{}'
++document.head.appendChild(script)",These files should in `/javascript/brython`
+6342,"@@ -265,7 +265,7 @@ runLoop:
+ 					continue
+ 				}
+ 				s.close(err)
+-				break runLoop
++				continue
+ 			}
+ 			// This is a bit unclean, but works properly, since the packet always
+ 			// begins with the public header and we never copy it.","I'm not sure this is the right fix - I'd be more happy with a `continue`. That way, we don't enter the code at the bottom of the run loop (e.g. sending packets). Keep in mind that this error here may be triggered by a peer doing something security-relevant, so I don't think we should do much more work other than sending the close frame."
+6343,"@@ -107,7 +107,11 @@ bool load_model::load_model_weights(const std::string& ckpt_dir,
+   closedir(weight_dir);
+
+   // load weights that appear in weight list.
+-  m->reload_weights(active_ckpt_dir, weight_list);
++  // load weights that appear in weight list.
++  // for(auto&& w : m_weights) {
++  //   w->load_from_save(latest,weight_list);
++  // }
++  //  m->reload_weights(active_ckpt_dir, weight_list);
+   return true;
+ }
+ ","Can we fix this, or is it going to stay broken."
+6344,"@@ -57,7 +57,6 @@ except Exception:
+
+ # to avoid copying:
+
+-@attr('postgres')
+ class CopyToTestDB(postgres.CopyToTable):
+     host = host
+     database = database",Is there a reason to remove this attr?
+6345,"@@ -0,0 +1,19 @@
++package config
++
++import (
++	""github.com/kubeedge/beehive/pkg/common/config""
++	""github.com/kubeedge/beehive/pkg/common/log""
++	""github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants""
++)
++
++// MessageLayer used, context or ssmq, default is context
++var MessageLayer string
++
++func init() {
++	if ml, err := config.CONFIG.GetValue(""devicecontroller.message-layer"").ToString(); err != nil {
++		MessageLayer = constants.DefaultMessageLayer
++	} else {
++		MessageLayer = ml
++	}
++	log.LOGGER.Infof(""message layer: %s"", MessageLayer)
++}",log message should be started with upper-case word.
+6346,"@@ -17,6 +17,9 @@ const (
+ 	// aim to create chunks of 20 bits or about 1MiB on average.
+ 	averageBits = 20
+
++	// default buffer size
++	bufSize = 512 * KiB
++
+ 	// MinSize is the minimal size of a chunk.
+ 	MinSize = 512 * KiB
+ 	// MaxSize is the maximal size of a chunk.",I guess this is not needed anymore now?
+6347,"@@ -24,7 +24,7 @@
+ #include ""h2o.h""
+
+ static ssize_t add_header(h2o_mem_pool_t *pool, h2o_headers_t *headers, h2o_iovec_t *name, const char *orig_name, const char *value,
+-                          size_t value_len, h2o_header_flags_t flags)
++                          size_t value_len)
+ {
+     h2o_header_t *slot;
+ ","I think I would prefer retaining the argument. It's true that we are not using it now, but it's harmless, it's good to have a constructor function that accepts all the field values as arguments. Performance-wise, it does not matter."
+6348,"@@ -836,8 +836,11 @@ Blockly.Gesture.prototype.duplicateOnDrag_ = function() {
+   try {
+     // Note: targetBlock_ should have no children.  If it has children we would
+     // need to update shadow block IDs to avoid problems in the VM.
++    // Resizes will be reenabled at the end of the drag.
++    this.startWorkspace_.setResizesEnabled(false);
+     var xmlBlock = Blockly.Xml.blockToDom(this.targetBlock_);
+     newBlock = Blockly.Xml.domToBlock(xmlBlock, this.startWorkspace_);
++
+     // Move the duplicate to original position.
+     var xy = this.targetBlock_.getRelativeToSurfaceXY();
+     newBlock.moveBy(xy.x, xy.y);",Is this a different fix?
+6349,"@@ -45,10 +45,12 @@ func (s *DaemonServer) SetDNSServer(ctx context.Context,
+ 		}
+
+ 		// backup the /etc/resolv.conf
+-		cmd := bpm.DefaultProcessBuilder(""sh"", ""-c"", fmt.Sprintf(""ls %s.chaos.bak || cp %s %s.chaos.bak"", DNSServerConfFile, DNSServerConfFile, DNSServerConfFile)).
+-			SetNS(pid, bpm.MountNS).
+-			SetContext(ctx).
+-			Build()
++		processBuilder := bpm.DefaultProcessBuilder(""sh"", ""-c"", fmt.Sprintf(""ls %s.chaos.bak || cp %s %s.chaos.bak"", DNSServerConfFile, DNSServerConfFile, DNSServerConfFile)).SetContext(ctx)
++		if !req.WithoutNS {
++			processBuilder = processBuilder.SetNS(pid, bpm.MountNS)
++		}
++
++		cmd := processBuilder.Build()
+ 		output, err := cmd.CombinedOutput()
+ 		if err != nil {
+ 			log.Error(err, ""execute command error"", ""command"", cmd.String(), ""output"", output)",Why not add a `EnterNS` filed instead of `WithoutNS`?
+6350,"@@ -27,6 +27,13 @@ import (
+ )
+
+ var _ = Describe(""Endpoints"", func() {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	for _, trueOrFalse := range []bool{true, false} {
+ 		kubeIPVSEnabled := trueOrFalse
+ 		var rrConfigNormalMangleReturn = Config{",Same points as in other test file.
+6351,"@@ -158,6 +158,16 @@ void SettingsStruct_tmpl<N_TASKS>::ApDontForceSetup(bool value) {
+   bitWrite(VariousBits1, 14, value);
+ }
+
++template<unsigned int N_TASKS>
++bool SettingsStruct_tmpl<N_TASKS>::JSONBoolWithQuotes() const {
++  return bitRead(VariousBits1, 15);
++}
++
++template<unsigned int N_TASKS>
++void SettingsStruct_tmpl<N_TASKS>::JSONBoolWithQuotes(bool value) {
++  bitWrite(VariousBits1, 15, value);
++}
++
+ template<unsigned int N_TASKS>
+ bool SettingsStruct_tmpl<N_TASKS>::CombineTaskValues_SingleEvent(taskIndex_t taskIndex) const {
+   if (validTaskIndex(taskIndex))","I have a PR pending, can you change this bit index to `16`?"
+6352,"@@ -310,11 +310,12 @@ public class JavaParserInterfaceDeclaration extends AbstractTypeDeclaration impl
+
+     private ResolvedReferenceType toReferenceType(ClassOrInterfaceType classOrInterfaceType) {
+         SymbolReference<? extends ResolvedTypeDeclaration> ref = null;
+-        if (classOrInterfaceType.toString().indexOf('.') > -1) {
+-            ref = typeSolver.tryToSolveType(classOrInterfaceType.toString());
++        String typeName = classOrInterfaceType.getNameAsString();
++        if (typeName.indexOf('.') > -1) {
++            ref = typeSolver.tryToSolveType(typeName);
+         }
+         if (ref == null || !ref.isSolved()) {
+-            ref = solveType(classOrInterfaceType.toString(), typeSolver);
++            ref = solveType(typeName, typeSolver);
+         }
+         if (!ref.isSolved()) {
+             ref = solveType(classOrInterfaceType.getName().getId(), typeSolver);",we should probably have some utility class for this sort of things
+6353,"@@ -1,4 +1,4 @@
+-#pylint: disable=missing-docstring, no-else-return, invalid-name, unused-variable, superfluous-parens
++#pylint: disable=missing-docstring, no-else-return, invalid-name, unused-variable, superfluous-parens, try-except-raise
+ """"""Testing inconsistent returns""""""
+ import math
+ import sys",Curious that I'm not seeing any occurrence of the new error check in this file. Why was it disabled?
+6354,"@@ -341,6 +341,13 @@ class Realm {
+      */
+     static deleteFile(config) { }
+
++    /**
++     * Checks if the Realm already exists on disk.
++     * @param {Realm~Configuration} config The configuration for the Realm.
++     * @throws {Error} if anything in the provided `config` is invalid.
++     */
++    static exists(config) { }
++
+     /**
+      * Copy all bundled Realm files to app's default file folder.
+      * This is only implemented for React Native.",does it return something?
+6355,"@@ -265,7 +265,7 @@ const withData = (
+
+ 			// If we have an error, display the DataErrorComponent.
+ 			if ( error ) {
+-				return ( 'string' !== typeof error ) ? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid );
++				return ( 'string' !== typeof error ) ? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid, data );
+ 			}
+
+ 			// If we have zeroData, display the NoDataComponent.","This function is also called in various Site Kit module components, where the error object (here `data`) also needs to be passed, otherwise the link to fix the issue won't appear."
+6356,"@@ -14,6 +14,8 @@ var log = logging.MustGetLogger(""scm"")
+
+ // An SCM represents an SCM implementation that we can ask for various things.
+ type SCM interface {
++	// DescribeIdentifier returns the string that is a ""human-readable"" identifier of the given revision.
++	DescribeIdentifier(sha string) string
+ 	// CurrentRevIdentifier returns the string that specifies what the current revision is.
+ 	CurrentRevIdentifier() string
+ 	// ChangesIn returns a list of modified files in the given diffSpec.",super nit: `revision string` (the passed value might not be a SHA hash).
+6357,"@@ -54,7 +54,7 @@ namespace NLog.Layouts
+         /// Is this layout initialized? See <see cref=""Initialize(NLog.Config.LoggingConfiguration)""/>
+         /// </summary>
+         internal bool IsInitialized;
+-        private bool _scannedForObjects;
++        internal bool _scannedForObjects;
+
+         /// <summary>
+         /// Gets a value indicating whether this layout is thread-agnostic (can be rendered on any thread).",@snakefoot why is internal needed?
+6358,"@@ -190,11 +190,14 @@ func (s *server) startService() common.Daemon {
+ 		}
+
+ 		params.PublicClient, err = sdkclient.NewClient(sdkclient.Options{
+-			HostPort:          s.cfg.PublicClient.HostPort,
+-			Namespace:         common.SystemLocalNamespace,
+-			MetricsScope:      params.MetricScope,
+-			Logger:            l.NewZapAdapter(zapLogger),
+-			ConnectionOptions: sdkclient.ConnectionOptions{TLS: options},
++			HostPort:     s.cfg.PublicClient.HostPort,
++			Namespace:    common.SystemLocalNamespace,
++			MetricsScope: params.MetricScope,
++			Logger:       l.NewZapAdapter(zapLogger),
++			ConnectionOptions: sdkclient.ConnectionOptions{
++				TLS:                options,
++				DisableHealthCheck: true,
++			},
+ 		})
+ 		if err != nil {
+ 			log.Fatalf(""failed to create public client: %v"", err)",Why were we disabling health checks before?
+6359,"@@ -22,7 +22,7 @@ def check_src_files_have_test():
+ def check_test_files_have_src():
+     unknown_test_files = []
+
+-    excluded = ['test/mitmproxy/data/', 'test/mitmproxy/net/data/', '/tservers.py']
++    excluded = ['test/mitmproxy/data/', 'test/mitmproxy/net/data/', '/tservers.py', '/conftest.py']
+     test_files = glob.glob('test/mitmproxy/**/*.py', recursive=True) + glob.glob('test/pathod/**/*.py', recursive=True)
+     test_files = [f for f in test_files if os.path.basename(f) != '__init__.py']
+     test_files = [f for f in test_files if not any(os.path.normpath(p) in f for p in excluded)]",did `conftest.py` actually show up for you? `test_files` should never contain it...
+6360,"@@ -561,7 +561,8 @@ StmtDDLDropSchema::StmtDDLDropSchema(//const SchemaName & schemaName,
+   // If the schema name specified is reserved name, users cannot drop them.
+   // They can only be dropped internally.
+   if ((! Get_SqlParser_Flags(INTERNAL_QUERY_FROM_EXEUTIL)) &&
+-      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())))
++      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())) &&
++      (!ComIsTrafodionExternalSchemaName(schemaQualName_.getSchemaName())))
+     {
+       // error.
+       *SqlParser_Diags << DgSqlCode(-1430)",Should this be a ! on line 565? I would have expected the condition to be similar to line 564. If I am wrong please excuse my mistake.
+6361,"@@ -288,6 +288,10 @@ class DBUpgrader {
+
+             db.execSQL(""DROP TABLE "" + PodDBAdapter.TABLE_NAME_FEED_IMAGES);
+         }
++        if (oldVersion < 1070296) {
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_VOLUME_REDUCTION + "" INTEGER DEFAULT 0"");
++        }
+     }
+
+ }",Please change to `1070400`. I promise to look into this PR in more detail before the 1.7.4 release ;)
+6362,"@@ -68,15 +68,15 @@ public class FlinkParquetWriters {
+     }
+
+     @Override
+-    public ParquetValueWriter<?> message(RowType sStruct, MessageType message, List<ParquetValueWriter<?>> fields) {
++    public ParquetValueWriter<?> message(LogicalType sStruct, MessageType message, List<ParquetValueWriter<?>> fields) {
+       return struct(sStruct, message.asGroupType(), fields);
+     }
+
+     @Override
+-    public ParquetValueWriter<?> struct(RowType sStruct, GroupType struct,
++    public ParquetValueWriter<?> struct(LogicalType fStruct, GroupType struct,
+                                         List<ParquetValueWriter<?>> fieldWriters) {
+       List<Type> fields = struct.getFields();
+-      List<RowField> flinkFields = sStruct.getFields();
++      List<RowField> flinkFields = ((RowType) fStruct).getFields();
+       List<ParquetValueWriter<?>> writers = Lists.newArrayListWithExpectedSize(fieldWriters.size());
+       List<LogicalType> flinkTypes = Lists.newArrayList();
+       for (int i = 0; i < fields.size(); i += 1) {",Can we change to use `LogicalType.getChildren`?
+6363,"@@ -1,10 +1,11 @@
+ require 'spec_helper'
+
+ describe '#create' do
+-  it 'sets the payment_method on Purchase to free' do
++  it 'sets the payment_method on Purchase to subscription' do
+     user = create(:user, :with_subscription)
+     create_subscriber_purchase(create(:book_product), user)
+-    user.purchases.last.payment_method.should == 'free'
++    user.purchases.last.payment_method.should eq 'free'
++    user.purchases.last[:payment_method].should eq 'subscription'
+   end
+
+   it 'sets the comments on the purchase if provided' do",I'm confused as to how these are both passing.
+6364,"@@ -0,0 +1,17 @@
++module DashboardsHelper
++  def learn_live_link(&block)
++    if current_user_has_access_to?(:office_hours)
++      link_to OfficeHours.url, target: ""_blank"", &block
++    else
++      content_tag ""a"", &block
++    end
++  end
++
++  def learn_repo_link(&block)
++    if current_user_has_access_to?(:source_code)
++      link_to ENV['LEARN_REPO_URL'], target: ""_blank"", &block
++    else
++      content_tag ""a"", &block
++    end
++  end
++end",Prefer single-quoted strings when you don't need string interpolation or special symbols.
+6365,"@@ -28,7 +28,7 @@ class CategoryData
+     public $seoH1s;
+
+     /**
+-     * @var string[]
++     * @var string[]|null[]
+      */
+     public $descriptions;
+ ","there is `""` sign in commit message and colon. can you rename also `descrition` to plural `descriptions` and add there `$` ?"
+6366,"@@ -108,7 +108,9 @@ func (ti *TelemetryInterceptor) Intercept(
+ 	resp, err := handler(ctx, req)
+
+ 	if val, ok := metrics.ContextCounterGet(ctx, metrics.HistoryWorkflowExecutionCacheLatency); ok {
+-		timerNoUserLatency.Subtract(time.Duration(val))
++		userLatencyDuration := time.Duration(val)
++		timerNoUserLatency.Subtract(userLatencyDuration)
++		metricsScope.RecordTimer(metrics.ServiceLatencyUserLatency, userLatencyDuration)
+ 	}
+
+ 	if err != nil {",timerNoUserLatency is not being used?
+6367,"@@ -603,6 +603,8 @@ class Serializer(object):
+         :param Date attr: Object to be serialized.
+         :rtype: str
+         """"""
++        if isinstance(attr, str):
++            attr = isodate.parse_date(attr)
+         t = ""{:04}-{:02}-{:02}"".format(attr.year, attr.month, attr.day)
+         return t
+ ","@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :) They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet. Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay."
+6368,"@@ -553,8 +553,8 @@ namespace pwiz.SkylineTest
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""15N\"" label_15N=\""true\"" />"", true, true, isotopeModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Heavy K\"" aminoacid=\""K\"" label_13C=\""true\"" label_15N=\""true\"" label_18O=\""true\""  label_2H=\""true\""/>"", true, true, isotopeModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Aqua\"" aminoacid=\""K, R\"" label_13C=\""true\"" label_15N=\""true\"" label_18O=\""true\""  label_2H=\""true\""/>"", true, true, isotopeModificationType);
+-            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss1\"" aminoacid=\""T, S\"" formula=\""HPO3\""><fragment_loss formula=\""HP3O4\""/></static_modification>"", true, true, isotopeModificationType);
+-            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss3\"" aminoacid=\""T, S\"" formula=\""HPO3\"" explicit_decl=\""true\""><fragment_loss formula=\""HP3O4\""/><fragment_loss formula=\""H2O\""/><fragment_loss formula=\""NH3\""/></static_modification>"", true, true, isotopeModificationType);
++            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss1\"" aminoacid=\""T, S\"" formula=\""HPO3\""><potential_loss formula=\""HP3O4\""/></static_modification>"", true, true, structuralModificationType);
++            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss3\"" aminoacid=\""T, S\"" formula=\""HPO3\"" explicit_decl=\""true\""><potential_loss formula=\""HP3O4\""/><potential_loss formula=\""H2O\""/><potential_loss formula=\""NH3\""/></static_modification>"", true, true, structuralModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss-only\"" aminoacid=\""K, R, Q, N\""><potential_loss formula=\""NH3\""/></static_modification>"", true, true, structuralModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""LossInclusion\"" aminoacid=\""T, S\"" formula=\""HPO3\""><potential_loss formula=\""HP3O4\"" inclusion=\""Always\""/><potential_loss formula=\""HP2O3\"" inclusion=\""Library\""/><potential_loss formula=\""HP1O2\"" inclusion=\""Never\""/></static_modification>"", true, true, structuralModificationType);
+ ",Why change the name in the XML?
+6369,"@@ -132,7 +132,11 @@ class User < ActiveRecord::Base
+   # = Callbacks =
+   # =============
+
+-  after_update :when_org_changes
++  before_update :clear_other_organisation, if: :org_id_changed?
++
++  after_update :delete_perms!, if: :org_id_changed?, unless: :can_change_org?
++
++  after_update :remove_token!, if: :org_id_changed?, unless: :can_change_org?
+
+   # =================
+   # = Class methods =",This is much cleaner. makes it easier to tell what happens on a save.
+6370,"@@ -212,6 +212,8 @@ func refineFiltersOperator(filters []datastore.ListFilter) ([]datastore.ListFilt
+ 			filter.Operator = ""IN""
+ 		case datastore.OperatorNotIn:
+ 			filter.Operator = ""NOT IN""
++		case datastore.OperatorContains:
++			// FIXME: Convert contains operator into one dedicated to MySQL
+ 		case datastore.OperatorNotEqual,
+ 			datastore.OperatorGreaterThan,
+ 			datastore.OperatorGreaterThanOrEqual,",Could you add return error unsupported operator here
+6371,"@@ -6,7 +6,8 @@
+ package javaslang.collection;
+
+ import javaslang.*;
+-import javaslang.collection.Stream.*;
++import javaslang.collection.Stream.Cons;
++import javaslang.collection.Stream.Empty;
+ import javaslang.collection.StreamModule.*;
+ import javaslang.control.Option;
+ ","(Mhh, we seem to use different formatters - we should unify them. I like the wildcards)"
+6372,"@@ -54,8 +54,11 @@ func AdminDescribeTaskQueue(c *cli.Context) {
+ 	ctx, cancel := newContext(c)
+ 	defer cancel()
+ 	request := &workflowservice.DescribeTaskQueueRequest{
+-		Namespace:              namespace,
+-		TaskQueue:              &taskqueuepb.TaskQueue{Name: taskQueue},
++		Namespace: namespace,
++		TaskQueue: &taskqueuepb.TaskQueue{
++			Name: taskQueue,
++			Kind: enumspb.TASK_QUEUE_KIND_NORMAL,
++		},
+ 		TaskQueueType:          tlType,
+ 		IncludeTaskQueueStatus: true,
+ 	}",Should `kind` be a command line parameter also?
+6373,"@@ -43,7 +43,7 @@ namespace Nethermind.JsonRpc.Data
+             Gas = transaction.GasLimit;
+             Input = Data = transaction.Data;
+             Type = transaction.Type;
+-            AccessList = TryGetAccessListItems();
++            AccessList = transaction.AccessList is null ? null : AccessListItemForRpc.FromAccessList(transaction.AccessList);
+
+             Signature? signature = transaction.Signature;
+             if (signature != null)",can we have it inside FromAccessList?
+6374,"@@ -64,6 +64,19 @@ var rawRequestPaths = map[string]bool{
+ 	""/v2/teal/compile"": true,
+ }
+
++// unauthorizedRequestError is generated when we receive 401 error from the server. This error includes the inner error
++// as well as the likely parameters that caused the issue.
++type unauthorizedRequestError struct {
++	errorString string
++	apiToken    string
++	url         string
++}
++
++// Error format an error string for the unauthorizedRequestError error.
++func (e unauthorizedRequestError) Error() string {
++	return fmt.Sprintf(""Unauthorized request to `%s` when using token `%s` : %s"", e.url, e.apiToken, e.errorString)
++}
++
+ // RestClient manages the REST interface for a calling user.
+ type RestClient struct {
+ 	serverURL       url.URL",Why not embed filterASCII in this function?
+6375,"@@ -1872,7 +1872,11 @@ public class ExecutorManager extends EventHandler implements
+           // process flow with current snapshot of activeExecutors
+           selectExecutorAndDispatchFlow(reference, exflow, new HashSet<Executor>(activeExecutors));
+         }
+-        currentContinuousFlowProcessed++;
++
++        // do not count failed flow processsing (flows still in queue)
++        if(queuedFlows.getFlow(exflow.getExecutionId()) == null) {
++          currentContinuousFlowProcessed++;
++        }
+       }
+     }
+ ","I am curious, shouldn't ""currentContinuousFlowProcessed++;"" be added right after line 1873? otherwise we will count 1 extra when a exflow wakes up from the sleep section,.even though it hasn't been assigned"
+6376,"@@ -162,6 +162,7 @@ def _get_configtypes():
+                                      configtypes._Numeric] and
+                            issubclass(e, configtypes.BaseType))
+     yield from inspect.getmembers(configtypes, predicate)
++    # pylint: enable=protected-access
+
+
+ def _get_setting_types_quickref():",You can probably move this up after the `._Numeric` line.
+6377,"@@ -203,6 +203,7 @@ class SGEJobTask(luigi.Task):
+         description=""don't tarball (and extract) the luigi project files"")
+
+     def __init__(self, *args, **kwargs):
++        super(SGEJobTask, self).__init__(*args, **kwargs)
+         if self.job_name:
+             # use explicitly provided job name
+             pass","@Tarrasch this is another change you need to pay attention, it seems `SGEJobTask` is not calling `super.__init__` which break the test case some how."
+6378,"@@ -0,0 +1,14 @@
++class CreateCompletions < ActiveRecord::Migration
++  def change
++    create_table :completions do |t|
++      t.string :trail_object_id
++      t.string :trail_name
++      t.belongs_to :user
++
++      t.timestamps
++    end
++
++    add_index :completions, :user_id
++    add_index :completions, :trail_object_id
++  end
++end",Do we need indices for this table?
+6379,"@@ -447,6 +447,19 @@ static int process_data(struct flb_http_client *c)
+     return FLB_HTTP_MORE;
+ }
+
++#if defined FLB_HAVE_TESTS_OSSFUZZ
++int fuzz_process_data(struct flb_http_client *c);
++int fuzz_process_data(struct flb_http_client *c) {
++	return process_data(c);
++}
++
++int fuzz_check_connection(struct flb_http_client *c);
++int fuzz_check_connection(struct flb_http_client *c) {
++    return check_connection(c);
++}
++
++#endif
++
+ static int proxy_parse(const char *proxy, struct flb_http_client *c)
+ {
+     int len;",what about making this function static inline to avoid the extra declaration ?
+6380,"@@ -21,6 +21,7 @@ import (
+
+ type protocol = string
+ type TableIDType uint8
++type GroupIDType = uint32
+
+ const LastTableID TableIDType = 0xff
+ ","I forget the difference between type definition with ""="" and without ""="" again, but can we unify the style? I believe the difference doesn't apply to TableIDType and GroupIDType whatever it is?"
+6381,"@@ -49,7 +49,7 @@ return_code parseArguments(int argc,
+         ""Number of threads to use"")(
+         ""core,k"",
+         boost::program_options::value<double>(&contractor_config.core_factor)->default_value(1.0),
+-        ""Percentage of the graph (in vertices) to contract [0..1]"")(
++        ""Percentage of the graph (in vertices) to contract [0..1]. Will always be 1.0"")(
+         ""segment-speed-file"",
+         boost::program_options::value<std::vector<std::string>>(
+             &contractor_config.updater_config.segment_speed_lookup_paths)",would be `DEPRECATED Percentage of the graph (in vertices) to contract [0..1]` better?
+6382,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";
++  String STOP_CASTING = ""stopCasting"";
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`
+6383,"@@ -108,7 +108,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+             }
+
+             string serviceName = null;
+-            Dictionary<string, object> tags = null;
++            Dictionary<string, object> tags = new Dictionary<string, object>();
+             foreach (var label in resource.Attributes)
+             {
+                 string key = label.Key;","if we won't use, should we remove this?"
+6384,"@@ -230,7 +230,10 @@ namespace MvvmCross.Platforms.Android.Core
+
+         protected virtual IDictionary<string, string> ViewNamespaceAbbreviations => new Dictionary<string, string>
+         {
+-            { ""Mvx"", ""MvvmCross.Platforms.Android.Views"" }
++            { ""Mvx"", ""mvvmcross.platforms.android.views""
++            },
++            { ""Mvx"", ""mvvmcross.platforms.android.binding.views""
++            }
+         };
+
+         protected virtual IEnumerable<string> ViewNamespaces => new List<string>",Having 2 items with the same key (Mvx) won't work in a dictionary
+6385,"@@ -0,0 +1,17 @@
++class CouponsController < ApplicationController
++  def show
++    if coupon.valid?
++      session[:coupon] = coupon.code
++    else
++      flash[:notice] = ""The coupon code you supplied is not valid.""
++    end
++
++    redirect_to root_path
++  end
++
++  private
++
++  def coupon
++    @coupon ||= Coupon.new(params[:id])
++  end
++end","@cpytel how does the flow work right now? I expect to go to the sign up as customer page after putting in my code, but it goes to the longer landing page?"
+6386,"@@ -75,10 +75,10 @@ void show_message(
+     //
+     switch (priority) {
+     case MSG_INTERNAL_ERROR:
+-        snprintf(event_msg, sizeof(event_msg), ""[error] %s"", message);
++        snprintf(event_msg, sizeof(event_msg), ""[error] %.512s"", message);
+         break;
+     case MSG_SCHEDULER_ALERT:
+-        snprintf(event_msg, sizeof(event_msg), ""%s: %s"",
++        snprintf(event_msg, sizeof(event_msg), ""%.64s: %.512s"",
+             _(""Message from server""), message
+         );
+         break;","`event_msg` has the same size (1024) as a `message`. Maybe should be increased to 2048 instead? Then this `""[error] %.512s"", message` could be changed to this: `""[error] %.*s"", sizeof(message), message`"
+6387,"@@ -35,6 +35,7 @@ package org.apache.iceberg;
+  * changes.
+  */
+ public interface ReplacePartitions extends SnapshotUpdate<ReplacePartitions> {
++
+   /**
+    * Add a {@link DataFile} to the table.
+    *",Nit: unnecessary whitespace change.
+6388,"@@ -176,7 +176,7 @@ func (b *PinnedMap) Iter(f MapIter) error {
+ 	args := cmd[1:]
+
+ 	printCommand(prog, args...)
+-	output, err := exec.Command(prog, args...).CombinedOutput()
++	output, err := exec.Command(prog, args...).Output()
+ 	if err != nil {
+ 		return errors.Errorf(""failed to dump in map (%s): %s\n%s"", b.versionedFilename(), err, output)
+ 	}","Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`"
+6389,"@@ -119,7 +119,15 @@ void image_data_reader::set_input_params(const int width, const int height, cons
+
+ bool image_data_reader::fetch_label(CPUMat& Y, int data_id, int mb_idx) {
+   const label_t label = m_image_list[data_id].second;
+-  Y.Set(label, mb_idx, 1);
++  if (label >= 0 && label < m_num_labels) {
++    Y.Set(label, mb_idx, 1);
++  }
++  else {
++    LBANN_ERROR(
++      ""\"""",this->get_type(),""\"" data reader "",
++      ""expects data with "",m_num_labels,"" labels, "",
++      ""but data sample "",data_id,"" has a label of "",label);
++  }
+   return true;
+ }
+ ",I would use static_cast<label_t>(0) and static_cast<label_T>(m_num_labels) just in case.
+6390,"@@ -406,4 +406,18 @@ public class ZMSUtils {
+
+         return authorityFilter;
+     }
++
++    public static String lowerDomainInResource(String resource) {
++        if (resource == null) {
++            return null;
++        }
++
++        int delimiterIndex = resource.indexOf("":"");
++        if (delimiterIndex == -1) {
++            return resource;
++        }
++
++        String lowerCasedDomain = resource.substring(0, delimiterIndex).toLowerCase();
++        return lowerCasedDomain + resource.substring(delimiterIndex);
++    }
+ }",Even if we want to keep in original case - domain will be lower-cased.
+6391,"@@ -0,0 +1,9 @@
++class RenameTopicBodyHtmlToTrailMap < ActiveRecord::Migration
++  def up
++    rename_column :topics, :body_html, :trail_map
++  end
++
++  def down
++    rename_column :topics, :trail_map, :body_html
++  end
++end",Based on discussion with Chad it feels like trail_map_json could be a good column name.
+6392,"@@ -98,9 +98,9 @@ class Users extends Controller
+                 'comment' => $permission->comment,
+                 'type' => 'balloon-selector',
+                 'options' => [
+-                    1 => 'Allow',
+-                    0 => 'Inherit',
+-                    -1 => 'Deny',
++                    1 => Lang::get('backend::lang.user.allow'),
++                    0 => Lang::get('backend::lang.user.inherit'),
++                    -1 => Lang::get('backend::lang.user.deny'),
+                 ],
+                 'attributes' => [
+                     'data-trigger' => ""input[name='User[permissions][superuser]']"",","This array should be logic-less, just the language string (without `Lang::get()`) should appear. Then `trans()` is [or should be] used when the balloon selector renders the values."
+6393,"@@ -253,7 +253,7 @@ module Beaker
+         else
+           task = 'defaultgroup:ensure_default_group'
+         end
+-        on dashboard, ""/opt/puppet/bin/rake -sf /opt/puppet/share/puppet-dashboard/Rakefile #{task} RAILS_ENV=production""
++        on dashboard, ""BUNDLE_GEMFILE=/opt/puppet/share/puppet-dashboard/Gemfile /opt/puppet/bin/bundle/exec /opt/puppet/bin/rake -sf /opt/puppet/share/puppet-dashboard/Rakefile #{task} RAILS_ENV=production""
+
+         # Now that all hosts are in the dashbaord, run puppet one more
+         # time to configure mcollective","This looks like it runs both pre 3.0 rake tasks and 3 rake tasks, and since pre 3.0 we didn't use bundler, my guess is it will fail then."
+6394,"@@ -450,7 +450,14 @@ func (m *Manager) Set(container *configs.Config) error {
+ }
+
+ func getUnitName(c *configs.Cgroup) string {
+-	return fmt.Sprintf(""%s-%s.scope"", c.Parent, c.Name)
++	allowed := ""0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ:-_.\\""
++	sanitizeFunc := func(r rune) rune {
++		if strings.ContainsRune(allowed, r) {
++			return r
++		}
++		return '.'
++	}
++	return fmt.Sprintf(""%s-%s.scope"", strings.Map(sanitizeFunc, c.Parent), strings.Map(sanitizeFunc, c.Name))
+ }
+
+ // Atm we can't use the systemd device support because of two missing things:","I'm not sure the replacement is a good idea, and as I said in #336 , this ""parent-name.scope"" is not a good idea in the first place, specially when we support assigning a slice as the parent, so we should change this, WDYT?"
+6395,"@@ -627,7 +627,7 @@ func (dao *blockDAO) putBlock(blk *block.Block) error {
+ 			log.L().Error(""failed to serialize receipits for block"", zap.Uint64(""height"", blkHeight))
+ 		}
+ 	}
+-	if err = kv.Commit(batchForBlock); err != nil {
++	if err = kv.WriteBatch(batchForBlock); err != nil {
+ 		return err
+ 	}
+ ",sloppyReassign: re-assignment to `err` can be replaced with `err := kv.WriteBatch(batchForBlock)` (from `gocritic`)
+6396,"@@ -123,7 +123,11 @@ public class VertxServerResponseToHttpServletResponse extends AbstractHttpServle
+   @Override
+   public CompletableFuture<Void> sendPart(Part part) {
+     DownloadUtils.prepareDownloadHeader(this, part);
+-
++    if (part == null) {
++      CompletableFuture<Void> future = new CompletableFuture<>();
++      future.complete(null);
++      return future;
++    }
+     return new PumpFromPart(context, part).toWriteStream(serverResponse, null);
+   }
+ ",using factory method. return CompletableFuture.completedFuture
+6397,"@@ -31,7 +31,7 @@ storiesOf( 'Global', module )
+ 				title={ __( 'Top content over the last 28 days', 'google-site-kit' ) }
+ 				headerCtaLink=""https://analytics.google.com""
+ 				headerCtaLabel={ __( 'See full stats in Analytics', 'google-site-kit' ) }
+-				footerCtaLabel={ __( 'Analytics', 'google-site-kit' ) }
++				footerCtaLabel={ _x( 'Analytics', 'Service name', 'google-site-kit' ) }
+ 				footerCtaLink=""https://analytics.google.com""
+ 			>
+ 				<AnalyticsDashboardWidgetTopPagesTable />",The `_x` function needs to be imported at the top of the file (in addition to `__`)
+6398,"@@ -19,7 +19,7 @@ type ofFlow struct {
+ 	// The Flow.Table field can be updated by Reset(), which can be called by
+ 	// ReplayFlows() when replaying the Flow to OVS. For thread safety, any access
+ 	// to Flow.Table should hold the replayMutex read lock.
+-	ofctrl.Flow
++	*ofctrl.Flow
+
+ 	// matchers is string slice, it is used to generate a readable match string of the Flow.
+ 	matchers []string",this looks like the only controversial change potentially. @MatthewHinton56 Could let us know why you made this change (which `go vet` warning was triggered)? @wenyingd could you take a look and let us know if you're okay with this change?
+6399,"@@ -26,7 +26,7 @@ using pwiz.Skyline.Util;
+
+ namespace pwiz.Skyline.Controls.Graphs
+ {
+-    public sealed partial class AreaCVToolbar : GraphSummaryToolbar //UserControl // for designer
++    public sealed partial class AreaCVToolbar : GraphSummaryToolbar //GraphSummaryToolbar UserControl // for designer
+     {
+         private readonly Timer _timer;
+         private int _standardTypeCount;","This seems like left-over debugging code. I think I fixed this to no longer be necessary, switching to UserControl for the designer."
+6400,"@@ -0,0 +1,15 @@
++import re
++import logging
++from localstack.utils.common import to_str, to_bytes
++from localstack.services.generic_proxy import ProxyListener
++from moto.elbv2 import urls
++
++LOG = logging.getLogger(__name__)
++
++
++class ProxyListenerELBV2(ProxyListener):
++    pass
++
++
++# # instantiate listener
++UPDATE_ELBV2 = ProxyListenerELBV2()","As we're currently not applying any logic in the proxy listener, I guess we can simply remove this file (and remove the `listener` argument from the `register_plugin(..)` call above)."
+6401,"@@ -86,6 +86,7 @@ func (w *DefaultWorker) Generate(ctx context.Context,
+ 		Proof:           proof,
+ 		StateRoot:       newStateTreeCid,
+ 		Ticket:          ticket,
++		Timestamp:       types.Uint64(time.Now().Unix()),
+ 	}
+
+ 	for i, msg := range res.PermanentFailures {",Isn't the point of the clock module to encapsulate access to `time.Now()`? Coming later?
+6402,"@@ -117,6 +117,10 @@ func generateFastUpgradeConsensus() (fastUpgradeProtocols config.ConsensusProtoc
+ 		}
+
+ 		fastUpgradeProtocols[consensusTestFastUpgrade(proto)] = fastParams
++
++		// support the ALGOSMALLLAMBDAMSEC = 500 env variable
++		fastParams.AgreementFilterTimeout = time.Second
++		fastParams.AgreementFilterTimeoutPeriod0 = time.Second
+ 	}
+ 	return
+ }","as before - if you've set this, you should be able to get rid of the `os.Setenv(""ALGOSMALLLAMBDAMSEC"", ""500"")`. make sure that the various tests still takes have the same execution time."
+6403,"@@ -450,8 +450,8 @@ module Travis
+             mactex = 'BasicTeX.pkg'
+             # TODO(craigcitro): Confirm that this will route us to the
+             # nearest mirror.
+-            sh.cmd 'wget http://mirror.ctan.org/systems/mac/mactex/'\
+-                   ""#{mactex} -O \""/tmp/#{mactex}\""""
++            sh.cmd 'curl -fLo \""/tmp/#{mactex}\"" --retry 3 http://mirror.ctan.org/systems/mac/mactex/'\
++                   '#{mactex}'
+
+             sh.echo 'Installing OS X binary package for MacTeX'
+             sh.cmd ""sudo installer -pkg \""/tmp/#{mactex}\"" -target /""","Pretty sure the single quotes here should be double quotes, single quotes are not expanded by the shell."
+6404,"@@ -109,8 +109,11 @@ public final class ValidateConstantMessageTests {
+                         ""  void f(boolean bArg, int iArg, Object oArg, Integer[] arrayArg, ""
+                             + ""Collection<String> collectionArg, Map<String, String> mapArg, String stringArg, ""
+                             + ""Iterable<String> iterableArg, double dArg) {"",
++                        ""    String localConstant = \""constant\"";"",
+                         ""    Validate.isTrue(bArg, \""message %d\"", 123L);"",
+                         ""    Validate.isTrue(bArg, \""message %f\"", 0.0);"",
++                        ""    Validate.notBlank(stringArg, \""message %s\"", compileTimeConstant);"",
++                        ""    Validate.notBlank(stringArg, \""message %s\"", localConstant);"",
+                         ""    Validate.isTrue(bArg, \""message %s %s\"", \""msg\"", \""msg\"");"",
+                         ""    Validate.notNull(oArg, \""message %s %s\"", \""msg\"", \""msg\"");"",
+                         ""    Validate.notEmpty(arrayArg, \""message %s %s\"", \""msg\"", \""msg\"");"",","these are not really constants, right?"
+6405,"@@ -1,3 +1,4 @@
++from boto.compat import six
+ # Copyright (c) 2012 Mitch Garnaat http://garnaat.org/
+ # Copyright (c) 2012 Amazon.com, Inc. or its affiliates.  All Rights Reserved
+ #",import below copyright statement
+6406,"@@ -49,7 +49,7 @@ describe InvoiceNotifier do
+
+   def customer_should_receive_receipt_email(invoice)
+     email = ActionMailer::Base.deliveries.first
+-    email.subject.should include('receipt')
+-    email.to.should eq [invoice.user_email]
++    expect(email.subject).to include('receipt')
++    expect(email.to).to eq [invoice.user_email]
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+6407,"@@ -200,11 +200,11 @@ class Field implements Translatable
+     }
+
+     /**
+-     * @return string|Markup
++     * @return string|array|Markup
+      */
+     public function getTwigValue()
+     {
+-        $value = $this->__toString();
++        $value = $this->getFlattenedValue();
+
+         if ($this->getDefinition()->get('allow_html')) {
+             $value = new Markup($value, 'UTF-8');",`if (is_string($value) && $this->getDefinition()->get('allow_html')) {`
+6408,"@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace
+
+         private void AddInternal(string key, object value)
+         {
+-            Guard.Null(key, nameof(key));
++            Debug.Assert(key != null, $""{nameof(key)} must not be null"");
+
+             this.Attributes[key] = value;
+         }","I think we have the same problem here - if folks called the `public void Add` with a `null` key, we need to use `Guard`."
+6409,"@@ -0,0 +1,12 @@
++//
++//  Copyright (C) 2020 Greg Landrum
++//   @@ All Rights Reserved @@
++//  This file is part of the RDKit.
++//  The contents are covered by the terms of the BSD license
++//  which is included in the file license.txt, found at the root
++//  of the RDKit source tree.
++//
++
++#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only do
++                           // this in one cpp file
++#include ""catch.hpp""",I thought that the main was in catch_qt.cpp?
+6410,"@@ -87,7 +87,7 @@ public class ImagesManageActivity extends BaseActivity {
+     private static final int REQUEST_UNSELECT_IMAGE_AFTER_LOGIN = 4;
+     public static final int REQUEST_EDIT_IMAGE = 1000;
+     private static final int REQUEST_CHOOSE_IMAGE = 1001;
+-    private static final List<ProductImageField> TYPE_IMAGE = Arrays.asList(ProductImageField.FRONT, ProductImageField.INGREDIENTS, ProductImageField.NUTRITION);
++    private static final List<ProductImageField> TYPE_IMAGE = Arrays.asList(ProductImageField.FRONT, ProductImageField.INGREDIENTS, ProductImageField.NUTRITION, ProductImageField.PACKAGING);
+     private ActivityFullScreenImageBinding binding;
+     private OpenFoodAPIClient client;
+     private File lastViewedImage;","I would rename the field to IMAGE_TYPES and make it an array. I don't think we need list operations. Also, if possible, I would move the field to the ApiFields class. What do you think?"
+6411,"@@ -117,6 +117,17 @@ func verifyContainerRunningStateChangeWithRuntimeID(t *testing.T, taskEngine Tas
+ 		""Expected container runtimeID should not empty"")
+ }
+
++func verifyExecAgentRunningStateChange(t *testing.T, taskEngine TaskEngine) {
++	stateChangeEvents := taskEngine.StateChangeEvents()
++	event := <-stateChangeEvents
++	containerEvent := event.(api.ContainerStateChange)
++	assert.NotEmpty(t, containerEvent.ManagedAgents, ""Expected exec-agent event has no managed agents"")
++	if containerEvent.ManagedAgents != nil {
++		assert.Equal(t, apicontainerstatus.ManagedAgentRunning, containerEvent.ManagedAgents[0].Status,
++			""expected managedAgent container state change event did not match actual event"")
++	}
++}
++
+ func verifyContainerStoppedStateChange(t *testing.T, taskEngine TaskEngine) {
+ 	stateChangeEvents := taskEngine.StateChangeEvents()
+ 	event := <-stateChangeEvents","I'd prefer to timeout on this, but I know it's not a pattern that is being followed"
+6412,"@@ -37,10 +37,7 @@ import org.apache.lucene.store.BufferedChecksumIndexInput;
+ import org.apache.lucene.store.ChecksumIndexInput;
+ import org.apache.lucene.store.IOContext;
+ import org.apache.lucene.store.IndexInput;
+-import org.apache.lucene.util.BytesRef;
+-import org.apache.lucene.util.BytesRefBuilder;
+-import org.apache.lucene.util.IOUtils;
+-import org.apache.lucene.util.StringHelper;
++import org.apache.lucene.util.*;
+
+ /**
+  * Reads vector values from a simple text format. All vectors are read up front and cached in RAM in",hmm let's not use * imports please
+6413,"@@ -497,6 +497,10 @@ func generateAlertmanagerConfig(version semver.Version, am v1.AlertmanagerEndpoi
+ 		cfg = append(cfg, k8sSDWithNamespaces([]string{am.Namespace}))
+ 	}
+
++	if am.BearerTokenFile != """" {
++		cfg = append(cfg, yaml.MapItem{Key: ""bearer_token_file"", Value: am.BearerTokenFile})
++	}
++
+ 	var relabelings []yaml.MapSlice
+
+ 	relabelings = append(relabelings, yaml.MapSlice{",is this configuration key already exist in prometheus ?
+6414,"@@ -2,6 +2,7 @@ require ""test_helper""
+
+ class DiaryEntryControllerTest < ActionController::TestCase
+   include ActionView::Helpers::NumberHelper
++  api_fixtures
+
+   def setup
+     # Create the default language for diary entries","As @gravitystorm said new tests need to be using factories, not fixtures."
+6415,"@@ -171,8 +171,8 @@ bool CliManager::readLine(std::string &line, bool linebreak) {
+         if (!isInteractive_) {
+             break;
+         }
+-        auto purePrompt = folly::stringPrintf(""(%s@%s:%d) [%s]> "",
+-                                              username_.c_str(), addr_.c_str(), port_,
++        auto purePrompt = folly::stringPrintf(""(%s@) [%s]> "",
++                                              username_.c_str(),
+                                               cmdProcessor_->getSpaceName().c_str());
+         if (linebreak) {
+             purePrompt.assign(purePrompt.size() - 3, ' ');",You can replace IP by hostname.
+6416,"@@ -123,13 +123,14 @@ def getDriversForConnectedUsbDevices():
+ 			for port in deviceInfoFetcher.comPorts if ""usbID"" in port)
+ 	)
+ 	for match in usbDevs:
+-		# check for the Braille HID protocol before any other device matching.
+-		if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILLE:
+-			yield (""hid"", match)
+ 		for driver, devs in _driverDevices.items():
+ 			for type, ids in devs.items():
+ 				if match.type==type and match.id in ids:
+ 					yield driver, match
++		# check for the Braille HID protocol after any other device matching.
++		if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILLE:
++			yield (""hid"", match)
++
+
+ def getDriversForPossibleBluetoothDevices():
+ 	""""""Get any matching drivers for possible Bluetooth devices.","This should say ""why"" NVDA should do things in this order."
+6417,"@@ -114,7 +114,7 @@ func TestPopulateLocationConstraint(t *testing.T) {
+ func TestNoPopulateLocationConstraintIfProvided(t *testing.T) {
+ 	s := s3.New(unit.Session)
+ 	req, _ := s.CreateBucketRequest(&s3.CreateBucketInput{
+-		Bucket: aws.String(""bucket""),
++		Bucket:                    aws.String(""bucket""),
+ 		CreateBucketConfiguration: &s3.CreateBucketConfiguration{},
+ 	})
+ 	if err := req.Build(); err != nil {",nit these will get changed back during next release.
+6418,"@@ -0,0 +1,8 @@
++// Copyright 2021 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package api
++
++// Version is set in the build process.
++var Version string",it is actually not needed to make the member public. the build tags can also set a package scoped variable.
+6419,"@@ -38,6 +38,7 @@ trait ContentExtrasTrait
+             'excerpt' => $this->contentExtension->getExcerpt($content),
+             'link' => $this->contentExtension->getLink($content),
+             'editLink' => $this->contentExtension->getEditLink($content),
++            'icon' => $this->contentExtension->getIcon($content),
+         ];
+     }
+ }",We already have a method for it 'icon' => $content->getIcon()
+6420,"@@ -9,6 +9,7 @@ import (
+ 	""github.com/aws/aws-sdk-go/service/kms""
+ 	""github.com/aws/aws-sdk-go/service/s3""
+ 	""github.com/aws/aws-sdk-go/service/s3/s3iface""
++	""golang.org/x/net/context""
+ )
+
+ // WrapEntry is builder that return a proper key decrypter and error",Instead of importing `golang.org/x/net/context` The SDK should use `aws.BackgroundContext()` instead of `context.Background()`
+6421,"@@ -38,7 +38,7 @@ class MediaController extends Controller
+      */
+     public function getMedia($id)
+     {
+-        return $this->get('sonata.media.manager.media')->findOneBy(array('id' => $id));
++        return $this->get('sonata.media.manager.media')->find($id);
+     }
+
+     /**",I think this is an agnostic change for the ORM right? Why was it doing this? - this does not work on PHPCR-ODM as the `id` is not a field - although I guess it could be mapped as such.
+6422,"@@ -73,7 +73,7 @@ class ApplicationController < ActionController::Base
+   helper_method :included_in_current_users_plan?
+
+   def topics
+-    Topic.top
++    Topic.all
+   end
+   helper_method :topics
+ ","I'm not 100% sure, but I think this should be `explorable`. If not, I think `explorable` can be removed entirely."
+6423,"@@ -124,15 +124,13 @@ class MockTarget(target.FileSystemTarget):
+                 self.wrapper = wrapper
+
+             def write(self, data):
+-                if six.PY3:
+-                    stderrbytes = sys.stderr.buffer
+-                else:
+-                    stderrbytes = sys.stderr
+-
+                 if mock_target._mirror_on_stderr:
+                     if self._write_line:
+                         sys.stderr.write(fn + "": "")
+-                    stderrbytes.write(data)
++                    if six.binary_type:
++                        sys.stderr.write(data.decode('utf8'))
++                    else:
++                        sys.stderr.write(data)
+                     if (data[-1]) == '\n':
+                         self._write_line = True
+                     else:",Note to self: Why was this not originally not using `stderrbytes`?
+6424,"@@ -364,6 +364,14 @@ bool FileUtils::exist(const std::string& path) {
+     return access(path.c_str(), F_OK) == 0;
+ }
+
++// static
++bool FileUtils::rename(const std::string& src, const std::string& dst) {
++    auto status = ::rename(src.c_str(), dst.c_str());
++    LOG_IF(WARNING, status < 0) << ""Rename "" << src << "" to "" << dst << "" failed, the errno: ""
++        << ::strerror(errno);
++    return status == 0;
++}
++
+ std::vector<std::string> FileUtils::listAllTypedEntitiesInDir(
+         const char* dirpath,
+         FileType type,","Is betterLOG_IF(ERROR, status != 0) ?"
+6425,"@@ -38,6 +38,9 @@ class BaseLoadTest(TestCase):
+         self.session.auth = self.auth
+         self.session.headers.update({'Content-Type': 'application/json'})
+
++        self.bucket = 'default'
++        self.collection = 'default'
++
+         # Keep track of created objects.
+         self._collections_created = {}
+ ",I wouldn't call it default too.
+6426,"@@ -2,6 +2,7 @@
+  * and will be replaced soon by a Vue component.
+  */
+
++/* eslint-disable no-var */
+ import browser from 'browser';
+ import dom from 'dom';
+ import 'css!./navdrawer';",Why disable the rule for this file?
+6427,"@@ -76,6 +76,7 @@ CTA.propTypes = {
+ 	'aria-label': PropTypes.string,
+ 	error: PropTypes.bool,
+ 	onClick: PropTypes.func,
++	ctaLinkExternal: PropTypes.bool,
+ };
+
+ CTA.defaultProps = {",Thanks for adding this :+1:. Could you please move it to go after the `ctaLink` prop?
+6428,"@@ -193,7 +193,7 @@ namespace Nethermind.Core.Collections
+
+             public T Current => _array[_index];
+
+-            object IEnumerator.Current => Current;
++            object IEnumerator.Current => Current!;
+
+             public void Dispose() { }
+         }",The other way around Current can be null.
+6429,"@@ -230,7 +230,8 @@ class SideMenuBuilder
+
+         $communicationMenu = $menu->addChild('communication', ['label' => t('Communication with customer')]);
+         $communicationMenu->addChild('mail_settings', ['route' => 'admin_mail_setting', 'label' => t('Email settings')]);
+-        $communicationMenu->addChild('mail_templates', ['route' => 'admin_mail_template', 'label' => t('Email templates')]);
++        $mailTemplates = $communicationMenu->addChild('mail_templates', ['route' => 'admin_mail_template', 'label' => t('Email templates')]);
++        $mailTemplates->addChild('edit_template', ['route' => 'admin_mail_edit', 'label' => t('Editing email template'), 'display' => false]);
+         $communicationMenu->addChild('order_confirmation', ['route' => 'admin_customercommunication_ordersubmitted', 'label' => t('Order confirmation page')]);
+
+         $listsMenu = $menu->addChild('lists', ['label' => t('Lists and nomenclatures')]);",why does it have to be here? Due to breadcrumb navigation?
+6430,"@@ -21,10 +21,18 @@ import (
+
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	""github.com/openebs/maya/pkg/util""
++	""k8s.io/apimachinery/pkg/api/resource""
+ 	v1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/types""
+ )
+
++//TODO: Move to some common function
++func StrToQuantity(capacity string) resource.Quantity {
++	qntCapacity, _ := resource.ParseQuantity(capacity)
++	//	fmt.Printf(""Error: %v"", err)
++	return qntCapacity
++}
++
+ // TestCreateVolumeTarget is to test cStorVolume creation.
+ func TestCreateVolumeTarget(t *testing.T) {
+ 	testVolumeResource := map[string]struct {",I fear moving this to some common func. We are swallowing the error here. This might be ok in UT but not in actual source code.
+6431,"@@ -716,12 +716,9 @@ class TestMessagesStore(object):
+         with pytest.raises(InvalidMessageError) as cm:
+             store.add_renamed_message(
+                 'W1234', 'old-msg-symbol', 'duplicate-keyword-arg')
+-        assert str(cm.value) == ""Message id 'W1234' is already defined""
+-        # conflicting message symbol
+-        with pytest.raises(InvalidMessageError) as cm:
+-            store.add_renamed_message(
+-                'W1337', 'msg-symbol', 'duplicate-keyword-arg')
+-        assert str(cm.value) == ""Message symbol 'msg-symbol' is already defined""
++        expected = ""Message id 'W1234' cannot have both 'msg-symbol' and \
++'old-msg-symbol' as symbolic name.""
++        assert str(cm.value) == expected
+
+     def test_renamed_message_register(self, store):
+         assert 'msg-symbol' == store.check_message_id('W0001').symbol","Please don't use \ as a line continuation. Do an implicit string join instead with parens: ``` (""Message ..."" ""and ..."")"
+6432,"@@ -258,7 +258,6 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey,
+ 		return nil, fmt.Errorf(""localstore: %w"", err)
+ 	}
+ 	b.localstoreCloser = storer
+-	// register localstore unreserve function on the batchstore before batch service starts listening to blockchain events
+
+ 	batchStore, err := batchstore.New(stateStore, nil)
+ 	if err != nil {",there needs to be a change here. setting up the batchstore with localstore.Unreserve hook
+6433,"@@ -52,9 +52,15 @@ public final class ConfigUtil {
+
+   private static final String MICROSERVICE_CONFIG_LOADER_KEY = ""cse-microservice-config-loader"";
+
++  private static ConfigModel model = new ConfigModel();
++
+   private ConfigUtil() {
+   }
+
++  public static void setConfigs(Map<String, Object> config) {
++    model.setConfig(config);
++  }
++
+   public static Object getProperty(String key) {
+     Object config = DynamicPropertyFactory.getBackingConfigurationSource();
+     return getProperty(config, key);","I think if we can provide a more convenient method to add configs . e.g. public static void addConfig(String k, Object v)"
+6434,"@@ -266,7 +266,7 @@ func TestActPool_AddActs(t *testing.T) {
+ 	err = ap.AddTsf(overBalTsf)
+ 	require.Equal(ErrBalance, errors.Cause(err))
+ 	// Case VI: over gas limit
+-	creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), blockchain.GasLimit+100, big.NewInt(10), []byte{})
++	creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), action.GasLimit+100, big.NewInt(10), []byte{})
+ 	require.NoError(err)
+ 	err = ap.AddExecution(creationExecution)
+ 	require.Equal(ErrGasHigherThanLimit, errors.Cause(err))",line is 165 characters
+6435,"@@ -0,0 +1,8 @@
++package org.jkiss.dbeaver.ext.oceanbase.data;
++
++import org.jkiss.dbeaver.model.impl.jdbc.data.handlers.JDBCStandardValueHandlerProvider;
++
++public class OceanbaseValueHandlerProvider extends JDBCStandardValueHandlerProvider{
++
++
++}","Please add a copyright notice. Also, could you tell me please why do we need this empty provider here?"
+6436,"@@ -95,8 +95,11 @@ public class EeaSendRawTransaction implements JsonRpcMethod {
+         maybePrivacyGroup =
+             privacyController.retrieveOnChainPrivacyGroup(
+                 maybePrivacyGroupId.get(), enclavePublicKey);
+-        if (maybePrivacyGroup.isEmpty()
+-            && !privacyController.isGroupAdditionTransaction(privateTransaction)) {
++        if (maybePrivacyGroup.isEmpty()) {
++          if (!privacyController.isGroupAdditionTransaction(privateTransaction)) {
++            return new JsonRpcErrorResponse(id, JsonRpcError.ONCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST);
++          }
++        } else if (!maybePrivacyGroup.get().getMembers().contains(enclavePublicKey)) {
+           return new JsonRpcErrorResponse(id, JsonRpcError.ONCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST);
+         }
+       } else { // !onchainPirvacyGroupEnabled",I feel like this would be easier to read if we join the two if's together: `if (maybePrivacyGroup.isEmpty() && !privacyController.isGroupAdditionTransaction(privateTransaction))`
+6437,"@@ -567,7 +567,7 @@ public class DBOpenHelper extends SQLiteOpenHelper {
+ 		try {
+ 			result = new JSONObject(loadSoupBlobAsString(soupTableName, soupEntryId, passcode));
+
+-		} catch (JSONException ex) {
++		} catch (Exception ex) {
+ 			Log.e(""DBOpenHelper:loadSoupBlob"", ""Exception occurred while attempting to read external soup blob."", ex);
+ 		}
+ 		return result;","Tests are failing because the exception type is NullPointException here if the soupBlob is deleted (so instead of a mal-format json, it's a null)"
+6438,"@@ -439,12 +439,8 @@ Blockly.Connection.prototype.isConnectionAllowed = function(candidate) {
+       break;
+     }
+     case Blockly.OUTPUT_VALUE: {
+-      // Don't offer to connect an already connected left (male) value plug to
+-      // an available right (female) value plug.
+-      if (candidate.targetConnection || this.targetConnection) {
+-        return false;
+-      }
+-      break;
++      // Can't drag an input to an output--you have to move the inferior block.
++      return false;
+     }
+     case Blockly.INPUT_VALUE: {
+       // Offering to connect the left (male) of a value block to an already","Glad we fixed this as well. Blockly is going to be left as-is for this case, right?"
+6439,"@@ -36,9 +36,7 @@ import java.util.Locale;
+  * This class represents a typical Salesforce object.
+  *
+  * @author bhariharan
+- * @deprecated Will be removed in Mobile SDK 7.0.
+  */
+-@Deprecated
+ public class SalesforceObject {
+
+     protected String objectType;",I had accidentally deprecated this class. This is meant to stick around. Only `SalesforceObjectType` goes away.
+6440,"@@ -208,6 +208,7 @@ def rev_hex(s):
+ def int_to_hex(i, length=1):
+     assert isinstance(i, int)
+     s = hex(i)[2:].rstrip('L')
++    s = s.lstrip('0x')
+     s = ""0""*(2*length - len(s)) + s
+     return rev_hex(s)
+ ",`hex(i)[2:]` is trying to do the same thing above. what is `i` in your malformed case?
+6441,"@@ -126,8 +126,8 @@ public class XML {
+     }
+   }
+
+-  /** escapes character data in val */
+-  public final static void writeXML(Writer out, String tag, String val, Object... attrs) throws IOException {
++  /** escapes character data in val if shouldEscape is true*/
++  public final static void writeXML(Writer out, String tag, boolean shouldEscape, String val, Object... attrs) throws IOException {
+     out.write('<');
+     out.write(tag);
+     for (int i=0; i<attrs.length; i++) {","I think this change is redundant; see the previously defined method ""writeUnescapedXML""."
+6442,"@@ -0,0 +1,18 @@
++package types
++
++import cbor ""gx/ipfs/QmRoARq3nkUb13HSKZGepCZSWe5GrVPwx7xURJGZ7KWv9V/go-ipld-cbor""
++
++func init() {
++	cbor.RegisterCborType(Commitments{})
++}
++
++// CommitmentLength is the length of a single commitment (in bytes).
++const CommitmentLength = 32
++
++// Commitments is a struct containing the replica and data commitments produced
++// when sealing a sector.
++type Commitments struct {
++	CommD     [CommitmentLength]byte
++	CommR     [CommitmentLength]byte
++	CommRStar [CommitmentLength]byte
++}",Ah now I have at least some idea what these are for.
+6443,"@@ -58,8 +58,8 @@ public class DataReader<T> implements DatumReader<T> {
+   }
+
+   @Override
+-  public void setSchema(Schema fileSchema) {
+-    this.fileSchema = Schema.applyAliases(fileSchema, readSchema);
++  public void setSchema(Schema schema) {
++    this.fileSchema = Schema.applyAliases(schema, readSchema);
+   }
+
+   @Override",I believe in previous PRs @mccheah frequently used `fileSchema` -> `newFileSchema` type of renames to avoid hiding fields in builders. Would it make sense to make it consistent?
+6444,"@@ -62,9 +62,17 @@ func (manager *connectionManager) Connect(consumerID, providerID identity.Identi
+ 		}
+ 	}()
+
++	err = manager.startConnection(consumerID, providerID)
++	if err == utils.ErrRequestCancelled {
++		return ErrConnectionCancelled
++	}
++	return err
++}
++
++func (manager *connectionManager) startConnection(consumerID, providerID identity.Identity) (err error) {
+ 	cancelable := utils.NewCancelable()
+ 	manager.cleanConnection = utils.CallOnce(func() {
+-		log.Info(managerLogPrefix, ""Canceling connection initiation"")
++		log.Info(managerLogPrefix, ""Cancelling connection initiation"")
+ 		manager.status = statusDisconnecting()
+ 		cancelable.Cancel()
+ 	})",Do we really need separate error in manager if utils.ErrRequestCancelled is the only error which indicates cancelation ?
+6445,"@@ -136,7 +136,7 @@ MODEL_PARAMS = {
+
+             # Temporal Pooler implementation selector (see _getTPClass in
+             # CLARegion.py).
+-            'temporalImp': 'cpp',
++            'temporalImp': 'tm_cpp',
+
+             # New Synapse formation count
+             # NOTE: If None, use spNumActivePerInhArea",Leave as `cpp` since that still gives better results.
+6446,"@@ -27,7 +27,7 @@ import (
+ 	""sigs.k8s.io/controller-runtime/pkg/predicate""
+ )
+
+-func pausedPredicates(logger logr.Logger) predicate.Funcs {
++func PausedPredicates(logger logr.Logger) predicate.Funcs {
+ 	return predicate.Funcs{
+ 		UpdateFunc: func(e event.UpdateEvent) bool {
+ 			return processIfUnpaused(logger.WithValues(""predicate"", ""updateEvent""), e.ObjectNew, e.MetaNew)",temp change so the predicate can be used by the `exp` package
+6447,"@@ -387,6 +387,11 @@ class KeyboardInputGesture(inputCore.InputGesture):
+ 			# This could be for an event such as gyroscope movement,
+ 			# so don't report it.
+ 			return False
++		if self.vkCode in self.TOGGLE_KEYS:
++			# #5490: Dont report for keys that toggle on off.
++			# This is to avoid them from reported twice: once by the 'speak command keys' feature,
++			# and once by the 'speak typed characters' feature
++			return False
+ 		return not self.isCharacter
+
+ 	def _get_isCharacter(self):","Just as a tiny clarification, this isn't affected in any way by ""speak typed characters"". That is, ""caps lock on"", etc. is always spoken, even if speak typed characters is off."
+6448,"@@ -61,10 +61,11 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe
+ 	}
+ 	hLog.Info(""deployment applied (%s)"", result)
+
+-	// Deploy the desired ClusterImageSets representing installable releases of OpenShift.
+-	// TODO: in future this should be pipelined somehow.
+ 	applyAssets := []string{
+ 		""config/manager/service.yaml"",
++
++		// Deploy the desired ClusterImageSets representing installable releases of OpenShift.
++		// TODO: in future this should be pipelined somehow.
+ 		""config/clusterimagesets/openshift-4.0-latest.yaml"",
+ 		""config/clusterimagesets/openshift-4.0-beta3.yaml"",
+ 		""config/clusterimagesets/openshift-4.0-beta4.yaml"",",@dgoodwin Will it cause an issue when the issue get fixed in OLM?
+6449,"@@ -29,9 +29,8 @@ namespace Nethermind.Blockchain.Processing
+         IgnoreParentNotOnMainChain = 16,
+         DoNotVerifyNonce = 32,
+         DoNotUpdateHead = 64,
+-        DumpParityTraces = 128,
+-        DumpGetTraces = 256,
+-        All = 511,
++        RerunWithTraceOnFailure = 128,
++        All = 255,
+         ProducingBlock = NoValidation | ReadOnlyChain,
+         Trace = ForceProcessing | ReadOnlyChain | DoNotVerifyNonce | NoValidation,
+         Beam = IgnoreParentNotOnMainChain | DoNotUpdateHead",This option is now unnecessary
+6450,"@@ -360,10 +360,7 @@ func TestWriter(t *testing.T) {
+ 			t.Fatal(err)
+ 		}
+
+-		b, err := NewBucket(subdir)
+-		if err != nil {
+-			t.Fatal(err)
+-		}
++		b := &bucket{dir: subdir}
+ 		ctx := context.Background()
+ 		names := []string{
+ 			// Backslashes not allowed.","Don't jump down to the unexported interface: just set the content type to `""application/octet-stream""` explicitly when creating the `Writer`."
+6451,"@@ -176,8 +176,11 @@ class BufferedUpdates implements Accountable {
+   }
+
+   void clearDeleteTerms() {
+-    deleteTerms.clear();
+     numTermDeletes.set(0);
++    deleteTerms.forEach((term, docIDUpto) -> {
++      bytesUsed.addAndGet(-(BYTES_PER_DEL_TERM + term.bytes.length + (Character.BYTES * term.field().length())));
++    });
++    deleteTerms.clear();
+   }
+
+   void clear() {","Instead of counting this here on clear, can we use a second counter for the deleteTerms next to `bytesUsed`? This would be great. It doesn't need to be thread safe IMO"
+6452,"@@ -24,10 +24,10 @@ class User extends UserBase
+      * Validation rules
+      */
+     public $rules = [
+-        'email' => 'required|between:6,255|email|unique:backend_users',
+-        'login' => 'required|between:2,255|unique:backend_users',
+-        'password' => 'required:create|between:4,255|confirmed',
+-        'password_confirmation' => 'required_with:password|between:4,255'
++        'email' => 'required|between:6,191|email|unique:backend_users',
++        'login' => 'required|between:2,191|unique:backend_users',
++        'password' => 'required:create|between:8,191|confirmed',
++        'password_confirmation' => 'required_with:password|between:8,191'
+     ];
+
+     /**",@daftspunk @bennothommo I wonder if we need to go as deep as detecting what the default varchar length is with a special character to be parsed by the validation trait since we've introduced the config for it.
+6453,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below
+6454,"@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+             ""com.fsck.k9.activity.MessageCompose.quotedTextFormat"";
+     private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = ""numAttachmentsLoading"";
+     private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = ""waitingForAttachments"";
+-
++    private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmpySubject"";
+     private static final String LOADER_ARG_ATTACHMENT = ""attachment"";
+
+     private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = ""waitingForAttachment"";","Typo, should read `firstTimeEmptySubject`"
+6455,"@@ -22,7 +22,7 @@ package transport
+
+ import ""golang.org/x/net/context""
+
+-// Handler handles a single transport-level request.
++// Handler handles a single, transport-level, unary request.
+ type Handler interface {
+ 	// Handle the given request, writing the response to the given
+ 	// ResponseWriter.",The more I see this the more I think the transport layer _should_ actually refer to this as `UnaryHandler`.
+6456,"@@ -267,6 +267,7 @@ module Beaker
+         logger.warn ""#{e.class} error in scp'ing. Forcing the connection to close, which should "" <<
+           ""raise an error.""
+         close
++        raise ""#{e}\n#{e.backtrace}""
+       end
+
+ ",The `warn` message here seems to indicate that the forced closure of the SSH connection should raise an error; is that getting swallowed up somewhere and not raising?
+6457,"@@ -616,6 +616,8 @@ class FilenamePrompt(_BasePrompt):
+         self._init_texts(question)
+         self._init_key_label()
+
++        self._expands_user = False
++
+         self._lineedit = LineEdit(self)
+         if question.default:
+             self._lineedit.setText(question.default)","I wonder if this is a fitting name. Why ""expands user""? Wouldn't be `user_expanded` or so be more fitting?"
+6458,"@@ -28,10 +28,11 @@ var axe = axe || { utils: {} };
+  */
+ function virtualDOMfromNode(node, shadowId) {
+ 	const vNodeCache = {};
+-	return {
++	const vNode = {
+ 		shadowId: shadowId,
+ 		children: [],
+ 		actualNode: node,
++		_isHidden: null, // will be populated by axe.utils.isHidden
+ 		get isFocusable() {
+ 			if (!vNodeCache._isFocusable) {
+ 				vNodeCache._isFocusable = axe.commons.dom.isFocusable(node);","I see what you are doing here, but to stay with the `getter/setter` pattern, should we introduce `set isHidden(value)` & `get isHidden()` which them maintains `_isHidden` with in `vNodeCache`. This will avoid what looks like accessing an internal property like `_isHidden` from `axe.utils.isHidden` & keeps things neat."
+6459,"@@ -41,6 +41,7 @@ public class CSharpBasicPackageTransformer implements ModelToViewTransformer<Pro
+       ""csharp/gapic_snippets_csproj.snip"";
+   private static final String UNITTEST_CSPROJ_TEMPLATE_FILENAME =
+       ""csharp/gapic_unittest_csproj.snip"";
++  private static final String SAMPLE_CSPROJ_TEMPLATE_FILENAME = ""csharp/gapic_samples_csproj.snip"";
+
+   private static final CSharpAliasMode ALIAS_MODE = CSharpAliasMode.MessagesOnly;
+ ","nit: for consistency, have this line and the previous formatted similarly"
+6460,"@@ -165,6 +165,9 @@ public class PrivacyParameters {
+     private PrivacyStorageProvider storageProvider;
+     private EnclaveFactory enclaveFactory;
+     private boolean multiTenancyEnabled;
++    private Path orionKeyStoreFile;
++    private Path orionKeyStorePasswordFile;
++    private Path orionClientWhitelistFile;
+
+     public Builder setPrivacyAddress(final Integer privacyAddress) {
+       this.privacyAddress = privacyAddress;","As before, shouldn't mention these as being orion options I don't think. Perhaps just enclaveKeyStoreFile etc."
+6461,"@@ -152,10 +152,8 @@ async function observeRestResponse( res ) {
+ 		// The response may fail to resolve if the test ends before it completes.
+ 		try {
+ 			args.push( await res.text() );
++			console.log( ...args ); // eslint-disable-line no-console
+ 		} catch ( err ) {} // eslint-disable-line no-empty
+-
+-		// eslint-disable-next-line no-console
+-		console.log( ...args );
+ 	}
+ }
+ ",What's the thinking here? Only logging when the test has not ended yet?
+6462,"@@ -57,6 +57,12 @@ def _column_op(f):
+             args = [arg._scol if isinstance(arg, IndexOpsMixin) else arg for arg in args]
+             scol = f(self._scol, *args)
+
++            # If f is a logistic operator, fill NULL with False
++            log_ops = ['eq', 'ne', 'lt', 'le', 'ge', 'gt']
++            is_log_op = any(f == getattr(spark.Column, f'__{log_op}__') for log_op in log_ops)
++            if is_log_op:
++                scol = F.when(scol.isNull(), False).otherwise(scol)
++
+             return self._with_new_scol(scol)
+         else:
+             # Different DataFrame anchors",@HyukjinKwon @ueshin (cc @itholic @charlesdong1991 ) Not sure if this is the right implementation ...
+6463,"@@ -10,7 +10,13 @@ module.exports = function(url, options, callback) {
+   if (typeof options === 'function') (callback = options), (options = {});
+   options = options || {};
+
+-  let result = parser.parse(url, true);
++  let result;
++  try {
++    result = parser.parse(url, true);
++  } catch (e) {
++    return callback(new Error('URL malformed, cannot be parsed'));
++  }
++
+   if (result.protocol !== 'mongodb:' && result.protocol !== 'mongodb+srv:') {
+     return callback(new Error('Invalid schema, expected `mongodb` or `mongodb+srv`'));
+   }",Do we want to add any specific error on how the url is malformed?
+6464,"@@ -190,6 +190,10 @@ void Host::appendLogsInternal(folly::EventBase* eb,
+             {
+                 std::lock_guard<std::mutex> g(self->lock_);
+                 self->setResponse(r);
++                self->lastLogIdSent_++;
++                if (self->lastLogIdSent_ < self->logIdToSend_) {
++                    ++self->lastLogIdSent_;
++                }
+             }
+             self->noMoreRequestCV_.notify_all();
+             return;",why NOT self->lastLogIdSent_ = self->logIdToSend_
+6465,"@@ -599,6 +599,18 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ 				return reconcile.Result{Requeue: true}, nil
+ 			}
+ 		}
++		// Set the Provisioned status condition for adopted clusters (and in case we upgraded to/past where that condition was introduced)
++		if err := r.updateCondition(
++			cd,
++			hivev1.ProvisionedCondition,
++			corev1.ConditionTrue,
++			hivev1.ProvisionedProvisionedReason,
++			""Cluster is provisioned"",
++			cdLog,
++		); err != nil {
++			cdLog.WithError(err).Error(""Error updating Provisioned status condition"")
++			return reconcile.Result{}, err
++		}
+
+ 		// update SyncSetFailedCondition status condition
+ 		cdLog.Debug(""Check if any syncsets are failing"")",Shouldn't this be in the above `if` block where we are setting the installedtimestamp to ensure this only happens for already installed (and/or adopted) clusters?
+6466,"@@ -422,7 +422,7 @@ class SessionManager(QObject):
+                                         window=window.win_id)
+             tab_to_focus = None
+             for i, tab in enumerate(win['tabs']):
+-                new_tab = tabbed_browser.tabopen()
++                new_tab = tabbed_browser.tabopen(background=False)
+                 self._load_tab(new_tab, tab)
+                 if tab.get('active', False):
+                     tab_to_focus = i",This seems like another unrelated change I've done in `master`.
+6467,"@@ -873,6 +873,15 @@ module RSpec::Core
+           expect(config.formatters.first.output.path).to eq(path)
+         end
+       end
++
++      context ""when a duplicate formatter exists for the same output target"" do
++        it ""does not add the formatter"" do
++          config.add_formatter :documentation
++          expect {
++            config.add_formatter :documentation
++          }.not_to change { config.formatters.length }
++        end
++      end
+     end
+
+     describe ""#filter_run_including"" do","Would be good to have another context `""when a duplicate formatter exists for a different output target""` that shows that it keeps both. As this stands, the specs could pass w/o the `formatter.output == new_formatter.output` check."
+6468,"@@ -217,14 +217,15 @@ void SYCLSharedUSMSpace::deallocate(const char* arg_label,
+                   Kokkos::Tools::make_space_handle(name()));
+ }
+
+-void SYCLDeviceUSMSpace::impl_access_error() {
++KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error() {
+   const std::string msg(
+       ""Kokkos::Experimental::SYCLDeviceUSMSpace::impl_access_error attempt to ""
+       ""execute device function from non-device space"");
+   Kokkos::Impl::throw_runtime_exception(msg);
+ }
+
+-void SYCLDeviceUSMSpace::impl_access_error(const void* const) {
++KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error(
++    const void* const) {
+   impl_access_error();
+ }
+ ",Why not just remove? The CUDA one has been around for while. This one has not been part of any release (?)
+6469,"@@ -83,8 +83,9 @@ public class Session implements ContentBlocking.Delegate, GeckoSession.Navigatio
+     private transient SharedPreferences mPrefs;
+     private transient GeckoRuntime mRuntime;
+     private transient byte[] mPrivatePage;
+-    private transient boolean mFirstContentfulPaint;
++    private transient boolean mFirstContentFulPaint;
+     private transient long mKeepAlive;
++    private transient boolean mIsFirstActivation;
+
+     public interface BitmapChangedListener {
+         void onBitmapChanged(Session aSession, Bitmap aBitmap);","nit: `Contentful` is the word used in the GV API, without the uppercase in F"
+6470,"@@ -83,6 +83,12 @@ public class SchemaMeta extends CommonService<OperationMeta> {
+   }
+
+   private void initOperations() {
++    if (swagger.getPaths() == null) {
++      LOGGER.error(swagger.getInfo().getTitle() + "" with path "" + swagger.getBasePath()
++          + "" is an empty interface, please delete it or fill with one method!"");
++      return;
++    }
++
+     for (Entry<String, Path> entry : swagger.getPaths().entrySet()) {
+       String strPath = entry.getKey();
+       Path path = entry.getValue();","It just does the check, maybe we can name it as checkOperations."
+6471,"@@ -344,7 +344,7 @@ describe('runRules', function() {
+ 		});
+
+ 		fixture.innerHTML =
+-			'<div id=""t1""><span></span></div><div id=""t2""><em></em></div>';
++			'<div id=""t1""><em></em></div><div id=""t2""><em></em></div>';
+
+ 		var $test = {
+ 			0: fixture.querySelector('#t1'),",We no longer have karma output in the test file so these selectors were now unique and the target didn't need a child selector. Updated to force non-unique nodes
+6472,"@@ -1,8 +1,14 @@
++<% content_for :additional_header_links do %>
++  <% if current_user.has_subscription_with_mentor? %>
++    <li class=""mentor"">
++      <%= mentor_image(current_user.mentor) %>
++      <%= mentor_contact_link(current_user.mentor) %>
++    </li>
++  <% end %>
++<% end %>
++
+ <section class=""workshops vertical-slider revealed"">
+-  <figure class=""meta product-card"">
+-    <%= render 'mentor' %>
+-    <%= render 'trails' %>
+-  </figure>
++  <%= render 'trails' %>
+   <%= render partial: 'products/workshop', collection: online_workshops %>
+   <%= render partial: 'products/workshop', collection: in_person_workshops %>
+ </section>",This moved from a partial to not being in a partial. How about cleaning this view up further by moving it back into a partial?
+6473,"@@ -42,6 +42,7 @@ func NewLightweightInformer(
+ 	objType runtime.Object,
+ 	resync time.Duration,
+ 	h cache.ResourceEventHandler,
++	recieveUpdates bool,
+ ) cache.Controller {
+ 	cacheStore := cache.NewIndexer(cache.DeletionHandlingMetaNamespaceKeyFunc, cache.Indexers{})
+ 	fifo := cache.NewDeltaFIFOWithOptions(cache.DeltaFIFOOptions{",add some form of docs in docstring or on :74 for what the effect is
+6474,"@@ -13,7 +13,8 @@ from kinto.core.storage import (
+     StorageBase,
+     exceptions,
+ )
+-from kinto.core.utils import COMPARISON, find_nested_value, json
++from kinto.core.utils import COMPARISON, find_nested_value
++import json
+
+
+ def tree():",Couldn't you import `json` from `kinto.core.utils` here too?
+6475,"@@ -8,6 +8,9 @@ require 'rspec/rails'
+ require 'steps/user_steps'
+ require 'steps/approval_steps'
+
++# mimic production env for view+mail
++ENV[""DISABLE_SANDBOX_WARNING""] = 'true'
++
+ # Requires supporting ruby files with custom matchers and macros, etc, in
+ # spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+ # run as spec files by default. This means that files in spec/support that end",Minor: Hmmm...is it worth setting this explicitly for the tests that it affects?
+6476,"@@ -42,7 +42,6 @@ using namespace eprosima::fastrtps::rtps;
+
+ StatefulReader::~StatefulReader()
+ {
+-    std::lock_guard<std::recursive_timed_mutex> guard(mp_mutex);
+     logInfo(RTPS_READER,""StatefulReader destructor."");
+     is_alive_ = false;
+ ","This was added to fix a race condition and you are reverting it here, right?"
+6477,"@@ -2,11 +2,16 @@ package commands
+
+ import (
+ 	""context""
++	""fmt""
+
+ 	""github.com/ledgerwatch/turbo-geth/common""
+ )
+
+-// Etherbase is the address that mining rewards will be send to
++// Coinbase is the address that mining rewards will be sent to
+ func (api *APIImpl) Coinbase(_ context.Context) (common.Address, error) {
++	if api.ethBackend == nil {
++		// We're running in --chaindata mode or otherwise cannot get the backend
++		return common.Address{}, fmt.Errorf(""eth_coinbase function is not available"")
++	}
+ 	return api.ethBackend.Etherbase()
+ }","Could you add some extra text here, so that it reads ""eth_coinbase function is not available, please use --private.api.addr option instead of --chaindata option"", so that it is clear that the function can work, but different options"
+6478,"@@ -159,6 +159,19 @@ feature 'Creating an NCR work order' do
+       expect(page).to have_content('$2,000 for construction')
+     end
+
++    scenario ""selecting Expense Type toggles Building required flag"", :js do
++      login_as(requester)
++      visit ""/ncr/work_orders/new""
++      find(""#ncr_work_order_expense_type_ba60"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to_not match('required')
++      find(""#ncr_work_order_expense_type_ba61"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to match('required')
++      find(""#ncr_work_order_expense_type_ba80"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to match('required')
++      find(""#ncr_work_order_expense_type_ba60"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to_not match('required')
++    end
++
+     scenario 'defaults to no approver if there was no previous request' do
+       login_as(requester)
+       visit '/ncr/work_orders/new'",`new_ncr_work_order_path` ? (I've been slowly moving specs over to that way of calling paths)
+6479,"@@ -15,7 +15,9 @@
+                         application/javascript
+                         text/css
+                         image/*
+-                        application/x-shockwave-flash
++                        application/x-shockwave-flash ?
++                        font/*
++                        application/font-*
+         ~h rex      Header line in either request or response
+         ~hq rex     Header in request
+         ~hs rex     Header in response",Should flash be included in the patterns too? It currently isn't.
+6480,"@@ -18,7 +18,7 @@ namespace Microsoft.Cci.Differs.Rules
+             if (impl.IsEffectivelySealed() && !contract.IsEffectivelySealed())
+             {
+                 differences.AddIncompatibleDifference(this,
+-                    ""Type '{0}' is sealed in the implementation but not sealed in the contract."", impl.FullName());
++                    $""Type '{impl.FullName()}' is sealed in the {Right} but not sealed in the {Left}."");
+
+                 return DifferenceType.Changed;
+             }",I suspect I will have to keep looking whether Left/Right refers to contract/Implementation while working on the rules code.
+6481,"@@ -76,7 +76,7 @@ namespace AutoRest.CSharp.Azure
+                     if (model.Extensions.ContainsKey(AzureExtensions.AzureResourceExtension) &&
+                         (bool)model.Extensions[AzureExtensions.AzureResourceExtension])
+                     {
+-                        model.BaseModelType = new CompositeType { Name = ""IResource"", SerializedName = ""IResource"" };
++                        model.BaseModelType = new CompositeType { Name = ""Microsoft.Rest.Azure.IResource"", SerializedName = ""Microsoft.Rest.Azure.IResource"" };
+                     }
+                 }
+             }",(ignore this. testing a codeflow bug)
+6482,"@@ -137,9 +137,9 @@ func buildCLIOptions() *cli.App {
+ 			EnvVar: ""CASSANDRA_TLS_CA"",
+ 		},
+ 		cli.BoolFlag{
+-			Name:   schema.CLIFlagTLSEnableHostVerification,
+-			Usage:  ""TLS host verification"",
+-			EnvVar: ""CASSANDRA_TLS_VERIFY_HOST"",
++			Name:   schema.CLIFlagTLSDisableHostVerification,
++			Usage:  ""Cassandra tls verify server hostname"",
++			EnvVar: ""CASSANDRA_TLS_DISABLE_HOST_VERIFICATION"",
+ 		},
+ 	}
+ ","[Nit] can you change the Usage wording to indicate that the flag is used to opt-out of server certificate verification? (e.g. ""disables validation of the Cassandra cluster's server certificate."")"
+6483,"@@ -14,6 +14,8 @@
+ package zipkin.storage.elasticsearch;
+
+ import com.google.common.base.Throwables;
++import java.io.IOException;
++import java.util.List;
+ import zipkin.DependencyLink;
+ import zipkin.Span;
+ import zipkin.internal.MergeById;","Sorry :) Would be really helpful to integrate something like Eclipse Code Formatter, so it will fail if the code style is broken (the same as eslint fails on the frontend) I use IntelliJ IDEA and their vision of imports is a bit different :)"
+6484,"@@ -362,7 +362,17 @@ module Beaker
+       block_on host do |host|
+         if host['platform'] =~ /centos|el-|redhat|fedora/
+           logger.debug(""Disabling iptables on #{host.name}"")
+-          host.exec(Command.new(""sudo su -c \""/etc/init.d/iptables stop\""""), {:pty => true})
++          if host.exec(Command.new('whoami')).stdout.chomp =~ /root/ #don't need to sudo if we are root
++            if host.check_for_command('iptables') #is iptables even installed?
++              host.exec(Command.new(""/etc/init.d/iptables stop""))
++            else
++              logger.warn(""iptables not installed on #{host.name} (#{host['platform']})"")
++            end
++          else
++            if host.exec(Command.new(""sudo su -c \""/etc/init.d/iptables stop\""""), {:pty => true, :acceptable_exit_codes => (0..255)}).exit_code != '0'
++              logger.warn(""failed to disable iptables on #{host.name} (#{host['platform']})"")
++            end
++          end
+         else
+           logger.warn(""Attempting to disable iptables on non-supported platform: #{host.name}: #{host['platform']}"")
+         end",this will still fail on systemd
+6485,"@@ -3760,6 +3760,8 @@ class RDSConnection(AWSQueryConnection):
+                                      path='/', params=params)
+         body = response.read()
+         boto.log.debug(body)
++        if type(body) == bytes:
++            body = body.decode('utf-8')
+         if response.status == 200:
+             return json.loads(body)
+         else:","The convention in most of the codebase is to use `if isinstance(body, bytes):` instead."
+6486,"@@ -249,7 +249,9 @@ class ConsoleUI(wx.Frame):
+ 		if self.completionAmbiguous:
+ 			menu = wx.Menu()
+ 			for comp in completions:
+-				item = menu.Append(wx.ID_ANY, comp)
++				# Only show text after the last dot (so as to not keep repeting the class or module in the context menu)
++				label=comp.split('.')[-1]
++				item = menu.Append(wx.ID_ANY, label)
+ 				self.Bind(wx.EVT_MENU,
+ 					lambda evt, completion=comp: self._insertCompletion(original, completion),
+ 					item)","I think this would be better as: `label = comp.rsplit('.', 1)[-1]`"
+6487,"@@ -57,8 +57,8 @@ public class RubyProvider {
+   }
+
+   @SuppressWarnings(""unchecked"")
+-  public <Element> GeneratedResult generate(
+-      Element element, SnippetDescriptor snippetDescriptor, RubyGapicContext context) {
++  public <Element, ContextT> GeneratedResult generate(
++      Element element, SnippetDescriptor snippetDescriptor, ContextT context) {
+     ImmutableMap<String, Object> globalMap =
+         ImmutableMap.<String, Object>builder().put(""context"", context).build();
+     RubySnippetSet<Element> snippets =",We have been creating a language-level context interface for each language instead of parameterizing the generate function.
+6488,"@@ -21,6 +21,6 @@ class UuidGenerator implements GeneratorInterface
+     {
+         $id = (string) $media->getId();
+
+-        return sprintf('%s/%04s/%02s', $media->getContext(), substr($id, 0, 4), substr($id, 4, 2));
++        return sprintf('%s/%04s/%02s', $media->getContext() ?? '', substr($id, 0, 4), substr($id, 4, 2));
+     }
+ }",Same thing about context here.
+6489,"@@ -634,9 +634,16 @@ func (handler *workflowTaskHandlerImpl) handleCommandContinueAsNewWorkflow(
+ 		return handler.failCommand(enumspb.WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND, nil)
+ 	}
+
++	namespaceEntry, err := handler.namespaceCache.GetNamespaceByID(handler.mutableState.GetExecutionInfo().NamespaceId)
++	if err != nil {
++		return err
++	}
++	namespace := namespaceEntry.GetInfo().Name
++
+ 	if err := handler.validateCommandAttr(
+ 		func() error {
+ 			return handler.attrValidator.validateContinueAsNewWorkflowExecutionAttributes(
++				namespace,
+ 				attr,
+ 				handler.mutableState.GetExecutionInfo(),
+ 			)",there is a function to get namespace entry from mutable state directly
+6490,"@@ -191,7 +191,7 @@ module Bolt
+         hiera_config: @hiera_config,
+         plan_vars: plan_vars,
+         # This data isn't available on the target config hash
+-        config: @inventory.config.transport_data_get
++        config: @inventory.transport_data_get
+       }
+
+       description = options[:description] || 'apply catalog'",The `Transport::Config` objects don't serialize properly. We probably want to just turn them into hashes at this point.
+6491,"@@ -251,11 +251,11 @@ const ConfigInstructions = `
+ # These values specify the destination directory for ddev ssh and the
+ # directory in which commands passed into ddev exec are run.
+
+-# omit_containers: [""dba"", ""ddev-ssh-agent""]
+-# would omit the dba (phpMyAdmin) and ddev-ssh-agent containers. Currently
+-# only those two containers can be omitted here.
+-# Note that these containers can also be omitted globally in the
+-# ~/.ddev/global_config.yaml or with the ""ddev config global"" command.
++# omit_containers: [""db"", dba"", ""ddev-ssh-agent""]
++# Currently only these containers are supported. Some containers can also be
++# omitted globally in the ~/.ddev/global_config.yaml. Note that if you omit
++# the ""db"" container, several standard features of ddev that access the
++# database container will be unusuable.
+
+ # nfs_mount_enabled: false
+ # Great performance improvement but requires host configuration first.","Sorry, typo s/unusuable/unusable/"
+6492,"@@ -242,6 +242,13 @@ public class SparkSessionCatalog<T extends TableCatalog & SupportsNamespaces>
+
+   @Override
+   public final void initialize(String name, CaseInsensitiveStringMap options) {
++    if (options.containsKey(""type"") && options.get(""type"").equalsIgnoreCase(""hive"") && options.containsKey(""uri"")) {
++      throw new UnsupportedOperationException(""Cannot set an alternative uri when"" +
++              "" using the SparkSessionCatalog, "" +
++              ""make an alternative SparkCatalog if the "" +
++              ""Spark Session catalog and Iceberg "" +
++              ""catalog should contact different metastores."");
++    }
+     this.catalogName = name;
+     this.icebergCatalog = buildSparkCatalog(name, options);
+     if (icebergCatalog instanceof StagingTableCatalog) {","If this is needed, should we check that the configured `uri` isn't already equal to the value of the metastore URI configured via `spark.hadoop.hive.metastore.uris` or any of the other ways of setting it. This would be a breaking change for people who have `uri` configured on the SparkSessionCatalog and have it correctly set (which I believe should be everybody as `uri` is currently required if I'm not mistaken)."
+6493,"@@ -21,4 +21,7 @@ class ViewMultipart(base.View):
+             return ""Multipart form"", self._format(v)
+
+     def render_priority(self, data: bytes, *, content_type: Optional[str] = None, **metadata) -> float:
+-        return float(content_type == ""multipart/form-data"")
++        if content_type and content_type.startswith(""multipart/form-data""):
++            return 1
++        else:
++            return 0","see above - this is only used to select the correct view, we don't need to handle the boundary information here."
+6494,"@@ -555,6 +555,7 @@ func TestSign(t *testing.T) {
+ 								LastTransitionTime: &metaFixedClockStart,
+ 							}),
+ 							gen.SetCertificateRequestCertificate(certPEM),
++							gen.SetCertificateRequestCA(certPEM),
+ 							gen.AddCertificateRequestAnnotations(map[string]string{cmapi.VenafiPickupIDAnnotationKey: ""test""}),
+ 						),
+ 					)),","These tests use a self-signed cert so the CA *is* the cert. I considered making a proper chain to use in the tests, but wasn't sure it was necessary to test here, since we test it in the E2E tests anyway."
+6495,"@@ -212,6 +212,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+
+ 	if (newVNode.type===null) {
+ 		if (oldProps !== newProps) {
++			if (excessDomChildren!=null) {
++				const index = excessDomChildren.indexOf(dom);
++				if (index > -1) excessDomChildren[index] = null;
++			}
+ 			dom.data = newProps;
+ 		}
+ 	}","We could, maybe, just directly do `excessDomChildren[excessDomChildren.indexOf(dom)] = null;`. Would this improve the size in any way? This will end-up with a property on the `excessDomChildren[""-1""]` but maybe we could live with that?"
+6496,"@@ -1278,6 +1278,11 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC
+     for ( var i = mouseWheeltoBind.length; i; ) {
+       $elm.on(mouseWheeltoBind[--i], cbs[fn]);
+     }
++    $elm.on('$destroy', function unbindEvents() {
++      for ( var i = mouseWheeltoBind.length; i; ) {
++        $elm.off(mouseWheeltoBind[--i], cbs[fn]);
++      }
++    });
+   };
+   s.off.mousewheel = function (elm, fn) {
+     var $elm = angular.element(elm);",this looks like it may be something that needs additional refactoring
+6497,"@@ -300,7 +300,7 @@ class Resource(object):
+                 for resource in yielder.iter():
+                     res = resource
+                     new_stack = stack + [self]
+-
++
+                     # Parallelization for resource subtrees.
+                     if res.should_dispatch():
+                         callback = partial(res.try_accept, visitor, new_stack)",Nit: Remove whitespace (and below)
+6498,"@@ -205,7 +205,10 @@ return [
+         'error_moving_file' => 'Error moving file :file',
+         'error_moving_directory' => 'Error moving directory :dir',
+         'error_deleting_directory' => 'Error deleting the original directory :dir',
+-        'path' => 'Path'
++        'path' => 'Path',
++        'unzip' => 'Unzip',
++        'is_a_directory' => 'Only files are allowed. You\'ve selected a directory.',
++        'error_open_zip' => 'Error open the zip file'
+     ],
+     'component' => [
+         'menu_label' => 'Components',","""Failed opening"" or ""Failed to open""."
+6499,"@@ -131,8 +131,12 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError {
+ 		if _, err := s.w.images.regUse(d.SourceImage, s); err != nil {
+ 			errs = addErrs(errs, Errf(""%s: can't use image %q: %v"", pre, d.SourceImage, err))
+ 		}
++	} else if d.SourceSnapshot != """" {
++		if _, err := s.w.snapshots.regUse(d.SourceSnapshot, s); err != nil {
++			errs = addErrs(errs, Errf(""%s: can't use snapshot %q: %v"", pre, d.SourceSnapshot, err))
++		}
+ 	} else if d.Disk.SizeGb == 0 {
+-		errs = addErrs(errs, Errf(""%s: SizeGb and SourceImage not set"", pre))
++		errs = addErrs(errs, Errf(""%s: SizeGb, SourceSnapshot or SourceImage not set"", pre))
+ 	}
+
+ 	// Register creation.",and -> or
+6500,"@@ -683,5 +683,17 @@ describe('model', function() {
+         yield User.collection.drop();
+       });
+     });
++    it('should do a dryRun feat-10316', function() {
++      return co(function*() {
++        const userSchema = new mongoose.Schema({ username: String }, { password: String }, { email: String });
++        userSchema.index({ password: 1 });
++        userSchema.index({ email: 1 });
++        const User = db.model('Upson', userSchema);
++        yield User.collection.createIndex({ age: 1 });
++        const result = yield User.diffIndexes();
++        assert.deepStrictEqual(result.toDrop, ['age_1']);
++        assert.deepStrictEqual(result.toCreate, [{ password: 1 }, { email: 1 }]);
++      });
++    });
+   });
+ });",Add a `yield User.init()` here to wait for all indexes to finish building
+6501,"@@ -11,6 +11,8 @@
+ #include <ifaddrs.h>
+ #include <arpa/inet.h>
+
++DEFINE_string(local_ip, """", ""local ip"");
++
+ namespace nebula {
+ namespace network {
+ ","I don't think this belongs here. If the application can take a local_ip as input, the application should take care of it, not in this common library"
+6502,"@@ -524,6 +524,17 @@ class Theme
+         return ThemeData::forTheme($this);
+     }
+
++    /**
++     * Remove data specific to this theme
++     * @return bool
++     */
++    public function removeCustomData()
++    {
++        if ($this->hasCustomData()) {
++            return $this->getCustomData()->delete();
++        }
++    }
++
+     /**
+      * Checks to see if the database layer has been enabled
+      *","@DanHarrin please add a `return true` at the bottom of this method, as the docblock indicates a boolean return value."
+6503,"@@ -25,7 +25,7 @@ import org.apache.lucene.index.SlowImpactsEnum;
+
+ /** Expert: A <code>Scorer</code> for documents matching a <code>Term</code>.
+  */
+-final class TermScorer extends Scorer {
++public final class TermScorer extends Scorer {
+   private final PostingsEnum postingsEnum;
+   private final ImpactsEnum impactsEnum;
+   private final DocIdSetIterator iterator;",This is used in o.a.l.sandbox.search.BM25FQuery.
+6504,"@@ -41,7 +41,8 @@ public class XYShapeBoundingBoxQuery extends ShapeQuery {
+   @Override
+   protected PointValues.Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
+                                                         int maxXOffset, int maxYOffset, byte[] maxTriangle) {
+-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
++    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
++        queryRelation == QueryRelation.INTERSECTS);
+   }
+
+   /** returns true if the query matches the encoded triangle */",Shouldn't this work as well for Disjoint?
+6505,"@@ -50,6 +50,9 @@ class TestCase(unittest.TestCase):
+       for nm, fn in Descriptors._descList:
+         try:
+           v = fn(m)
++        except RuntimeError:
++          # 3D descriptors fail since the mol has no conformers
++          pass
+         except Exception:
+           import traceback
+           traceback.print_exc()","Same here. This was included to quiet the test for the 3D descriptors. As we removed them, this exception handling is no longer required"
+6506,"@@ -26,6 +26,7 @@
+
+ #include ""lbann/utils/lbann_library.hpp""
+ #include ""lbann/callbacks/callback_checkpoint.hpp""
++#include ""lbann/data_store/data_store_jag.hpp""
+
+ namespace lbann {
+ ",Why do you need to load a specific data reader in lbann_library?
+6507,"@@ -31,10 +31,10 @@ namespace Nethermind.Runner.Ethereum.Steps
+             _context = context;
+         }
+
+-        public ValueTask Execute()
++        public Task Execute()
+         {
+             _context.ChainSpec.Bootnodes = _context.ChainSpec.Bootnodes?.Where(n => !n.NodeId?.Equals(_context.NodeKey.PublicKey) ?? false).ToArray() ?? new NetworkNode[0];
+-            return default;
++            return Task.CompletedTask;
+         }
+     }
+ }",why not ValueTask?
+6508,"@@ -422,7 +422,7 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ 		return reconcile.Result{Requeue: true}, nil
+ 	}
+
+-	if cd.Status.InstallerImage == nil {
++	if !cd.Status.Installed && (cd.Status.InstallerImage == nil || cd.Status.CLIImage == nil) {
+ 		return r.resolveInstallerImage(cd, imageSet, releaseImage, hiveImage, cdLog)
+ 	}
+ ","I'm nervous about this line, I don't want to go regenerate a bunch of imageset jobs for clusters that are old, already installed, but don't have a CLIImage set (which they wouldn't because they're old) Adding the Installed guard is meant to address this. Otherwise this *should* recreate the imageset job due to the code in this function that deletes the job if it's finished. (but we don't have our images set due to this clause)"
+6509,"@@ -303,7 +303,8 @@ public class HadoopTables implements Tables, Configurable {
+       }
+
+       Map<String, String> properties = propertiesBuilder.build();
+-      TableMetadata metadata = tableMetadata(schema, spec, sortOrder, properties, location);
++
++      TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, sortOrder, location, properties);
+       ops.commit(null, metadata);
+       return new BaseTable(ops, location);
+     }",Is it necessary to change this file? Doesn't `tableMetadata` call `newTableMetadata`?
+6510,"@@ -78,12 +78,6 @@ func TestCatchupOverGossip(t *testing.T) {
+ 	t.Parallel()
+ 	// ledger node upgraded version, fetcher node upgraded version
+ 	runCatchupOverGossip(t, false, false)
+-	// ledger node older version, fetcher node upgraded version
+-	runCatchupOverGossip(t, true, false)
+-	// ledger node upgraded older version, fetcher node older version
+-	runCatchupOverGossip(t, false, true)
+-	// ledger node older version, fetcher node older version
+-	runCatchupOverGossip(t, true, true)
+ }
+
+ func runCatchupOverGossip(t *testing.T,","I think that I have a better proposal for this test - improve it so that it would know how to read the list of SupportedProtocolVersions and dynamically use these. The motivation here is that I expect to have another network version soon, and this test seems to be a good test case for that."
+6511,"@@ -89,10 +89,13 @@ public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, Supp
+
+     try {
+       List<String> tables = clients.run(client -> client.getAllTables(database));
+-      return tables.stream()
++      List<TableIdentifier> tableIdentifiers = tables.stream()
+           .map(t -> TableIdentifier.of(namespace, t))
+           .collect(Collectors.toList());
+
++      LOG.debug(""Listing of namespace [{}] resulted in the following tables: [{}]"", namespace, tableIdentifiers);
++      return tableIdentifiers;
++
+     } catch (UnknownDBException e) {
+       throw new NoSuchNamespaceException(""Namespace does not exist: %s"", namespace);
+ ",What is the purpose of this debug message? I'm not sure how it would help.
+6512,"@@ -25,7 +25,6 @@ import (
+ 	""time""
+
+ 	""kythe.io/kythe/go/extractors/bazel""
+-	""kythe.io/kythe/go/extractors/bazel/extutil""
+ )
+
+ var (",Is there a corresponding BUILD dependency to prune?
+6513,"@@ -2066,7 +2066,14 @@ func testSignedURL(t *testing.T, newHarness HarnessMaker) {
+ 	}
+ 	getURLNoParamsURL.RawQuery = """"
+ 	getURLNoParams := getURLNoParamsURL.String()
+-	putURL, err := b.SignedURL(ctx, key, &blob.SignedURLOptions{Method: http.MethodPut})
++	const (
++		goodContentType = ""text/plain""
++		badContentType  = ""application/octet-stream""
++	)
++	putURL, err := b.SignedURL(ctx, key, &blob.SignedURLOptions{
++		Method:      http.MethodPut,
++		ContentType: goodContentType,
++	})
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	} else if putURL == """" {","The ""good"" and ""bad"" descriptions confused me a bit. Maybe `allowedContentType` and `disallowedContentType`? Not sure if that's better."
+6514,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())
+6515,"@@ -106,11 +106,11 @@ func TestServerRoutesWithAuthAndBCrypt(t *testing.T) {
+ 	srvB := RunServer(optsB)
+ 	defer srvB.Shutdown()
+
+-	urlA := fmt.Sprintf(""nats://%s:%d/"", optsA.Host, optsA.Port)
+-	urlB := fmt.Sprintf(""nats://%s:%d/"", optsB.Host, optsB.Port)
++	urlA := fmt.Sprintf(""nats://%s:%s@%s:%d/"", optsA.Username, optsA.Password, optsA.Host, optsA.Port)
++	urlB := fmt.Sprintf(""nats://%s:%s@%s:%d/"", optsB.Username, optsB.Password, optsB.Host, optsB.Port)
+
+ 	// Wait for route to form.
+-	time.Sleep(250 * time.Millisecond)
++	time.Sleep(4 * time.Second)
+
+ 	nc1, err := nats.Connect(urlA)
+ 	if err != nil {","You may want to have a look at `func checkClusterFormed(t *testing.T, servers ...*Server)` in this file that I created some time ago. It will timeout at 5 seconds, but will return as soon as cluster is ready."
+6516,"@@ -662,8 +662,14 @@ static void push_cb (flux_t *h, flux_msg_handler_t *mh,
+         aggregate_sink (h, ag);
+     rc = 0;
+ done:
+-    if (flux_respond (h, msg, rc < 0 ? saved_errno : 0, NULL) < 0)
+-        flux_log_error (h, ""aggregator.push: flux_respond"");
++    if (rc < 0) {
++        if (flux_respond_error (h, msg, saved_errno, NULL) < 0)
++            flux_log_error (h, ""aggregator.push: flux_respond_error"");
++    }
++    else {
++        if (flux_respond (h, msg, NULL) < 0)
++            flux_log_error (h, ""aggregator.push: flux_respond"");
++    }
+ }
+
+ ","I see a few places where this blob of code is required due to the removal of `errnum` parameter from `flux_respond` -- trading 2 lines of code for 8. The improvement to the function seems like a good idea, but I wonder if we need a convenience macro or function to do it the old way? You went through and made all the changes, was it overall a net win?"
+6517,"@@ -23,9 +23,9 @@
+  */
+ import {
+ 	appendNotificationsCount,
+-	sendAnalyticsTrackingEvent,
+ 	getQueryParameter,
+ } from './util/standalone';
++import { trackEvent } from './util/tracking';
+
+ // Set webpackPublicPath on-the-fly.
+ if ( global.googlesitekitAdminbar && global.googlesitekitAdminbar.publicPath ) {","I know it's not related to your change, but it's a bit odd that this import uses a relative path rather than the ones setup by webpack. Might be nice to change this one in case we refactor those paths in the future; this one wouldn't get caught in any kind of find+replace."
+6518,"@@ -86,7 +86,8 @@ func (c *Config) Start() {
+
+ 	for _, schedule := range c.Scheduler.Schedules {
+ 		helper.ControllerWg.Add(1)
+-		go schedule.ExecuteSchedule(c.ActionManager.Actions, c.Converter.DataRead, c.Device.ID)
++		newSchedule := schedule
++		go newSchedule.ExecuteSchedule(c.ActionManager.Actions, c.Converter.DataRead, c.Device.ID)
+ 	}
+ 	helper.ControllerWg.Wait()
+ }","Good catch, and if we don't declare the newSchedule here, will the last schedule be executed in multi goroutine?"
+6519,"@@ -879,6 +879,7 @@ partial class Build
+                 .Concat(includeSecurity)
+                 .Select(x => Solution.GetProject(x))
+                 .Where(project =>
++                project != null &&
+                 (project, project.TryGetTargetFrameworks()) switch
+                 {
+                     _ when exclude.Contains(project.Path) => false,","`project` should never be null here, unless we have projects that aren't in the solution? Which we shouldn't have  "
+6520,"@@ -1,13 +1,18 @@
+ #include ""extractor/graph_compressor.hpp""
+
+ #include ""extractor/compressed_edge_container.hpp""
+-#include ""extractor/restriction_map.hpp""
++#include ""extractor/restriction.hpp""
++#include ""extractor/restriction_compressor.hpp""
++
+ #include ""util/dynamic_graph.hpp""
+ #include ""util/node_based_graph.hpp""
+ #include ""util/percent.hpp""
+
+ #include ""util/log.hpp""
+
++#include <boost/assert.hpp>
++#include <unordered_set>
++
+ namespace osrm
+ {
+ namespace extractor",Simple `for` loop instead of `for_each` would help here by making it more readable.
+6521,"@@ -96,6 +96,8 @@ namespace thread_role
+ 			case nano::thread_role::name::signature_checking:
+ 				thread_role_name_string = ""Signature check"";
+ 				break;
++			case nano::thread_role::name::confirmation_height_processing:
++				thread_role_name_string = ""Conf height"";
+ 		}
+
+ 		/*","Looks like this falls through, should break."
+6522,"@@ -73,6 +73,7 @@ class ManifestListWriter implements FileAppender<ManifestFile> {
+           .schema(ManifestFile.schema())
+           .named(""manifest_file"")
+           .meta(meta)
++          .overwrite(false)
+           .build();
+
+     } catch (IOException e) {",Let's default manifest lists and manifests to overwrite. These use UUID-based file names and should never conflict.
+6523,"@@ -135,6 +135,9 @@ confspec = ConfigObj(StringIO(
+ 	audioCoordinates_maxPitch = integer(default=880)
+ 	reportMouseShapeChanges = boolean(default=false)
+
++[speechView]
++	showSpeechViewerAtStartup = boolean(default=false)
++
+ #Keyboard settings
+ [keyboard]
+ 	useCapsLockAsNVDAModifierKey = boolean(default=false)",Please rename [speechView] to [speechViewer].
+6524,"@@ -20,6 +20,12 @@ type CpuUsage struct {
+ 	// Total CPU time consumed per core.
+ 	// Units: nanoseconds.
+ 	PercpuUsage []uint64 `json:""percpu_usage,omitempty""`
++	// CPU time consumed per core in kernel mode
++	// Units: nanoseconds.
++	PercpuUsageInKernelmode []uint64 `json:""percpu_usage_in_kernelmode""`
++	// CPU time consumed per core in user mode
++	// Units: nanoseconds.
++	PercpuUsageInUsermode []uint64 `json:""percpu_usage_in_usermode""`
+ 	// Time spent by tasks of the cgroup in kernel mode.
+ 	// Units: nanoseconds.
+ 	UsageInKernelmode uint64 `json:""usage_in_kernelmode""`","I would use shorter yet still descriptive names, e.g. `KernelPerCpu` and `UserPerCpu`."
+6525,"@@ -5017,7 +5017,7 @@ def print_record(recID, format='hb', ot='', ln=CFG_SITE_LANG, decompress=zlib.de
+         display_claim_this_paper = False
+
+     can_edit_record = False
+-    if check_user_can_edit_record(user_info, recID):
++    if  not (format.lower().startswith('t')) and check_user_can_edit_record(user_info, recID):
+         can_edit_record = True
+
+     out = """"","if we are seeking for the content of only one field from metadata, no need to check whether a user could edit record or not"
+6526,"@@ -25,3 +25,4 @@ class ChromeRemoteConnection(RemoteConnection):
+         self._commands[""launchApp""] = ('POST', '/session/$sessionId/chromium/launch_app')
+         self._commands[""setNetworkConditions""] = ('POST', '/session/$sessionId/chromium/network_conditions')
+         self._commands[""getNetworkConditions""] = ('GET', '/session/$sessionId/chromium/network_conditions')
++        self._commands['ExecuteCDP'] = ('POST', '/session/$sessionId/goog/cdp/execute')",Should this be camelCase to match the above commands? I am not the expert here so maybe Lucas or David can chime in.
+6527,"@@ -254,7 +254,8 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+                 scope = tracer.StartActive(ValidateOperationName, serviceName: serviceName);
+                 var span = scope.Span;
+                 span.Type = SpanTypes.GraphQL;
+-
++                span.SetTag(Tags.SpanKind, SpanKinds.Server);
++                span.SetTag(Tags.Language, TracerConstants.Language);
+                 span.SetTag(Tags.GraphQLSource, source);
+
+                 // set analytics sample rate if enabled",This is also missing in CreateScopeFromExecuteAsync. Can you add that there too?
+6528,"@@ -30,9 +30,12 @@ public class DateUtils {
+         }
+         String date = input.trim().replace('/', '-').replaceAll(""( ){2,}+"", "" "");
+
++        // remove colon from timezone to avoid differences between Android and Java SimpleDateFormat
++        date = date.replaceAll(""([+-]\\d\\d):(\\d\\d)$"", ""$1$2"");
++
+         // CEST is widely used but not in the ""ISO 8601 Time zone"" list. Let's hack around.
+-        date = date.replaceAll(""CEST$"", ""+02:00"");
+-        date = date.replaceAll(""CET$"", ""+01:00"");
++        date = date.replaceAll(""CEST$"", ""+0200"");
++        date = date.replaceAll(""CET$"", ""+0100"");
+
+         // some generators use ""Sept"" for September
+         date = date.replaceAll(""\\bSept\\b"", ""Sep"");",I hope that this does not break anything... Probably needs detailed beta tests.
+6529,"@@ -1518,6 +1518,17 @@ module RSpec::Core
+       end
+     end
+
++    describe 'recording spec start time (for measuring load)' do
++      it 'returns a time' do
++        expect(config.start_time).to be_an_instance_of ::Time
++      end
++
++      it 'is configurable' do
++        config.start_time = 42
++        expect(config.start_time).to eq 42
++      end
++    end
++
+     # assigns files_or_directories_to_run and triggers post-processing
+     # via `files_to_run`.
+     def assign_files_or_directories_to_run(*value)",@JonRowe in what scenario do you see this being manually set?
+6530,"@@ -307,6 +307,10 @@ void nano::block_processor::process_live (nano::block_hash const & hash_a, std::
+ 			election.election->try_generate_votes (block_a->hash ());
+ 		}
+ 	}
++	else
++	{
++		node.active.check_inactive_votes_cache_election (block_a);
++	}
+
+ 	// Announce block contents to the network
+ 	if (origin_a == nano::block_origin::local)","I think the work ""trigger"" makes more sense than ""check"" because this is taking an action based on status."
+6531,"@@ -41,7 +41,7 @@ public class AuthHandlerBoot implements BootListener {
+       RSAKeypair4Auth.INSTANCE.setPrivateKey(rsaKeyPairEntry.getPrivateKey());
+       RSAKeypair4Auth.INSTANCE.setPublicKey(rsaKeyPairEntry.getPublicKey());
+       RSAKeypair4Auth.INSTANCE.setPublicKeyEncoded(rsaKeyPairEntry.getPublicKeyEncoded());
+-      RegistrationManager.INSTANCE.getMicroserviceInstance().getProperties().put(DefinitionConst.INSTANCE_PUBKEY_PRO,
++      RegistrationManager.INSTANCE.getMicroservice().getProperties().put(DefinitionConst.INSTANCE_PUBKEY_PRO,
+           rsaKeyPairEntry.getPublicKeyEncoded());
+     }
+   }","add a configuration , default put public key in Microservice, if the configuration is set, then put in Instance."
+6532,"@@ -20,8 +20,8 @@ import com.google.common.collect.ImmutableList;
+ public interface OutputView {
+
+   public enum Kind {
+-    ASSIGNMENT,
+     COMMENT,
++    DEFINITION,
+     LOOP,
+     PRINT
+   }",WDYT about the idea above of making these all verbs that correspond to the input spec?
+6533,"@@ -77,7 +77,7 @@ import static com.fsck.k9.mail.K9MailLib.PUSH_WAKE_LOCK_TIMEOUT;
+  * </pre>
+  */
+ public class ImapStore extends RemoteStore {
+-    public static final String STORE_TYPE = ""IMAP"";
++    public static final ServerSettings.Type STORE_TYPE = ServerSettings.Type.IMAP;
+
+     private static final int IDLE_READ_TIMEOUT_INCREMENT = 5 * 60 * 1000;
+     private static final int IDLE_FAILURE_COUNT_LIMIT = 10;",With the introduction of the enum(s) the constants in the store classes should be removed.
+6534,"@@ -455,6 +455,12 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		}
+ 	}
+
++	// Drop packets with IP options
++	if (ip_header->ihl > 5) {
++		fwd.reason = CALI_REASON_IP_OPTIONS;
++		CALI_DEBUG(""Drop packets with IP options\n"");
++		goto deny;
++	}
+ 	// Setting all of these up-front to keep the verifier happy.
+ 	struct tcphdr *tcp_header = (void*)(ip_header+1);
+ 	struct udphdr *udp_header = (void*)(ip_header+1);",I would say `!= 5`; A packet with <5 would be malformed.
+6535,"@@ -60,7 +60,7 @@ func New(selector export.AggregationSelector, exporter export.Exporter, opts ...
+ 		c.Timeout = c.Period
+ 	}
+
+-	integrator := simple.New(selector, c.Stateful)
++	integrator := simple.New(selector, exporter)
+ 	impl := sdk.NewAccumulator(
+ 		integrator,
+ 		sdk.WithResource(c.Resource),",I think you missed removing `Stateful` from `push/config.go`
+6536,"@@ -29,7 +29,7 @@ namespace Nethermind.Db.Databases
+         {
+         }
+
+-        protected override void UpdateReadMetrics() => Metrics.EthRequestsDbReads++;
+-        protected override void UpdateWriteMetrics() => Metrics.EthRequestsDbWrites++;
++        protected internal override void UpdateReadMetrics() => Metrics.EthRequestsDbReads++;
++        protected internal override void UpdateWriteMetrics() => Metrics.EthRequestsDbWrites++;
+     }
+ }",why would you make it internal? if so then at least protected internal
+6537,"@@ -502,6 +502,18 @@ class TestHttps2Http(tservers.ReverseProxTest):
+ class TestTransparent(tservers.TransparentProxTest, CommonMixin, TcpMixin):
+     ssl = False
+
++    def test_tcp_stream_modify(self):
++        self.master.load_script(
++            tutils.test_data.path(""scripts/tcp_stream_modify.py""))
++
++        self._tcpproxy_on()
++        d = self.pathod('200:b""foo""')
++        self._tcpproxy_off()
++
++        assert d.content == ""bar""
++
++        self.master.unload_scripts()
++
+
+ class TestTransparentSSL(tservers.TransparentProxTest, CommonMixin, TcpMixin):
+     ssl = True","We should check if the response (`d`) contains bar as response, screw the log. :smile:"
+6538,"@@ -538,7 +538,7 @@ void GPUTreeLearner::AllocateGPUMemory() {
+   }
+   // data transfer time
+   std::chrono::duration<double, std::milli> end_time = std::chrono::steady_clock::now() - start_time;
+-  Log::Info(""%d dense feature groups (%.2f MB) transfered to GPU in %f secs. %d sparse feature groups"",
++  Log::Info(""%d dense feature groups (%.2f MB) transferred to GPU in %f secs. %d sparse feature groups"",
+             dense_feature_group_map_.size(), ((dense_feature_group_map_.size() + (dword_features_ - 1)) / dword_features_) * num_data_ * sizeof(Feature4) / (1024.0 * 1024.0),
+             end_time * 1e-3, sparse_feature_group_map_.size());
+   #if GPU_DEBUG >= 1",@Laurae2 good call. This is the only one I found (with `git grep transfered`)
+6539,"@@ -1805,7 +1805,7 @@ class VariablesChecker(BaseChecker):
+         """"""
+         if (
+             node.frame().parent == defstmt
+-            and node.statement(future=True) not in node.frame().body
++            and node.statement(future=True) == node.frame()
+         ):
+             # Check if used as type annotation
+             # Break but don't emit message if postponed evaluation is enabled","I don't understand how this work, could you explain ?"
+6540,"@@ -183,7 +183,7 @@ analyze_callee_regs_usage(dcontext_t *dcontext, callee_info_t *ci)
+     /* XXX implement bitset for optimisation */
+     memset(ci->reg_used, 0, sizeof(bool) * NUM_GP_REGS);
+     ci->num_simd_used = 0;
+-    memset(ci->simd_used, 0, sizeof(bool) * NUM_SIMD_REGS);
++    memset(ci->simd_used, 0, sizeof(bool) * MCTX_NUM_SIMD_SLOTS);
+     ci->write_flags = false;
+
+     num_regparm = MIN(ci->num_args, NUM_REGPARM);","The abbreviation for ""context"" used extensively inside DR is ""cxt"", not ""ctx"", so s/MCTX/MCXT/."
+6541,"@@ -13,5 +13,5 @@ return [
+     */
+
+     'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈ میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing again
+6542,"@@ -40,6 +40,7 @@ public class WebSocketConfiguration {
+   private String authenticationCredentialsFile;
+   private List<String> hostsAllowlist = Arrays.asList(""localhost"", ""127.0.0.1"");
+   private File authenticationPublicKeyFile;
++  private String authenticationAlgorithm = null;
+   private long timeoutSec;
+   private int maxActiveConnections;
+ ",initializing to null makes me uncomfortable. let's have a default value
+6543,"@@ -1129,6 +1129,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+                             }
+                             else if (ch == BytePercentage)
+                             {
++                                if (pathStart == -1)
++                                {
++                                    // Empty path is illegal
++                                    RejectRequestLine(start, end);
++                                }
++
+                                 needDecode = true;
+                             }
+ ",This is the `GET % HTTP/1.1` scenario right?
+6544,"@@ -1,6 +1,7 @@
+ <?php namespace Backend\FormWidgets;
+
+ use App;
++use Backend\Facades\BackendAuth;
+ use File;
+ use Event;
+ use Lang;","No need to use the fully qualified path the BackendAuth facade, just `use BackendAuth` is fine."
+6545,"@@ -357,6 +357,11 @@ bool nano::send_block::valid_predecessor (nano::block const & block_a) const
+ 	return result;
+ }
+
++nano::epoch nano::send_block::epoch () const
++{
++	return nano::epoch::epoch_0;
++}
++
+ nano::block_type nano::send_block::type () const
+ {
+ 	return nano::block_type::send;","Because it's similar for send/open/change/receive types, then probably it can be just common `nano::epoch nano::block::epoch () const` with override for state_block (like nano::block::link (), account (), representative ())"
+6546,"@@ -1,5 +1,6 @@
+ // This is the API that JS files loaded from the webview can see
+ const webviewApiPromises_ = {};
++let cb_ = () => {};
+
+ // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
+ const webviewApi = {",Please give a more descriptive name and add a command to explain what it does.
+6547,"@@ -77,7 +77,8 @@ public class UserPreferences {
+     // Network
+     private static final String PREF_ENQUEUE_DOWNLOADED = ""prefEnqueueDownloaded"";
+     public static final String PREF_UPDATE_INTERVAL = ""prefAutoUpdateIntervall"";
+-    private static final String PREF_MOBILE_UPDATE = ""prefMobileUpdate"";
++    public static final String PREF_MOBILE_UPDATE_OLD = ""prefMobileUpdate"";
++    public static final String PREF_MOBILE_UPDATE = ""prefMobileUpdateAllowed"";
+     public static final String PREF_EPISODE_CLEANUP = ""prefEpisodeCleanup"";
+     public static final String PREF_PARALLEL_DOWNLOADS = ""prefParallelDownloads"";
+     public static final String PREF_EPISODE_CACHE_SIZE = ""prefEpisodeCacheSize"";",we can never get rid of this...
+6548,"@@ -28,8 +28,9 @@ var (
+ 		[]string{""controller"", ""method"", ""resource"", ""remote"", ""status""},
+ 	)
+ 	metricKubeClientRequestSeconds = prometheus.NewHistogramVec(prometheus.HistogramOpts{
+-		Name: ""hive_kube_client_request_seconds"",
+-		Help: ""Length of time for kubernetes client requests."",
++		Name:    ""hive_kube_client_request_seconds"",
++		Help:    ""Length of time for kubernetes client requests."",
++		Buckets: []float64{0.05, 0.1, 0.5, 1, 5, 10, 30, 60, 120},
+ 	},
+ 		[]string{""controller"", ""method"", ""resource"", ""remote"", ""status""},
+ 	)",what is the effect of changing these buckets in existing data that is available in the monitoring system? if there are any existing dashboards that use previous histogram buckets they are probably going to be wrong ot invalid? also any reason why we chose these specific values?
+6549,"@@ -109,4 +109,13 @@
+ //
+ // 	var h handler
+ // 	yarpc.InjectClients(dispatcher, &h)
++//
++// Automatically Sanitizing TChannel Contexts
++//
++// Contexts created with `tchannel.ContextWithHeaders` are incompatible with yarpc clients generated from thrift.
++// Using such a context will cause a yarpc client to error on any call. Using the `sanitize-tchannel` flag will
++// generate a yarpc client such that all tchannel headers from any context supplied are removed before making a yarpc call.
++// the option can be used like so:
++//
++// 	thriftrw --plugin yarpc --sanitize-tchannel myservice.thrift
+ package thrift","This won't work. For the flag to be passed to the plugin, it should be passed as part of the --plugin argument. --plugin ""yarpc --sanitize-tchannel"""
+6550,"@@ -2308,6 +2308,13 @@ int LGBM_BoosterSetLeafValue(BoosterHandle handle,
+   API_END();
+ }
+
++int LGBM_BoosterGetNumFeatures(BoosterHandle handle, int *out_val) {
++  API_BEGIN();
++  Booster* ref_booster = reinterpret_cast<Booster*>(handle);
++  *out_val = ref_booster->GetBoosting()->MaxFeatureIdx() + 1;
++  API_END();
++}
++
+ int LGBM_BoosterFeatureImportance(BoosterHandle handle,
+                                   int num_iteration,
+                                   int importance_type,","@shiyu1994 @StrikerRUS what do you think about this addition to `c_api.cpp`? I think it's a really useful addition to be able to get this type of information from the `Booster`, but I want more opinions since `c_api` is the main public API for the library."
+6551,"@@ -213,6 +213,16 @@ type deferedCommit struct {
+ 	lookback basics.Round
+ }
+
++// RoundOffsetError is an error for when requested round is behind earliest stored db entry
++type RoundOffsetError struct {
++	Round   basics.Round
++	DbRound basics.Round
++}
++
++func (e *RoundOffsetError) Error() string {
++	return fmt.Sprintf(""round %d before dbRound %d"", e.Round, e.DbRound)
++}
++
+ // initialize initializes the accountUpdates structure
+ func (au *accountUpdates) initialize(cfg config.Local, dbPathPrefix string, genesisProto config.ConsensusParams, genesisAccounts map[basics.Address]basics.AccountData) {
+ 	au.initProto = genesisProto","rename Round -> requestedRound and DbRound -> dbRound. we don't need to export the fields here, only the error struct."
+6552,"@@ -1052,6 +1052,18 @@ func TestClusterDeploymentReconcile(t *testing.T) {
+ 				}
+ 			},
+ 		},
++		{
++			name: ""Add cluster region label"",
++			existing: []runtime.Object{
++				testClusterDeploymentWithoutRegionLabel(),
++			},
++			validate: func(c client.Client, t *testing.T) {
++				cd := getCD(c)
++				if assert.NotNil(t, cd, ""missing clusterdeployment"") {
++					assert.Equal(t, getClusterRegion(cd), cd.Labels[hivev1.HiveClusterRegionLabel], ""incorrect cluster region label"")
++				}
++			},
++		},
+ 		{
+ 			name: ""Ensure cluster metadata set from provision"",
+ 			existing: []runtime.Object{","This expected value should probably be what you literally expect, otherwise there's a chance getClusterRegion is doing something wrong and the test wouldn't catch it because it's being run for both expected and actual."
+6553,"@@ -27,6 +27,7 @@ package encryption
+ import (
+ 	""crypto/tls""
+ 	""crypto/x509""
++	""encoding/base64""
+ 	""errors""
+ 	""fmt""
+ 	""io/ioutil""",TODO: update unit tests to exercise base64-inline path
+6554,"@@ -551,6 +551,16 @@ public class UserPreferences {
+         restartUpdateAlarm(false);
+     }
+
++    public static boolean shouldShowOnboarding(String location) {
++        String key = ""onboarding_"" + location;
++        if (prefs.getBoolean(key, true)) {
++            prefs.edit().putBoolean(key, false).apply();
++            return true;
++        } else {
++            return false;
++        }
++    }
++
+     /**
+      * Change the auto-flattr settings
+      *",this method knows too much - it is kind of a strange side effect I'd prefer if we had separate method for acknowledging that the onboarding was done and should not be shown again
+6555,"@@ -125,6 +125,7 @@ public class StorageCallbacksImpl implements StorageCallbacks {
+                     PodDBAdapter.KEY_CHAPTER_TYPE));
+         }
+         if(oldVersion <= 14) {
++
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_AUTO_DOWNLOAD + "" INTEGER"");
+             db.execSQL(""UPDATE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS","Do we need to increase the DB version? Also, should probably be a constant, no?"
+6556,"@@ -50,6 +50,11 @@ func NewWindow(every, period, offset values.Duration) (Window, error) {
+ 	return w, nil
+ }
+
++// IsZero checks if the window's every duration is zero
++func (w Window) IsZero() bool {
++	return w.every.IsZero()
++}
++
+ func (w Window) isValid() error {
+ 	if w.every.IsZero() {
+ 		return errors.New(codes.Invalid, ""duration used as an interval cannot be zero"")","We could utilize the new isZero method in this if-statement, right?"
+6557,"@@ -107,6 +107,14 @@ func (config testBlockOpsConfig) blockCache() BlockCache {
+ 	return config.cache
+ }
+
++func (config testBlockOpsConfig) MakeLogger(module string) logger.Logger {
++	return logger.NewNull()
++}
++
++func (config testBlockOpsConfig) DataVersion() DataVer {
++	return FilesWithHolesDataVer
++}
++
+ func makeTestBlockOpsConfig(t *testing.T) testBlockOpsConfig {
+ 	bserver := NewBlockServerMemory(logger.NewTestLogger(t))
+ 	codec := kbfscodec.NewMsgpack()","should probably have config have a `t` or a `logger.NewTestLogger(t)`, and return the latter"
+6558,"@@ -51,8 +51,10 @@ func (p *heuristicPlanner) Plan(inputPlan *PlanSpec) (*PlanSpec, error) {
+
+ 		visited := make(map[PlanNode]struct{})
+
+-		nodeStack := make([]PlanNode, len(inputPlan.Results()))
+-		copy(nodeStack, inputPlan.Results())
++		nodeStack := make([]PlanNode, 0, len(inputPlan.Roots))
++		for root := range inputPlan.Roots {
++			nodeStack = append(nodeStack, root)
++		}
+
+ 		anyChanged = false
+ 		for len(nodeStack) > 0 {","Does this not do the same thing as `copy`? I thought that `copy` just did an elementwise assignment, but maybe I was wrong."
+6559,"@@ -124,9 +124,9 @@ public abstract class FlatteningConfig {
+     // flattening.
+     Map<String, FlatteningConfig> flatteningConfigs = new LinkedHashMap<>();
+
+-    flatteningConfigs.putAll(flatteningConfigsFromGapicConfig);
+-    // Let flattenings from proto annotations override flattenings from GAPIC config.
++    // Let flattenings from GAPIC config override flattenings from proto annotations.
+     flatteningConfigs.putAll(flatteningConfigsFromProtoFile);
++    flatteningConfigs.putAll(flatteningConfigsFromGapicConfig);
+
+     return ImmutableList.copyOf(flatteningConfigs.values());
+   }","Here we are merging the configs from proto annotations and gapic config. But in other places in this PR we are using the new enum to pick one or the other, right? Or is that not the correct way to think about this?"
+6560,"@@ -16,7 +16,7 @@ var opts = struct {
+ 	Usage     string
+ 	Verbosity cli.Verbosity `short:""v"" long:""verbosity"" default:""warning"" description:""Verbosity of output (higher number = more output)""`
+ 	CacheDir  string        `short:""d"" long:""dir"" default:"""" description:""The directory to store cached artifacts in.""`
+-	Port      int           `short:""p"" long:""port"" description:""The port to run the server on""`
++	Port      int           `short:""p"" long:""port"" description:""The port to run the server on"" default:""8080""`
+ }{
+ 	Usage: `
+ HTTP cache implements a resource based http server that please can use as a cache. The cache supports storing files",not related to this change?
+6561,"@@ -51,9 +51,9 @@ if (options.arch) {
+
+ const buildType = options.buildType;
+
+-const ndkPath = process.env[""ANDROID_NDK""];
++const ndkPath = process.env[""ANDROID_NDK""] || process.env[""ANDROID_NDK_HOME""];
+ if (!ndkPath) {
+-  throw Error(""ANDROID_NDK environment variable not set"");
++  throw Error(""ANDROID_NDK / ANDROID_NDK_HOME environment variable not set"");
+ }
+
+ const sdkPath = getAndroidSdkPath();",Why is this needed?
+6562,"@@ -1353,7 +1353,7 @@ int64_t Creature::getStepDuration() const
+ 	int32_t stepSpeed = getStepSpeed();
+ 	if (stepSpeed > -Creature::speedB) {
+ 		calculatedStepSpeed = floor((Creature::speedA * log((stepSpeed / 2) + Creature::speedB) + Creature::speedC) + 0.5);
+-		if (calculatedStepSpeed <= 0) {
++		if (calculatedStepSpeed == 0) {
+ 			calculatedStepSpeed = 1;
+ 		}
+ 	} else {","This one could be replaced with a `std::max`, no?"
+6563,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.
+6564,"@@ -566,7 +566,11 @@ class Filter extends WidgetBase
+         /*
+          * Set scope value
+          */
+-        $scope->value = $this->getScopeValue($scope);
++        if($scopeType=='checkbox' || $scopeType=='switch'){
++            $scope->value = isset($config['value']) ? $config['value'] : $this->getScopeValue($scope);
++        } else{
++            $scope->value = $this->getScopeValue($scope);
++        }
+
+         return $scope;
+     }","Please use strict type comparisons (`===`), not loose type comparisons."
+6565,"@@ -73,6 +73,14 @@ public class FilterParameter {
+     return blockhash;
+   }
+
++  public boolean isValid() {
++    if (!getFromBlock().isLatest() && !getToBlock().isLatest() && getBlockhash() != null) {
++      return false;
++    }
++
++    return true;
++  }
++
+   @Override
+   public String toString() {
+     return MoreObjects.toStringHelper(this)","The filter parameters are a bit confusing. I understand that one of them has to be set, but what takes precedence if a from/to is set and the hash as well? Should that fail?"
+6566,"@@ -6,6 +6,9 @@
+
+ #include ""graph/context/Iterator.h""
+
++#include <cstdio>
++#include <tuple>
++
+ #include ""common/datatypes/Edge.h""
+ #include ""common/datatypes/Vertex.h""
+ #include ""graph/util/SchemaUtil.h""",Is that necessary?
+6567,"@@ -72,7 +72,7 @@ describe Ncr::WorkOrder do
+
+   describe ""#ba_6x_tier1_team?"" do
+     it ""is true for whitelist of organizations"" do
+-      org_letters = %w( 7 J 4 T 1 A C Z )
++      org_letters = %w( 1 2 4 7 A C J T Z )
+       org_letters.each do |org_letter|
+         org_code = ""P11#{org_letter}XXXX""
+         ncr_org = build(:ncr_organization, code: org_code)",yess so much easier to read in order like this!
+6568,"@@ -613,6 +613,7 @@ public abstract class LuceneTestCase extends Assert {
+     RuleChain r = RuleChain.outerRule(new TestRuleIgnoreTestSuites())
+       .around(ignoreAfterMaxFailures)
+       .around(suiteFailureMarker = new TestRuleMarkFailure())
++      .around(new VerifyTestClassNamingConvention())
+       .around(new TestRuleAssertionsRequired())
+       .around(new TestRuleLimitSysouts(suiteFailureMarker))
+       .around(tempFilesCleanupRule = new TestRuleTemporaryFilesCleanup(suiteFailureMarker));",question: would this convention automatically and always apply to all classes derived from `LuceneTestCase` including any non-`org.apache` name spaces or would it be possible to opt-out (without an exclusion list) somehow for custom code that might perhaps have chosen a different convention?
+6569,"@@ -57,7 +57,7 @@ public class PasscodeManager  {
+ 	private static final String EPREFIX = ""eprefix"";
+
+     // Default min passcode length
+-    protected static final int MIN_PASSCODE_LENGTH = 6;
++    protected static final int MIN_PASSCODE_LENGTH = 4;
+
+     // Key in preference for the passcode
+     private static final String KEY_PASSCODE =""passcode"";","Also found this bug, where we were setting the min passcode length to 6, but the min length for a connected app is 4. This can cause problems when the app is force closed or the shared pref is removed."
+6570,"@@ -175,7 +175,7 @@ class FastTemporalMemory(TemporalMemory):
+     """"""
+     self._validateCell(cell)
+
+-    return int(cell.idx / self.cellsPerColumn)
++    return int(cell / self.cellsPerColumn)
+
+
+   def cellsForColumn(self, column):",Why was this change necessary?
+6571,"@@ -55,7 +55,7 @@ import java.util.logging.Logger;
+
+ class Host {
+
+-  private static final Logger LOG = Logger.getLogger(""Selenium Distributor"");
++  private static final Logger LOG = Logger.getLogger(""Selenium Host"");
+   private final Node node;
+   private final UUID nodeId;
+   private final URI uri;","I kind of did this deliberately, so everything from the distributor appears in the same set of logs."
+6572,"@@ -300,6 +300,7 @@ class TCPSession(IPSession):
+                 return pkt
+             metadata[""pay_class""] = pay_class
+             metadata[""tcp_reassemble""] = tcp_reassemble
++            metadata[""seq""] = pkt[TCP].seq
+         else:
+             tcp_reassemble = metadata[""tcp_reassemble""]
+         # Get a relative sequence number for a storage purpose",We already have a `seq = pkt[TCP].seq` so you can just re-use it.
+6573,"@@ -22,11 +22,8 @@ package org.apache.iceberg.data.parquet;
+ import com.google.common.collect.ImmutableList;
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;
+-import java.time.Instant;
+-import java.time.LocalDate;
+-import java.time.LocalDateTime;
+-import java.time.OffsetDateTime;
+-import java.time.ZoneOffset;
++
++import java.time.*;
+ import java.time.temporal.ChronoUnit;
+ import java.util.Iterator;
+ import java.util.List;","We avoid wildcard imports because it isn't clear where symbols are coming from and there is potential for collision. Could you roll back this change? (As well as the additional newline, we don't use breaks in imports either.)"
+6574,"@@ -533,11 +533,11 @@ TEST_F(TCPv4Tests, send_and_receive_between_secure_ports_client_verifies)
+                                     (std::chrono::steady_clock::now() + std::chrono::microseconds(100)));
+                     while (!sent)
+                     {
+-                        Locators input_begin(locator_list.begin());
+-                        Locators input_end(locator_list.end());
++                        Locators l_input_begin(locator_list.begin());
++                        Locators l_input_end(locator_list.end());
+
+                         sent =
+-                                send_resource_list.at(0)->send(message, 5, &input_begin, &input_end,
++                                send_resource_list.at(0)->send(message, 5, &l_input_begin, &l_input_end,
+                                         (std::chrono::steady_clock::now() + std::chrono::microseconds(100)));
+                         std::this_thread::sleep_for(std::chrono::milliseconds(100));
+                     }",Why are these variables renamed? Is there a conflict with some Windows specific variable?
+6575,"@@ -18,6 +18,8 @@
+
+ require_once(""../inc/util.inc"");
+ require_once(""../inc/xml.inc"");
++if(file_exists('../../release.inc'))
++    include '../../release.inc';
+
+ BoincDb::get(true);
+ xml_header();",Do you test for file existence simply to reduce the warning message that may occur using the include? Also - I think the practice used in BOINC is to go ahead and use include_once even though it isn't strictly necessary in this case.
+6576,"@@ -20,6 +20,8 @@ import (
+ )
+
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ // +chaos-mesh:experiment
+
+ // TimeChaos is the Schema for the timechaos API",`TimeChaos` does not contains a field .spec.action
+6577,"@@ -1,9 +1,10 @@
+ package net.runelite.rs.api;
+
++import net.runelite.api.AbstractArchive;
+ import net.runelite.api.IndexDataBase;
+ import net.runelite.mapping.Import;
+
+-public interface RSAbstractArchive extends IndexDataBase
++public interface RSAbstractArchive extends IndexDataBase, AbstractArchive
+ {
+ 	@Import(""takeFile"")
+ 	byte[] getConfigData(int archiveId, int fileId);",You need to override where possible in rs-api
+6578,"@@ -25,5 +25,12 @@ namespace Reporting
+         public string BuildName { get; set; }
+
+         public DateTime TimeStamp { get; set; }
++
++        public Dictionary<string, string> AdditionalData { get; set; } = new Dictionary<string, string>();
++
++        public void AddData(string key, string payload)
++        {
++            AdditionalData.Add(key, payload);
++        }
+     }
+ }",Should this have an add/update/etc pattern? What happens if I need to change some set of data? May be better to just let the callsite manipulate the dictionary.
+6579,"@@ -177,6 +177,18 @@ class PyRegion(object):
+     name: the name of the output
+     """"""
+
++  @not_implemented
++  def getAlgorithmInstance(self):
++    """"""
++    Returns the instance of the underlying algorithm that is performing
++    the computation.
++
++    This method should be overridden by the region subclass.
++
++    Note that the return type depends on the Region and therefore
++    cannot be determined in advance.
++    """"""
++
+   def getParameter(self, name, index):
+     """"""Default implementation that return an attribute with the requested name
+ ","I don't think this should be added to PyRegion. Adding it here requires that every region have an ""algorithm"" which may not always make sense and the return value type will be different in every case. But fine to use the same name in the regions where we choose to implement it as a convention if that makes the API more discoverable."
+6580,"@@ -421,6 +421,12 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyht
+ 			return nil
+ 		}
+
++		// detect connection timeout to the upstream and respond with 504
++		switch e, ok := proxyErr.(net.Error); ok {
++		case e.Timeout():
++			return caddyhttp.Error(http.StatusGatewayTimeout, proxyErr)
++		}
++
+ 		// if the roundtrip was successful, don't retry the request or
+ 		// ding the health status of the upstream (an error can still
+ 		// occur after the roundtrip if, for example, a response handler",Returning here bypasses all the health check and load balancing features.
+6581,"@@ -1,4 +1,4 @@
+-// Copyright (c) 2020 Tigera, Inc. All rights reserved.
++// Copyright (c) 2020-2021 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");
+ // you may not use this file except in compliance with the License.","Should revert this copyright change, when the file isn't changing in any other way."
+6582,"@@ -90,8 +90,10 @@ func WriteFile(fromFile io.Reader, to string, mode os.FileMode) error {
+ 		return err
+ 	}
+ 	dir, file := path.Split(to)
+-	if err := os.MkdirAll(dir, DirPermissions); err != nil {
+-		return err
++	if dir != """" {
++		if err := os.MkdirAll(dir, DirPermissions); err != nil {
++			return err
++		}
+ 	}
+ 	tempFile, err := ioutil.TempFile(dir, file)
+ 	if err != nil {","Interesting that filepath.Dir(""thing"") returns ""."" whereas this returns """""
+6583,"@@ -364,11 +364,11 @@ class Series(_Frame):
+         ...                    's2': [.3, .6, .0, .1]})
+         >>> s1 = df.s1
+         >>> s2 = df.s2
+-        >>> s1.corr(s2, method='pearson')
+-        -0.8510644963469898
++        >>> s1.corr(s2, method='pearson')  # doctest: +ELLIPSIS
++        -0.851064...
+
+-        >>> s1.corr(s2, method='spearman')
+-        -0.9486832980505125
++        >>> s1.corr(s2, method='spearman')  # doctest: +ELLIPSIS
++        -0.948683...
+
+         Notes
+         -----","Nice, I did not know about that"
+6584,"@@ -2521,4 +2521,19 @@ namespace hip_impl {
+             std::terminate();
+         #endif
+     }
++
++    std::mutex executables_cache_mutex;
++
++    void executables_cache(
++            std::string elf, hsa_isa_t isa, hsa_agent_t agent,
++            std::vector<hsa_executable_t>& exes, bool write) {
++        static std::unordered_map<std::string,
++            std::unordered_map<hsa_isa_t,
++                std::unordered_map<hsa_agent_t, std::vector<hsa_executable_t>>>> cache;
++        if (write) {
++            cache[elf][isa][agent] = exes;
++        } else {
++            exes = cache[elf][isa][agent];
++        }
++    }
+ } // Namespace hip_impl.","Since the lock is have moved outside of this function, I think it would be simpler and efficient to just return a ref to the std::vector<hsa_executable_t>? That way, we don't need to make a new copy on read and we won't actually need a write operation."
+6585,"@@ -448,12 +448,15 @@ func (api *Server) ReadState(ctx context.Context, in *iotexapi.ReadStateRequest)
+ 	if !ok {
+ 		return nil, status.Errorf(codes.Internal, ""protocol %s isn't registered"", string(in.ProtocolID))
+ 	}
+-	data, err := api.readState(ctx, p, in.GetHeight(), in.MethodName, in.Arguments...)
++	data, readStateHeight, err := api.readState(ctx, p, in.GetHeight(), in.MethodName, in.Arguments...)
+ 	if err != nil {
+ 		return nil, status.Error(codes.NotFound, err.Error())
+ 	}
+ 	out := iotexapi.ReadStateResponse{
+ 		Data: data,
++		BlockIdentifier: &iotextypes.BlockIdentifier{
++			Height: readStateHeight,
++		},
+ 	}
+ 	return &out, nil
+ }",also fetch block hash of this height and return hash
+6586,"@@ -75,6 +75,9 @@ namespace Samples.HttpMessageHandler
+
+         private static async Task SendHttpClientRequestAsync(bool tracingDisabled)
+         {
++            // Insert a call to the Tracer.Instance to include an AssemblyRef to Datadog.Trace assembly in the final executable
++            var ins = Tracer.Instance;
++
+             Console.WriteLine($""[HttpClient] sending request to {Url}"");
+             var clientRequestContent = new StringContent(RequestContent, Utf8);
+ ",Why do we need this in this sample app and not the others?
+6587,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+
+   @Override",We don't need this additional method.
+6588,"@@ -97,6 +97,6 @@ class CreateUserCommand extends Command
+             $output->writeln(sprintf('<error>Can\'t find role %s</error>', $role));
+         }
+
+-        return 1;
++        return 0;
+     }
+ }",Shouldn't this return code conditionally? The above line seems like an error occurred.
+6589,"@@ -24,6 +24,12 @@ import (
+ 	""k8s.io/apimachinery/pkg/types""
+ )
+
++// SupportedDiskType is a map containing the valid disk type
++var SupportedDiskType = map[string]bool{
++	string(apis.TypeSparseCPV): true,
++	string(apis.TypeDiskCPV):   true,
++}
++
+ // SPC encapsulates StoragePoolClaim api object.
+ type SPC struct {
+ 	// actual spc object",What is the need to use string as key? Can we use the apis type as the key?
+6590,"@@ -867,6 +867,7 @@ class Uppy {
+
+   info (message, type, duration) {
+     const isComplexMessage = typeof message === 'object'
++    duration = typeof duration === 'undefined' ? 3000 : duration
+
+     this.setState({
+       info: {",how about a default parameter instead?
+6591,"@@ -624,11 +624,11 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ }
+
+ func (r *ReconcileClusterDeployment) reconcileInstallingClusterProvision(cd *hivev1.ClusterDeployment, releaseImage string, logger log.FieldLogger) (reconcile.Result, error) {
+-	// Return early and stop processing if Agent install strategy is in play. The controllers that
++	// Return early and stop processing if ClusterInstallRef is in play. The controllers that
+ 	// handle this portion of the API currently live in the assisted service repo, rather than hive.
+ 	// This will hopefully change in the future.
+-	if cd.Spec.Provisioning != nil && cd.Spec.Provisioning.InstallStrategy != nil && cd.Spec.Provisioning.InstallStrategy.Agent != nil {
+-		logger.Info(""skipping processing of agent install strategy cluster"")
++	if cd.Spec.ClusterInstallRef != nil {
++		logger.Info(""ClusterInstallRef specified, skipping creation of ClusterProvision"")
+ 		return reconcile.Result{}, nil
+ 	}
+ ","i don't think we need to add duplicate check for clusterinstallref here, the function already assumes that it was invoked for clusterprovision"
+6592,"@@ -159,7 +159,10 @@ class HybridTaskCascadeRoIHead(CascadeRoIHead):
+         bbox_head = self.bbox_head[stage]
+         bbox_feats = bbox_roi_extractor(
+             x[:len(bbox_roi_extractor.featmap_strides)], rois)
+-        if self.with_semantic and 'bbox' in self.semantic_fusion:
++
++        # bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.
++        if self.with_semantic and 'bbox' in self.semantic_fusion and \
++                bbox_feats.shape[0] > 0:
+             bbox_semantic_feat = self.semantic_roi_extractor([semantic_feat],
+                                                              rois)
+             if bbox_semantic_feat.shape[-2:] != bbox_feats.shape[-2:]:",\`bbox_feats.shape[0] > 0\` requires the number of proposal is not 0.
+6593,"@@ -202,9 +202,8 @@ public class RewriteManifestsAction
+         .createDataset(Lists.transform(manifests, ManifestFile::path), Encoders.STRING())
+         .toDF(""manifest"");
+
+-    String entriesMetadataTable = metadataTableName(MetadataTableType.ENTRIES);
+-    Dataset<Row> manifestEntryDF = spark.read().format(""iceberg"")
+-        .load(entriesMetadataTable)
++    Dataset<Row> manifestEntryDF = BaseSparkAction.loadMetadataTable(spark, table.name(), table().location(),
++        MetadataTableType.ENTRIES)
+         .filter(""status < 2"") // select only live entries
+         .selectExpr(""input_file_name() as manifest"", ""snapshot_id"", ""sequence_number"", ""data_file"");
+ ",Same here. Any way to fit on one line?
+6594,"@@ -170,6 +170,9 @@ bool TestShard::commitLogs(std::unique_ptr<LogIterator> iter) {
+                     data_.emplace_back(currLogId_, log.toString());
+                     VLOG(1) << idStr_ << ""Write: "" << log << "", LogId: "" << currLogId_
+                             << "" state machine log size: "" << data_.size();
++                    if (log.startsWith(""set "")) {
++                        singleRegister_ = std::stoi(log.subpiece(4).toString());
++                    }
+                     break;
+                 }
+             }",using folly::to is better ?
+6595,"@@ -376,7 +376,6 @@ def _init_profiles():
+         private_profile.setter = ProfileSetter(  # type: ignore[attr-defined]
+             private_profile)
+         assert private_profile.isOffTheRecord()
+-        private_profile.setter.init_profile()
+
+
+ def _init_site_specific_quirks():",I'm guessing this is unintended?
+6596,"@@ -284,11 +284,13 @@ class ChangeStreamCursor extends Cursor {
+       if (this.options[optionName]) result[optionName] = this.options[optionName];
+     }
+
++    const resumeKey = this.options.startAfter && !this.hasReceived ? 'startAfter' : 'resumeAfter';
++
+     if (this.resumeToken || this.startAtOperationTime) {
+       ['resumeAfter', 'startAfter', 'startAtOperationTime'].forEach(key => delete result[key]);
+
+       if (this.resumeToken) {
+-        result.resumeAfter = this.resumeToken;
++        result[resumeKey] = this.resumeToken;
+       } else if (this.startAtOperationTime && maxWireVersion(this.server) >= 7) {
+         result.startAtOperationTime = this.startAtOperationTime;
+       }","This looks a little suspicious to me, can you explain what's going on here?"
+6597,"@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base
+   private
+
+   def current_user
+-    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    @current_user ||= find_current_user
++  end
++
++  def find_current_user
++    if ENV['FORCE_USER_ID']
++      User.find ENV['FORCE_USER_ID']
++    else
++      User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    end
+   end
+
+   def sign_in(user)",Can you talk about this? I'm not sure I follow why this is necessary.
+6598,"@@ -136,6 +136,8 @@ class AbstractBase extends AbstractActionController
+             ->fromPost('layout', $this->params()->fromQuery('layout', false));
+         if ('lightbox' === $layout) {
+             $this->layout()->setTemplate('layout/lightbox');
++        }elseif(isset($params['layout']) && $params['layout']=='simple'){
++             $this->layout()->setTemplate('layout/simple');
+         }
+         return new ViewModel($params);
+     }","Is there really a need for this 'simple' layout? Is there a reason you can't use 'lightbox'? The only difference seems to be that the lightbox layout includes Piwik/Google Analytics tracking and simple does not. If tracking needs to be disabled for some reason, perhaps there is a way to do that without creating a whole new layout."
+6599,"@@ -526,6 +526,19 @@ public abstract class MergePolicy {
+   public abstract MergeSpecification findForcedDeletesMerges(
+       SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException;
+
++  /**
++   * Identifies merges that we want to execute (synchronously) on commit. By default, do not synchronously merge on commit.
++   *
++   * If a returned {@link OneMerge} includes a segment already included in a registered merge, then the commit will fail.
++   * Use {@link MergeContext#getMergingSegments()} to determine which segments are currently registered to merge.
++   *
++   * @param segmentInfos the total set of segments in the index (while preparing the commit)
++   * @param mergeContext the IndexWriter to find the merges on
++   */
++  public MergeSpecification findCommitMerges(SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException {
++    return null;
++  }
++
+   /**
+    * Returns true if a new segment (regardless of its origin) should use the
+    * compound file format. The default implementation returns <code>true</code>","Can you say what exception will be thrown in that case (or add an `@throws`, below)?"
+6600,"@@ -5,9 +5,9 @@ import sys
+ # Simple python version test
+ major,minor = sys.version_info[:2]
+ py_version = sys.version.split()[0]
+-if major != 2 or minor < 5:
++if major != 2 or minor < 6:
+   # SystemExit defaults to returning 1 when printing a string to stderr
+-  raise SystemExit(""You are using python %s, but version 2.5 or greater is required"" % py_version)
++  raise SystemExit(""You are using python %s, but version 2.7 or greater is required"" % py_version)
+
+ required = 0
+ optional = 0","Is this meant to be ""2.7"" or ""2.6"". The two lines in this commit don't agree with one another. Looks like everything else in this PR is ""2.6"" and that seems sensible."
+6601,"@@ -21,8 +21,8 @@
+ # ----------------------------------------------------------------------
+ import unittest
+
+-from nupic.data.pattern_machine import (PatternMachine,
+-                                        ConsecutivePatternMachine)
++from nupic.data.generators.pattern_machine import (PatternMachine,
++                                                   ConsecutivePatternMachine)
+
+
+ ",Should we put these tests in a `generators` directory?
+6602,"@@ -356,8 +356,8 @@ struct greater_equal_op {
+ struct and_op {
+   inline DataType operator()(const DataType& x1,
+                              const DataType& x2) const {
+-    const bool b1 = x1 != zero && !std::isnan(x1);
+-    const bool b2 = x2 != zero && !std::isnan(x2);
++    const auto& b1 = x1 >= DataType(0.5);
++    const auto& b2 = x2 >= DataType(0.5);
+     return (b1 && b2) ? one : zero;
+   }
+   inline void operator()(const DataType& x1,",I think that it makes more sense to keep these with the standard definition of non-zero is true and zero is false.
+6603,"@@ -34,9 +34,9 @@ class DummyRequest(mock.MagicMock):
+         self.authn_type = 'basicauth'
+         self.prefixed_userid = 'basicauth:bob'
+         self.effective_principals = [
+-            self.prefixed_userid,
+             'system.Everyone',
+-            'system.Authenticated']
++            'system.Authenticated',
++            'bob']
+         self.json = {}
+         self.validated = {}
+         self.matchdict = {}",Any idea why you want to change the behavior here? Is there a security risk not to have the prefix in the principal here.
+6604,"@@ -47,6 +47,7 @@ type ConfigMock struct {
+ 	mockMdcache    *MockMDCache
+ 	mockKcache     *MockKeyCache
+ 	mockBcache     *MockBlockCache
++	mockDBcache    *MockDirtyBlockCache
+ 	mockCrypto     *MockCrypto
+ 	mockCodec      *MockCodec
+ 	mockMdops      *MockMDOps","this reads like ""mock database cache"", maybe a clearer name"
+6605,"@@ -26,6 +26,8 @@ import (
+ 	""net/http""
+ 	""time""
+
++	""github.com/jetstack/cert-manager/pkg/webhook/server/util""
++
+ 	logf ""github.com/jetstack/cert-manager/pkg/logs""
+
+ 	""github.com/go-logr/logr""",Nit: move this with the other CM imports.
+6606,"@@ -2,9 +2,10 @@
+
+ namespace Shopsys\ShopBundle\Controller\Front;
+
++use League\Flysystem\FilesystemInterface;
+ use Shopsys\FrameworkBundle\Component\Image\Config\ImageConfig;
+ use Shopsys\FrameworkBundle\Component\Image\Processing\ImageGeneratorFacade;
+-use Symfony\Component\HttpFoundation\BinaryFileResponse;
++use Symfony\Component\HttpFoundation\StreamedResponse;
+
+ class ImageController extends FrontBaseController
+ {",This change should be mentioned in the CM
+6607,"@@ -23,6 +23,13 @@ namespace Datadog.Trace
+             HttpHeaderNames.DatadogTags,
+         };
+
++        /// <summary>
++        /// An <see cref=""ISpanContext""/> with default values. Can be used as the value for
++        /// <see cref=""SpanCreationSettings.Parent""/> in <see cref=""Tracer.StartActive(string, SpanCreationSettings)""/>
++        /// to specify that the new span should not inherit the currently active scope as its parent.
++        /// </summary>
++        public static readonly ISpanContext Empty = new ReadOnlySpanContext(traceId: 0, spanId: 0, serviceName: null);
++
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""SpanContext""/> class
+         /// from a propagated context. <see cref=""Parent""/> will be null","Do we really want a new type, or can we just use `SpanContext`? The `ISpanContext` interface is read-only, but there's nothing stopping users from casting this to `SpanContext` and modifying it."
+6608,"@@ -13,7 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
+-#if NET461
++#if NET452 || NET461
+ using System;
+ using System.Collections;
+ using System.Collections.Generic;",Should we define a const like NETFRAMEWORK or NETFULL which will be set for NET452 NET461 and anything like NET47 etc in future?
+6609,"@@ -36,6 +36,12 @@ const PoStProofLength = 192
+ // https://github.com/filecoin-project/go-filecoin/issues/966
+ var ProvingPeriodBlocks = types.NewBlockHeight(20000)
+
++// GracePeriodBlocks is the number of blocks after a proving period over
++// which a miner can still submit a post at a penalty.
++// TODO: what is a secure value for this?  Value is arbitrary right now.
++// See https://github.com/filecoin-project/go-filecoin/issues/1887
++var GracePeriodBlocks = types.NewBlockHeight(100)
++
+ const (
+ 	// ErrPublicKeyTooBig indicates an invalid public key.
+ 	ErrPublicKeyTooBig = 33",maybe start an issue to capture params that we need final values for and link to it here?
+6610,"@@ -288,6 +288,8 @@ class _RunData(object):
+         alternate_services = set()
+         direct_access_sources = set()
+         for backend in backend_service.backends:
++            if not backend.get('group'):
++                continue
+             instance_group = self.find_instance_group_by_url(
+                 backend.get('group'))
+             if not instance_group:","Can we instead do the check in find_instance_group_by_url() ? if we return None when group is not found, it will hit the next if statement (if not instance_group) and continue as expected, in this case we don't need to add 3 separate if statements"
+6611,"@@ -85,15 +85,15 @@ public class DateUtil {
+     }
+
+     public static int toSeconds(String hh_colon_mm) {
+-        Pattern p = Pattern.compile(""(\\d+):(\\d+)( a.m.| p.m.|)"");
++        Pattern p = Pattern.compile(""(\\d+):(\\d+)( a.m.| p.m.| AM | PM)"");
+         Matcher m = p.matcher(hh_colon_mm);
+         int retval = 0;
+
+         if (m.find()) {
+             retval = SafeParse.stringToInt(m.group(1)) * 60 * 60 + SafeParse.stringToInt(m.group(2)) * 60;
+-            if (m.group(3).equals("" .a.m"") && m.group(1).equals(""12""))
++            if (m.group(3).equals("" AM"") && m.group(1).equals(""12""))
+                 retval -= 12 * 60 * 60;
+-            if (m.group(3).equals("" p.m."") && !m.group(1).equals(""12""))
++            if (m.group(3).equals("" PM"") && !(m.group(1).equals(""12"")))
+                 retval += 12 * 60 * 60;
+         }
+         return retval;","on my android "".a.m"" and "".p.m"" is used add `||` here to support both variants"
+6612,"@@ -4647,7 +4647,7 @@ bool CoreChecks::PreCallValidateCreateImageView(VkDevice device, const VkImageVi
+                     skip |= LogError(pCreateInfo->image, ""VUID-VkImageViewCreateInfo-image-01586"", ""%s"", ss.str().c_str());
+                 }
+             } else {
+-                if ((!(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR)) || (!FormatIsMultiplane(image_format))) {
++                if (!(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR)) {
+                     // Format MUST be compatible (in the same format compatibility class) as the format the image was created with
+                     if (FormatCompatibilityClass(image_format) != FormatCompatibilityClass(view_format)) {
+                         const char *error_vuid;",`!FormatIsMultiplane(image_format)` will always be true at this point due to the test on line 4639.
+6613,"@@ -24,6 +24,7 @@ from typing import Any, Optional, List, Union
+
+ import numpy as np
+ import pandas as pd
++from pandas.core.accessor import CachedAccessor
+
+ from pyspark import sql as spark
+ from pyspark.sql import functions as F","Maybe inline the CachedAccessor code? Is it similar to our lazy property? If yes, can we reconcile the two?"
+6614,"@@ -34,7 +34,7 @@ func (c SmokeTestCase) BuildInputShape(ref *ShapeRef) string {
+ 	)
+ }
+
+-// AttachSmokeTests attaches the smoke test cases to the API model.
++	// AttachSmokeTests attaches the smoke test cases to the API model.
+ func (a *API) AttachSmokeTests(filename string) {
+ 	f, err := os.Open(filename)
+ 	if err != nil {",Nit this file has unintended changes.
+6615,"@@ -101,6 +101,8 @@ public class FeedItemMenuHandler {
+             mi.setItemVisibility(R.id.share_download_url_with_position_item, false);
+         }
+
++        mi.setItemVisibility(R.id.share_file, selectedItem.getMedia().fileExists());
++
+         if (selectedItem.isPlayed()) {
+             mi.setItemVisibility(R.id.mark_read_item, false);
+         } else {",Potential NPE? `hasMedia && selectedItem...`
+6616,"@@ -1662,7 +1662,7 @@ class EC2Connection(AWSQueryConnection):
+             params['AutoEnableIO.Value'] = new_value
+         return self.get_status('ModifyVolumeAttribute', params, verb='POST')
+
+-    def create_volume(self, size, zone, snapshot=None,
++    def create_volume(self, size, zone = None, snapshot=None,
+                       volume_type=None, iops=None):
+         """"""
+         Create a new EBS Volume.",PEP-8/consistency with the rest of the code.
+6617,"@@ -0,0 +1,15 @@
++using Datadog.Trace.ClrProfiler.Integrations;
++
++namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.MongoDb
++{
++    internal abstract class MongoDbInstrumentMethodAttribute : InstrumentMethodAttribute
++    {
++        protected MongoDbInstrumentMethodAttribute(string typeName)
++        {
++            AssemblyName = MongoDbIntegration.MongoDbClientAssembly;
++            TypeName = typeName;
++            IntegrationName = MongoDbIntegration.IntegrationName;
++            ParameterTypeNames = new[] { ""MongoDB.Driver.Core.Connections.IConnection"", ClrNames.CancellationToken };
++        }
++    }
++}",nit: Would you mind moving the `ParameterTypeNames` assignment into each of the method-specific attributes? That could reduce confusion if we later decided to instrument other methods in MongoDb
+6618,"@@ -0,0 +1,16 @@
++using System.Collections.Generic;
++using Nethermind.Blockchain.Find;
++using Nethermind.Core;
++using Nethermind.Core.Specs;
++using Nethermind.Int256;
++
++namespace Nethermind.JsonRpc.Modules.Eth
++{
++    public interface IGasPriceOracle
++    {
++        public ISpecProvider SpecProvider { get; }
++        public UInt256? FallbackGasPrice { get; }
++        public List<UInt256> TxGasPriceList { get; }
++        ResultWrapper<UInt256?> GasPriceEstimate(Block? headBlock, IBlockFinder blockFinder);
++    }
++}",Is exposing SpecProvider needed here?
+6619,"@@ -141,6 +141,18 @@ namespace MvvmCross.ViewModels
+             }
+         }
+
++        [NotifyPropertyChangedInvocator]
++        protected virtual bool SetProperty<T>(ref T storage, T value, Action afterAction, [CallerMemberName] string propertyName = null)
++        {
++            if (!SetProperty(ref storage, value, propertyName))
++            {
++                return false;
++            }
++
++            afterAction?.Invoke();
++            return true;
++        }
++
+         [NotifyPropertyChangedInvocator]
+         protected virtual bool SetProperty<T>(ref T storage, T value, [CallerMemberName] string propertyName = null)
+         {","So this will only be executed when it is true. I'm not sure that makes it always usable. Why not make the afterAction, `Action<bool>` and always call it, with the result as parameter."
+6620,"@@ -516,6 +516,7 @@ int pfs_table::resolve_name(int is_special_syscall, const char *cname, struct pf
+ 		char tmp[PFS_PATH_MAX];
+ 		path_split(pname->path,pname->service_name,tmp);
+ 		pname->service = pfs_service_lookup(pname->service_name);
++		if (result == PFS_RESOLVE_LOCAL) pname->service = NULL;
+ 		if(!pname->service) {
+ 			pname->service = pfs_service_lookup_default();
+ 			strcpy(pname->service_name,""local"");","Tim, please add { } to this 'if'."
+6621,"@@ -11,8 +11,11 @@ import (
+ )
+
+ const (
+-	// DefaultPort is used when no port is specified
++	// DefaultPort is used when no port is specified.
+ 	DefaultPort = ""31000""
++
++	// DefaultHost is the host that will be used when none is specified.
++	DefaultHost = ""127.0.0.1""
+ )
+
+ // Reporter will gather metrics of API requests made and",Suggest moving to `enable.go` since thats only place used.
+6622,"@@ -54,7 +54,7 @@ describe ""apply"" do
+
+         # Includes agent facts from apply_prep
+         agent_facts = report['resource_statuses']['Notify[agent facts]']['events'][0]['desired_value'].split(""\n"")
+-        expect(agent_facts[0]).to match(/^\w+\./)
++        expect(agent_facts[0]).to match(/^\w+/)
+         expect(agent_facts[1]).to eq(agent_facts[0])
+         expect(agent_facts[2]).to match(/^\d+\.\d+\.\d+$/)
+         expect(agent_facts[3]).to eq(agent_facts[2])","This changed when I rebuilt my docker container. Not quite sure why, but might have to do with what my host network configuration looks like when it's rebuilt."
+6623,"@@ -13,6 +13,7 @@ import (
+ 	""github.com/restic/restic/server""
+ )
+
++// Cache is used to handle the local cache.
+ type Cache struct {
+ 	base string
+ }",Local cache of what? What's stored in it?
+6624,"@@ -176,7 +176,7 @@ public class DataFiles {
+       this.keyMetadata = toCopy.keyMetadata() == null ? null
+           : ByteBuffers.copy(toCopy.keyMetadata());
+       this.splitOffsets = toCopy.splitOffsets() == null ? null : copyList(toCopy.splitOffsets());
+-      this.sortOrderId = toCopy.sortOrderId();
++      this.sortOrderId = toCopy.sortOrderId() == null ? SortOrder.unsorted().orderId() : toCopy.sortOrderId();
+       return this;
+     }
+ ","If the copied `DataFile` returns null, shouldn't the copy also return null? Why not make the builder use `Integer` instead of a primitive here?"
+6625,"@@ -2,11 +2,18 @@ import os
+
+ from jinja2 import Environment, FileSystemLoader
+
++HTML_FILES_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'html_files')
++
+ def save_html(filename, context, template):
+     path = os.path.dirname(os.path.abspath(__file__))
+     template_environment = Environment(
+     loader=FileSystemLoader(os.path.join(path, 'templates')))
+-    outputfile = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'html_files', filename)
++    outputfile = os.path.join(HTML_FILES_PATH, filename)
+     with open(outputfile, 'w') as f:
+         html = template_environment.get_template(template).render(context)
+         f.write(html)
++
++
++def check_html_files_dir_path():
++    dir_exists = os.path.isdir(HTML_FILES_PATH)
++    return dir_exists","You could just do this test in the `save_html` function above, and then the users of the save html function don't have to worry about it."
+6626,"@@ -214,7 +214,7 @@ func TestTaskRunOpts_Validate(t *testing.T) {
+ 					Name: ""my-app"",
+ 				}, nil)
+ 			},
+-			wantedError: errors.New(""get environment: couldn't find environment dev in the application my-app""),
++			wantedError: fmt.Errorf(""get environment %s config: couldn't find environment dev in the application my-app"", ""dev""),
+ 		},
+ 		""no workspace"": {
+ 			basicOpts: defaultOpts,","I think I'd prefer not using the formatted string when it comes to unit test, since we don't pass in any string variable as params."
+6627,"@@ -1,4 +1,4 @@
+-// +build avr esp nrf sam sifive stm32 k210 nxp
++// +build avr esp nrf sam sifive stm32 k210 nxp,!mimxrt1062
+
+ package machine
+ ",Maybe it would be better to explicitly include devices instead of explicitly excluding devices?
+6628,"@@ -475,10 +475,10 @@ void ROMol::clearComputedProps(bool includeRings) const {
+
+   RDProps::clearComputedProps();
+
+-  for (ConstAtomIterator atomIt = this->beginAtoms();
+-       atomIt != this->endAtoms(); ++atomIt) {
+-    (*atomIt)->clearComputedProps();
++  for (auto atom: atoms()) {
++    atom->clearComputedProps();
+   }
++
+   for (ConstBondIterator bondIt = this->beginBonds();
+        bondIt != this->endBonds(); bondIt++) {
+     (*bondIt)->clearComputedProps();","This could be `for (auto bond: bonds()){`, right?"
+6629,"@@ -78,10 +78,13 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+
++        $config = $this->getConfig();
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'allowConnectingCards' => $this->getAuthManager()
++                    ->supportsConnectingLibraryCard(),
+             ]
+         );
+     }",Is $config no longer being used? Can we remove this line?
+6630,"@@ -179,7 +179,7 @@ char* get_file_name(char* filename)
+ //   finished with it.
+ // If you pass in NULL or the new string can't be allocated,
+ //   it returns NULL.
+-char* remove_ext(const char* path, char dot, char sep, size_t* allocated_size)
++char* remove_ext(const char* path, char dot, char sep, size_t* allocated_size)
+ {
+     char *retstr, *lastdot, *lastsep;
+     // Error checks and allocate string.",can you revert changes to this file.
+6631,"@@ -2139,7 +2139,7 @@ public class DBService {
+                 Role templateRole = updateTemplateRole(role, domainName, roleName, templateParams);
+                 firstEntry = auditLogSeparator(auditDetails, firstEntry);
+                 auditDetails.append("" \""add-role\"": "");
+-                if (!processRole(con, originalRole, domainName, roleName, templateRole,
++                if (!processRole(con, originalRole, domainName, ZMSUtils.removeDomainPrefix(templateRole.getName(), domainName, ROLE_PREFIX), templateRole,
+                         admin, auditRef, true, auditDetails)) {
+                     return false;
+                 }","I don't believe the change is sufficient to correctly handle variable substitutions in the name. As part of the process command we pass the original role object that was retreived without taking into account the substitution. So while the first template apply command will work fine because the original role does not exist thus it's a new add operation, if you try to re-apply the same template again, we'll pick up and process a wrong original name thus we'll try to execute an add operation again instead of modify. So we need to take into account the substituted name when we retrieve the original role as well. Same change should be applied to both policy and service blocks as well."
+6632,"@@ -14,5 +14,6 @@ namespace MvvmCross.Base
+     {
+         Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);
+         Task ExecuteOnMainThreadAsync(Func<Task> action, bool maskExceptions = true);
++        bool IsOnMainThread { get; }
+     }
+ }",Please add this to IMvxMainThreadDispatcher as well
+6633,"@@ -223,7 +223,7 @@ module Bolt
+           if @future
+             to_expand = %w[private-key cacert token-file] & selected.keys
+             to_expand.each do |opt|
+-              selected[opt] = File.expand_path(selected[opt], @boltdir.path) if opt.is_a?(String)
++              selected[opt] = File.expand_path(selected[opt], @boltdir.path) if selected[opt].is_a?(String)
+             end
+           end
+ ",Is it possible for opt not to be a string? I couldn't tell if this was a typo or if there is actually a case where it is not a string.
+6634,"@@ -54,6 +54,7 @@ export default function UserInputSettings() {
+ 			ctaLabel={ __( 'Let’s go', 'google-site-kit' ) }
+ 			dismiss={ __( 'Remind me later', 'google-site-kit' ) }
+ 			winImage={ global._googlesitekitLegacyData.admin.assetsRoot + personSitImage }
++			className=""googlesitekit-user-input__notification""
+ 		/>
+ 	);
+ }",Let's move this up next to the `id` as we usually have `className` as one of the first props.
+6635,"@@ -4,14 +4,14 @@ import sys
+ from setuptools import setup, find_packages
+ from setuptools.command.install import install
+
+-VERSION = ""3.1.0""
++VERSION = ""3.1.1""
+
+ def readme():
+     readme_short = """"""
+     Quilt is a data management tool designed for data discoverability, data dependency
+     management, and data version control using `data packages <https://blog.quiltdata.com/data-packages-for-fast-reproducible-python-analysis-c74b78015c7f>`_.
+
+-    The `quilt` PyPi package allows you to build, push, and pull data packages in Quilt using Python.
++    The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python.
+     Visit the `documentation quickstart <https://docs.quiltdata.com/quickstart>`_ for more information.
+
+     """"""","While you're in here, ""build, push and install""?"
+6636,"@@ -35,8 +35,6 @@ namespace OpenTelemetry.Metrics
+
+         public string Description { get; set; }
+
+-        public string Unit { get; set; }
+-
+         public string[] TagKeys { get; set; }
+
+         public virtual Aggregation Aggregation { get; set; }",Unit never made it to spec...so removing.
+6637,"@@ -702,6 +702,9 @@ func (nl *NATSLatency) TotalTime() time.Duration {
+ // ServiceLatency is the JSON message sent out in response to latency tracking for
+ // exported services.
+ type ServiceLatency struct {
++	Type           string        `json:""type""`
++	ID             string        `json:""id""`
++	Time           string        `json:""timestamp""`
+ 	Status         int           `json:""status""`
+ 	Error          string        `json:""description,omitempty""`
+ 	AppName        string        `json:""app,omitempty""`","We have RequestStart which seems redundant a bit to this one, WDYT?"
+6638,"@@ -1,10 +1,4 @@
+-import {
+-	Component,
+-	createElement,
+-	_unmount as unmount,
+-	options,
+-	cloneElement
+-} from 'preact';
++import { Component, createElement, options, Fragment } from 'preact';
+ import { removeNode } from '../../src/util';
+
+ const oldCatchError = options._catchError;",I think we can remove this corresponding export from `preact` now! Double check no other s using though lol
+6639,"@@ -78,6 +78,14 @@ ActiveRecord::Schema.define(version: 20140604204910) do
+     t.datetime ""updated_at""
+   end
+
++  create_table ""item_traits"", force: true do |t|
++    t.text     ""name""
++    t.text     ""value""
++    t.integer  ""cart_item_id""
++    t.datetime ""created_at""
++    t.datetime ""updated_at""
++  end
++
+   create_table ""user_roles"", force: true do |t|
+     t.integer ""approval_group_id""
+     t.integer ""user_id""",I'm not sure why this would be in here. Were you working off a branch based off of master? These lines were removed in a previous commit because the table is actually called 'cart_item_traits'.
+6640,"@@ -30,6 +30,8 @@ module Travis
+         bundler: false
+       }
+
++      DEFAULT_GITHUB_ENDPOINT = ""https://api.github.com""
++
+       attr_reader :data
+
+       def initialize(data, defaults = {})","Maybe `DEFAULT_GITHUB_API_ENDPOINT` would be a better name, since we refer to this as an API endpoint elsewhere?"
+6641,"@@ -45,7 +45,9 @@ const (
+ 	capabilityPrefix             = ""com.amazonaws.ecs.capability.""
+ 	capabilityTaskIAMRole        = ""task-iam-role""
+ 	capabilityTaskIAMRoleNetHost = ""task-iam-role-network-host""
++	capabilityTaskCPUMemLimit    = ""task-cpu-mem-limit""
+ 	labelPrefix                  = ""com.amazonaws.ecs.""
++	attributePrefix              = ""ecs.capability.""
+ )
+
+ // DockerTaskEngine is a state machine for managing a task and its containers","If/when you rebase from `dev`, this is going to cause a merge conflict. I'd suggest that soon after merging this PR as the capabilities code has been moved to ""agent/app/agent_capabilities.go"""
+6642,"@@ -40,6 +40,14 @@ func Test_Start(t *testing.T) {
+ 	assert.Equal(t, ""bytecount 1"", mockConnection.LastLine)
+ }
+
++func Test_Stop(t *testing.T) {
++	statsRecorder := fakeStatsRecorder{}
++	middleware := NewMiddleware(statsRecorder.record, 1*time.Second)
++	mockConnection := &management.MockConnection{}
++	middleware.Stop(mockConnection)
++	assert.Equal(t, ""bytecount 0"", mockConnection.LastLine)
++}
++
+ func Test_ConsumeLine(t *testing.T) {
+ 	var tests = []struct {
+ 		line                  string",What is the test case here?
+6643,"@@ -130,6 +130,7 @@ func run(o *Options) error {
+ 	go flowAggregator.Run(stopCh, &wg)
+
+ 	informerFactory.Start(stopCh)
++	informerFactory.WaitForCacheSync(stopCh)
+
+ 	<-stopCh
+ 	klog.Infof(""Stopping flow aggregator"")","You could try moving this closer to the call, where we request label info. We might be doing the check very early.. all the resources may not be present with the informer at this point."
+6644,"@@ -42,7 +42,10 @@ public interface ManifestFile {
+           required(509, ""contains_null"", Types.BooleanType.get()),
+           optional(510, ""lower_bound"", Types.BinaryType.get()), // null if no non-null values
+           optional(511, ""upper_bound"", Types.BinaryType.get())
+-      ))));
++      ))),
++      optional(512, ""added_rows_count"", Types.LongType.get()),
++      optional(513, ""existing_rows_count"", Types.LongType.get()),
++      optional(514, ""deleted_rows_count"", Types.LongType.get()));
+
+   static Schema schema() {
+     return SCHEMA;",Can we add these up by the data files counts?
+6645,"@@ -30,10 +30,8 @@ const resolve = (list, child, node) => {
+ 	// callbacks won't get queued in the node anyway.
+ 	// If revealOrder is 'together' then also do an early exit
+ 	// if all suspended descendants have not yet been resolved.
+-	if (
+-		!list.props.revealOrder ||
+-		(list.props.revealOrder[0] === 't' && list._map.size)
+-	) {
++	const revealOrder = list.props.revealOrder;
++	if (!revealOrder || (revealOrder[0] === 't' && list._map.size)) {
+ 		return;
+ 	}
+ ",Most of the time assigning won't save bytes unless used 3+ times (var adds 3bytes)
+6646,"@@ -160,8 +160,8 @@ define(['playbackManager', 'nowPlayingHelper', 'events', 'connectionManager'], f
+
+         if (navigator.mediaSession) {
+             navigator.mediaSession.metadata = new MediaMetadata({
+-                title: title,
+-                artist: artist,
++                title: artist,
++                artist: title,
+                 album: album,
+                 artwork: getImageUrls(item),
+                 albumArtist: albumArtist,",I would rather find the code that inverts the logic and remove that.
+6647,"@@ -142,7 +142,7 @@ class RemoteConnection(object):
+         :Returns:
+         Timeout value in seconds for all http requests made to the Remote Connection
+         """"""
+-        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout
++        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT else cls._timeout
+
+     @classmethod
+     def set_timeout(cls, timeout):",The else doesn't return anything?
+6648,"@@ -48,7 +48,7 @@ func claim(args []string) error {
+ 		gasLimit = action.ClaimFromRewardingFundBaseGas +
+ 			action.ClaimFromRewardingFundGasPerByte*uint64(len(payload))
+ 	}
+-	gasPriceRau, err := gasPriceInRau()
++	gasPriceRau, _ := gasPriceInRau()
+ 	nonce, err := nonce(sender)
+ 	if err != nil {
+ 		return output.NewError(0, ""failed to get nonce"", err)",assignments should only be cuddled with other assignments (from `wsl`)
+6649,"@@ -3413,9 +3413,8 @@ static void
+ GetLibrarySearchPaths(std::vector<std::string> &paths,
+                       const swift::SearchPathOptions &search_path_opts) {
+   paths.clear();
+-  paths.resize(search_path_opts.LibrarySearchPaths.size() + 1);
+-  std::copy(search_path_opts.LibrarySearchPaths.begin(),
+-            search_path_opts.LibrarySearchPaths.end(), paths.begin());
++  paths.assign(search_path_opts.LibrarySearchPaths.begin(),
++            search_path_opts.LibrarySearchPaths.end());
+   paths.push_back(search_path_opts.RuntimeLibraryPath);
+ }
+ ",why not simply `paths = search_path_opts.LibrarySearchPaths` ?
+6650,"@@ -610,7 +610,7 @@ define([""globalize"", ""listView"", ""layoutManager"", ""userSettings"", ""focusManager""
+             }
+
+             if (item) {
+-                return item.Name;
++                return globalize.translate(item.Name);
+             }
+
+             if (""Movie"" === params.type) {",Are we sure this should be translated by the web client? It was unclear in chat exactly what's getting translated here.
+6651,"@@ -253,7 +253,7 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
+ 			docName = driver.UniqueString()
+ 			newName = docName
+ 		}
+-		w, err = c.putWrite(a.Doc, docName, &pb.Precondition{ConditionType: &pb.Precondition_Exists{false}})
++		w, err = c.putWrite(a.Doc, docName, &pb.Precondition{ConditionType: &pb.Precondition_Exists{Exists: false}})
+
+ 	case driver.Replace:
+ 		// If the given document has a revision, use it as the precondition (it implies existence).",same oneof issue.
+6652,"@@ -258,7 +258,7 @@ module Bolt
+                     config.project.puppetfile,
+                     config.project.managed_moduledir,
+                     config.project.project_file,
+-                    config.module_install)
++                    @plugins.resolve_references(config.module_install))
+     end
+
+     # Generate Puppet data types from project modules.","If we resolve here, isn't the whole `module_install` config setting or any subkeys also pluggable? I think that's totally fine, just want to make sure that that's known, and we should also update the data in `options.rb` for those options"
+6653,"@@ -376,6 +376,7 @@ hipError_t ihipExtLaunchMultiKernelMultiDevice(hipLaunchParams* launchParamsList
+
+         if(globalWorkSizeX > UINT32_MAX || globalWorkSizeY > UINT32_MAX || globalWorkSizeZ > UINT32_MAX)
+         {
++            free(kds);
+             return hipErrorInvalidConfiguration;
+         }
+ ",it would be better to change `kds` into a `std::vector` then we don't need to explicitly free it
+6654,"@@ -113,6 +113,8 @@ def send_email_sendgrid(config, sender, subject, message, recipients, image_png)
+
+
+ def send_email(subject, message, sender, recipients, image_png=None):
++    config = configuration.get_config()
++
+     subject = _prefix(subject)
+     logger.debug(""Emailing:\n""
+                  ""-------------\n""",Looks like you're also changing logic and not only tests.
+6655,"@@ -78,7 +78,7 @@ namespace Datadog.Trace.Tests.Sampling
+
+             var expectedLimit = totalMilliseconds * actualIntervalLimit / 1_000;
+
+-            var acceptableVariance = (actualIntervalLimit * 1.0);
++            var acceptableVariance = (actualIntervalLimit * 1.15);
+             var upperLimit = expectedLimit + acceptableVariance;
+             var lowerLimit = expectedLimit - acceptableVariance;
+ ",Is it possible that test failures here are real and that we should improve the rate limiting logic? Or are we ok with rate limits to be exceeded by 15%?
+6656,"@@ -71,6 +71,8 @@ class ImageProvider extends FileProvider
+             throw new \LogicException(""The 'srcset' and 'picture' options must not be used simultaneously."");
+         }
+
++        $attrPrefix = isset($options['lazy']) && true === $options['lazy'] ? 'data-' : '';
++
+         if (MediaProviderInterface::FORMAT_REFERENCE === $format) {
+             $box = $media->getBox();
+         } else {",Shouldn't there be some kind of validation somewhere? IMO there should be an exception if `$options['lazy']` is not a boolean.
+6657,"@@ -1,5 +1,7 @@
+ // Copyright (c) Microsoft. All rights reserved.
+
++using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging;
++
+ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer
+ {
+     using System;",nit: please move it inside namespace.
+6658,"@@ -15,7 +15,7 @@ module Bolt
+           shell-command
+           tmpdir
+           tty
+-        ].freeze
++        ].concat(RUN_AS_OPTIONS).sort.freeze
+
+         DEFAULTS = {
+           'cleanup' => true",The inventory schema needs to be regenerated to include these options. Looks like the CI job didn't get triggered since the paths don't include `lib/bolt/transport/**`.
+6659,"@@ -0,0 +1,14 @@
++WELCOME_DIALOG_TEXT = (
++	""Welcome to NVDA  dialog  Welcome to NVDA!\n""
++	""Most commands for controlling NVDA require you to hold down the NVDA key while pressing other keys.\n""
++	""By default, the numpad Insert and main Insert keys may both be used as the NVDA key.\n""
++	""You can also configure NVDA to use the CapsLock as the NVDA key.\n""
++	""Press NVDA+n at any time to activate the NVDA menu.\n""
++	""From this menu, you can configure NVDA, get help and access other NVDA functions.\n""
++	""Options  grouping\n""
++	""Keyboard layout:  combo box  desktop  collapsed  Alt+k""
++)
++QUIT_DIALOG_TEXT = (
++	""Exit NVDA  dialog\n""
++	""What would you like to do?  combo box  Exit  collapsed  Alt+d""
++)","This might break if a user runs the system tests with a system language other than English, in which the user default language differs."
+6660,"@@ -3,7 +3,7 @@ require 'rspec/expectations'
+ RSpec::Matchers.define :have_errors do |expected|
+
+   match do
+-    actual.body.match(/Error/)
++    actual.body.match(/Error\:/)
+   end
+
+   failure_message do |actual|","This was raising intermittent errors, since Lorem ipsum contains the word ""error"""
+6661,"@@ -214,6 +214,7 @@ bool RTPSDomain::removeRTPSParticipant(
+ {
+     if (p != nullptr)
+     {
++        assert((p->mp_impl != nullptr) && ""This participant has been previously invalidated"");
+         p->mp_impl->disable();
+
+         std::unique_lock<std::mutex> lock(m_mutex);",Shouldn't we then add `mp_impl = nullptr` to the destructor of `RTPSParticipant`
+6662,"@@ -5,10 +5,10 @@ import pytest
+ from mmdet.datasets import DATASETS
+
+
+-@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock)
++@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock())
+ @patch('mmdet.datasets.CocoDataset._filter_imgs', MagicMock)
+ @patch('mmdet.datasets.CustomDataset._filter_imgs', MagicMock)
+ @patch('mmdet.datasets.XMLDataset._filter_imgs', MagicMock)",Are the additional brackets necessary?
+6663,"@@ -148,7 +148,7 @@ public class Invoker implements InvocationHandler {
+     }
+
+     PojoConsumerOperationMeta pojoConsumerOperationMeta = consumerMeta
+-        .findOperationMeta(MethodUtils.findSwaggerMethodName(method));
++        .findOperationMeta(MethodUtils.findSwaggerMethodName(method), consumerIntf);
+     if (pojoConsumerOperationMeta == null) {
+       throw new IllegalStateException(
+           String.format(",consumerMeta only belongs to this invoker instance only relate to this one consumerIntf class seems no need to build a complex key?
+6664,"@@ -35,6 +35,11 @@ RSpec.describe RSpec::Core::Formatters::BaseTextFormatter do
+       expect(formatter_output.string).to match(""1 example, 1 failure, 1 pending"")
+     end
+
++    it ""with 1s outputs singular (only pending)"" do
++      send_notification :dump_summary, summary_notification(1, examples(1), examples(0), examples(1), 0)
++      expect(formatter_output.string).to match(""1 example, 0 failures, 1 pending"")
++    end
++
+     it ""with 2s outputs pluralized (including pending)"" do
+       send_notification :dump_summary, summary_notification(2, examples(2), examples(2), examples(2), 0)
+       expect(formatter_output.string).to match(""2 examples, 2 failures, 2 pending"")","this one is unrelated right? (Don't mind including it, just making sure I understand)"
+6665,"@@ -0,0 +1,14 @@
++_base_ = [
++    '../_base_/datasets/coco_instance.py', '../_base_/models/solo_r50_fpn.py',
++    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
++]
++# optimizer
++optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)
++optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
++# learning policy
++lr_config = dict(
++    policy='step',
++    warmup='linear',
++    warmup_iters=500,
++    warmup_ratio=1.0 / 3,
++    step=[9, 11])","8, 11 actually achieves similar performance, we should use our default config if [9,11] is unnecessary."
+6666,"@@ -0,0 +1,12 @@
++package yarpc
++
++import (
++	""time""
++
++	""github.com/yarpc/yarpc-go/encoding/raw""
++)
++
++func SleepRaw(reqMeta *raw.ReqMeta, body []byte) ([]byte, *raw.ResMeta, error) {
++	time.Sleep(1 * time.Second)
++	return nil, nil, nil
++}",For a separate PR: Can we make this a JSON/Thrift procedure instead? It could accept the amount of time it needs to sleep as an argument.
+6667,"@@ -92,6 +92,7 @@ class Tab(browsertab.AbstractTab):
+         pass
+
+
++
+ @pytest.mark.xfail(run=False, reason='Causes segfaults, see #1638')
+ def test_tab(qtbot, view, config_stub, tab_registry, mode_manager):
+     tab_w = Tab(win_id=0, mode_manager=mode_manager)",Please remove this blank line.
+6668,"@@ -26,6 +26,7 @@ use Front\Front;
+ use Propel\Runtime\Exception\PropelException;
+ use Symfony\Component\HttpFoundation\Cookie;
+ use Symfony\Component\HttpFoundation\Request;
++use Thelia\Cart\CartTrait;
+ use Thelia\Controller\Front\BaseFrontController;
+ use Thelia\Core\Event\Cart\CartEvent;
+ use Thelia\Core\Event\Order\OrderEvent;",the cartTrait is not used anymore
+6669,"@@ -82,6 +82,7 @@ namespace OpenTelemetry.Trace.Configuration
+         /// Creates tracerSdk factory.
+         /// </summary>
+         /// <param name=""configure"">Function that configures tracerSdk factory.</param>
++        /// <returns><see cref=""TracerFactory""/>.</returns>
+         public static TracerFactory Create(Action<TracerBuilder> configure)
+         {
+             if (configure == null)",Cn you please make the message more human friendly.
+6670,"@@ -23,10 +23,12 @@ import os
+ import sys
+ import html
+ import netrc
+-from typing import Callable, Mapping, List, Optional
+ import tempfile
++from enum import Enum, unique
++from typing import Callable, Mapping, List, Optional
+
+ from PyQt5.QtCore import QUrl
++from PyQt5.QtWebEngineWidgets import QWebEnginePage
+
+ from qutebrowser.config import config
+ from qutebrowser.utils import (usertypes, message, log, objreg, jinja, utils,","Please do `import enum` instead, then use `enum.Enum` and `enum.unique` - we do this everywhere to see where things are coming from, except for Qt (everything begins with a `Q` anyways) and typing (mostly used in type annotations, so it's clear without the namespacing)."
+6671,"@@ -46,7 +46,6 @@
+
+ #include ""codec.h""
+
+-#define ENCFAIL (uint)0 /* a value that is not a valid instruction */
+
+ /* Decode immediate argument of bitwise operations.
+  * Returns zero if the encoding is invalid.",Isn't ENCFAIL used in codec.c below? Wouldn't this make it no longer compile?
+6672,"@@ -73,6 +73,10 @@ public abstract class StaticLangXCombinedSurfaceView implements ViewModel {
+
+   public abstract List<PageStreamingDescriptorClassView> pageStreamingDescriptorClasses();
+
++  public boolean getTrue() {
++    return true;
++  }
++
+   public static Builder newBuilder() {
+     return new AutoValue_StaticLangXCombinedSurfaceView.Builder();
+   }",this looks very weird
+6673,"@@ -14,7 +14,9 @@ import java.util.logging.LogRecord;
+  * Log to the console using a basic formatter.
+  *
+  * @author Wouter Zelle
++ * @deprecated This class will be complety removed in 7.0.0
+  */
++@Deprecated
+ public class ConsoleLogHandler extends Handler {
+
+     private static final Formatter FORMATTER = new PmdLogFormatter();","So, the culprit was actually this class ""ConsoleLogHandler"", correct? Because it simply wrote to stdout..."
+6674,"@@ -272,7 +272,7 @@ namespace NLog.Config
+         public override LoggingConfiguration Reload()
+         {
+             if (!string.IsNullOrEmpty(_originalFileName))
+-                return new XmlLoggingConfiguration(_originalFileName, LogFactory);
++                return LogFactory.CreateConfig(_originalFileName); //TODO NLog 5: should call LoadConfiguration which set LogFactory.Configuration
+             else
+                 return base.Reload();
+         }",Still curious why you need to modify this method? Why not in the future just have a method called `LogFactory.ReloadConfiguration()` instead of the config assigning itself?
+6675,"@@ -110,8 +110,8 @@ class Test(base.Base):
+           'Molecule run (always).'))
+ def test(ctx, scenario_name, driver_name, __all, destroy):  # pragma: no cover
+     """"""
+-    Test (lint, destroy, dependency, syntax, create, prepare, converge,
+-          idempotence, side_effect, verify, destroy).
++    Test (lint, cleanup, destroy, dependency, syntax, create, prepare,
++          converge, idempotence, side_effect, verify, cleanup, destroy).
+     """"""
+
+     args = ctx.obj.get('args')","Should this say ""lint, cleanup, destroy, dependency, syntax, create, prepare, converge, idempotence, side_effect, verify, cleanup, destroy""?"
+6676,"@@ -23,12 +23,11 @@ func sendHeaders(ctx context.Context, headers p2p.Headers, stream *stream) error
+ 	defer cancel()
+
+ 	if err := w.WriteMsgWithContext(ctx, headersP2PToPB(headers)); err != nil {
+-		return fmt.Errorf(""write message: %w"", err)
++		return fmt.Errorf(""send write message: %w"", err)
+ 	}
+-
+ 	h := new(pb.Headers)
+ 	if err := r.ReadMsgWithContext(ctx, h); err != nil {
+-		return fmt.Errorf(""read message: %w"", err)
++		return fmt.Errorf(""send read message: %w"", err)
+ 	}
+
+ 	stream.headers = headersPBToP2P(h)",I am not sure why these log messages are changed.
+6677,"@@ -5,7 +5,10 @@ package runtime
+ // Interfaces are represented as a pair of {typecode, value}, where value can be
+ // anything (including non-pointers).
+
+-import ""unsafe""
++import (
++	""reflect""
++	""unsafe""
++)
+
+ type _interface struct {
+ 	typecode uintptr",This panic is incorrect - this is a full implementation of a slice equality check. This should be something more like `type x is not comparable` maybe?
+6678,"@@ -271,7 +271,7 @@ add_extra_option(opt_info_t *opt_info, const TCHAR *opt)
+             return DR_FAILURE;
+         }
+
+-        len = MIN(DR_MAX_OPTIONS_LENGTH - 1, _tcslen(opt));
++        len = _dr_nlen(opt, DR_MAX_OPTIONS_LENGTH);
+         opt_info->extra_opts[idx] =
+             malloc((len + 1) * sizeof(opt_info->extra_opts[idx][0]));
+         _tcsncpy(opt_info->extra_opts[idx], opt, len);",See below: let's use the existing convention _tcsnlen.
+6679,"@@ -6,10 +6,6 @@ describe Step do
+
+   describe ""Validations"" do
+     it { should validate_presence_of(:proposal) }
+-    it do
+-      create(:approval_step) # needed for spec, see https://github.com/thoughtbot/shoulda-matchers/issues/194
+-      should validate_uniqueness_of(:user_id).scoped_to(:proposal_id)
+-    end
+   end
+
+   let(:approval) { create(:approval_step) }",Why don't we need this any more?
+6680,"@@ -0,0 +1,14 @@
++_base_ = ['./sparse_rcnn_r50_fpn_mstrain_480-800_3x_coco.py']
++
++model = dict(
++    pretrained='torchvision://resnet101',
++    backbone=dict(
++        type='ResNet',
++        depth=101,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++)",clean unnecessary comma
+6681,"@@ -75,11 +75,14 @@ export function createVNode(type, props, key, ref, original) {
+ 		// a _nextDom that has been set to `null`
+ 		_nextDom: undefined,
+ 		_component: null,
+-		constructor: undefined,
+-		_original: original
++		constructor: undefined
+ 	};
+
+-	if (original == null) vnode._original = vnode;
++	Object.defineProperty(vnode, '_original', {
++		value: original || vnode,
++		enumerable: false,
++		writable: true
++	});
+ 	if (options.vnode) options.vnode(vnode);
+
+ 	return vnode;",This is the default value for enumerable.
+6682,"@@ -61,8 +61,8 @@ std::string chemicalReactionTemplatesToString(
+     bool toSmiles, bool canonical) {
+   std::string res = """";
+   std::vector<std::string> vfragsmi;
+-  RDKit::MOL_SPTR_VECT::const_iterator begin = getStartIterator(rxn, type);
+-  RDKit::MOL_SPTR_VECT::const_iterator end = getEndIterator(rxn, type);
++  auto begin = getStartIterator(rxn, type);
++  auto end = getEndIterator(rxn, type);
+   for (; begin != end; ++begin) {
+     vfragsmi.push_back(molToString(**begin, toSmiles));
+   }","Just above, you have `const auto` for a `RDKit::MOL_SPTR_VECT::const_iterator`, here it is only `auto`. Why is this?"
+6683,"@@ -186,9 +186,10 @@ bool Actions::registerEvent(Event_ptr event, const pugi::xml_node& node)
+ 	return false;
+ }
+
+-bool Actions::registerLuaEvent(Event* event)
++bool Actions::registerLuaEvent(Action* event)
+ {
+-	Action_ptr action{ static_cast<Action*>(event) }; //event is guaranteed to be an Action
++	Event_ptr ptr = Event_ptr(event);
++	Action_ptr action{ static_cast<Action*>(ptr.release()) }; //event is guaranteed to be an Action
+ 	if (action->getItemIdRange().size() > 0) {
+ 		if (action->getItemIdRange().size() == 1) {
+ 			auto result = useItemMap.emplace(action->getItemIdRange().at(0), std::move(*action));","@djarek just a quick question, wouldn't be `ptr.reset()` here better as it does not memory leak if we do not call delete on the raw pointer aswell? it maybe makes sense to use `ptr.release` if the event is guaranteed to be loaded again but on a reload it would memory leak if for example I removed that script from my files before reloading or not?"
+6684,"@@ -218,8 +218,12 @@ func (cfg *Config) GetString(key string) string {
+
+ // GetStringSlice returns config value as []string.
+ func (cfg *Config) GetStringSlice(key string) []string {
+-	value := cfg.Get(key).(*cli.StringSlice)
+-	return cast.ToStringSlice([]string(*value))
++	switch cfg.Get(key).(type) {
++	case *cli.StringSlice:
++		return cast.ToStringSlice([]string(*cfg.Get(key).(*cli.StringSlice)))
++	default:
++		return cast.ToStringSlice(cfg.Get(key))
++	}
+ }
+
+ // ParseBoolFlag parses a cli.BoolFlag from command's context and","Why to `Get()` value twice, while u have it 2 lines before"
+6685,"@@ -310,10 +310,17 @@ class ServiceProvider extends ModuleServiceProvider
+         $this->registerConsoleCommand('october.update', 'System\Console\OctoberUpdate');
+         $this->registerConsoleCommand('october.util', 'System\Console\OctoberUtil');
+         $this->registerConsoleCommand('october.mirror', 'System\Console\OctoberMirror');
++        $this->registerConsoleCommand('october.mirror', 'System\Console\OctoberFresh');
++
+         $this->registerConsoleCommand('plugin.install', 'System\Console\PluginInstall');
+         $this->registerConsoleCommand('plugin.remove', 'System\Console\PluginRemove');
+         $this->registerConsoleCommand('plugin.refresh', 'System\Console\PluginRefresh');
+
++        $this->registerConsoleCommand('theme.use', 'System\Console\ThemeUse');
++        $this->registerConsoleCommand('theme.list', 'System\Console\ThemeList');
++        $this->registerConsoleCommand('theme.install', 'System\Console\ThemeInstall');
++        $this->registerConsoleCommand('theme.delete', 'System\Console\ThemeDelete');
++
+         /*
+          * Register the sidebar for the System main menu
+          */","There is a typo here, this needs to state `october.fresh`"
+6686,"@@ -139,6 +139,18 @@ public class TestHadoopTables {
+     Assert.assertEquals(""Transform must match"", transform, sortOrder.fields().get(0).transform());
+   }
+
++  @Test
++  public void testTableName() {
++    PartitionSpec spec = PartitionSpec.builderFor(SCHEMA)
++        .bucket(""data"", 16)
++        .build();
++    String location = tableDir.toURI().toString();
++    TABLES.create(SCHEMA, spec, location);
++
++    Table table = TABLES.load(location);
++    Assert.assertEquals(""Table name must match"", location, table.name());
++  }
++
+   private static void createDummyTable(File tableDir, File dataDir) throws IOException {
+     Table table = TABLES.create(SCHEMA, tableDir.toURI().toString());
+     AppendFiles append = table.newAppend();",Metadata tables loaded through `HadoopTables` will have their names as location.type (which is weird as we normally use location#type). I am not sure whether it is a big deal or not.
+6687,"@@ -343,7 +343,7 @@ Blockly.VerticalFlyout.prototype.wheel_ = function(e) {
+       delta *= 10;
+     }
+     var metrics = this.getMetrics_();
+-    var pos = metrics.viewTop + delta;
++    var pos = -this.workspace_.scrollY + delta;
+     var limit = metrics.contentHeight - metrics.viewHeight;
+     pos = Math.min(pos, limit);
+     pos = Math.max(pos, 0);",Can you explain why you went from a positive value (metrics.viewTop) to a negative value?
+6688,"@@ -91,4 +91,11 @@ public interface ExternalTaskRestService {
+   @Produces(MediaType.APPLICATION_JSON)
+   BatchDto setRetriesAsync(SetRetriesForExternalTasksDto retriesDto);
+
++  @GET
++  @Path(""/topic-names"")
++  @Produces(MediaType.APPLICATION_JSON)
++  List<String> getTopicNames(@QueryParam(""withLockedTasks"") boolean withLockedTasks,
++      @QueryParam(""withUnlockedTasks"") boolean withUnlockedTasks,
++      @QueryParam(""withRetriesLeft"") boolean withRetriesLeft);
++
+ }",Let's use a dedicated DTO instead of `List<String>` to remain consistent with all other existing REST API endpoints: * Introduce a new DTO class (e. g. `ExternalTaskTopicNameDto`) located under `org.camunda.bpm.engine.rest.dto.externaltask` * The class should have the attribute `topicName` of type `String` * Introduce a getter & setter for the attribute * Convert the list of strings to a list of `ExternalTaskTopicNameDto`s * Change the method signature to return `List<ExternalTaskTopicNameDto>`
+6689,"@@ -42,6 +42,14 @@ public interface RepositoryManager {
+      */
+     ScriptDTO getScript(List<String> path);
+
++    /**
++     * This method returns the {@link org.phoenicis.repository.dto.ScriptDTO} with the given ID
++     *
++     * @param id The script ID
++     * @return The found ScriptDTO
++     */
++    ScriptDTO getScript(String id);
++
+     /**
+      * This method moves the repository, belonging to the given repository url, to the given index.
+      * This is done by swapping the current content at the given index with old index of the given repository url",Do you plan to remove the `ScriptDTO getScript(List<String> path);` method long-term?
+6690,"@@ -134,12 +134,14 @@
+             },
+             types: function() {
+                 var self = this;
+-                var result = this.allTypes.filter(function(item) {
++                if (this.enabledTypes && !this.enabledTypes.length) {
++                    return this.allTypes;
++                }
++                return this.allTypes.filter(function(item) {
+                     return self.enabledTypes.some(function(enabledItem) {
+                         return enabledItem === item.value;
+                     });
+                 });
+-                return result;
+             }
+         }
+     });","@itsiprikshit I used a custom v-model to app count component because the sourceapps component was not reacting to user app count selection, e.g. whenever user changed app count selection, the source apps selection multiplicity remained the same. As a matter of fact, user was able to select one application only. Please let me know if you have any thoughts on this."
+6691,"@@ -4,6 +4,7 @@ from mmcv.cnn import ConvModule, kaiming_init
+ from mmcv.runner import auto_fp16, force_fp32
+
+ from mmdet.models.builder import HEADS
++from mmdet.models.utils import ResLayer, SimplifiedBasicBlock
+
+
+ @HEADS.register_module()","Similarly, we think we may keep `fused_semantic_head.py` unchanged. Then, we could add a new mask head for the desired function."
+6692,"@@ -175,4 +175,10 @@ public class PhpModelTypeNameConverter implements ModelTypeNameConverter {
+   private static String getPhpPackage(ProtoFile file) {
+     return file.getProto().getPackage().replaceAll(""\\."", ""\\\\"");
+   }
++
++  @Override
++  public TypeName getTypeNameForTypedResourceName(
++      ProtoElement elem, String typedResourceShortName) {
++    throw new UnsupportedOperationException(""getTypeNameForTypedResourceName not supported by PHP"");
++  }
+ }",Why implement this? It duplicates the value in FeatureConfig.
+6693,"@@ -159,8 +159,14 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
+
+   @Override
+   public Scan build() {
+-    return new SparkBatchQueryScan(
+-        spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    // TODO: understand how to differentiate that this is a spark streaming microbatch scan.
++    if (false) {
++      return new SparkBatchQueryScan(
++              spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    } else {
++      return new SparkMicroBatchStreamScan(
++              spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    }
+   }
+
+   public Scan buildMergeScan() {","@aokolnychyi / @RussellSpitzer / @holdenk Spark3 gives ScanBuilder - abstraction - to define all types of Scans (Batch, MicroBatch & Continuous). But, the current implementation / class modelling - has SparkBatchScan as the Scan implementation. Looking at some of the concerns of BatchScan - all the way from the State maintenance of a single SnapshotId to read from, the asOfTimeStamp & features like VectorizedReads - all of these don't seem relevant to Streaming Scans. So, I feel that we need to divide out Streaming Scans into a different class. Does this thought process - make sense? If we go by this route - do you folks know - how to pass different Scan objects to Spark based on Batch vs Streaming?"
+6694,"@@ -56,10 +56,7 @@ public final class ClaimTypeConverter implements Converter<Map<String, Object>,
+ 		this.claimTypeConverters.forEach((claimName, typeConverter) -> {
+ 			if (claims.containsKey(claimName)) {
+ 				Object claim = claims.get(claimName);
+-				Object mappedClaim = typeConverter.convert(claim);
+-				if (mappedClaim != null) {
+-					result.put(claimName, mappedClaim);
+-				}
++				result.put(claimName, typeConverter.convert(claim));
+ 			}
+ 		});
+ 		return result;",Will you please update these files to use a copyright end date of 2021?
+6695,"@@ -10,6 +10,17 @@ if (window.__AXE_EXTENSION__) {
+ /*eslint indent: 0*/
+ var testUtils = {};
+
++var fixture = document.createElement('div');
++fixture.setAttribute('id', 'fixture');
++document.body.insertBefore(fixture, document.body.firstChild);
++
++/*eslint no-unused-vars: 0*/
++var checks, commons;
++var originalChecks = (checks = axe._audit.checks);
++var originalAudit = axe._audit;
++var originalRules = axe._audit.rules;
++var originalCommons = (commons = axe.commons);
++
+ /**
+  * Create a check context for mocking/resetting data and relatedNodes in tests
+  *",Adding fixture to the body as we don't have the `runner.tmpl` anymore
+6696,"@@ -6,11 +6,15 @@ import (
+
+ 	log ""github.com/sirupsen/logrus""
+
++	librarygocontroller ""github.com/openshift/library-go/pkg/controller""
++
+ 	corev1 ""k8s.io/api/core/v1""
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/client-go/util/flowcontrol""
+ 	""k8s.io/client-go/util/workqueue""
++	""k8s.io/utils/pointer""
+
+ 	""sigs.k8s.io/controller-runtime/pkg/client""
+ 	""sigs.k8s.io/controller-runtime/pkg/controller""",nit: just for consistency we can move this import block down. Right above openshift/hive imports
+6697,"@@ -57,7 +57,7 @@ class MessageLocationTuple(NamedTuple):
+
+
+ class ManagedMessage(NamedTuple):
+-    """"""Tuple with information ahout a managed message of the linter""""""
++    """"""Tuple with information about a managed message of the linter""""""
+
+     name: Optional[str]
+     msgid: str",Perhaps clean up the commit history and don't squash?
+6698,"@@ -162,7 +162,7 @@ final class ScribeInboundHandler extends ChannelInboundHandlerAdapter {
+           buf.release();
+         }
+       } else {
+-        returned.writeBytes(content.array(), content.offset(), content.length());
++        returned.writeBytes(content.array(), 0, content.length());
+       }
+
+       if (responseIndex == previouslySentResponseIndex + 1) {","Just `writeBytes(content.array())` Back to my original, somewhat broken version ;)"
+6699,"@@ -95,6 +95,16 @@ func TestCrossdock(t *testing.T) {
+ 				""transport"": []string{""http"", ""tchannel""},
+ 			},
+ 		},
++		{
++			name: ""ctxpropagation"",
++			axes: axes{
++				""transport"": []string{""http"", ""tchannel""},
++			},
++			params: params{
++				""ctxserver"": ""127.0.0.1"",
++				""ctxclient"": ""127.0.0.1"",
++			},
++		},
+ 	}
+
+ 	for _, bb := range behaviors {",I couldn't tell from reading the test - do we every criss-cross transports in the same test? I want to make sure we aren't breaking the chain...
+6700,"@@ -10,11 +10,11 @@ import (
+ 	""context""
+ 	""crypto/sha256""
+ 	""encoding/hex""
++	""github.com/facebookgo/clock""
+ 	""math/big""
+ 	""strings""
+ 	""testing""
+
+-	""github.com/facebookgo/clock""
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/require""
+ 	""golang.org/x/crypto/blake2b""",File is not `goimports`-ed
+6701,"@@ -227,9 +227,6 @@ func invokeErrorToYARPCError(err error, responseMD metadata.MD) error {
+
+ // CallStream implements transport.StreamOutbound#CallStream.
+ func (o *Outbound) CallStream(ctx context.Context, request *transport.StreamRequest) (*transport.ClientStream, error) {
+-	if _, ok := ctx.Deadline(); !ok {
+-		return nil, yarpcerrors.InvalidArgumentErrorf(""stream requests require a connection establishment timeout on the passed in context"")
+-	}
+ 	if err := o.once.WaitUntilRunning(ctx); err != nil {
+ 		return nil, err
+ 	}","do we want to still validate that the context had a nonzero TTL? i suppose it's fine to let clients determine whether or not their streams will timeout (though we still don't have the means to cancel them from the server other than EOF), and they can still cancel their own contexts - so maybe not a huge deal, but thought it was worth bringing up."
+6702,"@@ -72,4 +72,9 @@ public class JavaNameFormatter implements NameFormatter {
+   public String classFileNameBase(Name name) {
+     return name.toOriginal();
+   }
++
++  @Override
++  public String humanName(Name name) {
++    throw new UnsupportedOperationException();
++  }
+ }",Go ahead and provide the same implementation for all of the languages - I'm not sure there's a reason for it to be different.
+6703,"@@ -253,6 +253,15 @@ class TestApp(tornado.testing.AsyncHTTPTestCase):
+         assert self.put_json(""/settings"", {""anticache"": True}).code == 200
+         assert self.put_json(""/settings"", {""wtf"": True}).code == 400
+
++    def test_options(self):
++        j = json(self.fetch(""/options""))
++        assert type(j) == list
++        assert type(j[0]) == dict
++
++    def test_option_update(self):
++        assert self.put_json(""/options"", {""anticache"": True}).code == 200
++        assert self.put_json(""/options"", {""wtf"": True}).code == 400
++
+     def test_err(self):
+         with mock.patch(""mitmproxy.tools.web.app.IndexHandler.get"") as f:
+             f.side_effect = RuntimeError","We should also test type confusion here (e.g. `{""anticache"": ""foo""}`)"
+6704,"@@ -236,6 +236,10 @@ MESSAGE
+             end
+
+             sh.cmd 'unformatted=`dartfmt -n .`'
++            # If `dartfmt` fails for some reason
++            sh.if '$? -ne 0' do
++              sh.failure """"
++            end
+             sh.if '! -z ""$unformatted""' do
+               sh.echo ""Files are unformatted:"", ansi: :red
+               sh.echo ""$unformatted""",I'd love to trim the content of `unformatted` too. Any ideas?
+6705,"@@ -17,6 +17,7 @@
+ """"""
+ Utilities to deal with types. This is mostly focused on python3.
+ """"""
++
+ import typing
+ from inspect import getfullargspec
+ from functools import wraps",can you remove this unrelated change?
+6706,"@@ -145,6 +145,17 @@ class MainWindow(QWidget):
+         _private: Whether the window is in private browsing mode.
+     """"""
+
++    # Application wide stylesheets
++    STYLESHEET = """"""
++        QLabel#hint {
++            background-color: {{ conf.colors.hints.bg }};
++            color: {{ conf.colors.hints.fg }};
++            font: {{ conf.fonts.hints }};
++            border: {{ conf.hints.border }};
++            padding-left: -3px;
++        }
++    """"""
++
+     def __init__(self, *, private, geometry=None, parent=None):
+         """"""Create a new main window.
+ ",Would using `HintLabel` here instead (without `setObjectName`) work?
+6707,"@@ -51,7 +51,7 @@ type solver interface {
+ // It is useful for mocking out a given provider since an alternate set of
+ // constructors may be set.
+ type dnsProviderConstructors struct {
+-	cloudDNS   func(project string, serviceAccount []byte, dns01Nameservers []string) (*clouddns.DNSProvider, error)
++	cloudDNS   func(project string, serviceAccountFile string, serviceAccount []byte, dns01Nameservers []string, ambient bool) (*clouddns.DNSProvider, error)
+ 	cloudFlare func(email, apikey string, dns01Nameservers []string) (*cloudflare.DNSProvider, error)
+ 	route53    func(accessKey, secretKey, hostedZoneID, region string, ambient bool, dns01Nameservers []string) (*route53.DNSProvider, error)
+ 	azureDNS   func(clientID, clientSecret, subscriptionID, tenentID, resourceGroupName, hostedZoneName string, dns01Nameservers []string) (*azuredns.DNSProvider, error)","From what I can tell, the `serviceAccountFile` is never set to anything except """"? It'd be best to remove this altogether, so we don't mislead future developers  "
+6708,"@@ -18,11 +18,6 @@
+             </li>
+           </ul>
+         </nav>
+-        <nav>
+-          <ul>
+-            <li class=""account""><%= link_to 'Sign in', sign_in_path %></li>
+-          </ul>
+-        </nav>
+       </div>
+     </section>
+ ",Why do we remove the Sign in link?
+6709,"@@ -186,11 +186,6 @@ public class FeedItemMenuHandler {
+                     GpodnetPreferences.enqueueEpisodeAction(actionNew);
+                 }
+                 break;
+-            case R.id.move_to_top_item:
+-                DBWriter.moveQueueItemToTop(selectedItem.getId(), true);
+-                return true;
+-            case R.id.move_to_bottom_item:
+-                DBWriter.moveQueueItemToBottom(selectedItem.getId(), true);
+             case R.id.add_to_queue_item:
+                 DBWriter.addQueueItem(context, selectedItem);
+                 break;","holy crap, were we really missing a 'break' statement here?"
+6710,"@@ -28,6 +28,10 @@ type logMaker interface {
+ 	MakeLogger(module string) logger.Logger
+ }
+
++type debugForcedLogMaker interface {
++	MakeLoggerForceEnableDebug(module string) logger.Logger
++}
++
+ type blockCacher interface {
+ 	BlockCache() BlockCache
+ }","This doesn't seem to be used anywhere, probably doesn't need to be a new interface."
+6711,"@@ -363,7 +363,9 @@ func (f *FS) Statfs(ctx context.Context, req *fuse.StatfsRequest, resp *fuse.Sta
+ 	usageBytes, limitBytes, err := f.quotaUsage.Get(ctx, quotaUsageStaleTolerance)
+ 	if err != nil {
+ 		f.log.CDebugf(ctx, ""Getting quota usage error: %v"", err)
+-		return err
++		// Ignore the error here so Statfs() can succeeded. Otherwise reading a
++		// public TLF while logged out fails on macOS.
++		return nil
+ 	}
+
+ 	total := getNumBlocksFromSize(uint64(limitBytes))","This is a good start, but what do you think about just using `libkbfs.GetCurrentSessionIfPossible()` to avoid calling this altogether if there's no session? That way we can avoid continuous RTTs to the server when logged out."
+6712,"@@ -0,0 +1,18 @@
++<div class=""dropdown edit_menu"">
++  <%= link_to link_text, edit_path,
++              :id => 'editanchor',
++              :class => ""geolink tab #{link_class}"" %>
++  <a class='dropdown-toggle' data-toggle='dropdown' href='#'>
++    <b class=""caret""></b>
++  </a>
++  <ul class='dropdown-menu' role='menu' aria-labelledby='dLabel'>
++    <% Editors::RECOMMENDED_EDITORS.each do |editor| %>
++      <li>
++        <%= link_to t('layouts.edit_with', :editor => t(""editor.#{editor}.description"")),
++                    edit_path(:editor => editor),
++                    :data => { :editor => editor },
++                    :class => ""geolink #{link_class}"" %>
++      </li>
++    <% end %>
++  </ul>
++</div>","This `aria-labelledby` stuff is all new to me, but my reading of the spec is that the value should be a list of element id values, and `dLabel` doesn't seem to be the id of any element?"
+6713,"@@ -6,16 +6,16 @@ module Bolt
+       class Step
+         class Upload < Step
+           def self.allowed_keys
+-            super + Set['source', 'destination']
++            super + Set['source', 'destination', 'upload']
+           end
+
+           def self.required_keys
+-            Set['destination', 'source', 'targets']
++            Set['upload', 'destination', 'targets']
+           end
+
+           def initialize(step_body)
+             super
+-            @source = step_body['source']
++            @source = step_body['upload'] || step_body['source']
+             @destination = step_body['destination']
+           end
+ ",Does this fail validation if you now use the `upload` key instead of `source`?
+6714,"@@ -733,7 +733,7 @@ CmpStoredProc::ExecStatus CmpStoredProc::close(CmpSPDataObject&)
+ // Methods of CmpISPFuncs
+ // -----------------------------------------------------------------------
+
+-NAList<CmpISPFuncs::ProcFuncsStruct> CmpISPFuncs::procFuncsArray_(256);
++NAList<CmpISPFuncs::ProcFuncsStruct> CmpISPFuncs::procFuncsArray_(NULL,256);
+
+ CmpISPFuncs::CmpISPFuncs()
+ {",Can we use GetCliGlobals(false)->exCollHeap() here instead
+6715,"@@ -17,7 +17,10 @@ namespace storage {
+
+ TEST(AddEdgesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddEdgesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
++    TestUtils::waitUntilAllElected(kv.get(), 0, {0, 1, 2, 3, 4, 5}/*partitions*/);
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddEdgesProcessor::instance(kv.get(),",I suggest you move the waitUntilAllElected into init::KV() method.
+6716,"@@ -28,6 +28,11 @@ namespace OpenTelemetry
+     public class BatchExportProcessor<T> : BaseExportProcessor<T>
+         where T : class
+     {
++        public const int DefaultMaxQueueLength = 2048;
++        public const int DefaultScheduledDelayMilliseconds = 5000;
++        public const int DefaultTimeoutMilliseconds = 30000;
++        public const int DefaultMaxBatchSize = 512;
++
+         private readonly CircularBuffer<T> circularBuffer;
+         private readonly int scheduledDelayMilliseconds;
+         private readonly int exporterTimeoutMilliseconds;",no need of pub;lic.
+6717,"@@ -237,6 +237,10 @@ type ConsensusParams struct {
+
+ 	// max decimal precision for assets
+ 	MaxAssetDecimals uint32
++
++	// whether to use the old buggy Credential.lowestOutput function
++	// TODO(upgrade): Please remove as soon as the upgrade goes through
++	UseBuggyProposalLowestOutput bool
+ }
+
+ // Consensus tracks the protocol-level settings for different versions of the",Do you think we can name this variable in a less ...negative.. language ? maybe `ProposalTieBreakerEqualizer`
+6718,"@@ -48,7 +48,7 @@ class PartitionKey implements StructLike {
+   private final Accessor<InternalRow>[] accessors;
+
+   @SuppressWarnings(""unchecked"")
+-  PartitionKey(PartitionSpec spec) {
++  PartitionKey(PartitionSpec spec, Schema inputSchema) {
+     this.spec = spec;
+
+     List<PartitionField> fields = spec.fields();",Can you add back these newlines? We try to avoid non-functional changes like this because they can cause commit conflicts.
+6719,"@@ -755,7 +755,8 @@ const reducer = (state = defaultState, action) => {
+ 		case 'SEARCH_ADD':
+ 			{
+ 				newState = Object.assign({}, state);
+-				const searches = newState.searches.slice();
++				let searches = newState.searches.slice();
++        searches = searches.filter(s => s.title !== action.search.title);
+ 				searches.push(action.search);
+ 				newState.searches = searches;
+ 			}",Why not just `if (!searches.includes(action.search)) searches.push(action.search)`? That way you don't need to remove then add the element.
+6720,"@@ -276,6 +276,17 @@ class Demo extends AbstractBase
+         return $a . $b . ""."" . $c;
+     }
+
++    /**
++     * Generate a fake call number prefix.
++     *
++     * @return string
++     */
++    protected function getFakeCallNumPrefix()
++    {
++        $codes = ""ABCDEFGHIJKLMNOPQRSTUVWXYZ"";
++        return substr(str_shuffle($codes), 1, rand(0, 3));
++    }
++
+     /**
+      * Get a random ID from the Solr index.
+      *","@demiankatz I'm not sure that this is very useful. I just did it to get started. If we had a small handful of predetermined prefixes that were randomly chosen, it would be easier to distinguish them from the rest of the call number. Would that be preferable?"
+6721,"@@ -313,16 +313,6 @@ func createUpstreamRequest(rw http.ResponseWriter, r *http.Request) (*http.Reque
+ 	// Original incoming server request may be canceled by the
+ 	// user or by std lib(e.g. too many idle connections).
+ 	ctx, cancel := context.WithCancel(r.Context())
+-	if cn, ok := rw.(http.CloseNotifier); ok {
+-		notifyChan := cn.CloseNotify()
+-		go func() {
+-			select {
+-			case <-notifyChan:
+-				cancel()
+-			case <-ctx.Done():
+-			}
+-		}()
+-	}
+
+ 	outreq := r.WithContext(ctx) // includes shallow copies of maps, but okay
+ ",Why is this deleted too?
+6722,"@@ -8,9 +8,9 @@ using System.Threading.Tasks;
+
+ namespace Datadog.Trace.Agent
+ {
+-    internal class ApiWebResponse : IApiResponse
++    internal class ApiWebResponse : IApiResponse, IDisposable
+     {
+-        private HttpWebResponse _response;
++        private readonly HttpWebResponse _response;
+
+         public ApiWebResponse(HttpWebResponse response)
+         {","Given that IApiResponse is already made disposable, this is not necessary."
+6723,"@@ -97,7 +97,10 @@ class ItemPricesOverlay extends Overlay
+ 		switch (action)
+ 		{
+ 			case ITEM_USE_ON_WIDGET:
+-				if (!menuEntry.getTarget().contains(""High Level Alchemy"") || !plugin.isShowAlchProfit()) return null;
++				if (!menuEntry.getTarget().contains(""High Level Alchemy"") || !plugin.isShowAlchProfit())
++				{
++					return null;
++				}
+ 			case WIDGET_DEFAULT:
+ 			case ITEM_USE:
+ 			case ITEM_FIRST_OPTION:",client.getSelectedSpellName() can be used for this
+6724,"@@ -14,6 +14,12 @@
+
+ """"""Common formatting methods.""""""
+
++# Filename patterns.
++VIOLATION_JSON_FMT = 'violations.{}.{}.{}.json'
++SCANNER_OUTPUT_CSV_FMT = 'scanner_output_base.{}.csv'
++FINDINGS_FILENAME = 'forseti_findings_{}.json'
++
++# Timestamps.
+ # Example: '2018-03-01T21:31:52'
+ TIMESTAMP_UTC_OFFSET = '%Y-%m-%dT%H:%M:%S%z'
+ ",Please alpha sort these filenames.
+6725,"@@ -147,17 +147,6 @@ func (p *Protocol) validateTransfer(_ context.Context, act action.Action) error
+ 	if tsf.TotalSize() > TransferSizeLimit {
+ 		return errors.Wrap(action.ErrActPool, ""oversized data"")
+ 	}
+-	// Reject transfer of negative amount
+-	if tsf.Amount().Sign() < 0 {
+-		return errors.Wrap(action.ErrBalance, ""negative value"")
+-	}
+-	// Reject transfer of negative gas price
+-	if tsf.GasPrice().Sign() < 0 {
+-		return errors.Wrap(action.ErrGasPrice, ""negative value"")
+-	}
+-	// check if recipient's address is valid
+-	if _, err := address.FromString(tsf.Recipient()); err != nil {
+-		return errors.Wrapf(err, ""error when validating recipient's address %s"", tsf.Recipient())
+-	}
+-	return nil
++
++	return tsf.SelfCheck()
+ }",is this already called by actPool.validate()?
+6726,"@@ -707,6 +707,16 @@ void updateStereoBonds(RWMOL_SPTR product, const ROMol &reactant,
+
+       if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) {
+         pBond->setStereo(Bond::BondStereo::STEREONONE);
++      } else {
++        // Ring bonds shouldn't be marked as STEREOANY
++
++        if (!product->getRingInfo()->isInitialized()) {
++          MolOps::findSSSR(*product);
++        }
++
++        if (product->getRingInfo()->numBondRings(pBond->getIdx()) > 0) {
++          pBond->setStereo(Bond::BondStereo::STEREONONE);
++        }
+       }
+
+       continue;","It is relatively cheap to tell whether a bond is a ring bond, we don't have to perform an SSSR."
+6727,"@@ -18,7 +18,7 @@ const (
+ 	nameFlag    = ""name""
+ 	svcFlag     = ""svc""
+ 	envFlag     = ""env""
+-	appTypeFlag = ""app-type""
++	svcTypeFlag = ""svc-type""
+ 	profileFlag = ""profile""
+ 	yesFlag     = ""yes""
+ 	jsonFlag    = ""json""",Maybe we should add flag aliases for service as well.
+6728,"@@ -31,10 +31,7 @@ type Block struct {
+ 	Ticket Ticket `json:""ticket""`
+
+ 	// ElectionProof is the vrf proof giving this block's miner authoring rights
+-	ElectionProof crypto.VRFPi
+-
+-	// EPoStInfo wraps all data for verifying this block's Election PoSt
+-	EPoStInfo EPoStInfo `json:""ePoStInfo""`
++	ElectionProof crypto.ElectionProof
+
+ 	// DrandEntries contain the verifiable oracle randomness used to elect
+ 	// this block's author leader","This LGTM but don't we need a winning PoSts field to fully implement the protocol? No need to add here as I'm working on this in another PR, but curious how we can interop with lotus blocks without post proofs."
+6729,"@@ -12,3 +12,10 @@ import ""github.com/iotexproject/iotex-core/blockchain/block""
+ type BlockCreationSubscriber interface {
+ 	ReceiveBlock(*block.Block) error
+ }
++
++// pubSub includes Subscriber, buffered channel for storing the pending blocks and cancel channel to end the handler thread
++type pubSub struct {
++	Blocklistener       BlockCreationSubscriber
++	BlocklistenerBuffer chan *block.Block
++	BlocklistenerCancel chan interface{}
++}","can you move the [] into pubSub? so Blockchain just contains a pubSub, not []"
+6730,"@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 100);
++
++    validateMemoryBreakerThreshold();
+
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ","I don't think 100 is a safe default here, since later we check that the value is between 50-95."
+6731,"@@ -49,5 +49,9 @@ namespace NLog.Layouts
+         /// Layout renderer method can handle concurrent threads
+         /// </summary>
+         ThreadSafe = 1,
++        /// <summary>
++        /// Layout renderer method is agnostic to current thread context
++        /// </summary>
++        ThreadAgnostic = 2 | ThreadSafe,
+     }
+ }","I would be nice if we could describe this without the word ""agnostic"""
+6732,"@@ -406,6 +406,16 @@ class KNNClassifier(object):
+       print ""  active inputs:"", _labeledInput(inputPattern,
+                                               cellsPerCol=self.cellsPerCol)
+
++    if isSparse > 0:
++      isSorted = all(inputPattern[i] <= inputPattern[i+1]
++                     for i in xrange(len(inputPattern)-1))
++      if not isSorted:
++        raise RuntimeError(""Sparse inputPattern must be sorted."")
++
++      if not all(bit < isSparse for bit in inputPattern):
++        raise RuntimeError(""Sparse inputPattern contains an index outside of""
++                           ""the dense representation's bounds."")
++
+     if rowID is None:
+       rowID = self._iterationIdx
+ ",Pick more specific exception types for these cases. Not sure what would be best for this one (`ValueError`?) but the next one could be `IndexError`.
+6733,"@@ -0,0 +1,6 @@
++const jestConfig = require( './jest.config' );
++
++module.exports = {
++	...jestConfig,
++	testMatch: [ '<rootDir>/.storybook/?(*.)test.js' ],
++};",This seemed like the easiest solution We need to include this path in `testMatch` to run the test AFAIK *BUT* we don't want this test ran when running them all normally I'm sure there are other ways to do this!
+6734,"@@ -114,7 +114,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation.Tests
+
+             var ex = Assert.Throws<TTransportException>(() => transport.Flush());
+
+-            Assert.Equal(""Cannot flush closed transport. message, yo"", ex.Message);
++            Assert.Equal(""Cannot flush closed transport"", ex.Message);
+         }
+
+         [Fact]",Most of the following test changes can be avoided if need be.
+6735,"@@ -181,14 +181,8 @@ int Partitioner::Run(const PartitionConfig &config)
+     TIMER_STOP(packed_mlp);
+     util::Log() << ""MultiLevelPartition constructed in "" << TIMER_SEC(packed_mlp) << "" seconds"";
+
+-    TIMER_START(cell_storage);
+-    CellStorage storage(mlp, *edge_based_graph);
+-    TIMER_STOP(cell_storage);
+-    util::Log() << ""CellStorage constructed in "" << TIMER_SEC(cell_storage) << "" seconds"";
+-
+     TIMER_START(writing_mld_data);
+     io::write(config.mld_partition_path, mlp);
+-    io::write(config.mld_storage_path, storage);
+     TIMER_STOP(writing_mld_data);
+     util::Log() << ""MLD data writing took "" << TIMER_SEC(writing_mld_data) << "" seconds"";
+ ",Eventually we might want to move this back as generating this data structure takes some time (for large datasets) and we don't want it in the hot-path of `osrm-customize` runs. Thinking long-term making `osrm-customize` eventually digest `.osrm.cells` will will enable only updating cells selectively and using an earlier customization for the rest.
+6736,"@@ -110,8 +110,15 @@ func (cmd *CommandRun) Wait() error {
+ 	return cmd.vpnServer.Wait()
+ }
+
+-func (cmd *CommandRun) Kill() {
++func (cmd *CommandRun) Kill() (err error) {
+ 	cmd.vpnServer.Stop()
+-	cmd.dialogWaiter.Stop()
+-	cmd.natService.Stop()
++	err = cmd.dialogWaiter.Stop()
++	if err != nil {
++		return err
++	}
++	err = cmd.natService.Stop()
++	if err != nil {
++		return err
++	}
++	return nil
+ }",You're not really using named result variable - you can just leave `error`.
+6737,"@@ -37,16 +37,14 @@ public class SortOrderUtil {
+   }
+
+   public static SortOrder buildSortOrder(Table table) {
+-    return buildSortOrder(table.spec(), table.sortOrder());
++    return buildSortOrder(table.schema(), table.spec(), table.sortOrder());
+   }
+
+-  public static SortOrder buildSortOrder(PartitionSpec spec, SortOrder sortOrder) {
++  public static SortOrder buildSortOrder(Schema schema, PartitionSpec spec, SortOrder sortOrder) {
+     if (sortOrder.isUnsorted() && spec.isUnpartitioned()) {
+       return SortOrder.unsorted();
+     }
+
+-    Schema schema = spec.schema();
+-
+     Multimap<Integer, SortField> sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);
+
+     // build a sort prefix of partition fields that are not already in the sort order",It wasn't possible to call this method with `PartitionSpec.unpartitioned()` as the schema in the spec was empty.
+6738,"@@ -26,11 +26,13 @@ use Thelia\Exception\ModuleException;
+ use Thelia\Log\Tlog;
+ use Thelia\Model\Cart;
+ use Thelia\Model\Country;
++use Thelia\Model\Hook;
+ use Thelia\Model\HookQuery;
+ use Thelia\Model\Lang;
+ use Thelia\Model\Map\ModuleImageTableMap;
+ use Thelia\Model\Map\ModuleTableMap;
+ use Thelia\Model\Module;
++use Thelia\Model\ModuleConfigQuery;
+ use Thelia\Model\ModuleI18n;
+ use Thelia\Model\ModuleI18nQuery;
+ use Thelia\Model\ModuleImage;",this namespace is never used
+6739,"@@ -26,6 +26,13 @@
+ // see URLOpener.
+ // See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
++// Message Delivery Semantics
++//
++// AWS SNS and SQS combine to support at-least-once semantics; applications must
++// call Message.Ack/Nack after processing a message, or it will be redelivered.
++// See https://godoc.org/gocloud.dev/pubsub#hdr-At_most_once_and_At_least_once_Delivery
++// for more background.
++//
+ // Escaping
+ //
+ // Go CDK supports all UTF-8 strings; to make this work with providers lacking","Well, if you call `Nack`, it _will_ be redelivered. So maybe reword."
+6740,"@@ -7,7 +7,9 @@
+
+ <div class=""text-box-wrapper"">
+   <div class=""text-box"">
+-    <p class=""videowrapper""><%= wistia_video_embed('39245f55fd') %></p>
++    <p class=""videowrapper"">
++      <iframe allowtransparency=""true"" class=""wistia_embed"" frameborder=""0"" height=""367"" name=""wistia_embed"" scrolling=""no"" src=""https://fast.wistia.com/embed/iframe/39245f55fd?videoWidth=653&videoHeight=367&controlsVisibleOnLoad=true"" width=""653""></iframe>
++    </p>
+     <h3>An interview with a Ruby developer who uses Linux and full Open Source stack</h3>
+
+     <div class='assets'>",Why did we make this a static string?
+6741,"@@ -148,7 +148,7 @@ def bigquery_dataset(item):
+     parent = item.parent()
+     name = '//bigquery.googleapis.com/projects/{}/datasets/{}'.format(
+         parent['projectNumber'], item['datasetReference']['datasetId'])
+-    asset_type = 'google.bigquery.Dataset'
++    asset_type = 'google.cloud.bigquery.Dataset'
+     parent_name = '//cloudresourcemanager.googleapis.com/projects/{}'.format(
+         parent['projectNumber'])
+     return _create_asset(name, asset_type, parent_name, item.data(), None)",Please re-run PYTHONPATH=. python tests/services/inventory/update_cai_dumps.py following the instructions at the top of this file to ensure the test files have the correct CAI asset type.
+6742,"@@ -66,9 +66,9 @@ func TestCreateContract(t *testing.T) {
+ 	addr := identityset.Address(28)
+ 	_, err = accountutil.LoadOrCreateAccount(sm, addr.String())
+ 	require.NoError(err)
+-	stateDB := NewStateDBAdapter(sm, 0, !cfg.Genesis.IsAleutian(0),
+-		cfg.Genesis.IsGreenland(0), cfg.Genesis.IsKamchatka(0),
+-		cfg.Genesis.IsLordHowe(0), hash.ZeroHash256)
++	opt := []StateDBAdapterOption{NotFixTopicCopyBugOption()}
++	stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, opt...)
++
+ 	contract := addr.Bytes()
+ 	var evmContract common.Address
+ 	copy(evmContract[:], contract[:])","`stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, NotFixTopicCopyBugOption())`"
+6743,"@@ -446,8 +446,17 @@ class HintManager(QObject):
+         # Short hints are the number of hints we can possibly show which are
+         # (needed - 1) digits in length.
+         if needed > min_chars:
+-            short_count = math.floor((len(chars) ** needed - len(elems)) /
+-                                     len(chars))
++            total_space = len(chars) ** needed
++            # Calculate short_count naively, by finding the avaiable space and
++            # dividing by the number of spots we would loose by adding a
++            # short element
++            short_count = math.floor((total_space - len(elems)) /
++                                     (len(chars)))
++            # Check if we double counted above to warrant another short_count
++            # https://github.com/qutebrowser/qutebrowser/issues/3242
++            if total_space - (short_count * len(chars) +
++                              (len(elems) - short_count)) >= len(chars) - 1:
++                short_count += 1
+         else:
+             short_count = 0
+ ","There are unneeded parens here, but I'll fix it up when merging."
+6744,"@@ -62,6 +62,12 @@ static void setup_globals(mrb_state *mrb)
+
+     h2o_mruby_eval_expr(mrb, ""$LOAD_PATH << \""#{$H2O_ROOT}/share/h2o/mruby\"""");
+     h2o_mruby_assert(mrb);
++
++    /* require and include built-in libraries */
++    h2o_mruby_eval_expr(mrb, ""require \""h2o.rb\""\n""
++                             ""require \""acl.rb\""\n""
++                             ""include H2O::ACL\n"");
++    h2o_mruby_assert(mrb);
+ }
+
+ mrb_value h2o_mruby_to_str(mrb_state *mrb, mrb_value v)",Just one more thing... How about doing all of the following? 1. renaming h2o.rb to bootstrap.rb 2. require and include the acl code _from_ bootstrap.rb
+6745,"@@ -82,14 +82,6 @@ double get_timestamp (void)
+     return ((double) tm.tv_sec + (tm.tv_nsec/1.0e9));
+ }
+
+-static void timeout_cb (flux_t *h, cron_task_t *t, void *arg)
+-{
+-    cron_entry_t *e = arg;
+-    flux_log (h, LOG_INFO, ""cron-%ju: task timeout at %.2fs. Killing"",
+-              e->id, e->timeout);
+-    cron_task_kill (t, SIGTERM);
+-}
+-
+ static int cron_entry_run_task (cron_entry_t *e)
+ {
+     flux_t *h = e->ctx->h;","Commit message: ""remove"" is misspelled."
+6746,"@@ -60,6 +60,11 @@ public abstract class BytesValues {
+     return value.slice(toTrim);
+   }
+
++  public static BytesValue trimTrailingZeros(final BytesValue value) {
++    final int toTrim = trailingZeros(value);
++    return value.slice(0, value.size() - toTrim + 1);
++  }
++
+   /**
+    * Returns the smallest bytes value whose bytes correspond to the provided long. That is, the
+    * returned value may be of size less than 8 if the provided int has leading zero bytes.",This is a pretty idiosyncratic method - I'd move it into the JSON-RPC package rather than adding it to `BytesValue`.
+6747,"@@ -424,11 +424,15 @@ module RSpec
+           superclass.method(:next_runnable_index_for),
+           description, *args, &example_group_block
+         )
++
++        config = RSpec.configuration
++        config.apply_derived_metadata_to(@metadata)
++
+         ExampleGroups.assign_const(self)
+
+         @currently_executing_a_context_hook = false
+
+-        RSpec.configuration.configure_group(self)
++        config.configure_group(self)
+       end
+
+       # @private",Is there a way to deduplicate this somehow? Could we roll it into `RSpec.configuration` with a bit of memoization or is there a chicken and egg problem.
+6748,"@@ -49,6 +49,7 @@ public class ResultSetPropertyTester extends PropertyTester
+     public static final String PROP_CAN_NAVIGATE_HISTORY = ""canNavigateHistory"";
+     public static final String PROP_EDITABLE = ""editable"";
+     public static final String PROP_CHANGED = ""changed"";
++    private static final String PROP_UPDATE_NOT_IN_PROGRESS = ""updateNotInProgress"";
+
+     private static final Log log = Log.getLog(ResultSetPropertyTester.class);
+ ","Generally, I wouldn't say I like the idea of providing properties that return negative/inverted values. It would be more convenient to return whether the update is **in** progress or not."
+6749,"@@ -256,7 +256,7 @@ import 'flexStyles';
+             const runtimeTicks = playbackManager.duration(options.player);
+
+             if (runtimeTicks) {
+-                const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player);
++                const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player) * 10000;
+
+                 return Math.round(timeRemainingTicks / 10000);
+             }","Converting playbackManager to operate in ms (preferred solution, imo) would allow us to completely drop this function."
+6750,"@@ -8,6 +8,7 @@
+
+ DEFINE_int32(max_handlers_per_req, 10, ""The max handlers used to handle one request"");
+ DEFINE_int32(min_vertices_per_bucket, 3, ""The min vertices number in one bucket"");
++DEFINE_int32(max_edge_returned_per_vertex, 1000, ""The max edge number returnred searching vertex"");
+
+ namespace nebula {
+ namespace storage {","The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc."
+6751,"@@ -221,7 +221,10 @@ func (c *cliApp) settle(args []string) {
+ 		clio.Info(fmt.Sprintf(""Hermes fee: %v MYST"", hermesFee.String()))
+ 		return
+ 	}
+-	hermesID := c.config.GetStringByFlag(config.FlagHermesID)
++	hermesID, err := c.config.GetHermesID()
++	if err != nil {
++		clio.Warn(""could not get hermes id: "", err)
++	}
+ 	clio.Info(""Waiting for settlement to complete"")
+ 	errChan := make(chan error)
+ ",Probably missing return here as well
+6752,"@@ -109,6 +109,12 @@ type ConfigSettings struct {
+ 	//
+ 	// EXPERIMENTAL: Subject to change.
+ 	LoadRaw json.RawMessage `json:""load,omitempty"" caddy:""namespace=caddy.config_loaders inline_key=module""`
++
++	// The interval to pull config. With a non-zero value, will pull config
++	// from config loader (eg. a http loader) with given interval.
++	//
++	// EXPERIMENTAL: Subject to change.
++	PullInterval Duration `json:""pull_interval,omitempty""`
+ }
+
+ // IdentityConfig configures management of this server's identity. An identity","On second thought... this affects how often the function specified by the `load` property is run. So I wonder if, for consistency, we should call this `LoadInterval` instead. Does that make sense?"
+6753,"@@ -2,7 +2,8 @@ var exported = {},
+     common = require('../../../api/utils/common.js'),
+     crypto = require('crypto'),
+     countlyCommon = require('../../../api/lib/countly.common.js'),
+-    plugins = require('../../pluginManager.js');
++    plugins = require('../../pluginManager.js'),
++    localize = require('../../../api/utils/localization.js');
+ (function() {
+     /**
+      *    register internalEvent",Now you don't need the localization module here then :)
+6754,"@@ -264,11 +264,16 @@ public class InclusiveMetricsEvaluator {
+
+     @Override
+     public <T> Boolean in(BoundReference<T> ref, Set<T> literalSet) {
+-      return ROWS_MIGHT_MATCH;
++      // in(col, {X, Y}) => eq(col, x) OR eq(col, x)
++      if (literalSet.stream().anyMatch(v -> eq(ref, toLiteral(v)))) {
++        return ROWS_MIGHT_MATCH;
++      }
++      return ROWS_CANNOT_MATCH;
+     }
+
+     @Override
+     public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {
++      // notIn(col, {X, Y}) => notEq(col, x) AND notEq(col, x)
+       return ROWS_MIGHT_MATCH;
+     }
+ ","This should not convert each value to a literal on every invocation. Instead, this PR can add a `literals` method to `BoundSetPredicate` to access the values as literals. That way, the conversion happens once and can be lazy."
+6755,"@@ -22,7 +22,7 @@ def _load_lib():
+     """"""Load LightGBM Library.""""""
+     lib_path = find_lib_path()
+     if len(lib_path) == 0:
+-        raise Exception(""cannot find LightGBM library"")
++        return None
+     lib = ctypes.cdll.LoadLibrary(lib_path[0])
+     lib.LGBM_GetLastError.restype = ctypes.c_char_p
+     return lib",I think we still need this exception if doesn't have LIGHTGBM_BUILD_DOC
+6756,"@@ -71,15 +71,9 @@ func (h *Helper) waitForCertificateCondition(client clientset.CertificateInterfa
+ 	if pollErr != nil && certificate != nil {
+ 		log.Logf(""Failed waiting for certificate %v: %v\n"", name, pollErr.Error())
+
+-		if len(certificate.Status.Conditions) > 0 {
+-			log.Logf(""Observed certificate conditions:\n"")
+-			for _, cond := range certificate.Status.Conditions {
+-				log.Logf(""- Last Status: '%s' Reason: '%s', Message: '%s'\n"", cond.Status, cond.Reason, cond.Message)
+-			}
+-		}
++		log.Logf(""Certificate:\n"")
++		h.describeCMObject(certificate)
+
+-		log.Logf(""Certificate description:\n"")
+-		h.Kubectl(certificate.Namespace).DescribeResource(""certificate"", name)
+ 		log.Logf(""Order and challenge descriptions:\n"")
+ 		h.Kubectl(certificate.Namespace).Describe(""order"", ""challenge"")
+ ",Does this make it easier to read? Previously this would have run `kubectl describe certificate` right? In which case it would have included events related to the cert. Will we miss that? Would the old `kubectl describe` output have gone to stderr?
+6757,"@@ -24,11 +24,14 @@ import com.google.gson.annotations.SerializedName;
+ public class Internals {
+
+   public static final String SERIALIZED_APPLICATION_SERVER = ""application-server"";
++  public static final String SERIALIZED_CAMUNDA_INTEGRATION = ""camunda-integration"";
+
+   protected Database database;
+   @SerializedName(value = SERIALIZED_APPLICATION_SERVER)
+   protected ApplicationServer applicationServer;
+   protected Map<String, Command> commands;
++  @SerializedName(value = SERIALIZED_CAMUNDA_INTEGRATION)
++  protected Map<String, Object> camundaIntegration;
+
+   protected Map<String, Metric> metrics;
+ ","Just an understanding question: do we need a map here, would a list/set of Strings be sufficient? we are not adding entries with `false` here, are we? Being in the list already means it's used, right?"
+6758,"@@ -567,7 +567,8 @@ class CentralPlannerScheduler(Scheduler):
+
+         for task in self._state.get_active_tasks():
+             self._state.fail_dead_worker_task(task, self._config, assistant_ids)
+-            if task.id not in necessary_tasks and self._state.prune(task, self._config):
++            removed = self._state.prune(task, self._config)
++            if removed and task.id not in necessary_tasks:
+                 remove_tasks.append(task.id)
+
+         self._state.inactivate_tasks(remove_tasks)","Ah, so the change is that you want the `prune()` side effect before doing the `task.id not in necessary_tasks` membership check? Stupid non-Haskell programming languages :p"
+6759,"@@ -2,6 +2,13 @@ package cmd
+
+ import (
+ 	""fmt""
++	""os""
++	osexec ""os/exec""
++	""path/filepath""
++	""strings""
++	""testing""
++	""time""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.
+6760,"@@ -494,6 +494,8 @@ function findAndModify(coll, query, sort, doc, options, callback) {
+     queryObject.bypassDocumentValidation = finalOptions.bypassDocumentValidation;
+   }
+
++  finalOptions.readPreference = ReadPreference.primary;
++
+   // Have we specified collation
+   decorateWithCollation(queryObject, coll, finalOptions);
+ ",Do we normally force ReadPreference primary on other write operations? Or is it just that we normally ignore it?
+6761,"@@ -292,6 +292,12 @@ public class Spark3Util {
+             return Expressions.hours(sourceName);
+           }
+
++          @Override
++          public Transform alwaysNull(int fieldId, String sourceName, int sourceId) {
++            // do nothing for alwaysNull, it doesn't need to be converted to a transform
++            return null;
++          }
++
+           @Override
+           public Transform unknown(int fieldId, String sourceName, int sourceId, String transform) {
+             return Expressions.apply(transform, Expressions.column(sourceName));","Instead of returning null here and discarding nulls automatically, I think this should return null (or some other signaling value) and fix the part that consumes the output of the visitor."
+6762,"@@ -95,8 +95,13 @@ public class ForkingValidatorProvider implements ValidatorProvider {
+         final long prevBlockNumber = blockNumber - 1L;
+         final Optional<BlockHeader> prevBlockHeader = blockchain.getBlockHeader(prevBlockNumber);
+         if (prevBlockHeader.isPresent()) {
+-          return resolveValidatorProvider(prevBlockNumber)
+-              .getValidatorsForBlock(prevBlockHeader.get());
++          final Collection<Address> validatorsForPreviousBlock =
++              resolveValidatorProvider(prevBlockNumber)
++                  .getValidatorsForBlock(prevBlockHeader.get());
++          // Update VoteTallyCache
++          blockValidatorProvider.setValidatorsForBlock(
++              prevBlockHeader.get(), validatorsForPreviousBlock);
++          return validatorsForPreviousBlock;
+         }
+       }
+       return getValidators.apply(validatorProvider);","Really, we want to be setting the validatorsForPreviousBlock against the yet to be created block, so it might make sense to update the cache once the block is created/imported instead."
+6763,"@@ -60,11 +60,11 @@ int set_properties_from_args(fpga_properties filter, fpga_result *result,
+ 		{""segment"", required_argument, NULL, 0xe},
+ 		{0, 0, 0, 0},
+ 	};
+-	int supported_options = sizeof(longopts) / sizeof(longopts[0]) - 1;
+ 	int getopt_ret = -1;
+ 	int option_index = 0;
+ 	char *endptr = NULL;
+ 	int found_opts[] = {0, 0, 0, 0};
++	int supported_options = sizeof(found_opts) / sizeof(int);
+ 	int next_found = 0;
+ 	int old_opterr = opterr;
+ 	opterr = 0;",It seems to me that the original implementation was correct. Can you share what the scanner was pointing out?
+6764,"@@ -178,6 +178,8 @@ function* webpackConfig( env, argv ) {
+ 				'./assets/js/googlesitekit-modules-search-console.js',
+ 			'googlesitekit-modules-subscribe-with-google':
+ 				'./assets/js/googlesitekit-modules-subscribe-with-google.js',
++			'googlesitekit-subscribe-with-google-bulk-edit':
++				'./assets/js/modules/subscribe-with-google/bulk-edit.js',
+ 			'googlesitekit-modules-tagmanager':
+ 				'./assets/js/googlesitekit-modules-tagmanager.js',
+ 			'googlesitekit-user-input':","Instead of doing that, please create an `assets/js/googlesitekit-subscribe-with-google-bulk-edit.js` file as entry point - all our entry points should be located in `assets/js`."
+6765,"@@ -39,7 +39,11 @@ storiesOf( 'WordPress', module )
+ 			<div id=""dashboard-widgets"">
+ 				<div className=""metabox-holder"">
+ 					<div id=""google_dashboard_widget"" className=""postbox"">
+-						<h2 className=""hndle ui-sortable-handle""><span><SvgIcon id=""logo-g"" height=""19"" width=""19"" /><SvgIcon id=""logo-sitekit"" height=""17"" width=""78"" /></span>
++						<h2 className=""hndle ui-sortable-handle"">
++							<span><div className=""googlesitekit-logo googlesitekit-logo-mini"">
++								<SvgIcon id=""logo-g"" height=""19"" width=""19"" />
++								<SvgIcon id=""logo-sitekit"" height=""17"" width=""78"" />
++							</div></span>
+ 						</h2>
+ 						<div className=""inside"">
+ 							<div id=""js-googlesitekit-wp-dashboard"">","This is not valid, a `div` shouldn't be in a `span`. You could apply the `className` attribute to the `span` tag."
+6766,"@@ -100,6 +100,8 @@ func AddFlags(flagSet *pflag.FlagSet) {
+ 	flags.IntVarP(flagSet, &fs.Config.MultiThreadStreams, ""multi-thread-streams"", """", fs.Config.MultiThreadStreams, ""Max number of streams to use for multi-thread downloads."")
+ 	flags.DurationVarP(flagSet, &fs.Config.RcJobExpireDuration, ""rc-job-expire-duration"", """", fs.Config.RcJobExpireDuration, ""expire finished async jobs older than this value"")
+ 	flags.DurationVarP(flagSet, &fs.Config.RcJobExpireInterval, ""rc-job-expire-interval"", """", fs.Config.RcJobExpireInterval, ""interval to check for expired async jobs"")
++	flags.DurationVarP(flagSet, &fs.Config.TransferredExpireDuration, ""accounting-transferred-expire-duration"", """", fs.Config.TransferredExpireDuration, ""remove transferred accounting stats older than this value"")
++	flags.DurationVarP(flagSet, &fs.Config.TransferredExpireInterval, ""accounting-transferred-expire-interval"", """", fs.Config.TransferredExpireInterval, ""interval to check for expired transferred accounting stats"")
+ }
+
+ // SetFlags converts any flags into config which weren't straight forward",Would it be possible to reuse RcJobExpireDuration and RcJobExpireInterval and auto delete them when job is deleted?
+6767,"@@ -18,7 +18,13 @@
+ #  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ #  THE SOFTWARE.
+
++from __future__ import print_function
++
+ import copy
++import sys
++
++from jinja2 import Environment
++from jinja2 import PackageLoader
+
+
+ def merge_dicts(a, b, raise_conflicts=False, path=None):",Python wants **future** imports to come first.
+6768,"@@ -2267,4 +2267,5 @@ detach_on_permanent_stack(bool internal, bool do_cleanup, dr_stats_t *drstats)
+     SELF_PROTECT_DATASEC(DATASEC_RARELY_PROT);
+     dynamo_detaching_flag = LOCK_FREE_STATE;
+     EXITING_DR();
++    options_detach();
+ }",Better to call this before EXITING_DR which is supposed to be last.
+6769,"@@ -295,8 +295,6 @@ public class MainActivity extends BaseActivity implements CustomTabActivityHelpe
+                     switch ((int) drawerItem.getIdentifier()) {
+                         case ITEM_HOME:
+                             fragment = new HomeFragment();
+-                            // recreate when Home is pressed
+-                            recreate();
+                             break;
+                         case ITEM_SEARCH_BY_CODE:
+                             fragment = new FindProductFragment();",Does this work at runtime?
+6770,"@@ -24,8 +24,9 @@ import (
+ const (
+ 	userAgentHeader = ""User-Agent""
+
+-	credsTimeout  = 10 * time.Second
+-	clientTimeout = 30 * time.Second
++	maxRetriesOnRecoverableFailures = 8 // Default provided by SDK is 3 which means requests are retried up to only 2 seconds.
++	credsTimeout                    = 10 * time.Second
++	clientTimeout                   = 30 * time.Second
+ )
+
+ // Provider provides methods to create sessions.",Hmm why do we need to make this change? Like which one requires this change?
+6771,"@@ -4,12 +4,6 @@
+ // Use define from require.js not webpack's define
+ var _define = window.define;
+
+-// document-register-element
+-var docRegister = require(""document-register-element"");
+-_define(""document-register-element"", function() {
+-    return docRegister;
+-});
+-
+ // fetch
+ var fetch = require(""whatwg-fetch"");
+ _define(""fetch"", function() {",why remove this and other piece?
+6772,"@@ -41,7 +41,7 @@ describe('dom.hasContentVirtual', function() {
+ 	it('is false if the element has an aria label but `ignoreAria=true`', function() {
+ 		fixture.innerHTML = '<div id=""target"" aria-label=""my-label"">	</div>';
+ 		tree = axe.utils.getFlattenedTree(fixture);
+-		assert.isTrue(
++		assert.isFalse(
+ 			hasContentVirtual(
+ 				axe.utils.querySelectorAll(tree, '#target')[0],
+ 				true,",Yikes... That was probably me.
+6773,"@@ -622,7 +622,7 @@ class Application extends BaseApplication {
+
+ 		// the following menu items will be available for all OS under Tools
+ 		const toolsItemsAll = [{
+-			label: _('Resources'),
++			label: _('Note attachments...'),
+ 			click: () => {
+ 				this.dispatch({
+ 					type: 'NAV_GO',",It would be better to move the ... outside of the l8n block. This way it won't need to be translated for each language twice.
+6774,"@@ -35,6 +35,11 @@
+ #include ""monster.h""
+ #include ""scheduler.h""
+ #include ""databasetasks.h""
++#include ""actions.h""
++#include ""movement.h""
++#include ""weapons.h""
++#include ""globalevent.h""
++#include ""events.h""
+
+ extern Chat* g_chat;
+ extern Game g_game;",That's a huge load of new dependencies. I think it's better to create a reload function on ScriptManager and control with enum instead.
+6775,"@@ -42,6 +42,7 @@ func NewJob() *cobra.Command {
+ 		NewUpgradeJivaVolumeJob(),
+ 		NewUpgradeCStorSPCJob(),
+ 		NewUpgradeCStorVolumeJob(),
++		NewUpgradeTaskJob(),
+ 	)
+
+ 	cmd.PersistentFlags().StringVarP(&options.fromVersion,",`NewUpgradeTaskJob` -> `NewUpgradeResource`
+6776,"@@ -0,0 +1,16 @@
++#include ""system.h""
++
++#include <glibtop.h>
++#include <glibtop/mem.h>
++
++#include <glib.h>
++#include <unistd.h>
++
++int luaA_sys_get_meminfo(lua_State *L)
++{
++    glibtop_mem mem;
++    glibtop_init();
++    glibtop_get_mem(&mem);
++    lua_pushinteger(L, mem.cached);
++    return 1;
++}",Is that the memory usage of the system or the process / awesome?
+6777,"@@ -209,8 +209,8 @@ class Realm {
+     /**
+      * Add a listener `callback` for the specified event `name`.
+      * @param {string} name - The name of event that should cause the callback to be called.
+-     *   _Currently, only the ""change"" event supported_.
+-     * @param {callback(Realm, string)} callback - Function to be called when the event occurs.
++     *   _Currently, only the ""change"" or ""schema"" events supported_.
++     * @param {callback(Realm, string)|callback(Realm, Schema)} callback - Function to be called when a change event occurs.
+      *   Each callback will only be called once per event, regardless of the number of times
+      *   it was added.
+      * @throws {Error} If an invalid event `name` is supplied, or if `callback` is not a function.","""change"" *and* ""schema"" events (A bunch of these; not marking them all)."
+6778,"@@ -73,4 +73,13 @@ public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+    * @return this for method chaining
+    */
+   RewriteFiles validateFromSnapshot(long snapshotId);
++
++  /**
++   * Use the specified sequence number for the new manifest of the data files added in this update,
++   * instead of inheriting the sequence number of the snapshot that will be created.
++   *
++   * @param sequenceNumber a sequence number
++   * @return this for method chaining
++   */
++  RewriteFiles overrideSequenceNumberForNewDataFiles(long sequenceNumber);
+ }","I think there is probably a shorter, more descriptive name for this. Something like `commitAtSequenceNumber`?"
+6779,"@@ -23,6 +23,7 @@ class Organization < ActiveRecord::Base
+   scope :case_insensitive_url_name, ->(mixed_case) { where(['lower(url_name) = ?', mixed_case.downcase]) }
+
+   validates :name, presence: true, length: 3..85, uniqueness: { case_sensitive: false }
++  validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: true, case_sensitive: false
+   validates :description, length: 0..800, allow_nil: true
+   validates :org_type, inclusion: { in: ORG_TYPES.values }
+   before_validation :clean_strings_and_urls",The `url_name` should definitely be more than just 1 character long at the shortest. How about 3 or 4 characters?
+6780,"@@ -22,9 +22,6 @@
+ *  This copyright notice MUST APPEAR in all copies of the script!
+ ***************************************************************/
+
+-use TYPO3\CMS\Core\Utility\GeneralUtility;
+-use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
+-
+
+ /**
+  * Page Indexer to index TYPO3 pages used by the Index Queue.",Please revert this change
+6781,"@@ -57,13 +57,10 @@ module OrgAdmin
+     # preview a phase
+     # GET /org_admin/phases/[:id]/preview
+     def preview
+-      phase = Phase.includes(:template).find(params[:id])
+-      authorize phase
+-      render(""/org_admin/phases/preview"",
+-        locals: {
+-          template: phase.template,
+-          phase: phase
+-        })
++      @phase = Phase.includes(:template).find(params[:id])
++      authorize @phase
++      @template = @phase.template
++      @guidance_presenter = GuidancePresenter.new(Plan.new(template: @phase.template))
+     end
+
+     # add a new phase to a passed template",Nice. I hadn't even heard of presenters in Rails before (learn something new every day) :)
+6782,"@@ -22,10 +22,19 @@ class Pool
+      */
+     protected $providers = array();
+
++    /**
++     * @var array
++     */
+     protected $contexts = array();
+
++    /**
++     * @var DownloadStrategyInterface[]
++     */
+     protected $downloadSecurities = array();
+
++    /**
++     * @var string
++     */
+     protected $defaultContext;
+
+     /**","`string[]` ? not sure, can you verify this @core23 ? Thank you"
+6783,"@@ -1224,12 +1224,14 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+             return null;
+         }
+
++        let playPauseClickTimeout;
+         function onViewHideStopPlayback() {
+             if (playbackManager.isPlayingVideo()) {
+                 require(['shell'], function (shell) {
+                     shell.disableFullscreen();
+                 });
+
++                clearTimeout(playPauseClickTimeout);
+                 var player = currentPlayer;
+                 view.removeEventListener(""viewbeforehide"", onViewHideStopPlayback);
+                 releaseCurrentPlayer();",are we aware that this breaks older browsers like WebOS? :) they don't handle `let`
+6784,"@@ -86,7 +86,7 @@ class Cache(CacheBase):
+         if ttl == 0:
+             self.delete(key)
+         else:
+-            # We can't use touch here because we need to update the TTL value in the record.
++            # We can't use touch here because we need to update the TTL value in the object.
+             value = self.get(key)
+             self.set(key, value, ttl)
+ ",This isn't really a Kinto record but a Memcached record. I could kind of go either way on this.
+6785,"@@ -582,6 +582,7 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+                     displayName(accountOptions.displayName).email(accountOptions.email).
+                     photoUrl(accountOptions.photoUrl).thumbnailUrl(accountOptions.thumbnailUrl).
+                     additionalOauthValues(accountOptions.additionalOauthValues).build();
++            account.downloadProfilePhoto();
+             if (id.customAttributes != null) {
+                 mgr.getAdminSettingsManager().setPrefs(id.customAttributes, account);
+             }",Kick off the download after login.
+6786,"@@ -286,7 +286,7 @@ class ErrorBaseline
+         $xml = preg_replace_callback(
+             '/<files (psalm-version=""[^""]+"") (?:php-version=""(.+)""(\/?>)\n)/',
+             /**
+-             * @param array<int, string> $matches
++             * @param string[] $matches
+              */
+             function (array $matches) : string {
+                 return","I don't think you need to change this, `array<int, string>` should be accepted whenever `string[]` is expected. (`string[]` is an alias of `array<string>` itself an alias of `array<array-key, string>` which is a parent type of `array<int, string>`"
+6787,"@@ -1257,8 +1257,9 @@ bool wlr_seat_touch_has_grab(struct wlr_seat *seat) {
+ }
+
+ bool wlr_seat_validate_grab_serial(struct wlr_seat *seat, uint32_t serial) {
+-	return serial == seat->pointer_state.grab_serial ||
+-		serial == seat->touch_state.grab_serial;
++	return true;
++	//return serial == seat->pointer_state.grab_serial ||
++	//	serial == seat->touch_state.grab_serial;
+ }
+
+ struct wlr_seat_client *wlr_seat_client_from_resource(","TODO: fix this, probably in another PR"
+6788,"@@ -591,6 +591,17 @@ class HintManager(QObject):
+             message.error(""No elements found."")
+             return
+
++        # Because _start_cb is called asynchronously, it's possible that the
++        # user switched to another tab or closed the tab/window. In that case
++        # we should not start hinting.
++        tabbed_browser = objreg.get('tabbed-browser', default=None,
++                scope='window', window=self._win_id)
++        if tabbed_browser is None:
++            return
++        tab = tabbed_browser.widget.currentWidget()
++        if tab is None or tab.tab_id != self._tab_id:
++            return
++
+         strings = self._hint_strings(elems)
+         log.hints.debug(""hints: {}"".format(', '.join(strings)))
+ ",Is there any case that tab is None?
+6789,"@@ -132,8 +132,14 @@ func (e *endpoint) Apply(ctx context.Context, req ctrl.Request, chaos v1alpha1.I
+ 			Namespace: pod.Namespace,
+ 		})
+
+-		t.Append(sourceSet)
+-		t.Append(targetSet)
++		e := t.Append(sourceSet)
++		if e != nil {
++			return e
++		}
++		e = t.Append(targetSet)
++		if e != nil {
++			return e
++		}
+ 	}
+
+ 	sourcesChains := []v1alpha1.RawIptables{}",pls use `err` instead of `e`
+6790,"@@ -159,7 +159,9 @@ function attachGamepadScript(e) {
+ }
+
+ // No need to check for gamepads manually at load time, the eventhandler will be fired for that
+-window.addEventListener(""gamepadconnected"", attachGamepadScript);
++if (navigator.getGamepads) { /* eslint-disable-line compat/compat */
++    window.addEventListener(""gamepadconnected"", attachGamepadScript);
++}
+
+ export default {
+     enable: enable,",`attachGamepadScript` above can also be placed inside.
+6791,"@@ -108,7 +108,7 @@ func decodeBytecode() ([]byte, error) {
+ 	return hex.DecodeString(util.TrimHexPrefix(bytecodeFlag.Value().(string)))
+ }
+
+-func signer() (address string, err error) {
++func Signer() (address string, err error) {
+ 	return util.GetAddress(signerFlag.Value().(string))
+ }
+ ","when we use RegisterWriteCommand,this func should be exported,so we can use this to get signer at the outside action package"
+6792,"@@ -123,7 +123,7 @@ func (management *Management) serveNewConnection(connection net.Conn) {
+ func (management *Management) deliverLines() {
+ 	for {
+ 		line := <-management.lineReceiver
+-		log.Debug(management.logPrefix, ""Line delivering: "", line)
++		// log.Debug(management.logPrefix, ""Line delivering: "", line)
+
+ 		lineConsumed := false
+ 		for _, middleware := range management.middlewares {",Dead code - we should remove it or use `log.Trace` for lower logging level. Same applies for change at line 138.
+6793,"@@ -55,6 +55,11 @@ boost::optional<ParameterT> parseParameters(std::string::iterator &iter,
+         // iterator to the failing position. Extract the position from the exception ourselves.
+         iter = failure.first;
+     }
++    catch (const boost::numeric::bad_numeric_cast &e)
++    {
++        // this can happen if we get bad numeric values in the request, just handle
++        // as normal parser error
++    }
+
+     return boost::none;
+ }",How does this make sure invalid coordinates making the parser fail? Relying on the Coordinate type's boost numeric_cast calls in the ctor? Shouldn't we rely on a coordinate's `.IsValid()` member function instead?
+6794,"@@ -1,8 +1,11 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
+ # This code example demonstrates how to upload an item
+-# (file) to a folder within a bucket in Amazon S3.
++# (file) to a folder within a bucket in Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3-ruby-example-upload-item-to-folder]
+
+ # Prerequisites:
+ #  - An existing Amazon S3 bucket.",Simple Storage **Service**
+6795,"@@ -54,6 +54,8 @@ if (!is_dir($cacheDir)) {
+ // Enable caching unless in dev mode or running tests:
+ $useCache = APPLICATION_ENV != 'development' && !defined('VUFIND_PHPUNIT_RUNNING');
+
++defined('CACHE_ENABLED') || define('CACHE_ENABLED', $useCache);
++
+ // Build configuration:
+ return [
+     'modules' => array_unique($modules),",Does this line (and the corresponding one in the test bootstrap) actually do anything? I don't see where CACHE_ENABLED is used as a global constant.
+6796,"@@ -445,13 +445,14 @@ func assertResolved(f func(target *api.Container, dep *api.Container) bool, targ
+ 	}
+ }
+
+-func TestTransitionDependenciesResolved(t *testing.T) {
++func TestVerifyTransitionDependenciesResolved(t *testing.T) {
+ 	testcases := []struct {
+ 		Name             string
+ 		TargetKnown      api.ContainerStatus
+ 		TargetDesired    api.ContainerStatus
++		TargetNext       api.ContainerStatus
++		DependencyName   string
+ 		DependencyKnown  api.ContainerStatus
+-		DependentStatus  api.ContainerStatus
+ 		SatisfiedStatus  api.ContainerStatus
+ 		ExpectedResolved bool
+ 	}{","has this changed? are we testing ""all possible situations"" now?"
+6797,"@@ -236,13 +236,13 @@ public class SolrCLI implements CLIO {
+           .argName(""HOST"")
+           .hasArg()
+           .required(false)
+-          .desc(""Address of the Zookeeper ensemble; defaults to: ""+ZK_HOST)
++          .desc(""Address of the Zookeeper ensemble; defaults to: ""+ ZK_HOST + '.')
+           .build(),
+       Option.builder(""c"")
+           .argName(""COLLECTION"")
+           .hasArg()
+           .required(false)
+-          .desc(""Name of collection; no default"")
++          .desc(""Name of collection; no default."")
+           .longOpt(""collection"")
+           .build(),
+       Option.builder(""verbose"")",ZK is properly spelled 'ZooKeeper' (capital 'K').
+6798,"@@ -73,6 +73,8 @@ public class RubyGapicSurfaceTransformer implements ModelToViewTransformer {
+       ImmutableList.of(""GOOGLE_CLOUD_KEYFILE"", ""GCLOUD_KEYFILE"");
+   private static final List<String> DEFAULT_JSON_ENV_VARS =
+       ImmutableList.of(""GOOGLE_CLOUD_KEYFILE_JSON"", ""GCLOUD_KEYFILE_JSON"");
++  private static final List<String> DEFAULT_PATHS =
++      ImmutableList.of(""~/.config/gcloud/application_default_credentials.json"");
+
+   private final GapicCodePathMapper pathMapper;
+   private final PackageMetadataConfig packageConfig;",Guessing this locates the key you get when you run `gcloud auth application-default login`? What was the previous behavior/the behavior for the manual Veneer creds?
+6799,"@@ -85,7 +85,7 @@
+               entireColumnSelection = [0, selected[1], this.view.wt.wtTable.getRowStrategy().cellCount - 1, selected[1]],
+               columnSelected = entireColumnSelection.join(',') == selected.join(',');
+
+-            return selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected;
++            return selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || (columnSelected && this.countRows() > 1);
+           }
+         },
+         {","looks good to me, but it would be better if you assigned `this.countRows()` into a variable, so it doesn't trigger twice in the return statement"
+6800,"@@ -1,3 +1,5 @@
++'use strict';
++
+ require('classtool');
+
+ function ClassSpec(b) {","For now, don't add ""use strict"" to any existing files. That's a separate project that we'll do later. (New files can use ""use strict"".)"
+6801,"@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
+ 	// Set up tests and give ourselves a working directory.
+ 	assert := asrt.New(t)
+
++	noninteractive := ""DRUD_NONINTERACTIVE""
++	// nolint: errcheck
++	defer os.Setenv(noninteractive, os.Getenv(noninteractive))
++	err := os.Unsetenv(noninteractive)
++	assert.NoError(err)
++
+ 	testMatrix := map[string][]string{
+ 		""drupal6phpversion"": {AppTypeDrupal6, PHP56},
+ 		""drupal7phpversion"": {AppTypeDrupal7, PHP71},","I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?"
+6802,"@@ -139,7 +139,7 @@ def py_run(command_options='', return_std=False, stdout=None, stderr=None):
+     """"""
+     # Create command line to call pylint
+     epylint_part = [sys.executable, ""-c"", ""from pylint import epylint;epylint.Run()""]
+-    options = shlex.split(command_options)
++    options = shlex.split(command_options, posix='win' not in sys.platform)
+     cli = epylint_part + options
+
+     # Providing standard output and/or error if not set",`sys.platform` could be equal to `darwin` which is posix. Use `not startswith('win')`?
+6803,"@@ -38,11 +38,12 @@ func New(cfg *any.Any, logger *zap.Logger, scope tally.Scope) (service.Service,
+ 	}
+
+ 	s := &svc{
+-		logger:  logger,
+-		filter:  config.Filter,
+-		scope:   scope,
+-		slack:   slack.New(config.Token),
+-		channel: config.Channel,
++		logger:    logger,
++		filter:    config.Filter,
++		overrides: NewOverrideLookup(config.Overrides),
++		scope:     scope,
++		slack:     slack.New(config.Token),
++		channel:   config.Channel,
+ 	}
+ 	return s, nil
+ }",let's move this into `slack_helper.go`
+6804,"@@ -54,7 +54,7 @@ class Azure(base.Base):
+         driver:
+           name: azure
+           ssh_connection_options:
+-            -o ControlPath=~/.ansible/cp/%r@%h-%p
++            - '-o ControlPath=~/.ansible/cp/%r@%h-%p'
+
+     .. important::
+ ","I doubt it will work, but without space between -o and ControlPath it should. Lets see. What I do not understand is why we did not see a failure on CI related to this?"
+6805,"@@ -56,7 +56,7 @@ DiscreteBearing BearingClass::getDiscreteBearing(const double bearing)
+ {
+     BOOST_ASSERT(0. <= bearing && bearing <= 360.);
+     auto shifted_bearing = (bearing + 0.5 * discrete_step_size);
+-    if (shifted_bearing > 360.)
++    if (shifted_bearing >= 360.)
+         shifted_bearing -= 360;
+     return static_cast<DiscreteBearing>(shifted_bearing / discrete_step_size);
+ }",this is the reason we might be seeing 360 as discrete bearing
+6806,"@@ -72,6 +72,9 @@ from pylint.__pkginfo__ import version
+ from pylint.reporters.ureports import nodes as report_nodes
+
+
++FULL_VERSION = '%%(prog)s %s\nastroid %s\nPython %s' % (
++    version, astroid_version, sys.version)
++
+ MANAGER = astroid.MANAGER
+
+ ","`FULL_VERSION` is available at module level for others to use, but it won't have `%(prog)s` substituted with pylint. Will that be a problem. Also put it here instead of __pkginfo__ with other versions because it isn't pkginfo related."
+6807,"@@ -34,6 +34,7 @@ public abstract class BaseColumnIterator {
+   protected long triplesRead = 0L;
+   protected long advanceNextPageCount = 0L;
+   protected Dictionary dictionary;
++  protected long rowPosition;
+
+   protected BaseColumnIterator(ColumnDescriptor descriptor) {
+     this.desc = descriptor;",Is this needed? I don't see any uses.
+6808,"@@ -29,6 +29,15 @@ func (c *Client) DeletePubSubOrFail(name string) {
+ 	}
+ }
+
++func (c *Client) DeleteBuildOrFail(name string) {
++	c.T.Helper()
++	builds := c.KnativeGCP.EventsV1alpha1().CloudBuildSources(c.Namespace)
++	err := builds.Delete(name, &metav1.DeleteOptions{})
++	if err != nil {
++		c.T.Fatalf(""Failed to delete build %s/%s: %v"", c.Namespace, name, err)
++	}
++}
++
+ func (c *Client) DeleteSchedulerOrFail(name string) {
+ 	c.T.Helper()
+ 	schedulers := c.KnativeGCP.EventsV1alpha1().CloudSchedulerSources(c.Namespace)",Shouldn't this be V1beta1?
+6809,"@@ -102,6 +102,13 @@ class Proposal < ActiveRecord::Base
+     approval
+   end
+
++  def remove_approver(email)
++    user = User.for_email(email)
++    approval = self.approvals.find_by(user_id: user.id)
++    CommunicartMailer.notification_for_approver_removed(email,approval)
++    approval.destroy
++  end
++
+   def initialize_approvals()
+     if self.linear? && self.approvals.any?
+       self.approvals.update_all(status: 'pending')",I think there's an `approval_for`
+6810,"@@ -719,6 +719,8 @@ public interface Stack<T> extends LinearSeq<T> {
+     @Override
+     Stack<T> takeWhile(Predicate<? super T> predicate);
+
++    <U> U transform(Function<? super List<T>, ? extends U> f);
++
+     @Override
+     <U> Stack<U> unit(Iterable<? extends U> iterable);
+ ",Here we should use <code>List</code> in generic
+6811,"@@ -56,8 +56,7 @@ public final class BaselineReleaseCompatibility extends AbstractBaselinePlugin {
+
+         @Override
+         public Iterable<String> asArguments() {
+-            JavaVersion jdkVersion =
+-                    JavaVersion.toVersion(javaCompile.getToolChain().getVersion());
++            JavaVersion jdkVersion = JavaVersion.toVersion(javaCompile.getTargetCompatibility());
+             if (!supportsReleaseFlag(jdkVersion)) {
+                 log.debug(
+                         ""BaselineReleaseCompatibility is a no-op for {} in {} as {} doesn't support --release"",",The `JavaCompile#getToolChain` method got removed and I am not sure what a good replacement is. I replaced it with `targetCompat` for now but they are not equivalent. Maybe we can use `JavaVersion#current` here?
+6812,"@@ -14,7 +14,7 @@ use Ergonode\SharedKernel\Domain\Aggregate\MultimediaId;
+
+ interface MultimediaQueryInterface
+ {
+-    public function fileExists(Hash $hash): bool;
++    public function fileExists(string $name): bool;
+
+     public function findIdByHash(Hash $hash): ?MultimediaId;
+ ",The method name is incorrect. It does not check the existence of the file. I'd suggest deprecating both methods `fileExists` and `findIdByHash` and use findIdByFilename instead of fileExits
+6813,"@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
++	__u8 nat_lvl1_drop = 0;
+
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.","We have `stdbool` imported, might as well use that for clarity."
+6814,"@@ -0,0 +1 @@
++package batchstore","File is empty, consider removing?"
+6815,"@@ -760,7 +760,7 @@ describe('Bulk', function() {
+           batch.insert({ b: 1 });
+
+           // Execute the operations
+-          batch.execute(self.configuration.writeConcernMax(), function(err, result) {
++          batch.execute(self.configuration.writeConcernMax().writeConcern, function(err, result) {
+             expect(err).to.exist;
+             expect(result).to.not.exist;
+ ","`writeConcernMax` was changed to return a `writeConcern` formatted the new way-- `writeConcern: {w:1, ...}`. Bulk execute takes an actual `WriteConcern` object as its first parameter (this was changed in master), so we have to un-wrap the `writeConcernMax` result here."
+6816,"@@ -1,9 +1,10 @@
+ module TabularData
+   class Container
+-    attr_reader :columns
++    attr_reader :columns, :frozen_sort
+
+     def initialize(name, config)
+       @name = name
++      @frozen_sort = false
+       self.init_query(config[:engine].constantize, config.fetch(:joins, []))
+       self.init_columns(config.fetch(:column_configs, {}), config.fetch(:columns, {}))
+       self.set_sort(config[:sort])",How about passing this through the `config`?
+6817,"@@ -373,10 +373,10 @@ def create_secret(secretsmanager_client):
+         secretsmanager_client.delete_secret(SecretId=item)
+
+
+-only_localstack = pytest.mark.skipif(
+-    os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD"",
+-    reason=""test only applicable if run against localstack"",
+-)
++@pytest.fixture
++def only_localstack():
++    if os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD"":
++        pytest.skip(""test only applicable if run against localstack"")
+
+
+ @pytest.fixture","Out of curiosity - did we make this change to allow dynamically assigning a value to `os.environ[""TEST_TARGET""]` during test execution? I kind of liked the decorator style `@only_localstack` - makes the condition a bit more explicit. Looks like `skipif` also allows to specify a condition string, e.g. `pytest.mark.skipif('os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD""')` - could that be an option? (not sure if that gets lazily evaluated at runtime right before the execution of the annotated test method starts, though..)"
+6818,"@@ -72,6 +72,7 @@ class SliderItem implements OrderableEntityInterface
+      */
+     public function edit(SliderItemData $sliderItemData)
+     {
++        $this->domainId = $sliderItemData->domainId;
+         $this->name = $sliderItemData->name;
+         $this->link = $sliderItemData->link;
+         $this->hidden = $sliderItemData->hidden;",I noticed (SonarCloud noticed actually) that the implementation of `::edit` method is the same as `__construct` is. Does it make sense to call the `edit` method from the constructor?
+6819,"@@ -78,6 +78,7 @@ int syslog_prot_process(struct syslog_conn *conn)
+
+         /* Incomplete message */
+         if (eof == end || (*eof != '\n' && *eof != '\0')) {
++            flb_debug(""[syslog-prot] incomplete message! (Enable trace log to see the message.)"");
+             return 0;
+         }
+ ","would you please rename the message prefix to: [in_syslog] ..."""
+6820,"@@ -600,8 +600,8 @@ struct AtomMatch {  // for each seed atom (matched)
+ };
+ typedef std::vector<AtomMatch> AtomMatchSet;
+
+-std::string MaximumCommonSubgraph::generateResultSMARTS(
+-    const MCS& mcsIdx) const {
++std::string MaximumCommonSubgraph::generateResultSMARTSAndQueryMol(
++    const MCS& mcsIdx, RWMol **molExt) const {
+   // match the result MCS with all targets to check if it is exact match or
+   // template
+   Seed seed;  // result MCS","The pointer to a pointer is kind of gross. How about either taking the `ROMOL_SPTR` directly or, preferably, returning an `std::pair`?"
+6821,"@@ -164,7 +164,12 @@ func (pool *TransactionPool) rememberCommit(flush bool) {
+ func (pool *TransactionPool) PendingCount() int {
+ 	pool.pendingMu.RLock()
+ 	defer pool.pendingMu.RUnlock()
++	return pool.pendingCountLocked()
++}
+
++// pendingCountLocked is a helper for PendingCount that returns the number of
++// transactions pending in the pool
++func (pool *TransactionPool) pendingCountLocked() int {
+ 	var count int
+ 	for _, txgroup := range pool.pendingTxGroups {
+ 		count += len(txgroup)","the name confusing, please rename to `pendingCountNoLock` or similar"
+6822,"@@ -44,13 +44,11 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		[]byte{}, uint64(100000),
+ 		big.NewInt(10),
+ 	)
+-	sk, err := keypair.DecodePrivateKey(Gen.CreatorPrivKey)
+-	if err != nil {
+-		return err
+-	}
+-	if err := action.Sign(tsf0, sk); err != nil {
+-		return err
+-	}
++	pk, _ := hex.DecodeString(Gen.CreatorPubKey)
++	pubk, _ := keypair.BytesToPublicKey(pk)
++	sig, _ := hex.DecodeString(""ea18385718db2a8b92fa2dcdc158a05aae17fc7e800cc735850bdc99ab7b081f32fce70080888742d7b6bee892034e38298b69ce5fff671c18f0bed827e1e21f9da2ba5d8c434e00"")
++	tsf0.SetSrcPubkey(pubk)
++	tsf0.SetSignature(sig)
+ 	blk, err := bc.MintNewBlock([]action.Action{tsf0}, ta.Addrinfo[""producer""],
+ 		nil, nil, """")
+ 	if err != nil {",line is 175 characters
+6823,"@@ -230,12 +230,10 @@ public abstract class SalesforceReactActivity extends ReactActivity {
+     }
+
+     protected void setRestClient(RestClient restClient) {
+-        if(restClient!= null && client != restClient){
+-            if(reactActivityDelegate != null){
+-                reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());
+-            }
+-        }
+         client = restClient;
++        if(client != null && reactActivityDelegate != null){
++            reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());
++        }
+     }
+
+     protected ClientManager buildClientManager() {",@ivanbogdanov Does this fix the first time load gray screen issue that @wmathurin noticed?
+6824,"@@ -35,11 +35,12 @@ __all__ = ['Dataset', 'Booster',
+            'print_evaluation', 'record_evaluation', 'reset_parameter', 'early_stopping',
+            'plot_importance', 'plot_metric', 'plot_tree', 'create_tree_digraph']
+
++# REMOVEME: remove warning after 2.3.0 version release
+ if system() == 'Darwin':
+     warnings.warn(""Starting from version 2.2.1, the library file in distribution wheels for macOS ""
+-                  ""will be built by the Apple Clang compiler.\n""
++                  ""is built by the Apple Clang (Xcode_9.4.1) compiler.\n""
+                   ""This means that in case of installing LightGBM from PyPI via the ``pip install lightgbm`` command, ""
+-                  ""you won't need to install the gcc compiler anymore.\n""
+-                  ""Instead of that, you'll need to install the OpenMP library, ""
++                  ""you don't need to install the gcc compiler anymore.\n""
++                  ""Instead of that, you need to install the OpenMP library, ""
+                   ""which is required for running LightGBM on the system with the Apple Clang compiler.\n""
+-                  ""You can install the OpenMP library by the following command: ``brew install libomp``."", FutureWarning)
++                  ""You can install the OpenMP library by the following command: ``brew install libomp``."", UserWarning)",Is `2.3.0` version OK?
+6825,"@@ -26,6 +26,18 @@ describe ""Selenium::WebDriver::TargetLocator"" do
+     end
+   end
+
++  it ""should switch to parent frame"" do
++    driver.navigate.to url_for(""iframes.html"")
++
++    iframe = driver.find_element(:tag_name => ""iframe"")
++    driver.switch_to.frame(iframe)
++
++    driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)
++
++    driver.switch_to.parent_frame
++    driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element)
++  end
++
+   # switching by name not yet supported by safari
+   not_compliant_on :browser => [:ie, :iphone, :safari] do
+     it ""should switch to a window and back when given a block"" do",I tested it only in Firefox (`./go //rb:firefox-test`)
+6826,"@@ -10,6 +10,8 @@ import (
+ 	""net/http/httptest""
+ )
+
++// NewTestClient returns a TestClient with a replacement http handler function.
++// Methods on the new TestClient are overrideable as well.
+ func NewTestClient(handleFunc http.HandlerFunc) (*httptest.Server, *TestClient, error) {
+ 	ts := httptest.NewServer(handleFunc)
+ 	opts := []option.ClientOption{",separate third party and builtin
+6827,"@@ -818,7 +818,9 @@ public class SalesforceSDKManager {
+
+         // Finishes front activity if specified, and if this is the last account.
+         if (frontActivity != null && (users == null || users.size() <= 1)) {
+-            frontActivity.finish();
++            // only finish if it isn't hybrid or if hybrid, requires authentication
++            if (!isHybrid() || BootConfig.getBootConfig(frontActivity).shouldAuthenticate())
++                frontActivity.finish();
+         }
+
+         /*",@smcnulty-sfdc We do want to finish the hybrid activity in our hybrid apps though. Could the caller not pass in `frontActivity` instead? Or start it up again post-logout?
+6828,"@@ -111,7 +111,7 @@ func (o outbound) Call(ctx context.Context, req *transport.Request) (*transport.
+
+ 	response, err := ctxhttp.Do(ctx, o.Client, request)
+ 	if err != nil {
+-		if err == context.DeadlineExceeded {
++		if err == ctx.Err() {
+ 			return nil, errors.NewTimeoutError(req.Service, req.Procedure, deadline.Sub(start))
+ 		}
+ ",isn't this going to return a timeout error if the context is canceled?
+6829,"@@ -15,6 +15,10 @@ class ArgsParser {
+   ArgsParser(String[] args) {
+     for (String arg : args) {
+       String[] argNameVal = arg.split(""="");
++      if (argNameVal.length == 1) {
++        parsedArgs.put(argNameVal[0], ""true"");
++        continue;
++      }
+       if (argNameVal.length != 2) {
+         System.out.println(""WARNING: Ignoring unrecognized argument: "" + arg);
+         continue;","`argNameVal.length` will still be !=2, so line 22 will give true and then continue on line 24"
+6830,"@@ -237,7 +237,7 @@ class FunctionDocblockManipulator
+                 continue;
+             }
+
+-            if ($char === '\\' || preg_match('/\w/', $char)) {
++            if ($chars[$i + 1] === '\\' || preg_match('/\w/', $char)) {
+                 if ($this->return_typehint_start === null) {
+                     $this->return_typehint_start = $i + $end_bracket_position + 1;
+                 }",It was `$chars[$i]` I believe.
+6831,"@@ -246,7 +246,7 @@ module Unix::Exec
+       else
+         val = val.to_s
+       end
+-      env_array << ""#{key.to_s.upcase}=\""#{val}\""""
++      env_array << ""#{key.to_s}=\""#{val}\""""
+     end
+     env_array
+   end","This has the likely potential to break existing tests that are relying on the old beaker behavior. If we are going to release this in beaker 3.x, then we need to preserve the old behavior as well (so set both the `upcase` and original values). On Windows, they env variables will overwrite each other, with the same value, so not an issue. On *nix, there will be two env variables, but they will have the same value, so again no issue."
+6832,"@@ -299,6 +299,7 @@ Blockly.Variables.createVariable = function(workspace, opt_callback, opt_type) {
+   // Prompt the user to enter a name for the variable
+   Blockly.prompt(newMsg, '',
+       function(text, additionalVars, variableOptions) {
++        variableOptions = variableOptions || {};
+         var scope = variableOptions.scope;
+         var isLocal = (scope === 'local') || false;
+         var isCloud = variableOptions.isCloud || false;",Thanks for fixing this! I probably didn't test the playground when making changes here for cloud variables.
+6833,"@@ -39,6 +39,7 @@ class PruneColumns extends AvroSchemaVisitor<Schema> {
+   private final NameMapping nameMapping;
+
+   PruneColumns(Set<Integer> selectedIds, NameMapping nameMapping) {
++    Preconditions.checkNotNull(selectedIds, ""Selected field ids cannot be null"");
+     this.selectedIds = selectedIds;
+     this.nameMapping = nameMapping;
+   }",I will also check if `nameMapping` needs a precondition null check.
+6834,"@@ -60,9 +60,8 @@ public class Files {
+
+       if (!file.getParentFile().isDirectory() && !file.getParentFile().mkdirs()) {
+         throw new RuntimeIOException(
+-            String.format(
+                 ""Failed to create the file's directory at %s."",
+-                file.getParentFile().getAbsolutePath()));
++                file.getParentFile().getAbsolutePath());
+       }
+
+       try {","Since RuntimeIOException is deprecated and you are touching this code, why not replace it?"
+6835,"@@ -59,7 +59,9 @@ class ClusterParamsTest(TestCaseBase):
+       self.assertGreaterEqual(encodersDict['c1']['resolution'], 0.001,
+                               ""Resolution is too low"")
+
+-
++    # Ensure incorrect tmImplementation throws exception
++    with self.assertRaises(ValueError):
++        getScalarMetricWithTimeOfDayAnomalyParams([0], tmImplementation="""")
+
+ if __name__ == '__main__':
+   unittest.main()",You should also have a test that calls it with tm_cpp and make sure it returns the correct JSON file.
+6836,"@@ -168,17 +168,12 @@ define([""jQuery"", ""globalize"", ""scripts/taskbutton"", ""dom"", ""libraryMenu"", ""layo
+         }), menuItems.push({
+             name: ""Xml TV"",
+             id: ""xmltv""
+-        }), menuItems.push({
+-            name: globalize.translate(""ButtonOther""),
+-            id: ""other""
+         }), require([""actionsheet""], function(actionsheet) {
+             actionsheet.show({
+                 items: menuItems,
+                 positionTo: button,
+                 callback: function(id) {
+-                    ""other"" == id ? Dashboard.alert({
+-                        message: globalize.translate(""ForAdditionalLiveTvOptions"")
+-                    }) : Dashboard.navigate(getProviderConfigurationUrl(id))
++                    Dashboard.navigate(getProviderConfigurationUrl(id))
+                 }
+             })
+         })","One more minor change, the string `ForAdditionalLiveTvOptions` is probably also unused."
+6837,"@@ -107,7 +107,7 @@ bool RowReaderWrapper::reset(meta::SchemaProviderIf const* schema,
+     currReader_ = &readerV2_;
+     return true;
+   } else {
+-    LOG(ERROR) << ""Unsupported row reader version "" << readerVer;
++    LOG(WARNING) << ""Unsupported row reader version "" << readerVer;
+     currReader_ = nullptr;
+     return false;
+   }",How to distinguish between warning and error?
+6838,"@@ -171,6 +171,10 @@ def doPreGainFocus(obj,sleepMode=False):
+ 			else:
+ 				newForeground=obj
+ 		api.setForegroundObject(newForeground)
++		import UIAHandler
++		if UIAHandler.isUIAAvailable:
++			# Notify UIAHandler of the new foreground so that it can deregister old events and register new ones
++			UIAHandler.handler.onForegroundChange(newForeground.windowHandle)
+ 		executeEvent('foreground',newForeground)
+ 	if sleepMode: return True
+ 	#Fire focus entered events for all new ancestors of the focus if this is a gainFocus event",Perhaps you want to check if UIAHandler.handler is not None. The current check will break NVDA if you call UIAHandler.terminate() for some reason.
+6839,"@@ -27,6 +27,7 @@ public class BaseReplacePartitions
+     extends MergingSnapshotProducer<ReplacePartitions> implements ReplacePartitions {
+   BaseReplacePartitions(String tableName, TableOperations ops) {
+     super(tableName, ops);
++    set(""replace-partitions"", ""true"");
+   }
+
+   @Override",can we make `replace-partitions` property a static variable in `SnaphotSummary.java`?
+6840,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?
+6841,"@@ -79,7 +79,9 @@ def get_admins():
+ def activate_response(link):
+     payload = verify_activation_link(link)
+     if payload:
+-        _activate_user(User.query.filter_by(id=payload['id']).with_for_update().one_or_none())
++        user = User.query.filter_by(id=payload['id']).with_for_update().one_or_none()
++        _activate_user(user)
++        send_welcome_email(user)
+         db.session.commit()
+         return redirect(""{CATALOG_URL}/signin"".format(CATALOG_URL=CATALOG_URL), code=302)
+ ","Should really be `one()`, not `one_or_none()`"
+6842,"@@ -193,7 +193,11 @@ func SetJoinNodeConfigurationOverrides(caCertHash, bootstrapToken string, machin
+ 	}
+ 	out.NodeRegistration.KubeletExtraArgs[""cloud-provider""] = CloudProvider
+ 	if !util.IsControlPlaneMachine(machine.GetMachine()) {
+-		out.NodeRegistration.KubeletExtraArgs[""node-labels""] = nodeRole
++		if labels, ok := out.NodeRegistration.KubeletExtraArgs[""node-labels""]; ok {
++			out.NodeRegistration.KubeletExtraArgs[""node-labels""] = fmt.Sprintf(""%s,%s"", labels, nodeRole)
++		} else {
++			out.NodeRegistration.KubeletExtraArgs[""node-labels""] = nodeRole
++		}
+ 	}
+ 	return out
+ }",Should we use strings.Split and strings.Join instead of manual concatenation?
+6843,"@@ -374,6 +374,18 @@ class In(
+             asset_partitions=asset_partitions,
+         )
+
++    @staticmethod
++    def from_definition(input_def: InputDefinition):
++        return In(
++            dagster_type=input_def.dagster_type,
++            description=input_def.description,
++            default_value=input_def._default_value,  # pylint: disable=protected-access
++            root_manager_key=input_def.root_manager_key,
++            metadata=input_def.metadata,
++            asset_key=input_def._asset_key,  # pylint: disable=protected-access
++            asset_partitions=input_def._asset_partitions_fn,  # pylint: disable=protected-access
++        )
++
+     def to_definition(self, name: str) -> InputDefinition:
+         dagster_type = self.dagster_type if self.dagster_type is not NoValueSentinel else None
+         return InputDefinition(","rough that this needs to exist, but it is what it is"
+6844,"@@ -117,6 +117,17 @@ describe('render()', () => {
+ 		expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
+ 	});
+
++	// TODO: the test doesn't seem to work as it throws, maybe due to not knowing the props allowed for x-bar
++	// it('should not set empty string for null props in custom attributes', () => {
++	// 	render(<x-bar val={null} />, scratch);
++	// 	expect(scratch.childNodes).to.have.length(1);
++	// 	expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
++	// 	expect(scratch.firstChild.attributes['val']).to.equal('null');
++	// 	expect(scratch.innerHTML).to.equal(
++	// 		'<x-bar val=""null""></x-bar>'
++	// 	);
++	// });
++
+ 	it('should support the form attribute', () => {
+ 		render(
+ 			<div>","FYI, I pulled your branch and hacked a little on your test case. This passes for me (you may want to tweak further): <pre> it('should not set empty string for null props in custom elements', () => { customElements.define('x-bar', class extends HTMLElement { val; }); // @ts-ignore render(&lt;x-bar val={null} /&gt;, scratch); expect(scratch.childNodes).to.have.length(1); expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR'); expect(scratch.firstChild.attributes.length).to.equal(0); expect(scratch.firstChild.val).to.equal(null); }); </pre>"
+6845,"@@ -43,7 +43,7 @@ import android.util.Log;
+  */
+ public class SmartStoreLoadExternalStorageTest extends SmartStoreLoadTest {
+
+-    static final int ONE_MEGABYTE = 1024 * 1024;
++    static final int LARGE_BYTES = 512 * 1024;
+
+     @Override
+     protected String getPasscode() {",It is the maximum value that the configured emulator can support.
+6846,"@@ -210,14 +210,17 @@ def _load_session(name):
+         name: The name of the session to load, or None to read state file.
+     """"""
+     state_config = objreg.get('state-config')
++    session_manager = objreg.get('session-manager')
+     if name is None:
+         try:
+             name = state_config['general']['session']
+         except KeyError:
+             # No session given as argument and none in the session file ->
+             # start without loading a session
+-            return
+-    session_manager = objreg.get('session-manager')
++            if session_manager.exists('_autosave'):
++                name = '_autosave'
++            else:
++                return
+     try:
+         session_manager.load(name)
+     except sessions.SessionNotFoundError:","Here, I've been giving priority to the session saved by the user. This means, that if the user quits with `:wq`, then restarts `qutebrowser`, and then `qutebrowser` crashes for some reason, next time `qutebrowser` is restarted, the session saved lastly with `wq` will be restored, and not the one autosaved. What do you think?"
+6847,"@@ -64,7 +64,7 @@ func membership(l LedgerReader, addr basics.Address, r basics.Round, p period, s
+ 	balanceRound := balanceRound(r, cparams)
+ 	seedRound := seedRound(r, cparams)
+
+-	record, err := l.BalanceRecord(balanceRound, addr)
++	record, err := l.AccountData(balanceRound, addr)
+ 	if err != nil {
+ 		err = fmt.Errorf(""Service.initializeVote (r=%d): Failed to obtain balance record for address %v in round %d: %v"", r, addr, balanceRound, err)
+ 		return","this line got me confused for few seconds, as the `AccountData` is both the name of the data structure as well as the function name. I think that `GetAccountData` is a better choice for a name. ( note that the same applies for the previous `BalanceRecord` function name )"
+6848,"@@ -61,11 +61,7 @@ public:
+     void helper_block_for_at_least_entries(
+             uint32_t amount)
+     {
+-        std::unique_lock<std::mutex> lck(*xml_mutex_);
+-        mock_consumer->cv().wait(lck, [this, amount]
+-                {
+-                    return mock_consumer->ConsumedEntriesSize_nts() >= amount;
+-                });
++        mock_consumer->wait_for_at_least_entries(amount);
+     }
+
+     MockConsumer* mock_consumer;",I think this mutex is only used here. Remove it.
+6849,"@@ -234,6 +234,11 @@ func NewMutableState(
+ 		logger:          logger,
+ 		metricsClient:   shard.GetMetricsClient(),
+ 	}
++
++	if migration.IsDBVersionEnabled() {
++		s.dbRecordVersion = 1
++	}
++
+ 	s.executionInfo = &persistencespb.WorkflowExecutionInfo{
+ 		WorkflowTaskVersion:    common.EmptyVersion,
+ 		WorkflowTaskScheduleId: common.EmptyEventID,",so this is now init to 1?
+6850,"@@ -191,7 +191,8 @@ bool ZoneDatabase::LoadSpawnGroups(const char *zone_name, uint16 version, SpawnG
+ 				WHERE
+ 				spawn2.spawngroupID = spawngroup.ID
+ 				AND
+-				spawn2.version = {} and zone = '{}'
++				(spawn2.version = {} OR version = -1)
++				AND zone = '{}'
+ 				{}
+ 		),
+ 		version,",For future note; not prefixing the table in a join can throw an error in the query parser depending on how the query is built I am making an assumption this was tested
+6851,"@@ -42,9 +42,13 @@ var c client.Client
+
+ var expectedRequest = reconcile.Request{NamespacedName: types.NamespacedName{Name: ""foo"", Namespace: ""default""}}
+
+-var jobKey = types.NamespacedName{Name: ""install-foo"", Namespace: ""default""}
++var jobKey = types.NamespacedName{Name: ""foo-install"", Namespace: ""default""}
+
+-const timeout = time.Second * 5
++const (
++	timeout             = time.Second * 10
++	fakeClusterUUID     = ""fe953108-f64c-4166-bb8e-20da7665ba00""
++	fakeClusterMetadata = `{""clusterName"":""foo"",""aws"":{""region"":""us-east-1"",""identifier"":{""tectonicClusterID"":""fe953108-f64c-4166-bb8e-20da7665ba00""}}}`
++)
+
+ func init() {
+ 	log.SetLevel(log.DebugLevel)","Had to bring this up, will abandon this style of testing based on Joel's work soon."
+6852,"@@ -493,7 +493,7 @@ public class HttpSolrCall {
+     }
+     if (statusCode == AuthorizationResponse.FORBIDDEN.statusCode) {
+       if (log.isDebugEnabled()) {
+-        log.debug(""UNAUTHORIZED auth header {} context : {}, msg: {}"", req.getHeader(""Authorization""), context, authResponse.getMessage()); // logOk
++        log.debug(""UNAUTHORIZED auth header {} context : {}, msg: {}"", req.getHeader(""Authorization""), context, authResponse.getMessage()); // nowarn
+       }
+       sendError(statusCode,
+           ""Unauthorized request, Response code: "" + statusCode);",What does our source validation complain about here? Many of the logok/nowarn places look fine to me at a glance but I'm no match for the logging policeman ;-)
+6853,"@@ -22,14 +22,17 @@ import (
+ 	""strconv""
+ 	""time""
+
++	""github.com/mysteriumnetwork/node/client/stats""
+ 	""github.com/mysteriumnetwork/node/openvpn/management""
+ )
+
+ // SessionStatsHandler is invoked when middleware receives statistics
+-type SessionStatsHandler func(SessionStats) error
++type SessionStatsHandler func(stats.SessionStats) error
+
+ const byteCountCommandTemplate = ""bytecount %d""
+
++var rule = regexp.MustCompile(""^>BYTECOUNT:(.*),(.*)$"")
++
+ type middleware struct {
+ 	sessionStatsHandler SessionStatsHandler
+ 	interval            time.Duration","It feels like this dependency should not be here. Some deep internal openvpn package (middleware) knows about one of possible stats consumers. Maybe as an alternative, statistics and state callbacks can be extracted as separate interfaces in top openvpn package and reused by both sides"
+6854,"@@ -1744,7 +1744,7 @@ func (fd *fileData) deepCopy(ctx context.Context, codec kbfscodec.Codec,
+
+ 	// Handle the single-level case first.
+ 	if !topBlock.IsInd {
+-		newTopBlock, err := topBlock.DeepCopy(codec)
++		newTopBlock := topBlock.DeepCopy()
+ 		if err != nil {
+ 			return zeroPtr, nil, err
+ 		}",Can you please remove `codec` from the parameters too? I think it's unused now.
+6855,"@@ -126,6 +126,7 @@ class ContextTest extends AbstractSymbolResolutionTest {
+         when(compilationUnitDecl.getName()).thenReturn(""CompilationUnit"");
+         when(compilationUnitDecl.getQualifiedName()).thenReturn(""com.github.javaparser.ast.CompilationUnit"");
+         TypeSolver typeSolver = mock(TypeSolver.class);
++        when(typeSolver.getSolvedJavaLangObject()).thenReturn(new ReflectionClassDeclaration(Object.class, typeSolver));
+         when(typeSolver.getRoot()).thenReturn(typeSolver);
+         when(typeSolver.solveType(""java.lang.Object"")).thenReturn(new ReflectionClassDeclaration(Object.class, typeSolver));
+         when(typeSolver.tryToSolveType(""com.github.javaparser.ast.CompilationUnit"")).thenReturn(SymbolReference.solved(compilationUnitDecl));","mocks needed this change so that it returns the ""right"" thing"
+6856,"@@ -128,9 +128,14 @@ public class MenuEntrySwapperPlugin extends Plugin
+ 	@Getter
+ 	private boolean configuringShiftClick = false;
+
++	@Getter
+ 	@Setter
+ 	private boolean shiftModifier = false;
+
++	@Getter
++	@Setter
++	private boolean controlModifier = false;
++
+ 	@Provides
+ 	MenuEntrySwapperConfig provideConfig(ConfigManager configManager)
+ 	{","I don't think the getters for this are needed, but looks good other than that"
+6857,"@@ -1,3 +1,16 @@
+ <%= content_tag_for :div, video do %>
+-  <%= render 'videos/summary', video: video %>
++  <div class=""video-text <%= video.status_class %>"">
++    <%= link_to video_path(video) do %>
++      <h3><%= video.name %></h3>
++    <% end %>
++    <div class=""video-tags"">
++      <%= render video.topics %>
++    </div>
++    <p class=""video-length"" data-wistia-id=""<%= video.clip.wistia_id %>"">
++      <%= video.length_in_minutes %> minutes
++    </p>
++    <p class=""video-summary"">
++      <%= format_markdown(video.summary) %>
++    </p>
++  </div>
+ <% end %>",:+1: to inlining this.
+6858,"@@ -13785,7 +13785,7 @@ return [
+ 'stream_get_contents' => ['string|false', 'stream'=>'resource', 'length='=>'int', 'offset='=>'int'],
+ 'stream_get_filters' => ['array'],
+ 'stream_get_line' => ['string|false', 'stream'=>'resource', 'length'=>'int', 'ending='=>'string'],
+-'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri:string,mediatype:string}', 'stream'=>'resource'],
++'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri:string,mediatype:string,crypto?:mixed}', 'stream'=>'resource'],
+ 'stream_get_transports' => ['list<string>'],
+ 'stream_get_wrappers' => ['list<string>'],
+ 'stream_is_local' => ['bool', 'stream'=>'resource|string'],",Does psalm support the same logic internally for object-like arrays? Just want to be certain I can indicate this is a contextual return item `crypto?:mixed`.
+6859,"@@ -658,8 +658,6 @@ void CreateImageTest(VkLayerTest &test, const VkImageCreateInfo *pCreateInfo, st
+     VkImage image = VK_NULL_HANDLE;
+     if (code.length()) {
+         test.Monitor().SetDesiredFailureMsg(kErrorBit, code);
+-        // Very possible a test didn't check for VK_ERROR_FORMAT_NOT_SUPPORTED
+-        test.Monitor().SetUnexpectedError(""UNASSIGNED-CoreValidation-Image-FormatNotSupported"");
+     } else {
+         test.Monitor().ExpectSuccess();
+     }",I can't recall if there was a fix specific to this in the past?
+6860,"@@ -51,14 +51,15 @@ var _ = duck.VerifyType(&PubSubSource{}, &duckv1alpha1.Conditions{})
+
+ // PubSubSourceSpec defines the desired state of the PubSubSource.
+ type PubSubSourceSpec struct {
+-	// GcpCredsSecret is the credential to use to poll the GCP PubSubSource Subscription. It is not used
++	// Secret is the credential to use to poll the PubSubSource Subscription. It is not used
+ 	// to create or delete the Subscription, only to poll it. The value of the secret entry must be
+ 	// a service account key in the JSON format (see
+ 	// https://cloud.google.com/iam/docs/creating-managing-service-account-keys).
+-	GcpCredsSecret corev1.SecretKeySelector `json:""gcpCredsSecret,omitempty""`
++	Secret *corev1.SecretKeySelector `json:""secret,omitempty""`
+
+-	// GoogleCloudProject is the ID of the Google Cloud Project that the PubSubSource Topic exists in.
+-	GoogleCloudProject string `json:""googleCloudProject,omitempty""`
++	// TODO: https://github.com/googleapis/google-cloud-go/blob/master/compute/metadata/metadata.go
++	// Project is the ID of the Google Cloud Project that the PubSubSource Topic exists in.
++	Project string `json:""project,omitempty""`
+
+ 	// Topic is the ID of the GCP PubSubSource Topic to Subscribe to. It must be in the form of the
+ 	// unique identifier within the project, not the entire name. E.g. it must be 'laconia', not",Not sure what the todo is here? Is it to support some kind of defaulting based off of that?
+6861,"@@ -68,11 +68,18 @@ namespace NLog.Targets.Wrappers
+         /// Delay the flush until the LogEvent has been confirmed as written
+         /// </summary>
+         /// <docgen category='General Options' order='10' />
+-        public bool AsyncFlush { get => _asyncFlush ?? true;
++        public bool AsyncFlush
++        {
++            get => _asyncFlush ?? true;
+             set => _asyncFlush = value;
+         }
+         private bool? _asyncFlush;
+
++        /// <summary>
++        /// Only flush when LogEvent matches condition. Ignore explicit-flush, config-reload-flush and shutdown-flush
++        /// </summary>
++        public bool FlushOnConditionOnly { get; set; }
++
+         private readonly AsyncOperationCounter _pendingManualFlushList = new AsyncOperationCounter();
+
+         /// <summary>","Not sure about this name. I think ""explicit"" is also a bit difficult here (I think it should be implicit then) Proposal: FlushOnEvents. Or, It would be cool if we could split into 2 options, FlushOnShutdown and FlushOnReload, but I expect that's far more difficult to implement?"
+6862,"@@ -32,7 +32,11 @@ from qutebrowser.utils import objreg, qtutils
+ from qutebrowser.browser.webkit import tabhistory
+
+
+-pytestmark = pytest.mark.qt_log_ignore('QIODevice::read.*: device not open')
++@pytest.fixture(autouse=True)
++@pytest.mark.qt_log_ignore('QIODevice::read.*: device not open')
++def autouse(fake_save_manager):
++    yield
++
+
+ webengine_refactoring_xfail = pytest.mark.xfail(
+     True, reason='Broke during QtWebEngine refactoring, will be fixed after '",I don't think that works - you can't mark a fixture.
+6863,"@@ -42,6 +42,12 @@ module Bolt
+
+     PUPPETFILE_OPTIONS = %w[proxy forge].freeze
+
++    DEFAULT_CONFIG_PATHS = [
++      Bolt::Util.windows? ? 'C:\\Program Files\\Puppet Labs\\Bolt\\bolt.yaml' : '/etc/puppetlabs/bolt/bolt.yaml',
++      File.expand_path('.puppetlabs/etc/bolt/bolt.yaml', Bolt::Util.windows? ? ENV['USERPROFILE'] : '~'),
++      File.expand_path('.puppetlabs/bolt.yaml', Bolt::Util.windows? ? ENV['USERPROFILE'] : '~')
++    ].freeze
++
+     def self.default
+       new(Bolt::Boltdir.new('.'), {})
+     end",We should not include this path.
+6864,"@@ -52,6 +52,19 @@ class SlackWebhooknotifierTest(ForsetiTestCase):
+
+             self.assertEqual(expected_output.strip(), actual_output.strip())
+
++    def test_dump_slack_output_for_string_returns_string(self):
++        violation_data = 'Test violation data string'
++        with mock.patch.object(
++                slack_webhook.SlackWebhook,
++                '__init__',
++                lambda x: None):
++            slack_notifier = slack_webhook.SlackWebhook()
++            actual_output = slack_notifier._dump_slack_output(violation_data)
++
++            expected_output = '\t' + '`' + str(violation_data) + '`\n'
++
++            self.assertEqual(expected_output.strip(), actual_output.strip())
++
+     def test_no_url_no_run_notifier(self):
+         """"""Test that no url for Slack notifier will skip running.""""""
+         with mock.patch.object(slack_webhook.SlackWebhook, '__init__', lambda x: None):",Add newline at end of file
+6865,"@@ -257,6 +257,9 @@ class DBUpgrader {
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_EXCLUDE_FILTER + "" TEXT DEFAULT ''"");
+
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_MINIMAL_DURATION_FILTER + "" INTEGER DEFAULT -1"");
++
+             // and now auto refresh
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_KEEP_UPDATED + "" INTEGER DEFAULT 1"");","This should be done when updating to the next release (2.5). You currently only perform the upgrade when users go from 1.4 to 1.5, so it will lead to crashes for existing users."
+6866,"@@ -320,6 +320,9 @@ const (
+ 	// HiveFeatureGatesEnabledEnvVar is the the environment variable specifying the comma separated list of
+ 	// feature gates that are enabled.
+ 	HiveFeatureGatesEnabledEnvVar = ""HIVE_FEATURE_GATES_ENABLED""
++
++	// CentralMachineManagementAnnotation
++	CentralMachineManagementAnnotation = ""hive.openshift.io/clusterName""
+ )
+
+ // GetMergedPullSecretName returns name for merged pull secret name per cluster deployment",suggest hive.openshift.io/cluster-machine-management or something to make it more obvious what it is.
+6867,"@@ -45,7 +45,7 @@ using Nethermind.JsonRpc.Modules.Eth.FeeHistory;
+
+ namespace Nethermind.Init.Steps
+ {
+-    [RunnerStepDependencies(typeof(InitializeNetwork), typeof(SetupKeyStore), typeof(InitializeBlockchain), typeof(InitializePlugins))]
++    [RunnerStepDependencies(typeof(InitializeNetwork), typeof(SetupKeyStore), typeof(InitializeBlockchain), typeof(InitializePlugins), typeof(ReviewBlockTree))]
+     public class RegisterRpcModules : IStep
+     {
+         private readonly INethermindApi _api;",We explicitly don't want to do that. This was a complaint from users before.
+6868,"@@ -28,6 +28,7 @@ use Thelia\Type\TypeCollection;
+  * {@inheritdoc}
+  * @method int getId()
+  * @method int[] getExclude()
++ * @method int[] getExcludeCode()
+  * @method string getCode()
+  * @method string[] getOrder()
+  */","Hello, The PHPDoc is `string[]` not `int[]`"
+6869,"@@ -20,7 +20,7 @@ import (
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/mock""
+ )
+
+-func applyTc(ctx context.Context, pid uint32, args ...string) error {
++func applyTc(ctx context.Context, pid uint32, enterNS bool, args ...string) error {
+ 	// Mock point to return error in unit test
+ 	if err := mock.On(""TcApplyError""); err != nil {
+ 		if e, ok := err.(error); ok {",Same issues with parameters order in `ipset_server.go`
+6870,"@@ -82,8 +82,8 @@ const (
+ 	SystemLocalNamespace = ""temporal-system""
+ 	// SystemNamespaceID is namespace id for all temporal system workflows
+ 	SystemNamespaceID = ""32049b68-7872-4094-8e63-d0dd59896a83""
+-	// SystemNamespaceRetentionDays is retention config for all temporal system workflows
+-	SystemNamespaceRetentionDays = time.Hour * 24 * 7
++	// SystemNamespaceRetention is retention config for all temporal system workflows
++	SystemNamespaceRetention = time.Hour * 24 * 7
+ )
+
+ const (","Wow, did it literally mean the retention days is a huge number?"
+6871,"@@ -216,6 +216,11 @@ int FlatCompiler::Compile(int argc, const char **argv) {
+             flatbuffers::PosixPath(argv[argi]));
+         include_directories.push_back(
+             include_directories_storage.back().c_str());
++      } else if (arg == ""--bfbs-filenames"") {
++        if (++argi > argc) Error(""missing path following: "" + arg, true);
++        opts.project_root = argv[argi];
++        if (!DirExists(opts.project_root.c_str()))
++          Error(arg + "" is not a directory: "" + opts.project_root);
+       } else if (arg == ""--conform"") {
+         if (++argi >= argc) Error(""missing path following: "" + arg, true);
+         conform_to_schema = flatbuffers::PosixPath(argv[argi]);",you probably didn't intend to touch those files in `scripts/`
+6872,"@@ -270,6 +270,7 @@ def eval_map(det_results,
+              iou_thr=0.5,
+              dataset=None,
+              logger=None,
++             tpfp_func=None,
+              nproc=4):
+     """"""Evaluate mAP of a dataset.
+ ","Similar to `collate_fn`, we may rename it to `tpfp_fn`."
+6873,"@@ -320,6 +320,7 @@ export class TopOverlay extends Overlay {
+       return this.wot.wtTable.holderOffset.top;
+
+     }
++
+     return 0;
+
+   }","Awesome! We may also use negative rule `never` to fix new lines after `return`: `{ blankLine: ""never"", prev: ""return"", next: ""*"" }`"
+6874,"@@ -0,0 +1,18 @@
++// Copyright 2016 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++package libkbfs
++
++import ""errors""
++
++// GetJournalServer returns the JournalServer tied to a particular
++// config.
++func GetJournalServer(config Config) (*JournalServer, error) {
++	bserver := config.BlockServer()
++	jbserver, ok := bserver.(journalBlockServer)
++	if !ok {
++		return nil, errors.New(""Write journal not enabled"")
++	}
++	return jbserver.jServer, nil
++}",Why can't this be a function on the `Config` interface like all the others?
+6875,"@@ -252,7 +252,9 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem
+         optionsMenu = menu;
+         FeedMenuHandler.onCreateOptionsMenu(inflater, menu);
+         iconTintManager.updateTint();
+-        MenuItemUtils.setupSearchItem(menu, (MainActivity) getActivity(), feedID);
++        if (feed != null) {
++            MenuItemUtils.setupSearchItem(menu, (MainActivity) getActivity(), feedID, feed.getTitle());
++        }
+         if (feed == null || feed.getLink() == null) {
+             menu.findItem(R.id.share_link_item).setVisible(false);
+             menu.findItem(R.id.visit_website_item).setVisible(false);","If the feed is null, the menu items should still be setup. Just the feed title can be left out. That prevents possible flickering when menu items are displayed/hidden for some feeds."
+6876,"@@ -178,8 +178,12 @@ public class Spark3Util {
+
+   private static void apply(UpdateSchema pendingUpdate, TableChange.AddColumn add) {
+     Type type = SparkSchemaUtil.convert(add.dataType());
+-    pendingUpdate.addColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
+-
++    if (add.isNullable()) {
++      pendingUpdate.addColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
++    } else {
++      pendingUpdate.allowIncompatibleChanges()
++        .addRequiredColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
++    }
+     if (add.position() instanceof TableChange.After) {
+       TableChange.After after = (TableChange.After) add.position();
+       String referenceField = peerName(add.fieldNames(), after.column());",I'm not sure that this should call `allowIncompatibleChanges()` because adding a required column when there are no existing values will break reading the new column in any table with data in it. The only time it is safe to add a required column is if there is no data in the table. What about throwing an exception here instead? I agree that the column should not be optional if NOT NULL was specified. Another alternative is to check whether the table has data and allow the incompatible change if it doesn't have any rows.
+6877,"@@ -154,7 +154,7 @@ class ServiceProvider extends ModuleServiceProvider
+          */
+         WidgetManager::instance()->registerReportWidgets(function($manager){
+             $manager->registerReportWidget('System\ReportWidgets\Status', [
+-                'label'   => 'System status',
++                'label'   => Lang::get('backend::lang.dashboard.status.widget_title_default'),
+                 'context' => 'dashboard'
+             ]);
+         });","Early translation , should be logic-less"
+6878,"@@ -0,0 +1,19 @@
++package proxy
++
++import ""net/http""
++
++type interceptor interface {
++	InterceptRequest(*http.Request) (*http.Request, error)
++	InterceptResponse(*http.Response) (*http.Response, error)
++}
++
++type nullInterceptor struct {
++}
++
++func (i nullInterceptor) InterceptRequest(r *http.Request) (*http.Request, error) {
++	return r, nil
++}
++
++func (i nullInterceptor) InterceptResponse(r *http.Response) (*http.Response, error) {
++	return r, nil
++}","I don't understand why these functions return a request/response, respectively. In all implementations we actually _modify_ the request/response given as a parameter. Do you envisage situations where we'd want to construct completely fresh request/response objects? Even if we do, it's not something needed atm, so I'd favour in keeping the API minimal. Also, the fact that these functions _may_ mutate the request/response should be noted."
+6879,"@@ -147,8 +147,8 @@ Rails.application.routes.draw do
+   get 'maintenance', to: 'abouts#maintenance'
+   get 'tools', to: 'abouts#tools'
+
+-  get 'p/compare', to: 'compares#projects', as: :compare_projects
+-  get 'p/project_graph', to: 'compares#projects_graph', as: :compare_graph_projects
++  get 'p/_compare', to: 'compares#projects', as: :compare_projects
++  get 'p/_project_graph', to: 'compares#projects_graph', as: :compare_graph_projects
+   get 'projects/:id/stacks', to: 'stacks#project_stacks', constraints: { format: /xml/ }
+   get 'p/:id/stacks', to: 'stacks#project_stacks', as: :project_stacks, constraints: { format: /xml/ }
+   get 'p/:id/stacks', to: redirect('/p/%{id}/users'), constraints: { format: /html/ }",Wasn't there a subsequent reason why we had to keep the `/p/project_graph` route? Outside references or is the proposed solution to the original proposal we us `/p/g` as the `compares#project_graph` route?
+6880,"@@ -44,6 +44,14 @@ public class GenTest {
+         assertThat(gen.apply(RANDOM)).isEqualTo(3);
+     }
+
++    @Test
++    public void shouldCreateGenOfFixedValues() {
++        final Gen<Integer> gen = Gen.fixed(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++    }
++
+     // -- random number generator (rng)
+
+     @Test",Any suggestions on how I would even _approach_ writing tests for arbitrary values....
+6881,"@@ -46,8 +46,8 @@ class Theme
+      */
+     protected static $editThemeCache = false;
+
+-    const ACTIVE_KEY = 'cms::theme.active';
+-    const EDIT_KEY = 'cms::theme.edit';
++    private const ACTIVE_KEY = 'cms::theme.active';
++    private const EDIT_KEY = 'cms::theme.edit';
+
+     /**
+      * Loads the theme.","Scope declarations for class constants was not added until 7.1, this will not be accepted."
+6882,"@@ -126,9 +126,11 @@ void TThreadedServer::onClientDisconnected(TConnectedClient* pClient) {
+   Synchronized sync(clientMonitor_);
+   drainDeadClients(); // use the outgoing thread to do some maintenance on our dead client backlog
+   ClientMap::iterator it = activeClientMap_.find(pClient);
+-  ClientMap::iterator end = it;
+-  deadClientMap_.insert(it, ++end);
+-  activeClientMap_.erase(it);
++  if (it != activeClientMap_.end()) {
++    ClientMap::iterator end = it;
++    deadClientMap_.insert(it, ++end);
++    activeClientMap_.erase(it);
++  }
+   if (activeClientMap_.empty()) {
+     clientMonitor_.notify();
+   }",The assertion here is that find should never return end() because this is the only mechanism that reaps items from the activeClientMap. If it == end something went horribly wrong.
+6883,"@@ -24,6 +24,12 @@ import (
+
+ // A Collection is a set of documents.
+ type Collection interface {
++	// Key returns the document key, or nil if the document doesn't have one. Key
++	// should not return an error if the key is missing unless the collection cannot
++	// generate a fresh key for a Create action.
++	// The returned key must be comparable.
++	Key(Document) (interface{}, error)
++
+ 	// RunActions executes a slice of actions.
+ 	//
+ 	// If unordered is false, it must appear as if the actions were executed in the","The `unless the collection ...` part reads a little bit hard, maybe separate into its own sentence and explain what it means by `cannot generate a fresh key`?"
+6884,"@@ -50,6 +50,9 @@ const (
+
+ 	// The feature is not implemented.
+ 	Unimplemented ErrorCode = 6
++
++	// The system was in the wrong state.
++	FailedPrecondition ErrorCode = 7
+ )
+
+ // Call ""go generate"" whenever you change the above list of error codes.",Doesn't `gcerr_string.go` need to be updated for this?
+6885,"@@ -2473,6 +2473,8 @@ func (c *Compiler) parseConvert(typeFrom, typeTo types.Type, value llvm.Value, p
+ 		switch elemType.Kind() {
+ 		case types.Byte:
+ 			return c.createRuntimeCall(""stringToBytes"", []llvm.Value{value}, """"), nil
++		case types.Rune:
++			return c.createRuntimeCall(""stringToRunes"", []llvm.Value{value}, """"), nil
+ 		default:
+ 			return llvm.Value{}, c.makeError(pos, ""todo: convert from string: ""+elemType.String())
+ 		}","Both cases allowed by the Go spec are now supported, so it's a bug in the compiler if we get here. You can replace the `todo:` error with a panic. (Note: getting here would be a bug because when we get to SSA level the code has long been type checked and has already been verified as being valid Go)."
+6886,"@@ -551,6 +551,14 @@ class TabbedBrowser(tabwidget.TabWidget):
+                 return
+             widget.setFocus()
+
++    def load_prepared_history(self, idx):
++        tab = self.widget(idx)
++        if len(tab.history_prepared) > 0:
++            tab.history.load_items(tab.history_prepared)
++            tab.history_prepared = []
++        #end if
++    #end def load_prepared_history
++
+     @pyqtSlot(int)
+     def on_current_changed(self, idx):
+         """"""Set last-focused-tab and leave hinting mode when focus changed.""""""",You can simply do `if tab.history_prepared:` here as empty lists are falsey.
+6887,"@@ -25,6 +25,8 @@ import (
+
+ 	""github.com/jetstack/cert-manager/cmd/ctl/pkg/create""
+ 	""github.com/jetstack/cert-manager/cmd/ctl/pkg/create/certificatesigningrequest""
++
++	""github.com/jetstack/cert-manager/cmd/ctl/pkg/install""
+ )
+
+ func NewCmdExperimental(ctx context.Context, ioStreams genericclioptions.IOStreams, factory cmdutil.Factory) *cobra.Command {",Remove this whitespace
+6888,"@@ -118,12 +118,14 @@ def preprocess_example_input(input_config):
+     input_path = input_config['input_path']
+     input_shape = input_config['input_shape']
+     one_img = mmcv.imread(input_path)
++    one_img = mmcv.imresize(one_img, input_shape[2:][::-1])
++    show_img = one_img.copy()
+     if 'normalize_cfg' in input_config.keys():
+         normalize_cfg = input_config['normalize_cfg']
+         mean = np.array(normalize_cfg['mean'], dtype=np.float32)
+         std = np.array(normalize_cfg['std'], dtype=np.float32)
+         one_img = mmcv.imnormalize(one_img, mean, std)
+-    one_img = mmcv.imresize(one_img, input_shape[2:][::-1]).transpose(2, 0, 1)
++    one_img = one_img.transpose(2, 0, 1)
+     one_img = torch.from_numpy(one_img).unsqueeze(0).float().requires_grad_(
+         True)
+     (_, C, H, W) = input_shape",`show_img` is not normalized while `one_img` is normalized. And line 139 pass `show_img` for pytorch2onnx function. Is this expected behavior?
+6889,"@@ -45,11 +45,11 @@ function init(instance) {
+             let inputOffset = /[-+]?\d+\.?\d*/g.exec(this.textContent);
+             if (inputOffset) {
+                 inputOffset = inputOffset[0];
++                inputOffset = parseFloat(inputOffset);
++                inputOffset = Math.min(30, Math.max(-30, inputOffset));
+
+                 // replace current text by considered offset
+                 this.textContent = inputOffset + 's';
+-
+-                inputOffset = parseFloat(inputOffset);
+                 // set new offset
+                 playbackManager.setSubtitleOffset(inputOffset, player);
+                 // synchronize with slider value",Why is this bounded between -30 and 30?
+6890,"@@ -21,7 +21,7 @@ THE SOFTWARE.
+ */
+
+ /* HIT_START
+- * BUILD: %t %s ../../test_common.cpp EXCLUDE_HIP_PLATFORM all
++ * BUILD: %t %s ../../test_common.cpp EXCLUDE_HIP_PLATFORM nvcc
+  * TEST: %t
+  * HIT_END
+  */",I think even you can exclude to run it on nvcc
+6891,"@@ -179,7 +179,7 @@ func CreateIstgtConf(cStorVolume *apis.CStorVolume) []byte {
+ 	buffer.WriteString(`
+   PhysRecordLength 4096
+ `)
+-	buffer.WriteString(""  LUN0 Storage "" + cStorVolume.Spec.Capacity + "" 32k"")
++	buffer.WriteString(""  LUN0 Storage "" + cStorVolume.Spec.Capacity.String() + "" 32k"")
+ 	buffer.WriteString(`
+   LUN0 Option Unmap Disable
+   LUN0 Option WZero Disable",G104: Errors unhandled. (from `gosec`)
+6892,"@@ -182,6 +182,11 @@ class ECSTask(luigi.Task):
+         response = client.run_task(taskDefinition=self.task_def_arn,
+                                    overrides=overrides,
+                                    cluster=self.cluster)
++
++        if response['failures']:
++            raise Exception("", "".join([""fail to run task {0} reason: {1}"".format(failure['arn'], failure['reason'])
++                                       for failure in response['failures']]))
++
+         self._task_ids = [task['taskArn'] for task in response['tasks']]
+
+         # Wait on task completion","will `failure` always include `arn` and `reason` in its dictionary? If so, :+1:"
+6893,"@@ -46,13 +46,13 @@ module Bolt
+         @logger = Logging.logger[self]
+       end
+
+-      def with_events(target, callback)
++      def with_events(target, callback, action)
+         callback&.call(type: :node_start, target: target)
+
+         result = begin
+                    yield
+                  rescue StandardError, NotImplementedError => e
+-                   Bolt::Result.from_exception(target, e)
++                   Bolt::Result.from_exception(target, e, action: action)
+                  end
+
+         callback&.call(type: :node_result, result: result)","Should this be optional, or default to 'action' as well?"
+6894,"@@ -16,6 +16,12 @@ package client
+ import (
+ 	""context""
+
++	""github.com/pkg/errors""
++	""k8s.io/apimachinery/pkg/types""
++	ctrl ""sigs.k8s.io/controller-runtime""
++
++	""github.com/chaos-mesh/chaos-mesh/controllers/config""
++
+ 	""google.golang.org/grpc""
+ 	v1 ""k8s.io/api/core/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""",how about formating this import?
+6895,"@@ -177,13 +177,14 @@ def getReviewPosition():
+ 		globalVars.reviewPosition,globalVars.reviewPositionObj=review.getPositionForCurrentMode(obj)
+ 		return globalVars.reviewPosition
+
+-def setReviewPosition(reviewPosition,clearNavigatorObject=True):
++def setReviewPosition(reviewPosition,clearNavigatorObject=True, isCaret=False):
+ 	""""""Sets a TextInfo instance as the review position. if clearNavigatorObject is true, It sets the current navigator object to None so that the next time the navigator object is asked for it fetches it from the review position.
+ 	""""""
+ 	globalVars.reviewPosition=reviewPosition.copy()
+ 	globalVars.reviewPositionObj=reviewPosition.obj
+ 	if clearNavigatorObject: globalVars.navigatorObject=None
+-	braille.handler.handleReviewMove()
++	eventHandler.lastReviewMoveDueToFollowing = isCaret
++	braille.handler.handleReviewMove(shouldAutoTether=not isCaret)
+
+ def getNavigatorObject():
+ 	""""""Gets the current navigator object. Navigator objects can be used to navigate around the operating system (with the number pad) with out moving the focus. If the navigator object is not set, it fetches it from the review position. ","Comma police. :) Also, the docstring needs updating."
+6896,"@@ -51,6 +51,7 @@ type driver struct {
+ 	volume.QuiesceDriver
+ 	volume.CredsDriver
+ 	volume.CloudBackupDriver
++	volume.CloudMigrateDriver
+ 	kv          kvdb.Kvdb
+ 	thisCluster cluster.Cluster
+ }",Implement an in-memory implementation of this in the fake driver.
+6897,"@@ -0,0 +1,13 @@
++require 'spec_helper'
++
++describe 'shows/_show.html.erb' do
++  it 'includes published episodes count' do
++    show = create(:show)
++    create_list(:video, 2, :published, watchable: show)
++    create(:video, watchable: show)
++
++    render 'shows/show', show: show
++
++    expect(rendered).to include('2 episodes')
++  end
++end",Same question as the other view spec regarding not actually saving records.
+6898,"@@ -269,9 +269,9 @@ namespace NLog.Config
+                     factory.RegisterItemsFromAssembly(extensionAssembly);
+                     success = true;
+                 }
+-                catch (Exception)
++                catch (Exception ex)
+                 {
+-                    InternalLogger.Warn(""Auto loading assembly file: {0} failed! Skipping this file."", extensionDll);
++                    InternalLogger.Warn(ex, ""Auto loading assembly file: {0} failed! Skipping this file."", extensionDll);
+                 }
+                 if (success)
+                 {",Rethrow for `MustBeRethrown()`-exceptions?
+6899,"@@ -43,11 +43,13 @@ class RandomSampler(BaseSampler):
+             Tensor or ndarray: sampled indices.
+         """"""
+         assert len(gallery) >= num
+-
+         is_tensor = isinstance(gallery, torch.Tensor)
+         if not is_tensor:
+-            gallery = torch.tensor(
+-                gallery, dtype=torch.long, device=torch.cuda.current_device())
++            if torch.cuda.is_available():
++                device = torch.cuda.current_device()
++            else:
++                device = 'cpu'
++            gallery = torch.tensor(gallery, dtype=torch.long, device=device)
+         perm = torch.randperm(gallery.numel(), device=gallery.device)[:num]
+         rand_inds = gallery[perm]
+         if not is_tensor:",May clean the unnecessary modification.
+6900,"@@ -227,8 +227,13 @@ AX_CODE_COVERAGE
+ AC_ARG_WITH([flux-security], AS_HELP_STRING([--with-flux-security],
+              [Build with flux-security]))
+ AS_IF([test ""x$with_flux_security"" = ""xyes""], [
+-    PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security], [], [])
++    PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security],
++                      [flux_sec_incdir=`$PKG_CONFIG --variable=includedir flux-security`],
++                      [flux_sec_incdir=;])
++    AS_IF([test ""x$flux_sec_incdir"" = x],
++          [AC_MSG_ERROR([couldn't find flux-security or include directory])])
+     AC_DEFINE([HAVE_FLUX_SECURITY], [1], [Define flux-security is available])
++    AC_SUBST(FLUX_SECURITY_INCDIR, $flux_sec_incdir)
+ ])
+ AM_CONDITIONAL([HAVE_FLUX_SECURITY], [test ""x$with_flux_security"" = ""xyes""])
+ ",Should this line set the value to `x` since that is checked below?
+6901,"@@ -138,6 +138,14 @@ public interface DataFile {
+    */
+   DataFile copy();
+
++  /**
++   * Copies this {@link DataFile data file} without file stats. Manifest readers can reuse data file instances; use
++   * this method to copy data without stats when collecting files.
++   *
++   * @return a copy of this data file
++   */
++  DataFile slimCopy();
++
+   /**
+    * @return List of recommended split locations, if applicable, null otherwise.
+    * When available, this information is used for planning scan tasks whose boundaries","I don't particularly love the terminology here. Why not simply add `copy(boolean stats)` or a copy with an enum to indicate what portions of the datafile to include? At some point we may want just some of the values (e.g. CBO may want counts, but not lower/upper bounds). Just a thought."
+6902,"@@ -220,11 +220,12 @@ public final class QueryRequest {
+     public Builder parseAnnotationQuery(String annotationQuery) {
+       if (annotationQuery != null && !annotationQuery.isEmpty()) {
+         for (String ann : annotationQuery.split("" and "")) {
+-          if (ann.indexOf('=') == -1) {
++          int idx = ann.indexOf('=');
++          if (idx == -1) {
+             addAnnotation(ann);
+           } else {
+             String[] keyValue = ann.split(""="");
+-            addBinaryAnnotation(keyValue[0], keyValue.length < 2 ? """" :keyValue[1]);
++            addBinaryAnnotation(ann.substring(0, idx), keyValue.length < 2 ? """" : ann.substring(idx+1));
+           }
+         }
+       }",you could probably remove keyValue and just compare idx vs ann.length (ex I think the goal here is to ensure it works with a value like `foo=`
+6903,"@@ -94,8 +94,8 @@ exports.getMimeType = (item) => {
+ }
+
+ exports.getId = (item) => {
+-  if (item.file_type && item.file_type === 'TIMELINE') {
+-    return `${encodeURIComponent(item.meeting_id)}__TIMELINE`
++  if (item.file_type && item.file_type === 'CC') {
++    return `${encodeURIComponent(item.meeting_id)}__CC__${encodeURIComponent(item.recording_start)}`
+   } else if (item.file_type) {
+     return `${encodeURIComponent(item.meeting_id)}__${encodeURIComponent(item.id)}`
+   }",we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting
+6904,"@@ -182,7 +182,6 @@ class KohaRest extends \VuFind\ILS\Driver\AbstractBase implements
+      */
+     protected $itemStatusMappings = [
+         'Item::Held' => 'On Hold',
+-        'Item::Lost' => 'Lost--Library Applied',
+         'Item::Waiting' => 'On Holdshelf',
+     ];
+ ",You've deleted this code but not added it anywhere else. Should this be used as my proposed example in the .ini file? Do we need a mechanism for configuring a global fallback string independent of the numeric codes?
+6905,"@@ -46,6 +46,9 @@ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.ImmutableSet;
+ import com.google.protobuf.DescriptorProtos.FieldDescriptorProto.Type;
+
++import java.util.ArrayList;
++import java.util.Arrays;
++import java.util.Collections;
+ import java.util.List;
+
+ import javax.annotation.Nullable;",nit: strip away those imports? seems not used in the new code.
+6906,"@@ -25,8 +25,12 @@ import (
+ 	""os""
+ 	""time""
+
++	""github.com/ethereum/go-ethereum/common""
++
++	""github.com/ethereum/go-ethereum/accounts/abi/bind""
+ 	""github.com/ethereum/go-ethereum/core/types""
+ 	""github.com/ethereum/go-ethereum/ethclient""
++	""github.com/mysteriumnetwork/node/blockchain/generated""
+ 	""github.com/mysteriumnetwork/payments/cli/helpers""
+ 	""github.com/mysteriumnetwork/payments/contracts/abigen""
+ 	""github.com/mysteriumnetwork/payments/mysttoken""",redundant whitespace :octocat:
+6907,"@@ -698,7 +698,8 @@ class TestCloudFormationSetStackPolicy(CloudFormationConnectionBase):
+         self.set_http_response(status_code=200)
+         api_response = self.service_connection.set_stack_policy('stack-id',
+             stack_policy_body='{}')
+-        self.assertEqual(api_response['Some'], 'content')
++        self.assertDictEqual(api_response, {'SetStackPolicyResult': {'Some': 'content'}})
++        self.assertIsInstance(api_response, dict)
+         self.assert_request_parameters({
+             'Action': 'SetStackPolicy',
+             'ContentType': 'JSON',","I don't believe that the `assertDictEqual` call can pass without `api_response` being a `dict`, so this second check isn't needed!"
+6908,"@@ -213,8 +213,10 @@ static h2o_iovec_t *decode_string(h2o_mem_pool_t *pool, const uint8_t **src, con
+         if (len > src_end - *src)
+             return NULL;
+         ret = alloc_buf(pool, len * 2); /* max compression ratio is >= 0.5 */
+-        if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_header_name, err_desc)) == SIZE_MAX)
++        if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_header_name, err_desc)) == SIZE_MAX) {
++            h2o_mem_release_shared(ret);
+             return NULL;
++        }
+         ret->base[ret->len] = '\0';
+     } else {
+         if (len > src_end - *src)","Fuzzer did not like this change. Looks like I misunderstood how the pool works... if allocated from a pool we should never free it manually, right? I think I'll need to drop this patch."
+6909,"@@ -4,16 +4,13 @@ import javafx.beans.property.ObjectProperty;
+ import javafx.beans.property.SimpleObjectProperty;
+ import javafx.scene.control.Alert;
+ import javafx.scene.control.ButtonType;
+-import javafx.scene.control.Label;
+-import javafx.scene.layout.Region;
+-import javafx.stage.Window;
+
+ import java.util.Optional;
+
+ /**
+- * A confirm dialog with two callbacks
++ * An abstract class for confirm dialogs with two callbacks
+  */
+-public class ConfirmDialog extends Alert {
++public abstract class ConfirmDialog extends Alert {
+     /**
+      * Callback for {@link ButtonType#OK} button events
+      */","Wouldn't it make sense to already have title, owner etc in this class?"
+6910,"@@ -18,6 +18,19 @@ module Faker
+         def character
+           fetch('aqua_teen_hunger_force.character')
+         end
++
++        ##
++        # Produces a perl of great AHTF wisdom
++        #
++        # @return [String]
++        #
++        # @example
++        #   Faker::TvShows::AquaTeenHungerForce.quote #=> ""Friendship ain't about trust. Friendship's about nunchucks.""
++        #
++        # @faker.version 1.8.5
++        def quote
++          fetch('aqua_teen_hunger_force.quote')
++        end
+       end
+     end
+   end",New generators should have version `next`
+6911,"@@ -204,6 +204,8 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+         params.add(""--metrics-category"");
+         params.add(((Enum<?>) category).name());
+       }
++      params.add(""--metrics-protocol"");
++      params.add(metricsConfiguration.getProtocol().name());
+       if (metricsConfiguration.isPushEnabled()) {
+         params.add(""--metrics-push-enabled"");
+         params.add(""--metrics-push-host"");",Wrap these two lines inside an `if (node.isMetricsEnabled() || metricsConfiguration.isPushEnabled()) { ... }`
+6912,"@@ -85,13 +85,14 @@ class FPN(BaseModule):
+         self.fp16_enabled = False
+         self.upsample_cfg = upsample_cfg.copy()
+
+-        if end_level == -1:
++        if end_level == -1 or end_level == self.num_ins:
++            # if end_level == len(inputs) or end_level == -1, extra level is allowed
+             self.backbone_end_level = self.num_ins
+             assert num_outs >= self.num_ins - start_level
+         else:
+             # if end_level < inputs, no extra level is allowed
+             self.backbone_end_level = end_level
+-            assert end_level <= len(in_channels)
++            assert end_level < len(in_channels)
+             assert num_outs == end_level - start_level
+         self.start_level = start_level
+         self.end_level = end_level",if end_level == -1 or end_level == (self.num_ins - 1): for end_level is the Index of the end input backbone level.
+6913,"@@ -33,6 +33,17 @@ namespace Nethermind.Store
+         public bool IsLeaf { get; }
+         public bool IsExtension => !IsLeaf;
+
++        public int Size
++        {
++            get
++            {
++                const int refSize = sizeof(long);
++                const int arrayOverhead = sizeof(long);
++                return refSize + Path.Length + arrayOverhead
++                    + 4 /* aligned bools */;
++            }
++        }
++
+         public byte[] ToBytes()
+         {
+             byte[] output = new byte[Path.Length / 2 + 1];",No CLR overhead?
+6914,"@@ -414,6 +414,18 @@ func TestCreateInstanceValidateMachineType(t *testing.T) {
+ 	p := ""project""
+ 	z := ""zone""
+
++	_, c, err := daisyCompute.NewTestClient(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
++		if r.Method == ""GET"" && r.URL.String() == ""/project/zones/zone/machineTypes/mt?alt=json"" {
++			fmt.Fprintln(w, `{}`)
++		} else {
++			w.WriteHeader(http.StatusBadRequest)
++			fmt.Fprintf(w, ""bad request: %+v"", r)
++		}
++	}))
++	if err != nil {
++		t.Fatalf(""error creating test client: %v"", err)
++	}
++
+ 	tests := []struct {
+ 		desc      string
+ 		mt        string",Consider faking the TestClient's GetProject/GetZone/GetMachine methods.
+6915,"@@ -88,13 +88,15 @@ func AddHeader(key, value string) OutboundOption {
+ 	}
+ }
+
+-// NewOutbound builds an HTTP outbound which sends requests to peers supplied
++// NewOutbound builds an HTTP outbound that sends requests to peers supplied
+ // by the given peer.Chooser. The URL template for used for the different
+ // peers may be customized using the URLTemplate option.
+ //
+-// Peer Choosers used with the HTTP outbound MUST yield *hostport.Peer
+-// objects. Also note that the Chooser MUST have started before Outbound.Start
+-// is called.
++// The peer chooser and outbound must share the same transport, in this case
++// the HTTP transport.
++// The peer chooser must use the transport's RetainPeer to obtain peer
++// instances and return those peers to the outbound when it calls Choose.
++// The concrete peer type is private and intrinsic to the HTTP transport.
+ func (t *Transport) NewOutbound(chooser peer.Chooser, opts ...OutboundOption) *Outbound {
+ 	o := &Outbound{
+ 		once:        sync.Once(),",Returning a private type as part of the public API? Isn't this impossible for users to implement?
+6916,"@@ -422,9 +422,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule,
+     if (canonical) {
+       if (tmol->hasProp(""_canonicalRankingNumbers"")) {
+         for (unsigned int i = 0; i < tmol->getNumAtoms(); ++i) {
+-          unsigned int rankNum;
+-          tmol->getAtomWithIdx(i)
+-              ->getPropIfPresent(""_canonicalRankingNumber"", rankNum);
++          unsigned int rankNum = 0;
++          tmol->getAtomWithIdx(i)->getPropIfPresent(""_canonicalRankingNumber"",
++                                                    rankNum);
+           ranks[i] = rankNum;
+         }
+       } else {","prefer common_properties::_canonicalRankingNumber if possible, should be quicker in general."
+6917,"@@ -52,6 +52,8 @@ class AnchorHead(nn.Module):
+                      loss_weight=1.0),
+                  loss_bbox=dict(
+                      type='SmoothL1Loss', beta=1.0 / 9.0, loss_weight=1.0),
++                 loss_normalizer=-1,
++                 loss_normalizer_momentum=0.9,
+                  train_cfg=None,
+                  test_cfg=None):
+         super(AnchorHead, self).__init__()",The meaning of `loss_normalizer` and `loss_normalizer_momentum` should be reflected in docstring.
+6918,"@@ -87,11 +87,16 @@ static void init_async(h2o_multithread_queue_t *queue, h2o_loop_t *loop)
+ {
+     int fds[2];
+
++#ifndef _WIN32
+     if (cloexec_pipe(fds) != 0) {
+         perror(""pipe"");
+         abort();
+     }
+     fcntl(fds[1], F_SETFL, O_NONBLOCK);
++#else
++    u_long nonblock = 1;
++    ioctlsocket(fds[1], FIONBIO, &nonblock);
++#endif
+     queue->async.write = fds[1];
+     queue->async.read = h2o_evloop_socket_create(loop, fds[0], NULL, 0, 0);
+     queue->async.read->data = queue;",Call to `cloexec_pipe` (or an equivalent function) is missing. I presume that this is the reason why you are seeing timeout errors.
+6919,"@@ -26,11 +26,7 @@ import org.springframework.security.oauth2.jwt.Jwt;
+
+ import java.time.Duration;
+ import java.time.Instant;
+-import java.util.Arrays;
+-import java.util.Collection;
+-import java.util.Collections;
+-import java.util.HashMap;
+-import java.util.Map;
++import java.util.*;
+
+ import static org.assertj.core.api.Assertions.assertThat;
+ import static org.assertj.core.api.Assertions.assertThatThrownBy;",There are no changes in this file. Please reset.
+6920,"@@ -731,9 +731,11 @@ def nullDistribution(verbosity=0):
+
+ def normalProbability(x, distributionParams):
+   """"""
+-  Given the normal distribution specified by the mean and standard deviation in
+-  distributionParams, return the probability of getting samples > x.
+-  This is the Q-function: the tail probability of the normal distribution.
++  Given the normal distribution specified by the mean and standard deviation
++  in distributionParams, return the probability of getting samples further
++  from the mean. For values above the mean, this is the probability of getting
++  samples > x and for values below the mean, the probability of getting
++  samples < x. This is the Q-function: the tail probability of the normal distribution.
+
+   :param distributionParams: dict with 'mean' and 'stdev' of the distribution
+   """"""",Should we rename this to tailProbability?
+6921,"@@ -431,6 +431,9 @@ drutil_insert_get_mem_addr_arm(void *drcontext, instrlist_t *bb, instr_t *where,
+             index = replace_stolen_reg(drcontext, bb, where, memref, dst, scratch,
+                                        scratch_used);
+         }
++        if (opnd_get_base_aligned(memref)) {
++            // TODO
++        }
+         if (index == REG_NULL && opnd_get_disp(memref) != 0) {
+             /* first try ""add dst, base, #disp"" */
+             instr = negated",Add the issue number too i#4400
+6922,"@@ -373,7 +373,7 @@ abstract class BaseFile<F>
+     if (list != null) {
+       List<E> copy = Lists.newArrayListWithExpectedSize(list.size());
+       copy.addAll(list);
+-      return Collections.unmodifiableList(copy);
++      return copy;
+     }
+     return null;
+   }",Why make this modifiable?
+6923,"@@ -8,13 +8,11 @@ package blockchain
+
+ const (
+ 	// Erc721Binary a simple erc721 token bin
+-	Erc721Binary=""60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a700000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b5050620002c5565b7fffffffff000000000000000000000000000000000000000000000000000000008082161415620001e357600080fd5b7fffffffff00000000000000000000000000000000000000000000000000000000166000908152602081905260409020805460ff19166001179055565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f106200026357805160ff191683800117855562000293565b8280016001018555821562000293579182015b828111156200029357825182559160200191906001019062000276565b50620002a1929150620002a5565b5090565b620002c291905b80821115620002a15760008155600101620002ac565b90565b611b2480620002d56000396000f3006080604052600436106101275763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166301ffc9a7811461012c57806306fdde0314610162578063081812fc146101ec578063095ea7b31461022057806318160ddd1461024657806319fa8f501461026d57806323b872dd1461029f5780632f745c59146102c957806342842e0e146102ed5780634f558e79146103175780634f6ccce71461032f5780636352211e1461034757806370a082311461035f5780638462151c146103805780639507d39a146103f157806395d89b411461045f578063a22cb46514610474578063b88d4fde1461049a578063c87b56dd14610509578063e985e9c514610521578063efc81a8c14610548578063fdb05e851461055d575b600080fd5b34801561013857600080fd5b5061014e600160e060020a031960043516610581565b604080519115158252519081900360200190f35b34801561016e57600080fd5b506101776105a0565b6040805160208082528351818301528351919283929083019185019080838360005b838110156101b1578181015183820152602001610199565b50505050905090810190601f1680156101de5780820380516001836020036101000a031916815260200191505b509250505060405180910390f35b3480156101f857600080fd5b50610204600435610637565b60408051600160a060020a039092168252519081900360200190f35b34801561022c57600080fd5b50610244600160a060020a0360043516602435610652565b005b34801561025257600080fd5b5061025b610708565b60408051918252519081900360200190f35b34801561027957600080fd5b5061028261070e565b60408051600160e060020a03199092168252519081900360200190f35b3480156102ab57600080fd5b50610244600160a060020a0360043581169060243516604435610732565b3480156102d557600080fd5b5061025b600160a060020a03600435166024356107d5565b3480156102f957600080fd5b50610244600160a060020a0360043581169060243516604435610822565b34801561032357600080fd5b5061014e600435610843565b34801561033b57600080fd5b5061025b600435610860565b34801561035357600080fd5b50610204600435610895565b34801561036b57600080fd5b5061025b600160a060020a03600435166108bf565b34801561038c57600080fd5b506103a1600160a060020a03600435166108f2565b60408051602080825283518183015283519192839290830191858101910280838360005b838110156103dd5781810151838201526020016103c5565b505050509050019250505060405180910390f35b3480156103fd57600080fd5b5061040960043561095e565b60408051600160a060020a03909816885260ff9687166020890152948616878601529285166060870152908416608086015290921660a084015267ffffffffffffffff90911660c0830152519081900360e00190f35b34801561046b57600080fd5b50610177610a91565b34801561048057600080fd5b50610244600160a060020a03600435166024351515610af2565b3480156104a657600080fd5b50604080516020601f60643560048181013592830184900484028501840190955281845261024494600160a060020a038135811695602480359092169560443595369560849401918190840183828082843750949750610b769650505050505050565b34801561051557600080fd5b50610177600435610b9e565b34801561052d57600080fd5b5061014e600160a060020a0360043581169060243516610c49565b34801561055457600080fd5b5061025b610c77565b34801561056957600080fd5b50610244600160a060020a0360043516602435610ffb565b600160e060020a03191660009081526020819052604090205460ff1690565b60058054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b820191906000526020600020905b81548152906001019060200180831161060f57829003601f168201915b505050505090505b90565b600090815260026020526040902054600160a060020a031690565b600061065d82610895565b9050600160a060020a03838116908216141561067857600080fd5b33600160a060020a038216148061069457506106948133610c49565b151561069f57600080fd5b600082815260026020526040808220805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a0387811691821790925591518593918516917f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92591a4505050565b60095490565b7f01ffc9a70000000000000000000000000000000000000000000000000000000081565b61073c3382611043565b151561074757600080fd5b600160a060020a038316151561075c57600080fd5b600160a060020a038216151561077157600080fd5b61077b83826110a2565b6107858382611113565b61078f828261121a565b8082600160a060020a031684600160a060020a03167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef60405160405180910390a4505050565b60006107e0836108bf565b82106107eb57600080fd5b600160a060020a038316600090815260076020526040902080548390811061080f57fe5b9060005260206000200154905092915050565b61083e8383836020604051908101604052806000815250610b76565b505050565b600090815260016020526040902054600160a060020a0316151590565b600061086a610708565b821061087557600080fd5b600980548390811061088357fe5b90600052602060002001549050919050565b600081815260016020526040812054600160a060020a03168015156108b957600080fd5b92915050565b6000600160a060020a03821615156108d657600080fd5b50600160a060020a031660009081526003602052604090205490565b600160a060020a03811660009081526007602090815260409182902080548351818402810184019094528084526060939283018282801561095257602002820191906000526020600020905b81548152602001906001019080831161093e575b50505050509050919050565b600081815260016020526040812054600c8054839283928392839283928392600160a060020a03909216918a90811061099357fe5b600091825260209091200154600c805460ff909216918b9081106109b357fe5b9060005260206000200160000160019054906101000a900460ff16600c8b8154811015156109dd57fe5b9060005260206000200160000160029054906101000a900460ff16600c8c815481101515610a0757fe5b9060005260206000200160000160039054906101000a900460ff16600c8d815481101515610a3157fe5b9060005260206000200160000160049054906101000a900460ff16600c8e815481101515610a5b57fe5b600091825260209091200154959e949d50929b50909950975095506501000000000090910467ffffffffffffffff169350915050565b60068054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b600160a060020a038216331415610b0857600080fd5b336000818152600460209081526040808320600160a060020a03871680855290835292819020805460ff1916861515908117909155815190815290519293927f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c31929181900390910190a35050565b610b81848484610732565b610b8d84848484611263565b1515610b9857600080fd5b50505050565b6060610ba982610843565b1515610bb457600080fd5b6000828152600b602090815260409182902080548351601f6002600019610100600186161502019093169290920491820184900484028101840190945280845290918301828280156109525780601f10610c1c57610100808354040283529160200191610952565b820191906000526020600020905b815481529060010190602001808311610c2a5750939695505050505050565b600160a060020a03918216600090815260046020908152604080832093909416825291909152205460ff1690565b60008060008060008060006060610c8c611a07565b610c94610708565b6040805160208082019390935260001943014081830152815180820383018152606090910191829052805190928291908401908083835b60208310610cea5780518252601f199092019160209182019101610ccb565b5181516020939093036101000a600019018019909116921691909117905260405192018290039091209a5060059250505060f860020a60008a901a81020460ff16066001908101975060059089901a60f860020a0260f860020a900460ff16811515610d5257fe5b066001019550600560f860020a60028a901a81020460ff16066001019450600560f860020a60038a901a81020460ff16066001019350600560f860020a60048a901a81020460ff16066001019250610dad87878787876113d0565b6040805160c08101825260ff808b16825289811660208301908152898216938301938452888216606084019081528883166080850190815267ffffffffffffffff43811660a08701908152600c805460018101825560009190915287517fdf6966c971051c3d54ec59162606531493a51404a002842f56009d7e5cf4a8c78201805497519a5196519551935190941665010000000000026cffffffffffffffff0000000000199389166401000000000264ff0000000019968a1663010000000263ff00000019988b16620100000262ff0000199d8c166101000261ff001995909c1660ff19909b169a909a1793909316999099179a909a16969096179490941694909417919091169390931791909116939093179055909a509092509050610ed5338a61152d565b610edf898361157c565b33600160a060020a03167f1ae41272ced32fa050dc3df49761e279866a7a9378212de7a61104821698f18c8a89898989898860a001518a604051808981526020018860ff1660ff1681526020018760ff1660ff1681526020018660ff1660ff1681526020018560ff1660ff1681526020018460ff1660ff1681526020018367ffffffffffffffff1667ffffffffffffffff16815260200180602001828103825283818151815260200191508051906020019080838360005b83811015610faf578181015183820152602001610f97565b50505050905090810190601f168015610fdc5780820380516001836020036101000a031916815260200191505b50995050505050505050505060405180910390a2505050505050505090565b60408051808201909152600481527f74657374000000000000000000000000000000000000000000000000000000006020820152611039838361152d565b61083e828261157c565b60008061104f83610895565b905080600160a060020a031684600160a060020a0316148061108a575083600160a060020a031661107f84610637565b600160a060020a0316145b8061109a575061109a8185610c49565b949350505050565b81600160a060020a03166110b582610895565b600160a060020a0316146110c857600080fd5b600081815260026020526040902054600160a060020a03161561110f576000818152600260205260409020805473ffffffffffffffffffffffffffffffffffffffff191690555b5050565b600080600061112285856115af565b600084815260086020908152604080832054600160a060020a038916845260079092529091205490935061115d90600163ffffffff61164516565b600160a060020a03861660009081526007602052604090208054919350908390811061118557fe5b90600052602060002001549050806007600087600160a060020a0316600160a060020a03168152602001908152602001600020848154811015156111c557fe5b6000918252602080832090910192909255600160a060020a03871681526007909152604090208054906111fc906000198301611a3c565b50600093845260086020526040808520859055908452909220555050565b60006112268383611657565b50600160a060020a039091166000908152600760209081526040808320805460018101825590845282842081018590559383526008909152902055565b60008061127885600160a060020a03166116e7565b151561128757600191506113c7565b6040517f150b7a020000000000000000000000000000000000000000000000000000000081523360048201818152600160a060020a03898116602485015260448401889052608060648501908152875160848601528751918a169463150b7a0294938c938b938b93909160a490910190602085019080838360005b8381101561131a578181015183820152602001611302565b50505050905090810190601f1680156113475780820380516001836020036101000a031916815260200191505b5095505050505050602060405180830381600087803b15801561136957600080fd5b505af115801561137d573d6000803e3d6000fd5b505050506040513d602081101561139357600080fd5b5051600160e060020a031981167f150b7a020000000000000000000000000000000000000000000000000000000014925090505b50949350505050565b6040805180820190915260208082527f68747470733a2f2f6e66746965732e696f2f746f6b656e732f6e66746965732d9082015260609061141181886116ef565b90506114398160408051908101604052806001815260200160f860020a602d02815250611880565b905061144581876116ef565b905061146d8160408051908101604052806001815260200160f860020a602d02815250611880565b905061147981866116ef565b90506114a18160408051908101604052806001815260200160f860020a602d02815250611880565b90506114ad81856116ef565b90506114d58160408051908101604052806001815260200160f860020a602d02815250611880565b90506114e181846116ef565b9050611522816040805190810160405280600481526020017f2e706e6700000000000000000000000000000000000000000000000000000000815250611880565b979650505050505050565b611537828261199f565b600980546000838152600a60205260408120829055600182018355919091527f6e1540171b6c0c960b71a7020d9f60077f6af931a8bbf590da0223dacf75c7af015550565b61158582610843565b151561159057600080fd5b6000828152600b60209081526040909120825161083e92840190611a60565b81600160a060020a03166115c282610895565b600160a060020a0316146115d557600080fd5b600160a060020a0382166000908152600360205260409020546115ff90600163ffffffff61164516565b600160a060020a03909216600090815260036020908152604080832094909455918152600190915220805473ffffffffffffffffffffffffffffffffffffffff19169055565b60008282111561165157fe5b50900390565b600081815260016020526040902054600160a060020a03161561167957600080fd5b6000818152600160208181526040808420805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a03881690811790915584526003909152909120546116c7916119fa565b600160a060020a0390921660009081526003602052604090209190915550565b6000903b1190565b60408051606480825260a0820190925260609190829060009081908390819083908760208201610c8080388339019050509550600094505b60ff89161561177c578551600a60ff9a8b168181049b60018901989290910616955060f860020a603087010291889190811061175f57fe5b906020010190600160f860020a031916908160001a905350611727565b899250848351016040519080825280601f01601f1916602001820160405280156117b0578160200160208202803883390190505b509150600090505b82518110156118105782818151811015156117cf57fe5b90602001015160f860020a900460f860020a0282828151811015156117f057fe5b906020010190600160f860020a031916908160001a9053506001016117b8565b5060005b84811015611873578581600187030381518110151561182f57fe5b90602001015160f860020a900460f860020a02828451830181518110151561185357fe5b906020010190600160f860020a031916908160001a905350600101611814565b5098975050505050505050565b606080606080606060008088955087945084518651016040519080825280601f01601f1916602001820160405280156118c3578160200160208202803883390190505b50935083925060009150600090505b85518110156119305785818151811015156118e957fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561191057fe5b906020010190600160f860020a031916908160001a9053506001016118d2565b5060005b845181101561199257848181518110151561194b57fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561197257fe5b906020010190600160f860020a031916908160001a905350600101611934565b5090979650505050505050565b600160a060020a03821615156119b457600080fd5b6119be828261121a565b6040518190600160a060020a038416906000907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b818101828110156108b957fe5b6040805160c081018252600080825260208201819052918101829052606081018290526080810182905260a081019190915290565b81548183558181111561083e5760008381526020902061083e918101908301611ade565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f10611aa157805160ff1916838001178555611ace565b82800160010185558215611ace579182015b82811115611ace578251825591602001919060010190611ab3565b50611ada929150611ade565b5090565b61063491905b80821115611ada5760008155600101611ae45600a165627a7a72305820eb6ef4caf7e8dfb40d659802d0d7106ab4b338205d58c4b1d0596c47c740a77e0029""
++	Erc721Binary = ""60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a700000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b5050620002c5565b7fffffffff000000000000000000000000000000000000000000000000000000008082161415620001e357600080fd5b7fffffffff00000000000000000000000000000000000000000000000000000000166000908152602081905260409020805460ff19166001179055565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f106200026357805160ff191683800117855562000293565b8280016001018555821562000293579182015b828111156200029357825182559160200191906001019062000276565b50620002a1929150620002a5565b5090565b620002c291905b80821115620002a15760008155600101620002ac565b90565b611b2480620002d56000396000f3006080604052600436106101275763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166301ffc9a7811461012c57806306fdde0314610162578063081812fc146101ec578063095ea7b31461022057806318160ddd1461024657806319fa8f501461026d57806323b872dd1461029f5780632f745c59146102c957806342842e0e146102ed5780634f558e79146103175780634f6ccce71461032f5780636352211e1461034757806370a082311461035f5780638462151c146103805780639507d39a146103f157806395d89b411461045f578063a22cb46514610474578063b88d4fde1461049a578063c87b56dd14610509578063e985e9c514610521578063efc81a8c14610548578063fdb05e851461055d575b600080fd5b34801561013857600080fd5b5061014e600160e060020a031960043516610581565b604080519115158252519081900360200190f35b34801561016e57600080fd5b506101776105a0565b6040805160208082528351818301528351919283929083019185019080838360005b838110156101b1578181015183820152602001610199565b50505050905090810190601f1680156101de5780820380516001836020036101000a031916815260200191505b509250505060405180910390f35b3480156101f857600080fd5b50610204600435610637565b60408051600160a060020a039092168252519081900360200190f35b34801561022c57600080fd5b50610244600160a060020a0360043516602435610652565b005b34801561025257600080fd5b5061025b610708565b60408051918252519081900360200190f35b34801561027957600080fd5b5061028261070e565b60408051600160e060020a03199092168252519081900360200190f35b3480156102ab57600080fd5b50610244600160a060020a0360043581169060243516604435610732565b3480156102d557600080fd5b5061025b600160a060020a03600435166024356107d5565b3480156102f957600080fd5b50610244600160a060020a0360043581169060243516604435610822565b34801561032357600080fd5b5061014e600435610843565b34801561033b57600080fd5b5061025b600435610860565b34801561035357600080fd5b50610204600435610895565b34801561036b57600080fd5b5061025b600160a060020a03600435166108bf565b34801561038c57600080fd5b506103a1600160a060020a03600435166108f2565b60408051602080825283518183015283519192839290830191858101910280838360005b838110156103dd5781810151838201526020016103c5565b505050509050019250505060405180910390f35b3480156103fd57600080fd5b5061040960043561095e565b60408051600160a060020a03909816885260ff9687166020890152948616878601529285166060870152908416608086015290921660a084015267ffffffffffffffff90911660c0830152519081900360e00190f35b34801561046b57600080fd5b50610177610a91565b34801561048057600080fd5b50610244600160a060020a03600435166024351515610af2565b3480156104a657600080fd5b50604080516020601f60643560048181013592830184900484028501840190955281845261024494600160a060020a038135811695602480359092169560443595369560849401918190840183828082843750949750610b769650505050505050565b34801561051557600080fd5b50610177600435610b9e565b34801561052d57600080fd5b5061014e600160a060020a0360043581169060243516610c49565b34801561055457600080fd5b5061025b610c77565b34801561056957600080fd5b50610244600160a060020a0360043516602435610ffb565b600160e060020a03191660009081526020819052604090205460ff1690565b60058054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b820191906000526020600020905b81548152906001019060200180831161060f57829003601f168201915b505050505090505b90565b600090815260026020526040902054600160a060020a031690565b600061065d82610895565b9050600160a060020a03838116908216141561067857600080fd5b33600160a060020a038216148061069457506106948133610c49565b151561069f57600080fd5b600082815260026020526040808220805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a0387811691821790925591518593918516917f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92591a4505050565b60095490565b7f01ffc9a70000000000000000000000000000000000000000000000000000000081565b61073c3382611043565b151561074757600080fd5b600160a060020a038316151561075c57600080fd5b600160a060020a038216151561077157600080fd5b61077b83826110a2565b6107858382611113565b61078f828261121a565b8082600160a060020a031684600160a060020a03167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef60405160405180910390a4505050565b60006107e0836108bf565b82106107eb57600080fd5b600160a060020a038316600090815260076020526040902080548390811061080f57fe5b9060005260206000200154905092915050565b61083e8383836020604051908101604052806000815250610b76565b505050565b600090815260016020526040902054600160a060020a0316151590565b600061086a610708565b821061087557600080fd5b600980548390811061088357fe5b90600052602060002001549050919050565b600081815260016020526040812054600160a060020a03168015156108b957600080fd5b92915050565b6000600160a060020a03821615156108d657600080fd5b50600160a060020a031660009081526003602052604090205490565b600160a060020a03811660009081526007602090815260409182902080548351818402810184019094528084526060939283018282801561095257602002820191906000526020600020905b81548152602001906001019080831161093e575b50505050509050919050565b600081815260016020526040812054600c8054839283928392839283928392600160a060020a03909216918a90811061099357fe5b600091825260209091200154600c805460ff909216918b9081106109b357fe5b9060005260206000200160000160019054906101000a900460ff16600c8b8154811015156109dd57fe5b9060005260206000200160000160029054906101000a900460ff16600c8c815481101515610a0757fe5b9060005260206000200160000160039054906101000a900460ff16600c8d815481101515610a3157fe5b9060005260206000200160000160049054906101000a900460ff16600c8e815481101515610a5b57fe5b600091825260209091200154959e949d50929b50909950975095506501000000000090910467ffffffffffffffff169350915050565b60068054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b600160a060020a038216331415610b0857600080fd5b336000818152600460209081526040808320600160a060020a03871680855290835292819020805460ff1916861515908117909155815190815290519293927f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c31929181900390910190a35050565b610b81848484610732565b610b8d84848484611263565b1515610b9857600080fd5b50505050565b6060610ba982610843565b1515610bb457600080fd5b6000828152600b602090815260409182902080548351601f6002600019610100600186161502019093169290920491820184900484028101840190945280845290918301828280156109525780601f10610c1c57610100808354040283529160200191610952565b820191906000526020600020905b815481529060010190602001808311610c2a5750939695505050505050565b600160a060020a03918216600090815260046020908152604080832093909416825291909152205460ff1690565b60008060008060008060006060610c8c611a07565b610c94610708565b6040805160208082019390935260001943014081830152815180820383018152606090910191829052805190928291908401908083835b60208310610cea5780518252601f199092019160209182019101610ccb565b5181516020939093036101000a600019018019909116921691909117905260405192018290039091209a5060059250505060f860020a60008a901a81020460ff16066001908101975060059089901a60f860020a0260f860020a900460ff16811515610d5257fe5b066001019550600560f860020a60028a901a81020460ff16066001019450600560f860020a60038a901a81020460ff16066001019350600560f860020a60048a901a81020460ff16066001019250610dad87878787876113d0565b6040805160c08101825260ff808b16825289811660208301908152898216938301938452888216606084019081528883166080850190815267ffffffffffffffff43811660a08701908152600c805460018101825560009190915287517fdf6966c971051c3d54ec59162606531493a51404a002842f56009d7e5cf4a8c78201805497519a5196519551935190941665010000000000026cffffffffffffffff0000000000199389166401000000000264ff0000000019968a1663010000000263ff00000019988b16620100000262ff0000199d8c166101000261ff001995909c1660ff19909b169a909a1793909316999099179a909a16969096179490941694909417919091169390931791909116939093179055909a509092509050610ed5338a61152d565b610edf898361157c565b33600160a060020a03167f1ae41272ced32fa050dc3df49761e279866a7a9378212de7a61104821698f18c8a89898989898860a001518a604051808981526020018860ff1660ff1681526020018760ff1660ff1681526020018660ff1660ff1681526020018560ff1660ff1681526020018460ff1660ff1681526020018367ffffffffffffffff1667ffffffffffffffff16815260200180602001828103825283818151815260200191508051906020019080838360005b83811015610faf578181015183820152602001610f97565b50505050905090810190601f168015610fdc5780820380516001836020036101000a031916815260200191505b50995050505050505050505060405180910390a2505050505050505090565b60408051808201909152600481527f74657374000000000000000000000000000000000000000000000000000000006020820152611039838361152d565b61083e828261157c565b60008061104f83610895565b905080600160a060020a031684600160a060020a0316148061108a575083600160a060020a031661107f84610637565b600160a060020a0316145b8061109a575061109a8185610c49565b949350505050565b81600160a060020a03166110b582610895565b600160a060020a0316146110c857600080fd5b600081815260026020526040902054600160a060020a03161561110f576000818152600260205260409020805473ffffffffffffffffffffffffffffffffffffffff191690555b5050565b600080600061112285856115af565b600084815260086020908152604080832054600160a060020a038916845260079092529091205490935061115d90600163ffffffff61164516565b600160a060020a03861660009081526007602052604090208054919350908390811061118557fe5b90600052602060002001549050806007600087600160a060020a0316600160a060020a03168152602001908152602001600020848154811015156111c557fe5b6000918252602080832090910192909255600160a060020a03871681526007909152604090208054906111fc906000198301611a3c565b50600093845260086020526040808520859055908452909220555050565b60006112268383611657565b50600160a060020a039091166000908152600760209081526040808320805460018101825590845282842081018590559383526008909152902055565b60008061127885600160a060020a03166116e7565b151561128757600191506113c7565b6040517f150b7a020000000000000000000000000000000000000000000000000000000081523360048201818152600160a060020a03898116602485015260448401889052608060648501908152875160848601528751918a169463150b7a0294938c938b938b93909160a490910190602085019080838360005b8381101561131a578181015183820152602001611302565b50505050905090810190601f1680156113475780820380516001836020036101000a031916815260200191505b5095505050505050602060405180830381600087803b15801561136957600080fd5b505af115801561137d573d6000803e3d6000fd5b505050506040513d602081101561139357600080fd5b5051600160e060020a031981167f150b7a020000000000000000000000000000000000000000000000000000000014925090505b50949350505050565b6040805180820190915260208082527f68747470733a2f2f6e66746965732e696f2f746f6b656e732f6e66746965732d9082015260609061141181886116ef565b90506114398160408051908101604052806001815260200160f860020a602d02815250611880565b905061144581876116ef565b905061146d8160408051908101604052806001815260200160f860020a602d02815250611880565b905061147981866116ef565b90506114a18160408051908101604052806001815260200160f860020a602d02815250611880565b90506114ad81856116ef565b90506114d58160408051908101604052806001815260200160f860020a602d02815250611880565b90506114e181846116ef565b9050611522816040805190810160405280600481526020017f2e706e6700000000000000000000000000000000000000000000000000000000815250611880565b979650505050505050565b611537828261199f565b600980546000838152600a60205260408120829055600182018355919091527f6e1540171b6c0c960b71a7020d9f60077f6af931a8bbf590da0223dacf75c7af015550565b61158582610843565b151561159057600080fd5b6000828152600b60209081526040909120825161083e92840190611a60565b81600160a060020a03166115c282610895565b600160a060020a0316146115d557600080fd5b600160a060020a0382166000908152600360205260409020546115ff90600163ffffffff61164516565b600160a060020a03909216600090815260036020908152604080832094909455918152600190915220805473ffffffffffffffffffffffffffffffffffffffff19169055565b60008282111561165157fe5b50900390565b600081815260016020526040902054600160a060020a03161561167957600080fd5b6000818152600160208181526040808420805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a03881690811790915584526003909152909120546116c7916119fa565b600160a060020a0390921660009081526003602052604090209190915550565b6000903b1190565b60408051606480825260a0820190925260609190829060009081908390819083908760208201610c8080388339019050509550600094505b60ff89161561177c578551600a60ff9a8b168181049b60018901989290910616955060f860020a603087010291889190811061175f57fe5b906020010190600160f860020a031916908160001a905350611727565b899250848351016040519080825280601f01601f1916602001820160405280156117b0578160200160208202803883390190505b509150600090505b82518110156118105782818151811015156117cf57fe5b90602001015160f860020a900460f860020a0282828151811015156117f057fe5b906020010190600160f860020a031916908160001a9053506001016117b8565b5060005b84811015611873578581600187030381518110151561182f57fe5b90602001015160f860020a900460f860020a02828451830181518110151561185357fe5b906020010190600160f860020a031916908160001a905350600101611814565b5098975050505050505050565b606080606080606060008088955087945084518651016040519080825280601f01601f1916602001820160405280156118c3578160200160208202803883390190505b50935083925060009150600090505b85518110156119305785818151811015156118e957fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561191057fe5b906020010190600160f860020a031916908160001a9053506001016118d2565b5060005b845181101561199257848181518110151561194b57fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561197257fe5b906020010190600160f860020a031916908160001a905350600101611934565b5090979650505050505050565b600160a060020a03821615156119b457600080fd5b6119be828261121a565b6040518190600160a060020a038416906000907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b818101828110156108b957fe5b6040805160c081018252600080825260208201819052918101829052606081018290526080810182905260a081019190915290565b81548183558181111561083e5760008381526020902061083e918101908301611ade565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f10611aa157805160ff1916838001178555611ace565b82800160010185558215611ace579182015b82811115611ace578251825591602001919060010190611ab3565b50611ada929150611ade565b5090565b61063491905b80821115611ada5760008155600101611ae45600a165627a7a72305820eb6ef4caf7e8dfb40d659802d0d7106ab4b338205d58c4b1d0596c47c740a77e0029""
+ 	// CreateTo createTo(address _owner,uint256 _tokenId)
+-	CreateTo=""fdb05e85""
++	CreateTo = ""fdb05e85""
+ 	// TransferFrom transferFrom(address _from, address _to, uint256 _tokenId)
+-	TransferFrom=""23b872dd""
++	TransferFrom = ""23b872dd""
+ 	// BalanceOf BalanceOf(opts *bind.CallOpts, _owner common.Address)
+-	BalanceOf=""70a08231""
+-	)
+-
+-
++	BalanceOf = ""70a08231""
++)",Why this file is changed?
+6924,"@@ -9,6 +9,11 @@ def includeme(config):
+         description='Track changes on data.',
+         url='http://kinto.readthedocs.io/en/latest/api/1.x/history.html')
+
++    config.add_api_capability(
++        'revert',
++        description='discard all changes after given timestamp.',
++        url='http://kinto.readthedocs.io/en/latest/api/1.x/revert.html')
++
+     # Activate end-points.
+     config.scan('kinto.plugins.history.views')
+ ",I'm not sure that we need this
+6925,"@@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Build.Tasks
+             string dependencyVersion;
+             if (package.Value is JObject)
+             {
+-                dependencyVersion = package.Value[""version""].Value<string>();
++                dependencyVersion = package.Value[""version""]?.Value<string>();
+             }
+             else if (package.Value is JValue)
+             {",Is this going to cause issues in any other places were someone forgets the version? Should we consider also checking for type=project?
+6926,"@@ -86,3 +86,18 @@ func extractASMValue(out *secretsmanager.GetSecretValueOutput) (docker.AuthConfi
+
+ 	return dac, nil
+ }
++
++// GetSecretFromASM makes the api call to the AWS Secrets Manager service to
++// retrieve the secret value
++func GetSecretFromASM(secretID string, client secretsmanageriface.SecretsManagerAPI) (string, error) {
++	in := &secretsmanager.GetSecretValueInput{
++		SecretId: aws.String(secretID),
++	}
++
++	out, err := client.GetSecretValue(in)
++	if err != nil {
++		return """", errors.Wrapf(err, ""secret %s"", secretID)
++	}
++
++	return aws.StringValue(out.SecretString), nil
++}",Does this have retries? Is there a possibility that customer would hit throttle errors here?
+6927,"@@ -3,15 +3,17 @@
+ #endif
+ #include <platform.h>
+
+-#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_FREEBSD)
++#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_BSD)
+ #include <sched.h>
+ #include <sys/time.h>
+ #include <sys/resource.h>
+ #include <sys/mman.h>
+ #endif
+
+-#if defined(PLATFORM_IS_FREEBSD)
++#if defined(PLATFORM_IS_BSD)
+ #include <pthread_np.h>
++#endif
++#if defined(PLATFORM_IS_FREEBSD)
+ #include <sys/cpuset.h>
+ typedef cpuset_t cpu_set_t;
+ #endif",i noted that we are inconsistent with when we indent includes (see atomics.h which is rather different) and for example cpu.c which is also different. we seem to have 3 styles.
+6928,"@@ -80,6 +80,12 @@ const start = (passthroughArgs, buildConfig = config.defaultBuildConfig, options
+     if (user_data_dir) {
+       // clear the data directory before doing a network test
+       fs.removeSync(user_data_dir.replace('\\', ''))
++      if (fs.existsSync(networkLogFile)) {
++        fs.unlinkSync(networkLogFile)
++      }
++      if (fs.existsSync('network-audit-results.json')) {
++        fs.unlinkSync('network-audit-results.json')
++      }
+     }
+   }
+ ",Deleting the files before starting the audit helps avoid stale results if the new file is not created.
+6929,"@@ -70,14 +70,8 @@ func (c *Controller) spcEventHandler(operation string, spcGot *apis.StoragePoolC
+ 		// CreateStoragePool function will create the storage pool
+ 		// It is a create event so resync should be false and pendingPoolcount is passed 0
+ 		// pendingPoolcount is not used when resync is false.
+-		var newSpcLease Leases
+-		newSpcLease = &spcLease{spcGot, SpcLeaseKey, c.clientset}
+-		_, err := newSpcLease.GetLease()
+-		if err != nil {
+-			glog.Errorf(""Could not acquire lease on spc object:%v"", err)
+-			return addEvent, err
+-		}
+-		err = CreateStoragePool(spcGot, false, 0)
++
++		err := c.CreateStoragePool(spcGot, false, 0)
+
+ 		if err != nil {
+ 			glog.Error(""Storagepool could not be created:"", err)",Remove this blank line
+6930,"@@ -23,12 +23,19 @@ import com.google.api.codegen.discovery.Schema.Format;
+ import com.google.api.codegen.discovery.Schema.Type;
+ import com.google.api.codegen.transformer.ImportTypeTable;
+ import com.google.api.codegen.util.Name;
++import com.google.api.codegen.util.SymbolTable;
+ import com.google.api.codegen.util.TypeName;
+ import com.google.api.tools.framework.model.Oneof;
+ import com.google.api.tools.framework.model.TypeRef.Cardinality;
+ import com.google.common.base.Preconditions;
++import com.google.common.base.Strings;
+ import com.google.common.collect.ImmutableList;
++import java.util.AbstractMap;
++import java.util.Comparator;
++import java.util.HashMap;
+ import java.util.List;
++import java.util.Map;
++import java.util.TreeMap;
+ import java.util.regex.Matcher;
+ import java.util.regex.Pattern;
+ import javax.annotation.Nullable;",This is... quite unconventional (use a map entry as a key). I would suggest making your own data class for the key.
+6931,"@@ -213,7 +213,11 @@ class OutputList(RecycleView):
+         res = []
+         for o in outputs:
+             value = self.app.format_amount_and_units(o.value)
+-            res.append({'address': o.get_ui_address_str(), 'value': value})
++            res.append({
++                    'address': o.get_ui_address_str(),
++                    'value': value,
++                    'background_color': (0.3, 0.3, 0.3, 1),
++                    'color': (1, 1, 1, 1)})
+         self.data = res
+
+ ",why are these colors needed to be specified here? when are they used?
+6932,"@@ -139,7 +139,12 @@ abstract class BaseMetadataTable implements Table {
+
+   @Override
+   public Rollback rollback() {
+-    throw new UnsupportedOperationException(""Cannot roll back a metadata table"");
++    throw new UnsupportedOperationException(""Cannot rollback snapshots from a metadata table"");
++  }
++
++  @Override
++  public ManageSnapshots manageSnapshots() {
++    throw new UnsupportedOperationException(""Cannot manage snapshots in a metadata table"");
+   }
+
+   @Override",Nit: no need to change this method.
+6933,"@@ -19,11 +19,15 @@ import inspect
+ # pylint: disable=line-too-long
+ from google.cloud.forseti.common.util import logger
+ from google.cloud.forseti.common.util import string_formats
++from google.cloud.forseti.services.inventory.storage import DataAccess
++
+ from google.cloud.forseti.notifier.notifiers.base_notification import BaseNotification
+ from google.cloud.forseti.notifier.notifiers import cscc_notifier
++from google.cloud.forseti.notifier.notifiers import email_violations
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+-from google.cloud.forseti.services.inventory.storage import DataAccess
+ from google.cloud.forseti.services.scanner import dao as scanner_dao
++
++
+ # pylint: enable=line-too-long
+
+ ",Why a blank line?
+6934,"@@ -103,7 +103,7 @@
+       <h2><%= _('Request expert feedback') %></h2>
+       <p><%= _('Click below to give data management staff at your organisation access to read and comment on your plan.') %></p>
+       <div class=""well well-sm"">
+-        <%= current_user.org.feedback_email_msg.html_safe %>
++        <%= current_user.org.feedback_email_msg %>
+       </div>
+       <p><%= _('You can continue to edit and download the plan in the interim.') %></p>
+ ",Why remove the `.html_safe` here? Should we use `sanitize` or `raw` instead? This info comes off of the org edit page and is entered by users.
+6935,"@@ -383,7 +383,7 @@ get_dr_stats(void)
+  * returns zero on success, non-zero on failure
+  */
+ DYNAMORIO_EXPORT int
+-dynamorio_app_init(void)
++dynamorio_app_init(bool attach_case)
+ {
+     int size;
+ ",I think we need some docs about how to set this parameter correctly. Are we OK with changing the public API like this? We probably at least want to make a change notice to the release doc.
+6936,"@@ -329,10 +329,13 @@ type ProtocolTag byte
+
+ const (
+ 	ProtocolHeartbeat ProtocolTag = iota
+-	ProtocolOverlayControlMsg
++	ProtocolConnectionEstablished
++	ProtocolFragmentationReceived
++	ProtocolPMTUVerified
+ 	ProtocolGossip
+ 	ProtocolGossipUnicast
+ 	ProtocolGossipBroadcast
++	ProtocolOverlayControlMsg
+ )
+
+ type ProtocolMsg struct {","When we undo this for 1.3, do we not need to leave these three entries intact to avoid renumbering of the subsequent constants? If so perhaps the changes to this file should be pulled into a separate initial commit so we can just `git revert` the remainder..."
+6937,"@@ -60,5 +60,9 @@ func (a *API) Setup() {
+ 		a.removeUnusedShapes()
+ 	}
+
++	if !a.NoValidataShapeMethods {
++		a.addShapeValidations()
++	}
++
+ 	a.initialized = true
+ }",This is never set anywhere in the `cli/gen-api` folder. Should it be?
+6938,"@@ -23,13 +23,13 @@ import (
+ 	""sync""
+ 	""time""
+
+-	v1 ""k8s.io/api/core/v1""
++	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/resource""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	kubeinformers ""k8s.io/client-go/informers""
+ 	""k8s.io/client-go/kubernetes""
+ 	""k8s.io/client-go/kubernetes/scheme""
+-	corev1 ""k8s.io/client-go/kubernetes/typed/core/v1""
++	clientv1 ""k8s.io/client-go/kubernetes/typed/core/v1""
+ 	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/clientcmd""
+ 	""k8s.io/client-go/tools/leaderelection""",All the changes in this commit are mechanical. Produced by the script in the previous commit.
+6939,"@@ -76,7 +76,7 @@ module Travis
+             true
+           when 'server_error'
+             cmd 'echo -e ""\033[31;1mCould not fetch .travis.yml from GitHub.\033[0m""', assert: false, echo: false
+-            cmd 'travis_terminate 2', assert: false, echo: false
++            raw 'travis_terminate 2', assert: false, echo: false
+             false
+           else
+             true",What's the difference between these 2 versions?
+6940,"@@ -224,7 +224,7 @@ class KMSScannerTest(unittest_utils.ForsetiTestCase):
+         self.scanner.run()
+         crypto_key = self.scanner._retrieve()
+         violations = self.scanner._find_violations(crypto_key)
+-        self.assertEquals(1, len(violations))
++        self.assertEquals(6, len(violations))
+         self.assertEquals(1, mock_output_results.call_count)
+
+ ",@red2k18 Are we sure its correct to only have 1 now?
+6941,"@@ -151,6 +151,7 @@ void AddFragToMol(RWMol *mol, RWMol *frag, Bond::BondType bondOrder,
+         newB->setOwningMol(mol);
+         newB->setBeginAtomIdx(atomIdx1);
+         newB->setEndAtomIdx(atomIdx2);
++        newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1);
+         mol->addBond(newB);
+         delete newB;
+       } else {","@greglandrum interesting, is this related to #3307 by any chance?"
+6942,"@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base
+   private
+
+   def current_user
+-    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    @current_user ||= find_current_user
++  end
++
++  def find_current_user
++    if ENV['FORCE_USER_ID'] && !Rails.env.production?
++      User.find ENV['FORCE_USER_ID']
++    else
++      User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    end
+   end
+
+   def sign_in(user)",Minor: how about moving the trailing `if` to an `elsif` above?
+6943,"@@ -321,6 +321,8 @@ class DBUpgrader {
+             db.execSQL(""UPDATE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS + "" SET content_encoded = NULL"");
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_TAGS + "" TEXT;"");
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_MINIMAL_DURATION_FILTER + "" INTEGER DEFAULT -1"");
+         }
+     }
+ ",That's only executed when users switch from 2.2 to 2.3. Please create a new block with code `2050000` for the next release :) Please also adapt the version number in PodDbAdapter
+6944,"@@ -351,6 +351,16 @@ func (c *client) sendConnect(tlsRequired bool) {
+
+ // Process the info message if we are a route.
+ func (c *client) processRouteInfo(info *Info) {
++	// We may need to update route permissions and will need the account
++	// sublist. Since getting the account requires server lock, do the
++	// lookup now.
++
++	// FIXME(dlc) - Add account scoping.
++	gacc := c.srv.globalAccount()
++	gacc.mu.RLock()
++	sl := gacc.sl
++	gacc.mu.RUnlock()
++
+ 	c.mu.Lock()
+ 	// Connection can be closed at any time (by auth timeout, etc).
+ 	// Does not make sense to continue here if connection is gone.",Safe to reference c.srv without capturing it first under a client lock?
+6945,"@@ -1,3 +1,19 @@
++/*
++Copyright 2018 The Kubernetes Authors.
++
++Licensed under the Apache License, Version 2.0 (the ""License"");
++you may not use this file except in compliance with the License.
++You may obtain a copy of the License at
++
++    http://www.apache.org/licenses/LICENSE-2.0
++
++Unless required by applicable law or agreed to in writing, software
++distributed under the License is distributed on an ""AS IS"" BASIS,
++WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++See the License for the specific language governing permissions and
++limitations under the License.
++*/
++
+ package actuators
+
+ import (","@vincepri blame tells me this was you, any objections to the change?"
+6946,"@@ -0,0 +1,19 @@
++package main
++
++import (
++	""net/http""
++	""time""
++
++	""github.com/yarpc/yarpc-go/crossdock/client""
++	""github.com/yarpc/yarpc-go/crossdock/server""
++)
++
++func main() {
++	// TODO need to be able to wait till all inbounds are finished listening
++	go server.StartServerUnderTest()
++	// TODO maybe sleep?
++	time.Sleep(2 * time.Second)
++
++	http.HandleFunc(""/"", client.TestCaseHandler)
++	http.ListenAndServe("":8080"", nil)
++}",@abhinav here is where i need to be able to block/wait until the server is started
+6947,"@@ -64,6 +64,9 @@ public class MetricsServlet extends HttpServlet {
+
+         /**
+          * Returns the name of the parameter used to specify the jsonp callback, if any.
++         *
++         * @return the name of the parameter used to specify the jsonp callback, or <code>null</code>, if
++         *         no such parameter exists.
+          */
+         protected String getJsonpCallbackParameter() {
+             return null;",It seems to me as an unrelated change. Could you please revert it?
+6948,"@@ -0,0 +1,3 @@
++package iface
++
++type DaemonAPI interface{}","~Why are putting all these APIs in their own ~packages~ files? So many more ~directories~ files, to what end? Why not just have them all be a part of the same API file and all live alongside each other so you can easily see them?~ Edit: nevermind, probably works best in separate files."
+6949,"@@ -32,6 +32,10 @@ import static com.github.javaparser.StaticJavaParser.parseClassOrInterfaceType;
+  */
+ public interface NodeWithExtends<N extends Node> {
+
++    /**
++     * @return All extended types that have been explicitly added.
++     *   Note that this will not include {@code java.lang.Object} unless it is explicitly added (e.g. {@code class X extends Object {}})
++     */
+     NodeList<ClassOrInterfaceType> getExtendedTypes();
+
+     void tryAddImportToParentCompilationUnit(Class<?> clazz);","This likely needs to be double checked -- I recall being convinced at the time of writing this, but now I am less sure"
+6950,"@@ -56,7 +56,7 @@ func main() {
+ 	if csv {
+ 		// produce a csv report
+
+-		fmt.Printf(""Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Exact Match,Similar To,Similarity Confidence,State\n"")
++		fmt.Printf(""Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Similar To,Similarity Confidence,State\n"")
+ 		for _, module := range modules {
+ 			fmt.Printf(""%s,%s,%v"", module.moduleName, module.path, cfg.whitelistedModules[module.moduleName])
+ 			for _, l := range module.licenses {",For a followup - it is better to use acceptlist/denylist. I realize this is a historical artifact of our codebase.
+6951,"@@ -77,6 +77,13 @@ import org.apache.commons.io.FileUtils;
+ import java.util.zip.GZIPInputStream;
+ import java.util.zip.ZipEntry;
+ import java.util.zip.ZipInputStream;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
+
+
+ /**",Looks like glassfish went a bit nuts doing a refactor
+6952,"@@ -47,4 +47,12 @@ describe('dom.visuallyContains', function () {
+ 		assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode));
+ 	});
+
++	it('should return true when element is inline', function () {
++		// result depends on the display property of the element
++		fixture.innerHTML = '<label>' +
++			'My label <input type=""text"" id=""target"">' +
++			'</label>';
++		var target = fixture.querySelector('#target');
++		assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode));
++	});
+ });",Couldn't you use position:absolute or float to move inline elements outside their parent? Through clipping an child element can also be outside it's parent. There are probably some other ways to do it too. So I'm not sure the assumption you're making here is right.
+6953,"@@ -78,7 +78,7 @@ public class ExpireSnapshotsProcedure extends BaseProcedure {
+   @Override
+   public InternalRow[] call(InternalRow args) {
+     Identifier tableIdent = toIdentifier(args.getString(0), PARAMETERS[0].name());
+-    Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.toMillis(args.getLong(1));
++    Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.microsToMillis(args.getLong(1));
+     Integer retainLastNum = args.isNullAt(2) ? null : args.getInt(2);
+
+     return modifyIcebergTable(tableIdent, table -> {",This could be copied into iceberg code to avoid the spark internal dep? We could use a version check to adjust the method used if needed.
+6954,"@@ -254,7 +254,7 @@ static void subprocess_destroy_finish (flux_future_t *f, void *arg)
+     if (flux_future_get (f, NULL) < 0) {
+         flux_t *h = flux_subprocess_aux_get (p, ""flux_t"");
+         flux_log_error (h, ""subprocess_kill: %ju: %s"",
+-                        (uintmax_t) flux_subprocess_pid,
++                        (uintmax_t) flux_subprocess_pid (p),
+                         flux_strerror (errno));
+     }
+     flux_subprocess_destroy (p);",This one had me stumped!
+6955,"@@ -190,10 +190,7 @@ class SettingsAdmin extends Component {
+ 												googlesitekit-settings-module__meta-item
+ 												googlesitekit-settings-module__meta-item--nomargin
+ 											"">
+-												<Optin
+-													id=""opt-in""
+-													name=""optin""
+-												/>
++												<Optin />
+ 											</div>
+ 										</div>
+ 									</div>","Note that this name differs from the name used as default (and thus used now that you removed this). That should be fine, but wanted to flag it."
+6956,"@@ -388,12 +388,17 @@ abstract class AbstractCrudController extends AbstractController implements Crud
+
+     public function autocomplete(AdminContext $context): JsonResponse
+     {
+-        $queryBuilder = $this->createIndexQueryBuilder($context->getSearch(), $context->getEntity(), FieldCollection::new([]), FilterCollection::new());
++        $queryBuilder = $this->createAutocompleteQueryBuilder($context->getSearch(), $context->getEntity());
+         $paginator = $this->get(PaginatorFactory::class)->create($queryBuilder);
+
+         return JsonResponse::fromJsonString($paginator->getResultsAsJson());
+     }
+
++    public function createAutocompleteQueryBuilder(SearchDto $searchDto, EntityDto $entityDto): QueryBuilder
++    {
++        return $this->get(EntityRepository::class)->createQueryBuilder($searchDto, $entityDto, FieldCollection::new([]), FilterCollection::new());
++    }
++
+     public function createIndexQueryBuilder(SearchDto $searchDto, EntityDto $entityDto, FieldCollection $fields, FilterCollection $filters): QueryBuilder
+     {
+         return $this->get(EntityRepository::class)->createQueryBuilder($searchDto, $entityDto, $fields, $filters);",Why public and not protected?
+6957,"@@ -51,7 +51,7 @@
+             locals: {current_org: current_org.id, published: published, scopes: scopes[:all], hide_actions: true}) %>
+         </div>
+       <% end %>
+-      <div id=""organisation-templates"" role=""tabpanel"" class=""tab-pane<%= !current_user.can_super_admin? || current_tab == 'organisation-templates' ? ' active' : '' %>"">
++      <div id=""organisation-templates"" role=""tabpanel"" class=""tab-pane<%= (!current_user.can_super_admin? && !current_tab.present?) || current_tab == 'organisation-templates' ? ' active' : '' %>"">
+         <h2><%= current_user.can_super_admin? ? _('%{org_name} Templates') % { org_name: current_user.org.name } : _('Own Templates') %></h2>
+         <%= paginable_renderise(
+           partial: 'paginable/templates/orgs',",We definitely need to address this duplication after MVP
+6958,"@@ -113,6 +113,12 @@ export default function UserInputKeywords( { slug, max } ) {
+ 	return (
+ 		<Cell lgStart={ 6 } lgSize={ 6 } mdSize={ 8 } smSize={ 4 }>
+ 			<div ref={ keywordsContainer } className=""googlesitekit-user-input__text-options"">
++				<label
++					htmlFor={ `${ slug }-keyword-0` }
++					className=""screen-reader-text""
++				>
++					{ __( 'Enter minimum one (1), maximum three (3) terms', 'google-site-kit' ) }
++				</label>
+ 				{ values.map( ( value, i ) => (
+ 					<div
+ 						key={ i }","This will always generate a label for the first keyword, which means this will be a label linked to no element after the first keyword is entered. This label should be generated inside the `values.map` next to the `<TextField><Input /></TextField>` it is for, because the ID changes based on the index. Also, we have a `VisuallyHidden` component I'd prefer we use over the CSS class. Building as many things out of components is more React-y. Admittedly it's sort of a preference, but it's why we have the `VisuallyHidden` component. So let's use that instead  "
+6959,"@@ -323,6 +323,14 @@ struct roots_desktop *desktop_create(struct roots_server *server,
+
+ 	desktop->server = server;
+ 	desktop->config = config;
++
++	desktop->xcursor_theme = roots_xcursor_theme_create(""default"");
++	if (desktop->xcursor_theme == NULL) {
++		wlr_list_free(desktop->views);
++		free(desktop);
++		return NULL;
++	}
++
+ 	desktop->layout = wlr_output_layout_create();
+ 	desktop->compositor = wlr_compositor_create(server->wl_display,
+ 		server->renderer);","Does it make sense for this to be fatal? Could there be an embedded application that does not have xcursor themes at all? For instance, compositors without a pointer (like a touch-screen kiosk) will never show a cursor. I think I'm ok with this assumption since it simplifies the code and rootston is assumed to have desktop features, but we should always make sure xcursor is not required to be used in the library."
+6960,"@@ -0,0 +1,15 @@
++using Nethermind.Core;
++
++namespace Nethermind.Blockchain.Filters.Topics
++{
++    public abstract class TopicsFilterBase
++    {
++        public abstract bool Accepts(LogEntry entry);
++
++        public abstract bool Accepts(ref LogEntryStructRef entry);
++
++        public abstract bool Matches(Bloom bloom);
++
++        public abstract bool Matches(ref BloomStructRef bloom);
++    }
++}",would rename to TopicsFilter and original one to SequenceTopicsFilter
+6961,"@@ -240,7 +240,7 @@ class MPLPlot(DimensionedPlot):
+
+
+     def update(self, key):
+-        if len(self) == 1 and key == 0 and not self.drawn:
++        if len(self) == 1 and ((key == 0) or (key == self.keys[0])) and not self.drawn:
+             return self.initialize_plot()
+         return self.__getitem__(key)
+ ",Is the idea that ``self.keys[0]`` here normally matches ``init_key``?
+6962,"@@ -262,6 +262,11 @@ class UIAHandler(COMObject):
+ 		eventHandler.queueEvent(NVDAEventName,obj)
+
+ 	def _isUIAWindowHelper(self,hwnd):
++		if hwnd == winUser.getDesktopWindow():
++			# #6301: In Windows 10 build >= 14901,
++			# calling UiaHasServerSideProvider with the desktop window sometimes freezes when bringing up NVDA windows.
++			# It will always return False anyway.
++			return False
+ 		# UIA in NVDA's process freezes in Windows 7 and below
+ 		processID=winUser.getWindowThreadProcessID(hwnd)[0]
+ 		if windll.kernel32.GetCurrentProcessId()==processID:","Can this be clarified to ""Exit early when hwnd is the windows desktop handle, UiaHasServerSideProvider would return false anyway."" ?"
+6963,"@@ -72,11 +72,11 @@ type Task struct {
+ 	Containers []*Container
+ 	// Volumes are the volumes for the task
+ 	Volumes []TaskVolume `json:""volumes""`
+-	// VCPULimit is a task-level limit for compute resources. A value of 1 means that
++	// Cpu is a task-level limit for compute resources. A value of 1 means that
+ 	// the task may access 100% of 1 vCPU on the instance
+-	VCPULimit float64 `json:""CPULimit,omitempty""`
+-	// MemoryLimit is a task-level limit for memory resources in bytes
+-	MemoryLimit int64 `json:""Memory,omitempty""`
++	Cpu float64 `json:""CPULimit,omitempty""`
++	// Memory is a task-level limit for memory resources in bytes
++	Memory int64 `json:""Memory,omitempty""`
+ 	// DesiredStatusUnsafe represents the state where the task should go. Generally,
+ 	// the desired status is informed by the ECS backend as a result of either
+ 	// API calls made to ECS or decisions made by the ECS service scheduler.",I'm okay with leaving VCPULimit and MemoryLimit on our internal model
+6964,"@@ -73,6 +73,10 @@ const (
+ 	defaultWorkers = 4
+ 	// Default rule priority for K8s NetworkPolicy rules.
+ 	defaultRulePriority = -1
++	// TierIndex is used to index ClusterNetworkPolicies by Tier names.
++	TierIndex = ""tier""
++	// maxSupportedTiers is the maximum number of supported Tiers.
++	maxSupportedTiers = 10
+ )
+
+ var (",5 or 10?
+6965,"@@ -27,6 +27,10 @@ internal class MyExporter : ActivityExporter
+     public override Task<ExportResult> ExportAsync(
+         IEnumerable<Activity> batch, CancellationToken cancellationToken)
+     {
++        // Exporter code which can generate further
++        // telemetry should do so inside SuppressInstrumentation
++        // scope. This suppresses telemetry from
++        // exporter's own code to avoid live-loop situation.
+         using var scope = Sdk.SuppressInstrumentation.Begin();
+
+         foreach (var activity in batch)",Should we explain more here?
+6966,"@@ -30,9 +30,10 @@ import (
+ // ec2Svc are the functions from the ec2 service, not the client, this actuator needs.
+ // This should never need to import the ec2 sdk.
+ type ec2Svc interface {
+-	CreateInstance(*clusterv1.Machine) (*ec2svc.Instance, error)
++	CreateInstance(*clusterv1.Machine, *v1alpha1.AWSMachineProviderConfig, *v1alpha1.AWSClusterProviderStatus) (*ec2svc.Instance, error)
+ 	InstanceIfExists(*string) (*ec2svc.Instance, error)
+ 	TerminateInstance(*string) error
++	CreateOrGetMachine(*clusterv1.Machine, *v1alpha1.AWSMachineProviderStatus, *v1alpha1.AWSMachineProviderConfig, *v1alpha1.AWSClusterProviderStatus) (*ec2svc.Instance, error)
+ }
+
+ // codec are the functions off the generated codec that this actuator uses.","I've been struggling with this on my cloud-init integration work as well. In addition to info that is currently stored in the cluster providerstatus, we also need some of the info that is available within the base cluster object as well. I think it would make sense to unify the machine and cluster info needed into a consolidated struct rather than continuing to add additional disparate structs."
+6967,"@@ -17,7 +17,9 @@ import java.util.Map;
+  * UIs without the package prefixes.
+  *
+  * @author Brian Remedios
++ * @deprecated Is internal API
+  */
++@Deprecated
+ public final class ClassUtil {
+
+     public static final Class<?>[] EMPTY_CLASS_ARRAY = new Class[0];",Why not `@InternalApi`?
+6968,"@@ -22,6 +22,11 @@ import datetime
+ import decimal
+ from inspect import getfullargspec, isclass
+
++try:
++    from typing import _GenericAlias  # type: ignore
++except ImportError:
++    from typing import GenericMeta as _GenericAlias  # type: ignore
++
+ import numpy as np
+ import pandas as pd
+ from pandas.api.types import is_datetime64_dtype, is_datetime64tz_dtype",FYI: `GenericMeta` is renamed to `_GenericAlias` in Python3.7.
+6969,"@@ -63,7 +63,7 @@
+                         <% unless phase.sections.all?(&:modifiable?) %>
+                           <%= _(""You may place them before or after the main template sections."") %>
+                         <% end %>
+-                      <% else %>
++                      <% elsif template.latest? %>
+                         <%= link_to _('Re-order sections'),
+                             org_admin_template_phase_versions_path(phase.template, phase),
+                             method: ""post"",","So this hides the link to re-order sections on Historic Templates? Good catch, Just checked on DMPonline and hitting that throws a 404"
+6970,"@@ -69,7 +69,7 @@ module RSpec
+   # same process.
+   def self.clear_examples
+     world.reset
+-    configuration.reporter.reset
++    configuration.reset_reporter
+     configuration.start_time = ::RSpec::Core::Time.now
+     configuration.reset_filters
+   end","Is `Reporter#reset` no longer used? If so, can we remove it?"
+6971,"@@ -188,7 +188,7 @@ public final class EthHash {
+     out.writeLongScalar(header.getTimestamp());
+     out.writeBytes(header.getExtraData());
+     if (header.getBaseFee().isPresent()) {
+-      out.writeLongScalar(header.getBaseFee().get());
++      out.writeUInt256Scalar(header.getBaseFee().get());
+     }
+     out.endList();
+     return Bytes32.wrap(",same concern here about difference in the write scalar implementation. I am not sure if this could present a consensus problem or not
+6972,"@@ -0,0 +1,7 @@
++using UIKit;
++using MvvmCross.Core.ViewModels;
++
++namespace MvvmCross.tvOS.Views
++{
++    public interface IMvxSplitViewController : IMvxTvosView { }
++}",Can we remove this file?
+6973,"@@ -799,7 +799,7 @@ func (c *Operator) sync(ctx context.Context, key string) error {
+
+ 	if ok && sErr.ErrStatus.Code == 422 && sErr.ErrStatus.Reason == metav1.StatusReasonInvalid {
+ 		c.metrics.StsDeleteCreateCounter().Inc()
+-		level.Info(c.logger).Log(""msg"", ""resolving illegal update of Alertmanager StatefulSet"", ""details"", sErr.ErrStatus.Details)
++		level.Info(c.logger).Log(""msg"", ""recreating AlertManager StatefulSet because the update operation wasn't possible"", ""reason"", sErr.ErrStatus.Details.Causes[0].Message)
+ 		propagationPolicy := metav1.DeletePropagationForeground
+ 		if err := ssetClient.Delete(ctx, sset.GetName(), metav1.DeleteOptions{PropagationPolicy: &propagationPolicy}); err != nil {
+ 			return errors.Wrap(err, ""failed to delete StatefulSet to avoid forbidden action"")",Why listing only first error reason (`ErrStatus.Details.Causes[0].Message`)?
+6974,"@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+
++  /**
++   * If the compaction should use the sequence number of the snapshot at compaction start time for new data files,
++   * instead of using the sequence number of the newly produced snapshot.
++   * <p>
++   * This avoids commit conflicts with updates that add newer equality deletes at a higher sequence number.
++   * <p>
++   * Defaults to true.
++   */
++  String USE_STARTING_SEQUENCE_NUMBER = ""use-starting-sequence-number"";
++  boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining","Now that this is true, do we have to ignore it with V1 Tables?"
+6975,"@@ -87,6 +87,12 @@ Blockly.Css.inject = function(hasCss, pathToMedia) {
+   // Strip off any trailing slash (either Unix or Windows).
+   Blockly.Css.mediaPath_ = pathToMedia.replace(/[\\\/]$/, '');
+   text = text.replace(/<<<PATH>>>/g, Blockly.Css.mediaPath_);
++  // Dynamically replace colours in the CSS text, in case they have
++  // been set at run-time injection.
++  for (var colourProperty in Blockly.Colours) {
++    if (!Blockly.Colours.hasOwnProperty(colourProperty)) continue;
++    text = text.replace('$colour_' + colourProperty, Blockly.Colours[colourProperty]);
++  }
+   // Inject CSS tag.
+   var cssNode = document.createElement('style');
+   document.head.appendChild(cssNode);",prefer if (condition) { stuff; } to if !(condition) { continue; } stuff
+6976,"@@ -1,11 +1,8 @@
+-<h1><%= h(@title) %></h1>
+-
+-<% content_for :head do %>
+-<%= auto_discovery_link_tag :atom, :action => 'georss', :display_name => @display_name, :tag => @tag %>
+-<% end %>
+-
+-<p>
+-  <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %>
++<% content_for :heading do %>
++  <h1><%= h(@title) %></h1>
++  <span><%= raw(@description) %></span>
++  |
++    <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %>
+   | <%= link_to t('trace.trace_header.upload_trace'), :action => 'create' %>
+   <% if @tag %>
+     | <%= link_to t('trace.trace_header.see_all_traces'), :controller => 'trace', :action => 'list', :display_name => nil, :tag => nil, :page => nil %>",Should this section not be converted to a secondary action list?
+6977,"@@ -225,8 +225,17 @@ class CommandDispatcher:
+             count: The tab index to close, or None
+         """"""
+         tab = self._cntwidget(count)
++        result = True
+         if tab is None:
+             return
++
++        if tab.pin is True:
++            result = message.ask(""Are you sure you want to close a pinned tab?"",
++                    mode=usertypes.PromptMode.yesno, default=False)
++
++        if result is False or result is None:
++            return
++
+         tabbar = self._tabbed_browser.tabBar()
+         selection_override = self._get_selection_override(left, right,
+                                                           opposite)","This askes a blocking question, which means a local Qt eventloop will be running. While this is unavoidable sometimes, the async functions should be used whenever possible (`message.confirm_async` in this case). This means: - Split everything after this question in a separate private method (you can probably just call it `_tab_close`) - If the tab is not pinned, just call `_tab_close` directly - If it is pinned, call `message.confirm_async` with `yes_action=self._tab_close`"
+6978,"@@ -28,7 +28,7 @@ define([""jQuery"", ""loading"", ""libraryMenu"", ""fnchecked""], function($, loading, l
+             IsHidden: !1
+         })).then(function(folders) {
+             loadDeleteFolders(page, user, folders.Items)
+-        }), user.Policy.IsDisabled ? $("".disabledUserBanner"", page).show() : $("".disabledUserBanner"", page).hide(), ""Guest"" == user.ConnectLinkType ? ($(""#fldConnectInfo"", page).hide(), $(""#txtUserName"", page).prop(""disabled"", ""disabled"")) : ($(""#txtUserName"", page).prop(""disabled"", """").removeAttr(""disabled""), $(""#fldConnectInfo"", page).show()), $("".lnkEditUserPreferences"", page).attr(""href"", ""mypreferencesmenu.html?userId="" + user.Id), libraryMenu.setTitle(user.Name), page.querySelector("".username"").innerHTML = user.Name, $(""#txtUserName"", page).val(user.Name), $(""#chkIsAdmin"", page).checked(user.Policy.IsAdministrator), $(""#chkDisabled"", page).checked(user.Policy.IsDisabled), $(""#chkIsHidden"", page).checked(user.Policy.IsHidden), $(""#chkRemoteControlSharedDevices"", page).checked(user.Policy.EnableSharedDeviceControl), $(""#chkEnableRemoteControlOtherUsers"", page).checked(user.Policy.EnableRemoteControlOfOtherUsers), $(""#chkEnableDownloading"", page).checked(user.Policy.EnableContentDownloading), $(""#chkManageLiveTv"", page).checked(user.Policy.EnableLiveTvManagement), $(""#chkEnableLiveTvAccess"", page).checked(user.Policy.EnableLiveTvAccess), $(""#chkEnableMediaPlayback"", page).checked(user.Policy.EnableMediaPlayback), $(""#chkEnableAudioPlaybackTranscoding"", page).checked(user.Policy.EnableAudioPlaybackTranscoding), $(""#chkEnableVideoPlaybackTranscoding"", page).checked(user.Policy.EnableVideoPlaybackTranscoding), $(""#chkEnableVideoPlaybackRemuxing"", page).checked(user.Policy.EnablePlaybackRemuxing), $(""#chkRemoteAccess"", page).checked(null == user.Policy.EnableRemoteAccess || user.Policy.EnableRemoteAccess), $(""#chkEnableSyncTranscoding"", page).checked(user.Policy.EnableSyncTranscoding), $(""#chkEnableConversion"", page).checked(user.Policy.EnableMediaConversion || !1), $(""#chkEnableSharing"", page).checked(user.Policy.EnablePublicSharing), $(""#txtRemoteClientBitrateLimit"", page).val(user.Policy.RemoteClientBitrateLimit / 1e6 || """"), loading.hide()
++        }), user.Policy.IsDisabled ? $("".disabledUserBanner"", page).show() : $("".disabledUserBanner"", page).hide(), ""Guest"" == user.ConnectLinkType ? ($(""#fldConnectInfo"", page).hide(), $(""#txtUserName"", page).prop(""disabled"", ""disabled"")) : ($(""#txtUserName"", page).prop(""disabled"", """").removeAttr(""disabled""), $(""#fldConnectInfo"", page).show()), $("".lnkEditUserPreferences"", page).attr(""href"", ""mypreferencesmenu.html?userId="" + user.Id), libraryMenu.setTitle(user.Name), page.querySelector("".username"").innerHTML = user.Name, $(""#txtUserName"", page).val(user.Name), $(""#chkIsAdmin"", page).checked(user.Policy.IsAdministrator), $(""#chkDisabled"", page).checked(user.Policy.IsDisabled), $(""#chkIsHidden"", page).checked(user.Policy.IsHidden), $(""#chkRemoteControlSharedDevices"", page).checked(user.Policy.EnableSharedDeviceControl), $(""#chkEnableRemoteControlOtherUsers"", page).checked(user.Policy.EnableRemoteControlOfOtherUsers), $(""#chkEnableDownloading"", page).checked(user.Policy.EnableContentDownloading), $(""#chkManageLiveTv"", page).checked(user.Policy.EnableLiveTvManagement), $(""#chkEnableLiveTvAccess"", page).checked(user.Policy.EnableLiveTvAccess), $(""#chkEnableMediaPlayback"", page).checked(user.Policy.EnableMediaPlayback), $(""#chkEnableAudioPlaybackTranscoding"", page).checked(user.Policy.EnableAudioPlaybackTranscoding), $(""#chkEnableVideoPlaybackTranscoding"", page).checked(user.Policy.EnableVideoPlaybackTranscoding), $(""#chkEnableVideoPlaybackRemuxing"", page).checked(user.Policy.EnablePlaybackRemuxing), $(""#chkRemoteAccess"", page).checked(null == user.Policy.EnableRemoteAccess || user.Policy.EnableRemoteAccess), $(""#chkEnableSyncTranscoding"", page).checked(user.Policy.EnableSyncTranscoding), $(""#chkEnableConversion"", page).checked(user.Policy.EnableMediaConversion || !1), $(""#chkEnableSharing"", page).checked(user.Policy.EnablePublicSharing), $(""#txtRemoteClientBitrateLimit"", page).val(user.Policy.RemoteClientBitrateLimit / 1e6 || """"), $(""#txtLoginAttemptsBeforeLockout"", page).val(user.Policy.LoginAttemptsBeforeLockout || ""0""), loading.hide()
+     }
+
+     function onSaveComplete(page, user) {",Can we deuglify this?
+6979,"@@ -177,7 +177,7 @@ public interface Option<T> extends Value<T>, Serializable {
+      */
+     default <R> Option<R> collect(PartialFunction<? super T, ? extends R> partialFunction) {
+         Objects.requireNonNull(partialFunction, ""partialFunction is null"");
+-        return filter(partialFunction::isDefinedAt).map(partialFunction::apply);
++        return flatMap(partialFunction.lift()::apply);
+     }
+
+     /**","@skestle Just recognized that the `::apply` is not necessary. Does it compile if you leave it away? Could you please check that, I'm on vacation and have no IDE at hand... Thx!"
+6980,"@@ -366,7 +366,8 @@ public class TestMergeAppend extends TableTestBase {
+         1, base.currentSnapshot().manifests().size());
+     ManifestFile initialManifest = base.currentSnapshot().manifests().get(0);
+
+-    // build the new spec using the table's schema, which uses fresh IDs
++    // build the new spec using the table's sche
++    // ma, which uses fresh IDs
+     PartitionSpec newSpec = PartitionSpec.builderFor(base.schema())
+         .bucket(""data"", 16)
+         .bucket(""id"", 4)",Looks like this is an unnecessary change.
+6981,"@@ -290,7 +290,7 @@ class CrawlerTest(CrawlerBase):
+             'disk': {'resource': 3},
+             'firewall': {'resource': 3},
+             'folder': {'iam_policy': 2, 'resource': 2},
+-            'forwardingrule': {'resource': 1},
++            'forwardingrule': {'resource': 2},
+             'instance': {'resource': 3},
+             'instancegroup': {'resource': 2},
+             'instancegroupmanager': {'resource': 2},",This one won't change as the resource is not included in the project getting tested with the composite root.
+6982,"@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
++	__u8 nat_lvl1_drop = 0;
+
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.","We have `stdbool` imported, might as well use that for clarity."
+6983,"@@ -30,8 +30,8 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+                 Assert.True(spans.Count > 0, ""expected at least one span"");
+                 foreach (var span in spans)
+                 {
+-                    Assert.Equal(SqlServerIntegration.OperationName, span.Name);
+-                    Assert.Equal($""Samples.SqlServer-{SqlServerIntegration.ServiceName}"", span.Service);
++                    Assert.Equal(""sql-server.query"", span.Name);
++                    Assert.Equal($""Samples.SqlServer-sql-server"", span.Service);
+                     Assert.Equal(SpanTypes.Sql, span.Type);
+                 }
+             }",Why do we not also have integration tests for postgres?
+6984,"@@ -205,7 +205,7 @@ describe('Db', function() {
+   /**
+    * An example showing how to force a reindex of a collection.
+    */
+-  it('shouldCorrectlyForceReindexOnCollection', {
++  it.skip('shouldCorrectlyForceReindexOnCollection', {
+     metadata: {
+       requires: { topology: ['single'] }
+     },","I think its safe to remove this if we're removing `reIndex` outright. The description shows us that the test is ""An example showing how to force a reindex of a collection"""
+6985,"@@ -43,6 +43,7 @@ const (
+ 	EEXIST      Errno = 0x11
+ 	EINTR       Errno = 0x4
+ 	ENOTDIR     Errno = 0x14
++	EINVAL      Errno = 22
+ 	EMFILE      Errno = 0x18
+ 	EAGAIN      Errno = 0x23
+ 	ETIMEDOUT   Errno = 0x3c",Can you make this hexadecimal to match the other constants?
+6986,"@@ -209,12 +209,5 @@ module Bolt
+         Bolt::Logger.warn(""missing_project_name"", message)
+       end
+     end
+-
+-    def check_deprecated_file
+-      if (@path + 'project.yaml').file?
+-        msg = ""Project configuration file 'project.yaml' is deprecated; use 'bolt-project.yaml' instead.""
+-        Bolt::Logger.warn(""project_yaml"", msg)
+-      end
+-    end
+   end
+ end",Can this get moved to `Bolt::Project#validate`?
+6987,"@@ -426,7 +426,15 @@ public interface List<T> extends Seq<T>, Stack<T> {
+     @Override
+     default Tuple2<List<T>, List<T>> partition(Predicate<? super T> predicate) {
+         Objects.requireNonNull(predicate, ""predicate is null"");
+-        return Tuple.of(filter(predicate), filter(predicate.negate()));
++        List<T> left = nil(), right = nil();
++        for (T t : this) {
++            if (predicate.test(t)) {
++                left = left.prepend(t);
++            } else {
++                right = right.prepend(t);
++            }
++        }
++        return Tuple.of(left.reverse(), right.reverse());
+     }
+
+     @Override","I'm pretty sure it doesn't harm, but don't we have a second pass here with the reverse() operation?"
+6988,"@@ -24,6 +24,7 @@ public interface CapabilityType {
+   String PLATFORM = ""platform"";
+   String SUPPORTS_JAVASCRIPT = ""javascriptEnabled"";
+   String TAKES_SCREENSHOT = ""takesScreenshot"";
++  String TAKES_HEAP_SNAPSHOT = ""takesHeapSnapshot"";
+   String VERSION = ""version"";
+   String SUPPORTS_ALERTS = ""handlesAlerts"";
+   String SUPPORTS_SQL_DATABASE = ""databaseEnabled"";",This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot
+6989,"@@ -144,9 +144,9 @@ trainer::execution_context_key_pair_t trainer::check_and_build_execution_context
+     if(dynamic_cast<observer_ptr<sgd_training_algorithm>>(&alg) != nullptr) {
+       /// @todo BVE FIXME Figure out how to get a good mini-batch size
+       /// in here
+-      context = make_unique<sgd_execution_context>(this, m_comm, mode, model->get_max_mini_batch_size());
++      context = make_unique<sgd_execution_context>(this, &alg, m_comm, mode, model->get_max_mini_batch_size());
+     }else {
+-      context = make_unique<execution_context>(this, m_comm, mode);
++      context = make_unique<execution_context>(this, &alg, m_comm, mode);
+     }
+     m_model_execution_context.emplace(key,std::move(context));
+   }",This shouldn't work with pointers -- prefer references unless you can meaningfully pass `nullptr`. The address-of operator here is clunky at best.
+6990,"@@ -140,7 +140,8 @@ func TestBuild(t *testing.T) {
+ 		for _, t := range tests {
+ 			switch t {
+ 			case ""atomic.go"":
+-				// Not supported due to unaligned atomic accesses.
++				// Requires GCC 11.2.0 or above for interface comparison.
++				// https://github.com/gcc-mirror/gcc/commit/f30dd607669212de135dec1f1d8a93b8954c327c
+
+ 			case ""reflect.go"":
+ 				// Reflect tests do not work due to type code issues.",Sidenote: some day we'll drop the avr-gcc and avr-libc dependencies so that this case becomes supported.
+6991,"@@ -619,6 +619,6 @@ public class TestFieldCacheVsDocValues extends LuceneTestCase {
+
+   protected boolean codecAcceptsHugeBinaryValues(String field) {
+     String name = TestUtil.getDocValuesFormat(field);
+-    return !(name.equals(""Memory"")); // Direct has a different type of limit
++    return true;
+   }
+ }",do we still need this method?
+6992,"@@ -618,10 +618,14 @@ RETDesc *GenericUpdate::createOldAndNewCorrelationNames(BindWA *bindWA, NABoolea
+     rd = new (bindWA->wHeap()) RETDesc(bindWA);
+   }
+
++  /*  if ((getOperatorType() != REL_UNARY_INSERT) ||
++      getUpdateCKorUniqueIndexKey() ||
++      ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->isMerge()) ||
++      ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))  */
+   if ((getOperatorType() != REL_UNARY_INSERT) ||
+       getUpdateCKorUniqueIndexKey() ||
+       ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->isMerge()) ||
+-      ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))
++      ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->xformedEffUpsert()))
+   {
+     // DELETE or UPDATE --
+     // Now merge the old/target/before valueid's (the Scan child RETDesc)",It's better to not leave this old code here... it just clutters things up and makes reading the code more confusing. We can always recover the old code from the repository if needed.
+6993,"@@ -21,6 +21,8 @@ import com.google.common.base.Charsets;
+ import com.google.common.io.ByteStreams;
+ import com.google.common.net.MediaType;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.apache.http.Header;
+ import org.apache.http.HttpEntity;
+ import org.apache.http.HttpHost;","Again, you don't want to depend on glassfish."
+6994,"@@ -1,6 +1,6 @@
+ FactoryGirl.define do
+   factory :post do
+-    association :account
++    association :account, factory: :account
+     association :topic
+     body { Faker::Lorem.sentence }
+     sequence :created_at do |n|",This shouldn't be required. What was going on here?
+6995,"@@ -80,6 +80,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) *tls.Config {
+ 	}
+
+ 	return &tls.Config{
++		MinVersion: tls.VersionTLS12,
+ 		GetConfigForClient: func(hello *tls.ClientHelloInfo) (*tls.Config, error) {
+ 			// filter policies by SNI first, if possible, to speed things up
+ 			// when there may be lots of policies",Why add this here?
+6996,"@@ -141,15 +141,15 @@ namespace AutoRest.CSharp.Model
+             {
+                 if (ReturnType.Body != null && ReturnType.Headers != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)},{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)},{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
+                 }
+                 if (ReturnType.Body != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)}>"";
+                 }
+                 if (ReturnType.Headers != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationHeaderResponse<{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationHeaderResponse<{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)}>"";
+                 }
+
+                 return ""Microsoft.Rest.HttpOperationResponse"";",nullability does not apply to headers type (that is always an object)
+6997,"@@ -166,7 +166,7 @@ static fpga_result map_mmio_region(fpga_handle handle, uint32_t mmio_num)
+ 	wsid = wsid_gen();
+ 	if (!wsid_add(&_handle->mmio_root,
+ 		      wsid,
+-		      (uint64_t) NULL,
++		      (uint64_t) addr,
+ 		      (uint64_t) NULL,
+ 		      size,
+ 		      (uint64_t) addr,","Do we also need to add the iova, or is that done somewhere else?"
+6998,"@@ -19,9 +19,7 @@ package selector
+
+ import ""github.com/mysteriumnetwork/node/identity""
+
+-// Handler allows selecting identity to be used
++// Handler interface
+ type Handler interface {
+-	UseExisting(address, passphrase string) (identity.Identity, error)
+-	UseLast(passphrase string) (identity.Identity, error)
+-	UseNew(passphrase string) (identity.Identity, error)
++	UseOrCreate(address, passphrase string) (identity.Identity, error)
+ }",why change this?
+6999,"@@ -173,7 +173,7 @@ void h2o_get_timestamp(h2o_context_t *ctx, h2o_mem_pool_t *pool, h2o_timestamp_t
+             if (ctx->_timestamp_cache.value != NULL)
+                 h2o_mem_release_shared(ctx->_timestamp_cache.value);
+             ctx->_timestamp_cache.value = h2o_mem_alloc_shared(NULL, sizeof(h2o_timestamp_string_t), NULL);
+-            gmtime_r(&ctx->_timestamp_cache.tv_at.tv_sec, &gmt);
++            gmtime_r((time_t *)&ctx->_timestamp_cache.tv_at.tv_sec, &gmt);
+             h2o_time2str_rfc1123(ctx->_timestamp_cache.value->rfc1123, &gmt);
+             h2o_time2str_log(ctx->_timestamp_cache.value->log, ctx->_timestamp_cache.tv_at.tv_sec);
+         }","If there is no guarantee that tv_sec is of type `time_t`, IMO you should copy the value instead of enforcing a pointer typecast."
+7000,"@@ -83,9 +83,12 @@ func (opts *InitAppOpts) Validate() error {
+ 		}
+ 	}
+ 	if opts.DockerfilePath != """" {
+-		if _, err := listDockerfiles(opts.fs, opts.DockerfilePath); err != nil {
++		if _, err := opts.fs.Stat(opts.DockerfilePath); err != nil {
+ 			return err
+ 		}
++		if !strings.HasSuffix(opts.DockerfilePath, ""/Dockerfile"") {
++			return fmt.Errorf(""a valid Dockerfile path is required"")
++		}
+ 	}
+ 	if opts.ProjectName() == """" {
+ 		return errNoProjectInWorkspace",Should we validate the suffix before going to the filesystem?
+7001,"@@ -23,8 +23,12 @@ var (
+ 	plugin   = ""local""
+ 	// 1 week
+ 	updateInterval = time.Hour * 24 * 7
++	siteName       string
++	serviceType    string
+ )
+
++const netName = ""ddev_default""
++
+ // RootCmd represents the base command when called without any subcommands
+ var RootCmd = &cobra.Command{
+ 	Use:   ""ddev"",",It feels like we should be working to reduce/eliminate our global vars. I'm not sure it adds much here. Any objection to just removing it?
+7002,"@@ -0,0 +1,13 @@
++class AddScheduledReports < ActiveRecord::Migration
++  def change
++    create_table :scheduled_reports do |t|
++      t.string :name, null: false
++      t.string :frequency, null: false
++      t.integer :user_id, null: false
++      t.integer :report_id, null: false
++      t.timestamps
++    end
++    add_foreign_key :scheduled_reports, :users
++    add_foreign_key :scheduled_reports, :reports
++  end
++end",did you consider using AR enums for this? would give us all the boolean methods (`weekly?` etc) for free
+7003,"@@ -378,6 +378,8 @@ class Engine(object):
+         :param filename: file basename to find
+         :type filename: str
+         """"""
++        if not filename:
++            return None
+         filename = os.path.expanduser(filename)
+         if os.path.exists(filename):
+             return filename","This may change """" into None. Better return filename."
+7004,"@@ -126,4 +126,11 @@ type Resources struct {
+
+ 	// CpuWeight sets a proportional bandwidth limit.
+ 	CpuWeight uint64 `json:""cpu_weight""`
++
++	// SkipDevices allows to skip configuring device permissions.
++	// Used by e.g. kubelet while creating a parent cgroup (kubepods)
++	// common for many containers.
++	//
++	// NOTE it is impossible to start a container which has this flag set.
++	SkipDevices bool `json:""skip_devices""`
+ }",:+1: That does resolve my security concerns about this feature.
+7005,"@@ -61,8 +61,13 @@ def get_if(iff, cmd):
+     return ifreq
+
+
++def get_if_raw_hwaddr(iff):
++    from scapy.arch import SIOCGIFHWADDR
++    return struct.unpack(""16xh6s8x"", get_if(iff, SIOCGIFHWADDR))
++
+ # SOCKET UTILS
+
++
+ def _select_nonblock(sockets, remain=None):
+     """"""This function is called during sendrecv() routine to select
+     the available sockets.",Could you add a docstring?
+7006,"@@ -92,7 +92,7 @@ func TestClientDisableIMDS(t *testing.T) {
+ 	svc := ec2metadata.New(unit.Session, &aws.Config{
+ 		LogLevel: aws.LogLevel(aws.LogDebugWithHTTPBody),
+ 	})
+-	resp, err := svc.Region()
++	resp, err := svc.GetUserData()
+ 	if err == nil {
+ 		t.Fatalf(""expect error, got none"")
+ 	}",Shouldn't this still be `Region()`?
+7007,"@@ -89,6 +89,7 @@ class CompletionView(QTreeView):
+     # https://github.com/The-Compiler/qutebrowser/issues/117
+
+     resize_completion = pyqtSignal()
++    connected = None
+
+     def __init__(self, win_id, parent=None):
+         super().__init__(parent)","This shouldn't be here but `self.connected = None` in `__init__` instead, otherwise that'd be an attribute which is set this way in _every_ instance of that class (i.e. a class rather than an instance variable). I'd also say let's make it ""private"" (i.e. `_connected`) and please add a quick note about what it is to the docstring of the class."
+7008,"@@ -24,7 +24,7 @@ class ChromiumService(service.Service):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None, start_error_message=None):
++                 log_path=None, env=None, start_error_message=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ",This would be better served as a method/property that is set when people don't want to a window.
+7009,"@@ -33,7 +33,7 @@ public class PageStreamingTransformer {
+   public List<PageStreamingDescriptorView> generateDescriptors(SurfaceTransformerContext context) {
+     List<PageStreamingDescriptorView> descriptors = new ArrayList<>();
+
+-    for (Method method : context.getInterface().getMethods()) {
++    for (Method method : context.getNonStreamingMethods()) {
+       MethodConfig methodConfig = context.getMethodConfig(method);
+       if (!methodConfig.isPageStreaming()) {
+         continue;","I was dubious about putting getNonStreamingMethods in the context, but after some thought, I have decided to embrace the approach. In this particular case, the loop is supposed to be over page streaming methods. So, could you add a getPageStreamingMethods() method in the context, use it here, and remove the isPageStreaming() check below?"
+7010,"@@ -600,7 +600,8 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister, HavingInstall
+         self.__add_result_listeners(jmx)
+         if not is_jmx_generated:
+             self.__force_tran_parent_sample(jmx)
+-            if self.settings.get('version', self.JMETER_VER) >= '3.2':
++            version = str(self.settings.get('version', self.JMETER_VER)).split(""."")
++            if tuple(version) >= ('3', '2'):
+                 self.__force_hc4_cookie_handler(jmx)
+         self.__fill_empty_delimiters(jmx)
+ ",LooseVersion class can help here
+7011,"@@ -220,7 +220,9 @@ void HDF5Common::AddVar(IO &io, std::string const &name, hid_t datasetId)
+                 shape[i] = dims[i];
+         }
+
+-        auto &foo = io.DefineVariable<T>(name, shape);
++        Dims zeros(shape.size(), 0);
++
++        auto &foo = io.DefineVariable<T>(name, shape, zeros, shape);
+         // default was set to 0 while m_AvailabelStepsStart is 1.
+         // correcting
+         if (0 == foo.m_AvailableStepsCount)","`const Dims zeros(shape.size(), 0);`"
+7012,"@@ -135,8 +135,8 @@ module RSpec::Core
+           options[:color] = o
+         end
+
+-        parser.on('-p', '--profile', 'Enable profiling of examples and list 10 slowest examples.') do |o|
+-          options[:profile_examples] = o
++        parser.on('-p', '--profile [COUNT]', 'Enable profiling of examples and list 10 slowest examples.') do |count|
++          options[:profile_examples] = count.nil? ? true : count.to_i
+         end
+
+         parser.separator <<-FILTERING",Would be good for this not to say `10` anymore...
+7013,"@@ -174,7 +174,7 @@ class AdSenseDashboardWidget extends Component {
+ 								</div>
+ 							}
+ 							{ ! receivingData && (
+-								error ? getDataErrorComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), true, true, true )
++								error ? getDataErrorComponent( 'adsense', _x( 'AdSense', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), true, true, true )
+ 							) }
+ 							<div className={ classnames(
+ 								'mdc-layout-grid__cell',","See above, we don't need to pass the module name here."
+7014,"@@ -4,8 +4,10 @@ declare(strict_types=1);
+
+ namespace Shopsys\FrontendApiBundle\Controller;
+
++use BadMethodCallException;
+ use Overblog\GraphQLBundle\Controller\GraphController;
+ use Shopsys\FrontendApiBundle\Component\Domain\EnabledOnDomainChecker;
++use Shopsys\FrontendApiBundle\Model\GraphqlConfigurator;
+ use Symfony\Component\HttpFoundation\JsonResponse;
+ use Symfony\Component\HttpFoundation\Request;
+ use Symfony\Component\HttpFoundation\Response;","This is random line :-) overridden String type by custom trimmed - please change that commit message to something like ""introduced custom String type with automatic trimming"""
+7015,"@@ -104,6 +104,19 @@ module.exports = function(realmConstructor) {
+
+         setConstructorOnPrototype(realmConstructor.Sync.User);
+         setConstructorOnPrototype(realmConstructor.Sync.Session);
++
++        if (realmConstructor.Sync._setFeatureToken) {
++            realmConstructor.Sync.setFeatureToken = function(featureToken) {
++                if (typeof featureToken !== 'string' || !featureToken instanceof String) {
++                    throw new Error(""featureToken should be a string"");
++                }
++
++                realmConstructor.Sync._setFeatureToken(featureToken.trim());
++            }
++
++            //enable depreciated setAccessToken
++            realmConstructor.Sync.setAccessToken = realmConstructor.Sync.setFeatureToken;
++        }
+     }
+
+     // TODO: Remove this now useless object.","My personal taste: ""depreciated"" -> ""deprecated"""
+7016,"@@ -58,6 +58,8 @@ var (
+ 		""destinationPodName"",
+ 		""destinationPodNamespace"",
+ 		""destinationNodeName"",
++		""destinationClusterIP"",
++		""destinationServiceName"",
+ 	}
+ )
+ ",this includes the port as well right? should the name be `destinationServicePortName`?
+7017,"@@ -23,13 +23,15 @@ import os
+ import json
+ import logging
+ import socket
+-import time
+ import base64
+
+ from urllib.parse import urljoin, urlencode, urlparse
+ from urllib.request import urlopen, Request
+ from urllib.error import URLError
+
++from tenacity import retry
++from tenacity import wait_fixed
++from tenacity import stop_after_attempt
+ from luigi import configuration
+ from luigi.scheduler import RPC_METHODS
+ ",We can import all of them in one line.
+7018,"@@ -1656,7 +1656,7 @@ interface StreamModule {
+
+         @Override
+         public Stream<T> appendAll(Iterable<? extends T> elements) {
+-            Objects.requireNonNull(queue, ""elements is null"");
++            Objects.requireNonNull(elements, ""elements is null"");
+             return isEmpty() ? Stream.ofAll(queue) : new AppendElements<>(head, queue.appendAll(elements), tail);
+         }
+ ","this was wrong, the rest were just inconsistent :)"
+7019,"@@ -23,7 +23,7 @@
+     </div>
+   </div>
+
+-  <div class=""row past-pr"">
++  <div id=""proposals-completed"" class=""row past-pr"">
+     <div class=""col-md-12"">
+       <h3>Recently Completed Purchase Requests</h3>
+     <%- if @approved_data.rows.any? %>",I gave them the EXACT SAME NAMES in my branch :)
+7020,"@@ -96,6 +96,16 @@ func (*RunCLI) Run(args []string) int {
+ 		return 1
+ 	}
+
++	// Create uds dir and parents if not exists
++	dir := filepath.Dir(c.BindAddress.String())
++	if _, statErr := os.Stat(dir); os.IsNotExist(statErr) {
++		c.Log.WithField(""dir"", dir).Infof(""Creating spire agent UDS directory"")
++		if err := os.MkdirAll(dir, 0755); err != nil {
++			fmt.Fprintln(os.Stderr, err)
++			return 1
++		}
++	}
++
+ 	// Set umask before starting up the agent
+ 	cli.SetUmask(c.Log)
+ ",What would you think stat'ing the directory first before doing the log+mkdirall and only proceeding if the directory does not exist? The logging might be less confusing (I'd be wondering why it was logging that it was creating the directory when I knew it already existed).
+7021,"@@ -339,7 +339,7 @@ namespace Datadog.Trace.Agent
+             }
+
+             // Add the current keep rate to the root span
+-            var rootSpan = trace.Array[trace.Offset].Context.TraceContext?.RootSpan;
++            var rootSpan = trace.Array[trace.Offset].InternalContext.TraceContext?.RootSpan;
+             if (rootSpan is not null)
+             {
+                 var currentKeepRate = _traceKeepRateCalculator.GetKeepRate();","Sorry about the confusion, I'm trying to address that in the PR follow-up. If we ever have `Span` objects, then accessing their properties is going to be safe. The only question remaining is ""What is the runtime type for Scope.Span?"" and we just have to account for it when it is `Datadog.Trace.Span` and when it is not"
+7022,"@@ -9,6 +9,12 @@ import static com.github.javaparser.JavaParser.*;
+ import static com.github.javaparser.utils.Utils.EOL;
+ import static org.junit.Assert.*;
+
++import java.io.FileOutputStream;
++import java.io.IOException;
++import java.io.OutputStreamWriter;
++import java.io.Writer;
++import java.io.BufferedWriter;
++
+ public class JsonPrinterTest {
+     @Test
+     public void testWithType() {",I was using this imports for writing the results to file to more easily check that it was valid JSON. You can probably remove these `java.io` imports.
+7023,"@@ -21,6 +21,11 @@ type pid struct {
+ 	Pid int `json:""Pid""`
+ }
+
++type logentry struct {
++	Msg   string
++	Level string
++}
++
+ func TestNsenterValidPaths(t *testing.T) {
+ 	args := []string{""nsenter-exec""}
+ 	parent, child, err := newPipe()",You should probably include a `json:...` annotation here.
+7024,"@@ -38,6 +38,7 @@ import (
+
+ const (
+ 	ecsMaxReasonLength    = 255
++	ecsMaxRuntimeIDLength = 255
+ 	pollEndpointCacheSize = 1
+ 	pollEndpointCacheTTL  = 20 * time.Minute
+ 	roundtripTimeout      = 5 * time.Second",can container ID > 255 chars? why are we doing this check?
+7025,"@@ -111,6 +111,7 @@ return [
+     'prohibited'           => 'This field is prohibited.',
+     'prohibited_if'        => 'This field is prohibited when :other is :value.',
+     'prohibited_unless'    => 'This field is prohibited unless :other is in :values.',
++    'prohibits'            => 'This field field prohibits :other from being present.',
+     'same'                 => 'The value of this field must match the one from :other.',
+     'size'                 => [
+         'numeric' => 'The value must be :size.',","*""This **field field** prohibits :other from being present.""*, **field** word repeated is right?"
+7026,"@@ -36,6 +36,7 @@ import (
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/flowexporter/flowrecords""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/interfacestore""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/metrics""
++	npl ""github.com/vmware-tanzu/antrea/pkg/agent/npl""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/openflow""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/proxy""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/querier""",nit: no need to add an alias for this case.
+7027,"@@ -4,15 +4,16 @@ import (
+ 	""fmt""
+ 	""io""
+ 	""os""
++	""strconv""
+ 	""sync""
+ )
+
+-var out io.Writer = os.Stdout
+-
+ // LogLevel of quic-go
+ type LogLevel uint8
+
+ const (
++	logEnv = ""QUIC_GO_LOG_LEVEL""
++
+ 	// LogLevelDebug enables debug logs (e.g. packet contents)
+ 	LogLevelDebug LogLevel = iota
+ 	// LogLevelInfo enables info logs (e.g. packets)",Or `QUIC_LOG_LEVEL`. Which one do you prefer?
+7028,"@@ -117,7 +117,14 @@ func GetDiskInfos(virtualHardware *ovf.VirtualHardwareSection, diskSection *ovf.
+ 				return diskInfos, err
+ 			}
+
+-			byteCapacity, err := Parse(int64(capacityRaw), *virtualDiscDesc.CapacityAllocationUnits)
++			var allocationUnits string
++			if virtualDiscDesc.CapacityAllocationUnits == nil ||
++				*virtualDiscDesc.CapacityAllocationUnits == """" {
++				allocationUnits = ""byte""
++			} else {
++				allocationUnits = *virtualDiscDesc.CapacityAllocationUnits
++			}
++			byteCapacity, err := Parse(int64(capacityRaw), allocationUnits)
+ 			if err != nil {
+ 				return diskInfos, err
+ 			}","Minor: you can set it to byte here and only set it to *virtualDiscDesc.CapacityAllocationUnits if that's not nil/"""". Saves two lines"
+7029,"@@ -70,6 +70,18 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
+                           headers=self.headers,
+                           status=400)
+
++    def test_buckets_can_handle_arbitrary_attributes(self):
++        bucket = MINIMALIST_BUCKET.copy()
++        fingerprint = ""5866f245a00bb3a39100d31b2f14d453""
++        bucket['data'] = {'fingerprint': fingerprint}
++        resp = self.app.put_json('/buckets/beers',
++                                 bucket,
++                                 headers=self.headers,
++                                 status=200)
++        data = resp.json['data']
++        self.assertIn('fingerprint', data)
++        self.assertEqual(data['fingerprint'], fingerprint)
++
+
+ class BucketCreationTest(BaseWebTest, unittest.TestCase):
+     def test_buckets_can_be_created_with_post(self):","While reading this I found that it makes actually little sense for ""beers"" to have a ""fingerprint"". We might want to do another pass on the examples here to use something that actually makes more sense to the reader. This could be done in another issue."
+7030,"@@ -365,7 +365,7 @@ public abstract class AbstractMultimapTest extends AbstractTraversableTest {
+     @Test
+     public void shouldConvertToMap() {
+         Multimap<Integer, Integer> mm = emptyIntInt().put(1, 2).put(1, 3);
+-        assertThat(mm.asMap().get(1).get().mkString("","")).isEqualTo(""2,3"");
++        assertThat(mm.asMap().get(1).get()).isEqualTo(HashSet.of(2, 3));
+     }
+
+     // -- biMap","Thank you! That's better, especially the conversion test should not test the mkString method :)"
+7031,"@@ -70,9 +70,10 @@ class ScintillaTextInfo(textInfos.offsets.OffsetsTextInfo):
+ 		return watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POSITIONFROMPOINT,x,y)
+
+ 	def _getPointFromOffset(self,offset):
++		location = self.obj.location
+ 		point=textInfos.Point(
+-		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTXFROMPOSITION,None,offset),
+-		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTYFROMPOSITION,None,offset)
++			location.left + watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTXFROMPOSITION,None,offset),
++			location.top + watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTYFROMPOSITION,None,offset)
+ 		)
+ 		if point.x is not None and point.y is not None:
+ 			return point","You're basically converting client to screen coordinates here, doing it manually. Is there a specific reason why you aren't using clientToScreen here? Does it fail?"
+7032,"@@ -340,6 +340,10 @@ func Copy(ctx context.Context, f fs.Fs, dst fs.Object, remote string, src fs.Obj
+ 		}
+ 		// If can't server side copy, do it manually
+ 		if err == fs.ErrorCantCopy {
++			if fs.Config.MaxTransfer >= 0 && (accounting.Stats(ctx).GetBytes() >= int64(fs.Config.MaxTransfer) ||
++				(fs.Config.MaxTransferMode == fs.MaxTransferModeCautious && accounting.Stats(ctx).GetBytesWithPending()+src.Size() >= int64(fs.Config.MaxTransfer))) {
++				return nil, accounting.ErrorMaxTransferLimitReached
++			}
+ 			if doMultiThreadCopy(f, src) {
+ 				// Number of streams proportional to size
+ 				streams := src.Size() / int64(fs.Config.MultiThreadCutoff)","This needs to be done for server-side copies too, earlier in the function."
+7033,"@@ -26,7 +26,13 @@ import (
+ 	""github.com/lyft/clutch/backend/service""
+ )
+
+-var scopes = []string{oidc.ScopeOpenID, ""email""} // TODO(maybe): make scopes part of config?
++// TODO(maybe): make scopes part of config?
++// For more documentation on scopes see: https://developer.okta.com/docs/reference/api/oidc/#scopes
++var scopes = []string{
++	oidc.ScopeOpenID,
++	oidc.ScopeOfflineAccess, // offline_access is used to request issuance of a refresh_token
++	""email"",
++}
+
+ const Name = ""clutch.service.authn""
+ ",Do we want to add in `profile` here as well so we request access to the end user's default profile claims like name?
+7034,"@@ -0,0 +1,10 @@
++module ProposalSpecHelper
++  def fully_approve(proposal)
++    proposal.individual_approvals.each do |approval|
++      approval.reload
++      approval.approve!
++    end
++    expect(proposal.reload).to be_approved # sanity check
++    deliveries.clear
++  end
++end",I am not sure what the difference between approving and full approving is...
+7035,"@@ -17,7 +17,7 @@ package main
+ import (
+ 	""time""
+
+-	""github.com/docopt/docopt-go""
++	docopt ""github.com/docopt/docopt-go""
+ 	log ""github.com/sirupsen/logrus""
+
+ 	""github.com/projectcalico/felix/iptables""",Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated
+7036,"@@ -127,7 +127,7 @@ public class TestSubQueryTransformer extends SolrTestCaseJ4 {
+      //System.out.println(""p ""+peopleMultiplier+"" d ""+deptMultiplier);
+     assertQ(""subq1.fl is limited to single field"",
+         req(""q"",""name_s:(john nancy)"", ""indent"",""true"",
+-            ""fl"",""name_s_dv,depts:[subquery]"",
++            ""fl"",""dept_ss_dv,name_s_dv,depts:[subquery]"",
+             ""rows"","""" + (2 * peopleMultiplier),
+             ""depts.q"",""{!term f=dept_id_s v=$row.dept_ss_dv}"",
+             ""depts.fl"",""text_t"",",Many tests in this class seem to have just been fortunate that `SolrIndexSearcher` ignored `fl` and retrieved all fields when not using lazy loading.
+7037,"@@ -14,7 +14,9 @@
+ # You should have received a copy of the GNU General Public License
+ # along with Scapy. If not, see <http://www.gnu.org/licenses/>.
+
+-# scapy.contrib.description = GENEVE
++# flake8: noqa: E501
++
++# scapy.contrib.description = Generic Network Virtualization Encapsulation (GENEVE)
+ # scapy.contrib.status = loads
+
+ """"""",Is this really needed?
+7038,"@@ -39,8 +39,12 @@ module RSpec
+
+         example_group_aliases << name
+
+-        (class << RSpec; self; end).__send__(:define_method, name) do |*args, &example_group_block|
+-          RSpec.world.register RSpec::Core::ExampleGroup.__send__(name, *args, &example_group_block)
++        (class << RSpec; self; end).instance_exec do
++          remove_method(name) if method_defined?(name)
++
++          define_method(name) do |*args, &example_group_block|
++            RSpec.world.register RSpec::Core::ExampleGroup.__send__(name, *args, &example_group_block)
++          end
+         end
+
+         expose_example_group_alias_globally(name) if exposed_globally?",Is this necessary with line 38?
+7039,"@@ -148,7 +148,7 @@ if ""CI_EXTRA_COMPILE_ARGS"" in os.environ:
+ # https://stackoverflow.com/questions/29870629/pip-install-test-dependencies-for-tox-from-setup-py
+ test_deps = [
+     ""pandas"",
+-    ""pytest>=3.0"",
++    ""pytest>=3.1"",
+     ""pytest-cov"",
+     ""pytest-benchmark>=3.1"",
+ ]",DO we want to have >= here? Or ==
+7040,"@@ -10,7 +10,7 @@ namespace Datadog.Trace
+         /// <summary>
+         /// The environment of the profiled service.
+         /// </summary>
+-        public const string Env = ""env"";
++        public const string Env = CoreTags.Env;
+
+         /// <summary>
+         /// The version of the profiled service.","Can you also add this `""version""` tag to the CoreTags? Now that we're targeting the service/env/version trio"
+7041,"@@ -29,6 +29,14 @@ class SkuTest extends TestCase
+         $this->assertEquals($sku, $sku->getValue());
+     }
+
++    /**
++     * @expectedException \InvalidArgumentException
++     */
++    public function testInvalidVAlue(): void
++    {
++        $sku = new Sku('yKL3rWXluEM7NapnMSVpYHpicQJkpJ0Obfx91mma0xwnQxUfsrwy5Nfki1LUZR4qYolBTlUFDO4RkeINIkjPzMfTSit0bQZJevXA6GMsj0LnSZaiT1bBfr00vtKWqLAPollonRzb6GBVlT5U9I6nC49r3Vnj2jUgpA73CvfnVnFBNnHqCaI2Cu48SKaVSRGgROhoD1dGPvvq98okavZ3ktVHk0TcyyiyfoH52U3gP3J5bNTVZngivjPJAqtOW8TO');
++    }
++
+     /**
+      * @return array
+      */",This entry will be incompatible with the currently implemented formatting rules. Maximum 120 characters per line.
+7042,"@@ -234,7 +234,11 @@ module Beaker
+         output_callback = nil
+       else
+         @logger.debug ""\n#{log_prefix} #{Time.new.strftime('%H:%M:%S')}$ #{cmdline}""
+-        output_callback = logger.method(:host_output)
++        if @options[:preserve_host_output]
++          output_callback = logger.method(:preserve_host_output)
++        else
++          output_callback = logger.method(:host_output)
++        end
+       end
+
+       unless $dry_run",Let's call this color_host_output or some such - preserve_host_output makes it sound like you won't get any output without this being set.
+7043,"@@ -6,7 +6,7 @@ var attr,
+ 	attrName,
+ 	allowed,
+ 	role = node.getAttribute('role'),
+-	attrs = node.attributes;
++	attrs = axe.utils.getNodeAttributes(node);
+
+ if (!role) {
+ 	role = axe.commons.aria.implicitRole(node);","suggestion: if we perhaps make `attributes` a getter in `virtualNode`, it does look seamless to access the property, same as what we have done for `isFocusable` or `tabbableElements`. `node.attributes` can become `virtualNode.attributes`"
+7044,"@@ -55,6 +55,7 @@ public class FeedMedia extends FeedFile implements Playable {
+     private Date playbackCompletionDate;
+     private int startPosition = -1;
+     private int playedDurationWhenStarted;
++    private String lastPlaybackSpeed = null;
+
+     // if null: unknown, will be checked
+     private Boolean hasEmbeddedPicture;",I think a float value fits better.
+7045,"@@ -90,6 +90,11 @@ func (s *server) setupRouting() {
+ 		),
+ 	})
+
++	handle(router, ""/pss/{topic}/ws"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.pssPostHandler),
++		//""POST"": http.HandlerFunc(s.pssPostHandler), // WS does not use verbs
++	})
++
+ 	handle(router, ""/tags"", web.ChainHandlers(
+ 		s.gatewayModeForbidEndpointHandler,
+ 		web.FinalHandler(jsonhttp.MethodHandler{","This should be (POST,DELETE) `/pss/subscribe/{topic}` for subscriptions and there should be `/pss/send/{topic}` for sending."
+7046,"@@ -13,6 +13,9 @@ export function createContext(defaultValue) {
+ 		_id: '__cC' + i++,
+ 		_defaultValue: defaultValue,
+ 		Consumer(props, context) {
++			this.shouldComponentUpdate = function (_props, _state, _context) {
++				return _context !== context;
++			};
+ 			return props.children(context);
+ 		},
+ 		Provider(props) {",Closing over the closure arguments is a neat trick :+1: Love it :100:
+7047,"@@ -156,11 +156,12 @@ public class TestEvaluatior {
+   @Test
+   public void testCaseSensitiveNot() {
+     TestHelpers.assertThrows(
+-      ""X != x when case sensitivity is on"",
+-      ValidationException.class,
+-      ""Cannot find field 'X' in struct"",
+-      () -> { new Evaluator(STRUCT, not(equal(""X"", 7)), true); }
+-      );
++        ""X != x when case sensitivity is on"",
++        ValidationException.class,
++        ""Cannot find field 'X' in struct"",
++        () -> {
++          new Evaluator(STRUCT, not(equal(""X"", 7)), true);
++        });
+   }
+
+   @Test",Does this need to be a block or can it be an expression?
+7048,"@@ -148,7 +148,7 @@ public abstract class LoginAbstractAzkabanServlet extends
+     buf.append(""\"""");
+     buf.append(req.getMethod()).append("" "");
+     buf.append(req.getRequestURI()).append("" "");
+-    if (req.getQueryString() != null) {
++    if (req.getQueryString() != null && allowedPostRequest(req)) {
+       buf.append(req.getQueryString()).append("" "");
+     } else {
+       buf.append(""-"").append("" "");",req.getQueryString() != null is not necessary since same check is already done in allowedPostRequest
+7049,"@@ -128,6 +128,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+   @Nullable
+   public abstract String grpcTransportImportName();
+
++  public abstract boolean isRestOnlyTransport();
++
+   @Override
+   public String resourceRoot() {
+     return SnippetSetRunner.SNIPPET_RESOURCE_ROOT;","As per go/actools-regapic-design, in the final product, generated GAPICs must be able to support multiple transports if supported by the API. For Java, we'll support this in the microgenerator; the monolith generates single-transport GAPICs. For PHP, the situation is likely similar, though on a longer timescale. All this to say that I would appreciate structuring the code in terms of ""supports REST"" rather than ""REST only"", but only where this doesn't require undue work. For everything else, please add a TODO to the effect of ""we're generating single-transport GAPICs for now, though in the fullness of time we'll generate multi-transport GAPICs."""
+7050,"@@ -13,5 +13,5 @@ return [
+     */
+
+     'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈز میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing again
+7051,"@@ -5,14 +5,14 @@ module DelayedJobsHelpers
+     end
+   end
+
+-  def stub_mail_method(method_name)
++  def stub_mail_method(klass, method_name)
+     stub('mail', deliver: true).tap do |mail|
+-      Mailer.stubs(method_name => mail)
++      klass.stubs(method_name => mail)
+     end
+   end
+
+-  def stub_mail_method_to_raise(method_name, error)
+-    Mailer.stubs(method_name).raises(error)
++  def stub_mail_method_to_raise(klass, method_name, error)
++    klass.stubs(method_name).raises(error)
+   end
+ end
+ ",Changed this helper to also get class name.
+7052,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher
+7053,"@@ -15,6 +15,9 @@
+ #include <valgrind/helgrind.h>
+ #endif
+
++// default actor batch size
++#define PONY_ACTOR_DEFAULT_BATCH 100
++
+ // Ignore padding at the end of the type.
+ pony_static_assert((offsetof(pony_actor_t, gc) + sizeof(gc_t)) ==
+    sizeof(pony_actor_pad_t), ""Wrong actor pad size!"");",Why the rename from PONY_SCHED_BATCH ? ACTOR_DEFAULT_BATCH is less meaningful to me than SCHED_BATCH.
+7054,"@@ -35,6 +35,10 @@ var log = logging.Logger(""/fil/storage"")
+ const makeDealProtocol = protocol.ID(""/fil/storage/mk/1.0.0"")
+ const queryDealProtocol = protocol.ID(""/fil/storage/qry/1.0.0"")
+
++// TODO: replace this with a queries to pick reasonable gas price and limits.
++const submitPostGasPrice = 0
++const submitPostGasLimit = 100000000000
++
+ // Miner represents a storage miner.
+ type Miner struct {
+ 	minerAddr      address.Address","Let's be sure we have an issue that tracks this, filed against testnet."
+7055,"@@ -9,6 +9,9 @@ function SIN(type, payload) {
+     SIN.super_.call(this, type, payload);
+     return;
+   }
++  if ( !Buffer.isBuffer(payload) ||  payload.length != 20)
++    throw new Error('Payload must be 20 bytes');
++
+   this.data = new Buffer(1 + 1 + payload.length);
+   this.converters = this.encodings['binary'].converters;
+   this._encoding = this.encodings['binary']._encoding;",There should be no space before !Buffer
+7056,"@@ -57,4 +57,6 @@ storiesOf( 'Global', module )
+ 				/>
+ 			</p>
+ 		</div>;
++	}, {
++		padding: 0,
+ 	} );","Same here, we need the default padding for this story."
+7057,"@@ -348,8 +348,12 @@ class InfluxListenStore(ListenStore):
+             int: the number of bytes this user's listens take in the dump file
+         """"""
+         self.log.info('Dumping user %s...', username)
++
++        t0 = time.time()
+         offset = 0
+         bytes_written = 0
++        listen_count = 0
++
+         # Get this user's listens in chunks
+         while True:
+             # loop until we get this chunk of listens","I think this should go away, its noise in the grand scheme of things."
+7058,"@@ -1273,6 +1273,17 @@ func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err e
+ 			}
+ 		}
+
++		// Create/Remove git-daemon-export-ok for git-daemon...
++		daemonExportFile := path.Join(repo.RepoPath(), `git-daemon-export-ok`)
++		if repo.IsPrivate {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			os.Remove(daemonExportFile)
++		} else {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			f, _ := os.Create(daemonExportFile)
++			f.Close()
++		}
++
+ 		forkRepos, err := getRepositoriesByForkID(e, repo.ID)
+ 		if err != nil {
+ 			return fmt.Errorf(""getRepositoriesByForkID: %v"", err)",Maybe just call `ioutil.WriteFile` with 0 bytes? And Make an error log `log.Error` if any error occurs.
+7059,"@@ -490,6 +490,18 @@ class Builder {
+     return this;
+   }
+
++  /**
++   * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
++   * child process when creating IE sessions locally.
++   *
++   * @param {ie.ServiceBuilder} service the service to use.
++   * @return {!Builder} a self reference.
++   */
++  setIeService(service) {
++    this.ieService_ = service;
++    return this;
++  }
++
+   /**
+    * Set {@linkplain edge.Options options} specific to Microsoft's Edge browser
+    * for drivers created by this builder. Any proxy settings defined on the",`this.ieService_` should be initialized to null in the constructor.
+7060,"@@ -313,11 +313,17 @@ func (r *DefaultRuleRenderer) filterOutputChain() *Chain {
+ 	// That decision is based on pragmatism; it's generally very useful to be able to contact
+ 	// any local workload from the host and policing the traffic doesn't really protect
+ 	// against host compromise.  If a host is compromised, then the rules could be removed!
++	// However, we do apply policy to workload ingress traffic if it belongs to an IPVS connection.
+ 	for _, prefix := range r.WorkloadIfacePrefixes {
+-		// If the packet is going to a worklaod endpoint, RETURN.
++		// If the packet is going to a workload endpoint, apply workload ingress policy if traffic
++		// belongs to an IPVS connection and return at the end.
+ 		log.WithField(""ifacePrefix"", prefix).Debug(""Adding workload match rules"")
+ 		ifaceMatch := prefix + ""+""
+ 		rules = append(rules,
++			Rule{
++				Match:  Match().OutInterface(ifaceMatch).IPVSConnection(),
++				Action: JumpAction{Target: ChainToWorkloadDispatch},
++			},
+ 			Rule{
+ 				Match:  Match().OutInterface(ifaceMatch),
+ 				Action: ReturnAction{},","I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?"
+7061,"@@ -35,7 +35,7 @@ public class PojoProducers implements BeanPostProcessor {
+     pojoMgr.register(pojoProducer.getSchemaId(), pojoProducer);
+   }
+
+-  public Collection<PojoProducerMeta> getProcucers() {
++  public Collection<PojoProducerMeta> getProducers() {
+     return pojoMgr.values();
+   }
+ ","This is public method , we need to deprecated this method first and add new updated method for it."
+7062,"@@ -199,7 +199,10 @@ func generateNetworkTemplate(templateFilename string, wallets, relays, nodeHosts
+ 		newNode.NodeNameMatchRegex = """"
+ 		newNode.FractionApply = 0.0
+ 		newNode.Name = name
+-		newNode.IsRelay = true
++		if newNode.NetAddress == """" {
++			// if not set by relayTemplate ensure that it is a relay
++			newNode.NetAddress = ""0.0.0.0:4160""
++		}
+ 		newNode.Wallets = nil
+ 		host.Nodes = append(host.Nodes, newNode)
+ 		network.Hosts = append(network.Hosts, host)","I think that you don't want to have these workarounds; you want to make sure that the relayTemplates is configured correctly. If not, we need to fix it there."
+7063,"@@ -306,7 +306,8 @@ public class ProtocolScheduleBuilder {
+             config.getEvmStackSize(),
+             isRevertReasonEnabled,
+             config.getEcip1017EraRounds(),
+-            quorumCompatibilityMode));
++            quorumCompatibilityMode,
++            config.getThanosBlockNumber()));
+
+     LOG.info(""Protocol schedule created with milestones: {}"", protocolSchedule.listMilestones());
+     return protocolSchedule;",This field is not needed.
+7064,"@@ -6,7 +6,10 @@ class Subscriber::CancellationsController < ApplicationController
+   end
+
+   def create
+-    @cancellation = Cancellation.new(subscription: current_user.subscription)
++    @cancellation = Cancellation.new(
++      subscription: current_user.subscription,
++      reason: cancellation_params[:reason],
++    )
+
+     if @cancellation.schedule
+       redirect_to(",Put a comma after the last parameter of a multiline method call.
+7065,"@@ -9,6 +9,7 @@ package e2etest
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/iotexproject/iotex-address/address""
+ 	""math/big""
+ 	""math/rand""
+ 	""testing""",move to line 18 below
+7066,"@@ -1,11 +1,16 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to upload an encrypted object to an
++# Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.ruby.s3_add_csaes_encrypt_item]
++
+ require 'aws-sdk-s3'
+ require 'openssl'
+
+-# Uploads an encrypted object to an Amazon S3 bucket.
+-#
++
+ # Prerequisites:
+ #
+ # - An Amazon S3 bucket.",Simple Storage **Service**
+7067,"@@ -81,6 +81,19 @@ root
+ "")
+     end
+
++    it ""can output indented messages"" do
++      root = RSpec.describe(""root"")
++      root.example(""example"") {|example| example.reporter.message(""message"")}
++
++      root.run(reporter)
++
++      expect(formatter_output.string).to eql(""
++root
++  message
++  example
++"")
++    end
++
+     it ""strips whitespace for each row"" do
+       group = RSpec.describe("" root "")
+       context1 = group.describe("" nested "")","Thats odd, I'd actually not expect this output at all..."
+7068,"@@ -53,7 +53,7 @@ module Travis
+         go_version_aliases: ENV.fetch(
+           'TRAVIS_BUILD_GO_VERSION_ALIASES', (
+             {
+-              '1' => '1.7.4',
++              '1' => '1.8',
+               '1.0' => '1.0.3',
+               '1.0.x' => '1.0.3',
+               '1.1.x' => '1.1.2',","As a side note, I get why this is up here (sort order), but it'd be easier to not forget to update it if it were down next to `1.x` -- would it be acceptable to make that change the next time I make this sort of PR? :smile: :innocent: (don't want to hold this one up since folks are blocked on getting this one in, it's a pretty superficial change, and I probably won't have cycles again for a few days to update the PR with the change :sweat_smile:)"
+7069,"@@ -92,14 +92,14 @@ public class AccountPermissioningControllerFactoryTest {
+   }
+
+   @Test
+-  public void createOnchainConfigWithAccountPermissioningDisabledShouldReturnEmpty() {
+-    SmartContractPermissioningConfiguration onchainConfig =
++  public void createFlexibleConfigWithAccountPermissioningDisabledShouldReturnEmpty() {
++    SmartContractPermissioningConfiguration flexibleConfig =
+         SmartContractPermissioningConfiguration.createDefault();
+-    assertThat(onchainConfig.isSmartContractAccountAllowlistEnabled()).isFalse();
++    assertThat(flexibleConfig.isSmartContractAccountAllowlistEnabled()).isFalse();
+
+     PermissioningConfiguration permissioningConfiguration =
+         new PermissioningConfiguration(
+-            Optional.empty(), Optional.of(onchainConfig), Optional.empty());
++            Optional.empty(), Optional.of(flexibleConfig), Optional.empty());
+
+     Optional<AccountPermissioningController> controller =
+         AccountPermissioningControllerFactory.create(","this class is permissioning so let's keep ""Onchain"" here"
+7070,"@@ -4,7 +4,7 @@ using System.Resources;
+ using System.Runtime.CompilerServices;
+ using System.Runtime.InteropServices;
+
+-// General Information about an assembly is controlled through the following
++// General Information about an assembly is controlled through the following
+ // set of attributes. Change these attribute values to modify the information
+ // associated with an assembly.
+ [assembly: AssemblyTitle(""AutoRest"")]","we can be more specific to call out the it is ""AutoRest C# code generator""?"
+7071,"@@ -124,3 +124,5 @@ class VirtualNode extends axe.AbstractVirtualNode {
+ 		return this._cache.boundingClientRect;
+ 	}
+ }
++
++axe.VirtualNode = VirtualNode;",Ditto for not adding this to the axe namespace.
+7072,"@@ -0,0 +1 @@
++package registration",Should we just remove this file? Having it present but empty feels misleading
+7073,"@@ -69,6 +69,14 @@ func (tracker *PeerTracker) UpdateTrusted(ctx context.Context) error {
+ 	return tracker.updatePeers(ctx, tracker.trustedPeers()...)
+ }
+
++// Trust adds `pid` to the peer trackers trusted node set.
++func (tracker *PeerTracker) Trust(pid peer.ID) {
++	tracker.mu.Lock()
++	defer tracker.mu.Unlock()
++	tracker.trusted[pid] = struct{}{}
++	logPeerTracker.Infof(""Trusting peer=%s"", pid.Pretty())
++}
++
+ // Track adds information about a given peer.ID
+ func (tracker *PeerTracker) Track(ci *types.ChainInfo) {
+ 	tracker.mu.Lock()",Would it make sense to include an `Untrust` as well? If I were playing around with this on the CLI I wouldn't want to make a change I couldn't undo.
+7074,"@@ -43,6 +43,13 @@ use VuFindSearch\Backend\Solr\Response\Json\RecordCollectionFactory;
+  */
+ class SolrDefaultBackendFactory extends AbstractSolrBackendFactory
+ {
++    /**
++     * Callback for creating a record driver.
++     *
++     * @var string
++     */
++    protected $createRecordCallback = 'getSolrRecord';
++
+     /**
+      * Constructor
+      */","It might be better to call this `$createRecordMethod` since it's not a full PHP callback, just a method name for the plugin manager."
+7075,"@@ -15,7 +15,12 @@ namespace Thelia\Action;
+ use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+ use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+ use Thelia\Core\Event\Cart\CartEvent;
++use Thelia\Core\Event\Currency\CurrencyChangeEvent;
+ use Thelia\Core\Event\TheliaEvents;
++use Thelia\Core\HttpFoundation\Request;
++use Thelia\Core\HttpFoundation\Session\Session;
++use Thelia\Log\Tlog;
++use Thelia\Model\Currency;
+ use Thelia\Model\ProductPrice;
+ use Thelia\Model\ProductPriceQuery;
+ use Thelia\Model\CartItem;",remove this line
+7076,"@@ -24,7 +24,7 @@ class NavigationManager
+     protected $callbacks = [];
+
+     /**
+-     * @var array List of registered items.
++     * @var MainMenuItem[] List of registered items.
+      */
+     protected $items;
+ ","I've never seen this syntax before, it's still just an array, the difference is that it's an array of MainMenuItems instead of an array of arrays."
+7077,"@@ -1532,10 +1532,15 @@ map_api_set_dll(const char *name, privmod_t *dependent)
+              str_case_prefix(name, ""API-MS-Win-Eventing-Provider-L1-1""))
+         return ""kernelbase.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-Core-PrivateProfile-L1-1"") ||
+-             str_case_prefix(name, ""API-MS-Win-Core-Atoms-L1-1""))
++             str_case_prefix(name, ""API-MS-Win-Core-Atoms-L1-1"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Localization-Obsolete-L1-2"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Kernel32-private-L1-1""))
+         return ""kernel32.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-Core-WinRT-Error-L1-1""))
+         return ""combase.dll"";
++    else if (str_case_prefix(name, ""API-MS-Win-Core-Appinit-L1-1"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Com-L1-1""))
++        return ""ole32.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-GDI-"")) {
+         /* We've seen many different GDI-* */
+         return ""gdi32full.dll"";",nit: to match the others: s/private/Private/
+7078,"@@ -96,8 +96,9 @@ namespace Nethermind.Network
+
+         public IReadOnlyCollection<Peer> ActivePeers => _activePeers.Values.ToList().AsReadOnly();
+         public IReadOnlyCollection<Peer> CandidatePeers => _peerPool.CandidatePeers.ToList();
++        public IReadOnlyCollection<Peer> ConnectedPeers => _activePeers.Values.Where(IsConnected).ToList().AsReadOnly();
+         private int AvailableActivePeersCount => MaxActivePeers - _activePeers.Count;
+-        private int MaxActivePeers => _networkConfig.ActivePeersMaxCount + _peerPool.StaticPeerCount;
++        public int MaxActivePeers => _networkConfig.ActivePeersMaxCount + _peerPool.StaticPeerCount;
+
+         public void Init()
+         {",Maybe just IEnumerable? Not sure myself.
+7079,"@@ -54,7 +54,8 @@ public abstract class TestIcebergSourceHiveTables extends TestIcebergSourceTable
+   @Override
+   public Table createTable(TableIdentifier ident, Schema schema, PartitionSpec spec) {
+     TestIcebergSourceHiveTables.currentIdentifier = ident;
+-    return TestIcebergSourceHiveTables.catalog.createTable(ident, schema, spec);
++    Table table = TestIcebergSourceHiveTables.catalog.createTable(ident, schema, spec);
++    return table;
+   }
+
+   @Override",do we need this change?
+7080,"@@ -586,7 +586,17 @@ func (s *Server) configureAccounts() error {
+ 	// Check opts and walk through them. We need to copy them here
+ 	// so that we do not keep a real one sitting in the options.
+ 	for _, acc := range s.opts.Accounts {
+-		a := acc.shallowCopy()
++		var a *Account
++		if acc.Name == globalAccountName {
++			a = s.gacc
++		} else {
++			a = acc.shallowCopy()
++		}
++		if acc.hasMappings() {
++			// For now just move and wipe from opts.Accounts version.
++			a.mappings = acc.mappings
++			acc.mappings = nil
++		}
+ 		acc.sl = nil
+ 		acc.clients = nil
+ 		s.registerAccountNoLock(a)","Would want @matthiashanel to have a look since if I recall he had to add the shallowCopy() to fix some bugs during reload. That being said, since I believe the $G account cannot referenced in configurations, this should not be a problem, but Matthias has looked at this in more details in the past."
+7081,"@@ -320,3 +320,19 @@ func (volInfo *VolumeInfo) GetNodeName() string {
+ 	}
+ 	return """"
+ }
++
++// GetVolumeStatus returns the status of the volume
++func (volInfo *VolumeInfo) GetVolumeStatus() string {
++	if len(volInfo.Volume.Status.Reason) > 0 {
++		return volInfo.Volume.Status.Reason
++	}
++	return volumeStatusOK
++}
++
++// GetVolumeNamespace returns the status of the volume
++func (volInfo *VolumeInfo) GetVolumeNamespace() string {
++	if len(volInfo.Volume.ObjectMeta.Namespace) > 0 {
++		return volInfo.Volume.ObjectMeta.Namespace
++	}
++	return ""N/A""
++}",The descriptions are incorrect
+7082,"@@ -1229,6 +1229,14 @@ class WebDriver {
+     if (target && cdpTargets.indexOf(target.toLowerCase()) === -1) {
+       throw new error.InvalidArgumentError('invalid target value')
+     }
++
++    if (debuggerAddress.match(/\/se\/cdp/)) {
++      if (debuggerAddress.match(""ws:\/\/"", ""http:\/\/"")) {
++        return debuggerAddress.replace(""ws:\/\/"", ""http:\/\/"")
++      }
++      return debuggerAddress
++    }
++
+     const path = '/json/version'
+     let request = new http.Request('GET', path)
+     let client = new http.HttpClient('http://' + debuggerAddress)",if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?
+7083,"@@ -1749,7 +1749,8 @@ class CommandDispatcher:
+             elif going_up and tab.scroller.pos_px().y() > old_scroll_pos.y():
+                 message.info(""Search hit TOP, continuing at BOTTOM"")
+         else:
+-            message.warning(""Text '{}' not found on page!"".format(text))
++            message.warning(""Text '{}' not found on page!"".format(text),
++                    replace=True)
+
+     @cmdutils.register(instance='command-dispatcher', scope='window',
+                        maxsplit=0)",Please only indent this by four spaces.
+7084,"@@ -74,7 +74,7 @@ func isLink(s string) bool {
+
+ func randString(n int) string {
+ 	gen := rand.New(rand.NewSource(time.Now().UnixNano()))
+-	letters := ""abcdefghijklmnopqrstuvwxyz""
++	letters := ""bdghjlmnpqrstvwxyz0123456789""
+ 	b := make([]byte, n)
+ 	for i := range b {
+ 		b[i] = letters[gen.Int63()%int64(len(letters))]",What's the reason behind these characters?
+7085,"@@ -13,9 +13,12 @@ describe ParallelDispatcher do
+     end
+
+     it 'creates a new token for each approver' do
+-      expect(ApiToken).to receive(:create!).exactly(2).times
+       expect(dispatcher).to receive(:send_notification_email).twice
+       dispatcher.deliver_new_cart_emails(cart)
++
++      cart.approver_approvals.each do |approval|
++        expect(approval.api_token.expires_at).to be > Time.now
++      end
+     end
+
+     it 'sends a cart notification email to observers' do",Minor: The name of this specs seems a little off now
+7086,"@@ -1126,10 +1126,12 @@ ast_result_t pass_syntax(ast_t** astp, pass_opt_t* options)
+     case TK_VALUEFORMALARG:
+     case TK_VALUEFORMALPARAM:
+       ast_error(options->check.errors, ast,
+-        ""Value formal parameters not yet supported"");
++        ""Value formal parameters not yet supported. ""
++        ""Note that many functions including array indexing use the apply ""
++        ""method raher than square brackets"");
+       r = AST_ERROR;
+       break;
+-
++
+     case TK_CONSTANT:
+       ast_error(options->check.errors, ast,
+         ""Compile time expressions not yet supported"");",I'd suggest using `ast_error_continue` here to get the `apply` message in the `Info` part of the error report.
+7087,"@@ -72,6 +72,13 @@ class SearchTabsHelper extends \Laminas\View\Helper\AbstractHelper
+      */
+     protected $permissionConfig;
+
++    /**
++     * Tab detailed configuration
++     *
++     * @var array
++     */
++    protected $detailConfig;
++
+     /**
+      * Request
+      *","If we decide to change the name of the .ini setting, we might also want to review the naming of this property and related code. Maybe a simple `getOptions` or `getSettings` would be more concise than `getTabDetailConfig`. At very least, I don't think we need Tab in the method name since the method belongs to a helper with ""Tabs"" in the name."
+7088,"@@ -175,6 +175,10 @@ func isListResource(msg *beehiveModel.Message) bool {
+ 			return true
+ 		}
+ 	}
++	// user data
++	if msg.GetGroup() == ""user"" {
++		return true
++	}
+
+ 	return false
+ }","Use const for ""user"", same as below"
+7089,"@@ -79,6 +79,7 @@ class Newsletter extends BaseAction implements EventSubscriberInterface
+             $nl->setEmail($event->getEmail())
+                 ->setFirstname($event->getFirstname())
+                 ->setLastname($event->getLastname())
++                ->setUnsubscribed(0)
+                 ->setLocale($event->getLocale())
+                 ->save();
+ ",->setUnsubscribed(false) would be better :)
+7090,"@@ -0,0 +1,11 @@
++# frozen_string_literal: true
++
++module Faker
++  class Sports < Base
++    class << self
++      def name
++        fetch('sports.name')
++      end
++    end
++  end
++end","I now think singular `Sport` is better, but I will wait for the first round of feedback before updating."
+7091,"@@ -167,6 +167,9 @@ class UserResource:
+             parent_id=parent_id,
+             auth=auth)
+
++        # Initialize timestamp as soon as possible.
++        self.timestamp
++
+         self.request = request
+         self.context = context
+         self.record_id = self.request.matchdict.get('id')",Don't you need = something ?
+7092,"@@ -1869,10 +1869,12 @@ bool CoreChecks::ValidateCmdQueueFlags(const CMD_BUFFER_STATE *cb_node, const ch
+                                        const char *error_code) const {
+     auto pool = cb_node->command_pool.get();
+     if (pool) {
+-        VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[pool->queueFamilyIndex].queueFlags;
++        const uint32_t queue_family_index = pool->queueFamilyIndex;
++        const VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[queue_family_index].queueFlags;
+         if (!(required_flags & queue_flags)) {
+             string required_flags_string;
+-            for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT}) {
++            for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT, VK_QUEUE_SPARSE_BINDING_BIT,
++                              VK_QUEUE_PROTECTED_BIT}) {
+                 if (flag & required_flags) {
+                     if (required_flags_string.size()) {
+                         required_flags_string += "" or "";",Looks like this could be `const` (I realize it wasn't like that before)?
+7093,"@@ -7,7 +7,8 @@ import com.fsck.k9.message.preview.PreviewResult.PreviewType;
+ public enum DatabasePreviewType {
+     NONE(""none"", PreviewType.NONE),
+     TEXT(""text"", PreviewType.TEXT),
+-    ENCRYPTED(""encrypted"", PreviewType.ENCRYPTED);
++    ENCRYPTED(""encrypted"", PreviewType.ENCRYPTED),
++    FAILED_TO_LOAD(""failedToLoad"", PreviewType.FAILED_TO_LOAD);
+
+
+     private final String databaseValue;",Maybe just `FAILED`. We can't be sure loading was the thing that failed.
+7094,"@@ -1,5 +1,5 @@
+-define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSettings', 'cardBuilder', 'datetime', 'mediaInfo', 'backdrop', 'listView', 'itemContextMenu', 'itemHelper', 'dom', 'indicators', 'imageLoader', 'libraryMenu', 'globalize', 'browser', 'events', 'playbackManager', 'scrollStyles', 'emby-itemscontainer', 'emby-checkbox', 'emby-button', 'emby-playstatebutton', 'emby-ratingbutton', 'emby-scroller', 'emby-select'], function (loading, appRouter, layoutManager, connectionManager, userSettings, cardBuilder, datetime, mediaInfo, backdrop, listView, itemContextMenu, itemHelper, dom, indicators, imageLoader, libraryMenu, globalize, browser, events, playbackManager) {
+-    'use strict';
++define([""loading"", ""appRouter"", ""layoutManager"", ""connectionManager"", ""userSettings"", ""cardBuilder"", ""datetime"", ""mediaInfo"", ""backdrop"", ""listView"", ""itemContextMenu"", ""itemHelper"", ""dom"", ""indicators"", ""imageLoader"", ""libraryMenu"", ""globalize"", ""browser"", ""events"", ""playbackManager"", ""scrollStyles"", ""emby-itemscontainer"", ""emby-checkbox"", ""emby-button"", ""emby-playstatebutton"", ""emby-ratingbutton"", ""emby-scroller"", ""emby-select""], function (loading, appRouter, layoutManager, connectionManager, userSettings, cardBuilder, datetime, mediaInfo, backdrop, listView, itemContextMenu, itemHelper, dom, indicators, imageLoader, libraryMenu, globalize, browser, events, playbackManager) {
++    ""use strict"";
+
+     function getPromise(apiClient, params) {
+         var id = params.id;","You have replaced single quotes with double ones, this fails linting and our current coding style. Please fix this, otherwise it's a whopping of 1200 LoC while in reality it should be rather small."
+7095,"@@ -43,6 +43,9 @@ public class PlaybackPreferences implements
+ 	/** True if last played media was a video. */
+ 	public static final String PREF_CURRENT_EPISODE_IS_VIDEO = ""de.danoeh.antennapod.preferences.lastIsVideo"";
+
++	/** Value of PREF_QUEUE_ADD_TO_FRONT if no media is playing. */
++	public static final String PREF_QUEUE_ADD_TO_FRONT = ""prefQueueAddToFront"";
++
+ 	/** Value of PREF_CURRENTLY_PLAYING_MEDIA if no media is playing. */
+ 	public static final long NO_MEDIA_PLAYING = -1;
+ ","@danieloeh @TomHennen. Some of these files are using spaces, the others use tabs. Is there a project wide preference? I personally like spaces, because they are consistent across editors"
+7096,"@@ -11,10 +11,12 @@ module Blacklight
+     # @param [SolrDocument] document
+     # @param [ActionView::Base] view_context scope for linking and generating urls
+     # @param [Blacklight::Configuration] configuration
+-    def initialize(document, view_context, configuration = view_context.blacklight_config)
++    # @param [Integer] counter what offset in the search result is this record (used for tracking)
++    def initialize(document, view_context, configuration = view_context.blacklight_config, counter: nil)
+       @document = document
+       @view_context = view_context
+       @configuration = configuration
++      @counter = counter
+     end
+
+     # @return [Hash<String,Configuration::Field>]  all the fields for this index view that should be rendered","I guess this is ok for backwards-compatibility? Maybe it'd be better to check arity in the helpers? Or just call it out in the release notes, because there are at least a couple projects on github that overrode `initialize`.."
+7097,"@@ -194,8 +194,8 @@ public class AzkabanWebServer extends AzkabanServer {
+     // TODO remove hack. Move injection to constructor
+     executorManager = SERVICE_PROVIDER.getInstance(ExecutorManager.class);
+     projectManager = SERVICE_PROVIDER.getInstance(ProjectManager.class);
++    triggerManager = SERVICE_PROVIDER.getInstance(TriggerManager.class);
+
+-    triggerManager = loadTriggerManager(props);
+     loadBuiltinCheckersAndActions();
+
+     // load all trigger agents here","At some point, we would like to get rid of these custom injections as well. Looks Ok for now."
+7098,"@@ -349,6 +349,13 @@ namespace Datadog.Trace.Configuration
+             /// </summary>
+             /// <seealso cref=""TracerSettings.DelayWcfInstrumentationEnabled""/>
+             public const string DelayWcfInstrumentationEnabled = ""DD_TRACE_DELAY_WCF_INSTRUMENTATION_ENABLED"";
++
++            /// <summary>
++            /// Enables a fix around header tags normalization.
++            /// We used to normalize periods even if a tag was provided for a header, whereas we should not.
++            /// This flag defaults to true and is here in case customers need retrocompatibility only
++            /// </summary>
++            public const string HeaderTagsNormalizationFixEnabled = ""DD_TRACE_HEADER_TAG_NORMALIZATION_FIX_ENABLED"";
+         }
+     }
+ }","nit: Not a fan of ""fix"" in the name, but don't have a better suggestion  "
+7099,"@@ -181,6 +181,11 @@ class TabWidget(QTabWidget):
+         except qtutils.QtValueError:
+             fields['current_url'] = ''
+
++        try:
++            fields['protocol'] = self.tab_url(idx).scheme()
++        except qtutils.QtValueError:
++            fields['protocol'] = ''
++
+         y = tab.scroller.pos_perc()[1]
+         if y is None:
+             scroll_pos = '???'","Since we're calling `self.tab_url(idx)` a third time here already, can you please add a `url = self.tab_url(idx)` somewhere above (e.g. after all the `fields[...] = ...` assignments) and change the calls here to `url.host()` etc.?"
+7100,"@@ -15,8 +15,8 @@
+ """"""Forseti CLI installer.""""""
+
+ from forseti_installer import ForsetiInstaller
+-
+ from util import gcloud
++from util import constants
+
+ class ForsetiClientInstaller(ForsetiInstaller):
+     """"""Forseti command line interface installer""""""",alphasort this import
+7101,"@@ -0,0 +1,14 @@
++#include<iostream>
++using namespace std;
++void reverseNum(int digit){
++	while(digit>0){
++		int n=digit%10;
++		digit=digit/10;
++		cout<<n<<""\t"";
++	}
++}
++int main(){
++	int digit;
++	cin>>digit;
++	reverseNum(digit);
++}",remove this file!
+7102,"@@ -256,11 +256,14 @@ func (acc *Account) String() string {
+ 			etas = ""0s""
+ 		}
+ 	}
++
+ 	name := []rune(acc.name)
+ 	if fs.Config.StatsFileNameLength > 0 {
+ 		if len(name) > fs.Config.StatsFileNameLength {
+-			where := len(name) - fs.Config.StatsFileNameLength
+-			name = append([]rune{'.', '.', '.'}, name[where:]...)
++			suffixLength := fs.Config.StatsFileNameLength / 2
++			prefixLength := fs.Config.StatsFileNameLength - suffixLength
++			suffixStart := len(name) - suffixLength
++			name = append(append(name[:prefixLength], '…'), name[suffixStart:]...)
+ 		}
+ 	}
+ ",You don't need to say `rune(' ')` - `' '` is already a `rune`.
+7103,"@@ -38,7 +38,7 @@ module Selenium
+         port
+       end
+
+-      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
++      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL].freeze
+       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+       IGNORED_ERRORS.freeze
+ ",We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it.
+7104,"@@ -0,0 +1,5 @@
++package javaslang.control;
++
++public interface Kind<TYPE extends Kind<TYPE, ?, ?>, E, T> {
++
++}",We call it Kind2 and move out of the `javaslang/control` package into the `javaslang`package. Maybe I will later generate Kind1..Kindn but that's another story.
+7105,"@@ -166,7 +166,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
+-	db.logger.Infof(""db capacity: %v"", db.capacity)
++	db.logger.Infof(""database capacity in chunks (and in Bytes): %v (%v)"", db.capacity, db.capacity*swarm.ChunkSize)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","i think it might be nicer to have a message like: `database capacity: %d chunks (%d bytes, %d megabytes)`. counting in bytes is so 90s :)"
+7106,"@@ -195,6 +195,16 @@ public class Constants {
+
+     // dir to keep dependency plugins
+     public static final String DEPENDENCY_PLUGIN_DIR = ""azkaban.dependency.plugin.dir"";
++
++    /*
++     * Prefix used to construct Hadoop/Spark user job link.
++     * a) RM: resource manager
++     * b) JHS: Hadoop job history server
++     * c) SHS: spark job history server
++     * */
++    public static final String AZKABAN_RM_JOB_LINK = ""azkaban.rm.job.link"";
++    public static final String AZKABAN_JHS_JOB_LINK = ""azkaban.jhs.job.link"";
++    public static final String AZKABAN_SHS_JOB_LINK = ""azkaban.shs.job.link"";
+   }
+
+   public static class FlowProperties {","The '.' in the key names are used to separate namespaces, NOT to separate words. How about azkaban.external_resources.resource_manager? ---- Why is it better than using the full name in the variable name e.g. RESOURCE_MANAGER_LINK ?"
+7107,"@@ -17,7 +17,7 @@
+ using BenchmarkDotNet.Attributes;
+ using Benchmarks.Tracing;
+ using OpenTelemetry.Trace;
+-using OpenTelemetry.Trace.Configuration;
++using OpenTelemetry.Trace;
+ using OpenTelemetry.Trace.Samplers;
+
+ namespace Benchmarks",This seems to be duplicated with line 19?
+7108,"@@ -20,7 +20,7 @@
+ #endif
+
+ #if !(defined(_WIN32) || (defined(__WXMAC__) && (MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_4)))
+-#include <xlocale.h>
++#include <wx/xlocale.h>
+ #endif
+
+ #include ""stdwx.h""","This is wrong. xlocale.h is needed on OSX and maybe elsewhere too. This needs a test in configure to see if xlocale.h and uselocale() are available and an #if test here. Also, the NO_PER_THREAD_LOCALE stuff in configure.ac needs to be updated to include test for uselocale()."
+7109,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteAccessKey.java demonstrates how to delete an access key from an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[DeleteAccessKey.java demonstrates how to delete an access key from an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+7110,"@@ -138,7 +138,7 @@ utils.imageReplacement = function(ResourceModel, src, resources, resourceBaseUrl
+ 	}
+
+ 	const mime = resource.mime ? resource.mime.toLowerCase() : '';
+-	if (ResourceModel.isSupportedImageMimeType(mime)) {
++	if (ResourceModel.isSupportedImageMimeType(mime) || ResourceModel.isSupportedAudioMimeType(mime)) {
+ 		let newSrc = `./${ResourceModel.filename(resource)}`;
+ 		if (resourceBaseUrl) newSrc = resourceBaseUrl + newSrc;
+ 		newSrc += `?t=${resource.updated_time}`;","Why did you have multiple function calls here instead of having one long array of supported mimeTypes? In line with your PR here, I think we might eventually see inline videos or inline pdf. It would be great to generalize this a bit."
+7111,"@@ -37,6 +37,7 @@ from pyspark.sql.types import (
+     LongType,
+     StringType,
+     TimestampType,
++    NumericType,
+ )
+
+ from databricks import koalas as ks  # For running doctests and reference resolution in PyCharm.",nit: shall we keep alphabetical order?
+7112,"@@ -106,6 +106,15 @@ export default class Realm {
+         let method = util.createMethod(objectTypes.REALM, 'objects');
+         return method.apply(this, [type, ...args]);
+     }
++
++    objectForPrimaryKey(type, ...args) {
++        if (typeof type == 'function') {
++            type = objects.typeForConstructor(this[keys.realm], type);
++        }
++
++        let method = util.createMethod(objectTypes.REALM, 'objectForPrimaryKey');
++        return method.apply(this, [type, ...args]);
++    }
+ }
+
+ // Non-mutating methods:",We could just move the check for function into `typeForConstruction` to make this a one liner every time we need to do this.
+7113,"@@ -153,7 +153,7 @@ public class I18nTest extends JUnit4TestBase {
+     assertThat(ime.isActivated()).isTrue();
+     assertThat(ime.getActiveEngine()).isEqualTo(desiredEngine);
+
+-    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to convert the word.
++    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to transform the word.
+     input.sendKeys(""toukyou "");
+     input.sendKeys(Keys.ENTER);
+ ",A correct by unrelated change. We'll slide this one in without another word ;)
+7114,"@@ -40,6 +40,9 @@ Solver<Dtype>::Solver(const SolverParameter& param)
+ template <typename Dtype>
+ void Solver<Dtype>::Solve(const char* resume_file) {
+   Caffe::set_mode(Caffe::Brew(param_.solver_mode()));
++  if (param_.solver_mode()) {
++    Caffe::SetDevice(param_.device_id());
++  }
+   Caffe::set_phase(Caffe::TRAIN);
+   LOG(INFO) << ""Solving "" << net_->name();
+   PreSolve();","I feel that a slightly safer way is to do if (param_.has_device_id()) { Caffe::SetDevice(param_.device_id()); } just in case a user has hard-coded a device id outside the solver and does not specify the device id in the solver param. Currently, if nothing is set, the solver will always use the 0th device, which might not be desired."
+7115,"@@ -321,6 +321,7 @@ class TestSeleniumScriptBuilder(SeleniumTestCase):
+                             ""closeWindow('that_window')"",
+                             ""submitByName(\""toPort\"")"",
+                             ""scriptEval(\""alert('This is Sparta');\"")"",
++                            ""rawCode(multi(1)\n  line(2)\n    block(33))"",
+                             {""dragByID(address)"": ""elementByName(toPort)""},
+                             ""switchFrameByName('my_frame')"",
+                             ""switchFrameByIdx(1)"",","let's replace this example with something that won't fail in Python. Like ""for+if+print"""
+7116,"@@ -268,7 +268,8 @@ def _to_graphviz(tree_info, show_info, feature_names, precision=None,
+         raise ImportError('You must install graphviz to plot tree.')
+
+     def float2str(value, precision=None):
+-        return ""{0:.{1}f}"".format(value, precision) if precision is not None else str(value)
++        return ""{0:.{1}f}"".format(value, precision) \
++            if (precision is not None) and (not isinstance(value, str)) else str(value)
+
+     def add(root, parent=None, decision=None):
+         """"""recursively add node or edge""""""",Please remove the brackets and use `string_type` from `compat.py` module instead of `str` in `isinstance()`.
+7117,"@@ -36,16 +36,11 @@ type Execution struct {
+ }
+
+ // NewExecution returns a Execution instance
+-func NewExecution(executorAddress string, contractAddress string, nonce uint64, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) (*Execution, error) {
+-	if executorAddress == """" {
+-		return nil, errors.Wrap(ErrAddress, ""address of the executor is empty"")
+-	}
+-
++func NewExecution(contractAddress string, nonce uint64, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) (*Execution, error) {
+ 	return &Execution{
+ 		AbstractAction: AbstractAction{
+ 			version:  version.ProtocolVersion,
+ 			nonce:    nonce,
+-			srcAddr:  executorAddress,
+ 			dstAddr:  contractAddress,
+ 			gasLimit: gasLimit,
+ 			gasPrice: gasPrice,",line is 143 characters (from `lll`)
+7118,"@@ -94,7 +94,11 @@ func NewController(params Params) (types.Controller, error) {
+ 						for i := 0; i < items.Len(); i++ {
+ 							item := items.Index(i).Addr().Interface().(InnerObjectWithSelector)
+ 							for _, record := range item.GetStatus().Experiment.Records {
+-								if controller.ParseNamespacedName(record.Id) == objName {
++								namespacedName, err := controller.ParseNamespacedName(record.Id)
++								if err != nil {
++									setupLog.Error(err, ""failed to parse record"", ""record"", record.Id)
++								}
++								if namespacedName == objName {
+ 									id := k8sTypes.NamespacedName{
+ 										Namespace: item.GetObjectMeta().Namespace,
+ 										Name:      item.GetObjectMeta().Name,",It should follow a `continue`.
+7119,"@@ -18,6 +18,7 @@ services:
+         gid: '{{ .GID }}'
+     image: ${DDEV_DBIMAGE}-${DDEV_SITENAME}-built
+     stop_grace_period: 60s
++    working_dir: ""{{ .WebWorkingDir }}""
+     volumes:
+       - type: ""volume""
+         source: mariadb-database",Should this be DBWorkingDir?
+7120,"@@ -542,7 +542,7 @@ public class AutoScalingHandler extends RequestHandlerBase implements Permission
+     String eventTypeStr = op.getStr(EVENT);
+
+     if (op.hasError()) return currentConfig;
+-    TriggerEventType eventType = TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
++    TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
+
+     String waitForStr = op.getStr(WAIT_FOR, null);
+ ",I think you can remove the whole line.
+7121,"@@ -8,6 +8,7 @@ package consensus
+
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-core/db""
+ 	""math/big""
+
+ 	""github.com/facebookgo/clock""",File is not `goimports`-ed (from `goimports`)
+7122,"@@ -40,12 +40,13 @@ public class ClientHarvestRun implements Serializable {
+         this.id = id;
+     }
+
+-    public enum RunResultType { SUCCESS, FAILURE, INPROGRESS };
++    public enum RunResultType { SUCCESS, RUN_FAILED, RUN_IN_PROGRESS, DELETE_FAILED };
+
+     private static String RESULT_LABEL_SUCCESS = ""SUCCESS"";
+-    private static String RESULT_LABEL_FAILURE = ""FAILED"";
+-    private static String RESULT_LABEL_INPROGRESS = ""IN PROGRESS"";
+-    private static String RESULT_DELETE_IN_PROGRESS = ""DELETE IN PROGRESS"";
++    private static String RESULT_LABEL_RUN_FAILED = ""RUN FAILED"";
++    private static String RESULT_LABEL_RUN_IN_PROGRESS = ""RUN IN PROGRESS"";
++    private static String RESULT_LABEL_DELETE_IN_PROGRESS = ""DELETE IN PROGRESS"";
++    private static String RESULT_LABEL_DELETE_FAILED = ""DELETE FAILED"";
+
+     @ManyToOne
+     @JoinColumn(nullable = false)","Not a big deal, but what is the value of adding this status condition for a failure to delete a client? It has some value for a dataverse admin, to know that the last attempt to harvest from a certain server resulted in a failure. Is it really useful to know that an attempt to delete a client failed? - should the startup check simply remove the ""delete in progress"" flag quietly instead? After all, seeing how the client is still there makes it somewhat clear that the attempt to get rid of it didn't work out, so they should try again? I may be missing some situation where it could actually be useful - so I'm open to hearing it."
+7123,"@@ -85,7 +85,7 @@ public abstract class BaseWriterFactory<T> implements WriterFactory<T> {
+     OutputFile outputFile = file.encryptingOutputFile();
+     EncryptionKeyMetadata keyMetadata = file.keyMetadata();
+     Map<String, String> properties = table.properties();
+-    MetricsConfig metricsConfig = MetricsConfig.fromProperties(properties);
++    MetricsConfig metricsConfig = MetricsConfig.forTable(table);
+
+     try {
+       switch (dataFileFormat) {",Can we also update the equality delete branch below?
+7124,"@@ -457,6 +457,11 @@ class StepExecutionContext(PlanExecutionContext, IStepContext):
+             if step_output_handle == record.dagster_event.event_specific_data.step_output_handle:
+                 return True
+
++        # source is skipped so cannot load
++        for record in self.instance.all_logs(self.run_id, of_type=DagsterEventType.STEP_SKIPPED):
++            if step_output_handle.step_key == record.dagster_event.step_key:
++                return False
++
+         # can load from a previous run
+         if self._get_source_run_id_from_logs(step_output_handle):
+             return True","This doesn't solve the entire problem we talked abut yesterday, right? Because it's possible that the step itself didn't skip, but rather that it chose not to yield the output in question?"
+7125,"@@ -5,6 +5,7 @@
+ # -------------------------------------------------------------------------
+
+ import base64
++from datetime import datetime
+ from hashlib import sha256
+ import json
+ import os",I also do not see any usages of this import. Is this a fix for a crash?
+7126,"@@ -794,6 +794,9 @@ func (engine *DockerTaskEngine) AddTask(task *apitask.Task) {
+ 		// This will update the container desired status
+ 		task.UpdateDesiredStatus()
+
++		// This will update any dependencies for awsvpc network mode before the task is started.
++		engine.updateTaskENIDependencies(task)
++
+ 		engine.state.AddTask(task)
+ 		if dependencygraph.ValidDependencies(task, engine.cfg) {
+ 			engine.startTask(task)",Feels like this needs to be invoked in `PostUnmarshalTask` since that's where most of the task setup happens.
+7127,"@@ -5390,7 +5390,8 @@ PrivStatus ObjectPrivsMDTable::updateWhere(const std::string & setClause,
+ //    <catalogName> ""<schema_name>"".""<object_name>"",
+ //    object_type,
+ //    object_owner, -- granteeID
+-//    (select auth_db_name from AUTHS where auth_id = object_owner), --granteeName
++//    coalesce((select auth_db_name from AUTHS where auth_id = object_owner),
++//             'DB__ROOT') --granteeName
+ //    USER_GRANTEE_LIT, -- ""U""
+ //    SYSTEM_AUTH_ID,  -- system grantor ID (-2)
+ //    SYSTEM_AUTH_NAME, -- grantorName (_SYSTEM)",I wonder what would happen if the granteeName becomes DB__ROOT but the granteeID is not DB__ROOT ID (33333) but something else.
+7128,"@@ -299,6 +299,10 @@ func (install *PleaseGoInstall) compilePackage(target string, pkg *build.Package
+ 			}
+ 		}
+
++		if f := os.Getenv(""CFLAGS""); f != """" {
++			cFlags = append(cFlags, f)
++		}
++
+ 		cFiles := pkg.CFiles
+
+ 		cgoGoFiles, cgoCFiles, err := install.tc.CGO(pkg.Dir, workDir, cFlags, pkg.CgoFiles)",Feel like this should probably come into this tool as a flag rather than it just grabbing an env var internally?
+7129,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings."
+7130,"@@ -7,7 +7,7 @@ module MentorHelper
+     mail_to(
+       mentor.email,
+       I18n.t(
+-        'dashboards.show.contact_your_mentor',
++        'shared.header.contact_your_mentor',
+         mentor_name: mentor.first_name
+       )
+     )",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+7131,"@@ -90,6 +90,18 @@ class ConfigValidatorUtilTest(ForsetiTestCase):
+         actual_path = cv_data_converter.generate_ancestry_path(full_name)
+         self.assertEqual(expected_path, actual_path)
+
++    def test_generate_ancestors_for_org(self):
++        full_name = 'organization/1234567890/project/test-project-123/firewall/1234567890123456789/'
++        expected_ancestors = ['organization/1234567890', 'project/test-project-123']
++        actual_ancestors = cv_data_converter.generate_ancestors(full_name)
++        self.assertListEqual(expected_ancestors, actual_ancestors)
++
++    def test_generate_ancestors_for_folder(self):
++        full_name = 'folder/folder-1/project/project-2/lien/p123/'
++        expected_ancestors = ['folder/folder-1', 'project/project-2']
++        actual_ancestors = cv_data_converter.generate_ancestors(full_name)
++        self.assertListEqual(expected_ancestors, actual_ancestors)
++
+     def test_cleanup_dict_does_not_replace_false(self):
+         firewall = mock_cai_resources.FIREWALL_DATA
+         cv_data_converter.cleanup_dict(firewall)","nit: folders are always a numeric ID, projects as given by CAI use project number for ancestry"
+7132,"@@ -35,7 +35,12 @@ import (
+ 	""github.com/multiformats/go-multistream""
+ )
+
+-var _ p2p.Service = (*Service)(nil)
++var (
++	_ p2p.Service = (*Service)(nil)
++
++	// ErrBadNetwork indicates that it is suspected that network is currently in bad condition
++	ErrBadNetwork = errors.New(""bad network"")
++)
+
+ type Service struct {
+ 	ctx              context.Context",is this used anywhere?
+7133,"@@ -28,7 +28,6 @@ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/versioned""
+ 	""github.com/openebs/maya/pkg/debug""
+-	merrors ""github.com/openebs/maya/pkg/errors/v1alpha1""
+ 	pkg_errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/errors""",change pkg_errors to errors. Keep it consistent across all the files.
+7134,"@@ -657,7 +657,8 @@ class LocalRemote(unittest.TestCase):
+
+         resolved_results, _, returncode = get_diff_results(
+             [self._run_names[0]], [baseline_file_path], '--resolved', 'json',
+-            [""--url"", self._url])
++            [""--url"", self._url,
++             ""--review-status"", ""unreviewed"", ""confirmed"", ""false_positive""])
+         print(resolved_results)
+
+         self.assertTrue(resolved_results)",I don't see any test cases which would test that fix dates are set properly on review status changes / storage events. For this reason please create some more test cases and also check my scenarios above.
+7135,"@@ -109,6 +109,10 @@ namespace Microsoft.Rest.Generator
+             foreach (var method in client.Methods)
+             {
+                 NormalizeMethod(method);
++                if (method.DefaultResponse != null && method.DefaultResponse is CompositeType)
++                {
++                    client.Exceptions.Add((CompositeType)method.DefaultResponse);
++                }
+             }
+         }
+ ",This belongs to SwaggerModeler.cs `public override ServiceClient Build()`
+7136,"@@ -286,9 +286,11 @@ export default () => {
+      * Defines column widths in pixels. Accepts number, string (that will be converted to a number), array of numbers
+      * (if you want to define column width separately for each column) or a function (if you want to set column width
+      * dynamically on each render).
++     *
++     * Note that this option will disable {@link AutoColumnSize} plugin.
+      *
+      * @memberof Options#
+-     * @type {number|number[]|string|string[]|Function}
++     * @type {number|(number|undefined)[]|string|(string|undefined)[]|Function}
+      * @default undefined
+      *
+      * @example",We could go further and directly give the tips of the `columns` property for someone (like me) who would like to specify some column width and let the others be autosized.
+7137,"@@ -1058,8 +1058,17 @@ void VkRenderFramework::InitRenderTarget(uint32_t targets, VkImageView *dsBindin
+                                     VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
+         // Must include dep_by_region bit when src & dst both include framebuffer-space stages
+         subpass_dep.dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT;
+-        rp_info.dependencyCount = 1;
+-        rp_info.pDependencies = &subpass_dep;
++    }
++
++    if (m_additionalSubpassDependencies.size()) {
++        m_renderPass_dependencies.reserve(m_additionalSubpassDependencies.size() + m_renderPass_dependencies.size());
++        m_renderPass_dependencies.insert(m_renderPass_dependencies.end(), m_additionalSubpassDependencies.begin(),
++                                         m_additionalSubpassDependencies.end());
++    }
++
++    if (m_renderPass_dependencies.size()) {
++        rp_info.dependencyCount = static_cast<uint32_t>(m_renderPass_dependencies.size());
++        rp_info.pDependencies = m_renderPass_dependencies.data();
+     } else {
+         rp_info.dependencyCount = 0;
+         rp_info.pDependencies = nullptr;",I think a `std::copy` with `std::back_inserter` will get this done in one call.
+7138,"@@ -47,6 +47,11 @@ type cryptoSetupServer struct {
+
+ var _ CryptoSetup = &cryptoSetupServer{}
+
++// ErrHOLExperiment is returned when the client sends the FHL2 tag in the CHLO
++// this is an expiremnt implemented by Chrome in QUIC 36, which we don't support
++// TODO: remove this when dropping support for QUIC 36
++var ErrHOLExperiment = qerr.Error(qerr.InvalidCryptoMessageParameter, ""HOL experiment. Unsupported"")
++
+ // NewCryptoSetup creates a new CryptoSetup instance for a server
+ func NewCryptoSetup(
+ 	connID protocol.ConnectionID,",In the future: s/QUIC 36/Version36/ to make grepping easier
+7139,"@@ -29,11 +29,13 @@ class FileCard extends Component {
+     }
+   }
+
+-  tempStoreMeta = (ev, name) => {
++  tempStoreMeta = (ev, name, type) => {
++    var value = ev.target.value
++    if (type === 'checkbox') value = ev.target.checked ? 'on' : 'off'
+     this.setState({
+       formState: {
+         ...this.state.formState,
+-        [name]: ev.target.value
++        [name]: value
+       }
+     })
+   }",This is an example of why I prefer a flexible custom `render()` solution   'on'/'off' may not be the right value for every application. You have to make a lot of decisions even for very simple form fields :(
+7140,"@@ -568,7 +568,6 @@ func (data *TestData) deployAntreaIPSec() error {
+ func (data *TestData) deployAntreaFlowExporter(ipfixCollector string) error {
+ 	// Enable flow exporter feature and add related config params to antrea agent configmap.
+ 	ac := []configChange{
+-		{""FlowExporter"", ""true"", true},
+ 		{""flowPollInterval"", ""\""1s\"""", false},
+ 		{""activeFlowExportTimeout"", fmt.Sprintf(""\""%v\"""", exporterActiveFlowExportTimeout), false},
+ 		{""idleFlowExportTimeout"", fmt.Sprintf(""\""%v\"""", exporterIdleFlowExportTimeout), false},",we should also skip the e2e flow aggregator tests if the Flow Exporter feature is disabled.
+7141,"@@ -225,6 +225,7 @@ class ConsoleMaster(flow.FlowMaster):
+                 if err:
+                     print >> sys.stderr, ""Script load error:"", err
+                     sys.exit(1)
++                script.ObserveScripts(self, i)
+
+         if options.outfile:
+             err = self.start_stream_to_path(","We should initialize the observation in the constructor of the Script class - otherwise, we don't have this feature for mitmdump."
+7142,"@@ -172,9 +172,11 @@ class Index(IndexOpsMixin):
+             raise ValueError('Names must be a list-like')
+         internal = self._kdf._internal
+         if len(internal.index_map) != len(names):
++
+             raise ValueError('Length of new names must be {}, got {}'
+                              .format(len(internal.index_map), len(names)))
+-        names = [name if isinstance(name, tuple) else (name,) for name in names]
++
++        names = [name if isinstance(name, (tuple, type(None))) else (name,) for name in names]
+         self._kdf._internal = internal.copy(index_map=list(zip(internal.index_columns, names)))
+
+     @property",I would remove this line. Otherwise looks fine cc @ueshin
+7143,"@@ -50,7 +50,7 @@ TEST (ledger_walker, genesis_account_longer)
+
+ 	nano::ledger_walker ledger_walker{ node->ledger };
+ 	EXPECT_TRUE (ledger_walker.walked_blocks.empty ());
+-	EXPECT_EQ (1, ledger_walker.walked_blocks.bucket_count ());
++	EXPECT_LE (ledger_walker.walked_blocks.bucket_count (), 1);
+ 	EXPECT_TRUE (ledger_walker.blocks_to_walk.empty ());
+
+ 	const auto get_number_of_walked_blocks = [&ledger_walker] (const auto & start_block_hash) {",Would it be better to remove that line alltogether if it not directly relevant?
+7144,"@@ -693,6 +693,13 @@ signal_arch_init(void)
+          * compiler from optimizing it away.
+          * XXX i#641, i#639: this breaks transparency to some extent until the
+          * app uses fpu/xmm but we live with it.
++         * Given a security vulnerability and its mitigations, executing a fpu/xmm
++         * operation here might not be necessary anymore. The vulnerabilty, published on
++         * June 13, 2018, is CVE-2018-3665: ""Lazy FPU Restore"" schemes are vulnerable to
++         * the FPU state information leakage issue. The kernel-based mitigation was to
++         * automatically default to (safe) ""eager"" floating point register restore.  In
++         * this mode FPU state is saved and restored for every task/context switch
++         * regardless of whether the current process invokes FPU instructions or not.
+          */
+         __asm__ __volatile__(""movd %%xmm0, %0"" : ""=g""(rc));
+         memset(&act, 0, sizeof(act));","Does ""FPU"" here include XMM/YMM/ZMM SIMD and not just x87 FPU/MMX?"
+7145,"@@ -226,7 +226,7 @@ class TokValueFile(Token):
+         return generators.FileGenerator(s)
+
+     def spec(self):
+-        return ""<'%s'"" % strutils.bytes_to_escaped_str(self.path)
++        return ""<'%s'"" % self.path
+
+
+ TokValue = pp.MatchFirst(","I'm not sure if we need to store path as bytes, and then decode/escape it when printing or just store it as a unicode string (as done here.)"
+7146,"@@ -7,7 +7,7 @@ testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+
+
+ def test_hostname(host):
+-    assert 'instance' == host.check_output('hostname -s')
++    assert host.check_output('hostname -s') == 'instance'
+
+
+ def test_etc_molecule_directory(host):",Why is this flipped? Looks unrelated and our pattern is `expected == returned`.
+7147,"@@ -2,7 +2,11 @@
+   <%= link_to workshop do %>
+     <span class=""icon""></span>
+     <hgroup>
+-      <h5><%= t '.heading' %></h5>
++      <% if workshop.online? %>
++        <h5><%= t '.heading.online' %></h5>
++      <% else %>
++        <h5><%= t '.heading.in_person' %></h5>
++      <% end %>
+       <h4><%= workshop.name %></h4>
+     </hgroup>
+   <% end %>",Can the `h5` tags be pulled outside of the `if` block?
+7148,"@@ -2,6 +2,8 @@
+
+ namespace Shopsys\ShopBundle\Command;
+
++use Shopsys\ShopBundle\Component\Image\DirectoryStructureCreator as ImageDirectoryStructureCreator;
++use Shopsys\ShopBundle\Component\UploadedFile\DirectoryStructureCreator as UploadedFileDirectoryStructureCreator;
+ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+ use Symfony\Component\Console\Input\InputInterface;
+ use Symfony\Component\Console\Output\OutputInterface;",From @PetrHeinz review: this should be also aliased (`ImageDirectoryStructureCreator`)
+7149,"@@ -170,7 +170,7 @@ func (s *ClusterScope) AdditionalTags() infrav1.Tags {
+ 		s.AWSCluster.Spec.AdditionalTags = infrav1.Tags{}
+ 	}
+
+-	return s.AWSCluster.Spec.AdditionalTags
++	return infrav1.Tags(s.AWSCluster.Spec.AdditionalTags).DeepCopy()
+ }
+
+ // APIServerPort returns the APIServerPort to use when creating the load balancer.","Isn't AdditionalTags already of `Tags` type? If not, we should make it so, if it's not a breaking change"
+7150,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel
+ {
+     using System;",Add blank line below license header.
+7151,"@@ -24,6 +24,7 @@ func init() {
+ 	initRTC()
+ 	initUARTClock()
+ 	initI2CClock()
++	initPWMClocks()
+
+ 	// connect to UART
+ 	machine.UART0.Configure(machine.UARTConfig{})",Perhaps this could be moved into `InitPWM`? I suspect not initializing the clocks will reduce power consumption.
+7152,"@@ -0,0 +1,9 @@
++class Quiz < ActiveRecord::Base
++  validates :title, presence: true
++
++  has_many :questions, -> { order(position: :asc) }, dependent: :destroy
++
++  def first_question
++    questions.first
++  end
++end",I believe this `order` isn't tested.
+7153,"@@ -7,12 +7,13 @@
+ # include ""../../_Plugin_Helper.h""
+ # include ""../Helpers/ESPEasyStatistics.h""
+ # include ""../Static/WebStaticData.h""
+-HELPERS_ESPEASY_MATH_H
++//HELPERS_ESPEASY_MATH_H  //clumsy-stefan: what's this for?
++
++#ifdef WEBSERVER_METRICS
+ #ifdef ESP32
+ # include <esp_partition.h>
+ #endif // ifdef ESP32
+
+-
+ void handle_metrics() {
+     TXBuffer.startStream(F(""text/plain""), F(""*""));
+ ",No idea why it ended up in the code. You can remove the entire line.
+7154,"@@ -146,9 +146,10 @@ func (n *NetworkPolicyController) processClusterNetworkPolicy(cnp *secv1alpha1.C
+ 			appliedToGroupNamesForRule = append(appliedToGroupNamesForRule, atGroup)
+ 			appliedToGroupNamesSet.Insert(atGroup)
+ 		}
++		iFromPeers := n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists)
+ 		rules = append(rules, controlplane.NetworkPolicyRule{
+ 			Direction:       controlplane.DirectionIn,
+-			From:            *n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists),
++			From:            iFromPeers,
+ 			Services:        services,
+ 			Action:          ingressRule.Action,
+ 			Priority:        int32(idx),","""i"" and ""From"" is a bit duplicate, and should it be singular given the method name? I mean ""fromPeer"" or just ""from""?"
+7155,"@@ -32,6 +32,7 @@ public class TestOAuth2AuthorizationRequests {
+ 		return OAuth2AuthorizationRequest.authorizationCode()
+ 				.authorizationUri(""https://example.com/login/oauth/authorize"")
+ 				.clientId(clientId)
++				.scope(""openid"")
+ 				.redirectUri(""https://example.com/authorize/oauth2/code/registration-id"")
+ 				.state(""state"")
+ 				.additionalParameters(additionalParameters);",Did you verify this isn't going to break any existing test assumptions? We probably shouldn't modify this as we don't know what impact this is having on existing tests. It may invalidate a test that has different expectations of the scopes.
+7156,"@@ -43,12 +43,16 @@ func (a *defaultAuthorizer) Authorize(_ context.Context, claims *Claims, target
+ 	if target.Namespace == ""temporal-system"" || target.Namespace == """" {
+ 		return Result{Decision: DecisionAllow}, nil
+ 	}
+-
++	if claims == nil {
++		return Result{Decision: DecisionDeny}, nil
++	}
+ 	// Check system level permissions
+ 	if claims.System == RoleAdmin || claims.System == RoleWriter {
+ 		return Result{Decision: DecisionAllow}, nil
+ 	}
+-
++	if claims.Namespaces == nil {
++		return Result{Decision: DecisionDeny}, nil
++	}
+ 	roles, found := claims.Namespaces[target.Namespace]
+ 	if !found || roles == RoleUndefined {
+ 		return Result{Decision: DecisionDeny}, nil","technically not necessary since reading from a nil dictionary will always return found = false, so this should already be handled"
+7157,"@@ -141,6 +141,9 @@ type StatsDriver interface {
+ 	// VolumeUsageByNode returns capacity usage of all volumes and snaps for a
+ 	// given node
+ 	VolumeUsageByNode(nodeID string) (*api.VolumeUsageByNode, error)
++	// RelaxedReclaimPurge triggers the purge of RelaxedReclaim queue for a
++	// given node
++	RelaxedReclaimPurge(nodeID string) (*api.RelaxedReclaimPurge, error)
+ }
+
+ type QuiesceDriver interface {","This can return bool. RelaxedReclaimPurge(nodeID string) (bool, error)"
+7158,"@@ -60,7 +60,7 @@ public class GeneralStateReferenceTestTools {
+     final String eips =
+         System.getProperty(
+             ""test.ethereum.state.eips"",
+-            ""Frontier,Homestead,EIP150,EIP158,Byzantium,Constantinople,ConstantinopleFix,Istanbul,Berlin"");
++            ""Frontier,Homestead,EIP150,EIP158,Byzantium,Constantinople,ConstantinopleFix,Istanbul,Berlin,London"");
+     EIPS_TO_RUN = Arrays.asList(eips.split("",""));
+   }
+ ","Is there something we can do to make this automatic? At the very least, can we add Shanghai, Cancun, etc. here now so that we don't forget them?"
+7159,"@@ -129,7 +129,7 @@ def add_arguments_to_parser(parser):
+     parser.add_argument('--skip-db-cleanup',
+                         dest=""skip_db_cleanup"",
+                         action='store_true',
+-                        default=True,
++                        default=False,
+                         required=False,
+                         help=""Skip performing cleanup jobs on the database ""
+                              ""like removing unused files."")","For boolean values, I'd rather have `argparse.SUPPRESS` as default value. No need to have a `(default: False)` in the help if it's a toggle."
+7160,"@@ -251,6 +251,7 @@ func initSyncTest(t *testing.T, con consensus.Protocol, genFunc func(cst *hamt.C
+ 	chainStore := chain.NewStore(chainDS, cst, &state.TreeStateLoader{}, calcGenBlk.Cid())
+
+ 	fetcher := th.NewTestFetcher()
++	fetcher.AddSourceBlocks(calcGenBlk)
+ 	syncer := chain.NewSyncer(con, chainStore, fetcher, syncMode) // note we use same cst for on and offline for tests
+
+ 	// Initialize stores to contain dstP.genesis block and state","The genesis block needs to exist in the store the fetcher pulls from, this is because the fetcher will stop fetching when it finds a block it has seen before and this can sometimes be the genesis block."
+7161,"@@ -1111,7 +1111,7 @@ func (c *linuxContainer) Checkpoint(criuOpts *CriuOpts) error {
+ 			return err
+ 		}
+
+-		err = ioutil.WriteFile(filepath.Join(criuOpts.ImagesDirectory, descriptorsFilename), fdsJSON, 0655)
++		err = ioutil.WriteFile(filepath.Join(criuOpts.ImagesDirectory, descriptorsFilename), fdsJSON, 0600)
+ 		if err != nil {
+ 			return err
+ 		}","should we do the same for os.Mkdir(criuOpts.WorkDirectory, 0755)?"
+7162,"@@ -87,7 +87,8 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
+         .replace('<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML""', '<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML"" flattenhtml=""true""')
+         .replace(pageVisibility, bravePageVisibility + pageVisibility)
+         .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
+-        .replace(/Automatically sends usage statistics and crash reports to Brave/g, 'Automatically sends crash reports to Brave')
++        .replace(/Automatically send usage statistics and crash reports to Google/g, 'Automatically send crash reports to Google')
++        .replace(/Automatically sends usage statistics and crash reports to Google/g, 'Automatically sends crash reports to Google')
+         .replace(/The Chromium Authors/g, 'Brave Software Inc')
+         .replace(/Google Chrome/g, 'Brave')
+         .replace(/Chromium/g, 'Brave')",@bbondy Two messages because the label and description differ very slightly in their wording...
+7163,"@@ -134,7 +134,10 @@ unit_test_get_ymm_caller_saved()
+     register __m256 ymm15 asm(""ymm15"");
+ #        endif
+
+-    for (int regno = 0; regno < proc_num_simd_registers(); ++regno) {
++    /* The function get_ymm_caller_saved is intended to be used for AVX (no AVX-512). It
++     * currently doesn't cover extended AVX-512 registers.
++     */
++    for (int regno = 0; regno < proc_num_simd_sse_avx_registers(); ++regno) {
+         for (int dword = 0; dword < sizeof(dr_ymm_t) / sizeof(uint); ++dword) {
+             get_buffer[regno].u32[dword] = 0;
+             ref_buffer[regno].u32[dword] = base++;","""currently"" implies it should and will be changed: so TODO i#?"
+7164,"@@ -1,8 +1,14 @@
+ import { translationMacro as t } from 'ember-i18n';
+ import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
++import Ember from 'ember';
++
++const { computed } = Ember;
++
+ export default AbstractIndexRoute.extend({
+   modelName: 'imaging',
+-  pageTitle: t('imaging.pageTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('imaging.pageTitle');
++  }),
+   searchStatus: 'Requested',
+
+   _getStartKeyFromItem(item) {",This should be `computed('i18n.locale'....`
+7165,"@@ -12,7 +12,6 @@ class CommitFlag::BackToLifeTest < ActiveSupport::TestCase
+     btl = CommitFlag::BackToLife.find(cf.id)
+     btl.time_elapsed = 123.0
+     btl.save!
+-    btl.reload
+     btl.time_elapsed.must_equal 123.0
+   end
+ end","Wait, does this not work if we do `btl.reload`? That seems odd that we have to have the object in the same state."
+7166,"@@ -22,9 +22,7 @@ define(['playbackManager', 'focusManager', 'appRouter', 'dom'], function (playba
+
+     var eventListenerCount = 0;
+     function on(scope, fn) {
+-        if (eventListenerCount) {
+-            eventListenerCount++;
+-        }
++        eventListenerCount++;
+         dom.addEventListener(scope, 'command', fn, {});
+     }
+ ",I seem to recall this being the cause of a bug at some point.
+7167,"@@ -1648,6 +1648,7 @@ public class LFMainActivity extends SharedMediaActivity {
+             menu.setGroupVisible(R.id.photos_option_men, false);
+             menu.findItem(R.id.all_photos).setVisible(!editMode && !hidden);
+             menu.findItem(R.id.search_action).setVisible(!editMode);
++            menu.findItem(R.id.settings).setVisible(false);
+
+             if (getAlbums().getSelectedCount() >= 1) {
+                 if (getAlbums().getSelectedCount() > 1) {",Can you remove it from the menu instead of setting it hidden? Or are there any other trouble?
+7168,"@@ -32,6 +32,7 @@ import (
+ 	reflect ""reflect""
+
+ 	gomock ""github.com/golang/mock/gomock""
++	execution ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	persistence ""github.com/temporalio/temporal/common/persistence""
+ )
+ ","And for ""execution ""."
+7169,"@@ -34,6 +34,8 @@ module Bolt
+           search_dirs << mod.plugins if mod.plugins?
+           search_dirs << mod.pluginfacts if mod.pluginfacts?
+           search_dirs << mod.files if mod.files?
++          type_files = ""#{mod.path}/types""
++          search_dirs << type_files if File.exist?(type_files)
+           search_dirs
+         end
+       end",Do agents usually download these from puppetserver when applying a catalog?
+7170,"@@ -68,6 +68,14 @@ PONY_API int pony_asio_event_fd(asio_event_t* ev)
+   return ev->fd;
+ }
+
++PONY_API bool pony_asio_event_get_disposable(asio_event_t* ev)
++{
++  if(ev == NULL)
++    return false;
++
++  return (ev->flags & ASIO_DISPOSABLE) != 0;
++}
++
+ PONY_API bool pony_asio_event_get_writeable(asio_event_t* ev)
+ {
+   if(ev == NULL)",This should be `return (ev->flags == ASIO_DISPOSABLE);` because `ASIO_DISPOSABLE` has a value of `0` as defined in the enum in `asio.h` and because when `ev->flags` is assigned `ASIO_DISPOSABLE` it is assigned as `ev->flags = ASIO_DISPOSABLE` unsetting any other flags previously assigned.
+7171,"@@ -68,7 +68,8 @@ namespace Examples.Console
+                 providerBuilder
+                     .AddOtlpExporter(o =>
+                     {
+-                        o.MetricExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
++                        o.MetricReaderType = MetricReaderType.Periodic;
++                        o.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
+                         o.AggregationTemporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
+                     });
+             }","this is not required, right? its the default already..."
+7172,"@@ -49,6 +49,11 @@ const (
+ 	// to indicate that a reader has requested to read a TLF ID that
+ 	// has been finalized, which isn't allowed.
+ 	StatusCodeServerErrorCannotReadFinalizedTLF = 2812
++	// StatusCodeServerErrorRequiredLockIsNotHeld is the error code returned by
++	// a MD write operation to indicate that a lockID that client required the
++	// write to be contingent to is not held at the time server tries to commit
++	// the MD, and as a result the MD is not written.
++	StatusCodeServerErrorRequiredLockIsNotHeld = 2813
+ )
+
+ // ServerError is a generic server-side error.","""contingent to"" -> ""contingent on"""
+7173,"@@ -19,6 +19,14 @@ Exceptions/Errors used in Koalas.
+ """"""
+
+
++class GroupByError(Exception):
++    pass
++
++
++class DataError(GroupByError):
++    pass
++
++
+ class SparkPandasIndexingError(Exception):
+     pass
+ ",Does pandas throw an exception like this?
+7174,"@@ -538,14 +538,14 @@ cvdescriptorset::AllocateDescriptorSetsData::AllocateDescriptorSetsData(uint32_t
+
+ cvdescriptorset::DescriptorSet::DescriptorSet(const VkDescriptorSet set, const VkDescriptorPool pool,
+                                               const std::shared_ptr<DescriptorSetLayout const> &layout, uint32_t variable_count,
+-                                              CoreChecks *dev_data)
++                                              cvdescriptorset::DescriptorSet::StateTracker *state_data)
+     : some_update_(false),
+       set_(set),
+       pool_state_(nullptr),
+       p_layout_(layout),
+-      device_data_(dev_data),
++      state_data_(state_data),
+       variable_count_(variable_count) {
+-    pool_state_ = dev_data->GetDescriptorPoolState(pool);
++    pool_state_ = state_data->GetDescriptorPoolState(pool);
+     // Foreach binding, create default descriptors of given type
+     descriptors_.reserve(p_layout_->GetTotalDescriptorCount());
+     for (uint32_t i = 0; i < p_layout_->GetBindingCount(); ++i) {",The point of the exercise has been to eliminate CoreChecks as an object dependency for DescriptorSet et. al.
+7175,"@@ -34,7 +34,7 @@ import static org.apache.iceberg.TableProperties.DEFAULT_NAME_MAPPING;
+ /**
+  * Context object with optional arguments for a Flink Scan.
+  */
+-class ScanContext implements Serializable {
++public class ScanContext implements Serializable {
+
+   private static final long serialVersionUID = 1L;
+ ",Why do we need to make so much more of this ScanContext public?
+7176,"@@ -54,7 +54,6 @@ class ProductFilterFormType extends AbstractType
+                 'choices' => $config->getFlagChoices(),
+                 'choice_label' => 'name',
+                 'choice_value' => 'id',
+-                'choice_name' => 'id',
+                 'multiple' => true,
+                 'expanded' => true,
+             ])",is choice_name not needed anymore?
+7177,"@@ -226,6 +226,9 @@ public class Parquet {
+       set(""parquet.avro.write-old-list-structure"", ""false"");
+       MessageType type = ParquetSchemaUtil.convert(schema, name);
+
++      // Check that our metrics make sense
++      metricsConfig.validateProperties(schema);
++
+       if (createWriterFunc != null) {
+         Preconditions.checkArgument(writeSupport == null,
+             ""Cannot write with both write support and Parquet value writer"");","Is this the right place to do the validation? If a user adds a bad property or performs some schema update that causes a validation error, that would break all writes to the table. To me, it doesn't seem like we are catching the problem early enough and possibly allowing a typo to break scheduled jobs. What do you think about adding this validation when altering the table? `UpdateProperties` could check whether any properties starting with `write.metadata.metrics` were modified and run this. Similarly, `UpdateSchema` could run this as well, although I think that we should probably modify `UpdateSchema` to simply update the properties for column renames (if that's easily done)."
+7178,"@@ -2467,11 +2467,17 @@ hipError_t hipHccGetAcceleratorView(hipStream_t stream, hc::accelerator_view** a
+ namespace hip_impl {
+     std::vector<hsa_agent_t> all_hsa_agents() {
+         std::vector<hsa_agent_t> r{};
+-        for (auto&& acc : hc::accelerator::get_all()) {
++        auto accelerators = hc::accelerator::get_all();
++        for (int i = 0; i < accelerators.size(); i++) {
++            auto&& acc = accelerators[i];
+             const auto agent = acc.get_hsa_agent();
+
+             if (!agent || !acc.is_hsa_accelerator()) continue;
+
++            // If device is not in visible devices list, ignore
++            if (std::find(g_hip_visible_devices.begin(), g_hip_visible_devices.end(), (i - 1)) ==
++                    g_hip_visible_devices.end()) continue;
++
+             r.emplace_back(*static_cast<hsa_agent_t*>(agent));
+         }
+ ",Why is this necessary? Just in order to get an indexed loop?
+7179,"@@ -68,6 +68,7 @@ type poolSyncMetrics struct {
+ 	zpoolLastSyncTime             *prometheus.GaugeVec
+ 	zpoolStateUnknown             *prometheus.GaugeVec
+ 	zpoolLastSyncTimeCommandError *prometheus.GaugeVec
++	zpoolListRequestRejectCounter prometheus.Gauge
+ }
+
+ // poolfields struct is for pool last sync time metric","instead of using `prometheus.Gauge`, using `promethus.Counter` will be better."
+7180,"@@ -23,5 +23,9 @@ module Ncr
+     def whsc?
+       code == WHSC_CODE
+     end
++
++    def ba_6x_tier1_team?
++      code.match(/^P11[7J4T1ACZ]....$/)
++    end
+   end
+ end",maybe we should have a unit test for this and then just test one case in `spec/services/ncr/approval_manager_spec.rb` ?
+7181,"@@ -21,8 +21,9 @@ class CommunicartsController < ApplicationController
+   def approval_response
+     cart = Cart.find(params[:cart_id]).decorate
+     client_data = cart.proposal.client_data_legacy
+-    approval = cart.approvals.find_by(user_id: user_id)
+-
++    approval = cart.approvals.find_by(user_id: user_id)
++    @token ||= ApiToken.find_by(approval_id: approval.id)
++
+     if !approval.pending?
+       flash[:error] = ""You have already logged a response for Cart #{client_data.public_identifier}""
+     else",Why is this necessary?
+7182,"@@ -320,7 +320,7 @@ public class Spark3Util {
+     }
+   }
+
+-  private static DistributionMode getDistributionMode(org.apache.iceberg.Table table) {
++  public static DistributionMode getDistributionMode(org.apache.iceberg.Table table) {
+     boolean isSortedTable = !table.sortOrder().isUnsorted();
+     String defaultModeName = isSortedTable ? WRITE_DISTRIBUTION_MODE_RANGE : WRITE_DISTRIBUTION_MODE_DEFAULT;
+     String modeName = table.properties().getOrDefault(WRITE_DISTRIBUTION_MODE, defaultModeName);","Minor: If this is going to be public, we should fix the name. `get` doesn't add any value. How about `distributionModeFor` instead?"
+7183,"@@ -16,7 +16,10 @@ from mitmproxy.tools.console import eventlog
+
+
+ class StackWidget(urwid.Frame):
+-    def __init__(self, widget, title, focus):
++    def __init__(self, window, widget, title, focus):
++        self.f = focus
++        self.window = window
++
+         if title:
+             header = urwid.AttrWrap(
+                 urwid.Text(title),",This needs a more self-explaining name. Maybe `.is_focused`?
+7184,"@@ -174,11 +174,17 @@ var rubyAzureMappings = {
+   'parameter_grouping':['../../dev/TestServer/swagger/azure-parameter-grouping.json', 'ParameterGroupingModule']
+ };
+
++var goAzureMappings = {
++  'paging':['../../dev/TestServer/swagger/paging.json','paginggroup'],
++  'azurereport':['../../dev/TestServer/swagger/azure-report.json', 'azurereport']
++};
++
+ gulp.task('regenerate:expected', function(cb){
+   runSequence('regenerate:delete',
+     [
+-      'regenerate:expected:csazure',
+       'regenerate:expected:cs',
++      'regenerate:expected:csazure',
++      'regenerate:expected:csazurefluent',
+       'regenerate:expected:node',
+       'regenerate:expected:nodeazure',
+       'regenerate:expected:ruby',","minor: I'd add a space between `,` & `'paginggroup'`."
+7185,"@@ -42,10 +42,8 @@ def main():
+
+     push_p = subparsers.add_parser(""push"")
+     push_p.add_argument(""package"", type=str, help=""Owner/Package Name"")
+-    push_p.set_defaults(func=command.push)
+-
+-    push_p = subparsers.add_parser(""push"")
+-    push_p.add_argument(""package"", type=str, help=""Owner/Package Name"")
++    push_p.add_argument(""--reupload"", action=""store_true"",
++                        help=""Re-upload all fragments, even the ones the server already has"")
+     push_p.set_defaults(func=command.push)
+
+     version_p = subparsers.add_parser(""version"")","""Re-upload all fragments (even if fragment is already in registry)"""
+7186,"@@ -813,11 +813,15 @@ type PrometheusRuleSpec struct {
+ // upstream Prometheus struct definitions don't have json struct tags.
+
+ // RuleGroup is a list of sequentially evaluated recording and alerting rules.
++// Note: PartialResponseStrategy is only used by ThanosRuler and will
++// be ignored by Prometheus instances.  Valid values for this field are 'warn'
++// or 'abort'.  More info: https://github.com/thanos-io/thanos/blob/master/docs/components/rule.md#partial-response
+ // +k8s:openapi-gen=true
+ type RuleGroup struct {
+-	Name     string `json:""name""`
+-	Interval string `json:""interval,omitempty""`
+-	Rules    []Rule `json:""rules""`
++	Name                    string `json:""name""`
++	Interval                string `json:""interval,omitempty""`
++	Rules                   []Rule `json:""rules""`
++	PartialResponseStrategy string `json:""partial_response_strategy,omitempty""`
+ }
+
+ // Rule describes an alerting or recording rule.",I don't see us ignoring the field. Are we sure Prometheus wouldn't refuse to load the rules?
+7187,"@@ -314,7 +314,7 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
+         super.onResume();
+         if (isVisible() || mIsInVRVideoMode) {
+             mSession.setActive(true);
+-            if (!SettingsStore.getInstance(getContext()).getLayersEnabled()) {
++            if (!SettingsStore.getInstance(getContext()).getLayersEnabled() && !mSession.hasDisplay()) {
+                 // Ensure the Gecko Display is correctly recreated.
+                 // See: https://github.com/MozillaReality/FirefoxReality/issues/2880
+                 callSurfaceChanged();",I wonder if we can just check if the mSession is active and then only call `setActive(true)` and `callSurfaceChanged()` if it isn't?
+7188,"@@ -1336,6 +1336,8 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		""OFF""),
+
+  SDDui___(EXE_MEMORY_FOR_PROBE_CACHE_IN_MB,	""100""),
+
++ SDDui___(EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB,	""100""),
++
+   // lower-bound memory limit for BMOs/nbmos (in MB)
+   DDui___(EXE_MEMORY_LIMIT_LOWER_BOUND_EXCHANGE, ""10""),
+   DDui___(EXE_MEMORY_LIMIT_LOWER_BOUND_MERGEJOIN, ""10""),","A default value of 100 MB maybe too small. I understand that this is good for mixed workloads, but do consider than plans with Unpack, especially when used for insert/upsert are simple. Unpack is always serial and part of master exe. Often there is only one in a query. The cost of having a low value here seems to be that queue length from unpack could be limited by this when we are loading a table with wide rows (even if actual data in row is not wide). We know from performance runs that queue length is critical to upsert load performance. This is a hunch on my part and could be misguided. It will be good to performance test for upsert of table with wide rows, if you think that is worthwhile."
+7189,"@@ -32,8 +32,8 @@ type (
+ 		GetByOwner(address.Address) *Candidate
+ 		GetBySelfStakingIndex(uint64) *Candidate
+ 		Upsert(*Candidate) error
+-		CreditBucketPool(*big.Int, bool) error
+-		DebitBucketPool(*big.Int, bool, bool) error
++		CreditBucketPool(*big.Int) error
++		DebitBucketPool(*big.Int, bool) error
+ 		Commit() error
+ 	}
+ ","think we should pass in ctx, and use ctx.GreenlandHeight inside bucketPool to determine if create or not"
+7190,"@@ -153,7 +153,7 @@ public class I18nTest extends JUnit4TestBase {
+     assertThat(ime.isActivated()).isTrue();
+     assertThat(ime.getActiveEngine()).isEqualTo(desiredEngine);
+
+-    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to convert the word.
++    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to transform the word.
+     input.sendKeys(""toukyou "");
+     input.sendKeys(Keys.ENTER);
+ ",A correct by unrelated change. We'll slide this one in without another word ;)
+7191,"@@ -1,5 +1,4 @@
+ <%= semantic_form_for checkout, url: checkouts_path(checkout.plan), html: { method: 'post' } do |form| %>
+-  <%= form.semantic_errors %>
+
+   <%= form.inputs do %>
+     <% if signed_out? %>",Why remove this?
+7192,"@@ -11,7 +11,7 @@ use Shopsys\FrameworkBundle\Component\Router\Security\RouteCsrfProtector;
+ use Symfony\Component\HttpFoundation\Request;
+ use Symfony\Component\HttpFoundation\RequestStack;
+ use Symfony\Component\Routing\Router;
+-use Twig_Environment;
++use Twig\Environment;
+
+ class GridTest extends TestCase
+ {","I still see some usages of not namespaced variants (look for Twig_ in project, about 42 matches). Is it intentional?"
+7193,"@@ -22,11 +22,11 @@ import (
+ 	""sync""
+ 	""time""
+
+-	""github.com/aws/amazon-ecs-agent/agent/api""
+ 	""github.com/aws/amazon-ecs-agent/agent/resources/cgroup""
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ioutilwrapper""
+ 	""github.com/cihub/seelog""
+ 	""github.com/containerd/cgroups""
++	specs ""github.com/opencontainers/runtime-spec/specs-go""
+ 	""github.com/pkg/errors""
+ )
+ ",Is this a new dependency? Does this require a dep update?
+7194,"@@ -62,6 +62,8 @@ bool Print(T val, Type type, int /*indent*/, Type * /*union_type*/,
+
+   if (type.base_type == BASE_TYPE_BOOL) {
+     text += val != 0 ? ""true"" : ""false"";
++  } else if (opts.generate_hexfloat_in_json && (type.base_type == BASE_TYPE_FLOAT || type.base_type == BASE_TYPE_DOUBLE)) {
++    text += FloatToStringtStringHex(val);
+   } else {
+     text += NumToString(val);
+   }",> opts.generate_hexfloat_in_json && **IsFloat**(type.base_type)
+7195,"@@ -7,4 +7,5 @@ package archer
+ type Manifest interface {
+ 	Marshal() ([]byte, error)
+ 	DockerfilePath() string
++	AppName() string
+ }","As an alternative to this, we could also create a new method, like `Common() *AppManifest` This way we don't have to add a new method to the interface everytime we add a new field to the `AppManifest`. This is a nit though so it's up to you."
+7196,"@@ -28,6 +28,7 @@ script_deps = {
+         ""urwid>=1.1"",
+         ""lxml>=3.3.6"",
+         ""Pillow>=2.3.0"",
++        ""harparser"",
+     },
+     ""mitmdump"": set()
+ }","As long as we have this feature as an inline script, I'm inclined to remove the dependency here. I'd suggest that we just try to import harparser and pytz and throw an error instructing the user to install the dependencies (catch for `ImportError`). In the long term, we probably want to include that in the mitmproxy core, but we first want to introduce a clean extension interface before that's going to happen. As soon as said interface is there, porting the inline script and adding the dependency again should be a breeze."
+7197,"@@ -0,0 +1,4 @@
++// set the base folder of this project
++global.basefolder = `${__dirname}`
++require (""rechoir"").prepare(require('interpret').extensions, './.gulp/gulpfile.iced');
++require ('./.gulp/gulpfile.iced')",makes it work nice with vscode. all logic is now in `.gulp/*.iced` files
+7198,"@@ -27,7 +27,7 @@ public interface SearchContext {
+    * @return A list of all {@link WebElement}s, or an empty list if nothing matches
+    * @see org.openqa.selenium.By
+    */
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",should a similar change be done for findElement?
+7199,"@@ -2745,7 +2745,7 @@ TEST (node, local_votes_cache)
+ 	{
+ 		ASSERT_NO_ERROR (system.poll (node.aggregator.max_delay));
+ 	}
+-	ASSERT_TIMELY (3s, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes) == 3);
++	ASSERT_TIMELY (3s, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes)+node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_cached_late_votes) == 3);
+ 	ASSERT_FALSE (node.history.votes (send1->root (), send1->hash ()).empty ());
+ 	ASSERT_FALSE (node.history.votes (send2->root (), send2->hash ()).empty ());
+ 	ASSERT_FALSE (node.history.votes (send3->root (), send3->hash ()).empty ());",`+` -> ` + ` I guess. Same below
+7200,"@@ -109,9 +109,8 @@ function TransactionBuilder(opts) {
+   this.lockTime = opts.lockTime || 0;
+   this.spendUnconfirmed = opts.spendUnconfirmed || false;
+
+-  if (opts.fee || opts.feeSat) {
+-    this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
+-  }
++  this.givenFeeSat = typeof(opts.fee) !== 'undefined' ? opts.fee * util.COIN : opts.feeSat;
++
+   this.remainderOut = opts.remainderOut;
+   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
+ ","`typeof` is not a function - its an operator, and the standard way to use it is as `typeof foo !== ...` (i.e. no parenthesis). Also, I would personally use `opts.fee != null` instead (with a non-strict comparison, which also identifies `undefined` values because `null == undefined`)."
+7201,"@@ -855,6 +855,7 @@ class ReaderTest < Minitest::Test
+       end
+
+       test 'unreadable file referenced by include directive is replaced by warning' do
++        next if windows? # JRuby on Windows runs this even with the conditional on the block
+         include_file = File.join DIRNAME, 'fixtures', 'chapter-a.adoc'
+         FileUtils.chmod 0000, include_file
+         input = <<~'EOS'",Is there a reason why you're not using Rspec `skip`? It allows to specify message and makes it clearly visible in test results which tests were skipped.
+7202,"@@ -36,6 +36,10 @@ type ClusterSyncStatus struct {
+ 	// Conditions is a list of conditions associated with syncing to the cluster.
+ 	// +optional
+ 	Conditions []ClusterSyncCondition `json:""conditions,omitempty""`
++
++	// FirstSyncSetsSuccessTime is the time we first successfully applied all (selector)syncsets to a cluster.
++	// +optional
++	FirstSyncSetsSuccessTime *metav1.Time `json:""firstSyncSetsSuccessTime,omitempty""`
+ }
+
+ // SyncStatus is the status of applying a specific SyncSet or SelectorSyncSet to the cluster.","how about ""all matching SyncSets and SelectorSyncSets"""
+7203,"@@ -331,7 +331,7 @@ void Storage::PopulateLayout(DataLayout &layout)
+
+     // load geometries sizes
+     {
+-        io::FileReader reader(config.geometries_path, io::FileReader::HasNoFingerprint);
++        io::FileReader reader(config.geometries_path, io::FileReader::VerifyFingerprint);
+
+         const auto number_of_geometries_indices = reader.ReadVectorSize<unsigned>();
+         layout.SetBlockSize<unsigned>(DataLayout::GEOMETRIES_INDEX, number_of_geometries_indices);","What is the logic behind `ReadVectorSize` reading `CountElement64`, then skipping `T` (in this case `unsigned`)? Naming doesn't cover what's actually happening here. Ideally I'd also take this through a `files` layer, any input as to how?"
+7204,"@@ -24,6 +24,7 @@ import org.apache.solr.common.params.CommonParams;
+ import org.apache.solr.core.CoreContainer;
+ import org.apache.solr.core.SolrCore;
+
++import javax.servlet.ServletException;
+ import javax.servlet.http.HttpServletRequest;
+ import javax.servlet.http.HttpServletResponse;
+ ",This looks like an unused import to me?
+7205,"@@ -231,13 +231,13 @@ func taskListInfoFromBlob(b []byte, proto string) (*sqlblobs.TaskListInfo, error
+ 	return result, thriftRWDecode(b, proto, result)
+ }
+
+-func transferTaskInfoToBlob(info *sqlblobs.TransferTaskInfo) (p.DataBlob, error) {
+-	return thriftRWEncode(info)
++func TransferTaskInfoToBlob(info *persistenceblobs.TransferTaskInfo) (p.DataBlob, error) {
++	return protoRWEncode(info)
+ }
+
+-func transferTaskInfoFromBlob(b []byte, proto string) (*sqlblobs.TransferTaskInfo, error) {
+-	result := &sqlblobs.TransferTaskInfo{}
+-	return result, thriftRWDecode(b, proto, result)
++func TransferTaskInfoFromBlob(b []byte, proto string) (*persistenceblobs.TransferTaskInfo, error) {
++	result := &persistenceblobs.TransferTaskInfo{}
++	return result, protoRWDecode(b, proto, result)
+ }
+
+ func TimerTaskInfoToBlob(info *persistenceblobs.TimerTaskInfo) (p.DataBlob, error) {","`RW` means read/write. Why do we have it here, as part of a func name?"
+7206,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...
+7207,"@@ -1051,7 +1051,11 @@ static ssize_t expect_preface(h2o_http2_conn_t *conn, const uint8_t *src, size_t
+     }
+
+     { /* send SETTINGS and connection-level WINDOW_UPDATE */
+-        h2o_iovec_t vec = h2o_buffer_reserve(&conn->_write.buf, SERVER_PREFACE.len);
++        h2o_iovec_t vec = h2o_buffer_try_reserve(&conn->_write.buf, SERVER_PREFACE.len);
++        if (vec.base == NULL) {
++            *err_desc = ""failed to allocate memory"";
++            return H2O_HTTP2_ERROR_PROTOCOL_CLOSE_IMMEDIATELY;
++        }
+         memcpy(vec.base, SERVER_PREFACE.base, SERVER_PREFACE.len);
+         conn->_write.buf->size += SERVER_PREFACE.len;
+         if (conn->http2_origin_frame) {",I think you missed this.
+7208,"@@ -145,6 +145,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             return _requestStream.ReadAsync(buffer, offset, count, cancellationToken);
+         }
+
++#if NETCOREAPP2_1
++        public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)
++        {
++            return _requestStream.ReadAsync(destination, cancellationToken);
++        }
++#endif
++
+         public override Task CopyToAsync(Stream destination, int bufferSize, CancellationToken cancellationToken)
+         {
+             return _requestStream.CopyToAsync(destination, bufferSize, cancellationToken);",List all of the current TFMs so we know if this gets outdated. E.g. this breaks if we add 2.2.
+7209,"@@ -811,6 +811,12 @@ func (s *VolumeServer) mergeVolumeSpecs(vol *api.VolumeSpec, req *api.VolumeSpec
+ 		spec.ExportSpec = vol.GetExportSpec()
+ 	}
+
++	// Xattr
++	if req.GetXattr() >= 0 {
++		spec.Xattr = req.GetXattr()
++	} else {
++		spec.Xattr = vol.GetXattr()
++	}
+ 	return spec
+ }
+ ","here, you want to use req.GetXattrOpt() referring to the in line 514 of api.proto. This will be nil if not provided. See the example above on line 801 on this file"
+7210,"@@ -952,7 +952,14 @@ public class LocalPSMP extends PlaybackServiceMediaPlayer {
+                 // Load next episode if previous episode was in the queue and if there
+                 // is an episode in the queue left.
+                 // Start playback immediately if continuous playback is enabled
+-                nextMedia = callback.getNextInQueue(currentMedia);
++
++                // Repeat episode implementation
++                if (UserPreferences.repeatEpisode() && !wasSkipped) {
++                    nextMedia = currentMedia;
++                    nextMedia.setPosition(0);
++                } else {
++                    nextMedia = callback.getNextInQueue(currentMedia);
++                }
+
+                 boolean playNextEpisode = isPlaying &&
+                         nextMedia != null &&","I think this should be done outside LocalPSMP, but in `getNextInQueue`. The reason is that I want to reduce the dependence of the media players on the preferences and database. Also, it will then probably work on Chromecast."
+7211,"@@ -143,7 +143,9 @@ struct _hiprtcProgram {
+     {
+         using namespace std;
+
+-        name = hip_impl::demangle(name.c_str());
++        char* demangled = hip_impl::demangle(name.c_str());
++        name.assign(demangled == nullptr ? """" : demangled);
++        free(demangled);
+
+         if (name.empty()) return name;
+ ",Please remove it or remove all `std::` namespace prefixes.
+7212,"@@ -0,0 +1,17 @@
++// Copyright (C) 2019-2020 Algorand, Inc.
++// This file is part of go-algorand
++//
++// go-algorand is free software: you can redistribute it and/or modify
++// it under the terms of the GNU Affero General Public License as
++// published by the Free Software Foundation, either version 3 of the
++// License, or (at your option) any later version.
++//
++// go-algorand is distributed in the hope that it will be useful,
++// but WITHOUT ANY WARRANTY; without even the implied warranty of
++// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++// GNU Affero General Public License for more details.
++//
++// You should have received a copy of the GNU Affero General Public License
++// along with go-algorand.  If not, see <https://www.gnu.org/licenses/>.
++
++package nodecontrol",wait! I'm confused - is that an empty file ?!
+7213,"@@ -19,14 +19,14 @@ var phrasingElements = ['A', 'EM', 'STRONG', 'SMALL', 'MARK', 'ABBR', 'DFN', 'I'
+  * @param {HTMLElement} element The HTMLElement
+  * @return {HTMLElement} The label element, or null if none is found
+  */
+-function findLabel({ actualNode }) {
++function findLabel(virtualNode) {
+ 	let label;
+-	if (actualNode.id) {
++	if (virtualNode.actualNode.id) {
+ 		label = dom.findElmsInContext({
+-			elm: 'label', attr: 'for', value: actualNode.id, context: actualNode
++			elm: 'label', attr: 'for', value: virtualNode.actualNode.id, context: virtualNode.actualNode
+ 		})[0];
+ 	} else {
+-		label = dom.findUp(actualNode, 'label');
++		label = dom.findUpVirtual(virtualNode, 'label');
+ 	}
+ 	return axe.utils.getNodeFromTree(axe._tree[0], label);
+ }",These should all call `findUpVirtual`.
+7214,"@@ -105,7 +105,7 @@ class HierarchicHTTPRequest(HTTPRequest):
+             file_dict[""path""] = path
+
+             mime = mimetypes.guess_type(file_dict[""path""])[0] or ""application/octet-stream""
+-            file_dict.get('mime-type', mime)
++            file_dict[""mime-type""] = mime
+         self.content_encoding = self.config.get('content-encoding', None)
+
+ ","This changes the behavior. Original behavior was ""set if not set"", while new is ""just set""."
+7215,"@@ -110,7 +110,7 @@ public final class DefaultBearerTokenResolver implements BearerTokenResolver {
+ 				throw new OAuth2AuthenticationException(error);
+ 			}
+
+-			return matcher.group(""token"");
++			return authorization.substring(7);
+ 		}
+ 		return null;
+ 	}",Let's keep using the regular expression to make sure that the token is well-formed. I think the regular expression should be altered instead of doing a substring.
+7216,"@@ -26,10 +26,10 @@ public final class Array<T> implements Kind1<Array<?>, T>, IndexedSeq<T>, Serial
+
+     private static final Array<?> EMPTY = new Array<>(new Object[0]);
+
+-    private final Object[] back;
++    private final Object[] delegate;
+
+-    private Array(Object[] back) {
+-        this.back = back;
++    private Array(Object[] delegate) {
++        this.delegate = delegate;
+     }
+
+     static <T> Array<T> wrap(Object[] array) {","All the operations are delegated to this entity, hence the rename. `back` can have too many meanings."
+7217,"@@ -561,16 +561,9 @@ module Beaker
+
+       block_on host do |host|
+         skip_msg = host.skip_set_env?
+-        if skip_msg.nil?
+-          env = construct_env(host, opts)
+-          logger.debug(""setting local environment on #{host.name}"")
+-          if host['platform'] =~ /windows/ and host.is_cygwin?
+-            env['CYGWIN'] = 'nodosfilewarning'
+-          end
+-          host.ssh_permit_user_environment
+-          host.ssh_set_user_environment(env)
+-        else
+-          logger.debug(skip_msg)
++        unless skip_msg.nil?
++            logger.debug( skip_msg )
++            next
+         end
+
+         if skip_msg.nil?","@trevor-vaughan it looks like the spec failures are caused by the fact that although it was a great idea to put the guard clause here first & get the error case out of the way, the main code path has been erased when I assume it should be just below the guard clause."
+7218,"@@ -22,6 +22,7 @@ import (
+ 	""github.com/algorand/go-algorand/config""
+ 	""github.com/algorand/go-algorand/data/basics""
+ 	""github.com/algorand/go-algorand/logging""
++	""github.com/algorand/go-algorand/protocol""
+ )
+
+ var filterTimeout = 2 * config.Protocol.SmallLambda",Could you delete this constant?
+7219,"@@ -2,6 +2,7 @@
+ // The .NET Foundation licenses this file to you under the MIT license.
+ // See the LICENSE file in the project root for more information.
+
++using BenchmarkDotNet.Disassemblers;
+ using BenchmarkDotNet.Exporters;
+ using BenchmarkDotNet.Loggers;
+ using BenchmarkDotNet.Parameters;",looks like this snuck in from your other change?
+7220,"@@ -10,11 +10,6 @@ module Ncr
+   BUILDING_NUMBERS = YAML.load_file(""#{Rails.root}/config/data/ncr/building_numbers.yml"")
+
+   class WorkOrder < ActiveRecord::Base
+-      NCR_BA61_TIER1_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA61_TIER1_BUDGET_MAILBOX'] || 'communicart.budget.approver+ba61@gmail.com'
+-      NCR_BA61_TIER2_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA61_TIER2_BUDGET_MAILBOX'] || 'communicart.ofm.approver@gmail.com'
+-      NCR_BA80_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA80_BUDGET_MAILBOX'] || 'communicart.budget.approver+ba80@gmail.com'
+-      OOL_BA80_BUDGET_APPROVER_MAILBOX = ENV['NCR_OOL_BA80_BUDGET_MAILBOX'] || 'communicart.budget.approver+ool_ba80@gmail.com'
+-
+     # must define before include PurchaseCardMixin
+     def self.purchase_amount_column_name
+       :amount","These env vars are not set in any CF environment, on purpose, because we are moving away from using env vars to store role-based information and instead using the database. So in a CF environment, the wrong emails get used (the defaults, rather than what is in the db)."
+7221,"@@ -1,4 +1,4 @@
+-<%# locals: { question, answer, readonly, locking } %>
++<%# locals: { template, question, answer, readonly, locking } %>
+ <!--
+   This partial creates a form for each type of question. The local variables are: plan, answer, question, readonly
+ -->","this partial is used also for previewing a template, did you test if still works?"
+7222,"@@ -22,6 +22,19 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	appInitAppTypePrompt     = ""Which type of "" + color.Emphasize(""infrastructure pattern"") + "" best represents your application?""
++	appInitAppTypeHelpPrompt = `Your application's architecture. Most applications need additional AWS resources to run.
++To help setup the infrastructure resources, select what ""kind"" or ""type"" of application you want to build.`
++
++	fmtAppInitAppNamePrompt     = ""What do you want to "" + color.Emphasize(""name"") + "" this %s?""
++	fmtAppInitAppNameHelpPrompt = `The name will uniquely identify this application within your %s project.
++Deployed resources (such as your service, logs) will contain this app's name and be tagged with it.`
++
++	fmtAppInitDockerfilePrompt  = ""Which Dockerfile would you like to use for %s app?""
++	appInitDockerfileHelpPrompt = ""Dockerfile to use for building your application's container image.""
++)
++
+ const (
+ 	fmtAddAppToProjectStart    = ""Creating ECR repositories for application %s.""
+ 	fmtAddAppToProjectFailed   = ""Failed to create ECR repositories for application %s.""",Would it be better to put like `Which Dockerfile would you like to use for %s?`
+7223,"@@ -3636,8 +3636,8 @@ Model.hydrate = function(obj) {
+  * @see response http://docs.mongodb.org/v2.6/reference/command/update/#output
+  * @param {Object} filter
+  * @param {Object} doc
+- * @param {Object} [options] optional see [`Query.prototype.setOptions()`](http://mongoosejs.com/docs/api.html#query_Query-setOptions)
+- * @param {Boolean|String} [options.strict] overwrites the schema's [strict mode option](http://mongoosejs.com/docs/guide.html#strict)
++ * @param {Object} [options] optional see [`Query.prototype.setOptions()`](/api.html#query_Query-setOptions)
++ * @param {Boolean|String} [options.strict] overwrites the schema's [strict mode option](/docs/guide.html#strict)
+  * @param {Boolean} [options.upsert=false] if true, and no documents found, insert a new document
+  * @param {Object} [options.writeConcern=null] sets the [write concern](https://docs.mongodb.com/manual/reference/write-concern/) for replica sets. Overrides the [schema-level write concern](/docs/guide.html#writeConcern)
+  * @param {Boolean} [options.omitUndefined=false] If true, delete any properties whose value is `undefined` when casting an update. In other words, if this is set, Mongoose will delete `baz` from the update in `Model.updateOne({}, { foo: 'bar', baz: undefined })` before sending the update to the server.","You mistakenly removed `/docs` here, please add it"
+7224,"@@ -48,8 +48,9 @@ public interface FileAppender<D> extends Closeable {
+   long length();
+
+   /**
+-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
++   * @return a list of offsets for file blocks, if applicable, null otherwise. When available, this
+    * information is used for planning scan tasks whose boundaries are determined by these offsets.
++   * It is important that the returned list is sorted in ascending order.
+    * Only valid after the file is closed.
+    */
+   default List<Long> splitOffsets() {","I missed this earlier, but why does this say ""file blocks""? This should probably be ""recommended split locations""."
+7225,"@@ -33,10 +33,10 @@ import (
+ // AlertsServer implements api.OpenStorageAlertsServer.
+ // In order to use this server implementation just have
+ // AlertsServer pointer properly instantiated with a valid
+-// alerts.Reader.
++// alerts.FilterDeleter.
+ type AlertsServer struct {
+-	// Reader holds pointer to alerts Reader
+-	Reader alerts.Reader
++	// FilterDeleter holds pointer to alerts FilterDeleter
++	FilterDeleter alerts.FilterDeleter
+ }
+
+ func getOpts(opts []*api.SdkAlertsOption) []alerts.Option {",Please change this to non-exported.
+7226,"@@ -4649,10 +4649,7 @@ stats_get_snapshot(dr_stats_t *drstats)
+     if (!GLOBAL_STATS_ON())
+         return false;
+     CLIENT_ASSERT(drstats != NULL, ""Expected non-null value for parameter drstats."");
+-    /* We are at V1 of the structure, and we can't return less than the one
+-     * field. We need to remove this assert when we add more fields.
+-     */
+-    CLIENT_ASSERT(drstats->size >= sizeof(dr_stats_t), ""Invalid drstats->size value."");
+     drstats->basic_block_count = GLOBAL_STAT(num_bbs);
++    drstats->peak_num_threads = GLOBAL_STAT(peak_num_threads);
+     return true;
+ }",This is ignoring compatibility: it needs to check the size to ensure this field exists in the client.
+7227,"@@ -96,10 +96,11 @@ public class RoundChangePayloadValidator {
+       return false;
+     }
+
+-    if (certificate.getPreparePayloads().size() < minimumPrepareMessages) {
++    if (certificate.getPreparePayloads().stream().map(SignedData::getAuthor).distinct().count()
++        < minimumPrepareMessages) {
+       LOG.info(
+-          ""Invalid RoundChange message, insufficient Prepare messages exist to justify ""
+-              + ""prepare certificate."");
++          ""Invalid RoundChange message, insufficient uniquely authored Prepare messages exist to ""
++              + "" justify  prepare certificate."");
+       return false;
+     }
+ ",Do all the prepare authors also need to be unique? Or is it enough the we have minimumPrepareMessages. I guess I'm wondering if need a hasDuplicateAuthors check like in the RoundChangeCertificateValidator.
+7228,"@@ -4,12 +4,17 @@ package stdlib
+
+ import (
+ 	_ ""github.com/influxdata/flux/stdlib/csv""
++	_ ""github.com/influxdata/flux/stdlib/date""
+ 	_ ""github.com/influxdata/flux/stdlib/generate""
+ 	_ ""github.com/influxdata/flux/stdlib/http""
+ 	_ ""github.com/influxdata/flux/stdlib/influxdata/influxdb""
+ 	_ ""github.com/influxdata/flux/stdlib/influxdata/influxdb/v1""
+ 	_ ""github.com/influxdata/flux/stdlib/kafka""
+ 	_ ""github.com/influxdata/flux/stdlib/math""
++	_ ""github.com/influxdata/flux/stdlib/mqtt""
++	_ ""github.com/influxdata/flux/stdlib/promql""
++	_ ""github.com/influxdata/flux/stdlib/regexp""
++	_ ""github.com/influxdata/flux/stdlib/runtime""
+ 	_ ""github.com/influxdata/flux/stdlib/socket""
+ 	_ ""github.com/influxdata/flux/stdlib/sql""
+ 	_ ""github.com/influxdata/flux/stdlib/strings""","we had some situations where we merged some promql bits then took them out. i'm not sure what's going on here, but unless your code actually needs promql (probably not?) let's remove this line."
+7229,"@@ -32,9 +32,9 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend
+     {
+         $termsAndConditions = $this->getReference(ArticleDataFixture::ARTICLE_TERMS_AND_CONDITIONS_1);
+         $privacyPolicy = $this->getReference(ArticleDataFixture::ARTICLE_PRIVACY_POLICY_1);
+-        /* @var $termsAndConditions \Shopsys\FrameworkBundle\Model\Article\Article */
++        /* @var $termsAndConditions \Shopsys\ShopBundle\Model\Article\Article */
+         $cookies = $this->getReference(ArticleDataFixture::ARTICLE_COOKIES_1);
+-        /* @var $cookies \Shopsys\FrameworkBundle\Model\Article\Article */
++        /* @var $cookies \Shopsys\ShopBundle\Model\Article\Article */
+
+         $personalDataDisplaySiteContent = 'By entering an email below, you can view your personal information that we register in our online store.
+         An email with a link will be sent to you after entering your email address, to verify your identity. ","Annotations in this hunk should follow PhpDoc style (above the occurrence, type first)"
+7230,"@@ -100,7 +100,7 @@ public class Wildcard implements Type {
+         } else if (type == BoundType.EXTENDS) {
+             return ""? extends "" + boundedType.describe();
+         } else {
+-            throw new UnsupportedOperationException();
++            throw new UnsupportedOperationException(String.format(""%s is not supported"", type));
+         }
+     }
+ ","This is an improvement - thanks! Could we rephrase slightly to not use the phrase ""is not supported"" -- instead stating _WHAT_ isn't valid please? e.g. maybe `String.format(""Unsupported BoundType provided: %s"" type)` or something like that."
+7231,"@@ -30,7 +30,7 @@ type linuxWatcher struct {
+ 	gid       uint32
+ 	pid       int32
+ 	mtx       sync.Mutex
+-	procfh    *os.File
++	procfh    int
+ 	starttime string
+ 	uid       uint32
+ }",nit: `procfd` seems more appropriate now?
+7232,"@@ -1045,6 +1045,10 @@ def access_put(owner, package_name, user):
+             ""Only the package owner can grant access""
+         )
+
++    django_headers = {
++        AUTHORIZATION_HEADER: g.auth_header
++        }
++
+     package = (
+         Package.query
+         .with_for_update()",Let's not call it django. Maybe `auth_provider_headers`? `auth_headers`?
+7233,"@@ -252,7 +252,8 @@ func (s *Server) isClientAuthorized(c *client) bool {
+ 	tlsMap := s.opts.TLSMap
+ 	s.optsMu.RUnlock()
+
+-	// Check custom auth first, then jwts, then nkeys, then multiple users, then token, then single user/pass.
++	// Check custom auth first, then jwts, then nkeys, then
++	// multiple users, then token, then single user/pass.
+ 	if customClientAuthentication != nil {
+ 		return customClientAuthentication.Check(c)
+ 	}",Should we mention TLS map here?
+7234,"@@ -25,9 +25,12 @@
+ package net.runelite.client.plugins.playerindicators;
+
+ import java.awt.Color;
++
++import net.runelite.api.ClanMemberRank;
+ import net.runelite.client.config.Config;
+ import net.runelite.client.config.ConfigGroup;
+ import net.runelite.client.config.ConfigItem;
++import net.runelite.client.config.Range;
+
+ @ConfigGroup(""playerindicators"")
+ public interface PlayerIndicatorsConfig extends Config",remove this empty line pl0x
+7235,"@@ -34,4 +34,10 @@ class NcrDispatcher < LinearDispatcher
+       end
+     }
+   end
++
++  def on_approver_removal(proposal, approvers)
++    approvers.each{|approver|
++      CommunicartMailer.notification_for_subscriber(approver.email_address,proposal,""removed"").deliver_now
++    }
++  end
+ end",Why not have this in the `Dispatcher`? Doesn't seem like NCR-specific functionality.
+7236,"@@ -26,6 +26,11 @@ import (
+ )
+
+ func CreateTestKV(t *testing.T) kv.RwDB {
++	s, _, _ := CreateTestSentry(t)
++	return s.DB
++}
++
++func CreateTestSentry(t *testing.T) (*stages.MockSentry, *core.ChainPack, []*core.ChainPack) {
+ 	// Configure and generate a sample block chain
+ 	var (
+ 		key, _   = crypto.HexToECDSA(""b71c71a67e1177ad4e901695e1b4b9ee17ae16c6668d313eac2f96dbcda3f291"")","If you need only test db, use `memdb.NewTestDB(t)`"
+7237,"@@ -533,7 +533,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+                             await ProduceEnd();
+
+                             // ForZeroContentLength does not complete the reader nor the writer
+-                            if (!messageBody.IsEmpty && _keepAlive)
++                            if (!messageBody.IsEmpty)
+                             {
+                                 // Finish reading the request body in case the app did not.
+                                 await messageBody.ConsumeAsync();",I'm not sure I like setting the IsEmpty property true for upgraded connections since it feels a middle misleading. Maybe we can leave the ForUpgrade class as is and change this condition to `if (!messageBody.IsEmpty && !messageBody.RequestUpgrade)` to make things more explicit.
+7238,"@@ -141,7 +141,7 @@ ActiveRecord::Schema.define(version: 20151123235600) do
+     t.integer  ""client_data_id""
+     t.string   ""client_data_type"", limit: 255
+     t.integer  ""requester_id""
+-    t.string   ""public_id""
++    t.string   ""public_id"",        limit: 255
+   end
+
+   add_index ""proposals"", [""client_data_id"", ""client_data_type""], name: ""index_proposals_on_client_data_id_and_client_data_type"", using: :btree",git checkout since this is unrelated to this PR? (running migrations also changes this for me -- not sure why it keeps going back and forth
+7239,"@@ -154,7 +154,7 @@ class _TLSSignature(_GenericTLSSessionInheritance):
+     #XXX 'sig_alg' should be set in __init__ depending on the context.
+     """"""
+     name = ""TLS Digital Signature""
+-    fields_desc = [SigAndHashAlgField(""sig_alg"", 0x0401, _tls_hash_sig),
++    fields_desc = [SigAndHashAlgField(""sig_alg"", 0x0804, _tls_hash_sig),
+                    SigLenField(""sig_len"", None, fmt=""!H"",
+                                length_of=""sig_val""),
+                    SigValField(""sig_val"", None,",Is this change needed?
+7240,"@@ -1321,7 +1321,7 @@ void MolPickler::_pickleAtom(std::ostream &ss, const Atom *atom) {
+     streamWrite(ss, ENDQUERY);
+   }
+   if (getAtomMapNumber(atom, tmpInt)) {
+-    if (tmpInt < 128) {
++    if (tmpInt >= 0 && tmpInt < 128) {
+       tmpChar = static_cast<char>(tmpInt % 128);
+       streamWrite(ss, ATOM_MAPNUMBER, tmpChar);
+     } else {",Isn't the % 128 redundant here?
+7241,"@@ -34,7 +34,9 @@ func TestCmdMarshalProto(t *testing.T) {
+  ""sticky"": false,
+  ""group_enforced"": false,
+  ""compressed"": false,
+- ""cascaded"": false
++ ""cascaded"": false,
++ ""loopdev"": false,
++ ""ramdisk"": false
+ }`,
+ 		data,
+ 	)","Are you testing that the values are always false? I think you should test for setting values to true or false, right? Who is going to take action with these values?"
+7242,"@@ -35,6 +35,9 @@ extern const struct batch_queue_module batch_queue_wq;
+ extern const struct batch_queue_module batch_queue_mesos;
+ extern const struct batch_queue_module batch_queue_k8s;
+ extern const struct batch_queue_module batch_queue_dryrun;
++#ifdef MPI
++extern const struct batch_queue_module batch_queue_mpi;
++#endif
+
+ static struct batch_queue_module batch_queue_unknown = {
+ 	BATCH_QUEUE_TYPE_UNKNOWN, ""unknown"",",Please change MPI to CCTOOLS_WITH_MPI
+7243,"@@ -16,6 +16,11 @@
+
+ #include ""oneapi/dal/algo/decision_forest/common.hpp""
+ #include ""oneapi/dal/algo/decision_forest/detail/model_impl.hpp""
++#include ""oneapi/dal/exceptions.hpp""
++
++#define DAL_CHECK_DOMAIN_COND(cond, description) \
++    if (!(cond))                                 \
++        throw domain_error(description);
+
+ namespace oneapi::dal::decision_forest {
+ ",Why you can't use function here?
+7244,"@@ -0,0 +1,16 @@
++// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package ssm
++
++//go:generate go run ../../scripts/generate/mockgen.go github.com/aws/aws-sdk-go/service/ssm/ssmiface SSMAPI mocks/ssmiface_mocks.go",We should scope this down to only the methods we use.
+7245,"@@ -800,7 +800,7 @@ public final class HashSet<T> implements Set<T>, Serializable {
+
+     @Override
+     public String toString() {
+-        return mkString("", "", ""HashSet("", "")"");
++        return mkString(""HashSet("", "", "", "")"");
+     }
+
+     private static <T> HashArrayMappedTrie<T, T> addAll(HashArrayMappedTrie<T, T> initial,","Oh, thanks for catching - I thought I've catched all after changing `mkString(infix, prefix, suffix)` to `mkString(prefix, infix, suffix)`."
+7246,"@@ -33,6 +33,14 @@ const (
+ 	// Issued indicates that a CertificateRequest has been completed, and that
+ 	// the `status.certificate` field is set.
+ 	CertificateRequestReasonIssued = ""Issued""
++
++	// Approved indicates that a CertificateRequest has been approved by the
++	// approver, and the CertificateRequest is ready for signing.
++	CertificateRequestReasonApproved = ""Approved""
++
++	// Denied indicates that a CertificateRequest has been denied by the
++	// approver, and the CertificateRequest will be never be signed.
++	CertificateRequestReasonDenied = ""Denied""
+ )
+
+ // +genclient","Suggestion: `.. the CertificateRequest is ready for signing` - could we perhaps word this differently? I understand that in this case it will be the associated X.509 certificate that can now be signed, so maybe `the certificate is ready for signing` ? (Same with `CertificateRequestReasonDenied`)."
+7247,"@@ -54,6 +54,10 @@ export default function PropertySelect() {
+ 		}
+ 	}, [ propertyID, selectProperty ] );
+
++	if ( ! accountID ) {
++		return null;
++	}
++
+ 	if ( isLoading ) {
+ 		return <ProgressBar small />;
+ 	}",We should use `! isValidAccountID( accountID )` for the `accountID` checks.
+7248,"@@ -6,7 +6,9 @@ require 'bolt/error'
+ module Bolt
+   class Target
+     attr_reader :uri, :options
+-    attr_writer :inventory
++    # CODEREVIEW: this feels wrong. The altertative is threading inventory through the
++    # executor to the RemoteTransport
++    attr_accessor :inventory
+
+     PRINT_OPTS ||= %w[host user port protocol].freeze
+ ",That alternative does seem better. Did you want to try to do it in this PR? It makes sense to me that the inventory would always be available before creating the executor.
+7249,"@@ -545,8 +545,12 @@ module Beaker
+           on host, ""apt-get install -y hiera=#{opts[:hiera_version]}-1puppetlabs1""
+         end
+
+-        puppet_pkg = opts[:version] ? ""puppet=#{opts[:version]}-1puppetlabs1"" : 'puppet'
+-        on host, ""apt-get install -y #{puppet_pkg}""
++        if opts[:version]
++          on host, ""apt-get install -y puppet-common=#{opts[:version]}-1puppetlabs1""
++          on host, ""apt-get install -y puppet=#{opts[:version]}-1puppetlabs1""
++        else
++          on host, 'apt-get install -y puppet'
++        end
+       end
+
+       # Installs Puppet and dependencies from msi",Missing the `-y` argument which all other `apt-get install` commands have.
+7250,"@@ -1295,7 +1295,8 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+     auto subpass_desc = &pPipeline->rp_state->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass];
+     if (pPipeline->graphicsPipelineCI.subpass >= pPipeline->rp_state->createInfo.subpassCount) {
+         skip |= LogError(device, ""VUID-VkGraphicsPipelineCreateInfo-subpass-00759"",
+-                         ""Invalid Pipeline CreateInfo[%u] State: Subpass index %u is out of range for this renderpass (0..%u)."",
++                         ""Invalid Pipeline CreateInfo[%"" PRIu32
++                         ""] State: Subpass index %u is out of range for this renderpass (0..%u)."",
+                          pipelineIndex, pPipeline->graphicsPipelineCI.subpass, pPipeline->rp_state->createInfo.subpassCount - 1);
+         subpass_desc = nullptr;
+     }","So I think we are going to settle on the ""concise and elegant"" `PRI` macros as they are the safest option for now. Even though they make my eyes bleed a little..."
+7251,"@@ -112,7 +112,7 @@ func (r *Replacer) ReplaceFunc(input string, f ReplacementFunc) (string, error)
+ func (r *Replacer) replace(input, empty string,
+ 	treatUnknownAsEmpty, errOnEmpty, errOnUnknown bool,
+ 	f ReplacementFunc) (string, error) {
+-	if !strings.Contains(input, string(phOpen)) {
++	if !strings.Contains(input, string(phOpen)) && !strings.Contains(input, string(phClose)) {
+ 		return input, nil
+ 	}
+ ","Interesting, was this needed for a test case to pass? I figured if there is no opening brace, there is definitely no placeholder -- we don't even have to check for a closing one."
+7252,"@@ -122,8 +122,10 @@ ChainLoop:
+ 			return []explorer.Transfer{}, err
+ 		}
+
+-		for i := len(blk.Transfers) - 1; i >= 0; i-- {
+-			if showCoinBase || !blk.Transfers[i].IsCoinbase() {
++		transfers, _, _ := action.ClassifyActions(blk.Actions)
++
++		for i := len(transfers) - 1; i >= 0; i-- {
++			if showCoinBase || !transfers[i].IsCoinbase() {
+ 				transferCount++
+ 			}
+ ",I think we want to provide getAction API instead
+7253,"@@ -117,12 +117,7 @@ class SynthDriver(SynthDriver):
+
+ 	@classmethod
+ 	def check(cls):
+-		if not hasattr(sys, ""frozen""):
+-			# #3793: Source copies don't report the correct version on Windows 10 because Python isn't manifested for higher versions.
+-			# We want this driver to work for source copies on Windows 10, so just return True here.
+-			# If this isn't in fact Windows 10, it will fail when constructed, which is okay.
+-			return True
+-		# For binary copies, only present this as an available synth if this is Windows 10.
++		# Only present this as an available synth if this is Windows 10.
+ 		return winVersion.winVersion.major >= 10
+
+ 	def _get_supportsProsodyOptions(self):","There is also `winVersion.isWin10`. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here."
+7254,"@@ -37,6 +37,7 @@ RSpec.configure do |config|
+   config.use_transactional_fixtures = false
+   config.use_instantiated_fixtures  = false
+   config.fixture_path = ""#{::Rails.root}/spec/fixtures""
++  config.fail_fast = true
+
+   config.include Paperclip::Shoulda::Matchers
+   config.include EmailSpec::Helpers",This doesn't seem like it should be part of this pull request.
+7255,"@@ -4,6 +4,7 @@ class ProductsController < ApplicationController
+
+   def show
+     @product = Product.find(params[:id])
++    @offering = @product
+     @viewable_subscription = ViewableSubscription.new(current_user, subscription_product)
+
+     if signed_in? && @product.purchase_for(current_user)",Is the idea that `@product` (and `@workshop` for `workshops_controller`) would eventually go away here?
+7256,"@@ -0,0 +1,8 @@
++package headerdownload
++
++var bscMainnetPreverifiedHashes = []string{
++	""0d21840abff46b96c84b2ac9e10e4f5cdaeb5693cb665db62a2f3b02d2d57b5b"",
++	""04055304e432294a65ff31069c4d3092ff8b58f009cdb50eba5351e0332ad0f6"",
++}
++
++const bscMainnetPreverifiedHeight uint64 = 1","We should add those only once we have successfully synced to the BSC main net, we have a utility to generate those. Please remove for now"
+7257,"@@ -376,7 +376,7 @@ def test_set_env_from_file(config_instance):
+
+
+ def test_set_env_from_file_returns_original_env_when_env_file_not_found(
+-    config_instance
++    config_instance,
+ ):
+     env = config.set_env_from_file({}, 'file-not-found')
+ ",And how is that related?
+7258,"@@ -55,7 +55,8 @@ func AdminAddOrUpdateRemoteCluster(c *cli.Context) {
+ 	defer cancel()
+
+ 	_, err := adminClient.AddOrUpdateRemoteCluster(ctx, &adminservice.AddOrUpdateRemoteClusterRequest{
+-		FrontendAddress: getRequiredOption(c, FlagFrontendAddressWithAlias),
++		FrontendAddress:               c.String(FlagFrontendAddressWithAlias),
++		EnableRemoteClusterConnection: c.BoolT(FlagConnectionEnableAlias),
+ 	})
+ 	if err != nil {
+ 		ErrorAndExit(""Operation AddOrUpdateRemoteCluster failed."", err)",this should be required
+7259,"@@ -18,6 +18,7 @@ import com.google.api.codegen.SnippetSetRunner;
+ import com.google.auto.value.AutoValue;
+ import java.util.List;
+ import javax.annotation.Nullable;
++import javax.validation.constraints.Null;
+
+ @AutoValue
+ public abstract class DynamicLangXApiView implements ViewModel {",This appears to be unused
+7260,"@@ -63,6 +63,19 @@ public class SnapshotUtil {
+     return ancestorIds(table.currentSnapshot(), table::snapshot);
+   }
+
++  /**
++   * Traverses the history of the table's state and finds the oldest Snapshot.
++   * @return null if the table is empty, else the oldest Snapshot.
++   */
++  public static Snapshot oldestSnapshot(Table table) {
++    Snapshot current = table.currentSnapshot();
++    while (current != null && current.parentId() != null) {
++      current = table.snapshot(current.parentId());
++    }
++
++    return current;
++  }
++
+   /**
+    * Returns list of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
+    * <p>","I think that ""table's state"" isn't clear enough. How about ""history of the table's current snapshot"" like the one below?"
+7261,"@@ -457,3 +457,17 @@ instr_is_exclusive_store(instr_t *instr)
+     }
+     return false;
+ }
++
++DR_API
++bool
++instr_is_scatter(instr_t *instr)
++{
++    return false;
++}
++
++DR_API
++bool
++instr_is_gather(instr_t *instr)
++{
++    return false;
++}",This looks like a bug: pretty sure there are scatter-gather instructions on AArch64. Ditto below.
+7262,"@@ -55,9 +55,10 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // sharing this transport.
+ func (t *Transport) NewInbound(addr string, opts ...InboundOption) *Inbound {
+ 	i := &Inbound{
+-		once:   sync.Once(),
+-		addr:   addr,
+-		tracer: t.tracer,
++		once:      sync.Once(),
++		addr:      addr,
++		tracer:    t.tracer,
++		transport: t,
+ 	}
+ 	for _, opt := range opts {
+ 		opt(i)","No need to change this: id love if we changed as a team to unkeyed fields, it ends up catching a lot more at compile time, at minimal cost"
+7263,"@@ -105,6 +105,11 @@ func (m LBFargateManifest) DockerfilePath() string {
+ 	return m.Image.Build
+ }
+
++// AppName returns the name of the application
++func (m LBFargateManifest) AppName() string {
++	return m.Name
++}
++
+ // EnvConf returns the application configuration with environment overrides.
+ // If the environment passed in does not have any overrides then we return the default values.
+ func (m *LBFargateManifest) EnvConf(envName string) LBFargateConfig {",Should this be in the parent struct? `AppManifest` since it's embedded to `LBFargateManifest` it'll get the method as well.
+7264,"@@ -18,7 +18,12 @@
+ package openvpn
+
+ import (
++	""bufio""
++	""bytes""
+ 	""errors""
++	log ""github.com/cihub/seelog""
++	""io""
++	""net/textproto""
+ 	""os/exec""
+ 	""strconv""
+ 	""syscall""","""Openvpn check"" we could move this to separate prefix."
+7265,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests
+7266,"@@ -42,8 +42,6 @@ void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
+             } else {
+                 this->pushResultCode(this->to(code), partId);
+             }
+-            this->onFinished();
+-            return;
+         }
+     });
+ ",We don't return now?
+7267,"@@ -18,7 +18,7 @@ module Travis
+         end
+
+         def install
+-          uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install'
++          uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install', retry: true
+         end
+
+         def script","This might end up not doing exactly what we want (the retry only picks up the `go get`, not the `go build`, due to the `&&`)."
+7268,"@@ -1,4 +1,4 @@
+-// <copyright file=""ConsoleExporterOptions.cs"" company=""OpenTelemetry Authors"">
++// <copyright file=""ConsoleExporterOptions.cs"" company=""OpenTelemetry Authors"">
+ // Copyright The OpenTelemetry Authors
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");",Is there a BOM change?
+7269,"@@ -142,8 +142,6 @@ public final class Const {
+
+   public static final String REGISTRY_SERVICE_NAME = ""SERVICECENTER"";
+
+-  public static final String REGISTRY_VERSION = ""3.0.0"";
+-
+   public static final String APP_SERVICE_SEPARATOR = "":"";
+
+   public static final String PATH_CHECKSESSION = ""checksession"";",It's not a good practise to delete the public static constant.
+7270,"@@ -467,13 +467,7 @@ func (eval *BlockEvaluator) transaction(txn transactions.SignedTxn, ad transacti
+ 			return TransactionInLedgerError{txn.ID()}
+ 		}
+
+-		// Well-formed on its own?
+-		err = txn.Txn.WellFormed(spec, eval.proto)
+-		if err != nil {
+-			return fmt.Errorf(""transaction %v: malformed: %v"", txn.ID(), err)
+-		}
+-
+-		// Properly signed?
++		// Well-formed and signed properly?
+ 		if eval.txcache == nil || !eval.txcache.Verified(txn) {
+ 			err = verify.TxnPool(&txn, spec, eval.proto, eval.verificationPool)
+ 			if err != nil {",I deleted this because `WellFormed` is immediately called by `verify.TxnPool` below. Can someone please double check this for me since it's... pretty important
+7271,"@@ -70,6 +70,7 @@ setup(
+         ""kaitaistruct>=0.7,<0.9"",
+         ""ldap3>=2.5,<2.6"",
+         ""passlib>=1.6.5, <1.8"",
++        ""ply>=3.4, <3.12"",
+         ""pyasn1>=0.3.1,<0.5"",
+         ""pyOpenSSL>=17.5,<18.1"",
+         ""pyparsing>=2.1.3, <2.3"",","Did you actually test this with ply 3.4? That release is pretty old (2011), so I think we can bump this to at least 3.6 (2015) or even 3.10 (2017)..."
+7272,"@@ -130,6 +130,12 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe
+
+ 	r.includeGlobalPullSecret(hLog, h, instance, hiveDeployment)
+
++	if instance.Spec.MaintenanceMode != nil && *instance.Spec.MaintenanceMode {
++		hLog.Warn(""maintenanceMode enabled in HiveConfig, setting hive-controllers replicas to 0"")
++		replicas := int32(0)
++		hiveDeployment.Spec.Replicas = &replicas
++	}
++
+ 	result, err := h.ApplyRuntimeObject(hiveDeployment, scheme.Scheme)
+ 	if err != nil {
+ 		hLog.WithError(err).Error(""error applying deployment"")",This can be simplified somewhat to `pointer.Int32Ptr(0)`. But it is not necessary.
+7273,"@@ -226,9 +226,7 @@ static bool checkBondStereo(const MCSBondCompareParameters& p,
+   Bond::BondStereo bs1 = b1->getStereo();
+   Bond::BondStereo bs2 = b2->getStereo();
+   if (b1->getBondType() == Bond::DOUBLE && b2->getBondType() == Bond::DOUBLE) {
+-    if ((bs1 == Bond::STEREOZ || bs1 == Bond::STEREOE) &&
+-        !(bs2 == Bond::STEREOZ || bs2 == Bond::STEREOE))
+-      return false;
++    if (bs1 > Bond::STEREOANY && !(bs2 > Bond::STEREOANY)) return false;
+   }
+   return true;
+ }",Clever but perhaps confusing.
+7274,"@@ -360,10 +360,14 @@ func (r *ReconcileSyncSetInstance) syncDeletedSyncSetInstance(ssi *hivev1.SyncSe
+
+ 	ssiLog.Info(""deleting syncset resources on target cluster"")
+ 	err = r.deleteSyncSetResources(ssi, dynamicClient, ssiLog)
+-	if err == nil {
+-		return reconcile.Result{}, r.removeSyncSetInstanceFinalizer(ssi, ssiLog)
++	if err != nil {
++		return reconcile.Result{}, err
++	}
++	err = r.deleteSyncSetSecretReferences(ssi, dynamicClient, ssiLog)
++	if err != nil {
++		return reconcile.Result{}, err
+ 	}
+-	return reconcile.Result{}, err
++	return reconcile.Result{}, r.removeSyncSetInstanceFinalizer(ssi, ssiLog)
+ }
+
+ func (r *ReconcileSyncSetInstance) applySyncSet(ssi *hivev1.SyncSetInstance, spec *hivev1.SyncSetCommonSpec, dynamicClient dynamic.Interface, h Applier, kubeConfig []byte, ssiLog log.FieldLogger) error {",@abutcher Is it a safe assumption that secrets are the only objects that need to get attached to syncsets?
+7275,"@@ -1605,7 +1605,8 @@ func (o *consumer) needAck(sseq uint64) bool {
+ 		state, err := o.store.State()
+ 		if err != nil || state == nil {
+ 			o.mu.RUnlock()
+-			return false
++			// Fall back to what we track internally for now.
++			return sseq > o.asflr
+ 		}
+ 		asflr, osseq = state.AckFloor.Stream, o.sseq
+ 		pending = state.Pending",Should you capture o.asflr before releasing consumer's lock?
+7276,"@@ -51,6 +51,10 @@ public class WinePrefixContainerWineToolsTab extends Tab {
+         final VBox toolsPane = new VBox();
+         final Text title = new TextWithStyle(tr(""Wine tools""), TITLE_CSS_CLASS);
+
++        if (engineTools == null) {
++            return;
++        }
++
+         toolsPane.getStyleClass().add(CONFIGURATION_PANE_CSS_CLASS);
+         toolsPane.getChildren().add(title);
+ ","Just asking: Should this happen, that null is passed? If this is the case I think we should think about passing an `Optional` object to the method."
+7277,"@@ -10,6 +10,17 @@ class HomeController < ApplicationController
+   def me
+   end
+
++  def edit_me
++    first_name = params[:first_name]
++    last_name = params[:last_name]
++    user = current_user
++    user.first_name = first_name
++    user.last_name = last_name
++    user.save!
++    flash[:success] = ""Your profile is updated!""
++    redirect_to :me
++  end
++
+   def error
+     raise ""test exception""
+   end","what about making a `ProfilesController` or `UserProfilesController` and having this be a `show` action instead? That would be more Railsy (although that can be considered a compliment or a dis, depending on who you are :hamburger: )"
+7278,"@@ -2378,7 +2378,11 @@ void PostCallRecordCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *
+     }
+
+     layer_data *device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
+-    device_data->enabled_features.core = *enabled_features_found;
++    if (nullptr == enabled_features_found) {
++        device_data->enabled_features.core = {};
++    } else {
++        device_data->enabled_features.core = *enabled_features_found;
++    }
+
+     uint32_t count;
+     instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr);",I'd move the empty assignment and non-null case into the if check directly above (adding an else clause as needed)
+7279,"@@ -215,6 +215,8 @@ class Preference extends Model
+             'zh-tw' => [Lang::get('system::lang.locale.zh-tw'), 'flag-tw'],
+             'nb-no' => [Lang::get('system::lang.locale.nb-no'), 'flag-no'],
+             'el' => [Lang::get('system::lang.locale.el'), 'flag-gr'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++
+         ];
+
+         $locales = Config::get('app.localeOptions', $localeOptions);",Please remove this extra line of whitespace
+7280,"@@ -83,14 +83,15 @@ class ProductSearchExportWithFilterRepository
+     /**
+      * @param int $domainId
+      * @param string $locale
+-     * @param int $startFrom
++     * @param int $lastProcessedId
+      * @param int $batchSize
+      * @return array
+      */
+-    public function getProductsData(int $domainId, string $locale, int $startFrom, int $batchSize): array
++    public function getProductsData(int $domainId, string $locale, int $lastProcessedId, int $batchSize): array
+     {
+         $queryBuilder = $this->createQueryBuilder($domainId)
+-            ->setFirstResult($startFrom)
++            ->andWhere('p.id > :lastProcessedId')
++            ->setParameter('lastProcessedId', $lastProcessedId)
+             ->setMaxResults($batchSize);
+
+         $query = $queryBuilder->getQuery();","maybe it's time to rename `ProductSearchExportWithFilter` to something better, what do you think?"
+7281,"@@ -49,11 +49,11 @@ func (agent *ecsAgent) appendTaskEIACapabilities(capabilities []*ecs.Attribute)
+ }
+
+ func (agent *ecsAgent) appendFirelensFluentdCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+-	return capabilities
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentd)
+ }
+
+ func (agent *ecsAgent) appendFirelensFluentbitCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+-	return capabilities
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentbit)
+ }
+
+ func (agent *ecsAgent) appendEFSCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {","Instead of adding new code here - can you move these methods to agent_capability.go, so the same is used for unix and windows as well. this will need removal of these methods from agent_capability_unix.go as well."
+7282,"@@ -648,7 +648,7 @@ def log(package):
+             str(entry.get('tags', [])), str(entry.get('versions', []))))
+     _print_table(table)
+
+-def push(package, is_public=False, is_team=False, reupload=False):
++def push(package, hash=None, is_public=False, is_team=False, reupload=False):
+     """"""
+     Push a Quilt data package to the server
+     """"""","Make it the last parameter, just in case someone uses the API with non-keyword args."
+7283,"@@ -1,15 +1,15 @@
+-class GithubRemovalJob < Struct.new(:github_team, :username)
++class GithubRemovalJob < Struct.new(:repository, :username)
+   include ErrorReporting
+
+   PRIORITY = 1
+
+-  def self.enqueue(github_team, username)
+-    Delayed::Job.enqueue(new(github_team, username))
++  def self.enqueue(repository, username)
++    Delayed::Job.enqueue(new(repository, username))
+   end
+
+   def perform
+     begin
+-      github_client.remove_team_member(github_team, username)
++      github_client.remove_collaborator(repository, username)
+     rescue Octokit::NotFound, Net::HTTPBadResponse => e
+       Airbrake.notify(e)
+     end",Don't extend an instance initialized by `Struct.new`.
+7284,"@@ -4771,6 +4771,11 @@ static void tdes(pmix_server_trkr_t *t)
+     if (NULL != t->info) {
+         PMIX_INFO_FREE(t->info, t->ninfo);
+     }
++    pmix_nspace_caddy_t *nm, *nm_next;
++    PMIX_LIST_FOREACH_SAFE(nm, nm_next, &t->nslist, pmix_nspace_caddy_t) {
++        pmix_list_remove_item (&t->nslist, &nm->super);
++        PMIX_RELEASE(nm);
++    }
+     PMIX_DESTRUCT(&t->nslist);
+ }
+ PMIX_CLASS_INSTANCE(pmix_server_trkr_t,","Just wondering - would it make more sense to simply replace `PMIX_DESTRUCT(&t->nslist)` with `PMIX_LIST_DESTRUCT(&t->nslist)` here, and then add `PMIX_RELEASE(p->jobbkt)` to the `pmix_nspace_caddy_t` destructor on line 154 of src/include/pmix_globals.c? Seems to me like we always want to have these things removed/destructed."
+7285,"@@ -5,7 +5,13 @@
+ package net.sourceforge.pmd.lang.vf;
+
+ import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
++import net.sourceforge.pmd.lang.apex.rule.ApexXPathRule;
+
+ public class RuleSetFactoryTest extends AbstractRuleSetFactoryTest {
+-    // no additional tests
++    public RuleSetFactoryTest() {
++        super();
++        // Copied from net.sourceforge.pmd.lang.apex.RuleSetFactoryTest
++        // Apex rules are found in the classpath because this module has a dependency on pmd-apex
++        validXPathClassNames.add(ApexXPathRule.class.getName());
++    }
+ }","I think, we should fix/improve AbstractRuleSetFactoryTest. I guess, both apex and visualforce rules are now tested, which is unnecessary."
+7286,"@@ -111,6 +111,14 @@ class BackendController extends ControllerBase
+         self::extendableExtendCallback($callback);
+     }
+
++    /**
++     * @inheritDoc
++     */
++    public function callAction($method, $parameters)
++    {
++        return parent::callAction($method, array_values($parameters));
++    }
++
+     /**
+      * Pass unhandled URLs to the CMS Controller, if it exists
+      *",In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or `call_user_func_array()` etc.
+7287,"@@ -7,8 +7,10 @@ package javaslang.collection;
+
+ import javaslang.Function2;
+ import javaslang.Tuple2;
++import javaslang.control.Try;
+ import org.junit.Test;
+
++import java.lang.reflect.Field;
+ import java.util.List;
+ import java.util.Random;
+ import java.util.concurrent.ThreadLocalRandom;",easily possible to get that information without exposing internal information
+7288,"@@ -65,7 +65,13 @@ module Beaker
+           found_env_vars[:answers][key] = value if key.to_s =~ /q_/
+         end
+         found_env_vars[:consoleport] &&= found_env_vars[:consoleport].to_i
+-        found_env_vars[:type] = found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes' ? 'pe' : nil
++        if found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes'
++          found_env_vars[:type] = 'pe'
++        elsif found_env_vars[:is_pe] == 'false' || found_env_vars[:is_pe] == 'no'
++          found_env_vars[:type] = 'foss'
++        else
++          found_env_vars[:type] = nil
++        end
+         found_env_vars[:pe_version_file_win] = found_env_vars[:pe_version_file]
+         found_env_vars[:answers].delete_if {|key, value| value.nil? or value.empty? }
+         found_env_vars.delete_if {|key, value| value.nil? or value.empty? }","Why do we need tristate logic (pe, foss, nil)?"
+7289,"@@ -19,13 +19,13 @@ import (
+
+ func TestBlocksAfterFlagTimeout(t *testing.T) {
+
+-	mu := sync.Mutex{}
++	mux := sync.Mutex{}
+ 	blocked := make(map[string]time.Duration)
+
+ 	mock := mockBlockLister(func(a swarm.Address, d time.Duration, r string) error {
+-		mu.Lock()
++		mux.Lock()
+ 		blocked[a.ByteString()] = d
+-		mu.Unlock()
++		mux.Unlock()
+
+ 		return nil
+ 	})",this change needs to be reverted to what is on `master`
+7290,"@@ -1076,9 +1076,14 @@ Blockly.WorkspaceSvg.prototype.deleteVariableById = function(id) {
+  * @package
+  */
+ Blockly.WorkspaceSvg.prototype.createVariable = function(name, opt_type, opt_id) {
++  var variableInMap = (this.getVariable(name) != null);
+   var newVar = Blockly.WorkspaceSvg.superClass_.createVariable.call(this, name,
+     opt_type, opt_id);
+-  this.refreshToolboxSelection_();
++  // For performance reaons, only refresh the the toolbox for new variables.
++  // Variables that already exist should already be there.
++  if (!variableInMap) {
++    this.refreshToolboxSelection_();
++  }
+   return newVar;
+ };
+ ",Do you still need to call the superclass `createVariable` if you've already determined that the variable exists?
+7291,"@@ -281,7 +281,10 @@ type EachByPackResult struct {
+ }
+
+ // EachByPack returns a channel that yields all blobs known to the index
+-// grouped by packID but ignoring blobs with a packID in packPlacklist.
++// grouped by packID but ignoring blobs with a packID in packPlacklist for
++// finalized indexes.
++// This filtering is used when rebuilding the index where we need to ignore packs
++// from the finalized index which have been re-read into a non-finalized index.
+ // When the  context is cancelled, the background goroutine
+ // terminates. This blocks any modification of the index.
+ func (idx *Index) EachByPack(ctx context.Context, packBlacklist restic.IDSet) <-chan EachByPackResult {","Ignoring the pack entry from an existing entry but using the new entry from a non-finalized index, is subtle enough that it needs explaining."
+7292,"@@ -236,9 +236,12 @@ uint32_t Spells::getInstantSpellCount(const Player* player) const
+
+ InstantSpell* Spells::getInstantSpellById(uint32_t spellId)
+ {
+-	auto it = std::next(instants.begin(), std::min<uint32_t>(spellId, instants.size()));
+-	if (it != instants.end()) {
+-		return it->second;
++	uint32_t count = 0;
++	for (const auto& it : instants) {
++		if (count == spellId) {
++			return it.second;
++		}
++		++count;
+ 	}
+ 	return nullptr;
+ }","This is a revert, is it really an issue?"
+7293,"@@ -26,8 +26,7 @@ namespace OpenTelemetry.Trace
+     using OpenTelemetry.Trace.Export;
+     using OpenTelemetry.Trace.Internal;
+
+-    /// <inheritdoc/>
+-    public class SpanBuilder : ISpanBuilder
++    /*public class SpanBuilder
+     {
+         private readonly SpanProcessor spanProcessor;
+         private readonly TracerConfiguration tracerConfiguration;",can we delete this file altogether?
+7294,"@@ -59,7 +59,9 @@ func InitCoverage(name string) {
+ 	}
+
+ 	// Set up the unit test framework with the required arguments to activate test coverage.
+-	flag.CommandLine.Parse([]string{""-test.coverprofile"", tempCoveragePath()})
++	if err := flag.CommandLine.Parse([]string{""-test.coverprofile"", tempCoveragePath()}); err != nil {
++		panic(err)
++	}
+
+ 	// Begin periodic logging
+ 	go wait.Forever(FlushCoverage, flushInterval)",Suggestion: log some additional info here so we know where we are i.e 'Failed to prepare coverage framework..'
+7295,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace
++{
++    internal static class TracerConstants
++    {
++        public const string Language = ""dotnet"";
++    }
++}","There didn't seem to be any good place to put constants that are .NET Tracer-specific, so I created this internal static class. If there's a better place, let me know."
+7296,"@@ -0,0 +1,19 @@
++package config
++
++import (
++	""github.com/kubeedge/beehive/pkg/common/config""
++	""github.com/kubeedge/beehive/pkg/common/log""
++	""github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants""
++)
++
++// UpdateDeviceStatusBuffer is the size of channel which save update device status message from edge
++var UpdateDeviceStatusBuffer int
++
++func init() {
++	if psb, err := config.CONFIG.GetValue(""devicecontroller.update-device-status-buffer"").ToInt(); err != nil {
++		UpdateDeviceStatusBuffer = constants.DefaultUpdateDeviceStatusBuffer
++	} else {
++		UpdateDeviceStatusBuffer = psb
++	}
++	log.LOGGER.Infof(""update device status buffer: %d"", UpdateDeviceStatusBuffer)
++}",Log message should be started with upper-case word.
+7297,"@@ -126,7 +126,7 @@ namespace NLog.Targets
+         /// Gets or sets the layout that renders event ID.
+         /// </summary>
+         /// <docgen category='Event Log Options' order='10' />
+-        public Layout EventId { get; set; }
++        public Layout<int> EventId { get; set; }
+
+         /// <summary>
+         /// Gets or sets the layout that renders event Category.",changes for example usage in this class
+7298,"@@ -1,4 +1,4 @@
+-define(['browser', 'css!./emby-collapse', 'registerElement', 'emby-button'], function (browser) {
++define(['browser', 'css!elements/emby-collapse/emby-collapse', 'registerElement', 'emby-button'], function (browser) {
+     'use strict';
+
+     var EmbyButtonPrototype = Object.create(HTMLDivElement.prototype);","I know frameworks that support current directory when loading dependencies, is this a limitation of the requirejs loader or can we fix it somehow?"
+7299,"@@ -164,6 +164,10 @@ func (a *FakeWebAPI) AddApplication(ctx context.Context, req *webservice.AddAppl
+ 	return &webservice.AddApplicationResponse{}, nil
+ }
+
++func (a *FakeWebAPI) EnableApplication(ctx context.Context, req *webservice.EnableApplicationRequest) (*webservice.EnableApplicationResponse, error) {
++	return &webservice.EnableApplicationResponse{}, nil
++}
++
+ func (a *FakeWebAPI) DisableApplication(ctx context.Context, req *webservice.DisableApplicationRequest) (*webservice.DisableApplicationResponse, error) {
+ 	return &webservice.DisableApplicationResponse{}, nil
+ }",`ctx` is unused in EnableApplication
+7300,"@@ -139,6 +139,8 @@ static const char* generate_multi_dot_name(ast_t* ast, ast_t** def_found) {
+
+     default:
+     {
++      if (def == NULL)
++        return stringtab("""");
+       pony_assert(0);
+     }
+   }","@jemc , this is one change needed in `generate_multi_dot_name`. I believe this * will do no harm to working pony code: The new code was added in a place where it is throwing an assert. So no working code will get affected. * is in sync with the rest of the method: if the parent ast node has null `data`, we are supposed to return empty string. That is possible when we have expressions wrapped in braces."
+7301,"@@ -88,6 +88,7 @@ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+ import static org.apache.solr.common.params.CommonParams.SORT;
++import static org.apache.solr.common.params.QueryElevationParams.ONLY_ELEVATED_REPRESENTATIVE;
+
+ /**
+ ",Should not be a static import.
+7302,"@@ -288,13 +288,13 @@ func (client *APIECSClient) getCustomAttributes() []*ecs.Attribute {
+
+ func (client *APIECSClient) SubmitTaskStateChange(change api.TaskStateChange) error {
+ 	// Submit attachment state change
+-	if change.Attachments != nil {
++	if change.Attachment != nil {
+ 		var attachments []*ecs.AttachmentStateChange
+
+-		eniStatus := change.Attachments.Status.String()
++		eniStatus := change.Attachment.Status.String()
+ 		attachments = []*ecs.AttachmentStateChange{
+ 			{
+-				AttachmentArn: &change.Attachments.AttachmentArn,
++				AttachmentArn: &change.Attachment.AttachmentARN,
+ 				Status:        &eniStatus,
+ 			},
+ 		}",should we be using `aws.String` here? it seems there are a few other spots we could use `aws.String` in the `if change.Attachment != nil { ...` block.
+7303,"@@ -66,7 +66,9 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
+
+ 		return {
+ 			isAdSenseLinked: select( MODULES_ANALYTICS ).getAdsenseLinked(),
+-			analyticsMainURL: select( MODULES_ANALYTICS ).getServiceURL(),
++			analyticsMainURL: select( MODULES_ANALYTICS ).getServiceReportURL( 'content-publisher-overview', {
++				'_u.date00': startDate, '_u.date01': endDate,
++			} ),
+ 			data: select( MODULES_ANALYTICS ).getReport( args ),
+ 			error: select( MODULES_ANALYTICS ).getErrorForSelector( 'getReport', [ args ] ),
+ 			loading: ! select( MODULES_ANALYTICS ).hasFinishedResolution( 'getReport', [ args ] ),","We can't pass raw dates like this because they need to be formatted as `YYYYMMDD` as noted in the IB. We added the `generateDateRangeArgs` utilities to handle this for us, as well as abstracting the relationship between arg name and specific dates which is not obvious just by looking at it. Let's update it to use `generateDateRangeArgs( { startDate, endDate } )` instead   Use care to make sure we're sourcing the utility from Analytics utils though since AdSense has its own version by the same name, which is different."
+7304,"@@ -313,6 +313,8 @@ class worker(Config):
+     no_install_shutdown_handler = BoolParameter(default=False,
+                                                 description='If true, the SIGUSR1 shutdown handler will'
+                                                 'NOT be install on the worker')
++    save_summary_data = BoolParameter(default=True, description='If true, save data required for '
++                                      'execution summary')
+
+
+ class KeepAliveThread(threading.Thread):",`default=True` shouldn't be used for BoolParameters iirc.
+7305,"@@ -35,6 +35,10 @@ func parsePrettyFormatLog(repo *Repository, logByts []byte) (*list.List, error)
+ }
+
+ func RefEndName(refStr string) string {
++	if strings.HasPrefix(refStr, ""refs/heads/"") {
++		return strings.TrimPrefix(refStr, ""refs/heads/"")
++	}
++
+ 	index := strings.LastIndex(refStr, ""/"")
+ 	if index != -1 {
+ 		return refStr[index+1:]",It would be better to use `return refStr[12:]`. or `11`... I have problem with counting..
+7306,"@@ -211,9 +211,7 @@ func ruleHash(state *core.BuildState, target *core.BuildTarget, runtime bool) []
+ 	for _, licence := range target.Licences {
+ 		h.Write([]byte(licence))
+ 	}
+-	for _, output := range target.TestOutputs {
+-		h.Write([]byte(output))
+-	}
++
+ 	for _, output := range target.OptionalOutputs {
+ 		h.Write([]byte(output))
+ 	}",Pretty sure these should only contribute to the runtime hash.
+7307,"@@ -1,4 +1,4 @@
+-<div id=""ncr-layout"">
++<div id=""gsa18f-layout"">
+   <table class=""w-container main-container"" width='800'>
+     <tr>
+       <td>","Just verifying: this change doesn't break the 18f layout, right?"
+7308,"@@ -120,14 +120,6 @@ func (c call) endStats(elapsed time.Duration, err error, isApplicationError bool
+ 			counter.Inc()
+ 		}
+ 		return
+-	case yarpcerrors.CodeOK:
+-		// If we got ""CodeOK"" it really means that this is not a yarpcError, in
+-		// which case this is another level of ""unknown"" error.
+-		c.edge.serverErrLatencies.Observe(elapsed)
+-		if counter, err := c.edge.serverFailures.Get(""unknown_internal_yarpc""); err == nil {
+-			counter.Inc()
+-		}
+-		return
+ 	}
+ 	// If this code is executed we've hit an error code outside the usual error
+ 	// code range, so we'll just log the string representation of that code.","we should keep this counter using the ""isYarpcError"" api"
+7309,"@@ -28,16 +28,16 @@ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.StructLike;
+ import org.apache.iceberg.relocated.com.google.common.base.Objects;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+ import org.apache.iceberg.types.Types;
+ import org.apache.iceberg.types.Types.StructType;
++import org.apache.iceberg.util.CaseInsensitiveMap;
+
+ public class GenericRecord implements Record, StructLike {
+   private static final LoadingCache<StructType, Map<String, Integer>> NAME_MAP_CACHE =
+       Caffeine.newBuilder()
+       .weakKeys()
+       .build(struct -> {
+-        Map<String, Integer> idToPos = Maps.newHashMap();
++        Map<String, Integer> idToPos = new CaseInsensitiveMap<>();
+         List<Types.NestedField> fields = struct.fields();
+         for (int i = 0; i < fields.size(); i += 1) {
+           idToPos.put(fields.get(i).name(), i);","Could we just use case insensitive strings as keys instead of creating a new map implementation? e.g. simply using a treemap with a comparator `Map<String, Integer> idToPos = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);` could work I think"
+7310,"@@ -67,7 +67,14 @@ namespace OpenTelemetry.Context
+         /// <returns>The slot previously registered.</returns>
+         public static RuntimeContextSlot<T> GetSlot<T>(string name)
+         {
+-            return (RuntimeContextSlot<T>)Slots[name];
++            if (Slots.TryGetValue(name, out var slot) && slot is RuntimeContextSlot<T> expectedSlot)
++            {
++                return expectedSlot;
++            }
++            else
++            {
++                return null;
++            }
+         }
+
+         /*",I think this should be a throw. Or the method should be TryGetSlot?
+7311,"@@ -3991,7 +3991,15 @@ int LuaScriptInterface::luaGameLoadMap(lua_State* L)
+ {
+ 	// Game.loadMap(path)
+ 	const std::string& path = getString(L, 1);
+-	g_dispatcher.addTask(createTask(std::bind(&Game::loadMap, &g_game, path)));
++	g_dispatcher.addTask(createTask( [path]() {
++		try {
++			g_game.loadMap(path);
++		} catch (const std::exception& e) {
++			// FIXME: Should only catch some exceptions
++			std::cout << ""[Error - LuaScriptInterface::luaGameLoadMap] Failed to load map: ""
++				<< e.what() << std::endl;
++		}
++	}));
+ 	return 0;
+ }
+ ","We don't usually put spaces between ( and [, and I think `path` should be passed by reference."
+7312,"@@ -419,12 +419,11 @@ int Zone::SaveTempItem(uint32 merchantid, uint32 npcid, uint32 item, int32 charg
+ 				if (!ml.origslot) {
+ 					ml.origslot = ml.slot;
+ 				}
+-
+-				if (charges > 0) {
++				bool IsStackable = database.GetItem(item)->Stackable;
++				if ((IsStackable && charges > 0) || (!IsStackable && sold)) {
+ 					database.SaveMerchantTemp(npcid, ml.origslot, item, ml.charges);
+ 					tmp_merlist.push_back(ml);
+-				}
+-				else {
++				} else {
+ 					database.DeleteMerchantTemp(npcid, ml.origslot);
+ 				}
+ 			}",Make sure to `snake_case` locally scoped variable names in the future
+7313,"@@ -56,6 +56,7 @@ type LogsConfig struct {
+ // RoutingRule holds the path to route requests to the service.
+ type RoutingRule struct {
+ 	Path string `yaml:""path""`
++	HealthCheckPath string `yaml:""healthcheck""`
+ }
+
+ // AutoScalingConfig is the configuration to scale the service with target tracking scaling policies.",Maybe we should use underscores like `health_check` - what do you think?
+7314,"@@ -139,6 +139,12 @@ func (v *volumeAPIOpsV1alpha1) read(volumeName string) (*v1alpha1.CASVolume, err
+ 		vol.Namespace = hdrNS
+ 	}
+
++	// use sc name from header if present
++	scName := v.req.Header.Get(string(v1alpha1.StorageClassKey))
++	if scName != """" {
++		vol.Annotations[string(v1alpha1.StorageClassKey)] = scName
++	}
++
+ 	vOps, err := volume.NewVolumeOperation(vol)
+ 	if err != nil {
+ 		return nil, CodedError(400, err.Error())",Do a TrimSpace before setting.
+7315,"@@ -41,6 +41,9 @@ type ENI struct {
+
+ 	// PrivateDNSName is the dns name assigned by the vpc to this eni
+ 	PrivateDNSName string `json:"",omitempty""`
++	// SubnetGatewayIPV4Address is the address to the subnet gateway for
++	// the eni
++	SubnetGatewayIPV4Address string `json:"",omitempty""`
+ }
+
+ // GetIPV4Addresses returns a list of ipv4 addresses allocated to the ENI","Are the fields in this struct grouped by IP address family or by function? There are separate fields for IPv4Addresses and IPv6Addresses, but a single field for DomainNameServers. Should this new field be named SubnetGatewayAddress with type array consisting of both IPv4 and IPv6 gateways?"
+7316,"@@ -38,7 +38,7 @@ class LinkTest < ActiveSupport::TestCase
+       new_link.revive_or_create
+     end
+
+-    deleted_link = Link.find(link)
++    deleted_link = Link.where(id: link.id).first
+     deleted_link.title.must_equal new_title
+     deleted_link.link_category_id.must_equal Link::CATEGORIES[:Forums]
+   end",.find(id) is being deprecated to Rails 5.
+7317,"@@ -4,6 +4,9 @@ import datetime
+ from itertools import product
+
+ import iris
++from iris.coords import DimCoord
++from iris.cube import CubeList
++from iris.experimental.equalise_cubes import equalise_attributes
+ from iris.util import guess_coord_axis
+
+ import numpy as np",Will be good to have the iris interface moved to geoviews. Could this be done for 1.10.6?
+7318,"@@ -152,7 +152,10 @@ func (cs *ClientServerImpl) Connect() error {
+ 	request, _ := http.NewRequest(""GET"", parsedURL.String(), nil)
+
+ 	// Sign the request; we'll send its headers via the websocket client which includes the signature
+-	utils.SignHTTPRequest(request, cs.AgentConfig.AWSRegion, ServiceName, cs.CredentialProvider, nil)
++	err = utils.SignHTTPRequest(request, cs.AgentConfig.AWSRegion, ServiceName, cs.CredentialProvider, nil)
++	if err != nil {
++		return err
++	}
+
+ 	timeoutDialer := &net.Dialer{Timeout: wsConnectTimeout}
+ 	tlsConfig := &tls.Config{ServerName: parsedURL.Host, InsecureSkipVerify: cs.AgentConfig.AcceptInsecureCert}",does this get wrapped in the calling method?
+7319,"@@ -195,6 +195,8 @@ class DictAuth(unittest.TestCase):
+             subprocess.check_output(
+                 store_cmd, encoding=""utf-8"", errors=""ignore"")
+
++    # TODO: This test should not test case-insensivity, only the successful
++    # group authorization. The permission tests should do that.
+     def test_group_auth(self):
+         """"""
+         Test for case insensitive group comparison at authorization.","Do we still need this test case? If your new test cases test this, then we can remove it."
+7320,"@@ -641,6 +641,15 @@ class Plan < ActiveRecord::Base
+     User.joins(:roles).where('roles.plan_id = ? AND roles.access IN (?)', self.id, vals).first
+   end
+
++  ##
++  # returns the shared roles of a plan, excluding the creator
++  def shared
++    role_values = Role.access_values_for(:commenter)
++                      .concat(Role.access_values_for(:editor))
++                      .concat(Role.access_values_for(:administrator)).uniq! - Role.access_values_for(:creator)
++    Role.where(plan: self, access: role_values)
++  end
++
+   ##
+   # the owner and co-owners of the project
+   #","If you want to express ""any role that is not creator"" you could use the following statement: Role.where(plan: self).where(Role.not_creator_condition).any? which would be less verbose and a bit more efficient if it is used for Yes/No shared?"
+7321,"@@ -188,14 +188,12 @@ func migrateJSONFile(from, to string) (bool, error) {
+ 		if len(chain) == 0 {
+ 			return nil, nil
+ 		}
+-		// The chain is in one of three states:
++		// The chain is in one of two states:
+ 		// 1) single self-signed cert
+-		// 2) single upstream-signed cert, implying upstream_bundle=false
+-		// 3) an upstream-signed cert followed by any intermediates and a root
++		// 2) an upstream-signed cert followed by any intermediates and a root
+ 		//
+-		// The ca should only be considered an ""intermediate"" in case #3, so a
+-		// check for more than one cert should be sufficient for that. However
+-		// we don't want the the root in the chain anymore, so remove it.
++		// In the case where the CA is an intermediate, we don't want to store
++		// the root, so remove it.
+ 		certificate := chain[0].Raw
+ 		var upstreamChain [][]byte
+ 		if len(chain) > 1 {",Do we need any update on the test side?
+7322,"@@ -4663,6 +4663,10 @@ func (fbo *folderBranchOps) notifyOneOpLocked(ctx context.Context,
+ 			return nil
+ 		}
+ 	}
++	// Cancel any block prefetches for unreferenced blocks.
++	for _, ptr := range op.Unrefs() {
++		fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)
++	}
+
+ 	fbo.observers.batchChanges(ctx, changes)
+ 	return nil",There's a few `return nil` cases above this -- we should probably move this above the big switch.
+7323,"@@ -33,6 +33,19 @@ func (tile TransactionInLedgerError) Error() string {
+ 	return fmt.Sprintf(""transaction already in ledger: %v"", tile.Txid)
+ }
+
++// LeaseInLedgerError is returned when a transaction cannot be added because it has a lease that already being used in the relavant rounds
++type LeaseInLedgerError struct {
++	txid  transactions.Txid
++	lease txlease
++}
++
++// Error implements the error interface for the LeaseInLedgerError stuct
++func (lile LeaseInLedgerError) Error() string {
++	// format the lease as address.
++	addr := basics.Address(lile.lease.lease)
++	return fmt.Sprintf(""transaction %v using an overlapping lease %s"", lile.txid, addr.String())
++}
++
+ // BlockInLedgerError is returned when a block cannot be added because it has already been done
+ type BlockInLedgerError struct {
+ 	LastRound basics.Round",`lile *LeaseInLedgerError` to reduce copying?
+7324,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent
+7325,"@@ -35,9 +35,9 @@ namespace Microsoft.VisualStudio.TestPlatform.Utilities.Helpers
+         }
+
+         /// <inheritdoc/>
+-        public Stream GetStream(string filePath, FileMode mode)
++        public Stream GetStream(string filePath, FileMode mode, FileAccess access = FileAccess.ReadWrite)
+         {
+-            return new FileStream(filePath, mode);
++            return new FileStream(filePath, mode, access);
+         }
+
+         /// <inheritdoc/>","We don't have a requirement anywhere in Test Platform for GetStream() with write access. It is ok to directly change `return new FileStream(filePath, mode, FileAccess.Read)`."
+7326,"@@ -22,12 +22,17 @@
+ import os
+ import os.path
+ import textwrap
++import string
++import functools
++import operator
+
+ import attr
+ import yaml
+ import pytest
+ import bs4
+
++import qutebrowser.browser.hints
++
+
+ def collect_tests():
+     basedir = os.path.dirname(__file__)",FWIW `from qutebrowser.browser import hints` is okay - it's just things like `from qutebrowser.browser.hints import HintManager` I try to avoid.
+7327,"@@ -11,7 +11,12 @@
+ namespace HFG;
+
+ use HFG\Core\Builder\Header as HeaderBuilder;
++
++$transparent_header_class = '';
++if ( get_theme_mod( 'neve_transparent_header', false ) ) {
++	$transparent_header_class = ' neve-tansparent-header';
++}
+ ?>
+-<div id=""header-grid""  class=""<?php echo esc_attr( get_builder( HeaderBuilder::BUILDER_NAME )->get_property( 'panel' ) ); ?> site-header"">
++<div id=""header-grid""  class=""<?php echo esc_attr( get_builder( HeaderBuilder::BUILDER_NAME )->get_property( 'panel' ) ) . esc_attr( $transparent_header_class ); ?> site-header"">
+ 	<?php render_builder( HeaderBuilder::BUILDER_NAME ); ?>
+ </div>","@preda-bogdan let's use a filter for the header classes, something like, hfg_header_classes where we hook this logic, in neve pro"
+7328,"@@ -21,7 +21,7 @@ import (
+ 	""time""
+
+ 	""github.com/containernetworking/plugins/pkg/ip""
+-	""k8s.io/api/core/v1""
++	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/labels""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+ 	""k8s.io/client-go/informers""",Out of curiosity.. is there a rule to determine the package name as prevDirectory+currentDirectory.
+7329,"@@ -53,7 +53,9 @@ get_xmm_vals(priv_mcontext_t *mc)
+ #ifdef X86
+     if (preserve_xmm_caller_saved()) {
+         ASSERT(proc_has_feature(FEATURE_SSE));
+-        if (YMM_ENABLED())
++        if (ZMM_ENABLED())
++            get_zmm_caller_saved(&mc->simd[0]);
++        else if (YMM_ENABLED())
+             get_ymm_caller_saved(&mc->simd[0]);
+         else
+             get_xmm_caller_saved(&mc->simd[0]);",It seems this needs to check the lazy cxt switching flag. It is used on the initial thread for early injection and in other places where the lazy switch should apply.
+7330,"@@ -21,9 +21,10 @@ import { isValidPropertyID } from './validation';
+ /**
+  * Parses the bits of a valid property ID into an object of its components.
+  *
++ * See: https://support.google.com/analytics/answer/7372977.
++ *
+  * @since 1.8.0
+  *
+- * @see {@link https://support.google.com/analytics/answer/7372977}
+  * @param {string} propertyID Property ID to parse.
+  * @return {(Object|undefined)} Object of property ID components if valid, otherwise false.
+  */",Why not use the JSdoc annotation as it did before?
+7331,"@@ -108,7 +108,11 @@ public class ParseUtil {
+     String version = packageImplementationVersion;
+     String edition = ProcessEngineDetails.EDITION_COMMUNITY;
+
+-    if (version != null && version.contains(""-ee"")) {
++    if (version == null){
++      version = ProductPropertiesUtil.getProductVersion();
++    }
++
++    if (version.contains(""-ee"")) {
+       edition = ProcessEngineDetails.EDITION_ENTERPRISE;
+       if (trimSuffixEE) {
+         version = version.replace(""-ee"", """"); // trim `-ee` suffix",Why don't we drop the packageImplementationVersion in general? That way the version will be fetch all that time only from the properties file and it will be consistent.
+7332,"@@ -1076,6 +1076,9 @@ class CppGenerator : public BaseGenerator {
+       code_ += ""  };"";
+     }
+
++    // Found fields with union type.
++    std::vector<const FieldDef*> union_fields;
++
+     // Generate the accessors.
+     for (auto it = struct_def.fields.vec.begin();
+          it != struct_def.fields.vec.end(); ++it) {","Please use the style of the rest of the code, a space between the type and `*`"
+7333,"@@ -25,6 +25,8 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+
+         private MockProcessManager mockProcessManager;
+
++
++
+         [TestInitialize]
+         public void TestInit()
+         {",nit: remove extra blank lines.
+7334,"@@ -39,6 +39,7 @@ const (
+ 	appEnvOptionNone      = ""None (run in default VPC)""
+ 	defaultDockerfilePath = ""Dockerfile""
+ 	imageTagLatest        = ""latest""
++	taskGroupNameDefault  = ""copilot-task""
+ )
+
+ const (",nit: What do you think of `copilot-task-group`?
+7335,"@@ -156,6 +156,7 @@ export function setProperty(dom, name, value, oldValue, isSvg) {
+  */
+ function eventProxy(e) {
+ 	this._listeners[e.type + false](options.event ? options.event(e) : e);
++	if (e.type === 'input' || e.type === 'change') this.value = this._prevValue || '';
+ }
+
+ function eventProxyCapture(e) {",We should check whether or not the input node has a value since we can just have an onChange on an uncontrolled component as well.
+7336,"@@ -13,7 +13,7 @@ how the API has changed as well as the range of API versions supported by this b
+ """"""
+
+ CURRENT = (buildVersion.version_year, buildVersion.version_major, buildVersion.version_minor)
+-BACK_COMPAT_TO = (2019, 3, 0)
++BACK_COMPAT_TO = (2021, 1, 0)
+ """"""
+ As BACK_COMPAT_TO is incremented, the changed / removed parts / or reasoning should be added below.
+ EG: (x, y, z): Large changes to speech.py",I think there should be some reasoning below this line about the version updating.
+7337,"@@ -371,6 +371,17 @@ static int on_body(h2o_http1client_t *client, const char *errstr)
+     return 0;
+ }
+
++static char compress_hint_to_enum(const char *val, size_t len)
++{
++    if (!strncasecmp(""ON"", val, len)) {
++        return H2O_COMPRESS_HINT_ENABLE;
++    }
++    if (!strncasecmp(""OFF"", val, len)) {
++        return H2O_COMPRESS_HINT_DISABLE;
++    }
++    return H2O_COMPRESS_HINT_AUTO;
++}
++
+ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *errstr, int minor_version, int status,
+                                        h2o_iovec_t msg, h2o_http1client_header_t *headers, size_t num_headers)
+ {","Please use `h2o_lcstris` instead of `strncasecmp` so that the comparison would be a complete match (instead of a prefix match; current code would yield true if [val,len] is [""O"", 1]) and that it would be locale-independent."
+7338,"@@ -333,7 +333,13 @@ var _ fbmHelper = (*folderBranchOps)(nil)
+ // newFolderBranchOps constructs a new folderBranchOps object.
+ func newFolderBranchOps(config Config, fb FolderBranch,
+ 	bType branchType) *folderBranchOps {
+-	nodeCache := newNodeCacheStandard(fb)
++	var nodeCache NodeCache
++	if config.Mode() != InitMinimal {
++		nodeCache = newNodeCacheStandard(fb)
++	} else {
++		// If we're in minimal mode, let the block cache remain nil to
++		// ensure that the user doesn't try any data reads or writes.
++	}
+
+ 	// make logger
+ 	branchSuffix := """"",I prefer if possible for `if`/`else` statements to have the positive case first.
+7339,"@@ -33,9 +33,18 @@ from scapy.base_classes import BasePacketList
+ ## Tools ##
+ ###########
+
++def issubtype(x, t):
++    """"""issubtype(C, B) -> bool
++
++    Return whether C is a class and if it is a subclass of class B.
++    When using a tuple as the second argument issubtype(X, (A, B, ...)),
++    is a shortcut for issubtype(X, A) or issubtype(X, B) or ... (etc.).
++    """"""
++    return isinstance(x, type) and issubclass(x, t)
++
+ def get_temp_file(keep=False, autoext=""""):
+     """"""Create a temporary file and return its name. When keep is False,
+-the file is deleted when scapy exits.
++    the file is deleted when scapy exits.
+
+     """"""
+     fname = tempfile.NamedTemporaryFile(prefix=""scapy"", suffix=autoext,",Docstring would be nice
+7340,"@@ -23,6 +23,7 @@ import org.gradle.api.provider.ListProperty;
+ public class BaselineErrorProneExtension {
+     private static final ImmutableList<String> DEFAULT_PATCH_CHECKS = ImmutableList.of(
+             // Baseline checks
++            ""CatchBlockLogException"",
+             ""ExecutorSubmitRunnableFutureIgnored"",
+             ""LambdaMethodReference"",
+             ""OptionalOrElseMethodInvocation"",",Low risk to fix this by default because existing baseline consumers pass this check. We don't attempt to fix checks that have been opted out of.
+7341,"@@ -77,7 +77,16 @@ void OpenMPTargetInternal::impl_finalize() {
+     Kokkos::kokkos_free<Kokkos::Experimental::OpenMPTargetSpace>(
+         space.m_uniquetoken_ptr);
+ }
+-void OpenMPTargetInternal::impl_initialize() { m_is_initialized = true; }
++void OpenMPTargetInternal::impl_initialize() {
++  m_is_initialized = true;
++
++  // FIXME_OPENMPTARGET:  Only fix the number of teams for NVIDIA architectures.
++#if defined(KOKKOS_ARCH_VOLTA70) || defined(KOKKOS_ARCH_PASCAL60)
++#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300)
++  omp_set_num_teams(512);
++#endif
++#endif
++}
+ int OpenMPTargetInternal::impl_is_initialized() {
+   return m_is_initialized ? 1 : 0;
+ }","What about `VOLTA72`, `TURING75`, `AMPERE80` and `AMPERE86`? We only want to set the number of teams for these two architectures or for all the architectures newer than Maxwell?"
+7342,"@@ -1,7 +1,7 @@
+ # model settings
+ model = dict(
+     type='FasterRCNN',
+-    pretrained='modelzoo://resnet50',
++    pretrained='torchvision://resnet50',
+     backbone=dict(
+         type='ResNet',
+         depth=50,","Since we have specified `load_from`, `pretrained` can be left None."
+7343,"@@ -71,6 +71,9 @@ func logParse(c *caddy.Controller) ([]*Rule, error) {
+ 				},
+ 				Format: DefaultLogFormat,
+ 			})
++		} else if len(args) > 3 {
++			// Maxiumum number of args in log directive is 3.
++			return nil, c.ArgErr()
+ 		} else {
+ 			// Path scope, output file, and maybe a format specified
+ ",I prefer to translate these `else if` into `switch` for more readability.
+7344,"@@ -3,12 +3,13 @@ class Api::V1::StatusesController < ApiController
+
+   def create
+     exercise.statuses.create!(user: resource_owner, state: params[:state])
++    exercise.update_trails_state_for(resource_owner)
+     render nothing: true
+   end
+
+   private
+
+   def exercise
+-    Exercise.find_by!(uuid: params[:exercise_uuid])
++    @exercise ||= Exercise.find_by!(uuid: params[:exercise_uuid])
+   end
+ end",This can also be a local variable in `create`.
+7345,"@@ -1273,6 +1273,19 @@ func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err e
+ 			}
+ 		}
+
++		// Create/Remove git-daemon-export-ok for git-daemon...
++		daemonExportFile := strings.Join([]string{repo.RepoPath(), `git-daemon-export-ok`}, ""/"")
++		if repo.IsPrivate {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			os.Remove(daemonExportFile)
++		} else {
++			// NOTE: Gogs only cares to check errors so we don't get other errors by closing a file that isn't open...
++			f, err := os.Create(daemonExportFile)
++			if err == nil {
++				f.Close()
++			}
++		}
++
+ 		forkRepos, err := getRepositoriesByForkID(e, repo.ID)
+ 		if err != nil {
+ 			return fmt.Errorf(""getRepositoriesByForkID: %v"", err)",Why not use `path.Join`?
+7346,"@@ -7,4 +7,8 @@ if ( typeof global.googlesitekit === 'undefined' ) {
+ 	global.googlesitekit = {};
+ }
+
+-global.googlesitekit.api = API;
++if ( typeof global.googlesitekit.api === 'undefined' ) {
++	global.googlesitekit.api = API;
++}
++
++export * from 'assets/js/googlesitekit/api';",Why not `export default API` instead? This ensures we export the same that we export on the global.
+7347,"@@ -552,7 +552,7 @@ def imread(filename, pixel_type=None, fallback_only=False):
+         increase_dimension=False
+         kwargs={'FileName':filename}
+     if pixel_type:
+-        imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.ReadMode)
++        imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode)
+         if not imageIO:
+             raise RuntimeError(""No ImageIO is registered to handle the given file."")
+         imageIO.SetFileName(io_filename)",This is a good change I think. It greatly helps reduce name conflicts.
+7348,"@@ -46,6 +46,12 @@ type jetStreamCluster struct {
+ 	consumerResults *subscription
+ }
+
++// Used to guide placement of streams in clustered JetStream.
++type Placement struct {
++	Cluster string   `json:""cluster""`
++	Tags    []string `json:""tags,omitempty""`
++}
++
+ // Define types of the entry.
+ type entryOp uint8
+ ","cluster not having omitempty, does this imply that cluster is required? seems empty is valid so just checking"
+7349,"@@ -758,3 +758,19 @@ func (c *Container) ShouldCreateWithSSMSecret() bool {
+ 	}
+ 	return false
+ }
++
++// MergeEnvironmentVariables appends additional envVarName:envVarValue pairs to
++// the the container's enviornment values structure
++func (c *Container) MergeEnvironmentVariables(secrets map[string]string) {
++	c.lock.Lock()
++	defer c.lock.Unlock()
++
++	// don't assume that the environment variable map has been initialized by others
++	if c.Environment == nil {
++		c.Environment = make(map[string]string)
++	}
++
++	for k, v := range secrets {
++		c.Environment[k] = v
++	}
++}","@aws/aws-ecs-agent, @yumex93: how concerned should we be about user provided envvar names clobbering existing envvars? i'm not convinced we should be doing additional validation here."
+7350,"@@ -0,0 +1,14 @@
++'use strict';
++
++function defineAspects(operation, aspects) {
++  aspects = new Set(aspects);
++  Object.defineProperty(operation, 'aspects', {
++    value: aspects,
++    writable: false
++  });
++  return aspects;
++}
++
++module.exports = {
++  defineAspects
++};","nit: aspects are defined in `OperationBase`, should `defineAspects` live there as well?"
+7351,"@@ -5,12 +5,15 @@ from collections import OrderedDict
+
+ from kinto.core.permission import PermissionBase
+ from kinto.core.storage.postgresql.client import create_from_config
++from kinto.core.storage.postgresql.migrator import Migrator
+
+
+ logger = logging.getLogger(__name__)
+
++HERE = os.path.abspath(os.path.dirname(__file__))
+
+-class Permission(PermissionBase):
++
++class Permission(PermissionBase, Migrator):
+     """"""Permission backend using PostgreSQL.
+
+     Enable in configuration::",Why the `os.path.abspath`? `os.path.dirname` should always give a valid directory path.
+7352,"@@ -143,4 +143,8 @@ public class ControllerConfiguration {
+                 settingsConfiguration.settingsManager()
+         );
+     }
++
++    public String getWineEnginesPath() {
++        return this.wineEnginesPath;
++    }
+ }",I think we should not consider special engine types on this level. I would prefer to build the specific engine path based on `application.user.engines` later on.
+7353,"@@ -78,6 +78,12 @@ bool IndexPolicyMaker::buildPolicy() {
+         if (exist == scanItems_.end()) {
+             break;
+         }
++        // Stop build policy when last operator is range scan,
++        // And other fields will use expression filtering.
++        auto it = scanItems_.rbegin()->second;
++        if (it.endBound_.rel_ != RelationType::kEQRel) {
++            break;
++        }
+     }
+     // re-check operatorList_.
+     // if operatorList_ is not empty, that means there are still fields to filter",Is `rbegin` correct? We can't make sure that the last index column is the `rbegin` of `scanItems`.
+7354,"@@ -108,6 +108,8 @@ func main() {
+ 		glog.Fatalln(""EVM Network ID is not set, call config.New() first"")
+ 	}
+
++	config.SetChainID(cfg.Chain.ID)
++
+ 	cfg.Genesis = genesisCfg
+ 	cfgToLog := cfg
+ 	cfgToLog.Chain.ProducerPrivKey = """"","check it is != 0, just like `EVMNetworkID` above"
+7355,"@@ -186,6 +186,8 @@ namespace OpenTelemetry
+             this.shutdownDrainTarget = this.circularBuffer.AddedCount;
+             this.shutdownTrigger.Set();
+
++            OpenTelemetrySdkEventSource.Log.DroppedExportProcessorItems(nameof(BatchExportProcessor<T>), typeof(T).Name, this.exporter.GetType().Name, this.droppedCount);
++
+             if (timeoutMilliseconds == Timeout.Infinite)
+             {
+                 this.exporterThread.Join();","if you just do ""this.GetType().Name"" and ""this.exporter.GetType().Name"", we get what we need."
+7356,"@@ -26,16 +26,13 @@
+  */
+ package com.salesforce.androidsdk.rest;
+
+-import com.salesforce.androidsdk.R;
+-import com.salesforce.androidsdk.app.SalesforceSDKManager;
+
+ /**
+  * This is where all the API version info lives. This allows us to change one
+  * line here and affect all our api calls.
+  */
+ public class ApiVersionStrings {
+-    public static final String VERSION_NUMBER = SalesforceSDKManager.getInstance().
+-    		getAppContext().getResources().getString(R.string.api_version);
++    public static final String VERSION_NUMBER = ""v29.0"";
+     public static final String API_PREFIX = ""/services/data/"";
+     public static final String BASE_PATH = API_PREFIX + VERSION_NUMBER;
+     public static final String BASE_CHATTER_PATH = BASE_PATH + ""/chatter/"";","That's the code that would prevent any SalesforceSDKTest from running. At class loading time, SalesforceSDKManager.getInstance() would throw a RuntimeException because init() had never been called."
+7357,"@@ -34,4 +34,6 @@ public interface DefinitionConst {
+   String VERSION_RULE_LATEST = ""latest"";
+
+   String VERSION_RULE_ALL = ""0.0.0+"";
++
++  String DEFAULT_REVISION = ""0"";
+ }","there is no ""DEFAULT_REVISION"" logic, no need to define this."
+7358,"@@ -289,6 +289,9 @@ public class SalesforceSDKManager {
+                 loginOptions = new LoginOptions(url, getPasscodeHash(), config.getOauthRedirectURI(),
+                         config.getRemoteAccessConsumerKey(), config.getOauthScopes(), null, jwt);
+             }
++        } else {
++            loginOptions.setJwt(jwt);
++            loginOptions.setUrl(url);
+         }
+         return loginOptions;
+     }","so this is to fix a scenario where the app is first launched normally, then background and foreground through the link, we are not updating loginOption"
+7359,"@@ -322,6 +322,14 @@ class Application extends BaseApplication {
+ 		});
+ 	}
+
++	checkLayout(layout) {
++		if (layout === 'viewer') {
++			this.focusElement_('noteTextViewer');
++		} else {
++			this.focusElement_('noteBody');
++		}
++	}
++
+ 	async updateMenu(screen) {
+ 		if (this.lastMenuScreen_ === screen) return;
+ ","It doesn't seem like the right way to implement this, because you add a new element that doesn't really exist (noteTextViewer). Instead you should modify the command handler `if (command.name === 'focusElement' && command.target === 'noteBody') {` in NoteText.jsx. Then focus either the editor or the viewer depending on what's currently visible."
+7360,"@@ -21,7 +21,12 @@ package org.apache.iceberg.avro;
+
+ import com.google.common.base.Preconditions;
+ import com.google.common.collect.Lists;
++
++import java.util.HashSet;
++import java.util.LinkedList;
+ import java.util.List;
++import java.util.Set;
++
+ import org.apache.avro.LogicalType;
+ import org.apache.avro.LogicalTypes;
+ import org.apache.avro.Schema;",We don't add blank lines in imports.
+7361,"@@ -1,7 +1,7 @@
+ # -*- coding: UTF-8 -*-
+ #addonHandler.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2012-2018 Rui Batista, NV Access Limited, Noelia Ruiz Martínez, Joseph Lee, Babbage B.V.
++#Copyright (C) 2012-2019 Rui Batista, NV Access Limited, Noelia Ruiz Martínez, Joseph Lee, Babbage B.V.
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",Please add your name to the copyright list.
+7362,"@@ -243,6 +243,11 @@ func (r *replacer) getSubstitution(key string) string {
+ 	case ""{path_escaped}"":
+ 		u, _ := r.request.Context().Value(OriginalURLCtxKey).(url.URL)
+ 		return url.QueryEscape(u.Path)
++	case ""{request_id}"":
++		reqid, _ := r.request.Context().Value(RequestIDCtxKey).(string)
++		if reqid != """" {
++			return reqid
++		}
+ 	case ""{rewrite_path}"":
+ 		return r.request.URL.Path
+ 	case ""{rewrite_path_escaped}"":","You can elide the `if` check for empty string, because if it's not a value that is set, the string will be empty anyway."
+7363,"@@ -1,8 +1,8 @@
+ /*global countlyVue, CV, countlyCommon, Promise, moment*/
+ (function(countlyPushNotification) {
+
+-    var messagesSentLabel = CV.i18n('push-notification.time-chart-serie-messages-sent');
+-    var actionsPerformedLabel = CV.i18n('push-notification.time-chart-serie-actions-performed');
++    var messagesSentLabel = CV.i18n('push-notification.messages-sent-serie-name');
++    var actionsPerformedLabel = CV.i18n('push-notification.actions-performed-serie-name');
+
+     var StatusFinderHelper = {
+         STATUS_SHIFT_OPERATOR_ENUM: {",Different i18n keys. By mistake or on purpose?
+7364,"@@ -59,3 +59,18 @@ type SecretKeySelector struct {
+ const (
+ 	TLSCAKey = ""ca.crt""
+ )
++
++// Describes how the ACME challenge self check behaves when it fails.
++type ACMESelfCheckFailurePolicy string
++
++const (
++	// The default failure policy. This policy will cause the request to be
++	// sent to the certificate provider ONLY if the ACME challenge self check
++	// succeeds. The request is retried continuously and the `Certificate` will
++	// remain `Pending` indefinitely.
++	ACMESelfCheckFailurePolicyRetryForever ACMESelfCheckFailurePolicy = ""RetryForever""
++
++	// This policy will cause the ACME challenge self check response to be
++	// ignored and the request will always be sent to the certificate provider.
++	ACMESelfCheckFailurePolicyIgnore ACMESelfCheckFailurePolicy = ""Ignore""
++)","Given the description for this is `// Describes how the ACME challenge self check behaves when it fails.`, perhaps `RetryForever` is better terminology here as when the check fails, we don't just wait, we retry periodically."
+7365,"@@ -187,14 +187,14 @@ _ostree_gpg_verifier_check_signature (OstreeGpgVerifier  *self,
+           gpg_error = gpgme_data_new_from_fd (&kdata, fd);
+           if (gpg_error != GPG_ERR_NO_ERROR)
+             {
+-              ot_gpgme_error_to_gio_error (gpg_error, error);
++              ot_gpgme_throw (gpg_error, error, ""Loading data from fd %i"", fd);
+               goto out;
+             }
+
+           gpg_error = gpgme_op_import (result->context, kdata);
+           if (gpg_error != GPG_ERR_NO_ERROR)
+             {
+-              ot_gpgme_error_to_gio_error (gpg_error, error);
++              ot_gpgme_throw (gpg_error, error, ""import"");
+               goto out;
+             }
+         }",Nit: let's add a more descriptive prefix in line with the other ones? E.g. `Unable to import key` ?
+7366,"@@ -13,6 +13,7 @@ describe Bolt::SSH do
+   let(:user) { ENV['BOLT_SSH_USER'] || ""vagrant"" }
+   let(:password) { ENV['BOLT_SSH_PASSWORD'] || ""vagrant"" }
+   let(:port) { ENV['BOLT_SSH_PORT'] || 2224 }
++  let(:key) { ENV['BOLT_SSH_KEY'] || Dir["".vagrant/**/private_key""] }
+   let(:command) { ""pwd"" }
+   let(:ssh) { Bolt::SSH.new(hostname, port, user, password) }
+   let(:insecure) { { config: Bolt::Config.new(insecure: true) } }",This looks like it will pass an array as `:key` in the default case. That doesn't reflect how this will actually work in practice.
+7367,"@@ -0,0 +1,11 @@
++#if NETFRAMEWORK
++namespace Datadog.Trace.IntegrationTests
++{
++    public static class Program
++    {
++        public static void Main()
++        {
++        }
++    }
++}
++#endif",Do we need this?
+7368,"@@ -282,6 +282,11 @@ func (b *ofFlowBuilder) MatchConjID(value uint32) FlowBuilder {
+ 	return b
+ }
+
++func (b *ofFlowBuilder) MatchPriority(priority uint16) FlowBuilder {
++	b.Match.Priority = priority
++	return b
++}
++
+ // MatchProtocol adds match condition for matching protocol type.
+ func (b *ofFlowBuilder) MatchProtocol(protocol Protocol) FlowBuilder {
+ 	switch protocol {","I am a bit confused about this function. If it is used to set priority, we actually use function ""Table.BuildFlow(priority uint16)"" to set the value. If it is used to parse the priority value, I think adding a property(if you don't want to consume Match.Priority directly) to cache it and consume that property should be simpler than using string regex."
+7369,"@@ -68,7 +68,7 @@ func main() {
+ }
+
+ // addUnresolvedPackage adds an unresolved node to the graph representing the
+-// packged described in the PackgetVer structure. Returns an error if the node
++// packaged described in the PackgetVer structure. Returns an error if the node
+ // could not be created.
+ func addUnresolvedPackage(g *pkggraph.PkgGraph, pkgVer *pkgjson.PackageVer) (newRunNode *pkggraph.PkgNode, err error) {
+ 	logger.Log.Debugf(""Adding unresolved %s"", pkgVer)","In this case we probably meant ""package""."
+7370,"@@ -0,0 +1,19 @@
++const fs = require('fs');
++const { promisify } = require('util');
++const { dirname: getDirName } = require('path');
++const makeDir = require('make-dir');
++const writeFile = promisify(fs.writeFile);
++
++/**
++ * Create file with given contents at specified location
++ * @method createFile
++ * @param {String} path file path, inclusive of file name
++ * @param {String} content contents of the file
++ * @returns {Promise}
++ */
++const createFile = (path, content) =>
++	makeDir(getDirName(path)).then(() => writeFile(path, content));
++
++module.exports = {
++	createFile
++};",Just export `createFile` directly.
+7371,"@@ -175,6 +175,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Docker.ResultsTimeout = cli.Duration(20 * time.Second)
+ 	config.Docker.RemoveTimeout = cli.Duration(20 * time.Second)
+ 	config.Go.GoTool = ""go""
++	config.Go.BuildIdTool = ""//tools/go_buildid_replacer""
+ 	config.Go.CgoCCTool = ""gcc""
+ 	config.Go.GoPath = ""$TMP_DIR:$TMP_DIR/src:$TMP_DIR/$PKG_DIR:$TMP_DIR/third_party/go:$TMP_DIR/third_party/""
+ 	config.Python.PipTool = ""pip3""",This probably needs to get shipped with plz; you shouldn't have to redefine it within the user's repo. It should use `defaultPath` like the other things up the top of the file.
+7372,"@@ -4,7 +4,7 @@ var run = function() {
+   var WalletKey = bitcore.WalletKey;
+   var Builder = bitcore.TransactionBuilder;
+   var opts = {
+-    network: networks.testnet
++    network: networks['btc'].testnet
+   };
+
+   console.log('## Network: ' + opts.network.name);",interface for bitcoin should not change if possible. i.e: networks.testnet should return networks['btc'].testnet
+7373,"@@ -12,6 +12,7 @@ import (
+ 	""fmt""
+ 	""math/big""
+ 	""syscall""
++	""io/ioutil""
+
+ 	""github.com/golang/protobuf/proto""
+ 	""github.com/spf13/cobra""",File is not `gofmt`-ed with `-s` (from `gofmt`)
+7374,"@@ -929,3 +929,17 @@ void wlr_surface_send_leave(struct wlr_surface *surface,
+ 		}
+ 	}
+ }
++
++static inline int64_t timespec_to_msec(const struct timespec *a) {
++	return (int64_t)a->tv_sec * 1000 + a->tv_nsec / 1000000;
++}
++
++void wlr_surface_send_frame_done(struct wlr_surface *surface,
++		const struct timespec *when) {
++	struct wlr_frame_callback *cb, *cnext;
++	wl_list_for_each_safe(cb, cnext, &surface->current->frame_callback_list,
++			link) {
++		wl_callback_send_done(cb->resource, timespec_to_msec(when));
++		wl_resource_destroy(cb->resource);
++	}
++}",We have this functions in a couple of places. It should probably live in util or something.
+7375,"@@ -53,6 +53,7 @@ module Mongoid
+                 # The associated object will be replaced by the below update if non-nil, so only
+                 # run the callbacks and state-changing code by passing persist: false in that case.
+                 _target.destroy(persist: !replacement) if persistable?
++                _target.new_record = true
+               end
+               unbind_one
+               return nil unless replacement",maybe this should be inside the destroy?
+7376,"@@ -106,10 +106,17 @@ class RPN(BaseDetector):
+             list[np.ndarray]: proposals
+         """"""
+         x = self.extract_feat(img)
++        # get origin input shape to onnx dynamic input shape
++        import torch
++        if torch.onnx.is_in_onnx_export():
++            img_shape = torch._shape_as_tensor(img)[2:]
++            img_metas[0]['img_shape_for_onnx'] = img_shape
+         proposal_list = self.rpn_head.simple_test_rpn(x, img_metas)
+         if rescale:
+             for proposals, meta in zip(proposal_list, img_metas):
+                 proposals[:, :4] /= proposals.new_tensor(meta['scale_factor'])
++        if torch.onnx.is_in_onnx_export():
++            return proposal_list
+
+         return [proposal.cpu().numpy() for proposal in proposal_list]
+ ",Do not import torch in the test function because it will import torch every test iteration and will slow down the testing speed.
+7377,"@@ -69,11 +69,16 @@ func (s *Service) InstanceByTags(machine *actuators.MachineScope) (*v1alpha1.Ins
+ }
+
+ // InstanceIfExists returns the existing instance or nothing if it doesn't exist.
+-func (s *Service) InstanceIfExists(id string) (*v1alpha1.Instance, error) {
+-	klog.V(2).Infof(""Looking for instance %q"", id)
++func (s *Service) InstanceIfExists(id *string) (*v1alpha1.Instance, error) {
++	if id == nil {
++		klog.Error(""Instance does not have an instance id"")
++		return nil, nil
++	}
++
++	klog.V(2).Infof(""Looking for instance %q"", *id)
+
+ 	input := &ec2.DescribeInstancesInput{
+-		InstanceIds: []*string{aws.String(id)},
++		InstanceIds: []*string{id},
+ 		Filters: []*ec2.Filter{
+ 			filter.EC2.VPC(s.scope.VPC().ID),
+ 			filter.EC2.InstanceStates(ec2.InstanceStateNamePending, ec2.InstanceStateNameRunning),","I think we want to return an error here, not nil."
+7378,"@@ -38,6 +38,7 @@ describe( 'core/user userInfo', () => {
+ 			picture: 'https://path/to/image',
+ 		},
+ 		verified: true,
++		userInputState: 'complete',
+ 	};
+
+ 	let registry;","Nitpicking, but I think it would be more accurate to use an actually supported value, i.e. `completed`."
+7379,"@@ -0,0 +1,17 @@
++class OhAdmin::JobsController < ApplicationController
++  before_action :admin_session_required
++  before_action :find_project
++  layout 'admin'
++  helper JobApiHelper
++
++  def index
++    @response = JSON.parse(ApiJob.new(@project.id, params[:page]).get)
++  end
++
++  private
++
++  def find_project
++    @project = Project.find_by_vanity_url(params[:project_id])
++    raise ParamRecordNotFound if @project.nil?
++  end
++end","How about renaming the `ApiJob` class to `JobApi`. As per rails convention, get method is to get a single object, not a collection, can we change that to `fetch`/`where`. It would be great if we can move the `get` method to a class method."
+7380,"@@ -427,12 +427,14 @@ func TestCreateBlockchain(t *testing.T) {
+ 	require.NoError(registry.Register(account.ProtocolID, acc))
+ 	rp := rolldpos.NewProtocol(cfg.Genesis.NumCandidateDelegates, cfg.Genesis.NumDelegates, cfg.Genesis.NumSubEpochs)
+ 	require.NoError(registry.Register(rolldpos.ProtocolID, rp))
+-	bc := NewBlockchain(cfg, nil, InMemStateFactoryOption(), InMemDaoOption(), RegistryOption(&registry))
++	sf, err := factory.NewFactory(cfg, factory.InMemTrieOption())
++	require.NoError(err)
++	bc := NewBlockchain(cfg, nil, sf, InMemDaoOption(), RegistryOption(&registry))
+ 	bc.Validator().AddActionEnvelopeValidators(protocol.NewGenericValidator(bc))
+ 	exec := execution.NewProtocol(bc, hu)
+ 	require.NoError(registry.Register(execution.ProtocolID, exec))
+ 	bc.Validator().AddActionValidators(acc, exec)
+-	bc.GetFactory().AddActionHandlers(acc, exec)
++	sf.AddActionHandlers(acc, exec)
+ 	require.NoError(bc.Start(ctx))
+ 	require.NotNil(bc)
+ 	height := bc.TipHeight()",assignments should only be cuddled with other assignments (from `wsl`)
+7381,"@@ -54,3 +54,11 @@ func (c *Cache) Delete(key interface{}) error {
+ 	c.values.Delete(key)
+ 	return nil
+ }
++
++func (c *Cache) GetAll() ([]interface{}, error) {
++	return nil, cache.ErrUnimplemented
++}
++
++func (c *Cache) PutHash(k interface{}, v interface{}) error {
++	return cache.ErrUnimplemented
++}",`k` is unused in PutHash
+7382,"@@ -39,7 +39,7 @@ interface StatementsSource extends FileSource
+
+     public function isStatic(): bool;
+
+-    public function getSource(): ?StatementsSource;
++    public function getSource(): StatementsSource;
+
+     public function getCodebase() : Codebase;
+ ","None of the child return null here, plus it was creating an incoherence between interfaces."
+7383,"@@ -1076,7 +1076,7 @@ pony_ctx_t* ponyint_sched_init(uint32_t threads, bool noyield, bool nopin,
+
+   // If minimum thread count is > thread count, cap it at thread count
+   if(min_threads > threads)
+-    min_threads = threads;
++    min_threads = threads; // this becomes the equivalent of --ponynoscale
+
+   // convert to cycles for use with ponyint_cpu_tick()
+   // 1 second = 2000000000 cycles (approx.)",Should we remove this entirely now then?
+7384,"@@ -0,0 +1,17 @@
++package monitor
++
++import (
++	""github.com/weaveworks/weave/net/address""
++)
++
++// Monitor is an interface for tracking changes in ring allocations.
++type Monitor interface {
++	// HandleUpdate is called whenever an address ring gets updated.
++	//
++	// prevRanges corresponds to ranges which were owned by a peer before
++	// a change in the ring, while currRanges to the ones which are currently
++	// owned by the peer.
++	HandleUpdate(prevRanges, currRanges []address.Range) error
++	// String returns a user-friendly name of the monitor.
++	String() string
++}",That is way too generic a name.
+7385,"@@ -49,4 +49,11 @@ describe('duplicate-id', function () {
+ 		assert.isTrue(checks['duplicate-id'].evaluate.call(checkContext, node));
+ 	});
+
++	it('should allow overwrote ids', function () {
++		fixture.innerHTML = '<form data-testelm=""1"" id=""target""><input name=""id""></form>';
++		var node = fixture.querySelector('[data-testelm=""1""]');
++
++		assert.isTrue(checks['duplicate-id'].evaluate.call(checkContext, node));
++	});
++
+ });",This might be overkill for test code...but as stewards of accessibility it would be appropriate to have a label in the fixture.
+7386,"@@ -232,7 +232,16 @@ TEST_F(VkBestPracticesLayerTest, CmdClearAttachmentTest) {
+     ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
+
+     m_commandBuffer->begin();
+-    m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo);
++
++    auto* secondary_full_clear = new VkCommandBufferObj(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
++    auto* secondary_small_clear = new VkCommandBufferObj(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
++    VkCommandBufferBeginInfo begin_info = { VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO };
++    begin_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT |
++                       VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT;
++    VkCommandBufferInheritanceInfo inherit_info = { VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO };
++    begin_info.pInheritanceInfo = &inherit_info;
++    inherit_info.subpass = 0;
++    inherit_info.renderPass = m_renderPassBeginInfo.renderPass;
+
+     // Main thing we care about for this test is that the VkImage obj we're
+     // clearing matches Color Attachment of FB","Are these allocations necessary, or can these be instantiated normally (i.e., `VkCommandBufferObj secondary_full_clear(...)`). If the allocations _are_ necessar, I'd vote for using something like `std::unique_ptr` and then remove the associated `delete`s."
+7387,"@@ -43,6 +43,8 @@ public class InternalForTests {
+
+   public static void clear(ElasticsearchHttpStorage es) throws IOException {
+     es.clear();
++    // clear servicespan cache in order to prevent tests breaking
++    ((ElasticsearchHttpSpanConsumer)es.asyncSpanConsumer()).resetIndexToServiceSpansCache();
+   }
+
+   public static void flushOnWrites(ElasticsearchHttpStorage.Builder builder) {",es.clear should call this
+7388,"@@ -54,6 +54,10 @@ class TPTest(unittest.TestCase):
+   def tearDown(self):
+     shutil.rmtree(self._tmpDir)
+
++
++  def testInitDefaultTP(self):
++    self.assertTrue(isinstance(TP(), TP))
++
+
+   def testCheckpointLearned(self):
+     # Create a model and give it some inputs to learn.",please remove. this is true by the definition of the Python language
+7389,"@@ -1239,6 +1239,8 @@ KEY_DATA = collections.OrderedDict([
+         ('stop', ['<Ctrl-s>']),
+         ('print', ['<Ctrl-Alt-p>']),
+         ('open qute:settings', ['Ss']),
++        ('select-follow', ['<Return>']),
++        ('select-follow -t', ['<Ctrl-Return>']),
+     ])),
+
+     ('insert', collections.OrderedDict([","Hmm, I wonder if binding `<Return>` is a good idea... this means it wouldn't be passed to webpages anymore, which makes me wonder how many people rely on that... I guess trying it is the only way to find out :wink:"
+7390,"@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
+ func icmpPkt(src, dst string) packet {
+ 	return packetWithPorts(1, src+"":0"", dst+"":0"")
+ }
++func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
++	return packet{
++		protocol: 1,
++		srcAddr:  src,
++		srcPort:  0,
++		dstAddr:  dst,
++		dstPort:  (icmpCode << 8) | (icmpType),
++	}
++}
+
+ var polProgramTests = []polProgramTest{
+ 	// Tests of actions and flow control.
+-
+ 	{
+ 		PolicyName: ""no tiers"",
+ 		DroppedPackets: []packet{",Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain
+7391,"@@ -300,6 +300,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+
+         protected FrameResponseHeaders FrameResponseHeaders { get; } = new FrameResponseHeaders();
+
++        public TimeSpan RequestBodyTimeout { get; set; }
++
++        public double RequestBodyMinimumDataRate { get; set; }
++
++        public TimeSpan RequestBodyMinimumDataRateGracePeriod { get; set; }
++
+         public void InitializeStreams(MessageBody messageBody)
+         {
+             if (_frameStreams == null)",nit: Probably should renamed to `InitializeBody`
+7392,"@@ -11,13 +11,15 @@ export default Component.extend({
+
+     open: false,
+
+-    navMenuIcon: computed('config.blogUrl', function () {
+-        let url = `${this.get('config.blogUrl')}/favicon.png`;
++    navMenuIcon: computed('config.blogUrl', 'settings.icon', function () {
++        let blogIcon = this.get('settings.icon') ? this.get('settings.icon') : 'favicon.ico';
++        let url = `${this.get('config.blogUrl')}/${blogIcon}`;
+
+         return htmlSafe(`background-image: url(${url})`);
+     }),
+
+     config: injectService(),
++    settings: injectService(),
+     session: injectService(),
+     ghostPaths: injectService(),
+     feature: injectService(),",is `settings.icon` always null/undefined when there's no icon or does is it get set to a blank string? It might be worth wrapping it in an `isBlank()` anyway
+7393,"@@ -90,8 +90,9 @@ var Module = fx.Options(
+ 	fx.Provide(MetadataManagerProvider),
+ 	fx.Provide(NamespaceCacheProvider),
+ 	fx.Provide(serialization.NewSerializer),
+-	fx.Provide(ArchiverProviderProvider),
+ 	fx.Provide(ArchivalMetadataProvider),
++	fx.Provide(ArchiverProviderProvider),
++	fx.Invoke(RegisterBootstrapContainer),
+ 	fx.Provide(PersistenceBeanProvider),
+ 	fx.Provide(MembershipFactoryProvider),
+ 	fx.Provide(MembershipMonitorProvider),","put invoke to the end of the list, and other module at beginning of the list (line 86)"
+7394,"@@ -166,7 +166,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
+-	db.logger.Infof(""db capacity: %v"", db.capacity)
++	db.logger.Infof(""database capacity: %d chunks, %d bytes, %.2f megabytes."", db.capacity, db.capacity*swarm.ChunkSize, float64(db.capacity*swarm.ChunkSize)*9.5367431640625e-7)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","I think that bytes is too precise. Can we just calculate the approximate value in appropriate units? Something like MB, GB depending on the value, `db capacity: 5000000 chunks (approximately 20GB)` ."
+7395,"@@ -0,0 +1,4 @@
++let label = node.getAttribute('alt');
++let text = node.textContent;
++
++return (!!label && axe.commons.text.sanitize(label).trim() !== '' && axe.commons.text.sanitize(text).trim() !== '');","This check shouldn't look at the content, you're already doing this with `none-empty-text`. I also think this check should be renamed to `none-empty-alt` or something like it. There is nothing specific to applets in this check to warrant putting `applet` in the check ID."
+7396,"@@ -31,9 +31,11 @@ class TaxCreationForm extends BaseForm
+
+     protected $taxEngine = null;
+
+-    public function __construct(Request $request, $type = ""form"", $data = array(), $options = array(), TaxEngine $taxEngine = null)
++    public function __construct(Request $request, $type = ""form"", $data = array(), $options = array())
+     {
+-        $this->taxEngine = $taxEngine;
++        $this->taxEngine = $options[""tax_engine""];
++
++        unset($options[""tax_engine""]);
+
+         parent::__construct($request, $type, $data, $options);
+     }",Why did you change the signature of this method ? You can break BC doing that
+7397,"@@ -49,6 +49,12 @@ func Run(ctx context.Context, cfg *config.Node) error {
+ 	}
+
+ 	template := configToml
++
++	if cfg.ConfigTemplate != """" {
++		fileBytes, _ := ioutil.ReadFile(cfg.ConfigTemplate)
++		template = string(fileBytes[:])
++	}
++
+ 	if !cfg.NoFlannel {
+ 		template += configCNIToml
+ 	}",can you catch the error here please and return err if it can't read the template
+7398,"@@ -58,6 +58,7 @@ public class MainController {
+         appsController.setOnAppLoaded(() -> {
+             enginesController.loadEngines();
+             containersController.loadContainers();
++            libraryController.updateLibrary();
+         });
+
+         appsController.loadApps();",Is this method called at another location too? I'm just asking because you didn't remove another call to `updateLibrary`
+7399,"@@ -14,7 +14,7 @@ class PublicPagePolicy < ApplicationPolicy
+   end
+
+   def template_export?
+-    @object.is_default || @object.org.funder?
++    @object.present? && ( @object.is_default || @object.org.funder? ) && @object.published
+   end
+
+   def plan_export?",Not necessary but you should be able to add a `?` on `is_default?` and `published?`
+7400,"@@ -87,7 +87,7 @@ public class ProtoCodecBenchmarks {
+
+   @Benchmark
+   public List<Span> bytebuffer_zipkinDecoder() {
+-    return SpanBytesDecoder.PROTO3.decodeList(ByteBufUtil.getBytes(encodedBuf));
++    return SpanBytesDecoder.PROTO3.decodeList(encodedBuf.nioBuffer());
+   }
+
+   @Benchmark",here is us decoding directly the bytebuffer in benchmarks
+7401,"@@ -39,7 +39,16 @@ namespace Datadog.Trace.Logging
+             }
+             else
+             {
+-                SetDefaultValues();
++                // Do not set default values because the Tracer (and this event
++                // subscriber) may be initialized at a time when it is not safe
++                // to add properties to the MDC of the underlying logging framework.
++                //
++                // This previously caused a SerializationException when the Tracer
++                //  was initialized in the Asp.Net HttpModule startup, the default
++                // values were added to the underlying log4net framework, and,
++                // upon handling a new request, Asp.Net tried to copy the type
++                // log4net.Util.PropertiesDictionary from one AppDomain to another
++                // even though the type did not implement MarshalObjectByRef
+                 _scopeManager.SpanActivated += MapOnSpanActivated;
+                 _scopeManager.TraceEnded += MapOnTraceEnded;
+             }","When the Tracer is first created AND `DD_LOGS_INJECTION=true`, this is invoked and causes the issues described."
+7402,"@@ -44,7 +44,7 @@ public class JsonRpcErrorConverter {
+       case GAS_PRICE_TOO_LOW:
+         return JsonRpcError.GAS_PRICE_TOO_LOW;
+       case PRIVACY_GROUP_DOES_NOT_EXIST:
+-        return JsonRpcError.PRIVACY_GROUP_DOES_NOT_EXIST;
++        return JsonRpcError.OFFCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST;
+
+       default:
+         return JsonRpcError.INVALID_PARAMS;","NIT: If we are renaming the JsonRpcError, should we also rename this enum value to be consistent?"
+7403,"@@ -572,7 +572,8 @@ type FunctionExpression struct {
+ 	Defaults   *ObjectExpression
+ 	Block      *Block
+
+-	typ MonoType
++	typ        MonoType
++	Vectorized Expression
+ }
+
+ func (*FunctionExpression) NodeType() string { return ""FunctionExpression"" }","This could be made into a function expression, yes?"
+7404,"@@ -9,5 +9,5 @@ void release_assert_internal (bool check, const char * check_expr, const char *
+ 	}
+
+ 	std::cerr << ""Assertion ("" << check_expr << "") failed "" << file << "":"" << line << std::endl;
+-	abort();
++	abort ();
+ }","Oops, I missed this initially."
+7405,"@@ -243,6 +243,12 @@ class TestLambdaBaseFeatures(unittest.TestCase):
+         lambda_client.delete_function(FunctionName=lambda_name)
+
+     def test_add_lambda_permission(self):
++        function_name = 'lambda_func-{}'.format(short_uid())
++        testutil.create_lambda_function(
++            handler_file=TEST_LAMBDA_ECHO_FILE,
++            func_name=function_name,
++            runtime=LAMBDA_RUNTIME_PYTHON36
++        )
+         iam_client = aws_stack.connect_to_service('iam')
+         lambda_client = aws_stack.connect_to_service('lambda')
+ ",Can we add an assertion here the policy actually contains both statements created above?
+7406,"@@ -59,7 +59,13 @@ DEFINE_bool(enable_partitioned_index_filter, false, ""True for partitioned index
+ DEFINE_string(rocksdb_compression,
+               ""snappy"",
+               ""Compression algorithm used by RocksDB, ""
+-              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2"");
++              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress"");
++
++DEFINE_string(rocksdb_bottommost_compression,
++              ""disable"",
++              ""Specify the bottommost level compression algorithm""
++              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress,disable"");
++
+ DEFINE_string(rocksdb_compression_per_level,
+               """",
+               ""Specify per level compression algorithm, """,a space after comma?
+7407,"@@ -70,6 +70,11 @@ public final class CorrectForClockSkew {
+     if (skew != null) {
+       // the current span's skew may be a different endpoint than skewFromParent, adjust again.
+       node.value(adjustTimestamps(node.value(), skew));
++    } else {
++      if (skewFromParent != null && isLocalSpan(node.value())) {
++        //Propagate skewFromParent to local spans
++         skew = skewFromParent;
++      }
+     }
+     // propagate skew to any children
+     for (Node<Span> child : node.children()) {",nit formatting here and below
+7408,"@@ -5,9 +5,9 @@ import (
+
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/spiffe/spire/pkg/common/util""
+-	""github.com/spiffe/spire/proto/spire/api/registration""
+-	""github.com/spiffe/spire/proto/spire/common""
+-	mock_registration ""github.com/spiffe/spire/test/mock/proto/api/registration""
++	""github.com/spiffe/spire/proto/spire/api/server/entry/v1""
++	""github.com/spiffe/spire/proto/spire/types""
++	mock_entry ""github.com/spiffe/spire/test/mock/proto/api/entry""
+ 	""github.com/stretchr/testify/suite""
+ )
+ ","I think that there is a general consensus of trying to avoid this kind of mocks in the new tests that we write. I would suggest to have tests using fake service implementations. In this case, we can have a fake entry service. Examples of how tests have been written this way are the tests for the `spire-server agent` and `spire-server bundle` commands. It would be great if we can have that kind of testing here also. What do you think?"
+7409,"@@ -38,6 +38,6 @@ func (p *Provider) Type() string {
+ 	return ProviderType
+ }
+
+-func (p *Provider) RunQuery(ctx context.Context, query string) (bool, error) {
+-	return false, nil
++func (p *Provider) RunQuery(ctx context.Context, query string) (bool, string, error) {
++	return false, """", nil
+ }",`ctx` is unused in RunQuery
+7410,"@@ -276,12 +276,14 @@ def get_report_path_hash(report):
+     """""" Returns path hash for the given bug path.
+
+     This can be used to filter deduplications of multiple reports.
++
++    report type should be codechecker_common.Report
+     """"""
+     report_path_hash = ''
+     events = [i for i in report.bug_path if i.get('kind') == 'event']
+-
+     for event in events:
+-        file_name = os.path.basename(report.files[event['location']['file']])
++        file_name = \
++            os.path.basename(report.files.get(event['location']['file']))
+         line = str(event['location']['line']) if 'location' in event else 0
+         col = str(event['location']['col']) if 'location' in event else 0
+ ",Couldn't we use type hints to express this?
+7411,"@@ -57,12 +57,12 @@ define(['connectionManager', 'serverNotifications', 'events', 'globalize', 'emby
+
+     function setState(button, likes, isFavorite, updateAttribute) {
+
+-        var icon = button.querySelector('i');
++        var icon = button.querySelector('.material-icons');
+
+         if (isFavorite) {
+
+             if (icon) {
+-                icon.innerHTML = 'favorite';
++                icon.classList.add('favorite');
+                 icon.classList.add('ratingbutton-icon-withrating');
+             }
+ ",why you do `.classList.add()` here but `.replace()` in other places?
+7412,"@@ -98,9 +98,14 @@ Then 'I see the section price is ""$price""' do |price|
+ end
+
+ Then 'I see that one of the teachers is ""$teacher_name""' do |teacher_name|
++  sleep 10
+   page.should have_css("".teachers"", text: teacher_name)
+ end
+
++Then 'I should see that ""$teacher_name"" is teaching both sections' do |teacher_name|
++  page.should have_selector('h4', text: ""Joe Teacher"", count: 1)
++end
++
+ Then %{I see ""$teacher_name""'s avatar} do |teacher_name|
+   teacher = Teacher.find_by_name!(teacher_name)
+   page.should have_css(""img[src^='https://secure.gravatar.com/avatar/#{teacher.gravatar_hash}']"")",What is this sleep here for?
+7413,"@@ -478,4 +478,19 @@ describe('AutoRowSize', () => {
+
+     expect(rowHeight(spec().$container, -1)).toBe(75);
+   });
++
++  it('should properly count height', () => {
++    const hot = handsontable({
++      data: [['Tomek', 'Tomek\nTomek', 'Romek\nRomek']],
++      rowHeaders: true,
++      colHeaders: true,
++      autoRowSize: true,
++    });
++    // const cloneLeftHider = spec().$container.find('.ht_clone_left .wtHider')[0];
++    const $rowsHeaders = spec().$container.find('.ht_clone_left tbody tr th');
++    const plugin = hot.getPlugin('autoRowSize');
++
++    expect($rowsHeaders.height()).toEqual(42);
++    expect(plugin.heights[0]).toEqual(43);
++  });
+ });","I think that this test doesn't cover this bug correctly. When I attached the older version of the handsontable to this test it passes, should fail. Can you check that?"
+7414,"@@ -186,6 +186,16 @@ type tlfJournal struct {
+ 	mdJournal    *mdJournal
+ 	disabled     bool
+ 	lastFlushErr error
++	// The cache of unflushed paths.  If `unflushedReady` is not nil,
++	// then any callers must wait for it to be closed before accessing
++	// `unflushedPaths`.  `unflushedReady` only transitions
++	// nil->non-nil->nil at most one time during the lifetime of the
++	// journal. If `unflushedPaths` is non-nil, then `chainsPopulator`
++	// must also be non-nil.  These three fields are protected by
++	// `journalLock`.
++	unflushedPaths  map[MetadataRevision]map[string]bool
++	unflushedReady  chan struct{}
++	chainsPopulator chainsPathPopulator
+
+ 	bwDelegate tlfJournalBWDelegate
+ }",Maybe this should just be passed in on construction time
+7415,"@@ -367,6 +367,11 @@ struct wlr_backend *wlr_backend_autocreate(struct wl_display *display) {
+
+ 	struct wlr_backend *primary_drm =
+ 		attempt_drm_backend(display, backend, multi->session);
++
++	// discard the returned pointer - the monitor should destroy itself
++	// when the multi-backend is destroyed
++	wlr_drm_backend_monitor_create(backend, primary_drm, multi->session);
++
+ 	if (!primary_drm) {
+ 		wlr_log(WLR_ERROR, ""Failed to open any DRM device"");
+ 		wlr_backend_destroy(libinput);",We should create the monitor after the `if (!primary_drm)` check.
+7416,"@@ -85,6 +85,7 @@ def whitelist_generator():
+     yield 'qutebrowser.utils.log.QtWarningFilter.filter'
+     yield 'logging.LogRecord.log_color'
+     yield 'qutebrowser.browser.pdfjs.is_available'
++    yield 'qutebrowser.browser.tab.TabData._initializing'
+     # vulture doesn't notice the hasattr() and thus thinks netrc_used is unused
+     # in NetworkManager.on_authentication_required
+     yield 'PyQt5.QtNetwork.QNetworkReply.netrc_used'",Can be removed now that slots are used
+7417,"@@ -216,7 +216,7 @@ describe 'AccountsController' do
+   describe 'edit' do
+     it 'must respond with not_found when account does not exist' do
+       get :edit, id: :anything
+-      must_respond_with :not_found
++      must_respond_with :unauthorized
+     end
+
+     it 'must respond with success' do",The description should match the test
+7418,"@@ -165,12 +165,9 @@ static void xwayland_finish_display(struct wlr_xwayland *wlr_xwayland) {
+
+ 	unlink_display_sockets(wlr_xwayland->display);
+ 	wlr_xwayland->display = -1;
+-	unsetenv(""DISPLAY"");
++	wlr_xwayland->display_name[0] = '\0';
+ }
+
+-static bool xwayland_start_display(struct wlr_xwayland *wlr_xwayland,
+-	struct wl_display *wl_display);
+-
+ static bool xwayland_start_server(struct wlr_xwayland *wlr_xwayland);
+ static bool xwayland_start_server_lazy(struct wlr_xwayland *wlr_xwayland);
+ ",rootston needs to unset this now
+7419,"@@ -35,7 +35,7 @@ func newBlockBuffer(bufferSize, intervalSize uint64) *blockBuffer {
+ 	}
+ }
+
+-func (b *blockBuffer) Delete(height uint64) []*peerBlock {
++func (b *blockBuffer) Pop(height uint64) []*peerBlock {
+ 	b.mu.Lock()
+ 	defer b.mu.Unlock()
+ 	queue, ok := b.blockQueues[height]",why do you rename this function?
+7420,"@@ -30,12 +30,10 @@ module MailerHelper
+   end
+
+   def step_status_icon(step)
+-    if step.status == ""actionable""
+-      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + "".png""
+-    elsif step.status == ""pending""
+-      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + ""-pending.png""
+-    elsif step.status == ""completed""
++    if step.status == ""completed""
+       ""emails/numbers/icon-completed.png""
++    else
++      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + ""-pending.png""
+     end
+   end
+ ",since we are no longer using these numbered icons can we remove them from source control?
+7421,"@@ -182,6 +182,8 @@ public class VertxRestDispatcher extends AbstractVertxHttpDispatcher {
+
+     RestProducerInvocation restProducerInvocation = new RestProducerInvocation();
+     context.put(RestConst.REST_PRODUCER_INVOCATION, restProducerInvocation);
++    restProducerInvocation.setAfterCreateInvocationHandler(
++        invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));
+     restProducerInvocation.invoke(transport, requestEx, responseEx, httpServerFilters);
+   }
+ }","both edge and normal need to set this, so set it to be default action?"
+7422,"@@ -391,9 +391,13 @@ namespace Microsoft.DotNet.Build.Tasks
+
+         private static void WriteProject(JObject projectRoot, string projectJsonPath)
+         {
+-            string projectJson = JsonConvert.SerializeObject(projectRoot, Formatting.Indented);
+-            Directory.CreateDirectory(Path.GetDirectoryName(projectJsonPath));
+-            File.WriteAllText(projectJsonPath, projectJson + Environment.NewLine);
++            string projectJson = JsonConvert.SerializeObject(projectRoot, Formatting.Indented) + Environment.NewLine;
++
++            if (!File.Exists(projectJsonPath) || !projectJson.Equals(File.ReadAllText(projectJsonPath)))
++            {
++                Directory.CreateDirectory(Path.GetDirectoryName(projectJsonPath));
++                File.WriteAllText(projectJsonPath, projectJson);
++            }
+         }
+
+         /* JProperties are encapsulated with ""['"" and ""']"" to assist with matching Paths which",Is doing a straight string compare of the files the right way to determine this? I guess if you expect to be the only one writing this file it could work but it does seem like it might be a large string compare and if we are doing this hundreds of times that might cause some memory issues.
+7423,"@@ -431,7 +431,7 @@ static void set_client_priority() {
+ #ifdef __linux__
+     char buf[1024];
+     snprintf(buf, sizeof(buf), ""ionice -c 3 -p %d"", getpid());
+-    system(buf);
++    if (!system(buf)) {}
+ #endif
+ }
+ ",What's the purpose of this change? It basically changes nothing until we want to put smth between curly braces
+7424,"@@ -186,6 +186,9 @@ static void handle_device_removed(struct wlr_libinput_backend *backend,
+ 	}
+ 	struct wlr_input_device *dev, *tmp_dev;
+ 	wl_list_for_each_safe(dev, tmp_dev, wlr_devices, link) {
++		if (dev->type == WLR_INPUT_DEVICE_TABLET_TOOL) {
++			wlr_libinput_tablet_tool_destroy(dev);
++		}
+ 		wlr_input_device_destroy(dev);
+ 	}
+ 	for (size_t i = 0; i < backend->wlr_device_lists.length; i++) {","Hmm, why is this needed? `wlr_input_device_destroy` should destroy the tablet tool."
+7425,"@@ -62,6 +62,12 @@ public class DiscoApiModel implements ApiModel {
+     return interfaceModels;
+   }
+
++  @Override
++  public Iterable<? extends TypeModel> getAdditionalTypes() {
++    // TODO: is this supported?
++    return ImmutableList.of();
++  }
++
+   @Override
+   public InterfaceModel getInterface(String interfaceName) {
+     for (InterfaceModel interfaceModel : getInterfaces()) {",I think it's better to throw `UnsupportedOperationException`
+7426,"@@ -124,6 +124,14 @@ function createElement(...args) {
+ 			delete props.defaultValue;
+ 		}
+
++		if (Array.isArray(props.value) && props.multiple && type==='select') {
++			props.children.forEach((child) => {
++				if (props.value.includes(child.props.value)) {
++					child.props.selected = true;
++				}
++			});
++			delete props.value;
++		}
+ 		handleElementVNode(vnode, props);
+ 	}
+ ",`props.children` is not always guaranteed to be an array. When only one child is passed this will break. We can use `toChildArray()` to turn it into an array :tada:
+7427,"@@ -26,7 +26,8 @@ buildStyle = os.environ['BUILD_STYLE']
+
+ # Build the configure command.
+ configureCmd = os.path.join(buildSystemDir, 'contrib', 'configure.py')
+-configureCmd += ' --mode=%s' % buildStyle
++# configureCmd += ' --mode=%s' % buildStyle
++configureCmd += ' --mode=release'
+ configureCmd += ' --builddir=%s' % buildDir
+
+ print 'Running command:', configureCmd",Please just remove this line. We have the git history if we want the old version.
+7428,"@@ -49,9 +49,11 @@ public class ScriptTaskGraalJsTest extends AbstractScriptTaskTest {
+   private static final String GRAALJS = ""graal.js"";
+
+   protected ScriptEngineResolver defaultScriptEngineResolver;
++  protected boolean spinEnabled = false;
+
+   @Before
+   public void setup() {
++    spinEnabled = processEngineConfiguration.getEnvScriptResolvers().stream().anyMatch(resolver -> resolver.getClass().getSimpleName().equals(""SpinScriptEnvResolver""));
+     defaultScriptEngineResolver = processEngineConfiguration.getScriptEngineResolver();
+     processEngineConfiguration.setConfigureScriptEngineHostAccess(configureHostAccess);
+     processEngineConfiguration.setEnableScriptEngineLoadExternalResources(enableExternalResources);","Can we put some of the code on a new line to make it more readable. The max line length was 120 now, right?"
+7429,"@@ -56,3 +56,19 @@ func Example() {
+ 	cfg := snapshot.Value.(MyConfig)
+ 	_ = cfg
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	// This example watches a variable based on a file-based blob.Bucket with JSON.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""etcd://myvarname?client=my.etcd.server:9999"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}",Remove the handling here as well.
+7430,"@@ -113,7 +113,7 @@ namespace OpenTelemetry.Trace
+         /// <inheritdoc/>
+         public override void OnEnd(Activity activity)
+         {
+-            if (this.queue.TryAdd(activity))
++            if (this.queue.TryAdd(activity, maxSpinCount: 50000))
+             {
+                 if (this.queue.Count >= this.maxExportBatchSize)
+                 {",Do we want to make this configurable?
+7431,"@@ -159,6 +159,17 @@ public final class Require {
+     return number;
+   }
+
++  public static double positive(String argName, double number, String message) {
++    if (number <= 0) {
++      if (message == null) {
++        throw new IllegalArgumentException(argName + "" must be greater than 0"");
++      } else {
++        throw new IllegalArgumentException(message);
++      }
++    }
++    return number;
++  }
++
+   public static int positive(String argName, Integer number) {
+     return positive(argName, number, null);
+   }","Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly."
+7432,"@@ -71,4 +71,17 @@ ActiveAdmin.register Proposal do
+     flash[:alert] = ""Completed!""
+     redirect_to admin_proposal_path(resource)
+   end
++
++  csv do
++    proposal_attributes = %w(id status created_at updated_at client_data_type public_id visit_id)
++    proposal_attributes.each do |proposal_attr|
++      column(proposal_attr.to_sym) { |proposal| proposal.attributes[proposal_attr] }
++    end
++    column(:requester) { |proposal| proposal.requester.display_name }
++    client_data_attributes = %w(expense_type vendor not_to_exceed building_number emergency rwa_number work_order_code project_title description direct_pay cl_number function_code soc_code ncr_organization_id)
++    client_data_attributes.each do |data_attr|
++      column(data_attr.to_sym) { |proposal| proposal.client_data.attributes[data_attr] }
++    end
++    column(:approving_offical_name) { |proposal| User.find(proposal.client_data.approving_official_id).display_name }
++  end
+ end","Is this going to break things for 18F proposals, or will these fields just be ignored?"
+7433,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those,
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?
+7434,"@@ -35,6 +35,12 @@ type AWSClusterProviderConfig struct {
+
+ 	// SSHKeyName is the name of the ssh key to attach to the bastion host.
+ 	SSHKeyName string `json:""sshKeyName,omitempty""`
++
++	// CACertificate is a PEM encoded CA Certificate for the control plane nodes.
++	CACertificate []byte `json:""caCertificate,omitempty""`
++
++	// CAPrivateKey is a PEM encoded PKCS1 CA PrivateKey for the control plane nodes.
++	CAPrivateKey []byte `json:""caKey,omitemptuy""`
+ }
+
+ // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object",What's the reason for moving this to config from status?
+7435,"@@ -48,7 +48,7 @@ class GenericSuppressHandler(suppress_handler.SuppressHandler):
+     def store_suppress_bug_id(self, bug_id, file_name, comment):
+
+         if self.suppress_file is None:
+-            return False
++            return True
+
+         ret = suppress_file_handler.write_to_suppress_file(self.suppress_file,
+                                                            bug_id,",Shouldn't we re validate/update the in memory suppress data here?
+7436,"@@ -68,7 +68,7 @@ func TestPaymentChannelLs(t *testing.T) {
+ 	t.Run(""Works with default payer"", func(t *testing.T) {
+ 		t.Parallel()
+
+-		payer, err := address.NewFromString(fixtures.TestAddresses[0])
++		payer, err := address.NewFromString(fixtures.TestAddresses[2])
+ 		require.NoError(err)
+ 		target, err := address.NewFromString(fixtures.TestAddresses[1])
+ 		require.NoError(err)",curious why the renumbering is required here and elsewhere?
+7437,"@@ -426,9 +426,12 @@ func validateClusterPlatform(path *field.Path, platform hivev1.Platform) field.E
+ 	if aws := platform.AWS; aws != nil {
+ 		numberOfPlatforms++
+ 		awsPath := path.Child(""aws"")
+-		if aws.CredentialsSecretRef.Name == """" {
++		if aws.CredentialsSecretRef.Name == """" && aws.CredentialsAssumeRole == nil {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""credentialsSecretRef"", ""name""), ""must specify secrets for AWS access""))
+ 		}
++		if aws.CredentialsAssumeRole != nil && aws.CredentialsSecretRef.Name != """" {
++			allErrs = append(allErrs, field.Required(awsPath.Child(""credentialsAssumeRole""), ""cannot specify assume role when credentials secret is provided""))
++		}
+ 		if aws.Region == """" {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""region""), ""must specify AWS region""))
+ 		}",s/must specify secrets/must specify secrets or Role info/
+7438,"@@ -63,8 +63,8 @@ C2::Application.routes.draw do
+   end
+
+   mount Peek::Railtie => ""/peek""
++  mount Blazer::Engine, at: ""blazer""
+   if Rails.env.development?
+     mount LetterOpenerWeb::Engine => ""letter_opener""
+-    mount Blazer::Engine, at: ""blazer""
+   end
+ end","let's leave this as a dev-only feature, and copy prod db to local env when needed. that keeps blazer security issues to a minimum."
+7439,"@@ -22,7 +22,7 @@ namespace OpenTelemetry.Trace.Samplers
+     public sealed class AlwaysOffActivitySampler : ActivitySampler
+     {
+         /// <inheritdoc />
+-        public override string Description { get; } = nameof(AlwaysOffActivitySampler);
++        public override string Description { get; } = ""AlwaysOffSampler"";
+
+         /// <inheritdoc />
+         public override SamplingResult ShouldSample(in ActivitySamplingParameters samplingParameters)","We'll be renaming ActivitySampler to Sampler anyway, so this change will be non-required. Prefer to avoid changes here to avoid merge conflict with my PR doing the rename."
+7440,"@@ -278,7 +278,10 @@ func mutateHeadersByRules(headers, rules http.Header, repl httpserver.Replacer)
+ 		} else if strings.HasPrefix(ruleField, ""-"") {
+ 			headers.Del(strings.TrimPrefix(ruleField, ""-""))
+ 		} else if len(ruleValues) > 0 {
+-			headers.Set(ruleField, repl.Replace(ruleValues[len(ruleValues)-1]))
++			var replacement = repl.Replace(ruleValues[len(ruleValues)-1])
++			if len(replacement) > 0 {
++				headers.Set(ruleField, replacement)
++			}
+ 		}
+ 	}
+ }","This applies only in the ""set"" headers case, but what about ""adding"" a header (field prefixed with `+`)?"
+7441,"@@ -13,6 +13,7 @@ package net.sourceforge.pmd;
+  * @version $Revision$, $Date$
+  * @since August 30, 2002
+  */
++@Deprecated
+ public class PMDException extends Exception {
+     private static final long serialVersionUID = 6938647389367956874L;
+ ","I'm not sure we should deprecate this. I kinda like the idea, that we would provide all exceptions (if we throw any) with a common super type. Of course, the exception should be not a checked exception like this one, but rather a runtime exception. We maybe need additionally an internal exception that we would convert into such a public API exception. But that's out of scope of this PR - that's the question of exception handling."
+7442,"@@ -41,6 +41,11 @@ class TabDeletedError(Exception):
+     """"""Exception raised when _tab_index is called for a deleted tab.""""""
+
+
++class MarkNotSetError(Exception):
++
++    """"""Exception raised when _tab_index is called for a deleted tab.""""""
++
++
+ class TabbedBrowser(tabwidget.TabWidget):
+
+     """"""A TabWidget with QWebViews inside.",You'll need to adjust the docstring :wink:
+7443,"@@ -81,7 +81,8 @@ void ReaderProxy::start(const ReaderProxyData& reader_attributes)
+         reader_attributes.guid(),
+         reader_attributes.remote_locators().unicast,
+         reader_attributes.remote_locators().multicast,
+-        reader_attributes.m_expectsInlineQos);
++        reader_attributes.m_expectsInlineQos,
++        /*reader_attributes.guid().is_on_same_process_as(writer_->getGuid()*/false);
+
+     is_active_ = true;
+     reader_attributes_ = reader_attributes;",Add a TODO explaining why this is being done
+7444,"@@ -26,7 +26,8 @@
+
+ goog.provide('Blockly.VariableMap');
+
+-goog.require('Blockly.VariableModel');
++goog.require('Blockly.Events.VarDelete');
++goog.require('Blockly.Events.VarRename');
+
+ /**
+  * Class for a variable map.  This contains a dictionary data structure with",This file still uses Blockly.VariableModel...
+7445,"@@ -129,8 +129,10 @@ type ManagedRemoteAccess struct {
+ 	SSHKeyName *string `json:""sshKeyName,omitempty""`
+
+ 	// SourceSecurityGroups specifies which security groups are allowed access
+-	// An empty array opens port 22 to the public internet
+ 	SourceSecurityGroups []string `json:""sourceSecurityGroups,omitempty""`
++
++	// Public specifies whether to open port 22 to the public internet
++	Public bool `json:""public,omitempty""`
+ }
+
+ // AWSManagedMachinePoolStatus defines the observed state of AWSManagedMachinePool","Small nit, in the PR description its `publicAccess` but here its `public`. Guessing the preferred naming is public?"
+7446,"@@ -106,10 +106,11 @@ func (c *Variable) Close() error {
+ // Decode is a function type for unmarshaling/decoding bytes into given object.
+ type Decode func([]byte, interface{}) error
+
+-// Decoder is a helper for decoding bytes into a particular Go type object.  The Variable objects
+-// produced by a particular driver.Watcher should always contain the same type for Variable.Value
+-// field.  A driver.Watcher can use/construct a Decoder object with an associated type (Type) and
+-// decoding function (Func) for decoding retrieved bytes into Variable.Value.
++// Decoder is a helper for decoding bytes into a particular Go type object. The
++// Variable objects produced by a particular driver.Watcher should always
++// contain the same type for Variable.Value field. A driver.Watcher can
++// use/construct a Decoder object with an associated type (Type) and decoding
++// function (Func) for decoding retrieved bytes into Variable.Value.
+ type Decoder struct {
+ 	Type reflect.Type
+ 	// Func is a Decode function.","Maybe `driver.Watcher` -> provider (2x)? This is the concrete type, this user doesn't really know anything about the driver."
+7447,"@@ -21,12 +21,10 @@ import java.io.IOException;
+
+ import org.apache.lucene.codecs.DocValuesConsumer;
+ import org.apache.lucene.search.DocIdSetIterator;
+-import org.apache.lucene.search.SortField;
+
+-abstract class DocValuesWriter {
+-  abstract void finish(int numDoc);
++abstract class DocValuesWriter<T> {
+   abstract void flush(SegmentWriteState state, Sorter.DocMap sortMap, DocValuesConsumer consumer) throws IOException;
+-  abstract Sorter.DocComparator getDocComparator(int numDoc, SortField sortField) throws IOException;
++  abstract T getDocValues();
+   abstract DocIdSetIterator getDocIdSet();
+
+ }",can we remove this since `getDocValues` already returns an iterator? (we might need to do `T extends DocIdSetIterator` above)
+7448,"@@ -0,0 +1,8 @@
++class String
++  def fix_encoding_if_invalid!
++    unless self.valid_encoding?
++      self.encode!('utf-8', 'binary', invalid: :replace, undef: :replace)
++    end
++    self
++  end
++end",Don't check this in. This is already implemented in core_extensions/ruby/string.rb
+7449,"@@ -277,7 +277,7 @@ Block.prototype._getHash = function() {
+
+ var idProperty = {
+   configurable: false,
+-  writeable: false,
++  enumerable: true,
+   /**
+    * @returns {string} - The big endian hash buffer of the header
+    */","This is used for both `id`, and `hash` we may not want these both to be enumerable."
+7450,"@@ -641,9 +641,16 @@ module RSpec
+         formatter_loader.default_formatter = value
+       end
+
+-      # @private
++      # @api public
++      #
++      # Returns a duplicate of the formatters currently loaded in
++      # the `FormatterLoader` for introspection.
++      #
++      # Note as this is a duplicate, any mutations will be disregarded.
++      #
++      # @return [Array] the formatters currently loaded
+       def formatters
+-        formatter_loader.formatters
++        formatter_loader.formatters.dup
+       end
+
+       # @private",Is this necessary? I would expect YARD to treat it as public anyway... (Don't hold off merging on this...I'm mostly just curious).
+7451,"@@ -578,6 +578,7 @@ func (e *MutableStateImpl) GetActivityScheduledEvent(
+ 		e.executionState.RunId,
+ 		ai.ScheduledEventBatchId,
+ 		ai.ScheduleId,
++		ai.Version,
+ 		currentBranchToken,
+ 	)
+ 	if err != nil {",@wxing1292 to double check this is the right version to use?
+7452,"@@ -70,4 +70,12 @@ class TIntRange extends TInt
+     {
+         return $this->min_bound !== null && $this->min_bound > 0;
+     }
++
++    public function contains(int $i): bool
++    {
++        return
++            ($this->min_bound === null && $this->max_bound === null) ||
++            ($this->min_bound === null && $this->max_bound >= $i) ||
++            ($this->max_bound === null && $this->min_bound <= $i);
++    }
+ }",Shouldn't there be another case for when both min and max are specified?
+7453,"@@ -1,5 +1,5 @@
+ ## This file is part of Invenio.
+-## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 CERN.
++## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","Don't miss this one `2: I102 copyright year is outdated, expected 2014 but got 2013`. Thanks"
+7454,"@@ -112,8 +112,9 @@ size_t Cord::appendTo(std::string& str) const {
+     }
+
+     // Last block
+-    str.append(tail_, blockPt_);
+-
++    if (tail_) {
++        str.append(tail_, blockPt_);
++    }
+     return len_;
+ }
+ ",the tail_ maybe nullptr?
+7455,"@@ -92,7 +92,7 @@ func (c *Controller) reviewAdmission(ctx context.Context, req *admv1beta1.Admiss
+ 		if err := json.Unmarshal(req.Object.Raw, pod); err != nil {
+ 			return errs.New(""unable to unmarshal %s/%s object: %v"", req.Kind.Version, req.Kind.Kind, err)
+ 		}
+-		return c.createPodEntry(ctx, pod)
++		return c.syncPodEntry(ctx, pod)
+ 	case admv1beta1.Delete:
+ 		return c.deletePodEntry(ctx, req.Namespace, req.Name)
+ 	default:","The PR description mentions that `The controller code is extended to react to ""add"" events`, but I don't see any additional cases added here beyond the existing Create and Delete... is there something I'm missing?"
+7456,"@@ -26,7 +26,7 @@ module Blacklight
+   ##
+   # An OpenStruct that responds to common Hash methods
+   class OpenStructWithHashAccess < OpenStruct
+-    delegate :keys, :each, :map, :has_key?, :empty?, :delete, :length, :reject!, :select!, :include, :fetch, :to_json, :as_json, :to => :to_h
++    delegate :keys, :each, :map, :has_key?, :include?, :empty?, :length, :delete, :delete_if, :keep_if, :clear, :reject!, :select!, :replace, :fetch, :to_json, :as_json, to: :to_h
+
+     if ::RUBY_VERSION < '2.0'
+       def []=(key, value)",Does it matter that #include changed to #include? ? I think the change makes sense since it aligns with the method name on Hash but unsure if anything called #include that would break with the change.
+7457,"@@ -92,7 +92,7 @@ const (
+
+ 	// minimumTaskCleanupWaitDuration specifies the minimum duration to wait before cleaning up
+ 	// a task's container. This is used to enforce sane values for the config.TaskCleanupWaitDuration field.
+-	minimumTaskCleanupWaitDuration = 1 * time.Minute
++	minimumTaskCleanupWaitDuration = time.Second
+
+ 	// minimumImagePullInactivityTimeout specifies the minimum amount of time for that an image can be
+ 	// 'stuck' in the pull / unpack step. Very small values are unsafe and lead to high failure rate.","LGTM, curious though why exactly this is in place, and are there any possible issues from not waiting long enough?"
+7458,"@@ -104,7 +104,7 @@ module Beaker
+       #cleanup phase
+       rescue => e
+         #cleanup on error
+-        if @options[:preserve_hosts].to_s =~ /(never)/
++        if @options[:preserve_hosts].to_s =~ /(?:never)|(?:onpass)/
+           @logger.notify ""Cleanup: cleaning up after failed run""
+           if @network_manager
+             @network_manager.cleanup",?: is unnecessary because we already force preserve_hosts to be a string with to_s.
+7459,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent
+7460,"@@ -106,8 +106,8 @@ describe('debug with suspense', () => {
+
+ 				return loader.then(() => {
+ 					rerender();
+-					expect(console.warn).to.be.calledTwice;
+-					expect(warnings[1].includes('MyLazyLoaded')).to.equal(true);
++					expect(console.warn).to.be.calledThrice;
++					expect(warnings[2].includes('MyLazyLoaded')).to.equal(true);
+ 					expect(serializeHtml(scratch)).to.equal('<div>Hi there</div>');
+ 				});
+ 			});","Since lazy is re-rendered when mounting the fallback, these checks get triggered an additional time."
+7461,"@@ -173,6 +173,10 @@ class AbstractWebElement(collections.abc.MutableMapping):
+         except KeyError:
+             return False
+
++    def is_content_editable_prop(self) -> bool:
++        """"""Get the value of this element's isContentEditable property.""""""
++        raise NotImplementedError
++
+     def _is_editable_object(self) -> bool:
+         """"""Check if an object-element is editable.""""""
+         if 'type' not in self:","There is a `is_content_editable()` method just above this, what's the difference?"
+7462,"@@ -86,7 +86,7 @@ type PrometheusList struct {
+ type PrometheusSpec struct {
+ 	// PodMetadata configures Labels and Annotations which are propagated to the prometheus pods.
+ 	PodMetadata *EmbeddedObjectMetadata `json:""podMetadata,omitempty""`
+-	// ServiceMonitors to be selected for target discovery. *Deprecated:* if
++	// ServiceMonitors to be selected for target discovery. *Warning:* if
+ 	// neither this nor podMonitorSelector are specified, configuration is
+ 	// unmanaged.
+ 	ServiceMonitorSelector *metav1.LabelSelector `json:""serviceMonitorSelector,omitempty""`","Hmm, I'm not sure this is exactly what we want to get across. The behavior of leaving both values unset allowing the entire config to be managed is what is indeed deprecated. It's just that not the entire field is deprecated, just that one behavior."
+7463,"@@ -146,10 +146,17 @@ static void complete_cb (struct bulk_exec *exec, void *arg)
+ static void output_cb (struct bulk_exec *exec, flux_subprocess_t *p,
+                        const char *stream,
+                        const char *data,
+-                       int data_len,
++                       int len,
+                        void *arg)
+ {
+     struct jobinfo *job = arg;
++    const char *cmd = flux_cmd_arg (flux_subprocess_get_cmd (p), 0);
++    jobinfo_log_output (job,
++                        flux_subprocess_rank (p),
++                        basename (cmd),
++                        stream,
++                        data,
++                        len);
+     flux_log (job->h, LOG_INFO, ""%ju: %d: %s: %s"",
+                       (uintmax_t) job->id,
+                       flux_subprocess_rank (p),","Given the slightly vague discussion in basename(3) about POSIX basename (modifies arg) vs GNU (doesn't), I always assumed it was advisable to pass a string copy However, I guess you'd get a ""discarding const"" warning promoted to error by our build system here if you were getting the POSIX implementation. Hah! Cool, I probably can go remove some memory copies in other parts of the code where those conditions exist."
+7464,"@@ -81,12 +81,12 @@ public class MetricManagerTest {
+   @Test
+   public void managerEmitterHandlingTest() throws Exception {
+     this.emitter.purgeAllData();
+-    final Date from = DateTime.now().minusMinutes(1).toDate();
++    final Date from = DateTime.now().minusMinutes(10).toDate();
+     this.metric.notifyManager();
+
+     this.emitterWrapper.countDownLatch.await(10L, TimeUnit.SECONDS);
+
+-    final Date to = DateTime.now().plusMinutes(1).toDate();
++    final Date to = DateTime.now().plusMinutes(10).toDate();
+     final List<InMemoryHistoryNode> nodes = this.emitter.getMetrics(""FakeMetric"", from, to, false);
+
+     assertEquals(""Failed to report metric"", 1, nodes.size());","Do you know somehow that this was the culprit? Even 1 minute is a lot, so I would expect the bug to lie somewhere else."
+7465,"@@ -146,7 +146,9 @@ void ActiveHostsMan::cleanExpiredHosts() {
+         LOG(INFO) << ""set "" << data.size() << "" expired hosts to offline in meta rocksdb"";
+         kvstore_->asyncMultiPut(kDefaultSpaceId, kDefaultPartId, std::move(data),
+                                 [] (kvstore::ResultCode code) {
+-            CHECK_EQ(code, kvstore::ResultCode::SUCCEEDED);
++            if (code != kvstore::ResultCode::SUCCEEDED) {
++                LOG(WARNING) << ""put failed, ret "" << static_cast<int32_t>(code);
++            }
+         });
+     }
+ }",what to do if some failed? just logging?
+7466,"@@ -16,6 +16,19 @@ module Faker
+         fetch('quote.famous_last_words')
+       end
+
++      ##
++      # Produces a quote from Deep Thoughts by Jack Handey.
++      #
++      # @return [String]
++      #
++      # @example
++      #   Faker::Quote.deep_thoughts # => ""I hope life isn't a big joke, because I don't get it.""
++      #
++      # @faker.version next
++      def deep_thoughts
++        fetch('quote.deep_thoughts')
++      end
++
+       ##
+       # Produces a quote from Matz.
+       #",since these thoughts are all Jack Handey's the generator should probably be called `jack_handey` to reflect that.
+7467,"@@ -288,6 +288,8 @@ type Container struct {
+
+ 	Environment map[string]*string `locationName:""environment"" type:""map""`
+
++	EnvironmentFiles []*EnvironmentFile `locationName:""environmentFiles"" type:""list""`
++
+ 	Essential *bool `locationName:""essential"" type:""boolean""`
+
+ 	FirelensConfiguration *FirelensConfiguration `locationName:""firelensConfiguration"" type:""structure""`",this file is autogenerated. you should edit `model/api/api-2.json` and then go generate this file. otherwise the next people generating api.go will remove the changes you added here
+7468,"@@ -0,0 +1,8 @@
++class ProgressBarsController < ApplicationController
++
++  def show
++    _trail = Trail.find(params[:trail_id])
++    @trail = TrailWithProgress.new(_trail, user: current_user)
++    render layout: false
++  end
++end",Extra empty line detected at class body beginning.
+7469,"@@ -934,7 +934,9 @@ public class ExecutorManager extends EventHandler implements
+   @Override
+   public String submitExecutableFlow(ExecutableFlow exflow, String userId)
+     throws ExecutorManagerException {
+-    synchronized (exflow) {
++
++    String exFlowKey = exflow.getProjectName() + ""."" + exflow.getId() + "".submitFlow"";
++    synchronized (exFlowKey.intern()) {
+       String flowId = exflow.getFlowId();
+
+       logger.info(""Submitting execution flow "" + flowId + "" by "" + userId);",This is smart but hacky! I would probably prefer an alternate solution that would be more obvious to read/understand.
+7470,"@@ -115,7 +115,7 @@ type Client interface {
+ 	S3StreamingGet(ctx context.Context, region string, bucket string, key string) (io.ReadCloser, error)
+
+ 	DescribeTable(ctx context.Context, region string, tableName string) (*dynamodbv1.Table, error)
+-	UpdateTableCapacity(ctx context.Context, region string, tableName string, targetIndexRcu int64, targetIndexWcu int64) error
++	UpdateTableCapacity(ctx context.Context, region string, tableName string, targetTableRcu int64, targetTableWcu int64) (*dynamodbv1.Status, error)
+
+ 	Regions() []string
+ }",i would not return a pointer for status here which is an int
+7471,"@@ -67,6 +67,10 @@ exclude = [""AuthalicMatrixCoefficients"",
+            ""vnl_file_matrix"",
+            ""vnl_file_vector"",
+            ""vnl_fortran_copy"",
++           ""CosineWindowFunction"",
++           ""HammingWindowFunction"",
++           ""LanczosWindowFunction"",
++           ""WelchWindowFunction"",
+            ]
+
+ total = 0","Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now)."
+7472,"@@ -89,6 +89,7 @@ class Uppy {
+         enterTextToSearch: 'Enter text to search for images',
+         backToSearch: 'Back to Search',
+         emptyFolderAdded: 'No files were added from empty folder',
++        folderAlreadyAdded: 'The folder was already added',
+         folderAdded: {
+           0: 'Added %{smart_count} file from %{folder}',
+           1: 'Added %{smart_count} files from %{folder}',",Should we specify the name of the folder?
+7473,"@@ -14,7 +14,7 @@ from rdkit import RDConfig, rdBase
+ from rdkit import DataStructs
+ from rdkit import Chem
+ import rdkit.Chem.rdDepictor
+-from rdkit.Chem import rdqueries
++from rdkit.Chem import rdqueries, rdmolops
+
+ from rdkit import __version__
+ ","it's not wrong, but you don't technical need `rdmolops` here since it's imported as part of `Chem`"
+7474,"@@ -534,6 +534,7 @@ class InfluxListenStore(ListenStore):
+
+             pxz.stdin.close()
+
++        pxz.wait()
+         self.log.info('ListenBrainz listen dump done!')
+         self.log.info('Dump present at %s!', archive_path)
+         return archive_path","I think the absence of this might have been the cause of the dump file corruption. We didn't wait for the pxz command to exit, leading to a race condition between the cp and this, leading to corrupted files in some places. I came across this because the hashes created and printed were different from the hashes of the actual files in dev also."
+7475,"@@ -27,7 +27,7 @@ type blockchainConfig struct {
+ }
+
+ type LoggingConfig struct {
+-	Level logging.Level `required:""true"" default:""debug""`
++	Level *logging.Level `required:""true"" default:""info""`
+ }
+
+ func NewConfig(path string) (*Config, error) {",Out of the scope.
+7476,"@@ -1,11 +1,11 @@
+ describe('ColumnSorting', () => {
+-  var id = 'testContainer';
++  const id = 'testContainer';
+
+   beforeEach(function() {
+     this.$container = $(`<div id=""${id}"" style=""overflow: auto; width: 300px; height: 200px;""></div>`).appendTo('body');
+
+-    this.sortByColumn = function(columnIndex) {
+-      var element = this.$container.find(`th span.columnSorting:eq(${columnIndex})`);
++    this.sort = function(columnIndex) {
++      const element = this.$container.find(`th span.columnSorting:eq(${columnIndex})`);
+
+       element.simulate('mousedown');
+       element.simulate('mouseup');",Maybe `sortByColumnHeader` would be more precise? The plugin has a method with the same name and it could be confusing.
+7477,"@@ -36,7 +36,8 @@ export function diffChildren(
+ 	oldDom,
+ 	isHydrating
+ ) {
+-	let i, j, oldVNode, childVNode, newDom, firstChildDom, refs;
++	let i, j, oldVNode, childVNode, newDom, firstChildDom;
++	let refs = [];
+
+ 	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
+ 	// as EMPTY_OBJ._children should be `undefined`.",@developit I vaguely remember you mentioning something about some JS engines having an escape analysis feature that makes objects (and arrays?) locally declared that never leave the function essentially free from a GC perspective or something. Do you think we could benefit from that here? Or should we leave this as it is?
+7478,"@@ -1252,6 +1252,8 @@ func invertOpForLocalNotifications(oldOp op) (newOp op, err error) {
+ 		}
+ 	case *GCOp:
+ 		newOp = op
++	case *resolutionOp:
++		newOp = op
+ 	}
+
+ 	// Now reverse all the block updates.  Don't bother with bare Refs",Remind me why this is needed?
+7479,"@@ -64,6 +64,14 @@ public final class ConstantScoreQuery extends Query {
+     return super.rewrite(reader);
+   }
+
++  @Override
++  public void visit(QueryVisitor visitor) {
++    QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.FILTER, this);
++    if (v != null) {
++      query.visit(v);
++    }
++  }
++
+   /** We return this as our {@link BulkScorer} so that if the CSQ
+    *  wraps a query with its own optimized top-level
+    *  scorer (e.g. BooleanScorer) we can use that","same as above, can this be null now?"
+7480,"@@ -319,8 +319,8 @@ public class SparkOrcWriter implements OrcValueWriter<InternalRow> {
+         // make sure the child is big enough
+         cv.child.ensureSize(cv.childCount, true);
+         // Add each element
+-        for (int e = 0; e < cv.lengths[rowId]; ++e) {
+-          children.addValue((int) (e + cv.offsets[rowId]), e, value, cv.child);
++        for (long e = 0; e < cv.lengths[rowId]; ++e) {
++          children.addValue((int) (e + cv.offsets[rowId]), (int) e, value, cv.child);
+         }
+       }
+     }",This doesn't make sense to me. Should `cv.lengths` be an integer array instead of longs? It looks like they should always be integers since the values are assigned from `ArrayData#numElements()`. That's very likely an int.
+7481,"@@ -1920,7 +1920,18 @@ namespace pwiz.Skyline.Model.Results
+                 }
+                 else if (id.StartsWith(MsDataFileImpl.PREFIX_PRECURSOR))
+                 {
+-                    precursor = double.Parse(id.Substring(MsDataFileImpl.PREFIX_TOTAL.Length), CultureInfo.InvariantCulture);
++                    var str = id.Substring(MsDataFileImpl.PREFIX_PRECURSOR.Length);
++                    if (!double.TryParse(str, NumberStyles.Float, CultureInfo.InvariantCulture, out precursor))
++                    {
++                        if (str.StartsWith(@""Q1=""))
++                        {
++                            str = str.Substring(3);
++                            var tail = str.IndexOf(' ');
++                            if (tail > 0)
++                                str = str.Substring(0, tail);
++                        }
++                        precursor = double.Parse(str, CultureInfo.InvariantCulture);
++                    }
+                     product = precursor;
+                 }
+                 else if (id.StartsWith(MsDataFileImpl.PREFIX_SINGLE))",str.Substring(3).Split(' ')[0] would also work and is more concise.
+7482,"@@ -198,7 +198,8 @@ void nano::node::keepalive (std::string const & address_a, uint16_t port_a, bool
+ 			{
+ 				auto endpoint (nano::map_endpoint_to_v6 (i->endpoint ()));
+ 				node_l->send_keepalive (endpoint);
+-				if (preconfigured_peer_a)
++				// Force insert only for local preconfigured peers
++				if (preconfigured_peer_a && node_l->config.allow_local_peers && node_l->peers.not_a_peer (endpoint, false))
+ 				{
+ 					node_l->peers.insert (endpoint, nano::protocol_version, true);
+ 				}",Did you mean to negate the not_a_peer check?
+7483,"@@ -1,6 +1,6 @@
+ /*
+  * DBeaver - Universal Database Manager
+- * Copyright (C) 2010-2021 DBeaver Corp and others
++ * Copyright (C) 2010-2017 Serge Rider (serge@jkiss.org)
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.",Copyright (C) 2010-2021 DBeaver Corp and others
+7484,"@@ -22,9 +22,8 @@
+ We use this to be able to highlight parts of the text.
+ """"""
+
+-import re
+ import html
+-
++import re
+ from PyQt5.QtWidgets import QStyle, QStyleOptionViewItem, QStyledItemDelegate
+ from PyQt5.QtCore import QRectF, QSize, Qt
+ from PyQt5.QtGui import (QIcon, QPalette, QTextDocument, QTextOption,",This seems like an unrelated change
+7485,"@@ -48,6 +48,10 @@ func (l *linuxStandardInit) Init() error {
+ 	runtime.LockOSThread()
+ 	defer runtime.UnlockOSThread()
+ 	if !l.config.Config.NoNewKeyring {
++		if err := label.SetKeyLabel(l.config.ProcessLabel); err != nil {
++			return err
++		}
++		defer label.SetKeyLabel("""")
+ 		ringname, keepperms, newperms := l.getSessionRingParams()
+
+ 		// Do not inherit the parent's session keyring.",Just to double-check -- are you sure this needs to be done *before* we create a new session? (Is `SetKeyLabel` setting what the label will be for all future keys or the label for the current key?)
+7486,"@@ -47,6 +47,19 @@ using LocatorSelectorEntry = fastrtps::rtps::LocatorSelectorEntry;
+ using LocatorSelector = fastrtps::rtps::LocatorSelector;
+ using PortParameters = fastrtps::rtps::PortParameters;
+
++namespace eprosima {
++namespace fastdds {
++namespace rtps {
++
++static constexpr SharedMemTransportDescriptor::OverflowPolicy shm_default_overflow_policy =
++            SharedMemTransportDescriptor::OverflowPolicy::DISCARD;
++
++
++} // namespace rtps
++} // namespace fastdds
++} // namespace eprosima
++
++
+ TransportInterface* SharedMemTransportDescriptor::create_transport() const
+ {
+     return new SharedMemTransport(*this);",I thought we were removing the FAIL policy altogether....
+7487,"@@ -14,7 +14,7 @@
+
+ def txt2tags_actionFunc(target,source,env):
+ 	import txt2tags
+-	txt2tags.exec_command_line([str(source[0])])
++	txt2tags.exec_command_line([""--outfile"", str(source[0])[:-3] + ""html"", str(source[0])])
+
+ def exists(env):
+ 	try:",Could you elaborate on why you made this change?
+7488,"@@ -374,6 +374,9 @@ TEST(Scanner, Basic) {
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\110 \"""", TokenType::STRING, ""\\H ""),
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\\110 \"""", TokenType::STRING, ""\\\\110 ""),
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\\\110 \"""", TokenType::STRING, ""\\\\H ""),
++
++
++        CHECK_SEMANTIC_VALUE(""\""己所不欲，勿施于人\"""", TokenType::STRING, ""己所不欲，勿施于人""),
+     };
+ #undef CHECK_SEMANTIC_TYPE
+ #undef CHECK_SEMANTIC_VALUE","before the fix, does this sentence make service crash? My point is can you re-produce the problem. I'm not sure the bug is due to non-asiic code"
+7489,"@@ -86,7 +86,7 @@ func repoAssignment() macaron.Handler {
+ // Contexter middleware already checks token for user sign in process.
+ func reqToken() macaron.Handler {
+ 	return func(c *context.Context) {
+-		if !c.IsLogged {
++		if true != c.Data[""IsApiToken""] {
+ 			c.Error(401)
+ 			return
+ 		}","This comparison looks a bit strange, we should first check existence of key ""IsApiToken"" and then check if it is equal to true. ~~Besdies, s/IsApiToken/IsAuthedByToken/~~"
+7490,"@@ -568,10 +568,12 @@ func (r *ReconcileClusterSync) applySyncSets(
+ 			ObservedGeneration: syncSet.AsMetaObject().GetGeneration(),
+ 			Result:             hiveintv1alpha1.SuccessSyncSetResult,
+ 		}
+-		if syncSet.GetSpec().ResourceApplyMode == hivev1.SyncResourceApplyMode {
++		applyMode := syncSet.GetSpec().ResourceApplyMode
++		if applyMode == hivev1.SyncResourceApplyMode {
+ 			newSyncStatus.ResourcesToDelete = resourcesApplied
+ 		}
+-		if syncSet.GetSpec().ResourceApplyMode == hivev1.UpsertResourceApplyMode && len(oldSyncStatus.ResourcesToDelete) > 0 {
++		// applyMode defaults to UpsertResourceApplyMode
++		if (applyMode == hivev1.UpsertResourceApplyMode || applyMode == """") && len(oldSyncStatus.ResourcesToDelete) > 0 {
+ 			logger.Infof(""resource apply mode is %v but there are resources to delete in clustersync status"", hivev1.UpsertResourceApplyMode)
+ 			oldSyncStatus.ResourcesToDelete = nil
+ 		}","This might be working as is, but I'm a bit thrown by the || and then && and how things get evaluated. Testing real quick on the go playground, true || false && false seems to either evaluate the && first, or start on the right side. Anyhow could you group with braces, it looks to me like it should be ( a || b) && c in this case?"
+7491,"@@ -0,0 +1,17 @@
++// Copyright (c) 2020 IoTeX Foundation
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package main
++
++import (
++	""github.com/iotexproject/iotex-core/ioctl/cmd""
++	""github.com/iotexproject/iotex-core/ioctl/cmd/account""
++)
++
++func main() {
++	account.CryptoSm2 = true
++	cmd.Execute()
++}",add an entry in makefile to generate binary with diff name?
+7492,"@@ -115,6 +115,10 @@ func validatePagerDutyConfigs(configs []monitoringv1alpha1.PagerDutyConfig) erro
+ 		if conf.RoutingKey == nil && conf.ServiceKey == nil {
+ 			return errors.New(""one of 'routingKey' or 'serviceKey' is required"")
+ 		}
++
++		if err := conf.HTTPConfig.Validate(); err != nil {
++			return err
++		}
+ 	}
+ 	return nil
+ }",hmm so we didn't validate the HTTP config for all receivers?
+7493,"@@ -49,5 +49,14 @@ namespace OpenTelemetry.Context.Propagation
+         /// <param name=""getter"">Function that will return string value of a key with the specified name.</param>
+         /// <returns>Span context from it's text representation.</returns>
+         SpanContext Extract<T>(T carrier, Func<T, string, IEnumerable<string>> getter);
++
++        /// <summary>
++        /// Tests if an activity context has been injected into a carrier.
++        /// </summary>
++        /// <typeparam name=""T"">Type of object to extract context from. Typically HttpRequest or similar.</typeparam>
++        /// <param name=""carrier"">Object to extract context from. Instance of this object will be passed to the getter.</param>
++        /// <param name=""getter"">Function that will return string value of a key with the specified name.</param>
++        /// <returns><see langword=""true"" /> if the carrier has been injected with an activity context.</returns>
++        bool IsInjected<T>(T carrier, Func<T, string, IEnumerable<string>> getter);
+     }
+ }","ITextFormatActivity had this, can I add to have the same effect?"
+7494,"@@ -20,8 +20,11 @@ import (
+ 	""sync""
+ 	""time""
+
++	""github.com/aws/amazon-ecs-agent/agent/containerresource""
++	""github.com/aws/amazon-ecs-agent/agent/containerresource/containerstatus""
++
+ 	apicontainerstatus ""github.com/aws/amazon-ecs-agent/agent/api/container/status""
+-	apierrors ""github.com/aws/amazon-ecs-agent/agent/api/errors""
++	apierrors ""github.com/aws/amazon-ecs-agent/agent/apierrors""
+ 	""github.com/aws/amazon-ecs-agent/agent/credentials""
+ 	resourcestatus ""github.com/aws/amazon-ecs-agent/agent/taskresource/status""
+ ",not blocking: can we remove extra lines here?
+7495,"@@ -44,7 +44,7 @@ var PrivateKey = function PrivateKey(data, network, compressed) {
+   };
+
+   // detect type of data
+-  if (!data){
++  if (typeof(data) === 'undefined' || data === 'random'){
+     info.bn = PrivateKey._getRandomBN();
+   } else if (data instanceof BN) {
+     info.bn = data;",This just feels weird... can we use some kind of constant here? something like: `if (_.isUndefined(data) || data === PrivateKey.Random)`
+7496,"@@ -61,9 +61,12 @@ class ProjectorCompilerPass implements CompilerPassInterface
+             }
+
+             $parameters = $method->getParameters();
+-            $eventClass = (string) $parameters[0]->getType();
+
+-            $definition->addMethodCall('add', [new Reference($serviceId), $eventClass]);
++            $class = $parameters[0]->getClass();
++            if ($class) {
++                $eventClass = $class->getName();
++                $definition->addMethodCall('add', [new Reference($serviceId), $eventClass]);
++            }
+         }
+     }
+ }",if does not have a class I guess the exception should be thrown because we cannot recognize the type based on it?
+7497,"@@ -262,12 +262,18 @@ public final class DiscoveryMethodModel implements MethodModel {
+   }
+
+   private DiscoveryField createFieldMaskField() {
++    // TODO(andrealin): Change this to a Set instead of a List.
+     return DiscoveryField.create(
+         StandardSchemaGenerator.createListSchema(
+             StandardSchemaGenerator.createStringSchema(
+                 """", SurfaceNamer.Cardinality.NOT_REPEATED, true),
+             DiscoveryMethodTransformer.FIELDMASK_STRING,
+-            true),
++            true,
++            ""The fields that should be serialized (empty values will be serialized). ""
++                + ""If the containing message object has a non-null fieldmask, ""
++                + ""then all the fields in the field mask (and only those fields in the field mask) ""
++                + ""will be serialized. If the containing object does not have a fieldmask, then ""
++                + ""only non-empty fields will be serialized. ""),
+         null);
+   }
+ ",LOL: use your GitHub username?
+7498,"@@ -116,6 +116,16 @@ public class Key implements Comparable<Key> {
+     return toRawKey(Arrays.copyOf(value, value.length + 1));
+   }
+
++  /**
++   * nextPrefix key will be key with next available rid. For example, if the current key is
++   * prefix_rid, after calling this method, the return value should be prefix_rid+1
++   *
++   * @return a new key current rid+1.
++   */
++  public Key nextPrefix() {
++    return toRawKey(prefixNext(value));
++  }
++
+   /**
+    * The prefixNext key for bytes domain
+    *",any tests for nextPrefix() ?
+7499,"@@ -482,7 +482,7 @@ public class PrettyPrintVisitor implements VoidVisitor<Void> {
+         printMemberAnnotations(n.getAnnotations(), arg);
+         printModifiers(n.getModifiers());
+         if (!n.getVariables().isEmpty()) {
+-            n.getMaximumCommonType().accept(this, arg);
++            n.getMaximumCommonType().ifPresent(t -> t.accept(this, arg));
+         }
+
+         printer.print("" "");","In general I'm saying ""if there is no common type I'm just going to skip some stuff and fail silently."""
+7500,"@@ -19,10 +19,10 @@ package v1alpha1
+ import (
+ 	""context""
+
++	""github.com/google/knative-gcp/pkg/logging""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/equality""
+ 	""knative.dev/eventing/pkg/apis/messaging""
+-	""knative.dev/eventing/pkg/logging""
+ 	""knative.dev/pkg/apis""
+
+ 	""github.com/google/knative-gcp/pkg/apis/configs/gcpauth""","did we move the eventing logging here? Probably the eventing logging was removing and they are now using the pkg logging in eventing. If that is the case, we should do the same here"
+7501,"@@ -50,8 +50,7 @@ type Filter func(*http.Request) bool
+ // the mux are wrapped with WithRouteTag. A Handler will add various attributes
+ // to the span using the core.Keys defined in this package.
+ type Handler struct {
+-	operation string
+-	handler   http.Handler
++	handler http.Handler
+
+ 	tracer           trace.Tracer
+ 	props            propagation.Propagators","I think that `Handler` should preserve the `operation` member and the span formatter should receive the operation name string as a parameter too, otherwise the `operation` parameter in the `NewHandler` function becomes useless if we pass a custom span formatter. Also, shouldn't it be called `spanNameFormatter`?"
+7502,"@@ -67,7 +67,7 @@ class HSRPmd5(Packet):
+         ByteEnumField(""algo"", 0, {1: ""MD5""}),
+         ByteField(""padding"", 0x00),
+         XShortField(""flags"", 0x00),
+-        IPField(""sourceip"", None),
++        IPField(""sourceip"", ""127.0.0.1""),
+         XIntField(""keyid"", 0x00),
+         StrFixedLenField(""authdigest"", ""\00"" * 16, 16)]
+ ","Can you merge #466? That would make the current `None` default value working and more relevant that `""127.0.0.1""`."
+7503,"@@ -96,14 +96,15 @@ func (v *Validator) Validate(searchAttributes *commonpb.SearchAttributes, namesp
+ 	}
+
+ 	for saName, saPayload := range searchAttributes.GetIndexedFields() {
+-		if IsReservedField(saName) {
+-			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is Temporal reserved field name"", saName))
++		if !typeMap.IsDefined(saName) {
++			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is not a valid search attribute name"", saName))
+ 		}
+
+-		saType, err := typeMap.GetType(saName)
++		saType, err := typeMap.getType(saName, customCategory|predefinedCategory)
+ 		if err != nil {
+-			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is not a valid search attribute name"", saName))
++			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s attribute can't be set in SearchAttributes: reserved field name"", saName))
+ 		}
++
+ 		_, err = DecodeValue(saPayload, saType)
+ 		if err != nil {
+ 			var invalidValue interface{}",is reserved filed name the only possible reason this could fail?
+7504,"@@ -169,6 +169,10 @@ func defaultLogPath(ctx Context) string {
+
+ // DefaultInitParams returns default init params
+ func DefaultInitParams(ctx Context) InitParams {
++	journalEnv := os.Getenv(""KBFS_ENABLE_JOURNAL"")
++	if journalEnv == """" {
++		journalEnv = ""true""
++	}
+ 	return InitParams{
+ 		Debug:            BoolForString(os.Getenv(""KBFS_DEBUG"")),
+ 		BServerAddr:      defaultBServer(ctx),",Would a KBFS_DISABLE_JOURNAL make more sense?
+7505,"@@ -40,6 +40,8 @@ void DropSpaceExecutor::execute() {
+         if (*spaceName_ == ectx()->rctx()->session()->spaceName()) {
+             ectx()->rctx()->session()->setSpace("""", -1);
+         }
++        ectx()->addWarningMsg(""Data will be deleted completely after restarting the services"");
++
+         doFinish(Executor::ProcessControl::kNext);
+     };
+ ",BTW. What's the message meaning?...
+7506,"@@ -289,4 +289,15 @@ describe Mongoid::Extensions::Object do
+       end
+     end
+   end
++
++  describe ""#numeric?"" do
++
++    let(:object) do
++      Object.new
++    end
++
++    it ""returns false"" do
++      expect(object.numeric?).to eq(false)
++    end
++  end
+ end",this should say false
+7507,"@@ -1,3 +1,4 @@
++//go:build unit
+ // +build unit
+
+ // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.",for my understanding - are this line and the next line both necessary? they seem to contain duplicate information. same for the other test files
+7508,"@@ -102,6 +102,13 @@ def _get_search_url(txt):
+         engine = 'DEFAULT'
+     template = config.val.url.searchengines[engine]
+     url = qurl_from_user_input(template.format(urllib.parse.quote(term)))
++
++    if config.val.url.open_base_url and \
++            term in config.val.url.searchengines.keys():
++        url = qurl_from_user_input(config.val.url.searchengines[term])
++        url.setPath(None)
++        url.setFragment(None)
++        url.setQuery(None)
+     qtutils.ensure_valid(url)
+     return url
+ ","No need for the `.keys()`, iterating over a dictionary gives you its keys (and thus you can also do `key in some_dict`). With that, it also fits on one line :wink:"
+7509,"@@ -24,14 +24,6 @@ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {
+
+-IPLocator::IPLocator()
+-{
+-}
+-
+-IPLocator::~IPLocator()
+-{
+-}
+-
+ // Factory
+ void IPLocator::createLocator(
+         int32_t kindin,","If we want to avoid the user calling constructor and destructor, we should add `= delete` to their declarations. If we just want to avoid writing the default behavior, we should add `= default` to the declarations. I'm more in favor of the second option to avoid an API break."
+7510,"@@ -269,12 +269,12 @@ class GrapheneObjectStoreOperationResult(graphene.ObjectType):
+         return _to_metadata_entries(self.metadata_entries)  # pylint: disable=no-member
+
+
+-class GrapheneMaterialization(graphene.ObjectType):
++class GrapheneMaterializationOrObservation(graphene.ObjectType):
+     assetKey = graphene.Field(GrapheneAssetKey)
+
+     class Meta:
+         interfaces = (GrapheneDisplayableEvent,)
+-        name = ""Materialization""
++        name = ""MaterializationOrObservation""
+
+     def resolve_metadataEntries(self, _graphene_info):
+         from ...implementation.events import _to_metadata_entries",My preference here is to keep a stricter hierarchy. We should have a mixin or something that is an AssetEvent that Observation and Materialization can both inherit from. That way we can check the type in the frontend if we need to.
+7511,"@@ -212,7 +212,7 @@ class SpatialPoolerTest(unittest.TestCase):
+
+     # Get only the active column indices
+     spOutput = [i for i, v in enumerate(activeArray) if v != 0]
+-    self.assertEqual(spOutput, expectedOutput)
++    self.assertEqual(sorted(spOutput), expectedOutput)
+
+
+   def testStripNeverLearned(self):",Can also cast them as `set`s and compare them.
+7512,"@@ -0,0 +1 @@
++package trigger",Still TODO I guess?
+7513,"@@ -37,8 +37,6 @@
+ #include <fastdds/rtps/builtin/BuiltinProtocols.h>
+ #include <fastdds/rtps/builtin/liveliness/WLP.h>
+
+-#include <functional>
+-
+ using namespace eprosima::fastrtps;
+ using namespace ::rtps;
+ using namespace std::chrono;",Another cleanup. There are two additional `using namespace std::chrono;` under this one. Should also remove std::chrono:: from the full file. Please do this on a single commit.
+7514,"@@ -501,7 +501,7 @@ public final class JavaParserMetaModel {
+         enclosedExprMetaModel.getDeclaredPropertyMetaModels().add(enclosedExprMetaModel.innerPropertyMetaModel);
+         fieldAccessExprMetaModel.namePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""name"", com.github.javaparser.ast.expr.SimpleName.class, Optional.of(simpleNameMetaModel), false, false, false, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.namePropertyMetaModel);
+-        fieldAccessExprMetaModel.scopePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""scope"", com.github.javaparser.ast.expr.Expression.class, Optional.of(expressionMetaModel), true, false, false, false, false);
++        fieldAccessExprMetaModel.scopePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""scope"", com.github.javaparser.ast.expr.Expression.class, Optional.of(expressionMetaModel), false, false, false, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.scopePropertyMetaModel);
+         fieldAccessExprMetaModel.typeArgumentsPropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""typeArguments"", com.github.javaparser.ast.type.Type.class, Optional.of(typeMetaModel), true, false, true, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.typeArgumentsPropertyMetaModel);","Looking at this list of boolean flags I wonder if we should create enums for all of these options, so that the code becomes much more readable"
+7515,"@@ -29,8 +29,11 @@
+ #include <fastrtps/qos/QosPolicies.h>
+ #include <fastrtps/utils/TimeConversion.h>
+
++#include <rtps/builtin/data/ProxyHashTables.hpp>
++
+ #include <mutex>
+ #include <chrono>
++#include <unordered_set>
+
+ using namespace eprosima::fastrtps;
+ ",Is this necessary?
+7516,"@@ -0,0 +1,15 @@
++namespace Microsoft.Azure.Cosmos.CosmosElements
++{
++    internal abstract class CosmosElement
++    {
++        protected CosmosElement(CosmosElementType cosmosItemType)
++        {
++            this.Type = cosmosItemType;
++        }
++
++        public CosmosElementType Type
++        {
++            get;
++        }
++    }
++}",How about this NS inside query NS?
+7517,"@@ -53,7 +53,7 @@ func LoadOrCreateAccount(sm protocol.StateManager, encodedAddr string) (*state.A
+ }
+
+ // LoadAccount loads an account state
+-func LoadAccount(sm protocol.StateManager, addrHash hash.Hash160) (*state.Account, error) {
++func LoadAccount(sm protocol.StateReader, addrHash hash.Hash160) (*state.Account, error) {
+ 	var account state.Account
+ 	if err := sm.State(addrHash, &account); err != nil {
+ 		if errors.Cause(err) == state.ErrStateNotExist {","in line 79, sm also can be stateReader"
+7518,"@@ -876,6 +876,13 @@ int32_t MetaClient::partsNum(GraphSpaceID spaceId) {
+     return it->second->partsAlloc_.size();
+ }
+
++std::unordered_map<HostAddr, std::vector<PartitionID>>
++MetaClient::partsBySpace(GraphSpaceID spaceId) {
++    folly::RWSpinLock::ReadHolder holder(localCacheLock_);
++    auto it = localCache_.find(spaceId);
++    CHECK(it != localCache_.end());
++    return it->second->partsOnHost_;
++}
+
+ folly::Future<StatusOr<TagID>>
+ MetaClient::createTagSchema(GraphSpaceID spaceId, std::string name, nebula::cpp2::Schema schema) {","maybe can not return a map directly, it will be modified by inner thread."
+7519,"@@ -299,7 +299,7 @@ class Diff(unittest.TestCase):
+                                                     cmp_data)
+         # Unesolved core checkers.
+         test_res = {'core.NullDereference': 4, 'core.DivideZero': 3}
+-        self.assertDictEqual(diff_res, test_res)
++        self.assertDictContainsSubset(test_res, diff_res)
+
+     def test_get_diff_checker_counts_all_unresolved(self):
+         """"""","What is the actual change here, why is this test change needed? Now the diff will send back more data?"
+7520,"@@ -89,6 +89,17 @@ int RGroupDecomposition::add(const ROMol &inmol) {
+   const bool addCoords = true;
+   MolOps::addHs(mol, explicitOnly, addCoords);
+
++  // mark any wildcards in input molecule:
++  for (auto &atom : mol.atoms()) {
++    if (atom->getAtomicNum() == 0) {
++      atom->setIsotope(1000U);
++      // clean any existing R group numbers
++      atom->setAtomMapNum(0);
++      if (atom->hasProp(common_properties::_MolFileRLabel)) {
++        atom->clearProp(common_properties::_MolFileRLabel);
++      }
++    }
++  }
+   int core_idx = 0;
+   const RCore *rcore = nullptr;
+   std::vector<MatchVectType> tmatches;",Might be better to use a tag here. I for one have used 1000 isotopes as a tag in the past...
+7521,"@@ -128,11 +128,11 @@ func TestSetName(t *testing.T) {
+ 	}
+ }
+
+-func TestRecordingIsOff(t *testing.T) {
++func TestRecordingIsOn(t *testing.T) {
+ 	tp, _ := NewProvider()
+ 	_, span := tp.Tracer(""Recording off"").Start(context.Background(), ""StartSpan"")
+ 	defer span.End()
+-	if span.IsRecording() == true {
++	if span.IsRecording() == false {
+ 		t.Error(""new span is recording events"")
+ 	}
+ }","This tests seems it was broken from the start :joy:. It ""worked"" because the old sample chance was small enough that this have always be off. Thanks for fixing this. Could you also change the strings on this test? `""Recording off""` and `""new span is recording events""`"
+7522,"@@ -44,6 +44,14 @@ public final class PmdParametersParseResult {
+         return !isError() && result.isHelp();
+     }
+
++    /**
++     * Returns whether parsing just requested the {@code --version} text.
++     * In this case no configuration is produced.
++     */
++    public boolean isVersion() {
++        return !isError() && result.isVersion();
++    }
++
+     /**
+      * Returns the error if parsing failed. Parsing may fail if required
+      * parameters are not provided, or if some parameters don't pass validation.","This is not actually the case, you need to modify `toConfiguration` below to prevent a configuration from being produced"
+7523,"@@ -88,7 +88,7 @@ func (a *attestor) loadSVID(ctx context.Context) (*x509.Certificate, *ecdsa.Priv
+
+ 	svid := a.readSVIDFromDisk()
+ 	if len(fResp.PrivateKey) > 0 && svid == nil {
+-		a.c.Log.Warn(""Private key recovered, but no SVID found"")
++		a.c.Log.Debug(""Private key recovered, but no SVID found"")
+ 	}
+
+ 	var keyData []byte",I'm worried about we hide some important log here
+7524,"@@ -625,7 +625,7 @@ def start_workers(actions_map, actions, context, analyzer_config_map,
+                            callback=lambda results: worker_result_handler(
+                                results, metadata, output_path,
+                                context.analyzer_binaries)
+-                           ).get(float('inf'))
++                           ).get(31557600)
+
+             pool.close()
+         except Exception:","Python 3 will throw an exception for inf, but not providing a timeout will result in no timeout exception."
+7525,"@@ -45,6 +45,18 @@ func (s *server) setupRouting() {
+ 		""POST"": http.HandlerFunc(s.chunkUploadHandler),
+ 	})
+
++	router.Handle(""/bzz-tag/name/{name}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getANewTag),
++	})
++
++	router.Handle(""/bzz-tag/addr/{addr}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getTagInfoUsingAddress),
++	})
++
++	router.Handle(""/bzz-tag/uuid/{uuid}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getTagInfoUsingUUid),
++	})
++
+ 	s.Handler = web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""api access""),
+ 		handlers.CompressHandler,","As this method changes the state, it should be `POST`. Also, maybe to rename it to `createTag`?"
+7526,"@@ -24,6 +24,6 @@ func (e *Executor) ensureTrafficSplit(ctx context.Context) model.StageStatus {
+ 	return model.StageStatus_STAGE_SUCCESS
+ }
+
+-func (e *Executor) rollbackTraffic(ctx context.Context) model.StageStatus {
+-	return model.StageStatus_STAGE_SUCCESS
++func (e *Executor) rollbackTraffic(ctx context.Context) error {
++	return nil
+ }",`ctx` is unused in rollbackTraffic
+7527,"@@ -0,0 +1,12 @@
++
++using System;
++
++namespace SarifViewer
++{
++    internal sealed partial class Guids
++    {
++        public const string guidVSPackageString = ""b97edb99-282e-444c-8f53-7de237f2ec5e"";
++
++        public static Guid guidVSPackage = new Guid(guidVSPackageString);
++    }
++}",Roslyn conventions have const in PascalCase.
+7528,"@@ -112,7 +112,7 @@ public class ZookeeperStatusHandler extends RequestHandlerBase {
+           .map(h -> h.resolveClientPortAddress() + "":"" + h.clientPort)
+           .sorted().collect(Collectors.toList());
+       List<String> dynamicHosts = zkDynamicConfig.getServers().stream()
+-          .map(h -> h.resolveClientPortAddress() + "":"" + h.clientPort)
++          .map(h -> h.resolveClientPortAddress() + "":"" + (h.clientPort != null ? h.clientPort : ""2181""))
+           .sorted().collect(Collectors.toList());
+       if (!connStringHosts.containsAll(dynamicHosts)) {
+         errors.add(""Your ZK connection string ("" + connStringHosts.size() + "" hosts) is different from the "" +","This is not bullet proof if e.g. user has `clientPort=1234` in `zoo.cfg` and in zkHost connection string. Then we'll add a warning that dynamic config differs from zkHost, which is not entirely true since we just lack the port part. We have no way from client to read the `clientPort` from server except from connecting to the server with 4LW *ont the clientPort* which is a chicken and egg. This hack will make the comparison work for default port, which is a compromise."
+7529,"@@ -1,8 +1,8 @@
+ #if MESSAGEPACK_2_1
+ using System;
+ using Datadog.Trace.ExtensionMethods;
+-using MessagePack;
+-using MessagePack.Formatters;
++using Datadog.Trace.Vendors.MessagePack;
++using Datadog.Trace.Vendors.MessagePack.Formatters;
+
+ namespace Datadog.Trace.Agent.MessagePack
+ {",We can probably delete this entire file. It's not used now and we'll (probably) write a custom serializer before we ever switch to MessagePack 2.1.
+7530,"@@ -174,8 +174,11 @@ class ConfigV1(Config):
+                 'limit': 'all',
+                 'playbook': 'playbook.yml',
+                 'raw_ssh_args': [
+-                    '-o UserKnownHostsFile=/dev/null', '-o IdentitiesOnly=yes',
+-                    '-o ControlMaster=auto', '-o ControlPersist=60s'
++                    '-o UserKnownHostsFile=/dev/null',
++                    '-o IdentitiesOnly=yes',
++                    '-o ControlMaster=auto',
++                    '-o ControlPersist=60s',
++                    '-o IdentitiesOnly=yes',
+                 ],
+                 'tags': False,
+                 'timeout': 30,",Aren't you duplicating this option?
+7531,"@@ -440,6 +440,17 @@ func (a *Analyzer) IsBuildFile(uri lsp.DocumentURI) bool {
+ 	return a.State.Config.IsABuildFile(base)
+ }
+
++// IsBuildDefFile takes a uri path and check if it's a valid .build_defs file
++func (a *Analyzer) IsBuildDefFile(uri lsp.DocumentURI) bool {
++	filepath, err := GetPathFromURL(uri, ""file"")
++	if err != nil {
++		return false
++	}
++
++	base := path.Base(filepath)
++	return strings.HasSuffix(base, "".build_defs"")
++}
++
+ // e.g. src type:list, required:false
+ func getArgString(argument asp.Argument) string {
+ 	argType := strings.Join(argument.Type, ""|"")",I'm not sure we should be doing this based on the extension? Calling them `.build_defs` is just a convention
+7532,"@@ -30,7 +30,6 @@ def unsupported_property(property_name, deprecated=False, reason=""""):
+ class _MissingPandasLikeIndex(object):
+
+     # Properties
+-    T = unsupported_property('T')
+     nbytes = unsupported_property('nbytes')
+     shape = unsupported_property('shape')
+ ",Should remove in `_MissingPandasLikeMultiIndex:` too
+7533,"@@ -107,6 +107,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Defaults to false.
+ 	// +optional
+ 	CrossZoneLoadBalancing bool `json:""crossZoneLoadBalancing,omitempty""`
++
++	// Subnets specifies the subnets that should be used by the load balancer
++	// +optional
++	Subnets Subnets `json:""subnets,omitempty""`
+ }
+
+ // AWSClusterStatus defines the observed state of AWSCluster","We should scope this down to the bits that we're actually using, otherwise the API is going to be problematic, as it includes references to NAT gateways and public and/or private subnets. Copying the types to be more local to the task in hand is fine."
+7534,"@@ -45,6 +45,12 @@ type AWSDNSZoneSpec struct {
+ 	// to these tags,the DNS Zone controller will set a hive.openhsift.io/hostedzone tag
+ 	// identifying the HostedZone record that it belongs to.
+ 	AdditionalTags []AWSResourceTag `json:""additionalTags,omitempty""`
++
++	// Region is the AWS region to use for route53 operations.
++	// This defaults to us-east-1.
++	// For AWS China, use cn-northwest-1.
++	// +optional
++	Region string `json:""region,omitempty""`
+ }
+
+ // AWSResourceTag represents a tag that is applied to an AWS cloud resource",Is it is a hard requirement for this field to be 'cn-northwest-1' when wanting to interact with AWS China? It appears that putting in 'cn-north-1' would also result in using the alternative API endpoint (with the region overridden to use 'cn-northwest-1' for the created AWS client).
+7535,"@@ -812,7 +812,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+             Assert.IsType<Http2StreamErrorException>(thrownEx.InnerException);
+         }
+
+-        [Fact]
++        [Fact(Skip=""Flaky test #2799"")]
+         public async Task ContentLength_Received_MultipleDataFramesOverSize_Reset()
+         {
+             IOException thrownEx = null;",Stephen already fixed this one. Only the OverSize test is flaky now right?
+7536,"@@ -0,0 +1,6 @@
++<%= @activity %>
++
++<%= t(""mailer.proposal_link_text"",
++      proposal_url: proposal_url(@proposal)) %>
++
++<%= t(""mailer.footer"", feedback_url: feedback_url) %>","if the `activity_mailer` has a layout, should we include the footer in that? Realize there may also be conflicts with work @rememberlenny is working on..."
+7537,"@@ -16,6 +16,12 @@ require 'ruby_smb'
+ ENV['RACK_ENV'] = 'test'
+ $LOAD_PATH.unshift File.join(__dir__, 'lib')
+
++# Disables internationalized strings, which shouldn't be needed for tests.
++# This gets around an issue where Puppet::Environment and GettextSetup in
++# r10k are fighting over the same text domain within the FastGettext domain.
++# https://github.com/voxpupuli/ra10ke/issues/39
++Puppet[:disable_i18n] = true
++
+ RSpec.shared_context 'reset puppet settings' do
+   after :each do
+     # reset puppet settings so that they can be initialized again","This makes me nervous, mostly because I don't know very much about it. Will users run into the gettext error in the wild? I can't reproduce it locally, but it's hard to be 100% sure. Is disabling gettext in Pal an option?"
+7538,"@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
+   public void unassignExecutor(int executionId) throws ExecutorManagerException {
+     executionExecutorMapping.remove(executionId);
+   }
++
++  @Override
++  public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
++      throws ExecutorManagerException {
++    return new ArrayList<>();
++  }
+ }",Is Java smart enough to know the generic type here? Never knew this.
+7539,"@@ -71,7 +71,7 @@ public class BackupRepositoryFactory {
+     PluginInfo repo = Objects.requireNonNull(backupRepoPluginByName.get(name),
+         ""Could not find a backup repository with name "" + name);
+
+-    BackupRepository result = loader.newInstance(repo.className, BackupRepository.class);
++    BackupRepository result = loader.newInstance(repo, BackupRepository.class);
+     result.init(repo.initArgs);
+     return result;
+   }",no thought given to reload
+7540,"@@ -291,8 +291,17 @@ public abstract class ScheduledReporter implements Closeable, Reporter {
+         return shutdownExecutorOnStop;
+     }
+
+-    protected Set<MetricAttribute> getDisabledMetricAttributes() {
+-        return disabledMetricAttributes;
++    /**
++     * Check if Attribute disabled to be logged
++     * @param attribute metric attribute
++     * @return True if attribute is configured to be disabled
++     */
++    protected boolean isMetricAttributeDisabled(MetricAttribute attribute) {
++        if(disabledMetricAttributes != null && disabledMetricAttributes.contains(attribute)) {
++            return true;
++        }
++
++        return false;
+     }
+
+     private String calculateRateUnit(TimeUnit unit) {","Please, don't remove the `getDisabledMetricAttributes` method. All changes must be backward-compatible."
+7541,"@@ -195,7 +195,11 @@ function prepareDatabaseForSuite(suite, context) {
+     .admin()
+     .command({ killAllSessions: [] })
+     .catch(err => {
+-      if (err.message.match(/no such (cmd|command)/) || err.code === 11601) {
++      if (
++        err.message.match(/no such (cmd|command)/) ||
++        err.message.match(/Failed to kill on some hosts/) ||
++        err.code === 11601
++      ) {
+         return;
+       }
+ ",Is this left over from debugging?
+7542,"@@ -86,7 +86,7 @@ before(function(_done) {
+         }
+
+         this.configuration = new TestConfiguration(parsedURI, context);
+-        done();
++        client.close(done);
+       });
+     });
+   });",I've fallen for this before myself :) We _do_ call `close` inside of `done` on L65
+7543,"@@ -269,7 +269,9 @@ func (f *Fs) connect(ctx context.Context) (project *uplink.Project, err error) {
+ 	fs.Debugf(f, ""connecting..."")
+ 	defer fs.Debugf(f, ""connected: %+v"", err)
+
+-	cfg := uplink.Config{}
++	cfg := uplink.Config{
++		UserAgent: ""rclone"",
++	}
+
+ 	project, err = cfg.OpenProject(ctx, f.access)
+ 	if err != nil {","That looks fine! You could use `""rclone/""+fs.Version` too if you wanted. BTW does tardigrade use http under the hood? If you were using rclone's http Client then you'd get a User-Agent and you'd also get support for `-vv --dump bodies` and other nice things."
+7544,"@@ -260,6 +260,10 @@ class FreeAnchorRetinaHead(RetinaHead):
+             Tensor: Negative bag loss in shape (num_img, num_anchors, num_classes).
+         """"""  # noqa: E501, W605
+         prob = cls_prob * (1 - box_prob)
+-        negative_bag_loss = prob**self.gamma * F.binary_cross_entropy(
+-            prob, torch.zeros_like(prob), reduction='none')
+-        return (1 - self.alpha) * negative_bag_loss
++        neg_prob = 1 - prob
++        # There are some cases when neg_prob = 0.
++        # This will cause the neg_prob.log() to be inf without clamp.
++        neg_prob = torch.clamp(neg_prob, min=1e-12)
++        negative_bag_loss = -prob**self.gamma * neg_prob.log()
++        negative_bag_loss = (1 - self.alpha) * negative_bag_loss
++        return negative_bag_loss","Adding one line `prob = prob.clamp(min=EPS, max=1-EPS)` already works."
+7545,"@@ -118,7 +118,15 @@ namespace NLog.Targets.Wrappers
+         /// <param name=""overflowAction"">The action to be taken when the queue overflows.</param>
+         public AsyncTargetWrapper(Target wrappedTarget, int queueLimit, AsyncTargetWrapperOverflowAction overflowAction)
+         {
+-            RequestQueue = new AsyncRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#if NETSTANDARD2_0
++            // NetStandard20 includes many optimizations for ConcurrentQueue:
++            //  - See: https://blogs.msdn.microsoft.com/dotnet/2017/06/07/performance-improvements-in-net-core/
++            // Net40 ConcurrencyQueue can seem to leak, because it doesn't clear properly on dequeue
++            //  - See: https://blogs.msdn.microsoft.com/pfxteam/2012/05/08/concurrentqueuet-holding-on-to-a-few-dequeued-elements/
++            _requestQueue = new ConcurrentRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#else
++            _requestQueue = new AsyncRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#endif
+             TimeToSleepBetweenBatches = 50;
+             BatchSize = 200;
+             FullBatchSizeWriteLimit = 5;","another option would be to create a `CreateRequestQueue(bool lockingQeueue)`, and set it only in `InitializeTarget`, isn't? The would prefer having the creation and ""business"" rules for the creation in one region, I think `InitializeTarget` would be the best place."
+7546,"@@ -805,7 +805,7 @@ static void subsurface_handle_place_above(struct wl_client *client,
+ 	}
+
+ 	wl_list_remove(&subsurface->parent_pending_link);
+-	wl_list_insert(sibling->parent_pending_link.prev,
++	wl_list_insert(&sibling->parent_pending_link,
+ 		&subsurface->parent_pending_link);
+
+ 	subsurface->reordered = true;","Wait, I think the `subsurface_handle_place_above` code was correct before. `place_above` means ""place it above in rendering order"" right?"
+7547,"@@ -4,9 +4,10 @@ public class Test {
+     /**
+      * Docstring that looks like a list:
+      *
+-     * <p>1. hey 2. there
++     * 1. hey
++     * 2. there
+      *
+-     * <p>with blank line.
++     * with blank line.
+      */
+     Void test() {
+         /*",why did this change?
+7548,"@@ -15,12 +15,13 @@ import (
+ )
+
+ func TestBareRootMetadataVersionV3(t *testing.T) {
+-	tlfID := tlf.FakeID(1, false)
++	tlfID := tlf.FakeID(1, tlf.Private)
+
+ 	// All V3 objects should have SegregatedKeyBundlesVer.
+
+ 	uid := keybase1.MakeTestUID(1)
+-	bh, err := tlf.MakeHandle([]keybase1.UID{uid}, nil, nil, nil, nil)
++	bh, err := tlf.MakeHandle(
++		[]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, nil, nil, nil)
+ 	require.NoError(t, err)
+
+ 	rmd, err := MakeInitialBareRootMetadataV3(tlfID, bh)",Do you think we should have some tests here for `tlf.SingleTeam` too?
+7549,"@@ -1,6 +1,8 @@
+ package table
+
+-import ""github.com/influxdata/flux""
++import (
++	""github.com/influxdata/flux""
++)
+
+ // Copy returns a buffered copy of the table and consumes the
+ // input table. If the input table is already buffered, it ""consumes""",No problem with this but might as well revert this file since nothing else changed.
+7550,"@@ -14,18 +14,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         /// </summary>
+         public static void Register()
+         {
+-            Tracer.Instance = new Tracer(
+-                settings: null,
+-                agentWriter: null,
+-                sampler: null,
+-                scopeManager: new AspNetScopeManager(),
+-                statsd: null);
+-
+-            if (Tracer.Instance.Settings.IsIntegrationEnabled(AspNetHttpModule.IntegrationName))
+-            {
+-                // only register http module if integration is enabled
+-                HttpApplication.RegisterModule(typeof(AspNetHttpModule));
+-            }
++            HttpApplication.RegisterModule(typeof(AspNetHttpModule));
+         }
+     }
+ }","In my changes, I did not create a new `AspNetScopeManager`. I'm not familiar with it enough to know if this is a valid change or not"
+7551,"@@ -0,0 +1,3 @@
++export default message => {
++  throw new Error(message);
++};","Not cool with this. I think we talked about it in past. This is a side effect. If we want to introduce the side effect in our functions like `inRange` (which I am for) the side effect (error) should originate in that function and not in some internal `throwError` function. Every stacktract will start at line `2` of `trowError.js`. Been there, done that and falled back to throwing the error from the place where it should be thrown."
+7552,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+
+   @Override",We don't need this additional method.
+7553,"@@ -44,11 +44,10 @@ public class DelegatingOAuth2UserServiceTests {
+ 	}
+
+ 	@Test(expected = IllegalArgumentException.class)
+-	@SuppressWarnings(""unchecked"")
+ 	public void loadUserWhenUserRequestIsNullThenThrowIllegalArgumentException() {
+ 		DelegatingOAuth2UserService<OAuth2UserRequest, OAuth2User> delegatingUserService =
+ 			new DelegatingOAuth2UserService<>(
+-				Arrays.asList(mock(OAuth2UserService.class), mock(OAuth2UserService.class)));
++				Arrays.asList(mock(DefaultOAuth2UserService.class), mock(DefaultOAuth2UserService.class)));
+ 		delegatingUserService.loadUser(null);
+ 	}
+ ",The purpose of this test is to ensure that the `OAuth2UserRequest` passed into `loadUser` is **not** null else throw `IllegalArgumentException`. Changing the `List` of `OAuth2UserService` mocks to `DefaultOAuth2UserService` doesn't really apply to what is being tested here. Please revert this. Thank you.
+7554,"@@ -124,7 +124,7 @@ func NewProtocol(
+ 	getkickoutList GetKickoutList,
+ 	getUnproductiveDelegate GetUnproductiveDelegate,
+ 	electionCommittee committee.Committee,
+-	stakingV2 *staking.Protocol,
++	stakingProto *staking.Protocol,
+ 	getBlockTimeFunc GetBlockTime,
+ 	productivity Productivity,
+ 	getBlockHash evm.GetBlockHash,",nit: rename to nativeStk? proto might lead to think protobuf
+7555,"@@ -28,6 +28,9 @@ import org.apache.solr.common.util.StrUtils;
+ public interface ShardParams {
+   /** the shards to use (distributed configuration) */
+   String SHARDS = ""shards"";
++
++  /** UUID of the query */
++  String QUERY_ID = ""queryID"";
+
+   /** per-shard start and rows */
+   String SHARDS_ROWS = ""shards.rows"";",Why not `queryUUID` (and reference the same constant as in other places)?
+7556,"@@ -36,9 +36,9 @@ import (
+ )
+
+ const (
+-	invalidTrustDomainAttestedNode = ""An attested node with trust domain '%v' has been detected, "" +
++	invalidTrustDomainAttestedNode = ""an attested node with trust domain '%v' has been detected, "" +
+ 		""which does not match the configured trust domain of '%v'. Agents may need to be reconfigured to use new trust domain""
+-	invalidTrustDomainRegistrationEntry = ""A registration entry with trust domain '%v' has been detected, "" +
++	invalidTrustDomainRegistrationEntry = ""a registration entry with trust domain '%v' has been detected, "" +
+ 		""which does not match the configured trust domain of '%v'. If you want to change the trust domain, "" +
+ 		""please delete all existing registration entries""
+ 	invalidSpiffeIDRegistrationEntry = ""registration entry with id %v is malformed because invalid SPIFFE ID: %v""","This is also used to log, of which our convention is leading uppercase..."
+7557,"@@ -131,7 +131,7 @@ class ReusedSQLTestCase(unittest.TestCase, SQLTestUtils):
+         # Please see databricks/koalas/conftest.py.
+         pass
+
+-    def assertPandasEqual(self, left, right):
++    def assertPandasEqual(self, left, right, less_precise=False):
+         if isinstance(left, pd.DataFrame) and isinstance(right, pd.DataFrame):
+             try:
+                 pd.util.testing.assert_frame_equal(",What about we just name it `check_exact`?
+7558,"@@ -205,9 +205,10 @@ public abstract class SpanStoreTest {
+   }
+
+   @Test
+-  public void getAllServiceNames() {
++  public void getAllServiceNames_mergesAnnotation_andBinaryAnnotation() {
++    // creates a span with mutual exclusive endpoints in binary annotations and annotations
+     BinaryAnnotation yak = BinaryAnnotation.address(""sa"", Endpoint.create(""yak"", 127 << 24 | 1));
+-    accept(span1.toBuilder().addBinaryAnnotation(yak).build(), span4);
++    accept(span1.toBuilder().binaryAnnotations(asList(yak)).build());
+
+     // should be in order
+     assertThat(store().getServiceNames()).containsExactly(""service"", ""yak"");","before, a binary annotation had the same service name as a regular annotation, masking the bug where we weren't querying the latter"
+7559,"@@ -1,4 +1,6 @@
+ class Exercise < ActiveRecord::Base
++  AVERAGE_COMPLETION_TIME_IN_MINUTES = 7
++
+   has_many :statuses, as: :completeable, dependent: :destroy
+   has_one :trail, through: :step, as: :completeables
+   has_one :step, dependent: :destroy, as: :completeable",Where does the `7` come from?
+7560,"@@ -48,7 +48,7 @@ export default function CountrySelect() {
+ 				timezone: countriesByCode[ newCountryCode ].defaultTimeZoneId,
+ 			} );
+ 		}
+-	}, [ setValues ] );
++	}, [ setValues, value ] );
+
+ 	return (
+ 		<Select",I don't know how we haven't got bugs from some of these! As here this would have had a stale `value`
+7561,"@@ -199,6 +199,9 @@ public class SparkCatalog extends BaseCatalog {
+           setSnapshotId = set;
+         } else if (""cherry-pick-snapshot-id"".equalsIgnoreCase(set.property())) {
+           pickSnapshotId = set;
++        } else if (""sort-order"".equalsIgnoreCase(set.property())) {
++          throw new UnsupportedOperationException(""'sort-order' is a reserved table property. Please use the command "" +
++                  ""'ALTER TABLE ... WRITE ORDERED BY' to specify it."");
+         } else {
+           propertyChanges.add(set);
+         }","One nit here I forgot about this before but we usually structure error messages as ""Cannot X because Y. Then the recommendation goes here"" I would also recommend not using ""it"" in the message since it the pronoun is a bit ambiguous. ""to specify write sort-order"" may be clearer"
+7562,"@@ -26,7 +26,8 @@ import {
+ } from '../../../../../tests/js/utils';
+ import * as CacheModule from '../../../googlesitekit/api/cache';
+ import { STORE_NAME } from './constants';
+-import initialState, {
++import {
++	initialState,
+ 	FEATURE_TOUR_COOLDOWN_SECONDS,
+ 	FEATURE_TOUR_LAST_DISMISSED_AT,
+ } from './feature-tours';",I'm surprised this worked at all! It was importing the default export but `eslint-plugin-import` warned me `warning Using exported name 'initialState' as identifier for default export import/no-named-as-default`
+7563,"@@ -1,10 +1,9 @@
+ class VideoTutorial < Product
+-  has_many :teachers, dependent: :destroy
+-  has_many :users, through: :teachers
++  validates :description, :tagline, presence: true
+
+-  # Validations
+-  validates :description, presence: true
+-  validates :tagline, presence: true
++  def teachers
++    Teacher.joins(:video).merge(videos)
++  end
+
+   def collection?
+     published_videos.count > 1",This was used in `app/views/video_tutorials/_video_tutorial_details.html.erb` how are we handling that now?
+7564,"@@ -8,8 +8,9 @@ var (
+ 	newlineTabRE           = regexp.MustCompile(`\n\t`)
+ 	certificateTimeErrorRE = regexp.MustCompile(`: current time \S+ is after \S+`)
+ 	// aws
+-	awsRequestIDRE   = regexp.MustCompile(`(, )*(?i)(request id: )(?:[-[:xdigit:]]+)`)
+-	awsNotAuthorized = regexp.MustCompile(`(User: arn:aws:sts::)\S+(:assumed-role/[^/]+/)\S+( is not authorized to perform: \S+ on resource: arn:aws:iam::)[^:]+(:\S+)`)
++	awsRequestIDRE    = regexp.MustCompile(`(, )*(?i)(request id: )(?:[-[:xdigit:]]+)`)
++	awsNotAuthorized  = regexp.MustCompile(`(User: arn:aws:sts::)\S+(:assumed-role/[^/]+/)\S+( is not authorized to perform: \S+ on resource: arn:aws:iam::)[^:]+(:\S+)`)
++	awsEncodedMessage = regexp.MustCompile(`(Encoded authorization failure message: )\S+(,)`)
+ 	// azure
+ 	azureErrorDescriptionRE = regexp.MustCompile(`\""error_description\"":\""(.*?)\\r\\n`)
+ )","Is `\S+` really the right thing? Anybody know what kind of encoding this is? Perhaps if we know it doesn't have commas, we can just use `[^,]+`. Also, parens around the comma are unnecessary, since we're not using the capture group."
+7565,"@@ -1,10 +1,8 @@
+ tests = [
++  (""python"", ""UnitTestDocTests.py"", {}),
+   (""python"", ""UnitTestcBitVect.py"", {}),
+   (""python"", ""UnitTestBitEnsemble.py"", {}),
+   (""python"", ""UnitTestTopNContainer.py"", {}),
+-  (""python"", ""BitUtils.py"", {}),
+-  (""python"", ""VectCollection.py"", {}),
+-  (""python"", ""LazySignature.py"", {}),
+ ]
+ longTests = []
+ ",This block of changes looks like you removed tests without replacing them anywhere. Did I miss something?
+7566,"@@ -360,7 +360,10 @@ struct atom_wrapper {
+         .def(""GetPropNames"", &Atom::getPropList, (python::arg(""self"")),
+              ""Returns a list of the properties set on the Atom.\n\n"")
+
+-        .def(""GetPropsAsDict"", GetPropsAsDict<Atom>, (python::arg(""self"")),
++        .def(""GetPropsAsDict"", GetPropsAsDict<Atom>, (python::arg(""self""),
++                                                      python::arg(""includePrivate"") = true,
++                                                      python::arg(""includeComputed"") = true
++                                                      ),
+              ""Returns a dictionary of the properties set on the Atom.\n""
+              "" n.b. some properties cannot be converted to python types.\n"")
+         ",n.b. private and computed values are now exposed to the API. They were hidden/not exposed before.
+7567,"@@ -285,6 +285,13 @@ class WebElementWrapper(collections.abc.MutableMapping):
+         tag = self._elem.tagName().lower()
+         return self.get('role', None) in roles or tag in ('input', 'textarea')
+
++    def remove_target(self):
++        """"""Remove target from link""""""
++        if self._elem.tagName().lower() == 'a':
++            self._elem.removeAttribute('target')
++        elif self.parent().tagName().lower() == 'a':
++            self.parent().removeAttribute('target')
++
+     def debug_text(self):
+         """"""Get a text based on an element suitable for debug output.""""""
+         self._check_vanished()",Nitpick: Please add a period after `link` :wink:
+7568,"@@ -67,5 +67,8 @@ func (hs *HandlerStub) Start() {
+ 		klog.Errorf(""New upstream controller failed with error: %v"", err)
+ 		return
+ 	}
+-	upstream.Start()
++	if err := upstream.Start(); err != nil {
++		klog.Errorf(""Failed to start upstream with error: %v"", err)
++		return
++	}
+ }","we got no chance that `err` is not nil here, need to revisit how `NewUpstreamController` is defined."
+7569,"@@ -247,7 +247,8 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+         .put(GET_LOG, post(""/session/:sessionId/log""))
+         .put(GET_AVAILABLE_LOG_TYPES, get(""/session/:sessionId/log/types""))
+
+-        .put(STATUS, get(""/status""));
++        .put(STATUS, get(""/status""))
++        .put(HEAP_SNAPSHOT, get(""/session/:sessionId/chromium/heap_snapshot""));
+
+         nameToUrl = builder.build();
+   }","Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?"
+7570,"@@ -348,6 +348,12 @@ module RSpec::Core
+     end
+
+     describe ""#its"" do
++
++      it ""should issue deprecation warning"" do
++        expect_deprecation_with_call_site(__FILE__, __LINE__+1, '""its"" method')
++        RSpec::Core::ExampleGroup.its(nil) {}
++      end
++
+       subject do
+         Class.new do
+           def initialize","It'd be nice to assert the right deprecation is being raised, just add a third argument of `/""its"" method/`"
+7571,"@@ -87,6 +87,8 @@ public class TableProperties {
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+
++  public static final String LOCATION_PROVIDER_IMPL = ""write.location-provider.impl"";
++
+   public static final String OBJECT_STORE_PATH = ""write.object-storage.path"";
+
+   // This only applies to files written after this property is set. Files previously written aren't",Do we want to add this to the docs?
+7572,"@@ -46,7 +46,7 @@ func AssertGRPCStatus(tb testing.TB, err error, code codes.Code, message string)
+ 	st := status.Convert(err)
+
+ 	ok := true
+-	if !assert.Equal(tb, code, st.Code(), ""GRPC status code does not match"") {
++	if !assert.Equal(tb, code.String(), st.Code().String(), ""GRPC status code does not match"") {
+ 		ok = false
+ 	}
+ 	if !assert.Equal(tb, message, st.Message(), ""GRPC status message does not match"") {",This isn't really related but makes debugging test failures much easier since you see the string representation of the code instead of the integer value.
+7573,"@@ -130,6 +130,18 @@ bool ValueObjectVariable::UpdateValue() {
+   m_error.Clear();
+
+   Variable *variable = m_variable_sp.get();
++  // Check if the type has size 0. If so, there is nothing to update.
++  CompilerType var_type(GetCompilerTypeImpl());
++  if (var_type.IsValid()) {
++    ExecutionContext exe_ctx(GetExecutionContextRef());
++    llvm::Optional<uint64_t> size =
++      var_type.GetByteSize(exe_ctx.GetBestExecutionContextScope());
++    if (size && *size == 0) {
++      m_value.SetCompilerType(var_type);
++      return m_error.Success();
++    }
++  }
++
+   DWARFExpression &expr = variable->LocationExpression();
+
+   if (variable->GetLocationIsConstantValueData()) {",Because of this new early exit.
+7574,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?
+7575,"@@ -150,12 +150,16 @@ public abstract class PrivacyApiGroupJsonRpcMethods extends ApiGroupJsonRpcMetho
+
+   private JsonRpcMethod createPrivacyMethod(
+       final PrivacyParameters privacyParameters, final JsonRpcMethod rpcMethod) {
+-    if (rpcMethod.getName().equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
++    final String methodName = rpcMethod.getName();
++    if (methodName.equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
++      return rpcMethod;
++    } else if (methodName.equals(RpcMethod.PRIV_DISTRIBUTE_RAW_TRANSACTION.getMethodName())
++        && privacyParameters.getGoQuorumPrivacyParameters().isPresent()) {
+       return rpcMethod;
+     } else if (privacyParameters.isEnabled() && privacyParameters.isMultiTenancyEnabled()) {
+       return new MultiTenancyRpcMethodDecorator(rpcMethod);
+     } else if (!privacyParameters.isEnabled()) {
+-      return new DisabledPrivacyRpcMethod(rpcMethod.getName());
++      return new DisabledPrivacyRpcMethod(methodName);
+     } else {
+       return rpcMethod;
+     }",can this be removed now?
+7576,"@@ -213,8 +213,11 @@ static pmix_status_t initialize_server_base(pmix_server_module_t *module)
+     }
+
+     /* for now, just setup the v1.1 series rendezvous point
+-     * we use the pid to reduce collisions */
+-    if (0 > asprintf(&pmix_pid, ""%s/pmix-%d"", tdir, mypid)) {
++     * - use userid to avoid situation where user with other UID but same PID
++     *   has created the usock and terminate abnormally and we have no way to
++     *   remove the file
++     * - use the pid to reduce collisions */
++    if (0 > asprintf(&pmix_pid, ""%s/pmix-%d.%d"", tdir, getuid(), mypid)) {
+         return PMIX_ERR_NOMEM;
+     }
+ ",This is going to create a problem - we are already encountering issues with the length of the usock pathname on recent Linux kernels as the temp directory base has moved down to the var directory under a name created by a hash. So adding another field to it is going to add to the problem.
+7577,"@@ -31,3 +31,13 @@ type ApplicationGetter interface {
+ type ApplicationCreator interface {
+ 	CreateApplication(app *Application) error
+ }
++
++const (
++	// AppCfnTemplateNameFormat is the base output file name when `app package`
++	// is called. This is also used to render the pipeline CFN template.
++	AppCfnTemplateNameFormat = ""%s.stack.yml""
++	// AppCfnTemplateConfigurationNameFormat is the base output configuration
++	// file name when `app package` is called. It's also used to render the
++	// pipeline CFN template.
++	AppCfnTemplateConfigurationNameFormat = ""%s-%s.params.json""
++)",What do you think about moving this to the `cloudformation` pkg?
+7578,"@@ -63,6 +63,11 @@ abstract class BaseProvider implements MediaProviderInterface
+      */
+     protected $name;
+
++    /**
++     * @var array
++     */
++    protected $clones = [];
++
+     /**
+      * @param string             $name
+      * @param Filesystem         $filesystem",Please make this private by default
+7579,"@@ -16,6 +16,12 @@
+  */
+ package org.camunda.bpm.engine.impl.util.xml;
+
++import org.camunda.bpm.engine.impl.ProcessEngineLogger;
++import org.camunda.bpm.engine.impl.cfg.ProcessEngineConfigurationImpl;
++import org.camunda.bpm.engine.impl.context.Context;
++import org.camunda.bpm.engine.impl.util.EngineUtilLogger;
++
++import javax.xml.XMLConstants;
+ import javax.xml.parsers.SAXParser;
+ import javax.xml.parsers.SAXParserFactory;
+ ","We can add `@Override` annotations to all of the implementations of this method. I think this is a best practice for us, but it would be nicer in any case."
+7580,"@@ -7,5 +7,11 @@ type Resolver interface {
+
+ // Detector allows detecting location by current ip
+ type Detector interface {
+-	DetectCountry() (string, error)
++	DetectLocation() (Location, error)
++}
++
++// Cache allows caching location
++type Cache interface {
++	Get() (Location, error)
++	RefreshAndGet() (Location, error)
+ }","Most of uses of `RefreshAndGet` seems to be made only for `Refresh` part, result is ignored. We can simplify this method to assigning single responsibility to it - just `Refresh()`."
+7581,"@@ -137,7 +137,10 @@ class OptionsManagerMixIn:
+
+     def add_optik_option(self, provider, optikcontainer, opt, optdict):
+         args, optdict = self.optik_option(provider, opt, optdict)
+-        option = optikcontainer.add_option(*args, **optdict)
++        try:
++            option = optikcontainer.add_option(*args, **optdict)
++        except optparse.OptionConflictError:
++            return
+         self._all_options[opt] = provider
+         self._maxlevel = max(self._maxlevel, option.level or 0)
+ ","@Pierre-Sassoulas Are we sure this doesn't create problems? Without it for some reason we get an error on `accept-no-param-docs` being a duplicate error. I couldn't figure out why it did this. This solves the issue and passes the tests, but I wonder if this creates other issues.."
+7582,"@@ -169,7 +169,17 @@ func (c *linuxContainer) OCIState() (*specs.State, error) {
+ }
+
+ func (c *linuxContainer) Processes() ([]int, error) {
+-	pids, err := c.cgroupManager.GetAllPids()
++	var pids []int
++	status, err := c.currentStatus()
++	if err != nil {
++		return pids, err
++	}
++	// for systemd cgroup, the unit's cgroup path will be auto removed if container's all processes exited
++	if status == Stopped && !c.cgroupManager.Exists() {
++		return pids, nil
++	}
++
++	pids, err = c.cgroupManager.GetAllPids()
+ 	if err != nil {
+ 		return nil, newSystemErrorWithCause(err, ""getting all container pids from cgroups"")
+ 	}","Does it make sense to check for ""Created"" here as well? Or should it return an error in such case?"
+7583,"@@ -93,7 +93,7 @@ public abstract class BaseMetastoreCatalog implements Catalog {
+     String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
+     Map<String, String> tableProperties = properties != null ? properties : Maps.newHashMap();
+     TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
+-    return Transactions.createTableTransaction(ops, metadata);
++    return Transactions.createTableTransaction(identifier.name(), ops, metadata);
+   }
+
+   @Override",Did you mean to use `identifier.toString` here as well?
+7584,"@@ -1,6 +1,6 @@
+-require 'spec_helper'
++require ""rails_helper""
+
+-describe Api::V1::UsersController, '#show' do
++describe Api::V1::UsersController, ""#show"", type: :controller do
+   it 'returns a 401 when users are not authenticated' do
+     get :show
+     expect(response.code).to eq ""401""",interesting! didn't realize this was needed in RSpec 3
+7585,"@@ -27,7 +27,7 @@ from databricks.koalas.base import _wrap_accessor_pandas, _wrap_accessor_spark
+
+ class DatetimeMethods(object):
+     """"""Date/Time methods for Koalas Series""""""
+-    def __init__(self, series: ks.Series):
++    def __init__(self, series: 'ks.Series'):
+         if not isinstance(series.spark_type, (DateType, TimestampType)):
+             raise ValueError(
+                 ""Cannot call DatetimeMethods on type {}""",This is to avoid circular reference
+7586,"@@ -93,6 +93,9 @@ class MPLRenderer(Renderer):
+              'nbagg':   (NbAggJupyterComm, None),
+              'mpld3':   (JupyterComm, mpld3_msg_handler)}
+
++    # Whether in a notebook context
++    _notebook = False
++
+     def __call__(self, obj, fmt='auto'):
+         """"""
+         Render the supplied HoloViews component or MPLPlot instance","As the bokeh renderer also has a ``load_nb`` classmethod (and notebooks are explicitly mentioned in that method name), I would consider making ``_notebook`` into a constant ``notebook_context`` class parameter. The docstring can say it is set to True if the ``load_nb`` classmethod has been called."
+7587,"@@ -2,7 +2,6 @@
+
+ const CommandOperation = require('./command');
+ const handleCallback = require('../utils').handleCallback;
+-const MongoError = require('../core').MongoError;
+
+ class DropCollectionOperation extends CommandOperation {
+   constructor(db, command, options) {","Where is the actual command generated here? Shouldn't this be taking in `constructor(db, collectionName, options)` and then constructing the command off of that?"
+7588,"@@ -55,7 +55,8 @@
+ int
+ memquery_library_bounds_by_iterator(const char *name, app_pc *start /*IN/OUT*/,
+                                     app_pc *end /*OUT*/, char *fullpath /*OPTIONAL OUT*/,
+-                                    size_t path_size)
++                                    size_t path_size, char *filename,
++                                    size_t filename_size)
+ {
+     int count = 0;
+     bool found_library = false;",Mirror the `OPTIONAL OUT` of fullpath
+7589,"@@ -94,13 +94,16 @@ const ConsensusV17 = ConsensusVersion(
+ 	""https://github.com/algorandfoundation/specs/tree/5615adc36bad610c7f165fa2967f4ecfa75125f0"",
+ )
+
++// ConsensusVNext stand-in for protocol with LogicSig and TEAL v1
++const ConsensusVNext = ConsensusVersion(""NEXT!"")
++
+ // !!! ********************* !!!
+ // !!! *** Please update ConsensusCurrentVersion when adding new protocol versions *** !!!
+ // !!! ********************* !!!
+
+ // ConsensusCurrentVersion is the latest version and should be used
+ // when a specific version is not provided.
+-const ConsensusCurrentVersion = ConsensusV17
++const ConsensusCurrentVersion = ConsensusVNext
+
+ // ConsensusTest0 is a version of ConsensusV0 used for testing
+ // (it has different approved upgrade paths).","Please merge with master and replace with with ""future"" version."
+7590,"@@ -55,7 +55,6 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			let cxType = newType.contextType;
+ 			let provider = cxType && context[cxType._id];
+ 			let cctx = cxType != null ? (provider ? provider.props.value : cxType._defaultValue) : context;
+-
+ 			// Get component and set it to `c`
+ 			if (oldVNode._component) {
+ 				c = newVNode._component = oldVNode._component;",Nit: Change is not needed for this PR :slightly_smiling_face:
+7591,"@@ -11,6 +11,15 @@ module CloudFoundry
+     end
+   end
+
++  def self.app_url
++    if self.is_environment?
++      # (arbitrarily) use the shortest assigned route, if there are multiple
++      self.vcap_data['application_uris'].min_by(&:length)
++    else
++      nil
++    end
++  end
++
+   # returns `true` if this app is running in Cloud Foundry
+   def self.is_environment?
+     !!self.raw_vcap_data",if we are returning `nil` from an `else` I think we can just remove the `else` (and this method will still return `nil`)
+7592,"@@ -9,7 +9,7 @@ using System.Threading.Tasks;
+ namespace System.Threading.Tests
+ {
+     [BenchmarkCategory(Categories.CoreFX)]
+-    public class TimerPerfTest
++    public class Perf_Timer
+     {
+         private readonly Timer[] _timers = new Timer[1_000_000];
+         private readonly Task[] _tasks = new Task[Environment.ProcessorCount];","side note: this change is ok as of today because we have not exported the results for this new type to BenchView yet. After we to that the namespace, type name and method name should not be changed (they create a benchmark ID which is used in BenchView)."
+7593,"@@ -294,7 +294,15 @@ namespace pwiz.Skyline.Model.Lib.Midas
+             _spectra = null;
+             if (FilePath == null)
+                 return false;
+-            var info = new FileInfo(FilePath);
++            FileInfo info;
++            try
++            {
++                info = new FileInfo(FilePath);
++            }
++            catch
++            {
++                return false;
++            }
+             if (!info.Exists || info.Length == 0)
+                 return false;
+ ","How exactly are you expecting the user to see issues with their Midas library? It seems like all error information is being swallowed and not clearly reported to the user. Even if the eventual result is to report that loading the file failed, it seems like the exception, in this case, might have more information about why."
+7594,"@@ -105,6 +105,10 @@ func (wsc *WebSocketClient) UnInit() {
+
+ //Send sends the message as JSON object through the connection
+ func (wsc *WebSocketClient) Send(message model.Message) error {
++	err := wsc.connection.SetWriteDeadline(time.Now().Add(wsc.config.WriteDeadline))
++	if err != nil {
++		return err
++	}
+ 	return wsc.connection.WriteMessageAsync(&message)
+ }
+ ","Looks good, but seems `ReadMessage` hadn't used this Deadline in Underlying `WSConnection`?"
+7595,"@@ -89,6 +89,8 @@ public class Constants {
+   // The flow exec id for a flow trigger instance unable to trigger a flow yet
+   public static final int FAILED_EXEC_ID = -2;
+
++  // Name of the file which keeps project directory size
++  public static final String PROJECT_DIR_SIZE_FILE_NAME = ""_azkaban_project_dir_size_in_bytes_"";
+
+   public static class ConfigurationKeys {
+ ","Make it ""___*"" three underscores to make it even less likely to have a collision? I assume it will be hard to change the file name once this change is deployed..."
+7596,"@@ -432,7 +432,7 @@ public class RecoveryStrategy implements Runnable, Closeable {
+   /**
+    * @return true if we have reached max attempts or should stop recovering for some other reason
+    */
+-  private boolean waitBetweenRecoveries(String coreName) {
++  final private boolean waitBetweenRecoveries(String coreName) {
+     // lets pause for a moment and we need to try again...
+     // TODO: we don't want to retry for some problems?
+     // Or do a fall off retry...",We don't need this anymore after #2151
+7597,"@@ -48,7 +48,7 @@ namespace NLog.LayoutRenderers
+     [AppDomainFixedOutput]
+     [ThreadAgnostic]
+     [ThreadSafe]
+-    public class MachineNameLayoutRenderer : LayoutRenderer, IStringValueRenderer
++    public class MachineNameLayoutRenderer : LayoutRenderer
+     {
+         internal string MachineName { get; private set; }
+ ",this is this removed? I don't understand in the context of this PR
+7598,"@@ -107,6 +107,9 @@ def getmacbyip6(ip6, chainCC=0):
+     (chainCC parameter value ends up being passed to sending function
+      used to perform the resolution, if needed)
+     """"""
++
++    if isinstance(ip6,Net6):
++        ip6 = iter(ip6).next()
+
+     if in6_ismaddr(ip6): # Multicast
+         mac = in6_getnsmac(inet_pton(socket.AF_INET6, ip6))","`isinstance(ip6, Net6)` instead"
+7599,"@@ -359,10 +359,12 @@ ResultCode NebulaStore::get(GraphSpaceID spaceId,
+ }
+
+
+-ResultCode NebulaStore::multiGet(GraphSpaceID spaceId,
+-                                 PartitionID partId,
+-                                 const std::vector<std::string>& keys,
+-                                 std::vector<std::string>* values) {
++ErrorOr<ResultCode, std::vector<Status>> NebulaStore::multiGet(
++        GraphSpaceID spaceId,
++        PartitionID partId,
++        const std::vector<std::string>& keys,
++        std::vector<std::string>* values,
++        bool returnPartly) {
+     auto ret = part(spaceId, partId);
+     if (!ok(ret)) {
+         return error(ret);","Do we really need the param here? If only partial results returned, we could return ResultCode::PARTIAL_RESULTS;"
+7600,"@@ -330,7 +330,12 @@ func moveOutputs(state *core.BuildState, target *core.BuildTarget) ([]string, bo
+ 	tmpDir := target.TmpDir()
+ 	outDir := target.OutDir()
+ 	for _, output := range target.Outputs() {
+-		tmpOutput := path.Join(tmpDir, output)
++		var tmpOutput string
++		if output == target.Label.PackageName {
++			tmpOutput = path.Join(tmpDir, fmt.Sprintf(core.TmpOutputFormat, output))
++		} else {
++			tmpOutput = path.Join(tmpDir, output)
++		}
+ 		realOutput := path.Join(outDir, output)
+ 		if !core.PathExists(tmpOutput) {
+ 			return nil, true, fmt.Errorf(""Rule %s failed to create output %s"", target.Label, tmpOutput)",this logic seems duplicated from the other new function. I think it should probably be a member function on `BuildTarget`
+7601,"@@ -51,14 +51,13 @@ func TestPatricia(t *testing.T) {
+ 	stream, err := b.serialize()
+ 	assert.Nil(err)
+ 	assert.NotNil(stream)
+-	assert.Equal(byte(1), stream[0])
+ 	b1 := branch{}
+ 	err = b1.deserialize(stream)
+ 	assert.Nil(err)
+ 	assert.Equal(0, bytes.Compare(root, b1.Path[0]))
+ 	assert.Equal(0, bytes.Compare(hash1, b1.Path[2]))
+ 	assert.Equal(0, bytes.Compare(hash2, b1.Path[11]))
+-	assert.Equal(430, len(stream))
++	assert.Equal(114, len(stream))
+
+ 	e := leaf{0, nil, nil}
+ 	e.Path = []byte{2, 3, 5, 7}",size reduce to 1/4 of using Gob
+7602,"@@ -15,13 +15,14 @@ type Writer struct {
+ func NewWriter(w io.Writer, h hash.Hash) *Writer {
+ 	return &Writer{
+ 		h: h,
+-		w: io.MultiWriter(w, h),
++		w: w,
+ 	}
+ }
+
+ // Write wraps the write method of the underlying writer and also hashes all data.
+ func (h *Writer) Write(p []byte) (int, error) {
+ 	n, err := h.w.Write(p)
++	h.h.Write(p[:n])
+ 	return n, err
+ }
+ ",The Hash interface states that a call to `Write()` never returns an error. Does this also apply to the number of written bytes?
+7603,"@@ -5,7 +5,7 @@ module Travis
+     module Appliances
+       class DisableSshRoaming < Base
+         def apply
+-          sh.if ""$(sw_vers -productVersion | cut -d . -f 2) -lt 12"" do
++          sh.if %(""$(sw_vers -productVersion 2>/dev/null | cut -d . -f 2)"" -lt 12) do
+             sh.cmd %(mkdir -p $HOME/.ssh)
+             sh.cmd %(chmod 0700 $HOME/.ssh)
+             sh.cmd %(touch $HOME/.ssh/config)","In my tests, I found that `[[ """" -lt 12 ]]` evaluates to true, but `[[ -lt 12 ]]` is an error, which is why the subshell is wrapped in `""`."
+7604,"@@ -369,6 +369,11 @@ FactoryGirl.define do
+     association :watchable, factory: :product
+     title
+     wistia_id '1194803'
++    published_on Time.zone.today
++
++    trait :unpublished do
++      published_on nil
++    end
+   end
+
+   factory :oauth_access_token do","I don't see a validation on `published_on`, we generally shouldn't specify it in the base factory unless the model would be invalid without the model. Is there a different way we can handle this?"
+7605,"@@ -115,7 +115,7 @@ public final class ConstantScoreQuery extends Query {
+       return new ConstantScoreWeight(this, boost) {
+         @Override
+         public BulkScorer bulkScorer(LeafReaderContext context) throws IOException {
+-          if (scoreMode == ScoreMode.TOP_SCORES) {
++          if (scoreMode == ScoreMode.TOP_SCORES || scoreMode == ScoreMode.TOP_DOCS || scoreMode == ScoreMode.TOP_DOCS_WITH_SCORES) {
+             return super.bulkScorer(context);
+           }
+           final BulkScorer innerScorer = innerWeight.bulkScorer(context);",maybe add a `isExhaustive()` method on the enum to avoid these large conditions?
+7606,"@@ -15,11 +15,13 @@ import (
+ )
+
+ const (
+-	defaultCaFile   = ""ca.pem""
+-	defaultKeyFile  = ""key.pem""
+-	defaultCertFile = ""cert.pem""
+-	dockerSock      = ""/var/run/docker.sock""
+-	dockerSockUnix  = ""unix://"" + dockerSock
++	defaultCaFile               = ""ca.pem""
++	defaultKeyFile              = ""key.pem""
++	defaultCertFile             = ""cert.pem""
++	dockerSock                  = ""/var/run/docker.sock""
++	dockerSockUnix              = ""unix://"" + dockerSock
++	substitutionPatternName     = ""pattern""
++	substitutionReplacementName = ""replacement""
+ )
+
+ var (","so those regexps were wrong previously? e.g. they would match `/v\/foo`? If so, raise a bug and fix on the 1.0 branch."
+7607,"@@ -1417,6 +1417,9 @@ class MultiBackend extends AbstractBase implements \Laminas\Log\LoggerAwareInter
+         bool $stripPrefixes = true,
+         bool $addPrefixes = true
+     ) {
++        if (empty($params) && null === $source) {
++            return null;
++        }
+         if (null === $source) {
+             $source = $this->getSourceForMethod($method, $params);
+         }","I think with MultiBackend we could have a slightly different logic: return true if there are no configured login targets ( = getLoginDrivers returns an empty array). MultiBackend could also check all configured login targets for loginIsHidden support and verify that at least one of the configured login targets allows login, but I wouldn't go that far without a use case. In a related note, I'm not quite sure if loginIsHidden works with ChoiceAuth at all, but that's a different issue."
+7608,"@@ -25,11 +25,13 @@ using namespace LAMMPS_NS;
+ Reader::Reader(LAMMPS *lmp) : Pointers(lmp)
+ {
+   fp = nullptr;
++  binary = false;
++  compressed = false;
+ }
+
+ /* ----------------------------------------------------------------------
+    try to open given file
+-   generic version for ASCII files that may be compressed
++   generic version for ASCII files that may be compressed or native binary dumps
+ ------------------------------------------------------------------------- */
+
+ void Reader::open_file(const std::string &file)",Should we add error info for not supporting the compressed binary?
+7609,"@@ -62,6 +62,8 @@ var (
+ 	// defaulting fails.
+ 	defaultBackoffDelay  = ""PT1S""
+ 	defaultBackoffPolicy = eventingduckv1beta1.BackoffPolicyExponential
++	// clusterRegionGetter is a function that can get the cluster region
++	clusterRegionGetter = utils.NewClusterRegionGetter()
+ )
+
+ // Reconciler implements controller.Reconciler for Trigger resources.",I suggest injecting this into the reconciler. For this and the others. Have Wire generate it and push it into the controller creation.
+7610,"@@ -25,6 +25,11 @@ namespace Nethermind.Core.Json
+ {
+     public class EthereumJsonSerializer : IJsonSerializer
+     {
++        public EthereumJsonSerializer()
++        {
++            _serializer = JsonSerializer.Create(_settings);
++        }
++
+         public static IList<JsonConverter> BasicConverters { get; } = new List<JsonConverter>
+         {
+             new AddressConverter(),",Can't we just make _serializer static? We use same settings every time. I would also put those fields on top of the class for readability.
+7611,"@@ -321,6 +321,7 @@ class HttpLayer(base.Layer):
+
+         try:
+             if websockets.check_handshake(request.headers) and websockets.check_client_version(request.headers):
++                f.metadata['websocket'] = True
+                 # We only support RFC6455 with WebSocket version 13
+                 # allow inline scripts to manipulate the client handshake
+                 self.channel.ask(""websocket_handshake"", f)",Can't we just use `metadata['websocket_flow']` to identify handshake flows and not add another attribute?
+7612,"@@ -81,7 +81,7 @@ module RSpec
+
+           def output_formatted(str)
+             return str unless str.lines.count > 1
+-            separator = ""#{'-' * 80}""
++            separator = '-' * 80
+             ""#{separator}\n#{str.chomp}\n#{separator}""
+           end
+ ",Funny that we were wrapping this with string interpolation before...
+7613,"@@ -0,0 +1,6 @@
++import Controller from '@ember/controller';
++import {alias} from '@ember/object/computed';
++
++export default Controller.extend({
++    guid: alias('model')
++});","I had an eslint error saying I must ""alias"" my model - so I copied this from controllers/site.js"
+7614,"@@ -124,9 +124,9 @@ namespace OpenTelemetry.Metrics
+
+         internal bool InstrumentDisposed { get; set; }
+
+-        public BatchMetricPoint GetMetricPoints()
++        public MetricPointsAccessor GetMetricPointsAccessor()
+         {
+-            return this.aggStore.GetMetricPoints();
++            return this.aggStore.GetMetricPointsAccessor();
+         }
+
+         internal void UpdateLong(long value, ReadOnlySpan<KeyValuePair<string, object>> tags)",unsure if the methodname can still be `GetMetricPoints()` as before...
+7615,"@@ -233,6 +233,7 @@ class ViolationAccess(object):
+                 violation.get('full_name', ''),
+                 violation.get('resource_data', ''),
+                 violation.get('violation_data', ''),
++                violation.get('rule_name', '')
+             )
+
+             violation = Violation(","This file contains the functional changes, the rest is for testing."
+7616,"@@ -22,6 +22,7 @@ package http_test
+
+ import (
+ 	""fmt""
++	""io""
+ 	""log""
+ 	nethttp ""net/http""
+ 	""os""","I know you didn't do this, but there's no need for the `nethttp` alias and it was confusing to me - just remove it and s/nethttp/http/ everywhere (it's fine that the package here is http itself, I do the same thing in transport/grpc)"
+7617,"@@ -1335,6 +1335,12 @@ public class SmartStoreTest extends SmartStoreTestCase {
+ 			JSONObject soupElt = new JSONObject(""{'key':'abcd"" + i + ""', 'value':'va"" + i + ""', 'otherValue':'ova"" + i + ""'}"");
+ 			store.create(TEST_SOUP, soupElt);
+ 		}
++
++		// With WAL enabled we must force a WAL checkpoint if we want the actual DB file to reflect the new content:
++		store.getDatabase()
++				.query(""PRAGMA wal_checkpoint(FULL);"")
++				.moveToNext();
++
+         Assert.assertTrue(""Database should be larger now"", store.getDatabaseSize() > initialSize);
+ 	}
+ ","I felt that this was the most non-invasive way to fix the test, but this does expose some raw DB queries and knowledge about how SQLite works which may be a code smell. The alternative to getting this to pass is to perform enough writes to trigger a checkpoint, but that threshold is determined in the config stage and this test may not be able to know what that page threshold is set to. This could lead to inconsistent test runs which is why I elected to force the checkpoint regardless of the page threshold."
+7618,"@@ -14,7 +14,7 @@
+
+ namespace LightGBM {
+
+-const std::string kModelVersion = ""v2"";
++const std::string kModelVersion = ""v3"";
+
+ std::string GBDT::DumpModel(int start_iteration, int num_iteration) const {
+   std::stringstream str_buf;",Is new model format backward compatible with current v2?
+7619,"@@ -17,6 +17,14 @@ describe 'User creation when logging in with Oauth to view a protected page' do
+     expect(new_user.last_name).to eq(""Jetsonian"")
+   end
+
++  it ""sends welcome email to a new user"" do
++    deliveries.clear
++    expect { get '/auth/myusa/callback' }.to change { deliveries.length }.from(0).to(1)
++    welcome_mail = deliveries.first
++    expect(welcome_mail.subject).to eq(""[TEST] Welcome to C2!"")
++    deliveries.clear
++  end
++
+   it ""absence of first/last name does not throw error"" do
+     user = StructUser.new('somebody@example.com', nil, nil)
+     setup_mock_auth(:myusa, user)",should we perhaps write a spec that ensures we don't send a welcome email to a user on login when the user is not new?
+7620,"@@ -83,6 +83,10 @@ type Config struct {
+ 	// other than containers managed by ECS
+ 	ReservedMemory uint16
+
++	// ContainerTimeout specifies the amount time before a SIGKILL is issued to
++	// containers managed by ECS
++	DockerStopTimeoutSeconds uint64
++
+ 	// AvailableLoggingDrivers specifies the logging drivers available for use
+ 	// with Docker.  If not set, it defaults to [""json-file""].
+ 	AvailableLoggingDrivers []dockerclient.LoggingDriver",I think my preference would be to have the type be a `time.Duration` and use `time.ParseDuration` for parsing.
+7621,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+
+ import com.google.common.base.Predicate;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.
+7622,"@@ -41,7 +41,7 @@ class Yamllint(base.Base):
+     .. code-block:: yaml
+
+         verifier:
+-          name: goss
++          name: ...
+           lint:
+             name: yamllint
+             options:",We should really leave a TODO or something or else we will forget them ...
+7623,"@@ -61,7 +61,7 @@ def define_pandas_source_test_solid():
+     return dm.define_dagstermill_solid(
+         name='pandas_source_test',
+         notebook_path=nb_test_path('pandas_source_test'),
+-        inputs=[InputDefinition(name='df', dagster_type=DataFrame)],
++        inputs=[InputDefinition(name='df', runtime_type=DataFrame)],
+         outputs=[OutputDefinition(DataFrame)],
+     )
+ ","This exposes what a bad name `dagster_type` was, but is it crazy to want this to just be `type` -- do we gain usability by being super-explicit that this is a `runtime_type`? If so, would it make sense to rename the `config_field` to be `config_type`?"
+7624,"@@ -803,6 +803,16 @@ Tries to force this object to take the focus.
+ 		""""""
+ 		speech.speakObject(self,reason=controlTypes.REASON_FOCUS)
+
++	def _get_isSelectionAnchoredAtStart(self):
++		""""""Determine if the selection is anchored at the start.
++		If the selection is anchored at the end or there is no information this is C{False}.
++		@return: C{True} if the selection is anchored at the start else C{False}
++		@rtype: bool
++		""""""
++		if hasattr(self, '_isSelectionAnchoredAtStart'):
++			return self._isSelectionAnchoredAtStart
++		return False
++
+ 	def _reportErrorInPreviousWord(self):
+ 		try:
+ 			# self might be a descendant of the text control; e.g. Symphony.",It might help here if you give a brief explanation of what you mean with a selection being anchored at the start.
+7625,"@@ -7,12 +7,14 @@
+ package transfer
+
+ import (
++	""fmt""
+ 	""math/big""
+
+ 	""github.com/pkg/errors""
+
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/iotxaddress""
++	""github.com/iotexproject/iotex-core/pkg/hash""
+ 	""github.com/iotexproject/iotex-core/state""
+ )
+ ",move cachedStates to handle function
+7626,"@@ -130,7 +130,7 @@ public class GlobalSettings {
+         s.put(""hideSpecialAccounts"", Settings.versions(
+                 new V(1, new BooleanSetting(false))
+             ));
+-        s.put(""keyguardPrivacy"", Settings.versions(
++        s.put(""privacyMode"", Settings.versions(
+                 new V(1, new BooleanSetting(false))
+             ));
+         s.put(""language"", Settings.versions(","I don't think this can just be renamed; it's saying that privacyMode is a BooleanSetting, which it's not."
+7627,"@@ -595,7 +595,7 @@ public class SharedCoreConcurrencyTest extends SolrCloudSharedStoreTestCase {
+       public void recordState(String collectionName, String shardName, String coreName, SharedCoreStage stage) {
+         super.recordState(collectionName, shardName, coreName, stage);
+         ConcurrentLinkedQueue<String> coreConcurrencyStages = coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());
+-        coreConcurrencyStages.add(Thread.currentThread().getId() + ""."" + stage.name());
++        coreConcurrencyStages.add(Thread.currentThread().getName() + ""."" + stage.name());
+       }
+     };
+     setupTestSharedConcurrencyControllerForNode(concurrencyController, solrProcess);",what was the reason for this change?
+7628,"@@ -1,14 +1,8 @@
+ using System;
+-using System.Collections.Concurrent;
+-using System.Collections.Generic;
+ using System.Configuration;
+-using System.Linq;
+-using System.Text;
+-using System.Web;
+-
+-[assembly: System.Security.SecurityCritical]
+-[assembly: System.Security.AllowPartiallyTrustedCallers]
+
++// [assembly: System.Security.SecurityCritical]
++// [assembly: System.Security.AllowPartiallyTrustedCallers]
+ namespace Datadog.Trace.ClrProfiler
+ {
+     /// <summary>","Minor, but these two nullable and the logic around them could be replaced by a Lazy<Bool>."
+7629,"@@ -1,12 +1,17 @@
+ package main
+
+ import (
++	""os""
++	""strconv""
+ 	""sync/atomic""
+ 	""syscall""
+ 	""time""
+
+-	""github.com/weaveworks/go-checkpoint""
++	checkpoint ""github.com/weaveworks/go-checkpoint""
+ 	weave ""github.com/weaveworks/weave/router""
++	api ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/client-go/kubernetes""
++	""k8s.io/client-go/rest""
+ )
+
+ var checker *checkpoint.Checker","I think I would just pass in `len(peers)`, on the principle of minimum information."
+7630,"@@ -84,6 +84,9 @@ public class TableProperties {
+   public static final String PARQUET_BATCH_SIZE = ""read.parquet.vectorization.batch-size"";
+   public static final int PARQUET_BATCH_SIZE_DEFAULT = 5000;
+
++  public static final String PARQUET_IN_LIMIT = ""read.parquet.in-predicate-limit"";
++  public static final int PARQUET_IN_LIMIT_DEFAULT = 200;
++
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ ","Spark's default value is 10 but it also rewrites IN as OR/EQUALS. We can do better that this because of the way we evaluate IN predicates. On datasets we tested this, we saw performance improvements on IN predicates with up to 200 elements (on sorted column). We may increase the default value a bit but I am very reluctant to make it more than 300 since our jobs were 20% slower with IN predicates that contained 300 elements. That being said, the optimal value still depends on a particular query and table."
+7631,"@@ -20,6 +20,7 @@ package org.springframework.security.oauth2.core.oidc.endpoint;
+  * and used by the authorization endpoint and token endpoint.
+  *
+  * @author Joe Grandja
++ * @author Mark Heckler
+  * @since 5.0
+  * @see <a target=""_blank"" href=""https://openid.net/specs/openid-connect-core-1_0.html#OAuthParametersRegistry"">18.2 OAuth Parameters Registration</a>
+  */",Please update copyright year.
+7632,"@@ -289,9 +289,13 @@ int Extractor::run(ScriptingEnvironment &scripting_environment)
+
+         WriteEdgeBasedGraph(config.edge_graph_output_path, max_edge_id, edge_based_edge_list);
+
+-        util::SimpleLogger().Write()
+-            << ""Expansion  : "" << (number_of_node_based_nodes / TIMER_SEC(expansion))
+-            << "" nodes/sec and "" << ((max_edge_id + 1) / TIMER_SEC(expansion)) << "" edges/sec"";
++        const auto nodes_per_second =
++            static_cast<std::uint64_t>(number_of_node_based_nodes / TIMER_SEC(expansion));
++        const auto edges_per_second =
++            static_cast<std::uint64_t>((max_edge_id + 1) / TIMER_SEC(expansion));
++
++        util::SimpleLogger().Write() << ""Expansion: "" << nodes_per_second << "" nodes/sec and ""
++                                     << edges_per_second << "" edges/sec"";
+         util::SimpleLogger().Write() << ""To prepare the data for routing, run: ""
+                                      << ""./osrm-contract "" << config.output_file_name << std::endl;
+     }","Same here, could just be `std::setprecision`."
+7633,"@@ -2290,14 +2290,6 @@ func (fbo *folderBranchOps) getConvID(
+
+ func (fbo *folderBranchOps) sendEditNotifications(
+ 	ctx context.Context, rmd ImmutableRootMetadata, body string) error {
+-	// For now only write out the notifications if we're in test mode,
+-	// just in case we decide to change the notification format before
+-	// we launch.  TODO: turn this on for admins once we can test it
+-	// on staging.
+-	if !fbo.config.Mode().IsTestMode() {
+-		return nil
+-	}
+-
+ 	handle := rmd.GetTlfHandle()
+ 	convID, err := fbo.getConvID(ctx, handle)
+ 	if err != nil {","Do we still want the ""admins"" gate?"
+7634,"@@ -1,8 +1,11 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
+ # This code example demonstrates how to upload multiple items
+-# to a bucket in Amazon S3.
++# to a bucket in Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3-ruby-example-upload-multiple-items]
+
+ # Prerequisites:
+ #  - An existing Amazon S3 bucket.",Simple Storage **Service**
+7635,"@@ -172,4 +172,11 @@ type Config struct {
+
+ 	// Configures telemetry.
+ 	Metrics MetricsConfig
++
++	// DisableAutoObservabilityMiddleware is used to stop the dispatcher from
++	// automatically attaching observability middleware to all inbounds and
++	// outbounds.  It is the assumption that if if this option is disabled the
++	// observability middleware is being inserted in the Inbound/Outbound
++	// Middleware.
++	DisableAutoObservabilityMiddleware bool
+ }",nit: `it is assumed`
+7636,"@@ -23,6 +23,7 @@
+ #include <stdint.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <stdbool.h>
+ #include ""h2o.h""
+ #include ""h2o/http2.h""
+ #include ""h2o/http2_internal.h""","I would appreciate it if you could refrain from using `stdbool.h`. We allow the header files of H2O to be included from C++ (which means that `bool` might be a C++ type), and therefore my preference is to not use `bool` in our code (but instead use `int` or `char` for the purpose) to avoid confusion."
+7637,"@@ -843,6 +843,9 @@ class RelationController extends ControllerBehavior
+             }
+
+             $widget = $this->makeWidget('Backend\Widgets\Lists', $config);
++            $widget->setSearchOptions([
++                'scope' => $this->getConfig('manage[searchScope]')
++            ]);
+
+             /*
+              * Apply defined constraints",@danielbidala What happens if `searchScope` is not defined in `config_relation.yaml` ?
+7638,"@@ -57,14 +57,17 @@ func serviceLoggedIn(ctx context.Context, config Config, session SessionInfo,
+ 			""%+v"", err)
+ 	}
+
++	// Launch auth refreshes in the background, in case we are
++	// currently disconnected from one of these servers.
+ 	mdServer := config.MDServer()
+ 	if mdServer != nil {
+-		mdServer.RefreshAuthToken(ctx)
++		go mdServer.RefreshAuthToken(context.Background())
+ 	}
+ 	bServer := config.BlockServer()
+ 	if bServer != nil {
+-		bServer.RefreshAuthToken(ctx)
++		go bServer.RefreshAuthToken(context.Background())
+ 	}
++
+ 	config.KBFSOps().RefreshCachedFavorites(ctx)
+ 	config.KBFSOps().PushStatusChange()
+ 	return wg",Do we want maybe a 1min timeout?
+7639,"@@ -48,11 +48,11 @@ func BasicAuthDecode(encoded string) (user string, name string, err error) {
+ 		return user, name, err
+ 	}
+
+-	a := strings.Split(string(s), "":"")
+-	if len(a) == 2 {
+-		user, name = a[0], a[1]
+-	} else {
++	a := strings.SplitN(string(s), "":"", 2)
++	if len(a) != 2 {
+ 		err = errors.New(""decode failed"")
++	} else {
++		user, name = a[0], a[1]
+ 	}
+ 	return user, name, err
+ }","I guess code never reaches this line, you can remove `else` block and just `return a[0], a[1]`. Also, probably rename `a` to `auth` as well."
+7640,"@@ -43,7 +43,7 @@ class SerializableByteBufferMap implements Map<Integer, ByteBuffer>, Serializabl
+     return new SerializableByteBufferMap(map);
+   }
+
+-  public SerializableByteBufferMap() {
++  SerializableByteBufferMap() {
+     this.wrapped = Maps.newLinkedHashMap();
+   }
+ ",Doesn't this no-arg constructor need to be public for serialization to work?
+7641,"@@ -20,7 +20,7 @@ return [
+     'alpha_dash'           => 'Hierdie veld mag slegs letters, syfers, strepies en onderstrepe bevat.',
+     'alpha_num'            => 'Hierdie veld mag slegs letters en syfers bevat.',
+     'array'                => 'Hierdie veld moet \'n array wees.',
+-    'attached'             => 'This field is already attached.',
++    'attached'             => 'Hierdie gebied is reeds aangeheg.',
+     'before'               => 'Dit moet \'n datum voor :date wees.',
+     'before_or_equal'      => 'Dit moet \'n datum gelyk of voor :date wees.',
+     'between'              => [","Just use the word ""veld"" instead of ""gebied"" here"
+7642,"@@ -22,6 +22,7 @@ import android.util.Log;
+ import android.webkit.URLUtil;
+
+ import org.apache.commons.io.FileUtils;
++import org.shredzone.flattr4j.model.User;
+ import org.xml.sax.SAXException;
+
+ import java.io.File;",This change (import org.shredzone.flatter4j.model.User;) does not seem relevant to this fix / commit.
+7643,"@@ -63,6 +63,7 @@ var (
+ 	noCleanup            = app.Flag(""no-cleanup"", ""Whether or not to delete the chroot folder after the build is done"").Bool()
+ 	noCache              = app.Flag(""no-cache"", ""Disables using prebuilt cached packages."").Bool()
+ 	stopOnFailure        = app.Flag(""stop-on-failure"", ""Stop on failed build"").Bool()
++	hydratedBuild        = app.Flag(""hydrated-build"", ""Build individual packages with Hydrated RPMs"").String()
+
+ 	validBuildAgentFlags = []string{buildagents.TestAgentFlag, buildagents.ChrootAgentFlag}
+ 	buildAgent           = app.Flag(""build-agent"", ""Type of build agent to build packages with."").PlaceHolder(exe.PlaceHolderize(validBuildAgentFlags)).Required().Enum(validBuildAgentFlags...)",This should be a Bool() rather than a String(). (See the other PR for an example)
+7644,"@@ -243,7 +243,7 @@ rules:
+         """"""Test that a bucket's rule can guarantee the maximum_retention if its
+         action is 'Delete' and the only condition is an age(<= maximum_retention)""""""
+         rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
+-        self.assertEqual(1, len(rules_engine.rule_book.resource_rules_map))
++        self.assertTrue(1 <= len(rules_engine.rule_book.resource_rules_map))
+
+         data_creater = frsd.FakeBucketDataCreater('fake_bucket', frsd.PROJECT1)
+         data_creater.AddLifecycleDict(action=""Delete"", age=365)",This should be a failure if we don't get the exact number of expected rules. You can use a constant if you don't want to update several lines any time you update the test rule strings.
+7645,"@@ -38,14 +38,14 @@ namespace Nethermind.Blockchain.Synchronization
+             _syncPeerPool = syncPeerPool ?? throw new ArgumentNullException(nameof(syncPeerPool));
+             _syncConfig = syncConfig ?? throw new ArgumentNullException(nameof(syncConfig));
+             _logger = logManager.GetClassLogger() ?? throw new ArgumentNullException(nameof(logManager));
+-
++
+             Current = SyncMode.NotStarted;
+         }
+
+         public SyncMode Current { get; private set; }
+
+         public bool IsParallel => Current == SyncMode.FastBlocks || Current == SyncMode.StateNodes;
+-
++
+         public void Update()
+         {
+             if (_syncPeerPool.PeerCount == 0)","We need to switch from BeamSync to FullSync when we download all the needed headers, blocks, receipts and state"
+7646,"@@ -61,15 +61,15 @@ thrift_protocol_set_property (GObject *object, guint property_id,
+   switch (property_id)
+   {
+     case PROP_THRIFT_PROTOCOL_TRANSPORT:
+-      protocol->transport = g_value_get_object (value);
++      protocol->transport = g_value_dup_object (value);
+       break;
+   }
+ }
+
+
+ gint32
+-thrift_protocol_write_message_begin (ThriftProtocol *protocol,
+-                                     const gchar *name,
++thrift_protocol_write_message_begin (ThriftProtocol *protocol,
++                                     const gchar *name,
+                                      const ThriftMessageType message_type,
+                                      const gint32 seqid, GError **error)
+ {",Why you duplicate it? The underlaying transport should live as long as the multiplexed one. And must be destroyed after protocol is destroyed. Duplicating the transport may lead to object references hold and maybe memory freeing problems. I think this property must hold a reference to it and not a copy. The copy can lead to memory freeing problems.
+7647,"@@ -97,6 +97,7 @@ func (in *{{.Type}}) GetChaos() *ChaosInstance {
+ 		Kind:      Kind{{.Type}},
+ 		StartTime: in.CreationTimestamp.Time,
+ 		Action:    """",
++		Status:    string(in.Status.ChaosStatus.Experiment.Phase),
+ 		UID:       string(in.UID),
+ 	}
+ ",`in.Status.Experiment.Phase`. we can omit `ChaosStatus`
+7648,"@@ -1,9 +1,12 @@
+ package cmd
+
+ import (
++	""bytes""
+ 	""testing""
+
+ 	""encoding/json""
++	oexec ""os/exec""
++	""time""
+
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""",Just curious... why the alias here?
+7649,"@@ -28,6 +28,7 @@
+         /// </summary>
+         private void InitializeComponent()
+         {
++            System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(DetectionToolbarProperties));
+             this.btnCancel = new System.Windows.Forms.Button();
+             this.btnOk = new System.Windows.Forms.Button();
+             this.label1 = new System.Windows.Forms.Label();",Seems like this should conflict with changes I made during merging of the 20.2 RESX file translation
+7650,"@@ -11,6 +11,8 @@
+ #include ""graph/planner/plan/Query.h""
+ #include ""graph/util/ExpressionUtils.h""
+
++DEFINE_bool(enable_opt_collapse_project_rule, true, """");
++
+ using nebula::graph::PlanNode;
+ using nebula::graph::QueryContext;
+ ",Why disable this rule?
+7651,"@@ -124,6 +124,6 @@ class ExternalEditor(QObject):
+         self._proc.error.connect(self.on_proc_error)
+         editor = config.get('general', 'editor')
+         executable = editor[0]
+-        args = [self._filename if arg == '{}' else arg for arg in editor[1:]]
++        args = [arg.replace('{}', self._filename) if '{}' in arg else arg for arg in editor[1:]]
+         log.procs.debug(""Calling \""{}\"" with args {}"".format(executable, args))
+         self._proc.start(executable, args)","I think you don't need the `... if '{}' in arg else arg` part - if the arg doesn't contain `{}`, `arg.replace('{}', ...)` will return the unchanged string anyways."
+7652,"@@ -21,9 +21,11 @@ from google.cloud.security.common.util import log_util
+ from google.cloud.security.common.data_access import errors as dao_errors
+ from google.cloud.security.inventory import errors as inventory_errors
+ from google.cloud.security.inventory.pipelines import base_pipeline
++import threading
+
+
+ LOGGER = log_util.get_logger(__name__)
++GROUP_CHUNK_SIZE = 20
+
+
+ class LoadGroupMembersPipeline(base_pipeline.BasePipeline):",nit: Should we make this an attribute of the LoadGroupMembersPIpeline class?
+7653,"@@ -479,6 +479,8 @@ public class JDBCConnection implements ObjectStoreConnection {
+             + ""JOIN principal ON principal.principal_id=principal_group_member.principal_id ""
+             + ""JOIN domain ON domain.domain_id=principal_group.domain_id ""
+             + ""WHERE principal_group_member.last_notified_time=? AND principal_group_member.server=?;"";
++    private static final String SQL_UPDATE_PRINCIPAL = ""UPDATE principal SET system_suspended=? WHERE principal_id=?;"";
++    private static final String SQL_GET_PRINCIPAL = ""SELECT name FROM principal WHERE system_suspended=?;"";
+
+     private static final String CACHE_DOMAIN    = ""d:"";
+     private static final String CACHE_ROLE      = ""r:"";",need to update this command to use the name field instead of principal_id
+7654,"@@ -51,7 +51,7 @@ public class PrivGetTransactionCount extends PrivacyApiMethod {
+     final Address address = requestContext.getRequiredParameter(0, Address.class);
+     final String privacyGroupId = requestContext.getRequiredParameter(1, String.class);
+
+-    final long nonce = privateTransactionHandler.getSenderNonce(address, privacyGroupId);
++    final long nonce = privateTransactionHandler.determineNonce(address, privacyGroupId);
+     return new JsonRpcSuccessResponse(requestContext.getRequest().getId(), Quantity.create(nonce));
+   }
+ }",nit: I can't help but think the privateTransactionHandler should be a base-class member ... every Priv Json RPC seems to need it...
+7655,"@@ -230,12 +230,8 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
+                 .setOnPreferenceChangeListener(
+                         (preference, newValue) -> {
+                             Intent i = new Intent(activity, MainActivity.class);
+-                            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
+-                                i.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK
+-                                        | Intent.FLAG_ACTIVITY_NEW_TASK);
+-                            } else {
+-                                i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+-                            }
++                            i.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK
++                                    | Intent.FLAG_ACTIVITY_NEW_TASK);
+                             activity.finish();
+                             activity.startActivity(i);
+                             return true;","Why does this start the main activity and not the preferences? With `overridePendingTransition(0, 0)`, this could instantly switch the theme without the user being disrupted"
+7656,"@@ -117,6 +117,10 @@ public class DistributorStatus {
+       return up;
+     }
+
++    public boolean isDocker() {
++      return up;
++    }
++
+     public int getMaxSessionCount() {
+       return maxSessionCount;
+     }",Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?
+7657,"@@ -15,7 +15,7 @@ VERSION = ""2015-06-15""
+ # prerequisite: setuptools
+ # http://pypi.python.org/pypi/setuptools
+
+-REQUIRES = [""msrest>=0.1.0"", ""msrestazure>=0.1.0""]
++REQUIRES = [""msrest>=0.2.0"", ""msrestazure>=0.2.1""]
+
+ setup(
+     name=NAME,",It appears as though whoever checked in python changes didn't re-run regenerate:expected. I am modifying these files as a result of running that after a sync and build.
+7658,"@@ -329,4 +329,13 @@ public abstract class FlatteningConfig {
+     paramList.forEach(p -> paramsAsString.append(p.getSimpleName()).append("", ""));
+     return paramsAsString.toString();
+   }
++
++  /** Return if the flattening config contains a parameter that is a resource name. */
++  public static boolean hasAnyResourceNameParameter(FlatteningConfig flatteningGroup) {
++    return flatteningGroup
++        .getFlattenedFieldConfigs()
++        .values()
++        .stream()
++        .anyMatch(FieldConfig::useResourceNameType);
++  }
+ }",This was copied from JavaMethodViewGenerator; only the `public static` method modifiers were added.
+7659,"@@ -327,6 +327,18 @@ public class Transaction implements org.hyperledger.besu.plugin.data.Transaction
+     return Optional.ofNullable(maxFeePerGas);
+   }
+
++  public long getEffectivePriorityFeePerGas(final Optional<Long> maybeBaseFee) {
++    return maybeBaseFee
++        .filter(__ -> getType().supports1559FeeMarket())
++        .map(
++            baseFee ->
++                Math.max(
++                    0,
++                    Math.min(
++                        getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(),
++                        getMaxFeePerGas().get().getAsBigInteger().longValue() - baseFee)))
++        .orElseGet(() -> getGasPrice().getValue().longValue());
++  }
+   /**
+    * Returns the transaction gas limit.
+    *",this is going to throw for frontier transactions post-london
+7660,"@@ -389,8 +389,6 @@ class PropelInitService
+                 $theliaDatabaseConnection->useDebug(true);
+             }
+         } catch (\Throwable $th) {
+-            Tlog::getInstance()->error(""Failed to initialize Propel : "" . $th->getMessage());
+-
+             throw $th;
+         } finally {
+             // Release cache generation lock",The catch clause is not needed. The finally clause alone is enough.
+7661,"@@ -117,6 +117,10 @@ public class DistributorStatus {
+       return up;
+     }
+
++    public boolean isDocker() {
++      return up;
++    }
++
+     public int getMaxSessionCount() {
+       return maxSessionCount;
+     }",Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?
+7662,"@@ -99,7 +99,7 @@ SRVR_STMT_HDL::SRVR_STMT_HDL(long inDialogueId)
+     moduleName[0] = '\0';
+     inputDescName[0] = '\0';
+     outputDescName[0] = '\0';
+-    isClosed = TRUE;
++    isClosed = FALSE;
+     IPD = NULL;
+     IRD = NULL;
+     useDefaultDesc = FALSE;",Changing the default value for isClosed from TRUE to FALSE can have other repercussions. We might miss throwing error. Can you please confirm this change.
+7663,"@@ -286,11 +286,13 @@ func (payloadHandler *payloadRequestHandler) handleUnrecognizedTask(task *ecsacs
+ 	}
+
+ 	// Only need to stop the task; it brings down the containers too.
+-	payloadHandler.taskHandler.AddTaskEvent(api.TaskStateChange{
++	te := api.TaskStateChange{
+ 		TaskArn: *task.Arn,
+ 		Status:  api.TaskStopped,
+ 		Reason:  UnrecognizedTaskError{err}.Error(),
+-	}, payloadHandler.ecsClient)
++	}
++
++	payloadHandler.taskHandler.AddStateChangeEvent(te, payloadHandler.ecsClient)
+ }
+
+ // clearAcks drains the ack request channel",Please use more meaningful names than `te`here and in other places.
+7664,"@@ -33,8 +33,9 @@ type Catalog interface {
+ 	// the generic Plugin type
+ 	Plugins() []*ManagedPlugin
+
+-	// Finds plugin metadata
+-	Find(Plugin) *ManagedPlugin
++	// ConfigFor finds the plugin configuration for the supplied plugin. nil
++	// is returned if the plugin is not managed by the catalog.
++	ConfigFor(interface{}) *PluginConfig
+ }
+
+ type Config struct {","Perhaps this would be more idiomatic as `ConfigFor(interface{}) (*PluginConfig, bool)`?"
+7665,"@@ -3,9 +3,10 @@ from requests.models import Request
+ from localstack.utils.common import to_str
+ from localstack.services.generic_proxy import ProxyListener
+
++AWS_JSON_CONTENT_TYPE = 'application/x-amz-json-1.1'
+
+-class ProxyListenerCloudWatchLogs(ProxyListener):
+
++class ProxyListenerCloudWatchLogs(ProxyListener):
+     def forward_request(self, method, path, data, headers):
+         if method == 'POST' and path == '/':
+             if 'nextToken' in to_str(data or ''):",nit: We could import `APPLICATION_AMZ_JSON_1_1` from `constants.py` here.
+7666,"@@ -0,0 +1,15 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MS-PL license.
++// See the LICENSE file in the project root for more information.
++
++using System;
++using System.Threading.Tasks;
++
++namespace MvvmCross.Base
++{
++    public interface IMvxMainThreadAsyncDispatcher
++    {
++        Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);
++        Task ExecuteOnMainThreadAsync(Func<Task> action, bool maskExceptions = true);
++    }
++}",Should this not inherit from IMvxMainThreadDispatcher?
+7667,"@@ -19,18 +19,13 @@ import (
+
+ type roundCalculator struct {
+ 	chain                  ChainManager
+-	blockInterval          time.Duration
+ 	timeBasedRotation      bool
+ 	rp                     *rolldpos.Protocol
+ 	candidatesByHeightFunc CandidatesByHeightFunc
+ 	beringHeight           uint64
+ }
+
+-func (c *roundCalculator) BlockInterval() time.Duration {
+-	return c.blockInterval
+-}
+-
+-func (c *roundCalculator) UpdateRound(round *roundCtx, height uint64, now time.Time, toleratedOvertime time.Duration) (*roundCtx, error) {
++func (c *roundCalculator) UpdateRound(round *roundCtx, height uint64, blockInterval time.Duration, now time.Time, toleratedOvertime time.Duration) (*roundCtx, error) {
+ 	epochNum := round.EpochNum()
+ 	epochStartHeight := round.EpochStartHeight()
+ 	delegates := round.Delegates()",line is 167 characters (from `lll`)
+7668,"@@ -13,6 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
++using System.Collections.Generic;
+ using System.Diagnostics;
+ using OpenTelemetry;
+ using OpenTelemetry.Resources;",nit: consider adding a blank line between L15 and L16.
+7669,"@@ -445,10 +445,11 @@ void Storage::PopulateLayout(DataLayout &layout)
+     {
+         io::FileReader maneuver_overrides_file(config.GetPath("".osrm.maneuver_overrides""),
+                                                io::FileReader::VerifyFingerprint);
+-        const auto number_of_overrides = maneuver_overrides_file.ReadElementCount64();
++        const auto number_of_overrides =
++            maneuver_overrides_file.ReadVectorSize<extractor::StorageManeuverOverride>();
+         layout.SetBlockSize<extractor::StorageManeuverOverride>(DataLayout::MANEUVER_OVERRIDES,
+                                                                 number_of_overrides);
+-        const auto number_of_nodes = maneuver_overrides_file.ReadElementCount64();
++        const auto number_of_nodes = maneuver_overrides_file.ReadVectorSize<NodeID>();
+         layout.SetBlockSize<NodeID>(DataLayout::MANEUVER_OVERRIDE_NODE_SEQUENCES, number_of_nodes);
+     }
+ ",This is another bug fix: Without skipping the bytes of the vector this would read garbage data.
+7670,"@@ -353,10 +353,12 @@ func (bc *blockchain) startExistingBlockchain(recoveryHeight uint64) error {
+ 	}
+ 	ws, err := bc.sf.NewWorkingSet()
+ 	if err != nil {
+-		return errors.Wrap(err, ""Failed to obtain working set from state factory"")
++		return errors.Wrap(err, ""failed to obtain working set from state factory"")
+ 	}
+ 	// If restarting factory from fresh db, first create creator's state
+ 	if startHeight == 0 {
++		actions := loadGenesisData(bc.config)
++		Gen.CreatorPubKey = actions.Creation.PubKey
+ 		if _, err := ws.LoadOrCreateAccountState(Gen.CreatorAddr(bc.ChainID()), Gen.TotalSupply); err != nil {
+ 			return err
+ 		}",why need this? i don't see Gen.CreatorPubKey being used?
+7671,"@@ -147,6 +147,8 @@ OpenStreetMap::Application.routes.draw do
+   get ""/help"" => ""site#help""
+   get ""/about/:about_locale"" => ""site#about""
+   get ""/about"" => ""site#about""
++  get ""/communities"" => ""site#communities""
++  get ""/communities/:communities_locale"" => ""site#communities""
+   get ""/history"" => ""changesets#index""
+   get ""/history/feed"" => ""changesets#feed"", :defaults => { :format => :atom }
+   get ""/history/comments/feed"" => ""changeset_comments#index"", :as => :changesets_comments_feed, :defaults => { :format => ""rss"" }","As previously mentioned, best to drop this locale override. It's not something we only provide in exceptional circumstances. Moreover, it doesn't work for this PR anyway, while massively increasing the code complexity!"
+7672,"@@ -24,5 +24,16 @@ var (
+ 		  ""openebs.io/version"": ""{{.}}""
+ 	   }
+ 	}
++ }`
++	// VersionDetailsPatch is generic template for version details patch
++	VersionDetailsPatch = `{
++	""metadata"": {
++	   ""labels"": {
++		  ""openebs.io/version"": ""{{.}}""
++	   }
++	},
++	""versionDetails"": {
++		""desired"": ""{{.}}""
++	}
+  }`
+ )",is this supposed to be `Desired`?
+7673,"@@ -1903,9 +1903,6 @@ public class TestPointQueries extends LuceneTestCase {
+       upperBound[i] = value[i] + random().nextInt(1);
+     }
+     Query query = IntPoint.newRangeQuery(""point"", lowerBound, upperBound);
+-    Weight weight = searcher.createWeight(query, ScoreMode.COMPLETE_NO_SCORES, 1);
+-    Scorer scorer = weight.scorer(searcher.getIndexReader().leaves().get(0));
+-    assertEquals(DocIdSetIterator.all(1).getClass(), scorer.iterator().getClass());
+
+     // When not all documents in the query have a value, the optimization is not applicable
+     reader.close();",The iterator is not wrapped when the score mode is set to `COMPLETE_NO_SCORES` so you don't need to change this assertion anymore ?
+7674,"@@ -9,7 +9,8 @@ def render_template(template, destination, **kwargs):
+     template = os.path.join(HERE, template)
+
+     folder = os.path.dirname(destination)
+-    os.makedirs(folder)
++    if os.path.exists(folder) == False:
++            os.makedirs(folder)
+
+     with codecs.open(template, 'r', encoding='utf-8') as f:
+         raw_template = f.read()",Is there too much spaces there? (should be 4 I think)
+7675,"@@ -57,6 +57,8 @@ public class KieClient {
+
+   private static final int LONG_POLLING_WAIT_TIME_IN_SECONDS = 30;
+
++  private static String revision = ""0"";
++
+   private static final KieConfig KIE_CONFIG = KieConfig.INSTANCE;
+
+   private final int refreshInterval = KIE_CONFIG.getRefreshInterval();","IS_FIRST_PULL revision is better to use instance property, not static. When KieClient has only one instance, instance property is better. When KieClient has many instances(not possible), static is not good eitheir."
+7676,"@@ -1,4 +1,5 @@
+ <?php
+ return [
+     'extends' => 'bootstrap3',
++    'mixins' => ['fontawesome5_icon_mixin'],
+ ];",This needs to be removed since we removed the mixin.
+7677,"@@ -219,8 +219,7 @@ RaftPart::RaftPart(ClusterID clusterId,
+         , ioThreadPool_{pool}
+         , bgWorkers_{workers}
+         , executor_(executor)
+-        , snapshot_(snapshotMan)
+-        , weight_(1) {
++        , snapshot_(snapshotMan) {
+     FileBasedWalPolicy policy;
+     policy.ttl = FLAGS_wal_ttl;
+     policy.fileSize = FLAGS_wal_file_size;",Can `weight_` be deleted?
+7678,"@@ -50,6 +50,17 @@ class EasyAdminExtension extends Extension
+         }
+
+         $this->ensureBackwardCompatibility($container);
++
++        if ($container->hasParameter('locale')) {
++            $container->getDefinition('easyadmin.configuration.design_config_pass')
++                ->replaceArgument(1, $container->getParameter('locale'));
++        }
++
++        $configPasses = $container->findTaggedServiceIds('easyadmin.config_pass');
++        $definition = $container->getDefinition('easyadmin.config.manager');
++        foreach ($configPasses as $id => $tags) {
++            $definition->addMethodCall('addConfigPass', array(new Reference($id)));
++        }
+     }
+
+     /**","This is fine, but by Symfony convention this part is responsability of the compiler pass class, i.e `DependencyInjection\Compiler\?`"
+7679,"@@ -9,6 +9,18 @@ module Unix::File
+     execute(""mktemp -td #{name}.XXXXXX"")
+   end
+
++  # Create a temporary directory owned by the Puppet user.
++  #
++  # @param name [String] The name of the directory.  It will be suffixed with a
++  #   unique identifier to avoid conflicts.
++  # @return [String] The path to the temporary directory.
++  def puppet_tmpdir(name)
++    dir = tmpdir(name)
++    user = execute(""puppet master --configprint user"")
++    execute(""chown #{user} #{dir}"")
++    dir
++  end
++
+   def path_split(paths)
+     paths.split(':')
+   end",The host object already has a nice way of querying configprint. Try `puppet('master')['user']`
+7680,"@@ -20,6 +20,7 @@ from mitmproxy.addons import stickycookie
+ from mitmproxy.addons import streambodies
+ from mitmproxy.addons import save
+ from mitmproxy.addons import upstream_auth
++from mitmproxy.addons import upload
+
+
+ def default_addons():","Let's call this `share` and not `upload` - the user wants to share their flows, uploading is just the implementation of that. :)"
+7681,"@@ -6,8 +6,9 @@
+
+ import wx
+ import gui
++import config
+
+-class SpeechViewerFrame(wx.MiniFrame):
++class SpeechViewerFrame(wx.Dialog):
+
+ 	def __init__(self):
+ 		super(SpeechViewerFrame, self).__init__(gui.mainFrame, wx.ID_ANY, _(""NVDA Speech Viewer""), style=wx.CAPTION | wx.RESIZE_BORDER | wx.STAY_ON_TOP)","It would be better to keep focus on the main text control. But to get around the fact that Dialogs focus their first child on show, even when not active, something like Dialog.isActive should be chcked when appending text, rather than whether the text control has focus."
+7682,"@@ -1205,6 +1205,7 @@ end_and_emit_trace(dcontext_t *dcontext, fragment_t *cur_f)
+         target = opnd_get_pc(instr_get_target(last));
+         md->emitted_size -= local_exit_stub_size(dcontext, target, md->trace_flags);
+     }
++    IF_AARCH64(md->emitted_size += fixup_indirect_trace_exit(dcontext, trace));
+
+     if (DYNAMO_OPTION(speculate_last_exit)
+ #ifdef HASHTABLE_STATISTICS",So is this invoked every time we extend the trace?
+7683,"@@ -55,11 +55,16 @@ constexpr int64_t kMaxTimestamp = std::numeric_limits<int64_t>::max() / 10000000
+         return Status::Error(""Invalid second number `%ld'."", kv.second.getInt());
+       }
+       dt.sec = kv.second.getInt();
++    } else if (kv.first == ""millisecond"") {
++      if (kv.second.getInt() < 0 || kv.second.getInt() > 999) {
++        return Status::Error(""Invalid millisecond number `%ld'."", kv.second.getInt());
++      }
++      dt.microsec += kv.second.getInt() * 1000;
+     } else if (kv.first == ""microsecond"") {
+-      if (kv.second.getInt() < 0 || kv.second.getInt() > 999999) {
++      if (kv.second.getInt() < 0 || kv.second.getInt() > 999) {
+         return Status::Error(""Invalid microsecond number `%ld'."", kv.second.getInt());
+       }
+-      dt.microsec = kv.second.getInt();
++      dt.microsec += kv.second.getInt();
+     } else {
+       return Status::Error(""Invlaid parameter `%s'."", kv.first.c_str());
+     }",Why not use switch here?
+7684,"@@ -37,6 +37,7 @@ type Route struct {
+ 	Method      string
+ 	Path        string
+ 	HandlerFunc HandlerFunc
++	AuthFree    bool // routes that has the AuthFree set to true doesn't require authentication
+ }
+
+ // Routes contains all routes",I think `NoAuth` is a better name
+7685,"@@ -214,6 +214,13 @@ func (es *{{ $esapi.Name }}) waitStreamPartClose() {
+ 			es.inputWriter = inputWriter
+ 	}
+
++	func (es *{{ $esapi.Name }}) closeInputWriter(r *request.Request) {
++		err := es.inputWriter.Close()
++		if err != nil {
++			r.Error = awserr.New(eventstreamapi.InputWriterCloseErrorCode, err.Error(), r.Error)
++		}
++	}
++
+ 	// Send writes the event to the stream blocking until the event is written.
+ 	// Returns an error if the event was not written.
+ 	//",This does create a minor bifurcation in how closing the InputWriter is done in success vs failure cases. Is there anyway to merge this with the success exit path? This is something that seems like it would be better as a function closure instead of method on the `$esapi.Name` type. Can the `es.Close` not be used instead of this method?
+7686,"@@ -132,7 +132,6 @@ class RootContext(object):
+
+
+ class Log(object):
+-
+     def __init__(self, msg, level=""info""):
+         self.msg = msg
+         self.level = level",Please keep this blank line. PEP8 says: > Method definitions inside a class are surrounded by a single blank line.
+7687,"@@ -6,7 +6,7 @@
+       <%= link_to(t(:'blacklight.search.per_page.button_label', :count => current_per_page), ""#"") %> <span class=""caret""></span>
+       <ul>
+         <%- blacklight_config.per_page.each do |count| %>
+-          <li><%= link_to(t(:'blacklight.search.per_page.label', :count => count).html_safe, url_for(params_for_search(:per_page => count))) %></li>
++          <li><%= link_to(t(:'blacklight.search.per_page.label', :count => count).html_safe, params_for_search(params.merge(:per_page => count))) %></li>
+         <%- end -%>
+       </ul>
+     </li>",You are not passing in a `:params` key here.
+7688,"@@ -79,6 +79,7 @@ func (i *Initializer) prepareHostNetwork() error {
+ // prepareOVSBridge adds local port and uplink to ovs bridge.
+ // This function will delete OVS bridge and HNS network created by antrea on failure.
+ func (i *Initializer) prepareOVSBridge() error {
++	klog.Info(""preparing ovs bridge ..."")
+ 	hnsNetwork, err := hcsshim.GetHNSNetworkByName(util.LocalHNSNetwork)
+ 	defer func() {
+ 		// prepareOVSBridge only works on windows platform. The operation has a chance to fail on the first time agent","Probably change ""ovs"" to ""OVS""."
+7689,"@@ -87,7 +87,9 @@ abstract class BaseMediaAdmin extends AbstractAdmin
+             $this->getRequest()->query->set('provider', $provider);
+         }
+
+-        $categoryId = $this->getRequest()->get('category');
++        $uniqueId = $this->getRequest()->get('uniqid');
++        $formParams =  $this->getRequest()->get($uniqueId);
++        $categoryId = $formParams && array_key_exists('category', $formParams) ? $formParams['category'] : $this->getRequest()->get('category');
+
+         if (null !== $this->categoryManager && !$categoryId) {
+             $categoryId = $this->categoryManager->getRootCategory($context)->getId();",Please linebreak this
+7690,"@@ -21,7 +21,7 @@ namespace Nethermind.Blockchain.Data
+ {
+     public class EmptyLocalDataSource<T> : ILocalDataSource<T>
+     {
+-        public T Data { get; } = default;
+-        public event EventHandler Changed;
++        public T? Data { get; }
++        public event EventHandler? Changed;
+     }
+ }","`= default` is implied here, so having it is redundant. Is it a stylistic choice to include it, or just an oversight?"
+7691,"@@ -226,7 +226,7 @@ type wsPipelineReader interface {
+ 	wsPipelineManifestReader
+ }
+
+-type wsProjectManager interface {
++type wsAppManager interface {
+ 	Create(projectName string) error
+ 	Summary() (*workspace.Summary, error)
+ }",Maybe it's time to fix the param name for this interface?
+7692,"@@ -232,9 +232,6 @@ type (
+ 		CancelRequestId                        string
+ 		StickyTaskQueue                        string
+ 		StickyScheduleToStartTimeout           *time.Duration
+-		ClientLibraryVersion                   string
+-		ClientFeatureVersion                   string
+-		ClientImpl                             string
+ 		AutoResetPoints                        *workflowpb.ResetPoints
+ 		Memo                                   map[string]*commonpb.Payload
+ 		SearchAttributes                       map[string]*commonpb.Payload","Why are we removing it? Looks like useful info. Obviously, field names should change."
+7693,"@@ -49,12 +49,18 @@ namespace NLog.LayoutRenderers
+         private const int MaxInitialRenderBufferLength = 16384;
+         private int _maxRenderedLength;
+         private bool _isInitialized;
++        private IValueFormatter _valueFormatter;
+
+         /// <summary>
+         /// Gets the logging configuration this target is part of.
+         /// </summary>
+         protected LoggingConfiguration LoggingConfiguration { get; private set; }
+
++        /// <summary>
++        /// Value formatter
++        /// </summary>
++        protected IValueFormatter ValueFormatter => _valueFormatter ?? (_valueFormatter = Resolve<IValueFormatter>());
++
+         /// <summary>
+         /// Returns a <see cref=""System.String""/> that represents this instance.
+         /// </summary>",Missing fallback to MessageTemplates.ValueFormatter.Instance
+7694,"@@ -1193,7 +1193,7 @@ class _Frame(object):
+
+     # TODO: by argument only support the grouping name and as_index only for now. Documentation
+     # should be updated when it's supported.
+-    def groupby(self, by, as_index: bool = True):
++    def groupby(self, by, axis=0, as_index: bool = True):
+         """"""
+         Group DataFrame or Series using a Series of columns.
+ ","The parameter in the docstring should be fixed too. Actually, why don't you try to implement the other axis? It wouldn't be impossible to do if we use pandas UDF from a cursory look. We have enough time before the next release currently."
+7695,"@@ -16,11 +16,13 @@ package patch
+
+ import (
+ 	""context""
++	""fmt""
+ 	""os""
+ 	""time""
+
+-	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/cloud.google.com/go/osconfig/apiv1alpha1""
+-	osconfigpb ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/google.golang.org/genproto/googleapis/cloud/osconfig/v1alpha1""
++	""cloud.google.com/go/compute/metadata""
++	osconfig ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/cloud.google.com/go/osconfig/apiv1alpha1""
++	api ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/google.golang.org/genproto/googleapis/cloud/osconfig/v1alpha1""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/config""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/logger""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/tasker""",This also runs a patch if its in the middle of one.
+7696,"@@ -248,7 +248,7 @@ func (task *Task) UpdateMountPoints(cont *Container, vols map[string]string) {
+ // there was no change
+ // Invariant: task known status is the minimum of container known status
+ func (task *Task) updateTaskKnownStatus() (newStatus TaskStatus) {
+-	seelog.Debug(""Updating task: %s"", task.String())
++	seelog.Debugf(""Updating task: %s"", task.String())
+
+ 	// Set to a large 'impossible' status that can't be the min
+ 	earliestStatus := ContainerZombie",Could we rename this method to `updateKnownStatus` ?
+7697,"@@ -76,6 +76,12 @@ namespace Datadog.Trace
+                                 Tracer.Sampler?.GetSamplingPriority(RootSpan);
+                         }
+                     }
++
++                    // set the origin tag to the root span of each trace/subtrace
++                    if (span.Context.Origin != null)
++                    {
++                        span.SetTag(Tags.Origin, span.Context.Origin);
++                    }
+                 }
+
+                 _spans.Add(span);","Maybe it would make sense to move that to DecorateRootSpan? Currently it only has Azure stuff, but given the name of the method I feel like it would be semantically appropriate"
+7698,"@@ -5,13 +5,14 @@ import (
+ 	""sync""
+
+ 	""github.com/pkg/errors""
+-	coreapi ""k8s.io/api/core/v1""
+-	extnapi ""k8s.io/api/extensions/v1beta1""
+-	networkingv1 ""k8s.io/api/networking/v1""
+-
+ 	""github.com/weaveworks/weave/common""
+ 	""github.com/weaveworks/weave/net/ipset""
+ 	""github.com/weaveworks/weave/npc/iptables""
++	coreapi ""k8s.io/api/core/v1""
++	extnapi ""k8s.io/api/extensions/v1beta1""
++	networkingv1 ""k8s.io/api/networking/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/client-go/kubernetes""
+ )
+
+ type NetworkPolicyController interface {",nit: these imports were in a separate group to ones from this repo
+7699,"@@ -22,4 +22,12 @@ public enum DispatchMethod {
+   public static boolean isPollMethodEnabled(String dispatchMethod) {
+     return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.POLL;
+   }
++
++  public static boolean isPushMethodEnabled(String dispatchMethod) {
++    return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.PUSH;
++  }
++
++  public static boolean isPushContainerizedMethodEnabled(String dispatchMethod) {
++    return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.PUSH_CONTAINERIZED;
++  }
+ }",Is it possible to rename the methods to `isXXXMethod` to keep the usage by the caller generic? The caller could use the result of these methods to verify whether a feature is enabled or to validate an input value for example.
+7700,"@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
+ exports.rmDir = function(path) {
+   return new promise.Promise(function(fulfill, reject) {
+     var numAttempts = 0;
++    var maxAttempts = 5;
++    var attemptTimeout = 250;
+     attemptRm();
+     function attemptRm() {
+       numAttempts += 1;
+       rimraf(path, function(err) {
+         if (err) {
+-          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+-            attemptRm();
++          if (err.code === 'ENOTEMPTY' && numAttempts <= maxAttempts) {
++            setTimeout(attemptRm, attemptTimeout);
+             return;
+           }
+           reject(err);",Don't penalize everyone with 250ms delay b/c some machines have problems.
+7701,"@@ -130,7 +130,11 @@ public final class UserUtils {
+             // Match!
+             // reparse the config file
+             log.info(""Modification detected, reloading config file "" + filename);
+-            configFileMap.get(filename).parseConfigFile();
++            try {
++              configFileMap.get(filename).parseConfigFile();
++            } catch (Exception e) {
++              log.error(""Failed parsing config file after update: "" + filename, e);
++            }
+             break;
+           }
+         }","This try-catch should be here so that watcher thread doesn't just exit in case of an exception. This change alone would probably be enough to fix the error as well, assuming that there's another `ENTRY_MODIFY` event when the file write is finalized. But of course not a perfect fix because it doesn't protect against possibly reading a non-empty but only partially written file?"
+7702,"@@ -417,6 +417,9 @@ func (s *Server) sendInternalMsg(sub, rply string, si *ServerInfo, msg interface
+
+ // Locked version of checking if events system running. Also checks server.
+ func (s *Server) eventsRunning() bool {
++	if s == nil {
++		return false
++	}
+ 	s.mu.Lock()
+ 	er := s.running && s.eventsEnabled()
+ 	s.mu.Unlock()",Weird that we have to check for `s == nil` here.. I would instead have fixed the call stack to find out when this gets invoked with a nil server.
+7703,"@@ -228,7 +228,7 @@ export default Controller.extend({
+         if (erroredEmails.length > 0) {
+             invitationsString = erroredEmails.length > 1 ? ' invitations: ' : ' invitation: ';
+             message = `Failed to send ${erroredEmails.length} ${invitationsString}`;
+-            message += erroredEmails.join(', ');
++            message += Ember.Handlebars.Utils.escapeExpression(erroredEmails.join(', '));
+             message += '. Please check your email configuration, see <a href=\'https://docs.ghost.org/docs/mail-config\' target=\'_blank\'>https://docs.ghost.org/v1.0.0/docs/mail-config</a> for instructions';
+
+             message = htmlSafe(message);",The `import` statement for `Ember` is missing in this file.
+7704,"@@ -90,7 +90,7 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			let s = c._nextState || c.state;
+ 			if (newType.getDerivedStateFromProps!=null) {
+ 				oldState = assign({}, c.state);
+-				if (s===c.state) s = assign({}, s);
++				if (s===c.state) s = c._nextState = assign({}, s);
+ 				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
+ 			}
+ ",Awesome :tada: I'd love to have a test case for this so that we don't regress on this feature in any future refactorings :+1:
+7705,"@@ -28,7 +28,7 @@ class SeriesDateTimeTest(ReusedSQLTestCase, SQLTestUtils):
+
+     @property
+     def pdf1(self):
+-        date1 = pd.Series(pd.date_range('2012-1-1 12:00:00', periods=3, freq='M'))
++        date1 = pd.Series(pd.date_range('2012-1-1 12:45:31', periods=3, freq='M'))
+         date2 = pd.Series(pd.date_range('2013-3-11 21:45:00', periods=3, freq='W'))
+         return pd.DataFrame(dict(start_date=date1, end_date=date2))
+ ",For testing some of the rounding functions
+7706,"@@ -56,6 +56,10 @@ class CurrencyDataFixture extends AbstractReferenceFixture
+          * @see \Shopsys\FrameworkBundle\Migrations\Version20180603135342
+          */
+         $currencyCzk = $this->currencyFacade->getById(1);
++        $currencyData = $this->currencyDataFactory->createFromCurrency($currencyCzk);
++        $currencyData->minFractionDigits = Currency::DEFAULT_MIN_FRACTION_DIGITS;
++        $currencyData->roundingType = Currency::ROUNDING_TYPE_INTEGER;
++        $currencyCzk = $this->currencyFacade->edit($currencyCzk->getId(), $currencyData);
+         $this->addReference(self::CURRENCY_CZK, $currencyCzk);
+
+         if (count($this->domain->getAll()) > 1) {",This should be present in UPGRADE notes. Also on currently running projects you should suggest users to update these settings.
+7707,"@@ -1053,10 +1053,9 @@ func (bdl *backpressureDiskLimiter) reserveBytes(
+ 	if count < 0 {
+ 		return count, nil
+ 	}
+-	// We calculate the total free bytes by adding the reported free bytes and
+-	// the non-`tracker` used bytes.
+-	tracker.updateFree(freeBytes + bdl.overallByteTracker.used -
+-		tracker.usedResources())
++	// TODO: verify there's not any other kind of bytes we care about
++	// subtracting too.
++	tracker.updateFree(freeBytes)
+
+ 	count = tracker.tryReserve(blockBytes)
+ 	if count < 0 {","Are you sure you want to do this? This will affect the working set block cache too, such that it'll now be tracking global free space. It throws off the fraction calculation."
+7708,"@@ -44,6 +44,7 @@ bool CompoundReaderListener::hasReaderAttached(){
+ 	return false;
+ }
+ ReaderListener* CompoundReaderListener::getAttachedListener(){
++	std::lock_guard<std::mutex> lock(attached_listener_mutex);
+ 	if(attached_listener != nullptr)
+ 		return attached_listener;
+ 	return nullptr;",Why would the read access need to be mutexed? The caller might still get a wrong answer since the value might change immediately after the mutex is unlocked before the caller receives the value.
+7709,"@@ -631,6 +631,16 @@ class TabbedBrowser(tabwidget.TabWidget):
+         if config.val.tabs.tabs_are_windows:
+             self.window().setWindowIcon(icon)
+
++    @pyqtSlot(usertypes.KeyMode)
++    def on_mode_entered(self, mode):
++        """"""Save input mode when tabs.mode_on_change = restore.""""""
++        input_modes = [usertypes.KeyMode.insert, usertypes.KeyMode.passthrough]
++        if (mode in input_modes and
++                config.val.tabs.mode_on_change == 'restore'):
++            tab = self.currentWidget()
++            if tab and tab is not None:
++                tab.data.input_mode = mode
++
+     @pyqtSlot(usertypes.KeyMode)
+     def on_mode_left(self, mode):
+         """"""Give focus to current tab if command mode was left.""""""",This fits on one line without the parentheses :wink:
+7710,"@@ -64,7 +64,7 @@ public class TestCloudRecovery extends SolrCloudTestCase {
+
+   @Before
+   public void beforeTest() throws Exception {
+-    configureCluster(2)
++    configureCluster(4)
+         .addConfig(""config"", TEST_PATH().resolve(""configsets"").resolve(""cloud-minimal"").resolve(""conf""))
+         .configure();
+ ",Looks like `TestCloudRecovery` changes are unrelated?
+7711,"@@ -10,16 +10,14 @@ declare(strict_types = 1);
+ namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute;
+
+ use Doctrine\DBAL\Connection;
++use Doctrine\DBAL\DBALException;
+ use Ergonode\Attribute\Domain\Event\Attribute\AttributeHintChangedEvent;
+ use Ergonode\Core\Domain\Entity\AbstractId;
+-use Ergonode\EventSourcing\Infrastructure\DomainEventInterface;
+-use Ergonode\EventSourcing\Infrastructure\Exception\UnsupportedEventException;
+-use Ergonode\EventSourcing\Infrastructure\Projector\DomainEventProjectorInterface;
+ use Ramsey\Uuid\Uuid;
+
+ /**
+  */
+-class AttributeHintChangedEventProjector implements DomainEventProjectorInterface
++class AttributeHintChangedEventProjector
+ {
+     private const TABLE = 'value_translation';
+ ",Try to separate it to different methods. Invoke is huge :)
+7712,"@@ -16,7 +16,7 @@
+           </thead>
+           <tbody>
+             <% scope.each do |plan| %>
+-              <tr>
++              <tr id=""<%= dom_id(plan) %>"">
+                 <td>
+                   <%= link_to ""#{plan.title.length > 60 ? ""#{plan.title[0..59]} ..."" : plan.title}"",
+                       plan_path(plan) %>",Looks like another spot that would benefit from `truncate`
+7713,"@@ -272,7 +272,7 @@ static mrb_value build_constants(mrb_state *mrb, const char *server_name, size_t
+             mrb_ary_set(mrb, ary, i, lit);
+         }
+         for (; i != H2O_MAX_TOKENS * 2; ++i) {
+-            const h2o_token_t *token = h2o__tokens + i - H2O_MAX_TOKENS;
++            const h2o_token_t *token = h2o__tokens + (i - H2O_MAX_TOKENS);
+             mrb_value lit = mrb_nil_value();
+             if (token == H2O_TOKEN_CONTENT_TYPE) {
+                 lit = mrb_str_new_lit(mrb, ""CONTENT_TYPE"");","This change is not related to what this PR wanted to fix, but undefined behavior sanitizer warns without this parenthesis because `h2o__tokens + i` overflows."
+7714,"@@ -223,7 +223,7 @@ class DocstringParameterChecker(BaseChecker):
+
+         # skip functions that match the 'no-docstring-rgx' config option
+         no_docstring_rgx = get_global_option(self, ""no-docstring-rgx"")
+-        if no_docstring_rgx and re.match(no_docstring_rgx, node.name):
++        if no_docstring_rgx.pattern and re.match(no_docstring_rgx, node.name):
+             return
+
+         # skip functions smaller than 'docstring-min-length'","This is actually incorrect and should be the other way around. Going to fix this tomorrow. If `no_docstring_rgx == re.compile("""")` no function should be checked, since every function matches the pattern. If `no_docstring_rgx == re.compile(""^$"")` all functions should be checked."
+7715,"@@ -95,7 +95,7 @@ def get_spotify_oauth():
+     """"""
+     client_id = current_app.config['SPOTIFY_CLIENT_ID']
+     client_secret = current_app.config['SPOTIFY_CLIENT_SECRET']
+-    scope = 'user-read-recently-played'
++    scope = 'user-read-recently-played user-read-currently-playing'
+     redirect_url = current_app.config['SPOTIFY_CALLBACK_URL']
+     return spotipy.oauth2.SpotifyOAuth(client_id, client_secret, redirect_uri=redirect_url, scope=scope)
+ ",Should this be in a config file?
+7716,"@@ -3,13 +3,15 @@ const {
+   eachAsync,
+   executeLegacyOperation,
+   makeInterruptibleAsyncInterval,
+-  BufferPool
++  BufferPool,
++  shuffle
+ } = require('../../src/utils');
+ const { expect } = require('chai');
+ const sinon = require('sinon');
++const { MongoRuntimeError } = require('../../src/error');
+
+-describe('utils', function () {
+-  context('eachAsync', function () {
++describe('driver utils', function () {
++  context('eachAsync function', function () {
+     it('should callback with an error', function (done) {
+       eachAsync(
+         [{ error: false }, { error: true }],","purely preference, but have you considered using parentheses to indicate that a method is being tested? e.g., `describe('eachAsync()')`"
+7717,"@@ -449,9 +449,10 @@ ResultCode RocksEngine::createCheckpoint(const std::string& name) {
+     auto checkpointPath = folly::stringPrintf(""%s/checkpoints/%s/data"",
+                                               dataPath_.c_str(), name.c_str());
+     LOG(INFO) << ""Target checkpoint path : "" << checkpointPath;
+-    if (fs::FileUtils::exist(checkpointPath)) {
+-        LOG(ERROR) << ""The snapshot file already exists: "" << checkpointPath;
+-        return ResultCode::ERR_CHECKPOINT_ERROR;
++    if (fs::FileUtils::exist(checkpointPath) &&
++        !fs::FileUtils::remove(checkpointPath.data(), true)) {
++            LOG(ERROR) << ""Remove exist dir failed of checkpoint : "" << checkpointPath;
++            return ResultCode::ERR_IO_ERROR;
+     }
+
+     auto parent = checkpointPath.substr(0, checkpointPath.rfind('/'));",Why not return success?
+7718,"@@ -3,12 +3,19 @@ namespace Psalm\Report;
+
+ use Psalm\Config;
+ use Psalm\Internal\Analyzer\DataFlowNodeData;
++use Psalm\Internal\Analyzer\IssueData;
+ use Psalm\Report;
+
++use function get_cfg_var;
++use function ini_get;
++use function strtr;
+ use function substr;
+
+ class ConsoleReport extends Report
+ {
++    /** @var string|null */
++    private $linkFormat;
++
+     public function create(): string
+     {
+         $output = '';",Please use snake_case for properties to keep it consistent with the rest of the codebase.
+7719,"@@ -304,7 +304,9 @@ func New(ctx context.Context, signer beecrypto.Signer, networkID uint64, overlay
+ 		}
+
+ 		s.metrics.HandledStreamCount.Inc()
+-		s.logger.Infof(""successfully connected to peer (inbound) %s"", i.BzzAddress.ShortString())
++		s.logger.Debugf(""successfully connected to peer (inbound) %s"", i.BzzAddress.ShortString())
++		s.logger.Infof(""successfully connected to peer (inbound)"")
++
+ 	})
+
+ 	h.Network().SetConnHandler(func(_ network.Conn) {",i don't understand why we need this change. what information is this providing when running in less than Debug loglevel? I prefer to revert this
+7720,"@@ -170,6 +170,9 @@ public class ExecutionFlowDaoTest {
+     final List<ExecutableFlow> flows = this.executionFlowDao
+         .fetchRecentlyFinishedFlows(RECENTLY_FINISHED_LIFETIME);
+     assertThat(flows.size()).isEqualTo(0);
++
++    //Restore the clock
++    DateTimeUtils.setCurrentMillisOffset(0);
+   }
+
+   @Test","Oh, so this test leaks DateTimeUtils offset? It would be safer to place the reset in an `@After` method to not cause side effects even if the test case fails."
+7721,"@@ -28,14 +28,6 @@ import { Grid, Cell, Row } from '../../../../../material-components';
+ import Pagination from './Pagination';
+
+ export default function Footer( { tab, footerText } ) {
+-	if ( ! footerText ) {
+-		return (
+-			<div className=""googlesitekit-idea-hub__footer"">
+-				<Pagination tab={ tab } />
+-			</div>
+-		);
+-	}
+-
+ 	return (
+ 		<Grid className=""googlesitekit-idea-hub__footer"">
+ 			<Row>","Kind of a nit-pick, but is there no way to solve this while still not rendering an empty div if `footerText` is empty? We could still use the `Row` to maintain the same layout but then only render the `Cell` for the pagination - I think it's possible to use specific classes to horizontally offset?"
+7722,"@@ -23,12 +23,14 @@ import java.util.Objects;
+ public class DomainChangeMessage {
+
+     // Represent the changed object type
+-    enum ObjectType {
++    public enum ObjectType {
+         DOMAIN,
+-        ROLE,
++        ROLE,
++        GROUP,
+         POLICY,
+-        SERVICE,
+-        ENTITY
++        SERVICE,
++        ENTITY,
++        TEMPLATE
+     }
+
+     private String domainName;","Template is also not an object type so I don't expect to notify on templates. Instead when applying templates, we'll be updating roles/policies/services/groups."
+7723,"@@ -93,7 +93,8 @@ class iloc(Accessor):
+         rows, cols = index
+         if rows is Ellipsis:
+             rows = slice(None)
+-        data = dataset.interface.iloc(dataset.dataset, (rows, cols))
++
++        data = dataset.interface.iloc(dataset, (rows, cols))
+         kdims = dataset.kdims
+         vdims = dataset.vdims
+         if np.isscalar(data):",Had to fix this to get my tests passing (should have been a new PR sorry).
+7724,"@@ -91,6 +91,11 @@ type VaultIssuer struct {
+ 	Server string `json:""server""`
+ 	// Vault URL path to the certificate role
+ 	Path string `json:""path""`
++	// Base64 encoded CA bundle to validate Vault server certificate. Only used
++	// if the Server URL is using HTTPS protocol. This parameter is ignored for
++	// plain HTTP protocol connection. If not set the system root certificates
++	// are used to validate the TLS connection.
++	CABundle []byte `json:""caBundle""`
+ }
+
+ // Vault authentication  can be configured:","Small nit, and sorry for not spotting sooner.. this should have `omitempty` on it, else when marshalling nil values into json, it will be `caBundle: null` which trips up some JSON parsers"
+7725,"@@ -1030,6 +1030,9 @@ class GenericLayoutPlot(GenericCompositePlot):
+     displays the elements in a cartesian grid in scanline order.
+     """"""
+
++    transpose = param.Boolean(default=False, doc=""""""
++        Whether to transpose the layout when plotting"""""")
++
+     def __init__(self, layout, **params):
+         if not isinstance(layout, (NdLayout, Layout)):
+             raise ValueError(""GenericLayoutPlot only accepts Layout objects."")","Would be good to say the normal behavior is scanline order (left to right, top to bottom) and that transposing makes it work top to bottom and left to right."
+7726,"@@ -326,6 +326,17 @@ Photos folder"" option in your google drive settings. You can then copy
+ or move the photos locally and use the date the image was taken
+ (created) set as the modification date.`,
+ 			Advanced: true,
++		}, {
++			Name:    ""use_shared_date"",
++			Default: false,
++			Help: `Use date file was shared instead of modified date.
++
++Note that, as with ""--drive-use-created-date"", this flag may have
++unexpected consequences when uploading/downloading files.
++
++If both this flag and ""--drive-use-created-date"" are set, the created
++date is used.`,
++			Advanced: true,
+ 		}, {
+ 			Name:     ""list_chunk"",
+ 			Default:  1000,",Perhaps note here that `--drive-use-created-date` takes precedence if both set?
+7727,"@@ -128,7 +128,7 @@ class DynamicRoIHead(StandardRoIHead):
+         bbox_results.update(loss_bbox=loss_bbox)
+         return bbox_results
+
+-    def update_hyperparameters(self):
++    def update_hyperparameters(self, eps=1e-15):
+         """"""Update hyperparameters like IoU thresholds for assigner and beta for
+         SmoothL1 loss based on the training statistics.
+ ",Use EPS=1e-15 as that in atss_head or FCOS head.
+7728,"@@ -40,7 +40,7 @@ func TestBlobSaver(t *testing.T) {
+
+ 	tmb, ctx := tomb.WithContext(ctx)
+ 	saver := &saveFail{
+-		idx: repository.NewIndex(),
++		idx: repository.NewMasterIndex(),
+ 	}
+
+ 	b := NewBlobSaver(ctx, tmb, saver, uint(runtime.NumCPU()))",Is there a need to replace the Index with a MasterIndex?
+7729,"@@ -389,6 +389,7 @@ func TestExecCommandAgent(t *testing.T) {
+
+ 	verifyExecCmdAgentExpectedMounts(t, ctx, client, testTaskId, cid, testContainerName, testExecCmdHostBinDir)
+ 	pidA := verifyMockExecCommandAgentIsRunning(t, client, cid)
++	verifyExecAgentRunningStateChange(t, taskEngine)
+ 	seelog.Infof(""Verified mock ExecCommandAgent is running (pidA=%s)"", pidA)
+ 	killMockExecCommandAgent(t, client, cid, pidA)
+ 	seelog.Infof(""kill signal sent to ExecCommandAgent (pidA=%s)"", pidA)",are we adding stop state change in a different PR?
+7730,"@@ -23,9 +23,9 @@ class PlansController < ApplicationController
+     # Get all of the available funders and non-funder orgs
+     @funders = Org.funder
+                   .joins(:templates)
+-                  .where(templates: { published: true }).uniq.sort(&:name)
++                  .where(templates: { published: true }).uniq.sort_by(&:name)
+     @orgs = (Org.organisation + Org.institution + Org.managing_orgs).flatten
+-                                                                    .uniq.sort(&:name)
++                                                                    .uniq.sort_by(&:name)
+
+     # Get the current user's org
+     @default_org = current_user.org if @orgs.include?(current_user.org)",How much difference is there between sort and sort_by ?
+7731,"@@ -231,6 +231,7 @@ STATIC int opae_plugin_mgr_initialize_all(void)
+ 	int res;
+ 	opae_api_adapter_table *aptr;
+ 	int errors = 0;
++	int count = 0;
+
+ 	for (aptr = adapter_list; aptr; aptr = aptr->next) {
+ ",count doesn't seem to be used. Let's remove it.
+7732,"@@ -18,7 +18,11 @@ module Mongoid
+       #
+       # @since 4.0.0
+       def cache_table
+-        Thread.current[""[mongoid]:query_cache""] ||= {}
++        if defined?(Mongo::QueryCache)
++          Mongo::QueryCache.cache_table
++        else
++          Thread.current[""[mongoid]:query_cache""] ||= {}
++        end
+       end
+
+       # Clear the query cache.",Mongo is a hard dependency for Mongoid. Why do we need an if-statement to if it's defined? We should always use Mongo::QueryCache
+7733,"@@ -0,0 +1,6 @@
++class AddFunderAndOrgToPlans < ActiveRecord::Migration
++  def change
++    add_reference :plans, :org, foreign_key: true
++    add_column :plans, :funder_id, :integer, index: true
++  end
++end","Does this point out at a ROR funder id? If so, could we get rid of the `funder_name` field on the plan and just use the `name` of the funder with id `funder_id`?"
+7734,"@@ -3,8 +3,12 @@ var assert = require('assert');
+ var fs = require('fs');
+
+ var flatbuffers = require('../js/flatbuffers').flatbuffers;
++global.flatbuffers = flatbuffers;
++
+ var MyGame = require(process.argv[2]).MyGame;
+
++var isTsTest = process.env.FB_TS_TEST ? true : false;
++
+ function main() {
+
+   // First, let's test reading a FlatBuffer generated by C++ code:","Use !! to cast to bool, rather than the ternary bool antipattern."
+7735,"@@ -145,7 +145,7 @@ func (cmd CmdSnapshots) Execute(args []string) error {
+ 		tab.Rows = append(tab.Rows, []interface{}{sn.ID()[:plen/2], sn.Time.Format(TimeFormat), sn.Hostname, sn.Paths[0]})
+
+ 		if len(sn.Paths) > 1 {
+-			for _, path := range sn.Paths {
++			for _, path := range sn.Paths[1:] {
+ 				tab.Rows = append(tab.Rows, []interface{}{"""", """", """", path})
+ 			}
+ 		}",why is it in the list twice to begin with?
+7736,"@@ -890,6 +890,10 @@ void Player::sendPing()
+ 			return;
+ 		}
+
++		if (pzLocked) {
++			return;
++		}
++
+ 		if (!g_creatureEvents->playerLogout(this)) {
+ 			return;
+ 		}",This way you will **never** be kicked while monsters are around you.
+7737,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+7738,"@@ -110,5 +110,5 @@ export default function ModulesList( { moduleSlugs } ) {
+ }
+
+ ModulesList.propTypes = {
+-	moduleSlug: PropTypes.arrayOf( PropTypes.string ).isRequired,
++	moduleSlugs: PropTypes.arrayOf( PropTypes.string ).isRequired,
+ };","This just fixes an unrelated prop type error, correct?"
+7739,"@@ -1022,7 +1022,7 @@ func (fbo *folderBlockOps) updateWithDirtyEntriesLocked(ctx context.Context,
+ 	}
+
+ 	// Remove cached removals from the copy.
+-	for k := range dirCacheEntry.adds {
++	for k := range dirCacheEntry.dels {
+ 		_, ok := dblock.Children[k]
+ 		if !ok {
+ 			continue",This was a bug in KBFS-2071 -- oops.
+7740,"@@ -82,9 +82,18 @@ type PaymentChannel struct {
+ 	// payer and payee upon initialization or extension
+ 	AgreedEol *types.BlockHeight `json:""agreed_eol""`
+
++	// Conditions are the set of conditions for redeeming or closing the payment
++	// channel
++	Conditions *types.Predicate `json:""conditions""`
++
+ 	// Eol is the actual expiration for the payment channel which can differ from
+ 	// AgreedEol when the payment channel is in dispute
+ 	Eol *types.BlockHeight `json:""eol""`
++
++	// Redeemed is a flag indicating whether or not Redeem has been called on the
++	// payment channel yet. This is necessary because AmountRedeemed can still be
++	// zero in the event of a zero-value voucher
++	Redeemed bool `json:""redeemed""`
+ }
+
+ // Actor provides a mechanism for off chain payments.",// Condition is a condition for ... Condition
+7741,"@@ -207,6 +207,16 @@ describe ""National Capital Region proposals"" do
+       expect(current_path).to eq(""/proposals/#{work_order.proposal.id}"")
+     end
+
++    it ""does not resave unchanged requests"" do
++      visit ""/ncr/work_orders/#{work_order.id}/edit""
++      click_on 'Submit for approval'
++      visit ""/ncr/work_orders/#{work_order.id}/edit""
++      click_on 'Submit for approval'
++
++      expect(current_path).to eq(""/proposals/#{work_order.proposal.id}"")
++      expect(page).to have_content(""No changes were made to the request"")
++    end
++
+     it ""has a disabled field if first approval is done"" do
+       visit ""/ncr/work_orders/#{work_order.id}/edit""
+       expect(find(""[name=approver_email]"")[""disabled""]).to be_nil","Might be good to test that no emails were sent out, either. You should be able to use `deliveries` for this"
+7742,"@@ -80,7 +80,7 @@ public class Connection implements Closeable {
+       serialized.put(""sessionId"", sessionId);
+     }
+
+-    LOG.info(JSON.toJson(serialized.build()));
++    LOG.finest(JSON.toJson(serialized.build()));
+     socket.sendText(JSON.toJson(serialized.build()));
+
+     if (!command.getSendsResponse() ) {",Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier.
+7743,"@@ -17,6 +17,11 @@ namespace UpdateVendors
+ //------------------------------------------------------------------------------
+ "";
+
++        private static readonly List<string> FilesToSkip = new List<string>()
++        {
++            @""\Serilog\Events\LogEventLevel.cs"",
++        };
++
+         private static readonly string DownloadDirectory = Path.Combine(Environment.CurrentDirectory, ""downloads"");
+         private static string _vendorProjectDirectory;
+ ",Is this new list being consumed yet?
+7744,"@@ -18,18 +18,14 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""io""
+-	weakrand ""math/rand""
+ 	""net""
+ 	""net/http""
+ 	""strconv""
+-	""time""
+
+ 	""github.com/caddyserver/caddy/v2""
+ )
+
+ func init() {
+-	weakrand.Seed(time.Now().UnixNano())
+-
+ 	caddy.RegisterModule(tlsPlaceholderWrapper{})
+ }
+ ",moved to `errors.go` which is the only places `math/rand` is used in this package
+7745,"@@ -3,8 +3,8 @@
+ namespace Shopsys\FrameworkBundle\Component\Error;
+
+ use AppKernel;
+-use Shopsys\Environment;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
++use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
+ use Shopsys\FrameworkBundle\Component\Router\DomainRouterFactory;
+ use Symfony\Component\Filesystem\Filesystem;
+ use Symfony\Component\HttpFoundation\Request;","This use is wrong, corrent is: `Shopsys\FrameworkBundle\Component\Environment` It is the same in classes below"
+7746,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression."
+7747,"@@ -323,11 +323,6 @@ func updateContainerMetadata(metadata *dockerapi.DockerContainerMetadata, contai
+ 		container.SetLabels(metadata.Labels)
+ 	}
+
+-	// Update Volume
+-	if metadata.Volumes != nil {
+-		task.UpdateMountPoints(container, metadata.Volumes)
+-	}
+-
+ 	// Set Exitcode if it's not set
+ 	if metadata.ExitCode != nil {
+ 		container.SetKnownExitCode(metadata.ExitCode)","For my understanding, why was this removed?"
+7748,"@@ -36,14 +36,13 @@ namespace Nethermind.Runner
+         protected override (CommandLineApplication, Func<IConfigProvider>, Func<string>) BuildCommandLineApp()
+         {
+             string pluginsDirectory = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""plugins"");
+-            Console.WriteLine($""Loading plugins from: {pluginsDirectory}"");
+             if (Directory.Exists(pluginsDirectory))
+             {
+                 var plugins = Directory.GetFiles(pluginsDirectory, ""*.dll"");
+                 foreach (string plugin in plugins)
+                 {
+-                    Console.WriteLine($""Loading plugin {plugin} from {pluginsDirectory}"");
+                     string pluginName = plugin.Contains(""/"") ? plugin.Split(""/"").Last() : plugin.Split(""\\"").Last();
++                    Console.WriteLine($""Loading plugin: {pluginName}"");
+                     AssemblyLoadContext.Default.LoadFromAssemblyPath(plugin);
+                 }
+             }",the whole idea was to display information on the plugin directory in case it was missing - need to add if...else... and display the plugin dir if it is configured (non empty) but cannot be found
+7749,"@@ -154,6 +154,11 @@ public class LoginActivity extends BaseActivity implements CustomTabActivityHelp
+             loginView.requestFocus();
+             return;
+         }
++        if (TextUtils.isEmpty(password)) {
++            Toast.makeText(this, getString(R.string.error_field_required), Toast.LENGTH_SHORT).show();
++            passwordView.requestFocus();
++            return;
++        }
+         if (!(password.length() >= 6)) {
+             passwordView.setError(getString(R.string.error_invalid_password));
+             passwordView.requestFocus();","Can you please set this as an error on the password view, rather than a toast, just to make sure that it is kept consistent. Check out a couple of lines below."
+7750,"@@ -114,7 +114,7 @@ func consumerConnectFlow(t *testing.T, tequilapi *tequilapi_client.Client, consu
+ 	})
+ 	assert.NoError(t, err)
+
+-	connectionStatus, err = tequilapi.Connect(consumerID, proposal.ProviderID, endpoints.ConnectOptions{true})
++	connectionStatus, err = tequilapi.Connect(consumerID, proposal.ProviderID, ""openvpn"", endpoints.ConnectOptions{true})
+ 	assert.NoError(t, err)
+
+ 	err = waitForCondition(func() (bool, error) {",Shouldn't we pass here a proposal too?
+7751,"@@ -85,5 +85,11 @@ def test_dupe_solid_repo_definition():
+         },
+     )
+
+-    with pytest.raises(DagsterInvalidDefinitionError):
++    with pytest.raises(DagsterInvalidDefinitionError) as exc_info:
+         repo.get_all_pipelines()
++
++    assert str(exc_info.value) == (
++        'You have defined two solids named ""same"" in repository ""error_repo"". '
++        'Solid names must be unique within a repository. The solid has been defined '
++        'in pipeline ""first"" and it has been defined again in pipeline ""second.""'
++    )","im not a huge fan of exact text match in these tests, not sure what a good solution is that solves the same problem"
+7752,"@@ -182,6 +182,13 @@ func (s *server) setupRouting() {
+ 		})),
+ 	)
+
++	handle(""/stamps/topup/{id}/{amount}"", web.ChainHandlers(
++		s.gatewayModeForbidEndpointHandler,
++		web.FinalHandler(jsonhttp.MethodHandler{
++			""PATCH"": http.HandlerFunc(s.postageTopUpHandler),
++		})),
++	)
++
+ 	handle(""/stewardship/{address}"", jsonhttp.MethodHandler{
+ 		""PUT"": web.ChainHandlers(
+ 			s.gatewayModeForbidEndpointHandler,",this should _not_ be in the api. all postage APIs have moved to the debugAPI
+7753,"@@ -51,9 +51,13 @@ def _path_hash(path, transform, kwargs):
+     return digest_string(srcinfo)
+
+ def _is_internal_node(node):
+-    # at least one of an internal nodes children are dicts
+-    # some (group args) may not be dicts
+-    return any(isinstance(x, dict) for x in itervalues(node))
++    return not _is_leaf_node(node)
++
++def _is_leaf_node(node):
++    """"""
++    A leaf node either has no children or defines a `file` key
++    """"""
++    return not node or node.get(RESERVED['file'])
+
+ def _pythonize_name(name):
+     safename = re.sub('[^A-Za-z0-9]+', '_', name).strip('_')","Including both functions seems like overkill for this PR since only _is_internal_node is ever used. Keep them if you think they'll both be used in the future, but if not, the code will be easier to read if you collapse the logic into a single function."
+7754,"@@ -41,7 +41,7 @@ func GenerateTestCertificate(path string, certFileName string, keyFileName strin
+ 		SerialNumber:          big.NewInt(1234),
+ 		Subject: pkix.Name{
+ 			Country:      []string{""test""},
+-			Organization: []string{""testor""},
++			Organization: []string{""tester""},
+ 		},
+ 		DNSNames:    []string{""localhost""},
+ 		NotBefore:   time.Now(),",It seems that the two words mean the same thing.
+7755,"@@ -271,13 +271,13 @@ void RaftPart::start(std::vector<HostAddr>&& peers, bool asLearner) {
+
+     lastLogId_ = wal_->lastLogId();
+     lastLogTerm_ = wal_->lastLogTerm();
++    term_ = proposedTerm_ = lastLogTerm_;
+
+     // Set the quorum number
+     quorum_ = (peers.size() + 1) / 2;
+
+     auto logIdAndTerm = lastCommittedLogId();
+     committedLogId_ = logIdAndTerm.first;
+-    term_ = proposedTerm_ = logIdAndTerm.second;
+
+     if (lastLogId_ < committedLogId_) {
+         LOG(INFO) << idStr_ << ""Reset lastLogId "" << lastLogId_","Do we need to set lastLogTerm_ to committedLogTerm when `lastLogId_ < committedLogId_`, on line 286"
+7756,"@@ -160,7 +160,8 @@ public class TestAllDictionaries extends LuceneTestCase {
+           try {
+             Dictionary dic = loadDictionary(aff);
+             totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
+-            totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
++            totalWords.addAndGet(
++                RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes));
+             System.out.println(aff + ""\t"" + memoryUsageSummary(dic));
+           } catch (Throwable e) {
+             failures.add(aff);","About ~7% memory usage increase on average, at most 512KB"
+7757,"@@ -32,6 +32,11 @@ type Response struct {
+ type ResponseWriter interface {
+ 	io.Writer
+
++	// Options for the request/response that this ResponseWriter is attached to.
++	Options() Options
++	// TODO(abg) Options should not be attached to the ResponseWriter. Instead
++	// they should be part of the Handle interface.
++
+ 	// AddHeaders adds the given headers to the response. If called, this MUST
+ 	// be called before any invocation of Write().
+ 	//",Was this too big of a pain to do now?
+7758,"@@ -41,10 +41,10 @@ static train_result call_daal_kernel(const context_cpu& ctx,
+     const int64_t component_count = desc.get_component_count();
+
+     auto arr_data = row_accessor<const Float>{ data }.pull();
+-    array<Float> arr_eigvec{ column_count * component_count };
+-    array<Float> arr_eigval{ 1 * component_count };
+-    array<Float> arr_means{ 1 * component_count };
+-    array<Float> arr_vars{ 1 * component_count };
++    auto arr_eigvec = array<Float>::zeros(column_count * component_count);
++    auto arr_eigval = array<Float>::zeros(1 * component_count);
++    auto arr_means = array<Float>::zeros(1 * component_count);
++    auto arr_vars = array<Float>::zeros(1 * component_count);
+
+     // TODO: read-only access performed with deep copy of data since daal numeric tables are mutable.
+     // Need to create special immutable homogen table on daal interop side",Why need to spend time for initializing of array? when will we rewrite the contents anyway? This can take a lot of time in some algorithms. Especially if the filling is in sequential mode.
+7759,"@@ -0,0 +1,5 @@
++class AddResourcesToWorkshops < ActiveRecord::Migration
++  def change
++    add_column :workshops, :resources, :text, null: false, default: ''
++  end
++end","Can this be `null:false, default: ''` to avoid the nil vs blank issue?"
+7760,"@@ -0,0 +1,19 @@
++# frozen_string_literal: true
++
++test_name ""Set root/Administrator password to a known value"" do
++  extend Beaker::HostPrebuiltSteps
++
++  hosts.each do |host|
++    case host['platform']
++    when /windows/
++      on host, ""passwd #{ENV['WINRM_USER']}"", stdin: ENV['WINRM_PASSWORD']
++    when /osx/
++      # Our VMs default to PermitRootLogin prohibit-password
++      on host, 'echo ""PermitRootLogin yes"" >> /etc/ssh/sshd_config' if ENV['SSH_USER'] == 'root'
++      on host, ""dscl . -passwd /Users/#{ENV['SSH_USER']}"", stdin: ENV['SSH_PASSWORD']
++    else
++      # Some platforms support --stdin, but repeating it seems to work everywhere
++      on host, ""passwd #{ENV['SSH_USER']}"", stdin: ""#{ENV['SSH_PASSWORD']}\n#{ENV['SSH_PASSWORD']}""
++    end
++  end
++end",Had to add this to get macOS to work.
+7761,"@@ -0,0 +1,13 @@
++package azkaban.container;
++
++import org.junit.Rule;
++import org.junit.rules.TemporaryFolder;
++
++
++public class FlowContainerTestBase {
++
++  @Rule
++  public TemporaryFolder temporaryFolder = new TemporaryFolder();
++
++
++}",What is the usage of this class?
+7762,"@@ -144,7 +144,7 @@ public class DataFilesTable extends BaseMetadataTable {
+     @Override
+     public CloseableIterable<StructLike> rows() {
+       return CloseableIterable.transform(
+-          ManifestFiles.read(manifest, io).project(schema),
++          ManifestFiles.read(manifest, io, null, null).project(schema),
+           file -> (GenericDataFile) file);
+     }
+ ","Could we keep the original signatures as well, so we do not have to rewrite the method calls everywhere and add `null, null`? I think this could greatly reduce the changes needed in this patch"
+7763,"@@ -706,6 +706,7 @@ func (tds *TrieDbState) updateTrieRoots(forward bool) ([]common.Hash, error) {
+ 				if len(v) > 0 {
+ 					//fmt.Printf(""Update storage trie addrHash %x, keyHash %x: %x\n"", addrHash, keyHash, v)
+ 					if forward {
++						_ = ClearTombstonesForNewStorage(tds.db, cKey)
+ 						tds.t.Update(cKey, v)
+ 					} else {
+ 						// If rewinding, it might not be possible to execute storage item update.",Ideally this error should not be swallowed (can do in the next PR)
+7764,"@@ -212,9 +212,10 @@ def config():
+     global _registry_url
+     _registry_url = None
+
+-def _update_auth(team, refresh_token):
++def _update_auth(team, refresh_token, timeout=None):
+     response = requests.post(""%s/api/token"" % get_registry_url(team), data=dict(
+-        refresh_token=refresh_token
++        refresh_token=refresh_token,
++        timeout=timeout
+     ))
+
+     if response.status_code != requests.codes.ok:",Wait a minute... You're passing it as a POST parameter. There's no way that can work.
+7765,"@@ -259,6 +259,7 @@ func (w *Workflow) cleanup() {
+ 			w.LogWorkflowInfo(""Error returned from cleanup hook: %s"", err)
+ 		}
+ 	}
++	w.LogWorkflowInfo(""Workflow %q finished clean up."", w.Name)
+ }
+
+ func (w *Workflow) genName(n string) string {","minor: to be consistent with other logs, either use ""cleaning up"" (preferred) or ""cleanup""."
+7766,"@@ -23,6 +23,7 @@ PG_ASYNC_LISTEN_COMMIT = False
+ # Redis
+ REDIS_HOST = ""redis""
+ REDIS_PORT = 6379
++REDIS_NAMESPACE = ""listenbrainz""
+
+ # Influx DB (main listen store)
+ INFLUX_HOST    = ""influx""",Adding the config changes to the consul config template `consul_config.py.ctmpl` would be helpful too.
+7767,"@@ -56,7 +56,7 @@ import org.hibernate.validator.constraints.NotEmpty;
+ public class Dataverse extends DvObjectContainer {
+
+     public enum DataverseType {
+-        RESEARCHERS, RESEARCH_PROJECTS, JOURNALS, ORGANIZATIONS_INSTITUTIONS, TEACHING_COURSES, UNCATEGORIZED
++        RESEARCHERS, RESEARCH_PROJECTS, JOURNALS, ORGANIZATIONS_INSTITUTIONS, TEACHING_COURSES, UNCATEGORIZED, LABORATORY, RESEARCH_GROUP
+     };
+
+     private static final long serialVersionUID = 1L;",While we're at it should we add Department? See Dataverse Category: Add Department #2829
+7768,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.
+7769,"@@ -22,13 +22,14 @@ function detachedClone(vnode) {
+ 	if (vnode) {
+ 		vnode = assign({}, vnode);
+ 		vnode._component = null;
++		vnode._original = vnode;
+ 		vnode._children = vnode._children && vnode._children.map(detachedClone);
+ 	}
+ 	return vnode;
+ }
+
+ // having custom inheritance instead of a class here saves a lot of bytes
+-export function Suspense(props) {
++export function Suspense() {
+ 	// we do not call super here to golf some bytes...
+ 	this._pendingSuspensionCount = 0;
+ 	this._suspenders = null;",TODO: check whether this is needed or not
+7770,"@@ -48,8 +48,12 @@ type Config struct {
+ 	Aliases  map[string]string `yaml:""aliases""`
+ }
+
+-// ReadConfig represents the current config read from local
+-var ReadConfig Config
++var (
++	// ReadConfig represents the current config read from local
++	ReadConfig Config
++	// IsInsecure represents the connect option of grpc dial
++	IsInsecure bool
++)
+
+ func init() {
+ 	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl/default""",`ReadConfig` is a global variable (from `gochecknoglobals`)
+7771,"@@ -12,6 +12,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ //
++//go:build !cgo
+ // +build !cgo
+
+ package ptrace",This is duplicated with `+build !cgo`?
+7772,"@@ -34,7 +34,7 @@ module Selenium
+           driver.manage.timeouts.implicit_wait = 6
+
+           driver.find_element(id: 'adder').click
+-          driver.find_element(id: 'box0')
++          expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError)
+         end
+
+         it 'should still fail to find an element with implicit waits enabled' do",This should just be `.not_to raise_error` otherwise it potentially hides errors
+7773,"@@ -164,13 +164,17 @@ class DataFrame(_Frame):
+         else:
+             self._metadata = metadata
+
+-    def _reduce_for_stat_function(self, sfun):
++    def _reduce_for_stat_function(self, sfun, numeric_only=False):
+         """"""
+         Applies sfun to each column and returns a pd.Series where the number of rows equal the
+         number of columns.
+
+-        :param sfun: either an 1-arg function that takes a Column and returns a Column, or
++        Parameters
++        ----------
++        sfun : either an 1-arg function that takes a Column and returns a Column, or
+         a 2-arg function that takes a Column and its DataType and returns a Column.
++        numeric_only : boolean, default False
++            If True, sfun is applied on numeric columns (including booleans) only.
+         """"""
+         from inspect import signature
+         exprs = []",Line 175 needs to be indented so that it's under `sfun`.
+7774,"@@ -21,12 +21,16 @@ namespace Nethermind.Blockchain.Filters.Topics
+ {
+     public class AnyTopic : TopicExpression
+     {
+-        public static readonly AnyTopic Instance = new();
++        public static readonly AnyTopic Instance = new();
++
++        private AnyTopic() { }
+
+         public override bool Accepts(Keccak topic) => true;
+         public override bool Accepts(ref KeccakStructRef topic) => true;
+
+         public override bool Matches(Bloom bloom) => true;
+         public override bool Matches(ref BloomStructRef bloom) => true;
++
++        public override string ToString() => ""null"";
+     }
+ }",It looks strange a bit. What is the reason?
+7775,"@@ -9,13 +9,17 @@ import java.nio.file.Path;
+ import java.nio.file.PathMatcher;
+ import java.util.Optional;
+
+-import static com.github.javaparser.StaticJavaParser.parse;
++import static com.github.javaparser.StaticJavaParser.parse;import org.apache.log4j.Logger;
++
+
+ /**
+  * A strategy for discovering the structure of a project.
+  * Implementations could read a pom.xml, a Gradle build file, a makefile...
+  */
+-public interface CollectionStrategy {
++public interface CollectionStrategy {
++    protected static Logger LOG = Logger.getLogger(CollectionStrategy.class.getName());
++
++
+
+     ProjectRoot collect(Path path);
+ ",Is this one of those `LexicalPreservingPrinter` issues?
+7776,"@@ -61,6 +61,12 @@ func prettify(v reflect.Value, indent int, buf *bytes.Buffer) {
+
+ 		buf.WriteString(""\n"" + strings.Repeat("" "", indent) + ""}"")
+ 	case reflect.Slice:
++		strtype := v.Type().String()
++		if strtype == ""[]uint8"" {
++			buf.WriteString(""<binary>"")
++			break
++		}
++
+ 		nl, id, id2 := """", """", """"
+ 		if v.Len() > 3 {
+ 			nl, id, id2 = ""\n"", strings.Repeat("" "", indent), strings.Repeat("" "", indent+2)",Can we also add the length of the slice here? Some like `<binary> len %d`
+7777,"@@ -7,6 +7,8 @@
+ package block
+
+ import (
++	""github.com/iotexproject/iotex-core/pkg/log""
++	""go.uber.org/zap""
+ 	""google.golang.org/protobuf/proto""
+
+ 	""github.com/iotexproject/iotex-proto/golang/iotextypes""","move this line together to after line 16, group internal packages together"
+7778,"@@ -0,0 +1,12 @@
++class CreateFeedbacks < ActiveRecord::Migration
++  def change
++    create_table :feedbacks do |t|
++      t.integer :rating
++      t.integer :more_info
++      t.string :uuid
++      t.string :project_name
++
++      t.timestamps null: false
++    end
++  end
++end",How about using a reference(project_id) instead of project name
+7779,"@@ -133,12 +133,14 @@ var (
+ 		Explorer: Explorer{
+ 			Enabled:                 false,
+ 			IsTest:                  false,
++			UseRDS:					 false,
+ 			Port:                    14004,
+ 			TpsWindow:               10,
+ 			MaxTransferPayloadBytes: 1024,
+ 		},
+ 		Indexer: Indexer{
+ 			Enabled: false,
++			NodeAddr: """",
+ 		},
+ 		System: System{
+ 			HeartbeatInterval: 10 * time.Second,",File is not `gofmt`-ed with `-s`
+7780,"@@ -235,6 +235,10 @@ public class FileDownloadServiceBean implements java.io.Serializable {
+                 dataFile = guestbookResponse.getDataFile();
+             }
+         }
++        //For tools to get the dataset and datasetversion ids, we need a full DataFile object (not a findCheapAndEasy() copy)
++        if(dataFile.getFileMetadata()==null) {
++            dataFile=datafileService.find(dataFile.getId());
++        }
+         ExternalToolHandler externalToolHandler = new ExternalToolHandler(externalTool, dataFile, apiToken);
+         // Back when we only had TwoRavens, the downloadType was always ""Explore"". Now we persist the name of the tool (i.e. ""TwoRavens"", ""Data Explorer"", etc.)
+         guestbookResponse.setDownloadtype(externalTool.getDisplayName());","@qqmyers this looks fine but have you seen any performance issue here? If so, we could right some helper method like doesExternalToolNeedDataset(externalTool). But if there's trivial performance impact, not worth it."
+7781,"@@ -37,6 +37,8 @@
+ #define STATICBOXVERTICALSPACER 10
+ #define DAYOFWEEKBORDERSIZE 10
+
++bool usingLocalPrefs;
++
+ ///////////////////////////////////////////////////////////////////////////
+
+ // NOTE: On MS Windows with wxWidgets 3.0, controls inside a wxStaticBox ",Make this a member variable instead (move to header inside `class` and rename to `m_bUsingLocalPrefs`).
+7782,"@@ -110,7 +110,7 @@ describe('Transactions (spec)', function() {
+         afterEach(() => cleanupAfterSuite(testContext));
+
+         testSuite.tests.forEach(testData => {
+-          const maybeSkipIt = testData.skipReason ? it.skip : it;
++          const maybeSkipIt = testData.skipReason || testSuite.name === 'pin-mongos' ? it.skip : it;
+           maybeSkipIt(testData.description, function() {
+             let testPromise = Promise.resolve();
+ ","Generally I'd say we should factor this out into something more extensible (check an array of potentially skipped tests, for examples), but since we're likely to remove this soon for scheduled work I think this is fine. What do you think @daprahamian?"
+7783,"@@ -18,7 +18,7 @@ THE SOFTWARE.
+ */
+
+ /* HIT_START
+- * BUILD: %t %s ../../test_common.cpp NVCC_OPTIONS -std=c++11
++ * BUILD: %t %s ../../test_common.cpp NVCC_OPTIONS -std=c++11 EXCLUDE_HIP_PLATFORM clang
+  * TEST: %t
+  * HIT_END
+  */",Why are we skipping these tests? they should be passing in HIP-Clang.
+7784,"@@ -279,9 +279,14 @@ class RandString(RandField):
+     def __mul__(self, n):
+         return self._fix()*n
+
+-class RandBin(RandString):
++class RandBin(RandString, object):
+     def __init__(self, size=None):
+-        RandString.__init__(self, size, """".join(map(chr, range(256))))
++        super(RandBin, self).__init__(size=size, chars=b"""".join(chb(c) for c in range(256)))
++    def _fix(self):
++        s = b""""
++        for _ in range(self.size):
++            s += chb(random.choice(self.chars))
++        return s
+
+
+ class RandTermString(RandString):","I think a ""string"" in Scapy's spirit (if such a thing exists) is actually a `bytes` object in Python 3 (see `Str*Field`s). So maybe `RandString._fix()` should return a `bytes` object. What do you think?"
+7785,"@@ -12,6 +12,8 @@
+
+ const path = require('path')
+ const fs = require('fs')
++const jsdom = require(""jsdom"");
++const { JSDOM } = jsdom;
+
+ const srcDir = path.resolve(path.join(__dirname, '..', 'src'))
+ ","This can be combined to 1 line, just tested, seems to work."
+7786,"@@ -1404,6 +1404,16 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+         throw new IllegalStateException(
+             ""GoQuorum compatibility mode (enabled) can only be used if genesis file has 'isQuorum' flag set to true."");
+       }
++      genesisConfigOptions
++          .getChainId()
++          .ifPresent(chainId -> ensureGoQuorumCompatibilityModeNotUsedOnMainnet(chainId));
++    }
++  }
++
++  private void ensureGoQuorumCompatibilityModeNotUsedOnMainnet(final BigInteger chainId) {
++    if (chainId.equals(EthNetworkConfig.MAINNET_NETWORK_ID)) {
++      throw new IllegalStateException(
++          ""GoQuorum compatibility mode (enabled) cannot be used on Mainnet."");
+     }
+   }
+ ",what needs to happen if it is not present?
+7787,"@@ -88,6 +88,11 @@ func (e *deployExecutor) Execute(sig executor.StopSignal) model.StageStatus {
+ 		return model.StageStatus_STAGE_FAILURE
+ 	}
+
++	chartRepoName := e.deployCfg.Input.HelmChart.Repository
++	if chartRepoName != """" {
++		e.deployCfg.Input.HelmChart.Insecure = ds.DeploymentConfig.PipedSpec.IsInsecureChartRepository(chartRepoName)
++	}
++
+ 	e.provider = provider.NewProvider(e.Deployment.ApplicationName, ds.AppDir, ds.RepoDir, e.Deployment.GitPath.ConfigFilename, e.deployCfg.Input, e.Logger)
+ 	e.Logger.Info(""start executing kubernetes stage"",
+ 		zap.String(""stage-name"", e.Stage.Name),","`DeploymentConfig` is only for deployment configuration not Piped configuration so `ds.DeploymentConfig.PipedSpec` is always nil. Instead of that, you can have Piped config with `e.PipedConfig` because it is placing inside `executor.Input`."
+7788,"@@ -1,6 +1,12 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to set the access control list (ACL) on an
++# object in an Amazon Simple Storage Solution (Amazon S3) bucket for the given owner.
++
++# snippet-start:[s3.s3_set_bucket_object_acls.rb]
++
+ require 'aws-sdk-s3'
+
+ # Sets the access control list (ACL) on an object in an Amazon S3",Simple Storage **Service**
+7789,"@@ -35,8 +35,13 @@ namespace OpenTelemetry.Instrumentation.AspNet
+         });
+
+         /// <summary>
+-        /// Gets or sets a hook to exclude calls based on domain or other per-request criterion.
++        /// Gets or sets a Filter function to filter instrumentation for requests on a per request basis.
++        /// The functions gets the HttpContext, and should return a boolean.
++        /// If functions returns true, the request is collected.
++        /// If functions returns false, the request is filtered out.
++        /// If filter throws exception, then this is considered as no filter being configured.
++        /// and requested is collected.
+         /// </summary>
+-        internal Predicate<HttpContext> RequestFilter { get; set; }
++        public Func<HttpContext, bool> Filter { get; set; }
+     }
+ }",This line doesn't seem to be right?
+7790,"@@ -271,6 +271,7 @@ func (c *CVCController) createVolumeOperation(cvc *apis.CStorVolumeClaim) (*apis
+ 	// update the cstorvolume reference, phase as ""Bound"" and desired
+ 	// capacity
+ 	cvc.Spec.CStorVolumeRef = volumeRef
++	cvc.Spec.Policy = volumePolicy.Spec
+ 	cvc.Status.Phase = apis.CStorVolumeClaimPhaseBound
+ 	cvc.Status.Capacity = cvc.Spec.Capacity
+ ",this need to be moved up after getting policy..
+7791,"@@ -1363,7 +1363,7 @@ data:
+     # GCP Specific
+     - name: GCPInvalidProjectID
+       searchRegexStrings:
+-      - ""platform\.gcp\.project.* invalid project ID""
++      - ""platform.gcp.project.* invalid project ID""
+       installFailingReason: GCPInvalidProjectID
+       installFailingMessage: Invalid GCP project ID
+     - name: GCPInstanceTypeNotFound",I'm curious - is there a way to test these?
+7792,"@@ -59,10 +59,10 @@ public class MetadataTableUtils {
+   }
+
+   public static Table createMetadataTableInstance(TableOperations originTableOps,
++                                                  String catalogName,
+                                                   TableIdentifier originTableIdentifier,
+                                                   MetadataTableType type) {
+-    return createMetadataTableInstance(originTableOps,
+-        BaseMetastoreCatalog.fullTableName(type.name(), originTableIdentifier),
+-        type);
++    String fullTableName = BaseMetastoreCatalog.fullTableName(catalogName, originTableIdentifier);
++    return createMetadataTableInstance(originTableOps, fullTableName, type);
+   }
+ }","This was broken before as the name of the metadata table started with its type, not catalog."
+7793,"@@ -173,6 +173,7 @@ func (di *Dependencies) Bootstrap(nodeOptions node.Options) error {
+ 	nats_discovery.Bootstrap()
+
+ 	log.Infof(""Starting Mysterium Node (%s)"", metadata.VersionAsString())
++	log.Infof(""Build information (%s)"", metadata.BuildAsString())
+
+ 	if err := nodeOptions.Directories.Check(); err != nil {
+ 		return err","Maybe remake `VersionAsString()` function, so that that we would have build info in all places"
+7794,"@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
+   close();
+ }
+
++bool TSSLSocket::hasPendingDataToRead() {
++  if (!isOpen()) {
++    return false;
++  }
++  initializeHandshake();
++  if (!checkHandshake())
++    throw TSSLException(""SSL_peek: Handshake is not completed"");
++  // data may be available in SSL buffers (note: SSL_pending does not have a failure mode)
++  return TSocket::hasPendingDataToRead() || SSL_pending(ssl_) > 0;
++}
++
+ void TSSLSocket::init() {
+   handshakeCompleted_ = false;
+   readRetryCount_ = 0;",This should probably say something other than SSL_peek?
+7795,"@@ -1,7 +1,7 @@
+ /**
+- * Search Console module initialization.
++ * Search console module initialization.
+  *
+- * Site Kit by Google, Copyright 2019 Google LLC
++ * Site Kit by Google, Copyright 2020 Google LLC
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.","Nitpicking, but this should be capitalized since it's a product name :)"
+7796,"@@ -94,6 +94,16 @@ type TransactionMisc struct {
+ 	from atomic.Value
+ }
+
++type RawTransactions [][]byte
++
++func (t RawTransactions) Len() int {
++	return len(t)
++}
++
++func (t RawTransactions) EncodeIndex(i int, w *bytes.Buffer) {
++	w.Write(t[i])
++}
++
+ func (tm TransactionMisc) Time() time.Time {
+ 	return tm.time
+ }",Why do we need RawTransactions?
+7797,"@@ -37,6 +37,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ 	""github.com/iotexproject/iotex-core/protogen/iotextypes""
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ )
+
+ var (",File is not `gofmt`-ed with `-s` (from `gofmt`)
+7798,"@@ -632,7 +632,14 @@ public class NSClientService extends Service {
+                                         if (sgv.getMills() > latestDateInReceivedData)
+                                             latestDateInReceivedData = sgv.getMills();
+                                 }
+-                                BroadcastSgvs.handleNewSgv(sgvs, MainApp.instance().getApplicationContext(), isDelta);
++                                // Was that sgv more than 15 mins ago ?
++                                boolean moreThan15MinAgo = false;
++                                if((System.currentTimeMillis()-latestDateInReceivedData)/(60 * 1000L) < 15L )
++                                    moreThan15MinAgo = true;
++                                if(Notification.isAlarmForStaleData() && moreThan15MinAgo){
++                                    MainApp.bus().post(new EventDismissNotification(Notification.NSALARM));
++                                }
++                                BroadcastSgvs.handleNewSgv(sgvs, MainApp.instance().getApplicationContext(), isDelta);
+                             }
+                             MainApp.bus().post(new EventNSClientNewLog(""LAST"", DateUtil.dateAndTimeString(latestDateInReceivedData)));
+                         } catch (JSONException e) {",should not be this lessThan15MinAgo ?
+7799,"@@ -1192,6 +1192,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+
+                 return RequestLineStatus.Done;
+             }
++            catch (DecodingException)
++            {
++                RejectRequest(RequestRejectionReason.NonAsciiOrNullCharactersInRequestLine,
++                    Log.IsEnabled(LogLevel.Information) ? start.GetAsciiStringEscaped(end, MaxInvalidRequestLineChars) : string.Empty);
++                // won't run but compiler complains
++                return RequestLineStatus.Done;
++            }
+             finally
+             {
+                 input.ConsumingComplete(consumed, end);",Would it work if we changed the return type of 'RejectRequest*' methods to Exception and instead did `throw RejectRequest(...` ?
+7800,"@@ -387,7 +387,7 @@ import browser from './browser';
+             videoAudioCodecs.push('mp2');
+         }
+
+-        let supportsDts = browser.tizen || browser.web0s || options.supportsDts || videoTestElement.canPlayType('video/mp4; codecs=""dts-""').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=""dts+""').replace(/no/, '');
++        let supportsDts = browser.tizen || videoTestElement.canPlayType('video/mp4; codecs=""dts-""').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=""dts+""').replace(/no/, '');
+
+         // DTS audio not supported in 2018 models (Tizen 4.0)
+         if (browser.tizenVersion >= 4) {","It is not a ""perfect"" test, but: webOS 1.2 emulator says `probably`. webOS 3 emulator says \``. webOS 4 emulator says \``. Why did you remove `options.supportsDts`?"
+7801,"@@ -152,6 +152,8 @@ hipError_t ihipEnablePeerAccess(hipCtx_t peerCtx, unsigned int flags) {
+ //---
+ hipError_t hipMemcpyPeer(void* dst, hipCtx_t dstCtx, const void* src, hipCtx_t srcCtx,
+                          size_t sizeBytes) {
++    if(dstCtx == srcCtx) return hipErrorInvalidValue;
++
+     HIP_INIT_API(NONE, dst, dstCtx, src, srcCtx, sizeBytes);
+
+     // TODO - move to ihip memory copy implementaion.",This check should be after the HIP_INIT_API to ensure HIP tracing & lazy init works correctly. Also return should be wrapped in ihipLogStatus() so that logging works correctly.
+7802,"@@ -54,7 +54,14 @@ class ReIndexTask extends AbstractTask
+      *
+      * @var array
+      */
+-    protected $indexingConfigurationsToReIndex = array();
++    protected $indexingConfigurationsToReIndex = [];
++
++    /**
++     * Clear Index for selected sites and record types
++     *
++     * @var boolean
++     */
++    protected $clearSearchIndex = false;
+
+
+     /**",Can't use short array syntax for the 3.1 release branch.
+7803,"@@ -2103,7 +2103,8 @@ static pmix_status_t server_switchyard(pmix_peer_t *peer, uint32_t tag,
+         PMIX_ERROR_LOG(rc);
+         return rc;
+     }
+-    pmix_output_verbose(2, pmix_globals.debug_output,
++   // pmix_output_verbose(2, pmix_globals.debug_output,
++                        pmix_output(0,
+                         ""recvd pmix cmd %d from %s:%u"",
+                         cmd, peer->info->pname.nspace, peer->info->pname.rank);
+ ",@rhc54 Is this intentional or for debug purposes?
+7804,"@@ -12,7 +12,14 @@ def includeme(config):
+     # Activate end-points.
+     config.scan('kinto.plugins.history.views')
+
++    # If StatsD is enabled, monitor execution time of listener.
++    if config.registry.statsd:
++        key = 'listeners.history'
++        listener = config.registry.statsd.timer(key)(on_resource_changed)
++    else:
++        listener = on_resource_changed
++
+     # Listen to every resources (except history)
+-    config.add_subscriber(on_resource_changed, ResourceChanged,
++    config.add_subscriber(listener, ResourceChanged,
+                           for_resources=('bucket', 'group',
+                                          'collection', 'record'))","Maybe it should be `plugins.history` here instead of `listeners.X`, since we use those for listeners configured via `.ini` files?"
+7805,"@@ -6,6 +6,10 @@ module TeamPlansHelper
+     end
+   end
+
++  def team_page?
++    @team_page.present?
++  end
++
+   private
+
+   def team_plan_quantity_select_attributes(plan)","Hmm, I also don't have a better idea here. As a small thing, could you make this `@team_page.present?` or similar to make the intent slightly more clear?"
+7806,"@@ -45,7 +45,12 @@ public class DecrypterInputStream extends InputStream implements WatchableStream
+
+     public DecrypterInputStream(FileInputStream inputStream, String encryptionKey)
+             throws GeneralSecurityException, IOException {
++        // First byte should be iv length
+         int ivLength = inputStream.read();
++        if (ivLength != 16 && ivLength != 32) {
++            throw new IOException(""Can't decrypt file: incorrect iv length found in file: "" + ivLength);
++        }
++        // Next bytes should be iv
+         byte[] iv = new byte[ivLength];
+         inputStream.read(iv);
+         Cipher cipher = Encryptor.getDecryptingCipher(encryptionKey, iv);",Without that check it would fail later (probably in the getDecryptingCipher method) but the error could be hard to make sense of.
+7807,"@@ -379,6 +379,13 @@ module Beaker
+       return result
+     end
+
++    def do_take_snapshot snapshot_name
++      self[:hypervisor].take_snapshot(name, snapshot_name)
++    end
++
++    def do_restore_snapshot snapshot_name
++      self[:hypervisor].restore_snapshot(name, snapshot_name)
++    end
+   end
+
+   [ 'windows', 'unix', 'aix', 'mac' ].each do |lib|",I don't think that this belongs in the host code. A host is pretty much unaware of what hypervisor is running it and I don't want them to be so coupled to their hypervisor.
+7808,"@@ -23,5 +23,6 @@ import setuptools
+ setuptools.setup(
+     packages=setuptools.find_packages(),
+     pbr=True,
+-    setup_requires=['pbr']
++    setup_requires=['pbr', 'setuptools>=12']
++    # setuptools due https://github.com/ansible/molecule/issues/1859
+ )",I'm here to tell you that this doesn't make sense because of the way it works. `setuptools.setup()` installs this only for setup-time and then discards those. But the problem is that it will not pick up a newer version because the older version is already in runtime and module cannot substitute itself. The proper place for adding build deps nowadays is `pyproject.toml`->`[build-system]`->`requires'.
+7809,"@@ -34,7 +34,7 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ )
+
+-type fakeManager struct {
++type fakeConnectionManager struct {
+ 	onConnectReturn      error
+ 	onDisconnectReturn   error
+ 	onStatusReturn       connection.Status",fakeConnectionManager -> mockConnectionManager. We probably should not use the `fake` anymore.
+7810,"@@ -364,6 +364,7 @@ class JUnitTester(AbstractTestRunner):
+         self.base_class_path = [self.selenium_server_jar_path, self.junit_path, self.junit_listener_path,
+                                 self.hamcrest_path, self.json_jar_path]
+         self.base_class_path.extend(self.scenario.get(""additional-classpath"", []))
++        self.base_class_path=[os.path.abspath(x) for x in self.base_class_path]
+
+     def prepare(self):
+         """"""","Code style. Btw, it's weird Codacy didn't catch that."
+7811,"@@ -72,6 +72,14 @@ func (m *EthAddress) UnmarshalYAML(unmarshal func(interface{}) error) error {
+ 	return nil
+ }
+
++func (m *EthAddress) IsZero() bool {
++	return NewBigInt(m.Unwrap().Big()).IsZero()
++}
++
++func NewEthAddress(addr common.Address) *EthAddress {
++	return &EthAddress{Address: addr.Bytes()}
++}
++
+ func (m *DataSize) Unwrap() datasize.ByteSize {
+ 	return datasize.NewByteSize(m.Bytes)
+ }",no need in BigInt just m.Unwrap().Big().Bitlen() == 0
+7812,"@@ -197,7 +197,7 @@ func (ctx *conjMatchFlowContext) installOrUpdateFlow(actions []*conjunctiveActio
+ 		// Build the Openflow entry. actions here should not be empty for either add or update case.
+ 		flow := ctx.client.conjunctiveMatchFlow(ctx.tableID, ctx.matchKey, ctx.matchValue, actions...)
+
+-		if err := flow.Add(); err != nil {
++		if err := ctx.client.flowOperations.Add(flow); err != nil {
+ 			return err
+ 		}
+ 		ctx.flow = flow",I assume you want to change NetworkPolicy to use bundles in a separate PR later?
+7813,"@@ -77,7 +77,7 @@ MARKER_FILE_LIGHT_VERSION = ""%s/.light-version"" % dirs.static_libs
+ IMAGE_NAME_SFN_LOCAL = ""amazon/aws-stepfunctions-local""
+ ARTIFACTS_REPO = ""https://github.com/localstack/localstack-artifacts""
+ SFN_PATCH_URL_PREFIX = (
+-    f""{ARTIFACTS_REPO}/raw/047cc6dcd2e31f5ff3ec52d293c61b875f606958/stepfunctions-local-patch""
++    f""{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunctions-local-patch""
+ )
+ SFN_PATCH_CLASS1 = ""com/amazonaws/stepfunctions/local/runtime/Config.class""
+ SFN_PATCH_CLASS2 = (","nit: We could parameterize the commit hash, as it's used in multiple places."
+7814,"@@ -2,6 +2,7 @@
+ // Licensed under the MIT License. See License.txt in the project root for license information.
+
+ var Constants = require('./constants');
++var _ = require('underscore');
+
+ /**
+ * Checks if a parsed URL is HTTPS","move this above the ""Constants"" as this is 3rd party ones"
+7815,"@@ -12,10 +12,16 @@ class AuthenticationPoliciesTest(BaseWebTest, unittest.TestCase):
+
+     def test_basic_auth_is_accepted_by_default(self):
+         self.app.get(self.collection_url, headers=self.headers, status=200)
++        # Check that the capability is exposed on the homepage.
++        resp = self.app.get('/')
++        assert 'basicauth' in resp.json['capabilities']
+
+     def test_basic_auth_is_accepted_if_enabled_in_settings(self):
+         app = self.make_app({'multiauth.policies': 'basicauth'})
+         app.get(self.collection_url, headers=self.headers, status=200)
++        # Check that the capability is exposed on the homepage.
++        resp = self.app.get('/')
++        assert 'basicauth' in resp.json['capabilities']
+
+     def test_basic_auth_is_declined_if_disabled_in_settings(self):
+         app = self.make_app({",`assert not in`
+7816,"@@ -310,13 +310,15 @@ func (engine *DockerTaskEngine) monitorExecAgentRunning(ctx context.Context,
+ 	// to finish monitoring.
+ 	// This is inspired from containers streaming stats from Docker.
+ 	time.Sleep(retry.AddJitter(time.Nanosecond, engine.monitorExecAgentsInterval/2))
+-	_, err = engine.execCmdMgr.RestartAgentIfStopped(ctx, engine.client, task, c, dockerID)
++	status, err := engine.execCmdMgr.RestartAgentIfStopped(ctx, engine.client, task, c, dockerID)
+ 	if err != nil {
+ 		seelog.Errorf(""Task engine [%s]: Failed to restart ExecCommandAgent Process for container [%s]: %v"", task.Arn, dockerID, err)
++		mTask.emitContainerEvent(mTask.Task, c, """")
+ 	}
+-	// whether we restarted or failed to restart, we'll want to emit a state change event
+-	// redundant state change events like RUNNING->RUNNING are allowed
+-	mTask.emitContainerEvent(mTask.Task, c, """")
++	if status == execcmd.Restarted {
++		mTask.emitContainerEvent(mTask.Task, c, """")
++	}
++
+ }
+
+ // MustInit blocks and retries until an engine can be initialized.","just curious, why was this modified?"
+7817,"@@ -1302,6 +1302,7 @@ void ComTdbExeUtilFastDelete::displayContents(Space * space,
+ ComTdbExeUtilHiveTruncate::ComTdbExeUtilHiveTruncate(
+      char * tableName,
+      ULng32 tableNameLen,
++     char * hiveTableName,
+      char * tableLocation,
+      char * partnLocation,
+      char * hostName,",I'm curious why the table name is bound at compile time? Is it just to save the table create/drop overhead in a prepare-once-execute-many situation?
+7818,"@@ -58,10 +58,6 @@ public class ProcessJob extends AbstractProcessJob {
+   public ProcessJob(final String jobId, final Props sysProps,
+       final Props jobProps, final Logger log) {
+     super(jobId, sysProps, jobProps, log);
+-
+-    // this is in line with what other job types (hadoopJava, spark, pig, hive)
+-    // is doing
+-    jobProps.put(CommonJobProperties.JOB_ID, jobId);
+   }
+
+   @Override","quick question, isn't ProcessJob used by all job types? Then why is JOB_ID not found?"
+7819,"@@ -264,6 +264,15 @@ public class AccountSettings {
+         s.put(""trashFolderSelection"", Settings.versions(
+                 new V(54, new EnumSetting<>(SpecialFolderSelection.class, SpecialFolderSelection.AUTOMATIC))
+         ));
++        s.put(""resize_image_enabled"", Settings.versions(
++                new V(55, new BooleanSetting(Account.DEFAULT_RESIZE_IMAGE_ENABLED))
++        ));
++        s.put(""resize_image_circumference"", Settings.versions(
++                new V(55, new StringSetting(Integer.toString(Account.DEFAULT_RESIZE_IMAGE_CIRCUMFERENCE)))
++        ));
++        s.put(""resize_image_quality"", Settings.versions(
++                new V(55, new StringSetting(Integer.toString(Account.DEFAULT_RESIZE_IMAGE_QUALITY)))
++        ));
+         // note that there is no setting for openPgpProvider, because this will have to be set up together
+         // with the actual provider after import anyways.
+ ",looks like you forgot to actually increase the version
+7820,"@@ -43,5 +43,13 @@ namespace OpenTelemetry.Instrumentation.AspNet
+         /// The type of this object depends on the event, which is given by the above parameter.</para>
+         /// </remarks>
+         public Action<Activity, string, object> Enrich { get; set; }
++
++        /// <summary>
++        /// Gets or sets a value indicating whether to record http server attributes or not.
++        /// </summary>
++        /// <remarks>
++        /// https://github.com/open-telemetry/opentelemetry-specification/blob/a2758014f408f64ff84728918d671ee3fdab2225/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions.
++        /// </remarks>
++        public bool RecordHttpServerAttributes { get; set; }
+     }
+ }",I think it might be helpful if we add `Default value: False.` on the end of the summary.
+7821,"@@ -80,7 +80,7 @@ module.exports = function(realmConstructor) {
+             // result in sync rejecting the writes. `_waitForDownload` ensures that the session is kept
+             // alive until our callback has returned, which prevents it from being torn down and recreated
+             // when we close the schemaless Realm and open it with the correct schema.
+-            if (!config.sync.fullSynchronization && config.schema === undefined) {
++            if (config.sync.fullSynchronized !== undefined && !config.sync.fullSynchronization && config.schema === undefined) {
+                 throw new Error('Query-based sync requires a schema.');
+             }
+             let syncSession;",I think the check should be `config.sync.fullSynchronization === false` - otherwise this will get triggered even when full sync is `true`.
+7822,"@@ -924,8 +924,11 @@ func (a *WebAPI) GenerateApplicationSealedSecret(ctx context.Context, req *webse
+ 		return nil, err
+ 	}
+
+-	sse := piped.SealedSecretEncryption
+-	if sse == nil {
++	se := piped.SecretEncryption
++	if se == nil {
++		se = piped.SealedSecretEncryption
++	}
++	if se == nil {
+ 		return nil, status.Error(codes.FailedPrecondition, ""The piped does not contain the encryption configuration"")
+ 	}
+ ",this blown my mind
+7823,"@@ -335,6 +335,10 @@ type MayaAPIServiceOutputLabel string
+ const (
+ 	ReplicaStatusAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/replica-status""
+
++	//ReplicaContainerStatus MayaAPIServiceOutputLabel = ""vsm.openebs.io/replica-cont-status""
++
++	ControllerContainerStatus MayaAPIServiceOutputLabel = ""vsm.openebs.io/container-status""
++
+ 	ControllerStatusAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/controller-status""
+
+ 	TargetPortalsAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/targetportals""",this should be controller-container-status
+7824,"@@ -16,10 +16,12 @@
+
+ package azkaban.scheduler;
+
++import azkaban.utils.Utils;
+ import java.util.ArrayList;
+ import java.util.HashMap;
+ import java.util.List;
+ import java.util.Map;
++import java.util.Date;
+
+ import org.joda.time.DateTime;
+ import org.joda.time.DateTimeZone;",Sort import. You can use IDE's organize import feature.
+7825,"@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver;
+ import org.openqa.selenium.WebElement;
+
+ import java.io.IOException;
++import java.io.UncheckedIOException;
+ import java.net.URL;
+ import java.nio.charset.StandardCharsets;
+ import java.util.ArrayList;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+7826,"@@ -16,6 +16,7 @@ import (
+ )
+
+ func TestMiningPledgeSector(t *testing.T) {
++	t.Skip(""Unskip when we have implemented production drand component and local drand network for functional tests"")
+ 	tf.FunctionalTest(t)
+
+ 	ctx, cancel := context.WithCancel(context.Background())",This PR is off to a rough start. :)
+7827,"@@ -380,7 +380,7 @@ function normalizeProxyConfiguration(config) {
+     }
+   } else if ('pac' === config.proxyType) {
+     if (config.proxyAutoconfigUrl && !config.pacUrl) {
+-      config.pacUrl = config.proxyAutoconfigUrl;
++      config.proxyAutoconfigUrl = config.proxyAutoconfigUrl;
+     }
+   }
+   return config;","Actually, it looks like the entire `normalizeProxyConfiguration` function isn't needed anymore"
+7828,"@@ -32,6 +32,8 @@
+   </div>
+ </div>
+
+-<ul id='breadcrumb-nav'>
+-  <li><%= link_to ""Back to main portal"", carts_path %></li>
+-</ul>
++<%- unless excluded_portal_link %>
++  <ul id='breadcrumb-nav'>
++    <li><%= link_to ""Back to main portal"", carts_path %></li>
++  </ul>
++<%- end %>",How about `unless current_path == carts_path`?
+7829,"@@ -63,7 +63,7 @@
+ # Copyright (c) 2021 Lorena B <46202743+lorena-b@users.noreply.github.com>
+ # Copyright (c) 2021 David Liu <david@cs.toronto.edu>
+ # Copyright (c) 2021 Andreas Finkler <andi.finkler@gmail.com>
+-# Copyright (c) 2021 Or Bahari <orbahari@mail.tau.ac.il>
++# Copyright (c) 2021-2022 Or Bahari <or.ba402@gmail.com>
+
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE",You need to modify the copyrite aliases so it's done automatically.
+7830,"@@ -174,6 +174,13 @@ function createElement(...args) {
+
+ 	let type = vnode.type, props = vnode.props;
+ 	if (typeof type!='function') {
++		Object.keys(props).forEach(key => {
++			if (/^on(Ani|Tra)/.test(key)) {
++				props[key.toLowerCase()] = props[key];
++				delete props[key];
++			}
++		});
++
+ 		if (props.defaultValue) {
+ 			if (!props.value && props.value!==0) {
+ 				props.value = props.defaultValue;",Quick question: Is this true for all `onAnimation*` and all `onTransition*` events?
+7831,"@@ -59,6 +59,8 @@ function Address(data, network, type) {
+     info = Address._transformPublicKey(data);
+   } else if (data.constructor && (data.constructor.name && data.constructor.name === 'Script')) {
+     info = Address._transformScript(data);
++  } else if (data instanceof Address) {
++    return data;
+   } else if (typeof(data) === 'string') {
+     info = Address._transformString(data, network, type);
+   } else {","Should sending an address into address error? Since the call isn't needed, and could be fixed easily."
+7832,"@@ -26,6 +26,7 @@ import java.util.List;
+ import java.util.Map;
+ import java.util.TreeMap;
+
++import org.apache.log4j.MDC;
+ import org.apache.lucene.index.MultiTerms;
+ import org.apache.lucene.index.Terms;
+ import org.apache.lucene.index.TermsEnum;",This is the wrong MDC; see MDCLoggingContext which imports `org.slf4j.MDC`
+7833,"@@ -127,6 +127,9 @@ public interface HistoricDetailQuery extends Query<HistoricDetailQuery, Historic
+   /** Only select historic details that have occurred after the given date (inclusive). */
+   HistoricDetailQuery occurredAfter(Date date);
+
++  /** Only select historic details that were set during the process start. */
++  HistoricDetailQuery initial();
++
+   /**
+    * Order by tenant id (needs to be followed by {@link #asc()} or {@link #desc()}).
+    * Note that the ordering of historic details without tenant id is database-specific.",Maybe we can clarify a bit what that means.
+7834,"@@ -94,7 +94,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+                 {
+                     tcs2.SetResult(task2.Result);
+                 }
+-            }, tcs);
++            }, tcs, cancellationToken);
+             return tcs.Task;
+         }
+ ",This entire method can be deleted; it isn't used and it isn't an override of Stream.
+7835,"@@ -50,6 +50,8 @@ import org.apache.iceberg.util.Pair;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
++import static org.apache.iceberg.MetadataTableUtils.createMetadataTableInstance;
++
+ /**
+  * Implementation of Iceberg tables that uses the Hadoop FileSystem
+  * to store metadata and manifests.",We avoid static method imports. Can you call `MetadataTableUtils.createMetadataTableInstance` instead?
+7836,"@@ -254,6 +254,7 @@ class PACFetcher(QObject):
+     def __eq__(self, other):
+         # pylint: disable=protected-access
+         return self._pac_url == other._pac_url
++        # pylint: enable=protected-access
+
+     def __repr__(self):
+         return utils.get_repr(self, url=self._pac_url, constructor=True)","No need for this, as pylint already only turns things off for this function and it's needed for the entire function."
+7837,"@@ -37,7 +37,13 @@ class Purchase < ActiveRecord::Base
+     to: :purchaseable,
+     prefix: :purchaseable,
+     allow_nil: true
+-  delegate :fulfilled_with_github?, :subscription?, :terms, to: :purchaseable
++  delegate(
++    :fulfilled_with_github?,
++    :includes_mentor?,
++    :subscription?,
++    :terms,
++    to: :purchaseable
++  )
+
+   def self.within_range(start_time, end_time)
+     paid.where(""created_at >= ? and created_at <= ?"", start_time, end_time)",I'm actually surprised this is valid Ruby. I thought you'd need either `delegate(...)` or `delegate \ ...`.
+7838,"@@ -99,7 +99,7 @@ public class TestHelpers {
+         if (checkArrowValidityVector) {
+           ColumnVector columnVector = batch.column(i);
+           ValueVector arrowVector = ((IcebergArrowColumnVector) columnVector).vectorAccessor().getVector();
+-          Assert.assertEquals(""Nullability doesn't match"", expectedValue == null, arrowVector.isNull(rowId));
++          Assert.assertFalse(""Nullability doesn't match"", expectedValue == null ^ arrowVector.isNull(rowId));
+         }
+       }
+     }",Why change this?
+7839,"@@ -537,6 +537,12 @@ module.exports = class XHRUpload extends Plugin {
+     const files = fileIDs.map((fileID) => this.uppy.getFile(fileID))
+
+     if (this.opts.bundle) {
++      // if bundle: true, we don’t support remote uploads
++      const isSomeFileRemote = files.some(file => file.isRemote)
++      if (isSomeFileRemote) {
++        throw new Error('Can’t bundle remote files when bundle: true is set')
++      }
++
+       return this.uploadBundle(files)
+     }
+ ",Maybe change it to `'Can't UPLOAD remote files when bundle: true is set'`?
+7840,"@@ -217,7 +217,14 @@ namespace OpenTelemetry
+
+                 if (this.circularBuffer.Count > 0)
+                 {
+-                    this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize));
++                    try
++                    {
++                        this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize));
++                    }
++                    catch (Exception ex)
++                    {
++                        OpenTelemetrySdkEventSource.Log.SpanProcessorException(nameof(this.OnExport), ex);
++                    }
+
+                     this.dataExportedNotification.Set();
+                     this.dataExportedNotification.Reset();",Do we need to drop the remaining items from the batch? Otherwise we might end up with a dead loop. Add @CodeBlanch for awareness.
+7841,"@@ -292,6 +292,19 @@ func setupMiners(st state.Tree, sm vm.StorageMap, keys []*types.KeyInfo, miners
+ 				return nil, err
+ 			}
+ 		}
++		if m.NumCommittedSectors > 0 {
++			// Now submit a dummy PoSt right away to trigger power updates.
++			// Don't worry, bootstrap miner actors don't need to verify
++			// that the PoSt is well formed.
++			poStProof := make([]byte, types.OnePoStProofPartition.ProofLen())
++			if _, err := pnrg.Read(poStProof[:]); err != nil {
++				return nil, err
++			}
++			_, err = applyMessageDirect(ctx, st, sm, addr, maddr, types.NewAttoFILFromFIL(0), ""submitPoSt"", []types.PoStProof{poStProof}, types.EmptyIntSet())
++			if err != nil {
++				return nil, err
++			}
++		}
+ 	}
+
+ 	return minfos, nil",Because power is now added during `submitPoSt` this is needed for setting power in the genesis block. Again let me know if this bootstrapping solution is flawed.
+7842,"@@ -40,6 +40,10 @@ return [
+     'session_gc' => ['int'],
+     'timezone_identifiers_list' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'?string'],
+     'unpack' => ['array', 'format'=>'string', 'string'=>'string', 'offset='=>'int'],
++    'ReflectionFunction::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionFunctionAbstract::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionMethod::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionParameter::getType' => ['?ReflectionNamedType']
+ ],
+ 'old' => [
+     'DateTimeZone::listIdentifiers' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'string'],","To be consistent, these should go at the top between `DateTimeZone::listIdentifiers` and `SQLite3::createFunction`."
+7843,"@@ -165,4 +165,13 @@ public abstract class Directory implements Closeable {
+    * @throws AlreadyClosedException if this Directory is closed
+    */
+   protected void ensureOpen() throws AlreadyClosedException {}
++
++  /**
++   * Implementations can override this if they are capable of reporting modification time
++   * of a file in seconds since the epoch.
++   */
++  public long fileModified(String name) throws IOException {
++    throw new UnsupportedOperationException();
++  }
++
+ }",I think we should avoid changing any lucene classes for the moment - fileModified() can probably stay where it is?
+7844,"@@ -1174,7 +1174,7 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+                 extendedBolusView.setText(extendedBolusText);
+             }
+             if (extendedBolusText.equals(""""))
+-                extendedBolusView.setVisibility(View.INVISIBLE);
++                extendedBolusView.setVisibility(View.GONE);
+             else
+                 extendedBolusView.setVisibility(View.VISIBLE);
+         }","GONE breaks formating of "":"". or is it fixed below?"
+7845,"@@ -20,6 +20,9 @@ public class ASTResource extends ASTFormalParameter {
+     public Object jjtAccept(JavaParserVisitor visitor, Object data) {
+         return visitor.visit(this, data);
+     }
++
++    // TODO Should we deprecate all methods from ASTFormalParameter?
++
+ }
+ /*
+  * JavaCC - OriginalChecksum=92734fc70bba91fd9422150dbf87d5c4 (do not edit this",What do you mean with this? Won't the deprecation be inherited?
+7846,"@@ -90,6 +90,8 @@ std::string FlatCompiler::GetUsageString(const char* program_name) const {
+       ""  --cpp-ptr-type T   Set object API pointer type (default std::unique_ptr)\n""
+       ""  --cpp-str-type T   Set object API string type (default std::string)\n""
+       ""                     T::c_str() and T::length() must be supported\n""
++      ""  --object-prefix    Customise class prefix for C++ object-based API.\n""
++      ""  --object-suffix    Customise class suffix for C++ object-based API. Default value is \""T\""\n""
+       ""  --no-js-exports    Removes Node.js style export lines in JS.\n""
+       ""  --goog-js-export   Uses goog.exports* for closure compiler exporting in JS.\n""
+       ""  --go-namespace     Generate the overrided namespace in Golang.\n""","line between "" and "" should be <80 chars."
+7847,"@@ -7,7 +7,6 @@ module Travis
+     class Script
+       class Ruby < Script
+         DEFAULTS = {
+-          rvm:     'default',
+           gemfile: 'Gemfile'
+         }
+ ",What will happen if neither `rvm` nor `ruby` is present in the .travis.yml?
+7848,"@@ -71,8 +71,7 @@ class HCI_ACL_Hdr(Packet):
+     def post_build(self, p, pay):
+         p += pay
+         if self.len is None:
+-            l = len(p)-4
+-            p = p[:2]+chr(l&0xff)+chr((l>>8)&0xff)+p[4:]
++            p = p[:2] + struct.pack(""<H"", len(pay)) + p[4:]
+         return p
+
+ ",@p-l- Hey it seems that this was len-4 ?!
+7849,"@@ -23,12 +23,14 @@ import AdBlockerWarning from './ad-blocker-warning';
+ import { render } from '../../../../../tests/js/test-utils';
+ import { STORE_NAME } from '../datastore/constants';
+
+-const setupAdBlockerRegistry = async ( registry ) => {
+-	await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );
++const setupAdBlockerRegistry = ( registry ) => {
++	registry.dispatch( STORE_NAME ).receiveSettings( {} );
++	registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );
+ };
+
+-const setupNoAdBlockerRegistry = async ( registry ) => {
+-	await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( false );
++const setupNoAdBlockerRegistry = ( registry ) => {
++	registry.dispatch( STORE_NAME ).receiveSettings( {} );
++	registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( false );
+ };
+
+ describe( 'AdBlockerWarning', () => {","This is something I added which resolved a few large errors in the output, although not related to the refactor here I don't think."
+7850,"@@ -200,7 +200,6 @@ public class ExternalPlayerFragment extends Fragment {
+                 .into(imgvCover);
+
+         if (controller != null && controller.isPlayingVideoLocally()) {
+-            butPlay.setVisibility(View.GONE);
+             ((MainActivity) getActivity()).getBottomSheet().setLocked(true);
+             ((MainActivity) getActivity()).getBottomSheet().setState(BottomSheetBehavior.STATE_COLLAPSED);
+         } else {",i have removed this line because whenever a video is played in AntennaPod this line was making play button invisible
+7851,"@@ -0,0 +1,10 @@
++package org.apache.servicecomb.foundation.vertx;
++
++import org.junit.Test;
++
++public class MyTest {
++  @Test
++  public void myTest() {
++    System.out.println(System.getProperty(""java.io.tmpdir""));
++  }
++}",remove temporary code
+7852,"@@ -154,4 +154,11 @@ public interface BlockHeader {
+    * @return The Keccak 256-bit hash of this header.
+    */
+   Hash getBlockHash();
++
++  /**
++   * The BASEFEE of this header.
++   *
++   * @return TheBASEFEE of this header.
++   */
++  Long getBaseFee();
+ }","* Should be tagged `@Unstable` * Should be a default method, returning `null` * Also, perhaps `Optional<Long>` instead of just `Long`? Always empty when the BASEFEE isn't relevant? If so the default is `Optional.empty()`"
+7853,"@@ -30,6 +30,7 @@ import { STORE_NAME as CORE_SITE } from '../datastore/site/constants';
+ import { STORE_NAME as CORE_USER } from '../datastore/user/constants';
+
+ const MODULE_SLUG = 'test-slug';
++const TEST_STORE_NAME = 'test/' + MODULE_SLUG;
+
+ describe( 'createInfoStore store', () => {
+ 	let registry;","Minor detail, but let's use the interpolated template string syntax instead."
+7854,"@@ -53,6 +53,11 @@ type TimeChaosSpec struct {
+ 	// TimeOffset defines the delta time of injected program
+ 	TimeOffset TimeOffset `json:""timeOffset""`
+
++	// ClockIds defines all affected clock id
++	// All available options are [""CLOCK_REALTIME"",""CLOCK_MONOTONIC"",""CLOCK_PROCESS_CPUTIME_ID"",""CLOCK_THREAD_CPUTIME_ID"",""CLOCK_MONOTONIC_RAW"",""CLOCK_REALTIME_COARSE"",""CLOCK_MONOTONIC_COARSE"",""CLOCK_BOOTTIME"",""CLOCK_REALTIME_ALARM"",""CLOCK_BOOTTIME_ALARM""]
++	// Default value is [""CLOCK_REALTIME""]
++	ClockIds []string `json:""clockIds,omitempty""`
++
+ 	// Duration represents the duration of the chaos action
+ 	Duration *string `json:""duration""`
+ ","this line is so long, split it to multi lines."
+7855,"@@ -2865,7 +2865,7 @@ void AdjustValidatorOptions(const DeviceExtensions &device_extensions, const Dev
+     if (device_extensions.vk_khr_uniform_buffer_standard_layout && enabled_features.core12.uniformBufferStandardLayout == VK_TRUE) {
+         options.SetUniformBufferStandardLayout(true);
+     }
+-    if (device_extensions.vk_ext_scalar_block_layout && enabled_features.core12.scalarBlockLayout == VK_TRUE) {
++    if (device_extensions.vk_ext_scalar_block_layout || enabled_features.core12.scalarBlockLayout == VK_TRUE) {
+         options.SetScalarBlockLayout(true);
+     }
+     if (device_extensions.vk_khr_workgroup_memory_explicit_layout &&","Looks like this might be one of those ""promoted features"" where you can enable it by _either_ enabling the extension _or_ enabling the feature bit. If that is the case, I think this needs to be: `(device_extensions.vk_ext_scalar_block_layout == kEnabledByCreateinfo) || (enabled_features.core12.scalarBlockLayout == VK_TRUE)`."
+7856,"@@ -52,6 +52,10 @@ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint16_t>;
+ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint32_t>;
+ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint64_t>;
+
++#if defined(__APPLE__)
++template struct ONEDAL_EXPORT integer_overflow_ops<std::size_t>;
++#endif
++
+ } // namespace v1
+
+ namespace v2 {","Why should we define it for v1? This is preserved only for backward compatibility, all further modifications must be done in the latest vX"
+7857,"@@ -229,12 +229,8 @@ class DaskInterface(PandasInterface):
+         return columns.data.compute()
+
+     @classmethod
+-    def length(cls, dataset):
+-        """"""
+-        Length of dask dataframe is unknown, always return 1
+-        for performance, use shape to compute dataframe shape.
+-        """"""
+-        return 1
++    def nonzero(cls, dataset):
++        return True
+
+
+ ","This is a definite improvement! Hardcoding nonzero is vastly better than hardcoding length. Even so, is there no way to determine the actual value of nonzero in a way that doesn't load the entire dataset?"
+7858,"@@ -94,6 +94,13 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation
+             return hostTagValue;
+         }
+
++        /// <summary>
++        /// Gets the OpenTelemetry standard uri tag value for a span based on its request <see cref=""Uri""/>.
++        /// </summary>
++        /// <param name=""uri""><see cref=""Uri""/>.</param>
++        /// <returns>Span uri value.</returns>
++        public static string GetUriTagValueFromRequestUri(Uri uri) => string.Concat(uri.Scheme, Uri.SchemeDelimiter, uri.Authority, uri.PathAndQuery, uri.Fragment);
++
+         private static string ConvertMethodToOperationName(string method) => $""HTTP {method}"";
+
+         private static string ConvertHttpMethodToOperationName(HttpMethod method) => $""HTTP {method}"";","do we have a way to avoid the string concats, if there is no username/password in the Uri? if (uri has UsernameInfo) { do what is done in this PR. } else { existing behavior. }"
+7859,"@@ -1862,6 +1862,7 @@ static void cb_stackdriver_flush(const void *data, size_t bytes,
+     else {
+         /* The request was issued successfully, validate the 'error' field */
+         flb_plg_debug(ctx->ins, ""HTTP Status=%i"", c->resp.status);
++        flb_plg_debug(ctx->ins, ""HTTP data=%s"", c->resp.data);
+         if (c->resp.status == 200) {
+             ret_code = FLB_OK;
+         }","do not print the payload since it might be corrupted, you can get the data with _debug.http.response_payload configuration property"
+7860,"@@ -33,6 +33,7 @@ var _ = Describe(""addons flow"", func() {
+
+ 		It(""app init creates an copilot directory"", func() {
+ 			Expect(""./copilot"").Should(BeADirectory())
++			Expect(""./copilot/.workspace"").Should(BeAnExistingFile())
+ 		})
+
+ 		It(""app ls includes new app"", func() {","maybe ""app init creates an copilot directory and a workspace file""? since you validate for the file as well."
+7861,"@@ -7,10 +7,9 @@ class Topic < ActiveRecord::Base
+     options.has_many :products, source_type: 'Product'
+     options.has_many :topics, source_type: 'Topic'
+     options.has_many :videos, source_type: 'Video'
++    options.has_many :trails, source_type: 'Trail'
+   end
+
+-  has_many :trails
+-
+   validates :name, presence: true
+   validates :slug, presence: true, uniqueness: true
+ ",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+7862,"@@ -1,6 +1,6 @@
+ <?php
+
+-namespace Sabre\Event;
++namespace Amp;
+
+ /**
+  * @template TReturn",Nit: Could rename this file from SabreEvent.php now that it's not for Sabre
+7863,"@@ -39,4 +39,9 @@ func Start() {
+ func Stop() {
+ 	tch.Stop()
+ 	yarpc.Stop()
++	http.Stop()
++	apachethrift.Stop()
+ }
++
++// TODO(abg): We should probably use defers to ensure things that started up
++// successfully are stopped before we exit.",I believe this `Stop` function _is_ called with deferred.
+7864,"@@ -28,13 +28,11 @@ import { __ } from '@wordpress/i18n';
+ import API from 'googlesitekit-api';
+ import Data from 'googlesitekit-data';
+ import { STORE_NAME } from './constants';
+-import { parseAccountID } from '../util';
+ import { createFetchStore } from '../../../googlesitekit/data/create-fetch-store';
+
+ const fetchGetURLChannelsStore = createFetchStore( {
+ 	baseName: 'getURLChannels',
+-	controlCallback: ( { clientID } ) => {
+-		const accountID = parseAccountID( clientID );
++	controlCallback: ( { accountID, clientID } ) => {
+ 		if ( undefined === accountID ) {
+ 			// Mirror the API response that would happen for an invalid client ID.
+ 			return new Promise( () => {","This entire clause should now be removed. It was only relevant if `accountID` couldn't be parsed from `clientID`, which is now no longer needed."
+7865,"@@ -77,10 +77,12 @@ extlinks = {
+ }
+
+ intersphinx_mapping = {
+-    'ansible': ('https://docs.ansible.com/ansible/devel/', None),
++    'ansible': ('https://docs.ansible.com/ansible/latest/', None),
+     'pip': ('https://pip.pypa.io/en/latest/', None),
+     'python': ('https://docs.python.org/3', None),
+     'python2': ('https://docs.python.org/2', None),
++    'testinfra': ('https://testinfra.readthedocs.io/en/latest/', None),
++    'yamllint': ('http://yamllint.readthedocs.io/en/latest/', None),
+ }
+
+ # The version info for the project you're documenting, acts as replacement for","FTR: Unlike commonly known practice, `latest` in Ansible docs corresponds to the stable version, not to the latest state of the main Git branch. Is this your intention? Just checking..."
+7866,"@@ -5207,6 +5207,18 @@ const NAType *Translate::synthesizeType()
+          err4106arg = SQLCHARSETSTRING_UTF8;
+        break;
+
++     case GBK_TO_UTF8:
++       if (translateSource->getCharSet() == CharInfo::GBK || translateSource->getCharSet() == CharInfo::UnknownCharSet )
++         charsetTarget = CharInfo::UTF8;
++       else
++       {
++            if( CmpCommon::getDefaultString(HIVE_FILE_CHARSET) ==  CmpCommon::getDefaultString(HIVE_DEFAULT_CHARSET) )
++              err4106arg = SQLCHARSETCODE_GB2312;
++            else
++             charsetTarget = CharInfo::UTF8;
++       }
++       break;
++
+      case ISO88591_TO_UTF8:
+        if (translateSource->getCharSet() == CharInfo::ISO88591)
+        {",Why do we have || CharInfo::UnknownCharSet here? I do not see it it in neighbouring statements. This is just for my understanding.
+7867,"@@ -180,6 +180,7 @@ namespace NLog.Targets
+         /// <docgen category='Web Service Options' order='10' />
+         public string XmlRootNamespace { get; set; }
+
++        private readonly Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>> _pendingRequests = new Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>>();
+
+         /// <summary>
+         /// Calls the target method. Must be implemented in concrete classes.",isn't `HttpWebRequest` an expensive key value?
+7868,"@@ -148,6 +148,14 @@ class Proposal < ActiveRecord::Base
+     observations.find_by(user: user)
+   end
+
++  def eligible_observers
++    if observations.count > 0
++      User.where(client_slug: client).where('id not in (?)', observations.pluck('user_id'))
++    else
++      User.where(client_slug: client)
++    end
++  end
++
+   def add_observer(email_or_user, adder=nil, reason=nil)
+     user = find_user(email_or_user)
+ ",couldn't we run this query whether there are observations or not?
+7869,"@@ -125,12 +125,12 @@ class CmdlineTest(unittest.TestCase):
+
+     @mock.patch(""logging.getLogger"")
+     def test_cmdline_other_task(self, logger):
+-        luigi.run(['--local-scheduler', '--no-lock', 'SomeTask', '--n', '1000'])
++        luigi.run(['SomeTask', '--local-scheduler', '--no-lock', '--n', '1000'])
+         self.assertEqual(dict(MockTarget.fs.get_all_data()), {'/tmp/test_1000': b'done'})
+
+     @mock.patch(""logging.getLogger"")
+     def test_cmdline_ambiguous_class(self, logger):
+-        self.assertRaises(Exception, luigi.run, ['--local-scheduler', '--no-lock', 'AmbiguousClass'])
++        self.assertRaises(Exception, luigi.run, ['AmbiguousClass', '--local-scheduler', '--no-lock'])
+
+     @mock.patch(""logging.getLogger"")
+     @mock.patch(""logging.StreamHandler"")",This shouldn't be needed to change right?
+7870,"@@ -18,14 +18,14 @@ module.exports = {
+             ""port"": 8080
+         }
+     },
+-    ""files"": [ ""examples/cdn/*""],
++    ""files"": [ ""examples/bundle/*""],
+     ""index"": ""index.html"",
+     ""watchOptions"": {},
+     ""server"": true,
+     ""proxy"": false,
+     ""port"": 3000,
+     ""middleware"": false,
+-    ""serveStatic"": [""examples/cdn""],
++    ""serveStatic"": [""examples/bundle""],
+     ""ghostMode"": {
+         ""clicks"": true,
+         ""scroll"": true,","This seemed broken to me. Why would browserify only check the (previously `cdn`, now) `bundle` example? And even so, the path is incorrect here. Fixing this is unrelated so should not go into this PR I feel. But when we fix this in master, perhaps that solves the reload issues that you experienced @hedgerh?"
+7871,"@@ -11,13 +11,12 @@ namespace Datadog.Trace.AppSec.Waf.NativeBindings
+     [StructLayout(LayoutKind.Sequential)]
+     internal struct DdwafResultStruct
+     {
+-        [Obsolete(""This member will be removed from then ddwaf library by a future PR"")]
+-        public DDWAF_RET_CODE Action;
++        public bool Timeout;
++
++        public int PerfTotalRuntime;
+
+         public IntPtr Data;
+
+         public IntPtr PerfData;
+-
+-        public int PerfTotalRuntime;
+     }
+ }","Same question, do we have potential version-conflict crashing scenarios here?"
+7872,"@@ -89,6 +89,18 @@ int RGroupDecomposition::add(const ROMol &inmol) {
+   const bool addCoords = true;
+   MolOps::addHs(mol, explicitOnly, addCoords);
+
++  // mark any wildcards in input molecule:
++  for (auto &atom : mol.atoms()) {
++    if (atom->getAtomicNum() == 0) {
++      atom->setProp(""INPUT_DUMMY"", true);
++      // clean any existing R group numbers
++      atom->setIsotope(0);
++      atom->setAtomMapNum(0);
++      if (atom->hasProp(common_properties::_MolFileRLabel)) {
++        atom->clearProp(common_properties::_MolFileRLabel);
++      }
++    }
++  }
+   int core_idx = 0;
+   const RCore *rcore = nullptr;
+   std::vector<MatchVectType> tmatches;","Definitely not required, but it would be better if you had a constexpr for `""INPUT_DUMMY""`"
+7873,"@@ -1831,11 +1831,7 @@ namespace NLog.Targets
+ #endif
+                 try
+                 {
+-                    archiveFile = this.GetArchiveFileName(fileName, ev, upcomingWriteSize);
+-                    if (!string.IsNullOrEmpty(archiveFile))
+-                    {
+-                        this.DoAutoArchive(archiveFile, ev);
+-                    }
++                    this.DoAutoArchive(archiveFile, ev);
+                 }
+                 finally
+                 {","It seems ok. Because already created a file name at line 1815 and already checked if it is null or empty at line 1816. If file name is null, then already this line will not executed."
+7874,"@@ -71,8 +71,9 @@ public interface GenesisConfigOptions {
+
+   OptionalLong getLondonBlockNumber();
+
+-  // TODO EIP-1559 change for the actual fork name when known
+-  OptionalLong getAleutBlockNumber();
++  OptionalLong getArrowGlacierBlockNumber();
++
++  OptionalLong getBaseFeePerGas();
+
+   OptionalLong getEIP1559BlockNumber();
+ ",Can all the BaseFeePerGas methods that are added be removed? It's not needed for the bomb and not referenced anywhere else in this PR.
+7875,"@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
+ 	if docrootRelPath != """" {
+ 		app.Docroot = docrootRelPath
+ 		if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
+-			util.Failed(""The docroot provided (%v) does not exist"", docrootRelPath)
++			output.UserOut.Warnf(""Warning: the provided docroot at %s does not currently exist."", docrootRelPath)
+ 		}
+ 	} else if !cmd.Flags().Changed(""docroot"") {
+ 		app.Docroot = ddevapp.DiscoverDefaultDocroot(app)",util.Warning()? Easier to say.
+7876,"@@ -64,8 +64,6 @@ type (
+ 		rootHash  hash.Hash32B
+ 		toRoot    *list.List // stores the path from root to diverging node
+ 		bucket    string     // bucket name to store the nodes
+-		clpsK     []byte     // path if the node can collapse after deleting an entry
+-		clpsV     []byte     // value if the node can collapse after deleting an entry
+ 		numEntry  uint64     // number of entries added to the trie
+ 		numBranch uint64
+ 		numExt    uint64",these 2 no longer needed after refactor
+7877,"@@ -63,6 +63,8 @@ const (
+ 	SpecExportOptionsEmpty   = ""empty_export_options""
+ 	SpecMountOptions         = ""mount_options""
+ 	SpecCSIMountOptions      = ""csi_mount_options""
++	SpecCSIRawBlock			 = ""fadirectRawBlock""
++	SpecCSIFsType			 = ""fsType""
+ 	SpecSharedv4MountOptions = ""sharedv4_mount_options""
+ 	SpecProxyProtocolS3      = ""s3""
+ 	SpecProxyProtocolPXD     = ""pxd""","most spec options appear to be snake case - `fa_direct_raw_block`, let's stick to that convention"
+7878,"@@ -4,7 +4,6 @@ var globby = require('globby');
+ var WebDriver = require('selenium-webdriver');
+ var chrome = require('selenium-webdriver/chrome');
+ var chromedriver = require('chromedriver');
+-var isCI = require('is-ci');
+
+ var args = process.argv.slice(2);
+ ",Looks like we can then drop this dependency.
+7879,"@@ -667,6 +667,10 @@ class FlowMaster(controller.Master):
+             self.add_event(""Script error:\n"" + str(e), ""error"")
+         self.scripts.remove(script_obj)
+
++    def reload_scripts(self):
++        for s in self.scripts[:]:
++            s.load()
++
+     def load_script(self, command):
+         """"""
+             Loads a script. Returns an error description if something went","3) Subscribe to the script change signal in `FlowMaster.__init__`. The event handler should call `self.masterq.put((""script_change"", script))`. 4) Add a `handle_script_change` function, that once called, takes the script object and calls `script.reload()`."
+7880,"@@ -287,4 +287,13 @@ public class EmailMessage {
+
+     return this;
+   }
++
++  public String getBody() {
++    return _body.toString();
++  }
++
++  public String getSubject() {
++    return _subject;
++  }
++
+ }","This method is for unit testing only, right? How about making it package private? This way the readers would know that this is not a public API outside this package and would reduce the search space."
+7881,"@@ -0,0 +1 @@
++package project",accidental? i guess it's the same as any other boilerplate
+7882,"@@ -1,7 +1,10 @@
++from concurrent.futures import ThreadPoolExecutor, TimeoutError
+ from pyramid.security import NO_PERMISSION_REQUIRED
+
++from kinto import logger
+ from kinto.core import Service
+
++
+ heartbeat = Service(name=""heartbeat"", path='/__heartbeat__',
+                     description=""Server health"")
+ ","shadowing the builtin, let's use function or func or callable_"
+7883,"@@ -0,0 +1,8 @@
++# pylint: disable=missing-docstring,expression-not-assigned,too-few-public-methods,pointless-statement
++
++class Unhashable(object):
++    __hash__ = list.__hash__
++
++{}[[]] # [unhashable-dict-key]
++{}[{}] # [unhashable-dict-key]
++{}[Unhashable()] # [unhashable-dict-key]","Can you add some good examples, for instance integers, strings and whatnot?"
+7884,"@@ -1,3 +1,17 @@
++// Copyright © 2017-2019 The OpenEBS Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
+ package command
+
+ import (","Can we just have 2017 here @kmova if possible, as i seen in other projects as well( kubernetes etc..), they mentioned only the year when the file has been created."
+7885,"@@ -460,8 +460,7 @@ std::vector<DPFSubstring> DebugPrintf::ParseFormatString(const std::string forma
+
+ std::string DebugPrintf::FindFormatString(std::vector<unsigned int> pgm, uint32_t string_id) {
+     std::string format_string;
+-    SHADER_MODULE_STATE shader;
+-    shader.words = pgm;
++    SHADER_MODULE_STATE shader(pgm);
+     if (shader.words.size() > 0) {
+         for (const auto &insn : shader) {
+             if (insn.opcode() == spv::OpString) {","@Tony-LunarG I just realized that this differs from the previous behavior in that spirv-opt will run on the byte code if there are any ""group decorations."" If this is a problem, I can add an additional constructor to keep the pre-existing behavior."
+7886,"@@ -86,9 +86,9 @@ public class ParquetMetrics implements Serializable {
+           Types.NestedField field = fileSchema.asStruct().field(fieldId);
+           if (field != null && stats.hasNonNullValue()) {
+             updateMin(lowerBounds, fieldId,
+-                fromParquetPrimitive(field.type(), stats.genericGetMin()));
++              fromParquetPrimitive(field.type(), column.getPrimitiveType(), stats.genericGetMin()));
+             updateMax(upperBounds, fieldId,
+-                fromParquetPrimitive(field.type(), stats.genericGetMax()));
++              fromParquetPrimitive(field.type(), column.getPrimitiveType(), stats.genericGetMax()));
+           }
+         }
+       }",Nit: continuation lines should be indented 4 spaces from the start of the statement.
+7887,"@@ -487,6 +487,7 @@ int sysfs_finalize(void)
+ 		sysfs_region_destroy(&_regions[i]);
+ 	}
+ 	_sysfs_region_count = 0;
++	_sysfs_format_ptr = NULL;
+ 	return FPGA_OK;
+ }
+ ",Are these protected by any kind of lock?
+7888,"@@ -66,6 +66,7 @@ class FirewallRule(object):
+         self.resource_id = kwargs.get('id')
+         self.create_time = kwargs.get('firewall_rule_create_time')
+         self.name = kwargs.get('firewall_rule_name')
++        self.hierarchical_name = kwargs.get('firewall_rule_hierarchical_name')
+         self.kind = kwargs.get('firewall_rule_kind')
+         self.network = kwargs.get('firewall_rule_network')
+         self._priority = kwargs.get('firewall_rule_priority')","This should probably default to a string, as get_resource_ancestors is causing the tests to fail due to the rsplit on a None hierarchical_name."
+7889,"@@ -170,6 +170,7 @@ type ACMEChallengeSolverHTTP01Ingress struct {
+
+ 	// The ingress class to use when creating Ingress resources to solve ACME
+ 	// challenges that use this challenge solver.
++	// A reference by name to a Kubernetes [IngressClass](https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-class) object
+ 	// Only one of 'class' or 'name' may be specified.
+ 	Class *string
+ ","I prefer not to have markdown here, while it is nice for the site this is also shown for `kubectl explain` where this will look weird"
+7890,"@@ -26,7 +26,7 @@ describe('monitoring', function () {
+     mockServer.setMessageHandler(request => {
+       const doc = request.document;
+       if (doc.ismaster || doc.hello) {
+-        request.reply(Object.assign({}, mock.DEFAULT_ISMASTER));
++        request.reply(Object.assign({}, mock.DEFAULT_ISMASTER_36));
+       } else if (doc.endSessions) {
+         request.reply({ ok: 1 });
+       }",@durran Was this change intended to be included in this PR?
+7891,"@@ -110,7 +110,7 @@ namespace pwiz.SkylineTestFunctional
+                 Assert.AreEqual(z, key.Charge);
+                 Assert.AreEqual(adduct, key.Adduct);
+                 Assert.AreEqual(caffeineInChiKey, key.Target.ToString());
+-                var viewLibPepInfo = new ViewLibraryPepInfo(key);
++                var viewLibPepInfo = new ViewLibraryPepInfo(key, null);
+                 Assert.AreEqual(key, viewLibPepInfo.Key);
+                 var smallMolInfo = viewLibPepInfo.GetSmallMoleculeLibraryAttributes();
+                 Assert.AreEqual(moleculeName, smallMolInfo.MoleculeName);","Feels like this could have a default null value to remove the need for this explicit ""null"" use."
+7892,"@@ -145,12 +145,12 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error {
+
+ 	fs, err := s.createFilestore(ctx, cfg, t.Logger)
+ 	if err != nil {
+-		t.Logger.Error(""failed creating firestore"", zap.Error(err))
++		t.Logger.Error(""failed creating filestore"", zap.Error(err))
+ 		return err
+ 	}
+ 	defer func() {
+ 		if err := fs.Close(); err != nil {
+-			t.Logger.Error(""failed closing firestore client"", zap.Error(err))
++			t.Logger.Error(""failed closing filestore client"", zap.Error(err))
+ 		}
+ 	}()
+ ","""failed to create ..."""
+7893,"@@ -69,7 +69,7 @@ func PodCreator(fakeKubeClient kubernetes.Interface, podName string) {
+ 		}
+ 		_, err := fakeKubeClient.CoreV1().Pods(""openebs"").Create(podObjet)
+ 		if err != nil {
+-			glog.Errorf(""Fake pod object could not be created:"", err)
++			glog.Error(""Fake pod object could not be created:"", err)
+ 		}
+ 	}
+ }","No formatting directives, `glog.Error` will do just fine."
+7894,"@@ -34,7 +34,7 @@ module Selenium
+           driver.manage.timeouts.implicit_wait = 6
+
+           driver.find_element(id: 'adder').click
+-          driver.find_element(id: 'box0')
++          expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError)
+         end
+
+         it 'should still fail to find an element with implicit waits enabled' do",This should just be `.not_to raise_error` otherwise it potentially hides errors
+7895,"@@ -442,7 +442,18 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			log.WithError(err).Error(""Failed to connect to Typha. Retrying..."")
++			startTime := time.Now()
++			for err != nil && time.Since(startTime) < 30*time.Second {
++				// Set Ready to false and Live to true when unable to connect to typha
++				healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Debug(""Retrying to start Typha"")
++				time.Sleep(1 * time.Second)
++			}
++			if err != nil {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()",Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.
+7896,"@@ -10,17 +10,14 @@ declare(strict_types = 1);
+ namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute;
+
+ use Doctrine\DBAL\Connection;
++use Doctrine\DBAL\DBALException;
+ use Ergonode\Attribute\Domain\Event\Attribute\AttributeCreatedEvent;
+-use Ergonode\Core\Domain\Entity\AbstractId;
+-use Ergonode\EventSourcing\Infrastructure\DomainEventInterface;
+-use Ergonode\EventSourcing\Infrastructure\Exception\UnsupportedEventException;
+-use Ergonode\EventSourcing\Infrastructure\Projector\DomainEventProjectorInterface;
+ use JMS\Serializer\SerializerInterface;
+ use Ramsey\Uuid\Uuid;
+
+ /**
+  */
+-class AttributeCreatedEventProjector implements DomainEventProjectorInterface
++class AttributeCreatedEventProjector
+ {
+     private const TABLE = 'attribute';
+     private const TABLE_PARAMETER = 'attribute_parameter';",Separate it to different methods :D Invoke method look's like old fashion portal class :D
+7897,"@@ -11,11 +11,7 @@ import 'emby-button';
+         elem.classList.remove('hide');
+         elem.classList.add('expanded');
+         elem.style.height = 'auto';
+-        const height = elem.offsetHeight + 'px';
+-        elem.style.height = '0';
+-
+-        // trigger reflow
+-        const newHeight = elem.offsetHeight;
++        var height = elem.offsetHeight + 'px';
+         elem.style.height = height;
+
+         setTimeout(function () {",Collapse/expand animation of filter is broken - not smooth.
+7898,"@@ -16,16 +16,10 @@ module Travis
+           install_sdk_components(config[:android][:components]) unless config[:android][:components].empty?
+         end
+
+-        def install
+-          self.if   '-f gradlew',      './gradlew assemble', fold: 'install', retry: true
+-          self.elif '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
+-          self.elif '-f pom.xml',      'mvn install -DskipTests=true -B', fold: 'install', retry: true # Otherwise mvn install will run tests which. Suggestion from Charles Nutter. MK.
+-        end
+-
+         def script
+           self.if   '-f gradlew',      './gradlew check connectedCheck'
+           self.elif '-f build.gradle', 'gradle check connectedCheck'
+-          self.elif '-f pom.xml',      'mvn test -B'
++          self.elif '-f pom.xml',      'mvn install -B'
+           self.else                    'ant debug installt test'
+         end
+ ",so during the `script` stage we run `mvn install`?
+7899,"@@ -19,6 +19,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
++	""github.com/iotexproject/iotex-core/state/factory""
+ )
+
+ // protocolID is the protocol ID",we may need to move CandidateNamespace to this protocol as it is only used here.
+7900,"@@ -230,7 +230,12 @@ public class ExecutionControllerUtils {
+           continue;
+           // case UNKNOWN:
+         case READY:
+-          node.setStatus(Status.KILLING);
++          // if flow status is EXECUTION_STOPPED due to e.g. pod failure, set sub node to KILLED
++          if (exFlow.getStatus()==Status.EXECUTION_STOPPED) {
++            node.setStatus(Status.KILLED);
++          } else {
++            node.setStatus(Status.KILLING);
++          }
+           break;
+         default:
+           node.setStatus(Status.FAILED);","Just to confirm, this will take care of all the nodes in graph. right?"
+7901,"@@ -175,10 +175,16 @@ namespace TestPlatform.CrossPlatEngine.UnitTests.Hosting
+         public void GetTestHostProcessStartInfoShouldIncludeConnectionInfo()
+         {
+             var connectionInfo = new TestRunnerConnectionInfo { Port = 123 };
++            var parentProcessId = 101;
++
++            mockProcessHelper.Setup(ph => ph.GetCurrentProcessId()).Returns(parentProcessId);
+
+             var startInfo = this.dotnetHostManager.GetTestHostProcessStartInfo(this.testSource, null, connectionInfo);
+
+             StringAssert.Contains(startInfo.Arguments, ""--port "" + connectionInfo.Port);
++
++            StringAssert.Contains(startInfo.Arguments, string.Format(""{0} {1}"",  Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Constants.ParentProcessIdOption, parentProcessId));
++
+         }
+
+         [TestMethod]","nit: remove this line. All ""arrange"" may be in one code block."
+7902,"@@ -14,10 +14,17 @@ import (
+
+ 	""runtime""
+
++	""bytes""
+ 	""restic/debug""
+ 	""restic/fs""
+ )
+
++// Xattr is a tuple storing the xattr name and value.
++type Xattr struct {
++	XattrName  string `json:""xattrname""`
++	XattrValue []byte `json:""xattrvalue""`
++}
++
+ // Node is a file, directory or other item in a backup.
+ type Node struct {
+ 	Name       string      `json:""name""`","This name is not a good fit, what about `ExtendedAttribute`? Or even just `Attribute`?"
+7903,"@@ -0,0 +1,18 @@
++#include ""test_assert.h""
++
++int testing_fails = 0;
++
++void TestFail(const char *expval, const char *val, const char *exp,
++              const char *file, int line) {
++  TEST_OUTPUT_LINE(""VALUE: \""%s\"""", expval);
++  TEST_OUTPUT_LINE(""EXPECTED: \""%s\"""", val);
++  TEST_OUTPUT_LINE(""TEST FAILED: %s:%d, %s"", file, line, exp);
++  assert(0);
++  testing_fails++;
++}
++
++void TestEqStr(const char *expval, const char *val, const char *exp,
++               const char *file, int line) {
++  if (strcmp(expval, val) != 0) { TestFail(expval, val, exp, file, line); }
++}
++","lets keep our ""testing framework"" header only if possible. since there is an `assert(0)` in there, it is intended to halt on the first test failure."
+7904,"@@ -26,9 +26,8 @@ import (
+
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""
+-	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
++	""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/action/protocol/rolldpos""
+-	""github.com/iotexproject/iotex-core/action/protocol/vote""
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""",File is not `goimports`-ed (from `goimports`)
+7905,"@@ -104,7 +104,6 @@ public class TableMigrationUtil {
+                 .withMetrics(metrics)
+                 .withPartitionPath(partitionKey)
+                 .build();
+-
+           }).collect(Collectors.toList());
+     } catch (IOException e) {
+       throw new RuntimeException(""Unable to list files in partition: "" + partitionUri, e);",I was saving this white-space for my retirement :nit:
+7906,"@@ -133,6 +133,10 @@ module Blacklight::Controller
+     def discard_flash_if_xhr
+       flash.discard if request.xhr?
+     end
++    deprecation_deprecate discard_flash_if_xhr: ""Discarding flash messages on XHR requests is deprecated.
++      If you wish to continue this behavior, add this method to your ApplicationController with an
++      after_action :discard_flash_if_xhr filter. To disable this behavior now and remove this warning, add
++      a skip_after_action :discard_flash_if_xhr to your ApplicationController.""
+
+     ##
+     #","What if you don't want to continue with the behavior, but you just want the deprecation to go away? Should we add `skip_after_action :discard_flash_if_xhr`?"
+7907,"@@ -309,7 +309,7 @@ func (ws *workingSet) validateNonce(blk *block.Block) error {
+ 	}
+ 	// Verify each account's Nonce
+ 	for srcAddr, receivedNonces := range accountNonceMap {
+-		confirmedState, err := accountutil.AccountState(ws, srcAddr)
++		confirmedState, err := accountutil.AccountStateByHash160(ws, srcAddr)
+ 		if err != nil {
+ 			return errors.Wrapf(err, ""failed to get the confirmed nonce of address %s"", srcAddr)
+ 		}",change `accountNonceMap` to map[address.Address][]uint64
+7908,"@@ -38,6 +38,7 @@ public class GapicCodeGeneratorTest extends GapicTestBase2 {
+           .put(MainGapicProviderFactory.NODEJS, MainGapicProviderFactory.NODEJS)
+           .put(MainGapicProviderFactory.NODEJS_DOC, MainGapicProviderFactory.NODEJS)
+           .put(MainGapicProviderFactory.CSHARP, MainGapicProviderFactory.CSHARP)
++          .put(MainGapicProviderFactory.CLIENT_CONFIG, ""clientconfig"")
+           .build();
+
+   private final String apiName;","The `CLIENT_CONFIG` is ""client_config"" with underscore, so we can't reuse it in the second arg."
+7909,"@@ -62,6 +62,19 @@ func serviceLoggedIn(ctx context.Context, config Config, name string,
+ 		}
+ 	}
+
++	if adminFeatureList[session.UID] {
++		log.CDebugf(ctx, ""Enabling a dir op batch size of %d"",
++			bgFlushDirOpBatchSizeDefault)
++		// NOTE: This overrides any command-line parameter.  It only
++		// matters until we un-feature-flag this, I think it's ok for
++		// now.
++		config.SetBGFlushDirOpBatchSize(bgFlushDirOpBatchSizeDefault)
++	} else {
++		// TODO: let non-admins have a non-1 batch size once admins
++		// test it enough.
++		config.SetBGFlushDirOpBatchSize(1)
++	}
++
+ 	config.MDServer().RefreshAuthToken(ctx)
+ 	config.BlockServer().RefreshAuthToken(ctx)
+ 	config.KBFSOps().RefreshCachedFavorites(ctx)",Does this mean all admins get the default batch size (which is 20) no matter the value of `-sync-batch-size`? It seems the command line flag doesn't do anything then does it?
+7910,"@@ -35,8 +35,11 @@ class CurlDownloader implements DownloaderInterface
+      *
+      * @throws DownloaderException
+      */
+-    public function download(string $url, array $headers = []): string
++    public function download(string $url, array $headers = [], array $acceptedContentTypes = null): string
+     {
++        if (null !== $acceptedContentTypes) {
++            throw new DownloaderException('CurlDownloader not supported param `acceptedHeaderTypes`');
++        }
+         $ch = curl_init();
+         curl_setopt($ch, CURLOPT_HEADER, 0);
+         curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);",Set default value as empty array instead of null
+7911,"@@ -121,6 +121,10 @@ mainLoop:
+ 				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no link index."")
+ 				continue
+ 			}
++			if routeUpd.Dst == nil {
++				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no destination"")
++				continue
++			}
+
+ 			idx := routeUpd.LinkIndex
+ 			oldUpds := updatesByIfaceIdx[idx]",Would be good to UT this case
+7912,"@@ -40,7 +40,7 @@ namespace Ethereum.Blockchain.Test
+             {
+                 string expectedTypeName = ExpectedTypeName(directory);
+                 Type type = types.SingleOrDefault(t => string.Equals(t.Name, expectedTypeName, StringComparison.InvariantCultureIgnoreCase));
+-                if(type == null && directory != ""stEWASMTests"" && directory != ""runtimes"")
++                if(type == null && directory != ""stEWASMTests"" && directory != ""Specs"" && directory != ""runtimes"")
+                 {
+                     if (new DirectoryInfo(directory).GetFiles().Any(f => f.Name.Contains("".resources."")))
+                     {",this was updated after linking the latest ethereum/tests after a submodules recursive update
+7913,"@@ -13,6 +13,7 @@ import { Fragment } from './create-element';
+ export function Component(props, context) {
+ 	this.props = props;
+ 	this.context = context;
++	this.__data = {};
+ }
+
+ /**","Todo: find a way to only do this in one spot, ideally with defaults for the stuff we use"
+7914,"@@ -21,14 +21,19 @@ package org.apache.iceberg.parquet;
+
+ import java.io.File;
+ import java.io.IOException;
++import java.util.Map;
++
+ import org.apache.avro.generic.GenericData;
+ import org.apache.iceberg.Metrics;
+ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.TestMetrics;
+ import org.apache.iceberg.io.InputFile;
++import org.apache.parquet.hadoop.ParquetFileReader;
+ import org.junit.Rule;
+ import org.junit.rules.TemporaryFolder;
+
++import static org.apache.iceberg.Files.localInput;
++
+ /**
+  * Test Metrics for Parquet.
+  */","Imports should not have blank lines. Sorry there isn't a checkstyle rule running for this yet, we still need to update the build for this one."
+7915,"@@ -3096,6 +3096,8 @@ class Booster(object):
+         """"""Evaluate training or validation data.""""""
+         if data_idx >= self.__num_dataset:
+             raise ValueError(""Data_idx should be smaller than number of dataset"")
++        if callable(feval):
++            feval = [feval]
+         self.__get_eval_info()
+         ret = []
+         if self.__num_inner_eval > 0:",Please move this to L3115 to group the code logically - all code for `feval` in one place.
+7916,"@@ -103,7 +103,7 @@ import org.apache.tuweni.bytes.Bytes;
+ import org.apache.tuweni.bytes.Bytes32;
+
+ /** Provides EVMs supporting the appropriate operations for mainnet hard forks. */
+-abstract class MainnetEvmRegistries {
++public abstract class MainnetEvmRegistries {
+
+   static EVM frontier(final GasCalculator gasCalculator) {
+     final OperationRegistry registry = new OperationRegistry();",This was done to wrap the operation so it could be spied upon during testing. Likely needs to be undone once an alternative test is discovered.
+7917,"@@ -1062,7 +1062,7 @@ func nextReqFromMsg(msg []byte) (time.Time, int, bool, error) {
+ 		if err := json.Unmarshal(msg, &cr); err != nil {
+ 			return time.Time{}, -1, false, err
+ 		}
+-		return cr.Expires, cr.Batch, cr.NoWait, nil
++		return time.Now().Add(time.Duration(cr.Expires) * time.Millisecond), cr.Batch, cr.NoWait, nil
+ 	}
+ 	// Naked batch size here for backward compatibility.
+ 	bs := 1",I feel we need to impose a lower limit here maybe? What about a max and default for when none is set?
+7918,"@@ -245,7 +245,15 @@ func (cds *contentDirectoryService) Handle(action string, argsXML []byte, r *htt
+ 				""UpdateID"":       cds.updateIDString(),
+ 			}, nil
+ 		case ""BrowseMetadata"":
+-			result, err := xml.Marshal(obj)
++			node, err := cds.vfs.Stat(obj.Path)
++			if err != nil {
++				return nil, err
++			}
++			upnpObject, err := cds.cdsObjectToUpnpavObject(obj, node, host)
++			if err != nil {
++				return nil, err
++			}
++			result, err := xml.Marshal(upnpObject)
+ 			if err != nil {
+ 				return nil, err
+ 			}",ineffectual assignment to `err` (from `ineffassign`)
+7919,"@@ -37,8 +37,8 @@ type Replacer interface {
+ // they will be used to overwrite other replacements
+ // if there is a name conflict.
+ type replacer struct {
+-	replacements       map[string]string
+-	customReplacements map[string]string
++	replacements       map[string]func() string
++	customReplacements map[string]func() string
+ 	emptyValue         string
+ 	responseRecorder   *ResponseRecorder
+ }","Ahhh... this makes sense. Does using functions to defer evaluation of these values have anything to do with #916 (where the `Host: {host}` was 'cached' between different hostnames)? If not, could you help me understand what this change does?"
+7920,"@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
+     ownEventBase_ = false;
+   }
+
+-  if (listenSocket_ >= 0) {
++  if (listenSocket_ >= 0 && listenSocket_ != THRIFT_INVALID_SOCKET) {
+     if (0 != ::THRIFT_CLOSESOCKET(listenSocket_)) {
+       GlobalOutput.perror(""TNonblockingIOThread listenSocket_ close(): "", THRIFT_GET_SOCKET_ERROR);
+     }",Perhaps the only test needed is to see if the socket is not an invalid socket? Is the >= 0 test necessary at this point?
+7921,"@@ -20,7 +20,16 @@
+   </div>
+
+   <% if current_user.subscription && current_user.stripe_customer %>
+-    <%= render 'credit_card_form' %>
++    <div class='text-box'>
++      <%= semantic_form_for current_user.subscription, url: subscription_path(current_user.subscription) do |form| %>
++        <%= form.inputs ""Your Subscription Billing Info"", id: 'billing-information' do %>
++          <%= render 'shared/credit_card_form' %>
++        <% end %>
++        <%= form.actions do %>
++          <%= form.action :submit, label: 'Update Your Card' %>
++        <% end %>
++      <% end %>
++    </div>
+   <% end %>
+ </div>
+ ",Could this line use `url: current_user.subscription`?
+7922,"@@ -477,7 +477,7 @@ class Context
+             $quoted_remove_var_id = preg_quote($remove_var_id);
+
+             foreach ($clause->possibilities as $var_id => $_) {
+-                if (preg_match('/' . $quoted_remove_var_id . '[\]\[\-]/', $var_id)) {
++                if (preg_match('/' . preg_quote($quoted_remove_var_id, '/') . '[\]\[\-]/', $var_id)) {
+                     break 2;
+                 }
+             }",I was seeing `Warning: preg_match(): Unknown modifier 'a' in /path/to/project/vendor/vimeo/psalm/src/Psalm/Context.php on line 480` here
+7923,"@@ -1,10 +1,18 @@
+ package com.github.javaparser.ast.stmt;
+
++import com.github.javaparser.JavaParser;
++import com.github.javaparser.ParserConfiguration;
++import com.github.javaparser.StaticJavaParser;
+ import com.github.javaparser.ast.expr.Expression;
+ import com.github.javaparser.ast.expr.MethodCallExpr;
+ import com.github.javaparser.ast.expr.NameExpr;
++import com.github.javaparser.printer.lexicalpreservation.LexicalPreservingPrinter;
+ import org.junit.jupiter.api.Test;
+
++import static com.github.javaparser.StaticJavaParser.parse;
++import static com.github.javaparser.utils.TestUtils.assertEqualsNoEol;
++import static com.github.javaparser.utils.Utils.EOL;
++
+ class BlockStmtTest {
+     @Test
+     void issue748AddingIdenticalStatementsDoesParentingRight() {",The changes in this file are not necessary.
+7924,"@@ -1,6 +1,7 @@
+ package manager
+
+ import (
++	""github.com/kubeedge/kubeedge/pkg/apiserverlite/util""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/watch""
+ 	""k8s.io/klog/v2""",run `make lint` to fix
+7925,"@@ -0,0 +1,7 @@
++from dagster import execute_pipeline
++from docs_snippets.guides.dagster.reexecution.pipeline.unreliable_pipeline import unreliable_pipeline
++
++
++def test_pipeline_compiles_and_executes():
++    result = execute_pipeline(unreliable_pipeline)
++    assert result","we will need `assert result.success` instead. result will always be not null because it returns an execution result including several metadata - when the execution fails, it'd return an execution result whose `success` attribute is false."
+7926,"@@ -52,6 +52,8 @@ type CStorVolumeReplica struct {
+ type CStorVolumeReplicaSpec struct {
+ 	TargetIP string `json:""targetIP""`
+ 	Capacity string `json:""capacity""`
++	// ZvolWorkers represents number of threads that executes client IOs
++	ZvolWorkers string `json:""zvolWorkers""`
+ }
+
+ // CStorVolumeReplicaPhase is to hold result of action.",Can we mention how can one determine the best value given an infrastructure? Does it default to any value?
+7927,"@@ -1,4 +1,6 @@
+-<?php namespace Backend\Widgets;
++<?php
++
++namespace Backend\Widgets;
+
+ use Lang;
+ use Backend\Classes\WidgetBase;","Leave this formatting the way it was please, that's the standard across all of October's files."
+7928,"@@ -7,7 +7,7 @@ import (
+ 	""strings""
+
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+-	""github.com/opencontainers/runc/libcontainer/selinux""
++	selinux ""github.com/opencontainers/selinux/go-selinux""
+ )
+
+ type Validator interface {","@runcom says there is no need to use `selinux` here. `selinux` ""github.com/opencontainers/selinux/go-selinux"" The code should work fine without it."
+7929,"@@ -20,8 +20,8 @@ CREATE_PROJECT_TABLE = """"""
+         `project_number` bigint(20) NOT NULL,
+         `project_id` varchar(255) NOT NULL,
+         `project_name` varchar(255) DEFAULT NULL,
+-        `lifecycle_state` enum('ACTIVE','DELETE_REQUESTED',
+-            'DELETE_IN_PROGRESS','DELETED') DEFAULT NULL,
++        `lifecycle_state` enum('LIFECYCLE_STATE_UNSPECIFIED','ACTIVE',
++            'DELETE_REQUESTED','DELETED') NOT NULL,
+         `parent_type` varchar(255) DEFAULT NULL,
+         `parent_id` varchar(255) DEFAULT NULL,
+         `raw_project` json DEFAULT NULL,",nit: It might be worth defining these elsewhere as a python-type?
+7930,"@@ -151,6 +151,9 @@ public class Constants {
+      *    implies save latest 3 versions saved in storage.
+      **/
+     public static final String AZKABAN_STORAGE_ARTIFACT_MAX_RETENTION = ""azkaban.storage.artifact.max.retention"";
++
++    // enable Quartz Scheduler if true.
++    public static final String ENABLE_QUARTZ= ""enable.quartz"";
+   }
+
+   public static class FlowProperties {",prefix it with azkaban. Maybe azkaban.server.schedule.enable_quartz?
+7931,"@@ -145,6 +145,13 @@ module Bolt
+             end
+           rescue Bolt::Error => e
+             e
++          rescue Puppet::DataBinding::LookupError => e
++            if /Undefined variable/.match(e.message)
++              message = ""Interpolations are not supported in lookups outside of an apply block: #{e.message}""
++              PALError.new(message)
++            else
++              PALError.from_preformatted_error(e)
++            end
+           rescue Puppet::PreformattedError => e
+             PALError.from_preformatted_error(e)
+           rescue StandardError => e",It'd be nice if we also caught `Unknown variable $trusted / $server_facts / $settings::` here - while I highly doubt anyone is using them (and if they are they're surely misusing them) it'd be crazy-making to have a working plan suddenly start failing with no clue as to why.
+7932,"@@ -967,6 +967,11 @@ type serviceInfo struct {
+ 	onlyNodeLocalEndpoints   bool
+ }
+
++// TopologyKeys is part of ServicePort interface.
++func (info *serviceInfo) TopologyKeys() []string {
++	panic(""NOT IMPLEMENTED"")
++}
++
+ // String is part of ServicePort interface.
+ func (info *serviceInfo) String() string {
+ 	return fmt.Sprintf(""%s:%d/%s"", info.clusterIP, info.port, info.protocol)",Probably need to understand/implement this one now.
+7933,"@@ -91,8 +91,13 @@ public class JdbcDependencyManager {
+       while (rs.next()) {
+         // Columns are (starting at index 1): file_name, file_sha1, validation_status
+         Dependency d = hashAndFileNameToDep.remove(rs.getString(1) + rs.getString(2));
+-        FileValidationStatus v = FileValidationStatus.valueOf(rs.getInt(3));
+-        depValidationStatuses.put(d, v);
++
++        // HashMap.remove will return null if the key is not found, hence check for it before
++        // adding to depValidationStatuses.
++        if (d != null) {
++          FileValidationStatus v = FileValidationStatus.valueOf(rs.getInt(3));
++          depValidationStatuses.put(d, v);
++        }
+       }
+
+       // All remaining dependencies in the hashToDep map should be marked as being NEW (because they weren't",It will be better to add contains check for key in hashAndFileNameToDep instead of null check over here. All of these should be inside that contains if case.
+7934,"@@ -300,8 +300,18 @@ module Beaker
+           new_conf
+         end
+
++        # Restarts the named puppet service
++        #
++        # @param [Host] host Host the service runs on
++        # @param [String] service Name of the service to restart
++        # @param [Fixnum] curl_retries Number of times to retry the restart command
++        # @param [Fixnum] port Port to check status at
++        #
++        # @return [Result] Result of last status check
+         # @!visibility private
+-        def bounce_service host, service, curl_retries = 120
++        def bounce_service host, service, curl_retries = nil, port = nil
++          curl_retries = 120 if curl_retries.nil?
++          port = options[:puppetserver_port] if port.nil?
+           if host.graceful_restarts?
+             apachectl_path = host.is_pe? ? ""#{host['puppetsbindir']}/apache2ctl"" : 'apache2ctl'
+             host.exec(Command.new(""#{apachectl_path} graceful""))","perhaps these magic numbers could go into a Defaults module somewhere? 8140 implies the default is for puppet server. i guess that's somewhat reasonable. but if we're trying to decouple beaker from puppet, maybe this should be 80?"
+7935,"@@ -7595,6 +7595,13 @@ dr_prepopulate_cache(app_pc *tags, size_t tags_count)
+     return true;
+ }
+
++DR_API
++uint64
++dr_stats_get_built_blocks_count() {
++  return GLOBAL_STAT(num_bbs);
++}
++
++
+ /***************************************************************************
+  * PERSISTENCE
+  */",style violation: { on own line
+7936,"@@ -421,6 +421,10 @@ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *er
+                 goto AddHeaderDuped;
+             } else if (token == H2O_TOKEN_LINK) {
+                 h2o_push_path_in_link_header(req, headers[i].value, headers[i].value_len);
++            } else if (token == H2O_TOKEN_X_COMPRESS) {
++                req->compression_hint =
++                    h2o_strtosize(headers[i].value, headers[i].value_len) ? H2O_COMPRESS_HINT_ENABLE : H2O_COMPRESS_HINT_DISABLE;
++                goto Skip;
+             }
+         /* default behaviour, transfer the header downstream */
+         AddHeaderDuped:","Could we accept caseless strings (e.g. `off`, `on`, `auto`) instead of numbers to indicate the mode? Of course, we should use an enum internally (as we already do)."
+7937,"@@ -28,7 +28,8 @@ const Topic = ""/fil/msgs""
+ // Abstracts over a store of blockchain state.
+ type chainState interface {
+ 	GetHead() types.SortedCidSet
+-	GetTipSetAndState(tsKey types.SortedCidSet) (*chain.TipSetAndState, error)
++	GetTipSet(tsKey types.SortedCidSet) (*types.TipSet, error)
++	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ }
+
+ // BlockClock defines a interface to a struct that can give the current block height.","The sender doesn't use `GetTipSet`, so please remove it from this interface."
+7938,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.
+7939,"@@ -92,9 +92,9 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl {
+   public static final String DEFAULT_NSCD_SOCKET_HOST_PATH = ""/var/run/nscd/socket"";
+   public static final String HOST_PATH_TYPE = ""Socket"";
+   public static final String DEFAULT_NSCD_SOCKET_VOLUME_MOUNT_PATH = ""/var/run/nscd/socket"";
+-  public static final String DEFAULT_SECRET_NAME = ""azkaban-private-properties"";
++  public static final String DEFAULT_SECRET_NAME = ""azkaban-k8s-secret"";
+   public static final String DEFAULT_SECRET_VOLUME = DEFAULT_SECRET_NAME;
+-  public static final String DEFAULT_SECRET_MOUNTPATH = ""/var/azkaban/private/conf"";
++  public static final String DEFAULT_SECRET_MOUNTPATH = ""/var/azkaban/private"";
+
+
+   private final String namespace;",These configurations are currently overwritten in the props we provide in our config files. They need to be overridden there as well after you make this change.
+7940,"@@ -54,7 +54,12 @@ func PopulateMissingParameters(project *string, zone *string, region *string,
+
+ 	scratchBucketRegion := """"
+ 	if *scratchBucketGcsPath == """" {
+-		scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project)
++		fallbackZone := *zone
++		if fallbackZone == """" && mgce.OnGCE() {
++			// try to get zone which Cloud Build is running in, ignoring error
++			fallbackZone, _ = mgce.Zone()
++		}
++		scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project, fallbackZone)
+ 		scratchBucketRegion = sbr
+ 		if err != nil {
+ 			return err",Why is error ignored here?
+7941,"@@ -20,6 +20,8 @@ const (
+ 	PartitionFlagGrub PartitionFlag = ""grub""
+ 	// PartitionFlagBiosGrub indicates this is a bios grub boot partition
+ 	PartitionFlagBiosGrub PartitionFlag = ""bios_grub""
++	// PartitionFlagBiosGrubLegacy indicates this is a bios grub boot partition. Needed to preserve legacy config behavior.
++	PartitionFlagBiosGrubLegacy PartitionFlag = ""bios-grub""
+ 	// PartitionFlagBoot indicates this is a boot partition
+ 	PartitionFlagBoot PartitionFlag = ""boot""
+ 	// PartitionFlagDeviceMapperRoot indicates this partition will be used for a device mapper root device",">PartitionFlagBiosGrubLegacy PartitionFlag = ""bios-grub"" [](start = 1, length = 55) I presume this is to fix a breaking change...and it's too late to fix the breaking change (since it already escaped into the world?)"
+7942,"@@ -159,7 +159,7 @@ public class ScanSummary {
+       removeTimeFilters(filters, Expressions.rewriteNot(scan.filter()));
+       Expression rowFilter = joinFilters(filters);
+
+-      Iterable<ManifestFile> manifests = table.currentSnapshot().manifests();
++      Iterable<ManifestFile> manifests = table.currentSnapshot().dataManifests();
+
+       boolean filterByTimestamp = !timeFilters.isEmpty();
+       Set<Long> snapshotsInTimeRange = Sets.newHashSet();",Is this explicitly ignoring the effect of deleted rows on partition metrics or is it just that you are short circuiting any delete files (as we can't use them anyways)
+7943,"@@ -149,6 +149,12 @@ namespace Microsoft.DotNet.Execute
+         private string BuildParametersForCommand(Dictionary<string, string> commandParameters, string toolName)
+         {
+             string commandSetting = string.Empty;
++
++            if (Tools.ContainsKey(toolName))
++            {
++                commandSetting = Tools[toolName].osSpecific[Os][""defaultParameters""];
++            }
++
+             foreach (KeyValuePair<string, string> parameters in commandParameters)
+             {
+                 if (!parameters.Key.Equals(""toolName"") && !string.IsNullOrEmpty(parameters.Value))","I would also check whether or not this ""defaultParameters"" is null or empty to allow for people to omit it from the config file."
+7944,"@@ -170,5 +170,5 @@ func (event *Event) IsToEdge() bool {
+
+ // GetContent dumps the content to string
+ func (event *Event) GetContent() string {
+-	return fmt.Sprintf(""%v"", event.Content)
++	return fmt.Sprintf(""%s"", event.Content)
+ }","I think event.Content is of type interface{}, so we may need %v here?"
+7945,"@@ -17,10 +17,12 @@
+ # along with Invenio; if not, write to the Free Software Foundation, Inc.,
+ # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+
++""""""Legacy BibEdit.""""""
++
+ import warnings
+
+-from invenio.utils.deprecation import RemovedInInvenio22Warning
++from invenio.utils.deprecation import RemovedInInvenio23Warning
+
+-warnings.warn(""BibEdit will be removed in 2.2. Please check ""
++warnings.warn(""Legacy BibEdit will be removed in 2.3. Please check ""
+               ""'invenio.modules.editor' module."",
+-              RemovedInInvenio22Warning)
++              RemovedInInvenio23Warning)",Note: `editor` depends on legacy `BibEdit`
+7946,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.
+7947,"@@ -2608,3 +2608,16 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
+         self.assertRaises(
+             ValueError, lambda: kdf.groupby([(""B"", ""class""), (""A"", ""name"")]).get_group(""mammal"")
+         )
++
++    def test_median(self):
++        kdf = ks.DataFrame(
++            {
++                ""a"": [1.0, 1.0, 1.0, 1.0, 2.0, 2.0, 2.0, 3.0, 3.0, 3.0],
++                ""b"": [2.0, 3.0, 1.0, 4.0, 6.0, 9.0, 8.0, 10.0, 7.0, 5.0],
++                ""c"": [3.0, 5.0, 2.0, 5.0, 1.0, 2.0, 6.0, 4.0, 3.0, 6.0],
++            },
++            columns=[""a"", ""b"", ""c""],
++            index=[7, 2, 4, 1, 3, 4, 9, 10, 5, 6],
++        )
++        with self.assertRaisesRegex(ValueError, ""accuracy must be an integer; however""):
++            kdf.groupby(""a"").median(accuracy=""a"")",I'm wondering if a positive test case is needed here? Then we might compare the result DataFrame with a pre-created Koalas DataFrame.
+7948,"@@ -328,9 +328,9 @@ public interface Value<T> extends Iterable<T> {
+     }
+
+     /**
+-     * Checks, this {@code Value} is empty, i.e. if the underlying value is absent.
++     * Checks whether this {@code Value} is empty, i.e. if the underlying value is absent.
+      *
+-     * @return false, if no underlying value is present, true otherwise.
++     * @return true, if no underlying value is present, false otherwise.
+      */
+     boolean isEmpty();
+ ",I think it was reversed
+7949,"@@ -12,14 +12,10 @@ public class ASTJspDirective extends AbstractJspNode {
+      */
+     private String name;
+
+-    public ASTJspDirective(int id) {
++    ASTJspDirective(int id) {
+         super(id);
+     }
+
+-    public ASTJspDirective(JspParser p, int id) {
+-        super(p, id);
+-    }
+-
+     /**
+      * @return Returns the name.
+      */","The setter ""setName"" can be package-private as well"
+7950,"@@ -30,7 +30,7 @@ void AdamSolver<Dtype>::ComputeUpdateValue(int param_id, Dtype rate) {
+   Blob<Dtype>* val_v = this->history_[param_id + update_history_offset].get();
+   Blob<Dtype>* val_t = this->temp_[param_id].get();
+
+-  const int t = this->iter_  + 1;
++  const int t = this->iter_ + 1;
+   const Dtype correction = std::sqrt(Dtype(1) - pow(beta2, t)) /
+       (Dtype(1.) - pow(beta1, t));
+   const int N = net_params[param_id]->count();","Not sure if this is intentional or snuck in through find/replace; while this is a correct style fix (and is welcome in another PR), it should not be done here so that the commit maintains a logical changeset."
+7951,"@@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
+   BOOST_CHECK_NO_THROW(buf2.write((const uint8_t*)""bar"", 3));
+ }
+
++#ifndef _WIN32
++// We can't allocate 1 GB of memory in 32-bit environments.
++BOOST_AUTO_TEST_CASE(test_over_two_gb) {
++  TMemoryBuffer buf;
++  std::vector<uint8_t> small_buff(1);
++  std::vector<uint8_t> one_gb(1073741824);
++
++  buf.write(&small_buff[0], small_buff.size());
++  buf.write(&one_gb[0], one_gb.size());
++  BOOST_CHECK_THROW(buf.write(&one_gb[0], one_gb.size()), TTransportException);
++}
++#endif
++
+ BOOST_AUTO_TEST_SUITE_END()","This makes me wonder if the TBufferTransport should have a size limit that is configurable, with a default of INT32_MAX, and then the test can make a smaller one like 4KB, and write 4KB and then one byte more, instead of using up 2GB of memory."
+7952,"@@ -255,6 +255,8 @@ public class ApiMethodTransformer {
+     methodViewBuilder.stubName(namer.getStubName(context.getTargetInterface()));
+     methodViewBuilder.settingsGetterName(namer.getSettingsFunctionName(context.getMethod()));
+     methodViewBuilder.callableName(context.getNamer().getCallableName(context.getMethod()));
++    methodViewBuilder.isRequestStreaming(context.getMethod().getRequestStreaming());
++    methodViewBuilder.isResponseStreaming(context.getMethod().getResponseStreaming());
+   }
+
+   private void setListMethodFields(","If you use an enum for the streaming type, you wouldn't need to add each boolean as a separate attribute."
+7953,"@@ -98,6 +98,7 @@ from invenio.utils.serializers import serialize_via_marshal, \
+     deserialize_via_marshal
+
+ from sqlalchemy.exc import DatabaseError
++from MySQLdb import IntegrityError
+
+ from .engine_utils import get_index_id_from_index_name
+ ",can you check if you can use `sqlalchemy.exc.IntegrityError` instead?
+7954,"@@ -144,7 +144,7 @@ void JobManager::scheduleThread() {
+
+ // @return: true if all task dispatched, else false
+ bool JobManager::runJobInternal(const JobDescription& jobDesc, JbOp op) {
+-  std::lock_guard<std::mutex> lk(muJobFinished_);
++  std::lock_guard<std::recursive_mutex> lk(muJobFinished_);
+   std::unique_ptr<JobExecutor> je =
+       JobExecutorFactory::createJobExecutor(jobDesc, kvStore_, adminClient_);
+   JobExecutor* jobExec = je.get();",Why we need to use recursive_mutex here?
+7955,"@@ -68,8 +68,7 @@ var _ = framework.CertManagerDescribe(""ACME Certificate (HTTP01)"", func() {
+ 	validations := f.Helper().ValidationSetForUnsupportedFeatureSet(unsupportedFeatures)
+
+ 	BeforeEach(func() {
+-		acmeIssuer := util.NewCertManagerACMEIssuer(issuerName, f.Config.Addons.ACMEServer.URL, testingACMEEmail, testingACMEPrivateKey)
+-		acmeIssuer.Spec.ACME.Solvers = []cmacme.ACMEChallengeSolver{
++		solvers := []cmacme.ACMEChallengeSolver{
+ 			{
+ 				HTTP01: &cmacme.ACMEChallengeSolverHTTP01{
+ 					Ingress: &cmacme.ACMEChallengeSolverHTTP01Ingress{","am I correct these changes are related to: > I have removed a bunch of legacy functions for issuer generation ... if so, I can see why that's a valuable change but this is already a pretty huge PR and these changes to use `gen` here feel quite distant from the goal of this specific PR; they should maybe be in their own PR, to make everything easier to review? or have I missed how these changes are linked to this PR?"
+7956,"@@ -19,8 +19,10 @@ package org.openqa.selenium.grid.graphql;
+
+ import com.google.common.base.Suppliers;
+ import com.google.common.collect.ImmutableList;
++
+ import org.openqa.selenium.grid.data.DistributorStatus;
+ import org.openqa.selenium.grid.distributor.Distributor;
++import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.internal.Require;
+
+ import java.net.URI;",I think that this is an unused import
+7957,"@@ -328,7 +328,7 @@ public class DdiExportUtil {
+
+     private static void writeVersionStatement(XMLStreamWriter xmlw, DatasetVersionDTO datasetVersionDTO) throws XMLStreamException{
+         xmlw.writeStartElement(""verStmt"");
+-        writeAttribute(xmlw,""source"",""DVN"");
++        writeAttribute(xmlw,""source"",""producer"");
+         xmlw.writeStartElement(""version"");
+         writeAttribute(xmlw,""date"", datasetVersionDTO.getReleaseTime().substring(0, 10));
+         writeAttribute(xmlw,""type"", datasetVersionDTO.getVersionState().toString()); ","The string ""DVN_3_0"" appears in `if (!SOURCE_DVN_3_0.equals(xmlr.getAttributeValue(null, ""source""))) {` in ImportDDIServiceBean. It's not an exact match so I don't *think* this will break dataset import from DDI but I thought I'd at least mention it."
+7958,"@@ -361,6 +361,15 @@ func (s *svc) CompareCommits(ctx context.Context, ref *RemoteRef, compareSHA str
+ 	}, nil
+ }
+
++func (s *svc) ListCommitsViaComparison(ctx context.Context, ref *RemoteRef, compareSHA string) ([]*githubv3.RepositoryCommit, error) {
++	comp, _, err := s.rest.Repositories.CompareCommits(ctx, ref.RepoOwner, ref.RepoName, compareSHA, ref.Ref)
++	if err != nil {
++		return nil, fmt.Errorf(""could not get commits from comparison for %s and %s. %+v"", ref.Ref, compareSHA, err)
++	}
++
++	return comp.Commits, nil
++}
++
+ type Commit struct {
+ 	Files     []*githubv3.CommitFile
+ 	Message   string","Can you add docstring to this? Also, this might be a nit but I think `CompareCommits` or `CommitRange` might be a better name. What do you think?"
+7959,"@@ -33,6 +33,11 @@ import (
+
+ func (current *PullSubscription) Validate(ctx context.Context) *apis.FieldError {
+ 	errs := current.Spec.Validate(ctx).ViaField(""spec"")
++
++	if apis.IsInUpdate(ctx) {
++		original := apis.GetBaseline(ctx).(*PullSubscription)
++		errs = errs.Also(current.CheckImmutableFields(ctx, original))
++	}
+ 	return duck.ValidateAutoscalingAnnotations(ctx, current.Annotations, errs)
+ }
+ ","were all these ones missed in the previous PR so you are adding them now? the sources v1 and some of this? Is that right? If so, can you update the PR title"
+7960,"@@ -124,7 +124,10 @@ public final class SegmentInfos implements Cloneable, Iterable<SegmentCommitInfo
+   public static final int VERSION_72 = 8;
+   /** The version that recorded softDelCount */
+   public static final int VERSION_74 = 9;
+-  static final int VERSION_CURRENT = VERSION_74;
++  /** The version that recorded nextWriteDocValuesGen */
++  public static final int VERSION_77 = 10;
++
++  static final int VERSION_CURRENT = VERSION_77;
+
+   /** Used to name new segments. */
+   public long counter;",hmm should this be `VERSION_81` instead?
+7961,"@@ -50,7 +50,9 @@ const (
+ 	pendingDeltasFlushThreshold = 128
+ 	// trieRebuildAccountChunkSize defines the number of accounts that would get read at a single chunk
+ 	// before added to the trie during trie construction
+-	trieRebuildAccountChunkSize = 512
++	trieRebuildAccountChunkSize = 16384
++	// trieRebuildCommitFrequency defines the number of accounts that would get added before we call evict to commit the changes and adjust the memory cache.
++	trieRebuildCommitFrequency = 65536
+ 	// trieAccumulatedChangesFlush defines the number of pending changes that would be applied to the merkle trie before
+ 	// we attempt to commit them to disk while writing a batch of rounds balances to disk.
+ 	trieAccumulatedChangesFlush = 256",What is the reason for increasing this?
+7962,"@@ -153,7 +153,9 @@ module.exports = class Transloadit extends Plugin {
+     // Add Assembly-specific Tus endpoint.
+     const tus = {
+       ...file.tus,
+-      endpoint: status.tus_url
++      endpoint: status.tus_url,
++      // Include X-Request-ID headers for better debugging.
++      addRequestId: true
+     }
+
+     // Set Companion location. We only add this, if 'file' has the attribute","is there any reason we are not adding this to companion as well?   There are no CORS concerns there, so adding probably shouldn't be a problem, no? **One question about the requestId;** Are the request Ids unique to each tus-js-client request, or are they unique to an upload instance instead?"
+7963,"@@ -76,6 +76,8 @@ public final class CsrfConfigurer<H extends HttpSecurityBuilder<H>> extends Abst
+     private CsrfTokenRepository csrfTokenRepository = new HttpSessionCsrfTokenRepository();
+     private RequestMatcher requireCsrfProtectionMatcher = CsrfFilter.DEFAULT_CSRF_MATCHER;
+     private List<RequestMatcher> ignoredCsrfProtectionMatchers = new ArrayList<RequestMatcher>();
++	private String cookieName;
++	private String cookiePath;
+
+     /**
+      * Creates a new instance",The formatting is a little off here.
+7964,"@@ -263,7 +263,7 @@ public class TestCustomFunctions extends LuceneTestCase {
+     PrintWriter pw = new PrintWriter(sw);
+     expected.printStackTrace(pw);
+     pw.flush();
+-    assertTrue(sw.toString().contains(""JavascriptCompiler$CompiledExpression.evaluate("" + source + "")""));
++    assertTrue(sw.toString(), sw.toString().contains(""JavascriptCompiler$CompiledExpression.evaluate("" + source + "")""));
+   }
+
+   /** test that namespaces work with custom expressions. */",Perhaps we should import assertj for tests. These assertions are so much cleaner with assertj. Don't know whether hamcrest equivalent exist (maybe it does).
+7965,"@@ -2449,16 +2449,9 @@ void ProtocolGame::sendAddCreature(const Creature* creature, const Position& pos
+ 		sendMagicEffect(pos, CONST_ME_TELEPORT);
+ 	}
+
+-	sendInventoryItem(CONST_SLOT_HEAD, player->getInventoryItem(CONST_SLOT_HEAD));
+-	sendInventoryItem(CONST_SLOT_NECKLACE, player->getInventoryItem(CONST_SLOT_NECKLACE));
+-	sendInventoryItem(CONST_SLOT_BACKPACK, player->getInventoryItem(CONST_SLOT_BACKPACK));
+-	sendInventoryItem(CONST_SLOT_ARMOR, player->getInventoryItem(CONST_SLOT_ARMOR));
+-	sendInventoryItem(CONST_SLOT_RIGHT, player->getInventoryItem(CONST_SLOT_RIGHT));
+-	sendInventoryItem(CONST_SLOT_LEFT, player->getInventoryItem(CONST_SLOT_LEFT));
+-	sendInventoryItem(CONST_SLOT_LEGS, player->getInventoryItem(CONST_SLOT_LEGS));
+-	sendInventoryItem(CONST_SLOT_FEET, player->getInventoryItem(CONST_SLOT_FEET));
+-	sendInventoryItem(CONST_SLOT_RING, player->getInventoryItem(CONST_SLOT_RING));
+-	sendInventoryItem(CONST_SLOT_AMMO, player->getInventoryItem(CONST_SLOT_AMMO));
++	for (int i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) {
++		sendInventoryItem((slots_t)i, player->getInventoryItem((slots_t)i));
++	}
+
+ 	sendStats();
+ 	sendSkills();",You should use C++-type casts instead.
+7966,"@@ -865,7 +865,12 @@ func (d *cassandraPersistence) UpdateShard(
+ }
+ func (d *cassandraPersistence) CreateWorkflowExecution(
+ 	request *p.InternalCreateWorkflowExecutionRequest,
+-) (*p.CreateWorkflowExecutionResponse, error) {
++) (*p.InternalCreateWorkflowExecutionResponse, error) {
++	for _, req := range request.NewWorkflowNewEvents {
++		if err := d.AppendHistoryNodes(req); err != nil {
++			return nil, err
++		}
++	}
+
+ 	batch := d.session.NewBatch(gocql.LoggedBatch)
+ ",Looks like each AppendHistoryNodes is its own transaction - what happens if `len(request.NewWorkflowNewEvents) == 5` but we only succeed in writing 3 of them? Will the system be able to pick up from there later? I'm _guessing_ the answer is related to the `ON CONFLICT` and `INSERT IGNORE` changes below? What does Cassandra do?
+7967,"@@ -107,7 +107,12 @@ func (s *SVIDStoreService) deleteSVID(ctx context.Context, log logrus.FieldLogge
+ 		return false
+ 	}
+
+-	log = log.WithField(telemetry.SVIDStore, storeName)
++	log = log.WithFields(logrus.Fields{
++		telemetry.SVIDStore: storeName,
++		telemetry.Entry:     entry.EntryId,
++		telemetry.SPIFFEID:  entry.SpiffeId,
++	})
++
+ 	svidStore, ok := s.cat.GetSVIDStoreNamed(storeName)
+ 	if !ok {
+ 		log.Error(""Error deleting SVID: SVIDStore not found"")",why are you replacing log here? it is defined above and contains EntryID and SPIFFEID
+7968,"@@ -34,11 +34,17 @@ type Command struct {
+ 	vpnServerFactory func(sessionManager session.Manager, serviceLocation dto_discovery.Location,
+ 		providerID identity.Identity, callback state.Callback) *openvpn.Server
+
+-	vpnServer *openvpn.Server
++	vpnServer          *openvpn.Server
++	openvpnBinaryCheck func() error
+ }
+
+ // Start starts server - does not block
+ func (cmd *Command) Start() (err error) {
++	err = cmd.openvpnBinaryCheck()
++	if err != nil {
++		return err
++	}
++
+ 	providerID, err := cmd.identityLoader()
+ 	if err != nil {
+ 		return err",Why not `checkOpenvpn` as in client command?
+7969,"@@ -1,6 +1,11 @@
+ /*global mocha, console */
+ (function() {
+ 	'use strict';
++
++	if (!mocha || !mocha.reporter || !mocha.reporter('base')) {
++		return;
++	}
++
+ 	var Base = mocha.reporter('base')._reporter;
+ 	mocha.reporter(function(runner) {
+ 		Base.call(this, runner);",> Note: Non-headless tests (that run on selenium-webdriver) need to wire up to mocha reporter to collect all the results and report them. (See `test-webdriver.js`). But for other tests this can be skipped.
+7970,"@@ -241,8 +241,8 @@ class Pathoc(tcp.TCPClient):
+
+     def http_connect(self, connect_to):
+         self.wfile.write(
+-            'CONNECT %s:%s HTTP/1.1\r\n' % tuple(connect_to) +
+-            '\r\n'
++            b'CONNECT %s:%d HTTP/1.1\r\n' % (connect_to[0].encode(), connect_to[1]) +
++            b'\r\n'
+         )
+         self.wfile.flush()
+         try:",I think we should apply IDNA encoding for the host here.
+7971,"@@ -10127,8 +10127,10 @@ void Client::Handle_OP_PetCommands(const EQApplicationPacket *app)
+
+ 		mypet->SayString(this, Chat::PetResponse, PET_GETLOST_STRING);
+ 		mypet->CastToNPC()->Depop();
++		this->Save(1);
+
+ 		//Oddly, the client (Titanium) will still allow ""/pet get lost"" command despite me adding the code below. If someone can figure that out, you can uncomment this code and use it.
++		// on live since aa merging to companions discipline /pet get lost is available without any aa requirement.
+ 		/*
+ 		if((mypet->GetPetType() == petAnimation && GetAA(aaAnimationEmpathy) >= 2) || mypet->GetPetType() != petAnimation) {
+ 		mypet->SayString(PET_GETLOST_STRING);",No need to use `this->` here
+7972,"@@ -151,6 +151,7 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c
+ 		statusModified = true
+ 	}
+
++	completed = controllerutils.FindClusterDeploymentCondition(conditions, hivev1.ClusterInstallCompletedClusterDeploymentCondition)
+ 	if completed.Status == corev1.ConditionTrue { // the cluster install is complete
+ 		cd.Spec.Installed = true
+ 		cd.Status.InstalledTimestamp = &completed.LastTransitionTime","I can't quite tell, is there a reason why we're finding this condition again when it was done a few lines above? Or was this a mistaken paste?"
+7973,"@@ -22,7 +22,7 @@
+ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ // THE SOFTWARE.
+
+-//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination namespaceCache_mock.go
++//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination cache_mock.go
+
+ package namespace
+ ","doh. My fault, sorry."
+7974,"@@ -80,3 +80,11 @@ func conditionIsProvider1(provider market.ServiceProposal) bool {
+ func conditionIsStreaming(provider market.ServiceProposal) bool {
+ 	return provider.ServiceType == ""streaming""
+ }
++
++func fieldID(proposal market.ServiceProposal) interface{} {
++	return proposal.ID
++}
++
++func fieldProviderID(proposal market.ServiceProposal) interface{} {
++	return proposal.ProviderID
++}",Why do we returning `interface{}` here? Don't we have a predefined type for `ID`?
+7975,"@@ -34,9 +34,12 @@ import MiniChart from 'GoogleComponents/mini-chart';
+  */
+ import { trafficSourcesReportDataDefaults } from '../util';
+
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component, Fragment } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component, Fragment } from '@wordpress/element';
+
+ class AnalyticsDashboardWidgetTopAcquisitionSources extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies
+7976,"@@ -8,6 +8,8 @@ import (
+ 	""context""
+ 	""flag""
+ 	""fmt""
++	""github.com/rclone/rclone/fs/config/provider/goconfig""
++	""github.com/rclone/rclone/fs/config/provider/viper""
+ 	""io""
+ 	""io/ioutil""
+ 	""log""",File is not `goimports`-ed (from `goimports`)
+7977,"@@ -96,6 +96,11 @@ class InteropServiceHelper {
+ 	}
+
+ 	static async defaultFilename(noteIds, fileExtension) {
++		// Use of == here is because noteIds is potentiall undefined
++		if (noteIds == null) {
++			return '';
++		}
++
+ 		const note = await Note.load(noteIds[0]);
+ 		// In a rare case the passed not will be null, use the id for filename
+ 		if (note === null) {",Not sure why you want to make the distinction between null and undefined? And also `null == undefined` anyway so I think you could simply have `!noteIds` here.
+7978,"@@ -21,6 +21,15 @@
+ package http
+
+ const (
++	// ApplicationHeaderPrefix is the prefix added to application headers over
++	// the wire.
++	ApplicationHeaderPrefix = ""Rpc-Header-""
++
++	// ContextHeaderPrefix is the prefix added to context headers over the wire.
++	ContextHeaderPrefix = ""Context-""
++
++	// TODO(abg): Allow customizing header prefixes
++
+ 	// CallerHeader is the HTTP header used to indiate the service doing the calling
+ 	CallerHeader = ""Rpc-Caller""
+ ",Almost makes me wonder if this should default to Rpc-Context so everything defaults under Rpc-
+7979,"@@ -26,7 +26,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""
+-	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
++	""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/action/protocol/execution/evm""
+ 	""github.com/iotexproject/iotex-core/action/protocol/poll""
+ 	""github.com/iotexproject/iotex-core/action/protocol/rewarding""",File is not `goimports`-ed (from `goimports`)
+7980,"@@ -317,8 +317,16 @@ func (mset *Stream) AddConsumer(config *ConsumerConfig) (*Consumer, error) {
+ 		}
+ 	}
+
+-	// Check for any limits.
+-	if mset.config.MaxConsumers > 0 && len(mset.consumers) >= mset.config.MaxConsumers {
++	// Check for any limits, if the config for the consumer sets a limit we check against that
++	// but if not we use the value from account limits, if account limits is more restrictive
++	// than stream config we prefer the account limits to handle cases where account limits are
++	// updated during the lifecycle of the stream
++	maxc := mset.config.MaxConsumers
++	if mset.config.MaxConsumers <= 0 || mset.jsa.limits.MaxConsumers < mset.config.MaxConsumers {
++		maxc = mset.jsa.limits.MaxConsumers
++	}
++
++	if maxc > 0 && len(mset.consumers) >= maxc {
+ 		mset.mu.Unlock()
+ 		return nil, fmt.Errorf(""maximum consumers limit reached"")
+ 	}",would these require any account lock here?
+7981,"@@ -142,7 +142,7 @@ class RemoteConnection(object):
+         :Returns:
+         Timeout value in seconds for all http requests made to the Remote Connection
+         """"""
+-        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout
++        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT else cls._timeout
+
+     @classmethod
+     def set_timeout(cls, timeout):",The else doesn't return anything?
+7982,"@@ -112,6 +112,7 @@ function TransactionBuilder(opts) {
+   if (opts.fee || opts.feeSat) {
+     this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
+   }
++  if (opts.fee == 0 || opts.feeSat == 0) this.givenFeeSat = 0;
+   this.remainderOut = opts.remainderOut;
+   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
+ ",if (typeof (opts.fee) !== 'undefined' || typeof (opts.feeSat) !=='undefined') {
+7983,"@@ -38,7 +38,13 @@ type Device struct {
+ }
+
+ func (d *Device) CgroupString() string {
+-	return fmt.Sprintf(""%c %s:%s %s"", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), d.Permissions)
++	var p string
++	if d.Permissions == """" {
++		p = ""rwm"" // empty permissions is invalid... causes a write invalid argument error upon saving to cgroups
++	} else {
++		p = d.Permissions
++	}
++	return fmt.Sprintf(""%c %s:%s %s"", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), p)
+ }
+
+ func (d *Device) Mkdev() int {",I not sure we need to change this method's logic. Isn't no perms and invalid config?
+7984,"@@ -23,7 +23,7 @@ const (
+ 	protocolName    = ""hive""
+ 	protocolVersion = ""1.0.0""
+ 	peersStreamName = ""peers""
+-	messageTimeout  = 5 * time.Second // maximum allowed time for a message to be read or written.
++	messageTimeout  = 1 * time.Minute // maximum allowed time for a message to be read or written.
+ 	maxBatchSize    = 50
+ )
+ ",this is an abysmal amount of time. can you explain under which circumstances you should wait for a minute for a message?
+7985,"@@ -342,6 +342,8 @@ func (o *deployJobOpts) runtimeConfig(addonsURL string) (*stack.RuntimeConfig, e
+ 		AddonsTemplateURL:        addonsURL,
+ 		AdditionalTags:           tags.Merge(o.targetApp.Tags, o.resourceTags),
+ 		ServiceDiscoveryEndpoint: endpoint,
++		AccountID:                o.targetApp.AccountID,
++		Region:                   o.targetEnvironment.Region,
+ 	}, nil
+ }
+ ",Can we add this code to `job_package.go` and `svc_package.go`?
+7986,"@@ -273,7 +273,9 @@ func CreatePhysicalNode(id NodeID, spec PhysicalProcedureSpec) *PhysicalPlanNode
+ 	}
+ }
+
+-const NextPlanNodeIDKey = ""NextPlanNodeID""
++type nodeIDKey string
++
++const NextPlanNodeIDKey nodeIDKey = ""NextPlanNodeID""
+
+ func CreateUniquePhysicalNode(ctx context.Context, prefix string, spec PhysicalProcedureSpec) *PhysicalPlanNode {
+ 	if value := ctx.Value(NextPlanNodeIDKey); value != nil {","While you're here, can you change the casing on this so it is unexported? `nextPlanNodeIDKey` instead."
+7987,"@@ -1,4 +1,5 @@
+-// +build proto
++// +build !bootstrap
++
+ // Contains functions related to dispatching work to remote processes.
+ // Right now those processes must be on the same box because they use
+ // the local temporary directories, but in the future this might form","thanks for tidying all these up, as you can tell they've been used pretty arbitrarily in the past to just exclude things from bootstrap..."
+7988,"@@ -204,7 +204,7 @@ class Renderer(Exporter):
+             if (((len(plot) == 1 and not plot.dynamic)
+                 or (len(plot) > 1 and self.holomap is None) or
+                 (plot.dynamic and len(plot.keys[0]) == 0)) or
+-                not unbound_dimensions(plot.streams, plot.dimensions)):
++                not unbound_dimensions(plot.streams, plot.dimensions, False)):
+                 fmt = fig_formats[0] if self.fig=='auto' else self.fig
+             else:
+                 fmt = holomap_formats[0] if self.holomap=='auto' else self.holomap","Again, `no_duplicates=False` would be clearer here..."
+7989,"@@ -36,7 +36,7 @@ import (
+ // function will terminate current and further iterations without errors, and also close the returned channel.
+ // Make sure that you check the second returned parameter from the channel to stop iteration when its value
+ // is false.
+-func (db *DB) SubscribePull(ctx context.Context, bin uint8, since, until uint64) (c <-chan storage.Descriptor, stop func()) {
++func (db *DB) SubscribePull(ctx context.Context, bin uint8, since, until uint64) (c <-chan storage.Descriptor, closed <-chan struct{}, stop func()) {
+ 	db.metrics.SubscribePull.Inc()
+
+ 	chunkDescriptors := make(chan storage.Descriptor)",shouldnt we stop these routines BEFORE the db closed?
+7990,"@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap;
+ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.Multimap;
+
++import org.openqa.selenium.devtools.target.model.SessionId;
+ import org.openqa.selenium.json.Json;
+ import org.openqa.selenium.json.JsonInput;
+ import org.openqa.selenium.remote.http.HttpClient;",It fills me with endless sadness that we can't use Selenium's own `SessionId` here.
+7991,"@@ -88,7 +88,7 @@ public class Docker {
+
+     findImage(new ImageNamePredicate(name, tag));
+
+-    LOG.info(String.format(""Pulling %s:%s"", name, tag));
++    LOG.finest(String.format(""Pulling %s:%s"", name, tag));
+
+     HttpRequest request = new HttpRequest(POST, ""/images/create"");
+     request.addQueryParameter(""fromImage"", name);",This will always need to be displayed to users.
+7992,"@@ -1,6 +1,8 @@
+ class CartDecorator < Draper::Decorator
+   delegate_all
+
++  CUSTOM_TEMPLATES = %w(navigator whsc)
++
+   def total_price
+     price = object.cart_items.reduce(0) do |sum,citem| sum + citem.quantity * citem.price end
+     Float(""%0.02f"" % price)",Maybe we make an `ORIGINS` constant on the Cart model instead?
+7993,"@@ -115,7 +115,7 @@ const (
+ 	//	 a) Add 'authorizationConfig', 'transitEncryption' and 'transitEncryptionPort' to 'taskresource.volume.EFSVolumeConfig'
+ 	//	 b) Add 'pauseContainerPID' field to 'taskresource.volume.VolumeResource'
+ 	// 28) Add 'envfile' field to 'resources'
+-	// 29) Add 'ExecCommandAgentMetadata' field to 'apicontainer.Container'
++	// 29) Add 'ManagedAgentsUnsafe' field to 'apicontainer.Container'
+
+ 	ECSDataVersion = 29
+ ",looks like this is not needed anymore with boltdb migration. lets confirm with @fenxiong
+7994,"@@ -409,7 +409,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet()
++				ws, err := sf.NewWorkingSet(false)
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 408 (from `govet`)"
+7995,"@@ -380,7 +380,7 @@ public class Actions {
+
+     // Of course, this is the offset from the centre of the element. We have no idea what the width
+     // and height are once we execute this method.
+-    LOG.info(""When using the W3C Action commands, offsets are from the center of element"");
++    LOG.finest(""When using the W3C Action commands, offsets are from the center of element"");
+     return moveInTicks(target, xOffset, yOffset);
+   }
+ ","Again, the existing level is correct --- we're letting users know about something that might cause there tests to fail."
+7996,"@@ -34,7 +34,7 @@ type ProfileDecoder struct {
+ }
+
+ func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
+-	return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
++	return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
+ }
+
+ func (p *ProfileDecoder) RegisterWith(d *dispatcher.Dispatcher) {",Required by the libcalico-go changes
+7997,"@@ -438,10 +438,12 @@ void write_variables_gnuplot(struct histogram *h, struct histogram *all)
+ 	FILE *f     = open_file(fname);
+ 	free(fname);
+
++	fprintf(f, ""%s = %"" PRId64""\n"", ""current_buckets"",    h->nbuckets);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_minimum"",    h->min_value);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_maximum"",    h->max_value);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_mode"",       h->value_at_max_count);
+ 	fprintf(f, ""%s = %"" PRId64""\n"", ""current_mode_count"", h->max_count);
++	fprintf(f, ""%s = %"" PRId64""\n"", ""current_mode_min_count"", h->min_count);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_mean"",       h->mean);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_percentile75"", value_of_p(h, 0.75));
+ 	fprintf(f, ""%s = %lf\n"",        ""current_percentile25"", value_of_p(h, 0.25));","You want ""current_min_count"""
+7998,"@@ -85,14 +85,10 @@ public class MediaStoreProvider {
+           MediaStore.Files.FileColumns.PARENT, MediaStore.Images.Media.BUCKET_DISPLAY_NAME
+         };
+
+-    String selection, selectionArgs[];
+-
+-    selection =
+-        MediaStore.Files.FileColumns.MEDIA_TYPE
+-            + ""=? ) GROUP BY ( ""
+-            + MediaStore.Files.FileColumns.PARENT
+-            + "" "";
+-    selectionArgs = new String[] {String.valueOf(MediaStore.Files.FileColumns.MEDIA_TYPE_IMAGE)};
++    String selection = MediaStore.Files.FileColumns.MEDIA_TYPE + ""=? "";
++    String[] selectionArgs =
++        new String[] {String.valueOf(MediaStore.Files.FileColumns.MEDIA_TYPE_IMAGE)};
++    String sortOrder = MediaStore.Files.FileColumns.PARENT;
+
+     Cursor cur =
+         context",Why changes in this file?
+7999,"@@ -26,6 +26,7 @@ public final class CommentPatterns {
+       Pattern.compile(""\\[([^\\]]+)\\]\\((\\p{Alpha}+:[^\\)]+)\\)"");
+   public static final Pattern CLOUD_LINK_PATTERN =
+       Pattern.compile(""\\[([^\\]]+)\\]\\(((?!\\p{Alpha}+:)[^\\)]+)\\)"");
+-  public static final Pattern PROTO_LINK_PATTERN = Pattern.compile(""\\[([^\\]]+)\\]\\[[^\\]]*\\]"");
++  public static final Pattern PROTO_LINK_PATTERN =
++      Pattern.compile(""\\[([^\\]]+)\\]\\[([A-Za-z_][A-Za-z_.0-9]*)*\\]"");
+   public static final Pattern HEADLINE_PATTERN = Pattern.compile(""^#+"", Pattern.MULTILINE);
+ }",This doesn't look right. I think what you want here is `\\[([^\\]]+)\\]\\[[A-Za-z_][A-Za-z_.0-9]*]*\\]`.
+8000,"@@ -16,7 +16,7 @@ module Faker
+         return result
+       end
+
+-      raise RetryLimitExceeded
++      raise RetryLimitExceeded, ""Retry limit exceeded for #{name}""
+     end
+
+     RetryLimitExceeded = Class.new(StandardError)",@AndrewRayCode thanks for contributing   Could you write/modify the specs to make sure that this description is working properly?
+8001,"@@ -120,7 +120,8 @@ def default_bucket(request):
+     try:
+         response = request.invoke_subrequest(subrequest)
+     except httpexceptions.HTTPException as error:
+-        if error.content_type == 'application/json':
++        is_redirect = error.status_code < 400
++        if error.content_type == 'application/json' or is_redirect:
+             response = reapply_cors(subrequest, error)
+         else:
+             # Ask the upper level to format the error.",I would have tested 304 only there.
+8002,"@@ -36,16 +36,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+                 {
+                     // Close socket immediately
+                 }
+-            }
+
+-            await loggerFactory.FilterLogger.LogTcs.Task;
++                await loggerFactory.FilterLogger.LogTcs.Task.TimeoutAfter(TimeSpan.FromSeconds(10));
++            }
+
+             Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id);
+             Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel);
+             Assert.Equal(0, loggerFactory.ErrorLogger.TotalErrorsLogged);
+         }
+
+-
+         [Fact]
+         public async Task ClientHandshakeFailureLoggedAsInformation()
+         {",`TimeoutAfter` to be safe.
+8003,"@@ -244,8 +244,14 @@ init_build_bb(build_bb_t *bb, app_pc start_pc, bool app_interp, bool for_cache,
+      * whose fall-through hits our hook.  We avoid interpreting our own hook
+      * by shifting it to the displaced pc.
+      */
+-    if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc)
+-        start_pc = vsyscall_sysenter_displaced_pc;
++    if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc) {
++        if (vsyscall_sysenter_displaced_pc != NULL)
++            start_pc = vsyscall_sysenter_displaced_pc;
++        else {
++            /* Our hook must have failed. */
++            ASSERT(should_syscall_method_be_sysenter());
++        }
++    }
+ #endif
+     bb->check_vm_area = true;
+     bb->start_pc = start_pc;",So the 32-bit tests on the new kernel hit this case? Won't they fail in debug build?
+8004,"@@ -46,7 +46,9 @@ public class HTMLTestResults {
+   private final HTMLSuiteResult suite;
+
+   private static final String HEADER = ""<html>\n"" +
+-      ""<head><style type='text/css'>\n"" +
++      ""<head>\n""+
++      ""<meta charset=\""UTF-8\"">\n""+
++      ""<style type='text/css'>\n"" +
+       ""body, table {\n"" +
+       ""    font-family: Verdana, Arial, sans-serif;\n"" +
+       ""    font-size: 12;\n"" +","Is there a recommended quote style for attributes? I see single and double here, double further down."
+8005,"@@ -5,12 +5,14 @@ module RSpec::Core
+   # with information about a particular event of interest.
+   module Notifications
+
+-    # The `CountNotification` represents notifications sent by the formatter
+-    # which a single numerical count attribute. Currently used to notify
+-    # formatters of the expected number of examples.
++    # The `StartNotification` represents a notification sent by the reporter
++    # when the suite is started. It contains the expected amount of examples
++    # to be executed, and the load time of RSpec.
+     #
+     # @attr count [Fixnum] the number counted
+-    CountNotification = Struct.new(:count)
++    # @attr load_time [Float] the number of seconds taken to boot RSpec
++    #                         and load the spec files
++    StartNotification = Struct.new(:count, :load_time)
+
+     # The `ExampleNotification` represents notifications sent by the reporter
+     # which contain information about the current (or soon to be) example.",The description of `load_time` here is different from the description below..is that intentional?
+8006,"@@ -1547,6 +1547,10 @@ import 'programStyles';
+                     return '<span class=""cardImageIcon material-icons book""></span>';
+                 case 'Folder':
+                     return '<span class=""cardImageIcon material-icons folder""></span>';
++                case 'BoxSet':
++                    return '<span class=""cardImageIcon material-icons collections""></span>';
++                case 'Playlist':
++                    return '<span class=""cardImageIcon material-icons queue_music""></span>';
+             }
+
+             if (options && options.defaultCardImageIcon) {",Actually it could also be a video playlist. But music is used more often.
+8007,"@@ -36,6 +36,11 @@ function writeCommand(server, type, opsField, ns, ops, options, callback) {
+     writeCommand.bypassDocumentValidation = options.bypassDocumentValidation;
+   }
+
++  if (writeConcern.w === 0) {
++    // don't include session for unacknowledged writes
++    delete options.session;
++  }
++
+   const commandOptions = Object.assign(
+     {
+       checkKeys: type === 'insert',","From the ticket: > I understand why a session ID would be silently omitted for implicit sessions, but what is the reasoning behind omitting it for explicit sessions instead of raising a logic error to the user? So what this change is doing is ""silently omitting"" the session if its an unacknowledged write. I think we want to actually return an error in this case."
+8008,"@@ -85,6 +85,17 @@ namespace pwiz.Skyline.Model.Databinding.Entities
+         [Format(NullValue = TextUtil.EXCEL_NA)]
+         public int? PointsAcrossPeak { get { return ChromInfo.PointsAcrossPeak; } }
+
++        [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)]
++        public double? AverageCycleTime
++        {
++            get
++            {
++                return StartTime.HasValue && EndTime.HasValue && PointsAcrossPeak.HasValue
++                    ? (EndTime.Value - StartTime.Value) * 60 / PointsAcrossPeak.Value
++                    : (double?) null;
++            }
++        }
++
+         public bool Coeluting { get { return !ChromInfo.IsForcedIntegration; } }
+
+         [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)]",You can simplify this by doing: return (EndTime - StartTime) * 60 / PointsAcrossPeak;
+8009,"@@ -56,7 +56,7 @@ ColorPickerWidget::ColorPickerWidget(QWidget *parent):
+     QFrame(parent)
+ {
+     QFontMetrics fm (mLineEdit.font());
+-    mLineEdit.setFixedWidth ( 10*fm.width (QStringLiteral(""a"")) );
++    mLineEdit.setFixedWidth ( 10*fm.horizontalAdvance (QStringLiteral(""a"")) );
+
+     QHBoxLayout *layout = new QHBoxLayout(this);
+     layout->setContentsMargins (0, 0, 0, 0);","I think it's the time for bumping `REQUIRED_QT_VERSION` to the last LTS, 5.12. `QFontMetrics::horizontalAdvance()` doesn't exist in 5.10."
+8010,"@@ -21,7 +21,8 @@ module Bolt
+       statement_count: :cd6,
+       resource_mean: :cd7,
+       plan_steps: :cd8,
+-      return_type: :cd9
++      return_type: :cd9,
++      boltdir_type: :cd11
+     }.freeze
+
+     def self.build_client","I already set up cd10 for ""inventory_version in google analytics. I've added cd11 for Boltdir Type now"
+8011,"@@ -45,6 +45,10 @@ module Travis
+   module Build
+     class Script
+       TEMPLATES_PATH = File.expand_path('../templates', __FILE__)
++      INTERNAL_RUBY_REGEX = ENV.fetch(
++        'TRAVIS_INTERNAL_RUBY_REGEX',
++        'ruby-(2\.[0-2]\.[0-9]|1\.9\.3)'
++      ).untaint
+       DEFAULTS = {}
+
+       class << self",@henrikhodne We are lazily skipping `jruby-*` here (assuming that JRuby all of a sudden start using these version numbers).
+8012,"@@ -739,8 +739,11 @@ void CPaintStatistics::DrawAxis(wxDC &dc, const double max_val_y, const double m
+ 	double y_start_val = ceil(min_val_y / d_oy_val) * d_oy_val;
+ 	d_oy_count = (int)floor((max_val_y - y_start_val) / d_oy_val);
+
++    double temp_int_part;
++    int prec = modf(d_oy_val, &temp_int_part) == 0.0 ? 0 : 2;
++
+ 	for (double ny = 0; ny <= double(d_oy_count); ++ny){
+-		dc.GetTextExtent(wxString::Format(wxT(""%s""), format_number(y_start_val + ny * d_oy_val, 2)), &w_temp, &h_temp, &des_temp, &lead_temp);
++		dc.GetTextExtent(wxString::Format(wxT(""%s""), format_number(y_start_val + ny * d_oy_val, prec)), &w_temp, &h_temp, &des_temp, &lead_temp);
+ 		x0 = wxCoord(m_Graph_X_start + 1.0);
+ 		y0 = wxCoord(m_Ay_ValToCoord * (y_start_val + ny * d_oy_val) + m_By_ValToCoord);
+ 		x1 = wxCoord(m_Graph_X_end - 1.0);",How does this cope with values like `5.001`? Shouldn't that set precision to 0? Instead it is set to 2.
+8013,"@@ -40,7 +40,7 @@ class APITestCase(IntegrationTestCase):
+         # This sleep allows for the influx subscriber to take its time in getting
+         # the listen submitted from redis and writing it to influx.
+         # Removing it causes an empty list of listens to be returned.
+-        time.sleep(10)
++        time.sleep(15)
+
+         url = url_for('api_v1.get_listens', user_name = self.user['musicbrainz_id'])
+         response = self.client.get(url, query_string = {'count': '1'})","Rather than having a sleep here, we should check to see if the service we're waiting for is up yet, using something like dockerize. Not critical this second, but would be nice for later."
+8014,"@@ -0,0 +1,18 @@
++import path from 'path';
++import execa from 'execa';
++import {
++  displayErrorMessage
++} from '../../scripts/utils/console.mjs';
++
++((async function() {
++  try {
++    await execa('npm', ['run', 'swap-package-links'], {
++      cwd: path.resolve(process.cwd(), '..'),
++      stdio: 'inherit'
++    });
++
++  } catch (error) {
++    displayErrorMessage('Error running the script.');
++    process.exit(error.exitCode);
++  }
++})());",I'm not sure if there are any links to swap for Handosntable package. Should this be a top lvl script?
+8015,"@@ -537,7 +537,16 @@ signal_thread_init(dcontext_t *dcontext, void *os_data)
+         signal_frame_extra_size(true)
+         /* sigpending_t has xstate inside it already */
+         IF_LINUX(IF_X86(-sizeof(kernel_xstate_t)));
+-    IF_LINUX(IF_X86(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT))));
++/* Above does not guarantee alignment, it only guarantees sufficient space including
++ * aligmment of the extended state. The following is needed in order to guarantee
++ * alignment of our pending unit's size, which is used as the block size in the
++ * special allocator.
++ */
++#ifdef X86
++    pend_unit_size =
++        ALIGN_FORWARD(pend_unit_size, YMM_ENABLED() ? AVX_ALIGNMENT : FPSTATE_ALIGNMENT);
++    IF_LINUX(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT)));
++#endif
+
+     /* all fields want to be initialized to 0 */
+     memset(info, 0, sizeof(thread_sig_info_t));","It seems like it's too big now: can we remove signal_frame_extra_size from line 537? That should only be needed when placing xstate separately. It seems like it isn't needed at all for pending? Also, if we have special heap align forward for us, we don't need this align here either."
+8016,"@@ -128,9 +128,12 @@ catch
+                 # fortunately, using PS with stdin input_method should never happen
+                 if input_method == 'powershell'
+                   conn.execute(<<-PS)
+-$private:taskArgs = Get-ContentAsJson (
++$private:tempArgs = Get-ContentAsJson (
+   $utf8.GetString([System.Convert]::FromBase64String('#{Base64.encode64(JSON.dump(arguments))}'))
+ )
++$allowedArgs = (Get-Command ""#{remote_path}"").Parameters.Keys
++$private:taskArgs = @{}
++$private:tempArgs.Keys | ? { $allowedArgs -contains $_ } | % { $private:taskArgs[$_] = $private:tempArgs[$_] }
+ try { & ""#{remote_path}"" @taskArgs } catch { Write-Error $_.Exception; exit 1 }
+               PS
+                 else","Just double checked the `-in` operator. It's PS3 only, so we might want to change `$_ -in $allowedArgs` to `$allowedArgs -contains $_`"
+8017,"@@ -152,6 +152,14 @@ class StartButton(IAccessible):
+ 		states = super(StartButton, self).states
+ 		states.discard(controlTypes.STATE_SELECTED)
+ 		return states
++
++class UIProperty(UIA):
++	#Used for columns in Windows Explorer Details view.
++	#These can contain dates that include unwanted left-to-right and right-to-left indicator characters.
++
++	def _get_value(self):
++		value = super(UIProperty, self).value
++		return value.replace(u'\u200E','').replace(u'\u200F','')
+
+
+ class AppModule(appModuleHandler.AppModule):","Might as well use translate here, as @jcsteh suggested"
+8018,"@@ -145,8 +145,9 @@ class DimensionedPlot(Plot):
+     show_title = param.Boolean(default=True, doc=""""""
+         Whether to display the plot title."""""")
+
+-    title_format = param.String(default=""{label} {group}"", doc=""""""
+-        The formatting string for the title of this plot."""""")
++    title_format = param.String(default=""{label} {group}\n{dimensions}"", doc=""""""
++        The formatting string for the title of this plot, allows defining
++        a label group separator and dimension labels."""""")
+
+     normalize = param.Boolean(default=True, doc=""""""
+         Whether to compute ranges across all Elements at this level",Definitely an improvement as long as the old tests pass (i.e backwards compatible).
+8019,"@@ -22,11 +22,11 @@ package com.netflix.iceberg;
+ import com.google.common.collect.Maps;
+ import com.netflix.iceberg.exceptions.RuntimeIOException;
+ import com.netflix.iceberg.io.FileIO;
+-import java.util.Map;
+ import com.netflix.iceberg.io.LocationProvider;
+ import org.junit.rules.TemporaryFolder;
+
+ import java.io.IOException;
++import java.util.Map;
+
+ class LocalTableOperations implements TableOperations {
+   private final TemporaryFolder temp;",nit: non functional change
+8020,"@@ -130,6 +130,17 @@ func main() {
+ 		}()
+ 	}
+
++	// Fail fast if the AWS credentials are not present.
++	awsCredentialsPath := os.Getenv(""AWS_SHARED_CREDENTIALS_FILE"")
++	if len(awsCredentialsPath) == 0 {
++		awsCredentialsPath = ""/home/.aws/credentials""
++	}
++	_, err := os.Stat(awsCredentialsPath)
++	if err != nil {
++		setupLog.Error(err, ""AWS credentials not found"")
++		os.Exit(1)
++	}
++
+ 	ctrl.SetLogger(klogr.New())
+ 	// Machine and cluster operations can create enough events to trigger the event recorder spam filter
+ 	// Setting the burst size higher ensures all events will be recorded and submitted to the API","The file is not required - if you're using an IAM instance profile, for example. I'm not sure we can error 100% of the time if it's missing. @randomvariable any suggestions?"
+8021,"@@ -2527,7 +2527,7 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
+ 		}
+
+ 		if expr.High != nil {
+-			highType = expr.High.Type().(*types.Basic)
++			highType = expr.High.Type().Underlying().(*types.Basic)
+ 			high, err = c.parseExpr(frame, expr.High)
+ 			if err != nil {
+ 				return llvm.Value{}, nil",There is a very similar line `lowType = expr.Low.Type().(*types.Basic)` a few lines above this line. Can you change that in the same way?
+8022,"@@ -0,0 +1,19 @@
++/*
++ * Copyright ConsenSys AG.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
++ * the License. You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
++ * an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
++ * specific language governing permissions and limitations under the License.
++ *
++ * SPDX-License-Identifier: Apache-2.0
++ */
++package org.hyperledger.besu.consensus.merge.blockcreation;
++
++import org.hyperledger.besu.ethereum.blockcreation.MiningCoordinator;
++
++public interface MergeMiningCoordinator extends MiningCoordinator {}",New files should be copyright Hyperledger Besu Contributors.
+8023,"@@ -34,5 +34,18 @@ module Bolt
+         sftp.upload!(source, destination)
+       end
+     end
++
++    def make_tempdir
++      @session.exec!('mktemp -d').chomp
++    end
++
++    def run_script(script)
++      dir = make_tempdir
++      remote_path = ""#{dir}/#{File.basename(script)}""
++      copy(script, remote_path)
++      execute(""chmod u+x \""#{remote_path}\"""")
++      execute(""\""#{remote_path}\"""")
++      execute(""rm -rf \""#{dir}\"""")
++    end
+   end
+ end","if I give a non-existent script, then I don't get an errors. I would have expected the `copy` method to raise, but maybe `net-sftp` silently exits?"
+8024,"@@ -4343,10 +4343,12 @@ class Series(Frame, IndexOpsMixin, Generic[T]):
+         """"""
+         if to_replace is None:
+             return self.fillna(method=""ffill"")
+-        if not isinstance(to_replace, (str, list, dict, int, float)):
+-            raise ValueError(""'to_replace' should be one of str, list, dict, int, float"")
++        if not isinstance(to_replace, (str, list, tuple, dict, int, float)):
++            raise ValueError(""'to_replace' should be one of str, list, tuple, dict, int, float"")
+         if regex:
+             raise NotImplementedError(""replace currently not support for regex"")
++        to_replace = list(to_replace) if isinstance(to_replace, tuple) else to_replace
++        value = list(value) if isinstance(value, tuple) else value
+         if isinstance(to_replace, list) and isinstance(value, list):
+             if not len(to_replace) == len(value):
+                 raise ValueError(",@itholic can you also update the parameters in the docs?
+8025,"@@ -292,6 +292,11 @@ public final class IntMap<T> implements Traversable<T>, Serializable {
+             public int characteristics() {
+                 return spliterator.characteristics();
+             }
++
++            @Override
++            public Comparator<? super T> getComparator() {
++                return null;
++            }
+         }
+         return new SpliteratorProxy(original.spliterator());
+     }","The super impl Spliterator.getComparator() throws an IllegalStateException by default. Is it really necessary to return null? If null is used somewhere it will throw a NPE, which is roughly the same as throwing an IllegalStateException. I'm just curious - I'm sure there is a reason!"
+8026,"@@ -256,7 +256,7 @@ public class Avro {
+       schema(table.schema());
+       withSpec(table.spec());
+       setAll(table.properties());
+-      metricsConfig(MetricsConfig.fromProperties(table.properties()));
++      metricsConfig(MetricsConfig.forTable(table));
+       return this;
+     }
+ ",Do we need to do the same in Avro `WriteBuilder` too? I don't think we use that method right now but should make sense for consistency. We already handle that for Parquet.
+8027,"@@ -319,6 +319,8 @@ int FlatCompiler::Compile(int argc, const char **argv) {
+         opts.force_defaults = true;
+       } else if (arg == ""--force-empty"") {
+         opts.set_empty_to_null = false;
++      } else if (arg == ""--java_primitive_has_method"") {
++        opts.java_primitive_has_method = true;
+       } else {
+         for (size_t i = 0; i < params_.num_generators; ++i) {
+           if (arg == params_.generators[i].generator_opt_long ||",can you make all the `_` into `-` to be consistent with the other options?
+8028,"@@ -0,0 +1,15 @@
++// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++// SPDX-License-Identifier: Apache-2.0
++
++package archer
++
++import ""github.com/aws/aws-sdk-go/service/cloudformation""
++
++// StackConfiguration represents an entity that can be serialized
++// into a Cloudformation template
++type StackConfiguration interface {
++	StackName() string
++	Template() (string, error)
++	Parameters() []*cloudformation.Parameter
++	Tags() []*cloudformation.Tag
++}",What do you think of renaming this file to `stack.go` or `cfn_stack.go`? `common.go`/`util.go` don't provide us anything descriptive about the contents of the file.
+8029,"@@ -19,12 +19,14 @@ using System.Runtime.CompilerServices;
+ #if SIGNED
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
+ [assembly: InternalsVisibleTo(""Benchmarks, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
++[assembly: InternalsVisibleTo(""Examples.Console, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
+
+ // Used by Moq.
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7"")]
+ #else
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests"")]
+ [assembly: InternalsVisibleTo(""Benchmarks"")]
++[assembly: InternalsVisibleTo(""Examples.Console"")]
+
+ // Used by Moq.
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")]","It isn't a very effective example if it requires access to the internals   I can't tell just looking at the diff why this is needed, can you provide a little context?"
+8030,"@@ -3,13 +3,16 @@
+ require 'spec_helper'
+ require 'bolt/transport/local'
+ require 'bolt/target'
++require 'bolt/inventory'
++require 'bolt_spec/transport'
+
+ require_relative 'shared_examples'
+
+ describe Bolt::Transport::Local, bash: true do
+-  let(:runner) { Bolt::Transport::Local.new }
++  include BoltSpec::Transport
++
++  let(:transport) { :local }
+   let(:os_context) { posix_context }
+-  let(:transport_conf) { {} }
+   let(:target) { Bolt::Target.new('local://localhost', transport_conf) }
+
+   it 'is always connected' do",Why does this include `bolt/inventory`?
+8031,"@@ -427,7 +427,7 @@ public final class LinkedHashMap<K, V> implements Kind2<LinkedHashMap<?, ?>, K,
+         Queue<Tuple2<K, V>> newList = list;
+         HashMap<K, V> newMap = map;
+         if (containsKey(key)) {
+-            newList = newList.filter(t -> !t._1.equals(key));
++            newList = newList.filter(t -> !Objects.equals(t._1, key));
+             newMap = newMap.remove(key);
+         }
+         newList = newList.append(Tuple.of(key, value));",We called `t._1.equals(...)` where `t._1` potentially could be `null`.
+8032,"@@ -0,0 +1,14 @@
++/* global forms */
++const rangeRoles = ['progressbar', 'scrollbar', 'slider', 'spinbutton'];
++
++/**
++ * Determines if an element is an aria range element
++ * @method isAriaRange
++ * @memberof axe.commons.forms
++ * @param {Element} node Node to determine if aria range
++ * @returns {Bool}
++ */
++forms.isAriaRange = function(node) {
++	const role = axe.commons.aria.getRole(node, { noImplicit: true });
++	return rangeRoles.includes(role) && node.hasAttribute('aria-valuenow');
++};","I don't think we should include the `hasAttribute` test here. Even without aria-valuenow, it's still an aria range element. This check is going to make reuse of this function problematic. Better to move the attribute check part outside this function IMO."
+8033,"@@ -35,6 +35,7 @@ class ErgonodeFixtureCommand extends Command
+         $this->setName('ergonode:fixture:load');
+         $this->setDescription('Fill database with data');
+         $this->addOption('group', 'g', InputOption::VALUE_REQUIRED, 'Group');
++        $this->addOption('file', 'f', InputOption::VALUE_REQUIRED, 'File');
+     }
+
+     /**",Shouldn't it be optional?
+8034,"@@ -55,6 +55,7 @@ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegio
+ 			cfg,
+ 			metadata.ClientInfo{
+ 				ServiceName:   ServiceName,
++				ServiceID:     ""API Gateway"",
+ 				SigningName:   signingName,
+ 				SigningRegion: signingRegion,
+ 				Endpoint:      endpoint,","would be helpful to make these a package level constant so they are accessible to the user. similar to Service Name. Not directly related note, v2 SDK ServiceName should be renamed to ServiceEndpointPrefix."
+8035,"@@ -18,7 +18,7 @@ class Storage
+
+     public function load(string $path)
+     {
+-        return include $this->realpath($path);
++        return file_exists($this->realpath($path)) ? include $this->realpath($path) : null;
+     }
+
+     public function store(string $path, string $content): void",Duplicate call to the method. Better to put in a variable.
+8036,"@@ -1023,8 +1023,9 @@ type Prefetcher interface {
+ 	// PrefetchAfterBlockRetrieved allows the prefetcher to trigger prefetches
+ 	// after a block has been retrieved. Whichever component is responsible for
+ 	// retrieving blocks will call this method once it's done retrieving a
+-	// block.
+-	PrefetchAfterBlockRetrieved(b Block, kmd KeyMetadata, priority int,
++	// block. It caches if it has triggered a prefetch and returns that.
++	PrefetchAfterBlockRetrieved(b Block, blockPtr BlockPointer,
++		kmd KeyMetadata, priority int, lifetime BlockCacheLifetime,
+ 		hasPrefetched bool)
+ 	// Shutdown shuts down the prefetcher idempotently. Future calls to
+ 	// the various Prefetch* methods will return io.EOF. The returned channel","""and returns that"" -- it looks like this method has no return value."
+8037,"@@ -212,7 +212,7 @@ class BitmapMasks(BaseInstanceMasks):
+
+     def flip(self, flip_direction='horizontal'):
+         """"""See :func:`BaseInstanceMasks.flip`.""""""
+-        assert flip_direction in ('horizontal', 'vertical')
++        assert flip_direction in ('horizontal', 'vertical', 'diagonal')
+
+         if len(self.masks) == 0:
+             flipped_masks = self.masks",Modifications are also needed for PolygonMask.
+8038,"@@ -3,12 +3,9 @@
+
+ using System;
+ using System.Net;
+-using Microsoft.AspNetCore;
+ using Microsoft.AspNetCore.Hosting;
+-using Microsoft.AspNetCore.Server.Kestrel.Core;
+-using Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal;
++using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http;
+ using Microsoft.Extensions.Configuration;
+-using Microsoft.Extensions.DependencyInjection;
+
+ namespace PlatformBenchmarks
+ {",Does this really make a difference?
+8039,"@@ -70,6 +70,9 @@ public class TestRandomFlRTGCloud extends SolrCloudTestCase {
+
+   /** Always included in fl so we can vet what doc we're looking at */
+   private static final FlValidator ID_VALIDATOR = new SimpleFieldValueValidator(""id"");
++
++  /** Since nested documents are not tested, when _root_ is declared in schema, it is always the same as id */
++  private static final FlValidator ROOT_VALIDATOR = new RenameFieldValueValidator(""id"" , ""_root_"");
+
+   /**
+    * Types of things we will randomly ask for in fl param, and validate in response docs.","Added a validator for _root_, which is now added automatically since the schema used here declares _root_."
+8040,"@@ -76,6 +76,12 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+
++  /**
++   * The estimated cost to open a file, used as a minimum weight when combining splits. By default this
++   * will use the ""read.split.open-file-cost"" value in the table properties of the table being updated.
++   */
++  String OPEN_FILE_COST = ""open-file-cost"";
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining","The other properties are `file-open-cost`, not `open-file-cost`."
+8041,"@@ -337,6 +337,19 @@ AC_ARG_ENABLE(easylogging,
+         [Disable easylogging]))
+ AM_CONDITIONAL(USE_EASYLOGGING, [test x$enable_easylogging != xno])
+
++case ""${host_os}"" in
++    *darwin*)
++        # libunwind comes standard with the command-line tools on macos
++        AC_DEFINE([HAVE_LIBUNWIND], [1],
++            [Define to 1 if you have the <libunwind.h> header file])
++        ;;
++    *)
++        PKG_CHECK_MODULES(libunwind, libunwind,
++            AC_DEFINE([HAVE_LIBUNWIND], [1],
++                [Define to 1 if you have the <libunwind.h> header file]))
++        ;;
++esac
++
+ # Need this to pass through ccache for xdrpp, libsodium
+ esc() {
+     out=",confused by this: what we need here is not libunwind but libunwind-dev right? Why skipping detection?
+8042,"@@ -24,8 +24,8 @@ namespace Microsoft.Azure
+                 throw new ArgumentNullException(""serializer"");
+             }
+             JsonSerializer newSerializer = new JsonSerializer();
+-            PropertyInfo[] properties = typeof(JsonSerializer).GetProperties();
+-            foreach (var property in properties.Where(p => p.GetSetMethod() != null))
++            var properties = typeof(JsonSerializer).GetTypeInfo().DeclaredProperties;
++            foreach (var property in properties.Where(p => p.SetMethod != null && !p.SetMethod.IsPrivate))
+             {
+                 property.SetValue(newSerializer, property.GetValue(serializer, null), null);
+             }","just in case helps, it this related with this PR?"
+8043,"@@ -88,6 +88,11 @@ def convert_019_100(data):
+
+ def convert_100_200(data):
+     data[""version""] = (2, 0, 0)
++    data[""client_conn""][""address""] = data[""client_conn""][""address""][""address""]
++    data[""server_conn""][""address""] = data[""server_conn""][""address""][""address""]
++    data[""server_conn""][""source_address""] = data[""server_conn""][""source_address""][""address""]
++    if data[""server_conn""][""ip_address""]:
++        data[""server_conn""][""ip_address""] = data[""server_conn""][""ip_address""][""address""]
+     return data
+
+ ",This is incomplete I think (at least source_address and ip_address are missing)
+8044,"@@ -126,7 +126,16 @@ public class DefaultSynchronizer<C> implements Synchronizer {
+       LOG.info(""Starting synchronizer."");
+       blockPropagationManager.start();
+       if (fastSyncDownloader.isPresent()) {
+-        fastSyncDownloader.get().start().whenComplete(this::handleFastSyncResult);
++        fastSyncDownloader
++            .get()
++            .start()
++            .whenComplete(this::handleFastSyncResult)
++            .exceptionally(
++                ex -> {
++                  System.exit(0);
++                  return null;
++                });
++
+       } else {
+         startFullSync();
+       }","We have a `stop` method here, we should probably be calling that instead of just exiting. There could be important resources to close or cleanup nicely now or in the future."
+8045,"@@ -35,6 +35,7 @@ namespace AutoRest.Extensions
+                 //Constraints = parameter.Constraints, Omit these since we don't want to perform parameter validation
+                 Documentation = parameter.Documentation,
+                 ModelType = parameter.ModelType,
++                RealPath = new string[] { },
+                 SerializedName = default(string) //Parameter is never serialized directly
+             });
+ ",fixes ArgNullEx when using both `x-ms-parameter-grouping` and media type `application/xml` in the same operation (issue #2236)
+8046,"@@ -33,6 +33,12 @@ const (
+ 	// The specified bucket does not exist.
+ 	ErrCodeNoSuchBucket = ""NoSuchBucket""
+
++	// ErrCodeBucketNotFound for service response error code
++	// ""NotFound"".
++	//
++	// The specified bucket does not exist
++	ErrCodeBucketNotFound = ""NotFound""
++
+ 	// ErrCodeNoSuchKey for service response error code
+ 	// ""NoSuchKey"".
+ 	//","`NotFound` is a generic error code derived from the HTTP response message's status code, and can be returned for any S3 operation that responds with a 404 status code and no other error code present. Due to this the constant `ErrCodeBucketNotFound`. In addition, these constants are generated based on the API model defined by Amazon S3, modifications to the file directly will be lost during regeneration of the API. With that said, we are looking at ways to work with the Amazon S3 team to better represent this error in a way that is more easily consumed."
+8047,"@@ -0,0 +1,18 @@
++test_name 'test generic installers'
++
++step 'install arbitrary msi via url' do
++  hosts.each do |host|
++    if host['platform'] =~ /win/
++      # this should be implemented at the host/win/pkg.rb level someday
++      generic_install_msi_on(host, 'https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1.8.4.msi', {}, {:debug => true})
++    end
++  end
++end
++
++step 'install arbitrary dmg via url' do
++  hosts.each do |host|
++    if host['platform'] =~ /osx/
++      host.generic_install_dmg('https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1.8.4.dmg', 'Vagrant', 'Vagrant.pkg')
++    end
++  end
++end","@johnduarte I was curious about the case when the operating system was neither `osx` or `win`; in this case, the test will indeed pass, but nothing will have actually really been tested. Should this have a `skip_test` condition at the top?"
+8048,"@@ -0,0 +1,10 @@
++package main
++
++import ""time""
++
++func main() {
++	for {
++		println(""hello world!"")
++		time.Sleep(time.Second)
++	}
++}",I think this example was included by accident? It doesn't seem to belong in this PR (but a separate PR with this would be nice!).
+8049,"@@ -128,7 +128,7 @@ public class RestRequest {
+ 	 *
+ 	 * @param method				the HTTP method for the request (GET/POST/DELETE etc)
+ 	 * @param path					the URI path, this will automatically be resolved against the users current instance host.
+-	 * @param httpEntity			the request body if there is one, can be null.
++	 * @param requestEntity			the request body if there is one, can be null.
+ 	 */
+ 	public RestRequest(RestMethod method, String path, HttpEntity requestEntity) {
+ 		this(method, path, requestEntity, null);",Just fixing a bunch of outdated java docs in this file
+8050,"@@ -51,7 +51,7 @@ namespace Nethermind.TxPool
+
+         private readonly object _locker = new();
+
+-        private readonly ConcurrentDictionary<Address, AddressNonces> _nonces =
++        private readonly Dictionary<Address, AddressNonces> _nonces =
+             new();
+
+         private readonly LruKeyCache<Keccak> _hashCache = new(MemoryAllowance.TxHashCacheSize,",I think it may be safer not to touch Concurrent to normal.
+8051,"@@ -158,6 +158,10 @@ class Server extends EventEmitter {
+     // setup listeners
+     this.s.pool.on('parseError', parseErrorEventHandler(this));
+
++    this.s.pool.on('drain', err => {
++      this.emit('error', err);
++    });
++
+     // it is unclear whether consumers should even know about these events
+     // this.s.pool.on('timeout', timeoutEventHandler(this));
+     // this.s.pool.on('reconnect', reconnectEventHandler(this));","is this for everything, or just legacy?"
+8052,"@@ -368,6 +368,15 @@ function processNewChange(args) {
+   const change = args.change;
+   const callback = args.callback;
+   const eventEmitter = args.eventEmitter || false;
++
++  if (changeStream.isClosed()) {
++    if (eventEmitter) return;
++
++    const error = new Error('ChangeStream is closed');
++    if (typeof callback === 'function') return callback(error, null);
++    return changeStream.promiseLibrary.reject(error);
++  }
++
+   const topology = changeStream.topology;
+   const options = changeStream.cursor.options;
+ ",I think this should be a `MongoError` right?
+8053,"@@ -14,8 +14,10 @@ var (
+ 	DdevBin      = ""ddev""
+ 	DevTestSites = []testcommon.TestSite{
+ 		{
+-			Name:        ""drupal8"",
+-			DownloadURL: ""https://github.com/drud/drupal8/archive/v0.2.2.tar.gz"",
++			Name:      ""drupal8"",
++			SourceURL: ""https://github.com/drud/drupal8/archive/v0.2.2.tar.gz"",
++			FileURL:   ""https://github.com/drud/drupal8/releases/download/v0.2.2/files.tar.gz"",
++			DBURL:     ""https://github.com/drud/drupal8/releases/download/v0.2.2/db.tar.gz"",
+ 		},
+ 	}
+ )",This is currently a db.tar.gz with just one .sql file in it. It might be worth another test (or maybe I'll find one) that has more than one sql file in it.
+8054,"@@ -218,6 +218,14 @@ var _ = infrastructure.DatastoreDescribe(""VXLAN topology before adding host IPs
+ 					policy.Spec.Selector = ""has(host-endpoint)""
+ 					_, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions)
+ 					Expect(err).NotTo(HaveOccurred())
++
++					policy = api.NewGlobalNetworkPolicy()
++					policy.Name = ""allow-all-egress-normal""
++					policy.Spec.Order = &order
++					policy.Spec.Egress = []api.Rule{{Action: api.Allow}}
++					policy.Spec.Selector = ""has(host-endpoint)""
++					_, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions)
++					Expect(err).NotTo(HaveOccurred())
+ 				})
+
+ 				It(""should not block any traffic"", func() {",Why these changes to existing tests?
+8055,"@@ -141,6 +141,12 @@ namespace Datadog.Trace.Configuration
+             HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
+                                    .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
+
++            var serviceNameMappings = source?.GetDictionary(ConfigurationKeys.ServiceNameMappings)
++                                      ?.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
++                                      ?.ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
++
++            ServiceNameMappings = new ServiceNames(serviceNameMappings);
++
+             DogStatsdPort = source?.GetInt32(ConfigurationKeys.DogStatsdPort) ??
+                             // default value
+                             8125;","It should be `IsNullOrWhitespace` I believe, since we're going to trim the value afterwards (and I just realized the other configuration keys have the same issue)"
+8056,"@@ -72,9 +72,9 @@ module Bolt
+
+     # Returns a hash of implementation name, path to executable, input method (if defined),
+     # and any additional files (name and path)
+-    def select_implementation(target, additional_features = [])
++    def select_implementation(target, provided_features = [])
+       impl = if (impls = implementations)
+-               available_features = target.features + additional_features
++               available_features = target.features + provided_features
+                impl = impls.find do |imp|
+                  remote_impl = imp['remote']
+                  remote_impl = metadata['remote'] if remote_impl.nil?",This is just for consistency + searchability with the transports
+8057,"@@ -42,6 +42,7 @@ import (
+ const (
+ 	CertFile = ""/tmp/kubeedge/certs/edge.crt""
+ 	KeyFile  = ""/tmp/kubeedge/certs/edge.key""
++	ConfigPath = ""/tmp/kubeedge/testData""
+ )
+
+ //testServer is a fake http server created for testing",please run gofmt.
+8058,"@@ -1,4 +1,4 @@
+-package porcelain_test
++package porcelain
+
+ import (
+ 	""context""","thats kind of a bummer, why do we have to give it full access? if it is just for the private interfaces i'd personally rather have those interfaces pollute the public exported symbols than open the tests up like this."
+8059,"@@ -69,6 +69,11 @@ func (s *store) initialize() {
+ 			continue
+ 		}
+
++		// Ignore in case appNodes with appID not existed in store.
++		if s.apps[appID] == nil {
++			continue
++		}
++
+ 		// Add the missing resource into the dependedResources of the app.
+ 		key := provider.MakeResourceKey(an.resource)
+ 		s.apps[appID].addDependedResource(uid, key, an.resource, now)",Because this is an unexpected situation so can you add a log here to help us figure out what resource is causing this problem?
+8060,"@@ -554,12 +554,11 @@ public class OverseerCollectionMessageHandler implements OverseerMessageHandler,
+     final String collectionName = message.getStr(ZkStateReader.COLLECTION_PROP);
+     //the rest of the processing is based on writing cluster state properties
+     //remove the property here to avoid any errors down the pipeline due to this property appearing
+-    String configName = (String) message.getProperties().remove(CollectionAdminParams.COLL_CONF);
++    String configName = (String) message.getProperties().get(CollectionAdminParams.COLL_CONF);
+
+     if(configName != null) {
+       validateConfigOrThrowSolrException(configName);
+
+-      createConfNode(cloudManager.getDistribStateManager(), configName, collectionName);
+       reloadCollection(null, new ZkNodeProps(NAME, collectionName), results);
+     }
+ ",just observing that this innocent looking change seems important to this PR. Previously this data had disappeared from the state.
+8061,"@@ -1442,7 +1442,8 @@ short ExExeUtilHBaseBulkLoadTcb::work()
+            ComCondition *cond;
+            Lng32 entryNumber;
+            while ((cond = diagsArea->findCondition(EXE_ERROR_ROWS_FOUND, &entryNumber)) != NULL) {
+-              errorRowCount = cond->getOptionalInteger(0);
++              if (errorRowCount < cond->getOptionalInteger(0))
++                 errorRowCount = cond->getOptionalInteger(0);
+               diagsArea->deleteWarning(entryNumber);
+            }
+            diagsArea->setRowCount(0);","Actually, I do have one question: You mention that each warning is for a different range. Should we add the rowcounts instead of using the max?"
+8062,"@@ -31,6 +31,7 @@ type Protocol interface {
+ 	ReadState(context.Context, StateReader, []byte, ...[]byte) ([]byte, error)
+ 	Register(*Registry) error
+ 	ForceRegister(*Registry) error
++	Name() string
+ }
+
+ // GenesisStateCreator creates some genesis states",it is confusing to return ID as Name
+8063,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests
+8064,"@@ -48,7 +48,7 @@ class Bootstrap
+         }
+
+         $kernel = new AppKernel($this->environment, Environment::isEnvironmentDebug($this->environment));
+-        $kernel->loadClassCache();
++        Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_ALL);
+         if ($this->console) {
+             $input = new ArgvInput();
+             $output = new ConsoleOutput();","commit mesasge: I would append ""...Kernel::loadClassCache() method call"""
+8065,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those,
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?
+8066,"@@ -2,7 +2,7 @@ package azkaban.test.utils;
+
+ import java.io.File;
+
+-import junit.framework.Assert;
++import org.junit.Assert;
+
+ import org.apache.log4j.Logger;
+ import org.junit.Test;",You can move this import down to before line 8 (import org.junit.Test;).
+8067,"@@ -52,7 +52,7 @@ class Findingsnotifier(object):
+                     'resource_type': violation.get('resource_type'),
+                     'resource_id': violation.get('resource_id'),
+                     'rule_index': violation.get('rule_index'),
+-                    'inventory_index_id': violation.get('inventory_index_id'),
++                    'scanner_index_id': violation.get('scanner_index_id'),
+                     'resource_data': violation.get('resource_data')
+                 }
+             }","It's okay to add the `scanner_index_id` here. But we still should keep the `inventory_index_id` reference because it will help the user to know right away, which inventory the violation is coming from, without having to do another lookup."
+8068,"@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take
+     }
+
+     public void submit() {
++      dispatcher.beforeClickOn(element, driver);
+       element.submit();
++      dispatcher.afterClickOn(element, driver);
+     }
+
+     public void sendKeys(CharSequence... keysToSend) {","this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate."
+8069,"@@ -1,5 +1,7 @@
+ <h2>
+-  Single
++  <% unless current_user_has_active_subscription? %>
++    Single
++  <% end %>
+   <% if pricing_scheme == ""primary"" %>
+     <%= render 'price', product: product,
+       price: product.individual_price,",Should this be I18n'd?
+8070,"@@ -93,7 +93,7 @@ public class CheckCompatibility extends TypeUtil.CustomOrderSchemaVisitor<List<S
+   }
+
+   @Override
+-  public List<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) {
++  public ImmutableList<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) {
+     Preconditions.checkNotNull(readStruct, ""Evaluation must start with a schema."");
+
+     if (!currentType.isStructType()) {","We don't typically use `ImmutableList` to avoid leaking it in methods that are accidentally public or purposely part of the API. I'm +1 for returning `ImmutableList.copyOf(errors)` below, but I don't think we should guarantee the list will be an `ImmutableList`."
+8071,"@@ -441,10 +441,18 @@ class TestCase(unittest.TestCase):
+     m = Chem.MolFromSmiles('C1=CN=CC=C1')
+     pkl = cPickle.dumps(m)
+     m2 = cPickle.loads(pkl)
++    self.assertTrue(type(m2) == Chem.Mol)
+     smi1 = Chem.MolToSmiles(m)
+     smi2 = Chem.MolToSmiles(m2)
+     self.assertTrue(smi1 == smi2)
+
++    pkl = cPickle.dumps(Chem.RWMol(m))
++    m2 = cPickle.loads(pkl)
++    self.assertTrue(type(m2) == Chem.RWMol)
++    smi1 = Chem.MolToSmiles(m)
++    smi2 = Chem.MolToSmiles(m2)
++    self.assertTrue(smi1 == smi2)
++
+   def test16Props(self):
+     m = Chem.MolFromSmiles('C1=CN=CC=C1')
+     self.assertTrue(not m.HasProp('prop1'))",@greglandrum Is this test sufficient?
+8072,"@@ -1,2 +1 @@
+-GITHUB_USER = ENV['GITHUB_USER']
+-GITHUB_PASSWORD = ENV['GITHUB_PASSWORD']
++GITHUB_ACCESS_TOKEN = ENV['GITHUB_ACCESS_TOKEN']",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+8073,"@@ -0,0 +1,5 @@
++class MakePlansPolymorphic < ActiveRecord::Migration
++  def change
++    add_column :subscriptions, :plan_type, :string, null: false
++  end
++end",I think Rails complains about the `null: false` part if we ever decide to roll this migration back. Might need to split this up into separate `up/down` methods to handle that.
+8074,"@@ -618,8 +618,8 @@ func (mtask *managedTask) progressContainers() {
+ 	// We've kicked off one or more transitions, wait for them to
+ 	// complete, but keep reading events as we do. in fact, we have to for
+ 	// transitions to complete
+-	mtask.waitForContainerTransitions(transitions, transitionChange, transitionChangeContainer)
+-	seelog.Debugf(""Managed task [%s]: done transitioning all containers"", mtask.Arn)
++	mtask.waitForContainerTransition(transitions, transitionChange, transitionChangeContainer)
++	seelog.Debugf(""Managed task [%s]: wait for container transition done"", mtask.Arn)
+
+ 	// update the task status
+ 	changed := mtask.UpdateStatus()",I don't think we need this line. You're logging in `waitForContainerTransition()` anyway
+8075,"@@ -13,7 +13,7 @@
+
+ return [
+     'accepted'             => ':attribute ला स्वीकार केला गेला पाहिजे.',
+-    'accepted_if'          => 'The :attribute must be accepted when :other is :value.',
++    'accepted_if'          => ':other हे :value असेल तेव्हा हे फील्ड स्वीकारणे आवश्यक आहे.',
+     'active_url'           => ':attribute हा एक बरोबर URL नाही आहे.',
+     'after'                => ':attribute, :date नंतरची एक तारीख पाहिजे.',
+     'after_or_equal'       => ':attribute, :date हि किंवा त्या नंतरची एक तारीख पाहिजे.',",Shouldn't the `:attribute` placeholder appear?
+8076,"@@ -78,8 +78,8 @@ public class ResidualEvaluator implements Serializable {
+   private class ResidualVisitor extends ExpressionVisitors.BoundExpressionVisitor<Expression> {
+     private StructLike struct;
+
+-    private Expression eval(StructLike struct) {
+-      this.struct = struct;
++    private Expression eval(StructLike arg) {
++      this.struct = arg;
+       return ExpressionVisitors.visit(expr, this);
+     }
+ ",Could you update this to `structLike` instead of `arg`?
+8077,"@@ -0,0 +1,14 @@
++// +build darwin linux,!baremetal freebsd,!baremetal
++
++// +build gc.conservative gc.leaking
++
++package runtime
++
++const heapSize = 1 * 1024 * 1024 // 1MB to start
++
++var heapStart, heapEnd uintptr
++
++func preinit() {
++	heapStart = uintptr(malloc(heapSize))
++	heapEnd = heapStart + heapSize
++}","I only now spot this `freebsd,!baremetal` in the code, which doesn't make a lot of sense. The fact that there is `linux,!baremetal` is because baremetal targets pretend to be linux/arm to get the standard library to compile. Such a `!baremetal` exclusion is not necessary for FreeBSD. But this is not something that needs fixing in this PR."
+8078,"@@ -455,7 +455,7 @@ get_unpacked_unlinked_content (OstreeRepo       *repo,
+                                GError          **error)
+ {
+   gboolean ret = FALSE;
+-  g_autofree char *tmpname = g_strdup (""tmpostree-deltaobj-XXXXXX"");
++  g_autofree char *tmpname = g_strdup (""/var/tmp/tmpostree-deltaobj-XXXXXX"");
+   glnx_fd_close int fd = -1;
+   g_autoptr(GBytes) ret_content = NULL;
+   g_autoptr(GInputStream) istream = NULL;","Ugh, we were using cwd? =("
+8079,"@@ -21,7 +21,6 @@ struct screencopy_damage {
+ 	struct pixman_region32 damage;
+ 	struct wl_listener output_precommit;
+ 	struct wl_listener output_destroy;
+-	uint32_t last_commit_seq;
+ };
+
+ static const struct zwlr_screencopy_frame_v1_interface frame_impl;",This can probably be removed?
+8080,"@@ -89,8 +89,9 @@ void FetchExecutor::setupResponse(cpp2::ExecutionResponse &resp) {
+ }
+
+ void FetchExecutor::onEmptyInputs() {
++    auto outputs = std::make_unique<InterimResult>(std::move(resultColNames_));
+     if (onResult_) {
+-        onResult_(nullptr);
++        onResult_(std::move(outputs));
+     } else if (resp_ == nullptr) {
+         resp_ = std::make_unique<cpp2::ExecutionResponse>();
+     }",put this sentence in `if (onResult_) { }`
+8081,"@@ -235,11 +235,16 @@ echo ""echo '{export_forseti_vars}' >> /etc/profile.d/forseti_environment.sh"" | s
+ gsutil cp gs://{scanner_bucket}/configs/forseti_conf_server.yaml {forseti_server_conf}
+ gsutil cp -r gs://{scanner_bucket}/rules {forseti_home}/
+
++# Download the Newest Config Validator constraints from GCS
++rm -rf /home/ubuntu/config_validator_constraints
++gsutil cp -r gs://{scanner_bucket}/config_validator_constraints /home/ubuntu/
++
+ # Start Forseti service depends on vars defined above.
+ bash ./install/gcp/scripts/initialize_forseti_services.sh
+
+ echo ""Starting services.""
+ systemctl start cloudsqlproxy
++systemctl start config-validator
+ sleep 5
+
+ echo ""Attempting to update database schema, if necessary.""",Will this always be started up as default? Is there any impact to the VM in terms of load and memory usage?
+8082,"@@ -374,7 +374,7 @@ class CommandLine
+         /// parsable types (values are comma separated without space).
+         ///
+         /// Qualifiers that are defined BEFORE any parameter sets apply to ALL parameter sets.  qualifiers that
+-        /// are defined AFTER a parameter set will apply only the the parameter set that preceeds them.
++        /// are defined AFTER a parameter set will apply only the the parameter set that precedes them.
+         ///
+         /// See code:#DefiningParametersAndQualifiers
+         /// See code:#Overview",Thanks for fixing the typo's but given that this is a fork of the other commandline.cs file they will still exist there :( Part of the reason forks suck.
+8083,"@@ -141,8 +141,14 @@ import datetime
+ import itertools
+ import logging
+ import luigi
+-import sqlalchemy
+ import os
++import warnings
++
++try:
++    import sqlalchemy
++except ImportError:
++    # Don't fail on import because we want the documentation to be generated
++    warnings.warn(""sqlalchemy could not be imported, db_task_history will not work"", warnings.ImportWarning, stacklevel=3)
+
+
+ class SQLAlchemyTarget(luigi.Target):",This doesn't seem related to docs? :)
+8084,"@@ -233,7 +233,7 @@ public class K9 extends Application {
+     private static boolean hideSpecialAccounts = false;
+     private static boolean autofitWidth;
+     private static boolean quietTimeEnabled = false;
+-    private static boolean notificationDuringQuietTimeEnabled = true;
++    private static boolean notificationDuringQuietTimeDisabled = true;
+     private static String quietTimeStarts = null;
+     private static String quietTimeEnds = null;
+     private static String attachmentDefaultPath = """";","Having a negative in the variable/method name makes the code harder to read. Also, you inverted the logic but didn't invert the default value. I suggest sticking to the original name."
+8085,"@@ -66,8 +66,8 @@ namespace NLog.Targets
+         /// Always use <see cref=""Trace.WriteLine(string)""/> independent of <see cref=""LogLevel""/>
+         /// </summary>
+         /// <docgen category='Output Options' order='100' />
+-        [DefaultValue(false)]
+-        public bool RawWrite { get; set; }
++        [DefaultValue(true)]
++        public bool ForceTraceWriteLine { get; set; } = true;
+
+         /// <summary>
+         /// Forward <see cref=""LogLevel.Fatal"" /> to <see cref=""Trace.Fail(string)"" /> (Instead of <see cref=""Trace.TraceError(string)"" />)",Think you need to keep `RawWrite` around as obsolete until NLog6 (Property that just assigns `ForceTraceWriteLine`)
+8086,"@@ -45,6 +45,9 @@ proc_init_arch(void)
+     num_simd_registers = MCXT_NUM_SIMD_SLOTS;
+     num_opmask_registers = MCXT_NUM_OPMASK_SLOTS;
+
++    set_cache_line_size_using_ctr_el0(/* dcache_line_size= */ &cache_line_size,
++                                      /* icache_line_size= */ NULL);
++
+     /* FIXME i#1569: NYI */
+ }
+ ",I would expect this to be named *get* not *set*: it's a query; it's not setting some persistent state.
+8087,"@@ -2,7 +2,7 @@ import os
+ from typing import Dict, List
+
+ from dagster import SensorDefinition
+-from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext
++from dagster.core.definitions.pipeline_definition_sensor import PipelineFailureSensorContext
+ from dagster_slack import make_slack_on_pipeline_failure_sensor
+ from hacker_news_assets.utils.slack_message import build_slack_message_blocks
+ ",maybe should rename this to be `run_status_sensor_definition.py`
+8088,"@@ -0,0 +1,19 @@
++/*
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *     http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.apache.iceberg.spark;
++
++public class SparkWriteOptions {
++    public static final String FANOUT_ENABLED = ""fanout-enabled"";
++}",Do we want to add the other write options in this PR or keep the refactor separate?
+8089,"@@ -68,7 +68,17 @@ def refresh_user_token(spotify_user):
+         user (domain.spotify.Spotify): the same user with updated tokens
+     """"""
+     auth = get_spotify_oauth()
+-    new_token = auth.refresh_access_token(spotify_user.refresh_token)
++
++    retries = 5
++    new_token = None
++    while retries > 0:
++        new_token = auth.refresh_access_token(spotify_user.refresh_token)
++        if new_token is not None:
++            break
++        retries -= 1
++    if new_token is None:
++        raise SpotifyAPIError('Could not refresh API Token for Spotify user')
++
+     access_token = new_token['access_token']
+     refresh_token = new_token['refresh_token']
+     expires_at = new_token['expires_at']",either make this a config or a constant we can define at the top. Burying this in the code is no good.
+8090,"@@ -73,6 +73,13 @@ def multi_error(y_true, y_pred):
+ def multi_logloss(y_true, y_pred):
+     return np.mean([-math.log(y_pred[i][y]) for i, y in enumerate(y_true)])
+
++def custom_recall(y_true, y_pred):
++    return 'custom_recall', recall_score(y_true, y_pred > 0.5), True
++
++
++def custom_precision(y_true, y_pred):
++    return 'custom_precision', precision_score(y_true, y_pred > 0.5), True
++
+
+ class TestSklearn(unittest.TestCase):
+ ",Same about new metrics. Can we avoid adding them?
+8091,"@@ -40,6 +40,15 @@ def run():
+     group.add_argument('--cloudsql-region',
+                        help='The Cloud SQL region')
+
++    network = parser.add_argument_group(title='network')
++    network.add_argument('--network-host-project-id',
++                         help='The project id that is hosting the network '
++                              'resources.')
++    network.add_argument('--vpc-name',
++                         help='The VPC name where Forseti VM will run.')
++    network.add_argument('--subnet-name',
++                         help='The subnetwork name where Forseti VM will run.')
++
+     email_params = parser.add_argument_group(title='email')
+     email_params.add_argument('--sendgrid-api-key',
+                               help='Sendgrid API key')","I know this is a port from the previous PR, but I am wondering if we can take the chance to improve the naming? `--vpc-host-project-id` ?"
+8092,"@@ -228,7 +228,7 @@ describe('Formulas general', () => {
+       afterChange,
+     });
+
+-    hot.getSourceData()[1][1] = 20;
++    hot.setSourceDataAtCell(1, 1, 20);
+     hot.getPlugin('formulas').recalculateFull();
+     hot.render();
+ ","The test description says it's ""by reference"". We should change the description"
+8093,"@@ -16,9 +16,15 @@ namespace AutoRest.Core.Validation
+         {
+         }
+
++        /// <summary>
++        /// Id of the Rule.
++        /// </summary>
+         public virtual string Id => ""!!! implement me and make me abstract !!!"";
+
+-        public ValidationCategory ValidationCategory => ((ValidationCategory)0); // !!! implement me and make me abstract !!!
++        /// <summary>
++        /// Violation category of the Rule.
++        /// </summary>
++        public virtual ValidationCategory ValidationCategory => ((ValidationCategory)0); // !!! implement me and make me abstract !!!
+
+         /// <summary>
+         /// The template message for this Rule. ",A C# newbie question here: would it make sense to declare Id as an abstract property so any subclass Must have its own Id?
+8094,"@@ -47,6 +47,11 @@ func (r *Repository) Proposals(filter *proposal.Filter) ([]market.ServiceProposa
+ 	return []market.ServiceProposal{}, nil
+ }
+
++// Countries returns proposals per country matching the filter.
++func (r *Repository) Countries(filter *proposal.Filter) (map[string]int, error) {
++	return nil, nil
++}
++
+ // Start begins proposals synchronization to storage.
+ func (r *Repository) Start() error {
+ 	return nil",just looks like you should return an **empty map** with nil error
+8095,"@@ -103,11 +103,18 @@ func main() {
+ 	reloadURL := app.Flag(""reload-url"", ""reload URL to trigger Prometheus reload on"").
+ 		Default(""http://127.0.0.1:9090/-/reload"").URL()
+
++	version.RegisterIntoKingpinFlags(app)
++
+ 	if _, err := app.Parse(os.Args[1:]); err != nil {
+ 		fmt.Fprintln(os.Stderr, err)
+ 		os.Exit(2)
+ 	}
+
++	if version.ShouldPrintVersion() {
++		version.Print(os.Stdout, ""prometheus-config-reloader"")
++		os.Exit(0)
++	}
++
+ 	logger := log.NewLogfmtLogger(log.NewSyncWriter(os.Stdout))
+
+ 	if *logFormat == logFormatJson {",could you also update the starting log at L146?
+8096,"@@ -312,6 +312,16 @@ func isUnitExists(err error) bool {
+ 	return false
+ }
+
++// isDbusClosed returns true if the error is that connection closed.
++func isDbusClosed(err error) bool {
++	if err != nil {
++		if dbusError, ok := err.(dbus.Error); ok {
++			return strings.Contains(dbusError.Name, ""connection closed by user"")
++		}
++	}
++	return false
++}
++
+ func startUnit(dbusConnection *systemdDbus.Conn, unitName string, properties []systemdDbus.Property) error {
+ 	statusChan := make(chan string, 1)
+ 	if _, err := dbusConnection.StartTransientUnit(unitName, ""replace"", properties, statusChan); err == nil {",Also this probably should be `error.As()` or something like it.
+8097,"@@ -219,7 +219,9 @@ webdriver.CommandName = {
+   GET_SESSION_LOGS: 'getSessionLogs',
+
+   // Non-standard commands used by the standalone Selenium server.
+-  UPLOAD_FILE: 'uploadFile'
++  UPLOAD_FILE: 'uploadFile',
++
++  GET_CANVAS_URL: 'getCanvasUrl'
+ };
+
+ ",This is Safari specific and should be defined somewhere in the `safaridriver` namespace
+8098,"@@ -49,6 +49,13 @@ main(int argc, char *argv[])
+       exit (EXIT_SUCCESS);
+   }
+
++  /* We conflict with the magic ostree-mount-deployment-var file for ostree-prepare-root */
++  { struct stat stbuf;
++    if (fstatat (AT_FDCWD, ""/run/ostree-mount-deployment-var"", &stbuf, 0) == 0)
++      exit (EXIT_SUCCESS);
++  }
++
++
+   if (argc > 1 && argc != 4)
+     errx (EXIT_FAILURE, ""This program takes three or no arguments"");
+ ","Let's maybe be nice and `unlinkat()` here in the interest of having `/run` be less littered. Or in addition/alternatively, make the file `/run/ostree/initramfs-mount-var` since we already made `/run/ostree/` for the deployment staging bits."
+8099,"@@ -21,6 +21,7 @@
+
+ #include ""teleport.h""
+ #include ""game.h""
++#include <boost/format.hpp>
+
+ extern Game g_game;
+ ",Not sure if this doesn't require explicitly adding this library to cmake.
+8100,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.
+8101,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?
+8102,"@@ -77,9 +77,10 @@ module Beaker
+     # @option opts [Beaker::Logger] :logger A {Beaker::Logger} object
+     def validate_host host, opts
+       logger = opts[:logger]
++      # Additional Packages to be determined at runtime
++      additional_pkgs = Array.new
+       if opts[:collect_perf_data]
+-        UNIX_PACKAGES << ""sysstat"" if !UNIX_PACKAGES.include? ""sysstat""
+-        SLES_PACKAGES << ""sysstat"" if !SLES_PACKAGES.include? ""sysstat""
++        additional_pkgs << ""sysstat"" if !additional_pkgs.include? ""sysstat""
+       end
+       block_on host do |host|
+         case",This `if` statement can be merged with the above `if opts[:collect_perf_data]`.
+8103,"@@ -110,6 +110,8 @@ func (d Document) Get(fp []string) (interface{}, error) {
+ }
+
+ func (d Document) structField(name string) (reflect.Value, error) {
++	// We do case-insensitive match here to cover the MongoDB's lowercaseFields
++	// option.
+ 	f := d.fields.MatchFold(name)
+ 	if f == nil {
+ 		return reflect.Value{}, gcerr.Newf(gcerr.NotFound, nil, ""field %q not found in struct type %s"", name, d.s.Type())","But won't we do case-insensitive matching for all the drivers? For example, we will get the revision field case-insensitively. Let's make this case-sensitive. I think the way the mongo driver works, by lowercasing field names, will be OK with that."
+8104,"@@ -5,7 +5,10 @@
+
+ <div class=""text-box-wrapper"">
+   <div class=""text-box"">
+-    <h2><%= @product.tagline %></h2>
++    <hgroup class=""product-title"">
++      <h2><%= @product.tagline %></h2>
++      <h3 class=""workshop-type"">Online Workshop</h3>
++    </hgroup>
+
+     <%== @product.description %>
+   </div>","I believe this should be on `workshops/show` now, not `products/show`"
+8105,"@@ -16,6 +16,7 @@ func TestDetectorDetectCountry(t *testing.T) {
+ 		{""95.85.39.36"", ""NL"", """"},
+ 		{""127.0.0.1"", """", """"},
+ 		{""8.8.8.8.8"", """", ""failed to parse IP""},
++		{""185.243.112.225"", """", """"},
+ 		{""asd"", """", ""failed to parse IP""},
+ 	}
+ ","If we return error when we are unable to found country in database, using country detector would be much easier - if error was not returned, that means country was returned :) This doesn't have to be solved in this PR, but since you're adding such case, we can add a `TODO` just to track this :)"
+8106,"@@ -24,7 +24,12 @@ namespace Datadog.Trace.ClrProfiler.Managed.Loader
+             var corlib461Version = new Version(corlib461FileVersionString);
+             var tracerFrameworkDirectory = corlibVersion < corlib461Version ? ""net45"" : ""net461"";
+
+-            var tracerHomeDirectory = Environment.GetEnvironmentVariable(""DD_DOTNET_TRACER_HOME"") ?? string.Empty;
++            var tracerHomeDirectory = Environment.GetEnvironmentVariable(""DD_DOTNET_TRACER_HOME"");
++            if (string.IsNullOrWhiteSpace(tracerHomeDirectory))
++            {
++                tracerHomeDirectory = Path.GetDirectoryName(Environment.GetEnvironmentVariable(""DD_INTEGRATIONS"")) ?? string.Empty;
++            }
++
+             return Path.Combine(tracerHomeDirectory, tracerFrameworkDirectory);
+         }
+ ",.NET Framework: Fallback to `DD_INTEGRATIONS` if `DD_DOTNET_TRACER_HOME` was not set.
+8107,"@@ -111,7 +111,8 @@ def _read_request_line(line: bytes) -> Tuple[str, int, bytes, bytes, bytes, byte
+                 raise ValueError
+         else:
+             scheme, rest = target.split(b""://"", maxsplit=1)
+-            authority, path_ = rest.split(b""/"", maxsplit=1)
++            authority, *paths_ = rest.split(b""/"", maxsplit=1)
++            path_ = paths_[0] if paths_ else b""""
+             path = b""/"" + path_
+             host, port = url.parse_authority(authority, check=True)
+             port = port or url.default_port(scheme)","Can you use `authority, _, path = rest.partition(b""/"")` here? That should make stuff a bit cleaner."
+8108,"@@ -75,6 +75,10 @@ module RSpec::Core
+           options[:order] = ""rand:#{seed}""
+         end
+
++        parser.on('--stress-test LIMIT', Float, 'Repeatedly run randomly selected examples for LIMIT seconds.') do |o|
++          options[:stress_test] = o.to_f
++        end
++
+         parser.on('-d', '--debugger', 'Enable debugging.') do |o|
+           options[:debug] = true
+         end",I don't think this needs to be a float if its a number of seconds... :)
+8109,"@@ -38,7 +38,7 @@ interface FieldProcessor
+     /**
+      * process method
+      *
+-     * @param array Array of values, an array because of multivalued fields
++     * @param array $values of values, an array because of multivalued fields
+      * @return array Modified array of values
+      */
+     public function process(array $values);","Please add ""Array"" back, right now it's not a proper sentence."
+8110,"@@ -509,7 +509,9 @@ public class QueryElevationComponent extends SearchComponent implements SolrCore
+       rb.setQuery(new BoostQuery(elevation.includeQuery, 0f));
+     } else {
+       BooleanQuery.Builder queryBuilder = new BooleanQuery.Builder();
+-      queryBuilder.add(rb.getQuery(), BooleanClause.Occur.SHOULD);
++      BooleanClause.Occur queryOccurrence = params.getBool(QueryElevationParams.ELEVATE_ONLY_DOCS_MATCHING_QUERY, false) ?
++              BooleanClause.Occur.SHOULD : BooleanClause.Occur.MUST;
++      queryBuilder.add(rb.getQuery(), queryOccurrence);
+       queryBuilder.add(new BoostQuery(elevation.includeQuery, 0f), BooleanClause.Occur.SHOULD);
+       if (elevation.excludeQueries != null) {
+         if (params.getBool(QueryElevationParams.MARK_EXCLUDES, false)) {",@tkaessmann when I ran tests I saw this line has a bug. It inverts the SHOULD and MUST. Hopefully I fixed it and merged it without the bug.
+8111,"@@ -301,7 +301,7 @@ func initTelemetry(genesis bookkeeping.Genesis, log logging.Logger, dataDirector
+ 				}
+
+ 				// If the telemetry URI is not set, periodically check SRV records for new telemetry URI
+-				if log.GetTelemetryURI() == """" {
++				if telemetryConfig.Enable && log.GetTelemetryURI() == """" {
+ 					network.StartTelemetryURIUpdateService(time.Minute, cfg, genesis.Network, log, abort)
+ 				}
+ ","There may be another bug, it looks like we're already in a `if telemetryConfig.Enable` block at this point, maybe that block should be unnested?"
+8112,"@@ -944,7 +944,9 @@ class Request(Message):
+
+     def _set_multipart_form(self, value):
+         self.content = multipart.encode(self.headers, value)
+-        self.headers[""content-type""] = ""multipart/form-data""
++        if ""content-type"" not in self.headers:
++            # Don't overwrite header if it already exists or it will destroy the boundary value
++            self.headers[""content-type""] = ""multipart/form-data""
+
+     @property
+     def multipart_form(self) -> multidict.MultiDictView[bytes, bytes]:","This... looks like it plainly didn't work before? Good catch. I would suggest we change the logic here to 1. Check if `self.headers[""content_type""].startswith(""multipart/form-data"")`, and if that's not the case, add a content-type header with a random (?) boundary. The point here is that if someone assigns to `.multipart_form = ` in their addon, the header should be updated accordingly if the request was not multipart before. 2. *After* that, call `self.content = multipart.encode(self.headers, value)` (as we do right now)"
+8113,"@@ -86,9 +86,14 @@ func TestSignBlock(t *testing.T) {
+
+ func TestWrongNonce(t *testing.T) {
+ 	cfg := config.Default
++
++	require := require.New(t)
++	registry := protocol.Registry{}
++	require.NoError(registry.Register(account.ProtocolID, account.NewProtocol()))
++
+ 	ctx := protocol.WithValidateActionsCtx(
+ 		context.Background(),
+-		protocol.ValidateActionsCtx{Genesis: cfg.Genesis},
++		protocol.ValidateActionsCtx{Genesis: cfg.Genesis, Registry: &registry},
+ 	)
+ 	testTrieFile, _ := ioutil.TempFile(os.TempDir(), ""trie"")
+ 	testTriePath := testTrieFile.Name()",importShadow: shadow of imported from 'github.com/stretchr/testify/require' package 'require' (from `gocritic`)
+8114,"@@ -1963,9 +1963,8 @@ get_ibl_routine_type_ex(dcontext_t *dcontext, cache_pc target, ibl_type_t *type
+
+     /* a decent compiler should inline these nested loops */
+     /* iterate in order <linked, unlinked> */
+-    for (link_state = IBL_LINKED;
+-         /* keep in mind we need a signed comparison when going downwards */
+-         (int)link_state >= (int)IBL_UNLINKED; link_state-- ) {
++    link_state = IBL_LINKED;
++    while (true) {
+         /* it is OK to compare to IBL_BB_PRIVATE even when !SHARED_FRAGMENTS_ENABLED() */
+         for (source_fragment_type = IBL_SOURCE_TYPE_START;
+              source_fragment_type < IBL_SOURCE_TYPE_END;",Wouldn't it be enough to change the condition in the for loop to `link_state != IBL_UNLINKED`?
+8115,"@@ -31,7 +31,10 @@
+
+ #include <glib/gi18n.h>
+
++static gboolean opt_verify;
++
+ static GOptionEntry options[] = {
++  { ""verify"", 'V', 0, G_OPTION_ARG_NONE, &opt_verify, ""Print the commit verification status"", NULL },
+   { NULL }
+ };
+ ","I'm not familiar with signed setups, but this does not seem to offer a way to choose between GPG and signapi verification. Are they usually either both enabled or both disabled? Would this be better suited as a verb with flags for different methods?"
+8116,"@@ -951,7 +951,7 @@ func (dao *blockDAO) getBlockValue(blockNS string, h hash.Hash256) ([]byte, erro
+ 		if err != nil {
+ 			return nil, err
+ 		}
+-		value, err = db.Get(blockNS, h[:])
++		value, _ = db.Get(blockNS, h[:])
+ 	}
+ 	return value, err
+ }",assignments should only be cuddled with other assignments (from `wsl`)
+8117,"@@ -11,6 +11,7 @@ C2::Application.routes.draw do
+   post ""/feedback"" => ""feedback#create""
+
+   match ""/auth/:provider/callback"" => ""auth#oauth_callback"", via: [:get]
++  get ""/auth/failure"" => ""auth#failure""
+   post ""/logout"" => ""auth#logout""
+
+   resources :help, only: [:index, :show]",would it make sense to mock oauth in a way that we direct a user to this endpoint on login (in a test)?
+8118,"@@ -5,13 +5,14 @@ define([""events"", ""globalize"", ""dom"", ""datetime"", ""userSettings"", ""serverNotific
+         var html = """";
+         html += '<div class=""listItem listItem-border"">';
+         var color = ""Error"" == entry.Severity || ""Fatal"" == entry.Severity || ""Warn"" == entry.Severity ? ""#cc0000"" : ""#00a4dc"";
++        var icon = ""Error"" == entry.Severity || ""Fatal"" == entry.Severity || ""Warn"" == entry.Severity ? ""notification_important"" : ""notifications"";
+         if (entry.UserId && entry.UserPrimaryImageTag) {
+             html += '<i class=""listItemIcon md-icon"" style=""width:2em!important;height:2em!important;padding:0;color:transparent;background-color:' + color + "";background-image:url('"" + apiClient.getUserImageUrl(entry.UserId, {
+                 type: ""Primary"",
+                 tag: entry.UserPrimaryImageTag,
+                 height: 40
+             }) + ""');background-repeat:no-repeat;background-position:center center;background-size: cover;\"">dvr</i>""
+-        } else html += '<i class=""listItemIcon md-icon"" style=""background-color:' + color + '"">dvr</i>';
++        } else html += '<i class=""listItemIcon md-icon"" style=""background-color:' + color + '"">' + icon + '</i>';
+         html += '<div class=""listItemBody three-line"">', html += '<div class=""listItemBodyText"">', html += entry.Name, html += ""</div>"", html += '<div class=""listItemBodyText secondary"">';
+         var date = datetime.parseISO8601Date(entry.Date, !0);
+         return html += datetime.toLocaleString(date).toLowerCase(), html += ""</div>"", html += '<div class=""listItemBodyText secondary listItemBodyText-nowrap"">', html += entry.ShortOverview || """", html += ""</div>"", html += ""</div>"", entry.Overview && (html += '<button type=""button"" is=""paper-icon-button-light"" class=""btnEntryInfo"" data-id=""' + entry.Id + '"" title=""' + globalize.translate(""Info"") + '""><i class=""md-icon"">info</i></button>'), html += ""</div>""","Since these two lines use the same logic, it may be cleaner to use an `if` statement rather than duplicating it."
+8119,"@@ -3,7 +3,6 @@
+ namespace Shopsys\ShopBundle\Controller\Front;
+
+ use Exception;
+-use Shopsys\FrameworkBundle\Component\Controller\FrontBaseController;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
+ use Shopsys\FrameworkBundle\Component\Error\ErrorPagesFacade;
+ use Shopsys\FrameworkBundle\Component\Error\ExceptionController;",unnecessary blank line
+8120,"@@ -38,6 +38,12 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 2, ""_pos"", Types.LongType.get(), ""Ordinal position of a row in the source data file"");
+   public static final NestedField IS_DELETED = NestedField.required(
+       Integer.MAX_VALUE - 3, ""_deleted"", Types.BooleanType.get(), ""Whether the row has been deleted"");
++  public static final NestedField SPEC_ID = NestedField.required(
++      Integer.MAX_VALUE - 4, ""_spec_id"", Types.IntegerType.get(), ""Spec ID to which a row belongs to"");
++  // the partition column type is not static and depends on all specs in the table
++  public static final int PARTITION_COLUMN_ID = Integer.MAX_VALUE - 5;
++  public static final String PARTITION_COLUMN_NAME = ""_partition"";
++  public static final String PARTITION_COLUMN_DOC = ""Partition to which a row belongs to"";
+
+   // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+   public static final NestedField DELETE_FILE_PATH = NestedField.required(","Nit: no need for ""to"" at the end of the doc because it already uses ""to which""."
+8121,"@@ -0,0 +1,6 @@
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT License. See License.txt in the project root for license information.
++
++[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA1021:AvoidOutParameters"", MessageId = ""2#"", Scope = ""member"", Target = ""Microsoft.Rest.TransientFaultHandling.ShouldRetryHandler.#Invoke(System.Int32,System.Exception,System.TimeSpan&)"")]
++[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA2210:AssembliesShouldHaveValidStrongNames"", Justification=""We do give it strong name and sign it when build in CI server and verify it"")]
++","I would just say ""Signed before publishing."""
+8122,"@@ -21,13 +21,14 @@
+
+ #include <gtest/gtest.h>
+
+-#include <fastrtps/transport/UDPv4Transport.h>
+-#include ""../cpp/rtps/transport/shared_mem/test_SharedMemTransportDescriptor.h""
++#include <rtps/transport/shared_mem/test_SharedMemTransportDescriptor.h>
++#include <rtps/transport/UDPv4Transport.h>
+
+ using namespace eprosima::fastrtps;
+
+ using SharedMemTransportDescriptor = eprosima::fastdds::rtps::SharedMemTransportDescriptor;
+ using test_SharedMemTransportDescriptor = eprosima::fastdds::rtps::test_SharedMemTransportDescriptor;
++using UDPv4Transport = eprosima::fastdds::rtps::UDPv4Transport;
+
+ TEST(SHM, TransportPubSub)
+ {",We can just include the public UDPv4TransportDescriptor header here ...
+8123,"@@ -196,6 +196,9 @@ class BlazeMeterUploader(Reporter, AggregatorListener, MonitoringListener, Singl
+             self._session = Session(self._user, {'id': sess_id})
+             self._session['userId'] = self.parameters.get(""user-id"", None)
+             self._session['testId'] = self.parameters.get(""test-id"", None)
++            data_address = self.settings.get(""data-address"", None)
++            if data_address:
++                self._session['data-address'] = data_address
+             self._test = Test(self._user, {'id': self._session['testId']})
+             exc = TaurusConfigError(""Need signature for session"")
+             self._session.data_signature = self.parameters.get(""signature"", exc)",Why do we need this change?
+8124,"@@ -172,11 +172,15 @@ func (t *Tag) Done(s State) bool {
+ 	return err == nil && n == total
+ }
+
+-// DoneSplit sets total count to SPLIT count and sets the associated swarm hash for this tag
+-// is meant to be called when splitter finishes for input streams of unknown size
++// DoneSplit adds the total with the split count and updated the total.
++// This is useful when you use the same tag for a file and its manifest upload
++// Also the Address is updated with the last called address, so the assumption
++// is that the manifest creation will be called last and this will have the root
++// hash of the manifest
+ func (t *Tag) DoneSplit(address swarm.Address) int64 {
+-	total := atomic.LoadInt64(&t.Split)
+-	atomic.StoreInt64(&t.Total, total)
++	split := atomic.LoadInt64(&t.Split)
++	total := atomic.LoadInt64(&t.Total)
++	atomic.StoreInt64(&t.Total, total+split)
+ 	t.Address = address
+ 	return total
+ }","These three atomic functions done separately are not atomic. There is a possibility of data race, as nothing is guarding Total in between lines 182 and 183. Total got on line 182 may be changed before new value is stored on line 183 by some other goroutine resulting an incorrect value. Mutex should be used."
+8125,"@@ -392,7 +392,7 @@ namespace Nethermind.BeaconNode.Tests.EpochProcessing
+             foreach (var checkpoint in checkpoints)
+             {
+                 var startSlot = beaconChainUtility.ComputeStartSlotOfEpoch(checkpoint.Epoch);
+-                var slotIndex = startSlot % timeParameters.SlotsPerHistoricalRoot;
++                Slot slotIndex = (Slot)(startSlot % timeParameters.SlotsPerHistoricalRoot);
+                 state.SetBlockRoot(slotIndex, checkpoint.Root);
+             }
+         }",Is this because you don't have % on your version of Slot? I don't really care either way.
+8126,"@@ -212,9 +212,14 @@
+           return {
+             pre: function ($scope, $elm, $attrs, uiGridCtrl) {
+               if ( uiGridCtrl.grid.options.enableExpandableRowHeader !== false ) {
+-                var expandableRowHeaderColDef = {name: 'expandableButtons', displayName: '', enableColumnResizing: false, width: 40};
+-                expandableRowHeaderColDef.cellTemplate = $templateCache.get('ui-grid/expandableRowHeader');
+-                uiGridCtrl.grid.addRowHeaderColumn(expandableRowHeaderColDef);
++                var defaultExpandableRowHeaderColDef = {
++                    name: 'expandableButtons',
++                    width: 40,
++                    cellTemplate: $templateCache.get('ui-grid/expandableRowHeader')
++                  },
++                  userInjectedExpandableRowHeaderColDef = $scope.gridOptions.expandableRowHeaderColDef || {},
++                  finalExpandableRowHeaderColDef = angular.extend({}, defaultExpandableRowHeaderColDef, userInjectedExpandableRowHeaderColDef);
++                uiGridCtrl.grid.addRowHeaderColumn(finalExpandableRowHeaderColDef);
+               }
+               uiGridExpandableService.initializeGrid(uiGridCtrl.grid);
+             },",Please use var declaration for variables you are declaring. I could not find one for userInjectedExpandableRowHeaderColDef and finalExpandableRowHeaderColDef. Also code styling in the if block needs to be corrected.
+8127,"@@ -158,12 +158,10 @@ NABoolean TMUDFDllInteraction::describeParamsAndMaxOutputs(
+                                   dummyUser,
+                                      cachedLibName, cachedLibPath))
+         {
+-           NAString cachedFullName = cachedLibPath+""/""+cachedLibName;
+            char errString[200];
+            NAString errNAString;
+-           sprintf(errString , ""Error %d creating directory :"",errno);
++           sprintf(errString , ""Error %d creating directory : %s"", err, cachedLibPath.data());
+            errNAString = errString;
+-           errNAString += cachedFullName;
+            *CmpCommon::diags() <<  DgSqlCode(-4316)
+                                   << DgString0(( char *)errNAString.data());
+            bindWA->setErrStatus();","If cachedLibPath > 200 bytes, it will overflow errString."
+8128,"@@ -202,6 +202,10 @@ const ariaRoles = {
+     allowedAttrs: ['aria-expanded'],
+     superclassRole: ['landmark']
+   },
++  generic: {
++    type: 'structure',
++    prohibitedAttrs: ['aria-label', 'aria-labelledby']
++  },
+   grid: {
+     type: 'composite',
+     requiredOwned: ['rowgroup', 'row'],","Talked this through with a few more folks. I think it would be better to flag prohibited attributes for review, instead of outright failing them. ARIA labels are used fairly liberally. We don't really know if they are actually needed whenever they are used."
+8129,"@@ -565,8 +565,11 @@ func (pool *TxPool) validateTx(tx *types.Transaction, local bool) error {
+ 	}
+ 	// Transactor should have enough funds to cover the costs
+ 	// cost == V + GP * GL
+-	if pool.currentState.GetBalance(from).Cmp(tx.Cost()) < 0 {
+-		return ErrInsufficientFunds
++	if !rcfg.UsingOVM {
++		// This check is done in SyncService.verifyFee
++		if pool.currentState.GetBalance(from).Cmp(tx.Cost()) < 0 {
++			return ErrInsufficientFunds
++		}
+ 	}
+ 	// Ensure the transaction has more gas than the basic tx fee.
+ 	intrGas, err := IntrinsicGas(tx.Data(), tx.To() == nil, true, pool.istanbul)",Let's keep it to avoid the diff
+8130,"@@ -63,7 +63,8 @@ public class SparkTable implements org.apache.spark.sql.connector.catalog.Table,
+
+   private static final Logger LOG = LoggerFactory.getLogger(SparkTable.class);
+
+-  private static final Set<String> RESERVED_PROPERTIES = Sets.newHashSet(""provider"", ""format"", ""current-snapshot-id"");
++  private static final Set<String> RESERVED_PROPERTIES =
++      Sets.newHashSet(""provider"", ""format"", ""current-snapshot-id"", ""location"");
+   private static final Set<TableCapability> CAPABILITIES = ImmutableSet.of(
+       TableCapability.BATCH_READ,
+       TableCapability.BATCH_WRITE,","nit: not directly related to this PR, but shall we use `ImmutableSet` for consistency?"
+8131,"@@ -109,10 +109,10 @@ module Blacklight
+     # @return [Blacklight::Solr::Response] the solr response object
+     def to_hash
+       return @params unless params_need_update?
+-      @params = processed_parameters.
+-                  reverse_merge(@reverse_merged_params).
+-                  merge(@merged_params).
+-                  tap { clear_changes }
++      @params = processed_parameters
++                  .reverse_merge(@reverse_merged_params)
++                  .merge(@merged_params)
++                  .tap { clear_changes }
+     end
+
+     alias_method :query, :to_hash","Layout/DotPosition: Place the . on the previous line, together with the method call receiver."
+8132,"@@ -628,7 +628,10 @@ public class ClientManager {
+                     Log.w(""AccMgrAuthTokenProvider:fetchNewAuthToken"", ""accountManager.getAuthToken returned null bundle"");
+                 } else {
+                     newAuthToken = bundle.getString(AccountManager.KEY_AUTHTOKEN);
+-                    newInstanceUrl = bundle.getString(AuthenticatorService.KEY_INSTANCE_URL);
++                    final String encryptedInstanceUrl = bundle.getString(AuthenticatorService.KEY_INSTANCE_URL);
++                    if (encryptedInstanceUrl != null) {
++                        newInstanceUrl = SalesforceSDKManager.decryptWithPasscode(encryptedInstanceUrl, SalesforceSDKManager.getInstance().getPasscodeHash());
++                    }
+                     Intent broadcastIntent;
+                     if (newAuthToken == null) {
+                         if (clientManager.revokedTokenShouldLogout) {","We send the `instanceUrl` encrypted, but never bothered to decrypt it. I guess it was working because we never did any org split testing where the `instanceUrl` actually changes."
+8133,"@@ -43,6 +43,12 @@ public class BftBlockHeaderFunctions implements BlockHeaderFunctions {
+         bftExtraDataCodec);
+   }
+
++  public static BlockHeaderFunctions forCmsSignature(final BftExtraDataCodec bftExtraDataCodec) {
++    return new BftBlockHeaderFunctions(
++        h -> new BftBlockHashing(bftExtraDataCodec).calculateHashOfBftBlockForCmsSignature(h),
++        bftExtraDataCodec);
++  }
++
+   @Override
+   public Hash hash(final BlockHeader header) {
+     return hashFunction.apply(header);",Can this be moved to QbftBlockHeaderFunctions class as it is only used for qbft
+8134,"@@ -95,14 +95,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver
+             }
+         }
+
+-        public IList<string> Tags
+-        {
+-            get
+-            {
+-                throw new NotImplementedException();
+-            }
+-        }
+-
+         public void Analyze(TestAnalysisContext context)
+         {
+             if (_exceptionCondition == ExceptionCondition.InvokingAnalyze)",`Tags` now comes from the `PropertyBagHolder` base class.
+8135,"@@ -61,7 +61,7 @@ class TextPlot(ElementPlot):
+                 data[k].extend(eld)
+         return data, elmapping, style
+
+-    def get_extents(self, element, ranges=None):
++    def get_extents(self, element, ranges=None, range_type='combined'):
+         return None, None, None, None
+
+ ","I'm not sure where this should go, but one of the `get_extents` methods should mention that `range_type` can be `'data'` or `'combined'` (are there others?). I found out those are the two expected values by searching the code..."
+8136,"@@ -25,14 +25,13 @@ import java.util.List;
+ import java.util.Locale;
+ import java.util.Map;
+ import java.util.TreeMap;
+-import java.util.logging.Logger;
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
+ import zipkin2.codec.SpanBytesDecoder;
+ import zipkin2.codec.SpanBytesEncoder;
+ import zipkin2.internal.Nullable;
+ import zipkin2.internal.Platform;
+
+-import static java.lang.String.format;
+-import static java.util.logging.Level.FINEST;
+ import static zipkin2.internal.HexCodec.HEX_DIGITS;
+
+ /**",please revert all of this stuff in core.. I'll take another pass after. cheers and thanks for the help!
+8137,"@@ -50,6 +50,7 @@ public class TestCreateTableAsSelect extends SparkCatalogTestBase {
+   @After
+   public void removeTables() {
+     sql(""DROP TABLE IF EXISTS %s"", tableName);
++    sql(""DROP TABLE IF EXISTS %s"", sourceName);
+   }
+
+   @Test",Why was this needed?
+8138,"@@ -179,8 +179,8 @@ func (brq *blockRetrievalQueue) Request(ctx context.Context, priority int, kmd K
+ 				brq.config.BlockCache().GetWithPrefetch(ptr)
+ 			if err == nil && cachedBlock != nil {
+ 				block.Set(cachedBlock, brq.config.codec())
+-				brq.triggerPrefetchAfterBlockRetrieved(
+-					cachedBlock, kmd, priority, hasPrefetched)
++				brq.Prefetcher().PrefetchAfterBlockRetrieved(
++					cachedBlock, ptr, kmd, priority, lifetime, hasPrefetched)
+ 				ch <- nil
+ 				return ch
+ 			}","I see that CI found a couple test hangs, maybe your `TogglePrefetcher` change below wasn't enough and this still needs to be a `go` invocation for some reason?"
+8139,"@@ -125,7 +125,7 @@ class DomainInfoCommand extends Command
+
+         $propertyExtractor = new ReflectionExtractor();
+         $io->writeln('You can access these properties:');
+-        $io->listing($propertyExtractor->getProperties($domainConfig));
++        $io->listing($propertyExtractor->getProperties(get_class($domainConfig)));
+     }
+
+     /**",I do not understand this change
+8140,"@@ -5398,6 +5398,9 @@ type InputService24TestShapeInputService24TestCaseOperation1Input struct {
+
+ 	Header1 *string `location:""header"" type:""string""`
+
++	// By default keys received from the service api response will be formatted
++	// using net/http.CanonicalHeaderKey.
++	// Set aws.Config.LowerCaseHeaderMaps to `true` to lower case keys.
+ 	HeaderMap map[string]*string `location:""headers"" locationName:""header-map-"" type:""map""`
+ }
+ ",It would be helpful to clarify this is only for unmarshaling a response. not marshaling a request.
+8141,"@@ -109,7 +109,7 @@ describe('nested-interactive virtual-rule', function() {
+
+     var results = axe.runVirtualRule('nested-interactive', node);
+
+-    assert.lengthOf(results.passes, 0);
++    assert.lengthOf(results.passes, 1);
+     assert.lengthOf(results.violations, 1);
+     assert.lengthOf(results.incomplete, 0);
+   });","I have no explanation for why this test wasn't erroring before... There are two applicable nodes in this tree, one passes, the other fails."
+8142,"@@ -26,7 +26,7 @@
+
+ #ifdef HAVE_CONFIG_H
+ #include <config.h>
+-#endif // HAVE_CONFIG_H
++#endif // HAVE_CONFIG_Hrm
+
+ #include <glob.h>
+ #include <stdio.h>","Remove the ""rm"" from the end of ""HAVE_CONFIG_H"""
+8143,"@@ -15,3 +15,11 @@ func (p *FakeProver) CalculatePoSt(ctx context.Context, start, end *types.BlockH
+ 		Proofs: []types.PoStProof{[]byte(""test proof"")},
+ 	}, nil
+ }
++
++// TrivialTestSlasher is a storage fault slasher that does nothing
++type TrivialTestSlasher struct{}
++
++// Slash is a required function for storageFaultSlasher interfaces and is intended to do nothing.
++func (ts *TrivialTestSlasher) Slash(context.Context, *types.BlockHeight) error {
++	return nil
++}",Non-Blocking: This might be too trivial. It doesn't allow us to test that it's being callled.
+8144,"@@ -278,6 +278,8 @@ switch (datatype)
+   case REC_INT_FRACTION: return extFormat? (char *)""INTERVAL FRACTION"":(char *)""REC_INT_FRACTION"";
+   case REC_BLOB: return extFormat? (char *)""BLOB"":(char *)""REC_BLOB"";
+   case REC_CLOB: return extFormat? (char *)""CLOB"":(char *)""REC_CLOB"";
++  case REC_BOOLEAN: return extFormat ? (char *)""BOOLEAN"" : (char *)""BOOLEAN"";
++
+   // When you add new datatype in /common/dfs2rec.h, don't
+   // forget add new case here. Otherwise, showplan won't display it.
+   default: return extFormat? (char *)""UNKNOWN"":(char *)""add datatype in getDatatypeAsString()"";","Not sure why the ternary expressions are used here, since the true and false results are the same."
+8145,"@@ -263,7 +263,7 @@ func getTranslationFunc(driverName string) (func() translationFunc, error) {
+ 	switch driverName {
+ 	case ""sqlite3"":
+ 		return SqliteColumnTranslateFunc, nil
+-	case ""postgres"", ""sqlmock"":
++	case ""postgres"", ""sqlmock"", ""vertica"", ""vertigo"":
+ 		return PostgresColumnTranslateFunc, nil
+ 	case ""mysql"":
+ 		return MysqlColumnTranslateFunc, nil",Is `vertigo` another name for Vertica databases?
+8146,"@@ -236,6 +236,7 @@ class HintActions:
+                utils.supports_selection())
+
+         urlstr = url.toString(QUrl.FullyEncoded | QUrl.RemovePassword)
++        urlstr = urlstr.lstrip('mailto:')
+         utils.set_clipboard(urlstr, selection=sel)
+
+         msg = ""Yanked URL to {}: {}"".format(","That doesn't do the right thing - it strips any of the characters m, a, i, l, t, o and :. It'd probably be cleaner to do this before converting the URL to a string."
+8147,"@@ -98,12 +98,14 @@ cliUtils.makeCommandArgs = function(cmd, argv) {
+ 		}
+ 	}
+
++
+ 	const args = yargParser(argv, {
+ 		boolean: booleanFlags,
+ 		alias: aliases,
+ 		string: ['_'],
+ 	});
+
++
+ 	for (let i = 1; i < cmdUsage['_'].length; i++) {
+ 		const a = cliUtils.parseCommandArg(cmdUsage['_'][i]);
+ 		if (a.required && !args['_'][i]) throw new Error(_('Missing required argument: %s', a.name));",Why the white space changes?
+8148,"@@ -0,0 +1,8 @@
++class LicenseMailerPreview < ActionMailer::Preview
++  def fullfillment_error
++    user = User.new(name: 'John Doe')
++    repository = Repository.first
++
++    LicenseMailer.fulfillment_error(repository, user)
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+8149,"@@ -235,12 +235,11 @@ func (zone *ZoneDb) DomainLookupInaddr(inaddr string) (res []ZoneRecord, err err
+ func (zone *ZoneDb) startUpdatingName(name string) {
+ 	if zone.refreshInterval > 0 {
+ 		zone.mx.Lock()
+-		defer zone.mx.Unlock()
+-
+ 		// check if we should enqueue a refresh request for this name
+ 		n := zone.getNameSet(defaultRemoteIdent).getName(name, true)
++		now := zone.clock.Now()
++		zone.mx.Unlock() // Don't hold the lock while talking to the SchedQueue
+ 		if n.lastRefreshTime.IsZero() {
+-			now := zone.clock.Now()
+ 			n.lastRefreshTime = now
+
+ 			Debug.Printf(""[zonedb] Creating new immediate refresh request for '%s'"", name)","This is now outside the mutex, so could race."
+8150,"@@ -43,11 +43,7 @@ import org.apache.lucene.index.SortedSetDocValues;
+ import org.apache.lucene.index.TermsEnum;
+ import org.apache.lucene.search.DocIdSetIterator;
+ import org.apache.lucene.search.SortedSetSelector;
+-import org.apache.lucene.store.ByteBuffersDataOutput;
+-import org.apache.lucene.store.ByteBuffersIndexOutput;
+-import org.apache.lucene.store.ChecksumIndexInput;
+-import org.apache.lucene.store.IOContext;
+-import org.apache.lucene.store.IndexOutput;
++import org.apache.lucene.store.*;
+ import org.apache.lucene.util.ArrayUtil;
+ import org.apache.lucene.util.BytesRef;
+ import org.apache.lucene.util.BytesRefBuilder;",hmmm did this pass spotless check? I don't think we typically use wildcard imports
+8151,"@@ -222,8 +222,8 @@ func (j journalMDOps) getRangeFromJournal(
+ 	return irmds, nil
+ }
+
+-func (j journalMDOps) GetForHandle(
+-	ctx context.Context, handle *TlfHandle, mStatus MergeStatus) (
++func (j journalMDOps) GetForHandle(ctx context.Context, handle *TlfHandle,
++	mStatus MergeStatus, lockBeforeLock *keybase1.LockID) (
+ 	tlfID tlf.ID, rmd ImmutableRootMetadata, err error) {
+ 	// TODO: Ideally, *TlfHandle would have a nicer String() function.
+ 	j.jServer.log.LazyTrace(ctx, ""jMDOps: GetForHandle %+v %s"", handle, mStatus)",`lockBeforeLock` -> `lockBeforeGet` (here and everywhere below).
+8152,"@@ -12,7 +12,7 @@ import java.util.List;
+ import org.junit.Test;
+
+ import net.sourceforge.pmd.PMD;
+-import net.sourceforge.pmd.lang.java.ast.JavaParserConstants;
++import net.sourceforge.pmd.lang.java.ast.JavaTokenKinds;
+
+ public class JavaTokensTokenizerTest {
+ ","Do we need to internalize net.sourceforge.pmd.lang.java.ast.JavaParserConstants on master, so that we can rename it?"
+8153,"@@ -36,7 +36,7 @@ namespace Nethermind.Vault
+             {1, new Guid(""deca2436-21ba-4ff5-b225-ad1b0b2f5c59"")},
+             {3, new Guid(""66d44f30-9092-4182-a3c4-bc02736d6ae5"")},
+             {4, new Guid(""07102258-5e49-480e-86af-6d0c3260827d"")},
+-            {5, new Guid(""1b16996e-3595-4985-816c-043345d22f"")},
++            //{5, new Guid(""1b16996e-3595-4985-816c-043345d22f"")},
+             {42, new Guid(""8d31bf48-df6b-4a71-9d7c-3cb291111e27"")}
+         };
+ ","The GUID here was incorrect, because of that, Vault plugin loading was failing. Should I change to any correct GUID, or it has some special meaning?"
+8154,"@@ -84,9 +84,6 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests
+             // giving some breezing room for the End callback to complete
+             await Task.Delay(TimeSpan.FromSeconds(1));
+
+-            // Invokes the TestExporter which will invoke ProcessExport
+-            metricReader.Collect();
+-
+             this.meterProvider.Dispose();
+
+             var requestMetrics = metricItems","just confirming: if we remove explicit Collect(), then we are relying on the provider dispose... which has a hard-coded 5000 msec to finish flushing. On the other hand, if we keep explicit Collect(), we can pass an explicit timeout to it. (we were not doing it now and was relying on Infinite timeout). Net effect of this change in test code: Previously we would wait indefinitely for Collect() to be over. With this PR, we hope Collect() will be over in 5 secs. If we ever need more than 5 sec, we need to bring back Collect(maxTimeInMilliSecs..)."
+8155,"@@ -22,4 +22,16 @@ public class Constants {
+ 	public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";
+ 	public static final String DEFAULT_CONF_PATH = ""conf"";
+ 	public static final String AZKABAN_EXECUTOR_PORT_FILENAME = ""executor.port"";
++
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_GLOBAL_DISABLE = ""azkaban.logging.kafka.globalDisable"";
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_BROKERLIST = ""azkaban.logging.kafka.brokerList"";
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_TOPIC = ""azkaban.logging.kafka.topic"";
++
++  public static final String AZKABAN_FLOW_PROJECT_NAME = ""azkaban.flow.projectname"";
++  public static final String AZKABAN_FLOW_FLOW_ID = ""azkaban.flow.flowid"";
++  public static final String AZKABAN_FLOW_SUBMIT_USER = ""azkaban.flow.submituser"";
++  public static final String AZKABAN_FLOW_EXEC_ID = ""azkaban.flow.execid"";
++  public static final String AZKABAN_FLOW_PROJECT_VERSION = ""azkaban.flow.projectversion"";
++
++  public static final String AZKABAN_JOB_LOGGING_KAFKA_ENABLE = ""azkaban.job.logging.kafka.enable"";
+ }",What do you think of a name like azkaban.server.logging.kafka.brokerList? This way the name signals that this is a server config.
+8156,"@@ -449,6 +449,12 @@ namespace NLog.Targets
+             get
+             {
+ #if SupportsMutex
++
++                if (!PlatformDetector.SupportsSharableMutex)
++                {
++                    return _concurrentWrites ?? false;  // Better user experience for mobile platforms
++                }
++
+                 return _concurrentWrites ?? true;
+ #else
+                 return _concurrentWrites ?? false;  // Better user experience for mobile platforms",Maybe change into `return _concurrentWrites ?? PlatformDetector.SupportsSharableMutex` ?
+8157,"@@ -63,7 +63,8 @@ public class CircleStyleFinalizerTests {
+
+         finalizer.createCircleReport();
+
+-        String report = Resources.toString(targetFile.toURI().toURL(), StandardCharsets.UTF_8);
++        String report = Resources.toString(targetFile.toURI().toURL(), StandardCharsets.UTF_8)
++                .replaceAll(""\\p{Blank}*(?=<)"", """");
+         String expectedReport = Resources.toString(
+                 testFile(""two-namecheck-failures-checkstyle-report.xml""), StandardCharsets.UTF_8);
+ ",indentation of resulting file is different between 11 and 8 where 8 doesn't indent lines and 11 does
+8158,"@@ -82,13 +82,14 @@ func (u *unaryTransportHandler) Handle(ctx context.Context, req *Request, reqBuf
+ 	}
+
+ 	if appErr != nil {
+-		// TODO: This is a bit odd; we set the error in response AND return it.
+-		// However, to preserve the current behavior of YARPC, this is
+-		// necessary. This is most likely where the error details will be added,
+-		// so we expect this to change.
++		encodedError, err := codec.EncodeError(appErr)
++		if err != nil {
++			return res, nil, err
++		}
++
+ 		errorInfo := yarpcerror.ExtractInfo(appErr)
+ 		res.ApplicationErrorInfo = &errorInfo
+-		return res, encodedBody, appErr
++		return res, encodedError, nil
+ 	}
+
+ 	return res, encodedBody, nil",Do we still need to return the `Response` here?
+8159,"@@ -18,3 +18,4 @@ if (global.document) {
+   }));
+   document.execCommand = jest.fn();
+ }
++global.VERDACCIO_API_URL = 'http://localhost/-/verdaccio/'",Here `global.VERDACCIO_API_URL` I'd use something different as `global.TEST_VERDACCIO_API_URL` then when you search by `VERDACCIO_API_URL` we don't confuse with `window.VERDACCIO_API_URL`
+8160,"@@ -57,6 +57,13 @@ public class DiscoveryFragmentGeneratorTool {
+             .hasArg()
+             .argName(""OUTPUT-DIRECTORY"")
+             .build());
++    options.addOption(
++        Option.builder()
++            .longOpt(""auth_url"")
++            .desc(""A comma delimited map of language to auth instructions URL."")
++            .hasArg()
++            .argName(""AUTH-URL"")
++            .build());
+
+     CommandLine cl = (new DefaultParser()).parse(options, args);
+     if (cl.hasOption(""help"")) {","This is totally fine, but consider whether in the future a YAML input format would be better. If so, we can plan for it."
+8161,"@@ -277,6 +277,14 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+
++        /// <summary>
++        /// Configuration key for the semantic convention to be used.
++        /// The Tracer uses it to define operation names, span tags, statuses etc.
++        /// Default is <c>""Default""</c>.
++        /// <seealso cref=""TracerSettings.Convention""/>
++        /// </summary>
++        public const string Convention = ""DD_CONVENTION"";
++
+         /// <summary>
+         /// Configuration key for setting the API key, used by the Agent.
+         /// This key is here for troubleshooting purposes.",This should be `DD_TRACE_CONVENTION` to follow our ... conventions.
+8162,"@@ -241,8 +241,7 @@ Status VariablePropertyExpression::prepare() {
+
+
+ OptVariantType EdgeTypeExpression::eval(Getters &getters) const {
+-    UNUSED(getters);
+-    return *alias_;
++    return getters.getAliasProp(*alias_, *prop_);
+ }
+
+ Status EdgeTypeExpression::prepare() {",Be careful memory leaks. memory leaks occur when getters.getAliasProp == nullptr . right?
+8163,"@@ -281,6 +281,7 @@ type readCache struct {
+
+ 	// This is for routes and gateways to have their own L1 as well that is account aware.
+ 	pacache map[string]*perAccountCache
++	losc    int64 // last orphan subs check
+
+ 	// This is for when we deliver messages across a route. We use this structure
+ 	// to make sure to only send one message and properly scope to queues as needed.",Why not just a time.Time?
+8164,"@@ -213,7 +213,7 @@ class DefaultFormatBundle:
+                 continue
+             results[key] = DC(to_tensor(results[key]))
+         if 'gt_masks' in results:
+-            results['gt_masks'] = DC(results['gt_masks'], cpu_only=True)
++            results['gt_masks'] = DC(to_tensor(results['gt_masks']), cpu_only=True)
+         if 'gt_semantic_seg' in results:
+             results['gt_semantic_seg'] = DC(
+                 to_tensor(results['gt_semantic_seg'][None, ...]), stack=True)",Please do not submit a commit that is not part of this PR.
+8165,"@@ -410,11 +410,11 @@ func (d *HandlerImpl) UpdateDomain(
+
+ 	if updateRequest.UpdatedInfo != nil {
+ 		updatedInfo := updateRequest.UpdatedInfo
+-		if updatedInfo.Description != nil {
++		if updatedInfo.GetDescription() != """" {
+ 			configurationChanged = true
+ 			info.Description = updatedInfo.GetDescription()
+ 		}
+-		if updatedInfo.OwnerEmail != nil {
++		if updatedInfo.GetOwnerEmail() != """" {
+ 			configurationChanged = true
+ 			info.OwnerEmail = updatedInfo.GetOwnerEmail()
+ 		}","This is small braking change: there is no way to clear description any more. If value is empty string, description will not be updated at all. It will affect existing Thrift endpoints also."
+8166,"@@ -16,5 +16,8 @@ func DNS01Record(domain, value string) (string, string, int) {
+ 	if err == nil && r.Rcode == dns.RcodeSuccess {
+ 		fqdn = updateDomainWithCName(r, fqdn)
+ 	}
+-	return fqdn, value, 60
++	if err != nil {
++		return """", """", 0, err
++	}
++	return fqdn, value, 60, nil
+ }",Can you open a separate PR with this patch? It seems valuable outside the context of this PR!
+8167,"@@ -52,6 +52,9 @@ func (s *server) setupRouting() {
+ 	router.Handle(""/peers/{address}"", jsonhttp.MethodHandler{
+ 		""DELETE"": http.HandlerFunc(s.peerDisconnectHandler),
+ 	})
++	router.Handle(""/chunk/{address}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.hasChunkHandler),
++	})
+
+ 	baseRouter.Handle(""/"", web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""debug api access""),","I would suggest to have plurals in the api `""/chunks/{address}""`"
+8168,"@@ -1365,6 +1365,7 @@ namespace pwiz.Skyline.Model
+             ALL_LABEL_SUBSTITUTIONS = ImmutableList.ValueOf(new[]
+         {
+             Tuple.Create(LabelAtoms.C13, BioMassCalc.C, BioMassCalc.C13),
++            Tuple.Create(LabelAtoms.C14, BioMassCalc.C, BioMassCalc.C14),
+             Tuple.Create(LabelAtoms.N15, BioMassCalc.N, BioMassCalc.N15),
+             Tuple.Create(LabelAtoms.O18, BioMassCalc.O, BioMassCalc.O18),
+             Tuple.Create(LabelAtoms.H2, BioMassCalc.H, BioMassCalc.H2),","Let's just not do this. We don't have LabelAtoms.O17 here. This is just a short-cut to avoid needing to write out a more verbose function like: 5O"" - 5O i.e. Add 5 x 17O atoms to replace 5 x 16O atoms. This was the original implementation in Skyline before I added the checkboxes to denote simply labeling all atoms in the amino acid."
+8169,"@@ -56,7 +56,7 @@ def bootstrap_accept_mini(field, **kwargs):
+                          name=""submitButton"",
+                          type=""submit"",
+                          value=field.label.text,
+-                         onclick=""mini_approval('Accept', event, %s);"" % (objectid,),)
++                         onclick=""approval.mini_approval('Accept', event, %s);"" % (objectid,),)
+     return HTMLString(u''.join(html))
+
+ ","1:D100: Docstring missing 23:D400: First line should end with '.', not 'p' 23:D200: One-line docstring should not occupy 3 lines 36:D400: First line should end with '.', not 'n' 36:D200: One-line docstring should not occupy 3 lines 48:D400: First line should end with '.', not 'p' 48:D200: One-line docstring should not occupy 3 lines 63:D400: First line should end with '.', not 'p' 63:D200: One-line docstring should not occupy 3 lines 76:D400: First line should end with '.', not 'p' 76:D200: One-line docstring should not occupy 3 lines"
+8170,"@@ -73,6 +73,10 @@ class CarouselLoop extends Image
+     {
+         /** @var \Carousel\Model\Carousel $carousel */
+         foreach ($loopResult->getResultDataCollection() as $carousel) {
++            if (!file_exists($carousel->getUploadDir() . DS . $carousel->getFile())) {
++                continue;
++            }
++
+             $loopResultRow = new LoopResultRow($carousel);
+
+             $event = new ImageEvent();",Adding a warning or an error in the Thelia log would be a nice idea.
+8171,"@@ -26,6 +26,8 @@ var CONNECTED = 'connected';
+ var DESTROYING = 'destroying';
+ var DESTROYED = 'destroyed';
+
++const CONNECTION_EVENTS = ['error', 'close', 'timeout', 'parseError', 'connect', 'message'];
++
+ var _id = 0;
+
+ /**",nit: `Set` (and swap `forEach`s for `for (const i of CONNECTION_EVENTS)`)
+8172,"@@ -4,7 +4,7 @@ using System.Collections.Generic;
+ using System.Linq;
+ using System.Reflection;
+ using System.Reflection.Emit;
+-using System.Runtime.InteropServices;
++using Datadog.Trace.ClrProfiler.ExtensionMethods;
+ using Datadog.Trace.ClrProfiler.Helpers;
+ using Datadog.Trace.Configuration;
+ using Datadog.Trace.Logging;",nit: Is this `using` statement still needed?
+8173,"@@ -26,7 +26,7 @@ func (endpoint *identitiesApi) List(writer http.ResponseWriter, request *http.Re
+ 	idsSerializable := make([]identityDto, len(idArry))
+ 	for i, id := range idArry {
+ 		idsSerializable[i] = identityDto{
+-			Id: string(id),
++			Id: string(id.Id),
+ 		}
+ 	}
+ ",Dont need to cast `string` -> `string`
+8174,"@@ -35,6 +35,11 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	s.Addressbook.Put(address, addr)
++	if err := s.TopologyDriver.AddPeer(r.Context(), address); err != nil {
++		s.Logger.Debugf(""debug api: topologyDriver.AddPeer %s: %v"", addr, err)
++	}
++
+ 	jsonhttp.OK(w, peerConnectResponse{
+ 		Address: address.String(),
+ 	})",why doesn't the API return an error in this case?
+8175,"@@ -583,3 +583,18 @@ class InvalidInstanceMetadataError(Exception):
+     def __init__(self, msg):
+         final_msg = msg + '\n' + self.MSG
+         super(InvalidInstanceMetadataError, self).__init__(final_msg)
++
++
++class BaseEndpointResolverError(Exception):
++    """"""Base error for endpoint resolving errors.
++
++    Should never be raised directly, but clients can catch
++    this exception if they want to generically handle any errors
++    during the endpoint resolution process.
++
++    """"""
++
++
++class NoRegionError(BaseEndpointResolverError):
++    """"""No region was specified.""""""
++    fmt = 'You must specify a region.'",Not sure how particularly useful these exceptions are. Seem to be exceptions required in copying and pasting the EndpointResolver over. I wonder if it makes sense to move these out of ``exceptions.py``
+8176,"@@ -203,9 +203,6 @@ class Proposal < ActiveRecord::Base
+     end
+   end
+
+-
+-  ## delegated methods ##
+-
+   def public_identifier
+     self.delegate_with_default(:public_identifier) { ""##{self.id}"" }
+   end",Can we re-add this? I think that grouping is useful (though would be open to putting them in a mixin or something).
+8177,"@@ -319,7 +319,7 @@ public class PartitionSpec implements Serializable {
+     private final Schema schema;
+     private final List<PartitionField> fields = Lists.newArrayList();
+     private final Set<String> partitionNames = Sets.newHashSet();
+-    private Map<Integer, PartitionField> timeFields = Maps.newHashMap();
++    private Map<String, PartitionField> partitionFields = Maps.newHashMap();
+     private int specId = 0;
+     private final AtomicInteger lastAssignedFieldId = new AtomicInteger(PARTITION_DATA_ID_START - 1);
+ ","Overall LGTM, one nit is that I think `partitionFields` here would be good to be renamed so that it's easy to tell it's just for collision detection. Also I wonder if we want to do this check for other transformations too (e.g. bucket, and record numBuckets in the string), so that we might be able to combine `fields` and `partitionFields` into potentially something like a LinkedHashMap?"
+8178,"@@ -34,6 +34,8 @@ class Config(object):
+                               datetime.datetime.now().strftime('%Y%m%d%H%M%S'))
+         self.identifier = None
+         self.force_no_cloudshell = bool(kwargs.get('no_cloudshell'))
++        self.service_account_key_path = kwargs.get(
++            'service_account_key_path') or None
+         self.config_filename = (kwargs.get('config') or
+                                 'forseti-setup-{}.cfg'.format(
+                                     self.datetimestamp))","Don't need the `or None` here as the flag will already default to None. Also, `some_dict.get('foo')` will also default to `None`."
+8179,"@@ -68,6 +68,7 @@ storiesOf( 'Settings', module )
+ 		options: {
+ 			delay: 3000, // Wait for tabs to animate.
+ 		},
++		padding: 0,
+ 	} )
+ 	.add( 'Connected Services', () => {
+ 		const setupRegistry = ( registry ) => {","Please, use the default padding here."
+8180,"@@ -3,11 +3,12 @@
+ const Aspect = require('./operation').Aspect;
+ const OperationBase = require('./operation').OperationBase;
+ const resolveReadPreference = require('../utils').resolveReadPreference;
++const serverLacksFeature = require('../utils').serverLacksFeature;
+ const ReadConcern = require('../read_concern');
+ const WriteConcern = require('../write_concern');
+ const maxWireVersion = require('../core/utils').maxWireVersion;
+ const commandSupportsReadConcern = require('../core/sessions').commandSupportsReadConcern;
+-const MongoError = require('../error').MongoError;
++const MongoError = require('../core').MongoError;
+
+ const SUPPORTS_WRITE_CONCERN_AND_COLLATION = 5;
+ ",let's actually use the direct include: `require('../core/error').MongoError;`
+8181,"@@ -227,6 +227,16 @@ def data(readonly=False):
+              ""How to open links in an existing instance if a new one is ""
+              ""launched.""),
+
++            ('new-instance-open-target.window',
++             SettingValue(typ.String(
++                 valid_values=typ.ValidValues(
++                     ('last-opened', ""Open new tabs in the last""
++                     ""opened window.""),
++                     ('last-focused', ""Open new tabs in the most""
++                     ""recently focused window."")
++                 )), 'last-focused'),
++             ""Which window to choose when opening links as new tabs.""),
++
+             ('log-javascript-console',
+              SettingValue(typ.String(
+                  valid_values=typ.ValidValues(","You're missing a space before the `""` here and below, but I'll fix it up when merging."
+8182,"@@ -119,6 +119,11 @@ void testBookmarks(ROMol m) {
+   m.clearBondBookmark(777);
+ }
+
++void dump(STR_VECT &p) {
++  std::cerr << ""----------------------------------"" << std::endl;
++  for(size_t i=0;i<p.size();++i)
++    std::cerr << p[i] << std::endl;
++}
+ void testMolProps() {
+   BOOST_LOG(rdInfoLog)
+       << ""-----------------------\n Testing Mol Property Caches"" << std::endl;",remove this debugging code?
+8183,"@@ -22,14 +22,14 @@ class ParallelPostingsArray {
+   final static int BYTES_PER_POSTING = 3 * Integer.BYTES;
+
+   final int size;
+-  final int[] textStarts;
+-  final int[] intStarts;
+-  final int[] byteStarts;
++  final int[] textStarts; // maps term ID to the terms text start in the bytesHash
++  final int[] addressOffset; // maps term ID to current stream address
++  final int[] byteStarts; // maps term ID to stream start offset in the byte pool
+
+   ParallelPostingsArray(final int size) {
+     this.size = size;
+     textStarts = new int[size];
+-    intStarts = new int[size];
++    addressOffset = new int[size];
+     byteStarts = new int[size];
+   }
+ ",s/`terms text`/`terms's text`
+8184,"@@ -23,6 +23,7 @@ module.exports = class Form extends Plugin {
+       resultName: 'uppyResult',
+       getMetaFromForm: true,
+       addResultToForm: true,
++      replaceResultInFormWithNew: true,
+       submitOnSuccess: false,
+       triggerUploadOnSubmit: false
+     }",":bike: :derelict_house: , but maybe the default option should be `multipleResults: false` or `combineMultipleResults: false`? i feel like `replaceResultInFormWithNew` is very verbose but also doesn't immediately clarify what it's for."
+8185,"@@ -1,15 +1,16 @@
+ require ""rails_helper""
+
+-feature 'Visitor signs up for a subscription' do
++feature ""Visitor signs up for a subscription"" do
+   background do
+     create_plan
+   end
+
+-  scenario 'visitor signs up by navigating from landing page' do
++  scenario ""visitor signs up by navigating from landing page"", js: true do
+     create(:trail, :published)
+
+     visit root_path
+-    click_link ""Sign Up Now!""
++    click_link I18n.t(""subscriptions.new.sign_up_cta"")
++    show_email_and_username_form
+     fill_out_account_creation_form
+     fill_out_credit_card_form_with_valid_credit_card
+ ",Line is too long. [87/80]
+8186,"@@ -2,10 +2,8 @@
+ #  Copyright (C) 2006 Greg Landrum
+ #  This file is part of RDKit and covered by $RDBASE/license.txt
+ #
+-
+-
+-import argparse
+ import sys
++import argparse
+
+ from rdkit import Chem
+ from rdkit import Geometry",Are you using an automated tool for sorting the imports?
+8187,"@@ -41,11 +41,11 @@ class ApiClient(object):
+     __metaclass__ = abc.ABCMeta
+
+     @abc.abstractmethod
+-    def fetch_bigquery_dataset_policy(self, project_id, dataset_id):
++    def fetch_bigquery_dataset_policy(self, project_number, dataset_id):
+         """"""Dataset policy Iterator for a dataset from gcp API call.
+
+         Args:
+-            project_id (str): id of the project to query.
++            project_number (str): id of the project to query.
+             dataset_id (str): id of the dataset to query.
+         """"""
+ ","If this is `project_number` now, can we also update the `id` the description?"
+8188,"@@ -132,6 +132,7 @@ func (s *receiveStream) readImpl(p []byte) (bool /*stream completed */, int, err
+ 				}
+ 				if deadlineTimer == nil {
+ 					deadlineTimer = utils.NewTimer()
++					defer deadlineTimer.Stop()
+ 				}
+ 				deadlineTimer.Reset(deadline)
+ 			}","* This will defer until the function returns. Are you sure this won't happen multiple times. * Alternatively, why is the deadline timer not defined outside the outer loop? * More generally, why are we looping in the first place instead of reading one frame and returning?"
+8189,"@@ -36,10 +36,10 @@ namespace Datadog.Trace.Agent.Transports
+             _request.Headers.Add(name, value);
+         }
+
+-        public async Task<IApiResponse> PostAsync(ArraySegment<byte> traces)
++        public async Task<IApiResponse> PostAsync(ArraySegment<byte> traces, string contentType)
+         {
+             _request.Method = ""POST"";
+-            _request.ContentType = ""application/msgpack"";
++            _request.ContentType = contentType;
+             using (var requestStream = await _request.GetRequestStreamAsync().ConfigureAwait(false))
+             {
+                 await requestStream.WriteAsync(traces.Array, traces.Offset, traces.Count).ConfigureAwait(false);",Should we rename the traces parameter now that this isn't just traces?
+8190,"@@ -28,14 +28,14 @@ static void atomic_begin(struct wlr_drm_crtc *crtc, struct atomic *atom) {
+ 	atom->failed = false;
+ }
+
+-static bool atomic_end(int drm_fd, struct atomic *atom) {
++static bool atomic_end(int drm_fd, uint32_t flags, struct atomic *atom) {
+ 	if (atom->failed) {
+ 		return false;
+ 	}
+
+-	uint32_t flags = DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_NONBLOCK;
++	flags |= DRM_MODE_ATOMIC_TEST_ONLY;
+ 	if (drmModeAtomicCommit(drm_fd, atom->req, flags, NULL)) {
+-		wlr_log_errno(WLR_ERROR, ""Atomic test failed"");
++		wlr_log_errno(WLR_DEBUG, ""Atomic test failed"");
+ 		drmModeAtomicSetCursor(atom->req, atom->cursor);
+ 		return false;
+ 	}",I don't think it makes sense to have both `TEST_ONLY` and `NONBLOCK`. We should probably leave `NONBLOCK` out.
+8191,"@@ -109,7 +109,10 @@ static void touch_point_handle_surface_destroy(struct wl_listener *listener,
+ 		void *data) {
+ 	struct wlr_touch_point *point =
+ 		wl_container_of(listener, point, surface_destroy);
+-	touch_point_destroy(point);
++	// Touch point itself is destroyed on up event
++	point->surface = NULL;
++	wl_list_remove(&point->surface_destroy.link);
++	wl_list_init(&point->surface_destroy.link);
+ }
+
+ static struct wlr_touch_point *touch_point_create(",Need to remove the surface destroy listener (and `wl_list_init` it so that `touch_point_destroy` still works)
+8192,"@@ -31,7 +31,8 @@ class ResearchProjectsController < ApplicationController
+
+   def fetch_projects
+     Rails.cache.fetch([""research_projects"", funder_type], expires_in: expiry) do
+-      Thread.new { ExternalApis::OpenAireService.search(funder: funder_type) }.value
++      #Thread.new { ExternalApis::OpenAireService.search(funder: funder_type) }.value
++      ExternalApis::OpenAireService.search(funder: funder_type)
+     end
+   end
+ ",create ticket to investigate this
+8193,"@@ -90,7 +90,7 @@ typedef struct
+   struct sockaddr_storage addr;
+ } ipaddress_t;
+
+-static socklen_t address_length(ipaddress_t* ipaddr)
++PONY_API socklen_t address_length(ipaddress_t* ipaddr)
+ {
+   switch(ipaddr->addr.ss_family)
+   {","If we want to expose this for FFI use in the standard library, it needs to get either a `pony_` or `ponyint_` prefix to its name, for cleanliness of the function namespace. `pony_` means it is a public API meant for use by third party code, whereas `ponyint_` means it is internal. Unless there is a good reason to make it public, we should prefer to keep it internal because public functions require us to treat any changes to them as breaking changes in Pony. So, this function should end up named `ponyint_address_length`, or something else with that prefix."
+8194,"@@ -17,6 +17,8 @@ const (
+ 	OptionsWaitBeforeDelete = ""WAIT_BEFORE_DELETE""
+ 	// OptionsRedirectDetach Redirect detach to the node where volume is attached
+ 	OptionsRedirectDetach = ""REDIRECT_DETACH""
++	// OptionsDeviceFuseMount name of fuse mount device
++	OptionsDeviceFuseMount = ""DEV_FUSE_MOUNT""
+ )
+
+ func IsBoolOptionSet(options map[string]string, key string) bool {","Fuse for shared volumes is a px specific implementation. libopenstorage doesn't know about it, right? So should this be called DeviceVirtualMount (or something similar) instead?"
+8195,"@@ -24,6 +24,13 @@ namespace Datadog.Trace.ClrProfiler
+
+         public ushort TargetSignatureTypesLength;
+
++        [MarshalAs(UnmanagedType.U1)]
++        public bool UseTargetMethodArgumentsToLoad;
++
++        public IntPtr TargetMethodArgumentsToLoad;
++
++        public ushort TargetMethodArgumentsToLoadLength;
++
+         public ushort TargetMinimumMajor;
+
+         public ushort TargetMinimumMinor;",`bool` vs `BOOL` in native side :)
+8196,"@@ -17,6 +17,7 @@ const chromiumRebaseL10n = require('../lib/chromiumRebaseL10n')
+ const createDist = require('../lib/createDist')
+ const upload = require('../lib/upload')
+ const test = require('../lib/test')
++const lint = require('../lib/lint')
+
+ program
+   .version(process.env.npm_package_version)",I think maybe you moved it to util but this is still around and it should get it from util instead.
+8197,"@@ -0,0 +1,16 @@
++class RepositoriesController < ApplicationController
++  def index
++    @catalog = Catalog.new
++  end
++
++  def show
++    repository = Repository.friendly.find(params[:id])
++    @offering = Offering.new(repository, current_user)
++
++    if @offering.user_has_license?
++      redirect_to repository.github_url
++    else
++      render template: ""products/show""
++    end
++  end
++end",Do we need to test the redirection?
+8198,"@@ -372,12 +372,12 @@ public class EpisodesApplyActionFragment extends Fragment {
+     }
+
+     private void markedCheckedPlayed() {
+-        DBWriter.markItemPlayed(getActivity(), FeedItem.PLAYED, checkedIds.toArray());
++        DBWriter.markItemPlayed(FeedItem.PLAYED, checkedIds.toArray());
+         close();
+     }
+
+     private void markedCheckedUnplayed() {
+-        DBWriter.markItemPlayed(getActivity(), FeedItem.UNPLAYED, checkedIds.toArray());
++        DBWriter.markItemPlayed(FeedItem.UNPLAYED, checkedIds.toArray());
+         close();
+     }
+ ","Tsts, that's why... activity leak about to happen"
+8199,"@@ -3160,6 +3160,9 @@ func (s *Server) startGWReplyMapExpiration() {
+ 				}
+ 			case cttl := <-s.gwrm.ch:
+ 				ttl = cttl
++				if !t.Stop() {
++					<-t.C
++				}
+ 				t.Reset(ttl)
+ 			case <-s.quitCh:
+ 				return",You should do a select here IMO just to be safe so we do not block forever.
+8200,"@@ -119,7 +119,7 @@ type Node struct {
+ 	// Incoming messages for block mining.
+ 	MsgPool *core.MessagePool
+ 	// Messages sent and not yet mined.
+-	Outbox *core.MessageQueue
++	MsgQueue *core.MessageQueue
+
+ 	Wallet *wallet.Wallet
+ ",I'll replace this with the actual outbox object soon.
+8201,"@@ -218,6 +218,9 @@ class AnnotationTest extends TestCase
+      */
+     public function providerValidCodeParse(): iterable
+     {
++        $codebase = $this->project_analyzer->getCodebase();
++        $codebase->reportUnusedVariables();
++
+         return [
+             'nopType' => [
+                 '<?php","Providers are called *before* `setUp()`, so I don't think you can access properties here."
+8202,"@@ -11,7 +11,7 @@ namespace Xunit
+     /// Apply this attribute to your test method to specify an active issue.
+     /// </summary>
+     [TraitDiscoverer(""Xunit.NetCore.Extensions.ActiveIssueDiscoverer"", ""Xunit.NetCore.Extensions"")]
+-    [AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
++    [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = true)]
+     public class ActiveIssueAttribute : Attribute, ITraitAttribute
+     {
+         public ActiveIssueAttribute(int issueNumber, TestPlatforms platforms) { }",While this allows it to be applied does it correctly cause the entire class to be skipped?
+8203,"@@ -143,6 +143,11 @@ def main():
+     if args.seed is not None:
+         logger.info(f'Set random seed to {args.seed}, '
+                     f'deterministic: {args.deterministic}')
++
++        # import torch.distributed as dist
++        # rank = dist.get_rank()
++        # args.seed = args.seed + rank
++
+         set_random_seed(args.seed, deterministic=args.deterministic)
+     cfg.seed = args.seed
+     meta['seed'] = args.seed",clean unnecessary modification.
+8204,"@@ -44,8 +44,8 @@ describe('createElement(jsx)', () => {
+ 	});
+
+ 	it('should set VNode#key property', () => {
+-		expect(<div />).to.have.property('key').that.is.undefined;
+-		expect(<div a=""a"" />).to.have.property('key').that.is.undefined;
++		expect(<div />).to.have.property('key').that.is.empty;
++		expect(<div a=""a"" />).to.have.property('key').that.is.empty;
+ 		expect(<div key=""1"" />).to.have.property('key', '1');
+ 	});
+ ",I think these assertions want to be `.to.not.exist` which would pass for `null` or `undefined`
+8205,"@@ -24,11 +24,9 @@ import (
+ )
+
+ func ExampleOpenKeeper() {
+-	// This example is used in https://gocloud.dev/howto/secrets/#vault-ctor
+-
+-	// import _ ""gocloud.dev/secrets/hashivault""
+-
+-	// Variables set up elsewhere:
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/secrets/hashivault""
++	// PRAGMA(gocloud.dev): Skip until next blank line.
+ 	ctx := context.Background()
+
+ 	// Get a client to use with the Vault API.",Don't think you need this since this is not a URL example.
+8206,"@@ -43,6 +43,14 @@ class TestFakerNumber < Test::Unit::TestCase
+     assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
+   end
+
++  def test_decimal_within
++    assert @tester.decimal_within(l_digits: 1, r_digits: 1, range: 0..1).to_s.match(/[0-1]{1}\.[0-1]{1}/)
++    assert @tester.decimal_within(l_digits: 1).to_s.match(/[0-9]{1}\.[0-9]{2}/)
++    assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
++    assert @tester.decimal_within(l_digits: 3, r_digits: 3, range: 1..100).to_s.match(/[0-9]*\.[0-9]*/)
++    assert @tester.decimal_within(l_digits: 3, r_digits: 3, range: 1..1000).to_s.match(/[0-9]*\.[0-9]*/)
++  end
++
+   def test_digit
+     assert @tester.digit.to_s.match(/[0-9]{1}/)
+     assert((1..1000).collect { |_i| @tester.digit == 9 }.include?(true))","Maybe a test to check if the generated value is within the boundaries would be nice, what do you think?"
+8207,"@@ -12,7 +12,7 @@ namespace AutoRest.Core.Utilities
+     {
+         public void WriteFile(string path, string contents)
+         {
+-            File.WriteAllText(path, contents, Encoding.UTF8);
++            File.WriteAllText(path, contents, new UTF8Encoding(false, true));
+         }
+
+         /// <summary>",Suppresses UTF-8 BOM in outputs
+8208,"@@ -65,10 +65,10 @@ type Config struct {
+ 	Inbounds  Inbounds
+ 	Outbounds Outbounds
+
+-	// Filter and Interceptor that will be applied to all outgoing and incoming
+-	// requests respectively.
+-	Filter      transport.Filter
+-	Interceptor transport.Interceptor
++	// Inbound and Outbound Middleware that will be applied to all outgoing and
++	// incoming requests respectively.
++	InboundMiddleware  InboundMiddleware
++	OutboundMiddleware OutboundMiddleware
+
+ 	Tracer opentracing.Tracer
+ }","order wrong for ""outgoing and incoming"""
+8209,"@@ -43,6 +43,7 @@ public class MemoryCircuitBreaker extends CircuitBreaker {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+   private static final MemoryMXBean MEMORY_MX_BEAN = ManagementFactory.getMemoryMXBean();
+
++  private boolean isMemoryCircuitBreakerEnabled;
+   private final long heapMemoryThreshold;
+
+   // Assumption -- the value of these parameters will be set correctly before invoking getDebugInfo()","We know it's a boolean and it's in the MemoryCircuitBreaker, why not simply call it `enabled` (like many other Solr plugins do)?"
+8210,"@@ -0,0 +1,5 @@
++class AddIncludesTeamToIndividualPlans < ActiveRecord::Migration
++  def change
++    add_column :individual_plans, :includes_team, :boolean, default: false
++  end
++end","Should team be a ""feature"" that can be ""included"" or a type? In code it seems to me that a `team` flag makes sense."
+8211,"@@ -172,6 +172,9 @@ type OutputInfo struct {
+ }
+
+ func (i *InputParams) updateParams(p *string) {
++	logParamsMutex.Lock()
++	defer logParamsMutex.Unlock()
++
+ 	if p == nil {
+ 		return
+ 	}",Why is this called update params when it's updating project info? Should p called project?
+8212,"@@ -44,7 +44,8 @@ const (
+ 	// below are templates for history_tree table
+ 	addHistoryTreeQuery = `INSERT INTO history_tree (` +
+ 		`shard_id, tree_id, branch_id, data, data_encoding) ` +
+-		`VALUES (:shard_id, :tree_id, :branch_id, :data, :data_encoding) `
++		`VALUES (:shard_id, :tree_id, :branch_id, :data, :data_encoding) ` +
++		`ON DUPLICATE KEY UPDATE data=VALUES(data), data_encoding=VALUES(data_encoding)`
+
+ 	getHistoryTreeQuery = `SELECT branch_id, data, data_encoding FROM history_tree WHERE shard_id = ? AND tree_id = ? `
+ ",`upsertHistoryTreeQuery` is a better name for this query now. Is it ok to change history?
+8213,"@@ -33,8 +33,12 @@ namespace Nethermind.Core
+             }
+             string date = DateTime.Now.ToString(""yyyyMMdd"");
+             string gitTag = File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-hash"")) ? File.ReadAllText(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-hash"")).Trim().Replace(""g"", """") : string.Empty;
+-
+-            Description = $""Nethermind/v{gitTag}-{date}/{RuntimeInformation.OSArchitecture}-{osDescription}/{RuntimeInformation.FrameworkDescription.Trim().Replace("".NET "", """").Replace("" "", """")}"";
++            string gitBranch = File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-branch"")) ? File.ReadAllText(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-branch"")).Trim().Replace(""/"", ""-"") : string.Empty;
++            if (gitBranch != ""master"")
++            {
++                gitTag = gitTag.Insert(5, ""b"");
++            }
++            Description = $""Nethermind/v{gitTag}-{date}/{gitBranch}/{RuntimeInformation.OSArchitecture}-{osDescription}/{RuntimeInformation.FrameworkDescription.Trim().Replace("".NET "", """").Replace("" "", """")}"";
+         }
+
+         public static string Version { get; }",b did not mean branch - it meant the next version - so probably better to be able to release from a tag on the branch so we can create a hotfix branch of the 1.4.1 tag and tag it 1.4.1b and then version is picked as 1.4.1b
+8214,"@@ -9,7 +9,6 @@
+  *  Created on: Jul 26, 2017
+  *      Author: William F Godoy godoywf@ornl.gov
+  */
+-#include <mpi.h>
+
+ #include <ios>       //std::ios_base::failure
+ #include <iostream>  //std::cout","Keep the mpi.h include, just move it to after adios2.h and guard with the ifdef. Otherwise everything else looks good."
+8215,"@@ -72,8 +72,12 @@ type Config struct {
+ 	// bind mounts are writtable.
+ 	Readonlyfs bool `json:""readonlyfs""`
+
+-	// Privatefs will mount the container's rootfs as private where mount points from the parent will not propogate
+-	Privatefs bool `json:""privatefs""`
++	// RootfsMountMode is the rootfs mount propagation mode.
++	// On linux it is one of the followings:
++	// ""private"": rootfs is mounted as MS_PRIVATE
++	// ""shared"": rootfs is mounted as MS_SHARED
++	// ""slave"": rootfs is mounted as MS_SLAVE
++	RootfsMountMode PropagationMode `json:""root_mount_mode""`
+
+ 	// Mounts specify additional source and destination paths that will be mounted inside the container's
+ 	// rootfs and mount namespace if specified",Shouldn't this be something like `rootmountmode` to fit the pattern of the other fields' serialized representations?
+8216,"@@ -747,9 +747,7 @@ void Cuda::impl_initialize(const Cuda::SelectDevice config,
+                            size_t /*num_instances*/) {
+   Impl::CudaInternal::singleton().initialize(config.cuda_device_id, 0);
+
+-#if defined(KOKKOS_ENABLE_PROFILING)
+   Kokkos::Profiling::initialize();
+-#endif
+ }
+
+ std::vector<unsigned> Cuda::detect_device_arch() {",Why were we initializing here in the first place?
+8217,"@@ -0,0 +1,7 @@
++namespace MvvmCross.Core.Platform.LogProviders
++{
++    internal sealed class NullLogProvider : MvxBaseLogProvider
++    {
++        protected override Logger GetLogger(string name) => new Logger((logLevel, messageFunc, exception, formatParameters) => true);
++    }
++}","This should be removed, and instead set the logger to None."
+8218,"@@ -49,7 +49,7 @@ function UndoRedo(instance) {
+       return;
+     }
+
+-    var originalData = plugin.instance.getSourceDataArray();
++    var originalData = plugin.instance.getSourceData();
+
+     index = (originalData.length + index) % originalData.length;
+ ",Storing a reference to source data isn't the best choice. Maybe you can find a different way (without storing the reference) to save removed data?
+8219,"@@ -7761,7 +7761,7 @@ void UDR::processData(UDRInvocationInfo &info,
+  *
+  *  This method is called in debug Trafodion builds when certain
+  *  flags are set in the UDR_DEBUG_FLAGS CQD (CONTROL QUERY DEFAULT).
+- *  See https://wiki.trafodion.org/wiki/index.php/Tutorial:_The_object-oriented_UDF_interface#Debugging_UDF_code
++ *  See https://cwiki.apache.org/confluence/display/TRAFODION/Tutorial%3A+The+object-oriented+UDF+interface#Tutorial:Theobject-orientedUDFinterface-DebuggingUDFcode
+  *  for details.
+  *
+  *  The default implementation prints out the process id and then",Is the tutorial going to move to the new Trafodion website or will it stay on the Confluence wiki? (Check with Gunnar.)
+8220,"@@ -55,10 +55,8 @@ func FromStatus(st *status.Status) error {
+ 		switch errDetails := errDetails.(type) {
+ 		case *errordetails.ShardOwnershipLostFailure:
+ 			return newShardOwnershipLost(st, errDetails)
+-		case *errordetails.RetryTaskFailure:
+-			return newRetryTask(st, errDetails)
+ 		case *errordetails.RetryTaskV2Failure:
+-			return newRetryTaskV2(st, errDetails)
++			return convertRetryReplication(st, errDetails)
+ 		}
+ 	}
+ ",maybe call it `fromRetryTaskV2Failure`
+8221,"@@ -16,11 +16,13 @@ package com.google.api.codegen.transformer.php;
+
+ import com.google.api.codegen.InterfaceView;
+ import com.google.api.codegen.config.FieldConfig;
++import com.google.api.codegen.config.FlatteningConfig;
+ import com.google.api.codegen.config.GapicProductConfig;
+ import com.google.api.codegen.config.GrpcStreamingConfig.GrpcStreamingType;
+ import com.google.api.codegen.metacode.InitCodeContext;
+ import com.google.api.codegen.metacode.InitCodeContext.InitCodeOutputType;
+ import com.google.api.codegen.php.PhpGapicCodePathMapper;
++import com.google.api.codegen.transformer.DynamicLangApiMethodTransformer;
+ import com.google.api.codegen.transformer.FileHeaderTransformer;
+ import com.google.api.codegen.transformer.GapicInterfaceContext;
+ import com.google.api.codegen.transformer.GapicMethodContext;","The diff for this class is difficult to walk through because I reorganized it to be much more clear. There are improvements throughout, but the most important are in the new `createSmokeTest.*` methods."
+8222,"@@ -164,6 +164,12 @@ class BaseDetector(BaseModule, metaclass=ABCMeta):
+         should be double nested (i.e.  List[Tensor], List[List[dict]]), with
+         the outer list indicating test time augmentations.
+         """"""
++        img_norm_cfg = kwargs.get('img_norm_cfg', None)
++        if img_norm_cfg:
++            mean = torch.tensor(img_norm_cfg['mean'])[None, ..., None, None]
++            std = torch.tensor(img_norm_cfg['std'])[None, ..., None, None]
++            img = (img - mean) / std
++
+         if torch.onnx.is_in_onnx_export():
+             assert len(img_metas) == 1
+             return self.onnx_export(img[0], img_metas[0])",We suggest keeping this logic in lines between 173-175 to restrict its influence.
+8223,"@@ -88,7 +88,7 @@ class GridView
+      * @param string $name
+      * @param array $parameters
+      * @param bool $echo
+-     * @return string|null
++     * @return string|null|void
+      */
+     public function renderBlock($name, array $parameters = [], $echo = true)
+     {",why not ? maybe another phpstan plugin
+8224,"@@ -37,14 +37,16 @@ namespace Nethermind.JsonRpc.Modules.Trace
+         private readonly ITracer _tracer;
+         private readonly IBlockFinder _blockFinder;
+         private readonly TransactionDecoder _txDecoder = new TransactionDecoder();
+-        private readonly CancellationToken _cancellationToken;
++        private readonly IJsonRpcConfig _jsonRpcConfig;
++        private readonly TimeSpan _cancellationTokenTimeout;
+
+-        public TraceModule(IReceiptFinder receiptFinder, ITracer tracer, IBlockFinder blockFinder, CancellationToken cancellationToken = default(CancellationToken))
++        public TraceModule(IReceiptFinder receiptFinder, ITracer tracer, IBlockFinder blockFinder, IJsonRpcConfig jsonRpcConfig)
+         {
+-            _cancellationToken = cancellationToken;
+             _receiptFinder = receiptFinder ?? throw new ArgumentNullException(nameof(receiptFinder));
+             _tracer = tracer ?? throw new ArgumentNullException(nameof(tracer));
+             _blockFinder = blockFinder ?? throw new ArgumentNullException(nameof(blockFinder));
++            _jsonRpcConfig = jsonRpcConfig ?? throw new ArgumentNullException(nameof(jsonRpcConfig));
++            _cancellationTokenTimeout = TimeSpan.FromMilliseconds(_jsonRpcConfig.TracerTimeout);
+         }
+
+         private static ParityTraceTypes GetParityTypes(string[] types)",That was a really bad CR from me before if I did not spot it.
+8225,"@@ -203,7 +203,15 @@ EOF
+ echo ""$FORSETI_ENV"" > $USER_HOME/forseti_env.sh
+
+ USER=ubuntu
+-(echo ""{run_frequency} $FORSETI_HOME/setup/gcp/scripts/run_forseti.sh"") | crontab -u $USER -
++
++# Use flock to prevent rerun of the same cron job when the previous job is still running.
++# If the lock file does not exist under the tmp directory, it will create the file and put a lock on top of the file.
++# When the previous cron job is not finished and the new one is trying to run, it will attempt to acquire the lock
++# to the lock file and fail because the file is already locked by the previous process.
++# The -n flag in flock will fail the process right away when the process is not able to acquire the lock so we won't
++# queue up the jobs.
++
++(echo ""{run_frequency} /usr/bin/flock -n /tmp/forseti_cron_runner.lock $FORSETI_HOME/setup/gcp/scripts/run_forseti.sh"") | crontab -u $USER -
+ echo ""Added the run_forseti.sh to crontab under user $USER""
+
+ echo ""Execution of startup script finished""","Does this resolve the scenario when the user-triggered forseti process is running, and it would be killed by the cron job restarting the server?"
+8226,"@@ -157,7 +157,6 @@ func (ops *OpStream) Intc(constIndex uint) {
+ 	} else {
+ 		ops.trace(""intc %d %d"", constIndex, ops.intc[constIndex])
+ 	}
+-	ops.tpush(StackUint64)
+ }
+
+ // Uint writes opcodes for loading a uint literal",Does this happen somewhere else now?
+8227,"@@ -749,7 +749,8 @@ import browser from './browser';
+         }
+
+         // Support H264 Level 52 (Tizen 5.0) - app only
+-        if (browser.tizenVersion >= 5 && window.NativeShell) {
++        if ((browser.tizenVersion >= 5 && window.NativeShell) ||
++            videoTestElement.canPlayType('video/mp4; codecs=""avc1.640834""').replace(/no/, '')) {
+             maxH264Level = 52;
+         }
+ ","Remove trailing space at this line, amend the commit, and then force-push."
+8228,"@@ -21,6 +21,8 @@ import (
+ 	""testing""
+ 	""time""
+
++	""go.opentelemetry.io/api/trace""
++
+ 	""google.golang.org/grpc/codes""
+
+ 	""go.opentelemetry.io/api/core""","This should be grouped together with the import of ""go.opentelemetry.io/{api/core,sdk/export}"" below."
+8229,"@@ -66,10 +66,14 @@ REQUIREMENTS_MAP = {
+         {'module_name': 'instance_network_interface_scanner',
+          'class_name': 'InstanceNetworkInterfaceScanner',
+          'rules_filename': 'instance_network_interface_rules.yaml'},
++    'ke_scanner':
++        {'module_name': 'ke_scanner',
++         'class_name': 'KeScanner',
++         'rules_filename': 'ke_rules.yaml'},
+     'ke_version_scanner':
+         {'module_name': 'ke_version_scanner',
+          'class_name': 'KeVersionScanner',
+-         'rules_filename': 'ke_rules.yaml'},
++         'rules_filename': 'ke_version_rules.yaml'},
+     'log_sink':
+         {'module_name': 'log_sink_scanner',
+          'class_name': 'LogSinkScanner',","What's the impact to people upgrading to the new version? If they don't change their file names, they'll suddenly be broken. While I agree that your naming makes more intuitive sense, I think we need to maintain backwards compatibility. Please choose a new rules file name for the new scanner and keep ke_rules.yaml for the existing version scanner."
+8230,"@@ -698,7 +698,7 @@ class InternalFrame(object):
+         index_spark_columns = self.index_spark_columns
+         return index_spark_columns + [
+             spark_column
+-            for label, spark_column in zip(self.column_labels, self.data_spark_columns)
++            for spark_column in self.data_spark_columns
+             if all(not spark_column._jc.equals(scol._jc) for scol in index_spark_columns)
+         ]
+ ","Shall we add some docstrings clearly to describe when to use which clearly? For example, `spark_frame` now should always be used via `df._internal.applied.spark_frame` for Spark DataFrame APIs that internally creates new query execution plan with the different output length. For expressions and/or functions, `df._internal.spark_frame` should be used together with Spark column instances, in order to avoid the operations on different DataFrames."
+8231,"@@ -54,8 +54,8 @@ class DataFrame(_Frame):
+         Dict can contain Series, arrays, constants, or list-like objects
+         If data is a dict, argument order is maintained for Python 3.6
+         and later.
+-        Note that if `data` is a Pandas DataFrame other arguments are ignored.
+-        If data is a Spark DataFrame, all other arguments except `index` is ignored.
++        Note that if `data` is a Pandas DataFrame, other arguments should not be used
++        If `data` is a Spark DataFrame, all other arguments except `index` should not be used.
+     index : Index or array-like
+         Index to use for resulting frame. Will default to RangeIndex if
+         no indexing information part of input data and no index provided",nit: `.` at the end of line?
+8232,"@@ -2012,7 +2012,16 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
+
+     private void updateFooterView() {
+         if (!mSearch.isManualSearch() && mCurrentFolder != null && mAccount != null) {
+-            if (mCurrentFolder.loading) {
++            int msg=100;
++            try {
++                msg=mCurrentFolder.folder.getMessageCount();
++            } catch (MessagingException e) {
++                e.printStackTrace();
++            }
++            if (msg==0){
++                updateFooter(mContext.getString(R.string.no_email));
++            }
++            else if (mCurrentFolder.loading) {
+                 updateFooter(mContext.getString(R.string.status_loading_more));
+             } else if (!mCurrentFolder.moreMessages) {
+                 updateFooter(null);","I'm not sure I agree that this should take priority over ""Loading""."
+8233,"@@ -237,8 +237,6 @@ class PySparkTask(SparkSubmitTask):
+
+     # Path to the pyspark program passed to spark-submit
+     app = os.path.join(os.path.dirname(__file__), 'pyspark_runner.py')
+-    # Python only supports the client deploy mode, force it
+-    deploy_mode = ""client""
+
+     @property
+     def name(self):",Was this an intentional deletion? Why not just allow overwrite of `deploy_mode`?
+8234,"@@ -168,7 +168,16 @@ func (c *CStorVolumeReplicaController) syncHandler(
+ 	// Synchronize cstor volume total allocated and
+ 	// used capacity fields on CVR object.
+ 	// Any kind of sync activity should be done from here.
+-	c.syncCvr(cvrGot)
++	err = c.syncCvr(cvrGot)
++	if err != nil {
++		c.recorder.Event(
++			cvrGot,
++			corev1.EventTypeWarning,
++			""SyncFailed"",
++			fmt.Sprintf(""failed to sync CVR error: %s"", err.Error()),
++		)
++		return nil
++	}
+
+ 	_, err = c.clientset.
+ 		OpenebsV1alpha1().",better to call it as syncCVRStatus.. just syncCVR is very confusing
+8235,"@@ -29,11 +29,14 @@ var (
+ 	errAppDeleteCancelled = errors.New(""app delete cancelled - no changes made"")
+ )
+
+-type deleteAppOpts struct {
+-	// Flags or arguments that are user inputs.
++type deleteAppVars struct {
+ 	*GlobalOpts
+ 	SkipConfirmation bool
+ 	AppName          string
++}
++
++type deleteAppOpts struct {
++	deleteAppVars
+
+ 	// Interfaces to dependencies.
+ 	projectService   projectService",should we make this not a pointer? so that when we embed the struct a copy is made instead of modifying the original object.
+8236,"@@ -99,9 +99,9 @@ class BaseWebTest(object):
+     def get_app_settings(self, additional_settings=None):
+         settings = DEFAULT_SETTINGS.copy()
+
+-        settings['storage_backend'] = 'kinto.core.storage.redis'
+-        settings['cache_backend'] = 'kinto.core.cache.redis'
+-        settings['permission_backend'] = 'kinto.core.permission.redis'
++        settings['storage_backend'] = 'kinto_redis.storage'
++        settings['cache_backend'] = 'kinto_redis.cache'
++        settings['permission_backend'] = 'kinto_redis.permission'
+
+         settings['project_name'] = 'myapp'
+         settings['project_version'] = '0.0.1'",Does this mean that `kinto_redis` is required to run tests?
+8237,"@@ -475,7 +475,7 @@ function mergeBatchResults(batch, bulkResult, err, result) {
+   if (Array.isArray(result.writeErrors)) {
+     for (let i = 0; i < result.writeErrors.length; i++) {
+       const writeError = {
+-        index: batch.originalZeroIndex + result.writeErrors[i].index,
++        index: batch.originalIndexes[i],
+         code: result.writeErrors[i].code,
+         errmsg: result.writeErrors[i].errmsg,
+         op: batch.operations[result.writeErrors[i].index]",will this ensure the indexes for ordered writes as well?
+8238,"@@ -28,7 +28,11 @@ from nupic.support.lockattributes import LockAttributesMixin
+ import functools
+
+ basicTypes = ['Byte', 'Int16', 'UInt16', 'Int32', 'UInt32', 'Int64', 'UInt64',
+-              'Real32', 'Real64', 'Handle']
++              'Real32', 'Real64', 'Handle', 'Bool']
++
++arrayTypes = ['ByteArray', 'Int16Array', 'UInt16Array', 'Int32Array',
++              'UInt32Array', 'Int64Array', 'UInt64Array', 'Real32Array',
++              'Real64Array', 'BoolArray']
+
+ pyRegions = (
+     (""nupic.regions.AnomalyRegion"", ""AnomalyRegion""),",Put `BoolArray` first?
+8239,"@@ -0,0 +1,3 @@
++window.appMode = 'standalone';
++
++import('./site');",I believe this whole file can be deleted now.
+8240,"@@ -34,6 +34,17 @@ var (
+ 		Usage: ""Port for listening incoming api requests"",
+ 		Value: 4050,
+ 	}
++
++	promiseCurrencyFlag = cli.StringFlag{
++		Name:  ""promise.currency"",
++		Usage: ""Type of currency that will be used for issuing promises"",
++		Value: ""MYST"",
++	}
++	promiseAmountFlag = cli.IntFlag{
++		Name:  ""promise.amount"",
++		Usage: ""Amount of money that will be used for issuing a single promise"",
++		Value: 100,
++	}
+ )
+
+ // RegisterFlagsNode function register node flags to flag list","We should specify format for a user. I.e: Integer, 1000 == 1 MYST"
+8241,"@@ -132,6 +132,12 @@ func runControllers(ctx context.Context, config *Config) error {
+ 		}
+ 	}
+
++	for _, controller := range config.Controllers {
++		if err := controller(ctx, sc); err != nil {
++			return errors.Wrap(err, ""controller"")
++		}
++	}
++
+ 	if err := sc.Start(ctx); err != nil {
+ 		return err
+ 	}","Does the errors returned from these controllers indicate which controller threw the error? If not, there might be some value in making the ""CustomControllers"" type a `map[string]func(ctx context.Context, sc *server.Context) error` with the name of the controller as the key and include the key in this error string. This would apply for below as well."
+8242,"@@ -2204,8 +2204,13 @@ CheckedError Parser::DoParse(const char *source,
+       }
+       uoffset_t toff;
+       ECHECK(ParseTable(*root_struct_def_, nullptr, &toff));
+-      builder_.Finish(Offset<Table>(toff),
+-                file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      if (opts.prefix_size) {
++        builder_.FinishSizePrefixed(Offset<Table>(toff),
++                  file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      } else {
++        builder_.Finish(Offset<Table>(toff),
++                  file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      }
+     } else if (IsIdent(""enum"")) {
+       ECHECK(ParseEnum(false, nullptr));
+     } else if (IsIdent(""union"")) {",maybe at least pull the file identifier arg out of the if?
+8243,"@@ -1028,17 +1028,13 @@ class CommandDispatcher:
+             raise cmdexc.CommandError(""Can't move tab to position {}!"".format(
+                 new_idx + 1))
+
+-        tab = self._current_widget()
+         cur_idx = self._current_index()
+-        icon = self._tabbed_browser.tabIcon(cur_idx)
+-        label = self._tabbed_browser.page_title(cur_idx)
+         cmdutils.check_overflow(cur_idx, 'int')
+         cmdutils.check_overflow(new_idx, 'int')
+         self._tabbed_browser.setUpdatesEnabled(False)
+         try:
+             color = self._tabbed_browser.tab_indicator_color(cur_idx)
+-            self._tabbed_browser.removeTab(cur_idx)
+-            self._tabbed_browser.insertTab(new_idx, tab, icon, label)
++            self._tabbed_browser.tabBar().moveTab(cur_idx, new_idx)
+             self._set_current_index(new_idx)
+             self._tabbed_browser.set_tab_indicator_color(new_idx, color)
+         finally:","You can most likely remove that (and the try/finally) too, as we shouldn't have any flickering from removing/inserting tabs anymore now."
+8244,"@@ -19,12 +19,15 @@ const localHooks = {
+    *
+    * @param {String} key Hook name.
+    * @param {Function} callback Hook callback
++   * @return {Object}
+    */
+   addLocalHook(key, callback) {
+     if (!this._localHooks[key]) {
+       this._localHooks[key] = [];
+     }
+     this._localHooks[key].push(callback);
++
++    return this;
+   },
+
+   /**",Could you add `s` to `@return`?
+8245,"@@ -57,11 +57,10 @@ module Selenium
+               is_relative = Regexp.last_match(1).strip == '1'
+             when /^Path=(.+)$/
+               path = Regexp.last_match(1).strip
++              p = path_for(name, is_relative, path)
++              @profile_paths[name] = p if p
+             end
+           end
+-
+-          p = path_for(name, is_relative, path)
+-          @profile_paths[name] = p if p
+         end
+
+         def path_for(name, is_relative, path)",Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?
+8246,"@@ -290,9 +290,16 @@ func (at *addrTable) getAddrTable(key string) *serviceTable {
+ // filterResourceType implement filter. Proxy cares ""Service"" and ""ServiceList"" type
+ func filterResourceType(msg model.Message) []v1.Service {
+ 	svcs := make([]v1.Service, 0)
+-	content, ok := msg.Content.([]byte)
+-	if !ok {
+-		return svcs
++	var content []byte
++	var err error
++	switch msg.Content.(type) {
++	case []byte:
++		content = msg.GetContent().([]byte)
++	default:
++		content, err = json.Marshal(msg.GetContent())
++		if err != nil {
++			klog.Errorf(""marshal message to edgemesh failed, err: %v"", err)
++		}
+ 	}
+ 	switch getReourceType(msg.GetResource()) {
+ 	case constants.ResourceTypeService:",Will cause any bugs without this change? I've seen this code block(L293-302) many times... ;-)
+8247,"@@ -82,6 +82,11 @@ namespace NLog
+         /// </summary>
+         public LogFactory Factory { get; private set; }
+
++        /// <summary>
++        /// Properties added with <see cref=""WithProperty""/> or <see cref=""SetProperty""/>
++        /// </summary>
++        public IDictionary<string, object> Properties => _contextProperties ?? new Dictionary<string, object>();
++
+         /// <summary>
+         /// Gets a value indicating whether logging is enabled for the specified level.
+         /// </summary>",You are opening a door to race-condition-hell by returning an unprotected dictionary. I recommend that you return `IReadOnlyDictionary` that only works on the platforms where it is known.
+8248,"@@ -4367,7 +4367,7 @@ describe('Cursor', function() {
+     }
+   );
+
+-  it('should return a promise when no callback supplied to forEach method', function(done) {
++  it.skip('should return a promise when no callback supplied to forEach method', function(done) {
+     const configuration = this.configuration;
+     const client = configuration.newClient({ w: 1 }, { poolSize: 1, auto_reconnect: false });
+ ",also seems we should not skip this test
+8249,"@@ -31,14 +31,17 @@ import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+
+ class BaseFileScanTask implements FileScanTask {
+   private final DataFile file;
++  private final DeleteFile[] deletes;
+   private final String schemaString;
+   private final String specString;
+   private final ResidualEvaluator residuals;
+
+   private transient PartitionSpec spec = null;
+
+-  BaseFileScanTask(DataFile file, String schemaString, String specString, ResidualEvaluator residuals) {
++  BaseFileScanTask(DataFile file, DeleteFile[] deletes, String schemaString, String specString,
++                   ResidualEvaluator residuals) {
+     this.file = file;
++    this.deletes = deletes != null ? deletes : new DeleteFile[0];
+     this.schemaString = schemaString;
+     this.specString = specString;
+     this.residuals = residuals;","This is mostly for my understanding: is `DeleteFile[] deletes` a mandatory builder param now for file scan tasks? If not, from a v1 / v2 compatibility standpoint would it make sense to add an overloaded constructor?"
+8250,"@@ -123,6 +123,16 @@ public class ExecutionFlowDao {
+     }
+   }
+
++  public List<Pair<ExecutionReference, ExecutableFlow>> fetchAgedQueuedFlows(final Duration minAge)
++      throws ExecutorManagerException {
++    try {
++      return this.dbOperator.query(FetchAgedQueuedExecutableFlows.FETCH_FLOWS_QUEUED_FOR_LONG_TIME,
++          new FetchQueuedExecutableFlows(), System.currentTimeMillis() - minAge.toMillis());
++    } catch (final SQLException e) {
++      throw new ExecutorManagerException(""Error fetching active flows"", e);
++    }
++  }
++
+   /**
+    * fetch flow execution history with specified {@code projectId}, {@code flowId} and flow start
+    * time >= {@code startTime}","Can the error message reflect the purpose of the query more closely? Something like ""Error fetching executions queued for a long time"""
+8251,"@@ -60,7 +60,7 @@ func (c *CreateInstances) validate(w *Workflow) error {
+ 		}
+
+ 		// Startup script checking.
+-		if !sourceExists(ci.StartupScript) {
++		if ci.StartupScript != """" && !w.sourceExists(ci.StartupScript) {
+ 			return fmt.Errorf(""cannot create instance: file not found: %s"", ci.StartupScript)
+ 		}
+ ",Are you making it so startup script HAS to be in sources?
+8252,"@@ -128,7 +128,9 @@ void l2_weight_regularization::start_evaluation() {
+       if (vals.Participating()
+           && vals.GetLocalDevice() == El::Device::GPU
+           && vals.RedundantRank() == i % vals.RedundantSize()) {
+-        if (vals.LDim() == vals.LocalHeight()) {
++        if (vals.LocalWidth() < 1 || vals.LocalHeight() < 1) {
++        } else if (vals.LocalWidth() == 1
++                   || vals.LDim() == vals.LocalHeight()) {
+           cublas::dot(handle,
+                       vals.LocalHeight() * vals.LocalWidth(),
+                       vals.LockedBuffer(), 1,",Might be more clear to just have one if statement?
+8253,"@@ -87,7 +87,7 @@ class SparkReader:
+         try:
+             response_handler(response)
+         except Exception as e:
+-            current_app.logger.error('Error in the response handler: %s, data: %s %'
++            current_app.logger.error('Error in the response handler: %s, data: %s' %
+                                      (str(e), json.dumps(response, indent=4)), exc_info=True)
+             return
+ ","remember that logger methods will do string interpolation automatically anyway, so you should be able to do `logger.error('message %s', var, exc_info=True)`"
+8254,"@@ -350,6 +350,7 @@ private:
+   void render_sync_handler_failed_default_exception_branch(t_function *tfunc);
+   void render_sync_handler_send_exception_response(t_function *tfunc, const string &err_var);
+   void render_service_call_structs(t_service* tservice);
++  void render_args_struct(t_function* tfunc);
+   void render_result_value_struct(t_function* tfunc);
+
+   string handler_successful_return_struct(t_function* tfunc);",Perhaps rename to `render_service_args_struct`?
+8255,"@@ -11,8 +11,8 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/cborutil""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/chain""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/consensus""
++	crypto2 ""github.com/filecoin-project/go-filecoin/internal/pkg/crypto""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/repo""
+-	""github.com/filecoin-project/go-filecoin/internal/pkg/types""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/wallet""
+ )
+ ",clean the name
+8256,"@@ -70,6 +70,13 @@ func (a BrokerMetricAssertion) Assert(client *monitoring.MetricClient) error {
+ 		if err != nil {
+ 			return fmt.Errorf(""metric has invalid response code label: %v"", ts.GetMetric())
+ 		}
++
++		// Workarounds to reduce test flakiness caused by sender pod retry sending events (which will cause unexpected response code).
++		// We should remove it after https://github.com/google/knative-gcp/issues/1058 lands
++		if code == http.StatusForbidden || code == http.StatusServiceUnavailable || code == http.StatusInternalServerError {
++			continue
++		}
++
+ 		if code != http.StatusAccepted {
+ 			return fmt.Errorf(""metric has unexpected response code: %v"", ts.GetMetric())
+ 		}",I think we would expect StatusNotFound instead of StatusForbidden?
+8257,"@@ -241,9 +241,11 @@ static int rexec_output (flux_subprocess_t *p,
+                          bool eof)
+ {
+     json_t *io = NULL;
++    char rankstr[64];
+     int rv = -1;
+
+-    if (!(io = ioencode (stream, s->rank, data, len, eof))) {
++    snprintf (rankstr, sizeof (rankstr), ""%d"", s->rank);
++    if (!(io = ioencode (stream, rankstr, data, len, eof))) {
+         flux_log_error (s->h, ""%s: ioencode"", __FUNCTION__);
+         goto error;
+     }","Since this is a recurring theme, would it make sense to have an ioencode interface for it like `ioencode_rank()` that takes an integer rank like before?"
+8258,"@@ -192,8 +192,10 @@ func contains(capabilities []string, capability string) bool {
+ // object
+ func (agent *ecsAgent) initializeResourceFields() {
+ 	agent.resourceFields = &taskresource.ResourceFields{
+-		Control: cgroup.New(),
+-		IOUtil:  ioutilwrapper.NewIOUtil(),
++		Control:      cgroup.New(),
++		IOUtil:       ioutilwrapper.NewIOUtil(),
++		Ctx:          agent.ctx,
++		DockerClient: agent.dockerClient,
+ 	}
+ }
+ ",Is it a concern that we initialize these fields irrespective of whether resources like cgroup/volumes are enabled or not?
+8259,"@@ -109,10 +109,13 @@ func NewDispatcher(cfg Config) Dispatcher {
+
+ // convertOutbounds applys outbound middleware and creates validator outbounds
+ func convertOutbounds(outbounds Outbounds, middleware OutboundMiddleware) Outbounds {
+-	//TODO(apb): ensure we're not given the same underlying outbound for each RPC type
+ 	convertedOutbounds := make(Outbounds, len(outbounds))
+
+ 	for service, outs := range outbounds {
++		if outs.Unary == nil && outs.Oneway == nil {
++			panic(fmt.Sprintf(""no outbound set for service %q in dispatcher"", service))
++		}
++
+ 		var (
+ 			unaryOutbound  transport.UnaryOutbound
+ 			onewayOutbound transport.OnewayOutbound",Wouldn't this be the first panic in yarpc? What do we do for transport validation? Return errors?
+8260,"@@ -26,6 +26,7 @@ import (
+ type processor interface {
+ 	process(ctx context.Context) error
+ 	traceLogs() []string
++	cancel(reason string)
+ }
+
+ // processorProvider allows the processor to be determined after the pd has been inflated.",have you envisioned other cancellation reasons?
+8261,"@@ -395,8 +395,10 @@ final class SonataMediaExtension extends Extension implements PrependExtensionIn
+     /**
+      * Checks if the classification of media is enabled.
+      *
+-     * @param array<string, class-string> $bundles
+-     * @param array<string, mixed>        $config
++     * @param array<string, string> $bundles
++     * @param array<string, mixed>  $config
++     *
++     * @phpstan-param array<string, class-string> $bundles
+      */
+     private function isClassificationEnabled(array $bundles, array $config): bool
+     {","For the record, class-string is now suported by PHPStorm. Don't know if it's worth moving it to `@phpstan-param` then."
+8262,"@@ -2085,7 +2085,10 @@ class CommandDispatcher:
+                 raise cmdexc.CommandError(str(e))
+
+         widget = self._current_widget()
+-        widget.run_js_async(js_code, callback=jseval_cb, world=world)
++        try:
++            widget.run_js_async(js_code, callback=jseval_cb, world=world)
++        except OverflowError:
++            raise cmdexc.CommandError(""World Id not in valid range"")
+
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+     def fake_key(self, keystring, global_=False):","This prevents negative IDs, but it doesn't check for too large IDs. You should probably just do the same check you do for `QWebengineScript` here as well."
+8263,"@@ -18,6 +18,7 @@ const (
+ 	// Command specific flags.
+ 	dockerFileFlag        = ""dockerfile""
+ 	imageTagFlag          = ""tag""
++	awsTagsFlag           = ""tags""
+ 	stackOutputDirFlag    = ""output-dir""
+ 	limitFlag             = ""limit""
+ 	followFlag            = ""follow""",This might be very confusing. Maybe `resource-tags`? I
+8264,"@@ -283,6 +283,7 @@ class DeformConvPack(DeformConv):
+             kernel_size=self.kernel_size,
+             stride=_pair(self.stride),
+             padding=_pair(self.padding),
++            dilation=self.dilation,
+             bias=True)
+         self.init_offset()
+ ",We may use `_pair` to wrap `dilation`.
+8265,"@@ -286,15 +286,9 @@ func createLibcontainerConfig(cgroupName string, spec *specs.LinuxSpec) (*config
+ 		return nil, err
+ 	}
+ 	config.Cgroups = c
+-	if config.Readonlyfs {
+-		setReadonly(config)
+-		config.MaskPaths = []string{
+-			""/proc/kcore"",
+-		}
+-		config.ReadonlyPaths = []string{
+-			""/proc/sys"", ""/proc/sysrq-trigger"", ""/proc/irq"", ""/proc/bus"",
+-		}
+-	}
++	// set extra path masking for libcontainer for the various unsafe places in proc
++	config.MaskPaths = maskedPaths
++	config.ReadonlyPaths = readonlyPaths
+ 	seccomp, err := setupSeccomp(&spec.Linux.Seccomp)
+ 	if err != nil {
+ 		return nil, err",what's with `setReadonly`? Why we deleted it totally?
+8266,"@@ -121,12 +121,7 @@ CXXToken * cxxTagSetTypeField(
+ {
+ 	CXX_DEBUG_ASSERT(tag && pTypeStart && pTypeEnd,""Non null parameters are expected"");
+
+-	const char * szTypeRef0;
+-
+-	// ""typename"" is debatable since it's not really
+-	// allowed by C++ for unqualified types. However I haven't been able
+-	// to come up with something better... so ""typename"" it is for now.
+-	static const char * szTypename = ""typename"";
++	const char * szTypeRef0 = NULL;
+
+ 	if(pTypeStart != pTypeEnd)
+ 	{","Currently I think this is not acceptable. I think the value should be chosen by the author of the parser. (Personally ""type"" is better than ""typename"".)"
+8267,"@@ -13,6 +13,7 @@
+
+ package machine
+
++// should not need to import the ec2 sdk here
+ import (
+ 	""fmt""
+ ",Is this excessive?
+8268,"@@ -251,7 +251,7 @@ main(int argc, char *argv[])
+        * sysroot, we still need a writable /etc.  And to avoid race conditions
+        * we ensure it's writable in the initramfs, before we switchroot at all.
+        */
+-      if (mount (""/etc"", ""/etc"", NULL, MS_BIND, NULL) < 0)
++      if (mount (""etc"", ""etc"", NULL, MS_BIND, NULL) < 0)
+         err (EXIT_FAILURE, ""failed to make /etc a bind mount"");
+       /* Pass on the fact that we discovered a readonly sysroot to ostree-remount.service */
+       int fd = open (_OSTREE_SYSROOT_READONLY_STAMP, O_WRONLY | O_CREAT | O_CLOEXEC, 0644);","Ohhhh I see, this change was previously having *no effect* - I had thought you meant we were doing something like bind mounting the initramfs' `/etc` as the real `/etc` but we'd clearly notice if that happened, we'd be missing all sorts of config files etc."
+8269,"@@ -133,6 +133,15 @@ abstract class SnapshotProducer<ThisT> implements SnapshotUpdate<ThisT> {
+    */
+   protected abstract String operation();
+
++  /**
++   * A Long that write sequenceNumber in manifest-list file.
++   *
++   * @return a string operation
++   */
++  protected Long sequenceNumber() {
++    return null;
++  }
++
+   /**
+    * Validate the current metadata.
+    * <p>","I think this needs a more specific name, like `sequenceNumberOverride`"
+8270,"@@ -39,7 +39,8 @@ module Blacklight
+     when /::/
+       connection_config[:adapter].constantize
+     else
+-      Blacklight.const_get(""#{connection_config[:adapter]}/Repository"".classify)
++      raise ""The value for :adapter was not found in the blacklight.yml config"" unless connection_config.key? :adapter
++      Blacklight.const_get(""#{connection_config.fetch(:adapter)}/Repository"".classify)
+     end
+   end
+ ",Ought we just raise an exception if the adapter isn't defined?
+8271,"@@ -5,7 +5,6 @@ var stsLegacyGlobalRegions = map[string]struct{}{
+ 	""ap-south-1"":     {},
+ 	""ap-southeast-1"": {},
+ 	""ap-southeast-2"": {},
+-	""aws-global"":     {},
+ 	""ca-central-1"":   {},
+ 	""eu-central-1"":   {},
+ 	""eu-north-1"":     {},","Should this have been removed? We still set the region to ""aws-global"" in v3model.go#L115"
+8272,"@@ -335,14 +335,15 @@ def setup_logging(config):
+                 errno=errors.ERRORS.INVALID_PARAMETERS,
+                 message='Invalid URL path.')
+
++        qs = dict(errors.request_GET(request))
+         request.log_context(agent=request.headers.get('User-Agent'),
+                             path=request_path,
+                             method=request.method,
+-                            querystring=dict(errors.request_GET(request)),
++                            querystring=(qs if len(qs) else None),
+                             lang=request.headers.get('Accept-Language'),
+                             uid=None,
+                             authn_type=None,
+-                            errno=None)
++                            errno=0)
+
+     config.add_subscriber(on_new_request, NewRequest)
+ ","You could shorten this to `qs or None`. But why not just build a dict of parameters we want to include and only add `querystring` if there's something here, similar to the way you do in the error view?"
+8273,"@@ -31,15 +31,9 @@ func (c *client) acquireTopologyCacheLock(ctx context.Context) {
+ 	}
+ 	defer conn.Close()
+
+-	go func() {
+-		<-ctx.Done()
+-		ticker.Stop()
+-		c.unlockAdvisoryLock(context.Background(), conn, advisoryLockId)
+-	}()
+-
+ 	// Infinitely try to acquire the advisory lock
+ 	// Once the lock is acquired we start caching, this is a blocking operation
+-	for ; true; <-ticker.C {
++	for {
+ 		c.log.Info(""trying to acquire advisory lock"")
+
+ 		// TODO: We could in the future spread the load of the topology caching","sorry if I'm missing it somewhere else in the code, but do you need to create a `ticker := time.NewTicker`?"
+8274,"@@ -44,7 +44,11 @@ import (
+ func TestNew(t *testing.T) {
+ 	ctx, _ := SetupFakeContext(t)
+
+-	c := NewController(ctx, configmap.NewStaticWatcher(
++	dataresidencySs := &dataresidency.StoreSingleton{}
++
++	ctor := NewConstructor(dataresidencySs)
++
++	c := ctor(ctx, configmap.NewStaticWatcher(
+ 		&corev1.ConfigMap{
+ 			ObjectMeta: metav1.ObjectMeta{
+ 				Name:      logging.ConfigMapName(),","Inline this, as we don't use it again."
+8275,"@@ -39,7 +39,9 @@ exclude = [""ForwardFFTImageFilter"",
+            ""templated_class"",
+            ""HalfHermitianToRealInverseFFTImageFilter"",
+            ""RealToHalfHermitianForwardFFTImageFilter"",
+-           ""CustomColormapFunction""]
++           ""CustomColormapFunction"",
++           ""ScanlineFilterCommon""  # Segfault
++           ]
+
+ wrongName = 0
+ totalName = 0",I think the instantiation of the new objects i.New() and T.New() need to be done in a function to have local variable and reduce the amount of memory used.
+8276,"@@ -40,6 +40,8 @@ namespace pwiz.Skyline.Model.Hibernate
+         public const string Mz = ""0.####"";
+         public const string SamplingTime = ""0.00"";
+         public const string OneOverK0 = ""0.####"";
++
++        public const string IonMobility = ""0.#####"";
+         // ReSharper restore LocalizableElement
+     }
+ }",This is probably more digits than needed - perhaps rename OneOverK0 to IonMobility instead
+8277,"@@ -25,5 +25,8 @@ public enum ApiMethodType {
+   CallableMethod,
+   // PHP
+   OptionalArrayMethod,
+-  PagedOptionalArrayMethod
++  PagedOptionalArrayMethod,
++  // C#
++  FlattenedMethodAsyncCallSettings,
++  FlattenedMethodAsyncCancellationToken,
+ }","End with 'Method', so: - FlattenedAsyncCallSettingsMethod - FlattenedAsyncCancellationTokenMethod"
+8278,"@@ -22,6 +22,7 @@ import (
+
+ 	cloudkms ""cloud.google.com/go/kms/apiv1""
+ 	""gocloud.dev/gcp""
++	""gocloud.dev/internal/secrets""
+ 	""google.golang.org/api/option""
+ 	kmspb ""google.golang.org/genproto/googleapis/cloud/kms/v1""
+ )",`localsecrets` should be updated in the same way.
+8279,"@@ -94,13 +94,18 @@ const ConsensusV17 = ConsensusVersion(
+ 	""https://github.com/algorandfoundation/specs/tree/5615adc36bad610c7f165fa2967f4ecfa75125f0"",
+ )
+
++// ConsensusV18 adds the ability to issue a transaction that marks an account non-participating
++const ConsensusV18 = ConsensusVersion(
++	""---->!!!TODO!!!<----"",
++)
++
+ // !!! ********************* !!!
+ // !!! *** Please update ConsensusCurrentVersion when adding new protocol versions *** !!!
+ // !!! ********************* !!!
+
+ // ConsensusCurrentVersion is the latest version and should be used
+ // when a specific version is not provided.
+-const ConsensusCurrentVersion = ConsensusV17
++const ConsensusCurrentVersion = ConsensusV18
+
+ // ConsensusTest0 is a version of ConsensusV0 used for testing
+ // (it has different approved upgrade paths).",We'll want to PR a spec change into github.com/algorandfoundation/specs. (Side note: It might or might not make sense to combine this protocol upgrade with Tsachi's protocol upgrade for fixing the reward rate calculation.)
+8280,"@@ -30,7 +30,7 @@ func (w *DefaultWorker) Generate(
+ 	nullBlockCount abi.ChainEpoch,
+ 	posts []block.PoStProof,
+ 	drandEntries []*drand.Entry,
+-) Output {
++) (*block.Block, []*types.SignedMessage, []*types.SignedMessage, error) {
+
+ 	generateTimer := time.Now()
+ 	defer func() {","Use `FullBlock`, it comes from the same package."
+8281,"@@ -1,9 +1,13 @@
++import abc
+ import json
+ import logging
+ import time
+ from concurrent.futures import ThreadPoolExecutor
++from typing import Collection, Dict, Optional
+
+ import requests
++from flask import Request
++from readerwriterlock import rwlock
+
+ from localstack import config
+ from localstack.utils.bootstrap import canonicalize_api_names","do we plan to use anything else than flask for making HTTP requests inside localstack? if so, it maybe makes sense not to strongly couple to flask for now, and just leave the type of the `request` function parameters open for now."
+8282,"@@ -143,9 +143,17 @@ func (verifyContentLanguage) ErrorCheck(b *blob.Bucket, err error) error {
+ }
+
+ func (verifyContentLanguage) BeforeWrite(as func(interface{}) bool) error {
++	var objp **storage.ObjectHandle
++	if !as(&objp) {
++		return errors.New(""Writer.As failed to get ObjectHandle"")
++	}
++	// Replace the ObjectHandle with a new one that adds Conditions
++	// (this condition will always be true).
++	*objp = (*objp).If(storage.Conditions{DoesNotExist: true})
++
+ 	var sw *storage.Writer
+ 	if !as(&sw) {
+-		return errors.New(""Writer.As failed"")
++		return errors.New(""Writer.As failed to get Writer"")
+ 	}
+ 	sw.ContentLanguage = language
+ 	return nil","I think we should make this a separate test case: it seems like making the precondition fail is the test case that would ensure that this escape hatch worked. Otherwise, if it's always true, then it would be the same as if the escape hatch didn't modify the outgoing request."
+8283,"@@ -62,6 +62,13 @@ func (s *Server) Start(ctx context.Context) error {
+ 		return errors.Wrap(err, ""error when subscribe to block"")
+ 	}
+
++	// sync genesis block
++	genesisBlk, err := s.bc.GetBlockByHeight(0)
++	if err != nil {
++		return errors.Wrap(err, ""error when get genesis block"")
++	}
++	s.idx.BuildIndex(genesisBlk)
++
+ 	go func() {
+ 		for {
+ 			select {",Error return value of `s.idx.BuildIndex` is not checked
+8284,"@@ -36,6 +36,8 @@ def gen_classes():
+             pass
+         elif member is configtypes.MappingType:
+             pass
++        elif member in [configtypes.List, configtypes.LengthList]:
++            pass
+         elif member is configtypes.FormatString:
+             yield functools.partial(member, fields=['a', 'b'])
+         elif issubclass(member, configtypes.BaseType):",What's the reason for excluding those from the fuzzing here? You probably could just add some inner type via `functools.partial` like below with `FormatString`.
+8285,"@@ -3,6 +3,6 @@ require 'spec_helper'
+ describe Api::V1::UsersController, '#show' do
+   it 'returns a 401 when users are not authenticated' do
+     get :show
+-    response.code.should eq '401'
++    expect(response.code).to eq '401'
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+8286,"@@ -14,7 +14,7 @@ import (
+ )
+
+ func killContainer(container libcontainer.Container) error {
+-	container.Signal(syscall.SIGKILL, false)
++	_ = container.Signal(syscall.SIGKILL, false)
+ 	for i := 0; i < 100; i++ {
+ 		time.Sleep(100 * time.Millisecond)
+ 		if err := container.Signal(syscall.Signal(0), false); err != nil {",Its this golint or govet stuff?
+8287,"@@ -232,10 +232,9 @@ insert(hash_table_t table, app_pc addr, cbr_state_t state)
+ static void
+ at_taken(app_pc src, app_pc targ)
+ {
+-    dr_mcontext_t mcontext = {
+-        sizeof(mcontext),
+-        DR_MC_ALL,
+-    };
++    dr_mcontext_t mcontext;
++    mcontext.size = sizeof(mcontext);
++    mcontext.flags = DR_MC_ALL;
+     void *drcontext = dr_get_current_drcontext();
+
+     /*","These are good cleanups: I didn't realize there were so many like this in the samples and tests. But given that there are quite of few of these mcontext changes I would separate these into their own PR (no need for an issue: iX branch) since they are logically distinct. Cleaner history, simpler revert paths, etc."
+8288,"@@ -0,0 +1,18 @@
++// Copyright (c) Six Labors.
++// Licensed under the Apache License, Version 2.0.
++
++using BenchmarkDotNet.Attributes;
++
++using SixLabors.ImageSharp.PixelFormats;
++
++namespace SixLabors.ImageSharp.Benchmarks
++{
++    public class ColorEquality
++    {
++        [Benchmark(Description = ""ImageSharp Color Equals"")]
++        public bool ColorEqual()
++        {
++            return new Rgba32(128, 128, 128, 128).Equals(new Rgba32(128, 128, 128, 128));
++        }
++    }
++}","  This is just a random struct equality, no value here."
+8289,"@@ -180,6 +180,7 @@ type Config struct {
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail""`
+
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
++	NatPortRange       numorstring.Port   `config:""portrange;;local""`
+
+ 	UsageReportingEnabled          bool          `config:""bool;true""`
+ 	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`",Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only
+8290,"@@ -8,8 +8,12 @@ except ImportError:
+ import numpy as np
+ import param
+
+-from ..dimension import redim
+-from ..util import unique_iterator
++from ..dimension import redim, Dimension, process_dimensions
++from ..element import Element
++from ..ndmapping import OrderedDict
++from ..spaces import HoloMap, DynamicMap
++from ..util import (basestring, dimension_range as d_range, get_param_values,
++                    isfinite, process_ellipses, unique_iterator, wrap_tuple)
+ from .interface import Interface, iloc, ndloc
+ from .array import ArrayInterface
+ from .dictionary import DictInterface","I had some weird issues when importing ``from .. import util`` getting the wrong utilities, hence I did this."
+8291,"@@ -1,8 +1,8 @@
+-#NVDAObjects/WinConsole.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
+-#Copyright (C) 2007-2019 NV Access Limited, Bill Dengler
++# NVDAObjects/WinConsole.py
++# A part of NonVisual Desktop Access (NVDA)
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
++# Copyright (C) 2007-2020 NV Access Limited, Bill Dengler
+
+ import winConsoleHandler
+ from . import Window",Please remove this line.
+8292,"@@ -324,7 +324,8 @@ module Beaker
+           # exit codes at the host level and then raising...
+           # is it necessary to break execution??
+           if options[:accept_all_exit_codes] && options[:acceptable_exit_codes]
+-            @logger.warn "":accept_all_exit_codes & :acceptable_exit_codes set. :accept_all_exit_codes overrides, but they shouldn't both be set at once""
++            @logger.warn "":accept_all_exit_codes & :acceptable_exit_codes set. :acceptable_exit_codes overrides, but they shouldn't both be set at once""
++            options[:accept_all_exit_codes] = false
+           end
+           if !options[:accept_all_exit_codes] && !result.exit_code_in?(Array(options[:acceptable_exit_codes] || [0, nil]))
+             raise CommandFailure, ""Host '#{self}' exited with #{result.exit_code} running:\n #{cmdline}\nLast #{@options[:trace_limit]} lines of output were:\n#{result.formatted_output(@options[:trace_limit])}""",should this state that we're falling back to `:acceptable_exit_codes`?
+8293,"@@ -87,6 +87,16 @@ def df_type_check(_, value):
+         success=True,
+         metadata_entries=[
+             EventMetadataEntry.text(str(len(value)), 'row_count', 'Number of rows in DataFrame'),
++            EventMetadataEntry.text(str(value.shape), ""shape"", ""The shape of the DataFrame.""),
++            EventMetadataEntry.md(
++                value.dtypes.to_markdown(), ""dtypes"", ""The dtypes within the DataFrame.""
++            ),
++            EventMetadataEntry.md(
++                dataframe.head().to_markdown(), ""head"", ""A preview of the first 5 rows.""
++            ),
++            EventMetadataEntry.md(
++                dataframe.tail().to_markdown(), ""tail"", ""A preview of the last 5 rows.""
++            ),
+             # string cast columns since they may be things like datetime
+             EventMetadataEntry.json({'columns': list(map(str, value.columns))}, 'metadata'),
+         ],",I don't think this works. The dataframe object is encapsulated in the value parameter. This might be the root of the failing checks.
+8294,"@@ -163,7 +163,7 @@ class TopologyDescription {
+     }
+
+     if (topologyType === TopologyType.Unknown) {
+-      if (serverType === ServerType.Standalone) {
++      if (serverType === ServerType.Standalone && this.servers.size !== 1) {
+         serverDescriptions.delete(address);
+       } else {
+         topologyType = topologyTypeForServerType(serverType);",Why was it necessary to add this check against `this.servers.size`?
+8295,"@@ -61,6 +61,11 @@ std::string getWrongOptionHelp(const engine::api::TableParameters &parameters)
+         help = ""fallback_speed must be > 0"";
+     }
+
++    if (parameters.scale_factor < 0)
++    {
++        help = ""scale_factor must be > 0"";
++    }
++
+     return help;
+ }
+ } // anon. ns",This tests for < 0 but the error message says it must be > 0. The `if` should probably be `<=` to match the message.
+8296,"@@ -25,12 +25,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         {
+             var request = (WebRequest)webRequest;
+
+-            if (!IsTracingEnabled(request))
++            if (!(request is HttpWebRequest) || !IsTracingEnabled(request))
+             {
+                 return request.GetResponse();
+             }
+
+-            string httpMethod = request.Method.ToUpperInvariant();
++            string httpMethod = request.Method?.ToUpperInvariant() ?? ""UNKNOWN"";
+             string integrationName = typeof(WebRequestIntegration).Name.TrimEnd(""Integration"", StringComparison.OrdinalIgnoreCase);
+
+             using (var scope = ScopeFactory.CreateOutboundHttpScope(Tracer.Instance, httpMethod, request.RequestUri, integrationName))","Short circuits when it's something like a WebPackRequest, which we should instrument and test specifically."
+8297,"@@ -23,7 +23,7 @@ var (
+
+ func init() {
+ 	flag.BoolVar(&fProd, ""prod"", false, ""disable development mode"")
+-	flag.BoolVar(&fDiskCertCache, ""use-disk-cert-cache-dev"", false, ""cache cert on disk"")
++	flag.BoolVar(&fDiskCertCache, ""use-disk-cert-cache"", false, ""cache cert on disk"")
+ }
+
+ func main() {",Should this be true now by default?
+8298,"@@ -131,6 +131,7 @@ public class AzkabanExecutorServer {
+     root.addServlet(new ServletHolder(new ExecutorServlet()), ""/executor"");
+     root.addServlet(new ServletHolder(new JMXHttpServlet()), ""/jmx"");
+     root.addServlet(new ServletHolder(new StatsServlet()), ""/stats"");
++    root.addServlet(new ServletHolder(new StatisticsServlet()), ""/stastics"");
+
+     root.setAttribute(ServerConstants.AZKABAN_SERVLET_CONTEXT_KEY, this);
+ ",/DispatcherStatistics ? /statistics is a bit confusing with /stats
+8299,"@@ -605,6 +605,9 @@ def get_lambda_log_events(
+             or ""START"" in raw_message
+             or ""END"" in raw_message
+             or ""REPORT"" in raw_message
++            # necessary until tail is updated in docker images. See this PR:
++            # http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.24-111-g1118f32
++            or ""tail: unrecognized file system type 0x794c7630"" in raw_message
+             or regex_filter
+             and not re.search(regex_filter, raw_message)
+         ):","nit: Wondering if we should simply filter on `""tail: unrecognized file system type""`, or is the type identifier `0x794c7630` always the same?"
+8300,"@@ -4,12 +4,13 @@ import (
+ 	""encoding/json""
+ 	""fmt""
+
++	""github.com/google/uuid""
+ 	installertypes ""github.com/openshift/installer/pkg/types""
+
+ 	hivev1 ""github.com/openshift/hive/pkg/apis/hive/v1""
+ )
+
+-const fakeMetadataFormatStr = `{""aws"":{""identifier"":[{""kubernetes.io/cluster/fake-infraid"":""owned""},{""openshiftClusterID"":""fake-cluster-id""}],""region"":""us-east-1""},""clusterID"":""fake-cluster-id"",""clusterName"":""%s"",""infraID"":""fake-infra-id""}`
++const fakeMetadataFormatStr = `{""aws"":{""identifier"":[{""kubernetes.io/cluster/fake-infraid"":""owned""},{""openshiftClusterID"":""%s""}],""region"":""us-east-1""},""clusterID"":""%s"",""clusterName"":""%s"",""infraID"":""fake-infra-id""}`
+
+ func fakeLoadAdminPassword(m *InstallManager) (string, error) {
+ 	m.log.Warn(""loading fake admin password"")","I think the goal of using `fake-cluster-id` was to make it sure clear that this is a fake cluster, replacing this with UUID only now makes these clusters look very similar to real ones which can cause problems.. any reason why we didn't go for the original recommendation from slack thread of `fake-cluster-UUID` @twiest"
+8301,"@@ -1719,3 +1719,19 @@ def get_node_first_ancestor_of_type(
+         if isinstance(ancestor, ancestor_type):
+             return ancestor
+     return None
++
++
++def get_node_first_ancestor_of_type_and_its_child(
++    node: nodes.NodeNG, ancestor_type: Union[Type[T_Node], Tuple[Type[T_Node]]]
++) -> Tuple[Optional[T_Node], Optional[T_Node]]:
++    """"""Modified version of get_node_first_ancestor_of_type to also return the
++    descendant visited directly before reaching the sought ancestor. Useful
++    for extracting whether a statement is guarded by a try, except, or finally
++    when searching for a TryFinally ancestor.
++    """"""
++    last_ancestor = node
++    for ancestor in node.node_ancestors():
++        if isinstance(ancestor, ancestor_type):
++            return (ancestor, last_ancestor)
++        last_ancestor = ancestor
++    return None, None","I need to spruce up my `mypy` knowledge but I think this is incorrect. Using `T_Node` twice makes it so that both should be the same type. I think this would be better: `Tuple[Optional[T_Node], Optional[nodes.NodeNG ]]`. It might even better to do: `Union[Tuple[None, None]. Tuple[T_Node, nodes.NodeNG ]]` as that shows that `None` should always pair with `None`"
+8302,"@@ -438,10 +438,13 @@ func runTest(t *testing.T, test testT) {
+ 	}
+
+ 	controller := certificaterequests.New(apiutil.IssuerCA, ca)
+-	controller.Register(test.builder.Context)
++	_, _, err := controller.Register(test.builder.Context)
++	if err != nil {
++		t.Errorf(""controller.Register failed (%s)"", err.Error())
++	}
+ 	test.builder.Start()
+
+-	err := controller.Sync(context.Background(), test.certificateRequest)
++	err = controller.Sync(context.Background(), test.certificateRequest)
+ 	if err != nil && !test.expectedErr {
+ 		t.Errorf(""expected to not get an error, but got: %v"", err)
+ 	}",Nit: below on line 449 we use `%v` to print an error - perhaps would be nice to do it in the same way in both places (but probably not that important). Similar in other places in this PR.
+8303,"@@ -169,6 +169,8 @@ class Flow(stateobject.StateObject):
+             self.reply.take()
+         self.reply.kill(force=True)
+         self.reply.commit()
++        self.live = False
++        master.addons(""kill"", self)
+
+     def intercept(self, master):
+         """"""","I'm not against adding a kill event, but we need to do it properly, please. That means listing it in events.py, adding docs for it, and so forth."
+8304,"@@ -2083,9 +2083,15 @@ class CppGenerator : public BaseGenerator {
+         if (!field.deprecated) {
+           code_.SetValue(""FIELD_NAME"", Name(field));
+           if (field.value.type.base_type == BASE_TYPE_STRING) {
+-            code_ +=
+-                ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
+-                ""_fbb.CreateString({{FIELD_NAME}}) : 0;"";
++            if (!field.native_shared) {
++              code_ +=
++                  ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
++                  ""_fbb.CreateString({{FIELD_NAME}}) : 0;"";
++            } else {
++              code_ +=
++                  ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
++                  ""_fbb.CreateSharedString({{FIELD_NAME}}) : 0;"";
++            }
+           } else if (field.value.type.base_type == BASE_TYPE_VECTOR) {
+             code_ += ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? \\"";
+             const auto vtype = field.value.type.VectorType();",this line can be lifted outside of the if-then? In fact only CreateString / CreateSharedString needs to be inside of it.
+8305,"@@ -386,8 +386,8 @@ public class EpisodesApplyActionFragment extends Fragment implements Toolbar.OnM
+             mListView.setItemChecked(i, checked);
+         }
+         refreshToolbarState();
+-        toolbar.setTitle(getResources().getQuantityString(R.plurals.num_selected_label,
+-                checkedIds.size(), checkedIds.size()));
++//        toolbar.setTitle(getResources().getQuantityString(R.plurals.num_selected_label,
++//                checkedIds.size(), checkedIds.size()));
+     }
+
+     private void queueChecked() {",I think the `EpisodesApplyActionFragment` is unused now. So please delete it :)
+8306,"@@ -863,7 +863,7 @@ module Bolt
+       end
+       define('--log-level LEVEL',
+              ""Set the log level for the console. Available options are"",
+-             ""debug, info, notice, warn, error, fatal, any."") do |level|
++             ""trace, debug, info, warn, error, fatal, any."") do |level|
+         @options[:log] = { 'console' => { 'level' => level } }
+       end
+       define('--plugin PLUGIN', 'Select the plugin to use') do |plug|","It seems like we should leave `notice` here since it can be configured in Bolt config files, and that's what sets the console config for messages from Puppet. For example, this will break plans that call `notice()` in their apply blocks."
+8307,"@@ -31,6 +31,7 @@ public enum CommonMetrics {
+
+   private Meter dbConnectionMeter;
+   private Meter flowFailMeter;
++  private Meter OOMwaitingJobMeter;
+   private AtomicLong dbConnectionTime = new AtomicLong(0L);
+
+   private MetricRegistry registry;",This metrics is only exposed in executors. Should it be defined in azkaban.execapp.ExecMetrics instead?
+8308,"@@ -64,3 +64,14 @@ export function getEffectiveMaxDate ({ maxDate, includeDates }) {
+     return maxDate
+   }
+ }
++
++export function parseDate (value, { dateFormat, locale }) {
++  const m = moment(value, dateFormat, locale || moment.locale(), true)
++  return m.isValid() ? m : null
++}
++
++export function safeDateFormat (date, { dateFormat, locale }) {
++  return date && date.clone()
++    .locale(locale || moment.locale())
++    .format(Array.isArray(dateFormat) ? dateFormat[0] : dateFormat) || ''
++}","I originally factored out these functions from date_input. Currently, they are only used in datepicker, but they seemed more general purpose. If you decide we should keep the current date_input API (in case anyone is using it directly), then I think it makes sense to factor these out in order to be able to maintain consistency, but otherwise they could be inlined into datepicker.jsx if you prefer."
+8309,"@@ -204,9 +204,10 @@ func (r *mutableStateTaskGeneratorImpl) generateDelayedWorkflowTasks(
+ 	switch startAttr.GetInitiator() {
+ 	case enumspb.CONTINUE_AS_NEW_INITIATOR_RETRY:
+ 		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_RETRY
+-	case enumspb.CONTINUE_AS_NEW_INITIATOR_CRON_SCHEDULE,
+-		enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW:
++	case enumspb.CONTINUE_AS_NEW_INITIATOR_CRON_SCHEDULE, enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW:
+ 		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_CRON
++	case enumspb.CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED:
++		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_UNSPECIFIED
+ 	default:
+ 		return serviceerror.NewInternal(fmt.Sprintf(""unknown initiator: %v"", startAttr.GetInitiator()))
+ 	}",I think this should never happen and should return an error also. Having `WorkflowBackoffTimerTask` with `UNSPECIFIED` type looks weird.
+8310,"@@ -9,7 +9,7 @@ import 'webcomponents';
+     function onKeyDown(e) {
+         // Don't submit form on enter
+         // Real (non-emulator) Tizen does nothing on Space
+-        if (e.keyCode === 13 || e.keyCode === 32) {
++        if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) {
+             e.preventDefault();
+
+             if (!this.checked) {",Add `browser` import
+8311,"@@ -0,0 +1,18 @@
++// Copyright 2018 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++package config
++
++import (
++	""crypto/sha256""
++	""encoding/hex""
++)
++
++// GenerateSHA256PasswordHash generates a sha256 hashed password hash from
++// plaintextPassword in the form of ""sha256:<hash>"". This is what should go
++// into the config file.
++func GenerateSHA256PasswordHash(plaintextPassword string) string {
++	hash := sha256.Sum256([]byte(plaintextPassword))
++	return ""sha256:"" + hex.EncodeToString(hash[:])
++}","Would it be good practice to add a nonce in here (that's also stored in the config), so it's harder to tell when passwords are being reused?"
+8312,"@@ -40,4 +40,8 @@ public interface TelemetryRestService {
+   @Produces(MediaType.APPLICATION_JSON)
+   TelemetryConfigurationDto getTelemetryConfiguration();
+
++  @GET
++  @Path(""/data"")
++  @Produces(MediaType.APPLICATION_JSON)
++  Object getTelemetryData();
+ }","For consistency, the return type could be `TelemetryDataDto` here. This would be more consistent with the other REST API interfaces. From a functional perspective, the current code is perfectly fine though."
+8313,"@@ -133,7 +133,7 @@ PySGDSolver::PySGDSolver(const string& param_file) {
+   // as in PyNet, (as a convenience, not a guarantee), create a Python
+   // exception if param_file can't be opened
+   CheckFile(param_file);
+-  solver_.reset(new SGDSolver<float>(param_file));
++  solver_ = boost::make_shared<SolvingDriver<float> >(param_file);
+   // we need to explicitly store the net wrapper, rather than constructing
+   // it on the fly, so that it can hold references to Python objects
+   net_.reset(new PyNet(solver_->net()));",I've never seen this `boost::make_shared`...why use it instead of `reset`?
+8314,"@@ -273,6 +273,11 @@ public abstract class AbstractExecutorManagerAdapter extends EventHandler implem
+     }
+   }
+
++  @Override
++  public DispatchMethod getDispatchMethod(final ExecutableFlow flow) {
++    return getDispatchMethod();
++  }
++
+   protected String uploadExecutableFlow(
+       final ExecutableFlow exflow, final String userId, final String flowId,
+       String message) throws ExecutorManagerException {",Wasn't this added as a part of different PR already?
+8315,"@@ -8,7 +8,7 @@ class UrlListData
+     public const FIELD_SLUG = 'slug';
+
+     /**
+-     * @var \Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\FriendlyUrl[]
++     * @var \Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\FriendlyUrl[][]
+      */
+     public $toDelete;
+ ","hmmmmm, should not be in constructor in this case `$this->toDelete = [[]];` ??? maybe not"
+8316,"@@ -114,8 +114,11 @@ def toggle_routing_control_state(routing_control_arn, cluster_endpoints):
+     update_state = 'Off' if state == 'On' else 'On'
+     print(f""Setting control state to '{update_state}'."")
+     response = update_routing_control_state(routing_control_arn, cluster_endpoints, update_state)
+-    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
++    status = response.get('ResponseMetadata', {}).get('HTTPStatusCode', 'Unknown')
++    if status == 200:
+         print('Success!')
++    else:
++        print(f'Something went wrong. Status: {status}.')
+     print('-'*88)
+ # snippet-end:[python.example_code.route53-recovery-cluster.Scenario_SetControlState]
+ ","We can just update it to be as follows: `if response: print(""Success"") else: print(""Error"")`"
+8317,"@@ -119,6 +119,7 @@ type Helper struct {
+ 	matcherDefs  map[string]caddy.ModuleMap
+ 	parentBlock  caddyfile.ServerBlock
+ 	groupCounter counter
++	state        map[string]interface{}
+ }
+
+ // Option gets the option keyed by name.",Maybe this should be exported so (external/third-party) plugins can also use it.
+8318,"@@ -38,17 +38,9 @@ func (service *servicePFCtl) Add(rule RuleForwarding) {
+ }
+
+ func (service *servicePFCtl) Start() error {
+-	err := service.ipForward.Enable()
+-	if err != nil {
+-		return err
+-	}
+-
++	service.ipForward.Enable()
+ 	service.clearStaleRules()
+-	err = service.enableRules()
+-	if err != nil {
+-		return err
+-	}
+-	return nil
++	return service.enableRules()
+ }
+
+ func (service *servicePFCtl) Stop() {",Warning logging whould be exactly here in high logic. So that everybody understands why we swallow errors
+8319,"@@ -46,6 +46,7 @@ namespace Nethermind.JsonRpc.WebSockets
+             string clientName,
+             ISocketHandler handler,
+             RpcEndpoint endpointType,
++            JsonRpcUrl? url,
+             IJsonRpcProcessor jsonRpcProcessor,
+             IJsonRpcService jsonRpcService,
+             IJsonRpcLocalStats jsonRpcLocalStats,","if its optional, move it to last item an use JsonRpcUrl? url = null"
+8320,"@@ -58,6 +58,14 @@ class User < ActiveRecord::Base
+     user
+   end
+
++  def client_model
++    Proposal.client_model_for(self)
++  end
++
++  def client_model_slug
++    client_model.to_s.underscore.tr(""/"", ""_"")
++  end
++
+   def add_role(role_name)
+     role = Role.find_or_create_by!(name: role_name)
+     user_roles.find_or_create_by!(role: role)",how is this different from the `client_slug` method already available on a `user` ?
+8321,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...
+8322,"@@ -49,11 +49,14 @@ module Travis
+             fi
+           ),
+           redirect_io: %(
+-            exec > >(
+-              %{curl}
+-              %{exports}
+-              ruby ~/filter.rb %{args}
+-            ) 2>&1
++            if [[ -z ""$TRAVIS_FILTERED"" ]]; then
++              export TRAVIS_FILTERED=1
++              exec 9>&1 1>(
++                %{curl}
++                %{exports}
++                ruby ~/filter.rb %{args}
++              ) 2>&1
++            fi
+           )
+         }
+ ",I believe this env var won't be set anywhere. Do we need this condition?
+8323,"@@ -14,7 +14,7 @@ function getWindowLocationSearch(win) {
+     return search || '';
+ }
+
+-function getParameterByName(name, url) {
++window.getParameterByName = function (name, url) {
+     'use strict';
+
+     name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');",why add function explicitly?
+8324,"@@ -92,7 +92,8 @@ func newLevel() *level {
+
+ // New will create a default sublist
+ func NewSublist() *Sublist {
+-	return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)}
++	//	return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)}
++	return &Sublist{root: newLevel()}
+ }
+
+ // Insert adds a subscription into the sublist","Is that intentional? If you don't create the cache here, it will never be created therefore used."
+8325,"@@ -136,4 +136,15 @@ func TestStream(t *testing.T) {
+ 		require.Greater(t, streamer.fetchCount, 1, ""expected more than one call to Fetch within timeout"")
+ 		require.Greater(t, streamer.notifyCount, 1, ""expected more than one call to Notify within timeout"")
+ 	})
++
++	t.Run(""nextFetchDate works correctly to grab times before the timeout."", func(t *testing.T) {
++		for r := 0; r < 1000; r++ {
++			now := time.Now()
++			a := nextFetchDate(now, 0)
++			require.True(t, a.Before(now.Add(4*time.Second)), ""require that the given date for 0 retries is less than 4s in the future"")
++			b := nextFetchDate(now, 10)
++			require.True(t, b.Before(now.Add(32*time.Second)), ""require that the given date for 10 retries is never more than the max interval"")
++		}
++
++	})
+ }",I think we can now remove this test case since we can ensure that multiple calls to `Fetch` will double the interval on each call
+8326,"@@ -64,7 +64,7 @@ type (
+ )
+
+ const (
+-	reservedTaskListPrefix = ""/__cadence_sys/""
++	reservedTaskListPrefix = ""/__temporal_sys/""
+ )
+
+ func newDecisionAttrValidator(",Not part of this PR but this const seems to be defined in multiple places. Needs to be extracted somewhere.
+8327,"@@ -2,6 +2,7 @@ package volume
+
+ import (
+ 	""fmt""
++
+ 	""github.com/libopenstorage/openstorage/api""
+ 	""github.com/libopenstorage/openstorage/api/client""
+ 	""github.com/libopenstorage/openstorage/volume""",Remove this file from the PR
+8328,"@@ -55,6 +55,11 @@ namespace Nethermind.Core.Specs
+             {
+                 return Byzantium.Instance;
+             }
++
++            if (blockNumber < IstanbulBlockNumber)
++            {
++                return Istanbul.Instance;
++            }
+
+             return ConstantinopleFix.Instance;
+         }","need to add it for ropsten, rinkeby, goerli as well"
+8329,"@@ -109,7 +109,7 @@ func (v *VolumeProperty) Execute() ([]byte, error) {
+ 		return nil, err
+ 	}
+ 	// execute command here
+-	return exec.Command(bin.ZFS, v.Command).CombinedOutput()
++	return exec.Command(bin.BASH, ""-c"", v.Command).CombinedOutput()
+ }
+
+ // Build returns the VolumeProperty object generated by builder",G204: Subprocess launching should be audited (from `gosec`)
+8330,"@@ -49,11 +49,11 @@ import org.apache.orc.storage.ql.exec.vector.MapColumnVector;
+ import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
+ import org.apache.orc.storage.serde2.io.HiveDecimalWritable;
+
+-class FlinkOrcReaders {
++public class FlinkOrcReaders {
+   private FlinkOrcReaders() {
+   }
+
+-  static OrcValueReader<StringData> strings() {
++  public static OrcValueReader<StringData> strings() {
+     return StringReader.INSTANCE;
+   }
+ ","curious why only making these 3 public. what about other package scope methods like `times`, `timestamps`, `array`?"
+8331,"@@ -0,0 +1,15 @@
++<?php
++
++return [
++    /*
++    |--------------------------------------------------------------------------
++    | Exclusion list
++    |--------------------------------------------------------------------------
++    |
++    | This is a list of exclusions for words or phrases where the original
++    | form of the word has the same spelling in a given language.
++    |
++    */
++
++    'Email',
++];","The Email field is not translated into Russian, and into any other. It's kind of a ""standard"" word. Therefore, we may face the fact that you have to create files with exceptions for all languages. @caouecs, what do you say?"
+8332,"@@ -32,6 +32,9 @@ int main (int argc, char * const * argv)
+ 		(""disable_unchecked_drop"", ""Disables drop of unchecked table at startup"")
+ 		(""fast_bootstrap"", ""Increase bootstrap speed for high end nodes with higher limits"")
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
++		(""block_processor_batch_size"",boost::program_options::value<std::size_t> (), ""Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time), 256k for fast_bootstrap"")
++		(""block_processor_full_size"",boost::program_options::value<std::size_t> (), ""Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536, 1 million for fast_bootstrap"")
++		(""block_processor_verification_size"",boost::program_options::value<std::size_t> (), ""Increase batch signature verification size in block processor, default 0 (2048 * signature checker threads + 1), unlimited for fast_bootstrap"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
+ 		(""debug_dump_online_weight"", ""Dump online_weights table"")",Should it say `default 0` here? looks a bit confusing. Also following BODMAS we should put: `2048 * (signature checker threads + 1)`
+8333,"@@ -16,6 +16,7 @@
+
+ from __future__ import print_function
+ import os
++import ruamel.yaml
+
+ import constants
+ import utils","Add a newline. We group by 1: standard library, 2: 3rd party library, 3: application library"
+8334,"@@ -83,7 +83,9 @@ func (p *Provider) Type() string {
+ 	return ProviderType
+ }
+
+-func (p *Provider) RunQuery(ctx context.Context, query string, queryRange metrics.QueryRange, evaluator metrics.Evaluator) (bool, string, error) {
++// Evaluate queries the range query endpoint and checks if values in all data points are within the expected range.
++// For the range query endpoint, see: https://prometheus.io/docs/prometheus/latest/querying/api/#range-queries
++func (p *Provider) Evaluate(ctx context.Context, query string, queryRange metrics.QueryRange, evaluator metrics.Evaluator) (bool, string, error) {
+ 	if err := queryRange.Validate(); err != nil {
+ 		return false, """", err
+ 	}",So `queryRange.Step` will be ignored?
+8335,"@@ -24,13 +24,13 @@
+
+ // making the defines very clear, these represent the host architecture - aka
+ // the arch on which this code is running
+-#if defined(_X86_)
++#if defined(HOST_X86)
+ #define _HOST_X86_
+-#elif defined(_AMD64_)
++#elif defined(HOST_AMD64)
+ #define _HOST_AMD64_
+-#elif defined(_ARM_)
++#elif defined(HOST_ARM)
+ #define _HOST_ARM_
+-#elif defined(_ARM64_)
++#elif defined(HOST_ARM64)
+ #define _HOST_ARM64_
+ #endif
+ ",It would be nice to replace these _HOST_* defines with HOST_*.
+8336,"@@ -299,5 +299,9 @@ func doList(dir string, out io.Writer, arg, indent string) error {
+ // scrub removes dynamic content from recorded files.
+ func scrub(rootDir string, b []byte) []byte {
+ 	const scrubbedRootDir = ""[ROOTDIR]""
+-	return bytes.ReplaceAll(b, []byte(rootDir), []byte(scrubbedRootDir))
++	rootDirWithSeparator := rootDir + string(filepath.Separator)
++	scrubbedRootDirWithSeparator := scrubbedRootDir + string(filepath.Separator)
++	b = bytes.Replace(b, []byte(rootDirWithSeparator), []byte(scrubbedRootDirWithSeparator), -1)
++	b = bytes.Replace(b, []byte(rootDir), []byte(scrubbedRootDir), -1)
++	return b
+ }","The problem here was that the record file started with something like `/tmp/whatever/myproj` and was scrubbed to `[ROOTDIR]/myproj`, but the `/` is a `\` on Windows."
+8337,"@@ -33,10 +33,13 @@
+
+ #include <rtps/builtin/data/ProxyHashTables.hpp>
+
++#include ""../../../fastdds/core/policy/ParameterList.hpp""
++
+ #include <mutex>
+ #include <chrono>
+
+ using namespace eprosima::fastrtps;
++using ParameterList = eprosima::fastdds::dds::ParameterList;
+
+ namespace eprosima {
+ namespace fastrtps {",Don't use relative paths. src directory is already on the include search path
+8338,"@@ -177,8 +177,12 @@ type BuildTarget struct {
+ 	// Tools that this rule will use, ie. other rules that it may use at build time which are not
+ 	// copied into its source directory.
+ 	Tools []BuildInput
++	// Like tools but available to the test_cmd instead
++	TestTools []BuildInput
+ 	// Named tools, similar to named sources.
+ 	namedTools map[string][]BuildInput `name:""tools""`
++	// Named test tools, similar to named sources.
++	namedTestTools map[string][]BuildInput `name:""test_tools""`
+ 	// Target-specific environment passthroughs.
+ 	PassEnv *[]string `name:""pass_env""`
+ 	// Target-specific unsafe environment passthroughs.",if we're introducing this now can we make this private?
+8339,"@@ -103,6 +103,17 @@ namespace pwiz.Skyline.Model.Results
+             if (_totalSteps == 0)
+                 return measured;
+
++            // Before we do anything else, make sure the raw files are present
++            foreach (var f in fileInfos)
++            {
++                if (!ScanProvider.FileExists(_documentFilePath, f.FilePath))
++                {
++                    throw new FileNotFoundException(TextUtil.LineSeparate(Resources.IonMobilityFinder_ProcessMSLevel_Failed_using_results_to_populate_ion_mobility_library_,
++                    string.Format(Resources.ScanProvider_GetScans_The_data_file__0__could_not_be_found__either_at_its_original_location_or_in_the_document_or_document_parent_folder_,
++                        f.FilePath)));
++                }
++            }
++
+             using (_msDataFileScanHelper = new MsDataFileScanHelper(SetScans, HandleLoadScanException, true))
+             {
+                 //",Something is wrong with the indentation here.
+8340,"@@ -18,12 +18,13 @@ package importtestsuites
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/compute""
+ 	""log""
+ 	""regexp""
++	""strings""
+ 	""sync""
+
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/path""
+-	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/compute""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/test_suites""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/e2e_test_utils/junitxml""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/e2e_test_utils/test_config""",This should go to the external imports group below
+8341,"@@ -36,6 +36,7 @@ func NewInstaller(dc dynamic.Interface, config map[string]string, paths ...strin
+ 	}
+
+ 	for i, p := range paths {
++		log.Println(""processing yaml folder"", p)
+ 		paths[i] = ParseTemplates(p, config)
+ 	}
+ 	path := strings.Join(paths, "","")",Intended to be checked in?
+8342,"@@ -307,7 +307,10 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+
+       // Currently nothing to do but print a warning
+       LOGGER.warn(""There are schemas only existing in service center: {}, which means there are interfaces changed. ""
+-          + ""It's recommended to increment microservice version before deploying."", scSchemaMap.keySet());
++              + ""It's recommended to increment microservice version before deploying."",
++          scSchemaMap.keySet());
++      LOGGER.warn(""ATTENTION: The schemas in new version are less than the old version, ""
++          + ""which may cause compatibility problems."");
+     }
+   }
+ ","I think this warning message is the same as above one. Anyway, it's fine to keep it."
+8343,"@@ -46,7 +46,7 @@ namespace Nethermind.Logging
+
+             if (NLog.LogManager.Configuration?.AllTargets.SingleOrDefault(t => t.Name == ""file"") is FileTarget target)
+             {
+-                target.FileName = !Path.IsPathFullyQualified(fileName) ? Path.Combine(""logs"", fileName) : fileName;
++                target.FileName = !Path.IsPathFullyQualified(fileName) ? Path.Combine(logsDir, fileName) : fileName;
+             }
+
+             /* NOTE: minor perf gain - not planning to switch logging levels while app is running */","This is done few times, replace with some well named method"
+8344,"@@ -101,14 +101,14 @@ public class CodeGeneratorTool {
+
+   private static int generate(
+       String descriptorSet,
+-      String[] apiConfigs,
++      String[] configs,
+       String[] generatorConfigs,
+       String packageConfig,
+       String outputDirectory,
+       String[] enabledArtifacts) {
+     ToolOptions options = ToolOptions.create();
+     options.set(ToolOptions.DESCRIPTOR_SET, descriptorSet);
+-    options.set(ToolOptions.CONFIG_FILES, Lists.newArrayList(apiConfigs));
++    options.set(ToolOptions.CONFIG_FILES, Lists.newArrayList(configs));
+     options.set(CodeGeneratorApi.OUTPUT_FILE, outputDirectory);
+     options.set(CodeGeneratorApi.GENERATOR_CONFIG_FILES, Lists.newArrayList(generatorConfigs));
+     options.set(CodeGeneratorApi.PACKAGE_CONFIG_FILE, packageConfig);","`configs` isn't very descriptive, especially when there are other config-ish things like `generatorConfigs`."
+8345,"@@ -192,7 +192,12 @@ class TestGatlingExecutor(BZTestCase):
+                               }]},
+                              {""url"": ""/"",
+                               ""think-time"": 2,
+-                              ""follow-redirects"": True}]
++                              ""follow-redirects"": True},
++                             {""url"": ""/reserve.php"",
++                              ""method"": ""POST"",
++                              ""body"": u""Body Content 2"",
++                              }
++                             ]
+             }
+         })
+         self.obj.prepare()",In my point we have to check conversion with specific (non-ASCII) characters in unicode string.
+8346,"@@ -1,6 +1,7 @@
+ tests = [
+-  (""python"", ""EmbedLib.py"", {}),
++  #   (""python"", ""EmbedLib.py"", {}),
+   (""python"", ""UnitTestEmbed.py"", {}),
++  (""python"", ""UnitTestExcludedVolume.py"", {}),
+   (""python"", ""UnitTestPharmacophore.py"", {}),
+ ]
+ ","Given that file still contains doctests (and should still contain doctests), they should be run. Please turn this back on."
+8347,"@@ -70,6 +70,7 @@ public class SignUtils {
+     private static final String ATTR_CONTENTS = ""contents"";
+     private static final String ATTR_CERT_DNS_DOMAIN = ""certDnsDomain"";
+     private static final String ATTR_AUDIT_ENABLED = ""auditEnabled"";
++    private static final String ATTR_SELF_SERVE = ""selfserve"";
+
+     private static Struct asStruct(DomainPolicies domainPolicies) {
+         // all of our fields are in canonical order based",we should keep the camel case format - selfServe
+8348,"@@ -17,14 +17,15 @@ package patch
+ import (
+ 	""time""
+
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/compute""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/utils""
+-	""google.golang.org/api/compute/v1""
++	api ""google.golang.org/api/compute/v1""
+ )
+
+ type patchTestSetup struct {
+ 	testName      string
+ 	image         string
+-	startup       *compute.MetadataItems
++	metadata      []*api.MetadataItems
+ 	assertTimeout time.Duration
+ 	machineType   string
+ }",consider the alias `compute` in case this ever references other apis.
+8349,"@@ -392,3 +392,7 @@ func (m *manager) GetFreezerState() (configs.FreezerState, error) {
+ 	}
+ 	return freezer.(*FreezerGroup).GetState(dir)
+ }
++
++func (m *manager) Exists() bool {
++	return cgroups.PathExists(m.paths[""devices""])
++}","It probably doesn't matter in practice, but we're not supposed to access a map without holding a lock. This is why I have suggested using `m.Path(""devices"")` earlier -- it takes a lock before accessing m.paths. Alternatively, you can leave this code as is but add taking a lock (same as `Path()`)."
+8350,"@@ -33,6 +33,8 @@ let baseModuleStore = Modules.createModuleStore( 'tagmanager', {
+ 		'internalAMPContainerID',
+ 		'useSnippet',
+ 		'ownerID',
++		'gaAMPPropertyID',
++		'gaPropertyID',
+ 	],
+ 	submitChanges,
+ 	validateCanSubmitChanges,","Since `ga` is an acronym here, we should rename the generated actions and selectors to adhere to our naming conventions as it will no longer be capitalized properly. See below for how this is already done for the amp container ID settings. We should add `GA` to our list of checked acronyms as well in `packages/eslint-plugin/rules/acronym-case.js`."
+8351,"@@ -88,12 +88,11 @@ class TransloaditAssembly extends Emitter {
+
+     socket.on('assembly_upload_finished', (file) => {
+       this.emit('upload', file)
+-      this._fetchStatus({ diff: false })
++      this.status.uploads.push(file)
+     })
+
+     socket.on('assembly_uploading_finished', () => {
+       this.emit('executing')
+-      this._fetchStatus({ diff: false })
+     })
+
+     socket.on('assembly_upload_meta_data_extracted', () => {","uploading_finished and upload_meta_data_extracted can fire very quickly after another, and there is not much difference in the Assembly status that's useful to us. I kept only the Assembly fetch after metadata is extracted, which ensures that we'll have all the correct `uploads.*.meta` properties on the client side."
+8352,"@@ -53,7 +53,10 @@ func (m *manager) getControllers() error {
+
+ 	file := filepath.Join(m.dirPath, ""cgroup.controllers"")
+ 	data, err := ioutil.ReadFile(file)
+-	if err != nil && !m.rootless {
++	if err != nil {
++		if m.rootless && m.config.Path == """" {
++			return nil
++		}
+ 		return err
+ 	}
+ 	fields := strings.Fields(string(data))","Does it make sense to keep trying to read the file every time the function is called, or should we maybe use `sync.Once()` here?"
+8353,"@@ -59,6 +59,7 @@ type Bee struct {
+
+ type Options struct {
+ 	DataDir            string
++	DbCapacity         uint64
+ 	Password           string
+ 	APIAddr            string
+ 	DebugAPIAddr       string",`DbCapacity` -> `DBCapacity`
+8354,"@@ -56,8 +56,10 @@ namespace Nethermind.Network.Test
+         [TestCase(0, ""0xa3f5ab08"", 1_561_651L, ""Unsynced"")]
+         [TestCase(1_561_650L, ""0xa3f5ab08"", 1_561_651L, ""Last Constantinople block"")]
+         [TestCase(1_561_651L, ""0xc25efa5c"", 4_460_644L, ""First Istanbul block"")]
+-        [TestCase(4_460_644L, ""0x757a1c47"", 0L, ""First Berlin block"")]
+-        [TestCase(6_000_000L, ""0x757a1c47"", 0L, ""Future Berlin block"")]
++        [TestCase(4_460_644L, ""0x757a1c47"", 5_062_605, ""First Berlin block"")]
++        [TestCase(4_600_000L, ""0x757a1c47"", 5_062_605, ""Future Berlin block"")]
++        [TestCase(5_062_605L, ""0xB8C6299D"", 0L, ""First London block"")]
++        [TestCase(5_979_794L, ""0xB8C6299D"", 0L, ""Future London block"")]
+         public void Fork_id_and_hash_as_expected_on_goerli(long head, string forkHashHex, long next, string description)
+         {
+             Test(head, KnownHashes.GoerliGenesis, forkHashHex, next, description, GoerliSpecProvider.Instance, ""goerli.json"");",For Berlin I confirmed all the fork hashes with the Geth team. Would you do the same with Martin? He responded quickly the last time.
+8355,"@@ -63,6 +63,19 @@ func Wireguard() error {
+ 	return sh.RunV(cmdParts[0], cmdParts[1:]...)
+ }
+
++// SOCKS5 builds and starts SOCKS5 service with terms accepted
++func SOCKS5() error {
++	if err := sh.RunV(""bin/build""); err != nil {
++		return err
++	}
++	cmd := ""build/myst/myst service --agreed-terms-and-conditions socks5""
++	if runtime.GOOS == ""darwin"" {
++		cmd = ""sudo "" + cmd
++	}
++	cmdParts := strings.Split(cmd, "" "")
++	return sh.RunV(cmdParts[0], cmdParts[1:]...)
++}
++
+ // CLI builds and runs myst CLI
+ func CLI() error {
+ 	if err := sh.RunV(""bin/build""); err != nil {",Does `sudo` required for `darwin` only? Don't we need it for `linux` too?
+8356,"@@ -11,11 +11,17 @@ import (
+ 	""text/tabwriter""
+
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/cloudformation""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/resourcegroups""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/session""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store""
+ 	sess ""github.com/aws/aws-sdk-go/aws/session""
+ )
+
++const (
++	cloudformationResourceType = ""AWS::CloudFormation::Stack""
++)
++
+ type EnvDescription struct {
+ 	Environment  *archer.Environment   `json:""environment""`
+ 	Applications []*archer.Application `json:""applications""`",Can you add description to this exported struct?
+8357,"@@ -68,13 +68,14 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		state = component.state,
+ 		context = component.context,
+ 		previousProps = component.prevProps || props,
+-		previousState = component.prevState || state,
++		previousState = extend({}, component.prevState || state),
+ 		previousContext = component.prevContext || context,
+ 		isUpdate = component.base,
+ 		nextBase = component.nextBase,
+ 		initialBase = isUpdate || nextBase,
+ 		initialChildComponent = component._component,
+ 		skip = false,
++		snapshot = previousContext,
+ 		rendered, inst, cbase;
+
+ 	if (component.constructor.getDerivedStateFromProps) {","Although this is needed for `getSnapshotBeforeUpdate` this also fixes a bug with `componentDidUpdate`. During rendering, the `state` variable is mutated. This has the consequence, that `previousState` would never hold the previous state, but the most current one."
+8358,"@@ -15,6 +15,7 @@ package ec2
+
+ import (
+ 	""github.com/aws/aws-sdk-go/service/ec2/ec2iface""
++	""github.com/aws/aws-sdk-go/service/elb/elbiface""
+ )
+
+ // Service holds a collection of interfaces.",Should this maybe directly start with ELBv2 aka NLBs or ALBs?
+8359,"@@ -59,6 +59,11 @@ describe( 'Tag Manager module setup', () => {
+ 				request.respond( {
+ 					status: 200,
+ 				} );
++			} else if ( request.url().match( 'google-site-kit/v1/core/site/data/notifications' ) ) {
++				request.respond( {
++					status: 200,
++					body: JSON.stringify( [] ),
++				} );
+ 			} else if ( request.url().match( 'modules/tagmanager/data/live-container-version' ) ) {
+ 				// Return a live container version without GA.
+ 				request.respond( { status: 200, body: JSON.stringify( liveContainerVersionFixture ) } );",This was the request that was often causing the test to fail as an unexpected API failure (or at least one of them   ).
+8360,"@@ -0,0 +1,13 @@
++class NetworkError extends Error {
++  constructor (error = null, xhr = null) {
++    super(error.message)
++
++    this.isNetworkError = true
++    this.originalRequest = xhr
++
++    const message = error.message + '. This looks like a network error, the endpoint might be blocked by an ISP or a firewall'
++    this.message = message
++  }
++}
++
++module.exports = NetworkError","I understand why `xhr = null`, but I think adding `error = null` implies that this method should work even if we don't pass the `error` argument. Should we remove it?"
+8361,"@@ -73,7 +73,8 @@ public abstract class GapicMethodConfig extends MethodConfig {
+       Method method,
+       ProtoMethodModel methodModel,
+       RetryCodesConfig retryCodesConfig,
+-      ImmutableSet<String> retryParamsConfigNames) {
++      ImmutableSet<String> retryParamsConfigNames,
++      GrpcGapicRetryMapping retryMapping) {
+
+     GrpcStreamingConfig grpcStreaming = null;
+     if (isGrpcStreamingMethod(methodModel)) {","It is not your code, and it is used like this all over the place in gapic generator, but the general rule is we should prefer using the least specific class/interface in the hierarchy, which still satisfies our requirements. Here, unless we really need anything specific from `ImmutableSet`, please use `Set` (less specific type) instead."
+8362,"@@ -162,9 +162,18 @@ struct flb_elasticsearch *flb_es_conf_create(struct flb_output_instance *ins,
+             }
+             ctx->aws_region = (char *) tmp;
+
++            tmp = flb_output_get_property(""aws_sts_endpoint"", ins);
++            if (!tmp) {
++                flb_error(""[out_es] aws_sts_endpoint not set"");
++                flb_es_conf_destroy(ctx);
++                return NULL;
++            }
++            ctx->aws_sts_endpoint = (char *) tmp;
++
+             ctx->aws_provider = flb_standard_chain_provider_create(config,
+                                                                    &ctx->aws_tls,
+                                                                    ctx->aws_region,
++                                                                   ctx->aws_sts_endpoint,
+                                                                    NULL,
+                                                                    flb_aws_client_generator());
+             if (!ctx->aws_provider) {","Sorry... I just realized... since we use sts_endpoint in the EKS Provider, this error message is no longer true. Role_arn is not required."
+8363,"@@ -206,6 +206,18 @@ public interface Tree<T> extends Traversable<T>, Serializable {
+         return io.vavr.collection.Collections.fill(n, s, empty(), Tree::of);
+     }
+
++    /**
++     * Returns a Tree containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Tree
++     * @param n       The number of elements in the Tree
++     * @param element The element
++     * @return A Tree of size {@code n}, where each element is the given {@code element}.
++     */
++    static <T> Tree<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element, empty(), Tree::of);
++    }
++
+     /**
+      * Recursively builds a non-empty {@code Tree}, starting with the given {@code seed} value and proceeding in depth-first order.
+      * <p>","(...), where each element ~are~ **is the** given {\@code element}."
+8364,"@@ -73,6 +73,7 @@ abstract class BaseFile<F>
+   private long[] splitOffsets = null;
+   private int[] equalityIds = null;
+   private byte[] keyMetadata = null;
++  private Integer sortOrderId;
+
+   // cached schema
+   private transient Schema avroSchema = null;","I think this can be an int because we have a default that is always valid, `0`."
+8365,"@@ -141,6 +141,17 @@ describe Section do
+     end
+   end
+
++  describe '.upcoming?' do
++    it 'knows if it has happened yet' do
++      next_week = Section.new(starts_on: 1.week.from_now)
++      last_week = Section.new(starts_on: 1.week.ago)
++      today = Section.new(starts_on: Date.today)
++      expect(today).to be_upcoming
++      expect(next_week).to be_upcoming
++      expect(last_week).not_to be_upcoming
++    end
++  end
++
+   describe '#fulfillment_method' do
+     it 'returns in-person if the workshop is an in-person one' do
+       in_person_workshop = create(:workshop, online: false)",I think you can use `build_stubbed` here for the same results but with more speed.
+8366,"@@ -491,6 +491,11 @@ class JMX(object):
+         if hold or (rampup and not iterations):
+             scheduler = True
+
++        if isinstance(rampup, numeric_types) and isinstance(hold, numeric_types):
++            duration = hold + rampup
++        else:
++            duration = 0
++
+         trg = etree.Element(""ThreadGroup"", guiclass=""ThreadGroupGui"",
+                             testclass=""ThreadGroup"", testname=testname)
+         if on_error is not None:",what if one of them is property and one is not?
+8367,"@@ -277,6 +277,8 @@ module.exports = class Dashboard extends Plugin {
+         name: file.name,
+         type: file.type,
+         data: blob
++      }).catch(() => {
++        // Ignore
+       })
+     })
+   }",> UI plugins swallow rejection errors so they don't end up in the console with no way to fix But it will still catch upstream in `addFile` and restrictions to show the informer?..
+8368,"@@ -378,11 +378,12 @@ const executeOperation = (topology, operation, args, options) => {
+
+   // The driver sessions spec mandates that we implicitly create sessions for operations
+   // that are not explicitly provided with a session.
+-  let session, opOptions;
++  let session, opOptions, owner;
+   if (!options.skipSessions && topology.hasSessionSupport()) {
+     opOptions = args[args.length - 2];
+     if (opOptions == null || opOptions.session == null) {
+-      session = topology.startSession();
++      owner = {};
++      session = topology.startSession({ owner });
+       const optionsIndex = args.length - 2;
+       args[optionsIndex] = Object.assign({}, args[optionsIndex], { session: session });
+     } else if (opOptions.session && opOptions.session.hasEnded) {",can't this just be left undefined/null?
+8369,"@@ -64,8 +64,8 @@ module EsSpecHelper
+   def es_execute_with_retries(retries = 3, &block)
+     begin
+       retries -= 1
+-      response = block.call
+-    rescue SearchUnavailable => _error
++      block.call
++    rescue SearchUnavailable => error
+       if retries > 0
+         retry
+       else",changed bc we are using the `error` var below
+8370,"@@ -172,13 +172,7 @@ class TestKnowledgeRestfulAPI(APITestCase):
+             user_id=1,
+         )
+
+-        answer = get_answer.json
+-
+-        expected_result = dict(
+-            status=404,
+-        )
+-
+-        assert answer['status'] == expected_result['status']
++        assert get_answer.status_code == 404
+
+     def test_get_knwkb_mappings(self):
+         """"""Test the return of list of mappings.""""""",Is there a reason why this is change is in the same commit?
+8371,"@@ -77,7 +77,7 @@ func (r *repo) GetClonedBranch() string {
+
+ // Copy does copying the repository to the given destination.
+ func (r *repo) Copy(dest string) (Repo, error) {
+-	cmd := exec.Command(""cp"", ""-rf"", r.dir, dest)
++	cmd := copyCommand(r.dir, dest)
+ 	out, err := cmd.CombinedOutput()
+ 	if err != nil {
+ 		return nil, formatCommandError(err, out)","@nghialv btw, perhaps was this method originally created for copying the repo root to the given `dest` as a subdirectory?"
+8372,"@@ -205,7 +205,7 @@ namespace pwiz.Skyline.Model.Lib
+         // ReSharper disable LocalizableElement
+         private bool LoadLibraryFromDatabase(ILoadMonitor loader)
+         {
+-            var status = new ProgressStatus(
++            IProgressStatus status = new ProgressStatus(
+                 string.Format(Resources.ChromatogramLibrary_LoadLibraryFromDatabase_Reading_precursors_from__0_,
+                     Name));
+             try",Just curious - why not var?
+8373,"@@ -26,6 +26,9 @@ import {
+ 	clearWebStorage,
+ } from './util/standalone';
+
++// Load image for the parent menu item.
++import '../images/logo-g_white_small.png';
++
+ if ( 'toplevel_page_googlesitekit-dashboard' !== global.pagenow && 'site-kit_page_googlesitekit-splash' !== global.pagenow && 'admin_page_googlesitekit-splash' !== global.pagenow && global.localStorage ) {
+ 	// The total notifications count should always rely on local storage
+ 	// directly for external availability.",Why would we import this here and not use it? Is there a side-effect of this import?
+8374,"@@ -281,8 +281,10 @@ module RSpec::Core
+     # @attr pending_examples [Array<RSpec::Core::Example>] the pending examples
+     # @attr load_time [Float] the number of seconds taken to boot RSpec
+     #                         and load the spec files
++    # @attr errors [Integer] the number of errors that have occurred processing
++    #                        the spec suite
+     SummaryNotification = Struct.new(:duration, :examples, :failed_examples,
+-                                     :pending_examples, :load_time)
++                                     :pending_examples, :load_time, :errors)
+     class SummaryNotification
+       # @api
+       # @return [Fixnum] the number of examples run",The name `errors` is a bit mis-leading -- usually I'd expect a field called `errors` to be an array of errors but here it's just a count. And it's not a count of _all_ errors -- it's a count only of some errors.
+8375,"@@ -24,7 +24,6 @@ class AppKernel extends Kernel
+             new JMS\TranslationBundle\JMSTranslationBundle(),
+             new Presta\SitemapBundle\PrestaSitemapBundle(),
+             new Prezent\Doctrine\TranslatableBundle\PrezentDoctrineTranslatableBundle(),
+-            new RaulFraile\Bundle\LadybugBundle\RaulFraileLadybugBundle(),
+             new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
+             new Shopsys\FormTypesBundle\ShopsysFormTypesBundle(),
+             new ShopSys\MigrationBundle\ShopSysMigrationBundle(),",there was no usage of the bundle in the framework? everything works exactly the same after the removal?
+8376,"@@ -327,6 +327,14 @@ var _ = infrastructure.DatastoreDescribe(""_BPF-SAFE_ IPIP topology before adding
+ 		BeforeEach(func() {
+ 			ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
+ 			defer cancel()
++			if bpfEnabled {
++				infra.RemoveNodeAddresses(felixes[0])
++			} else {
++				for _, f := range felixes {
++					infra.RemoveNodeAddresses(f)
++				}
++			}
++
+ 			listOptions := options.ListOptions{}
+ 			if bpfEnabled {
+ 				listOptions.Name = felixes[0].Hostname",Why this difference?
+8377,"@@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
+         if (retcode == SQL_ERROR)
+         {
+             ERROR_DESC_def *p_buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
++            char             errNumStr[128];
++            sprintf(errNumStr, ""%d"", p_buffer->sqlcode);
+             strncpy(RequestError, p_buffer->errorText, sizeof(RequestError) - 1);
+
+             SendEventMsg(MSG_SQL_ERROR,","Surround code issue. RequestError may not be null terminated when the RequestError size is less than the length of the string in p_buffer->errorText. Also, this can cause core dump due to segment violation if length of errorText is less than the size of RequestBuffer."
+8378,"@@ -43,6 +43,11 @@ const (
+ 	AccountTrieRootKey = ""accountTrieRoot""
+ )
+
++var (
++	// AccountMaxVersionPrefix is for account history
++	AccountMaxVersionPrefix = []byte(""vp."")
++)
++
+ type (
+ 	// Factory defines an interface for managing states
+ 	Factory interface {",`AccountMaxVersionPrefix` is a global variable (from `gochecknoglobals`)
+8379,"@@ -32,7 +32,6 @@ import (
+
+ 	apicommon ""go.temporal.io/api/common/v1""
+ 	""go.temporal.io/api/enums/v1""
+-	apinamespace ""go.temporal.io/api/namespace/v1""
+ 	apireplication ""go.temporal.io/api/replication/v1""
+ 	""go.temporal.io/api/serviceerror""
+ 	""go.temporal.io/api/workflowservice/v1""","I see it is not part of this PR but I somehow overlooked it before. Can you use same import aliases as we use everywhere in the project: `apicommon` -> `commonpb` `apireplication` -> `replicationpb` `""go.temporal.io/api/enums/v1""` -> `enumspb ""go.temporal.io/api/enums/v1""`"
+8380,"@@ -235,7 +235,7 @@ class Storage(StorageBase, MigratorMixin):
+                     error_msg = (
+                         ""Cannot initialize empty resource timestamp "" ""when running in readonly.""
+                     )
+-                    raise exceptions.BackendError(message=error_msg)
++                    raise exceptions.ReadonlyError(message=error_msg)
+                 obj = row
+             else:
+                 create_result = conn.execute(",Nit: Maybe merge these into one string while you are here?
+8381,"@@ -0,0 +1,15 @@
++package runtime
++
++// noret is a placeholder that can be used to indicate that an async function is not going to directly return here
++func noret() {}
++
++func getParentHandle() *task {
++	panic(""NOPE"")
++}
++
++func fakeCoroutine(dst **task) {
++	*dst = getCoroutine()
++	for {
++		yield()
++	}
++}",Why make a new file for this? I think keeping everything related to the scheduler in a single file increases readability. Especially when there is no API-boundary in between. Functions like `getCoroutine` and `yield` also live in the normal scheduler files so it doesn't seem consistent.
+8382,"@@ -132,9 +132,10 @@ func (c *endpointManagerCallbacks) InvokeRemoveWorkload(old *proto.WorkloadEndpo
+ // that fail are left in the pending state so they can be retried later.
+ type endpointManager struct {
+ 	// Config.
+-	ipVersion              uint8
+-	wlIfacesRegexp         *regexp.Regexp
+-	kubeIPVSSupportEnabled bool
++	ipVersion                 uint8
++	wlIfacesRegexp            *regexp.Regexp
++	kubeIPVSSupportEnabled    bool
++	ifaceConfigurationEnabled bool
+
+ 	// Our dependencies.
+ 	rawTable     iptablesTable","tiniest of nits: why would you abbreviate ""interface"" but not ""configuration"" ?"
+8383,"@@ -19,9 +19,6 @@ namespace Samples.HttpMessageHandler
+
+         private static string Url;
+
+-#if NETFRAMEWORK
+-        [LoaderOptimization(LoaderOptimization.MultiDomainHost)]
+-#endif
+         public static void Main(string[] args)
+         {
+             bool tracingDisabled = args.Any(arg => arg.Equals(""TracingDisabled"", StringComparison.OrdinalIgnoreCase));",Removing since all of the domain-neutral testing will be done in the new `Samples.MultiDomainHost.Runner` app
+8384,"@@ -50,6 +50,8 @@ def getpcmd(pid):
+                 spid, scmd = line.strip().split(' ', 1)
+                 if int(spid) == int(pid):
+                     return scmd
++    # Fallback instead of None, for e.g. Cygwin where -o is an ""unknown option"" for the ps command:
++    return '[PROCESS_WITH_PID={}]'.format(pid)
+
+
+ def get_info(pid_dir, my_pid=None):",is there a better way to detect this rather than just always assuming it's cygwin if everything else fails? i think you can check `if sys.platform == 'cygwin'`
+8385,"@@ -410,6 +410,10 @@ def _build_internal(package, path, dry_run, env):
+             try:
+                 _clone_git_repo(url, branch, tmpdir)
+                 build_from_path(package, tmpdir, dry_run=dry_run, env=env)
++            except yaml.scanner.ScannerError as ex:
++                message_parts = str(ex).split('\n')
++                message_parts.insert(0, ""Syntax error while reading {!r}"".format(path))
++                raise CommandException('\n  '.join(message_parts))
+             except Exception as exc:
+                 msg = ""attempting git clone raised exception: {exc}""
+                 raise CommandException(msg.format(exc=exc))",duplicate code - can you move into build_from_path() ?
+8386,"@@ -9,3 +9,6 @@ def toto(): #pylint: disable=C0102,R1711
+ # +1: [missing-function-docstring]
+ def test_enabled_by_id_msg(): #pylint: enable=C0111
+     pass
++
++def baz(): #pylint: disable=blacklisted-name
++    return 1",  very important test as we want to make sure the old name still work.
+8387,"@@ -1191,5 +1191,5 @@ This code is executed if a gain focus event is received by this object.
+ 		Fetches the number of descendants currently selected.
+ 		For performance, this method will only count up to the given maxCount number, and if there is one more above that, then sys.maxint is returned stating that many items are selected.
+ 		""""""
+-		return 0
++		return 1
+ ",I think returning 1 should some how be moved in to specific support for LibreOffice..
+8388,"@@ -85,6 +85,8 @@ byte *app_sysenter_instr_addr = NULL;
+ static bool sysenter_hook_failed = false;
+ #endif
+
++bool d_r_avx512_code_in_use = false;
++
+ /* static functions forward references */
+ static byte *
+ emit_ibl_routines(dcontext_t *dcontext, generated_code_t *code, byte *pc,",Should be inside `ifdef X86` I would think (or moved to ... I guess arch/x86/emit_utils.c)
+8389,"@@ -10,12 +10,14 @@ import (
+
+ // LocationCache cache the map of node, pod, configmap, secret
+ type LocationCache struct {
+-	//edgeNodes is a list of valid edge nodes
+-	edgeNodes []string
++	// EdgeNodes is a list of valid edge nodes
++	EdgeNodes []string
+ 	// configMapNode is a map, key is namespace/configMapName, value is nodeName
+ 	configMapNode sync.Map
+ 	// secretNode is a map, key is namespace/secretName, value is nodeName
+ 	secretNode sync.Map
++	// Services is an array of services
++	Services []v1.Service
+ }
+
+ // PodConfigMapsAndSecrets return configmaps and secrets used by pod","Using sync.Map(key: nodename; value: state) instead of this ""EdgeNodes"" string slice here would be much better. Reasons: 1. Using sync.Map makes the time complexity of function UpdateEdgeNode and IsEdgeNode O(1), while using string slice with for loop makes it O(n). 2. Later we could be checking node state whether it's ""ready"" or still ""not ready"" by directly comparing ""value"" of sync.Map and doing the node state updating."
+8390,"@@ -20,6 +20,10 @@ namespace AutoRest.Go
+
+     public const string ReadOnlyConstraint = ""ReadOnly"";
+
++    private static readonly Regex IsApiVersionPattern = new Regex(@""^api[^a-zA-Z0-9_]?version"", RegexOptions.IgnoreCase);
++
++    private static readonly Regex UnwrapAnchorTagsPattern = new Regex(""([^<>]*)<a\\s*.*\\shref\\s*=\\s*[\'\""]([^\'\""]*)[\'\""][^>]*>(.*)</a>"");
++
+     private static readonly Regex WordSplitPattern = new Regex(@""(\p{Lu}\p{Ll}+)"");
+
+     private static Dictionary<string, string> plural = new Dictionary<string, string>()","nit, does it make sense to get this variables outside the func where they are used?"
+8391,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-show-subscriptions.rb demonstrates how to list subscriptions to the Amazon Simple Notification Services (SNS) topic using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",to **an** Amazon... Simple Notification **Service** (singular)
+8392,"@@ -297,10 +297,13 @@ func TestOpenTopicFromURL(t *testing.T) {
+
+ 	ctx := context.Background()
+ 	for _, test := range tests {
+-		_, err := pubsub.OpenTopic(ctx, test.URL)
++		top, err := pubsub.OpenTopic(ctx, test.URL)
+ 		if (err != nil) != test.WantErr {
+ 			t.Errorf(""%s: got error %v, want error %v"", test.URL, err, test.WantErr)
+ 		}
++		if top != nil {
++			top.Shutdown(ctx)
++		}
+ 	}
+ }
+ ","Nit: is ""top"" a short name we use frequently? Seems a bit mysterious, and saves only 2 chars."
+8393,"@@ -52,7 +52,9 @@ import (
+ // R represents row type in executions table, valid values are:
+ // R = {Shard = 1, Execution = 2, Transfer = 3, Timer = 4, Replication = 5}
+ const (
+-	cassandraProtoVersion = 4
++	// ProtoVersion is the protocol version used to communicate with Cassandra cluster
++	ProtoVersion = 4
++
+ 	defaultSessionTimeout = 10 * time.Second
+ 	// Special Namespaces related constants
+ 	emptyNamespaceID = ""10000000-0000-f000-f000-000000000000""",This name is really confusing. May be just remove this const completely and hardcode `4` where it is used?
+8394,"@@ -558,12 +558,6 @@ module RSpec::Core
+       context ""with single pattern"" do
+         before { config.pattern = ""**/*_foo.rb"" }
+
+-        it ""loads files following pattern"" do
+-          file = File.expand_path(File.dirname(__FILE__) + ""/resources/a_foo.rb"")
+-          assign_files_or_directories_to_run file
+-          expect(config.files_to_run).to include(file)
+-        end
+-
+         it ""loads files in directories following pattern"" do
+           dir = File.expand_path(File.dirname(__FILE__) + ""/resources"")
+           assign_files_or_directories_to_run dir",Why did you remove this spec?
+8395,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?
+8396,"@@ -33,6 +33,12 @@ class Config(object):
+                               datetime.datetime.now().strftime('%Y%m%d%H%M%S'))
+         self.identifier = None
+         self.force_no_cloudshell = bool(kwargs.get('no_cloudshell'))
++        self.project_id = kwargs.get('project_id') or None
++        if kwargs.get('composite_root_resources'):
++            tmpcrr = kwargs.get('composite_root_resources')
++            self.composite_root_resources = tmpcrr.split(',')
++        else:
++            self.composite_root_resources = []
+         self.service_account_key_file = kwargs.get('service_account_key_file')
+         self.vpc_host_project_id = kwargs.get('vpc_host_project_id')
+         self.vpc_host_network = kwargs.get('vpc_host_network') or 'default'",".get will return None if there is no project_id key, so the or None part is redundant"
+8397,"@@ -22,11 +22,16 @@ namespace OpenTelemetry.Metrics
+ {
+     public struct MetricPoint
+     {
++        internal DateTimeOffset StartTime;
++        internal DateTimeOffset EndTime;
++
+         private readonly AggregationType aggType;
+         private readonly HistogramBuckets histogramBuckets;
+         private long longVal;
++        private long longValue;
+         private long lastLongSum;
+         private double doubleVal;
++        private double doubleValue;
+         private double lastDoubleSum;
+
+         internal MetricPoint(",Do they need to be `internal`?
+8398,"@@ -176,7 +176,7 @@ func (b *PinnedMap) Iter(f MapIter) error {
+ 	args := cmd[1:]
+
+ 	printCommand(prog, args...)
+-	output, err := exec.Command(prog, args...).CombinedOutput()
++	output, err := exec.Command(prog, args...).Output()
+ 	if err != nil {
+ 		return errors.Errorf(""failed to dump in map (%s): %s\n%s"", b.versionedFilename(), err, output)
+ 	}","Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`"
+8399,"@@ -175,8 +175,8 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
+   {""cuMemcpy"",                                             {""hipMemcpy_"",                                              """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy2D due to different signatures
+-  {""cuMemcpy2D"",                                           {""hipMemcpy2D_"",                                            """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+-  {""cuMemcpy2D_v2"",                                        {""hipMemcpy2D_"",                                            """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemcpy2D"",                                           {""hipMemcpyParam2D"",                                        """", CONV_MEMORY, API_DRIVER}},
++  {""cuMemcpy2D_v2"",                                        {""hipMemcpyParam2D"",                                        """", CONV_MEMORY, API_DRIVER}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy2DAsync due to different signatures
+   {""cuMemcpy2DAsync"",                                      {""hipMemcpy2DAsync_"",                                       """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},",Is there any official CUDA API called cuMemcpy2D_v2?
+8400,"@@ -0,0 +1,7 @@
++package azkaban.imagemgmt.utils;
++
++public interface ImageMgmtConstants {
++  public static final String IMAGE_TYPE = ""imageType"";
++  public static final String IMAGE_VERSION = ""imageVersion"";
++
++}",Can you please move this interface as class in common Constants file in az-core module?
+8401,"@@ -43,12 +43,15 @@ TEST(ProcessUtils, isPidAvailable) {
+     }
+     {
+         // pid file which contains pid of current process
+-        auto pidFile = ""/tmp/maybe-non-existing-dir/process_test.pid"";
++        auto pidFile = folly::stringPrintf(""/tmp/non-existing-dir-%d/process_test.pid"", ::getpid());
++        SCOPE_EXIT {
++            ::unlink(pidFile.c_str());
++            ::rmdir(fs::FileUtils::dirname(pidFile.c_str()).c_str());
++        };
+         auto status = ProcessUtils::makePidFile(pidFile);
+         ASSERT_TRUE(status.ok()) << status;
+         status = ProcessUtils::isPidAvailable(pidFile);
+         ASSERT_FALSE(status.ok());
+-        ::unlink(pidFile);
+     }
+     {
+         // pid file not exist",Why not TempDir?
+8402,"@@ -0,0 +1,16 @@
++using System;
++using MvvmCross.Binding.BindingContext;
++using MvvmCross.Core.ViewModels;
++using MvvmCross.Core.Views;
++
++namespace MvvmCross.Forms.Views
++{
++    public interface IMvxElement : IMvxView, IMvxBindingContextOwner
++    {
++    }
++
++    public interface IMvxElement<TViewModel>
++        : IMvxElement, IMvxView<TViewModel> where TViewModel : class, IMvxViewModel
++    {
++    }
++}","IMvxFormsView -> IMvxElement is a breaking change, isn't it?"
+8403,"@@ -33,6 +33,7 @@ import yaml
+ from molecule import config
+ from molecule import state
+ from molecule import utilities
++from molecule import ansible_galaxy_install
+ from molecule.provisioners import baseprovisioner
+ from molecule.provisioners import dockerprovisioner
+ from molecule.provisioners import openstackprovisioner",This should be imported alphabetically.
+8404,"@@ -11,7 +11,7 @@ use Shopsys\FrameworkBundle\Component\Grid\Ordering\OrderableEntityInterface;
+ use Shopsys\FrameworkBundle\Component\Money\Money;
+ use Shopsys\FrameworkBundle\Model\Localization\AbstractTranslatableEntity;
+ use Shopsys\FrameworkBundle\Model\Payment\Payment;
+-use Shopsys\FrameworkBundle\Model\Pricing\Currency\Currency;
++use Shopsys\FrameworkBundle\Model\Pricing\Price;
+ use Shopsys\FrameworkBundle\Model\Transport\Exception\TransportDomainNotFoundException;
+
+ /**",Please apply same changes as for Payment
+8405,"@@ -55,9 +55,13 @@ import { Cell, Grid, Row } from '../material-components';
+ import PageHeader from './PageHeader';
+ import Layout from './layout/Layout';
+ import { CORE_WIDGETS } from '../googlesitekit/widgets/datastore/constants';
++import { useHasScrolledEffect } from '../hooks/useHasScrolledEffect';
++import ScrollEffect from './ScrollEffect';
+ const { useSelect } = Data;
+
+ function DashboardEntityApp() {
++	useHasScrolledEffect();
++
+ 	const currentEntityURL = useSelect( ( select ) =>
+ 		select( CORE_SITE ).getCurrentEntityURL()
+ 	);","This should only be used in the `ScrollEffect` component, as you have in the `DashboardMainApp` below  "
+8406,"@@ -269,6 +269,8 @@ def api(require_login=True, schema=None, enabled=True,
+                               is_admin=user.is_admin,
+                               is_active=user.is_active)
+
++                g.token_str = token
++
+                 if not g.auth.is_active:
+                     raise ApiException(
+                         requests.codes.forbidden,","I'd call it `g.auth_token`, just to make it more clear"
+8407,"@@ -2,6 +2,9 @@ package protocol
+
+ import ""time""
+
++// DesiredReceiveBufferSize is the kernel UDP receive buffer size that we'd like to use.
++const DesiredReceiveBufferSize = (1 << 20) * 2 // 2 MB
++
+ // MaxPacketSizeIPv4 is the maximum packet size that we use for sending IPv4 packets.
+ const MaxPacketSizeIPv4 = 1252
+ ","Not sure if this is what we really need, we might need to adjust this constant after more extensive benchmarking."
+8408,"@@ -183,7 +183,10 @@ func RegisterRoutes(m *macaron.Macaron) {
+ 				m.Patch(""/hooks/:id:int"", bind(api.EditHookOption{}), repo.EditHook)
+ 				m.Get(""/raw/*"", middleware.RepoRef(), repo.GetRawFile)
+ 				m.Get(""/archive/*"", repo.GetArchive)
+-
++				m.Group(""/branches"", func() {
++					m.Get("""",repo.ListBranches)
++					m.Get(""/:id"",repo.GetBranch)
++				})
+ 				m.Group(""/keys"", func() {
+ 					m.Combo("""").Get(repo.ListDeployKeys).
+ 						Post(bind(api.CreateKeyOption{}), repo.CreateDeployKey)",Shouldn't we use `:branchname` here? Or just `:branch`?
+8409,"@@ -930,7 +930,7 @@ class RandUUID(RandField):
+ # Automatic timestamp
+
+
+-class AutoTime(VolatileValue):
++class AutoTime(RandNum):
+     def __init__(self, base=None):
+         if base is None:
+             self.diff = 0",`AutoTime` is a number but calling `int()` would make it crash. Tested through the docs
+8410,"@@ -333,7 +333,16 @@ namespace OpenTelemetry.Trace
+                         new EvictingQueue<KeyValuePair<string, object>>(this.tracerConfiguration.MaxNumberOfAttributes);
+                 }
+
+-                this.attributes.Add(new KeyValuePair<string, object>(key ?? string.Empty, sanitizedValue));
++                var attribute = this.attributes.FirstOrDefault(a => a.Key == (key ?? string.Empty));
++                var newAttribute = new KeyValuePair<string, object>(key ?? string.Empty, sanitizedValue);
++                if (attribute.Equals(default(KeyValuePair<string, object>)))
++                {
++                    this.attributes.Add(newAttribute);
++                }
++                else
++                {
++                    this.attributes.Replace(attribute, newAttribute);
++                }
+             }
+         }
+ ","@eddynaka Looks like the same block more or less 4 times, should we have a helper method? private void AddOrReplaceAttribute or something?"
+8411,"@@ -381,7 +381,8 @@ public class JettySolrRunner {
+         dispatchFilter = root.getServletHandler().newFilterHolder(Source.EMBEDDED);
+         dispatchFilter.setHeldClass(SolrDispatchFilter.class);
+         dispatchFilter.setInitParameter(""excludePatterns"", excludePatterns);
+-        root.addFilter(dispatchFilter, ""*"", EnumSet.of(DispatcherType.REQUEST));
++        // Map dispatchFilter in same path as in web.xml
++        root.addFilter(dispatchFilter, ""/*"", EnumSet.of(DispatcherType.REQUEST));
+
+         synchronized (JettySolrRunner.this) {
+           waitOnSolr = true;",Please do the same for the DebugFilter a few lines above.
+8412,"@@ -0,0 +1,2 @@
++export * from './act';
++export * from './setupRerender';","Minor nit: Just inline both functions here. No need to make a file per function (that's a popular approach for some projects though, just not for us :) )."
+8413,"@@ -28,6 +28,18 @@ namespace Datadog.Trace.Configuration
+         {
+         }
+
++        /// <summary>
++        /// Initializes a new instance of the <see cref=""TracerSettings""/> class with default values,
++        /// or using the default sources. Calling <c>new TracerSettings(true)</c> is equivalent to
++        /// calling <c>TracerSettings.FromDefaultSources()</c>
++        /// </summary>
++        /// <param name=""useDefaultSources"">If <c>true</c>, creates a <see cref=""TracerSettings""/> populated from
++        /// the default sources such as environment variables etc. If <c>false</c>, uses the default values.</param>
++        public TracerSettings(bool useDefaultSources)
++            : this(useDefaultSources ? CreateDefaultConfigurationSource() : null)
++        {
++        }
++
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""TracerSettings""/> class
+         /// using the specified <see cref=""IConfigurationSource""/> to initialize values.","There are several uses of the word ""default"" in here, perhaps it can be reworded slightly?"
+8414,"@@ -50,7 +50,7 @@ class MediaType extends AbstractType
+             'new_on_update' => $options['new_on_update'],
+         )));
+
+-        $builder->addEventListener(FormEvents::BIND, function (FormEvent $event) {
++        $builder->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) {
+             if ($event->getForm()->has('unlink') && $event->getForm()->get('unlink')->getData()) {
+                 $event->setData(null);
+             }",`function (` is correct. A space must be there. Please run `make cs` to have correct coding style.
+8415,"@@ -18,7 +18,7 @@ function pageNoDuplicateEvaluate(node, options, virtualNode) {
+   cache.set(key, true);
+
+   let elms = querySelectorAllFilter(axe._tree[0], options.selector, elm =>
+-    isVisible(elm.actualNode)
++    isVisible(elm.actualNode, true)
+   );
+
+   // Filter elements that, within certain contexts, don't map their role.","I think this is now going to fail the scenario where there is a `main` with aria-hidden=""true"". I don't think that should fail."
+8416,"@@ -83,7 +83,7 @@ func NewSublist() *Sublist {
+ // Insert adds a subscription into the sublist
+ func (s *Sublist) Insert(sub *subscription) error {
+ 	// copy the subject since we hold this and this might be part of a large byte slice.
+-	subject := string(append([]byte(nil), sub.subject...))
++	subject := string(sub.subject)
+ 	tsa := [32]string{}
+ 	tokens := tsa[:0]
+ 	start := 0","Is this specifically that if we capture the cast in another variable, even if it passes escape analysis, that the runtime will copy?"
+8417,"@@ -108,6 +108,10 @@ type EKSConfig struct {
+ 	// Fargate controls the configuration of the AWS IAM role for
+ 	// used by EKS managed machine pools.
+ 	Fargate *AWSIAMRoleSpec `json:""fargate,omitempty""`
++	// KMSAliasPrefix is prefix to use to restrict permission to KMS keys to only those that have an alias
++	// name that is prefixed by this.
++	// Defaults to cluster-api-provider-aws-*
++	KMSAliasPrefix string `json:""kmsAliasPrefix,omitempty""`
+ }
+
+ // EventBridgeConfig represents configuration for enabling experimental feature to consume",Should this be optional for existing configs to work?
+8418,"@@ -119,12 +119,14 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount uint64) er
+ 		}
+ 		return ErrUnknownBeneficary
+ 	}
+-	err = s.chequebook.Issue(ctx, beneficiary, big.NewInt(int64(amount)), func(signedCheque *chequebook.SignedCheque) error {
++	balance, err := s.chequebook.Issue(ctx, beneficiary, big.NewInt(int64(amount)), func(signedCheque *chequebook.SignedCheque) error {
+ 		return s.proto.EmitCheque(ctx, peer, signedCheque)
+ 	})
+ 	if err != nil {
+ 		return err
+ 	}
++
++	s.metrics.AvailableBalance.Set(float64(balance.Int64()))
+ 	s.metrics.TotalSent.Add(float64(amount))
+ 	return nil
+ }","note that `balance` does not necessarily fit into `int64`, especially with the new bzz token. so you might want to avoid the `int64` conversion step using `big.NewFloat(0).SetInt(balance).Float64()`."
+8419,"@@ -96,7 +96,12 @@ int main(int argc, const char *argv[]) {
+       flatbuffers::IDLOptions::kPhp,
+       ""Generate PHP files for tables/structs"",
+       flatbuffers::GeneralMakeRule },
+-    };
++   { flatbuffers::GenerateJsonSchema, ""-S"", ""--jsonschema"", ""JsonSchema"", true,
++      nullptr,
++      flatbuffers::IDLOptions::kJsonSchema,
++      ""Generate Json schema"",
++      flatbuffers::GeneralMakeRule },
++  };
+
+   flatbuffers::FlatCompiler::InitParams params;
+   params.generators = generators;",lets leave out the `-S` ?
+8420,"@@ -112,4 +112,9 @@ public class CommonRenderingUtil {
+   public static int toInt(String value) {
+     return Integer.valueOf(value);
+   }
++
++  /** Returns the lowercase version of the given text */
++  public static String lowercase(String value) {
++    return value.toLowerCase();
++  }
+ }",Is this method needed?
+8421,"@@ -127,6 +127,7 @@ void PoolingLayer<Dtype>::Reshape(const vector<Blob<Dtype>*>& bottom,
+ template <typename Dtype>
+ void PoolingLayer<Dtype>::Forward_cpu(const vector<Blob<Dtype>*>& bottom,
+       const vector<Blob<Dtype>*>& top) {
++  PoolingParameter pool_param = this->layer_param_.pooling_param();
+   const Dtype* bottom_data = bottom[0]->cpu_data();
+   Dtype* top_data = top[0]->mutable_cpu_data();
+   const int top_count = top[0]->count();","How about, instead of reading the param every time, just add a class member variable to hold the value of the flag, and just set it once during `LayerSetUp`?"
+8422,"@@ -99,7 +99,7 @@ func (e *ECS) Service(clusterName, serviceName string) (*Service, error) {
+ 	return nil, fmt.Errorf(""cannot find service %s"", serviceName)
+ }
+
+-// ServiceTasks calls ECS API and returns ECS tasks running by a service.
++// ServiceTasks calls ECS API and returns ECS tasks desired to be running by a service.
+ func (e *ECS) ServiceTasks(cluster, service string) ([]*Task, error) {
+ 	return e.listTasks(cluster, withService(service))
+ }",Does this mean it's only returning tasks associated with the primary deployment? or something else
+8423,"@@ -1101,6 +1101,11 @@ func TestRequestNoConnection(t *testing.T) {
+ 		t.Fatal(""expect error, but got none"")
+ 	}
+
++	t.Log(err)
++	awsError := err.(awserr.Error)
++	origError := awsError.OrigErr()
++	t.Logf(""Orig Error: %#v of type %T"", origError, origError)
++
+ 	if e, a := 10, r.RetryCount; e != a {
+ 		t.Errorf(""expect %v retry count, got %v"", e, a)
+ 	}","nit, would be good to include prefix for this log statement."
+8424,"@@ -57,4 +57,12 @@ describe('aria-required-attr', function () {
+ 		axe.commons.aria.requiredAttr = orig;
+ 	});
+
++	describe('options', function () {
++		it('should require provided attribute names', function () {
++			fixture.innerHTML = '<div role=""slider"" id=""target""></div>';
++			var target = fixture.children[0];
++			assert.isFalse(checks['aria-required-attr'].evaluate.call(checkContext, target, ['aria-valuemax', 'aria-bats']));
++			assert.deepEqual(checkContext._data, ['aria-valuenow', 'aria-valuemax', 'aria-valuemin', 'aria-bats']);
++		});
++	});
+ });","Same here, you should use a made up role. May I suggest `role=""McCheddarton""`? :)"
+8425,"@@ -372,7 +372,9 @@ class SparkWrite {
+       }
+
+       Expression conflictDetectionFilter = conflictDetectionFilter();
+-      overwriteFiles.validateNoConflictingAppends(conflictDetectionFilter);
++      overwriteFiles.conflictDetectionFilter(conflictDetectionFilter);
++      overwriteFiles.validateNoConflictingData();
++      overwriteFiles.validateNoConflictingDeletes();
+
+       String commitMsg = String.format(
+           ""overwrite of %d data files with %d new data files, scanSnapshotId: %d, conflictDetectionFilter: %s"",","@aokolnychyi, shouldn't this check whether the operation is a delete? If this is invoked by `DELETE FROM` then we don't need to validate conflicting deletes."
+8426,"@@ -11,8 +11,9 @@ import (
+ 	""reflect""
+ 	""sync""
+
+-	""github.com/keybase/kbfs/kbfscodec""
+ 	""golang.org/x/net/context""
++
++	""github.com/keybase/kbfs/kbfscodec""
+ )
+
+ const (","Any reason to split up this import block? I think most files have them together in one block, right?"
+8427,"@@ -109,6 +109,18 @@ namespace Datadog.Trace.AppSec
+
+         internal SecuritySettings Settings => _settings;
+
++        private static void TagSpan(Span span)
++        {
++            // we should only tag service entry span, the first span opened for a
++            // service. For WAF it's safe to assume we always have service entry spans
++            // we'll need to revisit this for RASP.
++            if (span != null)
++            {
++                span.SetMetric(Tags.AppSecEnabled, 1.0);
++                span.SetTag(Tags.RuntimeFamily, TracerConstants.Language);
++            }
++        }
++
+         /// <summary>
+         /// Frees resouces
+         /// </summary>",`Tags.AppSecEnabled` should probably move to `Metrics.AppSecEnabled` I guess?
+8428,"@@ -35,6 +35,9 @@ class atomic_file(AtomicLocalFile):
+     Also cleans up the temp file if close is not invoked
+     """"""
+
++    def __init__(self, path, mode):
++        super(AtomicLocalFile, self).__init__(path, mode)
++
+     def move_to_final_destination(self):
+         os.rename(self.tmp_path, self.path)
+ ","What happens if you remove this? Can't you still initialize this atomic_file class, since it's just AtomicLocalFile with an additional method (move_to_final_destination)?"
+8429,"@@ -34,7 +34,6 @@
+     <h2><div class='icon partners'></div><%= t "".partners_title"" %></h2>
+     <p><%= t 'layouts.partners_html',
+              :ucl => link_to(t('layouts.partners_ucl'), ""https://www.ucl.ac.uk""),
+-             :ic => link_to(t('layouts.partners_ic'), ""https://www.imperial.ac.uk/""),
+              :bytemark => link_to(t('layouts.partners_bytemark'), ""https://www.bytemark.co.uk""),
+              :partners => link_to(t('layouts.partners_partners'), ""https://hardware.openstreetmap.org/thanks/"") %>
+     </p>",As previously discussed in #1944 it's not safe to remove IC like this as it will break every language that still has a `%{ic}` marker in the translation.
+8430,"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+
++	rules = append(rules, Rule{
++		Match: Match().ProtocolNum(ProtoUDP).
++			DestPorts(uint16(r.Config.VXLANPort)).
++			VXLANVNI(uint32(r.Config.VXLANVNI)),
++		Action:  DropAction{},
++		Comment: ""Drop VXLAN encapped packets originating in pods"",
++	})
++	rules = append(rules, Rule{
++		Match:   Match().ProtocolNum(ProtoIPIP),
++		Action:  DropAction{},
++		Comment: ""Drop IPinIP encapped packets originating in pods"",
++	})
++
+ 	if len(policyNames) > 0 {
+ 		// Clear the ""pass"" mark.  If a policy sets that mark, we'll skip the rest of the policies and
+ 		// continue processing the profiles, if there are any.","I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?"
+8431,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename
+8432,"@@ -79,7 +79,7 @@ module Faker
+         digits = Faker::Number.leading_zero_number(9) until digits&.match(/(\d)((?!\1)\d)+/)
+         first_digit = brazilian_citizen_number_checksum_digit(digits)
+         second_digit = brazilian_citizen_number_checksum_digit(digits + first_digit)
+-        [digits, first_digit, second_digit].join
++        ""#{digits.gsub(/(\d{3})(?=\d)/, '\1.')}-#{first_digit}#{second_digit}""
+       end
+
+       private",What about adding an optional parameter that allows users to choose whether they want to use the format or not?
+8433,"@@ -35,8 +35,8 @@ func TestChainHead(t *testing.T) {
+
+ func TestChainLs(t *testing.T) {
+ 	tf.IntegrationTest(t)
+-	ctx := context.Background()
+ 	t.Skip(""DRAGONS: fake post for integration test"")
++	ctx := context.Background()
+
+ 	t.Run(""chain ls with json encoding returns the whole chain as json"", func(t *testing.T) {
+ 		builder := test.NewNodeBuilder(t)",Lint didn't like this context being before the skip
+8434,"@@ -0,0 +1,18 @@
++package tequilapi
++
++import ""net/http""
++
++type corsHandler struct {
++	originalHandler http.Handler
++}
++
++func (wrapper corsHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
++	resp.Header().Set(""Access-Control-Allow-Origin"", ""*"")
++	resp.Header().Set(""Access-Control-Allow-Methods"", ""POST, GET, OPTIONS, PUT, DELETE"")
++	wrapper.originalHandler.ServeHTTP(resp, req)
++}
++
++//ApplyCors wraps original handler by adding cors headers to response BEFORE original ServeHTTP method is called
++func ApplyCors(original http.Handler) http.Handler {
++	return corsHandler{original}
++}",so now basically anybody could drink my tequila? currently electron dev-env runs on `http://localhost:9080`
+8435,"@@ -259,7 +259,7 @@ bool Plugin::loadLib(ILXQtPanelPluginLibrary const * pluginLib)
+     mPlugin = pluginLib->instance(startupInfo);
+     if (!mPlugin)
+     {
+-        qWarning() << QString(""Can't load plugin \""%1\"". Plugin can't build ILXQtPanelPlugin."").arg(mPluginLoader->fileName());
++        qWarning() << QString(""Can't load plugin \""%1\"". Plugin can't build ILXQtPanelPlugin."").arg(mDesktopFile.id());
+         return false;
+     }
+ ","`mPluginLoader` is nullptr in static plugins, which causes segmentation faults"
+8436,"@@ -1,12 +1,8 @@
+ package org.phoenicis.javafx.views.mainwindow.ui;
+
+-import javafx.event.ActionEvent;
+-import javafx.event.EventHandler;
+-import org.phoenicis.javafx.views.common.ThemeManager;
+-
+ import javafx.beans.property.StringProperty;
+-import javafx.scene.control.TextField;
+ import javafx.scene.control.Button;
++import javafx.scene.control.TextField;
+ import javafx.scene.layout.AnchorPane;
+
+ import java.util.function.Consumer;",Better use `Optional<Consumer<String>> onSearch` here.
+8437,"@@ -16,7 +16,6 @@ BOOST_AUTO_TEST_CASE(rfc4648_test_vectors)
+ {
+     using namespace osrm::engine;
+
+-    BOOST_CHECK_EQUAL(encodeBase64(""""), """");
+     BOOST_CHECK_EQUAL(encodeBase64(""f""), ""Zg=="");
+     BOOST_CHECK_EQUAL(encodeBase64(""fo""), ""Zm8="");
+     BOOST_CHECK_EQUAL(encodeBase64(""foo""), ""Zm9v"");",this is asserted as invalid input
+8438,"@@ -10,12 +10,15 @@ import (
+ 	""time""
+
+ 	""github.com/thought-machine/please/src/core""
++	""github.com/thought-machine/please/src/parse""
+ )
+
+ // Print produces a Python call which would (hopefully) regenerate the same build rule if run.
+ // This is of course not ideal since they were almost certainly created as a java_library
+ // or some similar wrapper rule, but we've lost that information by now.
+-func Print(graph *core.BuildGraph, targets []core.BuildLabel, fields, labels []string) {
++func Print(state *core.BuildState, targets []core.BuildLabel, fields, labels []string) {
++	graph := state.Graph
++	order := parse.NewAspParser(state).BuildRuleArgOrder()
+ 	for _, target := range targets {
+ 		t := graph.TargetOrDie(target)
+ 		if len(labels) > 0 {",Why do you need to create a new parser? Can't you just use `state.Parser` to answer this question?
+8439,"@@ -155,5 +155,10 @@ namespace Nethermind.Core
+             HashNumberDiffAndTx,
+             Short
+         }
++
++        public virtual Block CreateBlockForProcessing(BlockHeader header) =>
++            new(header, Transactions, Ommers);
++
++        public virtual IEnumerable<Transaction> GetTransactions() => Transactions;
+     }
+ }","remove processing references from Nethermind.Core where possible, keep clean"
+8440,"@@ -0,0 +1,7 @@
++package com.fsck.k9.mail.internet;
++
++public class UnsupportedContentTransferEncodingException extends Exception {
++    public UnsupportedContentTransferEncodingException(String encoding) {
++        super(""Unsupported encoding: ""+encoding);
++    }
++}",Why not make this a subclass of `MessagingException` so we don't need to change all `throws` clause?
+8441,"@@ -22,6 +22,8 @@ import qrcode
+ import traceback
+ from hashlib import sha256
+ from decimal import Decimal
++import binascii
++from .drbg.hmac_drbg import DRBG
+
+ from PyQt5.QtPrintSupport import QPrinter
+ ","it should instead be `from .hmac_drbg import DRBG` also, please put it at the bottom of the imports (PEP 8 order), so near line 36"
+8442,"@@ -138,12 +138,13 @@ class SchemaUpdate implements UpdateSchema {
+       parentId = parentField.fieldId();
+       Preconditions.checkArgument(!deletes.contains(parentId),
+           ""Cannot add to a column that will be deleted: %s"", parent);
+-      Preconditions.checkArgument(schema.findField(parent + ""."" + name) == null,
+-          ""Cannot add column, name already exists: %s.%s"", parent, name);
++      Preconditions.checkArgument(schema.findField(parent + ""."" + name) == null ||
++                      deletes.contains(schema.findField(parent + ""."" + name).fieldId()),
++          ""Cannot add column, name already exists and is not being deleted: %s.%s"", parent, name);
+       fullName = schema.findColumnName(parentId) + ""."" + name;
+     } else {
+-      Preconditions.checkArgument(schema.findField(name) == null,
+-          ""Cannot add column, name already exists: %s"", name);
++      Preconditions.checkArgument(schema.findField(name) == null || deletes.contains(schema.findField(name).fieldId()),
++          ""Cannot add column, name already exists and is not being deleted: %s"", name);
+       fullName = name;
+     }
+ ",Nit: indentation is 2 indents (4 spaces) from the previous line.
+8443,"@@ -224,7 +224,7 @@ func (c *Config) RenderComposeYAML() (string, error) {
+ 		// path.Join is desired over filepath.Join here,
+ 		// as we always want a unix-style path for the mount.
+ 		""docroot"":     path.Join(""../"", c.Docroot),
+-		""plugin"":      c.Platform,
++		""plugin"":      ""ddev"",
+ 		""appType"":     c.AppType,
+ 		""mailhogport"": appports.GetPort(""mailhog""),
+ 		""dbaport"":     appports.GetPort(""dba""),",I don't understand why this is changing to a hard-coded string.
+8444,"@@ -24,7 +24,7 @@ import (
+ // Devnet is a FAST lib environment that is meant to be used
+ // when working with kittyhawk devnets run by the Filecoin development team.
+ type Devnet struct {
+-	network  string
++	network  DevnetConfig
+ 	location string
+
+ 	log logging.EventLogger",nit: perhaps calling this `config` would be more clear?
+8445,"@@ -110,7 +110,7 @@ de_DE.strings = {
+     '1': '+%{smart_count} Dateien hochladen',
+     '2': '+%{smart_count} Dateien hochladen',
+   },
+-  uploading: 'Uploading',
++  uploading: 'Lade hoch',
+   uploadingXFiles: {
+     '0': '%{smart_count} Datei wird hochgeladen',
+     '1': '%{smart_count} Dateien werden hochgeladen',",I would rather recommend using 'Wird hochgeladen' since the imperative form of 'Lade hoch' confuses me whether this is an action I need to do or whether it's an action that Uppy is currently doing. Just my two cents.
+8446,"@@ -30,6 +30,8 @@ const (
+ 	defaultDataDir  = "".""
+ 	defaultLogLevel = ""INFO""
+ 	defaultUmask    = 0077
++
++	minimumUmask = 0027
+ )
+
+ // RunConfig represents the available configurables for file",Hmm I would have expected this to go away? What role does it play now that we have a minimum?
+8447,"@@ -3,12 +3,6 @@
+ const MongoNetworkError = require('./core').MongoNetworkError;
+ const mongoErrorContextSymbol = require('./core').mongoErrorContextSymbol;
+
+-const GET_MORE_NON_RESUMABLE_CODES = new Set([
+-  136, // CappedPositionLost
+-  237, // CursorKilled
+-  11601 // Interrupted
+-]);
+-
+ // From spec@https://github.com/mongodb/specifications/blob/f93d78191f3db2898a59013a7ed5650352ef6da8/source/change-streams/change-streams.rst#resumable-error
+ const GET_MORE_RESUMABLE_CODES = new Set([
+   6, // HostUnreachable","if we are removing this, is it useful to have the `isGetMoreError` message below? If that's not required, can we also remove the `mongoErrorContextSymbol` outright?"
+8448,"@@ -59,11 +59,7 @@ public:
+     void helper_block_for_at_least_entries(
+             uint32_t amount)
+     {
+-        std::unique_lock<std::mutex> lck(*xml_mutex_);
+-        mock_consumer->cv().wait(lck, [this, amount]
+-                {
+-                    return mock_consumer->ConsumedEntriesSize_nts() >= amount;
+-                });
++        mock_consumer->wait_for_at_least_entries(amount);
+     }
+
+     eprosima::fastdds::dds::MockConsumer* mock_consumer;",I think this mutex is only used here. Remove it.
+8449,"@@ -181,7 +181,16 @@ public class IndexSearcher {
+   }
+
+   /** Runs searches for each segment separately, using the
+-   *  provided Executor. NOTE:
++   *  provided Executor. The passed in Executor will also be
++   *  used by LRUQueryCache (if enabled) to perform asynchronous
++   *  query caching.
++   *  If a task is rejected by the host Executor, the failed task
++   *  will then be executed on the caller thread. This is done to
++   *  ensure that a query succeeds, albeit with a higher latency.
++   *  If a user wishes to modify the said behaviour, they can either
++   *  handle the exception in the provided Executor, or override
++   *  the said method in a custom extension of IndexSearcher.
++   *  NOTE:
+    *  if you are using {@link NIOFSDirectory}, do not use
+    *  the shutdownNow method of ExecutorService as this uses
+    *  Thread.interrupt under-the-hood which can silently",it's unclear to me which method you are recommending overriding?
+8450,"@@ -511,7 +511,7 @@ class StringFormatChecker(BaseChecker):
+
+         check_args = False
+         # Consider ""{[0]} {[1]}"" as num_args.
+-        num_args += sum(1 for field in named_fields if field == """")
++        num_args += sum(1 for field in named_fields if not field)
+         if named_fields:
+             for field in named_fields:
+                 if field and field not in named_arguments:","This make me think that if the typing of a variable is inconsistent it could cause problem. For example here, if `field == 0`, the behavior is not exactly the same. A `0` and is implicitelty false. Well it works because summing 0 is neutral, but what if it was a multiplication ?"
+8451,"@@ -4,12 +4,13 @@ import (
+ 	""bytes""
+ 	""errors""
+ 	""fmt""
+-	""github.com/libopenstorage/openstorage/api""
+-	""github.com/libopenstorage/openstorage/api/client""
+-	""github.com/libopenstorage/openstorage/volume""
+ 	""io""
+ 	""io/ioutil""
+ 	""strconv""
++
++	""github.com/libopenstorage/openstorage/api""
++	""github.com/libopenstorage/openstorage/api/client""
++	""github.com/libopenstorage/openstorage/volume""
+ )
+
+ const (",Remove this file from the PR
+8452,"@@ -35,9 +35,9 @@ namespace Nethermind.Precompiles.Benchmark
+             // BenchmarkRunner.Run<Bn256MulBenchmark>();
+             // BenchmarkRunner.Run<Bn256PairingBenchmark>();
+             BenchmarkRunner.Run<ModExp2565Benchmark>();
+-            BenchmarkRunner.Run<ModExpBenchmark>();
++            // BenchmarkRunner.Run<ModExpBenchmark>();
+             Console.ReadLine();
+         }
+ #endif
+     }
+-}
++}",I cannot find the changes / results of the eip2565 benchmark
+8453,"@@ -151,7 +151,7 @@ const withData = (
+ 				'googlesitekit.moduleDataReset',
+ 				'googlesitekit.moduleDataResetHandler',
+ 				() => {
+-					this.setState( { data: false } );
++					this.setState( { data: false, zeroData: false } );
+ 				}
+ 			);
+ ","@tofumatt now that I see this in context, we're now resetting 2/3 of the keys in the `NewComponent` state - the other being `error`. It seems that `error` should probably also be reset - essentially resetting all of the component state when the date range changes. What do you think? cc: @felixarntz @adamsilverstein"
+8454,"@@ -32,7 +32,11 @@ namespace OpenTelemetry.Trace.Export
+
+         public override Task ShutdownAsync(CancellationToken cancellationToken)
+         {
++#if NET452
++            return Task.FromResult(0);
++#else
+             return Task.CompletedTask;
++#endif
+         }
+     }
+ }",This one and the ones below are for shutdowns but if it appears in some method called frequently during the lifetime of the process it should be cached in a static.
+8455,"@@ -5540,7 +5540,9 @@ describe('Model', function() {
+
+         return co(function*() {
+           const createdUser = yield User.create({ name: 'Hafez' });
+-          let threw = false;
++
++          let err;
++
+           try {
+             yield User.bulkWrite([{
+               updateOne: {","Better to just do `const err = yield User.bulkWrite(ops).then(() => null, err => err);` so you don't need to write out the whole `try/catch` block."
+8456,"@@ -453,7 +453,7 @@ func evmErrToErrStatusCode(evmErr error, g genesis.Blockchain, height uint64) (e
+ // intrinsicGas returns the intrinsic gas of an execution
+ func intrinsicGas(data []byte) (uint64, error) {
+ 	dataSize := uint64(len(data))
+-	if action.ExecutionDataGas == 0 || (math.MaxInt64-action.ExecutionBaseIntrinsicGas)/action.ExecutionDataGas < dataSize {
++	if (math.MaxInt64-action.ExecutionBaseIntrinsicGas)/action.ExecutionDataGas < dataSize {
+ 		return 0, action.ErrInsufficientFunds
+ 	}
+ ",`action.ExecutionDataGas = 100`
+8457,"@@ -124,6 +124,9 @@ class GalleryControllerTest extends TestCase
+         $this->assertSame([$media], $gController->getGalleryMediasAction(1));
+     }
+
++    /**
++     * @group legacy
++     */
+     public function testPostGalleryMediaGalleryhasmediaAction()
+     {
+         $media = $this->createMock(MediaInterface::class);",@supersmile2009 please review. Is it right to mark this as legacy? Are we testing the legacy path here? Are there tests for the non-legacy path?
+8458,"@@ -112,11 +112,14 @@ func (c *Controller) getSpcResource(key string) (*apis.StoragePoolClaim, error)
+ 		// The SPC resource may no longer exist, in which case we stop
+ 		// processing.
+ 		if errors.IsNotFound(err) {
++
+ 			runtime.HandleError(fmt.Errorf(""spcGot '%s' in work queue no longer exists"", key))
+-			return nil, err
+ 		}
+-
+-		return nil, err
++		// No need to return error to caller as we still want to fire the delete handler
++		// using the spc key(name)
++		// If error is returned the caller function will return without calling the spcEventHandler
++		// function that invokes business logic for pool deletion
++		return nil,nil
+ 	}
+ 	return spcGot, nil
+ }",getSpcResource should not be bothered about deletion. Can we have `separation of concerns` for this logic?
+8459,"@@ -4596,11 +4596,11 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         >>> merged.sort_values(by=['lkey', 'value_x', 'rkey', 'value_y'])
+           lkey  value_x rkey  value_y
+         0  bar        2  bar        6
+-        1  baz        3  baz        7
+-        2  foo        1  foo        5
+-        3  foo        1  foo        8
+-        4  foo        5  foo        5
+-        5  foo        5  foo        8
++        5  baz        3  baz        7
++        1  foo        1  foo        5
++        2  foo        1  foo        8
++        3  foo        5  foo        5
++        4  foo        5  foo        8
+
+         >>> left_kdf = ks.DataFrame({'A': [1, 2]})
+         >>> right_kdf = ks.DataFrame({'B': ['x', 'y']}, index=[1, 2])",This is actually matched with pandas's result since the output is sorted.
+8460,"@@ -37,12 +37,12 @@ var ConfigCmd = &cobra.Command{
+
+ // Config defines the config schema
+ type Config struct {
+-	Endpoint   string            `yaml:""endpoint""""`
+-	WalletList map[string]string `yaml:""walletList""`
++	Endpoint    string            `yaml:""endpoint""""`
++	AccountList map[string]string `yaml:""walletList""`
+ }
+
+ func init() {
+-	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl""
++	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl/default""
+ 	if err := os.MkdirAll(ConfigDir, 0700); err != nil {
+ 		fmt.Println(err.Error())
+ 		os.Exit(1)","struct field tag `yaml:""endpoint""""` not compatible with reflect.StructTag.Get: key:""value"" pairs not separated by spaces (from `govet`)"
+8461,"@@ -41,6 +41,8 @@ TopicImpl::TopicImpl(
+     , qos_(&qos == &TOPIC_QOS_DEFAULT ? participant_->get_default_topic_qos() : qos)
+     , listener_(listen)
+     , user_topic_(nullptr)
++    , handle_()
++    , num_refs_(0u)
+ {
+ }
+ ",This is not necessary. Topic inherits from DomainEntity which already has instance_handle_
+8462,"@@ -31,7 +31,7 @@ func TestICMPPortUnreachable(t *testing.T) {
+ 	_, ipv4, _, _, pktBytes, err := testPacketUDPDefault()
+ 	Expect(err).NotTo(HaveOccurred())
+
+-	runBpfUnitTest(t, ""icmp_port_unreachable.c"", func(bpfrun bpfProgRunFn) {
++	runBpfUnitTest(t, ""icmp_port_unreachable.c"", false, func(bpfrun bpfProgRunFn) {
+ 		res, err := bpfrun(pktBytes)
+ 		Expect(err).NotTo(HaveOccurred())
+ 		Expect(res.Retval).To(Equal(0))","Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes."
+8463,"@@ -68,8 +68,8 @@ func (c *cstorSnapshotCommand) validateOptions() error {
+ 	return nil
+ }
+
+-// getSnapshotObj returns a filled object of CASSnapshot
+-func (c *cstorSnapshotCommand) getSnapshotObj() *apis.CASSnapshot {
++// casSnapshot returns a filled object of CASSnapshot
++func (c *cstorSnapshotCommand) casSnapshot() *apis.CASSnapshot {
+ 	volName, _ := c.Data[""volname""].(string)
+ 	snapName, _ := c.Data[""snapname""].(string)
+ 	return &apis.CASSnapshot{",All the code that reference to this function must also be changed.
+8464,"@@ -49,4 +49,12 @@ public interface UserManager {
+   public Role getRole(String roleName);
+
+   public boolean validateProxyUser(String proxyUser, User realUser);
++
++  /**
++   * @param username e.g. user alias
++   * @param groupName e.g. name of hadoop headless group / LDAP group
++   * @return Returns true if the user belongs to a group. This is used when verifying user
++   * permission by checking its group membership
++   */
++  public boolean validateUserGroupMembership(String username, String groupName);
+ }",How is this new interface different from existing `validateProxyUser` method? If I understand correctly the `proxyUser` parameter is essentially a group and the method should verify if `realUser` belongs to it.
+8465,"@@ -38,6 +38,7 @@ using Nethermind.Store;
+ using Nethermind.Store.Bloom;
+ using Nethermind.TxPool;
+ using NUnit.Framework;
++using BlockTree = Nethermind.Blockchain.BlockTree;
+
+ namespace Nethermind.JsonRpc.Test.Modules.Trace
+ {",Do we have namespace conflicts?
+8466,"@@ -224,7 +224,7 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error {
+ 		if s.useFakeResponse {
+ 			service = api.NewFakeWebAPI()
+ 		} else {
+-			service = api.NewWebAPI(ds, sls, alss, cmds, cfg.ProjectMap(), encryptDecrypter, t.Logger)
++			service = api.NewWebAPI(ctx, ds, sls, alss, cmds, cfg.ProjectMap(), encryptDecrypter, cfg.Cache.TTLDuration(), t.Logger)
+ 		}
+ 		opts := []rpc.Option{
+ 			rpc.WithPort(s.webAPIPort),","We have several groups of caches so I think we should not use this shared configuration value for all of them. Instead of that, each cache group should have a separate configuration field, and the added `validation cache` should have its own field too. But this point, they can be fixed by `24h`."
+8467,"@@ -26,12 +26,12 @@ class Replicate implements AdapterInterface, MetadataSupporter
+     /**
+      * @var AdapterInterface
+      */
+-    protected $master;
++    protected $primary;
+
+     /**
+      * @var AdapterInterface
+      */
+-    protected $slave;
++    protected $secondary;
+
+     /**
+      * @var LoggerInterface","This is a BC break for extending classes, it can't be done on 3.x"
+8468,"@@ -950,10 +950,13 @@ class Key(object):
+             if isinstance(md5, bytes):
+                 md5 = md5.decode('utf-8')
+
+-            if self.etag != '""%s""' % md5:
+-                raise provider.storage_data_error(
+-                    'ETag from S3 did not match computed MD5. '
+-                    '%s vs. %s' % (self.etag, self.md5))
++            # If you use customer-provided encryption keys, the ETag value that Amazon S3 returns in the response will not be the MD5 of the object.
++            server_side_encryption_customer_algorithm = response.getheader('x-amz-server-side-encryption-customer-algorithm', None)
++            if server_side_encryption_customer_algorithm is None:
++                if self.etag != '""%s""' % md5:
++                    raise provider.storage_data_error(
++                        'ETag from S3 did not match computed MD5. '
++                        '%s vs. %s' % (self.etag, self.md5))
+
+             return True
+ ","Line length (PEP8, should be 80 chars max)"
+8469,"@@ -42,6 +42,8 @@ public abstract class MessageBuilder {
+     private final Context context;
+     private final MessageIdGenerator messageIdGenerator;
+     private final BoundaryGenerator boundaryGenerator;
++    private static final String highPriorityTag = ""X-Priority"";
++    private static final String xPriorityContent =""priority_high"";
+
+
+     private String subject;","this is duplicate now. I suggest moving it into `MimeHeader`, we already have a bunch of other headers there"
+8470,"@@ -551,11 +551,15 @@ func checkPassword(password string) (string, error) {
+ 	if !utf8.ValidString(password) {
+ 		return """", errors.New(""password contains invalid utf8 characters"")
+ 	}
+-	// Remove leading+trailing whitespace
+-	password = strings.TrimSpace(password)
++	// Check for leading/trailing whitespace
++	trimmedPassword := strings.TrimSpace(password)
++	// Warn user if password has leading+trailing whitespace
++	if len(password) != len(trimmedPassword) {
++		fmt.Fprintln(os.Stderr, ""Your password contains leading/trailing whitespace - in previous versions of rclone this was stripped"")
++	}
+ 	// Normalize to reduce weird variations.
+ 	password = norm.NFKC.String(password)
+-	if len(password) == 0 {
++	if len(password) == 0 || len(trimmedPassword) == 0 {
+ 		return """", errors.New(""no characters in password"")
+ 	}
+ 	return password, nil","Can you expand the warning slightly ""Your password contains leading/trailing whitespace - in previous versions of rclone this was stripped"" Just so users know they might have to type their password without a leading space."
+8471,"@@ -596,7 +596,7 @@ namespace pwiz.Skyline
+                             var message = TextUtil.SpaceSeparate(
+                                 Resources.SkylineWindow_FindIrtDatabase_The_database_file_specified_could_not_be_opened,
+                                 e.Message);
+-                            MessageBox.Show(message);
++                            MessageDlg.Show(this, message);
+                         }
+                     }
+                     else","I think ""this"" should be ""parent""."
+8472,"@@ -331,6 +331,8 @@ ostree_async_progress_set (OstreeAsyncProgress *self,
+   if (self->dead)
+     goto out;
+
++  changed = FALSE;
++
+   va_start (ap, self);
+
+   for (key = va_arg (ap, const char *), format_string = va_arg (ap, const char *);",Why not init this at variable decl time instead?
+8473,"@@ -25,6 +25,11 @@ const (
+ 	ProjectIDEnvKey = ""PROJECT_ID""
+ )
+
++// ProjectIDEnvConfig is a struct to parse Project id from env var
++type ProjectIDEnvConfig struct {
++	ProjectID string `envconfig:""PROJECT_ID""`
++}
++
+ // ProjectID returns the project ID for a particular resource.
+ func ProjectID(project string, client metadataClient.Client) (string, error) {
+ 	// If project is set, then return that one.",Do we still need this if we're doing everything through `envconfig`?
+8474,"@@ -22,6 +22,8 @@ type OptionsNetwork struct {
+ 	Testnet  bool
+ 	Localnet bool
+
++	IdentityCheck bool
++
+ 	DiscoveryAPIAddress string
+ 	BrokerAddress       string
+ ",I would like these options to have `experiment` prefix or suffix. Because we will be deleting them later
+8475,"@@ -88,7 +88,11 @@
+       <%= f.label :additional_info, 'Please include any additional information you feel we need to correctly execute the purchase' %>
+       <%= f.text_area :additional_info, class: 'form-control' %>
+     </div>
+-    <%= f.submit class: 'form-button' %>
++    <% unless ENV['DISABLE_SANDBOX_WARNING'] == 'true' %>
++      <%= f.submit value: 'Submit test request for approval', class: 'form-button' %>
++    <% else %>
++      <%= f.submit class: 'form-button' %>
++    <% end %>
+     <% if @model_instance.persisted? %>
+       <%= link_to 'Discard Changes', proposal_url(@model_instance.proposal) %>
+     <% end %>","Since we have the same logic in both forms, can we make a shared partial/helper for it?"
+8476,"@@ -69,10 +69,12 @@ func NewSalesman(opts ...Option) (*Salesman, error) {
+ 	if err := o.Validate(); err != nil {
+ 		return nil, err
+ 	}
++	marketAddr := blockchain.MarketAddr().Hex()
++	askPlansKey := marketAddr + ""/ask_plans""
+
+ 	s := &Salesman{
+ 		options:         o,
+-		askPlanStorage:  state.NewKeyedStorage(""ask_plans"", o.storage),
++		askPlanStorage:  state.NewKeyedStorage(askPlansKey, o.storage),
+ 		askPlanCGroups:  map[string]cgroups.CGroup{},
+ 		deals:           map[string]*sonm.Deal{},
+ 		orders:          map[string]*sonm.Order{},",Why to introduce this intermediate variable?
+8477,"@@ -43,6 +43,9 @@ class webhdfs(luigi.Config):
+                               description='Port for webhdfs')
+     user = luigi.Parameter(default='', description='Defaults to $USER envvar',
+                            config_path=dict(section='hdfs', name='user'))
++    client_type = luigi.Parameter(default='insecure',
++                                  description='Type of client to use. One of insecure, kerberos or token')
++    token = luigi.Parameter(default='', description='Hadoop delegation token, only used when client_type=""token""')
+
+
+ class WebHdfsClient(hdfs_abstract_client.HdfsFileSystem):",Maybe use ChoiceParameter?
+8478,"@@ -2,11 +2,12 @@ class ProposalsController < ApplicationController
+   include TokenAuth
+
+   before_filter :authenticate_user!, except: :approve
+-  before_filter ->{authorize self.proposal}, only: :show
++  before_filter ->{authorize self.proposal}, only: [:show, :cancel, :cancel_form]
+   before_filter :needs_token_on_get, only: :approve
+   before_filter :validate_access, only: :approve
+   helper_method :display_status
+   add_template_helper ProposalsHelper
++  rescue_from Pundit::NotAuthorizedError, with: :auth_errors
+
+   def show
+     @proposal = self.proposal.decorate","Not positive is this is needed, given the `TokenAuth` include"
+8479,"@@ -50,3 +50,13 @@ class ErrorDescriptionDict(TypedDict):
+ CheckerStats = Dict[
+     str, Union[int, ""Counter[str]"", List, Dict[str, Union[int, str, Dict[str, int]]]]
+ ]
++
++
++# Tuple with information about the location of a to-be-displayed message
++class MessageLocationTuple(NamedTuple):
++    abspath: str
++    path: str
++    module: str
++    obj: str
++    line: int
++    column: int",Why not use a docstring for it?
+8480,"@@ -3672,4 +3672,17 @@ public class BesuCommandTest extends CommandTestAbstract {
+     assertThat(commandErrorOutput.toString())
+         .contains(""Invalid value for option"", ""--Xws-timeout-seconds"", ""abc"", ""is not a long"");
+   }
++
++  @Test
++  public void assertThatDuplicatePortSpecifiedFails() {
++    parseCommand(""--p2p-port=9"", ""--rpc-http-port=10"", ""--rpc-ws-port=10"");
++    assertThat(commandErrorOutput.toString())
++        .contains(""Port number '10' has been specified multiple times."");
++  }
++
++  @Test
++  public void assertThatDuplicatePortZeroSucceeds() {
++    parseCommand(""--p2p-port=0"", ""--rpc-http-port=0"", ""--rpc-ws-port=0"");
++    assertThat(commandErrorOutput.toString()).isEmpty();
++  }
+ }","Two more tests - no ports specified and every possible port specified - p2pPort, graphQLHttpPort, rpcHttpPort, rpcWsPort, metricsPort, metricsPushPort, stratumPort"
+8481,"@@ -9,6 +9,7 @@
+ # Copyright (c) 2019-2020 Pierre Sassoulas <pierre.sassoulas@gmail.com>
+ # Copyright (c) 2019 Ashley Whetter <ashley@awhetter.co.uk>
+ # Copyright (c) 2019 Taewon D. Kim <kimt33@mcmaster.ca>
++# Copyright (c) 2020 Eli Fine <ejfine@gmail.com>
+
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ # For details: https://github.com/PyCQA/pylint/blob/master/COPYING","Don't worry about that next time, it's automated :)"
+8482,"@@ -172,6 +172,7 @@ def pytest_configure(config):
+     # pylint: disable=unused-variable
+     if config.webengine:
+         import PyQt5.QtWebEngineWidgets
++    # pylint: enable=unused-variable
+
+
+ @pytest.fixture(scope='session', autouse=True)","No need for this, as pylint already only turns things off for this function and it's needed for the entire function."
+8483,"@@ -103,10 +103,11 @@ const (
+ 	fluentTagDockerFirelensV2Format = ""%s.%s""
+
+ 	// Environment variables are needed for firelens
+-	fluentNetworkHost      = ""FLUENT_HOST""
+-	fluentNetworkPort      = ""FLUENT_PORT""
+-	FluentNetworkPortValue = ""24224""
+-	FluentAWSVPCHostValue  = ""127.0.0.1""
++	fluentNetworkHost        = ""FLUENT_HOST""
++	fluentNetworkPort        = ""FLUENT_PORT""
++	FluentNetworkPortValue   = ""24224""
++	AWSVPCHostValue          = ""127.0.0.1""
++	opentelemetryNetworkHost = ""OPEN_TELEMETRY_HOST""
+
+ 	defaultMonitorExecAgentsInterval = 15 * time.Minute
+ ",Are these values expected to change over time? Why not inject these values in ECS backend instead of agent doing it?
+8484,"@@ -31,6 +31,17 @@ func run(app *cli.Context, cfg *cmds.Server) error {
+ 		return err
+ 	}
+
++	nodeName := app.String(""node-name"")
++	if nodeName == """" {
++		h, err := os.Hostname()
++		if err != nil {
++			return err
++		}
++		nodeName = h
++	}
++
++	os.Setenv(""NODE_NAME"", nodeName)
++
+ 	var serverConfig server.Config
+ 	serverConfig.DisableAgent = true
+ 	serverConfig.ControlConfig.DataDir = dataDir","as best i can tell, you are setting this here in order to make it available in `(e *ETCD) Snapshot(ctx context.Context, config *config.Control) error`. It feels wrong to pass state like this through an env var. Could you instead add a `nodeName` property to the ETCD struct?"
+8485,"@@ -38,6 +38,8 @@ var skipTests = map[string]string{
+ 	""covariance_missing_column_2"": ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""drop_before_rename"":          ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""drop_referenced"":             ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
++	""drop_non_existent"":           ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
++	""keep_non_existent"":           ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""yield"":                       ""yield requires special test case (https://github.com/influxdata/flux/issues/535)"",
+ }
+ ","These seem to support the new test framework below, but the `.in.csv` files are still committed."
+8486,"@@ -227,8 +227,11 @@ namespace Nethermind.Blockchain.Receipts
+
+             for (int i = 0; i < txReceipts.Length; i++)
+             {
+-                var txHash = block.Transactions[i].Hash;
+-                _transactionDb.Set(txHash, block.Hash.Bytes);
++                if (txReceipts[i].Removed == false)
++                {
++                    var txHash = block.Transactions[i].Hash;
++                    _transactionDb.Set(txHash, block.Hash.Bytes);
++                }
+             }
+
+             if (blockNumber < MigratedBlockNumber)","!txReceipts[i].Removed and We can check it for first item outside of for loop, we don't expect mixed batches"
+8487,"@@ -40,7 +40,7 @@ const (
+ 	prodEnvFlag           = ""prod""
+ 	deployFlag            = ""deploy""
+ 	resourcesFlag         = ""resources""
+-	githubURLFlag         = ""github-url""
++	repoURLFlag           = ""url""
+ 	githubAccessTokenFlag = ""github-access-token""
+ 	gitBranchFlag         = ""git-branch""
+ 	envsFlag              = ""environments""","We can't unfortunately change any of our old flags :( it'd be a breaking change. Instead, we can keep both `githubURLFlag` and `repoURLFlag` and make the description of `githubURLFlagDescription` as ""(Deprecated) Use --url instead. GitHub respository URL for your service."" It would be even better if we can make `githubURLFlag` as hidden but keep in the command. This way old commands will still work with `--github-url` but it won't appear anymore in the help menu."
+8488,"@@ -61,7 +61,10 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction
+
+       return result
+     end
++
+     # Could not find plan
+-    raise ArgumentError, ""Function #{self.class.name}(): Unknown plan: '#{plan_name}'""
++    raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
++      Puppet::Pops::Issues.issue(:UNKNOWN_PLAN) { Bolt::Error.unknown_plan(plan_name) }
++    )
+   end
+ end",This provides file and line number if applicable.
+8489,"@@ -10,6 +10,7 @@ import math
+ from matplotlib import pyplot as plt
+ import os
+ import pandas as pd
++import numpy as np
+ import random
+ import re
+ import shutil",This is already imported. Please check the file.
+8490,"@@ -1676,6 +1676,11 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
+                 if (aSelection.isActionAvailable(action)) {
+                     aSelection.execute(action);
+                 }
++                if (GeckoSession.SelectionActionDelegate.ACTION_COPY.equals(action) &&
++                        aSelection.isActionAvailable(GeckoSession.SelectionActionDelegate.ACTION_UNSELECT)) {
++                    // Don't keep the text selected after it's copied.
++                    aSelection.execute(GeckoSession.SelectionActionDelegate.ACTION_UNSELECT);
++                }
+             }
+
+             @Override","One thing we can do in a follow up is use the shorthand calls, so You can just call `aSelection.unselect()` instead of calling the more verbose `execute()`. The fact that you have to check if the action is available sort of sucks though."
+8491,"@@ -519,10 +519,10 @@ func (st *ServerType) serversFromPairings(
+ 					for _, h := range hosts {
+ 						if h == defaultSNI {
+ 							hosts = append(hosts, """")
+-							cp.DefaultSNI = defaultSNI
+ 							break
+ 						}
+ 					}
++					cp.DefaultSNI = defaultSNI
+
+ 					// TODO: are matchers needed if every hostname of the resulting config is matched?
+ 					if len(hosts) > 0 {",I don't think adding this value to _every_ connection policy is needed or useful... why is this necessary?
+8492,"@@ -10,7 +10,11 @@ declare(strict_types=1);
+ namespace Ergonode\Product\Infrastructure\Provider\Strategy;
+
+ use Ergonode\Attribute\Domain\Entity\AbstractAttribute;
+-use Ergonode\Attribute\Infrastructure\Provider\AttributeValueConstraintStrategyInterface;
++use Ergonode\Attribute\Infrastructure\Provider\ContextAwareAttributeValueConstraintStrategyInterface;
++use Ergonode\EventSourcing\Infrastructure\Manager\EventStoreManagerInterface;
++use Ergonode\Product\Application\Validator\NotTheSameProduct;
++use Ergonode\Product\Domain\Entity\AbstractProduct;
++use Ergonode\SharedKernel\Domain\AggregateId;
+ use Symfony\Component\Validator\Constraint;
+ use Symfony\Component\Validator\Constraints\Collection;
+ use Ergonode\Product\Application\Validator\ProductExists;",adding this constrain for null AggreagateId is redundant
+8493,"@@ -103,7 +103,12 @@ func Dashboard(ctx *middleware.Context) {
+ 	feeds := make([]*models.Action, 0, len(actions))
+ 	for _, act := range actions {
+ 		if act.IsPrivate {
+-			if has, _ := models.HasAccess(ctx.User, &models.Repository{Id: act.RepoId, IsPrivate: true}, models.ACCESS_MODE_READ); !has {
++			repo := &models.Repository{Id: act.RepoId, IsPrivate: true}
++			// This prevents having to retrieve the repository for each action
++			if act.RepoUserName == ctx.User.LowerName {
++				repo.OwnerId = ctx.User.Id
++			}
++			if has, _ := models.HasAccess(ctx.User, repo, models.ACCESS_MODE_READ); !has {
+ 				continue
+ 			}
+ 		}",Why when current user is owner but still check access? Should we use `else if` here?
+8494,"@@ -4,12 +4,18 @@ import (
+ 	""errors""
+ 	""fmt""
+ 	""strings""
++	""time""
+
+ 	docker ""github.com/fsouza/go-dockerclient""
+
+ 	. ""github.com/weaveworks/weave/common""
+ )
+
++const (
++	InitialInterval = 1 * time.Second
++	MaxInterval     = 60 * time.Second
++)
++
+ // An observer for container events
+ type ContainerObserver interface {
+ 	ContainerStarted(ident string)",60 seems high. 10? 20?
+8495,"@@ -755,8 +755,8 @@ def server_init_start(args):
+
+     # Create the main database link from the arguments passed over the
+     # command line.
+-    default_product_path = os.path.join(args.config_directory,
+-                                        'Default.sqlite')
++    cfg_dir = os.path.abspath(args.config_directory)
++    default_product_path = os.path.join(cfg_dir, 'Default.sqlite')
+     create_default_product = 'sqlite' in args and \
+                              not os.path.exists(default_product_path)
+ ",I think this is not the best way to handle this problem. This way every relative path will be converted to absolute path. What if the user would like to move his config directory to a different directory?
+8496,"@@ -169,6 +169,10 @@ type NetworkSpec struct {
+ 	// Subnets configuration.
+ 	// +optional
+ 	Subnets Subnets `json:""subnets,omitempty""`
++
++	// ControlPlaneLoadBalancerScheme (defaults to Internet-facing)
++	// +optional
++	ControlPlaneLoadBalancerScheme ClassicELBScheme `json:""controlPlaneLoadBalancerScheme,omitempty""""`
+ }
+
+ // APIEndpoint represents a reachable Kubernetes API endpoint.",Let's make this a pointer given that's optional
+8497,"@@ -4,6 +4,7 @@
+  * Module dependencies.
+  */
+
++var CircularJSON = require('circular-json');
+ var Stream = require('stream').Stream;
+ var utils = require('./utils');
+ var helpers = require('./queryhelpers');",Why is CircularJSON imported here? It is never used in this file.
+8498,"@@ -80,7 +80,11 @@ namespace AutoRest.Swagger
+             {
+                 // Look for semantic errors and warnings in the document.
+                 var validator = new RecursiveObjectValidator(PropertyNameResolver.JsonName);
+-                foreach (var validationEx in validator.GetValidationExceptions(ServiceDefinition.FilePath, ServiceDefinition))
++                foreach (var validationEx in validator.GetValidationExceptions(ServiceDefinition.FilePath, ServiceDefinition, new ServiceDefinitionMetadata
++                {   // LEGACY MODE! set defaults for the metadata, the validator doesn't care from this codepath
++                    OpenApiDocumentType = ServiceDefinitionDocumentType.Default,
++                    MergeState = ServiceDefinitionMergeState.After
++                }))
+                 {
+                     Logger.Instance.Log(validationEx);
+                 }",Should be ARM
+8499,"@@ -86,10 +86,10 @@ func openBucket(dir string, _ *Options) (driver.Bucket, error) {
+ 	dir = filepath.Clean(dir)
+ 	info, err := os.Stat(dir)
+ 	if err != nil {
+-		return nil, fmt.Errorf(""open file bucket: %v"", err)
++		return nil, err
+ 	}
+ 	if !info.IsDir() {
+-		return nil, fmt.Errorf(""open file bucket: %s is not a directory"", dir)
++		return nil, fmt.Errorf(""%s is not a directory"", dir)
+ 	}
+ 	return &bucket{dir}, nil
+ }","I don't see how removing ""open file bucket"" helps your purpose."
+8500,"@@ -47,7 +47,7 @@ class SolrVersionStatus extends AbstractSolrStatus
+      *
+      * @var string
+      */
+-    const REQUIRED_SOLR_VERSION = '6.3.0';
++    const REQUIRED_SOLR_VERSION = '6.6.2';
+
+     /**
+      * Compiles a version check against each configured Solr server.",Solr dependency was downgraded?
+8501,"@@ -38,6 +38,7 @@ module C2
+     config.autoload_paths << Rails.root.join('app', 'mailers', 'concerns')
+     config.autoload_paths << Rails.root.join('app', 'policies', 'concerns')
+     config.autoload_paths << Rails.root.join('lib')
++    config.autoload_paths << Rails.root.join(""lib"", ""services"")
+
+     config.assets.precompile << 'communicarts_mailer.css'
+ ",or should we just autoload everything in `lib` ?
+8502,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.
+8503,"@@ -533,6 +533,7 @@ CREATE_VIOLATIONS_TABLE = """"""
+         `violation_type` enum('UNSPECIFIED',
+                               'ADDED','REMOVED',
+                               'BIGQUERY_VIOLATION',
++                              'BLACKLIST_VIOLATION',
+                               'BUCKET_VIOLATION',
+                               'CLOUD_SQL_VIOLATION',
+                               'FIREWALL_BLACKLIST_VIOLATION',",create_tables isn't used in 2.0 (should probably be deleted?)
+8504,"@@ -29,6 +29,7 @@ namespace OpenTelemetry.Exporter
+         internal Func<DateTimeOffset> GetUtcNowDateTimeOffset = () => DateTimeOffset.UtcNow;
+
+         private int scrapeResponseCacheDurationMilliseconds = 10 * 1000;
++        private IReadOnlyCollection<string> httpListenerPrefixes = new string[] { ""http://*:80/"" };
+
+ #if NETCOREAPP3_1_OR_GREATER
+         /// <summary>","Now I start to wonder, do we want to have `80` as the default or `9090` (or depending on whether we are exposing it via `PrometheusExporterMiddleware` vs. `PrometheusExporterHttpServer`)?"
+8505,"@@ -980,7 +980,9 @@ TEST(Parser, UserOperation) {
+     {
+         GQLParser parser;
+         std::string query = ""CREATE USER IF NOT EXISTS user1 WITH PASSWORD \""aaa\"" , ""
+-                            ""FIRSTNAME \""a\"", LASTNAME \""a\"", EMAIL \""a\"", PHONE \""111\"""";
++                            ""ACCOUNT LOCK, MAX_QUERIES_PER_HOUR 1, ""
++                            ""MAX_UPDATES_PER_HOUR 2, MAX_CONNECTIONS_PER_HOUR 3, ""
++                            ""MAX_USER_CONNECTIONS 4"";
+         auto result = parser.parse(query);
+         ASSERT_TRUE(result.ok()) << result.status();
+         auto& sentence = result.value();",try an illegal case. and the result is syntax error.
+8506,"@@ -23,6 +23,7 @@ void MemoryDataLayer<Dtype>::DataLayerSetUp(const vector<Blob<Dtype>*>& bottom,
+   added_label_.Reshape(batch_size_, 1, 1, 1);
+   data_ = NULL;
+   labels_ = NULL;
++  needs_reshape_ = false;
+   added_data_.cpu_data();
+   added_label_.cpu_data();
+ }",Initialize `needs_reshape_` with true and call `Reshape` method
+8507,"@@ -936,7 +936,10 @@ EOM
+       # @private
+       RANDOM_ORDERING = lambda do |list|
+         Kernel.srand RSpec.configuration.seed
+-        ordering = list.sort_by { Kernel.rand(list.size) }
++        orders = list.map {|x| !(x.respond_to?(:order)) || x.order.nil? || x.order == :random ? Kernel.rand(list.size) : 1}
++        zipped = list.zip(orders)
++
++        ordering = zipped.sort_by { |x| x[1] }.map { |x| x.first }
+         Kernel.srand # reset random generation
+         ordering
+       end","This is a _very_ complicated line. I'm not a fan of ternaries to begin with (although, I allow them in very simple situations), but this ternary has compound conditionals and would really need to be broken up. That said: if I'm reading this right, it sounds like this logic can make it where this lambda (which is called `RANDOM_ORDERING`) can make it not random and basically do the opposite of what it says. In general, it's good to avoid making methods or lambdas do the opposite of what they say."
+8508,"@@ -52,7 +52,8 @@ if (TYPO3_MODE == 'BE') {
+         '',
+         [
+             // An array holding the controller-action-combinations that are accessible
+-            'Administration' => 'index,setSite,setCore,noSiteAvailable'
++            'Administration' => 'index,setSite,setCore,noSiteAvailable',
++            'Backend\\Web\\Info\\ApacheSolrDocument' => 'index'
+         ],
+         [
+             'access' => 'admin',",We should remove this
+8509,"@@ -205,6 +205,8 @@ type Config struct {
+ 	sourceToRawConfig map[Source]map[string]string
+ 	rawValues         map[string]string
+ 	Err               error
++
++	IptablesNATOutgoingInterfaceFilter string `config:""string;""`
+ }
+
+ type ProtoPort struct {","We should validate this, I think. To add a validator: - change `string` to, say `iface-pattern` - add a new `case ""iface-pattern""` to the `switch` in the `loadParams()` function: - in that `case`, you should be able to use a RegexpPattern like the one for `iface-list`. However, you'll need a different regexp. I think this regexp should work: `^[a-zA-Z0-9:._+-]{1,15}$` i.e. 1-15 characters consisting of alphanumerics, colon, dot, underscore, hyphen and plus."
+8510,"@@ -59,6 +59,10 @@ func TestBalance(t *testing.T) {
+ 	require.Nil(err)
+ 	// Balance should == 30 now
+ 	require.Equal(0, state.Balance.Cmp(big.NewInt(30)))
++
++    // Sub 40 to the balance
++    err = state.SubBalance(big.NewInt(40))
++    require.Equal(err, ErrNotEnoughBalance)
+ }
+
+ func TestClone(t *testing.T) {",File is not `goimports`-ed with -local github.com/iotexproject/iotex-core (from `goimports`)
+8511,"@@ -53,6 +53,11 @@ public class FlinkOrcWriter implements OrcRowWriter<RowData> {
+     writer.writeRow(row, output);
+   }
+
++  @Override
++  public List<OrcValueWriter<?>> writers() {
++    return this.writer.writers();
++  }
++
+   @Override
+   public Stream<FieldMetrics<?>> metrics() {
+     return writer.metrics();",Nit: Here we don't need the extra `this` in iceberg because we usually use the `this` to distinguish whether it is a member variable or local variable when assigning value.
+8512,"@@ -71,7 +71,7 @@ public class AuthorizationLoggingTest {
+     engineRule.getManagementService().toggleTelemetry(true);
+
+     // then
+-    String message = ""ENGINE-03029 Required admin authenticated group or user."";
++    String message = ""ENGINE-16002 Exception while closing command context: ENGINE-03110 Required admin authenticated group or user or any of the following permissions:"";
+     List<ILoggingEvent> filteredLog = loggingRule.getFilteredLog(CONTEXT_LOGGER, message);
+
+     assertThat(filteredLog.size()).isEqualTo(1);","Why do we have that extra ""ENGINE-16002 Exception while closing command context:"" now? Is that done intentionally by us or where does that now come from?"
+8513,"@@ -4,10 +4,15 @@ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ import org.slf4j.Marker;
+
++import java.util.Collections;
+ import java.util.Map.Entry;
++import java.util.Set;
+ import java.util.SortedMap;
+ import java.util.concurrent.ScheduledExecutorService;
+ import java.util.concurrent.TimeUnit;
++import java.util.function.Supplier;
++
++import static com.codahale.metrics.MetricAttribute.*;
+
+ /**
+  * A reporter class for logging metrics values to a SLF4J {@link Logger} periodically, similar to","Please don't use star imports, in the codebase we tend to use direct imports."
+8514,"@@ -1,8 +1,10 @@
++import {CREDENTIALS} from ""../config.func"";
++
+ module.exports = function(server) {
+
+     test('who am I?', () => {
+       return server.whoami().then(function (username) {
+-        expect(username).toMatch('test');
++        expect(username).toMatch(CREDENTIALS.user);
+       });
+     });
+ ",Filename can be `config.functional`
+8515,"@@ -44,11 +44,19 @@ nano::block_processor::block_processor (nano::node & node_a, nano::write_databas
+ 			this->condition.notify_all ();
+ 		}
+ 	};
++	thread = std::thread ([this] () {
++		nano::thread_role::set (nano::thread_role::name::block_processing);
++		this->process_blocks ();
++	});
+ }
+
+ nano::block_processor::~block_processor ()
+ {
+ 	stop ();
++	if (thread.joinable ())
++	{
++		thread.join ();
++	}
+ }
+
+ void nano::block_processor::stop ()",Should the thread join be done in the stop function maybe? I am simply wondering and sharing my thoughts. This is my thinking: * The join used to be done in the stop function of node class and now it has moved in the destructor. * The class state_block_signature_verification joins its thread at the stop function too.
+8516,"@@ -22,3 +22,8 @@ var WalletCmd = &cobra.Command{
+ 		fmt.Println(""Print: "" + strings.Join(args, "" ""))
+ 	},
+ }
++
++func init() {
++	WalletCmd.AddCommand(walletCreateCmd)
++	WalletCmd.AddCommand(walletListCmd)
++}",don't use `init` function (from `gochecknoinits`)
+8517,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-enable-resource.rb demonstrates how to enable an Amazon Simple Notification Services (SNS) resource using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - MY_TOPIC_ARN",Simple Notification **Service** (singular)
+8518,"@@ -15,6 +15,7 @@ DEFINE_int64(int64_test, 10, ""Test flag for int64 type"");
+ DEFINE_bool(bool_test, false, ""Test flag for bool type"");
+ DEFINE_double(double_test, 3.14159, ""Test flag for double type"");
+ DEFINE_string(string_test, ""Hello World"", ""Test flag for string type"");
++DEFINE_uint32(crash_test, 1024, ""The flag could not be read"");
+
+ namespace nebula {
+ ","You are fixing the crash problem, and you have fixed it, so it won't crash anymore. So `crash_test` is not a proper name."
+8519,"@@ -68,8 +68,12 @@ public class SampleNamer extends NameFormatterDelegator {
+     return localVarName(Name.lowerCamel(""request""));
+   }
+
+-  /** Returns the variable name of the request body. */
+   public String getRequestBodyVarName() {
++    return getRequestBodyVarName("""");
++  }
++
++  /** Returns the variable name of the request body. */
++  public String getRequestBodyVarName(String requestBodyTypeName) {
+     return localVarName(Name.lowerCamel(""requestBody""));
+   }
+ ","If this default doesn't depend on the argument, shouldn't it be delegated as the default for the no-arg version instead?"
+8520,"@@ -84,7 +84,7 @@ def read_api_key_safe():
+
+
+ def _get_config_file(path):
+-    get_or_create_file(path)
++    get_or_create_file(path, permissions=0o600)
+     return path
+
+ ","I did not use the new save_config_file method in here, because I am not sure whether this whole logic is still necessary? There is an TODO about it there as well."
+8521,"@@ -22,7 +22,7 @@ define(['dom', 'appRouter', 'connectionManager'], function (dom, appRouter, conn
+                     return void appRouter.showItem(items[0]);
+                 }
+
+-                var url = 'itemdetails.html?id=' + itemId + '&serverId=' + serverId;
++                var url = 'details?id=' + itemId + '&serverId=' + serverId;
+                 Dashboard.navigate(url);
+             });
+             e.stopPropagation();",Why was this changed?
+8522,"@@ -98,6 +98,8 @@ class IoUBalancedNegSampler(RandomSampler):
+                 floor_set = set()
+                 iou_sampling_set = set(
+                     np.where(max_overlaps > self.floor_thr)[0])
++                # for sampling interval calculation
++                self.floor_thr == 0
+
+             floor_neg_inds = list(floor_set & neg_set)
+             iou_sampling_neg_inds = list(iou_sampling_set & neg_set)","I think you meant, self.floor_thr = 0"
+8523,"@@ -14,13 +14,12 @@ import (
+
+ 	""github.com/99designs/gqlgen/graphql""
+ 	""github.com/99designs/gqlgen/graphql/introspection""
++	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
++	""github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model""
+ 	gqlparser ""github.com/vektah/gqlparser/v2""
+ 	""github.com/vektah/gqlparser/v2/ast""
+-	v1 ""k8s.io/api/core/v1""
++	""k8s.io/api/core/v1""
+ 	v11 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+-
+-	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+-	""github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model""
+ )
+
+ // region    ************************** generated!.gotpl **************************",Can you revert these changes?
+8524,"@@ -18,10 +18,13 @@
+
+ 'use strict';
+
+-import React, {
++import React from 'react';
++
++import {
+     Component,
+     Navigator,
+-    StatusBarIOS,
++    Platform,
++    StatusBar,
+     Text,
+     TouchableOpacity,
+     View,",Do we need to change this?
+8525,"@@ -104,14 +104,12 @@ func setKernelMemory(path string, kernelMemoryLimit uint64) error {
+ }
+
+ func setMemoryAndSwap(path string, cgroup *configs.Cgroup) error {
+-	ulimited := -1
+-
+-	// If the memory update is set to uint64(-1) we should also
+-	// set swap to uint64(-1), it means unlimited memory.
+-	if cgroup.Resources.Memory == uint64(ulimited) {
++	// If the memory update is set to MemoryUnlimited we should also
++	// set swap to MemoryUnlimited.
++	if cgroup.Resources.Memory == configs.MemoryUnlimited {
+ 		// Only set swap if it's enbled in kernel
+ 		if cgroups.PathExists(filepath.Join(path, cgroupMemorySwapLimit)) {
+-			cgroup.Resources.MemorySwap = uint64(ulimited)
++			cgroup.Resources.MemorySwap = uint64(configs.MemoryUnlimited)
+ 		}
+ 	}
+ ","With this commit, `MemoryUnlimited` is defined as a `unit64`, so I think you can drop the redundant cast from this line (and the later lines which also have `uint64(configs.MemoryUnlimited)`."
+8526,"@@ -7,6 +7,8 @@ function DashboardContentTitle (props) {
+ }
+
+ function PanelTopBar (props) {
++  const notOverFileLimit = props.maxNumberOfFiles !== props.totalFileCount
++
+   return (
+     <div class=""uppy-DashboardContent-bar"">
+       <button class=""uppy-DashboardContent-back""",`props.totalFileCount < props.maxNumberOfFiles` makes the intent a bit more clear I think. And a check to see if maxNumberOfFiles even exists?
+8527,"@@ -12,7 +12,8 @@ import (
+
+ // Flags
+ var (
+-	epochNum uint64
++	epochNum  uint64
++	nextEpoch bool
+ )
+
+ // NodeCmd represents the node command",`epochNum` is a global variable (from `gochecknoglobals`)
+8528,"@@ -1083,6 +1083,8 @@ angular.module('ui.grid')
+       } else {
+         // otherwise, manually search the oldRows to see if we can find this row
+         newRow = self.getRow(newEntity, oldRows);
++      } else {
++          newRow.entity = newEntity;
+       }
+
+       // if we didn't find the row, it must be new, so create it",This needs to be fixed before we can accept the PR
+8529,"@@ -14,6 +14,11 @@ constexpr double bootstrap_minimum_termination_time_sec = 30.0;
+ constexpr unsigned bootstrap_max_new_connections = 10;
+ constexpr unsigned bulk_push_cost_limit = 200;
+
++size_t constexpr nano::frontier_req::size;
++size_t constexpr nano::bulk_pull_blocks::size;
++size_t constexpr nano::bulk_pull_account::size;
++size_t constexpr nano::frontier_req_client::size_frontier;
++
+ nano::socket::socket (std::shared_ptr<nano::node> node_a) :
+ socket_m (node_a->io_ctx),
+ cutoff (std::numeric_limits<uint64_t>::max ()),",Are these forward declarations needed if we `#include <node/common.hpp>` which includes the definition ?
+8530,"@@ -76,7 +76,7 @@ func (m *Message) Bytes() []byte {
+ }
+
+ func (m *Message) String() string {
+-	return fmt.Sprintf(""MESSAGE: connectid %v MessageType %s"", m.ConnectID, m.MessageType)
++	return fmt.Sprintf(""MESSAGE: ConnectID %v MessageType %s"", m.ConnectID, m.MessageType)
+ }
+
+ func ReadMessageFromTunnel(r io.Reader) (*Message, error) {",can you use either `connectID` or `ConnectID` i would preffer `connectID`
+8531,"@@ -112,6 +112,11 @@ class Shopware6ChannelFormModel
+      */
+     public array $customField = [];
+
++    /**
++     * @var array|null
++     */
++    public ?array $crossSelling = [];
++
+     public function __construct(Shopware6Channel $channel = null)
+     {
+         if ($channel) {",It seems like it cannot be null?
+8532,"@@ -19,6 +19,7 @@ package azkaban.executor;
+ public class ExecutionReference {
+   private final int execId;
+   private Executor executor;
++  //Todo jamiesjc: deprecate updateTime in ExecutionReference class gradually.
+   private long updateTime;
+   private long nextCheckTime = -1;
+   private int numErrors = 0;",should we consider add deprecated annotation here?
+8533,"@@ -27,8 +27,8 @@ import (
+ 	""golang.org/x/net/context""
+ )
+
+-type createUserFn func(t testing.TB, ith int, config *libkbfs.ConfigLocal,
+-	opTimeout time.Duration) *fsUser
++type createUserFn func(t testing.TB, ith int, name libkb.NormalizedUsername,
++	config *libkbfs.ConfigLocal, opTimeout time.Duration) *fsUser
+
+ type fsEngine struct {
+ 	name       string",Why can't the implementor get the username from the config?
+8534,"@@ -87,7 +87,7 @@ func NewParams(raCtx protocol.RunActionsCtx, execution *action.Execution, stateD
+ 		BlockNumber: new(big.Int).SetUint64(raCtx.BlockHeight),
+ 		Time:        new(big.Int).SetInt64(raCtx.BlockTimeStamp),
+ 		Difficulty:  new(big.Int).SetUint64(uint64(50)),
+-		GasLimit:    raCtx.ActionGasLimit,
++		GasLimit:    execution.GasLimit(),
+ 		GasPrice:    execution.GasPrice(),
+ 	}
+ ",@CoderZhi Please confirm if this change makes sense
+8535,"@@ -127,6 +127,7 @@ public enum JsonRpcError {
+   PMT_FAILED_INTRINSIC_GAS_EXCEEDS_LIMIT(
+       -50100,
+       ""Private Marker Transaction failed due to intrinsic gas exeeding the limit. Gas limit used from the Private Transaction.""),
++  PRIVATE_SUBSCRIPTION_MULTI_TENANCY_ERROR(-50100, ""foo.""),
+
+   CANT_CONNECT_TO_LOCAL_PEER(-32100, ""Cannot add local node as peer.""),
+ ",Do you think you can come up with a better message? :-) It looks like this is not used anywhere. So maybe just delete the line.
+8536,"@@ -1065,11 +1065,7 @@ public interface Traversable<T> extends Foldable<T>, Value<T> {
+     @Override
+     default T reduceLeft(BiFunction<? super T, ? super T, ? extends T> op) {
+         Objects.requireNonNull(op, ""op is null"");
+-        if (isEmpty()) {
+-            throw new NoSuchElementException(""reduceLeft on Nil"");
+-        } else {
+-            return tail().foldLeft(head(), op);
+-        }
++        return iterator().reduceLeft(op);
+     }
+
+     /**",`tail()` is an expensive operation for certain collections
+8537,"@@ -86,7 +86,8 @@ var rubyMappings = {
+   'http_infrastructure':['../../../TestServer/swagger/httpInfrastructure.json','HttpInfrastructureModule'],
+   'required_optional':['../../../TestServer/swagger/required-optional.json','RequiredOptionalModule'],
+   'report':['../../../TestServer/swagger/report.json','ReportModule'],
+-  'model_flattening':['../../../TestServer/swagger/model-flattening.json', 'ModelFlatteningModule'],
++  'model_flattening':['../../../TestServer/swagger/model-flattening.json', 'ModelFlatteningModule'],
++  'parameter_grouping':['../../../TestServer/swagger/azure-parameter-grouping.json', 'ParameterGroupingModule'],
+ };
+
+ var defaultAzureMappings = {",do we need to add this one in this PR?
+8538,"@@ -223,7 +223,6 @@ namespace Nethermind.State.Test.Runner
+
+         public void ReportGasUpdateForVmTrace(long refund, long gasAvailable)
+         {
+-            throw new NotImplementedException();
+         }
+
+         public void ReportRefundForVmTrace(long refund, long gasAvailable)",where is a test for it?
+8539,"@@ -46,7 +46,7 @@ class Page extends CmsCompoundObject
+      */
+     public $rules = [
+         'title' => 'required',
+-        'url'   => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i']
++        'url' => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i']
+     ];
+
+     /**",Why has this spacing been adjusted?
+8540,"@@ -90,10 +90,15 @@ class PipelineBuilder(object):
+                 raise api_errors.ApiInitializationError(e)
+
+             api_version = self.api_map.get(api_name).get('version')
+-            if api_version is None:
+-                api = api_class()
+-            else:
+-                api = api_class(version=api_version)
++            try:
++                if api_version is None:
++                    api = api_class()
++                else:
++                    api = api_class(version=api_version)
++            except api_errors.ApiExecutionError as e:
++                LOGGER.error('Failed to execute API %s, v=%s',
++                             api_class_name, api_version)
++                raise api_errors.ApiInitializationError(e)
+
+             self.initialized_api_map[api_name] = api
+ ","Sorry to do this, since you're touching this file can you resolve the pylint doc messages above?"
+8541,"@@ -81,7 +81,7 @@ class BigQueryWriter(object):
+             }
+             bq_data.append({
+                 'json': row,
+-                'insertId': ""%s-%s"" % (listen['user_name'], listen['listened_at'])
++                'insertId': ""%s-%s-%s"" % (listen['user_name'], listen['listened_at'], listen['recording_msid'])
+             })
+
+         body = { 'rows' : bq_data }","@alastair, because the `insertId` for two listens with different metadata and same ts was the same, only one of them would get written into BQ. A question is what would be the ideal way to write tests for stuff like this, so that this doesn't break again?"
+8542,"@@ -1883,7 +1883,7 @@ UDS_RDBI.dataIdentifiers[0x4080] = ""AirbagLock_NEU""
+ UDS_RDBI.dataIdentifiers[0x4140] = ""BodyComConfig""
+ UDS_RDBI.dataIdentifiers[0x4ab4] = ""Betriebsstundenzaehler""
+ UDS_RDBI.dataIdentifiers[0x5fc2] = ""WDBI_DME_ABGLEICH_PROG_REQ""
+-UDS_RDBI.dataIdentifiers[0xd114] = ""Gesamtweg-Streckenzähler Offset""
++UDS_RDBI.dataIdentifiers[0xd114] = ""Gesamtweg-Streckenzaehler Offset""
+ UDS_RDBI.dataIdentifiers[0xd387] = ""STATUS_DIEBSTAHLSCHUTZ""
+ UDS_RDBI.dataIdentifiers[0xdb9c] = ""InitStatusEngineAngle""
+ UDS_RDBI.dataIdentifiers[0xEFE9] = ""WakeupRegistry""",Wondering where this breaks btw (although pretty understandable)
+8543,"@@ -64,6 +64,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy {
+       Dataset<Row> scanDF = cloneSession.read().format(""iceberg"")
+           .option(SparkReadOptions.FILE_SCAN_TASK_SET_ID, groupID)
+           .option(SparkReadOptions.SPLIT_SIZE, splitSize(inputFileSize(filesToRewrite)))
++          .option(SparkReadOptions.LOOKBACK, 10)
+           .option(SparkReadOptions.FILE_OPEN_COST, ""0"")
+           .load(table.name());
+ ",is this needed? 10 is already the default
+8544,"@@ -35,9 +35,13 @@ class TextPlot(ElementPlot):
+             data = dict(x=[element.x], y=[element.y])
+         self._categorize_data(data, ('x', 'y'), element.dimensions())
+         data['text'] = [element.text]
+-        style['text_align'] = element.halign
++        if 'text_align' not in style:
++            style['text_align'] = element.halign
+         baseline = 'middle' if element.valign == 'center' else element.valign
+-        style['text_baseline'] = baseline
++        if 'text_baseline' not in style:
++            style['text_baseline'] = baseline
++        if 'text_font_size' not in style:
++            style['text_font_size'] = '%dPt' % element.fontsize
+         if 'color' in style:
+             style['text_color'] = style.pop('color')
+         return (data, mapping, style)",One day we can try to allow the user to specify font sizes in something other than points. For now this is fine though...
+8545,"@@ -29,7 +29,13 @@ namespace rtps {
+
+
+ WriterProxyData::WriterProxyData()
++#if HAVE_SECURITY
++    : security_attributes_(0)
++    , plugin_security_attributes_(0)
++    , m_userDefinedId(0)
++#else
+     : m_userDefinedId(0)
++#endif
+     , m_typeMaxSerialized(0)
+     , m_isAlive(true)
+     , m_topicKind(NO_KEY)",duplicated in both block of preprocessor condition. Can you join in one?
+8546,"@@ -50,9 +50,10 @@ function getXPathArray(node, path) {
+ 		var element = {};
+ 		element.str = node.nodeName.toLowerCase();
+ 		// add the id and the count so we can construct robust versions of the xpath
+-		if(node.getAttribute && node.getAttribute('id') &&
+-			node.ownerDocument.querySelectorAll('#' + axe.utils.escapeSelector(node.id)).length === 1) {
+-
++		if(
++			node.getAttribute && node.getAttribute('id') &&
++			node.ownerDocument.querySelectorAll('#' + axe.utils.escapeSelector(node.getAttribute('id'))).length === 1
++		) {
+ 			element.id = node.getAttribute('id');
+ 		}
+ 		if(count > 1) {",Can we put the first part of the expression inline with the `if(` for consistency's sake?
+8547,"@@ -26,9 +26,15 @@ import ""github.com/yarpc/yarpc-go/transport""
+ type CallReqMeta interface {
+ 	Procedure(string) CallReqMeta
+ 	Headers(Headers) CallReqMeta
++	ShardKey(string) CallReqMeta
++	RoutingKey(string) CallReqMeta
++	RoutingDelegate(string) CallReqMeta
+
+ 	GetProcedure() string
+ 	GetHeaders() Headers
++	GetShardKey() string
++	GetRoutingKey() string
++	GetRoutingDelegate() string
+ }
+
+ // ReqMeta contains information about an incoming YARPC request.",Do servers have no need of accessing this information?
+8548,"@@ -51,7 +51,7 @@
+     // @vue/component
+     var commonFormattersMixin = {
+         methods: {
+-            formatTimeAgo: countlyCommon.formatTimeAgo,
++            formatTimeAgo: countlyCommon.formatTimeAgoText,
+             formatNumber: countlyCommon.formatNumber,
+             getShortNumber: countlyCommon.getShortNumber
+         }","It feels like this will break some stuff, but let it break. We need ""text"" version anyway."
+8549,"@@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc &leftTable,
+     ItemExpr *leftExpr  = leftTable.getValueId(i).getItemExpr();
+     ItemExpr *rightExpr = rightTable.getValueId(i).getItemExpr();
+     BiRelat *compare = new (bindWA->wHeap())
+-      BiRelat(ITM_EQUAL, leftExpr, rightExpr);
++      BiRelat(ITM_EQUAL, leftExpr, rightExpr, TRUE);
+     if (predicate)
+       predicate = new (bindWA->wHeap()) BiLogic(ITM_AND, predicate, compare);
+     else","Here are two things I wonder: First, would it make sense to replace the TRUE here with ""leftExpr->getValueId().getType().supportsSQLnull() && rightExpr->getValueId().getType().supportsSQLnull()"". I'm not sure we have optimizations elsewhere that set the ""special nulls"" semantics back to FALSE if one of the operands it not nullable. Second, I wonder whether we have bugs elsewhere in the code that may not check for the ""special nulls"" semantics. For example, hash and merge joins probably can't use such predicates as equi-join predicates - one of the reasons for the optimization above. When I look at method ItemExpr::isAnEquiJoinPredicate() in core/sql/optimizer/OptItemExpr.cpp, I don't see a check for that. You have an example with a NULL value that is working, so hopefully this is not an issue, but I'm not sure how and why it works."
+8550,"@@ -267,7 +267,8 @@ T *LookupTableByName(const SymbolTable<T> &table, const std::string &name,
+   TD(StringConstant, 257, ""string constant"") \
+   TD(IntegerConstant, 258, ""integer constant"") \
+   TD(FloatConstant, 259, ""float constant"") \
+-  TD(Identifier, 260, ""identifier"")
++  TD(NumericConstant, 260, ""nan, inf or function name (signed)"") \
++  TD(Identifier, 261, ""identifier"")
+ #ifdef __GNUC__
+ __extension__  // Stop GCC complaining about trailing comma with -Wpendantic.
+ #endif",This will cause someone writing a schema field like `inf:string` to get a pretty confusing error? If they intended to use `inf` as short for `information` or whatever :) Might it be better to keep it as `Identifier` and explicitly recognize the few identifiers we care about only when parsing values (not while parsing field names)?
+8551,"@@ -46,7 +46,7 @@ export function generateRandomHexString(length: number = 8) {
+
+ export function signPayload(payload: JWTPayload, secret: string, options: JWTSignOptions) {
+   return jwt.sign(payload, secret, {
+-    notBefore: '1000', // Make sure the time will not rollback :)
++    notBefore: '1', // Make sure the time will not rollback :)
+     ...options,
+   });
+ }",Mmm .... this affect #168 I'll need to research the collateral damage
+8552,"@@ -268,7 +268,7 @@ func checkSrvRecord(dnsBootstrap string) {
+
+ func doDeleteDNS(network string, noPrompt bool, excludePattern string) bool {
+
+-	if network == """" || network == ""testnet"" || network == ""devnet"" || network == ""mainnet"" {
++	if network == """" || network == ""testnet"" || network == ""devnet"" || network == ""mainnet"" || network == ""beta"" {
+ 		fmt.Fprintf(os.Stderr, ""Deletion of network '%s' using this tool is not allowed\n"", network)
+ 		return false
+ 	}",nit: refactor into a const map lookup.
+8553,"@@ -26,7 +26,7 @@ namespace MvvmCross.Forms.Droid.Views
+         {
+             BindingContext = new MvxAndroidBindingContext(this, this);
+             this.AddEventListeners();
+-            _resourceAssembly = Assembly.GetCallingAssembly();
++            _resourceAssembly = this.GetType().Assembly;
+         }
+
+         public object DataContext",I don't think this is going to work. We need to get the actual assembly of the app project. @johnnywebb thoughts?
+8554,"@@ -306,7 +306,7 @@ def get_kbr_keys(kb_name, searchkey="""", searchvalue="""", searchtype='s'):
+                                              searchvalue, searchtype)
+
+ def get_kbr_values(kb_name, searchkey="""", searchvalue="""", searchtype='s',
+-                   use_memoise=False):
++                   use_memoize=False):
+     """"""
+     Return a tuple of values from key-value mapping kb.
+ ",@MSusik be careful about changing existing API. I think in this case you shouldn't rename the argument.
+8555,"@@ -176,8 +176,8 @@ int produce_message(struct flb_time *tm, msgpack_object *map,
+                 /* Add extracted topic on the fly to topiclist */
+                 if (ctx->dynamic_topic) {
+                     /* Only if default topic is set and this topicname is not set for this message */
+-                    if (strncmp(topic->name, flb_kafka_topic_default(ctx)->name, val.via.str.size) == 0 &&
+-                        (strncmp(topic->name, val.via.str.ptr, val.via.str.size) != 0) ) {
++                    if (strcmp(topic->name, flb_kafka_topic_default(ctx)->name) == 0 &&
++                        (strcmp(topic->name, val.via.str.ptr) != 0) ) {
+                         if (strstr(val.via.str.ptr, "","")) {
+                             /* Don't allow commas in kafkatopic name */
+                             flb_warn(""',' not allowed in dynamic_kafka topic names"");",This is bad. It is not a NULL-terminated string here.
+8556,"@@ -48,9 +48,10 @@ class UserIpReader
+     protected $server;
+
+     /**
+-     * Should we respect the X-Forwarded-For header?
++     * Configuration specifying allowed HTTP headers containing IPs (false for none).
++     * See [Proxy] allow_forwarded_ips setting in config.ini for more details.
+      *
+-     * @var bool
++     * @var string|bool
+      */
+     protected $allowForwardedIps;
+ ",This probably should be @param string|false.
+8557,"@@ -195,7 +195,7 @@ public class SmartSqlTest extends SmartStoreTestCase {
+ 	 */
+ 	public void testSmartQueryReturningOneRowWithTwoIntegers() throws JSONException {
+ 		loadData();
+-		JSONArray result = store.query(QuerySpec.buildSmartQuerySpec(""select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr, {employees} as e where e.{employees:lastName} = 'Thompson'"", 1), 0);
++		JSONArray result = store.query(QuerySpec.buildSmartQuerySpec(""select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr, {employees} as e where e.{employees:lastName} = 'Thompson' and mgr.{employees:employeeId} = e.{employees:managerId}"", 1), 0);
+ 		assertSameJSONArray(""Wrong result"", new JSONArray(""[[200000,120000]]""), result);
+ 	}
+ 	",Unrelated test fix. Already in cordova34 branch.
+8558,"@@ -87,10 +87,6 @@ func (sc *stakingCommand) CreatePostSystemActions(ctx context.Context, sr protoc
+ }
+
+ func (sc *stakingCommand) Handle(ctx context.Context, act action.Action, sm protocol.StateManager) (*action.Receipt, error) {
+-	// no height here,  v1 v2 has the same validate method, so directly use common one
+-	if err := validate(ctx, sm, sc, act); err != nil {
+-		return nil, err
+-	}
+ 	if sc.useV2(ctx, sm) {
+ 		return sc.stakingV2.Handle(ctx, act, sm)
+ 	}",validate() will be called by either V1 or V2
+8559,"@@ -100,6 +100,13 @@ class CppGenerator : public BaseGenerator {
+
+     assert(!cur_name_space_);
+
++    code_ += ""#if defined(_MSC_VER)"";
++    code_ += ""#define NOEXCEPT"";
++    code_ += ""#else"";
++    code_ += ""#define NOEXCEPT noexcept"";
++    code_ += ""#endif"";
++    code_ += """";
++
+     // Generate forward declarations for all structs/tables, since they may
+     // have circular references.
+     for (auto it = parser_.structs_.vec.begin();","rather than generate code for this every time, stick it in `flatbuffers.h` (and call it `FLATBUFFERS_NOEXCEPT` to avoid clashes)."
+8560,"@@ -14,7 +14,9 @@ import (
+ // GetBlockByNumber see https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getblockbynumber
+ // see internal/ethapi.PublicBlockChainAPI.GetBlockByNumber
+ func (api *APIImpl) GetBlockByNumber(ctx context.Context, number rpc.BlockNumber, fullTx bool) (map[string]interface{}, error) {
+-	tx, err := api.dbReader.Begin(ctx)
++	// TODO the next line used to be ""tx, err := api.dbReader.Begin(ctx)"" When it changed, there was concern that it would have
++	// negative impact on performance. Revisit performance of using this type of database transaction
++	tx, err := api.db.Begin(ctx, nil, false)
+ 	if err != nil {
+ 		return nil, err
+ 	}","@AskAlexSharov @tjayrush , I'm still feeling uncomfortable with this change: - because it works by accident. For example in next lines `tx` object used as: `ReadBlockByNumber(tx)`. If you go inside `ReadBlockByNumber` you can find `!errors.Is(err, ethdb.ErrKeyNotFound)` - but ethdb.Tx doesn't return this error - and it satisfy `DatabaseReader` by accident - (I faced this problem last week - when passed Tx to place which expected Db - and I promised to change tx API - rename Get to GetOne or even remove the method). - we can merge this PR if it doesn't break things and solve problem of localDb use of RPCDaemon. But I will make PR now which will allow open Read tx by TxDb/ObjectDb - and will ask you to use it. Then will take a look how hard to change LmdbTx to not satisfy rawdb.DatabaseReader interface."
+8561,"@@ -159,3 +159,4 @@ def createTemporalAnomaly(recordParams, spatialParams=_SP_PARAMS,
+   temporalPoolerRegion.setParameter(""anomalyMode"", True)
+
+   return network
++  ",I think this means the file doesn't have a newline character at the end.
+8562,"@@ -469,6 +469,15 @@ fpga_result fpgaPerfCounterGet(fpga_token token, fpga_perf_counter *fpga_perf)
+
+ 	memset(fpga_perf, 0, sizeof(fpga_perf_counter));
+
++	//check if its being run as root or not
++	uid_t uid = getuid();
++	if (uid != 0) {
++		fpga_perf->previlege = false;
++		return FPGA_OK;
++	} else {
++		fpga_perf->previlege = true;
++	}
++
+ 	ret = get_fpga_sbdf(token, &segment, &bus, &device, &function);
+ 	if (ret != FPGA_OK) {
+ 		OPAE_ERR(""Failed to get sbdf"");","Hi Ramya, rather than checking here in the perf counter library, we should add the privilege check in the host_exerciser app."
+8563,"@@ -20,7 +20,9 @@ class TrackedObject:
+ 	""""""
+
+ 	def __del__(self):
+-		notifyObjectDeletion(self)
++		# notifyObjectDeletion could be None if Python is shutting down.
++		if notifyObjectDeletion:
++			notifyObjectDeletion(self)
+
+
+ _collectionThreadID = 0",Could you elaborate on this some more? Has this behavior changed with Python 3.8?
+8564,"@@ -89,7 +89,10 @@ const logReqMsg = `DEBUG: Request %s/%s Details:
+
+ func logRequest(r *request.Request) {
+ 	logBody := r.Config.LogLevel.Matches(aws.LogDebugWithHTTPBody)
+-	dumpedBody, _ := httputil.DumpRequestOut(r.HTTPRequest, logBody)
++	dumpedBody, err := httputil.DumpRequestOut(r.HTTPRequest, logBody)
++	if err != nil {
++		r.Config.Logger.Log(fmt.Sprintf(""Error dumping request: %s"", err))
++	}
+
+ 	if logBody {
+ 		// Reset the request body because dumpRequest will re-wrap the r.HTTPRequest's","Do we want to continue on logging the `dumpedBody`, if an error was thrown? It is probably an empty string. This would make the log after this one pretty much useless."
+8565,"@@ -1,6 +1,7 @@
+ <fieldset class=""annotation_fields"" id=""<%= unique_dom_id(f.object, ""fields"") %>"">
+   <div class=""form-group col-md-10"">
+-    <%= f.label(:type, f.object.type.humanize, class: ""control-label"") %>
++    <% lbl = f.object.type.humanize.downcase == 'example answer' ? _('Example answer') : _('Guidance') %>
++    <%= f.label(:type, lbl, class: ""control-label"") %>
+     <div data-toggle=""tooltip"" title=""<%= tooltip_for_annotation_text(f.object) %>"">
+       <em class=""sr-only""><%= tooltip_for_annotation_text(f.object) %></em>
+       <%= f.text_area(:text, class: 'question',",the text here is derived from the object type and not getting properly handled by get text
+8566,"@@ -27,10 +27,13 @@ const (
+ var (
+ 	// runtimeMode tells which mode antctl is running against.
+ 	runtimeMode string
++	inPod       bool
+ )
+
+ func init() {
+-	if strings.HasPrefix(os.Getenv(""POD_NAME""), ""antrea-agent"") {
++	podName, found := os.LookupEnv(""POD_NAME"")
++	inPod = found && (strings.HasPrefix(podName, ""antrea-agent"") || strings.HasPrefix(podName, ""antrea-controller""))
++	if strings.HasPrefix(podName, ""antrea-agent"") {
+ 		runtimeMode = ModeAgent
+ 	} else {
+ 		runtimeMode = ModeController",This will make other pods that run antctl will also connect its localhost? Maybe only do it when it's in antrea-agent and antrea-controller
+8567,"@@ -168,9 +168,6 @@ define([""jQuery"", ""globalize"", ""scripts/taskbutton"", ""dom"", ""libraryMenu"", ""layo
+         }), menuItems.push({
+             name: ""Xml TV"",
+             id: ""xmltv""
+-        }), menuItems.push({
+-            name: globalize.translate(""ButtonOther""),
+-            id: ""other""
+         }), require([""actionsheet""], function(actionsheet) {
+             actionsheet.show({
+                 items: menuItems,","The corresponding action for this key needs to be removed as well, along with any unused translations."
+8568,"@@ -48,15 +48,15 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
+
+             var requestProxy = request.DuckCast<ISendMessageBatchRequest>();
+
+-            var scope = AwsSqsCommon.CreateScope(Tracer.Instance, Operation, out AwsSqsTags tags);
++            var scope = AwsSqsCommon.CreateScope(Tracer.InternalInstance, Operation, out AwsSqsTags tags);
+             tags.QueueUrl = requestProxy.QueueUrl;
+
+-            if (scope?.Span?.Context != null && requestProxy.Entries.Count > 0)
++            if (scope?.Span.Context is SpanContext spanContext && requestProxy.Entries.Count > 0)
+             {
+                 for (int i = 0; i < requestProxy.Entries.Count; i++)
+                 {
+                     var entry = requestProxy.Entries[i].DuckCast<IContainsMessageAttributes>();
+-                    ContextPropagation.InjectHeadersIntoMessage<TSendMessageBatchRequest>(entry, scope?.Span?.Context);
++                    ContextPropagation.InjectHeadersIntoMessage<TSendMessageBatchRequest>(entry, spanContext);
+                 }
+             }
+ ","Can't Span cannot be null anymore? I assume it was a useless check as there are discrepencies within integrations, but as you explicitly removed this one, I was wondering"
+8569,"@@ -210,7 +210,7 @@ namespace Nethermind.JsonRpc.Modules.Trace
+
+             Block block = blockSearch.Object;
+
+-            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace | ParityTraceTypes.Rewards);
++            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace);
+             return ResultWrapper<ParityTxTraceFromStore[]>.Success(ParityTxTraceFromStore.FromTxTrace(txTrace));
+         }
+ ","hmmm, ok, this is interesting -> Lukasz definitely uses rewards traces"
+8570,"@@ -78,6 +78,9 @@ public class TableProperties {
+   public static final String SPLIT_OPEN_FILE_COST = ""read.split.open-file-cost"";
+   public static final long SPLIT_OPEN_FILE_COST_DEFAULT = 4 * 1024 * 1024; // 4MB
+
++  public static final String SPLIT_BY_PARTITION = ""read.split.by-partition"";
++  public static final boolean SPLIT_BY_PARTITION_DEFAULT = false;
++
+   public static final String PARQUET_VECTORIZATION_ENABLED = ""read.parquet.vectorization.enabled"";
+   public static final boolean PARQUET_VECTORIZATION_ENABLED_DEFAULT = false;
+ ",Why do we need this flag? can this be detected if the table is bucketed/partitioned and enabled/disabled automatically? Is this for backwards compatibility?
+8571,"@@ -188,7 +188,7 @@ bool is_name_type(const char* name)
+ {
+   if(*name == '$')
+     name++;
+-
++
+   if(*name == '_')
+     name++;
+ ",can you revert changes to this file.
+8572,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package soc provides the single-owner chunk implemenation
++// and validator.
+ package soc
+
+ import (",suggestion to add: An soc is a chunks whose address is derived of (...)
+8573,"@@ -110,6 +110,8 @@ export const API_ERROR = {
+   DEPRECATED_BASIC_HEADER: 'basic authentication is deprecated, please use JWT instead',
+   BAD_FORMAT_USER_GROUP: 'user groups is different than an array',
+   RESOURCE_UNAVAILABLE: 'resource unavailable',
++  USERNAME_PASSWORD_REQUIRED: 'username and password is required',
++  USERNAME_ALREADY_REGISTERED: 'username is already registered',
+ };
+
+ export const APP_ERROR = {","It doesn't make sense. if we are going to have the profile page where the user can change the password and he / she is already logged in ... I do not need to register a new username. only: new password..confirm new password..something similar...and ""USERNAME_ALREADY_REGISTERED"" only if I have a register page..are we going to have? We need to talk about it."
+8574,"@@ -747,14 +747,14 @@ namespace Nethermind.State
+             _needsStateRootUpdate = false;
+         }
+
+-        public void CommitTree()
++        public void CommitTree(long blockNumber)
+         {
+             if (_needsStateRootUpdate)
+             {
+                 RecalculateStateRoot();
+             }
+
+-            _tree.Commit();
++            _tree.Commit(blockNumber);
+         }
+     }
+ }",not a great fan of this change - maybe worth splitting into CommitTree() and CloseBlock(long blockNumber)?
+8575,"@@ -65,7 +65,9 @@ namespace Microsoft.AspNetCore.Connections
+
+         public CancellationToken ConnectionClosed { get; set; }
+
+-        public virtual void Abort()
++        public void Abort() => Abort(abortReason: null);
++
++        public virtual void Abort(ConnectionAbortedException abortReason)
+         {
+             ThreadPool.QueueUserWorkItem(cts => ((CancellationTokenSource)cts).Cancel(), _connectionClosedTokenSource);
+         }","Ugh, if we're going to make a breaking change, I'd like this to be moved to ConnectionContext."
+8576,"@@ -1286,6 +1286,12 @@ func NewFs(path string) (Fs, error) {
+ 	if err != nil {
+ 		return nil, err
+ 	}
++	// TODO: Fix import for rc
++	// f, err := fsInfo.NewFs(configName, fsPath, config)
++	// if err != nil && f.reload != nil {
++	// 	rc.AddOptionReload(f.name, &f.opt, f.reload)
++	// }
++	// return f, err
+ 	return fsInfo.NewFs(configName, fsPath, config)
+ }
+ ","I was planning to add it as a common option, but there is a cyclic import for the rc & fs libs. Thoughts on avoiding it or should I remove this for now?"
+8577,"@@ -65,6 +65,10 @@ namespace SynchronizeVersions
+                 ""src/Datadog.Trace/Datadog.Trace.csproj"",
+                 NugetVersionReplace);
+
++            SynchronizeVersion(
++                ""/deploy/Nuget/Datadog.Trace.nuspec"",
++                NugetVersionReplace);
++
+             Console.WriteLine($""Completed synchronizing versions to {VersionString()}"");
+         }
+ ","I think this entry can be removed now, right?"
+8578,"@@ -230,6 +230,18 @@ class Key(object):
+         else:
+             self.encrypted = None
+
++    def handle_storage_class_header(self, resp):
++        provider = self.bucket.connection.provider
++        if provider.storage_class_header:
++            self._storage_class = resp.getheader(
++                provider.storage_class_header, None)
++            if (self._storage_class is None and
++                provider.get_provider_name() == 'aws'):
++                # S3 docs for HEAD object requests say S3 will return this
++                # header for all objects except Standard storage class objects.
++                self._storage_class = 'STANDARD'
++
++
+     def handle_version_headers(self, resp, force=False):
+         provider = self.bucket.connection.provider
+         # If the Key object already has a version_id attribute value, it","I don't understand why you want to populate the storage class in this case, if the S3 docs say they won't populate the header in this case?"
+8579,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities"
+8580,"@@ -14,8 +14,11 @@ import (
+ //
+ // The request will not be signed, and will not use your AWS credentials.
+ //
+-// A ""NotFound"" error code will be returned if the bucket does not exist in
+-// the AWS partition the regionHint belongs to.
++// A ""NotFound"" error code will be returned if the bucket does not exist in the
++// AWS partition the regionHint belongs to. If the regionHint parameter is an
++// empty string GetBucketRegion will fallback to the ConfigProvider's region
++// config. If no region is specified, hint or ConfigProvider, an error will
++// be returned.
+ //
+ // For example to get the region of a bucket which exists in ""eu-central-1""
+ // you could provide a region hint of ""us-west-2"".",Should the last sentence be `If no region was found` rather than `specified`?
+8581,"@@ -217,9 +217,16 @@ public class CoxPlugin extends Plugin
+ 			{
+ 				for (Player player : client.getPlayers())
+ 				{
+-					if (player.getName().equals(tpMatcher.group(1)))
++					final String rawPlayerName = player.getName();
++
++					if (rawPlayerName != null)
+ 					{
+-						victims.add(new Victim(player, Victim.Type.TELEPORT));
++						final String fixedPlayerName = Text.sanitize(rawPlayerName);
++
++						if (fixedPlayerName.equals(tpMatcher.group(1)))
++						{
++							victims.add(new Victim(player, Victim.Type.TELEPORT));
++						}
+ 					}
+ 				}
+ 			}","Text.sanitize just removes images from names, for instance, the hardcore ironman symbol when someone talks. A better option would be text.standardize, or text.toJagexName"
+8582,"@@ -81,3 +81,13 @@ func (a *Application) IsOutOfSync() bool {
+ func IsApplicationConfigFile(filename string) bool {
+ 	return filename == DefaultApplicationConfigFilename || strings.HasSuffix(filename, applicationConfigFileExtention)
+ }
++
++func ToApplicationKind(kind string) (ApplicationKind, bool) {
++	upper := strings.ToUpper(string(kind))
++	k := strings.TrimSuffix(upper, ""APP"")
++	appKind, ok := ApplicationKind_value[k]
++	if !ok {
++		return -1, false
++	}
++	return ApplicationKind(appKind), true
++}",How about `ApplicationKindFromConfigKind`? And I think this function should be better in the config package. The reason is `config` package can import and refer things from the model package but not vice versa.
+8583,"@@ -101,9 +101,14 @@ const (
+ // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob.
+ type Options struct {
+ 	// Credential represents the authorizer for SignedURL.
+-	// Required to use SignedURL.
++	// Required to use SignedURL. If you're using MSI for authentication, this will
++	// attempt to be loaded lazily the first time you call SignedURL
+ 	Credential azblob.StorageAccountCredential
+
++	// CredentialExpiration is when the current MSI-obtained signing credential
++	// expires so that we can refresh it on demand
++	CredentialExpiration time.Time
++
+ 	// SASToken can be provided along with anonymous credentials to use
+ 	// delegated privileges.
+ 	// See https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1#shared-access-signature-parameters.","Nit: missing closing "".""."
+8584,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked"
+8585,"@@ -123,9 +123,9 @@ func CreatePipeline(pipelineName string, provider Provider, stageNames []string)
+ 	}, nil
+ }
+
+-// Marshal serializes the pipeline manifest object into byte array that
++// MarshalBinary serializes the pipeline manifest object into byte array that
+ // represents the pipeline.yml document.
+-func (m *PipelineManifest) Marshal() ([]byte, error) {
++func (m *PipelineManifest) MarshalBinary() ([]byte, error) {
+ 	box := templates.Box()
+ 	content, err := box.FindString(""cicd/pipeline.yml"")
+ 	if err != nil {",Same here. Should this be pipeline YAML file? Like `MarshalPipelineManifest`
+8586,"@@ -213,6 +213,9 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) {
+ 	}
+ 	i.Stop()
+
++	// Execute instantiation events
++	EmitEvent(InstanceStartupEvent, newInst)
++
+ 	log.Println(""[INFO] Reloading complete"")
+
+ 	return newInst, nil",I will add this to my PR
+8587,"@@ -19,4 +19,8 @@ class RolePolicy < ApplicationPolicy
+   def destroy?
+     @role.plan.owned_by?(@user.id)
+   end
++
++  def archive?
++    @role.user_id = @user.id
++  end
+ end",Again not 100% sold on the name
+8588,"@@ -226,8 +226,9 @@ func runWeb(ctx *cli.Context) error {
+ 	m.Group(""/user/settings"", func() {
+ 		m.Get("""", user.Settings)
+ 		m.Post("""", bindIgnErr(auth.UpdateProfileForm{}), user.SettingsPost)
+-		m.Post(""/avatar"", binding.MultipartForm(auth.UploadAvatarForm{}), user.SettingsAvatar)
++		m.Post(""/avatar"", binding.MultipartForm(auth.AvatarForm{}), user.SettingsAvatarPost)
+ 		m.Post(""/avatar/delete"", user.SettingsDeleteAvatar)
++		m.Get(""/avatar"", user.SettingsAvatar)
+ 		m.Combo(""/email"").Get(user.SettingsEmails).
+ 			Post(bindIgnErr(auth.AddEmailForm{}), user.SettingsEmailPost)
+ 		m.Post(""/email/delete"", user.DeleteEmail)",Use `m.Combo` for `Get` and `Post` methods.
+8589,"@@ -446,6 +446,13 @@ class DownloadItem(QObject):
+             # The file already exists, so ask the user if it should be
+             # overwritten.
+             self._ask_overwrite_question()
++        # FIFO, device node, etc. Don't even try.
++        elif (os.path.exists(self._filename) and not
++                os.path.isdir(self._filename)):
++            self.cancel(False)
++            message.error(self._win_id, ""The file {} already exists, and is a ""
++                                        ""special file. Aborting."".format(
++                                         self._filename))
+         else:
+             self._create_fileobj()
+ ","Is there a reason you're not using `self._die(""The file {} ..."")` here?"
+8590,"@@ -13,7 +13,7 @@ import (
+
+ // LocalDevExecCmd allows users to execute arbitrary bash commands within a container.
+ var LocalDevExecCmd = &cobra.Command{
+-	Use:   ""exec [app_name] [environment_name] '[cmd]'"",
++	Use:   ""exec '[cmd]'"",
+ 	Short: ""run a command in an app container."",
+ 	Long:  `Execs into container and runs bash commands.`,
+ 	Run: func(cmd *cobra.Command, args []string) {","I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But ""Run a command in an app container"" doesn't do it for me :)"
+8591,"@@ -8,6 +8,10 @@ import (
+ 	. ""github.com/weaveworks/weave/common""
+ )
+
++var (
++	weaveWaitEntrypoint = []string{""/home/weavewait/weavewait""}
++)
++
+ func callWeave(args ...string) ([]byte, error) {
+ 	args = append([]string{""--local""}, args...)
+ 	Debug.Print(""Calling weave"", args)",shouldn't this be a const?
+8592,"@@ -135,10 +135,7 @@ class MongoDBMochaReporter extends mocha.reporters.Spec {
+         timestamp = timestamp ? timestamp.toISOString().split('.')[0] : '';
+
+         output.testSuites.push({
+-          package:
+-            suite.file.includes('functional') || suite.file.includes('integration')
+-              ? 'Functional'
+-              : 'Unit',
++          package: suite.file.includes('integration') ? 'Functional' : 'Unit',
+           id,
+           name: className,
+           timestamp,","This is a bit of a throwaway field in the xunit output, it doesn't impact anything on EVG, should we just name it `integration` now?"
+8593,"@@ -29,6 +29,6 @@ import java.lang.annotation.Target;
+ @Documented
+ @Retention(SOURCE)
+ @Target(TYPE)
+-public @interface SolrSingleThreaded {
++public @interface SolrThreadUnsafe {
+
+ }",Please change the name of the file too.
+8594,"@@ -286,7 +286,7 @@ func inject(args []string) string {
+
+ func init() {
+ 	flag := injectCmd.Flags()
+-	flag.StringVar(&injectCfg.configPath, ""injector-config-path"", ""./tools/actioninjector/gentsfaddrs.yaml"", ""path of config file of genesis transfer addresses"")
++	flag.StringVar(&injectCfg.configPath, ""injector-config-path"", ""./tools/actioninjector.v2/gentsfaddrs.yaml"", ""path of config file of genesis transfer addresses"")
+ 	flag.StringVar(&injectCfg.serverAddr, ""addr"", ""127.0.0.1:14004"", ""target ip:port for grpc connection"")
+ 	flag.Uint64Var(&injectCfg.transferGasLimit, ""transfer-gas-limit"", 20000, ""transfer gas limit"")
+ 	flag.Int64Var(&injectCfg.rawTransferGasPrice, ""transfer-gas-price"", 10, ""transfer gas price"")",line is 161 characters (from `lll`)
+8595,"@@ -195,8 +195,10 @@ module Bolt
+       @outputter.stop_spin
+
+       # Automatically generate types after installing modules
+-      @outputter.print_action_step(""Generating type references"")
+-      @pal.generate_types(cache: true)
++      if ok
++        @outputter.print_action_step(""Generating type references"")
++        @pal.generate_types(cache: true)
++      end
+
+       @outputter.print_puppetfile_result(ok, path, moduledir)
+ ",When is this false?
+8596,"@@ -540,7 +540,6 @@ Dispose()
+         [InlineData(""${counter}"", DbType.Int16, (short)1)]
+         [InlineData(""${counter}"", DbType.Int32, 1)]
+         [InlineData(""${counter}"", DbType.Int64, (long)1)]
+-        [InlineData(""${counter}"", DbType.Int16, (short)1)]
+         [InlineData(""${counter:norawvalue=true}"", DbType.Int16, (short)1)] //fallback
+         [InlineData(""${counter}"", DbType.VarNumeric, 1, true)]
+         [InlineData(""${counter}"", DbType.AnsiString, ""1"")]",note: also here ;)
+8597,"@@ -145,6 +145,10 @@ public class TemporaryFilesystem {
+   }
+
+   public boolean deleteBaseDir() {
+-    return baseDir.delete();
++    boolean wasDeleted = baseDir.delete();
++    if (wasDeleted) {
++      Runtime.getRuntime().removeShutdownHook(shutdownHook);
++    }
++    return wasDeleted;
+   }
+ }","I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways."
+8598,"@@ -38,10 +38,15 @@ const kytheExtractionConfigFile = "".kythe-extraction-config""
+ // Repo is a container of input/output parameters for doing extraction on remote
+ // repositories.
+ type Repo struct {
+-	// Clone extracts a copy of the repo to the specified output Directory.
+-	Clone func(ctx context.Context, outputDir string) error
++	// Either GitRepo or LocalRepo should be set, not both.
++	// A remote git repo, e.g. https://github.com/google/kythe.
++	Git string
++	// A local copy of a repository.
++	Local string
++
+ 	// Where to write from an extraction.
+ 	OutputPath string
++
+ 	// An optional path to a file containing a
+ 	// kythe.proto.ExtractionConfiguration encoded as JSON that details how
+ 	// to perform extraction. If this is unset, the extractor will first try","nit: blank between, for consistency."
+8599,"@@ -21,8 +21,10 @@ import java.util.regex.Matcher;
+ /** Utility class for formatting source comments to follow RDoc style. */
+ public class RDocCommentFixer {
+
+-  /** Returns a Sphinx-formatted comment string. */
++  /** Returns a RDoc-formatted comment string. */
+   public static String rdocify(String comment) {
++    // escape '$' in the comment first
++    comment = comment.replaceAll(""\\$"", ""\\\\\\$"");
+     comment = CommentPatterns.BACK_QUOTE_PATTERN.matcher(comment).replaceAll(""+"");
+     comment = rdocifyProtoMarkdownLinks(comment);
+     comment = rdocifyCloudMarkdownLinks(comment);",ditto for RDoc or YARD link
+8600,"@@ -173,7 +173,7 @@ public class DefaultConditionRunner implements ConditionRunner {
+     }
+
+     protected void log(String message) {
+-      logger.info(new Date() + "" - "" + message);
++      logger.finest(new Date() + "" - "" + message);
+     }
+
+   }",This method is designed to allow the condition runner to tell users something interesting. The current `INFO` log level is correct.
+8601,"@@ -36,7 +36,7 @@ type Info struct {
+ 	SSLRequired       bool     `json:""ssl_required""` // DEPRECATED: ssl json used for older clients
+ 	TLSRequired       bool     `json:""tls_required""`
+ 	TLSVerify         bool     `json:""tls_verify""`
+-	MaxPayload        int      `json:""max_payload""`
++	MaxPayload        int64    `json:""max_payload""`
+ 	IP                string   `json:""ip,omitempty""`
+ 	ClientConnectURLs []string `json:""connect_urls,omitempty""` // Contains URLs a client can connect to.
+ ","Again, would not change that."
+8602,"@@ -98,4 +98,16 @@ public enum Status {
+       return false;
+     }
+   }
++
++  public static boolean isStatusFailed(Status status) {
++    switch (status) {
++      case FAILED:
++      case KILLED:
++      case CANCELLED:
++      case FAILED_FINISHING:
++        return true;
++      default:
++        return false;
++    }
++  }
+ }",Is canceled considered failed?
+8603,"@@ -300,7 +300,7 @@ func TestBrowseJson(t *testing.T) {
+ 		req.Header.Set(""Accept"", ""application/json"")
+ 		rec := httptest.NewRecorder()
+
+-		code, err := b.ServeHTTP(rec, req)
++		code, _ := b.ServeHTTP(rec, req)
+
+ 		if code != http.StatusOK {
+ 			t.Fatalf(""In test %d: Wrong status, expected %d, got %d"", i, http.StatusOK, code)",These ineffectual assignment changes intrigue me. Our CI tests have been checking for these for months; how come the tests haven't been failing? How did you catch these?
+8604,"@@ -103,10 +103,15 @@ func TestMintX509CA(t *testing.T) {
+ 			wrapper := Wrap(upstreamCA)
+
+ 			// Request Mint to wrapper
+-			resp, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
++			stream, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
+ 				Csr:          testCase.csr,
+ 				PreferredTtl: testCase.preferredTTL,
+ 			})
++			// Stream returned, and no error expected
++			require.NoError(t, err)
++			require.NotNil(t, stream)
++
++			resp, err := stream.Recv()
+
+ 			// if test case expect an error validates it has expected code and message
+ 			if testCase.err != """" {",We should add an additional call to Recv() somewhere after here that we assert returns io.EOF.
+8605,"@@ -35,7 +35,8 @@ func setupJournalBlockServerTest(t *testing.T) (
+ 	// Clean up the config if the rest of the setup fails.
+ 	defer func() {
+ 		if !setupSucceeded {
+-			CheckConfigAndShutdown(t, config)
++			ctx := context.Background()
++			CheckConfigAndShutdown(ctx, t, config)
+ 		}
+ 	}()
+ ","Why not return a `ctx` from `setupJournalBlockServerTest` and use it everywhere, like in the other test files? And maybe put a test timeout on it while you're at it? (Same for the other journal test files below.)"
+8606,"@@ -33,7 +33,17 @@
+
+
+ // ObjectTracker undestroyed objects validation function
+-bool ObjectLifetimes::ReportUndestroyedObjects(VkDevice device, const std::string& error_code) {
++bool ObjectLifetimes::ReportUndestroyedInstanceObjects(VkInstance instance, const std::string& error_code) {
++    bool skip = false;
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeSurfaceKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeSwapchainKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDisplayKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDisplayModeKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDebugReportCallbackEXT, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDebugUtilsMessengerEXT, error_code);
++    return skip;
++}
++bool ObjectLifetimes::ReportUndestroyedDeviceObjects(VkDevice device, const std::string& error_code) {
+     bool skip = false;
+     skip |= DeviceReportUndestroyedObjects(device, kVulkanObjectTypeCommandBuffer, error_code);
+     skip |= DeviceReportUndestroyedObjects(device, kVulkanObjectTypeSemaphore, error_code);",Do we need HeadlessSurface and DisplayPlaneSurface here too?
+8607,"@@ -473,7 +473,7 @@ describe('GridFS Stream', function () {
+                     // Fail if user tries to abort an aborted stream
+                     uploadStream.abort().then(null, function (error) {
+                       expect(error.toString()).to.equal(
+-                        'MongoDriverError: Cannot call abort() on a stream twice'
++                        'MongoGridFSStreamError: Cannot call abort() on a stream twice'
+                       );
+                       client.close(done);
+                     });",Would it be appropriate for this to be a `MongoStreamClosedError`?
+8608,"@@ -26,11 +26,13 @@ import (
+ 	""github.com/golang/glog""
+ 	""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/internalclientset""
++	snapclient ""github.com/openebs/maya/pkg/client/generated/openebs.io/snapshot/v1/clientset/internalclientset""
+ 	""k8s.io/api/admission/v1beta1""
+ 	admissionregistrationv1beta1 ""k8s.io/api/admissionregistration/v1beta1""
+ 	v1 ""k8s.io/api/apps/v1""
+ 	corev1 ""k8s.io/api/core/v1""
+
++	""k8s.io/apimachinery/pkg/api/resource""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/serializer""",Can you raise new issue that talks about refactoring webhook code. It should follow `idiomatic maya` patterns.
+8609,"@@ -0,0 +1,9 @@
++using Datadog.Trace.Interfaces;
++
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface ISpanDecorator
++    {
++        void Decorate(ISpan span);
++    }
++}","(Probably repeating myself) Instead of `Datadog.Trace.Interfaces`, should we move this and several other files into a `Datadog.Trace.Decorators` namespace instead?"
+8610,"@@ -1,6 +1,7 @@
+ # -*- encoding : utf-8 -*-
+ require 'kaminari'
+ require 'rsolr'
++require 'deprecation'
+ module Blacklight
+
+   autoload :Configurable, 'blacklight/configurable'","Should we generate `gem ""rsolr""` into the application Gemfile?"
+8611,"@@ -130,6 +130,8 @@ static struct optparse_option attach_opts[] =  {
+     { .name = ""label-io"", .key = 'l', .has_arg = 0,
+       .usage = ""Label output by rank"",
+     },
++    { .name = ""verbose"", .key = 'v', .has_arg = 0,
++      .usage = ""Increase verbosity"" },
+     { .name = ""quiet"", .key = 'q', .has_arg = 0,
+       .usage = ""Suppress warnings written to stderr from flux-job"",
+     },","commit message, ""currently ignored""? (-ed)"
+8612,"@@ -37,6 +37,12 @@ module Selenium
+         def bridge_class
+           Bridge
+         end
++
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
+       end # Driver
+     end # Firefox
+   end # WebDriver",Same here. and all others.
+8613,"@@ -25,14 +25,16 @@ namespace Nethermind.Blockchain
+     public class OneTimeChainProcessor : IBlockchainProcessor
+     {
+         private readonly IBlockchainProcessor _processor;
++        private readonly IBlockchainProcessor _mainChainProcessor;
+         private readonly IReadOnlyDbProvider _readOnlyDbProvider;
+
+         private object _lock = new object();
+
+-        public OneTimeChainProcessor(IReadOnlyDbProvider readOnlyDbProvider, IBlockchainProcessor processor)
++        public OneTimeChainProcessor(IReadOnlyDbProvider readOnlyDbProvider, IBlockchainProcessor processor, IBlockchainProcessor mainChainProcessor = null)
+         {
+             _readOnlyDbProvider = readOnlyDbProvider ?? throw new ArgumentNullException(nameof(readOnlyDbProvider));
+             _processor = processor ?? throw new ArgumentNullException(nameof(processor));
++            _mainChainProcessor = mainChainProcessor;
+         }
+
+         public void Start()",can we pass some simple interface instead of a full additional processor? (an imterface with these two events only)
+8614,"@@ -107,6 +107,8 @@ insert_exit_stub_other_flags(dcontext_t *dcontext, fragment_t *f,
+     /* FIXME i#1575: coarse-grain NYI on ARM */
+     ASSERT_NOT_IMPLEMENTED(!TEST(FRAG_COARSE_GRAIN, f->flags));
+     if (LINKSTUB_DIRECT(l_flags)) {
++        /* We put a NOP here for future linking. */
++        *pc++ = 0xd503201f;
+         /* stp x0, x1, [x(stolen), #(offs)] */
+         *pc++ = (0xa9000000 | 0 | 1 << 10 | (dr_reg_stolen - DR_REG_X0) << 5 |
+                  TLS_REG0_SLOT >> 3 << 15);",Use a named constant
+8615,"@@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+
+             var stop = Assert.Single(events, e => e.EventName == ""ConnectionStop"");
+             Assert.All(new[] { ""connectionId"" }, p => Assert.Contains(p, stop.PayloadNames));
+-            Assert.Same(KestrelEventSource.Log, stop.EventSource);
++            Assert.Same(KestrelEventSource.Log, stop?.EventSource);
+         }
+
+         private string GetProperty(EventWrittenEventArgs data, string propName)",The `?` is unnecessary since `Assert.Single` will fail if it can't find the stop event.
+8616,"@@ -29,6 +29,12 @@ import org.apache.iceberg.StructLike;
+  * Implementations must be {@link Serializable} because instances will be serialized to tasks.
+  */
+ public interface LocationProvider extends Serializable {
++
++  /**
++   * Return a fully-qualified data location.
++   */
++  String dataLocation();
++
+   /**
+    * Return a fully-qualified data file location for the given filename.
+    *",What about providers that don't have a reliable location? Do they return null?
+8617,"@@ -14,9 +14,14 @@
+ // limitations under the License.
+ // </copyright>
+
++using System;
++
+ namespace OpenTelemetry.Metrics
+ {
+     public abstract class MetricProcessor : BaseProcessor<MetricItem>
+     {
++        // GetMetric or GetMemoryState or GetAggregatedMetrics..
++        // ...or some other names
++        public abstract void SetGetMetricFunction(Func<MetricItem> getMetrics);
+     }
+ }","I might not be thinking about things right, but would it make sense for a MetricProcessor to have a handle on the ParentProvider kinda like how we do for traces? That way instead of calling `SetGetMetricFunction(this.Collect)` in the MeterProviderSdk you'd have a handle on the provider to call `Collect` directly."
+8618,"@@ -30,7 +30,8 @@ def check_dynamodb(expect_shutdown=False, print_error=False):
+         # wait for backend port to be opened
+         wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path=""/"", expect_success=False, sleep_time=1)
+         # check DynamoDB
+-        out = aws_stack.connect_to_service(""dynamodb"").list_tables()
++        endpoint_url = f""http://127.0.0.1:{PORT_DYNAMODB_BACKEND}""
++        out = aws_stack.connect_to_service(""dynamodb"", endpoint_url=endpoint_url).list_tables()
+     except Exception as e:
+         if print_error:
+             LOGGER.error(""DynamoDB health check failed: %s %s"" % (e, traceback.format_exc()))","nit: If we want to squeeze out a few more milliseconds from the startup, we may actually be able to remove this line (`wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path=""/"", ...` should already be sufficient to ensure that the service is up and responding to HTTP requests). Thoughts?"
+8619,"@@ -4880,7 +4880,7 @@ os_normalized_sysnum(int num_raw, instr_t *gateway, dcontext_t *dcontext)
+         }
+     }
+ #    ifdef X64
+-    if (num_raw >> 24 == 0x2)
++    if (num_raw & SYSCALL_NUM_MARKER_BSD)
+         return (int)(num_raw & 0xffffff); /* Drop BSD bit */
+     else
+         num = (int)num_raw; /* Keep Mach and Machdep bits */",Convention is to use TEST
+8620,"@@ -38,9 +38,9 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
+   """"""
+
+
+-  @unittest.skip(""There are slight differences between implementations that""
+-                 ""prevent this from passing still. See ""
+-                 ""https://github.com/numenta/nupic/issues/2980"")
++  # @unittest.skip(""There are slight differences between implementations that""
++  #                ""prevent this from passing still. See ""
++  #                ""https://github.com/numenta/nupic/issues/2980"")
+   def testTMPyCpp(self):
+     """"""
+     Test compatibility between C++ and Python TM implementation.",Just in case: remember to remove this.
+8621,"@@ -61,7 +61,7 @@ public class EIP1559 {
+       final BigInteger target = BigInteger.valueOf(targetGasUsed);
+       final BigInteger denominator = BigInteger.valueOf(feeMarket.getBasefeeMaxChangeDenominator());
+       feeDelta = pBaseFee.multiply(gDelta).divide(target).divide(denominator).longValue();
+-      baseFee = parentBaseFee - feeDelta;
++      baseFee = max(parentBaseFee - feeDelta, 0);
+     }
+     LOG.trace(
+         ""block #{} parentBaseFee: {} parentGasUsed: {} parentGasTarget: {} baseFee: {}"",",I am not certain if this should be 0 or 7 here. I think a basefee under 7 is pathological
+8622,"@@ -20,6 +20,12 @@ vm[] = {
+ 	.0002908882086657216,
+ 	.0000048481368110953599
+ };
++/* byte sequence for Degree Sign U+00B0 in UTF-8. */
++	static constexpr char
++DEG_SIGN1 = '\xc2';
++	static constexpr char
++DEG_SIGN2 = '\xb0';
++
+ 	double
+ dmstor(const char *is, char **rs) {
+ 	return dmstor_ctx( pj_get_default_ctx(), is, rs );",it would be better to move the declaration of the variable with its initialization at line 68
+8623,"@@ -12,6 +12,7 @@
+
+  defined in: Hall and Kier JCICS _35_ 1039-1045 (1995)  Table 1
+ """"""
++import sys
+ from rdkit import Chem
+
+ _rawD = [",I don't think this is required.
+8624,"@@ -48,7 +48,7 @@ func TestSyncServiceContextUpdated(t *testing.T) {
+ 	}
+
+ 	// run the update context call once
+-	err := service.updateContext()
++	err := service.updateEthContext()
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}",This rename should also ideally be in a separate PR.
+8625,"@@ -86,11 +86,14 @@ public final class HttpCall<V> extends Call.Base<V> {
+       if (t != null) {
+         callback.onError(t);
+       } else {
++        V value = null;
+         try {
+-          callback.onSuccess(parseResponse(response, bodyConverter));
+-        } catch (IOException e) {
+-          callback.onError(e);
++          value = parseResponse(response, bodyConverter);
++        } catch (Throwable t1) {
++          propagateIfFatal(t1);
++          callback.onError(t1);
+         }
++        if (value != null) callback.onSuccess(value);
+       }
+       return null;
+     });","Think this needs to go right below line 91. `parseResponse` can return `null` (line 133), which will cause this future to never complete."
+8626,"@@ -46,8 +46,8 @@ import java.util.List;
+ public class HttpCommandProcessor implements CommandProcessor {
+
+   private String pathToServlet;
+-  private String browserStartCommand;
+-  private String browserURL;
++  private final String browserStartCommand;
++  private final String browserURL;
+   private String sessionId;
+   private String extensionJs;
+   private String rcServerLocation;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+8627,"@@ -520,8 +520,7 @@ public class AzkabanWebServer extends AzkabanServer {
+       startWebMetrics();
+     }
+
+-    if(this.props.containsKey(ConfigurationKeys.ENABLE_QUARTZ) && this.props.getBoolean(ConfigurationKeys
+-        .ENABLE_QUARTZ)) {
++    if (this.props.getBoolean(ConfigurationKeys.ENABLE_QUARTZ, false)) {
+       this.quartzScheduler.start();
+     }
+ ","Yeah, why not use this method instead of checking with `containsKey`?"
+8628,"@@ -39,9 +39,9 @@ for i in range(loop_num):
+     torch.cuda.synchronize()
+     time_backward += timer.since_last_check()
+     bar.update()
+-print('\nCARAFE time forward: {} ms/iter | time backward: {} ms/iter'.format(
+-    (time_forward + 1e-3) * 1e3 / loop_num,
+-    (time_backward + 1e-3) * 1e3 / loop_num))
++print(f'\nCARAFE time forward: {(time_forward + 1e-3) * 1e3 / loop_num} '
++      f'ms/iter | time backward: {(time_backward + 1e-3) * 1e3 / loop_num}'
++      ' ms/iter')
+
+ time_naive_forward = 0
+ time_naive_backward = 0",Compute `(time_forward + 1e-3) * 1e3 / loop_num` ahead.
+8629,"@@ -74,18 +74,13 @@ namespace NLog.Internal
+                     throw;
+                 }
+
+-                if (LogManager.ThrowExceptions)
+-                {
+-                    throw;
+-                }
+-
+                 ReportExceptionInHandler(ex);
+             }
+         }
+
+         private static void ReportExceptionInHandler(Exception exception)
+         {
+-            InternalLogger.Error(""Exception in asynchronous handler {0}"", exception);
++            InternalLogger.Error(exception, ""Exception in asynchronous handler."");
+         }
+     }
+ }","Mh... `MustBeRethrown()` above already logs `ex`, so `ex` will be logged here for the second time. I think this line must be moved to before `MustBeRethrown()`."
+8630,"@@ -29,11 +29,13 @@ import java.util.Map;
+  */
+ public class CommonDiscoveryProvider implements DiscoveryProvider {
+   private final DiscoveryContext context;
+-  private final SnippetSetRunner<Method> snippetSetRunner;
++  private final SnippetSetRunner.Generator<Method> snippetSetRunner;
+   private final String snippetFileName;
+
+   public CommonDiscoveryProvider(
+-      DiscoveryContext context, SnippetSetRunner<Method> snippetSetRunner, String snippetFileName) {
++      DiscoveryContext context,
++      SnippetSetRunner.Generator<Method> snippetSetRunner,
++      String snippetFileName) {
+     this.context = context;
+     this.snippetSetRunner = snippetSetRunner;
+     this.snippetFileName = snippetFileName;","Since this never changes, why not pass it into the constructor instead?"
+8631,"@@ -48,10 +48,10 @@ namespace Nethermind.Synchronization.BeamSync
+
+         private readonly ISyncModeSelector _syncModeSelector;
+
+-        private readonly Func<bool> _writeThrough;
+-
+         private ILogger _logger;
+
++        private IDb _targetDbForSaves;
++
+         public BeamSyncDb(IDb stateDb, IDb tempDb, ISyncModeSelector syncModeSelector, ILogManager logManager)
+             : base(logManager)
+         {",this is critical to avoid state root saving from beam
+8632,"@@ -231,7 +231,8 @@ class AnchorHead(nn.Module):
+         # map up to original set of anchors
+         if unmap_outputs:
+             num_total_anchors = flat_anchors.size(0)
+-            labels = unmap(labels, num_total_anchors, inside_flags)
++            labels = unmap(labels, num_total_anchors, inside_flags,
++                           self.num_classes)  # fill bg label
+             label_weights = unmap(label_weights, num_total_anchors,
+                                   inside_flags)
+             bbox_targets = unmap(bbox_targets, num_total_anchors, inside_flags)","To make it more clear, `fill=self.num_classes`."
+8633,"@@ -78,6 +78,11 @@ type Message struct {
+ 	AfterSend func(asFunc func(interface{}) bool) error
+ }
+
++// Implement batcher item for byte sized based batching
++func (m *Message) ByteSize() int {
++	return len(m.Body)
++}
++
+ // Topic publishes messages.
+ // Drivers may optionally also implement io.Closer; Close will be called
+ // when the pubsub.Topic is Shutdown.","Nit: ""ByteSize estimates the size in bytes of the message for the purpose of restricting batch sizes."""
+8634,"@@ -61,9 +61,11 @@ namespace SampleApp
+
+                     // The following section should be used to demo sockets
+                     //options.ListenUnixSocket(""/tmp/kestrel-test.sock"");
+-
++                })
++                .UseLibuv(options =>
++                {
+                     // Uncomment the following line to change the default number of libuv threads for all endpoints.
+-                    //options.ThreadCount = 4;
++                    options.ThreadCount = 4;
+                 })
+                 .UseContentRoot(Directory.GetCurrentDirectory())
+                 .UseStartup<Startup>()",It's weird to have this on the same level as kestrel. This needs to move to options.
+8635,"@@ -476,7 +476,11 @@ module.exports = class Webcam extends Plugin {
+   }
+
+   getVideo () {
+-    const mimeType = this.recordingChunks[0].type
++    // Sometimes in iOS Safari, Blobs (especially the first Blob in the recordingChunks Array)
++    // have empty 'type' attributes (e.g. '') so we need to find a Blob that has a defined 'type'
++    // attribute in order to determine the correct MIME type.
++    const mimeType = this.recordingChunks.find(blob => blob.type?.length > 0).type
++
+     const fileExtension = getFileTypeExtension(mimeType)
+
+     if (!fileExtension) {",is it safe for us to use the `blob.type?.length` optional chaining with IE11 support? @goto-bus-stop
+8636,"@@ -125,13 +125,14 @@ class User < ActiveRecord::Base
+   # @param new_organisation_id [Integer] the id for an organisation
+   # @return [String] the empty string as a causality of setting api_token
+   def org_id=(new_org_id)
++    puts ""$$$$ new_org_id: #{new_org_id}""
+     unless self.can_change_org? || new_org_id.nil? || self.org.nil? || (new_org_id.to_s == self.org.id.to_s)
+       # rip all permissions from the user
+       self.perms.delete_all
+     end
+     # set the user's new organisation
+     super(new_org_id)
+-    self.save!
++    # self.save!
+     # rip api permissions from the user
+     self.remove_token!
+   end",remove this debug statement
+8637,"@@ -2357,7 +2357,12 @@ bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer com
+
+     VkImageAspectFlags legal_aspect_flags =
+         VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
+-    if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
++    // YCbCr is core after 1.1
++    if (api_version >= VK_API_VERSION_1_1) {
++        legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT);
++    }
++    // If physical device does not support 1.1, check for YCbCr extension support
++    else if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
+         legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
+     }
+ ","This should not be needed. 1) all 1.1 promoted extensions are marked as enabled when a 1.1 device is created (which happens iff both physical device support and apiVersion are set to 1.1) 2) The KHR and non-KHR versions of the bits are aliases of each other, so no different set is required."
+8638,"@@ -656,7 +656,11 @@ static void makeflow_node_complete(struct dag *d, struct dag_node *n, struct bat
+
+ 	struct list *outputs = makeflow_generate_output_files(n, wrapper, monitor);
+
+-	if(info->exited_normally && info->exit_code == 0) {
++
++	if(getenv(""CCTOOLS_LOOP_DEV_FULL"")) {
++		job_failed = 1;
++	}
++	else if(info->exited_normally && info->exit_code == 0) {
+ 		list_first_item(outputs);
+ 		while((f = list_next_item(outputs))) {
+ 			if(!makeflow_node_check_file_was_created(n, f))","I can see why you did it this way, but let's not get into the habit of passing information back via an environment variable. Add an element to `batch_job_info` instead, which is where we send back detailed info about jobs."
+8639,"@@ -438,7 +438,11 @@ function diffElementNodes(
+ 			if (
+ 				'value' in newProps &&
+ 				(i = newProps.value) !== undefined &&
+-				i !== dom.value
++				// #2756 For the <progress>-element the initial value is 0,
++				// despite the attribute not being present. When the attribute
++				// is missing the progress bar is treated as indeterminate.
++				// To fix that we'll always update it when it is 0 for progress elements
++				(i !== dom.value || (newVNode.type === 'progress' && !i))
+ 			) {
+ 				setProperty(dom, 'value', i, oldProps.value, false);
+ 			}","Turns out my previous fix of doing `!dom.hasAttribute('value')` is not a good one as it leads to all input values always being updated. The new fix only updates it, despite `dom.value === props.value` when the value is `0` for progress elements."
+8640,"@@ -3,6 +3,7 @@
+ #include <cmath>
+ #include <cstdio>
+ #include <ctime>
++#include <vector>
+
+ #include ""caffe/common.hpp""
+ #include ""caffe/util/rng.hpp""",Why is this being added here? Is this relevant to these changes?
+8641,"@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
+           getClass().getClassLoader())
+           .asSubclass(Routable.class);
+       Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
+-      LOG.info(""Bound legacy RC support"");
++      LOG.finest(""Bound legacy RC support"");
+       return constructor.newInstance(sessions);
+     } catch (ReflectiveOperationException e) {
+       // Do nothing.",This informational message is important to users. Please leave.
+8642,"@@ -0,0 +1,4 @@
++All unapproved FY15 credit card funding requests are being cancelled.
++If the need still exists, please submit a new FY16 funding request.
++
++<%= url_for(controller: 'proposals', action: 'show', id: @proposal.id) %>",why isn't rubocop failing for single quotes?
+8643,"@@ -36,14 +36,10 @@ class StatusAttributeDataSetQueryBuilder extends AbstractAttributeDataSetBuilder
+     {
+         $query->addSelect(sprintf(
+             '(
+-                SELECT value FROM product_value pv
+-                JOIN value_translation vt ON vt.value_id = pv.value_id
+-                WHERE pv.attribute_id = \'%s\'
+-                AND pv.product_id = p.id
+-                AND vt.language IS NULL
++                SELECT status_id FROM product_workflow_status pws
++                WHERE pws.product_id = p.id
+                 LIMIT 1
+             ) AS ""%s""',
+-            $attribute->getId()->getValue(),
+             $key
+         ));
+     }",Is `WHERE` should `Language` param ?
+8644,"@@ -46,6 +46,7 @@ namespace oneapi::dal::basic_statistics::backend {
+ namespace de = dal::detail;
+ namespace be = dal::backend;
+ namespace pr = dal::backend::primitives;
++namespace ps = oneapi::dal::preview::spmd;
+
+ using alloc = sycl::usm::alloc;
+ ","ps - first letter from preview, when we move it into public it will not be relevant. my suggestion is spmd or ds(distributed)"
+8645,"@@ -1757,7 +1757,18 @@ class Frame(object, metaclass=ABCMeta):
+         2  6  30   30
+         3  7  40   50
+         """"""
+-        return self._apply_series_op(lambda kser: kser._with_new_scol(F.abs(kser.spark.column)))
++
++        def abs(kser):
++            if isinstance(kser.spark.data_type, BooleanType):
++                return kser
++            elif isinstance(kser.spark.data_type, NumericType):
++                return kser.spark.transform(F.abs)
++            else:
++                raise TypeError(
++                    ""bad operand type for abs(): {}"".format(kser.spark.data_type.simpleString())
++                )
++
++        return self._apply_series_op(abs)
+
+     # TODO: by argument only support the grouping name and as_index only for now. Documentation
+     # should be updated when it's supported.","Hm, should we show pandas' dtype instead of Spark data type?"
+8646,"@@ -23,10 +23,13 @@ namespace OpenTelemetry.Metrics
+     {
+         /*
+         Type:
+-            0x10: Sum
+-            0x20: Gauge
+-            0x30: Histogram
+-            0x40: Summary (reserved)
++            0x10 0b00010000: Sum
++            0x20 0b00100000: Gauge
++            0x40 0b01000000: Histogram
++            0x50 0b01010000: HistogramWithBuckets
++            0x60 0b01100000: HistogramWithMinMax
++            0x70 0b01110000: HistogramWithMinMaxAndBuckets
++            0x80 0b10000000: Summary (reserved)
+
+         Point kind:
+             0x04: I1 (signed 1-byte integer)","@reyang when exponentialhistogram arrives, we won't have any bits left for it.. unless we take Summary or make this 16 bits instead of current 8 bytes"
+8647,"@@ -2,6 +2,8 @@
+
+ class PdoStatement {
+     /**
++     * @psalm-taint-sink text $class
++     *
+      * @template T
+      * @param class-string<T> $class
+      * @return false|T",This change is not tested.. I guess this is how these taint-annotations work..?
+8648,"@@ -485,6 +485,14 @@ class ConfigOverrider(object):
+
+         dest.dump()
+
++    def __apply_mult_override(self, obj, key, replace_value):
++        for k, v in obj.items():
++            if isinstance(v, dict):
++                obj[k] = self.__apply_mult_override(v, key, replace_value)
++        if key in obj:
++            obj[key] = replace_value
++        return obj
++
+     def __apply_single_override(self, dest, name, value):
+         """"""
+         Apply single override",Fails if obj is list. Please fix!
+8649,"@@ -28,5 +28,16 @@ class TestInstanceStatusResponseParsing(unittest.TestCase):
+         self.assertEqual(all_statuses.next_token, 'page-2')
+
+
++    def test_include_all_instances(self):
++        ec2 = EC2Connection(aws_access_key_id='aws_access_key_id',
++                            aws_secret_access_key='aws_secret_access_key')
++        mock_response = mock.Mock()
++        mock_response.read.return_value = INSTANCE_STATUS_RESPONSE
++        mock_response.status = 200
++        ec2.make_request = mock.Mock(return_value=mock_response)
++        all_statuses = ec2.get_all_instance_status(include_all_instances=True)
++        self.assertEqual(all_statuses.next_token, 'page-2')
++
++
+ if __name__ == '__main__':
+     unittest.main()",Could you add an assertion to make sure the `IncludeAllInstances` parameter is actually set and passed to the request?
+8650,"@@ -79,7 +79,8 @@ def __get_analyzer_version(context, analyzer_config_map):
+         version = [analyzer_bin, u' --version']
+         try:
+             output = subprocess.check_output(shlex.split(' '.join(version)),
+-                                             env=check_env)
++                                             env=check_env,
++                                             universal_newlines=True)
+             versions[analyzer_bin] = output
+         except (subprocess.CalledProcessError, OSError) as oerr:
+             LOG.warning(""Failed to get analyzer version: %s"",","The name of this argument is not too intuitive. The point is, these kind of subprocess calls will return `str`s in Python2 and 'byte`s in Python3. It would be a lot of work to make CodeChecker handle both `str` and `byte` everywhere. Using the `universal_newlines` argument, we can force Python3 to return text rather then bytes."
+8651,"@@ -63,7 +63,7 @@ func toProtoDomainReplicationConfiguration(in *shared.DomainReplicationConfigura
+ 	}
+ 	return &common.DomainReplicationConfiguration{
+ 		ActiveClusterName: in.GetActiveClusterName(),
+-		Clusters:          toProtoClusterReplicationConfigurations(in.Clusters),
++		Clusters:          toProtoClusterReplicationConfigurations(in.GetClusters()),
+ 	}
+ }
+ ",These `Get`s are just cosmetic changes for consistency.
+8652,"@@ -55,13 +55,7 @@ def test_read_yaml(tmpdir):
+     assert parsed_string == parsed_path_obj
+
+
+-def test_yaml_has_comments(tmpdir):
+-    no_comments_yaml = """"""blah: foo\nfizz: boop""""""
+-
+-    assert not util.yaml_has_comments(util.read_yaml(no_comments_yaml))
+-    assert util.yaml_has_comments(util.read_yaml(TEST_YAML))
+-
+-
++@pytest.mark.skip(reason=""Broken due to yaml safe load"")
+ def test_read_yaml_exec_flaw(capfd):
+     # We don't execute anything remote, but someone could give a bad build.yml..
+     util.read_yaml(""""""!!python/object/apply:os.system\nargs: ['echo arbitrary code execution!']"""""")","We should never skip unit tests, but instead fix them. Look at `pytest.raises` for cases where we expect an exception."
+8653,"@@ -79,11 +79,15 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
+         {
+             Log.LogMessage(MessageImportance.Low, $""START pushing items to feed"");
+-            Random rnd = new Random();
+
+-            try
++            if (!items.Any())
+             {
++                Log.LogMessage(""No items to push found in the items list."");
++                return true;
++            }
+
++            try
++            {
+                 bool result = await PushAsync(items.ToList(), allowOverwrite);
+                 return result;
+             }",Do we need to call ToList here?
+8654,"@@ -5,5 +5,8 @@ class EpisodesController < ApplicationController
+
+   def show
+     @episode = Episode.find(params[:id])
++    if topic = @episode.topics.first
++      @products = topic.products.ordered
++    end
+   end
+ end","I think this can be moved into the model, at the very least, but I also think you might be able to do a has many through."
+8655,"@@ -785,7 +785,7 @@ public interface Tree<T> extends Traversable<T> {
+             if (tree.isLeaf()) {
+                 return value;
+             } else {
+-                return String.format(""(%s %s)"", value, tree.getChildren().map(Node::toLispString).mkString("" ""));
++                return ""("" + value + "" "" + (tree.getChildren().map(Node::toLispString).mkString("" "")) + "")"";
+             }
+         }
+ ",could you please separate computations from string concatenation?
+8656,"@@ -216,8 +216,8 @@ namespace Microsoft.Rest.Generator.Tests
+
+             var type = clientModel.ModelTypes.First();
+
+-            Assert.Equal(""code"", type.Properties[0].Name);
+-            Assert.Equal(""message"", type.Properties[1].Name);
++            Assert.Equal(""errorCode"", type.Properties[0].Name);
++            Assert.Equal(""errorMessage"", type.Properties[1].Name);
+             Assert.Equal(""parentError"", type.Properties[2].Name);
+         }
+ ",@NiklasGustafsson - I had to make these changes for the x-ms-client-name extension tests for java and python. The tests were expecting wire format instead of the client name. Hence modified them appropriately. Let me know what you think ?
+8657,"@@ -59,6 +59,13 @@ static int on_req(h2o_handler_t *_self, h2o_req_t *req)
+         authority = &self->upstream.authority;
+     }
+
++    /* rewrite headers */
++    if (self->config.header_cmds.size != 0) {
++        h2o_headers_command_t *cmd;
++        for (cmd = self->config.header_cmds.entries; cmd->cmd != H2O_HEADERS_CMD_NULL; ++cmd)
++            h2o_rewrite_headers(&req->pool, &req->headers, cmd);
++    }
++
+     /* request reprocess */
+     h2o_reprocess_request(req, req->method, scheme, *authority,
+                           h2o_build_destination(req, self->upstream.path.base, self->upstream.path.len, 0), overrides, 0);","Could we just set the list of header modification commands to `req->overrides` and apply them only when the request is sent upstream in lib/core/proxy.c? The reason I ask is because an upstream server (accessed using the modified headers) might return 399. In such case, the request would be delegated to the next handler. I think that the headers of the original request should be passed to the next handler, since per my understanding the intended behavior of `proxy.header.*` is to modify the headers passed to the upstream server only."
+8658,"@@ -214,6 +214,12 @@ type Table struct {
+ 	// to top-level chains.
+ 	insertMode string
+
++	// Record when we did our most recent updates and refreshes of the table.  We use these to
++	// calculate the next time we should force a refresh.
++	lastUpdateTime  time.Time
++	lastRefreshTime time.Time
++	refreshInterval time.Duration
++
+ 	logCxt *log.Entry
+
+ 	gaugeNumChains        prometheus.Gauge","Can we rename 'refresh' to 'read' and 'update' to 'write'? Until I had read more of the code below, I couldn't tell the difference between 'update' and 'refresh'."
+8659,"@@ -76,7 +76,7 @@ export default class VerdaccioProcess implements IServerProcess {
+     });
+
+     this.childFork.on('error', (err) => {
+-      console.log('error process', err);
++      // console.log('error process', err);
+       reject([err, this]);
+     });
+ ",can we remove it ?
+8660,"@@ -228,4 +228,17 @@ NAString ComConvertTrafNameToNativeName(
+   return convertedName;
+ }
+
++NABoolean ComTrafReservedColName(
++     const NAString &colName)
++{
++
++  if ((colName == TRAF_SALT_COLNAME) ||
++      (colName == TRAF_SYSKEY_COLNAME))
++    return TRUE;
+
++  if ((memcmp(colName.data(), TRAF_DIVISION_COLNAME_PREFIX, strlen(TRAF_DIVISION_COLNAME_PREFIX)) == 0) &&
++      (colName.data()[colName.length()-1] == '_'))
++    return TRUE;
++
++  return FALSE;
++}","I take it that by the time we get here, colName has already been case-shifted to upper case?"
+8661,"@@ -126,11 +126,14 @@ func ResponseHeaders(h *map[string]string) CallOption {
+ 	return CallOption{func(o *OutboundCall) { o.responseHeaders = h }}
+ }
+
+-// TODO(abg): Example tests to document the different options
+-
+-// WithHeader adds a new header to the request.
++// WithHeader adds a new header to the request. Header keys are case
++// insensitive.
++//
++// 	_, err := client.GetValue(ctx, reqBody, yarpc.WithHeader(""Token"", ""10""))
++// 	// ==> {""token"": ""10""}
+ //
+-// 	resBody, err := client.GetValue(ctx, reqBody, yarpc.WithHeader(""Token"", ""10""))
++// If multiple entries have the same normalized header name, newer entries
++// override older ones.
+ func WithHeader(k, v string) CallOption {
+ 	return CallOption{func(o *OutboundCall) {
+ 		o.headers = append(o.headers, keyValuePair{k: k, v: v})",Super clear desc - thx.
+8662,"@@ -3551,7 +3551,11 @@ void SwiftASTContext::LoadModule(swift::ModuleDecl *swift_module,
+         all_dlopen_errors.GetData());
+   };
+
+-  swift_module->collectLinkLibraries(addLinkLibrary);
++  swift_module->forAllVisibleModules(
++      {}, [&](swift::ModuleDecl::ImportedModule import) {
++        import.second->collectLinkLibraries(addLinkLibrary);
++        return true;
++      });
+   error = current_error;
+ }
+ ","Ahh the correct fix is to call `collectLinkLibraries` on the SourceFile being compiled, not the module. Sorry for our mistake!"
+8663,"@@ -64,6 +64,7 @@ func TestConfigDefault(t *testing.T) {
+ 		""Default TaskMetadataSteadyStateRate is set incorrectly"")
+ 	assert.Equal(t, DefaultTaskMetadataBurstRate, cfg.TaskMetadataBurstRate,
+ 		""Default TaskMetadataBurstRate is set incorrectly"")
++	assert.False(t, cfg.SharedVolumeMatchFullConfig, ""Default SharedVolumeMatchFullConfig set incorrectly"")
+ }
+
+ // TestConfigFromFile tests the configuration can be read from file",Can you also modify the `TestEnvironmentConfig` in `config_test.go` to cover this?
+8664,"@@ -120,8 +120,12 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
+             }
+             restClient.sendAsync(request, new RestClient.AsyncRequestCallback() {
+
++                // TODO: Remove onSuccess for 9.0 Release.
+                 @Override
+-                public void onSuccess(RestRequest request, RestResponse response) {
++                public void onSuccess(RestRequest request, RestResponse response) {}
++
++                @Override
++                public void onResponse(RestRequest request, RestResponse response) {
+                     try {
+                         // Not a 2xx status
+                         if (!response.isSuccess()) {","There's no point ""deprecating"" this interface method (the customer still has to implement the new callback that we have introduced which makes it a breaking change). I'd make an exception and simply rename it to `onResponse`."
+8665,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.
+8666,"@@ -40,6 +40,8 @@ THE SOFTWARE.
+ #include ""hip_hcc_internal.h""
+ #include ""trace_helper.h""
+
++//TODO Add support for multiple modules
++static std::unordered_map<std::string, uintptr_t> coGlobals;
+ //TODO Use Pool APIs from HCC to get memory regions.
+
+ #include <cassert>",I know this is not new here but we need to remove this global or protect access from multiple threads.
+8667,"@@ -30,13 +30,13 @@ namespace OpenTelemetry.Trace
+         /// Enables HttpClient and HttpWebRequest instrumentation.
+         /// </summary>
+         /// <param name=""builder""><see cref=""TracerProviderBuilder""/> being configured.</param>
+-        /// <param name=""configureHttpClientInstrumentationOptions"">HttpClient configuration options.</param>
+         /// <param name=""configureHttpWebRequestInstrumentationOptions"">HttpWebRequest configuration options.</param>
++        /// <param name=""configureHttpClientInstrumentationOptions"">HttpClient configuration options.</param>
+         /// <returns>The instance of <see cref=""TracerProviderBuilder""/> to chain the calls.</returns>
+         public static TracerProviderBuilder AddHttpClientInstrumentation(
+             this TracerProviderBuilder builder,
+-            Action<HttpClientInstrumentationOptions> configureHttpClientInstrumentationOptions = null,
+-            Action<HttpWebRequestInstrumentationOptions> configureHttpWebRequestInstrumentationOptions = null)
++            Action<HttpWebRequestInstrumentationOptions> configureHttpWebRequestInstrumentationOptions = null,
++            Action<HttpClientInstrumentationOptions> configureHttpClientInstrumentationOptions = null)
+ #else
+         /// <summary>
+         /// Enables HttpClient instrumentation.","Doesn't seem any less confusing or error-prone to me. IMO the solution is to not use ""object"" in the enrich callback signatures. Type safety/compile-time checking is our friend!"
+8668,"@@ -19,6 +19,9 @@ module Travis
+         def export
+           super
+           sh.export 'TRAVIS_GO_VERSION', go_version, echo: false
++          sh.if '-z $GOMAXPROCS' do
++            sh.export 'GOMAXPROCS', '2', echo: true
++          end
+         end
+
+         def prepare",I think this should be `GOMAXPROCS=$(nproc 2>/dev/null || echo 2)`
+8669,"@@ -175,8 +175,9 @@ func (ctx *rollDPoSCtx) validateProposeBlock(blk Block, expectedProposer string)
+ 		errorLog.Msg(""error when validating the block signature"")
+ 		return false
+ 	}
+-	if producer == ctx.addr.RawAddress {
+-		// If the block is self proposed, skip validation
++	// TODO: in long term, block in process and after process should be represented differently
++	if producer == ctx.addr.RawAddress && block.WorkingSet != nil {
++		// If the block is self proposed and working set is not nil (meaning not obtained from wire), skip validation
+ 		return true
+ 	}
+ 	containCoinbase := true",Can we log if this actually happens.
+8670,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression."
+8671,"@@ -1,8 +1,10 @@
+ /* eslint-disable no-restricted-globals */
+ /* global __STORYBOOK_CLIENT_API__ */
++
+ /**
+  * External dependencies
+  */
++import lodash from 'lodash';
+ import React from 'react';
+ import { addDecorator, configure } from '@storybook/react';
+ ",It looks like the import format was only changed from one-per-line to all on one line here. Can we keep it as it was so it's easier to see what changed? It's also more consistent with how we format multiple imports in other components.
+8672,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?
+8673,"@@ -5,12 +5,16 @@ import android.content.SharedPreferences;
+ import android.graphics.Color;
+ import android.os.StrictMode;
+ import android.preference.PreferenceManager;
++import android.util.Log;
+
++import org.json.JSONException;
++import org.json.JSONObject;
+ import org.mozilla.geckoview.GeckoSessionSettings;
+ import org.mozilla.telemetry.TelemetryHolder;
+ import org.mozilla.vrbrowser.BuildConfig;
+ import org.mozilla.vrbrowser.R;
+ import org.mozilla.vrbrowser.telemetry.TelemetryWrapper;
++import org.mozilla.vrbrowser.ui.widgets.WidgetPlacement;
+ import org.mozilla.vrbrowser.utils.DeviceType;
+ import org.mozilla.vrbrowser.utils.LocaleUtils;
+ import org.mozilla.vrbrowser.utils.StringUtils;",Looks like `org.json.*` can be removed?
+8674,"@@ -890,7 +890,9 @@ public enum WidgetInfo
+ 	SECOND_TRADING_WITH_MY_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_MY_ITEMS),
+ 	SECOND_TRADING_WITH_THEIR_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_THEIR_ITEMS),
+
+-	GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIMER_GROUP_ID, WidgetID.GauntletTimer.CONTAINER);
++	GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIMER_GROUP_ID, WidgetID.GauntletTimer.CONTAINER),
++	GAUNTLET_MAP(WidgetID.GAUNTLET_MAP_GROUP_ID, WidgetID.GauntletMap.CONTAINER),
++	;
+
+ 	private final int groupId;
+ 	private final int childId;",remove the extra comma and newline
+8675,"@@ -1,3 +1,5 @@
++<% @page_title = t('blacklight.saved_searches.page_title', :application_name => application_name) %>
++
+ <div id=""content"" class=""col-md-9"">
+
+ <h1 class='page-heading'><%= t('blacklight.saved_searches.title') %></h1>",Can we try to use Ruby 1.9-style hashes?
+8676,"@@ -120,6 +120,17 @@ func RegisterHandlerDirective(dir string, setupFunc UnmarshalHandlerFunc) {
+ 	})
+ }
+
++// RegisterGlobalOption registers a unique global option opt with
++// an associated unmarshaling (setup) function. When the global
++// option opt is encountered in a Caddyfile, setupFunc will be
++// called to unmarshal its tokens.
++func RegisterGlobalOption(opt string, setupFunc UnmarshalGlobalFunc) {
++	if _, ok := registeredGlobalOptions[opt]; ok {
++		panic(""global option "" + opt + "" already registered"")
++	}
++	registeredGlobalOptions[opt] = setupFunc
++}
++
+ // Helper is a type which helps setup a value from
+ // Caddyfile tokens.
+ type Helper struct {","Terminology question - these are called ""global options"" in the code, but the parallel non-global versions of these are called ""directives""... Should this be `RegisterGlobalDirective`? Or does that have different semantics?"
+8677,"@@ -244,7 +244,7 @@ def isTypingProtected():
+ @rtype: boolean
+ """"""
+ 	focusObject=getFocusObject()
+-	if focusObject and (controlTypes.STATE_PROTECTED in focusObject.states or focusObject.role==controlTypes.ROLE_PASSWORDEDIT):
++	if focusObject and focusObject.isProtected:
+ 		return True
+ 	else:
+ 		return False","I do not care much, but you could as well just return bool(focusObject and focusObject.isProtected) here and avoid the if check? I know, really trivial."
+8678,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked"
+8679,"@@ -50,7 +50,7 @@ public class GoLanguageProvider {
+
+   @SuppressWarnings(""unchecked"")
+   public <Element> GeneratedResult generate(
+-      Element element, SnippetDescriptor snippetDescriptor, GoGapicContext context) {
++      Element element, SnippetDescriptor snippetDescriptor, Object context) {
+     GoSnippetSet<Element> snippets =
+         SnippetSet.createSnippetInterface(
+             GoSnippetSet.class,","Do DiscoveryContext and GoGapicContext have a more specific common ancestor than Object? If so, let's use that."
+8680,"@@ -119,7 +119,7 @@ module Beaker
+           :timeout              => 300,
+           :fail_mode            => 'slow',
+           :timesync             => false,
+-          :disable_iptables     => true,
++          :disable_iptables     => false,
+           :repo_proxy           => false,
+           :package_proxy        => false,
+           :add_el_extras        => false,",is this the intended behavior now?
+8681,"@@ -27,6 +27,5 @@ public class TestDutchIJ extends StemmerTestBase {
+   public void testStemming() {
+     assertStemsTo(""ijs"", ""ijs"");
+     assertStemsTo(""IJs"", ""ijs"");
+-    assertStemsTo(""Ijs"");
+   }
+ }","Hunspell/C++ stems that a bit differently from Lucene, but in a controversial way, so I removed the check instead of changing the expectation"
+8682,"@@ -172,7 +172,7 @@ func (o *opt) close() {
+ func (o *opt) runInitOnce() {
+ 	o.initOnce.Do(func() {
+ 		o.clock = &libkbfs.TestClock{}
+-		o.clock.Set(time.Unix(0, 0))
++		o.clock.Set(time.Unix(1, 0))
+ 		o.users = o.engine.InitTest(o.ver, o.blockSize,
+ 			o.blockChangeSize, o.batchSize, o.bwKBps, o.timeout, o.usernames,
+ 			o.teams, o.implicitTeams, o.clock, o.journal)",I'm curious why this is needed?
+8683,"@@ -742,7 +742,7 @@ void Combat::doCombat(Creature* caster, Creature* target) const
+ 			}
+ 			*/
+
+-			if (caster && params.distanceEffect != CONST_ANI_NONE) {
++			if (caster && target && params.distanceEffect != CONST_ANI_NONE) {
+ 				addDistanceEffect(caster, caster->getPosition(), target->getPosition(), params.distanceEffect);
+ 			}
+ 		}","I do not see how that changes anything, as the target is operated on many times before that line?"
+8684,"@@ -513,7 +513,7 @@ $(document).ready(function() {
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-geo"", url: ""#/analytics/geo"", text: ""sidebar.analytics.geo"", priority: 30});
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-sessions"", url: ""#/analytics/sessions"", text: ""sidebar.analytics.session"", priority: 20});
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-users"", url: ""#/analytics/users"", text: ""sidebar.analytics.users"", priority: 10});
+-        app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-loyalty"", url: ""#/analytics/loyalty"", text: ""sidebar.analytics.user-loyalty"", priority: 15});
++        app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-loyalty"", url: ""#/analytics/loyalty"", text: ""sidebar.analytics.visitor-loyalty"", priority: 15});
+     }
+
+     app.addAppSwitchCallback(function(appId) {",Same user/visitor thing.
+8685,"@@ -167,6 +167,13 @@ exit /B %errorlevel%
+             reg_query_command = %Q(reg query ""#{reg_key}"" /v ""RememberedPuppetAgentStartupMode"" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
+             on host, Command.new(reg_query_command, [], { :cmdexe => true })
+
++            # (PA-620) environment.bat should be run before any cmd.exe shell command
++            # in order to properly set up environment variables
++            auto_run_key = ""HKLM\\SOFTWARE\\Microsoft\\Command Processor\AutoRun""
++            # TODO What's the best way to get the actual path to the script, respecting arch differences?
++            environment_script = ""C:\\Program Files\\Puppet Labs\\Puppet\bin\\environment.bat""
++            reg_add_command = %Q(reg add ""#{auto_run_key}"" /v ""PuppetEnvironment"" /d ""#{environment_script}"")
++
+             # emit the misc/versions.txt file which contains component versions for
+             # puppet, facter, hiera, pxp-agent, packaging and vendored Ruby
+             [",This is not the correct path on all hosts. How can I correctly determine whether I will need to look in `Program Files` or `Program Files (x86)` for the script?
+8686,"@@ -73,8 +73,15 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+
+             this.maxFlushIntervalTimer.Elapsed += async (sender, args) =>
+             {
+-                await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
+-            };
++                try
++                {
++                    await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
++                }
++                catch (Exception ex)
++                {
++                    JaegerExporterEventSource.Log.FailedToSend(ex);
++                }
++            };
+         }
+
+         public Process Process { get; internal set; }","I think it would be better to move this try/catch block inside of the `FlushAsyncInternal` function as there are a few of places that can call it, eg event timer (here), AppendAsync, FlushAsync and CloseAsync."
+8687,"@@ -79,6 +79,7 @@ final class IndexingChain implements Accountable {
+
+   // Holds fields seen in each document
+   private PerField[] fields = new PerField[1];
++  private PerField[] docFields = new PerField[10];
+   private final InfoStream infoStream;
+   private final ByteBlockPool.Allocator byteBlockAllocator;
+   private final LiveIndexWriterConfig indexWriterConfig;",should we set a smaller initial size to make sure that we exercise the growing logic in our tests?
+8688,"@@ -230,3 +230,9 @@ def test_sum():
+     assert str(dt.sum(f[:])) == str(f[:].sum())
+     DT = dt.Frame(A=range(1, 10))
+     assert_equals(DT[:, f.A.sum()], DT[:, dt.sum(f.A)])
++
++def test_max():
++    assert str(dt.max(f.A)) == str(f.A.max())
++    assert str(dt.max(f[:])) == str(f[:].max())
++    DT = dt.Frame(A=range(1, 10))
++    assert_equals(DT[:, f.A.max()], DT[:, dt.max(f.A)])","Let's add a new line at the end of this file, so that the last line becomes a valid line of code."
+8689,"@@ -3131,7 +3131,7 @@ Offset<reflection::Field> FieldDef::Serialize(FlatBufferBuilder *builder,
+ }
+
+ bool FieldDef::Deserialize(Parser &parser, const reflection::Field *field) {
+-  name = parser.UnqualifiedName(field->name()->str());
++  name = field->name()->str();
+   defined_namespace = parser.current_namespace_;
+   if (!value.type.Deserialize(parser, field->type()))
+     return false;",Why was this removed?
+8690,"@@ -20,5 +20,12 @@ namespace Microsoft.CodeAnalysis.Sarif.SarifValidator
+             HelpText = ""Path of the SARIF file to validate"",
+             Required = true)]
+         public string InstanceFilePath { get; set; }
++
++        [Option(
++            'l',
++            ""log-file-path"",
++            HelpText = ""Path to SARIF log file containing the results of the validation"",
++            Default = ""sarif.log"")]
++        public string LogFilePath { get; set; }
+     }
+ }","I would prefer that this tool follow the driver framework conventions, which use OutputFilePath as an argument, take a look at AnalyzeCommandBase. You can propose changes to that if you'd like, but binskim, sqlskim, this tool should all conform (in the interests of building an eco-system with consistent command-line interface)"
+8691,"@@ -308,6 +308,18 @@ public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements Linear
+         return io.vavr.collection.Collections.fill(n, s, empty(), Queue::of);
+     }
+
++    /**
++     * Returns a Queue containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Queue
++     * @param n       The number of elements in the Queue
++     * @param element The element
++     * @return An Queue of size {@code n}, where each element is the given {@code element}.
++     */
++    public static <T> Queue<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element, empty(), Queue::of);
++    }
++
+     public static Queue<Character> range(char from, char toExclusive) {
+         return ofAll(Iterator.range(from, toExclusive));
+     }","(...), where each element ~are~ **is the** given {@code element}."
+8692,"@@ -57,7 +57,7 @@ namespace Examples.AspNetCore
+             switch (exporter)
+             {
+                 case ""jaeger"":
+-                    services.AddOpenTelemetryTracerProvider((builder) => builder
++                    services.AddOpenTelemetryTracing((builder) => builder
+                         .AddAspNetCoreInstrumentation()
+                         .AddHttpClientInstrumentation()
+                         .AddJaegerExporter(jaegerOptions =>",What if `AddOpenTelemetryTracing` is called multiple times?
+8693,"@@ -16,9 +16,10 @@ FileBasedWalIterator::FileBasedWalIterator(
+     std::shared_ptr<FileBasedWal> wal,
+     LogID startId,
+     LogID lastId)
+-        : wal_(std::move(wal))
++        : wal_(wal)
+         , currId_(startId) {
+-    if (lastId >= 0) {
++    holder_ = std::make_unique<folly::RWSpinLock::ReadHolder>(wal_->rollbackLock_);
++    if (lastId >= 0 && lastId <= wal_->lastLogId()) {
+         lastId_ = lastId;
+     } else {
+         lastId_ = wal_->lastLogId();","Why is the condition of ""lastId <= wal _-> lastLogId() "" added here?"
+8694,"@@ -13,3 +13,9 @@
+ // limitations under the License.
+
+ package model
++
++import ""path""
++
++func MakeEnvironmentURL(baseURL, environmentID string) string {
++	return path.Join(baseURL, ""settings"", ""environment"")
++}",`environmentID` is unused in MakeEnvironmentURL
+8695,"@@ -1700,10 +1700,14 @@ public class LFMainActivity extends SharedMediaActivity {
+         }
+     }
+
+-    private void checkNoSearchResults(String result){
+-        textView.setText(getString(R.string.null_search_result) + "" "" + '""' + result + '""' );
+-        textView.setTextColor(getTextColor());
+-        textView.setVisibility(View.VISIBLE);
++    private void checkNoSearchResults(String result,int length){
++        if (length>0) {
++            textView.setText(getString(R.string.null_search_result) + "" "" + '""' + result + '""');
++            textView.setTextColor(getTextColor());
++            textView.setVisibility(View.VISIBLE);
++        }
++        else
++            textView.setVisibility(View.INVISIBLE);
+     }
+
+     //region MENU",Just hide the textview
+8696,"@@ -54,7 +54,14 @@ type SessionDto struct {
+ 	Config json.RawMessage `json:""config""`
+ }
+
++// PaymentVersion represents the different payment versions we have
++type PaymentVersion string
++
++// PaymentVersionV2 represents the new pingpong version
++const PaymentVersionV2 PaymentVersion = ""v2""
++
+ // ConsumerInfo represents the consumer related information
+ type ConsumerInfo struct {
+ 	IssuerID identity.Identity `json:""issuerID""`
++	Supports PaymentVersion    `json:""supports""`
+ }","'Supports'? Very uninformative naming inside protocol. Why not just paymentVersion, or just recognise supported payment version from generic protocol version supported by the client."
+8697,"@@ -162,7 +162,11 @@ func (s *DiskSuite) TestExplicitBundleAndVerify() {
+ 	csr, pubKey, err := util.NewCSRTemplate(validSpiffeID)
+ 	require.NoError(err)
+
+-	resp, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
++	stream, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
++	require.NoError(err)
++	require.NotNil(stream)
++
++	resp, err := stream.Recv()
+ 	require.NoError(err)
+ 	require.NotNil(resp)
+ ",We should add an additional call to Recv() somewhere after here that we assert returns io.EOF.
+8698,"@@ -16,10 +16,13 @@
+
+ package azkaban.database;
+
++import static azkaban.ServiceProvider.SERVICE_PROVIDER;
++
+ import azkaban.metrics.CommonMetrics;
+ import azkaban.utils.Props;
+ import java.io.IOException;
+ import java.sql.Connection;
++import javax.inject.Inject;
+ import org.apache.commons.dbutils.DbUtils;
+ import org.apache.commons.dbutils.QueryRunner;
+ ",What is this used for?
+8699,"@@ -7,9 +7,8 @@ package net.sourceforge.pmd.lang.java.ast;
+
+ import java.util.List;
+
+-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
++public class ASTAnnotationTypeDeclaration extends ASTAnyTypeDeclaration {
+
+-    private JavaQualifiedName qualifiedName;
+
+     public ASTAnnotationTypeDeclaration(int id) {
+         super(id);",this is a breaking API change. Do we really need to do it in 6.2.0? Can't we just deprecate the methods?
+8700,"@@ -123,6 +123,12 @@ public class DatabaseHelper extends DaoMaster.OpenHelper {
+                     }
+                 }
+                 break;
++            case 10:
++                AllergenDao.dropTable(db, true);
++                AllergenDao.createTable(db, true);
++                AllergenNameDao.dropTable(db, true);
++                AllergenNameDao.createTable(db, true);
++                break;
+         }
+     }
+ ",Is dropping the **Allergen table** necessary? Can't we just add the two new columns to the existing table using a raw query?
+8701,"@@ -13,11 +13,11 @@ feature ""Subscriber views completed trails"" do
+
+     within "".completed-trails"" do
+       expect(page).to have_content(just_finished_trail.name)
+-      expect(page).to have_no_content(incomplete_trail.name)
++      expect(page).not_to have_content(incomplete_trail.name)
+     end
+
+     within "".incomplete-trails"" do
+-      expect(page).to have_no_content(just_finished_trail.name)
++      expect(page).not_to have_content(just_finished_trail.name)
+       expect(page).to have_content(incomplete_trail.name)
+     end
+ ",I'm confused why the expectations here would have inverted? Seems unrelated to topic stuff. Can you clarify?
+8702,"@@ -127,12 +127,13 @@ std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) {
+ std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId,
+                                             EdgeType edgeType,
+                                             int64_t version) {
++    int64_t storageVer = std::numeric_limits<int64_t>::max() - version;
+     std::string key;
+     key.reserve(128);
+     key.append(kEdgesTable.data(), kEdgesTable.size());
+     key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
+     key.append(reinterpret_cast<const char*>(&edgeType), sizeof(edgeType));
+-    key.append(reinterpret_cast<const char*>(&version), sizeof(version));
++    key.append(reinterpret_cast<const char*>(&storageVer), sizeof(storageVer));
+     return key;
+ }
+ ",I am very sorry that I neglected to resolve the conflict and did not fully unit test edge
+8703,"@@ -25,13 +25,14 @@ import org.apache.iceberg.catalog.TableIdentifier;
+ import org.apache.iceberg.exceptions.AlreadyExistsException;
+ import org.apache.iceberg.exceptions.CommitFailedException;
+ import org.apache.iceberg.exceptions.NoSuchTableException;
++import org.apache.iceberg.io.CloseableGroup;
+ import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+-public abstract class BaseMetastoreCatalog implements Catalog {
++public abstract class BaseMetastoreCatalog extends CloseableGroup implements Catalog {
+   private static final Logger LOG = LoggerFactory.getLogger(BaseMetastoreCatalog.class);
+
+   @Override","I think closeable should be handled by the concrete impl of a catalog and not by the base class, I don't think all catalogs must implement closeable by design. This should be done via composition rather than inheritance. Additionally, I don't know what the effect of this change is on other catalogs so this feels a bit on the risky side."
+8704,"@@ -9,11 +9,13 @@ void ConvolutionLayer<Dtype>::compute_output_shape() {
+   const int* kernel_shape_data = this->kernel_shape_.cpu_data();
+   const int* stride_data = this->stride_.cpu_data();
+   const int* pad_data = this->pad_.cpu_data();
++  const int* dilation_data = this->dilation_.cpu_data();
+   this->output_shape_.clear();
+   for (int i = 0; i < this->num_spatial_axes_; ++i) {
+     // i + 1 to skip channel axis
+     const int input_dim = this->input_shape(i + 1);
+-    const int output_dim = (input_dim + 2 * pad_data[i] - kernel_shape_data[i])
++    const int kernel_extent = dilation_data[i] * (kernel_shape_data[i] - 1) + 1;
++    const int output_dim = (input_dim + 2 * pad_data[i] - kernel_extent)
+         / stride_data[i] + 1;
+     this->output_shape_.push_back(output_dim);
+   }",Should this be `const`?
+8705,"@@ -6,7 +6,7 @@ namespace Benchmarks.Trace
+     {
+         private static void Main(string[] args)
+         {
+-            BenchmarkRunner.Run<SpanBenchmark>();
++            BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+         }
+     }
+ }",Can we also add the Exporters here by using `DefaultConfig.AddExporter(...)`? At least the Datadog exporter that can't be configured from the command line...
+8706,"@@ -77,7 +77,7 @@ int main(int argc, char *argv[]) {
+
+     // When using checkpoint states, skip training as those could be the result
+     // of checkpointing by steps.
+-    if (!opts->has_string(""ckpt_dir"")){
++    if (!opts->has_string(""no_model1_train"")){
+       model_1->train( pb_model.num_epochs() );
+     }
+     // Evaluate model 1 unless it is set to skip","@JaeseungYeom I believe you had set this in a previous commit to, by default, not train model1 when loading from ckpt. Would it work for you to have this as a command line option `--no_model1_train` instead of the default behavior?"
+8707,"@@ -86,6 +86,11 @@ namespace Microsoft.Rest.Generator.Ruby.TemplateModels
+                 return ""Array<Integer>"";
+             }
+
++            if (type == PrimaryType.TimeSpan)
++            {
++                return ""Duration""; //TODO: Is this a real Ruby type...?
++            }
++
+             if (compositeType != null)
+             {
+                 return compositeType.Name;","@devigned, please clarify"
+8708,"@@ -19,6 +19,7 @@ import (
+ 	""reflect""
+ 	""testing""
+ 	""time""
++	""github.com/jmcvetta/randutil""
+ )
+
+ func TestConcurrentCommand_UnmarshalJSON(t *testing.T) {",File is not `gofmt`-ed with `-s` (from `gofmt`)
+8709,"@@ -127,7 +127,7 @@ def GenerateConfig(context):
+                 'items': [{
+                     'key': 'startup-script',
+                     'value': """"""#!/bin/bash
+-sudo apt-get install -y unzip
++sudo apt-get install -y unzip git
+ sudo apt-get install -y libmysqlclient-dev
+ sudo apt-get install -y python-pip python-dev
+ ",Should we break this up into a separate line?
+8710,"@@ -57,6 +57,7 @@ var _ = Describe(""conformance tests"", func() {
+ 	Measure(specName, func(b Benchmarker) {
+
+ 		name := fmt.Sprintf(""cluster-%s"", util.RandomString(6))
++		setEnvVar(""USE_CI_ARTIFACTS"", ""true"", false)
+ 		kubernetesVersion := e2eConfig.GetVariable(KubernetesVersion)
+ 		flavor := clusterctl.DefaultFlavor
+ 		if useCIArtifacts {","Why the override on the env variable, wouldn't we want to use the value set from Prow?"
+8711,"@@ -0,0 +1,13 @@
++widget :projected_monthly_revenue do
++  key ""74b333b94cd772ee15be863e646f8ca1e535f1c6""
++  type ""number_and_secondary""
++  data do
++    {
++      value:
++        IndividualPlan.prime_basic.projected_monthly_revenue +
++        IndividualPlan.prime_workshops.projected_monthly_revenue +
++        IndividualPlan.prime_with_mentoring.projected_monthly_revenue +
++        TeamPlan.instance.projected_monthly_revenue
++    }
++  end
++end","I don't see anything here that excludes people on a Team plan from from the revenue report. I see that TeamPlans are counted below, but the individual subscribers on the plan would still be included."
+8712,"@@ -1078,11 +1078,8 @@ public final class Vector<T> implements IndexedSeq<T>, Serializable {
+
+     @Override
+     public Vector<T> subSequence(int beginIndex, int endIndex) {
+-        if ((beginIndex >= 0) && (beginIndex <= endIndex) && (endIndex <= length())) {
+-            return slice(beginIndex, endIndex);
+-        } else {
+-            throw new IndexOutOfBoundsException(""subSequence("" + beginIndex + "", "" + endIndex + "") on Vector of size "" + length());
+-        }
++        Collections.subSequenceRangeCheck(beginIndex, endIndex, length());
++        return slice(beginIndex, endIndex);
+     }
+
+     @Override",I know that we do not pull the last bit of performance out of the JVM but it is more robust and removes redundant code.
+8713,"@@ -130,6 +130,11 @@ public abstract class ScheduledReporter implements Closeable, Reporter {
+                                 ScheduledExecutorService executor,
+                                 boolean shutdownExecutorOnStop,
+                                 Set<MetricAttribute> disabledMetricAttributes) {
++
++        if (registry == null) {
++            throw new IllegalArgumentException(""MetricRegistry must not be null !!!"");
++        }
++
+         this.registry = registry;
+         this.filter = filter;
+         this.executor = executor == null ? createDefaultExecutor(name) : executor;","I'd make this a `throw new NullPointerException(""registry == null"");` instead"
+8714,"@@ -163,10 +163,12 @@ type Config struct {
+ 	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;tcp:22,udp:68;die-on-fail""`
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;tcp:2379,tcp:2380,tcp:4001,tcp:7001,udp:53,udp:67;die-on-fail""`
+
+-	UsageReportingEnabled bool   `config:""bool;true""`
+-	ClusterGUID           string `config:""string;baddecaf""`
+-	ClusterType           string `config:""string;""`
+-	CalicoVersion         string `config:""string;""`
++	UsageReportingEnabled          bool          `config:""bool;true""`
++	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`
++	UsageReportingIntervalSecs     time.Duration `config:""seconds;86400""`
++	ClusterGUID                    string        `config:""string;baddecaf""`
++	ClusterType                    string        `config:""string;""`
++	CalicoVersion                  string        `config:""string;""`
+
+ 	DebugMemoryProfilePath          string        `config:""file;;""`
+ 	DebugDisableLogDropping         bool          `config:""bool;false""`",Does adding things here require us also to extend the FelixConfiguration resource in libcalico-go?
+8715,"@@ -31,7 +31,11 @@ import (
+ 	""github.com/pkg/errors""
+ )
+
+-const currentCNISpec = ""0.3.1""
++const (
++	currentCNISpec = ""0.3.1""
++	currentCNIVersion = ""2018.08.0""
++	CNIGitHash = ""a134a973585b560439ed25ec3857e4789bfeb89f""
++)
+
+ // CNIClient defines the method of setting/cleaning up container namespace
+ type CNIClient interface {",does this need to be public?
+8716,"@@ -15,6 +15,7 @@
+ from . import encode
+ from . import number_types as N
+
++FILEIDENTIFIER_LENGTH = 4
+
+ class Table(object):
+     """"""Table wraps a byte slice and provides read access to its data.",Please import this from a pre-existing definition.
+8717,"@@ -0,0 +1,18 @@
++class WebOptions:
++    def load(self, loader):
++        loader.add_option(
++            ""web_open_browser"", bool, True,
++            ""Start a browser.""
++        )
++        loader.add_option(
++            ""web_debug"", bool, False,
++            ""Mitmweb debugging.""
++        )
++        loader.add_option(
++            ""web_port"", int, 8081,
++            ""Mitmweb port.""
++        )
++        loader.add_option(
++            ""web_iface"", str, ""127.0.0.1"",
++            ""Mitmweb interface.""
++        )",File name does not represent class name... if we ever cared for such things?
+8718,"@@ -39,7 +39,7 @@ Rails.application.routes.draw do
+       get :languages
+       get :commits_by_project_chart
+       get :commits_by_language_chart
+-      post :make_spammer
++      post :label_as_spammer
+       get 'edit_privacy'   => 'privacy#edit',   as: :edit_account_privacy
+       put 'update_privacy' => 'privacy#update', as: :account_privacy
+     end","I don't mind the `make_spammer` route name. It seems to more clearly convey that the state of the account will change. The ""label as"" route name seems less definitive, as if one is simply adding something to the account -- a new label -- instead of changing the status of the account."
+8719,"@@ -46,7 +46,8 @@ var loggingCmd = &cobra.Command{
+ 	Long:  `Enable/disable and configure Algorand remote logging`,
+ 	Args:  validateNoPosArgsFn,
+ 	Run: func(cmd *cobra.Command, _ []string) {
+-		cfg, err := logging.EnsureTelemetryConfig(nil, """")
++		dataDir := ensureSingleDataDir()
++		cfg, err := logging.EnsureTelemetryConfig(&dataDir, """")
+
+ 		// If error loading config, can't disable / no need to disable
+ 		if err != nil {","This exits if `-d` not specified which isn't exactly what we want, right?"
+8720,"@@ -313,3 +313,10 @@ def sizeof_fmt(num, suffix='B'):
+             return ""%3.1f%s%s"" % (num, unit, suffix)
+         num /= 1024.0
+     return ""%.1f%s%s"" % (num, 'Yi', suffix)
++
++
++def escape_like(string, escape_char='*'):
++    """"""Escape the string parameter used in SQL LIKE expressions.""""""
++    return string.replace(escape_char, escape_char * 2) \
++                 .replace('%', escape_char + '%') \
++                 .replace('_', escape_char + '_')",So a `*` becomes `**`? How does this affect the query? If I have `csordas*marton` as filter and I have `csordas*marton` and `csordasFOOBARmarton` as run names in the database I get only the first as result?
+8721,"@@ -191,11 +191,14 @@ InterimResult::buildIndex(const std::string &vidColumn) const {
+         auto name = schema->getFieldName(i);
+         if (vidColumn == name) {
+             VLOG(1) << ""col name: "" << vidColumn << "", col index: "" << i;
+-            if (schema->getFieldType(i).type != SupportedType::VID) {
++            if (schema->getFieldType(i).type != SupportedType::INT &&
++                schema->getFieldType(i).type != SupportedType::VID &&
++                schema->getFieldType(i).type != SupportedType::TIMESTAMP) {
+                 return Status::Error(
+-                        ""Build internal index for input data failed. ""
+-                        ""The specific vid column `%s' is not type of VID, column index: %ul."",
+-                        vidColumn.c_str(), i);
++                    ""Build internal index for input data failed. ""
++                    ""The specific vid column `%s' is not type of VID, INT or TIMESTAMP, ""
++                    ""column index: %u."",
++                    vidColumn.c_str(), i);
+             }
+             vidIndex = i;
+         }","I want to know in which situation you need to traverse from ""Timestamp"" data....."
+8722,"@@ -687,7 +687,11 @@ func (ctx *signingCtx) buildBodyDigest() error {
+ 			if !aws.IsReaderSeekable(ctx.Body) {
+ 				return fmt.Errorf(""cannot use unseekable request body %T, for signed request with body"", ctx.Body)
+ 			}
+-			hash = hex.EncodeToString(makeSha256Reader(ctx.Body))
++			hasBytes, err := makeSha256Reader(ctx.Body)
++			if err != nil {
++				return err
++			}
++			hash = hex.EncodeToString(hasBytes)
+ 		}
+
+ 		if includeSHA256Header {",nit: hasBytes should be hashBytes
+8723,"@@ -171,6 +171,15 @@ def perform_analysis(args, skip_handler, context, actions, metadata):
+         config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
+             ReturnValueCollector.checker_analyze)
+
++    # Statistics collector checkers must be explicitly disabled
++    # as they trash the output.
++    if ""clangsa"" in analyzers:
++        config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
++            SpecialReturnValueCollector.checker_collect, False)
++
++        config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
++            ReturnValueCollector.checker_collect, False)
++
+     # Save some metadata information.
+     versions = __get_analyzer_version(context, config_map)
+     metadata['versions'].update(versions)",If I enable the clangsa analyzer with the `--stats` flag the checkers will be disabled even if they were enabled previously. I think we should check here if stats was enabled. `if 'stats_enabled' in args and args.stats_enabled` we should leave them enabled.
+8724,"@@ -1041,6 +1041,9 @@ func DoEstimateGas(ctx context.Context, b Backend, args CallArgs, blockNrOrHash
+
+ 	// 3. calculate the fee and normalize by the default gas price
+ 	fee := core.CalculateRollupFee(*args.Data, uint64(gasUsed), dataPrice, executionPrice).Uint64() / defaultGasPrice
++	if fee < 21000 {
++		fee = 21000
++	}
+ 	return (hexutil.Uint64)(fee), nil
+ }
+ ",Note that we probably should set the default gasPrice to `0.1 gwei` considering our minimum gas limit has to be 21k. At 21k the minimum fee would end up being `0.000021 ETH` which is just a little too high
+8725,"@@ -132,7 +132,9 @@ func validateTrustedOperators(o *Options) error {
+ 		if o.TrustedKeys == nil {
+ 			o.TrustedKeys = make([]string, 0, 4)
+ 		}
+-		o.TrustedKeys = append(o.TrustedKeys, opc.Issuer)
++		if !opc.StrictSigningKeyUsage {
++			o.TrustedKeys = append(o.TrustedKeys, opc.Subject)
++		}
+ 		o.TrustedKeys = append(o.TrustedKeys, opc.SigningKeys...)
+ 	}
+ 	for _, key := range o.TrustedKeys {","So during a config reload, this function is invoked, but prior to that the o.TrustedKeys slice is set to nil, so this code would work. However, I am wondering what happens to s.trustedKeys, I am not sure this is handled at all. (same with the new map you are adding). I am not sure if this is supposed to be supported with a config reload, but just wondering if this is not putting things into a bad state."
+8726,"@@ -64,15 +64,12 @@ func SecurityHandler(authenticators map[string]auth.Authenticator, next http.Han
+ 	}
+
+ 	return func(w http.ResponseWriter, r *http.Request) {
+-
+ 		tokenHeader := r.Header.Get(""Authorization"")
+ 		tokens := strings.Split(tokenHeader, "" "")
+
+ 		if len(tokens) < 2 {
+ 			w.WriteHeader(http.StatusUnauthorized)
+-			json.NewEncoder(w).Encode(&api.ClusterResponse{
+-				Error: fmt.Sprintf(""Access denied, token is malformed""),
+-			})
++			fmt.Fprintf(w, ""Access denied token is empty"")
+ 			return
+ 		}
+ 		token := tokens[1]","I think the logic should be to check for token len of 0 then check for token len of less than 2. The way the logic is now, it is hard to determine if it is empty or malformed."
+8727,"@@ -267,6 +267,15 @@ void wlr_output_set_subpixel(struct wlr_output *output,
+ 	wlr_output_schedule_done(output);
+ }
+
++void wlr_output_set_format(struct wlr_output *output,
++		enum wl_shm_format format) {
++	if (output->format == format) {
++		return;
++	}
++
++	output->format = format;
++}
++
+ void wlr_output_set_description(struct wlr_output *output, const char *desc) {
+ 	if (output->description != NULL && desc != NULL &&
+ 			strcmp(output->description, desc) == 0) {",Nothing would change here even if this `if` statement were removed.
+8728,"@@ -38,10 +38,11 @@ assert_pyspark_version()
+ from databricks.koalas.frame import DataFrame
+ from databricks.koalas.indexes import Index, MultiIndex
+ from databricks.koalas.series import Series
+-from databricks.koalas.typedef import Col, pandas_wraps
++from databricks.koalas.typedef import pandas_wraps
++from databricks.koalas.sql import sql
+
+ __all__ = ['read_csv', 'read_parquet', 'to_datetime', 'from_pandas',
+-           'get_dummies', 'DataFrame', 'Series', 'Index', 'MultiIndex', 'Col', 'pandas_wraps',
++           'get_dummies', 'DataFrame', 'Series', 'Index', 'MultiIndex', 'pandas_wraps',
+            'sql', 'range', 'concat', 'melt']
+
+ ",`sql` module is imported later.
+8729,"@@ -69,6 +69,15 @@ class GARPNHead(RPNTestMixin, GuidedAnchorHead):
+                            cfg,
+                            rescale=False):
+         cfg = self.test_cfg if cfg is None else cfg
++
++        # refactor the nms cfg
++        # this is used for avoid breaking change
++        if 'nms' not in cfg:
++            cfg.nms = dict(type='nms', iou_threshold=cfg.nms_thr)
++            cfg.max_per_img = cfg.max_num
++
++        assert cfg.nms.get('type', 'nms') == 'nms', 'GARPNHead only support ' \
++            'naive nms.'
+         mlvl_proposals = []
+         for idx in range(len(cls_scores)):
+             rpn_cls_score = cls_scores[idx]","I think it's strange, whether `assert cfg.nms.type == 'nms'` would be better."
+8730,"@@ -33,14 +33,7 @@ import globalize from '../scripts/globalize';
+             });
+
+             options.buttons = items;
+-
+-            return dialog.show(options).then(function (result) {
+-                if (result === 'ok') {
+-                    return Promise.resolve();
+-                }
+-
+-                return Promise.reject();
+-            });
++            return dialog.show(options);
+         }
+
+         return Promise.resolve();","Doing a quick search, it looks like there are other places that would be handling this promise rejection. How did you confirm this is not needed?"
+8731,"@@ -68,7 +68,7 @@ func TestCreateContract(t *testing.T) {
+ 	_, err = accountutil.LoadOrCreateAccount(sm, addr.String())
+ 	require.NoError(err)
+ 	hu := config.NewHeightUpgrade(&cfg.Genesis)
+-	stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hash.ZeroHash256)
++	stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hu.IsPost(config.Fairbank, 0), hash.ZeroHash256)
+ 	contract := addr.Bytes()
+ 	var evmContract common.Address
+ 	copy(evmContract[:], contract[:])",let's use greenland in the unit tests as well
+8732,"@@ -48,8 +48,10 @@ def reportPassThrough(treeInterceptor,onlyIfChanged=True):
+ 			nvwave.playWaveFile(sound)
+ 		else:
+ 			if treeInterceptor.passThrough:
++				# Translators: The mode to interact with controls in documents
+ 				ui.message(_(""Focus mode""))
+ 			else:
++				# Translators: The mode that presents text in a flat representation that can be navigated with the cursor keys like in a text document
+ 				ui.message(_(""Browse mode""))
+ 		reportPassThrough.last = treeInterceptor.passThrough
+ reportPassThrough.last = False",Please split this into two lines
+8733,"@@ -77,6 +77,12 @@ namespace MvvmCross.Platform.Tvos.Views
+
+         public virtual bool ShowChildView(UIViewController viewController)
+         {
++            if (SelectedIndex > 5) // when more menu item is currently visible, selected index has value higher than 5
++            {
++                MoreNavigationController.PushViewController(viewController, true);
++                return true;
++            }
++
+             var navigationController = SelectedViewController as UINavigationController;
+
+             // if the current selected ViewController is not a NavigationController, then a child cannot be shown",Is there any variable available instead of hardcoding 5?
+8734,"@@ -385,9 +385,7 @@ public class LoginActivity extends AccountAuthenticatorActivity
+
+ 	@Override
+ 	protected void onActivityResult(int requestCode, int resultCode, Intent data) {
+-		if (requestCode == PasscodeManager.PASSCODE_REQUEST_CODE && resultCode == Activity.RESULT_OK) {
+-			webviewHelper.onNewPasscode();
+-		} else if (requestCode == SPRequestHandler.IDP_REQUEST_CODE) {
++		if (requestCode == SPRequestHandler.IDP_REQUEST_CODE) {
+             spRequestHandler.handleIDPResponse(resultCode, data);
+         } else {
+ 	        super.onActivityResult(requestCode, resultCode, data);",The onNewPasscode method was taking care of creating the user account. Now the user account will already have been created.
+8735,"@@ -29,7 +29,8 @@ import (
+ )
+
+ const (
+-	MaxChainNameLength = 28
++	MaxChainNameLength       = 28
++	defaultPostWriteInterval = 50 * time.Millisecond
+ )
+
+ var (","This is really a minimum, isn't it, so `minPostWriteInterval` perhaps? IIUC it never gets used as a default, because the default IptablesPostWriteCheckInterval is 1s, which is larger than this."
+8736,"@@ -1,11 +1,9 @@
+ <ul class=""bookmarkTools nav nav-pills"">
+-  <li class=""cite"">
+-    <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
+-  </li>
+-
+-  <li class=""email"">
+-    <%= link_to t('blacklight.tools.email'), email_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), :class=>""btn btn-default"", :id => ""emailLink"", :data => {:ajax_modal => ""trigger""} %>
+-  </li>
++  <% BookmarksController.document_actions.each do |action| %>
++    <li class=""#{action}"">
++      <%= link_to t(""blacklight.tools.#{action}""), self.send(""#{action}_bookmarks_path""), {:id => ""#{action}Link"", :name => action, :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
++    </li>
++  <% end %>
+
+   <%= render_marc_tools %>
+ </ul>",I wonder if you can use the controller's context instead of using it explicitly?
+8737,"@@ -94,6 +94,7 @@ func (e *Executor) ensureCanaryClean(ctx context.Context) model.StageStatus {
+
+ 	resources := strings.Split(value, "","")
+ 	if err := e.removeCanaryResources(ctx, resources); err != nil {
++		e.LogPersister.AppendErrorf(""Unable to remove canary resources: %v"", err)
+ 		return model.StageStatus_STAGE_FAILURE
+ 	}
+ 	return model.StageStatus_STAGE_SUCCESS",Can you add this log for `baseline` too?
+8738,"@@ -148,6 +148,10 @@ Blockly.Msg.CANNOT_DELETE_VARIABLE_PROCEDURE = 'Can\'t delete the variable ""%1""
+ /// dropdown choice - Delete the currently selected variable.
+ Blockly.Msg.DELETE_VARIABLE = 'Delete the ""%1"" variable';
+
++// Broadcast Message creation
++/// dropdown choice - Create a new message.
++Blockly.Msg.NEW_MESSAGE = 'New message...';
++
+ // Colour Blocks.
+ /// url - Information about colour.
+ Blockly.Msg.COLOUR_PICKER_HELPURL = 'https://en.wikipedia.org/wiki/Color';","Let's call this ""NEW_BROADCAST_MESSAGE"". Msg.NEW_MESSAGE will be confusing down the line."
+8739,"@@ -128,11 +128,17 @@ type Container struct {
+ 	// is handled properly so that the state storage continues to work.
+ 	KnownStatusUnsafe ContainerStatus `json:""KnownStatus""`
+
++	// TransitionDependenciesMap is a map of the dependent container status to other
++	// dependencies that must be satisfied in order for this container to transition.
++	TransitionDependenciesMap map[ContainerStatus]TransitionDependencySet
++
+ 	// TransitionDependencySet is a set of dependencies that must be satisfied
+ 	// in order for this container to transition.  Each transition dependency
+ 	// specifies a resource upon which the transition is dependent, a status
+ 	// that depends on the resource, and the state of the dependency that
+ 	// satisfies.
++	// Deprecated: Use TransitionDependenciesMap instead. TransitionDependencySet is
++	// retained for compatibility with old state files.
+ 	TransitionDependencySet TransitionDependencySet `json:""TransitionDependencySet""`
+
+ 	// SteadyStateDependencies is a list of containers that must be in ""steady state"" before","A better way to do this (in your future PR) would be to: 1. get rid of `TransitionDependencySet` altogether 2. tag `TransitionDependenciesMap` as `""TransitionDependencySet""` in JSON 3. update the JSON marshaler to deal with `""TransitionDependencySet""` tag. If it's a map, no big deal. Else, construct the `TransitionDependenciesMap` map. Doing that would mean that we don't need to have duplicate code, names for this."
+8740,"@@ -81,10 +81,10 @@ def file_list_to_folder(df: pd.DataFrame, limit: int, offset: int) -> dict:
+             axis=1
+         ).to_dict(orient='records')
+         objects = folder[~folder.logical_key.str.contains('/')].to_dict(orient='records')
+-        returned_results = len(prefixes) + len(objects)
+-    except AttributeError as err:
+-        # Pandas will raise an attribute error if the DataFrame has
+-        # no rows with a non-null logical_key. We expect that case if
++
++    except (AttributeError, KeyError) as err:
++        # Pandas will raise an AttributeError or KeyError if the DataFrame
++        # has no rows with a non-null logical_key. We expect that case if
+         # either: (1) the package is empty (has zero package entries)
+         # or, (2) zero package entries match the prefix filter. The
+         # choice to allow this to raise the exception instead of","It's very error-prone to have so large `try` clause with such non-specific exceptions handled. Consider rewriting it with either of these: 1. Check that expected columns are present in `DataFrame` (`{'physical_key', 'logical_key', 'size'}.issubset(df.columns)`). 2. Normalizing output of query by using `COALESCE()` (or normalizing `DataFrame` itself?). Also it looks like a row with package metadata isn't used here, so might make sense to filter out it with `WHERE logical_key IS NOT MISSING`."
+8741,"@@ -116,6 +116,7 @@ var (
+ 		MirrorQueueLength      int
+ 		PullRequestQueueLength int
+ 		PreferredLicenses      []string
++		DisableHttpGit         bool
+
+ 		// Repository editor settings
+ 		Editor struct {",Change to `DisableHTTPGit`
+8742,"@@ -71,10 +71,9 @@ class UserMailer < ActionMailer::Base
+   end
+
+   def feedback_notification(recipient, plan, requestor)
+-    return unless @user.org.present? && recipient.active?
++    return unless recipient.active?
+
+     @user = requestor
+-    @org = @user.org
+     @plan = plan
+     @recipient = recipient
+ ",org was not used in the mail content
+8743,"@@ -128,6 +128,9 @@ export default Service.extend({
+         return this.lazyLoader.loadStyle('dark', 'assets/ghost-dark.css', true).then(() => {
+             $('link[title=dark]').prop('disabled', !nightShift);
+             $('link[title=light]').prop('disabled', nightShift);
++        }).catch((err) => {
++            $('link[title=dark]').prop('disabled', true);
++            $('link[title=light]').prop('disabled', false);
+         });
+     }
+ });","Is this gonna cause a lint issue, because of unused var? Maybe we should log it out?"
+8744,"@@ -321,7 +321,11 @@ module Beaker
+     def hack_etc_hosts hosts, opts
+       etc_hosts = ""127.0.0.1\tlocalhost localhost.localdomain\n""
+       hosts.each do |host|
+-        etc_hosts += ""#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n""
++        if host['hypervisor'] == 'docker'
++          etc_hosts += ""#{host['docker_container'].json[""NetworkSettings""][""IPAddress""]}\t#{host.name}\n""
++        else
++          etc_hosts += ""#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n""
++        end
+       end
+       hosts.each do |host|
+         set_etc_hosts(host, etc_hosts)","My understanding is that this will always be set to the actual containers IP, and never to the `DOCKER_HOST` IP if that env_var is set."
+8745,"@@ -49,11 +49,14 @@ function ResetButton( { children } ) {
+ 	 * the navigate call starting, we will just set a debounce to keep the spinner for 3 seconds.
+ 	 */
+ 	const debouncedSetInProgress = useDebounce( setInProgress, 3000 );
+-	const mediatedSetInProgress = ( bool ) => bool ? setInProgress( true ) : debouncedSetInProgress( false );
++	const mediatedSetInProgress = useCallback(
++		( bool ) => bool ? setInProgress( true ) : debouncedSetInProgress( false ),
++		[ debouncedSetInProgress ]
++	);
+
+ 	useEffect( () => {
+ 		mediatedSetInProgress( isDoingReset || isNavigatingToPostResetURL );
+-	}, [ isDoingReset, isNavigatingToPostResetURL ] );
++	}, [ isDoingReset, isNavigatingToPostResetURL, mediatedSetInProgress ] );
+
+ 	useEffect( () => {
+ 		const handleCloseModal = ( event ) => {",this dependency to a callback also has to be a callback (eslint now warns us)
+8746,"@@ -95,7 +95,7 @@ func (c *CStorPoolController) reconcile(key string) error {
+ 	return c.updateStatus(csp)
+ }
+
+-func (c *CStorPoolController) destroy(csp *apis.NewTestCStorPool) error {
++func (c *CStorPoolController) destroy(csp *apis.CStorPoolInstance) error {
+ 	var phase apis.CStorPoolPhase
+
+ 	// DeletePool is to delete cstor zpool.",directory name as well needs change..
+8747,"@@ -348,7 +348,8 @@ class PluginManager
+     public function findByIdentifier($identifier)
+     {
+         if (!isset($this->plugins[$identifier])) {
+-            $identifier = $this->normalizeIdentifier($identifier);
++            $code = $this->getIdentifier($identifier);
++            $identifier = $this->normalizeIdentifier($code);
+         }
+
+         if (!isset($this->plugins[$identifier])) {",Why is the getIdentifier() call required here?
+8748,"@@ -92,7 +92,11 @@ std::string MakeCamel(const std::string &in, bool first) {
+ }
+
+ void Parser::Message(const std::string &msg) {
++#ifndef FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
+   error_ = file_being_parsed_.length() ? AbsolutePath(file_being_parsed_) : """";
++#else // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
++  error_ = file_being_parsed_.length() ? file_being_parsed_ : """";
++#endif // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
+   // clang-format off
+   #ifdef _WIN32
+     error_ += ""("" + NumToString(line_) + "")"";  // MSVC alike",Looks more appropriate to stick this in `AbsolutePath`.. actually that already has `FLATBUFFERS_NO_ABSOLUTE_PATH_RESOLUTION`
+8749,"@@ -1,4 +1,8 @@
+-const html = require('yo-yo')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl
+
+ module.exports = (props) => {
+   const input = html`",this might interfere when we have multiple dashboards. maybe ActionBrowseTagline needs to be a Component so we can store the reference to the element on it.
+8750,"@@ -376,8 +376,15 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock.
+ 	context kbfsblock.Context) (
+ 	buf []byte, serverHalf kbfscrypto.BlockCryptKeyServerHalf, err error) {
+ 	ctx = rpc.WithFireNow(ctx)
++	var res keybase1.GetBlockRes
+ 	b.log.LazyTrace(ctx, ""BServer: Get %s"", id)
++
++	// Once the block has been retrieved, cache it.
+ 	defer func() {
++		// But don't cache it if it's archived data.
++		if res.Status == keybase1.BlockStatus_ARCHIVED {
++			return
++		}
+ 		b.log.LazyTrace(ctx, ""BServer: Get %s done (err=%v)"", id, err)
+ 		if err != nil {
+ 			b.deferLog.CWarningf(",Should this be inside the `else` below and right after `CDebugf` so that we still get the logs?
+8751,"@@ -540,4 +540,5 @@ var errorCodeMap = map[string]gcerrors.ErrorCode{
+ 	dyn.ErrCodeTransactionCanceledException:             gcerr.FailedPrecondition,
+ 	dyn.ErrCodeTransactionInProgressException:           gcerr.InvalidArgument,
+ 	dyn.ErrCodeIdempotentParameterMismatchException:     gcerr.InvalidArgument,
++	""ValidationException"":                               gcerr.InvalidArgument,
+ }",Weird they don't expose the type for dynamo and this seems a pretty common error.
+8752,"@@ -33,10 +33,11 @@ namespace OpenTelemetry.Trace.Configuration
+         /// Enables OpenTelemetry.
+         /// </summary>
+         /// <param name=""configureOpenTelemetryBuilder"">Function that configures OpenTelemetryBuilder.</param>
++        /// <returns><see cref=""IDisposable""/> to be disposed on application shutdown.</returns>
+         /// <remarks>
+         /// Basic implementation only. Most logic from TracerBuilder will be ported here.
+         /// </remarks>
+-        public static void EnableOpenTelemetry(Action<OpenTelemetryBuilder> configureOpenTelemetryBuilder)
++        public static IDisposable EnableOpenTelemetry(Action<OpenTelemetryBuilder> configureOpenTelemetryBuilder)
+         {
+             var openTelemetryBuilder = new OpenTelemetryBuilder();
+             configureOpenTelemetryBuilder(openTelemetryBuilder);",@cijothomas I couldn't make the unit tests work without a way to destroy the ActivityListener we create internally so I return it as an IDisposable here. But we'll also need to also stop any ActivityProcessors/ActivityExporters on application shutdown right?
+8753,"@@ -592,7 +592,7 @@ class Commands:
+
+     @command('wp')
+     async def payto(self, destination, amount, fee=None, feerate=None, from_addr=None, from_coins=None, change_addr=None,
+-                    nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, wallet: Abstract_Wallet = None):
++                    nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, addtransaction=True, wallet: Abstract_Wallet = None):
+         """"""Create a transaction. """"""
+         self.nocheck = nocheck
+         tx_fee = satoshis(fee)","The default should be ""False"", as ""True"" would be a significant change in behaviour."
+8754,"@@ -161,8 +161,16 @@ class Package(object):
+
+         # Serialize DataFrame to chosen format
+         if enumformat is PackageFormat.HDF5:
+-            with pd.HDFStore(storepath, mode='w') as store:
+-                store[self.DF_NAME] = df
++            # HACK: Force the use of old pickle to ensure Python 2/3 compatibility.
++            from pandas.compat import cPickle
++            old_protocol = cPickle.HIGHEST_PROTOCOL
++            try:
++                cPickle.HIGHEST_PROTOCOL = 2
++                with pd.HDFStore(storepath, mode='w') as store:
++                    store[self.DF_NAME] = df
++            finally:
++                cPickle.HIGHEST_PROTOCOL = old_protocol
++
+         elif enumformat is PackageFormat.PARQUET:
+             # switch parquet lib
+             parqlib = self.get_parquet_lib()","since goal is to restore old_protocol, shouldn't we get it from pandas if possible? e.g. this will break if their source code changes."
+8755,"@@ -299,7 +299,7 @@ class ErrorBaseline
+                     ""\n"" .
+                     '  php-version=""' .
+                     ""\n    "" .
+-                    implode(""\n    "", explode('&#10;&#9;', $matches[2])) .
++                    str_replace('&#10;&#9;', ""\n    "", $matches[2]).
+                     ""\n"" .
+                     '  ""' .
+                     ""\n"" .",This should consume less resources because str_replace don't need to assign arrays with all the values
+8756,"@@ -240,6 +240,10 @@ static bool check_arg_types(pass_opt_t* opt, ast_t* params, ast_t* positional,
+     {
+       errorframe_t frame = NULL;
+       ast_error_frame(&frame, arg, ""argument not a subtype of parameter"");
++      ast_error_frame(&frame, arg, ""argument type is %s"",
++                      ast_print_type(a_type));
++      ast_error_frame(&frame, arg, ""parameter type is %s"",
++                      ast_print_type(p_type));
+       errorframe_append(&frame, &info);
+
+       if (ast_childcount(arg) > 1)","It would be better to pass `param` as the second argument here, so that the parameter declaration is printed alongside the type. Same thing for the changes in `ffi.c` and `lambda.c`."
+8757,"@@ -27,6 +27,7 @@ import org.joda.time.DateTime;
+
+ import azkaban.utils.JSONUtils;
+
++
+ public class Trigger {
+
+   private static Logger logger = Logger.getLogger(Trigger.class);","Do we need to set the members to final like submitTime, submitUser ...? They are only used by getter method."
+8758,"@@ -13,7 +13,7 @@ class MediaLibraryItem extends SystemMediaLibraryItem
+ {
+     public function __construct()
+     {
+-        traceLog('Class Cms\Classes\MediaLibraryItem has been deprecated, use System\Classes\MediaLibraryItem instead.');
++        traceLog('Class ' . __CLASS__ . ' has been deprecated, use ' . SystemMediaLibraryItem::class . ' instead.');
+         parent::__construct(...func_get_args());
+     }
+ }","That makes this error message incorrect; if someone has extended Cms\Classes\MediaLibraryItem, then this error message will read ""Class My\Classes\CustomMediaLibraryItem has been deprecated""."
+8759,"@@ -97,6 +97,6 @@ class Factory implements \Zend\ServiceManager\FactoryInterface
+         $config = $sm->get('VuFind\Config')->get('config');
+
+         // Create service:
+-        return new \VuFind\Mailer\Mailer($this->getTransport($config));
++        return new \VuFind\Mailer\Mailer($this->getTransport($config), $config);
+     }
+ }","Is it worth injecting the whole configuration object for just one setting? Would it be more generic to pass an $options array with the override_from in it? I'm not completely opposed to passing $config, but since we've avoided it so far, it seems like it would be cleaner to maintain that separation. Simply adding a getOptions method to the factory would make this a lot more readable."
+8760,"@@ -44,3 +44,14 @@ const (
+ 	SDA_PIN = 26
+ 	SCL_PIN = 27
+ )
++
++// SPI pins
++const (
++	SPI0_SCK_PIN  = 25
++	SPI0_MOSI_PIN = 23
++	SPI0_MISO_PIN = 24
++
++	SPI1_SCK_PIN  = 2
++	SPI1_MOSI_PIN = 3
++	SPI1_MISO_PIN = 4
++)","Just curious: where do these pin numbers come from? I see you took the SPI0 pin numbers from the Arduino board layout which is good, but I can't find such a relation for `SPI1`."
+8761,"@@ -450,10 +450,14 @@ public final class MethodTypeResolution {
+         Class<?> contextClass = context.getType();
+
+         // search the class
+-        for (Method method : contextClass.getDeclaredMethods()) {
+-            if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) {
+-                result.add(getTypeDefOfMethod(context, method, typeArguments));
++        try {
++            for (Method method : contextClass.getDeclaredMethods()) {
++                if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) {
++                    result.add(getTypeDefOfMethod(context, method, typeArguments));
++                }
+             }
++        } catch (final LinkageError ignored) {
++            // TODO : This is an incomplete classpath, report the missing class
+         }
+
+         // search it's supertype","Isn't that already too late? I'd expect, that the LinkageError occurs the first time, we have the class instance (the classloader tried to load the class) - or do we get a partially linked class back, and we get the exception when retrieving the methods?"
+8762,"@@ -31,7 +31,7 @@ import (
+ const (
+ 	supportedVersion  = 0
+ 	maxVersion        = 254
+-	traceparentHeader = ""traceparent""
++	TraceparentHeader = ""Traceparent""
+ )
+
+ type httpTraceContextPropagator struct{}",nit:s/Traceparent/traceparent/ - As per the spec header name is all lowercase.
+8763,"@@ -484,3 +484,16 @@ type ErrDockerfileNotFound struct {
+ func (e *ErrDockerfileNotFound) Error() string {
+ 	return fmt.Sprintf(""no Dockerfiles found within %s or a sub-directory level below"", e.dir)
+ }
++
++// RelPath returns the path relative to the current working directory.
++func RelPath(fullPath string) (string, error) {
++	wkdir, err := os.Getwd()
++	if err != nil {
++		return """", fmt.Errorf(""get working directory: %w"", err)
++	}
++	path, err := filepath.Rel(wkdir, fullPath)
++	if err != nil {
++		return """", fmt.Errorf(""get relative path of file: %w"", err)
++	}
++	return path, nil
++}",We need to have unit tests for it since it is now a public function. Also I'm not a fan for making this movement since `relPath` doesn't consume any info in this pkg.
+8764,"@@ -5,16 +5,11 @@
+  */
+ package edu.harvard.iq.dataverse.datasetutility;
+
+-import edu.harvard.iq.dataverse.DataFile;
++import edu.harvard.iq.dataverse.*;
+ import edu.harvard.iq.dataverse.DataFile.ChecksumType;
+-import edu.harvard.iq.dataverse.DataFileServiceBean;
+-import edu.harvard.iq.dataverse.Dataset;
+-import edu.harvard.iq.dataverse.DatasetServiceBean;
+-import edu.harvard.iq.dataverse.DatasetVersion;
+-import edu.harvard.iq.dataverse.EjbDataverseEngine;
+-import edu.harvard.iq.dataverse.FileMetadata;
+-import edu.harvard.iq.dataverse.PermissionServiceBean;
++import edu.harvard.iq.dataverse.api.Files;
+ import edu.harvard.iq.dataverse.api.Util;
++import edu.harvard.iq.dataverse.authorization.users.AuthenticatedUser;
+ import edu.harvard.iq.dataverse.authorization.users.User;
+ import edu.harvard.iq.dataverse.engine.command.Command;
+ import edu.harvard.iq.dataverse.engine.command.DataverseRequest;","We generally avoid wildcard imports. If you feel like changing it back, great. Otherwise, no big deal."
+8765,"@@ -51,7 +51,7 @@
+ // 	dispatcher := yarpc.NewDispatcher(yarpc.Config{
+ // 		Name: ""myservice"",
+ // 		Outbounds: yarpc.OUtbounds{
+-// 			{Unary: myserviceOutbound},
++// 			""outboundservice"": {Unary: myserviceOutbound},
+ // 		},
+ // 	})
+ //",We also have a typo on the line above! OUt or Out?
+8766,"@@ -7,5 +7,7 @@
+ <%= @step.action_name %>
+ <%= generate_approve_url(@step) %>
+
+-<%= t(""mailer.step_mailer.proposal_notification.cta"") %>
+-<%= proposal_url(@proposal, anchor: ""comments"") %>
++<%= t(""mailer.view_request_cta"") %>
++<%= proposal_url(@proposal) %>
++
++<%= t(""mailer.footer"", feedback_url: feedback_url) %>",OH! These are text.... (Ignore above)
+8767,"@@ -98,7 +98,6 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+   private List<Expression> filterExpressions = null;
+   private Filter[] pushedFilters = NO_FILTERS;
+   private final boolean localityPreferred;
+-  private final int batchSize;
+   private final boolean readTimestampWithoutZone;
+
+   // lazy variables",How was this set before? Was it just ignored?
+8768,"@@ -0,0 +1,12 @@
++class CreditCardsController < ApplicationController
++  def update
++    customer = Stripe::Customer.retrieve(current_user.stripe_customer_id)
++    customer.card = params['stripe_token']
++    begin
++      customer.save
++      redirect_to my_account_path, notice: I18n.t('subscriptions.flashes.update.success')
++    rescue Stripe::CardError => error
++      redirect_to my_account_path, notice: error.message
++    end
++  end
++end",Should we `save!` here?
+8769,"@@ -284,7 +284,7 @@ void TServerSocket::listen() {
+   hints.ai_family = PF_UNSPEC;
+   hints.ai_socktype = SOCK_STREAM;
+   hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
+-  sprintf(port, ""%d"", port_);
++  snprintf(port, sizeof(""65535""), ""%d"", port_);
+
+   // If address is not specified use wildcard address (NULL)
+   TGetAddrInfoWrapper info(address_.empty() ? NULL : &address_[0], port, &hints);",sizeof(port) seems ever-so-slightly clearer.
+8770,"@@ -116,6 +116,12 @@ type Rule struct {
+ 	// conjunction with NetworkPolicySpec/ClusterNetworkPolicySpec.AppliedTo.
+ 	// +optional
+ 	AppliedTo []NetworkPolicyPeer `json:""appliedTo,omitempty""`
++	// SourceGroups is a list of ClusterGroup names which must be set as the
++	// source for this rule.
++	SourceGroups []string `json:""sourceGroups,omitempty""`
++	// DestinationGroups is a list of ClusterGroup names which must be set as the
++	// destination for this rule.
++	DestinationGroups []string `json:""destinationGroups,omitempty""`
+ }
+
+ // NetworkPolicyPeer describes the grouping selector of workloads.",Not sure if this has been discussed. I wonder why SourceGroups and DestinationGroups are not in From and To NetworkPolicyPeer as NetworkPolicyPeer already describes the source/destination of the traffic.
+8771,"@@ -151,6 +151,19 @@ class Completer(QObject):
+             except KeyError:
+                 # No completion model for this section/option.
+                 model = None
++        elif completion == usertypes.Completion.keybinding:
++            # look for --mode to provide mode-specific binding completions
++            # since flags are ignored by most completers, we need to re-parse
++            parts, cursor_part = self._filter_cmdline_parts(self.split(),
++                                                            cursor_part,
++                                                            ignore_flags=False)
++            if parts[cursor_part - 1].startswith(""--mode=""):
++                mode = parts[cursor_part - 1][7:]  # strip --mode=
++                key = parts[cursor_part]
++            else:
++                mode = 'normal'
++                key = parts[cursor_part - 1]
++            model = instances.get(completion)[mode][key]
+         else:
+             model = instances.get(completion)
+ ",This doesn't account for `:bind --mode caret ...` (i.e. `--mode caret` instead of `--mode=caret`; both work). Do you see an easy way to make that work?
+8772,"@@ -41,7 +41,8 @@ var (
+ 	errorPriority = map[reflect.Type]int{
+ 		reflect.TypeOf(&p.ShardOwnershipLostError{}):             0,
+ 		reflect.TypeOf(&p.CurrentWorkflowConditionFailedError{}): 1,
+-		reflect.TypeOf(&p.ConditionFailedError{}):                2,
++		reflect.TypeOf(&p.WorkflowConditionFailedError{}):        2,
++		reflect.TypeOf(&p.ConditionFailedError{}):                3,
+ 	}
+
+ 	errorDefaultPriority = math.MaxInt64",Is this map used for durable state anywhere? If so we probably want to keep ConditionFailedError as 2
+8773,"@@ -25,6 +25,7 @@ type roundTripperOpts struct {
+ }
+
+ var dialAddr = quic.DialAddr
++var methodHEAD = ""HEAD""
+
+ // client is a HTTP2 client doing QUIC requests
+ type client struct {",You can use `http.MethodHead` here.
+8774,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.session.remote;
++
++public class SessionTest {
++
++}",And another empty test. Please remove until there's content.
+8775,"@@ -2,9 +2,9 @@ define([""localassetmanager""], function(localassetmanager) {
+     ""use strict"";
+
+     function processDownloadStatus(apiClient, serverInfo, options) {
+-        return console.log(""[mediasync] Begin processDownloadStatus""), localassetmanager.resyncTransfers().then(function() {
++        return console.debug(""mediasync: begin processDownloadStatus""), localassetmanager.resyncTransfers().then(function() {
+             return localassetmanager.getServerItems(serverInfo.Id).then(function(items) {
+-                console.log(""[mediasync] Begin processDownloadStatus getServerItems completed"");
++                console.debug(""mediasync: begin processDownloadStatus getServerItems completed"");
+                 var p = Promise.resolve(),
+                     cnt = 0;
+                 return items.filter(function(item) {","You really didn't need to do any of these, we need to remove the API client from source eventually anyway."
+8776,"@@ -58,6 +58,9 @@ import org.tikv.kvproto.Pdpb.TsoResponse;
+
+ public class PDClient extends AbstractGRPCClient<PDBlockingStub, PDStub>
+     implements ReadOnlyPDClient {
++
++  private TiSession session;
++
+   private RequestHeader header;
+   private TsoRequest tsoReq;
+   private volatile LeaderWrapper leaderWrapper;",seems pretty strange here because TiSession contains PDClient.
+8777,"@@ -73,4 +73,11 @@ class NotesControllerTest < ActionDispatch::IntegrationTest
+     assert_response :success
+     assert_select ""table.note_list tr"", :count => 11
+   end
++
++  def test_empty_page
++    user = create(:user)
++    get user_notes_path(:display_name => user.display_name)
++    assert_response :success
++    assert_select ""h4"", :html => ""No notes""
++  end
+ end",I created a test method for this scenario. Would you normally split it out like that or bundle this into one of the existing test methods? I'm more accustomed to creating lots of separate `it` blocks in nested `context` blocks in rspec
+8778,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent
+8779,"@@ -5463,6 +5463,13 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable,
+     throw new IllegalArgumentException(""number of documents in the index cannot exceed "" + actualMaxDocs + "" (current document count is "" + pendingNumDocs.get() + ""; added numDocs is "" + addedNumDocs + "")"");
+   }
+
++  /**
++   * Returns the number of documents in the index including documents are being added (i.e., reserved).
++   */
++  public long getPendingNumDocs() {
++    return pendingNumDocs.get();
++  }
++
+   /** Returns the highest <a href=""#sequence_number"">sequence number</a> across
+    *  all completed operations, or 0 if no operations have finished yet.  Still
+    *  in-flight operations (in other threads) are not counted until they finish.",Maybe add `@lucene.experimental`? We are exposing (slightly) internal details about `IndexWriter` so maybe we need to reserve the right to change this API in the future ...
+8780,"@@ -676,7 +676,10 @@ module Beaker
+         def sleep_until_puppetdb_started(host, nonssl_port = nil, ssl_port = nil)
+           nonssl_port = options[:puppetdb_port_nonssl] if nonssl_port.nil?
+           ssl_port = options[:puppetdb_port_ssl] if ssl_port.nil?
+-          curl_with_retries(""start puppetdb"", host, ""http://localhost:#{nonssl_port}"", 0, 120)
++          endpoint = 'status/v1/services/puppetdb-status'
++          retry_on(host,
++                   ""curl -m 1 http://localhost:#{nonssl_port}/#{endpoint} | grep '\""state\"":\""running\""'"",
++                   {:max_retries => 120})
+           curl_with_retries(""start puppetdb (ssl)"",
+                             host, ""https://#{host.node_name}:#{ssl_port}"", [35, 60])
+         end","@johnduarte I know this isn't part of your code change, but it seems to me that this `curl_with_retries` is not necessary. If the `retry_on` host command is successful, isn't puppetdb ostensibly listening to the ssl port as well? What do you think about removing that `curl_with_retries` after the `retry_on`?"
+8781,"@@ -17,13 +17,15 @@ package labelindex
+ import (
+ 	log ""github.com/Sirupsen/logrus""
+
++	""github.com/projectcalico/felix/set""
+ 	""github.com/projectcalico/libcalico-go/lib/selector""
++	""github.com/projectcalico/libcalico-go/lib/selector/parser""
+ )
+
+ type Index interface {
+ 	UpdateSelector(id interface{}, sel selector.Selector)
+ 	DeleteSelector(id interface{})
+-	UpdateLabels(id interface{}, labels map[string]string)
++	UpdateLabels(id interface{}, labels parser.Labels)
+ 	DeleteLabels(id interface{})
+ }
+ ","Does an empty struct really take less storage than a bool? I guess it must be, or else you wouldn't have changed this, but I'm curious about the detail."
+8782,"@@ -259,6 +259,12 @@ class EditableTextWithoutAutoSelectDetection(EditableText):
+ 	This should be used when an object does not notify of selection changes.
+ 	""""""
+
++	def waitForAndSpeakSelectionChange(self, oldTextInfo):
++		api.processPendingEvents(processEventQueue=False)
++		newInfo=self.makeTextInfo(textInfos.POSITION_SELECTION)
++		speech.speakSelectionChange(oldTextInfo,newInfo)
++		braille.handler.handleCaretMove(self)
++
+ 	def script_caret_changeSelection(self,gesture):
+ 		try:
+ 			oldInfo=self.makeTextInfo(textInfos.POSITION_SELECTION)","nit: This should perhaps be called `waitForAndReportSelectionChange`, as it affects braille as well, not just speech."
+8783,"@@ -127,10 +127,14 @@ class ProxyListenerSNS(ProxyListener):
+
+             elif req_action == 'CreateTopic':
+                 topic_arn = aws_stack.sns_topic_arn(req_data['Name'][0])
+-                self._extract_tags(topic_arn, req_data)
++                tag_error_response = self._extract_tags(topic_arn, req_data, True)
++                # in case if there is an error it returns an error , other wise it will continue as expected.
++                if not tag_error_response:
++                    return make_error(code=400, code_string='InvalidParameter',
++                                  message='Topic already exists with different tags')
+
+             elif req_action == 'TagResource':
+-                self._extract_tags(topic_arn, req_data)
++                self._extract_tags(topic_arn, req_data, False)
+                 return make_response(req_action)
+
+             elif req_action == 'UntagResource':","nit: I suggest that we rename `tag_error_response` to `tag_resource_success`, as later in line 132 we're returning an error if this value is *not* truthy."
+8784,"@@ -0,0 +1,15 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Shopsys\ShopBundle\Controller\Styleguide;
++
++use Shopsys\ShopBundle\Controller\Front\FrontBaseController;
++
++class StyleguideController extends FrontBaseController
++{
++    public function styleguideAction()
++    {
++        return $this->render('@ShopsysShop/Styleguide/styleguide.html.twig');
++    }
++}",I am missing return typehint
+8785,"@@ -0,0 +1,8 @@
++_base_ = [
++    'retinanet_pvt-t_fpn_1x_coco.py',
++]
++model = dict(
++    backbone=dict(
++        num_layers=[3, 4, 6, 3],
++        init_cfg=dict(checkpoint='https://github.com/whai362/PVT/'
++                      'releases/download/v2/pvt_small.pth')))",_base_ = 'retinanet_pvt-t_fpn_1x_coco.py'
+8786,"@@ -394,11 +394,12 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+     private class SwapJWTForAccessTokenTask extends BaseFinishAuthFlowTask<LoginOptions> {
+
+         @Override
+-        protected TokenEndpointResponse performRequest(LoginOptions options) {
++        protected TokenEndpointResponse performRequest(LoginOptions options) throws Exception {
+             try {
+                 return OAuth2.swapJWTForTokens(HttpAccess.DEFAULT, new URI(options.loginUrl), options.jwt);
+             } catch (Exception e) {
+-                Log.w(""OAuth.SwapJWT"", e);
++                onAuthFlowError(""jwt_oauth_error"", e.getLocalizedMessage());
++                callback.finish();
+             }
+             return null;
+         }","We should remove `throws Exception` here, since we're catching it anyway and triggering `onAuthFlowError`."
+8787,"@@ -0,0 +1,18 @@
++package ps
++
++import ""gx/ipfs/QmepvmmYNM6q4RaUiwEikQFhgMFHXg2PLhx2E9iaRd3jmS/go-libp2p-pubsub""
++
++// Publisher publishes to pubsub topics
++type Publisher struct {
++	pubsub *pubsub.PubSub
++}
++
++// NewPublisher builds a new publisher
++func NewPublisher(sub *pubsub.PubSub) *Publisher {
++	return &Publisher{pubsub: sub}
++}
++
++// Publish publishes to a pubsub topic
++func (s *Publisher) Publish(topic string, data []byte) error {
++	return s.pubsub.Publish(topic, data)
++}","a super thin wrapper like this makes me think we should consider not having it, instead just defining in the plumbing.api the publisher and subscriber interfaces we expect a ps dependency passed in to support and then to pass calls directly to that thing rather than through this wrapper"
+8788,"@@ -93,7 +93,7 @@ public class Docker {
+       throw new WebDriverException(""Unable to pull container: "" + name);
+     }
+
+-    LOG.info(String.format(""Pull of %s:%s complete"", name, tag));
++    LOG.fine(String.format(""Pull of %s:%s complete"", name, tag));
+
+     return findImage(new ImageNamePredicate(name, tag))
+         .orElseThrow(() -> new DockerException(",Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.
+8789,"@@ -67,10 +67,12 @@ setup(
+         ""configargparse>=0.10, <0.11"",
+         ""construct>=2.5.2, <2.6"",
+         ""cryptography>=1.3, <1.5"",
++        ""cssutils>=1.0.1, <1.1"",
+         ""Flask>=0.10.1, <0.12"",
+         ""h2>=2.4.0, <3"",
+         ""html2text>=2016.1.8, <=2016.5.29"",
+         ""hyperframe>=4.0.1, <5"",
++        ""jsbeautifier>=1.6.3""
+         ""lxml>=3.5.0, <=3.6.0"",  # no wheels for 3.6.1 yet.
+         ""Pillow>=3.2, <3.4"",
+         ""passlib>=1.6.5, <1.7"",",We should set a 1.7 upper bound for this as well. :smiley:
+8790,"@@ -39,11 +39,14 @@ import Spinner from 'GoogleComponents/spinner';
+ import SettingsOverlay from 'GoogleComponents/settings/settings-overlay';
+ import GenericError from 'GoogleComponents/notifications/generic-error';
+
+-const { Component, Fragment } = wp.element;
+-const { __, sprintf } = wp.i18n;
+-const { filter, map } = lodash;
+-const { applyFilters } = wp.hooks;
+-const { withFilters } = wp.components;
++/**
++ * WordPress dependencies
++ */
++import { Component, Fragment } from '@wordpress/element';
++import { __, sprintf } from '@wordpress/i18n';
++import { filter, map } from 'lodash';
++import { applyFilters } from '@wordpress/hooks';
++import { withFilters } from '@wordpress/components';
+
+ /**
+  * A single module. Keeps track of its own active state and settings.",Lodash mixed in with WordPress dependencies
+8791,"@@ -22,10 +22,10 @@ class StripeEvents
+     if subscription = Subscription.find_by(stripe_id: stripe_subscription.id)
+       subscription
+     else
+-      Airbrake.notify_or_ignore(
++      Honeybadger.notify(
+         error_message: ""No subscription found for #{stripe_subscription.id}"",
+         error_class: ""StripeEvents"",
+-        parameters: @event.to_hash
++        context: @event.to_hash,
+       )
+       nil
+     end",Put a comma after the last parameter of a multiline method call.
+8792,"@@ -0,0 +1,11 @@
++describe ""User can manage their own profile"" do
++  it ""allows editing of name"" do
++    user = create(:user)
++    login_as(user)
++    visit ""/me""
++    fill_in :first_name, with: ""Some""
++    fill_in :last_name, with: ""Body""
++    click_button ""Update profile""
++    expect(page).to have_content(""Welcome, Some Body <#{user.email_address}>"")
++  end
++end",perhaps we should test that users cannot edit the profiles of others?
+8793,"@@ -43,7 +43,7 @@ class TestMasterSecretLogger(tservers.ServerTestBase):
+
+             tls.log_master_secret.close()
+             with open(logfile, ""rb"") as f:
+-                assert f.read().count(b""CLIENT_RANDOM"") >= 2
++                assert f.read().count(b""SERVER_HANDSHAKE_TRAFFIC_SECRET"") >= 2
+
+         tls.log_master_secret = _logfun
+ ",Does this mean the content changed with the new pyopenssl version? Is Wireshark already compatible with this new format?
+8794,"@@ -618,7 +618,7 @@ func TestCachedBatch(t *testing.T) {
+ }
+
+ func TestSTXCachedBatch(t *testing.T) {
+-	ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))})
++	ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))}, config.Default.DB)
+ 	testCachedBatch(ws, t, true)
+ }
+ ",line is 147 characters (from `lll`)
+8795,"@@ -65,6 +65,7 @@ confspec = ConfigObj(StringIO(
+ 	#possible log levels are DEBUG, IO, DEBUGWARNING, INFO
+ 	loggingLevel = string(default=""INFO"")
+ 	showWelcomeDialogAtStartup = boolean(default=true)
++	showSpeechViewerAtStartup = boolean(default=false)
+
+ # Speech settings
+ [speech]","Perhaps move this option into a separate speechViewer section, as we are planning to also save position information as well."
+8796,"@@ -22,4 +22,9 @@ interface SegmentProductsQueryInterface
+      * @return array
+      */
+     public function getProductsByType(SegmentId $segmentId, string $type): array;
++
++    /**
++     * @return array
++     */
++    public function getAllEditedProducts(SegmentId $segmentId, ?\DateTime $dateTime = null): array;
+ }",This is not a segment responsibility this query should be in exporter-File module
+8797,"@@ -174,6 +174,8 @@ class ClangTidy(analyzer_base.SourceAnalyzer):
+
+             analyzer_cmd.append(self.source_file)
+
++            analyzer_cmd.extend(['--export-fixes', result_handler.fixit_file])
++
+             analyzer_cmd.append(""--"")
+
+             analyzer_cmd.append('-Qunused-arguments')",Did you measure the performance with and without this option. Do we want to export fixits even if the `clang-apply-replacements` tool is not available in the user's PATH?
+8798,"@@ -19,12 +19,12 @@ package v1alpha1
+ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1""
+ 	""github.com/pkg/errors""
+-	""k8s.io/apimachinery/pkg/apis/meta/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+
+ // Get is spc client implementation to get disk.
+ func (s *SpcObjectClient) Get(name string) (*Disk, error) {
+-	spcDiskList := s.Spc.Spec.Disks.DiskList
++	spcDiskList := s.Spc.Spec.BlockDevices.BlockDeviceList
+ 	var diskName string
+ 	for _, disk := range spcDiskList {
+ 		if name == disk {",What if we do not change this file ? Are we using this `pkg/disk/v1alpha1` elsewhere for block device requirement?
+8799,"@@ -27,7 +27,7 @@ module Bolt
+         non_interactive: true
+       }
+
+-      options[:port] = @port if @port
++      options[:port] = port if port
+       options[:password] = @password if @password
+       options[:keys] = @key if @key
+       options[:verify_host_key] = if @insecure",regarding dropping the port/host/uri methods on Nod: this would `options[:port] = target.port if target.port`
+8800,"@@ -4,9 +4,10 @@ import java.io.File;
+ import java.io.IOException;
+
+ public class FileTypeDetection {
+-
+-    public static String determineFileType(File file) throws IOException {
+-        return FileUtil.determineFileType(file, file.getName());
++    // Question: why do we need this utility? - as opposed to just calling the
++    // static method in FileUtil directly? - L.A.
++    public static String determineFileType(File file, String fileName) throws IOException {
++        return FileUtil.determineFileType(file, fileName);
+     }
+
+ }","good question - I vote we just remove, up to you if you want to handle in this PR though. (as it would require changing the places you call it; maybe moving the test? Though my guess is if we don't now, we never will."
+8801,"@@ -15,6 +15,10 @@ module Travis
+           super << ""--gemfile-"" << config[:gemfile].to_s
+         end
+
++        def use_directory_cache?
++          super or data.cache?(:bundler)
++        end
++
+         def setup
+           super
+           setup_bundler",This is so that if we turn on bundler caching globally it still won't affect python etc. Same inheritance logic as for the cache slug.
+8802,"@@ -58,7 +58,8 @@ namespace Nethermind.Synchronization.Peers
+         public bool CanBeAllocated(AllocationContexts contexts)
+         {
+             return !IsAsleep(contexts) &&
+-                   !IsAllocated(contexts);
++                   !IsAllocated(contexts) &&
++                   this.SupportsAllocation(contexts);
+         }
+
+         [MethodImpl(MethodImplOptions.Synchronized)]",[You can ignore it] Maybe a better method name would be IsSupported or HasSupportForAllocation?
+8803,"@@ -32,7 +32,7 @@ def escape_and_globify(pattern_string):
+         pattern_string (str): The pattern string of which to make a regex.
+
+     Returns:
+-        str: The pattern string, escaped except for the ""*"", which is
++        str: The pattern string, escaped except for the ""\*"", which is
+             transformed into "".+"" (match on one or more characters).
+     """"""
+     if pattern_string is None:","Why is this changed to `\*`? The behavior of the code on line 42, shows that `*` is what's handled?"
+8804,"@@ -117,6 +117,16 @@ module.exports = BaseTest.extend({
+         TestCase.assertEqual(Realm.defaultPath, newPath, ""defaultPath should have been updated"");
+     },
+
++    testRealmSchemaVersion: function() {
++        TestCase.assertEqual(Realm.schemaVersion(Realm.defaultPath), 0xFFFFFFFFFFFFFFFF);
++
++        var realm = new Realm({schema: []});
++        TestCase.assertEqual(Realm.schemaVersion(Realm.defaultPath), 0);
++
++        realm = new Realm({schema: [], schemaVersion: 2, path: 'another.realm'});
++        TestCase.assertEqual(Realm.schemaVersion('another.realm'), 2);
++    },
++
+     testRealmCreate: function() {
+         var realm = new Realm({schema: [schemas.IntPrimary, schemas.AllTypes, schemas.TestObject]});
+ ",I think this should either return `-1` or throw. I think my vote is on the former.
+8805,"@@ -54,6 +54,7 @@ DEFAULT_SETTINGS = {
+         'kinto.core.events.setup_transaction_hook',
+     ),
+     'event_listeners': '',
++    'heartbeat_timeout_seconds': 5,
+     'logging_renderer': 'kinto.core.logs.ClassicLogRenderer',
+     'newrelic_config': None,
+     'newrelic_env': 'dev',","I am confused, I've read 2, 3 and 5 seconds in various places"
+8806,"@@ -91,7 +91,14 @@ func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error)
+ 			fcgiBackend.SetSendTimeout(rule.SendTimeout)
+
+ 			var resp *http.Response
+-			contentLength, _ := strconv.Atoi(r.Header.Get(""Content-Length""))
++
++			var contentLength int64
++			// if ContentLength is already set
++			if r.ContentLength > 0 {
++				contentLength = r.ContentLength
++			} else {
++				contentLength, _ = strconv.ParseInt(r.Header.Get(""Content-Length""), 10, 64)
++			}
+ 			switch r.Method {
+ 			case ""HEAD"":
+ 				resp, err = fcgiBackend.Head(env)",Any particular reason you chose int64 instead of int? This requires adding type conversions throughout the code below.
+8807,"@@ -280,14 +280,16 @@ class CommandTest(QuiltTestCase):
+
+         mock_input.return_value = old_refresh_token
+
+-        with pytest.raises(command.CommandException, match='Invalid team name'):
++        with pytest.raises(command.CommandException,
++                match='The team you specified is not a valid team.'):
+             command.login('fo!o')
+
+         mock_open.assert_not_called()
+         mock_login_with_token.assert_not_called()
+
+     def test_login_with_token_invalid_team(self):
+-        with pytest.raises(command.CommandException, match='Invalid team name'):
++        with pytest.raises(command.CommandException,
++                match='The team you specified is not a valid team.'):
+             command.login_with_token('123', 'fo!o')
+
+     @patch('quilt.tools.command._save_auth')",this string should really be a local constant. it's repeated below.
+8808,"@@ -194,6 +194,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+                 int i => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: Convert.ToInt64(i)),
+                 long l => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: l),
+                 float f => new JaegerTag(attribute.Key, JaegerTagType.DOUBLE, vDouble: Convert.ToDouble(f)),
++                short sh => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: Convert.ToInt64(sh)),
+                 double d => new JaegerTag(attribute.Key, JaegerTagType.DOUBLE, vDouble: d),
+                 bool b => new JaegerTag(attribute.Key, JaegerTagType.BOOL, vBool: b),
+                 _ => new JaegerTag(attribute.Key, JaegerTagType.STRING, vStr: attribute.Value.ToString()),","Number types are hard  . Should we be considering byte/sbyte? What about unsigned variants that would otherwise fit in a signed 64 bit integer like UInt16, UInt32?"
+8809,"@@ -170,7 +170,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [MemberData(nameof(HostHeaderData))]
+         public void ValidHostHeadersParsed(string host)
+         {
+-            Assert.True(HttpUtilities.IsValidHostHeader(host));
++            HttpUtilities.ValidateHostHeader(host);
++            Assert.True(true);
+         }
+
+         public static TheoryData<string> HostHeaderInvalidData",`Assert.True(true)`...   xunit used to have Assert.DoesNotThrow
+8810,"@@ -3,8 +3,9 @@ if ENV[""S3_BUCKET_NAME""] && ENV[""S3_ACCESS_KEY_ID""] && ENV[""S3_SECRET_ACCESS_KEY
+     bucket: ENV[""S3_BUCKET_NAME""],
+     s3_credentials: {
+       access_key_id: ENV[""S3_ACCESS_KEY_ID""],
+-      secret_access_key: ENV[""S3_SECRET_ACCESS_KEY""]
++      secret_access_key: ENV[""S3_SECRET_ACCESS_KEY""],
+     },
++    s3_region: ""us-east-1"",
+     s3_permissions: :private,
+     storage: :s3,
+   )",should this be an env var like the other `S3_*` values?
+8811,"@@ -9,3 +9,12 @@ export function assign(obj, props) {
+ 	for (let i in props) obj[i] = props[i];
+ 	return /** @type {O & P} */ (obj);
+ }
++
++/**
++ * Remove a child node from its parent if attached.
++ * @param {Node} node The node to remove
++ */
++export function removeNode(node) {
++	let parentNode = node.parentNode;
++	if (parentNode) parentNode.removeChild(node);
++}","If you do go this route, I think it would be worth adding a note here that IE 11 is the only reason why we're not using the more obvious `node.remove()`."
+8812,"@@ -26,7 +26,7 @@ class RecommendationChecker(checkers.BaseChecker):
+             ""consider-iterating-dictionary"",
+             ""Emitted when the keys of a dictionary are iterated through the .keys() ""
+             ""method. It is enough to just iterate through the dictionary itself, as ""
+-            'in ""for key in dictionary"".',
++            'in ""for key in dictionary"" or ""if key in dictionary"".',
+         ),
+         ""C0206"": (
+             ""Consider iterating with .items()"",",The added text doesn't really match why it's possible. Maybe it would be better to name that as a separate case for this checker? (e.g. dict lookup is quicker than list comparison)
+8813,"@@ -63,7 +63,7 @@ class Image implements EntityFileUploadInterface
+     protected $position;
+
+     /**
+-     * @var \Datetime
++     * @var \DateTime
+      *
+      * @ORM\Column(type=""datetime"")
+      */",just whether we are not missing some doctrine extension because above this attribute is nullable position and it shows int instead of int|null but maybe for lvl2 it is OK
+8814,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.
+8815,"@@ -1030,7 +1030,7 @@ bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, con
+                                      ""vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have ""
+                                      ""either VkImageDrmFormatModifierListCreateInfoEXT or ""
+                                      ""VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain"");
+-                } else if (drm_format_mod_list != nullptr) {
++                } else if (drm_format_mod_explict != nullptr) {
+                     image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
+                 } else if (drm_format_mod_list != nullptr) {
+                     for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {",":grimacing: yikes, thanks for catching this!"
+8816,"@@ -0,0 +1,10 @@
++using System;
++using MvvmCross.Droid.Support.V7.RecyclerView.Model;
++
++namespace MvvmCross.Droid.Support.V7.RecyclerView
++{
++    public interface IMvxRecyclerAdapterBindableHolder
++    {
++        event Action<MvxViewHolderBindedEventArgs> MvxViewHolderBinded;
++    }
++}",`Binded` is weird. I think it needs to be something with `Bound` in it (and drop the `Mvx` bit) like `ViewHolderBound` or something.
+8817,"@@ -84,8 +84,8 @@ func importPoolBuilder(cStorPool *apis.CStorPool, cachefileFlag bool) []string {
+ }
+
+ // CreatePool creates a new cStor pool.
+-func CreatePool(cStorPool *apis.CStorPool) error {
+-	createAttr := createPoolBuilder(cStorPool)
++func CreatePool(cStorPool *apis.CStorPool, diskList []string) error {
++	createAttr := createPoolBuilder(cStorPool, diskList)
+ 	glog.V(4).Info(""createAttr : "", createAttr)
+
+ 	stdoutStderr, err := RunnerVar.RunCombinedOutput(PoolOperator, createAttr...)",can we have String() and GoString() implementation of `apis.CStorPool` struct to pretty print it.
+8818,"@@ -914,6 +914,10 @@ CheckedError Parser::ParseTable(const StructDef &struct_def, std::string *value,
+   size_t fieldn = 0;
+   auto err = ParseTableDelimiters(fieldn, &struct_def,
+                                   [&](const std::string &name) -> CheckedError {
++    if (name == ""$schema"") {
++      NEXT(); // Ignore this field.
++      return NoError();
++    }
+     auto field = struct_def.fields.Lookup(name);
+     if (!field) {
+       if (!opts.skip_unexpected_fields_in_json) {","Like I said, please replace by `EXPECT(kTokenString)`"
+8819,"@@ -32,6 +32,7 @@ import org.apache.commons.logging.Log;
+ import org.apache.commons.logging.LogFactory;
+
+ import org.springframework.security.authentication.AuthenticationCredentialsNotFoundException;
++import org.springframework.security.authentication.AuthenticationDetailsSource;
+ import org.springframework.security.authentication.AuthenticationManager;
+ import org.springframework.security.authentication.AuthenticationTrustResolver;
+ import org.springframework.security.authentication.AuthenticationTrustResolverImpl;",Will you please update the copyright message to `2021` for classes that you modify?
+8820,"@@ -301,6 +301,8 @@
+                 getSelectedRows: function () {
+                   return service.getSelectedRows(grid).map(function (gridRow) {
+                     return gridRow.entity;
++                  }).filter(function (entity) {
++                    return entity.hasOwnProperty('$$hashKey');
+                   });
+                 },
+                 /**","Is there a better way to filter these other than relying on the hashKey. I few like this might now be trustworthy in the long run. If angular ever removes this property, this feature would be broken."
+8821,"@@ -2012,7 +2012,11 @@ os_tls_thread_exit(local_state_t *local_state)
+
+     /* We already set TLS to &uninit_tls in os_thread_exit() */
+
+-    if (dynamo_exited && !last_thread_tls_exited) {
++    /* Do not set last_thread_tls_exited if a client_thread is exiting.
++     * If set, get_thread_private_dcontext() returns NULL, which may cause
++     * other thread fault on using dcontext.
++     */
++    if (dynamo_exited && dynamo_exited_synched && !last_thread_tls_exited) {
+         last_thread_tls_exited = true;
+         first_thread_tls_initialized = false; /* for possible re-attach */
+     }",No need to check dynamo_exited
+8822,"@@ -47,8 +47,11 @@ func (c *Config) SetDevice(deviceName string) {
+ 	c.setParam(""dev"", deviceName)
+ }
+
+-func (c *Config) SetTlsCertificate(caFile, certFile, certKeyFile string) {
++func (c *Config) SetTlsCACertificate(caFile string) {
+ 	c.AddOptions(OptionFile(""ca"", caFile))
++}
++
++func (c *Config) SetTlsPrivatePubKeys(certFile string, certKeyFile string) {
+ 	c.AddOptions(OptionFile(""cert"", certFile))
+ 	c.AddOptions(OptionFile(""key"", certKeyFile))
+ }",from linter: >method SetTlsCACertificate should be SetTLSCACertificate
+8823,"@@ -519,11 +519,11 @@ public abstract class SpanStoreTest {
+
+     Span trace2 = Span.builder().traceId(2).name(""get"").id(2)
+         .timestamp((today + 2) * 1000)
+-        .addAnnotation(Annotation.create((today + 1) * 1000, CLIENT_SEND, APP_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, SERVER_RECV, WEB_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, SERVER_SEND, WEB_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, CLIENT_RECV, APP_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, ""app"", APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, CLIENT_SEND, APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, SERVER_RECV, WEB_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, SERVER_SEND, WEB_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, CLIENT_RECV, APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, ""app"", APP_ENDPOINT))
+         .addBinaryAnnotation(BinaryAnnotation.create(""local"", ""app"", APP_ENDPOINT))
+         .addBinaryAnnotation(BinaryAnnotation.create(""app-b"", ""app"", APP_ENDPOINT))
+         .build();",this data had incorrectly aligned timestamps (which wasn't the point of the test)
+8824,"@@ -280,6 +280,16 @@ func (w *Workflow) populateStep(ctx context.Context, s *Step) error {
+ 	return step.populate(ctx, s)
+ }
+
++func getUser() string {
++	if cu, err := user.Current(); err == nil {
++		return cu.Username
++	}
++	if hn, err := os.Hostname(); err == nil {
++		return hn
++	}
++	return ""unknown""
++}
++
+ func (w *Workflow) populate(ctx context.Context) error {
+ 	var err error
+ 	if w.ComputeClient == nil {","Since this is workflow agnostic, should we put this in common?"
+8825,"@@ -54,6 +54,13 @@ class SourceAnalyzer(object):
+         """"""
+         raise NotImplementedError(""Subclasses should implement this!"")
+
++    @classmethod
++    def version_compatible(cls, configured_binary, environ):
++        """"""
++        Checker the version compatibility of the given analyzer binary.
++        """"""
++        raise NotImplementedError(""Subclasses should implement this!"")
++
+     @classmethod
+     def construct_config_handler(cls, args, context):
+         """""" Should return a subclass of AnalyzerConfigHandler.""""""",using the `@abstractmethod` decorator wouldn't be better?
+8826,"@@ -21,7 +21,7 @@ final class BooleanConfigurator implements FieldConfiguratorInterface
+     public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $context): void
+     {
+         $isRenderedAsSwitch = true === $field->getCustomOption(BooleanField::OPTION_RENDER_AS_SWITCH);
+-        if ($isRenderedAsSwitch && false !== strpos($field->getProperty(), '.')) {
++        if ($isRenderedAsSwitch && $this->isNestedProperty($field) && false === $this->isBoolean($field)) {
+             throw new \InvalidArgumentException(sprintf('The ""%s"" property cannot be rendered as a switch because it belongs to an associated entity instead of to the entity itself. Render the property as a normal boolean field.', $field->getProperty()));
+         }
+ ",This was crashing the app during EDIT on boolean Doctrine Embedded properties
+8827,"@@ -45,7 +45,7 @@
+
+ #include ""board_common.h""
+
+-#define DFL_SYSFS_SEC_GLOB ""*dfl*/*spi*/*spi*/*spi*/**/security/""
++#define DFL_SYSFS_SEC_GLOB ""*dfl*/**/security/""
+ #define DFL_SYSFS_SEC_USER_FLASH_COUNT         DFL_SYSFS_SEC_GLOB ""*flash_count""
+ #define DFL_SYSFS_SEC_BMC_CANCEL               DFL_SYSFS_SEC_GLOB ""bmc_canceled_csks""
+ #define DFL_SYSFS_SEC_BMC_ROOT                 DFL_SYSFS_SEC_GLOB ""bmc_root_entry_hash""",Will this be backwards compatible with the previous path?
+8828,"@@ -29,6 +29,11 @@ namespace OpenTelemetry.Trace
+         /// </summary>
+         ISpan CurrentSpan { get; }
+
++        /// <summary>
++        /// Gets the current scope from the context.
++        /// </summary>
++        IScope CurrentScope { get; }
++
+         /// <summary>
+         /// Gets the <see cref=""IBinaryFormat""/> for this implementation.
+         /// </summary>",what is potential use for current scope? It seems you'd only want it to stop it. But if you get current scope you never know if it's yours to stop - i.e. this is not safe or correct to stop current scope. So I wonder should we even try to expose it?
+8829,"@@ -76,7 +76,9 @@ describe( 'User Input Settings', () => {
+ 			'enter keywords',
+ 			async () => {
+ 				await expect( page ).toClick( '.googlesitekit-user-input__buttons--next' );
+-				await expect( page ).toFill( '#searchTerms-keyword-0', 'One,Two,Three,' );
++				await expect( page ).toFill( '#searchTerms-keyword-0', 'One' );
++				await expect( page ).toFill( '#searchTerms-keyword-1', 'Two' );
++				await expect( page ).toFill( '#searchTerms-keyword-2', 'Three' );
+ 			},
+ 		);
+ ",I think this is likely the only additional change needed on the original PR.
+8830,"@@ -5,10 +5,12 @@ import android.content.SharedPreferences;
+ import android.content.res.Configuration;
+ import android.util.AttributeSet;
+ import android.view.View;
++
+ import androidx.appcompat.view.ContextThemeWrapper;
+ import androidx.recyclerview.widget.DividerItemDecoration;
+ import androidx.recyclerview.widget.LinearLayoutManager;
+ import androidx.recyclerview.widget.RecyclerView;
++
+ import de.danoeh.antennapod.R;
+ import io.reactivex.annotations.Nullable;
+ ",Please revert changes to unrelated file
+8831,"@@ -0,0 +1,14 @@
++package azkaban.execapp.fake;
++
++import org.mortbay.jetty.Connector;
++import org.mortbay.jetty.Server;
++import org.mortbay.jetty.bio.SocketConnector;
++
++public class FakeServer extends Server {
++
++  @Override
++  public Connector[] getConnectors() {
++    return new Connector[]{new SocketConnector()};
++  }
++
++}",Can test use a Mockito mock instance instead?
+8832,"@@ -47,12 +47,13 @@ import java.lang.reflect.Method;
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+         severity = BugPattern.SeverityLevel.WARNING,
+-        summary = ""InvocationHandlers which delegate to another object must catch and unwrap ""
+-                + ""InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown ""
+-                + ""each time the delegate throws an exception.\n""
+-                + ""This check is intended to be advisory. It's fine to ""
+-                + ""@SuppressWarnings(\""InvocationHandlerDelegation\"") in certain cases, ""
+-                + ""but is usually not recommended."")
++        summary =
++                ""InvocationHandlers which delegate to another object must catch and unwrap ""
++                        + ""InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown ""
++                        + ""each time the delegate throws an exception.\n""
++                        + ""This check is intended to be advisory. It's fine to ""
++                        + ""@SuppressWarnings(\""InvocationHandlerDelegation\"") in certain cases, ""
++                        + ""but is usually not recommended."")
+ public final class InvocationHandlerDelegation extends BugChecker implements BugChecker.MethodInvocationTreeMatcher {
+
+     private static final Matcher<MethodTree> INVOCATION_HANDLER = Matchers.anyOf(",Bit of a shame about these multi-line strings in annotation parameters - they're not a deal breaker but just make the diff noisier
+8833,"@@ -61,6 +61,11 @@ namespace Microsoft.Rest.Generator.NodeJS
+             }
+         }
+
++        public List<T> ConvertIEnumerableToList<T>(IEnumerable<T> enumerable)
++        {
++            return new List<T>(enumerable);
++        }
++
+         public bool IsPolymorphic
+         {
+             get",we can remove this one as this is not used any more
+8834,"@@ -90,7 +90,6 @@ public abstract class LongRunningConfig {
+   private static LongRunningConfig createLongRunningConfigFromProtoFile(
+       Method method, DiagCollector diagCollector, ProtoParser protoParser) {
+
+-    boolean error = false;
+     Model model = method.getModel();
+     OperationTypes operationTypes = protoParser.getLongRunningOperation(method);
+     if (operationTypes == null",we don't really need an extra error flag
+8835,"@@ -21,11 +21,15 @@ import com.google.common.collect.ImmutableList;
+ import java.io.File;
+ import java.util.AbstractList;
+ import java.util.List;
++import java.util.Optional;
+ import java.util.stream.Collectors;
+-import net.ltgt.gradle.errorprone.ErrorPronePlugin;
++import net.ltgt.gradle.errorprone.javacplugin.CheckSeverity;
++import net.ltgt.gradle.errorprone.javacplugin.ErrorProneJavacPluginPlugin;
++import net.ltgt.gradle.errorprone.javacplugin.ErrorProneOptions;
+ import org.gradle.api.Plugin;
+ import org.gradle.api.Project;
+ import org.gradle.api.file.FileCollection;
++import org.gradle.api.plugins.ExtensionAware;
+ import org.gradle.api.plugins.JavaPluginConvention;
+ import org.gradle.api.tasks.compile.JavaCompile;
+ import org.gradle.api.tasks.javadoc.Javadoc;",any chance you could just fix the processors plugin?
+8836,"@@ -22,7 +22,8 @@ model = dict(
+         basesize_ratio_range=(0.15, 0.9),
+         anchor_ratios=([2], [2, 3], [2, 3], [2, 3], [2], [2]),
+         target_means=(.0, .0, .0, .0),
+-        target_stds=(0.1, 0.1, 0.2, 0.2)))
++        target_stds=(0.1, 0.1, 0.2, 0.2),
++        use_depthwise=False))
+ cudnn_benchmark = True
+ train_cfg = dict(
+     assigner=dict(",We may keep this config unchanged since `use_depthwise=True` by default.
+8837,"@@ -566,6 +566,15 @@ privload_process_imports(privmod_t *mod)
+                     privload_locate_and_load(name, mod, false /*client dir=>true*/);
+                 if (impmod == NULL)
+                     return false;
++                if (strstr(name, ""libpthread"") == name) {
++                    /* i#956: A private libpthread is not fully supported, but many
++                     * libraries import some utilities from it and do not use
++                     * threading.  We load it and just do not guarantee things will
++                     * work if thread-related routines are called.
++                     */
++                    SYSLOG_INTERNAL_WARNING(
++                        ""private libpthread.so loaded but not fully supported"");
++                }
+                 /* i#852: identify all libs that import from DR as client libs.
+                  * XXX: this code seems stale as libdynamorio.so is already loaded
+                  * (xref #3850).",Maybe add i#956 in this log as well.
+8838,"@@ -438,6 +438,11 @@ void Player::updateInventoryWeight()
+ 			inventoryWeight += item->getWeight();
+ 		}
+ 	}
++
++	StoreInbox* storeInbox = getStoreInbox();
++	if (storeInbox) {
++		inventoryWeight += storeInbox->getWeight();
++	}
+ }
+
+ void Player::addSkillAdvance(skills_t skill, uint64_t count)",if (StoreInbox* storeInbox = getStoreInbox()) {
+8839,"@@ -459,9 +459,14 @@ API.prototype._import = function(cb) {
+   });
+ };
+
++
++API.prototype.importAllFromMnemonic = function(words, opts, cb) {
++}
++
+ /**
+  * Import from Mnemonics (language autodetected)
+  * Can throw an error if mnemonic is invalid
++ * Will try compilant and non-compliantDerivation
+  *
+  * @param {String} BIP39 words
+  * @param {Object} opts","what is this, is it going to be used later?"
+8840,"@@ -66,8 +66,7 @@ module Beaker
+       name = host.name
+       Dir.stub( :chdir ).and_yield()
+
+-      out = double( 'stdout' )
+-      out.stub( :read ).and_return(""Host #{host.name}
++      vagrant.should_receive(:`).and_return(""Host #{host.name}
+     HostName 127.0.0.1
+     User vagrant
+     Port 2222","@anodelman test failure is probably due to this, needs to be fixed to `(""Host #{host.name}"")`"
+8841,"@@ -75,10 +75,10 @@
+
+
+
+-<div class=""cart-comments-container"">
+-  <div id=""cart-comments"">
+-    <h3>Comments on this purchase request</h3>
+-    <%- if @show_comments %>
++<%- if @include_comments_files %>
++  <div class=""cart-comments-container proposal-submodel-container"">
++    <div id=""cart-comments"">
++      <h3>Comments on this purchase request</h3>
+       <%= form_for [cart, Comment.new] do |f| %>
+         <%= f.text_area :comment_text, rows: 5 %>
+ ","I'm not sure that we need this anymore, but that can be a separate discussion."
+8842,"@@ -34,10 +34,14 @@ public interface HttpClient {
+    * @throws IOException if an I/O error occurs.
+    */
+   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
+-
++
+   /**
+-   * Creates HttpClient instances.
+-   */
++	* Closes the connections associated with this client.
++	*
++	* @throws  IOException  if an I/O error occurs.
++	*/
++  void close() throws IOException;
++
+   interface Factory {
+
+     /**",The formatting seems different from the rest of the code
+8843,"@@ -709,6 +709,9 @@ func (cg *ConfigGenerator) generateProbeConfig(
+ 	if m.Spec.ProberSpec.Scheme != """" {
+ 		cfg = append(cfg, yaml.MapItem{Key: ""scheme"", Value: m.Spec.ProberSpec.Scheme})
+ 	}
++	if m.Spec.ProberSpec.ProxyURL != """" {
++		cfg = append(cfg, yaml.MapItem{Key: ""proxy_url"", Value: m.Spec.ProberSpec.ProxyURL})
++	}
+
+ 	if m.Spec.Module != """" {
+ 		cfg = append(cfg, yaml.MapItem{Key: ""params"", Value: yaml.MapSlice{",Could we have a unit test for this?
+8844,"@@ -477,9 +477,11 @@ func (c *temporalImpl) startHistory(
+ 			}
+ 		}
+
++		stoppedCh := make(chan struct{})
+ 		var historyService *history.Service
+ 		app := fx.New(
+-			fx.Supply(params),
++			fx.Supply(params,
++				stoppedCh),
+ 			history.Module,
+ 			fx.Populate(&historyService))
+ 		err = app.Err()",nit: put params in new line
+8845,"@@ -100,13 +100,15 @@ export default function DateRangeSelector() {
+ 					'mdc-button--dropdown',
+ 					'googlesitekit-header__dropdown',
+ 					'googlesitekit-header__date-range-selector-menu',
++					'googlesitekit-border-radius-round--phone',
++					'googlesitekit-button-icon--phone',
+ 					{
+ 						'googlesitekit-header__date-range-selector-menu--has-unified-dashboard': unifiedDashboardEnabled,
+ 					}
+ 				) }
+ 				text
+ 				onClick={ handleMenu }
+-				icon={ <DateRangeIcon width=""18"" height=""20"" /> }
++				icon={ <DateRangeIcon width=""20"" height=""20"" /> }
+ 				aria-haspopup=""menu""
+ 				aria-expanded={ menuOpen }
+ 				aria-controls=""date-range-selector-menu""",The button for the date range selector has incorrect width since it has `padding-right: 8px` which sets the width to: `44px`. Can you review to make the button `36px` on small screens as per the AC?
+8846,"@@ -2836,8 +2836,13 @@ client_process_bb(dcontext_t *dcontext, build_bb_t *bb)
+ #    ifdef X86
+         if (!d_r_is_avx512_code_in_use()) {
+             if (ZMM_ENABLED()) {
+-                if (instr_may_write_zmm_register(inst))
++                if (instr_may_write_zmm_register(inst)) {
++                    LOG(THREAD, LOG_INTERP, 2, ""Detected AVX-512 code in use\n"");
++                    SELF_UNPROTECT_DATASEC(DATASEC_RARELY_PROT);
+                     d_r_set_avx512_code_in_use(true);
++                    proc_set_num_simd_saved(MCXT_NUM_SIMD_SLOTS);
++                    SELF_PROTECT_DATASEC(DATASEC_RARELY_PROT);
++                }
+             }
+         }
+ #    endif",This should be inside the set routine IMHO: matches the others; all callers need it; simplifies code here.
+8847,"@@ -106,6 +106,8 @@ public class TwoPhaseCommitter {
+   /** unit is second */
+   private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3000;
+
++  private static final long MAX_RETRY_LEVEL = 3;
++
+   private static final Logger LOG = LoggerFactory.getLogger(TwoPhaseCommitter.class);
+
+   private TxnKVClient kvClient;",MAX_RETRY_TIMES makes much more sense.
+8848,"@@ -56,6 +56,7 @@ type testContext struct {
+ 	fakeStatsKeeper       *fakeSessionStatsKeeper
+ 	fakeDialog            *fakeDialog
+ 	fakePromiseIssuer     *fakePromiseIssuer
++	fakeStorage           *fakeStorage
+ 	sync.RWMutex
+ }
+ ","`saveSession` allows easier mocking - just save function which You need, instead full interface"
+8849,"@@ -211,7 +211,8 @@ class Bucket(object):
+                 raise self.connection.provider.storage_response_error(
+                     response.status, response.reason, '')
+
+-    def list(self, prefix='', delimiter='', marker='', headers=None):
++    def list(self, prefix='', delimiter='', marker='', headers=None,
++             encoding_type=None):
+         """"""
+         List key objects within a bucket.  This returns an instance of an
+         BucketListResultSet that automatically handles all of the result",No docs for the new param here?
+8850,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright ConsenSys AG.
++ * Copyright Contributors to Hyperledger Besu.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
+  * the License. You may obtain a copy of the License at",This file is unrelated to the aims of this PR. Please remove. If it is needed to demonstrate Sonar Deltas then it has been proven and can be removed.
+8851,"@@ -42,5 +42,12 @@ namespace OpenTelemetry.Trace.Export
+         /// <param name=""cancellationToken"">Cancellation token.</param>
+         /// <returns>Returns <see cref=""Task""/>.</returns>
+         public abstract Task ShutdownAsync(CancellationToken cancellationToken);
++
++        /// <summary>
++        /// Flushes all activity objects that have been queued for processing.
++        /// </summary>
++        /// <param name=""cancellationToken"">Cancellation token.</param>
++        /// <returns>Returns <see cref=""Task""/>.</returns>
++        public abstract Task ForceFlushAsync(CancellationToken cancellationToken);
+     }
+ }","minor: `Export all ended spans to the configured Exporter that have not yet been exported.` - This is the spec description. Lets use something on that line. ""queue"" is not necessarily present for all processor."
+8852,"@@ -683,6 +683,8 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
+ 		ActionDigest:    digest,
+ 		SkipCacheLookup: skipCacheLookup,
+ 	}, updateProgress)
++	log.Debug(""completed ExecuteAndWaitProgress() for %v"", target.Label)
++
+ 	if err != nil {
+ 		// Handle timing issues if we try to resume an execution as it fails. If we get a
+ 		// ""not found"" we might find that it's already been completed and we can't resume.",is this deliberate? or testing?
+8853,"@@ -24,7 +24,7 @@ namespace OpenTelemetry
+ {
+     public class CompositeProcessor<T> : BaseProcessor<T>
+     {
+-        private DoublyLinkedListNode head;
++        private readonly DoublyLinkedListNode head;
+         private DoublyLinkedListNode tail;
+         private bool disposed;
+ ","I want to get more perspectives regarding this one. Making it `readonly` makes me feel that we're assuming the head should never change, and my worry is that other code might assume it (e.g. they might cache the value and assume it will never change). While this is true for now, I guess in the future we might want to support something like `PrependProcessor(processor)` or `InsertProcessor(index, processor)`."
+8854,"@@ -65,7 +65,7 @@ public class TestIndexSortSortedNumericDocValuesRangeQuery extends LuceneTestCas
+         iw.deleteDocuments(LongPoint.newRangeQuery(""idx"", 0L, 10L));
+       }
+       final IndexReader reader = iw.getReader();
+-      final IndexSearcher searcher = newSearcher(reader, false);
++      final IndexSearcher searcher = newSearcher(reader);
+       iw.close();
+
+       for (int i = 0; i < 100; ++i) {","This isn't critical for test coverage, but it seemed off that we had disabled wrapping the reader."
+8855,"@@ -21,9 +21,9 @@ _descList = []
+
+ def _setupDescriptors(namespace):
+   global _descList, descList
+-  from rdkit.Chem import GraphDescriptors, MolSurf, Lipinski, Fragments, Crippen
++  from rdkit.Chem import GraphDescriptors, MolSurf, Lipinski, Fragments, Crippen, Descriptors3D
+   from rdkit.Chem.EState import EState_VSA
+-  mods = [GraphDescriptors, MolSurf, EState_VSA, Lipinski, Crippen, Fragments]
++  mods = [GraphDescriptors, MolSurf, EState_VSA, Lipinski, Crippen,Descriptors3D, Fragments]
+
+   otherMods = [Chem]
+ ",Please remove Descriptors3D from this file. We just did this in master.
+8856,"@@ -15,12 +15,17 @@ namespace storage {
+
+ StorageClient::StorageClient(std::shared_ptr<folly::IOThreadPoolExecutor> threadPool)
+         : ioThreadPool_(threadPool) {
+-    client_ = std::make_unique<meta::MetaClient>();
+-    client_->init();
+     clientsMan_
+         = std::make_unique<thrift::ThriftClientManager<storage::cpp2::StorageServiceAsyncClient>>();
+ }
+
++
++void StorageClient::init(meta::MetaClient *client) {
++    CHECK(client);
++    client_ = client;
++}
++
++
+ folly::SemiFuture<StorageRpcResponse<cpp2::ExecResponse>> StorageClient::addVertices(
+         GraphSpaceID space,
+         std::vector<cpp2::Vertex> vertices,","You could pass the MetaClient instance in ctor, and create a new instance if nullptr."
+8857,"@@ -264,7 +264,11 @@ func subincludeTarget(s *scope, l core.BuildLabel) *core.BuildTarget {
+ 		s.NAssert(s.contextPkg.Target(l.Name) == nil, ""Target :%s is not defined in this package; it has to be defined before the subinclude() call"", l.Name)
+ 	}
+ 	s.NAssert(l.IsAllTargets() || l.IsAllSubpackages(), ""Can't pass :all or /... to subinclude()"")
++	// Temporarily release the parallelism limiter; this is important to keep us from deadlocking
++	// all available parser threads (easy to happen if they're all waiting on a single target which now can't start)
++	<-s.interpreter.limiter
+ 	t := s.state.WaitForBuiltTarget(l, pkgLabel)
++	s.interpreter.limiter <- struct{}{}
+ 	// This is not quite right, if you subinclude from another subinclude we can basically
+ 	// lose track of it later on. It's hard to know what better to do at this point though.
+ 	s.contextPkg.RegisterSubinclude(l)",What does this do? Seems like a poor mans mutex/semaphore?
+8858,"@@ -45,5 +45,5 @@ type ResponseWriter interface {
+ 	// SetApplicationError specifies that this response contains an
+ 	// application error. If called, this MUST be called before any invocation
+ 	// of Write().
+-	SetApplicationError()
++	SetApplicationError(err error)
+ }","This is a breaking change, and cannot be made. We have committed to this API for v1."
+8859,"@@ -136,16 +136,14 @@ class StatementsAnalyzer extends SourceAnalyzer implements StatementsSource
+      * Checks an array of statements for validity
+      *
+      * @param  array<PhpParser\Node\Stmt>   $stmts
+-     * @param  Context|null                                     $global_context
+-     * @param  bool                                             $root_scope
+      *
+      * @return null|false
+      */
+     public function analyze(
+         array $stmts,
+         Context $context,
+-        Context $global_context = null,
+-        $root_scope = false
++        ?Context $global_context = null,
++        bool $root_scope = false
+     ) {
+         if (!$stmts) {
+             return;",Can also drop corresponding types from docblock here
+8860,"@@ -105,7 +105,7 @@ public class RequestHandler implements Comparable<RequestHandler> {
+   public void process() {
+     switch (request.getRequestType()) {
+       case START_SESSION:
+-        log.info(""Got a request to create a new session: ""
++        log.finest(""Got a request to create a new session: ""
+                  + new DesiredCapabilities(request.getDesiredCapabilities()));
+         try {
+           registry.addNewSessionRequest(this);",This change is unhelpful to users.
+8861,"@@ -59,6 +59,8 @@ public struct Vec3 : IFlatbufferObject
+   }
+   public static Offset<MyGame.Example.Vec3> Pack(FlatBufferBuilder builder, Vec3T _o) {
+     if (_o == null) return default(Offset<MyGame.Example.Vec3>);
++    var _test3_a = _o.Test3.A;
++    var _test3_b = _o.Test3.B;
+     return CreateVec3(
+       builder,
+       _o.X,",why is this variable introduced? Please stick `_o.Test3.A` directly in the call below.
+8862,"@@ -88,7 +88,7 @@ module.exports.app = (options = {}) => {
+   app.get('/:providerName/logout', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.logout)
+   app.get('/:providerName/authorized', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.authorized)
+   app.get('/:providerName/list/:id?', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.list)
+-  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.get)
++  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.get)
+   app.get('/:providerName/thumbnail/:id', middlewares.hasSessionAndProvider, middlewares.cookieAuthToken, middlewares.verifyToken, controllers.thumbnail)
+
+   app.param('providerName', providerManager.getProviderMiddleware(providers))",do you mind sharing what is the reason for this change?
+8863,"@@ -27,11 +27,11 @@ class ProposalsController < ApplicationController
+     @pending_data = listing.pending
+     @pending_review_data = listing.pending_review
+     @completed_data = listing.completed.alter_query { |rel| rel.limit(@closed_proposal_limit) }
+-    @canceled_data = listing.canceled
++    @canceled_data = listing.canceled.alter_query { |rel| rel.limit(@closed_proposal_limit) }
+   end
+
+   def archive
+-    @proposals_data = listing.closed
++    redirect_to query_proposals_path(text: ""status:completed"")
+   end
+
+   def cancel_form",thoughts on putting `alter_query { |rel| rel.limit(@closed_proposal_limit) }` in a method that we can call here? That way we can have a test for this logic without needing a controller spec.
+8864,"@@ -31,7 +31,12 @@ module Api
+       response.last_modified = node.timestamp
+
+       if node.visible
+-        render :xml => node.to_xml.to_s
++        @node = node
++
++        # Render the result
++        respond_to do |format|
++          format.xml
++        end
+       else
+         head :gone
+       end",Perhaps `@node` throughout
+8865,"@@ -195,8 +195,14 @@ module Beaker
+             @cmd_options[:validate] = bool
+           end
+
+-          opts.on '--collect-perf-data', 'Use sysstat on linux hosts to collect performance and load data' do
+-            @cmd_options[:collect_perf_data] = true
++          opts.on '--collect-perf-data [MODE]',
++                  'Collect SUT performance and load data',
++                  'Possible values:',
++                  'aggressive (poll every minute)',
++                  'normal (poll every 10 minutes)',
++                  'none (do not collect perf data)',
++                  '(default: normal)' do |mode|
++            @cmd_options[:collect_perf_data] = mode || 'normal'
+           end
+
+           opts.on('--version', 'Report currently running version of beaker' ) do",Shouldn't this default be 'normal' ?
+8866,"@@ -131,7 +131,7 @@ class TelemetryEntry(
+     namedtuple(
+         ""TelemetryEntry"",
+         ""action client_time elapsed_time event_id instance_id pipeline_name_hash ""
+-        ""num_pipelines_in_repo repo_hash python_version metadata version dagster_version os_desc os_platform"",
++        ""num_pipelines_in_repo num_schedules_in_repo num_sensors_in_repo repo_hash python_version metadata version dagster_version os_desc os_platform"",
+     )
+ ):
+     """"""",nit: type this
+8867,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";
++  String STOP_CASTING = ""stopCasting"";
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`
+8868,"@@ -234,7 +234,8 @@ func CheckIfBDBelongsToNode(nodeName string) Validate {
+ func (bd *BlockDevice) CheckIfBDBelongsToNode(nodeName string) error {
+ 	if !bd.IsBelongToNode(nodeName) {
+ 		return errors.Errorf(
+-			""block device doesn't belongs to node %s"",
++			""block device %s doesn't belongs to node %s"",
++			bd.Object.Name,
+ 			bd.Object.Spec.NodeAttributes.NodeName,
+ 		)
+ 	}",lets print nodeName that got passed also
+8869,"@@ -38,6 +38,9 @@ try:
+ except NameError:
+     pass
+
++if sys.version > '3':
++    long = int
++
+
+ class WebElement(object):
+     """"""Represents a DOM element.",Should be `if sys.version_info[0] > 2:`
+8870,"@@ -1254,6 +1254,7 @@ int main(int argc, char *argv[])
+
+ 	random_init();
+ 	debug_config(argv[0]);
++	debug_config_file_size(string_metric_parse(""0""));//to set debug file size to ""don't delete anything""
+
+ 	s = getenv(""MAKEFLOW_BATCH_QUEUE_TYPE"");
+ 	if(s) {","Is there any need to pass this through `string_metric_parse`? I believe you can either create an off_t or just pass 0, with no need to added a string conversion into the mix."
+8871,"@@ -888,6 +888,17 @@ class WebDriver(BaseWebDriver):
+         """"""
+         self.execute(Command.MINIMIZE_WINDOW)
+
++    def print_page(self, print_option_arg = None):
++        """"""
++        Takes PDF of the current page.
++        The driver makes a best effort to return a PDF based on the provided parameters.
++        """"""
++        options = {}
++        if print_option_arg:
++            options = print_option_arg.print_options
++
++        return self.execute(Command.PRINT_PAGE, options)['value']
++
+     @property
+     def switch_to(self):
+         """"""",Let's not use a form of hungarian notation in naming our variables
+8872,"@@ -527,8 +527,13 @@ static void handle_incoming_request(struct st_h2o_http1_conn_t *conn)
+             send_bad_request(conn, ""line folding of header fields is not supported"");
+             return;
+         }
++
++        H2O_PROBE_CONN(RECEIVE_REQUEST_HEADERS, &conn->super, conn->_req_index, &conn->req.input.method, &conn->req.input.authority,
++                       &conn->req.input.path, conn->req.version, conn->req.headers.entries, conn->req.headers.size);
++
+         H2O_PROBE(RECEIVE_REQUEST_HEADERS, &conn->super, conn->_req_index, &conn->req.input.method, &conn->req.input.authority,
+                   &conn->req.input.path, conn->req.version, conn->req.headers.entries, conn->req.headers.size);
++
+         if (entity_body_header_index != -1) {
+             conn->req.timestamps.request_body_begin_at = h2o_gettimeofday(conn->super.ctx->loop);
+             if (expect.base != NULL) {",Seems like we are calling the probe twice?
+8873,"@@ -13,7 +13,7 @@ import (
+
+ // LocalDevExecCmd allows users to execute arbitrary bash commands within a container.
+ var LocalDevExecCmd = &cobra.Command{
+-	Use:   ""exec [app_name] [environment_name] '[cmd]'"",
++	Use:   ""exec '[cmd]'"",
+ 	Short: ""run a command in an app container."",
+ 	Long:  `Execs into container and runs bash commands.`,
+ 	Run: func(cmd *cobra.Command, args []string) {","I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But ""Run a command in an app container"" doesn't do it for me :)"
+8874,"@@ -118,7 +118,7 @@ func CreateOrUpdateService(ctx context.Context, sclient clientv1.ServiceInterfac
+ 		}
+ 	} else {
+ 		svc.ResourceVersion = service.ResourceVersion
+-		svc.Spec.IPFamily = service.Spec.IPFamily
++		svc.Spec.IPFamilies = service.Spec.IPFamilies
+ 		svc.SetOwnerReferences(mergeOwnerReferences(service.GetOwnerReferences(), svc.GetOwnerReferences()))
+ 		_, err := sclient.Update(ctx, svc, metav1.UpdateOptions{})
+ 		if err != nil && !apierrors.IsNotFound(err) {","Have not tested this yet, lets see if tests complain, but I suspect it should be as easy as this  "
+8875,"@@ -42,6 +42,10 @@ SPARK_INDEX_NAME_FORMAT = ""__index_level_{}__"".format
+ # A pattern to check if the name of a Spark column is a Koalas index name or not.
+ SPARK_INDEX_NAME_PATTERN = re.compile(r""__index_level_[0-9]+__"")
+
++NATURAL_ORDER_COLUMN_NAME = '__natural_order__'
++
++HIDDEN_COLUMNS = set([NATURAL_ORDER_COLUMN_NAME])
++
+ IndexMap = Tuple[str, Optional[Tuple[str, ...]]]
+
+ ",no big deal but we don't we just use a list to keep the order? I don't think it's likely to have a duplicated columns if that was the concern.
+8876,"@@ -1,5 +1,5 @@
+ /**
+- * core/modules data store
++ * Modules data store
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for all similar cases below."
+8877,"@@ -34,6 +34,7 @@ const ContainerdConfigTemplate = `
+
+ {{- if .NodeConfig.AgentConfig.Snapshotter }}
+ [plugins.cri.containerd]
++  disable_snapshot_annotations = true
+   snapshotter = ""{{ .NodeConfig.AgentConfig.Snapshotter }}""
+ {{end}}
+ ",where is this coming from?
+8878,"@@ -0,0 +1,11 @@
++class MoveScreencastsIntoProducts < ActiveRecord::Migration
++  def up
++    say_with_time ""Converting screencasts into video_tutorials"" do
++      update ""UPDATE products SET type = 'VideoTutorial' WHERE type = 'Screencast'""
++    end
++  end
++
++  def down
++    raise ActiveRecord::IrreversibleMigration
++  end
++end","We can also drop `plans.includes_screencasts`, right?"
+8879,"@@ -374,6 +374,11 @@ class ECPrivkey(ECPubkey):
+             sigdecode = get_r_and_s_from_sig_string
+         private_key = _MySigningKey.from_secret_exponent(self.secret_scalar, curve=SECP256k1)
+         sig = private_key.sign_digest_deterministic(data, hashfunc=hashlib.sha256, sigencode=sigencode)
++        counter = 0
++        while ord(sig[0]) > 127: # grind for low R value https://github.com/bitcoin/bitcoin/pull/13666
++            counter += 1
++            extra_entropy = bfh(""%064x"" % counter)[::-1]
++            sig = private_key.sign_digest_deterministic(data, hashfunc=hashlib.sha256, sigencode=sigencode, extra_entropy=extra_entropy)
+         public_key = private_key.get_verifying_key()
+         if not public_key.verify_digest(sig, data, sigdecode=sigdecode):
+             raise Exception('Sanity check verifying our own signature failed.')","wouldn't `int.to_bytes(counter, 32, 'little')` be equivalent, clearer and faster?"
+8880,"@@ -60,6 +60,11 @@ func (a *API) CreatePayments(ctx context.Context, config CreatePaymentsParams) (
+ 	return CreatePayments(ctx, a, config)
+ }
+
++// ValidateStoragePaymentCondition validates that the given condition is a payment condition and has the right values
++func (a *API) ValidateStoragePaymentCondition(ctx context.Context, condition *types.Predicate, minerAddr address.Address, commP types.CommP, pieceSize *types.BytesAmount) error {
++	return ValidateStoragePaymentCondition(ctx, condition, minerAddr, commP, pieceSize)
++}
++
+ // DealGet returns a single deal matching a given cid or an error
+ func (a *API) DealGet(ctx context.Context, proposalCid cid.Cid) (*storagedeal.Deal, error) {
+ 	return DealGet(ctx, a, proposalCid)","I don't see why this is in porcelain since it's just a free function, with no dependency on plumbing or the `a` receiver. I think it should be moved to `protocol/storage`. It's exposed unnecessarily widely here."
+8881,"@@ -130,6 +130,11 @@ def create_messages(data, entity: str, stats_range: str, from_ts: int, to_ts: in
+     """"""
+     for entry in data:
+         _dict = entry.asDict(recursive=True)
++
++        # Clip the recordings to top 1000 so that we don't drop messages
++        if entity == ""recordings"":
++            _dict[entity] = _dict[entity][:1000]
++
+         try:
+             model = UserEntityStatMessage(**{
+                 'musicbrainz_id': _dict['user_name'],",Could we only do this for all time? Because that's what is causing problems rn?
+8882,"@@ -369,7 +369,7 @@ class _FlowType(_BaseFlowType):
+
+     def parse(self, manager: ""CommandManager"", t: type, s: str) -> flow.Flow:
+         try:
+-            flows = manager.execute(""view.flows.resolve %s"" % (s))
++            flows = manager.execute(""view.flows.resolve '%s'"" % (s))
+         except exceptions.CommandError as e:
+             raise exceptions.TypeError(str(e)) from e
+         if len(flows) != 1:","This looks better than before, but we'll now likely run into issues with `'` characters in the spec. Maybe we can just use `manager.call_strings` instead?"
+8883,"@@ -131,6 +131,12 @@ public class SparkReadConf {
+         .parse();
+   }
+
++  public Long splitSizeOption() {
++    return confParser.longConf()
++        .option(SparkReadOptions.SPLIT_SIZE)
++        .parseOptional();
++  }
++
+   public long splitSize() {
+     return confParser.longConf()
+         .option(SparkReadOptions.SPLIT_SIZE)","Should this replace `splitSize` instead of adding a parallel call? The `SparkReadConf` is not yet released, so we can change it still."
+8884,"@@ -71,7 +71,18 @@ class LocalFileSystem(FileSystem):
+                 return
+
+         if parents:
+-            os.makedirs(path)
++            # for Python 2 compatibility
++            try:
++                FileNotExistsError
++            except NameError:
++                FileNotExistsError = OSError
++
++            try:
++                os.makedirs(path)
++            except FileNotExistsError as err:
++                # somebody already created the path
++                if err.errno != errno.EEXIST:
++                    raise
+         else:
+             if not os.path.exists(os.path.dirname(path)):
+                 raise MissingParentDirectory()","To reduce complexity, please use OSError on Python3 as well."
+8885,"@@ -209,3 +209,10 @@ def follow_selected(tab_obj: apitypes.Tab, *, tab: bool = False) -> None:
+         tab_obj.caret.follow_selected(tab=tab)
+     except apitypes.WebTabError as e:
+         raise cmdutils.CommandError(str(e))
++
++
++@cmdutils.register()
++@cmdutils.argument('tab', value=cmdutils.Value.cur_tab)
++def reverse_selection(tab: apitypes.Tab) -> None:
++    """"""Toggle caret selection mode.""""""
++    tab.caret.reverse_selection()",That seems wrong.
+8886,"@@ -55,6 +55,7 @@ public class ConfirmEmailPage implements java.io.Serializable {
+             if (confirmEmailData != null) {
+                 user = confirmEmailData.getAuthenticatedUser();
+                 session.setUser(user);
++                session.configureSessionTimeout(); // TODO: is this needed here? (it can't hurt, but still)
+                 JsfHelper.addSuccessMessage(BundleUtil.getStringFromBundle(""confirmEmail.details.success""));
+                 return ""/dataverse.xhtml?faces-redirect=true"";
+             }","Yes, this is needed here. This is a builtin user who just reset their password."
+8887,"@@ -396,13 +396,12 @@ class HDF5PackageStore(PackageStore):
+         """"""
+         self._find_path_write()
+         buildfile = name.lstrip('/').replace('/', '.')
+-        storepath = os.path.join(self._pkg_dir, buildfile)
++        storepath = self._object_path('.' + buildfile)
+         with pd.HDFStore(storepath, mode=self._mode) as store:
+             store[self.DF_NAME] = df
+         filehash = digest_file(storepath)
+         self._add_to_contents(buildfile, filehash, ext, path, target)
+-        objpath = os.path.join(self._pkg_dir, self.OBJ_DIR, filehash)
+-        os.rename(storepath, objpath)
++        os.rename(storepath, self._object_path(filehash))
+
+     @classmethod
+     def ls_packages(cls, pkg_dir):","This seems to move the storage of temporary files to the CWD. Is that right? I don't think we should do that. If the process gets interrupted, we should try our best to clean up, but if even that fails, it'd be nice if the mess was left in a different directory. Maybe we should have a directory explicitly for builds?"
+8888,"@@ -67,6 +67,10 @@ type Config struct {
+ 	// If not set, it uses all versions available.
+ 	// Warning: This API should not be considered stable and will change soon.
+ 	Versions []protocol.VersionNumber
++	// Ask the server to truncate the connection ID sent in the Public Header.
++	// This saves 8 bytes in the Public Header in every packet. However, if the IP address of the server changes, the connection cannot be migrated.
++	// Currently only valid for the client.
++	RequestConnectionIDTruncation bool
+ }
+
+ // A Listener for incoming QUIC connections","Please explain why a user would enable this (space savings), and the requirements for this option to be safe."
+8889,"@@ -43,12 +43,16 @@ export default function ContainerSelect( {
+ 	value,
+ 	...props
+ } ) {
+-	const accounts = useSelect( ( select ) => select( STORE_NAME ).getAccounts() );
++	const { accounts, hasResolvedAccounts } = useSelect( ( select ) => ( {
++		accounts: select( STORE_NAME ).getAccounts(),
++		hasResolvedAccounts: select( STORE_NAME ).hasFinishedResolution( 'getAccounts' ),
++	} ) );
++
+ 	const accountID = useSelect( ( select ) => select( STORE_NAME ).getAccountID() );
+ 	const hasExistingTag = useSelect( ( select ) => select( STORE_NAME ).hasExistingTag() );
+-	const isLoadingContainers = useSelect( ( select ) => select( STORE_NAME ).isDoingGetContainers( accountID ) );
++	const hasResolvedContainers = useSelect( ( select ) => select( STORE_NAME ).hasFinishedResolution( 'getContainers', [ accountID ] ) );
+
+-	if ( accounts === undefined || containers === undefined || isLoadingContainers ) {
++	if ( accounts === undefined || ! hasResolvedAccounts || containers === undefined || ! hasResolvedContainers ) {
+ 		return <ProgressBar small />;
+ 	}
+ ",I think the `undefined` checks still need to be removed from here.
+8890,"@@ -158,6 +158,13 @@ class KubernetesJobTask(luigi.Task):
+         """"""
+         return self.kubernetes_config.max_retrials
+
++    @property
++    def backoff_limit(self):
++        """"""
++        Maximum number of retries before considering the job as failed.
++        """"""
++        return 6
++
+     @property
+     def delete_on_success(self):
+         """"""",Is there any particular reason to have 6?
+8891,"@@ -122,8 +122,11 @@ func (s *Space) biggestFreeRange(r address.Range) (biggest address.Range) {
+ 	biggestSize := address.Count(0)
+ 	s.walkFree(r, func(chunk address.Range) bool {
+ 		if size := chunk.Size(); size >= biggestSize {
+-			biggest = chunk
+-			biggestSize = size
++			chunk = chunk.BiggestPow2AlignedRange()
++			if size = chunk.Size(); size >= biggestSize {
++				biggest = chunk
++				biggestSize = size
++			}
+ 		}
+ 		return false
+ 	})","The biggest chunk does not guarantee that it contains the biggest CIDR-aligned range. If we don't care too much about a few CPU cycles being wasted, then I'd suggest to merge the if-statements."
+8892,"@@ -81,6 +81,16 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) dErr {
+ 	}
+ 	substitute(reflect.ValueOf(i.Workflow).Elem(), strings.NewReplacer(replacements...))
+
++	// We do this here, and not in validate, as embedded startup scripts could
++	// have what we think are daisy variables.
++	if err := i.Workflow.validateVarsSubbed(); err != nil {
++		return err
++	}
++
++	if err := i.Workflow.substituteSourceVars(reflect.ValueOf(i.Workflow).Elem()); err != nil {
++		return err
++	}
++
+ 	i.Workflow.populateLogger(ctx)
+
+ 	for name, st := range i.Workflow.Steps {","instead of doing the if err := __; err != nil { return err } thing, you can do errs = addErrs(errs, ___). If you want."
+8893,"@@ -4,8 +4,15 @@
+ package cli
+
+ import (
++	""errors""
++	""fmt""
++
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/ssm""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/color""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/log""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/prompt""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/workspace""
+ 	""github.com/spf13/cobra""
+ )",nit: Is this error message accurate?
+8894,"@@ -4269,7 +4269,7 @@ import_one_object_direct (OstreeRepo    *dest_repo,
+         G_IN_SET (src_repo->mode, OSTREE_REPO_MODE_BARE, OSTREE_REPO_MODE_BARE_USER);
+       if (src_is_bare_or_bare_user && !OSTREE_OBJECT_TYPE_IS_META(objtype))
+         {
+-          if (src_repo == OSTREE_REPO_MODE_BARE)
++          if (src_repo->mode == OSTREE_REPO_MODE_BARE)
+             {
+               g_autoptr(GVariant) xattrs = NULL;
+               if (!glnx_fd_get_all_xattrs (src_fd, &xattrs,","Ouch! :man_facepalming: And of course, this worked for me because that evaluated to false when I was testing the bare-user path."
+8895,"@@ -380,7 +380,10 @@ func (c *FCGIClient) Request(p map[string]string, req io.Reader) (resp *http.Res
+ 		if err != nil {
+ 			return
+ 		}
+-		resp.Status = statusParts[1]
++		if (len(statusParts) > 0) {
++			resp.Status = statusParts[1]
++		}
++
+ 	} else {
+ 		resp.StatusCode = http.StatusOK
+ 	}",Parentheses aren't needed here. `if len(statusParts) > 0 {` will suffice.
+8896,"@@ -44,9 +44,10 @@ const serverName = ""yarpc-test""
+
+ // TT is the gauntlets table test struct
+ type TT struct {
+-	Service  string // thrift service name; defaults to ThriftTest
+-	Function string // name of the Go function on the client
+-	Oneway   bool   // if the function is a oneway function
++	Service       string   // thrift service name; defaults to ThriftTest
++	Function      string   // name of the Go function on the client
++	Oneway        bool     // if the function is a oneway function
++	SkipOnServers []string // if the test needs to be skipped on particular server
+
+ 	Details string        // optional extra details about what this test does
+ 	Give    []interface{} // arguments besides context",// the test is skipped on given servers because it will fail.
+8897,"@@ -220,8 +220,7 @@ describe 'OrganizationsController' do
+
+     it 'should return unauthorized if api key is invalid' do
+       get :index, format: :xml, api_key: 'dummy_id'
+-
+-      must_respond_with :unauthorized
++      must_respond_with :bad_request
+     end
+   end
+ ","The name of the test should be updated to ""it 'should return bad_request if api key is invalid"""
+8898,"@@ -806,6 +806,12 @@ class _HyperSearchRunner(object):
+
+     # pull out best Model from jobs table
+     jobInfo = _clientJobsDB().jobInfo(hyperSearchJob.getJobID())
++
++    # Try to return a decent error message if the job was cancelled for some
++    # reason.
++    if jobInfo.cancel is 1:
++      raise Exception(jobInfo.workerCompletionMsg)
++
+     try:
+       results = json.loads(jobInfo.results)
+     except Exception, e:",Use `==` in this case instead of `is`.
+8899,"@@ -53,6 +53,7 @@ type CStorPoolAttr struct {
+ 	OverProvisioning bool   `json:""overProvisioning""` //true or false
+ }
+
++// CStorPoolPhase is a CStorPool phase.
+ type CStorPoolPhase string
+
+ // Status written onto CStorPool and CStorVolumeReplica objects.",Please put it like this: `CStorPoolPhase is a typed string for phase field of CStorPool`
+8900,"@@ -222,13 +222,15 @@ class Order extends BaseAction implements EventSubscriberInterface
+             $pse = $cartItem->getProductSaleElements();
+
+             /* check still in stock */
+-            if ($cartItem->getQuantity() > $pse->getQuantity()) {
++            if ($cartItem->getQuantity() > $pse->getQuantity() && true === ConfigQuery::checkAvailableStock()) {
+                 throw new TheliaProcessException(""Not enough stock"", TheliaProcessException::CART_ITEM_NOT_ENOUGH_STOCK, $cartItem);
+             }
+
+             /* decrease stock */
++            $newStock = $pse->getQuantity() - $cartItem->getQuantity();
++            if($newStock < 0) $newStock = 0; //Forbid negative stock
+             $pse->setQuantity(
+-                    $pse->getQuantity() - $cartItem->getQuantity()
++                    $newStock
+             );
+             $pse->save($con);
+ ",variable must be in camelCase => $newStock
+8901,"@@ -73,7 +73,7 @@ func setActionFlags(cmds ...*cobra.Command) {
+
+ func sendAction(elp action.Envelope) string {
+ 	fmt.Printf(""Enter password #%s:\n"", signer)
+-	bytePassword, err := terminal.ReadPassword(syscall.Stdin)
++	bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))
+ 	if err != nil {
+ 		log.L().Error(""fail to get password"", zap.Error(err))
+ 		return err.Error()",unnecessary conversion (from `unconvert`)
+8902,"@@ -345,6 +345,18 @@ final class BitMappedTrie<T> implements Serializable {
+         return index;
+     }
+
++    Object[] toArray() {
++        final Object[] results = new Object[length];
++        visit((index, leaf, start, end) -> {
++            final int copied = end - start;
++            for (int i = start; i < end; i++) {
++                results[index + i] = type.getAt(leaf, i);
++            }
++            return index + copied;
++        });
++        return results;
++    }
++
+     int length() { return length; }
+ }
+ ","... is probably automatically vectorized, since it has the same speed as `System.arraycopy`"
+8903,"@@ -15,9 +15,19 @@
+
+ package engine
+
++import (
++	""github.com/aws/amazon-ecs-agent/agent/resources/cgroup""
++	""github.com/cihub/seelog""
++	""github.com/pkg/errors""
++)
++
++// control is used to manipulate cgroups and ease testing
++var control cgroup.Control
++
+ // SetupPlatformResources sets up platform level resources
+ func (mtask *managedTask) SetupPlatformResources() error {
+ 	if mtask.Task.CgroupEnabled() {
++		setControl(cgroup.New())
+ 		return mtask.setupCgroup()
+ 	}
+ 	return nil","Is there anyway to get rid of the global variable, if it is specific for each task, can you add it to the `mtask` struct?"
+8904,"@@ -77,12 +77,12 @@ func TestDeserializeFromFlatBuffer(t *testing.T) {
+ 		{
+ 			name:     ""simple unary expr"",
+ 			fbFn:     getUnaryOpFlatBuffer,
+-			polyType: `forall [] float`,
++			polyType: `float`,
+ 		},
+ 		{
+ 			name:     ""function expression"",
+ 			fbFn:     getFnExprFlatBuffer,
+-			polyType: `forall [t0, t1] (a: t0, <-b: t1, ?c: int) -> int`,
++			polyType: `(a: A, <-b: B, ?c: int) => int`,
+ 		},
+ 	}
+ ","Surprised to see this old syntax here, but not _that_ surprised."
+8905,"@@ -164,9 +164,16 @@ abstract class AbstractQueue<T, Q extends AbstractQueue<T, Q>> implements Traver
+         return Collections.removeAll((Q) this, elements);
+     }
+
+-    @SuppressWarnings(""unchecked"")
++    @Deprecated
+     public Q removeAll(Predicate<? super T> predicate) {
+-        return Collections.removeAll((Q) this, predicate);
++        Objects.requireNonNull(predicate, ""predicate is null"");
++        return reject(predicate);
++    }
++
++    @SuppressWarnings(""unchecked"")
++    @Override
++    public Q reject(Predicate<? super T> predicate) {
++        return Collections.reject((Q) this, predicate);
+     }
+
+     @Override",It is good to mark it! Maybe we can remove the method for Vavr 1.0.0 - but for now it can stay as-is. Thx!
+8906,"@@ -15,11 +15,12 @@
+ package pool
+
+ import (
++	""errors""
+ 	""sync""
+-	""time""
+
+ 	""github.com/golang/glog""
+-	""github.com/openebs/maya/pkg/util""
++	col ""github.com/openebs/maya/cmd/maya-exporter/app/collector""
++	types ""github.com/openebs/maya/pkg/exec""
+ 	zpool ""github.com/openebs/maya/pkg/zpool/v1alpha1""
+ 	""github.com/prometheus/client_golang/prometheus""
+ )","exported func New returns unexported type *pool.pool, which can be annoying to use"
+8907,"@@ -17,7 +17,7 @@ module BoltSpec
+
+     # Nothing on the executor is 'public'
+     class MockExecutor
+-      attr_reader :noop, :error_message, :in_parallel
++      attr_reader :noop, :error_message, :in_parallel, :transports
+       attr_accessor :run_as, :transport_features, :execute_any_plan
+
+       def initialize(modulepath)","Sorry, I feel like I'm missing something - where does this get called?"
+8908,"@@ -423,12 +423,9 @@ func (e *edged) syncNodeStatus() {
+ 			klog.Errorf(""Register node failed: %v"", err)
+ 			return
+ 		}
+-		if err := e.updateNodeStatus(); err != nil {
+-			klog.Errorf(""Unable to update node status: %v"", err)
+-		}
+-	} else {
+-		if err := e.updateNodeStatus(); err != nil {
+-			klog.Errorf(""Unable to update node status: %v"", err)
+-		}
++	}
++
++	if err := e.updateNodeStatus(); err != nil {
++		klog.Errorf(""Unable to update node status: %v"", err)
+ 	}
+ }","@guihecheng Thanks for the fixing! Actually this is not the dup codes, when we first registerNode, then update the nodestatus immediately, or the node will keep not ready for 10s. And do you have other ways to refactor it?"
+8909,"@@ -14,6 +14,7 @@
+
+ #include ""SystemInfo.hpp""
+
++#include <sys/stat.h>
+ #ifdef _WIN32
+ #include <windows.h>
+ #else","How portable is this? (e.g., Windows). I'm relaunching tests of windows because they failed for other reasons."
+8910,"@@ -7498,10 +7498,13 @@ static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_stat
+     cb_state->hasDrawCmd = true;
+
+     // Add descriptor image/CIS layouts to CB layout map
+-    auto &desc_sets = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets;
+-    for (auto &desc : desc_sets) {
+-        if (desc) {
+-            desc->UpdateDSImageLayoutState(cb_state);
++    PIPELINE_STATE *pPipe = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state;
++
++    for (const auto &set_binding_pair : pPipe->active_slots) {
++        uint32_t setIndex = set_binding_pair.first;
++        auto &desc_set = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets[setIndex];
++        if (desc_set) {
++            desc_set->UpdateDSImageLayoutState(cb_state);
+         }
+     }
+ }","What this does is narrow down what we are saying the descriptor set is requiring. This is a good thing, but doesn't go far enough, we are still potentially setting unused bindings to either a required state or an invalid one. set_binding_pair.second is a map of the binding/requirements from the bound shaders... and instead of marking all bindings, looking at that will mark only the used ones. Will open a new PR"
+8911,"@@ -1038,11 +1038,10 @@ func (core *coreService) BlockMetas(start uint64, count uint64) ([]*iotextypes.B
+
+ 	var (
+ 		tipHeight = core.bc.TipHeight()
+-		res       []*iotextypes.BlockMeta
++		res       = make([]*iotextypes.BlockMeta, 0)
+ 	)
+ 	if start > tipHeight {
+-		log.L().Debug(""err in BlockMetas()"", zap.Error(status.Error(codes.InvalidArgument, ""start height should not exceed tip height"")))
+-		return nil, nil
++		return nil, status.Error(codes.NotFound, ""start height should not exceed tip height"")
+ 	}
+ 	for height := start; height <= tipHeight && count > 0; height++ {
+ 		blockMeta, err := core.getBlockMetaByHeight(height)","should use `codes.InvalidArgument`, same as above line 1033 and 1036"
+8912,"@@ -51,7 +51,7 @@ func getAgentVersions() []DockerVersion {
+ 	return append(getWindowsReplaceableVersions(), MinDockerAPIWindows)
+ }
+
+-// getDefaultVersion returns agent's default version of the Docker API
++// GetDefaultVersion returns agent's default version of the Docker API
+ func getDefaultVersion() DockerVersion {
+ 	return MinDockerAPIWindows
+ }",Please revert this file.
+8913,"@@ -18,10 +18,13 @@
+ //
+ // URLs
+ //
+-// For pubsub.OpenTopic/Subscription URLs, azurepubsub registers for the scheme
+-// ""azuresb"". The Service Bus Connection String defaults to the environment
+-// variable ""SERVICEBUS_CONNECTION_STRING"". For details on the format of the
+-// URL, see URLOpener.
++// For pubsub.OpenTopic and pubsub.OpenSubscription, azurepubsub registers
++// for the scheme ""azuresb"".
++// The default URL opener will use a Service Bus Connection String based on
++// the environment variable ""SERVICEBUS_CONNECTION_STRING"".
++// To customize the URL opener, or for more details on the URL format,
++// see URLOpener.
++// See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
+ // As
+ //","Probably in another PR, I think the package should be renamed to `servicebus` to be consistent."
+8914,"@@ -557,7 +557,7 @@ namespace AutoRest.Core.Properties {
+         }
+
+         /// <summary>
+-        ///   Looks up a localized string similar to A swagger must have security definitions and must adhere to the specific structure..
++        ///   Looks up a localized string similar to Every swagger/configuration must have a security definitions section and it must adhere to the structure described in: https://github.com/Azure/autorest/tree/master/docs/developer/validation-rules/security-definitions-structure-validation.md.
+         /// </summary>
+         public static string SecurityDefinitionsStructureValidation {
+             get {",curious: are we planning to add link to each of the rules in the message?
+8915,"@@ -248,6 +248,11 @@ func (exp *MockExplorer) GetDeposits(subChainID int64, offset int64, limit int64
+ 	return nil, nil
+ }
+
++// SettleDeposit settles deposit on sub-chain
++func (exp *MockExplorer) SettleDeposit(req explorer.SettleDepositRequest) (res explorer.SettleDepositResponse, err error) {
++	return explorer.SettleDepositResponse{}, nil
++}
++
+ func randInt64() int64 {
+ 	rand.Seed(time.Now().UnixNano())
+ 	amount := int64(0)",line is 123 characters
+8916,"@@ -69,7 +69,7 @@ class AuthorizationService extends AbstractAuthenticationService
+      * whether a user is authenticated.
+      *
+      * @see \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::checkAuthentication()
+-     * @param array Array of user data
++     * @param array $user of user data
+      * @return int Returns 200 to grant access for the page indexer.
+      */
+     public function authUser($user)",same here; `@param array $user Array of user data`
+8917,"@@ -21,7 +21,7 @@ func TestString(t *testing.T) {
+ 					b.Append(""a"")
+ 				}
+ 			},
+-			sz: 256,
++			sz: 0,
+ 			want: []interface{}{
+ 				""a"", ""a"", ""a"", ""a"", ""a"",
+ 				""a"", ""a"", ""a"", ""a"", ""a"",","A quick read of this test indicates that we're changing the behavior of this api, and so the test needs updating. Is that right?"
+8918,"@@ -5,13 +5,13 @@
+ using System;
+ using Android.Content;
+ using Android.Runtime;
+-using Android.Support.V7.Widget;
++using AndroidX.RecyclerView.Widget;
+ using Java.Lang;
+ using MvvmCross.Logging;
+
+-namespace MvvmCross.Droid.Support.V7.RecyclerView
++namespace MvvmCross.DroidX.RecyclerView
+ {
+-    [Register(""mvvmcross.droid.support.v7.recyclerview.MvxGuardedLinearLayoutManager"")]
++    [Register(""mvvmcross.DroidX.recyclerview.MvxGuardedLinearLayoutManager"")]
+     public class MvxGuardedLinearLayoutManager : LinearLayoutManager
+     {
+         public MvxGuardedLinearLayoutManager(Context context) : base(context)",Register needs lowercasing
+8919,"@@ -134,6 +134,9 @@ public class Constants {
+   public static final String EXECUTION_SOURCE_SCHEDULED = ""schedule"";
+   public static final String EXECUTION_SOURCE_EVENT = ""event"";
+
++  // Should validate proxy user
++  public static final boolean DEFAULT_VALIDATE_PROXY_USER = false;
++
+   public static class ConfigurationKeys {
+
+     public static final String AZKABAN_CLUSTER_NAME = ""azkaban.cluster.name"";",This should belong to FlowContainer class.
+8920,"@@ -412,7 +412,10 @@ class NVDAHighlighter(providerBase.VisionEnhancementProvider):
+ 		window = self.window = self.customWindowClass(self)
+ 		self.timer = winUser.WinTimer(window.handle, 0, self._refreshInterval, None)
+ 		msg = MSG()
+-		while winUser.getMessage(byref(msg), None, 0, 0):
++		# Python 3.8 note, Change this to use an Assignment expression to catch a return value of -1.
++		# See the remarks section of
++		# https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getmessage
++		while winUser.getMessage(byref(msg), None, 0, 0) > 0:
+ 			winUser.user32.TranslateMessage(byref(msg))
+ 			winUser.user32.DispatchMessageW(byref(msg))
+ 		if vision._isDebug():","I think there is a chance that on disable/enable cycling, referring to `self.window` is problematic. In the `__init__` method `self.window` is set to None. If `__init__` gets called before `_run` exits the `while` loop then we wont call `self.window.destroy()`. Can you use non-instance variables after this point? I don't think `self.timer` is used outside this function, if so, then I'd prefer it also be a local variable."
+8921,"@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
+ 	// Set up tests and give ourselves a working directory.
+ 	assert := asrt.New(t)
+
++	noninteractive := ""DRUD_NONINTERACTIVE""
++	// nolint: errcheck
++	defer os.Setenv(noninteractive, os.Getenv(noninteractive))
++	err := os.Unsetenv(noninteractive)
++	assert.NoError(err)
++
+ 	testMatrix := map[string][]string{
+ 		""drupal6phpversion"": {AppTypeDrupal6, PHP56},
+ 		""drupal7phpversion"": {AppTypeDrupal7, PHP71},","I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?"
+8922,"@@ -56,9 +56,15 @@ public class TableProperties {
+   public static final String PARQUET_COMPRESSION = ""write.parquet.compression-codec"";
+   public static final String PARQUET_COMPRESSION_DEFAULT = ""gzip"";
+
++  public static final String PARQUET_WRITE_MODE = ""write.parquet.write-mode"";
++  public static final String PARQUET_WRITE_MODE_DEFAULT = ""overwrite"";
++
+   public static final String AVRO_COMPRESSION = ""write.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";
+
++  public static final String AVRO_WRITE_MODE = ""write.avro.write-mode"";
++  public static final String AVRO_WRITE_MODE_DEFAULT = ""overwrite"";
++
+   public static final String SPLIT_SIZE = ""read.split.target-size"";
+   public static final long SPLIT_SIZE_DEFAULT = 134217728; // 128 MB
+ ","  nice, having the ""overwrite"" default makes this change backwards compatible, right?"
+8923,"@@ -108,7 +108,7 @@ public class DefaultReactiveOAuth2UserService implements ReactiveOAuth2UserServi
+ 					authenticationMethod);
+ 			// @formatter:off
+ 			Mono<Map<String, Object>> userAttributes = requestHeadersSpec.retrieve()
+-					.onStatus((s) -> s != HttpStatus.OK, (response) ->
++					.onStatus((s) -> !s.is2xxSuccessful(), (response) ->
+ 						parse(response)
+ 							.map((userInfoErrorResponse) -> {
+ 								String description = userInfoErrorResponse.getErrorObject().getDescription();","It doesn't make sense to accept all 2xx status code. For example, `203 Non-Authoritative Information` or `205 Reset Content`, etc."
+8924,"@@ -385,16 +385,8 @@ class SplitOp implements CoreAdminHandler.CoreAdminOp {
+
+       // compare to current prefix bucket and see if this new term shares the same prefix
+       if (term != null && term.length >= currPrefix.length && currPrefix.length > 0) {
+-        int i = 0;
+-        for (; i < currPrefix.length; i++) {
+-          if (currPrefix.bytes[i] != term.bytes[term.offset + i]) {
+-            break;
+-          }
+-        }
+-
+-        if (i == currPrefix.length) {
+-          // prefix was the same (common-case fast path)
+-          // int count = termsEnum.docFreq();
++        BytesRef termPrefix = new BytesRef(term.bytes, term.offset, currPrefix.length);
++        if (termPrefix.bytesEquals(currPrefix)) {
+           bucketCount++;  // use 1 since we are dealing with unique ids
+           continue;
+         }",Found a better choice here that doesn't involve object creation: StringHelper.startsWith()
+8925,"@@ -250,8 +250,15 @@ func (s *nodeServer) attest(
+ 	attestedData *common.AttestedData, attestedBefore bool) (
+ 	response *nodeattestor.AttestResponse, err error) {
+
+-	// TODO: Pick the right node attestor [#222]
+-	nodeAttestor := s.catalog.NodeAttestors()[0]
++	// Pick the right node attestor
++	var nodeAttestor nodeattestor.NodeAttestor
++	for _, a := range s.catalog.NodeAttestors() {
++		mp := s.catalog.Find(a)
++		if mp.Config.PluginName == attestedData.Type {
++			nodeAttestor = a
++			break
++		}
++	}
+
+ 	attestRequest := &nodeattestor.AttestRequest{
+ 		AttestedData:   attestedData,",Shouldn't we consider the situation where it doesn't find a plugin?
+8926,"@@ -24,7 +24,12 @@ namespace oneapi::dal::csv {
+ template <>
+ class detail::v1::read_args_impl<table> : public base {
+ public:
+-    read_args_impl() {}
++    read_args_impl(preview::read_mode mode = preview::read_mode::table) : mode(mode) {
++        if (mode != preview::read_mode::table)
++            throw invalid_argument(dal::detail::error_messages::unsupported_read_mode());
++    }
++
++    preview::read_mode mode;
+ };
+
+ namespace v1 {",Do not understand why this needed for table. All new classes defined in the `preview` namespace.
+8927,"@@ -17,6 +17,8 @@
+ package com.yahoo.athenz.common.server.notification;
+
+ public final class NotificationServiceConstants {
++    public static final String NOTIFICATION_PROP_SERVICE_FACTORY_CLASS = ""athenz.zms.notification_service_factory_class"";
++
+     public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL           = ""MEMBERSHIP_APPROVAL"";
+     public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL_REMINDER  = ""MEMBERSHIP_APPROVAL_REMINDER"";
+     public static final String NOTIFICATION_TYPE_PRINCIPAL_EXPIRY_REMINDER     = ""PRINCIPAL_EXPIRY_REMINDER"";",Kept the same property value even though it is now in Common to avoid breaking existing clients.
+8928,"@@ -52,7 +52,7 @@ public class InclusiveMetricsEvaluator {
+     return visitors.get();
+   }
+
+-  InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
++  public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
+     this(schema, unbound, true);
+   }
+ ",TODO: this is temporary until we figure out case sensitivity for metrics evaluators.
+8929,"@@ -503,9 +503,10 @@ func (node *Node) Start(ctx context.Context) error {
+ 		// TODO it is possible the syncer interface should be modified to
+ 		// make use of the additional context not used here (from addr + height).
+ 		// To keep things simple for now this info is not used.
+-		err := node.Syncer.HandleNewBlocks(context.Background(), cids)
++		cidSet := types.NewSortedCidSet(cids...)
++		err := node.Syncer.HandleNewTipset(context.Background(), cidSet)
+ 		if err != nil {
+-			log.Infof(""error handling blocks: %s"", types.NewSortedCidSet(cids...).String())
++			log.Infof(""error handling blocks: %s"", cidSet.String())
+ 		}
+ 	}
+ 	node.HelloSvc = hello.New(node.Host(), node.ChainReader.GenesisCid(), syncCallBack, node.ChainReader.Head, node.Repo.Config().Net, flags.Commit)",can we just kill this TODO?
+8930,"@@ -33,7 +33,7 @@ func TestDAGGet(t *testing.T) {
+ 		dag := NewDAG(dserv)
+
+ 		_, err := dag.GetNode(ctx, ""awful"")
+-		assert.EqualError(t, err, ""invalid 'ipfs ref' path"")
++		assert.EqualError(t, err, ""invalid path \""awful\"": selected encoding not supported"")
+ 	})
+
+ 	t.Run(""ILPD node not found results in error"", func(t *testing.T) {",This appears to be a change in error handling due to a dag upgrade.
+8931,"@@ -246,7 +246,9 @@ module Beaker
+           end
+
+           it 'calls beaker-hostgenerator to get hosts information' do
+-            parser.instance_variable_set( :@options, {} )
++            parser.instance_variable_set( :@options, {
++              :hosts_file => 'notafile.yml'
++            } )
+             allow( Beaker::Options::HostsFileParser ).to receive(
+               :parse_hosts_file
+             ).and_raise( Errno::ENOENT )",These changes look like a hosts file _must_ be provided?
+8932,"@@ -92,8 +92,9 @@ int FixPythonInvoke::setmask()
+ void FixPythonInvoke::end_of_step()
+ {
+   PyUtils::GIL lock;
++  char fmt[] = ""O"";
+
+-  PyObject * result = PyObject_CallFunction((PyObject*)pFunc, ""O"", (PyObject*)lmpPtr);
++  PyObject * result = PyObject_CallFunction((PyObject*)pFunc, fmt, (PyObject*)lmpPtr);
+
+   if (!result) {
+     PyUtils::Print_Errors();","@akohlmey Just make it a cast like the others. I dislike it either way, but that's the price we pay for Python 2 support."
+8933,"@@ -68,6 +68,7 @@ program
+   .option('--disable_brave_extension', 'disable loading the Brave extension')
+   .option('--disable_pdfjs_extension', 'disable loading the PDFJS extension')
+   .option('--enable_brave_update', 'enable brave update')
++  .option('--channel <target_chanel>', 'target channel to start', /^(beta|dev|nightly|release)$/i, 'release')
+   .arguments('[build_config]')
+   .action(start)
+ ",I wonder if the default here should be nightly? I won't block on that though just a question for a follow up.
+8934,"@@ -181,7 +181,7 @@ namespace TestRunner
+             Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException);
+             Application.ThreadException += ThreadExceptionEventHandler;
+
+-            Console.OutputEncoding = Encoding.UTF8;  // So we can send Japanese to SkylineTester, which monitors our stdout
++            //Console.OutputEncoding = Encoding.UTF8;  // So we can send Japanese to SkylineTester, which monitors our stdout
+
+             // Parse command line args and initialize default values.
+             const string commandLineOptions =",Also not for merge to master.
+8935,"@@ -201,6 +201,10 @@ class ScheduleDefinition:
+             raise DagsterInvalidDefinitionError(
+                 f""Found invalid cron schedule '{self._cron_schedule}' for schedule '{name}''.""
+             )
++        if len(self._cron_schedule.split("" "")) != 5:
++            raise DagsterInvalidDefinitionError(
++                f""Found non-standard cron schedule '{self._cron_schedule}' for schedule '{name}''.""
++            )
+
+         if job is not None:
+             self._target: Union[DirectTarget, RepoRelativeTarget] = DirectTarget(job)","nit `non-standard` might be a bit subjective - maybe ""Cron schedule {blah} is in an unrecognized format. Dagster cron strings must consist of five characters separated by a single space chacater""."
+8936,"@@ -163,7 +163,6 @@ public class ServerPickerActivityTest {
+             openCustomEditDialog();
+         }
+         setText(com.salesforce.androidsdk.R.id.sf__picker_custom_label, label);
+-        clickView(com.salesforce.androidsdk.R.id.sf__picker_custom_url);
+         setText(com.salesforce.androidsdk.R.id.sf__picker_custom_url, url);
+     }
+ ",ARM emulator gets tripped up on the copy/paste menu when tapping the text. Tapping on the text field isn't necessary for setting text.
+8937,"@@ -68,11 +68,12 @@ public class SpellChecker {
+     }
+
+     char[] wordChars = word.toCharArray();
+-    if (dictionary.isForbiddenWord(wordChars, wordChars.length)) {
+-      return false;
++    Boolean simpleResult = checkSimpleWord(wordChars, wordChars.length, null);
++    if (simpleResult != null) {
++      return simpleResult;
+     }
+
+-    if (checkWord(wordChars, wordChars.length, null)) {
++    if (checkCompounds(wordChars, wordChars.length, null)) {
+       return true;
+     }
+ ",extra word lookup removed
+8938,"@@ -520,6 +520,12 @@ webdriver.WebDriver.prototype.call = function(fn, opt_scope, var_args) {
+  * Schedules a command to wait for a condition to hold, as defined by some
+  * user supplied function. If any errors occur while evaluating the wait, they
+  * will be allowed to propagate.
++ *
++ * <p>In the event a condition returns a Promise, the polling loop will wait
++ * for it to be resolved and use the resolved value for evaluating whether the
++ * condition has been satisfied. The resolution time for a promise is factored
++ * into whether a wait has timed out.
++ *
+  * @param {function():boolean} fn The function to evaluate as a wait condition.
+  * @param {number} timeout How long to wait for the condition to be true.
+  * @param {string=} opt_message An optional message to use if the wait times",Will you link to {!webdriver.promise.Promise} here?
+8939,"@@ -45,6 +45,7 @@ Workshops::Application.routes.draw do
+     resources :licenses, only: [:create]
+   end
+   get '/products/:id/purchases/:lookup' => redirect(""/purchases/%{lookup}"")
++  get '/purchases/:lookup' => 'pages#show', id: 'purchase-show'
+
+   resources :books, only: :show, controller: 'products' do
+     resources :licenses, only: [:create]",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+8940,"@@ -96,11 +96,10 @@ public class DataService extends IntentService {
+                 ObjectivesPlugin.bgIsAvailableInNS = true;
+                 ObjectivesPlugin.saveProgress();
+             } else if (isNSProfile && Intents.ACTION_NEW_PROFILE.equals(action)){
+-                // always handle Profili if NSProfile is enabled without looking at nsUploadOnly
++                // always handle Profile if NSProfile is enabled without looking at nsUploadOnly
+                 handleNewDataFromNSClient(intent);
+             } else if (!nsUploadOnly &&
+-                    (Intents.ACTION_NEW_PROFILE.equals(action) ||
+-                            Intents.ACTION_NEW_TREATMENT.equals(action) ||
++                    (Intents.ACTION_NEW_TREATMENT.equals(action) ||
+                             Intents.ACTION_CHANGED_TREATMENT.equals(action) ||
+                             Intents.ACTION_REMOVED_TREATMENT.equals(action) ||
+                             Intents.ACTION_NEW_STATUS.equals(action) ||",@AdrianLxM finally found some your bug too :)
+8941,"@@ -1543,7 +1543,9 @@ void cvdescriptorset::ImageSamplerDescriptor::UpdateDrawState(layer_data *dev_da
+     if (iv_state) {
+         core_validation::AddCommandBufferBindingImageView(dev_data, cb_node, iv_state);
+     }
+-    SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
++    if (image_view_) {
++        SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
++    }
+ }
+
+ cvdescriptorset::ImageDescriptor::ImageDescriptor(const VkDescriptorType type)",This crashed in an app using descriptor_indexing with some unbound descriptors.
+8942,"@@ -39,14 +39,15 @@ MODULES_TO_CHECK = [
+ MODULES_NAMES = [m[1] for m in MODULES_TO_CHECK]
+
+
+-@pytest.mark.primer_stdlib
++@pytest.mark.primer
+ @pytest.mark.parametrize(
+     (""test_module_location"", ""test_module_name""), MODULES_TO_CHECK, ids=MODULES_NAMES
+ )
+-def test_lib_module_no_crash(
++def test_primer_stdlib_no_crash(
+     test_module_location: str, test_module_name: str, capsys: CaptureFixture
+ ) -> None:
+     """"""Test that pylint does not produces any crashes or fatal errors on stdlib modules""""""
++    __tracebackhide__ = True  # pylint: disable=unused-variable
+     os.chdir(test_module_location)
+     with _patch_stdout(io.StringIO()):
+         try:",I think we might want to keep these marks separate? Then we can create a new `workflow` file with 3 jobs: 1) Prime stdlib 2) Prime batch 1 of external 2) Prime batch 2 of external
+8943,"@@ -263,6 +263,13 @@ namespace MvvmCross.Droid.Support.V4
+ 			{
+ 				((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.Clear();
+ 				((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.PutAll(bundle);
++
++                var childViewModelCache = Mvx.GetSingleton<IMvxChildViewModelCache>();
++                if (childViewModelCache.Exists(fragInfo.CachedFragment.ViewModel.GetType()))
++                {
++                    fragInfo.CachedFragment.ViewModel = childViewModelCache.Get(fragInfo.CachedFragment.ViewModel.GetType());
++                    childViewModelCache.Remove(fragInfo.CachedFragment.ViewModel.GetType());
++                }
+ 			}
+ 			else
+ 			{",Throw `fragInfo.CachedFragment.ViewModel.GetType()` into a variable so it's not evaluated each time.
+8944,"@@ -189,7 +189,7 @@ class User < ActiveRecord::Base
+   end
+
+   def preferred_languages
+-    @preferred_languages ||= Locale.list(languages)
++    Locale.list(languages)
+   end
+
+   def nearby(radius = NEARBY_RADIUS, num = NEARBY_USERS)",Rather than just getting rid of the memoization maybe we should use an `after_save` filter to set it to `nil` so that it will be recomputed on next read?
+8945,"@@ -0,0 +1,3 @@
++export default function remove(el) {
++	el.parentNode && el.parentNode.removeChild(el);
++}",JS abstraction leaks so this should be `if (el.parentNode !== null) { el.parentNode.removeChild(el) }` @developit
+8946,"@@ -30,6 +30,15 @@ type LedgerUSB struct {
+ 	hiddev *hid.Device
+ }
+
++// LedgerUSBError is a wrapper around the two-byte error code that the Ledger
++// protocol returns.
++type LedgerUSBError uint16
++
++// Error satisfies builtin interface `error`
++func (err LedgerUSBError) Error() string {
++	return fmt.Sprintf(""unexpected status %x"", err)
++}
++
+ // Protocol reference:
+ // https://github.com/LedgerHQ/blue-loader-python/blob/master/ledgerblue/comm.py (see HIDDongleHIDAPI)
+ // https://github.com/LedgerHQ/blue-loader-python/blob/master/ledgerblue/ledgerWrapper.py (see wrapCommandAPDU)",nit: change it to `Exchange: unexpected status 0x%x` so that we'll know where this issue came from as well as making it easier to decode.
+8947,"@@ -23,13 +23,7 @@ func CstorVolumeArtifactsFor070() (list ArtifactList) {
+ 	return
+ }
+
+-// cstorVolumeYamlsFor070 returns all the yamls related to cstor volume in a
+-// string format
+-//
+-// NOTE:
+-//  This is an implementation of MultiYamlFetcher
+-func cstorVolumeYamlsFor070() string {
+-	return `
++const cstorRunTask = `
+ ---
+ apiVersion: openebs.io/v1alpha1
+ kind: CASTemplate",Name of constant is not appropriate. Name of constant should make use of version no. as suffix. The constant can be a typed string versus a string.
+8948,"@@ -51,6 +51,7 @@ module Bolt
+           command_options = []
+           # Need to be interactive if redirecting STDIN
+           command_options << '--interactive' unless options[:stdin].nil?
++          command_options << '--tty' if options[:tty]
+           command_options.concat(envs) unless envs.empty?
+           command_options << container_id
+           command_options.concat(command)",@glennsarti you want to validate this on Windows? IIRC this won't work
+8949,"@@ -45,8 +45,11 @@ public class ZipkinElasticsearchHttpStorageAutoConfiguration {
+   ElasticsearchHttpStorage.Builder esHttpBuilder(
+       ZipkinElasticsearchHttpStorageProperties elasticsearch,
+       @Qualifier(""zipkinElasticsearchHttp"") OkHttpClient client,
+-      @Value(""${zipkin.storage.strict-trace-id:true}"") boolean strictTraceId) {
+-    return elasticsearch.toBuilder(client).strictTraceId(strictTraceId);
++      @Value(""${zipkin.storage.strict-trace-id:true}"") boolean strictTraceId,
++      @Value(""${zipkin.query.lookback:86400000}"") int namesLookback) {
++    return elasticsearch.toBuilder(client)
++        .strictTraceId(strictTraceId)
++        .namesLookback(namesLookback);
+   }
+
+   /** cheap check to see if we are likely to include urls */",ps I'm ok to add this as a elasticsearch property instead. ex zipkin.storage.elasticsearch.names-lookback (we have similar things in cassandra)
+8950,"@@ -69,12 +69,12 @@ class Search implements IWebSearch {
+   }
+
+   /**
+-   * Force a reindex.
++   * Force a re-index.
+    */
+   reindex() {
+     let self = this;
+-    this.storage.getLocalDatabase(function(err, packages) {
+-      if (err) throw err; // that function shouldn't produce any
++    this.storage.getLocalDatabase(function(error, packages) {
++      if (error) throw error; // that function shouldn't produce any
+       let i = packages.length;
+       while (i--) {
+         self.add(packages[i]);",Curly brackets here `{ (breakLine) xx (breakLine)}`
+8951,"@@ -450,6 +450,11 @@ window.ConfigurationsView = countlyView.extend({
+                     return false;
+                 }
+
++                if($(this).val() === countlyGlobal[""member""].username){
++                    $("".username-check"").remove();
++                    return false;
++                }
++
+                 $(this).next("".required"").remove();
+
+                 var existSpan = $(""<span class='username-check red-text' data-localize='management-users.username.exists'>"").html(jQuery.i18n.map[""management-users.username.exists""]),","Can you check this case Assuming you have a dashboard with 2 users, test1 and test2 Currently logged in user is test1. You should not be able to change it to test2. You open dev console and paste in `countlyGlobal[""member""].username = ""test2"";` then you enter value test2 in the input and it is allowed and form would be submitted. Would server side validation deal with such case?"
+8952,"@@ -46,13 +46,14 @@ public class DataSourceFactory {
+     static final long MAX_TTL_CONN_MS = TimeUnit.MILLISECONDS.convert(10L, TimeUnit.MINUTES);
+     static final String MYSQL_VALIDATION_QUERY = ""/* ping */ SELECT 1"";
+
++    static final String DRIVER_CLASS_NAME = ""athenz.db.driver.class"";
+     public static PoolableDataSource create(String url, Properties mysqlConnectionProperties) {
+
+         String driver = null;
+         try {
+             if (url.indexOf("":mysql:"") > 0) {
+
+-                driver = ""com.mysql.jdbc.Driver"";
++                driver = System.getProperty(DRIVER_CLASS_NAME, ""com.mysql.jdbc.Driver"");
+                 Class.forName(driver);
+
+                 ConnectionFactory connectionFactory =","since we're changing this class, let's fix the default class name as well. it should be com.mysql.cj.jdbc.Driver"
+8953,"@@ -3,4 +3,13 @@ class Role < ActiveRecord::Base
+   has_many :proposals, through: :proposal_roles
+   has_many :user_roles
+   has_many :users, through: :user_roles
++
++  # Safely ensure that the system roles in `config/initializers/01_c2.rb`
++  # exist in the database. Rails will run this code when it loads the
++  # `Role` class at bootup.
++  def self.ensure_system_roles_exist
++    SYSTEM_ROLES.each { |r| Role.find_or_create_by!(name: r) }
++  end
++
++  ensure_system_roles_exist if connection.table_exists? ""roles""
+ end","At load time, we ensure the config'd objects exist."
+8954,"@@ -153,6 +153,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+                         {
+                             throw new InvalidOperationException($""HTTPS endpoints can only be configured using {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}()."");
+                         }
++                        else if (!parsedAddress.Scheme.Equals(""http"", StringComparison.OrdinalIgnoreCase))
++                        {
++                            throw new InvalidOperationException($""Unrecognized scheme in server address '{address}'. Only 'http://' is supported."");
++                        }
+
+                         if (!string.IsNullOrEmpty(parsedAddress.PathBase))
+                         {",Is there a test for this case?
+8955,"@@ -0,0 +1,14 @@
++<section class=""topic"">
++  <header>
++    <p class=""topic-headline""><%= show.name %></p>
++  </header>
++
++  <%= render partial: ""products/videos/video"", collection: show.latest_videos %>
++
++  <figure class=""card see-more"">
++    <%= link_to show do %>
++      <h4><%= pluralize show.videos.count, ""more #{show.name} episode"" %></h4>
++      <p>View All</p>
++    <% end %>
++  </figure>
++</section>",This copy doesn't match what I had in my mockup. I think it's better to call them episodes.
+8956,"@@ -135,7 +135,11 @@ func (s *server) startService() common.Daemon {
+ 	servicePortMap := make(map[string]int)
+ 	for roleName, svcCfg := range s.cfg.Services {
+ 		serviceName := getServiceName(roleName)
+-		servicePortMap[serviceName] = svcCfg.RPC.Port
++		if serviceName == common.FrontendServiceName || serviceName == common.MatchingServiceName {
++			servicePortMap[serviceName] = svcCfg.RPC.GRPCPort
++		} else {
++			servicePortMap[serviceName] = svcCfg.RPC.Port
++		}
+ 	}
+
+ 	params.MembershipFactory, err = s.cfg.Ringpop.NewFactory(",For some reason it worked for frontend even before this change.
+8957,"@@ -666,7 +666,10 @@ TEST (block_store, large_iteration)
+ 	{
+ 		auto transaction (store.tx_begin (true));
+ 		nano::account account;
+-		nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
++		{
++			std::lock_guard<std::mutex> lk (nano::random_pool_mutex);
++			nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
++		}
+ 		accounts1.insert (account);
+ 		store.account_put (transaction, account, nano::account_info ());
+ 	}",Can we encapsulate this in a function so if we want to change it against we don't have to change all call sites?
+8958,"@@ -470,8 +470,8 @@ void nano::bulk_pull_client::received_block (boost::system::error_code const & e
+ 				connection->start_time = std::chrono::steady_clock::now ();
+ 			}
+ 			connection->attempt->total_blocks++;
+-			total_blocks++;
+ 			bool stop_pull (connection->attempt->process_block (block, known_account, total_blocks, block_expected));
++			total_blocks++;
+ 			if (!stop_pull && !connection->hard_stop.load ())
+ 			{
+ 				/* Process block in lazy pull if not stopped","Maybe a good opportunity to do a related improvement: The parameter `total_blocks` in `bootstrap_attempt::process_block` shadows a field with the same name, so maybe rename the parameter to `total_blocks_a` The parameter and field are incremented at the same time, but the field is used by `populate_connections` as well, so I assume they mean different things. Other than that, LGTM"
+8959,"@@ -9,6 +9,8 @@
+
+ DEFINE_int32(default_parts_num, 100, ""The default number of parts when a space is created"");
+ DEFINE_int32(default_replica_factor, 1, ""The default replica factor when a space is created"");
++DEFINE_int32(default_space_sum, 100, ""The default number of space can be created"");
++DEFINE_int32(default_max_replica_factor, 1, ""The default max replica factor that a space can take"");
+
+ namespace nebula {
+ namespace meta {",Please revise the naming of these two flags. _**default**_ is the value we take when user doesn't provide. You could infer from the fact how `default_parts_num` are used.
+8960,"@@ -24,12 +24,13 @@ import java.util.Map;
+ import java.util.Set;
+ import java.util.TreeSet;
+
+-public class ImportTypeTransformer {
++public class ImportTypeTransformer implements ImportGenerator {
+   private enum ImportFileType {
+     SERVICE_FILE,
+     PROTO_FILE
+   }
+
++  @Override
+   public List<ImportTypeView> generateImports(Map<String, TypeAlias> imports) {
+     List<ImportTypeView> generatedImports = new ArrayList<>();
+     for (String key : imports.keySet()) {","I don't think we should have separate ""transformer"" and ""generator"" terms. I would suggest renaming this existing class `ImportTypeTransformer` to `StandardImportTypeTransformer` and renaming the interface `ImportGenerator` to `ImportTypeTransformer`."
+8961,"@@ -1,4 +1,4 @@
+ export { default as getContainers } from './get-containers';
+ export { default as isValidAccountID } from './is-valid-account-id';
+ export { default as isValidContainerID } from './is-valid-container-id';
+-export { default as tagMatchers } from './tag-matchers';
++export { default as tagMatchers } from './tagMatchers';","I believe `tag-matchers` is the proper form for this filename. Only components should use pascal case, I believe everything else should continue to use kabob-case."
+8962,"@@ -19,6 +19,7 @@ package pubsub
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1""
+
+ 	pubsubsourcev1alpha1 ""github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1""
+ 	pubsubsourceclientset ""github.com/google/knative-gcp/pkg/client/clientset/versioned""","same here, move this one down"
+8963,"@@ -112,6 +112,7 @@ class OrderDataFixture extends AbstractReferenceFixture implements DependentFixt
+         $orderData->domainId = Domain::FIRST_DOMAIN_ID;
+         $orderData->currency = $this->getReference(CurrencyDataFixture::CURRENCY_CZK);
+         $orderData->createdAt = $this->faker->dateTimeBetween('-1 week', 'now');
++        $orderData->createdAsAdministrator = $this->getReference(AdministratorDataFixture::ADMINISTRATOR);
+         $this->createOrder(
+             $orderData,
+             [","Some could be created as superadmin instead, to add more special cases. Also, the reason behind this change should be described in the commit msg and the PR description."
+8964,"@@ -28,6 +28,7 @@ from pyspark.sql import functions as F
+ from pyspark.sql.types import FloatType, DoubleType, LongType, StructType, TimestampType, \
+     to_arrow_type
+
++from databricks import koalas as ks
+ from databricks.koalas.dask.utils import derived_from
+ from databricks.koalas.frame import DataFrame
+ from databricks.koalas.generic import _Frame, max_display_count",Is this required?
+8965,"@@ -483,9 +483,10 @@ func start(c *cli.Context) error {
+ 			Cluster:       cm,
+ 			StoragePolicy: sp,
+ 			Security: &sdk.SecurityConfig{
+-				Role:           rm,
+-				Tls:            tlsConfig,
+-				Authenticators: authenticators,
++				Role:                         rm,
++				Tls:                          tlsConfig,
++				Authenticators:               authenticators,
++				PublicVolumeCreationDisabled: !c.Bool(""public-volume-create-allowed""),
+ 			},
+ 		})
+ 		if err != nil {","`--public-volume-create-allowed=true` and set the default to `true`, then use `!c.Bool('...')`"
+8966,"@@ -867,7 +867,9 @@ static int handle_goaway_frame(h2o_http2_conn_t *conn, h2o_http2_frame_t *frame,
+     if ((ret = h2o_http2_decode_goaway_payload(&payload, frame, err_desc)) != 0)
+         return ret;
+
+-    /* nothing to do, since we do not open new streams by ourselves */
++    /* stop opening new push streams hereafter */
++    conn->push_stream_ids.max_open = INT32_MAX;
++
+     return 0;
+ }
+ ","Could we use `0x7ffffffe` instead, since `INT32_MAX` is an ID of a _pull_ stream? Other than that the PR seems ready for merge. Thank you for working on the fix."
+8967,"@@ -86,11 +86,11 @@ module Beaker
+         execute_rake_task(""beaker_quickstart:gen_hosts[vmpooler]"")
+       end
+
+-      # Print a message to the console and exit with 0
++      # Print a message to the console and exit with 1
+       # @param [String] msg the message to print
+-      def self.exit_with(msg)
++      def self.exit_with(msg, exit_code=1)
+         puts msg
+-        exit(0)
++        exit(exit_code)
+       end
+
+       # Call the quick start task for the specified hypervisor",Might as well add a docstring for the new `exit_code` parameter too.
+8968,"@@ -77,8 +77,8 @@ public class LocalNewSessionQueuer extends NewSessionQueuer {
+   }
+
+   @Override
+-  public Optional<HttpRequest> remove() {
+-    return sessionRequests.poll();
++  public Optional<HttpRequest> remove(RequestId id) {
++    return sessionRequests.poll(id);
+   }
+
+   @Override",`poll` and `remove` have different meanings.
+8969,"@@ -111,6 +111,15 @@ public class TableProperties {
+   public static final String DELETE_AVRO_COMPRESSION = ""write.delete.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";
+
++  public static final String PARQUET_BLOOM_FILTER_ENABLED = ""write.parquet.bloom-filter-enabled"";
++  public static final boolean PARQUET_BLOOM_FILTER_ENABLED_DEFAULT = false;
++
++  public static final String PARQUET_BLOOM_FILTER_EXPECTED_NDV = ""write.parquet.bloom-filter-expected-ndv"";
++  public static final long PARQUET_BLOOM_FILTER_EXPECTED_NDV_DEFAULT = -1L;
++
++  public static final String PARQUET_BLOOM_FILTER_MAX_BYTES = ""write.parquet.bloom-filter-max-bytes"";
++  public static final int PARQUET_BLOOM_FILTER_MAX_BYTES_DEFAULT = 1024 * 1024;
++
+   public static final String SPLIT_SIZE = ""read.split.target-size"";
+   public static final long SPLIT_SIZE_DEFAULT = 134217728; // 128 MB
+ ",What's the perf impact of writing bloom filer? Does it make sense to enable it by default if the perf impact is minor? Would be nice to include benchmarks?
+8970,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (IAM) role.]
++//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (AWS IAM) role.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+8971,"@@ -162,13 +162,13 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
+   {""cuMemAlloc"",                                           {""hipMalloc"",                                               """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAlloc_v2"",                                        {""hipMalloc"",                                               """", CONV_MEMORY, API_DRIVER}},
+   // cudaHostAlloc
+-  {""cuMemAllocHost"",                                       {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemAllocHost"",                                       {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAllocHost_v2"",                                    {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // cudaMallocManaged
+   {""cuMemAllocManaged"",                                    {""hipMemAllocManaged"",                                      """", CONV_MEMORY, API_DRIVER}},
+   // no analogue
+   // NOTE: Not equal to cudaMallocPitch due to different signatures
+-  {""cuMemAllocPitch"",                                      {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemAllocPitch"",                                      {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAllocPitch_v2"",                                   {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy due to different signatures",Remove `HIP_UNSUPPORTED` - it is an alias
+8972,"@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
+   public void unassignExecutor(int executionId) throws ExecutorManagerException {
+     executionExecutorMapping.remove(executionId);
+   }
++
++  @Override
++  public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
++      throws ExecutorManagerException {
++    return null;
++  }
+ }",i think we should return an empty list instead of null here.
+8973,"@@ -104,10 +104,14 @@ public class UserPreferences {
+     public static final String PREF_ENABLE_AUTODL_WIFI_FILTER = ""prefEnableAutoDownloadWifiFilter"";
+     private static final String PREF_AUTODL_SELECTED_NETWORKS = ""prefAutodownloadSelectedNetworks"";
+     private static final String PREF_PROXY_TYPE = ""prefProxyType"";
+-    private static final String PREF_PROXY_HOST = ""prefProxyHost"";
+-    private static final String PREF_PROXY_PORT = ""prefProxyPort"";
+-    private static final String PREF_PROXY_USER = ""prefProxyUser"";
+-    private static final String PREF_PROXY_PASSWORD = ""prefProxyPassword"";
++    private static final String PREF_HTTP_PROXY_HOST = ""prefHttpProxyHost"";
++    private static final String PREF_HTTP_PROXY_PORT = ""prefHttpProxyPort"";
++    private static final String PREF_HTTP_PROXY_USER = ""prefHttpProxyUser"";
++    private static final String PREF_HTTP_PROXY_PASSWORD = ""prefHttpProxyPassword"";
++    private static final String PREF_SOCKS_PROXY_HOST = ""prefSocksProxyHost"";
++    private static final String PREF_SOCKS_PROXY_PORT = ""prefSocksProxyPort"";
++    private static final String PREF_SOCKS_PROXY_USER = ""prefSocksProxyUser"";
++    private static final String PREF_SOCKS_PROXY_PASSWORD = ""prefSocksProxyPassword"";
+
+     // Services
+     private static final String PREF_GPODNET_NOTIFICATIONS = ""pref_gpodnet_notifications"";","Is it really necessary to store them in a new setting? I think it should be enough to store the credentials in `ProxyConfig.direct()`. Then AntennaPod does not need to store multiple different proxy settings. Also, it will not change existing users' settings (currently the proxy settings would be lost on upgrade)."
+8974,"@@ -2115,10 +2115,15 @@ namespace pwiz.Skyline.Model
+         public static double GetCollisionEnergy(SrmSettings settings, PeptideDocNode nodePep,
+             TransitionGroupDocNode nodeGroup, TransitionDocNode nodeTran, CollisionEnergyRegression regression, int step)
+         {
+-            var ce = nodeTran==null // If we're only given a precursor, use the explicit CE of its children if they all agree
+-                ? (nodeGroup.Children.Any() && nodeGroup.Children.All( node => ((TransitionDocNode)node).ExplicitValues.CollisionEnergy == ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy)
+-                    ? ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy : null)
+-                : nodeTran.ExplicitValues.CollisionEnergy;
++            // Collision Energy explicitly declared at the transition level is taken to be the correct value.
++            // If that is not present, explicitly declared value at the precursor level is used.
++            // If that is not present, the CE is calculated using the provided regression if any.
++            var ce = nodeTran == null ?
++                // If we're only given a precursor, use the explicit CE of its children if they all agree, else use precursor explicit CE
++                (nodeGroup.Children.Select(node => ((TransitionDocNode)node).ExplicitValues.CollisionEnergy).Distinct().Count() == 1 ?
++                    ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy : null) ?? nodeGroup.ExplicitValues.CollisionEnergy :
++                // Otherwise use explicit precursor CE if no explicit transition CE given
++                nodeTran.ExplicitValues.CollisionEnergy ?? nodeGroup.ExplicitValues.CollisionEnergy;
+             if (regression != null)
+             {
+                 if (!ce.HasValue)","This is a mess. Can it be broken out as a separate function using ifs and return statements, which would also make it more debuggable."
+8975,"@@ -1457,8 +1457,16 @@ class GenericCompositePlot(DimensionedPlot):
+
+         key_map = dict(zip([d.name for d in self.dimensions], key))
+         for path, item in self.layout.items():
+-            frame = item.map(lambda x: get_plot_frame(x, key_map, cached=cached),
+-                             ['DynamicMap', 'HoloMap'])
++            clone = item.map(lambda x: x)
++
++            # Ensure that DynamicMaps in the cloned frame have
++            # identical callback inputs to allow memoization to work
++            for it1, it2 in zip(item.traverse(lambda x: x), clone.traverse(lambda x: x)):
++                if isinstance(it1, DynamicMap):
++                    with util.disable_constant(it2.callback):
++                        it2.callback.inputs = it1.callback.inputs
++            frame = clone.map(lambda x: get_plot_frame(x, key_map, cached=cached),
++                              [DynamicMap, HoloMap], clone=False)
+             if frame is not None:
+                 layout_frame[path] = frame
+         traverse_setter(self, '_force', False)",This stuff is a bit ugly and should probably become a utility. The main problem is that ``.map`` is being abused a bit.
+8976,"@@ -1128,6 +1128,9 @@ class ShareableResource(UserResource):
+         filters = super(ShareableResource, self)._extract_filters(queryparams)
+
+         ids = self.context.shared_ids
++        if getattr(self.context, ""forced_empty_list"", False):
++            ids = ['UNKNOWN']
++
+         if ids:
+             filter_by_id = Filter(self.model.id_field, ids, COMPARISON.IN)
+             filters.insert(0, filter_by_id)",Maybe there is a better way here so that we don't even bother triggering a storage query since we want an empty list here.
+8977,"@@ -0,0 +1,16 @@
++package aws
++
++import (
++	""context""
++
++	""github.com/aws/aws-sdk-go-v2/service/iam""
++)
++
++func (c *client) SimulateCustomPolicy(ctx context.Context, region string, customPolicySimulatorParams *iam.SimulateCustomPolicyInput) (*iam.SimulateCustomPolicyOutput, error) {
++	rc, err := c.getRegionalClient(region)
++	if err != nil {
++		return nil, err
++	}
++
++	return rc.iam.SimulateCustomPolicy(ctx, customPolicySimulatorParams)
++}","just curious, `region` is not used in the AWS IAM client, afaik. But I see this is a general field for clutch clients, is it just ignored internally?"
+8978,"@@ -7,7 +7,7 @@
+  * ""License""); you may not use this file except in compliance
+  * with the License. You may obtain a copy of the License at
+  *
+- *   http://www.apache.org/licenses/LICENSE-2.0
++ * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing,
+  * software distributed under the License is distributed on an",Why are we doing that change?
+8979,"@@ -220,7 +220,7 @@ public class ErrorHandler {
+
+   private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
+
+-    if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
++    if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
+       // Not enough information for us to try to rebuild an error.
+       return null;
+     }",Why && changed to || ?
+8980,"@@ -196,6 +196,15 @@ def _unpickle(filepath, serializer):
+         raise ValueError(f'Unrecognized serializer type: {serializer}')
+
+
++def collection_to_single_partition(collection):
++    """"""Merge the parts of a Dask collection into a single partition.""""""
++    if collection is None:
++        return
++    if isinstance(collection, da.Array):
++        return collection.rechunk(*collection.shape)
++    return collection.repartition(npartitions=1)
++
++
+ @pytest.mark.parametrize('output', data_output)
+ @pytest.mark.parametrize('centers', data_centers)
+ def test_classifier(output, centers, client, listen_port):","can you please change this to `_collection_to_single_partition()`, like we've done for alll other helper methods defined in this module?"
+8981,"@@ -24,6 +24,7 @@ namespace Thelia\Core;
+ use Propel\Runtime\Connection\ConnectionManagerSingle;
+ use Propel\Runtime\Connection\ConnectionWrapper;
+ use Propel\Runtime\Propel;
++use Propel\Runtime\ServiceContainer\StandardServiceContainer;
+ use Symfony\Component\Config\FileLocator;
+ use Symfony\Component\Config\Loader\LoaderInterface;
+ use Symfony\Component\Debug\Debug;","This class is never used, don't import it."
+8982,"@@ -41,6 +41,10 @@ namespace Datadog.Trace.DiagnosticListeners
+
+         void IObserver<KeyValuePair<string, object>>.OnNext(KeyValuePair<string, object> value)
+         {
++#if DEBUG
++            // In debug mode we allow exceptions to be catch in the test suite
++            OnNext(value.Key, value.Value);
++#else
+             try
+             {
+                 OnNext(value.Key, value.Value);","Missing a `return`. Either way, I think it's better to add a `#if DEBUG throw;` in the catch block instead (so we keep the log in debug mode)"
+8983,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.
+8984,"@@ -104,6 +104,9 @@ namespace NLog.Config
+         /// </summary>
+         public IList<LoggingRule> LoggingRules { get; private set; }
+
++        internal List<LoggingRule> GetLoggingRulesThreadSafe() {  lock (LoggingRules) return LoggingRules.ToList(); }
++        private void AddLoggingRulesThreadSafe(LoggingRule rule) { lock (LoggingRules) LoggingRules.Add(rule); }
++
+         /// <summary>
+         /// Gets or sets the default culture info to use as <see cref=""LogEventInfo.FormatProvider""/>.
+         /// </summary>",I think we could replace this (well the backing field) with `BlockingCollection` when we drop NET35?
+8985,"@@ -928,6 +928,15 @@ class GroupBy(object):
+                 pser_or_pdf = pdf.groupby(input_groupnames)[name].apply(func)
+             else:
+                 pser_or_pdf = pdf.groupby(input_groupnames).apply(func)
++                keys = set(input_groupnames)
++                should_drop_columns = (
++                    isinstance(pser_or_pdf, pd.DataFrame)
++                    and keys.issubset(set(pser_or_pdf.index.names))
++                    and keys.issubset(set(pser_or_pdf.columns))
++                )
++                if should_drop_columns:
++                    pser_or_pdf = pser_or_pdf.drop(input_groupnames, axis=1)
++
+             kser_or_kdf = ks.from_pandas(pser_or_pdf)
+             if len(pdf) <= limit:
+                 return kser_or_kdf","Can you show before/after output in the PR description? From a cursory look, seems like it will just drop the duplicated column which isn't consistent with pandas' results."
+8986,"@@ -33,6 +33,14 @@ module Bolt
+         @rest = data.reject { |k, _| %w[name nodes config groups].include? k }
+       end
+
++      def check_deprecated_config(context, name, config)
++        if config && config['transports']
++          msg = ""#{context} #{name} contains invalid config option 'transports', see "" \
++                ""https://puppet.com/docs/bolt/0.x/inventory_file.html for the updated format""
++          raise ValidationError.new(msg, @name)
++        end
++      end
++
+       def validate(used_names = Set.new, node_names = Set.new, depth = 0)
+         raise ValidationError.new(""Group does not have a name"", nil) unless @name
+         if used_names.include?(@name)",Added validation that `config: transports` isn't used @adreyer @katelopresti Curious what you think about having Bolt link directly to the docs site.
+8987,"@@ -99,6 +99,7 @@ class AbstractSettings:
+     _FONT_SIZES = {}  # type: typing.Dict[str, typing.Any]
+     _FONT_FAMILIES = {}  # type: typing.Dict[str, typing.Any]
+     _FONT_TO_QFONT = {}  # type: typing.Dict[typing.Any, QFont.StyleHint]
++    _UnknownUrlSchemePolicy = {}  # type: typing.Dict[str, typing.Any]
+
+     def __init__(self, settings: typing.Any) -> None:
+         self._settings = settings",This probably isn't needed anymore now?
+8988,"@@ -3,9 +3,9 @@ import { h } from './h';
+
+ /**
+  * Clones the given VNode, optionally adding attributes/props and replacing its children.
+- * @param {VNode} vnode		The virtual DOM element to clone
+- * @param {Object} props	Attributes/props to add when cloning
+- * @param {VNode} rest		Any additional arguments will be used as replacement children.
++ * @param {import('./vnode').VNode} vnode The virtual DOM element to clone
++ * @param {object} props Attributes/props to add when cloning
++ * @param {Array<import('./vnode').VNode>} [rest] Any additional arguments will be used as replacement children.
+  */
+ export function cloneElement(vnode, props) {
+ 	return h(",Would it be easier to kick this import to the top of the file? It'll get stripped out anyway.
+8989,"@@ -236,7 +236,8 @@ public class MultiTenancyPrivacyController implements PrivacyController {
+     }
+   }
+
+-  private void verifyPrivacyGroupContainsEnclavePublicKey(
++  @Override
++  public void verifyPrivacyGroupContainsEnclavePublicKey(
+       final String privacyGroupId, final String enclavePublicKey) {
+     final PrivacyGroup privacyGroup = enclave.retrievePrivacyGroup(privacyGroupId);
+     if (!privacyGroup.getMembers().contains(enclavePublicKey)) {",are you sure that the privacyGroup cannot be null?
+8990,"@@ -120,7 +120,7 @@ def GenerateDepictionMatching2DStructure(mol, reference, confId=-1, referencePat
+     if not referenceMatch:
+       raise ValueError(""Reference does not map to itself"")
+   else:
+-    referenceMatch = range(reference.GetNumAtoms(onlyExplicit=True))
++    referenceMatch = list(range(reference.GetNumAtoms(onlyExplicit=True)))
+   if referencePattern:
+     match = mol.GetSubstructMatch(referencePattern)
+   else:",Wrapped with list
+8991,"@@ -0,0 +1,10 @@
++package stats
++
++// DivideFloat64 returns the value of value divided by base.
++// divide by zero case handled before calling.
++func DivideFloat64(value float64, base float64) (float64, bool) {
++	if base == 0 {
++		return 0, false
++	}
++	return (value / base), true
++}",Please move this to `pkg/stats/v1alpha1`
+8992,"@@ -1,12 +1,13 @@
+ class GithubUser
++  URL_FORMAT = /\A[^\/]+\Z/
+   include ActiveModel::Model
+
+   attr_accessor :url, :bypass_url_validation
+   attr_reader :repositories, :module_name, :password
+   alias_method :username, :url
+
+-  validates :url, format: { with: /\A[^\/]+\Z/, message: I18n.t('invalid_github_username') }
+-  validate :username_must_exist
++  validates :url, format: { with: URL_FORMAT, message: I18n.t('invalid_github_username') }
++  validate :username_must_exist, if: -> { url.match(URL_FORMAT) }
+
+   def attributes
+     { url: username, type: self.class.name }",a small nit pick ...this can go into `lib/patterns.rb` ?
+8993,"@@ -27,7 +27,7 @@ import * as fixtures from '../datastore/__fixtures__';
+ import fetchMock from 'fetch-mock';
+
+ // TODO: update the active class.
+-const activeClass = 'googlesitekit-cta-link--danger';
++const activeClass = 'mdc-tab--active';
+ const url = fixtures.pagespeedMobile.loadingExperience.id;
+ const setupRegistry = ( { dispatch } ) => {
+ 	dispatch( STORE_NAME ).receiveGetReport( fixtures.pagespeedMobile, { url, strategy: STRATEGY_MOBILE } );",The above TODO is no longer necessary I believe
+8994,"@@ -345,7 +345,7 @@ func getPoolLivenessProbe() *corev1.Probe {
+ 	probe := &corev1.Probe{
+ 		Handler: corev1.Handler{
+ 			Exec: &corev1.ExecAction{
+-				Command: []string{""/bin/sh"", ""-c"", ""zfs set io.openebs:livenesstimestamp=\""$(date)\"" cstor-$OPENEBS_IO_POOL_NAME""},
++				Command: []string{""/bin/sh"", ""-c"", ""zfs set io.openebs:livenesstimestamp=\""$(date +%s)\"" cstor-$OPENEBS_IO_POOL_NAME""},
+ 			},
+ 		},
+ 		FailureThreshold:    3,",Why is this change required ?
+8995,"@@ -0,0 +1,16 @@
++package summary
++
++import (
++	""bytes""
++
++	""github.com/russross/blackfriday""
++)
++
++func Markdown(input []byte, wordcount int) []byte {
++	words := bytes.Fields(blackfriday.Markdown(input, Renderer{}, 0))
++	if wordcount > len(words) {
++		wordcount = len(words)
++	}
++
++	return bytes.Join(words[0:wordcount], []byte{' '})
++}",This really is an excerpt. ;-)
+8996,"@@ -164,7 +164,7 @@ func (m *mock) IsWithinDepth(addr swarm.Address) bool {
+ 	if m.isWithinFunc != nil {
+ 		return m.isWithinFunc(addr)
+ 	}
+-	return false
++	return true
+ }
+
+ func (m *mock) EachNeighbor(f topology.EachPeerFunc) error {","@acud The reason why the default is now `true` is because the chunk must be in the neighborhood of the storer peer with this change. The majority of the tests expect a valid receipt so the closest peers in the tests must be in the neighborhood. As of writing this, there is only one test that expects a peer to be out of depth."
+8997,"@@ -44,6 +44,7 @@ import (
+ 	""go.temporal.io/server/common/log/tag""
+ 	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/mysql""      // needed to load mysql plugin
+ 	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql"" // needed to load postgresql plugin
++	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/sqlite""     // needed to load sqlite plugin
+ 	""go.temporal.io/server/temporal""
+ )
+ ","This is what breaks the build. Apparently w/o this line, `sqlite` package is not even compiled. With this line it gets compiled but compilation fails because we don't use CGO for our production Linux builds and > ***Important: because this is a `CGO` enabled package you are required to set the environment variable `CGO_ENABLED=1` and have a `gcc` compile present within your path.***"
+8998,"@@ -58,7 +58,7 @@ test_get_size()
+     }
+
+     // Check sizes of FP/SIMD regs.
+-    for (uint i = 0; i < NUM_SIMD_SLOTS; i++) {
++    for (int i = 0; i < proc_num_simd_saved(); i++) {
+         ASSERT(reg_get_size((reg_id_t)DR_REG_H0 + i) == OPSZ_2);
+         ASSERT(reg_get_size((reg_id_t)DR_REG_S0 + i) == OPSZ_4);
+         ASSERT(reg_get_size((reg_id_t)DR_REG_D0 + i) == OPSZ_8);",This should be all slots
+8999,"@@ -66,7 +66,7 @@ public final class RegistryUtils {
+     serviceRegistry.run();
+   }
+
+-  public static void destory() {
++  public static void destroy() {
+     serviceRegistry.destroy();
+   }
+ ",Need to add deprecated annotation and call the new fixed method to avoid the API broken issue.
+9000,"@@ -36,8 +36,7 @@ public class GleanMetricsService {
+         } else {
+             GleanMetricsService.stop();
+         }
+-        Configuration config = new Configuration(Configuration.DEFAULT_TELEMETRY_ENDPOINT,
+-                                                 BuildConfig.BUILD_TYPE);
++        Configuration config = new Configuration();
+         Glean.INSTANCE.initialize(aContext, config);
+     }
+ ","This was just fixed in mozilla-mobile/android-components#4892. @pocmo is cutting a new Android Components 19 dot release today, so you'll be able to jump to the new version and restore the build type."
+9001,"@@ -131,6 +131,7 @@ func (r *genericInjectReconciler) Reconcile(req ctrl.Request) (ctrl.Result, erro
+ 	if err := r.Client.Get(ctx, req.NamespacedName, target.AsObject()); err != nil {
+ 		if dropNotFound(err) == nil {
+ 			// don't requeue on deletions, which yield a non-found object
++			log.V(logf.TraceLevel).Info(""not found"", ""err"", err)
+ 			return ctrl.Result{}, nil
+ 		}
+ 		log.Error(err, ""unable to fetch target object to inject into"")","Leaving this log line because it helped me to diagnose that the reconciler client was using a different cache than the event sources, so not always seeing the injectable that triggered the reconcile."
+9002,"@@ -4867,7 +4867,10 @@ func (mset *stream) processCatchupMsg(msg []byte) (uint64, error) {
+ 		return 0, errors.New(""bad catchup msg"")
+ 	}
+
++	mset.mu.RLock()
+ 	st := mset.cfg.Storage
++	mset.mu.RUnlock()
++
+ 	if mset.js.limitsExceeded(st) || mset.jsa.limitsExceeded(st) {
+ 		return 0, NewJSInsufficientResourcesError()
+ 	}",Do we need also to protect access to `mset.js` and `mset.jsa` or even `mset.store` down below? (not sure if those are immutable or not).
+9003,"@@ -579,6 +579,7 @@ func (k *KeybaseServiceBase) ResolveImplicitTeamByID(
+ func (k *KeybaseServiceBase) checkForRevokedVerifyingKey(
+ 	ctx context.Context, currUserInfo UserInfo, kid keybase1.KID) (
+ 	newUserInfo UserInfo, exists bool, err error) {
++	newUserInfo = currUserInfo
+ 	for key, info := range currUserInfo.RevokedVerifyingKeys {
+ 		if !key.KID().Equal(kid) {
+ 			continue",I'd rather you do this under `if info.filledInMerkle {` since that's the only place it's relevant.
+9004,"@@ -344,13 +344,8 @@ public class RecoveryStrategy implements Runnable, Closeable {
+                                                                                             // though
+       try {
+         CloudDescriptor cloudDesc = this.coreDescriptor.getCloudDescriptor();
+-        ZkNodeProps leaderprops = zkStateReader.getLeaderRetry(
+-            cloudDesc.getCollectionName(), cloudDesc.getShardId());
+-        final String leaderBaseUrl = leaderprops.getStr(ZkStateReader.BASE_URL_PROP);
+-        final String leaderCoreName = leaderprops.getStr(ZkStateReader.CORE_NAME_PROP);
+-
+-        String leaderUrl = ZkCoreNodeProps.getCoreUrl(leaderBaseUrl, leaderCoreName);
+-
++        ZkNodeProps leaderprops = zkStateReader.getLeaderRetry(cloudDesc.getCollectionName(), cloudDesc.getShardId());
++        String leaderUrl = ZkCoreNodeProps.getCoreUrl(leaderprops);
+         String ourUrl = ZkCoreNodeProps.getCoreUrl(baseUrl, coreName);
+
+         boolean isLeader = leaderUrl.equals(ourUrl); // TODO: We can probably delete most of this code if we say this",*NULL_DEREFERENCE:* object `leaderUrl` last assigned on line 348 could be null and is dereferenced at line 351.
+9005,"@@ -38,9 +38,13 @@ class PlansController < ApplicationController
+   def create
+     @plan = Plan.new
+     authorize @plan
+-
++
+     @plan.principal_investigator = current_user.surname.blank? ? nil : ""#{current_user.firstname} #{current_user.surname}""
+-    @plan.data_contact = current_user.email
++    @plan.principal_investigator_email = current_user.email
++
++    orcid = current_user.identifier_for(IdentifierScheme.find_by(name: 'orcid'))
++    @plan.principal_investigator_identifier = orcid.identifier unless orcid.nil?
++
+     @plan.funder_name = plan_params[:funder_name]
+
+     @plan.visibility = (plan_params['visibility'].blank? ? Rails.application.config.default_plan_visibility :","Since the IdentifierScheme's don't change without us making additional code changes, perhaps this should be added as a constant as we previously did with Perms?"
+9006,"@@ -14,6 +14,7 @@
+ # limitations under the License.
+ #
+
++import os
+ import functools
+ import shutil
+ import sys",nit: We can revert this now.
+9007,"@@ -5,9 +5,19 @@ import android.view.ContextMenu;
+ import android.view.MenuInflater;
+ import android.view.View;
+ import android.view.ViewGroup;
++
+ import androidx.annotation.NonNull;
+ import androidx.annotation.Nullable;
+ import androidx.recyclerview.widget.RecyclerView;
++
++import org.apache.commons.lang3.ArrayUtils;
++
++import java.lang.ref.WeakReference;
++import java.util.ArrayList;
++import java.util.HashSet;
++import java.util.List;
++import java.util.Set;
++
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.activity.MainActivity;
+ import de.danoeh.antennapod.core.feed.FeedItem;","Oh, that's the reason why you have two different data structures here. Does the order of the `selectedItems` list matter? If not, I think it would be more clear if both would be a Set."
+9008,"@@ -2034,6 +2034,7 @@ void LuaScriptInterface::registerFunctions()
+ 	registerClass(""Container"", ""Item"", LuaScriptInterface::luaContainerCreate);
+ 	registerMetaMethod(""Container"", ""__eq"", LuaScriptInterface::luaUserdataCompare);
+
++	registerMethod(""Container"", ""getContentDescription"", LuaScriptInterface::luaContainerGetContentDescription);
+ 	registerMethod(""Container"", ""getSize"", LuaScriptInterface::luaContainerGetSize);
+ 	registerMethod(""Container"", ""getCapacity"", LuaScriptInterface::luaContainerGetCapacity);
+ 	registerMethod(""Container"", ""getEmptySlots"", LuaScriptInterface::luaContainerGetEmptySlots);","Should be named getDescription, since the other description functions are named that."
+9009,"@@ -62,7 +62,9 @@ public class PlatformActivity extends VRActivity implements RenderInterface, CVC
+         if (ControllerClient.isControllerServiceExisted(this)) {
+             mControllerManager = new CVControllerManager(this);
+             mControllerManager.setListener(this);
+-            mType = 1;
++            mType = 1; // Neo2
++            // Enable high res
++            PicovrSDK.SetEyeBufferSize(1920, 1920);
+         } else {
+             mHbManager = new HbManager(this);
+             mHbManager.InitServices();",Don't we want to do this for g2 4k also?
+9010,"@@ -4,6 +4,8 @@ const time = require('./time').default;
+ const Logger = require('./Logger').default;
+ const { _ } = require('./locale');
+ const urlUtils = require('./urlUtils.js');
++const str2ab = require('string-to-arraybuffer');
++const Buffer = require('buffer').Buffer;
+
+ class OneDriveApi {
+ 	// `isPublic` is to tell OneDrive whether the application is a ""public"" one (Mobile and desktop","I would prefer if we don't add this package as it's unsupported, and I expect not necessary. Node buffer supports many formats - is it not possible to use one of its helper functions to load the content?"
+9011,"@@ -205,6 +205,12 @@ type Table struct {
+ 	// to what we calculate from chainToContents.
+ 	chainToDataplaneHashes map[string][]string
+
++	// chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
++	chainsToFullRules map[string][]string
++
++	// hashToFullRules contains a mapping of rule hashes to the full rules.
++	hashToFullRules map[string]string
++
+ 	// hashCommentPrefix holds the prefix that we prepend to our rule-tracking hashes.
+ 	hashCommentPrefix string
+ 	// hashCommentRegexp matches the rule-tracking comment, capturing the rule hash.","I don't think this is used any more, please remove."
+9012,"@@ -219,7 +219,11 @@ def List(inner_type):
+             super(_List, self).__init__(
+                 key='List.{inner_type}'.format(inner_type=inner_type.key),
+                 name=None,
+-                description='List of {inner_type}'.format(inner_type=inner_type.name),
++                description=(
++                    'List of {inner_type}'.format(inner_type=inner_type.name)
++                    if inner_type.name is not None
++                    else 'List of config values'
++                ),
+                 type_attributes=ConfigTypeAttributes(is_builtin=True),
+                 inner_type=inner_type,
+             )","actually use type_name=print_config_type_to_string(self, with_lines=False) to populate this"
+9013,"@@ -71,6 +71,13 @@ class Import extends QueueWorkerBase implements ContainerFactoryPluginInterface
+       foreach ($results as $result) {
+         $queued = $this->processResult($result, $data, $queued);
+       }
++
++      // Delete local resource file.
++      if ($this->container->get('config.factory')->get('datastore.settings')->get('delete_local_resource')) {
++        $uuid = ""{$identifier}_{$version}"";
++        $this->container->get('file_system')->deleteRecursive(""public://resources/{$uuid}"");
++      }
++
+     }
+     catch (\Exception $e) {
+       $this->log(RfcLogLevel::ERROR,","We should be using dependency injection here, instead of fetching the config factory at the last minute from the container. That would allow us to more easily overwrite the ""delete_local_resource"" setting in tests."
+9014,"@@ -21,8 +21,12 @@ import com.codahale.metrics.health.HealthCheckRegistry;
+ import com.codahale.metrics.json.HealthCheckModule;
+ import com.fasterxml.jackson.databind.ObjectMapper;
+ import com.fasterxml.jackson.databind.ObjectWriter;
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
+
+ public class HealthCheckServlet extends HttpServlet {
++    private static final Logger LOG = LoggerFactory.getLogger(HealthCheckServlet.class);
++
+     public static abstract class ContextListener implements ServletContextListener {
+         /**
+          * @return the {@link HealthCheckRegistry} to inject into the servlet context.","everywhere else in the project, `LOGGER` is used"
+9015,"@@ -10,7 +10,7 @@ OSM = {
+   MAX_REQUEST_AREA:        <%= Settings.max_request_area.to_json %>,
+   SERVER_PROTOCOL:         <%= Settings.server_protocol.to_json %>,
+   SERVER_URL:              <%= Settings.server_url.to_json %>,
+-  API_VERSION:             <%= Settings.api_version.to_json %>,
++  API_VERSION:             <%= Settings.api_versions.min_by(&:to_f).to_json %>,
+   STATUS:                  <%= Settings.status.to_json %>,
+   MAX_NOTE_REQUEST_AREA:   <%= Settings.max_note_request_area.to_json %>,
+   OVERPASS_URL:            <%= Settings.overpass_url.to_json %>,","Why is this value set to ""min_by"", and what are the implications of it? Does `&:to_f` play nice with semver (e.g. 1.2.0)?"
+9016,"@@ -0,0 +1,9 @@
++/**
++ * Setup configuration for Jest
++ * This file includes gloabl settings for the JEST environment.
++ */
++import 'raf/polyfill';
++import { configure } from 'enzyme';
++import Adapter from 'enzyme-adapter-react-16';
++
++configure({ adapter: new Adapter() });",typo --> gloabl
+9017,"@@ -356,6 +356,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 	c := context.WithValue(r.Context(), OriginalURLCtxKey, urlCopy)
+ 	r = r.WithContext(c)
+
++	// Setup a replacer for the request that keeps track of placeholder
++	// values across plugins.
++	replacer := NewReplacer(r, nil, """")
++	c = context.WithValue(r.Context(), ReplacerCtxKey, replacer)
++	r = r.WithContext(c)
++
+ 	w.Header().Set(""Server"", caddy.AppName)
+
+ 	status, _ := s.serveHTTP(w, r)","Wanted to double-check: does the `log` middleware still set its own ""empty"" value (should default to `-` at least for the default log format)?"
+9018,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit())
+9019,"@@ -14,12 +14,13 @@ module Bolt
+
+       def print_head; end
+
+-      def initialize(color, verbose, trace, stream = $stdout)
++      def initialize(color, verbose, trace, spin, stream = $stdout)
+         super
+         # Plans and without_default_logging() calls can both be nested, so we
+         # track each of them with a ""stack"" consisting of an integer.
+         @plan_depth = 0
+         @disable_depth = 0
++        @pinwheel = %w[- \\ | /]
+       end
+
+       def colorize(color, string)","Is this going to be configurable? If not, it should just be removed for now."
+9020,"@@ -23,6 +23,13 @@ See :ref:`Parameter` for more info on how to define parameters.
+ import abc
+ import datetime
+ import warnings
++import json
++from json import JSONEncoder
++from collections import OrderedDict
++import collections
++import operator
++import functools
++
+ try:
+     from ConfigParser import NoOptionError, NoSectionError
+ except ImportError:","Maybe just one import line - `from collections import OrderedDict, Mapping` ?"
+9021,"@@ -37,8 +37,8 @@ public class NonRuleWithAllPropertyTypes extends AbstractRule {
+     public static final StringMultiProperty MULTI_STR = new StringMultiProperty(""multiStr"", ""Multiple string values"",
+                                                                                 new String[] {""hello"", ""world""}, 5.0f, '|');
+     public static final PropertyDescriptor<Integer> SINGLE_INT = PropertyFactory.intProperty(""singleInt"").desc(""Single integer value"").require(inRange(1, 10)).defaultValue(8).build();
+-    public static final IntegerMultiProperty MULTI_INT = new IntegerMultiProperty(""multiInt"", ""Multiple integer values"",
+-                                                                                  0, 10, new Integer[] {1, 2, 3, 4}, 5.0f);
++    public static final PropertyDescriptor<List<Integer>> MULTI_INT = PropertyFactory.intListProperty(""multiInt"").desc(""Multiple integer values"").requireEach(inRange(0, 10)).defaultValues(1, 2, 3, 4).build();
++
+     public static final LongProperty SINGLE_LONG = new LongProperty(""singleLong"", ""Single long value"", 1L, 10L, 8L,
+                                                                     3.0f);
+     public static final LongMultiProperty MULTI_LONG = new LongMultiProperty(""multiLong"", ""Multiple long values"", 0L,","Btw this class probably doesn't belong in PMD. It says it's there to test UIs, but arguably UIs can use their own test fixtures, and this in in src/test so probably not even shipped anywhere."
+9022,"@@ -50,6 +50,8 @@ describe( 'AMPContainerSelect', () => {
+ 		registry.dispatch( STORE_NAME ).setAccountID( accountID );
+ 		registry.dispatch( STORE_NAME ).receiveGetAccounts( [ account ] );
+ 		registry.dispatch( STORE_NAME ).receiveGetContainers( [ ...webContainers, ...ampContainers ], { accountID } );
++		registry.dispatch( STORE_NAME ).finishResolution( 'getAccounts', [] );
++		registry.dispatch( STORE_NAME ).finishResolution( 'getContainers', [ accountID ] );
+
+ 		const { getAllByRole } = render( <AMPContainerSelect />, { registry } );
+ ",Maybe we can group each `finishResolution` call with the corresponding `receiveGet...` call? That would make the connection more clear when reading the code.
+9023,"@@ -109,9 +109,9 @@ class ServerConnectionMixin(object):
+                         self.disconnect()
+     """"""
+
+-    def __init__(self, server_address=None):
++    def __init__(self, server_address=None, source_address=None):
+         super(ServerConnectionMixin, self).__init__()
+-        self.server_conn = ServerConnection(server_address)
++        self.server_conn = ServerConnection(server_address, source_address)
+         self.__check_self_connect()
+
+     def __check_self_connect(self):",Can we take this out of the constructor here and just use the config value? (This would also make the other proxy mode cases obsolete)
+9024,"@@ -1350,9 +1350,14 @@ class RustGenerator : public BaseGenerator {
+         code_ +=
+             ""    if self.{{FIELD_TYPE_FIELD_NAME}}_type() == ""
+             ""{{U_ELEMENT_ENUM_TYPE}} {"";
+-        code_ +=
+-            ""      self.{{FIELD_NAME}}().map(|u| ""
+-            ""{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        if (!field.required) {
++          code_ +=
++              ""      self.{{FIELD_NAME}}().map(|u| ""
++              ""{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        } else {
++          code_ += ""      let u = self.{{FIELD_NAME}}();"";
++          code_ += ""      Some({{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        }
+         code_ += ""    } else {"";
+         code_ += ""      None"";
+         code_ += ""    }"";",Please flip the conditional to be `if (field.required) { ... }`.
+9025,"@@ -11,7 +11,10 @@ describe 'User creation when logging in with Oauth to view a protected page' do
+       get '/auth/myusa/callback'
+     }.to change { User.count }.by(1)
+
+-    expect(User.last.email_address).to eq('george-test@example.com')
++    new_user = User.last
++    expect(new_user.email_address).to eq('george-test@example.com')
++    expect(new_user.first_name).to eq(""Georgie"")
++    expect(new_user.last_name).to eq(""Jetsonian"")
+   end
+
+   it 'does not create a user if the current user already exists' do",should we create a fixture without first name and last name and have a spec like this one that uses it to make sure nothing errors out when they are not present?
+9026,"@@ -35,4 +35,9 @@ interface PythonSnippetSet<Element> {
+    * Generates the result module with a set of accumulated imports.
+    */
+   Doc generateModule(Element element, Doc body, Iterable<String> imports);
++
++  /**
++   * Generate the example snippet for the code documentation.
++   */
++  Doc generateMethodSampleCode(PythonDocConfig config);
+ }",It seems odd to require all Python snippets to have this method when it's not relevant for messages.snip or the discovery snippets. (I see that we're already doing something similar with generateModule/generateBody where some of the implementations are empty. This also seems strange to me.)
+9027,"@@ -122,6 +122,7 @@ public class PrivateTransactionSimulator {
+             publicWorldState.updater(),
+             disposablePrivateState.updater(),
+             header,
++            Hash.ZERO, // PMT hash is not needed as this private transaction doesn't exist
+             transaction,
+             protocolSpec.getMiningBeneficiaryCalculator().calculateBeneficiary(header),
+             new DebugOperationTracer(TraceOptions.DEFAULT),","What about this: ""// Corresponding PMT does not exist."""
+9028,"@@ -626,6 +626,8 @@ class OptionsManagerMixIn(object):
+             config_file = self.config_file
+         if config_file is not None:
+             config_file = os.path.expanduser(config_file)
++            if not os.path.exists(config_file):
++                raise IOError(""The config file {:s} doesn't exist!"".format(config_file))
+
+         use_config_file = config_file and os.path.exists(config_file)
+         if use_config_file:",You don't need af ormat specified here.
+9029,"@@ -12,6 +12,8 @@ import (
+ 	""time""
+
+ 	""github.com/nats-io/go-nats""
++	""strings""
++	""sync""
+ )
+
+ func TestRouteConfig(t *testing.T) {",Nitpick: import ordering
+9030,"@@ -38,7 +38,7 @@ namespace Nethermind.Blockchain
+
+         public ReadOnlyChain(ReadOnlyBlockTree readOnlyTree,
+             IBlockValidator blockValidator,
+-            IRewardCalculator rewardCalculator,
++            Func<ITransactionProcessor, IRewardCalculator> rewardCalculatorFactory,
+             ISpecProvider specProvider,
+             IReadOnlyDbProvider dbProvider,
+             IBlockDataRecoveryStep recoveryStep,","code smell here, a function that create a reward calculator from transaction processor?"
+9031,"@@ -48,7 +48,7 @@ var authScopes = []string{
+ 	""https://www.googleapis.com/auth/cloud-platform"",
+ }
+
+-// Client is a runtimevarManager client.
++// A Client constructs runtime variables using the Runtime Configurator API.
+ type Client struct {
+ 	conn *grpc.ClientConn
+ 	// The gRPC API client.",I don't think the `A` is idomatic is it?
+9032,"@@ -67,4 +67,12 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files reachable from given metadata location.
++   */
++  default RemoveReachableFiles removeReachableFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement "" +
++        RemoveReachableFiles.class.toString());
++  }
+ }",nit: the others use the method name in the api and not the class name of the api
+9033,"@@ -1939,6 +1939,9 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
+   //  - Some passes may create new functions, but only the functions defined in
+   //    the lldb repl line should be serialized.
+   if (swift_ast_ctx->UseSerialization()) {
++    // Run all the passes before differentiation before we serialize.
++    runSILMandatoryOptPreDiffPasses(*sil_module);
++    // Serialize the module now.
+     auto expr_module_dir = swift_ast_ctx->GetReplExprModulesDir();
+     assert(expr_module_dir != nullptr);
+     llvm::SmallString<256> filename(expr_module_dir);",Does it work to run all the sil diagnostic passes before we serialize? That would be more consistent with what the normal compiler does in `FrontendTool.cpp : performCompileStepsPostSILGen()`
+9034,"@@ -4,6 +4,7 @@ Given '""$teacher_name"" is teaching the section from ""$section_start"" to ""$sectio
+   section = Section.find_by_starts_on_and_ends_on!(start_date, end_date)
+   teacher = Teacher.find_by_name!(teacher_name)
+   create(:section_teacher, section: section, teacher: teacher)
++  p section.teachers
+ end
+
+ Given 'I create the following section for ""$course_name"":' do |course_name, section_data|",You left in a puts.
+9035,"@@ -59,6 +59,11 @@ public abstract class CachingCollector extends FilterCollector {
+     @Override
+     public final float score() { return score; }
+
++    @Override
++    public float smoothingScore(int docId) throws IOException {
++      return 0;
++    }
++
+     @Override
+     public int docID() {
+       return doc;","Hmm, should we also cache the `smoothingScore` for this hit? Or, if we will keep it at returning `0`, couldn't we remove this impl and inherit the default from `Scorable`?"
+9036,"@@ -51,7 +51,7 @@ module.exports = function (grunt, options) {
+     baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site', 'update-bower-json', 'gh-pages:bower', 'npm-publish'];
+   }
+   else {
+-    baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site'];
++    baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release'];
+   }
+
+   return baseTasks;",I removed that from here because I am hoping that will stop the random unwanted updates to the website with unstable versions.
+9037,"@@ -11,7 +11,9 @@ import (
+ // State is the status of a process.
+ type State rune
+
+-const ( // Only values for Linux 3.14 and later are listed here
++// Process state values.
++// Only values for Linux 3.14 and later are listed here.
++const (
+ 	Dead        State = 'X'
+ 	DiskSleep   State = 'D'
+ 	Running     State = 'R'",Nit: missing period.
+9038,"@@ -1,10 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how deny uploads of unencrypted objects to an Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.ruby.s3_add_bucket_ssekms_encryption_policy]
++
+ require 'aws-sdk-s3'
+
+-# Denies uploads of unencrypted objects to an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - The Amazon S3 bucket to deny uploading unencrypted objects.",how **to** deny Simple Storage **Service**
+9039,"@@ -5,7 +5,7 @@ setResolver(resolver);
+
+ /* jshint ignore:start */
+ mocha.setup({
+-    timeout: 15000,
++    timeout: 25000,
+     slow: 500
+ });
+ /* jshint ignore:end */",Were you having trouble with timeouts in general acceptance tests or only the editor test? It's possible to set timeouts on a per-test basis by using `this.timeout(25000)` within the `it()` function. I'd like to drop the global timeout in the future if possible rather than increase it - in some circumstances a failing test can have a knock-on effect which makes all later tests timeout so Travis can get hung up for a long time if no one notices and cancels the build.
+9040,"@@ -246,6 +246,11 @@ def _setSystemConfig(fromPath):
+ 		if curSourceDir==fromPath:
+ 			curDestDir=toPath
+ 		else:
++			if os.path.relpath(curSourceDir,fromPath) == ""addons"":
++				import addonHandler
++				subDirs[:] = [addon.name for addon in addonHandler.getRunningAddons()]
++			else:
++				subDirs[:] = subDirs
+ 			curDestDir=os.path.join(toPath,os.path.relpath(curSourceDir,fromPath))
+ 		if not os.path.isdir(curDestDir):
+ 			os.makedirs(curDestDir)",I don't think this is necessary.
+9041,"@@ -1025,15 +1025,13 @@ func (vd *volAPI) snapEnumerate(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	snaps := make([]*api.Volume, len(resp.GetVolumeSnapshotIds()))
+-	for i, s := range resp.GetVolumeSnapshotIds() {
++	snaps := make([]*api.Volume, 0)
++	for _, s := range resp.GetVolumeSnapshotIds() {
+ 		vol, err := volumes.Inspect(ctx, &api.SdkVolumeInspectRequest{VolumeId: s})
+ 		if err != nil {
+-			e := fmt.Errorf(""Failed to inspect volumeID: %s"", err.Error())
+-			vd.sendError(vd.name, method, w, e.Error(), http.StatusBadRequest)
+-			return
++			continue
+ 		}
+-		snaps[i] = vol.GetVolume()
++		snaps = append(snaps, vol.GetVolume())
+ 	}
+ 	json.NewEncoder(w).Encode(snaps)
+ }","Instead of blindly ignoring all errors, this should just ignore the volume not found error."
+9042,"@@ -135,11 +135,9 @@ public class ParquetReader<T> extends CloseableGroup implements CloseableIterabl
+         throw new RuntimeIOException(e);
+       }
+
+-      long rowPosition = rowGroupsStartRowPos[nextRowGroup];
++      model.setPageSource(pages, rowGroupsStartRowPos == null ? 0 : rowGroupsStartRowPos[nextRowGroup]);
+       nextRowGroupStart += pages.getRowCount();
+       nextRowGroup += 1;
+-
+-      model.setPageSource(pages, rowPosition);
+     }
+
+     @Override",The `rowPosition` will be ignored if the position column is not projected.
+9043,"@@ -215,6 +215,16 @@ spec:
+               protocol: TCP
+             - containerPort: 3232
+               protocol: TCP
++            livenessProbe:
++              exec:
++                command:
++                - /bin/sh
++                - -c
++                - zfs set io.openebs:livenesstimestap='$(date)' cstor-$OPENEBS_IO_CSTOR_ID
++              failureThreshold: 3
++              initialDelaySeconds: 300
++              periodSeconds: 10
++              timeoutSeconds: 30
+             securityContext:
+               privileged: true
+             volumeMounts:","Is there a possibility of a clash between periodSeconds and timeoutSeconds? For instance, the current probe is not yet timed-out and the next one has started."
+9044,"@@ -38,12 +38,11 @@ public class BesuCommandCustomFactory implements CommandLine.IFactory {
+       return (T) new VersionProvider(pluginVersionsProvider);
+     }
+
+-    final Constructor<T> constructor = cls.getDeclaredConstructor();
+     try {
++      final Constructor<T> constructor = cls.getDeclaredConstructor();
+       return constructor.newInstance();
+     } catch (Exception e) {
+-      constructor.setAccessible(true);
+-      return constructor.newInstance();
++      return CommandLine.defaultFactory().create(cls);
+     }
+   }
+ }",This logic is already been performed in `CommandLine.defaultFactory().create(cls)` ... whats the point of repeating it here?
+9045,"@@ -410,7 +410,7 @@ class ManualColumnMove extends BasePlugin {
+    * @private
+    */
+   updateColumnsMapper() {
+-    let countCols = this.hot.countSourceCols();
++    let countCols = Math.max(this.hot.countCols(), this.hot.countSourceCols());
+     let columnsMapperLen = this.columnsMapper._arrayMap.length;
+
+     if (columnsMapperLen === 0) {",Please change from `let` to `const` here and above. Setting value to `this.hot.countSourceCols()` should be enought probably.
+9046,"@@ -796,7 +796,10 @@ int flb_upstream_conn_timeouts(struct mk_list *list)
+                  * waiting for I/O will receive the notification and trigger
+                  * the error to it caller.
+                  */
+-                shutdown(u_conn->fd, SHUT_RDWR);
++                if (u_conn->fd != -1) {
++                    shutdown(u_conn->fd, SHUT_RDWR);
++                }
++
+                 u_conn->net_error = ETIMEDOUT;
+                 prepare_destroy_conn(u_conn);
+             }","Somewhat nitpick: I see the `!=` pattern mentioned in the fluent-bit style guide, but imo, it would be safer to check that a fd is non-negative with ` > -1` or `>= 0`"
+9047,"@@ -0,0 +1,17 @@
++class CreatePgSearchDocuments < ActiveRecord::Migration
++  def self.up
++    say_with_time(""Creating table for pg_search multisearch"") do
++      create_table :pg_search_documents do |t|
++        t.text :content
++        t.belongs_to :searchable, :polymorphic => true, :index => true
++        t.timestamps null: false
++      end
++    end
++  end
++
++  def self.down
++    say_with_time(""Dropping table for pg_search multisearch"") do
++      drop_table :pg_search_documents
++    end
++  end
++end",Use the new Ruby 1.9 hash syntax.
+9048,"@@ -25,6 +25,8 @@ import (
+ 	""github.com/gogits/gogs/modules/bindata""
+ 	""github.com/gogits/gogs/modules/log""
+ 	""github.com/gogits/gogs/modules/user""
++
++	""strk.kbt.io/projects/go/libravatar""
+ )
+
+ type Scheme string",Please host to a GitHub repo.
+9049,"@@ -197,6 +197,12 @@ func (s *server) doneSplit(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	tag.DoneSplit(tagr.Address)
++	_, err = tag.DoneSplit(tagr.Address)
++	if err != nil {
++		s.Logger.Debugf(""done split: %v"", err)
++		s.Logger.Error(""done split: %v"", err)
++		jsonhttp.InternalServerError(w, nil)
++		return
++	}
+ 	jsonhttp.OK(w, ""ok"")
+ }","The Error log message should not expose internals. The message should be something like this `""done split failed for address %v"", tagr.Address`. Also, the Debugf would be more informative with the address in the message."
+9050,"@@ -13,11 +13,15 @@
+
+ package args
+
+-import ""flag""
++import (
++	""flag""
++)
+
+ const (
+ 	versionUsage             = ""Print the agent version information and exit""
+-	logLevelUsage            = ""Loglevel: [<crit>|<error>|<warn>|<info>|<debug>]""
++	logLevelUsage            = ""Loglevel overrides loglevel-driver and loglevel-on-instance and sets the same level for both on-instance and driver logging: [<crit>|<error>|<warn>|<info>|<debug>]""
++	driverLogLevelUsage      = ""Loglevel for docker logging driver: [<crit>|<error>|<warn>|<info>|<debug>]""
++	instanceLogLevelUsage    = ""Loglevel for Agent on-instance log file: [<none>|<crit>|<error>|<warn>|<info>|<debug>]""
+ 	ecsAttributesUsage       = ""Print the Agent's ECS Attributes based on its environment""
+ 	acceptInsecureCertUsage  = ""Disable SSL certificate verification. We do not recommend setting this option""
+ 	licenseUsage             = ""Print the LICENSE and NOTICE files and exit""","can we rename `fileLogLevelUsage` to be more generic like `instanceLogLevelUsage`? Same goes for other var below like fileLogLevelFlagName, FileLogLevel."
+9051,"@@ -169,11 +169,8 @@ define([""loading"", ""layoutManager"", ""userSettings"", ""events"", ""libraryBrowser"",
+                     valueChangeEvent: ""click""
+                 });
+
+-                if (layoutManager.desktop || layoutManager.mobile) {
+-                    alphaPickerElement.classList.add(""alphabetPicker-right"");
+-                    itemsContainer.classList.remove(""padded-left-withalphapicker"");
+-                    itemsContainer.classList.add(""padded-right-withalphapicker"");
+-                }
++                alphaPickerElement.classList.add(""alphaPicker-fixed-right"");
++                itemsContainer.classList.add(""padded-right-withalphapicker"");
+             }
+
+             var btnFilter = tabContent.querySelector("".btnFilter"");",Does this one not need the `tabContent` object used in the other files?
+9052,"@@ -102,6 +102,16 @@ type ClassicELB struct {
+ 	Tags map[string]string `json:""tags,omitempty""`
+ }
+
++// IsUnmanaged returns true if the Classic ELB is unmanaged.
++func (b *ClassicELB) IsUnmanaged(clusterName string) bool {
++	return b.Name != """" && !Tags(b.Tags).HasOwned(clusterName)
++}
++
++// IsManaged returns true if Classic ELB is managed.
++func (b *ClassicELB) IsManaged(clusterName string) bool {
++	return !b.IsUnmanaged(clusterName)
++}
++
+ // ClassicELBAttributes defines extra attributes associated with a classic load balancer.
+ type ClassicELBAttributes struct {
+ 	// IdleTimeout is time that the connection is allowed to be idle (no data",Our use of the terms `managed` and `unmanaged` in CAPA is interesting. I think we should probably update the docs (as part of a separate PR) to explain that we are referring to whether its CAPA managed infra. As opposed to meaning AWS managed service.
+9053,"@@ -246,7 +246,7 @@ def record_listens(request, data):
+
+     lookup = defaultdict(dict)
+     for key, value in data.items():
+-        if key == ""sk"" or key == ""token"" or key == ""api_key"" or key == ""method"":
++        if key == ""sk"" or key == ""token"" or key == ""api_key"" or key == ""method"" or key == ""api_sig"":
+             continue
+         matches = re.match('(.*)\[(\d+)\]', key)
+         if matches:",Looks like all of these can be put into a list.
+9054,"@@ -38,6 +38,8 @@ func CanonicalizeHeaderKey(k string) string {
+ type Headers struct {
+ 	// This representation allows us to make zero-value valid
+ 	items map[string]string
++	// map from canonicalized key to original key
++	keyMapping map[string]string
+ }
+
+ // NewHeaders builds a new Headers object.","nit: ""*mapping"" for a map is unnecessary. Consider calling this `originalNames` or similar."
+9055,"@@ -171,11 +171,11 @@ class ProfilesDialog(wx.Dialog):
+ 		index = self.profileList.Selection
+ 		if gui.messageBox(
+ 			# Translators: The confirmation prompt displayed when the user requests to delete a configuration profile.
+-			_(""Are you sure you want to delete this profile? This cannot be undone.""),
++			_(""This profile will be permanently deleted, this action cannot be undone.""),
+ 			# Translators: The title of the confirmation dialog for deletion of a configuration profile.
+ 			_(""Confirm Deletion""),
+-			wx.YES | wx.NO | wx.ICON_QUESTION, self
+-		) == wx.NO:
++			wx.OK | wx.CANCEL | wx.ICON_QUESTION, self
++		) != wx.OK:
+ 			return
+ 		name = self.profileNames[index]
+ 		try:","Please split this into two sentences; i.e. ""This profile will be permanently deleted. This action cannot be undone."""
+9056,"@@ -173,9 +173,10 @@ public class OpenAPSAMAPlugin extends PluginBase implements APSInterface {
+
+         startPart = new Date();
+         if (MainApp.getConstraintChecker().isAutosensModeEnabled().value()) {
+-            lastAutosensResult = IobCobCalculatorPlugin.getPlugin().detectSensitivityWithLock(IobCobCalculatorPlugin.getPlugin().oldestDataAvailable(), System.currentTimeMillis());
++            lastAutosensResult = IobCobCalculatorPlugin.getPlugin().getLastAutosensDataSynchronized(""OpenAPSPlugin"").autosensResult;
+         } else {
+             lastAutosensResult = new AutosensResult();
++            lastAutosensResult.sensResult = ""autosens disabled"";
+         }
+         Profiler.log(log, ""detectSensitivityandCarbAbsorption()"", startPart);
+         Profiler.log(log, ""AMA data gathering"", start);",NPE here and in other APS plugins
+9057,"@@ -142,6 +142,9 @@ func getMsgKey(obj interface{}) (string, error) {
+ 		resourceType, _ := edgemessagelayer.GetResourceType(*msg)
+ 		resourceNamespace, _ := edgemessagelayer.GetNamespace(*msg)
+ 		resourceName, _ := edgemessagelayer.GetResourceName(*msg)
++		if msg.Router.Source == modules.DynamicControllerModuleName {
++			return strings.Join([]string{resourceType, resourceNamespace, resourceName, msg.Router.Source}, ""/""), nil
++		}
+ 		return strings.Join([]string{resourceType, resourceNamespace, resourceName}, ""/""), nil
+ 	}
+ ","Thanks for the fixing, and could you please provide more details for this bug? Because we have the deduplication mechanism in cloudhub, so it will has no problem."
+9058,"@@ -52,6 +52,10 @@ public class ViewSettings extends MainWindowView {
+     private static final String CAPTION_TITLE_CSS_CLASS = ""captionTitle"";
+     private static final String CONFIGURATION_PANE_CSS_CLASS = ""containerConfigurationPane"";
+     private static final String TITLE_CSS_CLASS = ""title"";
++    private String applicationName;
++    private String applicationVersion;
++    private String applicationGitRevision;
++    private String applicationBuildTimestamp;
+     private final ObservableList<String> repositories = FXCollections.observableArrayList();
+     private ComboBox<Theme> themes;
+     private Consumer<Settings> onSave;",These could be final
+9059,"@@ -103,7 +103,7 @@ public abstract class AbstractRestInvocation {
+     @SuppressWarnings(""unchecked"")
+     Map<String, String> cseContext =
+         JsonUtils.readValue(strCseContext.getBytes(StandardCharsets.UTF_8), Map.class);
+-    invocation.setContext(cseContext);
++    invocation.addContext(cseContext);
+   }
+
+   public String getContext(String key) {","highway have the same problem we can add a new method in invocation: mergeContext 1.if new context have more items, then addAll to new context, and replace old context 2.if new context have less items, then allAll to old context directly."
+9060,"@@ -637,12 +637,15 @@ namespace GenFacades
+
+             private static void TraceDuplicateSeedTypeError(string docId, IReadOnlyList<INamedTypeDefinition> seedTypes)
+             {
+-                Trace.TraceError(""The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the following arguments to choose the preferred seed type:"", docId);
++                var sb = new StringBuilder();
++                sb.AppendFormat(""The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the following arguments to choose the preferred seed type:"", docId);
+
+                 foreach (INamedTypeDefinition type in seedTypes)
+                 {
+-                    Trace.TraceError(""  /preferSeedType:{0}={1}"", docId.Substring(""T:"".Length), type.GetAssembly().Name.Value);
++                    sb.AppendFormat(""  /preferSeedType:{0}={1}"", docId.Substring(""T:"".Length), type.GetAssembly().Name.Value);
+                 }
++
++                Trace.TraceError(sb.ToString());
+             }
+
+             private void AddTypeForward(Assembly assembly, INamedTypeDefinition seedType)",Created a single error so it's not interleaved in log
+9061,"@@ -94,11 +94,9 @@ describe('exportFile', () => {
+
+       const result = plugin._createBlob(formatter);
+
+-      if (!Handsontable.helper.isIE9()) {
+-        expect(formatter.export).toHaveBeenCalled();
+-        expect(result.size).toBe(7);
+-        expect(result.type).toBe('foo;charset=iso-8859-1');
+-      }
++      expect(formatter.export).toHaveBeenCalled();
++      expect(result.size).toBe(7);
++      expect(result.type).toBe('foo;charset=iso-8859-1');
+     });
+   });
+ });",`isIE9` was reverted. Shouldn't this condition be reverted as well?
+9062,"@@ -504,14 +504,14 @@ int LuaScriptInterface::luaErrorHandler(lua_State* L)
+ 	return 1;
+ }
+
+-bool LuaScriptInterface::callFunction(int params)
++bool LuaScriptInterface::callFunction(int params, bool defaultReturn /* = false */)
+ {
+ 	bool result = false;
+ 	int size = lua_gettop(luaState);
+ 	if (protectedCall(luaState, params, 1) != 0) {
+ 		LuaScriptInterface::reportError(nullptr, LuaScriptInterface::getString(luaState, -1));
+ 	} else {
+-		result = LuaScriptInterface::getBoolean(luaState, -1);
++		result = LuaScriptInterface::getBoolean(luaState, -1, defaultReturn);
+ 	}
+
+ 	lua_pop(luaState, 1);","Sorry if I'm being too pedantic here, but wouldn't it be nice to have standard parameter name? Like using `defaultValue` everywhere."
+9063,"@@ -119,9 +119,14 @@ func defaultBServer(ctx Context) string {
+ 	case libkb.DevelRunMode:
+ 		return memoryAddr
+ 	case libkb.StagingRunMode:
+-		return ""bserver-0.dev.keybase.io:443""
++		return `
++			bserver-0.dev.keybase.io:443,bserver-1.dev.keybase.io:443;
++			bserver.dev.keybase.io:443`
+ 	case libkb.ProductionRunMode:
+-		return ""bserver.kbfs.keybase.io:443""
++		return `
++			bserver-0.kbfs.keybaseapi.com:443,bserver-1.kbfs.keybaseapi.com:443;
++			bserver-0.kbfs.keybase.io:443,bserver-1.kbfs.keybase.io:443;
++			bserver.kbfs.keybase.io:443`
+ 	default:
+ 		return """"
+ 	}","Remind me again: what's the point of having new clients connect to both -0 and -1? If we ever have to blackhole -0, we'd have to blackhole -1 at the same time, right? What is supposed to be the difference between the two? Is it just that someday we might want to have two ELBs, and this will help load balance between them?"
+9064,"@@ -1792,8 +1792,8 @@ func (s *Server) createClient(conn net.Conn) *client {
+
+ 	// Do final client initialization
+
+-	// Set the First Ping timer.
+-	s.setFirstPingTimer(c)
++	// Set the Ping timer. Will be reset once connect was received.
++	c.setPingTimer()
+
+ 	// Spin up the read loop.
+ 	s.startGoRoutine(func() { c.readLoop() })",Why not go back to `c.setPingTimer()` here instead so you don't need the new boolean in setFirstPingTimer().
+9065,"@@ -1,4 +1,4 @@
+-/*
++/*
+  * Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
+  *                  MacCoss Lab, Department of Genome Sciences, UW
+  *",We should figure out why so many of these files have an invisible change on the first line: Are we writing out some sort of byte order mark?
+9066,"@@ -1,19 +1,3 @@
+-/*
+-Copyright 2018 The Kubernetes Authors.
+-
+-Licensed under the Apache License, Version 2.0 (the ""License"");
+-you may not use this file except in compliance with the License.
+-You may obtain a copy of the License at
+-
+-    http://www.apache.org/licenses/LICENSE-2.0
+-
+-Unless required by applicable law or agreed to in writing, software
+-distributed under the License is distributed on an ""AS IS"" BASIS,
+-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-See the License for the specific language governing permissions and
+-limitations under the License.
+-*/
+-
+ package resource
+
+ import (",Was this our code @csrwng
+9067,"@@ -24,6 +24,7 @@ module Travis
+             end
+             sh.echo ""Build id: #{Shellwords.escape(data.build[:id])}""
+             sh.echo ""Job id: #{Shellwords.escape(data.job[:id])}""
++            sh.echo ""Runtime kernel version: #{`uname -r`.strip}""
+           end
+
+           def show_travis_build_version",I think you need `.untaint` here.
+9068,"@@ -227,7 +227,10 @@ module Bolt
+           raise Bolt::ValidationError, ""The project '#{name}' will not be loaded. The project name conflicts ""\
+             ""with a built-in Bolt module of the same name.""
+         end
+-      else
++      elsif name.nil? &&
++            (File.directory?(plans_path) ||
++            File.directory?(@path + 'tasks') ||
++            File.directory?(@path + 'files'))
+         message = ""No project name is specified in bolt-project.yaml. Project-level content will not be available.""
+         @logs << { warn: message }
+       end","Why are we including the `files/` directory in this check? I know `tasks/` and `plans/` make sense, since you can reference content in those directories from the CLI, but I don't think you can for `files/` (unless I'm missing a command)."
+9069,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+
+ import com.google.common.collect.Maps;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.
+9070,"@@ -72,6 +72,11 @@ const (
+ // A valid Certificate requires at least one of a CommonName, DNSName, or
+ // URISAN to be valid.
+ type CertificateSpec struct {
++	// Full X509 name specification (https://golang.org/pkg/crypto/x509/pkix/#Name).
++	// If specified, overrides any other name elements below.
++	// +optional
++	X509Name *X509DistinguishedName `json:""x509Name,omitempty""`
++
+ 	// CommonName is a common name to be used on the Certificate.
+ 	// The CommonName should have a length of 64 characters or fewer to avoid
+ 	// generating invalid CSRs.","Can we rename this field to `Subject`? Looking around, it seems like 'subject' is the standard terminology for this stanza  "
+9071,"@@ -15,7 +15,7 @@ was persisted in the address book and the node has been restarted).
+
+ So the information has been changed, and potentially upon disconnection,
+ the depth can travel to a shallower depth in result.
+-If a peer gets added through AddPeer, this does not necessarily infer
++If a peer gets added through AddPeers , this does not necessarily infer
+ an immediate depth change, since the peer might end up in the backlog for
+ a long time until we actually need to connect to her.
+ ",Remove additional whitespace.
+9072,"@@ -171,6 +171,16 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
+ 		http.SetCookie(w, cookie)
+ 	}
+
++	if cookies := md.HeaderMD.Get(""Set-Cookie-Refresh-Token""); len(cookies) > 0 {
++		cookie := &http.Cookie{
++			Name:     ""refreshToken"",
++			Value:    cookies[0],
++			Path:     ""/v1/authn/login"",
++			HttpOnly: true, // Client cannot access refresh token, it is sent by browser only if login is attempted.
++		}
++		http.SetCookie(w, cookie)
++	}
++
+ 	// Redirect if it's the browser (non-XHR).
+ 	redirects := md.HeaderMD.Get(""Location"")
+ 	if len(redirects) > 0 && isBrowser(requestHeadersFromResponseWriter(w)) {",We should add `Secure` as well
+9073,"@@ -12,7 +12,7 @@ import (
+ // TestIntegration runs integration tests against the remote
+ func TestIntegration(t *testing.T) {
+ 	fstests.Run(t, &fstests.Opt{
+-		RemoteName: ""TestWebdavNexcloud:"",
++		RemoteName: ""TestWebdavNextcloud:"",
+ 		NilObject:  (*webdav.Object)(nil),
+ 	})
+ }",I presume this isn't a big deal
+9074,"@@ -2974,7 +2974,8 @@ raw_mem_alloc(size_t size, uint prot, void *addr, dr_alloc_flags_t flags)
+             : (TEST(DR_ALLOC_COMMIT_ONLY, flags) ? RAW_ALLOC_COMMIT_ONLY : 0);
+ #    endif
+         if (IF_WINDOWS(TEST(DR_ALLOC_COMMIT_ONLY, flags) &&) addr != NULL &&
+-            !app_memory_pre_alloc(get_thread_private_dcontext(), addr, size, prot, false))
++            !app_memory_pre_alloc(get_thread_private_dcontext(), addr, size, prot, false,
++                                  true /*update*/, false /*!image*/))
+             p = NULL;
+         else
+             p = os_raw_mem_alloc(addr, size, prot, os_flags, &error_code);","Maybe {}, even though no multi-line body?"
+9075,"@@ -39,6 +39,16 @@ describe CommunicartMailer do
+       mail.from.should == ['reply@communicart-stub.com']
+     end
+
++   it 'renders the navigator template' do
++      cart.setProp('origin','navigator')
++      cart.stub(:approval_group).and_return(approval_group)
++      approval_group.stub(:approvers).and_return([approver])
++      approver.stub(:approver_comment).and_return([])
++# This is very fragile, it is based on a particular term coming from the navigator teplate.
++# If the template changes, this test will break --- I know of no other way of tesitng this.
++      expect(mail.body.encoded).to match('NAVIGATOR')
++    end
++
+     context 'attaching a csv of the cart activity' do
+       it 'generates csv attachments for an approved cart' do
+         cart.stub(:approval_group).and_return(approval_group)",We can try something like this: response.should render_template(:partial => 'partial_name')
+9076,"@@ -514,6 +514,10 @@ IDRETRY=4
+ IDCANCEL=3
+
+ def MessageBox(hwnd, text, caption, type):
++	if hasattr(text, 'decode'):
++		text = text.decode('mbcs')
++	if caption and hasattr(caption, 'decode'):
++		caption = caption.decode('mbcs')
+ 	res = user32.MessageBoxW(hwnd, text, caption, type)
+ 	if res == 0:
+ 		raise WinError()","Please use `isinstance(text, bytes)` instead. Otherwise, this will lead to unnecessary decoding on python 2 unicode strings."
+9077,"@@ -3068,7 +3068,7 @@ void SwiftLanguageRuntime::FindFunctionPointersInCall(
+                   ExecutionContext exe_ctx;
+                   frame.CalculateExecutionContext(exe_ctx);
+                   error = argument_values.GetValueAtIndex(0)->GetValueAsData(
+-                      &exe_ctx, data, 0, NULL);
++                      &exe_ctx, data, NULL);
+                   lldb::offset_t offset = 0;
+                   lldb::addr_t fn_ptr_addr = data.GetPointer(&offset);
+                   Address fn_ptr_address;",This one is unrelated to the GetSymbolVendor removal ... the API to GetValueAsData was changed.
+9078,"@@ -45,6 +45,7 @@ func TestMarshalUnmarshalJSON(t *testing.T) {
+ 		desiredStatusUnsafe:   resourcestatus.ResourceCreated,
+ 		knownStatusUnsafe:     resourcestatus.ResourceCreated,
+ 		appliedStatusUnsafe:   resourcestatus.ResourceCreated,
++		networkMode:           bridgeNetworkMode,
+ 	}
+
+ 	bytes, err := json.Marshal(firelensResIn)",can you assert the value of this field below similar to other fields?
+9079,"@@ -11,6 +11,7 @@ package net.sourceforge.pmd.lang.java.ast;
+  * <pre class=""grammar"">
+  *
+  * PrimaryExpression ::= {@linkplain ASTLiteral Literal}
++ *                     | {@link ASTClassLiteral ClassLiteral}
+  *                     | {@linkplain ASTMethodCall MethodCall}
+  *                     | {@linkplain ASTFieldAccess FieldAccess}
+  *                     | {@linkplain ASTConstructorCall ConstructorCall}","I'll change that to ""linkplain"" for consistency :)"
+9080,"@@ -196,7 +196,12 @@ class RouteFactory(object):
+                                                 self.resource_name,
+                                                 **matchdict)
+                 if object_id == '*':
+-                    object_uri = object_uri.replace('%2A', '*')
++                    # Express the object_uri pattern with precision
++                    # XXX: we could get the model.id_generator pattern, but
++                    # since the backend replace * by .* we can't.
++                    # See Kinto/kinto#970
++                    id_pattern = ""[a-zA-Z0-9_-]+""
++                    object_uri = object_uri.replace('%2A', id_pattern)
+             except KeyError:
+                 # Maybe the resource has no single record endpoint.
+                 # We consider that object URIs in permissions backend will","This is fix. But since the history resource was relying on the bug to work, I had to do some changes regarding the history entries (eg. explicit declare that the permissions inherit from bucket)"
+9081,"@@ -142,6 +142,11 @@ public class DocsStreamer implements Iterator<SolrDocument> {
+     return docIterator.hasNext();
+   }
+
++  // called at the end of the stream
++  public void finish(){
++    if (transformer != null) transformer.finish();
++  }
++
+   public SolrDocument next() {
+     int id = docIterator.nextDoc();
+     idx++;","can't we leverage Closeable here and get some sugar&warns? Also, line 89 still calls setContext() .. is it right? or I'm missing something?"
+9082,"@@ -52,7 +52,7 @@ func TestPing(t *testing.T) {
+ 	// ping
+ 	peerID := ""124""
+ 	greetings := []string{""hey"", ""there"", ""fella""}
+-	rtt, err := client.Ping(context.Background(), peerID, greetings...)
++	rtt, err := client.Ping(context.Background(), []byte(peerID), greetings...)
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}","Use explicit swarm.Address when defining peerID, by using NewAddress, and remove conversion here."
+9083,"@@ -30,9 +30,13 @@ const (
+ 	rootMountPoint = ""/""
+ 	rootUser       = ""root""
+
++	// RpmDependenciesDirectory is the directory which contains RPM database. It is not required for images that do not contain RPM.
++	RpmDependenciesDirectory = ""/var/lib/rpm""
++
+ 	// /boot directory should be only accesible by root. The directories need the execute bit as well.
+ 	bootDirectoryFileMode = 0600
+ 	bootDirectoryDirMode  = 0700
++	shadowFile            = ""/etc/shadow""
+ )
+
+ // PackageList represents the list of packages to install into an image","`RpmDependenciesDirectory` should start with a lowercase character so it's not exported outside of this package, it looks like its only referenced in this file."
+9084,"@@ -25,9 +25,13 @@ class BasicBlock(nn.Module):
+                  conv_cfg=None,
+                  norm_cfg=dict(type='BN'),
+                  dcn=None,
++                 rfp_inplanes=None,
++                 sac=None,
+                  plugins=None):
+         super(BasicBlock, self).__init__()
+         assert dcn is None, 'Not implemented yet.'
++        assert rfp_inplanes is None, 'Not implemented yet.'
++        assert sac is None, 'Not implemented yet.'
+         assert plugins is None, 'Not implemented yet.'
+
+         self.norm1_name, norm1 = build_norm_layer(norm_cfg, planes, postfix=1)","If we make a new backbone class, we don't need to support `BasicBlock`"
+9085,"@@ -359,11 +359,6 @@ configRetry:
+
+ 	// Start up the dataplane driver.  This may be the internal go-based driver or an external
+ 	// one.
+-	if configParams.BPFEnabled && !bpf.SyscallSupport() {
+-		log.Error(""BPFEnabled is set but BPF mode is not supported on this platform.  Continuing with BPF disabled."")
+-		configParams.BPFEnabled = false
+-	}
+-
+ 	var dpDriver dp.DataplaneDriver
+ 	var dpDriverCmd *exec.Cmd
+ ",This was an out-of-date dupe of the check on line 335
+9086,"@@ -44,7 +44,6 @@ window.PluginsView = countlyView.extend({
+
+             this.dtable = $('#plugins-table').dataTable($.extend({}, $.fn.dataTable.defaults, {
+                 ""aaData"": pluginsData,
+-                ""bPaginate"": false,
+                 ""aoColumns"": [
+                     { ""mData"": function (row, type) { if (row.enabled) { return jQuery.i18n.map[row.code + "".plugin-title""] || jQuery.i18n.map[row.code + "".title""] || row.title; } else return row.title }, ""sType"": ""string"", ""sTitle"": jQuery.i18n.map[""plugins.name""] },
+                     {",Let's put this back
+9087,"@@ -122,9 +122,9 @@ bool Mailbox::sendItem(Item* item) const
+ 		}
+ 	} else {
+ 		Player tmpPlayer(nullptr);
+-		if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
++		//if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
+ 			return false;
+-		}
++		//}
+
+ 		if (g_game.internalMoveItem(item->getParent(), tmpPlayer.getInbox(), INDEX_WHEREEVER,
+ 		                            item, item->getItemCount(), nullptr, FLAG_NOLIMIT) == RET_NOERROR) {",Things like these should have been addressed before submitting a pull request.
+9088,"@@ -77,7 +77,7 @@ public class ITZipkinMetrics {
+
+     // ensure we don't track prometheus, UI requests in prometheus
+     assertThat(scrape())
+-      .doesNotContain(""prometheus"")
++      .doesNotContain(""prometheus_notifications"")
+       .doesNotContain(""uri=\""/zipkin"")
+       .doesNotContain(""uri=\""/\"""");
+   }",This one as well. Any better suggestion please?
+9089,"@@ -267,6 +267,11 @@ func (s *Server) internalSendLoop(wg *sync.WaitGroup) {
+ 			c.pa.reply = []byte(pm.rply)
+ 			c.mu.Unlock()
+
++			if c.trace {
++				c.traceInOp(fmt.Sprintf(
++					""PUB %s %s %d"", c.pa.subject, c.pa.reply, c.pa.size), nil)
++			}
++
+ 			// Add in NL
+ 			b = append(b, _CRLF_...)
+ 			c.processInboundClientMsg(b)","wonder if we should collect c.trace, c.pa.subject, etc.. while under the lock to prevent data races.. or simply move the tracing under the lock."
+9090,"@@ -182,7 +182,7 @@ PJ_XY pj_fwd(PJ_LP lp, PJ *P) {
+
+     last_errno = proj_errno_reset(P);
+
+-    if (!P->skip_fwd_prepare)
++    if (!P->skip_fwd_prepare && 0 != strcmp(P->short_name, ""s2""))
+         coo = fwd_prepare (P, coo);
+     if (HUGE_VAL==coo.v[0] || HUGE_VAL==coo.v[1])
+         return proj_coord_error ().xy;","Why is this hack needed ? Ideally, we shouldn't need that."
+9091,"@@ -0,0 +1,19 @@
++package plugin
++
++type Status struct {
++	DriverName     string
++	MeshDriverName string `json:""MeshDriverName,omitempty""`
++	Version        int
++}
++
++func NewStatus(address, meshAddress string, isPluginV2 bool) *Status {
++	status := &Status{
++		DriverName:     pluginNameFromAddress(address),
++		MeshDriverName: pluginNameFromAddress(meshAddress),
++		Version:        1,
++	}
++	if isPluginV2 {
++		status.Version = 2
++	}
++	return status
++}","Minor/Nitpick: replace `1` with a constant, esp. as used in `prog/weaver/http.go` in `{{if eq .Plugin.Version 1}}`"
+9092,"@@ -13,5 +13,5 @@ namespace Datadog.Trace.Configuration
+         {
+             return Environment.GetEnvironmentVariable(key);
+         }
+-    }
++   }
+ }","nit: Looks like the whitespace got thrown off, can you fix this?"
+9093,"@@ -5593,7 +5593,13 @@ namespace pwiz.Skyline.Properties {
+                 return ResourceManager.GetString(""CommandLine_ImportAnnotations_Error__Failed_while_reading_annotations_"", resourceCulture);
+             }
+         }
+-
++
++        public static string CommandLine_ImportPeakBoundaries_Error__Failed_while_importing_boundaries_ {
++            get {
++                return ResourceManager.GetString(""CommandLine_ImportPeakBoundaries_Error__Failed_while_importing_boundaries_"", resourceCulture);
++            }
++        }
++
+         /// <summary>
+         ///   Looks up a localized string similar to Error: The replicate {0} already exists in the given document and the --import-append option is not specified.  The replicate will not be added to the document..
+         /// </summary>",Redo this by adding a string literal and then pressing F6 to have Resharper move it to Properties\Resources.resx which will also create this property.
+9094,"@@ -0,0 +1,11 @@
++// +build !windows
++// Copyright 2012-2017 Apcera Inc. All rights reserved.
++
++package server
++
++// Run starts the NATS server. This wrapper function allows Windows to add a
++// hook for running NATS as a service.
++func Run(server *Server) error {
++	server.Start()
++	return nil
++}","Unless a log file has been specified, IMO you should set the server option to enable syslog (windows event log) here, or someplace along the service start code path. We shouldn't really rely on users to specify that when creating the service."
+9095,"@@ -86,8 +86,8 @@ public class TestFlinkCatalogTable extends FlinkCatalogTestBase {
+             Types.NestedField.optional(1, ""strV"", Types.StringType.get())));
+     Assert.assertEquals(
+         Arrays.asList(
+-            TableColumn.of(""id"", DataTypes.BIGINT()),
+-            TableColumn.of(""strV"", DataTypes.STRING())),
++            TableColumn.physical(""id"", DataTypes.BIGINT()),
++            TableColumn.physical(""strV"", DataTypes.STRING())),
+         getTableEnv().from(""tl"").getSchema().getTableColumns());
+     Assert.assertTrue(getTableEnv().getCatalog(catalogName).get().tableExists(ObjectPath.fromString(""db.tl"")));
+   }","It's strange here, because I saw the `TableColumn` is marked as `PublicEvolving`, but after released flink 1.12.0 it did not have any Interface compatibility guarantee. At least, it should marked as `deprecated`, and keep it a major release."
+9096,"@@ -104,7 +104,7 @@ public abstract class ConnectionPageAbstract extends DialogPage implements IData
+
+         if (!site.isNew() && !site.getDriver().isEmbedded()) {
+             Link netConfigLink = new Link(panel, SWT.NONE);
+-            netConfigLink.setText(""<a>Network settings (SSH, SSL, Proxy, ...)</a>"");
++            netConfigLink.setText(""<a>"" + CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link + ""</a>"");
+             netConfigLink.addSelectionListener(new SelectionAdapter() {
+                 @Override
+                 public void widgetSelected(SelectionEvent e) {","I'm not sure regarding this approach, for me the whole text including anchors should go to resources like ` netConfigLink.setText(CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link); ` You shouldn't concatenate translated values inside the code. If you need some params, please use NLS.bind()"
+9097,"@@ -78,6 +78,7 @@ func (c *connectionFlowController) GetWindowUpdate() protocol.ByteCount {
+ func (c *connectionFlowController) EnsureMinimumWindowSize(inc protocol.ByteCount) {
+ 	c.mutex.Lock()
+ 	if inc > c.receiveWindowSize {
++		c.logger.Debugf(""Increasing receive flow control window for the connection to %d kB, in response to stream flow control window increase"", c.receiveWindowSize/(1<<10))
+ 		c.receiveWindowSize = utils.MinByteCount(inc, c.maxReceiveWindowSize)
+ 		c.startNewAutoTuningEpoch()
+ 	}",How often do we expect this to trigger? Should we maybe put it behind an if logger.Debug()?
+9098,"@@ -126,12 +126,12 @@ func Snapshot(volname string, snapname string, labels map[string]string) (string
+ 		return """", err
+ 	}
+
+-	volume, err := GetVolume(controller.address)
++	volume, err := GetVolume(controller.Address)
+ 	if err != nil {
+ 		return """", err
+ 	}
+
+-	url := controller.address + ""/volumes/"" + volume.Id + ""?action=snapshot""
++	url := controller.Address + ""/volumes/"" + volume.Id + ""?action=snapshot""
+
+ 	fmt.Println(""Url is:"", url)
+ ","How was the name `controller` arrived? Can you get a consensus for the name controller ? This may be OK for jiva. However, c-stor does not have a concept called `controller`."
+9099,"@@ -151,6 +151,16 @@ func (v *ConfigValidator) sysctl(config *configs.Config) error {
+ 				return fmt.Errorf(""sysctl %q is not allowed in the hosts network namespace"", s)
+ 			}
+ 		}
++		if config.Namespaces.Contains(configs.NEWUTS) {
++			switch s {
++			case ""kernel.domainname"":
++				// This is namespaced and there's no explicit OCI field for it.
++				continue
++			case ""kernel.hostname"":
++				// This is namespaced but there's a conflicting (dedicated) OCI field for it.
++				return fmt.Errorf(""sysctl %q is not allowed as it conflicts with the OCI %q field"", s, ""hostname"")
++			}
++		}
+ 		return fmt.Errorf(""sysctl %q is not in a separate kernel namespace"", s)
+ 	}
+ ",i dont think we need to explicitly single out `kernel.domainname` here since its not a TODO for OCI either right ?
+9100,"@@ -66,7 +66,7 @@ static void on_setup_ostream(h2o_filter_t *_self, h2o_req_t *req, h2o_ostream_t
+     if (!req->res.mime_attr->is_compressible)
+         goto Next;
+     /* 100 is a rough estimate */
+-    if (req->res.content_length <= 100)
++    if (req->res.content_length <= self->args.min_size)
+         goto Next;
+     /* skip if failed to gather the list of compressible types */
+     if ((compressible_types = h2o_get_compressible_types(&req->headers)) == 0)",Should we better change the operator to `<` since the variable defines the minimum size that gets compressed?
+9101,"@@ -233,6 +233,14 @@ public class StreamTest extends AbstractLinearSeqTest {
+         assertThat(actual).isEqualTo(3);
+     }
+
++    // -- append
++
++    @Test
++    public void shouldAppendMillionTimes() {
++        final int bigNum = 1_000_000;
++        assertThat(Stream.range(0, bigNum).foldLeft(Stream.empty(), Stream::append).length()).isEqualTo(bigNum);
++    }
++
+     // -- combinations
+
+     @Test",I'm really impressed by the AppendElements addition! Very cool! :-)
+9102,"@@ -230,7 +230,7 @@ public class GridLauncherV3 {
+     }
+
+     configureLogging(common.getLog(), common.getDebug());
+-    log.info(version());
++    log.finest(version());
+     return true;
+   }
+ ",This change means that users can't easily see which version of the selenium server they're using. This is `info` level information.
+9103,"@@ -41,6 +41,8 @@ from qutebrowser.misc import editor, guiprocess
+ from qutebrowser.completion.models import urlmodel, miscmodels
+ from qutebrowser.mainwindow import mainwindow
+
++# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-69904
++MAX_WORLD_ID = 256 if qtutils.version_check('5.11.2') else 11
+
+ class CommandDispatcher:
+ ",This should be in qtutils and imported to here and the other place instead of declaring it twice.
+9104,"@@ -73,6 +73,15 @@ func (l *Logger) FetchCert(ctx context.Context, url string, bundle bool) ([][]by
+ 	return l.baseCl.FetchCert(ctx, url, bundle)
+ }
+
++func (l *Logger) FetchCertAlternatives(ctx context.Context, url string, bundle bool) ([][][]byte, error) {
++	l.log.V(logf.TraceLevel).Info(""Calling FetchCertAlternatives"")
++
++	ctx, cancel := context.WithTimeout(ctx, timeout)
++	defer cancel()
++
++	return l.baseCl.FetchCertAlternatives(ctx, url, bundle)
++}
++
+ func (l *Logger) WaitOrder(ctx context.Context, url string) (*acme.Order, error) {
+ 	l.log.V(logf.TraceLevel).Info(""Calling WaitOrder"")
+ ","Seems a bit weird to add a timeout in ""logging"" middleware, but I see that that is done elsewhere, so fine."
+9105,"@@ -25,7 +25,7 @@ export default AbstractIndexRoute.extend(ModalHelper, UserSession, {
+   actions: {
+     deleteItem(item) {
+       let i18n = this.get('i18n');
+-      let message = i18n.t('admin.customForms.messages.deleteForm');
++      let message = i18n.t('messages.delete_singular', { name: 'form' });
+       let model = Ember.Object.create({
+         itemToDelete: item
+       });",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.
+9106,"@@ -556,6 +556,13 @@ class Uppy {
+       files: updatedFiles
+     })
+
++    // If nothing is uploading anymore, and if nothing has uploaded yet - allow new uploads!
++    if (Object.keys(updatedFiles).length === 0) {
++      this.setState({
++        allowNewUpload: true
++      })
++    }
++
+     removeUploads.forEach((uploadID) => {
+       this._removeUpload(uploadID)
+     })","Could we combine this with the `setState` call above, so we don't have to call it twice?"
+9107,"@@ -31,10 +31,10 @@ class String
+   end
+
+   def fix_encoding_if_invalid!
+-    unless valid_encoding?
+-      encode!('utf-8', 'binary', invalid: :replace, undef: :replace)
+-    end
+-    force_encoding('utf-8')
++    # All new strings claim to be 8-bit ASCII in the DB, but are really saved as UTF-8...
++    force_encoding('utf-8') unless encoding == 'UTF-8'
++    # ...but old strings are a hodge-podge of encodings, so replace any unrecognizable characters with unknowns.
++    encode!('utf-8', invalid: :replace, undef: :replace) unless valid_encoding?
+     self
+   end
+ ","That part that still leaves me mystified is how the String class, when populated with a value from the SQL_ASCII encoded database is set to ""UTF-8"" encoding. Since the database is SQL_ASCII, each byte in the string stored in the database is considered one character. Ruby, however, is using UTF-8, which is writing a series of one-byte code points that are only meaningful when considered in the correct encoding. When Ruby passes a string to Postgresql, the code points are essentially ""flattened"" into bytes as they are written to the DB. When Rails (through Ruby) asks for a string from the DB, where does the information about the encoding come from?"
+9108,"@@ -233,13 +233,14 @@ func PrecreatedDaoOption(dao *blockDAO) Option {
+ 	}
+ }
+
+-// BoltDBDaoOption sets blockchain's dao with BoltDB from config.Chain.ChainDBPath
++// BoltDBDaoOption sets blockchain's dao with BoltDB from config.Chain.ChainDBPath and cfg.DB.IndexDBPath
+ func BoltDBDaoOption() Option {
+ 	return func(bc *blockchain, cfg config.Config) error {
+ 		cfg.DB.DbPath = cfg.Chain.ChainDBPath // TODO: remove this after moving TrieDBPath from cfg.Chain to cfg.DB
+ 		_, gateway := cfg.Plugins[config.GatewayPlugin]
+ 		bc.dao = newBlockDAO(
+-			db.NewBoltDB(cfg.DB),
++			db.NewBoltDB(cfg.DB, cfg.DB.DbPath),
++			db.NewBoltDB(cfg.DB, cfg.DB.IndexDBPath),
+ 			gateway && !cfg.Chain.EnableAsyncIndexWrite,
+ 			cfg.Chain.CompressBlock,
+ 			cfg.Chain.MaxCacheSize,",Is it a doable way and does it make sense.
+9109,"@@ -95,7 +95,10 @@ def verify_limit_range(limit):
+     max_query_limit = constants.MAX_QUERY_SIZE
+     if limit > max_query_limit:
+         LOG.warning('Query limit %d was larger than max query limit %d, '
+-                    'setting limit to %d', limit, max_query_limit, max)
++                    'setting limit to %d',
++                    limit,
++                    max_query_limit,
++                    max_query_limit)
+         limit = max_query_limit
+     return limit
+ ","max was wrong here. As its buitlt-in, not a number, and a TypeError was thrown."
+9110,"@@ -1,3 +1,5 @@
++#! /usr/bin/env python
++
+ # MIT License
+
+ # Copyright (c) 2018 Jose Amores","This change is not needed, please revert it."
+9111,"@@ -40,7 +40,9 @@ def train(params, train_set, num_boost_round=100,
+         Customized objective function.
+     feval : callable or None, optional (default=None)
+         Customized evaluation function.
++        Should accept two parameters: preds, train_data.
+         Note: should return (eval_name, eval_result, is_higher_better) or list of such tuples.
++        To ignore the default metric in params, set it to the string ``""None""``
+     init_model : string or None, optional (default=None)
+         Filename of LightGBM model or Booster instance used for continue training.
+     feature_name : list of strings or 'auto', optional (default=""auto"")","@ClimbsRocks Please add that it could be a string. `feval : callable, string or None, optional (default=None)`"
+9112,"@@ -1,7 +1,7 @@
+ # frozen_string_literal: true
+
+ module Faker
+-  class Sports
++  class Sports < Base
+     class Basketball < Base
+       class << self
+         ##","now that I have started using, I realized, I could have named my new class singular `Sport` and not having to make this change. let me know, I will update"
+9113,"@@ -23,7 +23,7 @@ func GetApps() map[string][]App {
+ 	apps := make(map[string][]App)
+ 	for platformType := range PluginMap {
+ 		labels := map[string]string{
+-			""com.ddev.platform"":          platformType,
++			""com.ddev.platform"":          ""ddev"",
+ 			""com.docker.compose.service"": ""web"",
+ 		}
+ 		sites, err := dockerutil.FindContainersByLabels(labels)",Not sure why this is changing to a hard-coded string.
+9114,"@@ -453,6 +453,15 @@ class FlowContentView(RequestHandler):
+         ))
+
+
++class Commands(RequestHandler):
++    def post(self):
++        result = self.master.commands.execute(self.json[""command""])
++        if result is None:
++            self.write({""result"": """"})
++            return
++        self.write({""result"": str(result)})
++
++
+ class Events(RequestHandler):
+     def get(self):
+         self.write([logentry_to_json(e) for e in self.master.events.data])","Is there a reason why we `str` the result? It would be nice to eventually support more datatypes here, so we want to generally aim for arbitrary JSON."
+9115,"@@ -29,7 +29,7 @@ import java.util.Iterator;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.Set;
+-import org.apache.commons.lang.SerializationUtils;
++import org.apache.commons.lang3.SerializationUtils;
+ import org.apache.hadoop.io.Writable;
+ import org.apache.hadoop.mapreduce.InputFormat;
+ import org.apache.hadoop.mapreduce.InputSplit;",Why did we update the to this api?
+9116,"@@ -164,4 +164,17 @@ public class Preferences {
+     public SharedPreferences getPreferences() {
+         return mStorage;
+     }
++
++    public static <T extends Enum<T>> T getEnumStringPref(SharedPreferences prefs, String key, T defaultEnum) {
++        String stringPref = prefs.getString(key, defaultEnum.name());
++        try {
++            return Enum.valueOf(defaultEnum.getDeclaringClass(), stringPref);
++        } catch (Exception ex) {
++            Log.w(K9.LOG_TAG, ""Unable to convert preference key ["" + key +
++                    ""] value ["" + stringPref + ""] to enum of type "" + defaultEnum.getDeclaringClass(), ex);
++
++            return defaultEnum;
++        }
++    }
++
+ }",should probably just catch `IllegalArgumentException` here
+9117,"@@ -38,7 +38,9 @@ type truncateFunc func(t Time, d Duration) Time
+ func (w *Window) getTruncateFunc(d Duration) (truncateFunc, error) {
+ 	switch months, nsecs := d.Months(), d.Nanoseconds(); {
+ 	case months != 0 && nsecs != 0:
+-		return nil, errors.New(codes.Invalid, ""duration used as an interval cannot mix month and nanosecond units"")
++		const docURL = ""https://v2.docs.influxdata.com/v2.0/reference/flux/stdlib/built-in/transformations/window/#calendar-months-and-years""
++		return nil, errors.New(codes.Invalid, ""duration used as an interval cannot mix month and nanosecond units"").
++			WithDocURL(docURL)
+ 	case months != 0:
+ 		return truncateByMonths, nil
+ 	case nsecs != 0:",What does this error message mean?
+9118,"@@ -864,7 +864,7 @@ def get_utf8_value(value):
+         return value
+
+     if not isinstance(value, six.string_types):
+-        value = six.text_type(value)
++        value = six.text_type(value).encode('utf-8')
+
+     if isinstance(value, six.text_type):
+         value = value.encode('utf-8')","I don't think this change is necessary. If we cast `value` to type `six.text_type`, then the next if statement should evaluate to True and do the encoding for us."
+9119,"@@ -54,6 +54,11 @@ class CartItem < ActiveRecord::Base
+             )
+           end
+         end
++      else
++        self.cart_item_traits.build(
++          name: trait[0],
++          value: handle_trait_values_for(trait)
++        )
+       end
+     end
+   end",Can we move this into a method(s)?
+9120,"@@ -22,3 +22,13 @@ func uitoa(val uint) string {
+ 	buf[i] = byte(val + '0')
+ 	return string(buf[i:])
+ }
++
++// clen returns the index of the first NULL byte in n or len(n) if n contains no NULL byte.
++func clen(n []byte) int {
++	for i := 0; i < len(n); i++ {
++		if n[i] == 0 {
++			return i
++		}
++	}
++	return len(n)
++}",You could perhaps call this `strlen` (although I don't particularly care about the name as it is an implementation detail).
+9121,"@@ -15,13 +15,8 @@ public class Regula
+ {
+     public const int Iterations = 4000000;
+
+-    public static volatile object VolatileObject;
+-
+     [MethodImpl(MethodImplOptions.NoInlining)]
+-    private static void Escape(object obj)
+-    {
+-        VolatileObject = obj;
+-    }
++    private static void Escape(object _) { }
+
+     [Benchmark(Description = nameof(Regula))]
+     public bool Test()",should we have a common `Escape()` method that can be used everywhere?
+9122,"@@ -228,7 +228,6 @@ export function diff(
+  */
+ export function commitRoot(commitQueue, root) {
+ 	if (options._commit) options._commit(root, commitQueue);
+-
+ 	commitQueue.some(c => {
+ 		try {
+ 			commitQueue = c._renderCallbacks;",The whitespace removal above here is probably unintentional :slightly_smiling_face:
+9123,"@@ -90,14 +90,14 @@ func newServer(cfg config.Config, testing bool) (*Server, error) {
+ func (s *Server) Start(ctx context.Context) error {
+ 	cctx, cancel := context.WithCancel(context.Background())
+ 	s.subModuleCancel = cancel
+-	if err := s.p2pAgent.Start(cctx); err != nil {
+-		return errors.Wrap(err, ""error when starting P2P agent"")
+-	}
+ 	for _, cs := range s.chainservices {
+ 		if err := cs.Start(cctx); err != nil {
+ 			return errors.Wrap(err, ""error when starting blockchain"")
+ 		}
+ 	}
++	if err := s.p2pAgent.Start(cctx); err != nil {
++		return errors.Wrap(err, ""error when starting P2P agent"")
++	}
+ 	if err := s.dispatcher.Start(cctx); err != nil {
+ 		return errors.Wrap(err, ""error when starting dispatcher"")
+ 	}",should we start p2p even after dispatcher? b/c dispatcher handles msg from p2p
+9124,"@@ -101,13 +101,13 @@ func TestHandleInterfaceEmptySuccess(t *testing.T) {
+ 	handler := jsonHandler{reader: ifaceEmptyReader{}, handler: reflect.ValueOf(h)}
+
+ 	reqBuf := yarpc.NewBufferString(`[""a"", ""b"", ""c""]`)
+-	_, _, err := handler.Handle(context.Background(), &yarpc.Request{
++	_, respBuf, err := handler.Handle(context.Background(), &yarpc.Request{
+ 		Procedure: ""foo"",
+ 		Encoding:  ""json"",
+ 	}, reqBuf)
+
+ 	require.NoError(t, err)
+-	assert.JSONEq(t, `[""a"", ""b"", ""c""]`, reqBuf.String())
++	assert.JSONEq(t, `[""a"", ""b"", ""c""]`, respBuf.String())
+ }
+
+ func TestHandleSuccessWithResponseHeaders(t *testing.T) {",Did we decide once and for all to use req/resp throughout spring?
+9125,"@@ -8,8 +8,13 @@ describe ""videos/_access_callout"" do
+
+         render_callout video, signed_out: true
+
+-        expect(rendered).to have_css "".access-callout.auth-to-access""
+-        expect(rendered).to have_auth_to_access_link_for(video)
++        expect(rendered).to have_content(
++          I18n.t(""videos.show.auth_to_access_callout_text"")
++        )
++        expect(rendered).to have_link(
++          I18n.t(""videos.show.auth_to_access_button_text""),
++          href: video_auth_to_access_path(video),
++        )
+       end
+     end
+ ",Put a comma after the last parameter of a multiline method call.
+9126,"@@ -71,8 +71,18 @@ func populateScratchBucketGcsPath(scratchBucketGcsPath *string, zone string, mgc
+ 		if err != nil {
+ 			return """", daisy.Errf(""invalid scratch bucket GCS path %v"", scratchBucketGcsPath)
+ 		}
++
+ 		if !scratchBucketCreator.IsBucketInProject(*project, scratchBucketName) {
+-			return """", daisy.Errf(""Scratch bucket `%v` is not in project `%v`"", scratchBucketName, *project)
++			err := storageClient.DeleteGcsPath(*scratchBucketGcsPath)
++			var deletionResults string
++			if err == nil {
++				deletionResults = fmt.Sprintf(""The resources in %q have been deleted."", *scratchBucketGcsPath)
++			} else {
++				deletionResults = fmt.Sprintf(""Failed to delete resources in %q. Check with the owner of %q for more information"",
++					*scratchBucketGcsPath, scratchBucketName)
++			}
++			return """", daisy.Errf(""Scratch bucket %q is not in project %q. %s"",
++				scratchBucketName, *project, deletionResults)
+ 		}
+
+ 		scratchBucketAttrs, err := storageClient.GetBucketAttrs(scratchBucketName)","This will delete the whole bucket, which could have unforseen consequences in normal use cases. We should be deleting args.SourceFile instead."
+9127,"@@ -721,5 +721,9 @@ public class Constants {
+     // Constant to allow test version to be passed as flow parameter. Passing test version will be
+     // allowed for Azkaban ADMIN role only
+     public static final String FLOW_PARAM_ALLOW_IMAGE_TEST_VERSION = ""allow.image.test.version"";
++
++    //
++    public static final String FLOW_PARAM_ALLOW_RESTART_ON_EXECUTION_STOPPED = ""allow""
++        + "".restart.on.execution.stopped"";
+   }
+ }",Lets move the whole string to next line for better readability
+9128,"@@ -104,7 +104,7 @@ app.controller('CalendarListController', ['$scope', '$rootScope', '$window', 'Ha
+ 						$scope.subscription.newSubscriptionLocked = false;
+ 					})
+ 					.catch(function() {
+-						OC.Notification.showTemporary(t('calendar', 'Error saving WebCal-calendar'));
++						OC.Notification.showTemporary(t('calendar', 'Could not save WebCal-calendar'));
+ 						$scope.subscription.newSubscriptionLocked = false;
+ 					});
+ 			}).catch(function(reason) {",Please change this back to `Error saving WebCal-calendar` (and `Error saving WebCal-calendar` only)
+9129,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?
+9130,"@@ -3,14 +3,18 @@ using Datadog.Trace.Logging;
+ using Datadog.Trace.Logging.LogProviders;
+ using NLog;
+ using NLog.Config;
++using NLog.Layouts;
+ using NLog.Targets;
+ using Xunit;
+
+ namespace Datadog.Trace.Tests.Logging
+ {
+     [Collection(nameof(Datadog.Trace.Tests.Logging))]
++    [TestCaseOrderer(""Datadog.Trace.TestHelpers.AlphabeticalOrderer"", ""Datadog.Trace.TestHelpers"")]
+     public class NLogLogProviderTests
+     {
++        private const string ExpectedStringFormat = ""\""{0}\"": \""{1}\"""";
++
+         private readonly ILogProvider _logProvider;
+         private readonly ILog _logger;
+         private readonly MemoryTarget _target;","Not ideal, but I used a test case orderer so I could avoid a bug that occurs when running two tracer's sequentially with different DD_LOGS_INJECTION settings."
+9131,"@@ -129,6 +129,13 @@ func (p *Packer) Size() uint {
+ 	return p.bytes
+ }
+
++// HeaderFull returns true if the pack header is at maximum capacity.
++func (p *Packer) HeaderFull() bool {
++	p.m.Lock()
++	defer p.m.Unlock()
++	return EntrySize+crypto.Extension+(uint(headerLengthSize)*uint(len(p.blobs)-1)) <= uint(maxHeaderSize)
++}
++
+ // Count returns the number of blobs in this packer.
+ func (p *Packer) Count() int {
+ 	p.m.Lock()","I think the condition should be ` uint(headerLengthSize) + crypto.Extension + (len(p.blobs)+1)*uint(EntrySize) > uint(maxHeaderSize)` `headerLengthSize` is only the length field. But the pack header also includes the blob type and its ID. And the result of the check, currently seems to be inverted."
+9132,"@@ -19,7 +19,6 @@ namespace Nethermind.Mev.Test
+ {
+     public enum SelectorType
+     {
+-        V1,
+         V2,
+     }
+ }",Remove selector if only 1 version is supported
+9133,"@@ -1188,7 +1188,7 @@ class Application extends BaseApplication {
+ 		const selectedNoteIds = state.selectedNoteIds;
+ 		const note = selectedNoteIds.length === 1 ? await Note.load(selectedNoteIds[0]) : null;
+
+-		for (const itemId of ['copy', 'paste', 'cut', 'selectAll', 'bold', 'italic', 'link', 'code', 'insertDateTime', 'commandStartExternalEditing', 'showLocalSearch']) {
++		for (const itemId of ['paste', 'cut', 'bold', 'italic', 'link', 'code', 'insertDateTime']) {
+ 			const menuItem = Menu.getApplicationMenu().getMenuItemById(`edit:${itemId}`);
+ 			if (!menuItem) continue;
+ 			const isHtmlNote = !!note && note.markup_language === MarkupToHtml.MARKUP_LANGUAGE_HTML;",Why did you remove more than the asked command?
+9134,"@@ -320,11 +320,15 @@ func (s *session) handlePacketImpl(p *receivedPacket) error {
+ 		s.largestRcvdPacketNumber,
+ 		hdr.PacketNumber,
+ 	)
+-	if utils.Debug() {
+-		utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, time.Now().Format(""15:04:05.000""))
+-	}
+
+ 	packet, err := s.unpacker.Unpack(hdr.Raw, hdr, data)
++	if utils.Debug() {
++		if err != nil {
++			utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, time.Now().Format(""15:04:05.000""))
++		} else {
++			utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x, %s @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, packet.encryptionLevel, time.Now().Format(""15:04:05.000""))
++		}
++	}
+ 	// if the decryption failed, this might be a packet sent by an attacker
+ 	// don't update the remote address
+ 	if quicErr, ok := err.(*qerr.QuicError); ok && quicErr.ErrorCode == qerr.DecryptionFailure {","I just realized that we are logging time now - we shouldn't do that here, that's the logger's job. I've opened a new issue for that #444."
+9135,"@@ -44,13 +44,13 @@ const char *MolHolderBaseDoc =
+     ""The API is quite simple: \n""
+     ""  AddMol(mol) -> adds a molecule to the molecule holder, returns index of ""
+     ""molecule\n""
+-    ""  GetMol(idx) -> return the molecule at index idx\n"";
++    ""  GetMol(idx,sanitize=True) -> return the molecule at index idx\n"";
+
+ const char *MolHolderDoc =
+     ""Holds raw in-memory molecules\n""
+     ""  AddMol(mol) -> adds a molecule to the molecule holder, returns index of ""
+     ""molecule\n""
+-    ""  GetMol(idx) -> return the molecule at index idx\n"";
++    ""  GetMol(idx,sanitize=True) -> return the molecule at index idx\n"";
+
+ const char *CachedMolHolderDoc =
+     ""Holds molecules in their binary representation.\n""",why is the `sanitize=True` here in the docs?
+9136,"@@ -9,6 +9,9 @@ class Approval < ActiveRecord::Base
+   end
+
+   belongs_to :proposal
++  belongs_to :user
++  has_many :delegations, through: :user, source: :outgoing_delegates
++  has_many :delegates, through: :delegations, source: :assignee
+   acts_as_list scope: :proposal
+
+   belongs_to :parent, class_name: 'Approval'","Didn't end up using this, but I think it's useful anyway."
+9137,"@@ -121,7 +121,16 @@ namespace Microsoft.DotNet.Build.Tasks
+                 // Every test project comes with 4 of them, so not producing a warning here.
+                 else if (!string.IsNullOrEmpty(relativePath))
+                 {
+-                    copyCommands.AppendLine($""call :copyandcheck \""%PACKAGE_DIR%\\{relativePath}\"" \""%EXECUTION_DIR%\\{Path.GetFileName(relativePath)}\"" ||  exit /b -1"");
++                    bool? preserveSubDirectories = dependency.GetMetadata(""PreserveSubDirectories"")?.Equals(""true"", StringComparison.OrdinalIgnoreCase);
++                    string filePath = Path.GetFileName(relativePath);
++                    if (preserveSubDirectories == true)
++                    {
++                        //This is to remove the first two directories on the path which will always be the dependency followed by the version used
++                        int indexOfSubDirectories = relativePath.IndexOf(""\\"", relativePath.IndexOf(""\\"")+1);
++                        filePath = relativePath.Substring(indexOfSubDirectories);
++                        copyCommands.AppendLine($""call :makedir \""%EXECUTION_DIR%{Path.GetDirectoryName(filePath)}\"" ||  exit /b -1"");
++                    }
++                    copyCommands.AppendLine($""call :copyandcheck \""%PACKAGE_DIR%\\{relativePath}\"" \""%EXECUTION_DIR%\\{filePath}\"" ||  exit /b -1"");
+                 }
+             }
+             cmdExecutionTemplate = cmdExecutionTemplate.Replace(""[[CopyFilesCommands]]"", copyCommands.ToString());",I'm pretty sure there's already a metadata item that contains what you're calculating here (PackageRelativePath)?
+9138,"@@ -79,6 +79,15 @@ module ProjectsHelper
+     end
+   end
+
++  def browse_security_button(project)
++    css_class = project.uuid.blank? ? 'disabled' : 'btn-primary'
++    project_name = CGI.escape(project.name)
++    url = ENV['OH_SECURITY_URL'] + ""/#{project_name}/#{project.uuid}?project_id=#{project.id}""
++    haml_tag :a, href: url, class: ""btn #{css_class}"", target: '_blank' do
++      concat t('projects.browse_security')
++    end
++  end
++
+   private
+
+   def project_twitter_description_analysis(project, analysis)",We want to show this button only when there is a page for us to connect to. There is no reason to put the Browse Security Info button on the page at all unless we've identified the UUID from the KB.
+9139,"@@ -42,10 +42,14 @@
+ #include ""res/windowsicon.xpm""
+ #include ""res/macosicon.xpm""
+ #include ""res/linuxicon.xpm""
++#include ""res/androidicon.xpm""
+ #include ""res/freebsdicon.xpm""
++#include ""res/linuxarmicon2.xpm""
+ #include ""res/atiicon.xpm""
++#include ""res/amdicon2.xpm""
+ #include ""res/nvidiaicon.xpm""
+-#include ""res/androidicon.xpm""
++#include ""res/nvidiaicon2.xpm""
++#include ""res/intelgpuicon2.xpm""
+ #include ""res/virtualboxicon.xpm""
+ #include ""res/blankicon.xpm""
+ ",Why `2` in this and others?
+9140,"@@ -118,6 +118,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting
+             var testHostProcessName = (this.architecture == Architecture.X86) ? X86TestHostProcessName : X64TestHostProcessName;
+             var currentWorkingDirectory = Path.GetDirectoryName(typeof(DefaultTestHostManager).GetTypeInfo().Assembly.Location);
+             var argumentsString = "" "" + Constants.PortOption + "" "" + connectionInfo.Port;
++            argumentsString += "" "" + Constants.ParentProcessIdOption + "" "" + processHelper.GetCurrentProcessId();
+
+             var testhostProcessPath = Path.Combine(currentWorkingDirectory, testHostProcessName);
+ ","This may cause a new allocation, please consider merging the concat in above line. Same applies to change in dotnethostmanager."
+9141,"@@ -490,6 +490,16 @@ given file (report RP0402 must not be disabled)'}
+                 importedname = node.modname
+             else:
+                 importedname = node.names[0][0].split('.')[0]
++        if isinstance(node, astroid.ImportFrom) and \
++                node.as_string().startswith('from .'):
++            # We need the impotedname with first point to detect local package
++            # Example of node:
++            #  'from .my_package1 import MyClass1'
++            #  the output should be '.my_package1' instead of 'my_package1'
++            # Example of node:
++            #  'from . import my_package2'
++            #  the output should be '.my_package2' instead of '{pyfile}'
++            importedname = '.' + importedname
+         self._imports_stack.append((node, importedname))
+
+     @staticmethod","Alternatively (and better) would be to look for the .level attribute of the node. If it's bigger or equal to 1, than that is a relative import. So ""from . import x"" should have level 1, while ""from .. import z"" should have level 2 and so on. The same should happen for ""from .c import z""."
+9142,"@@ -25,4 +25,14 @@ public abstract class AbstractASTXPathHandler implements XPathHandler {
+     public void initialize(IndependentContext context, Language language, Class<?> functionsClass) {
+         context.declareNamespace(""pmd-"" + language.getTerseName(), ""java:"" + functionsClass.getName());
+     }
++
++    @Override
++    public void initialize() {
++        // override if needed
++    }
++
++    @Override
++    public void initialize(IndependentContext context) {
++        // override if needed
++    }
+ }","Btw. this API must definitely change with PMD 7 - we are exposing here a implementation detail (that we use Saxon). And it happens, that the way, how custom functions are registered, changed with Saxon 9.5... which makes the need for a implementation agnostic API relevant..."
+9143,"@@ -44,6 +44,8 @@ type GenericDeploymentSpec struct {
+ 	Timeout Duration `json:""timeout,omitempty"" default:""6h""`
+ 	// List of encrypted secrets and targets that should be decoded before using.
+ 	Encryption *SecretEncryption `json:""encryption""`
++	// Notification to be sent to users via Slack or email
++	Notification *Notification `json:""notification""`
+ }
+
+ type DeploymentPlanner struct {",nit: `Additional configuration used while sending notification to external services.`
+9144,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings."
+9145,"@@ -247,7 +247,7 @@ describe 'LinksControllerTest' do
+
+     get :new, project_id: project.url_name, category_id: category_id
+     assigns(:category_name).must_equal 'Homepage'
+-    assigns(:link).title.must_equal :Homepage
++    assigns(:link).title.must_equal 'Homepage'
+   end
+
+   it 'load_category_and_title_for_new_download_link' do",This should have failed before.
+9146,"@@ -0,0 +1,19 @@
++package paymentchannel
++
++import (
++	""github.com/filecoin-project/go-address""
++	""github.com/filecoin-project/specs-actors/actors/builtin/paych""
++)
++
++// ChannelInfo is the primary payment channel record
++type ChannelInfo struct {
++	Owner    address.Address // Payout (From) address for this channel, has ability to sign and send funds
++	State    *paych.State
++	Vouchers []*VoucherInfo // All vouchers submitted for this channel
++}
++
++// Voucher Info is a record of a voucher submitted for a payment channel
++type VoucherInfo struct {
++	Voucher *paych.SignedVoucher
++	Proof   []byte
++}",the paymentchannel dir is where the paymentchannel manager will live. it will store the types below.
+9147,"@@ -219,7 +219,9 @@ webdriver.CommandName = {
+   GET_SESSION_LOGS: 'getSessionLogs',
+
+   // Non-standard commands used by the standalone Selenium server.
+-  UPLOAD_FILE: 'uploadFile'
++  UPLOAD_FILE: 'uploadFile',
++
++  GET_CANVAS_URL: 'getCanvasUrl'
+ };
+
+ ",This is Safari specific and should be defined somewhere in the `safaridriver` namespace
+9148,"@@ -58,13 +58,13 @@ func TestNewRound(t *testing.T) {
+ 	require := require.New(t)
+ 	bc, roll := makeChain(t)
+ 	rc := &roundCalculator{bc, true, roll, bc.CandidatesByHeight, 0}
+-	proposer, err := rc.calculateProposer(5, 1, []string{""1"", ""2"", ""3"", ""4"", ""5""})
++	_, err := rc.calculateProposer(5, 1, []string{""1"", ""2"", ""3"", ""4"", ""5""})
+ 	require.Error(err)
+ 	var validDelegates [24]string
+ 	for i := 0; i < 24; i++ {
+ 		validDelegates[i] = identityset.Address(i).String()
+ 	}
+-	proposer, err = rc.calculateProposer(5, 1, validDelegates[:])
++	proposer, err := rc.calculateProposer(5, 1, validDelegates[:])
+ 	require.NoError(err)
+ 	require.Equal(validDelegates[6], proposer)
+ ",assignments should only be cuddled with other assignments (from `wsl`)
+9149,"@@ -641,12 +641,13 @@ Blockly.genUid.soup_ = '!#%()*+,-./:;=?@[]^_`{|}~' +
+  * Measure some text using a canvas in-memory.
+  * @param {string} fontSize E.g., '10pt'
+  * @param {string} fontFamily E.g., 'Arial'
++ * @param {string} fontWeight E.g., '600'
+  * @param {string} text The actual text to measure
+  * @return {number} Width of the text in px.
+  */
+-Blockly.measureText = function(fontSize, fontFamily, text) {
++Blockly.measureText = function(fontSize, fontFamily, fontWeight, text) {
+   var canvas = document.createElement('canvas');
+   var context = canvas.getContext('2d');
+-  context.font = fontSize + fontFamily;
++  context.font = fontWeight + ' ' + fontSize + ' ' + fontFamily;
+   return context.measureText(text).width;
+ };","prefer changing the signature by adding params to the end, not the middle, I think."
+9150,"@@ -301,6 +301,15 @@ func makeStatefulSetService(p *monitoringv1.Prometheus, config Config) *v1.Servi
+ 			},
+ 		},
+ 	}
++
++	if p.Spec.Thanos != nil {
++		svc.Spec.Ports = append(svc.Spec.Ports, v1.ServicePort{
++			Name:       ""grpc"",
++			Port:       10901,
++			TargetPort: intstr.FromString(""grpc""),
++		})
++	}
++
+ 	return svc
+ }
+ ",I guess we aim for hardcoded port for Prometheus operated ports right?
+9151,"@@ -602,8 +602,10 @@ class FormatChecker(BaseTokenChecker):
+             isinstance(node.parent, nodes.TryFinally) and node in node.parent.finalbody
+         ):
+             prev_line = node.parent.body[0].tolineno + 1
++        elif isinstance(node.parent, nodes.Module):
++            prev_line = 0
+         else:
+-            prev_line = node.parent.statement().fromlineno
++            prev_line = node.parent.statement(future=True).fromlineno
+         line = node.fromlineno
+         assert line, node
+         if prev_line == line and self._visited_lines.get(line) != 2:",This is the same effect as doing `node.parent.fromlineno` but avoids the `StatementMissing` exception from calling `statement`.
+9152,"@@ -165,12 +165,15 @@ def request_candidate_sets(days, top, similar):
+ @cli.command(name='request_recommendations')
+ @click.option(""--top"", type=int, default=200, help=""Generate given number of top artist recommendations"")
+ @click.option(""--similar"", type=int, default=200, help=""Generate given number of similar artist recommendations"")
+-def request_recommendations(top, similar):
++@click.option(""--mb_id"", callback=parse_list, default=[], multiple=True, help=""Generate recommendations for given users"" \
++              "" Generate recommendation for all users by default."")
++def request_recommendations(top, similar, mb_id):
+     """""" Send the cluster a request to generate recommendations.
+     """"""
+     params = {
+         'recommendation_top_artist_limit': top,
+         'recommendation_similar_artist_limit': similar,
++        'musicbrainz_id': mb_id
+     }
+     send_request_to_spark_cluster(_prepare_query_message('cf_recording.recommendations.recommend', params=params))
+ ","I think user-ids might be better; also note that options should use - and not _ to separate words. Also, how are more than one id specified? comma seperated? I think the usage statement should indicate this."
+9153,"@@ -117,14 +117,7 @@ func nanosecondsToTicks(ns int64) timeUnit {
+
+ // sleepTicks should sleep for specific number of microseconds.
+ func sleepTicks(d timeUnit) {
+-	for d != 0 {
+-		ticks()            // update timestamp
+-		ticks := uint32(d) // current scaling only supports 100 usec to 6553 msec
+-		if !timerSleep(ticks) {
+-			return
+-		}
+-		d -= timeUnit(ticks)
+-	}
++	timerSleep(uint32(d))
+ }
+
+ // number of ticks (microseconds) since start.",This code is necessary. It makes sure that you can sleep for longer durations than the timer supports.
+9154,"@@ -96,7 +96,7 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> {
+    * @param executorService an executor service to parallelize tasks to delete manifests and data files
+    * @return this for method chaining
+    */
+-  ExpireSnapshots executeWith(ExecutorService executorService);
++  ExpireSnapshots executeDeleteWith(ExecutorService executorService);
+
+   /**
+    * Allows expiration of snapshots without any cleanup of underlying manifest or data files.",Can we add the new name in parallel and deprecate this name? We should be careful about changes to the public API and give people at least a release to switch over before removing public methods.
+9155,"@@ -32,8 +32,10 @@ bool wlr_backend_start(struct wlr_backend *backend) {
+ }
+
+ void wlr_backend_destroy(struct wlr_backend *backend) {
+-	if (backend->impl->destroy) {
++	if (backend->impl && backend->impl->destroy) {
+ 		backend->impl->destroy(backend);
++	} else {
++		free(backend);
+ 	}
+ }
+ ",If you're going to start testing that impl itself is not NULL you should probably be doing it everywhere.
+9156,"@@ -159,7 +159,7 @@ func ParseFromStructuredObject(s interface{}) (Manifest, error) {
+ 	}, nil
+ }
+
+-func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string) ([]Manifest, error) {
++func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string, configFileName string) ([]Manifest, error) {
+ 	// If no name was specified we have to walk the app directory to collect the manifest list.
+ 	if len(names) == 0 {
+ 		err := filepath.Walk(dir, func(path string, f os.FileInfo, err error) error {",`ctx` is unused in LoadPlainYAMLManifests
+9157,"@@ -87,7 +87,7 @@ public class BlockHeaderBuilder {
+   }
+
+   public static BlockHeaderBuilder fromBuilder(final BlockHeaderBuilder fromBuilder) {
+-    BlockHeaderBuilder toBuilder =
++    final BlockHeaderBuilder toBuilder =
+         create()
+             .parentHash(fromBuilder.parentHash)
+             .ommersHash(fromBuilder.ommersHash)",why is this called toBuilder when the method is called fromBuilder? (I realise you did not change this...)
+9158,"@@ -40,4 +40,10 @@ public class FlinkConfigOptions {
+           .intType()
+           .defaultValue(100)
+           .withDescription(""Sets max infer parallelism for source operator."");
++
++  public static final ConfigOption<Integer> SOURCE_READER_FETCH_BATCH_SIZE = ConfigOptions
++      .key(""source.iceberg.reader.fetch-batch-size"")
++      .intType()
++      .defaultValue(2048)
++      .withDescription(""The target batch size for split reader fetch."");
+ }",nit: seems rather large.
+9159,"@@ -119,7 +119,7 @@ def get_listens(user_name):
+     latest_listen = db_conn.fetch_listens(
+         user_name,
+         limit=1,
+-        to_ts=max_ts,
++        to_ts=int(time.time()),
+     )
+     latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 else 0
+ ",I think it'd make sense to only calculate time.time() once (it's also used if max_ts and min_ts aren't set)
+9160,"@@ -53,6 +53,8 @@ public abstract class TestCaseView {
+
+   public abstract GrpcStreamingType grpcStreamingType();
+
++  public abstract String grpcStubTypeName();
++
+   public abstract String mockGrpcStubTypeName();
+
+   public abstract String createStubFunctionName();",Use existing `grpcStubCallString` instead
+9161,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace
++{
++    internal static class TraceConstants
++    {
++        public const ulong MaxTraceId = 9_223_372_036_854_775_807; // 2^63-1
++    }
++}","In a recent PR, Bob added a `TracerConstants` class. Do you think this makes sense to put in that class instead so that we can consolidate?"
+9162,"@@ -73,6 +73,10 @@ type Service struct {
+ 	auth            BlockAuthenticator
+ 	parallelBlocks  uint64
+ 	deadlineTimeout time.Duration
++	// catchpointWriting defines whether we've ran into a state where the ledger is currently busy writing the
++	// catchpoint file. If so, we want to pospone all the catchup process until the catchpoint file writing is complete,
++	// and resume from there without stopping the catchup timer.
++	catchpointWriting bool
+
+ 	// The channel gets closed when the initial sync is complete. This allows for other services to avoid
+ 	// the overhead of starting prematurely (before this node is caught-up and can validate messages for example).","I want to propose couple of different names for catchpointWriting: syncInterruptedWaitingCatchpointWriting syncWaitingForCatchpointWriting catchpointWriting is lacking context, and I found it difficult to understand the logic without this context."
+9163,"@@ -92,7 +92,7 @@ class InventoryImporter(object):
+
+         Args:
+             session (object): Database session.
+-            model (str): Model name to create.
++            model (Model): Model name to create.
+             dao (object): Data Access Object from dao.py
+             service_config (ServiceConfig): Service configuration.
+             inventory_id (str): Inventory id to import from","Do you still need the `name` in the arg description, if this is not `str` type anymore.?"
+9164,"@@ -42,15 +42,5 @@ def allreduce_grads(params, coalesce=True, bucket_size_mb=-1):
+
+
+ class DistOptimizerHook(OptimizerHook):
+-
+-    def __init__(self, grad_clip=None, coalesce=True, bucket_size_mb=-1):
+-        self.grad_clip = grad_clip
+-        self.coalesce = coalesce
+-        self.bucket_size_mb = bucket_size_mb
+-
+-    def after_train_iter(self, runner):
+-        runner.optimizer.zero_grad()
+-        runner.outputs['loss'].backward()
+-        if self.grad_clip is not None:
+-            self.clip_grads(runner.model.parameters())
+-        runner.optimizer.step()
++    """"""Deprecated optimizer hook for distributed training""""""
++    pass",We may raise a warning.
+9165,"@@ -2,8 +2,10 @@ import AbstractModel from 'hospitalrun/models/abstract';
+ import DS from 'ember-data';
+
+ export default AbstractModel.extend({
+-  patient: DS.belongsTo('patient'),
++  // Attributes
+   name: DS.attr('string'),
+   icd9CMCode: DS.attr('string'),
+-  icd10Code: DS.attr('string')
++  icd10Code: DS.attr('string'),
++  // Associations
++  patient: DS.belongsTo('patient'),
+ });",Trailing comma caused the eslint test to fail
+9166,"@@ -0,0 +1,6 @@
++from werkzeug.utils import import_string
++
++from .config import CFG_RELATIONSHIPS_NODE_ENGINE, CFG_RELATIONSHIPS_EDGE_ENGINE
++
++Node = import_string(CFG_RELATIONSHIPS_NODE_ENGINE)
++Edge = import_string(CFG_RELATIONSHIPS_EDGE_ENGINE)","I think you should use `app.config`. In the usual case, the config file is not overwritten, there is additional config file outside of the source of `Invenio`."
+9167,"@@ -86,6 +86,16 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat
+ 				new TrustedIssuerJwtAuthenticationManagerResolver(
+ 						Collections.unmodifiableCollection(trustedIssuers)::contains));
+ 	}
++
++	/**
++     * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided
++     * parameters
++     * @param trustedIssuer a predicate to determine whether the issuer should be trusted or not
++     */
++    public JwtIssuerAuthenticationManagerResolver(Predicate<String> trustedIssuer) {
++        this.authenticationManager = new ResolvingAuthenticationManager(
++                new TrustedIssuerJwtAuthenticationManagerResolver(trustedIssuer));
++    }
+
+ 	/**
+ 	 * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided",Will you please update the copyright message to now include `2021`?
+9168,"@@ -38,8 +38,8 @@ void test_rw(const Offsets &offsets, const Data &data)
+
+     for (std::size_t index = 0; index < offsets.size() - 1; ++index)
+     {
+-        typename IndexedData::ResultType expected_result(&data[offsets[index]],
+-                                                         &data[offsets[index + 1]]);
++        typename IndexedData::ResultType expected_result(data.begin() + offsets[index],
++                                                         data.begin() + offsets[index + 1]);
+         BOOST_CHECK_EQUAL(expected_result, indexed_data.at(index));
+     }
+ }",Potential subscript out of range.
+9169,"@@ -185,7 +185,6 @@ func (ps *peerSelector) PeerDownloadDurationToRank(peer network.Peer, blockDownl
+ 	default: // i.e. peerRankInitialFourthPriority
+ 		return downloadDurationToRank(blockDownloadDuration, lowBlockDownloadThreshold, highBlockDownloadThreshold, peerRank3LowBlockTime, peerRank3HighBlockTime)
+
+-
+ 	}
+ }
+ ","please undo this change. you didn't really meant to make it, right ?"
+9170,"@@ -0,0 +1,13 @@
++import initStoryshots from '@storybook/addon-storyshots';
++import { puppeteerTest } from '@storybook/addon-storyshots-puppeteer';
++import path from 'path';
++
++initStoryshots( {
++	suite: 'Puppeteer storyshots',
++	test: puppeteerTest( {
++		// eslint-disable-next-line sitekit/acronym-case
++		storybookUrl: `file://${ path.resolve( __dirname, '../dist' ) }`,
++		setupTimeout: 5000,
++		testTimeout: 5000,
++	} ),
++} );",To check! are these millseconds or seconds :thinking: The docs aren't clear
+9171,"@@ -508,6 +508,7 @@ func (u *multiuploader) upload(firstBuf io.ReadSeeker) (*UploadOutput, error) {
+
+ 	// Read and queue the rest of the parts
+ 	for u.geterr() == nil {
++		num++
+ 		// This upload exceeded maximum number of supported parts, error now.
+ 		if num > int64(u.ctx.MaxUploadParts) || num > int64(MaxUploadParts) {
+ 			var msg string",Why was this moved?
+9172,"@@ -15,6 +15,10 @@ limitations under the License.
+ */
+ package v1alpha1
+
++type CStorPoolExpansion interface{}
++
++type CStorVolumeReplicaExpansion interface{}
++
+ type StoragePoolExpansion interface{}
+
+ type StoragePoolClaimExpansion interface{}",What are these object with suffix Expansion?
+9173,"@@ -831,6 +831,13 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       arity = ""1"")
+   private final Wei txFeeCap = DEFAULT_RPC_TX_FEE_CAP;
+
++  @Option(
++      names = {""--rpc-allow-unprotected-txs""},
++      description =
++          ""Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"",
++      arity = ""1"")
++  private final Boolean unprotectedTransactionsAllowed = false;
++
+   @Option(
+       names = {""--min-block-occupancy-ratio""},
+       description = ""Minimum occupancy ratio for a mined block (default: ${DEFAULT-VALUE})"",","This breaks backwards compatibility, so it will have to wait for the next quarterly release of the default is to deny. I would recommend adding the flag with the default to allow and then at the next quarterly release rc cycle flip the flag to deny."
+9174,"@@ -57,12 +57,12 @@
+ // league_size) is not limited by physical constraints. Its a pure logical
+ // number.
+
+-typedef Kokkos::TeamPolicy<> team_policy;
+-typedef team_policy::member_type team_member;
++using team_policy = Kokkos::TeamPolicy<>;
++using team_member = team_policy::member_type;
+
+ // Define a functor which can be launched using the TeamPolicy
+ struct hello_world {
+-  typedef int value_type;  // Specify value type for reduction target, sum
++  using value_type = int;  // Specify value type for reduction target, sum
+
+   // This is a reduction operator which now takes as first argument the
+   // TeamPolicy member_type. Every member of the team contributes to the",I'm kind of surprised this doesn't require `typename`?
+9175,"@@ -38,8 +38,7 @@ GLIB_TESTS
+
+ AC_CHECK_HEADER([sys/xattr.h],,[AC_MSG_ERROR([You must have sys/xattr.h from glibc])])
+
+-AC_CHECK_PROGS(YACC, 'bison -y', :)
+-AS_IF([test ""$YACC"" = :], [AC_MSG_ERROR([bison not found but required])])
++AS_IF([test ""$YACC"" != ""bison -y""], [AC_MSG_ERROR([bison not found but required])])
+
+ PKG_PROG_PKG_CONFIG
+ ","I think this will break the case (you can try even with /usr/bin/bison as value): `YACC=""/path/to/bison -y"" ./configure` I wonder if we should use AC_PROG_YACC at all or simply use AC_CHECK_PROGS since we want to use bison and not another yacc"
+9176,"@@ -66,8 +66,14 @@ namespace Nethermind.KeyStore.Config
+         [ConfigItem(Description = ""Plain private key to be used in test scenarios"")]
+         string TestNodeKey { get; set; }
+
+-        [ConfigItem(Description = ""Account to be used by the block author / coinbase"")]
++        [ConfigItem(Description = ""Account to be used by the block author / coinbase, to be loaded from keystore"")]
+         string BlockAuthorAccount { get; set; }
++
++        [ConfigItem(Description = ""Account to be used by the node for network communication (enode), to be loaded from keystore"")]
++        string EnodeAccount { get; set; }
++
++        [ConfigItem(Description = ""Path to key file to be used by the node for network communication (enode)"")]
++        string EnodeKeyFile { get; set; }
+
+         [ConfigItem(Description = ""Passwords to use to unlock accounts from the UnlockAccounts configuration item. Only used when no PasswordFiles provided."", DefaultValue = ""System.String[]"")]
+         string[] Passwords { get; set; }",can we explain to users in the docs what happens if they leave the field blank?
+9177,"@@ -442,10 +442,10 @@ class EC2Connection(AWSQueryConnection):
+                              [('item', Reservation)], verb='POST')
+
+     def run_instances(self, image_id, min_count=1, max_count=1,
+-                      key_name=None, security_groups=None,
+-                      user_data=None, addressing_type=None,
+-                      instance_type='m1.small', placement=None,
+-                      kernel_id=None, ramdisk_id=None,
++                      key_name=None, security_group_ids=None,
++                      security_groups=None, user_data=None,
++                      addressing_type=None, instance_type='m1.small',
++                      placement=None, kernel_id=None, ramdisk_id=None,
+                       monitoring_enabled=False, subnet_id=None,
+                       block_device_map=None,
+                       disable_api_termination=False,",We try not to change the function footprints unless absolutely necessary. Why is it necessary to have both secuirty_group_ids and security_groups?
+9178,"@@ -105,7 +105,7 @@ public class JavaSourceFolderProvider implements SourceFolderProvider {
+     if (Strings.isNullOrEmpty(relativePath)) {
+       return parentPackagePrefix;
+     }
+-    relativePath = relativePath.replaceAll(File.separator, ""."");
++    relativePath = relativePath.replace(File.separator, ""."");
+     return Strings.isNullOrEmpty(parentPackagePrefix)
+         ? relativePath
+         : parentPackagePrefix + ""."" + relativePath;","Thanks! We're already replacing File.separatorChar with '/' in the call to FileUtil#toCanonicalPath above, so the correct fix here should be: `relativePath.replace('/', '.')` I'll make the change upstream."
+9179,"@@ -2,8 +2,8 @@
+
+ namespace Shopsys\FrameworkBundle\Model\Product\Exception;
+
+-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
++use Symfony\Component\HttpKernel\Exception\GoneHttpException;
+
+-class ProductNotFoundException extends NotFoundHttpException implements ProductException
++class ProductNotFoundException extends GoneHttpException implements ProductException
+ {
+ }","It could be nice to be explicit about this change in upgrade notes, what do you think?"
+9180,"@@ -27,7 +27,7 @@ function logout (req, res, next) {
+       }
+
+       delete companion.providerTokens[providerName]
+-      tokenService.removeFromCookies(res, companion.options, companion.provider.authProviderName)
++      tokenService.removeFromCookies(res, companion.options, companion.provider.authProvider)
+       cleanSession()
+       res.json(Object.assign({ ok: true }, data))
+     })",spotted a bug.
+9181,"@@ -148,7 +148,7 @@ public class SmartStoreFullTextSearchSpeedTest extends SmartStoreTestCase {
+     private double queryData(Type textFieldType, int rowsPerAnimal, int matchingRowsPerAnimal) throws JSONException {
+         long totalQueryTime = 0;
+         for (String animal : ANIMALS) {
+-            String prefix = String.format(""%07d"", (int) Math.random()*matchingRowsPerAnimal);
++            String prefix = String.format(""%07d"", (int) (Math.random()*(rowsPerAnimal/matchingRowsPerAnimal)));
+             String stringToMatch = prefix + animal;
+
+             QuerySpec querySpec = textFieldType == Type.full_text",We were always using 0000000 prefix
+9182,"@@ -306,7 +306,9 @@ void signalHandler(int sig) {
+             }
+             {
+                 auto gJobMgr = nebula::meta::JobManager::getInstance();
+-                gJobMgr->shutDown();
++                if (gJobMgr) {
++                    gJobMgr->shutDown();
++                }
+             }
+             if (gKVStore) {
+                 gKVStore->stop();",Here we also need to determine if gJobMgr has called the init function.
+9183,"@@ -0,0 +1,18 @@
++module Mongoid
++  module Matcher
++
++    # @api private
++    module All
++      module_function def matches?(exists, value, condition)
++        condition.any? && condition.all? do |c|
++          case c
++          when ::Regexp, BSON::Regexp::Raw
++            Regex.matches_array_or_scalar?(value, c)
++          else
++            EqImpl.matches?(true, value, c, '$all')
++          end
++        end
++      end
++    end
++  end
++end","Out of curiosity, why is `condition.any?` also necessary here?"
+9184,"@@ -12,14 +12,16 @@ namespace meta {
+
+ std::unordered_map<GraphSpaceID, std::shared_ptr<HostManager>> HostManager::hostManagers_;
+
+-
+ // static
+ std::shared_ptr<const HostManager> HostManager::get(GraphSpaceID space) {
+     auto it = hostManagers_.find(space);
+     if (it != hostManagers_.end()) {
+         return it->second;
+     } else {
+-        return std::shared_ptr<const HostManager>();
++        auto* hmPtr = new HostManager(space);
++        std::shared_ptr<HostManager> hm(hmPtr);
++        hostManagers_.emplace(space, hm);
++        return hm;
+     }
+ }
+ ","Always use `std::make_shared` whenever possible, it will save you one memory allocation."
+9185,"@@ -30,7 +30,7 @@ var DBATag = ""v0.2.0""
+ var RouterImage = ""drud/nginx-proxy"" // Note that this is overridden by make
+
+ // RouterTag defines the tag used for the router.
+-var RouterTag = ""v0.3.0"" // Note that this is overridden by make
++var RouterTag = ""router-expose"" // Note that this is overridden by make
+
+ // COMMIT is the actual committish, supplied by make
+ var COMMIT = ""COMMIT should be overridden""",Update to real tag before pull.
+9186,"@@ -73,7 +73,7 @@ public class ITZipkinHealth {
+
+     // ensure we don't track health in prometheus
+     assertThat(scrape())
+-      .doesNotContain(""health"");
++      .doesNotContain(""health_check"");
+   }
+
+   String scrape() throws InterruptedException {",Is there any better string that only exposed by prometheus? We have changed the meter tags to contain method and service name. For example `scrape()` contains `method=getHealth` and `service=server.internal.health.ITzipkinHealth` which made this test failed.
+9187,"@@ -33,7 +33,7 @@ namespace Datadog.Trace.Vendors.Serilog.Core
+     /// be disposed to flush any events buffered within it. Most application
+     /// code should depend on <see cref=""ILogger""/>, not this class.
+     /// </summary>
+-    internal sealed class Logger : ILogger, ILogEventSink, IDisposable
++    internal sealed class Logger : ILogger, ILogEventSink, IDisposable, ICoreLogger
+     {
+         static readonly object[] NoPropertyValues = new object[0];
+ ",Adding ICoreLogger here lets us pull this into Core as a strategy
+9188,"@@ -38,7 +38,7 @@ type UsageStats struct {
+
+ // ContainerMetadata contains meta-data information for a container.
+ type ContainerMetadata struct {
+-	DockerID string `json:""-""`
++	DockerID string
+ }
+
+ // StatsContainer abstracts methods to gather and aggregate utilization data for a container.",why did you change this?
+9189,"@@ -138,9 +138,15 @@ module RSpec::Core
+       # @param colorizer [#wrap] An object to colorize the message_lines by
+       # @return [Array(String)] The example failure message colorized
+       def colorized_message_lines(colorizer = ::RSpec::Core::Formatters::ConsoleCodes)
+-        message_lines.map do |line|
+-          colorizer.wrap line, RSpec.configuration.failure_color
+-        end
++        message_lines
++          .map do |line|
++            colorizer.wrap line, :failure
++          end
++          .tap do |lines|
++            unless exception_class_name =~ /RSpec/
++              lines[1] = colorizer.wrap(exception_class_name, :failure) + "":""
++            end
++          end
+       end
+
+       # Returns the failures formatted backtrace.",This is invalid syntax on 1.8.
+9190,"@@ -408,10 +408,10 @@ M  END
+     rxn = rdChemReactions.ReactionFromSmarts('[C:1]1[O:2][N:3]1>>[C:1][O:2].[N:3]')
+     r1 = rxn.GetReactantTemplate(0)
+     sma = Chem.MolToSmarts(r1)
+-    self.assertEqual(sma, '[C:1]1-,:[O:2]-,:[N:3]-,:1')
++    self.assertEqual(sma, '[C:1]1[O:2][N:3]1')
+     p1 = rxn.GetProductTemplate(0)
+     sma = Chem.MolToSmarts(p1)
+-    self.assertEqual(sma, '[C:1]-,:[O:2]')
++    self.assertEqual(sma, '[C:1][O:2]')
+
+     p2 = rxn.GetProductTemplate(1)
+     sma = Chem.MolToSmarts(p2)","This isn't part of the PR, but I can't find in the smarts definition that ""[C][C]"" == ""[C]-,:[C]"" There is a line saying essentially not to specify undefined items (but that's a bracket versus non bracket thing)."
+9191,"@@ -77,14 +77,14 @@ var (
+
+ // UnsignedMessage is an exchange of information between two actors modeled
+ // as a function call.
+-// Messages are the equivalent of transactions in Ethereum.
+ type UnsignedMessage struct {
++	_    struct{}        `cbor:"",toarray""`
+ 	To   address.Address `json:""to""`
+ 	From address.Address `json:""from""`
+ 	// When receiving a message from a user account the nonce in
+ 	// the message must match the expected nonce in the from actor.
+ 	// This prevents replay attacks.
+-	CallSeqNum Uint64 `json:""callSeqNum""`
++	CallSeqNum uint64 `json:""callSeqNum""`
+
+ 	Value AttoFIL `json:""value""`
+ ",Is this required for tuple encoding? This is confusing.
+9192,"@@ -112,6 +112,7 @@ public class FlowRunnerManager implements EventListener,
+   private final ExecutorLoader executorLoader;
+   private final ProjectLoader projectLoader;
+   private final JobTypeManager jobtypeManager;
++  private final FlowPreparer flowPreparer;
+
+   private final Props azkabanProps;
+   private final File executionDirectory;",Does it need to be a member variable? It is currently only used in one method.
+9193,"@@ -37,7 +37,7 @@ function showNewJoinGroupSelection (button, user, apiClient) {
+         console.debug('No item is currently playing.');
+     }
+
+-    apiClient.sendSyncPlayCommand(sessionId, 'ListGroups').then(function (response) {
++    apiClient.sendSyncPlayCommand('ListGroups').then(function (response) {
+         response.json().then(function (groups) {
+             var menuItems = groups.map(function (group) {
+                 return {",@MrTimscampi doesn't this need an update to apiclient?..
+9194,"@@ -472,7 +472,7 @@ static const byte xop_a_extra[256] = {
+  */
+ int
+ decode_sizeof(dcontext_t *dcontext, byte *start_pc,
+-              int *num_prefixes _IF_X64(uint *rip_rel_pos))
++              int *num_prefixes _IF_X86_64(uint *rip_rel_pos))
+ {
+     byte *pc = start_pc;
+     uint opc = (uint)*pc;",This is a nop: prob best for history to not change the line
+9195,"@@ -21,7 +21,8 @@ type TrivialTestSlasher struct {
+ 	SendCalls uint64
+ }
+
+-// Slash is a required function for storageFaultSlasher interfaces and is intended to do nothing.
++// Slash is a required function for storageFaultSlasher interfaces and does nothing but track
++// how many times it's called.
+ func (ts *TrivialTestSlasher) Slash(context.Context, *types.BlockHeight) error {
+ 	ts.SendCalls++
+ 	return nil",Can you delete this whole file now?
+9196,"@@ -24,6 +24,7 @@ type ReturnedContract struct {
+ 	Erc721Token blockchain.Erc721Token
+ 	ArrDelete   blockchain.ArrayDelete
+ 	ArrString   blockchain.ArrayString
++	ArrPassing  blockchain.ArrayPassing
+ }
+
+ // StartContracts deploys and starts fp token smart contract and stable token smart contract,erc721 token smart contract","can you combine this passing test, code, solidity binary into existing ArrDelete? the function is much similar, pushing int value into an array, and delete one item in the array"
+9197,"@@ -340,10 +340,10 @@ public class QueueFragment extends Fragment {
+                         SortOrder sortOrder = UserPreferences.getQueueKeepSortedOrder();
+                         DBWriter.reorderQueue(sortOrder, true);
+                         if (recyclerAdapter != null) {
+-                            recyclerAdapter.setLocked(true);
++                            recyclerAdapter.setKeepSorted(true);
+                         }
+                     } else if (recyclerAdapter != null) {
+-                        recyclerAdapter.setLocked(UserPreferences.isQueueLocked());
++                        recyclerAdapter.setKeepSorted(UserPreferences.isQueueKeepSorted());
+                     }
+                     getActivity().invalidateOptionsMenu();
+                     return true;","I think that could lead to problems when setting it to not sorted again. In that case, it will not be reset. What about using one single method for the adapter (`setDragDropEnabled`)?"
+9198,"@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
+ 		return """", err
+ 	}
+
+-	if app.SiteStatus() != ""running"" {
+-		return """", errors.New(""app not running locally. Try `ddev start`"")
++	if app.SiteStatus() != platform.SiteRunning {
++		return """", errors.New(""App not running locally. Try `ddev start`"")
+ 	}
+
+ 	db, err := app.FindContainerByType(""db"")","I'd say the error should be an error, not instructions to the user. So error would be something like ""site should be running and is not"""
+9199,"@@ -60,11 +60,12 @@ const (
+ 	// 9) Add 'ipToTask' map to state file
+ 	// 10) Add 'healthCheckType' field in 'apicontainer.Container'
+ 	// 11)
+-	//  a) Add 'PrivateDNSName' field to 'api.ENI'
+-	//  b)Remove `AppliedStatus` field form 'apicontainer.Container'
++	//   a) Add 'PrivateDNSName' field to 'api.ENI'
++	//   b)Remove `AppliedStatus` field form 'apicontainer.Container'
+ 	// 12) Deprecate 'TransitionDependencySet' and add new 'TransitionDependenciesMap' in 'apicontainer.Container'
+ 	// 13) Add 'resources' field to 'api.task.task'
+-	ECSDataVersion = 13
++	// 14) Add 'V3EndpointID' field to 'Container' struct
++	ECSDataVersion = 14
+
+ 	// ecsDataFile specifies the filename in the ECS_DATADIR
+ 	ecsDataFile = ""ecs_agent_data.json""","Are you sure `v3EndpointIDToContainerName` and `v3EndpointIDToTask` are saved in the state file, can you verify that?"
+9200,"@@ -23,6 +23,8 @@ type KeyExchangeFunction func() crypto.KeyExchange
+
+ // The CryptoSetupServer handles all things crypto for the Session
+ type cryptoSetupServer struct {
++	mutex sync.RWMutex
++
+ 	connID               protocol.ConnectionID
+ 	remoteAddr           net.Addr
+ 	scfg                 *ServerConfig","This mutex is never used. Should it be, if users can now make calls into the crypto setup?"
+9201,"@@ -25,6 +25,9 @@ module Beaker
+             host.exec(Command.new(""w32tm /config /manualpeerlist:#{NTPSERVER} /syncfromflags:manual /update""))
+             host.exec(Command.new(""w32tm /resync""))
+             @logger.notify ""NTP date succeeded on #{host}""
++          elsif host['platform'].include? 'sles'
++            host.exec(Command.new(""sntp #{NTPSERVER}""))
++            @logger.notify ""NTP date succeeded on #{host}""
+           else
+             success=false
+             try = 0","Check here for sles-, and i'd prefer a regex since I don't know what an 'include' is going to do exactly. :)"
+9202,"@@ -65,7 +65,11 @@ class QR_Window(QWidget):
+         amount_text = ''
+         if amount:
+             if currency:
+-                self.amount = Decimal(amount) / self.exchanger.exchange(1, currency) if currency else amount
++                exch = self.exchanger.exchange(1, currency)
++                if exch == None:
++                    self.amount = Decimal('0.0')
++                else:
++                    self.amount = Decimal(amount) / exch if currency else amount
+             else:
+                 self.amount = Decimal(amount)
+             self.amount = self.amount.quantize(Decimal('1.0000'))",Should this be `None` instead?
+9203,"@@ -171,7 +171,14 @@ public final class ConfigUtil {
+       }
+
+       String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(""."") + 1);
+-      source.addProperty(cseKey, source.getProperty(key));
++      if (!source.containsKey(cseKey)) {
++        source.addProperty(cseKey, source.getProperty(key));
++      } else {
++        LOGGER
++            .warn(
++                ""Key {} with an ambiguous item {} exists, please use the same prefix or will get unexpected merged value."",
++                key, cseKey);
++      }
+     }
+   }
+ ","Not sure if the warning message is enough for this time, if the configuration is wrong, java-chassis may need to stop working instead of sending out the warning message to let the admin know about it. BTW, we may need a default override policy here."
+9204,"@@ -7,7 +7,7 @@ import (
+
+ func MustParse(args []string) []string {
+ 	parser := &Parser{
+-		After:         []string{""server"", ""agent"", ""etcd-snapshot""},
++		After:         []string{""server"", ""agent"", ""etcd-snapshot"", ""save"", ""delete"", ""list"", ""prune""},
+ 		FlagNames:     []string{""--config"", ""-c""},
+ 		EnvName:       version.ProgramUpper + ""_CONFIG_FILE"",
+ 		DefaultConfig: ""/etc/rancher/"" + version.Program + ""/config.yaml"",","I see this getting unwieldy as we add more commands with subcommands. Can we perhaps enhance it to handle subcommands properly? Perhaps something like `""etcd-snapshot:1""` which would indicate that the etcd-snapshot command may have 1 subcommand after it, and if the 1 next argument after it doesn't start with `--` then the args should be appended after that subcommand."
+9205,"@@ -249,13 +249,13 @@ public class ExecutionController extends EventHandler implements ExecutorManager
+   }
+
+   /**
+-   * Get all active (running, non-dispatched) flows from database. {@inheritDoc}
++   * Get all running (unfinished) flows from database. {@inheritDoc}
+    */
+   @Override
+   public List<ExecutableFlow> getRunningFlows() {
+     final ArrayList<ExecutableFlow> flows = new ArrayList<>();
+     try {
+-      getActiveFlowHelper(flows, this.executorLoader.fetchUnfinishedFlows().values());
++      getFlowsHelper(flows, this.executorLoader.fetchUnfinishedFlows().values());
+     } catch (final ExecutorManagerException e) {
+       this.logger.error(""Failed to get running flows."", e);
+     }",why returning a string instead of a list?
+9206,"@@ -3,11 +3,13 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
++using Datadog.Trace.Configuration;
++
+ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AdoNet.Npgsql
+ {
+     internal static class NpgsqlConstants
+     {
+-        public const string SqlCommandIntegrationName = ""NpgsqlCommand"";
++        public const string SqlCommandIntegrationName = nameof(IntegrationIds.AdoNet);
+
+         internal struct NpgsqlClientData : IAdoNetClientData
+         {",Was there a reason for changing all these integration names?   Are they actually used for anything besides information in logs?
+9207,"@@ -422,6 +422,10 @@ public class FieldInfos implements Iterable<FieldInfo> {
+       }
+     }
+
++    synchronized Set<String> getFieldNames() {
++      return Set.copyOf(nameToNumber.keySet());
++    }
++
+     synchronized void clear() {
+       numberToName.clear();
+       nameToNumber.clear();",we should not resurrect this method that we just removed
+9208,"@@ -837,7 +837,18 @@ class WebDriver(object):
+             del png
+         return True
+
+-    save_screenshot = get_screenshot_as_file
++    def save_screenshot(self, filename):
++        """"""
++        Gets the screenshot of the current window. Returns False if there is
++           any IOError, else returns True. Use full paths in your filename.
++
++        :Args:
++         - filename: The full path you wish to save your screenshot to.
++
++        :Usage:
++            driver.save_screenshot('/Screenshots/foo.png')
++        """"""
++        return self.get_screenshot_as_file(self, filename)
+
+     def get_screenshot_as_png(self):
+         """"""",This needs to be just return self.get_screenshot_as_file(filename)
+9209,"@@ -0,0 +1,6 @@
++function isNetworkError (xhr) {
++  if (!xhr) return
++  return (xhr.readyState !== 0 && xhr.readyState !== 4) || xhr.status === 0
++}
++
++module.exports = isNetworkError",Shouldn't this return false here?
+9210,"@@ -92,6 +92,9 @@ type Config struct {
+ 	// Path to a directory containing the container's root filesystem.
+ 	Rootfs string `json:""rootfs""`
+
++	// Umask is the umask to use inside of the container.
++	Umask *uint32 `json:""umask""`
++
+ 	// Readonlyfs will remount the container's rootfs as readonly where only externally mounted
+ 	// bind mounts are writtable.
+ 	Readonlyfs bool `json:""readonlyfs""`",Should have json tag
+9211,"@@ -180,7 +180,7 @@ static const char *const PORT_ERROR[PORT_ERROR_COUNT] = {
+ /*
+  * errors command configuration, set during parse_args()
+  */
+-static struct errors_config {
++STATIC struct errors_config {
+ 	bool clear;
+ 	int force_count;
+ 	enum verbs_index which;",Is this needed after all? Looks like the struct was re-defined inside the test file.
+9212,"@@ -67,4 +67,11 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files referenced by given metadata location.
++   */
++  default RemoveReachableFiles removeFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement removeFiles"");
++  }
+ }",I think the name of the method should match the name of the action: `removeReachableFiles`.
+9213,"@@ -106,6 +106,7 @@ echo ""
+     <ul>
+         <li><a href=\""manage_apps.php\"">Manage applications</a></li>
+         <li><a href=\""manage_app_versions.php\"">Manage application versions</a></li>
++        <li><a href=\""manage_consent_types.php\"">Manage Consent types</a></li>
+         <li> Manage jobs
+         <ul>
+             <li><a href=\""cancel_wu_form.php\"">Cancel jobs by ID</a>",can you make the C in Consent lower case to match the other ones in this list?
+9214,"@@ -16,6 +16,7 @@ import (
+ 	""sync""
+ 	""testing""
+
++	""github.com/iotexproject/iotex-core/action/protocol/poll""
+ 	""github.com/stretchr/testify/require""
+
+ 	""github.com/iotexproject/iotex-core/action""",fix the group
+9215,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.
+9216,"@@ -47,7 +47,7 @@ func BenchmarkServiceFetchBlocks(b *testing.B) {
+
+ 	// Create a network and block service
+ 	net := &httpTestPeerSource{}
+-	ls := rpcs.MakeBlockService(config.GetDefaultLocal(), remote, net, ""test genesisID"")
++	ls := rpcs.MakeBlockService(logging.Base(), config.GetDefaultLocal(), remote, net, ""test genesisID"")
+ 	nodeA := basicRPCNode{}
+ 	nodeA.RegisterHTTPHandler(rpcs.BlockServiceBlockPath, ls)
+ 	nodeA.start()",we have `logging.TestingLog()` that should be used for that purpose.
+9217,"@@ -2372,7 +2372,7 @@ int mg_url_decode(const char *src, int src_len, char *dst,
+ #define HEXTOI(x) (isdigit(x) ? x - '0' : x - 'W')
+
+   for (i = j = 0; i < src_len && j < dst_len - 1; i++, j++) {
+-    if (src[i] == '%' && i < src_len - 2 &&
++    if (i < src_len - 2 && src[i] == '%' &&
+         isxdigit(* (const unsigned char *) (src + i + 1)) &&
+         isxdigit(* (const unsigned char *) (src + i + 2))) {
+       a = tolower(* (const unsigned char *) (src + i + 1));",This is also a question of style. src[i] will always be valid because of check if 'for' statement
+9218,"@@ -398,7 +398,7 @@ func killKubeEdgeBinary(proc string) error {
+
+ //isKubeEdgeProcessRunning checks if the given process is running or not
+ func isKubeEdgeProcessRunning(proc string) (bool, error) {
+-	procRunning := fmt.Sprintf(""pidof %s 2&>1"", proc)
++	procRunning := fmt.Sprintf(""pidof %s 2>&1"", proc)
+ 	cmd := NewCommand(procRunning)
+
+ 	err := cmd.Exec()",Why change it?
+9219,"@@ -11,7 +11,7 @@ import {
+   textStyle,
+   colorStyle,
+   borders,
+-} from '../src'
++} from '../src/index'
+
+ const theme = {
+   colors: {",nb: this change is unnecessary
+9220,"@@ -120,6 +120,7 @@ type Object struct {
+ 	size        int64     // size of the object
+ 	modTime     time.Time // modification time of the object
+ 	id          string    // ID of the object
++	publicLink  string    // Public Link for the object
+ 	sha1        string    // SHA-1 of the object content
+ }
+ ",Is the publicLink mostly empty? I'm just wondering how much this will bloat memory usage as sometimes rclone has millions of Object~s in memory.
+9221,"@@ -65,6 +65,11 @@ type OrderSpec struct {
+ 	// validation process.
+ 	// This field must match the corresponding field on the DER encoded CSR.
+ 	DNSNames []string
++
++	// IPAddresses is a list of IP addresses that should be included as part of the Order
++	// validation process.
++	// This field must match the corresponding field on the DER encoded CSR.
++	IPAddresses []string `json:""ipAddresses,omitempty""`
+ }
+
+ type OrderStatus struct {","I don't think the Internal API types need the json annotations. They are never serialised, right?"
+9222,"@@ -45,6 +45,7 @@ type apiClient interface {
+ 	GetApplicationMostRecentDeployment(ctx context.Context, req *pipedservice.GetApplicationMostRecentDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.GetApplicationMostRecentDeploymentResponse, error)
+ 	CreateDeployment(ctx context.Context, in *pipedservice.CreateDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.CreateDeploymentResponse, error)
+ 	ReportApplicationMostRecentDeployment(ctx context.Context, req *pipedservice.ReportApplicationMostRecentDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.ReportApplicationMostRecentDeploymentResponse, error)
++	ReportDeploymentCompleted(ctx context.Context, req *pipedservice.ReportDeploymentCompletedRequest, opts ...grpc.CallOption) (*pipedservice.ReportDeploymentCompletedResponse, error)
+ }
+
+ type gitClient interface {",Maybe this was added incidentally. We don't need this function in the interface.
+9223,"@@ -18,8 +18,15 @@ func To(fs http.FileSystem, r *http.Request, to string, replacer httpserver.Repl
+
+ 	// try each rewrite paths
+ 	t := """"
++	query := """"
+ 	for _, v := range tos {
+-		t = path.Clean(replacer.Replace(v))
++		t = replacer.Replace(v)
++		tparts := strings.Split(t, ""?"")
++		t = path.Clean(tparts[0])
++
++		if len(tparts) > 1 {
++			query = tparts[1]
++		}
+
+ 		// add trailing slash for directories, if present
+ 		if strings.HasSuffix(v, ""/"") && !strings.HasSuffix(t, ""/"") {",Is this a safe/reliable way to split the URL?
+9224,"@@ -350,6 +350,7 @@ public class JdbcProjectLoader extends AbstractJdbcLoader implements
+   public void uploadProjectFile(Project project, int version, String filetype,
+       String filename, File localFile, String uploader)
+       throws ProjectManagerException {
++    long startMs = System.currentTimeMillis();
+     logger.info(""Uploading to "" + project.getName() + "" version:"" + version
+         + "" file:"" + filename);
+     Connection connection = getConnection();",do we also need to profile the time to getConnection()?
+9225,"@@ -34,6 +34,12 @@ def flow_to_json(flow: mitmproxy.flow.Flow) -> dict:
+         ""type"": flow.type,
+         ""modified"": flow.modified(),
+     }
++    # .alpn_proto_negotiated is bytes, we need to decode that.
++    for conn in ""client_conn"", ""server_conn"":
++        if f[conn][""alpn_proto_negotiated""] is None:
++            continue
++        f[conn][""alpn_proto_negotiated""] = \
++            f[conn][""alpn_proto_negotiated""].decode(errors=""backslashreplace"")
+     if flow.error:
+         f[""error""] = flow.error.get_state()
+ ",Should we move the decode part directly to the actual first-use of this? Or how does this affect if the value gets decoded and we need to get the bytes back later?
+9226,"@@ -78,6 +78,16 @@ $config = [
+                     ]
+                 ]
+             ],
++            'legacy-holds' => [
++                'type' => 'Laminas\Router\Http\Literal',
++                'options' => [
++                    'route'    => '/MyResearch/Holds',
++                    'defaults' => [
++                        'controller' => 'Holds',
++                        'action'     => 'List',
++                    ]
++                ]
++            ],
+             'legacy-summonrecord' => [
+                 'type' => 'Laminas\Router\Http\Literal',
+                 'options' => [","How would you feel about continuing to point this at the MyResearchController's holdsAction, but instead changing that action to force a redirect to the new holds-list route? That way, people will get sent to the new URL instead of having two different URLs that do the same thing."
+9227,"@@ -1196,6 +1196,14 @@ func (c *client) markConnAsClosed(reason ClosedState, skipFlush bool) bool {
+ 	if skipFlush {
+ 		c.flags.set(skipFlushOnClose)
+ 	}
++	// Be consistent with the creation: for routes and gateways,
++	// we use Noticef on create, so use that too for delete.
++	if c.kind == ROUTER || c.kind == GATEWAY {
++		c.Noticef(""%s connection closed: %v"", c.typeString(), reason.String())
++	} else { // Client and Leaf Node connections.
++		c.Debugf(""%s connection closed: %v"", c.typeString(), reason.String())
++	}
++
+ 	// Save off the connection if its a client or leafnode.
+ 	if c.kind == CLIENT || c.kind == LEAF {
+ 		if nc := c.nc; nc != nil && c.srv != nil {",I think if yo use %s then you do not need reason.String() and can just do reason.
+9228,"@@ -156,9 +156,9 @@ func WorkflowEndingRunID(endingRunID string) Tag {
+ 	return newStringTag(""wf-ending-run-id"", endingRunID)
+ }
+
+-// WorkflowDecisionTimeoutSeconds returns tag for WorkflowDecisionTimeoutSeconds
+-func WorkflowDecisionTimeoutSeconds(s int32) Tag {
+-	return newInt32(""wf-decision-timeout"", s)
++// WorkflowTaskTimeoutSeconds returns tag for WorkflowTaskTimeoutSeconds
++func WorkflowTaskTimeoutSeconds(s int32) Tag {
++	return newInt32(""wf-workflow-task-timeout"", s)
+ }
+
+ // QueryID returns tag for QueryID","Having ""wf"" prefix doesn't make sense anymore. Please remove."
+9229,"@@ -5,15 +5,15 @@ import {
+ 	teardown,
+ 	getMixedArray,
+ 	mixedArrayHTML,
+-	serializeHtml
++	serializeHtml,
++	sortAttributes,
++	spyAll
+ } from '../_util/helpers';
+ import { div, span, p } from '../_util/dom';
+
+ /** @jsx createElement */
+ const h = createElement;
+
+-let spyAll = obj => Object.keys(obj).forEach(key => sinon.spy(obj, key));
+-
+ function getAttributes(node) {
+ 	let attrs = {};
+ 	if (node.attributes) {",Removed this copy of the `spyAll` function and replaced it with the same function declared in `helpers.js`. Same for `sortAttributes` below
+9230,"@@ -90,9 +90,9 @@ public class KubernetesContainerizedImpl extends EventHandler implements Contain
+   public static final String DEFAULT_POD_NAME_PREFIX = ""fc-dep"";
+   public static final String DEFAULT_SERVICE_NAME_PREFIX = ""fc-svc"";
+   public static final String DEFAULT_CLUSTER_NAME = ""azkaban"";
+-  public static final String CPU_LIMIT = ""4"";
++  public static final String DEFAULT_MAX_CPU = ""0"";
++  public static final String DEFAULT_MAX_MEMORY = ""0Gi"";
+   public static final String DEFAULT_CPU_REQUEST = ""1"";
+-  public static final String MEMORY_LIMIT = ""64Gi"";
+   public static final String DEFAULT_MEMORY_REQUEST = ""2Gi"";
+   public static final String MAPPING = ""Mapping"";
+   public static final String SERVICE_API_VERSION_2 = ""ambassador/v2"";",Default max cpu should be 8 and memory 64GB
+9231,"@@ -156,6 +156,11 @@ class _MissingPandasLikeSeries(object):
+     real = unsupported_property(
+         'real',
+         reason=""If you want to collect your data as an NumPy array, use 'to_numpy()' instead."")
++    nbytes = unsupported_property(
++        'nbytes',
++        reason=""'nbytes' requires to compute whole dataset. You can calculate manually it, ""
++               ""with its 'itemsize', by explicitly executing its count. Use Spark's web UI ""
++               ""to monitor disk and memory usage of your application in general."")
+
+     # Functions we won't support.
+     memory_usage = common.memory_usage(unsupported_function)","@itholic, can you remove `nbytes = unsupported_property('nbytes')` at `_MissingPandasLikeSeries`?"
+9232,"@@ -101,9 +101,8 @@ func TestEnvironmentConfig(t *testing.T) {
+ 	assert.True(t, conf.TaskIAMRoleEnabled, ""Wrong value for TaskIAMRoleEnabled"")
+ 	assert.True(t, conf.TaskIAMRoleEnabledForNetworkHost, ""Wrong value for TaskIAMRoleEnabledForNetworkHost"")
+ 	assert.True(t, conf.ImageCleanupDisabled, ""Wrong value for ImageCleanupDisabled"")
+-	assert.True(t, conf.TaskCPUMemLimit, ""Wrong value for TaskCPUMemLimit"")
+-	assert.True(t, conf.TaskENIEnabled, ""Wrong value for TaskNetwork"")
+
++	assert.True(t, conf.TaskENIEnabled, ""Wrong value for TaskNetwork"")
+ 	assert.Equal(t, (30 * time.Minute), conf.MinimumImageDeletionAge)
+ 	assert.Equal(t, (2 * time.Hour), conf.ImageCleanupInterval)
+ 	assert.Equal(t, 2, conf.NumImagesToDeletePerCycle)",What happened to the assertion on `conf.TaskCPUMemLimit`?
+9233,"@@ -5,10 +5,13 @@ import { render } from './render';
+ import { rerender } from './render-queue';
+ import options from './options';
+
++const createRef = Object;
++
+ export default {
+ 	h,
+ 	createElement,
+ 	cloneElement,
++	createRef,
+ 	Component,
+ 	render,
+ 	rerender,",Just curious: Is using `Object` faster than a literal `{}`?
+9234,"@@ -59,6 +59,14 @@ func ValidateCertificateForACMEIssuer(crt *v1alpha1.CertificateSpec, issuer *v1a
+ 		el = append(el, field.Invalid(specPath.Child(""organization""), crt.Organization, ""ACME does not support setting the organization name""))
+ 	}
+
++	if crt.Duration.Duration != 0 {
++		el = append(el, field.Invalid(specPath.Child(""duration""), crt.Duration, ""ACME does not support certificate durations""))
++	}
++
++	if crt.RenewBefore.Duration != 0 {
++		el = append(el, field.Invalid(specPath.Child(""renewBefore""), crt.RenewBefore, ""ACME does not support certificate renewal times""))
++	}
++
+ 	return el
+ }
+ ","How come we don't allow this to be configured with the ACME issuer? Happy to leave this as-is for now if there's a lot more consideration that needs to be made, but it seems like we could/should be able to allow this?"
+9235,"@@ -208,7 +208,6 @@ type HTTPHealthCheckOpts struct {
+
+ // NetworkLoadBalancerListener holds configuration that's need for a Network Load Balancer listener.
+ type NetworkLoadBalancerListener struct {
+-	Port            string
+ 	Protocol        string
+ 	TargetContainer string
+ 	TargetPort      string",Should we remove the `Aliases` field as well?
+9236,"@@ -88,6 +88,8 @@ public class VoiceSearchWidget extends UIWidget implements WidgetManagerDelegate
+
+         mMozillaSpeechService = MozillaSpeechService.getInstance();
+         mMozillaSpeechService.setProductTag(""fxr"");
++        mMozillaSpeechService.storeSamples(false);
++        mMozillaSpeechService.storeTranscriptions(false);
+
+         mVoiceSearchText1 = findViewById(R.id.voiceSearchText1);
+         mVoiceSearchText2 = findViewById(R.id.voiceSearchText2);",what's the effect of turning these two off? is there an issue on file for context?
+9237,"@@ -35,9 +35,10 @@ type CLITestType string
+
+ // List all test types here
+ const (
+-	Wrapper                   CLITestType = ""1 wrapper""
+-	GcloudProdWrapperLatest   CLITestType = ""2 gcloud-prod wrapper-latest""
+-	GcloudLatestWrapperLatest CLITestType = ""3 gcloud-latest wrapper-latest""
++	Wrapper                       CLITestType = ""1 wrapper""
++	GcloudBetaProdWrapperLatest   CLITestType = ""2 gcloud-beta-prod wrapper-latest""
++	GcloudBetaLatestWrapperLatest CLITestType = ""3 gcloud-beta-latest wrapper-latest""
++	GcloudGaLatestWrapperRelease  CLITestType = ""4 gcloud-ga-latest wrapper-release""
+ )
+
+ var (","The format like gcloud-beta-prod is a bit hard to understand. Maybe find a a more clear way to describe it,"
+9238,"@@ -20,7 +20,7 @@ namespace OpenTelemetry.Tags
+     /// <summary>
+     /// Collection of tags representing the tags context.
+     /// </summary>
+-    public interface ITagContext : IEnumerable<Tag>
++    public interface ITagContext : IEnumerable<DistributedContextEntry>
+     {
+     }
+ }",Are we renaming this too in a follow up PR?
+9239,"@@ -179,7 +179,8 @@ class Preference extends Model
+     public function getLocaleOptions()
+     {
+         $localeOptions = [
+-            'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++		    'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
+             'cs' => [Lang::get('system::lang.locale.cs'), 'flag-cz'],
+             'da' => [Lang::get('system::lang.locale.da'), 'flag-dk'],
+             'en' => [Lang::get('system::lang.locale.en'), 'flag-us'],",The indentation on this is off by one space to the left
+9240,"@@ -52,7 +52,9 @@ static VkImageSubresourceRange RangeFromLayers(const VkImageSubresourceLayers &s
+ static VkImageSubresourceRange MakeImageFullRange(const VkImageCreateInfo &create_info) {
+     const auto format = create_info.format;
+     VkImageSubresourceRange init_range{0, 0, VK_REMAINING_MIP_LEVELS, 0, VK_REMAINING_ARRAY_LAYERS};
+-    if (FormatIsColor(format) || FormatIsMultiplane(format)) {
++    const VkExternalFormatANDROID *pExternalFormatANDROID = lvl_find_in_chain<VkExternalFormatANDROID>(&create_info);
++    bool isExternalFormatConversion = (pExternalFormatANDROID != nullptr && pExternalFormatANDROID->externalFormat != 0);
++    if (FormatIsColor(format) || FormatIsMultiplane(format) || isExternalFormatConversion) {
+         init_range.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;  // Normalization will expand this for multiplane
+     } else {
+         init_range.aspectMask =","I guess nothing is wrong with this approach, but more curious if you didn't just go `|| (format != VK_FORMAT_UNDEFINED)) {` As if there ever was another external format system added in Vulkan it would need to be manually added here"
+9241,"@@ -22,7 +22,8 @@
+ package com.github.javaparser.resolution.types;
+
+ import java.util.*;
+-import java.util.stream.Collectors;
++
++import static java.util.stream.Collectors.joining;
+
+ /**
+  * A union type is defined in java as list of types separates by pipes.",Is order really irrelevant here?
+9242,"@@ -15,11 +15,14 @@ import android.net.Uri;
+ import android.provider.MediaStore;
+ import android.speech.RecognizerIntent;
+ import android.support.annotation.NonNull;
++import android.support.design.widget.Snackbar;
+ import android.util.Base64;
+ import android.view.View;
+ import android.webkit.MimeTypeMap;
++import android.widget.Toast;
+
+ import org.fossasia.phimpme.R;
++import org.fossasia.phimpme.accounts.AccountActivity;
+ import org.fossasia.phimpme.data.local.AccountDatabase;
+
+ import java.io.ByteArrayOutputStream;",I think this import will be unused now. If it is unused remove it.
+9243,"@@ -37,6 +37,13 @@ type MutationItem struct {
+ 	value []byte
+ }
+
++func NewBatch(kv RwKV) StatelessRwTx {
++	return &mutation{
++		db:   NewObjectDatabase(kv),
++		puts: btree.New(32),
++	}
++}
++
+ func (mi *MutationItem) Less(than btree.Item) bool {
+ 	i := than.(*MutationItem)
+ 	c := strings.Compare(mi.table, i.table)",Let's change to tx
+9244,"@@ -55,6 +55,12 @@ const (
+ 	// By default, this will be the block type given to all blocks
+ 	// that aren't explicitly some other type.
+ 	defaultBlockTypeDefault = keybase1.BlockType_DATA
++
++	// By default, allow 10% of the free bytes on disk to be used in the disk block cache.
++	defaultDiskBlockCacheFraction = 0.10
++
++	// By default, allow 15% of the free bytes on disk to be used in the sync block cache.
++	defaultSyncBlockCacheFraction = 0.10
+ )
+
+ // ConfigLocal implements the Config interface using purely local","Looks like I was wrong about the sync cache size being 15% before. There seems to be some reporting bug related to my use of the sync cache, that makes the limit different from the working set cache limit. For now, I say we keep this at `0.10` (change the param default too), and we can change it later if needed."
+9245,"@@ -151,7 +151,7 @@ func sentryNotSetupWarning() {
+ // from the last saved version. If it is, prompt to request anon ddev usage stats
+ // and update the info.
+ func checkDdevVersionAndOptInSentry() error {
+-	if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false {
++	if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false && os.Getenv(""DDEV_NO_SENTRY"") == """" {
+ 		allowStats := util.Confirm(""It looks like you have a new ddev release.\nMay we send anonymous ddev usage statistics and errors?\nTo know what we will see please take a look at\nhttps://ddev.readthedocs.io/en/latest/users/cli-usage/#opt-in-usage-information\nPermission to beam up?"")
+ 		if allowStats {
+ 			globalconfig.DdevGlobalConfig.InstrumentationOptIn = true","I think it'd be a good idea to define the environment variable name as a constant in values.go because it's hard-coded in several places, but that's a small point."
+9246,"@@ -0,0 +1,6 @@
++class AddIndexesToClassifications < ActiveRecord::Migration
++  def change
++    add_index :classifications, :topic_id
++    add_index :classifications, [:classifiable_id, :classifiable_type]
++  end
++end",Style/SymbolArray: Use %i or %I for an array of symbols.
+9247,"@@ -133,6 +133,13 @@ func TestComposeCmd(t *testing.T) {
+ 	assert.Error(err)
+ }
+
++func TestCheckCompose(t *testing.T) {
++	assert := asrt.New(t)
++
++	err := CheckDockerCompose()
++	assert.NoError(err)
++}
++
+ func TestGetAppContainers(t *testing.T) {
+ 	assert := asrt.New(t)
+ 	sites, err := GetAppContainers(""dockertest"")","Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions."
+9248,"@@ -116,6 +116,10 @@ public abstract class AbstractOAuth2AuthenticationProvider implements Authentica
+         final OAuthRequest request = new OAuthRequest(Verb.GET, userEndpoint, service);
+         request.addHeader(""Authorization"", ""Bearer "" + accessToken.getAccessToken());
+         request.setCharset(""UTF-8"");
++
++        // Microsoft
++        request.addHeader(""Accept"", ""application/json"");
++
+
+         final Response response = request.send();
+         int responseCode = response.getCode();",I'm slightly concerned about this because doesn't ORCID use XML instead of JSON?
+9249,"@@ -17,7 +17,11 @@ def is_new_user_stats_batch():
+     So, we check the database and see if the difference between the last time stats were updated
+     and right now is greater than 12 hours.
+     """"""
+-    return datetime.now(timezone.utc) - db_stats.get_timestamp_for_last_user_stats_update() > timedelta(hours=TIME_TO_CONSIDER_STATS_AS_OLD)
++    last_update_ts = db_stats.get_timestamp_for_last_user_stats_update()
++    if(last_update_ts is None):
++        last_update_ts = datetime.min.replace(tzinfo=timezone.utc) # use min datetime value if last_update_ts is None
++
++    return datetime.now(timezone.utc) - last_update_ts > timedelta(hours=TIME_TO_CONSIDER_STATS_AS_OLD)
+
+
+ def notify_user_stats_update():",brackets around if conditions isn't really pythonic.
+9250,"@@ -396,9 +396,6 @@ func (h *Impl) Stop() {
+ 	h.namespaceCache.Stop()
+ 	h.membershipMonitor.Stop()
+ 	h.ringpopChannel.Close()
+-	if err := h.grpcListener.Close(); err != nil {
+-		h.logger.WithTags(tag.Error(err)).Error(""failed to close gRPC listener"")
+-	}
+ 	h.runtimeMetricsReporter.Stop()
+ 	h.persistenceBean.Close()
+ 	h.visibilityMgr.Close()","It turn out that when we close server it closed underlying listener itself, so this line always generated and error."
+9251,"@@ -38,13 +38,13 @@ function createObjects(user) {
+             error: err => console.log(err)
+         },
+         schema: [{
+-            name: 'Dog',
+-            primaryKey: '_id',
++            name: ""Dog"",
++            primaryKey: ""_id"",
+             properties: {
+-              _id: 'objectId?',
+-              breed: 'string?',
+-              name: 'string',
+-              realm_id: 'string?',
++              _id: ""objectId?"",
++              breed: ""string?"",
++              name: ""string"",
++              realm_id: ""string?"",
+             }
+         }]
+     };",Looks like this is for debugging? Maybe just remove.
+9252,"@@ -187,7 +187,10 @@ module Mongoid
+     #
+     # @since 1.0.0
+     def exists?
+-      context.count > 0
++      Mongoid.unit_of_work(disable: :current) do
++        # Don't use count here since Mongo does not use counted b-tree indexes
++        !context.dup.criteria.only(:_id).limit(1).entries.first.nil?
++      end
+     end
+
+     # Extract a single id from the provided criteria. Could be in an $and",Same here - this code is duplicated. I think we can just remove the `exists?` method completely from `Criteria` and it should delegate to the context.
+9253,"@@ -150,8 +150,14 @@ void SYCLInternal::initialize(const sycl::queue& q) {
+
+     m_maxShmemPerBlock =
+         d.template get_info<sycl::info::device::local_mem_size>();
+-    m_indirectKernelMem.reset(*m_queue, m_instance_id);
++
+     m_indirectReducerMem.reset(*m_queue, m_instance_id);
++    for (auto& usm_mem : m_indirectKernelMem) {
++      usm_mem.reset(*m_queue, m_instance_id);
++      // TODO 0x1440= 5184, arbitrary, larger than largest encountered kernel.
++      usm_mem.reserve(0x1440);
++    }
++
+   } else {
+     std::ostringstream msg;
+     msg << ""Kokkos::Experimental::SYCL::initialize(...) FAILED"";",I'm not quite sure that we preallocate memory. Do you have a good reason for that?
+9254,"@@ -731,6 +731,17 @@ func (s *Server) checkAuth(c *client) bool {
+ 	}
+ }
+
++// Check that number of clients is below Max connection setting.
++func (s *Server) checkMaxConn(c *client) bool {
++	if c.typ == CLIENT {
++		s.mu.Lock()
++		ok := len(s.clients) <= s.opts.MaxConn
++		s.mu.Unlock()
++		return ok
++	}
++	return true
++}
++
+ // Remove a client or route from our internal accounting.
+ func (s *Server) removeClient(c *client) {
+ 	var rID string","If we have added to s.clients, we could just do the following since if its a route will be ok I think. s.mu.Lock() defer s.mu.Unlock() return len(s.clients) <+ s.opts.MaxConn"
+9255,"@@ -53,7 +53,10 @@ void BalanceTask::invoke() {
+             LOG(INFO) << taskIdStr_ << ""Ask the src to give up the leadership."";
+             SAVE_STATE();
+             if (srcLived_) {
+-                client_->transLeader(spaceId_, partId_, src_).thenValue([this](auto&& resp) {
++                // For balance task of single replica, the target leader is src_ itself
++                HostAddr targetLeader = singleReplica_ ? src_ : kRandomPeer;
++                client_->transLeader(spaceId_, partId_, src_, targetLeader)
++                    .thenValue([this](auto&& resp) {
+                     if (!resp.ok()) {
+                         LOG(INFO) << taskIdStr_ << ""Transfer leader failed, status "" << resp;
+                         if (resp == nebula::Status::PartNotFound()) {","if the targetLeader is src_ itself, it is really need call transLeader function?"
+9256,"@@ -85,6 +85,7 @@ public class CSharpSurfaceNamer extends SurfaceNamer {
+
+   @Override
+   public String getAndSavePagedResponseTypeName(
++      Method method,
+       FeatureConfig featureConfig,
+       ModelTypeTable typeTable,
+       TypeRef inputType,",Can we remove this featureConfig since you removed in L98 (assuming it is not used else where)
+9257,"@@ -11,6 +11,7 @@ using Newtonsoft.Json;
+
+ using Xunit;
+ using System.Collections.Generic;
++using System.Linq;
+
+ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+ {",namespaces in this file need a sorting
+9258,"@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
+ 		c.VXLANMTU = hostMTU - vxlanMTUOverhead
+ 	}
+ 	if c.Wireguard.MTU == 0 {
+-		if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == ""WorkloadIPs"" {
++		if c.Wireguard.EncryptHostTraffic {
+ 			// The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes,
+ 			// see https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-tcpip-performance-tuning#azure-and-vm-mtu
+ 			// for details.",This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS.
+9259,"@@ -36,8 +36,14 @@ class FastTemporalMemory(TemporalMemory):
+   """"""
+
+   def __init__(self, *args, **kwargs):
++    maxSegmentsPerCell = kwargs.get(""maxSegmentsPerCell"") or 255
++    maxSynapsesPerSegment = kwargs.get(""maxSynapsesPerSegment"") or 255
++
+     super(FastTemporalMemory, self).__init__(*args, **kwargs)
+-    self.connections = Connections(self.numberOfCells())
++    self.connections = Connections(
++      self.numberOfCells(),
++      maxSegmentsPerCell=maxSegmentsPerCell,
++      maxSynapsesPerSegment=maxSynapsesPerSegment)
+
+
+   def burstColumns(self,",`get` has an optional second parameter that is the default if the key isn't found.
+9260,"@@ -63,6 +63,7 @@ if (LDAP_HOST && $ldap_auth) {
+     if (!$passwd_hash) {
+         echo ""<account_out>\n"";
+         echo ""   <success/>\n"";
++        echo ""<id>$user->id</id>\n"";
+         echo ""</account_out>\n"";
+         exit();
+     }",Please also indent the new response line as was done to the existing line above.
+9261,"@@ -3403,6 +3403,13 @@ void Client::Handle_OP_AutoFire(const EQApplicationPacket *app)
+ 		DumpPacket(app);
+ 		return;
+ 	}
++
++	if (this->GetTarget() == this) {
++		this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++		auto_fire = false;
++		return;
++	}
++
+ 	bool *af = (bool*)app->pBuffer;
+ 	auto_fire = *af;
+ 	auto_attack = false;",Shouldn't need this-> here.
+9262,"@@ -2717,7 +2717,7 @@ bool Game::internalStartTrade(Player* player, Player* tradePartner, Item* tradeI
+ 	player->sendTradeItemRequest(player->getName(), tradeItem, true);
+
+ 	if (tradePartner->tradeState == TRADE_NONE) {
+-		tradePartner->sendTextMessage(MESSAGE_EVENT_ADVANCE, fmt::format(""{:s} wants to trade with you."", player->getName()));
++		tradePartner->sendTextMessage(MESSAGE_TRADE, fmt::format(""{:s} wants to trade with you."", player->getName()));
+ 		tradePartner->tradeState = TRADE_ACKNOWLEDGE;
+ 		tradePartner->tradePartner = player;
+ 	} else {","I believe this is incorrect, if I'm not wrong, MESSAGE_TRADE should be used when buying/selling items from NPC's"
+9263,"@@ -728,6 +728,8 @@ namespace pwiz.Skyline
+                     return _listGraphPeakArea.FirstOrDefault(g => g.Type == type) ?? CreateGraphPeakArea(type);
+                 else if (split[1] == typeof(MassErrorGraphController).Name)
+                     return _listGraphMassError.FirstOrDefault(g => g.Type == type) ?? CreateGraphMassError(type);
++                else if (split[1] == typeof(DetectionsGraphController).Name)
++                    return _listGraphDetections.FirstOrDefault(g => g.Type == type) ?? CreateGraphDetections(type);
+                 else
+                     return null;
+             }","Better if you give split[0], split[1], and split[2] descriptive names than using them this much through so many lines of code."
+9264,"@@ -41,8 +41,6 @@ export const getSetupIncompleteComponent = ( module, inGrid = false, fullWidth =
+ 	return ctaWrapper( cta, inGrid, fullWidth, createGrid );
+ };
+
+-export default getSetupIncompleteComponent;
+-
+ /**
+  * Creates a CTA component when module needs to be activated. Different wrapper HTML is needed depending on where the CTA gets output, which is determined by the inGrid, fullWidth, and createGrid parameters.
+  *",I know we're deleting this soon but I thought I'd fix it anyway :smile:
+9265,"@@ -58,9 +58,9 @@ public final class Slf4jConstantLogMessage extends BugChecker implements MethodI
+
+         List<? extends ExpressionTree> args = tree.getArguments();
+         ExpressionTree messageArg = ASTHelpers.isCastable(
+-                ASTHelpers.getType(tree.getArguments().get(0)),
+-                state.getTypeFromString(""org.slf4j.Marker""),
+-                state)
++                        ASTHelpers.getType(tree.getArguments().get(0)),
++                        state.getTypeFromString(""org.slf4j.Marker""),
++                        state)
+                 ? args.get(1)
+                 : args.get(0);
+ ","I like this, makes it clearer what scope the continuation is in"
+9266,"@@ -367,12 +367,12 @@ describe('MergeCells', () => {
+       keyDownUp('tab');
+       keyDownUp('enter');
+
+-      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('top-left-corner!');
++      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('A1');
+
+       keyDownUp('tab');
+       keyDownUp('enter');
+
+-      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('top-left-corner!');
++      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('B1');
+     });
+
+     it('should select the cell in the top-left corner of the merged cell, when navigating down using the SHIFT + ENTER key on the' +",These test checks if the value of the merged cells is correct. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire mergeCells.e2e.js file.
+9267,"@@ -598,3 +598,14 @@ func encodeAccounts(s *changeset.ChangeSet) ([]byte, error) {
+ }
+
+ // ---- Copy-Paste of code to decode ChangeSets: End -----
++
++var clearHashedChangesets = Migration{
++	Name: ""clear_hashed_changesets"",
++	Up: func(db ethdb.Database, tmpdir string, progress []byte, OnLoadCommit etl.LoadCommitHandler) error {
++		if err := db.(ethdb.BucketsMigrator).ClearBuckets(dbutils.AccountChangeSetBucket, dbutils.StorageChangeSetBucket); err != nil {
++			return err
++		}
++
++		return OnLoadCommit(db, nil, true)
++	},
++}","Don't need to clear them - because nobody have data there, also can don't delete buckets - just leave them, new nodes will not have them if remove bucket from buckets.go"
+9268,"@@ -0,0 +1,17 @@
++/* Copyright 2016 Google Inc
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *      http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package com.google.api.codegen.viewmodel;
++
++public interface ApiMethodView {}","Similarly, this has only one implementing class"
+9269,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?
+9270,"@@ -268,7 +268,7 @@ class StubsGenerator
+     /**
+      * @return PhpParser\Node\Identifier|PhpParser\Node\Name|PhpParser\Node\NullableType|null
+      */
+-    public static function getParserTypeFromPsalmType(Type\Union $type)
++    public static function getParserTypeFromPsalmType(Type\Union $type): ?PhpParser\NodeAbstract
+     {
+         $nullable = $type->isNullable();
+ ",I must have forgotten that one in previous PR
+9271,"@@ -1,10 +1,8 @@
+ require ""test_helper""
+
+ class DiaryCommentTest < ActiveSupport::TestCase
+-  api_fixtures
+-  fixtures :diary_comments
+-
+   def test_diary_comment_count
+-    assert_equal 4, DiaryComment.count
++    comment = create(:diary_comment)
++    assert_includes DiaryComment.all, comment
+   end
+ end",This test name doesn't really reflect what the test does any more... Then again I'm not really sure what it is testing now - is it actually just testing that FactoryGirl can create records? or does that itself funnel through the rails code so that we're testing rails can create records?
+9272,"@@ -1423,8 +1423,12 @@ func (m *executor) putCStorVolumeReplica() (err error) {
+
+ // putUpgradeResult will put an upgrade result as defined in the task
+ func (m *executor) putUpgradeResult() (err error) {
++	raw, err := template.AsTemplatedBytes(""UpgradeResult"", m.Runtask.Spec.Task, m.Values)
++	if err != nil {
++		return
++	}
+ 	uresult, err := upgraderesult.
+-		BuilderForRuntask(""UpgradeResult"", m.Runtask.Spec.Task, m.Values).
++		BuilderForTemplateObject(raw).
+ 		Build()
+ 	if err != nil {
+ 		return",Can this be `BuilderForYAMLObject`
+9273,"@@ -42,12 +42,14 @@ cpp_test = pytest.mark.skipif(not hasattr(core, ""test_coverage""),
+ #-------------------------------------------------------------------------------
+
+ def test_multiprocessing_threadpool():
++    import atexit
+     # Verify that threads work properly after forking (#1758)
+     import multiprocessing as mp
+     from datatable.internal import get_thread_ids
+     parent_threads = get_thread_ids()
+     n = 4
+     pool = mp.Pool(processes=n)
++    atexit.register(pool.close)
+     child_threads = pool.starmap(get_thread_ids, [()] * n, chunksize=1)
+     assert len(child_threads) == n
+     for chthreads in child_threads:",better use `with mp.Pool(...) as pool:` here
+9274,"@@ -48,8 +48,12 @@ public class Pids extends AbstractApiBean {
+         String baseUrl = systemConfig.getDataCiteRestApiUrlString();
+         String username = System.getProperty(""doi.username"");
+         String password = System.getProperty(""doi.password"");
+-        JsonObjectBuilder result = PidUtil.queryDoi(persistentId, baseUrl, username, password);
+-        return ok(result);
++        try {
++            JsonObjectBuilder result = PidUtil.queryDoi(persistentId, baseUrl, username, password);
++            return ok(result);
++        } catch (Exception ex) {
++            return error(Response.Status.BAD_REQUEST, ex.getLocalizedMessage());
++        }
+     }
+
+     @GET","Since this is a config problem, BAD_REQUEST is probably not the right response."
+9275,"@@ -479,6 +479,11 @@ func (o *Options) ProcessConfigFile(configFile string) error {
+ 				errors = append(errors, err)
+ 				continue
+ 			}
++			if dur < 30*time.Second {
++				err := &configErr{tk, fmt.Sprintf(""invalid lame_duck_duration of %v, minimum is 30 seconds"", dur)}
++				errors = append(errors, err)
++				continue
++			}
+ 			o.LameDuckDuration = dur
+ 		case ""trusted"":
+ 			switch v.(type) {","We could probably do 1 sec if we have time, and hence exit early if we have small number of clients. So LB = 60 sec. Grace = 10secs. So 50Sec window, if NumClients < 50, Close 1 every second. Then exit when NumClients == 0."
+9276,"@@ -75,7 +75,7 @@ def combine_frames(this, *args, how=""full""):
+         # If the same named index is found, that's used.
+         for this_column, this_name in this_index_map:
+             for that_col, that_name in that_index_map:
+-                if this_name == that_name:
++                if (this_column == that_col) and (this_name == that_name):
+                     # We should merge the Spark columns into one
+                     # to mimic pandas' behavior.
+                     this_scol = this._internal.scol_for(this_column)",can you rename `that_col` to `that_column`?
+9277,"@@ -19,7 +19,9 @@
+ /**
+  * Internal dependencies
+  */
+-import Widgets from './googlesitekit/widgets';
++import { Widget } from './googlesitekit/widgets';
++
++const Widgets = { componenets: Widget };
+
+ if ( typeof global.googlesitekit === 'undefined' ) {
+ 	global.googlesitekit = {};","This is not correct, it will override everything else that is currently in `Widgets`. This file shouldn't be modified at all, we should be adding `components.Widget` in `assets/js/googlesitekit/widgets/index.js`, where the rest of that object is defined. Oh, and there's a typo here :)"
+9278,"@@ -152,6 +152,14 @@ void BalanceTask::invoke() {
+                 if (!resp.ok()) {
+                     LOG(INFO) << taskIdStr_ << ""Update meta failed, status "" << resp;
+                     ret_ = Result::FAILED;
++                } else if (kv_ != nullptr) {
++                    if (LastUpdateTimeMan::update(kv_, time::WallClock::fastNowInMilliSec()) !=
++                            kvstore::ResultCode::SUCCEEDED) {
++                        LOG(INFO) << taskIdStr_ << ""Update meta failed"";
++                        ret_ = Result::FAILED;
++                    } else {
++                        status_ = Status::REMOVE_PART_ON_SRC;
++                    }
+                 } else {
+                     status_ = Status::REMOVE_PART_ON_SRC;
+                 }",Each task finished will result in the meta info updated?
+9279,"@@ -88,7 +88,7 @@ class PageSpeedInsightsSetup extends Component {
+
+ 	handleAPIKeyChange( e ) {
+ 		this.setState( {
+-			apikey: e.currentTarget.value,
++			apikey: e.currentTarget.value.replace( /\s/g, '' ),
+ 			disabled: 0 === e.currentTarget.value.length,
+ 		} );
+ 	}","Quick follow-up @aaemnnosttv, why this and not `.trim()`?"
+9280,"@@ -1,3 +1,4 @@
++/* eslint-disable sitekit/camelcase-acronyms */
+ /**
+  * Profile Select component tests.
+  *","I don't think we should have file-wide exceptions for this rule, let's annotate the individual instances."
+9281,"@@ -101,6 +101,8 @@ public class MailServiceBean implements java.io.Serializable {
+     private Session session;
+
+     public boolean sendSystemEmail(String to, String subject, String messageText) {
++        if (true) return true;
++
+         boolean sent = false;
+         String body = messageText + ResourceBundle.getBundle(""Bundle"").getString(""notification.email.closing"");
+         logger.fine(""Sending email to "" + to + "". Subject: <<<"" + subject + "">>>. Body: "" + body);","@raprasad you plan to take this ""if true"" out, right?"
+9282,"@@ -496,11 +496,13 @@ class ConsoleMaster(flow.FlowMaster):
+         self.eventlog = not self.eventlog
+         self.view_flowlist()
+
+-    def _readflow(self, path):
+-        path = os.path.expanduser(path)
++    def _readflow(self, paths):
+         try:
+-            f = file(path, ""rb"")
+-            flows = list(flow.FlowReader(f).stream())
++            flows = []
++            for path in paths:
++                path = os.path.expanduser(path)
++                f = file(path, ""rb"")
++                flows.extend(list(flow.FlowReader(f).stream()))
+         except (IOError, flow.FlowReadError), v:
+             return True, v.strerror
+         return False, flows","Could you adjust this to `with open(path, ""rb""):` here and below? We should make sure that we close all files."
+9283,"@@ -7,6 +7,8 @@ package libkbfs
+ import (
+ 	""testing""
+
++	""golang.org/x/net/context""
++
+ 	""github.com/keybase/kbfs/kbfshash""
+ 	""github.com/keybase/kbfs/tlf""
+ )",Does this need its own import block or can it be combined with the imports below as in most other files?
+9284,"@@ -34,6 +34,12 @@ _registered_options = {
+     # For example, this value determines whether the repr() for a dataframe prints out fully or
+     # just a truncated repr.
+     ""display.max_rows"": 1000,  # TODO: None should support unlimited.
++
++    # This determines whether or not to operate between two different dataframs.
++    # For example, 'combine_frames' function internally performs a join operation which can be
++    # expensive in general.
++    # So, if `compute.ops_on_diff_frames` variable is not True, that method throws an exception.
++    ""compute.ops_on_diff_frames"": True,
+ }  # type: Dict[str, Any]
+
+ ",It defaults to `false`.
+9285,"@@ -7,8 +7,12 @@ type corsHandler struct {
+ }
+
+ func (wrapper corsHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
+-	resp.Header().Set(""Access-Control-Allow-Origin"", ""*"")
+-	resp.Header().Set(""Access-Control-Allow-Methods"", ""POST, GET, OPTIONS, PUT, DELETE"")
++	if isPreflightCorsRequest(req) {
++		applyPreflightCorsResponse(resp)
++		return
++	}
++
++	allowAllCorsActions(resp)
+ 	wrapper.originalHandler.ServeHTTP(resp, req)
+ }
+ ","Why conditional check is done? As i understand, later both `applyPreflightCorsResponse()` and `allowAllCorsActions()` does the same"
+9286,"@@ -142,6 +142,9 @@ func (mh *MessageHandle) OnRegister(connection conn.Connection) {
+
+ 	if _, ok := mh.KeepaliveChannel[nodeID]; !ok {
+ 		mh.KeepaliveChannel[nodeID] = make(chan struct{}, 1)
++	} else {
++		klog.Warningf(""Node %v/%v has not yet exit, OnRegister failed"", projectID, nodeID)
++		return
+ 	}
+
+ 	io := &hubio.JSONIO{Connection: connection}",has not yet exit?
+9287,"@@ -247,6 +247,11 @@ _rt_hemuother_per_user_known = {
+
+ class RadioTap(Packet):
+     name = ""RadioTap dummy""
++    deprecated_fields = {
++        ""Channel"": ""ChannelFrequency"",  # 2.4.3
++        ""ChannelFlags2"": ""ChannelPlusFlags"",  # 2.4.3
++        ""ChannelNumber"": ""ChannelPlusNumber""  # 2.4.3
++    }
+     fields_desc = [
+         ByteField('version', 0),
+         ByteField('pad', 0),",I wonder if the version should be part of the deprecation API. It might ease our future selves while debugging issues =)
+9288,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.
+9289,"@@ -183,10 +183,11 @@ namespace Microsoft.Sarif.Viewer
+                 HelpLink = rule?.HelpUri?.ToString()
+             };
+
+-            IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotationsFromStacks(result.Stacks);
++            IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotatedCodeLocationsFromStacks(result.Stacks);
++            IEnumerable<IEnumerable<AnnotatedCodeLocation>> codeFlowLocations = CreateAnnotatedCodeLocationsFromCodeFlows(result.CodeFlows);
+
+             CreateAnnotatedCodeLocationCollections(stackLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+-            CreateAnnotatedCodeLocationCollections(result.CodeFlows, AnnotatedCodeLocationKind.CodeFlow, sarifError);
++            CreateAnnotatedCodeLocationCollections(codeFlowLocations, AnnotatedCodeLocationKind.CodeFlow, sarifError);
+             CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+
+             if (region != null)",This is just a rename...
+9290,"@@ -33,7 +33,10 @@ func GetLengthLimitedID(fixedPrefix, suffix string, maxLength int) string {
+ 		// start with the character that we use to denote a shortened string, which could
+ 		// result in a clash.  Hash the value and truncate...
+ 		hasher := sha256.New()
+-		hasher.Write([]byte(suffix))
++		_, err := hasher.Write([]byte(suffix))
++		if err != nil {
++			return """"
++		}
+ 		hash := base64.RawURLEncoding.EncodeToString(hasher.Sum(nil))
+ 		charsLeftForHash := maxLength - 1 - prefixLen
+ 		return fixedPrefix + shortenedPrefix + hash[0:charsLeftForHash]","Should probably panic here. I think hashers are contracted not to return errors (and returning """" doesn't handle the error)"
+9291,"@@ -13,7 +13,7 @@ import (
+ // Address is the interface that defines methods to manage Filecoin addresses and wallets.
+ type Address interface {
+ 	Addrs() Addrs
+-	Import(ctx context.Context, f files.Directory) ([]address.Address, error)
++	Import(ctx context.Context, f files.File) ([]address.Address, error)
+ 	Export(ctx context.Context, addrs []address.Address) ([]*types.KeyInfo, error)
+ }
+ ",Aside: this is a confusing name for an interface that contains multiple addresses.
+9292,"@@ -47,10 +47,8 @@ module Bolt
+       state = node_result['state']
+       result = node_result['result']
+
+-      result_output = Bolt::Node::ResultOutput.new
+-      result_output.stdout << result.to_json
+       if state == 'finished'
+-        Bolt::Node::Success.new(result.to_json, result_output)
++        exit_code = 0
+       else
+         # Try to extract the exit_code from _error
+         begin",We expect to use Bolt::CommandResult for scripts as well?
+9293,"@@ -386,7 +386,9 @@ module RSpec
+         user_metadata = Metadata.build_hash_from(args)
+
+         @metadata = Metadata::ExampleGroupHash.create(
+-          superclass_metadata, user_metadata, description, *args, &example_group_block
++          superclass_metadata, user_metadata,
++          superclass.method(:next_runnable_index_for),
++          description, *args, &example_group_block
+         )
+
+         hooks.register_globals(self, RSpec.configuration.hooks)",same thing as above inre commas and args?
+9294,"@@ -224,6 +224,9 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""query/useCircuitBreakers"", false);
++    memoryCircuitBreakerThreshold = getInt(""query/memoryCircuitBreakerThreshold"", 100);
+
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ",Should we validate that this is between 0 and 100?
+9295,"@@ -332,7 +332,7 @@ func (c *cliApp) help() {
+
+ // quit stops cli and client commands and exits application
+ func (c *cliApp) quit() {
+-	stop := utils.SoftKiller(c.Kill)
++	stop := utils.HardKiller(c.Kill)
+ 	stop()
+ }
+ ",`HardKiller` doing `os.Exit()` without proper shutting down other dependencies. I think there should be a better approach for this.
+9296,"@@ -136,16 +136,12 @@ const struct wlr_gles2_pixel_format *get_gles2_format_from_gl(
+ 	return NULL;
+ }
+
+-const uint32_t *get_gles2_shm_formats(const struct wlr_gles2_renderer *renderer,
+-		size_t *len) {
+-	static uint32_t shm_formats[sizeof(formats) / sizeof(formats[0])];
+-	size_t j = 0;
++void init_gles2_data_ptr_formats(struct wlr_gles2_renderer *renderer) {
+ 	for (size_t i = 0; i < sizeof(formats) / sizeof(formats[0]); i++) {
+ 		if (!is_gles2_pixel_format_supported(renderer, &formats[i])) {
+ 			continue;
+ 		}
+-		shm_formats[j++] = formats[i].drm_format;
++		wlr_drm_format_set_add(&renderer->data_ptr_texture_formats,
++			formats[i].drm_format, DRM_FORMAT_MOD_LINEAR);
+ 	}
+-	*len = j;
+-	return shm_formats;
+ }",Why isnt the return value checked?
+9297,"@@ -28,12 +28,15 @@ package util
+
+ import (
+ 	""fmt""
+-	""k8s.io/apimachinery/pkg/util/json""
+ 	""strings""
++
++	""k8s.io/apimachinery/pkg/util/json""
+ )
+
+ // GetNestedField returns a nested field from the provided map
+ func GetNestedField(obj map[string]interface{}, fields ...string) interface{} {
++	fmt.Println(""obj"", obj)
++	fmt.Println(""fields"", fields)
+ 	var val interface{} = obj
+ 	for _, field := range fields {
+ 		if _, ok := val.(map[string]interface{}); !ok {",remove this debug
+9298,"@@ -286,10 +286,13 @@ auto data_type_layer<TensorDataType>::get_local_error_signals(int parent_index)
+ // Accessing matrices corresponding to parent/child layer
+ template <typename TensorDataType>
+ auto data_type_layer<TensorDataType>::get_activations(const Layer& child) const -> const BaseDistMat& {
+-  const int child_index = (std::find(m_child_layers.begin(),
+-                                     m_child_layers.end(),
+-                                     &child)
+-                           - m_child_layers.begin());
++  if(m_child_layers.empty()) {
++    LBANN_ERROR(""This layer has no children"");
++  }
++  const int child_index = std::distance(m_child_layers.begin(),
++                                        std::find(m_child_layers.begin(),
++                                                  m_child_layers.end(),
++                                                  &child));
+   if (child_index >= get_num_children()) {
+     std::stringstream err;
+     err << ""attempted to get activation tensor of ""","This should change to a call to `Layer::find_layer_index`, which should be renamed to `find_child_layer_index` and it should return a `size_t` (technically the `difference_type` for whatever iterators are going to be used)."
+9299,"@@ -114,7 +114,7 @@ class py2exe(build_exe.py2exe):
+
+ 	def build_manifest(self, target, template):
+ 		mfest, rid = build_exe.py2exe.build_manifest(self, target, template)
+-		if getattr(target, ""script"", None) == ""nvda.pyw"":
++		if getattr(target, ""script"", """").endswith("".pyw""):
+ 			# This is one of the main application executables.
+ 			mfest = mfest[:mfest.rindex(""</assembly>"")]
+ 			mfest += MAIN_MANIFEST_EXTRA + ""</assembly>""",what is this change about?
+9300,"@@ -161,8 +161,6 @@ class Testinfra(Verifier):
+             cmd=[""pytest"", *util.dict2args(options), *self._tests, *args],
+             cwd=self._config.scenario.directory,
+             env=self.env,
+-            stdout=LOG.out,
+-            stderr=LOG.error,
+         )
+         # print(self._testinfra_command.cmd)
+ ",Why did we leave the `stderr` param in this case while we removed it from other bake methods?
+9301,"@@ -30,6 +30,13 @@ func VerifyTrustDomainMemberID(td spiffeid.TrustDomain, id spiffeid.ID) error {
+ 	return nil
+ }
+
++func VerifySameTrustDomain(td spiffeid.TrustDomain, id spiffeid.ID) error {
++	if !id.MemberOf(td) {
++		return fmt.Errorf(""%q is not a member of trust domain %q"", id, td)
++	}
++	return nil
++}
++
+ func TrustDomainAgentIDFromProto(td spiffeid.TrustDomain, protoID *types.SPIFFEID) (spiffeid.ID, error) {
+ 	id, err := idFromProto(protoID)
+ 	if err != nil {",This seems to only be used by the server/ca package.... maybe this can live there instead of being lumped into these API implementation helpers?
+9302,"@@ -1035,6 +1035,15 @@ func TestProvisionContainerResourcesSetPausePIDInVolumeResources(t *testing.T) {
+ 		}, nil),
+ 		mockCNIClient.EXPECT().SetupNS(gomock.Any(), gomock.Any(), gomock.Any()).Return(nsResult, nil),
+ 	)
++	// These mock calls would be made only for Windows.
++	dockerClient.EXPECT().CreateContainerExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(
++		&types.IDResponse{ID: containerID}, nil).MinTimes(0).MaxTimes(1)
++	dockerClient.EXPECT().StartContainerExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).
++		MinTimes(0).MaxTimes(1)
++	dockerClient.EXPECT().InspectContainerExec(gomock.Any(), gomock.Any(), gomock.Any()).Return(&types.ContainerExecInspect{
++		ExitCode: 0,
++		Running:  false,
++	}, nil).MinTimes(0).MaxTimes(1)
+
+ 	require.Nil(t, taskEngine.(*DockerTaskEngine).provisionContainerResources(testTask, pauseContainer).Error)
+ 	assert.Equal(t, strconv.Itoa(containerPid), volRes.GetPauseContainerPID())","hmm.. this is Hacky, the test will succeed in Windows even if you remove the calls to these, right?"
+9303,"@@ -1,4 +1,9 @@
+-test_name 'Install beaker and checkout branch if necessary' do
++ruby_version, ruby_source = ENV['RUBY_VER'], ""job parameter""
++unless ruby_version
++  ruby_version = ""2.3.1""
++  ruby_source = ""default""
++end
++test_name 'Install and configure Ruby #{ruby_version} (from #{ruby_source}) on the SUT' do
+
+   step 'Download the beaker git repo' do
+    on default, 'git clone https://github.com/puppetlabs/beaker.git /opt/beaker/'",should this block be in the file `05_install_ruby.rb`?
+9304,"@@ -167,7 +167,9 @@ func withDisconnectedClient(t *testing.T, recorder *Recorder, f func(raw.Client)
+ 				Unary: http.NewOutbound(""http://localhost:65535""),
+ 			},
+ 		},
+-		Filter: recorder,
++		Filters: yarpc.Filters{
++			UnaryFilter: recorder,
++		},
+ 	})
+ 	require.NoError(t, clientDisp.Start())
+ 	defer clientDisp.Stop()","To match outbounds, let's just call this `Unary: recorder`, `Oneway: ...`."
+9305,"@@ -49,7 +49,7 @@ def stripControlChars(string):
+
+ def compactHash(string):
+   hash = md5()
+-  hash.update(string)
++  hash.update(string.encode('unicode_escape'))
+   return hash.hexdigest()
+
+ ",`string.encode('utf-8')` is more common but I guess this is mostly cosmetic :)
+9306,"@@ -23,6 +23,6 @@ func NewLoggingHandler(handler http.Handler) LoggingHandler {
+ }
+
+ func (lh LoggingHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+-	log.Info(""Handling http request"", ""method"", r.Method, ""from"", r.RemoteAddr, ""uri"", r.RequestURI)
++	log.Info(""Handling http request"", ""method"", r.Method, ""from"", r.RemoteAddr)
+ 	lh.h.ServeHTTP(w, r)
+ }","Consider logging `r.Url.Path`? Either way, ship it!"
+9307,"@@ -54,14 +54,16 @@ type Context struct {
+ // Group data are omitted because they are committed to in the
+ // transaction and its ID.
+ type Params struct {
+-	CurrSpecAddrs transactions.SpecialAddresses
+-	CurrProto     protocol.ConsensusVersion
++	CurrSpecAddrs  transactions.SpecialAddresses
++	CurrProto      protocol.ConsensusVersion
++	MinTealVersion uint64
+ }
+
+ // PrepareContexts prepares verification contexts for a transaction
+ // group.
+ func PrepareContexts(group []transactions.SignedTxn, contextHdr bookkeeping.BlockHeader) []Context {
+ 	ctxs := make([]Context, len(group))
++	minTealVersion := logic.ComputeMinTealVersion(group)
+ 	for i := range group {
+ 		spec := transactions.SpecialAddresses{
+ 			FeeSink:     contextHdr.FeeSink,",this probably should be done lazely only if logic/app call txn in the group. Or even done in LogicSigSanityCheck?
+9308,"@@ -1639,6 +1639,10 @@ func (e *mutableStateBuilder) addWorkflowExecutionStartedEventForContinueAsNew(
+ 		SearchAttributes:         attributes.SearchAttributes,
+ 	}
+
++	if attributes.GetInitiator() == enumspb.CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED {
++		attributes.Initiator = enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW
++	}
++
+ 	req := &historyservice.StartWorkflowExecutionRequest{
+ 		NamespaceId:              e.namespaceEntry.GetInfo().Id,
+ 		StartRequest:             createRequest,",Please move this to `common/enums/defaults.go`.
+9309,"@@ -2,6 +2,7 @@
+ import time
+ import json
+ import re
++import listenbrainz.db.user as db_user
+ from collections import defaultdict
+ from yattag import Doc
+ import yattag","In general, if you find unalphabetized imports, you should alphabetize them. Fine for now though."
+9310,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.
+9311,"@@ -49,7 +49,12 @@ namespace pwiz.Skyline.Model
+             SLens = explicitSLens;
+             ConeVoltage = explicitConeVoltage;
+             DeclusteringPotential = explicitDeclusteringPotential;
+-            CompensationVoltage = explicitCompensationVoltage;
++            if (explicitCompensationVoltage.HasValue &&
++                (explicitIonMobilityUnits != MsDataFileImpl.eIonMobilityUnits.compensation_V ||
++                 !Equals(explicitIonMobility, explicitCompensationVoltage)))
++            {
++                CompensationVoltage = explicitCompensationVoltage;
++            }
+         }
+
+         public ExplicitTransitionGroupValues(ExplicitTransitionGroupValues other)","Is this if statement here necessary? It looks like this is the same logic that is taken care of in the setter for the property ""CompensationVoltage""."
+9312,"@@ -68,6 +68,14 @@ def bulk_send(elastic, list_):
+         raise_on_exception=False
+     )
+
++def key_to_parts(key):
++    """"""make a string for fulltext indexing of file name""""""
++    base, ext = os.path.splitext(key)
++    key_parts = base.split(""/"")
++    key_parts.append(ext[1:])
++
++    return f""{key} {' '.join(key_parts)}""
++
+ class DocumentQueue:
+     """"""transient in-memory queue for documents to be indexed""""""
+     def __init__(self, context):",Eliminate this function; handled by mappings and analyzer
+9313,"@@ -249,7 +249,14 @@ class JSTree extends AbstractBase
+                     'recordID' => '__record_id__'
+                 ]
+             ];
+-            $cache[$route] = $this->router->fromRoute($route, $params, $options);
++            $routeName = $route;
++            $datasource = $this->getDataSource();
++            if ($route === 'collection') {
++                $routeName = $datasource->getCollectionRoute();
++            } elseif ($route === 'record') {
++                $routeName = $datasource->getRecordRoute();
++            }
++            $cache[$route] = $this->router->fromRoute($routeName, $params, $options);
+         }
+         return str_replace('__record_id__', urlencode($id), $cache[$route]);
+     }","I wonder if this new logic would actually fit better as a support method, both for readability and overriding... e.g. <pre> protected function getRouteNameFromDataSource($route) { if ($route === 'collection') { return $this->getDataSource()->getCollectionRoute(); } elseif ($route === 'record') { return $this->getDataSource()->getRecordRoute(); } return $route; } </pre> That's extremely nitpicky, and you can feel free to leave this as-is if you prefer... but that feels marginally better to me."
+9314,"@@ -35,13 +35,13 @@ public class BaseSuite {
+   public static ExternalResource testEnvironment = new ExternalResource() {
+     @Override
+     protected void before() {
+-      log.info(""Preparing test environment"");
++      log.finest(""Preparing test environment"");
+       GlobalTestEnvironment.get(SeleniumTestEnvironment.class);
+       System.setProperty(""webdriver.remote.shorten_log_messages"", ""true"");
+     }
+     @Override
+     protected void after() {
+-      log.info(""Cleaning test environment"");
++      log.finest(""Cleaning test environment"");
+       TestEnvironment environment = GlobalTestEnvironment.get();
+       if (environment != null) {
+         environment.stop();",This is in test code: understanding what we're doing is important in this context.
+9315,"@@ -16,7 +16,7 @@ import (
+ 	""github.com/tinygo-org/tinygo/ir""
+ 	""github.com/tinygo-org/tinygo/loader""
+ 	""golang.org/x/tools/go/ssa""
+-	""tinygo.org/x/go-llvm""
++	llvm ""tinygo.org/x/go-llvm""
+ )
+
+ func init() {","This change (and a few similar ones below) are not related to rpi3 support, and should be removed."
+9316,"@@ -382,7 +382,7 @@ class KoalasBoxPlot(BoxPlot):
+         showcaps=None,
+         showbox=None,
+         showfliers=None,
+-        **kwargs
++        **kwargs,
+     ):
+         # Missing arguments default to rcParams.
+         if whis is None:","Hmm, why did we come to need the `,` at the end?"
+9317,"@@ -13,7 +13,8 @@ module.exports = function selectPopulatedFields(query) {
+     var userProvidedFields = query._userProvidedFields || {};
+     if (query.selectedInclusively()) {
+       for (i = 0; i < paths.length; ++i) {
+-        if (!isPathInFields(userProvidedFields, paths[i])) {
++        var hasPath = query._fields[paths[i]];
++        if (!isPathInFields(userProvidedFields, paths[i]) && hasPath) {
+           query.select(paths[i]);
+         }
+       }","I'm suspicious of this. For one thing, `query._fields[paths[i]]` may be `0`, `false`, etc. so checking for falsy will catch both cases where both the field isn't in the projection and if the field is explicitly excluded from the projection. For another, I'm not so sure that #6546 is a bug. Let's discuss that more."
+9318,"@@ -32,6 +32,8 @@ type Parser struct {
+ 	interpreter *interpreter
+ 	// Stashed set of source code for builtin rules.
+ 	builtins map[string][]byte
++
++	statements []*Statement
+ }
+
+ // NewParser creates a new parser instance. One is normally sufficient for a process lifetime.",What is this? I'm a bit unclear why the parser would have a list of statements in it.
+9319,"@@ -29,6 +29,14 @@ var (
+ 			""name"",
+ 		}, nil,
+ 	)
++	descPrometheusEnforcedSampleLimit = prometheus.NewDesc(
++		""prometheus_operator_enforced_sample_limit"",
++		""Global limit on the number of scraped samples per scrape target."",
++		[]string{
++			""namespace"",
++			""name"",
++		}, nil,
++	)
+ )
+
+ type prometheusCollector struct {","I believe this is Prometheus name, wonder if this is descriptive enough of a label name? @nrchakradhar @simonpasquier wdyt?"
+9320,"@@ -213,6 +213,11 @@ type Config struct {
+ 	IpInIpMtu        int    `config:""int;1440;non-zero""`
+ 	IpInIpTunnelAddr net.IP `config:""ipv4;""`
+
++	// Knobs provided to explicitly control whether we add rules to drop encap traffic
++	// from workloads. We always add them unless explicitly disabled.
++	DropVXLANPacketsFromWorkloads bool `config:""bool;true""`
++	DropIPIPPacketsFromWorkloads  bool `config:""bool;true""`
++
+ 	AWSSrcDstCheck string `config:""oneof(DoNothing,Enable,Disable);DoNothing;non-zero""`
+
+ 	ReportingIntervalSecs time.Duration `config:""seconds;30""`",Are most of our other fields default-zero-value? Would `AllowVXLANPacketsFromWorkloads` be a better formulation of this? I think it would make it easier for golang users of the API (default value matches the type zero-value)
+9321,"@@ -35,7 +35,7 @@ namespace Nethermind.TxPool
+         void AddPeer(ITxPoolPeer peer);
+         void RemovePeer(PublicKey nodeId);
+         AddTxResult AddTransaction(Transaction tx, TxHandlingOptions handlingOptions);
+-        void RemoveTransaction(Keccak hash, long blockNumber);
++        void RemoveTransaction(Keccak hash, long blockNumber, bool removeSmallerNonces);
+         bool TryGetPendingTransaction(Keccak hash, out Transaction transaction);
+         UInt256 ReserveOwnTransactionNonce(Address address);
+         event EventHandler<TxEventArgs> NewDiscovered;","void RemoveTransactions(Address sander, long removeBelowThisNonce) and separate these two calls"
+9322,"@@ -4365,6 +4365,8 @@ func TestJetStreamSnapshotsAPI(t *testing.T) {
+ 	// Now connect through a cluster server and make sure we can get things to work this way as well.
+ 	nc2 := clientConnectToServer(t, ls)
+ 	defer nc2.Close()
++	// Wait a bit for interest to propagate.
++	time.Sleep(100 * time.Millisecond)
+
+ 	snapshot = snapshot[:0]
+ ","Not sure which interest you are looking for to propagate here, but keep in mind that we have helpers (maybe not in /test package?) to check/wait for interest on a literal on a server for a given account."
+9323,"@@ -140,6 +140,7 @@ func execProcess(context *cli.Context) (int, error) {
+ 		detach:          detach,
+ 		pidFile:         context.String(""pid-file""),
+ 		action:          CT_ACT_RUN,
++		init:            false,
+ 	}
+ 	return r.run(p)
+ }",nit: should not need this.
+9324,"@@ -89,6 +89,8 @@ public class Constants {
+   // The flow exec id for a flow trigger instance unable to trigger a flow yet
+   public static final int FAILED_EXEC_ID = -2;
+
++  // Name of the file which keeps project directory size
++  public static final String PROJECT_DIR_SIZE_FILE_NAME = ""___azkaban_project_dir_size_in_bytes___"";
+
+   public static class ConfigurationKeys {
+ ","Since this constant is an implementation detail rather than a user-facing API, is it better to define it in a place where it is used?"
+9325,"@@ -1007,6 +1007,8 @@ class ListParameter(Parameter):
+         :param str x: the value to parse.
+         :return: the parsed value.
+         """"""
++        if isinstance(x, list):
++            x = json.dumps(x)
+         return list(json.loads(x, object_pairs_hook=FrozenOrderedDict))
+
+     def serialize(self, x):",It would be nice if we have some docs explaining this. Core luigi should avoid having hard to understand code.
+9326,"@@ -43,6 +43,11 @@ public abstract class StemmerTestBase extends LuceneTestCase {
+
+   static void init(boolean ignoreCase, String affix, String... dictionaries)
+       throws IOException, ParseException {
++    stemmer = new Stemmer(loadDictionary(ignoreCase, affix, dictionaries));
++  }
++
++  static Dictionary loadDictionary(boolean ignoreCase, String affix, String... dictionaries)
++      throws IOException, ParseException {
+     if (dictionaries.length == 0) {
+       throw new IllegalArgumentException(""there must be at least one dictionary"");
+     }",extract a method to call from a test
+9327,"@@ -184,6 +184,8 @@ public class CoreContainer {
+   private volatile ExecutorService coreContainerWorkExecutor = ExecutorUtil.newMDCAwareCachedThreadPool(
+       new DefaultSolrThreadFactory(""coreContainerWorkExecutor""));
+
++  final private ExecutorService collectorExecutor;
++
+   private final OrderedExecutor replayUpdatesExecutor;
+
+   protected volatile LogWatcher logging = null;",nitpick: regular order is private than final.
+9328,"@@ -145,6 +145,11 @@ class DocstringParameterChecker(BaseChecker):
+             ""useless-type-doc"",
+             ""Please remove the ignored parameter type documentation."",
+         ),
++        ""W9021"": (
++            'Missing any documentation in ""%s""',
++            ""missing-any-param-doc"",
++            ""Please add parameter and/or type documentation."",
++        ),
+     }
+
+     options = (","We could add an old names here, the ideal would be to not force to disable missing-any-param when the old one was already disabled. But they are not really equivalent so maybe you were right to not add it."
+9329,"@@ -8,11 +8,13 @@
+                 public const string BenchF = ""BenchF"";
+                 public const string BenchI = ""BenchI"";
+             public const string Inlining = ""Inlining"";
+-            public const string SIMD = ""SIMD"";
+-            public const string Span = ""Span"";
+             public const string V8 = ""V8"";
+             public const string Perflab = ""Perflab"";
+
+         public const string CoreFX = ""CoreFX"";
++
++        public const string LINQ = ""LINQ"";
++        public const string SIMD = ""SIMD"";
++        public const string Span = ""Span"";
+     }
+ }",">public const string LINQ = ""LINQ""; [](start = 8, length = 34) Are there duplicated benchmarks here? #Closed"
+9330,"@@ -129,14 +129,16 @@ module Beaker
+         end
+       end
+
+-      def do_install hosts, version, path, pre_30, options = {}
++      def do_install hosts, options = {}
+         #convenience methods for installation
+         ########################################################
+-        def installer_cmd(host, version, installer)
++        def installer_cmd(host, options)
+           if host['platform'] =~ /windows/
++            version = options[:pe_ver_win] || host['pe_ver_win']
+             ""cd #{host['working_dir']} && msiexec.exe /qn /i puppet-enterprise-#{version}.msi""
+           else
+-            ""cd #{host['working_dir']}/#{host['dist']} && ./#{installer}""
++            version = options[:pe_ver] || host['pe_ver']
++            ""cd #{host['working_dir']}/#{host['dist']} && ./#{options[:installer]}""
+           end
+         end
+         def link_exists?(link)",Probably worth taking the opportunity to add yardocs to this method now. Esp. curious about what the options hash accepts.
+9331,"@@ -271,6 +271,12 @@ static void roots_cursor_press_button(struct roots_cursor *cursor,
+ 			break;
+ 		case WLR_BUTTON_PRESSED:
+ 			roots_seat_set_focus(seat, view);
++			if (surface && !view) {
++				struct wlr_layer_surface *layer = surface->role_data;
++				if (layer->current.keyboard_interactive) {
++					roots_seat_set_focus_layer(seat, layer);
++				}
++			}
+ 			break;
+ 		}
+ 	}","This is Very Meh . We want to get rid of `role_data`, and it's an internal field."
+9332,"@@ -97,6 +97,11 @@ class Database {
+ 		return this.tryCall('selectOne', sql, params);
+ 	}
+
++	async loadExtension(path) {
++		const result = await this.driver()['loadExtension'](path);
++		return result;
++	}
++
+ 	async selectAll(sql, params = null) {
+ 		return this.tryCall('selectAll', sql, params);
+ 	}",`await this.driver().loadExtension(path);` should work
+9333,"@@ -98,12 +98,12 @@ func TestAddDepRescan(t *testing.T) {
+ 	target1.AddDependency(buildLabel(""//package1:target4""))
+
+ 	// Fake test: calling this now should have no effect because rescan is not true.
+-	state.QueueTarget(buildLabel(""//package1:target1""), core.OriginalTarget, false, false)
++	state.QueueTarget(buildLabel(""//package1:target1""), core.OriginalTarget, false)
+ 	assertPendingParses(t, state)
+ 	assertPendingBuilds(t, state) // Note that the earlier call to assertPendingBuilds cleared it.
+
+ 	// Now running this should activate it
+-	rescanDeps(state, map[*core.BuildTarget]struct{}{target1: {}})
++	// rescanDeps(state, map[*core.BuildTarget]struct{}{target1: {}})
+ 	time.Sleep(time.Millisecond * 100)
+
+ 	assertPendingBuilds(t, state, ""//package1:target4"")",Is any of this needed anymore?
+9334,"@@ -26,6 +26,16 @@
+ #include ""ostree-repo-private.h""
+ #include ""otutil.h""
+
++/* See ostree-repo.c for a bit more info about these ABI checks */
++#if __SIZEOF_POINTER__ == 8 && __SIZEOF_LONG__ == 8 && __SIZEOF_INT__ == 4
++G_STATIC_ASSERT(sizeof(OstreeDiffDirsOptions) ==
++                sizeof(int) * 2 +
++                sizeof(gpointer) +
++                sizeof(int) * (7+6) +
++                sizeof(int) +  /* hole */
++                sizeof(gpointer) * 7);
++#endif
++
+ static gboolean
+ get_file_checksum (OstreeDiffFlags  flags,
+                    GFile *f,",Can you add a mention here and in `ostree-repo.c` that the holes were found with `pahole`?
+9335,"@@ -78,7 +78,17 @@ module Blacklight::SolrHelper
+   # Returns a two-element array (aka duple) with first the solr response object,
+   # and second an array of SolrDocuments representing the response.docs
+   def get_search_results(user_params = params || {}, extra_controller_params = {})
+-    solr_response = query_solr(user_params, extra_controller_params)
++    Deprecation.warn(self, ""get_search_results is deprecated and will be removed in blacklight-6.0. Use `search_results' instead"")
++    search_results(user_params, extra_controller_params, solr_search_params_logic)
++  end
++
++  # a solr query method
++  # @param [Hash,HashWithIndifferentAccess] user_params ({}) the user provided parameters (e.g. query, facets, sort, etc)
++  # @param [Hash,HashWithIndifferentAccess] extra_controller_params ({}) extra parameters to add to the search
++  # @param [List<Symbol] processor_chain a list of filter methods to run
++  # @return [Blacklight::SolrResponse] the solr response object
++  def search_results(user_params, extra_controller_params, solr_search_parms_logic)
++    solr_response = query_solr(user_params, extra_controller_params, solr_search_params_logic)
+
+     case
+     when (solr_response.grouped? && grouped_key_for_results)","While we're changing this, I wonder if we can do away with `extra_controller_params`.. Maybe a new type of `solr_search_params_logic` that appends the attributes?"
+9336,"@@ -564,6 +564,8 @@ module Beaker
+
+           yield self if block_given?
+
++        rescue Beaker::DSL::Assertions, Minitest::Assertion => early_assertion
++          fail_test(early_assertion)
+         rescue Exception => early_exception
+           original_exception = RuntimeError.new(""PuppetAcceptance::DSL::Helpers.with_puppet_running_on failed (check backtrace for location) because: #{early_exception}\n#{early_exception.backtrace.join(""\n"")}\n"")
+           raise(original_exception)","I believe that you only need to rescue Beaker::DSL::Assertions, as they include Minitest::Assertions."
+9337,"@@ -372,6 +372,7 @@ namespace OpenTelemetry.Trace
+         private void RunGetRequestedDataAlwaysOffSampler(Activity activity)
+         {
+             activity.IsAllDataRequested = false;
++            activity.ActivityTraceFlags &= ActivityTraceFlags.None;
+         }
+
+         private void RunGetRequestedDataOtherSampler(Activity activity)",Do we need `&=` or `=` is sufficient?
+9338,"@@ -161,8 +161,8 @@ $settings['trusted_host_patterns'] = ['.*'];
+ $settings['class_loader_auto_detect'] = FALSE;
+
+ // This specifies the default configuration sync directory.
+-if (empty($config_directories[CONFIG_SYNC_DIRECTORY])) {
+-  $config_directories[CONFIG_SYNC_DIRECTORY] = '{{ joinPath $config.SitePath $config.SyncDir }}';
++if (empty($settings['config_sync_directory'])) {
++  $settings['config_sync_directory'] = '{{ joinPath $config.SitePath $config.SyncDir }}';
+ }
+ `
+ )",Let's keep both of these here. It should work on most any version of Drupal 8 then true?
+9339,"@@ -699,7 +699,7 @@ namespace OpenTelemetry.Trace.Test
+         private void AssertApproxSameTimestamp(DateTime one, DateTime two)
+         {
+             var timeShift = Math.Abs((one - two).TotalMilliseconds);
+-            Assert.InRange(timeShift, double.Epsilon, 10);
++            Assert.InRange(timeShift, double.Epsilon, 20);
+         }
+     }
+ }",@lmolkova This ok? I'm getting random failures from the build checks that don't happen locally from a few non-deterministic time related comparisons.
+9340,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright ConsenSys AG.
++ * Copyright Hyperledger Besu Contributors.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
+  * the License. You may obtain a copy of the License at",Q: are we supposed to change this for files that already exist?
+9341,"@@ -477,7 +477,7 @@ def initialize_unbounded(obj, dimensions, key):
+     """"""
+     select = dict(zip([d.name for d in dimensions], key))
+     try:
+-        obj.select([DynamicMap], **select)
++        obj.select(selection_specs=[DynamicMap], **select)
+     except KeyError:
+         pass
+ ","I count only four times where `selection_specs` had to be specified as a keyword instead of by position! If that is how often it was used that positional argument in our own codebase, I am pretty certain users barely used it (if at all)."
+9342,"@@ -24,5 +24,10 @@ describe HashDiffDecorator do
+       output = HashDiffDecorator.html_for(['~', 'foo', '', 'bar'])
+       expect(output).to eq(""<code>foo</code> was changed from <code>[empty]</code> to <code>&quot;bar&quot;</code>"")
+     end
++
++    it ""renders numeric events"" do
++      output = HashDiffDecorator.html_for(['~', 'a_number', 456, 123])
++      expect(output).to eq(""<code>a_number</code> was changed from <code>456.00</code> to <code>123.00</code>"")
++    end
+   end
+ end",is this test for the case above? seems to cover a numeric rather than empty val?
+9343,"@@ -245,6 +245,9 @@ class FlowHandler(RequestHandler):
+                         request.port = int(v)
+                     elif k == ""headers"":
+                         request.headers.set_state(v)
++                    elif k == ""content"":
++                        print(v)
++                        response.content = str(v)
+                     else:
+                         print(""Warning: Unknown update {}.{}: {}"".format(a, k, v))
+ ","I like the general idea, but this will break: - JSON is not binary-safe, so anything binary will break this. - JSON is super slow for multiple-MB things - We want to have drag-and-drop upload - the easiest way to implement this is FormData upload, so we should have a multipart/formdata endpoint. Can we put to /flow/content?"
+9344,"@@ -121,6 +121,7 @@ bool    dr_preinjected = false;
+ static bool dynamo_exiting = false;
+ #endif
+ bool    dynamo_exited = false;
++bool    dynamo_exited_synched = false;
+ bool    dynamo_exited_and_cleaned = false;
+ #ifdef DEBUG
+ bool    dynamo_exited_log_and_stats = false;",_and_synched seems to be more consistent w/ exited_and_cleaned
+9345,"@@ -13,6 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
++#if NETCOREAPP3_1
+ using Moq;
+ using Newtonsoft.Json;
+ using OpenTelemetry.Trace;",nit: in case of whole file `ifdef` it may be helpful to have `_netcore31` suffix it in the name of the file as well.
+9346,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long
+9347,"@@ -10,7 +10,8 @@ class CartDecorator < Draper::Decorator
+   end
+
+   def approvals_by_status
+-    object.approvals.order(
++    # Override default scope
++    object.approvals.reorder(
+       # http://stackoverflow.com/a/6332081/358804
+       <<-SQL
+         CASE approvals.status",Had no idea that method existed!
+9348,"@@ -38,6 +38,7 @@ class TestTabWidget:
+         qtbot.addWidget(w)
+         monkeypatch.setattr(tabwidget.objects, 'backend',
+                             usertypes.Backend.QtWebKit)
++        monkeypatch.setattr(w.tabBar(), 'width', w.width)
+         return w
+
+     @pytest.fixture","I wonder if we shouldn't just do `w.show()` here, which causes Qt to correctly calculate the sizes."
+9349,"@@ -24,12 +24,14 @@ class SparkDataFrameS3StoragePlugin(TypeStoragePlugin):  # pylint: disable=no-in
+     @classmethod
+     def set_object(cls, object_store, obj, _context, _runtime_type, paths):
+         target_path = object_store.key_for_paths(paths)
+-        obj.write.parquet('s3a://' + target_path)
++        obj.write.parquet('s3a://' + object_store.bucket + '/' + target_path)
+         return target_path
+
+     @classmethod
+     def get_object(cls, object_store, context, _runtime_type, paths):
+-        return context.resources.spark.read.parquet('s3a://' + object_store.key_for_paths(paths))
++        return context.resources.spark.read.parquet(
++            's3a://' + object_store.bucket + '/' + object_store.key_for_paths(paths)
++        )
+
+
+ class SparkDataFrameFilesystemStoragePlugin(TypeStoragePlugin):  # pylint: disable=no-init",may be nice to have helper method to generate s3 paths rather than the minor code dup
+9350,"@@ -169,11 +169,15 @@ export default Controller.extend(ValidationEngine, {
+     _oauthSetup() {
+         let blogTitle = this.get('blogTitle');
+         let config = this.get('config');
++        let promises = [];
++
++        promises.pushObject(this.get('settings').fetch());
++        promises.pushObject(this.get('config').fetchPrivate());
+
+         this.get('hasValidated').addObjects(['blogTitle', 'session']);
+
+         return this.validate().then(() => {
+-            return this.get('settings').fetch()
++            return RSVP.all(promises)
+                 .then((settings) => {
+                     settings.set('title', blogTitle);
+ ","This isn't needed here, we still run `this._afterAuthentication` which loads settings & config - the reason the settings fetch is here is to make sure we have all the settings before saving the blog title rather than fetching everything once auth has completed. Probably moot anyway as the oauth code will be removed shortly  "
+9351,"@@ -397,7 +397,7 @@ func assertConfigsCompatible(cfg1, cfg2 *Config) error {
+ 	if c1.ClientAuth != c2.ClientAuth {
+ 		return fmt.Errorf(""client authentication policy mismatch"")
+ 	}
+-	if c1.ClientAuth != tls.NoClientCert && c2.ClientAuth != tls.NoClientCert && c1.ClientCAs != c2.ClientCAs {
++	if c1.ClientAuth != tls.NoClientCert && c2.ClientAuth != tls.NoClientCert && !StringSliceEqual(cfg1.ClientCerts, cfg2.ClientCerts) {
+ 		// Two hosts defined on the same listener are not compatible if they
+ 		// have ClientAuth enabled, because there's no guarantee beyond the
+ 		// hostname which config will be used (because SNI only has server name).",This line is getting a little long; let's move the conditions to at least two lines (maybe three).
+9352,"@@ -37,6 +37,10 @@
+
+ #include <fastdds/dds/log/Log.hpp>
+
++#include ""../../../../fastdds/core/policy/ParameterList.hpp""
++
++using ParameterList = eprosima::fastdds::dds::ParameterList;
++
+ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {",Don't use relative paths. src directory is already on the include search path
+9353,"@@ -2,7 +2,7 @@ class Api::V1::CompletionsController < ApiController
+   before_action :doorkeeper_authorize!, if: lambda { !signed_in? }
+
+   def index
+-    respond_with current_resource_owner.completions.only_trail_object_ids
++    respond_with completions: current_resource_owner.completions.only_trail_object_ids
+   end
+
+   def create",Line is too long. [86/80]
+9354,"@@ -4,6 +4,11 @@ describe 'TwitterDigits' do
+   let(:service_provider_url) { Faker::Internet.url }
+   let(:credentials) { ""oauth_consumer_key=#{ Faker::Internet.password }"" }
+
++  before do
++    original_twitter_digits_path = File.expand_path('../../../../app/lib/twitter_digits.rb', __FILE__)
++    load original_twitter_digits_path
++  end
++
+   it 'must return the id_str when response is 200' do
+     id_str = Faker::Internet.password
+     response = stub(code: '200', body: { id_str: id_str }.to_json)","We have to navigate up four directories to come down three? I see it, but it's kinda icky. Is something like `load Rails.root + 'app/lib/twitter_digits.rb'` out of fashion nowadays?"
+9355,"@@ -208,6 +208,10 @@ int main(int argc, char *argv[]) {
+
+    res = fpgaDmaOpen(afc_h, &dma_h);
+    ON_ERR_GOTO(res, out_dma_close, ""fpgaDmaOpen"");
++   if(!dma_h) {
++      res = FPGA_EXCEPTION;
++      ON_ERR_GOTO(res, out_dma_close, ""Invaid DMA Handle"");
++   }
+
+    if(use_ase)
+       count = ASE_TEST_BUF_SIZE;",Empty space at end.
+9356,"@@ -215,6 +215,7 @@ module Bolt
+     def with_bolt_executor(executor, inventory, pdb_client = nil, applicator = nil, &block)
+       setup
+       opts = {
++        bolt_project: @project,
+         bolt_executor: executor,
+         bolt_inventory: inventory,
+         bolt_pdb_client: pdb_client,",I think similar to line 176 here we'll want to call `detect_project_conflict` after overriding this.
+9357,"@@ -1,7 +1,8 @@
+ const fs = require('fs')
+ const path = require('path')
+ const chalk = require('chalk')
+-const { exec } = require('child_process')
++const { spawn } = require('child_process')
++const readline = require('readline')
+ const YAML = require('js-yaml')
+ const { promisify } = require('util')
+ const gzipSize = require('gzip-size')",How about `const { promises: fs } = require('fs')` and then replacing `fs.promises.` with `fs.`?
+9358,"@@ -129,13 +129,9 @@ func getGithubData(ctx context.Context, url string) ([]byte, error) {
+ 		return nil, fmt.Errorf(""unexpected status %v (%v) returned"", res.StatusCode, res.Status)
+ 	}
+
+-	buf, err := ioutil.ReadAll(res.Body)
+-	if err != nil {
+-		_ = res.Body.Close()
+-		return nil, err
+-	}
++	defer res.Body.Close()
+
+-	err = res.Body.Close()
++	buf, err := ioutil.ReadAll(res.Body)
+ 	if err != nil {
+ 		return nil, err
+ 	}","This ignores errors closing the body. Not likely to happen, but no reason to take the risk either."
+9359,"@@ -73,7 +73,7 @@ public abstract class FlinkTestBase extends AbstractTestBase {
+   }
+
+   protected static TableResult exec(TableEnvironment env, String query, Object... args) {
+-    return env.executeSql(String.format(query, args));
++    return env.executeSql(args.length > 0 ? String.format(query, args) : query);
+   }
+
+   protected TableResult exec(String query, Object... args) {",Why was this change needed?
+9360,"@@ -259,6 +259,8 @@ namespace pwiz.Skyline
+             (c, p) => c.LockmassNegative = p.ValueDouble);
+         public static readonly Argument ARG_IMPORT_LOCKMASS_TOLERANCE = new DocArgument(@""import-lockmass-tolerance"", NUM_VALUE,
+             (c, p) => c.LockmassTolerance = p.ValueDouble);
++        public static readonly Argument ARG_IMPORT_PEAK_BOUNDARIES = new DocArgument(@""import-peak-boundaries"", PATH_TO_FILE,
++            (c, p) => c.ImportPeakBoundaries = p.ValueFullPath);
+
+         private static readonly ArgumentGroup GROUP_IMPORT = new ArgumentGroup(() => CommandArgUsage.CommandArgs_GROUP_IMPORT_Importing_results_replicates, false,
+             ARG_IMPORT_FILE, ARG_IMPORT_REPLICATE_NAME, ARG_IMPORT_OPTIMIZING, ARG_IMPORT_APPEND, ARG_IMPORT_ALL,",Needs a description added to CommandArgsUsage.resx
+9361,"@@ -153,7 +153,7 @@ public class DownloadServiceNotification {
+                 iconId = R.drawable.ic_notification_sync_error;
+                 intent = ClientConfig.downloadServiceCallbacks.getReportNotificationContentIntent(context);
+                 id = R.id.notification_download_report;
+-                content = String.format(context.getString(R.string.download_report_content), successfulDownloads, failedDownloads);
++                content = context.getResources().getQuantityString(R.plurals.download_report_content, successfulDownloads, successfulDownloads, failedDownloads);
+             }
+
+             NotificationCompat.Builder builder = new NotificationCompat.Builder(context, channelId);",The line is a bit too long. That's why the test currently fails. Please break it into two lines.
+9362,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.
+9363,"@@ -1,4 +1,6 @@
+ module Ncr
++  START_OF_NEW_6X_APPROVAL_POLICY = Time.zone.local(2016, 7, 5, 0, 0, 0)
++
+   class ApprovalManager
+     def initialize(work_order)
+       @work_order = work_order",Can this just be a feature flag to check if it's on? This will give us flexibility on launch date (which could be turned on July 1st) and allow us to easily revert back in case the policy is reverted.
+9364,"@@ -44,4 +44,5 @@ func (p Pin) Low() {
+
+ type ADC struct {
+ 	Pin Pin
++	Bus uint8
+ }","Due to this change, src/examples/adc needs to be modified"
+9365,"@@ -19,6 +19,12 @@ import (
+ 	""unsafe""
+ )
+
++// singlePointer wraps an unsafe.Pointer and supports basic
++// load(), store(), clear(), and swapNil() operations.
++type singlePtr struct {
++	ptr unsafe.Pointer
++}
++
+ func (l *sortedLabels) Len() int {
+ 	return len(*l)
+ }",`s/singlePointer/singlePtr` or please rename the type to `singlePointer`.
+9366,"@@ -577,7 +577,8 @@ bool nano::node_config::upgrade_json (unsigned version_a, nano::jsonconfig & jso
+ 		}
+ 		case 17:
+ 		{
+-			json.put (""vote_generator_delay"", vote_generator_delay.count ()); // Update value
++			json.put (""active_elections_size"", 10000); // Update value
++			json.put (""vote_generator_delay"", 100); // Update value
+ 			json.put (""backup_before_upgrade"", backup_before_upgrade);
+ 			json.put (""work_watcher_period"", work_watcher_period.count ());
+ 		}",Do we need it? If right now it's toml
+9367,"@@ -22,6 +22,16 @@ options._catchError = function(error, newVNode, oldVNode) {
+ 	oldCatchError(error, newVNode, oldVNode);
+ };
+
++const oldUnmount = options.unmount;
++options.unmount = function(vnode) {
++	/** @type {import('./internal').Component} */
++	const component = vnode._component;
++	if (component && component._onResolve) {
++		component._onResolve();
++	}
++	if (oldUnmount) oldUnmount(vnode);
++};
++
+ function detachedClone(vnode, detachedParent, parentDom) {
+ 	if (vnode) {
+ 		if (vnode._component && vnode._component.__hooks) {","You are never calling oldUnmount, this could lead to a plugin chain failing."
+9368,"@@ -119,7 +119,9 @@ public class MetaUtils {
+         name = ""Table"" + tid;
+       }
+       return new TiTableInfo(
+-          tid, CIStr.newCIStr(name), """", """", pkHandle, columns, indices, """", 0, 0, 0, 0);
++          tid, CIStr.newCIStr(name), """", """", pkHandle, columns,
++          indices, """", 0, 0, 0
++          , 0, null);
+     }
+   }
+ ",What does setting partitionInfo to null mean exactly?
+9369,"@@ -225,6 +225,18 @@ class BokehPlot(DimensionedPlot):
+                     source.data.update(converted_data)
+                 else:
+                     source.stream(data, stream.length)
++            return
++
++        # Determine if the CDS.data requires a full update or simply needs
++        # to be updated, this is done by determining whether newly added
++        # or not updated columns have the same length
++        new_length = [len(v) for v in data.values() if isinstance(v, (list, np.ndarray))]
++        length = [len(v) for v in source.data.values() if isinstance(v, (list, np.ndarray))]
++        not_updated = [k for k in source.data if k not in data]
++        new = [k for k in data if k not in source.data]
++        if ((not_updated and new_length and any(len(source.data[n]) != new_length[0] for n in not_updated))
++            or (new and length and any(len(data[n]) != length[0] for n in new))):
++            source.data = data
+         else:
+             source.data.update(data)
+ ",Not sure you need the initial ``not_updated`` as ``any([])`` evaluates to false.
+9370,"@@ -0,0 +1,13 @@
++class AddPublishedAtToVideos < ActiveRecord::Migration
++  def up
++    add_column :videos, :published_at, :datetime
++    execute <<-SQL
++      UPDATE videos
++      SET published_at = created_at
++    SQL
++  end
++
++  def down
++    remove_column :videos, :published_at
++  end
++end","Since this migration hasn't been merged to master yet, what do you think about just squashing these two into the migration you really want?"
+9371,"@@ -0,0 +1 @@
++BetterErrors.editor = :subl if defined? BetterErrors",This doesn't apply to all developers
+9372,"@@ -52,13 +52,16 @@ class SonataMediaExtension extends Extension
+         $loader->load('gaufrette.xml');
+         $loader->load('validators.xml');
+         $loader->load('serializer.xml');
+-        $loader->load('api_form.xml');
+-
++
+         $bundles = $container->getParameter('kernel.bundles');
+
+         if ('doctrine_orm' == $config['db_driver'] && isset($bundles['FOSRestBundle']) && isset($bundles['NelmioApiDocBundle'])) {
+             $loader->load('api_controllers.xml');
+         }
++
++        if (isset($bundles['JMSSerializerBundle'])) {
++            $loader->load('api_form.xml');
++        }
+
+         if (isset($bundles['SonataNotificationBundle'])) {
+             $loader->load('consumer.xml');",I think `serializer.xml` can be moved into condition below too
+9373,"@@ -21,6 +21,9 @@ namespace Benchmarks
+     {
+         public static void Main(string[] args)
+         {
++            // examples to run from command line:
++            // navigate to opentelemetry-dotnet\src\benchmarks directory and run the following
++            // dotnet run --framework netcoreapp3.1 --configuration Release --filter *OpenTelemetrySdkBenchmarksActivity*
+             BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+         }
+     }",Probably put this in a simple README.md file?
+9374,"@@ -0,0 +1,18 @@
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT License. See License.txt in the project root for license information.
++
++using System;
++using System.Collections.Generic;
++using System.Linq;
++using System.Threading.Tasks;
++
++namespace AutoRest.Core.Validation
++{
++    [Flags]
++    public enum ValidationCategory
++    {
++        RPCViolation    = 1 << 0,
++        OneAPIViolation = 1 << 1,
++        SDKViolation    = 1 << 2,
++    }
++}","Super Cool bitwise   Minor: Most likely you don't need `System.Collections.Generic`, `System.Linq` & `System.Threading.Tasks`"
+9375,"@@ -20,7 +20,7 @@ public class DefaultMicroserviceClassLoaderFactory implements MicroserviceClassL
+   public static final MicroserviceClassLoaderFactory INSTANCE = new DefaultMicroserviceClassLoaderFactory();
+
+   @Override
+-  public ClassLoader create(String microserviceName, String version) {
++  public ClassLoader create(String appId, String microserviceName, String version) {
+     return Thread.currentThread().getContextClassLoader();
+   }
+ }","If we just return the TCC, maybe we need to update the method name for it."
+9376,"@@ -111,8 +111,7 @@ namespace AutoRest.Extensions
+             if (methodList.Count == 1)
+             {
+                 Method method = methodList.Single();
+-                return string.Format(CultureInfo.InvariantCulture, ""Additional parameters for the {0} operation."",
+-                    createOperationDisplayString(method.MethodGroup.Name.ToPascalCase(), method.Name));
++                return string.Format(CultureInfo.InvariantCulture, ""Additional parameters for {0} operation."", method.Name);
+             }
+             else if (methodList.Count <= 4)
+             {","For consistency, shouldn't this use `SwaggerModeler.GetMethodNameFromOperationId(method.Name)` as above? I'd just reuse `""Additional parameters for "" + SwaggerModeler.GetMethodNameFromOperationId(method.Name) + "" operation.""` here, `string.Format` with `CultureInfo` is complete nonsense here anyways."
+9377,"@@ -32,7 +32,7 @@ TEST(LivelinessQos, Liveliness_Automatic_Reliable)
+     // Liveliness lease duration and announcement period
+     uint32_t liveliness_ms = 200;
+     Duration_t liveliness_s(liveliness_ms * 1e-3);
+-    Duration_t announcement_period(liveliness_ms * 1e-3 * 0.5);
++    Duration_t announcement_period(liveliness_ms * 1e-3 * 0.01);
+
+     reader.reliability(RELIABLE_RELIABILITY_QOS)
+             .liveliness_kind(AUTOMATIC_LIVELINESS_QOS)","As this is just a backport, I guess it is fine to leave these timings, although they are not enough to make tests stable."
+9378,"@@ -70,8 +70,8 @@ func New(p client.ConfigProvider, cfgs ...*aws.Config) *ECS {
+
+ // newClient creates, initializes and returns a new service client instance.
+ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegion, signingName string) *ECS {
+-	if signingName == """" {
+-		signingName = ServiceName
++	if len(signingName) == 0 {
++		signingName = ""ecs""
+ 	}
+ 	svc := &ECS{
+ 		Client: client.New(",Why this way?
+9379,"@@ -38,10 +38,7 @@ const (
+ func setupEnvironment(t *testing.T) string {
+ 	t.Helper()
+ 	// TODO(shahms): ExtractCompilations should take an output path.
+-	output := os.Getenv(""TEST_TMPDIR"")
+-	if output == """" {
+-		t.Skip(""Skipping test due to incompatible environment (missing TEST_TMPDIR)"")
+-	}
++	output := t.TempDir()
+ 	if err := os.Setenv(""KYTHE_OUTPUT_DIRECTORY"", output); err != nil {
+ 		t.Fatalf(""Error setting KYTHE_OUTPUT_DIRECTORY: %v"", err)
+ 	}",Changing this because otherwise the second run of testExtractCompilationsEndToEndWithDatabase will try to overwrite a generated file and fail. Maybe there's a better way?
+9380,"@@ -90,6 +90,9 @@ public final class HttpUtils {
+    * @return the encoded path param
+    */
+   public static String encodePathParam(String pathParam) {
++    if (pathParam.indexOf(';') != -1) {
++      pathParam = pathParam.substring(0, pathParam.indexOf(';'));
++    }
+     return UrlEscapers.urlPathSegmentEscaper().escape(pathParam);
+   }
+ ",This modification is not correct. Suggections: 1. upgread guava to 30.0-jre will fix this issue
+9381,"@@ -17,8 +17,8 @@ type syscalls struct {
+ var _ specsruntime.Syscalls = (*syscalls)(nil)
+
+ // VerifySignature implements Syscalls.
+-func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) bool {
+-	return crypto.IsValidSignature(plaintext, signer, signature)
++func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) error {
++	return crypto.ValidateSignature(plaintext, signer, signature)
+ }
+
+ // HashBlake2b implements Syscalls.",All changes to signature code stem from here. The syscalls interfaces expects VerifySignature to return an error. I performed the change here and bubbled it up through the rest of the code - mostly mechanical.
+9382,"@@ -77,15 +77,12 @@ public final class InMemoryStorage extends StorageComponent implements SpanStore
+     int maxSpanCount = 500000;
+     List<String> autocompleteKeys = Collections.emptyList();
+
+-    /** {@inheritDoc} */
+-    @Override
+-    public Builder strictTraceId(boolean strictTraceId) {
++    @Override public Builder strictTraceId(boolean strictTraceId) {
+       this.strictTraceId = strictTraceId;
+       return this;
+     }
+
+-    @Override
+-    public Builder searchEnabled(boolean searchEnabled) {
++    @Override public Builder searchEnabled(boolean searchEnabled) {
+       this.searchEnabled = searchEnabled;
+       return this;
+     }","This strategy seems good. Just wondering do you think this is a good time to move stuff out of core? For example, I guess storage, since it's for use by server and not client, doesn't need to be Java 6?"
+9383,"@@ -283,7 +283,8 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+       return new Stats(0L, 0L);
+     }
+
+-    if (filterExpressions == null || filterExpressions == Expressions.alwaysTrue()) {
++    // estimate stats using snapshot summary only for partitioned tables (metadata tables are unpartitioned)
++    if (table.spec().fields().size() > 0 && filterExpression() == Expressions.alwaysTrue()) {
+       long totalRecords = PropertyUtil.propertyAsLong(table.currentSnapshot().summary(),
+           SnapshotSummary.TOTAL_RECORDS_PROP, Long.MAX_VALUE);
+       return new Stats(SparkSchemaUtil.estimateSize(lazyType(), totalRecords), totalRecords);",We had a wrong predicate before: we compared a list to an expression.
+9384,"@@ -21,6 +21,13 @@ func Test_acl_decode(t *testing.T) {
+ 			},
+ 			want: ""user::rw-\nuser:0:rwx\nuser:65534:rwx\ngroup::rwx\nmask::rwx\nother::r--\n"",
+ 		},
++		{
++			name: ""decode group"",
++			args: args{
++				xattr: []byte{2, 0, 0, 0, 8, 0, 1, 0, 254, 255, 0, 0},
++			},
++			want: ""group:65534:--x\n"",
++		},
+ 		{
+ 			name: ""decode fail"",
+ 			args: args{","Name copy-pasted from above. ""empty""?"
+9385,"@@ -98,7 +98,7 @@ class Bottle2neck(_Bottleneck):
+         self.stage_type = stage_type
+         self.scales = scales
+         self.width = width
+-        delattr(self, 'conv2')
++        # delattr(self, 'conv2')
+         delattr(self, self.norm2_name)
+
+     def forward(self, x):",May I ask why change this?
+9386,"@@ -23,15 +23,7 @@ namespace Datadog.Trace.Agent.MessagePack
+                 len++;
+             }
+
+-            if (value.Tags != null)
+-            {
+-                len++;
+-            }
+-
+-            if (value.Metrics != null)
+-            {
+-                len++;
+-            }
++            len += 2; // Tags and metrics
+
+             int originalOffset = offset;
+ ","Does this mean we now always include the dictionaries even if they're empty? If so, we should make sure that this doesn't break the Agent (even older versions). It's possible that it doesn't handle empty dictionaries well."
+9387,"@@ -29,6 +29,9 @@ namespace Nethermind.Blockchain
+         [ConfigItem(Description = ""If set to 'true' then the Fast Sync (eth/63) synchronization algorithm will be used."", DefaultValue = ""false"")]
+         bool FastSync { get; set; }
+
++        [ConfigItem(Description = ""Relevant only if 'FastSync' is 'true'. If set to value, then it will set a minimum height threshold limit up to witch Full Sync will stay on when chain will be behind network."", DefaultValue = ""null"")]
++        long? FastSyncCatchUpHeightDelta { get; set; }
++
+         [ConfigItem(Description = ""If set to 'true' then in the Fast Sync mode blocks will be first downloaded from the provided PivotNumber downwards. This allows for parallelization of requests with many sync peers and with no need to worry about syncing a valid branch (syncing downwards to 0). You need to enter the pivot block number, hash and total difficulty from a trusted source (you can use etherscan and confirm with other sources if you wan to change it)."", DefaultValue = ""false"")]
+         bool FastBlocks { get; set; }
+         ",The description and name is unclear. Typo in 'which'.
+9388,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.
+9389,"@@ -74,6 +74,12 @@ proc_num_simd_saved(void)
+     return num_simd_saved;
+ }
+
++void
++proc_set_num_simd_saved(int num)
++{
++    num_simd_saved = num;
++}
++
+ DR_API
+ int
+ proc_num_simd_registers(void)","> i#1312 AVX-512 support: Add code cache to/from context switching. s|to/from|| (redundant and mildly confusing (called ""enter"" and ""return"" in code))."
+9390,"@@ -521,10 +521,10 @@ void dag_to_cyto(struct dag *d, int condense_display, int change_size)
+ 	fprintf(cytograph, ""\t<att name = \""layoutAlgorithm\"" value = \""Grid Layout\"" type = \""string\"" cy:hidden = \""1\""/>\n"");
+
+ 	if(change_size) {
+-		hash_table_firstkey(d->completed_files);
+-		while(hash_table_nextkey(d->completed_files, &label, (void **) &name)) {
+-			stat(label, &st);
+-			average += ((double) st.st_size) / ((double) hash_table_size(d->completed_files));
++		hash_table_firstkey(d->files);
++		while(hash_table_nextkey(d->files, &name, (void **) &f) && dag_file_exists(f)) {
++			stat(name, &st);
++			average += ((double) st.st_size) / ((double) d->completed_files);
+ 		}
+ 	}
+ ","This stat may fail, right? I think dag_file_exists does not actually check the file is there."
+9391,"@@ -16,7 +16,11 @@ describe('Options Validation', function() {
+     });
+
+     const testObject = { a: 1 };
+-    const validatedObject = objectValidator(testObject, { validationLevel: testValidationLevel });
++    const validatedObject = objectValidator(
++      testObject,
++      {},
++      { validationLevel: testValidationLevel }
++    );
+
+     expect(validatedObject).to.deep.equal({ a: 1 });
+     expect(validatedObject).to.be.frozen;","I think we can make a safe assumption that if only two values are passed in then you have `(optionsToValidate, optionsForValidation)`, if its three then you have `(optionsToValidate, overrideOptions, optionsForValidation)`"
+9392,"@@ -141,12 +141,14 @@ func runExperimentalBeamPipeline(ctx context.Context) error {
+ 	entries := beamio.ReadEntries(s, *entriesFile)
+ 	k := pipeline.FromEntries(s, entries)
+ 	shards := 8 // TODO(schroederc): better determine number of shards
++	edgeSets, edgePages := k.Edges()
+ 	xrefSets, xrefPages := k.CrossReferences()
+ 	beamio.WriteLevelDB(s, *tablePath, shards,
+ 		k.CorpusRoots(),
+ 		k.Directories(),
+ 		k.Decorations(),
+ 		xrefSets, xrefPages,
++		edgeSets, edgePages,
+ 	)
+ 	return beamx.Run(ctx, p)
+ }","If there are more items to add to what's being written out here, please add a TODO."
+9393,"@@ -106,8 +106,12 @@ class SuperSocket(six.with_metaclass(_SuperSocket_metaclass)):
+                         pkt = pkt[:12] + tag + pkt[12:]
+                 elif cmsg_lvl == socket.SOL_SOCKET and \
+                         cmsg_type == SO_TIMESTAMPNS:
+-                    tmp = struct.unpack(""iiii"", cmsg_data)
+-                    timestamp = tmp[0] + tmp[2] * 1e-9
++                    length = len(cmsg_data)
++                    if length == 16:  # __kernel_timespec
++                        tmp = struct.unpack(""ll"", cmsg_data)
++                    elif length == 8:  # timespec
++                        tmp = struct.unpack(""ii"", cmsg_data)
++                    timestamp = tmp[0] + tmp[1] * 1e-9
+             return pkt, sa_ll, timestamp
+
+     def recv_raw(self, x=MTU):",Can you add an `else:` case to handle an invalid length? That will prevent weird errors.
+9394,"@@ -9,14 +9,10 @@ public class ASTAttribute extends AbstractJspNode {
+
+     private String name;
+
+-    public ASTAttribute(int id) {
++    ASTAttribute(int id) {
+         super(id);
+     }
+
+-    public ASTAttribute(JspParser p, int id) {
+-        super(p, id);
+-    }
+-
+     /**
+      * @return Returns the name.
+      */",* We need to deprecate/internalize first on master. * We should directly make the AST node final now * The setter `setName()` can be package-private.
+9395,"@@ -137,12 +137,6 @@ public class InitCodeTransformer {
+       // Remove the request object for flattened method
+       orderedItems.remove(orderedItems.size() - 1);
+     }
+-    for (InitCodeNode param :
+-        sampleFuncParams(
+-            root, initCodeContext.sampleArgStrings(), initCodeContext.sampleParamConfigMap())) {
+-      List<InitCodeNode> paramInits = param.listInInitializationOrder();
+-      orderedItems.removeAll(paramInits);
+-    }
+     return orderedItems;
+   }
+ ",Where did this functionality move to?
+9396,"@@ -68,6 +68,19 @@ public class TiDBJDBCClient implements AutoCloseable {
+     }
+   }
+
++  // SPLIT TABLE table_name [INDEX index_name] BETWEEN (lower_value) AND (upper_value) REGIONS
++  // region_num
++  public boolean splitTableRegion(
++      String dbName, String tblName, long minVal, long maxVal, long regionNum) throws SQLException {
++    try (Statement tidbStmt = connection.createStatement()) {
++      String sql =
++          String.format(
++              ""split table %s.%s between (%d) and (%d) regions %d"",
++              dbName, tblName, minVal, maxVal, regionNum);
++      return tidbStmt.execute(sql);
++    }
++  }
++
+   public boolean isClosed() throws SQLException {
+     return connection.isClosed();
+   }",maybe should firstly check whether current tidb support `split table region`?
+9397,"@@ -27,7 +27,8 @@ import { Fragment } from '@wordpress/element';
+ import Data from 'googlesitekit-data';
+ import Logo from './Logo';
+ import UserMenu from './UserMenu';
+-import ErrorNotification from '../components/notifications/error-notification';
++import LegacyErrorNotification from './legacy-notifications/error-notification';
++import ErrorNotification from './notifications/ErrorNotifications';
+ import { STORE_NAME as CORE_USER } from '../googlesitekit/datastore/user/constants';
+ const { useSelect } = Data;
+ ",Please use the same (plural) name for the new component since it renders multiple notifications.
+9398,"@@ -466,6 +466,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
+ 				}
+ 				if attemptsCount <= uint64(cs.config.CatchupBlockDownloadRetryAttempts) {
+ 					// try again.
++					cs.log.Infof(""Failed to download block %d. %v"", topBlock.Round()-basics.Round(blocksFetched), err)
+ 					continue
+ 				}
+ 				return cs.abort(fmt.Errorf(""processStageBlocksDownload failed after multiple blocks download attempts""))",Perhaps show attempt x of y in message ie: Failed to download block %d (attempt %d of %d). %v
+9399,"@@ -94,8 +94,7 @@ public class PrivateTransactionHandler {
+     }
+   }
+
+-  public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction)
+-      throws Exception {
++  public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction) {
+     if (privateTransaction.getPrivacyGroupId().isPresent()) {
+       return BytesValues.asBase64String(privateTransaction.getPrivacyGroupId().get());
+     }",why did you took `Exception` out? Is this method only throwing runtime exceptions?
+9400,"@@ -1,9 +1,7 @@
+ # coding: utf-8
+ """"""Comparison of `binary` and `xentropy` objectives.
+-
+ BLUF: The `xentropy` objective does logistic regression and generalizes
+ to the case where labels are probabilistic (i.e. numbers between 0 and 1).
+-
+ Details: Both `binary` and `xentropy` minimize the log loss and use
+ `boost_from_average = TRUE` by default. Possibly the only difference
+ between them with default settings is that `binary` may achieve a slight",please revert all of these unrelated whitespace changes
+9401,"@@ -0,0 +1,15 @@
++package com.fsck.k9.mail;
++
++/**
++ * Enumeration of the different possible encryption protocol that can be used.
++ */
++public enum EncryptionType {
++
++    NONE,
++
++    INLINE,
++
++    PGP_MIME,
++
++    S_MIME
++}",PGP_INLINE is clearer IMHO
+9402,"@@ -16,6 +16,8 @@ import (
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/require""
+
++	""context""
++
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/action""
+ 	""github.com/iotexproject/iotex-core/config""",Please group imports
+9403,"@@ -102,7 +102,7 @@ public class TestHiveMetastore {
+         .transportFactory(new TTransportFactory())
+         .protocolFactory(new TBinaryProtocol.Factory())
+         .minWorkerThreads(3)
+-        .maxWorkerThreads(5);
++        .maxWorkerThreads(10);
+
+     return new TThreadPoolServer(args);
+   }",Would it make sense to expose this as a config option in `TestHiveMetastore`? A small number of worker threads helped us to catch a few connection leaks early on.
+9404,"@@ -10,9 +10,12 @@ void im2col_cpu(const Dtype* data_im, const int channels,
+     const int height, const int width, const int kernel_h, const int kernel_w,
+     const int pad_h, const int pad_w,
+     const int stride_h, const int stride_w,
++    const int dilation_h, const int dilation_w,
+     Dtype* data_col) {
+-  const int height_col = (height + 2 * pad_h - kernel_h) / stride_h + 1;
+-  const int width_col = (width + 2 * pad_w - kernel_w) / stride_w + 1;
++  const int height_col = (height + 2 * pad_h -
++      (dilation_h * (kernel_h - 1)  + 1)) / stride_h + 1;
++  const int width_col = (width + 2 * pad_w -
++      (dilation_w * (kernel_w - 1)  + 1)) / stride_w + 1;
+   const int channels_col = channels * kernel_h * kernel_w;
+   for (int c_col = 0; c_col < channels_col; ++c_col) {
+     int w_offset = c_col % kernel_w;",Let's fix the extra spaces above.
+9405,"@@ -27,7 +27,7 @@ public interface SearchContext {
+    * @return A list of all {@link WebElement}s, or an empty list if nothing matches
+    * @see org.openqa.selenium.By
+    */
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",should a similar change be done for findElement?
+9406,"@@ -15,11 +15,17 @@ import (
+
+ var _ keystore.Service = (*Service)(nil)
+
++// Service is the memory-based keystore.Service implementation.
++//
++// Keys are stored in the in-memory map, where the key is the name of the
++// private key, and value is structure where actual private key and password are
++// stored.
+ type Service struct {
+ 	m  map[string]key
+ 	mu sync.Mutex
+ }
+
++// New creates new memory-based keystore.Service implementation.
+ func New() *Service {
+ 	return &Service{
+ 		m: make(map[string]key),","// Keys are stored in an in-memory map, where the key is the name of the // private key, and the value is the structure where the actual private key and the password are // stored."
+9407,"@@ -59,6 +59,9 @@ var _ = duck.VerifyType(&PullSubscription{}, &duckv1.Conditions{})
+
+ // PullSubscriptionSpec defines the desired state of the PullSubscription.
+ type PullSubscriptionSpec struct {
++	// This brings in CloudEventOverrides and Sink.
++	duckv1.SourceSpec
++
+ 	// Secret is the credential to use to create and poll the PullSubscription
+ 	// Subscription. The value of the secret entry must be a service account
+ 	// key in the JSON format (see https://cloud.google.com/iam/docs/creating-managing-service-account-keys).",I think this needs a json inline tag here
+9408,"@@ -510,7 +510,7 @@ string t_erl_generator::render_member_type(t_field * field) {
+   } else if (type->is_struct() || type->is_xception()) {
+     return ""#"" + uncapitalize(type->get_name()) + ""{}"";
+   } else if (type->is_map()) {
+-    return ""dict()"";
++    return ""dict:dict()"";
+   } else if (type->is_set()) {
+     return ""set()"";
+   } else if (type->is_list()) {","Hi @cjimison good point but doesn't this break the compatibility with Erlang/OTP prior to 17.0? I think this could be done over an conditional macro defined in the rebar.config: `{erl_opts, [ {platform_define, ""^R"", pre17} ]}` and some additions with `-ifdef(pre17). ... -else. ... -endif.`"
+9409,"@@ -210,7 +210,7 @@ func (pl *List) removeFromUnavailablePeers(p peer.Peer) {
+
+ // Choose selects the next available peer in the round robin
+ func (pl *List) Choose(ctx context.Context, req *transport.Request) (peer.Peer, func(error), error) {
+-	if !pl.IsRunning() {
++	if err := pl.once.WaitForStart(ctx); err != nil {
+ 		return nil, nil, peer.ErrPeerListNotStarted(""RoundRobinList"")
+ 	}
+ ",should we change/wrap the error?
+9410,"@@ -109,12 +109,12 @@ final class DeFramer extends ByteToMessageDecoder {
+         try {
+           peerInfo = HelloMessage.readFrom(message).getPeerInfo();
+         } catch (final RLPException e) {
+-          LOG.debug(""Received invalid HELLO message"", e);
++          LOG.warn(""Received invalid HELLO message, set log level to TRACE for message body"", e);
+           connectFuture.completeExceptionally(e);
+           ctx.close();
+           return;
+         }
+-        LOG.debug(""Received HELLO message: {}"", peerInfo);
++        LOG.trace(""Received HELLO message: {}"", peerInfo);
+         if (peerInfo.getVersion() >= 5) {
+           LOG.trace(""Enable compression for p2pVersion: {}"", peerInfo.getVersion());
+           framer.enableCompression();",Are we sure that passing this log in warning does not risk spamming the logs of a node running on the mainnet or on ropsten etc ? Do we often receive invalid messages of this type ?
+9411,"@@ -397,10 +397,7 @@ class Parser
+     # check for option to find list item text only
+     # if skipped a line, assume a list continuation was
+     # used and block content is acceptable
+-    if (text_only = options[:text]) && skipped > 0
+-      options.delete(:text)
+-      text_only = false
+-    end
++    text_only = is_text_only(options, skipped)
+
+     parse_metadata = options.fetch(:parse_metadata, true)
+     #parse_sections = options.fetch(:parse_sections, false)",I'd like to avoid a method call here atm since this is an extremely hot line in the code.
+9412,"@@ -421,8 +421,7 @@ def parse_input(vds):
+
+ def parse_witness(vds):
+     n = vds.read_compact_size()
+-    for i in range(n):
+-        x = vds.read_bytes(vds.read_compact_size())
++    return list(vds.read_bytes(vds.read_compact_size()).encode('hex') for i in xrange(n))
+
+ def parse_output(vds, i):
+     d = {}",Is this a bugfix?
+9413,"@@ -35,7 +35,6 @@ namespace Microsoft.DotNet.Build.Tasks
+                 GlobalPackagesFolder = PackagesDir,
+
+                 Sources = new List<string>(),
+-                FallbackSources = new List<string>(),
+                 CacheContext = new SourceCacheContext(),
+                 RequestProviders = new List<IRestoreRequestProvider>
+                 {",Is this a relevant change?
+9414,"@@ -62,9 +62,9 @@ public final class JUnit5RuleUsage extends BugChecker implements BugChecker.Clas
+     }
+
+     static Matcher<ClassTree> hasVariable(Matcher<VariableTree> matcher) {
+-        return (classTree, state) -> classTree.getMembers().stream()
+-                .filter(tree -> tree instanceof VariableTree)
+-                .anyMatch(tree -> matcher.matches((VariableTree) tree, state));
++        return (classTree, state) ->
++                classTree.getMembers().stream().filter(tree -> tree instanceof VariableTree).anyMatch(tree ->
++                        matcher.matches((VariableTree) tree, state));
+     }
+
+     static Matcher<VariableTree> hasAnnotationOnVariable(String annotation) {",@dansanduleac what do you think of this one? dots were aligned and no longer are
+9415,"@@ -738,10 +738,6 @@ function deleteAllAppData(appId, fromAppDelete, params, app) {
+             }, deleteEvents);
+         }
+     });
+-
+-    if (fromAppDelete) {
+-        common.db.collection('graph_notes').remove({'_id': common.db.ObjectID(appId)}, function() {});
+-    }
+ }
+
+ /**",Why we dont delete app specific notes when app is deleted?
+9416,"@@ -113,9 +113,17 @@ public class ConfigBuilderPlugin extends PluginBase {
+         pluginList = MainApp.getPluginsList();
+         upgradeSettings();
+         loadSettings();
++        setAlwaysEnabledPluginsEnabled();
+         MainApp.bus().post(new EventAppInitialized());
+     }
+
++    private void setAlwaysEnabledPluginsEnabled() {
++        for (PluginBase plugin : pluginList) {
++            if (plugin.pluginDescription.alwaysEnabled) plugin.setPluginEnabled(plugin.getType(), true);
++        }
++        storeSettings(""setAlwaysEnabledPluginsEnabled"");
++    }
++
+     public void storeSettings(String from) {
+         if (pluginList != null) {
+             if (Config.logPrefsChange)","The _OverviewPlugin_ is forcefully enabled without the option to disable it, using _PluginDescription.alwaysEnabled_. That should also work for this plugin?"
+9417,"@@ -220,6 +220,8 @@ public class SearchFields {
+      * i.e. ""Unpublished"", ""Draft"" (multivalued)
+      */
+     public static final String PUBLICATION_STATUS = ""publicationStatus"";
++
++    public static final String EXTERNAL_STATUS = ""externalStatus"";
+     /**
+      * @todo reconcile different with Solr schema.xml where type is Long rather
+      * than String.",Can you facet on this new externalStatus Solr field?
+9418,"@@ -132,11 +132,14 @@ module Blacklight
+     end
+
+     def filters
+-      @filters ||= blacklight_config.facet_fields.each_value.map do |value|
+-        f = filter(value)
+-
+-        f if f.any?
+-      end.compact
++      @filters ||= blacklight_config.facet_fields.each_value.reduce([]) do |acc, value|
++        if value.pivot
++          acc + value.pivot.map { |v| value.class.new(key: v) }
++                     .map { |f| filter(f) }.select(&:any?)
++        else
++          acc + Array(filter(value)).select(&:any?)
++        end
++      end
+     end
+
+     def filter(field_key_or_field)","I wonder if it would it make sense to push the pivot facet handling down into `FilterField` (or maybe a subclass, `PivotFilterField`?)?"
+9419,"@@ -47,7 +47,12 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction
+       end
+
+       begin
+-        result = func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true)
++        func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true)
++        # If the plan returns using a return statement then we never get here.
++        # We only get here if the plan finishes without executing any return
++        # statement and since we don't want to leak any implicit return value
++        # from the plan we simply set the result to nil here.
++        result = nil
+       rescue Puppet::PreformattedError => err
+         if named_args['_catch_errors'] && err.cause.is_a?(Bolt::Error)
+           result = err.cause.to_puppet_error",Ah I see what you were saying about making it harder to validate types. We'll have to catch the return for that.
+9420,"@@ -86,6 +86,7 @@ public abstract class BaseActivity extends AppCompatActivity implements BottomNa
+                         .setTarget(nav_cam)
+                         .setDismissText(getResources().getString(R.string.ok_button))
+                         .setContentText(getResources().getString(R.string.camera_button))
++                        .hideOnTouchOutside()
+                         .build()
+         );
+ ",Try using using `.setDismissOnTouch(true)` instead
+9421,"@@ -122,6 +122,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+                 }
+                 catch (Exception ex)
+                 {
++                    if (scope != null)
++                    {
++                        // some fields aren't set till after execution, so populate anything missing
++                        UpdateSpan(controllerContext, scope.Span);
++                    }
++
+                     scope?.Span.SetException(ex);
+                     throw;
+                 }","Zach, is `UpdateSpan` of concern too? I see that it is called from `ExecuteAsyncInternal`."
+9422,"@@ -26,7 +26,9 @@ import org.apache.iceberg.types.Type;
+ import org.apache.iceberg.types.Types;
+ import org.apache.orc.TypeDescription;
+
+-public class TypeConversion {
++public final class TypeConversion {
++
++  private TypeConversion() {}
+
+   /**
+    * Convert a given Iceberg schema to ORC.",Nit: its scope can be reduced to package default
+9423,"@@ -15,5 +15,7 @@ namespace Microsoft.AspNetCore.Protocols.Features
+         PipeScheduler InputWriterScheduler { get; }
+
+         PipeScheduler OutputReaderScheduler { get; }
++
++        PipeScheduler ApplicationScheduler { get; set; }
+     }
+ }",Why is this get;set;?
+9424,"@@ -77,6 +77,9 @@ bool StatefulReader::matched_writer_add(RemoteWriterAttributes& wdata)
+
+     getRTPSParticipant()->createSenderResources(wdata.endpoint.remoteLocatorList, false);
+
++
++    wdata.endpoint.unicastLocatorList =
++        mp_RTPSParticipant->network_factory().ShrinkLocatorLists({wdata.endpoint.unicastLocatorList});
+     WriterProxy* wp = new WriterProxy(wdata, this);
+
+     wp->mp_initialAcknack->restart_timer();",Should we also create sender resources for unicast locators? Should we make a similar change on StatelessReader?
+9425,"@@ -130,7 +130,7 @@ namespace Datadog.Trace.RuntimeMetrics
+                 // Catching error UnauthorizedAccessException: Access to the registry key 'Global' is denied.
+                 // The 'Global' part seems consistent across localizations
+
+-                Log.Error(ex, ""The process does not have sufficient permissions to read performance counters. Please refer to https://docs.datadoghq.com/tracing/runtime_metrics/dotnet/#additional-permissions-for-iis to learn how to grant those permissions."");
++                Log.Error(ex, ""The process does not have sufficient permissions to read performance counters. Please refer to https://dtdg.co/net-runtime-metrics to learn how to grant those permissions."");
+                 throw;
+             }
+             catch (Exception ex)",Can we use `dotnet` instead of `net`?
+9426,"@@ -372,6 +372,13 @@ namespace Datadog.Trace
+             return StartSpan(operationName, tags: null, parent, serviceName, startTime, ignoreActiveScope, spanId: null);
+         }
+
++        /// <summary>
++        /// Forces the tracer to immediately flush pending traces and send them to the agent.
++        /// To be called when the appdomain or the process is about to be killed in a non-graceful way.
++        /// </summary>
++        /// <returns>Task used to track the async flush operation</returns>
++        public Task ForceFlush() => FlushAsync();
++
+         /// <summary>
+         /// Writes the specified <see cref=""Span""/> collection to the agent writer.
+         /// </summary>",Should this be `ForceFlushAsync`? Given we have the `async` suffix elsewhere.
+9427,"@@ -48,8 +48,8 @@ class TestJMeterExecutor(BZTestCase):
+         self.obj = get_jmeter()
+
+     def tearDown(self):
+-        if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx):
+-            os.remove(self.obj.modified_jmx)
++        # if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx):
++        #     os.remove(self.obj.modified_jmx)
+         super(TestJMeterExecutor, self).tearDown()
+
+     def configure(self, config):",Is this change intentional?
+9428,"@@ -55,10 +55,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+
+             if (nativeOffset != -1)
+             {
+-                stackFrame.Properties = new Dictionary<string, string>
+-                {
+-                    { ""NativeOffset"", nativeOffset.ToString(CultureInfo.InvariantCulture) }
+-                };
++                stackFrame.SetProperty(""NativeOffset"", nativeOffset.ToString(CultureInfo.InvariantCulture));
+             }
+
+             return stackFrame;",This could be an integer property if we supported explicitly setting non-string-valued properties.
+9429,"@@ -14,8 +14,7 @@ use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
+ class RouteCsrfProtector implements EventSubscriberInterface
+ {
+     public const CSRF_TOKEN_REQUEST_PARAMETER = 'routeCsrfToken';
+-    /** @access protected */
+-    const CSRF_TOKEN_ID_PREFIX = 'route_';
++    public const CSRF_TOKEN_ID_PREFIX = 'route_';
+
+     /**
+      * @var \Doctrine\Common\Annotations\Reader",this is not consistent with the previous annotation - is it because of the usage in `Admin\Content\Category\list.html.twig` twig template? Should not it be at least mentioned in the commit message? :slightly_smiling_face:
+9430,"@@ -149,6 +149,7 @@ func ReadSecretFromStdin() (string, error) {
+ 			case <-routineTerminate:
+ 				return
+ 			default:
++				return
+ 			}
+ 		}
+ 	}()",why add `return` here?
+9431,"@@ -82,7 +82,9 @@ namespace Nethermind.Network.Test.Discovery
+             Assert.AreEqual(message.DestinationAddress, deserializedMessage.DestinationAddress);
+             Assert.AreEqual(message.SourceAddress, deserializedMessage.SourceAddress);
+             Assert.AreEqual(message.Version, deserializedMessage.Version);
+-            Assert.IsNotNull(deserializedMessage.Mdc);
++
++            // check MDC correctness
++            Assert.IsNotNull(Bytes.FromHexString(""0xf8c61953f3b94a91aefe611e61dd74fe26aa5c969d9f29b7e063e6169171a772""));
+         }
+
+         [Test]",put this hash in variable
+9432,"@@ -5,11 +5,8 @@
+ package libkbfs
+
+ import (
+-	""bytes""
+-	""errors""
+ 	""testing""
+
+-	""github.com/keybase/client/go/libkb""
+ 	""github.com/keybase/client/go/logger""
+ 	""github.com/keybase/client/go/protocol/keybase1""
+ 	""github.com/keybase/go-framed-msgpack-rpc/rpc""",Why not use `kbfsblock.ZeroRefNonce`?
+9433,"@@ -26,7 +26,7 @@ class EarlyStopException(Exception):
+
+ # Callback environment used by callbacks
+ CallbackEnv = collections.namedtuple(
+-    ""LightGBMCallbackEnv"",
++    ""CallbackEnv"",
+     [""model"",
+      ""params"",
+      ""iteration"",",what mypy warning does this address? I'm confused by this change.
+9434,"@@ -3751,6 +3751,18 @@ void Player::addAttacked(const Player* attacked)
+ 	attackedSet.insert(attacked->guid);
+ }
+
++void Player::removeAttacked(const Player* attacked)
++{
++	if (!attacked || attacked == this) {
++		return;
++	}
++
++	auto it = attackedSet.find(attacked->guid);
++	if (it != attackedSet.end()) {
++		attackedSet.erase(it);
++	}
++}
++
+ void Player::clearAttacked()
+ {
+ 	attackedSet.clear();",Note that `hasAttacked` that is called before this function already performs this check. You probably don't need to check `hasAttacked` then.
+9435,"@@ -0,0 +1,10 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!@salesforce/design-system-react/components/carousel/__examples__/default.jsx'),
++];
++
++module.exports = siteStories;","Unfortunately, the site example only has access to imports from `components/index.js` that means that you can't import the items file `carousel-items.js`. You can import that file in all the other storybook files though."
+9436,"@@ -79,7 +79,7 @@ setup(
+             'locale/*/LC_MESSAGES/electrum.mo',
+         ]
+     },
+-    scripts=['electrum'],
++    scripts=['electrum', 'privkey2electrum'],
+     data_files=data_files,
+     description=""Lightweight Bitcoin Wallet"",
+     author=""Thomas Voegtlin"",",Leave this out and move the script to the scripts folder.
+9437,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings."
+9438,"@@ -0,0 +1,17 @@
++using System.Collections.Generic;
++using System.IO.Pipelines;
++using System.Threading.Tasks;
++using Microsoft.AspNetCore.Http.Features;
++
++namespace Microsoft.AspNetCore.Connections
++{
++    public interface IConnection
++    {
++        IDuplexPipe Transport { get; }
++        IFeatureCollection Features { get; }
++
++        Task StartAsync();
++        Task StartAsync(TransferFormat transferFormat);
++        Task DisposeAsync();
++    }
++}",TransferFormat.Text in general purpose connection interface? :/
+9439,"@@ -36,10 +36,17 @@ module Selenium
+       SOCKET_LOCK_TIMEOUT = 45
+       STOP_TIMEOUT        = 20
+
++      @executable = nil
++      @missing = ''
++
++      class << self
++        attr_accessor :executable, :missing_text
++      end
++
+       attr_accessor :host
+
+       def initialize(executable_path, port, *extra_args)
+-        @executable_path = executable_path
++        @executable_path = binary_path(executable_path)
+         @host            = Platform.localhost
+         @port            = Integer(port)
+         @extra_args      = extra_args",Is this `@missing_text` ?
+9440,"@@ -485,6 +485,12 @@ func (c *client) processRouteInfo(info *Info) {
+ 		if !s.getOpts().Cluster.NoAdvertise {
+ 			s.addClientConnectURLsAndSendINFOToClients(info.ClientConnectURLs)
+ 		}
++
++		// This will allow us to determine the initial RTT without having to
++		// wait for first timer based PING.
++		c.mu.Lock()
++		c.sendPing()
++		c.mu.Unlock()
+ 	} else {
+ 		c.Debugf(""Detected duplicate remote route %q"", info.ID)
+ 		c.closeConnection(DuplicateRoute)",This work for both sides?
+9441,"@@ -32,9 +32,12 @@ import {
+ 	isDataZeroSearchConsole,
+ } from '../dashboard/util';
+
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class DashboardWidgetPopularKeywordsTable extends Component {
+ 	static renderLayout( component ) {",`lodash` shouldn't be grouped under WordPress dependencies
+9442,"@@ -117,6 +117,13 @@ class ComputeTest(unittest_utils.ForsetiTestCase):
+         with self.assertRaises(expected_exception):
+             list(self.gce_api_client.get_firewall_rules(self.project_id))
+
++
++    def test_get_global_operations(self):
++        """"""Test get_global_operations""""""
++        http_mocks.mock_http_response(fake_compute.GLOBAL_OPERATIONS_RESPONSE)
++        results = self.gce_api_client.get_global_operations(
++            self.project_id, operation_id='operation-1234')
++
+     def test_get_quota(self):
+         """"""Test get quota.""""""
+         http_mocks.mock_http_response(fake_compute.GET_PROJECT_RESPONSE)",Include the standard parameterized error tests as well.
+9443,"@@ -242,6 +242,16 @@ func runWeb(ctx *cli.Context) {
+ 					m.Patch(""/hooks/:id:int"", bind(api.EditHookOption{}), v1.EditRepoHook)
+ 					m.Get(""/raw/*"", middleware.RepoRef(), v1.GetRepoRawFile)
+ 					m.Get(""/archive/*"", v1.GetRepoArchive)
++					m.Post(""/forks"", v1.ForkRepo)
++
++					m.Get(""/commits/:commitId"", middleware.RepoRef(), v1.CommitById)
++					m.Get(""/commits/current"", middleware.RepoRef(), v1.CurrentCommit)
++
++					m.Group(""/releases"", func() {
++						m.Combo("""").Get(v1.ListReleases).
++							Post(bindIgnErr(api.CreateReleaseOption{}), v1.CreateRelease)
++						m.Get(""/:release"", v1.ReleaseByName)
++					}, middleware.RepoRef())
+ 				}, middleware.ApiRepoAssignment(), middleware.ApiReqToken())
+ 			})
+ ",All lowercase in route rule.
+9444,"@@ -61,8 +61,16 @@ export const actions = {
+
+ 			const { dispatch } = yield Data.commonActions.getRegistry();
+ 			yield actions.receiveAccounts( response.accounts );
+-			dispatch( STORE_NAME ).receiveProperties( response.properties );
+-			dispatch( STORE_NAME ).receiveProfiles( response.profiles );
++
++			if ( response.properties.length && response.properties[ 0 ] && response.properties[ 0 ].accountId ) {
++				const accountID = response.properties[ 0 ].accountId;
++				dispatch( STORE_NAME ).receiveProperties( response.properties, { accountID } );
++			}
++
++			if ( response.properties.length && response.properties[ 0 ] && response.properties[ 0 ].id ) {
++				const propertyID = response.properties[ 0 ].id;
++				dispatch( STORE_NAME ).receiveProfiles( response.profiles, { propertyID } );
++			}
+
+ 			if ( response.matchedProperty ) {
+ 				dispatch( STORE_NAME ).receiveMatchedProperty( response.matchedProperty );","I'd suggest we use `response.profiles[ 0 ].webPropertyId` here instead, to make sure it's based on the profiles retrieved. The value _should_ be the same, but I think it's a bit more accurate like that."
+9445,"@@ -314,8 +314,8 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+             bgGraph.setOnLongClickListener(new View.OnLongClickListener() {
+                 @Override
+                 public boolean onLongClick(View v) {
+-                    rangeToDisplay += 6;
+-                    rangeToDisplay = rangeToDisplay > 24 ? 6 : rangeToDisplay;
++                    rangeToDisplay += 3;
++                    rangeToDisplay = rangeToDisplay > 24 ? 3 : rangeToDisplay;
+                     SP.putInt(R.string.key_rangetodisplay, rangeToDisplay);
+                     updateGUI(""rangeChange"");
+                     return false;","This doesn't change the default of 6h, but will increase the displayed timeframe by 3h for each long press, before wrapping around to 3h. This requires 7 long-presses - quiet a journey ..."
+9446,"@@ -91,6 +91,7 @@ type nodeChainReader interface {
+ 	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ 	HeadEvents() *ps.PubSub
+ 	Load(context.Context) error
++	SetHead(context.Context, types.TipSet) error
+ 	Stop()
+ }
+ ",We still need to figure out a way to get rid of this write method. Is this still necessary?
+9447,"@@ -265,6 +265,11 @@ class KNNClassifierTest(unittest.TestCase):
+
+     self.assertEquals(classifier.getNumPartitionIds(), 3)
+
++    # Check that the full set of partition ids is what we expect
++    self.assertItemsEqual(classifier.getPartitionIdPerPattern(),
++                          [433, 213, np.inf, 433, 413])
++    self.assertItemsEqual(classifier.getPartitionIdList(),[433, 413, 213])
++
+     # Remove two rows - all indices shift down
+     self.assertEquals(classifier._removeRows([0,2]), 2)
+     self.assertItemsEqual(classifier.getPatternIndicesWithPartitionId(433),","`assertItemsEqual` compares the sequences after sorting them, is that intended?"
+9448,"@@ -170,8 +170,8 @@ module Selenium
+
+           def macosx_path
+             path = ""/Applications/Firefox.app/Contents/MacOS/firefox-bin""
+-            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(path)
+-            path = Platform.find_binary(""firefox-bin"") unless File.exist?(path)
++            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(File.expand_path(path))
++            path = Platform.find_binary(""firefox-bin"") unless File.exist?(File.expand_path?(path))
+
+             path
+           end",I don't think this one needs to be changed since the only previous path is already an absolute one.
+9449,"@@ -13,8 +13,14 @@ namespace AutoRest.Swagger.Model.Utilities
+ {
+     public static class ValidationUtilities
+     {
+-        private static readonly string XmsPageable = ""x-ms-pageable"";
++        private const string XmsPageable = ""x-ms-pageable"";
+         private static readonly Regex TrackedResRegEx = new Regex(@"".+/Resource$"", RegexOptions.IgnoreCase);
++        private const string AzureHostSignature = ""management.azure.com"";
++
++        // if x-ms-parameterized-host extension is used or if the host is anything of the form management.azure, assume this to be an ARMServiceDefinition
++        // TODO: refine this definition for azure data plain also check x-ms-parameterized-host in detail to ensure this is ARM
++        public static bool IsARMServiceDefinition(ServiceDefinition serviceDefinition) =>
++            serviceDefinition.Extensions.ContainsKey(""x-ms-parameterized-host"") || serviceDefinition.Host?.EqualsIgnoreCase(AzureHostSignature) == true;
+
+         public static bool IsTrackedResource(Schema schema, Dictionary<string, Schema> definitions)
+         {",what's the goal of this?
+9450,"@@ -49,6 +49,8 @@ type Node struct {
+
+ 	// CborStore is a temporary interface for interacting with IPLD objects.
+ 	CborStore *hamt.CborIpldStore
++
++	pool *core.MessagePool
+ }
+
+ // Config is a helper to aid in the construction of a filecoin node.",why is this here? We already have a message pool in the node.
+9451,"@@ -1107,7 +1107,7 @@ func (s *activityReplicatorSuite) TestSyncActivity_ActivityRunning() {
+ 	var versionHistories *persistence.VersionHistories
+ 	s.mockMutableState.EXPECT().GetVersionHistories().Return(versionHistories).AnyTimes()
+ 	s.mockMutableState.EXPECT().GetReplicationState().Return(&persistence.ReplicationState{}).AnyTimes()
+-	s.mockMutableState.EXPECT().GetWorkflowStateStatus().Return(enumsgenpb.WORKFLOW_EXECUTION_STATE_RUNNING, enumspb.WORKFLOW_EXECUTION_STATUS_UNSPECIFIED).AnyTimes()
++	s.mockMutableState.EXPECT().GetWorkflowStateStatus().Return(enumsgenpb.WORKFLOW_EXECUTION_STATE_RUNNING, enumspb.WORKFLOW_EXECUTION_STATUS_COMPLETED).AnyTimes()
+ 	s.mockNamespaceCache.EXPECT().GetNamespaceByID(namespaceID).Return(
+ 		cache.NewGlobalNamespaceCacheEntryForTest(
+ 			&persistenceblobs.NamespaceInfo{Id: namespaceID, Name: namespace},",Another mess after all renames and enum conversions. Doesn't break anything though.
+9452,"@@ -17,7 +17,8 @@ class PluginSetup(unittest.TestCase):
+     def test_a_statsd_timer_is_used_for_history_if_configured(self):
+         settings = {
+             ""statsd_url"": ""udp://127.0.0.1:8125"",
+-            ""includes"": ""kinto.plugins.history""
++            ""includes"": ""kinto.plugins.history"",
++            ""storage_strict_json"": True
+         }
+         config = testing.setUp(settings=settings)
+         with mock.patch('kinto.core.statsd.Client.timer') as mocked:",I don't think it's necessary to change this for the history plugin tests?
+9453,"@@ -328,8 +328,8 @@ bool TCPv4Transport::compare_locator_ip_and_port(
+ void TCPv4Transport::fill_local_ip(
+         Locator& loc) const
+ {
+-    IPLocator::setIPv4(loc, ""127.0.0.1"");
+     loc.kind = LOCATOR_KIND_TCPv4;
++    IPLocator::setIPv4(loc, ""127.0.0.1"");
+ }
+
+ ip::tcp::endpoint TCPv4Transport::generate_endpoint(","In general, I suggest using the `kind()` getter inhereted from `TransportInterface`"
+9454,"@@ -48,8 +48,6 @@ namespace NLog.Layouts
+     /// </remarks>
+     [Layout(""Log4JXmlEventLayout"")]
+     [ThreadAgnostic]
+-    [ThreadSafe]
+-    [AppDomainFixedOutput]
+     public class Log4JXmlEventLayout : Layout, IIncludeContext
+     {
+         /// <summary>",Is the removal of `[AppDomainFixedOutput]` on purpose? (looks like a copy-paste...euh..remove error)
+9455,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (IAM) users.]
++//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (AWS IAM) users.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM)
+9456,"@@ -163,6 +163,7 @@ type APIV1POSTTransactionSignRequest struct {
+ 	WalletHandleToken string `json:""wallet_handle_token""`
+ 	// swagger:strfmt byte
+ 	Transaction    []byte `json:""transaction""`
++	PublicKey      crypto.PublicKey `json:""public_key""`
+ 	WalletPassword string `json:""wallet_password""`
+ }
+ ",gofmt everything pls
+9457,"@@ -243,6 +243,8 @@ type PodIOChaosStatus struct {
+ }
+
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+
+ // PodIOChaosList contains a list of PodIOChaos
+ type PodIOChaosList struct {","ditto, We do not need add this feature for PodXXXChaos"
+9458,"@@ -38,8 +38,9 @@ public class SampleNamer extends NameFormatterDelegator {
+   /**
+    * Returns the variable name of the service.
+    */
+-  public String getServiceVarName(String apiTypeName) {
+-    return localVarName(Name.lowerCamel(Name.upperCamel(apiTypeName).toLowerCamel(), ""service""));
++  public String getServiceVarName(String lowerCamelApiTypeName) {
++    return localVarName(
++        Name.lowerCamel(Name.lowerCamel(lowerCamelApiTypeName).toLowerCamel(), ""service""));
+   }
+
+   /**","There is a simpler way to do this: 1. Don't bother with the whole lowerCamelApiTypeName in SampleConfig 2. Use this code: `return localVarName(Name.upperCamel(apiTypeName, ""Service""));` Basically, each of the static creation methods of Name just need to have their arguments all be in the same casing, so you would just pass the upper camel string ""Service"" here."
+9459,"@@ -28,7 +28,7 @@ using EdgeData = util::NodeBasedDynamicGraph::EdgeData;
+
+ bool requiresAnnouncement(const EdgeData &from, const EdgeData &to)
+ {
+-    return !from.IsCompatibleTo(to);
++    return !from.CanCombineWith(to);
+ }
+
+ TurnAnalysis::TurnAnalysis(const util::NodeBasedDynamicGraph &node_based_graph,",Can you explain this change to me?
+9460,"@@ -19,7 +19,7 @@ const (
+ 	OpenEBSArtifacts  ArtifactSource = ""../artifacts/openebs-ci.yaml""
+ 	CStorPVCArtifacts ArtifactSource = ""../artifacts/cstor-pvc.yaml""
+ 	JivaPVCArtifacts  ArtifactSource = ""../artifacts/jiva-pvc.yaml""
+-	SingleReplicaSC   ArtifactSource = ""../artifacts/single-replica.yaml""
++	SingleReplicaSC   ArtifactSource = ""../artifacts/storageclass-1r.yaml""
+ 	CVRArtifact       ArtifactSource = ""../artifacts/cvr-schema.yaml""
+ 	CRArtifact        ArtifactSource = ""../artifacts/cr-schema.yaml""
+ )",let us rename the artifact to `storageclass-single-replica.yaml`
+9461,"@@ -5,7 +5,7 @@ using System;
+ using System.Runtime.CompilerServices;
+ using System.Runtime.InteropServices;
+
+-namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Networking
++namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking
+ {
+     public class LibuvFunctions
+     {","Nit: I should have done this before, but rename the file to LibuvFunctions.cs. Make sure no other files are misnamed."
+9462,"@@ -100,6 +100,7 @@ public class JavaBinCodec implements PushWriter {
+           MAP_ENTRY_ITER = 17,
+           ENUM_FIELD_VALUE = 18,
+           MAP_ENTRY = 19,
++          UUID = 20, // This is reserved to be used only in LogCodec
+           // types that combine tag + length (or other info) in a single byte
+           TAG_AND_LEN = (byte) (1 << 5),
+           STR = (byte) (1 << 5),",We should not add new types unless absolutely required. I'm not sure `UUID` is requires a new type
+9463,"@@ -461,3 +461,14 @@ class JUnitMirrorsManager(MirrorsManager):
+             links.append(default_link)
+         self.log.debug('Total mirrors: %d', len(links))
+         return links
++
++
++class JavaEnv(object):
++    def get_additional_classpath(self):
++        pass
++
++    def get_cp_from_files(self):
++        pass
++
++    def get_files_from_cp(self):
++        pass","If only Gatling uses it, can we skip introducing new entity for now? Looks like overkill..."
+9464,"@@ -54,6 +54,14 @@ type VersionsResponse struct {
+ 	Versions []string `json:""versions""`
+ }
+
++// Response to `GET /versions`
++// swagger:response VersionsResponse
++type versionsResponse struct {
++	//Versions Response
++	//in:body
++	Body *VersionsResponse
++}
++
+ // APIV1GETWalletsResponse is the response to `GET /v1/wallets`
+ // friendly:ListWalletsResponse
+ type APIV1GETWalletsResponse struct {",rename -> info ?
+9465,"@@ -135,6 +135,10 @@ class scheduler(Config):
+
+     prune_on_get_work = parameter.BoolParameter(default=False)
+
++    upstream_status_when_all = parameter.BoolParameter(default=False,
++                                                       config_path=dict(section='scheduler',
++                                                                        name='upstream-status-when-all'))
++
+
+ class Failures(object):
+     """"""","Remove the `config_path=dict(...)`, that is automatic!"
+9466,"@@ -23,9 +23,11 @@ function cleanupPlugins(resolve, reject) {
+     });
+   });
+
+-  axe.utils.toArray(document.querySelectorAll('frame, iframe')).forEach(function (frame) {
++  var flattenedTree = axe.utils.getFlattenedTree(document.body)
++
++  axe.utils.querySelectorAll(flattenedTree, 'iframe, frame').forEach(function (node) {
+     q.defer(function (res, rej) {
+-      return axe.utils.sendCommandToFrame(frame, {
++      return axe.utils.sendCommandToFrame(node.actualNode, {
+         command: 'cleanup-plugin'
+       }, res, rej);
+     });","I had to create a new flattened tree to support this functionality. The only other place in which a flattened tree is created is during the audit itself. Since `axe.cleanup` can be called at any arbitrary time, we can't reuse the same tree."
+9467,"@@ -52,9 +52,15 @@ public final class ConfigUtil {
+
+   private static final String MICROSERVICE_CONFIG_LOADER_KEY = ""cse-microservice-config-loader"";
+
++  private static ConfigModel model = new ConfigModel();
++
+   private ConfigUtil() {
+   }
+
++  public static void addConfigs(Map<String, Object> config) {
++    model.setConfig(config);
++  }
++
+   public static Object getProperty(String key) {
+     Object config = DynamicPropertyFactory.getBackingConfigurationSource();
+     return getProperty(config, key);","As this method is just set the internal cofigModel, it's better to use setConfigs instead of addConfigs."
+9468,"@@ -44,7 +44,13 @@ const (
+ // Timelimits for docker operations enforced above docker
+ const (
+ 	// ListContainersTimeout is the timeout for the ListContainers API.
+-	ListContainersTimeout   = 10 * time.Minute
++	ListContainersTimeout = 10 * time.Minute
++	// LoadImageTimeout is the timeout for the LoadImage API. It's set
++	// to much lower value than pullImageTimeout as it involves loading
++	// image from either a file or STDIN
++	// calls involved.
++	// TODO: Benchmark and re-evaluate this value
++	LoadImageTimeout        = 10 * time.Minute
+ 	pullImageTimeout        = 2 * time.Hour
+ 	createContainerTimeout  = 4 * time.Minute
+ 	startContainerTimeout   = 3 * time.Minute",Is this line needed?
+9469,"@@ -20,6 +20,8 @@ import (
+ 	""context""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
++	""github.com/google/knative-gcp/pkg/apis/events/v1beta1""
+ 	""net/url""
+ 	""os""
+ 	""time""",nit: import formatter
+9470,"@@ -118,9 +118,18 @@ namespace AutoRest.Swagger
+                 headerType = null;
+             }
+
++
+             // Response format
+             List<Stack<IModelType>> typesList = BuildResponses(method, headerType);
+
++            // if each of the responses have explicitly set their nullable property to false, we will have to consider it
++            bool isNonNullableReturnType = true;
++            _operation.Responses.Keys.ForEach(key =>
++            {
++                isNonNullableReturnType = isNonNullableReturnType && !(_operation.Responses[key].Extensions?.Get<bool>(""x-nullable"") ?? true);
++            });
++            method.IsXNullableReturnType = !(isNonNullableReturnType);
++
+             method.ReturnType = BuildMethodReturnType(typesList, headerType);
+             if (method.Responses.Count == 0)
+             {",can you use LINQ's `All` instead? Should be a side-effects free one liner with that.
+9471,"@@ -24,7 +24,9 @@
+ #include <inttypes.h>
+ #include <netdb.h>
+ #include <netinet/in.h>
++#ifndef __ANDROID__
+ #include <spawn.h>
++#endif
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <sys/socket.h>","Could you please remove `#include <spawn.h>` as a whole and see what happens? I believe that this is no longer needed; it was necessary when we called `posix_spawnp` directly, but now we use `h2o_spawnp`."
+9472,"@@ -94,10 +94,16 @@ func (in *fakeTwoPhaseChaos) GetStatus() *v1alpha1.ChaosStatus {
+ 	return &in.Status
+ }
+
++// IsDeleted returns whether this resource has been deleted
+ func (in *fakeTwoPhaseChaos) IsDeleted() bool {
+ 	return in.Deleted
+ }
+
++// IsPaused returns whether this resource is paused
++func (in *fakeTwoPhaseChaos) IsPaused() bool {
++	return false
++}
++
+ func (r fakeReconciler) Object() reconciler.InnerObject {
+ 	return &fakeTwoPhaseChaos{}
+ }",`whether this resource is paused` to `whether this resource has been paused` ? To keep same doc style.
+9473,"@@ -36,4 +36,11 @@ public interface PermissionManager {
+   public boolean hasPermission(final String imageTypeName, final String userId, final Type type)
+       throws ImageMgmtException;
+
++  /**
++   * Checks if the user has permission to manage high priority flows.
++   * @param userId
++   * @return
++   * @throws ImageMgmtException
++   */
++  public boolean hasPermission(final String userId) throws ImageMgmtException;
+ }",This method is validating permission for hp flow. Can you please rename this method to convey the same?
+9474,"@@ -102,9 +102,7 @@ class MongoNetworkError extends MongoError {
+     super(message);
+     this.name = 'MongoNetworkError';
+
+-    if (options && options.beforeHandshake === true) {
+-      this[kBeforeHandshake] = true;
+-    }
++    this[kBeforeHandshake] = !!(options && options.beforeHandshake === true);
+   }
+ }
+ ","Just to confirm, do we actually want to explicitly set the `kBeforeHandshake` symbol on all network errors regardless of whether the options/property is passed in?"
+9475,"@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) {
+ 	r.dirtyIfaces.Add(ifaceName)
+ }
+
++func (r *RouteTable) QueueResync() {
++	r.logCxt.Info(""Queueing a resync."")
++	r.inSync = false
++}
++
+ func (r *RouteTable) Apply() error {
+ 	if !r.inSync {
+ 		links, err := r.dataplane.LinkList()",How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.
+9476,"@@ -172,9 +172,12 @@ func (g *gen) frame() []byte {
+ 		}
+ 		sort.Strings(imps)
+ 		for _, path := range imps {
+-			// TODO(light): Omit the local package identifier if it matches
+-			// the package name.
+-			fmt.Fprintf(&buf, ""\t%s %q\n"", g.imports[path], path)
++			// Omit the local package identifier if it matches the package name.
++			if g.imports[path] == path {
++				fmt.Fprintf(&buf, ""\t%q\n"", path)
++			} else {
++				fmt.Fprintf(&buf, ""\t%s %q\n"", g.imports[path], path)
++			}
+ 		}
+ 		buf.WriteString("")\n\n"")
+ 	}","While this is commonly correct, the more reliable check is to get the package's identifier from the type checker and check those for equality. The information should be there, just another matter of plumbing it."
+9477,"@@ -168,6 +168,9 @@ def to_full_resource_name(full_parent_name, resource_type_name):
+     Returns:
+         str: full_resource_name of the child
+     """"""
++    # Strip out the fake composite root parent from the full resource name.
++    if full_parent_name == 'composite_root/root/':
++        return '{}/'.format(resource_type_name)
+
+     return '{}{}/'.format(full_parent_name, resource_type_name)
+ ","Just to clarify, should this be 'composite_root/root/' or 'composite_root/'?"
+9478,"@@ -288,5 +288,6 @@ func (psb *PubSubBase) DeletePubSub(ctx context.Context, pubsubable duck.PubSuba
+ 		return fmt.Errorf(""failed to delete PullSubscription: %w"", err)
+ 	}
+ 	status.SinkURI = nil
++	status.SubscriptionID = """"
+ 	return nil
+ }",Any reason not to move it to after line 281? These are all pubsub related fields IIUC.
+9479,"@@ -3,7 +3,7 @@ import { both, gt } from 'ramda';
+ import isNumber from './isNumber';
+
+ /**
+- * Checks if value is a negative `Number` primitive or object.
++ * Checks if value is a negative `Number` primitive or object. Zero is not considered negative.
+  *
+  * @func isNegative
+  * @memberOf RA",Checks if value is a negative `Number` primitive or object. Zero is considered neither positive nor negative.
+9480,"@@ -285,6 +285,11 @@ func (h Handler) buildEnv(r *http.Request, rule Rule, fpath string) (map[string]
+ 	// Retrieve name of remote user that was set by some downstream middleware such as basicauth.
+ 	remoteUser, _ := r.Context().Value(httpserver.RemoteUserCtxKey).(string)
+
++	requestScheme := ""http""
++	if r.TLS != nil {
++		requestScheme = ""https""
++	}
++
+ 	// Some variables are unused but cleared explicitly to prevent
+ 	// the parent environment from interfering.
+ 	env = map[string]string{","Just a nit, but remove the empty line here. :)"
+9481,"@@ -385,6 +385,16 @@ func (p *Package) addFiles(cu *apb.CompilationUnit, root, base string, names []s
+ 			Corpus: p.ext.DefaultCorpus,
+ 			Path:   trimmed,
+ 		}
++
++		if p.ext.Rules != nil {
++			v2, ok := p.ext.Rules.Apply(trimmed)
++			if ok {
++				vn.Corpus = v2.Corpus
++				vn.Root = v2.Root
++				vn.Path = v2.Path
++			}
++		}
++
+ 		if vn.Corpus == """" {
+ 			// If no default corpus is specified, use the package's corpus for each of
+ 			// its files.  The package corpus is based on the rules in",A `GoPackageInfo` details message should be added to the `CompilationUnit_FileInput` to ensure the import path remains the same.
+9482,"@@ -1,10 +1,10 @@
+ package com.fsck.k9.activity;
+
+-import android.app.ListActivity;
+ import android.os.Bundle;
+ import android.view.KeyEvent;
+ import android.view.MotionEvent;
+ import android.widget.AdapterView;
++import android.widget.ListAdapter;
+ import android.widget.ListView;
+
+ import com.fsck.k9.K9;",Please don't create new fields with the `m` prefix. I'd rather mix than introduce more of these.
+9483,"@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
+
+     useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    cpuCircuitBreakerEnabled = getBool(""circuitBreaker/cpuCircuitBreakerEnabled"", false);
++    memoryCircuitBreakerEnabled = getBool(""circuitBreaker/memoryCircuitBreakerEnabled"", false);
+     memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 95);
+
+-    validateMemoryBreakerThreshold();
++    cpuCircuitBreakerThreshold = getInt(""circuitBreaker/cpuCircuitBreakerThreshold"", 95);
++
++    validateCircuitBreakerThresholds();
+
+     filterCacheConfig = CacheConfig.getConfig(this, ""query/filterCache"");
+     queryResultCacheConfig = CacheConfig.getConfig(this, ""query/queryResultCache"");",Can we please simplify these names? they are awfully verbose and repeating the parts that are already unique and obvious.
+9484,"@@ -241,7 +241,7 @@ public class RecipientPresenter implements PermissionPingCallback {
+             boolean alreadyVisible = recipientMvpView.isBccVisible();
+             boolean singleBccRecipientFromAccount =
+                     bccRecipients.length == 1 && bccRecipients[0].toString().equals(bccAddress);
+-            recipientMvpView.setBccVisibility(alreadyVisible || singleBccRecipientFromAccount);
++            recipientMvpView.setBccVisibility(alreadyVisible || !singleBccRecipientFromAccount);
+             updateRecipientExpanderVisibility();
+         }
+     }","Flipped the logic here, was this actually wrong before?"
+9485,"@@ -336,7 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
+-	bool nat_lvl1_drop = 0;
++	int res = 0;
+
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.",I think (a) should be initialized to `NAT_FE_LOOKUP_ALLOW` and (b) it should be probably the first thing in `calico_v4_nat_lookup2`
+9486,"@@ -36,7 +36,7 @@ public class TestManyPointsInOldIndex extends LuceneTestCase {
+ //
+ // Compile:
+ //   1) temporarily remove 'extends LuceneTestCase' above (else java doesn't see our static void main)
+-//   2) ant compile-test
++//   2) gradlew testClasses
+ //
+ // Run:
+ //   1) java -cp ../build/backward-codecs/classes/test:../build/core/classes/java org.apache.lucene.index.TestManyPointsInOldIndex","I'd look as to what this class actually does... seems weird. Classpath below (under ""run"") is wrong for gradle."
+9487,"@@ -17,6 +17,7 @@
+ package algod
+
+ import (
++	""github.com/algorand/go-algorand/data/basics""
+ 	""path/filepath""
+ 	""testing""
+ ",Group w/ algorand imports
+9488,"@@ -28,12 +28,14 @@ package com.salesforce.androidsdk.store;
+
+ import java.util.ArrayList;
+ import java.util.List;
++import java.util.Locale;
+
+ import net.sqlcipher.database.SQLiteDatabase;
+
+ import org.json.JSONException;
+ import org.json.JSONObject;
+
++import android.annotation.SuppressLint;
+ import android.content.Context;
+ import android.test.InstrumentationTestCase;
+ import android.util.Log;",I don't think this import is being used.
+9489,"@@ -5,7 +5,7 @@ const AnyKind = ""*** any procedure kind ***""
+ // Pattern represents an operator tree pattern
+ // It can match itself against a query plan
+ type Pattern interface {
+-	Root() ProcedureKind
++	Roots() []ProcedureKind
+ 	Match(Node) bool
+ }
+ ",This is an interesting way to do this. I like it. An alternative way to implement a multiple kind pattern was to have this return `AnyKind` and then have match perform an actual check to see if it matches.
+9490,"@@ -373,8 +373,9 @@ class SonataMediaExtension extends Extension implements PrependExtensionInterfac
+         }
+
+         if ($container->hasDefinition('sonata.media.cdn.fallback') && isset($config['cdn']['fallback'])) {
++            // NEXT_MAJOR: Do not fallback to master
+             $container->getDefinition('sonata.media.cdn.fallback')
+-                ->replaceArgument(0, new Reference($config['cdn']['fallback']['master']))
++                ->replaceArgument(0, new Reference($config['cdn']['fallback']['primary'] ?? $config['cdn']['fallback']['master']))
+                 ->replaceArgument(1, new Reference($config['cdn']['fallback']['fallback']));
+         } else {
+             $container->removeDefinition('sonata.media.cdn.fallback');",You did not check this code
+9491,"@@ -31,6 +31,10 @@ func EncodeValues(vals []*Value) ([]byte, error) {
+ // DecodeValues decodes an array of abi values from the given buffer, using the
+ // provided type information.
+ func DecodeValues(data []byte, types []Type) ([]*Value, error) {
++	if len(types) > 0 && len(data) == 0 {
++		return nil, fmt.Errorf(""expected %d parameters, but got 0"", len(types))
++	}
++
+ 	if len(data) == 0 {
+ 		return nil, nil
+ 	}","This was necessary due to a bug uncovered in testing. If an actor method which requires params is called without any params at all, not returning an error here causes a panic."
+9492,"@@ -738,6 +738,7 @@ const htmlElms = {
+       'dialog',
+       'document',
+       'feed',
++			'group',
+       'log',
+       'main',
+       'marquee',","Thanks for the pr. Would you be able to edit the file to use spaces rather than tabs? Normally we have prettier run on commit, but I guess file patches don't do that."
+9493,"@@ -111,7 +111,6 @@ public class TestHiveClientPool {
+             ""Another meta exception"", () -> clients.run(client -> client.getTables(""default"", ""t"")));
+   }
+
+-  @Test
+   public void testConnectionFailureRestoreForMetaException() throws Exception {
+     HiveMetaStoreClient hmsClient = newClient();
+ ",Is it intentional that we removed this annotation?
+9494,"@@ -42,6 +42,18 @@ namespace AutoRest.Swagger.Validation
+         /// </summary>
+         public override Category Severity => Category.Warning;
+
++        /// <summary>
++        /// What kind of open api document type this rule should be applied to
++        /// </summary>
++        public override ServiceDefinitionDocumentType ServiceDefinitionDocumentType => ServiceDefinitionDocumentType.ARM;
++
++        /// <summary>
++        /// When to apply the validation rule, before or after it has been merged as a part of
++        /// its merged document as specified in the corresponding '.md' file
++        /// By default consider all rules to be applied for After only
++        /// </summary>
++        public override ServiceDefinitionDocumentState ValidationRuleMergeState => ServiceDefinitionDocumentState.Individual;
++
+         public override IEnumerable<ValidationMessage> GetValidationMessages(Dictionary<string, Schema> definitions, RuleContext context)
+         {
+             var violatingModels = definitions.Where(defPair=>defPair.Value.Properties?.Values.Any(schema => schema.Enum != null)??false);",should be general?
+9495,"@@ -153,7 +153,7 @@ namespace Nethermind.Blockchain
+         private void LoadBestKnown()
+         {
+             long headNumber = Head?.Number ?? _syncConfig.PivotNumberParsed;
+-            long left = Math.Max(_syncConfig.PivotNumberParsed, headNumber);
++            long left = Math.Max(LowestInsertedHeader?.Number ?? 0, headNumber);
+             long right = headNumber + BestKnownSearchLimit;
+
+             bool LevelExists(long blockNumber)","if lowest inserted header is non null non zero then pivot should be higher and a better best known on the left. maybe Head?.Number ?? Math.Max(Pivot, LowestInsertedHeader))?"
+9496,"@@ -0,0 +1,14 @@
++package azkaban.execapp.fake;
++
++import azkaban.execapp.AzkabanExecutorServer;
++import azkaban.execapp.jmx.JmxJobMBeanManager;
++import azkaban.utils.Props;
++
++public class FakeApp extends AzkabanExecutorServer {
++
++  public FakeApp() throws Exception {
++    super(new Props(), null, null, new FakeServer(), null);
++    JmxJobMBeanManager.getInstance().initialize(new Props());
++  }
++
++}",Is a FakeApp class needed? Can test use a Mockito mock instance instead?
+9497,"@@ -1020,7 +1020,8 @@ VariableSP SymbolFilePDB::ParseVariableForPDBData(
+
+   var_sp = std::make_shared<Variable>(
+       var_uid, var_name.c_str(), mangled_cstr, type_sp, scope, context_scope,
+-      ranges, &decl, location, is_external, is_artificial, is_static_member);
++      ranges, &decl, location, is_external, is_artificial, is_static_member,
++      is_constant);
+   var_sp->SetLocationIsConstantValueData(is_constant);
+
+   m_variables.insert(std::make_pair(var_uid, var_sp));",We should make this an enum.
+9498,"@@ -15,7 +15,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+         private const string TestRuleId = ""TST0001"";
+         private const string TestFormatSpecifier = ""testFormatSpecifier"";
+         private const string TestAnalysisTarget = @""C:\dir\file"";
+-        private static readonly string DisplayedTarget = TestAnalysisTarget.Replace('\\', '/');
+
+         private static readonly RuleDescriptor TestRule = new RuleDescriptor(
+             TestRuleId,","@lgolding, note I fixed the forward slashes that appeared in the VS output (which was certainly not by design)."
+9499,"@@ -724,7 +724,7 @@ class ElementPlot(BokehPlot, GenericElementPlot):
+         else:
+             self.handles['xaxis'] = plot.xaxis[0]
+             self.handles['x_range'] = plot.x_range
+-            self.handles['y_axis'] = plot.yaxis[0]
++            self.handles['yaxis'] = plot.yaxis[0]
+             self.handles['y_range'] = plot.y_range
+         self.handles['plot'] = plot
+ ",Minor unrelated fix that snuck in.
+9500,"@@ -36,8 +36,8 @@ import com.salesforce.androidsdk.smartstore.store.QuerySpec;
+ import com.salesforce.androidsdk.smartstore.store.QuerySpec.QueryType;
+ import com.salesforce.androidsdk.smartstore.store.SmartStore;
+ import com.salesforce.androidsdk.smartstore.store.SmartStore.SmartStoreException;
+-import com.salesforce.androidsdk.smartstore.store.StoreCursor;
+ import com.salesforce.androidsdk.smartstore.store.SoupSpec;
++import com.salesforce.androidsdk.smartstore.store.StoreCursor;
+ import com.salesforce.androidsdk.smartstore.ui.SmartStoreInspectorActivity;
+
+ import net.sqlcipher.database.SQLiteDatabase;",Took the opportunity to fix the import ordering.
+9501,"@@ -130,9 +130,13 @@ class XRDCalculator(AbstractDiffractionPatternCalculator):
+         """"""
+         if isinstance(wavelength, float):
+             self.wavelength = wavelength
+-        else:
++        elif isinstance(wavelength, int):
++            self.wavelength = float(wavelength)
++        elif isinstance(wavelength, str):
+             self.radiation = wavelength
+             self.wavelength = WAVELENGTHS[wavelength]
++        else:
++            raise TypeError(""'wavelength' must be either of: float, int or str"")
+         self.symprec = symprec
+         self.debye_waller_factors = debye_waller_factors or {}
+ ",I think int and float can be handled in one if statement. The subsequent calculations don't really care whether it si a float or an int.
+9502,"@@ -134,14 +134,14 @@ func TestDelayedCancellationEnabled(t *testing.T) {
+ 	t.Parallel()
+
+ 	ctx, cancel := makeContextWithDelayedCancellation(t)
+-	EnableDelayedCancellationWithGracePeriod(ctx, 15*time.Millisecond)
++	EnableDelayedCancellationWithGracePeriod(ctx, 50*time.Millisecond)
+
+ 	cancel()
+
+ 	select {
+ 	case <-ctx.Done():
+ 		t.Fatalf(""Cancellation is not delayed"")
+-	case <-time.After(10 * time.Millisecond):
++	case <-time.After(20 * time.Millisecond):
+ 	}
+
+ 	<-ctx.Done()",Can we keep this at 10 to reduce the probability of a flake? Or are you afraid this would be too likely to give a false positive if delayed cancellation is every actually broken?
+9503,"@@ -15,9 +15,14 @@
+ package gcsblob
+
+ import (
++	""context""
++	""fmt""
++	""net/http""
+ 	""strings""
+ 	""testing""
+
++	""github.com/google/go-x-cloud/gcp""
++
+ 	""google.golang.org/api/googleapi""
+ )
+ ",nit: add a blank line under this.
+9504,"@@ -67,6 +67,7 @@ var (
+ 	bytecodeFlag = flag.NewStringVarP(""bytecode"", ""b"", """", ""set the byte code"")
+ 	yesFlag      = flag.BoolVarP(""assume-yes"", ""y"", false, ""answer yes for all confirmations"")
+ 	passwordFlag = flag.NewStringVarP(""password"", ""P"", """", ""input password for account"")
++	chainIDFlag  = flag.NewUint64VarP(""chainID"", """", 0, ""set chainID for action"")
+ )
+
+ // ActionCmd represents the action command",no need to add this flag query the endpoint set-up to determine the chainID
+9505,"@@ -0,0 +1,9 @@
++if (node.querySelector('input[type=""submit""], img[type=""submit""], button[type=""submit""]')) {
++  return true;
++}
++
++if (!node.querySelectorAll(':not(textarea)').length) {
++  return false;
++}
++
++return undefined;","Here is a few scenario - What if there is a submit button with in a form, but is always disabled?"
+9506,"@@ -1498,6 +1498,7 @@ const instr_info_t * const op_instr[] =
+ #define Wed TYPE_W, OPSZ_16_vex32_evex64
+ #define Vex TYPE_V, OPSZ_16_vex32_evex64
+ #define Wex TYPE_W, OPSZ_16_vex32_evex64
++#define Weh_x TYPE_W, OPSZ_half_16_vex32_evex64
+
+ /* my own codes
+  * size m = 32 or 16 bit depending on addr size attribute",wrong code: should be `Wh_e`
+9507,"@@ -582,10 +582,11 @@ static void makeLabelTag (vString *const label)
+
+ static lineType getLineType (void)
+ {
+-	vString *label = vStringNew ();
++	static vString *label = NULL;
+ 	int column = 0;
+ 	lineType type = LTYPE_UNDETERMINED;
+
++	label = vStringNewOrClear (label);
+ 	do  /* read in first 6 ""margin"" characters */
+ 	{
+ 		int c = getcFromInputFile ();","This leads to a small ""leak"" (mostly theoretical only though), if we don't want it this could be created in `initialize()` and destroyed in `finalize()`."
+9508,"@@ -25,6 +25,8 @@ import (
+ )
+
+ const (
++	// BuildIDOSEnv is the os env name to get build id
++	BuildIDOSEnv           = ""BUILD_ID""
+ 	translateFailedPrefix  = ""TranslateFailed""
+ 	privacyInfoReplacement = ""[Privacy Info]""
+ )","BuildIDOSEnvVarName or similar, otherwise it sounds it's actually holding actual value of env var"
+9509,"@@ -103,7 +103,7 @@ class SparkReader:
+         """"""
+
+         with self.app.app_context():
+-
++            current_app.logger.info('Spark consumer has started!')
+             while True:
+                 self.init_rabbitmq_connection()
+                 self.incoming_ch = utils.create_channel_to_consume(","I like this standard ""container has started"" message. Should we have a ""container exited because FOO"" message as well?"
+9510,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+
+ import com.google.common.collect.Maps;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.
+9511,"@@ -0,0 +1,19 @@
++const { useHandsontable } = require('./use-handsontable');
++const { getDependencies } = require('./dependencies');
++const { register } = require('./register');
++
++if (module) {
++  module.exports = {
++    useHandsontable,
++    instanceRegister: register,
++    getDependencies,
++    applyToWindow: () => {
++      /* eslint-disable no-restricted-globals */
++      if ((typeof window !== 'undefined')) {
++        window.useHandsontable = useHandsontable;
++        window.instanceRegister = register;
++      }
++      /* eslint-enable no-restricted-globals */
++    }
++  };
++}","We have Vue application at our disposal, and have examples container implemented as component. Shouldn't helpers be imported instead being global? Not the best practice in Vue app I guess"
+9512,"@@ -1221,3 +1221,14 @@ type NoMergedMDError struct {
+ func (e NoMergedMDError) Error() string {
+ 	return fmt.Sprintf(""No MD yet for TLF %s"", e.tlf)
+ }
++
++// DiskCacheClosedError indicates that the disk cache has been
++// closed, and thus isn't accepting any more operations.
++type DiskCacheClosedError struct {
++	op string
++}
++
++// Error implements the error interface for DiskCacheClosedError.
++func (e DiskCacheClosedError) Error() string {
++	return fmt.Sprintf(""Error performing %s operation: the disk cache is closed."", e.op)
++}",No trailing punctuation in the error message.
+9513,"@@ -447,5 +447,6 @@ public class Notifier
+ 			}
+ 		}
+ 		clip.start();
++		clip.close();
+ 	}
+ }",tested? seems like it could break
+9514,"@@ -77,9 +77,10 @@ public final class IndexUpgrader {
+   public static void main(String[] args) throws IOException {
+     parseArgs(args).upgrade();
+   }
+-
++
++  /** Parse arguments. */
+   @SuppressForbidden(reason = ""System.out required: command line tool"")
+-  static IndexUpgrader parseArgs(String[] args) throws IOException {
++  public static IndexUpgrader parseArgs(String[] args) throws IOException {
+     String path = null;
+     boolean deletePriorCommits = false;
+     InfoStream out = null;",This have to be public because the renamed o.a.l.backward_index.TestBackwardsCompatibility refers this.
+9515,"@@ -286,7 +286,7 @@ func TestApplicationsUpgradeOverGossip(t *testing.T) {
+ 	fixture.SetupNoStart(t, filepath.Join(""nettemplates"", ""TwoNodes100SecondTestUnupgradedProtocol.json""))
+
+ 	// for the primary node, we want to have a different consensus which always enables applications.
+-	primaryNodeUnupgradedProtocol := consensus[consensusTestFastUpgrade(protocol.ConsensusFuture)]
++	primaryNodeUnupgradedProtocol := consensus[consensusTestFastUpgrade(protocol.ConsensusCurrentVersion)]
+ 	primaryNodeUnupgradedProtocol.ApprovedUpgrades = make(map[protocol.ConsensusVersion]uint64)
+ 	primaryNodeUnupgradedProtocol.ApprovedUpgrades[consensusTestFastUpgrade(protocol.ConsensusFuture)] = 0
+ 	consensus[consensusTestUnupgradedProtocol] = primaryNodeUnupgradedProtocol","unrelated to your change, but I don't think that this is correct anymore. We also seen to remove application support from `primaryNodeUnupgradedProtocol` for the test to be correct."
+9516,"@@ -440,6 +440,19 @@ func mergeConfigSrcs(cfg, userCfg *aws.Config, envCfg envConfig, sharedCfg share
+ 			cfg.Credentials = credentials.NewStaticCredentialsFromCreds(
+ 				envCfg.Creds,
+ 			)
++
++		} else if len(envCfg.WebIdentityTokenFilePath) > 0 {
++			// handles assume role via OIDC token. This should happen before any other
++			// assume role call.
++			sessionName := envCfg.IAMRoleSessionName
++			if len(sessionName) == 0 {
++				sessionName = sharedCfg.AssumeRole.RoleSessionName
++			}
++
++			cfg.Credentials = stscreds.NewWebIdentityCredentials(&Session{
++				Config:   cfg,
++				Handlers: handlers.Copy(),
++			}, envCfg.WebIdentityRoleARN, sessionName, envCfg.WebIdentityTokenFilePath)
+ 		} else if envCfg.EnableSharedConfig && len(sharedCfg.AssumeRole.RoleARN) > 0 && sharedCfg.AssumeRoleSource != nil {
+ 			cfgCp := *cfg
+ 			cfgCp.Credentials = credentials.NewStaticCredentialsFromCreds(","Should this also validate that the RoleArn env var is provided, or just let the creds fail?"
+9517,"@@ -20,10 +20,12 @@
+
+ package transport
+
++import ""github.com/opentracing/opentracing-go""
++
+ // Deps is the interface of any object useful for passing injected
+ // dependencies into inbound and outbound transports.
+ type Deps interface {
+-	// Tracer() opentracing.Tracer
++	Tracer() opentracing.Tracer
+ }
+
+ // NoDeps is a no-op implementation of Deps","fwiw, in tchannel-go I've implemented a similar method on TChannel that either returns a Tracer instance it was initialized with, or returns `opentracing.GlobalTracer()`, which by default happens to return a singleton instance of `NoopTracer`. In Go the use of global variables is not frowned upon as say in Java, so this pattern allows minimal work to enable tracing in a service, one just needs to store a real tracer in the global variable, e.g. via `opentracing.InitGlobalTracer(someTracerImpl)`, while the instances of TChannel do not need to be explicitly given any tracer since they will default to that global."
+9518,"@@ -135,6 +135,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         self.assertEqual(kidx.name, ""renamed"")
+         self.assert_eq(kidx, pidx)
+
++        expected_error_message = ""Series.name must be a hashable type""
++        with self.assertRaisesRegex(TypeError, expected_error_message):
++            kser.name = [""0"", ""1""]
++
+     def test_rename_method(self):
+         # Series name
+         pser = pd.Series([1, 2, 3, 4, 5, 6, 7], name=""x"")","Shall we also add `ks.Series([1, 2, 3], name=[""0"", ""1""])`?"
+9519,"@@ -45,7 +45,7 @@ public class PermissioningJsonRpcRequestFactory {
+
+   Request<?, AddNodeResponse> addNodesToWhitelist(final List<URI> enodeList) {
+     return new Request<>(
+-        ""perm_addNodesToWhitelist"",
++        ""perm_addNodesToAllowlist"",
+         Collections.singletonList(enodeList),
+         web3jService,
+         AddNodeResponse.class);",Can this be updated?
+9520,"@@ -89,14 +89,7 @@ final class AddProviderCompilerPass implements CompilerPassInterface
+                 $definition = $container->getDefinition($id);
+
+                 foreach ($context['formats'] as $format => $formatConfig) {
+-                    $formatConfig['quality'] = $formatConfig['quality'] ?? 80;
+-                    $formatConfig['format'] = $formatConfig['format'] ?? 'jpg';
+-                    $formatConfig['height'] = $formatConfig['height'] ?? null;
+-                    $formatConfig['constraint'] = $formatConfig['constraint'] ?? true;
+-                    $formatConfig['resizer'] = $formatConfig['resizer'] ?? false;
+-
+-                    $formatName = sprintf('%s_%s', $name, $format);
+-                    $definition->addMethodCall('addFormat', [$formatName, $formatConfig]);
++                    $definition->addMethodCall('addFormat', [sprintf('%s_%s', $name, $format), $formatConfig]);
+                 }
+             }
+         }","this change is to avoid duplication on the defaults. They are already on the Configuration class. (Also I removed the false default, because the admin format does not have it). This is also produces the rest of the diff, changes from false to null."
+9521,"@@ -46,6 +46,8 @@ func (pc *podConfigurator) connectInterfaceToOVSAsync(ifConfig *interfacestore.I
+ 	go func() {
+ 		klog.Infof(""Waiting for interface %s to be created"", hostIfAlias)
+ 		err := wait.PollImmediate(time.Second, 60*time.Second, func() (bool, error) {
++			containerAccess.lockContainer(containerID)
++			defer containerAccess.unlockContainer(containerID)
+ 			curEp, ok := pc.ifConfigurator.getEndpoint(ovsPortName)
+ 			if !ok {
+ 				return true, fmt.Errorf(""failed to find HNSEndpoint %s"", ovsPortName)","What does it protect from? If it's subsequent CNI calls, won't containerID be different from the first one? or it's different in containerd? we use `getInfraContainer` to get the lock identity in CNIAdd. And this reminds me what if the first CNI call and the subquent ones run into connectInterfaceToOVSAsync, will duplicate ports being created or it has been handled?"
+9522,"@@ -0,0 +1,19 @@
++<?php
++
++namespace Shopsys\FrameworkBundle\Model\Advert\Exception;
++
++use Exception;
++
++class AdvertPositionNotKnownException extends Exception implements AdvertException
++{
++    public function __construct(string $positionName, array $knownPositionsNames, Exception $previous = null)
++    {
++        $message = sprintf(
++            'Unknown advert position name ""%s"". Known names are %s.',
++            $positionName,
++            implode('"", ""', $knownPositionsNames)
++        );
++
++        parent::__construct($message, 0, $previous);
++    }
++}","In Exceptions' constructors, we always add a optional last parameter `Exception $previous = null`. In the past, this was (still is?) a part of the coding standards."
+9523,"@@ -90,6 +90,15 @@ const connectionActivityMonitorInterval = time.Minute * 3
+ // we discard the connection.
+ const maxPeerInactivityDuration = time.Minute * 5
+
++// maxMessageQueueDuration is the maximum amount of time a message is allowed to be waiting
++// in the various queues before being sent. Once that deadline has reached, sending the message
++// is pointless, as it's too stale to be of any value
++const maxMessageQueueDuration = time.Second * 25
++
++// slowWritingPeerMonitorInterval is the interval at which we peek on the connected peers to
++// verify that their current outgoing message is not being blocked for too long.
++const slowWritingPeerMonitorInterval = time.Second * 5
++
+ var networkIncomingConnections = metrics.MakeGauge(metrics.NetworkIncomingConnections)
+ var networkOutgoingConnections = metrics.MakeGauge(metrics.NetworkOutgoingConnections)
+ ","I think more idiomatic (and consistent with elsewhere in our code base, and more natural to read as ""25 seconds"") is `25 * time.Second`"
+9524,"@@ -127,6 +127,7 @@ func NewDecoder(opts ...func(*Decoder)) *Decoder {
+ 	d := &Decoder{
+ 		MarshalOptions: MarshalOptions{
+ 			SupportJSONTags: true,
++			SupportYAMLTags: true,
+ 		},
+ 	}
+ 	for _, o := range opts {","Enabling `YAML` by default would be a breaking change in behavior for some applications if the struct's used by that application already include YAML tags, but their application has been (un)marshaling DynamoDB Attributes based on the struct name."
+9525,"@@ -131,7 +131,7 @@ public class DriverCommandExecutor extends HttpCommandExecutor implements Closea
+         Thread.currentThread().interrupt();
+         throw new WebDriverException(""Timed out waiting for driver server to stop."", e);
+       } finally {
+-        executorService.shutdownNow();
++        executorService.shutdown();
+       }
+
+     } else {","For the command executor, which in turn, uses the HTTP client to talk to the WebDriver, the client might have high-timeout values set, so the shutdown can take a long time if we wait for it to complete, especially if multiple-long running threads are there. I think it might be a good idea in general to couple the shutdown() with `awaitTermination()` with a timeout, if the ongoing tasks do not complete within that timeout then call `shutdownNow()`. What do you think?"
+9526,"@@ -38,7 +38,7 @@ public abstract class HiveMetastoreTest {
+   @BeforeClass
+   public static void startMetastore() throws Exception {
+     HiveMetastoreTest.metastore = new TestHiveMetastore();
+-    metastore.start();
++    metastore.start(new HiveConf(HiveMetastoreTest.class));
+     HiveMetastoreTest.hiveConf = metastore.hiveConf();
+     HiveMetastoreTest.metastoreClient = new HiveMetaStoreClient(hiveConf);
+     String dbPath = metastore.getDatabasePath(DB_NAME);",Is this change needed? `start()` is still defined and uses `HiveMetastoreTest.class`. The only difference is that this doesn't pass a `Configuration` and the parameterless `start` passes `new Configuration()`.
+9527,"@@ -27,6 +27,7 @@ type stakingCommand struct {
+ 	stakingV1   Protocol
+ 	stakingV2   *staking.Protocol
+ 	candIndexer *CandidateIndexer
++	sr          protocol.StateReader
+ }
+
+ // NewStakingCommand creates a staking command center to manage staking committee and new native staking",I think it is weird to store sr in protocol struct
+9528,"@@ -7308,6 +7308,16 @@ NATable * NATableDB::get(const ExtendedQualName* key, BindWA* bindWA, NABoolean
+      }
+   }
+
++  // the reload cqd will be set during aqr after compiletime and runtime
++  // timestamp mismatch is detected.
++  // If set, reload hive metadata.
++  if ((cachedNATable->isHiveTable()) &&
++      (CmpCommon::getDefault(HIVE_DATA_MOD_CHECK) == DF_ON) &&
++      (CmpCommon::getDefault(TRAF_RELOAD_NATABLE_CACHE) == DF_ON))
++    {
++      removeEntry = TRUE;
++    }
++
+   //Found in cache.  If that's all the caller wanted, return now.
+   if ( !removeEntry && findInCacheOnly )
+      return cachedNATable;",Will this cause a reload _all_ NATable information? It's too bad we don't have some way to limit the reload to just the tables that have a metadata mismatch.
+9529,"@@ -111,6 +111,7 @@ var opDocList = []stringString{
+ 	{""app_global_del"", ""delete key A from a global state of the current application""},
+ 	{""asset_holding_get"", ""read from account specified by Txn.Accounts[A] and asset B holding field X (imm arg) => {0 or 1 (top), value}""},
+ 	{""asset_params_get"", ""read from asset Txn.ForeignAssets[A] params field X (imm arg) => {0 or 1 (top), value}""},
++	{""assert"", ""immediately fail unless value X is not zero""},
+ }
+
+ var opDocByName map[string]string",'fail unless X is a non-zero number' it will also fail if X is a byte string
+9530,"@@ -1447,10 +1447,13 @@ class ElementPlot(BokehPlot, GenericElementPlot):
+         """"""
+         Resets RangeXY streams if norm option is set to framewise
+         """"""
+-        if self.overlaid:
++        # Temporarily reverts this fix (see https://github.com/holoviz/holoviews/issues/4396)
++        # This fix caused PlotSize change events to rerender
++        # rasterized/datashaded with the full extents which was wrong
++        if self.overlaid or True:
+             return
+         for el, callbacks in self.traverse(lambda x: (x.current_frame, x.callbacks)):
+-            if el is None:
++            if el is None:W
+                 continue
+             for callback in callbacks:
+                 norm = self.lookup_options(el, 'norm').options",SyntaxError I think
+9531,"@@ -5012,6 +5012,9 @@ TEST_F(VkLayerTest, ValidateGeometryNV) {
+         vkCreateAccelerationStructureNV(m_device->handle(), &as_create_info, nullptr, &as);
+         m_errorMonitor->VerifyFound();
+     }
++#if 0
++    // XXX Subtest disabled because this is the wrong VUID.
++    // No VUIDs currently exist to require memory is bound (spec bug).
+     // Invalid vertex buffer - no memory bound.
+     {
+         VkGeometryNV geometry = valid_geometry_triangles;",I've filed an internal spec issue to add these missing VUs.
+9532,"@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver;
+ import org.openqa.selenium.WebElement;
+
+ import java.io.IOException;
++import java.io.UncheckedIOException;
+ import java.net.URL;
+ import java.nio.charset.StandardCharsets;
+ import java.util.ArrayList;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.
+9533,"@@ -24,16 +24,11 @@ import java.math.BigInteger;
+ import java.nio.ByteBuffer;
+ import java.time.Instant;
+ import java.time.ZoneOffset;
++import java.util.Arrays;
+ import java.util.List;
+ import java.util.Map;
+-import org.apache.flink.table.data.ArrayData;
+-import org.apache.flink.table.data.DecimalData;
+-import org.apache.flink.table.data.GenericRowData;
+-import org.apache.flink.table.data.MapData;
+-import org.apache.flink.table.data.RawValueData;
+-import org.apache.flink.table.data.RowData;
+-import org.apache.flink.table.data.StringData;
+-import org.apache.flink.table.data.TimestampData;
++
++import org.apache.flink.table.data.*;
+ import org.apache.iceberg.MetadataColumns;
+ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.parquet.ParquetValueReader;","In iceberg, we usually don't use `*` to import package, it's more clear to import the specify package one by one."
+9534,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+
+ import com.google.common.collect.Maps;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.
+9535,"@@ -18,7 +18,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure
+             // There's no reason to stop timing the write after the connection is closed.
+             var oneBufferSize = maxResponseBufferSize.Value;
+             var maxBufferedBytes = oneBufferSize < long.MaxValue / 2 ? oneBufferSize * 2 : long.MaxValue;
+-            timeoutControl.StartTimingWrite(minDataRate, maxBufferedBytes);
++            timeoutControl.BytesWritten(minDataRate, maxBufferedBytes);
++            timeoutControl.StartTimingWrite();
+         }
+     }
+ }","Since we now keep track of all bytes written, and extend the write timeout as needed, it's tempting to no longer add 2 times the max buffer size to the bytes written accounting for the connection drain timeout. As we've discussed before, this add several minutes to the timeout with the default 240 bytes/sec rate limit. I'm thinking instead this line changes to `timeoutControl.BytesWritten(minDataRate, 1);` to add a grace period to the drain if necessary. What do you think @Tratcher?"
+9536,"@@ -0,0 +1,18 @@
++const formPropsSet = new Set([
++	'form',
++	'formAction',
++	'formEncType',
++	'formMethod',
++	'formNoValidate',
++	'formTarget',
++]);
++
++export default function getFormProps(props) {
++	return Object.keys(props).reduce((prev, key) => {
++		if (formPropsSet.has(key)) {
++			// eslint-disable-next-line no-param-reassign
++			prev[key] = props[key];
++		}
++		return prev;
++	}, {});
++}",Good call. Makes we wonder if we should do this with the ARIA props.
+9537,"@@ -24,9 +24,7 @@ import java.io.InputStream;
+ import java.io.InputStreamReader;
+ import java.io.Reader;
+ import java.nio.charset.Charset;
+-import java.sql.Connection;
+-import java.sql.DatabaseMetaData;
+-import java.sql.SQLException;
++import java.sql.*;
+ import java.text.ParseException;
+ import java.util.ArrayList;
+ import java.util.Calendar;",Please do not use wildcard imports.
+9538,"@@ -386,6 +386,7 @@ struct wlr_surface *wlr_surface_create(struct wl_resource *res,
+ 		wl_resource_post_no_memory(res);
+ 		return NULL;
+ 	}
++	wlr_log(L_DEBUG, ""New wlr_surface %p (res %p)"", surface, res);
+ 	surface->renderer = renderer;
+ 	surface->texture = wlr_render_texture_create(renderer);
+ 	surface->resource = res;","Not sure about these added logs, as said in the commit message it's probably not something we want all the time, but it helped me debug a bit."
+9539,"@@ -487,8 +487,6 @@ class Comparison(ComparisonInterface):
+         paths2 = el2.split()
+         if len(paths1) != len(paths2):
+             raise cls.failureException(""%s objects do not have a matching number of paths."" % msg)
+-        for p1, p2 in zip(paths1, paths2):
+-            cls.compare_dataset(p1, p2, '%s data' % msg)
+
+     @classmethod
+     def compare_contours(cls, el1, el2, msg='Contours'):",Should there be an equivalent check or is it ok to remove this comparison?
+9540,"@@ -57,7 +57,7 @@ def run_migrations_online():
+
+     # this callback is used to prevent an auto-migration from being generated
+     # when there are no changes to the schema
+-    # reference: http://alembic.readthedocs.org/en/latest/cookbook.html
++    # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html
+     def process_revision_directives(context, revision, directives):
+         if getattr(config.cmd_opts, 'autogenerate', False):
+             script = directives[0]","sorry, why this change?"
+9541,"@@ -82,7 +82,7 @@ public abstract class AnalysisRequestHandlerBase extends RequestHandlerBase {
+    *
+    * @throws Exception When analysis fails.
+    */
+-  protected abstract NamedList doAnalysis(SolrQueryRequest req) throws Exception;
++  protected abstract NamedList<?> doAnalysis(SolrQueryRequest req) throws Exception;
+
+   /**
+    * Analyzes the given value using the given Analyzer.","I think best practice is to use `NamedList<Object>` as the return type, and `NamedList<?>` as the argument type in methods, but I can't find a reference for it right now."
+9542,"@@ -23,7 +23,9 @@ use Thelia\Core\Template\Element\PropelSearchLoopInterface;
+ use Thelia\Core\Template\Loop\Argument\Argument;
+ use Thelia\Core\Template\Loop\Argument\ArgumentCollection;
+ use Thelia\Coupon\Type\CouponInterface;
++use Thelia\Model\Base\CouponModule;
+ use Thelia\Model\Coupon as MCoupon;
++use Thelia\Model\CouponCountry;
+ use Thelia\Model\CouponQuery;
+ use Thelia\Model\Map\CouponTableMap;
+ use Thelia\Type\EnumListType;","Be careful, the base model is imported here !"
+9543,"@@ -60,7 +60,7 @@ func RootCommand() (*cobra.Command, *Flags) {
+ 	rootCmd.PersistentFlags().IntVar(&cfg.HttpPort, ""http.port"", node.DefaultHTTPPort, ""HTTP-RPC server listening port"")
+ 	rootCmd.PersistentFlags().StringSliceVar(&cfg.HttpCORSDomain, ""http.corsdomain"", []string{}, ""Comma separated list of domains from which to accept cross origin requests (browser enforced)"")
+ 	rootCmd.PersistentFlags().StringSliceVar(&cfg.HttpVirtualHost, ""http.vhosts"", node.DefaultConfig.HTTPVirtualHosts, ""Comma separated list of virtual hostnames from which to accept requests (server enforced). Accepts '*' wildcard."")
+-	rootCmd.PersistentFlags().StringSliceVar(&cfg.API, ""http.api"", []string{""eth""}, ""API's offered over the HTTP-RPC interface"")
++	rootCmd.PersistentFlags().StringSliceVar(&cfg.API, ""http.api"", []string{""eth"", ""tg""}, ""API's offered over the HTTP-RPC interface"")
+ 	rootCmd.PersistentFlags().Uint64Var(&cfg.Gascap, ""rpc.gascap"", 0, ""Sets a cap on gas that can be used in eth_call/estimateGas"")
+ 	rootCmd.PersistentFlags().Uint64Var(&cfg.MaxTraces, ""trace.maxtraces"", 200, ""Sets a limit on traces that can be returned in trace_filter"")
+ 	rootCmd.PersistentFlags().StringVar(&cfg.TraceType, ""trace.type"", ""parity"", ""Specify the type of tracing [geth|parity*] (experimental)"")","Do we want to make this part of the default? Probably not. In fact, the default should probably be eth, web3 and net (which are the standard namespaces on other nodes)."
+9544,"@@ -1,4 +1,8 @@
+ class Clump < ActiveRecord::Base
+   belongs_to :code_set
+   belongs_to :slave
++
++  def path
++    slave.path_from_code_set_id(code_set_id)
++  end
+ end",What is the plan when we deploy the Crawler VM project and eliminate the Clump model?
+9545,"@@ -28,10 +28,6 @@ type MultiClusterConfig struct {
+ 	metav1.TypeMeta `json:"",inline""`
+ 	// ControllerManagerConfigurationSpec returns the contfigurations for controllers
+ 	config.ControllerManagerConfigurationSpec `json:"",inline""`
+-	// Leader is a role of ClusterSet member cluster
+-	Leader bool `json:""leader,omitempty""`
+-	// Member is a role of ClusterSet member cluster
+-	Member bool `json:""member,omitempty""`
+ }
+
+ func init() {","these two are customized config fields, if we don't need them any more, we probably can use default ControllerManagerConfiguration"
+9546,"@@ -39,7 +39,12 @@ var (
+ 	defaultExecutablePathProvider executablePathProvider = os.Executable
+ 	defaultCommandArgsProvider    commandArgsProvider    = func() []string { return os.Args }
+ 	defaultOwnerProvider          ownerProvider          = user.Current
+-	defaultRuntimeNameProvider    runtimeNameProvider    = func() string { return runtime.Compiler }
++	defaultRuntimeNameProvider    runtimeNameProvider    = func() string {
++		if runtime.Compiler == ""gc"" {
++			return ""go""
++		}
++		return runtime.Compiler
++	}
+ 	defaultRuntimeVersionProvider runtimeVersionProvider = runtime.Version
+ 	defaultRuntimeOSProvider      runtimeOSProvider      = func() string { return runtime.GOOS }
+ 	defaultRuntimeArchProvider    runtimeArchProvider    = func() string { return runtime.GOARCH }","I don't think we should be pulling the runtime name from the Compiler. There are two compiler frontends, but both of them compile the same source to generate the ""go"" runtime. I think until there is a request from an alternative implementation (the embedded world **might** have a different runtime), it's fine to hardcode this as ""go"""
+9547,"@@ -932,6 +932,10 @@ Model.find = function find (conditions, fields, options, callback) {
+     options = null;
+   }
+
++  if (this.schema.discriminatorMapping && fields) {
++    fields = fields + ' ' + this.schema.options.discriminatorKey;
++  }
++
+   // get the raw mongodb collection object
+   var mq = new Query({}, options, this, this.collection);
+   mq.select(fields);",fields may be an object.
+9548,"@@ -4,12 +4,12 @@ import (
+ 	""bufio""
+ 	""encoding/json""
+ 	""fmt""
+-	""io/ioutil""
+ 	""log""
+ 	""net/http""
+ 	""net/url""
+ 	""strings""
+ 	""sync""
++	""time""
+
+ 	""github.com/hashicorp/hcl""
+ 	""github.com/spiffe/spire/proto/agent/workloadattestor""",i'm not confident these are the right defaults... anybody have input?
+9549,"@@ -80,7 +80,7 @@ type CasPool struct {
+ 	Namespace string
+
+ 	// DiskList is the list of disks over which a storagepool will be provisioned
+-	DiskList []string
++	DiskList []DiskGroup
+
+ 	// PoolType is the type of pool to be provisioned e.g. striped or mirrored
+ 	PoolType string",DiskGroupList can be better name
+9550,"@@ -229,7 +229,7 @@ func customErrorHandler(ctx context.Context, mux *runtime.ServeMux, m runtime.Ma
+ 	runtime.DefaultHTTPErrorHandler(ctx, mux, m, w, req, err)
+ }
+
+-func New(unaryInterceptors []grpc.UnaryServerInterceptor, assets http.FileSystem, gatewayCfg *gatewayv1.GatewayOptions) (*Mux, error) {
++func New(unaryInterceptors []grpc.UnaryServerInterceptor, assets http.FileSystem, gatewayCfg *gatewayv1.GatewayOptions, metricsHandler http.Handler) (*Mux, error) {
+ 	secureCookies := true
+ 	if gatewayCfg.SecureCookies != nil {
+ 		secureCookies = gatewayCfg.SecureCookies.Value",nit: lets leave gateway options at the end of the func signature.
+9551,"@@ -527,7 +527,7 @@ public class PDKClient {
+         SharedPreferences sharedPref = _context.getSharedPreferences(PDK_SHARED_PREF_FILE_KEY, Context.MODE_PRIVATE);
+         SharedPreferences.Editor editor = sharedPref.edit();
+         editor.putString(PDK_SHARED_PREF_TOKEN_KEY, accessToken);
+-        editor.commit();
++        editor.apply();
+     }
+
+     private static String restoreAccessToken() {","It will be better to use `commit()` on a separate thread, apart from the UI thread. The reason is `commit()` is synchronous while `apply()` is asynchronous. So in case it might not perform actions immediately as expected."
+9552,"@@ -123,10 +123,10 @@ func (q *queryImpl) validateTerminationState(
+ 		queryResult := terminationState.queryResult
+ 		validAnswered := queryResult.GetResultType().Equals(shared.QueryResultTypeAnswered) &&
+ 			queryResult.Answer != nil &&
+-			queryResult.ErrorMessage == nil
++			(queryResult.ErrorMessage == nil || *queryResult.ErrorMessage == """")
+ 		validFailed := queryResult.GetResultType().Equals(shared.QueryResultTypeFailed) &&
+ 			queryResult.Answer == nil &&
+-			queryResult.ErrorMessage != nil
++			(queryResult.ErrorMessage != nil && *queryResult.ErrorMessage != """")
+ 		if !validAnswered && !validFailed {
+ 			return errTerminationStateInvalid
+ 		}",Took me almost 4 hours to find this.
+9553,"@@ -8,9 +8,9 @@ from .concat_dataset import ConcatDataset
+ from .repeat_dataset import RepeatDataset
+ from .extra_aug import ExtraAugmentation
+
++
+ __all__ = [
+     'CustomDataset', 'XMLDataset', 'CocoDataset', 'VOCDataset', 'GroupSampler',
+     'DistributedGroupSampler', 'build_dataloader', 'to_tensor', 'random_scale',
+     'show_ann', 'get_dataset', 'ConcatDataset', 'RepeatDataset',
+-    'ExtraAugmentation'
+-]
++    'ExtraAugmentation']",There should be only a single blank line between imports and `__all__`.
+9554,"@@ -194,7 +194,7 @@ public class TestCloudPseudoReturnFields extends SolrCloudTestCase {
+       SolrDocumentList docs = assertSearch(params(""q"", ""*:*"", ""rows"", ""10"", ""fl"",fl));
+       // shouldn't matter what doc we pick...
+       for (SolrDocument doc : docs) {
+-        assertEquals(fl + "" => "" + doc, 4, doc.size());
++        assertEquals(fl + "" => "" + doc, 5, doc.size());
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""id"") instanceof String);
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""val_i"") instanceof Integer);
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""subject"") instanceof String);",Doc size increased by 1 since _root_ is also returned by queries.
+9555,"@@ -822,8 +822,14 @@ def color_intervals(colors, levels, clip=None, N=255):
+         clmin, clmax = clip
+         lidx = int(round(N*((clmin-cmin)/interval)))
+         uidx = int(round(N*((cmax-clmax)/interval)))
+-        cmap = cmap[lidx:N-uidx]
+-    return cmap
++        uidx = N-uidx
++        if lidx == uidx:
++            uidx = lidx+1
++        cmap = cmap[lidx:uidx]
++        if clmin == clmax:
++            idx = np.argmin(np.abs(np.array(levels)-clmin))
++            clip = levels[idx: idx+2] if len(levels) > idx+2 else levels[idx-1: idx+1]
++    return cmap, clip
+
+
+ def dim_axis_label(dimensions, separator=', '):",Now the return value has changed (or at least now includes `clip`) it might be worth updating the docstring...
+9556,"@@ -411,7 +411,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet()
++				ws, err := sf.NewWorkingSet(nil)
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 410 (from `govet`)"
+9557,"@@ -82,7 +82,13 @@ class Flashmessages extends AbstractHelper
+                 $this->fm->getMessages($ns), $this->fm->getCurrentMessages($ns)
+             );
+             foreach (array_unique($messages, SORT_REGULAR) as $msg) {
+-                $html .= '<div class=""' . $this->getClassForNamespace($ns) . '"">';
++                $html .= '<div class=""' . $this->getClassForNamespace($ns) . '""';
++                if (isset($msg['dataset'])) {
++                    foreach ($msg['dataset'] as $attr => $value) {
++                        $html .= ' data-' . $attr . '=""' . $value . '""';
++                    }
++                }
++                $html .= '>';
+                 // Advanced form:
+                 if (is_array($msg)) {
+                     // Use a different translate helper depending on whether",Should we be escaping $attr and/or $value here? Seems like htmlspecialchars() might be in order to be on the safe side.
+9558,"@@ -40,6 +40,7 @@ module Travis
+           def clone_args
+             args = ""--depth=#{depth}""
+             args << "" --branch=#{branch}"" unless data.ref
++	    args << "" #{quiet_o}""
+             args
+           end
+ ","why not remove the need for the `quiet_o` method and just add it similar to how the `--branch` is added? also, looks like the indenting is a little off"
+9559,"@@ -96,8 +96,9 @@ public class FlowContainer {
+   private static final String CONF_DIR = ""conf"";
+   private static final String JOB_THREAD_COUNT = ""flow.num.job.threads"";
+   private static final String DEFAULT_LOG_CHUNK_SIZE = ""5MB"";
++  private static final String FLOW_EXECUTION_ID = ""FLOW_EXECUTION_ID"";
++  private static final String VERSION_SET_ID = ""VERSION_SET_ID"";
+   private static final int DEFAULT_LOG_NUM_FILES = 4;
+-  private static final int EXEC_ID_INDEX = 0;
+   private static final int DEFAULT_JOB_TREAD_COUNT = 10;
+   private static final boolean DEFAULT_USE_IN_MEMORY_KEYSTORE = false;
+   // Should validate proxy user",These variables are already created in constants. Please reuse those.
+9560,"@@ -156,6 +156,10 @@ class Key(object):
+         if self.resp == None:
+             self.mode = 'r'
+
++            if self.version_id:
++                query_args = query_args or []
++                query_args.append('versionId=%s' % self.version_id)
++
+             provider = self.bucket.connection.provider
+             self.resp = self.bucket.connection.make_request(
+                 'GET', self.bucket.name, self.name, headers,","query_args is a string, not a list. Therefore you cannot call append to it. Also, line 986-989 of key.py already have code that is appending the versionId query parameter."
+9561,"@@ -548,12 +548,12 @@ func (f *Fs) newObjectWithInfo(ctx context.Context, remote string, info *api.Fil
+ 	if info != nil {
+ 		err := o.decodeMetaData(info)
+ 		if err != nil {
+-			return nil, err
++			return o, err
+ 		}
+ 	} else {
+ 		err := o.readMetaData(ctx) // reads info and headers, returning an error
+ 		if err != nil {
+-			return nil, err
++			return o, err
+ 		}
+ 	}
+ 	return o, nil",I think this change and the one below will break the integration tests which expect a `nil` object if `NewObject` fails.
+9562,"@@ -1,6 +1,7 @@
+ # frozen_string_literal: true
+
+ require 'hocon'
++require 'bolt/error'
+
+ class TransportConfig
+   attr_accessor :host, :port, :ssl_cert, :ssl_key, :ssl_ca_cert, :ssl_cipher_suites,",Looks like this isn't used in this file?
+9563,"@@ -327,7 +327,10 @@ class PandasLikeSeries(_Frame):
+             sum = df_dropna._spark_count()
+             df = df._spark_withColumn('count', F._spark_col('count') / F._spark_lit(sum))
+
+-        return _col(df.set_index([self.name]))
++        hidden_name = 'index' if self.name != 'index' else 'level_0'
++        df.columns = [hidden_name, self.name]
++        df._metadata = Metadata(column_fields=[self.name], index_info=[(hidden_name, None)])
++        return _col(df)
+
+     @property
+     def _pandas_anchor(self) -> DataFrame:",why hidden name? How about `index_name`?
+9564,"@@ -367,6 +367,9 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
+   char cursorId[8];
+   HdfsFileInfo *hdfo = NULL;
+   Lng32 openType = 0;
++  int hiveScanMode = 0;
++
++  hiveScanMode = CmpCommon::getDefaultLong(HIVE_SCAN_SPECIAL_MODE);
+
+   while (!qparent_.down->isEmpty())
+     {","Usually, CQDs are not accessed directly in executor operators directly. It should be passed as a flag in the TDB. It is possible that the query is compiled in a different process, then this CQD setting won't be available in the executor layer."
+9565,"@@ -477,9 +477,9 @@ func ShardID(shardID int32) ZapTag {
+ 	return NewInt32(""shard-id"", shardID)
+ }
+
+-// ShardItem returns tag for ShardItem
+-func ShardItem(shardItem interface{}) ZapTag {
+-	return NewAnyTag(""shard-item"", shardItem)
++// ShardContext returns tag for shard.Context
++func ShardContext(shard interface{}) ZapTag {
++	return NewAnyTag(""shard-context"", shard)
+ }
+
+ // ShardTime returns tag for ShardTime","This tag was broken, the value write to log was the memory address. Please verify that this actually write out meaningful content in log."
+9566,"@@ -0,0 +1,9 @@
++""""""Checks import position rule with pep-0008""""""
++# pylint: disable=unused-import,relative-import,ungrouped-imports,import-error,no-name-in-module,relative-beyond-top-level,undefined-variable
++
++__author__ = 'some author'
++__email__ = 'some.author@some_email'
++__copyright__ = 'Some copyright'
++
++
++import sys",Why do you have to disable all of these checks?
+9567,"@@ -1639,6 +1639,7 @@ class CommandDispatcher:
+         """"""
+         try:
+             elem.set_value(text)
++            mainwindow.raise_window(objreg.last_focused_window())
+         except webelem.OrphanedError as e:
+             message.error('Edited element vanished')
+         except webelem.Error as e:","Just a note to myself: After merging this, I should edit the line after this one to use `message.error`, as raising a `CommandError` from here seems wrong!"
+9568,"@@ -1010,8 +1010,6 @@ GLOBAL_LABEL(FUNCNAME:)
+         mov      TEST_REG2_ASM, 1
+         /* xax statelessly restored here. */
+         mov      TEST_REG2_ASM, 2
+-        /* xax is dead, so initial aflags spill should not use slot. */
+-        mov      REG_XAX, 0
+         jmp      test28_done
+      test28_done:
+         /* Fail if aflags were not restored correctly. */","In this test, we want xax to be dead, so that aflags are not spilled to a slot."
+9569,"@@ -54,7 +54,9 @@ type Options struct {
+
+ func newOptions() *Options {
+ 	return &Options{
+-		config: new(AgentConfig),
++		config: &AgentConfig{
++			EnablePrometheusMetrics: true,
++		},
+ 	}
+ }
+ ","I remember there were some misleading code about this but forgot to correct them. Although we initialize `config` here, it was discarded in `complete`, so I guess setting the default value here doesn't take effect. We should change L139-L140 as well to use the initialized `config`. So do antrea-controller."
+9570,"@@ -364,4 +364,13 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
+       output.string.should =~ /, 100.0% of total time\):/
+     end
+   end
++
++  describe ""custom_colors"" do
++    before { RSpec.configuration.stub(:color_enabled?) { true } }
++    it ""uses the custom success color"" do
++      RSpec.configuration.stub(:success_color).and_return(:cyan)
++      formatter.dump_summary(0,1,0,0)
++      output.string.should include(""\e[36m"")
++    end
++  end
+ end","Stubbin a value object (like `RSpec.configuration`) is a bit of a code smell, I think. You can just set `color_enabled` and `success_color` through the configuration APIs provided by `RSpec::Configuration` -- no need to stub. The `sandboxed` thing in `spec_helper.rb` takes care of preventing changes to the configuration object in one example from leaking into other examples."
+9571,"@@ -624,9 +624,14 @@ API.prototype.getBalanceFromPrivateKey = function(privateKey, coin, cb) {
+   var B = Bitcore_[coin];
+
+   var privateKey = new B.PrivateKey(privateKey);
+-  var address = privateKey.publicKey.toAddress();
++
++  var address = privateKey.publicKey.toAddress().toString();
++  if (coin == 'bch') {
++    address = privateKey.publicKey.toAddress().toCashAddress().replace('bitcoincash:', '');
++  }
++
+   self.getUtxos({
+-    addresses: coin == 'bch' ? address.toLegacyAddress() : address.toString(),
++    addresses: address,
+   }, function(err, utxos) {
+     if (err) return cb(err);
+     return cb(null, _.sumBy(utxos, 'satoshis'));",you can use `toString(true)` that will work for BTC and remove the prefix for BCH.
+9572,"@@ -652,9 +652,10 @@ class TabbedBrowser(tabwidget.TabWidget):
+
+         log.modes.debug(""Current tab changed, focusing {!r}"".format(tab))
+         tab.setFocus()
+-        for mode in [usertypes.KeyMode.hint, usertypes.KeyMode.insert,
+-                     usertypes.KeyMode.caret, usertypes.KeyMode.passthrough]:
+-            modeman.leave(self._win_id, mode, 'tab changed', maybe=True)
++        if not config.val.tabs.persist_mode_on_change:
++            for mode in [usertypes.KeyMode.hint, usertypes.KeyMode.insert,
++                         usertypes.KeyMode.caret, usertypes.KeyMode.passthrough]:
++                modeman.leave(self._win_id, mode, 'tab changed', maybe=True)
+         if self._now_focused is not None:
+             objreg.register('last-focused-tab', self._now_focused, update=True,
+                             scope='window', window=self._win_id)",This line is too long now - please break it after the comma.
+9573,"@@ -67,6 +67,7 @@ type StreamerDisconnecter interface {
+ type Stream interface {
+ 	io.ReadWriter
+ 	io.Closer
++	ResponseHeaders() Headers
+ 	Headers() Headers
+ 	FullClose() error
+ 	Reset() error","I find this addition to the interface a bit contentious. I think it would be cleaner to just return the response headers together with the new stream on `NewStream`. I.e. change the method signature for `NewStream` to be: `NewStream(ctx context.Context, overlay swarm.Address, headers p2p.Headers, protocolName, protocolVersion, streamName string) (p2p.Stream, p2p.Headers, error)`. I'd like to hear what other think. cc @zelig @janos"
+9574,"@@ -222,6 +222,12 @@ class CartFacade
+
+         if ($cart !== null) {
+             $this->cartWatcherFacade->checkCartModifications($cart);
++
++            if ($cart->isEmpty()) {
++                $this->deleteCart($cart);
++
++                return null;
++            }
+         }
+
+         return $cart;","i hope there is some magic where isEmpty or some cron can strip all non listable products from cart, but since we have the situation tested it should be OK and also we'll see during tests"
+9575,"@@ -127,7 +127,7 @@ public class HiveIcebergFilterFactory {
+       case FLOAT:
+         return leaf.getLiteral();
+       case DATE:
+-        return daysFromTimestamp((Timestamp) leaf.getLiteral());
++        return daysFromDate((Date) leaf.getLiteral());
+       case TIMESTAMP:
+         return microsFromTimestamp((Timestamp) LITERAL_FIELD.get(leaf));
+       case DECIMAL:",I think we should check the type returned by `getLiteral` and handle that here. Then we won't need separate code for different versions.
+9576,"@@ -131,13 +131,13 @@ func (s *HandlerTestSuite) TestFetchX509SVID() {
+ func (s *HandlerTestSuite) TestSendResponse() {
+ 	emptyUpdate := new(cache.WorkloadUpdate)
+ 	s.stream.EXPECT().Send(gomock.Any()).Times(0)
+-	err := s.h.sendResponse(emptyUpdate, s.stream)
++	err := s.h.sendX509SVIDResponse(emptyUpdate, s.stream)
+ 	s.Assert().Error(err)
+
+-	resp, err := s.h.composeResponse(s.workloadUpdate())
++	resp, err := s.h.composeX509SVIDResponse(s.workloadUpdate())
+ 	s.Require().NoError(err)
+ 	s.stream.EXPECT().Send(resp)
+-	err = s.h.sendResponse(s.workloadUpdate(), s.stream)
++	err = s.h.sendX509SVIDResponse(s.workloadUpdate(), s.stream)
+ 	s.Assert().NoError(err)
+ }
+ ",Tests for JWT handler functionality?
+9577,"@@ -548,9 +548,6 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
+                         ""POST / HTTP/1.1"",
+                         ""Content-Length: 3"",
+                         """",
+-                        ""101POST / HTTP/1.1"",
+-                        ""Content-Length: 3"",
+-                        """",
+                         ""204POST / HTTP/1.1"",
+                         ""Content-Length: 3"",
+                         """",","It's weird to set a 101 response and complete without writing anything, but this is still a valid test case right?"
+9578,"@@ -207,6 +207,19 @@ class DefaultBucketViewTest(FormattedErrorMixin, BaseWebTest,
+             self.assertEqual(resp.body, response.body)
+
+
++class HelloViewTest(BaseWebTest, unittest.TestCase):
++
++    def test_returns_bucket_id_and_url_if_authenticated(self):
++        response = self.app.get('/', headers=self.headers)
++        self.assertEqual(response.json['user']['bucket'],
++                         '23bb0efc-e80d-829e-6757-79d41e16640f')
++
++    def test_flush_capability_if_enabled(self):
++        resp = self.app.get('/')
++        capabilities = resp.json['capabilities']
++        self.assertIn('default_bucket', capabilities)
++
++
+ class ReadonlyDefaultBucket(BaseWebTest, unittest.TestCase):
+
+     def get_app_settings(self, extras=None):",Should we move that information in the capability itself?
+9579,"@@ -18,6 +18,9 @@ class StatisticsElement(Chart):
+
+     __abstract = True
+
++    # Ensure Interface does not add an index
++    _auto_indexable_1d = False
++
+     def __init__(self, data, kdims=None, vdims=None, **params):
+         if isinstance(data, Element):
+             params.update(get_param_values(data))",Is this needed?
+9580,"@@ -163,7 +163,7 @@ func (r *ReconcileRemoteClusterIngress) Reconcile(request reconcile.Request) (re
+ 	// can't proceed if the secret(s) referred to doesn't exist
+ 	certBundleSecrets, err := r.getIngressSecrets(rContext)
+ 	if err != nil {
+-		rContext.logger.WithError(err).Error(""will need to retry until able to find all certBundle secrets"")
++		rContext.logger.Warningf(""will need to retry until able to find all certBundle secrets : %v"", err)
+ 		conditionErr := r.setIngressCertificateNotFoundCondition(rContext, true, err.Error())
+ 		if conditionErr != nil {
+ 			rContext.logger.WithError(conditionErr).Error(""unable to set IngressCertNotFound condition"")",This log should not be an error as it communicates that we need to retry till we get the cert information for remote ingress controller.
+9581,"@@ -130,6 +130,8 @@ namespace Nethermind.Blockchain
+         BlockHeader[] FindHeaders(Keccak hash, int numberOfBlocks, int skip, bool reverse);
+
+         void DeleteInvalidBlock(Block invalidBlock);
++
++        void Flush();
+
+         event EventHandler<BlockEventArgs> NewBestSuggestedBlock;
+         event EventHandler<BlockEventArgs> BlockAddedToMain;","BlockTree alredy has a polluted API, this one seems very internal"
+9582,"@@ -123,6 +123,7 @@ describe ""BoltSpec::Run"", ssh: true do
+
+     describe 'apply_manifest' do
+       it 'should apply a manifest file' do
++        bolt_inventory['features'] = ['puppet-agent']
+         with_tempfile_containing('manifest', ""notify { 'hello world': }"", '.pp') do |manifest|
+           results = apply_manifest(manifest.path, 'ssh')
+           results.each do |result|","Sorry, I realize my line numbers were probably off after you deleted your variables! I meant for this to go in the `before(:all) do` and `after(:all) do` blocks."
+9583,"@@ -195,7 +195,9 @@ public class ToParentBlockJoinQuery extends Query {
+           return null;
+         }
+       }
+-      return MatchesUtils.MATCH_WITH_NO_TERMS;
++
++      // TODO: which fields should be here?
++      return MatchesUtils.matchWithNoTerms(getQuery());
+     }
+   }
+ ",This bit I wasn't really sure about.
+9584,"@@ -87,6 +87,7 @@ function buildRules(grunt, options, commons, callback) {
+ 		var tags = options.tags ? options.tags.split(/\s*,\s*/) : [];
+ 		var rules = result.rules;
+ 		var checks = result.checks;
++		parseChecks(checks);
+
+ 		// Translate checks
+ 		if (locale && locale.checks) {","From the code, a check's metatdata was only added to `axe._load` if a rule used it. Since `role-none` and `role-presentation` were no longer used in any rule, their metadata was never added. This caused any translation file that passed translations for those checks to fail `axe.configure` with > ""Locale provided for unknown check: ""role-none"""" To fix I added this line to parse all checks regardless of if a rule uses it or not."
+9585,"@@ -740,7 +740,7 @@ class Package:
+             gc.enable()
+         return pkg
+
+-    def set_dir(self, lkey, path=None, meta=None):
++    def set_dir(self, lkey, path=None, meta=None, update_policy=""incoming""):
+         """"""
+         Adds all files from `path` to the package.
+ ","We should raise `ValueError` if `update_policy not in ['existing', 'incoming']`. (or `in Enum.__members__` or however we want to express legal values)"
+9586,"@@ -42,10 +42,11 @@ namespace MvvmCross.iOS.Platform
+             _applicationDelegate = applicationDelegate;
+         }
+
+-        protected MvxIosSetup(IMvxApplicationDelegate applicationDelegate, IMvxIosViewPresenter presenter)
++        protected MvxIosSetup(IMvxApplicationDelegate applicationDelegate, UIWindow window, IMvxIosViewPresenter presenter) : this (applicationDelegate, window)
+         {
+-            _presenter = presenter;
++            _window = window;
+             _applicationDelegate = applicationDelegate;
++            _presenter = presenter;
+         }
+
+         protected UIWindow Window => _window;","`_applicationDelegate` and `_window` are already set in the call for `: this (applicationDelegate, window)`, no need to assigning them again here"
+9587,"@@ -9,7 +9,7 @@ export function createContext(defaultValue) {
+ 		_id: '__cC' + i++,
+ 		_defaultValue: defaultValue,
+ 		Consumer(props, context) {
+-			return props.children(context);
++			return props.children(props.selector(context));
+ 		},
+ 		Provider(props) {
+ 			if (!this.getChildContext) {",We might not have a selector prop in the consumer
+9588,"@@ -386,7 +386,7 @@ namespace Nethermind.Blockchain.Processing
+                     break;
+                 }
+
+-                bool isFastSyncTransition = _blockTree.Head?.Header == _blockTree.Genesis && toBeProcessed.Number > 1;
++                bool isFastSyncTransition = (_blockTree.Head?.IsGenesis ?? false) && toBeProcessed.Number > 1;
+                 if (!isFastSyncTransition)
+                 {
+                     if (_logger.IsTrace) _logger.Trace($""Finding parent of {toBeProcessed.ToString(Block.Format.Short)}"");",IMO == true is more readable than ?? false
+9589,"@@ -3,7 +3,7 @@ const test = require('./shared').assert,
+   setupDatabase = require('./shared').setupDatabase,
+   Script = require('vm'),
+   expect = require('chai').expect,
+-  normalizedFunctionString = require('bson/lib/bson/parser/utils').normalizedFunctionString,
++  normalizedFunctionString = require('bson/lib/parser/utils').normalizedFunctionString,
+   Buffer = require('safe-buffer').Buffer;
+
+ const {",feel free when editing sections like this to introduce modern features like object destructuring.
+9590,"@@ -1,3 +1,4 @@
++# coding: utf-8
+ # Copyright (c) 2006-2015 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
+ # Copyright (c) 2012-2014 Google, Inc.
+ # Copyright (c) 2014-2016 Claudiu Popa <pcmanticore@gmail.com>",I think the correct pragma is `# -*- coding: utf-8 -*-
+9591,"@@ -58,6 +58,9 @@ from scapy.layers.inet import TCP
+ from scapy.packet import Raw
+ from scapy.packet import Packet, bind_layers
+
++from . import iec104, iec104_fields, iec104_information_elements, \
++    iec104_information_objects  # noqa: F401
++
+ IEC_104_IANA_PORT = 2404
+
+ # direction - from the central station to the substation","This fixes some import errors, due to the fact that this file has the same name than its module."
+9592,"@@ -21,8 +21,9 @@ type Folder struct {
+ 	fs   *FS
+ 	list *FolderList
+
+-	handleMu sync.RWMutex
+-	h        *libkbfs.TlfHandle
++	handleMu       sync.RWMutex
++	h              *libkbfs.TlfHandle
++	hPreferredName string
+
+ 	folderBranchMu sync.Mutex
+ 	folderBranch   libkbfs.FolderBranch","I think we need to clear this out on logout, and update it on login, right?"
+9593,"@@ -43,6 +43,8 @@ gboolean
+ ot_util_filename_validate (const char *name,
+                            GError    **error)
+ {
++  if (name == NULL)
++    return glnx_throw (error, ""Invalid NULL filename"");
+   if (strcmp (name, ""."") == 0)
+     return glnx_throw (error, ""Invalid self-referential filename '.'"");
+   if (strcmp (name, "".."") == 0)","I think normally we'd make this a precondition (using e.g. `g_return_val_if_fail`), but meh, this works too!"
+9594,"@@ -34,5 +34,5 @@ public final class Const {
+
+     public static final String SRC_MICROSERVICE = ""x-cse-src-microservice"";
+
+-    public static final String DEST_MICROSERVICE = ""x-cse-dest-microservice"";
++    public static final String TARGET_MICROSERVICE = ""x-cse-target-microservice"";
+ }",Is this header used by other outside service?
+9595,"@@ -89,10 +89,3 @@ class TestZipFolder(BZTestCase):
+         result_tree = set(filename[len(destination):] for filename in get_files_recursive(destination))
+         original_tree = set(filename[len(source):] for filename in get_files_recursive(source))
+         self.assertEqual(result_tree, original_tree)
+-
+-    def test_no_work_prov(self):
+-        obj = Unpacker()
+-        obj.engine = EngineEmul()
+-        obj.engine.config[Provisioning.PROV] = 'cloud'
+-        obj.parameters.merge({Unpacker.FILES: ['notexists.zip']})
+-        obj.prepare()",that's fine by me to have simple test for provisioning check
+9596,"@@ -83,7 +83,7 @@ public class TriggerBasedScheduleLoader implements ScheduleLoader {
+     ConditionChecker checker =
+         new BasicTimeChecker(""BasicTimeChecker_1"", s.getFirstSchedTime(),
+             s.getTimezone(), s.isRecurring(), s.skipPastOccurrences(),
+-            s.getPeriod());
++            s.getPeriod(), s.getCronExpression());
+     checkers.put(checker.getId(), checker);
+     String expr = checker.getId() + "".eval()"";
+     Condition cond = new Condition(checkers, expr);",These two methods seem to be identical except the names. Any idea why two methods are needed?
+9597,"@@ -0,0 +1,14 @@
++#!/usr/bin/env python
++
++
++import sys
++import os
++sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)), "".."", ""..""))
++from influxdb import InfluxDBClient
++import config
++
++try:
++    i = InfluxDBClient(host=config.INFLUX_HOST, port=config.INFLUX_PORT, database=config.INFLUX_TEST_DB)
++    i.create_database(config.INFLUX_TEST_DB)
++except Exception as e:
++    print(""Creating influx DB failed: "", e)",I don't see much difference between this and `create_db` module. How about having a function with a `database` argument?
+9598,"@@ -183,7 +183,7 @@ class AnalyticsDashboardWidget extends Component {
+ 							</div>
+ 							{ /* Data issue: on error display a notification. On missing data: display a CTA. */ }
+ 							{ ! receivingData && (
+-								error ? getDataErrorComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), true, true, true )
++								error ? getDataErrorComponent( 'analytics', _x( 'Analytics', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), true, true, true )
+ 							) }
+ 							<div className={ classnames(
+ 								'mdc-layout-grid__cell',","See above, no need to pass the module name."
+9599,"@@ -316,7 +316,7 @@ class LGBMModel(_LGBMModelBase):
+         group : array-like or None, optional (default=None)
+             Group data of training data.
+         eval_set : list or None, optional (default=None)
+-            A list of (X, y) tuple pairs to use as a validation sets.
++            A list of (X, y) tuple pairs to use as a validation set.
+         eval_names : list of strings or None, optional (default=None)
+             Names of eval_set.
+         eval_sample_weight : list of arrays or None, optional (default=None)","LightGBM supports multiple validation sets, so please leave `sets`."
+9600,"@@ -19,13 +19,14 @@ package org.openqa.selenium.remote;
+
+ import com.google.common.collect.ImmutableMap;
+
++import org.openqa.selenium.DeviceRotation;
+ import org.openqa.selenium.Rotatable;
+ import org.openqa.selenium.ScreenOrientation;
+
+ import java.lang.reflect.Method;
+
+ public class AddRotatable implements AugmenterProvider {
+-
++
+   public Class<?> getDescribedInterface() {
+     return Rotatable.class;
+   }","you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)"
+9601,"@@ -1955,15 +1955,7 @@ context 'Substitutions' do
+       end
+
+       test 'should passthrough math macro inside another passthrough' do
+-        input = 'the text `asciimath:[x = y]` should be passed through as +literal+ text'
+-        para = block_from_string input, attributes: { 'compat-mode' => '' }
+-        assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+-
+-        input = 'the text [x-]`asciimath:[x = y]` should be passed through as `literal` text'
+-        para = block_from_string input
+-        assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+-
+-        input = 'the text `+asciimath:[x = y]+` should be passed through as `literal` text'
++        input = 'the text `++asciimath:[x = y]++` should be passed through as `literal` text'
+         para = block_from_string input
+         assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+       end",What is this obscure syntax anyway? o.O
+9602,"@@ -756,6 +756,10 @@ class SPRegion(PyRegion):
+     return spec
+
+
++  def getAlgorithm(self):
++    return self._sfdr
++
++
+   def getParameter(self, parameterName, index=-1):
+     """"""
+       Get the value of a NodeSpec parameter. Most parameters are handled","I think we should have one for the CLA Classifier, and KNNClassifier as well. And how about RecordSensor?"
+9603,"@@ -0,0 +1,9 @@
++package com.fsck.k9.fragment;
++import android.database.Cursor;
++import android.view.ContextMenu;
++/**
++ Created by Kamil Rajtar on 05.11.17. */
++
++public interface ICursorContextMenuSupplier{
++	void getCursorMenu(ContextMenu menu,Cursor cursor);
++}",Missing new line.
+9604,"@@ -17,6 +17,9 @@ const populateModelSymbol = require('../symbols').populateModelSymbol;
+ const schemaMixedSymbol = require('../../schema/symbols').schemaMixedSymbol;
+
+ module.exports = function getModelsMapForPopulate(model, docs, options) {
++  if (model.schema.base.options.strictPopulate == false && options.strictPopulate == null) {
++    options.strictPopulate = model.schema.base.options.strictPopulate;
++  }
+   let doc;
+   const len = docs.length;
+   const map = [];","`model.schema.base.options.strictPopulate != null`. Why hardcoding false? Also, `model.base.options` should work and be shorter. Finally, any way to move this up to the `populate()` function in `model.js` that calls `getModelsMapForPopulate()` and shallow clone the object before modifying? A bit random to modify this option here."
+9605,"@@ -35,10 +35,10 @@ namespace Nethermind.Core.Test
+             ISpecProvider specProvider = new CustomSpecProvider((0, releaseSpec));
+
+             BlockValidator blockValidator = new BlockValidator(txValidator, AlwaysValidHeaderValidator.Instance, AlwaysValidOmmersValidator.Instance, specProvider, LimboLogs.Instance);
+-            bool noiseRemoved = blockValidator.ValidateSuggestedBlock(Build.A.Block.TestObject);
++            bool noiseRemoved = blockValidator.ValidateSuggestedBlock(Builders.Build.A.Block.TestObject);
+             Assert.True(noiseRemoved);
+
+-            bool result = blockValidator.ValidateSuggestedBlock(Build.A.Block.WithOmmers(Build.A.BlockHeader.TestObject).TestObject);
++            bool result = blockValidator.ValidateSuggestedBlock(Builders.Build.A.Block.WithOmmers(Builders.Build.A.BlockHeader.TestObject).TestObject);
+             Assert.False(result);
+         }
+     }",We now have Prepare.A/Build.A/Builders.Build.A - what are the differences?
+9606,"@@ -51,6 +51,12 @@ module Asciidoctor
+       append_newline ? %(#{str}#{LF}) : str
+     end
+
++    def preserve_backslash str
++      str = str.
++        gsub(/\\/, '\\e')
++      str
++    end
++
+     def skip_with_warning node, name = nil
+       warn %(asciidoctor: WARNING: converter missing for #{name || node.node_name} node in manpage backend)
+       nil","Could you reduce this to one line and change the first argument to a single quoted backslash string? Perhaps we can add this as an option named `:preserve_backslash` to the manify method. That way, we don't need an extra method in the first two cases. Obviously, we still need it for the inline case."
+9607,"@@ -49,10 +49,10 @@ var _ = Context(""with initialized Felix, etcd datastore, 3 workloads"", func() {
+ 		defaultProfile := api.NewProfile()
+ 		defaultProfile.Name = ""default""
+ 		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.EgressRules = []api.Rule{{Action: ""allow""}}
++		defaultProfile.Spec.EgressRules = []api.Rule{{Action: api.Allow}}
+ 		defaultProfile.Spec.IngressRules = []api.Rule{{
+-			Action: ""allow"",
+-			Source: api.EntityRule{Tag: ""default""},
++			Action: api.Allow,
++			Source: api.EntityRule{Selector: ""default == ''""},
+ 		}}
+ 		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+ 		Expect(err).NotTo(HaveOccurred())",`has(default)` i think is the preferred way of doing this
+9608,"@@ -235,7 +235,7 @@ public class BaseRewriteManifests extends SnapshotProducer<RewriteManifests> imp
+               keptManifests.add(manifest);
+             } else {
+               rewrittenManifests.add(manifest);
+-              try (ManifestReader reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
++              try (ManifestReader<DataFile> reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
+                   .select(Arrays.asList(""*""))) {
+                 reader.liveEntries().forEach(
+                     entry -> appendEntry(entry, clusterByFunc.apply(entry.file()), manifest.partitionSpecId())",Does this mean we can only do rewrites if there are no `DeleteFile`'s?
+9609,"@@ -96,10 +96,12 @@ class InstallTest(QuiltTestCase):
+         """"""
+         table_data, table_hash = self.make_table_data()
+         file_data, file_hash = self.make_file_data()
+-        contents, contents_hash = self.make_contents(table=table_hash, file=file_hash)
++        contents, contents_hash = self.make_contents(table=table_hash,
++                                                     file=file_hash)
+
+         self._mock_tag('foo/bar', 'latest', contents_hash, team='qux')
+-        self._mock_package('foo/bar', contents_hash, '', contents, [table_hash, file_hash], team='qux')
++        self._mock_package('foo/bar', contents_hash, '',
++                           contents, [table_hash, file_hash], team='qux')
+         self._mock_s3(table_hash, table_data)
+         self._mock_s3(file_hash, file_data)
+ ","Actually, these are fine; we're using 110 as the max line length. (it's also set in the .pylintrc)"
+9610,"@@ -17,6 +17,7 @@ package main
+ import (
+ 	. ""github.com/onsi/ginkgo""
+ 	. ""github.com/onsi/gomega""
++
+ 	""github.com/projectcalico/felix/k8sfv/leastsquares""
+ )
+ ","No issue here, but what tool are you running to put these imports into the preferred organization? I have configuration to run `goimports` whenever I save a file, but it appears that that is not quite sufficient."
+9611,"@@ -131,6 +131,7 @@ public class DTAFileReaderSpi extends TabularDataFileReaderSpi{
+
+     @Override
+     public boolean canDecodeInput(BufferedInputStream stream) throws IOException {
++    	//who closes this stream?
+         if (stream ==null){
+             throw new IllegalArgumentException(""stream == null!"");
+         }",guessing this method could/should close it but I didn't see where it was getting called.
+9612,"@@ -50,11 +50,13 @@ public class ExecutableFlow extends ExecutableFlowBase {
+   public static final String AZKABANFLOWVERSION_PARAM = ""azkabanFlowVersion"";
+   public static final String IS_LOCKED_PARAM = ""isLocked"";
+   public static final String FLOW_LOCK_ERROR_MESSAGE_PARAM = ""flowLockErrorMessage"";
++  public static final String EXECUTION_SOURCE = ""execution_source"";
+
+   private final HashSet<String> proxyUsers = new HashSet<>();
+   private int executionId = -1;
+   private int scheduleId = -1;
+   private int projectId;
++  private String executionSource;
+   private String projectName;
+   private String lastModifiedUser;
+   private int version;",Could you please use `camelCase` in the property name to follow the naming convention used in the rest of the properties?
+9613,"@@ -12,7 +12,7 @@ import (
+ )
+
+ const (
+-	fmtErrPublicSubnetsFromEnv  = ""get public subnet IDs from environment %s: %w""
++	fmtErrPublicSubnetsFromEnv  = ""get public subnet IDs from environment %s: %w ""
+ 	fmtErrSecurityGroupsFromEnv = ""get security groups from environment %s: %w""
+
+ 	envSecurityGroupCFNLogicalIDTagKey   = ""aws:cloudformation:logical-id""",Can we revert this change? looks like an extra space was added at the end
+9614,"@@ -222,6 +222,9 @@ public class RubyPackageMetadataTransformer implements ModelToViewTransformer {
+                 productConfig, ImportSectionView.newBuilder().build(), surfaceNamer))
+         .hasSmokeTests(hasSmokeTests)
+         .versionPath(surfaceNamer.getVersionIndexFileImportName())
++        .versionNamespace(
++            surfaceNamer.getNamespace(
++                new InterfaceView().getElementIterable(model).iterator().next()))
+         .build();
+   }
+ ","This just grabs any one of the proto services defined in the API, right? What happens when there are multiple (like with PubSub)?"
+9615,"@@ -40,7 +40,9 @@ def define_violation(model_name, dbengine):
+     """"""
+
+     base = declarative_base()
+-    violations_tablename = '{}_violations'.format(model_name)
++    # pylint: disable=too-many-format-args
++    violations_tablename = 'violations'.format(model_name)
++    # pylint: enable=too-many-format-args
+
+     class Violation(base):
+         """"""Row entry for a violation.""""""",Remove the pylint disable and remove the .format() from the string. The tablename is just 'violations'
+9616,"@@ -8,6 +8,16 @@ class Trail < ActiveRecord::Base
+
+   friendly_id :name, use: [:slugged, :finders]
+
++  # Override setters so it preserves the ordering
++  def exercise_ids=(new_exercise_ids)
++    super
++    new_exercise_ids = new_exercise_ids.reject(&:blank?).map(&:to_i)
++
++    new_exercise_ids.each_with_index do |exercise_id, index|
++      steps.where(exercise_id: exercise_id).update_all(position: index + 1)
++    end
++  end
++
+   def steps_remaining_for(user)
+     ExerciseWithProgressQuery.
+       new(user: user, exercises: exercises).",Will this implementation allow you to add new exercises to the trail?
+9617,"@@ -76,9 +76,17 @@ func trapSignalsPosix() {
+ 					caddyfileToUse = newCaddyfile
+ 				}
+
++				// Backup old event hooks
++				oldEventHooks := cloneEventHooks()
++
++				// Purge the old event hooks
++				purgeEventHooks()
++
+ 				// Kick off the restart; our work is done
+ 				_, err = inst.Restart(caddyfileToUse)
+ 				if err != nil {
++					eventHooks = oldEventHooks
++
+ 					log.Printf(""[ERROR] SIGUSR1: %v"", err)
+ 				}
+ ","Actually there is race condition here, because pointer assignment isn't atomic on some platform. But this is a rare case we should hit, we can just let it go for now. Maybe this is one of the TODO list."
+9618,"@@ -181,6 +181,10 @@ void lbann::distributed_io_buffer::calculate_num_iterations_per_epoch(int num_mo
+     max_mini_batch_size = data_reader->get_num_data();
+   }
+
++  bool partitioned = data_reader->is_partitioned();
++  //@todo ""if (partitioned)"" conditionals below assume one processor per model;
++  //      this needs to be revisited for cases with multiple cpus per model
++
+   /// Check to make sure that there is enough data for all of the parallel readers
+   int num_parallel_readers_per_model = compute_max_num_parallel_readers(data_reader->get_num_data(), max_mini_batch_size, m_requested_max_num_parallel_readers);
+   data_reader->set_num_parallel_readers(num_parallel_readers_per_model);",We should check somewhere here and in the partitioned_io_buffer that the max_mini_batch_size is properly computed for each model and that it is not aggregate (sum) for all models. The global/max_mini_batch_size should be as specified by the user in the prototext/cmd line.
+9619,"@@ -132,7 +132,7 @@ const Capability = {
+    * Defines how the driver should handle unexpected alerts. The value should
+    * be one of ""accept"", ""dismiss"", or ""ignore"".
+    */
+-  UNEXPECTED_ALERT_BEHAVIOR: 'unexpectedAlertBehavior',
++  UNEXPECTED_ALERT_BEHAVIOUR: 'unexpectedAlertBehaviour',
+
+   /** Defines the browser version. */
+   VERSION: 'version'","you can change the string value, but not the code constant"
+9620,"@@ -27,10 +27,10 @@ func TestBech32(t *testing.T) {
+ 		{""split1checkupstagehandshakeupstreamerranterredcaperred2y9e2w"", false},                   // invalid checksum
+ 		{""s lit1checkupstagehandshakeupstreamerranterredcaperredp8hs2p"", false},                   // invalid character (space) in hrp
+ 		{""spl"" + string(127) + ""t1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false}, // invalid character (DEL) in hrp
+-		{""split1cheo2y9e2w"", false}, // invalid character (o) in data part
+-		{""split1a2y9w"", false},      // too short data part
+-		{""1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false}, // empty hrp
+-		{""li1dgmt3"", false}, // Too short checksum
++		{""split1cheo2y9e2w"", false},                                                               // invalid character (o) in data part
++		{""split1a2y9w"", false},                                                                    // too short data part
++		{""1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false},                        // empty hrp
++		{""li1dgmt3"", false},                                                                       // Too short checksum
+ 		{""11qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqsqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8247j"", false}, // overall max length exceeded
+ 	}
+ ",File is not `goimports`-ed
+9621,"@@ -36,6 +36,6 @@ public class AzkabanExecServerModule extends AbstractModule {
+     bind(AzkabanExecutorServer.class).in(Scopes.SINGLETON);
+     bind(TriggerManager.class).in(Scopes.SINGLETON);
+     bind(FlowRunnerManager.class).in(Scopes.SINGLETON);
+-
++    // TODO: add ExecMetrics when guicy
+   }
+ }",Is this Todo necessary?
+9622,"@@ -108,10 +108,7 @@ class ErrorHandler(object):
+                         message = value[""value""]
+                         if not isinstance(message, basestring):
+                             value = message
+-                            try:
+-                                message = message['message']
+-                            except TypeError:
+-                                message = None
++                            message = message.get('message', None)
+                     else:
+                         message = value.get('message', None)
+                 except ValueError:",I would recommend to leave out `None` because None is already the default.
+9623,"@@ -97,6 +97,10 @@ const (
+
+ 	taskIDFlag    = ""task-id""
+ 	containerFlag = ""container""
++
++	valuesFlag        = ""values""
++	overwriteFlag     = ""overwrite""
++	inputFilePathFlag = ""cli-input-yaml""
+ )
+
+ // Short flag names.","I may have missed previous discussion on this; apologies if that's the case. What do you think about just `input-yaml`, without the `cli-`?"
+9624,"@@ -57,13 +57,14 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal
+
+         public async Task StartAsync(IConnectionHandler connectionHandler)
+         {
++            Exception error = null;
+             try
+             {
+                 connectionHandler.OnConnection(this);
+
+                 // Spawn send and receive logic
+                 Task receiveTask = DoReceive();
+-                Task sendTask = DoSend();
++                Task<Exception> sendTask = DoSend();
+
+                 // If the sending task completes then close the receive
+                 // We don't need to do this in the other direction because the kestrel",Nit: rename to sendError.
+9625,"@@ -7,6 +7,10 @@ Makes functions in .tools.command accessible directly from quilt.
+ # None: CLI params have not yet been parsed to determine mode.
+ _DEV_MODE = None
+
++# Suppress numpy warnings for Python 2.7
++import warnings
++warnings.filterwarnings(""ignore"", message=""numpy.dtype size changed"")
++
+
+ # Normally a try: except: block on or in main() would be better and simpler,
+ # but we load a bunch of external modules that take a lot of time, during which",`pylint` wants to know why this `import` isn't at the top of the file; and it's kinda right
+9626,"@@ -0,0 +1,19 @@
++package de.danoeh.antennapod.core.feed;
++
++public class FeedUrlNotFoundException extends RuntimeException {
++    private final String artistName;
++    private final String trackName;
++
++    public FeedUrlNotFoundException(String url, String trackName) {
++        this.artistName = url;
++        this.trackName = trackName;
++    }
++
++    public String getArtistName() {
++        return artistName;
++    }
++
++    public String getTrackName() {
++        return trackName;
++    }
++}","To me, using a `RuntimeException` for this feels a bit weird. I would just extend `Exception`, or maybe even `IoException`. Could you also please overwrite the `getMessage` function to return something like `""Result does not specify a feed url""`?"
+9627,"@@ -88,7 +88,8 @@ func convertStorage(ctx context.Context, msg *cepubsub.Message, sendMode ModeTyp
+ 		}
+ 	}
+ 	event.SetDataContentType(*cloudevents.StringOfApplicationJSON())
+-	event.SetData(msg.Data)
++	event.Data = msg.Data
++	event.DataEncoded = true
+ 	// Attributes are extensions.
+ 	if msg.Attributes != nil && len(msg.Attributes) > 0 {
+ 		for k, v := range msg.Attributes {",what was the issue here? why did you have to directly set?
+9628,"@@ -226,10 +226,8 @@ func (c *Command) proposals() {
+ 	for _, proposal := range proposals {
+ 		country := proposal.ServiceDefinition.LocationOriginate.Country
+ 		var countryString string
+-		if country != nil {
+-			countryString = *country
+-		} else {
+-			countryString = ""Unknown""
++		if len(country) == 0 {
++			country = ""Unknown""
+ 		}
+ 		msg := fmt.Sprintf(""- provider id: %v, proposal id: %v, country: %v"", proposal.ProviderID, proposal.ID, countryString)
+ 		info(msg)",I'm confusied - Isn't `countryString` left empty if `len(country)` != 0?
+9629,"@@ -53,7 +53,7 @@ DesktopSwitch::DesktopSwitch(const ILXQtPanelPluginStartupInfo &startupInfo) :
+     mLabelType(static_cast<DesktopSwitchButton::LabelType>(-1))
+ {
+     m_buttons = new QButtonGroup(this);
+-    connect (m_pSignalMapper, SIGNAL(mapped(int)), this, SLOT(setDesktop(int)));
++    connect (m_pSignalMapper, QOverload<int>::of(&QSignalMapper::mapped), this, &DesktopSwitch::setDesktop);
+
+     mLayout = new LXQt::GridLayout(&mWidget);
+     mWidget.setLayout(mLayout);","Would you please update this by using `#if (QT_VERSION >= QT_VERSION_CHECK(5,15,0))` and `QSignalMapper::mappedInt` for Qt >= 5.15?"
+9630,"@@ -262,6 +262,8 @@ func PopulateInstallRoot(installChroot *safechroot.Chroot, packagesToInstall []s
+ 		filesystemPkg = ""filesystem""
+ 	)
+
++	defer stopGPGAgent(installChroot)
++
+ 	ReportAction(""Initializing RPM Database"")
+
+ 	installRoot := filepath.Join(rootMountPoint, installChroot.RootDir())","This type of change opens a question on how we can cleanly shutdown or prevent all running agents so we do not run the risk of an agent holding kernel mountpoints, which can cause unsafe unmount/chroot exit. Will open a github issue to track this. This specific change itself is fine. It is a pointed change specifically for stopping the offending agent."
+9631,"@@ -3,6 +3,8 @@
+
+ package io.protostuff.runtime.model;
+
++import com.google.protobuf.CodedOutputStream;
++
+ public final class ModelProtobuf {
+   private ModelProtobuf() {
+   }","this file is model generated by protobuf, just for compatible test it's better not change it."
+9632,"@@ -8,8 +8,8 @@ class Analytics
+     @user = user
+   end
+
+-  def track_cancelled
+-    track(event: ""Cancelled"", properties: {})
++  def track_cancelled(reason)
++    track(event: ""Cancelled"", properties: { reason: reason })
+   end
+
+   def track_updated","It turns out we can send the reason as the property to Segment on the event. Then we can do whatever we want with it. In this case, I think we'll fire a web hook to Zapier which will add a note or message on the user in Intercom."
+9633,"@@ -0,0 +1,17 @@
++class PromotedCatalog
++  def initialize(catalog)
++    @catalog = catalog
++  end
++
++  def method_missing(message, *arguments)
++    catalog.send(message, *arguments).promoted
++  end
++
++  def respond_to_missing?(message, include_all = false)
++    catalog.send(:respond_to?, message, include_all)
++  end
++
++  private
++
++  attr_reader :catalog
++end",This class is very similar to `Catalog`. Is there a way to have this class compose a `Catalog` instance or extract a common class which they can both compose?
+9634,"@@ -164,9 +164,7 @@ TEST(""pull as device usm from host-allocated homogen table"") {
+         row_accessor<const float>{ data } //
+             .pull(q, { 1, 3 }, sycl::usm::alloc::device);
+
+-    const auto data_arr_host =
+-        la::matrix<float>::wrap(q, data_arr_device.get_data(), { row_count, column_count })
+-            .to_host();
++    const auto data_arr_host = la::matrix<float>::wrap(data_arr_device).to_host();
+     const float* data_arr_host_ptr = data_arr_host.get_data();
+
+     REQUIRE(data_arr_host_ptr[0] == 3.0f);",Why did you decide to drop the `queue` from parameters of `wrap` function? The agreement was that all functions for DPC++ case that accept non-host-accessible memory shall accept the queue directly.
+9635,"@@ -340,6 +340,11 @@ module RSpec
+       # @return [Symbol]
+       add_setting :detail_color
+
++      # @macro add_setting
++      # Hyperlink failed examples (default: `false`).
++      # @return [Boolean]
++      add_setting :hyperlink
++
+       # @macro add_setting
+       # Don't print filter info i.e. ""Run options: include {:focus=>true}""
+       # (default `false`).","I think this is a bad name, as its not clear what it does by name alone. If we merge this it should be something like `use_links_to_files_in_output` and should take either a custom scheme like `rspec` or default to `file`"
+9636,"@@ -65,6 +65,7 @@ public final class BaselineErrorProne implements Plugin<Project> {
+                                 .configure(ErrorProneOptions.class, errorProneOptions -> {
+                                     errorProneOptions.check(""Slf4jLogsafeArgs"", CheckSeverity.OFF);
+                                     errorProneOptions.check(""PreferSafeLoggableExceptions"", CheckSeverity.OFF);
++                                    errorProneOptions.check(""Slf4jConstantLogMessage"", CheckSeverity.OFF);
+                                 }));
+             });
+ ","Arguably this is actually still valuable for perf, maybe it should just be a warning?"
+9637,"@@ -35,6 +35,14 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	s.Addressbook.Put(address, addr)
++	if err := s.TopologyDriver.AddPeer(address); err != nil {
++		s.Logger.Debugf(""debug api: topologyDriver.AddPeer %s: %v"", addr, err)
++		s.Logger.Errorf(""unable to connect to peer %s"", addr)
++		jsonhttp.InternalServerError(w, err)
++		return
++	}
++
+ 	jsonhttp.OK(w, peerConnectResponse{
+ 		Address: address.String(),
+ 	})",didn't way say that the topology driver will actually insert the entries to the address book?
+9638,"@@ -24,11 +24,13 @@ import { removeNode } from '../util';
+  * Fragments that have siblings. In most cases, it starts out as `oldChildren[0]._dom`.
+  */
+ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context, isSvg, excessDomChildren, mounts, ancestorComponent, oldDom) {
+-	let childVNode, i, j, p, index, oldVNode, newDom,
++	let childVNode, i, j, oldVNode, newDom,
+ 		nextDom, sibDom, focus;
+
+ 	let newChildren = newParentVNode._children || toChildArray(newParentVNode.props.children, newParentVNode._children=[], coerceToVNode, true);
+-	let oldChildren = oldParentVNode!=null && oldParentVNode!=EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR;
++	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
++	// as EMPTY_OBJ._children should be `undefined`.
++	let oldChildren = oldParentVNode!=null && oldParentVNode._children || EMPTY_ARR;
+
+ 	let oldChildrenLength = oldChildren.length;
+ ",This seems safe to me. My guess is the original checks were a combination of before + after `oldParentVNode` became reliably a `(vnode | null)`.
+9639,"@@ -148,6 +148,10 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --conform FILE         Specify a schema the following schemas should be\n""
+     ""                         an evolution of. Gives errors if not.\n""
+     ""  --conform-includes     Include path for the schema given with --conform PATH\n""
++    ""  --filename-suffix      The suffix appended to the generated file names.\n""
++    ""                         Default is '_generated'.\n""
++    ""  --filename-ext         The extension appended to the generated file names.\n""
++    ""                         Default is language-specific (e.g., '.h' for C++)\n""
+     ""  --include-prefix       Prefix this path to any generated include statements.\n""
+     ""    PATH\n""
+     ""  --keep-prefix          Keep original prefix of schema include statement.\n""",also in the `.md` please.
+9640,"@@ -7,7 +7,9 @@ module Unix::Pkg
+   end
+
+   def install_package name
+-    if self['platform'] =~ /(fedora)|(centos)|(el)/
++    if self['platform'] =~ /(el-4)|(redhat-4)/
++      @logger.debug(""Package installation not supported on rhel4"")
++    elsif self['platform'] =~ /(fedora)|(centos)|(el)|(redhat)/
+       execute(""yum -y install #{name}"")
+     elsif self['platform'] =~ /(ubuntu)|(debian)/
+       execute(""apt-get update"")",RHEL is an acronym and is usually all caps. Why are you adding a redhat regex matcher?
+9641,"@@ -193,16 +193,6 @@ public class VectorizedColumnIterator extends BaseColumnIterator {
+     }
+   }
+
+-  public class FixedWidthTypeBinaryBatchReader extends BatchReader {
+-    @Override
+-    protected int nextBatchOf(
+-        final FieldVector vector, final int expectedBatchSize, final int numValsInVector, final int typeWidth,
+-        NullabilityHolder holder) {
+-      return vectorizedPageIterator.fixedWidthBinaryPageReader().nextBatch(vector, expectedBatchSize, numValsInVector,
+-          typeWidth, holder);
+-    }
+-  }
+-
+   public class BooleanBatchReader extends BatchReader {
+     @Override
+     protected int nextBatchOf(",Maybe I am daft but it looks like you removed fixed width readers but I don't see where you added any readers?
+9642,"@@ -16,6 +16,14 @@ import (
+
+ const DefaultManifestType = ManifestMantarayContentType
+
++const (
++	RootPath                      = ""/""
++	WebsiteIndexDocumentSuffixKey = ""website-index-document""
++	WebsiteErrorDocumentPathKey   = ""website-error-document""
++	EntryMetadataContentTypeKey   = ""Content-Type""
++	EntryMetadataFilenameKey      = ""Filename""
++)
++
+ var (
+ 	// ErrNotFound is returned when an Entry is not found in the manifest.
+ 	ErrNotFound = errors.New(""manifest: not found"")","@acud The reason I moved these here is because I need them in the traversal tests. The traversal package doesn't need this. I don't see any particular reason why any package apart from api would need this. api package imports traversal, so I cannot import api in traversal pkg. Also if these change in future, the traversal tests need to change. So maybe enough reason to move these here? That way both packages can access these as they both depend on manifest"
+9643,"@@ -560,6 +560,7 @@ class AbstractTab(QWidget):
+         self._mouse_event_filter = mouse.MouseEventFilter(
+             self, widget_class=self.WIDGET_CLASS, parent=self)
+         self.backend = None
++        self.pin = False
+
+         # FIXME:qtwebengine  Should this be public api via self.hints?
+         #                    Also, should we get it out of objreg?","I'd prefer this to be called `pinned` - also it should probably be in the `TabData` class instead, which is accessible as the `.data` attribute of the `BrowserTab` object - otherwise, `BrowserTab` would have a lot of quite ""random"" attributes :wink:"
+9644,"@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
+   private ChromeDriverCommand() {}
+
+   static final String LAUNCH_APP = ""launchApp"";
++  static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
++      = ""sendCommandForDownloadChromeHeadLess"";
++
+ }","Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way."
+9645,"@@ -1,6 +1,9 @@
+-/*global Audit, runRules, cleanupPlugins */
++/*global Audit */
+ /*eslint indent: 0*/
+-function runCommand(data, keepalive, callback) {
++import cleanupPlugins from './cleanup-plugins';
++import runRules from './run-rules';
++
++const runCommand = (data, keepalive, callback) => {
+ 	'use strict';
+ 	var resolve = callback;
+ 	var reject = function(err) {",Why not import audit as well?
+9646,"@@ -92,7 +92,9 @@ class CategoryDataFixture extends AbstractReferenceFixture
+                 . '(black-and-white), or in color, and in two or three dimensions',
+             ]
+         );
+-        $categoryData->parent = $this->getReference(self::CATEGORY_ELECTRONICS);
++        /** @var \Shopsys\ShopBundle\Model\Category\Category $categoryElectronics */
++        $categoryElectronics = $this->getReference(self::CATEGORY_ELECTRONICS);
++        $categoryData->parent = $categoryElectronics;
+         $this->createCategory($categoryData, self::CATEGORY_TV);
+
+         $categoryData->name = [","OK, i think there will be more of those..."
+9647,"@@ -12,6 +12,6 @@ return [
+     |
+     */
+
+-    'failed'   => 'These credentials do not match our records.',
+-    'throttle' => 'Too many login attempts. Please try again in :seconds seconds.',
++    'failed'   => 'Овие акредитиви не се совпаѓаат со нашите записи.',
++    'throttle' => 'Премногу обиди за најавување. Обидете се повторно за :seconds секунди.',
+ ];","Can you add : 'password' => 'The provided password is incorrect.', ?"
+9648,"@@ -18,6 +18,7 @@ from logHandler import log
+
+ from comtypes.gen.UIAutomationClient import *
+
++
+ #Some new win8 UIA constants that could be missing
+ UIA_StyleIdAttributeId=40034
+ UIA_AnnotationAnnotationTypeIdPropertyId=30113",Extraneous blank line.
+9649,"@@ -30,7 +30,7 @@ function ariaOwns(nodes, role) {
+ 		if (nodes[index] === null) {
+ 			continue;
+ 		}
+-		let virtualTree = axe.utils.getNodeFromTree(axe._tree[0], nodes[index]);
++		let virtualTree = axe.utils.getNodeFromTree(nodes[index]);
+ 		if (owns(nodes[index], virtualTree, role, true)) {
+ 			return true;
+ 		}","nitpick: use `const virtualTree`, I know it was `let` earlier."
+9650,"@@ -464,7 +464,10 @@ func (j *mdJournal) convertToBranch(
+ 		brmd.SetUnmerged()
+ 		brmd.SetBranchID(bid)
+
+-		// Delete the old ""merged"" version from the cache.
++		// Delete the old ""merged"" version from the cache.  We aren't
++		// equipped here to cache the new version, but it will
++		// eventually get passed via an mdFlushListener to somewhere
++		// that will cache it.
+ 		mdcache.Delete(tlfID, ibrmd.RevisionNumber(), NullBranchID)
+
+ 		// Re-sign the writer metadata.","Actually, I think it might be easier to do it here. Rough outline: 1. Save a list of the md cache keys and new brmd while looping. 2. After the loop, for each entry: 2a. Look up the old cache entry. If it doesn't exist, continue. 2b. Otherwise, make a deep copy of it, and replace its brmd with the newly-generated one. 2c. Delete the old cache entry, put the new cache entry. What do you think? The problem with the current approach is that the gap between dropping the old version and putting the new version is large enough that when we put the new version, we may be kicking out hotter cache entries. In this case, we'd be doing so to a lesser extent. Ideally, we'd be able to replace the entry in the MDCache LRU without changing the LRU info."
+9651,"@@ -253,6 +253,12 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine
+             }
+
+             source = source.Trim();
++
++            if(!FileHelper.IsRootedPath(source))
++            {
++                source = FileHelper.CombinePath(source);
++            }
++
+             if (!FileHelper.Exists(source))
+             {
+                 throw new CommandLineException(",We need tests for this
+9652,"@@ -47,11 +47,11 @@ func initProvider() func() {
+ 	// `localhost:30080` address. Otherwise, replace `localhost` with the
+ 	// address of your cluster. If you run the app inside k8s, then you can
+ 	// probably connect directly to the service through dns
+-	exp, err := otlp.NewExporter(
+-		otlp.WithInsecure(),
++	config := otlp.NewConnectionConfig(otlp.WithInsecure(),
+ 		otlp.WithAddress(""localhost:30080""),
+ 		otlp.WithGRPCDialOption(grpc.WithBlock()), // useful for testing
+ 	)
++	exp, err := otlp.NewExporter(config, config)
+ 	handleErr(err, ""failed to create exporter"")
+
+ 	bsp := sdktrace.NewBatchSpanProcessor(exp)",NewExporter takes in two arguments: a configuration for the metrics connection and one for the traces
+9653,"@@ -241,6 +241,15 @@ import connectionManager from 'connectionManager';
+         navigator.mediaSession.setActionHandler('seekforward', function () {
+             execute('fastForward');
+         });
++
++        /* eslint-disable-next-line compat/compat */
++        navigator.mediaSession.setActionHandler('seekto', function (object) {
++            let item = playbackManager.getPlayerState(playbackManager.getCurrentPlayer()).NowPlayingItem;
++            // Convert to ms
++            let duration = parseInt(item.RunTimeTicks ? (item.RunTimeTicks / 10000) : 0);
++            let wantedTime = object.seekTime * 1000;
++            playbackManager.seekPercent(wantedTime / duration * 100, currentPlayer);
++        });
+     }
+
+     events.on(playbackManager, 'playerchange', function () {",Why not use currentPlayer instead of playbackManager.getCurrentPlayer()?
+9654,"@@ -15,7 +15,8 @@ class UsersController < Clearance::UsersController
+   def create_user_from_params
+     params.require(:user).permit(
+       :email, :password, :name, :github_username, :bio, :organization,
+-      :address1, :address2, :city, :state, :zip_code, :country
++      :address1, :address2, :city, :state, :zip_code, :country,
++      :unsubscribed_from_emails
+     )
+   end
+ ","Avoid comma after the last parameter of a method call, unless each item is on its own line."
+9655,"@@ -52,7 +52,12 @@ type Config struct {
+
+ 	// DataDir is the directory data is saved to in order to preserve state
+ 	// across agent restarts. It is only used if ""Checkpoint"" is true as well.
++	// It is also used to keep the metadata of containers managed by the agent
++	// regardless of whether ""Checkpoint"" is set.
+ 	DataDir string
++	// DataDirOnHost is the directory in the instance from which we mount
++	// DataDir to the ecs-agent container and to agent managed containers
++	DataDirOnHost string
+ 	// Checkpoint configures whether data should be periodically to a checkpoint
+ 	// file, in DataDir, such that on instance or agent restarts it will resume
+ 	// as the same ContainerInstance. It defaults to false.",You should remove the outdated sentence.
+9656,"@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+             ""com.fsck.k9.activity.MessageCompose.quotedTextFormat"";
+     private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = ""numAttachmentsLoading"";
+     private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = ""waitingForAttachments"";
+-
++    private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmptySubject"";
+     private static final String LOADER_ARG_ATTACHMENT = ""attachment"";
+
+     private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = ""waitingForAttachment"";",Please restore the empty line after the group of `STATE_*` constants. This visual separation makes the code easier to read.
+9657,"@@ -213,9 +213,10 @@ module.exports = class GoldenRetriever extends Plugin {
+       this.IndexedDBStore.delete(fileID)
+     })
+
+-    this.core.on('core:success', (fileIDs) => {
++    this.core.on('core:complete', ({ successful }) => {
++      const fileIDs = successful.map((file) => file.id)
+       this.deleteBlobs(fileIDs).then(() => {
+-        this.core.log(`[GoldenRetriever] removed ${fileIDs.length} files that finished uploading`)
++        this.core.log(`RestoreFiles: removed ${successful.length} files that finished uploading`)
+       })
+     })
+ ","Unsure why this is `RestoreFiles` now vs `GoldenRetriever`, thought we deprecated the first?"
+9658,"@@ -436,6 +436,10 @@ namespace pwiz.Skyline.Controls.Graphs
+         {
+             // Match each file status with a progress control.
+             bool first = true;
++            var width = flowFileStatus.Width - 2 -
++                        (flowFileStatus.VerticalScroll.Visible
++                            ? SystemInformation.VerticalScrollBarWidth
++                            : 0);
+             foreach (var loadingStatus in status.ProgressList)
+             {
+                 var filePath = loadingStatus.FilePath;",Not sure what this is. Bad merge?
+9659,"@@ -171,7 +171,7 @@ func (v *veth) create(n *network, nspid int) (err error) {
+ 			netlink.LinkDel(veth)
+ 		}
+ 	}()
+-	if err := v.attach(&n.Network); err != nil {
++	if err = v.attach(&n.Network); err != nil {
+ 		return err
+ 	}
+ 	child, err := netlink.LinkByName(n.TempVethPeerName)","I'm confused, what did this actually fix? Is there a reason we are setting `err` in the parent scope to `nil` in this round-about way?"
+9660,"@@ -1103,6 +1103,10 @@ func TestApplyEnv_Image_HealthCheck(t *testing.T) {
+ 	}
+ }
+
++func TestApplyEnv_Platform(t *testing.T) {
++	// TODO: Add test for platform in the next PR
++}
++
+ func TestApplyEnv_Entrypoint(t *testing.T) {
+ 	testCases := map[string]struct {
+ 		inSvc  func(svc *LoadBalancedWebService)",Can we remove this   ?
+9661,"@@ -0,0 +1,7 @@
++class NewLanguageConfirmationsController < ApplicationController
++  def index
++    redirect_to welcome_to_upcase_path(
++      confirmation: true, language_selected: params[:language],
++    ), notice: ""Thanks for signing up. We will be in touch!""
++  end
++end",Put a comma after the last parameter of a multiline method call.
+9662,"@@ -48,12 +48,13 @@ func TestBlockDAO(t *testing.T) {
+ 		tsf3, err := testutil.SignedTransfer(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+
+-		// create testing votes
+-		vote1, err := testutil.SignedVote(testaddress.Addrinfo[""alfa""].String(), testaddress.Keyinfo[""alfa""].PriKey, 1, 100000, big.NewInt(10))
++		tsf4, err := testutil.SignedTransfer(testaddress.Addrinfo[""alfa""].String(), testaddress.Keyinfo[""alfa""].PriKey, 2, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+-		vote2, err := testutil.SignedVote(testaddress.Addrinfo[""bravo""].String(), testaddress.Keyinfo[""bravo""].PriKey, 1, 100000, big.NewInt(10))
++
++		tsf5, err := testutil.SignedTransfer(testaddress.Addrinfo[""bravo""].String(), testaddress.Keyinfo[""bravo""].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+-		vote3, err := testutil.SignedVote(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 1, 100000, big.NewInt(10))
++
++		tsf6, err := testutil.SignedTransfer(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 4, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+
+ 		// create testing executions",line is 195 characters (from `lll`)
+9663,"@@ -29,8 +29,11 @@ import (
+ 	""github.com/pkg/errors""
+ 	k8serror ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	klabels ""k8s.io/apimachinery/pkg/labels""
++	""k8s.io/apimachinery/pkg/types""
+ 	""k8s.io/apimachinery/pkg/util/runtime""
+ 	""k8s.io/client-go/tools/cache""
++	""k8s.io/kubernetes/pkg/util/slice""
+ )
+
+ var (","could not import k8s.io/kubernetes/pkg/util/slice (invalid package name: """") (from `typecheck`)"
+9664,"@@ -29,4 +29,4 @@ describeComponent(
+             expect(component._state).to.equal('inDOM');
+         });
+     }
+-);
++);",@disordinary would you be able to configure your editor to use the `.editorconfig` file so that we can avoid final newline changes?
+9665,"@@ -80,12 +80,9 @@ module.exports = function(realmConstructor, context) {
+     const { DefaultNetworkTransport } = require('realm-network-transport');
+     realmConstructor._networkTransport = new DefaultNetworkTransport();
+
+-    Object.defineProperty(realmConstructor.Object.prototype, ""toJSON"", {
+-        value: function () {
+-            const result = {}
+-            Object.keys(this).forEach(p => result[p] = this[p]);
+-            Object.keys(Object.getPrototypeOf(this)).forEach(p => result[p] = this[p]);
+-            return result;
++    Object.defineProperty(realmConstructor.Collection.prototype, ""toJSON"", {
++        value: function (_, cache = new Map()) {
++            return this.map((item, index) => item.toJSON ? item.toJSON(index.toString(), cache) : item);
+         },
+
+         writable: true,",I really think we should not use this style where unused arguments are named with underscore. While this eases the person writing the function it does it at an expense of readability and debugging. So next person who needs to actually use this argument will need to check the spec and rename this to `obj` and then use it or if he is debugging it he will is not able to watch for a meaningful variable name and will need to inspect `_` which is weird and uncomfortable. We have not used this style anywhere in the code while I agree its very tempting to use it :)
+9666,"@@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[])
+     // setup log4cxx
+     QRLogger::initLog4cxx(QRLogger::QRL_LOB);
+     // initialize lob globals
+-    lobGlobals = new ExLobGlobals();
++    lobGlobals = new ExLobGlobals(NULL);
+     if (lobGlobals == NULL)
+       return -1;
+ ","Thanks for avoiding the default value for the param. But, I think sending heap as NULL might make this program to fail. Have you tested this program? If you have tested this program already, then this PR is ready to be merged."
+9667,"@@ -0,0 +1,18 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MS-PL license.
++// See the LICENSE file in the project root for more information.
++
++using MvvmCross.Presenters.Attributes;
++using Windows.UI.Xaml.Controls;
++
++namespace MvvmCross.Platforms.Uap.Presenters.Attributes
++{
++    public sealed class MvxModalViewPresentationAttribute : MvxBasePresentationAttribute
++    {
++        public MvxModalViewPresentationAttribute()
++        {
++        }
++
++        public ContentDialogPlacement Placement { get; set; }
++    }
++}",Don't make it sealed
+9668,"@@ -278,6 +278,8 @@ func (a *Account) shallowCopy() *Account {
+ 	}
+ 	// JetStream
+ 	na.jsLimits = a.jsLimits
++	// Server config account limits.
++	na.limits = a.limits
+
+ 	return na
+ }",Did we miss that for jwt before?
+9669,"@@ -44,10 +44,10 @@ const (
+
+ // UART1 on the Trinket M0.
+ var (
+-	UART1 = UART{Bus: sam.SERCOM1_USART,
++	UART1 = UART{
+ 		Buffer: NewRingBuffer(),
+-		Mode:   PinSERCOM,
+-		IRQVal: sam.IRQ_SERCOM1,
++		Bus:    sam.SERCOM0_USART,
++		SERCOM: 0,
+ 	}
+ )
+ ","It appears that using SERCOM1 was a bug: the only SERCOM that is supported on the TX/RX pins is SERCOM0. Previous UART support wouldn't have worked on the Trinket M0 TX/RX pins anyway (`PA06`/`PA07`). This PR fixes that, and should thereby add support for UART on the Trinket M0."
+9670,"@@ -179,7 +179,8 @@ class Preference extends Model
+     public function getLocaleOptions()
+     {
+         $localeOptions = [
+-            'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++						'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
+             'cs' => [Lang::get('system::lang.locale.cs'), 'flag-cz'],
+             'da' => [Lang::get('system::lang.locale.da'), 'flag-dk'],
+             'en' => [Lang::get('system::lang.locale.en'), 'flag-us'],","Spaces for indentation, not tabs"
+9671,"@@ -117,15 +117,11 @@ cvdescriptorset::DescriptorSetLayoutDef::DescriptorSetLayoutDef(const VkDescript
+     assert(bindings_.size() == binding_count_);
+     assert(binding_flags_.size() == binding_count_);
+     uint32_t global_index = 0;
+-    binding_to_global_index_range_map_.reserve(binding_count_);
+-    // Vector order is finalized so create maps of bindings to descriptors and descriptors to indices
++    global_index_range_.reserve(binding_count_);
++    // Vector order is finalized so build vectors of descriptors and dynamic offsets by binding index
+     for (uint32_t i = 0; i < binding_count_; ++i) {
+-        auto binding_num = bindings_[i].binding;
+         auto final_index = global_index + bindings_[i].descriptorCount;
+-        binding_to_global_index_range_map_[binding_num] = IndexRange(global_index, final_index);
+-        if (final_index != global_index) {
+-            global_start_to_index_map_[global_index] = i;
+-        }
++        global_index_range_.emplace_back(global_index, final_index);
+         global_index = final_index;
+     }
+ ","doing this as a binding map was insane, but with the ConstBindingIterator to hide the binding->index gunk and avoid the hashes during access it sticks out."
+9672,"@@ -27,6 +27,8 @@ TEST_EVENT_PATTERN = {
+     'Detail': [EVENT_DETAIL]
+ }
+
++TEST_EVENT_PATTERN_1 = {'detail': {'EventType': ['0', '1']}}
++
+
+ class EventsTest(unittest.TestCase):
+     def setUp(self):","nitpick: I'd rather move this into the test method directly (we should avoid variables at the root scope if they are not reused in multiple places). (not critical, though - shouldn't hold back the merge..)"
+9673,"@@ -212,7 +212,12 @@ namespace TestPerf // Note: tests in the ""TestPerf"" namespace only run when the
+             {
+                 RunUI(() => importPeptideSearchDlg.ClickNextButtonNoCheck());
+             }
+-            // Modifications are already set up, so that page should get skipped.
++            // Skip Match Modifications page.
++            RunUI(() =>
++            {
++                AssertEx.IsTrue(importPeptideSearchDlg.CurrentPage == ImportPeptideSearchDlg.Pages.match_modifications_page);
++                AssertEx.IsTrue(importPeptideSearchDlg.ClickNextButton());
++            });
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.PrecursorCharges = new []{2,3,4,5});
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.PrecursorMassAnalyzer = FullScanMassAnalyzerType.tof);
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.IonMobilityFiltering.IsUseSpectralLibraryIonMobilities = useDriftTimes);","You should do: AssertEx.AreEqual(importPeptideSearchDlg.CurrentPage, ImportPeptideSearchDlg.Pages.match_modifications_page);"
+9674,"@@ -145,7 +145,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+       String schemaId = entry.getKey();
+       String content = entry.getValue();
+       GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas);
+-      boolean exists = existSchema != null;
++      boolean exists = existSchema != null && existSchema.getSummary() != null;
+       LOGGER.info(""schemaId [{}] exists {}"", schemaId, exists);
+       if (!exists) {
+         if (!srClient.registerSchema(microservice.getServiceId(), schemaId, content)) {","SC support batch register schemas we should swtich to new api be careful that maybe will send too big request, need to split to multi request by max size of limit."
+9675,"@@ -25,8 +25,8 @@ func NewConfig(options *compileopts.Options) (*compileopts.Config, error) {
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""could not read version from GOROOT (%v): %v"", goroot, err)
+ 	}
+-	if major != 1 || minor < 11 || minor > 14 {
+-		return nil, fmt.Errorf(""requires go version 1.11, 1.12, 1.13, or 1.14, got go%d.%d"", major, minor)
++	if major != 1 || minor < 11 || minor > 15 {
++		return nil, fmt.Errorf(""requires go version 1.11, 1.12, 1.13, 1.14, or 1.15, got go%d.%d"", major, minor)
+ 	}
+ 	clangHeaderPath := getClangHeaderPath(goenv.Get(""TINYGOROOT""))
+ 	return &compileopts.Config{","At this point, maybe it would make more sense to write this as a range rather than listing specific versions?"
+9676,"@@ -255,6 +255,11 @@ func (p Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
+ 			return http.StatusRequestEntityTooLarge, backendErr
+ 		}
+
++		// TODO: write an 499 HTTP status as constant in someplace (and also change in proxy_test.go on line: expectedStatus, expectErr := 499, context.Canceled)
++		if backendErr == context.Canceled {
++			return 499, backendErr
++		}
++
+ 		// failover; remember this failure for some time if
+ 		// request failure counting is enabled
+ 		timeout := host.FailTimeout",I guess we can start by putting the `const StatusContextCancelled = 499` at the bottom of this file
+9677,"@@ -100,6 +100,7 @@ func TestPaymentChannelVoucher(t *testing.T) {
+ 			types.NewChannelID(5),
+ 			types.NewAttoFILFromFIL(10),
+ 			types.NewBlockHeight(0),
++			nil,
+ 		)
+ 		require.NoError(err)
+ 		assert.Equal(expectedVoucher.Channel, voucher.Channel)",Blocking: populate a non-empty value and check it below.
+9678,"@@ -194,7 +194,14 @@ public class Permission {
+     // Users with this permission can upload projects when the property ""lockdown.upload.projects""
+     // is turned on
+     UPLOADPROJECTS(0x0008000),
+-    ADMIN(0x8000000);
++    ADMIN(0x8000000),
++    // Permissions for image management APIs.
++    CREATE(0x0000100),
++    GET(0x0000200),
++    UPDATE(0x0000300),
++    DELETE(0x0000400),
++    IMAGE_TYPE_ADD_MEMBER(0x0000500),
++    IMAGE_TYPE_DELETE_MEMBER(0x0000600);
+
+     private final int numVal;
+ ",What is this number value for? How is it used?
+9679,"@@ -192,6 +192,11 @@ describe Travis::Build::Script::R, :sexp do
+                            assert: true, echo: true, retry: true, timing: true]
+     end
+
++    it 'does BiocCheck if requested' do
++      data[:config][:bioc_check] = true
++      should include_sexp [:cmd, /.*BiocCheck.*/,
++                           assert: true, echo: true, timing: true]
++
+     it 'does install bioc with bioc_packages' do
+       data[:config][:bioc_packages] = ['GenomicFeatures']
+       should include_sexp [:cmd, /.*biocLite.*/,",This needs an end keyword
+9680,"@@ -0,0 +1,17 @@
++// <copyright file=""DependencyTelemetryData.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Telemetry
++{
++    /// <summary>
++    /// Using a record as used as dictionary key so getting equality comparison for free
++    /// </summary>
++    internal record DependencyTelemetryData
++    {
++        public string Name { get; set; }
++
++        public string Version { get; set; }
++    }
++}",I think this is the first record type in Datadog.Trace!
+9681,"@@ -737,10 +737,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             {
+                 return Task.CompletedTask;
+             }
+-            else
+-            {
+-                return FireOnCompletedAwaited(onCompleted);
+-            }
++            return FireOnCompletedAwaited(onCompleted);
+         }
+
+         private async Task FireOnCompletedAwaited(Stack<KeyValuePair<Func<object, Task>, object>> onCompleted)",Nit: missing newline above.
+9682,"@@ -76,6 +76,13 @@ func StartKubeProxy(k8s kubernetes.Interface, hostname string,
+ 	}
+
+ 	go func() {
++		// Before we start, scan for all finished / timed out connections to
++		// free up the conntrack table asap as it may take time to sync up the
++		// proxy and kick off the first full cleaner scan.
++		lc := conntrack.NewLivenessScanner(kp.conntrackTimeouts, kp.dsrEnabled)
++		connScan := conntrack.NewScanner(kp.ctMap, lc.ScanEntry)
++		connScan.Scan()
++
+ 		err := kp.start()
+ 		if err != nil {
+ 			log.WithError(err).Panic(""kube-proxy failed to start"")","Since it's a one-off, worth putting an info log before and after."
+9683,"@@ -140,8 +140,10 @@ app.controller('CalController', ['$scope', 'Calendar', 'CalendarService', 'VEven
+ 				$scope.$apply();
+ 			});
+ 		} else {
+-			$scope.calendarsPromise = CalendarService.getPublicCalendar(constants.publicSharingToken).then(function(calendar) {
+-				$scope.calendars = [calendar];
++			constants.publicSharingToken.split(""."").forEach( (token) => {
++				$scope.calendarsPromise = CalendarService.getPublicCalendar(token).then(function(calendar) {
++					$scope.calendars.push(calendar);
++			});
+ 				is.loading = false;
+ 				// TODO - scope.apply should not be necessary here
+ 				$scope.$apply();","I'm sorry, but the indentation is still wrong. This should be indented by one tab."
+9684,"@@ -360,6 +360,18 @@ class DataFrame(_Frame):
+         self._sdf = sdf
+         self._metadata = self._metadata.copy(column_fields=names)
+
++    @property
++    def dtypes(self):
++        """"""Return the dtypes in the DataFrame.
++
++        This returns a Series with the data type of each column. The result's index is the original
++        DataFrame's columns. Columns with mixed types are stored with the object dtype.
++
++        :return: :class:`pd.Series` The data type of each column.
++        """"""
++        return pd.Series([self[col].dtype for col in self._metadata.column_fields],
++                         index=self._metadata.column_fields)
++
+     @derived_from(pd.DataFrame, ua_args=['axis', 'level', 'numeric_only'])
+     def count(self):
+         return self._sdf.count()",can we add an example?
+9685,"@@ -156,6 +156,13 @@ func identifyUID(ctx context.Context, nug normalizedUsernameGetter,
+ func identifyUser(ctx context.Context, nug normalizedUsernameGetter,
+ 	identifier identifier, username libkb.NormalizedUsername,
+ 	uid keybase1.UID, isPublic bool) error {
++
++	// check to see if identify should be skipped altogether
++	ei := getExtendedIdentify(ctx)
++	if ei.behavior == keybase1.TLFIdentifyBehavior_CHAT_SKIP {
++		return nil
++	}
++
+ 	var reason string
+ 	if isPublic {
+ 		reason = ""You accessed a public folder.""",We usually avoid blank lines at the start of functions.
+9686,"@@ -0,0 +1,18 @@
++<?php
++
++declare(strict_types=1);
++
++/*
++ * This file is part of the Sonata Project package.
++ *
++ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
++ *
++ * For the full copyright and license information, please view the LICENSE
++ * file that was distributed with this source code.
++ */
++
++use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
++
++return static function (ContainerConfigurator $containerConfigurator): void {
++    $containerConfigurator->services();
++};",I dont think this line is needed
+9687,"@@ -22,7 +22,12 @@ const (
+ // requests w.r.t a single Volume.
+ func (s *HTTPServer) volumeSpecificRequest(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
+ 	// check the feature gate & switch if enabled
+-	if util.CASTemplateFeatureGate() {
++	feature, err := util.CASTemplateFeatureGate()
++	if err != nil {
++		// exit if invalid value
++		glog.Fatalf(""invalid feature gate value for %s only boolean values allowed"", util.CASTemplateFeatureGateENVK)
++	}
++	if feature {
+ 		return s.volumeV1alpha1SpecificRequest(resp, req)
+ 	}
+ ",We should not panic here !!! We return error i.e. 500 http code
+9688,"@@ -1305,8 +1305,16 @@ nano:       use nanosecond-precision (requires libpcap >= 1.5.0)
+             else:
+                 pkt = pkt.__iter__()
+             for p in pkt:
++
+                 if not self.header_present:
+                     self._write_header(p)
++
++                if self.linktype != conf.l2types.get(type(p), None):
++                    warning(""Inconsistent linktypes detected!""
++                            "" The resulting PCAP file might contain""
++                            "" invalid packets.""
++                            )
++
+                 self._write_packet(p)
+
+     def _write_packet(self, packet, sec=None, usec=None, caplen=None,","To avoid useless calls to `conf.l2types.get()` we could have a `set()` of types that are OK in this PCAP files. We could check if `p.__class__ not in self.l2_types_seen` first, only run this code block in that case, and add `self.l2_types_seen.add(p.__class__)`. I'm not sure if I'm clear here... let me know what you think."
+9689,"@@ -129,6 +129,11 @@ public class Constants {
+   // Used (or should be used) wherever a string representation of UTF_8 charset is needed:
+   public static final String UTF_8 = java.nio.charset.StandardCharsets.UTF_8.toString();
+
++  // Specifies the source(adhoc, scheduled, flow_trigger) from where flow execution is triggered
++  public static final String EXECUTION_SOURCE_ADHOC = ""adhoc"";
++  public static final String EXECUTION_SOURCE_SCHEDULED = ""scheduled"";
++  public static final String EXECUTION_SOURCE_FLOW_TRIGGER = ""flow_trigger"";
++
+   public static class ConfigurationKeys {
+
+     public static final String AZKABAN_GLOBAL_PROPERTIES_EXT_PATH = ""executor.global.properties"";","Shouldn't ""source"" be a noun? How about? -EXECUTION_SOURCE_USER -EXECUTION_SOURCE_SCHEDULE -EXECUTION_SOURCE_EVENT (because it's an event based trigger mechanism)"
+9690,"@@ -1,6 +1,6 @@
+ _base_ = [
+     '../_base_/models/mask_rcnn_r50_fpn.py',
+-    '../_base_/datasets/coco_instance.py',
++    '../_base_/datasets/lvis_v1_instance.py',
+     '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py'
+ ]
+ model = dict(",Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.
+9691,"@@ -24,6 +24,8 @@ describe('th-has-data-cells', function () {
+ 			'<table>' +
+ 			'  <tr> <th>hi</th> <td>hello</td> </tr>' +
+ 			'  <tr> <th>hi</th> <td>hello</td> </tr>' +
++			'  <tr> <td>hello</td> <th>hi</th> </tr>' +
++			'  <tr> <td>hello</td> <th>hi</th> </tr>' +
+ 			'</table>';
+
+ 		var node = fixture.querySelector('table');","Last time I checked, this technique did not work on all major screen reader - browser combinations. What screen readers have you tested?"
+9692,"@@ -180,6 +180,8 @@ namespace Datadog.Trace.Configuration
+
+             TraceBatchInterval = source?.GetInt32(ConfigurationKeys.SerializationBatchInterval)
+                         ?? 100;
++
++            AspnetRouteTemplateResourceNamesEnabled = IsFeatureFlagEnabled(ConfigurationKeys.FeatureFlags.AspnetRouteTemplateResourceNamesEnabled);
+         }
+
+         /// <summary>","Most tracer settings can be set in several ways: environment variables, `app.config`/`web.config` file, or in a json file (`~/datadog.json` by default). Most exceptions to this rule are settings in native code (where we use env vars only). Currently, `DD_TRACE_ASPNET_ROUTE_TEMPLATE_RESOURCE_NAMES_ENABLED` will only work as an env var. Was this limitation intentional?"
+9693,"@@ -218,4 +218,10 @@ type Config struct {
+
+ 	// TaskMetadataBurstRate specifies the burst rate throttle for the task metadata endpoint
+ 	TaskMetadataBurstRate int
++
++	// NoIID when set to true, specifies that the agent should not register the instance
++	// with instance identity document. This is required in order to accomodate scenarios in
++	// which ECS agent tries to register the instance where the instance id document is
++	// not available or needed
++	NoIID bool
+ }","Would ""DisableIID"" be a better name? For example, we used DisableMetrics, ImageCleanupDisabled, ... etc. for other similar fields."
+9694,"@@ -3908,7 +3908,7 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb)
+             BBPRINT(bb, 3, ""reached end pc "" PFX "", stopping\n"", bb->stop_pc);
+             break;
+         }
+-        if (total_instrs > DYNAMO_OPTION(max_bb_instrs)) {
++        if (total_instrs == DYNAMO_OPTION(max_bb_instrs) - 1) {
+             /* this could be an enormous basic block, or it could
+              * be some degenerate infinite-loop case like a call
+              * to a function that calls exit() and then calls itself,","So this is a swing of 2: but I think we only need to reduce by 1? The artificial jump added on truncation is not passed to clients: it's like other mangling added later. So if `-max_bb_instrs 4` means 4 app instrs passed to clients, we'd want ==, not ==-1, right? Plus, if we did want -1 and to stop at 3 instead of 4, this is not sufficient: the inner loop above currently has `total_instrs <= cur_max_bb_instrs`."
+9695,"@@ -362,7 +362,7 @@ LmExprResult CreateLmOutputExpr(const NAType &formalType,
+ // specified type t to be converted to/from C strings. The only
+ // SQL types that do not need to be converted to C strings are:
+ //
+-//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION
++//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION, BOOLEAN
+ //
+ // because these types map to Java primitive types:
+ //","Does Tinyint belong to this set of types? I suppose the answer is No, but thought it safer to check."
+9696,"@@ -1110,6 +1110,17 @@ Blockly.WorkspaceSvg.prototype.isDeleteArea = function(e) {
+   return Blockly.DELETE_AREA_NONE;
+ };
+
++/**
++ * Is the mouse event outside the blocks UI, to the right of the workspace?
++ * @param {!Event} e Mouse move event.
++ * @return {boolean} True if event is outside the blocks UI.
++ */
++Blockly.WorkspaceSvg.prototype.isOutside = function(e) {
++  var mousePoint = Blockly.utils.mouseToSvg(e, this.getParentSvg(),
++      this.getInverseScreenCTM());
++  return this.getParentSvg().width.baseVal.value < mousePoint.x;
++};
++
+ /**
+  * Handle a mouse-down on SVG drawing surface.
+  * @param {!Event} e Mouse down event.","I'm a bit leery of this implementation, because it assumes that the only ""outside"" is to the right side. Note that Blockly assumes that there's nothing useful to the ""outside"" of the toolbox, based on the configuration of the workspace, so it's not like we're doing the right thing either. I think this will break in RTL. If you keep the editor in the same place but inject with RTL, everything you're looking for will be in the delete area. If the editor and stage swap places, this will just be looking on the wrong side."
+9697,"@@ -180,6 +180,7 @@ type Config struct {
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail""`
+
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
++	NatPortRange       numorstring.Port   `config:""portrange;;local""`
+
+ 	UsageReportingEnabled          bool          `config:""bool;true""`
+ 	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`",Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only
+9698,"@@ -2322,7 +2322,7 @@ bool DiscoveryDataBase::from_json(
+             }
+
+             // Add Participant
+-            auto wit = writers_.insert(std::make_pair(guid_aux, dei));
++            writers_.insert(std::make_pair(guid_aux, dei));
+
+             // Extra configurations for writers
+             // Add writer to writers_by_topic. This will create the topic if necessary","That's a tricky one, as the variable is indeed used in line 2346, which is a `logInfo` message that is not compiled unless `INTERNAL_DEBUG` is set or `CMAKE_BUILD_TYPE` is set to `Debug`. Our CI builds with `INTERNAL_DEBUG` to verify that all `logInfo` are correct, and thus we don't get the warning. The best is probably to remove the iterator (as you did), as well as the part of the log that uses it."
+9699,"@@ -600,7 +600,7 @@ class L3PacketSocket(L2Socket):
+         # type: (Packet) -> int
+         iff = x.route()[0]
+         if iff is None:
+-            iff = conf.iface
++            iff = network_name(conf.iface)
+         sdto = (iff, self.type)
+         self.outs.bind(sdto)
+         sn = self.outs.getsockname()",I suspect L2Socket needs a similar change (line 502) for the case where `iface` is None (line 479)
+9700,"@@ -0,0 +1,3 @@
++ActiveAdmin.register LicensePermission do
++  permit_params :name, :description, :icon
++end",Was this all that was needed to add CRUD operations for the LicensePermission model? :-)
+9701,"@@ -465,7 +465,7 @@ def installAddon(parentWindow, addonPath):
+
+ 	prevAddon = None
+ 	for addon in addonHandler.getAvailableAddons():
+-		if not addon.isPendingRemove and bundle.name==addon.manifest['name']:
++		if not addon.isPendingRemove and bundle.name.lower()==addon.manifest['name'].lower():
+ 			prevAddon=addon
+ 			break
+ 	if prevAddon:",Did you look for other locations that compare name? I expected there to be more.
+9702,"@@ -47,6 +47,9 @@ public final class BaselineTesting implements Plugin<Project> {
+                         .findAny()
+                         .ifPresent(ignored -> enableJUnit5ForAllTestTasks(project));
+             });
++
++            // Never cache test tasks, until we work out the correct inputs for ETE / integration tests
++            project.getTasks().withType(Test.class).configureEach(test -> test.getOutputs().cacheIf(task -> false));
+         });
+     }
+ ",There were some requests internally to allow users to opt out of this behaviour. We could expose a property that allows people to toggle ti
+9703,"@@ -300,10 +300,11 @@ public class TestIndexWriterDelete extends LuceneTestCase {
+     modifier.close();
+     dir.close();
+   }
+-
++
+   public void testDeleteAllNoDeadLock() throws IOException, InterruptedException {
+     Directory dir = newDirectory();
+-    final RandomIndexWriter modifier = new RandomIndexWriter(random(), dir);
++    final RandomIndexWriter modifier = new RandomIndexWriter(random(), dir,
++        newIndexWriterConfig().setMergePolicy(new MockRandomMergePolicy(random())));
+     int numThreads = atLeast(2);
+     Thread[] threads = new Thread[numThreads];
+     final CountDownLatch latch = new CountDownLatch(1);",Nice -- this forced `merge-on-getReader/commit` to be used more often in this test?
+9704,"@@ -221,6 +221,9 @@ type ConsensusParams struct {
+
+ 	// sum of estimated op cost must be less than this
+ 	LogicSigMaxCost uint64
++
++	// a precision for assets
++	SupportAssetsPrecision bool
+ }
+
+ // Consensus tracks the protocol-level settings for different versions of the","Instead of a `bool`, can we just call this `MaxAssetDecimals` and have it be a `uint8`/`uint16`/`uint32` whose value is 0 before the upgrade and 19 after (2**64 - 1 is 20 decimal digits)? We'll need to set a maximum value anyway, and that way there's only one new proto variable instead of two."
+9705,"@@ -145,7 +145,10 @@ final class EntityRepository implements EntityRepositoryInterface
+
+             if ($sortFieldIsDoctrineAssociation) {
+                 $sortFieldParts = explode('.', $sortProperty, 2);
+-                $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
++                // check if join has been added once before.
++                if (!\in_array($sortFieldParts[0], $aliases)) {
++                    $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
++                }
+
+                 if (1 === \count($sortFieldParts)) {
+                     $queryBuilder->addOrderBy('entity.'.$sortProperty, $sortOrder);",where `$aliases` is defined ? @javiereguiluz
+9706,"@@ -66,12 +66,9 @@ func (h *Handler) FetchJWTSVID(ctx context.Context, req *workload.JWTSVIDRequest
+ 	var spiffeIDs []string
+ 	identities := h.Manager.MatchingIdentities(selectors)
+ 	if len(identities) == 0 {
+-		telemetry_common.AddRegistered(counter, false)
+ 		return nil, status.Errorf(codes.PermissionDenied, ""no identity issued"")
+ 	}
+
+-	telemetry_common.AddRegistered(counter, true)
+-
+ 	for _, identity := range identities {
+ 		if req.SpiffeId != """" && identity.Entry.SpiffeId != req.SpiffeId {
+ 			continue",what is the justification for the removal of the registered label? it doesn't seem to have high cardinality nor is it redundant. Seems useful to shed insight into understand situations where workloads aren't registered....
+9707,"@@ -1835,3 +1835,7 @@ func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDepl
+ 		DeploymentChain: dc,
+ 	}, nil
+ }
++
++func (a *WebAPI) ListEvents(ctx context.Context, req *webservice.ListEventsRequest) (*webservice.ListEventsResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""Not implemented"")
++}",`ctx` is unused in ListEvents
+9708,"@@ -101,6 +101,14 @@ public class SmartStoreTest extends SmartStoreTestCase {
+         Assert.assertTrue(""ENABLE_JSON1 flag not found in compile options"", compileOptions.contains(""ENABLE_JSON1""));
+ 	}
+
++	/**
++	 * Checking sqlcipher version
++	 */
++	@Test
++	public void testSQLCipherVersion() {
++		Assert.assertEquals(""Wrong sqlcipher version"", ""4.0.1 community"", store.getSQLCipherVersion());
++	}
++
+ 	/**
+ 	 * Method to check soup blob with one stored by db. Can be overridden to check external storage if necessary.
+ 	 */",We've had that test on iOS for years.
+9709,"@@ -37,7 +37,7 @@ namespace BenchmarkDotNet.Extensions
+                     .DontEnforcePowerPlan(); // make sure BDN does not try to enforce High Performance power plan on Windows
+
+                 // See https://github.com/dotnet/roslyn/issues/42393
+-                job = job.WithArguments(new Argument[] { new MsBuildArgument(""/p:DebugType=portable"") });
++                job = job.WithArguments(new Argument[] { new MsBuildArgument(""/p:DebugType=portable""), new MsBuildArgument(""-bl:benchmarkdotnet.binlog"") });
+             }
+
+             var config = ManualConfig.CreateEmpty()",This is for creating binlog file for building bdn generated template project. I feel that it's may be helpful in general for bdn diagnostic purpose.
+9710,"@@ -359,6 +359,18 @@ class QuteProc(testprocess.Process):
+         else:
+             self.send_cmd(':open ' + url)
+
++    def open_url(self, url, *, new_tab=False, new_window=False):
++        """"""Open the given url in qutebrowser.""""""
++        if new_tab and new_window:
++            raise ValueError(""new_tab and new_window given!"")
++
++        if new_tab:
++            self.send_cmd(':open -t ' + url)
++        elif new_window:
++            self.send_cmd(':open -w ' + url)
++        else:
++            self.send_cmd(':open ' + url)
++
+     def mark_expected(self, category=None, loglevel=None, message=None):
+         """"""Mark a given logging message as expected.""""""
+         line = self.wait_for(category=category, loglevel=loglevel,",Can you adjust `open_path` to simply call `path_to_url` and then `open_url` instead of duplicating the code?
+9711,"@@ -24,10 +24,10 @@ import (
+ var logGraphsyncFetcher = logging.Logger(""net.graphsync_fetcher"")
+
+ const (
+-	// Timeout for a single graphsync request (which may be for many blocks).
+-	// We might prefer this timeout to scale with the number of blocks expected in the fetch,
+-	// when that number is large.
+-	requestTimeout = 60 * time.Second
++	// Timeout for a single graphsync request getting ""stuck""
++	// -- if no more responses are received for a period greater than this,
++	// we will assume the request has hung-up and cancel it
++	unresponsiveTimeout = 10 * time.Second
+ )
+
+ // Fetcher defines an interface that may be used to fetch data from the network.",I'm curious -- do we have information on the upper bound of the delay we would expect with high probability from a peer with no network issues? My intuition is that we want to set this as low as we can reasonably get away with before we start killing productive connections. My uninformed intuition is also that 10 seconds is probably higher than we need and I'd love to know if this is wrong and 10 seconds is already pushing the limit.
+9712,"@@ -44,7 +44,7 @@ public class SarOperation extends AbstractFixedCostOperation {
+     } else {
+       final int shiftAmountInt = shiftAmount.toInt();
+
+-      if (shiftAmountInt >= 256) {
++      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
+         frame.pushStackItem(negativeNumber ? ALL_BITS : UInt256.ZERO);
+       } else {
+         // first perform standard shift right.",what happens if it's == 0
+9713,"@@ -27,10 +27,6 @@ module Bolt
+           if @config['interpreters']
+             @config['interpreters'] = normalize_interpreters(@config['interpreters'])
+           end
+-
+-          if Bolt::Util.windows? && @config['run-as']
+-            raise Bolt::ValidationError, ""run-as is not supported when using PowerShell""
+-          end
+         end
+       end
+     end","We could potentially log a message here instead that indicates the transport does not support `run-as` on Windows and will be ignored, just in case users expect it to and are surprised. Since it would _always_ be logged when using `--run-as` on Windows, even when the transport isn't being used, it would probably want to be either at debug or trace level."
+9714,"@@ -4,7 +4,7 @@ import (
+ 	neturl ""net/url""
+ 	""strings""
+
+-	""github.com/bonitoo-io/go-sql-bigquery""
++	bigquery ""github.com/bonitoo-io/go-sql-bigquery""
+ 	""github.com/go-sql-driver/mysql""
+ 	""github.com/influxdata/flux/codes""
+ 	""github.com/influxdata/flux/dependencies/url""",Did we need this alias? Or is it just a holdout from development?
+9715,"@@ -72,7 +72,7 @@ class EditTest < ActiveSupport::TestCase
+     p.update_attributes(organization_id: org.id)
+     edit = PropertyEdit.where(target: p, key: 'organization_id').first
+     edit.project_id.must_equal p.id
+-    edit.organization_id.must_equal org.id
++    edit.value.must_equal org.id.to_s
+   end
+
+   it 'test_that_nothing_gets_filled_in_automatically_for_license_edits' do",This should have failed before.
+9716,"@@ -56,7 +56,8 @@ namespace Datadog.Trace.Vendors.Serilog.Sinks.File
+                 ""(?<"" + PeriodMatchGroup + "">\\d{"" + _periodFormat.Length + ""})"" +
+                 ""(?<"" + SequenceNumberMatchGroup + "">_[0-9]{3,}){0,1}"" +
+                 Regex.Escape(_filenameSuffix) +
+-                ""$"");
++                ""$"",
++                RegexOptions.Compiled);
+
+             DirectorySearchPattern = $""{_filenamePrefix}*{_filenameSuffix}"";
+         }","Slower construction, faster matching. I wonder if this will be noticeable in the relenv?"
+9717,"@@ -61,6 +61,9 @@ void ThroughputPublisher::DataPubListener::onPublicationMatched(
+     if (info.status == MATCHED_MATCHING)
+     {
+         ++throughput_publisher_.data_discovery_count_;
++        std::cout << C_RED << ""Pub: DATA Pub Matched ""
++            << throughput_publisher_.data_discovery_count_ << ""/"" << throughput_publisher_.subscribers_
++            << C_DEF << std::endl;
+     }
+     else
+     {","I think that if `data_discovery_count_ > static_cast<int>(throughput_publisher_.subscribers_)`, then we should not proceed, since we have discovered some unexpected subscriber that can affect the test results. I'd change the comparison to `==` and have and `else if` contemplating the `>` case"
+9718,"@@ -51,6 +51,7 @@
+ #include <iomanip>
+ #include <stdexcept>
+ #include <impl/Kokkos_Error.hpp>
++#include <Cuda/Kokkos_Cuda_Error.hpp>
+
+ //----------------------------------------------------------------------------
+ //----------------------------------------------------------------------------",Remove that include
+9719,"@@ -130,6 +130,7 @@ class EasyAdminFormType extends AbstractType
+         return function (Options $options, $value) {
+             return array_replace(array(
+                 'id' => sprintf('%s-%s-form', $options['view'], strtolower($options['entity'])),
++                'class' => sprintf('%s-form', $options['view']),
+             ), $value);
+         };
+     }","IMO this should be defined in the form theme instead. This class should always be there. If the user configured additional css classes, it should be appended instead of replacing the `{view}-form` css class."
+9720,"@@ -36,6 +36,7 @@ import com.salesforce.androidsdk.auth.OAuth2.TokenEndpointResponse;
+ import com.salesforce.androidsdk.rest.RestClient.AuthTokenProvider;
+ import com.salesforce.androidsdk.rest.RestClient.ClientInfo;
+ import com.salesforce.androidsdk.rest.RestRequest.RestMethod;
++import com.salesforce.androidsdk.util.JSONObjectHelper;
+
+ import org.json.JSONArray;
+ import org.json.JSONException;",These tests actually go to the server.
+9721,"@@ -147,6 +147,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+         {
+             var onStartingCalled = false;
+             var onCompletedCalled = false;
++            var onCompleted = Task.Run(() => onCompletedCalled = true);
+
+             var hostBuilder = TransportSelector.GetWebHostBuilder()
+                 .UseKestrel()",This test modification isn't correct. This task could run immediately and you wouldn't be able to tell if OnCompleted was called or not.
+9722,"@@ -20,11 +20,13 @@ export function setComponentProps(component, props, opts, context, mountAll) {
+ 	if ((component.__ref = props.ref)) delete props.ref;
+ 	if ((component.__key = props.key)) delete props.key;
+
+-	if (!component.base || mountAll) {
+-		if (component.componentWillMount) component.componentWillMount();
+-	}
+-	else if (component.componentWillReceiveProps) {
+-		component.componentWillReceiveProps(props, context);
++	if (typeof component.constructor.getDerivedStateFromProps === 'undefined') {
++		if (!component.base || mountAll) {
++			if (component.componentWillMount) component.componentWillMount();
++		}
++		else if (component.componentWillReceiveProps) {
++			component.componentWillReceiveProps(props, context);
++		}
+ 	}
+
+ 	if (context && context!==component.context) {",I'd be open to loosening this check if it can help offset the size.
+9723,"@@ -2017,6 +2017,9 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         Apply a function that takes pandas DataFrame and outputs pandas DataFrame. The pandas
+         DataFrame given to the function is of a batch used internally.
+
++        See also `Transform and apply a function
++        <https://koalas.readthedocs.io/en/stable/user_guide/transform_apply.html>`_.
++
+         .. note:: the `func` is unable to access to the whole input frame. Koalas internally
+             splits the input series into multiple batches and calls `func` with each batch multiple
+             times. Therefore, operations such as global aggregations are impossible. See the example","I'm wondering which we should use, stable or latest?"
+9724,"@@ -25,7 +25,8 @@ public abstract class BftExtraDataCodec {
+   protected enum EncodingType {
+     ALL,
+     EXCLUDE_COMMIT_SEALS,
+-    EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER
++    EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER,
++    EXCLUDE_CMS // TODO-lucas How can we achieve this w/o changing the BftExtraDataCodec base class
+   }
+
+   private static final Logger LOG = LogManager.getLogger();",possibly extending EncodingType enum?
+9725,"@@ -26,6 +26,18 @@ describe ""Selenium::WebDriver::TargetLocator"" do
+     end
+   end
+
++  it ""should switch to parent frame"" do
++    driver.navigate.to url_for(""iframes.html"")
++
++    iframe = driver.find_element(:tag_name => ""iframe"")
++    driver.switch_to.frame(iframe)
++
++    driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)
++
++    driver.switch_to.parent_frame
++    driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element)
++  end
++
+   # switching by name not yet supported by safari
+   not_compliant_on :browser => [:ie, :iphone, :safari] do
+     it ""should switch to a window and back when given a block"" do",I tested it only in Firefox (`./go //rb:firefox-test`)
+9726,"@@ -27,7 +27,7 @@ using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process;
+
+ namespace OpenTelemetry.Exporter.Jaeger
+ {
+-    public class JaegerExporter : BaseExporter<Activity>
++    public class JaegerExporter : BaseExporter<Activity>, IProviderContainer<TracerProvider>
+     {
+         private readonly int maxPayloadSizeInBytes;
+         private readonly TProtocolFactory protocolFactory;","can we do this in the baseexporter itself? So that exporters just access this.Provider.Resource, and baseexporters take care of populating Provider?"
+9727,"@@ -156,7 +156,9 @@ module.exports = function(grunt) {
+                     'frontend/express/public/core/session-frequency/javascripts/countly.models.js',
+                     'frontend/express/public/core/session-frequency/javascripts/countly.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.models.js',
+-                    'frontend/express/public/core/events/javascripts/countly.views.js'
++                    'frontend/express/public/core/events/javascripts/countly.views.js',
++                    'frontend/express/public/core/events/javascripts/countly.events.models.js',
++                    'frontend/express/public/core/events/javascripts/countly.events.views.js'
+                 ],
+                 dest: 'frontend/express/public/javascripts/min/countly.lib.concat.js'
+             }",what is the difference between `/core/events/javascripts/countly.views.js` and `/core/events/javascripts/countly.events.views.js`
+9728,"@@ -16,6 +16,10 @@ axe.a11yCheck = function (context, options, callback) {
+ 		options = {};
+ 	}
+
++	if (!('iframes' in options)) {
++		options.iframes = true;
++	}
++
+ 	var audit = axe._audit;
+ 	if (!audit) {
+ 		throw new Error('No audit configured');",We should make sure this is also supported by `axe.run`. Perhaps moving it into run-rules would cover both API methods more easily?
+9729,"@@ -46,9 +46,9 @@ class MemoryBasedStorage(StorageBase):
+     def set_record_timestamp(self, collection_id, parent_id, record,
+                              modified_field=DEFAULT_MODIFIED_FIELD,
+                              last_modified=None):
+-        timestamp = self._bump_timestamp(collection_id, parent_id, record,
+-                                         modified_field,
+-                                         last_modified=last_modified)
++        timestamp = self._bump_and_store_timestamp(collection_id, parent_id, record,
++                                                   modified_field,
++                                                   last_modified=last_modified)
+         record[modified_field] = timestamp
+         return record
+ ","If the `MemoryBasedStorage` relies on a `self._bump_and_store_timestamp()`, then every child class will have to implement it. So it should not be prefixed with `_`. And should raise `NotImplementedError` etc. :)"
+9730,"@@ -8,7 +8,6 @@ using System.Collections.Generic;
+
+ namespace System.Diagnostics
+ {
+-    [MemoryDiagnoser]
+     [BenchmarkCategory(Categories.Libraries)]
+     public class Perf_Activity
+     {",why removed the MemoryDiagnoser attribute?
+9731,"@@ -3939,7 +3939,16 @@ function getModelsMapForPopulate(model, docs, options) {
+       foreignField = foreignField.call(doc);
+     }
+
+-    const ret = convertTo_id(utils.getValue(localField, doc));
++    const localFieldPath = modelSchema.paths[localField];
++    const localFieldGetters = localFieldPath ? localFieldPath.getters : [];
++    let ret;
++
++    if (localFieldGetters.length) {
++      ret = localFieldGetters[0].call(doc, doc[localField]);
++    } else {
++      ret = convertTo_id(utils.getValue(localField, doc));
++    }
++
+     const id = String(utils.getValue(foreignField, doc));
+     options._docs[id] = Array.isArray(ret) ? ret.slice() : ret;
+ ","Why do this instead of `localFieldPath.applyGetters(doc[localField], doc)` ?"
+9732,"@@ -186,15 +186,6 @@ SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if match count is negative"") {
+         invalid_argument);
+ }
+
+-SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if match count is positive"") {
+-    REQUIRE_THROWS_AS(
+-        (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_type>(
+-            false,
+-            isomorphism_kind::induced,
+-            1)),
+-        unimplemented);
+-}
+-
+ // SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if semantic match is true"") {
+ //     REQUIRE_THROWS_AS(
+ //         (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_type>(",Just for a check. Do you really want to delete this?
+9733,"@@ -10,8 +10,10 @@ import (
+ 	""context""
+ 	""os""
+
++	""github.com/golang/protobuf/proto""
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
++	""github.com/iotexproject/iotex-core/blockchain/action""
+ 	""github.com/iotexproject/iotex-core/blocksync""
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/consensus""",github.com/golang/protobuf/proto group in next group
+9734,"@@ -64,6 +64,7 @@ var rootSubcmdsDaemon = map[string]*cmds.Command{
+ 	""mining"":    miningCmd,
+ 	""mpool"":     mpoolCmd,
+ 	""orderbook"": orderbookCmd,
++	""paych"":     paymentChannelCmd,
+ 	""ping"":      pingCmd,
+ 	""show"":      showCmd,
+ 	""swarm"":     swarmCmd,",Nit: what about just `pay`? Is there some other subcommand that would conflict with?
+9735,"@@ -55,8 +55,13 @@ public class Scalars {
+           if (!(input instanceof StringValue)) {
+             throw new CoercingParseLiteralException(""Value is not any Address : '"" + input + ""'"");
+           }
++          String inputValue = ((StringValue) input).getValue();
++          if (!inputValue.startsWith(""0x"")) {
++            throw new CoercingParseLiteralException(
++                ""Address value '"" + inputValue + ""' is not prefixed with 0x"");
++          }
+           try {
+-            return Address.fromHexStringStrict(((StringValue) input).getValue());
++            return Address.fromHexStringStrict(inputValue);
+           } catch (final IllegalArgumentException e) {
+             throw new CoercingParseLiteralException(""Value is not any Address : '"" + input + ""'"");
+           }","Just for the sake of keeping things logically co-located, I'd like to see this functionality in `Quantity.java` which has a lot of utility methods related to this. Maybe a `static` method like `Quantity.isValid(String string)`?"
+9736,"@@ -72,7 +72,7 @@ public abstract class FlinkTestBase extends AbstractTestBase {
+     return tEnv;
+   }
+
+-  List<Object[]> sql(String query, Object... args) {
++  public List<Object[]> sql(String query, Object... args) {
+     TableResult tableResult = getTableEnv().executeSql(String.format(query, args));
+     tableResult.getJobClient().ifPresent(c -> {
+       try {",How about use `protected` ?
+9737,"@@ -32,6 +32,12 @@ func (ih *IntermediateHashes) WillUnloadBranchNode(prefixAsNibbles []byte, nodeH
+ 	if len(prefixAsNibbles) == 0 || len(prefixAsNibbles)%2 == 1 {
+ 		return
+ 	}
++
++	// special case. Store Account.Root for long time
++	if len(prefixAsNibbles) == common.HashLength*2 {
++		return
++	}
++
+ 	InsertCounter.Inc(1)
+
+ 	buf := pool.GetBuffer(keyBufferSize)",Should it not be `common.HashLength*2 + common.IncarnationLength` ?
+9738,"@@ -422,7 +422,8 @@ public class FlowRunner extends EventHandler implements Runnable {
+
+       // If a job is seen as failed or killed due to failing SLA, then we set the parent flow to
+       // FAILED_FINISHING
+-      if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node.isKilledBySLA())) {
++      if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node
++          .isKilledBySLA())) {
+         // The job cannot be retried or has run out of retry attempts. We will
+         // fail the job and its flow now.
+         if (!retryJobIfPossible(node)) {",those change are done by save plugin.
+9739,"@@ -37,7 +37,9 @@ public class MimeHeader {
+     };
+
+     protected ArrayList<Field> mFields = new ArrayList<Field>();
+-    private String mCharset = null;
++
++    // use UTF-8 as standard to prevent NullPointerExceptions
++    private String mCharset = ""UTF-8"";
+
+     public void clear() {
+         mFields.clear();",There were problems with NullPointerException and with german Umlauts in message titles (I know they're not allowed in the specifiation but they caused my K-9-Inbox to not work at all) I don't know if this is related to PGP/Mime
+9740,"@@ -0,0 +1,11 @@
++// <copyright file=""IEvent.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Abstractions
++{
++    internal interface IEvent
++    {
++    }
++}",This is an appsec concept right? Should it live in the Appsec namespace?
+9741,"@@ -11,11 +11,10 @@ func main() {
+ 	machine.I2C0.Configure(machine.I2CConfig{})
+
+ 	// Init BlinkM
+-	machine.I2C0.WriteTo(0x09, []byte(""o""))
++	machine.I2C0.WriteRegister(0x09, 'o', nil)
+
+ 	version := []byte{0, 0}
+-	machine.I2C0.WriteTo(0x09, []byte(""Z""))
+-	machine.I2C0.ReadFrom(0x09, version)
++	machine.I2C0.ReadRegister(0x09, 'Z', version)
+ 	println(""Firmware version:"", string(version[0]), string(version[1]))
+
+ 	count := 0","I'd personally recommend having the demo check for error, unless it's worthless."
+9742,"@@ -582,7 +582,7 @@ public class DistributorTest {
+         );
+
+         Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession();
+-        LOG.info(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
++        LOG.finer(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
+
+         boolean inFirefoxNodes = firefoxNodes.stream().anyMatch(node -> node.getUri().equals(firefoxSession.getUri()));
+         boolean inChromeNodes = chromeNodes.stream().anyMatch(node -> node.getUri().equals(chromeSession.getUri()));","Since this is in a test, I imagine that the choice of `info` level was deliberate."
+9743,"@@ -1,10 +1,10 @@
+ const Plugin = require('../../core/Plugin')
+ const Translator = require('../../core/Translator')
+ const dragDrop = require('drag-drop')
+-const Dashboard = require('./Dashboard')
++const DashboardUI = require('./Dashboard')
+ const StatusBar = require('../StatusBar')
+ const Informer = require('../Informer')
+-const { findAllDOMElements } = require('../../core/Utils')
++const { findAllDOMElements, toArray } = require('../../core/Utils')
+ const prettyBytes = require('prettier-bytes')
+ const { defaultTabIcon } = require('./icons')
+ ",good call swapping these names! makes more sense this way i think
+9744,"@@ -13,8 +13,12 @@ import options from './options';
+  */
+ export function render(vnode, parentDom, replaceNode) {
+ 	if (options._root) options._root(vnode, parentDom);
+-	let oldVNode = replaceNode && replaceNode._children || parentDom._children;
+
++	let oldVNode = replaceNode && replaceNode._children || parentDom._children;
++	let isHydrating = false;
++	if (replaceNode === null) {
++		isHydrating = true;
++	}
+ 	vnode = createElement(Fragment, null, [vnode]);
+
+ 	let mounts = [];",Maybe leaving this out will save some bytes as in let `let isHydrating = replaceNode === null`
+9745,"@@ -298,6 +298,10 @@ class RustGenerator : public BaseGenerator {
+
+     assert(!cur_name_space_);
+
++    // Generate imports for the global scope in case no namespace is used
++    // in the schema file.
++    GenNamespaceImports(0);
++
+     // Generate all code in their namespaces, once, because Rust does not
+     // permit re-opening modules.
+     //","Let's manually create one extra whitespace line here (code_ += """")"
+9746,"@@ -138,6 +138,17 @@ func (bp *BucketPool) Count() uint64 {
+ 	return bp.total.count
+ }
+
++// Construct returns a copy of the bucket pool
++func (bp *BucketPool) Construct(enableSMStorage bool) *BucketPool {
++	pool := BucketPool{}
++	pool.enableSMStorage = enableSMStorage
++	pool.total = &totalAmount{
++		amount: new(big.Int).Set(bp.total.amount),
++		count:  bp.total.count,
++	}
++	return &pool
++}
++
+ // SyncPool sync the data from state manager
+ func (bp *BucketPool) SyncPool(sm protocol.StateManager) error {
+ 	if bp.enableSMStorage {",nit: copy or clone
+9747,"@@ -182,3 +182,14 @@ func (d Document) Decode(dec Decoder) error {
+ 	}
+ 	return decodeStruct(d.s, dec)
+ }
++
++// RevisionOn returns whether or not we should write a revision value when we
++// write a document. It could be either a map or a struct with a revision key or
++// field named after revField.
++func (d Document) RevisionOn(revField string) bool {
++	if d.m != nil {
++		_, ok := d.m[revField]
++		return ok
++	}
++	return d.fields.MatchFold(revField) != nil
++}","I think this can be called `HasField`, because that's what it's doing. It really is independent of revision."
+9748,"@@ -16,7 +16,10 @@ import java.math.BigDecimal;
+ import java.time.Year;
+ import java.util.function.Predicate;
+
+-import static javaslang.API.*;
++import static javaslang.API.$;
++import static javaslang.API.Case;
++import static javaslang.API.Match;
++import static javaslang.API.run;
+ import static javaslang.MatchTest_DeveloperPatterns.Developer;
+ import static javaslang.Patterns.*;
+ import static javaslang.Predicates.*;",Is this to avoid collisions?
+9749,"@@ -79,7 +79,7 @@ func MakeTransactionPool(ledger *ledger.Ledger, cfg config.Local) *TransactionPo
+ 		expiredTxCount:  make(map[basics.Round]int),
+ 		ledger:          ledger,
+ 		statusCache:     makeStatusCache(cfg.TxPoolSize),
+-		logStats:        cfg.EnableAssembleStats,
++		logStats:        cfg.EnableProcessBlockStats,
+ 		expFeeFactor:    cfg.TxPoolExponentialIncreaseFactor,
+ 		txPoolMaxSize:   cfg.TxPoolSize,
+ 	}","nit: a better name for this variable would be enableLogStats, but it's beyond the scope of your change."
+9750,"@@ -256,7 +256,6 @@ class CheckerTestCase(object):
+ # Init
+ test_reporter = TestReporter()
+ linter = PyLinter(pylint.config.Configuration())
+-linter.set_reporter(test_reporter)
+ linter.config.persistent = 0
+ checkers.initialize(PluginRegistry(linter))
+ ","Because linters don't handle reports now, this was breaking the setup for _all_ tests. I deleted it so I could run my tests, but I didn't check the impact on other tests as many tests are failing at the moment."
+9751,"@@ -138,6 +138,12 @@ func main() {
+ 		updateCommand,
+ 	}
+ 	app.Before = func(context *cli.Context) error {
++
++		// do nothing if logrus was already initialized in init.go
++		if logrus.StandardLogger().Out != logrus.New().Out {
++			return nil
++		}
++
+ 		if context.GlobalBool(""debug"") {
+ 			logrus.SetLevel(logrus.DebugLevel)
+ 		}",I'm not really a fan of this -- why not set up logging for `init` here (or setting a global flag) rather than doing it this way?
+9752,"@@ -1,4 +1,14 @@
+-/* global axe */
++/**
++ * Namespace `axe.imports` which holds required external dependencies
++ *
++ * @namespace imports
++ * @memberof axe
++ */
++export { default as axios } from 'axios';
++export { CssSelectorParser } from 'css-selector-parser';
++export { default as doT } from '@deque/dot';
++export { default as emojiRegexText } from 'emoji-regex';
++export { default as memoizee } from 'memoizee';
+
+ /**
+  * Note:",This is my favorite part of this PR. Being able to `import` 3rd party tools will hugely improve our workflows. :heart:
+9753,"@@ -0,0 +1,19 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.multithreading;
++
++import java.security.MessageDigest;
++
++/**
++ * Using a MessageDigest which is static can cause
++ * unexpected results when used in a multi-threaded environment. This rule will
++ * find static MessageDigest which are used in an unsynchronized manner.
++ */
++public class UnsynchronizedStaticMessageDigestRule extends UnsynchronizedStaticFormatterRule {
++
++    public UnsynchronizedStaticMessageDigestRule() {
++        super(MessageDigest.class);
++    }
++}","having this extend `UnsynchronizedStaticFormatterRule` seems semantically incorrect even if it works  we should probably refactor `UnsynchronizedStaticFormatterRule` into a `UnsynchronizedStaticAccessRule` which can be configured through properties to track unsynchronized static access to any given types (with proper defaults to include `Formatter` and `MessageDigest`). This will also scale better as new types are suggested to have a thread-safe access enforced. The `UnsynchronizedStaticFormatterRule` can be marked as deprecated at the ruleset level, point to the new implementation, overriding the property defaults to keep just looking for `Formatter`. Moreover, the `THREAD_SAFE_FORMATTER` static should probably be replaced with a property of thread-safe classes to ignore, once again with proper defaults."
+9754,"@@ -126,6 +126,8 @@ namespace Nethermind.Synchronization.ParallelSync
+         }
+
+         public long FindBestHeader() => _blockTree.BestSuggestedHeader?.Number ?? 0;
++
++        public Keccak FindBestHeaderHash() => _blockTree.BestSuggestedHeader?.Hash ?? Keccak.Zero;
+
+         public long FindBestFullBlock() => Math.Min(FindBestHeader(), _blockTree.BestSuggestedBody?.Number ?? 0); // avoiding any potential concurrency issue
+ ",Keccak.Zero should not be used to mean null
+9755,"@@ -40,5 +40,12 @@ namespace OpenTelemetry.Metrics.Tests
+                     new object[] { ""my_metric2"" },
+                     new object[] { new string('m', 63) },
+            };
++
++        public static IEnumerable<object[]> InvalidHistogramBounds
++           => new List<object[]>
++           {
++                    new object[] { new double[] { 0, 0 } },
++                    new object[] { new double[] { 1, 0 } },
++           };
+     }
+ }",perhaps add a couple more edge cases.
+9756,"@@ -4,11 +4,15 @@ package Example
+
+ import ""strconv""
+
++/// Composite components of Monster color.
+ type Color byte
+
+ const (
+ 	ColorRed   Color = 1
++	/// \brief color Green
++	/// Green is bit_flag with value (1u << 1)
+ 	ColorGreen Color = 2
++	/// \brief color Blue (1u << 3)
+ 	ColorBlue  Color = 8
+ )
+ ","Is this blank line needed, or typo?"
+9757,"@@ -122,12 +122,6 @@ func (p *blockPrefetcher) run() {
+ func (p *blockPrefetcher) request(priority int, kmd KeyMetadata,
+ 	ptr BlockPointer, block Block, entryName string,
+ 	doneCh, errCh chan<- struct{}) error {
+-	if _, err := p.config.BlockCache().Get(ptr); err == nil {
+-		return nil
+-	}
+-	if err := checkDataVersion(p.config, path{}, ptr); err != nil {
+-		return err
+-	}
+ 	select {
+ 	case p.progressCh <- prefetchRequest{
+ 		priority, kmd, ptr, block, doneCh, errCh}:",This was a major PitA to find: it was causing some huge goroutine leaks and unfinished prefetches.
+9758,"@@ -84,10 +84,8 @@ module Mongoid #:nodoc
+       #
+       # @since 2.1.8
+       def prohibited_methods
+-        @prohibited_methods ||= MODULES.inject([]) do |methods, mod|
+-          methods.tap do |mets|
+-            mets << mod.instance_methods.map{ |m| m.to_sym }
+-          end
++        @prohibited_methods ||= MODULES.map do |mod|
++          mod.instance_methods.map{ |m| m.to_sym }
+         end.flatten
+       end
+     end",you can use Enum#flat_map here.
+9759,"@@ -155,6 +155,7 @@ public class AbstractVmNode extends AbstractNode implements VmNode {
+      */
+     @Deprecated
+     public void dump(final String prefix, final boolean recurse, final Writer writer) {
++        @SuppressWarnings(""PMD.CloseResource"")
+         final PrintWriter printWriter = writer instanceof PrintWriter ? (PrintWriter) writer : new PrintWriter(writer);
+         printWriter.println(toString(prefix));
+         if (children != null && recurse) {","Same potential FP: The stream is provided from outside (here as a method parameter), so we should not be responsible here to close it, should we?"
+9760,"@@ -26,11 +26,12 @@ Upcase::Application.configure do
+   config.log_level = :info
+   config.log_formatter = ::Logger::Formatter.new
+
+-  config.middleware.use \
+-    Rack::SslEnforcer,
+-    hsts: false,
+-    strict: true,
+-    redirect_to: ""https://#{ENV[""APP_DOMAIN""]}""
++  config.force_ssl = true
++  config.middleware.insert_before(
++    ActionDispatch::SSL,
++    Rack::CanonicalHost,
++    ENV.fetch(""APP_DOMAIN""),
++  )
+
+   config.action_mailer.delivery_method = :smtp
+   config.action_mailer.smtp_settings = MAIL_SETTINGS",Put a comma after the last parameter of a multiline method call.
+9761,"@@ -67,10 +67,8 @@ public class VerbsManager {
+                 output -> {
+                     final Value verbClass = (Value) output;
+
+-                    final Verb verb = verbClass.newInstance().as(Verb.class);
+-
+                     try {
+-                        verb.install(container);
++                        verbClass.invokeMember(""install"", container);
+                     } catch (ScriptException se) {
+                         errorCallback.accept(se);
+                     }",It seems like this is the only way to access javascript `static` methods from Java.
+9762,"@@ -4,8 +4,6 @@
+  * A temporary workaround to ensure the same version of React
+  * is always used across multiple entrypoints.
+  *
+- * @private
+- *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");",Why was this removed here?
+9763,"@@ -4,12 +4,6 @@
+
+ package pslice
+
+-import ""github.com/ethersphere/bee/pkg/swarm""
+-
+-func PSlicePeers(p *PSlice) []swarm.Address {
+-	return p.peers
+-}
+-
+ func PSliceBins(p *PSlice) []uint {
+ 	return p.bins
+ }","i am aware that you did not add these, but might i ask why we need these one-liner funcs instead of just exporting the struct fields in the first place?"
+9764,"@@ -296,7 +296,7 @@ abstract class BaseTableScan implements TableScan {
+       }
+       requiredFieldIds.addAll(selectedIds);
+
+-      return TypeUtil.select(schema, requiredFieldIds);
++      return TypeUtil.project(schema, requiredFieldIds);
+
+     } else if (context.projectedSchema() != null) {
+       return context.projectedSchema();",I agree with this because it is the opposite of `GetProjectedIds` used above.
+9765,"@@ -632,7 +632,7 @@ class InstanceAttribute(dict):
+                    'disableApiTermination',
+                    'instanceInitiatedShutdownBehavior',
+                    'rootDeviceName', 'blockDeviceMapping', 'sourceDestCheck',
+-                   'groupSet']
++                   'groupSet', 'productCodes', 'ebsOptimized',]
+
+     def __init__(self, parent=None):
+         dict.__init__(self)",add 'sriovNetSupport' also to this list
+9766,"@@ -61,7 +61,9 @@ public class Preferences {
+         }
+         if ((newAccount != null) && newAccount.getAccountNumber() != -1) {
+             accounts.put(newAccount.getUuid(), newAccount);
+-            accountsInOrder.add(newAccount);
++            if (!accountsInOrder.contains(newAccount)) {
++                accountsInOrder.add(newAccount);
++            }
+             newAccount = null;
+         }
+     }",Code style issue: `if` body is not wrapped in braces.
+9767,"@@ -81,9 +81,8 @@ public class ItunesSearchFragment extends Fragment {
+         if (result != null && result.size() > 0) {
+             gridView.setVisibility(View.VISIBLE);
+             txtvEmpty.setVisibility(View.GONE);
+-            for (Podcast p : result) {
+-                adapter.add(p);
+-            }
++
++            adapter.addAll(result);
+             adapter.notifyDataSetInvalidated();
+         } else {
+             gridView.setVisibility(View.GONE);",Call requires API level 11 (we are on 10)
+9768,"@@ -97,7 +97,7 @@ namespace Nethermind.AuRa.Test.Contract
+                 var gasLimitContract = new BlockGasLimitContract(new AbiEncoder(), blockGasLimitContractTransition.Value, blockGasLimitContractTransition.Key,
+                     new ReadOnlyTxProcessingEnv(
+                         DbProvider,
+-                        new TrieStore(DbProvider.StateDb, LimboLogs.Instance),
++                        new TrieStore(DbProvider.StateDb, LimboLogs.Instance).AsReadOnly(DbProvider.StateDb),
+                         BlockTree, SpecProvider, LimboLogs.Instance));
+
+                 GasLimitOverrideCache = new AuRaContractGasLimitOverride.Cache();",do we need to pass the DB if it is the same
+9769,"@@ -300,6 +300,14 @@ func (ccs *crChains) addOp(ptr BlockPointer, op op) error {
+ }
+
+ func (ccs *crChains) makeChainForOp(op op) error {
++	// Ignore gc ops -- their unref semantics differ from the other
++	// ops.  Note that this only matters for old gcOps: new gcOps
++	// only unref the block ID, and not the whole pointer, so they
++	// wouldn't confuse chain creation.
++	if _, isGCOp := op.(*gcOp); isGCOp {
++		return nil
++	}
++
+ 	// First set the pointers for all updates, and track what's been
+ 	// created and destroyed.
+ 	for _, update := range op.AllUpdates() {",Might be a good idea to rename the variable so it doesn't shadow the type.
+9770,"@@ -14,7 +14,13 @@ class Tag extends BaseItem {
+ 	}
+
+ 	static async noteIds(tagId) {
+-		const rows = await this.db().selectAll('SELECT note_id FROM note_tags WHERE tag_id = ?', [tagId]);
++		// Get NoteIds of that are tagged with current tag or its descendants
++		const rows = await this.db().selectAll(`WITH RECURSIVE
++												parent_of(id, child_id) AS
++												(SELECT id, id FROM tags where id=?
++												UNION ALL
++												SELECT parent_of.id, tags2.id FROM parent_of JOIN tags AS tags2 ON parent_of.child_id=tags2.parent_id)
++												SELECT note_id FROM note_tags WHERE tag_id IN (SELECT child_id from parent_of)`, [tagId]);
+ 		const output = [];
+ 		for (let i = 0; i < rows.length; i++) {
+ 			output.push(rows[i].note_id);",Again I'd prefer if this is done in JavaScript rather than in SQL.
+9771,"@@ -1848,7 +1848,7 @@ function fullyResolveKeys(obj) {
+  * If there are no listeners registered with the flow, the error will be
+  * rethrown to the global error handler.
+  *
+- * Refer to the {@link ./promise} module documentation fora  detailed
++ * Refer to the {@link ./promise} module documentation for a  detailed
+  * explanation of how the ControlFlow coordinates task execution.
+  *
+  * @final",there is still `2` spaces after `a` here.. :P
+9772,"@@ -25,6 +25,17 @@ import (
+
+ const defaultMountFlags = syscall.MS_NOEXEC | syscall.MS_NOSUID | syscall.MS_NODEV
+
++// setupDev returns true if /dev needs to be set up.
++func needsSetupDev(config *configs.Config) (bool, error) {
++	setupDev := true
++	for _, m := range config.Mounts {
++		if m.Device == ""bind"" && m.Destination == ""/dev"" {
++			setupDev = false
++		}
++	}
++	return setupDev, nil
++}
++
+ // setupRootfs sets up the devices, mount points, and filesystems for use inside a
+ // new mount namespace.
+ func setupRootfs(config *configs.Config, console *linuxConsole, pipe io.ReadWriter) (err error) {","What we did in docker before, when working directly with libcontainer, is check if the source is `/dev` and the destination has a `/dev/` prefix. This implementation is probably ok. If someone is mounting their own `/dev` I would expect it to be pre-configured and not need the extra check for if it's the host's `/dev`. (that said, I've not tested yet, just reading through the code)"
+9773,"@@ -501,6 +501,10 @@ type Configuration struct {
+ 	PleaseLocation string
+ 	// buildEnvStored is a cached form of BuildEnv.
+ 	buildEnvStored *storedBuildEnv
++
++	FeatureFlags struct {
++		JavaBinaryExecutableByDefault bool `help:""Makes java_binary rules self executable by default. Target release version 16."" var:""FF_JAVA_SELF_EXEC""`
++	}
+ }
+
+ // An Alias represents aliases in the config.","you should add some help on the struct too so that `plz halp featureflags` has a bit of explanation. Might be worth mentioning that these generally won't remain around very long relative to other config options (i.e. they're typically enabling ""preview"" features for the next major)."
+9774,"@@ -302,7 +302,7 @@ func newSessionManagerFactory(
+ 	nodeOptions node.Options,
+ ) session.ManagerFactory {
+ 	return func(dialog communication.Dialog) *session.Manager {
+-		providerBalanceTrackerFactory := func(consumer, provider, issuer identity.Identity) (session.BalanceTracker, error) {
++		providerBalanceTrackerFactory := func(consumer, receiver, issuer identity.Identity) (session.BalanceTracker, error) {
+ 			// if the flag ain't set, just return a noop balance tracker
+ 			if !nodeOptions.ExperimentPayments {
+ 				return payments_noop.NewSessionBalance(), nil","Maybe `consumerID, receiverID, issuerID`, at least it's a convension in overal repo"
+9775,"@@ -14,6 +14,12 @@
+
+ // Package s3blob provides an implementation of blob using S3.
+ //
++// For blob.Open URLs, s3blob registers for the ""s3"" protocol.
++// The URL's Host is used as the bucket name.
++// The following query options are supported:
++// - region: The AWS region for requests.
++// Example URL: blob.Open(""s3://mybucket?region=us-east-1"")
++//
+ // It exposes the following types for As:
+ // Bucket: *s3.S3
+ // ListObject: s3.Object for objects, s3.CommonPrefix for ""directories"".",Where does the auth go?
+9776,"@@ -119,7 +119,10 @@ func ClassifyActions(actions []SealedEnvelope) ([]*Transfer, []*Execution) {
+ }
+
+ func calculateIntrinsicGas(baseIntrinsicGas uint64, payloadGas uint64, payloadSize uint64) (uint64, error) {
+-	if payloadGas == 0 || (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize {
++	if payloadGas == 0 {
++		return 0, ErrUnderpriced
++	}
++	if (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize {
+ 		return 0, ErrInsufficientFunds
+ 	}
+ 	return payloadSize*payloadGas + baseIntrinsicGas, nil","0 < minimum gas price, `ErrUnderpriced` is more proper"
+9777,"@@ -12,7 +12,7 @@ from sqlalchemy import func
+ from . import app, db
+ from .const import (VALID_EMAIL_RE, VALID_USERNAME_RE, blacklisted_name,
+                     ACTIVATE_SALT, PASSWORD_RESET_SALT, MAX_LINK_AGE,
+-                    CODE_EXP_MINUTES)
++                    CODE_EXP_MINUTES, TOKEN_EXP_DEFAULT)
+ from .mail import (send_activation_email, send_reset_email, send_new_user_email,
+                    send_welcome_email)
+ from .models import ActivationToken, Code, PasswordResetToken, Token, User",these should be alphabetized
+9778,"@@ -72,7 +72,7 @@ public class VectorizedDictionaryEncodedParquetValuesReader extends BaseVectoriz
+   }
+
+   void readBatchOfDictionaryEncodedLongs(FieldVector vector, int startOffset, int numValuesToRead, Dictionary dict,
+-                                         NullabilityHolder nullabilityHolder) {
++                                         NullabilityHolder nullabilityHolder, int typeWidth) {
+     int left = numValuesToRead;
+     int idx = startOffset;
+     while (left > 0) {","These changes look concerning. It looks like the old offset (only index) must not have been correct. If so, there are places where `getDataBuffer().setLong(...)` and similar methods are called but aren't updated like these. Are those cases bugs as well?"
+9779,"@@ -164,7 +164,7 @@ type Counters struct {
+
+ // flush writes the current state of in memory counters into the given db.
+ func (cs *Counters) flush(db *shed.DB, batch *leveldb.Batch) error {
+-	if cs.dirty.Load() > 1 {
++	if cs.dirty.Load() < 3 {
+ 		return nil
+ 	}
+ 	cs.dirty.CAS(3, 2)",the CAS call here is now wrong since dirty will never be 3 anymore. it might be useful to sweep through the entire usage of this field to see that everything is correct
+9780,"@@ -18,7 +18,11 @@ use Symfony\Component\Validator\Constraints\NotBlank;
+ use Symfony\Component\Validator\Constraints\NotEqualTo;
+ use Symfony\Component\Validator\ExecutionContextInterface;
+ use Thelia\Core\Translation\Translator;
++use Thelia\Model\Base\CountryQuery;
+ use Thelia\Model\Base\LangQuery;
++use Thelia\Model\Base\ModuleQuery;
++use Thelia\Model\Module;
++use Thelia\Module\BaseModule;
+
+ /**
+  * Allow to build a form Coupon",Base model is imported here
+9781,"@@ -16,6 +16,7 @@
+  */
+ package org.apache.servicecomb.serviceregistry.task;
+
++import org.apache.servicecomb.foundation.common.event.EventManager;
+ import org.apache.servicecomb.serviceregistry.RegistryUtils;
+ import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
+ import org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;",import but not used
+9782,"@@ -193,7 +193,7 @@ public final class VectorizedParquetDefinitionLevelReader extends BaseVectorized
+         case RLE:
+           if (currentValue == maxDefLevel) {
+             dictionaryEncodedValuesReader.readBatchOfDictionaryEncodedLongs(vector,
+-                idx, numValues, dict, nullabilityHolder);
++                idx, numValues, dict, nullabilityHolder, typeWidth);
+           } else {
+             setNulls(nullabilityHolder, idx, numValues, validityBuffer);
+           }",What about the call in `case PACKED` just below? Does that also need to use the `typeWidth`?
+9783,"@@ -8,13 +8,14 @@ import (
+ 	""errors""
+
+ 	""github.com/ethersphere/bee/pkg/collection""
++	""github.com/ethersphere/bee/pkg/encryption""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ )
+
+ var (
+ 	_                           = collection.Entry(&Entry{})
+ 	serializedDataSize          = swarm.SectionSize * 2
+-	encryptedSerializedDataSize = swarm.EncryptedReferenceSize * 2
++	encryptedSerializedDataSize = encryption.ReferenceSize * 2
+ )
+
+ // Entry provides addition of metadata to a data reference.",not sure i like this change. The encryption package does not need to know about references
+9784,"@@ -280,6 +280,7 @@ ifneq ($(MAKECMDGOALS),clean)
+   ifeq ($(llvm_version),3.9.1)
+   else ifeq ($(llvm_version),5.0.2)
+   else ifeq ($(llvm_version),6.0.1)
++  else ifeq ($(llvm_version),7.0.0) # this is what is shipped with ubuntu bionic llvm-7 package right now
+   else ifeq ($(llvm_version),7.0.1)
+   else
+     $(warning WARNING: Unsupported LLVM version: $(llvm_version))","This shouldn't be added. It's not supported. It's not event the default. If we are going to support this, we need to have CI for it."
+9785,"@@ -6,6 +6,5 @@ type API interface {
+ 	Client() Client
+ 	Daemon() Daemon
+ 	Ping() Ping
+-	RetrievalClient() RetrievalClient
+ 	Swarm() Swarm
+ }",omg only four left!!!!
+9786,"@@ -214,6 +214,12 @@ func (c *Client) InstallParticipationKeys(inputfile string) (part account.Partic
+ 		return
+ 	}
+
++	proto, ok := config.Consensus[protocol.ConsensusCurrentVersion]
++	if !ok {
++		err = fmt.Errorf(""Unknown consensus protocol %s"", protocol.ConsensusCurrentVersion)
++		return
++	}
++
+ 	// After successful install, remove the input copy of the
+ 	// partkey so that old keys cannot be recovered after they
+ 	// are used by algod.  We try to delete the data inside","I'm not really sure how this would happen. once the binary is already compiled, the config.Consensus should already have the entry for protocol.ConsensusCurrentVersion."
+9787,"@@ -160,7 +160,7 @@ class LuigiTestCase(unittest.TestCase):
+         temp = CmdlineParser._instance
+         try:
+             CmdlineParser._instance = None
+-            run_exit_status = luigi.run(['--local-scheduler', '--no-lock'] + args)
++            run_exit_status = luigi.run(args + ['--local-scheduler', '--no-lock'])
+         finally:
+             CmdlineParser._instance = temp
+         return run_exit_status",Is there a reason for the order swap here?
+9788,"@@ -241,8 +241,9 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting
+                 }
+             }
+
+-            EqtTrace.Error(""Unable to find path for dotnet host"");
+-            return dotnetExeName;
++            string errorMessage = String.Format(Resources.NoDotnetDotExeFileExist, dotnetExeName);
++            EqtTrace.Error(errorMessage);
++            throw new FileNotFoundException(errorMessage);
+         }
+
+         private string GetTestHostPath(string runtimeConfigDevPath, string depsFilePath, string sourceDirectory)",Where will this exception get caught ?
+9789,"@@ -49,9 +49,10 @@ var mainEtherAccPass = ""localaccount""
+ type CliWallet struct {
+ 	txOpts           *bind.TransactOpts
+ 	Owner            common.Address
+-	backend          *ethclient.Client
++	Backend          *ethclient.Client
+ 	identityRegistry registry.IdentityRegistryTransactorSession
+ 	tokens           mysttoken.MystTokenTransactorSession
++	KS               *keystore.KeyStore
+ }
+
+ // RegisterIdentity registers identity with given data on behalf of user",Why this field is made public?
+9790,"@@ -35,16 +35,16 @@
+ #include ""proj_internal.h""
+ #include ""proj_internal.h""
+
+-static int is_nodata(float value)
++static int is_nodata(float value, double vmultiplier)
+ {
+     /* nodata?  */
+     /* GTX official nodata value if  -88.88880f, but some grids also */
+     /* use other  big values for nodata (e.g naptrans2008.gtx has */
+     /* nodata values like -2147479936), so test them too */
+-    return value > 1000 || value < -1000 || value == -88.88880f;
++    return value * vmultiplier > 1000 || value * vmultiplier < -1000 || value == -88.88880f;
+ }
+
+-static double read_vgrid_value( PJ *defn, PJ_LP input, int *gridlist_count_p, PJ_GRIDINFO **tables, struct CTABLE *ct) {
++static double read_vgrid_value( PJ *defn, PJ_LP input, double vmultiplier, int *gridlist_count_p, PJ_GRIDINFO **tables, struct CTABLE *ct) {
+     int  itable = 0;
+     double value = HUGE_VAL;
+     double grid_x, grid_y;",Is the `vmultiplier` only used here for checking if a grid value is nodata?
+9791,"@@ -239,7 +239,7 @@ func signTestCert(key crypto.Signer) *x509.Certificate {
+ 		SerialNumber:          serialNumber,
+ 		SignatureAlgorithm:    x509.SHA256WithRSA,
+ 		Subject: pkix.Name{
+-			Organization: []string{defaultOrganization},
++			Organization: []string{""cert-manager""},
+ 			CommonName:   commonName,
+ 		},
+ 		NotBefore: time.Now(),","Is this deliberate? If so, why?"
+9792,"@@ -5,7 +5,7 @@ from mitmproxy import exceptions
+ from mitmproxy.net import tls as net_tls
+ from mitmproxy.proxy.protocol import base
+
+-# taken from https://testssl.sh/openssl-rfc.mappping.html
++# taken from https://testssl.sh/openssl-rfc.mapping.html
+ CIPHER_ID_NAME_MAP = {
+     0x00: 'NULL-MD5',
+     0x01: 'NULL-MD5',",both URL works. I corrected it anyway.
+9793,"@@ -43,12 +43,14 @@ import java.util.Collection;
+  * @since 5.0
+  */
+ public class PrePostAdviceReactiveMethodInterceptor implements MethodInterceptor {
+-	private Authentication anonymous = new AnonymousAuthenticationToken(""key"", ""anonymous"",
+-		AuthorityUtils.createAuthorityList(""ROLE_ANONYMOUS""));
++	private final Authentication anonymous = new AnonymousAuthenticationToken(""key"", ""anonymous"",
++			AuthorityUtils.createAuthorityList(""ROLE_ANONYMOUS""));
+
+ 	private final MethodSecurityMetadataSource attributeSource;
+
+-	private final PreInvocationAuthorizationAdvice preInvocationAdvice;
++	private PreInvocationAuthorizationAdvice preInvocationAdvice;
++
++	private PreInvocationAuthorizationReactiveAdvice preInvocationReactiveAdvice;
+
+ 	private final PostInvocationAuthorizationAdvice postAdvice;
+ ","Rather than have another member and and if/else statement, if the user passes in `PreInvocationAuthorizationAdvice` it could be adapted to match `PreInvocationAuthorizationReactiveAdvice`"
+9794,"@@ -210,8 +210,7 @@ class Sync {
+     /**
+      * A callback passed to `Realm.App.Sync.setLogger` when instrumenting the Realm Sync client with a custom logger.
+      * @callback Realm.App.Sync~logCallback
+-     * @param {number} level The level of the log entry between 0 and 8 inclusively.
+-     * Use this as an index into `['all', 'trace', 'debug', 'detail', 'info', 'warn', 'error', 'fatal', 'off']` to get the name of the level.
++     * @param {string} level The level of the log which can be ['all', 'trace', 'debug', 'detail', 'info', 'warn', 'error', 'fatal', 'off'].
+      * @param {string} message The message of the log entry.
+      */
+ ",The callback get the log level as a number.
+9795,"@@ -71,6 +71,7 @@ setup(
+         ""hyperframe>=5.0, <6"",
+         ""jsbeautifier>=1.6.3, <1.7"",
+         ""kaitaistruct>=0.7, <0.8"",
++        ""ldap3>=2.2.0, <2.2.1"",
+         ""passlib>=1.6.5, <1.8"",
+         ""pyasn1>=0.1.9, <0.3"",
+         ""pyOpenSSL>=16.0, <17.1"",",Is there any issue with 2.2.3? If not this should be `<2.3`.
+9796,"@@ -1595,7 +1595,3 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         # Only support for MultiIndex
+         kser = ks.Series([10, -2, 4, 7])
+         self.assertRaises(ValueError, lambda: kser.unstack())
+-
+-    def test_item(self):
+-        kser = ks.Series([10, 20])
+-        self.assertRaises(ValueError, lambda: kser.item())",Shall we keep this test?
+9797,"@@ -102,12 +102,15 @@ class Tx_Solr_Backend_IndexingConfigurationSelectorField {
+ 	/**
+ 	 * Renders a field to select which indexing configurations to initialize.
+ 	 *
+-	 * Uses TCEforms.
++	 * Uses \TYPO3\CMS\Backend\Form\FormEngine.
+ 	 *
+ 	 *  @return string Markup for the select field
+ 	 */
+ 	public function render() {
+-		$tceForm = t3lib_div::makeInstance('t3lib_TCEforms');
++		$selectFieldRenderer = $formEngine = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Backend\\Form\\FormEngine');
++		if (class_exists('TYPO3\\CMS\Backend\\Form\\Element\\SelectElement')) {
++			$selectFieldRenderer = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\Backend\\Form\\Element\\SelectElement', $formEngine);
++		}
+
+ 			// transform selected values into the format used by TCEforms
+ 		$selectedValues = array();","When would this be the case? / When would SelectElement not be available? Is this change compatible with 6.2? (I'd like to roll a release that works with 6.2+ first, before moving on to 7.x)"
+9798,"@@ -257,6 +257,10 @@ public abstract class DataType implements Serializable {
+         + ((long) (readBuffer[7] & 255) << 56));
+   }
+
++  public boolean isSameCatalog(DataType other) {
++    return false;
++  }
++
+   // all data should be read in little endian.
+   public TiChunkColumnVector decodeChunkColumn(CodecDataInput cdi) {
+     int numRows = readIntLittleEndian(cdi);",how about rename to shouldNarrowDataTypeTo?
+9799,"@@ -33,6 +33,9 @@ from .util import bokeh_version
+
+ Store.renderers['bokeh'] = BokehRenderer.instance()
+
++if len(Store.renderers) == 1:
++    Store.current_backend = 'bokeh'
++
+ associations = {Overlay: OverlayPlot,
+                 NdOverlay: OverlayPlot,
+                 GridSpace: GridPlot,",Why not check that the one available renderer is 'bokeh'?
+9800,"@@ -28,3 +28,6 @@ var ErrIncomplete = errors.New(""incomplete config"")
+
+ // ErrNotReady is the error when a broker is not ready.
+ var ErrNotReady = errors.New(""not ready"")
++
++// ErrOverflow is the error when a broker ingress is sending too many requests to PubSub.
++var ErrOverflow = errors.New(""bundler reached buffered byte limit"")",Can you import `bundler.ErrOverflow` rather than redefine it here?
+9801,"@@ -305,7 +305,7 @@ public abstract class FlatteningConfig {
+       }
+
+       ResourceNameTreatment resourceNameTreatment = ResourceNameTreatment.NONE;
+-      String resourceNameType = protoParser.getResourceType(parameterField.getProtoField());
++      String resourceNameType = protoParser.getResourceReference(parameterField.getProtoField());
+       if (!Strings.isNullOrEmpty(resourceNameType)) {
+         resourceNameTreatment = ResourceNameTreatment.STATIC_TYPES;
+       }",This is just a renaming of the function getResourceType() to getResourceReference()
+9802,"@@ -106,7 +106,7 @@ module Beaker
+       ip = ''
+       if File.file?(@vagrant_file) #we should have a vagrant file available to us for reading
+         f = File.read(@vagrant_file)
+-        m = /#{hostname}.*?ip:\s*('|"")\s*([^'""]+)('|"")/m.match(f)
++        m = /'#{hostname}'.*?ip:\s*('|"")\s*([^'""]+)('|"")/m.match(f)
+         if m
+           ip = m[2]
+           @logger.debug(""Determined existing vagrant box #{hostname} ip to be: #{ip} "")","Seems like this might need to allow for `""`s to be used here?"
+9803,"@@ -295,8 +295,8 @@ CombatSpell::~CombatSpell()
+
+ bool CombatSpell::loadScriptCombat()
+ {
+-	combat = g_luaEnvironment.getCombatObject(g_luaEnvironment.lastCombatId);
+-	return combat != nullptr;
++	Combat_ptr combatPtr = g_luaEnvironment.getCombatObject(g_luaEnvironment.lastCombatId);
++	return combatPtr != nullptr;
+ }
+
+ bool CombatSpell::castSpell(Creature* creature)","here you assigning it to a local variable, in the original code it assigned to combat(CombatSpell member). Not sure if CombatSpell needs to use a shared_ptr since currently it does not and it works ""good""."
+9804,"@@ -1,7 +1,5 @@
+ <section id=""terms"">
+   <dl>
+-    <dt><p>How often is this video tutorial offered?</p></dt>
+-    <dd><p>This online video tutorial starts as soon as you register.</p></dd>
+     <dt><p>What if I'm not happy?</p></dt>
+     <dd><p>If you&rsquo;re not happy, just let us know within 30 days and we&rsquo;ll refund your money. It&rsquo;s as simple as that.</p></dd>
+   </dl>","Should we also remove this? This applies to subscriptions in general, but it seems sort of weird in the context of products now."
+9805,"@@ -27,7 +27,6 @@ from dagster.core.errors import DagsterExecutionInterruptedError, DagsterInvaria
+ from dagster.seven import IS_WINDOWS, multiprocessing
+ from dagster.seven.abc import Mapping
+
+-from .alert import make_email_on_pipeline_failure_sensor, make_email_on_run_failure_sensor
+ from .merger import merge_dicts
+ from .yaml_utils import load_yaml_from_glob_list, load_yaml_from_globs, load_yaml_from_path
+ ","I think we should keep these, o.w. our examples will be wrong (where we're importing from `dagster.utils`). Also, we might break folks who've imported following our docs."
+9806,"@@ -24,7 +24,7 @@ namespace OpenTelemetry.Trace
+     /// <summary>
+     /// Build TracerProvider with Resource, Sampler, Processors and Instrumentation.
+     /// </summary>
+-    internal class TracerProviderBuilderSdk : TracerProviderBuilder
++    public class TracerProviderBuilderSdk : TracerProviderBuilder
+     {
+         private readonly List<InstrumentationFactory> instrumentationFactories = new List<InstrumentationFactory>();
+         private readonly List<BaseProcessor<Activity>> processors = new List<BaseProcessor<Activity>>();",This is good and something that I think opens a lot of possibilities. I think what would be even better is to change up `TracerProviderSdk` to take factories for the processors just like it already does for the instrumentations. Should probably use use a factory for the sampler. If we made those 2 changes then we could actually split this all up into the config and the build phase and we could use the factory methods in the hosting version to call into the IServiceProvider to get those instances.
+9807,"@@ -48,9 +48,14 @@ func (t *Table) Normalize() {
+ 			if len(t.Data) > 0 {
+ 				t.KeyValues[j] = t.Data[0][idx]
+ 			}
+-			v := values.New(t.KeyValues[j])
+-			if v.Type() == semantic.Invalid {
+-				panic(fmt.Errorf(""invalid value: %s"", t.KeyValues[j]))
++			var v values.Value
++			if t.KeyValues[j] == nil {
++				v = values.NewNull(flux.SemanticType(t.ColMeta[idx].Type))
++			} else {
++				v = values.New(t.KeyValues[j])
++				if v.Type() == semantic.Invalid {
++					panic(fmt.Errorf(""invalid value: %s"", t.KeyValues[j]))
++				}
+ 			}
+ 			vs[j] = v
+ 		}",Is there a way to make it so `values.New(nil)` works instead of adding a new function?
+9808,"@@ -85,7 +85,11 @@ class ApiMediaType extends AbstractType
+      */
+     public function getParent()
+     {
+-        return 'sonata_media_api_form_doctrine_media';
++        // NEXT_MAJOR: Return 'Sonata\MediaBundle\Form\Type\ApiDoctrineMediaType'
++        // (when requirement of Symfony is >= 2.8)
++        return method_exists('Symfony\Component\Form\AbstractType', 'getBlockPrefix')
++            ? 'Sonata\MediaBundle\Form\Type\ApiDoctrineMediaType'
++            : 'sonata_media_api_form_doctrine_media';
+     }
+
+     /**",> when requirement of Symfony **will be** >= 2.8 Same for others.
+9809,"@@ -104,7 +104,8 @@ PROJECT_IAM_ROLES_SERVER = [
+     'roles/storage.objectViewer',
+     'roles/storage.objectCreator',
+     'roles/cloudsql.client',
+-    'roles/logging.logWriter'
++    'roles/logging.logWriter',
++    'roles/iam.serviceAccountTokenCreator'
+ ]
+
+ PROJECT_IAM_ROLES_CLIENT = [",I'd like to see if this can just be set on the service account instead of the project. Using the SVC_ACCT_ROLES (which should otherwise be deleted as I don't think anything else is using it.)
+9810,"@@ -7,6 +7,7 @@ import android.content.Intent;
+ import android.content.SharedPreferences;
+ import android.content.res.Configuration;
+ import android.database.DataSetObserver;
++import android.graphics.Color;
+ import android.os.Build;
+ import android.os.Bundle;
+ import android.os.Handler;",Please remove the unused imports :)
+9811,"@@ -82,11 +82,11 @@ ActiveRecord::Schema.define(version: 20140723160957) do
+   end
+
+   create_table ""comments"", force: true do |t|
++    t.text     ""comment_text""
+     t.datetime ""created_at""
+     t.datetime ""updated_at""
+-    t.string   ""commentable_type""
+     t.integer  ""commentable_id""
+-    t.text     ""comment_text""
++    t.string   ""commentable_type""
+   end
+
+   create_table ""properties"", force: true do |t|","Were these local edits? There doesn't appear to be a change here. If so, let's remove this from the commit."
+9812,"@@ -3,8 +3,13 @@ package server
+ import (
+ 	""crypto/ecdsa""
+ 	""crypto/x509""
++	""github.com/spiffe/spire/pkg/common/profiling""
+ 	""net""
++	""net/http""
++	_ ""net/http/pprof""
+ 	""net/url""
++	""runtime""
++	""strconv""
+ 	""sync""
+ 	""syscall""
+ ",nit: this should be further down w/ the rest of the github imports
+9813,"@@ -2,7 +2,7 @@ Hi <%= @user.first_name %>,
+
+ This is a reminder that your Learn <%= @subscription.plan_name %> subscription
+ will be automatically renewed on <%= l @subscription.next_payment_on %> for the
+-amount of <%= number_to_currency(@subscription.next_payment_amount) %>.
++amount of <%= number_to_currency(@subscription.next_payment_amount / 100) %>.
+
+ If you need to make any changes, you can do so by accessing your account page at
+ <%= my_account_url %>","I don't know if this is something we should address now, but we have a cents_to_dollars private method in both `SubscriptionCoupon` and `Invoice`."
+9814,"@@ -1619,7 +1619,9 @@ void ihipPrintKernelLaunch(const char* kernelName, const grid_launch_parm* lp,
+ // Allows runtime to track some information about the stream.
+ hipStream_t ihipPreLaunchKernel(hipStream_t stream, dim3 grid, dim3 block, grid_launch_parm* lp,
+                                 const char* kernelNameStr, bool lockAcquired) {
+-    stream = ihipSyncAndResolveStream(stream, lockAcquired);
++    if (stream == nullptr || stream != stream->getCtx()->_defaultStream){
++        stream = ihipSyncAndResolveStream(stream, lockAcquired);
++    }
+     lp->grid_dim.x = grid.x;
+     lp->grid_dim.y = grid.y;
+     lp->grid_dim.z = grid.z;",Formatting here and all below: missing space before open bracket for the compound statement.
+9815,"@@ -44,7 +44,6 @@ import org.junit.After;
+ import org.junit.Before;
+ import org.junit.BeforeClass;
+ import org.junit.Test;
+-import org.mortbay.util.ajax.JSON;
+
+ import static org.apache.solr.security.JWTAuthPlugin.JWTAuthenticationResponse.AuthCode.AUTZ_HEADER_PROBLEM;
+ import static org.apache.solr.security.JWTAuthPlugin.JWTAuthenticationResponse.AuthCode.NO_AUTZ_HEADER;",Avoid using old mortbay utilities for converting JSON. Uses existing Solr Utils to convert from JSON string.
+9816,"@@ -0,0 +1,19 @@
++'use strict';
++
++const CommandOperationV2 = require('./command_v2');
++const defineAspects = require('./operation').defineAspects;
++const Aspect = require('./operation').Aspect;
++
++class CommandDirect extends CommandOperationV2 {
++  constructor(parent, command, options) {
++    super(parent, options);
++    this.command = command;
++  }
++  execute(server, callback) {
++    const command = this.command;
++    this.executeCommand(server, command, callback);
++  }
++}
++defineAspects(CommandDirect, [Aspect.EXECUTE_WITH_SELECTION]);
++
++module.exports = CommandDirect;","I actually think this wrapping is great, but let's call it `RunCommandOperation`?"
+9817,"@@ -122,11 +122,15 @@ func errorsParse(c *caddy.Controller) (*ErrorHandler, error) {
+ 				}
+ 				f.Close()
+
+-				whatInt, err := strconv.Atoi(what)
+-				if err != nil {
+-					return hadBlock, c.Err(""Expecting a numeric status code, got '"" + what + ""'"")
++				if what == ""*"" {
++					handler.GenericErrorPage = where
++				} else {
++					whatInt, err := strconv.Atoi(what)
++					if err != nil {
++						return hadBlock, c.Err(""Expecting a numeric status code or '*', got '"" + what + ""'"")
++					}
++					handler.ErrorPages[whatInt] = where
+ 				}
+-				handler.ErrorPages[whatInt] = where
+ 			}
+ 		}
+ 		return hadBlock, nil",Maybe it is better to add checking for status code duplications? It can prevent some stupid copy-paste user errors.
+9818,"@@ -5,14 +5,14 @@ describe Invoice do
+     invoices = Invoice.
+       find_all_by_stripe_customer_id(FakeStripe::CUSTOMER_ID)
+
+-    invoices.length.should eq 1
+-    invoices.first.stripe_invoice_id.should eq 'in_1s4JSgbcUaElzU'
++    expect(invoices.length).to eq 1
++    expect(invoices.first.stripe_invoice_id).to eq 'in_1s4JSgbcUaElzU'
+   end
+
+   it 'does not find invoices with a blank customer' do
+-    Invoice.find_all_by_stripe_customer_id(' ').length.should eq 0
+-    Invoice.find_all_by_stripe_customer_id('').length.should eq 0
+-    Invoice.find_all_by_stripe_customer_id(nil).length.should eq 0
++    expect(Invoice.find_all_by_stripe_customer_id(' ').length).to eq 0
++    expect(Invoice.find_all_by_stripe_customer_id('').length).to eq 0
++    expect(Invoice.find_all_by_stripe_customer_id(nil).length).to eq 0
+   end
+
+   describe 'invoice fields' do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+9819,"@@ -1823,6 +1823,9 @@ mangle_return(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+         IF_X64(ASSERT_TRUNCATE(val, int, opnd_get_immed_int(instr_get_src(instr, 0))));
+         /* addl sizeof_param_area, %xsp
+          * except that clobbers the flags, so we use lea */
++        /* XXX i#3307: unimplemented, we can only support simple mangling cases in
++         * mangling epilogue.
++         */
+         PRE(ilist, next_instr,
+             INSTR_CREATE_lea(dcontext, opnd_create_reg(REG_XSP),
+                              opnd_create_base_disp(REG_XSP, REG_NULL, 0, val, OPSZ_lea)));",This lea should match instr_check_xsp_mangling and be undone. I don't think i#3307 applies here.
+9820,"@@ -87,6 +87,11 @@ type Store struct {
+ 	tipIndex *TipIndex
+ }
+
++type ipldStateThing interface {
++	Get(ctx context.Context, c cid.Cid, out interface{}) error
++	Put(ctx context.Context, v interface{}) (cid.Cid, error)
++}
++
+ // NewStore constructs a new default store.
+ func NewStore(ds repo.Datastore, cst state.IpldStore, stl state.TreeLoader, genesisCid cid.Cid) *Store {
+ 	return &Store{","I like the idea of this being an interface as it makes the test setup a bit easier, thoughts?"
+9821,"@@ -608,7 +608,8 @@ class ColdcardPlugin(HW_PluginBase):
+             pubkey_deriv_info = wallet.get_public_keys_with_deriv_info(address)
+             pubkey_hexes = sorted([pk.hex() for pk in list(pubkey_deriv_info)])
+             xfp_paths = []
+-            for pubkey in pubkey_deriv_info:
++            for pubkey_hex in pubkey_hexes:
++                pubkey = bytes.fromhex(pubkey_hex)
+                 ks, der_suffix = pubkey_deriv_info[pubkey]
+                 fp_bytes, der_full = ks.get_fp_and_derivation_to_be_used_in_partial_tx(der_suffix, only_der_suffix=False)
+                 xfp_int = xfp_int_from_xfp_bytes(fp_bytes)",Nit: I believe the electrum convention is to use `bfh` instead of `bytes.fromhex`. Great catch on this bug!
+9822,"@@ -1910,7 +1910,10 @@ def _getPredictedField(options):
+       predictedFieldInfo = info
+       break
+
+-  assert predictedFieldInfo
++  if predictedFieldInfo is None:
++    raise Exception(
++      ""Predicted field '%s' does not exist in included fields."" % predictedField
++    )
+   predictedFieldType = predictedFieldInfo['fieldType']
+
+   return predictedField, predictedFieldType",Use a more granular error type. I would recommend `ValueError` in this case.
+9823,"@@ -2699,6 +2699,9 @@ void Game::playerRequestTrade(uint32_t playerId, const Position& pos, uint8_t st
+ 		player->sendTextMessage(MSG_INFO_DESCR, ""You can not trade more than 100 items."");
+ 		return;
+ 	}
++	if (!g_events->eventPlayerOnTradeRequest(player,tradePartner,tradeItem)) {
++		return;
++	}
+
+ 	internalStartTrade(player, tradePartner, tradeItem);
+ }","A space after each argument, and an empty line above this if-statement."
+9824,"@@ -27,8 +27,8 @@ export function memo(c, comparer) {
+ 		this.shouldComponentUpdate = shouldUpdate;
+ 		return createElement(c, props);
+ 	}
+-	Memoed.prototype.isReactComponent = true;
+ 	Memoed.displayName = 'Memo(' + (c.displayName || c.name) + ')';
++	Memoed.prototype.isReactComponent = true;
+ 	Memoed._forwarded = true;
+ 	return Memoed;
+ }","Things like this make me wonder whether we should ship a ""development"" and a ""production"" version. I remember the discussions about making things more complex bundling wise but couldn't we omit this line in a ""production"" or ""minimal"" variant of our build? That would save us some bytes here and there. Or are we somehow able to move this line to debug? I though about monkey patching the exported function but that only works in CJS and not ESM AFAIK."
+9825,"@@ -6,6 +6,8 @@ namespace Datadog.Trace
+
+         Scope Activate(Span span, bool finishOnClose);
+
++        void AddScopeListener(IScopeListener listener);
++
+         void Close(Scope scope);
+     }
+ }",Maybe rename to `RegisterListener` or `RegisterSubscriber`?
+9826,"@@ -34,7 +34,8 @@ export function diffChildren(
+ 	oldDom,
+ 	isHydrating
+ ) {
+-	let i, j, oldVNode, newDom, sibDom, firstChildDom, refs;
++	let i, j, oldVNode, newDom, sibDom, firstChildDom;
++	let refs = [];
+
+ 	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
+ 	// as EMPTY_OBJ._children should be `undefined`.","My one concern here is that we are adding a new array allocation for each depth of the tree which could add some non-trivial GC churn. Perhaps this would be okay if we think that refs are used through a tree commonly enough such that they'll get allocated anyway but I'm not sure refs are *that* often used. Every app has a couple, but probably not at every level of their app :/ So maybe the extra bytes are worth it in this case? Though I have no data to back up my hypothesis so I could way off lol."
+9827,"@@ -45,7 +45,7 @@ class TestDeterminism < Test::Unit::TestCase
+
+   def subclasses
+     Faker.constants.delete_if do |subclass|
+-      %i[Base Bank Books Cat Char Base58 ChileRut Config Creature Date Dog DragonBall Dota ElderScrolls Fallout Games GamesHalfLife HeroesOfTheStorm Internet JapaneseMedia LeagueOfLegends Movies Myst Overwatch OnePiece Pokemon SwordArtOnline TvShows Time VERSION Witcher WorldOfWarcraft Zelda].include?(subclass)
++      %i[Base Bank Books Cat Char Base58 ChileRut CLI Config Creature Date Dog DragonBall Dota ElderScrolls Fallout Games GamesHalfLife HeroesOfTheStorm Internet JapaneseMedia LeagueOfLegends Movies Myst Overwatch OnePiece Pokemon SwordArtOnline TvShows Time VERSION Witcher WorldOfWarcraft Zelda].include?(subclass)
+     end.sort
+   end
+ ",We should get rid of this big array and think about a better way to check this.
+9828,"@@ -67,6 +67,11 @@ namespace MvvmCross.Droid.Shared.Presenter
+             var serializedRequest = Serializer.Serializer.SerializeObject(request);
+             bundle.PutString(ViewModelRequestBundleKey, serializedRequest);
+
++            if (request is MvxViewModelInstanceRequest)
++            {
++                Mvx.Resolve<IMvxChildViewModelCache>().Cache(((MvxViewModelInstanceRequest)request).ViewModelInstance);
++            }
++
+             if (!_fragmentHostRegistrationSettings.IsActualHostValid(request.ViewModelType))
+             {
+                 Type newFragmentHostViewModelType =",Should we cache the result of `Mvx.Resolve<IMvxChildViewModelCache>()` to avoid a lookup each time?
+9829,"@@ -89,7 +89,10 @@ class RequestConsumer:
+                     self.connect_to_rabbitmq()
+                     self.init_rabbitmq_channels()
+
+-        avg_size_of_message //= num_of_messages
++        try:
++            avg_size_of_message //= num_of_messages
++        except ZeroDivisionError:
++            current_app.logger.warn(""No messages calculated"", exc_info=True)
+
+         current_app.logger.info(""Done!"")
+         current_app.logger.info(""Number of messages sent: {}"".format(num_of_messages))","If you get to this line avg_size_of_message is an undefined value, yet you use it below. You you should set this value to something in the exception block."
+9830,"@@ -0,0 +1,10 @@
++package mux
++
++import (
++	""net/http""
++	""net/http/pprof""
++)
++
++func pprofHandlers(httpMux *http.ServeMux) {
++	httpMux.HandleFunc(""/debug/pprof/"", pprof.Index)
++}","let's just fold this inline in mux.go, no need for the indirection to this new file"
+9831,"@@ -31,6 +31,7 @@ import com.github.javaparser.ast.nodeTypes.NodeWithTokenRange;
+ import com.github.javaparser.ast.observer.AstObserver;
+ import com.github.javaparser.ast.observer.ObservableProperty;
+ import com.github.javaparser.ast.observer.PropagatingAstObserver;
++import com.github.javaparser.ast.stmt.BlockStmt;
+ import com.github.javaparser.ast.visitor.CloneVisitor;
+ import com.github.javaparser.ast.visitor.EqualsVisitor;
+ import com.github.javaparser.ast.visitor.HashCodeVisitor;","This bit confused me just now as I was reading through -- turns out this is due to the `{@link}` on line 316. Reading up on this, the alternative seems to be to state the fully qualified name instead. Happy to edit if requested as I don't have a strong view either way (perhaps a small leaning towards keeping the import)."
+9832,"@@ -159,6 +159,18 @@ public class CPPTokenizerTest {
+         tokenizer.tokenize(code, new Tokens());
+     }
+
++    @Test
++    public void testDigitSeparators() {
++        final String code = ""auto integer_literal = 1'000'000;"" + PMD.EOL
++                + ""auto floating_point_literal = 0.000'015'3;"" + PMD.EOL
++                + ""auto hex_literal = 0x0F00'abcd'6f3d;"" + PMD.EOL
++                + ""auto silly_example = 1'0'0'000'00;"";
++        Tokens tokens = parse(code);
++        System.out.println(tokens.getTokens());
++        assertTrue(TokenEntry.getEOF() != tokens.getTokens().get(0));
++        assertEquals(21, tokens.size());
++    }
++
+     private Tokens parse(String snippet) {
+         try {
+             return parse(snippet, false, new Tokens());",There's a unnecessary System.out.
+9833,"@@ -532,6 +532,15 @@ func (c *client) InstallGatewayFlows() error {
+ 	// Add flow to ensure the liveness check packet could be forwarded correctly.
+ 	flows = append(flows, c.localProbeFlow(gatewayIPs, cookie.Default)...)
+ 	flows = append(flows, c.ctRewriteDstMACFlows(gatewayConfig.MAC, cookie.Default)...)
++	if c.enableProxy {
++		flows = append(flows, c.arpNodePortVirtualResponderFlow())
++		if gatewayConfig.IPv6 != nil {
++			flows = append(flows, c.serviceGatewayFlow(true))
++		}
++		if gatewayConfig.IPv4 != nil {
++			flows = append(flows, c.serviceGatewayFlow(false))
++		}
++	}
+ 	// In NoEncap , no traffic from tunnel port
+ 	if c.encapMode.SupportsEncap() {
+ 		flows = append(flows, c.l3FwdFlowToGateway(gatewayIPs, gatewayConfig.MAC, cookie.Default)...)",Should we add the flows only when NodePort is enabled?
+9834,"@@ -2,12 +2,12 @@ AC_PREREQ([2.63])
+ dnl To do a release: follow the instructions to update libostree-released.sym from
+ dnl libostree-devel.sym, update the checksum in test-symbols.sh, set is_release_build=yes
+ dnl below. Then make another post-release commit to bump the version and set
+-dnl is_release_build=no
++dnl is_release_build=yes
+ dnl Seed the release notes with `git-shortlog-with-prs <previous-release>..`. Then use
+ dnl `git-evtag` to create the tag and push it. Finally, create a GitHub release and attach
+ dnl the tarball from `make dist`.
+ m4_define([year_version], [2020])
+-m4_define([release_version], [2])
++m4_define([release_version], [3])
+ m4_define([package_version], [year_version.release_version])
+ AC_INIT([libostree], [package_version], [walters@verbum.org])
+ is_release_build=no",ITYM to flip this one...
+9835,"@@ -7,7 +7,9 @@ module.exports = {
+   },
+   extends: [
+     'airbnb',
+-    'plugin:@typescript-eslint/recommended',
++    ""eslint:recommended"",
++    ""plugin:@typescript-eslint/eslint-recommended"",
++    ""plugin:@typescript-eslint/recommended"",
+     'prettier',
+     'prettier/@typescript-eslint',
+     'plugin:prettier/recommended',",What's the difference between typescript-eslint/eslint-recommended and typescript-eslint/recommended? I really can't get it.
+9836,"@@ -223,6 +223,14 @@ type Config struct {
+ 	// If the timeout is exceeded, the connection is closed.
+ 	// If this value is zero, the timeout is set to 30 seconds.
+ 	IdleTimeout time.Duration
++	// AttackTimeout is the maximum duration that may pass after a suspicious packet is
++	// received without any incoming network activity, used for experimental mitigation
++	// against injection attacks. If the timeout is exceeded, the connection is closed.
++	// This timeout should be longer than any reasonable round trip time, but excessively
++	// long timeouts will delay reporting of rejected connections.
++	// If this value is zero, the default mitigation behavior will be used (currently off).
++	// If this value is negative, mitigation will be disabled.
++	AttackTimeout time.Duration
+ 	// AcceptToken determines if a Token is accepted.
+ 	// It is called with token = nil if the client didn't send a token.
+ 	// If not set, a default verification function is used:","Thinking: Maybe it would be more useful to define this in terms of RTTs. That would also make it easier to switch this to a bool, since we could then pick a reasonable default value. Unless of course an attacker could influence our RTT estimate. Is that the case?"
+9837,"@@ -1,4 +1,3 @@
+-//  Copyright 2019 Google Inc. All Rights Reserved.
+ //
+ //  Licensed under the Apache License, Version 2.0 (the ""License"");
+ //  you may not use this file except in compliance with the License.",Why is this line deleted?
+9838,"@@ -115,9 +115,9 @@ void nano::active_transactions::request_confirm (std::unique_lock<std::mutex> &
+ 	std::deque<std::shared_ptr<nano::block>> rebroadcast_bundle;
+ 	std::deque<std::pair<std::shared_ptr<nano::block>, std::shared_ptr<std::vector<std::shared_ptr<nano::transport::channel>>>>> confirm_req_bundle;
+
+-	// Confirm frontiers when there aren't many confirmations already pending
++	// Confirm frontiers when there aren't many confirmations already pending and node finished initial boostrap
+ 	lock_a.unlock ();
+-	if (node.pending_confirmation_height.size () < confirmed_frontiers_max_pending_cut_off)
++	if (node.pending_confirmation_height.size () < confirmed_frontiers_max_pending_cut_off && node.store.block_count (transaction).sum () >= node.ledger.bootstrap_weight_max_blocks)
+ 	{
+ 		confirm_frontiers (transaction);
+ 	}",minor type `boostrap`
+9839,"@@ -20,9 +20,12 @@
+ package com.netflix.iceberg;
+
+ import com.google.common.base.Objects;
++import com.google.common.collect.Lists;
+ import com.netflix.iceberg.expressions.Expression;
+ import com.netflix.iceberg.expressions.ResidualEvaluator;
+
++import java.util.Iterator;
++
+ class BaseFileScanTask implements FileScanTask {
+   private final DataFile file;
+   private final String schemaString;",Nit: please don't separate imports into groups.
+9840,"@@ -31,7 +31,10 @@ public class ApplicationSidebarToggleGroupSkin extends
+         final ToggleButton allCategoryButton = createSidebarToggleButton(tr(""All""));
+
+         allCategoryButton.setId(""allButton"");
+-        allCategoryButton.setOnAction(event -> getControl().getOnAllCategorySelection().run());
++        allCategoryButton.setOnAction(event -> {
++            getControl().setSelectedElement(null);
++            getControl().getOnAllCategorySelection().run();
++        });
+
+         return Optional.of(allCategoryButton);
+     }",Thinking if it would be nice to have something like `setNothingSelected`.
+9841,"@@ -141,7 +141,7 @@ func (f *FileCertificateSource) updateCertificateFromDisk() error {
+ 		f.Log.V(logf.DebugLevel).Info(""key and certificate on disk have not changed"")
+ 		return nil
+ 	}
+-	f.Log.Info(""detected private key or certificate data on disk has changed. reloading certificate"")
++	f.Log.V(logf.DebugLevel).Info(""detected private key or certificate data on disk has changed. reloading certificate"")
+
+ 	cert, err := tls.X509KeyPair(certData, keyData)
+ 	if err != nil {","I think this is a useful InfoLevel message. In production, if webhook client connections suddenly start failing due to change of serving cert, you'd want to see this information in the logs."
+9842,"@@ -28,7 +28,7 @@ void AddTagProcessor::process(const cpp2::AddTagReq& req) {
+     auto version = time::TimeUtils::nowInMSeconds();
+     TagID tagId = autoIncrementId();
+     data.emplace_back(MetaUtils::indexKey(EntryType::TAG, req.get_tag_name()),
+-                      std::string(reinterpret_cast<const char*>(&tagId), sizeof(tagId)));
++                      folly::to<std::string>(tagId));
+     LOG(INFO) << ""Add Tag "" << req.get_tag_name() << "", tagId "" << tagId;
+     data.emplace_back(MetaUtils::schemaTagKey(req.get_space_id(), tagId, version),
+                       MetaUtils::schemaTagVal(req.get_tag_name(), req.get_schema()));","Generally, if cast from int to char*, you could cast directly. Because no errors should happen."
+9843,"@@ -26,5 +26,12 @@ public class ServerInternals {
+   public static final String AZKABAN_EXECUTOR_PORT_FILENAME = ""executor.port"";
+
+   public static final String AZKABAN_SERVLET_CONTEXT_KEY = ""azkaban_app"";
+-
++
++
++  // Memory check retry interval when OOM in ms
++  public static final long MEMORY_CHECK_INTERVAL = 1000*60*10;
++
++  // Max number of memory check retry
++  public static final int MEMORY_CHECK_RETRY_LIMIT = 100;
++
+ }","Is 10 min too long? What do you think about 1 minute? Unless there are many jobs in this state, I don't expect the CPU overhead to be too high."
+9844,"@@ -28,10 +28,10 @@ type BackendServiceConfig struct {
+ 	ImageConfig      ImageWithPortAndHealthcheck `yaml:""image,flow""`
+ 	ImageOverride    `yaml:"",inline""`
+ 	TaskConfig       `yaml:"",inline""`
+-	*Logging         `yaml:""logging,flow""`
++	Logging          `yaml:""logging,flow""`
+ 	Sidecars         map[string]*SidecarConfig `yaml:""sidecars""`
+-	Network          *NetworkConfig            `yaml:""network""`
+-	Publish          *PublishConfig            `yaml:""publish""`
++	Network          NetworkConfig             `yaml:""network""`
++	Publish          PublishConfig             `yaml:""publish""`
+ 	TaskDefOverrides []OverrideRule            `yaml:""taskdef_overrides""`
+ }
+ ",can you remind me why we keep the pointer if it's a `map[string]<PStruct>`? are there other scenarios where the pointer is kept?
+9845,"@@ -61,8 +61,9 @@ public class RewriteDataFilesAction extends BaseRewriteDataFilesAction<RewriteDa
+     return this;
+   }
+
+-  public void maxParallelism(int parallelism) {
++  public RewriteDataFilesAction maxParallelism(int parallelism) {
+     Preconditions.checkArgument(parallelism > 0, ""Invalid max parallelism %d"", parallelism);
+     this.maxParallelism = parallelism;
++    return this;
+   }
+ }",Would it make sense to also add `setMaxParallelism` in addition to this to match the Flink API?
+9846,"@@ -1,4 +1,13 @@
+ import ModalComponent from 'ghost-admin/components/modal-base';
++import {inject as service} from '@ember/service';
+
+ export default ModalComponent.extend({
++    billing: service(),
++
++    actions: {
++        closeModal() {
++            this._super(arguments);
++            this.billing.closeBillingWindow();
++        }
++    }
+ });",Not needed for actions. `_super(...arguments)` is only needed when you're extending from a base class and want to run the logic in the base class before your own logic
+9847,"@@ -104,7 +104,14 @@ Suspense.prototype._childDidSuspend = function(promise, suspendingComponent) {
+ 		}
+ 	};
+
+-	if (!c._pendingSuspensionCount++) {
++	/**
++	 * We do not set `suspended: true` during hydration because we want the actual markup
++	 * to remain on screen and hydrate it when the suspense actually gets resolved.
++	 * While in non-hydration cases the usual fallback -> component flow would occour.
++	 */
++	const vnode = c._vnode;
++	const wasHydrating = vnode && vnode._hydrating === true;
++	if (!wasHydrating && !c._pendingSuspensionCount++) {
+ 		c.setState({ _suspended: (c._detachOnNextRender = c._vnode._children[0]) });
+ 	}
+ 	promise.then(onResolved, onResolved);","I still need to run this code to verify my understanding, but my first reading through makes me think this may need to be `suspendingComponent._vnode` since we set `vnode._hydrating` on the vnode that threw the error (diff/index.js:275), not on `Suspense._vnode` (though we could in Suspense's `_catchError` implementation at the top of this file)."
+9848,"@@ -372,8 +372,14 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
+         path = None
+
+     if check_exists:
+-        if path is not None and os.path.exists(path):
+-            log.url.debug(""URL is a local file"")
++        if path is not None:
++            # If the path contains characters that the locale cannot handle,
++            # then we consider it as non-existent.
++            try:
++                if os.path.exists(path):
++                    log.url.debug(""URL is a local file"")
++            except UnicodeEncodeError:
++                path = None
+         else:
+             path = None
+ ","I think it's a good idea to log this as debug, the same way the other branch gets logged."
+9849,"@@ -73,7 +73,7 @@ class TestJSONLD(AnnotationTestCase):
+                 ""comment"": 1}
+         a = API.add_annotation(model='annotation_note', **data)
+
+-        # JSONAlchemy issue with overwritting fields
++        # JSONAlchemy issue with overwriting fields
+         self.assert_(len(a.validate()) == 0)
+
+         ld = a.get_jsonld(""oaf"",",1:D100: Docstring missing 35:D101: Docstring missing 37:D102: Docstring missing 42:D101: Docstring missing 44:D102: Docstring missing 57:D102: Docstring missing 66:D101: Docstring missing 69:D102: Docstring missing
+9850,"@@ -20,6 +20,10 @@ import (
+ 	""context""
+ )
+
++const (
++	systemGuestRoleName = ""system.guest""
++)
++
+ var (
+ 	systemTokenInst TokenGenerator = &noauth{}
+ ","keeping this as an unexported constant, as importing the role pkg creates a cyclic dependency."
+9851,"@@ -349,9 +349,12 @@ func (c *collection) newPut(a *driver.Action, opts *driver.RunActionsOptions) (*
+ 		// It doesn't make sense to generate a random sort key.
+ 		return nil, fmt.Errorf(""missing sort key %q"", c.sortKey)
+ 	}
+-	rev := driver.UniqueString()
+-	if av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {
+-		return nil, err
++	var rev string
++	if a.Doc.RevisionOn(c.RevisionField()) {
++		rev = driver.UniqueString()
++		if av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {
++			return nil, err
++		}
+ 	}
+ 	dput := &dyn.Put{
+ 		TableName: &c.table,",Why `c.RevisionField()` here but `c.opts.RevisionField` just below?
+9852,"@@ -139,7 +139,6 @@ type Context struct {
+ 	OriginalTargetReached bool
+ 	OvmExecutionManager   dump.OvmDumpAccount
+ 	OvmStateManager       dump.OvmDumpAccount
+-	OvmMockAccount        dump.OvmDumpAccount
+ 	OvmSafetyChecker      dump.OvmDumpAccount
+ }
+ ",nit: this file diff seems unrelated and probably should have been a separate PR
+9853,"@@ -38,7 +38,7 @@ extern ""C"" {
+   void latte(int *, int *, double *, int *, int *,
+              double *, double *, double *, double *,
+              double *, double *, double *, int*,
+-             double *, double *, double *, double * );
++             double *, double *, double *, double *, bool *);
+ }
+
+ #define INVOKED_PERATOM 8","@sjplimp just checked this API in the latte repository master branch (which is what Install.py downloads) and this still does not provide the 18th argument. We cannot merge this pull request until this is available. i would also suggest to implement a second binding, a function called latte_abiversion() returning an int with an ABI version number (starting with 1). This way, it can be tested, whether the ABI expected by the LAMMPS interface and provided by the library is compatible *before* calling the `latte()` function and risking a segmentation fault."
+9854,"@@ -214,7 +214,10 @@ namespace Nethermind.JsonRpc.Modules.Eth
+             }
+
+             Account account = _stateReader.GetAccount(header.StateRoot, address);
+-            return Task.FromResult(ResultWrapper<UInt256?>.Success(account?.Nonce ?? 0));
++            UInt256 nonce = account?.Nonce ?? 0;
++            _logger.Warn($""{address} nonce is {nonce}"");
++
++            return Task.FromResult(ResultWrapper<UInt256?>.Success(nonce));
+         }
+
+         public ResultWrapper<UInt256?> eth_getBlockTransactionCountByHash(Keccak blockHash)",Is this from debugging?
+9855,"@@ -51,12 +51,17 @@ class NodeTest extends TestCase
+
+     /**
+      */
+-    public function testAddChildren():void
++    public function testAddChildren(): void
+     {
++        $categoryId2 = new CategoryId('cde02652-70ce-484e-bc9d-3bf61391522d');
++
+         /** @var Node|MockObject $children */
+-        $children = $this->createMock(Node::class);
++        $children = new Node($categoryId2);
+         $node = new Node($this->categoryId);
++        $this->assertFalse($node->hasChildren($categoryId2));
+         $node->addChildren($children);
+         $this->assertEquals($children, $node->getChildrens()[0]);
++        $this->assertFalse($node->hasSuccessor($this->categoryId));
++        $this->assertTrue($node->hasChildren($categoryId2));
+     }
+ }",Its betet use MockedObject
+9856,"@@ -840,8 +840,12 @@ type DiskBlockCache interface {
+ 	// Put puts a block to the disk cache.
+ 	Put(ctx context.Context, tlfID tlf.ID, blockID kbfsblock.ID, buf []byte,
+ 		serverHalf kbfscrypto.BlockCryptKeyServerHalf) error
+-	// DeleteByTLF deletes some blocks from the disk cache.
+-	DeleteByTLF(ctx context.Context, tlfID tlf.ID, blockIDs []kbfsblock.ID) (numRemoved int, sizeRemoved int64, err error)
++	// Delete deletes some blocks from the disk cache.
++	Delete(ctx context.Context, blockIDs []kbfsblock.ID) (numRemoved int,
++		sizeRemoved int64, err error)
++	// UpdateMetadata updates the metadata for the given block, including
++	// setting the LRU time to now.
++	UpdateMetadata(ctx context.Context, blockID kbfsblock.ID) error
+ 	// Size returns the size in bytes of the disk cache.
+ 	Size() int64
+ 	// Shutdown cleanly shuts down the disk block cache.","""including""? Since it doesn't take any parameters, I'm not sure how it can update anything else..."
+9857,"@@ -674,7 +674,7 @@ namespace AutoRest.Core.Properties {
+         }
+
+         /// <summary>
+-        ///   Looks up a localized string similar to Non-HTTPS/HTTP schemes have limited support.
++        ///   Looks up a localized string similar to Azure Resource Management only supports HTTPS scheme..
+         /// </summary>
+         public static string SupportedSchemesWarningMessage {
+             get {",nit: I'm assuming you have verified this is what the error message should read like
+9858,"@@ -850,4 +850,4 @@ def main(argv):
+     return glob_result
+
+ if __name__ == ""__main__"":
+-    exit(main(sys.argv[1:]))
++    sys.exit(main(sys.argv[1:]))",Why do you need that? (real question)
+9859,"@@ -1788,7 +1788,7 @@ static void skipCppTemplateParameterList (void)
+ 				}
+ 			}
+ 			else if(CollectingSignature)
+-				vStringPut (Signature, x);
++				vStringPut (Signature, c);
+ 		}
+ 		else if (c == '>')
+ 		{",If I understand the patch correctly the `else` is no longer required.
+9860,"@@ -11,14 +11,14 @@ import (
+
+ var (
+ 	dealsSearchCount  uint64
+-	addToBlacklist    bool
++	blacklistTypeStr  string
+ 	crNewDurationFlag string
+ 	crNewPriceFlag    string
+ )
+
+ func init() {
+ 	dealListCmd.PersistentFlags().Uint64Var(&dealsSearchCount, ""limit"", 10, ""Deals count to show"")
+-	dealCloseCmd.PersistentFlags().BoolVar(&addToBlacklist, ""blacklist"", false, ""Add counterparty to blacklist"")
++	dealCloseCmd.PersistentFlags().StringVar(&blacklistTypeStr, ""blacklist"", ""none"", ""Whom to add to blacklist (worker, master or neither)"")
+ 	changeRequestCreateCmd.PersistentFlags().StringVar(&crNewDurationFlag, ""new-duration"", """", ""Propose new duration for a deal"")
+ 	changeRequestCreateCmd.PersistentFlags().StringVar(&crNewPriceFlag, ""new-price"", """", ""Propose new price for a deal"")
+ ",Properly describe valid flag values here: `neither` should be replaced with `none` as they parsed below.
+9861,"@@ -379,7 +379,16 @@ public class AzkabanExecutorServer {
+           logger.info((""Exception when logging top memory consumers""), e);
+         }
+
+-        logger.info(""Shutting down..."");
++        String host = app.getHost();
++        int port = app.getPort();
++        try {
++          logger.info(String.format(""Removing executor(host: %s, port: %s) entry from database..."", host, port));
++          app.getExecutorLoader().removeExecutor(host, port);
++        } catch (ExecutorManagerException ex) {
++          logger.error(String.format(""Exception when removing executor(host: %s, port: %s)"", host, port), ex);
++        }
++
++        logger.info(""Shutting down executor..."");
+         try {
+           app.shutdownNow();
+         } catch (Exception e) {",Can we escalate this to `warn`. It is a major event.
+9862,"@@ -86,6 +86,8 @@ var (
+ 	_                            = stateOffDstPort
+ 	stateOffPostNATDstPort int16 = 24
+ 	stateOffIPProto        int16 = 26
++	stateOffICMPType       int16 = 22
++	stateOffICMPCode       int16 = 23
+
+ 	// Compile-time check that IPSetEntrySize hasn't changed; if it changes, the code will need to change.
+ 	_ = [1]struct{}{{}}[20-ipsets.IPSetEntrySize]",Please move these up to line 86 so the numbers are in order.
+9863,"@@ -0,0 +1,16 @@
++from ..builder import DETECTORS
++from .single_stage import SingleStageDetector
++
++
++@DETECTORS.register_module()
++class NASFCOS(SingleStageDetector):
++
++    def __init__(self,
++                 backbone,
++                 neck,
++                 bbox_head,
++                 train_cfg=None,
++                 test_cfg=None,
++                 pretrained=None):
++        super(NASFCOS, self).__init__(backbone, neck, bbox_head, train_cfg,
++                                      test_cfg, pretrained)",Add a docstring to contain the paper link.
+9864,"@@ -170,7 +170,11 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(stri
+ 		for i, path := range config.ExtraFiles() {
+ 			abspath := filepath.Join(root, path)
+ 			outpath := filepath.Join(dir, ""extra-""+strconv.Itoa(i)+""-""+filepath.Base(path)+"".o"")
+-			err := runCCompiler(config.Target.Compiler, append(config.CFlags(), ""-c"", ""-o"", outpath, abspath)...)
++			targ:=config.Target.Triple
++			if targ!="""" {
++				targ=""--target=""+config.Target.Triple
++			}
++			err := runCCompiler(config.Target.Compiler, append(config.CFlags(), ""-c"", targ,""-o"", outpath, abspath)...)
+ 			if err != nil {
+ 				return &commandError{""failed to build"", path, err}
+ 			}","Instead of adding the `--target` flag here, the `Target` struct should be set up correctly. Assuming this is for the Raspberry Pi 3, adding it to the `cflags` key of the JSON file should be enough (if not, you can print `config.CFlags()` here to check whether `--target` is already included)."
+9865,"@@ -280,7 +280,9 @@ func (s *Service) BatchCreateFederatedBundle(ctx context.Context, req *bundlev1.
+ 		r := s.createFederatedBundle(ctx, b, req.OutputMask)
+ 		results = append(results, r)
+
+-		rpccontext.AuditRPCWithTypesStatus(ctx, r.Status, fieldsFromBundleProto(b, nil))
++		if _, ok := rpccontext.AuditLog(ctx); ok {
++			rpccontext.AuditRPCWithTypesStatus(ctx, r.Status, fieldsFromBundleProto(b, nil))
++		}
+ 	}
+
+ 	return &bundlev1.BatchCreateFederatedBundleResponse{",The changes in this file look unnecessary since `rpccontext.AuditRPCWithTypesStatus()` already does this check. Was there a reason you needed to add them?
+9866,"@@ -0,0 +1,9 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package batchstore
++
++const StateKey = stateKey
++
++var BatchKey = batchKey",you could probably use `const` for both?
+9867,"@@ -0,0 +1,9 @@
++import { isDataTable } from '../commons/table';
++import { isFocusable } from '../commons/dom';
++
++// TODO: es-modules add tests. No way to access this on the `axe` object
++function dataTableMatches(node) {
++	return !isDataTable(node) && !isFocusable(node);
++}
++
++export default dataTableMatches;","This looks like an ""ES Module"" to me. I do not understand this TODO."
+9868,"@@ -103,8 +103,8 @@ public class RowDataRewriter implements Serializable {
+     OutputFileFactory fileFactory = new OutputFileFactory(
+         spec, format, locations, io.value(), encryptionManager.value(), partitionId, taskId);
+
+-    TaskWriter<InternalRow> writer;
+-    if (spec.fields().isEmpty()) {
++    final TaskWriter<InternalRow> writer;
++    if (spec.isUnpartitioned()) {
+       writer = new UnpartitionedWriter<>(spec, format, appenderFactory, fileFactory, io.value(),
+           Long.MAX_VALUE);
+     } else if (PropertyUtil.propertyAsBoolean(properties,","Iceberg doesn't use `final` because it is unlikely that this actually helps. In Java 8, final detection is quite good, which is why non-final variables can be used in closures and lambdas. And final doesn't produce different byte code so it can't do much to help at runtime."
+9869,"@@ -7391,7 +7391,7 @@ int LuaScriptInterface::luaPlayerGetIp(lua_State* L)
+ 	// player:getIp()
+ 	Player* player = getUserdata<Player>(L, 1);
+ 	if (player) {
+-		lua_pushnumber(L, player->getIP());
++		lua_pushstring(L, player->getIP().to_string().c_str());
+ 	} else {
+ 		lua_pushnil(L);
+ 	}",There's `pushString` to use with C++ strings.
+9870,"@@ -306,6 +306,13 @@ var _ = infrastructure.DatastoreDescribe(""service loop prevention; with 2 nodes""
+ 			cfg.Spec.ServiceLoopPrevention = ""Disabled""
+ 		})
+
++		// Expect to see empty cali-cidr-block chains.  (Allowing time for a Felix
++		// restart.)  This ensures that the cali-cidr-block chain has been cleared
++		// before we try a test ping.
++		for _, felix := range felixes {
++			Eventually(getCIDRBlockRules(felix, ""iptables-save""), ""8s"", ""0.5s"").Should(BeEmpty())
++		}
++
+ 		By(""test that we DO get a routing loop"")
+ 		// (In order to test that the tryRoutingLoop setup is genuine.)
+ 		tryRoutingLoop(true)",qq: Should this include the iptables6-save sim. to the inverse checks above?
+9871,"@@ -622,7 +622,11 @@ bool RTPSParticipantImpl::create_writer(
+
+     std::lock_guard<std::recursive_mutex> guard(*mp_mutex);
+     m_allWriterList.push_back(SWriter);
+-    if (!is_builtin)
++    if (is_builtin)
++    {
++        async_thread().wake_up(SWriter);
++    }
++    else
+     {
+         m_userWriterList.push_back(SWriter);
+     }",What about async user writers? We could be checking `param.mode == ASYNCHRONOUS_WRITER`
+9872,"@@ -84,7 +84,7 @@ public class UseUtilityClassRule extends AbstractLombokAwareRule {
+     private boolean isOkUsingLombok(ASTClassOrInterfaceDeclaration parent) {
+         // check if there's a lombok no arg private constructor, if so skip the rest of the rules
+         if (hasClassLombokAnnotation()) {
+-            ASTAnnotation annotation = getLombokAnnotation(parent, ""NoArgsConstructor"");
++            ASTAnnotation annotation = parent.getAnnotation(""lombok.NoArgsConstructor"");
+
+             if (annotation != null) {
+ ","this double check for lombok annotation + specific lombok annotation seems pointless, just keep the second (specific) check. Moreover, since we have a property with ignored annotations... why don't we use it? a user may setup the property and it will be ignored here. Also, this class should probably not extend `AbstractLombokAwareRule` anymore. We have a configurable set of annotations that suppress the warning, defaulting to ALL lombok annotations, yet we only check for `lombok.NoArgsConstructor`... Maybe directly extending `AbstractIgnoredAnnotRule` and settig the default property to `lombok.NoArgsConstructor`? Or, to avoid a breaking API change, keep extending it, but override the default. For 7.0.0 we can change the class hierarchy."
+9873,"@@ -67,9 +67,11 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // route requests through YARPC. The http.Handler returned by this function
+ // may delegate requests to the provided YARPC handler to route them through
+ // YARPC.
++// If more than one Interception is provided, they will be invoked in the same
++// order as they are passed in.
+ func Interceptor(interceptor func(yarpcHandler http.Handler) http.Handler) InboundOption {
+ 	return func(i *Inbound) {
+-		i.interceptor = interceptor
++		i.interceptors = append(i.interceptors, interceptor)
+ 	}
+ }
+ ","nit: the ordering may be misunderstood, as ""invoked in the same order"" could suggest the passed-in functions are called in-order, but the actual wrapping is LIFO. Some other ways to describe it (don't think any of these are ideal, but maybe it will help you come up with something better), * the handled returned by the first interceptor is executed first * interceptors are applied outside-in (don't like the terms outside/in though) * interceptors are applied in LIFO order, leading to an earlier interceptor's handler being executed before latter interceptor handlers"
+9874,"@@ -101,6 +101,8 @@ import org.w3c.dom.NodeList;
+ import org.xml.sax.InputSource;
+ import org.xml.sax.SAXException;
+
++import static org.apache.solr.common.params.QueryElevationParams.ELEVATE_DOCS_WITHOUT_MATCHING_Q;
++
+ /**
+  * A component to elevate some documents to the top of the result set.
+  *",We should not use a static import to be consistent with other existing use of the QueryElevationParams.
+9875,"@@ -277,7 +277,7 @@ void *ap6_thread(void *thread_context)
+ 	uint32_t num_matches = 0;
+
+ 	struct bitstream_info null_gbs_info ;
+-	memset(&null_gbs_info, 0, sizeof(null_gbs_info));
++	memset_s(&null_gbs_info, sizeof(null_gbs_info), 0);
+
+ 	ON_GOTO(c->config->num_null_gbs == 0, out_exit, ""no NULL bitstreams registered."");
+ ",No need to check return value?
+9876,"@@ -42,6 +42,11 @@ from typing import (Any, Callable, IO, Iterator, Optional, Sequence, Tuple, Type
+ from PyQt5.QtCore import QUrl, QVersionNumber
+ from PyQt5.QtGui import QClipboard, QDesktopServices
+ from PyQt5.QtWidgets import QApplication
++# We cannot use the stdlib version on 3.7-3.8 because we need the files() API.
++if sys.version_info >= (3, 9):
++    import importlib.resources as importlib_resources
++else:
++    import importlib_resources
+ import pkg_resources
+ import yaml
+ try:","~~Feel free to ignore that one, I'll fix things up when regenerating the `requirements.txt`.~~ As for the one below, this smells like a pylint bug..."
+9877,"@@ -279,6 +279,7 @@ func (fa *flowAggregator) InitCollectingProcess() error {
+ 			IsEncrypted:   false,
+ 		}
+ 	}
++	cpInput.NumExtraElements = len(antreaSourceStatsElementList) + len(antreaDestinationStatsElementList) + len(antreaLabelsElementList)
+ 	var err error
+ 	fa.collectingProcess, err = ipfix.NewIPFIXCollectingProcess(cpInput)
+ 	return err",it's a bit strange that this doesn't match `aggregationElements` which is what I would expect. I guess I am not familiar enough with go-ipfix.
+9878,"@@ -35,11 +35,13 @@
+ #include ""instr.h""
+
+ static int num_simd_saved;
++static int num_simd_saved_abs;
+
+ void
+ proc_init_arch(void)
+ {
+     num_simd_saved = MCXT_NUM_SIMD_SLOTS;
++    num_simd_saved_abs = MCXT_NUM_SIMD_SLOTS;
+
+     /* FIXME i#1569: NYI */
+ }",Same thing: `num_simd_registers`. Ditto below.
+9879,"@@ -47,7 +47,7 @@ DEPENDENCY_LINKS = [
+ ]
+
+ setup(name='kinto',
+-      version='2.2.0.dev0',
++      version='2.2.1',
+       description='Kinto Web Service - Store, Sync, Share, and Self-Host.',
+       long_description=README + ""\n\n"" + CHANGELOG + ""\n\n"" + CONTRIBUTORS,
+       license='Apache License (2.0)',",Should be 2.1.1
+9880,"@@ -7,14 +7,16 @@ from localstack.utils.common import to_str, short_uid
+ TEST_BUCKET_NAME_WITH_NOTIFICATIONS = 'test_bucket_notif_1'
+ TEST_QUEUE_NAME_FOR_S3 = 'test_queue'
+ TEST_TOPIC_NAME = 'test_topic_name_for_sqs'
++TEST_S3_TOPIC_NAME = 'test_topic_name_for_s3_to_sns_to_sqs'
+ TEST_QUEUE_NAME_FOR_SNS = 'test_queue_for_sns'
+
+
+-def receive_assert_delete(queue_url, assertions, sqs_client=None):
++def receive_assert_delete(queue_url, assertions, sqs_client=None, required_subject=None):
+     if not sqs_client:
+         sqs_client = aws_stack.connect_to_service('sqs')
+
+     response = sqs_client.receive_message(QueueUrl=queue_url)
++
+     messages = [json.loads(to_str(m['Body'])) for m in response['Messages']]
+     testutil.assert_objects(assertions, messages)
+     for message in response['Messages']:",nitpick: `required_subject` doesn't seem to be used here
+9881,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.
+9882,"@@ -871,6 +871,14 @@ class UIA(Window):
+ 					states.add(controlTypes.STATE_CHECKED)
+ 		return states
+
++	def _get_presentationType(self):
++		presentationType=super(UIA,self).presentationType
++		# UIA NVDAObjects can only be considered content if UI Automation considers them both a control and content.
++		if presentationType==self.presType_content and not (self.UIAElement.cachedIsContentElement and self.UIAElement.cachedIsControlElement):
++			presentationType=self.presType_layout
++		return presentationType
++
++
+ 	def correctAPIForRelation(self, obj, relation=None):
+ 		if obj and self.windowHandle != obj.windowHandle and not obj.UIAElement.cachedNativeWindowHandle:
+ 			# The target element is not the root element for the window, so don't change API class; i.e. always use UIA.",Extraneous blank line.
+9883,"@@ -20,7 +20,8 @@ from codechecker_lib.analyzers import analyzer_clangsa
+ from codechecker_lib.analyzers import config_handler_clang_tidy
+ from codechecker_lib.analyzers import config_handler_clangsa
+ from codechecker_lib.analyzers import result_handler_clang_tidy
+-from codechecker_lib.analyzers import result_handler_clangsa
++from codechecker_lib.analyzers import result_handler_plist_to_db
++from codechecker_lib.analyzers import result_handler_plist_to_stdout
+
+ LOG = LoggerFactory.get_new_logger('ANALYZER TYPES')
+ ",Is this the same import as in the line 20?
+9884,"@@ -5,6 +5,7 @@ class Template < ActiveRecord::Base
+   validates_with TemplateLinksValidator
+
+   before_validation :set_defaults
++  after_update :reconcile_published, if: Proc.new { |template| template.published? && template.version.present? && template.version > 0 }
+
+   # Stores links as an JSON object: { funder: [{""link"":""www.example.com"",""text"":""foo""}, ...], sample_plan: [{""link"":""www.example.com"",""text"":""foo""}, ...]}
+   # The links is validated against custom validator allocated at validators/template_links_validator.rb",why those additional checks after published? template.version should always be present and greater than zero
+9885,"@@ -61,6 +61,16 @@ type ExternalEntityReference struct {
+ 	Namespace string `json:""namespace,omitempty"" protobuf:""bytes,2,opt,name=namespace""`
+ }
+
++// EntityReference represents a reference to either a Pod or an ExternalEntity.
++// TODO: replace Pod and ExternalEntity in GroupMember to embed EntityReference
++//  when controlplane version is bumped?
++type EntityReference struct {
++	// Pod maintains the reference to the Pod.
++	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,1,opt,name=pod""`
++	// ExternalEntity maintains the reference to the ExternalEntity.
++	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,2,opt,name=externalEntity""`
++}
++
+ // GroupMember represents resource member to be populated in Groups.
+ // This supersedes GroupMemberPod, and will eventually replace it.
+ type GroupMember struct {",I did not see this is used in the controlplane API? Is it for internal use only? Then no need to define it here?
+9886,"@@ -138,7 +138,7 @@ void printDeviceProp(int deviceId) {
+     cout << setw(w1) << ""arch.hasSurfaceFuncs: "" << props.arch.hasSurfaceFuncs << endl;
+     cout << setw(w1) << ""arch.has3dGrid: "" << props.arch.has3dGrid << endl;
+     cout << setw(w1) << ""arch.hasDynamicParallelism: "" << props.arch.hasDynamicParallelism << endl;
+-    cout << setw(w1) << ""gcnArch: "" << props.gcnArch << endl;
++    cout << setw(w1) << ""gcnArchName: "" << props.gcnArchName << endl;
+     cout << setw(w1) << ""isIntegrated: "" << props.integrated << endl;
+     cout << setw(w1) << ""maxTexture1D: "" << props.maxTexture1D << endl;
+     cout << setw(w1) << ""maxTexture2D.width: "" << props.maxTexture2D[0] << endl;",Should we also add a line to print gcnArch?
+9887,"@@ -87,6 +87,7 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
+         .replace('<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML""', '<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML"" flattenhtml=""true""')
+         .replace(pageVisibility, bravePageVisibility + pageVisibility)
+         .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
++        .replace(/Automatically sends usage statistics and crash reports to Brave/g, 'Automatically sends crash reports to Brave')
+         .replace(/The Chromium Authors/g, 'Brave Software Inc')
+         .replace(/Google Chrome/g, 'Brave')
+         .replace(/Chromium/g, 'Brave')","I merged already so need another PR, but I think this needs to be at the bottom."
+9888,"@@ -150,6 +150,7 @@ bool ConfigManager::load()
+ 	boolean[ONLINE_OFFLINE_CHARLIST] = getGlobalBoolean(L, ""showOnlineStatusInCharlist"", false);
+ 	boolean[YELL_ALLOW_PREMIUM] = getGlobalBoolean(L, ""yellAlwaysAllowPremium"", false);
+ 	boolean[FORCE_MONSTERTYPE_LOAD] = getGlobalBoolean(L, ""forceMonsterTypesOnLoad"", true);
++	boolean[HOUSE_OWNED_BY_ACCOUNT] = getGlobalBoolean(L, ""houseOwnedByAccount "", false);
+
+ 	string[DEFAULT_PRIORITY] = getGlobalString(L, ""defaultPriority"", ""high"");
+ 	string[SERVER_NAME] = getGlobalString(L, ""serverName"", """");",space in key string?
+9889,"@@ -48,9 +48,13 @@ func (b *ProcessBuilder) Build() *ManagedProcess {
+ 	if len(b.nsOptions) > 0 {
+ 		args = append([]string{""--"", cmd}, args...)
+ 		for _, option := range b.nsOptions {
+-			args = append([]string{""-"" + nsArgMap[option.Typ] + option.Path}, args...)
++			args = append([]string{""-"" + nsArgMap[option.Typ], option.Path}, args...)
+ 		}
+-		cmd = ""nsenter""
++
++		if b.localMnt {
++			args = append([]string{""-l""}, args...)
++		}
++		cmd = nsexecPath
+ 	}
+
+ 	if b.pause {",The commends of this function should be updated
+9890,"@@ -48,6 +48,7 @@ class AnchorHead(nn.Module):
+                      type='DeltaXYWHBBoxCoder',
+                      target_means=(.0, .0, .0, .0),
+                      target_stds=(1.0, 1.0, 1.0, 1.0)),
++                 reg_decoded_bbox=False,
+                  background_label=None,
+                  loss_cls=dict(
+                      type='CrossEntropyLoss',",The docstring is outdated.
+9891,"@@ -7,6 +7,9 @@ namespace Datadog.Trace
+     /// </summary>
+     public static class CorrelationIdentifier
+     {
++        internal static readonly string ServiceKey = ""dd.service"";
++        internal static readonly string VersionKey = ""dd.version"";
++        internal static readonly string EnvKey = ""dd.env"";
+         internal static readonly string TraceIdKey = ""dd.trace_id"";
+         internal static readonly string SpanIdKey = ""dd.span_id"";
+ ",Could rename to `ServiceVersionKey` for consistency with the suggestion to rename the TracerSetting.
+9892,"@@ -826,6 +826,12 @@ def install(package, hash=None, version=None, tag=None, force=False):
+     store = PackageStore()
+     existing_pkg = store.get_package(owner, pkg)
+
++    if existing_pkg is not None and not force:
++        print(""{owner}/{pkg} already installed."".format(owner=owner, pkg=pkg))
++        overwrite = input(""Overwrite? (y/n) "")
++        if overwrite.lower() != 'y':
++            return
++
+     if version is not None:
+         response = session.get(
+             ""{url}/api/version/{owner}/{pkg}/{version}"".format(",I seem to recall a UI issue with this... @akarve I think you didn't like this for some reason...
+9893,"@@ -84,7 +84,7 @@ class MediaBlockService extends BaseBlockService
+     /**
+      * {@inheritdoc}
+      */
+-    public function getDefaultSettings(OptionsResolverInterface $resolver)
++    public function setDefaultSettings(OptionsResolverInterface $resolver)
+     {
+         $resolver->setDefaults(array(
+             'media'    => false,",The `MediaBlockService` commit must be remove
+9894,"@@ -239,11 +239,17 @@ rules:
+     maximum_retention: 365
+
+ """"""
++
++    def test_number_of_rules(self):
++        """"""The number of rules should be exactly the same as the length of SUPPORTED_RETENTION_RES_TYPES.""""""
++        rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
++        self.assertTrue(len(rre.SUPPORTED_RETENTION_RES_TYPES) == len(rules_engine.rule_book.resource_rules_map))
++
++
+     def test_only_max_normal_delete(self):
+         """"""Test that a bucket's rule can guarantee the maximum_retention if its
+         action is 'Delete' and the only condition is an age(<= maximum_retention)""""""
+         rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
+-        self.assertEqual(1, len(rules_engine.rule_book.resource_rules_map))
+
+         data_creater = frsd.FakeBucketDataCreater('fake_bucket', frsd.PROJECT1)
+         data_creater.AddLifecycleDict(action=""Delete"", age=365)","Use a literal constant here, and use `assertEqual`, e.g. `self.assertEqual(2, len(...))` You should also check that the number of rules is correct, i.e. 1 rule for buckets, 0 rules for tables."
+9895,"@@ -15,8 +15,8 @@
+  * will expire before some files can be uploaded.
+  *
+  * The long-term solution to this problem is to change the upload pipeline so that files
+- * can be sent to the next step individually. That requires a breakig change, so it is
+- * planned for Uppy v2.
++ * can be sent to the next step individually. That requires a breaking change, so it is
++ * planned for Uppy v4.
+  *
+  * In the mean time, this plugin is stuck with a hackier approach: the necessary parts
+  * of the XHRUpload implementation were copied into this plugin, as the MiniXHRUpload",@Murderlon Should it just say `some future version`?
+9896,"@@ -122,12 +122,14 @@ func (c *Controller) syncCSPC(cspcGot *apis.CStorPoolCluster) error {
+ 		return nil
+ 	}
+
+-	cspcGot, err := c.populateVersion(cspcGot)
++	cspcObj := cspcGot
++	cspcObj, err := c.populateVersion(cspcObj)
+ 	if err != nil {
+ 		klog.Errorf(""failed to add versionDetails to CSPC %s:%s"", cspcGot.Name, err.Error())
+ 		return nil
+ 	}
+
++	cspcGot = cspcObj
+ 	pc, err := c.NewPoolConfig(cspcGot, openebsNameSpace)
+ 	if err != nil {
+ 		message := fmt.Sprintf(""Could not sync CSPC : failed to get pool config: {%s}"", err.Error())","change looks good.. but, better to make populateVersion to return same object in the case of error.. that avoids lot of complex logic and probable issues"
+9897,"@@ -1358,6 +1358,10 @@ func (exp *Service) GetBlockOrActionByHash(hashStr string) (explorer.GetBlkOrAct
+ 		return explorer.GetBlkOrActResponse{Execution: &exe}, nil
+ 	}
+
++	if exe, err := exp.getAddressDetails(hashStr); err == nil {
++		return explorer.GetBlkOrActResponse{Address: &exe}, nil
++	}
++
+ 	return explorer.GetBlkOrActResponse{}, nil
+ }
+ ",invalid operation: exp (variable of type *Service) has no field or method getAddressDetails (from `typecheck`)
+9898,"@@ -4479,7 +4479,8 @@ func TestKBFSOpsBackgroundFlush(t *testing.T) {
+
+ 	// start the background flusher
+ 	ops := getOps(config, rootNode.GetFolderBranch().Tlf)
+-	go ops.backgroundFlusher(1 * time.Millisecond)
++	config.SetBGFlushPeriod(1 * time.Millisecond)
++	go ops.backgroundFlusher()
+
+ 	// Make sure we get the notification
+ 	select {","Probably overkill, but maybe we should be using a fake clock here. I won't push on whatever you decide though."
+9899,"@@ -690,7 +690,7 @@ func TestKBFSOpsConcurBlockSyncTruncate(t *testing.T) {
+
+ 	wg.Wait()
+
+-	// Do this in the main goroutine since t isn't goroutine safe,
++	// Do this in the main goroutine since it isn't goroutine safe,
+ 	// and do this after wg.Wait() since we only know it's set
+ 	// after the goroutine exits.
+ 	if syncErr != nil {","If you feel like it, may as well apply all the suggestions below to this test too."
+9900,"@@ -94,9 +94,18 @@ public class LatLonShape {
+     return new Field[] {new LatLonTriangle(fieldName, lat, lon, lat, lon, lat, lon)};
+   }
+
++  /** create a query to find all indexed shapes that comply the {@link QueryRelation} with the provided point
++   **/
++  public static Query newPointQuery(String field, QueryRelation queryRelation, double lat, double lon) {
++    return new LatLonShapePointQuery(field, queryRelation, lat, lon);
++  }
++
+   /** create a query to find all polygons that intersect a defined bounding box
+    **/
+   public static Query newBoxQuery(String field, QueryRelation queryRelation, double minLatitude, double maxLatitude, double minLongitude, double maxLongitude) {
++    if (minLatitude == maxLatitude && minLongitude == maxLongitude) {
++      return newPointQuery(field, queryRelation, minLatitude, minLongitude);
++    }
+     return new LatLonShapeBoundingBoxQuery(field, queryRelation, minLatitude, maxLatitude, minLongitude, maxLongitude);
+   }
+ ",do we really need a relation or can we just assume INTERSECTS?
+9901,"@@ -16,7 +16,7 @@ import net.sourceforge.pmd.lang.java.oom.api.MetricVersion;
+  *
+  * @author Clément Fournier
+  */
+-public final class ParameterizedMetricKey {
++/* default */ final class ParameterizedMetricKey {
+
+     private static final Map<Integer, ParameterizedMetricKey> POOL = new HashMap<>();
+ ",Is this a `MetricKey` ?
+9902,"@@ -49,6 +49,9 @@ public class Constants {
+   public static final int DEFAULT_SSL_PORT_NUMBER = 8443;
+   public static final int DEFAULT_JETTY_MAX_THREAD_COUNT = 20;
+
++  // One Schedule's default End Time: 01/01/2050, 00:00:00, UTC
++  public static final long DEFAULT_SCHEDULE_END_EPOCH_TIME = 2524608000000L;
++
+   public static class ConfigurationKeys {
+     // These properties are configurable through azkaban.properties
+ ",what's your rationale to pick up this date?
+9903,"@@ -11,6 +11,7 @@ import (
+ 	""strings""
+
+ 	""github.com/opencontainers/runc/libcontainer/cgroups""
++	""github.com/opencontainers/runc/libcontainer/cgroups/fscommon""
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ )
+ ","NIT: I'd have preferred that the new package be called ""utils"", but that's not a big deal."
+9904,"@@ -1,6 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to set the default encryption state for an
++# Amazon Simple Storage Solution (Amazon S3) bucket using server-side encryption (SSE)
++# with an AWS KMS customer master key (CMK).
++
++# snippet-start:[s3.ruby.s3_add_default_sse_encryption]
++
+ require 'aws-sdk-s3'
+
+ # Sets the default encryption state for an Amazon S3 bucket using",Simple Storage **Service**
+9905,"@@ -201,12 +201,15 @@ class GarbageCollector extends AbstractDataHandlerListener implements SingletonI
+         $indexQueueItems = $this->getIndexQueue()->getItems($table, $uid);
+         foreach ($indexQueueItems as $indexQueueItem) {
+             $site = $indexQueueItem->getSite();
++            $solrConfiguration = $site->getSolrConfiguration();
+
+             // a site can have multiple connections (cores / languages)
+             $solrConnections = $connectionManager->getConnectionsBySite($site);
+             foreach ($solrConnections as $solr) {
+                 $solr->deleteByQuery('type:' . $table . ' AND uid:' . intval($uid));
+-                $solr->commit(false, false, false);
++                if ($solrConfiguration->getEnableCommits()) {
++                    $solr->commit(false, false, false);
++                }
+             }
+         }
+     }","I think, retrieving the setting could also be done outside the loop. What do you think?"
+9906,"@@ -257,6 +257,7 @@ public class TransactionPool implements BlockAddedObserver {
+               transaction.getGasLimit(), chainHeadBlockHeader.getGasLimit()));
+     }
+
++    // TODO: this is where we would use the private state to do the validation against
+     return protocolContext
+         .getWorldStateArchive()
+         .get(chainHeadBlockHeader.getStateRoot())",This TODO isn't related to this change. We should remove it.
+9907,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.
+9908,"@@ -1689,7 +1689,14 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+                         and subscript == subscript.parent.target
+                     ):
+                         # Ignore this subscript if it is the target of an assignment
+-                        continue
++                        if subscript.as_string() == subscript.parent.value.as_string():
++                            # Fire error as d[k] += d[k] has an unnecessary index lookup
++                            self.add_message(
++                                ""unnecessary-dict-index-lookup"",
++                                node=subscript,
++                                args=(node.target.elts[1].as_string()),
++                            )
++                        return  # Early termination; after reassignment dict index lookup will be necessary
+
+                     # Case where .items is assigned to k,v (i.e., for k, v in d.items())
+                     if isinstance(value, astroid.Name):","I'm not really sure this is worth it. Keep in mind that every special case we add has the potential to introduce new errors and complicates the code further. For common cases that is acceptable, but in this instance I don't think it's beneficial."
+9909,"@@ -62,6 +62,11 @@ func (c *showCommand) Run(ctx context.Context, env *common_cli.Env, serverClient
+ 		return err
+ 	}
+
++	if agent.Selectors != nil {
++		for _, s := range agent.Selectors {
++			env.Printf(""Selectors     : %s:%s\n"", s.Type, s.Value)
++		}
++	}
+ 	return nil
+ }
+ ","nit: this `if` isn't necessary since we immediately follow it up with a range over the slice, which works fine with a `nil` slice."
+9910,"@@ -3160,9 +3160,15 @@ void Game::playerChangeOutfit(uint32_t playerId, Outfit_t outfit)
+ 	}
+
+ 	Player* player = getPlayerByID(playerId);
++
+ 	if (!player) {
+ 		return;
+ 	}
++
++	const Outfit* playerOutfit = Outfits::getInstance()->getOutfitByLookType(player->getSex(), outfit.lookType);
++	if (!playerOutfit) {
++		outfit.lookMount = 0;
++	}
+
+ 	if (outfit.lookMount != 0) {
+ 		Mount* mount = mounts.getMountByClientID(outfit.lookMount);",Remove this line please.
+9911,"@@ -144,6 +144,7 @@ public class ZMSImpl implements Authorizer, KeyStore, ZMSHandler {
+     protected int domainNameMaxLen;
+     protected AuthorizedServices serverAuthorizedServices = null;
+     protected SolutionTemplates serverSolutionTemplates = null;
++    protected Map<String, Integer> eligibleTemplatesForAutoUpdate = null;
+     protected Map<String, String> serverPublicKeyMap = null;
+     protected boolean readOnlyMode = false;
+     protected boolean validateUserRoleMembers = false;",why is this is class field? it should be something local within the auto apply template method since we only need this once to process templates and never use again.
+9912,"@@ -39,14 +39,14 @@ module.exports = function(grunt) {
+
+       const { diff: rolesTable, notes: rolesFootnotes } = getDiff(
+         roles,
+-        axe.commons.aria.lookupTable.role,
++        axe.utils.getStandards().ariaRoles,
+         listType
+       );
+
+       const ariaQueryAriaAttributes = getAriaQueryAttributes();
+       const { diff: attributesTable, notes: attributesFootnotes } = getDiff(
+         ariaQueryAriaAttributes,
+-        axe.commons.aria.lookupTable.attributes,
++        axe.utils.getStandards().ariaAttrs,
+         listType
+       );
+       const attributesTableMarkdown = mdTable([",I agree with Stephen it's better to invoke getStandards() only once.
+9913,"@@ -198,7 +198,7 @@ class GridInterface(DictInterface):
+
+
+     @classmethod
+-    def canonicalize(cls, dataset, data, coord_dims=None):
++    def canonicalize(cls, dataset, data, coord_dims=None, irregular_dims=[]):
+         """"""
+         Canonicalize takes an array of values as input and
+         reorients and transposes it to match the canonical","After discussing what ``irregular_dims`` really is, we agreed that we need a better name that makes it clearer that this is more of an xarray concept of irregular dimensions than a holoviews one."
+9914,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users."
+9915,"@@ -222,11 +222,16 @@ th svg {
+ }
+
+ td {
++	white-space: nowrap;
+ 	font-size: 14px;
+ }
+
+ td:first-child {
+-	width: 50%;
++	width: 100%;
++}
++
++td:nth-child(2) {
++	padding: 0 20px 0 20px;
+ }
+
+ th:last-child,",this makes sure there is some padding space around the size column
+9916,"@@ -47,6 +47,7 @@ extern ""C"" {
+ #include ""Util/InputFileUtil.h""
+ #include ""Util/GraphLoader.h""
+ #include ""Util/StringUtil.h""
++#include ""Util/LuaUtil.h""
+
+ using namespace std;
+ ",Put these includes in alphabetical order
+9917,"@@ -246,7 +246,12 @@ class JAB(Window):
+ 				continue
+ 			keyList=[]
+ 			# We assume alt  if there are no modifiers at all and its not a menu item as this is clearly a nmonic
+-			if (binding.modifiers&JABHandler.ACCESSIBLE_ALT_KEYSTROKE) or (not binding.modifiers and self.role!=controlTypes.ROLE_MENUITEM):
++			altModifier = binding.modifiers&JABHandler.ACCESSIBLE_ALT_KEYSTROKE
++			if not altModifier:
++				if not binding.modifiers and self.role!=controlTypes.ROLE_MENUITEM:
++					parent=self.parent
++					altModifier=isinstance(parent,JAB) and parent.role==controlTypes.ROLE_MENUBAR
++			if altModifier:
+ 				keyList.append(keyLabels.localizedKeyLabels['alt'])
+ 			if binding.modifiers&JABHandler.ACCESSIBLE_CONTROL_KEYSTROKE:
+ 				keyList.append(keyLabels.localizedKeyLabels['control'])",Can this just be an else?
+9918,"@@ -7,6 +7,7 @@ import torch.nn as nn
+ from mmcv.utils import print_log
+
+ from mmdet.core import auto_fp16
++from mmdet.utils import get_root_logger
+
+
+ class BaseDetector(nn.Module, metaclass=ABCMeta):",Merge this line with Line7
+9919,"@@ -19,7 +19,7 @@ module GeocoderHelper
+     html << result[:suffix] if result[:suffix]
+
+     if result[:type] and result[:id]
+-      html << content_tag(:small, :class => [""deemphasize"", ""search_details""]) do
++      html << content_tag(:small, :class => [""deemphasize"", ""search_details"", ""clearfix""]) do
+         link_to(t(""browse.#{result[:type]}_history.view_details""), :controller => :browse, :action => result[:type], :id => result[:id])
+       end
+     end",`clearfix` is needed to stop the `float:right` content overflowing the list item container.
+9920,"@@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
+
+ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+ {
+-    [ParameterizedJobConfig(typeof(CoreConfig))]
++    [AspNetCoreBenchmark]
+     public class StringUtilitiesBenchmark
+     {
+         private const int Iterations = 500_000;",Can this be put on the assembly?
+9921,"@@ -124,7 +124,8 @@ public class HealthCheckServlet extends HttpServlet {
+         if (results.isEmpty()) {
+             resp.setStatus(HttpServletResponse.SC_NOT_IMPLEMENTED);
+         } else {
+-            if (isAllHealthy(results)) {
++            final boolean alwaysOk = Boolean.parseBoolean(req.getParameter(""alwaysOk""));
++            if (alwaysOk || isAllHealthy(results)) {
+                 resp.setStatus(HttpServletResponse.SC_OK);
+             } else {
+                 resp.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);",Could we rename the parameter to `overrideStatusCode`? The name `alwaysOk` implies that the health check result would be always healthy.
+9922,"@@ -37,5 +37,9 @@ func (c *clusterApi) Routes() []*Route {
+ 		{verb: ""GET"", path: clusterSecretPath(""/defaultsecretkey"", cluster.APIVersion), fn: c.getDefaultSecretKey},
+ 		{verb: ""PUT"", path: clusterSecretPath(""/defaultsecretkey"", cluster.APIVersion), fn: c.setDefaultSecretKey},
+ 		{verb: ""POST"", path: clusterSecretPath(""/login"", cluster.APIVersion), fn: c.secretsLogin},
++		{verb: ""GET"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.listSchedPolicy},
++		{verb: ""POST"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.createSchedPolicy},
++		{verb: ""PUT"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.updateSchedPolicy},
++		{verb: ""DELETE"", path: clusterPath(""/schedpolicy/{name}"", cluster.APIVersion), fn: c.deleteSchedPolicy},
+ 	}
+ }","""/schedpolicy"" is repeated, i would make it a constant and use it here and cluster client.go"
+9923,"@@ -0,0 +1,14 @@
++module RSpec::Core::Ordering
++  class RandomOrdering
++    def order(items, configuration = RSpec.configuration)
++      Kernel.srand configuration.seed
++      ordering = items.shuffle
++      Kernel.srand # reset random generation
++      ordering
++    end
++
++    def built_in?
++      true
++    end
++  end
++end","Having a second `configuration` arg seems kinda odd to me as an interface. It looks like you're just using it as a form of dependency injection for the tests, right? Part of what makes it seem weird is that it's leaked into all the other orderers where they don't use `configuration` at all. Instead, what do you think about accepting the configuration in `initialize` (and having it default to `RSpec.configuration` in the same way)? To me, the config feels like a bit of state the instance should hold onto rather than being given each time `order` is called. It also means the other orderers wouldn't need to take the odd second argument. Thoughts?"
+9924,"@@ -248,8 +248,9 @@ class AddonsDialog(
+ 		self.getAddonsButton = generalActions.addButton(self, label=_(""&Get add-ons...""))
+ 		self.getAddonsButton.Bind(wx.EVT_BUTTON, self.onGetAddonsClick)
+ 		# Translators: The label for a button in Add-ons Manager dialog to install an add-on.
+-		self.addButton = generalActions.addButton(self, label=_(""&Install...""))
+-		self.addButton.Bind(wx.EVT_BUTTON, self.onAddClick)
++		if not globalVars.appArgs.secure:
++			self.addButton = generalActions.addButton(self, label=_(""&Install...""))
++			self.addButton.Bind(wx.EVT_BUTTON, self.onAddClick)
+ 		# Translators: The label of a button in the Add-ons Manager to open the list of incompatible add-ons.
+ 		self.incompatAddonsButton = generalActions.addButton(self, label=_(""&View incompatible add-ons...""))
+ 		self.incompatAddonsButton.Bind(wx.EVT_BUTTON, self.onIncompatAddonsShowClick)",This button should also be disabled when in secure mode since it opens a web browser from which you can easily do a lot of insecure stuff.
+9925,"@@ -221,4 +221,11 @@ public interface Table {
+    * @return a {@link LocationProvider} to provide locations for new data files
+    */
+   LocationProvider locationProvider();
++
++  /**
++   * Create a new {@link ExpireTableMetadata expire API} to manage table metadata files in this table and commit.
++   *
++   * @return a new {@link ExpireTableMetadata}
++   */
++  ExpireTableMetadata expireTableMetadata();
+ }",Should this be done as part of `expireSnapshots`? I'd like to avoid adding a lot of operations to `Table` because it is already a large API.
+9926,"@@ -0,0 +1,18 @@
++package libp2p
++
++import (
++	""github.com/libp2p/go-libp2p-core/helpers""
++	""github.com/libp2p/go-libp2p-core/network""
++)
++
++type Stream struct {
++	network.Stream
++}
++
++func (s *Stream) FullClose() error {
++	return helpers.FullClose(s)
++}
++
++func NewStream(stream network.Stream) *Stream {
++	return &Stream{Stream: stream}
++}",I do not think that this type (and its constructor) have to be exported.
+9927,"@@ -55,7 +55,10 @@ func (r *receiptLog) SetData(data []byte) {
+ 	r.data = data
+ }
+
+-func (r *receiptLog) Build(ctx context.Context, err error) *action.Log {
++func (r *receiptLog) Build(ctx context.Context, err error, skipLogOnErr bool) *action.Log {
++	if err != nil && skipLogOnErr {
++		return nil
++	}
+ 	blkCtx := protocol.MustGetBlockCtx(ctx)
+ 	actionCtx := protocol.MustGetActionCtx(ctx)
+ ","why add this? don't think it's correct? for instance, it returns ErrCandidateNotExist (not critical), in this case we should return a receipt with corresponding status"
+9928,"@@ -0,0 +1,6 @@
++package caddytls
++
++import ""github.com/xenolf/lego/acme""
++
++// ChallengeProvider type to be used in Caddy plugins over acme.ChallengeProvider directly, to avoid https://github.com/mattfarina/golang-broken-vendor
++type ChallengeProvider acme.ChallengeProvider","Instead of creating a new file, put this in tls.go, like right after or before DNSProviderConstructor is defined."
+9929,"@@ -62,7 +62,8 @@ app.controller('AttendeeController', function($scope, AutoCompletionService) {
+ 					'role': 'REQ-PARTICIPANT',
+ 					'rsvp': 'TRUE',
+ 					'partstat': 'NEEDS-ACTION',
+-					'cutype': 'INDIVIDUAL'
++					'cutype': 'INDIVIDUAL',
++					'language': OC.getLocale() // Use current user's timezone as a default value
+ 				}
+ 			});
+ 		}","Instead of OC.getLocale() for the default value the default should be the value of the user value 'core' 'lang'. When loading the page this can be added to the parameters by retrieving $this->config->getUserValue($user->getUID(), 'core', 'lang'); in viewcontroller.php."
+9930,"@@ -42,7 +42,7 @@ namespace interface1
+  * \param[in] id   Identifier of the result
+  * \return         Result that corresponds to the given identifier
+  */
+-classifier::quality_metric::binary_confusion_matrix::ResultPtr ResultCollection::getResult(QualityMetricId id) const
++classifier::quality_metric::binary_confusion_matrix::ResultPtr daal::algorithms::adaboost::quality_metric_set::interface1::ResultCollection::getResult(daal::algorithms::adaboost::quality_metric_set::QualityMetricId id) const
+ {
+     return staticPointerCast<classifier::quality_metric::binary_confusion_matrix::Result, SerializationIface>((*this)[(size_t)id]);
+ }",Why interface1 ? It should be in inner so.
+9931,"@@ -32,6 +32,16 @@ class User(UserMixin):
+             login_id=user['login_id'],
+         )
+
++    def to_dict(self):
++        return {
++            ""id"": self.id,
++            ""created"": self.created,
++            ""musicbrainz_id"": self.musicbrainz_id,
++            ""auth_token"": self.auth_token,
++            ""gdpr_agreed"": self.gdpr_agreed,
++            ""login_id"": self.login_id
++        }
++
+ @login_manager.user_loader
+ def load_user(user_login_id):
+     try:","Ideally, I'd have converted dicts to object but this way was less changes so this way for now."
+9932,"@@ -4061,8 +4061,17 @@ void t_c_glib_generator::generate_deserialize_field(ostream& out,
+       throw ""compiler error: no C reader for base type "" + t_base_type::t_base_name(tbase) + name;
+     }
+     out << "", error)) < 0)"" << endl;
+-    out << indent() << ""  return "" << error_ret << "";"" << endl << indent() << ""xfer += ret;""
+-        << endl;
++    if ((tbase != t_base_type::TYPE_STRING) && allocate) {
++      scope_up(out);
++      out << indent() << ""g_free (&"" << name << "");"" << endl;
++      out << indent() << ""return "" << error_ret << "";"" << endl;
++      scope_down(out);
++      out << indent() << ""xfer += ret;"" << endl;
++    }
++    else{
++      out << indent() << ""  return "" << error_ret << "";"" << endl << indent() << ""xfer += ret;""
++         << endl;
++    }
+
+     // load the byte array with the data
+     if (tbase == t_base_type::TYPE_STRING && type->is_binary()) {",Why is that test different to line 4022 (allocate is not tested there)? Shouldn't that be consistent?
+9933,"@@ -472,7 +472,15 @@ ExWorkProcRetcode ExHbaseAccessInsertSQTcb::work()
+ 	  {
+ 	    rc = applyPred(scanExpr());
+ 	    if (rc == 1) // expr is true or no expr
+-	      step_ = CREATE_MUTATIONS;
++	      {
++		 rc = evalInsDelPreCondExpr();
++		 if (rc == -1)
++		   step_ = HANDLE_ERROR;
++		 else if (rc == 0)
++		   step_ = INSERT_CLOSE;
++		 else
++		   step_ = CREATE_MUTATIONS;
++	      }
+ 	    else if (rc == 0) // expr is false
+ 	      step_ = INSERT_CLOSE;
+ 	    else // error","Should we consider move this expression evaluation to SETUP_INSERT step since it evaluates from queue entry. Also, this expression is not evaluated in ExHbaseAccessVsbbUpsertTcb."
+9934,"@@ -143,7 +143,8 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation
+             {
+                 Name = activity.DisplayName,
+
+-                Kind = (OtlpTrace.Span.Types.SpanKind)(activity.Kind + 1), // TODO: there is an offset of 1 on the enum.
++                // There is an offset of 1 on the Otlp enum.
++                Kind = (OtlpTrace.Span.Types.SpanKind)(activity.Kind + 1),
+
+                 TraceId = ByteStringCtorFunc(traceIdBytes),
+                 SpanId = ByteStringCtorFunc(spanIdBytes),",Don't see any more TODOs here..
+9935,"@@ -190,6 +190,13 @@ func (task *Task) DockerConfig(container *Container) (*docker.Config, *DockerCli
+ }
+
+ func (task *Task) dockerConfig(container *Container) (*docker.Config, *DockerClientConfigError) {
++	// Detect the name for S3 images
++	dockerImage := container.Image
++	if strings.HasPrefix(dockerImage, ""s3://"") {
++		slice := strings.Split(dockerImage, ""/"")
++		dockerImage = slice[len(slice)-1]
++	}
++
+ 	dockerVolumes, err := task.dockerConfigVolumes(container)
+ 	if err != nil {
+ 		return nil, &DockerClientConfigError{err.Error()}",Can you extract this out to a constant?
+9936,"@@ -452,12 +452,12 @@ def main(args):
+                 quiet_build=args.quiet_build,
+                 logfile=logfile
+             )
+-
+-            log_module = __load_module(""log"")
+             __update_if_key_exists(args, log_args, ""verbose"")
+
++            log_module = __load_module(""log"")
+             LOG.debug(""Calling LOG with args:"")
+             LOG.debug(log_args)
++
+             log_module.main(log_args)
+         elif 'logfile' in args:
+             logfile = args.logfile","any testcase for saargs, and tidyargs argument processing?"
+9937,"@@ -18,6 +18,7 @@ namespace Microsoft.Cci.Writers.CSharp
+         private bool _forCompilation;
+         private bool _forCompilationIncludeGlobalprefix;
+         private bool _forCompilationThrowPlatformNotSupported;
++        private string _platformNotSupportedExceptionMessage;
+         private bool _includeFakeAttributes;
+
+         public CSDeclarationWriter(ISyntaxWriter writer)",@ericstj do you think it is worth combining these two? With the presence of the message meaning it is enabled?
+9938,"@@ -271,8 +271,8 @@ func (s *ec2Ops) DeviceMappings() (map[string]string, error) {
+ 		if d.DeviceName != nil && d.Ebs != nil && d.Ebs.VolumeId != nil {
+ 			devName := *d.DeviceName
+ 			// Per AWS docs EC instances have the root mounted at
+-			// /dev/sda1, this label should be skipped
+-			if devName == ""/dev/sda1"" {
++			// /dev/sda1, /dev/xvda this label should be skipped
++			if devName == ""/dev/sda1"" || devName == ""/dev/xvda"" {
+ 				continue
+ 			}
+ 			// AWS EBS volumes get mapped from /dev/sdN -->/dev/xvdN",why not use instance.RootDeviceName ?
+9939,"@@ -14,6 +14,7 @@
+
+ #include <ios>      //std::ios_base::failure
+ #include <iostream> //std::cout
++#include <fstream>  //std::ifstream
+ #include <mpi.h>
+ #include <stdexcept> //std::invalid_argument std::exception
+ #include <vector>","not needed, ADIOS2 also needs to check for subfiles. ADIOS2 tries to remove dependency on serial `fstream`."
+9940,"@@ -50,6 +50,12 @@ class DatabaseDriverReactNative {
+ 		});
+ 	}
+
++	loadExtension(path) {
++		return new Promise(() => {
++			throw new Error(`No extension support for ${path} in react-native-sqlite-storage`);
++		});
++	}
++
+ 	exec(sql, params = null) {
+ 		return new Promise((resolve, reject) => {
+ 			this.db_.executeSql(",no need to wrap in new Promise - you can simply throw the exception
+9941,"@@ -2438,3 +2438,17 @@ func getOCSPStatus(s tls.ConnectionState) (*ocsp.Response, error) {
+ 	}
+ 	return resp, nil
+ }
++
++func TestOCSPManualConfig(t *testing.T) {
++	o := DefaultTestOptions
++	o.HTTPHost = ""127.0.0.1""
++	o.HTTPSPort = -1
++	o.TLSConfig = &tls.Config{ServerName: ""localhost""}
++	cert, err := tls.LoadX509KeyPair(""configs/certs/server-cert.pem"", ""configs/certs/server-key.pem"")
++	if err != nil {
++		t.Fatalf(""Got error reading certificates: %s"", err)
++	}
++	o.TLSConfig.Certificates = []tls.Certificate{cert}
++	s := RunServer(&o)
++	s.Shutdown()
++}","Isn't this testing an implicit config, not a manual config?"
+9942,"@@ -205,6 +205,12 @@ type Table struct {
+ 	// to what we calculate from chainToContents.
+ 	chainToDataplaneHashes map[string][]string
+
++	// chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
++	chainsToFullRules map[string][]string
++
++	// hashToFullRules contains a mapping of rule hashes to the full rules.
++	hashToFullRules map[string]string
++
+ 	// hashCommentPrefix holds the prefix that we prepend to our rule-tracking hashes.
+ 	hashCommentPrefix string
+ 	// hashCommentRegexp matches the rule-tracking comment, capturing the rule hash.","I don't think this is used any more, please remove."
+9943,"@@ -42,9 +42,11 @@ func NewManager(mysteriumClient server.Client, dialogEstablisherFactory DialogEs
+ 	}
+ }
+
+-func (manager *connectionManager) Connect(id identity.Identity, nodeKey string) error {
++func (manager *connectionManager) Connect(myId identity.Identity, nodeKey string) error {
+ 	manager.status = statusConnecting()
+
++	providerId := identity.FromAddress(nodeKey)
++
+ 	proposals, err := manager.mysteriumClient.FindProposals(nodeKey)
+ 	if err != nil {
+ 		manager.status = statusError(err)",shouldn't we name abbreviations up-cased? `myId` -> `myID`?
+9944,"@@ -287,7 +287,10 @@ export function recollectNodeTree(node, unmountOnly) {
+ 	else {
+ 		// If the node's VNode had a ref function, invoke it with null here.
+ 		// (this is part of the React spec, and smart for unsetting references)
+-		if (node[ATTR_KEY]!=null) applyRef(node[ATTR_KEY].ref, null);
++		if (node[ATTR_KEY]!=null) {
++			applyRef(node[ATTR_KEY].ref, null);
++			delete node[ATTR_KEY].ref;
++		}
+
+ 		if (unmountOnly===false || node[ATTR_KEY]==null) {
+ 			removeNode(node);","This just always calls refs. I think we need to either hoist ref invocation back out of `setProperty()` (it used to happen during rendering), or wait for component recycling to go away."
+9945,"@@ -618,7 +618,10 @@ func runTest(t *testing.T, test testT) {
+ 	defer test.builder.Stop()
+
+ 	c := &controller{}
+-	c.Register(test.builder.Context)
++	_, _, err := c.Register(test.builder.Context)
++	if err != nil {
++		t.Errorf(""Error registering the controller: %v"", err)
++	}
+ 	c.accountRegistry = &accountstest.FakeRegistry{
+ 		GetClientFunc: func(_ string) (acmecl.Interface, error) {
+ 			return test.acmeClient, nil",Oof. I may have missed this while reviewing #3805
+9946,"@@ -3,8 +3,12 @@
+ // caffe::Caffe functions so that one could easily call it from matlab.
+ // Note that for matlab, we will simply use float as the data type.
+
+-#include <string>
+-#include <vector>
++// these need to be included after boost on OS X
++#include <string>  // NOLINT(build/include_order)
++#include <vector>  // NOLINT(build/include_order)
++#include <fstream>  // NOLINT
++#include <stdexcept>
++
+
+ #include ""mex.h""
+ ",why the NOLINTs here? please just alphabetize the headers (should be easier than adding NOLINTs) unless there's a good reason not to...
+9947,"@@ -0,0 +1,5 @@
++export default function() {
++	return <div />;
++}
++
++export const ReactComponent = () => <div />;",Should we maybe return `<svg />` instead?
+9948,"@@ -11,6 +11,7 @@ const Cats = require('../lib/status-cats');
+ const Storage = require('../lib/storage');
+ const _ = require('lodash');
+ const cors = require('cors');
++const load_plugins = require('../lib/plugin-loader').load_plugins;
+
+ module.exports = function(config_hash) {
+   // Config",Please use camelCase in new code
+9949,"@@ -14,5 +14,6 @@ return [
+ 	'selectLocale'  => 'Select one of the supported languages',
+ 	'contact'		=> 'Contact',
+ 	'contact-us'	=> 'Contact Us',
++    'places'        => 'Places',
+
+ ];","Looks like the whitespace is off here. Not sure if there's a space or two too many or if there is an issue with tabs vs. spaces, but you probably want to fix this :)"
+9950,"@@ -17,7 +17,12 @@
+ ## along with Invenio; if not, write to the Free Software Foundation, Inc.,
+ ## 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+
+-""""""Base bundles.""""""
++""""""Base bundles.
++
++.. note:: `bootstrap.js` bundle must be loaded after jQuery UI to avoid conflicts.
++    You can use `noConflict()` if you need to access functions
++    of jQuery UI covered by `bootstrap.js`.
++""""""
+
+ from invenio.ext.assets import Bundle
+ ",This was just my laziness and I didn't copy the first line. Just remove it together with one empty line. Thanks
+9951,"@@ -9,8 +9,8 @@ use Shopsys\FrameworkBundle\Model\Pricing\Vat\Vat;
+ use Shopsys\FrameworkBundle\Model\Pricing\Vat\VatData;
+ use Shopsys\FrameworkBundle\Model\Product\Availability\Availability;
+ use Shopsys\FrameworkBundle\Model\Product\Availability\AvailabilityData;
+-use Shopsys\FrameworkBundle\Model\Product\Product;
+-use Shopsys\FrameworkBundle\Model\Product\ProductDataFactory;
++use Shopsys\FrameworkBundle\Model\Product\ProductDataFactoryInterface;
++use Shopsys\ShopBundle\Model\Product\Product;
+ use Tests\ShopBundle\Test\DatabaseTestCase;
+
+ class CartItemTest extends DatabaseTestCase",Why did you decide to change CartItemTest but you didnt change QueryBuilderWithRowManipulatorDataSourceTest?
+9952,"@@ -425,7 +425,15 @@ func (k *KeybaseServiceBase) LoadUserPlusKeys(ctx context.Context,
+ 	uid keybase1.UID, pollForKID keybase1.KID) (UserInfo, error) {
+ 	cachedUserInfo := k.getCachedUserInfo(uid)
+ 	if cachedUserInfo.Name != libkb.NormalizedUsername("""") {
+-		return cachedUserInfo, nil
++		if pollForKID == keybase1.KID("""") {
++			return cachedUserInfo, nil
++		}
++		// Skip the cache if pollForKID isn't present.
++		for _, key := range cachedUserInfo.VerifyingKeys {
++			if key.KID().Equal(pollForKID) {
++				return cachedUserInfo, nil
++			}
++		}
+ 	}
+
+ 	arg := keybase1.LoadUserPlusKeysArg{Uid: uid, PollForKID: pollForKID}","This was sort of a pre-existing bug -- we should be busting our local cache if the key isn't present. However, `KBPKIClient.HasVerifyingKey` already took care of it on that path. This way is better though."
+9953,"@@ -1,5 +1,6 @@
+ // Code generated by private/model/cli/gen-api/main.go. DO NOT EDIT.
+
++//go:build go1.15 && integration
+ // +build go1.15,integration
+
+ package cloudfront_test",Should this tag addition for generated files be handled explicitly in `private/model/cli/gen-api/main.go`
+9954,"@@ -4753,6 +4753,11 @@ public class MessagingController implements Runnable {
+      */
+     private void notifyAccount(Context context, Account account,
+             LocalMessage message, int previousUnreadMessageCount) {
++    	// if it's quiet time and notifications are disabled, then we shouldn't show a notification
++        if (K9.isQuietTime() && K9.getQuietTimeNotificationEnabled()) {
++            return;
++        }
++
+         final NotificationData data = getNotificationData(account, previousUnreadMessageCount);
+         synchronized (data) {
+             notifyAccountWithDataLocked(context, account, message, data);",You want to return if it's quiet time and notifications during quiet time are **not** enabled. So this is either a logic error or it's bad naming of the setting/field/method.
+9955,"@@ -28,14 +28,11 @@ Workshops::Application.configure do
+   config.log_level = :info
+   config.log_formatter = ::Logger::Formatter.new
+
+-  HOST = 'learn.thoughtbot.com'
+-  config.action_mailer.default_url_options = {host: HOST}
+-
+   config.middleware.use Rack::SslEnforcer,
+     hsts: false,
+     except: %r{^/podcast},
+     strict: true,
+-    redirect_to: ""https://#{HOST}""
++    redirect_to: ""https://#{ENV['APP_DOMAIN']}""
+
+   config.action_mailer.delivery_method = :smtp
+   config.action_mailer.smtp_settings = MAIL_SETTINGS",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+9956,"@@ -144,7 +144,12 @@ module Travis
+       def source_ssh?
+         return false if prefer_https?
+         repo_private? && !installation? or
+-          repo_private? && custom_ssh_key?
++          repo_private? && custom_ssh_key? or
++            force_private? && !installation?
++      end
++
++      def force_private?
++        source_host.exclude? 'github.com'
+       end
+
+       def source_host","cool, here (L146 && L148) maybe (repo_private? || force_private?) && !installation? to prevent double call of installation?"
+9957,"@@ -33,7 +33,7 @@ provide a working environment for development.`,
+ func appStart() {
+ 	app, err := platform.GetActiveApp("""")
+ 	if err != nil {
+-		util.Failed(""Failed to start: %s"", err)
++		util.Failed(""Failed to GetActiveApp err: %v"", err)
+ 	}
+
+ 	fmt.Printf(""Starting environment for %s...\n"", app.GetName())","this error carries a bit more meaning for us, but less meaning for users. we also lose the context of what command produced the failure. I'd prefer to keep the original error message. If we need better identification of GetActiveApp errors, maybe we could address that in the error messages it returns?"
+9958,"@@ -97,7 +97,7 @@ const (
+ const sendRouteSubsInGoRoutineThreshold = 1024 * 1024 // 1MB
+
+ // Warning when user configures cluster TLS insecure
+-const clusterTLSInsecureWarning = ""TLS Hostname verification disabled, system will not verify identity of the solicited route""
++const clusterTLSInsecureWarning = ""TLS certificate chain and hostname of solicited routes will not be verified, do not use in production!""
+
+ // Can be changed for tests
+ var routeConnectDelay = DEFAULT_ROUTE_CONNECT",Same: DO NOT USE IN PRODUCTION. Yes we should shout ;)
+9959,"@@ -134,7 +134,7 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+             await clientThrottle.WaitAsync();
+             string leaseId = string.Empty;
+             //this defines the lease for 15 seconds (max is 60) and 3000 milliseconds between requests
+-            AzureBlobLease blobLease = new AzureBlobLease(feed.AccountName, feed.AccountKey, string.Empty, feed.ContainerName, uploadPath, Log, ""15"", ""3000"");
++            AzureBlobLease blobLease = new AzureBlobLease(feed.AccountName, feed.AccountKey, string.Empty, feed.ContainerName, uploadPath, Log, ""15"", ""5000"");
+
+             bool isLeaseRequired = allowOverwrite && await feed.CheckIfBlobExists(uploadPath);
+ ","This change may be hiding more errors, if we continue to see more."
+9960,"@@ -246,13 +246,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+
+         object IFeatureCollection.this[Type key]
+         {
+-            get => FastFeatureGet(key);
++            get => FastFeatureGet(key) ?? ConnectionFeatures?[key];
+             set => FastFeatureSet(key, value);
+         }
+
+         TFeature IFeatureCollection.Get<TFeature>()
+         {
+-            return (TFeature)FastFeatureGet(typeof(TFeature));
++            return (TFeature)(FastFeatureGet(typeof(TFeature)) ?? ConnectionFeatures?[typeof(TFeature)]);
+         }
+
+         void IFeatureCollection.Set<TFeature>(TFeature instance)",Beware of exposing the underlying features directly. Any mutable fields should be reset per request.
+9961,"@@ -144,12 +144,18 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		if (initialBase && base!==initialBase && inst!==initialChildComponent) {
+ 			let baseParent = initialBase.parentNode;
+ 			if (baseParent && base!==baseParent) {
+-				baseParent.replaceChild(base, initialBase);
+
+ 				if (!toUnmount) {
++					baseParent.replaceChild(base, initialBase);
+ 					initialBase._component = null;
+ 					recollectNodeTree(initialBase, false);
+ 				}
++				// @TODO Formerly the initialBase was always replaced by the base
++				//		 but somehow all tests passes also if its only called at not unmounting.
++				//       These else condition was the original fix.
++				// else {
++				// 	baseParent.insertBefore(base, initialBase);
++				// }
+ 			}
+ 		}
+ ","This is probably more nuanced than I can feasibly check in a PR review, haha. Was the issue here that `replaceChild()` removes `initialBase` from the DOM before `recollectNodeTree()` invokes `componentWillUnmount()` on the owning component?"
+9962,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked"
+9963,"@@ -86,4 +86,8 @@ public class DataWriter<T> implements Closeable {
+     Preconditions.checkState(dataFile != null, ""Cannot create data file from unclosed writer"");
+     return dataFile;
+   }
++
++  public FileAppender<T> appender() {
++    return appender;
++  }
+ }",Do we need to expose it? It looks like it is only used in tests and only to obtain the final metrics. I think you can get the same by using `DataFile#lowerBounds` and `DataFile#upperBounds`. It seems `DataWriter` already exposes `toDataFile` that you can use.
+9964,"@@ -868,7 +868,7 @@ describe(""date_utils"", function() {
+     });
+
+     it(""should return the 4 2021 year week"", () => {
+-      const date = new Date(""2021-01-18"");
++      const date = new Date(""2021-01-19"");
+       assert(getWeek(date) === 3);
+     });
+ ",the test was failing likely due to locale issue. had to increment the date by 1 to make it pass
+9965,"@@ -935,15 +935,8 @@ bool Levitate(const InstantSpell*, Creature* creature, const std::string& param)
+ bool InstantSpell::loadFunction(const pugi::xml_attribute& attr)
+ {
+ 	const char* functionName = attr.as_string();
+-	if (strcasecmp(functionName, ""levitate"") == 0) {
+-		function = Levitate;
+-	} else {
+-		std::cout << ""[Warning - InstantSpell::loadFunction] Function \"""" << functionName << ""\"" does not exist."" << std::endl;
+-		return false;
+-	}
+-
+-	scripted = false;
+-	return true;
++	std::cout << ""[Warning - InstantSpell::loadFunction] Function \"""" << functionName << ""\"" does not exist."" << std::endl;
++	return false;
+ }
+
+ bool InstantSpell::playerCastInstant(Player* player, std::string& param)",The changes below here can also be undone.
+9966,"@@ -1,13 +1,14 @@
+ package channelq
+
+ import (
++	""context""
+ 	""fmt""
+ 	""strings""
+ 	""sync""
+
+ 	""k8s.io/klog""
+
+-	""github.com/kubeedge/beehive/pkg/core/context""
++	beehiveContext ""github.com/kubeedge/beehive/pkg/core/context""
+ 	""github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/common/model""
+ )
+ ","Instead of importing context besides beehivecontext, I'd suggest include golang context functionalities into beehivecontext. To keep channelq only rely on beehive."
+9967,"@@ -88,6 +88,9 @@ public class AddProductNutritionFactsData {
+         PREFIX_NUTRIMENT_LONG_NAME + ""vitamin-k"",
+         PREFIX_NUTRIMENT_LONG_NAME + ""zinc""));
+
++    private AddProductNutritionFactsData() {
++    }
++
+     static String getCompleteEntryName(CustomValidatingEditTextView editText) {
+         return PREFIX_NUTRIMENT_LONG_NAME + editText.getEntryName();
+     }",I'm not sure about this one. Are you sure we don't need to initialize this fragment anywhere else?
+9968,"@@ -644,6 +644,7 @@ public class LocalInsightPlugin extends PluginBase implements PumpInterface, Con
+                 result.comment = ExceptionTranslator.getString(e);
+             }
+         } else if (detailedBolusInfo.carbs > 0) {
++            TreatmentsPlugin.getPlugin().addToHistoryTreatment(detailedBolusInfo, true);
+             result.success = true;
+             result.enacted = true;
+         }","You didn't set a source here, so it will probably fail."
+9969,"@@ -52,7 +52,7 @@ func TestHandlerSucces(t *testing.T) {
+ 	headers.Set(BaggageHeaderPrefix+""BAR"", ""baz"")
+
+ 	rpcHandler := transporttest.NewMockHandler(mockCtrl)
+-	httpHandler := handler{rpcHandler}
++	httpHandler := handler{rpcHandler, transport.NoDeps}
+
+ 	rpcHandler.EXPECT().Handle(
+ 		transporttest.NewContextMatcher(t,",Might be easier to just do `handler{Handler: rpcHandler}` since zero-value of `Deps` is now valid.
+9970,"@@ -15,6 +15,10 @@ module Faker
+       def quote
+         fetch('movie.quote')
+       end
++
++      def title
++        fetch('movie.title')
++      end
+     end
+   end
+ end",Could you please add docs for this method?
+9971,"@@ -132,9 +132,16 @@ public abstract class AbstractApexNode<T extends AstNode> extends AbstractNode i
+
+     @Override
+     public String toString() {
++        return getXPathNodeName();
++    }
++
++
++    @Override
++    public final String getXPathNodeName() {
+         return this.getClass().getSimpleName().replaceFirst(""^AST"", """");
+     }
+
++
+     public String getLocation() {
+         if (hasRealLoc()) {
+             return String.valueOf(node.getLoc());",we should probably `@Deprecated` this implementation to be removed in PMD 7.0.0
+9972,"@@ -242,7 +242,11 @@ module Bolt
+         end
+
+         def shell
+-          @shell ||= Bolt::Shell::Bash.new(target, self)
++          @shell ||= if target.options['login-shell'] == 'powershell'
++                       Bolt::Shell::Powershell.new(target, self)
++                     else
++                       Bolt::Shell::Bash.new(target, self)
++                     end
+         end
+
+         # This is used by the Bash shell to decide whether to `cd` before","I wonder if 'unix' makes more sense for this now? I was thinking of putting up a 'cleanup' PR - I think I missed a few ""remote"" var names in the first PR, and want to reassess unifying the transport classes that just define `with_connection`. Renaming this could be part of that."
+9973,"@@ -52,8 +52,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+         {
+             const string source = ""<results> <cppcheck version=\""12.34\"" /> <errors>   </errors> </results>"";
+             const string expected = @""{
+-  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0-beta.5"""",
+-  """"version"""": """"1.0.0-beta.5"""",
++  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0"""",
++  """"version"""": """"1.0.0"""",
+   """"runs"""": [
+     {
+       """"tool"""": {",Do something similar to what was done in JsonTests (can you derive from JsonTests?)
+9974,"@@ -15,4 +15,4 @@
+ #
+
+ # https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages
+-__path__ = __import__('pkgutil').extend_path(__path__, __name__)
++__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore","Yes, not much we can do here."
+9975,"@@ -24,16 +24,16 @@ import (
+ 	""strings""
+ 	""time""
+
+-	""go.uber.org/zap""
++	_ ""knative.dev/pkg/metrics/testing""
+
+ 	cev2 ""github.com/cloudevents/sdk-go/v2""
+-
+ 	""github.com/cloudevents/sdk-go/v2/binding""
+ 	""github.com/cloudevents/sdk-go/v2/binding/transformer""
+ 	""github.com/cloudevents/sdk-go/v2/protocol""
+ 	""github.com/cloudevents/sdk-go/v2/protocol/http""
+ 	""github.com/google/knative-gcp/pkg/metrics""
+ 	""github.com/google/wire""
++	""go.uber.org/zap""
+ 	""knative.dev/eventing/pkg/kncloudevents""
+ 	""knative.dev/eventing/pkg/logging""
+ )",Why do we need this?
+9976,"@@ -0,0 +1,17 @@
++var bitcore = require('../bitcore');
++var Address = bitcore.Address;
++var bitcoreUtil = bitcore.util;
++var Script = bitcore.Script;
++var network = bitcore.networks.livenet;
++
++
++var script = ''; // write down your script here
++var s = Script.fromHumanReadable(script);
++var hash = bitcoreUtil.sha256ripe160(s.getBuffer());
++var version = network.addressScript;
++
++var addr = new Address(version, hash);
++var addrStr = addr.as('base58');
++
++// This outputs the ""address"" of thescript
++console.log(addrStr);",Would prefer to see an actual script here.
+9977,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?
+9978,"@@ -12,5 +12,4 @@ __all__ = [
+     'CustomDataset', 'XMLDataset', 'CocoDataset', 'VOCDataset', 'GroupSampler',
+     'DistributedGroupSampler', 'build_dataloader', 'to_tensor', 'random_scale',
+     'show_ann', 'get_dataset', 'ConcatDataset', 'RepeatDataset',
+-    'ExtraAugmentation'
+-]
++    'ExtraAugmentation']",This change is unnecessary.
+9979,"@@ -61,7 +61,11 @@ public final class MiniatureListWidget<E> extends ScrollPane {
+         this.mappedElements = new MappedList<Element<E>, E>(items, value -> {
+             Element newElement = converter.apply(value);
+
+-            newElement.setOnMouseClicked(event -> setOnMouseClicked.accept(newElement, event));
++            newElement.setOnMouseClicked(event -> {
++                unselectAll();
++                setOnMouseClicked.accept(newElement, event);
++                select(newElement);
++            });
+
+             return newElement;
+         });","Just as a note: Is it possible that the select css class is the same as the hover one? If this is true we should choose a different style for the selection css class, to make it more clear to the user I think."
+9980,"@@ -106,6 +106,11 @@ type ControllerOptions struct {
+ 	EnablePprof bool
+
+ 	DNS01CheckRetryPeriod time.Duration
++
++	// Annotations copied Certificate -> CertificateRequest,
++	// CertificateRequest -> Order. Slice of string literals that are
++	// treated as prefixes for annotation keys.
++	CopiedAnnotations []string
+ }
+
+ const (","What about Secrets, are we not also trying to cover those?"
+9981,"@@ -37,7 +37,7 @@
+ #include <jansson.h>
+
+ #include ""src/common/libutil/log.h""
+-#include ""src/common/libkvs/jansson_dirent.h""
++#include ""src/common/libkvs/treeobj.h""
+
+ #include ""commit.h""
+ #include ""kvs_util.h""",(commit messge): how about > update internal commit API for RFC 11
+9982,"@@ -27,7 +27,7 @@ var eventErrorStates = []string{
+ }
+
+ var waiters = []request.WaiterOption{
+-	request.WithWaiterDelay(request.ConstantWaiterDelay(3 * time.Second)), // Poll for cfn updates every 3 seconds.
++	request.WithWaiterDelay(request.ConstantWaiterDelay(5 * time.Second)), // How long to wait in between poll cfn for updates.
+ 	request.WithWaiterMaxAttempts(1800),                                   // Wait for at most 90 mins for any cfn action.
+ }
+ ","This will now wait for 2.5 hours, not 90 minutes, if the waiter delay is 5s"
+9983,"@@ -14,6 +14,7 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS ""AS IS"" AND
+ const EventUtil = {
+
+   trapEvent(event){
++    if(!event) return
+     event.preventDefault();
+     event.stopPropagation();
+     if(event.nativeEvent && event.nativeEvent.preventDefault){",See this error on console too so I don't think it's just test simulation. For some reason event doesn't show up sometimes
+9984,"@@ -44,7 +44,7 @@ func main() {
+ 		cmds.NewCRICTL(externalCLIAction(""crictl"", dataDir)),
+ 		cmds.NewCtrCommand(externalCLIAction(""ctr"", dataDir)),
+ 		cmds.NewCheckConfigCommand(externalCLIAction(""check-config"", dataDir)),
+-		cmds.NewEtcdSnapshotCommand(etcdsnapshotCommand, cmds.NewEtcdSnapshotSubcommands(etcdsnapshotCommand)),
++		cmds.NewEtcdSnapshotCommand(etcdsnapshotCommand, cmds.NewEtcdSnapshotSubcommands(etcdsnapshotCommand, etcdsnapshotCommand)),
+ 	}
+
+ 	if err := app.Run(os.Args); err != nil {",We're passing the same thing twice?
+9985,"@@ -245,7 +245,8 @@ func TestCreateInstance(t *testing.T) {
+ 				},
+ 				Spec: clusterv1.MachineSpec{
+ 					Bootstrap: clusterv1.Bootstrap{
+-						Data: pointer.StringPtr(""user-data""),
++						// echo ""user-data"" | base64
++						Data: pointer.StringPtr(""dXNlci1kYXRhCg==""),
+ 					},
+ 				},
+ 			},",Shouldn't the value in Bootstrap.Data be just a plain string?
+9986,"@@ -209,7 +209,9 @@ namespace Datadog.Trace.AppSec
+         private void Report(ITransport transport, Span span, WafMatch[] results, bool blocked)
+         {
+             span.SetTag(Tags.AppSecEvent, ""true"");
+-            span.SetTraceSamplingPriority(SamplingPriority.UserKeep);
++            var samplingPirority = _settings.KeepTraces
++                ? SamplingPriority.UserKeep : SamplingPriority.AutoReject;
++            span.SetTraceSamplingPriority(samplingPirority);
+
+             LogMatchesIfDebugEnabled(results, blocked);
+ ","@robertpi Isn't this changing the sampling priority when `KeepTraces==false`? The sampling priority could be `AutoReject` or `AutoKeep`, based on the sampling decision (or the user may have specified something else). Seems like we shouldn't be changing it in this case?"
+9987,"@@ -17,6 +17,11 @@ const (
+ 	DefaultCADir        = ""/etc/kubeedge/ca""
+ 	DefaultCertDir      = ""/etc/kubeedge/certs""
+
++	DefaultCAURL   = ""/ca.crt""
++	DefaultCertURL = ""/edge.crt""
++
++	DefaultCloudCoreReadyCheckURL = ""/readyz""
++
+ 	DefaultStreamCAFile   = ""/etc/kubeedge/ca/streamCA.crt""
+ 	DefaultStreamCertFile = ""/etc/kubeedge/certs/stream.crt""
+ 	DefaultStreamKeyFile  = ""/etc/kubeedge/certs/stream.key""",The const can also be used in cloud/pkg/cloudhub/servers/httpserver/server.go L46-47?
+9988,"@@ -82,7 +82,7 @@ Blockly.Procedures.allProcedureMutations = function(root) {
+   var blocks = root.getAllBlocks();
+   var mutations = [];
+   for (var i = 0; i < blocks.length; i++) {
+-    if (blocks[i].type === 'procedures_prototype') {
++    if (blocks[i].type == 'procedures_prototype') {
+       var mutation = blocks[i].mutationToDom();
+       if (mutation) {
+         mutations.push(mutation);",Use a constant for `procedures_prototype`.
+9989,"@@ -12,7 +12,7 @@ def bad_percent(arg):
+
+ def good_percent(arg):
+     '''Instead of passing multiple arguments, format the message'''
+-    raise KeyError('Bad key: %r' % arg)
++    raise KeyError(f'Bad key: {arg!r}')
+
+ def bad_multiarg(name, value):
+     '''Raising a formatted string and multiple additional arguments'''",This file should probably not be touched as the formatting of the string seems to be a test in itself ?
+9990,"@@ -276,8 +276,11 @@ is_sys_kill(dcontext_t *dcontext, byte *pc, byte *xsp, siginfo_t *info);
+ int
+ sigaction_syscall(int sig, kernel_sigaction_t *act, kernel_sigaction_t *oact)
+ {
+-#if defined(X64) && !defined(VMX86_SERVER) && defined(LINUX)
++#if !defined(VMX86_SERVER) && defined(LINUX)
+     /* PR 305020: must have SA_RESTORER for x64 */
++    /* Must have SA_RESTORER to handle vsyscall32 being disabled
++       (see https://github.com/DynamoRIO/dynamorio/issues/2812)
++    */
+     if (act != NULL && !TEST(SA_RESTORER, act->flags)) {
+         act->flags |= SA_RESTORER;
+         act->restorer = (void (*)(void)) dynamorio_sigreturn;",style nit: missing leading '*'
+9991,"@@ -184,7 +184,7 @@ public class PrivateTransactionProcessor {
+       messageFrameStack.addFirst(initialFrame);
+
+       while (!messageFrameStack.isEmpty()) {
+-        process(messageFrameStack.peekFirst(), operationTracer);
++        process(messageFrameStack.peekFirst(), OperationTracer.NO_TRACING);
+       }
+
+       if (initialFrame.getState() == MessageFrame.State.COMPLETED_SUCCESS) {",The operationTracer is passed into the processTransaction() method. We should probably pass the no tracing in one in from where it is called.
+9992,"@@ -125,13 +125,10 @@ const (
+
+ // SPI on the Arduino Nano 33.
+ var (
+-	SPI0 = SPI{Bus: sam.SERCOM0_SPI,
+-		SCK:     SPI0_SCK_PIN,
+-		MOSI:    SPI0_MOSI_PIN,
+-		MISO:    SPI0_MISO_PIN,
+-		DOpad:   spiTXPad2SCK3,
+-		DIpad:   sercomRXPad0,
+-		PinMode: PinSERCOM}
++	SPI0 = SPI{
++		Bus:    sam.SERCOM0_SPI,
++		SERCOM: 0,
++	}
+ )
+
+ // I2S pins","I believe this line was an error, it should have been `sercomRXPad1` to be consistent with the pin numbers. Resolving this ambiguity by following the pin numbers."
+9993,"@@ -0,0 +1,12 @@
++<div>
++  <p>
++    Hello,<br/>
++    The request, <%= @proposal.name %> (<%= @proposal.public_id %>), has been cancelled.
++  </p>
++</div>
++
++<p>
++  <strong>
++    <%= link_to ""View This Request"", proposal_url(@proposal), {target: 'C2'} %>
++  </strong>
++</p>","May be useful to have the reason here, though clearly not pressing."
+9994,"@@ -136,7 +136,7 @@ class GridInterface(DictInterface):
+                                 'of arrays must match. %s found that arrays '
+                                 'along the %s dimension do not match.' %
+                                 (cls.__name__, vdim.name))
+-            stack = np.stack if any(is_dask(arr) for arr in arrays) else dask_array_module().stack
++            stack = dask_array_module().stack if any(is_dask(arr) for arr in arrays) else np.stack
+             new_data[vdim.name] = stack(arrays, -1)
+         return new_data
+ ",These were inverted before
+9995,"@@ -4227,6 +4227,11 @@ public class DBService {
+         return null;
+     }
+
++    public Map<String, DomainRoleMember> getReviewMembers() {
++        // Currently unimplemented
++        return new HashMap<>();
++    }
++
+     public void processExpiredPendingMembers(int pendingRoleMemberLifespan, final String monitorIdentity) {
+
+         final String auditRef = ""Expired - auto reject"";",DB is implemented in PR 951
+9996,"@@ -15,6 +15,16 @@ import (
+ 	""github.com/prometheus/client_golang/prometheus""
+ )
+
++const (
++	bytesToGB = 1073741824
++	bytesToMB = 1048567
++	micSec    = 1000000
++	bytesToKB = 1024
++	minwidth  = 0
++	maxwidth  = 0
++	padding   = 3
++)
++
+ // A gauge is a metric that represents a single numerical value that can
+ // arbitrarily go up and down.
+ ","move all constants to `pkg/util/constants.go`, these constants had been used in `volume_stats.go` file too. So better to import them."
+9997,"@@ -1,8 +1,8 @@
+ #appModules/winword.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2017 NV Access Limited, Manish Agrawal, Derek Riemer, Babbage B.V.
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# Copyright (C) 2006-2020 NV Access Limited, Manish Agrawal, Derek Riemer, Babbage B.V.
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+ import ctypes
+ import time",Could you revisit the full header and add appropriate spaces after the hashes?
+9998,"@@ -102,6 +102,11 @@ class CodeEditor extends FormWidgetBase
+      */
+     public $showPrintMargin = false;
+
++    /**
++     * @var string Hint to show above the code editor
++     */
++    public $codeHint = '';
++
+     //
+     // Object properties
+     //",This should either be `hint` that takes a string to render inside of the partial container or probably better you should just render a separate hint field above the code field in the same tab.
+9999,"@@ -4330,7 +4330,7 @@ func TestJetStreamCrossAccountMirrorsAndSources(t *testing.T) {
+ 		t.Fatalf(""Did not receive correct response: %+v"", scResp.Error)
+ 	}
+
+-	checkFor(t, 2*time.Second, 100*time.Millisecond, func() error {
++	checkFor(t, 4*time.Second, 100*time.Millisecond, func() error {
+ 		si, err := js2.StreamInfo(""MY_SOURCE_TEST"")
+ 		if err != nil {
+ 			t.Fatalf(""Could not retrieve stream info"")",this was flapping
+10000,"@@ -185,6 +185,7 @@ namespace MvvmCross.Platforms.Ios.Views
+             }
+             else
+             {
++                keyboardFrame.Height -= scrollView.SafeAreaInsets.Bottom;
+                 scrollView.CenterView(activeView, keyboardFrame);
+             }
+         }",Please add a check to see if SafeAreaInsets is available. It isn't on all iOS versions.
+10001,"@@ -77,7 +77,7 @@ class RolesController < ApplicationController
+       # rubocop:disable LineLength
+       render json: {
+         code: 1,
+-        msg: _(""Successfully changed the permissions for #{@role.user.email}. They have been notified via email."")
++        msg: _(""Successfully changed the permissions for %{email}. They have been notified via email."") % { email: @role.user.email }
+       }
+       # rubocop:enable LineLength
+     else",interpolation here was causing the translation to not get picked up
+10002,"@@ -69,8 +69,13 @@ StatelessWriter::StatelessWriter(
+
+ StatelessWriter::~StatelessWriter()
+ {
+-    AsyncWriterThread::removeWriter(*this);
+     logInfo(RTPS_WRITER,""StatelessWriter destructor"";);
++
++    mp_RTPSParticipant->async_thread().unregister_writer(this);
++
++    // After unregistering writer from AsyncWriterThread, delete all flow_controllers because they register the writer in
++    // the AsyncWriterThread.
++    flow_controllers_.clear();
+ }
+
+ void StatelessWriter::get_builtin_guid()",We don't need to disable the flow controller here as in `StatefulWriter`s destructor?
+10003,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low."
+10004,"@@ -313,11 +313,17 @@ func (r *DefaultRuleRenderer) filterOutputChain() *Chain {
+ 	// That decision is based on pragmatism; it's generally very useful to be able to contact
+ 	// any local workload from the host and policing the traffic doesn't really protect
+ 	// against host compromise.  If a host is compromised, then the rules could be removed!
++	// However, we do apply policy to workload ingress traffic if it belongs to an IPVS connection.
+ 	for _, prefix := range r.WorkloadIfacePrefixes {
+-		// If the packet is going to a worklaod endpoint, RETURN.
++		// If the packet is going to a workload endpoint, apply workload ingress policy if traffic
++		// belongs to an IPVS connection and return at the end.
+ 		log.WithField(""ifacePrefix"", prefix).Debug(""Adding workload match rules"")
+ 		ifaceMatch := prefix + ""+""
+ 		rules = append(rules,
++			Rule{
++				Match:  Match().OutInterface(ifaceMatch).IPVSConnection(),
++				Action: JumpAction{Target: ChainToWorkloadDispatch},
++			},
+ 			Rule{
+ 				Match:  Match().OutInterface(ifaceMatch),
+ 				Action: ReturnAction{},","I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?"
+10005,"@@ -60,3 +60,11 @@ func isABuildFile(name string, config *core.Configuration) bool {
+ 	}
+ 	return false
+ }
++
++// Max is an incredibly complicated function, which is presumably why it didn't make it into the Go stdlib
++func Max(x, y int) int {
++	if x < y {
++		return y
++	}
++	return x
++}",There's one for floats but not for ints. The float implementation is non-trivial though which I guess is the argument there.
+10006,"@@ -51,6 +51,9 @@ const (
+ 	// 6. QueryWorkflow
+ 	// please also reference selectedAPIsForwardingRedirectionPolicyWhitelistedAPIs
+ 	DCRedirectionPolicySelectedAPIsForwarding = ""selected-apis-forwarding""
++
++	// DCRedirectionPolicyAllAPIsForwarding means forwarding all APIs based on namespace active cluster
++	DCRedirectionPolicyAllAPIsForwarding = ""all-apis-forwarding""
+ )
+
+ type (","If we have a redirection policy for Selected API forwarding, why isn't ""redirect all"" just a special case where they are all Selected?"
+10007,"@@ -130,6 +130,8 @@ const (
+ 	FrameworkTally = ""tally""
+ 	// FrameworkOpentelemetry OpenTelemetry framework id
+ 	FrameworkOpentelemetry = ""opentelemetry""
++	// FrameworkCustom Custom framework id
++	FrameworkCustom = ""custom""
+ )
+
+ // tally sanitizer options that satisfy both Prometheus and M3 restrictions.",I wouldn't add this. Just completely ignore config if custom reporter is not `nil` in server options.
+10008,"@@ -159,10 +159,19 @@ int main(int argc, char *argv[]) {
+
+     auto ioThreadPool = std::make_shared<folly::IOThreadPoolExecutor>(FLAGS_num_io_threads);
+
++    std::string clusteridFile =
++        folly::stringPrintf(""%s/%s"", paths[0].c_str(), ""/storage.cluster.id"");
++    auto clusterMan
++        = std::make_unique<nebula::meta::ClusterManager>("""", clusteridFile);
++    if (!clusterMan->loadClusterId()) {
++        LOG(INFO) << ""storaged misses clusterId"";
++    }
++
+     // Meta client
+     auto metaClient = std::make_unique<nebula::meta::MetaClient>(ioThreadPool,
+                                                                  std::move(metaAddrsRet.value()),
+                                                                  localhost,
++                                                                 clusterMan.get(),
+                                                                  true);
+     if (!metaClient->waitForMetadReady()) {
+         LOG(ERROR) << ""waitForMetadReady error!"";",What's the meaning about the code?
+10009,"@@ -172,7 +172,7 @@ public class WebViewLocalServer {
+       return null;
+     }
+
+-    if (isLocalFile(loadingUrl) || (bridge.getConfig().getString(""server.url"") == null && !bridge.getAppAllowNavigationMask().matches(loadingUrl.getHost()))) {
++    if (isLocalFile(loadingUrl) || loadingUrl.getHost().contains(bridge.getHost()) || (bridge.getServerUrl() == null && !bridge.getAppAllowNavigationMask().matches(loadingUrl.getHost()))) {
+       Logger.debug(""Handling local request: "" + request.getUrl().toString());
+       return handleLocalRequest(request, handler);
+     } else {","Would this incorrectly trigger if `loadingUrl.getHost() = ""something.app""` and `bridge.getHost() = ""app""`?"
+10010,"@@ -23,7 +23,11 @@ class AnchorHead(BaseDenseHead, BBoxTestMixin):
+         anchor_generator (dict): Config dict for anchor generator
+         bbox_coder (dict): Config of bounding box coder.
+         reg_decoded_bbox (bool): If true, the regression loss would be
+-            applied on decoded bounding boxes. Default: False
++            applied directly on decoded bounding boxes, meaning both the
++            predicted boxes and regression targets are with absolute
++            coordinates format. Default False. Note generally it should be
++            set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`
++            in the bbox head.
+         loss_cls (dict): Config of classification loss.
+         loss_bbox (dict): Config of localization loss.
+         train_cfg (dict): Training config of anchor head.",Note generally it -> It
+10011,"@@ -81,8 +81,7 @@ public abstract class ConfigSetService {
+               ) ? false: true;
+
+       SolrConfig solrConfig = createSolrConfig(dcore, coreLoader, trusted);
+-      IndexSchema indexSchema = createIndexSchema(dcore, solrConfig, false);
+-      return new ConfigSet(configSetName(dcore), solrConfig, force -> indexSchema, properties, trusted);
++      return new ConfigSet(configSetName(dcore), solrConfig, force -> createIndexSchema(dcore, solrConfig, force), properties, trusted);
+     } catch (Exception e) {
+       throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
+           ""Could not load conf for core "" + dcore.getName() +",Does this mean that every call to `configSet.getIndexSchema()` will create a new schema object (if shared schema is not enabled)?
+10012,"@@ -1,12 +1,11 @@
+ /*
+- * Licensed to the Apache Software Foundation (ASF) under one or more
+- * contributor license agreements.  See the NOTICE file distributed with
+- * this work for additional information regarding copyright ownership.
+- * The ASF licenses this file to You under the Apache License, Version 2.0
+- * (the ""License""); you may not use this file except in compliance with
+- * the License.  You may obtain a copy of the License at
++ * Copyright 2017 Huawei Technologies Co., Ltd
+  *
+- *     http://www.apache.org/licenses/LICENSE-2.0
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an ""AS IS"" BASIS,",License header should use the Apache one.
+10013,"@@ -107,6 +107,8 @@ func (globber *Globber) Glob(rootPath string, includes, excludes []string, inclu
+ 		matches, err := globber.glob(rootPath, include, excludes, includeHidden, includeSymlinks)
+ 		if err != nil {
+ 			panic(fmt.Errorf(""error globbing files with %v: %v"", include, err))
++		} else if len(matches) == 0 {
++			panic(fmt.Errorf(""No matches found for this glob""))
+ 		}
+ 		// Remove the root path from the returned files and add them to the output
+ 		for _, filename := range matches {","I think this makes more sense to be applied within the parser code where we evaluate the `glob` builtin? This function looks generic in the sense of where it can be used, and perhaps no matches is fine in other cases?"
+10014,"@@ -226,6 +226,14 @@ func NewConfig(ec2client ec2.EC2MetadataClient) (*Config, error) {
+ 	}
+ 	config := &envConfig
+
++	if config.OnPrem.Enabled() {
++		if config.AWSRegion == """" {
++			return nil, errors.New(""AWS_DEFAULT_REGION has to be set when running on-premises"")
++		}
++		// Use fake ec2 metadata client if on prem config is set.
++		ec2client = ec2.NewBlackholeEC2MetadataClient()
++	}
++
+ 	if config.complete() {
+ 		// No need to do file / network IO
+ 		return config, nil",should we validate that AWSRegion has also been set here so that we don't get into the if-block that relies on the ec2 metadata client below?
+10015,"@@ -89,11 +89,13 @@ class ThriftRequestHandler():
+                  checker_md_docs,
+                  checker_md_docs_map,
+                  suppress_handler,
+-                 db_version_info):
++                 db_version_info,
++                 version):
+
+         self.__checker_md_docs = checker_md_docs
+         self.__checker_doc_map = checker_md_docs_map
+         self.__suppress_handler = suppress_handler
++        self.__version = version
+         self.__session = session
+
+     def __queryReport(self, reportId):",maybe naming `version` to `package_version` or something similar can be more descriptive
+10016,"@@ -235,7 +235,7 @@ class MessageTypeToType extends ParquetTypeVisitor<Type> {
+     return current;
+   }
+
+-  private int getId(org.apache.parquet.schema.Type type) {
++  protected int getId(org.apache.parquet.schema.Type type) {
+     org.apache.parquet.schema.Type.ID id = type.getId();
+     if (id != null) {
+       return id.intValue();",Why was this changed?
+10017,"@@ -1,3 +1,4 @@
++//go:build !arm64
+ // +build !arm64
+
+ package nodeps","Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these"
+10018,"@@ -1,10 +1,10 @@
+ module OrgAdmin
+   class PlansController < ApplicationController
+-    after_action :verify_authorized
+-
++    # GET org_admin/plans
+     def index
+-      authorize Plan
+-
++      # Test auth directly and throw Pundit error sincePundit is unaware of namespacing
++      raise Pundit::NotAuthorizedError unless current_user.present? && current_user.can_org_admin?
++
+       vals = Role.access_values_for(:reviewer)
+       @feedback_plans = Plan.joins(:roles).where('roles.user_id = ? and roles.access IN (?)', current_user.id, vals)
+       @plans = current_user.org.plans","Pundit is unaware of namespacing, however you can still create the class under policies/org_admin/plans_policy.rb. That means, the condition for the unless can be reused in other places too. You would call the policy as OrgAdmin::PlansPolicy.new(current_user).index? after that unless"
+10019,"@@ -203,6 +203,13 @@ public class PMD {
+             return 0;
+         }
+
++        // Log warning only once, if not explicitly disabled
++        if (!configuration.isIgnoreIncrementalAnalysis() && LOG.isLoggable(Level.WARNING)) {
++            final String version = PMDVersion.isUnknown() || PMDVersion.isSnapshot() ? ""latest"" : ""pmd-"" + PMDVersion.VERSION;
++            LOG.warning(""This analysis could be faster, please consider using Incremental Analysis: ""
++                                + ""https://pmd.github.io/"" + version + ""/pmd_userdocs_getting_started.html#incremental-analysis"");
++        }
++
+         Set<Language> languages = getApplicableLanguages(configuration, ruleSets);
+         List<DataSource> files = getApplicableFiles(configuration, languages);
+ ",this warning shouldn't be produced if we configured a cache either
+10020,"@@ -16,6 +16,7 @@ describe('examples(change-stream):', function() {
+     client = await this.configuration.newClient().connect();
+     db = client.db(this.configuration.db);
+
++    await db.createCollection('inventory');
+     await db.collection('inventory').deleteMany({});
+   });
+ ",what if the collection is already there?
+10021,"@@ -24,8 +24,7 @@ import java.io.OutputStream;
+ import java.util.Base64;
+
+ /**
+- * Defines the output type for a screenshot. See org.openqa.selenium.Screenshot for usage and
+- * examples.
++ * Defines the output type for a screenshot.
+  *
+  * @see TakesScreenshot
+  * @param <T> Type for the screenshot output.",instead of removing can you reference org.openqa.selenium.TakesScreenshot ?
+10022,"@@ -644,4 +644,6 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem
+             }
+         }
+     }
++
++
+ }",Please revert unrelated changes
+10023,"@@ -1224,6 +1224,11 @@ var AppRouter = Backbone.Router.extend({
+             path: [countlyGlobal.cdn + 'localization/min/'],
+             mode: 'map',
+             callback: function() {
++                if (countlyGlobal.company) {
++                    for (var key in jQuery.i18n.map) {
++                        jQuery.i18n.map[key] = jQuery.i18n.map[key].replace(""Countly"", countlyGlobal.company);
++                    }
++                }
+                 self.origLang = JSON.stringify(jQuery.i18n.map);
+             }
+         });","As far as I know, this will replace only first occurance of Countly, not others, if there are more than one Countly word in localized string"
+10024,"@@ -111,9 +111,9 @@ public class LocalRepository implements Repository {
+
+                     if (StringUtils.isBlank(jsonTypeDTO.getId())) {
+                         if (!StringUtils.isBlank(jsonTypeDTO.getName())) {
+-                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9]"", """"));
++                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9_]"", """"));
+                         } else {
+-                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9]"", """"));
++                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9_]"", """"));
+                         }
+                     }
+ ","I suggest, that we move the regex (`[^a-zA-Z0-9_]`) to a separate constant field, because we're using it in multiple places and I think it's quite prone to misspellings."
+10025,"@@ -1,7 +1,7 @@
+ import logging
+ import time
+ from collections import OrderedDict, defaultdict
+-from typing import Iterable, Optional
++from typing import Dict, Iterable, List, Optional, Union
+
+ from dagster import check
+ from dagster.core.definitions.events import AssetKey","Feel free to disregard, but I've been trying to use `Mapping` and `Sequence` instead of `Dict` and `List` when possible, because they communicate that the type is immutable, and also are covariant."
+10026,"@@ -27,6 +27,9 @@ import (
+ 	""testing""
+ 	""time""
+
++	""github.com/nats-io/jwt/v2""
++	""github.com/nats-io/nkeys""
++
+ 	""github.com/nats-io/nats.go""
+ )
+ ",No need for blank line here. This block will then be reordered alphabatically.
+10027,"@@ -5,9 +5,14 @@ import (
+ 	""fmt""
+
+ 	k8s ""k8s.io/client-go/kubernetes""
++	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/clientcmd""
+ )
+
++const (
++	localCluster = ""local""
++)
++
+ type ClientsetManager interface {
+ 	Clientsets() map[string]ContextClientset
+ 	GetK8sClientset(clientset, cluster, namespace string) (ContextClientset, error)",let's call it `in-cluster` instead of `local`. less chance of confusion.
+10028,"@@ -95,6 +95,8 @@ class Product extends BaseAction implements EventSubscriberInterface
+             $con->beginTransaction();
+
+             try {
++                $prev_ref = $product->getRef();
++
+                 $product
+                     ->setDispatcher($event->getDispatcher())
+                     ->setRef($event->getRef())",Please use camelCase instead of underscore_case
+10029,"@@ -87,7 +87,8 @@ def get_contents(bucket, key, ext, *, etag, version_id, s3_client, size):
+                 s3_client=s3_client,
+                 version_id=version_id
+             )
+-            content = extract_parquet(get_bytes(obj[""Body""], compression), as_html=False)[0]
++            body, info = extract_parquet(get_bytes(obj[""Body""], compression), as_html=False)
++            content = trim_to_bytes(f""{str(info)}\n{body}"", ELASTIC_LIMIT_BYTES)
+         else:
+             content = get_plain_text(
+                 bucket,","Ideally, we'd fold the schema into an expanded system_meta, but this is a good first step."
+10030,"@@ -95,6 +95,7 @@ public class TableMetadataParser {
+   static final String SNAPSHOT_ID = ""snapshot-id"";
+   static final String TIMESTAMP_MS = ""timestamp-ms"";
+   static final String SNAPSHOT_LOG = ""snapshot-log"";
++  static final String FIELDS = ""fields"";
+
+   public static void overwrite(TableMetadata metadata, OutputFile outputFile) {
+     internalWrite(metadata, outputFile, true);",Is this used?
+10031,"@@ -16,7 +16,7 @@
+
+ using System;
+ using System.Diagnostics;
+-#if NET45 || NET46
++#if NET452 || NET46
+ using System.Diagnostics.CodeAnalysis;
+ using System.Threading;
+ #endif",Should we use `#if NETFRAMEWORK` for consistency with the other projects?
+10032,"@@ -46,7 +46,12 @@ type DecodedContainerRecord struct {
+
+ func (d *ContianerRecordDecoder) DecodeContainerRecord(ctx context.Context, record *v1alpha1.Record) (decoded DecodedContainerRecord, err error) {
+ 	var pod v1.Pod
+-	podId, containerName := controller.ParseNamespacedNameContainer(record.Id)
++	podId, containerName, err := controller.ParseNamespacedNameContainer(record.Id)
++	if err != nil {
++		// TODO: organize the error in a better way
++		err = NewFailToFindContainer(pod.Namespace, pod.Name, containerName, err)
++		return
++	}
+ 	err = d.Client.Get(ctx, podId, &pod)
+ 	if err != nil {
+ 		// TODO: organize the error in a better way","If it parses failed, both of the `containerName` and `podId` should be the empty strings, it's non-sense to define this error, I suggest just return it."
+10033,"@@ -61,17 +61,6 @@ export default Service.extend({
+         }
+     },
+
+-    sendTestRequest(testApplicationId) {
+-        let url = `${API_URL}/photos/random`;
+-        let headers = {};
+-
+-        headers.Authorization = `Client-ID ${testApplicationId}`;
+-        headers['Accept-Version'] = API_VERSION;
+-
+-        return fetch(url, {headers})
+-            .then((response) => this._checkStatus(response));
+-    },
+-
+     actions: {
+         updateSearch(term) {
+             if (term === this.get('searchTerm')) {","line 26 can be removed i think > applicationId: or('config.unsplashAPI.applicationId', 'settings.unsplash.applicationId'),"
+10034,"@@ -340,9 +340,9 @@ void Config::CheckParamConflict() {
+     Log::Warning(""CUDA currently requires double precision calculations."");
+     gpu_use_dp = true;
+   }
+-  // linear tree learner must be serial type and cpu device
++  // linear tree learner must be serial type and run on cpu device
+   if (linear_tree) {
+-    if (device_type == std::string(""gpu"")) {
++    if (device_type != std::string(""cpu"")) {
+       device_type = ""cpu"";
+       Log::Warning(""Linear tree learner only works with CPU."");
+     }",To generalize for possible future new enum options.
+10035,"@@ -877,6 +877,9 @@ def main(argv):
+             from scapy.arch.windows import route_add_loopback
+             route_add_loopback()
+
++        # Add SCAPY_ROOT_DIR environment variable, used for tests
++        os.environ['SCAPY_ROOT_DIR'] = os.environ.get(""PWD"", os.getcwd())
++
+     except getopt.GetoptError as msg:
+         print(""ERROR:"", msg, file=sys.stderr)
+         raise SystemExit",Shall we remove this variable at the end of UTScapy execution?
+10036,"@@ -29,6 +29,10 @@ public class ProtoModels {
+
+   /** Gets the interfaces for the apis in the service config. */
+   public static List<Interface> getInterfaces(Model model) {
++    if (model.getServiceConfig().getApisCount() == 0) {
++      // A valid service config was not given.
++      return model.getSymbolTable().getInterfaces().asList();
++    }
+     return model
+         .getServiceConfig()
+         .getApisList()",What is this checking for? Why is returning the list of interfaces the correct behaviour in this case?
+10037,"@@ -20,6 +20,9 @@ namespace Nethermind.Blockchain
+ {
+     public interface ISyncConfig : IConfig
+     {
++        [ConfigItem(Description = ""HMB Sync."", DefaultValue = ""false"")]
++        bool HmbSync { get; set; }
++
+         [ConfigItem(Description = ""If set to 'true' then the Fast Sync (eth/63) synchronization algorithm will be used."", DefaultValue = ""false"")]
+         bool FastSync { get; set; }
+         ",Please name it correctly as Beam ;)
+10038,"@@ -184,9 +184,9 @@ func shouldRetryWithWait(tripper http.RoundTripper, err error, multiplier int) b
+ 	apiErr, ok := err.(*googleapi.Error)
+ 	var retry bool
+ 	switch {
+-	case !ok && tkValid:
+-		// Not a googleapi.Error and the token is still valid.
+-		return false
++	case !ok:
++		// Not a googleapi.Error. Likely a transport error.
++		retry = true
+ 	case apiErr.Code >= 500 && apiErr.Code <= 599:
+ 		retry = true
+ 	case apiErr.Code >= 429:","After chatting with Andrew, we think it's better to look for this particular error string that is causing issues (""connection reset by peer"") instead of blindly retrying on any error we don't know about."
+10039,"@@ -25,14 +25,14 @@ namespace AutoRest.Swagger.Validation.Core
+         /// <summary>
+         /// What kind of open api document type this rule should be applied to
+         /// </summary>
+-        public virtual ServiceDefinitionDocumentType ServiceDefinitionDocumentType => ServiceDefinitionDocumentType.ARM;
++        public abstract ServiceDefinitionDocumentType ServiceDefinitionDocumentType { get; }
+
+         /// <summary>
+         /// When to apply the validation rule, before or after it has been merged as a part of
+         /// its merged document as specified in the corresponding '.md' file
+         /// By default consider all rules to be applied for After only
+         /// </summary>
+-        public virtual ServiceDefinitionDocumentState ValidationRuleMergeState => ServiceDefinitionDocumentState.Composed;
++        public abstract ServiceDefinitionDocumentState ValidationRuleMergeState { get; }
+
+         /// <summary>
+         /// Violation category of the Rule.",any reason to not have defaults here like you had before? (ARM)?
+10040,"@@ -1,4 +1,3 @@
+-<% page_info = paginate_params(@response) %>
+ <%= tag :meta, :name => ""totalResults"", :content => @response.total %>
+-<%= tag :meta, :name => ""startIndex"", :content => (page_info.current_page == 1 ? 1 : @response.start ) %>
+-<%= tag :meta, :name => ""itemsPerPage"", :content => page_info.limit_value %>
++<%= tag :meta, :name => ""startIndex"", :content => @response.start %>
++<%= tag :meta, :name => ""itemsPerPage"", :content => @response.limit_value %>","This is a change. The old code was just wrong before, but now here (and one other machine-readable place) we expose the start index as 0 for the first item."
+10041,"@@ -178,11 +178,11 @@ namespace RDKit {
+     };
+   } // end of SLNParse namespace
+
+-  RWMol *SLNToMol(std::string sln,bool sanitize,int debugParse){
++  RWMol *SLNToMol(const std::string &sln,bool sanitize,int debugParse){
+     // FIX: figure out how to reset lexer state
+     yysln_debug = debugParse;
+     // strip any leading/trailing whitespace:
+-    boost::trim_if(sln,boost::is_any_of("" \t\r\n""));
++    //boost::trim_if(sln,boost::is_any_of("" \t\r\n""));
+
+     RWMol *res = SLNParse::toMol(sln,false,debugParse);
+     if(res){","This changes the behavior of the parser, right? Any particular reason to do this aside from the fact that you have to since the function takes a const?"
+10042,"@@ -17,5 +17,16 @@ function Portal(props) {
+  * @param {import('./internal').PreactElement} container The DOM node to continue rendering in to.
+  */
+ export function createPortal(vnode, container) {
++	// Note: We can't use Fragment here because a component that returned a Portal
++	// (e.g. `const App = () => createPortal(...)`) wouldn't work. Our diff
++	// collapses Fragments without keys that are returned directly from components
++	// into just an array and sets that as the children array of the component.
++	//
++	// We also can't use keyed Fragments here cuz it might lead to weird edge
++	// cases when toggling between two sibling portals if we use a shared keyed or
++	// lead to unnecessary re-mounts if trying to generate a new key on each call.
++	//
++	// So the simplest solution seems to be just to use an unique type for Portal
++	// to skip the Fragment collapsing logic when diffing components
+ 	return createElement(Portal, { _parentDom: container }, vnode);
+ }","Given how simple the Portal implementation is, I wonder if we should move it core... Though we'd have to export it which would be more bytes we can't crawl back..."
+10043,"@@ -348,6 +348,7 @@ Schema.prototype.clone = function() {
+   s.callQueue = this.callQueue.map(function(f) { return f; });
+   s.methods = utils.clone(this.methods);
+   s.statics = utils.clone(this.statics);
++  s.s.hooks = utils.clone(this.s.hooks);
+   return s;
+ };
+ ",The more correct way of doing this is `this.s.hooks.clone()` but either way works. Thanks for finding this :+1:
+10044,"@@ -123,14 +123,13 @@ func (b *ClusterNetworkPolicySpecBuilder) GetAppliedToPeer(podSelector map[strin
+ func (b *ClusterNetworkPolicySpecBuilder) AddIngress(protoc v1.Protocol,
+ 	port *int32, portName *string, endPort *int32, cidr *string,
+ 	podSelector map[string]string, nsSelector map[string]string,
+-	podSelectorMatchExp []metav1.LabelSelectorRequirement, nsSelectorMatchExp []metav1.LabelSelectorRequirement, selfNS bool,
++	podSelectorMatchExp []metav1.LabelSelectorRequirement, nsSelectorMatchExp []metav1.LabelSelectorRequirement, selfNS string,
+ 	ruleAppliedToSpecs []ACNPAppliedToSpec, action crdv1alpha1.RuleAction, ruleClusterGroup, name string) *ClusterNetworkPolicySpecBuilder {
+
+ 	var pSel *metav1.LabelSelector
+ 	var nSel *metav1.LabelSelector
+ 	var ns *crdv1alpha1.PeerNamespaces
+ 	var appliedTos []crdv1alpha1.NetworkPolicyPeer
+-	matchSelf := crdv1alpha1.NamespaceMatchSelf
+
+ 	if b.Spec.Ingress == nil {
+ 		b.Spec.Ingress = []crdv1alpha1.Rule{}",Can we update bool to an enum instead of a string? This helps future extensibility
+10045,"@@ -8,6 +8,13 @@ module Ncr
+
+   EXPENSE_TYPES = %w(BA60 BA61 BA80)
+   BUILDING_NUMBERS = YAML.load_file(""#{Rails.root}/config/data/ncr/building_numbers.yml"")
++  FY16 = Time.zone.parse('2015-10-01')
++  if Time.zone.now > FY16
++    MAX_AMOUNT = 3500.0
++  else
++    MAX_AMOUNT = 3000.0
++  end
++  MIN_AMOUNT = 0.0
+
+   class WorkOrder < ActiveRecord::Base
+     include ValueHelper","Should we share, since this is also being used with gsa18f?"
+10046,"@@ -1835,7 +1835,7 @@ window.CrashgroupView = countlyView.extend({
+         // `d` is the original data object for the row
+         var str = '';
+         if (data) {
+-            str += '<div class=""datatablesubrow"">' +
++            str += '<div id=""crash-data-subrow"" class=""datatablesubrow"">' +
+                    '<div class=""error_menu"">' +
+                     '<div class=""error-details-menu"" data-id=""' + data._id + '"">' +
+                         '<a class=""right icon-button cly-button-menu-trigger""></a>' +","There can be multiple subrows, so it is not a good idea to use `id` there, as id should identify single unique element. Instead you could just add the id of whole table or of whole crash plugin view"
+10047,"@@ -284,7 +284,6 @@ class TestAnalyze(unittest.TestCase):
+         # We expect a failure archive to be in the failed directory.
+         failed_files = os.listdir(failed_dir)
+         self.assertEquals(len(failed_files), 1)
+-        self.assertIn(""failure.c"", failed_files[0])
+
+         fail_zip = os.path.join(failed_dir, failed_files[0])
+ ",Why was this assert removed? Shouldn't we check if the file is in the zip?
+10048,"@@ -149,13 +149,17 @@ func (cb *ControllerBuilder) Build() (*Controller, error) {
+ 	return cb.Controller, nil
+ }
+
+-// addSpc is the add event handler for spc.
++// addSpc is the add event handler for spc
+ func (c *Controller) addSpc(obj interface{}) {
+ 	spc, ok := obj.(*apis.StoragePoolClaim)
+ 	if !ok {
+ 		runtime.HandleError(fmt.Errorf(""Couldn't get spc object %#v"", obj))
+ 		return
+ 	}
++	if spc.Labels[string(apis.OpenEBSUpgradeKey)] == ""true"" {
++		glog.Infof(""spc %s is not reconciled reason upgrade value: %s"", spc.Name, spc.Labels[string(apis.OpenEBSUpgradeKey)])
++		return
++	}
+ 	glog.V(4).Infof(""Queuing SPC %s for add event"", spc.Name)
+ 	c.enqueueSpc(spc)
+ }","This logic should be handled at informer handle functions i.e. AddFunc, UpdateFunc, DeleteFunc"
+10049,"@@ -39,3 +39,15 @@ type PSList struct {
+ func (c *PSList) Len() int {
+ 	return len(c.items)
+ }
++
++// IsStripePoolSpec returns true if pool spec is stripe pool or else it will
++// return false
++func IsStripePoolSpec(poolSpec *apisv1alpha1.PoolSpec) bool {
++	if len(poolSpec.RaidGroups[0].Type) != 0 {
++		if apisv1alpha1.PoolType(poolSpec.RaidGroups[0].Type) == apisv1alpha1.PoolStriped {
++			return true
++		}
++		return false
++	}
++	return apisv1alpha1.PoolType(poolSpec.PoolConfig.DefaultRaidGroupType) == apisv1alpha1.PoolStriped
++}",S1008: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (from `gosimple`)
+10050,"@@ -22,9 +22,15 @@ import (
+ )
+
+ func TestProcessIssueEvent(t *testing.T) {
++	const (
++		defaultTitle = ""foo: bar""
++	)
++
+ 	tests := []struct {
+ 		description string
+ 		action      string
++		title           string // defaults to defaultTitle
++		prevTitle string
+ 		labels      []string
+ 		want        *issueEdits
+ 	}{","Just to remove branching, use `defaultTitle` explicitly in the test cases. (Is this gofmt'd?)"
+10051,"@@ -64,7 +64,7 @@ public class CSharpGapicSnippetsTransformer implements ModelToViewTransformer<Pr
+   private final StaticLangApiMethodTransformer apiMethodTransformer =
+       new CSharpApiMethodTransformer();
+   private final CSharpCommonTransformer csharpCommonTransformer = new CSharpCommonTransformer();
+-  private final SampleTransformer sampleTransformer = new SampleTransformer(SampleType.IN_CODE);
++  private final SampleTransformer sampleTransformer = SampleTransformer.create(SampleType.IN_CODE);
+   private final InitCodeTransformer initCodeTransformer = new InitCodeTransformer();
+
+   public CSharpGapicSnippetsTransformer(GapicCodePathMapper pathMapper) {",I don't think you use this variable anywhere. (You call `SampleTransformer.newBuilder()` below)
+10052,"@@ -54,6 +54,18 @@ char *chirp_wrap_whoami(const char *hostname, time_t stoptime)
+ 	return xxstrdup(id);
+ }
+
++char *chirp_wrap_hash(const char *hostname, const char *path, const char *algorithm, time_t stoptime) {
++	int result;
++	unsigned char digest[CHIRP_DIGEST_MAX];
++
++	result = chirp_reli_hash(hostname, path, algorithm, digest, stoptime);
++
++	if(result < 0)
++		return NULL;
++
++	return xxstrdup( (char *) digest);
++}
++
+ int64_t chirp_wrap_job_create (const char *host, const char *json, time_t stoptime)
+ {
+ 	chirp_jobid_t id;",The digest is in binary and variable size (the digest size is result if > 0). So we can't use xxstrdup.
+10053,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+
+   @Override",We don't need this additional method.
+10054,"@@ -44,4 +44,5 @@ type ClientConfig interface {
+ 	// have already been started.
+ 	GetUnaryOutbound() UnaryOutbound
+ 	GetOnewayOutbound() OnewayOutbound
++	GetStreamOutbound() StreamOutbound
+ }","We can't do this. Adding a method to an interface is a breaking change. This was an oversight on our part when we converted ClientConfig from a struct to an interface. OutboundConfig was introduced to fix this, the idea being that we should use OutboundConfig everywhere instead of ClientConfig. In case of Dispatcher, we want to use the OutboundConfig and MustOutboundConfig methods instead of ClientConfig, and for streaming, the client needs to attempt to upcast a ClientConfig to OutboundConfig and error out if that's not possible."
+10055,"@@ -32,7 +32,9 @@ namespace domain {
+ DomainParticipant::DomainParticipant(
+         uint32_t did)
+     : dds::core::Reference<detail::DomainParticipant>(
+-        eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->create_participant(did))
++        eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->create_participant(
++                did,
++                eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->get_default_participant_qos()))
+ {
+ }
+ ",Why not using the constant `PARTICIPANT_QOS_DEFAULT` here?
+10056,"@@ -29,7 +29,8 @@ from pkg_resources import resource_stream
+ def getScalarMetricWithTimeOfDayAnomalyParams(metricData,
+                                               minVal=None,
+                                               maxVal=None,
+-                                              minResolution=None):
++                                              minResolution=None,
++                                              tmImplementation = ""cpp""):
+   """"""
+     Return a dict that can be used to create an anomaly model via OPF's
+     ModelFactory.","Shouldn't this be `tm_cpp` to match `temporalImp`? (There are multiple CPP implementations, so 'cpp' is ambiguous.)"
+10057,"@@ -30,7 +30,18 @@ module RSpec
+       # @param line [String] current code line
+       # @return [String] relative path to line
+       def self.relative_path(line)
+-        line = line.sub(File.expand_path("".""), ""."")
++        # Matches strings either at the beginning of the input or prefixed with a whitespace,
++        # containing the current path, either postfixed with the separator, or at the end of the string.
++        # Match groups are the character before and the character after the string if any.
++        #
++        # http://rubular.com/r/fT0gmX6VJX
++        # http://rubular.com/r/duOrD4i3wb
++        # http://rubular.com/r/sbAMHFrOx1
++        #
++
++        regex = /(\A|\s)#{File.expand_path('.')}(#{File::SEPARATOR}|\s|\Z)/
++
++        line = line.sub(regex, ""\\1.\\2"")
+         line = line.sub(/\A([^:]+:\d+)$/, '\\1')
+         return nil if line == '-e:1'
+         line",Need to remove this empty line for rubocop to be happy.
+10058,"@@ -63,9 +63,9 @@ func newController(objects ...runtime.Object) (*fake.Clientset, *networkPolicyCo
+ 	addressGroupStore := store.NewAddressGroupStore()
+ 	internalNetworkPolicyStore := store.NewNetworkPolicyStore()
+ 	npController := NewNetworkPolicyController(client, informerFactory.Core().V1().Pods(), informerFactory.Core().V1().Namespaces(), informerFactory.Networking().V1().NetworkPolicies(), addressGroupStore, appliedToGroupStore, internalNetworkPolicyStore)
+-	npController.podListerSynced = alwaysReady
+-	npController.namespaceListerSynced = alwaysReady
+-	npController.networkPolicyListerSynced = alwaysReady
++	//npController.podListerSynced = alwaysReady
++	//npController.namespaceListerSynced = alwaysReady
++	//npController.networkPolicyListerSynced = alwaysReady
+ 	return client, &networkPolicyController{
+ 		npController,
+ 		informerFactory.Core().V1().Pods().Informer().GetStore(),","just checking: do we need to remove this because otherwise the `List` operations may not return the entire set of Pods / Namespaces? do you know why we used `alwaysReady` in the first place, I can't remember?"
+10059,"@@ -439,10 +439,14 @@ function createTopology(mongoClient, topologyType, options, callback) {
+     }
+
+     const MongoClient = loadClient();
+-    const connectionString =
+-      os.platform() === 'win32'
+-        ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
+-        : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    let connectionString;
++    if (mongoClient.s.options.autoEncryption.cryptdConnectionString != null) {
++      connectionString = mongoClient.s.options.autoEncryption.cryptdConnectionString;
++    } else if (os.platform() === 'win32') {
++      connectionString = 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000';
++    } else {
++      connectionString = 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    }
+
+     const mongocryptdClient = new MongoClient(connectionString, { useUnifiedTopology: true });
+     mongocryptdClient.connect(err => {",maybe we can replace `mongoClient.s.options.autoEncryption.cryptdConnectionString` with `options.autoEncryption.cryptdConnectionString`?
+10060,"@@ -3719,9 +3719,11 @@ dr_create_client_thread(void (*func)(void *param), void *arg)
+ #        endif
+     LOG(THREAD, LOG_ALL, 1, ""dr_create_client_thread xsp="" PFX "" dstack="" PFX ""\n"", xsp,
+         get_clone_record_dstack(crec));
++    os_clone_pre(dcontext);
+     thread_id_t newpid =
+         dynamorio_clone(flags, xsp, NULL, IF_X86_ELSE(IF_X64_ELSE(NULL, &desc), NULL),
+                         NULL, client_thread_run);
++    os_clone_post(dcontext);
+     /* i#501 switch to app's tls before creating client thread */
+     if (IF_CLIENT_INTERFACE_ELSE(INTERNAL_OPTION(private_loader), false))
+         os_switch_lib_tls(dcontext, false /*to dr*/);","But we're already doing os_switch_lib_tls to app a few lines above, so there is now redundancy we should alleviate."
+10061,"@@ -52,10 +52,11 @@ namespace Datadog.Trace
+         /// <param name=""parent"">The parent context.</param>
+         /// <param name=""traceContext"">The trace context.</param>
+         /// <param name=""serviceName"">The service name to propagate to child spans.</param>
+-        internal SpanContext(ISpanContext parent, ITraceContext traceContext, string serviceName)
++        /// <param name=""spanId"">The propagated span id.</param>
++        internal SpanContext(ISpanContext parent, ITraceContext traceContext, string serviceName, ulong? spanId = null)
+             : this(parent?.TraceId, serviceName)
+         {
+-            SpanId = SpanIdGenerator.ThreadInstance.CreateNew();
++            SpanId = spanId ?? SpanIdGenerator.ThreadInstance.CreateNew();
+             Parent = parent;
+             TraceContext = traceContext;
+             if (parent is SpanContext spanContext)",Under what circumstance would we have a span id already? Is this for testing purposes?
+10062,"@@ -2986,7 +2986,8 @@ static bool PreCallValidateQueueSubmit(layer_data *dev_data, VkQueue queue, uint
+                     skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT,
+                                     HandleToUint64(semaphore), kVUID_Core_DrawState_QueueForwardProgress,
+                                     ""Queue 0x%"" PRIx64 "" is signaling semaphore 0x%"" PRIx64
+-                                    "" that has already been signaled but not waited on by queue 0x%"" PRIx64 ""."",
++                                    "" that was previously signaled by queue 0x%"" PRIx64
++                                    "" but has not since been waited on by any queue."",
+                                     HandleToUint64(queue), HandleToUint64(semaphore), HandleToUint64(pSemaphore->signaler.first));
+                 } else {
+                     unsignaled_semaphores.erase(semaphore);","The original text can be read to say ""not waited on by queue ..."" meaing that the second queue was supposed to have *waited* for the signal... which is especially confusing when it's the same queue that has signalled the semaphore *twice* without a wait."
+10063,"@@ -136,8 +136,8 @@ func (le *LookupEngine) Lookup(ctx context.Context, a types.Address) (peer.ID, e
+ 	case out := <-ch:
+ 		return out.(peer.ID), nil
+ 	case <-time.After(time.Second * 10):
+-		return """", fmt.Errorf(""timed out waiting for response"")
++		return """", fmt.Errorf(""lookup timed out waiting for response"")
+ 	case <-ctx.Done():
+-		return """", fmt.Errorf(""context cancled"")
++		return """", fmt.Errorf(""lookup failed: context cancled"")
+ 	}
+ }",just clarifying the error messages a bit.
+10064,"@@ -0,0 +1,18 @@
++// <copyright file=""TelemetryRequestTypes.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Telemetry
++{
++    internal static class TelemetryRequestTypes
++    {
++        public const string AppStarted = ""app-started"";
++        public const string AppDependenciesLoaded = ""app-dependencies-loaded"";
++        public const string AppIntegrationsChanged = ""app-integrations-change"";
++        public const string AppHeartbeat = ""app-heartbeat"";
++        public const string AppClosing = ""app-closing"";
++
++        public const string GenerateMetrics = ""generate-metrics"";
++    }
++}",Have those (and other data like conf...) shared across tracers?
+10065,"@@ -0,0 +1,17 @@
++// +build !windows
++
++// Copyright 2020 Antrea Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
++package lib",could we add this file only when we need one?
+10066,"@@ -37,4 +37,7 @@ type Context struct {
+ 	// ACMEHTTP01SolverImage is the image to use for solving ACME HTTP01
+ 	// challenges
+ 	ACMEHTTP01SolverImage string
++	// acmeDNS01ResolvConfFile is an optional custom resolv.conf file for
++	// solve ACME DNS01 challenges
++	ACMEDNS01ResolvConfFile string
+ }",This may not even be needed.
+10067,"@@ -70,6 +70,12 @@ var KnownFields = map[string]bool{
+ 	""Test.Flakiness"": true,
+ 	""Test.Results"":   true, // Recall that unsuccessful test results aren't cached...
+
++	// Debug fields don't contribute to any hash
++	""Debug"":            true,
++	""Debug.Command"":    true,
++	""Debug.tools"":      true,
++	""Debug.namedTools"": true,
++
+ 	// These only contribute to the runtime hash, not at build time.
+ 	""Data"":              true,
+ 	""namedData"":         true,",Capitalisation seems inconsistent here?
+10068,"@@ -1,7 +1,11 @@
+-namespace Nevermind.Core
++using System;
++
++namespace Nevermind.Core
+ {
+     public interface ILogger
+     {
+         void Log(string text);
++        void Debug(string text);
++        void Error(string text, Exception ex = null);
+     }
+ }",maybe better Error(string text) and Error(Exception ex) separately?
+10069,"@@ -58,7 +58,7 @@ func matchingTools(config *core.Configuration, prefix string) map[string]string
+ 		""jarcat"":      config.Java.JarCatTool,
+ 		""javacworker"": config.Java.JavacWorker,
+ 		""junitrunner"": config.Java.JUnitRunner,
+-		""langserver"":  path.Join(config.Please.Location, ""build_langserver""),
++		""lps"":  	   path.Join(config.Please.Location, ""build_langserver""),
+ 		""maven"":       config.Java.PleaseMavenTool,
+ 		""pex"":         config.Python.PexTool,
+ 	}","can you leave the old one in too please? at least for now, otherwise anyone using it now will break."
+10070,"@@ -3501,6 +3501,10 @@ void Player::onAttackedCreature(Creature* target)
+ {
+ 	Creature::onAttackedCreature(target);
+
++	if (target && target->getZone() == ZONE_PVP) {
++		return;
++	}
++
+ 	if (target == this) {
+ 		addInFightTicks();
+ 		return;","Trailing tab, remove it in another PR."
+10071,"@@ -156,6 +156,9 @@ func (w *taskWriter) allocTaskIDs(count int) ([]int64, error) {
+ 		if w.taskIDBlock.start > w.taskIDBlock.end {
+ 			// we ran out of current allocation block
+ 			newBlock, err := w.tlMgr.allocTaskIDBlock(w.taskIDBlock.end)
++			if err != nil && w.tlMgr.errShouldUnload(err) {
++				w.tlMgr.signalFatalProblem(w.tlMgr.taskQueueID)
++			}
+ 			if err != nil {
+ 				return nil, err
+ 			}",what about merging the error checking logic to within `errShouldUnload`?
+10072,"@@ -0,0 +1,6 @@
++class ArticlesController < ApplicationController
++  def index
++    @topic = Topic.find_by_slug(params[:id])
++    @articles = @topic.articles.by_published
++  end
++end",Probably want Topic.find_by_slug! to handle bogus topics. The next line will try to load articles off of nil otherwise.
+10073,"@@ -34,6 +34,11 @@ public:
+     static constexpr std::int64_t column_count = 2;
+     static constexpr std::int64_t element_count = row_count * column_count;
+
++    bool not_available_on_device() {
++        constexpr bool is_svd = std::is_same_v<Method, pca::method::svd>;
++        return get_policy().is_gpu() && is_svd;
++    }
++
+     auto get_descriptor() const {
+         return pca::descriptor<float, Method, pca::task::dim_reduction>{};
+     }",Should it really be done on test side?
+10074,"@@ -350,7 +350,8 @@ func (mtask *managedTask) steadyState() bool {
+ 	}
+ }
+
+-// cleanupCredentials removes credentials for a stopped task
++// cleanupCredentials removes credentials for a stopped task (execution credentials are removed in cleanupTask
++// due to its potential usage in the later phase of the task cleanup such as sending logs)
+ func (mtask *managedTask) cleanupCredentials() {
+ 	taskCredentialsID := mtask.GetCredentialsID()
+ 	if taskCredentialsID != """" {","Can we elaborate on why? I'm guessing because we need the execution role to call FE stopTask during `cleanupTask`, but would be good if we make it clear here."
+10075,"@@ -62,6 +62,10 @@ func newAgentCommand() *cobra.Command {
+ 			if err := opts.validate(args); err != nil {
+ 				klog.Fatalf(""Failed to validate: %v"", err)
+ 			}
++			// Not passing args again as they are already validated and are not used in flow exporter config
++			if err := opts.validateFlowExporterConfig(); err != nil {
++				klog.Fatalf(""Failed to validate flow exporter config: %v"", err)
++			}
+ 			if err := run(opts); err != nil {
+ 				klog.Fatalf(""Error running agent: %v"", err)
+ 			}",is there a reason why this is not called from inside `validate`?
+10076,"@@ -46,7 +46,12 @@ type clientServer struct {
+ // New returns a client/server to bidirectionally communicate with the backend.
+ // The returned struct should have both 'Connect' and 'Serve' called upon it
+ // before being used.
+-func New(url string, cfg *config.Config, credentialProvider *credentials.Credentials, statsEngine stats.Engine, publishMetricsInterval time.Duration) wsclient.ClientServer {
++func New(url string,
++	cfg *config.Config,
++	credentialProvider *credentials.Credentials,
++	statsEngine stats.Engine,
++	publishMetricsInterval time.Duration,
++	rwTimeout time.Duration) wsclient.ClientServer {
+ 	cs := &clientServer{
+ 		statsEngine:            statsEngine,
+ 		publishTicker:          nil,",:+1: I much prefer this style for functions with more than a few arguments.
+10077,"@@ -762,8 +762,7 @@ class CommandLine
+                     }
+                 }
+             }
+-
+-            if (hasQualifiers)
++            else if (hasQualifiers)
+             {
+                 sb.AppendLine().Append(""  Actions:"").AppendLine();
+ ","Are these mutually exclusive options (parameters vs qualifiers)? If parameters aren't supported, may want to consider throwing an exception for ""hasParameters"". If parameters and qualifiers are both legit options, then maybe change this to `if (hasQualifiers) { ... } if(!hasQualifiers && !hasParameters)`"
+10078,"@@ -43,7 +43,6 @@ public class InvocationStartProcessingEventListener implements EventListener {
+     if (InvocationType.PRODUCER.equals(event.getInvocationType())) {
+       ProducerInvocationMonitor monitor = registryMonitor.getProducerInvocationMonitor(event.getOperationName());
+       monitor.getWaitInQueue().increment(-1);
+-      monitor.getLifeTimeInQueue().update(event.getInQueueNanoTime());
+     }
+   }
+ }",Why did you remove this line?
+10079,"@@ -80,6 +80,7 @@ MSG(object_does_not_provide_read_access_to_columns,
+ MSG(object_does_not_provide_write_access_to_columns,
+     ""Given object does not provide write access to columns"")
+ MSG(unsupported_conversion_types, ""Unsupported conversion types"")
++MSG(invalid_indices, ""Invalid indices"")
+
+ /* Ranges */
+ MSG(invalid_range_of_rows, ""Invalid range of rows"")",Very unclear error message. Remember that these are messages that your users see. Please be more specific
+10080,"@@ -39,6 +39,12 @@ const (
+ 	DisablePublicIP         = ""DISABLED""
+ 	PublicSubnetsPlacement  = ""PublicSubnets""
+ 	PrivateSubnetsPlacement = ""PrivateSubnets""
++
++	// RuntimePlatform configuration.
++	linuxOS = ""LINUX""
++	// windowsCoreOS = ""WINDOWS_SERVER_2019_CORE""
++	// windowsFullOS = ""WINDOWS_SERVER_2019_FULL""
++	x86Arch = ""X86_64""
+ )
+
+ // Constants for ARN options.",Can we add these when we need them
+10081,"@@ -460,12 +460,13 @@ class EDS extends DefaultRecord
+      */
+     public function getPrimaryAuthors()
+     {
+-        return array_unique(
+-            $this->extractEbscoDataFromRecordInfo(
+-                'BibRecord/BibRelationships/HasContributorRelationships/*/'
++        $authors = $this->extractEbscoDataFromRecordInfo(
++            'BibRecord/BibRelationships/HasContributorRelationships/*/'
+                 . 'PersonEntity/Name/NameFull'
+-            )
+         );
++        return array_unique(array_filter($authors, function ($a) {
++            return !empty($a);
++        }));
+     }
+
+     /**","I believe you can simplify this to simply `return array_unique(array_filter($authors));` -- the default behavior of array_filter is to filter out empty elements, so the callback should not be required in this situation. Do you mind giving it a try and updating the PR if it works?"
+10082,"@@ -305,6 +305,10 @@ class UIAHandler(COMObject):
+ 			return
+ 		import NVDAObjects.UIA
+ 		obj=NVDAObjects.UIA.UIA(UIAElement=sender)
++		if not obj:
++			# Sometimes notification events can be fired on a UIAElement that has no windowHandle and does not connect through parents back to the desktop.
++			# There is nothing we can do with these.
++			return
+ 		eventHandler.queueEvent(""UIA_notification"",obj, notificationKind=NotificationKind, notificationProcessing=NotificationProcessing, displayString=displayString, activityId=activityId)
+
+ 	def _isUIAWindowHelper(self,hwnd):",Would it make sense to log a debug warning here?
+10083,"@@ -35,14 +35,6 @@ var loginCmd = &cobra.Command{
+ 				os.Exit(1)
+ 			}
+
+-			if err := ks.SetDefault(addr); err != nil {
+-				cmd.Printf(""Given address is not present into keystore.\r\nAvailable addresses:\r\n"")
+-				for _, addr := range ks.List() {
+-					cmd.Println(addr.Address.Hex())
+-				}
+-				return
+-			}
+-
+ 			// ask for password for default key
+ 			pass, err := accounts.NewInteractivePassPhraser().GetPassPhrase()
+ 			if err != nil {","""in the keystore"", but nevermind"
+10084,"@@ -337,7 +337,7 @@ void nano::network::republish_vote (std::shared_ptr<nano::vote> vote_a)
+ void nano::network::broadcast_confirm_req (std::shared_ptr<nano::block> block_a)
+ {
+ 	auto list (std::make_shared<std::vector<nano::peer_information>> (node.peers.representatives (std::numeric_limits<size_t>::max ())));
+-	if (list->empty () || node.peers.total_weight () < node.config.online_weight_minimum.number ())
++	if (list->empty () || node.peers.total_weight () < node.delta ())
+ 	{
+ 		// broadcast request to all peers
+ 		list = std::make_shared<std::vector<nano::peer_information>> (node.peers.list_vector (100));",This should be done in a separate PR.
+10085,"@@ -138,8 +138,9 @@ public class DropPartyPlugin extends Plugin
+ 			{
+ 				continue;
+ 			}
+-			if (Text.standardize(player.getName()).equalsIgnoreCase(playerName))
++			if (player.getName().equalsIgnoreCase(playerName))
+ 			{
++				log.error(""found running player"");
+ 				runningPlayer = player;
+ 				break;
+ 			}",Rather than this maybe `Text.sanitize` would be better here
+10086,"@@ -82,7 +82,7 @@ public class NeighborsMsgSerializer : DiscoveryMsgSerializerBase, IMessageSerial
+             }
+
+             ReadOnlySpan<byte> id = ctx.DecodeByteArraySpan();
+-            return new Node(new PublicKey(id), address);
++            return new Node(new PublicKey(id), address, false);
+         });
+     }
+ }",lot of places setting default 'false' to static value - noise in PR
+10087,"@@ -361,11 +361,19 @@ class Image extends BaseI18nLoop implements PropelSearchLoopInterface
+                 // Dispatch image processing event
+                 $this->dispatcher->dispatch(TheliaEvents::IMAGE_PROCESS, $event);
+
++                $originalImageSize = getimagesize($sourceFilePath);
++
++                $imageSize = getimagesize($event->getCacheFilepath());
++
+                 $loopResultRow
+                     ->set(""IMAGE_URL"", $event->getFileUrl())
+                     ->set(""ORIGINAL_IMAGE_URL"", $event->getOriginalFileUrl())
+                     ->set(""IMAGE_PATH"", $event->getCacheFilepath())
+                     ->set(""PROCESSING_ERROR"", false)
++                    ->set(""IMAGE_WIDH"", $imageSize[0])
++                    ->set(""IMAGE_HEIGHT"", $imageSize[1])
++                    ->set(""ORIGINAL_IMAGE_WIDH"", $originalImageSize[0])
++                    ->set(""ORIGINAL_IMAGE_HEIGHT"", $originalImageSize[1])
+                 ;
+             } catch (\Exception $ex) {
+                 // Ignore the result and log an error",I think you should use `$event->getOriginalFileUrl()` instead of `$sourceFilePath` here.
+10088,"@@ -99,6 +99,7 @@ def run(inventory_index_id,
+     # pylint: disable=too-many-locals
+     global_configs = service_config.get_global_config()
+     notifier_configs = service_config.get_notifier_config()
++    api_quota_configs = notifier_configs.get('api_quota')
+
+     with service_config.scoped_session() as session:
+         if scanner_index_id:","nit: It's a matter of taste, but it would be tighter if this is called `api_quota`."
+10089,"@@ -16,9 +16,10 @@ package org.hyperledger.besu.ethereum.mainnet.precompiles;
+
+ import static org.assertj.core.api.Assertions.assertThat;
+
+-import org.hyperledger.besu.ethereum.core.Gas;
+-import org.hyperledger.besu.ethereum.vm.GasCalculator;
+-import org.hyperledger.besu.ethereum.vm.MessageFrame;
++import org.hyperledger.besu.evm.Gas;
++import org.hyperledger.besu.evm.frame.MessageFrame;
++import org.hyperledger.besu.evm.gascalculator.GasCalculator;
++import org.hyperledger.besu.evm.precompile.AltBN128PairingPrecompiledContract;
+
+ import org.apache.tuweni.bytes.Bytes;
+ import org.junit.Test;",I noticed in all of these we now have to import the PrecompiledContract under testing. Could also rename the package these are in s/precompiles/precompile to keep them in the same package as they are elsewhere.
+10090,"@@ -288,7 +288,7 @@ class SnakebiteHdfsClient(HdfsClient):
+             client_kwargs = dict(filter(lambda (k, v): v is not None and v != '',  {
+                 'hadoop_version': self.config.getint(""hdfs"", ""client_version"", None),
+                 'effective_user': self.config.get(""hdfs"", ""effective_user"", None)
+-            }.items()))
++            }.iteritems()))
+             if self.config.getboolean(""hdfs"", ""snakebite_autoconfig"", False):
+                 """"""
+                 This is fully backwards compatible with the vanilla Client and can be used for a non HA cluster as well.",doubt this matters...
+10091,"@@ -36,6 +36,7 @@ from scapy.automaton import *
+ from scapy.autorun import *
+
+ from scapy.main import *
++from scapy.consts import *
+
+ from scapy.layers.all import *
+ ","Gets updated versions of `LOOPBACK_INTERFACE`, `LOOPBACK_NAME` when importing scapy."
+10092,"@@ -372,7 +372,7 @@ public class SparkTableUtil {
+     try {
+       PartitionSpec spec = SparkSchemaUtil.specForTable(spark, sourceTableIdentWithDB.unquotedString());
+
+-      if (spec == PartitionSpec.unpartitioned()) {
++      if (Objects.equal(spec, PartitionSpec.unpartitioned())) {
+         importUnpartitionedSparkTable(spark, sourceTableIdentWithDB, targetTable);
+       } else {
+         List<SparkPartition> sourceTablePartitions = getPartitions(spark, sourceTableIdent);","checking for ref. equality is probably fine here, but it takes a reader longer to navigate the code and figure out whether ref equality is really wanted here vs just using `equals()`"
+10093,"@@ -60,12 +60,14 @@ type (
+ 		matchingClient           matchingservice.MatchingServiceClient
+ 		config                   *configs.Config
+ 		searchAttributesProvider searchattribute.Provider
++		workflowDeleteManager    workflow.DeleteManager
+ 	}
+ )
+
+ func newTransferQueueTaskExecutorBase(
+ 	shard shard.Context,
+ 	historyEngine *historyEngineImpl,
++	workflowDeleteManager workflow.DeleteManager,
+ 	logger log.Logger,
+ 	metricsClient metrics.Client,
+ 	config *configs.Config,",looks like it's not used? Do we plan to use it in the future?
+10094,"@@ -34,8 +34,8 @@ import (
+ )
+
+ type (
+-	// Config supports common options that apply to statsd exporters.
+-	Config struct {
++	// Options supports common options that apply to statsd exporters.
++	Options struct {
+ 		// URL describes the destination for exporting statsd data.
+ 		// e.g., udp://host:port
+ 		//       tcp://host:port","I think this is an unrelated remark. I thought we had moved toward the practice of using ""Config"" as the structure name, and Option as a functional argument (`func(*Config)`), and Options as a `[]Option`. See api/trace `StartConfig` and `StartOption`, for example. That's why I prefer this struct be called Config."
+10095,"@@ -2,7 +2,8 @@ import random
+ import string
+
+ from kinto.core.storage import generators, exceptions
+-from pyramid import httpexceptions
++from pyramid.httpexceptions import (HTTPNotFound)
++from kinto.core.errors import http_error, ERRORS
+
+
+ class NameGenerator(generators.Generator):",nitpick: superfluous parenthesis
+10096,"@@ -219,6 +219,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         private static void DecorateSpan(Span span, GraphQLTags tags)
+         {
+             span.Type = SpanTypes.GraphQL;
++            span.SetMetric(Tags.Measured, 1);
+         }
+
+         private static Scope CreateScopeFromValidate(object document)","If, for a given integration, the tag/measure is always set, it should be added to the strongly-typed tags (here for instance, in GraphQLTags). This way, the underlying dictionary is allocated only in the rare case where users add custom tags"
+10097,"@@ -243,12 +243,12 @@ func ExecuteContract(
+ 	if err := stateDB.CommitContracts(); err != nil {
+ 		return nil, nil, errors.Wrap(err, ""failed to commit contracts to underlying db"")
+ 	}
+-	stateDB.clear()
+ 	receipt.AddLogs(stateDB.Logs()...).AddTransactionLogs(depositLog, burnLog)
+ 	if receipt.Status == uint64(iotextypes.ReceiptStatus_Success) ||
+ 		featureCtx.AddOutOfGasToTransactionLog && receipt.Status == uint64(iotextypes.ReceiptStatus_ErrCodeStoreOutOfGas) {
+ 		receipt.AddTransactionLogs(stateDB.TransactionLogs()...)
+ 	}
++	stateDB.clear()
+
+ 	if featureCtx.SetRevertMessageToReceipt && receipt.Status == uint64(iotextypes.ReceiptStatus_ErrExecutionReverted) && retval != nil && bytes.Equal(retval[:4], revertSelector) {
+ 		// in case of the execution revert error, parse the retVal and add to receipt",The position change of this line may be a hard fork.
+10098,"@@ -541,12 +541,7 @@ void Items::buildInventoryList()
+
+ void Items::parseItemNode(const pugi::xml_node& itemNode, uint16_t id)
+ {
+-	if (id > 30000 && id < 30100) {
+-		id -= 30000;
+-
+-		if (id >= items.size()) {
+-			items.resize(id + 1);
+-		}
++	if (id > 0 && id < 100) {
+ 		ItemType& iType = items[id];
+ 		iType.id = id;
+ 	}",id is unsigned
+10099,"@@ -13,6 +13,7 @@ Puppet::Functions.create_function(:run_command) do
+   # @param options A hash of additional options.
+   # @option options [Boolean] _catch_errors Whether to catch raised errors.
+   # @option options [String] _run_as User to run as using privilege escalation.
++  # @option options [Hash] _env_vars Map of environment variables to set
+   # @return A list of results, one entry per target.
+   # @example Run a command on targets
+   #   run_command('hostname', $targets, '_catch_errors' => true)",It looks like Puppet doesn't provide type validation for options and we don't provide it ourselves as part of the function. Is that something we'd want to do at some point?
+10100,"@@ -26,7 +26,8 @@ import org.apache.iceberg.io.CloseableIterable;
+ class StaticTableScan extends BaseTableScan {
+   private final Function<StaticTableScan, DataTask> buildTask;
+
+-  StaticTableScan(TableOperations ops, Table table, Schema schema, Function<StaticTableScan, DataTask> buildTask) {
++  StaticTableScan(TableOperations ops, Table table, Schema schema,
++                  Function<StaticTableScan, DataTask> buildTask) {
+     super(ops, table, schema);
+     this.buildTask = buildTask;
+   }",Looks like this didn't need to change.
+10101,"@@ -595,6 +595,10 @@ class PyLinter(config.OptionsManagerMixIn,
+             for msg_id in self._checker_messages('python3'):
+                 if msg_id.startswith('E'):
+                     self.enable(msg_id)
++            config_parser = self.cfgfile_parser
++            if config_parser.has_option('MESSAGES CONTROL', 'disable'):
++                value = config_parser.get('MESSAGES CONTROL', 'disable')
++                self.global_set_option('disable', value)
+         else:
+             self.disable('python3')
+         self.set_option('reports', False)",I don't understand why this is here and what's the intention with it? Can you elaborate what's the reasoning behind this change?
+10102,"@@ -25,13 +25,13 @@ package sqlplugin
+ import ""database/sql""
+
+ type (
+-	// historyShard is the SQL persistence interface for history shards
+-	historyShard interface {
++	// HistoryShard is the SQL persistence interface for history shards
++	HistoryShard interface {
+ 		InsertIntoShards(rows *ShardsRow) (sql.Result, error)
+ 		UpdateShards(row *ShardsRow) (sql.Result, error)
+ 		SelectFromShards(filter *ShardsFilter) (*ShardsRow, error)
+-		ReadLockShards(filter *ShardsFilter) (int, error)
+-		WriteLockShards(filter *ShardsFilter) (int, error)
++		ReadLockShards(filter *ShardsFilter) (int64, error)
++		WriteLockShards(filter *ShardsFilter) (int64, error)
+ 	}
+
+ 	// historyEvent is the SQL persistence interface for history nodes and history trees",I think @sergeybykov converted (wanted to convert) all `shardID` to `int32` from `int64`. Please check with him.
+10103,"@@ -2289,7 +2289,8 @@ void ProtocolGame::sendCreatureHealth(const Creature* creature)
+ 	if (creature->isHealthHidden()) {
+ 		msg.addByte(0x00);
+ 	} else {
+-		msg.addByte(std::ceil((static_cast<double>(creature->getHealth()) / std::max<int32_t>(creature->getMaxHealth(), 1)) * 100));
++		int32_t maxHealth = std::max(creature->getMaxHealth(), 1);
++		msg.addByte(std::ceil((static_cast<double>(std::min(creature->getHealth(), maxHealth)) / maxHealth) * 100));
+ 	}
+ 	writeToOutputBuffer(msg);
+ }",This will only fix client side (so showing it in-game) server still gonna hold invalid values I guess?
+10104,"@@ -287,6 +287,18 @@ class Dataset(Element):
+         class to each underlying element.
+         """"""
+         if isinstance(data, DynamicMap):
++            class_name = cls.__name__
++            repr_kdims = 'kdims=%r' % kdims if kdims else None
++            repr_vdims = 'vdims=%r' % vdims if vdims else None
++            repr_kwargs = (', '.join('%s=%r' % (k,v) for k,v in kwargs.items())
++                           if kwargs else None)
++            extras = ', '.join([el for el in [repr_kdims, repr_vdims, repr_kwargs]
++                               if el is not None])
++            extras = ', ' + extras if extras else ''
++            apply_args= 'hv.{class_name}{extras}'.format(class_name=class_name,
++                                                         extras=extras)
++            msg = ""Cannot construct a {class_name} from the supplied object of type DynamicMap. Implicitly creating a DynamicMap of {class_name} objects, but instead please explicitly call .apply({apply_args}) on the supplied DynamicMap.""
++            cls.warning(cls, msg.format(class_name=class_name, apply_args=apply_args))
+             return data.apply(cls, per_element=True, kdims=kdims, vdims=vdims, **kwargs)
+         else:
+             return super(Dataset, cls).__new__(cls)",Shouldn't this be `cls.param.warning`?
+10105,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)"
+10106,"@@ -107,9 +107,14 @@ class ServerConnectionMixin:
+         """"""
+         address = self.server_conn.address
+         if address:
++            forbidden_hosts = [""localhost"", ""127.0.0.1"", ""::1""]
++
++            if self.config.options.listen_host:
++                forbidden_hosts.append(self.config.options.listen_host)
++
+             self_connect = (
+                 address[1] == self.config.options.listen_port and
+-                address[0] in (""localhost"", ""127.0.0.1"", ""::1"")
++                address[0] in forbidden_hosts
+             )
+             if self_connect:
+                 raise exceptions.ProtocolException(","Could we not just always include `self.config.options.listen_host`? If that is empty, the `address[0]` check should also never be true."
+10107,"@@ -102,8 +102,8 @@ public class DataFilesTable extends BaseMetadataTable {
+     }
+
+     @Override
+-    protected long targetSplitSize(TableOperations ops) {
+-      return ops.current().propertyAsLong(
++    public long targetSplitSize() {
++      return tableOps().current().propertyAsLong(
+           TableProperties.METADATA_SPLIT_SIZE, TableProperties.METADATA_SPLIT_SIZE_DEFAULT);
+     }
+ ",Why not just access `ops` directly like before?
+10108,"@@ -389,17 +389,13 @@ void Creature::onRemoveTileItem(const Tile* tile, const Position& pos, const Ite
+ 	}
+ }
+
+-void Creature::onCreatureAppear(Creature* creature, bool isLogin)
++void Creature::onCreatureAppear(Creature* creature, bool)
+ {
+ 	if (creature == this) {
+ 		if (useCacheMap()) {
+ 			isMapLoaded = true;
+ 			updateMapCache();
+ 		}
+-
+-		if (isLogin) {
+-			setLastPosition(getPosition());
+-		}
+ 	} else if (isMapLoaded) {
+ 		if (creature->getPosition().z == getPosition().z) {
+ 			updateTileCache(creature->getTile(), creature->getPosition());",Is there even a need to keep the bool?
+10109,"@@ -42,7 +42,7 @@ class HotgymRegressionTest(unittest.TestCase):
+
+   def testHotgymRegression(self):
+     experimentDir = os.path.join(
+-      os.path.dirname(__file__).partition(""tests/integration/nupic/opf"")[0],
++      os.path.dirname(__file__).partition(os.path.normpath(""tests/integration/nupic/opf""))[0],
+       ""examples"", ""opf"", ""experiments"", ""multistep"", ""hotgym"")
+
+     resultsDir = os.path.join(experimentDir, ""inference"")",wrap to stay under 80 characters
+10110,"@@ -67,6 +67,7 @@ shared_ptr<Layer<Dtype> > GetConvolutionLayer(
+ #endif
+   } else {
+     LOG(FATAL) << ""Layer "" << param.name() << "" has unknown engine."";
++    throw;  // Avoids missing return warning
+   }
+ }
+ ","`return NULL` is more clear than `throw` at least in my reading, and consistent with #3362."
+10111,"@@ -87,8 +87,6 @@ class LocustIOExecutor(ScenarioExecutor, WidgetProvider, FileLister, HavingInsta
+
+         wrapper = os.path.join(get_full_path(__file__, step_up=2), ""resources"", ""locustio-taurus-wrapper.py"")
+
+-        self.env.add_path({""PYTHONPATH"": self.engine.artifacts_dir})
+-        self.env.add_path({""PYTHONPATH"": os.getcwd()})
+         self.env.set({""LOCUST_DURATION"": dehumanize_time(load.duration)})
+
+         self.log_file = self.engine.create_artifact(""locust"", "".log"")","Both of these are important. Without it, locust won't find my libraries in the cloud."
+10112,"@@ -87,7 +87,7 @@ func (o *listSvcOpts) Execute() error {
+ 		return fmt.Errorf(""get application: %w"", err)
+ 	}
+
+-	svcs, err := o.store.ListServices(o.appName)
++	svcs, err := o.store.ListWorkloads(o.appName)
+ 	if err != nil {
+ 		return err
+ 	}",This should remain as `ListServices`
+10113,"@@ -0,0 +1,2 @@
++package v2
++","If no tests, remove this file."
+10114,"@@ -116,7 +116,7 @@ cp bin/protoc /usr/local/bin/protoc
+     if SHOULD_INVENTORY_GROUPS:
+         GROUPS_DOMAIN_SUPER_ADMIN_EMAIL = context.properties[
+             'groups-domain-super-admin-email']
+-        GROUPS_SERVICE_ACCOUNT_KEY_FILE = context.properties[
++        GSUITE_SERVICE_ACCOUNT_KEY_FILE = context.properties[
+             'groups-service-account-key-file']
+
+         # TODO: remove this in a future version",This will require changes to the docs. I suggest searching the gh-pages branch for the previous variable name.
+10115,"@@ -249,7 +249,7 @@ class RemoteHandler(logging.Handler):
+
+ 	def __init__(self):
+ 		#Load nvdaHelperRemote.dll but with an altered search path so it can pick up other dlls in lib
+-		path=os.path.abspath(os.path.join(u""lib"",buildVersion.version,u""nvdaHelperRemote.dll""))
++		path = os.path.join(globalVars.appDir, ""lib"", buildVersion.version, ""nvdaHelperRemote.dll"")
+ 		h=ctypes.windll.kernel32.LoadLibraryExW(path,0,LOAD_WITH_ALTERED_SEARCH_PATH)
+ 		if not h:
+ 			raise OSError(""Could not load %s""%path) ",`RemoteHandler` is used in nvda_slave and slave does not have access to `globalVars` currently. Perhaps `globalVars.appDir` should be set to `None` in `globalVarrs by default and set to NVDA directory when they're imported for the first time.
+10116,"@@ -12,10 +12,11 @@ type MetricsConfig struct {
+ }
+
+ type FileConfig struct {
+-	Prometheus *PrometheusConfig `hcl:""Prometheus""`
+-	DogStatsd  []DogStatsdConfig `hcl:""DogStatsd""`
+-	Statsd     []StatsdConfig    `hcl:""Statsd""`
+-	M3         []M3Config        `hcl:""M3""`
++	Prometheus   *PrometheusConfig `hcl:""Prometheus""`
++	DogStatsd    []DogStatsdConfig `hcl:""DogStatsd""`
++	Statsd       []StatsdConfig    `hcl:""Statsd""`
++	M3           []M3Config        `hcl:""M3""`
++	DisableInMem bool              `hcl:""DisableInMem""`
+ }
+
+ type DogStatsdConfig struct {","In case there is more configuration to be added to the ""inmem"" metrics later (however unlikely that is), we may want to play it safe and create an `InMemConfig` struct and include the disabled flag there. This also gives the config symmetry across the plugins."
+10117,"@@ -35,6 +35,16 @@ describe ProposalSearch do
+     end
+
+     context Gsa18f::Procurement do
++      around(:each) do |example|
++        ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'
++        ENV['GSA18F_PURCHASER_EMAIL'] = 'test_purchaser@some-dot-gov.gov'
++        example.run
++
++        ENV['GSA18F_APPROVER_EMAIL'] = nil
++        ENV['GSA18F_PURCHASER_EMAIL'] = nil
++      end
++
++
+       [:product_name_and_description, :justification, :additional_info].each do |attr_name|
+         it ""returns the Proposal when searching by the ##{attr_name}"" do
+           procurement = FactoryGirl.create(:gsa18f_procurement, attr_name => 'foo')",I'll need to pull this out of here since we're sharing this in other tests. Same for `procurement_spec.rb`
+10118,"@@ -6,7 +6,7 @@ class ObservationsController < ApplicationController
+
+   def create
+     obs = @proposal.add_observer(observer_email, current_user, params[:observation][:reason])
+-    flash[:success] = ""#{obs.user.full_name} has been added as an observer""
++    prep_create_response_msg(obs)
+     redirect_to proposal_path(@proposal)
+   end
+ ","what about `observer` as a var name here (and below) rather than `obs` ? -- would be clearer, imo!"
+10119,"@@ -110,7 +110,7 @@ class ErrorHandler(object):
+                             value = message
+                             try:
+                                 message = message['message']
+-                            except TypeError:
++                            except KeyError:
+                                 message = None
+                     else:
+                         message = value.get('message', None)",could you change this to instead of being a `try.. except` be `message = message.get('message')`
+10120,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities
+ {
+     using System;",Add space between License and nameapace
+10121,"@@ -0,0 +1,15 @@
++class ProfileController < ApplicationController
++  def show
++  end
++
++  def update
++    first_name = params[:first_name]
++    last_name = params[:last_name]
++    user = current_user
++    user.first_name = first_name
++    user.last_name = last_name
++    user.save!
++    flash[:success] = ""Your profile is updated!""
++    redirect_to :me
++  end
++end",should we have a `before_filter` for auth here?
+10122,"@@ -575,6 +575,17 @@ func (r *AWSMachineReconciler) reconcileLBAttachment(machineScope *scope.Machine
+ 	// In order to prevent sending request to a ""not-ready"" control plane machines, it is required to remove the machine
+ 	// from the ELB as soon as the machine gets deleted or when the machine is in a not running state.
+ 	if !machineScope.AWSMachine.DeletionTimestamp.IsZero() || !machineScope.InstanceIsRunning() {
++		registered, err := elbsvc.InstanceIsRegisteredWithAPIServerELB(i)
++		if err != nil {
++			r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""FailedDetachControlPlaneELB"",
++				""Failed to deregister control plane instance %q from load balancer: failed to determine registration status: %v"", i.ID, err)
++			return errors.Wrapf(err, ""could not deregister control plane instance %q from load balancer - error determining registration status"", i.ID)
++		}
++		if !registered {
++			// Already deregistered - nothing more to do
++			return nil
++		}
++
+ 		if err := elbsvc.DeregisterInstanceFromAPIServerELB(i); err != nil {
+ 			r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""FailedDetachControlPlaneELB"",
+ 				""Failed to deregister control plane instance %q from load balancer: %v"", i.ID, err)","@vincepri I know we discussed moving this up and only calling it once, but I didn't (quickly) see an easy way to generate the right event based on the appropriate action (attach vs detach). Happy to move it around if you have suggestions."
+10123,"@@ -0,0 +1,15 @@
++class TsearchHooks
++  def after_save(record)
++    record.class.where(id: record).update_all(
++      ""vector = #{ vector(record) }, popularity_factor = #{ record.searchable_factor }"")
++  end
++
++  def vector(record)
++    weighted_sql = []
++    record.searchable_vector.each do |weight, attr_value|
++      attr_value.gsub!(/['?\\:]/, ' ')
++      weighted_sql << ""setweight(to_tsvector(coalesce('#{attr_value}')), '#{weight.upcase}')""
++    end
++    weighted_sql.join(' ||')
++  end
++end",Can we use record.update here?
+10124,"@@ -243,7 +243,7 @@ func (rw *responseWriter) Close() error {
+ 			retErr = appendError(retErr, fmt.Errorf(""SetApplicationError() failed: %v"", err))
+ 		}
+ 	}
+-	retErr = appendError(retErr, writeHeaders(rw.format, rw.headers, rw.response.Arg2Writer))
++	retErr = appendError(retErr, writeHeaders(rw.format, rw.headers.Items(), rw.response.Arg2Writer))
+
+ 	// Arg3Writer must be opened and closed regardless of if there is data
+ 	// However, if there is a system error, we do not want to do this",Shouldn't the exact case option matter here?
+10125,"@@ -184,7 +184,7 @@ def Derived(parent_cls):
+             n = luigi.IntParameter()
+             # ...
+
+-        class MyTask(luigi.uti.Derived(AnotherTask)):
++        class MyTask(luigi.util.Derived(AnotherTask)):
+             def requires(self):
+                return self.parent_obj
+             def run(self):","Errr, why haven't we noticed this until now?"
+10126,"@@ -456,7 +456,11 @@ public final class Lucene50PostingsFormat extends PostingsFormat {
+   @Override
+   public FieldsConsumer fieldsConsumer(SegmentWriteState state) throws IOException {
+     PostingsWriterBase postingsWriter = new Lucene50PostingsWriter(state);
+-    state.segmentInfo.putAttribute(MODE_KEY, fstLoadMode.name());
++    final String previous = state.segmentInfo.putAttribute(MODE_KEY, fstLoadMode.name());
++    if (previous != null && previous.equals(fstLoadMode.name()) == false) {
++      throw new IllegalStateException(""found existing value for "" + MODE_KEY + "" for segment: "" + state.segmentInfo.name +
++          ""old="" + previous + "", new="" + fstLoadMode.name());
++    }
+     boolean success = false;
+     try {
+       FieldsConsumer ret = new BlockTreeTermsWriter(state, ","It's a little spooky that this method throws exception if you try to set the attribute to a different value than it was set before, but then does leave the new value set in the attributes?"
+10127,"@@ -48,7 +48,7 @@ public class PodDBAdapter {
+
+     private static final String TAG = ""PodDBAdapter"";
+     public static final String DATABASE_NAME = ""Antennapod.db"";
+-    public static final int VERSION = 1090000;
++    public static final int VERSION = 1091000;
+
+     /**
+      * Maximum number of arguments for IN-operator.",Please only increment by 1.
+10128,"@@ -348,7 +348,7 @@ namespace Microsoft.Rest.Generator.Java
+             else if (primaryType == PrimaryType.TimeSpan ||
+                 primaryType.Name == ""Period"")
+             {
+-                return ""java.time.Period"";
++                return ""org.joda.time.Period"";
+             }
+             else
+             {","Sorry I might have missed some context, but what's the reason you choose `Period` over `Duration` or `Interval`? (Thumbs up for using `org.joda.time` instead!)"
+10129,"@@ -2359,6 +2359,19 @@ DefaultSettings.prototype = {
+    */
+   preventOverflow: false,
+
++  /**
++   * Prevents wheel event on overlays for doing default action.
++   *
++   * @type {Boolean}
++   * @default false
++   *
++   * @example
++   * ```js
++   * preventWheel: false,
++   * ```
++   */
++  preventWheel: false,
++
+   /**
+    * @description
+    * Enables the functionality of the {@link BindRowsWithHeaders} plugin which allows binding the table rows with their headers.",Please check if is it possible to mark it as private. What's more please add this to the TypeScript definition file.
+10130,"@@ -28,6 +28,10 @@ static std::string GeneratedFileName(const std::string &path,
+   return path + file_name + ""_generated.h"";
+ }
+
++char ToUpper(char c) {
++  return static_cast<char>(::toupper(c));
++}
++
+ namespace cpp {
+ class CppGenerator : public BaseGenerator {
+  public:",Maybe move this to `util.h` ?
+10131,"@@ -4,7 +4,8 @@
+
+ package Example
+
+-import ""github.com/google/flatbuffers/go""
++#include ""flatbuffers/grpc.h""
++
+
+ import (
+   context ""golang.org/x/net/context""",oops. this won't work will it
+10132,"@@ -208,12 +208,16 @@ func (extra ExtraMetadataV3) IsReaderKeyBundleNew() bool {
+ // must be done separately.
+ func MakeInitialRootMetadataV3(tlfID tlf.ID, h tlf.Handle) (
+ 	*RootMetadataV3, error) {
+-	if tlfID.Type() != h.Type() {
++	switch {
++	case h.TypeForKeying() == tlf.TeamKeying && tlfID.Type() != tlf.SingleTeam:
++		fallthrough
++	case h.TypeForKeying() != tlf.TeamKeying && tlfID.Type() != h.Type():
+ 		return nil, errors.New(""TlfID and TlfHandle disagree on TLF type"")
++	default:
+ 	}
+
+ 	var writers []keybase1.UserOrTeamID
+-	if tlfID.Type() != tlf.Private {
++	if h.TypeForKeying() != tlf.PrivateKeying {
+ 		writers = make([]keybase1.UserOrTeamID, len(h.Writers))
+ 		copy(writers, h.Writers)
+ 	}",@strib I assumed this is what you meant; but let me know if I'm wrong!
+10133,"@@ -106,7 +106,7 @@ func (wh *WorkflowNilCheckHandler) DeprecateNamespace(ctx context.Context, reque
+
+ // StartWorkflowExecution starts a new long running workflow instance.  It will create the instance with
+ // 'WorkflowExecutionStarted' event in history and also schedule the first WorkflowTask for the worker to make the
+-// first decision for this instance.  It will return 'WorkflowExecutionAlreadyStartedError', if an instance already
++// first command for this instance.  It will return 'WorkflowExecutionAlreadyStartedError', if an instance already
+ // exists with same workflowId.
+ func (wh *WorkflowNilCheckHandler) StartWorkflowExecution(ctx context.Context, request *workflowservice.StartWorkflowExecutionRequest) (_ *workflowservice.StartWorkflowExecutionResponse, retError error) {
+ 	resp, err := wh.parentHandler.StartWorkflowExecution(ctx, request)",I believe the error has changed
+10134,"@@ -41,6 +41,16 @@ module Blacklight
+       self.class.new(params || ActionController::Parameters.new, blacklight_config, controller)
+     end
+
++    ##
++    # Check if the query has any constraints defined (a query, facet, etc)
++    #
++    # @return [Boolean]
++    # rubocop:disable Style/PredicateName
++    def has_constraints?
++      params[:q].present? || params[:f].present?
++    end
++    # rubocop:enable Style/PredicateName
++
+     ##
+     # Extension point for downstream applications
+     # to provide more interesting routing to",Lint/UnneededDisable: Unnecessary disabling of Naming/PredicateName.
+10135,"@@ -58,6 +58,8 @@ describe ProposalsController do
+       end
+
+       it 'should redirect random users' do
++        skip ""flaky spec""
++
+         proposal = FactoryGirl.create(:proposal)
+         get :show, id: proposal.id
+         expect(response).to redirect_to(proposals_path)",Should this be removed now?
+10136,"@@ -25,6 +25,8 @@ public abstract class MockGrpcMethodView {
+
+   public abstract String responseTypeName();
+
++  public abstract String streamHandle();
++
+   public abstract GrpcStreamingType grpcStreamingType();
+
+   public static Builder newBuilder() {",streamHandle sounds vague to me. Can you be more specific?
+10137,"@@ -736,7 +736,8 @@ Cursor.prototype._initializeCursor = function(callback) {
+       return;
+     }
+
+-    server.command(cursor.ns, cursor.cmd, cursor.options, queryCallback);
++    const commandOptions = Object.assign({}, cursor.options, cursor.cursorState);
++    server.command(cursor.ns, cursor.cmd, commandOptions, queryCallback);
+   });
+ };
+ ",Does everything on cursorState belong in the command options?
+10138,"@@ -559,7 +559,7 @@ func (m *MatchNot) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
+ 	for d.Next() {
+ 		var mp matcherPair
+ 		matcherMap := make(map[string]RequestMatcher)
+-		for d.NextBlock(0) {
++		for d.NextArg() || d.NextBlock(0) {
+ 			matcherName := d.Val()
+ 			mod, err := caddy.GetModule(""http.matchers."" + matcherName)
+ 			if err != nil {","This is clever, but I do admit I think it's kinda weird. We can go with it for now and fix it later if people complain."
+10139,"@@ -31,7 +31,9 @@ import (
+ )
+
+ var (
+-	gsRegex = regexp.MustCompile(`^gs://([a-z0-9][-_.a-z0-9]*)/(.+)$`)
++	bucket = `([a-z0-9][-_.a-z0-9]*)`
++	bucketRegex = regexp.MustCompile(fmt.Sprintf(`^gs://%s/?$`, bucket))
++	gsRegex = regexp.MustCompile(fmt.Sprintf(`^gs://%s/(.+)$`, bucket))
+ )
+
+ // StorageClient implements domain.StorageClientInterface. It implements main Storage functions","the variable names are not entirely clear. ""bucket"" is essentially the regex that follows gcs naming pattern, right? if so, it should be changed to bucketregex. and then bucketregex, gsregex should be changed to something more specific to what pattern the regex is supposed to match."
+10140,"@@ -26,8 +26,8 @@ import com.google.common.collect.Lists;
+ import java.util.List;
+
+ /** Responsible for producing package meta-data related views for Java GAPIC clients */
+-public class JavaGapicPackageTransformer extends JavaPackageTransformer
+-    implements ModelToViewTransformer {
++public class JavaGapicPackageTransformer<T extends ApiModel> extends JavaPackageTransformer
++    implements ModelToViewTransformer<T> {
+   private final PackageMetadataConfig packageConfig;
+
+   public JavaGapicPackageTransformer(PackageMetadataConfig packageConfig) {",I think `ApiModelT` would be clearer than `T`
+10141,"@@ -1,6 +1,5 @@
+-// $Id$
+ //
+-//  Copyright (C) 2004-2008 Greg Landrum and Rational Discovery LLC
++//  Copyright (C) 2004-2016 Greg Landrum and Rational Discovery LLC
+ //
+ //   @@ All Rights Reserved @@
+ //  This file is part of the RDKit.",Shouldn't this be 2019?
+10142,"@@ -30,6 +30,8 @@ public enum Status {
+   SUCCEEDED(50),
+   KILLING(55),
+   KILLED(60),
++  // POD_FAILED refers to a failed containerized flow due to pod failure
++  POD_FAILED(65),
+   FAILED(70),
+   FAILED_FINISHING(80),
+   SKIPPED(90),","We should consider giving this state a more generic name which could be used for flows in similar state in non-containerized Azkban. For instance in the event of a bare-metal executor crashing we could the switch any flows assigned to that executor to this state. Something like `EXECUTE_INFRA_FAILED`, better alternatives should be possible though."
+10143,"@@ -4,8 +4,12 @@ var bad = [],
+
+ virtualNode.children.forEach(({ actualNode }) => {
+ 	var nodeName = actualNode.nodeName.toUpperCase();
+-	if (actualNode.nodeType === 1 && nodeName !== 'DT' && nodeName !== 'DD' && permitted.indexOf(nodeName) === -1) {
+-		bad.push(actualNode);
++
++	if (actualNode.nodeType === 1 && permitted.indexOf(nodeName) === -1) {
++		var role = (actualNode.getAttribute('role') || '').toLowerCase();
++		if ((nodeName !== 'DT' && nodeName !== 'DD') || role) {
++			bad.push(actualNode);
++		}
+ 	} else if (actualNode.nodeType === 3 && actualNode.nodeValue.trim() !== '') {
+ 		hasNonEmptyTextNode = true;
+ 	}","This should allow `role=definition` and `role=term`, possibly also `role=list`?"
+10144,"@@ -511,6 +511,19 @@ public class Spark3Util {
+             TableProperties.PARQUET_BATCH_SIZE, TableProperties.PARQUET_BATCH_SIZE_DEFAULT));
+   }
+
++  public static Boolean propertyAsBoolean(CaseInsensitiveStringMap options, String property, Boolean defaultValue) {
++    if (defaultValue != null) {
++      return options.getBoolean(property, defaultValue);
++    }
++
++    String value = options.get(property);
++    if (value != null) {
++      return Boolean.parseBoolean(value);
++    }
++
++    return null;
++  }
++
+   public static Long propertyAsLong(CaseInsensitiveStringMap options, String property, Long defaultValue) {
+     if (defaultValue != null) {
+       return options.getLong(property, defaultValue);",Should this use `boolean` instead of `Boolean`?
+10145,"@@ -135,7 +135,6 @@ namespace OpenTelemetry.Exporter.Zipkin.Tests
+         [Theory]
+         [InlineData(true, false, false)]
+         [InlineData(false, false, false)]
+-        [InlineData(false, true, false)]
+         [InlineData(false, false, true)]
+         [InlineData(false, false, false, StatusCode.Ok)]
+         [InlineData(false, false, false, StatusCode.Ok, null, true)]","Currently in our Zipkin tests, only one passed parameter would instantiate a Resource and checks for its tags populating. I left the If(UseTestResource) clause in the code in case we would like to return to the old resource tag checking, but if it makes more sense I can remove that parameter entirely."
+10146,"@@ -944,6 +944,11 @@ public class ZkStateReader implements SolrCloseable {
+     return null;
+   }
+
++  public boolean isNodeLive(String node) {
++    return liveNodes.contains(node);
++
++  }
++
+   /**
+    * Get shard leader properties, with retry if none exist.
+    */","While this is potentially convenient it seems off topic for the PR/Issue. Also if it is kept, in the realm of taste/style I tend to not use get/set/is for things that are not properties of the object. maybe hasLiveNode(String node) thus someone using it might write `if (zkReader.hasLiveNode(""foo"")) ...` which reads quite nicely."
+10147,"@@ -10,11 +10,13 @@ import (
+ )
+
+ var (
+-	svidPath    = path.Join(ProjectRoot(), ""test/fixture/certs/svid.pem"")
+-	svidKeyPath = path.Join(ProjectRoot(), ""test/fixture/certs/svid_key.pem"")
+-	caPath      = path.Join(ProjectRoot(), ""test/fixture/certs/ca.pem"")
+-	caKeyPath   = path.Join(ProjectRoot(), ""test/fixture/certs/ca_key.pem"")
+-	bundlePath  = path.Join(ProjectRoot(), ""test/fixture/certs/bundle.der"")
++	svidPath     = path.Join(ProjectRoot(), ""test/fixture/certs/svid.pem"")
++	svidKeyPath  = path.Join(ProjectRoot(), ""test/fixture/certs/svid_key.pem"")
++	caPath       = path.Join(ProjectRoot(), ""test/fixture/certs/ca.pem"")
++	caKeyPath    = path.Join(ProjectRoot(), ""test/fixture/certs/ca_key.pem"")
++	bundlePath   = path.Join(ProjectRoot(), ""test/fixture/certs/bundle.der"")
++	blogCsrPath  = path.Join(ProjectRoot(), ""test/fixture/certs/blog_csr.pem"")
++	blogSvidPath = path.Join(ProjectRoot(), ""test/fixture/certs/blog_cert.pem"")
+ )
+
+ // LoadCAFixture reads, parses, and returns the pre-defined CA fixture and key",What's the difference between blogSvid and the SVID above? Looks like the functions that use these aren't being called currently - can they be removed?
+10148,"@@ -67,7 +67,7 @@ namespace Nethermind.Serialization.Json
+                 return (long) reader.Value;
+             }
+
+-            string s = (string) reader.Value;
++            string s = reader.Value?.ToString();
+             if (s == ""0x0"")
+             {
+                 return BigInteger.Zero;",can you add numbers with this change? the CLI is a javascript engine and it can worh number - java adds strings vi concatenation
+10149,"@@ -116,6 +116,8 @@ class OrderDirective
+                 // Note the `lower()` in the `addOrderBy()`. It is essential to sorting the
+                 // results correctly. See also https://github.com/bolt/core/issues/1190
+                 // again: lower breaks postgresql jsonb compatibility, first cast as txt
++                // cast as TEXT or CHAR, depending on SQL support. See Bolt\Doctrine\Query\Cast.php
++                // and https://github.com/bolt/core/issues/2241
+                 $query
+                     ->getQueryBuilder()
+                     ->addOrderBy('lower(CAST(' . $translationsAlias . '.value as TEXT))', $direction);","Shouldn't this `TEXT` also be dependent on the platform, then?"
+10150,"@@ -17,6 +17,15 @@ type Typer interface {
+ 	Type() semantic.MonoType
+ }
+
++// ITableObject serves as sort of a ""marker trait"" to allow us to check if a
++// value is a TableObject without having to import TableObject which would be a
++// cyclical import.
++// Identical purpose to the interface in the interpreter package, but sadly we
++// can't import it here because of yet another potential cycle.
++type ITableObject interface {
++	TableObject()
++}
++
+ type Value interface {
+ 	Typer
+ 	IsNull() bool","Can we name this `TableObject`? I'm not a big fan of the `I` prefix for interfaces and that's not really used in Go. Is it also possible to have the method be unexported? I don't know if that's possible. If it's not, this is good. If it is possible, I'd prefer this method to be unexported."
+10151,"@@ -31,11 +31,15 @@
+     #include <stdlib.h> // malloc and free
+     #include <tbb/tbb.h>
+     #include <tbb/spin_mutex.h>
+-    #include ""tbb/scalable_allocator.h""
++    #include <tbb/scalable_allocator.h>
+     #include <tbb/global_control.h>
+     #include <tbb/task_arena.h>
+     #include ""services/daal_atomic_int.h""
+
++    #if defined(TBB_INTERFACE_VERSION) && TBB_INTERFACE_VERSION >= 12002
++        #include <tbb/task.h>
++    #endif
++
+ using namespace daal::services;
+ #else
+     #include ""src/externals/service_service.h""","If tbb.h is included, there is no big sense to include other TBB headers."
+10152,"@@ -915,12 +915,9 @@ def uses_path_addressing(headers):
+ def get_bucket_name(path, headers):
+     parsed = urlparse.urlparse(path)
+
+-    # try pick the bucket_name from the path
+-    bucket_name = parsed.path.split('/')[1]
+-
+-    # is the hostname not starting with a bucket name?
+-    if uses_path_addressing(headers):
+-        return normalize_bucket_name(bucket_name)
++    # matches the common endpoints like
++    #     - '<bucket_name>.s3.<region>.*'
++    localstack_pattern = re.compile(r'^(.+)\.s3[.\-][a-z]{2}-[a-z]+-[0-9]{1,}.*')
+
+     # matches the common endpoints like
+     #     - '<bucket_name>.s3.<region>.amazonaws.com'",Let's use the same `S3_HOSTNAME_PATTERN` as above here.
+10153,"@@ -215,6 +215,7 @@ function parseConnectionString(url, options) {
+     let r = parser.parse(f('mongodb://%s', hosts[i].trim()));
+     if (r.path && r.path.indexOf('.sock') !== -1) continue;
+     if (r.path && r.path.indexOf(':') !== -1) {
++      console.log(""R: "",r)
+       // Not connecting to a socket so check for an extra slash in the hostname.
+       // Using String#split as perf is better than match.
+       if (r.path.split('/').length > 1 && r.path.indexOf('::') === -1) {",This shouldn't be here.
+10154,"@@ -24,11 +24,16 @@ module ValueHelper
+   end
+
+   def property_to_s(val)
+-    # assume all decimals are currency
+-    if decimal?(val)
++    if decimal?(val) # assume all decimals are currency
+       number_to_currency(val)
++    elsif val.is_a?(ActiveSupport::TimeWithZone)
++      I18n.l(val, format: :date)
++    elsif val == true
++      ""Yes""
++    elsif val == false
++      ""No""
+     else
+-      val.to_s
++      val
+     end
+   end
+ end",A `case` statement may be simpler here.
+10155,"@@ -1081,10 +1081,15 @@ public class JDBCConnection implements ObjectStoreConnection {
+             throw notFoundError(caller, ZMSConsts.OBJECT_DOMAIN, domainName);
+         }
+         int curTagCount = getDomainTagsCount(domainId);
+-        int remainingTagsToInsert = domainTagsLimit - curTagCount;
++        int newTagCount = calculateTagCount(tags);
++        if (curTagCount + newTagCount > domainTagsLimit) {
++            throw ZMSUtils.quotaLimitError(""domain tag quota exceeded - limit: ""
++                + domainTagsLimit + "", current tags count: "" + curTagCount + "", new tags count: "" + newTagCount, caller);
++        }
++
+         boolean res = true;
+         for (Map.Entry<String, StringList> e : tags.entrySet()) {
+-            for (int i = 0; i < e.getValue().getList().size() && remainingTagsToInsert-- > 0; i++) {
++            for (int i = 0; i < e.getValue().getList().size(); i++) {
+                 String tagValue = e.getValue().getList().get(i);
+                 try (PreparedStatement ps = con.prepareStatement(SQL_INSERT_DOMAIN_TAG)) {
+                     ps.setInt(1, domainId);",why are we adding the current tag count to new tag count ?
+10156,"@@ -12,7 +12,7 @@ func (c *ServerConfig) SetServerMode(port int, network, netmask string) {
+
+ func (c *ServerConfig) SetTLSServer() {
+ 	c.setFlag(""tls-server"")
+-	c.AddOptions(OptionFile(""dh"", ""none""))
++	c.AddOptions(OptionFile(""dh"", ""none"", ""none""))
+ }
+
+ func (c *ServerConfig) SetProtocol(protocol string) {","Are you writing ""none"" to file content? no good"
+10157,"@@ -21,10 +21,10 @@ class SnippetWidget extends BaseWidget
+         string $target = Target::NOWHERE,
+         string $zone = RequestZone::NOWHERE
+     ) {
+-        $this->template = $snippet;
+-        $this->name = $name;
+-        $this->target = $target;
+-        $this->zone = $zone;
++        $this->setTemplate($snippet);
++        $this->setName($name);
++        $this->setTargets([$target]);
++        $this->setZone($zone);
+     }
+
+     protected function run(array $params = []): ?string",Should we allow `string|string[]` here?
+10158,"@@ -546,7 +546,17 @@ module.exports = class Dashboard extends Plugin {
+     })
+
+     // 4. Add all dropped files
+-    getDroppedFiles(event.dataTransfer)
++    let executedDropErrorOnce = false
++    const logDropError = (error) => {
++      this.uppy.log(error.message, 'error')
++
++      // In practice all drop errors are most likely the same, so let's just show one to avoid overwhelming the user
++      if (!executedDropErrorOnce) {
++        this.uppy.info(error.message, 'error')
++        executedDropErrorOnce = true
++      }
++    }
++    getDroppedFiles(event.dataTransfer, { logDropError })
+       .then((files) => {
+         if (files.length > 0) {
+           this.uppy.log('[Dashboard] Files were dropped')","Is there a reason for logging `error.message` specifically, maybe log the whole error object?"
+10159,"@@ -42,7 +42,9 @@ namespace OpenTelemetry.Trace
+             var aspnetOptions = new AspNetInstrumentationOptions();
+             configureAspNetInstrumentationOptions?.Invoke(aspnetOptions);
+
+-            builder.AddDiagnosticSourceInstrumentation((activitySource) => new AspNetInstrumentation(activitySource, aspnetOptions));
++            builder.AddInstrumentation(() => new AspNetInstrumentation(aspnetOptions));
++            builder.AddSource(typeof(AspNetInstrumentation).Assembly.GetName().Name);
++            builder.AddLegacyActivityOperationName(""Microsoft.AspNet.HttpReqIn"");
+
+             return builder;
+         }",Why is this needed?
+10160,"@@ -404,6 +404,14 @@ func (proxy *Proxy) ContainerStarted(ident string) {
+ 	proxy.notifyWaiters(ident, err)
+ }
+
++func (proxy *Proxy) ContainerConnected(ident string) {
++	err := proxy.attach(ident)
++	// if err != nil {
++	// TODO: Not sure what is needed here.
++	// }
++	proxy.notifyWaiters(ident, err)
++}
++
+ func containerShouldAttach(container *docker.Container) bool {
+ 	return len(container.Config.Entrypoint) > 0 && container.Config.Entrypoint[0] == weaveWaitEntrypoint[0]
+ }","Nothing. We only expect container-connected events when going via the plugin, not the proxy."
+10161,"@@ -11,6 +11,8 @@ import { mount } from './diff/mount';
+ import { patch } from './diff/patch';
+ import { createInternal } from './tree';
+
++let rootId = 0;
++
+ /**
+  *
+  * @param {import('./internal').PreactElement} parentDom The DOM element to","We might want to introduce some randomness here in case there are multiple completely separate Preact installations running, i.e. 2 widgets as those will be two roots with a resetting `_domDepth`"
+10162,"@@ -488,7 +488,7 @@ func TestPushChunkToNextClosest(t *testing.T) {
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}
+-	if ta2.Get(tags.StateSent) != 2 {
++	if ta2.Get(tags.StateSent) != 1 {
+ 		t.Fatalf(""tags error"")
+ 	}
+ ",this seems a bit wrong no? why is this change needed?
+10163,"@@ -145,7 +145,7 @@ Transaction.prototype._validateFees = function() {
+     return 'Fee is more than ' + Transaction.FEE_SECURITY_MARGIN + ' times the suggested amount';
+   }
+   if (this._getUnspentValue() < this._estimateFee() / Transaction.FEE_SECURITY_MARGIN) {
+-    return 'Fee is less than ' + Transaction.FEE_SECURITY_MARGIN + ' times the suggested amount';
++    return 'Fee is ' + Transaction.FEE_SECURITY_MARGIN + ' times less than the suggested amount';
+   }
+ };
+ ",Still confusing. Why don't we return something like `'Fee too low: expected X but found Y'`?
+10164,"@@ -81,14 +81,16 @@ type ProviderModeConfig struct {
+ type ConsumerConfig struct {
+ 	PublicKey string `json:""PublicKey""`
+ 	// IP is needed when provider is behind NAT. In such case provider parses this IP and tries to ping consumer.
+-	IP string `json:""IP,omitempty""`
++	IP    string `json:""IP,omitempty""`
++	Ports []int  `json:""Ports""`
+ }
+
+ // ServiceConfig represent a Wireguard service provider configuration that will be passed to the consumer for establishing a connection.
+ type ServiceConfig struct {
+ 	// LocalPort and RemotePort are needed for NAT hole punching only.
+-	LocalPort  int `json:""-""`
+-	RemotePort int `json:""-""`
++	LocalPort  int   `json:""-""`
++	RemotePort int   `json:""-""`
++	Ports      []int `json:""Ports""`
+
+ 	Provider struct {
+ 		PublicKey string","Should be from lowercase `json:""ports""` the same is defined in MarshalJSON"
+10165,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-create-subscription.rb demonstrates how to create an Amazon Simple Notification Services (SNS) subscription using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",Simple Notification **Service** (singular)
+10166,"@@ -32,7 +32,9 @@ public class NashornScriptInterpreter implements ScriptInterpreter {
+
+     @Override
+     public void runScript(String scriptContent, Consumer<Exception> errorCallback) {
+-        nashornEngineFactory.createEngine().eval(scriptContent, errorCallback);
++        final NashornEngine engine = nashornEngineFactory.createEngine();
++        engine.eval(""var tr = Packages.org.phoenicis.configuration.localisation.Localisation.tr;"", errorCallback);
++        engine.eval(scriptContent, errorCallback);
+     }
+
+     @Override",This code should be executed in NashornEngineFactory
+10167,"@@ -53,6 +53,7 @@ type Tags struct {
+
+ // NewTags creates a tags object
+ func NewTags(stateStore storage.StateStorer, logger logging.Logger) *Tags {
++	rand.Seed(time.Now().UnixNano())
+ 	return &Tags{
+ 		tags:       &sync.Map{},
+ 		stateStore: stateStore,","this is not so great as it sets the global rand seed. in tests that invoke this method multiple times for whatever reason, the global seed would be overridden every time the constructor would be called and the instances would have a different seed after every constructor call. it would be better to just pass a new source here as a parameter and do the same within the test. it should simplify things and clean this up"
+10168,"@@ -831,6 +831,14 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       arity = ""1"")
+   private final Wei txFeeCap = DEFAULT_RPC_TX_FEE_CAP;
+
++  @Option(
++      names = {""--rpc-require-chainid-in-txs""},
++      description =
++          ""Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"",
++      arity = ""1"")
++  // TODO: set default to false for next major release
++  private final Boolean unprotectedTransactionsAllowed = true;
++
+   @Option(
+       names = {""--min-block-occupancy-ratio""},
+       description = ""Minimum occupancy ratio for a mined block (default: ${DEFAULT-VALUE})"",","This looks inverted to me: if `--rpc-require-chainid-in-txs=true`, then shouldn't `unprotectedTransactionsAllowed == false`? Suggest changing this variable to `requireTxReplayProtection` or similar. I think the flag name could be clearer as well, maybe: `--require-tx-replay-protection`."
diff --git a/data/msg-test.finetuned_pred.csv b/data/msg-test.finetuned_pred.csv
new file mode 100644
index 0000000..5212f21
--- /dev/null
+++ b/data/msg-test.finetuned_pred.csv
@@ -0,0 +1,122419 @@
+,code,target,prediction
+0,"@@ -53,7 +53,7 @@ public class ProtocGapicPluginGeneratorTest {
+                 model.getFiles().stream().map(ProtoFile::getProto).collect(Collectors.toList()))
+             // Only the file to generate a client for (don't generate dependencies)
+             .addFileToGenerate(""multiple_services.proto"")
+-            .setParameter(""language=java"")
++            .setParameter(""language=java,transport=grpc"")
+             .build();
+
+     CodeGeneratorResponse response = ProtocGeneratorMain.generate(codeGeneratorRequest);",can we also test for `transport=rest`?,do we need to add the parameter to ProtocGeneratorMain.generate() as well?
+1,"@@ -182,7 +182,9 @@ abstract class AbstractSolrBackendFactory implements FactoryInterface
+      */
+     protected function createBackend(Connector $connector)
+     {
++        $config = $this->config->get($this->mainConfig);
+         $backend = new $this->backendClass($connector);
++        $backend->setPageSize($config->Index->record_batch_size);
+         $backend->setQueryBuilder($this->createQueryBuilder());
+         $backend->setSimilarBuilder($this->createSimilarBuilder());
+         if ($this->logger) {","If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`).",Is there a reason you're using the config variable here rather than the `I
+2,"@@ -1,6 +1,6 @@
+ <script type=""text/javascript"">
+   window.analytics||(window.analytics=[]),window.analytics.methods=[""identify"",""track"",""trackLink"",""trackForm"",""trackClick"",""trackSubmit"",""page"",""pageview"",""ab"",""alias"",""ready"",""group"",""on"",""once"",""off""],window.analytics.factory=function(t){return function(){var a=Array.prototype.slice.call(arguments);return a.unshift(t),window.analytics.push(a),window.analytics}};for(var i=0;i<window.analytics.methods.length;i++){var method=window.analytics.methods[i];window.analytics[method]=window.analytics.factory(method)}window.analytics.load=function(t){var a=document.createElement(""script"");a.type=""text/javascript"",a.async=!0,a.src=(""https:""===document.location.protocol?""https://"":""http://"")+""d2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/""+t+""/analytics.min.js"";var n=document.getElementsByTagName(""script"")[0];n.parentNode.insertBefore(a,n)},window.analytics.SNIPPET_VERSION=""2.0.8"",
+-  window.analytics.load(""2nexpdgku3"");
++  window.analytics.load(<%= ENV['SEGMENT_KEY']%>);
+   window.analytics.page();
+ </script>
+ ","I didn't realize we were hardcoding this, thanks for moving it to an env value.",Could you explain why this change is needed?
+3,"@@ -99,7 +99,7 @@ module.exports = function fileItem (props) {
+         }
+       </h4>
+       <div class=""UppyDashboardItem-status"">
+-        ${file.data.size && html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
++        ${isNaN(file.data.size) ? '' : html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
+         ${file.source && html`<div class=""UppyDashboardItem-sourceIcon"">
+             ${acquirers.map(acquirer => {
+               if (acquirer.id === file.source) return html`<span title=""${props.i18n('fileSource')}: ${acquirer.name}"">${acquirer.icon()}</span>`","We are trying to support IE 10-11, so we'll need a polyfill for this one, I think.",Would it be possible to use `isNaN` here as well?
+4,"@@ -38,6 +38,9 @@ const { useSelect, useDispatch } = Data;
+ function ResetButton( { children } ) {
+ 	const postResetURL = useSelect( ( select ) => select( CORE_SITE ).getAdminURL( 'googlesitekit-splash', { notification: 'reset_success' } ) );
+
++	const isNavigating = useSelect( ( select ) => select( CORE_LOCATION ).isNavigating() );
++	const navigatingURL = useSelect( ( select ) => select( CORE_LOCATION ).getNavigateURL() );
++
+ 	const [ dialogActive, setDialogActive ] = useState( false );
+
+ 	useEffect( () => {",It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with.,"`CORE_LOCATION` is an object, not a string."
+5,"@@ -29,8 +29,8 @@
+
+ namespace lbann {
+
+-void im2col(const Mat& im,
+-            Mat& col,
++void im2col(const AbsMat& im,
++            AbsMat& col,
+             const int num_channels,
+             const int im_num_dims,
+             const int * im_dims,",I think im2col should only accommodate CPUMat.,Why did you change these from Mat to AbsMat
+6,"@@ -24,6 +24,8 @@ from google.cloud.forseti.notifier.notifiers import cscc_notifier
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+ from google.cloud.forseti.services.inventory.storage import DataAccess
+ from google.cloud.forseti.services.scanner import dao as scanner_dao
++from google.cloud.forseti.common.util.email.email_factory import EmailFactory
++from google.cloud.forseti.notifier.notifiers import email_violations
+ # pylint: enable=line-too-long
+
+ ",alpha sort the imports,I think all these variables should be moved
+7,"@@ -1067,7 +1067,7 @@ fpga_result mmio_error(struct RASCommandLine *rasCmdLine)
+ 	if ( rasCmdLine->function >0 )
+ 		function = rasCmdLine->bus;
+
+-	snprintf(sysfs_path, sizeof(sysfs_path),
++	snprintf_s_iiii(sysfs_path, sizeof(sysfs_path),
+ 			DEVICEID_PATH,0,bus,device,function);
+
+ 	result = sysfs_read_u64(sysfs_path, &value);",Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?,`snprintf_s_iiii` should be `snprintf_s_iii
+8,"@@ -219,7 +219,19 @@ def internal_keyDownEvent(vkCode,scanCode,extended,injected):
+ 			for k in range(256):
+ 				keyStates[k]=ctypes.windll.user32.GetKeyState(k)
+ 			charBuf=ctypes.create_unicode_buffer(5)
++			# First try getting the keyboard layout from the thread with the focus (input thread)
+ 			hkl=ctypes.windll.user32.GetKeyboardLayout(focus.windowThreadID)
++			if not hkl:
++				log.debug(""Failed to fetch keyboard layout from focus, trying layout from last detected change"")
++				# Some threads, such as for Windows consoles
++				# Do not allow getKeyboardLayout to work.
++				# Therefore, use the cached keyboard layout from the last inputLangChange detected by NVDA
++				# on the foreground object.
++				hkl = getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)
++				if not hkl:
++					log.debug(""No layout cached, falling back to layout of NVDA main thread"")
++					# As a last resort, use the keyboard layout of NVDA's main thread.
++					hkl = ctypes.windll.user32.GetKeyboardLayout(core.mainThreadId)
+ 			# In previous Windows builds, calling ToUnicodeEx would destroy keyboard buffer state and therefore cause the app to not produce the right WM_CHAR message.
+ 			# However, ToUnicodeEx now can take a new flag of 0x4, which stops it from destroying keyboard state, thus allowing us to safely call it here.
+ 			res=ctypes.windll.user32.ToUnicodeEx(vkCode,scanCode,keyStates,charBuf,len(charBuf),0x4,hkl)",How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?,Should we cache this value (and then use it below) instead of fetching it again every time?
+9,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`),"Instead of doing this, you can just do `options.service = getDefaultService()` in the `crea"
+10,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below,This would be a breaking change. Can we instead pass an empty array as a default value and
+11,"@@ -39,6 +39,7 @@ func (p *Provisioner) ProvisionHostPath(opts pvController.VolumeOptions, volumeC
+ 	name := opts.PVName
+ 	stgType := volumeConfig.GetStorageType()
+ 	saName := getOpenEBSServiceAccountName()
++	shared := volumeConfig.GetSharedMountValue()
+
+ 	path, err := volumeConfig.GetPath()
+ 	if err != nil {","n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code.",Do we need to check if `GetSharedMountValue` is nil before calling it?
+12,"@@ -85,7 +85,10 @@ export class ManualColumnFreeze extends BasePlugin {
+   }
+
+   /**
+-   * Freezes the given column (add it to fixed columns).
++   * Freezes the specified column (i.e. adds it to fixed columns).
++   *
++   * `freezeColumn()` doesn't re-render the table,
++   * so you need to call the `render()` method afterward.
+    *
+    * @param {number} column Visual column index.
+    */",I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax  ,How about `freezeColumn()` instead of `render()`?
+13,"@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace
+         private void RunGetRequestedDataOtherSampler(Activity activity)
+         {
+             ActivityContext parentContext;
+-            if (string.IsNullOrEmpty(activity.ParentId))
++            if (string.IsNullOrEmpty(activity.ParentId) || activity.ParentSpanId.ToHexString().Equals(""0000000000000000""))
+             {
+                 parentContext = default;
+             }","this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed.",Can we put this string somewhere in `DynamoModel`
+14,"@@ -114,11 +114,16 @@ func (w *watcher) run(ctx context.Context, provider imageprovider.Provider, inte
+ 				updates = append(updates, u...)
+ 			}
+ 			if len(updates) == 0 {
+-				w.logger.Info(""no image to be updated"")
++				w.logger.Info(""no image to be updated"",
++					zap.String(""image-provider"", provider.Name()),
++				)
+ 				continue
+ 			}
+ 			if err := update(updates); err != nil {
+-				w.logger.Error(""failed to update image"", zap.Error(err))
++				w.logger.Error(""failed to update image"", zap.String(""image-provider"",
++					provider.Name()),
++					zap.Error(err),
++				)
+ 				continue
+ 			}
+ 		}","`zap.String(""image-provider"", provider.Name())` should be in a same line.","Hmm, do we need to log it?"
+15,"@@ -1,8 +1,6 @@
+ /*exported DqElement */
+
+ function truncate(str, maxLength) {
+-	'use strict';
+-
+ 	maxLength = maxLength || 300;
+
+ 	if (str.length > maxLength) {",Why this deletion?,Why remove this?
+16,"@@ -419,7 +419,10 @@ class S3KeyTest(unittest.TestCase):
+         remote_metadata = check._get_remote_metadata()
+
+         # TODO: investigate whether encoding ' ' as '%20' makes sense
+-        self.assertEqual(check.cache_control, 'public,%20max-age=500')
++        self.assertIn(
++            check.cache_control,
++            ('public,%20max-age=500', 'public, max-age=500')
++        )
+         self.assertEqual(remote_metadata['cache-control'], 'public,%20max-age=500')
+         self.assertEqual(check.get_metadata('test-plus'), 'A plus (+)')
+         self.assertEqual(check.content_disposition, 'filename=Sch%C3%B6ne%20Zeit.txt')",This change looks unrelated to the CL description?,"How about `'public,%20max-age=500', 'public, max-age=500')`?"
+17,"@@ -18,7 +18,7 @@ class DedupTest : public QueryTestBase {
+   void SetUp() override { QueryTestBase::SetUp(); }
+ };
+
+-#define DEDUP_RESUTL_CHECK(inputName, outputName, sentence, expected)                   \
++#define DEDUP_RESULT_CHECK(inputName, outputName, sentence, expected)                   \
+   do {                                                                                  \
+     qctx_->symTable()->newVariable(outputName);                                         \
+     auto yieldSentence = getYieldSentence(sentence, qctx_.get());                       \",I'm not certain that `res`+`utl` isn't a thing.,"There are a few of these `DEDUP_RESULT_CHECK`s in this file,"
+18,"@@ -182,6 +182,7 @@ public class FetchActiveFlowDao {
+             + "" LEFT JOIN ""
+             + "" executors et ON ex.executor_id = et.id""
+             + "" WHERE ex.status NOT IN (""
++            + Status.EXECUTION_STOPPED.getNumVal() + "", ""
+             + Status.SUCCEEDED.getNumVal() + "", ""
+             + Status.KILLED.getNumVal() + "", ""
+             + Status.FAILED.getNumVal() + "")"";","This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List<Integer> list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, "",""); You can use it at multiple places shown in this diff.",The `+` should be on the next line.
+19,"@@ -23,7 +23,10 @@ void wlr_input_device_init(struct wlr_input_device *dev,
+ }
+
+ void wlr_input_device_destroy(struct wlr_input_device *dev) {
+-	if (!dev) return;
++	if (!dev) {
++		return;
++	}
++
+ 	if (dev->_device) {
+ 		switch (dev->type) {
+ 		case WLR_INPUT_DEVICE_KEYBOARD:",Merge with next condition,Please add a blank line after the `switch` and before the `d
+20,"@@ -348,6 +348,7 @@ type appResourcesGetter interface {
+
+ type taskDeployer interface {
+ 	DeployTask(input *deploy.CreateTaskResourcesInput, opts ...cloudformation.StackOption) error
++	DeleteTask(task deploy.TaskStackInfo) error
+ }
+
+ type taskRunner interface {",Maybe add it when it is used.,What's the difference between this and `ListTask`?
+21,"@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
+     {'name': 'cloudsql_acl', 'enabled': False},
+     {'name': 'iam_policy', 'enabled': True}
+ ]}
++
++NONEXIST_ENABLED = {'scanners': [
++    {'name': 'bigquery', 'enabled': False},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': False},
++    {'name': 'non_exist_scanner', 'enabled': True}
++]}
++
++ALL_EXIST = {'scanners': [
++    {'name': 'bigquery', 'enabled': True},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': True},
++    {'name': 'iam_policy', 'enabled': True}
++]}",More clear naming: NONEXISTENT_ENABLED,no need for a comma here.
+22,"@@ -282,10 +282,10 @@ public class TypeUtil {
+
+     switch (from.typeId()) {
+       case INTEGER:
+-        return to == Types.LongType.get();
++        return to.equals(Types.LongType.get());
+
+       case FLOAT:
+-        return to == Types.DoubleType.get();
++        return to.equals(Types.DoubleType.get());
+
+       case DECIMAL:
+         Types.DecimalType fromDecimal = (Types.DecimalType) from;",why is this change necessary?,`to.equals(Types.LongType.get())` reads better.
+23,"@@ -178,9 +178,8 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter {
+
+   @Override
+   public String getFullNameFor(TypeModel type) {
+-    // TODO(andrealin): Remove this hack when null response types are implemented.
+-    if (type == null) {
+-      return ""nullFullName"";
++    if (type.isEmptyType()) {
++      return ""java.lang.Void"";
+     }
+     if (type instanceof DiscoveryRequestType) {
+       Method method = ((DiscoveryRequestType) type).parentMethod().getDiscoMethod();",make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here.,What's the reasoning behind this change?
+24,"@@ -26,7 +26,10 @@ class TinyMCELanguage extends AbstractSmartyPlugin
+
+     public function __construct(Request $request)
+     {
+-        $this->locale = $request->getSession()->getLang()->getLocale();
++        if($request->getSession() != null)
++            $this->locale = $request->getSession()->getLang()->getLocale();
++        else
++            $this->locale = Lang::getDefaultLanguage()->getLocale();
+     }
+
+     public function guessTinyMCELanguage($params, \Smarty_Internal_Template $template)",Use braces on your conditional structures please,The `getSession()` method returns `null` if the session is not active. Please fix this.
+25,"@@ -16,6 +16,7 @@
+
+ DECLARE_string(u);
+ DECLARE_string(p);
++DEFINE_bool(enable_history, false, ""Whether to force saving the command history"");
+
+ namespace nebula {
+ namespace graph {","Great God, I have a question. This "".nebula_history"" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx.","Why not `DEFINE_bool(history, false, ""Whether to force saving the command history."");`?"
+26,"@@ -1004,8 +1004,9 @@ static void parseRecord (tokenInfo *const token)
+ 	 */
+ 	if (!isType (token, TOKEN_OPEN_PAREN))
+ 		readToken (token);
++	if (!isType (token, TOKEN_OPEN_PAREN))
++		return;
+
+-	Assert (isType (token, TOKEN_OPEN_PAREN));
+ 	do
+ 	{
+ 		if (isType (token, TOKEN_COMMA) ||",Isn't this the same check as two lines above?,We already have this assert above. What's the reason to remove it?
+27,"@@ -18,8 +18,11 @@ from mitmproxy import io
+ from mitmproxy import log
+ from mitmproxy import version
+ from mitmproxy import optmanager
++from mitmproxy import options
+ import mitmproxy.tools.web.master # noqa
+
++CONFIG_PATH = os.path.join(options.CA_DIR, 'config.yaml')
++
+
+ def flow_to_json(flow: mitmproxy.flow.Flow) -> dict:
+     """"""","Don't redefine, just import the existing one in `cmdline.py`. :)",This could be defined in `mitmproxy.settings`
+28,"@@ -92,7 +92,8 @@ module Mongoid
+       #
+       # @since 2.0.0.rc.7
+       def process_attribute(name, value)
+-        if store_as = aliased_fields.invert[name.to_s]
++        responds = respond_to?(""#{name}="")
++        if !responds && store_as = aliased_fields.invert[name.to_s]
+           name = store_as
+         end
+         responds = respond_to?(""#{name}="")","why not call `respond_to?(""#{name}="")` from the `if` line?",Use `&&` instead of `&&`.
+29,"@@ -215,7 +215,8 @@ public final class BlazeCidrLauncher extends CidrLauncher {
+         workingDir = workspaceRootDirectory;
+       }
+
+-      GeneralCommandLine commandLine = new GeneralCommandLine(runner.executableToDebug.getPath());
++      GeneralCommandLine commandLine = new GeneralCommandLine(runner.executableToDebug.getPath())
++          .withWorkDirectory(workingDir);
+
+       commandLine.addParameters(handlerState.getExeFlagsState().getFlagsForExternalProcesses());
+       commandLine.addParameters(handlerState.getTestArgs());",This was properly set above as `<target>.runfiles/<workspace_name>` (with a fallback to workspace root dir) but never used past this line.,I don't think this change
+30,"@@ -0,0 +1,13 @@
++using System;
++using System.Collections.Generic;
++using System.Linq;
++using System.Text;
++using System.Threading.Tasks;
++using MvvmCross.Core.Views;
++
++namespace MvvmCross.Uwp.Attributes
++{
++    public class MvxPagePresentationAttribute : MvxBasePresentationAttribute
++    {
++    }
++}",Are all these namespaces required for this attribute?,Should this be renamed to
+31,"@@ -53,9 +53,12 @@ module Beaker
+           result.stdout << std_out
+           result.stderr << std_err
+           result.exit_code = status.exitstatus
++          @logger.info(result.stdout)
++          @logger.info(result.stderr)
+         end
+       rescue => e
+         result.stderr << e.inspect
++        @logger.info(result.stderr)
+         result.exit_code = 1
+       end
+ ","Given this may be used and printed in other ways, isn't `debug` more appropriate?",Since there's only one `b
+32,"@@ -540,3 +540,7 @@ func (s *blockDiskStore) remove(id kbfsblock.ID) error {
+ 	}
+ 	return err
+ }
++
++func (s blockDiskStore) clear() error {
++	return ioutil.RemoveAll(s.dir)
++}",Looks like this is unused? Did you mean to call it when clearing the block journal?,This should probably be in `pkg/storage/file_test.go` instead of in the test package.
+33,"@@ -117,8 +117,10 @@ public class ExecutorManager extends EventHandler implements
+
+   public ExecutorManager(Props props, ExecutorLoader loader,
+       Map<String, Alerter> alters) throws ExecutorManagerException {
++    alerters = alters;
+     azkProps = props;
+     this.executorLoader = loader;
++
+     this.setupExecutors();
+     this.loadRunningFlows();
+ ",why named alters? how about this.alerts = alerts?,rename `alerters` to `aleres`
+34,"@@ -1549,7 +1549,7 @@ func (js *jetStream) processStreamLeaderChange(mset *stream, isLeader bool) {
+ 		resp.Error = jsError(err)
+ 		s.sendAPIErrResponse(client, acc, subject, reply, _EMPTY_, s.jsonResponse(&resp))
+ 	} else {
+-		resp.StreamInfo = &StreamInfo{Created: mset.createdTime(), State: mset.state(), Config: mset.config(), Cluster: js.clusterInfo(mset.raftGroup())}
++		resp.StreamInfo = &StreamInfo{Created: mset.createdTime(), State: mset.state(), Config: mset.config(), Cluster: js.clusterInfo(mset.raftGroup()), Sources: mset.sourcesInfo(), Mirror: mset.mirrorInfo()}
+ 		s.sendAPIResponse(client, acc, subject, reply, _EMPTY_, s.jsonResponse(&resp))
+ 		if node := mset.raftNode(); node != nil {
+ 			mset.sendCreateAdvisory()",not sure if this has to be here or not tbh,Would you mind adding a `msg` to the `StreamInfo` so we know what kind of information
+35,"@@ -72,7 +72,12 @@ func newHarnessUsingAutodelete(ctx context.Context, t *testing.T) (drivertest.Ha
+ }
+
+ func (h *harness) CreateTopic(ctx context.Context, testName string) (dt driver.Topic, cleanup func(), err error) {
++	// Keep the topic entity name under 50 characters as per Azure limits.
++	// See https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-quotas
+ 	topicName := fmt.Sprintf(""%s-topic-%d"", sanitize(testName), atomic.AddUint32(&h.numTopics, 1))
++	if len(topicName) > 50 {
++		topicName = topicName[:50]
++	}
+
+ 	createTopic(ctx, topicName, h.ns, nil)
+ ","There's a better fix for this in #1741, which should replace this.",Should we check that the length of the string is exactly 50 chars and log an error if
+36,"@@ -63,7 +63,7 @@ func (s *StreamMock) Close() error {
+ func TestHandshake(t *testing.T) {
+ 	logger := logging.New(ioutil.Discard, 0)
+ 	info := Info{
+-		Address:   ""node1"",
++		Address:   []byte(""node1""),
+ 		NetworkID: 0,
+ 		Light:     false,
+ 	}","Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string.",why make this a `[]byte` and not a `string`?
+37,"@@ -80,8 +80,9 @@ func TestFSRepoInit(t *testing.T) {
+
+ 	dir, err := ioutil.TempDir("""", """")
+ 	assert.NoError(t, err)
+-
+-	defer os.RemoveAll(dir)
++	defer func() {
++		require.NoError(t, os.RemoveAll(dir))
++	}()
+
+ 	t.Log(""init FSRepo"")
+ 	assert.NoError(t, InitFSRepo(dir, config.NewDefaultConfig()))","It would be worth factoring this out to a function, but you don't have to do that here.",This is not needed anymore.
+38,"@@ -0,0 +1,15 @@
++package com.fsck.k9.message.html;
++
++/**
++ * General framework to handle uris when parsing. Allows different handling depending on the scheme identifier.
++ */
++public interface UriParser {
++    /**
++     * Parse and linkify scheme specific uri beginning from given position. The result will be written to given buffer.
++     * @param text String to parse uri from.
++     * @param startPos Position where uri starts (first letter of scheme).
++     * @param outputBuffer Buffer where linkified variant of uri is written to.
++     * @return Index where parsed uri ends (first non-uri letter). Should be startPos or smaller if no valid uri was found.
++     */
++    int linkifyUri(String text, int startPos, StringBuffer outputBuffer);
++}",There's no need for `final` in interfaces.,"I think this should be called ""prefixes"" ins"
+39,"@@ -101,6 +101,9 @@ namespace Datadog.Trace.OpenTracing
+                 case DatadogTags.ServiceName:
+                     Span.ServiceName = value;
+                     return this;
++                case DatadogTags.ServiceVersion:
++                    Span.SetTag(Tags.Version, value);
++                    return this;
+             }
+
+             if (key == global::OpenTracing.Tag.Tags.Error.Key)",Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties.,I believe this case should be `case DatadogT
+40,"@@ -681,7 +681,6 @@ class Quitter:
+     @cmdutils.argument('session', completion=miscmodels.session)
+     def quit(self, save=False, session=None):
+         """"""Quit qutebrowser.
+-
+         Args:
+             save: When given, save the open windows even if auto_save.session
+                   is turned off.",This shouldn't be changed.,Don't remove this empty line.
+41,"@@ -1,5 +1,5 @@
+ ## This file is part of Invenio.
+-## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 CERN.
++## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`",Copyright date should not be
+42,"@@ -32,6 +32,8 @@ import java.util.Map;
+ import java.util.Optional;
+ import java.util.Set;
+ import java.util.concurrent.TimeoutException;
++import java.util.function.BiConsumer;
++import java.util.function.Consumer;
+
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;","Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail.",nit: can you make these `BiCo
+43,"@@ -0,0 +1,10 @@
++class TraceDestroyerJob < ApplicationJob
++  queue_as :default
++
++  def perform(trace)
++    trace.destroy
++  rescue StandardError => ex
++    logger.info ex.to_s
++    ex.backtrace.each { |l| logger.info l }
++  end
++end",Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued...,I don't see any usages of `ex
+44,"@@ -90,14 +90,11 @@ class CartController extends FrontBaseController
+      */
+     public function indexAction(Request $request)
+     {
+-        $cart = $this->cartFacade->getCartOfCurrentCustomer();
+-
+-        if ($cart->isEmpty()) {
+-            $this->cartFacade->cleanAdditionalData();
+-        }
++        $cart = $this->cartFacade->findCartOfCurrentCustomer();
++        $cartItems = $cart === null ? [] : $cart->getItems();
+
+         $cartFormData = ['quantities' => []];
+-        foreach ($cart->getItems() as $cartItem) {
++        foreach ($cartItems as $cartItem) {
+             $cartFormData['quantities'][$cartItem->getId()] = $cartItem->getQuantity();
+         }
+ ","If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)",Should we use `CartFacade::getCartOfCurrentCustomer` here?
+45,"@@ -34,7 +34,8 @@ public enum BesuMetricCategory implements MetricCategory {
+   PRUNER(""pruner""),
+   RPC(""rpc""),
+   SYNCHRONIZER(""synchronizer""),
+-  TRANSACTION_POOL(""transaction_pool"");
++  TRANSACTION_POOL(""transaction_pool""),
++  VALIDATORS(""validators"");
+
+   private static final Optional<String> BESU_PREFIX = Optional.of(""besu_"");
+   public static final Set<MetricCategory> DEFAULT_METRIC_CATEGORIES;",Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2.,I don't think we should change the metric category here. S
+46,"@@ -14,9 +14,7 @@
+  */
+ package org.hyperledger.besu.tests.acceptance.dsl.account;
+
+-import org.hyperledger.besu.crypto.SECP256K1.KeyPair;
+-import org.hyperledger.besu.crypto.SECP256K1.PrivateKey;
+-import org.hyperledger.besu.crypto.SECP256K1.PublicKey;
++import org.hyperledger.besu.crypto.*;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.Hash;
+ import org.hyperledger.besu.tests.acceptance.dsl.blockchain.Amount;",Spotless is configured to reject star imports. Please replace with explicit imports.,Please do not use wildcard imports.
+47,"@@ -115,6 +115,8 @@ void SYCLInternal::initialize(const sycl::device& d) {
+
+     m_maxThreadsPerSM =
+         d.template get_info<sycl::info::device::max_work_group_size>();
++    m_maxShmemPerBlock =
++        d.template get_info<sycl::info::device::local_mem_size>();
+     m_indirectKernelMem.reset(*m_queue);
+     m_indirectReducerMem.reset(*m_queue);
+   } else {",Remind me why you are using CUDA vocabulary when naming these variables.,Why is this not `m_maxThreadsPerSM`?
+48,"@@ -898,6 +898,16 @@ public final class DBReader {
+         }
+         final LongIntMap feedCounters = adapter.getFeedCounters(feedIds);
+
++        int feedFilter = UserPreferences.getFeedFilter();
++        if (feedFilter == UserPreferences.FEED_FILTER_COUNTER_ZERO) {
++            for (int i = 0; i < feeds.size(); i++) {
++                if (feedCounters.get(feeds.get(i).getId()) <= 0) {
++                    feedCounters.delete(feeds.get(i).getId());
++                    feeds.remove(i);
++                }
++            }
++        }
++
+         Comparator<Feed> comparator;
+         int feedOrder = UserPreferences.getFeedOrder();
+         if (feedOrder == UserPreferences.FEED_ORDER_COUNTER) {",Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed.,This should be done in the `remove` method of the `Feed` model as well.
+49,"@@ -620,7 +620,7 @@ def execute_reentrant_pipeline(pipeline, typed_environment, throw_on_error, reen
+ def get_subset_pipeline(pipeline, solid_subset):
+     check.inst_param(pipeline, 'pipeline', PipelineDefinition)
+     check.opt_list_param(solid_subset, 'solid_subset', of_type=str)
+-    return pipeline if solid_subset is None else build_sub_pipeline(pipeline, solid_subset)
++    return pipeline if not solid_subset else build_sub_pipeline(pipeline, solid_subset)
+
+
+ def create_typed_environment(pipeline, environment=None):",this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline,"Not sure about this one, `solid_subset is None` is equivalent to `solid"
+50,"@@ -318,8 +318,7 @@ Licensed under the MIT License. See License.txt in the project root for license
+             {
+                 foreach (var unmatchedSetting in CustomSettings.Keys)
+                 {
+-                    Logger.LogError(new ArgumentException(unmatchedSetting),
+-                        Resources.ParameterIsNotValid, unmatchedSetting);
++                    Logger.LogWarning(Resources.ParameterIsNotValid, unmatchedSetting);
+                 }
+             }
+             ErrorManager.ThrowErrors();","this is a breaking change, any specific reason you want to do this?",Was this a bug?
+51,"@@ -91,6 +91,8 @@ type nodeChainReader interface {
+ 	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ 	HeadEvents() *ps.PubSub
+ 	Load(context.Context) error
++	PutTipSetAndState(context.Context, *chain.TipSetAndState) error
++	SetHead(context.Context, types.TipSet) error
+ 	Stop()
+ }
+ ","Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks.",Is there a better name than `PutTipSetAndState`? Is `PutTipSetAndState`
+52,"@@ -22,7 +22,8 @@ const (
+ 	minimalPrefetchWorkerQueueSize       int = 1
+ 	testBlockRetrievalWorkerQueueSize    int = 5
+ 	testPrefetchWorkerQueueSize          int = 1
+-	defaultOnDemandRequestPriority       int = 100
++	defaultOnDemandRequestPriority       int = 1<<30 - 1
++	lowestTriggerPrefetchPriority        int = 1
+ 	// Channel buffer size can be big because we use the empty struct.
+ 	workerQueueSize int = 1<<31 - 1
+ )",The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?,Could you explain why this change is needed?
+53,"@@ -609,6 +609,14 @@ bool Game::removeCreature(Creature* creature, bool isLogout/* = true*/)
+ 	return true;
+ }
+
++void Game::executeDeath(uint32_t creatureId)
++{
++	Creature* creature = getCreatureByID(creatureId);
++	if (creature && !creature->isRemoved() && creature->getHealth() < 1) {
++		creature->onDeath();
++	}
++}
++
+ void Game::playerMoveThing(uint32_t playerId, const Position& fromPos,
+                            uint16_t spriteId, uint8_t fromStackPos, const Position& toPos, uint8_t count)
+ {",checking health again? I think it is not necessary.,wouldn't this be better as a `void` method i
+54,"@@ -442,7 +442,18 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			log.WithError(err).Error(""Failed to connect to Typha. Retrying..."")
++			startTime := time.Now()
++			for err != nil && time.Since(startTime) < 30*time.Second {
++				// Set Ready to false and Live to true when unable to connect to typha
++				healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Debug(""Retrying to start Typha"")
++				time.Sleep(1 * time.Second)
++			}
++			if err != nil {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()",Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.,Shouldn't this be `time.Sleep(1 * time.Secon
+55,"@@ -0,0 +1,18 @@
++'use strict';
++
++const assert = require('assert');
++
++class ProvidedPromise {
++  set Promise(lib) {
++    assert.ok(typeof lib === 'function', `mongodb.Promise must be a function, got ${lib}`);
++    this._promise = lib;
++  }
++  get Promise() {
++    return this._promise;
++  }
++}
++
++const provided = new ProvidedPromise();
++provided.Promise = global.Promise;
++
++module.exports = provided;","to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate.",Is there a reason why this is global.Promise
+56,"@@ -738,6 +738,12 @@ func addDep(s *scope, args []pyObject) pyObject {
+ 	dep := core.ParseBuildLabelContext(string(args[1].(pyString)), s.pkg)
+ 	exported := args[2].IsTruthy()
+ 	target.AddMaybeExportedDependency(dep, exported, false, false)
++	// Queue this dependency if it'll be needed.
++	if target.State() > core.Inactive {
++		err := s.state.QueueTarget(dep, target.Label, true, false)
++		s.Assert(err == nil, ""%s"", err)
++	}
++	// TODO(peterebden): Do we even need the following any more?
+ 	s.pkg.MarkTargetModified(target)
+ 	return None
+ }","I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better.","The only thing we could do here is to ensure that if the target was already indeed modified, we don't queue it again. The only thing we could do is to ensure that if the target was indeed modified, we don't forget to mark it as modified."
+57,"@@ -123,7 +123,7 @@ def sndrcv(pks, pkt, timeout = None, inter = 0, verbose=None, chainCC=0, retry=0
+                                 if remaintime <= 0:
+                                     break
+                             r = None
+-                            if arch.FREEBSD or arch.DARWIN:
++                            if not (pks.__class__.__name__ == 'StreamSocket') and (arch.FREEBSD or arch.DARWIN):
+                                 inp, out, err = select(inmask,[],[], 0.05)
+                                 if len(inp) == 0 or pks in inp:
+                                     r = pks.nonblock_recv()",You should use `isinstance()` instead of comparing the class name to a string.,Would it be better to check `if not (pks.__class__ == 'StreamSocket' or pks.__class__ == 'Socket')` ?
+58,"@@ -15,6 +15,11 @@ axe.utils.isHidden = function isHidden(el, recursed) {
+ 		return false;
+ 	}
+
++	// do not exclude `video` or `audio` el's
++	if ([`VIDEO`, `AUDIO`].includes(el.nodeName.toUpperCase())) {
++		return false;
++	}
++
+ 	// 11 === Node.DOCUMENT_FRAGMENT_NODE
+ 	if (el.nodeType === 11) {
+ 		el = el.host; // grab the host Node",Why should audio and video elements always return `false` for `isHidden`?,`if (el.nodeType === 11) {`
+59,"@@ -27,7 +27,7 @@ namespace Playground.Core
+
+             Mvx.IoCProvider.RegisterSingleton<IMvxTextProvider>(new TextProviderBuilder().TextProvider);
+
+-            RegisterAppStart<RootViewModel>();
++            // RegisterAppStart<RootViewModel>();
+         }
+
+         /// <summary>",This obviously won't work for all the other platforms.,"I'm not sure if we should just remove the registration of the `RootViewModel` here. If we're going to start the view with a `DynamoViewModel`, why don't we just remove the registration of the `DynamoViewModel`?"
+60,"@@ -15,7 +15,7 @@ public class ManipulationTest extends BasicJBehaveTest {
+
+     @Override
+     public InjectableStepsFactory stepsFactory() {
+-        Map<String, Object> state = new HashMap<String, Object>();
++        Map<String, Object> state = new HashMap<>();
+
+         return new InstanceStepsFactory(configuration(),
+                 new SharedSteps(state),",Isn't he diamond operator Java7+?,"no need to change this, it's not public."
+61,"@@ -159,6 +159,17 @@ public final class Require {
+     return number;
+   }
+
++  public static double positive(String argName, double number, String message) {
++    if (number <= 0) {
++      if (message == null) {
++        throw new IllegalArgumentException(argName + "" must be greater than 0"");
++      } else {
++        throw new IllegalArgumentException(message);
++      }
++    }
++    return number;
++  }
++
+   public static int positive(String argName, Integer number) {
+     return positive(argName, number, null);
+   }","Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly.","Should this be `positive(argName, null)`"
+62,"@@ -474,7 +474,7 @@ func (rule removeCount) Name() string {
+ func (rule removeCount) Pattern() plan.Pattern {
+ 	return plan.Pat(universe.CountKind, plan.Any())
+ }
+-func (rule removeCount) Rewrite(ctx context.Context, node plan.Node) (plan.Node, bool, error) {
++func (rule removeCount) Rewrite(ctx context.Context, node plan.Node, nextNodeId *int) (plan.Node, bool, error) {
+ 	return node.Predecessors()[0], true, nil
+ }
+ ","This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it.",Not sure why we need to make this change
+63,"@@ -164,10 +164,13 @@ func WriteWordpressConfig(wordpressConfig *WordpressConfig, filePath string) err
+ 		return err
+ 	}
+
+-	// Ensure target directory is writable.
++	// Ensure target directory exists and is writeable
+ 	dir := filepath.Dir(filePath)
+-	err = os.Chmod(dir, 0755)
+-	if err != nil {
++	if err = os.Chmod(dir, 0755); os.IsNotExist(err) {
++		if err = os.MkdirAll(dir, 0755); err != nil {
++			return err
++		}
++	} else if err != nil {
+ 		return err
+ 	}
+ ",This seems like an improved pattern :),This was a bug I found. We now always cr
+64,"@@ -127,16 +127,16 @@ class UserController < ApplicationController
+         # valid OpenID and one the user has control over before saving
+         # it as a password equivalent for the user.
+         session[:new_user_settings] = params
+-        openid_verify(params[:user][:openid_url], @user)
++        federated_verify(params[:user][:openid_url], @user)
+       else
+         update_user(@user, params)
+       end
+-    elsif using_open_id?
++    elsif using_federated_login?
+       # The redirect from the OpenID provider reenters here
+       # again and we need to pass the parameters through to
+       # the open_id_authentication function
+       settings = session.delete(:new_user_settings)
+-      openid_verify(nil, @user) do |user|
++      federated_verify(nil, @user) do |user|
+         update_user(user, settings)
+       end
+     end","`open_id_authentication` is no longer the name of the function, and it's not OpenID specific",What is the difference between `openid_verify` and `federated_verify`?
+65,"@@ -243,10 +243,10 @@ void rai_qt::accounts::refresh_wallet_balance ()
+ 		balance = balance + (this->wallet.node.ledger.account_balance (transaction, key));
+ 		pending = pending + (this->wallet.node.ledger.account_pending (transaction, key));
+ 	}
+-	auto final_text (std::string (""Wallet balance (XRB): "") + wallet.format_balance (balance));
++	auto final_text (std::string (""Balance: "") + wallet.format_balance (balance));
+ 	if (!pending.is_zero ())
+ 	{
+-		final_text += ""\nWallet pending: "" + wallet.format_balance (pending);
++		final_text += ""\nPending: "" + wallet.format_balance (pending);
+ 	}
+ 	wallet_balance_label->setText (QString (final_text.c_str ()));
+ 	this->wallet.node.alarm.add (std::chrono::system_clock::now () + std::chrono::seconds (60), [this]() {",This didn't require corresponding changes to the test case(s)?,Why remove the XRB?
+66,"@@ -509,6 +509,7 @@ type TaskConfig struct {
+ 	Count          Count                `yaml:""count""`
+ 	ExecuteCommand ExecuteCommand       `yaml:""exec""`
+ 	Variables      map[string]string    `yaml:""variables""`
++	EnvFile        string               `yaml:""env_file""`
+ 	Secrets        map[string]string    `yaml:""secrets""`
+ 	Storage        Storage              `yaml:""storage""`
+ }","A question! I think `string` totally works, but what do you think of `*string` for consistency?",Why did you add this? The CLI flags already override the env file.
+67,"@@ -25,6 +25,12 @@ import (
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+
++const (
++	AnnotationClusterInfrastructureReady = ""aws.cluster.sigs.k8s.io/infrastructure-ready""
++	AnnotationControlPlaneReady          = ""aws.cluster.sigs.k8s.io/control-plane-ready""
++	ValueReady                           = ""true""
++)
++
+ // AWSResourceReference is a reference to a specific AWS resource by ID, ARN, or filters.
+ // Only one of ID, ARN or Filters may be specified. Specifying more than one will result in
+ // a validation error.",Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?,`aws.cluster.sigs.io/infrastructure-ready` -> `aws.cluster.sigs.io/inf
+68,"@@ -142,7 +142,7 @@ void PairLubricate::compute(int eflag, int vflag)
+     Ef[2][2] = h_rate[2]/domain->zprd;
+     Ef[0][1] = Ef[1][0] = 0.5 * h_rate[5]/domain->yprd;
+     Ef[0][2] = Ef[2][0] = 0.5 * h_rate[4]/domain->zprd;
+-    Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->zprd;
++    Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->xprd;
+
+     // copy updated velocity/omega/angmom to the ghost particles
+     // no need to do this if not shearing since comm->ghost_velocity is set",Not clear on why this change is correct.,here you should be able to use the variable domain->zprd instead of using domain->xprd
+69,"@@ -193,5 +193,10 @@ public final class ByteBuffersIndexInput extends IndexInput implements RandomAcc
+     if (in == null) {
+       throw new AlreadyClosedException(""Already closed."");
+     }
+-  }
++  }
++
++  @Override
++  public boolean isMMapped() {
++    return true;
++  }
+ }","Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap).",is this needed for anything?
+70,"@@ -54,6 +54,7 @@ storiesOf( 'PageSpeed Insights Module/Settings', module )
+ 		decorators: [
+ 			withRegistry,
+ 		],
++		padding: 0,
+ 	} )
+ 	.add( 'View, open with all settings', ( args, { registry } ) => {
+ 		return <Settings isOpen={ true } registry={ registry } />;",All stories in this file also need to have the default padding.,Is the default for `padding` correct? Shouldn't it be `0`?
+71,"@@ -804,8 +804,10 @@ static void subsurface_handle_place_above(struct wl_client *client,
+ 		return;
+ 	}
+
++	assert(sibling->parent == subsurface->parent);
++
+ 	wl_list_remove(&subsurface->parent_pending_link);
+-	wl_list_insert(&sibling->parent_pending_link,
++	wl_list_insert(sibling->parent_pending_link.prev,
+ 		&subsurface->parent_pending_link);
+
+ 	subsurface->reordered = true;","I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?",Doesn't `parent_pending_link.prev` insert the same element as `subsurface->parent`? I
+72,"@@ -0,0 +1,15 @@
++class Episode < ActiveRecord::Base
++  attr_accessible :title, :duration, :file, :description, :published_on, :notes,
++    :old_url, :file_size
++
++  validates_presence_of :title, :duration, :file, :file_size, :description,
++    :published_on
++
++  def self.published
++    where(""published_on <= ?"", Date.today).order('published_on desc')
++  end
++
++  def full_title
++    ""Episode #{id}: #{title}""
++  end
++end",Should this be `number` instead of `id`?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+73,"@@ -1569,12 +1569,11 @@ NATable *BindWA::getNATable(CorrName& corrName,
+       ((QualifiedName&)(table->getTableName())).setIsVolatile(TRUE);
+     }
+
+-  // For now, do not allow access through the Trafodion external name created for
+-  // the HIVE object unless the inDDL flag is set.  inDDL is set for drop
+-  // table and SHOWDDL statements.
+-  // TDB - may want to merge the Trafodion version with the HIVE version.
+-  // TDB - similar operation may be needed for external HBase tables
+-  if ((table) && (table->isExternalTable() && (! bindWA->inDDL())))
++  // For now, don't allow access through the Trafodion external name created for
++  // native HIVE or HBASE objects unless the allowExternalTables flag is set.
++  // allowExternalTables is set for drop table and SHOWDDL statements.
++  // TDB - may want to merge the Trafodion version with the native version.
++  if ((table) && (table->isExternalTable() && (! bindWA->allowExternalTables())))
+     {
+       *CmpCommon::diags() << DgSqlCode(-4258)
+                           << DgTableName(table->getTableName().getQualifiedNameAsAnsiString());","I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name.","Instead of ""don't"", ""don't"" sounds a bit redundant. Can we change this to ""don't""?"
+74,"@@ -40,6 +40,18 @@
+
+ struct ase_cfg_t *cfg;
+
++int app2sim_alloc_rx;		// app2sim mesaage queue in RX mode
++int sim2app_alloc_tx;		// sim2app mesaage queue in TX mode
++int app2sim_mmioreq_rx;		// MMIO Request path
++int sim2app_mmiorsp_tx;		// MMIO Response path
++int app2sim_umsg_rx;		// UMSG    message queue in RX mode
++int app2sim_portctrl_req_rx;	// Port Control messages in Rx mode
++int app2sim_dealloc_rx;
++int sim2app_dealloc_tx;
++int sim2app_portctrl_rsp_tx;
++int sim2app_intr_request_tx;
++int intr_event_fds[MAX_USR_INTRS];
++
+ int glbl_test_cmplt_cnt;   // Keeps the number of session_deinits received
+
+ volatile int sockserver_kill;",Should most of these non-globals be static?,Shouldn't this be `app2sim_pm_rx`?
+75,"@@ -14,6 +14,14 @@ class TestFakerName < Test::Unit::TestCase
+     assert @tester.name_with_middle.match(/(\w+\.? ?){3,4}/)
+   end
+
++  def test_first_name
++    assert @tester.first_name.match(/(\w+\.? ?){3,4}/)
++  end
++
++  def test_last_name
++    assert @tester.last_name.match(/(\w+\.? ?){3,4}/)
++  end
++
+   def test_prefix
+     assert @tester.prefix.match(/[A-Z][a-z]+\.?/)
+   end",Please do not approve PRs without tests!!!!,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for
+76,"@@ -48,7 +48,7 @@ class WebEngineView(QWebEngineView):
+         else:
+             profile = webenginesettings.default_profile
+         page = WebEnginePage(theme_color=theme_color, profile=profile,
+-                             parent=self)
++                             parent=self, win_id=win_id)
+         self.setPage(page)
+
+     def shutdown(self):",Now that you handle this in `webenginetab.py` you can undo all the changes in this file.,nitpick: Why not just `win_id=self.win_id`?
+77,"@@ -30,7 +30,11 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext
+ public class JavaFXApplication extends Application {
+
+     public static void main(String[] args) {
+-        Application.launch(JavaFXApplication.class);
++        try {
++            Application.launch(JavaFXApplication.class);
++        } catch (Exception e) {
++            e.printStackTrace();
++        }
+     }
+
+     @Override",I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console.,Do you want to also print the stack trace?
+78,"@@ -57,7 +57,7 @@ func (r *Helper) Apply(obj []byte) (ApplyResult, error) {
+ 	if err != nil {
+ 		r.logger.WithError(err).
+ 			WithField(""stdout"", ioStreams.Out.(*bytes.Buffer).String()).
+-			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Error(""running the apply command failed"")
++			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Warn(""running the apply command failed"")
+ 		return """", err
+ 	}
+ 	return changeTracker.GetResult(), nil","These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors.",@smarterclayton do we want to change this t
+79,"@@ -167,7 +167,7 @@ class ExportCategoryTableMap extends TableMap
+      */
+     public function buildRelations()
+     {
+-        $this->addRelation('Export', '\\Thelia\\Model\\Export', RelationMap::ONE_TO_MANY, array('id' => 'export_category_id', ), 'CASCADE', 'RESTRICT', 'Exports');
++        $this->addRelation('Export', '\\Thelia\\Model\\Export', RelationMap::ONE_TO_MANY, array('id' => 'export_category_id', ), null, null, 'Exports');
+         $this->addRelation('ExportCategoryI18n', '\\Thelia\\Model\\ExportCategoryI18n', RelationMap::ONE_TO_MANY, array('id' => 'id', ), 'CASCADE', null, 'ExportCategoryI18ns');
+     } // buildRelations()
+ ",do you really want to change the behavior on foreign key ?,"`$this->addRelation('Export', '\\Thelia\\Mo"
+80,"@@ -183,7 +183,8 @@ void event_batch_destroy (struct event_batch *batch)
+         if (batch->f)
+             (void)flux_future_wait_for (batch->f, -1);
+         if (batch->state_trans) {
+-            event_publish_state (batch->event, batch->state_trans);
++            if (json_array_size (batch->state_trans) > 0)
++                event_publish_state (batch->event, batch->state_trans);
+             json_decref (batch->state_trans);
+         }
+         if (batch->responses) {",Looks like my bad. Thanks for fixing!,"This check should be moved inside event_publish_state(), so that it is only called if state_trans is non-zero."
+81,"@@ -82,6 +82,7 @@ class Command:
+         no_cmd_split: If true, ';;' to split sub-commands is ignored.
+         backend: Which backend the command works with (or None if it works with
+                  both)
++        no_replace_variables: Whether or not to replace variables like {url}
+         _qute_args: The saved data from @cmdutils.argument
+         _needs_js: Whether the command needs javascript enabled
+         _modes: The modes the command can be executed in.","I think ""Don't replace variables ..."" would be cleaner.","I might be missing something, but I don't see where `no_replace_variables` is used."
+82,"@@ -82,8 +82,7 @@ class MPLPlot(DimensionedPlot):
+     sublabel_size = param.Number(default=18, doc=""""""
+          Size of optional subfigure label."""""")
+
+-    projection = param.ObjectSelector(default=None,
+-                                      objects=['3d', 'polar', None], doc=""""""
++    projection = param.Parameter(default=None, doc=""""""
+         The projection of the plot axis, default of None is equivalent to
+         2D plot, '3d' and 'polar' are also supported."""""")
+ ",Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate...,why do we need to change this?
+83,"@@ -40,13 +40,11 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
+ 	for i, dataDiskInfo := range dataDiskInfos {
+ 		dataDiskIndex := i + 1
+ 		dataDiskFilePath := dataDiskInfo.FilePath
+-		diskNames = append(
+-			diskNames,
+-			fmt.Sprintf(""%v-data-disk-%v"", w.Vars[""instance_name""].Value, dataDiskIndex))
++		diskNames = append(diskNames, generateDataDiskName(w.Vars[""instance_name""].Value, dataDiskIndex))
+
+ 		setupDataDiskStepName := fmt.Sprintf(""setup-data-disk-%v"", dataDiskIndex)
+-		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v"", dataDiskIndex)
+-		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%v-%v"", dataDiskIndex, w.Vars[""instance_name""].Value)
++		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v-%v"", dataDiskIndex, w.ID())
++		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%v-%v"", dataDiskIndex, w.ID())
+
+ 		setupDataDiskStep := daisy.NewStepDefaultTimeout(setupDataDiskStepName, w)
+ 		setupDataDiskStep.CreateDisks = &daisy.CreateDisks{",I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID().,Is there any reason we can't just use `fmt.Sprintf` here?
+84,"@@ -29,6 +29,11 @@ import java.util.Map;
+  * @param <F> the concrete Java class of a ContentFile instance.
+  */
+ public interface ContentFile<F> {
++  /**
++   * Returns the ordinal position of the file in a manifest, or null if it was not read from a manifest.
++   */
++  Long pos();
++
+   /**
+    * Returns id of the partition spec used for partition metadata.
+    */",qq: do we want to include anything in the name to indicate that it is a position in the manifest?,Is there a reason why this is not an int instead of a long?
+85,"@@ -969,8 +969,11 @@ public class VRBrowserActivity extends PlatformActivity implements WidgetManager
+         GleanMetricsService.stopImmersive();
+         Handler handler = new Handler(Looper.getMainLooper());
+         handler.postDelayed(() -> {
+-            mWindows.resumeCompositor();
+-            Log.d(LOGTAG, ""Compositor Resumed"");
++            if (!mWindows.isPaused()) {
++                Log.d(LOGTAG, ""Compositor resume begin"");
++                mWindows.resumeCompositor();
++                Log.d(LOGTAG, ""Compositor resume end"");
++            }
+         }, 20);
+     }
+ ",These logs should probably use the `LOGTAG`,Do we want to log when the commission is resumed?
+86,"@@ -28,10 +28,10 @@ import (
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/services/wireguard""
+ 	""github.com/mysteriumnetwork/node/services/wireguard/key""
+-	""github.com/mysteriumnetwork/wireguard-go/device""
+-	""github.com/mysteriumnetwork/wireguard-go/tun""
+ 	""github.com/pkg/errors""
+ 	""github.com/rs/zerolog/log""
++	""golang.zx2c4.com/wireguard/device""
++	""golang.zx2c4.com/wireguard/tun""
+ )
+
+ const (","From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing.",Can we remove this package now?
+87,"@@ -43,7 +43,7 @@ namespace Nethermind.JsonRpc
+
+         public static ResultWrapper<T> Fail(Exception e)
+         {
+-            return new() { Result = Result.Fail(e.ToString()), ErrorCode = ErrorCodes.InternalError};
++            return new() { Result = Result.Fail(e.Message), ErrorCode = ErrorCodes.InternalError};
+         }
+
+         public static ResultWrapper<T> Fail(string error, int errorCode, T outputData)",Any particular reason for this? This potentially will make harder to investigate users issues,why do we need to change `ToString` here?
+88,"@@ -999,7 +999,8 @@ Blockly.BlockSvg.prototype.updatePreviews = function(closestConnection,
+   // grayed-out blocks instead of highlighting the connection; for compatibility
+   // with Web Blockly the name ""highlightedConnection"" will still be used.
+   if (Blockly.highlightedConnection_ &&
+-      Blockly.highlightedConnection_ != closestConnection) {
++      (Blockly.highlightedConnection_ != closestConnection ||
++       Blockly.localConnection_ != localConnection)) {
+     if (Blockly.insertionMarker_ && Blockly.insertionMarkerConnection_) {
+       Blockly.BlockSvg.disconnectInsertionMarker();
+     }",Do you also need to check if Blockly.localConnection_ is non-null?,I don't think this is right. The localConnection_ will be different if the highlightedConnection is true and the localConnection is false.
+89,"@@ -1,5 +1,6 @@
+ module RSpec
+   module Core
++    # Internal container for global non-configuration data
+     class World
+
+       include RSpec::Core::Hooks","Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?",Can you add a `TODO` so we remember to remove this in the future?
+90,"@@ -3,6 +3,8 @@ const { basename } = require('./path-utils');
+ const shim = require('./shim').default;
+ const JoplinError = require('./JoplinError').default;
+ const { Buffer } = require('buffer');
++const { Readable } = require('stream').Readable;
++const { GetObjectCommand, ListObjectsV2Command, HeadObjectCommand, PutObjectCommand, DeleteObjectCommand, DeleteObjectsCommand } = require(""@aws-sdk/client-s3"");
+
+ const S3_MAX_DELETES = 1000;
+ ","The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], ""stream"").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(""data"", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?",Please move `require('stream')` to a new line at the end of this file.
+91,"@@ -93,7 +93,9 @@ func (m *MockStorer) Put(ctx context.Context, mode storage.ModePut, chs ...swarm
+ 			po := swarm.Proximity(ch.Address().Bytes(), m.baseAddress)
+ 			m.bins[po]++
+ 		}
+-		m.store[ch.Address().String()] = ch.Data()
++		b := make([]byte, len(ch.Data()))
++		copy(b, ch.Data())
++		m.store[ch.Address().String()] = b
+ 		m.modePut[ch.Address().String()] = mode
+
+ 		// pin chunks if needed","this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store",Shouldn't this be `ch.Data()` instead of `ch.Data()`?
+92,"@@ -42,6 +42,10 @@ import (
+ 	""go.uber.org/yarpc/yarpcerrors""
+ )
+
++func init() {
++	opentracing.SetGlobalTracer(nil)
++}
++
+ func TestHandlerSuccess(t *testing.T) {
+ 	mockCtrl := gomock.NewController(t)
+ 	defer mockCtrl.Finish()",wut. We can do this at the beginning of tests if we want right? Why are we depending on init?,why do we need this?
+93,"@@ -1403,9 +1403,12 @@ func (c *client) processConnect(arg []byte) error {
+ 				c.mu.Lock()
+ 				acc := c.acc
+ 				c.mu.Unlock()
++				srv.mu.Lock()
+ 				if acc != nil && acc != srv.gacc {
++					srv.mu.Unlock()
+ 					return ErrTooManyAccountConnections
+ 				}
++				srv.mu.Unlock()
+ 			}
+ 			c.authViolation()
+ 			return ErrAuthentication",Same trick here IMO.,"c.mu is read-only, s"
+94,"@@ -108,10 +108,11 @@ module Selenium
+
+         def initialize(source, duration, x, y, element: nil, origin: nil)
+           super(source)
++
+           @duration = duration * 1000
+           @x_offset = x
+           @y_offset = y
+-          @origin = element || origin
++          @origin = origin || POINTER
+         end
+
+         def type",Should be `@origin = element || origin || POINTER`,can we remove the el
+95,"@@ -50,11 +50,14 @@ func NewUpgradeCStorSPCJob() *cobra.Command {
+ 		Long:    cstorSPCUpgradeCmdHelpText,
+ 		Example: `upgrade cstor-spc --spc-name <spc-name>`,
+ 		Run: func(cmd *cobra.Command, args []string) {
++			util.CheckErr(options.RunCStorSPCUpgradeChecks(cmd, args), util.Fatal)
+ 			options.resourceKind = ""storagePoolClaim""
+-			util.CheckErr(options.RunPreFlightChecks(cmd), util.Fatal)
+-			util.CheckErr(options.RunCStorSPCUpgradeChecks(cmd), util.Fatal)
+-			util.CheckErr(options.InitializeDefaults(cmd), util.Fatal)
+-			util.CheckErr(options.RunCStorSPCUpgrade(cmd), util.Fatal)
++			if options.cstorSPC.spcName != """" {
++				singleCstorSPCUpgrade(cmd)
++			}
++			if len(args) != 0 {
++				bulkCstorSPCUpgrade(cmd, args)
++			}
+ 		},
+ 	}
+ ",this example needs a fix?,`--spc-name` is miss
+96,"@@ -248,9 +248,9 @@ static void close(struct roots_view *view) {
+ 	struct wlr_xdg_surface *surface = view->xdg_surface;
+ 	struct wlr_xdg_popup *popup = NULL;
+ 	wl_list_for_each(popup, &surface->popups, link) {
+-		wlr_xdg_surface_send_close(popup->base);
++		wlr_xdg_popup_destroy(popup->base);
+ 	}
+-	wlr_xdg_surface_send_close(surface);
++	wlr_xdg_toplevel_send_close(surface);
+ }
+
+ static void destroy(struct roots_view *view) {",Is it safe to assume this surface is a toplevel?,What does the `wl_list_for_each` do that you've added a `wlr_xdg_popup_destroy()` call?
+97,"@@ -225,6 +225,16 @@ projCtx pj_ctx_alloc()
+     return new (std::nothrow) projCtx_t(*pj_get_default_ctx());
+ }
+
++/************************************************************************/
++/*                            pj_ctx_clone()                            */
++/************************************************************************/
++
++projCtx pj_ctx_clone( projCtx ctx )
++
++{
++    return new (std::nothrow) projCtx_t(*ctx);
++}
++
+ /************************************************************************/
+ /*                            pj_ctx_free()                             */
+ /************************************************************************/",we don't need that function,Is this needed? It looks like it is only needed for the default ctx.
+98,"@@ -72,6 +72,13 @@ public enum Platform {
+     }
+   },
+
++  WIN10(""windows 10"", ""win10"") {
++    @Override
++    public Platform family() {
++      return WINDOWS;
++    }
++  },
++
+   MAC(""mac"", ""darwin"", ""os x"") {},
+
+   SNOW_LEOPARD(""snow leopard"", ""os x 10.6"") {","we'll also have to think about adding ""Windows Server 2014"" or whatever they come up with later.",I don't think this is the right place for this. The `WINDOWS` platform should only be r
+99,"@@ -35,6 +35,9 @@ public interface ExecutorLoader {
+   Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchActiveFlows()
+       throws ExecutorManagerException;
+
++  Pair<ExecutionReference, ExecutableFlow> fetchActiveFlowByExecId(int execId)
++      throws ExecutorManagerException;
++
+   List<ExecutableFlow> fetchFlowHistory(int skip, int num)
+       throws ExecutorManagerException;
+ ",curious do we have an API to fetch an inactive flow?,should this be called `fetchActiveFlowsByExecId`
+100,"@@ -116,10 +116,6 @@ function upgradeToVNodes(arr, offset) {
+ 		if (Array.isArray(obj)) {
+ 			upgradeToVNodes(obj);
+ 		}
+-		else if (obj && typeof obj==='object' && !isValidElement(obj) && ((obj.props && obj.type) || obj.text!=null)) {
+-			if (obj.text) continue;
+-			arr[i] = createElement(obj.type, obj.props, obj.props.children);
+-		}
+ 	}
+ }
+ ",This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now .,@dvoytenko is this safe to remove?
+101,"@@ -0,0 +1,16 @@
++const { getComposedParent } = axe.commons.dom;
++
++function shouldMatchElement(el) {
++	if (!el) {
++		return true;
++	}
++	const ariaHiddenValue = el.getAttribute('aria-hidden')
++		? el.getAttribute('aria-hidden')
++		: null;
++	if (ariaHiddenValue === null) {
++		return shouldMatchElement(getComposedParent(el));
++	}
++	return false;
++}
++
++return shouldMatchElement(getComposedParent(node));",Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability.,You don't need to pass `node` here
+102,"@@ -37,13 +37,14 @@ import pytest
+ import py.path  # pylint: disable=no-name-in-module
+
+ import helpers.stubs as stubsmod
++from helpers.utils import CallbackChecker
+ from qutebrowser.config import config, configdata, configtypes, configexc
+ from qutebrowser.utils import objreg, standarddir
+ from qutebrowser.browser.webkit import cookies
+ from qutebrowser.misc import savemanager, sql
+ from qutebrowser.keyinput import modeman
+
+-from PyQt5.QtCore import pyqtSignal, QEvent, QSize, Qt, QObject
++from PyQt5.QtCore import QEvent, QSize, Qt
+ from PyQt5.QtGui import QKeyEvent
+ from PyQt5.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout
+ from PyQt5.QtNetwork import QNetworkCookieJar",Please import modules and not classes (except for Qt stuff).,The name of this file has been cha
+103,"@@ -20,6 +20,11 @@ public class DummyJavaNode extends AbstractJavaNode {
+         super(id);
+     }
+
++    @Override
++    public void setImage(String image) {
++        super.setImage(image);
++    }
++
+     @Override
+     public Object jjtAccept(JavaParserVisitor visitor, Object data) {
+         return data;","Hm... why do we have a ""DummyJavaNode"" in src/main? Looks like, this should have gone into src/test....",The only thing I'm concerned about
+104,"@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
+ limitations under the License.
+ */
+
++// Package v1alpha1
+ package v1alpha1
+
+ // CasKey is used for all cas specific annotation keys",This seems meaningless. If we cannot add any info let us remove this.,This file has nothing to do with the v1alpha1 license. Please remove.
+105,"@@ -493,6 +493,14 @@ func (c *Container) GetLabels() map[string]string {
+ 	return c.labels
+ }
+
++// GetPorts gets the ports for a container
++func (c *Container) GetPorts() []PortBinding {
++	c.lock.RLock()
++	defer c.lock.RUnlock()
++
++	return c.Ports
++}
++
+ // HealthStatusShouldBeReported returns true if the health check is defined in
+ // the task definition
+ func (c *Container) HealthStatusShouldBeReported() bool {",Can you rename `Ports` to `PortsUnsafe`?,Why do we need the lock here?
+106,"@@ -0,0 +1,10 @@
++module ReturnToHelper
++  def make_return_to(name, path)
++    sig = OpenSSL::HMAC.digest(
++      OpenSSL::Digest::SHA256.new,
++      Rails.application.secrets.secret_key_base,
++      name + ""$"" + path
++    )
++    {name: name, path: path, sig: Base64.urlsafe_encode64(sig)}
++  end
++end",This feels like it could be moved out to your first gem!,Layout/IndentHash: Indent the right brace the same as the first posit
+107,"@@ -44,7 +44,7 @@ public abstract class NewSessionQueue implements HasReadyState {
+
+   public abstract boolean offerFirst(HttpRequest request, RequestId requestId);
+
+-  public abstract Optional<HttpRequest> poll();
++  public abstract Optional<HttpRequest> poll(RequestId requestId);
+
+   public abstract int clear();
+ ","The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here.",This is a breaking API change. I don't think we can do this.
+108,"@@ -7,4 +7,17 @@
+ axe.utils.toArray = function (thing) {
+ 	'use strict';
+ 	return Array.prototype.slice.call(thing);
+-};
++};
++
++
++/**
++ * Creates an array without duplicate values from 2 array inputs
++ * @param  {Array} arr1 First array
++ * @param  {Array} arr2 Second array
++ * @return {Array}
++ */
++axe.utils.uniqueArray = (arr1, arr2) => {
++  return arr1.concat(arr2).filter((elem, pos, arr) => {
++    return arr.indexOf(elem) === pos;
++  });
++};","This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs.",Can we use `Array.p.concat` here instead?
+109,"@@ -1676,9 +1676,10 @@ _tmain(int argc, TCHAR *targv[])
+     }
+ # ifdef UNIX
+     /* i#1676: detect whether under gdb */
+-    _snprintf(buf, BUFFER_SIZE_ELEMENTS(buf), ""/proc/%d/exe"", getppid());
+-    NULL_TERMINATE_BUFFER(buf);
+-    i = readlink(buf, buf, BUFFER_SIZE_ELEMENTS(buf));
++    char path_buf[MAXIMUM_PATH];
++    _snprintf(path_buf, BUFFER_SIZE_ELEMENTS(path_buf), ""/proc/%d/exe"", getppid());
++    NULL_TERMINATE_BUFFER(path_buf);
++    i = readlink(path_buf, buf, BUFFER_SIZE_ELEMENTS(buf));
+     if (i > 0) {
+         if (i < BUFFER_SIZE_ELEMENTS(buf))
+             buf[i] = '\0';","What is the problem here? The commit message has strange wording ""readlink is defined with restrict pointers"": do you mean ""restricted""? Is that a well-defined language term? I'm not sure what it means.",This needs to be made conditional on the
+110,"@@ -17,6 +17,7 @@ package com.google.api.codegen.util.ruby;
+ import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.util.NameFormatter;
+ import com.google.api.codegen.util.NamePath;
++import com.google.common.collect.ImmutableSet;
+
+ /**
+  * The NameFormatter for Ruby.",Why are we not wrapping here?,The commit message should describe the th
+111,"@@ -2,12 +2,10 @@
+
+ namespace Shopsys\FrameworkBundle\Model\Product\Filter;
+
+-use Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter;
+-
+ class ParameterFilterData
+ {
+     /**
+-     * @var \Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter
++     * @var \Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter|null
+      */
+     public $parameter;
+ ","I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?",Why did you remove this typehint?
+112,"@@ -22,16 +22,16 @@ var sourceHashes = map[string]string{
+ 	""libflux/flux-core/src/ast/flatbuffers/mod.rs"":                                                ""00c75dc1da14487953a4a017616fb8a237fe3da437c876f1328532dd7906f015"",
+ 	""libflux/flux-core/src/ast/flatbuffers/monotype.rs"":                                           ""4e82aae8e7edb8e230302241fe702ece9ae84fc708003c24709c2ea944cfaae8"",
+ 	""libflux/flux-core/src/ast/flatbuffers/tests.rs"":                                              ""ea85b78049f0c3d79daedcf9e171ccb00d0a596d1a643aa218590c99e6b160bc"",
+-	""libflux/flux-core/src/ast/mod.rs"":                                                            ""676e22d24cd7a97525688ed391a980d08b4bee40c5b5067d187f3ae6d66210ca"",
++	""libflux/flux-core/src/ast/mod.rs"":                                                            ""29b25b75a01cf1e1ac2b52d99b91986cec32011dc55af1ffd7f145838fce858d"",
+ 	""libflux/flux-core/src/ast/tests.rs"":                                                          ""bc7f77d569d8bbd4b9d00653f48bacd47eed46f53024dce836d3c8bbb6a80555"",
+ 	""libflux/flux-core/src/ast/walk/mod.rs"":                                                       ""e8a03023d7426bcf6dfdb1a61ac3263f5cf9194a595a1584dff7c899d06562f1"",
+ 	""libflux/flux-core/src/ast/walk/tests.rs"":                                                     ""f7b2d7dd5643bb795a86c04b6979b136b0de46b52b213caff094aed6d204a05d"",
+ 	""libflux/flux-core/src/formatter/mod.rs"":                                                      ""945736a4ad87adb6a3f359b6f2da6e5492b3cb0efd282e277303e2acae137763"",
+ 	""libflux/flux-core/src/formatter/tests.rs"":                                                    ""b0a10998a65fc4b54a8f68b3a0ed186d8548ba3d7638f911eb188d2ce485206f"",
+ 	""libflux/flux-core/src/lib.rs"":                                                                ""d19b7054e07f234c107d457030a0031374c123fe14a84a5b8e35537d138bac7a"",
+-	""libflux/flux-core/src/parser/mod.rs"":                                                         ""e3f11fe29f47271b5c04accc2d7efa35e1dc62c6de036bf0cc0cccda5e4742e8"",
++	""libflux/flux-core/src/parser/mod.rs"":                                                         ""daf24b2c439f4c7a6f138e2b25064a205aee73bb6cffc898df22dd0c962ca5df"",
+ 	""libflux/flux-core/src/parser/strconv.rs"":                                                     ""748c82f6efc2eafaafb872db5b4185ce29aafa8f03ba02c4b84f4a9614e832d2"",
+-	""libflux/flux-core/src/parser/tests.rs"":                                                       ""e3a7c9222f90323a7ea9b319bd84f96f66c6f115af6d199a0da332c894713ae4"",
++	""libflux/flux-core/src/parser/tests.rs"":                                                       ""43a1e5d3de85d76da2107544e417f583a1f66c20910286285b9645a309c42425"",
+ 	""libflux/flux-core/src/scanner/mod.rs"":                                                        ""2e15c9e0a73d0936d2eaeec030b636786db6dbe7aab673045de3a3e815c49f8a"",
+ 	""libflux/flux-core/src/scanner/scanner.rl"":                                                    ""530c062363b66daded3c521af44111b99ffee0eeb2a12ccffa8b8f349002d852"",
+ 	""libflux/flux-core/src/scanner/scanner_generated.rs"":                                          ""d65dcc216ccbb88d8f2e261a994ba2789075e434cb7a0f5e39e390bee2821e5b"",",Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily.,Did you mean to remove this?
+113,"@@ -440,18 +440,6 @@ func parseConfig(loc location.Location, opts options.Options) (interface{}, erro
+ 			cfg.ProjectID = os.Getenv(""GOOGLE_PROJECT_ID"")
+ 		}
+
+-		if cfg.JSONKeyPath == """" {
+-			if path := os.Getenv(""GOOGLE_APPLICATION_CREDENTIALS""); path != """" {
+-				// Check read access
+-				if _, err := ioutil.ReadFile(path); err != nil {
+-					return nil, errors.Fatalf(""Failed to read google credential from file %v: %v"", path, err)
+-				}
+-				cfg.JSONKeyPath = path
+-			} else {
+-				return nil, errors.Fatal(""No credential file path is set"")
+-			}
+-		}
+-
+ 		if err := opts.Apply(loc.Scheme, &cfg); err != nil {
+ 			return nil, err
+ 		}","We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!",This means we can no longer
+114,"@@ -1,11 +1,12 @@
+ package plugin
+
+ type Config struct {
+-	SocketPath string        `yaml:""path""`
+-	Volumes    VolumesConfig `yaml:""volume""`
++	SocketDir string                       `yaml:""socket_dir"" default:""/run/docker/plugins""`
++	Volumes   VolumesConfig                `yaml:""volume""`
++	GPUs      map[string]map[string]string `yaml:""GPUs""`
+ }
+
+ type VolumesConfig struct {
+-	Root    string
++	Root    string `yaml:""root"" default:""/var/lib/docker-volumes""`
+ 	Volumes map[string]map[string]string
+ }",No need to speficy attribute here. Moreover in yaml it is default to use lowercase names.,why is this in here?
+115,"@@ -8,10 +8,12 @@ using System;
+ using System.Collections.Generic;
+ using System.Globalization;
+ using System.IO;
++using System.Linq;
+ using System.Net;
+ using System.Net.Http;
+ using System.Text;
+ using System.Threading;
++using System.Threading.Tasks;
+ using Task = System.Threading.Tasks.Task;
+
+ namespace Microsoft.DotNet.Build.CloudTestTasks",In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?,Can you revert this change p
+116,"@@ -151,7 +151,9 @@ class BlacklistRuleBook(bre.BaseRuleBook):
+             lists: first one is IP addresses,
+             second one is network blocks
+         """"""
+-        data = urllib2.urlopen(url).read()
++        req = urllib2.build_opener()
++        req.addheaders = [('User-Agent', 'Forseti blacklist rules engine agent')]
++        data = req.open(url).read()
+         ip_addresses = re.findall(r'^[0-9]+(?:\.[0-9]+){3}$', data, re.M)
+         netblocks = re.findall(r'^[0-9]+(?:\.[0-9]+){0,3}/[0-9]{1,2}$',
+                                data, re.M)","Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?",why do we need to set this?
+117,"@@ -1405,6 +1405,8 @@ def getFormatFieldSpeech(attrs,attrsCache=None,formatConfig=None,unit=None,extra
+ 		linePrefix=attrs.get(""line-prefix"")
+ 		if linePrefix:
+ 			textList.append(linePrefix)
++	breakpoint=attrs.get(""breakpoint"")
++	if breakpoint: textList.append(breakpoint)
+ 	if attrsCache is not None:
+ 		attrsCache.clear()
+ 		attrsCache.update(attrs)","@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?","why not just `attrs.get(""br"
+118,"@@ -539,7 +539,10 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            return self.size, self.location
+
+     @property
+     def screenshot_as_base64(self):",This would return a tuple of two dictionaries. You need to combine them and return a dictionary,I don't think this change i
+119,"@@ -7,10 +7,14 @@ import (
+ 	""errors""
+ 	""fmt""
+
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/manifest""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/secretsmanager""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/ssm""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/color""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/log""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/prompt""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/workspace""
+
+ 	""github.com/spf13/cobra""
+ )","What do you think of moving the example to the help text of the prompt? and the prompt itself can be ""What is your application's GitHub repository URL?""",Nit: please sort this new i
+120,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,Maybe add a constant for the string?
+121,"@@ -266,7 +266,7 @@ bool parse_it(Iterator &first, Iterator last, RDKit::RWMol &mol) {
+       } else {
+         if (!parse_atom_labels(first, last, mol)) return false;
+       }
+-    } else if ((first + 9) < last &&
++    } else if (std::distance(first, last) > 9 &&
+                std::string(first, first + 9) == ""atomProp:"") {
+       first += 9;
+       if (!parse_atom_props(first, last, mol)) return false;",Nice use of std::distance. I'm a bit worried about first += 9 though.,"Don't use `std::distance`, use `std:"
+122,"@@ -578,8 +578,9 @@ func (c *Operator) syncNodeEndpoints(ctx context.Context) error {
+ 		ObjectMeta: metav1.ObjectMeta{
+ 			Name: c.kubeletObjectName,
+ 			Labels: c.config.Labels.Merge(map[string]string{
+-				""k8s-app"":                ""kubelet"",
+-				""app.kubernetes.io/name"": ""kubelet"",
++				""k8s-app"":                   ""kubelet"",
++				""app.kubernetes.io/name"":    ""kubelet"",
++				""app.kubernetes.io/part-of"": ""prometheus-operator"",
+ 			}),
+ 		},
+ 		Subsets: []v1.EndpointSubset{","Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?",Could you also fix the formatting of
+123,"@@ -41,8 +41,9 @@ namespace Datadog.Trace.ClrProfiler
+
+                 if (parent != null &&
+                     parent.Type == SpanTypes.Http &&
+-                    parent.GetTag(Tags.HttpMethod).Equals(httpMethod, StringComparison.OrdinalIgnoreCase) &&
+-                    parent.GetTag(Tags.HttpUrl).Equals(UriHelpers.CleanUri(requestUri, removeScheme: false, tryRemoveIds: false), StringComparison.OrdinalIgnoreCase))
++                    parent.GetTag(Tags.InstrumentationName) != null &&
++                    httpMethod.Equals(parent.GetTag(Tags.HttpMethod), StringComparison.OrdinalIgnoreCase) &&
++                    UriHelpers.CleanUri(requestUri, removeScheme: false, tryRemoveIds: false).Equals(parent.GetTag(Tags.HttpUrl), StringComparison.OrdinalIgnoreCase))
+                 {
+                     // we are already instrumenting this,
+                     // don't instrument nested methods that belong to the same stacktrace","As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?",Shouldn't this be instrumentationNam
+124,"@@ -19,6 +19,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/node""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/update""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/version""
++	xrc20 ""github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20""
+ )
+
+ // RootCmd represents the base command when called without any subcommands",No need to have `xrc20` alias,"didn't notice this already, but xrc20 looks like a typo and should be icmp20"
+125,"@@ -172,6 +172,19 @@ def define_environment_cls(pipeline_def):
+     )
+
+
++def context_cls_inst(pipeline_def):
++    check.inst_param(pipeline_def, 'pipeline_def', PipelineDefinition)
++    pipeline_name = camelcase(pipeline_def.name)
++    return SystemNamedDict(
++        name='{pipeline_name}.Context'.format(pipeline_name=pipeline_name),
++        fields={
++            'context': define_maybe_optional_selector_field(
++                define_context_context_cls(pipeline_name, pipeline_def.context_definitions)
++            )
++        },
++    ).inst()
++
++
+ def define_expectations_config_cls(name):
+     check.str_param(name, 'name')
+ ",the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn,Maybe use `PipelineDefinition.name` instead of `pipeline_name` as the param
+126,"@@ -54,6 +54,7 @@ public class BlockMiner<C, M extends AbstractBlockCreator<C>> implements Runnabl
+   private final ProtocolSchedule<C> protocolSchedule;
+   private final Subscribers<MinedBlockObserver> observers;
+   private final AbstractBlockScheduler scheduler;
++  private Boolean gpuMining = false;
+
+   public BlockMiner(
+       final Function<BlockHeader, M> blockCreatorFactory,","Don't call it GPU mining, call it `externalMining`, here and throughout.",Can we make this final and default to true?
+127,"@@ -252,6 +252,15 @@ return [
+     | folder - a folder prefix for storing all generated files inside.
+     | path   - the public path relative to the application base URL,
+     |          or you can specify a full URL path.
++    |
++    | For the 'media' resource you can also specify:
++    |
++    | imageMaxWidth     - Resize all media manager image uploads to be
++    |                     within this with (in pixels, 0 = ignore)
++    | imageMaxHeight    - Resize all media manager image uploads to be
++    |                     within this height (in pixels, 0 = ignore)
++    | imageQuality      - Set this quality to all media manager image uploads
++    |                     (1-100)
+     */
+
+     'storage' => [","`within this with` typo, should be `within this width`",(1-100) should be a constant.
+128,"@@ -22,10 +22,12 @@ import (
+ )
+
+ // Prometheus defines a Prometheus deployment.
++// +k8s:openapi-gen=true
+ type Prometheus struct {
+ 	metav1.TypeMeta `json:"",inline""`
+ 	// Standard object’s metadata. More info:
+ 	// https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#metadata
++	// +k8s:openapi-gen=false
+ 	metav1.ObjectMeta `json:""metadata,omitempty""`
+ 	// Specification of the desired behavior of the Prometheus cluster. More info:
+ 	// https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#spec-and-status",how come this is false?,What about making `prometheus.go` making only the `openapi-gen` tag? This would be more consistent with how we use it in other places in the code.
+129,"@@ -24,6 +24,19 @@ function node_require(module) {
+     return require(module);
+ }
+
++function typeOf(obj) {
++    return ({}).toString.call(obj).match(/\s(\w+)/)[1].toLowerCase();
++}
++
++function checkTypes(args, types) {
++    args = [].slice.call(args);
++    for (var i = 0; i < types.length; ++i) {
++        if (typeOf(args[i]) !== types[i]) {
++            throw new TypeError('param ' + i + ' must be of type ' + types[i]);
++        }
++    }
++}
++
+ const performFetch = typeof fetch === 'undefined' ? node_require('node-fetch') : fetch;
+
+ const url_parse = require('url-parse');",How about `Object.prototype.toString`? Or using the `typeof` operator?,`\s` is redundant with `\w`
+130,"@@ -83,6 +83,7 @@ type ReporterKBPKI struct {
+ 	notifySyncBuffer chan *keybase1.FSPathSyncStatus
+ 	suppressCh       chan time.Duration
+ 	canceler         func()
++	ctx              context.Context
+ }
+
+ // NewReporterKBPKI creates a new ReporterKBPKI.","I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly.",not needed anymore?
+131,"@@ -12,12 +12,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Networking
+         {
+             IsWindows = PlatformApis.IsWindows;
+
+-            var isDarwinMono =
+-#if DNX451
+-                IsWindows ? false : PlatformApis.IsDarwin;
+-#else
+-                false;
+-#endif
++            var isDarwinMono = !IsWindows && PlatformApis.IsDarwin;
+
+             if (isDarwinMono)
+             {",This check isn't right though.,Shouldn't this be `PlatformApis.IsWindows || PlatformApis.IsDarwin`?
+132,"@@ -96,6 +96,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+     return missingDefaultServiceAddress() || missingDefaultServiceScopes();
+   }
+
++  public abstract String codeGenVersion();
++
+   @Override
+   public String resourceRoot() {
+     return SnippetSetRunner.SNIPPET_RESOURCE_ROOT;","maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself.",I'm not sure how I feel about this. It feels like an antipattern to me.
+133,"@@ -230,15 +230,13 @@ module.exports = class XHRUpload extends Plugin {
+           const body = opts.getResponseData(xhr.responseText, xhr)
+           const uploadURL = body[opts.responseUrlFieldName]
+
+-          const response = {
++          const uploadResp = {
+             status: ev.target.status,
+             body,
+             uploadURL
+           }
+
+-          this.uppy.setFileState(file.id, { response })
+-
+-          this.uppy.emit('upload-success', file, body, uploadURL)
++          this.uppy.emit('upload-success', file, uploadResp)
+
+           if (uploadURL) {
+             this.uppy.log(`Download ${file.name} from ${file.uploadURL}`)","the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now ","It looks like the code below calls `setFileState` directly, so why remo"
+134,"@@ -134,7 +134,7 @@ func (s *stream) Read(p []byte) (int, error) {
+ 			} else {
+ 				select {
+ 				case <-s.readChan:
+-				case <-time.After(deadline.Sub(time.Now())):
++				case <-time.After(time.Until(deadline)):
+ 				}
+ 			}
+ 			s.mutex.Lock()",This isn't really easy to read.,"If the deadline is after the read, should we just return?"
+135,"@@ -123,7 +123,7 @@ func (c *CStorVolumeReplicaController) cVREventHandler(operation common.QueueOpe
+
+ 		err := volumereplica.DeleteVolume(fullVolName)
+ 		if err != nil {
+-			glog.Errorf(""Error in deleting volume %q: %s"", cVR.ObjectMeta.Name,err)
++			glog.Errorf(""Error in deleting volume %q: %s"", cVR.ObjectMeta.Name, err)
+ 			c.recorder.Event(cVR, corev1.EventTypeWarning, string(common.FailureDestroy), string(common.MessageResourceFailDestroy))
+ 			return string(apis.CVRStatusDeletionFailed), err
+ 		}",This line changed due to go formatting. Format was not there earlier.,removing a space character.
+136,"@@ -28,13 +28,13 @@ type staticUpstream struct {
+ 		Path     string
+ 		Interval time.Duration
+ 	}
++	Without string
+ }
+
+ // NewStaticUpstreams parses the configuration input and sets up
+ // static upstreams for the proxy middleware.
+ func NewStaticUpstreams(c parse.Dispenser) ([]Upstream, error) {
+ 	var upstreams []Upstream
+-
+ 	for c.Next() {
+ 		upstream := &staticUpstream{
+ 			from:        """",","The name ""Without"" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)",`from` and `to` are already part of `Upstream`. I'd suggest to use `Upstream` instead of `Without`.
+137,"@@ -254,6 +254,12 @@ public class MoveIT {
+         linkDataset.then().assertThat()
+                 .statusCode(OK.getStatusCode());
+
++        // A dataset cannot be linked to the same dataverse again.
++        Response tryToLinkAgain = UtilIT.linkDataset(datasetPid, dataverse2Alias, superuserApiToken);
++        tryToLinkAgain.prettyPrint();
++        tryToLinkAgain.then().assertThat()
++                .statusCode(FORBIDDEN.getStatusCode());
++
+         Response getLinksBefore = UtilIT.getDatasetLinks(datasetPid, superuserApiToken);
+         getLinksBefore.prettyPrint();
+         getLinksBefore.then().assertThat()","is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here.","Instead of introducing a new enum response, why not use a simple string like ""A dataset cannot be l"
+138,"@@ -368,5 +368,8 @@ type Instance struct {
+ 	EBSOptimized *bool `json:""ebsOptimized""`
+
+ 	// The tags associated with the instance.
+-	Tags map[string]string `json:""tag""`
++	Tags map[string]string `json:""tags""`
++
++	// The security groups associated with the instance.
++	SecurityGroups map[string]string `json:""securityGroups""`
+ }","I'm not sure if this wanted to be `json:""tags""` (which I'd set in my PR) or `json:""tag""` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`.",Let's change the variable name to `SecurityGroups` to match the other tags and security groups.
+139,"@@ -47,6 +47,11 @@ module Ncr
+       message: ""must be three letters or numbers""
+     }, allow_blank: true
+
++    scope :for_fiscal_year, lambda { |year|
++      range = self.class.range_for_fiscal_year(year)
++      where(created_at: range[:start_time]...range[:end_time])
++    }
++
+     def self.all_system_approver_emails
+       [
+         self.ba61_tier1_budget_mailbox,","since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?",Line is too long. [99/80]
+140,"@@ -42,6 +42,11 @@ class InfluxWriterSubscriber(object):
+         self.time = 0
+
+
++    def on_connection_closed(self, connection, reply_code, reply_text):
++        self.log.info('RabbitMQ connection got closed!')
++        self.connection.add_timeout(5, self.connect_to_rabbitmq)
++
++
+     @staticmethod
+     def static_callback(ch, method, properties, body, obj):
+         return obj.callback(ch, method, properties, body)",there is no static method as a go between -- how does this work?,probably better to use the constant defined in rabbitmq.constants.
+141,"@@ -0,0 +1,8 @@
++# frozen_string_literal: true
++# encoding: utf-8
++
++class StringifiedSymbol
++  include Mongoid::Document
++  store_in collection: ""stringified_symbols"", client: :other
++  field :stringified_symbol, type: StringifiedSymbol
++end",Can you please change the name of this class to be something else?,The `other` field doesn't seem to be necessary here.
+142,"@@ -403,7 +403,7 @@ size_t h2o_strstr(const char *haysack, size_t haysack_len, const char *needle, s
+ }
+
+ /* note: returns a zero-width match as well */
+-const char *h2o_next_token(h2o_iovec_t *iter, int separator, size_t *element_len, h2o_iovec_t *value)
++const char *h2o_next_token(h2o_iovec_t *iter, int separator, size_t *element_len, h2o_iovec_t *value, int coma_separator)
+ {
+     const char *cur = iter->base, *end = iter->base + iter->len, *token_start, *token_end;
+ ","I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`.","h2o_next_token is now unused, should it be removed from the interf"
+143,"@@ -43,8 +43,8 @@ namespace Nethermind.Blockchain
+     {
+         private const long LowestInsertedBodyNumberDbEntryAddress = 0;
+         private const int CacheSize = 64;
+-        private readonly ICache<Keccak, Block> _blockCache = new LruCacheWithRecycling<Keccak, Block>(CacheSize, CacheSize, ""blocks"");
+-        private readonly ICache<Keccak, BlockHeader> _headerCache = new LruCacheWithRecycling<Keccak, BlockHeader>(CacheSize, CacheSize, ""headers"");
++        private readonly ICache<Keccak, Block> _blockCache = new LruCache<Keccak, Block>(CacheSize, CacheSize, ""blocks"");
++        private readonly ICache<Keccak, BlockHeader> _headerCache = new LruCache<Keccak, BlockHeader>(CacheSize, CacheSize, ""headers"");
+
+         private const int BestKnownSearchLimit = 256_000_000;
+ ",why not recycling? I Lru cache now recycling?,Why not `ConcurrentDictionary`?
+144,"@@ -69,7 +69,7 @@ func (consumer *createConsumer) Consume(requestPtr interface{}) (response interf
+ 	issuerID := consumer.peerID
+ 	if request.ConsumerInfo != nil {
+ 		issuerID = request.ConsumerInfo.IssuerID
+-		if request.ConsumerInfo.PaymentVersion == PaymentVersionV2 {
++		if request.ConsumerInfo.PaymentVersion == PaymentVersionV3 {
+ 			indicateNewVersion = true
+ 		}
+ 	} else {",Why it is now called `PaymentVersionV3`?,Don't we need to check if the version is > 3.0?
+145,"@@ -165,7 +165,7 @@ func (dc *DownstreamController) syncSecret() {
+ 			}
+
+ 			nodes := dc.lc.SecretNodes(secret.Namespace, secret.Name)
+-			klog.Infof(""there are %d nodes need to sync secret, operation: %s"", len(nodes), e.Type)
++			klog.V(4).Infof(""there are %d nodes need to sync secret, operation: %s"", len(nodes), e.Type)
+ 			for _, n := range nodes {
+ 				msg := model.NewMessage("""")
+ 				msg.SetResourceVersion(secret.ResourceVersion)",changed for debug purpose?,why not log as `V(4)`?
+146,"@@ -46,6 +46,13 @@ namespace OpenTelemetry
+         /// <inheritdoc />
+         public abstract override void OnEnd(T data);
+
++        internal override void SetParentProvider(BaseProvider parentProvider)
++        {
++            base.SetParentProvider(parentProvider);
++
++            this.exporter.ParentProvider = parentProvider;
++        }
++
+         /// <inheritdoc />
+         protected override bool OnShutdown(int timeoutMilliseconds)
+         {",@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though.,Can this be made private?
+147,"@@ -31,9 +31,13 @@ inline extractor::RoadClassification roadClass(const ConnectedRoad &road,
+     return graph.GetEdgeData(road.eid).flags.road_classification;
+ }
+
+-inline bool isRampClass(EdgeID eid, const util::NodeBasedDynamicGraph &node_based_graph)
++inline bool isRampClass(EdgeID eid,
++                        const util::NodeBasedDynamicGraph &node_based_graph,
++                        bool from_motorway = true)
+ {
+-    return node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass();
++    return node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass() ||
++           (from_motorway &&
++            node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass());
+ }
+
+ } // namespace",Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario.,I'm wondering if `IsRampClass` should be rename
+148,"@@ -13,7 +13,7 @@ module Beaker
+           :q_verify_packages => ENV['q_verify_packages'] || 'y',
+           :q_puppet_symlinks_install => 'y',
+           :q_puppetagent_certname => host,
+-          :q_puppetagent_server => master,
++          :q_puppetagent_server => master_certname,
+
+           # Disable database, console, and master by default
+           # This will be overridden by other blocks being merged in.",where does `master_certname` come from?,Use the new Ruby 1.9 hash syntax.
+149,"@@ -1,5 +1,7 @@
+ from .resnet import ResNet, make_res_layer
+ from .resnext import ResNeXt
+ from .ssd_vgg import SSDVGG
++from .hrnet import HRNet
+
+-__all__ = ['ResNet', 'make_res_layer', 'ResNeXt', 'SSDVGG']
++__all__ = ['ResNet', 'make_res_layer', 'ResNeXt', 'SSDVGG',
++           'HRNet']",The line breaking is unnecessary.,Why do you add HRNet here? I am n
+150,"@@ -28,7 +28,7 @@ void DatasetLoader::SetHeader(const char* filename) {
+     // get column names
+     if (io_config_.has_header) {
+       std::string first_line = text_reader.first_line();
+-      feature_names_ = Common::Split(first_line.c_str(), ""\t ,"");
++      feature_names_ = Common::Split(first_line.c_str(), ""\t,"");
+     }
+
+     // load label idx first",why not enable split by space here ?,Will this break some existing cod
+151,"@@ -1076,7 +1076,8 @@ fpga_result mmio_error(struct RASCommandLine *rasCmdLine)
+ 		return result;
+ 	}
+
+-	if(value != FPGA_INTEGRATED_DEVICEID) {
++	if( (value != FPGA_INTEGRATED_DEVICEID) ||
++		(value != FPGA_DISCRETE_DEVICEID) ) {
+ 		FPGA_ERR(""Failed  to read Device id"");
+ 		return FPGA_NOT_SUPPORTED;
+ 	}",Shouldn't the operator be && ?,Please add a space between `if` a
+152,"@@ -161,6 +161,17 @@ module Beaker
+       FileUtils.rm_rf(@vagrant_path)
+     end
+
++    #snapshotting depends on https://github.com/scalefactory/vagrant-multiprovider-snap
++    def take_snapshot(host,snapshot_name)
++      @logger.debug ""Creating snapshot of #{host}""
++      vagrant_cmd(""snap take #{host} --name=#{snapshot_name}"")
++    end
++
++    def restore_snapshot(host,snapshot_name)
++      @logger.debug ""Restoring snapshot of #{host}""
++      vagrant_cmd(""snap rollback #{host} --name=#{snapshot_name}"")
++    end
++
+     def vagrant_cmd(args)
+       Dir.chdir(@vagrant_path) do
+         exit_status = 1",My best guess is that you want to use host.name in these parts to get the name of the host ?,"Can you please add a space after the `,`?"
+153,"@@ -270,13 +270,6 @@ func (n *Node) UnmarshalBinary(data []byte) error {
+
+ 		n.entry = append([]byte{}, data[nodeHeaderSize:nodeHeaderSize+refBytesSize]...)
+ 		offset := nodeHeaderSize + refBytesSize // skip entry
+-		// Currently we don't persist the root nodeType when we marshal the manifest, as a result
+-		// the root nodeType information is lost on Unmarshal. This causes issues when we want to
+-		// perform a path 'Walk' on the root. If there is more than 1 fork, the root node type
+-		// is an edge, so we will deduce this information from index byte array
+-		if !bytes.Equal(data[offset:offset+32], make([]byte, 32)) {
+-			n.nodeType = nodeTypeEdge
+-		}
+ 		n.forks = make(map[byte]*fork)
+ 		bb := &bitsForBytes{}
+ 		bb.fromBytes(data[offset:])","IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`",We can remove the `nodeType` field from `
+154,"@@ -205,9 +205,10 @@ public class DownloadService extends Service {
+         Log.d(TAG, ""Service shutting down"");
+         isRunning = false;
+
++        boolean showAutoDownloadReport = UserPreferences.showAutoDownloadReport();
+         if (ClientConfig.downloadServiceCallbacks.shouldCreateReport()
+-                && UserPreferences.showDownloadReport()) {
+-            notificationManager.updateReport(reportQueue);
++                && (UserPreferences.showDownloadReport() || showAutoDownloadReport)) {
++            notificationManager.updateReport(reportQueue, showAutoDownloadReport);
+             reportQueue.clear();
+         }
+ ","Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though.",What do you think about moving the call t
+155,"@@ -140,3 +140,11 @@ func (c *Call) RoutingDelegate() string {
+ 	}
+ 	return c.ic.req.RoutingDelegate
+ }
++
++// Features returns the RequestFeatures for this request.
++func (c *Call) Features() transport.RequestFeatures {
++	if c == nil {
++		return transport.RequestFeatures{}
++	}
++	return c.ic.req.Features
++}",Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?,If this is the only place where `c` is us
+156,"@@ -1202,3 +1202,15 @@ L:
+ 	}
+ 	return filtered
+ }
++
++func (a *WebAPI) GenerateAPIKey(ctx context.Context, req *webservice.GenerateAPIKeyRequest) (*webservice.GenerateAPIKeyResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *WebAPI) DisableAPIKey(ctx context.Context, req *webservice.DisableAPIKeyRequest) (*webservice.DisableAPIKeyResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *WebAPI) ListAPIKeys(ctx context.Context, req *webservice.ListAPIKeysRequest) (*webservice.ListAPIKeysResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}",`ctx` is unused in GenerateAPIKey,[nit] This method doesn't seem to be used anywhere.
+157,"@@ -75,6 +75,7 @@ type (
+ func NewBlockDAO(indexers []BlockIndexer, cfg config.DB) BlockDAO {
+ 	blkStore, err := filedao.NewFileDAO(cfg)
+ 	if err != nil {
++		log.L().Fatal(err.Error(), zap.Any(""cfg"", cfg))
+ 		return nil
+ 	}
+ 	return createBlockDAO(blkStore, indexers, cfg)",Can you judge the type of error?,This should be done in `init()` as well.
+158,"@@ -204,7 +204,7 @@ class GridInterface(DictInterface):
+         if edges and not isedges:
+             data = cls._infer_interval_breaks(data)
+         elif not edges and isedges:
+-            data = np.convolve(data, [0.5, 0.5], 'valid')
++            data = data[:-1] + np.diff(data)/2.
+         return data
+
+ ",Much simpler than a weird and confusing ``convolve`` call!,"why not `np.diff(data, axis=1)`?"
+159,"@@ -739,8 +739,8 @@ describe('suspense', () => {
+ 				expect(scratch.innerHTML).to.eql(
+ 					`<div>Hello first 2</div><div>Hello second 2</div>`
+ 				);
+-				expect(Suspender1.prototype.render).to.have.been.calledThrice;
+-				expect(Suspender2.prototype.render).to.have.been.calledThrice;
++				expect(Suspender1.prototype.render).to.have.been.calledTwice;
++				expect(Suspender2.prototype.render).to.have.been.calledTwice;
+ 			});
+ 		});
+ 	});","Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `<div>Hello second 2</div>` output... Imma take a peak at these tests to understand what's going on",The `Suspender1` and `Suspender2` classes have thei
+160,"@@ -80,6 +80,10 @@ class ApplicationController < ActionController::Base
+   def failed_destroy_error(obj, obj_name)
+     ""#{_('Could not delete the %{o}.') % {o: obj_name}} #{errors_to_s(obj)}""
+   end
++
++  def success_message(obj_name, action)
++    ""#{_('Successfully %{action} your %{object}.') % {object: obj_name, action: action}}""
++  end
+
+   private
+     # Override rails default render action to look for a branded version of a","Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper.",Layout/SpaceInsideBlockBraces: Space inside { missing.<br>Layout/SpaceInsideBlockBraces: Space inside } missing.
+161,"@@ -92,7 +92,7 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme
+
+ # Template used to display messages. This is a python new-style format string
+ # used to format the message information. See doc for all details
+-#msg-template=
++msg-template=[{msg_id}] {path}:{line:3d}:{column}: {msg}
+
+
+ [SPELLING]","Will this mess up parsing the messages by other editors? (vscode, vim ...)",Is this supposed to be part of this PR?
+162,"@@ -1,4 +1,3 @@
+-# Set up gems listed in the Gemfile.
+-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
++ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+
+-require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
++require 'bundler/setup' # Set up gems listed in the Gemfile.",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Lint/DeprecatedClassMethods: File.expand_path is deprecated in favor of File.path.expand_path.
+163,"@@ -28,8 +28,13 @@ namespace Microsoft.AspNet.Server.Kestrel.Filter
+             _filteredStream = filteredStream;
+             _socketInputStream = new SocketInputStream(SocketInput);
+
+-            _filteredStream.CopyToAsync(_socketInputStream).ContinueWith((task, state) =>
++            var block = memory.Lease();
++            // Use pooled block for copy
++            _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) =>
+             {
++                var returnedBlock = task.Result;
++                returnedBlock.Pool?.Return(returnedBlock);
++
+                 ((FilteredStreamAdapter)state).OnStreamClose(task);
+             }, this);
+         }",Why can the pool be null?,Is there a reason we are leaking the pooled block here?
+164,"@@ -74,6 +74,15 @@ class ToggleButton(ia2Web.Ia2Web):
+ 		return states
+
+
++class PresentationalList(ia2Web.Ia2Web):
++	"""""" Ensures that lists like UL, DL and OL always have the readonly state.""""""
++
++	def _get_states(self):
++		states = super().states
++		states.add(controlTypes.STATE_READONLY)
++		return states
++
++
+ def findExtraOverlayClasses(obj, clsList):
+ 	""""""Determine the most appropriate class(es) for Chromium objects.
+ 	This works similarly to L{NVDAObjects.NVDAObject.findOverlayClasses} except that it never calls any other findOverlayClasses method.","It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable.",This doesn't need to be in Ia2Web?
+165,"@@ -66,16 +66,16 @@ import java.util.Set;
+  * the current node) may be queried.
+  *
+  */
+-class DigraphNode implements Cloneable, Serializable {
++class DigraphNode<E> implements Cloneable, Serializable {
+
+     /** The data associated with this node. */
+-    protected Object data;
++    protected E data;
+
+     /**
+      * A <code>Set</code> of neighboring nodes pointed to by this
+      * node.
+      */
+-    protected Set outNodes = new HashSet();
++    protected Set<DigraphNode<E>> outNodes = new HashSet<>();
+
+     /** The in-degree of the node. */
+     protected int inDegree = 0;",This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?,Why do you change this to `E`?
+166,"@@ -282,8 +282,12 @@ void nano::bootstrap_attempt_legacy::request_push (nano::unique_lock<std::mutex>
+ void nano::bootstrap_attempt_legacy::add_frontier (nano::pull_info const & pull_a)
+ {
+ 	nano::pull_info pull (pull_a);
+-	nano::lock_guard<std::mutex> lock (mutex);
+-	frontier_pulls.push_back (pull);
++	// Prevent incorrent or malicious pulls with frontier 0 insertion
++	if (!pull.head.is_zero ())
++	{
++		nano::lock_guard<std::mutex> lock (mutex);
++		frontier_pulls.push_back (pull);
++	}
+ }
+
+ void nano::bootstrap_attempt_legacy::add_bulk_push_target (nano::block_hash const & head, nano::block_hash const & end)",There doesn't seem to be a reason to copy this here.,Shouldn't this be in a lock?
+167,"@@ -1774,6 +1774,7 @@ std::string h2o_raw_tracer::bpf_text() {
+
+ #include <linux/sched.h>
+ #include <linux/limits.h>
++#include ""include/h2o/ebpf.h""
+
+ #define STR_LEN 64
+ ","We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs.",Isn't there a way to avoid this? E
+168,"@@ -170,6 +170,10 @@ type ThanosRulerSpec struct {
+ 	// Note: Currently only the CAFile, CertFile, and KeyFile fields are supported.
+ 	// Maps to the '--grpc-server-tls-*' CLI args.
+ 	GRPCServerTLSConfig *TLSConfig `json:""grpcServerTlsConfig,omitempty""`
++	// The external Query URL the Thanos Ruler will set in the 'Source' field
++	// of all alerts.
++	// Maps to the '--alert.query-url' CLI arg.
++	AlertQueryURL string `json:""alertQueryUrl,omitempty""`
+ }
+
+ // ThanosRulerStatus is the most recent observed status of the ThanosRuler. Read-only. Not",I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses.,"Did you mean for this field to be optional? If so, the `omitempty` should be removed."
+169,"@@ -224,9 +224,7 @@ func (m *ipipManager) CompleteDeferredWork() error {
+ 		for _, ip := range m.activeHostnameToIP {
+ 			members = append(members, ip)
+ 		}
+-		for _, ip := range m.externalNodeCIDRs {
+-			members = append(members, ip)
+-		}
++		members = append(members, m.externalNodeCIDRs...)
+ 		m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, members)
+ 		m.ipSetInSync = true
+ 	}",Same change just above?,shouldn't this be `m.externalNodeCIDRs[0]`?
+170,"@@ -511,4 +511,14 @@ describe('services_SearchEngine', function() {
+ 		expect((await engine.search('""- [ ]""', { searchType: SearchEngine.SEARCH_TYPE_BASIC })).length).toBe(1);
+ 		expect((await engine.search('""[ ]""', { searchType: SearchEngine.SEARCH_TYPE_BASIC })).length).toBe(2);
+ 	}));
++
++	it('should not mistake cyrillic ""l"" for latin ""n""', asyncTest(async () => {
++		const n1 = await Note.save({ title: 'latin n', body: 'n' });
++		const n2 = await Note.save({ title: 'cyrillic l', body: 'л' });
++
++		await engine.syncTables();
++
++		expect((await engine.search('n')).length).toBe(1);
++		expect((await engine.search('л')).length).toBe(1);
++	}));
+ });","Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning ""latin n"" for both queries, we won't know about it.",Minor nit: I think you can skip this assertion by using `expect(await engine.search('
+171,"@@ -47,9 +47,10 @@ const (
+
+ 	otherDomainID = ""spiffe://otherdomain.test""
+
+-	serverID   = ""spiffe://example.org/spire/server""
+-	agentID    = ""spiffe://example.org/spire/agent/test/id""
+-	workloadID = ""spiffe://example.org/workload""
++	serverID    = ""spiffe://example.org/spire/server""
++	agentID     = ""spiffe://example.org/spire/agent/test/id""
++	agentlessID = ""spiffe://example.org/test/id""
++	workloadID  = ""spiffe://example.org/workload""
+
+ 	// used to cancel stream operations on test failure instead of blocking the
+ 	// full go test timeout period (i.e. 10 minutes)",nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways,what's the difference between `agentlessID` and `agentID`?
+172,"@@ -1,4 +1,4 @@
+-require 'spec_helper'
++require 'rails_helper'
+
+ feature 'Admin manages mentors' do
+   scenario 'creating a new mentor' do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,rubocop doesn't like this   ... ACAB
+173,"@@ -204,11 +204,7 @@ public class ClassTypeResolver extends JavaParserVisitorAdapter {
+             if (className != null) {
+                 populateClassName(node, className);
+             }
+-        } catch (ClassNotFoundException e) {
+-            if (LOG.isLoggable(Level.FINE)) {
+-                LOG.log(Level.FINE, ""Could not find class "" + className + "", due to: "" + e);
+-            }
+-        } catch (NoClassDefFoundError e) {
++        } catch (ClassNotFoundException | NoClassDefFoundError e) {
+             if (LOG.isLoggable(Level.FINE)) {
+                 LOG.log(Level.FINE, ""Could not find class "" + className + "", due to: "" + e);
+             }",We should have a rule to detect identical catch branches,Could you explain why this change?
+174,"@@ -28,10 +28,6 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+
+         public bool PublishFlatContainer { get; set; }
+
+-        public int RetryAttempts { get; set; } = 5;
+-
+-        public int RetryDelayInSeconds { get; set; } = 30;
+-
+         public int MaxClients { get; set; } = 8;
+
+         public bool SkipCreateContainer { get; set; } = false;",remove these from the targets file.,These are removed because they are n
+175,"@@ -11,14 +11,13 @@ import (
+ 	""time""
+
+ 	""github.com/ethersphere/bee/pkg/addressbook""
++	""github.com/ethersphere/bee/pkg/bzz""
+ 	""github.com/ethersphere/bee/pkg/hive/pb""
+ 	""github.com/ethersphere/bee/pkg/logging""
+ 	""github.com/ethersphere/bee/pkg/p2p""
+ 	""github.com/ethersphere/bee/pkg/p2p/protobuf""
+ 	""github.com/ethersphere/bee/pkg/storage""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+-
+-	ma ""github.com/multiformats/go-multiaddr""
+ )
+
+ const (","now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe",Looks like this import is unused.
+176,"@@ -35,11 +35,12 @@ NAMESPACE_PACKAGES = [
+ REQUIRED_PACKAGES = [
+     # Installation related.
+     'anytree==2.4.3',
+-    'google-api-python-client==1.7.7',
+-    'google-auth==1.6.2',
++    'google-api-python-client==1.7.10',
++    'google-auth==1.6.3',
+     'google-auth-httplib2==0.0.3',
+     'Jinja2==2.10.1',
+     'jmespath==0.9.3',
++    'mailjet-rest==1.3.3',
+     'netaddr==0.7.19',
+     'pyyaml==4.2b4',
+     'python-graph-core==1.8.2',","I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?",I think you need to keep `google-api-python-client` for 1.7.7 as well.
+177,"@@ -8,10 +8,7 @@ package javaslang.control;
+ import javaslang.Serializables;
+ import org.junit.Test;
+
+-import java.util.Iterator;
+-import java.util.NoSuchElementException;
+-import java.util.Objects;
+-import java.util.Optional;
++import java.util.*;
+
+ import static org.assertj.core.api.Assertions.assertThat;
+ ",I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard.,Don't use star imports please.
+178,"@@ -29,7 +29,9 @@ module Beaker
+         v_file << ""    v.vm.box = '#{host['box']}'\n""
+         v_file << ""    v.vm.box_url = '#{host['box_url']}'\n"" unless host['box_url'].nil?
+         v_file << ""    v.vm.base_mac = '#{randmac}'\n""
+-        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
++        host['ips'].each do |ip|
++          v_file << ""    v.vm.network :private_network, ip: \""#{ip.to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
++        end
+
+         if host['disk_path']
+           v_file << ""    v.vm.provider :virtualbox do |vb|\n""",Where is host['ips'] coming from?,Use the new Ruby 1.9 hash syntax.
+179,"@@ -3,14 +3,7 @@
+
+ package userns
+
+-import (
+-	""strings""
+-
+-	""github.com/opencontainers/runc/libcontainer/user""
+-)
+-
+-func FuzzUIDMap(data []byte) int {
+-	uidmap, _ := user.ParseIDMap(strings.NewReader(string(data)))
+-	_ = uidMapInUserNS(uidmap)
++func FuzzUIDMap(uidmap []byte) int {
++	_ = uidMapInUserNS(string(uidmap))
+ 	return 1
+ }",oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable,`return 1` would be more idiomatic here.
+180,"@@ -1,6 +1,8 @@
+ describe ""Display status text"" do
+   let(:proposal) { FactoryGirl.create(:proposal, :with_parallel_approvers) }
+   before do
++    proposal.approvers.first.update(first_name: ""Uniquely"", last_name: ""Named"")
++    proposal.approvers.second.update(first_name: ""Onlyof"", last_name: ""Itskind"")
+     login_as(proposal.requester)
+   end
+ ",Is this necessary?,Do not use parentheses for method calls with no arguments.
+181,"@@ -1,8 +1,16 @@
+-import React from 'react';
++import React, {Component} from 'react';
+ import 'element-theme-default';
+ import {i18n} from 'element-react';
+ import locale from 'element-react/src/locale/lang/en';
+
++import storage from './utils/storage';
++import logo from './utils/logo';
++import {makeLogin, isTokenExpire} from './utils/login';
++
++import Header from './components/Header';
++import Footer from './components/Footer';
++import LoginModal from './components/Login';
++
+ i18n.use(locale);
+
+ import Route from './router';",I'd create a different method for each render section.,Please put this in alphabetical order.
+182,"@@ -23,6 +23,8 @@ public class EstimateGasOperationTracer implements OperationTracer {
+
+   private Gas sStoreStipendNeeded = Gas.ZERO;
+
++  private boolean isReverted = false;
++
+   @Override
+   public void traceExecution(
+       final MessageFrame frame, final OperationTracer.ExecuteOperation executeOperation) {",Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?,This could be a local variable.
+183,"@@ -71,7 +71,7 @@ public class TestSparkOrcReader extends AvroDataTest {
+
+     try (CloseableIterable<InternalRow> reader = ORC.read(Files.localInput(testFile))
+         .project(schema)
+-        .createReaderFunc(SparkOrcReader::new)
++        .createReaderFunc(readOrcSchema -> new SparkOrcReader(schema, readOrcSchema))
+         .build()) {
+       final Iterator<InternalRow> actualRows = reader.iterator();
+       final Iterator<InternalRow> expectedRows = expected.iterator();",I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized.,nit: this can be a method reference
+184,"@@ -100,6 +100,10 @@ abstract class BaseFile<F>
+           found = true;
+           fromProjectionPos[i] = j;
+         }
++        if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId()) {
++          found = true;
++          fromProjectionPos[i] = 14;
++        }
+       }
+
+       if (!found) {",These modifications allow BaseFile to translate into a SparkRow with the specID as a column,Is there any chance fields[i] is null? What happens if it is?
+185,"@@ -519,7 +519,7 @@ function resolveReadPreference(parent, options) {
+     throw new Error('No readPreference was provided or inherited.');
+   }
+
+-  return readPreference;
++  return typeof readPreference === 'string' ? new ReadPreference(readPreference) : readPreference;
+ }
+
+ /**",is this something we've been missing this whole time?,Did you mean to leave this change in here?
+186,"@@ -25,6 +25,7 @@ import (
+ const (
+ 	defaultWaitApprovalTimeout  = Duration(6 * time.Hour)
+ 	defaultAnalysisQueryTimeout = Duration(30 * time.Second)
++	allEvents                   = ""*""
+ )
+
+ type GenericDeploymentSpec struct {",nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`.,is this a leftover?
+187,"@@ -111,6 +111,15 @@ def generate_thrift_files(thrift_files_dir, env, silent=True):
+         LOG.error('Failed to generate viewer server files')
+         return ret
+
++    auth_thrift = os.path.join(thrift_files_dir, 'authentication.thrift')
++    auth_thrift = 'authentication.thrift'
++    auth_cmd = ['thrift', '-r', '-I', '.',
++                '--gen', 'py', auth_thrift]
++    ret = run_cmd(auth_cmd, thrift_files_dir, env, silent=silent)
++    if ret:
++        LOG.error('Failed to generate authentication interface files')
++        return ret
++
+
+ # -------------------------------------------------------------------
+ def generate_documentation(doc_root, env, silent=True):",There seems to be some repetition. Does a local function make this code shorter overall?,this should probably be a warning or an error if it fails
+188,"@@ -298,6 +298,7 @@ function diffElementNodes(
+ 	}
+
+ 	if (dom == null) {
++		isHydrating = false;
+ 		if (newVNode.type === null) {
+ 			return document.createTextNode(newProps);
+ 		}",Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?,This feels a bit like a hack. Is there a better way to fix this?
+189,"@@ -22,7 +22,6 @@ import java.util.List;
+
+ @AutoValue
+ public abstract class TestCaseView {
+-
+   public abstract String clientMethodName();
+
+   public abstract InitCodeView initCode();",Revert this blank line,Please remove changes to this file.
+190,"@@ -50,8 +50,8 @@ public class MoveReplicaHDFSTest extends MoveReplicaTest {
+       HdfsTestUtil.teardownClass(dfsCluster);
+     } finally {
+       dfsCluster = null;
+-      System.setProperty(""solr.hdfs.blockcache.blocksperbank"", ""512"");
+-      System.setProperty(""tests.hdfs.numdatanodes"", ""1"");
++      System.clearProperty(""solr.hdfs.blockcache.blocksperbank"");
++      System.clearProperty(""tests.hdfs.numdatanodes"");
+     }
+   }
+ ",This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures.,"I think we can simplify this to `System.setProperty(""solr.hdfs.b"
+191,"@@ -2,6 +2,7 @@ class ProposalsController < ApplicationController
+   include TokenAuth
+
+   skip_before_action :authenticate_user!, only: [:approve]
++  before_action :check_disabled_client
+   # TODO use Policy for all actions
+   before_action ->{authorize proposal}, only: [:show, :cancel, :cancel_form, :history]
+   before_action :needs_token_on_get, only: :approve",I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client,I think this should be moved to `before_action :authenticate_use
+192,"@@ -56,9 +56,10 @@ class DefaultBucketViewTest(BaseWebTest, unittest.TestCase):
+         self.app.get(self.collection_url, headers=self.headers)
+
+     def test_querystring_parameters_are_taken_into_account(self):
+-        self.app.get(self.collection_url + '/records?_since=invalid',
+-                     headers=self.headers,
+-                     status=400)
++        resp = self.app.get(self.collection_url + '/records?_since=invalid',
++                            headers=self.headers,
++                            status=400)
++        self.assertIn('Content-Length', resp.headers)
+
+     def test_option_is_possible_without_authentication_for_default(self):
+         headers = 'authorization,content-type'",I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?,Can you check the content-length of the response too?
+193,"@@ -42,7 +42,7 @@ module Bolt
+         path = File.join(libexec, 'custom_facts.rb')
+         file = { 'name' => 'custom_facts.rb', 'path' => path }
+         metadata = { 'supports_noop' => true, 'input_method' => 'stdin' }
+-        Bolt::Task.new(name: 'custom_facts', files: [file], metadata: metadata)
++        Bolt::Task.new(name: 'apply_helpers::custom_facts', files: [file], metadata: metadata)
+       end
+     end
+ ","We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers.",The name of this task should be `apply_helpers::custo
+194,"@@ -0,0 +1,11 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Shopsys\ShopBundle\Model\Order\Item;
++
++use Shopsys\FrameworkBundle\Model\Order\Item\OrderItemFactory as BaseOrderItemFactory;
++
++class OrderItemFactory extends BaseOrderItemFactory
++{
++}",Why do you think that it is necessary to create this class?,Why do we need this typehint here? We already have a
+195,"@@ -18,8 +18,8 @@ type Hash struct {
+ //
+ // See http://docs.aws.amazon.com/amazonglacier/latest/dev/checksum-calculations.html for more information.
+ func ComputeHashes(r io.ReadSeeker) Hash {
+-	r.Seek(0, 0)       // Read the whole stream
+-	defer r.Seek(0, 0) // Rewind stream at end
++	start, _ := r.Seek(0, 1)  // Read the whole stream
++	defer r.Seek(start, 0) // Rewind stream at end
+
+ 	buf := make([]byte, bufsize)
+ 	hashes := [][]byte{}",replacing the `1` with `io.SeekCurrent` may be good here,Shouldn't we check for errors here?
+196,"@@ -0,0 +1,15 @@
++package main
++
++import (
++	""time""
++
++	""gopkg.in/square/go-jose.v2""
++)
++
++type JWKSSource interface {
++	// FetchJWKS returns the key set and modified time.
++	FetchKeySet() (*jose.JSONWebKeySet, time.Time, bool)
++
++	// Close closes the source.
++	Close() error
++}",nit: perhaps this file would be better named `jwks_source.go` ?,any reason to have this as a public interface?
+197,"@@ -153,6 +153,9 @@ public class Constants {
+   // Overridable plugin load properties
+   public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = ""azkaban.plugin.load.override.props"";
+
++  // File containing param override configs
++  public static final String PARAM_OVERRIDE_FILE = ""param_override.properties"";
++
+   // Azkaban event reporter constants
+   public static class EventReporterConstants {
+ ",It will be helpful to specify the intended priority as well for the properties within this file.,Shall we move it to `EventReporterConstants`?
+198,"@@ -23,6 +23,8 @@ import (
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/osinfo""
+ )
+
++type RunFunc func(*exec.Cmd) ([]byte, error)
++
+ var (
+ 	// AptExists indicates whether apt is installed.
+ 	AptExists bool","Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided.",Let's define this as `func Run(cmd *exec.Cmd)
+199,"@@ -1956,7 +1956,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		""OFF""),
+   DDkwd__(HIVE_DEFAULT_CHARSET,            (char *)SQLCHARSETSTRING_UTF8),
+   DD_____(HIVE_DEFAULT_SCHEMA,                  ""HIVE""),
+   DD_____(HIVE_FILE_CHARSET,                    """"),
+-  DD_____(HIVE_FILE_NAME,     ""/hive/tpcds/customer/customer.dat"" ),
++  DD_____(HIVE_FILE_NAME,     ""/user/trafodion/hive/tpcds/customer/customer.dat"" ),
+   DD_____(HIVE_HDFS_STATS_LOG_FILE,             """"),
+   DDui___(HIVE_INSERT_ERROR_MODE,               ""1""),
+   DDint__(HIVE_LIB_HDFS_PORT_OVERRIDE,          ""-1""),",Do you now why is it a specific table name is used as a default?,I think we can revert this file too?
+200,"@@ -414,8 +414,8 @@ namespace Microsoft.DotNet.Build.Tasks
+                     return Environment.GetEnvironmentVariable(""TMPDIR"");
+                 else if (DirExists(Environment.GetEnvironmentVariable(""TMP"")))
+                     return Environment.GetEnvironmentVariable(""TMP"");
+-                else if (DirExists(""/home/DDITAdministrator/myagent/_work/_temp""))
+-                    return ""/home/DDITAdministrator/myagent/_work/_temp"";
++                else if (DirExists(Path.Combine(Environment.GetEnvironmentVariable(""HOME""), ""myagent/_work/_temp"")))
++                    return Path.Combine(Environment.GetEnvironmentVariable(""HOME""), ""myagent/_work/_temp"");
+                 else
+                 {
+                     Log.LogMessage(""No TEMP dir found."");","If all you're doing is checking for the existence of a directory as your ""temp"" directory, why does it matter what OS you're on?",Is there any chance that these two directories are defined in different locations? I'm wondering if it wouldn't be better to check for `/home/DDITAdministrator/myagent/_work/_temp` instead.
+201,"@@ -60,10 +60,11 @@
+ package server
+
+ import (
+-	""fmt""
++	v2 ""github.com/algorand/go-algorand/daemon/algod/api/server/v2""
++	""github.com/algorand/go-algorand/daemon/algod/api/server/v2/generated""
+ 	""net/http""
+
+-	""github.com/gorilla/mux""
++	""github.com/labstack/echo/v4""
+
+ 	""github.com/algorand/go-algorand/daemon/algod/api/server/common""
+ 	""github.com/algorand/go-algorand/daemon/algod/api/server/lib""",nit- would be cleaner to import it once,can we rename this to something more descriptive?
+202,"@@ -159,6 +159,14 @@ class GenericProxyHandler(BaseHTTPRequestHandler):
+             # allow pre-flight CORS headers by default
+             if 'Access-Control-Allow-Origin' not in response.headers:
+                 self.send_header('Access-Control-Allow-Origin', '*')
++            if 'Access-Control-Allow-Headers' not in response.headers:
++                self.send_header('Access-Control-Allow-Headers', ','.join([
++                    'authorization',
++                    'x-amz-content-sha256',
++                    'x-amz-date',
++                    'x-amz-security-token',
++                    'x-amz-user-agent'
++                ])
+
+             self.end_headers()
+             if len(response.content):",Looks like there is a closing parenthesis `)` missing here.,I think we need to add `x-amz-user-agent` to `self.send_header`
+203,"@@ -1684,8 +1684,8 @@ void PairTlsph::coeff(int narg, char **arg) {
+                 } // end energy release rate failure criterion
+
+                 else {
+-                        sprintf(str, ""unknown *KEYWORD: %s"", arg[ioffset]);
+-                        error->all(FLERR, str);
++                  snprintf(str,128,""unknown *KEYWORD: %s"", arg[ioffset]);
++                  error->all(FLERR, str);
+                 }
+
+         }",this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed.,"`sprintf(str, ""unknown *KEYWORD: %s"", arg[ioffset]);` should work."
+204,"@@ -706,6 +706,7 @@ func TestKBFSOpsGetBaseDirChildrenCacheSuccess(t *testing.T) {
+ 	ops := getOps(config, id)
+ 	n := nodeFromPath(t, ops, p)
+
++	config.mockMdserv.EXPECT().FastForwardBackoff().AnyTimes()
+ 	children, err := config.KBFSOps().GetDirChildren(ctx, n)
+ 	if err != nil {
+ 		t.Errorf(""Got error on getdir: %+v"", err)","You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test.","If you use `AnyTimes()` instead of `FastForwardBackoff()`, you can remove the reference to `config.mockMdserv` in this test."
+205,"@@ -528,8 +528,10 @@ drx_insert_counter_update(void *drcontext, instrlist_t *ilist, instr_t *where,
+         }
+     }
+ #elif defined(AARCHXX)
++#    ifdef ARM_32
+     /* FIXME i#1551: implement 64-bit counter support */
+-    ASSERT(!is_64, ""DRX_COUNTER_64BIT is not implemented"");
++    ASSERT(!is_64, ""DRX_COUNTER_64BIT is not implemented for ARM_32"");
++#    endif /* ARM_32 */
+
+     if (use_drreg) {
+         if (drreg_reserve_register(drcontext, ilist, where, NULL, &reg1) !=","`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32.","If this is intended to be implemented on all platforms, you could use the ARM_32 macro to avoid the ifdef."
+206,"@@ -38,8 +38,11 @@ import javax.annotation.Nullable;
+ /** A field declaration wrapper around a Discovery Schema. */
+ public class DiscoveryField implements FieldModel, TypeModel {
+   private final List<DiscoveryField> properties;
++  // Dereferenced schema for use rendering type names and determining properties, type, and format.
+   private final Schema schema;
+-  private final Schema originalSchema; // Not dereferenced schema.
++
++  // Not dereferenced schema; used in rendering this FieldModel's parameter name.
++  private final Schema originalSchema;
+   private final DiscoApiModel apiModel;
+
+   /* Create a FieldModel object from a non-null Schema object, and internally dereference the input schema. */",s/for use/to use for/,what is the meaning of this field if it is never used?
+207,"@@ -60,7 +60,7 @@ class UserCreatedEventProjector
+                 'language' => $event->getLanguage()->getCode(),
+                 'password' => $event->getPassword()->getValue(),
+                 'is_active' => $event->isActive(),
+-                'avatar_id' => $event->getAvatarId() ? $event->getAvatarId()->getValue() : null,
++                'avatar_filename' => $event->getAvatarFilename() ? $event->getAvatarFilename()->getValue() : null,
+             ],
+             [
+                 'is_active' => \PDO::PARAM_BOOL,",` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `,Please write `null` instead of `null`. The same in other places.
+208,"@@ -34,7 +34,7 @@ import (
+
+ var (
+ 	// ErrPersistenceLimitExceeded is the error indicating QPS limit reached.
+-	ErrPersistenceLimitExceeded = serviceerror.NewResourceExhausted(""Persistence Max QPS Reached."")
++	ErrPersistenceLimitExceeded = serviceerror.NewUnavailable(""Persistence Max QPS Reached."")
+ )
+
+ type (",why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?,I'm not sure if this is a good error message. @deads2k any thoughts?
+209,"@@ -27,13 +27,10 @@ namespace OpenTelemetry.Instrumentation.AspNet
+     public class AspNetInstrumentationOptions
+     {
+         /// <summary>
+-        /// Gets or sets <see cref=""TextMapPropagator""/> for context propagation. Default value: <see cref=""CompositeTextMapPropagator""/> with <see cref=""TraceContextPropagator""/> &amp; <see cref=""BaggagePropagator""/>.
++        /// Gets or sets <see cref=""TextMapPropagator""/> for context propagation.
++        /// By default, <see cref=""Propagators.DefaultTextMapPropagator"" /> will be used.
+         /// </summary>
+-        public TextMapPropagator Propagator { get; set; } = new CompositeTextMapPropagator(new TextMapPropagator[]
+-        {
+-            new TraceContextPropagator(),
+-            new BaggagePropagator(),
+-        });
++        public TextMapPropagator Propagator { get; set; } = Propagators.DefaultTextMapPropagator;
+
+         /// <summary>
+         /// Gets or sets a Filter function to filter instrumentation for requests on a per request basis.","Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable.",Why did we remove the composite text mapPropagator?
+210,"@@ -158,7 +158,6 @@ public class TransactionSimulator {
+         callParams.getFrom() != null ? callParams.getFrom() : DEFAULT_FROM;
+
+     BlockHeader blockHeaderToProcess = header;
+-
+     if (transactionValidationParams.isAllowExceedingBalance()) {
+       updater.getOrCreate(senderAddress).getMutable().setBalance(Wei.of(UInt256.MAX_VALUE));
+       if (header.getBaseFee().isPresent()) {",Unrelated file. Please remove from PR.,remove empty line
+211,"@@ -2663,6 +2663,7 @@ static work_queue_msg_code_t process_http_request( struct work_queue *q, struct
+ 	} else {
+ 	        // Other requests get raw JSON data.
+ 		send_worker_msg(q,w,""Content-type: text/plain\n\n"");
++		send_worker_msg(q,w,""Access-Control-Allow-Origin: *\n\n"");
+ 		process_queue_status(q, w, &path[1], stoptime );
+ 	}
+ ",Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.),"Could you remove the space after `,`?"
+212,"@@ -9,6 +9,9 @@ def request(flow):
+     flow.request.headers.pop('If-Modified-Since', None)
+     flow.request.headers.pop('Cache-Control', None)
+
++    # do not force https redirection
++    flow.request.headers.pop('Upgrade-Insecure-Requests', None)
++
+     # proxy connections to SSL-enabled hosts
+     if flow.request.pretty_host in secure_hosts:
+         flow.request.scheme = 'https'","This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b""pattern""`)?",Should this be `pop` instead of `pop`?
+213,"@@ -85,7 +85,7 @@ const ariaRoles = {
+ 	},
+ 	combobox: {
+ 		type: 'composite',
+-		requiredOwned: ['textbox', 'listbox', 'tree', 'grid', 'dialog'],
++		requiredOwned: ['listbox', 'tree', 'grid', 'dialog', 'textbox'],
+ 		requiredAttrs: ['aria-expanded'],
+ 		// Note: because aria-controls is not well supported we will not
+ 		// make it a required attribute even though it is required in the","This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for ""equal but order doesn't matter"" in chai.",Why is this necessary?
+214,"@@ -16546,6 +16546,18 @@ RelInternalSP::costMethod() const
+ } // RelInternalSP::costMethod()
+ //<pb>
+
++CostMethod *
++HbaseDelete::costMethod() const
++{
++  if (CmpCommon::getDefault(HBASE_DELETE_COSTING) == DF_OFF)
++    return RelExpr::costMethod();  // returns cost 1 cost object
++
++  static THREAD_P CostMethodHbaseDelete *m = NULL;
++  if (m == NULL)
++    m = new (GetCliGlobals()->exCollHeap()) CostMethodHbaseDelete();
++  return m;
++} // HbaseDelete::costMethod()
++
+ PhysicalProperty*
+ HbaseDelete::synthPhysicalProperty(const Context* myContext,
+                                    const Lng32     planNumber,","maybe say ""returns the default cost method that returns an object of cost 1"".",I don't think you need to create a new
+215,"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+
++	rules = append(rules, Rule{
++		Match: Match().ProtocolNum(ProtoUDP).
++			DestPorts(uint16(r.Config.VXLANPort)).
++			VXLANVNI(uint32(r.Config.VXLANVNI)),
++		Action:  DropAction{},
++		Comment: ""Drop VXLAN encapped packets originating in pods"",
++	})
++	rules = append(rules, Rule{
++		Match:   Match().ProtocolNum(ProtoIPIP),
++		Action:  DropAction{},
++		Comment: ""Drop IPinIP encapped packets originating in pods"",
++	})
++
+ 	if len(policyNames) > 0 {
+ 		// Clear the ""pass"" mark.  If a policy sets that mark, we'll skip the rest of the policies and
+ 		// continue processing the profiles, if there are any.","I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?",Since most of these rules are going to
+216,"@@ -125,7 +125,9 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
+                     try {
+                         // Not a 2xx status
+                         if (!response.isSuccess()) {
+-                            callbackContext.error(response.asString());
++                            JSONObject errorObj = new JSONObject();
++                            errorObj.putOpt(""response"", response.fullResponseAsJSONObject());
++                            callbackContext.error(errorObj.toString());
+                         }
+                         // Binary response
+                         else if (returnBinary) {","Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine.",You need to do a JSONObject copy of the response.
+217,"@@ -113,7 +113,7 @@ describe('PasswordEditor', () => {
+     const editorHolder = $('.handsontableInputHolder');
+     const editor = editorHolder.find('.handsontableInput');
+
+-    expect(parseInt(editorHolder.css('z-index'), 10)).toBeGreaterThan(0);
++    expect(editorHolder.is(':visible')).toBe(true);
+
+     editor.val('Edgar');
+ ",Are you sure? We've changed it during an introduction of the IME support.,Can you explain why this change is needed?
+218,"@@ -46,7 +46,7 @@ class QueryBuilder
+             $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
+         }
+
+-        if (!empty($dqlFilter)) {
++        if (null !== $dqlFilter) {
+             $queryBuilder->andWhere($dqlFilter);
+         }
+ ","I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?",Why this change? Isn't that a BC break?
+219,"@@ -170,14 +170,12 @@ func (p *Agent) Start(ctx context.Context) error {
+ 			p2pMsgLatency.WithLabelValues(""broadcast"", strconv.Itoa(int(broadcast.MsgType)), status).Observe(float64(latency))
+ 		}()
+ 		if err = proto.Unmarshal(data, &broadcast); err != nil {
+-			err = errors.Wrap(err, ""error when marshaling broadcast message"")
+-			return
++			return errors.Wrap(err, ""error when marshaling broadcast message"")
+ 		}
+ 		// Skip the broadcast message if it's from the node itself
+ 		rawmsg, ok := p2p.GetBroadcastMsg(ctx)
+ 		if !ok {
+-			err = errors.New(""error when asserting broadcast msg context"")
+-			return
++			return errors.New(""error when asserting broadcast msg context"")
+ 		}
+ 		peerID = rawmsg.GetFrom().Pretty()
+ 		if p.host.HostIdentity() == peerID {","this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem",do we want to log the error here?
+220,"@@ -202,7 +202,7 @@ ostree_gpg_verify_result_get_all (OstreeGpgVerifyResult *result,
+  * ostree_gpg_verify_result_describe:
+  * @result: an #OstreeGpgVerifyResult
+  * @signature_index: which signature to describe
+- * @output_buffer: a #GString to hold the description
++ * @output_buffer: (out): a #GString to hold the description
+  * @line_prefix: (allow-none): optional line prefix string
+  * @flags: flags to adjust the description format
+  *","I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for.",This change seems unrelated to the rest of the PR
+221,"@@ -7,9 +7,9 @@ from ..registry import LOSSES
+
+ def _expand_binary_labels(labels, label_weights, label_channels):
+     bin_labels = labels.new_full((labels.size(0), label_channels), 0)
+-    inds = torch.nonzero(labels >= 1).squeeze()
++    inds = torch.nonzero((labels >= 0) & (labels < label_channels)).squeeze()
+     if inds.numel() > 0:
+-        bin_labels[inds, labels[inds] - 1] = 1
++        bin_labels[inds, labels[inds]] = 1
+     bin_label_weights = label_weights.view(-1, 1).expand(
+         label_weights.size(0), label_channels)
+     return bin_labels, bin_label_weights","If the label is not binary, should we rename this function?","This is a bug fix, right?"
+222,"@@ -421,10 +421,12 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister):
+         :param file_list:
+         :return: etree
+         """"""
++        cur_path = r""${__BeanShell(import org.apache.jmeter.services.FileServer; FileServer.getFileServer()"" \
++                   r"".getBaseDir();)}${__BeanShell(File.separator,)}""
+         for file_path in file_list:
+             file_path_elements = jmx.xpath('//stringProp[text()=""%s""]' % file_path)
+             for file_path_element in file_path_elements:
+-                file_path_element.text = os.path.basename(file_path)
++                file_path_element.text = cur_path + os.path.basename(file_path)
+
+     def __get_resource_files_from_jmx(self, jmx):
+         """"""",This is very-very bad idea because of its performance impact,`__BeanShell__` won't work for Windows. You need
+223,"@@ -6,6 +6,7 @@ import (
+ 	""database/sql""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/sonm-io/core/proto""
+ 	""math/big""
+ 	""net""
+ 	""sync""",WHY U NOT SORT IMPORTS?,This import should be moved down to the other std
+224,"@@ -0,0 +1,11 @@
++module SignInRequestHelpers
++  def sign_in_as(user)
++    post(
++      ""/session"",
++      session: {
++        email: user.email,
++        password: user.password,
++      },
++    )
++  end
++end",Put a comma after the last item of a multiline hash.,should this be `user.id`?
+225,"@@ -12,7 +12,7 @@ __version__ = param.Version(release=(1,7,0), fpath=__file__,
+                             commit=""$Format:%h$"", reponame='holoviews')
+
+ from .core import archive                                # noqa (API import)
+-from .core.dimension import OrderedDict, Dimension       # noqa (API import)
++from .core.dimension import OrderedDict, Dimension, Dimensioned       # noqa (API import)
+ from .core.boundingregion import BoundingBox             # noqa (API import)
+ from .core.options import (Options, Store, Cycle,        # noqa (API import)
+                            Palette, StoreOptions)",How come we need ``Dimensioned`` in the top-level namespace?,`Dimensioned` is unused n
+226,"@@ -75,9 +75,9 @@ import net.runelite.client.util.Text;
+ import net.runelite.client.util.WildcardMatcher;
+
+ @PluginDescriptor(
+-	name = ""NPC Indicators"",
+-	description = ""Highlight NPCs on-screen and/or on the minimap"",
+-	tags = {""highlight"", ""minimap"", ""npcs"", ""overlay"", ""respawn"", ""tags""}
++		name = ""NPC Indicators"",
++		description = ""Highlight NPCs on-screen and/or on the minimap"",
++		tags = {""highlight"", ""minimap"", ""npcs"", ""overlay"", ""respawn"", ""tags""}
+ )
+ @Slf4j
+ @Singleton",excess whitespace through plugin.,It would be better to kee
+227,"@@ -138,7 +138,7 @@ void EdgeBasedGraphFactory::InsertEdgeBasedNode(const NodeID node_u, const NodeI
+     NodeID current_edge_source_coordinate_id = node_u;
+
+     // traverse arrays from start and end respectively
+-    for (const auto i : util::irange(0UL, geometry_size))
++    for (const auto i : util::irange(std::size_t{ 0 }, geometry_size))
+     {
+         BOOST_ASSERT(current_edge_source_coordinate_id ==
+                      m_compressed_edge_container.GetBucketReference(",What is the problem here? I feel we used this in a lot of places.,Can `i` be moved out of t
+228,"@@ -109,8 +109,7 @@ class RPN(BaseDetector):
+             for proposals, meta in zip(proposal_list, img_metas):
+                 proposals[:, :4] /= proposals.new_tensor(meta['scale_factor'])
+
+-        # TODO: remove this restriction
+-        return proposal_list[0].cpu().numpy()
++        return [proposal.cpu().numpy() for proposal in proposal_list]
+
+     def aug_test(self, imgs, img_metas, rescale=False):
+         """"""Test function with test time augmentation.",Update the docstring.,Do we need to return proposals as a list?
+229,"@@ -7,10 +7,11 @@
+ package api
+
+ import (
+-	""errors""
+ 	""testing""
+ 	""time""
+
++	""github.com/pkg/errors""
++
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/stretchr/testify/require""
+ ","delete the empty line ""github.com/pkg/errors"" should be grouped with other third party packages same for the rest",did you mean to add this import?
+230,"@@ -155,7 +155,7 @@ public class RemoteWebDriver implements WebDriver, JavascriptExecutor,
+   }
+
+   private void init(Capabilities capabilities) {
+-    capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;
++    this.capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;
+
+     logger.addHandler(LoggingHandler.getInstance());
+ ",Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field).,The build fails because `capabilities` is
+231,"@@ -110,8 +110,6 @@ module RSpec::Core
+       end
+     end
+
+-    alias_method :abort, :finish
+-
+     def stop
+       @duration = (RSpec::Core::Time.now - @start).to_f if @start
+       notify :stop","Is this a breaking change, or is the API private?",do we want to keep this around as well?
+232,"@@ -0,0 +1,4 @@
++import pandas as pd
++
++test_data = pd.read_json(""./dumps/courseData.json"");
++test_data = {k: val.groupby('pk')['fields'].apply(list).apply(lambda x: x[0]).to_dict() for k, val in test_data.groupby(""model"")};",I don't think we need this dependency in this project right now,"I think you can just do `pd.read_json(""./dumps/courseData.json"")` directly"
+233,"@@ -30,8 +30,9 @@ const (
+ 	// FanoutName is the name used for the fanout container.
+ 	FanoutName = ""fanout""
+ 	// RetryName is the name used for the retry container.
+-	RetryName          = ""retry""
+-	BrokerCellLabelKey = ""brokerCell""
++	RetryName             = ""retry""
++	BrokerCellLabelKey    = ""brokerCell""
++	BrokerSystemNamespace = ""cloud-run-events""
+ )
+
+ var (",I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant.,"BrokerSystemNamespace is set to ""cloud-run-events"" which is the namespace "
+234,"@@ -155,14 +155,15 @@ module Bolt
+                          ""`task.py`) and the extension is case sensitive. When a target's name is `localhost`, ""\
+                          ""Ruby tasks run with the Bolt Ruby interpreter by default."",
+             additionalProperties: {
+-              type: String,
++              type: [String, Array],
+               _plugin: false
+             },
+             propertyNames: {
+               pattern: ""^.?[a-zA-Z0-9]+$""
+             },
+             _plugin: true,
+-            _example: { ""rb"" => ""/usr/bin/ruby"" }
++            _example: { ""rb"" => [""/usr/bin/ruby"", ""-r"", ""puppet""],
++                        "".py"" => ""/usr/bin/python3"" }
+           },
+           ""job-poll-interval"" => {
+             type: Integer,",The `_example` field should be updated to include an interpreter with an array value.,@jhipster/developers this looks like an odd change to me. Why is this need
+235,"@@ -532,12 +532,14 @@ var supportedKeyTypes = map[string]acme.KeyType{
+
+ // Map of supported protocols.
+ // HTTP/2 only supports TLS 1.2 and higher.
+-var supportedProtocols = map[string]uint16{
++var SupportedProtocols = map[string]uint16{
+ 	""tls1.0"": tls.VersionTLS10,
+ 	""tls1.1"": tls.VersionTLS11,
+ 	""tls1.2"": tls.VersionTLS12,
+ }
+
++// NOTE: if updating the above map, also update sslProtocolToStringMap in caddyhttp/fastcgi/fastcgi.go
++
+ // Map of supported ciphers, used only for parsing config.
+ //
+ // Note that, at time of writing, HTTP/2 blacklists 276 cipher suites,",Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?,nit: not sure if it's necessary to update here or in `upgrade-config.go`
+236,"@@ -59,13 +59,12 @@ func (container *CronContainer) StopStatsCron() {
+ }
+
+ // newCronContainer creates a CronContainer object.
+-func newCronContainer(dockerID *string, name *string, dockerGraphPath string) *CronContainer {
++func newCronContainer(dockerID *string, dockerGraphPath string) *CronContainer {
+ 	statePath := filepath.Join(dockerGraphPath, DockerExecDriverPath, *dockerID)
+
+ 	container := &CronContainer{
+ 		containerMetadata: &ContainerMetadata{
+ 			DockerID: dockerID,
+-			Name:     name,
+ 		},
+ 		statePath: statePath,
+ 	}","I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer.",Is `name` still being used?
+237,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,This import seems unused an
+238,"@@ -19,7 +19,10 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
++import org.openqa.selenium.SessionNotCreatedException;
+ import org.openqa.selenium.grid.distributor.Distributor;
++import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.internal.Require;
+
+ import java.net.URI;",You can safely revert changes to this file.,Do we really need this impo
+239,"@@ -127,7 +127,6 @@ class AnchorHead(nn.Module):
+
+     def loss_single(self, cls_score, bbox_pred, labels, label_weights,
+                     bbox_targets, bbox_weights, num_total_samples, cfg):
+-        # classification loss
+         labels = labels.reshape(-1)
+         label_weights = label_weights.reshape(-1)
+         cls_score = cls_score.permute(0, 2, 3, 1).reshape(",This deletion is unnecessary.,Why are you removing this?
+240,"@@ -302,7 +302,10 @@ class Notification extends Component {
+ 								mdc-layout-grid__cell
+ 								mdc-layout-grid__cell--span-1
+ 							"">
+-								<img className=""googlesitekit-publisher-win__small-image"" alt="""" src={ smallImage } />
++								{
++									typeof smallImage === 'string'
++										? <img className=""googlesitekit-publisher-win__small-image"" alt="""" src={ smallImage } /> : smallImage
++								}
+ 							</div>
+ 						}
+ ","I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear.","Can we move this check to the very beginning of the function, so it's easier to read?"
+241,"@@ -21,10 +21,7 @@ import java.io.InputStream;
+ import java.io.StringWriter;
+ import java.lang.invoke.MethodHandles;
+ import java.nio.charset.StandardCharsets;
+-import java.util.Collections;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
+ import java.util.concurrent.TimeUnit;
+
+ import org.apache.solr.cloud.ZkController;","I've had this happen recently with IntelliJ, was this intentional?","Please do not wildcard imports. To be honest, I don't think we can do it in this PR."
+242,"@@ -22,9 +22,10 @@
+ #include <string.h>
+ #include <string>
+ #include <vector>
+-#include <map>
++#include <unordered_map>
+ #include ""vulkan/vulkan.h""
+ #include ""vk_format_utils.h""
++#include ""hash_util.h""
+
+ struct VULKAN_FORMAT_INFO {
+     size_t size;",Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements.,Is this change needed?
+243,"@@ -33,6 +33,7 @@ import (
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/ip""
+ 	""github.com/mysteriumnetwork/node/core/location""
++	location_factory ""github.com/mysteriumnetwork/node/core/location/factory""
+ 	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/mysteriumnetwork/node/core/port""
+ 	""github.com/mysteriumnetwork/node/core/service""",I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?,could you rename the package to `location_factory`?
+244,"@@ -47,6 +47,14 @@ void Engine::SetCallBack(std::function<void(const void *, std::string,
+ {
+ }
+
++static void engineThrowUp(const std::string &engineType,
++                          const std::string &func)
++{
++    throw std::invalid_argument(
++        ""ERROR: Engine bass class "" + func + ""() called. "" + engineType +
++        "" child class is not implementing this function\n"");
++}
++
+ // should these functions throw an exception?
+ void Engine::Write(Variable<char> & /*variable*/, const char * /*values*/) {}
+ void Engine::Write(Variable<unsigned char> & /*variable*/,",Use `UpperCamelCase` for function names,"This error message is confusing, how about something like ""ERROR: Engine bass class X does not implements this function\n""?"
+245,"@@ -232,9 +232,12 @@ SchemaDate.prototype.cast = function(value) {
+
+   if (value instanceof Number || typeof value === 'number') {
+     date = new Date(value);
++  } else if (typeof value === 'string' && !isNaN(Number(value)) && (Number(value) >= 275761 || Number(value) < 0)) {
++    // string representation of milliseconds take this path
++    date = new Date(Number(value));
+   } else if (typeof value.valueOf === 'function') {
+-    // support for moment.js. This is also the path strings will take because strings
+-    // have a `valueOf()`
++    // support for moment.js. This is also the path string representation of years
++    // will take because strings have a `valueOf()`
+     date = new Date(value.valueOf());
+   } else {
+     // fallback","I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior.",why do we need this check? `Number(value) >= 275761` will be false if it's a number
+246,"@@ -138,8 +138,7 @@ public abstract class BaseHttpClusterStateProvider implements ClusterStateProvid
+     Set<String> liveNodes = new HashSet((List<String>)(cluster.get(""live_nodes"")));
+     this.liveNodes = liveNodes;
+     liveNodesTimestamp = System.nanoTime();
+-    //TODO SOLR-11877 we don't know the znode path; CLUSTER_STATE is probably wrong leading to bad stateFormat
+-    ClusterState cs = ClusterState.load(znodeVersion, collectionsMap, liveNodes, ZkStateReader.CLUSTER_STATE);
++    ClusterState cs = ClusterState.createFromData(znodeVersion, collectionsMap, liveNodes);
+     if (clusterProperties != null) {
+       Map<String, Object> properties = (Map<String, Object>) cluster.get(""properties"");
+       if (properties != null) {",Remember to close SOLR-11877 after this,"I believe this TODO is about the ZK-state reader, not the ZkStateReader."
+247,"@@ -1124,7 +1124,7 @@ void Identifier::_exportToJSON(JSONFormatter *formatter) const {
+ //! @cond Doxygen_Suppress
+ static bool isIgnoredChar(char ch) {
+     return ch == ' ' || ch == '_' || ch == '-' || ch == '/' || ch == '(' ||
+-           ch == ')' || ch == '.' || ch == '&' || ch == ',';
++           ch == ')' || ch == '.' || ch == '&';
+ }
+ //! @endcond
+ ",this change should be reverted,The `ch == ' '` should be removed.
+248,"@@ -186,9 +186,15 @@ type mockedIdentityRegistry struct {
+ 	anyIdentityRegistered bool
+ }
+
++// IsRegistered mock
+ func (mir *mockedIdentityRegistry) IsRegistered(address common.Address) (bool, error) {
+ 	return mir.anyIdentityRegistered, nil
+ }
+
++// WaitForRegistrationEvent mock
++func (mir *mockedIdentityRegistry) WaitForRegistrationEvent(providerAddress common.Address, registeredEvent chan int, stopLoop chan int) {
++
++}
++
+ //check that we implemented mocked registry correctly
+ var _ registry.IdentityRegistry = &mockedIdentityRegistry{}","This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented",Nit: `// WaitForRegistrationEvent mock` -> `// WaitForRegistrationEvent integration`
+249,"@@ -45,7 +45,7 @@ const options = {
+         query: ['src/**/*.png', 'src/**/*.jpg', 'src/**/*.gif', 'src/**/*.svg']
+     },
+     copy: {
+-        query: ['src/**/*.json', 'src/**/*.ico']
++        query: ['src/**/*.json', 'src/**/*.ico', 'src/**/*.wav']
+     },
+     injectBundle: {
+         query: 'src/index.html'","`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`...",Shouldn't this be `src/**/*.jpg`?
+250,"@@ -1602,6 +1602,17 @@ luaA_client_swap(lua_State *L)
+         *ref_swap = c;
+
+         luaA_class_emit_signal(L, &client_class, ""list"", 0);
++
++        luaA_object_push(L, swap);
++        lua_pushboolean(L, true);
++        luaA_object_emit_signal(L, -4, ""swapped"", 2);
++        lua_pop(L, 2);
++
++        luaA_object_push(L, swap);
++        luaA_object_push(L, c);
++        lua_pushboolean(L, false);
++        luaA_object_emit_signal(L, -3, ""swapped"", 2);
++        lua_pop(L, 3);
+     }
+
+     return 0;",Wouldn't a single signal call be enough? (without the boolean even),"`lua_pushboolean(L, false);` or `lua_pushboolean(L, 3);`"
+251,"@@ -17,6 +17,11 @@
+       <br/>
+       <%= note_event(@note.status, @note.closed_at, @note_comments.last.author) %>
+     <% end %>
++    <% if current_user && current_user != @note.author %>
++      <%= link_to new_report_url(reportable_id: @note.id, reportable_type: @note.class.name), :title => t('browse.note.report') do %>
++          &nbsp;&#9872;
++      <% end %>
++    <% end %>
+   </div>
+
+   <% if @note_comments.find { |comment| comment.author.nil? } -%>","I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?",can we use `!@note.deleted` here?
+252,"@@ -218,6 +218,9 @@ class Document < AbstractBlock
+   # Public: Get the Reader associated with this document
+   attr_reader :reader
+
++  # Public: Get/Set the PathResolver instance used to resolve paths in this Document.
++  attr_reader :path_resolver
++
+   # Public: Get the Converter associated with this document
+   attr_reader :converter
+ ",Should we expose this attribute in the Asciidoctor.js API ?,Style/SymbolArray: Use %i or %I for an array of symbols.
+253,"@@ -147,7 +147,7 @@ public interface Multimap<K, V> extends Traversable<Tuple2<K, V>>, Function1<K,
+
+     @Override
+     default boolean contains(Tuple2<K, V> element) {
+-        return get(element._1).map(v -> Objects.equals(v, element._2)).getOrElse(false);
++        return get(element._1).map(v -> v.contains(element._2)).getOrElse(false);
+     }
+
+     /**",I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right,The problem with changing this is that it changes the be
+254,"@@ -57,6 +57,7 @@ public class TiConfiguration implements Serializable {
+   private static final int DEF_KV_CLIENT_CONCURRENCY = 10;
+   private static final List<TiStoreType> DEF_ISOLATION_READ_ENGINES =
+       ImmutableList.of(TiStoreType.TiKV, TiStoreType.TiFlash);
++  private static final int DEF_PREWRITE_CONCURRENCY = 20;
+
+   private int timeout = DEF_TIMEOUT;
+   private TimeUnit timeoutUnit = DEF_TIMEOUT_UNIT;",delete this line,Please make it configurable.
+255,"@@ -43,6 +43,7 @@ module Test
+
+   def self.setup_models
+     conn = ClientRequest.connection
++    return if conn.table_exists? ""test_client_requests""
+     conn.create_table(:test_client_requests, force: true) do |t|
+       t.decimal  :amount
+       t.string   :project_title",Presumably we no longer need `force: true` here.,Prefer single-quoted strings when you don't need string
+256,"@@ -339,6 +339,12 @@ hipError_t hipHostAlloc(void** ptr, size_t sizeBytes, unsigned int flags) {
+ // width in bytes
+ hipError_t ihipMallocPitch(void** ptr, size_t* pitch, size_t width, size_t height, size_t depth) {
+     hipError_t hip_status = hipSuccess;
++	if(ptr==NULL || ptr==0)
++	{
++	hip_status=hipErrorInvalidValue;
++	return hip_status;
++	}
++
+     // hardcoded 128 bytes
+     *pitch = ((((int)width - 1) / 128) + 1) * 128;
+     const size_t sizeBytes = (*pitch) * height;",HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient.,"`hipErrorInvalidValue` is initialized with zero in this case, so no need to initialize it here"
+257,"@@ -0,0 +1,10 @@
++<%= t(""mailer.welcome_mailer.welcome_notification.header"") %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para1"") %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para2"", help_url: help_url('') ) %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para3"", feedback_url: feedback_url ) %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.signature"") %>
++",these urls are still in `a` tags so we should probably include these links separately for a non-HTML version,Doesn't look like there is a corresponding translation for this `welcome_notification.header`
+258,"@@ -507,8 +507,18 @@ func (s *Server) configureAccounts() error {
+ 	if opts.SystemAccount != _EMPTY_ {
+ 		// Lock may be acquired in lookupAccount, so release to call lookupAccount.
+ 		s.mu.Unlock()
+-		_, err := s.lookupAccount(opts.SystemAccount)
++		acc, err := s.lookupAccount(opts.SystemAccount)
+ 		s.mu.Lock()
++		if err == nil && s.sys != nil && acc != s.sys.account {
++			// sys.account.clients (including internal client)/respmap/etc... are transferred separately
++			s.sys.account = acc
++			s.mu.Unlock()
++			// acquires server lock separately
++			s.addSystemAccountExports(acc)
++			// can't hold the lock as go routine reading it may be waiting for lock as well
++			s.sys.resetCh <- struct{}{}
++			s.mu.Lock()
++		}
+ 		if err != nil {
+ 			return fmt.Errorf(""error resolving system account: %v"", err)
+ 		}","That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval.","I think we need a new lock here. Otherwise, the resetCh could hold the lock and then release i"
+259,"@@ -47,6 +47,7 @@ public interface CapabilityType {
+   String ELEMENT_SCROLL_BEHAVIOR = ""elementScrollBehavior"";
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
++  String ENABLE_DOWNLOADING = ""chromium:enableDownloading"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ",The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?,What about `chromium:downloadOnStartup` or `chromium:downloadOnStartup`?
+260,"@@ -28,10 +28,9 @@ public interface ValidatorManager {
+   Map<String, ValidationReport> validate(Project project, File projectDir);
+
+   /**
+-   * The ValidatorManager should have a default validator which checks for the most essential
+-   * components of a project. The ValidatorManager should always load the default validator. This
+-   * method returns the default validator of this ValidatorManager.
++   * ValidatorManager will not have any default validator.
+    */
++  @Deprecated
+   ProjectValidator getDefaultValidator();
+
+   /**",Found one internal team is using this method. Will coordinate with them about the migration solution.,"We don't need this method any more, since the ProjectValidator already has the ValidatorManager."
+261,"@@ -230,6 +230,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+
++        /// <summary>
++        /// Configuration key for the application's server http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpServerErrorCodes""/>
++        public const string HttpServerErrorCodes = ""DD_HTTP_SERVER_ERROR_STATUSES"";
++
++        /// <summary>
++        /// Configuration key for the application's client http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpClientErrorCodes""/>
++        public const string HttpClientErrorCodes = ""DD_HTTP_CLIENT_ERROR_STATUSES"";
++
+         /// <summary>
+         /// String format patterns used to match integration-specific configuration keys.
+         /// </summary>",The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`,"Should this be ""DD_HTTP_CLIENT_ERROR_STATUSES""?"
+262,"@@ -35,6 +35,12 @@ MAXIMUM_LOOP_COUNT = 600
+ DEFAULT_BUCKET_FMT_V1 = 'gs://{}-data-{}'
+ DEFAULT_BUCKET_FMT_V2 = 'gs://{}-{}-data-{}'
+
++FORSETI_V1_RULE_FILES = [
++    'bigquery_rules.yaml', 'blacklist_rules.yaml', 'bucket_rules.yaml',
++    'cloudsql_rules.yaml', 'firewall_rules.yaml', 'forwarding_rules.yaml',
++    'group_rules.yaml', 'iam_rules.yaml', 'iap_rules.yaml', 'ke_rules.yaml',
++    'instance_network_interface_rules.yaml']
++
+ GCLOUD_MIN_VERSION = (180, 0, 0)
+ GCLOUD_VERSION_REGEX = r'Google Cloud SDK (.*)'
+ GCLOUD_ALPHA_REGEX = r'alpha.*'","Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove.","Just a suggestion, but I think we are going to have to rename `FORSETI_V1_RULE_FILES` to `FORSET"
+263,"@@ -170,10 +170,14 @@ public class ConfigSetsHandler extends RequestHandlerBase implements PermissionN
+
+     boolean overwritesExisting = zkClient.exists(configPathInZk, true);
+
+-    if (overwritesExisting && !req.getParams().getBool(ConfigSetParams.OVERWRITE, false)) {
+-      throw new SolrException(ErrorCode.BAD_REQUEST,
+-          ""The configuration "" + configSetName + "" already exists in zookeeper"");
+-    }
++    // Get upload parameters
++    String singleFilePath = req.getParams().get(ConfigSetParams.FILE_PATH, """");
++    boolean allowOverwrite = req.getParams().getBool(ConfigSetParams.OVERWRITE, false);
++    // Cleanup is not allowed while using singleFilePath upload
++    boolean cleanup = singleFilePath.isEmpty() && req.getParams().getBool(ConfigSetParams.CLEANUP, false);
++
++    // Create a node for the configuration in zookeeper
++    createBaseZnode(zkClient, overwritesExisting, isTrusted(req, coreContainer.getAuthenticationPlugin()), cleanup, configPathInZk);
+
+     Iterator<ContentStream> contentStreamsIterator = req.getContentStreams().iterator();
+ ","should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`","Shouldn't this be `req.getParams().getBoolean(ConfigSetParams.OVERWRITE, false)`?"
+264,"@@ -191,7 +191,7 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
+ 	if len(archive.File) == 0 {
+ 		return nil, errors.New(""archive is empty"")
+ 	} else if fi := archive.File[0].FileInfo(); !fi.IsDir() {
+-		return nil, errors.New(""archive root is not a directory"")
++		return nil, fmt.Errorf(""archive root directory missing: expected a 'root' directory but got %v"", archive.File[0].Name)
+ 	}
+ 	root := archive.File[0].Name
+ 	pref, err := unitPrefix(root, archive.File)","There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip.",error strings should not be capitalized or end with punctuation or a newline
+265,"@@ -1,6 +1,9 @@
+ <% unless ENV['DISABLE_SANDBOX_WARNING'] == 'true' %>
+   <%= render partial: 'shared/sandbox_warning' %>
+ <% end %>
++<% if !current_page?(me_path) && current_user && current_user.requires_profile_attention? %>
++  <%= render partial: ""shared/user_profile_warning"" %>
++<% end %>
+ <header>
+   <div class='container'>
+     <div id='header-identity'>",perhaps we should encapsulate this logic in a helper method w a test?,You can use `!me_path?` here
+266,"@@ -0,0 +1,7 @@
++[ 'options_hash', 'defaults', 'command_line_parser', 'pe_version_scraper', 'parser' ].each do |file|
++  begin
++    require ""beaker/options/#{file}""
++  rescue LoadError
++    require File.expand_path(File.join(File.dirname(__FILE__), 'options', file))
++  end
++end",Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below.,Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body en
+267,"@@ -53,7 +53,8 @@ enum Timestamps implements Transform<Long, Integer> {
+     OffsetDateTime timestamp = Instant
+         .ofEpochSecond(timestampMicros / 1_000_000)
+         .atOffset(ZoneOffset.UTC);
+-    return (int) granularity.between(EPOCH, timestamp);
++    Integer year = Long.valueOf(granularity.between(EPOCH, timestamp)).intValue();
++    return year;
+   }
+
+   @Override","This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?","`return Long.valueOf(granularity.between(EPOCH, timestamp));`"
+268,"@@ -351,8 +351,6 @@ func (mtask *managedTask) waitEvent(stopWaiting <-chan struct{}) bool {
+ 		mtask.handleDesiredStatusChange(acsTransition.desiredStatus, acsTransition.seqnum)
+ 		return false
+ 	case dockerChange := <-mtask.dockerMessages:
+-		seelog.Infof(""Managed task [%s]: got container [%s (Runtime ID: %s)] event: [%s]"",
+-			mtask.Arn, dockerChange.container.Name, dockerChange.container.GetRuntimeID(), dockerChange.event.Status.String())
+ 		mtask.handleContainerChange(dockerChange)
+ 		return false
+ 	case resChange := <-mtask.resourceStateChangeEvent:",this is redundant because it gets logged immediately on entering the handleContainerChange function,"I think this should still be here, right?"
+269,"@@ -126,7 +126,7 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ 	var approvers []string
+
+ 	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+-		if v.Event == ""DEPLOYMENT_WAIT_APPROVAL"" {
++		if e := ""EVENT_"" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {
+ 			approvers = v.Slack
+ 		}
+ 	}",`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable.,Why we need the `.String()`?
+270,"@@ -42,4 +42,8 @@ public class CliqueMiningTracker {
+   public boolean blockCreatedLocally(final BlockHeader header) {
+     return CliqueHelpers.getProposerOfBlock(header).equals(localAddress);
+   }
++
++  public ProtocolContext getProtocolContext() {
++    return protocolContext;
++  }
+ }",this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine.,why do we need this getter?
+271,"@@ -265,13 +265,11 @@ public class FirefoxDriver extends RemoteWebDriver
+
+   @Override
+   public String installExtension(Path path) {
+-    Require.nonNull(""Path"", path);
+     return extensions.installExtension(path);
+   }
+
+   @Override
+   public void uninstallExtension(String extensionId) {
+-    Require.nonNull(""Extension ID"", extensionId);
+     extensions.uninstallExtension(extensionId);
+   }
+ ","It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user.",Why remove the requireNonNull?
+272,"@@ -60,8 +60,9 @@ RSpec.configure do |config|
+   # Add modules for helpers
+   config.include ControllerSpecHelper, type: :controller
+   config.include RequestSpecHelper, type: :request
+-  [:feature, :request].each do |type|
++  [:feature, :request, :model].each do |type|
+     config.include IntegrationSpecHelper, type: type
++    config.include EnvironmentSpecHelper, type: type
+   end
+   config.include FeatureSpecHelper, type: :feature
+ ","We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?",why do we need to add `model` here?
+273,"@@ -25,6 +25,9 @@ func TestWriteDrupalConfig(t *testing.T) {
+ 	err = WriteDrupalConfig(drupalConfig, file.Name())
+ 	assert.NoError(t, err)
+
++	os.Chmod(dir, 0755)
++	os.Chmod(file.Name(), 0666)
++
+ 	err = os.RemoveAll(dir)
+ 	assert.NoError(t, err)
+ }",Please check the return on these.,Why was this added?
+274,"@@ -279,10 +279,14 @@ class Storage {
+       if (uplink == null) {
+         uplink = new Proxy({
+           url: file.url,
++          cache: true,
+           _autogenerated: true,
+         }, self.config);
+       }
+-      let savestream = self.local.add_tarball(name, filename);
++      let savestream = null;
++      if (uplink.config.cache) {
++        savestream = self.local.add_tarball(name, filename);
++      }
+       let on_open = function() {
+         // prevent it from being called twice
+         on_open = function() {};",Do we need `==` for true?,Why do we need to set `savestream`
+275,"@@ -17,7 +17,7 @@ class BaseEMAHook(Hook):
+         momentum (float): The momentum used for updating ema parameter.
+             Ema's parameter are updated with the formula:
+            `ema_param = (1-momentum) * ema_param + momentum * cur_param`.
+-            Defaults to 0.0002.
++            Defaults to 0.0001.
+         skip_buffers (bool): Whether to skip the model buffers, such as
+             batchnorm running stats (running_mean, running_var), it does not
+             perform the ema operation. Default to False.",Changing the default value may cause BC-breaking. Suggest changing this value in config.,What's the reason for this change?
+276,"@@ -325,7 +325,7 @@ class SimpleConfig(Logger):
+         slider_pos = max(slider_pos, 0)
+         slider_pos = min(slider_pos, len(FEE_ETA_TARGETS))
+         if slider_pos < len(FEE_ETA_TARGETS):
+-            num_blocks = FEE_ETA_TARGETS[slider_pos]
++            num_blocks = FEE_ETA_TARGETS[int(slider_pos)]
+             fee = self.eta_target_to_fee(num_blocks)
+         else:
+             fee = self.eta_target_to_fee(1)",how does that happen?,"The `slider_pos` is always an integer, this is always a `int`."
+277,"@@ -31,9 +31,9 @@
+ #
+ from __future__ import print_function
+
+-import unittest
++import unittest, doctest
+ import os,sys
+-
++from rdkit.six import exec_
+ from rdkit.six.moves import cPickle
+
+ from rdkit import rdBase",This is gross/clever. :-),Please remove this file.
+278,"@@ -1,6 +1,6 @@
+ require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb')
+
+-class TestZhCnLocale < Test::Unit::TestCase
++class TestZhLocale < Test::Unit::TestCase
+   def setup
+     Faker::Config.locale = 'zh-CN'
+   end",Take a look at the name of this file. Definitely copy and  ,Style/ClassAndModuleChildren: Use nested module/class definiti
+279,"@@ -163,12 +163,15 @@ func NewVolumeInfo(URL string, volname string, namespace string) (volInfo *Volum
+ 		if resp.StatusCode == 500 {
+ 			fmt.Printf(""Volume: %s not found at namespace: %q\n"", volname, namespace)
+ 			err = util.InternalServerError
++			return
+ 		} else if resp.StatusCode == 503 {
+ 			fmt.Printf(""maya apiservice not reachable at %q\n"", mapiserver.GetURL())
+ 			err = util.ServerUnavailable
++			return
+ 		} else if resp.StatusCode == 404 {
+ 			fmt.Printf(""Volume: %s not found at namespace: %q error: %s\n"", volname, namespace, http.StatusText(resp.StatusCode))
+ 			err = util.PageNotFound
++			return
+ 		}
+ 		fmt.Printf(""Received an error from maya apiservice: statuscode: %d"", resp.StatusCode)
+ 		err = fmt.Errorf(""Received an error from maya apiservice: statuscode: %d"", resp.StatusCode)",Can you check with @mahebbar how to work this error. Should be different from 404.,I don't think we should return these errors. If the response i
+280,"@@ -46,7 +46,7 @@ setup(
+         'spark': ['pyspark>=2.4.0'],
+         'mlflow': ['mlflow>=1.0'],
+     },
+-    python_requires='>=3.5,<3.8',
++    python_requires='>=3.5',
+     install_requires=[
+         'pandas>=0.23.2',
+         'pyarrow>=0.10',",Do we still need the upper bound `<3.9`?,How about `<3.6`?
+281,"@@ -229,7 +229,10 @@ function getPathsToCheck($f_paths): ?array
+             /** @var string */
+             $input_path = $input_paths[$i];
+
+-            if (realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm')
++            if (
++                realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')
++                || realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalter')
++                || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm')
+                 || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalter')
+                 || realpath($input_path) === realpath(Phar::running(false))
+             ) {",Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?,The first two `re
+282,"@@ -1,4 +1,4 @@
+-package aws_test
++package aws
+
+ import (
+ 	""fmt""","@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user.",why did you chang
+283,"@@ -54,8 +54,6 @@ func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter
+ 	instruments := map[string]data{
+ 		""test-int64-counter"":         {sdkapi.CounterInstrumentKind, number.Int64Kind, 1},
+ 		""test-float64-counter"":       {sdkapi.CounterInstrumentKind, number.Float64Kind, 1},
+-		""test-int64-histogram"":       {sdkapi.HistogramInstrumentKind, number.Int64Kind, 2},
+-		""test-float64-histogram"":     {sdkapi.HistogramInstrumentKind, number.Float64Kind, 2},
+ 		""test-int64-gaugeobserver"":   {sdkapi.GaugeObserverInstrumentKind, number.Int64Kind, 3},
+ 		""test-float64-gaugeobserver"": {sdkapi.GaugeObserverInstrumentKind, number.Float64Kind, 3},
+ 	}","The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?",why remove these?
+284,"@@ -274,6 +274,13 @@ func (eval *BlockEvaluator) Round() basics.Round {
+ 	return eval.block.Round()
+ }
+
++// ResetTxnBytes resets the number of bytes tracked by the BlockEvaluator to
++// zero.  This is a specialized operation used by the transaction pool to
++// simulate the effect of putting pending transactions in multiple blocks.
++func (eval *BlockEvaluator) ResetTxnBytes(validateTxnBytes bool) {
++	eval.totalTxBytes = 0
++}
++
+ // Transaction tentatively adds a new transaction as part of this block evaluation.
+ // If the transaction cannot be added to the block without violating some constraints,
+ // an error is returned and the block evaluator state is unchanged.",should this increment eval.Round somehow?,"This is fine, but I'd like to see a test for it."
+285,"@@ -91,7 +91,7 @@ class Blacklight::Solr::Response < ActiveSupport::HashWithIndifferentAccess
+         value.each { |v| force_to_utf8(v) }
+       when String
+         if value.encoding != Encoding::UTF_8
+-          Rails.logger.warn ""Found a non utf-8 value in Blacklight::Solr::Response. \""#{value}\"" Encoding is #{value.encoding}""
++          Blacklight.logger.warn ""Found a non utf-8 value in Blacklight::Solr::Response. \""#{value}\"" Encoding is #{value.encoding}""
+           value.dup.force_encoding('UTF-8')
+         else
+           value",Although this change looks good. Maybe there are other inconsistent cases too?,Is there a reason to use `blacklight.logger` ove
+286,"@@ -21,7 +21,7 @@ module ApplicationHelper
+     '/auth/github'
+   end
+
+-  def format_resources(resources)
++  def format_markdown(resources)
+     BlueCloth.new(resources).to_html.html_safe
+   end
+ ",This is a way better method name.,what is the point of this change?
+287,"@@ -1,7 +1,5 @@
+ class NewLanguageConfirmationsController < ApplicationController
+   def index
+-    redirect_to welcome_to_upcase_path(
+-      confirmation: true, language_selected: params[:language],
+-    ), notice: ""Thanks for signing up. We will be in touch!""
++    redirect_to root_path, notice: t(""marketing.show.language_flash"")
+   end
+ end",Prefer single-quoted strings when you don't need string interpolation or special symbols.,Style/StringLiterals: Prefer single-quoted strin
+288,"@@ -1,3 +1,5 @@
++options = Array.isArray(options) ? options : [];
++
+ var invalid = [];
+
+ var attr, attrName, allowed,","I was wondering if this should allow per role specification, instead of (or in addition to) a generic ""allowed everywhere"". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the ""generic"" case you've got now: `{ '*': ['always-allowed'] }`.","I think it would be better to do `Array.isArray(options) ? options : []` here, since you don't need to do anything with an array :)"
+289,"@@ -942,7 +942,8 @@ SQLVarChar::SQLVarChar(Lng32 maxLen,
+ 	       FALSE, allowSQLnull, isUpShifted, isCaseInsensitive,
+ 	       TRUE, cs, co, ce,
+ 	       encoding, vcIndLen),
+-      clientDataType_(collHeap())  // Get heap from NABasicObject. Can't allocate on stack.
++      clientDataType_(collHeap()),  // Get heap from NABasicObject. Can't allocate on stack.
++      wasHiveString_(FALSE)
+ {}
+ #pragma warn(1506)  // warning elimination
+ ",I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...),I'm curious why this needed to be added?
+290,"@@ -31,12 +31,7 @@ import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.grid.sessionmap.local.LocalSessionMap;
+ import org.openqa.selenium.netty.server.NettyServer;
+ import org.openqa.selenium.remote.SessionId;
+-import org.openqa.selenium.remote.http.HttpClient;
+-import org.openqa.selenium.remote.http.HttpHandler;
+-import org.openqa.selenium.remote.http.HttpRequest;
+-import org.openqa.selenium.remote.http.HttpResponse;
+-import org.openqa.selenium.remote.http.TextMessage;
+-import org.openqa.selenium.remote.http.WebSocket;
++import org.openqa.selenium.remote.http.*;
+ import org.openqa.selenium.remote.tracing.DefaultTestTracer;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ ",Could you please leave the explicit imports?,Don't use wildcard imports.
+291,"@@ -23,7 +23,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/hash""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+-	""github.com/iotexproject/iotex-core/proto""
++	iproto ""github.com/iotexproject/iotex-core/proto""
+ 	""github.com/iotexproject/iotex-core/state/factory""
+ )
+ ",Why need alias?,"The ""proto"" packages are usually moved to ""iotexproject/iotex-core/pkg/iproto"" package."
+292,"@@ -148,6 +148,10 @@ func (c testTLFJournalConfig) teamMembershipChecker() kbfsmd.TeamMembershipCheck
+ 	return nil
+ }
+
++func (c testTLFJournalConfig) tlfIDGetter() tlfIDGetter {
++	return nil
++}
++
+ func (c testTLFJournalConfig) diskLimitTimeout() time.Duration {
+ 	return c.dlTimeout
+ }","Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?",can tlfIDGetter be an interface?
+293,"@@ -156,6 +156,9 @@ const (
+ 	tealsignTooManyArg    = ""--set-lsig-arg-idx too large, maximum of %d arguments""
+ 	tealsignInfoWroteSig  = ""Wrote signature for %s to LSig.Args[%d]""
+
++	tealLogicSigSize = ""%s: logicsig program size too large: %d > %d""
++	tealAppSize      = ""%s: app program size too large: %d > %d""
++
+ 	// Wallet
+ 	infoRecoveryPrompt           = ""Please type your recovery mnemonic below, and hit return when you are done: ""
+ 	infoChoosePasswordPrompt     = ""Please choose a password for wallet '%s': """,I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings.,`tealLogicSigSize` > `tealAppSiz
+294,"@@ -118,9 +118,6 @@ Status FetchVerticesExecutor::prepareTags() {
+             if (!tagIdStatus.ok()) {
+                 return tagIdStatus.status();
+             }
+-            auto tagId = tagIdStatus.value();
+-            tagNames_.push_back(tagName);
+-            tagIds_.push_back(tagId);
+             auto result = tagNameSet_.emplace(tagName);
+             if (!result.second) {
+                 return Status::Error(folly::sformat(""tag({}) was dup"", tagName));",Seems we don't need it anymore.,Any particular reason to remove
+295,"@@ -54,7 +54,7 @@ class Guidance < ActiveRecord::Base
+   validates :published, inclusion: { message: INCLUSION_MESSAGE,
+                                      in: BOOLEAN_VALUES}
+
+-  validates :themes, presence: { message: PRESENCE_MESSAGE }
++  validates :themes, presence: { message: PRESENCE_MESSAGE }, if: :published?
+
+   # Retrieves every guidance associated to an org
+   scope :by_org, -> (org) {",This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough.,what does the `if: :published?`
+296,"@@ -75,7 +75,7 @@ func NewRawExporter(config Config) (*Exporter, error) {
+ // 	defer pipeline.Stop()
+ // 	... Done
+ func InstallNewPipeline(config Config) (*push.Controller, error) {
+-	controller, err := NewExportPipeline(config)
++	controller, err := NewExportPipeline(config, time.Hour)
+ 	if err != nil {
+ 		return controller, err
+ 	}","this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below...",Why is the default being changed from `time.Hour` to `time.Minute`?
+297,"@@ -92,6 +92,15 @@ func (ACMEIssuer) CaddyModule() caddy.ModuleInfo {
+ func (iss *ACMEIssuer) Provision(ctx caddy.Context) error {
+ 	iss.logger = ctx.Logger(iss)
+
++	// expand email address, if non-empty
++	if iss.Email != """" {
++		email, err := caddy.NewReplacer().ReplaceOrErr(iss.Email, true, true)
++		if err != nil {
++			return fmt.Errorf(""expanding email address '%s': %v"", iss.Email, err)
++		}
++		iss.Email = email
++	}
++
+ 	// DNS providers
+ 	if iss.Challenges != nil && iss.Challenges.DNS != nil && iss.Challenges.DNS.ProviderRaw != nil {
+ 		val, err := ctx.LoadModule(iss.Challenges.DNS, ""ProviderRaw"")","I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here",nit: s/email/email/ to be consistent with the rest of the codebase
+298,"@@ -29,7 +29,9 @@ TestEnv::~TestEnv() {
+ void TestEnv::SetUp() {
+     FLAGS_load_data_interval_secs = 1;
+     // Create metaServer
+-    metaServer_ = nebula::meta::TestUtils::mockMetaServer(0, metaRootPath_.path());
++    metaServer_ = nebula::meta::TestUtils::mockMetaServer(
++                                                    network::NetworkUtils::getAvailablePort(),
++                                                    metaRootPath_.path());
+     FLAGS_meta_server_addrs = folly::stringPrintf(""127.0.0.1:%d"", metaServerPort());
+
+     // Create storageServer",Why change the port from 0 to getAvailablePort()?,This looks like a test failure. Is it related to this PR?
+299,"@@ -691,9 +691,9 @@ class TestSeleniumScriptGeneration(SeleniumTestCase):
+             content = fds.read()
+
+         target_lines = [
+-            ""var_loc_keys=self.loc_mng.get_locator([{'name':'btn1',}])self.driver.find_element""
++            ""var_loc_keys=self.loc_mng.get_locator([{'name':'btn1',}],30.0)self.driver.find_element""
+             ""(var_loc_keys[0],var_loc_keys[1]).click()"",
+-            ""var_loc_keys=self.loc_mng.get_locator([{'id':'Id_123',}])self.driver.find_element""
++            ""var_loc_keys=self.loc_mng.get_locator([{'id':'Id_123',}],30.0)self.driver.find_element""
+             ""(var_loc_keys[0],var_loc_keys[1]).clear()"",
+             ""self.driver.find_element(var_loc_keys[0],var_loc_keys[1]).send_keys('London')""
+         ]","For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`",Could you explain why this change is needed?
+300,"@@ -30,8 +30,9 @@ func NewGlobalOpts() *GlobalOpts {
+ 	bindProjectName()
+
+ 	return &GlobalOpts{
+-		projectName: viper.GetString(projectFlag),
+-		prompt:      prompt.New(),
++		// Leave the projectName as empty in case it's overwritten by a global flag.
++		// See https://github.com/aws/amazon-ecs-cli-v2/issues/570#issuecomment-569133741
++		prompt: prompt.New(),
+ 	}
+ }
+ ","I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired.","You can leave the project name as it was before, but the `--project` flag won't be set if the project is empty."
+301,"@@ -531,7 +531,7 @@ namespace Nethermind.Core.Extensions
+         [DebuggerStepThrough]
+         public static string ByteArrayToHexViaLookup32Safe(byte[] bytes, bool withZeroX)
+         {
+-            if (bytes.Length == 0)
++            if (bytes?.Length == 0 || bytes == null)
+             {
+                 return withZeroX ? ""0x"" : """";
+             }",why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place,"This is a change in behavior. Before, if the array was null, we would return ""0x"" with zeroX. Now, if it's null"
+302,"@@ -142,15 +142,12 @@ axe.utils.getNodeFromTree = function(vNode, node) {
+ 		return vNode;
+ 	}
+ 	vNode.children.forEach(candidate => {
+-		var retVal;
+-
+-		if (candidate.actualNode === node) {
++		if (found) {
++			return;
++		} else if (candidate.actualNode === node) {
+ 			found = candidate;
+ 		} else {
+-			retVal = axe.utils.getNodeFromTree(candidate, node);
+-			if (retVal) {
+-				found = retVal;
+-			}
++			found = axe.utils.getNodeFromTree(candidate, node);
+ 		}
+ 	});
+ 	return found;",nit: can remove this `else` since we return from the condition above.,The `found` variable was never used.
+303,"@@ -39,11 +39,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             _flushCompleted = OnFlushCompleted;
+         }
+
+-        public void Write(ArraySegment<byte> buffer, bool chunk = false)
+-        {
+-            WriteAsync(buffer, default(CancellationToken), chunk).GetAwaiter().GetResult();
+-        }
+-
+         public Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken))
+         {
+             if (cancellationToken.IsCancellationRequested)",You missed `Write<T>(...)`! I'm kidding ofc.,Does this mean we no longer need to call `WriteAsync`?
+304,"@@ -5,7 +5,7 @@ class SubscriptionUpcomingInvoiceUpdater
+
+   def process
+     @subscriptions.each do |subscription|
+-      if subscription.stripe_customer_id
++      if subscription.stripe_customer_id.present?
+         upcoming_invoice = upcoming_invoice_for(subscription.stripe_customer_id)
+         update_next_payment_information(subscription, upcoming_invoice)
+       end",Was there a customer who had this set to an empty string?,Rails/Present: Use if !subscription.stripe_customer_id.present? instead of if !subscription.stripe_customer_id.present?.
+305,"@@ -13,6 +13,14 @@ module Ncr
+       approver_email_address(final_approver)
+     end
+
++    def status_aware_approver_email_address
++      if proposal.approved?
++        final_approver_email_address
++      else
++        current_approver_email_address
++      end
++    end
++
+     private
+
+     def approver_email_address(approver)","I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test.",What is the difference between `approved?` and `current_approver_email_address`?
+306,"@@ -34,4 +34,6 @@ public interface RestClientRequest {
+   void addForm(String name, Object value);
+
+   Buffer getBodyBuffer() throws Exception;
++
++  void attach(String name, String filename);
+ }","it's better to be : void attach(String name, Part part);","Minor naming nit: since this is used in a couple places, maybe `setFileName` would be a better name?"
+307,"@@ -77,7 +77,8 @@ public abstract class BasePageIterator {
+   protected abstract void initDefinitionLevelsReader(DataPageV1 dataPageV1, ColumnDescriptor descriptor,
+                                                      ByteBufferInputStream in, int count) throws IOException;
+
+-  protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2, ColumnDescriptor descriptor);
++  protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2, ColumnDescriptor descriptor)
++          throws IOException;
+
+   public int currentPageCount() {
+     return triplesCount;","I didn't see where the IOException can get thrown, is this just to match the V1 reader?",What's the reason for this change?
+308,"@@ -418,7 +418,7 @@ unsigned int compute2DCoordsMimicDistMat(
+     RDKit::ROMol &mol, const DOUBLE_SMART_PTR *dmat, bool canonOrient,
+     bool clearConfs, double weightDistMat, unsigned int nFlipsPerSample,
+     unsigned int nSamples, int sampleSeed, bool permuteDeg4Nodes,
+-    bool forceRDKit) {
++    bool /* forceRDKit */) {
+   // storage for pieces of a molecule/s that are embedded in 2D
+   std::list<EmbeddedFrag> efrags;
+   computeInitialCoords(mol, nullptr, efrags);",We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`,Perhaps this should be `bool forcePermuteDeg4Nodes`
+309,"@@ -473,12 +473,11 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
+ 		return nullptr;
+ 	}
+
+-	for (const auto& it : players) {
+-		if (guid == it.second->getGUID()) {
+-			return it.second;
+-		}
++	auto it = mappedPlayerGuids.find(guid);
++	if (it == mappedPlayerGuids.end()) {
++		return nullptr;
+ 	}
+-	return nullptr;
++	return it->second;
+ }
+
+ ReturnValue Game::getPlayerByNameWildcard(const std::string& s, Player*& player)","What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?",Please don't make unrelated changes like this - it'
+310,"@@ -129,7 +129,7 @@ public class ApplicationsSidebar extends Sidebar {
+         this.testingCheck = new SidebarCheckBox(tr(""Testing""));
+         this.testingCheck.selectedProperty().bindBidirectional(filter.containTestingApplicationsProperty());
+
+-        this.requiresPatchCheck = new SidebarCheckBox(tr(""Requires patch""));
++        this.requiresPatchCheck = new SidebarCheckBox(tr(""Patch Required""));
+         this.requiresPatchCheck.selectedProperty().bindBidirectional(filter.containRequiresPatchApplicationsProperty());
+
+         this.commercialCheck = new SidebarCheckBox(tr(""Commercial""));","Why upper case ""R""?","Maybe ""Patch Required"" to match the rest of the cla"
+311,"@@ -107,3 +107,19 @@ func relativeDockerfilePath(ws copilotDirGetter, dockerfilePath string) (string,
+ 	}
+ 	return relDfPath, nil
+ }
++
++// dfBuildRequired returns if the container image should be built from local Dockerfile.
++func dfBuildRequired(svc interface{}) (bool, error) {
++	type manifest interface {
++		BuildRequired() (bool, error)
++	}
++	mf, ok := svc.(manifest)
++	if !ok {
++		return false, fmt.Errorf(""service does not have required methods BuildRequired()"")
++	}
++	required, err := mf.BuildRequired()
++	if err != nil {
++		return false, fmt.Errorf(""check if service requires building from local Dockerfile: %w"", err)
++	}
++	return required, nil
++}","Does this need to return an error or could it return `false, nil`?",Why not just make this a required method on the `Se
+312,"@@ -94,7 +94,7 @@ public abstract class Analyzer implements Closeable {
+    * Create a new Analyzer, reusing the same set of components per-thread
+    * across calls to {@link #tokenStream(String, Reader)}.
+    */
+-  public Analyzer() {
++  protected Analyzer() {
+     this(GLOBAL_REUSE_STRATEGY);
+   }
+ ",Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change.,does this really need to be protected?
+313,"@@ -85,7 +85,7 @@ class TranslationsController extends BaseAdminController
+                 'item_to_translate'             => $item_to_translate,
+                 'item_name'                     => $item_name,
+                 'module_part'                   => $module_part,
+-                'view_missing_traductions_only' => $this->getRequest()->get('view_missing_traductions_only', 1),
++                'view_missing_traductions_only' => $this->getRequest()->get('view_missing_traductions_only'),
+                 'max_input_vars_warning'        => false,
+         );
+ ","this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks",I don't think we should remove the opt
+314,"@@ -29,8 +29,8 @@ export default function(config: Config, auth: IAuth, storage: IStorageHandler) {
+   // this might be too harsh, so ask if it causes trouble
+   // $FlowFixMe
+   app.param('package', validatePackage);
++  app.param('filename', validatePackage);
+   // $FlowFixMe
+-  app.param('filename', validateName);
+   app.param('tag', validateName);
+   app.param('version', validateName);
+   app.param('revision', validateName);",Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403.,I think if you remove the `filename` p
+315,"@@ -639,7 +639,11 @@ class LabelledData(param.Parameterized):
+             for k, v in self.items():
+                 new_val = v.map(map_fn, specs, clone)
+                 if new_val is not None:
+-                    deep_mapped[k] = new_val
++                    # Ensure key validation doesn't cause errors
++                    try:
++                        deep_mapped[k] = new_val
++                    except KeyError:
++                        pass
+             if applies: deep_mapped = map_fn(deep_mapped)
+             return deep_mapped
+         else:",I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?,I'm not familiar with this code. Do yo
+316,"@@ -427,6 +427,15 @@ func (te *transactorEndpoint) Withdraw(c *gin.Context) {
+ 	}
+
+ 	chainID := config.GetInt64(config.FlagChainID)
++	if req.ChainID != 0 {
++		if _, ok := registry.Chains()[req.ChainID]; !ok {
++			utils.SendError(resp, errors.New(""Unsupported chain""), http.StatusBadRequest)
++			return
++		}
++
++		chainID = req.ChainID
++	}
++
+ 	err = te.promiseSettler.Withdraw(chainID, identity.FromAddress(req.ProviderID), common.HexToAddress(req.HermesID), common.HexToAddress(req.Beneficiary))
+ 	if err != nil {
+ 		utils.SendError(resp, err, http.StatusInternalServerError)","this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from.",Can we use constants for the ChainID field names?
+317,"@@ -57,7 +57,11 @@ func (TraceContext) Inject(ctx context.Context, supplier propagation.HTTPSupplie
+ }
+
+ func (tc TraceContext) Extract(ctx context.Context, supplier propagation.HTTPSupplier) context.Context {
+-	return ContextWithRemoteSpanContext(ctx, tc.extract(supplier))
++	sc := tc.extract(supplier)
++	if !sc.IsValid() {
++		return ctx
++	}
++	return ContextWithRemoteSpanContext(ctx, sc)
+ }
+
+ func (TraceContext) extract(supplier propagation.HTTPSupplier) core.SpanContext {","If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?",What does this fix do?
+318,"@@ -22,8 +22,8 @@
+ #include ""depotchest.h""
+ #include ""tools.h""
+
+-DepotChest::DepotChest(uint16_t type) :
+-	Container(type), maxDepotItems(2000) {}
++DepotChest::DepotChest(uint16_t type, bool paginated /*= true*/) :
++	Container(type, items[type].maxItems, true, paginated), maxDepotItems(2000) {}
+
+ ReturnValue DepotChest::queryAdd(int32_t index, const Thing& thing, uint32_t count,
+ 		uint32_t flags, Creature* actor/* = nullptr*/) const",here shouldn't we use `depotFreeLimit`?,why do you pass a `bool` here? why not just do `i
+319,"@@ -0,0 +1,3 @@
++# A secret token used to encrypt user_id's in the Bookmarks#export callback URL
++# functionality, for example in Refworks export of Bookmarks.
++Rails.application.config.blacklight_export_secret_token = '<%= SecureRandom.hex(64) %>'",Could we use the Rails application's secret token instead? Do we actually need our own here?,I wonder if we should have this default to someth
+320,"@@ -80,6 +80,10 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
+
+         self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.b, as_index=False))
+
++        self.assertRaises(ValueError, lambda: kdf.groupby('a', axis=1))
++        self.assertRaises(ValueError, lambda: kdf.groupby('a', 'b'))
++        self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.a, kdf.b))
++
+         # we can't use column name/names as a parameter `by` for `SeriesGroupBy`.
+         self.assertRaises(KeyError, lambda: kdf.a.groupby(by='a'))
+         self.assertRaises(KeyError, lambda: kdf.a.groupby(by=['a', 'b']))",so should be fixed here also,Please add a check for `as_index=True`
+321,"@@ -6478,8 +6478,13 @@ dr_get_mcontext_priv(dcontext_t *dcontext, dr_mcontext_t *dmc, priv_mcontext_t *
+          * when most old clients have been converted, remove this (we'll
+          * still return false)
+          */
+-        CLIENT_ASSERT(dmc->size == sizeof(dr_mcontext_t),
+-                      ""dr_mcontext_t.size field not set properly"");
++        CLIENT_ASSERT(
++            dmc->size == sizeof(dr_mcontext_t) ||
++                /* Opmask storage has been added for AVX-512 (xref i#1312).
++                 * An older client's mcontext may be filled in w/o the new structure.
++                 */
++                dmc->size == sizeof(dr_mcontext_t) - sizeof(dr_opmask_t),
++            ""dr_mcontext_t.size field not set properly"");
+         CLIENT_ASSERT(dmc->flags != 0 && (dmc->flags & ~(DR_MC_ALL)) == 0,
+                       ""dr_mcontext_t.flags field not set properly"");
+     } else",I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below.,I think this should say something like
+322,"@@ -28,6 +28,7 @@ func DefaultConfig() Config {
+ 		ReservedPorts:               []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort},
+ 		ReservedPortsUDP:            []uint16{},
+ 		DataDir:                     ""/data/"",
++		HostDataDir:                 ""/var/lib/ecs/"",
+ 		DisableMetrics:              false,
+ 		ReservedMemory:              0,
+ 		AvailableLoggingDrivers:     []dockerclient.LoggingDriver{dockerclient.JSONFileDriver},",`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary.,Why is this hardcoded to /var/lib/ecs?
+323,"@@ -37,6 +37,9 @@ const (
+ 	defaultMTUGRE             = 1462
+ 	defaultMTUSTT             = 1500
+ 	defaultMTU                = 1500
++	// IPsec ESP can add a maximum of 38 bytes to the packet including the ESP
++	// header and trailer.
++	ipsecESPOverhead = 38
+ )
+
+ type Options struct {",I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec.,can you add a link to the docs for thi
+324,"@@ -14,11 +14,15 @@
+ // limitations under the License.
+ // </copyright>
+
+-#nullable enable
++using System;
++using System.Collections.Generic;
++using System.Diagnostics.Metrics;
+
+ namespace OpenTelemetry.Metrics
+ {
+     public abstract class MeasurementProcessor : BaseProcessor<MeasurementItem>
+     {
++        public abstract void OnEnd<T>(MeasurementItem measurementItem, ref DateTimeOffset dt, ref T value, ref ReadOnlySpan<KeyValuePair<string, object>> tags)
++            where T : struct;
+     }
+ }","Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor<MeasurementItem> (not blocking. just noting some observations in the PR :) )",Should the parameter type be named `T` instead of `T`?
+325,"@@ -3,6 +3,13 @@ package cmd
+ import (
+ 	""bufio""
+ 	""fmt""
++	""io/ioutil""
++	""os""
++	""path""
++	""path/filepath""
++	""runtime""
++	""strings""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.,can you add gitea copyright header to this file
+326,"@@ -51,7 +51,8 @@ type Options struct {
+ 	DefaultSamplingPolicy trace.Sampler
+ }
+
+-// New creates a new server. New(nil) is the same as new(Server).
++// New creates a new server. New(nil) is the same as new(Server). Note: A
++// configured Requestlogger will not log HealthChecks.
+ func New(opts *Options) *Server {
+ 	srv := new(Server)
+ 	if opts != nil {",This seems like a more appropriate message under `ListenAndServe`. WDYT?,Consider adding a note that a configured Requestlogger
+327,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?,`await driver.stop()` is now unnecessary because `driv
+328,"@@ -360,7 +360,16 @@ class AdminController extends Controller
+         }
+
+         $searchableFields = $this->entity['search']['fields'];
+-        $paginator = $this->findBy($this->entity['class'], $this->request->query->get('query'), $searchableFields, $this->request->query->get('page', 1), $this->config['list']['max_results'], $this->request->query->get('sortField'), $this->request->query->get('sortDirection'), $this->entity['search']['dql_filter']);
++        $paginator = $this->findBy(
++            $this->entity['class'],
++            $this->request->query->get('query'),
++            $searchableFields,
++            $this->request->query->get('page', 1),
++            $this->config['list']['max_results'],
++            isset($this->entity['search']['sort']['field']) ? $this->entity['search']['sort']['field'] : $this->request->query->get('sortField'),
++            isset($this->entity['search']['sort']['direction']) ? $this->entity['search']['sort']['direction'] : $this->request->query->get('sortDirection'),
++            $this->entity['search']['dql_filter']
++        );
+         $fields = $this->entity['list']['fields'];
+
+         $this->dispatch(EasyAdminEvents::POST_SEARCH, array(",We should start thinking of an object that encapsulates this information :) we might need more arguments in the future.,Wouldn't it be better to pass the `$this->entity['search']['sort']` and `$this->request->query->get('sortDirection')` together to the `findBy` method?
+329,"@@ -4652,10 +4652,12 @@ TEST_F(VkLayerTest, RenderPassBarrierConflicts) {
+     img_barrier.subresourceRange.levelCount = 1;
+     // Mis-match src stage mask
+     m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-srcStageMask-01173"");
++    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-dstStageMask-01174"");
+     vkCmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_HOST_BIT, VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
+                          VK_DEPENDENCY_BY_REGION_BIT, 0, nullptr, 0, nullptr, 1, &img_barrier);
+     m_errorMonitor->VerifyFound();
+     // Now mis-match dst stage mask
++    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-srcStageMask-01173"");
+     m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-dstStageMask-01174"");
+     vkCmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_PIPELINE_STAGE_HOST_BIT,
+                          VK_DEPENDENCY_BY_REGION_BIT, 0, nullptr, 0, nullptr, 1, &img_barrier);","Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct.",Did the test fail because of this error?
+330,"@@ -52,11 +52,11 @@ public class EthMiningTest {
+   public void shouldReturnTrueWhenMiningCoordinatorExistsAndRunning() {
+     final JsonRpcRequest request = requestWithParams();
+     final JsonRpcResponse expectedResponse = new JsonRpcSuccessResponse(request.getId(), true);
+-    when(miningCoordinator.isRunning()).thenReturn(true);
++    when(miningCoordinator.isMining()).thenReturn(true);
+
+     final JsonRpcResponse actualResponse = method.response(request);
+     assertThat(actualResponse).isEqualToComparingFieldByField(expectedResponse);
+-    verify(miningCoordinator).isRunning();
++    verify(miningCoordinator).isMining();
+     verifyNoMoreInteractions(miningCoordinator);
+   }
+ ",rename? MiningCoordinator always exists,"The way I read this test, it looks like `miningCoordinator.isMining()` returns true, but `miningCoordinator.isMining()` returns false. Is this intenti"
+331,"@@ -8,7 +8,8 @@
+ var ip = {},
+     net = require('net'),
+     extIP = require('external-ip'),
+-    plugins = require('../../../plugins/pluginManager.js');
++    plugins = require('../../../plugins/pluginManager.js'),
++    offlineMode = plugins.getConfig(""api"").offline_mode;
+
+ /**
+  * Function to get the hostname/ip address/url to access dashboard","Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file.",This should be `pluginManager.js` and not `../../../plugins/pluginManager.js`
+332,"@@ -486,6 +486,8 @@ func (d *Dir) Cleanup(ctx context.Context, fi *dokan.FileInfo) {
+ 	defer func() { d.folder.reportErr(ctx, libkbfs.WriteMode, err) }()
+
+ 	if fi != nil && fi.IsDeleteOnClose() && d.parent != nil {
++		d.folder.fs.renameAndDeletionLock.Lock()
++		defer d.folder.fs.renameAndDeletionLock.Unlock()
+ 		d.folder.fs.log.CDebugf(ctx, ""Removing (Delete) dir in cleanup %s"", d.name)
+
+ 		err = d.folder.fs.config.KBFSOps().RemoveDir(ctx, d.parent, d.name)","Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me.",Shouldn't we also set `d.folder.fs.renameAndDeletionLock` after the call to `DeleteDir`?
+333,"@@ -56,7 +56,7 @@ func Test_Mine(t *testing.T) {
+ 	baseBlock := &block.Block{Height: 2, StateRoot: stateRoot, Tickets: []block.Ticket{{VRFProof: []byte{0}}}}
+ 	tipSet := th.RequireNewTipSet(t, baseBlock)
+
+-	st, pool, addrs, cst, bs := sharedSetup(t, mockSignerVal)
++	st, pool, addrs, _, bs := sharedSetup(t, mockSignerVal)
+ 	getStateTree := func(c context.Context, ts block.TipSet) (state.Tree, error) {
+ 		return st, nil
+ 	}",Does anyone still use the cst out of this method? If not consider deleting,This is the bugfix
+334,"@@ -9,6 +9,7 @@ get(
+     ""/getting-started-with-ios-development?utm_source=podcast""
+   )
+ )
++get ""/videos/vim-for-rails-developers"" => redirect(""https://www.youtube.com/watch?v=9J2OjH8Ao_A"")
+ get ""/humans-present/oss"" => redirect( ""https://www.youtube.com/watch?v=VMBhumlUP-A"")
+ get ""/ios-on-rails"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+ get ""/ios-on-rails-beta"" => redirect(""https://gumroad.com/l/ios-on-rails"")",Line is too long. [97/80],Does it make sense to follow the convention above and use `/videos/vim-for-rails-develop
+335,"@@ -1,12 +1,14 @@
+ """""" Testing for data_transfer.py """"""
+
+ ### Python imports
++from io import BytesIO
+ import pathlib
+
+ from unittest import mock
+
+ ### Third-party imports
+ from botocore.stub import ANY
++from botocore.exceptions import ReadTimeoutError
+ import pandas as pd
+ import pytest
+ ",This seems unused.,Please remove this line
+336,"@@ -184,8 +184,8 @@ func GetOSInterface() types.OSTypeInstaller {
+ 	case CentOSType:
+ 		return &CentOS{}
+ 	default:
++		panic(""unsupport os-release"")
+ 	}
+-	return nil
+ }
+
+ //IsKubeEdgeController identifies if the node is having edge controller and k8s api-server already running.","@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like ""This OS version is currently un-supported by keadm""","Can you make this message more explicit, e.g. `panic(""unsupport os-release"")`"
+337,"@@ -53,6 +53,10 @@ from rdkit.Chem.Draw import rdMolDraw2D
+ from rdkit.Chem import rdDepictor
+ from rdkit.Chem import rdMolDescriptors as rdMD
+
++def _CleanFpInfoAttr_(mol):
++  if hasattr(mol, '_fpInfo'):
++    delattr(mol, '_fpInfo')
++
+
+ def GetAtomicWeightsForFingerprint(refMol, probeMol, fpFunction, metric=DataStructs.DiceSimilarity):
+   """"""",should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`.,why not just `del` rather than `del`?
+338,"@@ -7101,6 +7101,13 @@ bool CoreChecks::PreCallValidateCmdBindDescriptorSets(VkCommandBuffer commandBuf
+                          ""(%zu) when pipeline layout was created"",
+                          firstSet, setCount, pipeline_layout->set_layouts.size());
+     }
++
++    static const std::map<VkPipelineBindPoint, std::string> bindpoint_errors = {
++        std::make_pair(VK_PIPELINE_BIND_POINT_GRAPHICS, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361""),
++        std::make_pair(VK_PIPELINE_BIND_POINT_COMPUTE, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361""),
++        std::make_pair(VK_PIPELINE_BIND_POINT_RAY_TRACING_NV, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361"")};
++    skip |= ValidatePipelineBindPoint(cb_state, pipelineBindPoint, ""vkCmdBindPipeline()"", bindpoint_errors);
++
+     return skip;
+ }
+ ","nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)","Don't use make_pair here. Instead, create a new map `VK_PIPELINE_BIND_POINT_G"
+339,"@@ -23,6 +23,6 @@ class Api::V1::ExercisesController < ApiController
+   end
+
+   def exercise_parameters
+-    params.require(:exercise).permit(:edit_url, :summary, :title, :url)
++    params.require(:exercise).permit(:edit_url, :summary, :name, :url)
+   end
+ end",This will need to be updated in the upcase-exercises repo as well.,This is unrelated to this PR but I'm curious if this is an issue that we need
+340,"@@ -21,7 +21,7 @@ class Trail < ActiveRecord::Base
+   def steps_remaining_for(user)
+     ExerciseWithProgressQuery.
+       new(user: user, exercises: exercises).
+-      count { |exercise| exercise.state != Status::REVIEWED }
++      count { |exercise| exercise.state != Status::COMPLETE }
+   end
+
+   def self.most_recent_published",Think it's worth extracting this to `Exercise#complete?`?,What's the reason for this change?
+341,"@@ -87,14 +87,6 @@ class Currency
+         return $this->exchangeRate;
+     }
+
+-    /**
+-     * @return string
+-     */
+-    public function getReversedExchangeRate()
+-    {
+-        return 1 / $this->exchangeRate;
+-    }
+-
+     /**
+      * @param string $exchangeRate
+      */",This is still a potentially useful public method - should we remove such methods?,This should be kept (at least temp
+342,"@@ -40,15 +40,9 @@ public abstract class ApiDefaultsConfig {
+   /** The name of the license of the client library. */
+   public abstract String licenseName();
+
+-  protected abstract Map<TargetLanguage, ReleaseLevel> releaseLevel();
+-
+   /** The development status of the client library. Configured per language. */
+-  public ReleaseLevel releaseLevel(TargetLanguage language) {
+-    ReleaseLevel level = releaseLevel().get(language);
+-    if (level == null) {
+-      level = ReleaseLevel.UNSET_RELEASE_LEVEL;
+-    }
+-    return level;
++  public ReleaseLevel releaseLevel() {
++    return ReleaseLevel.ALPHA;
+   }
+
+   protected abstract Map<TargetLanguage, VersionBound> generatedNonGAPackageVersionBound();","I don't understand this change, what is happening here?",This is a breaking change. It may
+343,"@@ -944,7 +944,8 @@ class ExcelCellTextInfo(NVDAObjectTextInfo):
+
+ 	def _getFormatFieldAndOffsets(self,offset,formatConfig,calculateOffsets=True):
+ 		formatField=textInfos.FormatField()
+-		if (self.obj.excelCellObject.Application.Version > ""12.0""):
++		version=int(self.obj.excelCellObject.Application.Version.split('.')[0])
++		if version>12:
+ 			cellObj=self.obj.excelCellObject.DisplayFormat
+ 		else:
+ 			cellObj=self.obj.excelCellObject",I think its worth stating this is `versionMajor`,should this be `>=` rather than `>
+344,"@@ -375,3 +375,14 @@ func (nc NodeController) readGenesisJSON(genesisFile string) (genesisLedger book
+ 	err = protocol.DecodeJSON(genesisText, &genesisLedger)
+ 	return
+ }
++
++// SetConsensus applies a new consensus settings which would get deployed before
++// any of the nodes starts
++func (nc NodeController) SetConsensus(consensus config.ConsensusProtocols) error {
++	return config.SaveConfigurableConsensus(nc.algodDataDir, consensus)
++}
++
++// GetConsensus rebuild the consensus version from the data directroy
++func (nc NodeController) GetConsensus() (config.ConsensusProtocols, error) {
++	return config.PreloadConfigurableConsensusProtocols(nc.algodDataDir)
++}",rebuild: say loads and merges,what's the meaning of `SetConsensus`? how does it rebuild the version from the data?
+345,"@@ -20,7 +20,6 @@
+  * External dependencies
+  */
+ import { getDefaultOptions } from 'expect-puppeteer';
+-import { Page, ElementHandle } from 'puppeteer';
+
+ /**
+  * Jest matcher for asserting the given instance has tracking loaded or not.",Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?,We no longer need to import `Page` and `ElementHandle`.
+346,"@@ -32,13 +32,12 @@ from databricks.koalas.series import Series
+
+
+ class PySparkTestCase(unittest.TestCase):
+-
+     def setUp(self):
+         self._old_sys_path = list(sys.path)
+         if SparkContext._active_spark_context is not None:
+             SparkContext._active_spark_context.stop()
+         class_name = self.__class__.__name__
+-        self.sc = SparkContext('local[4]', class_name)
++        self.sc = SparkContext(""local[4]"", class_name)
+
+     def tearDown(self):
+         self.sc.stop()",I'd prefer to have a blank line between the class declaration and its first member. Is it possible?,Please avoid un-necessary whitespace changes.
+347,"@@ -299,7 +299,7 @@ describe('Mongos SRV Polling', function () {
+         return records.map(r => `${r.name}:${r.port}`);
+       }
+
+-      const MONGOS_DEFAULT_ISMASTER = Object.assign({}, mock.DEFAULT_ISMASTER_36, {
++      const MONGOS_LEGACY_HELLO = Object.assign({}, mock.HELLO, {
+         msg: 'isdbgrid'
+       });
+ ",Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?,"Please use `const MONGOS_HELLO = Object.assign({}, mock.HELLO, { msg: 'isdbgrid' });"
+348,"@@ -1922,10 +1922,10 @@ detach_on_permanent_stack(bool internal, bool do_cleanup)
+     DEBUG_DECLARE(bool ok;)
+     DEBUG_DECLARE(int exit_res;)
+     /* synch-all flags: if we fail to suspend a thread (e.g., privilege
+-     * problems) ignore it.  XXX Should we retry instead?
++     * problems) retry it.
+      */
+     /* i#297: we only synch client threads after process exit event. */
+-    uint flags = THREAD_SYNCH_SUSPEND_FAILURE_IGNORE | THREAD_SYNCH_SKIP_CLIENT_THREAD;
++    uint flags = THREAD_SYNCH_SUSPEND_FAILURE_RETRY | THREAD_SYNCH_SKIP_CLIENT_THREAD;
+
+     ENTERING_DR();
+ ","I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new ""synchall failure is fatal and should kill the process"" approach it turns what used to work for us on Windows into process death.","Did you mean to change this from ""ignore"" to ""retry""?"
+349,"@@ -45,6 +45,7 @@ program
+   .option('-C <build_dir>', 'build config (out/Debug, out/Release')
+   .option('--target_arch <target_arch>', 'target architecture', 'x64')
+   .option('--mac_signing_identifier <id>', 'The identifier to use for signing')
++  .option('--mac_installer_signing_identifier <id>', 'The identifier to use for signing the installer')
+   .option('--mac_signing_keychain <keychain>', 'The identifier to use for signing', 'login')
+   .option('--debug_build <debug_build>', 'keep debugging symbols')
+   .option('--official_build <official_build>', 'force official build settings')",think it should only be in create_dist,Missing a period at the end of the sentence.
+350,"@@ -429,9 +429,14 @@ func (c *NPLController) handleAddUpdatePod(key string, obj interface{}) error {
+ 			podPorts[port] = struct{}{}
+ 			portData := c.portTable.GetEntryByPodIPPort(podIP, int(cport.ContainerPort))
+ 			if portData == nil { // rule does not exist
+-				nodePort, err = c.portTable.AddRule(podIP, port)
+-				if err != nil {
+-					return fmt.Errorf(""failed to add rule for Pod %s: %v"", key, err)
++				if int(cport.HostPort) > 0 {
++					klog.V(4).Infof(""Host Port is defined for Container %s in Pod %s, thus extra NPL port is not allocated"", container.Name, key)
++					nodePort = int(cport.HostPort)
++				} else {
++					nodePort, err = c.portTable.AddRule(podIP, port)
++					if err != nil {
++						return fmt.Errorf(""failed to add rule for Pod %s: %v"", key, err)
++					}
+ 				}
+ 			} else {
+ 				nodePort = portData.NodePort",Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?,"I think this should be inside the if statement, becau"
+351,"@@ -157,13 +157,14 @@ func (tlf *TLF) GetFileInformation(ctx context.Context, fi *dokan.FileInfo) (st
+ }
+
+ // open tries to open a file.
+-func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (dokan.File, bool, error) {
++func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (
++	dokan.File, dokan.CreateStatus, error) {
+ 	if len(path) == 0 {
+ 		if err := oc.ReturningDirAllowed(); err != nil {
+-			return nil, true, err
++			return nil, 0, err
+ 		}
+ 		tlf.refcount.Increase()
+-		return tlf, true, nil
++		return tlf, dokan.ExistingDir, nil
+ 	}
+
+ 	mode := libkbfs.ReadMode","Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?","Should this be `true, false, nil`?"
+352,"@@ -27,7 +27,11 @@ void deleteRegion(const storage::SharedRegionRegister::ShmKey key)
+
+ void listRegions()
+ {
+-
++    if (!storage::SharedMonitor<storage::SharedRegionRegister>::exists())
++    {
++        osrm::util::Log() << ""No shared memory regions found. Try running osrm-datastore"";
++        return;
++    }
+     storage::SharedMonitor<storage::SharedRegionRegister> monitor;
+     std::vector<std::string> names;
+     const auto &shared_register = monitor.data();",What about just printing an empty list in this case? That would make the output more predictable.,"I think this message could be clearer. ""No shared memory regions found. Try running osrm-datastore."""
+353,"@@ -24,7 +24,6 @@ export default Component.extend({
+
+     init() {
+         this._super(...arguments);
+-        this.container = document.querySelector('.gh-editor-container')[0];
+
+         let mobiledoc = this.get('value') || BLANK_DOC;
+         let userCards = this.get('cards') || [];","I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?",This was causing a circular reference error when running `gulp app:update`.
+354,"@@ -256,11 +256,11 @@ function roots_request_filter($query_vars) {
+ add_filter('request', 'roots_request_filter');
+
+ /**
+- * Tell WordPress to use searchform.php from the templates/ directory
++ * Tell WordPress to use searchform.php from the templates/ directory. Requires WordPress 3.6+
+  */
+-function roots_get_search_form($argument) {
+-  if ($argument === '') {
+-    locate_template('/templates/searchform.php', true, false);
+-  }
++function roots_get_search_form($form) {
++  $form = '';
++  locate_template('/templates/searchform.php', true, false);
++  return $form;
+ }
+ add_filter('get_search_form', 'roots_get_search_form');",I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!,I think this should be `return $form;`.
+355,"@@ -19,6 +19,7 @@ use Thelia\Condition\ConditionEvaluator;
+ use Thelia\Condition\Implementation\MatchForTotalAmount;
+ use Thelia\Condition\Operators;
+ use Thelia\Coupon\FacadeInterface;
++use Thelia\Coupon\Type\FreeProduct;
+ use Thelia\Model\CartItem;
+ use Thelia\Model\CountryQuery;
+ use Thelia\Model\CurrencyQuery;",Fixes test failed in some cases,"The `use` statement should be removed, it isn't used anymore"
+356,"@@ -23,9 +23,7 @@ module.exports = [
+   'https://balance-staging.mercury.basicattentiontoken.org/',
+   'https://publishers.basicattentiontoken.org/',
+   'https://publishers-staging.basicattentiontoken.org/',
+-  'https://updates.bravesoftware.com/', // remove this once updates are moved to the prod environment
+-  'https://ads-serve.bravesoftware.com/', // remove this once ads catalog moves to using prod
+-  'https://pdfjs.robwu.nl/logpdfjs', // allowed because it gets canceled in tracking protection
++  'https://updates.bravesoftware.com/',
+   'https://publishers-distro.basicattentiontoken.org/',
+   'https://publishers-staging-distro.basicattentiontoken.org/',
+   'https://p3a.brave.com/',",what's the prod url for this? just curious. @amirsaber,If this is no longer used can we remove it?
+357,"@@ -153,6 +153,12 @@ public class Constants {
+   // Overridable plugin load properties
+   public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = ""azkaban.plugin.load.override.props"";
+
++  // Append JVM args to job commands
++  public static final String AZ_JOB_COMMAND_ARGS = ""azkaban.jvm.cmd.args"";
++
++  // Ignore the above JVM args for jobtypes which have this true.
++  public static final String AZ_JOB_IGNORE_JVM_ARGS = ""ignore.jvm.args"";
++
+   /**
+    * File containing param override configs
+    * For a directory structure, property files in Proj_Dir used to have lower precedence than A.",Can you please change this to azkaban.jobs.java.opts?,I can't find where this is being used.
+358,"@@ -66,11 +66,10 @@ function AcquisitionPieChart( { data, args, source } ) {
+
+ 	let sourceMessage = '';
+ 	if ( source ) {
+-		sourceMessage = sprintf(
+-			/* translators: %1$s: URL to Analytics Module page in Site Kit Admin, %2$s: Analytics (Service Name) */
+-			__( 'Source: <a class=""googlesitekit-cta-link googlesitekit-cta-link--external googlesitekit-cta-link--inherit"" href=""%1$s"">%2$s</a>', 'google-site-kit' ),
++		sourceMessage = __( 'Source:', 'google-site-kit' ) + sprintf(
++			' <a class=""googlesitekit-cta-link googlesitekit-cta-link--external googlesitekit-cta-link--inherit"" href=""%1$s"">%2$s</a>',
+ 			getSiteKitAdminURL( 'googlesitekit-module-analytics' ),
+-			_x( 'Analytics', 'Service name', 'google-site-kit' ),
++			_x( 'Analytics', 'Service name', 'google-site-kit' )
+ 		);
+ 	}
+ ","Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component.",Should this be a single line string?
+359,"@@ -26,12 +26,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Infrastructure
+ #endif
+         }
+
+-        public static Task<int> GetCancelledZeroTask()
++        public static Task<int> GetCancelledZeroTask(CancellationToken cancellationToken = default(CancellationToken))
+         {
+-            // Task<int>.FromCanceled doesn't return Task<int>
++#if NETSTANDARD1_3
++            return Task.FromCanceled<int>(cancellationToken);
++#else
+             var tcs = new TaskCompletionSource<int>();
+             tcs.TrySetCanceled();
+             return tcs.Task;
++#endif
+         }
+     }
+ }",I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`.,If this only needs to be used in `TaskCompl
+360,"@@ -295,9 +295,13 @@ void BestPractices::PreCallRecordDestroyImage(VkDevice device, VkImage image, co
+ }
+
+ void BestPractices::PreCallRecordDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks* pAllocator) {
+-    SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
+-    for (auto& image : chain->images) {
+-        ReleaseImageUsageState(image.image_state->image());
++    if (VK_NULL_HANDLE != swapchain) {
++        SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
++        for (auto& image : chain->images) {
++            if (image.image_state) {
++                ReleaseImageUsageState(image.image_state->image());
++            }
++        }
+     }
+     ValidationStateTracker::PreCallRecordDestroySwapchainKHR(device, swapchain, pAllocator);
+ }","Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious.",ReleaseImageUsageState only if VK_NULL_HANDLE != swapchain
+361,"@@ -1131,9 +1131,10 @@ bool nano::wallet::change_sync (nano::account const & source_a, nano::account co
+
+ void nano::wallet::change_async (nano::account const & source_a, nano::account const & representative_a, std::function<void(std::shared_ptr<nano::block>)> const & action_a, uint64_t work_a, bool generate_work_a)
+ {
+-	wallets.node.wallets.queue_wallet_action (nano::wallets::high_priority, shared_from_this (), [source_a, representative_a, action_a, work_a, generate_work_a](nano::wallet & wallet_a) {
++	wallets.node.wallets.queue_wallet_action (nano::wallets::high_priority, shared_from_this (), [this, source_a, representative_a, action_a, work_a, generate_work_a](nano::wallet & wallet_a) {
+ 		auto block (wallet_a.change_action (source_a, representative_a, work_a, generate_work_a));
+ 		action_a (block);
++		this->wallets.queue_work_regeneration (std::chrono::steady_clock::now (), block);
+ 	});
+ }
+ ","Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`",What is this `std::chrono::steady_clock::now()` used for?
+362,"@@ -55,7 +55,8 @@ module.exports = iterateJsdoc(
+ 		) {
+ 			context.report( {
+ 				data: { name: jsdocNode.name },
+-				message: `The first word in a function's description should be a third-person verb (eg ""runs"" not ""run"").`,
++				message:
++					'The first word in a function\'s description should be a third-person verb (eg ""runs"" not ""run"").',
+ 				node: jsdocNode,
+ 			} );
+ 		}","And here. Please, use `'` for apostrophes in changed strings in this file.",Nit: single-quotes instead of double-quotes
+363,"@@ -100,7 +100,7 @@ func (gs *GasStation) EstimateGasForAction(actPb *iotextypes.Action) (uint64, er
+ 		if err != nil {
+ 			return 0, err
+ 		}
+-		_, receipt, err := gs.bc.ExecuteContractRead(callerAddr, sc)
++		_, receipt, err := gs.bc.SimulateExecution(callerAddr, sc)
+ 		if err != nil {
+ 			return 0, err
+ 		}",assignments should only be cuddled with other assignments (from `wsl`),there are two places in the code where we execute a `Execu
+364,"@@ -504,7 +504,15 @@ func (c *ConfigLocal) MetadataVersion() MetadataVer {
+
+ // DataVersion implements the Config interface for ConfigLocal.
+ func (c *ConfigLocal) DataVersion() DataVer {
+-	return 1
++	return FilesWithHolesDataVer
++}
++
++// DefaultNewBlockDataVersion returns the default data version for new blocks.
++func DefaultNewBlockDataVersion(c Config, holes bool) DataVer {
++	if holes {
++		return FilesWithHolesDataVer
++	}
++	return FirstValidDataVer
+ }
+
+ // DoBackgroundFlushes implements the Config interface for ConfigLocal.",Please move this to `block_types.go`.,Why do we need this method? It seems like we can just use `FirstValidDataVer` directly?
+365,"@@ -40,9 +40,6 @@ namespace NLog.Layouts
+     /// JSON attribute.
+     /// </summary>
+     [NLogConfigurationItem]
+-    [ThreadAgnostic]
+-    [ThreadSafe]
+-    [AppDomainFixedOutput]
+     public class JsonAttribute
+     {
+         /// <summary>",So this is not needed anymore for all attributes?,We need to remove `ThreadAgnostic`. `JsonAttribute` is used for dynamic serialization.
+366,"@@ -46,13 +46,13 @@ namespace OpenTelemetry.Extensions.Hosting.Implementation
+             }
+         }
+
+-        [Event(1, Message = ""Failed to initialize: '{0}'. OpenTelemetry will not work."", Level = EventLevel.Error)]
++        [Event(1, Message = ""An exception occured while adding OpenTelemetry Tracing to ServiceCollection. OpenTelemetry tracing will not work. Exception: '{0}'."", Level = EventLevel.Error)]
+         public void FailedInitialize(string exception)
+         {
+             this.WriteEvent(1, exception);
+         }
+
+-        [Event(2, Message = ""Failed to get OpenTelemetrySDK: '{0}'. OpenTelemetry will not work."", Level = EventLevel.Error)]
++        [Event(2, Message = ""An exception occured while retrieving OpenTelemetry Tracer from Service Provider. OpenTelemetry tracing will not work. Exception: '{0}'."", Level = EventLevel.Error)]
+         public void FailedOpenTelemetrySDK(string exception)
+         {
+             this.WriteEvent(2, exception);",Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work.,Do we want to specify that the exception occured while retrieving OpenTelemetry Tracer
+367,"@@ -108,6 +108,11 @@ def start_acm(port=None, asynchronous=False):
+     return start_moto_server('acm', port, name='ACM', asynchronous=asynchronous)
+
+
++def start_ses(port=None, asynchronous=False, update_listener=None):
++    port = port or config.PORT_SES
++    return start_moto_server('ses', port, name='SES', asynchronous=asynchronous, update_listener=update_listener)
++
++
+ # TODO move to es_starter.py?
+ def start_elasticsearch_service(port=None, asynchronous=False):
+     port = port or config.PORT_ES","I think we can remove this function, right? (duplicate with `ses_starter.py`)","E302 expected 2 blank lines, found 1"
+368,"@@ -195,6 +195,10 @@ class PandasLikeSeries(_Frame):
+                     ""Field {} not found, possible values are {}"".format(name, "", "".join(fnames)))
+             return anchor_wrap(self, self._spark_getField(name))
+
++    # TODO: automate the process here
++    def alias(self, name):
++        return self.rename(name)
++
+     @property
+     def schema(self):
+         if not hasattr(self, '_pandas_schema') or self._pandas_schema is None:","With this fix, I am not even sure we need to overwrite this function.",What is the purpose of this?
+369,"@@ -311,6 +311,8 @@ class PackageEntry(object):
+ class Package(object):
+     """""" In-memory representation of a package """"""
+
++    use_tqdm = os.getenv('QUILT_USE_TQDM').lower() == 'true'
++
+     def __init__(self):
+         self._children = {}
+         self._meta = {'version': 'v0'}",Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR.,Don't need the lower() here.
+370,"@@ -99,7 +99,7 @@ module Beaker
+       it ""can correctly combine arguments from different sources"" do
+         FakeFS.deactivate!
+         args = [""-h"", hosts_path, ""--debug"", ""--type"", ""git"", ""--install"", ""PUPPET/1.0,HIERA/hello""]
+-        expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>""git"", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>""/opt/enterprise/dists"", :pe_version_file=>""LATEST"", :pe_version_file_win=>""LATEST-win"", :dot_fog=>""#{home}/.fog"", :ec2_yaml=>""config/image_templates/ec2.yaml"", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[""publickey""], :port=>22, :forward_agent=>true, :keys=>[""#{home}/.ssh/id_rsa""], :user_known_hosts_file=>""#{home}/.ssh/known_hosts""}, :install=>[""git://github.com/puppetlabs/puppet.git#1.0"", ""git://github.com/puppetlabs/hiera.git#hello""], :HOSTS=>{:""pe-ubuntu-lucid""=>{:roles=>[""agent"", ""dashboard"", ""database"", ""master""], :vmname=>""pe-ubuntu-lucid"", :platform=>""ubuntu-10.04-i386"", :snapshot=>""clean-w-keys"", :hypervisor=>""fusion""}, :""pe-centos6""=>{:roles=>[""agent""], :vmname=>""pe-centos6"", :platform=>""el-6-i386"", :hypervisor=>""fusion"", :snapshot=>""clean-w-keys""}}, :nfs_server=>""none"", :puppet_ver=>nil, :facter_ver=>nil, :hiera_ver=>nil, :hiera_puppet_ver=>nil, :helper=>[], :load_path=>[], :tests=>[], :pre_suite=>[], :post_suite=>[], :modules=>[]}
++        expect(parser.parse_args(args)).to be === {:hosts_file=>""/Users/anode/beaker/spec/beaker/options/data/hosts.cfg"", :options_file=>nil, :type=>""git"", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>""/opt/enterprise/dists"", :pe_version_file=>""LATEST"", :pe_version_file_win=>""LATEST-win"", :dot_fog=>""/Users/anode/.fog"", :ec2_yaml=>""config/image_templates/ec2.yaml"", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[""publickey""], :port=>22, :forward_agent=>true, :keys=>[""/Users/anode/.ssh/id_rsa""], :user_known_hosts_file=>""/Users/anode/.ssh/known_hosts""}, :install=>[""git://github.com/puppetlabs/puppet.git#1.0"", ""git://github.com/puppetlabs/hiera.git#hello""], :HOSTS=>{:""pe-ubuntu-lucid""=>{:roles=>[""agent"", ""dashboard"", ""database"", ""master""], :vmname=>""pe-ubuntu-lucid"", :platform=>""ubuntu-10.04-i386"", :snapshot=>""clean-w-keys"", :hypervisor=>""fusion""}, :""pe-centos6""=>{:roles=>[""agent""], :vmname=>""pe-centos6"", :platform=>""el-6-i386"", :hypervisor=>""fusion"", :snapshot=>""clean-w-keys""}}, :nfs_server=>""none"", :helper=>[], :load_path=>[], :tests=>[], :pre_suite=>[], :post_suite=>[], :modules=>[]}
+       end
+
+       it ""ensures that file-mode is one of fast/stop"" do",You've got an absolute path here referencing your home dir :-).,Layout/SpaceBeforeBlockBrace
+371,"@@ -526,10 +526,10 @@ public final class JavaParserMetaModel {
+         unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.expressionPropertyMetaModel);
+         unaryExprMetaModel.operatorPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""operator"", com.github.javaparser.ast.expr.UnaryExpr.Operator.class, Optional.empty(), false, false, false, false, false);
+         unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.operatorPropertyMetaModel);
+-        unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""prefix"", boolean.class, Optional.empty(), false, true, false, false, false);
+-        unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.prefixPropertyMetaModel);
+         unaryExprMetaModel.postfixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""postfix"", boolean.class, Optional.empty(), false, true, false, false, false);
+         unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.postfixPropertyMetaModel);
++        unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""prefix"", boolean.class, Optional.empty(), false, true, false, false, false);
++        unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.prefixPropertyMetaModel);
+         variableDeclarationExprMetaModel.annotationsPropertyMetaModel = new PropertyMetaModel(variableDeclarationExprMetaModel, ""annotations"", com.github.javaparser.ast.expr.AnnotationExpr.class, Optional.of(annotationExprMetaModel), false, false, true, false, false);
+         variableDeclarationExprMetaModel.getDeclaredPropertyMetaModels().add(variableDeclarationExprMetaModel.annotationsPropertyMetaModel);
+         variableDeclarationExprMetaModel.modifiersPropertyMetaModel = new PropertyMetaModel(variableDeclarationExprMetaModel, ""modifiers"", com.github.javaparser.ast.Modifier.class, Optional.empty(), false, false, false, true, false);",Maybe I should do some sorting so that these properties don't keep moving around...,what is the purpose of this
+372,"@@ -32,14 +32,6 @@ func TestCheckMountDestFalsePositive(t *testing.T) {
+ 	}
+ }
+
+-func TestCheckMountRoot(t *testing.T) {
+-	dest := ""/rootfs""
+-	err := checkMountDestination(""/rootfs"", dest)
+-	if err == nil {
+-		t.Fatal(err)
+-	}
+-}
+-
+ func TestNeedsSetupDev(t *testing.T) {
+ 	config := &configs.Config{
+ 		Mounts: []*configs.Mount{","Can we keep this test anyway, as it's part of the spec?",Could you please explain why this is removed?
+373,"@@ -0,0 +1,19 @@
++<?php
++
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See license.txt for license details.
++ */
++
++declare(strict_types = 1);
++
++namespace Ergonode\Mailer;
++
++use Ergonode\Mailer\Application\DependencyInjection\CompilerPass\MailerStrategyInterfaceCompilerPass;
++use Ergonode\SharedKernel\Application\AbstractModule;
++
++/**
++ */
++class ErgonodeMailerBundle extends AbstractModule
++{
++}",Can be removed,Shouldn't this file be named `ergonode.php`?
+374,"@@ -1,5 +1,7 @@
+ <?php namespace System\Controllers;
+
++use Config;
++use Request;
+ use Lang;
+ use Flash;
+ use Backend;","It's a minor quibble I know, but I like having the imports ordered by lengt",Please remove this empty line.
+375,"@@ -216,7 +216,7 @@ public abstract class AbstractRestInvocation {
+       }
+     }
+     responseEx.setStatus(response.getStatusCode(), response.getReasonPhrase());
+-    responseEx.setContentType(produceProcessor.getName());
++    responseEx.setContentType(produceProcessor.getName()+""; charset=utf-8"");
+
+     Object body = response.getResult();
+     if (response.isFailed()) {",It's better to get the charset from context or other setting to let the user override it.,Doesn't this change the content type of the r
+376,"@@ -70,7 +70,7 @@ func NewCStorPoolController(
+ 	cStorInformerFactory informers.SharedInformerFactory) *CStorPoolController {
+
+ 	// obtain references to shared index informers for the cStorPool resources
+-	cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().NewTestCStorPools()
++	cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().CStorPoolInstances()
+
+ 	zpool.KubeClient = kubeclientset
+ 	zpool.OpenEBSClient = clientset",this filename as well needs change,This doesn't seem related to the rest of the PR?
+377,"@@ -179,10 +179,11 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
+ // ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
+ // configuration for AWS
+ type ACMEIssuerDNS01ProviderRoute53 struct {
+-	AccessKeyID     string            `json:""accessKeyID""`
+-	SecretAccessKey SecretKeySelector `json:""secretAccessKeySecretRef""`
+-	HostedZoneID    string            `json:""hostedZoneID""`
+-	Region          string            `json:""region""`
++	AccessKeyID        string            `json:""accessKeyID,omitempty""`
++	AccessKeyIDRef     SecretKeySelector `json:""accessKeyIDSecretRef,omitempty""`
++	SecretAccessKeyRef SecretKeySelector `json:""secretAccessKeySecretRef""`
++	HostedZoneID       string            `json:""hostedZoneID""`
++	Region             string            `json:""region""`
+ }
+
+ // ACMEIssuerDNS01ProviderAzureDNS is a structure containing the",I think we want to remove `omitempty` here,Does the `omitempty` do anything here?
+378,"@@ -129,6 +129,8 @@ func startContainer(context *cli.Context, spec *specs.LinuxSpec) (int, error) {
+ 	if err != nil {
+ 		return -1, err
+ 	}
++	handler := newSignalHandler(tty)
++	defer handler.Close()
+ 	if err := container.Start(process); err != nil {
+ 		return -1, err
+ 	}",You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start,I'm not sure if this is the right place for this
+379,"@@ -376,8 +376,7 @@ lookupTables.role = {
+ 			one: ['rowgroup', 'row']
+ 		},
+ 		nameFrom: ['author'],
+-		context: null,
+-		implicit: ['table']
++		context: null
+ 	},
+ 	'gridcell': {
+ 		type: 'widget',",I updated only the implicit roles who needed a update for this new rule to validate.,does this mean that there is no context for a ta
+380,"@@ -7,11 +7,12 @@
+ package pb
+
+ import (
++	reflect ""reflect""
++	sync ""sync""
++
+ 	proto ""github.com/golang/protobuf/proto""
+ 	protoreflect ""google.golang.org/protobuf/reflect/protoreflect""
+ 	protoimpl ""google.golang.org/protobuf/runtime/protoimpl""
+-	reflect ""reflect""
+-	sync ""sync""
+ )
+
+ const (",> // Code generated by protoc-gen-go. DO NOT EDIT.,These changes don't seem necessary.
+381,"@@ -46,6 +46,9 @@ var (
+ 		utils.GcloudProdWrapperLatest:   ""gcloud"",
+ 		utils.GcloudLatestWrapperLatest: ""gcloud"",
+ 	}
++	// Apply this as instance metadata if the OS config agent is not
++	// supported for the platform or version being imported.
++	skipOSConfig = map[string]string{""osconfig_not_supported"": ""true""}
+ )
+
+ type ovfInstanceImportTestProperties struct {","minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean",I think we can remove the `osconfig
+382,"@@ -56,7 +56,9 @@ public class NSRSS20 extends Namespace {
+ 			boolean validType = false;
+ 			boolean validUrl = !TextUtils.isEmpty(url);
+
+-			if (type == null) {
++			if(SyndTypeUtils.enclosureTypeValid(type)) {
++				validType = true;
++			} else {
+ 				type = SyndTypeUtils.getMimeTypeFromUrl(url);
+ 			}
+ ","~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for ""fixing"" this!",This can be simplified to `return S
+383,"@@ -239,3 +239,16 @@ func (client *Client) Stop() error {
+
+ 	return nil
+ }
++
++// GetSessions returns all sessions from history
++func (client *Client) GetSessions() (endpoints.SessionsDTO, error) {
++	response, err := client.http.Get(""sessions"", url.Values{})
++	if err != nil {
++		return endpoints.SessionsDTO{}, err
++	}
++	defer response.Body.Close()
++
++	var sessions endpoints.SessionsDTO
++	err = parseResponseJSON(response, &sessions)
++	return sessions, err
++}",`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler.,do we need to close the response?
+384,"@@ -5242,8 +5242,11 @@ master_signal_handler_C(byte *xsp)
+
+     /* Ensure we didn't get the app's sigstack into our frame.  On Mac, the kernel
+      * doesn't use the frame's uc_stack, so we limit this to Linux.
++     * The pointers may be different if a thread is on its way to exit, and the app's
++     * sigstack was already restored (i#3369).
+      */
+-    IF_LINUX(ASSERT(dcontext == NULL || dcontext == GLOBAL_DCONTEXT ||
++    IF_LINUX(ASSERT(dcontext == NULL || dcontext->is_exiting ||
++                    dcontext == GLOBAL_DCONTEXT ||
+                     frame->uc.uc_stack.ss_sp ==
+                         ((thread_sig_info_t *)dcontext->signal_field)->sigstack.ss_sp));
+ ",These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1),(style) line over 80 characters
+385,"@@ -24,7 +24,8 @@ namespace Http2SampleApp
+                     factory.SetMinimumLevel(LogLevel.Trace);
+                     factory.AddConsole();
+                 })
+-                .UseKestrel((context, options) =>
++                .UseKestrel()
++                .ConfigureKestrel((context, options) =>
+                 {
+                     var basePort = context.Configuration.GetValue<int?>(""BASE_PORT"") ?? 5000;
+ ",Why not change the other samples?,I think you can remove `UseKest
+386,"@@ -10,8 +10,9 @@ table.isHeader = function (cell) {
+ 		return true;
+ 	}
+
+-	if (cell.id) {
+-		return !!document.querySelector('[headers~=""' + axe.utils.escapeSelector(cell.id) + '""]');
++	if (cell.getAttribute('id')) {
++    const id = axe.utils.escapeSelector(cell.getAttribute('id'));
++		return !!document.querySelector(`[headers~=""${id}""]`);
+ 	}
+
+ 	return false;","Indentation is mixed up here due to spaces/tabs, I'm guessing.",I am a bit concerned about this
+387,"@@ -738,9 +738,15 @@ static fpga_result poll_interrupt(fpga_dma_handle dma_h) {
+ 		res = FPGA_EXCEPTION;
+ 	} else {
+ 		uint64_t count = 0;
+-		read(pfd.fd, &count, sizeof(count));
+-		debug_print(""Poll success. Return = %d, count = %d\n"",poll_res, (int)count);
+-		res = FPGA_OK;
++		ssize_t bytes_read = read(pfd.fd, &count, sizeof(count));
++		if(bytes_read <= 0) {
++			fprintf( stderr, ""Error: %s\n"",
++				bytes_read < 0 ? strerror(errno) : ""zero bytes read"");
++			res = FPGA_EXCEPTION;
++		} else {
++			debug_print(""Poll success. Return = %d, count = %d\n"",poll_res, (int)count);
++			res = FPGA_OK;
++		}
+ 	}
+
+ out:",Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?,You can use `strerror()` which
+388,"@@ -138,7 +138,10 @@ class PluginBase extends ServiceProviderBase
+      */
+     public function registerSettings()
+     {
+-        return [];
++		$configuration = $this->getConfigurationFromYaml();
++		if (array_key_exists('settings', $configuration)) {
++			return $configuration['settings'];
++		}
+     }
+
+     /**","Project standard is spaces, not tabs. Please fix and then we can merge this.",Wouldn't it be better to throw an error when the settings are not found?
+389,"@@ -1,12 +1,14 @@
+ #include ""dynamic_zone.h""
+-#include ""expedition.h""
+-#include ""expedition_state.h""
++#include ""cliententry.h""
++#include ""clientlist.h""
++#include ""dynamic_zone_manager.h""
+ #include ""worlddb.h""
+ #include ""zonelist.h""
+ #include ""zoneserver.h""
+ #include ""../common/eqemu_logsys.h""
+ #include ""../common/repositories/instance_list_repository.h""
+
++extern ClientList client_list;
+ extern ZSList zoneserver_list;
+
+ Database& DynamicZone::GetDatabase()",@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here,Is `client_list` used anywhere?
+390,"@@ -226,11 +226,11 @@ public class ManifestReader extends CloseableGroup implements Filterable<Filtere
+
+   @Override
+   public Iterator<DataFile> iterator() {
+-    return iterator(alwaysTrue(), fileSchema);
++    return iterator(fileSchema);
+   }
+
+   // visible for use by PartialManifest
+-  Iterator<DataFile> iterator(Expression partFilter, Schema fileProjection) {
++  Iterator<DataFile> iterator(Schema fileProjection) {
+     return Iterables.transform(Iterables.filter(
+         entries(fileProjection),
+         entry -> entry.status() != ManifestEntry.Status.DELETED),",The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there.,did you mean to remove that `alwaysTrue()` call?
+391,"@@ -24,7 +24,15 @@ module Mongoid
+             # @since 1.0.0
+             def evolve(object)
+               __evolve__(object) do |obj|
+-                obj ? obj.to_s : obj
++                if obj
++                  if obj.is_a?(::BigDecimal) && Mongoid.map_big_decimal_to_decimal128
++                    BSON::Decimal128.new(obj)
++                  elsif obj.is_a?(BSON::Decimal128) && Mongoid.map_big_decimal_to_decimal128
++                    obj
++                  else
++                    obj.to_s
++                  end
++                end
+               end
+             end
+           end",I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option.,Should this be `BSON::Decimal128.new(obj)`?
+392,"@@ -1,6 +1,7 @@
+ # frozen_string_literal: true
+
+ require 'bolt/application'
++require 'bolt/plan_creator'
+
+ require 'bolt_spec/files'
+ ",We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded.,can we remove this?
+393,"@@ -34,7 +34,10 @@ namespace Benchmarks
+
+         private static IConfig GetConfig(Options options)
+         {
+-            var baseJob = Job.ShortRun; // let's use the Short Run for better first user experience ;)
++            var baseJob = Job.Default
++                .WithWarmupCount(1) // 1 warmup is enough for our purpose
++                .WithMaxTargetIterationCount(20);  // we don't want to run more that 20 iterations
++
+             var jobs = GetJobs(options, baseJob).ToArray();
+
+             var config = DefaultConfig.Instance",">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default.",What is 20 here? Sh
+394,"@@ -47,7 +47,7 @@ class Service(object):
+         self.start_error_message = start_error_message
+         self.log_file = log_file
+         self.env = env or os.environ
+-
++
+     @property
+     def service_url(self):
+         """"""",can just remove it ?,no need for trailin
+395,"@@ -654,7 +654,17 @@ func MigrateRepository(u *User, opts MigrateRepoOptions) (*Repository, error) {
+ 		return repo, UpdateRepository(repo, false)
+ 	}
+
+-	if err = createUpdateHook(repoPath); err != nil {
++	repo, err = FinishMigrateRepository(repo, repoPath)
++	if err != nil {
++		return repo, err
++	}
++
++	return repo, UpdateRepository(repo, false)
++}
++
++// Finish migrating repository with things that don't need to be done for mirrors.
++func FinishMigrateRepository(repo *Repository, repoPath string) (*Repository, error) {
++	if err := createUpdateHook(repoPath); err != nil {
+ 		return repo, fmt.Errorf(""createUpdateHook: %v"", err)
+ 	}
+ ",Better call it `CleanUpMirrorInfo`?,Temporary solution
+396,"@@ -405,6 +405,19 @@ func (node *Node) SetupMining(ctx context.Context) error {
+ 		}
+ 	}
+
++	if err := node.StorageMining.Start(ctx); err != nil {
++		fmt.Printf(""error starting storage miner: %s\n"", err)
++	}
++
++	if err := node.StorageProtocol.StorageProvider.Start(ctx); err != nil {
++		fmt.Printf(""error starting storage provider: %s\n"", err)
++	}
++
++	// TODO: Retrieval Market Integration
++	//if err := node.RetrievalProtocol.RetrievalProvider.Start(); err != nil {
++	//	fmt.Printf(""error starting retrieval provider: %s\n"", err)
++	//}
++
+ 	return nil
+ }
+ ",@shannonwells is there still something missing here?,why don't we just stop the node here?
+397,"@@ -149,6 +149,9 @@ MESSAGE
+       # don't accidentally leave the seed encoded.
+       define_reader :seed
+
++      # Time limit for stress testing, if any (default: nil).
++      add_setting :stress_test
++
+       # When a block passed to pending fails (as expected), display the failure
+       # without reporting it as a failure (default: false).
+       add_setting :show_failures_in_pending_blocks",This could be more indicative of what it is... e.g... `stresstest_time_limit`,I think this would be a good place to
+398,"@@ -279,7 +279,6 @@ bool PDPSimple::createPDPEndpoints()
+         delete mp_listener;
+         mp_listener = nullptr;
+         reader_payload_pool_->release_history(reader_pool_cfg, true);
+-        TopicPayloadPoolRegistry::release(reader_payload_pool_);
+         return false;
+     }
+ ",Shouldn't we do a `reader_payload_pool_.reset()` here?,Is this related?
+399,"@@ -33,9 +33,9 @@ type Block struct {
+ 	// ElectionProof is the vrf proof giving this block's miner authoring rights
+ 	ElectionProof *crypto.ElectionProof
+
+-	// DrandEntries contain the verifiable oracle randomness used to elect
++	// BeaconEntries contain the verifiable oracle randomness used to elect
+ 	// this block's author leader
+-	DrandEntries []*drand.Entry
++	BeaconEntries []*drand.Entry
+
+ 	// PoStProofs are the winning post proofs
+ 	PoStProofs []PoStProof `json:""PoStProofs""`",I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change.,Could we call this `BeaconEntries`?
+400,"@@ -853,6 +853,11 @@ class DynamicMap(HoloMap):
+                 unbounded_dims.append(str(kdim))
+         return unbounded_dims
+
++    @property
++    def current_key(self):
++        """"""Returns the current key value.""""""
++        return getattr(self, '_current_key', None)
++
+     def _stream_parameters(self):
+         return util.stream_parameters(
+             self.streams, no_duplicates=not self.positional_stream_args",I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here.,"why not just `getattr(self, '_current_key', None)`?"
+401,"@@ -22,8 +22,14 @@ const FromCSVKind = ""fromCSV""
+ type FromCSVOpSpec struct {
+ 	CSV  string `json:""csv""`
+ 	File string `json:""file""`
++	Mode string `json:""mode""`
+ }
+
++const (
++	annotationMode = ""annotations""
++	rawMode        = ""raw""
++)
++
+ func init() {
+ 	fromCSVSignature := runtime.MustLookupBuiltinType(""csv"", ""from"")
+ 	runtime.RegisterPackageValue(""csv"", ""from"", flux.MustValue(flux.FunctionValue(FromCSVKind, createFromCSVOpSpec, fromCSVSignature)))",I guess I like the name `mode` okay. I can't think of anything better.,Can this be in the `flux` package?
+402,"@@ -69,8 +69,12 @@ type Step struct {
+ 	testType stepImpl
+ }
+
+-// NewStep creates a Step with given name and timeout  with the specified workflow
++// NewStep creates a Step with given name and timeout  with the specified workflow.
++// If timeout is less or equal to zero, defaultTimeout from the workflow will be used
+ func NewStep(name string, w *Workflow, timeout time.Duration) *Step {
++	if timeout <= 0 {
++		return &Step{name: name, w: w, Timeout: w.DefaultTimeout}
++	}
+ 	return &Step{name: name, w: w, timeout: timeout}
+ }
+ ",I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic,Should we check if the timeout is > 0 here?
+403,"@@ -71,6 +71,7 @@ func Register(r *gin.RouterGroup, s *Service) {
+ // @Param experimentNamespace query string false ""The namespace of the experiment""
+ // @Param uid query string false ""The UID of the experiment""
+ // @Param kind query string false ""kind"" Enums(PodChaos, IoChaos, NetworkChaos, TimeChaos, KernelChaos, StressChaos)
++// @Param limit query string false ""The max length of events list""
+ // @Success 200 {array} core.Event
+ // @Router /api/events [get]
+ // @Failure 500 {object} utils.APIError",Are these limit changes related?,suggest to change to `The maximum size of events li
+404,"@@ -18,12 +18,12 @@ Routing and network interface handling for IPv6.
+
+ from __future__ import absolute_import
+ import socket
++import scapy.consts
+ from scapy.config import conf
+ from scapy.utils6 import *
+ from scapy.arch import *
+ from scapy.pton_ntop import *
+ from scapy.error import warning, log_loading
+-from scapy.consts import LOOPBACK_INTERFACE
+ import scapy.modules.six as six
+
+ ",Don't you mean `import scapy.consts`?,Looks like this import is no longer used.
+405,"@@ -62,3 +62,7 @@ func (e *Executor) ensurePrimaryUpdate(ctx context.Context) model.StageStatus {
+ 	e.LogPersister.AppendSuccess(fmt.Sprintf(""Successfully applied %d primary resources"", len(manifests)))
+ 	return model.StageStatus_STAGE_SUCCESS
+ }
++
++func (e *Executor) rollbackPrimary(ctx context.Context) model.StageStatus {
++	return model.StageStatus_STAGE_SUCCESS
++}",`ctx` is unused in rollbackPrimary,This feels a little bit redundant with th
+406,"@@ -40,7 +40,7 @@ const (
+ 	// BufferedEventID is the id of the buffered event
+ 	BufferedEventID int64 = -123
+ 	// EmptyEventTaskID is uninitialized id of the task id within event
+-	EmptyEventTaskID int64 = -1234
++	EmptyEventTaskID int64 = 0
+ 	// TransientEventID is the id of the transient event
+ 	TransientEventID int64 = -124
+ 	// FirstBlobPageToken is the page token identifying the first blob for each history archival",This is not what title says.,Is this change intentional?
+407,"@@ -0,0 +1,19 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.autofix;
++
++import net.sourceforge.pmd.lang.ast.Node;
++
++/**
++ * Classes of this interface must be used when it is desired to make one or more operations to the AST.
++ */
++public interface RuleViolationFix {
++
++    /**
++     * Apply one or more operations to a node.
++     * @param node the node in the AST on which to apply operations
++     */
++    void applyFixesToNode(Node node);
++}",a fix applies several fixes? maybe this should simply be `applyToNode`,Why do we need this interface? It seems t
+408,"@@ -25,11 +25,12 @@ import (
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+
++// fakeGetClientset gets the cvr clientset
+ func fakeGetClientset() (clientset *clientset.Clientset, err error) {
+ 	return &client.Clientset{}, nil
+ }
+
+-func fakeListfn(cli *clientset.Clientset, namespace string, opts metav1.ListOptions) (*apis.CStorVolumeReplicaList, error) {
++func fakeListOk(cli *clientset.Clientset, namespace string, opts metav1.ListOptions) (*apis.CStorVolumeReplicaList, error) {
+ 	return &apis.CStorVolumeReplicaList{}, nil
+ }
+ ",U1000: func `fakeGetOk` is unused (from `unused`),why was this changed?
+409,"@@ -18,6 +18,8 @@ import (
+ 	""errors""
+ 	""fmt""
+
++	""k8s.io/client-go/util/retry""
++
+ 	""github.com/hashicorp/go-multierror""
+ 	""golang.org/x/sync/errgroup""
+ 	v1 ""k8s.io/api/core/v1""","Because there is a ""k8s.io/client-go/tools/cache"" below, we can sort out all the ""imports"" here.",nit: move down
+410,"@@ -3,7 +3,9 @@
+ package api
+
+ import (
++	""github.com/aws/aws-sdk-go/aws""
+ 	""fmt""
++	""encoding/json""
+ 	""reflect""
+ 	""sort""
+ 	""strings""","Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports.",please sort this new
+411,"@@ -118,8 +118,10 @@ func (o *deletePipelineOpts) Ask() error {
+
+ // Execute deletes the secret and pipeline stack.
+ func (o *deletePipelineOpts) Execute() error {
+-	if err := o.deleteSecret(); err != nil {
+-		return err
++	if o.PipelineSecret != """" {
++		if err := o.deleteSecret(); err != nil {
++			return err
++		}
+ 	}
+
+ 	if err := o.deleteStack(); err != nil {",Do we not have tests for pipeline delete  ,What happens if the s
+412,"@@ -146,6 +146,12 @@ class HdfsClient(hdfs_abstract_client.HdfsFileSystem):
+     def put(self, local_path, destination):
+         self.call_check(load_hadoop_cmd() + ['fs', '-put', local_path, destination])
+
++    def append(self, local_path, destination):
++        """"""
++        Requires Hadoop >= 2.3.0
++        """"""
++        call_check(load_hadoop_cmd() + ['fs', '-appendToFile', local_path, destination])
++
+     def get(self, path, local_destination):
+         self.call_check(load_hadoop_cmd() + ['fs', '-get', path, local_destination])
+ ",Good that you mention this constraint in the docstring :),You should be able to use `self.call_check` directly.
+413,"@@ -15,8 +15,13 @@ package workflow
+
+ import (
+ 	""encoding/json""
++	""fmt""
+ 	""net/http""
+
++	ctrl ""sigs.k8s.io/controller-runtime""
++
++	apierrors ""k8s.io/apimachinery/pkg/api/errors""
++
+ 	""github.com/gin-gonic/gin""
+
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""",remove this blank?,You don't seem to be using this anywhere.
+414,"@@ -9515,7 +9515,8 @@ FileScan::FileScan(const CorrName& tableName,
+      estRowsAccessed_ (0),
+      mdamFlag_(UNDECIDED),
+      skipRowsToPreventHalloween_(FALSE),
+-     doUseSearchKey_(TRUE)
++     doUseSearchKey_(TRUE),
++     computedNumOfActivePartiions_(-1)
+ {
+   // Set the filescan properties:
+ ","Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those.",Is there a reason you're not just setting this to `0`
+415,"@@ -22,9 +22,11 @@
+ import shlex
+
+ from PyQt5.QtCore import (pyqtSlot, pyqtSignal, QObject, QProcess,
+-                          QProcessEnvironment)
++                          QProcessEnvironment, QUrl)
+
+-from qutebrowser.utils import message, log
++from qutebrowser.utils import message, log, objreg
++
++from qutebrowser.browser import qutescheme
+
+ # A mapping of QProcess::ErrorCode's to human-readable strings.
+ ",Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports.,"QUrl is unused, right?"
+416,"@@ -45,6 +45,8 @@ var ActionCmd = &cobra.Command{
+ 	Args:  cobra.MinimumNArgs(1),
+ }
+
++var insecure bool
++
+ func init() {
+ 	ActionCmd.AddCommand(actionHashCmd)
+ 	ActionCmd.AddCommand(actionTransferCmd)",`insecure` is a global variable (from `gochecknoglobals`),Is this variable used somewhere?
+417,"@@ -479,6 +479,11 @@ func HTTPBackend(ctx *context.Context, cfg *serviceConfig) http.HandlerFunc {
+ 		for _, route := range routes {
+ 			r.URL.Path = strings.ToLower(r.URL.Path) // blue: In case some repo name has upper case name
+ 			if m := route.reg.FindStringSubmatch(r.URL.Path); m != nil {
++				if setting.Repository.DisableHttpGit {
++					w.WriteHeader(http.StatusForbidden)
++					w.Write([]byte(""Interacting with repositories by HTTP protocol is not allowed""))
++					return
++				}
+ 				if route.method != r.Method {
+ 					if r.Proto == ""HTTP/1.1"" {
+ 						w.WriteHeader(http.StatusMethodNotAllowed)",Same as above (HTTP in upper-case),We should also check for `&& r.U
+418,"@@ -206,4 +206,11 @@ class YouTubeProviderTest extends AbstractProviderTest
+         $this->assertSame(100, $properties['player_parameters']['height']);
+         $this->assertSame(100, $properties['player_parameters']['width']);
+     }
++
++    public function testGetReferenceUrl()
++    {
++        $media = new Media();
++        $media->setProviderReference('123456');
++        $this->assertEquals('http://www.youtube.com/watch?v=123456', $this->getProvider()->getReferenceUrl($media));
++    }
+ }",This is getting repetitive  maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?,what is the purpose of this test
+419,"@@ -0,0 +1,5 @@
++package reflect
++
++func MakeFunc(typ Type, fn func(args []Value) (results []Value)) Value {
++	return Value{}
++}","I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead.",The package name `mypy` doesn't
+420,"@@ -73,7 +73,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
+ 	else if (name[0]==='o' && name[1]==='n') {
+ 		let useCapture = name !== (name=name.replace(/Capture$/, ''));
+ 		let nameLower = name.toLowerCase();
+-		name = (nameLower in dom ? nameLower : name).substring(2);
++		name = (nameLower in window ? nameLower : name).substring(2);
+
+ 		if (value) {
+ 			if (!oldValue) dom.addEventListener(name, eventProxy, useCapture);",Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit,dom.addEventListener will probably fail in some cases.
+421,"@@ -224,9 +224,7 @@ func (m *ipipManager) CompleteDeferredWork() error {
+ 		for _, ip := range m.activeHostnameToIP {
+ 			members = append(members, ip)
+ 		}
+-		for _, ip := range m.externalNodeCIDRs {
+-			members = append(members, ip)
+-		}
++		members = append(members, m.externalNodeCIDRs...)
+ 		m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, members)
+ 		m.ipSetInSync = true
+ 	}",Same change just above?,shouldn't this be `m.externalNodeCIDRs[0]`?
+422,"@@ -35,7 +35,8 @@
+         // Promise() being missing on some legacy browser, and a funky one
+         // is Promise() present but buggy on WebOS 2
+         window.Promise = undefined;
+-        window.Promise = undefined;
++        /* eslint-disable-next-line no-restricted-globals -- Explicit check on self needed */
++        self.Promise = undefined;
+     }
+
+     if (!window.Promise) {",I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here.,"Instead of this, can we do `self.Promise = undefined`?"
+423,"@@ -7,13 +7,7 @@ test_name ""bolt plan run should apply manifest block on remote hosts via ssh"" do
+   extend Acceptance::BoltCommandHelper
+
+   ssh_nodes = select_hosts(roles: ['ssh'])
+-  skip_targets = select_hosts(platform: [/debian-8/])
+   targets = ""ssh_nodes""
+-  if skip_targets.any?
+-    ssh_nodes -= skip_targets
+-    targets = ssh_nodes.each_with_object([]) { |node, acc| acc.push(node[:vmhostname]) }.join("","")
+-  end
+-
+   skip_test('no applicable nodes to test on') if ssh_nodes.empty?
+
+   dir = bolt.tmpdir('apply_ssh')",Since this var is no longer defined we should remove the `if skip_targets.any?` bit below.,I removed the `skip_targets` variable because it isn't
+424,"@@ -170,6 +170,12 @@ def func_arn(function_name):
+     return aws_stack.lambda_function_arn(function_name)
+
+
++def func_qualifier(function_name, qualifier=None):
++    arn = aws_stack.lambda_function_arn(function_name)
++    if ARN_TO_LAMBDA.get(arn).qualifier_exists(qualifier):
++        return '{}:{}'.format(arn, qualifier)
++
++
+ def check_batch_size_range(source_arn, batch_size=None):
+     batch_size_entry = BATCH_SIZE_RANGES.get(source_arn.split(':')[2].lower())
+     if not batch_size_entry:",I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`).,"This function is only called in one place, can we move it to the utils file? e.g. `aws_lambda_function_arn`"
+425,"@@ -41,6 +41,11 @@ type NATProxy struct {
+
+ func (np *NATProxy) consumerHandOff(consumerPort int, remoteConn *net.UDPConn) chan struct{} {
+ 	stop := make(chan struct{})
++	if np.socketProtect == nil {
++		// shutdown pinger session since openvpn client will connect directly (without NATProxy)
++		remoteConn.Close()
++		return stop
++	}
+ 	go np.consumerProxy(consumerPort, remoteConn, stop)
+ 	return stop
+ }","Why session is started at all, if you need to shut it down e.g. DI should launch noopSession",Why not just make this a `defer`?
+426,"@@ -184,7 +184,7 @@ type describer interface {
+ }
+
+ type workspaceDeleter interface {
+-	DeleteAll() error
++	DeleteWorkspaceFile() error
+ }
+
+ type svcManifestReader interface {",nit: can we rename the interface to `wsFileDeleter`,Should this be renamed as well?
+427,"@@ -91,10 +91,10 @@ func hashRule(r *rule) string {
+ // It's the struct used by reconciler.
+ type CompletedRule struct {
+ 	*rule
+-	// Source Pods of this rule, can't coexist with ToAddresses.
+-	FromAddresses v1beta1.GroupMemberPodSet
+-	// Destination Pods of this rule, can't coexist with FromAddresses.
+-	ToAddresses v1beta1.GroupMemberPodSet
++	// Source GroupMembers of this rule, can't coexist with ToAddresses.
++	FromAddresses v1beta1.GroupMemberSet
++	// Destination GroupMembers of this rule, can't coexist with FromAddresses.
++	ToAddresses v1beta1.GroupMemberSet
+ 	// Target Pods of this rule.
+ 	Pods v1beta1.GroupMemberPodSet
+ }",Why target cannot be external endpoints?,"""coexist with"" sounds a bit redundant"
+428,"@@ -127,4 +127,8 @@ public interface CollectionAdminParams {
+
+   /** Option to follow aliases when deciding the target of a collection admin command. */
+   String FOLLOW_ALIASES = ""followAliases"";
++
++  /** Prefix for automatically created config elements. */
++  String AUTO_PREFIX = "".auto_"";
++
+ }","We use a suffix "".AUTOCREATED"" for configsets, maybe we can use the same here?",This doesn't look like it's used anywhere.
+429,"@@ -27,7 +27,7 @@ namespace Samples
+         {
+             // Enable OpenTelemetry for the source ""MyCompany.MyProduct.MyWebServer""
+             // and use Console exporter
+-            OpenTelemetrySdk.Default.EnableOpenTelemetry(
++            OpenTelemetrySdk.EnableOpenTelemetry(
+                 (builder) => builder.AddActivitySource(""MyCompany.MyProduct.MyWebServer"")
+                 .UseConsoleActivityExporter(opt => opt.DisplayAsJson = options.DisplayAsJson));
+ ",This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?,Can we leave OpenTelemetrySdk.Default as t
+430,"@@ -37,7 +37,7 @@ from logHandler import log
+ import UIAUtils
+ from comInterfaces import UIAutomationClient as UIA
+ # F403: unable to detect undefined names
+-from comInterfaces .UIAutomationClient import *  # noqa:  F403
++from comInterfaces.UIAutomationClient import *  # noqa:  F403
+ import textInfos
+ from typing import Dict
+ from queue import Queue",Why this is in the diff?,I'm guessing you didn't mean to include th
+431,"@@ -136,6 +136,8 @@ type QuiesceDriver interface {
+ type CloudBackupDriver interface {
+ 	// CloudBackupCreate uploads snapshot of a volume to the cloud
+ 	CloudBackupCreate(input *api.CloudBackupCreateRequest) error
++	// CloudBackupGroupCreate creates and then uploads volumegroup snapshots
++	CloudBackupGroupCreate(input *api.CloudBackupGroupCreateRequest) error
+ 	// CloudBackupRestore downloads a cloud backup and restores it to a volume
+ 	CloudBackupRestore(input *api.CloudBackupRestoreRequest) (*api.CloudBackupRestoreResponse, error)
+ 	// CloudBackupEnumerate enumerates the backups for a given cluster/credential/volumeID",How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?,this is probably a good opportunity to ren
+432,"@@ -232,6 +232,15 @@ export function diff(
+
+ 		if ((tmp = options.diffed)) tmp(newVNode);
+ 	} catch (e) {
++		// When we are hydrating and have excessDomChildren we don't know the _children this VNode
++		// should receive so it's safer to unmount them. Else on the subsequent error-boundary diff,
++		// we won't know the oldDom and insert an additional node instead of replace the prerendered one. (#2539)
++		if (isHydrating && excessDomChildren != null) {
++			for (tmp = excessDomChildren.length; tmp--; ) {
++				if (excessDomChildren[tmp] != null) removeNode(excessDomChildren[tmp]);
++			}
++		}
++
+ 		newVNode._original = null;
+ 		options._catchError(e, newVNode, oldVNode);
+ 	}",We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better.,nit: extra space after the period
+433,"@@ -464,7 +464,7 @@ class CombineAssets
+      */
+     protected function setHashOnCombinerFilters($hash)
+     {
+-        $allFilters = call_user_func_array('array_merge', $this->getFilters());
++        $allFilters = array_merge(...array_values($this->getFilters()));
+
+         foreach ($allFilters as $filter) {
+             if (method_exists($filter, 'setHash')) {",In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc.,`array_merge` with a single argum
+434,"@@ -82,6 +82,9 @@ func (b3 B3) Extract(ctx context.Context, supplier propagation.HTTPSupplier) con
+ 	} else {
+ 		sc = b3.extract(supplier)
+ 	}
++	if !sc.IsValid() {
++		return ctx
++	}
+ 	return ContextWithRemoteSpanContext(ctx, sc)
+ }
+ ","If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?",This would be a good use case to
+435,"@@ -56,7 +56,7 @@ return [
+         'choose_file' => 'Datei auswählen',
+         'close' => 'Schließen',
+         'create' => 'Erstellen',
+-        'create_and_add_another' => 'Erstellen und weiter hinzufügen',
++        'create_and_add_another' => 'Erstellen und weitere hinzufügen',
+         'create_and_continue' => 'Erstellen und weiter bearbeiten',
+         'save' => 'Speichern',
+         'save_and_continue' => 'Speichern und weiter bearbeiten',",I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though  ,Line is too long. [81/80]
+436,"@@ -227,3 +227,12 @@ class RecordsViewTest(BaseWebTest, unittest.TestCase):
+                      MINIMALIST_RECORD,
+                      headers=headers,
+                      status=200)
++
++    def test_records_can_be_created_after_deletion(self):
++        self.app.delete(self.record_url,
++                        headers=self.headers,
++                        status=200)
++        headers = self.headers.copy()
++        headers['If-None-Match'] = '*'
++        self.app.put_json(self.record_url, MINIMALIST_RECORD,
++                          headers=headers, status=201)",nit: 200 is superfluous,I don't think this test is really testing what we want to do here. We need to have an explicit way to modify a record.
+437,"@@ -246,7 +246,7 @@ TEST_F(SchemaTest, metaCommunication) {
+     // Test unreserved keyword
+     {
+         cpp2::ExecutionResponse resp;
+-        std::string query = ""CREATE TAG upper(name string, EMAIL string, ""
++        std::string query = ""CREATE TAG upper(name string, email string, ""
+                             ""age int, gender string, row_timestamp timestamp)"";
+         auto code = client->execute(query, resp);
+         ASSERT_EQ(cpp2::ErrorCode::SUCCEEDED, code);",This is testing `unreserved keyword`,Is this unrelated?
+438,"@@ -829,6 +829,10 @@ static const MethodMapping projectionMethodMappings[] = {
+
+     {PROJ_WKT2_NAME_METHOD_QUADRILATERALIZED_SPHERICAL_CUBE, 0,
+      ""Quadrilateralized_Spherical_Cube"", ""qsc"", nullptr, paramsNatOrigin},
++
++    {PROJ_WKT2_NAME_METHOD_S2, 0,
++     ""S2"", ""s2"", nullptr, paramsNatOrigin},
++
+
+     {PROJ_WKT2_NAME_METHOD_SPHERICAL_CROSS_TRACK_HEIGHT, 0,
+      ""Spherical_Cross_Track_Height"", ""sch"", nullptr, paramsSch},",paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now,Are you sure S2 is the best name? Looks like it is only used for quadrilateralized_spherical_cube.
+439,"@@ -71,9 +71,15 @@ func makeKMD() KeyMetadata {
+ 	return emptyKeyMetadata{tlf.FakeID(0, tlf.Private), 1}
+ }
+
++func initBlockRetrievalQueueTest(t *testing.T) *blockRetrievalQueue {
++	q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))
++	<-q.TogglePrefetcher(false, nil)
++	return q
++}
++
+ func TestBlockRetrievalQueueBasic(t *testing.T) {
+ 	t.Log(""Add a block retrieval request to the queue and retrieve it."")
+-	q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))
++	q := initBlockRetrievalQueueTest(t)
+ 	require.NotNil(t, q)
+ 	defer q.Shutdown()
+ ","It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me.","[nit] `q` could be `newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))`"
+440,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[ListAccessKeys.java demonstrates how to list access keys associated with an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[ListAccessKeys.java demonstrates how to list access keys associated with an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),Doesn't look like there is a test in this file that needs updating.
+441,"@@ -34,6 +34,7 @@ class LoadProjectsCloudsqlPipeline(base_pipeline.BasePipeline):
+     """"""Pipeline to load project CloudSql data into Inventory.""""""
+
+     PROJECTS_RESOURCE_NAME = 'project_iam_policies'
++    RESOURCE_NAME = 'cloudsql'
+     RESOURCE_NAME_INSTANCES = 'cloudsql_instances'
+     RESOURCE_NAME_IPADDRESSES = 'cloudsql_ipaddresses'
+     RESOURCE_NAME_AUTHORIZEDNETWORKS = (  # pylint: disable=invalid-name","As a long term thing, would it make sense to move the resource names as keys under the requirements map?",Nit: We can remove the newline here.
+442,"@@ -57,7 +57,7 @@ function traverseForHeaders(headerType, position, tableGrid) {
+  * @return {Array<HTMLTableCellElement>} Array of headers associated to the table cell
+  */
+ table.getHeaders = function(cell, tableGrid) {
+-	if (cell.hasAttribute('headers')) {
++	if (cell.getAttribute('headers')) {
+ 		return commons.dom.idrefs(cell, 'headers');
+ 	}
+ 	if (!tableGrid) {","That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers.",Might be worth checking if `cell.hasAttribute('headers')` instead o
+443,"@@ -38,7 +38,9 @@ public class NoUnusedPinCheckTask extends DefaultTask {
+
+     @Input
+     public final Set<String> getResolvedArtifacts() {
+-        return BaselineVersions.getResolvedArtifacts(getProject());
++        return getProject().getAllprojects().stream()
++                .flatMap(project -> BaselineVersions.getResolvedArtifacts(project).stream())
++                .collect(Collectors.toSet());
+     }
+
+     @InputFile",I am pretty sure that this is infinite recursion as getAllProjects returns the project itself.,"You can use `getProject()` here, there's no need to get all project"
+444,"@@ -268,6 +268,7 @@ Blockly.Categories = {
+   ""sound"": ""sounds"",
+   ""pen"": ""pen"",
+   ""data"": ""data"",
++  ""dataLists"": ""data-lists"",
+   ""event"": ""events"",
+   ""control"": ""control"",
+   ""sensing"": ""sensing"",","Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should ""data-lists"" be ""data_lists""? @paulkaplan",What's the difference between this and `data`? Why do we need both?
+445,"@@ -248,3 +248,7 @@ L2socket: use the provided L2socket
+
+ import scapy.sendrecv
+ scapy.sendrecv.sniff = sniff
++
++# If wpcap.dll is not available
++if (not conf.use_winpcapy) and (not conf.use_pcap) and (not conf.use_dnet):
++    from scapy.arch.windows.disable_sendrecv import *",Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`,I'm not sure if using `not conf.use_winpcapy` is the best way to ch
+446,"@@ -23,6 +23,8 @@ class _Repository:
+         self.description = check.opt_str_param(description, ""description"")
+
+     def __call__(self, fn: Callable[[], Any]) -> RepositoryDefinition:
++        from dagster.core.asset_defs import ForeignAsset
++
+         check.callable_param(fn, ""fn"")
+
+         if not self.name:",we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them.,I think we should move this import to the top of the file.
+447,"@@ -14,8 +14,7 @@ TempDir::TempDir(const char* pathTemplate, bool deleteOnDestroy)
+         : deleteOnDestroy_(deleteOnDestroy) {
+     auto len = strlen(pathTemplate);
+     std::unique_ptr<char[]> name(new char[len + 1]);
+-    strncpy(name.get(), pathTemplate, len);
+-    name.get()[len] = '\0';
++    strcpy(name.get(), pathTemplate);
+
+     VLOG(2) << ""Trying to create the temp directory with pattern \""""
+             << name.get() << ""\"""";","`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though.","Can this just be `strlcpy(name.get(), pathTemplate)`?"
+448,"@@ -36,7 +36,7 @@ const (
+
+ // ErrSharedConfigSourceCollision will be returned if a section contains both
+ // source_profile and credential_source
+-var ErrSharedConfigSourceCollision = awserr.New(ErrCodeSharedConfig, ""only source profile or credential source can be specified, not both"", nil)
++var ErrSharedConfigSourceCollision = awserr.New(ErrCodeSharedConfig, ""only one credential type may be specified per profile: source profile, credential source, credential process, web identity token, or sso"", nil)
+
+ // ErrSharedConfigECSContainerEnvVarEmpty will be returned if the environment
+ // variables are empty and Environment was set as the credential source","Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed.","""only one credential type may be specified per profile"""
+449,"@@ -3,6 +3,7 @@
+ var f = require('util').format;
+ var test = require('./shared').assert;
+ var setupDatabase = require('./shared').setupDatabase;
++const { ReadPreference } = require('../..');
+ const Db = require('../../lib/db');
+ const expect = require('chai').expect;
+ ",The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles,This can just be `const ReadPreference = require('../..
+450,"@@ -10,8 +10,9 @@ from ..registry import PIPELINES
+ @PIPELINES.register_module
+ class LoadImageFromFile(object):
+
+-    def __init__(self, to_float32=False):
++    def __init__(self, to_float32=False, color_type='color'):
+         self.to_float32 = to_float32
++        self.color_type = color_type
+
+     def __call__(self, results):
+         if results['img_prefix'] is not None:",I suggest expanding dims here to simplify the formatting.,"As above, let's remove `to_float32` and just do `self.c"
+451,"@@ -9,7 +9,7 @@ from pyramid.paster import bootstrap
+
+ from kinto.config import init
+
+-CONFIG_FILE = 'config/kinto.ini'
++CONFIG_FILE = 'kinto/config/kinto.ini'
+
+
+ def main(args=None):",Why do you need to specify the kinto prefix here?,Can we move `CONFIG_FILE` to the top of the file?
+452,"@@ -45,7 +45,7 @@ class FPN(nn.Module):
+         >>> self = FPN(in_channels, 11, len(in_channels)).eval()
+         >>> outputs = self.forward(inputs)
+         >>> for i in range(len(outputs)):
+-        ...     print('outputs[{}].shape = {!r}'.format(i, outputs[i].shape))
++        ...     print(f'outputs[{i}].shape = {outputs[i].shape!r}')
+         outputs[0].shape = torch.Size([1, 11, 340, 340])
+         outputs[1].shape = torch.Size([1, 11, 170, 170])
+         outputs[2].shape = torch.Size([1, 11, 84, 84])",The `!r` is unnecessary.,Did you mean to leave this print statement?
+453,"@@ -161,7 +161,7 @@ func (o *lazyCredsOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.
+
+ 		isMSIEnvironment := adal.MSIAvailable(ctx, adal.CreateSender())
+
+-		if accountKey != """" {
++		if accountKey != """" || sasToken != """" {
+ 			o.opener, o.err = openerFromEnv(accountName, accountKey, sasToken, storageDomain, protocol)
+ 		} else if isMSIEnvironment {
+ 			o.opener, o.err = openerFromMSI(accountName, storageDomain, protocol)",I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls.,"If `sasToken` is empty here, then the `else"
+454,"@@ -21,6 +21,8 @@ namespace AutoRest.Go.TemplateModels
+         // (null or empty if the model is not paged).
+         public string NextLink;
+
++        public bool PreparerNeeded;
++
+         public ModelTemplateModel(CompositeType source)
+         {
+             this.LoadFrom(source);",Should we default to `true` ?,nit: Move this next to the other constructo
+455,"@@ -15,6 +15,7 @@ import (
+ 	uconfig ""go.uber.org/config""
+
+ 	""github.com/iotexproject/iotex-core/address""
++	""github.com/iotexproject/iotex-core/consensus/fsm""
+ 	""github.com/iotexproject/iotex-core/crypto""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ )",File is not `goimports`-ed (from `goimports`),Can you move this line down with the other
+456,"@@ -54,11 +54,14 @@ const rules = [
+ 		use: [
+ 			{
+ 				loader: 'babel-loader',
+-				query: {
+-					presets: [ [ '@babel/env', {
+-						useBuiltIns: 'entry',
+-						corejs: 2,
+-					} ], '@babel/preset-react' ],
++				options: {
++					babelrc: false,
++					configFile: false,
++					cacheDirectory: true,
++					presets: [
++						'@wordpress/default',
++						'@babel/preset-react',
++					],
+ 				},
+ 			},
+ 			{","Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise.",I think we are missing a `preset-react.js` file.
+457,"@@ -1609,7 +1609,7 @@ func (wn *WebsocketNetwork) removePeer(peer *wsPeer, reason disconnectReason) {
+ 	// first logging, then take the lock and do the actual accounting.
+ 	// definitely don't change this to do the logging while holding the lock.
+ 	localAddr, _ := wn.Address()
+-	wn.log.With(""event"", ""Disconnected"").With(""remote"", peer.rootURL).With(""local"", localAddr).Infof(""Peer %v disconnected"", peer.rootURL)
++	wn.log.With(""event"", ""Disconnected"").With(""remote"", peer.rootURL).With(""local"", localAddr).Infof(""Peer %v disconnected: %v"", peer.rootURL, reason)
+ 	peerAddr := peer.OriginAddress()
+ 	// we might be able to get addr out of conn, or it might be closed
+ 	if peerAddr == """" && peer.conn != nil {",Nit: We can use `%s` since `disconnectReason` is a string.,"If `reason` is empty, then `wn.log.With(""event"","
+458,"@@ -17,7 +17,8 @@ X_test = df_test.drop(0, axis=1).values
+
+ print('Start training...')
+ # train
+-gbm = lgb.LGBMRegressor(objective='regression',
++gbm = lgb.LGBMRegressor(boosting_type='rgf',
++                        objective='regression',
+                         num_leaves=31,
+                         learning_rate=0.05,
+                         n_estimators=20)",I think it's better to create a new example,Is the trailing comma here on purpose?
+459,"@@ -392,7 +392,7 @@ void ResolveOperation(Action &action, const RENDER_PASS_STATE &rp_state, const V
+
+         if (aspect_mask) {
+             action(aspect_string, ""resolve read"", src_at, dst_at, attachment_views[src_at],
+-                   SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_READ, kDepthStencilAttachmentRasterOrder, offset, extent,
++                   SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_READ, kAttachmentRasterOrder, offset, extent,
+                    aspect_mask);
+             action(aspect_string, ""resolve write"", src_at, dst_at, attachment_views[dst_at],
+                    SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_WRITE, kAttachmentRasterOrder, offset, extent, aspect_mask);","The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers.",This change is also needed in the derived class.
+460,"@@ -64,7 +64,7 @@ class AcidBasePair(object):
+ #: Administration Substance Registration System Standard Operating Procedure guide.
+ ACID_BASE_PAIRS = (
+     AcidBasePair('-OSO3H', 'OS(=O)(=O)[OH]', 'OS(=O)(=O)[O-]'),
+-    AcidBasePair('–SO3H', '[!O]S(=O)(=O)[OH]', '[!O]S(=O)(=O)[O-]'),
++    AcidBasePair('--SO3H', '[!O]S(=O)(=O)[OH]', '[!O]S(=O)(=O)[O-]'),
+     AcidBasePair('-OSO2H', 'O[SD3](=O)[OH]', 'O[SD3](=O)[O-]'),
+     AcidBasePair('-SO2H', '[!O][SD3](=O)[OH]', '[!O][SD3](=O)[O-]'),
+     AcidBasePair('-OPO3H2', 'OP(=O)([OH])[OH]', 'OP(=O)([OH])[O-]'),","To be consistent, I think it should actually just be a single `-`",Is this change intended?
+461,"@@ -6,6 +6,7 @@ import yaml
+
+ from datetime import datetime
+ from listenbrainz.utils import escape, convert_to_unix_timestamp
++from flask import current_app
+
+ def flatten_dict(d, seperator='', parent_key=''):
+     """"""",this seems extraneous.,shouldn't we use `from f
+462,"@@ -795,7 +795,7 @@ func (s *Suite) Define() {
+ 			By(""Sanity-check the issued Certificate"")
+ 			err = f.Helper().ValidateCertificate(f.Namespace.Name, ""testcert"", validations...)
+ 			Expect(err).NotTo(HaveOccurred())
+-		}, featureset.OnlySAN)
++		}, featureset.OnlySAN, featureset.LongDomainFeatureSet)
+
+ 		s.it(f, ""should allow updating an existing certificate with a new DNS Name"", func(issuerRef cmmeta.ObjectReference) {
+ 			testCertificate := &cmapi.Certificate{","Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this?   if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible",`LongDomainFeatureSet` i
+463,"@@ -112,12 +112,13 @@ module Travis
+                   'cdbs qpdf texinfo libssh2-1-dev devscripts '\
+                   ""#{optional_apt_pkgs}"", retry: true
+
+-                r_filename = ""R-#{r_version}-$(lsb_release -cs).xz""
+-                r_url = ""https://travis-ci.rstudio.org/#{r_filename}""
++                r_filename = ""r-#{r_version}_1_amd64.deb""
++                os_version = ""$(lsb_release -rs | tr -d '.')""
++                r_url = ""https://cdn.rstudio.com/r/ubuntu-#{os_version}/pkgs/#{r_filename}""
+                 sh.cmd ""curl -fLo /tmp/#{r_filename} #{r_url}"", retry: true
+-                sh.cmd ""tar xJf /tmp/#{r_filename} -C ~""
+-                sh.export 'PATH', ""${TRAVIS_HOME}/R-bin/bin:$PATH"", echo: false
+-                sh.export 'LD_LIBRARY_PATH', ""${TRAVIS_HOME}/R-bin/lib:$LD_LIBRARY_PATH"", echo: false
++                sh.cmd ""sudo apt-get install gdebi-core""
++                sh.cmd ""sudo gdebi r-#{r_version}_1_amd64.deb""
++                sh.export 'PATH', ""/opt/R/#{r_version}/bin:$PATH"", echo: false
+                 sh.rm ""/tmp/#{r_filename}""
+
+                 sh.cmd ""sudo mkdir -p /usr/local/lib/R/site-library $R_LIBS_USER""",I think you need `-y` here to prevent a user confirmation prompt,Is it possible to use `$
+464,"@@ -100,6 +100,7 @@ bool dynamo_heap_initialized = false;
+ bool dynamo_started = false;
+ bool automatic_startup = false;
+ bool control_all_threads = false;
++bool dynamo_avx512_code_in_use = false;
+ #ifdef WINDOWS
+ bool dr_early_injected = false;
+ int dr_early_injected_location = INJECT_LOCATION_Invalid;","Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above.","I would suggest to rename this to `dynamo_avx512_code_in_use`, it's a bit confusing with `dynamo_avx512_code_in_use`."
+465,"@@ -55,8 +55,11 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister):
+     """"""
+     MIRRORS_SOURCE = ""https://archive.apache.org/dist/jmeter/binaries/""
+     JMETER_DOWNLOAD_LINK = ""https://archive.apache.org/dist/jmeter/binaries/apache-jmeter-{version}.zip""
++    PLUGINS_MANAGER = 'https://repo1.maven.org/maven2/kg/apc/jmeter-plugins-manager/0.8/jmeter-plugins-manager-0.8.jar'
++    CMDRUNNER = 'http://search.maven.org/remotecontent?filepath=kg/apc/cmdrunner/2.0/cmdrunner-2.0.jar'
++    PLUGINS = [""jpgc-casutg"", ""jpgc-dummy"", ""jpgc-ffw"", ""jpgc-fifo"", ""jpgc-functions"",
++               ""jpgc-json"", ""jpgc-perfmon"", ""jpgc-prmctl"", ""jpgc-tst""]
+     JMETER_VER = ""3.0""
+-    PLUGINS_DOWNLOAD_TPL = ""http://jmeter-plugins.org/files/JMeterPlugins-{plugin}-1.4.0.zip""
+     UDP_PORT_NUMBER = None
+
+     def __init__(self):","right URL is like in cmdrunner, using search.maven .org",Is there a reason to use `maven-plugins` instead of `jmeter-plugins`?
+466,"@@ -32,9 +32,9 @@ namespace OpenTelemetry.Exporter
+ #if NETSTANDARD2_1
+         /// <summary>
+         /// Gets or sets the target to which the exporter is going to send traces or metrics.
+-        /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md.
++        /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md. The endpoint value should start with http or https.
+         /// </summary>
+-        public Uri Endpoint { get; set; } = new Uri(""http://localhost:4317"");
++        public string Endpoint { get; set; } = ""http://localhost:4317"";
+ #else
+         /// <summary>
+         /// Gets or sets the target to which the exporter is going to send traces or metrics.","The link to valid syntax is not really applicable for NET2_1, right?","Similarly, I think we can change this to `string endpoint = ""http://localhost:4317"";`"
+467,"@@ -16,6 +16,13 @@
+ // PubSub. Use OpenTopic to construct a *pubsub.Topic, and/or OpenSubscription
+ // to construct a *pubsub.Subscription.
+ //
++// Escaping
++//
++// Go CDK supports all UTF-8 strings; some strings are escaped (during writes)
++// and unescaped (during reads) to ensure compatibility with the provider:
++//  - Metadata keys: No escaping required.
++//  - Metadata values: No escaping required.
++//
+ // As
+ //
+ // gcspubsub exposes the following types for As:","Shouldn't it be more specific, like ""gcppubsub supports all UTF-8 strings""?",I think this should be `Metadata key: ...` instead of `Metadata values: ...`. The latter is what is done for the `As`
+468,"@@ -59,14 +59,14 @@ public class CdcrReplicationHandlerTest extends BaseCdcrDistributedZkTest {
+   }
+
+   /**
+-   * Test the scenario where the slave is killed from the start. The replication
++   * Test the scenario where the secondary is killed from the start. The replication
+    * strategy should fetch all the missing tlog files from the leader.
+    */
+   @Test
+   @ShardsFixed(num = 2)
+   public void testFullReplication() throws Exception {
+-    List<CloudJettyRunner> slaves = this.getShardToSlaveJetty(SOURCE_COLLECTION, SHARD1);
+-    slaves.get(0).jetty.stop();
++    List<CloudJettyRunner> secondaries = this.getShardToSecondaryJetty(SOURCE_COLLECTION, SHARD1);
++    secondaries.get(0).jetty.stop();
+
+     for (int i = 0; i < 10; i++) {
+       List<SolrInputDocument> docs = new ArrayList<>();","Everything in this class is SolrCloud-related, not legacy replication","""secondary is killed from the leader"""
+469,"@@ -1122,15 +1122,8 @@ drbbdup_prepare_redirect(dr_mcontext_t *mcontext, drbbdup_manager_t *manager,
+ {
+     /* Restore flags and scratch reg to their original app values. */
+     if (!manager->are_flags_dead) {
+-        reg_t val;
+-        uint sahf;
+-        reg_t newval = mcontext->xflags;
+-        val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT);
+-        sahf = (val & 0xff00) >> 8;
+-        newval &= ~(EFLAGS_ARITH);
+-        newval |= sahf;
+-        if (TEST(1, val)) /* seto */
+-            newval |= EFLAGS_OF;
++        reg_t val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT);
++        reg_t newval = dr_merge_arith_flags(mcontext->xflags, val);
+         mcontext->xflags = newval;
+     }
+     if (!manager->is_scratch_reg_dead) {",Could just assign directly and eliminate the `newval` var.,This means we can't set the flags to
+470,"@@ -27,11 +27,13 @@ import (
+ const (
+ 	inProgressLabel            = ""in progress""
+ 	issueTitleComment          = ""Please edit the title of this issue with the name of the affected package, followed by a colon, followed by a short summary of the issue. Example: `blob/gcsblob: not blobby enough`.""
++	pullRequestTitleComment    = ""Please edit the title of this pull request with the name of the affected package, followed by a colon, followed by a short summary of the change. Example: `blob/gcsblob: improve comments`.""
+ 	branchesInForkCloseComment = ""Please create pull requests from your own fork instead of from branches in the main repository. Also, please delete this branch.""
+ )
+
+ var (
+-	issueTitleRegexp = regexp.MustCompile(""^[a-z0-9/]+: .*$"")
++	issueTitleRegexp       = regexp.MustCompile(""^[a-z0-9/]+: .*$"")
++	pullRequestTitleRegexp = issueTitleRegexp
+ )
+
+ // issueData is information about an issue event.","... with the name of the affected package, or ""all"", followed by a colon,...",I would consider rewording this to so
+471,"@@ -48,6 +48,10 @@ namespace PrepareRelease
+                 ""src/Datadog.Trace.ClrProfiler.Managed/Datadog.Trace.ClrProfiler.Managed.csproj"",
+                 NugetVersionReplace);
+
++            SynchronizeVersion(
++                ""src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj"",
++                NugetVersionReplace);
++
+             SynchronizeVersion(
+                 ""src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt"",
+                 text => FullVersionReplace(text, "".""));",We'll want to remove this one if we make the assembly version constant.,You might want to consider moving `Sy
+472,"@@ -51,6 +51,7 @@ class Frontend extends Generator {
+ 		$this->setup_blog_colors();
+ 		$this->setup_form_fields_style();
+ 		$this->setup_single_post_style();
++		$this->setup_single_page_style();
+ 	}
+
+ 	/**",Can we have a single function here that uses the same subscribers and just changes meta based on context?,Why are we not using `setup_single_post_style` here?
+473,"@@ -513,8 +513,9 @@ hsa_executable_t load_executable(const string& file, hsa_executable_t executable
+     return executable;
+ }
+
+-// To force HIP to load the kernels and to setup the function
+-// symbol map on program startup
++// HIP startup kernel loader logic
++// When enabled HIP_STARTUP_LOADER, HIP will load the kernels and setup
++// the function symbol map on program startup
+ class startup_kernel_loader {
+    private:
+     startup_kernel_loader() { functions(); }",where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?,"When enabled, HIP will load the kernels and setup th"
+474,"@@ -0,0 +1,14 @@
++const webkitGetAsEntryApi = require('./utils/webkitGetAsEntryApi')
++const getFilesAndDirectoriesApi = require('./utils/getFilesAndDirectoriesApi')
++const fallbackApi = require('./utils/fallbackApi')
++
++module.exports = function getDroppedFiles (dataTransfer, callback) {
++  if (dataTransfer.items[0] && 'webkitGetAsEntry' in dataTransfer.items[0]) {
++    webkitGetAsEntryApi(dataTransfer, callback)
++  } else if ('getFilesAndDirectories' in dataTransfer) {
++    // Doesn't actually work in firefox, maybe in previous versions. webkitGetAsEntryApi() works.
++    getFilesAndDirectoriesApi(dataTransfer, callback)
++  } else {
++    fallbackApi(dataTransfer, callback)
++  }
++}","I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module.","@saghul, I'm not sure this is correct. This function"
+475,"@@ -732,12 +732,6 @@ func (m *Volume) Contains(mid string) bool {
+ // Copy makes a deep copy of VolumeSpec
+ func (s *VolumeSpec) Copy() *VolumeSpec {
+ 	spec := *s
+-	if s.VolumeLabels != nil {
+-		spec.VolumeLabels = make(map[string]string)
+-		for k, v := range s.VolumeLabels {
+-			spec.VolumeLabels[k] = v
+-		}
+-	}
+ 	if s.ReplicaSet != nil {
+ 		spec.ReplicaSet = &ReplicaSet{Nodes: make([]string, len(s.ReplicaSet.Nodes))}
+ 		copy(spec.ReplicaSet.Nodes, s.ReplicaSet.Nodes)",Migrate the spec.Labels to locator.Labels ?,Is this not needed anymore?
+476,"@@ -250,7 +250,7 @@ func TestS3_EmptyBucket(t *testing.T) {
+
+ 			gotErr := service.EmptyBucket(tc.inBucket)
+
+-			if gotErr != nil {
++			if tc.wantErr != nil {
+ 				require.EqualError(t, gotErr, tc.wantErr.Error())
+ 			}
+ 		})",The test case already existed but it never tested properly because of the conditional in the test.,if len(tc.wantErr) > 0 {
+477,"@@ -68,11 +68,9 @@ public class PartitionField implements Serializable {
+     }
+
+     PartitionField that = (PartitionField) other;
+-    return (
+-        sourceId == that.sourceId &&
++    return sourceId == that.sourceId &&
+         name.equals(that.name) &&
+-        transform.equals(that.transform)
+-    );
++        transform.equals(that.transform);
+   }
+
+   @Override","I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them.",This was an automatic ID
+478,"@@ -138,7 +138,7 @@ public class IndexSchema {
+
+   protected List<SchemaField> fieldsWithDefaultValue = new ArrayList<>();
+   protected Collection<SchemaField> requiredFields = new HashSet<>();
+-  protected volatile DynamicField[] dynamicFields;
++  protected DynamicField[] dynamicFields = new DynamicField[] {};
+   public DynamicField[] getDynamicFields() { return dynamicFields; }
+
+   protected Map<String, SchemaField> dynamicFieldCache = new ConcurrentHashMap<>();",@sarowe why was this volatile? It's fishy to see this as the only volatile field.,I don't understand why t
+479,"@@ -0,0 +1,13 @@
++package org.apache.servicecomb.serviceregistry.task.event;
++
++/**
++ * 一句话功能简述
++ * 功能详细描述
++ * @author m00416667
++ * @version [版本号, ]
++ * @see  [相关类/方法]
++ * @since [产品/模块版本]
++ * Package Name:org.apache.servicecomb.serviceregistry.task.event
++ */
++public class InstanceRegistryFailedEvent {
++}",template is not correct?,What do you think about
+480,"@@ -0,0 +1,4 @@
++from mmdet.utils import Registry
++
++ASSIGNERS = Registry('assigner')
++SAMPLERS = Registry('sampler')",Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler.,Those should be moved to `mmdet.assigner` and `mmdet.sampler`.
+481,"@@ -89,9 +89,7 @@ module Beaker
+     describe ""provisioning and cleanup"" do
+
+       before :each do
+-        vagrant.should_receive( :make_vfile ).with( @hosts ).once
+-
+-        vagrant.should_receive( :vagrant_cmd ).with( ""destroy --force"" ).once
++        FakeFS.activate!
+         vagrant.should_receive( :vagrant_cmd ).with( ""up"" ).once
+         @hosts.each do |host|
+           host_prev_name = host['user']","This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters.",@jmhooper is this what we want to do here?
+482,"@@ -188,6 +188,11 @@ module BoltServer
+       [200, GC.stat.to_json]
+     end
+
++    get '/admin/status' do
++      stats = Puma.stats
++      [200, stats.is_a?(Hash) ? stats.to_json : stats]
++    end
++
+     get '/500_error' do
+       raise 'Unexpected error'
+     end",This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this.,"I'm not sure what the best way to do this, but I'm open to sug"
+483,"@@ -5902,6 +5902,7 @@ os_forge_exception(app_pc target_pc, dr_exception_type_t type)
+     switch (type) {
+     case ILLEGAL_INSTRUCTION_EXCEPTION: sig = SIGILL; break;
+     case UNREADABLE_MEMORY_EXECUTION_EXCEPTION: sig = SIGSEGV; break;
++    case SINGLE_STEP_EXCEPTION: ASSERT_NOT_IMPLEMENTED(false); /* cf i#2144 */
+     case IN_PAGE_ERROR_EXCEPTION: /* fall-through: Windows only */
+     default: ASSERT_NOT_REACHED(); sig = SIGSEGV; break;
+     }","Convention is ""FIXME: i#2144"" or ""XXX: i#2144""",Wouldn't it be better to use `ASSERT_NOT_IMPLEMENTED(false)` h
+484,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface IHasHttpMethod
++    {
++        string GetHttpMethod();
++    }
++}",This should probably be a property instead of a method.,Why do we need this interface? I don't see any other way around it.
+485,"@@ -159,10 +159,12 @@ spec:
+     status:
+       phase: Init
+     versionDetails:
+-      current: {{ .CAST.version }}
++      status:
++        current: {{ .CAST.version }}
++        dependentsUpgraded: true
++        state: RECONCILED
+       desired: {{ .CAST.version }}
+       autoUpgrade: false
+-      dependentsUpgraded: true
+ ---
+ apiVersion: openebs.io/v1alpha1
+ kind: RunTask","do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions.",Why did you remove this?
+486,"@@ -3,7 +3,11 @@ module Blacklight::Solr
+     extend ActiveSupport::Concern
+
+     included do
+-      self.default_processor_chain = [:default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr, :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr, :add_sorting_to_solr, :add_group_config_to_solr ]
++      self.default_processor_chain = [
++        :default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr,
++        :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr,
++        :add_sorting_to_solr, :add_group_config_to_solr, :add_facet_paging_to_solr
++      ]
+     end
+
+     ####",Line is too long. [82/80],Align the elements of an array literal if they span more than one l
+487,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel
+ {
+     using System;",Add blank line below license header.,Please revert all the changes to this file.
+488,"@@ -110,9 +110,17 @@ public abstract class BaseMetastoreCatalog implements Catalog {
+       throw new NoSuchTableException(""No such table: "" + identifier);
+     }
+
+-    String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
+     Map<String, String> tableProperties = properties != null ? properties : Maps.newHashMap();
+-    TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
++
++    TableMetadata metadata;
++    if (ops.current() != null) {
++      String baseLocation = location != null ? location : ops.current().location();
++      metadata = ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);
++    } else {
++      String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
++      metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
++    }
++
+     if (orCreate) {
+       return Transactions.createOrReplaceTableTransaction(identifier.toString(), ops, metadata);
+     } else {","I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider.",can location be null?
+489,"@@ -37,8 +37,10 @@ import (
+ 	executionpb ""go.temporal.io/temporal-proto/execution""
+ 	tasklistpb ""go.temporal.io/temporal-proto/tasklist""
+
++	executionproto ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	""github.com/temporalio/temporal/.gen/proto/persistenceblobs""
+ 	replicationgenpb ""github.com/temporalio/temporal/.gen/proto/replication""
++
+ 	""github.com/temporalio/temporal/common""
+ 	""github.com/temporalio/temporal/common/checksum""
+ 	""github.com/temporalio/temporal/common/persistence/serialization""",Just run a global replacement for all `executionproto`.,Did you mean to add t
+490,"@@ -111,7 +111,7 @@ class WebDriver(object):
+
+     def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
+                  desired_capabilities=None, browser_profile=None, proxy=None,
+-                 keep_alive=False, file_detector=None):
++                 keep_alive=False, file_detector=None, options=None):
+         """"""
+         Create a new driver that will issue commands using the wire protocol.
+ ",@AutomatedTester @davehunt thoughts on a new keyword argument?,I'm guessing you didn
+491,"@@ -49,6 +49,9 @@ fpga_result opae_ioctl(int fd, int request, ...)
+ 		case EINVAL:
+ 			res = FPGA_INVALID_PARAM;
+ 			break;
++		case ENOTSUP:
++			res = FPGA_NOT_SUPPORTED;
++			break;
+ 		default:
+ 			// other errors could be
+ 			// EBADF - fd is bad file descriptor",Should line 47 be OPAE_ERR?,The `break` here shou
+492,"@@ -104,6 +104,8 @@ import (
+ 	""gocloud.dev/pubsub/driver""
+ )
+
++var zeroTime time.Time
++
+ // Message contains data to be published.
+ type Message struct {
+ 	// Body contains the content of the message.","Not necessary, just write `time.Time{}`",What is this zeroTime for? Are we setting it somewhere else?
+493,"@@ -499,6 +499,11 @@ def data(readonly=False):
+              SettingValue(typ.Bool(), 'true'),
+              ""Whether to show favicons in the tab bar.""),
+
++            ('tabbar-size',
++             SettingValue(typ.Int(minval=8), '12'),
++             ""The height of the tabbar in pixels.""
++             ""This also controls the size of the favicons.""),
++
+             ('width',
+              SettingValue(typ.PercOrInt(minperc=0, maxperc=100, minint=1),
+                           '20%'),","As these two strings simply get concatenated for the docs, there's a space missing after the dot here.",typo: `the size of the tabbar in pixels.`
+494,"@@ -29,6 +29,7 @@ namespace Datadog.Trace.ClrProfiler.CallTarget
+         {
+             if (IntegrationOptions<TIntegration, TTarget>.IsIntegrationEnabled)
+             {
++                IntegrationOptions<TIntegration, TTarget>.RecordTelemetry();
+                 return BeginMethodHandler<TIntegration, TTarget>.Invoke(instance);
+             }
+ ",What about integrations where we don't plug ourselved on OnMethodBegin?,Should this only be done if `TTarget` is not `null`?
+495,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?,Shouldn't this be `all`?
+496,"@@ -18,12 +18,15 @@ import com.google.api.codegen.SnippetSetRunner;
+ import com.google.api.codegen.viewmodel.FileHeaderView;
+ import com.google.api.codegen.viewmodel.ViewModel;
+ import com.google.api.codegen.viewmodel.testing.MockServiceImplView.Builder;
++import com.google.api.tools.framework.model.Interface;
+ import com.google.auto.value.AutoValue;
+ import java.util.List;
+
+ @AutoValue
+ public abstract class GapicSurfaceTestClassView implements ViewModel {
+
++  public abstract Interface service();
++
+   public abstract FileHeaderView fileHeader();
+
+   public abstract String name();",ViewModel classes should not expose any classes from framework.model.,This looks like the only thing that `ViewModel` has to do with `GapicSurface`... should we just make it `private` and remove the abstract?
+497,"@@ -135,9 +135,6 @@ def test_single_required_string_field_config_type():
+     assert _validate(_single_required_string_config_dict(), {'string_field': 'value'}) == {
+         'string_field': 'value'
+     }
+-    assert _validate(_single_required_string_config_dict(), {'string_field': None}) == {
+-        'string_field': None
+-    }
+
+     with pytest.raises(DagsterEvaluateConfigValueError):
+         _validate(_single_required_string_config_dict(), {})",how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?,Why is this being removed?
+498,"@@ -21,10 +21,11 @@ test_name ""bolt plan run should apply manifest block on remote hosts via winrm""
+     scp_to(bolt, File.join(fixtures, 'example_apply'), ""#{dir}/modules/example_apply"")
+   end
+
+-  bolt_command = ""bolt plan run example_apply filepath=#{filepath} nodes=winrm_nodes""
++  bolt_command = ""bolt plan run example_apply filepath=#{filepath}""
+   flags = {
+     '--modulepath' => modulepath(File.join(dir, 'modules')),
+-    '--format' => 'json'
++    '--format' => 'json',
++    '-t' => ""winrm_nodes""
+   }
+
+   teardown do","Why do we use the `winrm_nodes` variable here and not the string `""winrm_nodes""` as we were using before?",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+499,"@@ -1,4 +1,4 @@
+-/* Copyright (c) 2018 vesoft inc. All rights reserved.
++/* Copyright (c) 2019 vesoft inc. All rights reserved.
+  *
+  * This source code is licensed under Apache 2.0 License,
+  * attached with Common Clause Condition 1.0, found in the LICENSES directory.",why update Copyright ?,"nit: do you need to change this file, or can you revert it?"
+500,"@@ -7469,7 +7469,14 @@ RelExpr *Scan::bindNode(BindWA *bindWA)
+      bindWA->setErrStatus();
+      return NULL;
+   }
+-
++  if (naTable->hasLobColumn() && isSampleScan())
++    {
++      *CmpCommon::diags() << DgSqlCode(-4322)
++       << DgTableName(
++           naTable->getTableName().getQualifiedNameAsAnsiString());
++     bindWA->setErrStatus();
++     return NULL;
++    }
+   // restricted partitions for HBase table
+   if (naTable->isHbaseTable() &&
+       (naTable->isPartitionNameSpecified() ||",Does this mean we cannot update statistics with sampling on a table with LOB columns?,shouldn't this be `if (isSampleScan())` ?
+501,"@@ -47,7 +47,18 @@ namespace NLog.LayoutRenderers.Wrappers
+     [ThreadAgnostic]
+     public sealed class CachedLayoutRendererWrapper : WrapperLayoutRendererBase
+     {
+-        private string cachedValue;
++        /// <summary>
++        /// A value indicating when the cache is cleared.
++        /// </summary>
++        public enum ClearCacheOption
++        {
++            /// <summary>Never clear the cache.</summary>
++            Never = 0,
++            /// <summary>Clear the cache whenever the <see cref=""CachedLayoutRendererWrapper""/> is initialized.</summary>
++            OnInitialize = 1
++        }
++
++        private string cachedValue = null;
+
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""CachedLayoutRendererWrapper""/> class.","Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?",Never should be 0 unless you are sure you
+502,"@@ -1577,6 +1577,16 @@
+       require: '^uiGrid',
+       link: function($scope, $elm, $attrs, uiGridCtrl) {
+         var self = uiGridCtrl.grid;
++        $scope.treeButtonClass = function(row) {
++          if ( ( self.options.showTreeExpandNoChildren && row.treeLevel > -1 ) || ( row.treeNode.children && row.treeNode.children.length > 0 ) ) {
++            if (row.treeNode.state === 'expanded' ) {
++              return 'ui-grid-icon-minus-squared';
++            }
++            if (row.treeNode.state === 'collapsed' ) {
++              return 'ui-grid-icon-plus-squared';
++            }
++          }
++        };
+         $scope.treeButtonClick = function(row, evt) {
+           evt.stopPropagation();
+           uiGridTreeBaseService.toggleRowTreeState(self, row, evt);","Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `",Shouldn't this be `row.treeNode.children.
+503,"@@ -32,10 +32,6 @@ import org.apache.solr.common.SolrException;
+  * Solr endpoints for SolrCloud collections, and then use the
+  * {@link LBHttp2SolrClient} to issue requests.
+  *
+- * This class assumes the id field for your documents is called
+- * 'id' - if this is not the case, you must set the right name
+- * with {@link #setIdField(String)}.
+- *
+  * @lucene.experimental
+  * @since solr 8.0
+  */","the latter part can go but isn't the first part of this still sound -- that we assume ""id""?","If we remove the `getIdField` method, do "
+504,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return '\'' + value + '\'';
+ 	} else {
+-		return '""""';
++		return '\'\'';
+ 	}
+ }
+ ",Why is the escaping of @ and $ removed?,why remove the escape escape?
+505,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface IHasHttpUrl
++    {
++        string GetRawUrl();
++    }
++}",Nit: `Http` is redundant in this interface's name.,Why do we need an `IHasRawUrl
+506,"@@ -82,6 +82,19 @@ func NewCluster(ctx context.Context, cfg *ClusterConfig, creds credentials.Trans
+ 	if err != nil {
+ 		return nil, nil, err
+ 	}
++
++	exists, err := store.Exists(cfg.SynchronizableEntitiesPrefix)
++	if err != nil {
++		return nil, nil, fmt.Errorf(""failed to check if SynchronizableEntitiesPrefix exists: %s"", err)
++	}
++
++	if !exists {
++		err = store.Put(cfg.SynchronizableEntitiesPrefix, []byte{}, nil)
++		if err != nil {
++			return nil, nil, err
++		}
++	}
++
+ 	endpoints, err := parseEndpoints(cfg)
+ 	if err != nil {
+ 		return nil, nil, err","what if I set SynchronizableEntitiesPrefix to ""a/b/c/d"" in config?",You could also use `cfg.Synch
+507,"@@ -83,9 +83,13 @@ func (opts *InitAppOpts) Validate() error {
+ 		}
+ 	}
+ 	if opts.DockerfilePath != """" {
+-		if _, err := listDockerfiles(opts.fs, opts.DockerfilePath); err != nil {
++		isDir, err := afero.IsDir(opts.fs, opts.DockerfilePath)
++		if err != nil {
+ 			return err
+ 		}
++		if isDir {
++			return fmt.Errorf(""dockerfile path expected, got %s"", opts.DockerfilePath)
++		}
+ 	}
+ 	if opts.ProjectName() == """" {
+ 		return errNoProjectInWorkspace","nit: This error message doesn't mention that the path is a directory, maybe ""Dockerfile path is a directory:%s, please provide path to file.""",error strings should not be c
+508,"@@ -26,6 +26,7 @@
+ # Copyright (c) 2020 Anthony <tanant@users.noreply.github.com>
+ # Copyright (c) 2021 Marc Mueller <30130371+cdce8p@users.noreply.github.com>
+ # Copyright (c) 2021 Peter Kolbus <peter.kolbus@garmin.com>
++# Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com>
+
+
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html","This is done automatically, you can skip it next time ;)","I don't know if it's worth adding a new file for this, but it's probably not worth it since it's unrelated to the change."
+509,"@@ -128,6 +128,14 @@ class WebKitElement(webelem.AbstractWebElement):
+             value = javascript.string_escape(value)
+             self._elem.evaluateJavaScript(""this.value='{}'"".format(value))
+
++    def dispatch_event(self, event):
++        self._check_vanished()
++        if self._tab.is_deleted():
++            raise webelem.OrphanedError(""Tab containing element vanished"")
++        log.webelem.debug(""Firing event on {!r} via javascript."".format(self))
++        self._elem.evaluateJavaScript(""this.dispatchEvent(new Event('{}'))""
++                                      .format(event))
++
+     def caret_position(self):
+         """"""Get the text caret position for the current element.""""""
+         self._check_vanished()","This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?",Why do we need to evaluate the JavaScript output here?
+510,"@@ -53,6 +53,10 @@ type agentConfig struct {
+
+ 	ConfigPath string
+ 	Umask      string `hcl:""umask""`
++
++	ProfilingEnabled string `hcl:""profiling_enabled""`
++	ProfilingPort    string `hcl:""profiling_port""`
++	ProfilingFreq    string `hcl:""profiling_freq""`
+ }
+
+ type RunCLI struct {","Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?",Can we just call this `ProfilingEnabled`?
+511,"@@ -22,6 +22,7 @@ module Beaker
+       #HACK HACK HACK - add checks here to ensure that we have box + box_url
+       #generate the VagrantFile
+       v_file = ""Vagrant.configure(\""2\"") do |c|\n""
++      v_file << ""  c.ssh.forward_agent = true\n"" unless options['forward_ssh_agent'].nil?
+       hosts.each do |host|
+         host['ip'] ||= randip #use the existing ip, otherwise default to a random ip
+         v_file << ""  c.vm.define '#{host.name}' do |v|\n""",This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set.,should we also set `c.ssh.forward_agent = true` if `options['forward_ssh_agent']` is nil?
+512,"@@ -521,7 +521,7 @@ func TestVoteTrackerFiltersDuplicateVoteOnce(t *testing.T) {
+ 			inputVotes[i] = helper.MakeValidVoteAcceptedVal(t, i, next, Val1)
+ 			expectedOutputs[i] = thresholdEvent{T: none}
+ 		case i == Num:
+-			inputVotes[i] = voteFilterRequestEvent{RawVote: inputVotes[Num-1].(voteAcceptedEvent).Vote.R}
++			inputVotes[i] = voteFilterRequestEvent{RawVote: inputVotes[Num-1].(voteAcceptedEvent).Vote.R, Proto: protocol.ConsensusCurrentVersion}
+ 			expectedOutputs[i] = filteredStepEvent{T: voteFilteredStep}
+ 		}
+ 	}",We could avoid passing proto since threshold isn't needed.,why do we need to set the Proto here?
+513,"@@ -1040,7 +1040,10 @@ func (di *Dependencies) AllowURLAccess(servers ...string) error {
+ 		return err
+ 	}
+
+-	if config.GetBool(config.FlagKeepConnectedOnFail) {
++	// Doesn't work as expected because some services share IP address with
++	// each other and with location oracle which is supposed to be routed
++	// through VPN tunnel.
++	if false && config.GetBool(config.FlagKeepConnectedOnFail) {
+ 		if err := router.AllowURLAccess(servers...); err != nil {
+ 			return err
+ 		}","This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded.",Does it mean that some services would
+514,"@@ -124,8 +124,8 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+   }
+   CHECK(status.ok()) << status.ToString();
+   db_.reset(db);
+-  partsNum_ = allParts().size();
+   extractorLen_ = sizeof(PartitionID) + vIdLen;
++  partsNum_ = allParts().size();
+   LOG(INFO) << ""open rocksdb on "" << path;
+
+   backup();",why can this modification avoid crash?,I'd like to see this reverted since i
+515,"@@ -1,8 +1,7 @@
+ module RedirectIfDisabled
+   def redirect_if_disabled
+-    account = current_user
+-    return unless account && account.access.disabled?
+-    request.env[:clearance].sign_out
+-    redirect_to disabled_account_url(account)
++    return unless @account && @account.access.disabled?
++    request.env[:clearance].sign_out if @account.id == current_user.id
++    redirect_to disabled_account_url(@account)
+   end
+ end",This looks good -- signing out the user if the current user is disabled,Would it make sense to use `@account.
+516,"@@ -47,13 +47,13 @@ class Selection {
+      */
+     this.selectedByCorner = false;
+     /**
+-     * The collection of the selection layer levels where the whole row was selected using the row header.
++     * The collection of the selection layer levels where the whole row was selected using the row header or the corner header.
+      *
+      * @type {Set.<number>}
+      */
+     this.selectedByRowHeader = new Set();
+     /**
+-     * The collection of the selection layer levels where the whole column was selected using the column header.
++     * The collection of the selection layer levels where the whole column was selected using the column header or the corner header.
+      *
+      * @type {Set.<number>}
+      */",The line exceeds 120 characters.,typo: header or the corner header
+517,"@@ -62,6 +62,11 @@ func renderAppDescribe(desc map[string]interface{}) (string, error) {
+ 	ddevapp.RenderAppRow(appTable, desc)
+ 	output = fmt.Sprint(appTable)
+
++	output = output + ""\n\nSite Information\n-----------------\n""
++	siteInfo := uitable.New()
++	siteInfo.AddRow(""PHP version:"", desc[""php_version""])
++	output = output + fmt.Sprint(siteInfo)
++
+ 	// Only show extended status for running sites.
+ 	if desc[""status""] == ddevapp.SiteRunning {
+ 		output = output + ""\n\nMySQL Credentials\n-----------------\n""","Let's go ahead and change ""Site"" to ""Project"", since that's the path we've chosen. One less thing to alter in the other issue.",I think this would be better in `
+518,"@@ -89,7 +89,6 @@ Prints out information about filecoin process and its environment.
+ 			sw.Printf(""\nEnvironment\n"")
+ 			sw.Printf(""FilAPI: \t%s\n"", info.Environment.FilAPI)
+ 			sw.Printf(""FilPath:\t%s\n"", info.Environment.FilPath)
+-			sw.Printf(""GoPath: \t%s\n"", info.Environment.GoPath)
+
+ 			// Print Config Info
+ 			sw.Printf(""\nConfig\n"")","I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?",Shouldn't we keep this line?
+519,"@@ -296,11 +296,16 @@ public class ImageRampupManagerImpl implements ImageRampupManager {
+       if (null == flow) {
+         log.info(""Flow object is null, so continue"");
+         final ImageRampup firstImageRampup = imageRampupList.get(0);
++
++        // Find the imageVersion in the Rampup list with maximum rampup percentage.
++        final ImageRampup maxImageRampup = imageRampupList.stream()
++            .max(Comparator.comparing(ImageRampup::getRampupPercentage))
++            .orElseGet(() -> firstImageRampup);
+         imageTypeRampupVersionMap.put(imageTypeName,
+-            this.fetchImageVersion(imageTypeName, firstImageRampup.getImageVersion())
++            this.fetchImageVersion(imageTypeName, maxImageRampup.getImageVersion())
+                 .orElseThrow(() -> new ImageMgmtException(
+                     String.format(""Unable to fetch version %s from image "" + ""versions table."",
+-                        firstImageRampup.getImageVersion()))));
++                        maxImageRampup.getImageVersion()))));
+         continue;
+       }
+       int prevRampupPercentage = 0;",I thought we decided on using the latest active version and not the one which is max ramped up.,"Hmm, I'm not sure if this is the "
+520,"@@ -461,10 +461,13 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
+ 		if err != nil {
+ 			if err == selector.ErrSubnetsNotFound {
+ 				log.Errorf(`No existing public subnets were found in VPC %s. You can either:
+-- Create new public subnets and then import them.
+-- Use the default Copilot environment configuration.`, o.importVPC.ID)
++- %s to interrupt, create new public subnets, then rerun %s and import them.
++- %s to interrupt, then rerun %s and use the default Copilot environment configuration.
++- Proceed without public subnets, knowing that deploying a load-balanced web service in this environment will fail because Load Balancers require at least two public subnets in different Availability Zones.
++`, o.importVPC.ID, color.HighlightUserInput(""ctrl-c""), color.HighlightCode(""copilot env init""), color.HighlightUserInput(""ctrl-c""), color.HighlightCode(""copilot env init""))
++			} else {
++				return fmt.Errorf(""select public subnets: %w"", err)
+ 			}
+-			return fmt.Errorf(""select public subnets: %w"", err)
+ 		}
+ 		o.importVPC.PublicSubnetIDs = publicSubnets
+ 	}",can we update this to a `log.Warningf`?,"Minor typo: ""rerun"" instead of ""reerun"""
+521,"@@ -105,7 +105,11 @@ def connect_container_to_network(container, network):
+
+
+ def disconnect_container_from_network(container, network):
+-    subprocess.check_call([""docker"", ""network"", ""disconnect"", network, container])
++    # subprocess.run instead of subprocess.check_call so we don't fail when
++    # trying to disconnect a container from a network that it's not connected to
++    subprocess.run(  # pylint: disable=subprocess-run-check
++        [""docker"", ""network"", ""disconnect"", network, container]
++    )
+
+
+ def hostnames(network):",can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?,"Shouldn't this be `check_call([""docker"""
+522,"@@ -20,9 +20,10 @@ namespace storage {
+ TEST(DeleteVertexTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/DeleteVertexTest.XXXXXX"");
+     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
++    auto schemaMan = TestUtils::mockSchemaMan();
+     // Add vertices
+     {
+-        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr);
++        auto* processor = AddVerticesProcessor::instance(kv.get(), schemaMan.get(), nullptr);
+         cpp2::AddVerticesRequest req;
+         req.space_id = 0;
+         req.overwritable = false;",Do we need `schema manager` at here ?,"Not needed, a unit test for this will b"
+523,"@@ -0,0 +1,19 @@
++package parser
++
++//go:generate cargo build --release
++
++// #cgo LDFLAGS: -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic
++// #include <stdlib.h>
++// void flux_parse_json(const char*);
++import ""C""
++
++import (
++	""unsafe""
++)
++
++func Parse(input string) {
++	cstr := C.CString(input)
++	defer C.free(unsafe.Pointer(cstr))
++
++	C.flux_parse_json(cstr)
++}","This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module.",You should be able to call `C.flux_pars
+524,"@@ -153,6 +153,8 @@ func (r *REPL) executeLine(t string) (values.Value, error) {
+ 		return nil, err
+ 	}
+
++	r.scope.SetReturn(nil)
++
+ 	if _, err := r.interpreter.Eval(semPkg, r.scope, flux.StdLib()); err != nil {
+ 		return nil, err
+ 	}","Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements.","I don't understand why this is necessary. You are setting `r.scope.Return = true` in line 137, but you are setting `r.scope.SetReturn(nil)` in line 138."
+525,"@@ -162,12 +162,14 @@ func makeStatefulSetService(p *monitoringv1.Alertmanager, config Config) *v1.Ser
+ 		p.Spec.PortName = defaultPortName
+ 	}
+
++	labels := config.Labels.Merge(p.Spec.ServiceMetadata.Labels)
++	labels[""operated-alertmanager""] = ""true""
++
+ 	svc := &v1.Service{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: governingServiceName,
+-			Labels: config.Labels.Merge(map[string]string{
+-				""operated-alertmanager"": ""true"",
+-			}),
++			Name:        governingServiceName,
++			Labels:      labels,
++			Annotations: p.Spec.ServiceMetadata.Annotations,
+ 			OwnerReferences: []metav1.OwnerReference{
+ 				metav1.OwnerReference{
+ 					Name:       p.GetName(),","This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?",Is there any reason for using `map[string]string` instead of `map[string]string`?
+526,"@@ -32,6 +32,7 @@ type AttestedNode struct {
+ 	ExpiresAt       time.Time `gorm:""index""`
+ 	NewSerialNumber string
+ 	NewExpiresAt    *time.Time
++	CanReattest     bool `gorm:""default:false""`
+
+ 	Selectors []*NodeSelector
+ }","Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns).",Please add a new migration for this field.
+527,"@@ -39,6 +39,18 @@ module ExportsHelper
+     ""<strong>#{prefix}</strong> #{attribution.join(', ')}""
+   end
+
++  def download_plan_page_title(plan, phase, hash)
++    # If there is more than one phase show the plan title and phase title
++    return hash[:phases].many? ? ""#{plan.title} - #{phase[:title]}"" : plan.title
++  end
++
++  def display_section?(customization, section, show_custom_sections)
++    display = !customization
++    display ||= customization && !section[:modifiable]
++    display ||= customization && section[:modifiable] && show_custom_sections
++    return display
++  end
++
+   private
+
+   def get_margin_value_for_side(side)",thanks for moving these over. makes more sense for them to be in the exports_helper,"Instead of calling this method, can you call it something like: `display_section?` so that it's more clear what it's doing?"
+528,"@@ -29,8 +29,9 @@ from qutebrowser.utils import message
+ from qutebrowser.config import config
+ from qutebrowser.keyinput import keyparser
+ from qutebrowser.utils import usertypes, log, objreg, utils
++from qutebrowser.config.parsers import keyconf
+
+-
++
+ STARTCHARS = "":/?""
+ LastPress = usertypes.enum('LastPress', ['none', 'filtertext', 'keystring'])
+ ",That import now isn't needed anymore,Please don't remove extra whitespace
+529,"@@ -237,6 +237,8 @@ class WebDriver(RemoteWebDriver):
+         Returns identifier of installed addon. This identifier can later
+         be used to uninstall addon.
+
++        :param path: Full path to the addon that will be installed.
++
+         :Usage:
+             driver.install_addon('firebug.xpi')
+         """"""",Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`,should be: `The path to the addon th
+530,"@@ -2,17 +2,13 @@
+ // The .NET Foundation licenses this file to you under the MS-PL license.
+ // See the LICENSE file in the project root for more information.
+
+-
+-using MvvmCross.Plugins;
+-
+ namespace MvvmCross.Plugin.Accelerometer.Platform.Uap
+ {
+-    public class Plugin
+-        : IMvxPlugin
++    public class Plugin : IMvxPlugin
+     {
+         public void Load()
+         {
+-            Mvx.RegisterSingleton<IMvxAccelerometer>(new MvxWindowsCommonAccelerometer());
++            Mvx.RegisterSingleton<IMvxAccelerometer>(new MvxWindowsAccelerometer());
+         }
+     }
+ }",This class is missing the `MvxPlugin` attribute,@johnsimons do you know why this was
+531,"@@ -596,6 +596,8 @@ def initialize():
+ 	if mainFrame:
+ 		raise RuntimeError(""GUI already initialized"")
+ 	mainFrame = MainFrame()
++	wxLang = core.getWxLang(languageHandler.getLanguage())
++	mainFrame.SetLayoutDirection(wxLang.LayoutDirection)
+ 	wx.GetApp().SetTopWindow(mainFrame)
+ 	# In wxPython >= 4.1,
+ 	# wx.CallAfter no longer executes callbacks while NVDA's main thread is within apopup menu or message box.",What if `wxLang` is returned `None` from `getWxLang`,"Sorry i didn't see this before, but "
+532,"@@ -546,9 +546,9 @@ ResultCode NebulaStore::ingest(GraphSpaceID spaceId) {
+             auto files = nebula::fs::FileUtils::listAllFilesInDir(path.c_str(), true, ""*.sst"");
+             for (auto file : files) {
+                 LOG(INFO) << ""Ingesting extra file: "" << file;
+-                auto code = engine->ingest(std::vector<std::string>({file}));
+-                if (code != ResultCode::SUCCEEDED) {
+-                    return code;
++                auto ret_code = engine->ingest(std::vector<std::string>({file}));
++                if (ResultCode::SUCCEEDED != ret_code) {
++                    return ret_code;
+                 }
+             }
+         }",Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions.,"Minor, but you can use `auto ret_code = engine->ingest(std::vector<std::string> {file});`"
+533,"@@ -35,13 +35,13 @@ public class BaseSuite {
+   public static ExternalResource testEnvironment = new ExternalResource() {
+     @Override
+     protected void before() {
+-      log.info(""Preparing test environment"");
++      log.finest(""Preparing test environment"");
+       GlobalTestEnvironment.get(SeleniumTestEnvironment.class);
+       System.setProperty(""webdriver.remote.shorten_log_messages"", ""true"");
+     }
+     @Override
+     protected void after() {
+-      log.info(""Cleaning test environment"");
++      log.finest(""Cleaning test environment"");
+       TestEnvironment environment = GlobalTestEnvironment.get();
+       if (environment != null) {
+         environment.stop();",This is in test code: understanding what we're doing is important in this context.,Why this change? Is it related to this PR?
+534,"@@ -76,8 +76,8 @@ public class CommandLineUtils {
+    * @param isMainOptionCondition the conditions to test dependent options against. If all
+    *     conditions are true, dependent options will be checked.
+    * @param dependentOptionsNames a list of option names that can't be used if condition is met.
+-   *     Example: if --min-gas-price is in the list and condition is that either --miner-enabled or
+-   *     --goquorum-compatibility-enabled should not be false, we log a warning.
++   *     Example: if --min-gas-price is in the list and condition is that --miner-enabled should not
++   *     be false, we log a warning.
+    */
+   public static void checkMultiOptionDependencies(
+       final Logger logger,",prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?,"I think you need to remove ""and condition"" here too"
+535,"@@ -246,9 +246,9 @@ class PlansController < ApplicationController
+     file_name = @plan.title.gsub(/ /, ""_"")
+
+     respond_to do |format|
+-      format.html
+-      format.csv  { send_data @exported_plan.as_csv(@sections, @unanswered_question, @question_headings),  filename: ""#{file_name}.csv"" }
+-      format.text { send_data @exported_plan.as_txt(@sections, @unanswered_question, @question_headings, @show_details),  filename: ""#{file_name}.txt"" }
++      format.html { render layout: false }
++      format.csv  { send_data @plan.as_csv(@show_sections_questions),  filename: ""#{file_name}.csv"" }
++      format.text { send_data render_to_string(partial: 'shared/export/plan_txt'), filename: ""#{file_name}.txt"" }
+       format.docx { render docx: 'export', filename: ""#{file_name}.docx"" }
+       format.pdf do
+         render pdf: file_name,","I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html...",Unnecessary spacing detected.
+536,"@@ -21,7 +21,7 @@ var LocalDevStopCmd = &cobra.Command{
+ 		err = app.Stop()
+ 		if err != nil {
+ 			log.Println(err)
+-			util.Failed(""Failed to stop containers for %s. Run `ddev list` to ensure your site exists."", app.ContainerName())
++			util.Failed(""Failed to stop containers for %s. Run `ddev list` to ensure your site exists. error="", app.ContainerName(), err)
+ 		}
+
+ 		util.Success(""Application has been stopped."")","stylistic nitpick: I _feel_ like we've largely shown errors like this as ""error: "" vs. ""error="". IMO colon/space reads better.",Do we need to add the error to the output?
+537,"@@ -18,11 +18,16 @@
+  */
+
+ #include <fastdds/rtps/writer/RTPSWriter.h>
++
++#include <fastdds/dds/log/Log.hpp>
++
+ #include <fastdds/rtps/history/WriterHistory.h>
+ #include <fastdds/rtps/messages/RTPSMessageCreator.h>
+-#include <fastdds/dds/log/Log.hpp>
+-#include <rtps/participant/RTPSParticipantImpl.h>
++
++#include <rtps/history/BasicPayloadPool.hpp>
++#include <rtps/history/CacheChangePool.h>
+ #include <rtps/flowcontrol/FlowController.h>
++#include <rtps/participant/RTPSParticipantImpl.h>
+
+ #include <mutex>
+ ",We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function.,Do we still need this? Doesn't seem like w
+538,"@@ -25,6 +25,7 @@
+ package persistencetests
+
+ import (
++	""fmt""
+ 	""time""
+
+ 	""github.com/pborman/uuid""",should this file ends with _test.go?,Remove the extra line.
+539,"@@ -382,7 +382,7 @@ class IPv6(_IPv6GuessPayload, Packet, IPTools):
+
+         if conf.checkIPsrc and conf.checkIPaddr and not in6_ismaddr(sd):
+             sd = inet_pton(socket.AF_INET6, sd)
+-            ss = inet_pton(socket.AF_INET6, self.src)
++            ss = inet_pton(socket.AF_INET6, ss)
+             return strxor(sd, ss) + struct.pack(""B"", nh) + self.payload.hashret()  # noqa: E501
+         else:
+             return struct.pack(""B"", nh) + self.payload.hashret()",It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does,shouldn't this be `self.src`?
+540,"@@ -483,6 +483,7 @@ class DataManager {
+    */
+   addChildAtIndex(parent, index, element) {
+     let childElement = element;
++    let flattenIndex;
+
+     if (!childElement) {
+       childElement = this.mockNode();","""Flatten"" is a verb, so I'd probably go with `flattenedIndex` as a variable name here.",Why do you need this?
+541,"@@ -1,5 +1,19 @@
+ const chalk = require('chalk')
+
++const valuesToMask = []
++/**
++ * Adds a list of strings that should be masked by the logger.
++ * This function can only be called once through out the life of the server.
++ * @param {Array} maskables a list of strings to be masked
++ */
++exports.addMaskables = (maskables) => {
++  maskables.forEach((i) => {
++    valuesToMask.push(i)
++  })
++
++  Object.freeze(valuesToMask)
++}
++
+ /**
+  * INFO level log
+  * @param {string} msg the message to log","If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times",Since this is only us
+542,"@@ -38,7 +38,7 @@ func downloadAndExtractConfigPackage(channel string, targetDir string) (err erro
+ }
+
+ func downloadConfigPackage(channelName string, targetDir string) (packageFile string, err error) {
+-	s3, err := s3.MakeS3SessionForDownload()
++	s3, err := s3.MakePublicS3SessionForDownload()
+ 	if err != nil {
+ 		return
+ 	}",Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket.,What does this change
+543,"@@ -0,0 +1,17 @@
++# MicrosoftEdge.py
++#A part of NonVisual Desktop Access (NVDA)
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++#Copyright (C) 2018 NV Access Limited, Joseph Lee
++
++""""""appModule for Microsoft Edge main process""""""
++
++import appModuleHandler
++import ui
++
++class AppModule(appModuleHandler.AppModule):
++
++	def event_UIA_notification(self, obj, nextHandler, displayString=None, **kwargs):
++		# #8423: even though content process is focused, notifications are fired by main Edge process.
++		# The base object will simply ignore this, so notifications must be announced here and no more.
++		ui.message(displayString)",Could you please end the file with an empty line?,I am not sure why thi
+544,"@@ -76,7 +76,7 @@ public class ProtocolHandshake {
+
+         if (result.isPresent()) {
+           Result toReturn = result.get();
+-          LOG.info(String.format(""Detected dialect: %s"", toReturn.dialect));
++          LOG.finest(String.format(""Detected dialect: %s"", toReturn.dialect));
+           return toReturn;
+         }
+       }",This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users.,to be consistent with the other log message
+545,"@@ -89,7 +89,9 @@ func (v *Var) UnmarshalJSON(b []byte) error {
+ // Workflow is a single Daisy workflow workflow.
+ type Workflow struct {
+ 	// Populated on New() construction.
+-	Cancel chan struct{} `json:""-""`
++	Cancel       chan struct{} `json:""-""`
++	isCanceled   bool
++	isCanceledMx sync.Mutex
+
+ 	// Workflow template fields.
+ 	// Workflow name.",Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work.,Why do we need this mutex?
+546,"@@ -145,7 +145,11 @@ func (w *watcher) ErrorAs(err error, i interface{}) bool {
+ 	return w.bucket.ErrorAs(err, i)
+ }
+
+-// IsNotExist implements driver.IsNotExist.
+-func (*watcher) IsNotExist(err error) bool {
+-	return gcerrors.Code(err) == gcerrors.NotFound
++// ErrorCode implements driver.ErrorCode.
++func (*watcher) ErrorCode(err error) gcerrors.ErrorCode {
++	// err might have come from blob, in which case use its code.
++	if c := gcerrors.Code(err); c != gcerrors.Unknown {
++		return c
++	}
++	return gcerrors.Unknown
+ }","Nit: this is just `return gcerrors.Code(err)`, isn't it?",I'm confused. If we return `gcerrors.NotFou
+547,"@@ -189,12 +189,7 @@ func (smc *Client) ProposeDeal(ctx context.Context, miner address.Address, data
+ 	// create payment information
+ 	totalCost := price.MulBigInt(big.NewInt(int64(pieceSize * duration)))
+ 	if totalCost.GreaterThan(types.ZeroAttoFIL) {
+-		// The payment setup requires that the payment is mined into a block, currently we
+-		// will wait for at most 5 blocks to be mined before giving up
+-		ctxPaymentSetup, cancel := context.WithTimeout(ctx, 5*smc.api.BlockTime())
+-		defer cancel()
+-
+-		cpResp, err := smc.api.CreatePayments(ctxPaymentSetup, porcelain.CreatePaymentsParams{
++		cpResp, err := smc.api.CreatePayments(ctx, porcelain.CreatePaymentsParams{
+ 			From:            fromAddress,
+ 			To:              minerOwner,
+ 			Value:           totalCost,","I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests.",Can you elaborate on why `ctxPaymentSetup`
+548,"@@ -47,7 +47,8 @@ def loadState():
+ 	global state
+ 	statePath=os.path.join(globalVars.appArgs.configPath,stateFilename)
+ 	try:
+-		state = cPickle.load(file(statePath, ""r""))
++		with open(statePath, ""r"") as f:
++			state = cPickle.load(f)
+ 		if ""disabledAddons"" not in state:
+ 			state[""disabledAddons""] = set()
+ 		if ""pendingDisableSet"" not in state:","In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb.",Could you explain why this change is needed?
+549,"@@ -2068,7 +2068,7 @@ const processRequest = (params) => {
+                     }
+                     else {
+                         if (params.qstring.event && params.qstring.event.startsWith('[CLY]_group_')) {
+-                            validateRead(params, 'core', countlyApi.data.fetch.fetchMergedEventGroups, params.qstring.method);
++                            validateRead(params, 'core', countlyApi.data.fetch.fetchMergedEventGroups);
+                         }
+                         else {
+                             params.truncateEventValuesList = true;",did you remove **params.qstring.method** intentionally? if so why?,Why is method required now?
+550,"@@ -90,6 +90,12 @@ public class TableProperties {
+   public static final String ORC_VECTORIZATION_ENABLED = ""read.orc.vectorization.enabled"";
+   public static final boolean ORC_VECTORIZATION_ENABLED_DEFAULT = false;
+
++  public static final String LOCALITY_ENABLED = ""read.locality.enabled"";
++  public static final String LOCALITY_ENABLED_DEFAULT = null;
++
++  public static final String LOCALITY_TASK_INITIALIZE_THREADS = ""read.locality.task.initialize.threads"";
++  public static final int LOCALITY_TASK_INITIALIZE_THREADS_DEFAULT = 1;
++
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ ",What is the current default? Is that inconsistent across uses and that's why this is null?,How about `read.orc.vectorization.threads` i
+551,"@@ -477,6 +477,7 @@ func (cf CloudFormation) getLastDeployedAppConfig(appConfig *stack.AppStackConfi
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""parse previous deployed stackset %w"", err)
+ 	}
++	previouslyDeployedConfig.App = appConfig.Name
+ 	return previouslyDeployedConfig, nil
+ }
+ ",Why did we make this change? How come it wasn't an issue before,Not sure what the right thing to do here is.
+552,"@@ -4342,14 +4342,11 @@ TEST_F(VkLayerTest, InvalidDescriptorSet) {
+     // ObjectTracker should catch this.
+     // Create a valid cmd buffer
+     // call vk::CmdBindDescriptorSets w/ false Descriptor Set
++    ASSERT_NO_FATAL_FAILURE(Init());
+
+     uint64_t fake_set_handle = 0xbaad6001;
+     VkDescriptorSet bad_set = reinterpret_cast<VkDescriptorSet &>(fake_set_handle);
+
+-    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdBindDescriptorSets-pDescriptorSets-parameter"");
+-
+-    ASSERT_NO_FATAL_FAILURE(Init());
+-
+     VkDescriptorSetLayoutBinding layout_binding = {};
+     layout_binding.binding = 0;
+     layout_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;",Can you tighten scope by moving to of these variables? i.e. Move to ~4372?,Is this not needed anymore?
+553,"@@ -90,7 +90,7 @@ public class RDATAFileReader extends TabularDataFileReader {
+   // RServe static variables
+   private static String RSERVE_HOST = System.getProperty(""dataverse.rserve.host"");
+   private static String RSERVE_USER = System.getProperty(""dataverse.rserve.user"");
+-  private static String RSERVE_PASSWORD = System.getProperty(""dataverse.rserve.pwrd"");
++  private static String RSERVE_PASSWORD = System.getProperty(""dataverse.rserve.password"");
+   private static int RSERVE_PORT;
+
+   // TODO: ",Nice to see this `dataverse.rserve.password` fix rolled in.,pwrd -> password ?
+554,"@@ -273,7 +273,7 @@ int parse_args(int argc, char *argv[])
+ 				break;
+ 			endptr = NULL;
+ 			config.target.bus = (int) strtoul(tmp_optarg, &endptr, 0);
+-			if (endptr != tmp_optarg + strlen(tmp_optarg)) {
++			if (endptr != tmp_optarg + strnlen_s(tmp_optarg, sizeof(tmp_optarg))) {
+ 				fprintf(stderr, ""invalid bus: %s\n"", tmp_optarg);
+ 				return -1;
+ 			}","How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\0' || *endptr != '\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\0') or invalid (`endptr` points to something other that a '\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though.",This should probably be `si
+555,"@@ -7,6 +7,7 @@ class FeedbackMailer < ApplicationMailer
+       to: self.class.support_email,
+       subject: 'Feedback submission',
+       from: from,
++      cc: from,
+       body: message
+     )
+   end","I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different.",Why not include the email a
+556,"@@ -32,13 +32,12 @@ describe('useEffect', () => {
+ 			return null;
+ 		}
+
+-		render(<Comp />, scratch);
+-		render(<Comp />, scratch);
+-
+-		expect(cleanupFunction).to.be.not.called;
+-		expect(callback).to.be.calledOnce;
++		act(() => {
++			render(<Comp />, scratch);
++			render(<Comp />, scratch);
++		});
+
+-		render(<Comp />, scratch);
++		act(() => render(<Comp />, scratch));
+
+ 		expect(cleanupFunction).to.be.calledOnce;
+ 		expect(callback).to.be.calledTwice;",I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(,"Can these `render` calls be replaced with `render(<Comp />, ...)`?"
+557,"@@ -632,8 +632,13 @@ void nano::active_transactions::update_difficulty (std::shared_ptr<nano::block>
+ 			{
+ 				node.logger.try_log (boost::str (boost::format (""Block %1% was updated from difficulty %2% to %3%"") % block_a->hash ().to_string () % nano::to_string_hex (existing_election->difficulty) % nano::to_string_hex (difficulty)));
+ 			}
+-			roots.get<tag_root> ().modify (existing_election, [difficulty](nano::conflict_info & info_a) {
++			roots.get<tag_root> ().modify (existing_election, [election = existing_election->election, &block_a, difficulty](nano::conflict_info & info_a) {
+ 				info_a.difficulty = difficulty;
++				election->blocks[block_a->hash ()] = block_a;
++				if (election->status.winner->hash () == block_a->hash ())
++				{
++					election->status.winner = block_a;
++				}
+ 			});
+ 			adjust_difficulty (block_a->hash ());
+ 		}","Could use election from `info_a.election`, or is this deliberate?",`if (election->status.winner->hash() == block_a->hash())`
+558,"@@ -95,6 +95,15 @@ class EasyAdminExtension extends AbstractTypeExtension
+     {
+         return LegacyFormHelper::getType('form');
+     }
++
++    /**
++     * {@inheritdoc}
++     */
++    public static function getExtendedTypes()
++    {
++        // needed to avoid a deprecation when using Symfony 4.2
++        return [LegacyFormHelper::getType('form')];
++    }
+ }
+
+ class_alias('EasyCorp\Bundle\EasyAdminBundle\Form\Extension\EasyAdminExtension', 'JavierEguiluz\Bundle\EasyAdminBundle\Form\Extension\EasyAdminExtension', false);",looks like this should be `return array(LegacyFormHelper::getType('form'));`,Move to the `FormHelper` class
+559,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?,I think this is a bug in the code. `assert` is a bit confusing. Ca
+560,"@@ -223,10 +223,9 @@ Blockly.ScratchBlocks.VerticalExtensions.SCRATCH_EXTENSION = function() {
+ Blockly.ScratchBlocks.VerticalExtensions.registerAll = function() {
+   var categoryNames =
+       ['control', 'data', 'data_lists', 'sounds', 'motion', 'looks', 'event',
+-      'sensing', 'pen', 'operators', 'more'];
++        'sensing', 'pen', 'operators', 'more'];
+   // Register functions for all category colours.
+-  for (var i = 0; i < categoryNames.length; i++) {
+-    name = categoryNames[i];
++  for (var i = 0, name; name = categoryNames[i]; i++) {
+     Blockly.Extensions.register('colours_' + name,
+         Blockly.ScratchBlocks.VerticalExtensions.colourHelper(name));
+   }",Where was `name` being declared before?,Nit: This line is a bit too long.
+561,"@@ -74,6 +74,18 @@ func (t testHelper) UnavailableDeployment() *appsv1.Deployment {
+ 	return d
+ }
+
++func (t testHelper) UnknownDeployment() *appsv1.Deployment {
++	d := &appsv1.Deployment{}
++	d.Name = ""unknown""
++	d.Status.Conditions = []appsv1.DeploymentCondition{
++		{
++			Type:   appsv1.DeploymentAvailable,
++			Status: ""Unknown"",
++		},
++	}
++	return d
++}
++
+ func (t testHelper) ReadyBrokerCellStatus() *BrokerCellStatus {
+ 	bs := &BrokerCellStatus{}
+ 	bs.PropagateIngressAvailability(t.AvailableEndpoints())",nit: use `corev1.ConditionUnknown`,Why can't this just return `&apps
+562,"@@ -997,7 +997,10 @@ Mongoose.prototype.isValidObjectId = function(v) {
+     v = v.toString();
+   }
+
+-  if (typeof v === 'string' && (v.length === 12 || v.length === 24)) {
++  if (typeof v === 'string' && v.length === 12) {
++    return true;
++  }
++  if (typeof v === 'string' && v.length === 24 && /^[a-f0-9]*$/.test(v)) {
+     return true;
+   }
+ ","You also need to add a similar check on line 992, there's another place where we check `length === 24`",`typeof v === 'string'` means `ty
+563,"@@ -105,9 +105,14 @@ public class BftBlockCreatorFactory {
+   public Bytes createExtraData(final int round, final BlockHeader parentHeader) {
+     final BftContext bftContext = protocolContext.getConsensusState(BftContext.class);
+     final ValidatorProvider validatorProvider = bftContext.getValidatorProvider();
+-    checkState(validatorProvider.getVoteProvider().isPresent(), ""Bft requires a vote provider"");
++    checkState(
++        validatorProvider.getVoteProviderAfterBlock(parentHeader).isPresent(),
++        ""Bft requires a vote provider"");
+     final Optional<ValidatorVote> proposal =
+-        validatorProvider.getVoteProvider().get().getVoteAfterBlock(parentHeader, localAddress);
++        validatorProvider
++            .getVoteProviderAfterBlock(parentHeader)
++            .get()
++            .getVoteAfterBlock(parentHeader, localAddress);
+
+     final List<Address> validators =
+         new ArrayList<>(validatorProvider.getValidatorsAfterBlock(parentHeader));",nit: can extract the voteProvider as a local variable,why not just use `validatorProvid
+564,"@@ -1190,14 +1190,8 @@ public class QueryEqualityTest extends SolrTestCaseJ4 {
+     assertFuncEquals(""gte(foo_i,2)"", ""gte(foo_i,2)"");
+     assertFuncEquals(""eq(foo_i,2)"", ""eq(foo_i,2)"");
+
+-    boolean equals = false;
+-    try {
+-      assertFuncEquals(""eq(foo_i,2)"", ""lt(foo_i,2)"");
+-      equals = true;
+-    } catch (AssertionError e) {
+-      //expected
+-    }
+-    assertFalse(equals);
++    expectThrows(AssertionError.class, ""expected error, functions are not equal"",
++        () -> assertFuncEquals(""eq(foo_i,2)"", ""lt(foo_i,2)""));
+   }
+
+   public void testChildField() throws Exception {","[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`","This should be rewritten as `expectThrows(AssertionError.class, ""expected error, functions are not equal"")`."
+565,"@@ -61,3 +61,19 @@ func (bc *Blockchain) GetAccountantFee(accountantAddress common.Address) (uint16
+
+ 	return res.Value, err
+ }
++
++// IsRegistered checks wether the given identity is registered or not
++func (bc *Blockchain) IsRegistered(registryAddress, addressToCheck common.Address) (bool, error) {
++	caller, err := bindings.NewRegistryCaller(registryAddress, bc.client)
++	if err != nil {
++		return false, errors.Wrap(err, ""could not create registry caller"")
++	}
++
++	ctx, cancel := context.WithTimeout(context.Background(), bc.bcTimeout)
++	defer cancel()
++
++	res, err := caller.IsRegistered(&bind.CallOpts{
++		Context: ctx,
++	}, addressToCheck)
++	return res, errors.Wrap(err, ""could not check registration status"")
++}",why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?,The caller should have a timeout if the timeout is exceeded.
+566,"@@ -2,7 +2,7 @@ import { pathOr, curry, merge } from 'ramda';
+
+ /**
+  * Flattens a property path so that its fields are spread out into the provided object.
+- *
++ * It's like {@link RA.spreadPath|spreadPath}, but preserves object under property path
+  *
+  * @func flattenPath
+  * @memberOf RA",`.` at the end of the sentence,`It's` -> `It's`
+567,"@@ -284,12 +284,16 @@ func (s *Service) checkAndAddPeers(ctx context.Context, peers pb.Peers) {
+ 			ctx, cancel := context.WithTimeout(ctx, pingTimeout)
+ 			defer cancel()
+
++			start := time.Now()
++
+ 			// check if the underlay is usable by doing a raw ping using libp2p
+ 			if _, err = s.streamer.Ping(ctx, multiUnderlay); err != nil {
++				s.metrics.PingTime.Observe(float64(time.Since(start).Milliseconds()))
+ 				s.metrics.UnreachablePeers.Inc()
+ 				s.logger.Debugf(""hive: peer %s: underlay %s not reachable"", hex.EncodeToString(newPeer.Overlay), multiUnderlay)
+ 				return
+ 			}
++			s.metrics.PingTime.Observe(float64(time.Since(start).Milliseconds()))
+
+ 			bzzAddress := bzz.Address{
+ 				Overlay:     swarm.NewAddress(newPeer.Overlay),",wouldn't it be useful to split this into an error metric for the timing?,You can use `s.metrics.SwarmPingTime.Observe(float64(time.Since(start).Milliseconds()))`
+568,"@@ -47,4 +47,8 @@ class TestFakerName < Test::Unit::TestCase
+     assert @tester.initials.match(/[A-Z]{3}/)
+     assert @tester.initials(2).match(/[A-Z]{2}/)
+   end
++
++  def test_fictional_character_name
++  assert @tester.fictional_character_name.match(/\w+/)
++  end
+ end","Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator...",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+569,"@@ -1293,6 +1293,8 @@ func newTestCFSM(
+ 				MintNewSecretBlock(gomock.Any(), gomock.Any(), gomock.Any()).Return(secretBlkToMint, nil).AnyTimes()
+ 			blockchain.EXPECT().
+ 				Nonce(gomock.Any()).Return(uint64(0), nil).AnyTimes()
++			blockchain.EXPECT().
++				MintNewBlockWithActionIterator(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(blkToMint, nil).AnyTimes()
+ 			if mockChain == nil {
+ 				candidates := make([]*state.Candidate, 0)
+ 				for _, delegate := range delegates {",line is 138 characters,why not use a mock here?
+570,"@@ -75,8 +75,9 @@ type Params struct {
+ 	TraceOpts []ocsql.TraceOption
+ }
+
+-// Open opens a Cloud SQL database.
+-func Open(ctx context.Context, certSource proxy.CertSource, params *Params) (*sql.DB, error) {
++// Open opens a Cloud SQL database. The second return value is a Wire cleanup
++// function that calls Close on the returned database.
++func Open(ctx context.Context, certSource proxy.CertSource, params *Params) (*sql.DB, func(), error) {
+ 	// TODO(light): Avoid global registry once https://github.com/go-sql-driver/mysql/issues/771 is fixed.
+ 	dialerCounter.mu.Lock()
+ 	dialerNum := dialerCounter.n",Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it.,Why do we need a cleanup function here?
+571,"@@ -14,10 +14,14 @@
+  */
+ package com.google.api.codegen.transformer.ruby;
+
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",Nit: each field can be on a separate line to make it visually easier to read.,This seems to be the only change in this file. Is it accidental?
+572,"@@ -336,6 +336,7 @@ def get_analysis_statistics(inputs, limits):
+                     statistics_files.append(compilation_db)
+             elif inp_f in ['compiler_includes.json',
+                            'compiler_target.json',
++                           'compiler_info.json',
+                            'metadata.json']:
+                 analyzer_file = os.path.join(input_path, inp_f)
+                 statistics_files.append(analyzer_file)",Do we still have these files? Shouldn't we remove these?,"I think metadata.json should go a bit further, so we don't need to add it to the list here."
+573,"@@ -22,6 +22,11 @@ import (
+ 	""github.com/jetstack/cert-manager/pkg/apis/certmanager/v1alpha1""
+ )
+
++ const (
++ 	// Error reason generated when duration or renewBefore is invalid
++	ErrorDurationInvalid = ""ErrDurationInvalid""
++)
++
+ type Interface interface {
+ 	// Setup initialises the issuer. This may include registering accounts with
+ 	// a service, creating a CA and storing it somewhere, or verifying","A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?",nit: missing a `.` at the end of the const name
+574,"@@ -171,7 +171,9 @@ var (
+ 			RepeatDecayStep:       1,
+ 		},
+ 		Dispatcher: Dispatcher{
+-			EventChanSize: 10000,
++			ActionChanSize:    1000,
++			BlockChanSize:     1000,
++			BlockSyncChanSize: 10,
+ 		},
+ 		API: API{
+ 			UseRDS:    false,","is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node",What's the reason for this change?
+575,"@@ -297,7 +297,7 @@ module Bolt
+         errors.each do |error|
+           @logger.warn(error.details['original_error'])
+         end
+-        plans
++        plans.reject { |plan| get_plan_info(plan.first)['private'] }
+       end
+     end
+ ",A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective.,Rails/FindEach: Use find_each instead of each.
+576,"@@ -19,3 +19,9 @@ const (
+ 	BUTTON3 = 15
+ 	BUTTON4 = 16
+ )
++
++// UART pins for NRF52840-DK
++const (
++	UART_TX_PIN = 6
++	UART_RX_PIN = 8
++)","These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?","8 is the same as 8+2, 8 is the same as 2"
+577,"@@ -1089,6 +1089,13 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+           ""Specifies the static node file containing the static nodes for this node to connect to"")
+   private final Path staticNodesFile = null;
+
++  @SuppressWarnings({""FieldCanBeFinal"", ""FieldMayBeFinal""}) // PicoCLI requires non-final Strings.
++  @CommandLine.Option(
++          names = { ""--dns-discovery-url"" },
++          description = ""Specifies the URL to use for DNS discovery""
++  )
++  private String dnsDiscoveryUrl = null;
++
+   private EthNetworkConfig ethNetworkConfig;
+   private JsonRpcConfiguration jsonRpcConfiguration;
+   private GraphQLConfiguration graphQLConfiguration;",Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?,Why not make this final?
+578,"@@ -1,3 +1,4 @@
++//go:build !ignore_autogenerated
+ // +build !ignore_autogenerated
+
+ /*",why is this needed?,Why is this needed?
+579,"@@ -23,7 +23,7 @@ DEFAULT_TYPE_ATTRIBUTES = ConfigTypeAttributes()
+
+
+ class ConfigType(object):
+-    def __init__(self, name=None, type_attributes=DEFAULT_TYPE_ATTRIBUTES, description=None):
++    def __init__(self, key, name, type_attributes=DEFAULT_TYPE_ATTRIBUTES, description=None):
+
+         type_obj = type(self)
+         if type_obj in ConfigType.__cache:","I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1.",You need to add `# type: ignore` and `#
+580,"@@ -110,6 +110,7 @@ public final class ThriftCodec implements Codec {
+     final Field IPV4 = new Field(TYPE_I32, 1);
+     final Field PORT = new Field(TYPE_I16, 2);
+     final Field SERVICE_NAME = new Field(TYPE_STRING, 3);
++    final Field IPV6 = new Field(TYPE_STRING, 4);
+
+     @Override
+     public Endpoint read(ByteBuffer bytes) {",@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?,Shouldn't we be able to read IPV6 from the endpoint object?
+581,"@@ -506,7 +506,7 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
+ ReturnValue Game::getPlayerByNameWildcard(const std::string& s, Player*& player)
+ {
+ 	size_t strlen = s.length();
+-	if (strlen == 0 || strlen > 20) {
++	if (strlen == 0 || strlen > PLAYER_NAME_LENGHT) {
+ 		return RETURNVALUE_PLAYERWITHTHISNAMEISNOTONLINE;
+ 	}
+ ","spelling (variable name, all three changes)",I'm not sure if this check is needed at all. If the player
+582,"@@ -411,8 +411,16 @@ type KeybaseService interface {
+ 		[]keybase1.PublicKey, error)
+
+ 	// LoadTeamPlusKeys returns a TeamInfo struct for a team with the
+-	// specified TeamID.
+-	LoadTeamPlusKeys(ctx context.Context, tid keybase1.TeamID) (TeamInfo, error)
++	// specified TeamID.  The caller can specify `desiredKeyGen` to
++	// force a server check if that particular key gen isn't yet
++	// known; it may be set to UnspecifiedKeyGen if no server check is
++	// required.  The caller can specify `desiredUID` to force a
++	// server check if that particular UID isn't a member of the team
++	// yet according to local caches; it may be set to """" if no server
++	// check is required.
++	LoadTeamPlusKeys(ctx context.Context, tid keybase1.TeamID,
++		desiredKeyGen KeyGen, desiredUser keybase1.UserVersion,
++		desiredRole keybase1.TeamRole) (TeamInfo, error)
+
+ 	// CurrentSession returns a SessionInfo struct with all the
+ 	// information for the current session, or an error otherwise.","I believe you meant ""specify `desiredUID` and `desiredRole`""?",`desiredUID` instead of `desiredKeyGen`?
+583,"@@ -16,10 +16,9 @@ package openflow
+
+ import (
+ 	""fmt""
++	""github.com/vmware-tanzu/antrea/pkg/apis/networking/v1beta1""
+ 	""net""
+
+-	coreV1 ""k8s.io/api/core/v1""
+-	v1 ""k8s.io/api/networking/v1""
+ 	""k8s.io/klog""
+
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/types""","Please follow the import style, move it to its similar group","`networking` is already v1beta1, so you can remove this imp"
+584,"@@ -63,3 +63,18 @@ func IsUnrecognizedProcedureError(err error) bool {
+ 	_, ok := err.(errors.UnrecognizedProcedureError)
+ 	return ok
+ }
++
++// UnrecognizedEncodingError returns an error for the given request, such that
++// IsUnrecognizedEncodingError can distinguish it from other errors coming out
++// of router.Choose.
++func UnrecognizedEncodingError(req *Request, want []string) error {
++	return errors.RouterUnrecognizedEncodingError(want, string(req.Encoding))
++}
++
++// IsUnrecognizedEncodingError returns true for errors returned by
++// Router.Choose if the router cannot find a handler for the request's
++// encoding.
++func IsUnrecognizedEncodingError(err error) bool {
++	_, ok := err.(errors.UnrecognizedEncodingError)
++	return ok
++}",Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal,I think this should be `errors.IsUnrecognizedEncodingError`
+585,"@@ -146,11 +146,9 @@ public class PasswordValidatorServiceBean implements java.io.Serializable {
+      * @return A List with error messages. Empty when the password is valid.
+      */
+     public List<String> validate(String password, Date passwordModificationTime, boolean isHumanReadable) {
+-//    public List<String> validate(String password, boolean isHumanReadable) {
+
+         init();
+-        final PasswordData passwordData = PasswordData.newInstance(password, String.valueOf(passwordModificationTime.getTime()), null);
+-//        final PasswordData passwordData = PasswordData.newInstance(password, ""username"", null);
++        final PasswordData passwordData = new PasswordData(password);
+         final RuleResult result = new RuleResult();
+
+         for (PasswordValidator currentUser : validators.values()) {",passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?,Doesn't look like this method was used anywhere. Can we rem
+586,"@@ -40,7 +40,7 @@ namespace ScenarioMeasurement
+
+                 source.Kernel.ProcessStart += evt =>
+                 {
+-                    if (processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine == commandLine)
++                    if (processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine.Trim() == commandLine.Trim())
+                     {
+                         if (pid.HasValue)
+                         {","Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?",I don't think trimming is required here. `pids.Contains(evt
+587,"@@ -115,7 +115,7 @@ var _ = Describe(""with running container"", func() {
+ 		It(""iptables should succeed in getting the lock after 3s"", func() {
+ 			iptCmd := cmdInContainer(""iptables"", ""-w"", ""3"", ""-A"", ""FORWARD"")
+ 			out, err := iptCmd.CombinedOutput()
+-			Expect(string(out)).To(ContainSubstring(""Another app is currently holding the xtables lock""))
++			log.Printf(""iptables output='%s'"", out)
+ 			Expect(err).NotTo(HaveOccurred())
+ 		})
+ ","Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)",You probably didn't mean to leave this one :)
+588,"@@ -155,13 +155,14 @@ Blockly.FlyoutButton.prototype.createDom = function() {
+       this.svgGroup_);
+   svgText.textContent = this.text_;
+
+-  this.width = svgText.getComputedTextLength() +
+-      2 * Blockly.FlyoutButton.MARGIN;
++  this.width = svgText.getComputedTextLength();
+
+   if (!this.isLabel_) {
++    this.width += 2 * Blockly.FlyoutButton.MARGIN;
+     shadow.setAttribute('width', this.width);
+     shadow.setAttribute('height', this.height);
+   }
++
+   rect.setAttribute('width', this.width);
+   rect.setAttribute('height', this.height);
+ ","Hm, this looks like a change that should go upstream as well.","I don't think this is correct, `this.width` will have the same value as `svgText.getComputedTextLength()`"
+589,"@@ -1533,16 +1533,6 @@ func (core *coreService) ChainID() uint32 {
+ 	return core.bc.ChainID()
+ }
+
+-// GetActionByActionHash returns action by action hash
+-func (core *coreService) ActionByActionHash(h hash.Hash256) (action.SealedEnvelope, error) {
+-	if !core.hasActionIndex || core.indexer == nil {
+-		return action.SealedEnvelope{}, status.Error(codes.NotFound, blockindex.ErrActionIndexNA.Error())
+-	}
+-
+-	selp, _, _, _, err := core.getActionByActionHash(h)
+-	return selp, err
+-}
+-
+ // ReadContractStorage reads contract's storage
+ func (core *coreService) ReadContractStorage(ctx context.Context, addr address.Address, key []byte) ([]byte, error) {
+ 	ctx, err := core.bc.Context(ctx)",let's keep ActionByActionHash and delete getActionByActionHash,why remove this?
+590,"@@ -64,4 +64,12 @@ class ProductVisibility
+     {
+         return $this->visible;
+     }
++
++    /**
++     * @return \Shopsys\FrameworkBundle\Model\Pricing\Group\PricingGroup
++     */
++    public function getPricingGroup(): PricingGroup
++    {
++        return $this->pricingGroup;
++    }
+ }",please use return type,You don't need the `use` statement since it's already imported.
+591,"@@ -76,7 +76,7 @@ public class TestEdgeDriver extends RemoteWebDriver implements WebStorage, Locat
+                 .findFirst().orElseThrow(WebDriverException::new);
+
+         service = (EdgeDriverService) builder.withVerbose(true).withLogFile(logFile.toFile()).build();
+-        LOG.info(""edgedriver will log to "" + logFile);
++        LOG.fine(""edgedriver will log to "" + logFile);
+         service.start();
+         Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));
+       }",This is deliberately at this level.,This should be a warn as well.
+592,"@@ -237,7 +237,7 @@ class UploadWorkerThread(TransferThread):
+             except self._retry_exceptions as e:
+                 log.error(""Exception caught uploading part number %s for ""
+                           ""vault %s, attempt: (%s / %s), filename: %s, ""
+-                          ""exception: %s, msg: %s"",
++                          ""exception: %s as msg: %s"",
+                           work[0], self._vault_name, i + 1, self._num_retries + 1,
+                           self._filename, e.__class__, e)
+                 time.sleep(self._time_between_retries)","I'm going to go ahead and undo this change, I don't think it was intentional.","""as msg"" seems like a stray typo"
+593,"@@ -163,7 +163,7 @@ namespace Datadog.AutoInstrumentation.ManagedLoader
+         /// As a result, the target framework moniker and the binary compatibility flags are initialized correctly.
+         /// </summary>
+         /// <remarks>
+-        /// The above logic is further specialised, depending on the kind of the currnent AppDomain and where the app is hosted:
++        /// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted:
+         /// <br />
+         /// * On non-default AD:
+         ///   we do not wait.",> specialised This isn't a typo in my neck of the woods  ,This is an API break. Please und
+594,"@@ -29,6 +29,7 @@ import (
+
+ var packages = []string{
+ 	""github.com/google/knative-gcp/test/cmd/target"",
++	""github.com/google/knative-gcp/test/cmd/storageTarget"",
+ }
+
+ var packageToImageConfig = map[string]string{}",will change to `storage_target`,can we also update this to `v1al
+595,"@@ -38,7 +38,7 @@ class SecurityCenterTest(unittest_utils.ForsetiTestCase):
+         """"""Set up.""""""
+         fake_global_configs = {
+             'securitycenter': {'max_calls': 1, 'period': 1.1}}
+-        cls.securitycenter_beta_api_client = securitycenter.SecurityCenterClient(version='v1beta1')
++        cls.securitycenter = securitycenter.SecurityCenterClient(version='v1')
+         cls.project_id = 111111
+         cls.source_id = 'organizations/111/sources/222'
+ ","This would be better as `cls.securitycenter_client`, to match what is being instantiated.",Shouldn't this be `cls.securityc
+596,"@@ -34,6 +34,15 @@ import appModules
+ import watchdog
+ import extensionPoints
+ from fileUtils import getFileVersionInfo
++import shlobj
++from functools import wraps
++
++# Path to the native system32 directory.
++nativeSys32: str = shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEM)
++# Path to the syswow64 directory if it exists on the current system.
++Syswow64Sys32: str = shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEMX86)
++# Do we have separate system32 directories for 32 and 64-bit processes?
++hasSeparateSyswow64: bool = nativeSys32 != Syswow64Sys32
+
+ #Dictionary of processID:appModule paires used to hold the currently running modules
+ runningTable={}",Could we have this initialization as part of the initialize method?,"I don't think we have a dedicated `SHGetFolderPath` for this purpose. Instead, we should be able to use `shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEM)` directly."
+597,"@@ -15,7 +15,7 @@ export default AbstractEditController.extend({
+   showUpdateButton: true,
+
+   database: inject.service(),
+-  editController: inject.controller('patients/edit'),
++  editController: null,
+   filesystem: inject.service(),
+
+   photoFileNotSet: computed('model.photoFile', function() {",This line should be removed as editController is not used from this context anymore.,why is this null?
+598,"@@ -9,11 +9,17 @@ import (
+ 	""github.com/influxdata/flux/plan""
+ )
+
++// Transformation represents functions that control of how the execution
++// engine will take in a flux Table, perform the necessary data processing
++// and return an output flux Table
+ type Transformation interface {
+ 	RetractTable(id DatasetID, key flux.GroupKey) error
++	// Process takes in a flux Table, performs data processing on it
++	// and produces an output flux Table
+ 	Process(id DatasetID, tbl flux.Table) error
+ 	UpdateWatermark(id DatasetID, t Time) error
+ 	UpdateProcessingTime(id DatasetID, t Time) error
++	// Finish indicates that the Transformation is complete
+ 	Finish(id DatasetID, err error)
+ }
+ ","This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?",Can you add a note here that this transform is only done with a flux Table?
+599,"@@ -238,9 +238,14 @@ class DetectoRS_ResNet(ResNet):
+                  pretrained=None,
+                  init_cfg=None,
+                  **kwargs):
+-        assert init_cfg is None, 'To prevent abnormal initialization ' \
+-                                 'behavior, init_cfg is not allowed to be set'
+-        self.pretrained = pretrained
++        self.init_cfg = init_cfg
++        if init_cfg is not None:  # init_cfg priority > pretrained
++            self.pretrained = init_cfg['checkpoint']
++        else:
++            if pretrained is not None:
++                self.pretrained = pretrained
++            else:
++                self.pretrained = None
+         self.sac = sac
+         self.stage_with_sac = stage_with_sac
+         self.rfp_inplanes = rfp_inplanes","For insurance, it's best not to take it directly",can you explain why this change?
+600,"@@ -67,11 +67,11 @@ public abstract class AbstractWebDriverEventListener implements WebDriverEventLi
+     // Do nothing.
+   }
+
+-  public void beforeChangeValueOf(WebElement element, WebDriver driver) {
++  public void beforeChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) {
+     // Do nothing.
+   }
+
+-  public void afterChangeValueOf(WebElement element, WebDriver driver) {
++  public void afterChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) {
+     // Do nothing.
+   }
+ ","change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it.","`driver` is an element, but `value` is an array"
+601,"@@ -1244,6 +1244,8 @@ func (engine *DockerTaskEngine) provisionContainerResources(task *apitask.Task,
+ 	taskIP := result.IPs[0].Address.IP.String()
+ 	seelog.Infof(""Task engine [%s]: associated with ip address '%s'"", task.Arn, taskIP)
+ 	engine.state.AddTaskIPAddress(taskIP, task.Arn)
++	task.SetLocalIPAddress(taskIP)
++	engine.saveTaskData(task)
+ 	return dockerapi.DockerContainerMetadata{
+ 		DockerID: cniConfig.ContainerID,
+ 	}",is the plan to fully migrate to boltdb and then remove the state save here?,Where is the call to `saveTaskData` used?
+602,"@@ -153,6 +153,8 @@ function themeStyle(theme) {
+
+ 		output.colorUrl = '#7B81FF';
+
++		output.strongTextColor = 'rgb(220,220,220)';
++
+ 		themeCache_[theme] = output;
+ 		return addExtraStyles(themeCache_[theme]);
+ 	}",This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable.,Did you mean to add this to the list of themes?
+603,"@@ -6,6 +6,11 @@
+
+ import os
+
++version_year=2016
++version_major=3
++version_minor=0
++version_build=0
++
+ def _updateVersionFromVCS():
+ 	""""""Update the version from version control system metadata if possible.
+ 	""""""","nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place.",you don't need to define this here since it's o
+604,"@@ -99,7 +99,7 @@ const LanguageParameters& GetLangParams(IDLOptions::Language lang) {
+       """",
+       """",
+       """",
+-      ""import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\n""
++      ""import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\nimport javax.annotation.*;\n""
+         ""import com.google.flatbuffers.*;\n\n@SuppressWarnings(\""unused\"")\n"",
+       {
+         ""/**"",",Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?,"I am not sure if this is correct. If `javax.annotation` is not found, then `java.nio.charset.StandardCharsets` must be used instead."
+605,"@@ -50,8 +50,8 @@ class Phase < ActiveRecord::Base
+   has_many :suffix_sections, -> (phase) {
+     modifiable.where(<<~SQL, phase_id: phase.id, modifiable: false)
+       sections.number > (SELECT MAX(number) FROM sections
+-                           WHERE sections.modifiable = :modifiable)
+-                           AND sections.phase_id = :phase_id
++                           WHERE sections.modifiable = :modifiable
++                           AND sections.phase_id = :phase_id)
+     SQL
+   }, class_name: ""Section""
+ ",@briri Thanks! I just caught this too updating my feature branch,Is this part of this PR? It doesn't seem related to this task.
+606,"@@ -214,8 +214,17 @@ var errorConfigFileNotFound = errors.New(""config file not found"")
+ // automatically decrypt it.
+ func loadConfigFile() (*goconfig.ConfigFile, error) {
+ 	b, err := ioutil.ReadFile(ConfigPath)
++	envpw := os.Getenv(""RCLONE_CONFIG_PASS"")
+ 	if err != nil {
+ 		if os.IsNotExist(err) {
++			if len(configKey) == 0 && envpw != """" {
++				err := setConfigPassword(envpw)
++				if err != nil {
++					fmt.Println(""Using RCLONE_CONFIG_PASS returned:"", err)
++				} else {
++					fs.Debugf(nil, ""Using RCLONE_CONFIG_PASS password."")
++				}
++			}
+ 			return nil, errorConfigFileNotFound
+ 		}
+ 		return nil, err","I think you should move this block (and the `envpw := os.Getenv(""RCLONE_CONFIG_PASS"")`) right to the start of the function, then we can remove the duplicate code below",This won't work if the RCLONE_CONFIG_PASS environment variable has been set. The RCLONE_CONFIG_PASS environment variable will have p
+607,"@@ -424,6 +424,17 @@ public class NodeTest {
+     return baseDir;
+   }
+
++  //Test that the draining command sets Host status to DRAINING
++  @Test
++  public void drainingNodeStatusDraining() {
++
++  }
++
++  //Test that a draining node doesn't accept new sessions by any means
++  //Test that a draining node continues to run its sessions and accept new WebDriver commands
++  //Test that a node will shut down once all sessions are finished
++  //Test that RemoteNode will post the correct command oto the LocalNode
++
+   private CreateSessionRequest createSessionRequest(Capabilities caps) {
+     return new CreateSessionRequest(
+             ImmutableSet.copyOf(Dialect.values()),",Is this only to set the node to draining?   I think we can do that inside `Before` or something?,"What's wrong with ""Test that a draining node will post the correct command""?"
+608,"@@ -647,6 +647,11 @@ namespace Datadog.Trace
+             {
+                 try
+                 {
++                    if (AzureAppServices.Metadata.IsRelevant)
++                    {
++                        return AzureAppServices.Metadata.SiteName;
++                    }
++
+                     if (TryLoadAspNetSiteName(out var siteName))
+                     {
+                         return siteName;",This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this.,"This is the site name, not the creative name."
+609,"@@ -43,12 +43,13 @@ module Bolt
+       Bolt::ResultSet.include_iterable
+     end
+
+-    # Create a top-level alias for TargetSpec so that users don't have to
++    # Create a top-level alias for TargetSpec and PlanResult so that users don't have to
+     # namespace it with Boltlib, which is just an implementation detail. This
+-    # allows TargetSpec to feel like a built-in type in bolt, rather than
++    # allows them to feel like a built-in type in bolt, rather than
+     # something has been, no pun intended, ""bolted on"".
+-    def add_target_spec(compiler)
++    def alias_types(compiler)
+       compiler.evaluate_string('type TargetSpec = Boltlib::TargetSpec')
++      compiler.evaluate_string('type PlanResult = Boltlib::PlanResult')
+     end
+
+     def full_modulepath(modulepath)",Do we expect people to use PlanResult directly?,This was not strictly necessary before becaus
+610,"@@ -48,7 +48,8 @@ func NewBackoff() wait.Backoff {
+
+ // WaitForWithRetryable repeats a condition check with exponential backoff.
+ func WaitForWithRetryable(backoff wait.Backoff, condition wait.ConditionFunc, retryableErrors ...string) error { //nolint
+-	return wait.ExponentialBackoff(backoff, func() (bool, error) {
++	var actualErr error
++	waitErr := wait.ExponentialBackoff(backoff, func() (bool, error) {
+ 		ok, err := condition()
+ 		if ok {
+ 			// All done!",Maybe we should call this something like `errToReturn`?,I don't think it's necessary to use `var` as
+611,"@@ -215,7 +215,8 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch {
++	fairBankEpochNum := rp.GetEpochNum(hu.FairbankBlockHeight()) // extend foundation bonus from fairbank to fairbank + 1 year
++	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= fairBankEpochNum && epochNum <= fairBankEpochNum+a.foundationBonusLastEpoch) {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that",this is wrong. it should be `<=`
+612,"@@ -350,14 +350,17 @@ const htmlElms = {
+       },
+       usemap: {
+         matches: '[usemap]',
+-        contentTypes: ['interactive', 'embedded', 'phrasing', 'flow']
++        contentTypes: ['interactive', 'embedded', 'flow']
+       },
+       default: {
+         // Note: allow role presentation and none on image with no
+         // alt as a way to prevent axe from flagging the image as
+         // needing an alt
+         allowedRoles: ['presentation', 'none'],
+-        contentTypes: ['embedded', 'phrasing', 'flow']
++        // Note: spec change (do not count as phrasing), because browsers
++        // insert a space between an img's accessible name and other
++        // elements' accessible names
++        contentTypes: ['embedded', 'flow']
+       }
+     },
+     // 5.10 img Element",I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used.,Is there a reason we're not using `phrasing` here?
+613,"@@ -20,11 +20,13 @@
+ """"""
+ Geneve: Generic Network Virtualization Encapsulation
+
+-draft-ietf-nvo3-geneve-06
++draft-ietf-nvo3-geneve-16
+ """"""
+
++import struct
++
+ from scapy.fields import BitField, XByteField, XShortEnumField, X3BytesField, \
+-    XStrField
++    XStrField, XShortField, StrField, XByteField, FieldLenField, PacketListField
+ from scapy.packet import Packet, bind_layers
+ from scapy.layers.inet import IP, UDP
+ from scapy.layers.inet6 import IPv6","Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used",Why was this file changed? It appears to be unrela
+614,"@@ -630,6 +630,18 @@ class FilenamePrompt(_BasePrompt):
+
+         self._to_complete = ''
+
++    def _directories_hide_show_model(self, path):
++        """"""Get rid of non-matching directories.""""""
++        try:
++            num_rows = self._file_model.rowCount(self._root_index)
++            for row in range(num_rows):
++                index = self._file_model.index(row, 0, self._file_model.index(path))
++                hidden = self._to_complete not in index.data()
++                self._file_view.setRowHidden(index.row(), index.parent(), hidden)
++        except FileNotFoundError:
++            log.prompt.debug(""Directory doesn't exist, can't \
++                                hide and unhide file prompt folders"")
++
+     @pyqtSlot(str)
+     def _set_fileview_root(self, path, *, tabbed=False):
+         """"""Set the root path for the file display.""""""","I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?",Is there a reason not to just do `self._to_complet
+615,"@@ -75,6 +75,8 @@ public class DirectSpellChecker {
+   private float thresholdFrequency = 0f;
+   /** minimum length of a query word to return suggestions */
+   private int minQueryLength = 4;
++  /** maximum length of a query word to return suggestions */
++  private int maxQueryLength = 0;
+   /** value in [0..1] (or absolute number &gt;= 1) representing the maximum
+    *  number of documents (of the total) a query term can appear in to
+    *  be corrected. */",Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?,"This should be minQueryLength, not maxQueryLength."
+616,"@@ -81,7 +81,7 @@ namespace NLog.LayoutRenderers
+         {
+             if (TopFrames == 1)
+             {
+-                // Allows fast rendering of ${when:when='${ndc:topframes=1}' == '':inner=:else=${ndc}|}
++                // Allows fast rendering of ${ndc:topframes=1}
+                 var topFrame = NestedDiagnosticsContext.PeekObject();
+                 if (topFrame != null)
+                     AppendAsString(topFrame, GetFormatProvider(logEvent), builder);",:+1: that's a easier example :),Is this a typo? Should it be `${ndc:topframes=1}`?
+617,"@@ -117,4 +117,9 @@ interface ProductQueryInterface
+      * @return AttributeId[]
+      */
+     public function findAttributeIdsByProductId(ProductId $productId): array;
++
++    /**
++     * @return array
++     */
++    public function findProductIdsWithBoundAttributeByAttributeId(AggregateId $id): array;
+ }","If an external module decorates this interface, such a change will cause it to generate an error",We could add a phpdoc here to explain what this fu
+618,"@@ -254,7 +254,7 @@ static int jobtap_remove (struct jobtap *jobtap,
+     while (p) {
+         const char *name = jobtap_plugin_name (p);
+         if (all
+-            || (isglob && fnmatch (arg, name, 0) == 0)
++            || (isglob && fnmatch (arg, name, FNM_PERIOD) == 0)
+             || strcmp (arg, name) == 0) {
+             zlistx_detach_cur (jobtap->plugins);
+             flux_plugin_destroy (p);","Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention.","` FNM_PERIOD` is not a valid glob specifier, so it"
+619,"@@ -7,11 +7,12 @@
+ package action
+
+ import (
++	""encoding/hex""
+ 	""fmt""
+-	""math/big""
+-
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""
++	""math/big""
++	""strings""
+
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/account""","wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group.",Did you run `make fmt` on this file?
+620,"@@ -78,8 +78,10 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) {
+ // Validate returns an error if the values provided by flags are invalid.
+ func (o *jobLogsOpts) Validate() error {
+ 	if o.appName != """" {
+-		_, err := o.configStore.GetApplication(o.appName)
+-		if err != nil {
++		if _, err := o.configStore.GetApplication(o.appName); err != nil {
++			return err
++		}
++		if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {
+ 			return err
+ 		}
+ 	}",Is `o.name` always set here?,"Shouldn't this be `GetApplication(o.appName, o.name)`?"
+621,"@@ -73,7 +73,8 @@ func dependenciesCanBeResolved(target *api.Container, by []*api.Container) bool
+ 	}
+
+ 	return verifyStatusResolvable(target, nameMap, neededVolumeContainers, volumeCanResolve) &&
+-		verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve)
++		verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve) &&
++		verifyStatusResolvable(target, nameMap, target.SteadyStateDependencies, onSteadyStateCanResolve)
+ }
+
+ // DependenciesAreResolved validates that the `target` container can be","Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?",Does it make sense to verify that the `target.SteadySt
+622,"@@ -73,7 +73,7 @@ class User < ActiveRecord::Base
+   end
+
+   def eligible_for_annual_upgrade?
+-    plan.present? && plan.has_annual_plan?
++    has_active_subscription? && plan.present? && plan.has_annual_plan?
+   end
+
+   def annualized_payment","`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`.",This seems to be unrelated to the PR.
+623,"@@ -100,6 +100,7 @@ class Command:
+         if scope != 'global' and instance is None:
+             raise ValueError(""Setting scope without setting instance makes ""
+                              ""no sense!"")
++        # pylint: enable=too-many-locals
+
+         self.name = name
+         self.maxsplit = maxsplit","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.","could you move this up to the top of the file, please?"
+624,"@@ -188,7 +188,7 @@ func (c *Operator) bootstrap(ctx context.Context) error {
+ 	}
+ 	c.secrInfs, err = informers.NewInformersForResource(
+ 		informers.NewKubeInformerFactories(
+-			c.config.Namespaces.AllowList,
++			c.config.Namespaces.AlertmanagerConfigAllowList,
+ 			c.config.Namespaces.DenyList,
+ 			c.kclient,
+ 			resyncPeriod,",L171 needs to be modified too?,Are you sure you want this change? It seems unrelated.
+625,"@@ -19,6 +19,16 @@ See the file COPYING for details.
+ #include <stdlib.h>
+ #include <unistd.h>
+
++int dag_node_comp(void *item, const void *arg)
++{
++	struct dag_node *d = ((struct dag_node *) item);
++	struct dag_node *e = ((struct dag_node *) arg);
++
++	if(d->nodeid == e->nodeid)
++		return 1;
++	return 0;
++}
++
+ struct dag_node *dag_node_create(struct dag *d, int linenum)
+ {
+ 	struct dag_node *n;","Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong.",(style) space required before the open parenthesis '('
+626,"@@ -0,0 +1,18 @@
++_base_ = [
++    '../_base_/models/retinanet_r50_fpn.py',
++    '../_base_/datasets/coco_detection.py',
++    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
++]
++model = dict(
++    type='RetinaNet',
++    backbone=dict(
++        _delete_=True,
++        type='PyramidVisionTransformer',
++        num_layers=[2, 2, 2, 2],
++        init_cfg=dict(
++            type='Pretrained',
++            checkpoint='https://github.com/whai362/PVT/'
++            'releases/download/v2/pvt_tiny.pth')),
++    neck=dict(in_channels=[64, 128, 320, 512]))
++# optimizer
++optimizer = dict(_delete_=True, type='AdamW', lr=0.0001, weight_decay=0.0001)",configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py,these are the lines in the wrong place
+627,"@@ -20,7 +20,7 @@ type MetadataResponse struct {
+
+ type TaskResponse struct {
+ 	Arn           string
+-	DesiredStatus string
++	DesiredStatus string `json:""DesiredStatus,omitempty""`
+ 	KnownStatus   string
+ 	Family        string
+ 	Version       string","Nit, this could be json:"",omitempty""","The `DesiredStatus` field should have a `json:"",omitem"
+628,"@@ -113,7 +113,12 @@ func tplDirName(s string) string {
+ 	return filepath.Dir(s)
+ }
+
+-//BuildArgs returns a docker.BuildArguments object given a ws root directory.
++// BuildRequired returns if the service requires building from the local Dockerfile.
++func (s *LoadBalancedWebService) BuildRequired() (bool, error) {
++	return buildRequired(s.Image.Image)
++}
++
++// BuildArgs returns a docker.BuildArguments object given a ws root directory.
+ func (s *LoadBalancedWebService) BuildArgs(wsRoot string) *DockerBuildArgs {
+ 	return s.Image.BuildConfig(wsRoot)
+ }",It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?,seems like this should be called `BuildRequired` and the return should be `isBuildRequired` or something.
+629,"@@ -1,4 +1,4 @@
+-// +build integration
++// +build integration,deploy
+
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ // SPDX-License-Identifier: Apache-2.0",nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario,Why is this change needed?
+630,"@@ -4701,8 +4701,8 @@ XS(XS_Mob_HasNPCSpecialAtk) {
+ XS(XS_Mob_SendAppearanceEffect); /* prototype to pass -Wmissing-prototypes */
+ XS(XS_Mob_SendAppearanceEffect) {
+ 	dXSARGS;
+-	if (items < 2 || items > 7)
+-		Perl_croak(aTHX_ ""Usage: Mob::SendAppearanceEffect(THIS, int32 param_1, [int32 param_2 = 0], [int32 param_3 = 0], [int32 param_4 = 0], [int32 param_5 = 0], [Client* single_client_to_send_to = null])""); // @categories Script Utility
++	if (items < 2 || items > 17)
++		Perl_croak(aTHX_ ""Usage: Mob::SendAppearanceEffect(THIS, int32 effect1, [int32 effect2 = 0], [int32 effect3 = 0], [int32 effect4 = 0], [int32 effect5 = 0], [Client* single_client_to_send_to = null]), [uint32 slot1 = 1], [uint32 ground1 = 1], [uint32 slot2 = 1], [uint32 ground2 = 1], [uint32 slot3 = 1], [uint32 ground2 = 1], [uint32 slot4 = 1], [uint32 ground4 = 1], [uint32 slot5 = 1], [uint32 ground5 = 1]""); // @categories Script Utility
+ 	{
+ 		Mob *THIS;
+ 		int32 parm1 = (int32) SvIV(ST(1));",Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others.,"Huh, I don't know that this is the correct place for this. This function is also called for Mob_SendAppea"
+631,"@@ -16,11 +16,12 @@
+
+ using System.Collections.Generic;
+ using Nethermind.Core;
++using Nethermind.Core.Crypto;
+
+ namespace Nethermind.Consensus
+ {
+     public interface IPendingTxSelector
+     {
+-        IEnumerable<Transaction> SelectTransactions(long gasLimit);
++        IEnumerable<Transaction> SelectTransactions(Keccak stateRoot, long gasLimit);
+     }
+ }",stateRoot or maybe ParentHeader would make more sense from API point of view?,The state root is already a `long` so you don't need to specify it here
+632,"@@ -151,7 +151,6 @@ public class PlaybackServiceFlavorHelper {
+                 // hardware volume buttons control the local device volume
+                 mediaRouter.setMediaSessionCompat(null);
+                 unregisterWifiBroadcastReceiver();
+-                callback.setupNotification(false, info);
+             }
+         };
+     }",Are you sure that this is no longer needed?,Why is this being removed?
+633,"@@ -57,7 +57,11 @@ class BaseTableScan implements TableScan {
+   private static final Logger LOG = LoggerFactory.getLogger(TableScan.class);
+
+   private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat(""yyyy-MM-dd HH:mm:ss.SSS"");
+-  private static final List<String> SNAPSHOT_COLUMNS = ImmutableList.of(
++  private static final List<String> SCAN_COLUMNS = ImmutableList.of(
++      ""snapshot_id"", ""file_path"", ""file_ordinal"", ""file_format"", ""block_size_in_bytes"",
++      ""file_size_in_bytes"", ""record_count"", ""partition""
++  );
++  private static final List<String> SCAN_WITH_STATS_COLUMNS = ImmutableList.of(
+       ""snapshot_id"", ""file_path"", ""file_ordinal"", ""file_format"", ""block_size_in_bytes"",
+       ""file_size_in_bytes"", ""record_count"", ""partition"", ""value_counts"", ""null_value_counts"",
+       ""lower_bounds"", ""upper_bounds""","Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.<String>builder().addAll(SCAN_COLUMNS).add(""value_counts"",....).build()` ?",How about `SNAPSHOT_COLUMN
+634,"@@ -85,11 +85,19 @@ func (a *PipedAPI) Register(server *grpc.Server) {
+
+ // Ping is periodically sent to report its realtime status/stats to control-plane.
+ // The received stats will be pushed to the metrics collector.
++// Note: This service is deprecated, use ReportStat instead.
+ func (a *PipedAPI) Ping(ctx context.Context, req *pipedservice.PingRequest) (*pipedservice.PingResponse, error) {
+ 	return &pipedservice.PingResponse{}, nil
+ 	// return nil, status.Error(codes.Unimplemented, """")
+ }
+
++// ReportStat is periodically sent to report its realtime status/stats to control-plane.
++// The received stats will be pushed to the metrics collector.
++func (a *PipedAPI) ReportStat(ctx context.Context, req *pipedservice.ReportStatRequest) (*pipedservice.ReportStatResponse, error) {
++	return &pipedservice.ReportStatResponse{}, nil
++	// return nil, status.Error(codes.Unimplemented, """")
++}
++
+ // ReportPipedMeta is sent by piped while starting up to report its metadata
+ // such as configured cloud providers.
+ func (a *PipedAPI) ReportPipedMeta(ctx context.Context, req *pipedservice.ReportPipedMetaRequest) (*pipedservice.ReportPipedMetaResponse, error) {",`ctx` is unused in ReportStat,I think we should remove t
+635,"@@ -21,12 +21,15 @@
+ #include <fstream>
+ #include <iostream>
+ #include <vector>
++#include <list>
++#include <map>
+
+ #include <stdlib.h>
+ #include <sys/stat.h>
+ #include <sys/types.h>
+ #include <sstream>
+ #include <algorithm>
++
+ #include ""t_generator.h""
+ #include ""platform.h""
+ #include ""version.h""",We don't want to add boost as a dependency when building the Thrift compiler. Sorry.,Please `#include` standard
+636,"@@ -323,7 +323,8 @@ bool Monsters::deserializeSpell(const pugi::xml_node& node, spellBlock_t& sb, co
+ 			combat->setParam(COMBAT_PARAM_TYPE, COMBAT_HEALING);
+ 			combat->setParam(COMBAT_PARAM_AGGRESSIVE, 0);
+ 		} else if (tmpName == ""speed"") {
+-			int32_t speedChange = 0;
++			int32_t minSpeedChange = 0;
++			int32_t maxSpeedChange = 0;
+ 			int32_t duration = 10000;
+
+ 			if ((attr = node.attribute(""duration""))) {",It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000.,Shouldn't be minSpeedChange = 1; ?
+637,"@@ -332,3 +332,15 @@ func (c *clusterClient) SchedPolicyDelete(name string) error {
+
+ 	return nil
+ }
++
++// SchedPolicyGet returns schedule policy matching given name.
++func (c *clusterClient) SchedPolicyGet(name string) (*sched.SchedPolicy, error) {
++	policy := new(sched.SchedPolicy)
++	req := c.c.Get().Resource(clusterPath + SchedPath + ""/"" + name)
++
++	if err := req.Do().Unmarshal(policy); err != nil {
++		return nil, err
++	}
++
++	return policy, nil
++}",if name is empty will this become enumerate ? (and cause the unmarshal to fail ?),I don't think we need this method
+638,"@@ -15,7 +15,7 @@ module ProductsHelper
+     if current_user_has_access_to?(:exercises)
+       link_to url, options, &block
+     else
+-      content_tag ""a"", &block
++      link_to edit_subscription_path, options, &block
+     end
+   end
+ end",How about including a flash message that explains the exercises are only available to subscribers of X plan?,"This is a questionable change, but"
+639,"@@ -232,6 +232,11 @@ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
+         Enter/Shift+Enter/etc. will cause QLineEdit to think it's finished
+         without command_accept to be called.
+         """"""
++        text = self.text()
++        if text in modeparsers.STARTCHARS and e.key() == Qt.Key_Backspace:
++            modeman.leave(self._win_id, usertypes.KeyMode.command,
++                          'prefix deleted')
++
+         if e.key() == Qt.Key_Return:
+             e.ignore()
+             return",You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways).,Is this still relevant if we have
+640,"@@ -0,0 +1,14 @@
++MAIL_SETTINGS = {
++  address: ""smtp.sendgrid.net"",
++  port: ""587"",
++  authentication: :plain,
++  user_name: ENV[""SENDGRID_USERNAME""],
++  password: ENV[""SENDGRID_PASSWORD""],
++  domain: ""heroku.com""
++}
++
++if ENV[""EMAIL_RECIPIENTS""]
++  Mail.register_interceptor(
++    RecipientInterceptor.new(ENV.fetch(""EMAIL_RECIPIENTS"")),
++  )
++end",Freeze mutable objects assigned to constants.,Do we want to use heroku here? Or do we need to use heroku-messagic?
+641,"@@ -34,8 +34,11 @@ import {
+
+ async function toggleOptIn() {
+ 	await page.waitForSelector( '#googlesitekit-opt-in' );
+-	await expect( page ).toClick( '#googlesitekit-opt-in' );
+-	await page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) );
++	await pageWait();
++	await Promise.all( [
++		page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) ),
++		expect( page ).toClick( '#googlesitekit-opt-in' ),
++	] );
+ }
+
+ describe( 'management of tracking opt-in/out via settings page', () => {","Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?",This could just be `await pageWait();`
+642,"@@ -144,6 +144,12 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation
+                 {
+                     activity.SetTag(SemanticConventions.AttributeHttpUserAgent, userAgent);
+                 }
++
++                var xForwardedFor = request.Headers[""X-Forwarded-For""].FirstOrDefault();
++                if (!string.IsNullOrEmpty(xForwardedFor))
++                {
++                    activity.SetTag(SemanticConventions.AttributeHttpClientIP, xForwardedFor.Split(',').First().Trim());
++                }
+             }
+         }
+ ","Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags.",Should this be a constant somewhere?
+643,"@@ -91,7 +91,7 @@ int main(int argc, char *argv[]) {
+     }
+
+     LOG(INFO) << ""Starting Graph HTTP Service"";
+-    nebula::WebService::registerHandler(""/graph"", [] {
++    nebula::WebService::registerHandler(""/status"", [] {
+         return new nebula::graph::GraphHttpHandler();
+     });
+     status = nebula::WebService::start();","`status` is just one of the features, named as status is not suitable.",This is the only change in this file. The rest of the changes are fr
+644,"@@ -296,9 +296,17 @@ public class NavListAdapter extends BaseAdapter
+                 .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
+
+         convertView = inflater.inflate(R.layout.nav_section_item, parent, false);
++        TextView feedsFilteredMsg = convertView.findViewById(R.id.nav_feeds_filtered_message);
+
+-        convertView.setEnabled(false);
+-        convertView.setOnClickListener(null);
++        if (UserPreferences.getFeedFilter() != UserPreferences.FEED_FILTER_NONE) {
++            convertView.setEnabled(true);
++            feedsFilteredMsg.setText(""{md-info-outline} "" + context.getString(R.string.feed_is_filtered));
++            Iconify.addIcons(feedsFilteredMsg);
++            feedsFilteredMsg.setVisibility(View.VISIBLE);
++        } else {
++            convertView.setEnabled(false);
++            feedsFilteredMsg.setVisibility(View.GONE);
++        }
+
+         return convertView;
+     }","There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed.",Can you explain why this change is needed?
+645,"@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""query/useCircuitBreakers"", false);
++    memoryCircuitBreakerThreshold = getInt(""query/memoryCircuitBreakerThreshold"", 100);
++
++    validateMemoryBreakerThreshold();
+
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ","I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate.",This should be `useCircuitBreakers = getBo
+646,"@@ -57,8 +57,6 @@ extern Events* g_events;
+ extern Chat* g_chat;
+ extern LuaEnvironment g_luaEnvironment;
+
+-using ErrorCode = boost::system::error_code;
+-
+ Signals::Signals(boost::asio::io_service& service) :
+ 	set(service)
+ {",move the constructor to down the `namespace`,Why did you remove this?
+647,"@@ -123,6 +123,10 @@ type ClusterDeploymentStatus struct {
+ 	// Federated is true if the cluster deployment has been federated with the host cluster.
+ 	Federated bool `json:""federated,omitempty""`
+
++	// FederatedClusterRef is the reference to the federated cluster resource associated with
++	// this ClusterDeployment
++	FederatedClusterRef *corev1.ObjectReference `json:""federatedClusterRef,omitempty""`
++
+ 	// AdminKubeconfigSecret references the secret containing the admin kubeconfig for this cluster.
+ 	AdminKubeconfigSecret corev1.LocalObjectReference `json:""adminKubeconfigSecret,omitempty""`
+ ",Nit: ending with a '.' looks consistent with the fields around it.,does this need to be a pointer? does not s
+648,"@@ -138,7 +138,7 @@ func (s *Service) MintX509SVID(ctx context.Context, req *svidv1.MintX509SVIDRequ
+ }
+
+ func (s *Service) MintJWTSVID(ctx context.Context, req *svidv1.MintJWTSVIDRequest) (*svidv1.MintJWTSVIDResponse, error) {
+-	rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(req.Id, req.Audience, req.Ttl))
++	rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(ctx, req.Id, req.Audience, req.Ttl))
+ 	jwtsvid, err := s.mintJWTSVID(ctx, req.Id, req.Audience, req.Ttl)
+ 	if err != nil {
+ 		return nil, err","Audit log will not have a warning about they are using a deprecated path, is it something we must care about?","If `s.fieldsFromJWTSvidParams` returns an error, then `s.mintJWTSVID` will fail and so the audit log will not be added. Is this intentional?"
+649,"@@ -23,7 +23,7 @@ namespace Microsoft.Cci.Differs.Rules
+             // If implementation is protected then contract must be protected as well.
+             if (impl.Visibility == TypeMemberVisibility.Family)
+             {
+-                if (contract.Visibility != TypeMemberVisibility.Family)
++                if (contract.Visibility != TypeMemberVisibility.Family && contract.Visibility != TypeMemberVisibility.FamilyOrAssembly)
+                 {
+                     differences.AddIncompatibleDifference(this,
+                         ""Visibility of member '{0}' is '{1}' in the implementation but '{2}' in the contract."",",I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`.,How is this related to the bug?
+650,"@@ -18,7 +18,10 @@ import (
+ )
+
+ var (
+-	depositToRewardingFundBaseGas = uint64(10000)
++	// DepositToRewardingFundBaseGas represents the base intrinsic gas for depositToRewardingFund
++	DepositToRewardingFundBaseGas = uint64(10000)
++	// DepositToRewardingFundGasPerByte represents the depositToRewardingFund payload gas per uint
++	DepositToRewardingFundGasPerByte = uint64(100)
+ )
+
+ // DepositToRewardingFund is the action to deposit to the rewarding fund",`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`),Why we change the base gas for depositToRewardingFund? This is a more reasonable change.
+651,"@@ -3,12 +3,14 @@
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ // SPDX-License-Identifier: Apache-2.0
+
+-// Package groups contains the names of command groups
++// Package groups contains the names of command groups.
+ package group
+
++// Categories for each top level command in the CLI.
+ const (
+-	GettingStarted = ""Getting Started ✨""
+-	Develop        = ""Develop 🔧""
++	GettingStarted = ""Getting Started 🌱""
++	Develop        = ""Develop ✨""
+ 	Settings       = ""Settings ⚙️""
++	Operational    = ""Operational 🧐""
+ 	Release        = ""Release 🚀""
+ )","What do you think of ""operations""?? Also what do these emojis look like on Linux??",Is there any reason for these changes? I don't see them in this PR.
+652,"@@ -0,0 +1,16 @@
++<% content_for :subject_block do %>
++  <h1><%= t('shared.subscription.name') %> for Teams</h1>
++  <h2 class=""tagline"">
++    Sign your team up for <%= t('shared.subscription.name') %> today, and give them the finest Ruby on Rails content and the best expert teachers.
++  </h2>
++<% end %>
++
++<p>Your team gets all of the great benefits of <%= link_to t('shared.subscription.name'), prime_path %>, with convenient monthly group billing, as well as a nice discount. <%= t('shared.subscription.name') %> Teams have a minimum of 5 members, and a 10% discount off the normal price. New members can be added at any time.</p>
++
++<section class=""plans"">
++  <%= render @plans %>
++</section>
++
++<span class=""prime-aside-links"">
++  <%= link_to ""View all the features of #{t('shared.subscription.name')}"", prime_path %>
++</span>","I like the word ""give"" here. Feels like I'm giving a gift to my team.","I'm not 100% sure if this is the right place for this, but I'd love to hear your thoughts."
+653,"@@ -11,12 +11,16 @@ import numpy as np
+ from sklearn import __version__ as sk_version
+ from sklearn.base import clone
+ from sklearn.datasets import (load_boston, load_breast_cancer, load_digits,
+-                              load_iris, load_svmlight_file)
++                              load_iris, load_linnerud, load_svmlight_file,
++                              make_multilabel_classification)
+ from sklearn.exceptions import SkipTestWarning
+ from sklearn.metrics import log_loss, mean_squared_error
+-from sklearn.model_selection import GridSearchCV, train_test_split
++from sklearn.model_selection import GridSearchCV, RandomizedSearchCV, train_test_split
++from sklearn.multioutput import (MultiOutputClassifier, ClassifierChain, MultiOutputRegressor,
++                                 RegressorChain)
+ from sklearn.utils.estimator_checks import (_yield_all_checks, SkipTest,
+                                             check_parameters_default_constructible)
++from scipy.stats import randint, uniform
+
+
+ decreasing_generator = itertools.count(0, -1)",Is it possible to use `np.random` module instead?,please make_multilabel_classification as `from sklearn.multioutput import ...`
+654,"@@ -49,7 +49,7 @@ legend_dimensions = ['label_standoff', 'label_width', 'label_height', 'glyph_wid
+
+ class ElementPlot(BokehPlot, GenericElementPlot):
+
+-    bgcolor = param.Parameter(default='white', doc=""""""
++    bgcolor = param.Parameter(default=None, allow_None=True, doc=""""""
+         Background color of the plot."""""")
+
+     border = param.Number(default=10, doc=""""""","``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed.","`allow_None=True` is a bit weird, maybe just `default='white'`?"
+655,"@@ -551,8 +551,8 @@ func genClientCerts(config *config.Control, runtime *config.ControlRuntime) erro
+ 	if _, err = factory(""system:kube-proxy"", nil, runtime.ClientKubeProxyCert, runtime.ClientKubeProxyKey); err != nil {
+ 		return err
+ 	}
+-	// this must be hardcoded to k3s-controller because it's hard coded in the rolebindings.yaml
+-	if _, err = factory(""system:k3s-controller"", nil, runtime.ClientK3sControllerCert, runtime.ClientK3sControllerKey); err != nil {
++	// This user (system:k3s-controller by default) must be bound to a role in rolebindings.yaml or the downstream equivalent
++	if _, err = factory(""system:""+version.Program+""-controller"", nil, runtime.ClientK3sControllerCert, runtime.ClientK3sControllerKey); err != nil {
+ 		return err
+ 	}
+ ",Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand.,"Maybe use `runtime.Program() + ""-controller"", nil` to make it clearer?"
+656,"@@ -21,7 +21,7 @@ import (
+ 	""strings""
+ 	""time""
+
+-	acd ""github.com/ncw/go-acd""
++	""github.com/ncw/go-acd""
+ 	""github.com/ncw/rclone/fs""
+ 	""github.com/ncw/rclone/fs/config""
+ 	""github.com/ncw/rclone/fs/config/configmap""",File is not `goimports`-ed (from `goimports`),Did you mean to delete this line?
+657,"@@ -0,0 +1,15 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++namespace Reporting
++{
++    public class Os
++    {
++        public string Locale { get; set; }
++
++        public string Architecture { get; set; }
++
++        public string Name { get; set; }
++    }
++}","nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?",why is this an enum?
+658,"@@ -16,7 +16,7 @@
+ #include <GraphMol/SmilesParse/SmilesParse.h>
+ #include <GraphMol/FileParsers/FileParsers.h>
+ #include <Geometry/point.h>
+-#include ""MolTransforms.h""
++#include <GraphMol/MolTransforms/MolTransforms.h>
+
+ using namespace RDKit;
+ using namespace MolTransforms;",Why is this needed here?,Please replace all the references
+659,"@@ -192,7 +192,7 @@ public interface Context {
+                 methodUsage = ((TypeVariableResolutionCapability) methodDeclaration)
+                                       .resolveTypeVariables(this, argumentsTypes);
+             } else {
+-                throw new UnsupportedOperationException();
++                return Optional.empty();
+             }
+
+             return Optional.of(methodUsage);","mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?",Why return `Optional.empty()` ins
+660,"@@ -32,8 +32,8 @@ public class EeaSendRawTransaction extends PrivacySendTransaction {
+
+   public EeaSendRawTransaction(
+       final PrivacyParameters privacyParameters,
+-      final PrivateTransactionHandler privateTransactionHandler,
+-      final TransactionPool transactionPool) {
++      final TransactionPool transactionPool,
++      final PrivateTransactionHandler privateTransactionHandler) {
+     super(privacyParameters, privateTransactionHandler, transactionPool);
+   }
+ ",nit: any reason you swapped the ordering?,Looks like there was a reason why we didn't have this before...
+661,"@@ -4,7 +4,7 @@ define([""jQuery"", ""loading"", ""globalize"", ""dom""], function($, loading, globalize
+     function loadPage(page, config, systemInfo) {
+         Array.prototype.forEach.call(page.querySelectorAll("".chkDecodeCodec""), function(c) {
+             c.checked = -1 !== (config.HardwareDecodingCodecs || []).indexOf(c.getAttribute(""data-codec""))
+-        }), page.querySelector(""#chkHardwareEncoding"").checked = config.EnableHardwareEncoding, $(""#selectVideoDecoder"", page).val(config.HardwareAccelerationType), $(""#selectThreadCount"", page).val(config.EncodingThreadCount), $(""#txtDownMixAudioBoost"", page).val(config.DownMixAudioBoost), page.querySelector("".txtEncoderPath"").value = config.EncoderAppPath || """", $(""#txtTranscodingTempPath"", page).val(config.TranscodingTempPath || """"), $(""#txtVaapiDevice"", page).val(config.VaapiDevice || """"), page.querySelector(""#selectH264Preset"").value = config.H264Preset || """", page.querySelector(""#txtH264Crf"").value = config.H264Crf || """", page.querySelector(""#chkEnableSubtitleExtraction"").checked = config.EnableSubtitleExtraction || !1, page.querySelector(""#selectVideoDecoder"").dispatchEvent(new CustomEvent(""change"", {
++        }), page.querySelector(""#chkHardwareEncoding"").checked = config.EnableHardwareEncoding, $(""#selectVideoDecoder"", page).val(config.HardwareAccelerationType), $(""#selectThreadCount"", page).val(config.EncodingThreadCount), $(""#txtDownMixAudioBoost"", page).val(config.DownMixAudioBoost), page.querySelector("".txtEncoderPath"").value = config.EncoderAppPathDisplay || """", $(""#txtTranscodingTempPath"", page).val(config.TranscodingTempPath || """"), $(""#txtVaapiDevice"", page).val(config.VaapiDevice || """"), page.querySelector(""#selectH264Preset"").value = config.H264Preset || """", page.querySelector(""#txtH264Crf"").value = config.H264Crf || """", page.querySelector(""#chkEnableSubtitleExtraction"").checked = config.EnableSubtitleExtraction || !1, page.querySelector(""#selectVideoDecoder"").dispatchEvent(new CustomEvent(""change"", {
+             bubbles: !0
+         })), loading.hide()
+     }",can you de-uglify at least this line?.. hard to tell what changed...,"shouldn't this be page.querySelector(""#chkH264Encoding"")"
+662,"@@ -354,13 +354,10 @@ type BPFDataplane interface {
+ 	RemoveXDP(ifName string, mode XDPMode) error
+ 	UpdateCIDRMap(ifName string, family IPFamily, ip net.IP, mask int, refCount uint32) error
+ 	UpdateFailsafeMap(proto uint8, port uint16) error
+-	loadXDPRaw(objPath, ifName string, mode XDPMode, mapArgs []string) error
+ 	GetBPFCalicoDir() string
+ 	AttachToSockmap() error
+ 	DetachFromSockmap(mode FindObjectMode) error
+ 	RemoveSockmap(mode FindObjectMode) error
+-	loadBPF(objPath, progPath, progType string, mapArgs []string) error
+-	LoadSockops(objPath string) error
+ 	LoadSockopsWithBytes(objBytes []byte) error
+ 	LoadSockopsAuto() error
+ 	RemoveSockops() error",Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code.,"loadBPFRaw is not used anymore, so can be removed"
+663,"@@ -66,3 +66,14 @@ class MyCls:
+     @classmethod
+     def get_class_var(cls):
+         return cls.__class_var
++
++
++class Bla:
++    """"""Regression test for issue 4638""""""
++
++    def __init__(self):
++        type(self).__a()
++
++    @classmethod
++    def __a(cls):
++        pass",Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`),The issue for this is probably similar to the one above?
+664,"@@ -462,7 +462,7 @@ def search(collection, p, of, ot, so, rm):
+
+     ctx = dict(
+         facets=facets.get_facets_config(collection, qid),
+-        records=len(get_current_user_records_that_can_be_displayed(qid)),
++        records=len(recids),
+         qid=qid, rg=rg,
+         create_nearest_terms_box=lambda: _create_neareset_term_box(argd_orig),
+         easy_search_form=EasySearchForm(csrf_enabled=False),","the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)",is this still necessary?
+665,"@@ -669,7 +669,15 @@ func (b *Bucket) newRangeReader(ctx context.Context, key string, offset, length
+
+ // WriteAll is a shortcut for creating a Writer via NewWriter and writing p.
+ func (b *Bucket) WriteAll(ctx context.Context, key string, p []byte, opts *WriterOptions) (err error) {
+-	w, err := b.NewWriter(ctx, key, opts)
++	realOpts := new(WriterOptions)
++	if opts != nil {
++		*realOpts = *opts
++	}
++	if len(realOpts.ContentMD5) == 0 {
++		sum := md5.Sum(p)
++		realOpts.ContentMD5 = sum[:]
++	}
++	w, err := b.NewWriter(ctx, key, realOpts)
+ 	if err != nil {
+ 		return err
+ 	}","Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?",I'm not sure that this i
+666,"@@ -143,6 +143,9 @@ def executeEvent(eventName,obj,**kwargs):
+ 	@param kwargs: Additional event parameters as keyword arguments.
+ 	""""""
+ 	try:
++		# Allow NVDAObjects to redirect focus events to another object of their choosing.
++		if eventName==""gainFocus"" and obj.focusRedirect:
++			obj=obj.focusRedirect
+ 		sleepMode=obj.sleepMode
+ 		if eventName==""gainFocus"" and not doPreGainFocus(obj,sleepMode=sleepMode):
+ 			return","focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!",This is the only part I
+667,"@@ -21,6 +21,8 @@ import (
+ 	""encoding/base64""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/config""
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/gcp_clients""
+ 	""io""
+ 	""log""
+ 	""path""",You imports are out of order,Can you move this up wit
+668,"@@ -45,7 +45,7 @@ import org.slf4j.LoggerFactory;
+ public class QuartzScheduler {
+
+   //Unless specified, all Quartz jobs's identities comes with the default job name.
+-  private static final String DEFAULT_JOB_NAME = ""job1"";
++  public static final String DEFAULT_JOB_NAME = ""job1"";
+   private static final Logger logger = LoggerFactory.getLogger(QuartzScheduler.class);
+   private Scheduler scheduler = null;
+ ","This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, ""flowtrigger""",Does it make sense to keep the `private`?
+669,"@@ -0,0 +1,19 @@
++// Copyright (c) 2018 IoTeX
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package sqlite3
++
++import (
++	""github.com/iotexproject/iotex-core/config""
++	""github.com/iotexproject/iotex-core/db""
++	// this is required for sqlite3 usage
++	_ ""github.com/mattn/go-sqlite3""
++)
++
++// NewSQLite3 instantiates an sqlite3
++func NewSQLite3(cfg *config.SQLITE3) db.Store {
++	return db.NewSQLBase(""sqlite3"", cfg.SQLite3File)
++}",File is not `goimports`-ed (from `goimports`),You don't need this anymore
+670,"@@ -30,6 +30,10 @@ public partial class Program
+
+     public static void Stress(int concurrency = 0)
+     {
++#if DEBUG
++        Console.WriteLine(""***WARNING*** The current build is DEBUG which may affect timing!\n"");
++#endif
++
+         if (concurrency < 0)
+         {
+             throw new ArgumentOutOfRangeException(nameof(concurrency), ""concurrency level should be a non-negative number."");",Why do we need `\n` if we already use `WriteLine`? (and `\n` is not cross platform),"nit: use `nameof(concurrency)`. Also, use"
+671,"@@ -30,12 +30,15 @@ import com.google.common.base.MoreObjects;
+ public class MetricsConfiguration {
+   private static final String DEFAULT_METRICS_HOST = ""127.0.0.1"";
+   public static final int DEFAULT_METRICS_PORT = 9545;
+-
++  private static final String DEFAULT_INSTRUMENTATION_NAME = ""besu"";
++  private static final String DEFAULT_METRICS_PROTOCOL = ""prometheus"";
+   private static final String DEFAULT_METRICS_PUSH_HOST = ""127.0.0.1"";
+   public static final int DEFAULT_METRICS_PUSH_PORT = 9001;
+   public static final Boolean DEFAULT_TIMERS_ENABLED = true;
+
+   private final boolean enabled;
++  private final String instrumentationName;
++  private final String protocol;
+   private final int port;
+   private int actualPort;
+   private final String host;","What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder.",Why do we need this? I thought we already
+672,"@@ -21,8 +21,10 @@ namespace Nethermind.TxPool.Collections
+ {
+     public partial class SortedPool<TKey, TValue, TGroupKey>
+     {
++#pragma warning disable 67
+         public event EventHandler<SortedPoolEventArgs>? Inserted;
+         public event EventHandler<SortedPoolRemovedEventArgs>? Removed;
++#pragma warning restore 67
+
+         public class SortedPoolEventArgs
+         {",@kristofgazso could you review these warnings?,Is there some reason why you didn't use the eventbus here? Is there some reason I'm not seeing?
+673,"@@ -0,0 +1,3 @@
++require(""child_process"");
++
++console.log(""hi"");",will delete this.,Please remove this.
+674,"@@ -104,9 +104,9 @@ module PurchasesHelper
+
+   def new_plan_link(plan)
+     link_to(
+-       I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe,
+-       new_individual_plan_purchase_path(plan),
+-       class: 'button'
++      I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe,
++      new_individual_plan_purchase_path(plan),
++      class: 'button'
+     )
+   end
+ end",~~Indent 2 lines above~~ Disregard. My fault,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escap
+675,"@@ -366,7 +366,7 @@ public class InitCodeTransformer {
+         default:
+           throw new UnsupportedOperationException(""unexpected entity name type"");
+       }
+-    } else if (initValueConfig.hasFormattingConfig()) {
++    } else if (initValueConfig.hasFormattingConfig() && !item.getType().isRepeated()) {
+       if (context.getFeatureConfig().enableStringFormatFunctions()) {
+         FormattedInitValueView.Builder initValue = FormattedInitValueView.newBuilder();
+ ",What was the bug that this is fixing?,Could this be `!item.isRepeated()` instead?
+676,"@@ -471,6 +471,9 @@ class RemoteConnection(object):
+             request.add_header('Accept', 'application/json')
+             request.add_header('Content-Type', 'application/json;charset=UTF-8')
+
++            base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))
++            request.add_header(""Authorization"", ""Basic %s"" % base64string)
++
+             if password_manager:
+                 opener = url_request.build_opener(url_request.HTTPRedirectHandler(),
+                                                   HttpErrorHandler(),","This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'",Do you think it's worth adding some sort of validation to ensure the `username` and `password` are not empty (e.g. `username.lower()`)?
+677,"@@ -50,7 +50,12 @@ uint32_t lcg_rand() {
+ }
+ void lcg_reset() { lcg_seed = 48271; }
+
+-std::string test_data_path = ""tests/"";
++std::string test_data_path =
++#ifdef BAZEL_TEST_DATA_PATH
++    ""../com_github_google_flatbuffers/tests/"";
++#else
++    ""tests/"";
++#endif
+
+ // example of how to build up a serialized buffer algorithmically:
+ flatbuffers::DetachedBuffer CreateFlatBufferTest(std::string &buffer) {",Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?,"why not just define this as `const std::string test_data_path = ""tests/""`?"
+678,"@@ -169,7 +169,9 @@ class ElasticsearchTarget(luigi.Target):
+
+         The document id would be sufficient but,
+         for documentation,
+-        we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well.
++        we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well.  `date_utc` added
++        so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the
++        client machine.
+         """"""
+         self.create_marker_index()
+         self.es.index(index=self.marker_index, doc_type=self.marker_doc_type,","Not an expert of ES, so not sure of the impact here.",Wondering if we should index this based on `date_utc` rather than on the client?
+679,"@@ -1665,10 +1665,10 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs(
+   if (ComUser::isRootUserID())
+     return FALSE;
+
+-  // any user granted the DB__ROOTROLE sees everything
+   Int32 numRoles;
+   Int32 *roleList;
+-  if (currContext->getRoleList(numRoles, roleList) == SUCCESS)
++  Int32 *granteeList;
++  if (currContext->getRoleList(numRoles, roleList, granteeList) == SUCCESS)
+   {
+     char authIDAsChar[sizeof(Int32)+10];
+     NAString auths;",Who deletes the memory for the granteeList? (or the roleList for that matter),"I'm not sure if it's a good idea to include `granteeList` in the `authIDs` array. If it's not needed, please remove it."
+680,"@@ -13,6 +13,11 @@ ws_listener (listener_a), ws (std::move (socket_a)), write_strand (ws.get_execut
+
+ nano::websocket::session::~session ()
+ {
++	for (auto & subscription : subscriptions)
++	{
++		ws_listener.decrease_subscription_count (subscription);
++	}
++
+ 	ws_listener.get_node ().logger.try_log (""websocket session ended"");
+ }
+ ",This loop is missing a lock on subscriptions_mutex.,why not just `for (auto &subscription : subscriptions)` ?
+681,"@@ -62,7 +62,9 @@ Workshops::Application.routes.draw do
+   match '/backbone-js-on-rails' => redirect(""/products/1-backbone-js-on-rails"")
+
+   match '/rubyist-booster-shot' => ""high_voltage/pages#show"", as: :rubyist_booster_shot, id: ""rubyist-booster-shot""
+-  match 'sign_in'  => 'sessions#new', as: 'sign_in'
++  match '/sign_up' => 'users#new', as: 'sign_up'
++  match '/sign_in' => 'sessions#new', as: 'sign_in'
++  match '/sign_out' => 'sessions#destroy', as: 'sign_out', via: :delete
+
+   mount Split::Dashboard, at: 'split'
+ ",shouldn't clearance be setting these up for us?,Should we change this to `users#new` and `sign_in`?
+682,"@@ -46,6 +46,10 @@ type (
+ 	}
+
+ 	defaultServiceNameDetector struct{}
++
++	// noOp is a Detector that only provides an empty resource.  Used
++	// to disable automatic detection.
++	noOp struct{}
+ )
+
+ var (",Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions.,I'm not clear on where this is used but I'm wondering if
+683,"@@ -55,12 +55,6 @@ public final class ASTRecordDeclaration extends AbstractAnyTypeDeclaration {
+         return isNested() || isLocal();
+     }
+
+-    @Override
+-    public boolean isFinal() {
+-        // A record is implicitly final
+-        return true;
+-    }
+-
+     @Override
+     public boolean isLocal() {
+         return getParent() instanceof ASTBlockStatement;",I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected,Why is this not needed anymore?
+684,"@@ -2444,6 +2444,11 @@ angular.module('ui.grid')
+           //   to get the full position we need
+           scrollPixels = self.renderContainers.body.prevScrollTop - (topBound - pixelsToSeeRow);
+
++          //Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop.
++          if (gridCol.colDef.enableCellEditOnFocus === true) {
++            scrollPixels = scrollPixels - self.footerHeight - self.scrollbarWidth;
++          }
++
+           scrollEvent.y = getScrollY(scrollPixels, scrollLength, self.renderContainers.body.prevScrolltopPercentage);
+         }
+         // Otherwise if the scroll position we need to see the row is MORE than the bottom boundary, i.e. obscured below the bottom of the self...",Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?,This should be `self.footerHeight - self.scrollbarWidth`
+685,"@@ -23,6 +23,7 @@ import com.playonlinux.common.dtos.*;
+ import com.playonlinux.domain.PlayOnLinuxError;
+ import com.playonlinux.injection.Scan;
+ import com.playonlinux.injection.Inject;
++import com.playonlinux.ui.api.InstallerFilter;
+ import com.playonlinux.webservice.RemoteAvailableInstallers;
+
+ import java.net.MalformedURLException;",You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?,"I think there's an unused import now, right?"
+686,"@@ -42,7 +42,7 @@ const (
+ 	templateCreateWorkflowExecutionClosed = `INSERT INTO executions_visibility (` +
+ 		`namespace_id, workflow_id, run_id, start_time, execution_time, workflow_type_name, close_time, status, history_length, memo, encoding) ` +
+ 		`VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ` +
+-		`ON DUPLICATE KEY UPDATE start_time = VALUES(start_time), execution_time = VALUES(execution_time), workflow_type_name = VALUES(workflow_type_name), ` +
++		`ON DUPLICATE KEY UPDATE workflow_id = VALUES(workflow_id), start_time = VALUES(start_time), execution_time = VALUES(execution_time), workflow_type_name = VALUES(workflow_type_name), ` +
+ 		`close_time = VALUES(close_time), status = VALUES(status), history_length = VALUES(history_length), memo = VALUES(memo), encoding = VALUES(encoding)`
+
+ 	// RunID condition is needed for correct pagination","This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key.","should this be start_time = VALUES(start_time), executio"
+687,"@@ -4520,7 +4520,9 @@ RelExpr * GenericUpdate::preCodeGen(Generator * generator,
+     {
+       oltOptInfo().setOltOpt(FALSE);
+       generator->oltOptInfo()->setOltOpt(FALSE);
+-      generator->setAqrEnabled(FALSE);
++      //enabling AQR to take care of the lock conflict error 8558 that
++      // should be retried.
++      //      generator->setAqrEnabled(FALSE);
+       generator->setUpdAbortOnError(TRUE);
+       generator->setUpdSavepointOnError(FALSE);
+     }",How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?,Why not just remove this line?
+688,"@@ -6,9 +6,11 @@ import (
+ 	""net""
+ 	""os""
+
+-	sds_v2 ""github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2""
++	discovery_v2 ""github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2""
++	secret_v3 ""github.com/envoyproxy/go-control-plane/envoy/service/secret/v3""
+ 	attestor ""github.com/spiffe/spire/pkg/agent/attestor/workload""
+-	""github.com/spiffe/spire/pkg/agent/endpoints/sds""
++	""github.com/spiffe/spire/pkg/agent/endpoints/sds/sdsv2""
++	""github.com/spiffe/spire/pkg/agent/endpoints/sds/sdsv3""
+ 	""github.com/spiffe/spire/pkg/agent/endpoints/workload""
+ 	""github.com/spiffe/spire/pkg/common/peertracker""
+ 	""github.com/spiffe/spire/pkg/common/telemetry""","Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter",I think the changes in this file are not needed anymore?
+689,"@@ -927,7 +927,7 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
+     if (isFunction(beforeChangeResult)) {
+       warn('Your beforeChange callback returns a function. It\'s not supported since Handsontable 0.12.1 (and the returned function will not be executed).');
+
+-    } else if (beforeChangeResult === false) {
++    } else if (beforeChangeResult === false || beforeChangeResult.length === 0 || beforeChangeResult[0] === null) {
+       const activeEditor = instance.getActiveEditor();
+
+       if (activeEditor) {",Please check also whether `null` occurs in the rest of `beforeChangeResult` array.,It's not possible to have `beforeChangeResult` be null?
+690,"@@ -22,9 +22,10 @@ package transport
+
+ import ""context""
+
+-// Filter defines transport-level middleware for Outbounds.
++// UnaryFilter defines transport-level middleware for `UnaryOutbound`s.
++// Note: this is client side.
+ //
+-// Filters MAY
++// UnaryFilter MAY
+ //
+ // - change the context
+ // - change the request","Outdated docs. There is no response, there's an ack.",s/Note: this is client side/inbound/ ?
+691,"@@ -27,7 +27,7 @@ your host.`,
+ 		}
+ 		switch status {
+ 		case libcontainer.Created:
+-			return container.Signal(libcontainer.InitContinueSignal)
++			return container.Exec()
+ 		case libcontainer.Stopped:
+ 			return fmt.Errorf(""cannot start a container that has run and stopped"")
+ 		case libcontainer.Running:","I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the ""FIFO does not exist"" error and translate it to a prettier ""someone must have already started the container"".",Do we need to wait for the completion of the container t
+692,"@@ -284,7 +284,7 @@ func (svr *Web3Server) getTransactionFromActionInfo(actInfo *iotexapi.ActionInfo
+
+ func (svr *Web3Server) getTransactionCreateFromActionInfo(actInfo *iotexapi.ActionInfo) (transactionObject, error) {
+ 	tx, err := svr.getTransactionFromActionInfo(actInfo)
+-	if err != nil {
++	if err != nil || tx == nil {
+ 		return transactionObject{}, err
+ 	}
+ ",can you check if there's other similar cases to add nil-check like this?,tx can be nil here right?
+693,"@@ -106,7 +106,10 @@ def dummy_cert(privkey, cacert, commonname, sans, organization):
+     cert.gmtime_adj_notBefore(-3600 * 48)
+     cert.gmtime_adj_notAfter(DEFAULT_EXP_DUMMY_CERT)
+     cert.set_issuer(cacert.get_subject())
+-    if commonname is not None and len(commonname) < 64:
++    is_valid_commonname = (
++        commonname is not None and len(commonname) < 64
++    )
++    if is_valid_commonname:
+         cert.get_subject().CN = commonname
+     if organization is not None:
+         cert.get_subject().O = organization","`<= 64`? I just picked up what you said in #3981 (""the CN field is limited to 64 characters"") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:",`if commonname is not Non
+694,"@@ -20,4 +20,10 @@ class License < ActiveRecord::Base
+   def short_name
+     abbreviation.blank? ? nice_name : abbreviation
+   end
++
++  class << self
++    def autocomplete(term)
++      License.select([:nice_name, :id]).where(['lower(nice_name) LIKE ?', ""#{term.downcase}%""]).limit(10)
++    end
++  end
+ end",I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?,I'm not sure how I feel a
+695,"@@ -480,6 +480,10 @@ public class BlockchainQueries {
+         txs.get(txIndex), header.getNumber(), blockHeaderHash, txIndex);
+   }
+
++  public Optional<TransactionLocation> transactionLocationByHash(final Hash transactionHash) {
++    return blockchain.getTransactionLocation(transactionHash);
++  }
++
+   /**
+    * Returns the transaction receipt associated with the given transaction hash.
+    *",I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ...,Looks like this method ca
+696,"@@ -180,6 +180,19 @@ public class StringUtil {
+         }
+     }
+
++    public static String sanitizeFileDirectory(String value){
++
++        while (value.startsWith(""\\"") || value.startsWith(""/"") || value.startsWith(""-"") || value.startsWith(""."")){
++            value = value.substring(1);
++        }
++        while (value.endsWith(""\\"") || value.endsWith(""/"") || value.endsWith(""-"") || value.endsWith(""."")){
++            value = value.substring(0, value.length() - 1);
++        }
++
++        return value;
++    }
++
++
+     private static SecretKeySpec generateKeyFromString(final String secKey) throws UnsupportedEncodingException, NoSuchAlgorithmException {
+         byte[] key = (secKey).getBytes(""UTF-8"");
+         MessageDigest sha = MessageDigest.getInstance(""SHA-1"");","@sekmiller This method correctly strips the leading and trailing slashes (and also ""."" and ""-""); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter ""folder1///folder2"", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as ""folder1/folder2"".",This should probably have a unit test.
+697,"@@ -45,7 +45,7 @@
+
+ int main()
+ {
+-    int pid;
++    int64_t pid;
+     fprintf(stderr, ""starting\n"");
+ #if defined(AARCH64)
+     asm(""movz x8, "" STRINGIFY(SYS_getpid) "";""",Looks like the X86 inline assembly is not happy with this type. I will update that,`pid` is declared as a `uint64_t`. If
+698,"@@ -6,6 +6,12 @@
+
+     <h2><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></h2>
+
++    <% if @user and diary_entry.user.id != @user.id %>
++           <%= link_to new_issue_url(reportable_id: diary_entry.id, reportable_type: diary_entry.class.name, reported_user_id: diary_entry.user.id,referer: request.fullpath), :title => t('diary_entry.diary_entry.report') do %>
++            &nbsp;&#9872;
++          <% end %>
++    <% end %>
++
+     <small class='deemphasize'>
+       <%= raw(t 'diary_entry.diary_entry.posted_by', :link_user => (link_to h(diary_entry.user.display_name), :controller => 'user', :action => 'view', :display_name => diary_entry.user.display_name), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to h(diary_entry.language.name), :controller => 'diary_entry', :action => 'list', :display_name => nil, :language => diary_entry.language_code)) %>
+     </small>","Tabs and a space, again.",Use `&nbsp;` rather than `&nbsp;`.
+699,"@@ -2441,6 +2441,16 @@ bool QuestManager::istaskappropriate(int task) {
+ 	return false;
+ }
+
++std::string QuestManager::gettaskname(uint32 task_id) {
++	QuestManagerCurrentQuestVars();
++
++	if (RuleB(TaskSystem, EnableTaskSystem)) {
++		return taskmanager->GetTaskName(task_id);
++	}
++
++	return std::string();
++}
++
+ void QuestManager::clearspawntimers() {
+ 	if(!zone)
+         return;",Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them,Why don't you check the enabled flag f
+700,"@@ -185,11 +185,7 @@
+ <% if policy(@proposal).can_approve_or_reject? %>
+   <div class=""centered"">
+     <p>
+-      <%= link_to ""Approve"",
+-          approval_response_path(approver_action: 'approve',
+-                                 # @todo: get rid of cart
+-                                 cart_id: @proposal.cart.id, version: @proposal.version
+-                                 ), class: 'form-button' %>
++      <%= link_to ""Approve"", approve_proposal_url(@proposal, version: @proposal.version), class: 'form-button' %>
+     </p>
+   </div>
+ <% end %>","`version` isn't need anymore because it's built into `approve_proposal_url`, yes?",Shouldn't this be `approve_proposal_path`?
+701,"@@ -11,9 +11,10 @@ import struct
+
+ from scapy.compat import orb, chb
+ from scapy.config import conf
+-from scapy.data import MTU, DLT_BLUETOOTH_LE_LL
++from scapy.data import MTU, DLT_BLUETOOTH_LE_LL, DLT_BLUETOOTH_LE_LL_WITH_PHDR
+ from scapy.packet import *
+ from scapy.fields import *
++from scapy.layers.dot11 import _dbmField
+ from scapy.layers.ppi import PPI, addPPIType, PPIGenericFldHdr
+
+ from scapy.contrib.ppi_geotag import XLEIntField, XLEShortField",Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after,Do we really need the underscore between `
+702,"@@ -48,6 +48,7 @@ module Blacklight::SolrHelper
+   extend ActiveSupport::Concern
+   include Blacklight::SearchFields
+   include Blacklight::Facet
++  require 'json'
+
+   included do
+     if self.respond_to?(:helper_method)","This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)",I was thinking we could add a helper metho
+703,"@@ -56,8 +56,13 @@ type byteReadCloser struct{ io.ReadCloser }
+ // ReadByte implements the io.ByteReader interface.
+ func (b byteReadCloser) ReadByte() (byte, error) {
+ 	var buf [1]byte
+-	_, err := b.Read(buf[:])
+-	return buf[0], err
++	for {
++		n, err := b.Read(buf[:])
++		if n == 0 && err == nil {
++			continue
++		}
++		return buf[0], err
++	}
+ }
+
+ // A compressor builds a Riegeli compressed block.","This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just ""trying again"" and failing if it fails the second time.",The `continue` here suggests that we've re
+704,"@@ -20,11 +20,18 @@
+ package org.apache.iceberg;
+
+ import java.util.List;
++import java.util.Optional;
+ import org.apache.iceberg.exceptions.ValidationException;
+ import org.apache.iceberg.expressions.Expressions;
++import org.apache.iceberg.util.PartitionSet;
+
+ public class BaseReplacePartitions
+     extends MergingSnapshotProducer<ReplacePartitions> implements ReplacePartitions {
++
++  private final PartitionSet deletedPartitions = PartitionSet.create(super.getSpecsById());
++  private Long startingSnapshotId = null;
++  private boolean validateNoConflictingAppends = false;
++
+   BaseReplacePartitions(String tableName, TableOperations ops) {
+     super(tableName, ops);
+     set(SnapshotSummary.REPLACE_PARTITIONS_PROP, ""true"");","If there is a reference to other fields or methods, please do the initialization in the constructor.",nit: can we rename this to startingSnapshotId?
+705,"@@ -0,0 +1,13 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/base.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/icons.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/avatars.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/bare.jsx'),
++];
++
++module.exports = siteStories;",These should be importing from `pill-container`,Do you have any reason why these are not in th
+706,"@@ -2593,12 +2593,12 @@ void Game::playerRequestTrade(uint32_t playerId, const Position& pos, uint8_t st
+
+ 	Player* tradePartner = getPlayerByID(tradePlayerId);
+ 	if (!tradePartner || tradePartner == player) {
+-		player->sendTextMessage(MESSAGE_INFO_DESCR, ""Sorry, not possible."");
++		player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
+ 		return;
+ 	}
+
+ 	if (!Position::areInRange<2, 2, 0>(tradePartner->getPosition(), player->getPosition())) {
+-		player->sendTextMessage(MESSAGE_INFO_DESCR, fmt::format(""{:s} tells you to move closer."", tradePartner->getName()));
++		player->sendCancelMessage(RETURNVALUE_DESTINATIONOUTOFREACH);
+ 		return;
+ 	}
+ ","Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?",is it ok to simply not send cancel message if
+707,"@@ -46,7 +46,7 @@ module Blacklight
+
+       fields = Array.wrap(view_config.title_field) + [configuration.document_model.unique_key]
+       f = fields.lazy.map { |field| field_config(field) }.detect { |field_config| field_presenter(field_config).any? }
+-      field_value(f, except_operations: [Rendering::HelperMethod])
++      f ? field_value(f, except_operations: [Rendering::HelperMethod]) : """"
+     end
+
+     def display_type(base_name = nil, default: nil)",Does this need to allocate a string or would a nil value (indicating no header) be a better?,Style/StringLiterals: Prefer single-quoted str
+708,"@@ -13,6 +13,7 @@ import { Fragment } from './create-element';
+ export function Component(props, context) {
+ 	this.props = props;
+ 	this.context = context;
++	// this.constructor // When component is functional component, this is reseted to functional component
+ 	// if (this.state==null) this.state = {};
+ 	// this.state = {};
+ 	// this._dirty = true;",Nit: Past tense of `reset` is also `reset`.,Can we get rid of this?
+709,"@@ -672,6 +672,12 @@ class Commands:
+         """""" return wallet synchronization status """"""
+         return self.wallet.is_up_to_date()
+
++    @command('')
++    def getfee(self):
++        """"""Return current optimal fee per kilobyte, according to
++        config settings (static/dynamic)""""""
++        return self.config.fee_per_kb()
++
+     @command('')
+     def help(self):
+         # for the python console",Shouldn't this use `'n'` instead?,i think it's better to
+710,"@@ -451,10 +451,10 @@ func (t *timerQueueProcessorBase) getTimerTaskType(
+ 	switch taskType {
+ 	case enumsspb.TASK_TYPE_USER_TIMER:
+ 		return ""UserTimer""
+-	case enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT:
+-		return ""ActivityTimeout""
+-	case enumsspb.TASK_TYPE_DECISION_TIMEOUT:
+-		return ""DecisionTimeout""
++	case enumsspb.TASK_TYPE_ACTIVITY_TASK_TIMEOUT:
++		return ""ActivityTaskTimeout""
++	case enumsspb.TASK_TYPE_WORKFLOW_TASK_TIMEOUT:
++		return ""WorkflowTaskTimeout""
+ 	case enumsspb.TASK_TYPE_WORKFLOW_RUN_TIMEOUT:
+ 		return ""WorkflowRunTimeout""
+ 	case enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT:",revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT',are we dropping the dec
+711,"@@ -105,6 +105,9 @@ Engine::Engine(core::Engine *engine) : m_Engine(engine) {}
+     template void Engine::Get<T>(const std::string &, std::vector<T> &,        \
+                                  const Mode);                                  \
+                                                                                \
++    template void Engine::GetBlock<T>(Variable<T>, T **, const Mode);          \
++    template void Engine::GetBlock<T>(const std::string &, T **, const Mode);  \
++                                                                               \
+     template std::map<size_t, std::vector<typename Variable<T>::Info>>         \
+     Engine::AllStepsBlocksInfo(const Variable<T> variable) const;              \
+                                                                                \","Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?",Can you avoid the doubl
+712,"@@ -146,9 +146,15 @@ func (n *NetworkPolicyController) processClusterNetworkPolicy(cnp *secv1alpha1.C
+ 			appliedToGroupNamesForRule = append(appliedToGroupNamesForRule, atGroup)
+ 			appliedToGroupNamesSet.Insert(atGroup)
+ 		}
++		cgExists := len(ingressRule.SourceGroups) > 0
++		iFromPeers := n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists, cgExists)
++		// If ClusterGroups are set in Rule, then create AddressGroups corresponding to the CG and append to From Peers.
++		ag, ipb := n.processRefCGs(ingressRule.SourceGroups)
++		iFromPeers.IPBlocks = append(iFromPeers.IPBlocks, ipb...)
++		iFromPeers.AddressGroups = append(iFromPeers.AddressGroups, ag...)
+ 		rules = append(rules, controlplane.NetworkPolicyRule{
+ 			Direction:       controlplane.DirectionIn,
+-			From:            *n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists),
++			From:            iFromPeers,
+ 			Services:        services,
+ 			Action:          ingressRule.Action,
+ 			Priority:        int32(idx),",nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though.,I'm wondering if `processRefCGs` should also take `from` instead of `from`. That way if we change the `from` field we won't have to update all references to `from`.
+713,"@@ -98,6 +98,7 @@ func updateSPCVersion(name string) error {
+ 		return err
+ 	}
+ 	spcObj.VersionDetails.Desired = upgradeVersion
++	spcObj.VersionDetails.Status.State = apis.ReconcilePending
+ 	_, err = client.Update(spcObj)
+ 	if err != nil {
+ 		return err","Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?",doesn't this need to go before the update?
+714,"@@ -61,11 +61,13 @@ class VimeoProvider extends BaseVideoProvider
+         $box = $this->getBoxHelperProperties($media, $format, $options);
+
+         $params = array(
+-            'src'         => http_build_query($player_parameters),
+-            'id'          => $player_parameters['js_swf_id'],
+-            'frameborder' => isset($options['frameborder']) ? $options['frameborder'] : 0,
+-            'width'       => $box->getWidth(),
+-            'height'      => $box->getHeight(),
++            'src'               => http_build_query($player_parameters),
++            'id'                => $player_parameters['js_swf_id'],
++            'frameborder'       => isset($options['frameborder']) ? $options['frameborder'] : 0,
++            'width'             => $box->getWidth(),
++            'height'            => $box->getHeight(),
++            'class'             => isset($options['class']) ? $options['class'] : '',
++            'allow_fullscreen'  => isset($options['allowfullscreen']) ? true : false,
+         );
+
+         return $params;",would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?,"`isset($options['class']) ? $options['class'] : ''` is the same as `empty($options['class']) ? true : false,`"
+715,"@@ -169,6 +169,8 @@ public class PhpSampleMethodToViewTransformer implements SampleMethodToViewTrans
+     builder.isResourceMap(fieldInfo.type().isMap());
+     builder.pageVarName(
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name()))));
++    builder.pageTokenName(methodInfo.requestPageTokenName());
++    builder.nextPageTokenName(Name.lowerCamel(methodInfo.responsePageTokenName()).toUpperCamel());
+     return builder.build();
+   }
+ }",How come we need case manipulation for the nextPageToken and not for pageToken?,`methodInfo.requestPageTokenName()` -> `methodInfo.responsePageTokenName()`
+716,"@@ -2,7 +2,8 @@ C2::Application.routes.draw do
+   ActiveAdmin.routes(self)
+   root :to => 'home#index'
+   get '/error' => 'home#error'
+-  get '/me'    => 'home#me'
++  get '/me'    => 'profile#show'
++  post '/me'   => 'profile#update'
+   get '/feedback' => 'feedback#index'
+   get '/feedback/thanks' => 'feedback#thanks'
+   post '/feedback' => 'feedback#create'",why use these rather than regular named paths?,"This should be under the `/profile` route, not `/me`."
+717,"@@ -61,6 +61,9 @@ module Bolt
+           { flags: OPTIONS[:global],
+             banner: GROUP_HELP }
+         end
++      when 'guide'
++        { flags: OPTIONS[:global] + %w[format],
++          banner: GUIDE_HELP }
+       when 'plan'
+         case action
+         when 'convert'","Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out.",Is there a way to differentiate between `--guide` and
+718,"@@ -1,3 +1,18 @@
++# This script is responsible to create candidate sets for all users. The generated candidate sets
++# will be given as input to the recommender to assign ratings to the recordings in candidate sets.
++# The general flow is as follows:
++#
++# Last 7 days listens are filtered from mapped_listens_df and is called the mapped_listens_subset_df.
++# Top X artists are fetched for each user from the mapped_listens_subset_df. The top_artist_df is joined
++# with recordings_df to get the dataframe of recordings belonging to the top artists. From this dataframe,
++# recordings listened to by the users in the last 7 days are filtered so that the recommendations don't contain
++# recordings that the user has listened to in the last week. The resultant dataframe is called the top_artists_candidate_set_df.
++#
++# Artists similar to top artists are fetched from the artist_relations_df and the similar_artist_candidate_set_df is generated
++# in a manner similar to the generation of the top artist candidate set.
++#
++# The top artist and similar artist candidate set dataframes are saved to HDFS.
++
+ import os
+ import sys
+ import uuid","We should make this a docstring, so that editors are able to pick it up.",Line is too long. [82/80]
+719,"@@ -14,5 +14,13 @@ feature ""User without a subscription views sample video"" do
+     expect(current_path).to eq(video_path(video))
+     expect(page).to have_css(""h1"", text: video.name)
+     expect(page).not_to have_css("".locked-message"")
++    expect_authed_to_access_event_fired_for(video)
++  end
++
++  def expect_authed_to_access_event_fired_for(video)
++    expect(analytics).to have_tracked(""Authed to Access"").with_properties(
++      video_name: video.name,
++      watchable_name: video.watchable_name,
++    )
+   end
+ end",Put a comma after the last parameter of a multiline method call.,Could we have a test that ensures that the event is f
+720,"@@ -150,10 +150,8 @@ public class SalesforceDroidGapActivity extends CordovaActivity {
+     		webSettings.setDomStorageEnabled(true);
+     		String cachePath = getApplicationContext().getCacheDir().getAbsolutePath();
+     		webSettings.setAppCachePath(cachePath);
+-            webSettings.setAppCacheMaxSize(1024 * 1024 * 8);
+     		webSettings.setAppCacheEnabled(true);
+     		webSettings.setAllowFileAccess(true);
+-            webSettings.setSavePassword(false);
+     		webSettings.setCacheMode(WebSettings.LOAD_DEFAULT);
+     		EventsObservable.get().notifyEvent(EventType.GapWebViewCreateComplete, appView);
+       	}",App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework.,Why is this removed?
+721,"@@ -1,4 +1,6 @@
+-var nn = node.nodeName.toLowerCase();
+-return (
+-	node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area')
+-);
++const { nodeName } = virtualNode.props;
++if (['img', 'input', 'area'].includes(nodeName) === false) {
++	return false;
++}
++
++return typeof virtualNode.attr('alt') === 'string';","VirtualNode has a `hasAttr` function, any reason why you're not using it?",Nit: can we use `Arr
+722,"@@ -69,7 +69,6 @@ public class HttpAccess {
+      * Initializes HttpAccess. Should be called from the application.
+      */
+     public static void init(Context app) {
+-        assert DEFAULT == null : ""HttpAccess.init should be called once per process"";
+         DEFAULT = new HttpAccess(app, null /* user agent will be calculated at request time */);
+     }
+ ",This now throws when running tests (maybe the move to java 11??). Do we want to keep it?,Shouldn't we keep th
+723,"@@ -45,8 +45,8 @@ func EncodeSha1(str string) string {
+ }
+
+ func ShortSha(sha1 string) string {
+-	if len(sha1) == 40 {
+-		return sha1[:10]
++	if len(sha1) > 7 {
++		return sha1[:7]
+ 	}
+ 	return sha1
+ }","We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut.",If the sha1 has more
+724,"@@ -66,8 +66,10 @@ en_US.strings = {
+   loading: 'Loading...',
+   logOut: 'Log out',
+   myDevice: 'My Device',
++  noDuplicates: 'Cannot add the duplicate file %{fileName}, it already exists',
+   noFilesFound: 'You have no files or folders here',
+   noInternetConnection: 'No Internet connection',
++  noNewAlreadyUploading: 'Cannot add new files: already uploading',
+   openFolderNamed: 'Open folder %{name}',
+   pause: 'Pause',
+   pauseUpload: 'Pause upload',",this one should also have quotes i guess :),"I am not sure if we should say ""it already exists"" in this case. It sounds like the file is already uploaded."
+725,"@@ -106,12 +106,14 @@ func TestBuilderForYAML(t *testing.T) {
+ 		""Test 2"": {fakeInvalidK8sResource, """", true},
+ 	}
+ 	for name, mock := range tests {
++		name := name // pin it
++		mock := mock // pin it
+ 		t.Run(name, func(t *testing.T) {
+ 			b := BuilderForYaml(mock.resourceYAML)
+ 			if mock.expectError && len(b.errs) == 0 {
+ 				t.Fatalf(""Test %s failed, expected err but got 0"", name)
+-			} else if b.unstruct.object.GetName() != mock.expectedName {
+-				t.Fatalf(""Test %s failed, expected %v but got %v"", name, mock.expectedName, b.unstruct.object.GetName())
++			} else if b.unstruct.Object.GetName() != mock.expectedName {
++				t.Fatalf(""Test %s failed, expected %v but got %v"", name, mock.expectedName, b.unstruct.Object.GetName())
+ 			}
+ 		})
+ 	}",Using the variable on range scope `mock` in function literal (from `scopelint`),"Unrelated to this PR, but I just noticed that `name` is not `mock.resourceYAML.Name` and `mock.expectedName` "
+726,"@@ -1020,7 +1020,7 @@ public class Datasets extends AbstractApiBean {
+             PublishDatasetResult res = execCommand(new PublishDatasetCommand(ds,
+                         createDataverseRequest(user),
+                     isMinor));
+-            return res.isCompleted() ? ok(json(res.getDataset())) : accepted(json(res.getDataset()));
++            return res.isWorkflow() ? accepted(json(res.getDataset())) : ok(json(res.getDataset()));
+             }
+         } catch (WrappedResponse ex) {
+             return ex.getResponse();",does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?,What's the difference between `isWorkflow` and `isCompleted`?
+727,"@@ -65,6 +65,7 @@ public class SmartStorePlugin extends ForcePlugin {
+ 	public static final String LIKE_KEY = ""likeKey"";
+ 	public static final String MATCH_KEY = ""matchKey"";
+ 	public static final String SMART_SQL = ""smartSql"";
++	public static final String ORDER_PATH = ""orderPath"";
+ 	public static final String ORDER = ""order"";
+ 	public static final String PAGE_SIZE = ""pageSize"";
+ 	public static final String QUERY_TYPE = ""queryType"";","Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided.",do we need a new constant for this? looks like it's used in two places.
+728,"@@ -38,7 +38,7 @@ export function flushMounts() {
+  * Apply differences in a given vnode (and it's deep children) to a real DOM Node.
+  * @param {import('../dom').PreactElement} dom A DOM node to mutate into the shape of a `vnode`
+  * @param {import('../vnode').VNode} vnode A VNode (with descendants forming a tree) representing
+- *  the desired DOM structure
++ *	the desired DOM structure
+  * @param {object} context The current context
+  * @param {boolean} mountAll Whether or not to immediately mount all components
+  * @param {Element} parent ?",VIM didn't like your whitespace.,Nit: the tab after `the desired DOM structure`
+729,"@@ -3,14 +3,7 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
+-using System;
+-using System.Collections.Generic;
+-using System.IO;
+-using System.Linq;
+-using System.Reflection;
+-using System.Threading;
+-using System.Threading.Tasks;
+-using Datadog.Trace.TestHelpers;
++using Datadog.Trace.ClrProfiler;
+ using Xunit;
+ using Xunit.Abstractions;
+ using Xunit.Sdk;",Are you sure the namespace should change?,Why did you remove these namespaces?
+730,"@@ -12,7 +12,7 @@ namespace MvvmCross.ViewModels
+
+         void Initialize();
+
+-        void Startup(object hint);
++        object Startup(object hint);
+
+         void Reset();
+     }",@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication<THint> with THint set to object,Why is this needed? Are there any callers that
+731,"@@ -31,6 +31,7 @@ import com.pingcap.tikv.meta.TiColumnInfo.InternalTypeHolder;
+ // https://dev.mysql.com/doc/refman/8.0/en/time.html
+
+ public class TimeType extends DataType {
++  public static final TimeType TIME = new TimeType(MySQLType.TypeDuration);
+   public static final MySQLType[] subTypes = new MySQLType[] {MySQLType.TypeDuration};
+   protected static final long NANOSECOND = 1;
+   protected static final long MICROSECOND = 1000 * NANOSECOND;",why do we create a time type here?,Why do we need this?
+732,"@@ -1,4 +1,4 @@
+-define([""jQuery"", ""datetime"", ""loading"", ""libraryMenu"", ""listViewStyle"", ""paper-icon-button-light""], function ($, datetime, loading, libraryMenu) {
++define([""jQuery"", ""datetime"", ""loading"", ""libraryMenu"", ""css!components/listview/listview"", ""paper-icon-button-light""], function ($, datetime, loading, libraryMenu) {
+     ""use strict"";
+
+     function populateRatings(allParentalRatings, page) {",Does this style actually need to get loaded in all of these components?,We should probably use the constant we already have for listview here.
+733,"@@ -30,6 +30,9 @@ import io.servicecomb.foundation.ssl.SSLCustom;
+ import io.servicecomb.foundation.ssl.SSLOption;
+ import io.servicecomb.foundation.ssl.SSLOptionFactory;
+ import io.servicecomb.foundation.vertx.VertxTLSBuilder;
++import io.servicecomb.transport.rest.vertx.accesslog.AccessLogConfiguration;
++import io.servicecomb.transport.rest.vertx.accesslog.impl.AccessLogHandlerImpl;
++import io.servicecomb.transport.rest.vertx.accesslog.parser.impl.DefaultAccessLogPatternParser;
+ import io.vertx.core.AbstractVerticle;
+ import io.vertx.core.Context;
+ import io.vertx.core.Future;",import but not used so you did not resolve compile warnings?,"Same here, no `impl` or `impl` part of the class."
+734,"@@ -865,15 +865,10 @@ BlockType_t Creature::blockHit(Creature* attacker, CombatType_t combatType, int3
+ 		}
+
+ 		if (checkArmor) {
+-			int32_t armorValue = getArmor();
+-			if (armorValue > 1) {
+-				double armorFormula = armorValue * 0.475;
+-				int32_t armorReduction = static_cast<int32_t>(std::ceil(armorFormula));
+-				damage -= uniform_random(
+-					armorReduction,
+-					armorReduction + static_cast<int32_t>(std::floor(armorFormula))
+-				);
+-			} else if (armorValue == 1) {
++			int32_t armor = getArmor();
++			if (armor > 3) {
++				damage -= uniform_random(armor / 2, armor - (armor % 2 + 1));
++			} else if (armor > 0) {
+ 				--damage;
+ 			}
+ ",This is so much more concise and beautiful than the previous formula  ,"Why not `uniform_random(armor / 2, armor % 2);`"
+735,"@@ -41,9 +41,19 @@ import org.hyperledger.besu.tests.acceptance.dsl.transaction.perm.PermissioningT
+ import org.hyperledger.besu.tests.acceptance.dsl.transaction.privacy.PrivacyTransactions;
+ import org.hyperledger.besu.tests.acceptance.dsl.transaction.web3.Web3Transactions;
+
++import java.io.File;
++
++import org.apache.logging.log4j.LogManager;
++import org.apache.logging.log4j.Logger;
++import org.apache.logging.log4j.ThreadContext;
+ import org.junit.After;
++import org.junit.Rule;
++import org.junit.rules.TestName;
++import org.junit.rules.TestWatcher;
++import org.junit.runner.Description;
+
+ public class AcceptanceTestBase {
++  protected final Logger LOG = LogManager.getLogger();
+
+   protected final Accounts accounts;
+   protected final AccountTransactions accountTransactions;",Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_,Please remove this unused import.
+736,"@@ -27,11 +27,18 @@ import (
+ // DialogCreator creates new dialog between consumer and provider, using given contact information
+ type DialogCreator func(consumerID, providerID identity.Identity, contact market.Contact) (communication.Dialog, error)
+
++// SessionCreationConfig are the parameters that get sent to the provider
++type SessionCreationConfig interface{}
++
++// ConsumerConfig are the parameters used for the initiation of connection
++type ConsumerConfig interface{}
++
+ // Connection represents a connection
+ type Connection interface {
+-	Start() error
++	Start(ConnectOptions) error
+ 	Wait() error
+ 	Stop()
++	GetSessionConfig() (SessionCreationConfig, error)
+ }
+
+ // StateChannel is the channel we receive state change events on",It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself,"`ConsumerConfig` is the interface for session creation, not a consumer config"
+737,"@@ -97,7 +97,7 @@ type ConfigLocal struct {
+ 	kbpki            KBPKI
+ 	renamer          ConflictRenamer
+ 	registry         metrics.Registry
+-	loggerFn         func(prefix string) logger.Logger
++	loggerFn         func(prefix string, overrideEnableDebug bool) logger.Logger
+ 	noBGFlush        bool // logic opposite so the default value is the common setting
+ 	rwpWaitTime      time.Duration
+ 	diskLimiter      DiskLimiter","Why is there an ""enable"" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else.",This is the only place where we have a `overrideEnableDebug` argument.
+738,"@@ -1,4 +1,8 @@
+ class VideosController < ApplicationController
++  def index
++    @videos = Video.published.recently_published_first
++  end
++
+   def show
+     @video = Video.find(params[:id])
+     @offering = Offering.new(@video.watchable, current_user)",`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?,Will this cause any problems if `@videos` is nil?
+739,"@@ -20,7 +20,11 @@ var createIntegrationPreprocessor = function(logger) {
+       // and add the test data to it
+       var htmlpath = file.originalPath.replace(extRegex, '.html');
+       var html = fs.readFileSync(htmlpath, 'utf-8');
+-      var test = JSON.parse(content);
++      try {
++        var test = JSON.parse(content);
++      } catch (e) {
++        throw new Error('Unable to parse content of ' + file.originalPath)
++      }
+       test.content = html;
+
+       var result = template.replace('{}; /*tests*/', JSON.stringify(test));",Encountered this because I had a stray comma. Figured I'd tweak it a bit.,"`var test = JSON.parse(content);` doesn't throw an exception, so `var test = "
+740,"@@ -306,6 +306,13 @@ var _ = infrastructure.DatastoreDescribe(""service loop prevention; with 2 nodes""
+ 			cfg.Spec.ServiceLoopPrevention = ""Disabled""
+ 		})
+
++		// Expect to see empty cali-cidr-block chains.  (Allowing time for a Felix
++		// restart.)  This ensures that the cali-cidr-block chain has been cleared
++		// before we try a test ping.
++		for _, felix := range felixes {
++			Eventually(getCIDRBlockRules(felix, ""iptables-save""), ""8s"", ""0.5s"").Should(BeEmpty())
++		}
++
+ 		By(""test that we DO get a routing loop"")
+ 		// (In order to test that the tryRoutingLoop setup is genuine.)
+ 		tryRoutingLoop(true)",qq: Should this include the iptables6-save sim. to the inverse checks above?,@smarterclayton do we need to change this to `0.5s` to ensure it's not empty before we try a ping?
+741,"@@ -195,8 +195,16 @@ func (cfg *Config) Merge(rhs Config) *Config {
+
+ 	for i := 0; i < left.NumField(); i++ {
+ 		leftField := left.Field(i)
+-		if utils.ZeroOrNil(leftField.Interface()) {
+-			leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++		switch leftField.Interface().(type) {
++		case BooleanDefaultFalse, BooleanDefaultTrue:
++			str, _ := json.Marshal(reflect.ValueOf(leftField.Interface()).Interface())
++			if string(str) == ""null"" {
++				leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++			}
++		default:
++			if utils.ZeroOrNil(leftField.Interface()) {
++				leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++			}
+ 		}
+ 	}
+ ",im open to explicitly checking NotSet value here but json logic already handles it so kept it this way.,Is it safe to return `null` here? Would it be safer to return an error instead?
+742,"@@ -27,6 +27,7 @@ extern ""C"" {
+ #include ""ScriptingEnvironment.h""
+ #include ""../typedefs.h""
+ #include ""../Util/OpenMPWrapper.h""
++#include ""../Util/Lua.h""
+
+ ScriptingEnvironment::ScriptingEnvironment() {}
+ ScriptingEnvironment::ScriptingEnvironment(const char * fileName) {",The naming of the include file appears to be unlucky.,why did you move this include to the cpp?
+743,"@@ -1018,7 +1018,8 @@ class BarPlot(BarsMixin, ColorbarPlot, LegendPlot):
+         if self.show_legend and any(len(l) for l in labels) and (sdim or not self.multi_level):
+             leg_spec = self.legend_specs[self.legend_position]
+             if self.legend_cols: leg_spec['ncol'] = self.legend_cols
+-            axis.legend(title=title, **leg_spec)
++            self.legend_opts.update(**leg_spec)
++            axis.legend(title=title, **self.legend_opts)
+
+         return bars, xticks, ax_dims
+ ",Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable.,is `legend_opts` always going to be a `dict`?
+744,"@@ -455,6 +455,11 @@ func (r *AWSMachinePoolReconciler) reconcileLaunchTemplate(machinePoolScope *sco
+ 	// userdata, OR we've discovered a new AMI ID.
+ 	if needsUpdate || tagsChanged || *imageID != *launchTemplate.AMI.ID || launchTemplateUserDataHash != bootstrapDataHash {
+ 		machinePoolScope.Info(""creating new version for launch template"", ""existing"", launchTemplate, ""incoming"", machinePoolScope.AWSMachinePool.Spec.AWSLaunchTemplate)
++		// There is a limit to the number of Launch Template Versions.
++		// We ensure that the number of versions does not grow without bound by following a simple rule: For each version we create, we delete one old version.
++		if err := ec2svc.PruneLaunchTemplateVersions(machinePoolScope.AWSMachinePool.Status.LaunchTemplateID); err != nil {
++			return err
++		}
+ 		if err := ec2svc.CreateLaunchTemplateVersion(machinePoolScope, imageID, bootstrapData); err != nil {
+ 			return err
+ 		}","Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing.",This should probably be `ec2svc.GetLaunchTemplateVersion()` since we're creating a new version for each launch template created.
+745,"@@ -27,13 +27,13 @@ class ContainerInformationTab extends Tab {
+
+     private final WinePrefixContainerDTO container;
+
+-    private Consumer<ContainerDTO> onDeletePrefix;
++    private Consumer<ContainerDTO> onDeleteContainer;
+     private Consumer<ContainerDTO> onOpenFileBrowser;
+
+-    ContainerInformationTab(WinePrefixContainerDTO container) {
++    ContainerInformationTab(ContainerDTO container) {
+         super(tr(""Information""));
+
+-        this.container = container;
++        this.container = (WinePrefixContainerDTO) container; // TODO: use generic container
+
+         this.setClosable(false);
+ ",Do we require the specific implementation information here?,`this.container = (WinePrefixContainerDTO)container;` ?
+746,"@@ -0,0 +1,13 @@
++class DomainBlacklist < ActiveRecord::Base
++  validates :domain, uniqueness: { case_sensitive: false }
++
++  class << self
++    def email_banned?(email_address)
++      contains?(email_address.split('@').last)
++    end
++
++    def contains?(domain)
++      exists?(['lower(domain) LIKE ?', ""%#{domain.downcase}%""])
++    end
++  end
++end","How about `exists?(['domain ~* ?', domain.downcase])` ?",Rails/InverseOf: Specify an :inverse_of option.
+747,"@@ -729,6 +729,15 @@ func newContextForLongPoll(c *cli.Context) (context.Context, context.CancelFunc)
+ 	return newContextWithTimeout(c, defaultContextTimeoutForLongPoll)
+ }
+
++func newContextForBackground(c *cli.Context) (context.Context, context.CancelFunc) {
++	if c.GlobalIsSet(FlagContextTimeout) {
++		timeout := time.Duration(c.GlobalInt(FlagContextTimeout)) * time.Second
++		return rpc.NewContextWithTimeoutAndCLIHeaders(timeout)
++	}
++
++	return rpc.NewContextWithCLIHeaders()
++}
++
+ func newContextWithTimeout(c *cli.Context, timeout time.Duration) (context.Context, context.CancelFunc) {
+ 	if c.GlobalIsSet(FlagContextTimeout) {
+ 		timeout = time.Duration(c.GlobalInt(FlagContextTimeout)) * time.Second",Is this getting used in other places? Can we switch all the places to use the new API you added?,Do we need the `if c.GlobalIsSet(FlagContextTimeout) {` check below?
+748,"@@ -483,17 +483,6 @@ int HTTP_OP::libcurl_exec(
+     curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, 1L);
+     //curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, FALSE);
+
+-    // if the above is nonzero, you need the following:
+-    //
+-#ifndef _WIN32
+-    if (boinc_file_exists(CA_BUNDLE_FILENAME)) {
+-        // call this only if a local copy of ca-bundle.crt exists;
+-        // otherwise, let's hope that it exists in the default place
+-        //
+-        curl_easy_setopt(curlEasy, CURLOPT_CAINFO, CA_BUNDLE_FILENAME);
+-    }
+-#endif
+-
+     // set the user agent as this boinc client & version
+     //
+     curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);","This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file.",Why is this being removed?
+749,"@@ -1,12 +1,12 @@
+-define(['browser', 'dom', 'layoutManager', 'css!components/viewManager/viewContainer'], function (browser, dom, layoutManager) {
+-    'use strict';
++import 'css!components/viewManager/viewContainer';
++/* eslint-disable indent */
+
+     function setControllerClass(view, options) {
+         if (options.controllerFactory) {
+             return Promise.resolve();
+         }
+
+-        var controllerUrl = view.getAttribute('data-controller');
++        let controllerUrl = view.getAttribute('data-controller');
+
+         if (controllerUrl) {
+             if (controllerUrl.indexOf('__plugin/') === 0) {",Shouldn't we import `default`? I can't get here to test.,Nit: Let's rename this var
+750,"@@ -99,7 +99,7 @@ class UNIXServerClient(object):
+         self.unix_socket = os.path.join(self.temp_dir, 'luigid.sock')
+
+     def run_server(self):
+-        luigi.server.run(unix_socket=unix_socket)
++        luigi.server.run(unix_socket=self.unix_socket)
+
+     def scheduler(self):
+         url = ParseResult(","!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???",Not sure why this was work
+751,"@@ -484,11 +484,11 @@ namespace Microsoft.DotNet.Execute
+         public string FormatSetting(string option, string value, string type, string toolName)
+         {
+             string commandOption = null;
+-            if (type.Equals(""passThrough""))
++            if (type != null && type.Equals(""passThrough""))
+             {
+                 commandOption = string.Format("" {0}"", toolName.Equals(""console"") ? """" : value);
+             }
+-            else if (type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }
++            else if (type != null && type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }
+             else
+             {
+                 Tool toolFormat;","I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way.",How about `!string.IsNullO
+752,"@@ -1,4 +1,11 @@
+ var parent = axe.commons.dom.getComposedParent(node);
+-return (['UL', 'OL'].includes(parent.nodeName.toUpperCase()) ||
+-    (parent.getAttribute('role') || '').toLowerCase() === 'list');
+-
++
++var parentRole = (parent.getAttribute('role') || '').toLowerCase();
++
++var isListRole = parentRole === 'list';
++
++return (
++	(['UL', 'OL'].includes(parent.nodeName.toUpperCase()) &&
++		(!parentRole || isListRole)) ||
++	isListRole
++);",This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?,"`(!parentRole || isListRole)`, `(!parentRole || isListRole)`, and below too"
+753,"@@ -4,10 +4,10 @@
+ package stack
+
+ import (
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/template""
+ 	""github.com/aws/aws-sdk-go/service/cloudformation""
++	""github.com/aws/copilot-cli/internal/pkg/template""
+
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy""
++	""github.com/aws/copilot-cli/internal/pkg/deploy""
+ )
+
+ const pipelineCfnTemplatePath = ""cicd/pipeline_cfn.yml""","The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?",Can we move this to the `aws/internal/pkg/deploy` package?
+754,"@@ -60,7 +60,7 @@ public class Program
+             // turn off the above default. i.e any
+             // instrument which does not match any views
+             // gets dropped.
+-            // .AddView(instrumentName: ""*"", new DropAggregationConfig())
++            // .AddView(instrumentName: ""*"", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })
+             .AddConsoleExporter()
+             .Build();
+ ",Consider making a constant (e.g. `MetricStreamConfiguration.Drop`).,"Same here, let's remove this."
+755,"@@ -18,6 +18,7 @@ try:
+ except ImportError:
+   from rdkit.piddle import piddle
+ import ClusterUtils
++from rdkit.six.moves import xrange
+
+ import numpy
+ ",same question: why not just switch this to range too?,why do you need this?
+756,"@@ -111,10 +111,10 @@ Variable IO::InquireVariable(const std::string &name)
+     helper::CheckForNullptr(m_IO, ""for variable "" + name +
+                                       "", in call to IO::InquireVariable"");
+
+-    const std::string type(m_IO->InquireVariableType(name));
++    const Type type(m_IO->InquireVariableType(name));
+     core::VariableBase *variable = nullptr;
+
+-    if (type == ""unknown"")
++    if (type == Type::None)
+     {
+     }
+ #define declare_template_instantiation(T)                                      \","@chuckatkins most places used an empty string for ""no type"", but a few used `""unknown""`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?",Could you please change `m_IO->InquireVariableType(name)` to `Type::Unknown`?
+757,"@@ -408,7 +408,7 @@ void CUDATreeLearner::copyDenseFeature() {
+     // looking for dword_features_ non-sparse feature-groups
+     if (!train_data_->IsMultiGroup(i)) {
+       dense_feature_group_map_.push_back(i);
+-      auto sizes_in_byte = train_data_->FeatureGroupSizesInByte(i);
++      auto sizes_in_byte = std::min(train_data_->FeatureGroupSizesInByte(i), static_cast<size_t>(num_data_));
+       void* tmp_data = train_data_->FeatureGroupData(i);
+       Log::Debug(""Started copying dense features from CPU to GPU - 2"");
+       CUDASUCCESS_OR_FATAL(cudaMemcpyAsync(&device_features[copied_feature * num_data_], tmp_data, sizes_in_byte, cudaMemcpyHostToDevice, stream_[device_id]));",should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type.,Does this work if you just do a memcpy with a `std::size_t`?
+758,"@@ -51,10 +51,10 @@ class TestCube(ComparisonTestCase):
+     def test_dimension_values_vdim(self):
+         cube = Dataset(self.cube, kdims=['longitude', 'latitude'])
+         self.assertEqual(cube.dimension_values('unknown', flat=False),
+-                         np.flipud(np.array([[ 0,  4,  8],
+-                                             [ 1,  5,  9],
+-                                             [ 2,  6, 10],
+-                                             [ 3,  7, 11]], dtype=np.int32).T))
++                         np.array([[ 0,  4,  8],
++                                   [ 1,  5,  9],
++                                   [ 2,  6, 10],
++                                   [ 3,  7, 11]], dtype=np.int32).T)
+
+     def test_range_kdim(self):
+         cube = Dataset(self.cube, kdims=['longitude', 'latitude'])",As long as you are sure this is definitely correct now... :-),Any idea why there was a `np.flipud` call here?
+759,"@@ -166,7 +166,7 @@ public class ActionsFragment extends SubscriberFragment implements View.OnClickL
+                             tempBasal.setVisibility(View.GONE);
+                             tempBasalCancel.setVisibility(View.VISIBLE);
+                             final TemporaryBasal activeTemp = MainApp.getConfigBuilder().getTempBasalFromHistory(System.currentTimeMillis());
+-                            tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + ""\n"" + activeTemp.toStringShort());
++                            tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + "" "" + activeTemp.toStringShort());
+                         } else {
+                             tempBasal.setVisibility(View.VISIBLE);
+                             tempBasalCancel.setVisibility(View.GONE);",... so that all action buttons have the same height :-),Is this change intentional? It looks like the new string doesn't have any new
+760,"@@ -21,6 +21,12 @@
+ #include <fastdds/dds/log/Log.hpp>
+ #include <fastdds/dds/log/Colors.hpp>
+ #include <fastrtps/xmlparser/XMLProfileManager.h>
++#include <fastdds/dds/domain/DomainParticipantFactory.hpp>
++#include <fastdds/dds/domain/DomainParticipant.hpp>
++#include <fastdds/dds/publisher/DataWriterListener.hpp>
++#include <fastdds/dds/subscriber/qos/DataReaderQos.hpp>
++#include <fastdds/dds/subscriber/DataReader.hpp>
++#include <fastdds/dds/publisher/DataWriter.hpp>
+
+ #include <numeric>
+ #include <cmath>","Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `""LatencyTestPublisher.hpp""`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers",Is DataWriter.hpp used anywhere? Can we remove it?
+761,"@@ -58,6 +58,10 @@ type OutboundOption func(*Outbound)
+
+ func (OutboundOption) httpOption() {}
+
++// RequestFactory allows clients to configure their outgoing http requests. If not set,
++// a default implemenation will use the HostPort to make a POST request with the request body.
++type RequestFactory func(*transport.Request) (*http.Request, error)
++
+ // URLTemplate specifies the URL this outbound makes requests to. For
+ // peer.Chooser-based outbounds, the peer (host:port) spection of the URL may
+ // vary from call to call but the rest will remain unchanged. For single-peer","I hate this name, open to suggestions.",Maybe rename to `RequestFactory` to make it clear
+762,"@@ -199,7 +199,13 @@ func (c *Client) locallyCacheResults(target *core.BuildTarget, digest *pb.Digest
+ 	}
+ 	data, _ := proto.Marshal(ar)
+ 	metadata.RemoteAction = data
+-	c.state.Cache.Store(target, c.localCacheKey(digest), nil)
++	// TODO(jpoole): Similar to retrieveTargetMetadataFromCache, it would be cleaner if we could store
++	//               into the cache from an arbitrary reader.
++	if err := build.StoreTargetMetadata(target, metadata); err != nil {
++		log.Warning(""%s"", err)
++		return
++	}
++	c.state.Cache.Store(target, c.localCacheKey(digest), []string{target.TargetBuildMetadataFileName()})
+ }
+
+ // retrieveLocalResults retrieves locally cached results for a target if possible.",Does this log line work? We need Warningf or just warning without the format string.,Should we rename `cachedTargetsCache` so that it i
+763,"@@ -62,6 +62,7 @@ func New(checkpointer export.Checkpointer, exporter export.Exporter, opts ...Opt
+ 	impl := sdk.NewAccumulator(
+ 		checkpointer,
+ 		sdk.WithResource(c.Resource),
++		sdk.WithMetricsProcessors(c.MetricsProcessors...),
+ 	)
+ 	return &Controller{
+ 		provider:     registry.NewMeterProvider(impl),",The pull controller would need similar updates.,Why do we need this in the controller? Couldn't we
+764,"@@ -1,5 +1,5 @@
+ /**
+- * Copyright 2015-2017 The OpenZipkin Authors
++ * Copyright 2015-2018 The OpenZipkin Authors
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except
+  * in compliance with the License. You may obtain a copy of the License at",ignore this.. just didn't want to litter with a commit update to satisfy license plugin,Copyright date should not change.
+765,"@@ -807,8 +807,8 @@ module Beaker
+         end
+
+         if host['is_cygwin'].nil? or host['is_cygwin'] == true
+-          dest = ""/cygdrive/c/Windows/Temp/#{host['dist']}.msi""
+-          on host, ""curl -O #{dest} #{link}""
++          dest = ""#{host['dist']}.msi""
++          on host, ""curl -O #{link}""
+
+           #Because the msi installer doesn't add Puppet to the environment path
+           #Add both potential paths for simplicity",Is this definition needed since it doesn't look like it's being used anywhere?,Was this not working before?
+766,"@@ -35,6 +35,11 @@ module Mongoid
+           class << self
+             delegate :discriminator_key, to: ::Mongoid
+           end
++        end
++
++        unless fields.has_key?(self.discriminator_key) || descendants.length == 0
++          default_proc = lambda { self.class.name }
++          field(self.discriminator_key, default: default_proc, type: String)
+         end
+       end
+     end",Can this condition be reworded using `if` please?,why is this not a `if descendants
+767,"@@ -135,13 +135,15 @@ Status FetchEdgesExecutor::setupEdgeKeysFromRef() {
+     const InterimResult *inputs;
+     if (sentence_->ref()->isInputExpr()) {
+         inputs = inputs_.get();
+-        if (inputs == nullptr) {
++        if (inputs == nullptr
++                || (inputs != nullptr && !inputs->hasData())) {
+             // we have empty imputs from pipe.
+             return Status::OK();
+         }
+     } else {
+         inputs = ectx()->variableHolder()->get(varname_);
+-        if (inputs == nullptr) {
++        if (inputs == nullptr
++                || (inputs != nullptr && !inputs->hasData())) {
+             return Status::Error(""Variable `%s' not defined"", varname_.c_str());
+         }
+     }","after ||, no need inputs != nullptr",Should have used `!inputs->hasDat
+768,"@@ -159,7 +159,14 @@ func (s *Source) Owner() (string, error) {
+ // is deloying to and the containerized applications that will be deployed.
+ type PipelineStage struct {
+ 	*AssociatedEnvironment
+-	LocalApplications []string
++	LocalApplications []AppInStage
++}
++
++// AppInStage represents configurations for an app in a pipeline stage
++type AppInStage struct {
++	Name string
++	// the path to the integration test buildspec for this action
++	IntegTestBuildspecPath string
+ }
+
+ // AppTemplatePath returns the full path to the application CFN template",Is it just preference or on purpose that using slice of structs instead of slice of pointers?,struct field IntegTestBuildspecPath should be TestBuildspecPath
+769,"@@ -90,7 +90,7 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi
+ 					c.state = c._nextState;
+ 					c._dirty = false;
+ 					c._vnode = newVNode;
+-					newVNode._dom = oldDom!=null ? oldDom!==oldVNode._dom ? oldDom : oldVNode._dom : null;
++					newVNode._dom = oldVNode._dom;
+ 					newVNode._children = oldVNode._children;
+ 					for (tmp = 0; tmp < newVNode._children.length; tmp++) {
+ 						if (newVNode._children[tmp]) newVNode._children[tmp]._parent = newVNode;",This line always confused me   anyway. Good catch!,"I don't understand this change. If `oldDom` is null, then `newV"
+770,"@@ -130,6 +130,6 @@ func (j journalBlockServer) IsUnflushed(ctx context.Context, tlfID tlf.ID,
+ }
+
+ func (j journalBlockServer) Shutdown() {
+-	j.jServer.shutdown()
++	j.jServer.shutdown(context.Background())
+ 	j.BlockServer.Shutdown()
+ }","Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much.",Is this a blocking call?
+771,"@@ -42,7 +42,7 @@ bool DeadlineQosPolicy::addToCDRMessage(CDRMessage_t* msg)
+     bool valid = CDRMessage::addUInt16(msg, this->Pid);
+     valid &= CDRMessage::addUInt16(msg, this->length);//this->length);
+     valid &= CDRMessage::addInt32(msg,period.seconds);
+-    valid &= CDRMessage::addUInt32(msg,period.fraction);
++    valid &= CDRMessage::addUInt32(msg,period.nanosec);
+     return valid;
+ }
+ ",Duration_t at RTPS level must be serialized using fractions.,Is this change intentional? Shouldn't it be addInt32?
+772,"@@ -28,6 +28,14 @@ import (
+ 	""go.uber.org/yarpc/yarpcerrors""
+ )
+
++var msgInboundDispatcherNotRunning = ""peer for service %q is not running""
++
++// NotRunningInboundError builds a YARPC error with code
++// yarpcerrors.CodeUnavailable when the dispatcher is not running.
++func NotRunningInboundError(service string) error {
++	return yarpcerrors.UnavailableErrorf(msgInboundDispatcherNotRunning, service)
++}
++
+ // RequestBodyDecodeError builds a YARPC error with code
+ // yarpcerrors.CodeInvalidArgument that represents a failure to decode
+ // the request body.","""peer"" has its own meaning within YARPC with its own class of objects. This should probably be ""dispatcher"" too?",I think this should be `NotRunningInboundError`.
+773,"@@ -172,9 +172,18 @@ class ClangSA(analyzer_base.SourceAnalyzer):
+                                          '-Xclang', checker_name])
+
+             if config.ctu_dir and not self.__disable_ctu:
++                # ctu-clang5 compatibility
+                 analyzer_cmd.extend(['-Xclang', '-analyzer-config',
+                                      '-Xclang',
+-                                     'xtu-dir=' + self.get_xtu_dir()])
++                                     'xtu-dir=' + self.get_ctu_dir()])
++                # ctu-clang6 compatibility (5.0 and 6.0 options work together)
++                analyzer_cmd.extend(['-Xclang', '-analyzer-config',
++                                     '-Xclang',
++                                     'experimental-enable-naive-ctu-analysis'
++                                     '=true',
++                                     '-Xclang', '-analyzer-config',
++                                     '-Xclang',
++                                     'ctu-dir=' + self.get_ctu_dir()])
+                 if config.ctu_has_analyzer_display_ctu_progress:
+                     analyzer_cmd.extend(['-Xclang',
+                                          '-analyzer-display-ctu-progress'])",I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together.,Maybe `-Xclang-experimental-ctu-analysis` should
+774,"@@ -34,18 +34,10 @@ import (
+ // the default value in Default var.
+
+ func init() {
+-	flag.StringVar(&_overwritePath, ""config-path"", """", ""Config path"")
+-	flag.StringVar(&_secretPath, ""secret-path"", """", ""Secret path"")
+-	flag.StringVar(&_subChainPath, ""sub-config-path"", """", ""Sub chain Config path"")
+ 	flag.Var(&_plugins, ""plugin"", ""Plugin of the node"")
+ }
+
+ var (
+-	// overwritePath is the path to the config file which overwrite default values
+-	_overwritePath string
+-	// secretPath is the path to the  config file store secret values
+-	_secretPath   string
+-	_subChainPath string
+ 	_plugins      strs
+ 	_evmNetworkID uint32
+ 	loadChainID   sync.Once",_plugins should be removed too,Is this a substantial change? Seems unrelated.
+775,"@@ -0,0 +1,5 @@
++let nn = node.nodeName.toLowerCase();
++let validSetup =
++	node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area');
++let validAttrValue = /^\s+$/.test(node.getAttribute('alt'));
++return validSetup && validAttrValue;","The rule selector will not include `<input>` and `<area>` elements. Why not make this a new, separate rule altogether?",what if `alt` is empty?
+776,"@@ -1122,7 +1122,7 @@ class CommandDispatcher:
+         try:
+             userscripts.run_async(tab, cmd, *args, win_id=self._win_id,
+                                   env=env, verbose=verbose)
+-        except userscripts.UnsupportedError as e:
++        except (userscripts.UnsupportedError, userscripts.NotFoundError) as e:
+             raise cmdexc.CommandError(e)
+
+     @cmdutils.register(instance='command-dispatcher', scope='window')",@The-Compiler Is this style okay or would you prefer a common userscript exception base?,Why is this change required?
+777,"@@ -98,7 +98,8 @@ SchemaBuffer.prototype.cast = function (value, doc, init) {
+
+     return value;
+   } else if (value instanceof Binary) {
+-    return new MongooseBuffer(value.value(true), [this.path, doc]);
++    var sub_type = value.sub_type || 0x00;
++    return (new MongooseBuffer(value.value(true), [this.path, doc])).toObject(sub_type);
+   }
+
+   if (null === value) return value;",we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead.,You need to do `instanceof M
+778,"@@ -1158,7 +1158,6 @@ function updateDocuments(coll, selector, document, options, callback) {
+   if ('function' === typeof options) (callback = options), (options = null);
+   if (options == null) options = {};
+   if (!('function' === typeof callback)) callback = null;
+-
+   // If we are not providing a selector or document throw
+   if (selector == null || typeof selector !== 'object')
+     return callback(toError('selector must be a valid JavaScript object'));",Let's remove this change.,remove this empty line
+779,"@@ -727,7 +727,7 @@ def processNegativeStates(role, states, reason, negativeStates=None):
+ 	# but only if it is either focused or this is something other than a change event.
+ 	# The condition stops ""not selected"" from being spoken in some broken controls
+ 	# when the state change for the previous focus is issued before the focus change.
+-	if role in (ROLE_LISTITEM, ROLE_TREEVIEWITEM, ROLE_TABLEROW) and STATE_SELECTABLE in states and (reason != REASON_CHANGE or STATE_FOCUSED in states):
++	if role in (ROLE_LISTITEM, ROLE_TREEVIEWITEM, ROLE_TABLEROW,ROLE_TABLECELL,ROLE_TABLECOLUMNHEADER,ROLE_TABLEROWHEADER) and STATE_SELECTABLE in states and (reason != REASON_CHANGE or STATE_FOCUSED in states):
+ 		speakNegatives.add(STATE_SELECTED)
+ 	# Restrict ""not checked"" in a similar way to ""not selected"".
+ 	if (role in (ROLE_CHECKBOX, ROLE_RADIOBUTTON, ROLE_CHECKMENUITEM) or STATE_CHECKABLE in states)  and (STATE_HALFCHECKED not in states) and (reason != REASON_CHANGE or STATE_FOCUSED in states):",Could you split this into multiple lines?,Please split this into multi
+780,"@@ -25,12 +25,17 @@ import { __ } from '@wordpress/i18n';
+ /**
+  * Internal dependencies
+  */
+-import Layout from '../../../components/layout/layout';
++import Data from 'googlesitekit-data';
+ import DashboardModuleHeader from '../../../components/dashboard/dashboard-module-header';
+ import DashboardPageSpeed from '../components/DashboardPageSpeed';
++import { STORE_NAME } from '../../../googlesitekit/datastore/site/constants';
++const { useSelect } = Data;
+
+ function DashboardSpeed() {
+-	const description = global.googlesitekit.permaLink ? __( 'How fast this page is.', 'google-site-kit' ) : __( 'How fast your home page is.', 'google-site-kit' );
++	const currentEntityURL = useSelect( ( select ) => select( STORE_NAME ).getCurrentEntityURL() );
++	const description = currentEntityURL
++		? __( 'How fast your page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' )
++		: __( 'How fast your home page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' );
+
+ 	return (
+ 		<Fragment>","This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that.","If we don't use `useSelect`, we can remove the reference to `storeName` altogether."
+781,"@@ -69,9 +69,9 @@ func (c *WSClient) Connect() (conn.Connection, error) {
+ 	if resp != nil {
+ 		body, errRead := ioutil.ReadAll(resp.Body)
+ 		if errRead == nil {
+-			respMsg = fmt.Sprintf(""response code: %d, response body: %s"", resp.StatusCode, string(body))
++			respMsg = fmt.Sprintf(""Response code: %d, response body: %s"", resp.StatusCode, string(body))
+ 		} else {
+-			respMsg = fmt.Sprintf(""response code: %d"", resp.StatusCode)
++			respMsg = fmt.Sprintf(""Response code: %d"", resp.StatusCode)
+ 		}
+ 		resp.Body.Close()
+ 	}",It does not recommend capitalization,Are the changes in this file necessary?
+782,"@@ -113,6 +113,17 @@ feature 'User creates a subscription' do
+     expect(page).to have_content(I18n.t('subscriptions.flashes.update.success'))
+   end
+
++  scenario 'updates Stripe subscription with declining credit card', :js => true do
++    FakeStripe.failure = true
++    sign_in_as_subscriber
++    visit my_account_path
++    submit_declining_credit_card_info
++
++    expect(current_path).to eq my_account_path
++    expect(page).to_not have_content(I18n.t('subscriptions.flashes.update.success'))
++    expect(page).to have_content 'Your credit card was declined'
++  end
++
+   scenario 'does not see option to update billing if not subscribing' do
+     visit my_account_path
+ ","Minor thing, but can you use 1.9 hash syntax for this?",The text of the card should be `Your credit card was declined`.
+783,"@@ -361,6 +361,7 @@ class LambdaExecutorReuseContainers(LambdaExecutorContainers):
+
+                 mount_volume = not config.LAMBDA_REMOTE_DOCKER
+                 lambda_cwd_on_host = Util.get_host_path_for_path_in_docker(lambda_cwd)
++                lambda_cwd_on_host = Util.format_windows_path(lambda_cwd)
+                 mount_volume_str = '-v ""%s"":/var/task' % lambda_cwd_on_host if mount_volume else ''
+
+                 # Create and start the container",I tried to follow the code structure already present.,Should we put this in `Util.get_host_path_for_path_in_docker`?
+784,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,Path.toString() is not guaranteed to return the same path as in the other cases.
+785,"@@ -118,7 +118,7 @@ class ExperimentTestBaseClass(HelperTestCaseBase):
+     global g_myEnv
+     if not g_myEnv:
+       # Setup environment
+-      params = type('obj', (object,), {'installDir' : os.environ['NUPIC']})
++      params = type('obj', (object,), {'installDir' : resource_filename(""nupic"","""")})
+       g_myEnv = MyTestEnvironment(params)
+
+ ",Please leave 1 space char between commas here and other places in this PR.,"resource_filename(""nupic"") is not a valid resource name for a file in /tmp/nupic"
+786,"@@ -100,8 +100,8 @@ bool ThreadsExec::spawn() {
+
+   pthread_attr_t attr;
+
+-  if (0 == pthread_attr_init(&attr) ||
+-      0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) ||
++  if (0 == pthread_attr_init(&attr) &&
++      0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) &&
+       0 == pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED)) {
+     pthread_t pt;
+ ",hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?,Shouldn't we also be checking pthread_attr_setdetachstate() ?
+787,"@@ -149,7 +149,8 @@ public class PackageTool extends SolrCLI.ToolBase {
+                 String version = parsedVersion.second();
+                 boolean noprompt = cli.hasOption('y');
+                 boolean isUpdate = cli.hasOption(""update"") || cli.hasOption('u');
+-                packageManager.deploy(packageName, version, PackageUtils.validateCollections(cli.getOptionValue(""collections"").split("","")), cli.getOptionValues(""param""), isUpdate, noprompt);
++                String collections[] = cli.hasOption(""collections"")? PackageUtils.validateCollections(cli.getOptionValue(""collections"").split("","")): new String[] {};
++                packageManager.deploy(packageName, version, collections, cli.hasOption(""cluster""), cli.getOptionValues(""param""), isUpdate, noprompt);
+                 break;
+               }
+               case ""undeploy"":",Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this,This looks like it will break if the user provides both `--collections` and `--c
+788,"@@ -259,6 +259,12 @@ bool pmix_value_cmp(pmix_value_t *p, pmix_value_t *p1)
+         case PMIX_STRING:
+             rc = strcmp(p->data.string, p1->data.string);
+             break;
++        case PMIX_COMPRESSED_STRING:
++            if (p->data.bo.size != p1->data.bo.size) {
++                return false;
++            } else {
++                return true;
++            }
+         case PMIX_STATUS:
+             rc = (p->data.status == p1->data.status);
+             break;",@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same.,"Can the data.bo.size be equal to the size of the pointer? If so, we should compare the pointer to the pointer to compare against, not just the size of the pointer."
+789,"@@ -1601,6 +1601,7 @@ void nano::json_handler::bootstrap ()
+ {
+ 	std::string address_text = request.get<std::string> (""address"");
+ 	std::string port_text = request.get<std::string> (""port"");
++	const bool confirmed_frontiers = request.get<bool> (""confirmed_frontiers"", false);
+ 	boost::system::error_code address_ec;
+ 	auto address (boost::asio::ip::address_v6::from_string (address_text, address_ec));
+ 	if (!address_ec)",I think `bypass_frontier_confirmation` conveys the intention better (default false as well),Please use `request_bool` for consistency with the rest of the code base.
+790,"@@ -5,12 +5,9 @@ import (
+ 	""fmt""
+ 	""testing""
+
+-	""github.com/ipfs/go-cid""
+-	""github.com/ipfs/go-hamt-ipld""
+-	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/assert""
+-	""github.com/stretchr/testify/require""
+
++	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/chain""
+ 	""github.com/filecoin-project/go-filecoin/config""
+ 	""github.com/filecoin-project/go-filecoin/core""","This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too.",Did you mean to delete this line?
+791,"@@ -666,9 +666,10 @@ class AbstractAudio(QObject):
+     muted_changed = pyqtSignal(bool)
+     recently_audible_changed = pyqtSignal(bool)
+
+-    def __init__(self, parent=None):
++    def __init__(self, tab, parent=None):
+         super().__init__(parent)
+         self._widget = None
++        self._tab = tab
+
+     def set_muted(self, muted: bool):
+         """"""Set this tab as muted or not.""""""",You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`.,Is there a reason you couldn't just do `self._tab = tab`?
+792,"@@ -1,19 +1,3 @@
+-/*
+-Copyright 2019 The Kubernetes Authors.
+-
+-Licensed under the Apache License, Version 2.0 (the ""License"");
+-you may not use this file except in compliance with the License.
+-You may obtain a copy of the License at
+-
+-    http://www.apache.org/licenses/LICENSE-2.0
+-
+-Unless required by applicable law or agreed to in writing, software
+-distributed under the License is distributed on an ""AS IS"" BASIS,
+-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-See the License for the specific language governing permissions and
+-limitations under the License.
+-*/
+-
+ package helpers
+
+ import (",@csrwng what should we do here? This one is from origin.,Why was this deleted?
+793,"@@ -17,6 +17,7 @@
+ #include <LightGBM/utils/openmp_wrapper.h>
+ #include <LightGBM/utils/random.h>
+ #include <LightGBM/utils/threading.h>
++#include <LightGBM/utils/LocaleContext.h>
+
+ #include <string>
+ #include <cstdio>",Follow alphabetical order.,@mhoemmen why is this
+794,"@@ -0,0 +1,16 @@
++// <copyright file=""IAutomaticTracer.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.ClrProfiler
++{
++    internal interface IAutomaticTracer : ICommonTracer
++    {
++        object GetDistributedTrace();
++
++        void SetDistributedTrace(object trace);
++
++        void Register(object manualTracer);
++    }
++}","As far as I can tell, these always get and set the context as an `IReadOnlyDictionary<string, string>`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary<string, string>`?",I'm wondering if we s
+795,"@@ -206,7 +206,7 @@ class CompletionItemDelegate(QStyledItemDelegate):
+             else:
+                 self._doc.setPlainText(self._opt.text)
+         else:
+-            self._doc.setHtml('<b>{}</b>'.format(html.escape(self._opt.text)))
++            self._doc.setHtml('{}'.format(html.escape(self._opt.text)))
+
+     def _draw_focus_rect(self):
+         """"""Draw the focus rectangle of an ItemViewItem.""""""","As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`",The text of the item
+796,"@@ -161,6 +161,8 @@ public class Constants {
+
+     // enable Quartz Scheduler if true.
+     public static final String ENABLE_QUARTZ= ""azkaban.server.schedule.enable_quartz"";
++
++    public static final String CUSTOM_CREDENTIAL_NAME = ""azkaban.security.credential"";
+   }
+
+   public static class FlowProperties {",Where would this be configured? In azkaban.properties?,The property `custom_credential` is a property for the `azkaban.security.credential` secret. The `azkaban.security.credential` secret is used for the `azkaban.server.schedule.enable_quartz` property to enable the Quartz Scheduler. The `custom_credential` property is used for the Quartz Scheduler only.
+797,"@@ -2101,6 +2101,12 @@ Collection.prototype.findOneAndUpdate = function(filter, update, options, callba
+   if (typeof options === 'function') (callback = options), (options = {});
+   options = options || {};
+
++  var err = checkForAtomicOperators(update);
++  if (err) {
++    if (typeof callback === 'function') return callback(err);
++    return this.s.promiseLibrary.reject(err);
++  }
++
+   // Basic validation
+   if (filter == null || typeof filter !== 'object')
+     throw toError('filter parameter must be an object');",1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`.,"Is the `callback` optional? If so, you should add it to the `options` declaration."
+798,"@@ -29,6 +29,13 @@ struct st_h2o_multithread_queue_t {
+ #if H2O_USE_LIBUV
+     uv_async_t async;
+ #else
++#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
++/**
++ * The kernel overhead of an eventfd file descriptor is
++ * much lower than that of a pipe, and only one file descriptor is required
++ */
++#define H2O_ASYNC_NOTIFY_USING_EVENTFD
++#endif
+     struct {
+         int write;
+         h2o_socket_t *read;","Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users.",(style) Macros with complex values should be enclosed in parentheses
+799,"@@ -61,6 +61,7 @@ public class DatabaseTransferConsumer implements IDataTransferConsumer<DatabaseC
+         IDataTransferNodePrimary, DBPReferentialIntegrityController {
+     private static final Log log = Log.getLog(DatabaseTransferConsumer.class);
+
++    private DBCStatistics statistics = new DBCStatistics();
+     private DatabaseConsumerSettings settings;
+     private DatabaseMappingContainer containerMapping;
+     private ColumnMapping[] columnMappings;",This field could be `final`.,"Same as above, I don't think it's necessary to create a new instance, just use the one from the settings."
+800,"@@ -62,8 +62,14 @@ module Beaker
+     def close
+       begin
+         @ssh.close if @ssh
+-      rescue
+-        @ssh.shutdown!
++      rescue => e
++        @logger.warn ""Attemped ssh.close.  Caught an error: #{e.message}  Attempting ssh.shutdown!...""
++        begin
++          @ssh.shutdown!
++        rescue => e
++          @logger.warn ""Attemped ssh.shutdown!.  Caught an error: #{e.message}. Giving up and destorying ssh.""
++          @ssh = nil
++        end
+       end
+       @ssh = nil
+     end",would be good to have a test for the case when `shutdown!` raises,Metrics/LineLength: Line is too long. [90/80]
+801,"@@ -2747,6 +2747,10 @@ short HbaseInsert::codeGen(Generator *generator)
+
+   generator->initTdbFields(hbasescan_tdb);
+
++  if (CmpCommon::getDefault(HBASE_ASYNC_OPERATIONS) == DF_ON
++           && t == ComTdbHbaseAccess::INSERT_)
++     hbasescan_tdb->setAsyncOperations(TRUE);
++
+   if (getTableDesc()->getNATable()->isSeabaseTable())
+     {
+       hbasescan_tdb->setSQHbaseTable(TRUE);",Does upsert pass this check also?,Why is the default set to TRUE here?
+802,"@@ -43,6 +43,9 @@ func (r *helper) Patch(name types.NamespacedName, kind, apiVersion string, patch
+ 			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Warn(""running the patch command failed"")
+ 		return err
+ 	}
++	r.logger.
++		WithField(""stdout"", ioStreams.Out.(*bytes.Buffer).String()).
++		WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Info(""patch command successful"")
+ 	return nil
+ }
+ ","Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all.",I think this should be a `Warn` level log.
+803,"@@ -23,6 +23,7 @@ import (
+ const (
+ 	kbfsRepoDir         = "".kbfs_git""
+ 	kbfsConfigName      = ""kbfs_config""
++	kbfsConfigNameTemp  = ""._kbfs_config""
+ 	gitSuffixToIgnore   = "".git""
+ 	kbfsDeletedReposDir = "".kbfs_deleted_repos""
+ )",I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems.,Does it make sense to have a test that confir
+804,"@@ -1,4 +1,4 @@
+-class AddIndexOnSectionIdAndTeacherIdToSectionTeachers < ActiveRecord::Migration
++class AddIndexOnSectionIdAndTeacherIdToSectionTeachers < ActiveRecord::Migration[4.2]
+   def up
+     change_table :section_teachers do |t|
+       t.remove_index :section_id",Metrics/LineLength: Line is too long. [85/80],Line is too long. [108/80]
+805,"@@ -19,12 +19,13 @@
+
+ package org.apache.iceberg.flink;
+
+-
+ import java.util.List;
+ import org.apache.flink.table.api.SqlParserException;
+ import org.apache.iceberg.AssertHelpers;
+ import org.apache.iceberg.FileFormat;
+ import org.apache.iceberg.catalog.Namespace;
++import org.apache.iceberg.events.Listeners;
++import org.apache.iceberg.events.ScanEvent;
+ import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+ import org.junit.After;
+ import org.junit.Assert;",Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes.,Why not just use Iceberg.e
+806,"@@ -112,7 +112,10 @@ static int http_post(struct flb_out_http *ctx,
+                         payload_buf, payload_size,
+                         ctx->host, ctx->port,
+                         ctx->proxy, 0);
+-
++    if (!c) {
++        flb_plg_error(ctx->ins, ""[http_client] failed to create HTTP client"");
++        return FLB_RETRY;
++    }
+
+     if (c->proxy.host) {
+         flb_plg_debug(ctx->ins, ""[http_client] proxy host: %s port: %i"",","thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too.",I'm confused why we can't
+807,"@@ -492,10 +492,13 @@ class MainWindow(QWidget):
+     @pyqtSlot(bool)
+     def _on_fullscreen_requested(self, on):
+         if on:
+-            self.state_before_fullscreen = self.windowState()
+-            self.showFullScreen()
++            self.window_state_before_fullscreen = self.windowState()
++            self.config_state_before_fullscreen = config.val.content.desktop_fullscreen
++            if config.val.content.desktop_fullscreen:
++                self.showFullScreen()
+         elif self.isFullScreen():
+-            self.setWindowState(self.state_before_fullscreen)
++            if config.val.content.desktop_fullscreen or self.config_state_before_fullscreen:
++                self.setWindowState(self.window_state_before_fullscreen)
+         log.misc.debug('on: {}, state before fullscreen: {}'.format(
+             on, debug.qflags_key(Qt, self.state_before_fullscreen)))
+ ","If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`).",It looks like `self.window
+808,"@@ -53,6 +53,7 @@ public class MapLayerMetadata implements Serializable {
+     // ForeignKey to DataFile
+     //x@ManyToOne
+     // For now, make this unique:  Each DataFile may only have one map
++    //@OneToOne(cascade = {CascadeType.REMOVE, CascadeType.MERGE, CascadeType.PERSIST}) // TODO: Figure out why this doesn't work.
+     @JoinColumn(nullable=false, unique=true)
+     private DataFile dataFile;
+ ","As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this.",Could you please elaborate on why this doesn't work?
+809,"@@ -84,5 +84,8 @@ func (a *action) Matches(act coretesting.Action) error {
+ 		return nil
+ 	}
+
++	fmt.Printf(""EXP:%+v\n"", objExp.GetObject())
++	fmt.Printf(""ACT:%+v\n"", objExp.GetObject())
++
+ 	return fmt.Errorf(""unexpected difference between actions: %s"", pretty.Diff(objExp.GetObject(), objAct.GetObject()))
+ }","Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes  ",Did you mean to leave this here?
+810,"@@ -63,6 +63,9 @@ const (
+
+ 	// SecretTypeEnv is to show secret type being ENVIRONMENT_VARIABLE
+ 	SecretTypeEnv = ""ENVIRONMENT_VARIABLE""
++
++	// TargetLogDriver is to show secret target being ""LOG_DRIVER"", the default will be ""CONTAINER""
++	SecretTargetLogDriver = ""LOG_DRIVER""
+ )
+
+ // DockerConfig represents additional metadata about a container to run. It's",where is the default being set?,Can we have this in the `docker_config.go` file inst
+811,"@@ -154,7 +154,7 @@ static void found_package_cb (const char *line,
+ 		vString *name = vStringNew ();
+ 		tagEntryInfo tag;
+
+-		vStringNCopyS (name, line + matches[1].start, matches[1].length);
++		vStringNCopyS (name, line + matches[2].start, matches[2].length);
+ 		initTagEntry (&tag, vStringValue (name), RpmSpecKinds + K_PACKAGE);
+ 		tag.extensionFields.scopeIndex = *(int *)userData;
+ 		makeTagEntry (&tag);",these changes should likely be in the next commit instead,The `start` and `length` of `vStringNCopyS` are used
+812,"@@ -26,9 +26,12 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ )
+
++type Foobar struct {
++	Foo string
++}
++
+ // TestFormat ensures the formatter and AddonTransform works as expected.
+ func TestFormat(t *testing.T) {
+-	// TODO: Add table formatter tests after implementing table formatter
+ 	for _, tc := range []struct {
+ 		name            string
+ 		singleton       bool","Since you have defined this struct, I would suggest to replace all exist literal structs by this.",struct field Foo should be Foo
+813,"@@ -168,6 +168,7 @@ public class K9 extends Application {
+     private static boolean mAnimations = true;
+
+     private static boolean mConfirmDelete = false;
++    private static boolean mConfirmMenuDiscard = true;
+     private static boolean mConfirmDeleteStarred = false;
+     private static boolean mConfirmSpam = false;
+     private static boolean mConfirmDeleteFromNotification = true;",The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice.,`mConfirmMenuDiscard` -> `mCon
+814,"@@ -192,6 +192,15 @@ class FileProvider extends BaseProvider
+             return;
+         }
+
++        // is_file will cause a fatal error if binary content is not a string
++        if (!is_string($media->getBinaryContent())) {
++            throw new \RuntimeException(sprintf(
++                'Invalid data provided for binary content, choose among: string, %s, %s',
++                'Symfony\Component\HttpFoundation\File\File',
++                'Symfony\Component\HttpFoundation\Request'
++            ));
++        }
++
+         // if the binary content is a filename => convert to a valid File
+         if (!is_file($media->getBinaryContent())) {
+             throw new \RuntimeException('The file does not exist : '.$media->getBinaryContent());",what if `$media->getBinaryContent() == Symfony\Component\HttpFoundation\File\File` does `is_string()` return `true`? ping @greg0ire,please use `!is_file()` instea
+815,"@@ -1065,11 +1065,9 @@ void GenStruct(StructDef &struct_def, std::string *code_ptr) {
+       }
+     }
+   // generate object accessors if is nested_flatbuffer
++  if (field.nested_flatbuffer) {
+   auto nested = field.attributes.Lookup(""nested_flatbuffer"");
+-  if (nested) {
+-    auto nested_qualified_name =
+-      parser_.namespaces_.back()->GetFullyQualifiedName(nested->constant);
+-    auto nested_type = parser_.structs_.Lookup(nested_qualified_name);
++	auto nested_type = nested->type.struct_def;
+     auto nested_type_name = WrapInNameSpace(*nested_type);
+     auto nestedMethodName = MakeCamel(field.name, lang_.first_camel_upper)
+       + ""As"" + nested_type_name;",maybe rather than `bool` make this field a `StructDef *` ?,I don't think struct_def is th
+816,"@@ -209,6 +209,13 @@ func (fbm *folderBlockManager) enqueueBlocksToDelete(toDelete blocksToDelete) {
+ 	fbm.blocksToDeleteChan <- toDelete
+ }
+
++func (fbm *folderBlockManager) enqueueBlocksToDeleteAfterShortDelay(
++	toDelete blocksToDelete) {
++	fbm.blocksToDeleteWaitGroup.Add(1)
++	time.AfterFunc(10*time.Millisecond,
++		func() { fbm.blocksToDeleteChan <- toDelete })
++}
++
+ // enqueueBlocksToDeleteNoWait enqueues blocks to be deleted just like
+ // enqueueBlocksToDelete, except that when fbm.blocksToDeleteChan is full, it
+ // doesn't block, but instead spawns a goroutine to handle the sending.",Shall we maybe put this in a `const` like `backgroundTaskTimeout`?,what is the `10*time.Millisecond` for?
+817,"@@ -272,6 +272,11 @@ namespace Datadog.Trace.TestHelpers
+                     ctx.Response.OutputStream.Write(buffer, 0, buffer.Length);
+                     ctx.Response.Close();
+                 }
++                catch (InvalidOperationException)
++                {
++                    // this can occur when setting Response.ContentLength64, with the framework claiming that the response has already been submitted
++                    // for now ignore, and we'll see if this introduces downstream issues
++                }
+                 catch (HttpListenerException)
+                 {
+                     // listener was stopped,",CI is complaining about this.,"@scalablecory, FYI for this"
+818,"@@ -31,6 +31,14 @@ import java.util.Date;
+  */
+ public class DefaultHistoryRemovalTimeProvider implements HistoryRemovalTimeProvider {
+
++  public static Date determineRemovalTime(Date initTime, Integer timeToLive) {
++    Calendar removalTime = Calendar.getInstance();
++    removalTime.setTime(initTime);
++    removalTime.add(Calendar.DATE, timeToLive);
++
++    return removalTime.getTime();
++  }
++
+   public Date calculateRemovalTime(HistoricProcessInstanceEventEntity historicRootProcessInstance, ProcessDefinition processDefinition) {
+
+     Integer historyTimeToLive = processDefinition.getHistoryTimeToLive();",Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced.,Since this method is only used in one
+819,"@@ -210,6 +210,14 @@ class ImageExtension extends Twig_Extension
+         $htmlAttributes = $attributes;
+         unset($htmlAttributes['type'], $htmlAttributes['size']);
+
++        $useLazyLoading = array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;
++        $isAttributeClassExistsAndNotEmpty = array_key_exists('class', $attributes) && $attributes['class'] !== '';
++        $htmlAttributes['class'] = sprintf(
++            '%s%s',
++            $useLazyLoading ? 'lazy' : '',
++            $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : ''
++        );
++
+         return $this->templating->render('@ShopsysFramework/Common/image.html.twig', [
+             'attr' => $htmlAttributes,
+             'additionalImagesData' => $additionalImagesData,","I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`",You could simplify this by using `$att
+820,"@@ -22,9 +22,13 @@ AdminJobExecutor::AdminJobExecutor(Sentence *sentence,
+
+ void AdminJobExecutor::execute() {
+     LOG(INFO) << __func__ << "" enter"";
+-    auto opEnum = toAdminJobOp(sentence_->getType());
++    auto optOpEnum = toAdminJobOp(sentence_->getType());
++    if (!optOpEnum) {
++        LOG(ERROR) << ""unknown setence type["" << sentence_->getType() <<""]"";
++    }
+     auto paras = sentence_->getParas();
+
++    auto opEnum = *optOpEnum;
+     if (opNeedsSpace(opEnum)) {
+         auto status = checkIfGraphSpaceChosen();
+         if (!status.ok()) {",when Op is illegal should return here?,Why is this guaranteed to be non-null?
+821,"@@ -447,8 +447,6 @@ public class FlowRunnerManager implements EventListener,
+             } catch (IOException e) {
+               logger.error(e);
+             }
+-
+-            installedVersions.remove(versionKey);
+           }
+         }
+       }",don't we need to remove the project version from installedVersions?,"This method is now unused, it should b"
+822,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.,Omit parentheses for method calls with
+823,"@@ -51,7 +51,10 @@ func (s *DaemonServer) FlushIPSets(ctx context.Context, req *pb.IPSetsRequest) (
+ 		ipset := ipset
+ 		s.IPSetLocker.Lock(ipset.Name)
+ 		err := flushIPSet(ctx, req.EnterNS, pid, ipset)
+-		s.IPSetLocker.Unlock(ipset.Name)
++		if err != nil {
++			return nil, err
++		}
++		err = s.IPSetLocker.Unlock(ipset.Name)
+ 		if err != nil {
+ 			return nil, err
+ 		}",This is intended. Pls revert this.,How is this change related to the rest
+824,"@@ -68,7 +68,7 @@ interface RedBlackTree<T> extends Iterable<T> {
+
+     static <T extends Comparable<? super T>> RedBlackTree<T> ofAll(Iterable<? extends T> values) {
+         Objects.requireNonNull(values, ""values is null"");
+-        return ofAll((Comparator<? super T> & Serializable) T::compareTo, values);
++        return ofAll(Comparators.naturalComparator(), values);
+     }
+
+     @SuppressWarnings(""unchecked"")","Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated",It's not clear to me why we need this change. Wouldn't it make more sense to do this for `ofAll(Iterable<T> values)`?
+825,"@@ -217,15 +217,10 @@ export default class App extends Component {
+
+   // eslint-disable-next-line no-unused-vars
+   handleClickSearch = (_, { suggestionValue, method }) => {
+-    const { packages } = this.state;
+     switch(method) {
+       case 'click':
+-        window.location.href = getDetailPageURL(suggestionValue);
+-      break;
+       case 'enter':
+-        this.setState({
+-          filteredPackages: packages.filter(pkg => pkg.label.match(suggestionValue))
+-        });
++        window.location.href = getDetailPageURL(suggestionValue);
+       break;
+     }
+   }","I think we need this. Not sure, I'll test.",This is the only place where we need to filter on the selected package.
+826,"@@ -83,7 +83,6 @@ module Beaker
+         host['user'] = 'google_compute'
+
+         disable_se_linux(host, @options)
+-        disable_iptables(host, @options)
+         copy_ssh_to_root(host, @options)
+         enable_root_login(host, @options)
+         host['user'] = default_user","I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact.",do we need the removal of the disable_iptables method?
+827,"@@ -2,6 +2,7 @@
+ // sources:
+ // build/static/charts/traefik-10.3.001.tgz
+ // build/static/charts/traefik-crd-10.3.001.tgz
++//go:build !no_stage
+ // +build !no_stage
+
+ package static",Did go change their tags with the new version?,Could you explain why this change is needed?
+828,"@@ -330,11 +330,15 @@ func (s *Server) newEndpointsServer(ctx context.Context, catalog catalog.Catalog
+ }
+
+ func (s *Server) newBundleManager(cat catalog.Catalog, metrics telemetry.Metrics) *bundle_client.Manager {
++	log := s.config.Log.WithField(telemetry.SubsystemName, ""bundle_client"")
+ 	return bundle_client.NewManager(bundle_client.ManagerConfig{
+-		Log:       s.config.Log.WithField(telemetry.SubsystemName, ""bundle_client""),
++		Log:       log,
+ 		Metrics:   metrics,
+ 		DataStore: cat.GetDataStore(),
+-		Source:    bundle_client.TrustDomainConfigMap(s.config.Federation.FederatesWith),
++		Source: bundle_client.MergeTrustDomainConfigSources(
++			bundle_client.TrustDomainConfigMap(s.config.Federation.FederatesWith),
++			bundle_client.DataStoreTrustDomainConfigSource(log, cat.GetDataStore()),
++		),
+ 	})
+ }
+ ","I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results.",Looks like this is the only place where it uses `s.config.Log`. Can we remove `s.config.Log`?
+829,"@@ -192,7 +192,7 @@ func replaceSequenceLabel(state *core.BuildState, target *core.BuildTarget, labe
+ }
+
+ func checkAndReplaceSequence(state *core.BuildState, target, dep *core.BuildTarget, in string, runnable, multiple, dir, outPrefix, hash, test, allOutputs, tool bool) string {
+-	if allOutputs && !multiple && len(dep.Outputs()) != 1 {
++	if allOutputs && !multiple && len(dep.Outputs()) > 1 {
+ 		// Label must have only one output.
+ 		panic(fmt.Sprintf(""Rule %s can't use %s; %s has multiple outputs."", target.Label, in, dep.Label))
+ 	} else if runnable && !dep.IsBinary {",I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit.,"The existing logic seems correct, but worried that if we have multiple outputs, we should onl"
+830,"@@ -110,12 +110,14 @@ public class SolrMetricManager {
+
+   public static final int DEFAULT_CLOUD_REPORTER_PERIOD = 60;
+
+-  private MetricRegistry.MetricSupplier<Counter> counterSupplier;
+-  private MetricRegistry.MetricSupplier<Meter> meterSupplier;
+-  private MetricRegistry.MetricSupplier<Timer> timerSupplier;
+-  private MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
++  private final MetricsConfig metricsConfig;
++  private final MetricRegistry.MetricSupplier<Counter> counterSupplier;
++  private final MetricRegistry.MetricSupplier<Meter> meterSupplier;
++  private final MetricRegistry.MetricSupplier<Timer> timerSupplier;
++  private final MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
+
+   public SolrMetricManager() {
++    metricsConfig = new MetricsConfig.MetricsConfigBuilder().build();
+     counterSupplier = MetricSuppliers.counterSupplier(null, null);
+     meterSupplier = MetricSuppliers.meterSupplier(null, null);
+     timerSupplier = MetricSuppliers.timerSupplier(null, null);",*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122.,Does this need to be public? It can be package-private.
+831,"@@ -60,12 +60,7 @@ function _command(server, ns, cmd, options, callback) {
+     finalCmd.$clusterTime = clusterTime;
+   }
+
+-  if (
+-    isSharded(server) &&
+-    !shouldUseOpMsg &&
+-    readPreference &&
+-    readPreference.preference !== 'primary'
+-  ) {
++  if (isSharded(server) && !shouldUseOpMsg && readPreference && readPreference.mode !== 'primary') {
+     finalCmd = {
+       $query: finalCmd,
+       $readPreference: readPreference.toJSON()",switch over to .mode,"`readPreference.mode` is a string, so `readPreference.preference !== 'primary'` is redundant"
+832,"@@ -125,7 +125,7 @@ describe('HiddenColumns', () => {
+       });
+
+       it('should return correct visual indexes when columns sequence is non-contiguous ' +
+-         '(force desync between physical and visual indexes)', () => {
++        '(force desync between physical and visual indexes)', () => {
+         const hot = handsontable({
+           data: Handsontable.helper.createSpreadsheetData(1, 10),
+           colHeaders: true,",I guess your IDE did some auto-fixing here  ,This should probably be reverted.
+833,"@@ -32,6 +32,7 @@ import org.apache.lucene.search.BooleanClause;
+ import org.apache.lucene.search.BooleanQuery;
+ import org.apache.lucene.search.DisjunctionMaxQuery;
+ import org.apache.lucene.search.FuzzyQuery;
++import org.apache.lucene.search.PhraseQuery;
+ import org.apache.lucene.search.TermQuery;
+
+ public class TestRamUsageEstimator extends LuceneTestCase {",This is an unused import failing recommit still.,Please move `import org.apache.lu
+834,"@@ -133,8 +133,12 @@ module Beaker
+               #move to the host
+               logger.debug ""Using scp to transfer #{source_path} to #{target_path}""
+               scp_to host, source_path, target_module_dir, {:ignore => ignore_list}
++
+               #rename to the selected module name, if not correct
+               cur_path = File.join(target_module_dir, source_name)
++              if host.is_powershell? #make sure our slashes are correct
++                cur_path = cur_path.gsub(/\//,'\\')
++              end
+               host.mv cur_path, target_path unless cur_path == target_path
+             when 'rsync'
+               logger.debug ""Using rsync to transfer #{source_path} to #{target_path}""","I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`.",cur_path = File.join(target_modul
+835,"@@ -52,6 +52,6 @@
+ <%= tinymce :content_css => asset_path('application.css') %>
+
+ <!-- alert for the default template-->
+-<div id=""edit_guidance_alert_dialog"" class=""modal"" style=""display:none"">
++<div id=""edit_guidance_alert_dialog"" class=""modal"" role=""dialog"" aria-label=""<%=_(""Missing Fields Alert"")%>"" style=""display:none"">
+   <ul id=""missing_fields_edit_guidance""></ul>
+ </div>",I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens.,Is there a specific reason this i
+836,"@@ -44,9 +44,9 @@ const COLUMN_SIZE_MAP_NAME = 'autoColumnSize';
+  * autoColumnSize: {syncLimit: '40%'},
+  * ```
+  *
+- * The plugin uses {@link GhostTable} and {@link SamplesGenerator} for calculations.
+- * First, {@link SamplesGenerator} prepares samples of data with its coordinates.
+- * Next {@link GhostTable} uses coordinates to get cells' renderers and append all to the DOM through DocumentFragment.
++ * The plugin uses GhostTable and SamplesGenerator for calculations.
++ * First, SamplesGenerator prepares samples of data with its coordinates.
++ * Next GhostTable uses coordinates to get cells' renderers and append all to the DOM through DocumentFragment.
+  *
+  * Sampling accepts additional options:
+  * - *samplingRatio* - Defines how many samples for the same length will be used to calculate. Default is `3`.",Should these link be removed?,Make this `{@link SamplesGenerator}`
+837,"@@ -217,11 +217,12 @@ class TabbedBrowser(tabwidget.TabWidget):
+         for tab in self.widgets():
+             self._remove_tab(tab)
+
+-    def close_tab(self, tab):
++    def close_tab(self, tab, add_undo=True):
+         """"""Close a tab.
+
+         Args:
+             tab: The QWebView to be closed.
++            add_undo: Whether the tab close can be undone.
+         """"""
+         last_close = config.get('tabs', 'last-close')
+         count = self.count()",Please make this a keyword-only argument by adding a `*` argument before `add_undo`.,What's the difference between `add_u
+838,"@@ -201,6 +201,13 @@ var eventStreamWriterTestTmpl = template.Must(
+ 			{{- end }}
+ 		}
+
++		var marshalers request.HandlerList
++		marshalers.PushBackNamed({{ $.API.ProtocolPackage }}.BuildHandler)
++		payloadMarshaler := protocol.HandlerPayloadMarshal{
++			Marshalers: marshalers,
++		}
++		_ = payloadMarshaler
++
+ 		eventMsgs := []eventstream.Message{
+ 			{{- range $idx, $event := $.InputStream.Events }}
+ 				{{- template ""set event message"" Map ""idx"" $idx ""parentShape"" $event.Shape ""eventName"" $event.Name }}",didn't quite follow what this code block is doing.,Is there a reason we're not using `m
+839,"@@ -1071,6 +1071,12 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+         }
+
+         function onWindowKeyDown(e) {
++            // FIXME: Conflicts with keyboard navigation
++            // FIXME: Then the keyboard is completely ignored. Need another solution.
++            if (layoutManager.tv) {
++                return void showOsd();
++            }
++
+             if (!currentVisibleMenu && 32 === e.keyCode) {
+                 playbackManager.playPause(currentPlayer);
+                 return void showOsd();","this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then",This should be removed now that we d
+840,"@@ -205,4 +205,17 @@ function patchDOMElement(dom, newVNode, internal, globalContext, commitQueue) {
+ 			dom.firstChild
+ 		);
+ 	}
++
++	if ('value' in newProps && dom._isControlled) {
++		dom._prevValue = newProps.value;
++
++		if (newProps.value !== dom.value) {
++			setProperty(dom, 'value', i, oldProps.value, 0);
++		}
++	} else if ('checked' in newProps && dom._isControlled) {
++		dom._prevValue = newProps.checked;
++		if (newProps.checked !== dom.checked) {
++			setProperty(dom, 'checked', i, oldProps.checked, 0);
++		}
++	}
+ }","After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component","Minor performance optimization here: `setProperty(dom, 'checked', i, oldProps.checked, 0)` can be done with `setProperty(dom, 'checked', i, oldProps.checked, 0)`"
+841,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package node provides the glue-code needed in order
++// to start a Bee node.
+ package node
+
+ import (","It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node.","nit: ""in order to start a Bee node"""
+842,"@@ -330,6 +330,8 @@ class ConfigManager(QObject):
+     CHANGED_OPTIONS = {
+         ('content', 'cookies-accept'):
+             _get_value_transformer('default', 'no-3rdparty'),
++        ('storage', 'download-directory'):
++            _get_value_transformer('', '%'),
+     }
+
+     changed = pyqtSignal(str, str)","I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore.","Just curious, what's the reason for this change?"
+843,"@@ -88,6 +88,13 @@ public interface Table {
+    */
+   Map<Integer, SortOrder> sortOrders();
+
++  /**
++   * Return the {@link RowKey row key} for this table.
++   *
++   * @return this table's row key.
++   */
++  RowKey rowKey();
++
+   /**
+    * Return a map of string properties for this table.
+    *",Nit: this table's row key map -> this table's row keys map,This should be `@return this table's row key.`
+844,"@@ -87,7 +87,7 @@ void proj_assign_context( PJ* pj, PJ_CONTEXT *ctx )
+ pj_ctx pj_ctx::createDefault()
+ {
+     pj_ctx ctx;
+-    ctx.debug_level = PJ_LOG_ERROR;
++    ctx.debug_level = PJ_LOG_NONE;
+     ctx.logger = pj_stderr_logger;
+     NS_PROJ::FileManager::fillDefaultNetworkInterface(&ctx);
+ ",this change should be reverted,This is the only real change in this file. the rest of the changes are from coding standards.
+845,"@@ -26,8 +26,10 @@ __copyright__ = ""Copyright 2014-2018 Florian Bruhin (The Compiler)""
+ __license__ = ""GPL""
+ __maintainer__ = __author__
+ __email__ = ""mail@qutebrowser.org""
+-__version_info__ = (1, 5, 0)
+-__version__ = '.'.join(str(e) for e in __version_info__)
++__version__ = ""1.5.0""
++__version_info__ = [int(part) for part in __version__.split('.')]
+ __description__ = ""A keyboard-driven, vim-like browser based on PyQt5.""
+
+ basedir = os.path.dirname(os.path.realpath(__file__))
++appdata_path = os.path.join(os.path.dirname(basedir), ""misc"",
++                            ""qutebrowser.appdata.xml"")","I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself.",why do we need a separate version? Can't we just update `__version__` to 1.5.0?
+846,"@@ -750,8 +750,8 @@ func TestConfigCheck(t *testing.T) {
+                 http_port = 8222
+ 				`,
+ 			err:       errors.New(`Duplicate user ""foo"" detected`),
+-			errorLine: 6,
+-			errorPos:  21,
++			errorLine: 5,
++			errorPos:  19,
+ 		},
+ 		{
+ 			name: ""when accounts block imports are not a list"",",Revert this change and see below why...,The test failure is due to this line being under the `if err != nil` block.
+847,"@@ -1,6 +1,6 @@
+ _base_ = [
+     '../_base_/models/cascade_mask_rcnn_r50_fpn.py',
+-    '../_base_/datasets/coco_instance.py',
++    '../_base_/datasets/lvis_v1_instance.py',
+     '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py'
+ ]
+ ",Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.,why is this changed?
+848,"@@ -70,7 +70,7 @@ public class NodeOptions {
+       Capabilities caps = info.getCanonicalCapabilities();
+       builders.stream()
+           .filter(builder -> builder.score(caps) > 0)
+-          .peek(builder -> LOG.info(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
++          .peek(builder -> LOG.finest(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
+           .forEach(builder -> {
+             DriverService.Builder freePortBuilder = builder.usingAnyFreePort();
+ ",This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave.,"I don't think we should be changing the log level here. If we are going to flood the logs, I think we should make it `debug` level."
+849,"@@ -52,6 +52,9 @@ type Alert interface {
+ 	// GetKvdbInstance.
+ 	GetKvdbInstance() kvdb.Kvdb
+
++	// RaiseSingleton raises a singleton alert.
++	RaiseSingleton(alert *api.Alert) error
++
+ 	// Raise raises an Alert.
+ 	Raise(alert *api.Alert) error
+ ",This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure.,I don't understand why this is needed. I don't see it used anywhere.
+850,"@@ -45,6 +45,7 @@ public class JavaProcessJobTest {
+   private JavaProcessJob job = null;
+   private Props props = null;
+   private Logger log = Logger.getLogger(JavaProcessJob.class);
++  private AllJobExecutorTests jobExecutorTests = null;
+
+   private static String classPaths;
+ ","What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method.",Does this need to be volatile? Can we just make it non-static and initialized in the constructor?
+851,"@@ -12,6 +12,7 @@ const mdUsageStr = `Usage:
+
+ The possible subcommands are:
+   dump		Dump metadata objects
++  check		Check metadata objects and their associated blocks for errors
+
+ `
+ ","This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?",Could you make this aligned with the other `dump` and `check` commands?
+852,"@@ -136,6 +136,17 @@ void image_data_reader::load() {
+   select_subset_of_data();
+ }
+
++void image_data_reader::setup() {
++  generic_data_reader::setup();
++
++  using InputBuf_T = lbann::cv_image_type<uint8_t>;
++  auto cvMat = cv::Mat(1, get_linearized_data_size(), InputBuf_T::T(1));
++  m_thread_cv_buffer.resize(omp_get_max_threads());
++  for(int tid = 0; tid < omp_get_max_threads(); ++tid) {
++    m_thread_cv_buffer[tid] = cvMat.clone();
++  }
++}
++
+ std::vector<image_data_reader::sample_t> image_data_reader::get_image_list_of_current_mb() const {
+   std::vector<sample_t> ret;
+   ret.reserve(m_mini_batch_size);","Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should.","This is an example of how to use `std::vector` instead of `std::vector`. For example, `m_thread_cv_buffer[0]` and `m_thread_cv_buffer[1]` are equivalent."
+853,"@@ -48,6 +48,8 @@ const (
+ 	KindLambdaApp Kind = ""LambdaApp""
+ 	// KindCloudRunApp represents deployment configuration for a CloudRun application.
+ 	KindCloudRunApp Kind = ""CloudRunApp""
++	// KindEcsApp represents deployment configuration for an AWS ECS.
++	KindEcsApp Kind = ""EcsApp""
+ 	// KindSealedSecret represents a sealed secret.
+ 	KindSealedSecret Kind = ""SealedSecret""
+ )",should be `ECSApp`  ,The `aws_ecs` package is in the `deployment_helper.go` file. We should be moving logic out of the `aws_ecs` package.
+854,"@@ -539,7 +539,13 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            rect = self.size.copy()
++            rect.update(self.location)
++            return rect
++
+
+     @property
+     def screenshot_as_base64(self):",flake8 is going to fail on this having 2 lines,"Rather than `self.size` which is a `dict`, this would probably be better as `self.size[0]` (or `self.size[1]` if that's not guaranteed to be the exact si"
+855,"@@ -15,7 +15,6 @@ package podfailure
+
+ import (
+ 	""context""
+-	""errors""
+ 	""fmt""
+ 	""time""
+ ",should we make a dir named controllers/scheduler/podchaos,Can you add gitea copyright line to header (and keep gogs one next to it)?
+856,"@@ -50,9 +50,9 @@ import (
+ )
+
+ const (
+-	//KeyNode represents the key values used for specifying the Node Affinity
++	//KeyNodeHostname represents the key values used for specifying the Node Affinity
+ 	// based on the hostname
+-	KeyNode = ""kubernetes.io/hostname""
++	KeyNodeHostname = ""kubernetes.io/hostname""
+ )
+
+ // NewProvisioner will create a new Provisioner object and initialize",there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?,This is a breaking change and needs to be added to the docs.
+857,"@@ -22,12 +22,12 @@ import (
+ 	""fmt""
+ 	""time""
+
++	""github.com/mysteriumnetwork/node/cmd/commands""
++
+ 	""github.com/mysteriumnetwork/node/cmd/commands/cli/clio""
+ 	""github.com/mysteriumnetwork/node/config""
+-	""github.com/mysteriumnetwork/node/config/urfavecli/clicontext""
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/connection/connectionstate""
+-	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/mysteriumnetwork/node/datasize""
+ 	""github.com/mysteriumnetwork/node/identity/registry""
+ 	""github.com/mysteriumnetwork/node/metadata""",Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?,mysteriumnetwork/node/config/urfavecli is no longer used in
+858,"@@ -122,6 +122,7 @@ public class EmojiPlugin extends Plugin
+ 			case FRIENDSCHAT:
+ 			case PRIVATECHAT:
+ 			case PRIVATECHATOUT:
++			case MODPRIVATECHAT:
+ 				break;
+ 			default:
+ 				return;",Don't think this belongs in this pr,"While you're here, could you also add a `default:` case here"
+859,"@@ -206,6 +206,16 @@ func (d *Dispatcher) Inbounds() Inbounds {
+ 	return inbounds
+ }
+
++// Outbounds returns a copy of the map of outbounds for this RPC object.
++// The outbounds are already wrapped with middleware
++func (d *Dispatcher) Outbounds() Outbounds {
++	outbounds := make(Outbounds, len(d.outbounds))
++	for k, v := range d.outbounds {
++		outbounds[k] = v
++	}
++	return outbounds
++}
++
+ // ClientConfig provides the configuration needed to talk to the given
+ // service through an outboundKey. This configuration may be directly
+ // passed into encoding-specific RPC clients.","We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?",Probably worth a check that `d.outbounds` is not nil before
+860,"@@ -37,14 +37,13 @@ namespace MvvmCross.Core.ViewModels
+
+     public interface IMvxViewModel<TParameter> : IMvxViewModel where TParameter : class
+     {
+-        Task Initialize(TParameter parameter);
++        void Declare(TParameter parameter);
+     }
+
+     //TODO: Can we keep the IMvxViewModel syntax here? Compiler complains
+     public interface IMvxViewModelResult<TResult> : IMvxViewModel where TResult : class
+     {
+-        void SetClose(TaskCompletionSource<TResult> tcs, CancellationToken cancellationToken);
+-        Task<bool> Close(TResult result);
++        TaskCompletionSource<object> CloseCompletionSource { get; set; }
+     }
+
+     public interface IMvxViewModel<TParameter, TResult> : IMvxViewModel<TParameter>, IMvxViewModelResult<TResult> where TParameter : class where TResult : class",@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs  ,Shouldn't this be an `CancellationToken`?
+861,"@@ -89,6 +89,13 @@ class SingleStageDetector(BaseDetector):
+         Returns:
+             dict[str, Tensor]: A dictionary of loss components.
+         """"""
++        # NOTE the batched image size information may be useful, e.g.
++        # in DETR, this is needed for the construction of masks, which is
++        # then used for the transformer_head.
++        input_img_shape = tuple(img.size()[-2:])
++        for img_meta in img_metas:
++            img_meta['input_img_shape'] = input_img_shape
++
+         x = self.extract_feat(img)
+         losses = self.bbox_head.forward_train(x, img_metas, gt_bboxes,
+                                               gt_labels, gt_bboxes_ignore)",Are these modification duplicate? Or should we move it into base detector.,Can you add a type annotation here?
+862,"@@ -35,7 +35,7 @@ public class DirectAcyclicGraphSeed {
+             }
+           });
+
+-  public static byte[] dagSeed(final long block) {
++  private static byte[] dagSeed(final long block) {
+     final byte[] seed = new byte[32];
+     if (Long.compareUnsigned(block, EPOCH_LENGTH) >= 0) {
+       final MessageDigest keccak256 = KECCAK_256.get();",Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method.,Why did you change the visibility on this
+863,"@@ -160,11 +160,10 @@ abstract class Tx_Solr_PluginBase_PluginBase extends tslib_pibase {
+ 	 * @param array $configuration configuration array as provided by the TYPO3 core
+ 	 */
+ 	protected function initialize($configuration) {
+-		$this->conf = $configuration;
+-
+-		$this->conf = t3lib_div::array_merge_recursive_overrule(
+-			$GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'],
+-			$this->conf
++		$this->conf = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'];
++		\TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule(
++			$this->conf,
++			$configuration
+ 		);
+
+ 		$this->pi_setPiVarDefaults();",why the order change? Also for the next chunk. (I understand the result will be the same though),Please move the import at the top of the
+864,"@@ -42,7 +42,9 @@ type FuncDef struct {
+ 	// Not part of the grammar. Used to indicate internal targets that can only
+ 	// be called using keyword arguments.
+ 	KeywordsOnly bool
+-	IsPrivate    bool
++	// allowed return types of the FuncDef
++	Returns   []string
++	IsPrivate bool
+ }
+
+ // A ForStatement implements the 'for' statement.",I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier.,Why is this a `[]string` and not a `*string`?
+865,"@@ -125,7 +125,7 @@ abstract class BaseDataReader<T> implements Closeable {
+
+   protected InputFile getInputFile(FileScanTask task) {
+     Preconditions.checkArgument(!task.isDataTask(), ""Invalid task type"");
+-    return inputFiles.get(task.file().path().toString());
++    return getInputFile(task.file().path().toString());
+   }
+
+   protected InputFile getInputFile(String location) {",I don't think this needs to change. Can you go back to the previous implementation?,This should probably be `getInputFile(FileSca
+866,"@@ -32,7 +32,7 @@ from jinja2 import PackageLoader
+
+ import molecule.utilities as utilities
+ import molecule.validators as validators
+-from provisioners import Ansible
++from molecule.core import Molecule
+
+
+ class Commands(object):","Bump it 2 lines higher, 'c' > 'u'.",shouldn't this be imported at the top of the
+867,"@@ -0,0 +1,11 @@
++/**
++ * Copyright @ 2018-present. All rights reserved by Vesoft Inc.
++ * Author: Fenglin Hou <dutor@vesoft-inc.com>
++ */
++#include ""parser/AstTypes.h""
++
++namespace vesoft {
++
++
++
++}",Please do not add author here,This file is missing the license header.
+868,"@@ -4,6 +4,7 @@ import (
+ 	""database/sql""
+ 	""encoding/hex""
+
++	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/db/rds""","Similarly, we should be able to persist action uniformly",Let's not forget to remove this import.
+869,"@@ -1,3 +1,8 @@
++#This prevents caching via the browser
++#in testing mode
++module ActionController::ConditionalGet
++    def expires_in(*args) ; end
++end
+ Workshops::Application.configure do
+   # Settings specified here will take precedence over those in config/application.rb
+ ","I think i'd prefer this override to be in the test helper instead, if that's possible?",Style/EmptyMethod: Put empty method def
+870,"@@ -134,6 +134,13 @@ func Untar(source string, dest string, extractionDir string) error {
+ 		case tar.TypeReg:
+ 			fallthrough
+ 		case tar.TypeRegA:
++			// Always ensure the directory is created before trying to move the file.
++			fullPathDir := filepath.Dir(fullPath)
++			err = os.MkdirAll(fullPathDir, 0755)
++			if err != nil {
++				return err
++			}
++
+ 			// For a regular file, create and copy the file.
+ 			exFile, err := os.Create(fullPath)
+ 			if err != nil {",This would be better with context added via wrapping or fmt.errorf(),I'm not sure if this is true or not. I
+871,"@@ -0,0 +1,19 @@
++//  Copyright 2020 Google Inc. All Rights Reserved.
++//
++//  Licensed under the Apache License, Version 2.0 (the ""License"");
++//  you may not use this file except in compliance with the License.
++//  You may obtain a copy of the License at
++//
++//      http://www.apache.org/licenses/LICENSE-2.0
++//
++//  Unless required by applicable law or agreed to in writing, software
++//  distributed under the License is distributed on an ""AS IS"" BASIS,
++//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++//  See the License for the specific language governing permissions and
++//  limitations under the License.
++
++// Package assert provides convenience functions that help a method or constructor check whether
++// it was invoked correctly (whether its preconditions have been met).
++//
++// When the assertion fails, a panic occurs, allowing bugs to be found in a fail-fast manner.
++package assert",What's the purpose of this file?,I don't think this is the right file fo
+872,"@@ -616,12 +616,14 @@ public class PasscodeManager  {
+      */
+     public void setPasscodeLength(Context ctx, int passcodeLength) {
+     	if (passcodeLength > this.passcodeLength) {
+-            if (hasStoredPasscode(ctx)) {
++            if (hasStoredPasscode(ctx) && passcodeLengthKnown) {
+                 this.passcodeChangeRequired = true;
+             }
++
++            this.passcodeLength = passcodeLength;
+     	}
+-        this.passcodeLength = passcodeLength;
+-    	this.passcodeLengthKnown = true;
++
++        this.passcodeLengthKnown = true;
+         storeMobilePolicy(ctx);
+     }
+ ",@bhariharan Why was passcode length requirement allowed to be lowered?,Shouldn't this.passcodeLengthChangeRequired = true always?
+873,"@@ -6,14 +6,6 @@ import (
+ 	""flag""
+ 	""io/ioutil""
+ 	""log""
+-
+-	""github.com/aws/aws-sdk-go/aws""
+-	""github.com/aws/aws-sdk-go/aws/credentials""
+-	""github.com/aws/aws-sdk-go/aws/session""
+-	""github.com/google/go-cloud/blob""
+-	""github.com/google/go-cloud/blob/gcsblob""
+-	""github.com/google/go-cloud/blob/s3blob""
+-	""github.com/google/go-cloud/gcp""
+ )
+
+ const bucketName = ""my-cool-bucket""","This file needs a license header, too. Sorry I didn't catch that earlier.",These credentials are not needed anymore?
+874,"@@ -289,7 +289,7 @@ func main() {
+ 		}
+ 	}
+
+-	err = s.Initialize(cfg, phonebookAddresses)
++	err = s.Initialize(cfg, phonebookAddresses, string(genesisText[:]))
+ 	if err != nil {
+ 		fmt.Fprintln(os.Stderr, err)
+ 		log.Error(err)",probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?,why is the `string(genesisText[:])` needed here?
+875,"@@ -86,8 +86,13 @@ public:
+                              const table& y_data,
+                              const table& result_values) {
+         auto reference = compute_reference(scale, shift, x_data, y_data);
++        const table reference_table = dal::detail::homogen_table_builder{}
++                                          .reset(reference.get_array(),
++                                                 reference.get_row_count(),
++                                                 reference.get_column_count())
++                                          .build();
+         const double tol = te::get_tolerance<Float>(3e-4, 1e-9);
+-        const double diff = la::l_inf_norm(reference, la::matrix<double>::wrap(result_values));
++        const double diff = te::abs_error(reference_table, result_values);
+         CHECK(diff < tol);
+     }
+ ",Why reference is converted to table?,reference.get_row_count() is not the same as reference.get
+876,"@@ -347,6 +347,19 @@ func (s *DataStore) ListRegistrationEntries(ctx context.Context,
+ 	s.mu.Lock()
+ 	defer s.mu.Unlock()
+
++	// no pagination allow for this fake, for now it return only one page
++	if req.Pagination != nil {
++		if req.Pagination.Token == 0 {
++			req.Pagination.Token = 1
++		} else {
++			// for now only 1 page is returned
++			return &datastore.ListRegistrationEntriesResponse{
++				Entries:    []*common.RegistrationEntry{},
++				Pagination: req.Pagination,
++			}, nil
++		}
++	}
++
+ 	// add the registration entries to the map
+ 	entriesSet := make(map[string]*common.RegistrationEntry)
+ 	for _, entry := range s.registrationEntries {",should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?,Is it possible for `req.Pagination.Token` to be 0?
+877,"@@ -15,6 +15,12 @@ func Compile(scope Scope, f *semantic.FunctionExpression, in semantic.MonoType)
+ 		return nil, errors.Newf(codes.Invalid, ""function input must be an object @ %v"", f.Location())
+ 	}
+
++	// If the function is vectorizable, `f.Vectorized` will be populated, and
++	// we should use the FunctionExpression it points to instead of `f`
++	if f.Vectorized != nil {
++		f = f.Vectorized
++	}
++
+ 	// Retrieve the function argument types and create an object type from them.
+ 	fnType := f.TypeOf()
+ 	argN, err := fnType.NumArguments()",What mechanism will be exposed so the caller knows they're using the vectorized version?,Shouldn't this just be `f.Vectorized = f.Vectorize
+878,"@@ -20,9 +20,9 @@ class TopicsController < ApplicationController
+     @topic = build_new_topic
+     respond_to do |format|
+       if verify_recaptcha(model: @topic) && @topic.save
+-        format.html { redirect_to forum_path(@forum), flash: { success: t('.success') } }
++        format.html { redirect_to forum_path(@forum), notice: t('.success') }
+       else
+-        format.html { redirect_to forum_path(@forum), flash: { error: t('.error') } }
++        format.html { render :new }
+       end
+     end
+   end",Can we remove respond_to block its not required here,Why did you remove the `success` flash message?
+879,"@@ -23,12 +23,13 @@
+ #include ""oneapi/dal/algo/jaccard.hpp""
+ #include ""oneapi/dal/graph/service_functions.hpp""
+ #include ""oneapi/dal/graph/undirected_adjacency_vector_graph.hpp""
+-#include ""oneapi/dal/io/graph_csv_data_source.hpp""
+-#include ""oneapi/dal/io/load_graph.hpp""
++#include ""oneapi/dal/io/csv.hpp""
+ #include ""oneapi/dal/table/homogen.hpp""
+
+ namespace dal = oneapi::dal;
+
++using namespace dal;
++
+ /// Computes Jaccard similarity coefficients for the graph. The upper triangular
+ /// matrix is processed only as it is symmetic for undirected graph.
+ ///","Do not do that even in example, we demonstrate bad practice",Seems this header is already included in `oneapi/d
+880,"@@ -202,7 +202,13 @@ module Beaker
+     #Examine the host system to determine the architecture
+     #@return [Boolean] true if x86_64, false otherwise
+     def determine_if_x86_64
+-      result = exec(Beaker::Command.new(""arch | grep x86_64""), :acceptable_exit_codes => (0...127))
++      if self['is_cygwin'].nil? or self['is_cygwin'] == true
++        command = Beaker::Command.new(""arch | grep x86_64"")
++      else
++        command = Beaker::Command.new(""echo '' | wmic os get osarchitecture | FindStr 64-bit"")
++      end
++
++      result = exec(command, :acceptable_exit_codes => (0...127))
+       result.exit_code == 0
+     end
+ ","Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location.",`self['is_cygwin'].nil?` instead of `self['is_cygwin'] == true`
+881,"@@ -84,11 +84,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [InlineData(null, new byte[0])]
+         public void EncodesAsAscii(string input, byte[] expected)
+         {
+-            var writerBuffer = _pipe.Writer;
+-            var writer = new BufferWriter<PipeWriter>(writerBuffer);
++            var pipeWriter = _pipe.Writer;
++            var writer = new BufferWriter<PipeWriter>(pipeWriter);
+             writer.WriteAsciiNoValidation(input);
+             writer.Commit();
+-            writerBuffer.FlushAsync().GetAwaiter().GetResult();
++            pipeWriter.FlushAsync().GetAwaiter().GetResult();
++            pipeWriter.Complete();
++
+             var reader = _pipe.Reader.ReadAsync().GetAwaiter().GetResult();
+
+             if (expected.Length > 0)",We have to `.Complete` now because of empty/null string test cases.,Thanks for the fix. Can you also make sure there's a test ensur
+882,"@@ -166,7 +166,7 @@ module Beaker
+     def scp_to source, target, options = {}, dry_run = false
+       return if dry_run
+
+-      options[:recursive]  = File.directory?(source) if options[:recursive].nil?
++      options[:recursive]  = File.directory?(source)
+       options[:chunk_size] = options[:chunk_size] || 16384
+
+       result = Result.new(@hostname, [source, target])",Is there still a way to specify no recursion?,Unnecessary spacing detected.
+883,"@@ -438,6 +438,15 @@ Loop:
+ 	return w, nil
+ }
+
++// Tool is used to communicate the tool's name ot the user.
++type Tool struct {
++
++	// HumanReadableName is used for error messages, for example: ""image import"".
++	HumanReadableName string
++	// URISafeName is used programmatically, eg: ""image-import""
++	URISafeName string
++}
++
+ // EnvironmentSettings controls the resources that are used during tool execution.
+ type EnvironmentSettings struct {
+ 	// Location of workflows",How is this name being URI safe and being used programmatically related?,Is there a reason why this name is `humanReadableName` and not
+884,"@@ -358,14 +358,14 @@ module.exports = class ProviderView {
+       state = this.plugin.getPluginState()
+       state.selectedFolders[folderId] = { loading: false, files: files }
+       this.plugin.setPluginState({ selectedFolders: folders })
+-      const dashboard = this.plugin.uppy.getPlugin('Dashboard')
++
+       let message
+       if (files.length) {
+-        message = dashboard.i18n('folderAdded', {
++        message = this.plugin.uppy.i18n('folderAdded', {
+           smart_count: files.length, folder: folder.name
+         })
+       } else {
+-        message = dashboard.i18n('emptyFolderAdded')
++        message = this.plugin.uppy.i18n('emptyFolderAdded')
+       }
+       this.plugin.uppy.info(message)
+     }).catch((e) => {","I think we have to keep this as a fallback for now, else it's a small breaking change :(",Nit: we can get rid of the `const` as well
+885,"@@ -80,7 +80,7 @@ func TestOpImmediateNote(t *testing.T) {
+ func TestOpDocExtra(t *testing.T) {
+ 	xd := OpDocExtra(""bnz"")
+ 	require.NotEmpty(t, xd)
+-	xd = OpDocExtra(""+"")
++	xd = OpDocExtra(""-"")
+ 	require.Empty(t, xd)
+ }
+ ",nit: shouldn't be part of this PR.,Could you explain why this change is neede
+886,"@@ -83,7 +83,7 @@ describe('Cursor Async Iterator Tests', function() {
+           expect(doc).to.exist;
+           cursor.close();
+         }
+-        throw new Error('expected closing the cursor to break iteration');
++        throw new MongoError('expected closing the cursor to break iteration');
+       } catch (e) {
+         expect(e).to.be.an.instanceOf(MongoError);
+       }","this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it.",We prefer `expect(e).to.throw(MongoError)`
+887,"@@ -164,6 +164,13 @@ namespace NLog.Internal
+
+             if (reusableBuilder != null)
+             {
++                if (!_layout.IsThreadAgnostic)
++                {
++                    string cachedResult;
++                    if (logEvent.TryGetCachedLayoutValue(_layout, out cachedResult))
++                        return cachedResult;
++                }
++
+                 _layout.RenderAppendBuilder(logEvent, reusableBuilder);
+
+                 if (_cachedPrevRawFileName != null && _cachedPrevRawFileName.Length == reusableBuilder.Length)","I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread.",Why are we only checking for `IsThreadAgno
+888,"@@ -7,14 +7,19 @@ import javafx.scene.control.ToggleGroup;
+ import javafx.scene.layout.HBox;
+ import org.phoenicis.javafx.views.common.widgets.lists.CombinedListWidget;
+ import org.phoenicis.javafx.views.common.widgets.lists.ListWidgetType;
++import org.slf4j.LoggerFactory;
+
+ import java.util.Arrays;
+ import java.util.List;
++import java.util.Optional;
++import java.util.function.Consumer;
+
+ /**
+  * Created by marc on 15.05.17.
+  */
+ public class LeftListWidgetChooser<E> extends HBox {
++    private final org.slf4j.Logger LOGGER = LoggerFactory.getLogger(LeftListWidgetChooser.class);
++
+     private List<CombinedListWidget<E>> listWidgets;
+
+     private ToggleGroup toggleGroup;",Please use only `Logger` instead of `org.slf4j.Logger`,Please use `org.slf4j.Logger` instead.
+889,"@@ -326,6 +326,10 @@ void nano::block_processor::process_live (nano::transaction const & transaction_
+ 	{
+ 		node.network.flood_block_initial (block_a);
+ 	}
++	else if (!node.flags.disable_block_processor_republishing)
++	{
++		node.network.flood_block (block_a, nano::buffer_drop_policy::no_limiter_drop);
++	}
+
+ 	if (node.websocket_server && node.websocket_server->any_subscriber (nano::websocket::topic::new_unconfirmed_block))
+ 	{","Should this be ""no limiter drop"", since this isn't an absolutely essential activity for the stability of the network?",why do you need to check this? do you
+890,"@@ -22,8 +22,8 @@ var iam = new AWS.IAM({apiVersion: '2010-05-08'});
+
+ iam.deleteAccountAlias({AccountAlias: process.argv[2]}, function(err, data) {
+   if (err) {
+-    console.log(""Error"", err);
++    throw err;
+   } else {
+-    console.log(""Success"", data);
++    console.log('Account alias ' + process.argv[2] + ' deleted.');
+   }
+ });","I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully.",Should this be `console.log('Account a
+891,"@@ -45,6 +45,8 @@ def _test_pyx():
+                                       stdout=devnull, stderr=subprocess.STDOUT)
+     except (subprocess.CalledProcessError, OSError):
+         return False
++    except FileNotFoundError as fnfe:
++        return False
+     else:
+         return r == 0
+ ",Could you simply add it to the previous clause ?,This doesn't catch `subprocess.CalledP
+892,"@@ -108,13 +108,10 @@ Blockly.Procedures.sortProcedureMutations_ = function(mutations) {
+     var procCodeA = a.getAttribute('proccode');
+     var procCodeB = b.getAttribute('proccode');
+
+-    if (procCodeA < procCodeB) {
+-      return -1;
+-    } else if (procCodeA > procCodeB) {
+-      return 1;
+-    } else {
+-      return 0;
+-    }
++    return procCodeA.localeCompare(procCodeB, undefined, {
++      sensitivity: 'base',
++      numeric: true
++    });
+   });
+
+   return newMutations;","@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options.",Why is this being removed?
+893,"@@ -239,6 +239,10 @@ public class ExecuteFlowAction implements TriggerAction {
+     }
+     exflow.setExecutionOptions(executionOptions);
+
++    if (slaOptions != null && slaOptions.size() > 0) {
++      exflow.setSlaOptions(slaOptions);
++    }
++
+     try {
+       logger.info(""Invoking flow "" + project.getName() + ""."" + flowName);
+       executorManager.submitExecutableFlow(exflow, submitUser);",@chengren311 : where does this logic move to?,Shouldn't you check that s
+894,"@@ -204,6 +204,14 @@ func (s *NodegroupService) reconcileNodegroupIAMRole() error {
+ 	}
+
+ 	policies := NodegroupRolePolicies()
++	if len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0 {
++		if !s.scope.AllowAdditionalRoles() {
++			return ErrCannotUseAdditionalRoles
++		}
++
++		policies = append(policies, s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies...)
++	}
++
+ 	_, err = s.EnsurePoliciesAttached(role, aws.StringSlice(policies))
+ 	if err != nil {
+ 		return errors.Wrapf(err, ""error ensuring policies are attached: %v"", policies)",Can we have a `nil` exception check at `s.scope.ManagedMachinePool`,This should be `!s.scope.A
+895,"@@ -40,16 +40,6 @@ class Options extends \VuFind\Search\Base\Options
+ {
+     use \VuFind\Search\Options\ViewOptionsTrait;
+
+-    /**
+-     * Available sort options for facets
+-     *
+-     * @var array
+-     */
+-    protected $facetSortOptions = [
+-        'count' => 'sort_count',
+-        'index' => 'sort_alphabetic'
+-    ];
+-
+     /**
+      * Hierarchical facets
+      *","Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?",Why is this removed?
+896,"@@ -31,11 +31,14 @@ class ManagerConfiguration {
+       '#collapsible' => FALSE,
+     ];
+     foreach ($this->datastoreManager->getConfigurableProperties() as $property => $default_value) {
++      $propety_label = str_replace(""_"", "" "", $property);
++      $propety_label = ucfirst($propety_label);
++
+       if ($property == ""delimiter"") {
+         $form['import_options'][""datastore_manager_config_{$property}""] = array(
+           '#type' => 'select',
+           // @codingStandardsIgnoreStart
+-          '#title' => ucfirst(t(""{$property}"")),
++          '#title' => t($propety_label),
+           // @codingStandardsIgnoreEnd
+           '#options' => array(
+             "","" => "","",","wrap, single line",What is the purpose of this change ?
+897,"@@ -202,6 +202,12 @@ public class JavaContextCommon {
+
+     public abstract String getReturnType();
+
++    public String getGenericAwareReturnType() {
++      String returnType = getReturnType();
++      if (returnType == null || returnType.isEmpty()) return ""Void"";
++      else return returnType;
++    }
++
+     public abstract ImmutableList<Variable> getParams();
+
+     public abstract ImmutableList<Variable> getRequiredParams();",always use brackets for if statements,use `StringUtils.isBlank()` instead.
+898,"@@ -34,14 +34,13 @@ namespace Datadog.Trace.ClrProfiler.Integrations.Testing
+         private const string NUnitTestExecutionContextType = ""NUnit.Framework.Internal.TestExecutionContext"";
+
+         private static readonly Vendors.Serilog.ILogger Log = DatadogLogging.GetLogger(typeof(NUnitIntegration));
+-        private static readonly FrameworkDescription _runtimeDescription;
++        private static readonly FrameworkDescription RuntimeDescription;
+
+         static NUnitIntegration()
+         {
+             // Preload environment variables.
+             CIEnvironmentValues.DecorateSpan(null);
+-
+-            _runtimeDescription = FrameworkDescription.Create();
++            RuntimeDescription = FrameworkDescription.Instance;
+         }
+
+         /// <summary>",`NUnitIntegration` doesn't need to cache this anymore.,Shouldn't this be FrameworkDescripti
+899,"@@ -210,8 +210,9 @@ EXTS_ACCESS_COUNTS = textwrap.dedent(""""""\
+             eventname,
+             bucket,
+             lower(CASE
+-                WHEN cardinality(parts) > 2 THEN concat(element_at(parts, -2), '.', element_at(parts, -1))
+-                WHEN cardinality(parts) = 2 THEN element_at(parts, -1)
++                WHEN cardinality(parts) > 2 AND lower(element_at(parts, -1)) = 'gz'
++                    THEN concat(element_at(parts, -2), '.', element_at(parts, -1))
++                WHEN cardinality(parts) >= 2 THEN element_at(parts, -1)
+                 ELSE ''
+                 END
+             ) AS ext,",Why did you change it to `>=` here?,Minor optimization: this could be si
+900,"@@ -30,8 +30,11 @@ abstract class BaseAction<R> implements Action<R> {
+     String tableName = table().toString();
+     if (tableName.contains(""/"")) {
+       return tableName + ""#"" + type;
+-    } else if (tableName.startsWith(""hadoop."") || tableName.startsWith(""hive."")) {
+-      // HiveCatalog and HadoopCatalog prepend a logical name which we need to drop for Spark 2.4
++    } else if (tableName.startsWith(""hadoop."")) {
++      // Load a path by HadoopCatalog or HadoopTables
++      return table().location() + ""#"" + type;
++    } else if (tableName.startsWith(""hive."")) {
++      // HiveCatalog prepend a logical name which we need to drop for Spark 2.4
+       return tableName.replaceFirst(""(hadoop\\.)|(hive\\.)"", """") + ""."" + type;
+     } else {
+       return tableName + ""."" + type;",Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path.,"I think we can simplify this to `return table().replaceFirst(""."", """");`"
+901,"@@ -1,4 +1,5 @@
+ require 'fileutils'
++require 'digest'
+
+ module RSpec
+   module Core","This require isn't need anymore, right?",rubocop doesn't like this
+902,"@@ -32,6 +32,7 @@ import (
+ 	""github.com/mysteriumnetwork/node/session""
+ 	""github.com/mysteriumnetwork/node/session/balance""
+ 	""github.com/mysteriumnetwork/node/session/promise""
++	""github.com/mysteriumnetwork/payments/crypto""
+ 	""github.com/pkg/errors""
+ )
+ ",a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments..,Can you move the `crypto` package to `core` package?
+903,"@@ -889,7 +889,7 @@ trait MarcAdvancedTrait
+                 'http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd',
+                 'http://www.w3.org/2001/XMLSchema-instance'
+             );
+-            $xml->record->addAttribute('type', 'Bibliographic');
++            $xml->record->addAttribute('type', $this->xmlType);
+             return $xml->record->asXML();
+         }
+ ","I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all.",incorrect indentation due to tabulation
+904,"@@ -2,6 +2,10 @@ package protocol
+
+ import ""time""
+
++// NonForwardSecurePacketSizeReduction is the number of bytes a non forward-secure packet has to be smaller than a forward-secure packet
++// This makes sure that those packets can always be retransmitted without splitting the contained StreamFrames
++const NonForwardSecurePacketSizeReduction = 50
++
+ // DefaultMaxCongestionWindow is the default for the max congestion window
+ const DefaultMaxCongestionWindow = 1000
+ ","I would prefer to not have a magic number, but construct this value out of other constants we already have.",Nit: I would call this something like NonForwardSecurePacketSizeReduction
+905,"@@ -101,6 +101,15 @@ def setup_authentication(config):
+     from configuration.
+     """"""
+     config.include('pyramid_multiauth')
++    settings = config.get_settings()
++
++    policies = aslist(settings['multiauth.policies'])
++    if 'basicauth' in policies:
++        config.add_api_capability(
++            ""basicauth"",
++            description=""Very basic authentication sessions. Not for production use."",
++            url=""http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html"",
++        )
+
+     # Track policy used, for prefixing user_id and for logging.
+     def on_policy_selected(event):","The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess.","I don't think we should mention ""not for production use"" here. What do yo"
+906,"@@ -31,8 +31,8 @@ import (
+ 	_ ""gocloud.dev/secrets/awskms""
+ 	_ ""gocloud.dev/secrets/azurekeyvault""
+ 	_ ""gocloud.dev/secrets/gcpkms""
+-	_ ""gocloud.dev/secrets/hashivault""
+ 	_ ""gocloud.dev/secrets/localsecrets""
++	_ ""gocloud.dev/secrets/vault""
+ )
+
+ const helpSuffix = `",? The package is named `hashivault`.,Why is this in this PR?
+907,"@@ -240,6 +240,9 @@ static int config_ini_handler(void *user, const char *section, const char *name,
+ 		if (strcmp(name, ""xwayland"") == 0) {
+ 			if (strcasecmp(value, ""true"") == 0) {
+ 				config->xwayland = true;
++			} else if (strcasecmp(value, ""lazy"") == 0) {
++				config->xwayland = true;
++				config->xwayland_lazy = true;
+ 			} else if (strcasecmp(value, ""false"") == 0) {
+ 				config->xwayland = false;
+ 			} else {","I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`",I don't think this line is needed.
+908,"@@ -28,7 +28,6 @@ import (
+ 	fakeclientset ""k8s.io/client-go/kubernetes/fake""
+ 	certutil ""k8s.io/client-go/util/cert""
+ 	""k8s.io/client-go/util/keyutil""
+-
+ 	fakeaggregatorclientset ""k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/fake""
+ )
+ ",Remove this line by accident?,`fakeclientset` is now unused. Please remove it.
+909,"@@ -16,12 +16,13 @@
+
+ package com.palantir.baseline.plugins;
+
++import java.util.Collections;
+ import java.util.Objects;
+ import org.gradle.api.Plugin;
+ import org.gradle.api.Project;
+ import org.gradle.api.artifacts.Dependency;
+-import org.gradle.api.plugins.JavaPluginConvention;
+ import org.gradle.api.tasks.SourceSet;
++import org.gradle.api.tasks.SourceSetContainer;
+ import org.gradle.api.tasks.compile.JavaCompile;
+
+ public final class BaselineImmutables implements Plugin<Project> {","Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?",`Immutables` -> `ImmutableMap`?
+910,"@@ -201,7 +201,10 @@ func CreateGitIgnore(targetDir string, ignores ...string) error {
+
+ 	if fileutil.FileExists(gitIgnoreFilePath) {
+ 		sigFound, err := fileutil.FgrepStringInFile(gitIgnoreFilePath, DdevFileSignature)
+-		util.CheckErr(err)
++		if err != nil {
++			return err
++		}
++
+ 		// If we sigFound the file and did not find the signature in .ddev/.gitignore, warn about it.
+ 		if !sigFound {
+ 			util.Warning(""User-managed %s will not be managed/overwritten by ddev"", gitIgnoreFilePath)","Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where ""can't happen"" but Things Can Happen.",Why remove the `CheckErr`?
+911,"@@ -275,6 +275,15 @@ func (b *ofFlowBuilder) MatchARPOp(op uint16) FlowBuilder {
+ 	return b
+ }
+
++// MatchIPDscp adds match condition for matching DSCP field in the IP header. Note, OVS use TOS to present DSCP, and
++// the field name is shown as ""nw_tos"" with OVS command line, and the value is calculated by shifting the given value
++// left 2 bits.
++func (b *ofFlowBuilder) MatchIPDscp(dscp uint8) FlowBuilder {
++	b.matchers = append(b.matchers, fmt.Sprintf(""nw_tos=%d"", dscp<<2))
++	b.Match.IpDscp = dscp
++	return b
++}
++
+ // MatchConjID adds match condition for matching conj_id.
+ func (b *ofFlowBuilder) MatchConjID(value uint32) FlowBuilder {
+ 	b.matchers = append(b.matchers, fmt.Sprintf(""conj_id=%d"", value))",What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?,Would `nw_tos` be better in this flow builder in
+912,"@@ -329,12 +329,17 @@ extern ""C"" bool isValidMolBlob(char *data, int len) {
+   return res;
+ }
+
+-extern ""C"" char *makeMolText(CROMol data, int *len, bool asSmarts) {
++extern ""C"" char *makeMolText(CROMol data, int *len, bool asSmarts,
++                             bool cxSmiles) {
+   ROMol *mol = (ROMol *)data;
+
+   try {
+     if (!asSmarts) {
+-      StringData = MolToSmiles(*mol, true);
++      if (!cxSmiles) {
++        StringData = MolToSmiles(*mol);
++      } else {
++        StringData = MolToCXSmiles(*mol);
++      }
+     } else {
+       StringData = MolToSmarts(*mol, false);
+     }",I'm assuming that asSmarts & cxSmiles == asSmarts,"This declaration of `cxSmiles` can be moved inside the `if` condition, since it's only used in one place."
+913,"@@ -780,7 +780,9 @@ class LabelledData(param.Parameterized):
+         except:
+             self.warning(""Could not unpickle custom style information."")
+         self.__dict__.update(d)
+-
++        # TODO: super's setstate not called?
++        if ""param"" not in self.__dict__:
++            self.param = type(self.param)(self.__class__, self=self)
+
+
+ class Dimensioned(LabelledData):",Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken.,Hmm... Why is this one called `setstate`? Is it just `setstate`?
+914,"@@ -30,8 +30,8 @@ namespace Examples.Console
+     internal class InstrumentationWithActivitySource : IDisposable
+     {
+         private const string RequestPath = ""/api/request"";
+-        private SampleServer server = new SampleServer();
+-        private SampleClient client = new SampleClient();
++        private readonly SampleServer server = new SampleServer();
++        private readonly SampleClient client = new SampleClient();
+
+         public void Start(ushort port = 19999)
+         {","Curious, do we consider this as pedantic for example code?","I'm not sure about these changes. `InstrumentationWithActivitySource` is internal, so we should be OK wit"
+915,"@@ -609,7 +609,7 @@ class AdminController extends Controller
+
+         $formType = $this->useLegacyFormComponent() ? 'easyadmin' : 'JavierEguiluz\\Bundle\\EasyAdminBundle\\Form\\Type\\EasyAdminFormType';
+
+-        return $this->get('form.factory')->createNamedBuilder('form', $formType, $entity, $formOptions);
++        return $this->get('form.factory')->createNamedBuilder(strtolower($this->entity['name']), $formType, $entity, $formOptions);
+     }
+
+     /**","Should we convert the entity name to snake case using `Doctrine\Common\Inflector\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?",Why changing this? Shouldn't we use the `getName` method?
+916,"@@ -12,9 +12,15 @@ func NewClientFake(IP string) Client {
+
+ type clientFake struct {
+ 	ip string
++	outboundIp string
+ }
+
+-func (client *clientFake) GetIp() (string, error) {
++func (client *clientFake) GetPublicIP() (string, error) {
++	log.Info(IPIFY_API_LOG_PREFIX, ""IP faked: "", client.ip)
++	return client.ip, nil
++}
++
++func (client *clientFake) GetOutboundIP() (string, error) {
+ 	log.Info(IPIFY_API_LOG_PREFIX, ""IP faked: "", client.ip)
+ 	return client.ip, nil
+ }",Should be `client.outboundIp`,"Out of curiosity, why do we need to log this at all?"
+917,"@@ -31,6 +31,9 @@
+ // THE POSSIBILITY OF SUCH DAMAGE.
+ //
+
++using System.IO;
++using System.Threading.Tasks;
++
+ namespace NLog.UnitTests.LayoutRenderers
+ {
+     using System;",Must these `using` statements not go inside the `namespace` block?,Do we need `using System.IO` or can we remove it?
+918,"@@ -92,8 +92,8 @@ type fboMutexLevel mutexLevel
+
+ const (
+ 	fboMDWriter fboMutexLevel = 1
+-	fboHead                   = 2
+-	fboBlock                  = 3
++	fboHead     fboMutexLevel = 2
++	fboBlock    fboMutexLevel = 3
+ )
+
+ func (o fboMutexLevel) String() string {",Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.),Is this supposed to be an enum value?
+919,"@@ -12,11 +12,7 @@ define([], function() {
+     }
+
+     function uploadContent(connectionManager, server, options) {
+-        return new Promise(function(resolve, reject) {
+-            require([""contentuploader""], function(ContentUploader) {
+-                (new ContentUploader).uploadImages(connectionManager, server).then(resolve, reject)
+-            })
+-        })
++        return new Promise().resolve();
+     }
+
+     function syncMedia(connectionManager, server, options) {",shouldn't we `reject` here instead?,"No need to use a new promise here, you can just retu"
+920,"@@ -167,10 +167,12 @@ func printActionProto(action *iotextypes.Action) (string, error) {
+ 	if err != nil {
+ 		return """", output.NewError(output.ConvertError, ""failed to convert bytes into address"", err)
+ 	}
++	//ioctl action should display IOTX unit instead Raul
++	gasPriceUnitIOTX, err := util.StringToIOTX(action.Core.GasPrice)
+ 	result := fmt.Sprintf(""\nversion: %d  "", action.Core.GetVersion()) +
+ 		fmt.Sprintf(""nonce: %d  "", action.Core.GetNonce()) +
+ 		fmt.Sprintf(""gasLimit: %d  "", action.Core.GasLimit) +
+-		fmt.Sprintf(""gasPrice: %s Rau\n"", action.Core.GasPrice) +
++		fmt.Sprintf(""gasPrice: %s IOTX\n"", gasPriceUnitIOTX) +
+ 		fmt.Sprintf(""senderAddress: %s %s\n"", senderAddress.String(),
+ 			Match(senderAddress.String(), ""address""))
+ 	switch {","check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct",How do you know that this is Rau and not IOTX?
+921,"@@ -34,7 +34,7 @@ func newHarness(t *testing.T) (drivertest.Harness, error) {
+ 	return &harness{vars: map[string][]byte{}}, nil
+ }
+
+-func (h *harness) MakeWatcher(ctx context.Context, name string, decoder *runtimevar.Decoder, wait time.Duration) (driver.Watcher, error) {
++func (h *harness) MakeWatcher(ctx context.Context, name string, decoder *runtimevar.Decoder) (driver.Watcher, error) {
+ 	rawVal, found := h.vars[name]
+ 	if !found {
+ 		// The variable isn't set. Create a Variable that always returns an error.","Just curious, was wait not used at all before?",Is this unused?
+922,"@@ -7,9 +7,10 @@ package manifest
+ import (
+ 	""errors""
+ 	""fmt""
++	""github.com/google/shlex""
+ 	""path/filepath""
+ 	""strconv""
+-	""strings""
++	//""strings""
+
+ 	""github.com/aws/aws-sdk-go/aws""
+ 	""gopkg.in/yaml.v3""",nit: can we remove this?,let's remove this line
+923,"@@ -44,11 +44,11 @@ public class NotificationStore {
+         }
+     }
+
+-    public Notification get(int index) {
++    public synchronized Notification get(int index) {
+         return store.get(index);
+     }
+
+-    public void add(Notification n) {
++    public synchronized void add(Notification n) {
+         log.info(""Notification received: "" + n.text);
+         for (int i = 0; i < store.size(); i++) {
+             if (get(i).id == n.id) {",is it not a problem when one synchronized function is called by other?,`index` doesn't seem to be used in this method
+924,"@@ -1,6 +1,7 @@
+ ActiveAdmin.register Account do
+-  permit_params :level
+-  actions :index, :show, :edit
++  permit_params :login, :email, :level, :country_code, :location, :url, :hide_experience, :email_master, :email_posts,
++                :email_kudos, :email_new_followers, :twitter_account, :affiliation_type, :organization_name
++  actions :index, :show, :edit, :update
+
+   controller do
+     defaults finder: :fetch_by_login_or_email","We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!","here you are missing the `show` action, but not the `update` action."
+925,"@@ -20,7 +20,7 @@ return [
+     'alpha_dash'           => 'O campo :attribute deve conter apenas letras, números e traços.',
+     'alpha_num'            => 'O campo :attribute deve conter apenas letras e números .',
+     'array'                => 'O campo :attribute deve conter um array.',
+-    'attached'             => 'This :attribute is already attached.',
++    'attached'             => 'Este :attribute já está ligado.',
+     'before'               => 'O campo :attribute deve conter uma data anterior a :date.',
+     'before_or_equal'      => 'O campo :attribute deve conter uma data inferior ou igual a :date.',
+     'between'              => [","""Este :attribute j est anexado."" sounds better.",Prefer double-quoted strings unless you need single quotes to avoid
+926,"@@ -0,0 +1,6 @@
++
++if __name__ == ""__main__"":
++    import doctest
++    import databricks.koalas as ks
++    from databricks.koalas import frame, series
++    doctest.testmod(frame, extraglobs={""ks"": ks})","This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files.",Need a newline before this to comply with PEP8
+927,"@@ -301,5 +301,3 @@ var failedIssuanceMu sync.RWMutex
+ // If this value is recent, do not make any on-demand certificate requests.
+ var lastIssueTime time.Time
+ var lastIssueTimeMu sync.Mutex
+-
+-var errNoCert = errors.New(""no certificate available"")",This error was unused,Do we not need this anymore?
+928,"@@ -212,6 +212,11 @@ type (
+ 		PreviousRangeID int64
+ 	}
+
++	// CloseShardRequest is used to notify persistence that we're unloading a shard
++	CloseShardRequest struct {
++		ShardID int32
++	}
++
+ 	// AddTasksRequest is used to write new tasks
+ 	AddTasksRequest struct {
+ 		ShardID int32","Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching.",Why do we need a shard ID here?
+929,"@@ -0,0 +1,5 @@
++<% if trail.complete? %>
++  <%= render ""completed_trails/trail"", trail: trail %>
++<% else %>
++  <%= render ""trails/incomplete_trail"", trail: trail %>
++<% end %>",Does this make more sense as `trails/_trail` now?,Can you change this to `if trai
+930,"@@ -435,6 +435,17 @@ func (agent *ecsAgent) getEC2InstanceID() string {
+ 	return instanceID
+ }
+
++// getoutpostARN gets the Outpost ARN from the metadata service
++func (agent *ecsAgent) getoutpostARN() string {
++	outpostARN, err := agent.ec2MetadataClient.OutpostARN()
++	if err != nil {
++		seelog.Warnf(
++			""Unable to obtain Outpost ARN from EC2 Metadata: %v"", err)
++		return """"
++	}
++	return outpostARN
++}
++
+ // newStateManager creates a new state manager object for the task engine.
+ // Rest of the parameters are pointers and it's expected that all of these
+ // will be backfilled when state manager's Load() method is invoked","synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows.",This method seems to be unused.
+931,"@@ -12,6 +12,10 @@ class PythonMappings
+     fun.add_mapping(""py_env"", Python::VirtualEnv.new)
+
+     fun.add_mapping(""py_docs"", Python::GenerateDocs.new)
++
++	fun.add_mapping(""py_install"", Python::Install.new)
++
++	fun.add_mapping(""py_prep"", Python::Prep.new)
+   end
+ end
+ ","Too much indentation here. Should match the lines above, which have four spaces.",If these are only used in the t
+932,"@@ -15,14 +15,6 @@ BOOST_AUTO_TEST_CASE(test_incompatible_with_mld)
+         osrm::exception);
+ }
+
+-BOOST_AUTO_TEST_CASE(test_incompatible_with_corech)
+-{
+-    // Note - CH-only data can't be used with the CoreCH algorithm
+-    BOOST_CHECK_THROW(
+-        getOSRM(OSRM_TEST_DATA_DIR ""/ch/monaco.osrm"", osrm::EngineConfig::Algorithm::CoreCH),
+-        osrm::exception);
+-}
+-
+ BOOST_AUTO_TEST_CASE(test_incompatible_with_ch)
+ {
+     // Can't use the CH algorithm with MLD data",Same here we still need this test to make sure the fallback works.,Do we have a test that ensures that data is used with the CoreCH algorithm?
+933,"@@ -0,0 +1,8 @@
++using System;
++namespace MvvmCross.iOS.Views.Presenters.Attributes
++{
++    public interface IMvxOverridePresentationAttribute
++    {
++        MvxBasePresentationAttribute OverridePresentationAttribute();
++    }
++}",I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one.,I don't see where this is used?
+934,"@@ -430,7 +430,7 @@ export function unmount(vnode, parentVNode, skipRemove) {
+ 			}
+ 		}
+
+-		r.base = r._parentDom = null;
++		r.base = r._parentDom = r._vnode = vnode._component = null;
+ 	}
+
+ 	if ((r = vnode._children)) {",could we switch to `undefined` here?,Do we need to set `_vnode` and `_component` to null here?
+935,"@@ -94,6 +94,7 @@ public class SyncManager {
+         this.smartStore = smartStore;
+         this.restClient = restClient;
+         SyncState.setupSyncsSoupIfNeeded(smartStore);
++        SyncState.cleanupSyncsSoupIfNeeded(smartStore);
+     }
+
+     /**",The cleanup call,Does this need to be called after `setupSyncsSoupIfNeeded`?
+936,"@@ -288,10 +288,11 @@ define(['apphost', 'globalize', 'connectionManager', 'itemHelper', 'appRouter',
+                 icon: 'album'
+             });
+         }
+-
+-        if (options.openArtist !== false && item.ArtistItems && item.ArtistItems.length) {
++        // Show Album Artist by default, as a song can have multiple artists, which specific one would this option refer to?
++        // Although some albums can have multiple artists, it's not as common as songs.
++        if (options.openArtist !== false && item.AlbumArtists && item.AlbumArtists.length) {
+             commands.push({
+-                name: globalize.translate('ViewArtist'),
++                name: globalize.translate('ViewAlbumArtist'),
+                 id: 'artist',
+                 icon: 'person'
+             });","I think ""View artist"" is a bit more standard and expected. Or even ""Go to artist"" to take the Spotify terminology as-is.","I'm not sure if this is the right icon for this. My thought is that if people have multiple album artists, then they'll both see the ""album"" icon. What happens if they have multiple artists, then they see the ""artist"" icon, but only one of them?"
+937,"@@ -196,6 +196,9 @@ module Bolt
+       # This works on deeply nested data structures composed of Hashes, Arrays, and
+       # and plain-old data types (int, string, etc).
+       def unwrap_sensitive_args(arguments)
++        # Skip this if Puppet isn't loaded
++        return arguments unless defined?(Puppet::Pops::Types::PSensitiveType::Sensitive)
++
+         case arguments
+         when Array
+           # iterate over the array, unwrapping all elements",It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values.,@stevegsa just wanted to check my understanding on this: is this function always called when Puppet is not loaded?
+938,"@@ -30,3 +30,7 @@ from extensive_tm_test_base import ExtensiveTemporalMemoryTest
+ class ExtensiveTemporalMemoryTestCPP(ExtensiveTemporalMemoryTest, unittest.TestCase):
+   def getTMClass(self):
+     return nupic.bindings.algorithms.TemporalMemory
++
++
++if __name__ == ""__main__"":
++  unittest.main()",We were trying to move away from this to force people to always run tests under py.test.,Do we need this if we have a unit test for it?
+939,"@@ -933,6 +933,8 @@ from selenium.webdriver.common.keys import Keys
+
+         browser = self._check_platform()
+
++        body.append(self._get_selenium_options())
++
+         if browser == 'firefox':
+             body.extend(self._get_firefox_options() + self._get_firefox_profile() + [self._get_firefox_webdriver()])
+ ",1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions,Why is this change necessary?
+940,"@@ -681,7 +681,9 @@ class ProxyListenerS3(ProxyListener):
+
+                 # fix content-type: https://github.com/localstack/localstack/issues/618
+                 #                   https://github.com/localstack/localstack/issues/549
+-                if 'text/html' in response.headers.get('Content-Type', ''):
++                #                   https://github.com/localstack/localstack/issues/854
++                if 'text/html' in response.headers.get('Content-Type', '') \
++                        and not response_content_str.startswith('<!doctype html'):
+                     response.headers['Content-Type'] = 'application/xml; charset=utf-8'
+
+                 reset_content_length = True",should be a case insensitive match though no? DOCTYPE and doctype are both widely used,Do we want to check for `application/xml; charset=utf-8` here?
+941,"@@ -0,0 +1,15 @@
++class AccountWidgetsController < WidgetsController
++  before_action :set_account
++  before_action :render_gif_image
++  before_action :account_context, only: :index
++
++  def index
++    @widgets = AccountWidget.create_widgets(params[:account_id])
++  end
++
++  private
++
++  def set_account
++    @account = Account.from_param(params[:account_id]).first!
++  end
++end",We must have a `fail ParamNotFound` here for cases where `@account.nil?`.,Style/NumericPredicate: Use params[:account_id].zero? instead
+942,"@@ -144,6 +144,7 @@ namespace Datadog.Trace.Vendors.Newtonsoft.Json.Serialization
+             return property;
+         }
+
++#if !NETCOREAPP
+         private bool TryGetValue(string key, out JsonProperty item)
+         {
+             if (Dictionary == null)",How come this change was needed?,Why are these `#if`s necessary?
+943,"@@ -25,3 +25,13 @@ const (
+ 	UART_TX_PIN = 6
+ 	UART_RX_PIN = 8
+ )
++
++// ADC pins
++const (
++	ADC0 = 3
++	ADC1 = 4
++	ADC2 = 28
++	ADC3 = 29
++	ADC4 = 30
++	ADC5 = 31
++)","Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?",You can use the `ADC_*` constants here as well.
+944,"@@ -224,7 +224,9 @@ func (gsf *GraphSyncFetcher) fetchRemainingTipsets(ctx context.Context, starting
+ // non-recursively
+ func (gsf *GraphSyncFetcher) fetchBlocks(ctx context.Context, cids []cid.Cid, targetPeer peer.ID) error {
+ 	selector := gsf.ssb.ExploreFields(func(efsb selectorbuilder.ExploreFieldsSpecBuilder) {
+-		efsb.Insert(""messages"", gsf.ssb.Matcher())
++		efsb.Insert(""messages"", gsf.ssb.ExploreFields(func(messagesSelector selectorbuilder.ExploreFieldsSpecBuilder) {
++			messagesSelector.Insert(""secpRoot"", gsf.ssb.Matcher())
++		}))
+ 		efsb.Insert(""messageReceipts"", gsf.ssb.Matcher())
+ 	}).Node()
+ 	var wg sync.WaitGroup","I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!",shouldn't this be `secpRoot/messageReceipts`
+945,"@@ -1,7 +1,7 @@
+ C2::Application.configure do
+   config.action_mailer.preview_path = ""#{Rails.root}/lib/mail_previews""
+   config.action_mailer.register_preview_interceptor :css_inline_styler
+-  config.action_mailer.asset_host = ""http://localhost:5000""
++  config.action_mailer.asset_host = ""http://2c429f18.ngrok.io"" || ""http://localhost:5000""
+   config.action_controller.perform_caching = false
+   config.action_mailer.delivery_method = :letter_opener_web
+   config.active_record.migration_error = :page_load",what is this default about? I am not using ngrok atm so would prefer an env var.,Prefer single-quoted strings when you don't
+946,"@@ -93,6 +93,19 @@ return [
+
+     'backendSkin' => 'Backend\Skins\Standard',
+
++    /*
++    |--------------------------------------------------------------------------
++    | Determines if logging in backend should run UpdateManager
++    |--------------------------------------------------------------------------
++    |
++    | If value is true it runs UpdateMananger after login in backend.
++    | It's recommended to set this value to 'false' in production enviroments
++    | because it cleares cache on every login in backend.
++    |
++    */
++
++    'runUpdateManagerAfterBackendLogin' => true,
++
+     /*
+     |--------------------------------------------------------------------------
+     | Determines which modules to load","@Samuell1 Might be better to say ""Automatically check for plugin updates on login"".",Default to 'false'. It's a bit more explicit
+947,"@@ -1,4 +1,6 @@
++using System;
+ using System.Diagnostics;
++using System.Runtime.CompilerServices;
+
+ namespace Datadog.Trace.Util
+ {",Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed,We shouldn't be using anything from the `Sys
+948,"@@ -73,6 +73,19 @@ func (*mockStatsEngine) GetTaskHealthMetrics() (*ecstcs.HealthMetadata, []*ecstc
+ 	return nil, nil, nil
+ }
+
++// TestDisableMetrics tests the StartMetricsSession will return immediately if
++// the metrics was disabled
++func TestDisableMetrics(t *testing.T) {
++	params := TelemetrySessionParams{
++		Cfg: &config.Config{
++			DisableMetrics:           true,
++			DisableDockerHealthCheck: true,
++		},
++	}
++
++	StartMetricsSession(params)
++}
++
+ func TestFormatURL(t *testing.T) {
+ 	endpoint := ""http://127.0.0.0.1/""
+ 	wsurl := formatURL(endpoint, testClusterArn, testInstanceArn)","just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?",Can we just call this `TestDisableMetrics` to match the other tests?
+949,"@@ -198,8 +198,9 @@ func TestInferModulePath(t *testing.T) {
+ 					t.Error(err)
+ 				}
+ 			}()
+-
+-			pctx := newTestProcessContext(dir)
++			srcDir := filepath.Join(dir, ""src"")
++			os.Mkdir(srcDir, 0777)
++			pctx := newTestProcessContext(srcDir)
+ 			gopath, cleanup := tc.testGOPATH(dir)
+ 			defer cleanup()
+ 			pctx.env = []string{gopath}",We should fail the test if this returns `err != nil`.,What was the reason for this change?
+950,"@@ -140,6 +140,9 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c
+ 	}
+
+ 	updated = false
++	// Fun extra variable to keep track of whether we should increment metricProvisionFailedTerminal
++	// later; because we only want to do that if (we change that status and) the status update succeeds.
++	provisionFailedTerminal := false
+ 	conditions, updated = controllerutils.SetClusterDeploymentConditionWithChangeCheck(conditions,
+ 		hivev1.ProvisionStoppedCondition,
+ 		stopped.Status,",What is the drawback of not having this flag as a gating condition to report the metric?,"This variable is unused now, right? Can we remove it?"
+951,"@@ -22,9 +22,14 @@ import (
+ )
+
+ func gracefullyStopProcess(pid int) error {
++	fmt.Printf(""Graceful stop..."")
+ 	err := syscall.Kill(pid, syscall.SIGINT)
+ 	if err != nil {
+ 		return fmt.Errorf(""kill: %v"", err)
+ 	}
+ 	return nil
+ }
++
++func getAppName() string {
++	return filepath.Base(os.Args[0])
++}","`getProcessName()` will be less ambiguous, since Caddy has ""apps"" that it runs internally.",Did you mean to leave this here?
+952,"@@ -4741,6 +4741,7 @@ const char * const DMLFormats[] =
+     ""<exec cmd=\""!DumpIL /i %s\"">%s</exec>"",         // DML_IL
+     ""<exec cmd=\""!DumpRCW -cw /d %s\"">%s</exec>"",    // DML_ComWrapperRCW
+     ""<exec cmd=\""!DumpCCW -cw /d %s\"">%s</exec>"",    // DML_ComWrapperCCW
++    ""<exec cmd=\""dps %s L2\"">%s</exec>"",             // DML_TaggedMemory (hardcoded current size to 2 pointer sizes)
+ };
+
+ void ConvertToLower(__out_ecount(len) char *buffer, size_t len)","Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a ""scratch memory"" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?",(style) quoted string split across lines
+953,"@@ -64,6 +64,13 @@ nebula::cpp2::ErrorCode ScanEdgeProcessor::checkAndBuildContexts(const cpp2::Sca
+   std::vector<cpp2::EdgeProp> returnProps = {*req.return_columns_ref()};
+   ret = handleEdgeProps(returnProps);
+   buildEdgeColName(returnProps);
++  ret = buildFilter(req, [](const cpp2::ScanEdgeRequest& r) -> const std::string* {
++    if (r.filter_ref().has_value()) {
++      return r.get_filter();
++    } else {
++      return nullptr;
++    }
++  });
+   return ret;
+ }
+ ",How about just override the `buildFilter`? Passing another function here is a little weird.,Use `nullptr` instead of `nullptr` to av
+954,"@@ -71,8 +71,9 @@ var (
+
+ 	ignoredPackages = app.Flag(""ignored-packages"", ""Space separated list of specs ignoring rebuilds if their dependencies have been updated. Will still build if all of the spec's RPMs have not been built."").String()
+
+-	pkgsToBuild   = app.Flag(""packages"", ""Space separated list of top-level packages that should be built. Omit this argument to build all packages."").String()
+-	pkgsToRebuild = app.Flag(""rebuild-packages"", ""Space separated list of base package names packages that should be rebuilt."").String()
++	pkgsToBuild     = app.Flag(""packages"", ""Space separated list of top-level packages that should be built. Omit this argument to build all packages."").String()
++	pkgsToRebuild   = app.Flag(""rebuild-packages"", ""Space separated list of base package names packages that should be rebuilt."").String()
++	rpmHydratedTest = app.Flag(""rpm-hydrated-test"", ""Is this just a TestRPM build with all RPMs hydrated?"").String()
+
+ 	logFile  = exe.LogFileFlag(app)
+ 	logLevel = exe.LogLevelFlag(app)","This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in.",Let's just name it `rpm-hydrated` for cl
+955,"@@ -2042,6 +2042,7 @@ bool SwiftLanguageRuntime::GetDynamicTypeAndAddress_Promise(
+     address.SetLoadAddress(val_ptr_addr, &m_process->GetTarget());
+     return true;
+   } break;
++  case swift::MetadataKind::Function:
+   case swift::MetadataKind::Optional:
+   case swift::MetadataKind::Struct:
+   case swift::MetadataKind::Tuple: {",Is this needed?,Consider adding default case as well.
+956,"@@ -348,7 +348,7 @@ export default Ember.Controller.extend(BillingCategories, EKMixin,
+       confirmDeleteValue(value) {
+         let i18n = this.get('i18n');
+         let title = i18n.t('admin.lookup.titles.deleteLookupValue');
+-        let message = i18n.t('admin.lookup.messages.deleteLookupValue', { value });
++        let message = i18n.t('messages.delete_singular', { name: value.concat(' value') });
+         this.displayConfirm(title, message, 'deleteValue', Ember.Object.create({
+           valueToDelete: value
+         }));",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,"The name `deleteLookupValue` doesn't make much sense to me, how about something like `deleteLookupTitle`, `deleteLookupMessage`?"
+957,"@@ -18,6 +18,8 @@ package container
+ import (
+ 	""context""
+
++	""github.com/chaos-mesh/chaos-mesh/pkg/selector/generic""
++
+ 	""go.uber.org/fx""
+ 	v1 ""k8s.io/api/core/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""",how about moving it under L26,This import should go with the rest of the `pkg/selector` imports.
+958,"@@ -0,0 +1,17 @@
++/**
++ * Memoize a function.
++ * @method memoize
++ * @memberof axe.utils
++ * @param {Function} fn Function to memoize
++ * @return {Function}
++ */
++axe._memoizedFns = [];
++axe.utils.memoize = function(fn) {
++	// keep track of each function that is memoized so it can be cleared at
++	// the end of a run. each memoized function has its own cache, so there is
++	// no method to clear all memoized caches. instead, we have to clear each
++	// individual memoized function ourselves.
++	const memoized = axe.imports.memoize(fn);
++	axe._memoizedFns.push(memoized);
++	return memoized;
++};",I think this needs to be tested,`memoize` is not a great name for this. `memoizeFn` could be more descriptive.
+959,"@@ -2,6 +2,9 @@ class Trail < ApplicationRecord
+   extend FriendlyId
+
+   include PgSearch
++
++  DEFAULT_IMAGE_URL = ""https://images.thoughtbot.com/upcase/trail-title-cards/default.jpg""
++
+   multisearchable against: [:name, :description], if: :published?
+
+   validates :name, :description, presence: true",Style/MutableConstant: Freeze mutable objects assigned to constants.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+960,"@@ -155,16 +155,15 @@ public final class DeflateWithPresetDictCompressionMode extends CompressionMode
+
+   private static class DeflateWithPresetDictCompressor extends Compressor {
+
+-    final byte[] dictBytes;
+-    final int blockLength;
++    private final int dictLength, blockLength;
+     final Deflater compressor;
+     byte[] compressed;
+     boolean closed;
+
+     DeflateWithPresetDictCompressor(int level, int dictLength, int blockLength) {
+-      compressor = new Deflater(level, true);
++      compressor = BugfixDeflater_JDK8252739.createDeflaterInstance(level, true, dictLength);
+       compressed = new byte[64];
+-      this.dictBytes = new byte[dictLength];
++      this.dictLength = dictLength;
+       this.blockLength = blockLength;
+     }
+ ","Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken.",Are you sure you want to use the `dictLength` instead of the `dictLength` in the constructor?
+961,"@@ -95,7 +95,7 @@ public class FSTTester<T> {
+     return br;
+   }
+
+-  static String getRandomString(Random random) {
++  public static String getRandomString(Random random) {
+     final String term;
+     if (random.nextBoolean()) {
+       term = TestUtil.randomRealisticUnicodeString(random);",Looks like this should be publicly accessible for tests in any modules?,why does this need to be public?
+962,"@@ -19,7 +19,7 @@ if (is_array($env = @include dirname(__DIR__).'/.env.local.php')) {
+     throw new RuntimeException('Please run ""composer require symfony/dotenv"" to load the "".env"" files configuring the application.');
+ } else {
+     $path = dirname(__DIR__).'/.env';
+-    $dotenv = new Dotenv(false);
++    $dotenv = new Dotenv(true);
+
+     // load all the .env files
+     if (method_exists($dotenv, 'loadEnv')) {",Allow putenv is necessary to be able to get environment variables with `getenv`?,I don't think this should be changed
+963,"@@ -0,0 +1,17 @@
++#include <iostream>
++#include <conio.h>
++using namespace std;
++
++int main()
++{
++	int year;
++	cout<<""Enter year to check\n"";
++	cin>>year;
++	if((year%4==0 && year%100!=0) || year%400==0){
++		cout<<""leap year.\n"";
++	}
++	else{
++		cout<<"" Not leap year.\n"";
++	}
++	return 0;
++}",use function to check it. - don't do everything in main,This line should be indented. See other files for examples.
+964,"@@ -50,7 +50,7 @@ class BaseRulesEngine(object):
+         self.full_rules_path = rules_file_path.strip()
+         self.snapshot_timestamp = snapshot_timestamp
+
+-    def build_rule_book(self):
++    def build_rule_book(self, global_configs):
+         """"""Build RuleBook from the rules definition file.""""""
+         raise NotImplementedError('Implement in a child class.')
+ ",Sorry I'm confused. Why not kwarg this like the others?,why is the global_configs needed here? it doesn't seem to be used?
+965,"@@ -7171,15 +7171,15 @@ const instr_info_t vex_W_extensions[][2] = {
+      * registers are identical.  We don't bother trying to detect that.
+      */
+     {OP_vpgatherdd,0x66389018,""vpgatherdd"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+-    {OP_vpgatherdq,0x66389058,""vpgatherdq"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vpgatherdq,0x66389058,""vpgatherdq"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 67 */
+-    {OP_vpgatherqd,0x66389118,""vpgatherqd"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vpgatherqd,0x66389118,""vpgatherqd"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+     {OP_vpgatherqq,0x66389158,""vpgatherqq"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 68 */
+     {OP_vgatherdps,0x66389218,""vgatherdps"",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+-    {OP_vgatherdpd,0x66389258,""vgatherdpd"",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vgatherdpd,0x66389258,""vgatherdpd"",Vvd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 69 */
+-    {OP_vgatherqps,0x66389318,""vgatherqps"",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vgatherqps,0x66389318,""vgatherqps"",Vvs,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+     {OP_vgatherqpd,0x66389358,""vgatherqpd"",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 70 */
+     {OP_vpmaskmovd,0x66388c18,""vpmaskmovd"",Vx,xx,Hx,Mx,xx, mrm|vex|reqp|predcx,x,tvexw[71][0]},","First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So ""vpgatherdq"" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess.","wouldn't it make more sense to call it ""end_list"" ?"
+966,"@@ -118,6 +118,9 @@ class ExternalProgramTask(luigi.Task):
+         file_object.seek(0)
+         return ''.join(map(lambda s: s.decode('utf-8'), file_object.readlines()))
+
++    def build_tracking_url(self, logs_output):
++        return logs_output
++
+     def run(self):
+         args = list(map(str, self.program_args()))
+ ",Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method.,Could you add a docstring here?
+967,"@@ -121,10 +121,7 @@ bool Creature::canSee(const Position& pos) const
+
+ bool Creature::canSeeCreature(const Creature* creature) const
+ {
+-	if (!canSeeInvisibility() && creature->isInvisible()) {
+-		return false;
+-	}
+-	return true;
++	return canSeeInvisibility() && creature->isInvisible();
+ }
+
+ void Creature::setSkull(Skulls_t newSkull)",You introduced a bug here.,why did you remove the if here?
+968,"@@ -261,6 +261,14 @@ namespace Microsoft.DotNet.Build.Tasks.VersionTools
+                 ""true"",
+                 StringComparison.OrdinalIgnoreCase);
+
++            string oldValue = step.GetMetadata(""ReplacementSubstituteOld"");
++            string newValue = step.GetMetadata(""ReplacementSubstituteNew"");
++
++            if (!string.IsNullOrEmpty(oldValue) && !string.IsNullOrEmpty(newValue))
++            {
++                updater.ReplacementTransform = v => v.Replace(oldValue, newValue);
++            }
++
+             return updater;
+         }
+ ",Should we log a warning/error if only one is specified and not the other?,"nit: can be simplified to `updater.ReplacementTransform = v => v.Replace(oldValue, newValue);`"
+969,"@@ -463,4 +463,15 @@ func (c *fakeClient) ReportApplicationLiveStateEvents(ctx context.Context, req *
+ 	return &pipedservice.ReportApplicationLiveStateEventsResponse{}, nil
+ }
+
++func (c *fakeClient) GetLatestEvent(ctx context.Context, req *pipedservice.GetLatestEventRequest, opts ...grpc.CallOption) (*pipedservice.GetLatestEventResponse, error) {
++	c.logger.Info(""fake client received GetLatestEvent rpc"", zap.Any(""request"", req))
++	return &pipedservice.GetLatestEventResponse{
++		Event: &model.Event{
++			Id:        ""dev"",
++			Name:      ""dev"",
++			ProjectId: ""dev"",
++		},
++	}, nil
++}
++
+ var _ pipedservice.PipedServiceClient = (*fakeClient)(nil)",`ctx` is unused in GetLatestEvent,I think the `testClient` should be moved to `tests/client_test.go` file.
+970,"@@ -128,6 +128,14 @@ void nano_daemon::daemon::run (boost::filesystem::path const & data_path, nano::
+ 				logger.always_log (boost::format (""Open file descriptors limit is %1%"") % file_descriptor_limit);
+ 			}
+
++			// a 0-valued port means for the node 'let the OS decide'; however, for the daemon start up, if
++			// the user hasn't specified a port in the config, we must use the default peering port for the network
++			//
++			if (!config.node.peering_port)
++			{
++				config.node.peering_port = network_params.network.default_node_port;
++			}
++
+ 			auto node (std::make_shared<nano::node> (io_ctx, data_path, config.node, opencl_work, flags));
+ 			if (!node->init_error ())
+ 			{","This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to ""-1"" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well.",`s/let the OS determine/let the OS/`
+971,"@@ -10,7 +10,6 @@ __all__ = [
+
+ class ImageTransform(object):
+     """"""Preprocess an image.
+-
+     1. rescale the image to expected size
+     2. normalize the image
+     3. flip the image (if needed)",The blank line between the summary and detailed description is better to be kept.,nit: I don't think we need this blank line here
+972,"@@ -167,6 +167,11 @@ func (a *API) Setup() {
+ 	a.setMetadataEndpointsKey()
+ 	a.writeShapeNames()
+ 	a.resolveReferences()
++
++	if !a.NoRemoveUnusedShapes {
++		a.removeUnusedShapes()
++	}
++
+ 	a.fixStutterNames()
+ 	a.renameExportable()
+ 	a.applyShapeNameAliases()","Curiously, are these indents intended or should they be aligned?",Shouldn't this be a part of `removeUnusedShapes`?
+973,"@@ -1130,7 +1130,9 @@ def getControlFieldSpeech(attrs,ancestorAttrs,fieldType,formatConfig=None,extraD
+ 	else:
+ 		tableID = None
+
+-	roleText=getSpeechTextForProperties(reason=reason,role=role)
++	roleText=attrs.get('roleText')
++	if not roleText:
++		roleText=getSpeechTextForProperties(reason=reason,role=role)
+ 	stateText=getSpeechTextForProperties(reason=reason,states=states,_role=role)
+ 	keyboardShortcutText=getSpeechTextForProperties(reason=reason,keyboardShortcut=keyboardShortcut) if config.conf[""presentation""][""reportKeyboardShortcuts""] else """"
+ 	ariaCurrentText=getSpeechTextForProperties(reason=reason,current=ariaCurrent)","What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if.",Why do we need to add this check?
+974,"@@ -4801,7 +4801,15 @@ master_signal_handler_C(byte *xsp)
+         return;
+     }
+ #endif
+-    dcontext_t *dcontext = get_thread_private_dcontext();
++    /* We avoid using safe_read_tls_magic during detach. This thread may already have
++     * lost its TLS. A safe read may result into a race affecting asynchronous non-alarm
++     * signals (xref i#3535) between delivering the SIGSEGV and restoring the app's signal
++     * handlers. We don't need the thread's private dcontext anymore here at this point.
++     * Note that there is still a small race window if the signal gets delivered after the
++     * detach has finished, i.e. doing_detach is false. This is an issue in particular if
++     * the app has started re-attaching.
++     */
++    dcontext_t *dcontext = doing_detach ? NULL : get_thread_private_dcontext();
+
+ #ifdef MACOS
+ #    ifdef X64",This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit().,(style) line over 80 characters
+975,"@@ -561,5 +561,4 @@ public class TestJdbcCatalog {
+     String nsString = JdbcUtil.namespaceToString(ns);
+     Assert.assertEquals(ns, JdbcUtil.stringToNamespace(nsString));
+   }
+-
+ }",Can you remove this change?,What's wrong with this?
+976,"@@ -48,7 +48,7 @@ func ValidateCertificateForACMEIssuer(crt *cmapi.CertificateSpec, issuer *cmapi.
+ 	el := field.ErrorList{}
+
+ 	if crt.IsCA {
+-		el = append(el, field.Invalid(specPath.Child(""isCA""), crt.KeyAlgorithm, ""ACME does not support CA certificates""))
++		el = append(el, field.Invalid(specPath.Child(""isCA""), crt.IsCA, ""ACME does not support CA certificates""))
+ 	}
+
+ 	if crt.Subject != nil && len(crt.Subject.Organizations) != 0 {","Oh, was that a bug in the validation?","Shouldn't this be `specPath.Child(""isCA"")`?"
+977,"@@ -134,6 +134,10 @@ public class OnlineFeedViewActivity extends AppCompatActivity {
+         } else {
+             Log.d(TAG, ""Activity was started with url "" + feedUrl);
+             setLoadingLayout();
++            //Remove subscribeonandroid.com from feed URL in order to subscribe to the actual feed URL
++            if(feedUrl.contains(""subscribeonandroid.com"")){
++                feedUrl = feedUrl.replaceFirst(""((www.)?(subscribeonandroid.com/))"","""");
++            }
+             if (savedInstanceState == null) {
+                 startFeedDownload(feedUrl, null, null);
+             } else {","Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent.","We should have a constant for this, I think"
+978,"@@ -145,10 +145,12 @@ TEST(UpdateEdgeTest, Set_Filter_Yield_Test) {
+     decltype(req.return_columns) tmpColumns;
+     tmpColumns.emplace_back(Expression::encode(val1));
+     tmpColumns.emplace_back(Expression::encode(val2));
+-    std::string name = folly::to<std::string>(3002);
+-    std::string prop = ""tag_3002_col_2"";
+-    auto* sourcePropExp = new SourcePropertyExpression(&name, &prop);
++    delete val1;
++    delete val2;
++    auto* sourcePropExp = new SourcePropertyExpression(
++        new std::string(folly::to<std::string>(3002)), new std::string(""tag_3002_col_2""));
+     tmpColumns.emplace_back(Expression::encode(sourcePropExp));
++    delete sourcePropExp;
+
+     req.set_return_columns(std::move(tmpColumns));
+     req.set_insertable(false);","Actually, I don't think we need to create object on heap.",Why is `folly::to` needed here? Isn't `foll
+979,"@@ -84,7 +84,7 @@ void GenerateImports(grpc_generator::File *file, grpc_generator::Printer *printe
+ 	}
+ 	printer->Print(""import (\n"");
+ 	printer->Indent();
+-	printer->Print(vars, ""$context$ \""golang.org/x/net/context\""\n"");
++	printer->Print(vars, ""$context$ \""context\""\n"");
+ 	printer->Print(vars, ""$grpc$ \""google.golang.org/grpc\""\n"");
+ 	printer->Outdent();
+ 	printer->Print("")\n\n"");","this is a file we copy from gRPC, sp ideally it be fixed upstream as well..",why not just remove this line?
+980,"@@ -14,7 +14,6 @@
+ package zipkin2.storage.cassandra.v1;
+
+ import com.datastax.driver.core.Session;
+-import com.google.common.cache.CacheBuilderSpec;
+ import java.nio.ByteBuffer;
+ import java.util.ArrayList;
+ import java.util.LinkedHashSet;","changes like this, just strangle guava usages to be replaced by DelayLimiter into one place",`zipkin2` doesn't have any other changes in this file.
+981,"@@ -27,8 +27,8 @@ const Widget = ( {
+ 	className,
+ 	slug,
+ 	noPadding,
+-	header: Header,
+-	footer: Footer,
++	Header,
++	Footer,
+ } ) => {
+ 	return (
+ 		<div","PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`.",Why did we remove the type here?
+982,"@@ -221,7 +221,7 @@ int get_ctest_gpu(const char* local_rank_str) {
+   }
+
+   auto const* comma = std::strchr(resource_str, ',');
+-  if (!comma || strncmp(resource_str, ""id:"", 3)) {
++  if (!comma || strncmp(resource_str, ""id:"", 3) != 0) {
+     std::ostringstream ss;
+     ss << ""Error: invalid value of "" << ctest_resource_group_id_name << "": '""
+        << resource_str << ""'. Raised by Kokkos::Impl::get_ctest_gpu()."";",maybe extra paren around `strncmp(...) != 0`,I'm not sure I follow this change. What is the semanti
+983,"@@ -510,6 +510,8 @@ public class Windows implements TrayListener, TopBarWidget.Delegate, TitleBarWid
+
+         TelemetryWrapper.resetOpenedWindowsCount(mRegularWindows.size(), false);
+         TelemetryWrapper.resetOpenedWindowsCount(mPrivateWindows.size(), true);
++        GleanMetricsService.resetOpenedWindowsCount(mRegularWindows.size(), false);
++        GleanMetricsService.resetOpenedWindowsCount(mPrivateWindows.size(), true);
+     }
+
+     public boolean isPaused() {",We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed,isn't mRegularWindows not getting resetOpenedWindowsCo
+984,"@@ -31,7 +31,7 @@ import java.util.function.Function;
+
+ import com.google.common.annotations.VisibleForTesting;
+
+-public class BftForksSchedule<C extends BftConfigOptions> {
++public class BftForksSchedule<C> {
+
+   private final NavigableSet<ForkSpec<C>> forks =
+       new TreeSet<>(",Rename to ForksSchedule? Maybe in separate PR.,Why not `ForkSpec<C extends BftConfigOptions`?
+985,"@@ -1,11 +1,12 @@
+-import pytest
+ import time
+ from unittest import mock
+
++import pytest
++
+ from pyramid import testing
+
+-from kinto.core.storage import exceptions
+ from kinto.core.cache import heartbeat
++from kinto.core.storage import exceptions
+
+
+ class CacheTest:",Why a blank line here?,Why did you change the import order?
+986,"@@ -14,6 +14,10 @@ class Subscription < ActiveRecord::Base
+     notifier.send_notifications
+   end
+
++  def active?
++    deactivated_on.nil?
++  end
++
+   private
+
+   def self.subscriber_emails","I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality.",What do you think about adding a new method `d
+987,"@@ -36,6 +36,10 @@ public class EnvironmentVariableDefaultProvider implements IDefaultValueProvider
+
+   @Override
+   public String defaultValue(final ArgSpec argSpec) {
++    if (!argSpec.isOption()) {
++      return null; // skip default for positional params
++    }
++
+     return envVarNames((OptionSpec) argSpec)
+         .map(environment::get)
+         .filter(Objects::nonNull)",What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?,Shouldn't this be `argSpec.isOption() ? argSpe
+988,"@@ -1415,7 +1415,13 @@ void ProtocolGame::sendBasicData()
+ 		msg.addByte(0);
+ 		msg.add<uint32_t>(0);
+ 	}
++
+ 	msg.addByte(player->getVocation()->getClientId());
++
++	if (version >= 1100) {
++		msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00); // prey data
++	}
++
+ 	msg.add<uint16_t>(0xFF); // number of known spells
+ 	for (uint8_t spellId = 0x00; spellId < 0xFF; spellId++) {
+ 		msg.addByte(spellId);",Why would you add those if client version min is set to 1100?,why not `player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00`?
+989,"@@ -7,12 +7,13 @@
+ package snapshotsync
+
+ import (
++	reflect ""reflect""
++	sync ""sync""
++
+ 	proto ""github.com/golang/protobuf/proto""
+ 	protoreflect ""google.golang.org/protobuf/reflect/protoreflect""
+ 	protoimpl ""google.golang.org/protobuf/runtime/protoimpl""
+ 	emptypb ""google.golang.org/protobuf/types/known/emptypb""
+-	reflect ""reflect""
+-	sync ""sync""
+ )
+
+ const (","You can delete this, it will now need to live in `gointerfaces` package",These changes don't seem necessary to me.
+990,"@@ -3,7 +3,7 @@
+   <%= render 'previous_next_doc' %>
+
+
+-<% @page_title = t('blacklight.search.show.title', :document_title => document_show_html_title, :application_name => application_name) -%>
++<% @page_title = t('blacklight.search.show.title', :document_title => document_show_html_title, :application_name => application_name).html_safe -%>
+ <% content_for(:head) { render_link_rel_alternates } -%>
+ <%# this should be in a partial -%>
+ ","Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work.",Use the new Ruby 1.9 hash syntax.
+991,"@@ -1435,6 +1435,8 @@ public class MessageList extends K9Activity implements MessageListFragmentListen
+     public void displayMessageSubject(String subject) {
+         if (mDisplayMode == DisplayMode.MESSAGE_VIEW) {
+             mActionBarSubject.setText(subject);
++        } else {
++            mActionBarSubject.showSubjectInMessageHeader();
+         }
+     }
+ ",What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?,We should either remove the else statement or add a new method to displa
+992,"@@ -65,7 +65,7 @@ func NewProvider(opts ...ProviderOption) (*Provider, error) {
+ 		namedTracer: make(map[string]*tracer),
+ 	}
+ 	tp.config.Store(&Config{
+-		DefaultSampler:       ProbabilitySampler(defaultSamplingProbability),
++		DefaultSampler:       AlwaysSample(),
+ 		IDGenerator:          defIDGenerator(),
+ 		MaxAttributesPerSpan: DefaultMaxAttributesPerSpan,
+ 		MaxEventsPerSpan:     DefaultMaxEventsPerSpan,",Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change.,Why are we not using `DefaultSampler` here anymore?
+993,"@@ -63,9 +63,9 @@ func (s *svc) UpdateDeployment(ctx context.Context, clientset, cluster, namespac
+ 	}
+
+ 	newDeployment := oldDeployment.DeepCopy()
+-	mergeLabelsAndAnnotations(newDeployment, fields)
++	mergeDeploymentLabelsAndAnnotations(newDeployment, fields)
+
+-	patchBytes, err := generateDeploymentStrategicPatch(oldDeployment, newDeployment)
++	patchBytes, err := GenerateStrategicPatch(oldDeployment, newDeployment, appsv1.Deployment{})
+ 	if err != nil {
+ 		return err
+ 	}",can you delete the `generateDeploymentStrategicPatch` function as well?,@deads2k why is this the only place where we need t
+994,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...,This should not be part of this PR
+995,"@@ -50,6 +50,10 @@ StatusOr<OptRule::TransformResult> LimitPushDownRule::transform(
+   const auto proj = static_cast<const Project *>(projGroupNode->node());
+   const auto gn = static_cast<const GetNeighbors *>(gnGroupNode->node());
+
++  DCHECK(graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()));
++  if (!graph::ExpressionUtils::isEvaluableExpr(limit->countExpr())) {
++    return TransformResult::noTransform();
++  }
+   int64_t limitRows = limit->offset() + limit->count();
+   if (gn->limit() >= 0 && limitRows >= gn->limit()) {
+     return TransformResult::noTransform();",Don't use DCHECK to debug your code if it's the regular branch you need to handle.,Why do you need this check? The same check is done
+996,"@@ -46,11 +46,6 @@ public interface AntlrNode extends Node {
+         throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");
+     }
+
+-    @Override
+-    default String getImage() {
+-        throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");
+-    }
+-
+     @Override
+     default void setImage(final String image) {
+         throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");",You should return null here instead. Null is an acceptable default value for the image attribute.,It looks like all the `setImage` methods in this class are unused. Can we remove them?
+997,"@@ -246,9 +246,14 @@ export function useErrorBoundary(cb) {
+ function flushAfterPaintEffects() {
+ 	afterPaintEffects.some(component => {
+ 		if (component._parentDom) {
+-			component.__hooks._pendingEffects.forEach(invokeCleanup);
+-			component.__hooks._pendingEffects.forEach(invokeEffect);
+-			component.__hooks._pendingEffects = [];
++			try {
++				component.__hooks._pendingEffects.forEach(invokeCleanup);
++				component.__hooks._pendingEffects.forEach(invokeEffect);
++				component.__hooks._pendingEffects = [];
++			} catch (e) {
++				options._catchError(e, component._vnode);
++				return true;
++			}
+ 		}
+ 	});
+ 	afterPaintEffects = [];",react bails as well?,I don't think we need to catch here since we are already catching errors in `_catchErr
+998,"@@ -7,7 +7,6 @@ namespace Shopsys\FrameworkBundle\Model\Security;
+ class Roles
+ {
+     public const ROLE_ADMIN = 'ROLE_ADMIN';
+-    public const ROLE_ADMIN_AS_CUSTOMER = 'ROLE_ADMIN_AS_CUSTOMER';
+     public const ROLE_LOGGED_CUSTOMER = 'ROLE_LOGGED_CUSTOMER';
+     public const ROLE_SUPER_ADMIN = 'ROLE_SUPER_ADMIN';
+ ",Can you please tell me why you did this?,"Doesn't make sense to remove this role from SCC, as it's no longer used?"
+999,"@@ -168,9 +168,12 @@ module.exports = class Webcam extends Plugin {
+       this.opts.modes.indexOf('video-only') !== -1 ||
+       this.opts.modes.indexOf('picture') !== -1
+
++    const videoConstraints = this.opts.videoConstraints ?? {}
++    videoConstraints.facingMode = this.opts.facingMode
++
+     return {
+       audio: acceptsAudio,
+-      video: acceptsVideo ? { facingMode: this.opts.facingMode } : false
++      video: acceptsVideo ? videoConstraints : false
+     }
+   }
+ ",Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set,Why not use the facing mode directly in the videoConstraints?
+1000,"@@ -1,7 +1,10 @@
+ class Video < ActiveRecord::Base
++  extend FriendlyId
++
+   belongs_to :watchable, polymorphic: true
+
+   validates :published_on, presence: true
++  validates :slug, presence: true, uniqueness: true
+   validates :title, presence: true
+   validates :watchable_id, presence: true
+   validates :watchable_type, presence: true",There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?,why is this required?
+1001,"@@ -79,7 +79,10 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(Buil
+ 	// keep functions interoperable, pass int64 types as pointers to
+ 	// stack-allocated values.
+ 	// Use -wasm-abi=generic to disable this behaviour.
+-	if config.Options.WasmAbi == ""js"" && strings.HasPrefix(config.Triple(), ""wasm"") {
++	if config.Options.WasmAbi != """" {
++		config.Target.WasmAbi = config.Options.WasmAbi
++	}
++	if config.Target.WasmAbi == ""js"" {
+ 		err := transform.ExternalInt64AsPtr(mod)
+ 		if err != nil {
+ 			return err","Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc).",`config.Options.WasmA
+1002,"@@ -159,6 +159,14 @@ func newTestEnv(inboundOptions []InboundOption, outboundOptions []OutboundOption
+ 	testRouter := newTestRouter(procedures)
+
+ 	t := NewTransport()
++	if err := t.Start(); err != nil {
++		return nil, err
++	}
++	defer func() {
++		if err != nil {
++			err = multierr.Append(err, t.Stop())
++		}
++	}()
+
+ 	listener, err := net.Listen(""tcp"", ""127.0.0.1:0"")
+ 	if err != nil {",The nil check is not necessary for these. Append checks both sides for nil.,It seems like this sh
+1003,"@@ -62,6 +62,7 @@ func main() {
+ 			trace.WithAttributes(attrs...),
+ 			trace.ChildOf(spanCtx),
+ 		)
++		span.SetAttributes(entries...)
+ 		defer span.End()
+
+ 		span.AddEvent(ctx, ""handling this..."")","Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes.",I'm not sure if this
+1004,"@@ -60,5 +60,12 @@ func (t *topologyAPI) GetTopology(ctx context.Context, req *topologyv1.GetTopolo
+ }
+
+ func (t *topologyAPI) SearchTopology(ctx context.Context, req *topologyv1.SearchTopologyRequest) (*topologyv1.SearchTopologyResponse, error) {
+-	return nil, errors.New(""not implemented"")
++	resources, err := t.topology.SearchTopology(ctx, req)
++	if err != nil {
++		return nil, err
++	}
++
++	return &topologyv1.SearchTopologyResponse{
++		Resources: resources,
++	}, nil
+ }",nit: rename this in proto and update impl to `Search` to avoid stutter,It looks like all the existing code in topology_test.go used errors as well. Do you think it's safe to switch back to this error?
+1005,"@@ -78,7 +78,8 @@ class SliderController extends AdminBaseController
+             ->from(SliderItem::class, 's')
+             ->where('s.domainId = :selectedDomainId')
+             ->setParameter('selectedDomainId', $this->adminDomainTabsFacade->getSelectedDomainId())
+-            ->orderBy('s.position');
++            ->orderBy('s.position')
++            ->addOrderBy('s.id');
+         $dataSource = new QueryBuilderDataSource($queryBuilder, 's.id');
+
+         $grid = $this->gridFactory->create('sliderItemList', $dataSource);",is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend),Shouldn't we order by `s.position` first?
+1006,"@@ -18,8 +18,10 @@ import (
+ )
+
+ var (
+-	claimFromRewardingFundBaseGas    = uint64(10000)
+-	claimFromRewardingFundGasPerByte = uint64(100)
++	// ClaimFromRewardingFundBaseGas represents the base intrinsic gas for claimFromRewardingFund
++	ClaimFromRewardingFundBaseGas = uint64(10000)
++	// ClaimFromRewardingFundGasPerByte represents the claimFromRewardingFund payload gas per uint
++	ClaimFromRewardingFundGasPerByte = uint64(100)
+ )
+
+ // ClaimFromRewardingFund is the action to claim reward from the rewarding fund",`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`),Why not make this a const? Then you don't need to define it everywhere.
+1007,"@@ -89,9 +89,11 @@ namespace RDKit {
+   }
+   PyObject *GetSubstructMatch(const ROMol &mol, const ROMol &query,bool useChirality=false,
+                             bool useQueryQueryMatches=false){
+-    NOGIL gil;
+     MatchVectType matches;
+-    SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);
++    {
++      NOGIL gil;
++      SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);
++    }
+     return convertMatches(matches);
+   }
+ ",How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?,This function looks like a duplicate of `SubstructMatch`.
+1008,"@@ -29,6 +29,11 @@ type chainState interface {
+ 	LatestState(ctx context.Context) (state.Tree, error)
+ }
+
++// BlockTimer defines a interface to a struct that can give the current block height.
++type BlockTimer interface {
++	BlockHeight() (uint64, error)
++}
++
+ // PublishFunc is a function the Sender calls to publish a message to the network.
+ type PublishFunc func(topic string, data []byte) error
+ ",blockheighter would be more clear,why is this not just a `*state.Timer`?
+1009,"@@ -949,5 +949,15 @@ void OptimizerUtils::copyIndexScanData(const nebula::graph::IndexScan* from,
+   to->setFilter(from->filter() == nullptr ? nullptr : from->filter()->clone());
+ }
+
++Status OptimizerUtils::compareAndSwapBound(std::pair<Value, bool>& a, std::pair<Value, bool>& b) {
++  if (a.first > b.first) {
++    std::swap(a, b);
++  } else if (a.first < b.first) {  // do nothing
++  } else if (a.second > b.second) {
++    std::swap(a, b);
++  }
++  return Status::OK();
++}
++
+ }  // namespace graph
+ }  // namespace nebula",This is so weird as a utility function.,what is the purpose of the second `std
+1010,"@@ -58,7 +58,8 @@ func TestPlanQuery(t *testing.T) {
+ 		return m
+ 	}
+
+-	cmpopt := cmp.AllowUnexported(dynamodb.ScanInput{}, dynamodb.QueryInput{}, dynamodb.AttributeValue{})
++	// Ignores the ConsistentRead field from both QueryInput and ScanInput.
++	cmpopt := cmp.FilterPath(func(p cmp.Path) bool { return p.Last().String() == "".ConsistentRead"" }, cmp.Ignore())
+
+ 	for _, test := range []struct {
+ 		desc string",Why? What would happen if you did not?,Ignores the ConsistentRead field from
+1011,"@@ -752,7 +752,9 @@ public class SmartStore  {
+         String[] pathElements = path.split(""[.]"");
+         Object o = soup;
+         for (String pathElement : pathElements) {
+-            o = ((JSONObject) o).opt(pathElement);
++        	if (o != null) {
++                o = ((JSONObject) o).opt(pathElement);
++        	}
+         }
+         return o;
+     }",Unrelated bugfix for NPE.,`o == null ? null : o` would be better
+1012,"@@ -387,7 +387,7 @@ class AdminController extends Controller
+             throw new \Exception(sprintf('The ""%s"" property is not a switchable toggle.', $propertyName));
+         }
+
+-        if (!$propertyMetadata['canBeSet']) {
++        if (!$propertyMetadata['isWritable']) {
+             throw new \Exception(sprintf('It\'s not possible to toggle the value of the ""%s"" boolean property of the ""%s"" entity.', $propertyName, $this->entity['name']));
+         }
+ ",What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?,This exception message needs to be updated as well
+1013,"@@ -524,6 +524,17 @@
+                 dataType: ""json""
+             });
+         },
++        fetchSegmentMap: function() {
++            return CV.$.ajax({
++                type: ""GET"",
++                url: countlyCommon.API_PARTS.data.r + '/data-manager/event-segment',
++                data: {
++                    ""app_id"": countlyCommon.ACTIVE_APP_ID,
++                    ""preventRequestAbort"": true,
++                },
++                dataType: ""json""
++            });
++        },
+         fetchRefreshSelectedEventsData: function(context) {
+             return CV.$.ajax({
+                 type: ""GET"",","This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?",please add jsdoc for this new ajax request
+1014,"@@ -219,7 +219,7 @@ func (o *deploySvcOpts) generateWorkerServiceRecommendedActions() {
+ 	retrieveEnvVarCode := ""const eventsQueueURI = process.env.COPILOT_QUEUE_URI""
+ 	actionRetrieveEnvVar := fmt.Sprintf(
+ 		`Update %s's code to leverage the injected environment variable ""COPILOT_QUEUE_URI"".
+-In JavaScript you can write %s.`,
++  In JavaScript you can write %s.`,
+ 		o.name,
+ 		color.HighlightCode(retrieveEnvVarCode),
+ 	)",Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?,Nit: `In JavaScript` should be `In JavaScript`
+1015,"@@ -3277,7 +3277,7 @@ bool CoreChecks::PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool
+                                                     VkQueryResultFlags flags) const {
+     if (disabled.query_validation) return false;
+     bool skip = false;
+-    skip |= ValidateQueryPoolStride(""VUID-vkGetQueryPoolResults-flags-00814"", ""VUID-vkGetQueryPoolResults-flags-00815"", stride,
++    skip |= ValidateQueryPoolStride(""VUID-vkGetQueryPoolResults-flags-02827"", ""VUID-vkGetQueryPoolResults-flags-00815"", stride,
+                                     ""dataSize"", dataSize, flags);
+     skip |= ValidateGetQueryPoolResultsFlags(queryPool, flags);
+     skip |= ValidateGetQueryPoolResultsQueries(queryPool, firstQuery, queryCount);","The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation.",Just to confirm that this is intentional?
+1016,"@@ -74,11 +74,12 @@ namespace Nethermind.Store
+             db[key.ToBigEndianByteArrayWithoutLeadingZeros()] = value;
+         }
+
+-        public static byte[] Get(this IDb db, long key)
+-        {
+-            return db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
+-        }
+-
++        public static byte[] Get(this IDb db, long key) => db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
++
++        public static byte[] ToDbKey(this long key) => key.ToBigEndianByteArrayWithoutLeadingZeros();
++
++        public static byte[] ToDbKey(this Keccak key) => key.Bytes;
++
+         public static void Delete(this IDb db, long key)
+         {
+             db.Remove(key.ToBigEndianByteArrayWithoutLeadingZeros());",Iguess you should use ToDbKey here,Should this be `ToDbKey(this long key)`?
+1017,"@@ -179,16 +179,7 @@ func (x *blockIndexer) DeleteTipBlock(blk *block.Block) error {
+ func (x *blockIndexer) Height() (uint64, error) {
+ 	x.mutex.RLock()
+ 	defer x.mutex.RUnlock()
+-
+-	index, err := db.GetCountingIndex(x.kvStore, totalBlocksBucket)
+-	if err != nil {
+-		if errors.Cause(err) == db.ErrBucketNotExist || errors.Cause(err) == db.ErrNotExist {
+-			// counting index does not exist yet
+-			return 0, nil
+-		}
+-		return 0, err
+-	}
+-	return index.Size() - 1, nil
++	return x.tbk.Size() - 1, nil
+ }
+
+ // GetBlockHash returns the block hash by height","x.tbk is the ""index"" below, and is done in Start()",Did the code not work for the case where
+1018,"@@ -8,6 +8,7 @@ namespace Datadog.Trace.Util
+     /// </summary>
+     internal static class DomainMetadata
+     {
++        private const string IsAppInsightKey = ""DD_IsAppInsight"";
+         private const string UnknownName = ""unknown"";
+         private static Process _currentProcess;
+         private static bool _processDataPoisoned;","Do we already have a convention for this? If not, would we consider ""DataDog.IsAppInsights"". And then use ""DataDog."" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)","Thinking about modularization, would it "
+1019,"@@ -95,6 +95,16 @@ static int cb_firehose_init(struct flb_output_instance *ins,
+         ctx->time_key_format = DEFAULT_TIME_KEY_FORMAT;
+     }
+
++    tmp = flb_output_get_property(""log_key"", ins);
++    if (tmp) {
++        ctx->log_key = tmp;
++    }
++
++    if (ctx->log_key && ctx->time_key) {
++        flb_plg_error(ctx->ins, ""'time_key' and 'log_key' can not be used together"");
++        goto error;
++    }
++
+     tmp = flb_output_get_property(""endpoint"", ins);
+     if (tmp) {
+         ctx->custom_endpoint = FLB_TRUE;",this assignment is not necessary if the offsetof() is used in the configmap,"can we also say ""can not be used togethe"
+1020,"@@ -268,11 +268,6 @@ func (p *Protocol) claimFromAccount(sm protocol.StateManager, addr address.Addre
+ 	balance := big.NewInt(0).Sub(acc.balance, amount)
+ 	if balance.Cmp(big.NewInt(0)) < 0 {
+ 		return errors.New(""no enough available balance"")
+-	} else if balance.Cmp(big.NewInt(0)) == 0 {
+-		// If the account balance is cleared, delete if from the store
+-		if err := p.deleteState(sm, accKey); err != nil {
+-			return err
+-		}
+ 	} else {
+ 		acc.balance = balance
+ 		if err := p.putState(sm, accKey, &acc); err != nil {",I'd rather leave a TODO here at least.,Why remove these?
+1021,"@@ -115,10 +115,10 @@ class BatchViewTest(BaseWebTest, unittest.TestCase):
+         request = {""path"": ""/mushrooms/""}  # trailing slash
+         body = {""requests"": [request]}
+         resp = self.app.post_json(""/batch"", body, headers=self.headers)
+-        collection = resp.json[""responses""][0]
+-        self.assertEqual(collection[""status""], 200)
+-        self.assertEqual(collection[""path""], ""/v0/mushrooms"")
+-        self.assertEqual(collection[""body""], {""data"": []})
++        objects = resp.json[""responses""][0]
++        self.assertEqual(objects[""status""], 200)
++        self.assertEqual(objects[""path""], ""/v0/mushrooms"")
++        self.assertEqual(objects[""body""], {""data"": []})
+
+     def test_body_is_transmitted_during_redirect(self):
+         request = {",Shouldn't this be `resource`?,`models` is a sli
+1022,"@@ -37,13 +37,12 @@ namespace {
+ /** CPU implementation of evaluation layer forward prop. */
+ void fp_cpu(lbann_comm& comm,
+             const AbsDistMat& input,
+-            DataType& value,
+-            Al::request& req) {
++            DataType& value) {
+   const auto& local_input = input.LockedMatrix();
+   const auto& local_height = local_input.Height();
+   const auto& local_width = local_input.Width();
+   const auto& mini_batch_size = input.Width();
+-  value = DataType(0);
++  value = 0;
+ #pragma omp parallel for reduction(+:value) collapse(2)
+   for (El::Int col = 0; col < local_width; ++col) {
+     for (El::Int row = 0; row < local_height; ++row) {",Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?,Why do you want t
+1023,"@@ -24,7 +24,7 @@ module Travis
+           sh.export 'TRAVIS_RUBY_VERSION', config[:rvm], echo: false if rvm?
+         end
+
+-        def setup
++        def configure
+           super
+           setup_rvm if rvm?
+         end",Do we need to change occurences where `setup` was called before?,I think you can r
+1024,"@@ -61,6 +61,16 @@ func (a *API) resolveReferences() {
+ 			o.ErrorRefs[i].Shape.IsError = true
+ 		}
+ 	}
++
++	// TODO put this somewhere better
++	for _, s := range a.Shapes {
++		switch s.Type {
++		case ""list"":
++			s.MemberRef.Shape.UsedInList = true
++		case ""map"":
++			s.ValueRef.Shape.UsedInMap = true
++		}
++	}
+ }
+
+ // A referenceResolver provides a way to resolve shape references to",Is this TODO still valid? Or are we going to put this somewhere else later?,"I wonder if we should put it somewhere else, perhaps in the future?"
+1025,"@@ -15,12 +15,17 @@ def generate_data(test_user_id, user_name, from_ts, num_records):
+     test_data = []
+     artist_msid = str(uuid.uuid4())
+
+-    for i in range(num_records):
++    if (from_ts == None):  #check for playing now listens
++        timestamp = None
++    else:
+         from_ts += 1   # Add one second
++        timestamp = datetime.utcfromtimestamp(from_ts)
++
++    for i in range(num_records):
+         item = Listen(
+             user_name=user_name,
+             user_id=test_user_id,
+-            timestamp=datetime.utcfromtimestamp(from_ts),
++            timestamp= timestamp,
+             artist_msid=artist_msid,
+             recording_msid=str(uuid.uuid4()),
+             data={",We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`,check for playing now listens
+1026,"@@ -460,9 +460,13 @@ void tm_process_req_requestregioninfo(CTmTxMessage * pp_msg)
+        TM_Txid_legacy lv_transid;
+    } u;
+
+-   char tname[2000], ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
++   char tname[2000];
++   tname[299] = '\0';
++/*
++   char ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
+    tname[299] = '\0', ername[49] = '\0', rname[99] = '\0', offline[19] = '\0';
+    regid[199]= '\0', hostname[199]='\0', port[99]='\0';
++*/
+
+    TMTrace(2, (""tm_process_req_requestregioninfo ENTRY.\n""));
+    HashMapArray* map = HbaseTM_process_request_regions_info();",Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before.,(style) line over 80 characters
+1027,"@@ -28,3 +28,9 @@ type PeerAdder interface {
+ type ClosestPeerer interface {
+ 	ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
+ }
++
++// ScoreFunc is implemented by components that need to score peers in a different way than XOR distance.
++type ScoreFunc func(peer swarm.Address) (score float32)
++
++// EachPeerFunc is a callback that is called with a peer and its PO
++type EachPeerFunc func(swarm.Address, uint8) (stop, jumpToNext bool, err error)",ScoreFunc is not used in this PR. Maybe to add it later when needed?,Let's move this interface to `src/server/p2p/server/p2p/types.go`
+1028,"@@ -171,9 +171,9 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
+ 		http.SetCookie(w, cookie)
+ 	}
+
+-	if redirects := md.HeaderMD.Get(""Location""); len(redirects) > 0 {
+-		w.Header().Set(""Location"", redirects[0])
+-
++	// Redirect if it's the browser (non-XHR).
++	redirects := md.HeaderMD.Get(""Location"")
++	if len(redirects) > 0 && isBrowser(copyRequestHeadersFromResponseWriter(w)) {
+ 		code := http.StatusFound
+ 		if st := md.HeaderMD.Get(""Location-Status""); len(st) > 0 {
+ 			headerCodeOverride, err := strconv.Atoi(st[0])",super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`,Should this also check for XSS?
+1029,"@@ -4,12 +4,8 @@
+  *  (found in the LICENSE.Apache file in the root directory)
+  */
+ #include <gtest/gtest.h>
+-#include <cstdlib>
+-#include <thread>
+-#include <mutex>
+-#include <atomic>
+-#include ""common/concurrent/Barrier.h""
+-#include ""common/thread/GenericThreadPool.h""
++#include ""concurrent/Barrier.h""
++#include ""thread/GenericThreadPool.h""
+
+ namespace vesoft {
+ namespace concurrent {","Need to include ""common/base/Base.h"" in front of this line",Do we still need the `atomic` i
+1030,"@@ -1,6 +1,5 @@
+ import getRole from '../aria/get-role';
+-import matches from '../matches/matches';
+-import nativeElementType from './native-element-type';
++import getElementSpec from '../standards/get-element-spec';
+ import nativeTextMethods from './native-text-methods';
+
+ /**",Changes in this file should go into a separate PR.,Can we do this in a separate PR
+1031,"@@ -243,10 +243,15 @@ public class PhpSurfaceNamer extends SurfaceNamer {
+         if (token.equals(InitFieldConfig.RANDOM_TOKEN)) {
+           stringParts.add(""time()"");
+         } else {
+-          stringParts.add(""\"""" + token + ""\"""");
++          stringParts.add(quoted(token));
+         }
+       }
+     }
+     return Joiner.on("". "").join(stringParts);
+   }
++
++  @Override
++  public String quoted(String text) {
++    return ""\'"" + text + ""\'"";
++  }
+ }",Please ensure that this will not start putting single quotes where double quotes are expected.,Why did you need to make this c
+1032,"@@ -68,7 +68,7 @@ type Manager struct {
+ }
+
+ // ProvideConfig provides the config for consumer
+-func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
++func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int, int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
+ 	key := &wg.ConsumerConfig{}
+ 	err := json.Unmarshal(publicKey, key)
+ 	if err != nil {","`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too.",error strings should not be capitalized or end with punctuation or a newline
+1033,"@@ -76,9 +76,8 @@ func Search(ctx *context.APIContext) {
+ 	})
+ }
+
+-// https://github.com/gogits/go-gogs-client/wiki/Repositories#list-your-repositories
+-func ListMyRepos(ctx *context.APIContext) {
+-	ownRepos, err := models.GetUserRepositories(ctx.User.ID, true, 1, ctx.User.NumRepos)
++func listUserRepos(ctx *context.APIContext, u *models.User) {
++	ownRepos, err := models.GetUserRepositories(u.ID, true, 1, u.NumRepos)
+ 	if err != nil {
+ 		ctx.Error(500, ""GetRepositories"", err)
+ 		return","This does not look right, you're listing all private repositories..",  not sure if we even need to expose this function anymore. `ListMyRepos` wa
+1034,"@@ -20,4 +20,6 @@ C2::Application.routes.draw do
+   get 'bookmarklet', to: redirect('bookmarklet.html')
+   get ""/498"", :to => ""errors#token_authentication_error""
+
++  match ""*path"" => ""application#xss_options_request"", :via => :options
++
+ end",An OPTIONS request should respond from _any_ path? Seems weird to me...,Use the new Ruby 1.9 hash syntax.
+1035,"@@ -40,6 +40,8 @@ class MediaAdmin extends Admin
+             ->add('category', null, array(
+                 'show_filter' => false,
+             ))
++            ->add('width')
++            ->add('height')
+         ;
+
+         $providers = array();",you need to add the content type,`add_submenu_page()` adds a lot more items. Why not just add width and heigh
+1036,"@@ -12,6 +12,14 @@ namespace Datadog.Trace
+     {
+         private static Task _traceAgentMonitor;
+         private static Task _dogStatsDMonitor;
++        private static Process _traceAgentProcess;
++        private static Process _dogStatsProcess;
++
++        public static void StopSubProcesses()
++        {
++            SafelyKillProcess(_traceAgentProcess, ""Failed to halt the sub-process trace agent"");
++            SafelyKillProcess(_dogStatsProcess, ""Failed to halt the sub-process stats agent"");
++        }
+
+         public static void StartStandaloneAgentProcessesWhenConfigured()
+         {",Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally.,Should we add the `SafelyKillProcess` to the log message?
+1037,"@@ -61,8 +61,8 @@ callee_info_t default_callee_info;
+ int
+ get_clean_call_switch_stack_size(void)
+ {
+-#ifdef AARCH64
+-    /* Stack size needs to be 16 byte aligned on ARM */
++#if defined(AARCH64) || defined(X64)
++    /* Stack size needs to be 16 byte aligned on ARM and x64. */
+     return ALIGN_FORWARD(sizeof(priv_mcontext_t), 16);
+ #else
+     return sizeof(priv_mcontext_t);","This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined.","should this be `ALIGN_FORWARD(sizeof(priv_mcontext_t), 16"
+1038,"@@ -271,7 +271,8 @@ final class MySQLSpanStore implements SpanStore {
+           .selectDistinct(ZIPKIN_SPANS.NAME)
+           .from(ZIPKIN_SPANS)
+           .join(ZIPKIN_ANNOTATIONS)
+-          .on(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
++          .on(ZIPKIN_SPANS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH))
++          .and(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
+           .and(ZIPKIN_SPANS.ID.eq(ZIPKIN_ANNOTATIONS.SPAN_ID))
+           .where(ZIPKIN_ANNOTATIONS.ENDPOINT_SERVICE_NAME.eq(serviceName))
+           .orderBy(ZIPKIN_SPANS.NAME)",guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?,probably `ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH` is better tha
+1039,"@@ -53,6 +53,7 @@ module Beaker
+     class_option :'xml-time-order', :type => :boolean, :group => 'Beaker run'
+     class_option :'debug-errors', :type => :boolean, :group => 'Beaker run'
+     class_option :'exec_manual_tests', :type => :boolean, :group => 'Beaker run'
++    class_option :'test-tag-exclude', :type => :string, :group => 'Beaker run'
+
+     # The following are listed as deprecated in beaker --help, but needed now for
+     # feature parity for beaker 3.x.",Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function.,Use the new Ruby 1.9 hash syntax.
+1040,"@@ -143,7 +143,10 @@ namespace OpenTelemetry.Context.Propagation
+                         break;
+                     }
+
+-                    if (NameValueHeaderValue.TryParse(pair, out NameValueHeaderValue baggageItem))
++                    var decodedPair = WebUtility.UrlDecode(pair);
++                    var escapedPair = string.Join(""="", decodedPair.Split('=').Select(Uri.EscapeDataString));
++
++                    if (NameValueHeaderValue.TryParse(escapedPair, out NameValueHeaderValue baggageItem))
+                     {
+                         if (string.IsNullOrEmpty(baggageItem.Name) || string.IsNullOrEmpty(baggageItem.Value))
+                         {","This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?",Doesn't `Uri.EscapeDataString` already do this?
+1041,"@@ -55,10 +55,17 @@ public class PvPUtil
+ 	public static boolean isAttackable(Client client, Player player)
+ 	{
+ 		int wildernessLevel = 0;
+-		if (!(client.getVar(Varbits.IN_WILDERNESS) == 1 || WorldType.isPvpWorld(client.getWorldType())))
++		if (!(client.getVar(Varbits.IN_WILDERNESS) == 1
++				|| WorldType.isPvpWorld(client.getWorldType())
++				|| client.getWorldType().contains(WorldType.DEADMAN)
++		))
+ 		{
+ 			return false;
+ 		}
++		if (client.getWorldType().contains(WorldType.DEADMAN))
++		{
++			return true;
++		}
+ 		if (WorldType.isPvpWorld(client.getWorldType()))
+ 		{
+ 			if (client.getVar(Varbits.IN_WILDERNESS) != 1)",This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls.,Replace this with client.getWorldType().contain
+1042,"@@ -600,11 +600,11 @@ class SABLRetinaHead(BaseDenseHead, BBoxTestMixin):
+                 bbox_cls_pred.contiguous(),
+                 bbox_reg_pred.contiguous()
+             ]
+-            bboxes, confids = self.bbox_coder.decode(
++            bboxes, confidences = self.bbox_coder.decode(
+                 anchors.contiguous(), bbox_preds, max_shape=img_shape)
+             mlvl_bboxes.append(bboxes)
+             mlvl_scores.append(scores)
+-            mlvl_confids.append(confids)
++            mlvl_confids.append(confidences)
+         mlvl_bboxes = torch.cat(mlvl_bboxes)
+         if rescale:
+             mlvl_bboxes /= mlvl_bboxes.new_tensor(scale_factor)",do we also need to change `mlvl_confid` -> `mlvl_confidences`>,Is there a reason why `bboxes` and `confids` ar
+1043,"@@ -125,7 +125,8 @@ type Config struct {
+ 	MetadataAddr string `config:""hostname;127.0.0.1;die-on-fail""`
+ 	MetadataPort int    `config:""int(0,65535);8775;die-on-fail""`
+
+-	InterfacePrefix string `config:""iface-list;cali;non-zero,die-on-fail""`
++	InterfacePrefix  string `config:""iface-list;cali;non-zero,die-on-fail""`
++	InterfaceExclude string `config:""iface-list;kube-ipvs0""`
+
+ 	ChainInsertMode             string `config:""oneof(insert,append);insert;non-zero,die-on-fail""`
+ 	DefaultEndpointToHostAction string `config:""oneof(DROP,RETURN,ACCEPT);DROP;non-zero,die-on-fail""`","I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?",I think this should be something like `die-on-f
+1044,"@@ -180,7 +180,7 @@ def transform_path(path):
+     path = utils.expand_windows_drive(path)
+     # Drive dependent working directories are not supported, e.g.
+     # E:filename is invalid
+-    if re.match(r'[A-Z]:[^\\]', path, re.IGNORECASE):
++    if re.fullmatch(r'[A-Z]:[^\\]', path, re.IGNORECASE):
+         return None
+     # Paths like COM1, ...
+     # See https://github.com/qutebrowser/qutebrowser/issues/82","This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`.","This regex was incorrect and so was the usage of `re.match`. If you want to match against a particular regular expression, you can use `re.match`."
+1045,"@@ -108,6 +108,14 @@ func determineResourceHealth(key ResourceKey, obj *unstructured.Unstructured) (s
+ 		return determineClusterRoleHealth(obj)
+ 	case KindClusterRoleBinding:
+ 		return determineClusterRoleBindingHealth(obj)
++	case KindVirtualService:
++		return determineVirtualService(obj)
++	case KindDestinationRule:
++		return determineDestinationRule(obj)
++	case KindGateway:
++		return determineGateway(obj)
++	case KindServiceEntry:
++		return determineServiceEntry(obj)
+ 	default:
+ 		desc = ""Unimplemented or unknown resource""
+ 		return","Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point.",I think this should be `determineDestinationRule(obj)`.
+1046,"@@ -40,7 +40,7 @@ import (
+ // themselves.
+ func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter, mcMetrics Collector) {
+ 	selector := simple.NewWithInexpensiveDistribution()
+-	proc := processor.New(selector, exportmetric.StatelessExportKindSelector())
++	proc := processor.NewFactory(selector, exportmetric.StatelessExportKindSelector())
+ 	cont := controller.New(proc, controller.WithExporter(exp))
+ 	require.NoError(t, cont.Start(ctx))
+ ",Does codecov not run this test? Not sure how else it would not be covered.,"Could we just call `processor.New(selector, exporter.StatelessExportKindSelector())` directly here?"
+1047,"@@ -30,8 +30,9 @@ func main() {
+
+ // rootCmd represents the base command when called without any subcommands
+ var rootCmd = &cobra.Command{
+-	Use:  ""multisend [command]"",
+-	Args: cobra.ExactArgs(1),
++	Use:   ""multisend 'JSON_DATA'"",
++	Short: ""multisend bytecode generator"",
++	Args:  cobra.ExactArgs(1),
+ 	RunE: func(cmd *cobra.Command, args []string) error {
+ 		output, err := multiSend(args)
+ 		if err == nil {",can we add some sample of JSON_DATA format in the usage?,Is there any chance we could have a short option for this?
+1048,"@@ -25,13 +25,13 @@ namespace Datadog.Trace.Logging
+             _logProvider = logProvider;
+         }
+
+-        public void Initialize(IScopeManager scopeManager, string defaultServiceName, string version, string env)
++        public void Initialize(string defaultServiceName, string version, string env)
+         {
+             _versionProperty = version;
+             _environmentProperty = env;
+             _serviceProperty = defaultServiceName;
+-            _traceIdProperty = CreateTracerProperty(scopeManager, t => t.Active?.Span.TraceId.ToString());
+-            _spanIdProperty = CreateTracerProperty(scopeManager, t => t.Active?.Span.SpanId.ToString());
++            _traceIdProperty = CreateTracerProperty(() => Tracer.Instance.DistributedSpanContext?[HttpHeaderNames.TraceId]);
++            _spanIdProperty = CreateTracerProperty(() => Tracer.Instance.DistributedSpanContext?[HttpHeaderNames.ParentId]);
+         }
+
+         public IDisposable Register()",Using `Tracer.Instance` in here is problematic for testing   It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!,Should this be `HttpHeaderNames.TraceId` and `HttpHeaderNames.ParentId`?
+1049,"@@ -22,7 +22,10 @@ import javax.annotation.Nullable;
+  */
+ @AutoValue
+ public abstract class InitFieldConfig {
++  public static final String projectIdVariableName = ""project_id"";
++
+   private static final String randomValueToken = ""$RANDOM"";
++  private static final String projectIdToken = ""$PROJECT_ID"";
+
+   public abstract String fieldPath();
+ ",make all of these `static final` fields UPPER_SNAKE - they are constants.,Does it make sense to put this into some common place? For example `Init
+1050,"@@ -3298,7 +3298,8 @@ int32 Mob::AffectMagicalDamage(int32 damage, uint16 spell_id, const bool iBuffTi
+
+ 	// If this is a DoT, use DoT Shielding...
+ 	if (iBuffTic) {
+-		damage -= (damage * itembonuses.DoTShielding / 100);
++		int total_dotshielding = itembonuses.DoTShielding + itembonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT];
++		damage -= (damage * total_dotshielding / 100);
+
+ 		if (spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT]) {
+ 			slot = spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_BUFFSLOT];","No possible chance for weird overflows here, right?",It would be better if the divisor was `itembonuses.MitigateDotRune[SBInd
+1051,"@@ -39,9 +39,13 @@ import org.apache.lucene.search.Weight;
+  * @lucene.experimental
+  */
+ public abstract class ValueSourceScorer extends Scorer {
++  // Fixed cost for a single iteration of the TwoPhaseIterator instance
++  private static final int DEF_COST = 5;
++
+   protected final FunctionValues values;
+   private final TwoPhaseIterator twoPhaseIterator;
+   private final DocIdSetIterator disi;
++  private float externallyMutableCost;
+
+   protected ValueSourceScorer(Weight weight, LeafReaderContext readerContext, FunctionValues values) {
+     super(weight);",Or we could use a Float object to more clearly show as user-settable via non-null?,Why not `static final int DEF_COST = 5;`?
+1052,"@@ -107,7 +107,7 @@ namespace Nethermind.Merge.Plugin.Handlers.V1
+
+             if (headUpdated && shouldUpdateHead)
+             {
+-                _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header);
++                _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header, finalizedHeader);
+                 _stateProvider.ResetStateTo(newHeadBlock.StateRoot!);
+                 if (_logger.IsInfo) _logger.Info($""Block {forkchoiceState.HeadBlockHash} was set as head"");
+             }",finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero,Why do we need to pass the finalized header here?
+1053,"@@ -48,6 +48,7 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
+
+ 		setupDataDiskStepName := fmt.Sprintf(""setup-data-disk-%v"", dataDiskIndex)
+ 		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v"", dataDiskIndex)
++		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%s-%v"", w.ID(), dataDiskIndex)
+
+ 		setupDataDiskStep := daisy.NewStep(setupDataDiskStepName, w, time.Hour)
+ 		setupDataDiskStep.CreateDisks = &daisy.CreateDisks{","Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them.",why do we name it `disk-importer-scratch-disk-nam
+1054,"@@ -8469,8 +8469,13 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+                 'For argument ""inplace"" expected type bool, received type {}.'
+                 .format(type(inplace).__name__))
+
+-        sdf = self._sdf.filter(expr)
+-        internal = self._internal.copy(sdf=sdf)
++        data_columns = [label[0] for label in self._internal.column_labels]
++        sdf = self._sdf.select(self._internal.index_scols
++                               + [scol.alias(col) for scol, col
++                                  in zip(self._internal.column_scols, data_columns)]) \
++            .filter(expr)
++        internal = self._internal.copy(sdf=sdf,
++                                       column_scols=[scol_for(sdf, col) for col in data_columns])
+
+         if inplace:
+             self._internal = internal","If we support multi-index column later, we need to rename to fit the pandas' requirement.",This should probably use `.alias(col) for scol in
+1055,"@@ -0,0 +1,11 @@
++package aws
++
++// JSONValue is a representation of a grab bag type that will be marshaled
++// into a json string. This type can be used just like any other map.
++//
++//	Example:
++//	values := JSONValue{
++//		""Foo"": ""Bar"",
++//	}
++//	values[""Baz""] = ""Qux""
++type JSONValue map[string]interface{}","I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it.",Nit: Let's change this to `JSONValue is a ...`
+1056,"@@ -724,6 +724,7 @@ void Container::internalAddThing(uint32_t, Thing* thing)
+
+ void Container::startDecaying()
+ {
++	Item::startDecaying();
+ 	for (Item* item : itemlist) {
+ 		item->startDecaying();
+ 	}",sorry for nitpicking but I would love a new line under this line,why not `Item::startDecaying()` ?
+1057,"@@ -21,5 +21,5 @@ package node
+ type OptionsTransactor struct {
+ 	TransactorEndpointAddress string
+ 	RegistryAddress           string
+-	AccountantID              string
++	ChannelImplementation     string
+ }","ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?","please, change to `ChannelImpleme"
+1058,"@@ -67,4 +67,11 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files referenced by given metadata location.
++   */
++  default RemoveFiles removeFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
++  }
+ }",Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with.,I would say : _Remove all files r
+1059,"@@ -31,7 +31,7 @@ public abstract class IntraFeedSortDialog {
+
+         int idxCurrentSort = -1;
+         for  (int i = 0; i < values.length; i++) {
+-            if (currentSortOrder == values[i]) {
++            if (currentSortOrder == values[i] || currentSortOrder == null) {
+                 idxCurrentSort = i;
+                 break;
+             }",Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?,Why not use `values.length == 1`?
+1060,"@@ -72,6 +72,8 @@ public class Notification {
+     public static final int OMNIPOD_POD_NOT_ATTACHED = 59;
+     public static final int CARBS_REQUIRED = 60;
+     public static final int IMPORTANCE_HIGH = 2;
++    public static final int OMNIPOD_POD_SUSPENDED = 61;
++    public static final int OMNIPOD_POD_ALERTS_UPDATED = 62;
+
+     public static final String CATEGORY_ALARM = ""alarm"";
+ ",Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?,Small typo: `SUSPENDED` should be `SUSPENDED_UPDATED`.
+1061,"@@ -48,7 +48,7 @@ void prepareMolForDrawing(RWMol &mol, bool kekulize, bool addChiralHs,
+   if (kekulize) {
+     try {
+       MolOps::Kekulize(mol, false);  // kekulize, but keep the aromatic flags!
+-    } catch(const RDKit::AtomKekulizeException &e) {
++    } catch (const RDKit::AtomKekulizeException &e) {
+       std::cerr << e.what() << std::endl;
+     }
+   }",Should this be boost logged?,Spurious line break.
+1062,"@@ -57,9 +57,10 @@ def find_notifiers(notifier_name):
+ # pylint: enable=inconsistent-return-statements
+
+
+-def convert_to_timestamp(violations):
++def convert_to_timestamp(session, violations):
+     """"""Convert violation created_at_datetime to timestamp string.
+     Args:
++        session (object): session object to work on.
+         violations (sqlalchemy_object): List of violations as sqlalchemy
+             row/record object with created_at_datetime.
+     Returns:",What is the reason for doing expunge here? This method is purely for converting the timestamp.,"session (object) -> (session object, optional)"
+1063,"@@ -86,9 +86,15 @@ class TypeToSchema extends TypeUtil.SchemaVisitor<Schema> {
+     List<Schema.Field> fields = Lists.newArrayListWithExpectedSize(fieldSchemas.size());
+     for (int i = 0; i < structFields.size(); i += 1) {
+       Types.NestedField structField = structFields.get(i);
++      String origFieldName = structField.name();
++      boolean isValid = validAvroName(origFieldName);
++      String fieldName =  isValid ? origFieldName : sanitize(origFieldName);
+       Schema.Field field = new Schema.Field(
+-          structField.name(), fieldSchemas.get(i), null,
++          sanitize(fieldName), fieldSchemas.get(i), null,
+           structField.isOptional() ? JsonProperties.NULL_VALUE : null);
++      if (!isValid) {
++        field.addProp(AvroSchemaUtil.ORIGINAL_FIELD_NAME_PROP, origFieldName);
++      }
+       field.addProp(AvroSchemaUtil.FIELD_ID_PROP, structField.fieldId());
+       fields.add(field);
+     }",This calls sanitize twice if the name isn't valid.,Why not call `sanitize()` on the `structField.name()`?
+1064,"@@ -0,0 +1,13 @@
++class Proposal < ActiveRecord::Base
++  has_one :cart
++
++  validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
++  validates :status, presence: true, inclusion: {in: Approval::STATUSES}
++
++  after_initialize :set_default_flow
++
++
++  def set_default_flow
++    self.flow ||= 'parallel'
++  end
++end",Is there an equivalent that'd allow zero or one?,Align the elements of a hash literal if they span more than one line.<br>Redundant `self` detected.
+1065,"@@ -234,6 +234,13 @@ func (m *taskExecutor) repeatWith() (err error) {
+ 			m.resetK8sClient(resource)
+ 		}
+
++		if rwExec.isTaskObjectNameRepeat() {
++			// if repetition is based on task object name itself, then the task's
++			// object name needs to be set
++			m.metaTaskExec.setObjectName(resource)
++			m.objectName = resource
++		}
++
+ 		// set the currently active repeat resource
+ 		util.SetNestedField(m.templateValues, resource, string(v1alpha1.ListItemsTLP), string(v1alpha1.CurrentRepeatResourceLITP))
+ ",Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties.,Is there any chance that `m.metaTaskExec.getObjectName` will be nil?
+1066,"@@ -47,7 +47,7 @@ func accountImport(args []string) string {
+ 	}
+ 	wallet := cfg.Wallet
+ 	fmt.Printf(""#%s: Enter your private key, which will not be exposed on the screen.\n"", name)
+-	privateKeyBytes, err := terminal.ReadPassword(syscall.Stdin)
++	privateKeyBytes, err := terminal.ReadPassword(int(syscall.Stdin))
+ 	if err != nil {
+ 		log.L().Error(""fail to get private key"", zap.Error(err))
+ 		return err.Error()",unnecessary conversion (from `unconvert`),why not `int(syscall.Stdin)`?
+1067,"@@ -30,7 +30,6 @@ int main (int argc, char *argv[])
+     int universe_size;
+     char *kvsname;
+     char *val;
+-    char pmi_fd[16];
+     char pmi_rank[16];
+     char pmi_size[16];
+     int result;",typo in commit message `openening`,(style) line over 80 characters
+1068,"@@ -10,7 +10,10 @@
+
+ #include <mpi.h>
+
+-#include <adios2.h>
++#define ADIOS_HAVE_PHDF5 // so hdf5 related items are loaded in ADIOS_CPP.h
++//#include ""ADIOS_CPP.h""
++#include ""adios2.h""
++#include ""adios2/engine/hdf5/HDF5ReaderP.h""
+
+ int main(int argc, char *argv[])
+ {",User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include <adios2.h>`,Can this be removed?
+1069,"@@ -20,7 +20,8 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
+
+     def test_buckets_are_global_to_every_users(self):
+         self.app.patch_json(self.record_url,
+-                            {'permissions': {'read': [Authenticated]}},
++                            {'data': {},
++                             'permissions': {'read': [Authenticated]}},
+                             headers=self.headers)
+         self.app.get(self.record_url, headers=get_user_headers('alice'))
+ ",nit: I guess we can omit this (unless you had a reason to specify it),Is there any way to
+1070,"@@ -74,6 +74,11 @@ func (c *client) isSolicitedLeafNode() bool {
+ 	return c.kind == LEAF && c.leaf.remote != nil
+ }
+
++// Returns true if this is a solicited leafnode and is not configured to be treated as a hub.
++func (c *client) isSpokeLeafNode() bool {
++	return c.kind == LEAF && c.leaf.remote != nil && !c.leaf.remote.Hub
++}
++
+ func (c *client) isUnsolicitedLeafNode() bool {
+ 	return c.kind == LEAF && c.leaf.remote == nil
+ }",Why is Hub public?,I am wondering if we
+1071,"@@ -114,7 +114,6 @@ func (agent *ecsAgent) capabilities() ([]*ecs.Attribute, error) {
+ 	}
+
+ 	capabilities = agent.appendTaskENICapabilities(capabilities)
+-	capabilities = agent.appendENITrunkingCapabilities(capabilities)
+
+ 	capabilities = agent.appendDockerDependentCapabilities(capabilities, supportedVersions)
+ ",why is this deleted?,@jsoriano can you co
+1072,"@@ -1,5 +1,6 @@
+ <div class=""<%= trail.unstarted? ? ""unstarted"" : ""started"" %>"">
+   <section class=""trail <%= topic_class(trail.topic) %>"">
++    <p class=""prerequisite"">Hey, before you start this...Have you done the <a href="""">Intro to Rails</a> tutorial?</p>
+     <header>
+       <span class=""topic-label""><%= trail.topic.name %></span>
+       <h1><%= link_to trail.name, trail %></h1>",Maybe move that into a partial,I'm not sure if `<p>` is the right tag for this. Maybe `<p>` is better.
+1073,"@@ -158,10 +158,13 @@ func TestBlockDAO(t *testing.T) {
+ 		require := require.New(t)
+
+ 		ctx := context.Background()
+-		dao := NewBlockDAO(kvstore, indexer, false, config.Default.DB)
++		testDBFile, _ := ioutil.TempFile(os.TempDir(), ""db"")
++		cfg := config.Default.DB
++		cfg.DbPath = testDBFile.Name()
++		dao := NewBlockDAO(kvstore, indexer, false, cfg)
+ 		require.NoError(dao.Start(ctx))
+ 		defer func() {
+-			require.NoError(dao.Stop(ctx))
++			dao.Stop(ctx)
+ 		}()
+
+ 		// receipts for the 3 blocks",Error return value of `dao.Stop` is not checked (from `errcheck`),Maybe use `path.Join()` here instead of `os.TempDir`?
+1074,"@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
+ 	if docrootRelPath != """" {
+ 		app.Docroot = docrootRelPath
+ 		if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
+-			util.Failed(""The docroot provided (%v) does not exist"", docrootRelPath)
++			output.UserOut.Warnf(""Warning: the provided docroot at %s does not currently exist."", docrootRelPath)
+ 		}
+ 	} else if !cmd.Flags().Changed(""docroot"") {
+ 		app.Docroot = ddevapp.DiscoverDefaultDocroot(app)",util.Warning()? Easier to say.,Why not output a warning? Is there a way to turn it on/off?
+1075,"@@ -38,6 +38,14 @@ func Trie(tx ethdb.Tx, slowChecks bool, quit <-chan struct{}) {
+ 			if errc != nil {
+ 				panic(errc)
+ 			}
++			select {
++			default:
++			case <-quit:
++				return
++			case <-logEvery.C:
++				log.Info(""trie account integrity"", ""key"", fmt.Sprintf(""%x"", k))
++			}
++
+ 			hasState, hasBranch, hasHash, hashes, _ := trie.UnmarshalTrieNode(v)
+ 			AssertSubset(k, hasBranch, hasState)
+ 			AssertSubset(k, hasHash, hasState)",this default is kinda superfluous (although i see it was already there before PR ),hmmm... how does this work?
+1076,"@@ -53,11 +53,7 @@ public class NodeList<N extends Node> implements List<N>, Iterable<N>, HasParent
+     private List<AstObserver> observers = new ArrayList<>();
+
+     public NodeList() {
+-        this((Node) null);
+-    }
+-
+-    public NodeList(Node parent) {
+-        setParentNode(parent);
++        parentNode = null;
+     }
+
+     public NodeList(Collection<N> n) {",How is this related?,Why is this not needed anymore?
+1077,"@@ -3,6 +3,7 @@ class SubscriptionsController < ApplicationController
+
+   def new
+     @plans = IndividualPlan.featured.active.ordered
++    @team_plans = TeamPlan.featured.ordered
+   end
+
+   def edit","I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions.",Do not use semicolons to termin
+1078,"@@ -1,8 +1,8 @@
+ shared_examples_for 'disables OpenSSH roaming' do
+   let(:disable_ssh_roaming) { %(echo -e ""Host *\n  UseRoaming no\n"" | cat - $HOME/.ssh/config > $HOME/.ssh/config.tmp && mv $HOME/.ssh/config.tmp $HOME/.ssh/config) }
+-  let(:sexp) { sexp_find(subject, [:if, ""$(sw_vers -productVersion | cut -d . -f 2) -lt 12""]) }
++  let(:sexp) { sexp_find(subject, [:if, %(""$(sw_vers -productVersion 2>/dev/null | cut -d . -f 2)"" -lt 12)]) }
+
+   it 'disables OpenSSH roaming' do
+-    sexp.should include_sexp [:cmd, disable_ssh_roaming]
++    expect(sexp).to include_sexp [:cmd, disable_ssh_roaming]
+   end
+ end","The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style.",Prefer single-quoted strings wh
+1079,"@@ -172,7 +172,7 @@ bool ReaderProxy::requested_changes_set(std::vector<SequenceNumber_t>& seqNumSet
+     {
+         auto chit = m_changesForReader.find(ChangeForReader_t(*sit));
+
+-        if(chit != m_changesForReader.end() && chit->isValid())
++        if(chit != m_changesForReader.end())
+         {
+             ChangeForReader_t newch(*chit);
+             newch.setStatus(REQUESTED);",Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?,Space between `if` and `(`
+1080,"@@ -44,9 +44,12 @@ import {
+ 	isDataZeroForReporting,
+ } from '../util';
+
+-const { __ } = wp.i18n;
+-const { Component, Fragment } = wp.element;
+-const { isEmpty } = lodash;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { Component, Fragment } from '@wordpress/element';
++import { isEmpty } from 'lodash';
+
+ class AnalyticsDashboardWidgetTopLevel extends Component {
+ 	constructor( props ) {",`lodash` shouldn't be grouped under WordPress dependencies,Nit: We usually only import these at the top of the file.
+1081,"@@ -69,7 +69,7 @@ class GenericDataFile
+   /**
+    * Used by Avro reflection to instantiate this class when reading manifest files.
+    */
+-  public GenericDataFile(org.apache.avro.Schema avroSchema) {
++  GenericDataFile(org.apache.avro.Schema avroSchema) {
+     this.avroSchema = avroSchema;
+
+     Types.StructType schema = AvroSchemaUtil.convert(avroSchema).asNestedType().asStructType();",This needs to be public so that Avro can call it.,Please revert this change.
+1082,"@@ -18,18 +18,7 @@
+ /**
+  * External dependencies
+  */
+-import data, { TYPE_CORE } from 'GoogleComponents/data';
+-import SvgIcon from 'GoogleUtil/svg-icon';
+-
+-export * from './storage';
+-
+-const { apiFetch } = wp;
+-const {
+-	addFilter,
+-	applyFilters,
+-} = wp.hooks;
+-
+-const {
++import {
+ 	map,
+ 	isNull,
+ 	isUndefined,",`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies.,Do we still need this file?
+1083,"@@ -245,6 +245,13 @@ class DataFrame(_Frame):
+             else:
+                 super(DataFrame, self).__init__(_InternalFrame(
+                     data, data_columns=index.data_columns, index_map=index.index_map))
++        elif isinstance(data, ks.Series):
++            assert index is None
++            assert columns is None
++            assert dtype is None
++            assert not copy
++            data = data.to_dataframe()
++            super(DataFrame, self).__init__(data._internal)
+         else:
+             if isinstance(data, pd.DataFrame):
+                 assert index is None",I think he meant the docstring in this constructor. yea we should fix,Is there a benefit to using `assert not copy` rather than
+1084,"@@ -150,7 +150,18 @@ public abstract class BinaryDictionary implements Dictionary {
+         throw new IllegalStateException(""unknown resource scheme "" + resourceScheme);
+     }
+   }
+-
++
++  public static InputStream getResource(ResourceScheme scheme, String path) throws IOException {
++    switch(scheme) {
++      case CLASSPATH:
++        return getClassResource(path);
++      case FILE:
++        return Files.newInputStream(Paths.get(path));
++      default:
++        throw new IllegalStateException(""unknown resource scheme "" + scheme);
++    }
++  }
++
+   // util, reused by ConnectionCosts and CharacterDefinition
+   public static InputStream getClassResource(Class<?> clazz, String suffix) throws IOException {
+     final InputStream is = clazz.getResourceAsStream(clazz.getSimpleName() + suffix);","so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?",This method doesn't seem to be used anywhere.
+1085,"@@ -525,8 +525,11 @@ namespace SkylineNightly
+
+         private void DownloadSkylineTester(string skylineTesterZip, RunMode mode)
+         {
+-            // Make sure we can negotiate with HTTPS servers that demand TLS 1.2 (default in dotNet 4.6, but has to be turned on in 4.5)
+-            ServicePointManager.SecurityProtocol |= (SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12);
++            // The current recommendation from MSFT for future-proofing HTTPS https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls
++            // is don't specify TLS levels at all, let the OS decide. But we worry that this will mess up Win7 and Win8 installs, so we continue to specify explicitly
++            var Tls13 = (SecurityProtocolType)12288; // From decompiled SecurityProtocolType - compiler has no definition for some reason
++            ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12 | Tls13;
++
+             using (var client = new WebClient())
+             {
+                 client.Credentials = new NetworkCredential(TEAM_CITY_USER_NAME, TEAM_CITY_USER_PASSWORD);",It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288,Would it make sense to put this as a static r
+1086,"@@ -70,16 +70,6 @@ export default [
+         updated_by: 1,
+         value: ''
+     },
+-    {
+-        id: 12,
+-        key: 'labs',
+-        value: '{""subscribers"":true}',
+-        type: 'blog',
+-        created_at: '2015-01-12T18:29:01.000Z',
+-        created_by: 1,
+-        updated_at: '2015-10-27T17:39:58.288Z',
+-        updated_by: 1
+-    },
+     {
+         id: 13,
+         created_at: '2015-09-11T09:44:30.810Z',","Similar to the above, put this setting back but keep the value as `'{}'`",This records the new records in the database.
+1087,"@@ -130,7 +130,7 @@ def refresh_listen_count_aggregate():
+            Assuming today is 2022-01-01 and this function is called for year_offset 1 and
+            year_count 1 then all of 2021 will be refreshed.
+     """"""
+-
++    logger.info(""Starting to refresh continuous aggregates:"")
+     timescale.init_db_connection(config.SQLALCHEMY_TIMESCALE_URI)
+
+     end_ts = int(datetime.now().timestamp()) - SECONDS_IN_A_YEAR","As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up",I think we should remove this log line. It lo
+1088,"@@ -33,12 +33,4 @@
+ <div id=""about"" class=""card"">
+   <h2 class='card-header collapsed collapse-toggle' data-toggle=""collapse"" data-target=""#about-content""><a href=""/rails/info/properties"">About your application&rsquo;s environment</a></h2>
+   <div id=""about-content"" class=""card-body collapse""></div>
+-</div>
+-
+-<script>
+-  Blacklight.onLoad(function() {
+-    $('#about .card-header').one('click', function() {
+-      $($(this).data('target')).load($(this).find('a').attr('href'));
+-    });
+-  });
+-</script>
++</div>",I'm curious about why this needed to be removed.,Can you explain why this is no longer needed?
+1089,"@@ -17,10 +17,10 @@ from scapy.config import conf
+ from scapy.base_classes import BasePacket,BasePacketList
+ from scapy.utils import do_graph,hexdump,make_table,make_lined_table,make_tex_table,get_temp_file
+
+-from scapy.consts import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
++from scapy.extlib import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
+ from functools import reduce
+ import scapy.modules.six as six
+-from scapy.modules.six.moves import filter, range, zip
++from scapy.modules.six.moves import range, zip
+
+
+ #############",why did you remove `zip`? It is used!,don't remove `filter` from `scapy.modules.six
+1090,"@@ -90,7 +90,7 @@ func (bs *BrokerStatus) MarkTopicUnknown(reason, format string, args ...interfac
+ 	brokerCondSet.Manage(bs).MarkUnknown(BrokerConditionTopic, reason, format, args...)
+ }
+
+-func (bs *BrokerStatus) MarkTopicReady() {
++func (bs *BrokerStatus) MarkTopicReady(_ string) {
+ 	brokerCondSet.Manage(bs).MarkTrue(BrokerConditionTopic)
+ }
+ ",Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?,I'm confused as to why we can't do a `MarkTru
+1091,"@@ -1,4 +1,4 @@
+-<?php namespace TestVendor\Goto;
++<?php namespace TestVendor\_Goto;
+
+ use System\Classes\PluginBase;
+ ","before php8 ""goto"" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4",Did you mean to leave this one untouched?
+1092,"@@ -85,6 +85,7 @@ func (t *Transport) NewInbound(listener net.Listener, options ...InboundOption)
+ }
+
+ // NewSingleOutbound returns a new Outbound for the given adrress.
++// Note: This does not support TLS. See TLS example in doc.go.
+ func (t *Transport) NewSingleOutbound(address string, options ...OutboundOption) *Outbound {
+ 	return newSingleOutbound(t, address, options...)
+ }","nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen.",Does it mean that we don't support TLS here?
+1093,"@@ -226,11 +226,17 @@ func (o *Outbound) CallOneway(ctx context.Context, treq *transport.Request) (tra
+ 		return nil, yarpcerrors.InvalidArgumentErrorf(""request for http oneway outbound was nil"")
+ 	}
+
+-	_, err := o.call(ctx, treq)
++	// res is used to close the response body to avoid memory/connection leak
++	// even when the response body is empty
++	res, err := o.call(ctx, treq)
+ 	if err != nil {
+ 		return nil, err
+ 	}
+
++	if err = res.Body.Close(); err != nil {
++		return nil, yarpcerrors.Newf(yarpcerrors.CodeInternal, err.Error())
++	}
++
+ 	return time.Now(), nil
+ }
+ ",I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors,It would be nice if the error returned from
+1094,"@@ -8,7 +8,7 @@ import java.util.regex.Pattern;
+
+ public class EmailAddressValidator implements Validator {
+     private static final Pattern EMAIL_ADDRESS_PATTERN = Pattern.compile(
+-          ""[a-zA-Z0-9\\+\\.\\_\\%\\-\\+]{1,256}"" +
++          ""[a-zA-Z0-9\\+\\.\\_\\%\\-]{1,256}"" +
+           ""\\@"" +
+           ""[a-zA-Z0-9][a-zA-Z0-9\\-]{0,64}"" +
+           ""("" +",We're already matching +. Not sure why this changed.,I am not sure if this change is correct. If
+1095,"@@ -34,6 +34,14 @@ class Configuration implements ConfigurationInterface
+             ->children()
+                 ->scalarNode('db_driver')->isRequired()->end()
+                 ->scalarNode('default_context')->isRequired()->end()
++                ->scalarNode('category_manager')
++                    ->info('if sonata-project/classification exists will set ""sonata.classification.manager.category"" | if you want to define your own category manager you need to implement \Sonata\MediaBundle\Model\CategoryManagerInterface and set the service name here')
++                    ->defaultValue(null)
++                ->end()
++                ->scalarNode('force_disable_category')
++                    ->info('true IF you really want to disable the relation with category')
++                    ->defaultValue(false)
++                ->end()
+             ->end()
+         ;
+ ","Please add line breaks, so the line doesn't exceed 80 chars.",Why does this default to `false`? Shouldn't
+1096,"@@ -29,11 +29,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""AspNetCoreInstrumentation""/> class.
+         /// </summary>
+-        /// <param name=""activitySource"">ActivitySource adapter instance.</param>
+         /// <param name=""options"">Configuration options for ASP.NET Core instrumentation.</param>
+-        public AspNetCoreInstrumentation(ActivitySourceAdapter activitySource, AspNetCoreInstrumentationOptions options)
++        public AspNetCoreInstrumentation(AspNetCoreInstrumentationOptions options)
+         {
+-            this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(new HttpInListener(""Microsoft.AspNetCore"", options, activitySource), null);
++            this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(new HttpInListener(""Microsoft.AspNetCore"", options), null);
+             this.diagnosticSourceSubscriber.Subscribe();
+         }
+ ",I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!,Can you also remove the `activitySource` parameter from the constructor here? I don't think it's used anymore.
+1097,"@@ -243,7 +243,7 @@ _ostree_delta_compute_similar_objects (OstreeRepo                 *repo,
+ {
+   gboolean ret = FALSE;
+   g_autoptr(GHashTable) ret_modified_regfile_content =
+-    g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)g_ptr_array_unref);
++    g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);
+   g_autoptr(GPtrArray) from_sizes = NULL;
+   g_autoptr(GPtrArray) to_sizes = NULL;
+   guint i, j;",I'm not sure how this one didn't segfault before.,"Hm, g_free is not needed here, it is already called by g_hash_table_new_full()."
+1098,"@@ -27,6 +27,13 @@ import (
+ )
+
+ var _ = Describe(""Endpoints"", func() {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	for _, trueOrFalse := range []bool{true, false} {
+ 		kubeIPVSEnabled := trueOrFalse
+ 		var rrConfigNormalMangleReturn = Config{",Same points as in other test file.,Is there a reason we moved these from `pkg/config` to `pkg/util`? I would prefer to keep them from `pkg/config
+1099,"@@ -16,14 +16,7 @@
+  */
+ package org.apache.lucene.analysis.hunspell;
+
+-import java.io.BufferedInputStream;
+-import java.io.BufferedOutputStream;
+-import java.io.BufferedReader;
+-import java.io.IOException;
+-import java.io.InputStream;
+-import java.io.InputStreamReader;
+-import java.io.LineNumberReader;
+-import java.io.OutputStream;
++import java.io.*;
+ import java.nio.charset.Charset;
+ import java.nio.charset.CharsetDecoder;
+ import java.nio.charset.CodingErrorAction;","Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question.",I think our style discourage importing `*`
+1100,"@@ -4,7 +4,11 @@ describe TrailWithProgress do
+   it ""decorates its component"" do
+     user = double(""user"")
+     trail = build_stubbed(:trail)
+-    trail_with_progress = TrailWithProgress.new(trail, user: user)
++    trail_with_progress = TrailWithProgress.new(
++      trail,
++      user: user,
++      status_finder: double(StatusFinder),
++    )
+
+     expect(trail_with_progress).to be_a(SimpleDelegator)
+     expect(trail_with_progress.name).to eq(trail.name)",Put a comma after the last parameter of a multiline method call.,Nice! This was always bothering me
+1101,"@@ -183,6 +183,11 @@ fpga_result errors_filter(fpga_properties *filter, int argc, char *argv[])
+ 							  FPGA_ACCELERATOR);
+ 			ON_FPGAINFO_ERR_GOTO(
+ 				res, out, ""setting type to FPGA_ACCELERATOR"");
++
++			res = fpgaPropertiesSetInterface(*filter,
++				FPGA_IFC_DFL);
++			ON_FPGAINFO_ERR_GOTO(
++				res, out, ""setting type to FPGA_IFC_DFL"");
+ 			break;
+ 		case VERB_ALL:
+ 		default:",Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday.,It seems like this should be condi
+1102,"@@ -18,6 +18,13 @@ var _ specsruntime.Syscalls = (*syscalls)(nil)
+
+ // VerifySignature implements Syscalls.
+ func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) error {
++	// Dragons: this lets all id addresses off the hook -- we need to remove this
++	// once market actor code actually checks proposal signature.  Depending on how
++	// that works we may want to do id address to pubkey address lookup here or we
++	// might defer that to VM
++	if signer.Protocol() == address.ID {
++		return nil
++	}
+ 	return crypto.ValidateSignature(plaintext, signer, signature)
+ }
+ ","Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here.",Should we add a TODO to remove thi
+1103,"@@ -5,7 +5,7 @@
+ Purpose
+
+ Shows how to run an EMRFS command as a job step on an Amazon EMR cluster. This
+-can be used to automate ERMFS commands and is an alternative to connecting through
++can be used to automate EMRFS commands and is an alternative to connecting through
+ SSH to run the commands manually.
+ """"""
+ ",electronic medical record file system (EMRFS),I don't think we should change thi
+1104,"@@ -438,6 +438,7 @@ var directives = []string{
+ 	""mailout"",   // github.com/SchumacherFM/mailout
+ 	""awslambda"", // github.com/coopernurse/caddy-awslambda
+ 	""filter"",    // github.com/echocat/caddy-filter
++	""maxrequestbody"",
+ }
+
+ const (","Put this higher in the list, like after ""bind"", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts.",This should be in `pkg/configurator`
+1105,"@@ -37,13 +37,11 @@ import (
+ )
+
+ var (
+-	ErrInvalidOrderType = status.Errorf(codes.InvalidArgument, ""invalid order type"")
+-	ErrAskNotFound      = status.Errorf(codes.NotFound, ""ask not found"")
+-	ErrDeviceNotFound   = status.Errorf(codes.NotFound, ""device not found"")
+-	ErrMinerNotFound    = status.Errorf(codes.NotFound, ""miner not found"")
+-	errDealNotFound     = status.Errorf(codes.NotFound, ""deal not found"")
+-	errTaskNotFound     = status.Errorf(codes.NotFound, ""task not found"")
+-	errImageForbidden   = status.Errorf(codes.PermissionDenied, ""specified image is forbidden to run"")
++	ErrDeviceNotFound = status.Errorf(codes.NotFound, ""device not found"")
++	ErrMinerNotFound  = status.Errorf(codes.NotFound, ""miner not found"")
++	errDealNotFound   = status.Errorf(codes.NotFound, ""deal not found"")
++	errTaskNotFound   = status.Errorf(codes.NotFound, ""task not found"")
++	errImageForbidden = status.Errorf(codes.PermissionDenied, ""specified image is forbidden to run"")
+
+ 	hubAPIPrefix = ""/sonm.Hub/""
+ ",oh come on :(,why did you change the error text he
+1106,"@@ -76,7 +76,7 @@ public class ProtocolHandshake {
+
+         if (result.isPresent()) {
+           Result toReturn = result.get();
+-          LOG.info(String.format(""Detected dialect: %s"", toReturn.dialect));
++          LOG.finest(String.format(""Detected dialect: %s"", toReturn.dialect));
+           return toReturn;
+         }
+       }",This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users.,to be consistent with the other log
+1107,"@@ -30,6 +30,7 @@ def get_gcloud_info():
+         str: GCP project id
+         str: GCP Authenticated user
+         bool: Whether or not the installer is running in cloudshell
++        bool: Whether or not authenticated user is a service account
+     """"""
+     return_code, out, err = utils.run_command(
+         ['gcloud', 'info', '--format=json'])",Remove as this is not needed anymore.,This should be `bool: Whether or not
+1108,"@@ -10,3 +10,11 @@ class Interface:
+ class DoNothing: pass
+
+ class DoNothing2: pass
++
++class DoSomething:
++    def __init__(self, a_string: str, optional_int: int = None):
++        self.my_string = a_string
++        self.my_int = optional_int
++
++    def do_it(self, new_int: int) -> int:
++        return self.my_int + new_int",This new class is for checking that #4551 works correctly with PlantUML output too.,This will need a docstring.
+1109,"@@ -168,6 +168,11 @@ func (c *controller) buildCertificates(ctx context.Context, ing *networkingv1bet
+ 					Kind:  issuerKind,
+ 					Group: issuerGroup,
+ 				},
++				Usages: []cmapi.KeyUsage{
++					cmapi.UsageDigitalSignature,
++					cmapi.UsageKeyEncipherment,
++					cmapi.UsageServerAuth, // default for web facing certificates as per https://support.apple.com/en-us/HT210176
++				},
+ 			},
+ 		}
+ ",Will this cause all certificates to be re-issued?,nit: `// default for web fa
+1110,"@@ -215,6 +215,10 @@ fpga_result  enum_max10_metrics_info(struct _fpga_handle *_handle,
+ 		}
+ 		metric_name[strlen(metric_name)-1] = '\0';
+
++		if (tmp) {
++			free(tmp);
++		}
++
+ 		// Metrics typw
+ 		result = read_sensor_sysfs_file(pglob.gl_pathv[i], SENSOR_SYSFS_TYPE, (void **)&tmp, &tot_bytes);
+ 		if (FPGA_OK != result) {",I think tmp is also leaked at the end of this loop if no error cases are encountered.,Any reason not to `free(tmp
+1111,"@@ -165,13 +165,14 @@ class BuildAvroProjection extends AvroCustomOrderSchemaVisitor<Schema, Schema.Fi
+       try {
+         Schema keyValueSchema = array.getElementType();
+         Schema.Field keyField = keyValueSchema.getFields().get(0);
++        Schema.Field keyProjection = element.get().getField(""key"");
+         Schema.Field valueField = keyValueSchema.getFields().get(1);
+         Schema.Field valueProjection = element.get().getField(""value"");
+
+         // element was changed, create a new array
+-        if (valueProjection.schema() != valueField.schema()) {
++        if (keyProjection.schema() != keyField.schema() || valueProjection.schema() != valueField.schema()) {
+           return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(),
+-              AvroSchemaUtil.getFieldId(keyField), keyField.name(), keyField.schema(),
++              AvroSchemaUtil.getFieldId(keyField), keyField.name(), keyProjection.schema(),
+               AvroSchemaUtil.getFieldId(valueField), valueField.name(), valueProjection.schema());
+         } else if (!(array.getLogicalType() instanceof LogicalMap)) {
+           return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(),","The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data.",nit: we can use `Objects.eq
+1112,"@@ -26,14 +26,13 @@ void UseExecutor::execute() {
+
+     auto spaceName = *sentence_->space();
+     // Check from the cache, if space not exists, schemas also not exist
+-    auto status = ectx()->schemaManager()->checkSpaceExist(spaceName);
+-    if (!status.ok()) {
++    auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);
++    if (spaceId < 0) {
+         DCHECK(onError_);
+         onError_(Status::Error(""Space not found for `%s'"", spaceName.c_str()));
+         return;
+     }
+
+-    auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);
+     session->setSpace(*sentence_->space(), spaceId);
+     FLOG_INFO(""Graph space switched to `%s', space id: %d"", sentence_->space()->c_str(), spaceId);
+ ","Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used.",The check can be removed here. The toGraphSpaceID calls will fail if the space is not found.
+1113,"@@ -17,11 +17,15 @@ import (
+ 	""context""
+ 	""encoding/json""
+ 	""fmt""
++	""io""
+ 	""os""
+ 	""strings""
++	""time""
+
+ 	""github.com/shirou/gopsutil/process""
+
++	jrpc ""github.com/ethereum/go-ethereum/rpc""
++
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/bpm""
+ 	pb ""github.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon/pb""",Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird.,This should probably be in the 3rd import block as well.
+1114,"@@ -68,12 +68,13 @@ class ControlField(Field):
+ 			or (role in (controlTypes.ROLE_TABLE, controlTypes.ROLE_TABLECELL, controlTypes.ROLE_TABLEROWHEADER, controlTypes.ROLE_TABLECOLUMNHEADER) and not formatConfig[""reportTables""])
+ 			or (role in (controlTypes.ROLE_LIST, controlTypes.ROLE_LISTITEM) and controlTypes.STATE_READONLY in states and not formatConfig[""reportLists""])
+ 			or (role in (controlTypes.ROLE_FRAME, controlTypes.ROLE_INTERNALFRAME) and not formatConfig[""reportFrames""])
++			or (role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT) and not formatConfig[""reportRevisions""])
+ 		):
+ 			# This is just layout as far as the user is concerned.
+ 			return self.PRESCAT_LAYOUT
+
+ 		if (
+-			role in (controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)
++			role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT,controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)
+ 			or (role == controlTypes.ROLE_EDITABLETEXT and controlTypes.STATE_MULTILINE not in states and (controlTypes.STATE_READONLY not in states or controlTypes.STATE_FOCUSABLE in states))
+ 			or (role == controlTypes.ROLE_LIST and controlTypes.STATE_READONLY not in states)
+ 		):",Could you split this into multiple lines?,"Could you please add a space after the comma like `role in (controlTypes.ROLE_LINK, controlT"
+1115,"@@ -19,14 +19,11 @@
+
+ package org.apache.iceberg;
+
+-import java.util.Collection;
+ import java.util.List;
+ import java.util.Set;
+-import org.apache.iceberg.expressions.Expression;
+ import org.apache.iceberg.io.CloseableIterable;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.relocated.com.google.common.collect.FluentIterable;
+-import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+ import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+ import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+ import org.apache.iceberg.relocated.com.google.common.collect.Sets;",Doesn't the snapshot ID start off as null? It seems like we don't need to set it here.,please revert changes to this file.
+1116,"@@ -93,7 +93,7 @@ func (t *V4Trie) Get(cidr V4CIDR) interface{} {
+ }
+
+ func (t *V4Trie) LookupPath(buffer []V4TrieEntry, cidr V4CIDR) []V4TrieEntry {
+-	return t.root.lookupPath(buffer, cidr)
++	return t.root.lookupPath(buffer[:0], cidr)
+ }
+
+ // LPM does a longest prefix match on the trie","I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?",why is this change needed?
+1117,"@@ -173,7 +173,9 @@ func (c *Expected) validateMining(ctx context.Context,
+ 	parentWeight fbig.Int,
+ 	parentReceiptRoot cid.Cid) error {
+
+-	powerTable := NewPowerTableView(c.state.StateView(parentStateRoot))
++	stateView := c.state.StateView(parentStateRoot)
++	sigValidator := NewSignatureValidator(stateView)
++	powerTable := NewPowerTableView(stateView)
+
+ 	for i := 0; i < ts.Len(); i++ {
+ 		blk := ts.At(i)",nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors.,Why not just make `c.state
+1118,"@@ -169,6 +169,13 @@ func (c *CStorPoolController) cStorPoolAddEventHandler(cStorPoolGot *apis.CStorP
+ 					glog.Infof(""Pool %v is online"", string(pool.PoolPrefix)+string(cStorPoolGot.GetUID()))
+ 					c.recorder.Event(cStorPoolGot, corev1.EventTypeNormal, string(common.AlreadyPresent), string(common.MessageResourceAlreadyPresent))
+ 					common.SyncResources.IsImported = true
++					if GetHash(cStorPoolGot) == """" {
++						hash, err := common.CalculateHash(cStorPoolGot.Spec.Disks.DiskList)
++						if err != nil {
++							glog.Errorf(""Failed to update openebs.io/csp-disk-hash value: %v"", err)
++						}
++						UpdateHash(cStorPoolGot, hash)
++					}
+ 					return string(apis.CStorPoolStatusOnline), nil
+ 				}
+ 				glog.Infof(""Pool %v already present"", string(pool.PoolPrefix)+string(cStorPoolGot.GetUID()))",need to fix the error message here,@deads2k i don't think we
+1119,"@@ -17,7 +17,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+         internal const string DEFAULT_POLICY_NAME = ""default"";
+
+         public PropertyBagDictionary() : base() { }
+-
++        //CA1026 not fixed
+         public PropertyBagDictionary(
+             PropertyBagDictionary initializer = null,
+             IEqualityComparer<string> comparer = null)",Unsure of how to handle this one.,what is the reason for thi
+1120,"@@ -1268,7 +1268,9 @@ public class FlowRunner extends EventHandler<Event> implements Runnable {
+
+   public void kill() {
+     synchronized (this.mainSyncObj) {
+-      if (isKilled()) {
++      if (isKilled() || this.flowFinished) {
++        this.logger.info(
++            ""Dropping Kill action as execution "" + this.execId + "" is already finished."");
+         return;
+       }
+       this.logger.info(""Kill has been called on execution "" + this.execId);","Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled.","Just to be sure, you want to check if the execution is already finished or not?"
+1121,"@@ -0,0 +1,11 @@
++package common
++
++// DefaultRetrySettings indicates what the ""default"" retry settings
++// are if it is not specified on an Activity or for any unset fields
++// if a policy is explicitly set on a Child Workflow
++type DefaultRetrySettings struct {
++	InitialIntervalInSeconds   int32
++	MaximumIntervalCoefficient float64
++	BackoffCoefficient         float64
++	MaximumAttempts            int32
++}","replace ""Child Workflow"" with ""any workflow""",why not just call it `RetrySettings`?
+1122,"@@ -426,7 +426,9 @@ footer {
+ 								<span class=""name"">{{html .Name}}</span>
+ 							</a>
+ 						</td>
+-						{{- if .IsDir}}
++						{{- if .IsSymlink }}
++						<td data-order=""-1"">symbolic link</td>
++						{{- else if .IsDir}}
+ 						<td data-order=""-1"">&mdash;</td>
+ 						{{- else}}
+ 						<td data-order=""{{.Size}}"">{{.HumanSize}}</td>","Instead of showing the words ""symbolic link"" under the ""Size"" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?",@DanielRis Have you tested this? I am a bit concerned that this may break some
+1123,"@@ -47,9 +47,10 @@ class DateRange implements FilterEncoder, FacetBuilder
+      * Parses the given date range from a GET parameter and returns a Solr
+      * date range filter.
+      *
+-     * @param string $rangeFilter The range filter query string from the query URL
++     * @param string $dateRange
+      * @param array $configuration Facet configuration
+      * @return string Lucene query language filter to be used for querying Solr
++     * @internal param string $rangeFilter The range filter query string from the query URL
+      */
+     public function decodeFilter($dateRange, array $configuration = array())
+     {",Please add back the description of the parameter,Is there a reason why this was added?
+1124,"@@ -17,7 +17,7 @@ function GraphiteBrowser () {
+   var searchPanel = createSearchPanel();
+   var completerPanel = createCompleterPanel();
+   var treeRoot = treePanel.getRootNode();
+-
++
+   this.trees = {
+     graphite: treeRoot.findChild('id', 'GraphiteTree'),
+     mygraphs: treeRoot.findChild('id', 'MyGraphsTree'),",Superfluous space inserted.,Let's revert this whitespace change.
+1125,"@@ -8,7 +8,9 @@
+  * @returns {Object}
+  */
+ dom.urlPropsFromAttribute = function urlPropsFromAttribute(node, attribute) {
+-	const value = node[attribute];
++	const value = !node.ownerSVGElement
++		? node[attribute]
++		: node.getAttribute(attribute);
+ 	if (!value) {
+ 		return undefined;
+ 	}","Didn't fix the problem. `href=""""` for SVG will still result in `undefined` getting returned by this function.",What's the purpose of this change?
+1126,"@@ -69,13 +69,13 @@ BOOST_AUTO_TEST_CASE(test_route_same_coordinates_fixture)
+                                                    json::Object{{
+                                                        {""location"", location},
+                                                        {""bearing_before"", 0},
+-                                                       {""bearing_after"", 58},
++                                                       {""bearing_after"", 238},
+                                                        {""type"", ""depart""},
+                                                    }}},
+                                                   {""intersections"",
+                                                    json::Array{{json::Object{
+                                                        {{""location"", location},
+-                                                        {""bearings"", json::Array{{58}}},
++                                                        {""bearings"", json::Array{{238}}},
+                                                         {""entry"", json::Array{{json::True()}}},
+                                                         {""out"", 0}}}}}}}}},
+ ",This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?,does this need to be updated?
+1127,"@@ -90,10 +90,10 @@ class AppModule(appModuleHandler.AppModule):
+ 			# Move the review cursor so others can't access its previous position.
+ 			self._oldReviewPos = api.getReviewPosition()
+ 			self._oldReviewObj = self._oldReviewPos.obj
+-			api.setNavigatorObject(eventHandler.lastQueuedFocusObject)
++			api.setNavigatorObject(eventHandler.lastQueuedFocusObject, isFocus=True)
+
+ 	def event_appModule_loseFocus(self):
+ 		if not config.conf[""reviewCursor""][""followFocus""]:
+-			api.setReviewPosition(self._oldReviewPos)
++			api.setReviewPosition(self._oldReviewPos, isCaret=False)
+ 			del self._oldReviewPos, self._oldReviewObj
+ 		inputCore.manager._captureFunc = None","As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject.","isCaret is set to False by default, "
+1128,"@@ -38,7 +38,7 @@ module Selenium
+         port
+       end
+
+-      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
++      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL].freeze
+       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+       IGNORED_ERRORS.freeze
+ ",We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it.,`EADDRNOTAVAIL` should be changed to `EADDRNOTAVAIL`.
+1129,"@@ -368,5 +368,9 @@ func consolidateAutomationPolicies(aps []*caddytls.AutomationPolicy) []*caddytls
+ 		return len(aps[i].Subjects) > len(aps[j].Subjects)
+ 	})
+
++	for i := 0; i < len(aps); i++ {
++		sort.Strings(aps[i].Subjects)
++	}
++
+ 	return aps
+ }",Why is this needed?,This looks like a good candidate for refactoring with
+1130,"@@ -215,6 +215,9 @@ func RegisterRoutes(m *macaron.Macaron) {
+ 		}, reqToken())
+
+ 		// Repositories
++		m.Get(""/users/:username/repos"", repo.ListUserRepos)
++		m.Get(""/orgs/:org/repos"", repo.ListOrgRepos)
++
+ 		m.Combo(""/user/repos"", reqToken()).Get(repo.ListMyRepos).
+ 			Post(bind(api.CreateRepoOption{}), repo.Create)
+ 		m.Post(""/org/:org/repos"", reqToken(), bind(api.CreateRepoOption{}), repo.CreateOrgRepo)",Why not put two other routes after this line (221)?,Shouldn't this be `/org/repos`?
+1131,"@@ -25,9 +25,10 @@ ExecutionEngine::~ExecutionEngine() {
+
+ Status ExecutionEngine::init(std::shared_ptr<folly::IOThreadPoolExecutor> ioExecutor) {
+     auto addrs = network::NetworkUtils::toHosts(FLAGS_meta_server_addrs);
+-    if (!addrs.ok()) {
++    if (!addrs.ok() || addrs.value().empty()) {
+         return addrs.status();
+     }
++
+     metaClient_ = std::make_unique<meta::MetaClient>(ioExecutor, std::move(addrs.value()));
+     metaClient_->init();
+ ","If FLAGS_meta_server_addrs is not empty, in which case ""toHosts"" return empty array?",Is there ever a case where `addrs.value()` would be e
+1132,"@@ -216,6 +216,8 @@ void ResetFactory()
+    */
+   Settings.I2C_clockSpeed = DEFAULT_I2C_CLOCK_SPEED;
+
++  Settings.JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES);
++
+ #ifdef PLUGIN_DESCR
+   strcpy_P(Settings.Name, PSTR(PLUGIN_DESCR));
+ #endif // ifdef PLUGIN_DESCR","There is a function to output a ""JSONBool"" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess.","Setting `DEFAULT_JSON_USE_QUOTES` has been added in settings file for a long time, so it should not have been added here."
+1133,"@@ -90,8 +90,9 @@ class SampledPlot:
+             sampled = data._sdf.sample(fraction=float(self.fraction))
+             return DataFrame(data._internal.copy(sdf=sampled)).to_pandas()
+         elif isinstance(data, Series):
++            scol = data._kdf._internal.data_scols[0]
+             sampled = data._kdf._sdf.sample(fraction=float(self.fraction))
+-            return DataFrame(data._kdf._internal.copy(sdf=sampled)).to_pandas()
++            return DataFrame(data._kdf._internal.copy(sdf=sampled, scol=scol)).to_pandas()
+         else:
+             ValueError(""Only DataFrame and Series are supported for plotting."")
+ ","oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick.",scol = data._internal.data_scols[0] if data._kdf._internal.data_scols else None
+1134,"@@ -1,6 +1,7 @@
+ <% administrator = Role.new(administrator: true, editor: true, commenter: true) %>
+ <% editor = Role.new(editor: true, commenter: true) %>
+ <% commenter = Role.new(commenter: true) %>
++<% administerable = @plan.administerable_by?(current_user) %>
+
+ <h2><%= _('Set plan visibility') %></h2>
+ <p class=""form-control-static""><%= _('Public or organisational visibility is intended for finished plans. You must answer at least %{percentage}%% of the questions to enable these options. Note: test plans are set to private visibility by default.') % { :percentage => Rails.application.config.default_plan_percentage_answered } %></p>",Thanks for moving this up with the rest of the variables. Much tidier :),"This feels more like a view thing than a view thing, maybe there's a better way to do this?"
+1135,"@@ -38,6 +38,12 @@ import (
+ // DefaultAccountantFailureCount defines how many times we're allowed to fail to reach accountant in a row before announcing the failure.
+ const DefaultAccountantFailureCount uint64 = 3
+
++// DefaultPaymentInfo represents the default payment info for the alpha release
++var DefaultPaymentInfo = dto.PaymentPerTime{
++	Price:    money.NewMoney(0.001, money.CurrencyMyst),
++	Duration: 1 * time.Minute,
++}
++
+ // InvoiceFactoryCreator returns a payment engine factory.
+ func InvoiceFactoryCreator(
+ 	dialog communication.Dialog,",I think `Rate` is a more precise and concise term for `PaymentPerTime`.,"I'm not a huge fan of this term, but `dto.PaymentPerTime` suggests that it's a `time.Duration`, so the default payment in"
+1136,"@@ -213,7 +213,7 @@ namespace pwiz.Skyline.Util
+                 {
+                     // No leading + or - : is it because description starts with a label, or because + mode is implied?
+                     var limit = input.IndexOfAny(new[] { '+', '-', ']' });
+-                    if (limit < 0)
++                    if (limit < posNext)
+                     {
+                         return null;
+                     }","I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the ""M"". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?",I think this should be `posNext + 1`
+1137,"@@ -263,7 +263,12 @@ class OrderController extends BaseFrontController
+
+         /* check cart count */
+         $this->checkCartNotEmpty();
+-
++
++        /* check stock not empty */
++        if(true === ConfigQuery::checkAvailableStock()) {
++          $this->checkStockNotEmpty();
++        }
++
+         /* check delivery address and module */
+         $this->checkValidDelivery();
+ ","if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution.",`if (true === ConfigQuery::checkAvai
+1138,"@@ -46,7 +46,7 @@ import (
+ 	""github.com/prometheus/common/version""
+ 	""golang.org/x/sync/errgroup""
+ 	v1 ""k8s.io/api/core/v1""
+-	""k8s.io/klog/v2""
++	klogv2 ""k8s.io/klog/v2""
+ )
+
+ const (",Any specific reason for this change? klog should work correctly here.,"`klogv2` is already imported, use `k"
+1139,"@@ -243,6 +243,9 @@ class Storage(StorageBase):
+         VALUES (:object_id, :parent_id,
+                 :collection_id, (:data)::JSONB,
+                 from_epoch(:last_modified))
++        ON CONFLICT (id, parent_id, collection_id) DO UPDATE
++        SET data = (:data)::JSONB,
++            last_modified = from_epoch(:last_modified)
+         RETURNING id, as_epoch(last_modified) AS last_modified;
+         """"""
+         placeholders = dict(object_id=record[id_field],",we don't mention `last_modified` here?,"<e76> instead of ON CONFLICT (id, pa"
+1140,"@@ -1,6 +1,10 @@
+-const html = require('yo-yo')
+ const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl
+
+ module.exports = (props) => {
+   const isHidden = Object.keys(props.files).length === 0",same deal about the global state maybe interfering as in ActionBrowseTagline,`hyperx` is a very generic name. I would call it `hyperx-editor` or something similar.
+1141,"@@ -172,5 +172,17 @@ namespace Nethermind.Core.Test.Caching
+
+             count.Should().Be(itemsToKeep);
+         }
++
++        [Test]
++        public void Wrong_capacity_number_at_constructor()
++        {
++            int maxCapacity = 0;
++
++            Assert.Throws<ArgumentOutOfRangeException>(() =>
++                {
++                    LruCache<int, int> cache = new LruCache<int, int>(maxCapacity, ""test"");
++                });
++
++        }
+     }
+ }",so sweet to see a test as the first thing,"It would be better to have a test that verifies that LruCache<int, int> is created whe"
+1142,"@@ -161,6 +161,12 @@ struct flb_config *flb_config_init()
+     config->http_port    = flb_strdup(FLB_CONFIG_HTTP_PORT);
+ #endif
+
++    config->http_proxy = getenv(""HTTP_PROXY"");
++    if (strcmp(config->http_proxy, """")) {
++        /* Proxy should not be set when the `HTTP_PROXY` is set to """" */
++        config->http_proxy = NULL;
++    }
++
+     config->cio          = NULL;
+     config->storage_path = NULL;
+     config->storage_input_plugin = NULL;","usually when HTTP_PROXY="""" (empty), proxy should be disabled. could you set it to NULL when it's empty string?",Why not use `HTTP_PROXY`?
+1143,"@@ -62,6 +62,10 @@ class SimpleResizer implements ResizerInterface
+         if ($settings['height'] == null) {
+             $settings['height'] = (int) ($settings['width'] * $size->getHeight() / $size->getWidth());
+         }
++
++        if ($settings['width'] == null) {
++            $settings['width'] = (int) ($settings['height'] * $size->getWidth() / $size->getHeight());
++        }
+
+         return $this->computeBox($media, $settings);
+     }",Can you throw an exception if width or height are both null,Shouldn't we cast to an int here? `(int) ($settings['width'] * $size->getWidth() / $si
+1144,"@@ -26,8 +26,8 @@ import (
+ )
+
+ var (
+-	HTTPSchemeHTTP  = HTTPSchemeKey.String(""http"")
+-	HTTPSchemeHTTPS = HTTPSchemeKey.String(""https"")
++	httpSchemeHTTP  = HTTPSchemeKey.String(""http"")
++	httpSchemeHTTPS = HTTPSchemeKey.String(""https"")
+ )
+
+ // NetAttributesFromHTTPRequest generates attributes of the net",This is a breaking change. I guess these might have been intentionally exported.,Why did the order of these changes?
+1145,"@@ -225,6 +225,8 @@ abstract class BaseTableScan implements TableScan {
+     long splitSize;
+     if (options.containsKey(TableProperties.SPLIT_SIZE)) {
+       splitSize = Long.parseLong(options.get(TableProperties.SPLIT_SIZE));
++    } else if (options.containsKey(TableProperties.METADATA_SPLIT_SIZE)) {
++      splitSize = Long.parseLong(options.get(TableProperties.METADATA_SPLIT_SIZE));
+     } else {
+       splitSize = targetSplitSize(ops);
+     }","I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans.",Can you add a curly bracket to alig
+1146,"@@ -267,6 +267,10 @@ const (
+ 	Add Operator = '+'
+ 	// Subtract implements binary - (only works on integers)
+ 	Subtract = '-'
++	// Multiply implements multiplication between two types
++	Multiply = '×'
++	// Divide implements division, currently only between integers
++	Divide = '÷'
+ 	// Modulo implements % (including string interpolation)
+ 	Modulo = '%'
+ 	// LessThan implements <","wait a sec, shouldn't this be `'*'`?",Is there an implement for `Multiply
+1147,"@@ -127,6 +127,9 @@ func (oi *OVFImporter) buildDaisyVars(bootDiskImageURI string, machineType strin
+ 	varMap[""boot_disk_image_uri""] = bootDiskImageURI
+ 	if oi.params.IsInstanceImport() {
+ 		varMap[""instance_name""] = oi.params.InstanceNames
++		if oi.params.ComputeServiceAccount != """" {
++			varMap[""compute_service_account""] = oi.params.ComputeServiceAccount
++		}
+ 	} else {
+ 		varMap[""machine_image_name""] = oi.params.MachineImageName
+ 	}",It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ ),I don't see this variable being use
+1148,"@@ -21,6 +21,7 @@ from selenium.webdriver.remote.remote_connection import RemoteConnection
+ class FirefoxRemoteConnection(RemoteConnection):
+     def __init__(self, remote_server_addr, keep_alive=True):
+         RemoteConnection.__init__(self, remote_server_addr, keep_alive)
++        self._commands[""GET_CONTEXT""] = ('GET', '/session/$sessionId/moz/context')
+
+         self._commands[""SET_CONTEXT""] = (""POST"", ""/session/$sessionId/moz/context"")
+         self._commands[""ELEMENT_GET_ANONYMOUS_CHILDREN""] = \",Nit: Group this with the other commands by moving it down one line.,Are we missing the `moz/context` part?
+1149,"@@ -512,6 +512,9 @@ public class VectorizedPageIterator extends BasePageIterator {
+         throw new ParquetDecodingException(""could not read page in col "" + desc, e);
+       }
+     } else {
++      if (dataEncoding != Encoding.PLAIN) {
++        throw new UnsupportedOperationException(""Unsupported encoding: "" + dataEncoding);
++      }
+       plainValuesReader = new ValuesAsBytesReader();
+       plainValuesReader.initFromPage(valueCount, in);
+       dictionaryDecodeMode = DictionaryDecodeMode.NONE;","I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like ""Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file""",We should throw an exception when `dat
+1150,"@@ -101,6 +101,10 @@ class RangeBase(luigi.WrapperTask):
+     now = luigi.IntParameter(
+         default=None,
+         description=""set to override current time. In seconds since epoch"")
++    param_name = luigi.Parameter(
++        default=None,
++        description=""parameter name used to pass in parameterized value. Defaults to None, meaning use first positional parameter"",
++        positional=False)
+
+     @property
+     def of_cls(self):","Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere.",when would this be `None`?
+1151,"@@ -9,8 +9,8 @@ const expect = require('chai').expect,
+   MongoError = require('../../../lib/core/error').MongoError,
+   ReadPreference = require('../../../lib/core/topologies/read_preference');
+
+-const rsWithPrimaryPath = f('%s/../spec/max-staleness/ReplicaSetWithPrimary', __dirname);
+-const rsWithoutPrimaryPath = f('%s/../spec/max-staleness/ReplicaSetNoPrimary', __dirname);
++const rsWithPrimaryPath = f('%s/../../spec/max-staleness/ReplicaSetWithPrimary', __dirname);
++const rsWithoutPrimaryPath = f('%s/../../spec/max-staleness/ReplicaSetNoPrimary', __dirname);
+
+ describe('Max Staleness', function() {
+   describe('ReplicaSet without primary', function() {","Since we're here, can we use a template?",I think this should be `../../../../sp
+1152,"@@ -214,3 +214,10 @@ def postgres_db_info_resource(init_context):
+         dialect='postgres',
+         load_table=_do_load,
+     )
++
++
++if __name__ == '__main__':
++    # This is a brutal hack. When the SparkSession is created for the first time there is a lengthy
++    # download process from Maven. This allows us to run python -m airline_demo.resources in the
++    # Dockerfile and avoid a long runtime delay before each containerized solid executes.
++    spark_session_local.resource_fn(None)",saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?,Is there a specific reason for this hack? I'm not sure what's going on here.
+1153,"@@ -49,10 +49,10 @@ var _ = Context(""with initialized Felix, etcd datastore, 3 workloads"", func() {
+ 		defaultProfile := api.NewProfile()
+ 		defaultProfile.Name = ""default""
+ 		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.EgressRules = []api.Rule{{Action: ""allow""}}
++		defaultProfile.Spec.EgressRules = []api.Rule{{Action: api.Allow}}
+ 		defaultProfile.Spec.IngressRules = []api.Rule{{
+-			Action: ""allow"",
+-			Source: api.EntityRule{Tag: ""default""},
++			Action: api.Allow,
++			Source: api.EntityRule{Selector: ""default == ''""},
+ 		}}
+ 		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+ 		Expect(err).NotTo(HaveOccurred())",`has(default)` i think is the preferred way of doing this,Why was this necessary?
+1154,"@@ -35,9 +35,11 @@ class ScalarSpaceEncoderTest(unittest.TestCase):
+   def testScalarSpaceEncoder(self):
+     """"""scalar space encoder""""""
+     # use of forced=True is not recommended, but used in the example for readibility, see scalar.py
+-    sse = ScalarSpaceEncoder(1,1,2,False,2,1,1,None,0,False,""delta"", forced=True)
++    sse = ScalarSpaceEncoder(w=21,minval=1,maxval=2,n=100,radius=1,
++            resolution=1,name=""SP1"",verbosity=0,clipInput=False,space=""delta"")
+     self.assertTrue(sse.isDelta())
+-    sse = ScalarSpaceEncoder(1,1,2,False,2,1,1,None,0,False,""absolute"", forced=True)
++    sse = ScalarSpaceEncoder(w=21,minval=1,maxval=2,n=100,radius=1,
++            resolution=1,name=""sp2"",verbosity=0,clipInput=False,space=""absolute"")
+     self.assertFalse(sse.isDelta())
+
+      ",always put a space after a comma,Forgot to remove the forced=True here?
+1155,"@@ -289,6 +289,10 @@ public class LFMainActivity extends SharedMediaActivity {
+                     mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
+                     editMode = true;
+                 }
++                else
++                {
++                    selectAllPhotosUpToFav(getImagePosition(m.getPath()));
++                }
+             } else selectAllPhotosUpTo(getImagePosition(m.getPath()), mediaAdapter);
+             return true;
+         }","@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280.",This is the same as `selectAllPhotosUpToFav` already?
+1156,"@@ -111,7 +111,7 @@ class WebDriver(object):
+
+     def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
+                  desired_capabilities=None, browser_profile=None, proxy=None,
+-                 keep_alive=False, file_detector=None):
++                 keep_alive=False, file_detector=None, options=None):
+         """"""
+         Create a new driver that will issue commands using the wire protocol.
+ ",@AutomatedTester @davehunt thoughts on a new keyword argument?,I'm guessing you didn't mean to include `options` in this docstring?
+1157,"@@ -44,7 +44,7 @@ public class NodeStatus {
+   public NodeStatus(
+       NodeId nodeId,
+       URI externalUri,
+-      int maxSessionCount,
++      Integer maxSessionCount,
+       Set<Slot> slots,
+       Availability availability) {
+     this.nodeId = Require.nonNull(""Node id"", nodeId);",This change shouldn't be necessary for this PR. Please remove it.,`int` as opposed to `int`?
+1158,"@@ -27,7 +27,8 @@ import (
+ )
+
+ func testAlertmanagerInstanceNamespacesAllNs(t *testing.T) {
+-	ctx := framework.NewTestCtx(t)
++	testCtx := framework.NewTestCtx(t)
++	ctx := &testCtx
+ 	defer ctx.Cleanup(t)
+
+ 	// create 3 namespaces:","This variable is mostly unused, how about we make `NewTestCtx` return a pointer?",Why do we need this change?
+1159,"@@ -7,6 +7,10 @@ import (
+ 	""k8s.io/klog/v2""
+ )
+
++const (
++	maxPayloadLen = 32 * 1 << 20 // 32Mi
++)
++
+ type Reader struct {
+ 	reader io.Reader
+ }",What is the basis of this value?,can we have this constant in pkg/config?
+1160,"@@ -28,6 +28,7 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+
++#include ""gce_metadata.h""
+ #include ""stackdriver.h""
+ #include ""stackdriver_conf.h""
+ ",Nit: was this extra blank line added intentionally?,"Shouldn't there be some kind of check here? If there is no error, it probably should."
+1161,"@@ -5837,6 +5837,12 @@ initialize_exception_record(EXCEPTION_RECORD* rec, app_pc exception_address,
+     case ILLEGAL_INSTRUCTION_EXCEPTION:
+         rec->ExceptionCode = EXCEPTION_ILLEGAL_INSTRUCTION;
+         break;
++    case GUARD_PAGE_EXCEPTION:
++        rec->ExceptionCode = STATUS_GUARD_PAGE_VIOLATION;
++        rec->NumberParameters = 2;
++        rec->ExceptionInformation[0]=EXCEPTION_EXECUTE_FAULT /* execution tried */;
++        rec->ExceptionInformation[1]=(ptr_uint_t)exception_address;
++        break;
+     default:
+         ASSERT_NOT_REACHED();
+     }",nit: inconsistent spacing around =,"`ptr_uint_t` is a 32-bit value, so this should be just `ptr_uint_t`."
+1162,"@@ -12,7 +12,6 @@
+ namespace Sonata\MediaBundle\Model;
+
+ use Imagine\Image\Box;
+-use Sonata\ClassificationBundle\Model\CategoryInterface;
+ use Symfony\Component\Validator\Context\ExecutionContextInterface;
+ use Symfony\Component\Validator\ExecutionContextInterface as LegacyExecutionContextInterface;
+ ",We still need this import,Why did you remove this?
+1163,"@@ -60,7 +60,7 @@ public class TestBinPackStrategy extends TableTestBase {
+     }
+
+     @Override
+-    public Set<DataFile> rewriteFiles(String groupId, List<FileScanTask> filesToRewrite) {
++    public Set<DataFile> rewriteFiles(List<FileScanTask> filesToRewrite) {
+       throw new UnsupportedOperationException();
+     }
+   }","We are pulling this because we removed ""groupID"" state and put it into the strategy implementations",I think we need to keep the old method signature as well for backwards compatibility.
+1164,"@@ -17,8 +17,7 @@
+ #include <CL/sycl.hpp>
+
+ #include ""gtest/gtest.h""
+-#define ONEAPI_DAL_DATA_PARALLEL
+-#include ""oneapi/dal/algo/kmeans_init.hpp""
++#include ""oneapi/dal/algo/kmeans_init/compute.hpp""
+ #include ""oneapi/dal/table/homogen.hpp""
+ #include ""oneapi/dal/table/row_accessor.hpp""
+ ",Is this file actually related to PCA?,Is there a reason for this change?
+1165,"@@ -6,7 +6,7 @@ import createEnableTracking from './createEnableTracking';
+ import createTrackEvent from './createTrackEvent';
+
+ const DEFAULT_CONFIG = {
+-	isFirstAdmin: false,
++	isOwner: false,
+ 	trackingEnabled: false,
+ 	trackingID: '',
+ 	referenceSiteURL: '',","See above, this should probably remain `isFirstAdmin`.",Why did you change the default val
+1166,"@@ -499,7 +499,7 @@ type ArrayExpression struct {
+
+ 	Elements []Expression
+
+-	typ MonoType
++	Type MonoType
+ }
+
+ func (*ArrayExpression) NodeType() string { return ""ArrayExpression"" }",Why the change to make it public? The expression interface has the `TypeOf` method?,This was not captured as part of t
+1167,"@@ -1562,7 +1562,7 @@ namespace NLog.UnitTests.Targets
+         }
+
+         [Fact]
+-        public void Single_Archive_File_Rolls_Correctly()
++        public void SingleArchiveFileRollsCorrectly()
+         {
+             var tempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+             var tempFile = Path.Combine(tempPath, ""file.txt"");","don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO",@aparajit-pratap @mjkkirschner I t
+1168,"@@ -28,6 +28,11 @@ type identityRegistrationDto struct {
+ 	Registered bool `json:""registered""`
+ }
+
++type identityUnlockingDto struct {
++	Id         string `json:""id""`
++	Passphrase string `json:""passphrase""`
++}
++
+ type identitiesApi struct {
+ 	idm             identity.IdentityManagerInterface
+ 	mysteriumClient server.Client",`Id` defines REST resource address and should not be in payload,should `Id` and `Passphrase` be in the `IdentityManager` struct?
+1169,"@@ -20,8 +20,11 @@ def main():
+         nargs='+',
+         default=[100, 300, 1000],
+         help='proposal numbers, only used for recall evaluation')
++    parser.add_argument(
++        '--class_wise', action='store_true', help='whether eval class wise ap')
+     args = parser.parse_args()
+-    coco_eval(args.result, args.types, args.ann, args.max_dets)
++    coco_eval(args.result, args.types, args.ann, args.max_dets,
++              args.class_wise)
+
+
+ if __name__ == '__main__':",We can omit the underscore and just use `classwise`.,why do we need this? can't we just infer `args.class_wise` from
+1170,"@@ -77,10 +77,12 @@ class MediaAdminController extends Controller
+         $datagrid->setValue('context', null, $context);
+
+         // retrieve the main category for the tree view
+-        $category = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);
++        $rootCategory = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);
++        // This should be safe as the root category has to exist for a given context but I do not like fatal errors
++        $rootCategoryId = !empty($rootCategory) ? $rootCategory->getId() : null;
+
+         if (!$filters) {
+-            $datagrid->setValue('category', null, $category);
++            $datagrid->setValue('category', null, $rootCategoryId);
+         }
+         if ($request->get('category')) {
+             $categoryByContext = $this->container->get('sonata.classification.manager.category')->findOneBy(array(",Why not throw an exception instead then?,Wouldn't it be better to pass `$rootCategory->getId()` in the `g
+1171,"@@ -71,8 +71,7 @@ abstract class DataIterator<T> implements CloseableIterator<T> {
+
+   InputFile getInputFile(FileScanTask task) {
+     Preconditions.checkArgument(!task.isDataTask(), ""Invalid task type"");
+-
+-    return inputFiles.get(task.file().path().toString());
++    return getInputFile(task.file().path().toString());
+   }
+
+   InputFile getInputFile(String location) {",Looks like this doesn't need to change. Can you revert this?,"I think you can remove the whole `FileScanTask` class now, it's "
+1172,"@@ -3,6 +3,7 @@ import sys
+ from cliquet.scripts import cliquet
+ from pyramid.scripts import pserve
+ from pyramid.paster import bootstrap
++from config import template
+
+ CONFIG_FILE = 'config/kinto.ini'
+ ",please import it like `from kinto.config import template`,"`cliquet.scripts.template` is no longer used in this file, it should be removed."
+1173,"@@ -173,7 +173,7 @@ public final class Configuration {
+   }
+
+   public boolean isIsolationFilterOpen(String microservice) {
+-    String p = getStringProperty(""false"",
++    String p = getStringProperty(""true"",
+         PROP_ROOT + microservice + ""."" + FILTER_ISOLATION + FILTER_OPEN,
+         PROP_ROOT + FILTER_ISOLATION + FILTER_OPEN);
+     return Boolean.parseBoolean(p);","There are lots of default value changed, not sure if it break the old behavior.",Why did you change this from false to true?
+1174,"@@ -10,13 +10,15 @@ import (
+ 	""context""
+ 	""encoding/hex""
+ 	""math/big""
++	""net""
++	""strconv""
+
+-	""github.com/golang/protobuf/jsonpb""
+ 	""github.com/golang/protobuf/proto""
+-	peerstore ""github.com/libp2p/go-libp2p-peerstore""
+ 	""github.com/pkg/errors""
+ 	""github.com/prometheus/client_golang/prometheus""
+ 	""go.uber.org/zap""
++	""google.golang.org/grpc""
++	""google.golang.org/grpc/reflection""
+
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/actpool""",File is not `goimports`-ed (from `goimports`),doesn't have to be in this PR but we should start switching to goimports
+1175,"@@ -29,9 +29,9 @@ namespace Nethermind.Cli.Modules
+         public object[] Peers() => NodeManager.Post<object[]>(""admin_peers"").Result;
+
+         [CliFunction(""admin"", ""addPeer"")]
+-        public string AddPeer(string enode) => NodeManager.Post<string>(""admin_addPeer"", enode).Result;
++        public string AddPeer(string enode, bool addToStaticNodes = false) => NodeManager.Post<string>(""admin_addPeer"", enode, addToStaticNodes).Result;
+
+         [CliFunction(""admin"", ""removePeer"")]
+-        public string RemovePeer(string enode) => NodeManager.Post<string>(""admin_removePeer"", enode).Result;
++        public string RemovePeer(string enode, bool addToStaticNodes = false) => NodeManager.Post<string>(""admin_removePeer"", enode, addToStaticNodes).Result;
+     }
+ }",parameter should be called removeFromStaticNodes,why not use `addPeer` as the default argument?
+1176,"@@ -221,7 +221,9 @@ class RequestContext:
+ ServiceRequestHandler = Callable[[RequestContext, ServiceRequest], Optional[ServiceResponse]]
+
+
+-def handler(operation: str = None, context: bool = True, expand: bool = True):
++def handler(
++    operation: str = None, context: bool = True, expand: bool = True, override: bool = False
++):
+     """"""
+     Decorator that indicates that the given function is a handler
+     """"""","The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto.","As `override` is not a very descriptive argument name, I would call it `secure` or something like that instead of `override`."
+1177,"@@ -14,6 +14,18 @@ class Subscription < ActiveRecord::Base
+     notifier.send_notifications
+   end
+
++  def active?
++    deactivated_on.nil?
++  end
++
++  def deactivate
++    update_column(:deactivated_on, Date.today)
++  end
++
++  def activate
++    update_column(:deactivated_on, nil)
++  end
++
+   private
+
+   def self.subscriber_emails","Is this method actually being used anywhere? If not, I think we should remove it.",What's the difference between `active?` and `deactivated_on` here?
+1178,"@@ -400,7 +400,7 @@ namespace AutoRest.Extensions
+                 {
+                     var bodyParameterType = bodyParameter.ModelType as CompositeType;
+                     if (bodyParameterType != null &&
+-                        (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant) <= Settings.Instance.PayloadFlatteningThreshold ||
++                        (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant && !p.IsReadOnly) <= Settings.Instance.PayloadFlatteningThreshold ||
+                          bodyParameter.ShouldBeFlattened()))
+                     {
+                         var parameterTransformation = new ParameterTransformation",Thanks! I somehow lost this between my far too many branchs.,Do we need this `!p.IsReadOnly` check?
+1179,"@@ -30,13 +30,14 @@ import socket
+ import sys
+
+ from .firefox_binary import FirefoxBinary
++from .options import Options
+ from .remote_connection import FirefoxRemoteConnection
+ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+ from selenium.webdriver.firefox.extension_connection import ExtensionConnection
+ from selenium.webdriver.firefox.firefox_profile import FirefoxProfile
+ from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
+ from .service import Service
+-from .options import Options
++from .webelement import FirefoxWebElement
+
+
+ class WebDriver(RemoteWebDriver):",i think this should get put into its own file. This could start to grow :),Can we move `from selenium.webdriver.firefox import FirefoxWebElement` and `from selenium.webdriver.firefox.extension_connect
+1180,"@@ -39,6 +39,13 @@ const (
+ 	// variable containers' config, which will be used by the AWS SDK to fetch
+ 	// credentials.
+ 	awsSDKCredentialsRelativeURIPathEnvironmentVariableName = ""AWS_CONTAINER_CREDENTIALS_RELATIVE_URI""
++	// pauseContainerName is the internal name for the pause container
++	pauseContainerName = ""~internal~ecs~pause""
++	// pauseContainerImage is container image used to create the pause container
++	// TODO: Modify this to amazon/amazon-ecs-pause or something similar
++	pauseContainerImage = ""gcr.io/google_containers/pause:latest""
++	// networkModeNone specifies the string used to define the `none` docker networking mode
++	networkModeNone = ""none""
+ )
+
+ // TaskOverrides are the overrides applied to a task",Can you add a TODO for loading the tarball of the pause image into Docker?,Shouldn't this be `~internal/amazon-ecs-pause`?
+1181,"@@ -259,7 +259,6 @@ public class ProcessJob extends AbstractProcessJob {
+         }
+         throw new RuntimeException(e);
+       } finally {
+-        this.process = null;
+         info(""Process completed ""
+             + (success ? ""successfully"" : ""unsuccessfully"") + "" in ""
+             + ((System.currentTimeMillis() - startMs) / 1000) + "" seconds."");",Is there any value in setting the process to null like this?,process is set to null after the exception is t
+1182,"@@ -35,6 +35,14 @@ void SoftmaxWithLossLayer<Dtype>::Reshape(
+     const vector<Blob<Dtype>*>& bottom, const vector<Blob<Dtype>*>& top) {
+   LossLayer<Dtype>::Reshape(bottom, top);
+   softmax_layer_->Reshape(softmax_bottom_vec_, softmax_top_vec_);
++  softmax_axis_ = this->layer_param_.softmax_param().axis();
++  outer_num_ = bottom[0]->count(0, softmax_axis_);
++  inner_num_ = bottom[0]->count(softmax_axis_ + 1);
++  CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count())
++      << ""Number of labels must match number of predictions; ""
++      << ""e.g., if softmax axis == 1 and prediction shape is (N, C, H, W), ""
++      << ""label count (number of labels) must be N*H*W, ""
++      << ""with integer values in {0, 1, ..., C-1}."";
+   if (top.size() >= 2) {
+     // softmax output
+     top[1]->ReshapeLike(*bottom[0]);",This could be a good time to add a check that the prediction and target dimensions (except channel) agree?,"You don't need this variable here, you can just"
+1183,"@@ -3920,6 +3920,11 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb)
+             if (!bb_process_interrupt(dcontext, bb))
+                 break;
+         }
++#ifdef AARCH64
++        /* OP_isb, when mangled, has a potential side exit. */
++        else if (instr_get_opcode(bb->instr) == OP_isb)
++            break;
++#endif
+ #if 0/*i#1313, i#1314*/
+         else if (instr_get_opcode(bb->instr) == OP_getsec) {
+             /* XXX i#1313: if we support CPL0 in the future we'll need to","The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs.","Not a big deal, but why don't we have an `else "
+1184,"@@ -83,7 +83,7 @@ define([""userSettings""], function (userSettings) {
+
+             if (html += '<div class=""listPaging"">', showControls) {
+                 html += '<span style=""vertical-align:middle;"">';
+-                html += (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd + "" of "" + totalRecordCount;
++                html += Globalize.translate(""ListPaging"").replace(""{0}"", (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd).replace(""{1}"", totalRecordCount);
+                 html += ""</span>"";
+             }
+ ",The translate library has a method to replace the variables.,"Looks like a typo, should be `ListPaging`"
+1185,"@@ -155,6 +155,18 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         with self.assertRaisesRegex(TypeError, msg):
+             ds.isin(1)
+
++    def test_fillna(self):
++        ps = pd.Series([np.nan, 2, 3, 4, np.nan, 6], name='x')
++        ks = koalas.from_pandas(ps)
++
++        self.assert_eq(ks.fillna(0), ps.fillna(0))
++        self.assert_eq(ks.fillna(0, inplace=True), ps.fillna(0, inplace=True))
++        self.assert_eq(ks.fillna({'x': 0}), ps.fillna({'x': 0}))
++
++        s_nan = pd.Series([0], index=['x'], dtype=int)
++        self.assert_eq(ks.fillna(s_nan),
++                       ps.fillna(s_nan))
++
+     def test_dropna(self):
+         ps = pd.Series([np.nan, 2, 3, 4, np.nan, 6], name='x')
+ ","i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following ""ks"" because ks has been changed.",The unit tests should be in `test_fillna_
+1186,"@@ -124,6 +124,7 @@ with outfile.open(""w"") as f, contextlib.redirect_stdout(f):
+             tls.TlsClienthelloHook,
+             tls.TlsStartClientHook,
+             tls.TlsStartServerHook,
++            tls.TlsHandshakeHook,
+         ]
+     )
+ ","Any proposals how to make the naming somehow include the ""completed"" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?",Does this need to be added to the end of
+1187,"@@ -157,6 +157,7 @@ namespace Nethermind.Blockchain.Synchronization
+
+                 if (headersSynced > 0)
+                 {
++                    _blockTree.Flush();
+                     _syncReport.FullSyncBlocksDownloaded.Update(_blockTree.BestSuggestedHeader?.Number ?? 0);
+                     _syncReport.FullSyncBlocksKnown = bestPeer.HeadNumber;
+                 }","it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?",Why are we flushing here?
+1188,"@@ -220,10 +220,10 @@ class JSTree extends AbstractBase
+             if ('collection' === $type && !$this->collectionsEnabled) {
+                 $type = 'record';
+             }
+-            $url = $this->getUrlFromRouteCache($type, $node->id);
++            $url = $this->getUrlFromRouteCache($type, urlencode($node->id));
+             return $type === 'collection'
+                 ? $url . '#tabnav'
+-                : $url . '#tree-' . preg_replace('/\W/', '-', $node->id);
++                : $url . '#tree-' . preg_replace('/\W/', '-', urlencode($node->id));
+         }
+     }
+ ","There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?",The `urlencode` should be moved out of the `getUrlFromRouteCache` method.
+1189,"@@ -142,7 +142,11 @@ class EditorManager {
+
+     if (editorClass) {
+       this.activeEditor = getEditorInstance(editorClass, this.instance);
++      this.activeEditor.row = row; // pre-preparation needed by getEditedCell
++      this.activeEditor.col = col;
+       const td = this.activeEditor.getEditedCell();
++      this.activeEditor.row = null; // restore the un-initialized state
++      this.activeEditor.col = null;
+       this.activeEditor.prepare(row, col, prop, td, originalValue, cellProperties);
+
+     } else {",Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?,Please don't initialize `this.activeEditor.row` and `this.activeEditor.co
+1190,"@@ -280,7 +280,11 @@ func (cs *ChainService) HandleAction(_ context.Context, actPb *iotextypes.Action
+ 	if err := act.LoadProto(actPb); err != nil {
+ 		return err
+ 	}
+-	return cs.actpool.Add(act)
++	err := cs.actpool.Add(act)
++	if err != nil {
++		log.L().Info(err.Error())
++	}
++	return err
+ }
+
+ // HandleBlock handles incoming block request.",Change this to Debug Level,"this will log L() very often, if we are not going to want to L() it would"
+1191,"@@ -521,9 +521,9 @@ namespace NLog.Targets
+             {
+                 _allLayoutsAreThreadSafe = _allLayouts.All(layout => layout.ThreadSafe);
+             }
+-            StackTraceUsage = _allLayouts.DefaultIfEmpty().Max(layout => layout?.StackTraceUsage ?? StackTraceUsage.None);
+-            if (this is IUsesStackTrace usesStackTrace && usesStackTrace.StackTraceUsage > StackTraceUsage)
+-                StackTraceUsage = usesStackTrace.StackTraceUsage;
++            StackTraceUsage = _allLayouts.DefaultIfEmpty().Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));
++            if (this is IUsesStackTrace usesStackTrace)
++                StackTraceUsage |= usesStackTrace.StackTraceUsage;
+             _scannedForLayouts = true;
+         }
+ ","I refactored the Aggregate, those are hard to read","I'm not sure what the best way to do this is, but it seems like overkill "
+1192,"@@ -290,14 +290,6 @@ describe('region', function() {
+     assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+   });
+
+-  it('treats iframe elements as regions', function() {
+-    var checkArgs = checkSetup(
+-      '<iframe id=""target""></iframe><div role=""main"">Content</div>'
+-    );
+-
+-    assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+-  });
+-
+   it('returns the outermost element as the error', function() {
+     var checkArgs = checkSetup(
+       '<div id=""target""><p>This is random content.</p></div><div role=""main""><h1 id=""mainheader"" tabindex=""0"">Introduction</h1></div>'","This is now done in the after method, so this test won't pass any more.",why remove this?
+1193,"@@ -152,10 +152,14 @@ class ApplicationController < ActionController::Base
+     # have we identified the user?
+     if @user
+       # check if the user has been banned
+-      if @user.blocks.active.exists?
+-        # NOTE: need slightly more helpful message than this.
++      user_block =  @user.blocks.active.take
++      unless user_block.nil?
+         set_locale
+-        report_error t(""application.setup_user_auth.blocked""), :forbidden
++        if  @user.blocks.active.take.zero_hour?
++          report_error  t(""application.setup_user_auth.blocked_zero_hour""), :forbidden
++        else
++          report_error t(""application.setup_user_auth.blocked""), :forbidden
++        end
+       end
+
+       # if the user hasn't seen the contributor terms then don't",What was the point of creating `user_block` if you're then not going to use it ;-),Unnecessary spac
+1194,"@@ -22,9 +22,6 @@ from decorator import decorator
+ import types
+ import logging
+
+-from databricks.koalas.frame import PandasLikeDataFrame
+-from databricks.koalas.series import PandasLikeSeries
+-
+ logger = logging.getLogger('spark')
+
+ _TOUCHED_TEST = ""_pandas_updated""","@ueshin, I thought we can remove this entire file. Does that require some more works?",let's get rid of
+1195,"@@ -39,7 +39,7 @@ def evaluateTokens(requestContext, tokens):
+       return float(tokens.number.scientific[0])
+
+   elif tokens.string:
+-    return str(tokens.string)[1:-1]
++    return unicode(tokens.string)[1:-1]
+
+   elif tokens.boolean:
+     return tokens.boolean[0] == 'true'",Just `return tokens.string[1:-1]` is enough,@JukkaL this onl
+1196,"@@ -0,0 +1,3 @@
++resources :quizzes, only: [:show] do
++  resources :questions, only: [:show]
++end",1 trailing blank lines detected.,@alexander-schranz should this be `only: [:show]`?
+1197,"@@ -29,7 +29,7 @@ public class LeftButton extends Button {
+         super(name);
+         this.name = name;
+         this.getStyleClass().add(""leftButton"");
+-        this.setPrefWidth(Double.MAX_VALUE);
++        this.setMaxWidth(Double.MAX_VALUE);
+         this.setAlignment(Pos.CENTER_LEFT);
+         this.setPadding(new Insets(2));
+     }",Isn't this the default max width? In any case I would prefer to see these definitions in the css files.,PrefWidth is set in parent class `Button` so it sh
+1198,"@@ -34,10 +34,11 @@ func redirParse(c *caddy.Controller) ([]Rule, error) {
+ 	cfg := httpserver.GetConfig(c)
+
+ 	initRule := func(rule *Rule, defaultCode string, args []string) error {
+-		if cfg.TLS.Enabled {
+-			rule.FromScheme = ""https""
+-		} else {
+-			rule.FromScheme = ""http""
++		rule.FromScheme = func() string {
++			if cfg.TLS.Enabled {
++				return ""https""
++			}
++			return ""http""
+ 		}
+
+ 		var (","Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)",I don't think you need the else now. You can just
+1199,"@@ -21,8 +21,8 @@
+ # IN THE SOFTWARE.
+ #-------------------------------------------------------------------------------
+ from datatable.lib._datatable import (
+-	Ftrl,
+ 	aggregate,
++	Ftrl,
+ 	kfold,
+ 	kfold_random,
+ )",Looks like this file has tabs instead of spaces.,nit: can you revert the extra removal of the comma
+1200,"@@ -649,6 +649,19 @@ func (engine *DockerTaskEngine) deleteTask(task *apitask.Task) {
+ 		}
+ 	}
+
++	for _, container := range task.Containers {
++		for _, resource := range container.GetResources() {
++			err := resource.Cleanup()
++			if err != nil {
++				seelog.Warnf(""Task engine [%s]/[%s]: unable to cleanup resource %s: %v"",
++					task.Arn, container.Name, resource.GetName(), err)
++			} else {
++				seelog.Infof(""Task engine [%s]/[%s]: resource %s cleanup complete"",
++					task.Arn, container.Name, resource.GetName())
++			}
++		}
++	}
++
+ 	if execcmd.IsExecEnabledTask(task) {
+ 		// cleanup host exec agent log dirs
+ 		if tID, err := task.GetID(); err != nil {",Hmm should we clean up container resources before task resources here? or the order does not really matter here?,"Just curious why this is an info log, shouldn't this be an error?"
+1201,"@@ -44,7 +44,6 @@ def temporary_download_dir(quteproc, tmpdir):
+     unwritable.ensure(dir=True)
+     unwritable.chmod(0)
+
+-
+ @bdd.given(""I clean old downloads"")
+ def clean_old_downloads(quteproc):
+     quteproc.send_cmd(':download-cancel --all')",Please undo this :wink:,nit: unrelated change?
+1202,"@@ -25,6 +25,12 @@ class ApiClient < ActiveRecord::Base
+   include DeviseInvitable::Inviter
+   include ValidationMessages
+
++  # ================
++  # = Associations =
++  # ================
++
++  has_many :plans
++
+   # If the Client_id or client_secret are nil generate them
+   before_validation :generate_credentials,
+                     if: Proc.new { |c| c.client_id.blank? || c.client_secret.blank? }",thanks for adding this missing association,Is this related to this PR?
+1203,"@@ -11,6 +11,11 @@ namespace Microsoft.AspNet.Server.Kestrel.Https
+     public static class HttpsApplicationBuilderExtensions
+     {
+         public static IApplicationBuilder UseKestrelHttps(this IApplicationBuilder app, X509Certificate2 cert)
++        {
++            return app.UseKestrelHttps(new HttpsConnectionFilterOptions { ServerCertificate = cert});
++        }
++
++        public static IApplicationBuilder UseKestrelHttps(this IApplicationBuilder app, HttpsConnectionFilterOptions options)
+         {
+             var serverInfo = app.ServerFeatures.Get<IKestrelServerInformation>();
+ ",Should I remove this in favor of the HttpsConnectionFilterOptions overload?,We should just pass the options object here.
+1204,"@@ -109,6 +109,15 @@ class DbalStatusQuery implements StatusQueryInterface
+         return array_values($result);
+     }
+
++    public function getMaxIndex(): ?int
++    {
++        return $this->connection->createQueryBuilder()
++            ->select('max(index)')
++            ->from(self::STATUS_TABLE)
++            ->execute()
++            ->fetchOne();
++    }
++
+     private function getQuery(Language $language): QueryBuilder
+     {
+         return $this->connection->createQueryBuilder()","This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme",Could you remove this method? It's not used anywhere.
+1205,"@@ -32,6 +32,10 @@ class Auth extends Controller
+     public function __construct()
+     {
+         parent::__construct();
++
++		// Add JS File to unistall SW to avoid Cookie Cache Issues when Signin, see github issue: #3707
++		$this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js');
++
+         $this->layout = 'auth';
+     }
+ ",Spaces not tabs,Why do we need to add a file here?
+1206,"@@ -160,6 +160,15 @@ class FsDriverNode extends FsDriverBase {
+ 		}
+ 	}
+
++	async readDir(path) {
++		try {
++			// return fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10
++			return fs.readdirSync(path); // For Node v8
++		} catch (error) {
++			throw this.fsErrorToJsError_(error, path);
++		}
++	}
++
+ 	// Always overwrite destination
+ 	async copy(source, dest) {
+ 		try {","To get the files inside a directory, please use `readDirStats()`.",remove this method and use `fs.readdir` directly in t
+1207,"@@ -34,8 +34,11 @@ const LocalConfigFileName string = "".plzconfig.local""
+ // for a particular machine (eg. build machine with different caching behaviour).
+ const MachineConfigFileName = ""/etc/plzconfig""
+
+-const TestContainerDocker = ""docker""
+-const TestContainerNone = ""none""
++const (
++	ContainerImplementationNone   = ""none""
++	ContainerImplementationDocker = ""docker""
++	ContainerImplementationPlz    = ""plz""
++)
+
+ func readConfigFile(config *Configuration, filename string) error {
+ 	log.Debug(""Reading config from %s..."", filename)","might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things","can drop the `= """"`"
+1208,"@@ -0,0 +1,5 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package batchstore_test","File is empty, consider removing?",why are we doing this?
+1209,"@@ -237,6 +237,16 @@ def _refresh_credentials():
+     return result
+
+
++def logged_in():
++    """"""
++    Return registry URL if Quilt client is authenticated. Otherwise
++    return `None`.
++    """"""
++    url = get_registry_url()
++    if url in _load_auth():
++        return url
++
++
+ class QuiltProvider(CredentialProvider):
+     METHOD = 'quilt-registry'
+     CANONICAL_NAME = 'QuiltRegistry'","This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful.",Is it possible that `g
+1210,"@@ -23,8 +23,9 @@ type Config struct {
+ 	L1CrossDomainMessengerAddress common.Address
+ 	L1FeeWalletAddress            common.Address
+ 	AddressManagerOwnerAddress    common.Address
+-	L1ETHGatewayAddress           common.Address
+ 	GasPriceOracleOwnerAddress    common.Address
++	L1StandardBridgeAddress       common.Address
++	GasPriceOracleAddress         common.Address
+ 	// Turns on checking of state for L2 gas price
+ 	EnableL2GasPolling bool
+ 	// Deployment Height of the canonical transaction chain",Was the addition of `GasPriceOracleAddress` here erroneous?,Why was this renamed?
+1211,"@@ -121,6 +121,11 @@ module Beaker
+           :project                => 'Beaker',
+           :department             => 'unknown',
+           :created_by             => ENV['USER'] || ENV['USERNAME'] || 'unknown',
++          :host_tags              => {
++                                      :project    => 'Beaker',
++                                      :department => 'unknown',
++                                      :created_by => ENV['USER'] || ENV['USERNAME'] || 'unknown'
++          },
+           :openstack_api_key      => ENV['OS_PASSWORD'],
+           :openstack_username     => ENV['OS_USERNAME'],
+           :openstack_auth_url     => ""#{ENV['OS_AUTH_URL']}/tokens"",","I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department].",Use the new Ruby 1.9 h
+1212,"@@ -149,8 +149,12 @@ public class SessionStore implements
+         if (BuildConfig.DEBUG) {
+             mStoreSubscription = ComponentsAdapter.get().getStore().observeManually(browserState -> {
+                 Log.d(LOGTAG, ""Session status BEGIN"");
+-                browserState.getTabs().forEach(tabSessionState -> Log.d(LOGTAG, ""BrowserStore Session: "" + tabSessionState.getId()));
+-                mSessions.forEach(session -> Log.d(LOGTAG, ""SessionStore Session: "" + session.getId()));
++                for (int i=0; i<browserState.getTabs().size(); i++) {
++                    Log.d(LOGTAG, ""BrowserStore Session: "" + browserState.getTabs().get(i).getId());
++                }
++                for (int i=0; i<mSessions.size(); i++) {
++                    Log.d(LOGTAG, ""SessionStore Session: "" + mSessions.get(i).getId());
++                }
+                 Log.d(LOGTAG, ""Session status END"");
+                 return null;
+             });",How was this causing the exception?,`for (int i = 0; i < mSessions.size(); i++)`
+1213,"@@ -57,6 +57,12 @@ define(['connectionManager', 'userSettings', 'events'], function (connectionMana
+             currentDateTimeCulture = currentCulture;
+         }
+         ensureTranslations(currentCulture);
++        // FIXME: See GH #1027 and #913. This should be configurable and not strictly based on locale.
++        if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk') {
++            require([""css!jellyfin-noto/css/TC""]);
++        } else {
++            require([""css!jellyfin-noto/css/SC""]);
++        }
+     }
+
+     function ensureTranslations(culture) {","I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case.","`require([""css!jellyfin-noto/css/SC""]);` sho"
+1214,"@@ -96,7 +96,7 @@ class MultiTermIntervalsSource extends IntervalsSource {
+
+   @Override
+   public void visit(String field, QueryVisitor visitor) {
+-
++    visitor.visitLeaf(new IntervalQuery(field, this));
+   }
+
+   @Override",Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer.,Why not just add `visitLeaf`?
+1215,"@@ -9,11 +9,11 @@ class CancellationAlternative
+   end
+
+   def discount_percentage_vs_current_plan_annualized
+-    ((1 - (@discounted_plan.price / (@current_plan.price * 12.0))) * 100).
++    ((1 - (@discounted_plan.price_in_dollars / (@current_plan.price_in_dollars * 12.0))) * 100).
+       round(0)
+   end
+
+   def discount_plan_price
+-    @discounted_plan.price
++    @discounted_plan.price_in_dollars
+   end
+ end",Line is too long. [96/80],Omit parentheses for ternary conditions.
+1216,"@@ -167,6 +167,9 @@ func (s *Solver) buildDefaultPod(ch *cmacme.Challenge) *corev1.Pod {
+ 			OwnerReferences: []metav1.OwnerReference{*metav1.NewControllerRef(ch, challengeGvk)},
+ 		},
+ 		Spec: corev1.PodSpec{
++			NodeSelector: map[string]string{
++				""kubernetes.io/os"": ""linux"",
++			},
+ 			RestartPolicy: corev1.RestartPolicyOnFailure,
+ 			Containers: []corev1.Container{
+ 				{","My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?","I think this is a more correct approach than what we usually do, but I don't have a better suggestion."
+1217,"@@ -24,7 +24,7 @@ import (
+ type Controller string
+
+ type Object struct {
+-	Object v1alpha1.InnerObject
++	Object v1alpha1.InnerObjectWithSelector
+ 	Name   string
+ }
+ ","Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`",Is this a breaking change? I don't think we can do this.
+1218,"@@ -20,8 +20,12 @@ var (
+ 	once    sync.Once
+ )
+
+-// GetContext gets global context instance
+-func GetContext(contextType string) *Context {
++func init()  {
++	InitContext(MsgCtxTypeChannel)
++}
++
++// InitContext gets global context instance
++func InitContext(contextType string) {
+ 	once.Do(func() {
+ 		context = &Context{}
+ 		switch contextType {",Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly.,Do we still need `MsgCtxTypeChannel`?
+1219,"@@ -619,6 +619,14 @@ class WebDriver(object):
+         else:
+             return self.execute(Command.GET_WINDOW_HANDLES)['value']
+
++    def minimize_window(self):
++        """"""
++        Miniimizes the current window that webdriver is using
++        """"""
++        if self.w3c:
++            command = Command.W3C_MINIMIZE_WINDOW
++            self.execute(command, {""windowHandle"": ""current""})
++
+     def maximize_window(self):
+         """"""
+         Maximizes the current window that webdriver is using",This `if` is not necessary,Let's rename this to `minimize_current_window`.
+1220,"@@ -255,6 +255,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 		// (as above, don't diff props during hydration)
+ 		if (!isHydrating) {
+ 			if (('value' in newProps) && newProps.value!==undefined && newProps.value !== dom.value) dom.value = newProps.value==null ? '' : newProps.value;
++			// preact/#1899
++			// We need this value for input masking.
++			dom._lastValue = dom.value;
++
+ 			if (('checked' in newProps) && newProps.checked!==undefined && newProps.checked !== dom.checked) dom.checked = newProps.checked;
+ 		}
+ 	}","should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (""next state"").",Looks like this should be inside the `if (('value' in newProps) && newProps.value !== dom._lastValue) {` block.
+1221,"@@ -717,6 +717,7 @@ module Beaker
+         args << ""--parseonly"" if opts[:parseonly]
+         args << ""--trace"" if opts[:trace]
+         args << ""--parser future"" if opts[:future_parser]
++        args << ""--modulepath #{opts[:modulepath]}"" if opts[:modulepath]
+
+         # From puppet help:
+         # ""... an exit code of '2' means there were changes, an exit code of",Please update the yard docs to indicate this new option.,The `--modulepath` flag is also present in `puppet.yaml` and `puppet.toml` (see `puppet_config.yml`). Do you ne
+1222,"@@ -52,6 +52,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Scheme sets the scheme of the load balancer (defaults to Internet-facing)
+ 	// +optional
+ 	Scheme *ClassicELBScheme `json:""scheme,omitempty""`
++
++	// Subnets specifies the subnets that should be used by the load balancer
++	// +optional
++	Subnets Subnets `json:""subnets,omitempty""`
+ }
+
+ // AWSClusterStatus defines the observed state of AWSCluster","Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?",Does it matter that these subnets are only used for load balancers?
+1223,"@@ -185,7 +185,10 @@ func initDB(db *gorm.DB, dbType string, log hclog.Logger) (err error) {
+ 		return sqlError.Wrap(err)
+ 	}
+
+-	if err := tx.Assign(Migration{Version: latestSchemaVersion}).FirstOrCreate(&Migration{}).Error; err != nil {
++	if err := tx.Assign(Migration{
++		Version:     latestSchemaVersion,
++		CodeVersion: codeVersion.String(),
++	}).FirstOrCreate(&Migration{}).Error; err != nil {
+ 		tx.Rollback()
+ 		return sqlError.Wrap(err)
+ 	}",It would be great if this could be captured by a test.,I think we need a migration to set the default value for the `CodeVersion` if it doesn't exist.
+1224,"@@ -441,10 +441,15 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int32, isAdvancedVis
+ 		ESIndexMaxResultWindow:            dc.GetIntProperty(dynamicconfig.FrontendESIndexMaxResultWindow, 10000),
+ 		IndexerConcurrency:                dc.GetIntProperty(dynamicconfig.WorkerIndexerConcurrency, 100),
+ 		ESProcessorNumOfWorkers:           dc.GetIntProperty(dynamicconfig.WorkerESProcessorNumOfWorkers, 1),
+-		ESProcessorBulkActions:            dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 1000),
+-		ESProcessorBulkSize:               dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 2<<24), // 16MB
+-		ESProcessorFlushInterval:          dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 1*time.Second),
+-		ESProcessorAckTimeout:             dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
++		// Should be not greater than NumberOfShards(512)/NumberOfHistoryNodes(4) * VisibilityTaskWorkerCount(10) divided by workflow distribution factor (2 at least).
++		// Otherwise, visibility queue processors won't be able to fill up bulk with documents and bulk will flush due to interval, not number of actions.
++		ESProcessorBulkActions: dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 100),
++		// 16MB - just a sanity check. With ES document size ~1Kb it should never be reached.
++		ESProcessorBulkSize: dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 16*1024*1024),
++		// Under high load bulk processor should flush due to number of BulkActions reached.
++		// Although, under small load it would never be the case and bulk processor will flush every this interval.
++		ESProcessorFlushInterval: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 200*time.Millisecond),
++		ESProcessorAckTimeout:    dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
+
+ 		EnableCrossNamespaceCommands: dc.GetBoolProperty(dynamicconfig.EnableCrossNamespaceCommands, true),
+ 	}","1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option",Why do we reduce this back to 512? I think we should keep it around for 10 minutes.
+1225,"@@ -60,5 +60,5 @@ func (a *ChecksumAddress) UnmarshalText(text []byte) error {
+ // MarshalText implements the encoding.TextMarshaler interface
+ func (a ChecksumAddress) MarshalText() (text []byte, err error) {
+ 	addr := basics.Address(a)
+-	return []byte(addr.GetChecksumAddress().String()), nil
++	return []byte(addr.String()), nil
+ }",Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?,This is the main change here. `GetChecksumAddress` returns the checksum of the addr
+1226,"@@ -248,7 +248,7 @@ events.on(serverNotifications, 'RestartRequired', function (e, apiClient) {
+         [
+             {
+                 action: 'restart',
+-                title: globalize.translate('ButtonRestart'),
++                title: globalize.translate('HeaderRestart'),
+                 icon: getIconUrl()
+             }
+         ];","Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general.",Is it possible to keep the title and icon in the same string?
+1227,"@@ -1250,7 +1250,7 @@ namespace Nethermind.Blockchain
+
+         public Keccak HeadHash => Head?.Hash;
+         public Keccak GenesisHash => Genesis?.Hash;
+-        public Keccak PendingHash => BestSuggestedHeader?.Hash;
++        public Keccak PendingHash => Head?.Hash;
+
+         public Block FindBlock(Keccak blockHash, BlockTreeLookupOptions options)
+         {","I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?","Since `PendingHash` is public, it should have `?.Hash` suffix"
+1228,"@@ -206,6 +206,7 @@ type SyncStatus struct {
+ type SyncSetCommonSpec struct {
+ 	// Resources is the list of objects to sync from RawExtension definitions.
+ 	// +optional
++	// +kubebuilder:pruning:PreserveUnknownFields
+ 	Resources []runtime.RawExtension `json:""resources,omitempty""`
+
+ 	// ResourceApplyMode indicates if the Resource apply mode is ""Upsert"" (default) or ""Sync"".",This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it.,@deads2k I'm not sure if this was a mistake or a bug. Do you know?
+1229,"@@ -2,8 +2,10 @@ class Topic < ActiveRecord::Base
+   # Associations
+   has_many :classifications
+   with_options(through: :classifications, source: :classifiable) do |options|
++    options.has_many :exercises, source_type: 'Exercise'
+     options.has_many :products, source_type: 'Product'
+     options.has_many :topics, source_type: 'Topic'
++    options.has_many :videos, source_type: 'Video'
+     options.has_many :workshops, source_type: 'Workshop'
+   end
+   has_one :trail",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted strings unless you need single quotes to avoi
+1230,"@@ -38,7 +38,7 @@
+ #include ""common/xutil.h""
+ #include ""xkb.h""
+
+-/* XStringToKeysym() and XKeysymToString */
++/* XStringToKeysym() */
+ #include <X11/Xlib.h>
+ #include <xkbcommon/xkbcommon.h>
+ #include <glib.h>",Some day (tm) I will also get rid of that one. But today is not that day...,Please remove this.
+1231,"@@ -206,6 +206,17 @@ class CombineAssets
+         // Disable cache always
+         $this->storagePath = null;
+
++        // Prefix all assets
++        if($localPath) {
++            if (substr($localPath, -1) !== '/') {
++                $localPath = $localPath.'/';
++            }
++            $assets = array_map(function($asset) use ($localPath) {
++                if (substr($asset, 0, 1) === '@') return $asset;
++                return $localPath.$asset;
++            }, $assets);
++        }
++
+         list($assets, $extension) = $this->prepareAssets($assets);
+
+         $rewritePath = File::localToPublic(dirname($destination));",Add a space between if and opening parenthesis please (i.e. `if (`),Please use `File::isAbsolutePath($localPath)`.
+1232,"@@ -827,8 +827,9 @@ class Series(_Frame, IndexOpsMixin, Generic[T]):
+         Name: my_name, dtype: int64
+         """"""
+         if index is None:
+-            return self
+-        scol = self._scol.alias(index)
++            scol = self._scol
++        else:
++            scol = self._scol.alias(index)
+         if kwargs.get('inplace', False):
+             self._internal = self._internal.copy(scol=scol)
+             return self",nit: `rename` instead of `alias`?,This is a bug fix. Can you open a separate PR for it?
+1233,"@@ -113,11 +113,17 @@ func (d *Driver) freeDevices() (string, string, error) {
+ 		return """", """", err
+ 	}
+ 	devPrefix := ""/dev/sd""
++
+ 	for _, dev := range self.BlockDeviceMappings {
+ 		if dev.DeviceName == nil {
+ 			return """", """", fmt.Errorf(""Nil device name"")
+ 		}
+ 		devName := *dev.DeviceName
++
++		// sda1 is reserved for the root device, skip
++		if devName == ""/dev/sda1"" {
++			continue
++		}
+ 		if !strings.HasPrefix(devName, devPrefix) {
+ 			devPrefix = ""/dev/xvd""
+ 			if !strings.HasPrefix(devName, devPrefix) {",Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped.,"If the root device is sda1, shouldn't we report an er"
+1234,"@@ -92,7 +92,6 @@ func (q *ChannelEventQueue) dispatchMessage() {
+ 		event := model.MessageToEvent(&msg)
+ 		select {
+ 		case rChannel <- event:
+-		default:
+ 		}
+ 	}
+ }","I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?",why remove this?
+1235,"@@ -539,11 +539,12 @@ class EAP_MD5(EAP):
+         ByteEnumField(""code"", 1, eap_codes),
+         ByteField(""id"", 0),
+         FieldLenField(""len"", None, fmt=""H"", length_of=""optional_name"",
+-                      adjust=lambda p, x: x + p.value_size + 6),
++                adjust=lambda p, x: (x + p.value_size + 6) if p.value_size is not None else 6),
+         ByteEnumField(""type"", 4, eap_types),
+-        FieldLenField(""value_size"", 0, fmt=""B"", length_of=""value""),
++        FieldLenField(""value_size"", None, fmt=""B"", length_of=""value""),
+         XStrLenField(""value"", '', length_from=lambda p: p.value_size),
+-        XStrLenField(""optional_name"", '', length_from=lambda p: p.len - p.value_size - 6)
++        XStrLenField(""optional_name"", '',
++                length_from=lambda p: (p.len - p.value_size - 6) if p.len is not None and p.value_size is not None else 0)
+     ]
+
+ ","Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`.",`p.value_size is not None` -> no need for the `is not
+1236,"@@ -238,6 +238,10 @@ type Container struct {
+
+ 	Secrets []*Secret `locationName:""secrets"" type:""list""`
+
++	StartTimeout *int64 `locationName:""startTimeout"" type:""integer""`
++
++	StopTimeout *int64 `locationName:""stopTimeout"" type:""integer""`
++
+ 	VolumesFrom []*VolumeFrom `locationName:""volumesFrom"" type:""list""`
+ }
+ ",Can we make sure ECS service treats it as int64 as well?,These should probably be pointer types since these are optional.
+1237,"@@ -178,6 +178,15 @@ class UIProperty(UIA):
+ 			return value
+ 		return value.replace(CHAR_LTR_MARK,'').replace(CHAR_RTL_MARK,'')
+
++class ReadOnlyEditBox(IAccessible):
++#Used for read-only edit boxes in a properties window.
++#These can contain dates that include unwanted left-to-right and right-to-left indicator characters.
++
++	def _get_windowText(self):
++		WindowText = super(ReadOnlyEditBox, self).windowText
++		if  WindowText  is not None and controlTypes.STATE_READONLY in self.states:
++			return WindowText.replace(CHAR_LTR_MARK,'').replace(CHAR_RTL_MARK,'')
++		return WindowText
+
+ class AppModule(appModuleHandler.AppModule):
+ ","Please follow the naming convention for variables, i.e. `windowText`.",Please add a space after `if`.
+1238,"@@ -21,8 +21,8 @@ import (
+
+ 	yaml ""github.com/ghodss/yaml""
+ 	""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
++	castv1alpha1 ""github.com/openebs/maya/pkg/castemplate/v1alpha1""
+ 	m_k8s_client ""github.com/openebs/maya/pkg/client/k8s""
+-	""github.com/openebs/maya/pkg/engine""
+ 	menv ""github.com/openebs/maya/pkg/env/v1alpha1""
+ 	""github.com/pkg/errors""
+ 	v1_storage ""k8s.io/api/storage/v1""",alias can be `cast`,remove the import of `castv1alpha1`
+1239,"@@ -97,13 +97,14 @@ static h2o_iovec_t events_status_final(void *priv, h2o_globalconf_t *gconf, h2o_
+                        "" \""http2-errors.inadequate-security\"": %"" PRIu64 "", \n""
+                        "" \""http2.read-closed\"": %"" PRIu64 "", \n""
+                        "" \""http2.write-closed\"": %"" PRIu64 "", \n""
+-                       "" \""ssl.errors\"": %"" PRIu64 ""\n"",
++                       "" \""ssl.errors\"": %"" PRIu64 "", \n""
++                       "" \""memory.mmap_errors\"": %"" PRIu64 ""\n"",
+                        H1_AGG_ERR(400), H1_AGG_ERR(403), H1_AGG_ERR(404), H1_AGG_ERR(405), H1_AGG_ERR(416), H1_AGG_ERR(417),
+                        H1_AGG_ERR(500), H1_AGG_ERR(502), H1_AGG_ERR(503), H2_AGG_ERR(PROTOCOL), H2_AGG_ERR(INTERNAL),
+                        H2_AGG_ERR(FLOW_CONTROL), H2_AGG_ERR(SETTINGS_TIMEOUT), H2_AGG_ERR(STREAM_CLOSED), H2_AGG_ERR(FRAME_SIZE),
+                        H2_AGG_ERR(REFUSED_STREAM), H2_AGG_ERR(CANCEL), H2_AGG_ERR(COMPRESSION), H2_AGG_ERR(CONNECT),
+                        H2_AGG_ERR(ENHANCE_YOUR_CALM), H2_AGG_ERR(INADEQUATE_SECURITY), esc->h2_read_closed, esc->h2_write_closed,
+-                       esc->ssl_errors);
++                       esc->ssl_errors, (uint64_t)mmap_errors);
+     pthread_mutex_destroy(&esc->mutex);
+     free(esc);
+     return ret;","Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`.",Shouldn't it be `1.1.1` instead of `1.1.2`?
+1240,"@@ -57,7 +57,7 @@ import javax.lang.model.element.Name;
+         name = ""CatchSpecificity"",
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+-        severity = BugPattern.SeverityLevel.SUGGESTION,
++        severity = BugPattern.SeverityLevel.WARNING,
+         summary = ""Prefer more specific error types than Exception and Throwable. When methods are updated to throw new""
+                 + "" checked exceptions they expect callers to handle failure types explicitly. Catching broad""
+                 + "" types defeats the type system. By catching the most specific types possible we leverage""",I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?,"Somewhat unrelated, but this is the only one that worries me."
+1241,"@@ -72,7 +72,7 @@ class CppGenerator : public BaseGenerator {
+     }
+     for (auto it = parser_.included_files_.begin();
+          it != parser_.included_files_.end(); ++it) {
+-      auto noext = flatbuffers::StripExtension(it->first);
++      auto noext = flatbuffers::StripExtension(it->second);
+       auto basename = flatbuffers::StripPath(noext);
+       if (basename != file_name_) {
+         code_ += ""#include \"""" + parser_.opts.include_prefix +",This should now be made into `if (it->second.empty())` ?,I think this is also wrong. It should be: `flatbuffers::Strip
+1242,"@@ -126,13 +126,19 @@ class WebEngineSearch(browsertab.AbstractSearch):
+     def __init__(self, parent=None):
+         super().__init__(parent)
+         self._flags = QWebEnginePage.FindFlags(0)
++        self.num_of_searches = 0
+
+     def _find(self, text, flags, callback, caller):
+         """"""Call findText on the widget.""""""
+         self.search_displayed = True
++        self.num_of_searches += 1
+
+         def wrapped_callback(found):
+             """"""Wrap the callback to do debug logging.""""""
++            self.num_of_searches -= 1
++            if self.num_of_searches > 0:
++                return
++
+             found_text = 'found' if found else ""didn't find""
+             if flags:
+                 flag_text = 'with flags {}'.format(debug.qflags_key(","Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about.",Please rename this method to `_num_of_searches`
+1243,"@@ -100,7 +100,7 @@ func TestMultiplePropagators(t *testing.T) {
+ 	// generates the valid span context out of thin air
+ 	{
+ 		ctx := ootaProp.Extract(bg, ns)
+-		sc := trace.RemoteSpanContextFromContext(ctx)
++		sc := trace.SpanContextFromContext(ctx)
+ 		require.True(t, sc.IsValid(), ""oota prop failed sanity check"")
+ 	}
+ 	// sanity check for real propagators, ensuring that they",Should these assert that the extracted `SpanContext` is remote?,I'd be tempted to keep this one as `RemoteSpanContextFromCont
+1244,"@@ -27,6 +27,9 @@ class ApproxMaxIoUAssigner(MaxIoUAssigner):
+             ignoring any bboxes.
+         ignore_wrt_candidates (bool): Whether to compute the iof between
+             `bboxes` and `gt_bboxes_ignore`, or the contrary.
++        match_low_quality (bool): Whether to allow quality matches. This is
++            usually allowed for RPN and single stage detectors, but not allowed
++            in the second stage.
+         gpu_assign_thr (int): The upper bound of the number of GT for GPU
+             assign. When the number of gt is above this threshold, will assign
+             on CPU device. Negative values mean not assign on CPU.",typo: allow low quality matches.,"Maybe something like ""When the number of GT is below this threshold, the number of GT is below this threshold."""
+1245,"@@ -49,7 +49,7 @@ func ResolveDataDir(dataDir string) (string, error) {
+ 	return filepath.Join(dataDir, ""server""), err
+ }
+
+-func StartServer(ctx context.Context, config *Config) error {
++func StartServer(ctx context.Context, config *Config, cfg *cmds.Server) error {
+ 	if err := setupDataDirAndChdir(&config.ControlConfig); err != nil {
+ 		return err
+ 	}","At some point we need to condense down and refactor our ""configs"" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference.",Should we be passing the config instead of the whole config?
+1246,"@@ -39,7 +39,8 @@ module Blacklight
+     def options
+       {
+         class: classes,
+-        ""aria-hidden"": (true if aria_hidden)
++        ""aria-hidden"": (true if aria_hidden),
++        ""aria-label"": icon_label
+       }
+     end
+ ",Can we add the `if label` conditional to this please?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+1247,"@@ -40,6 +40,7 @@ setup(
+     packages=['databricks', 'databricks.koalas', 'databricks.koalas.missing'],
+     extras_require={
+         'spark': ['pyspark>=2.4.0'],
++        'mlflow': ['mlflow>=0.2.0'],
+     },
+     python_requires='>=3.5',
+     install_requires=[","@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow",I don't think you need to specify `mlflow` here. `databricks` and `databricks.koalas` are in sync with `mlflow`
+1248,"@@ -669,6 +669,8 @@ const REGISTERED_HOOKS = [
+    * @param {CellRange} sourceRange The range values will be filled from.
+    * @param {CellRange} targetRange The range new values will be filled into.
+    * @param {string} direction Declares the direction of the autofill. Possible values: `up`, `down`, `left`, `right`.
++   * @param {boolean} hasFillDataChanged Indicates whether the original fillData has been changed in
++   *                                     the `beforeAutofill` hook.
+    */
+   'afterAutofill',
+ ","If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?",Does this need to be added to the `beforeAutofill` hook as well?
+1249,"@@ -37,13 +37,18 @@ from .execution_context import (
+     SystemPipelineExecutionContext,
+ )
+
+-
+ from .errors import DagsterInvariantViolationError
+
+ from .events import construct_event_logger
+
+ from .execution_plan.create import create_execution_plan_core
+
++from .execution_plan.intermediates_manager import (
++    FileSystemIntermediateManager,
++    InMemoryIntermediatesManager,
++    IntermediatesManager,
++)
++
+ from .execution_plan.objects import (
+     ExecutionPlan,
+     ExecutionStepEvent,",`Intermediates` or `Intermediate`,Why do we need the `IntermediatesManager` class if only `FileSys
+1250,"@@ -95,6 +95,8 @@ class visibility_of(object):
+
+
+ def _element_if_visible(element, visibility=True):
++    if isinstance(element, str) or isinstance(element, dict):
++           raise StaleElementReferenceException(""Invalid locator"")
+     return element if element.is_displayed() == visibility else False
+
+ ",This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.,Why is this error raised here? I don't see where the locator is
+1251,"@@ -52,8 +52,9 @@ func (c *Cluster) Bootstrap(ctx context.Context, snapshot bool) error {
+ 			// instance of etcd in the event that etcd certificates are unavailable,
+ 			// reading the data, and comparing that to the data on disk, all the while
+ 			// starting normal etcd.
+-			isHTTP := c.config.JoinURL != """" && c.config.Token != """"
+-			if isInitialized && !isHTTP {
++			// isHTTP := c.config.JoinURL != """" && c.config.Token != """"
++			if isInitialized {
++				logrus.Info(""Only reconciling with datastore"")
+ 				tmpDataDir := filepath.Join(c.config.DataDir, ""db"", ""tmp-etcd"")
+ 				os.RemoveAll(tmpDataDir)
+ 				if err := os.Mkdir(tmpDataDir, 0700); err != nil {","If this code isn't needed, it should be removed.",why did you remove this line?
+1252,"@@ -145,10 +145,13 @@ func (md *metricsDriver) uploadMetrics(ctx context.Context, protoMetrics []*metr
+ 		if md.metricsClient == nil {
+ 			return errNoClient
+ 		}
+-		_, err := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{
+-			ResourceMetrics: protoMetrics,
+-		})
+-		return err
++		req := func(ctx context.Context) error {
++			_, err := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{
++				ResourceMetrics: protoMetrics,
++			})
++			return err
++		}
++		return doRequest(ctx, req, md.connection.cfg.RetrySettings, md.connection.stopCh)
+ 	}()
+ 	if err != nil {
+ 		md.connection.setStateDisconnected(err)",Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?,Do we need a retry here?
+1253,"@@ -99,8 +99,8 @@ var _ = Describe(""init flow"", func() {
+ 			Expect(len(app.Variables)).To(Equal(5))
+ 			expectedVars := map[string]string{
+ 				""ECS_CLI_APP_NAME"":           appName,
+-				""ECS_CLI_ENVIRONMENT_NAME"":   ""test"",
+-				""ECS_CLI_LB_DNS"":             strings.TrimPrefix(app.Routes[0].URL, ""http://""),
++				""COPILOT_ENVIRONMENT_NAME"":   ""test"",
++				""COPILOT_LB_DNS"":             strings.TrimPrefix(app.Routes[0].URL, ""http://""),
+ 				""ECS_CLI_PROJECT_NAME"":       projectName,
+ 				""ECS_APP_DISCOVERY_ENDPOINT"": fmt.Sprintf(""%s.local"", projectName),
+ 			}",we'll probably tackle these e2e tests at the end,[nit] Can we call this `
+1254,"@@ -0,0 +1,19 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++using BenchmarkDotNet.Attributes;
++using MicroBenchmarks;
++
++namespace System.Net.Tests
++{
++    [BenchmarkCategory(Categories.CoreFX)]
++    public class DnsTests
++    {
++        [Benchmark]
++        public IPHostEntry GetHostEntry() => Dns.GetHostEntry(""34.206.253.53"");
++
++        [Benchmark]
++        public string GetHostName() => Dns.GetHostName();
++    }
++}",what is this address pointing to? what are we measuring here? I want to have a better understanding.,Do we really need a sepa
+1255,"@@ -101,7 +101,8 @@ public class JdbcFlowTriggerInstanceLoaderImpl implements FlowTriggerInstanceLoa
+           + ""project_json, flow_exec_id \n""
+           + ""FROM execution_dependencies JOIN (\n""
+           + ""SELECT trigger_instance_id FROM execution_dependencies WHERE trigger_instance_id not in (\n""
+-          + ""SELECT distinct(trigger_instance_id)  FROM execution_dependencies WHERE dep_status =  0 or dep_status = 4)\n""
++          + ""SELECT distinct(trigger_instance_id)  FROM execution_dependencies WHERE dep_status =""
++          + ""  0 or dep_status = 3)\n""
+           + ""GROUP BY trigger_instance_id\n""
+           + ""ORDER BY  min(starttime) desc limit %s) temp on execution_dependencies""
+           + "".trigger_instance_id in (temp.trigger_instance_id);"";","Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here.",not sure why do you chan
+1256,"@@ -1,3 +1,9 @@
++// Copyright 2017 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++// +build windows
++
+ package libdokan
+
+ import (",Hah I had `gorename` failing without this too.,why are we only building this for windows?
+1257,"@@ -597,6 +597,12 @@ namespace Datadog.Trace
+                     writer.WritePropertyName(""appsec_blocking_enabled"");
+                     writer.WriteValue(Security.Instance.Settings.BlockingEnabled);
+
++                    writer.WritePropertyName(""rules_file_path"");
++                    writer.WriteValue(Security.Instance.Settings.Rules ?? ""(none)"");
++
++                    writer.WritePropertyName(""libddwaf_version"");
++                    writer.WriteValue(Security.Instance.DdlibWafVersion?.ToString() ?? ""(none)"");
++
+                     writer.WriteEndObject();
+                 }
+ ",maybe prefix these with `appsec_` for consistency?,Maybe add a property for `Security.Instanc
+1258,"@@ -7,11 +7,19 @@ import (
+ 	""crypto/x509""
+ 	""errors""
+ 	""fmt""
++	""github.com/spiffe/spire/pkg/common/profiling""
++	""net/http""
++	_ ""net/http/pprof""
+ 	""net/url""
+ 	""path""
++	""runtime""
++
++	""strconv""
+ 	""sync""
+ 	""syscall""
+
++	_ ""golang.org/x/net/trace""
++
+ 	""github.com/spiffe/spire/pkg/agent/catalog""
+ 	""github.com/spiffe/spire/pkg/agent/endpoints""
+ 	""github.com/spiffe/spire/pkg/agent/manager""",nit: this should be down further with the other github imports,These seem like they ought to be moved to
+1259,"@@ -560,6 +560,11 @@ def main():
+ 	else:
+ 		log.debug(""initializing updateCheck"")
+ 		updateCheck.initialize()
++	# If running from source, try to disconnect from the console we may have been executed in.
++	# NVDA may reconnect to read it later,
++	# but it is better to assume we are not connected to anything at the start.
++	if ctypes.windll.kernel32.FreeConsole() != 0:
++		log.debug(""Freed from parent console process."")
+ 	log.info(""NVDA initialized"")
+ 	postNvdaStartup.notify()
+ ",Why is this change necessary or related to the rest of the PR?,Should we set the log level to debug inste
+1260,"@@ -31,7 +31,7 @@ class ConsoleReport extends Report
+             $issue_string .= 'INFO';
+         }
+
+-        $issue_reference = $issue_data->link ? ' (see ' . $issue_data->link . ')' : '';
++        $issue_reference = $issue_data->link ? ' - see: ' . $issue_data->link : '';
+
+         $issue_string .= ': ' . $issue_data->type
+             . ' - ' . $issue_data->file_name . ':' . $issue_data->line_from . ':' . $issue_data->column_from","Hm, I wonder if the `see:` prefix is even necessary?","The check for `issue_data->link` should be done beforehand, if `$issue_data->link` is empty, it should be set to `null`."
+1261,"@@ -261,7 +261,13 @@ import 'emby-button';
+
+                 minutes = minutes || 1;
+
+-                miscInfo.push(`${Math.round(minutes)} mins`);
++                if (item.UserData?.PlaybackPositionTicks) {
++                    let remainingMinutes = (item.RunTimeTicks - item.UserData.PlaybackPositionTicks) / 600000000;
++                    remainingMinutes = remainingMinutes || 1;
++                    miscInfo.push(`${Math.round(minutes)} mins (${Math.round(remainingMinutes)} remaining)`);
++                } else {
++                    miscInfo.push(`${Math.round(minutes)} mins`);
++                }
+             }
+         }
+ ",This should be translated.,"I'm not sure why you added this, but it's not used anywhere"
+1262,"@@ -294,13 +294,15 @@ class Booster {
+   void ResetConfig(const char* parameters) {
+     UNIQUE_LOCK(mutex_)
+     auto param = Config::Str2Map(parameters);
+-    if (param.count(""num_class"")) {
++    Config new_config;
++    new_config.Set(param);
++    if (param.count(""num_class"") && new_config.num_class != config_.num_class) {
+       Log::Fatal(""Cannot change num_class during training"");
+     }
+-    if (param.count(""boosting"")) {
++    if (param.count(""boosting"") && new_config.boosting != config_.boosting) {
+       Log::Fatal(""Cannot change boosting during training"");
+     }
+-    if (param.count(""metric"")) {
++    if (param.count(""metric"") && new_config.metric != config_.metric) {
+       Log::Fatal(""Cannot change metric during training"");
+     }
+     CheckDatasetResetConfig(config_, param);","I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed.",Do you need to check that new_config.boosting is not 0 here?
+1263,"@@ -356,9 +356,9 @@ describe 'run_task' do
+
+       is_expected.to run.with_params(task_name, hostname, task_params).and_raise_error(
+         Puppet::ParseError,
+-        /Task\ test::params:\n
++        %r{Task\ test::params:\n
+          \s*has\ no\ parameter\ named\ 'foo'\n
+-         \s*has\ no\ parameter\ named\ 'bar'/x
++         \s*has\ no\ parameter\ named\ 'bar'}x
+       )
+     end
+ ","These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals.","I changed this from `/x` to `\n`. It looks like there's a syntax error here, so the second `\n` is unnecessary."
+1264,"@@ -1564,7 +1564,7 @@ func (r *ReconcileClusterDeployment) mergePullSecrets(cd *hivev1.ClusterDeployme
+ 	globalPullSecretName := os.Getenv(constants.GlobalPullSecret)
+ 	var globalPullSecret string
+ 	if len(globalPullSecretName) != 0 {
+-		globalPullSecret, err = controllerutils.LoadSecretData(r.Client, globalPullSecretName, constants.HiveNamespace, corev1.DockerConfigJsonKey)
++		globalPullSecret, err = controllerutils.LoadSecretData(r.Client, globalPullSecretName, controllerutils.GetHiveNamespace(), corev1.DockerConfigJsonKey)
+ 		if err != nil {
+ 			return """", errors.Wrap(err, ""global pull secret could not be retrieved"")
+ 		}",Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand.,GetHiveNamespace() can return nil. I'm not sure if that's a good idea.
+1265,"@@ -23,11 +23,13 @@ class TestKinesis(unittest.TestCase):
+
+         # create stream and assert 0 consumers
+         client.create_stream(StreamName=stream_name, ShardCount=1)
++        sleep(1)
+         assert_consumers(0)
+
+         # create consumer and assert 1 consumer
+         consumer_name = 'cons1'
+         response = client.register_stream_consumer(StreamARN=stream_arn, ConsumerName=consumer_name)
++        sleep(1)
+         self.assertEqual(response['Consumer']['ConsumerName'], consumer_name)
+         # boto3 converts the timestamp to datetime
+         self.assertTrue(isinstance(response['Consumer']['ConsumerCreationTimestamp'], datetime))",kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here.,Why do we need this sleep?
+1266,"@@ -145,13 +145,8 @@ std::unique_ptr<nebula::kvstore::KVStore> initKV(std::vector<nebula::HostAddr> p
+     LOG(ERROR) << ""Meta version is invalid"";
+     return nullptr;
+   } else if (version == nebula::meta::MetaVersion::V1) {
+-    auto ret = nebula::meta::MetaVersionMan::updateMetaV1ToV2(engine);
+-    if (!ret.ok()) {
+-      LOG(ERROR) << ""Update meta from V1 to V2 failed "" << ret;
+-      return nullptr;
+-    }
+-
+-    nebula::meta::MetaVersionMan::setMetaVersionToKV(engine, nebula::meta::MetaVersion::V2);
++    LOG(ERROR) << ""Can't upgrade meta from V1 to V3"";
++    return nullptr;
+   } else if (version == nebula::meta::MetaVersion::V2) {
+     auto ret = nebula::meta::MetaVersionMan::updateMetaV2ToV3(engine);
+     if (!ret.ok()) {",Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?,Shouldn't this be `Can't upgrade meta from V1 to V3` ?
+1267,"@@ -26,7 +26,7 @@ func (repo *nodeAttestorRepository) Constraints() catalog.Constraints {
+ }
+
+ func (repo *nodeAttestorRepository) Versions() []catalog.Version {
+-	return []catalog.Version{nodeAttestorV0{}}
++	return []catalog.Version{nodeAttestorV1{}}
+ }
+
+ func (repo *nodeAttestorRepository) LegacyVersion() (catalog.Version, bool) {","I think that V0 is missing here, which will prevent plugins that haven't been converted to work.",Is there any reason to drop the old version?
+1268,"@@ -4,6 +4,7 @@ const withBundleAnalyzer = require(""@next/bundle-analyzer"")({
+ })
+
+ module.exports = withBundleAnalyzer({
++  // sitemap: () => [{uri: ""/wow"", type: ""pages"", verb: ""get""}],
+   middleware: [
+     sessionMiddleware({
+       unstable_isAuthorized: unstable_simpleRolesIsAuthorized,",Should we remove this?,I think we can remove this.
+1269,"@@ -6,12 +6,14 @@ import (
+
+ 	""go.uber.org/zap""
+
++	""github.com/docker/distribution/reference""
+ 	""github.com/docker/docker/api/types""
+ 	""github.com/docker/docker/api/types/container""
+ 	""github.com/docker/docker/api/types/network""
+ 	""github.com/docker/docker/client""
+ 	""github.com/gliderlabs/ssh""
+ 	log ""github.com/noxiouz/zapctx/ctxlog""
++	""io""
+ )
+
+ type containerDescriptor struct {",Put on top of the import.,[nit] Could you also move t
+1270,"@@ -46,6 +46,7 @@ domReady( () => {
+ 	Modules.registerModule(
+ 		'analytics',
+ 		{
++			name: 'Analytics',
+ 			settingsEditComponent: SettingsEdit,
+ 			settingsViewComponent: SettingsView,
+ 			setupComponent: SetupMain,","See above, this shouldn't be added.",why do we need to name it h
+1271,"@@ -505,8 +505,8 @@ public enum ItemMapping
+ 	ITEM_ANGUISH_ORNAMENT_KIT(ANGUISH_ORNAMENT_KIT, NECKLACE_OF_ANGUISH_OR),
+ 	ITEM_OCCULT_NECKLACE(OCCULT_NECKLACE, OCCULT_NECKLACE_OR),
+ 	ITEM_OCCULT_ORNAMENT_KIT(OCCULT_ORNAMENT_KIT, OCCULT_NECKLACE_OR),
+-	ITE_AMULET_OF_FURY(AMULET_OF_FURY, AMULET_OF_FURY_OR),
+-	ITE_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR),
++	ITEM_AMULET_OF_FURY(AMULET_OF_FURY, AMULET_OF_FURY_OR),
++	ITEM_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR),
+
+ 	// Ensouled heads
+ 	ITEM_ENSOULED_GOBLIN_HEAD(ENSOULED_GOBLIN_HEAD_13448, ENSOULED_GOBLIN_HEAD),","This'll likely get fixed upstream, we should let them deal with it.",why did you remove all the
+1272,"@@ -93,6 +93,7 @@ type Options struct {
+ 	LightNodeLimit int
+ 	WelcomeMessage string
+ 	Transaction    []byte
++	HostFactory    func(context.Context, ...libp2p.Option) (host.Host, error)
+ }
+
+ func New(ctx context.Context, signer beecrypto.Signer, networkID uint64, overlay swarm.Address, addr string, ab addressbook.Putter, storer storage.StateStorer, lightNodes *lightnode.Container, swapBackend handshake.SenderMatcher, logger logging.Logger, tracer *tracing.Tracer, o Options) (*Service, error) {","Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval.",I think this could just be `host.Host`
+1273,"@@ -111,6 +111,18 @@ class Time {
+ 	sleep(seconds) {
+ 		return this.msleep(seconds * 1000);
+ 	}
++
++
++	goBackInTime(n, timeDuration) {
++		// Note that we are starting from the first ms of the current timeDuration
++		// eg. If we go back by one day we are subtracting (24*60*60*1000) ms from the start ms of today
++		return moment().startOf(timeDuration).subtract(n, timeDuration).format('x');
++	}
++
++	goForwardInTime(n, timeDuration) {
++		return moment().startOf(timeDuration).add(n, timeDuration).format('x');
++	}
++
+ }
+
+ const time = new Time();","As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is ""n"" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be ""day"", ""hours"", etc. but from your example it seems to be milliseconds).",Any reason for using `moment` over `da
+1274,"@@ -71,7 +71,11 @@ class AppModule(appModuleHandler.AppModule):
+ 			ui.message(_(""No track playing""))
+ 		return elapsedAndTotalTime
+
+-	def script_reportRemainingTime(self,gesture):
++	def script_reportRemainingTime(self, gesture):
++		import config
++		from languageHandler import setLanguage
++		lang = config.conf[""general""][""language""]
++		setLanguage(lang)
+ 		elapsedTime, totalTime = self.getElapsedAndTotalIfPlaying()
+ 		if elapsedTime is None or totalTime is None:
+ 			# Translators: Reported if the remaining time can not be calculated in Foobar2000","Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage.",please import in top-level modules
+1275,"@@ -276,7 +276,7 @@ var _ = Describe(""Application deployment in edge_core Testing"", func() {
+ 		It(""TC_TEST_APP_DEPLOYMENT_16: Test application deployment with container network configuration as port mapping"", func() {
+ 			//Generate the random string and assign as a UID
+ 			UID = ""deployment-app-"" + edge.GetRandomString(10)
+-			port := []v1.ContainerPort{{HostPort: 10255, ContainerPort: 10255, Protocol: v1.ProtocolTCP, HostIP: ""127.0.0.1""}}
++			port := []v1.ContainerPort{{HostPort: 10256, ContainerPort: 10256, Protocol: v1.ProtocolTCP, HostIP: ""127.0.0.1""}}
+ 			IsAppDeployed := HandleAddAndDeletePods(http.MethodPut, ctx.Cfg.TestManager+AppHandler, UID, []v1.Container{{Name: UID, Image: ctx.Cfg.AppImageUrl[0], Ports: port, ImagePullPolicy: v1.PullIfNotPresent}}, v1.RestartPolicyOnFailure)
+ 			Expect(IsAppDeployed).Should(BeTrue())
+ 			CheckPodRunningState(ctx.Cfg.EdgedEndpoint+AppHandler, UID)",why is this changed ?,This change seems unrelated to the res
+1276,"@@ -182,8 +182,9 @@ func (l *ActionList) Get(doc Document, fps ...FieldPath) *ActionList {
+ // mod ""a.b"": 2, then either Update will fail, or it will succeed with the result
+ // {a: {b: 2}}.
+ //
+-// Update does not modify its doc argument. To obtain the new value of the document,
+-// call Get after calling Update.
++// Update does not modify its doc argument, except to set the new revision. To obtain
++// the new value of the document, call Get after calling Update.
++// TODO(jba): test that doc's revision field is updated.
+ func (l *ActionList) Update(doc Document, mods Mods) *ActionList {
+ 	return l.add(&Action{
+ 		kind: driver.Update,","Should this be ""the new revision value""?","The TODO should be done before merging, right?"
+1277,"@@ -13,7 +13,7 @@
+
+ return [
+     'accepted'             => ':attribute må aksepteres.',
+-    'accepted_if'          => 'The :attribute must be accepted when :other is :value.',
++    'accepted_if'          => 'Dette feltet må aksepteres når :other er :value.',
+     'active_url'           => ':attribute er ikke en gyldig URL.',
+     'after'                => ':attribute må være en dato etter :date.',
+     'after_or_equal'       => ':attribute må være en dato etter eller lik :date.',",You have deleted :attribute,Extra empty line detected at block body beginn
+1278,"@@ -1,12 +1,11 @@
+ /*
+- * Licensed to the Apache Software Foundation (ASF) under one or more
+- * contributor license agreements.  See the NOTICE file distributed with
+- * this work for additional information regarding copyright ownership.
+- * The ASF licenses this file to You under the Apache License, Version 2.0
+- * (the ""License""); you may not use this file except in compliance with
+- * the License.  You may obtain a copy of the License at
++ * Copyright 2017 Huawei Technologies Co., Ltd
+  *
+- *     http://www.apache.org/licenses/LICENSE-2.0
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *    http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an ""AS IS"" BASIS,",The license header should be updated to the Apache one.,Why change the copyright year?
+1279,"@@ -22,6 +22,10 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+         [Trait(""RunOnWindows"", ""True"")]
+         public void HttpClient()
+         {
++            int expectedSpanCount = EnvironmentHelper.IsCoreClr() ? 2 : 1;
++            const string expectedOperationName = ""http.request"";
++            const string expectedServiceName = ""Samples.HttpMessageHandler-http-client"";
++
+             int agentPort = TcpPortProvider.GetOpenPort();
+             int httpPort = TcpPortProvider.GetOpenPort();
+ ",@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?,I think CoreCLR builds are failing because of
+1280,"@@ -883,3 +883,17 @@ instr_is_exclusive_store(instr_t *instr)
+     return (opcode == OP_strex || opcode == OP_strexb || opcode == OP_strexd ||
+             opcode == OP_strexh);
+ }
++
++DR_API
++bool
++instr_is_scatter(instr_t *instr)
++{
++    return false;
++}
++
++DR_API
++bool
++instr_is_gather(instr_t *instr)
++{
++    return false;
++}",Not sure about this one -- did you check somehow?,this can be just `return false`
+1281,"@@ -157,8 +157,15 @@ module Beaker
+         @options = @options.merge(env_vars)
+
+         if @options.is_pe?
+-          @options['pe_ver']           = Beaker::Options::PEVersionScraper.load_pe_version(@options[:pe_dir], @options[:pe_version_file])
+-          @options['pe_ver_win']       = Beaker::Options::PEVersionScraper.load_pe_version(@options[:pe_dir], @options[:pe_version_file_win])
++          @options['HOSTS'].each_key do |name, val|
++            if @options['HOSTS'][name]['platform'] =~ /windows/
++              @options['HOSTS'][name]['pe_ver_win'] = @options['HOSTS'][name]['pe_ver_win'] || Beaker::Options::PEVersionScraper.load_pe_version(
++                                   @options['HOSTS'][name][:pe_dir] || @options[:pe_dir], @options[:pe_version_file_win])
++            else
++              @options['HOSTS'][name]['pe_ver'] = @options['HOSTS'][name]['pe_ver'] || Beaker::Options::PEVersionScraper.load_pe_version(
++                                   @options['HOSTS'][name][:pe_dir] || @options[:pe_dir], @options[:pe_version_file])
++            end
++          end
+         else
+           @options['puppet_ver']       = @options[:puppet]
+           @options['facter_ver']       = @options[:facter]",Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?,@monfresh These changes are all
+1282,"@@ -97,7 +97,9 @@ public class ProductActivity extends BaseActivity {
+         String[] menuTitles = getResources().getStringArray(R.array.nav_drawer_items_product);
+
+         ProductFragmentPagerAdapter adapterResult = new ProductFragmentPagerAdapter(getSupportFragmentManager());
+-        adapterResult.addFragment(new SummaryProductFragment(), menuTitles[0]);
++        SummaryProductFragment summaryProductFragment = new SummaryProductFragment();
++
++        adapterResult.addFragment(summaryProductFragment, menuTitles[0]);
+         adapterResult.addFragment(new IngredientsProductFragment(), menuTitles[1]);
+         adapterResult.addFragment(new NutritionProductFragment(), menuTitles[2]);
+         adapterResult.addFragment(new NutritionInfoProductFragment(), menuTitles[3]);","Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients",Can you remove the `summaryProd
+1283,"@@ -119,9 +119,6 @@ type StressInstance struct {
+ 	// UID is the instance identifier
+ 	// +optional
+ 	UID string `json:""uid""`
+-	// StartTime specifies when the instance starts
+-	// +optional
+-	StartTime *metav1.Time `json:""startTime""`
+ }
+
+ // GetDuration gets the duration of StressChaos",Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused.,Now that we're removing this fi
+1284,"@@ -489,6 +489,10 @@ module Beaker
+             end
+
+           rescue Exception => teardown_exception
++            if !host.is_pe?
++              dump_puppet_log(host)
++            end
++
+             if original_exception
+               logger.error(""Raised during attempt to teardown with_puppet_running_on: #{teardown_exception}\n---\n"")
+               raise original_exception","My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception.","If we don't have the puppet log, do we need to dump it? Or can we dump it just in case?"
+1285,"@@ -53,10 +53,11 @@ static infer_result<task::classification> call_daal_kernel(
+
+     const std::int64_t dummy_seed = 777;
+     const auto data_use_in_model = daal_knn::doNotUse;
+-    daal_knn::Parameter daal_parameter(desc.get_class_count(),
+-                                       desc.get_neighbor_count(),
+-                                       dummy_seed,
+-                                       data_use_in_model);
++    daal_knn::Parameter daal_parameter(
++        dal::detail::integral_cast<size_t>(desc.get_class_count()),
++        dal::detail::integral_cast<size_t>(desc.get_neighbor_count()),
++        dal::detail::integral_cast<int>(dummy_seed),
++        data_use_in_model);
+
+     interop::status_to_exception(interop::call_daal_kernel<Float, daal_knn_kd_tree_kernel_t>(
+         ctx,",Should it be `int64_t`?,(style) line over 80 characters
+1286,"@@ -26,10 +26,14 @@ import java.util.concurrent.TimeUnit;
+
+ import com.google.common.base.Stopwatch;
+ import org.apache.logging.log4j.Logger;
++import org.apache.tuweni.bytes.Bytes;
++import org.apache.tuweni.concurrent.ExpiringMap;
+ import org.apache.tuweni.units.bigints.UInt256;
+
+ public class PoWSolver {
+
++  private static final long POW_JOB_TTL = 1000 * 60 * 5; // 5 minutes
++  private static final int MAX_OMMER_DEPTH = 8;
+   private static final Logger LOG = getLogger();
+
+   public static class PoWSolverJob {",is this value related to something ?,Should this be configurable? e.g. POW_JOB_TTL_SECONDS
+1287,"@@ -23,6 +23,6 @@ namespace Nethermind.TxPool
+ {
+     public interface ITxSender
+     {
+-        ValueTask<Keccak?> SendTransaction(Transaction tx, TxHandlingOptions txHandlingOptions);
++        ValueTask<(Keccak?, AddTxResult?)> SendTransaction(Transaction tx, TxHandlingOptions txHandlingOptions);
+     }
+ }","Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?",The `?` is not necessary. `AddTxResult` returns `T?`.
+1288,"@@ -136,6 +136,7 @@ public class Name {
+   private String toUnderscore(CaseFormat caseFormat) {
+     List<String> newPieces = new ArrayList<>();
+     for (NamePiece namePiece : namePieces) {
++      namePiece = replaceAcronyms(namePiece);
+       newPieces.add(namePiece.caseFormat.to(caseFormat, namePiece.identifier));
+     }
+     return Joiner.on('_').join(newPieces);",I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings.,what's the purpose of this?
+1289,"@@ -53,7 +53,7 @@ public class TypeTest {
+         assertTrue(type.isArrayType());
+         ArrayType arrayType = type.asArrayType();
+         final ArrayType[] s = new ArrayType[1];
+-        type.ifArrayType(t -> s[0] = t);
++        type.ifArrayType(t -> s[0] = (ArrayType)t);
+         assertNotNull(s[0]);
+     }
+ }",Huh? The point is that a cast isn't necessary,This change seems unrelated
+1290,"@@ -35,4 +35,12 @@ const (
+ 	//
+ 	// Default is ""true""
+ 	CreateDefaultStorageConfig menv.ENVKey = ""OPENEBS_IO_CREATE_DEFAULT_STORAGE_CONFIG""
++
++	// InstallCRD is the environment
++	// variable that flags if maya apiserver should install the CRDs
++	// As the installation moves towards helm 3, the responsibility of installing
++	// CRDs can be pushed to helm.
++	//
++	// Default is ""true""
++	InstallCRD menv.ENVKey = ""OPENEBS_IO_INSTALL_CRD""
+ )",can we name it like `InstallV1Alpha1CRDs` ?,Please prefix the env varia
+1291,"@@ -79,6 +79,7 @@ const (
+ 	deleteAfterAnnotation      = ""hive.openshift.io/delete-after""
+ 	tryInstallOnceAnnotation   = ""hive.openshift.io/try-install-once""
+ 	tryUninstallOnceAnnotation = ""hive.openshift.io/try-uninstall-once""
++	hiveutilCreatedLabel       = ""hive.openshift.io/hiveutil-created""
+ 	cloudAWS                   = ""aws""
+ 	cloudAzure                 = ""azure""
+ 	cloudGCP                   = ""gcp""",I need something to match when creating selectorsyncsets so added this label.,in the future we may want t
+1292,"@@ -47,7 +47,9 @@ module RSpec
+         return nil if line == '-e:1'.freeze
+         line
+       rescue SecurityError
++        # :nocov:
+         nil
++        # :nocov:
+       end
+
+       # @private","Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose.",Is this unintended?
+1293,"@@ -1,11 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to add a cross-origin resource sharing (CORS)
++# configuration containing a single rule to an Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.s3_ruby_bucket_cors.rb]
++
+ require 'aws-sdk-s3'
+
+-# Adds a cross-origin resource sharing (CORS) configuration containing
+-#   a single rule to an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - An Amazon S3 bucket.",Simple Storage **Service**,Trailing whitespace
+1294,"@@ -471,6 +471,9 @@ func (r *Repository) LoadIndex(ctx context.Context) error {
+ 		return err
+ 	}
+
++	// remove obsolete indexes
++	validIndex.Sub(r.idx.Obsolete())
++
+ 	// remove index files from the cache which have been removed in the repo
+ 	return r.PrepareCache(validIndex)
+ }",Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository.,Might be worth chec
+1295,"@@ -0,0 +1,19 @@
++class FeedbackController < ApplicationController
++  # note that index is rendered implicitly as it's just a template
++
++  def create
++    message = []
++    [:bug, :context, :expected, :actually, :comments, :satisfaction, :referral].each do |key|
++      if !params[key].blank?
++        message << ""#{key}: #{params[key]}""
++      end
++    end
++    message = message.join(""\n"")
++    if !message.blank?
++      if current_user
++        message += ""\nuser: #{current_user.email_address}""
++      end
++      CommunicartMailer.feedback(message).deliver
++    end
++  end
++end",We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker.,I'm not sure how I
+1296,"@@ -1482,7 +1482,9 @@ Blockly.WorkspaceSvg.prototype.updateToolbox = function(tree) {
+     this.options.languageTree = tree;
+     this.flyout_.show(tree.childNodes);
+   }
+-  this.toolbox_.position();
++  if (this.toolbox_) {
++    this.toolbox_.position();
++  }
+ };
+
+ /**","move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox.",Do we need to set `this.toolbox_` to something non-null?
+1297,"@@ -364,10 +364,10 @@ namespace pwiz.Skyline.EditUI
+                             var peptideDocNode = tuple.Item2;
+                             HashSet<Protein> proteins = new HashSet<Protein>();
+                             var peptideGroupDocNode = PeptideGroupDocNodes.First(g => ReferenceEquals(g.PeptideGroup, peptideGroup));
+-                            List<Protein> proteinsForSequence;
+-                            if (sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out proteinsForSequence))
++                            // ReSharper disable once ConditionIsAlwaysTrueOrFalse
++                            if (peptideGroupDocNode != null)
+                             {
+-                                if (peptideGroupDocNode != null)
++                                if (sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out var proteinsForSequence))
+                                 {
+                                     foreach (var protein in proteinsForSequence)
+                                     {","Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?",Is this the right place to disable the check? Looks like
+1298,"@@ -17,7 +17,9 @@ var fetch = {},
+     _ = require('underscore'),
+     crypto = require('crypto'),
+     usage = require('./usage.js'),
+-    plugins = require('../../../plugins/pluginManager.js');
++    STATUS_MAP = require('../jobs/job').STATUS_MAP,
++    plugins = require('../../../plugins/pluginManager.js'),
++    countlyDb = plugins.dbConnection();
+
+ /**
+ * Prefetch event data, either by provided key or first event in the list and output result to browser","Let's not create new connection, but rather user `common.db` one",Why are we using a relative path here?
+1299,"@@ -0,0 +1,11 @@
++module OpenGraphHelper
++  def open_graph_tags
++    tag('meta', property: 'og:image', content: image_url('learn/learn-ralph.png'))
++  end
++
++  private
++
++  def image_url(filename)
++    URI.join(root_url, image_path(filename))
++  end
++end",Can this use asset_path rather than defining an image_url helper?,Layout/EmptyLinesAroundModuleBody: Extra empty line dete
+1300,"@@ -0,0 +1,19 @@
++import { always } from 'ramda';
++
++/**
++ * A function that returns empty string.
++ *
++ * @func stubString
++ * @memberOf RA
++ * @since {@link https://char0n.github.io/ramda-adjunct/2.1.0|v2.1.0}
++ * @category Function
++ * @sig ... -> ''
++ * @return {''}
++ * @example
++ *
++ * RA.stubString(); //=> ''
++ * RA.stubString(1, 2, 3); //=> ''
++ */
++const stubString = always('');
++
++export default stubString;",Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that,style: I think we tend to prefer single quotes over double quotes if possible.
+1301,"@@ -61,3 +61,11 @@ type Priority struct {
+ 	PolicyPriority float64
+ 	RulePriority   int32
+ }
++
++// OFPolicyRule groups all configurations that the openflow module needs to install flow for PolicyRule.
++type OFPolicyRule struct {
++	OfID        uint32
++	OfRule      *PolicyRule
++	NpName      string
++	NpNamespace string
++}","Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName..",Doesn't seem to be used anywhere?
+1302,"@@ -485,9 +485,13 @@ class Functions
+
+             // bcmath
+             'bcscale',
+-
++
+             // json
+             'json_last_error',
++
++            // opcache
++            'opcache_compile_file', 'opcache_get_configuration', 'opcache_get_status',
++            'opcache_invalidate', 'opcache_is_script_cached', 'opcache_reset',
+         ];
+
+         if (\in_array(strtolower($function_id), $impure_functions, true)) {","I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?",Please add a trailing comma
+1303,"@@ -127,6 +127,10 @@ class StepDelegatingExecutor(Executor):
+                     running_steps[step.key] = step
+
+             last_check_step_health_time = pendulum.now(""UTC"")
++
++            # Order of events is important here. During an interation, we call handle_event, then get_steps_to_execute,
++            # then is_complete. get_steps_to_execute updates the state of ActiveExecution, and without it
++            # is_complete can return true when we're just between steps.
+             while not active_execution.is_complete:
+
+                 if active_execution.check_for_interrupts():",Could also consider modifying the ActiveExecution...,"This is great, thanks for finding a better way to deal with it!"
+1304,"@@ -1522,3 +1522,19 @@ def get_iterating_dictionary_name(
+         return node.iter.as_string()
+
+     return None
++
++
++def get_subscript_const_value(node: astroid.Subscript) -> astroid.Const:
++    """"""
++    Returns the value (subscript.slice) of a Subscript node,
++    also supports python <3.9 windows where node.slice might be an Index
++    node
++    """"""
++    value = node.slice
++    if isinstance(value, astroid.Index):
++        value = value.value
++    inferred = safe_infer(value)
++    if not isinstance(inferred, astroid.Const):
++        raise ValueError(""Subscript.slice cannot be inferred as an astroid.Const"")
++
++    return inferred",Does it make sense to change that to a custom error instead of `ValueError`?,Nitpick: The first sentence of a docstring should start with a capital letter.
+1305,"@@ -259,7 +259,7 @@ func (vm *VM) ApplyTipSetMessages(blocks []interpreter.BlockMessagesInfo, head b
+
+ 		// Pay block reward.
+ 		// Dragons: missing final protocol design on if/how to determine the nominal power
+-		rewardMessage := makeBlockRewardMessage(blk.Miner, minerPenaltyTotal, minerGasRewardTotal, blk.TicketCount)
++		rewardMessage := makeBlockRewardMessage(blk.Miner, minerPenaltyTotal, minerGasRewardTotal, 1)
+ 		if _, err := vm.applyImplicitMessage(rewardMessage, rnd); err != nil {
+ 			return nil, err
+ 		}",I guess this will need to change soon.,why is this changed?
+1306,"@@ -37,10 +37,9 @@ import (
+ // The header directive goes second so that headers
+ // can be manipulated before doing redirects.
+ var directiveOrder = []string{
++	""map"",
+ 	""root"",
+-
+ 	""header"",
+-
+ 	""redir"",
+ 	""rewrite"",
+ ",Restore this spacing - not sure why it has to be removed?,"This is a good change, but I think it makes sense to move the ""header"" directi"
+1307,"@@ -16,7 +16,10 @@
+
+ // clang-format off
+ // Dont't remove `format off`, it prevent reordering of win-includes.
+-#define _POSIX_C_SOURCE 200112L // For stat from stat/stat.h and fseeko() (POSIX extensions).
++
++#  define _XOPEN_SOURCE 700L
++#  define _POSIX_C_SOURCE 200809L
++
+ #ifdef _WIN32
+ #  ifndef WIN32_LEAN_AND_MEAN
+ #    define WIN32_LEAN_AND_MEAN","These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?",Is this `#ifdef _WIN32` still relevant?
+1308,"@@ -504,7 +504,7 @@ SubPlan GoPlanner::mToNStepsPlan(SubPlan& startVidPlan) {
+   }
+
+   const auto& projectInput =
+-      (joinInput || joinDst) ? loopBody->outputVar() : sampleLimit->outputVar();
++      (loopBody != getDst) ? loopBody->outputVar() : sampleLimit->outputVar();
+   loopBody = Project::make(qctx, loopBody, goCtx_->yieldExpr);
+   loopBody->setInputVar(projectInput);
+   loopBody->setColNames(std::move(goCtx_->colNames));",Why not delete these codes?,Why did you remove the `|| joinInput`?
+1309,"@@ -112,7 +112,7 @@ bool StorageServer::start() {
+     metaClient_ = std::make_unique<meta::MetaClient>(ioThreadPool_,
+                                                      metaAddrs_,
+                                                      options);
+-    if (!metaClient_->waitForMetadReady()) {
++    if (!metaClient_->waitForMetadReady(FLAGS_meta_client_retry_times)) {
+         LOG(ERROR) << ""waitForMetadReady error!"";
+         return false;
+     }","If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data.",Use a constant so both retry times are
+1310,"@@ -7,7 +7,7 @@
+ import pytest
+ import random
+ import datatable as dt
+-from datatable import f, stype, ltype
++from datatable import f, stype, ltype, first, count
+ from tests import list_equals
+
+ ",looks like you don't need to import first and count here anymore,I don't see any new tests for this?
+1311,"@@ -2511,6 +2511,18 @@ func (e *historyEngineImpl) NotifyNewTransferTasks(
+ 	}
+ }
+
++func (e *historyEngineImpl) NotifyNewVisibilityTasks(
++	tasks []persistence.Task,
++) {
++
++	if len(tasks) > 0 {
++		// TODO (alex): add visibility processor
++		// task := tasks[0]
++		// clusterName := e.clusterMetadata.ClusterNameForFailoverVersion(task.GetVersion())
++		// e.visibilityProcessor.NotifyNewTask(clusterName, tasks)
++	}
++}
++
+ func (e *historyEngineImpl) NotifyNewReplicationTasks(
+ 	tasks []persistence.Task,
+ ) {","FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint",Should we add a visibility processor h
+1312,"@@ -36,6 +36,8 @@ import org.springframework.http.HttpMethod;
+ import org.springframework.http.ResponseEntity;
+ import org.springframework.web.client.RestTemplate;
+
++import com.netflix.config.DynamicPropertyFactory;
++
+ public class SpringmvcClient {
+   private static RestTemplate templateUrlWithServiceName = new CseRestTemplate();
+ ",This import can be removed.,minor: remove empty line
+1313,"@@ -48,6 +48,10 @@ func ParseResource(s string, resParser ResourceParser) (resARN Resource, err err
+ 		return nil, InvalidARNError{ARN: a, Reason: ""service is not supported""}
+ 	}
+
++	if strings.HasPrefix(a.Region, ""fips-"") || strings.HasSuffix(a.Region, ""-fips"") {
++		return nil, InvalidARNError{ARN: a, Reason: ""FIPS region not allowed in ARN""}
++	}
++
+ 	if len(a.Resource) == 0 {
+ 		return nil, InvalidARNError{ARN: a, Reason: ""resource not set""}
+ 	}","1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?",Should we check that `a.
+1314,"@@ -8,10 +8,14 @@ name of the service that is used by Boto 3.
+ This factory is used by the make_stubber fixture found in the set of common fixtures.
+ """"""
+
+-from test_tools.s3_stubber import S3Stubber
+ from test_tools.dynamodb_stubber import DynamoStubber
++from test_tools.iam_stubber import IamStubber
++from test_tools.lambda_stubber import LambdaStubber
+ from test_tools.pinpoint_stubber import PinpointStubber
++from test_tools.s3_stubber import S3Stubber
++from test_tools.s3control_stubber import S3ControlStubber
+ from test_tools.sqs_stubber import SqsStubber
++from test_tools.sts_stubber import StsStubber
+
+
+ class StubberFactoryNotImplemented(Exception):",is this phrase completed in a next line? Or forgot to add... what?,Maybe these stubber file
+1315,"@@ -0,0 +1,11 @@
++_base_ = [
++    '../_base_/models/mask_rcnn_r50_fpn.py',
++    '../_base_/datasets/deepfashion.py', '../_base_/schedules/schedule_1x.py',
++    '../_base_/default_runtime.py'
++]
++model = dict(
++    roi_head=dict(
++        bbox_head=dict(num_classes=15), mask_head=dict(num_classes=15)))
++# runtime settings
++total_epochs = 12
++workflow = [('train', 5)]","`('train', 5)` and `('train', 1)` are actually the same.",why is it 12?
+1316,"@@ -205,8 +205,8 @@ func (bt *backpressureTracker) beforeDiskBlockCachePut(blockResources int64) (
+ 	return availableResources
+ }
+
+-func (bt *backpressureTracker) getLimitInfo() (used int64, limit int64) {
+-	return bt.used, bt.limit
++func (bt *backpressureTracker) getLimitInfo() (used int64, limit float64) {
++	return bt.used, bt.currLimit()
+ }
+
+ type backpressureTrackerStatus struct {",Would it be too complicated to refactor `currLimit` to be an `int64`?,why not change `used` to `currLimit`?
+1317,"@@ -23,6 +23,13 @@ module RSpec
+       def assertions
+         @assertions ||= 0
+       end
++
++      RSPEC_SKIP_IMPLEMENTATION = ::RSpec::Core::Pending.instance_method(:skip)
++      # Minitest::Assertions has it's own `skip`, we need to make sure
++      # RSpec::Core::Pending#skip is used instead.
++      def skip(*args)
++        RSPEC_SKIP_IMPLEMENTATION.bind(self).call(*args)
++      end
+     end
+   end
+ end",Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston,I wonder if we should make this a cla
+1318,"@@ -92,6 +92,10 @@ type IoChaosSpec struct {
+ // IoChaosStatus defines the observed state of IoChaos
+ type IoChaosStatus struct {
+ 	ChaosStatus `json:"",inline""`
++
++	// Instances always specifies podnetworkchaos generation or empty
++	// +optional
++	Instances map[string]int64 `json:""instances,omitempty""`
+ }
+
+ func (obj *IoChaos) GetSelectorSpecs() map[string]interface{} {",Should be podiochaos?,Why not make it a `map[string]struct{
+1319,"@@ -35,6 +35,10 @@ import api
+ import guiHelper
+ import winVersion
+
++# Temporary: #8599: add cp65001 codec
++#            #7105: upgrading to python 3 should fix this issue. See https://bugs.python.org/issue13216
++codecs.register(lambda name: codecs.lookup('utf-8') if name == 'cp65001' else None)
++
+ try:
+ 	import updateCheck
+ except RuntimeError:","Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though.",Does this work on both Python 2 and 3
+1320,"@@ -154,6 +154,18 @@ namespace OpenTelemetry.Metrics
+                         {
+                             var metricStreamConfig = metricStreamConfigs[i];
+                             var metricStreamName = metricStreamConfig?.Name ?? instrument.Name;
++
++                            if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName))
++                            {
++                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(
++                                    metricStreamName,
++                                    instrument.Meter.Name,
++                                    ""Metric name is invalid."",
++                                    ""The name must comply with the OpenTelemetry specification."");
++
++                                continue;
++                            }
++
+                             if (this.metricStreamNames.ContainsKey(metricStreamName))
+                             {
+                                 // TODO: Log that instrument is ignored","in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)",This is a breaking change and needs to be added to `3.7`
+1321,"@@ -1654,9 +1654,10 @@ class TargetLocator {
+    *     when the driver has changed focus to the specified window.
+    */
+   window(nameOrHandle) {
++    let paramName = this.driver_.getExecutor().w3c ? 'handle' : 'name';
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter(paramName, nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ",I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs,Does this also need to change in `switchTo`?
+1322,"@@ -0,0 +1,5 @@
++_base_ = '../cascade_rcnn/cascade_mask_rcnn_r50_fpn_20e_coco.py'
++model = dict(
++    pretrained=  # NOQA
++    'https://shanghuagao.oss-cn-beijing.aliyuncs.com/res2net/res2net101_v1b_26w_4s_mmdetv2-f0a600f9.pth',  # NOQA
++    backbone=dict(type='Res2Net', depth=101, scale=4, base_width=26))",You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later.,Remove this file since it is not used.
+1323,"@@ -17,3 +17,12 @@
+  */
+
+ export const STORE_NAME = 'modules/pagespeed-insights';
++
++// Form ID for PageSpeed widget.
++export const FORM_DASH_WIDGET = 'pagespeedWidget';
++// Report strategies.
++export const STRATEGY_MOBILE = 'mobile';
++export const STRATEGY_DESKTOP = 'desktop';
++// Report data sources.
++export const DATA_SRC_LAB = 'data_lab';
++export const DATA_SRC_FIELD = 'data_field';","May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?",Nit: I would call them `data_labWidget` and `data_field`
+1324,"@@ -151,7 +151,7 @@ module.exports = class AwsS3Multipart extends Plugin {
+       const onError = (err) => {
+         this.uppy.log(err)
+         this.uppy.emit('upload-error', file, err)
+-        err.message = `Failed because: ${err.message}`
++        err.message = `${err.message}`
+
+         queuedRequest.done()
+         this.resetUploaderReferences(file.id)",I guess this assignment is now redundant?,this is unrelated but it made sense to add it in this PR
+1325,"@@ -218,7 +218,9 @@ func (s *Server) handleSingleRPC(ctx context.Context, req *RPCReq) *RPCRes {
+ 		return backendRes
+ 	}
+
+-	backendRes, err = s.backendGroups[group].Forward(ctx, req)
++	// NOTE: We call into the specific backend here to ensure that the RPCRes is synchronized with the blockNum.
++	var blockNum uint64
++	backendRes, blockNum, err = s.backendGroups[group].Forward(ctx, req)
+ 	if err != nil {
+ 		log.Error(
+ 			""error forwarding RPC request"",",See above note re: blockNum synchronization.,Nit: blockNum -> blockCount
+1326,"@@ -10,8 +10,10 @@ import (
+ 	""time""
+
+ 	""github.com/andres-erbsen/clock""
++	""github.com/cenkalti/backoff/v3""
+ 	observer ""github.com/imkira/go-observer""
+ 	""github.com/spiffe/spire/pkg/agent/client""
++	spire_backoff ""github.com/spiffe/spire/pkg/agent/common/backoff""
+ 	""github.com/spiffe/spire/pkg/agent/manager/cache""
+ 	""github.com/spiffe/spire/pkg/agent/svid""
+ 	""github.com/spiffe/spire/pkg/common/bundleutil""",wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?,Why is this needed?
+1327,"@@ -44,7 +44,6 @@
+ #include ""disassemble.h""
+ #include ""instr.h""
+ #include ""instr_create.h""
+-
+ #include ""codec.h""
+
+ ",Or maybe put into alphabetical order with the other #includes.,Don't rely on `instr.h` being present in this file.
+1328,"@@ -235,8 +235,11 @@ func watchConfigFile(filename, adapterName string) {
+ 		return false
+ 	}
+
++	ticker := time.NewTicker(1 * time.Second)
++	defer ticker.Stop()
++
+ 	// begin poller
+-	for range time.Tick(1 * time.Second) {
++	for range ticker.C {
+ 		// get the file info
+ 		info, err := os.Stat(filename)
+ 		if err != nil {",This runs the entire duration of the program; this change is not needed.,This can be simplified to `ticker.Run(time.Second)`.
+1329,"@@ -20,6 +20,10 @@ export class TouchScroll extends BasePlugin {
+     return PLUGIN_PRIORITY;
+   }
+
++  static get ALWAYS_UPDATE() {
++    return true;
++  }
++
+   constructor(hotInstance) {
+     super(hotInstance);
+ ","I don't feel well about the `ALWAYS_UPDATE` option   &nbsp; sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the ""observability"" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)",Is this needed?
+1330,"@@ -34,6 +34,11 @@
+  * by asynch interrupt.
+  */
+
++/* clang-format off */
++/* XXX: clang-format incorrectly detected a tab difference at ""clang-format on""
++ * below. This is why ""clang-format off"" has been moved outside the ifdef until
++ * bug is fixed.
++ */
+ #ifndef ASM_CODE_ONLY /* C code */
+ #    include ""configure.h""
+ #    ifndef UNIX","A ""tab difference""? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?",I don't understand this. Why has this been moved out
+1331,"@@ -31,12 +31,7 @@ import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.grid.sessionmap.local.LocalSessionMap;
+ import org.openqa.selenium.netty.server.NettyServer;
+ import org.openqa.selenium.remote.SessionId;
+-import org.openqa.selenium.remote.http.HttpClient;
+-import org.openqa.selenium.remote.http.HttpHandler;
+-import org.openqa.selenium.remote.http.HttpRequest;
+-import org.openqa.selenium.remote.http.HttpResponse;
+-import org.openqa.selenium.remote.http.TextMessage;
+-import org.openqa.selenium.remote.http.WebSocket;
++import org.openqa.selenium.remote.http.*;
+ import org.openqa.selenium.remote.tracing.DefaultTestTracer;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ ",Could you please leave the explicit imports?,Don't use wildcard imports.
+1332,"@@ -265,6 +265,9 @@ public abstract class GapicInterfaceConfig implements InterfaceConfig {
+     }
+     List<T> methodConfigs = new ArrayList<>();
+     for (MethodConfigProto methodConfigProto : interfaceConfigProto.getMethodsList()) {
++      if (methodConfigMap.get(methodConfigProto.getName()) == null) {
++        continue;
++      }
+       methodConfigs.add(methodConfigMap.get(methodConfigProto.getName()));
+     }
+     return methodConfigs;",Can we check for containsKey here?,"@GabrielBrascher We can't have more than one method config in the configMap, right? Or am I missing something?"
+1333,"@@ -35,9 +35,14 @@ import (
+ 	""golang.org/x/tools/go/types/typeutil""
+ )
+
++const usage = ""usage: wire [gen] [PKG] | wire show [...] | wire check [...]""
++
+ func main() {
+ 	var err error
+ 	switch {
++	case len(os.Args) == 2 && (os.Args[1] == ""help"" || os.Args[1] == ""-h"" || os.Args[1] == ""-help"" || os.Args[1] == ""--help""):
++		fmt.Fprintln(os.Stderr, usage)
++		os.Exit(2)
+ 	case len(os.Args) == 1 || len(os.Args) == 2 && os.Args[1] == ""gen"":
+ 		err = generate(""."")
+ 	case len(os.Args) == 2 && os.Args[1] == ""show"":",Exit successfully. We served the help the user wanted.,"It would be nice if this was a bit more human-readable. For example, something like: `usage: wire [gen] [PKG] "
+1334,"@@ -15,13 +15,13 @@ import (
+ // RepoRoot is the root of the Please repository
+ var RepoRoot string
+
+-// initialWorkingDir is the directory we began in. Early on we chdir() to the repo root but for
++// InitialWorkingDir is the directory we began in. Early on we chdir() to the repo root but for
+ // some things we need to remember this.
+-var initialWorkingDir string
++var InitialWorkingDir string
+
+-// initialPackage is the initial subdir of the working directory, ie. what package did we start in.
+-// This is similar but not identical to initialWorkingDir.
+-var initialPackage string
++// InitialPackagePath is the initial subdir of the working directory, ie. what package did we start in.
++// This is similar but not identical to InitialWorkingDir.
++var InitialPackagePath string
+
+ // usingBazelWorkspace is true if we detected a Bazel WORKSPACE file to find our repo root.
+ var usingBazelWorkspace bool",Had to rename this because `InitialPackage()` already existed.,why not just call it `workingDir`?
+1335,"@@ -19,4 +19,15 @@ module IntegrationSpecHelper
+       }
+     )
+   end
++
++  def with_18f_procurement_env_variables(setup_vars=nil)
++    old_approver_email = ENV['GSA18F_APPROVER_EMAIL']
++    old_purchaser_email = ENV['GSA18F_PURCHASER_EMAIL']
++
++    ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'
++    ENV['GSA18F_PURCHASER_EMAIL'] = 'test_purchaser@some-dot-gov.gov'
++    yield
++    ENV['GSA18F_APPROVER_EMAIL'] = old_approver_email
++    ENV['GSA18F_PURCHASER_EMAIL'] = old_purchaser_email
++  end
+ end",Can we put this in a different helper?,Line is too long. [98/80]
+1336,"@@ -603,6 +603,9 @@ insert_push_all_registers(dcontext_t *dcontext, clean_call_info_t *cci,
+                                   DR_REG_LIST_LENGTH_ARM, DR_REG_LIST_ARM));
+     }
+     dstack_offs += 15 * XSP_SZ;
++
++    /* Make dstack_offs 8-byte algined, as we only accounted for 31 4-byte slots */
++    dstack_offs += XSP_SZ;
+     ASSERT(cci->skip_save_flags    ||
+            cci->num_simd_skip != 0 ||
+            cci->num_regs_skip != 0 ||","I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD.",It's probably better to move this to the bottom of the file.
+1337,"@@ -46,4 +46,10 @@ public class Info extends AbstractApiBean {
+     public Response getServer() {
+         return response( req -> ok(systemConfig.getDataverseServer()));
+     }
++
++    @GET
++    @Path(""apiTermsOfUse"")
++    public Response getTermsOfUse() {
++        return response( req -> ok(systemConfig.getApiTermsOfUse()));
++    }
+ }","If you want, you could change this to `allowCors(response` (like in ""version"", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set.","Shouldn't this be `@Path(""/apiTermsOfUse"")`?"
+1338,"@@ -1616,4 +1616,9 @@ public class MessageList extends K9Activity implements MessageListFragmentListen
+             }
+         }
+     }
++
++    @Override
++    public void onConfigurationChanged(Configuration newConfig) {
++        super.onConfigurationChanged(newConfig);
++    }
+ }",Why do we need to override this if all we're doing is passing it up?,Shouldn't this be `super.onConfigurationChanged(newConfig)`?
+1339,"@@ -356,6 +356,9 @@ void CmpSeabaseDDL::createSeabaseTableLike(
+         query += keyClause;
+       }
+
++  // send any user CQDs down
++  Lng32 retCode = sendAllControls(FALSE, FALSE, TRUE);
++
+   ExeCliInterface cliInterface(STMTHEAP, NULL, NULL,
+   CmpCommon::context()->sqlSession()->getParentQid());
+ ","Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?",Shouldn't there be a check here to make sure the query is va
+1340,"@@ -1,11 +1,16 @@
+ import os
+
++import packaging.version
++import requests
++
+ from ..defines import GCP_CREDS_LOCAL_FILE
+ from ..module_build_spec import ModuleBuildSpec
+ from ..utils import connect_sibling_docker_container, network_buildkite_container
+ from .test_images import publish_test_images, test_image_depends_fn
+
+ SCRIPT_PATH = os.path.dirname(os.path.abspath(__file__))
++DAGSTER_FROM_SOURCE = ""current_branch""
++DAGSTER_EARLIEST_RELEASE = ""0.12.4""
+
+
+ def integration_suite_extra_cmds_fn(version):",EARLIEST_TESTED_RELEASE might be slightly more clear,"Is this actually the source of the flake8 line? If so, it needs to be changed to `current_branch`"
+1341,"@@ -81,7 +81,7 @@ MSG_STATE_CONFIDENCE = 2
+ # Allow stopping after the first semicolon/hash encountered,
+ # so that an option can be continued with the reasons
+ # why it is active or disabled.
+-OPTION_RGX = re.compile(r""\s*#.*\bpylint:\s*([^;#]+)[;#]{0,1}"")
++OPTION_RGX = re.compile(r'.*#\s*pylint:\s*([^;#]+)[;#]?.*')
+
+ # The line/node distinction does not apply to fatal errors and reports.
+ _SCOPE_EXEMPT = ""FR""","I think replacing `.*` with `\s*` from after the hash makes sense, but not the rest of the changes.",This regex was incorrect and so was not a typo.
+1342,"@@ -220,6 +220,8 @@ type NetworkPolicyRule struct {
+ 	// action “nil” defaults to Allow action, which would be the case for rules created for
+ 	// K8s Network Policy.
+ 	Action *secv1alpha1.RuleAction `json:""action,omitempty"" protobuf:""bytes,6,opt,name=action,casttype=github.com/vmware-tanzu/antrea/pkg/apis/security/v1alpha1.RuleAction""`
++	// EnableLogging indicates whether or not to generate logs when rules are matched. Default to false.
++	EnableLogging bool `json:""enableLogging"" protobuf:""varint,7,opt,name=enableLogging""`
+ }
+
+ // Protocol defines network protocols supported for things like container ports.",interesting .. did not know varint tag covered bool as well,"Should we have an option to disable logging, defaulting to `false`?"
+1343,"@@ -35,6 +35,11 @@ struct st_duration_stats_t {
+     struct gkc_summary *process_time;
+     struct gkc_summary *response_time;
+     struct gkc_summary *total_time;
++
++    /**
++     * average event loop latency per worker thread
++     */
++    H2O_VECTOR(uint64_t) evloop_latency_ms;
+ };
+
+ struct st_duration_agg_stats_t {","Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms.","This feels a little bit awkward. How about ""process_latency_ms"" ?"
+1344,"@@ -187,7 +187,7 @@ Block.prototype.getTransactionHashes = function getTransactionHashes() {
+     return [Block.Values.NULL_HASH];
+   }
+   for (var t = 0; t < this.txs.length; t++) {
+-    hashes.push(this.txs[t].hash());
++    hashes.push(this.txs[t]._getHash());
+   }
+   return hashes;
+ };",getHash should be a public and without an `_` if used here.,"I think we can remove the `hash` method entirely, since we are only using it internally now"
+1345,"@@ -71,6 +71,10 @@ func (dv *DefaultBlockValidator) ValidateSemantic(ctx context.Context, child *ty
+
+ // ValidateSyntax validates a single block is correctly formed.
+ func (dv *DefaultBlockValidator) ValidateSyntax(ctx context.Context, blk *types.Block) error {
++	// hack validate genesisblock
++	if blk.Height == 0 {
++		return nil
++	}
+ 	now := uint64(dv.Now().Unix())
+ 	if uint64(blk.Timestamp) > now {
+ 		return fmt.Errorf(""block %s with timestamp %d generate in future at time %d"", blk.Cid().String(), blk.Timestamp, now)",Unrelated to these changes -- we will probably want some special handling for genesis block validation.,why do we need this hack?
+1346,"@@ -75,6 +75,10 @@ type diskBlockCacheSetter interface {
+ 	MakeDiskBlockCacheIfNotExists() error
+ }
+
++type diskBlockCacheFractionSetter interface {
++	SetDiskBlockCacheFraction(float64)
++}
++
+ type clockGetter interface {
+ 	Clock() Clock
+ }","This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!",why is this not a pointer anymore?
+1347,"@@ -56,6 +56,8 @@ func (d *Driver) AddPeer(ctx context.Context, addr swarm.Address) error {
+ 		d.mtx.Unlock()
+ 		return nil
+ 	}
++
++	d.receivedPeers[addr.ByteString()] = struct{}{}
+ 	d.mtx.Unlock()
+
+ 	connectedPeers := d.p2pService.Peers()","@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?","I think we need a lock here. Otherwise, we can end up with a situation where we have two co"
+1348,"@@ -0,0 +1,19 @@
++<% if display_response_actions?(cart, current_user) %>
++  <div id='reply-section'>
++    <p>
++      <%= link_to ""Approve"",
++          approval_response_path(approver_action: 'approve',
++                                 cart_id: cart.id,
++                                 scheme: 'https',
++                                 user_id: current_user.id,
++                                 ), class: 'form-button' %>
++
++      <%= link_to ""Reject"",
++          approval_response_path(approver_action: 'reject',
++                                 cart_id: cart.id,
++                                 scheme: 'https',
++                                 user_id: current_user.id,
++                                 ), class: 'reject-link' %>
++    </p>
++  </div>
++<% end %>",Minor: can we put the conditional outside of the partial?,Can't we use `approve-link` here?
+1349,"@@ -887,7 +887,8 @@ class AsyncSniffer(object):
+
+                 if isinstance(offline, Packet):
+                     tempfile_written, offline = _write_to_pcap([offline])
+-                elif isinstance(offline, list) and \
++                elif (isinstance(offline, list) or
++                        isinstance(offline, PacketList)) and \
+                         all(isinstance(elt, Packet) for elt in offline):
+                     tempfile_written, offline = _write_to_pcap(offline)
+ ",We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent..,"instead of `isinstance(offline, P"
+1350,"@@ -29,6 +29,9 @@ var (
+ executions and is good for jobs which need to run frequently. ""Fixed Schedule""
+ lets you use a predefined or custom cron schedule and is good for less-frequent
+ jobs or those which require specific execution schedules.`
++
++	fmtJobInitTypeHelp = `A %s is a task which can be programmatically run, either on a schedule or via
++service code in response to events.`
+ )
+
+ const (","How "" via service code in response to event.""? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way",Nit: I think the first sentence i
+1351,"@@ -65,7 +65,6 @@ PER_YIELD = 1024
+
+ def generate_model_handle():
+     """"""Generate random model handle.
+-
+     Returns:
+         str: random bytes for handle
+     """"""",Please move unrelated formatting changes to their own PR (same with the resources.py file).,why did you remove this line?
+1352,"@@ -2171,6 +2171,7 @@ class CommandDispatcher:
+
+         window = self._tabbed_browser.window()
+         if window.isFullScreen():
+-            window.showNormal()
++            window.setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)
+         else:
++            window._state_before_fullscreen = window.windowState()
+             window.showFullScreen()",Make this a public attribute (remove the leading `_`) if you want to access it from the outside.,"This is the only place where we use this `_state_before_fullscreen`. I think we should be setting it directly in `showFullScreen`, and only setting it in `setFullscreenState` if it's needed."
+1353,"@@ -116,7 +116,7 @@ define(['layoutManager', 'browser', 'actionsheet', 'css!./emby-select', 'registe
+             inputId++;
+         }
+
+-        if (!browser.firefox) {
++        if (browser) {
+             this.classList.add('emby-select-withcolor');
+
+ 			if (layoutManager.tv) {",this conditional is useless now so it should be removed,"This was actually a bug, right? It should be `if (!browser.firefox) {`"
+1354,"@@ -262,8 +262,8 @@ void AccessFlatBufferTest(const uint8_t *flatbuf, size_t length,
+   auto vecofstructs = monster->testarrayofsortedstruct();
+   if (vecofstructs) {  // not filled in monster_test.bfbs
+     for (size_t i = 0; i < vecofstructs->size()-1; i++) {
+-      auto left = vecofstructs->Get(i);
+-      auto right = vecofstructs->Get(i+1);
++      auto left = vecofstructs->Get(static_cast<flatbuffers::uoffset_t>(i));
++      auto right = vecofstructs->Get(static_cast<flatbuffers::uoffset_t>(i+1));
+       TEST_EQ(true, (left->KeyCompareLessThan(right)));
+     }
+     TEST_NOTNULL(vecofstructs->LookupByKey(3));","`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts.",">static_cast<flatbuffers::uoffset_t>(i) [](start = 28, length = 28) No need of `static_cast`, right?"
+1355,"@@ -197,7 +197,14 @@ public abstract class GapicProductConfig implements ProductConfig {
+     }
+
+     // Toggle on/off proto annotations parsing.
+-    ProtoParser protoParser = new ProtoParser(getDefaultLanguageFeatureConfig(language, null));
++    ProtoParser protoParser;
++    // TODO(andrealin): Expose command-line option for toggling proto annotations parsing.
++    if (configProto == null) {
++      // By default, enable proto annotations parsing when no GAPIC config is given.
++      protoParser = new ProtoParser(true);
++    } else {
++      protoParser = new ProtoParser(getDefaultLanguageFeatureConfig(language, null));
++    }
+     if (configProto == null) {
+       configProto = ConfigProto.getDefaultInstance();
+     }","Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer.",@andrewkroh Can you take a look at this change? It seems to me you don't want to parse GAPIC config if there is no GAPIC config. That means you can only parse GAPIC config if there is no GAP
+1356,"@@ -138,7 +138,7 @@ describe.skip('Buffering Proxy', function() {
+           if (die) {
+             request.connection.destroy();
+           } else {
+-            if (doc.ismaster) {
++            if (doc.ismaster || doc.hello) {
+               request.reply(primary[currentIsMasterIndex]);
+             } else if (doc.insert) {
+               request.reply({ ok: 1, n: 1 });","I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution",why is this needed?
+1357,"@@ -7,6 +7,10 @@
+   <%= json_api_link_tag %>
+ <% end %>
+
++<% content_for(:skip_links) do -%>
++  <a href=""#documents"" class=""element-invisible element-focusable"" data-turbolinks=""false"">Skip to first result</a>
++<% end %>
++
+ <% content_for(:container_header) do -%>
+   <h1 class=""sr-only top-content-title""><%= t('blacklight.search.header') %></h1>
+ ","I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option).",I think we should a
+1358,"@@ -1323,11 +1323,9 @@ VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceDisplayPropertiesKHR(VkPhysicalD
+         instance_data->instance_dispatch_table.GetPhysicalDeviceDisplayPropertiesKHR(physicalDevice, pPropertyCount, pProperties);
+
+     lock.lock();
+-    if (result == VK_SUCCESS) {
+-        if (pProperties) {
+-            for (uint32_t i = 0; i < *pPropertyCount; ++i) {
+-                CreateObject(physicalDevice, pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
+-            }
++    if ((result == VK_SUCCESS || result == VK_INCOMPLETE) && pProperties) {
++        for (uint32_t i = 0; i < *pPropertyCount; ++i) {
++            CreateObject(physicalDevice, pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
+         }
+     }
+     lock.unlock();",This was already in vkGetPhysicalDeviceDisplayProperties2KHR...,This change is no l
+1359,"@@ -498,3 +498,7 @@ type tasksStopper interface {
+ type serviceLinkedRoleCreator interface {
+ 	CreateECSServiceLinkedRole() error
+ }
++
++type dockerEngineValidator interface {
++	IsDockerEngineRunning() (string, error)
++}","nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`",why is this in the
+1360,"@@ -322,12 +322,12 @@ def define_model(model_name, dbengine, model_seed):
+         cai_resource_name = Column(String(4096))
+         cai_resource_type = Column(String(512))
+         full_name = Column(String(2048), nullable=False)
+-        type_name = Column(get_string_by_dialect(dbengine.dialect.name, 512),
++        type_name = Column(get_string_by_dialect(dbengine.dialect.name, 700),
+                            primary_key=True)
+         parent_type_name = Column(
+-            get_string_by_dialect(dbengine.dialect.name, 512),
++            get_string_by_dialect(dbengine.dialect.name, 700),
+             ForeignKey('{}.type_name'.format(resources_tablename)))
+-        name = Column(String(256), nullable=False)
++        name = Column(String(1024), nullable=False)
+         type = Column(String(128), nullable=False)
+         policy_update_counter = Column(Integer, default=0)
+         display_name = Column(String(256), default='')","If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size",Why is this change needed?
+1361,"@@ -20,6 +20,13 @@ def GetSizePrefix(buf, offset):
+ 	""""""Extract the size prefix from a buffer.""""""
+ 	return encode.Get(packer.int32, buf, offset)
+
++def GetBufferIdentifier(buf, offset, size_prefixed = False):
++        """"""Extract the file_identifier from a buffer""""""
++        offset+=(number_types.UOffsetTFlags.bytewidth if size_prefixed else 0) + number_types.UOffsetTFlags.bytewidth # offset sizeof(root table offset) + sizeof(size prefix) if present
++        return buf[offset:offset+encode.FILE_IDENTIFIER_LENGTH]
++def BufferHasIdentifier(buf, offset, file_identifier, size_prefixed = False):
++        return GetBufferIdentifier(buf, offset, size_prefixed)==file_identifier
++
+ def RemoveSizePrefix(buf, offset):
+ 	""""""
+ 	Create a slice of a size-prefixed buffer that has","When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments.",what's the difference betw
+1362,"@@ -41,7 +41,7 @@ class BasicResBlock(nn.Module):
+             out_channels,
+             kernel_size=1,
+             bias=False,
+-            activation=None,
++            act_cfg=None,
+             conv_cfg=conv_cfg,
+             norm_cfg=norm_cfg)
+ ","We may follow the argument order: conv_cfg, norm_cfg, act_cfg.",what is the default value
+1363,"@@ -60,6 +60,19 @@ module Selenium
+
+         class << self
+           def chrome(opts = {})
++            define_method(:options) { @capabilities[:chrome_options] ||= {} }
++            define_method(""options="") { |value| @capabilities[:chrome_options] = value }
++            define_method(""profile="") do |profile|
++              profile_json = profile.as_json
++              options['args'] ||= []
++              if options['args'].none? { |arg| arg =~ /user-data-dir/ }
++                options['args'] << ""--user-data-dir=#{profile_json[:directory]}""
++              end
++              options['extensions'] = profile_json[:extensions]
++            end
++            alias_method :chrome_options, :options
++            alias_method :chrome_options=, :options=
++
+             new({
+               browser_name: 'chrome',
+               javascript_enabled: true,",`options['binary'] = WebDriver::Chrome.path` if set?,this should probably be `o
+1364,"@@ -5,6 +5,7 @@
+  */
+
+ #include <errno.h>
++#include <folly/ssl/Init.h>
+ #include <signal.h>
+ #include <string.h>
+ #include <thrift/lib/cpp2/server/ThriftServer.h>",folly library should be put on the top.,What's the point of this change?
+1365,"@@ -35,6 +35,7 @@ let CAMEL_REG = /-?(?=[A-Z])/g;
+ function setProperty(dom, name, value, oldValue, isSvg) {
+ 	let v;
+ 	if (name==='class' || name==='className') name = isSvg ? 'class' : 'className';
++	const ns = isSvg && (name !== (name = name.replace(/^xlink:?/, '')));
+
+ 	if (name==='style') {
+ ","Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?",Why the check for `xlink:?`? Sho
+1366,"@@ -134,7 +134,7 @@ class DataProvider {
+    * @returns {boolean}
+    */
+   _isHiddenRow(row) {
+-    return this.hot.hasHook('hiddenRow') && this.hot.runHooks('hiddenRow', row);
++    return this.hot.rowIndexMapper.isHidden(this.hot.toPhysicalRow(row));
+   }
+
+   /**",Please add it to the `REMOVED_HOOKS` constant.,Does this mean we can remove the
+1367,"@@ -1,7 +1,9 @@
+ describe('fieldset', function () {
+ 	'use strict';
+ 	var fixture = document.getElementById('fixture');
++	var shadowSupport = axe.testUtils.shadowSupport;
+ 	var fixtureSetup = axe.testUtils.fixtureSetup;
++
+ 	var checkContext = {
+ 		_data: null,
+ 		data: function (d) {","This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result",The variable should be called `s
+1368,"@@ -25,6 +25,12 @@ class AccountsController < ApplicationController
+     render json: Chart.new(@account).commits_by_language(params[:scope])
+   end
+
++  def label_as_spammer
++    @account = Account.find_by(id: params[:id])
++    Account::Access.new(@account).spam!
++    render template: 'accounts/disabled'
++  end
++
+   private
+
+   def account",Is this access protected so that only admins can access this route?,Wouldn't it be better to load the account if it's disabled? `@account.disabled`
+1369,"@@ -328,7 +328,7 @@ void wlr_output_layout_closest_point(struct wlr_output_layout *layout,
+ 		return;
+ 	}
+
+-	double min_x = DBL_MAX, min_y = DBL_MAX, min_distance = DBL_MAX;
++	double min_x = 0, min_y = 0, min_distance = DBL_MAX;
+ 	struct wlr_output_layout_output *l_output;
+ 	wl_list_for_each(l_output, &layout->outputs, link) {
+ 		if (reference != NULL && reference != l_output->output) {","What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?",Please use `DBL_MAX` instead of `DBL_MAX`.
+1370,"@@ -1637,6 +1637,11 @@ func (o *consumer) processNextMsgReq(_ *subscription, c *client, _, reply string
+ 		return
+ 	}
+
++	if o.maxp > 0 && batchSize > o.maxp {
++		sendErr(409, ""Exceeded MaxAckPending"")
++		return
++	}
++
+ 	// In case we have to queue up this request.
+ 	wr := waitingRequest{client: c, reply: reply, n: batchSize, noWait: noWait, expires: expires}
+ ",I think you want to look at current pending + batchSize and if that is > o.maxp no?,should this be a constant somewhere?
+1371,"@@ -189,7 +189,7 @@ func (h *Harness) testSpan(tracerFactory func() trace.Tracer) {
+ 			span.AddEventWithTimestamp(context.Background(), time.Now(), ""test event"")
+ 		},
+ 		""#SetStatus"": func(span trace.Span) {
+-			span.SetStatus(codes.Internal, ""internal"")
++			span.SetStatus(codes.Ok, ""internal"")
+ 		},
+ 		""#SetName"": func(span trace.Span) {
+ 			span.SetName(""new name"")",Should this be `codes.Error`? `codes.Internal` was an error status before.,I noticed that `internal` is used only in test cases. Would it make more sense
+1372,"@@ -26,6 +26,11 @@ class AccountsController < ApplicationController
+     @projects, @logos = @account.project_core.used
+     @twitter_detail = TwitterDetail.new(@account)
+     page_context[:page_header] = 'accounts/show/header'
++    respond_to do |format|
++      format.html
++      format.xml
++      format.json
++    end
+   end
+
+   def me",I don't think you need these lines.,This is what I was talking about the other day
+1373,"@@ -195,7 +195,7 @@ type tlfJournal struct {
+ 	// Invariant: this tlfJournal acquires exactly
+ 	// blockJournal.getStoredBytes() and
+ 	// blockJournal.getStoredFiles() until shutdown.
+-	DiskLimiter DiskLimiter
++	diskLimiter DiskLimiter
+
+ 	// All the channels below are used as simple on/off
+ 	// signals. They're buffered for one object, and all sends are","You didn't mean to export this, right?","Unrelated to this PR, but it would be nice if th"
+1374,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-show-topics.rb demonstrates how to list Amazon Simple Notification Services (SNS) topics using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",Simple Notification **Service** (singular),Metrics/LineLength: Line is too long. [97/80]
+1375,"@@ -313,6 +313,7 @@ type client struct {
+ 	replayMutex   sync.RWMutex
+ 	nodeConfig    *config.NodeConfig
+ 	networkConfig *config.NetworkConfig
++	egressConfig  *config.EgressConfig
+ 	gatewayOFPort uint32
+ 	// ovsDatapathType is the type of the datapath used by the bridge.
+ 	ovsDatapathType ovsconfig.OVSDatapathType",Do we still need this?,"Is this a pointer? If so, can we make it a point"
+1376,"@@ -108,9 +108,6 @@ public abstract class AbstractEeaSendRawTransaction implements JsonRpcMethod {
+         final Transaction privateMarkerTransaction =
+             createPrivateMarkerTransaction(privateTransaction, user);
+
+-        LOG.error(""CHEESE"");
+-        LOG.error(privateMarkerTransaction.getHash());
+-
+         return transactionPool
+             .addLocalTransaction(privateMarkerTransaction)
+             .either(",We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?,this should have been removed
+1377,"@@ -217,7 +217,7 @@ import 'css!./imageeditor';
+             reload(context, null, focusContext);
+         }, function () {
+             import('alert').then(({default: alert}) => {
+-                alert(globalize.translate('DefaultErrorMessage'));
++                alert(globalize.translate('MessageDefaultError'));
+             });
+         });
+     }",This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?,Just wondering what's the mot
+1378,"@@ -35,12 +35,13 @@ import (
+ 	""antrea.io/antrea/pkg/features""
+ )
+
+-func skipIfNetworkPolicyStatsDisabled(tb testing.TB, data *TestData) {
+-	skipIfFeatureDisabled(tb, data, features.NetworkPolicyStats, true, true)
++func skipIfNetworkPolicyStatsDisabled(tb testing.TB) {
++	skipIfFeatureDisabled(tb, features.NetworkPolicyStats, true, true)
+ }
+
+-func TestNetworkPolicyStats(t *testing.T) {
+-	skipIfNotIPv4Cluster(t)
++// TestNetworkPolicy is the top-level test which contains all subtests for
++// NetworkPolicy related test cases so they can share setup, teardown.
++func TestNetworkPolicy(t *testing.T) {
+ 	skipIfHasWindowsNodes(t)
+
+ 	data, err := setupTest(t)",I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898,What is the benefit of this f
+1379,"@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti
+ 	epType := tc.EpTypeHost
+ 	if ifaceName == ""tunl0"" {
+ 		epType = tc.EpTypeTunnel
++	} else if ifaceName == ""wireguard.cali"" {
++		epType = tc.EpTypeWireguard
+ 	}
+ 	ap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)
+ 	ap.HostIP = m.hostIP",nit: a switch perhaps?,epType = tc.EpTypeWireguard
+1380,"@@ -14,7 +14,7 @@
+     <![endif]-->
+
+     <title><%= render_page_title %></title>
+-    <link href=""<%= opensearch_catalog_path(:format => 'xml', :only_path => false) %>"" title=""<%= application_name%>"" type=""application/opensearchdescription+xml"" rel=""search""/>
++    <%= opensearch_description_tag application_name, opensearch_catalog_path(:format => 'xml', :only_path => false) %>
+     <%= favicon_link_tag asset_path('favicon.ico') %>
+     <%= stylesheet_link_tag    ""application"" %>
+     <%= javascript_include_tag ""application"" %>",Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?,Use the new hash syntax `format: :format`.
+1381,"@@ -281,7 +281,7 @@ func (j journalMDOps) getRange(
+ 	[]ImmutableRootMetadata, error) {
+ 	// Grab the range from the journal first.
+ 	jirmds, err := j.getRangeFromJournal(ctx, id, bid, mStatus, start, stop)
+-	if err != nil {
++	if err != nil && err != errTLFJournalDisabled {
+ 		return nil, err
+ 	}
+ ",Just noticed this while debugging -- it's unlikely to be causing issues in practice.,This is the only real change to this file.
+1382,"@@ -75,7 +75,7 @@ describe( 'setting up the Analytics module with no existing account and no exist
+ 		await expect( page ).toClick( '.googlesitekit-analytics__select-country' );
+ 		await expect( page ).toClick( '.mdc-menu-surface--open li', { text: /united kingdom/i } );
+
+-		await expect( page ).toMatchElement( 'p', { text: /need to give Site Kit permission to create an Analytics account/i } );
++		await expect( page ).toMatchElement( 'p', { text: /need to give Site Kit permission to create an Analytics account/i, timeout: 750 } );
+
+ 		await Promise.all( [
+ 			page.waitForNavigation(), // User is sent directly to OAuth.",That seems unrelated - did that fix a random test failure you noticed while working on this issue?,We can remove the `timeout: 750` part now.
+1383,"@@ -98,8 +98,11 @@ public abstract class BaseMetastoreTableOperations implements TableOperations {
+       LOG.info(""Nothing to commit."");
+       return;
+     }
++    TableMetadata updated = (base != null && base.file() != null) ?
++            metadata.addPreviousMetadata(base.file().location(), base.lastUpdatedMillis()) : metadata;
+
+-    doCommit(base, metadata);
++    doCommit(base, updated);
++    deleteRemovedMetadata(updated);
+     requestRefresh();
+   }
+ ","This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it.",Can't we just do metadata.addPreviousMetad
+1384,"@@ -82,3 +82,18 @@ def flip_tensor(src_tensor, flip_direction):
+     else:
+         out_tensor = torch.flip(src_tensor, [2, 3])
+     return out_tensor
++
++
++def collect_mlvl_tensor_single(mlvl_tensors, batch_id, detach=True):
++    assert isinstance(mlvl_tensors, (list, tuple))
++    num_levels = len(mlvl_tensors)
++
++    if detach:
++        mlvl_tensor_list = [
++            mlvl_tensors[i][batch_id].detach() for i in range(num_levels)
++        ]
++    else:
++        mlvl_tensor_list = [
++            mlvl_tensors[i][batch_id] for i in range(num_levels)
++        ]
++    return mlvl_tensor_list",We need to know why all the tensors are detached in `get_bboxed`.,"it would be better to use `.detach()` instead of `.detach()` in the case of `not isinstance(mlvl_tensors, list)`."
+1385,"@@ -309,3 +309,13 @@ class Foo:
+
+     def method(self):
+         print(self.__class__.__ham)
++
++
++class TypeSelfCallInMethod:
++    """"""Regression test for issue 5569""""""
++    @classmethod
++    def b(cls) -> None:
++        cls.__a = ''  # [unused-private-member]
++
++    def a(self):
++        return type(self).__a",Unrelated but shouldn't this raise `attribute-defined-outside-init`?,Add docstring explaining why this is regression.
+1386,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low.",why are we making this change to create_no_window?
+1387,"@@ -98,8 +98,7 @@ class Phase < ActiveRecord::Base
+   # TODO: Move this to Plan model as `num_answered_questions(phase=nil)`
+   # Returns the number of answered question for the phase.
+   def num_answered_questions(plan)
+-    return 0 if plan.nil?
+-    sections.to_a.sum { |s| s.num_answered_questions(plan) }
++    plan&.num_answered_questions.to_i
+   end
+
+   # Returns the number of questions for a phase. Note, this method becomes useful",You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!,Should this be `return 0 if plan.nil?` instead?
+1388,"@@ -23,9 +23,10 @@
+       <div class=""checkbox"">
+         <%= f.label :published, raw(""#{f.check_box :published, as: :check_boxes, 'data-toggle': 'tooltip', title: _(""Check this box when you are ready for this guidance to appear on user's plans."")} #{_('Published?')}"") %>
+       </div>
+-
+-      <%= f.submit _('Save'), name: ""edit_guidance_submit"", class: ""btn btn-primary"" %>
+-      <%= link_to _('Cancel'), admin_index_guidance_path, class: ""btn btn-primary"", role: 'button' %>
++      <div class=""form-group clear-fix"">
++        <%= f.submit _('Save'), name: ""edit_guidance_submit"", class: ""btn btn-primary"" %>
++        <%= link_to _('Cancel'), admin_index_guidance_path, class: ""btn btn-primary"", role: 'button' %>
++      </div>
+     <%end%>
+   </div>
+ </div>",do you mean 'clearfix' class?,"I'm not sure if I should add a `form-group` here since there's only one group, but it's probably better to add the `role=button` as a child of the previous `form-group`."
+1389,"@@ -391,6 +391,7 @@ MongoClient.connect = function(url, options, callback) {
+  * Starts a new session on the server
+  *
+  * @param {SessionOptions} [options] optional settings for a driver session
++ * @param {boolean} [options.causalConsistency=true] Enables or disables causal consistency for the session.
+  * @return {ClientSession} the newly established session
+  */
+ MongoClient.prototype.startSession = function(options) {",`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here.,I think this should be `[options.causalConsistency]` not `true`.
+1390,"@@ -46,9 +46,7 @@ import java.lang.reflect.Method;
+
+ import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
+ import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
+-import static org.mockito.ArgumentMatchers.any;
+-import static org.mockito.ArgumentMatchers.anyString;
+-import static org.mockito.ArgumentMatchers.eq;
++import static org.mockito.ArgumentMatchers.*;
+ import static org.mockito.Mockito.*;
+
+ /**",This should not be included since there are no code changes.,We usually don't use star imports. Please revert.
+1391,"@@ -56,6 +56,18 @@ func askCredentials(c *context.Context, status int, text string) {
+
+ func HTTPContexter() macaron.Handler {
+ 	return func(c *context.Context) {
++		if len(setting.HTTP.AccessControlAllowOrigin) > 0 {
++			// Set CORS headers for browser-based git clients
++			c.Resp.Header().Set(""Access-Control-Allow-Origin"", setting.HTTP.AccessControlAllowOrigin)
++			c.Resp.Header().Set(""Access-Control-Allow-Headers"", ""Content-Type, Authorization"")
++
++			// Handle preflight OPTIONS request
++			if c.Req.Method == ""OPTIONS"" {
++				c.Status(http.StatusOK)
++				return
++			}
++		}
++
+ 		ownerName := c.Params("":username"")
+ 		repoName := strings.TrimSuffix(c.Params("":reponame""), "".git"")
+ 		repoName = strings.TrimSuffix(repoName, "".wiki"")","If all we need just response 200, then we could use `c.Status(http.StatusOK)` here.",Would it make sense to also try to set this header even if CORS is disabled?
+1392,"@@ -683,6 +683,11 @@ func loadConfigFromDatastore(
+ 		Name:      ""node."" + hostname,
+ 		Namespace: """",
+ 	}, """")
++	n, err := client.Get(ctx, model.ResourceKey{
++		Kind:      apiv2.KindNode,
++		Name:      hostname,
++		Namespace: """",
++	}, """")
+ 	if _, ok := err.(errors2.ErrorResourceDoesNotExist); err != nil && !ok {
+ 		return
+ 	}",Should be checking for error here,is this a bug fix?
+1393,"@@ -431,7 +431,7 @@ class Form extends WidgetBase
+             $this->fields = [];
+         }
+
+-        $this->allTabs->outside = new FormTabs(FormTabs::SECTION_OUTSIDE, $this->config);
++        $this->allTabs->outside = new FormTabs(FormTabs::SECTION_OUTSIDE, (array)$this->config);
+         $this->addFields($this->fields);
+
+         /*",Put a space between `(array)` and `$this` and I'll merge it,The type hint shou
+1394,"@@ -0,0 +1,6 @@
++package runtime
++
++// Stack is a stub, not implemented
++func Stack(buf []byte, all bool) int {
++	return 0
++}","You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for.",do we need this?
+1395,"@@ -0,0 +1,13 @@
++package com.fsck.k9.notification;
++
++
++class NotificationHolder {
++    public final int notificationId;
++    public final NotificationContent content;
++
++
++    public NotificationHolder(int notificationId, NotificationContent content) {
++        this.notificationId = notificationId;
++        this.content = content;
++    }
++}","the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other",please add the lic
+1396,"@@ -23,10 +23,7 @@
+  */
+ package net.runelite.client.plugins.freezetimers;
+
+-import java.util.ArrayList;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
+ import javax.inject.Singleton;
+ import lombok.extern.slf4j.Slf4j;
+ import net.runelite.api.Actor;",Avoid wildcard imports,import \* is against style
+1397,"@@ -71,7 +71,7 @@ type (
+ 		GetContractState(hash.PKHash, hash.Hash32B) (hash.Hash32B, error)
+ 		SetContractState(hash.PKHash, hash.Hash32B, hash.Hash32B) error
+ 		// Candidate pool
+-		candidates() (uint64, []*Candidate)
++		Candidates() (uint64, []*Candidate)
+ 		CandidatesByHeight(uint64) ([]*Candidate, error)
+ 	}
+ ",Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method,why is this renamed?
+1398,"@@ -101,6 +101,13 @@ module.exports = function(url, options, callback) {
+         record = record[0].join('');
+         const parsedRecord = qs.parse(record);
+         const items = Object.keys(parsedRecord);
++        if (
++          Object.keys(items)
++            .map(k => k.toLowerCase())
++            .indexOf('loadbalanced') !== -1
++        ) {
++          return callback(new MongoParseError('Load balancer mode requires driver version 4+'));
++        }
+         if (items.some(item => item !== 'authSource' && item !== 'replicaSet')) {
+           return callback(
+             new MongoParseError('Text record must only set `authSource` or `replicaSet`')",same question here as I have on the other file regarding doing this check here vs L112 vs not at all,`loadbalanced` is a primit
+1399,"@@ -1,3 +1,5 @@
++// +build !openbsd
++
+ package fuse
+
+ import (",Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well.,We don't want to use `// +
+1400,"@@ -35,7 +35,6 @@ class BZAObject(dict):
+         self.token = None
+         self.log = logging.getLogger(self.__class__.__name__)
+         self.http_session = requests.Session()
+-        self.http_request = self.http_session.request
+
+         # copy infrastructure from prototype
+         if isinstance(proto, BZAObject):","this is used as important way of mocking for unit tests, FYI",why remove this?
+1401,"@@ -156,6 +156,7 @@ if not config.style_17:
+     options.Points = Options('plot', show_frame=True)
+
+ options.Histogram = Options('style', line_color='black', fill_color=Cycle())
++options.Distribution = Options('style', muted_alpha=0.2)
+ options.ErrorBars = Options('style', color='black')
+ options.Spread = Options('style', color=Cycle(), alpha=0.6, line_color='black')
+ options.Bars = Options('style', color=Cycle(), line_color='black', width=0.8)","Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above.",We usually don't
+1402,"@@ -566,7 +566,7 @@ namespace pwiz.SkylineTest
+             // Bad terminus
+             AssertEx.DeserializeError<StaticMod>(""<static_modification name=\""Mod\"" terminus=\""X\"" formula=\""C23N\"" />"");
+             // Bad formula
+-            AssertEx.DeserializeError<StaticMod, ArgumentException>(""<static_modification name=\""Mod\"" aminoacid=\""K\"" formula=\""C23NHe2\"" />"");
++            AssertEx.DeserializeError<StaticMod, ArgumentException>(""<static_modification name=\""Mod\"" aminoacid=\""K\"" formula=\""C23NHx2\"" />"");
+             // Terminal label without amino acid
+             AssertEx.DeserializeError<StaticMod>(""<static_modification name=\""15N\"" terminus=\""C\"" label_13C=\""true\""/>"");
+             // Formula and labeled atoms","Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?",What's the reaso
+1403,"@@ -486,6 +486,12 @@ class histogram(Operation):
+     bin_range = param.NumericTuple(default=None, length=2,  doc=""""""
+       Specifies the range within which to compute the bins."""""")
+
++    bins = param.ClassSelector(default=None, class_=(np.ndarray, list), doc=""""""
++      An explicit set of bin edges."""""")
++
++    cumulative = param.Boolean(default=False, doc=""""""
++      Whether to compute the cumulative histogram"""""")
++
+     dimension = param.String(default=None, doc=""""""
+       Along which dimension of the Element to compute the histogram."""""")
+ ",What about tuples or pandas series? Do we want to support lots of different types or force a single type?,why do you need
+1404,"@@ -294,10 +294,6 @@ public class ZkStateReader implements SolrCloseable {
+     log.debug(""Loading collection config from: [{}]"", path);
+
+     try {
+-      if (zkClient.exists(path, true) == false) {
+-        log.warn(""No collection found at path {}."", path);
+-        throw new KeeperException.NoNodeException(""No collection found at path: "" + path);
+-      }
+       byte[] data = zkClient.getData(path, null, null, true);
+       if (data == null) {
+         log.warn(""No config data found at path {}."", path);","Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(""No collection found at path: "" + path);` Just a thought, I'm not even sure it's worth it.",Why did you remove this check?
+1405,"@@ -17,7 +17,7 @@ class Project < ActiveRecord::Base
+   validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: { case_sensitive: false }
+   validates :description, length: 0..800, allow_nil: true # , if: proc { |p| p.validate_url_name_and_desc == 'true' }
+   validates_each :url, :download_url, allow_blank: true do |record, field, value|
+-    record.errors.add(field, I18n.t(:not_a_valid_url)) unless value.valid_http_url?
++    record.errors.add(field, I18n.t(:not_a_valid_url)) unless value.blank? || value.valid_http_url?
+   end
+   before_validation :clean_strings_and_urls
+   after_save :update_organzation_project_count","I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not.",Layout/EmptyLineAfterGuardClau
+1406,"@@ -212,8 +212,7 @@ module Bolt
+
+         return unless !stdout.empty? && stdout.to_i < 3
+
+-        msg = ""Detected PowerShell 2 on controller. PowerShell 2 is deprecated and ""\
+-              ""support will be removed in Bolt 3.0.""
++        msg = ""Detected PowerShell 2 on controller. PowerShell 2 is unsupported.""
+         Bolt::Logger.deprecation_warning(""PowerShell 2 controller"", msg)
+       end
+     end","Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from ""removing support"".",We're not using `Bolt::Logger.
+1407,"@@ -44,7 +44,12 @@ module Bolt
+
+       # Returns options this transport supports
+       def self.options
+-        raise NotImplementedError, ""self.options() must be implemented by the transport class""
++        raise NotImplementedError,
++              ""self.options() or self.filter_options(unfiltered) must be implemented by the transport class""
++      end
++
++      def self.filter_options(unfiltered)
++        unfiltered.select { |k| options.include?(k) }
+       end
+
+       def self.validate(_options)",This is kind of confusing with the other `filter_options`.,Style/RedundantSelf: Redundant
+1408,"@@ -160,7 +160,12 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
+ 		return fs.opsByFav[fav]
+ 	}()
+ 	if ops != nil {
+-		return ops.deleteFromFavorites(ctx, fs.favs)
++		err := ops.deleteFromFavorites(ctx, fs.favs)
++		if _, ok := err.(OpsCantHandleFavorite); !ok {
++			return err
++		}
++		// If the ops couldn't handle the delete, fall through to
++		// going directly via Favorites.
+ 	}
+
+ 	if isLoggedIn {",Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server.,"If we're going to handle the delete in favorites, why not do it in the ops package instead?"
+1409,"@@ -457,7 +457,7 @@ void CmpSeabaseDDL::dropSeabaseSchema(StmtDDLDropSchema * dropSchemaNode)
+
+    bool isVolatile = (memcmp(schName.data(),""VOLATILE_SCHEMA"",strlen(""VOLATILE_SCHEMA"")) == 0);
+    int32_t length = 0;
+-   int32_t rowCount = 0;
++   Int64 rowCount = 0;
+    bool someObjectsCouldNotBeDropped = false;
+    char errorObjs[1010];
+    Queue * objectsQueue = NULL;","It doesn't look like this particular ""rowCount"" variable is used anywhere. I suppose we could delete it. The code change is harmless though.","Not that it matters much, but `someObjectsCouldNotBeDropped` and `someObjectsCouldNotBeDrop"
+1410,"@@ -380,6 +380,10 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+
+ 	status, _ := s.serveHTTP(w, r)
+
++	if status == 204 {
++		w.WriteHeader(http.StatusNoContent)
++	}
++
+ 	// Fallback error response in case error handling wasn't chained in
+ 	if status >= 400 {
+ 		DefaultErrorFunc(w, r, status)","Hmm, probably we should instead write whatever `status` is returned instead of coding a special case.",I don't understand why this is needed. Why not set the status code?
+1411,"@@ -128,6 +128,10 @@ func parsedRuleToProtoRule(in *ParsedRule) *proto.Rule {
+ 		}
+ 	}
+
++	if in.HTTPMatch != nil {
++		out.HttpMatch = &proto.HTTPMatch{Methods: in.HTTPMatch.Methods}
++	}
++
+ 	// Fill in the ICMP fields.  We can't follow the pattern and make a
+ 	// convertICMP() function because we can't name the return type of the
+ 	// function (it's private to the protobuf package).","Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?",Would it be better to make this an `if` instead of an `if`?
+1412,"@@ -11,6 +11,7 @@ class User < ActiveRecord::Base
+
+   has_many :approvals
+   has_many :observations
++  has_many :observers, through: :observers, source: :user
+   has_many :comments
+
+   # we do not use rolify gem (e.g.) but declare relationship like any other.",why this recursive relationship definition?,why move this? we don't have any relationship on a `user`
+1413,"@@ -40,7 +40,8 @@ type Procedure struct {
+ 	// HandlerSpec specifiying which handler and rpc type.
+ 	HandlerSpec HandlerSpec
+
+-	// Encoding of the handler, for introspection.
++	// Encoding of the handler, optional, used for introspection, and used for
++	// routing if present.
+ 	Encoding Encoding
+
+ 	// Signature of the handler, for introspection. This should be a snippet of","More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change).","Nit: ""optional, used for introspection"" -> ""optional, use"
+1414,"@@ -66,6 +66,10 @@
+ //   are included because they call NewRangeReader.)
+ // - NewWriter, from creation until the call to Close.
+ //
++// It also collects the following metrics:
++// - gocloud.dev/blob/bytes_read: the total number of bytes read, by provider.
++// - gocloud.dev/blob/bytes_written: the total number of bytes written, by provider.
++//
+ // To enable trace collection in your application, see ""Configure Exporter"" at
+ // https://opencensus.io/quickstart/go/tracing.
+ // To enable metric collection in your application, see ""Exporting stats"" at","Not part of this PR, but should the section above say what the name of the metric is for each method?",Why not also add these to the other metrics for bytes_rea
+1415,"@@ -75,13 +75,13 @@ namespace OpenTelemetry.Exporter
+
+                         case MetricType.LongGauge:
+                             {
+-                                // TODOs
++                                valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
+                                 break;
+                             }
+
+                         case MetricType.DoubleGauge:
+                             {
+-                                // TODOs
++                                valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
+                                 break;
+                             }
+ ","there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs.",Is it possible to use the `nameof` pattern here?
+1416,"@@ -95,7 +95,7 @@ func (t *Terminal) run(ctx context.Context) {
+ 	for {
+ 		select {
+ 		case <-ctx.Done():
+-			if IsProcessBackground() {
++			if IsProcessBackground(t.fd) {
+ 				// ignore all messages, do nothing, we are in the background process group
+ 				continue
+ 			}",This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?,why did you swap these?
+1417,"@@ -61,7 +61,10 @@ void DataMan::add_stream(json p_jmsg)
+         man->init(p_jmsg);
+         this->add_next(method, man);
+     }
+-    add_man_to_path(""zfp"", method);
++    if (p_jmsg[""compress_method""] != nullptr)
++    {
++        add_man_to_path(p_jmsg[""compress_method""], method);
++    }
+ }
+
+ void DataMan::flush() { flush_next(); }","Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[""compress_method""])`",I'm surprised you don't
+1418,"@@ -146,6 +146,17 @@ public class LibraryFeaturePanel extends FeaturePanel<LibraryFeaturePanel, Libra
+         // get container
+         // TODO: smarter way using container manager
+         final String executablePath = shortcutCreationDTO.getExecutable().getAbsolutePath();
++        if (!executablePath.startsWith(getContainersPath())) {
++            Platform.runLater(() -> {
++                final ErrorDialog errorDialog = ErrorDialog.builder()
++                        .withMessage(tr(""Creating shortcut to executable outside of a container is not supported""))
++                        .withOwner(getScene().getWindow())
++                        .build();
++
++                errorDialog.showAndWait();
++            });
++            return;
++        }
+         final String pathInContainers = executablePath.replace(getContainersPath(), """");
+         final String[] split = pathInContainers.split(""/"");
+         final String engineContainer = split[0];","Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?",I don't think you need
+1419,"@@ -0,0 +1,14 @@
++from kinto.core.events import ResourceChanged
++
++from .listener import on_resource_changed
++
++
++def includeme(config):
++    config.add_api_capability('quotas',
++                              description='Quotas Management on Buckets.',
++                              url='https://kinto.readthedocs.io')
++
++    # Listen to every resources (except history)
++    config.add_subscriber(on_resource_changed, ResourceChanged,
++                          for_resources=('bucket', 'group',
++                                         'collection', 'record'))",nitpick: _and collections_,You don't need to speci
+1420,"@@ -42,6 +42,8 @@ struct rp_generator_t {
+     int is_websocket_handshake;
+     int had_body_error; /* set if an error happened while fetching the body so that we can propagate the error */
+     h2o_timer_t send_headers_timeout;
++    unsigned req_done : 1;
++    unsigned res_done : 1;
+ };
+
+ struct rp_ws_upgrade_info_t {",I believe these need to be explicitly initialized in `proxy_send_prepare`,"Same here, I think a single bool is more appropriate for this."
+1421,"@@ -160,6 +160,7 @@ class TaskProcess(multiprocessing.Process):
+             # Need to have different random seeds if running in separate processes
+             random.seed((os.getpid(), time.time()))
+
++        t0 = time.time() # Failed task start time
+         status = FAILED
+         expl = ''
+         missing = []",This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block.,This variable seems unrelated to the rest of the PR.
+1422,"@@ -1,6 +1,15 @@
+ */
+
+
++/**
++ * The border color when the client is marked.
++ * It has priority over the rest of beautiful border color properties.
++ * Note that only solid colors are supported.
++ * @beautiful beautiful.border_color_marked
++ * @param color
++ * @see request::border
++ */
++
+ /**
+  * The fallback border color when the client is floating.
+  *","The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?",Shouldn't this be called `_marked`?
+1423,"@@ -0,0 +1,19 @@
++module.exports = {
++  roots: [
++    ""<rootDir>/javascript/grid-ui/src""
++  ],
++  testMatch: [
++    ""<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx""
++  ],
++  transform: {
++    ""^.+\\.(ts|tsx)$"": ""ts-jest""
++  },
++  moduleFileExtensions: [""ts"", ""tsx"", ""js"", ""jsx"", ""json"", ""node""],
++  snapshotSerializers: [""enzyme-to-json/serializer""],
++  setupFilesAfterEnv: [""<rootDir>/setupTests.ts""],
++  testEnvironment: ""jsdom"",
++  moduleNameMapper: {
++    "".+\\.(svg|png|jpg|css)$"": ""identity-obj-proxy"",
++    ""selenium/javascript/grid-ui/(.*)"": ""<rootDir>/$1""
++  }
++}","We don't need this file, we can use the one that is in the grid-ui directory",can we do the same for angular as well
+1424,"@@ -48,6 +48,10 @@ public class BazelIgnoreParser {
+
+     try {
+       for (String path : FileOperationProvider.getInstance().readAllLines(bazelIgnoreFile)) {
++        if (!isEmptyLine(path)) {
++          continue;
++        }
++
+         if (path.endsWith(""/"")) {
+           // .bazelignore allows the ""/"" path suffix, but WorkspacePath doesn't.
+           path = path.substring(0, path.length() - 1);",FYI: inlined this method in the internal review.,Why did you choose to skip empty lines here?
+1425,"@@ -17,10 +17,8 @@ import org.junit.Test;
+ import org.junit.runner.RunWith;
+
+ import java.util.ArrayList;
+-import java.util.Arrays;
+ import java.util.Date;
+ import java.util.List;
+-import java.util.concurrent.CountDownLatch;
+ import java.util.concurrent.TimeUnit;
+
+ import de.danoeh.antennapod.core.feed.Feed;","Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff",please re-add this line
+1426,"@@ -47,7 +47,7 @@ namespace OpenTelemetry.Exporter
+             foreach (var metric in exporter.Metrics)
+             {
+                 var builder = new PrometheusMetricBuilder()
+-                    .WithName(metric.Name)
++                    .WithName(metric.Meter.Name + metric.Name)
+                     .WithDescription(metric.Description);
+
+                 switch (metric.MetricType)","Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter.",The `metric.Name` is already being prefixed
+1427,"@@ -78,10 +78,17 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+
++        $config = $this->getConfig();
++        $allowConnectingCards = !empty(
++            $config->Catalog
++                ->auth_based_library_cards
++        ) &&
++            ($this->getAuthManager()->getAuthMethod() == 'Shibboleth');
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'allowConnectingCards' => $allowConnectingCards,
+             ]
+         );
+     }","The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction.",`$config->Catalog->auth_based_library_cards`
+1428,"@@ -1791,7 +1791,7 @@ create_and_initialize_module_data(app_pc start, app_pc end, app_pc entry_point,
+             copy->segments[i].end = os_segments[i].end;
+             copy->segments[i].prot = os_segments[i].prot;
+         }
+-    } else
++    } else if (segments != NULL)
+         memcpy(copy->segments, segments, num_segments*sizeof(module_segment_data_t));
+     copy->timestamp = timestamp;
+ # ifdef MACOS","One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too.","this change is unrelated to the rest of the patch, but the `else if (segments != NULL)` should be removed."
+1429,"@@ -106,7 +106,11 @@ class User < ActiveRecord::Base
+
+   def self.from_oauth_hash(auth_hash)
+     user_data = auth_hash.extra.raw_info.to_hash
+-    self.find_or_create_by(email_address: user_data['email'])
++    user = self.for_email(user_data['email'])
++    if user_data['first_name'].present? && user_data['last_name'].present?
++      user.update_attributes(first_name: user_data['first_name'], last_name: user_data['last_name'])
++    end
++    user
+   end
+
+   def role_on(proposal)",I'm surprised rubocop isn't picking up singe quotes?,Didn't you want to use `update!` here? Or am I missing something?
+1430,"@@ -251,14 +251,7 @@ import (
+ var _ time.Duration
+ var _ strings.Reader
+ var _ aws.Config
+-
+-func parseTime(layout, value string) *time.Time {
+-	t, err := time.Parse(layout, value)
+-	if err != nil {
+-		panic(err)
+-	}
+-	return &t
+-}
++var _, _ = protocol.ParseTime(""unixTimestamp"", ""2016-09-27T15:50Z"")
+
+ `))
+ ",Is this line still needed?,You may want to return an error here if the value doesn't match the format.
+1431,"@@ -153,10 +153,8 @@ bool EDPSimple::createSEDPEndpoints()
+         watt.endpoint.multicastLocatorList = this->mp_PDP->getLocalParticipantProxyData()->m_metatrafficMulticastLocatorList;
+         //watt.endpoint.remoteLocatorList = m_discovery.initialPeersList;
+         watt.endpoint.durabilityKind = TRANSIENT_LOCAL;
+-        watt.times.nackResponseDelay.seconds = 0;
+-        watt.times.nackResponseDelay.fraction = 0;
+-        watt.times.initialHeartbeatDelay.seconds = 0;
+-        watt.times.initialHeartbeatDelay.fraction = 0;
++        watt.times.heartbeatPeriod.seconds = 1;
++        watt.times.heartbeatPeriod.fraction = 0;
+         if(mp_RTPSParticipant->getRTPSParticipantAttributes().throughputController.bytesPerPeriod != UINT32_MAX &&
+                 mp_RTPSParticipant->getRTPSParticipantAttributes().throughputController.periodMillisecs != 0)
+             watt.mode = ASYNCHRONOUS_WRITER;","Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?",Does this mean that every time we get a new heartbeat period we set the `watt.times.heartbeatPeriod.second
+1432,"@@ -21,9 +21,10 @@ import inputCore
+
+ #: The directory in which liblouis braille tables are located.
+ TABLES_DIR = r""louis\tables""
++PATTERNS_TABLE = os.path.join(TABLES_DIR, ""braille-patterns.cti"")
+
+-#: The table file names and information.
+-TABLES = (
++#: The braille table file names and information.
++tables = [
+ 	# (fileName, displayName, supportsInput),
+ 	# Translators: The name of a braille table displayed in the
+ 	# braille settings dialog.","nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots.","I don't think we should change the default to `braille-patterns.cti`, since that's what the default that is used for every language."
+1433,"@@ -104,9 +104,6 @@ type Builder struct {
+
+ 	// MachineNetwork is the subnet to use for the cluster's machine network.
+ 	MachineNetwork string
+-
+-	// SkipMachinePoolGeneration is set to skip generating MachinePool objects
+-	SkipMachinePoolGeneration bool
+ }
+
+ // Validate ensures that the builder's fields are logically configured and usable to generate the cluster resources.",Why are we removing the option to skip machine pool generation?,You could just remove the field entirely if it's not used anywhere.
+1434,"@@ -0,0 +1,9 @@
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpStartLineHandler
++    {
++        void OnStartLine(HttpMethod method, HttpVersion version, Span<byte> target, Span<byte> path, Span<byte> query, Span<byte> customMethod);
++    }
++}","""Request line"" here too.",I wonder if it wouldn't be better to make this take `HttpMethod` rather than `Span<byte>` rather than `Span<byte>`
+1435,"@@ -1292,6 +1292,19 @@ void Corpse::LootItem(Client *client, const EQApplicationPacket *app)
+ 		std::vector<EQ::Any> args;
+ 		args.push_back(inst);
+ 		args.push_back(this);
++		if (RuleB(Zone, UseZoneController)) {
++			if (entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)){
++				if (parse->EventNPC(EVENT_LOOT_ZONE, entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)->CastToNPC(), client, buf, 0, &args) != 0) {
++					lootitem->auto_loot = -1;
++					client->MessageString(Chat::Red, LOOT_NOT_ALLOWED, inst->GetItem()->Name);
++					client->QueuePacket(app);
++					delete inst;
++					return;
++				}
++			}
++		}
++
++
+ 		if (parse->EventPlayer(EVENT_LOOT, client, buf, 0, &args) != 0) {
+ 			lootitem->auto_loot = -1;
+ 			client->MessageString(Chat::Red, LOOT_NOT_ALLOWED, inst->GetItem()->Name);",Please remove this.,brace on wrong line
+1436,"@@ -15,6 +15,7 @@ class Organization::Affiliated < Organization::AccountFacts
+     accounts = @organization.accounts.joins([:person, :positions])
+     accounts = accounts.group('accounts.id, people.kudo_position').order('kudo_position nulls last')
+     accounts.paginate(per_page: limit, page: page)
++    Account.paginate_by_sql(accounts.to_sql, per_page: limit, page: page)
+   end
+
+   def projects(page = 1, limit = 10)","Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated.",Line is too long. [92/80]
+1437,"@@ -75,6 +75,12 @@ class Analysis < ActiveRecord::Base
+     end.compact.join(' AND ')
+   end
+
++  def allowed_tuples
++    [].tap do |tuples|
++      analysis_sloc_sets.each { |analysis_sloc_set| tuples << analysis_sloc_set.allowed_tuples }
++    end.compact.join(' AND ')
++  end
++
+   def angle
+     (Math.atan(hotness_score) * 180 / Math::PI).round(3)
+   end",This can be simplified as discussed before.,Prefer double-quoted stri
+1438,"@@ -1,7 +1,14 @@
+ package execute
+
+-import ""github.com/influxdata/flux""
++import (
++	""github.com/influxdata/flux""
++	""github.com/influxdata/flux/execute/table""
++)
+
+ func NewProcessMsg(tbl flux.Table) ProcessMsg {
+ 	return &processMsg{table: tbl}
+ }
++
++func NewProcessChunkMsg(chunk table.Chunk) ProcessChunkMsg {
++	return &processChunkMsg{chunk: chunk}
++}",Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?,nit: Can we call this `Ne
+1439,"@@ -12,7 +12,7 @@ describe('Transaction deserialization', function() {
+     vectors_valid.forEach(function(vector) {
+       if (vector.length > 1) {
+         var hexa = vector[1];
+-        Transaction(hexa).serialize().should.equal(hexa);
++        Transaction(hexa).serialize(true).should.equal(hexa);
+         index++;
+       }
+     });",does this boolean indicate unsafe serialization?,Was this change necessary
+1440,"@@ -332,6 +332,13 @@ class Realm {
+      */
+     static deleteFile(config) {}
+
++    /**
++     * Copy bundled Realm files to app's default file folder.
++     * This is not implemented for node.js.
++     * @throws {Error} If an I/O error occured or method is not implemented.
++     */
++    static copyBundledRealmFiles() {}
++
+     /**
+      * Get a list of subscriptions. THIS METHOD IS IN BETA AND MAY CHANGE IN FUTURE VERSIONS.
+      * @param {string} name - Optional parameter to query for either a specific name or pattern (using",Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case).,"""If an I/O error occured"" -> ""If an I/O error occured"""
+1441,"@@ -246,8 +246,15 @@ public abstract class PageStreamingConfig {
+     if (pageSizeField == null) {
+       // TODO: Conform to design doc spec, once approved, for using non-standard paging fields
+       //       (such as max_results for page_size)
+-      if (language == TargetLanguage.JAVA && transportProtocol == TransportProtocol.HTTP) {
+-        pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++      if (transportProtocol == TransportProtocol.HTTP) {
++        if (language == TargetLanguage.JAVA) {
++          pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++        } else if (language == TargetLanguage.PHP) {
++          FieldModel resourcesField = ProtoPageStreamingTransformer.getResourcesField(methodModel);
++          if (resourcesField != null && !resourcesField.isMap()) {
++            pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++          }
++        }
+       }
+     }
+     ProtoField responseTokenField =",Do we not need this in Java because Java *is* handling map responses?,Do you think we can add a builder pattern to avoid the
+1442,"@@ -279,6 +279,14 @@ class Task(object):
+                 except BaseException:
+                     logger.exception(""Error in event callback for %r"", event)
+
++    @property
++    def accepted_messages(self):
++        """"""
++        Configures which scheduler messages can be received and returns them. When falsy, this tasks
++        does not accept any message. When True, all messages are accepted.
++        """"""
++        return False
++
+     @property
+     def task_module(self):
+         ''' Returns what Python module to import to get access to this class. '''","Maybe ""For configuring which scheduler messages can be received.""?","`def accepted_messages()` might be a better name, give"
+1443,"@@ -141,7 +141,7 @@ class SyncThumbsCommand extends BaseCommand
+             }
+
+             //clear entity manager for saving memory
+-            $this->getMediaManager()->getEntityManager()->clear();
++            $this->getMediaManager()->getObjectManager()->clear();
+
+             if ($batchesLimit > 0 && $batchCounter == $batchesLimit) {
+                 break;","It will stop working with orm, so this is not a good fix, Try using some method in a common interface",Why do you use an ObjectManager here? Shouldn't it be
+1444,"@@ -40,7 +40,11 @@ namespace OpenTelemetry.Collector.Dependencies
+         {
+             this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(
+                 new Dictionary<string, Func<ITracer, Func<HttpRequestMessage, ISampler>, ListenerHandler>>()
+-                { { ""HttpHandlerDiagnosticListener"", (t, s) => new HttpHandlerDiagnosticListener(t, s) } },
++                {
++                    { ""HttpHandlerDiagnosticListener"", (t, s) => new HttpHandlerDiagnosticListener(t, s) },
++                    { ""Azure.Clients"", (t, s) => new AzureSdkDiagnosticListener(""Azure.Clients"", t, sampler) },
++                    { ""Azure.Pipeline"", (t, s) => new AzureSdkDiagnosticListener(""Azure.Pipeline"", t, sampler) },
++                },
+                 tracer,
+                 x =>
+                 {",`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`,Do we have a test for this somewhere?
+1445,"@@ -83,9 +83,14 @@ public class PojoOperationGenerator extends AbstractOperationGenerator {
+     bodyModel = new ModelImpl();
+     bodyModel.setType(ModelImpl.OBJECT);
+     for (ParameterGenerator parameterGenerator : bodyFields) {
+-      SwaggerUtils.addDefinitions(swagger, parameterGenerator.getGenericType());
++      parameterGenerator.setHttpParameterType(HttpParameterType.BODY);
++      scanMethodParameter(parameterGenerator);
++
+       Property property = ModelConverters.getInstance().readAsProperty(parameterGenerator.getGenericType());
++      property.setDescription(parameterGenerator.getGeneratedParameter().getDescription());
+       bodyModel.addProperty(parameterGenerator.getParameterName(), property);
++
++      parameterGenerator.setHttpParameterType(null);
+     }
+     swagger.addDefinition(simpleRef, bodyModel);
+ ",This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?,Why is this needed?
+1446,"@@ -741,7 +741,7 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
+ 			return nil, nil, err
+ 		}
+ 		log.Debug(""Completed remote build action for %s"", target)
+-		if err := c.verifyActionResult(target, command, digest, response.Result, false, isTest); err != nil {
++		if err := c.verifyActionResult(target, command, digest, response.Result, c.state.Config.Remote.VerifyOutputs && !isTest, isTest); err != nil {
+ 			return metadata, response.Result, err
+ 		}
+ 		c.locallyCacheResults(target, digest, metadata, response.Result)",Why did this change?,Is this change related to the rest of
+1447,"@@ -55,11 +55,14 @@ func (c *client) DescribeTable(ctx context.Context, region string, tableName str
+
+ 	globalSecondaryIndexes := getGlobalSecondaryIndexes(result.Table.GlobalSecondaryIndexes)
+
++	status := newProtoForTableStatus(result.Table.TableStatus)
++
+ 	ret := &dynamodbv1.Table{
+ 		Name:                   aws.ToString(result.Table.TableName),
+ 		Region:                 region,
+ 		GlobalSecondaryIndexes: globalSecondaryIndexes,
+ 		ProvisionedThroughput:  currentCapacity,
++		Status:                 status,
+ 	}
+ 	return ret, nil
+ }",nit: `status` collides with imported package named `status`,Can we also change `ProvisionedThroug
+1448,"@@ -584,6 +584,14 @@ func (l *Ledger) trackerEvalVerified(blk bookkeeping.Block, accUpdatesLedger led
+ 	return eval(context.Background(), accUpdatesLedger, blk, false, nil, nil)
+ }
+
++// IsWritingCatchpointFile returns true when a catchpoint file is being generated. The function is used by the catchup service so
++// that the memory pressure could be decreased until the catchpoint file writing is complete.
++func (l *Ledger) IsWritingCatchpointFile() bool {
++	l.trackerMu.RLock()
++	defer l.trackerMu.RUnlock()
++	return l.accts.IsWritingCatchpointFile()
++}
++
+ // A txlease is a transaction (sender, lease) pair which uniquely specifies a
+ // transaction lease.
+ type txlease struct {","""memory pressure could be decreased"" --> ""to avoid memory pressure""",why this lock is needed?
+1449,"@@ -426,8 +426,11 @@ class TestTimescaleListenStore(DatabaseTestCase):
+         self.assertEqual(count + 1, int(cache.get(user_key, decode=False) or 0))
+
+     def test_delete_listens(self):
+-        self._create_test_data(self.testuser_name)
+-        listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=self.testuser_name, to_ts=1400000300)
++        uid = random.randint(2000, 1 << 31)
++        testuser = db_user.get_or_create(uid, ""user_%d"" % uid)
++        testuser_name = testuser['musicbrainz_id']
++        self._create_test_data(testuser_name)
++        listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=testuser_name, to_ts=1400000300)
+         self.assertEqual(len(listens), 5)
+         self.assertEqual(listens[0].ts_since_epoch, 1400000200)
+         self.assertEqual(listens[1].ts_since_epoch, 1400000150)",I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect.,You can just use `self.t
+1450,"@@ -169,6 +169,11 @@ export class CollapsibleColumns extends BasePlugin {
+         });
+
+       } else if (Array.isArray(collapsibleColumns)) {
++
++        this.headerStateManager.mapState(() => {
++          return { collapsible: false };
++        });
++
+         this.headerStateManager.mergeStateWith(collapsibleColumns);
+       }
+     }",I'm thinking about covering this change with the test. Can you do that?,Does this mean that `col
+1451,"@@ -41,7 +41,7 @@ var (
+
+ // NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
+ type NATProviderPinger interface {
+-	PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
++	PingProvider(ip string, cPorts, pPorts []int, proxyPort int) (*net.UDPConn, error)
+ }
+
+ // NATPinger is responsible for pinging nat holes",Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?,I was wondering if the `
+1452,"@@ -373,7 +373,13 @@ func (dg *dockerGoClient) pullImage(image string, authData *apicontainer.Registr
+ 		return CannotGetDockerClientError{version: dg.version, err: err}
+ 	}
+
+-	authConfig, err := dg.getAuthdata(image, authData)
++	sdkAuthConfig, err := dg.getAuthdata(image, authData)
++	authConfig := docker.AuthConfiguration{
++		Username:      sdkAuthConfig.Username,
++		Password:      sdkAuthConfig.Password,
++		Email:         sdkAuthConfig.Email,
++		ServerAddress: sdkAuthConfig.ServerAddress,
++	}
+ 	if err != nil {
+ 		return wrapPullErrorAsNamedError(err)
+ 	}",Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?,"This is the same as `getAuthdata(image, authData)`. Can't we just pass in the `docker.AuthConfiguration` directly?"
+1453,"@@ -31,6 +31,8 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
+
+         public string BlobNamePrefix { get; set; }
+
++        public ITaskItem[] BlobNames { get; set; }
++
+         public override bool Execute()
+         {
+             return ExecuteAsync().GetAwaiter().GetResult();",Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?,Does this need to be public?
+1454,"@@ -22,5 +22,7 @@ describe('Client Side Encryption', function() {
+     return testContext.setup(this.configuration);
+   });
+
+-  generateTopologyTests(testSuites, testContext);
++  generateTopologyTests(testSuites, testContext, spec => {
++    return !spec.description.match(/type=regex/);
++  });
+ });",Can you leave a note about why we are skipping regex tests?,Can we have this as a separate method so that we only call it once?
+1455,"@@ -55,10 +55,15 @@ var initCmd = &cmds.Command{
+ 		if err != nil {
+ 			return err
+ 		}
+-		rep, err := repo.CreateRepo(repoDir, newConfig)
++
++		if err := repo.InitFSRepo(repoDir, newConfig); err != nil {
++			return err
++		}
++		rep, err := repo.OpenFSRepo(repoDir)
+ 		if err != nil {
+ 			return err
+ 		}
++
+ 		// The only error Close can return is that the repo has already been closed
+ 		defer rep.Close() // nolint: errcheck
+ ","This was the only caller of CreateRepo, so I inlined it.",Why we need this change?
+1456,"@@ -109,6 +109,8 @@ type VaultAuth struct {
+ 	TokenSecretRef SecretKeySelector `json:""tokenSecretRef,omitempty""`
+ 	// This Secret contains a AppRole and Secret
+ 	AppRole VaultAppRole `json:""appRole,omitempty""`
++	// Where the authentication path is mounted in Vault.
++	AuthPath string `json:""authPath,omitempty""`
+ }
+
+ type VaultAppRole struct {","As this is already a child of `auth`, I think we can shorten this to `path`",Should this have a `omitempty` so we don't make it optional?
+1457,"@@ -297,6 +297,14 @@ class UIATextInfo(textInfos.TextInfo):
+ 		elif position==textInfos.POSITION_LAST:
+ 			self._rangeObj=self.obj.UIATextPattern.documentRange
+ 			self.collapse(True)
++		elif position in (textInfos.POSITION_FIRSTVISIBLE, textInfos.POSITION_LASTVISIBLE):
++			try:
++				visiRanges = self.obj.UIATextPattern.GetVisibleRanges()
++				element = 0 if position == textInfos.POSITION_FIRSTVISIBLE else visiRanges.length - 1
++				self._rangeObj = visiRanges.GetElement(0)
++			except COMError:
++				# Error: FIRST_VISIBLE position not supported by the UIA text pattern.
++				raise NotImplementedError
+ 		elif position==textInfos.POSITION_ALL or position==self.obj:
+ 			self._rangeObj=self.obj.UIATextPattern.documentRange
+ 		elif isinstance(position,UIA) or isinstance(position,UIAHandler.IUIAutomationElement):","This call should use element, not 0 I think.",Is there a better way to get the element from `visiRanges`?
+1458,"@@ -223,6 +223,8 @@ type Options struct {
+ 	ChunkSize                   fs.SizeSuffix        `config:""chunk_size""`
+ 	NoChunk                     bool                 `config:""no_chunk""`
+ 	Enc                         encoder.MultiEncoder `config:""encoding""`
++	FetchUntilEmptyPage         bool                 `config:""fetch_until_empty_page""`
++	PartialPageFetchThreshold   int                  `config:""partial_page_fetch_threshold""`
+ }
+
+ // Fs represents a remote swift server",This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above.,Do we really need a new config for this? Can't we just reuse
+1459,"@@ -170,8 +170,8 @@ module Selenium
+
+           def macosx_path
+             path = ""/Applications/Firefox.app/Contents/MacOS/firefox-bin""
+-            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(path)
+-            path = Platform.find_binary(""firefox-bin"") unless File.exist?(path)
++            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(File.expand_path(path))
++            path = Platform.find_binary(""firefox-bin"") unless File.exist?(File.expand_path?(path))
+
+             path
+           end",I don't think this one needs to be changed since the only previous path is already an absolute one.,"@jjaffeux, @jjaffeux, @zachmargolis, can you explain why thi"
+1460,"@@ -200,7 +200,7 @@ public class BaseExpireSnapshotsSparkAction
+   }
+
+   private Dataset<Row> buildValidFileDF(TableMetadata metadata) {
+-    Table staticTable = newStaticTable(metadata, this.table.io());
++    Table staticTable = newStaticTable(metadata, this.table.io(), table.locationProvider());
+     return appendTypeString(buildValidDataFileDF(staticTable), DATA_FILE)
+         .union(appendTypeString(buildManifestFileDF(staticTable), MANIFEST))
+         .union(appendTypeString(buildManifestListDF(staticTable), MANIFEST_LIST));",Since we kept the original constructor we might not need this change now.,I think we can remove this
+1461,"@@ -130,6 +130,7 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+     }
+
+     refreshFromMetadataLocation(metadataLocation);
++    LOG.debug(""Refreshed [{}]"", fullName);
+   }
+
+   @Override","There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one.",Why is this at debug level
+1462,"@@ -21,6 +21,8 @@ import (
+ 	""net/http""
+ 	""time""
+
++	""github.com/pipe-cd/pipe/pkg/filestore/minio""
++
+ 	jwtgo ""github.com/dgrijalva/jwt-go""
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""",This should be in the last group.,nit: newline should be dro
+1463,"@@ -106,6 +106,7 @@ namespace Datadog.Trace.Agent
+                     {
+                         // stop retrying
+                         Log.Error(exception, ""An error occurred while sending traces to the agent at {0}"", _tracesEndpoint);
++                        _statsd?.Send();
+                         return false;
+                     }
+ ","I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named ""unit test improvements""",Is it intentional that we
+1464,"@@ -0,0 +1,8 @@
++// +k8s:deepcopy-gen=package,register
++// +k8s:conversion-gen=github.com/munnerz/cert-manager/pkg/apis/certmanager
++// +k8s:openapi-gen=true
++// +k8s:defaulter-gen=TypeMeta
++
++// Package v1alpha1 is the v1alpha1 version of the API.
++// +groupName=certmanager.k8s.io
++package v1alpha1","I've gone with this group name, however I'm open to suggestions on alternatives!",You don't need to specify `+k8s:defaulter-gen=true` here.
+1465,"@@ -32,6 +32,7 @@ public class RpcApis {
+   public static final RpcApi TX_POOL = new RpcApi(""TXPOOL"");
+   public static final RpcApi TRACE = new RpcApi(""TRACE"");
+   public static final RpcApi PLUGINS = new RpcApi(""PLUGINS"");
++  public static final RpcApi QUORUM = new RpcApi(""QUORUM"");
+
+   public static final List<RpcApi> DEFAULT_JSON_RPC_APIS = Arrays.asList(ETH, NET, WEB3);
+ ",should this be GOQUORUM,how about `QUORUM_VALUE`?
+1466,"@@ -49,7 +49,7 @@ type (
+ var cpuprofile = flag.String(""cpuprofile"", """", ""write cpu profile to file"")
+
+ // Validate for the byzantine node uses the actual block validator and returns the opposite
+-func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B) error {
++func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B, checkCoinbase bool) error {
+ 	//err := v.val.Validate(blk, tipHeight, tipHash)
+ 	//if err != nil {
+ 	//	return nil","I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0.",why a bool and not a pointer?
+1467,"@@ -24,14 +24,13 @@ import (
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/db""
+ 	""github.com/iotexproject/iotex-core/state""
+-	""github.com/iotexproject/iotex-core/state/factory""
+ 	""github.com/iotexproject/iotex-core/test/identityset""
+ 	""github.com/iotexproject/iotex-core/test/mock/mock_chainmanager""
+ 	""github.com/iotexproject/iotex-election/test/mock/mock_committee""
+ 	""github.com/iotexproject/iotex-election/types""
+ )
+
+-func initConstruct(t *testing.T) (Protocol, context.Context, factory.WorkingSet, *types.ElectionResult) {
++func initConstruct(t *testing.T) (Protocol, context.Context, protocol.StateManager, *types.ElectionResult) {
+ 	require := require.New(t)
+ 	ctrl := gomock.NewController(t)
+ 	defer ctrl.Finish()","same here, move it out",[nit] Can we call this `manager` instead of `protocol`? T
+1468,"@@ -42,11 +42,17 @@
+ //@HEADER
+ */
+
++#ifndef KOKKOS_TOOLS_INDEPENDENT_BUILD
+ #include <Kokkos_Macros.hpp>
+ #include <Kokkos_Tuners.hpp>
++#endif
++
+ #include <impl/Kokkos_Profiling.hpp>
+-#if defined(KOKKOS_ENABLE_LIBDL)
++#include <impl/Kokkos_Profiling_Interface.hpp>
++
++#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)
+ #include <dlfcn.h>
++#define KOKKOS_TOOLS_ENABLE_LIBDL
+ #endif
+
+ #include <algorithm>",Can you elaborate on why you need different behavior depending on Tools being built independently or not?,Is this define still needed?
+1469,"@@ -18,7 +18,8 @@ class AnnotationsController < ApplicationController
+     guid_save = guidance.present? ? guidance.save : true
+
+     if ex_save && guid_save
+-      redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: _('Information was successfully created.')
++      typ = (!ex_save && !guid_save ? 'example answer and guidance' : (!guid_save ? 'guidance' : 'example answer'))
++      redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: success_message(typ, _('created'))
+     else
+       @section = @question.section
+       @phase = @section.phase","because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`",Avoid multi-line ternary ope
+1470,"@@ -5,6 +5,7 @@ import (
+ 	""testing""
+
+ 	""github.com/stretchr/testify/assert""
++	""golang.org/x/net/context""
+
+ 	""github.com/sonm-io/core/insonmnia/structs""
+ 	pb ""github.com/sonm-io/core/proto""",why not context from stdlib?,what's the reason for this c
+1471,"@@ -48,7 +48,7 @@ func GenerateCRC32(
+ 	return Checksum{
+ 		Value:   checksum,
+ 		Version: payloadVersion,
+-		Flavor:  FlavorIEEECRC32OverThriftBinary,
++		Flavor:  FlavorIEEECRC32OverProto3Binary,
+ 	}, nil
+ }
+ ",Just saw this and wasn't able to hold myself from renaming :-).,Was this a bug?
+1472,"@@ -278,9 +278,7 @@ describe('src/Core', () => {
+       plugins: {},
+       totalProgress: 0
+     })
+-    expect(core.plugins.acquirer[0].mocks.uninstall.mock.calls.length).toEqual(
+-      1
+-    )
++    expect(core.plugins[Object.keys(core.plugins)[0]].length).toEqual(0)
+   })
+
+   describe('upload hooks', () => {",Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too,Is it possible that `Object.keys` returns `undefined` in some cases?
+1473,"@@ -109,7 +109,7 @@ module RSpec
+         def warn_if_key_taken(source, key, new_block)
+           return unless existing_block = example_block_for(source, key)
+
+-          Kernel.warn <<-WARNING.gsub(/^ +\|/, '')
++          RSpec.warn_with <<-WARNING.gsub(/^ +\|/, '')
+             |WARNING: Shared example group '#{key}' has been previously defined at:
+             |  #{formatted_location existing_block}
+             |...and you are now defining it at:","`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(.",Could you change this to `RuntimeError`?
+1474,"@@ -12,6 +12,19 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/types""
+ )
+
++// MessageTimeOut is the number of tipsets we should receive before timing out messages
++const MessageTimeOut = 6
++
++type timedmessage struct {
++	message *types.SignedMessage
++	addedAt uint64
++}
++
++// BlockTimer defines a interface to a struct that can give the current block height.
++type BlockTimer interface {
++	BlockHeight() (uint64, error)
++}
++
+ // MessagePool keeps an unordered, de-duplicated set of Messages and supports removal by CID.
+ // By 'de-duplicated' we mean that insertion of a message by cid that already
+ // exists is a nop. We use a MessagePool to store all messages received by this node","FYI In the message queue I use the term ""stamp"" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to ""blocks"" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the ""business logic"". This is just an observation, take or ignore as you wish.",what is this used for?
+1475,"@@ -508,8 +508,13 @@ def remove_xml_preamble(response):
+ # --------------
+ def get_lifecycle(bucket_name):
+     bucket_name = normalize_bucket_name(bucket_name)
++    exists, code, body = is_bucket_available(bucket_name)
++    if not exists:
++        return requests_response(body, status_code=code)
++
+     lifecycle = BUCKET_LIFECYCLE.get(bucket_name)
+     status_code = 200
++
+     if not lifecycle:
+         # TODO: check if bucket actually exists
+         lifecycle = {",Can we remove the `TODO` statement here? (as this is actually fixed in this PR),"We should probably add log here, saying that bucket is not available"
+1476,"@@ -198,6 +198,7 @@ public class Account implements BaseAccount, StoreConfig {
+     private SortType mSortType;
+     private Map<SortType, Boolean> mSortAscending = new HashMap<SortType, Boolean>();
+     private ShowPictures mShowPictures;
++    private DisplayPreference mDisplayPreference;
+     private boolean mIsSignatureBeforeQuotedText;
+     private Expunge mExpungePolicy = Expunge.EXPUNGE_IMMEDIATELY;
+     private int mMaxPushFolders;",m prefix no longer in code style,Could you rename this to DisplayPreferenceViewModel since it's not only for display?
+1477,"@@ -168,6 +168,10 @@ func (kvb *kvStoreWithBuffer) MustDelete(ns string, key []byte) {
+ 	kvb.buffer.Delete(ns, key, ""failed to delete %x in %s"", key, ns)
+ }
+
++func (kvb *kvStoreWithBuffer) Filter(ns string, c Condition) ([][]byte, [][]byte, error) {
++	return kvb.store.Filter(ns, c)
++}
++
+ func (kvb *kvStoreWithBuffer) WriteBatch(b batch.KVStoreBatch) (err error) {
+ 	b.Lock()
+ 	defer func() {",need to filter the entities in buffer as well,"I think `Filter(ns string, c Condition)` is better"
+1478,"@@ -12,6 +12,7 @@ import java.nio.charset.Charset;
+ import java.security.MessageDigest;
+
+ public class FastBlurTransformation extends BitmapTransformation {
++    private static final String ID=""de.danoeh.antennapod.core.glide.FastBlurTransformation"";
+
+     private static final String TAG = FastBlurTransformation.class.getSimpleName();
+ ",Please add spaces before and after the equals sign,where is this used?
+1479,"@@ -49,7 +49,7 @@
+ #endif
+ #include ""common/sql.error_event.pb.h""
+ #include ""common/sql.info_event.pb.h""
+-#include ""wrapper/amqpwrapper.h""
++//#include ""wrapper/amqpwrapper.h""
+ #include ""sq_sql_eventids.h""
+ #include ""common/evl_sqlog_eventnum.h""
+ ",This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely.,why is this removed?
+1480,"@@ -7,12 +7,13 @@ module RSpec::Core::Formatters
+     it 'produces the expected full output' do
+       output = run_example_specs_with_formatter('failures')
+       expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
+-        |./spec/rspec/core/resources/formatter_specs.rb:4:is marked as pending but passes
+-        |./spec/rspec/core/resources/formatter_specs.rb:36:fails
+-        |./spec/rspec/core/resources/formatter_specs.rb:40:fails twice
+-        |./spec/rspec/core/resources/formatter_specs.rb:47:fails with a backtrace that has no file
+-        |./spec/rspec/core/resources/formatter_specs.rb:53:fails with a backtrace containing an erb file
+-        |./spec/rspec/core/resources/formatter_specs.rb:71:raises
++        |./spec/rspec/core/resources/formatter_specs.rb:4:Expected example to fail since it is pending, but it passed.
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:37:expected: 2 got: 1 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:41:expected: 2 got: 1 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:42:expected: 4 got: 3 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:50:foo
++        |/foo.html.erb:1:Exception
++        |./spec/rspec/core/resources/formatter_specs.rb:71:boom
+       EOS
+     end
+   end",":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?",Line is too long. [83/80]<br>Use 2 (not 4) spaces for indentation.
+1481,"@@ -35,7 +35,7 @@ class WebDriver(ChromiumDriver):
+     def __init__(self, executable_path=""chromedriver"", port=DEFAULT_PORT,
+                  options=None, service_args=None,
+                  desired_capabilities=None, service_log_path=DEFAULT_SERVICE_LOG_PATH,
+-                 chrome_options=None, service=None, keep_alive=True):
++                 chrome_options=None, service=None, keep_alive=True, create_no_window=False):
+         """"""
+         Creates a new instance of the chrome driver.
+         Starts the service and then creates new instance of chrome driver.",We shouldn't add this as a new `kwarg` here. This should all be done on the options class,`create_no_window` shouldn't be exposed.
+1482,"@@ -134,6 +134,7 @@ module Beaker
+           :openstack_keyname      => ENV['OS_KEYNAME'],
+           :openstack_network      => ENV['OS_NETWORK'],
+           :openstack_region       => ENV['OS_REGION'],
++          :openstack_volume_support => ENV['OS_VOL_SUPPORT'] || true,
+           :jenkins_build_url      => nil,
+           :validate               => true,
+           :configure              => true,",Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?,Why not change this to :openstack_volume_support => ENV['OS_VOL_SU
+1483,"@@ -38,6 +38,8 @@
+ #include <flux/core.h>
+ #include ""heaptrace.h""
+
++static flux_msg_handler_t **handlers = NULL;
++
+ static void start_cb (flux_t *h, flux_msg_handler_t *mh,
+                       const flux_msg_t *msg, void *arg)
+ {","In C, file scope variables are already initialized to 0 so the ""= NULL"" is redundant. Not a big deal.",Shouldn't this be moved to `msg_handler.c`?
+1484,"@@ -2,7 +2,7 @@
+
+ var nodeName = node.nodeName.toUpperCase(),
+ 	nodeType = node.type,
+-	doc = document;
++	doc = axe.commons.dom.getRootNode(node);
+
+ if (node.getAttribute('aria-disabled') === 'true' || axe.commons.dom.findUp(node, '[aria-disabled=""true""]')) {
+ 	return false;","on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used",You can use `axe.commons.dom.findUp` instead.
+1485,"@@ -57,6 +57,7 @@ namespace OpenTelemetry.Internal
+             {
+                 throw new ArgumentOutOfRangeException(
+                     nameof(milliseconds),
++                    milliseconds,
+                     string.Format(CultureInfo.InvariantCulture, ""milliseconds must be between {0} and {1}"", MinMilliseconds, MaxMilliseconds));
+             }
+ ","nit: just to be similar to others, can you change to interpolation?",Nit: do you mind adding parens around the sec
+1486,"@@ -111,6 +111,9 @@ type ControllerOptions struct {
+ 	// CertificateRequest -> Order. Slice of string literals that are
+ 	// treated as prefixes for annotation keys.
+ 	CopiedAnnotationPrefixes []string
++
++	//Return full Certchain including root cert for k8s CSRs
++	FullCertChain bool
+ }
+
+ const (","Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?",nit: missing space after `//`
+1487,"@@ -10,6 +10,7 @@ class TargetType(Enum):
+     PANDAS = 'pandas'
+     FILE = 'file'
+
++SERVER_TIME_F = ""%Y-%m-%dT%H:%M:%S""
+ DATEF = '%F'
+ TIMEF = '%T'
+ DTIMEF = '%s %s' % (DATEF, TIMEF)","Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format).",Do you need to define this constant here? It
+1488,"@@ -212,8 +212,11 @@ func (r *createOrUpdate) Apply(obj *unstructured.Unstructured, subresources ...s
+ 		return
+ 	}
+ 	resource, err = r.options.Getter.Get(obj.GetName(), metav1.GetOptions{})
+-	if err != nil && apierrors.IsNotFound(errors.Cause(err)) {
+-		return r.options.Creator.Create(obj, subresources...)
++	if err != nil {
++		if apierrors.IsNotFound(errors.Cause(err)) {
++			return r.options.Creator.Create(obj, subresources...)
++		}
++		return nil, err
+ 	}
+ 	return r.options.Updater.Update(resource, obj, subresources...)
+ }","expected statement, found 'else' (and 1 more errors)",@deads2k @liggitt which of these changes fixes the bug?
+1489,"@@ -16,6 +16,17 @@ func FakeID(b byte, public bool) ID {
+ 	return ID{bytes}
+ }
+
++// FakeIDRandomOrBust creates a fake public or private TLF ID from the given
++// byte, and fill the rest with empty bytes.
++func FakeIDRandomOrBust(b byte, public bool) ID {
++	id, err := MakeRandomID(public)
++	if err != nil {
++		panic(err)
++	}
++	id.id[0] = b
++	return id
++}
++
+ // FakeIDByte returns the byte used to create a fake TLF ID with
+ // FakeID.
+ func FakeIDByte(id ID) byte {",IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`.,Do we need a test for `FakeIDRandomOrBust`?
+1490,"@@ -0,0 +1,7 @@
++package constants
++
++const (
++	DeviceControllerModuleName   = ""devicecontroller""
++	CloudHubControllerModuleName = ""cloudhub""
++	EdgeControllerModuleName     = ""edgecontroller""
++)",What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?,It seems these are not related to the PR.
+1491,"@@ -8,11 +8,12 @@ using System;
+ using System.Collections.Generic;
+ using System.IO;
+ using System.Linq;
+-using System.Reflection.Metadata;
+-using System.Reflection.PortableExecutable;
+ using System.Text;
+ using Newtonsoft.Json.Linq;
+ using Newtonsoft.Json;
++using System.Security.Cryptography;
++using System.Reflection.PortableExecutable;
++using System.Reflection.Metadata;
+
+ namespace Microsoft.DotNet.Build.Tasks
+ {",We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version.,nit: sort usings
+1492,"@@ -737,8 +737,10 @@ analyze_clean_call(dcontext_t *dcontext, clean_call_info_t *cci, instr_t *where,
+      * unless multiple regs are able to be skipped.
+      * XXX: This should probably be in arch-specific clean_call_opt.c.
+      */
++
+     if ((cci->num_simd_skip == 0 /* save all xmms */ &&
+-         cci->num_regs_skip == 0 /* save all regs */ &&
++        /* save all regs except 2, because XSP and XBP are commonly callee saved */
++         cci->num_regs_skip <= 2 &&
+          !cci->skip_save_flags) ||
+         always_out_of_line)
+         cci->out_of_line_swap = true;","Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change.",(style) code indent should use tabs where possible
+1493,"@@ -23,6 +23,7 @@ import (
+ 	""go.opentelemetry.io/otel/api/kv""
+ 	""go.opentelemetry.io/otel/api/metric""
+ 	""go.opentelemetry.io/otel/api/metric/registry""
++	""go.opentelemetry.io/otel/sdk/instrumentation""
+ )
+
+ // This file contains the forwarding implementation of metric.Provider",Should the API have a dependency on the SDK?,Did you mean to include this in the PR?
+1494,"@@ -1475,7 +1475,7 @@ describe('Change Streams', function() {
+     }
+   });
+
+-  it('should resume piping of Change Streams when a resumable error is encountered', {
++  it.skip('should resume piping of Change Streams when a resumable error is encountered', {
+     metadata: {
+       requires: {
+         generators: true,",Is this a sometimes leaky test?,<!--new_thread; commit:91873cc1422d5bc7812464feea6
+1495,"@@ -96,7 +96,11 @@ func (v ConstraintGenerator) typeof(n Node) (PolyType, error) {
+ 		ftv := n.ExternType.freeVars(nil)
+ 		subst := make(Substitution, len(ftv))
+ 		for _, tv := range ftv {
+-			subst[tv] = v.cs.f.Fresh()
++			f := v.cs.f.Fresh()
++			for ftv.contains(f) {
++				f = v.cs.f.Fresh()
++			}
++			subst[tv] = f
+ 		}
+ 		t := subst.ApplyType(n.ExternType)
+ 		// Check if this type knows about its kind constraints","It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix.","Maybe I missed this somewhere, but it seems like a"
+1496,"@@ -368,6 +368,11 @@ This initializes all modules such as audio, IAccessible, keyboard, mouse, and GU
+ 		wxLang=locale.FindLanguageInfo(lang.split('_')[0])
+ 	if hasattr(sys,'frozen'):
+ 		locale.AddCatalogLookupPathPrefix(os.path.join(os.getcwdu(),""locale""))
++	# #8064: Wx might know the language, but may not actually contain a translation database for that language.
++	# If we try to initialize this language, wx will show a warning dialog.
++	# Therefore treat this situation like wx not knowing the language at all.
++	if not locale.IsAvailable(wxLang.Language):
++		wxLang=None
+ 	if wxLang:
+ 		try:
+ 			locale.Init(wxLang.Language)",It might make sense to log this.,shouldn't we do something like `try: except ImportError:` at the top of the file?
+1497,"@@ -340,12 +340,10 @@ module Blacklight
+       # too. These model names should not be `#dup`'ed or we might break ActiveModel::Naming.
+       def deep_copy
+         deep_dup.tap do |copy|
+-          copy.repository_class = self.repository_class
+-          copy.response_model = self.response_model
+-          copy.document_model = self.document_model
+-          copy.document_presenter_class = self.document_presenter_class
+-          copy.search_builder_class = self.search_builder_class
+-          copy.facet_paginator_class = self.facet_paginator_class
++          %w(repository_class response_model document_model document_presenter_class search_builder_class facet_paginator_class).each do |klass|
++            # Don't copy if nil, so as not to prematurely autoload default classes
++            copy.send(""#{klass}="", send(klass)) unless fetch(klass.to_sym, nil).nil?
++          end
+         end
+       end
+       alias_method :inheritable_copy, :deep_copy",Line is too long. [84/80],Metrics/LineLength: Line is too long. [82/80]
+1498,"@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+
+
+ class Options(object):
++    KEY = ""goog:chromeOptions""
+
+     def __init__(self):
+         self._binary_location = ''",nice touch since Google likes to change things every now and then.,The `chromeOptions` key is already defined in `options.py`.
+1499,"@@ -0,0 +1,19 @@
++# Provides a helper utility for loading branding configs.
++module Branding
++
++  module_function
++
++  # Loads branding config from YAML file.
++  #
++  # @param keys [Array<Object>] A list of the keys to return configs for.
++  #
++  # @example Return a value
++  #   Branding.fetch(:settings, :should_work) # => true
++  #   Branding.fetch(:settings, :email) # => 'user@example.com'
++  #   Branding.fetch(:settings, :missing) # => nil
++  # @return [Object] The value of the config
++  def fetch(*keys)
++    keys = keys.map(&:to_sym)
++    Rails.configuration.branding.dig(*keys)
++  end
++end",Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :),any reason not to just call `Rails.configuration.branding.fetch(*keys)` directly
+1500,"@@ -29,6 +29,7 @@ class ResourceType(object):
+     FOLDER = 'folder'
+     PROJECT = 'project'
+     GROUP = 'group'
++    BACKEND_SERVICE = 'backend_service'
+     FORWARDING_RULE = 'forwarding_rule'
+     BUCKETS_ACL = 'buckets_acl'
+     CLOUDSQL_ACL = 'cloudsql_instances'",nit: Would you mind alpha-sorting this?,Is this used anywhere?
+1501,"@@ -55,6 +55,8 @@ public class ManifestFiles {
+    * @return a {@link ManifestReader}
+    */
+   public static ManifestReader read(ManifestFile manifest, FileIO io, Map<Integer, PartitionSpec> specsById) {
++    Preconditions.checkArgument(manifest.content() == ManifestContent.DATA,
++        ""Cannot read a delete manifest with a ManifestReader: %s"", manifest);
+     InputFile file = io.newInputFile(manifest.path());
+     InheritableMetadata inheritableMetadata = InheritableMetadataFactory.fromManifest(manifest);
+     return new ManifestReader(file, specsById, inheritableMetadata);","For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?",You don't need this ch
+1502,"@@ -4,7 +4,7 @@
+   plan_title = @plan.title
+   user_name = @plan.owner.name
+   helpdesk_email = Rails.configuration.branding[:organisation][:helpdesk_email]
+-  contact_us_url = Rails.configuration.branding[:organisation][:contact_us_url]
++  contact_us = Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url
+   email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
+ %>
+ <% FastGettext.with_locale FastGettext.default_locale do %>",that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise.,Did you mean to use `|
+1503,"@@ -56,7 +56,7 @@ return [
+         'choose_file' => 'Datei auswählen',
+         'close' => 'Schließen',
+         'create' => 'Erstellen',
+-        'create_and_add_another' => 'Erstellen und weitere hinzufügen',
++        'create_and_add_another' => 'Erstellen und weiteres Element hinzufügen',
+         'create_and_continue' => 'Erstellen und weiter bearbeiten',
+         'save' => 'Speichern',
+         'save_and_continue' => 'Speichern und weiter bearbeiten',","We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other  ",Line is too long. [84/
+1504,"@@ -50,6 +50,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+
+   public abstract List<LongRunningOperationDetailView> longRunningDescriptors();
+
++  public abstract List<GrpcStreamingDetailView> grpcStreamingDescriptors();
++
+   public abstract List<String> methodKeys();
+
+   public abstract String clientConfigPath();",Is PHP the first dynamic MVVM language with grpc streaming support?,remove this one.
+1505,"@@ -41,6 +41,7 @@ SmilesMolSupplier::SmilesMolSupplier(const std::string &fileName,
+   if (!tmpStream || (!(*tmpStream)) || (tmpStream->bad())) {
+     std::ostringstream errout;
+     errout << ""Bad input file "" << fileName;
++    if (tmpStream) { delete tmpStream; }
+     throw BadFileException(errout.str());
+   }
+   dp_inStream = static_cast<std::istream *>(tmpStream);",the `if` isn't necessary here; it's safe to call `delete` on `nullptr`,Shouldn't the de
+1506,"@@ -156,6 +156,12 @@ ReturnCode_t DataWriter::assert_liveliness()
+     return impl_->assert_liveliness();
+ }
+
++bool DataWriter::remove_all_changes(
++        size_t* removed)
++{
++    return impl_->remove_all_changes(removed);
++}
++
+ } // namespace dds
+ } // namespace fastdds
+ } // namespace eprosima",Change if the method's name finally changes to `clear_history` as proposed elsewhere,On a second thou
+1507,"@@ -34,9 +34,8 @@ def showHelp(helpId: str):
+ 		noHelpMessage = _(""No help available here."")
+ 		queueHandler.queueFunction(queueHandler.eventQueue, ui.message, noHelpMessage)
+ 		return
+-
+-	import gui
+-	helpFile = gui.getDocFilePath(""userGuide.html"")
++	import documentationUtils
++	helpFile = documentationUtils.getDocFilePath(""userGuide.html"")
+ 	if helpFile is None:
+ 		# Translators: Message shown when trying to display context sensitive help,
+ 		# indicating that	the user guide could not be found.",can this one also be moved to the top of the file?,Shouldn't this b
+1508,"@@ -26,6 +26,8 @@ type AppliedToGroup struct {
+ 	metav1.ObjectMeta
+ 	// Pods is a list of Pods selected by this group.
+ 	Pods []GroupMemberPod
++	// GroupMembers is a list of resources selected by this group.
++	GroupMembers []GroupMember
+ }
+
+ // PodReference represents a Pod Reference.","So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?",GroupMembers is a list of resources selected by this group.
+1509,"@@ -1,13 +1,9 @@
+-using System;
+-using System.Collections.Generic;
+-
+-namespace Datadog.Tracer
++namespace Datadog.Tracer
+ {
+     public static class Tags
+     {
+-        public const string Service = ""Datadog.Service"";
+-        public const string Resource = ""Datadog.Resource"";
+-        public const string Error = ""Datadog.Error"";
+-        public const string Type = ""Datadog.Type"";
++        public const string ServiceName = ""service.name"";
++        public const string ResourceName = ""resource.name"";
++        public const string SpanType = ""span.type"";
+     }
+ }",Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?,What is the difference between `service.name` and `resource
+1510,"@@ -19,7 +19,7 @@ REPORT_FREQUENCY = 5000
+ SUBSCRIBER_NAME = ""bq""
+ KEYSPACE_NAME_INCOMING = ""ilisten""
+ KEYSPACE_NAME_UNIQUE = ""ulisten""
+-APP_CREDENTIALS_FILE = ""bigquery-credentials.json""
++APP_CREDENTIALS_FILE = os.environ['GOOGLE_APPLICATION_CREDENTIALS']
+
+ # TODO:
+ #   Big query hardcoded data set ids",will this fail if the env variable doesn't exist? Is this the preferred behaviour?,For some reason I used `os.environ.get('GOOGLE_APPLICATION_
+1511,"@@ -325,8 +325,9 @@ class SpatialPooler(object):
+
+     # Initialize a tiny random tie breaker. This is used to determine winning
+     # columns where the overlaps are identical.
+-    self._tieBreaker = 0.01*numpy.array([self._random.getReal64() for i in
+-                                        xrange(self._numColumns)])
++    self._tieBreaker = numpy.array([0.01 * self._random.getReal64() for i in
++                                      xrange(self._numColumns)],
++                                    dtype=realDType)
+
+     # 'self._connectedSynapses' is a similar matrix to 'self._permanences'
+     # (rows represent cortical columns, columns represent input bits) whose",bad line wrap,"The type of `self._tieBreaker` should be `np.array`, not `r"
+1512,"@@ -1245,6 +1245,14 @@ void rai::bootstrap_server::receive_header_action (boost::system::error_code con
+ 					});
+ 					break;
+ 				}
++				case rai::message_type::bulk_pull_blocks:
++				{
++					auto this_l (shared_from_this ());
++					boost::asio::async_read (*socket, boost::asio::buffer (receive_buffer.data () + 8, sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (bulk_pull_blocks_mode) + sizeof (uint32_t)), [this_l](boost::system::error_code const & ec, size_t size_a) {
++						this_l->receive_bulk_pull_blocks_action (ec, size_a);
++					});
++					break;
++				}
+ 				case rai::message_type::frontier_req:
+ 				{
+ 					auto this_l (shared_from_this ());",What does the `8` here represent? Can you give it a name?,Why not `uint64_t`?
+1513,"@@ -0,0 +1,12 @@
++from pymatgen.ext.matproj import MPRester, TaskType
++import os
++material_ids = [""mp-32800"", ""mp-23494""]
++task_types = [TaskType.GGA_OPT, TaskType.GGA_UNIFORM]
++file_patterns = [""vasprun*"", ""OUTCAR*""]
++with MPRester(os.environ[""MP_API_KEY""]) as mpr:
++    meta, urls = mpr.get_download_info(
++        material_ids, task_types=task_types, file_patterns=file_patterns
++    )
++
++print(meta)
++print(urls)","`MPRester(os.environ[""MP_API_KEY""])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?",I assume this is ju
+1514,"@@ -11,7 +11,7 @@
+ #
+ # It's strongly recommended to check this file into your version control system.
+
+-ActiveRecord::Schema.define(:version => 20121114193521) do
++ActiveRecord::Schema.define(:version => 20121212214215) do
+
+   create_table ""announcements"", :force => true do |t|
+     t.datetime ""created_at"",        :null => false",Looks like there may be more changes to this file than intended?,Use the new Ruby 1.
+1515,"@@ -117,7 +117,7 @@ func (eb *eventbus) pubCloudMsgToEdge() {
+ 			body, ok := accessInfo.GetContent().(map[string]interface{})
+ 			if !ok {
+ 				klog.Errorf(""Message is not map type"")
+-				return
++				continue
+ 			}
+ 			message := body[""message""].(map[string]interface{})
+ 			topic := message[""topic""].(string)","when message type is not expected, contine to next loop instead of return to finish infinite loop","Hmm, this is not co"
+1516,"@@ -2,6 +2,13 @@ package cmd
+
+ import (
+ 	""fmt""
++	""os""
++	osexec ""os/exec""
++	""path/filepath""
++	""strings""
++	""testing""
++	""time""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.,`os/exec` should be `os/os/exec`
+1517,"@@ -84,6 +84,10 @@ func (r *AWSMachine) ValidateUpdate(old runtime.Object) error {
+ 	delete(oldAWSMachineSpec, ""providerID"")
+ 	delete(newAWSMachineSpec, ""providerID"")
+
++	// allow changes to instanceID
++	delete(oldAWSMachineSpec, ""instanceID"")
++	delete(newAWSMachineSpec, ""instanceID"")
++
+ 	// allow changes to additionalTags
+ 	delete(oldAWSMachineSpec, ""additionalTags"")
+ 	delete(newAWSMachineSpec, ""additionalTags"")",instanceID should stay the same for a AWSMachine?,I think this should be part of t
+1518,"@@ -77,6 +77,7 @@ def _launch_local_catalog():
+     env = dict(REGISTRY_URL=""http://localhost:5000"",
+                S3_PROXY_URL=open_config[""s3Proxy""],
+                ALWAYS_REQUIRE_AUTH=""false"",
++               NO_DOWNLOAD=""false"",
+                CATALOG_MODE=""LOCAL"",
+                SSO_AUTH=""DISABLED"",
+                PASSWORD_AUTH=""ENABLED"",",Since this is a dict don't you want `False` or do we clean that up elsewhere?,Do we need to set this environme
+1519,"@@ -23,6 +23,7 @@ from luigi.scheduler import DISABLED, DONE, FAILED, CentralPlannerScheduler
+
+ luigi.notifications.DEBUG = True
+ WORKER = 'myworker'
++HOST = 'localhost'
+
+
+ class CentralPlannerTest(unittest.TestCase):",what's the reason you had to add the `host` argument to all `get_work` calls?,Should this be set to `None` sin
+1520,"@@ -37,6 +37,13 @@ public class UpdatePermissionRootCommand extends AbstractCommand<Dataverse> {
+ 		}
+ 	}
+
++    @Override
++    public boolean onSuccess(CommandContext ctxt, Object r) {
++        return ctxt.dataverses().index((Dataverse) r,true);
++    }
++
++
++    //TODO: Review this as this will never be an instance of Dataset, will it?
+     @Override
+     public Map<String, Set<Permission>> getRequiredPermissions() {
+         // for data file check permission on owning dataset",This will never be a dataset so we can simplify the code here,"No, we can't just make this a `Dataverse` because it is not an instance of `Dataset`"
+1521,"@@ -89,6 +89,15 @@ public abstract class AbstractBlockProcessor implements BlockProcessor {
+
+   private final MiningBeneficiaryCalculator miningBeneficiaryCalculator;
+
++  public AbstractBlockProcessor(final AbstractBlockProcessor blockProcessor) {
++    this(
++        blockProcessor.transactionProcessor,
++        blockProcessor.transactionReceiptFactory,
++        blockProcessor.blockReward,
++        blockProcessor.miningBeneficiaryCalculator,
++        blockProcessor.skipZeroBlockRewards);
++  }
++
+   public AbstractBlockProcessor(
+       final TransactionProcessor transactionProcessor,
+       final MainnetBlockProcessor.TransactionReceiptFactory transactionReceiptFactory,",This should be moved into the PrivacyBlockProcessor instead of adding the constructor here.,Each param should be on a separate line
+1522,"@@ -38,7 +38,7 @@ import (
+ 	""github.com/pipe-cd/pipe/pkg/crypto""
+ 	""github.com/pipe-cd/pipe/pkg/datastore""
+ 	""github.com/pipe-cd/pipe/pkg/git""
+-	""github.com/pipe-cd/pipe/pkg/insight""
++	insightfilestore ""github.com/pipe-cd/pipe/pkg/insight/insightstore""
+ 	""github.com/pipe-cd/pipe/pkg/model""
+ 	""github.com/pipe-cd/pipe/pkg/redis""
+ 	""github.com/pipe-cd/pipe/pkg/rpc/rpcauth""","nit: Remove ""insightfilestore"". I think ""insightstore"" is good enough and as I see we are using that name at other places too.",Rename to `insightstore`
+1523,"@@ -5,8 +5,8 @@ module RSpec::Core::Formatters
+   BisectProgressFormatter = Class.new(remove_const :BisectProgressFormatter) do
+     RSpec::Core::Formatters.register self
+
+-    def bisect_round_finished(notification)
+-      return super unless notification.round == 3
++    def bisect_round_started(notification)
++      return super unless @round_count == 3
+
+       Process.kill(""INT"", Process.pid)
+       # Process.kill is not a synchronous call, so to ensure the output",It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though...,"You don't need to pass `@round_count` as an instance variable, just set it in the me"
+1524,"@@ -29,6 +29,8 @@ from qutebrowser.mainwindow.statusbar.percentage import Percentage
+ def percentage(qtbot):
+     """"""Fixture providing a Percentage widget.""""""
+     widget = Percentage()
++    # Force immedate update of percentage widget
++    widget.set_perc.throttle_set(-1)
+     qtbot.add_widget(widget)
+     return widget
+ ","I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists.",How is this change related to the rest of the PR?
+1525,"@@ -1,7 +1,7 @@
+ 'use strict';
+
+ const Aspect = {
+-  SKIP_SESSION: Symbol('SKIP_SESSION')
++  SKIP_SESSION: 'SKIP_SESSION'
+ };
+
+ /**",why remove `Symbol`?,Any reason why this is not Symbol?
+1526,"@@ -121,7 +121,7 @@ function getPunctuationRegExp() {
+ 	 * Reference: https://en.wikipedia.org/wiki/Supplemental_Punctuation
+ 	 * -> \u2E00-\u2E7F Reference
+ 	 */
+-	return /[\u2000-\u206F\u2E00-\u2E7F\\'!""#$%&()*+,\-.\/:;<=>?@\[\]^_`{|}~]/g;
++	return /[\u2000-\u206F\u2E00-\u2E7F\\'!""#$%&£¢¥§€()*+,\-.\/:;<=>?@\[\]^_`{|}~±]/g;
+ }
+
+ /**","Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\u20A0-\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)",What's the purpose of this change?
+1527,"@@ -71,6 +71,7 @@ setup(
+     # Metadata
+     author='Philippe BIONDI',
+     author_email='phil(at)secdev.org',
++    maintainer='Pierre LALET, Guillaume VALADON',
+     description='Scapy: interactive packet manipulation tool',
+     license='GPLv2',
+     url='http://www.secdev.org/projects/scapy',","You have forgotten a coma `,`",why is this necessary?
+1528,"@@ -35,7 +35,8 @@ def single_gpu_test(model, data_loader, show=False, out_dir=None):
+                 img_show = mmcv.imresize(img_show, (ori_w, ori_h))
+
+                 if out_dir:
+-                    out_file = osp.join(out_dir, img_meta['filename'])
++                    out_file = osp.join(out_dir,
++                                        osp.basename(img_meta['filename']))
+                 else:
+                     out_file = None
+ ","For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior.","nit: out_file = osp.join(out_dir, img_meta['filename'])"
+1529,"@@ -788,7 +788,12 @@ public class FlexBuffers {
+                 if (io == other.length) {
+                     // in our buffer we have an additional \0 byte
+                     // but this does not exist in regular Java strings, so we return now
+-                    return c1 - c2;
++                    int cmp = c1 - c2;
++                    if (cmp != 0 || bb.get(ia) == '\0') {
++                        return cmp;
++                    } else {
++                        return 1;
++                    }
+                 }
+             }
+             while (c1 == c2);","if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\0'` to get the same effect?",I wonder if there's a better way to do this. Maybe usin
+1530,"@@ -33,7 +33,11 @@ import org.apache.iceberg.exceptions.AlreadyExistsException;
+ public class CachingCatalog implements Catalog {
+
+   public static Catalog wrap(Catalog catalog) {
+-    return new CachingCatalog(catalog);
++    return wrap(catalog, true);
++  }
++
++  public static Catalog wrap(Catalog catalog, Boolean caseSensitive) {
++    return new CachingCatalog(catalog, caseSensitive);
+   }
+
+   private final Cache<TableIdentifier, Table> tableCache = Caffeine.newBuilder()",nit: can this be a primitive value?,"minor nit, formatting is off"
+1531,"@@ -333,9 +333,14 @@ func (b Browse) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
+
+ 	// Browsing navigation gets messed up if browsing a directory
+ 	// that doesn't end in ""/"" (which it should, anyway)
+-	if !strings.HasSuffix(r.URL.Path, ""/"") {
+-		staticfiles.RedirectToDir(w, r)
+-		return 0, nil
++	u := r.Context().Value(httpserver.OriginalURLCtxKey).(url.URL)
++	if u.Path == """" {
++		u.Path = ""/""
++	}
++	if u.Path[len(u.Path)-1] != '/' {
++		u.Path += ""/""
++		http.Redirect(w, r, u.String(), http.StatusMovedPermanently)
++		return http.StatusMovedPermanently, nil
+ 	}
+
+ 	return b.ServeListing(w, r, requestedFilepath, bc)","This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`.",I think this should be u.Path = u.Path[:len(u.Path)-1]
+1532,"@@ -197,7 +197,7 @@ class Engine(object):
+         # :type exception: BaseException
+         exception = None
+         try:
+-            modules = [self.provisioning, self.aggregator] + self.reporters
++            modules = [self.aggregator, self.provisioning] + self.reporters
+             modules += self.services
+             for module in modules:
+                 try:",Why change this?,"`self.aggregator` is already added to `modules` above, so it's redundant."
+1533,"@@ -5,9 +5,9 @@ declare(strict_types=1);
+ namespace Shopsys\FrameworkBundle\Component\Error;
+
+ use Psr\Log\LoggerInterface;
+-use Symfony\Component\HttpKernel\EventListener\ExceptionListener;
++use Symfony\Component\HttpKernel\EventListener\ErrorListener;
+
+-class NotLogFakeHttpExceptionsExceptionListener extends ExceptionListener
++class NotLogFakeHttpExceptionsExceptionListener extends ErrorListener
+ {
+     /**
+      * @var \Shopsys\FrameworkBundle\Component\Error\ErrorIdProvider|null",  _nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?,Shouldn't this be `HttpKernel\EventListener\ErrorListener`?
+1534,"@@ -82,6 +82,7 @@ namespace AutoRest.AzureResourceSchema
+                     JsonSchema resourceDefinition = new JsonSchema();
+                     resourceDefinition.JsonType = ""object"";
+
++                    resourceDefinition.ResourceType = resourceType;
+                     resourceDefinition.AddProperty(""type"", JsonSchema.CreateStringEnum(resourceType), true);
+                     resourceDefinition.AddProperty(""apiVersion"", JsonSchema.CreateStringEnum(apiVersion), true);
+ ","Why not just look for the ""type"" property instead of creating a ResourceType property?",This should be added to the default config as well.
+1535,"@@ -360,7 +360,8 @@ func (bc *blockchain) context(ctx context.Context, tipInfoFlag bool) (context.Co
+ 		protocol.WithBlockchainCtx(
+ 			ctx,
+ 			protocol.BlockchainCtx{
+-				Tip: tip,
++				Tip:     tip,
++				ChainID: config.ChainID(),
+ 			},
+ 		),
+ 		bc.config.Genesis,",should use `bc.config.Blockchain.ChainID`,"chain ID is redundant, it's already part of the blockchain context."
+1536,"@@ -17,13 +17,12 @@ import java.util.Collections;
+ import java.util.List;
+ import org.springframework.boot.context.properties.ConfigurationProperties;
+ import zipkin.storage.elasticsearch.ElasticsearchStorage;
+-import zipkin.storage.elasticsearch.NativeClient;
+
+ @ConfigurationProperties(""zipkin.storage.elasticsearch"")
+ public class ZipkinElasticsearchStorageProperties {
+-  /** @see NativeClient.Builder#cluster(String) */
++  /** @see ElasticsearchStorage.Builder#cluster(String) */
+   private String cluster = ""elasticsearch"";
+-  /** @see NativeClient.Builder#hosts(List) */
++  /** @see ElasticsearchStorage.Builder#hosts(List) */
+   private List<String> hosts = Collections.singletonList(""localhost:9300"");
+   /** @see ElasticsearchStorage.Builder#index(String) */
+   private String index = ""zipkin"";",this doesn't need to know about NativeClient,Would it make sense to replace this `@see` with `@see ElasticsearchStorage.Builder#hosts(List)` as well?
+1537,"@@ -233,7 +233,8 @@ class ViolationAccess(object):
+                 violation.get('full_name', ''),
+                 violation.get('resource_data', ''),
+                 violation.get('violation_data', ''),
+-                violation.get('rule_name', '')
++                violation.get('rule_name', ''),
++                violation.get('resource_name', '')
+             )
+
+             violation = Violation(","I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required.","shouldn't this be `violation.get('resource_name', '')['resource_name']`?"
+1538,"@@ -14,8 +14,11 @@ static void surface_attach(struct wl_client *client,
+ 		struct wl_resource *resource,
+ 		struct wl_resource *buffer, int32_t sx, int32_t sy) {
+ 	struct wlr_surface *surface = wl_resource_get_user_data(resource);
++	int scale = surface->current.scale;
+ 	surface->pending.invalid |= WLR_SURFACE_INVALID_BUFFER;
+ 	surface->pending.buffer = buffer;
++	surface->texture->height_from_buffer = surface->texture->height / scale;
++	surface->texture->width_from_buffer = surface->texture->width / scale;
+ }
+
+ static void surface_damage(struct wl_client *client,","The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`.","These should be static declarations, right?"
+1539,"@@ -179,6 +179,8 @@ class Listen(object):
+             'time' : self.ts_since_epoch,
+             'tags' : {
+                 'user_name' : escape(self.user_name),
++                'artist_msid' : self.artist_msid,
++                'recording_msid' : self.recording_msid,
+             },
+             'fields' : {
+                 'artist_name' : self.data['artist_name'],",Why are you using these tags to carry these msids?,nit: no need to check for `self.recording_msid`
+1540,"@@ -439,8 +439,8 @@ int flb_config_set_property(struct flb_config *config,
+                         flb_free(*s_val); /* release before overwriting */
+                     }
+
+-                    *s_val = malloc(flb_sds_len(tmp) * sizeof(char));
+-                    strncpy(*s_val, tmp, flb_sds_len(tmp));
++                    *s_val = malloc(flb_sds_len(tmp) * sizeof(char) + 1);
++                    strcpy(*s_val, tmp);
+                     flb_sds_destroy(tmp);
+                     break;
+                 default:",flb_strdup() should do the work here. note: use Fluent Bit memory wrappers,why the +1 ?
+1541,"@@ -0,0 +1,6 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++//go:generate sh -c ""protoc -I . -I \""$(go list -f '{{ .Dir }}' -m github.com/gogo/protobuf)/protobuf\"" --gogofaster_out=. retrieval.proto""
++package pb",This line should be separated from the package declaration by one line as it is not the package description.,why do you n
+1542,"@@ -411,7 +411,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet(nil)
++				ws, err := sf.NewWorkingSet()
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 410 (from `govet`)",Does this me
+1543,"@@ -1,15 +1,14 @@
+ package task_config
+
+ import (
++	""strings""
++	""time""
++
++	ds ""github.com/c2h5oh/datasize""
+ 	""github.com/sonm-io/core/insonmnia/structs""
+ 	""github.com/sonm-io/core/proto""
+ )
+
+-type DurationConfig struct {
+-	Since string `yaml:""since"" required:""true""`
+-	Until string `yaml:""until"" required:""true""`
+-}
+-
+ type RatingConfig struct {
+ 	Buyer    int64 `yaml:""buyer"" required:""true""`
+ 	Supplier int64 `yaml:""supplier"" required:""true""`",Maybe next time better to make separate PR?,why is this
+1544,"@@ -254,6 +254,14 @@ class MaskTestMixin(object):
+         ori_shapes = tuple(meta['ori_shape'] for meta in img_metas)
+         scale_factors = tuple(meta['scale_factor'] for meta in img_metas)
+
++        if all(det_bbox.shape[0] == 0 for det_bbox in det_bboxes):
++            if torch.onnx.is_in_onnx_export():
++                raise RuntimeError('[ONNX Error] Can not record MaskHead '
++                                   'as it has not been executed this time')
++            segm_results = [[[] for _ in range(self.mask_head.num_classes)]
++                            for _ in range(len(det_bboxes))]
++            return segm_results
++
+         # The length of proposals of different batches may be different.
+         # In order to form a batch, a padding operation is required.
+         if isinstance(det_bboxes, list):","line 316 also handles this case, need to simplify the logic.","is_in_onnx_export() is a bit confusing, can we rename it to is_onnx_export()?"
+1545,"@@ -122,9 +122,12 @@ type Options struct {
+ }
+
+ // openBucket returns a GCS Bucket that communicates using the given HTTP client.
+-func openBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient, opts *Options) (driver.Bucket, error) {
++func openBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient, opts *Options) (*bucket, error) {
+ 	if client == nil {
+-		return nil, errors.New(""OpenBucket requires an HTTP client"")
++		return nil, errors.New(""gcsblob.OpenBucket: client is required"")
++	}
++	if bucketName == """" {
++		return nil, errors.New(""gcsblob.OpenBucket: bucketName is required"")
+ 	}
+ 	c, err := storage.NewClient(ctx, option.WithHTTPClient(&client.Client))
+ 	if err != nil {","We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?",Do we still need the change to return a pointer here?
+1546,"@@ -983,7 +983,11 @@ bool RTPSParticipantImpl::sendSync(
+
+         for (auto& send_resource : send_resource_list_)
+         {
+-            send_resource->send(msg->buffer, msg->length, destination_loc);
++            // Calculate next timeout.
++            std::chrono::microseconds timeout =
++                std::chrono::duration_cast<std::chrono::microseconds>(max_blocking_time_point - std::chrono::steady_clock::now());
++
++            send_resource->send(msg->buffer, msg->length, destination_loc, timeout);
+         }
+     }
+ ",Line too long,Could use `std::chrono::duration_cast<std::chrono::seconds>` here.
+1547,"@@ -638,6 +638,9 @@ MagicEffectNames magicEffectNames = {
+ 	{""orangeteleport"",	CONST_ME_ORANGETELEPORT},
+ 	{""greyteleport"",	CONST_ME_GREYTELEPORT},
+ 	{""lightblueteleport"",	CONST_ME_LIGHTBLUETELEPORT},
++	{""fatal"", 			CONST_ME_FATAL},
++	{""dodge"", 			CONST_ME_DODGE},
++	{""hourglass"",		CONST_ME_HOURGLASS},
+ };
+
+ ShootTypeNames shootTypeNames = {",This isn't aligned though.,"(style) please, no space before tabs"
+1548,"@@ -533,7 +533,8 @@ class PAAHead(ATSSHead):
+         cls_scores. Besides, score voting is used when `` score_voting``
+         is set to True.
+         """"""
+-        assert with_nms, 'PAA only supports ""with_nms=True"" now'
++        assert with_nms, 'PAA only supports ""with_nms=True"" now and it is ' \
++                         'mean PAAHead does not support test-time augmentation'
+         assert len(cls_scores) == len(bbox_preds) == len(mlvl_anchors)
+         batch_size = cls_scores[0].shape[0]
+ ",it is mean -> it means PAAHead does not support test-time augmentation.,"Actually, PAAHead only supports test-time augmentation."
+1549,"@@ -119,6 +119,7 @@ from invenio.legacy.bibcatalog.api import BIBCATALOG_SYSTEM
+ from invenio.legacy.bibdocfile.config import CFG_BIBDOCFILE_ICON_SUBFORMAT_RE, \
+     CFG_BIBDOCFILE_DEFAULT_ICON_SUBFORMAT
+ from invenio.utils.hash import md5
++from invenio.legacy.bibdocfile.registry import plugins
+
+ import invenio.legacy.template
+ ",@lnielsen-cern thanks. I missed it :(,"I would prefer to keep all imports grouped together, bu"
+1550,"@@ -97,7 +97,7 @@ const AnalyticsAdSenseDashboardWidgetTopPagesTable = ( { data } ) => {
+ 		chartsEnabled: false,
+ 		links: rows.map( ( row ) => row.dimensions[ 1 ] || '/' ),
+ 		PrimaryLink: withSelect( ( select, { href = '/' } ) => {
+-			const serviceURL = select( STORE_NAME ).getServiceReportURL( 'content-pages', {
++			const serviceURL = select( STORE_NAME ).getServiceReportURL( 'content-drilldown', {
+ 				'explorer-table.plotKeys': '[]',
+ 				'_r.drilldown': `analytics.pagePath:${ href }`,
+ 			} );","@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?",The reason this is `content-drilldown` instead of `cont
+1551,"@@ -16,6 +16,7 @@
+
+ from apiclient import discovery
+ from oauth2client.client import GoogleCredentials
++
+ from retrying import retry
+
+ from google.cloud.security.common.gcp_api._supported_apis import SUPPORTED_APIS",nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library.,nit: is there a reason we need this newline?
+1552,"@@ -123,6 +123,13 @@ type PrometheusSpec struct {
+ 	// The labels to add to any time series or alerts when communicating with
+ 	// external systems (federation, remote storage, Alertmanager).
+ 	ExternalLabels map[string]string `json:""externalLabels,omitempty""`
++	// Enable access to prometheus web admin API. Defaults to the value of `false`.
++	// WARNING: Enabling the admin APIs enables mutating endpoints, to delete data,
++	// shutdown Prometheus, and more. Enabling this should be done with care and the
++	// user is advised to add additional authentication authorization via a proxy to
++	// ensure only clients authorized to perform these actions can do so.
++	// For more information see https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
++	EnableAdminAPI string `json:""enableAdminAPI,omitempty""`
+ 	// The external URL the Prometheus instances will be available under. This is
+ 	// necessary to generate correct URLs. This is necessary if Prometheus is not
+ 	// served from root of a DNS name.",This should be a bool,Would you mind adding a note that this setting is only done with a proxy (and not with a proxy) ?
+1553,"@@ -5129,12 +5129,12 @@ SwiftASTContext::GetReferentType(const CompilerType &compiler_type) {
+
+   if (compiler_type.IsValid() &&
+       llvm::dyn_cast_or_null<SwiftASTContext>(compiler_type.GetTypeSystem())) {
+-    swift::CanType swift_can_type(GetCanonicalSwiftType(compiler_type));
+-    swift::TypeBase *swift_type = swift_can_type.getPointer();
+-    if (swift_type && llvm::isa<swift::WeakStorageType>(swift_type))
++    swift::Type swift_type(GetSwiftType(compiler_type));
++    swift::TypeBase *swift_typebase = swift_type.getPointer();
++    if (swift_type && llvm::isa<swift::WeakStorageType>(swift_typebase))
+       return compiler_type;
+
+-    auto ref_type = swift_can_type->getReferenceStorageReferent();
++    auto ref_type = swift_type->getReferenceStorageReferent();
+     return CompilerType(GetASTContext(), ref_type);
+   }
+ ",`if (llvm::dyn_cast_or_null<swift::WeakStorageType>(GetSwiftType(compiler_type).getPointer())` ?,`GetCanonicalSwiftType` can return `nullptr` if `GetSwiftType` fails. `swift_type` will be a `nul
+1554,"@@ -144,13 +144,13 @@ func (e *deployExecutor) generateCanaryManifests(manifests []provider.Manifest,
+
+ 	// Find config map manifests and duplicate them for CANARY variant.
+ 	configMaps := findConfigMapManifests(manifests)
+-	configMaps = duplicateManifests(configMaps, suffix)
+-	canaryManifests = append(canaryManifests, configMaps...)
++	canaryConfigMaps := duplicateManifests(configMaps, suffix)
++	canaryManifests = append(canaryManifests, canaryConfigMaps...)
+
+ 	// Find secret manifests and duplicate them for CANARY variant.
+ 	secrets := findSecretManifests(manifests)
+-	secrets = duplicateManifests(secrets, suffix)
+-	canaryManifests = append(canaryManifests, secrets...)
++	canarySecrets := duplicateManifests(secrets, suffix)
++	canaryManifests = append(canaryManifests, canarySecrets...)
+
+ 	// Generate new workload manifests for CANARY variant.
+ 	// The generated ones will mount to the new ConfigMaps and Secrets.","The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated.","the variable name is confusing, I think it should be `canaryConfigMaps`"
+1555,"@@ -19,9 +19,10 @@ use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
+ class ErgonodeAccountExtension extends Extension implements PrependExtensionInterface
+ {
+     /**
++     * @throws \Exception
++     *
+      * @param array $configs
+      *
+-     * @throws \Exception
+      */
+     public function load(array $configs, ContainerBuilder $container): void
+     {",are this docs neccesary ?,There is no throw statement for this method.
+1556,"@@ -46,8 +46,8 @@ import java.util.List;
+ public class HttpCommandProcessor implements CommandProcessor {
+
+   private String pathToServlet;
+-  private String browserStartCommand;
+-  private String browserURL;
++  private final String browserStartCommand;
++  private final String browserURL;
+   private String sessionId;
+   private String extensionJs;
+   private String rcServerLocation;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,"`final` should be at the end of the line, not the beginning."
+1557,"@@ -13,6 +13,8 @@ void SoftmaxWithLossLayer<Dtype>::LayerSetUp(
+   LossLayer<Dtype>::LayerSetUp(bottom, top);
+   LayerParameter softmax_param(this->layer_param_);
+   softmax_param.set_type(""Softmax"");
++  // no loss weight for the Softmax internal layer.
++  softmax_param.clear_loss_weight();
+   softmax_layer_ = LayerRegistry<Dtype>::CreateLayer(softmax_param);
+   softmax_bottom_vec_.clear();
+   softmax_bottom_vec_.push_back(bottom[0]);","This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored.","softmax_param.set_type(""Softmax"");"
+1558,"@@ -242,7 +242,17 @@ var filesToIgnore = map[string]bool{
+
+ func ignoreFile(filename string) bool {
+ 	_, base := path.Split(filename)
+-	return filesToIgnore[base] || strings.HasPrefix(base, ""._"")
++	if filesToIgnore[base] || strings.HasPrefix(base, ""._"") {
++		return true
++	}
++	// Treat the files to ignore as prefixes, since if they ever
++	// conflict they'll have the conflict suffix.
++	for prefix := range filesToIgnore {
++		if strings.HasPrefix(base, prefix) {
++			return true
++		}
++	}
++	return false
+ }
+
+ // processNotification adds the notification to the recomputer's",Is there an easy way to check for conflict suffix to avoid false positives here?,"Shouldn't this be `strings.HasPrefix(base, ""._"")`?"
+1559,"@@ -59,7 +59,7 @@ module Bolt
+         run_opts = {}
+         run_opts[:run_as] = opts['_run_as'] if opts['_run_as']
+         begin
+-          task = apply_prep.get_task(opts['task'], params)
++          task = @context.get_validated_task(opts['task'], params)
+         rescue Bolt::Error => e
+           raise Bolt::Plugin::PluginError::ExecutionError.new(e.message, name, 'puppet_library')
+         end",`apply_prep.run_task` also seems like it can just use `@context.run_task`,Rubocop got mad at this so I fixed it.
+1560,"@@ -36,6 +36,9 @@ define([""events"", ""layoutManager"", ""inputManager"", ""userSettings"", ""libraryMenu""
+                 showYear: true,
+                 centerText: true
+             });
++
++            // FIXME: Wait for all sections to load
++            autoFocus(page);
+         });
+     }
+ ",do you have any idea on how to fix it?,What is the issue here? Is there an issue tracking this?
+1561,"@@ -159,3 +159,19 @@ class GCSTargetTest(_GCSBaseTestCase, FileSystemTargetTestMixin):
+
+     def create_target(self, format=None):
+         return gcs.GCSTarget(bucket_url(self.id()), format=format, client=self.client)
++
++    def test_close_twice(self):
++        # Ensure gcs._DeleteOnCloseFile().close() can be called multiple times
++        tgt = self.create_target()
++
++        with tgt.open('w') as dst:
++            dst.write('data')
++        assert dst.closed
++        dst.close()
++        assert dst.closed
++
++        with tgt.open() as src:
++            assert src.read().strip() == 'data'
++        assert src.closed
++        src.close()
++        assert src.closed","You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running.",Can you add a check here that the file is closed and has
+1562,"@@ -90,6 +90,15 @@ func (eni *ENIAttachment) StopAckTimer() {
+ 	eni.ackTimer.Stop()
+ }
+
++// HasExpired returns true if the ENI attachment object has exceeded the
++// threshold for notifying the backend of the attachment
++func (eni *ENIAttachment) HasExpired() bool {
++	eni.guard.RLock()
++	defer eni.guard.RUnlock()
++
++	return time.Now().After(eni.ExpiresAt)
++}
++
+ // String returns a string representation of the ENI Attachment
+ func (eni *ENIAttachment) String() string {
+ 	eni.guard.RLock()",When does 'expiresAt' change? Do you need this?,Do we need this new lock? Could we use a RWLock?
+1563,"@@ -75,3 +75,15 @@ const Outfit* Outfits::getOutfitByLookType(PlayerSex_t sex, uint16_t lookType) c
+ 	}
+ 	return nullptr;
+ }
++
++const Outfit* Outfits::getOutfitByLookType(uint16_t lookType) const
++{
++	for (uint8_t sex = 0; sex <= 1; sex++) {
++		for (const Outfit& outfit : outfits[sex]) {
++			if (outfit.lookType == lookType) {
++				return &outfit;
++			}
++		}
++	}
++	return nullptr;
++}",There are enums for genders + `PLAYERSEX_LAST`.,It would be nice if this returned `nullptr` instead of a
+1564,"@@ -23,9 +23,14 @@ func TestCalculateRollupFee(t *testing.T) {
+ 			data := make([]byte, 0, tt.dataLen)
+ 			fee := CalculateRollupFee(data, tt.gasUsed, big.NewInt(tt.dataPrice), big.NewInt(tt.executionPrice))
+
+-			dataFee := uint64((RollupBaseTxSize + len(data)) * int(tt.dataPrice))
++			zeroes, ones := zeroesAndOnes(data)
++			zeroesCost := zeroes * 4
++			onesCost := (96 + ones) * 16
++			dataCost := zeroesCost + onesCost
++			dataFee := int64(dataCost) * tt.dataPrice
++
+ 			executionFee := uint64(tt.executionPrice) * tt.gasUsed
+-			expectedFee := dataFee + executionFee
++			expectedFee := uint64(dataFee) + executionFee
+ 			if fee.Cmp(big.NewInt(int64(expectedFee))) != 0 {
+ 				t.Errorf(""rollup fee check failed: expected %d, got %s"", expectedFee, fee.String())
+ 			}",Should this use the constants as well? Or intentionally covering the fact that the constants may change,The<e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78><e78>
+1565,"@@ -58,7 +58,10 @@ class TopNContainer(object):
+     return self.extras
+
+   def __len__(self):
+-    return self._size
++    if self._size >= 0:
++      return self._size
++    else:
++      return len(self.best)
+
+   def __getitem__(self, which):
+     return self.best[which], self.extras[which]",The case of a negative size (= keep all elements) was not handled in this function.,Can you explain why this change is needed?
+1566,"@@ -70,13 +70,13 @@ var keys = map[Key]string{
+ 	EnableNamespaceNotActiveAutoForwarding: ""system.enableNamespaceNotActiveAutoForwarding"",
+ 	TransactionSizeLimit:                   ""system.transactionSizeLimit"",
+ 	MinRetentionDays:                       ""system.minRetentionDays"",
+-	MaxWorkflowTaskTimeout:                 ""system.maxWorkflowTaskTimeout"",
+ 	DisallowQuery:                          ""system.disallowQuery"",
+ 	EnableBatcher:                          ""worker.enableBatcher"",
+ 	EnableParentClosePolicyWorker:          ""system.enableParentClosePolicyWorker"",
+ 	EnableStickyQuery:                      ""system.enableStickyQuery"",
+ 	EnablePriorityTaskProcessor:            ""system.enablePriorityTaskProcessor"",
+ 	EnableAuthorization:                    ""system.enableAuthorization"",
++	EnableInfiniteTimeout:                  ""system.enableInfiniteTimeout"",
+
+ 	// size limit
+ 	BlobSizeLimitError:     ""limit.blobSize.error"",",I think we should keep this dynamic config knob for operations purpose.,does this mean we no longer enable the system property for maxWorkflowTaskTimeout?
+1567,"@@ -60,7 +60,6 @@ class TestCharacterOffsets(unittest.TestCase):
+ 		obj = BasicTextProvider(text=u""\U0001f926\U0001f60a\U0001f44d"") # 🤦😊👍
+ 		ti = obj.makeTextInfo(Offsets(5, 5))
+ 		ti.expand(textInfos.UNIT_CHARACTER) # Range at 👍
+-		self.assertEqual(ti.offsets, (4, 6)) # Two offsets
+ 		ti.move(textInfos.UNIT_CHARACTER, -1)
+ 		ti.expand(textInfos.UNIT_CHARACTER) # Range at 😊
+ 		self.assertEqual(ti.offsets, (2, 4)) # Two offsets",Was this intentional? Perhaps this could be replaced with another way to check the offsets?,Why was this removed?
+1568,"@@ -86,6 +86,7 @@ type PipelineManifest struct {
+ 	Version PipelineSchemaMajorVersion `yaml:""version""`
+ 	Source  *Source                    `yaml:""source""`
+ 	Stages  []PipelineStage            `yaml:""stages""`
++	// ArtifactBuckets?
+ }
+
+ // Source defines the source of the artifacts to be built and deployed.","the buckets are created via the stackset, customers don't need to provide them",Maybe we should rename `stage` to `artifacts` for clarity.
+1569,"@@ -25,7 +25,7 @@ module Blacklight
+     # Execute a search query against solr
+     # @param [Hash] solr query parameters
+     def search params = {}
+-      send_and_receive blacklight_config.solr_path, { qt: blacklight_config.qt }.merge(params)
++      send_and_receive blacklight_config.solr_path, params.merge({ qt: blacklight_config.qt })
+     end
+
+     ##",This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`),Space inside { missing.<br>Space inside } missing.
+1570,"@@ -6,6 +6,7 @@ module Travis
+
+         def setup
+           super
++          cmd ""export PATH=/usr/local/ghc/#{ghc_version}/bin/:$PATH""
+           cmd 'cabal update', fold: 'cabal', retry: true
+         end
+ ","This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think.",I think you can do `export PATH=/usr/local/ghc/#{ghc_versi
+1571,"@@ -374,7 +374,7 @@ define([""appSettings"", ""browser"", ""events"", ""htmlMediaHelper""], function (appSet
+             return -1 !== supportedFeatures.indexOf(command.toLowerCase());
+         },
+         preferVisualCards: browser.android || browser.chrome,
+-        moreIcon: browser.android ? ""dots-vert"" : ""dots-horiz"",
++        moreIcon: browser.android ? ""more_vert"" : ""more_horiz"",
+         getSyncProfile: getSyncProfile,
+         getDefaultLayout: function () {
+             if (window.NativeShell) {",We should deprecate this at some point.,can you change to `moreIcon` everywhere
+1572,"@@ -49,7 +49,9 @@ class FCOSHead(nn.Module):
+                      use_sigmoid=True,
+                      loss_weight=1.0),
+                  conv_cfg=None,
+-                 norm_cfg=dict(type='GN', num_groups=32, requires_grad=True)):
++                 norm_cfg=dict(type='GN', num_groups=32, requires_grad=True),
++                 center_sampling=False,
++                 center_sample_radius=1.5):
+         super(FCOSHead, self).__init__()
+
+         self.num_classes = num_classes",Move these two arguments before `loss_cls`.,Please make sure the default value compatible with older versions
+1573,"@@ -93,10 +93,16 @@ func GenerateSelfSignedX509CA(commonName string, extUsage []x509.ExtKeyUsage, ke
+ }
+
+ // GenerateServerX509UsingCA generates a TLS serverCert that is self-signed
+-func GenerateServerX509UsingCA(commonName string, ca *tls.Certificate) (*tls.Certificate, *rsa.PrivateKey, error) {
++func GenerateServerX509UsingCAAndSerialNumber(commonName string, serialNumber int64, ca *tls.Certificate) (*tls.Certificate, *rsa.PrivateKey, error) {
+ 	now := time.Now().UTC()
+
+-	i := mathrand.Int63n(100000000000000000)
++	var i int64
++	if serialNumber == 0 {
++		i = mathrand.Int63n(100000000000000000)
++	} else {
++		i = serialNumber
++	}
++
+ 	template := &x509.Certificate{
+ 		SerialNumber: big.NewInt(i),
+ 		Subject: pkix.Name{",[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) },nit: can we call this `generateServerX509UsingCA` or `generateSer
+1574,"@@ -14,8 +14,8 @@ namespace Microsoft.CodeAnalysis.Sarif.ConvertToSarif
+         public string InputFilePath { get; internal set; }
+
+         [Option(
+-            'f',
+-            ""format"",
++            't',
++            ""tool"",
+             HelpText = ""The tool format of the input file."")]
+         public ToolFormat ToolFormat { get; internal set; }
+ ",-f short form here collided with --force. :),nit: `tool` -> `tool format`
+1575,"@@ -12,6 +12,5 @@ describe('preact', () => {
+ 		expect(cloneElement).to.be.a('function');
+ 		expect(createContext).to.be.a('function');
+ 		expect(options).to.exist.and.be.an('object');
+-		// expect(rerender).to.be.a('function');
+ 	});
+ });",I think it is better to describe in the release note that `rerender()` was removed.,Can we just revert this change now that we are here?
+1576,"@@ -3,5 +3,5 @@ VERSION = ""."".join(str(i) for i in IVERSION)
+ PATHOD = ""pathod "" + VERSION
+ MITMPROXY = ""mitmproxy "" + VERSION
+
+-if __name__ == ""__main__"":
++if __name__ == ""__main__"":  # pragma: no cover
+     print(VERSION)","We could also test this easily with `runpy.run_module`, what do you think?",Let's add a TODO to remove this once we have the full cover.
+1577,"@@ -388,8 +388,10 @@ func decode(v reflect.Value, d Decoder) error {
+ 		if err != nil {
+ 			return err
+ 		}
+-		v.Set(reflect.ValueOf(val))
+-		return nil
++		if v.Type().AssignableTo(reflect.TypeOf(val)) {
++			v.Set(reflect.ValueOf(val))
++			return nil
++		}
+ 	}
+
+ 	// Handle implemented interfaces first.","Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice.","This feels a little hacky to me, but I don't think it's a go"
+1578,"@@ -133,7 +133,8 @@ func runAPIAndWait(ctx context.Context, nd *node.Node, config *config.Config, re
+ 		ctx:          context.Background(),
+ 		api:          api,
+ 		porcelainAPI: nd.PorcelainAPI,
+-		blockpAPI:    nd.BlockAPI,
++		blockAPI:     nd.BlockAPI,
++		retrievalAPI: nd.RetrievalAPI,
+ 	}
+
+ 	cfg := cmdhttp.NewServerConfig()",I know this is after the fact but imo blockAPI should be blockMiningAPI.,why not `nd.BlockAPI`?
+1579,"@@ -13,7 +13,11 @@ use Ergonode\SharedKernel\Domain\AbstractCode;
+
+ class AttributeCode extends AbstractCode
+ {
+-    public const PATTERN = '/^([a-zA-Z0-9_]+)$/';
++    public const NOT_SYSTEM_ATTRIBUTE_PATTERN = '/^(?!'.self::SYSTEM_ATTRIBUTE_PREFIX.')[a-zA-Z0-9_]+$/';
++
++    public const SYSTEM_ATTRIBUTE_PATTERN = '/^'.self::SYSTEM_ATTRIBUTE_PREFIX.'[a-zA-Z0-9_]+$/';
++
++    public const SYSTEM_ATTRIBUTE_PREFIX = 'esa_';
+
+     public function __construct(string $value)
+     {",it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it,"Same as above, could use `self::NOT_SYSTEM_ATTRIBUTE_PREFIX`"
+1580,"@@ -0,0 +1,17 @@
++/* Copyright (c) 2019 vesoft inc. All rights reserved.
++ *
++ * This source code is licensed under Apache 2.0 License,
++ * attached with Common Clause Condition 1.0, found in the LICENSES directory.
++ */
++
++#include ""LookUpEdgeIndexProcessor.h""
++
++namespace nebula {
++namespace storage {
++
++void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
++    UNUSED(req);
++}
++}  // namespace storage
++}  // namespace nebula
++","Similar to the code block when we use prefix, maybe we can unify them to base?",Move it to cpp1.
+1581,"@@ -100,6 +100,15 @@ func (in *PodChaos) ValidateScheduler(spec *field.Path) field.ErrorList {
+ 			allErrs = append(allErrs, err...)
+ 		}
+ 		break
++	case PodNotReadyAction:
++		// We choose to ignore the Duration property even user define it
++		if in.Spec.Scheduler == nil {
++			allErrs = append(allErrs, field.Invalid(schedulerField, in.Spec.Scheduler, ValidatePodchaosSchedulerError))
++		} else {
++			_, err := ParseCron(in.Spec.Scheduler.Cron, schedulerField.Child(""cron""))
++			allErrs = append(allErrs, err...)
++		}
++		break
+ 	default:
+ 		err := fmt.Errorf(""podchaos[%s/%s] have unknown action type"", in.Namespace, in.Name)
+ 		log.Error(err, ""Wrong PodChaos Action type"")",I think `Duration` is useful for this action and we shouldn't ignore it.,@smarterclayton
+1582,"@@ -243,13 +243,10 @@ func (s *stream) Write(p []byte) (int, error) {
+ 		s.mutex.Lock()
+ 	}
+
+-	if err != nil {
+-		return 0, err
+-	}
+ 	if s.err != nil {
+-		return len(p) - len(s.dataForWriting), s.err
++		err = s.err
+ 	}
+-	return len(p), nil
++	return len(p) - len(s.dataForWriting), err
+ }
+
+ func (s *stream) GetWriteOffset() protocol.ByteCount {","Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`.",Why remove the c
+1583,"@@ -84,6 +84,12 @@ namespace Impl {
+ HIPLockArrays g_host_hip_lock_arrays = {nullptr, nullptr, 0};
+
+ void initialize_host_hip_lock_arrays() {
++#ifdef KOKKOS_ENABLE_IMPL_DESUL_ATOMICS
++  desul::Impl::init_lock_arrays();
++
++  DESUL_ENSURE_HIP_LOCK_ARRAYS_ON_DEVICE();
++#endif
++
+   if (g_host_hip_lock_arrays.atomic != nullptr) return;
+   HIP_SAFE_CALL(hipMalloc(
+       &g_host_hip_lock_arrays.atomic,","Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?",Why not just cal
+1584,"@@ -69,12 +69,13 @@ class ImportSimpleProductCommandHandler
+             );
+
+             if (!empty($attributesToRedispatch)) {
+-                $this->commandBus->dispatch(new ImportProductAttributesValueCommand(
++                $ImportProductAttributesValueCommand = new ImportProductAttributesValueCommand(
+                     $command->getId(),
+                     $command->getImportId(),
+                     $attributesToRedispatch,
+                     $command->getSku()
+-                ));
++                );
++                $this->commandBus->dispatch($ImportProductAttributesValueCommand, true);
+             }
+             $this->repository->markLineAsSuccess($command->getId(), $product->getId());
+         } catch (ImportException $exception) {",Variable name should start from lowercase latter,I don't think this is the right place to add a new command. This kind of change is not related to this PR but IMO it is a good idea to move it into a separate PR.
+1585,"@@ -47,12 +47,12 @@ import (
+ // certificate, ca, and private key is stored into the target Secret to
+ // complete Issuing the Certificate.
+ func TestIssuingController(t *testing.T) {
+-	config, stopFn := framework.RunControlPlane(t)
+-	defer stopFn()
+-
+-	ctx, cancel := context.WithTimeout(context.Background(), time.Second*20)
++	ctx, cancel := context.WithTimeout(context.Background(), time.Second*40)
+ 	defer cancel()
+
++	config, stopFn := framework.RunControlPlane(t, ctx)
++	defer stopFn()
++
+ 	// Build, instantiate and run the issuing controller.
+ 	kubeClient, factory, cmCl, cmFactory := framework.NewClients(t, config)
+ 	controllerOptions := controllerpkg.CertificateOptions{",Why has this timeout doubled?,we should make the timeout configurable.
+1586,"@@ -113,7 +113,7 @@ type Config struct {
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;30""`
+ 	IptablesLockFilePath               string        `config:""file;/run/xtables.lock""`
+-	IptablesLockTimeoutSecs            time.Duration `config:""seconds;30""`
++	IptablesLockTimeoutSecs            time.Duration `config:""seconds;0""`
+ 	IptablesLockProbeIntervalMillis    time.Duration `config:""millis;50""`
+ 	IpsetsRefreshInterval              time.Duration `config:""seconds;10""`
+ 	MaxIpsetSize                       int           `config:""int;1048576;non-zero""`","Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?",Is this change intended?
+1587,"@@ -335,6 +335,13 @@ class WebEngineCaret(browsertab.AbstractCaret):
+         """"""
+         if js_elem is None:
+             return
++        if js_elem == ""focused"":
++            # we had a focused element, not a selected one. Just send <enter>
++            if tab:
++                self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)
++            else:
++                self._tab.key_press(Qt.Key_Enter)
++
+         assert isinstance(js_elem, dict), js_elem
+         elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)
+         if tab:","You're missing a `return` here, but I'll add it :smile:","Shouldn't we only do this if `js_elem == ""focused""`?"
+1588,"@@ -116,7 +116,7 @@ static bool gles2_render_texture_with_matrix(struct wlr_renderer *wlr_renderer,
+ 	struct wlr_gles2_renderer *renderer =
+ 		gles2_get_renderer_in_context(wlr_renderer);
+ 	struct wlr_gles2_texture *texture =
+-		get_gles2_texture_in_context(wlr_texture);
++		gles2_get_texture(wlr_texture);
+
+ 	struct wlr_gles2_tex_shader *shader = NULL;
+ 	GLenum target = 0;",Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer.,How come you removed `get_gles2_texture_in_context`?
+1589,"@@ -234,7 +234,8 @@ class RouteFactory(object):
+         required_permission = self.method_permissions.get(method)
+
+         # For create permission, the object id is the plural endpoint.
+-        collection_path = service.collection_path.format(**request.matchdict)
++        plural_endpoint = service.collection_path.decode('utf-8')
++        collection_path = plural_endpoint.format(**request.matchdict)
+
+         # In the case of a ""PUT"", check if the targetted record already
+         # exists, return ""write"" if it does, ""create"" otherwise.",This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils.,Could you explain what's happening here? Does the pl
+1590,"@@ -28,6 +28,8 @@ module Mongoid
+           raise Errors::InvalidDiscriminatorKeyTarget.new(self, self.superclass)
+         end
+
++        self._clear_types if self.respond_to?(:_clear_types)
++
+         if value
+           Mongoid::Fields::Validators::Macro.validate_field_name(self, value)
+           value = value.to_s",Why is the respond_to check here?,"I don't think we can safely call `super` here, since"
+1591,"@@ -229,7 +229,7 @@ class FunctionDocblockManipulator
+                 continue;
+             }
+
+-            if ($chars[$i] === '\\' || preg_match('/\w/', $char)) {
++            if ($char === '\\' || preg_match('/\w/', $char)) {
+                 if ($this->return_typehint_start === null) {
+                     $this->return_typehint_start = $i + $end_bracket_position + 1;
+                 }","@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment.",Please rename `$char` to `$char` for consistency.
+1592,"@@ -22,7 +22,7 @@ TEST(DeleteVertexTest, SimpleTest) {
+     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
+     // Add vertices
+     {
+-        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr);
++        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr);
+         cpp2::AddVerticesRequest req;
+         req.space_id = 0;
+         req.overwritable = false;",I have a question? How do I construct a indexManager for testcase?,Shouldn't nullptr be the default argument?
+1593,"@@ -73,6 +73,9 @@ int __FPGA_API__ opae_plugin_configure(opae_api_adapter_table *adapter,
+ {
+ 	UNUSED_PARAM(jsonConfig);
+
++	if (adapter == NULL || adapter->plugin.dl_handle == NULL)
++		return -1;
++
+ 	adapter->fpgaOpen = dlsym(adapter->plugin.dl_handle, ""xfpga_fpgaOpen"");
+ 	adapter->fpgaClose =
+ 		dlsym(adapter->plugin.dl_handle, ""xfpga_fpgaClose"");",These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( ).,Can we return 0 here instead?
+1594,"@@ -554,15 +554,14 @@ class SearchRequest
+
+     /**
+      * Method to check if the query string is an empty string
+-     * (also empty string or whitespaces only are handled as empty).
++     * (also whitespaces only are handled as empty).
+      *
+      * When no query string is set (null) the method returns false.
+      * @return bool
+      */
+     public function getRawUserQueryIsEmptyString()
+     {
+-        $path = $this->prefixWithNamespace('q');
+-        $query = $this->argumentsAccessor->get($path, null);
++        $query = $this->getRawUserQuery();
+
+         if ($query === null) {
+             return false;",Please take a care about prefixing.,you should remove the `string` typehint in
+1595,"@@ -70,6 +70,17 @@ public interface WorldUpdater extends MutableWorldView {
+     return account == null ? createAccount(address) : account;
+   }
+
++  /**
++   * Retrieves the provided account for a sender of a transaction if it exists, or creates it if it
++   * doesn't.
++   *
++   * @param address the address of the account.
++   * @return the account {@code address}, or {@code null} if the account does not exist.
++   */
++  default EvmAccount getOrCreateSenderAccount(final Address address) {
++    return getOrCreate(address);
++  }
++
+   /**
+    * Retrieves the provided account, returning a modifiable object (whose updates are accumulated by
+    * this updater).",this line doesn't match what the rest says,What do you think about moving this method
+1596,"@@ -1,4 +1,4 @@
+-// +build !linux linux,android
++// +build windows linux,android
+
+ /*
+  * Copyright (C) 2017 The ""MysteriumNetwork/node"" Authors.","Since it's not working for linux, maybe leave the !linux in there as well?",Are we sure we want to make this change?
+1597,"@@ -60,6 +60,9 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) error {
+
+ 	// Copy Sources up to parent resolving relative paths as we go.
+ 	for k, v := range i.w.Sources {
++		if v == """" {
++			continue
++		}
+ 		if _, ok := s.w.Sources[k]; ok {
+ 			return fmt.Errorf(""source %q already exists in workflow"", k)
+ 		}","Should we remove the key-value pair entirely? Same for workflows in general. We have a ""sourceExists"" method that checks if a key is there if I remember correctly.",This seems dangerous to me. Why would yo
+1598,"@@ -96,7 +96,7 @@ public class ContentSoqlSyncDownTarget extends SoqlSyncDownTarget {
+
+     @Override
+     public JSONArray startFetch(SyncManager syncManager, long maxTimeStamp) throws IOException, JSONException {
+-        String queryToRun = maxTimeStamp > 0 ? SoqlSyncDownTarget.addFilterForReSync(getQuery(), maxTimeStamp) : getQuery();
++        String queryToRun = maxTimeStamp > 0 ? SoqlSyncDownTarget.addFilterForReSync(getQuery(), getModificationDateFieldName(), maxTimeStamp) : getQuery();
+         syncManager.getRestClient().sendSync(RestRequest.getRequestForResources(syncManager.apiVersion)); // cheap call to refresh session
+         RestRequest request = buildQueryRequest(syncManager.getRestClient().getAuthToken(), queryToRun);
+         RestResponse response = syncManager.sendSyncWithSmartSyncUserAgent(request);",Unrelated bug fix,`getModificationDateFieldName()` is not
+1599,"@@ -173,15 +173,15 @@ define(['serverNotifications', 'playbackManager', 'events', 'globalize', 'requir
+             };
+
+             if (status === 'completed') {
+-                notification.title = globalize.translate('PackageInstallCompleted').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallCompleted', installation.Name + ' ' + installation.Version);
+                 notification.vibrate = true;
+             } else if (status === 'cancelled') {
+-                notification.title = globalize.translate('PackageInstallCancelled').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallCancelled', installation.Name + ' ' + installation.Version);
+             } else if (status === 'failed') {
+-                notification.title = globalize.translate('PackageInstallFailed').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallFailed', installation.Name + ' ' + installation.Version);
+                 notification.vibrate = true;
+             } else if (status === 'progress') {
+-                notification.title = globalize.translate('InstallingPackage').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('InstallingPackage', installation.Name + ' ' + installation.Version);
+
+                 notification.actions =
+                 [",We probably want to let the translation library handle the string replacement for these as well.,shouldn't this one be: `install.Name + '
+1600,"@@ -272,8 +272,7 @@ func newAdminMembershipCommands() []cli.Command {
+ 		{
+ 			Name:  ""list_db"",
+ 			Usage: ""List cluster membership items"",
+-			Flags: append(
+-				getDBFlags(),
++			Flags: []cli.Flag{
+ 				cli.StringFlag{
+ 					Name:  FlagHeartbeatedWithin,
+ 					Value: ""15m"",","should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any.",Do we need to remove `getDBFlags`?
+1601,"@@ -21,6 +21,11 @@ class ProposalPolicy
+     !@proposal.approved?
+   end
+
++  def approve_reject?
++    actionable_approvers = @proposal.currently_awaiting_approvers
++    actionable_approvers.include? @user
++  end
++
+   def edit?
+     self.test_all(:edit?)
+   end",What do you think about prefixing the Policy method names with `can_`?,Use 2 (not 3) spaces for indentati
+1602,"@@ -29,11 +29,10 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+
+-/* HTTP Credentials Endpoints have a standard set of JSON Keys */
+-#define AWS_HTTP_RESPONSE_ACCESS_KEY   ""AccessKeyId""
+-#define AWS_HTTP_RESPONSE_SECRET_KEY   ""SecretAccessKey""
+-#define AWS_HTTP_RESPONSE_TOKEN        ""Token""
+-#define AWS_HTTP_RESPONSE_EXPIRATION   ""Expiration""
++#define AWS_CREDENTIAL_RESPONSE_ACCESS_KEY   ""AccessKeyId""
++#define AWS_CREDENTIAL_RESPONSE_SECRET_KEY   ""SecretAccessKey""
++#define AWS_HTTP_RESPONSE_TOKEN              ""Token""
++#define AWS_CREDENTIAL_RESPONSE_EXPIRATION   ""Expiration""
+
+ #define ECS_CREDENTIALS_HOST           ""169.254.170.2""
+ #define ECS_CREDENTIALS_HOST_LEN       13","Based on the docs, credential process can return a key `SessionToken`",Does this need to be changed in th
+1603,"@@ -9,8 +9,12 @@ export default Ember.Mixin.create({
+
+     if (birthDate) {
+       if (birthDate.getFullYear === undefined) {
+-        birthDate = moment(birthDate, 'l').toDate();
++        birthDate = moment(birthDate, 'LLL').toDate();
+       }
++
++      birthDate.setHours(0, 0, 0, 0);
++      today.setHours(0, 0, 0, 0);
++
+       if (birthDate.getFullYear !== undefined) {
+         years = today.getFullYear() - birthDate.getFullYear();
+         if (today.getMonth() < birthDate.getMonth()",I think this if should be removed (see issue),Shouldn't this be `today.setHours(
+1604,"@@ -19,6 +19,7 @@ import (
+
+ 	log ""github.com/sirupsen/logrus""
+
++	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/libcalico-go/lib/set""
+ )
+ ",I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build.,Group this with the other projectcalico imports.
+1605,"@@ -19,6 +19,7 @@
+ # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+
+ """"""Generate the html documentation based on the asciidoc files.""""""
++from typing import List, Tuple
+
+ import re
+ import os","nitpick: Please move this down to the other imports, as it's a Python stdlib import.",Are these imports used here?
+1606,"@@ -13,7 +13,8 @@
+ // limitations under the License.
+
+ // Package blob provides an easy and portable way to interact with blobs
+-// within a storage location, hereafter called a ""bucket"".
++// within a storage location, hereafter called a ""bucket"". See
++// https://gocloud.dev/howto/blob/ for getting started guides.
+ //
+ // It supports operations like reading and writing blobs (using standard
+ // interfaces from the io package), deleting blobs, and listing blobs in a","""for getting started guides"" reads a bit weird, like it's missing punctuation. Maybe just ""for a tutorial""?",For more information on what guides this refers
+1607,"@@ -50,9 +50,9 @@ class Formats extends AbstractBase
+      * Constructor
+      *
+      * @param bool $enabled is this tab enabled?
+-     * @param bool $urc     use recaptcha?
++     * @param bool $uc     use captcha?
+      */
+-    public function __construct($enabled = true, $urc = false)
++    public function __construct($enabled = true, $uc = false)
+     {
+         $this->enabled = $enabled;
+     }","This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here.",not sure why this was changed in the first place
+1608,"@@ -42,7 +42,11 @@ func (m *VerticaRowReader) GetNextRow() ([]values.Value, error) {
+ 	row := make([]values.Value, len(m.columns))
+ 	for i, col := range m.columns {
+ 		switch col := col.(type) {
+-		case bool, int, uint, int64, uint64, float64, string:
++		case int:
++			row[i] = values.NewInt(int64(col))
++		case uint:
++			row[i] = values.NewUInt(uint64(col))
++		case bool, int64, uint64, float64, string:
+ 			row[i] = values.New(col)
+ 		case time.Time:
+ 			row[i] = values.NewTime(values.ConvertTime(col))","Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is.","Should we make this a `map[string]interface{}` for column indexes, so we don't have to introduce a new type?"
+1609,"@@ -14,7 +14,7 @@ import net.sourceforge.pmd.RuleViolation;
+ /**
+  * A {@link RuleViolation} implementation that is immutable, and therefore cache friendly
+  */
+-public final class CachedRuleViolation implements RuleViolation {
++public class CachedRuleViolation implements RuleViolation {
+
+     private final CachedRuleMapper mapper;
+ ","if you are not dealing with cache now, please revert these changes. On their own they make little sense",Why did you remove the final modifier?
+1610,"@@ -56,7 +56,7 @@ public abstract class NodeGenerator extends Generator {
+                     throw new AssertionError(f(""Wanted to regenerate a method with signature %s in %s, but it wasn't there."", callable.getSignature(), containingClassOrInterface.getNameAsString()));
+                 });
+     }
+-
++
+     private void addMethod(
+             ClassOrInterfaceDeclaration containingClassOrInterface,
+             CallableDeclaration<?> callable,",Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it.,unnecessary empty line
+1611,"@@ -0,0 +1,7 @@
++package de.danoeh.antennapod.core.event;
++
++public class ShowRemainTimeUpdateEvent {
++    public ShowRemainTimeUpdateEvent() {
++
++    }
++}","I think it would be better to use an `ItemUpdatedEvent` like for the ""prefer streaming"" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future.",please add a license header like other files
+1612,"@@ -0,0 +1,17 @@
++class AddSlugToProducts < ActiveRecord::Migration
++  def change
++    add_column :products, :slug, :string, null: true
++
++    products = select_all(""select id, name from products"")
++    products.each do |product|
++      update(<<-SQL)
++        UPDATE products
++          SET slug='#{product[""name""].parameterize}'
++          WHERE id=#{product[""id""]}
++      SQL
++    end
++
++    change_column_null :products, :slug, false
++    add_index :products, :slug, unique: true
++  end
++end",I think we have to manually write a down for this migration.,Wouldn't it be better to put this in the `products` table?
+1613,"@@ -454,14 +454,13 @@ class _InternalFrame(object):
+         assert isinstance(sdf, spark.DataFrame)
+
+         if index_map is None:
+-            # Here is when Koalas DataFrame is created directly from Spark DataFrame.
+-            assert not any(SPARK_INDEX_NAME_PATTERN.match(name) for name in sdf.schema.names), \
++            assert not any(SPARK_INDEX_NAME_PATTERN.match(name) for name in sdf.columns), \
+                 ""Index columns should not appear in columns of the Spark DataFrame. Avoid "" \
+-                ""index colum names [%s]."" % SPARK_INDEX_NAME_PATTERN
++                ""index column names [%s]."" % SPARK_INDEX_NAME_PATTERN
+
+             # Create default index.
+-            index_map = [(SPARK_INDEX_NAME_FORMAT(0), None)]
+-            sdf = _InternalFrame.attach_default_index(sdf)
++            sdf, index_column = _InternalFrame.attach_default_index(sdf)
++            index_map = [(index_column, None)]
+
+         if NATURAL_ORDER_COLUMN_NAME not in sdf.columns:
+             sdf = sdf.withColumn(NATURAL_ORDER_COLUMN_NAME, F.monotonically_increasing_id())","I don't think we still need this check, but I'd leave it as an assertion for now.",It seems that we don't need this assert anymore now?
+1614,"@@ -203,4 +203,9 @@ class Cart < ActiveRecord::Base
+       0.0
+     end
+   end
++
++  # may be replaced with paper-trail or similar at some point
++  def version
++    self.updated_at.to_i
++  end
+ end","Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?",Redundant `self` detected.
+1615,"@@ -215,6 +215,10 @@ namespace ScenarioMeasurement
+                 }
+                 TraceEventSession.Merge(files.ToArray(), traceFileName);
+
++                if (guiApp)
++                {
++                    appExe = Path.Join(workingDir, appExe);
++                }
+                 string commandLine = $""\""{appExe}\"""";
+                 if (!String.IsNullOrEmpty(appArgs))
+                 {",wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is,I think this should only be done if `appExe != null && !St
+1616,"@@ -329,8 +329,14 @@ public class ConfigCenterClient {
+
+     public void refreshConfig(String configcenter, boolean wait) {
+       CountDownLatch latch = new CountDownLatch(1);
++      String encodeServiceName = """";
++      try {
++        encodeServiceName = URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), ""UTF-8"");
++      } catch (UnsupportedEncodingException e) {
++        LOGGER.error(""encode error: {}"",e.getMessage());
++      }
++      String path = URIConst.ITEMS + ""?dimensionsInfo="" + encodeServiceName;
+       clientMgr.findThreadBindClientPool().runOnContext(client -> {
+-        String path = URIConst.ITEMS + ""?dimensionsInfo="" + StringUtils.deleteWhitespace(serviceName);
+         IpPort ipPort = NetUtils.parseIpPortFromURI(configcenter);
+         HttpClientRequest request = client.get(ipPort.getPort(), ipPort.getHostOrIp(), path, rsp -> {
+           if (rsp.statusCode() == HttpResponseStatus.OK.code()) {","1.not format code 2.failed but still continue? 3.""UTF-8"" can changed to java.nio.charset.StandardCharsets.UTF_8.name()",do we need to try/catch here?
+1617,"@@ -74,6 +74,7 @@ from typing import Any, Callable, Iterator, List, Optional, Pattern, Tuple
+ import astroid
+ import astroid.exceptions
+ from astroid import bases, nodes
++from astroid.brain import brain_dataclasses
+
+ from pylint.checkers import BaseChecker, utils
+ from pylint.checkers.utils import (","I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?",This won't work if you import
+1618,"@@ -54,6 +54,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Http
+
+                     InitializeHeaders();
+
++                    if (_corruptedRequest)
++                    {
++                        await ProduceEnd();
++                        return;
++                    }
++
+                     while (!_requestProcessingStopping && !TakeMessageHeaders(SocketInput, FrameRequestHeaders))
+                     {
+                         if (SocketInput.RemoteIntakeFin)",This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic.,Are we already calling ` Prod
+1619,"@@ -292,7 +292,7 @@ class _RunData(object):
+         direct_access_sources = set()
+         for backend in backend_service.backends:
+             instance_group = self.find_instance_group_by_url(
+-                backend.get('group'))
++                backend.get('resourceGroup'))
+             if not instance_group:
+                 continue
+ ","Please make the change in the CAI inventory, rather than changing the scanner.",Is this a bug fix?
+1620,"@@ -6,7 +6,7 @@ package net.sourceforge.pmd.lang.jsp.ast;
+
+ import net.sourceforge.pmd.lang.ast.AbstractNode;
+
+-public class AbstractJspNode extends AbstractNode implements JspNode {
++public abstract class AbstractJspNode extends AbstractNode implements JspNode {
+
+     protected JspParser parser;
+ ","adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0","Not sure why these classes are `AbstractNode`, `AbstractJspNode` and `JspParser` are `AbstractNode`."
+1621,"@@ -16,6 +16,7 @@ describe IndividualPlan do
+
+   it_behaves_like 'a Plan with countable subscriptions'
+   it_behaves_like 'a Plan for public listing'
++  it_behaves_like 'Purchaseable plan'
+
+   describe '.active' do
+     it 'only includes active plans' do","This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind.","How about ""a Plan for public listing"" instead?"
+1622,"@@ -304,14 +304,15 @@ size_t network_prefix)
+ bool nano::server_socket::limit_reached_for_incoming_subnetwork_connections (std::shared_ptr<nano::socket> const & new_connection)
+ {
+ 	debug_assert (strand.running_in_this_thread ());
+-	if (node.flags.disable_max_peers_per_subnetwork)
++	if (node.flags.disable_max_peers_per_subnetwork || nano::transport::is_ipv4_or_v4_mapped_address (new_connection->remote.address ()))
+ 	{
+ 		// If the limit is disabled, then it is unreachable.
++		// If the address is IPv4 we don't check for a network limit, since its address space isn't big as IPv6 /64.
+ 		return false;
+ 	}
+ 	auto const counted_connections = socket_functions::count_subnetwork_connections (
+ 	connections_per_address,
+-	nano::transport::mapped_from_v4_or_v6 (new_connection->remote.address ()),
++	new_connection->remote.address ().to_v6 (),
+ 	node.network_params.network.ipv6_subnetwork_prefix_for_limiting);
+ 	return counted_connections >= node.network_params.network.max_peers_per_subnetwork;
+ }",I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped),Shouldn't this be `is_ipv4_or_v6_mapped_address`?
+1623,"@@ -41,7 +41,7 @@ gboolean
+ ot_remote_builtin_delete_cookie (int argc, char **argv, GCancellable *cancellable, GError **error)
+ {
+   g_autoptr(OstreeRepo) repo = NULL;
+-  g_autoptr(GOptionContext) context = g_option_context_new (""NAME DOMAIN PATH COOKIE_NAME- Remote one cookie from remote"");
++  g_autoptr(GOptionContext) context = g_option_context_new (""NAME DOMAIN PATH COOKIE_NAME- Remove one cookie from remote"");
+
+   if (!ostree_option_context_parse (context, option_entries, &argc, &argv,
+                                     OSTREE_BUILTIN_FLAG_NONE, &repo, cancellable, error))",It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree.,"This is not remove, it is just removering the cookie from the server."
+1624,"@@ -29,7 +29,7 @@ import org.openqa.selenium.remote.service.DriverService;
+  *
+  * @see <a href=""https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/client/command_executor.py"">List of ChromeWebdriver commands</a>
+  */
+-class ChromeDriverCommandExecutor extends DriverCommandExecutor {
++public class ChromeDriverCommandExecutor extends DriverCommandExecutor {
+
+   private static final ImmutableMap<String, CommandInfo> CHROME_COMMAND_NAME_TO_URL = ImmutableMap.of(
+       ChromeDriverCommand.LAUNCH_APP,",This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?,Can you explain why this change is needed?
+1625,"@@ -84,7 +84,9 @@ public class CompareObjectsWithEqualsRule extends AbstractJavaRule {
+                 ASTReferenceType type1 = ((Node) nd1.getAccessNodeParent())
+                         .getFirstDescendantOfType(ASTReferenceType.class);
+                 // skip, if it is an enum
+-                if (type0.getType() != null && type0.getType().equals(type1.getType()) && type0.getType().isEnum()) {
++                if (type0.getType() != null && type0.getType().equals(type1.getType())
++                    // It may be a custom enum class or an explicit Enum class usage
++                    && (type0.getType().isEnum() || type0.getType() == java.lang.Enum.class)) {
+                     return data;
+                 }
+ ","it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here.",The first part of the condition is superfl
+1626,"@@ -49,6 +49,15 @@ class QuteSchemeHandler(schemehandler.SchemeHandler):
+
+     """"""Scheme handler for qute: URLs.""""""
+
++    handlers = dict()
++
++    @classmethod
++    def addHandler(cls, name):
++        """"""Add a handler to the qute: sheme.""""""
++        def namedecorator(function):
++            cls.handlers[name] = function
++        return namedecorator
++
+     def createRequest(self, _op, request, _outgoing_data):
+         """"""Create a new request.
+ ",Please use `{}` instead of `dict()`,add a docstring explaining what this does
+1627,"@@ -20,11 +20,12 @@
+  * External dependencies
+  */
+ import PropTypes from 'prop-types';
++import { useInView } from 'react-intersection-observer';
+
+ /**
+  * WordPress dependencies
+  */
+-import { useCallback } from '@wordpress/element';
++import { useCallback, useEffect } from '@wordpress/element';
+ import { __ } from '@wordpress/i18n';
+
+ /**",I have concerns about using this in more places before #3278 - I'll take a look at that again shortly.,Why is this needed?
+1628,"@@ -37,7 +37,16 @@ func TestConvert(t *testing.T) {
+ 	testLog := newTestLog()
+ 	testLog.Topics = topics
+ 	testLog.NotFixTopicCopyBug = true
+-	receipt := &Receipt{1, 1, hash.ZeroHash256, 1, ""test"", []*Log{testLog}, nil, ""balance not enough""}
++	receipt := &Receipt{
++		Status:             1,
++		BlockHeight:        1,
++		ActionHash:         hash.ZeroHash256,
++		GasConsumed:        1,
++		ContractAddress:    ""test"",
++		TxIndex:            1,
++		logs:               []*Log{testLog},
++		executionRevertMsg: ""balance not enough"",
++	}
+
+ 	typeReceipt := receipt.ConvertToReceiptPb()
+ 	require.NotNil(typeReceipt)",new field needs to be asserted,can we have an assertion that the receipt is `nil` at this place?
+1629,"@@ -190,6 +190,7 @@ void Host::appendLogsInternal(folly::EventBase* eb,
+             {
+                 std::lock_guard<std::mutex> g(self->lock_);
+                 self->setResponse(r);
++                self->lastLogIdSent_ = self->logIdToSend_;
+             }
+             self->noMoreRequestCV_.notify_all();
+             return;","when send log failed, why update the last sent log id?",There's no guarantee that `lastLogIdSent_` will be updated after
+1630,"@@ -127,12 +127,12 @@ public final class Tuple0 implements Tuple, Comparable<Tuple0>, Serializable {
+     }
+
+     @Override
+-    public <T> Tuple1<T> prepend(T value) {
++    public <T> Tuple1<T> append(T value) {
+        return new Tuple1<>(value);
+     }
+
+     @Override
+-    public <T> Tuple1<T> append(T value) {
++    public <T> Tuple1<T> prepend(T value) {
+        return new Tuple1<>(value);
+     }
+ ","what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think","Looking at the code in this class, would it be better to have the"
+1631,"@@ -291,6 +291,8 @@ type BackupInfo struct {
+ 	// Timestamp is the timestamp at which the source volume
+ 	// was backed up to cloud
+ 	Timestamp time.Time
++	// Metadata associated with the backup
++	Metadata map[string]string
+ 	// Status indicates if this backup was successful
+ 	Status string
+ }",Why is this necessary? Could you provide some context?,Metadata is part of the backup struct. Not sure if we want to inc
+1632,"@@ -46,7 +46,9 @@ public class HTMLTestResults {
+   private final HTMLSuiteResult suite;
+
+   private static final String HEADER = ""<html>\n"" +
+-      ""<head><style type='text/css'>\n"" +
++      ""<head>\n""+
++      ""<meta charset=\""UTF-8\"">\n""+
++      ""<style type='text/css'>\n"" +
+       ""body, table {\n"" +
+       ""    font-family: Verdana, Arial, sans-serif;\n"" +
+       ""    font-size: 12;\n"" +","Is there a recommended quote style for attributes? I see single and double here, double further down.","This should be `<meta charset=\""UTF-8\"">\n"" +"
+1633,"@@ -772,6 +772,17 @@ var _ = Describe(""Session"", func() {
+ 			Expect(mconn.written[0][0] & 0x02).ToNot(BeZero()) // Public Reset
+ 			Expect(sess.runClosed).To(BeClosed())
+ 		})
++
++		It(""unblocks WaitUntilClosed when the run loop exists"", func() {
++			returned := make(chan struct{})
++			go func() {
++				sess.WaitUntilClosed()
++				close(returned)
++			}()
++			Consistently(returned).ShouldNot(BeClosed())
++			sess.Close(nil)
++			Eventually(returned).Should(BeClosed())
++		})
+ 	})
+
+ 	Context(""receiving packets"", func() {",Please use an atomic bool.,I think you can just `sess.Close()` here and
+1634,"@@ -0,0 +1,19 @@
++namespace Datadog.Trace.ClrProfiler
++{
++    internal static class WebHelpers
++    {
++        public static void DecorateWebSpan(
++            this Span span,
++            string resourceName,
++            string method,
++            string host,
++            string httpUrl)
++        {
++            span.Type = SpanTypes.Web;
++            span.ResourceName = resourceName;
++            span.SetTag(Tags.HttpMethod, method);
++            span.SetTag(Tags.HttpRequestHeadersHost, host);
++            span.SetTag(Tags.HttpUrl, httpUrl);
++        }
++    }
++}",Consider naming this class `SpanExtensions` to follow C# conventions.,You might want to tag tag as `datadog.trace.T
+1635,"@@ -81,11 +81,6 @@ namespace Datadog.Trace.Logging
+             {
+                 // Don't let this exception bubble up as this logger is for debugging and is non-critical
+             }
+-            finally
+-            {
+-                // Log some information to correspond with the app domain
+-                SharedLogger.Information(FrameworkDescription.Create().ToString());
+-            }
+         }
+
+         public static ILogger GetLogger(Type classType)","FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions.",I don't think we should be removing this at a
+1636,"@@ -34,6 +34,8 @@ module Beaker
+           Beaker::Fusion
+         when /blimpy/
+           Beaker::Blimper
++        when /ec2/
++          Beaker::AwsSdk
+         when /vcloud/
+           if options['pooling_api']
+             Beaker::VcloudPooled","Ah, so we are going to need to update node/host files for this to work?",Could you add `when /vcloud/` as well?
+1637,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users.",Did you mean to leave this at info?
+1638,"@@ -11,9 +11,15 @@ class ObservationsController < ApplicationController
+   end
+
+   def destroy
+-    self.observation.destroy
+-    flash[:success] = ""Deleted Observation""
+-    redirect_to proposal_path(self.observation.proposal_id)
++    proposal = observation.proposal
++    if current_user == observation.user
++      redirect_path = ""/proposals""
++    else
++      redirect_path = proposal_path(proposal)
++    end
++    observation.destroy
++    flash[:success] = ""Deleted Observation for #{proposal.public_id}""
++    redirect_to redirect_path
+   end
+
+   protected",used named path (`proposals_path`) instead?,Metrics/LineLength: Line is too long.
+1639,"@@ -107,7 +107,10 @@ class Sierra extends AbstractBase implements TranslatorAwareInterface
+             . ""FROM sierra_view.bib_view ""
+             . ""LEFT JOIN sierra_view.bib_record_item_record_link ON ""
+             . ""(bib_view.id = bib_record_item_record_link.bib_record_id) ""
+-            . ""WHERE bib_view.record_num = $1;"";
++            . ""INNER JOIN sierra_view.item_view ON ""
++            . ""(bib_record_item_record_link.item_record_id = item_view.id ""
++            . ""WHERE bib_view.record_num = $1 ""
++            . ""AND item_view.is_suppressed = false;"";
+         $record_ids = pg_query_params(
+             $this->db, $get_record_ids_query, [$this->idStrip($id)]
+         );","Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!",Shouldn't this be `item_view.is_suppre
+1640,"@@ -256,6 +256,13 @@ func (o *Outbound) call(ctx context.Context, treq *transport.Request) (*transpor
+
+ 	span.SetTag(""http.status_code"", response.StatusCode)
+
++	// Service name match validation, return yarpcerrors.CodeInternal error if not match
++	if match, resSvcName := checkServiceMatch(treq.Service, response.Header); !match {
++		return nil, transport.UpdateSpanWithErr(span,
++			yarpcerrors.InternalErrorf(""service name sent from the request ""+
++				""does not match the service name received in the response, sent %q, got: %q"", treq.Service, resSvcName))
++	}
++
+ 	tres := &transport.Response{
+ 		Headers:          applicationHeaders.FromHTTPHeaders(response.Header, transport.NewHeaders()),
+ 		Body:             response.Body,",Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?,nit: `not match` -> `does not match`
+1641,"@@ -63,6 +63,7 @@ class AzureBlobClient(FileSystem):
+             * `token_credential` - A token credential used to authenticate HTTPS requests. The token value should be updated before its expiration.
+         """"""
+         self.options = {""account_name"": account_name, ""account_key"": account_key, ""sas_token"": sas_token}
++        kwargs[""protocol""] = kwargs.get(""protocol"") or ""https""  # Default protocol to https if it's not set
+         self.kwargs = kwargs
+
+     @property","if using dict.get, this could just be `kwargs.get('protocol', 'https')`",If we set `protocol` in `kwargs` thi
+1642,"@@ -443,6 +443,14 @@ public class SurfaceNamer extends NameFormatterDelegator {
+     return getNotImplementedString(""SurfaceNamer.getAsyncApiMethodExampleName"");
+   }
+
++  public String getGrpcStreamingApiMethodName(Method method) {
++    return getApiMethodName(method);
++  }
++
++  public String getGrpcStreamingApiMethodExampleName(Interface interfaze, Method method) {
++    return getGrpcStreamingApiMethodName(method);
++  }
++
+   /**
+    * The name of a variable to hold a value for the given proto message field
+    * (such as a flattened parameter).",Add docs to the new methods here,interfaze -> interface
+1643,"@@ -28,9 +28,11 @@ namespace Nethermind.Trie.Pruning
+             _memoryLimit = memoryLimit;
+         }
+
++        public bool Enabled => true;
++
+         public bool ShouldPrune(in long currentMemory)
+         {
+             return currentMemory >= _memoryLimit;
+         }
+     }
+-}
++}",what does it mean enabled?,"`Enabled` is confusing, how about `I"
+1644,"@@ -128,7 +128,7 @@ public class SmartStore  {
+     public static synchronized void changeKey(SQLiteDatabase db, String oldKey, String newKey) {
+     	synchronized(db) {
+ 	        if (newKey != null && !newKey.trim().equals("""")) {
+-	            db.execSQL(""PRAGMA rekey = '"" + newKey + ""'"");
++	            db.query(""PRAGMA rekey = '"" + newKey + ""'"");
+ 	            DBOpenHelper.reEncryptAllFiles(db, oldKey, newKey);
+ 	        }
+     	}","Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok).",Why not use `db.query`?
+1645,"@@ -83,11 +83,11 @@ func retrieveFeeds(ctx *middleware.Context, ctxUserID, userID, offset int64, isP
+ }
+
+ func Dashboard(ctx *middleware.Context) {
+-	ctx.Data[""Title""] = ctx.Tr(""dashboard"")
++  ctxUser := getDashboardContextUser(ctx)
++	ctx.Data[""Title""] = ctxUser.DisplayName() + "" "" + ctx.Tr(""dashboard"")
+ 	ctx.Data[""PageIsDashboard""] = true
+ 	ctx.Data[""PageIsNews""] = true
+
+-	ctxUser := getDashboardContextUser(ctx)
+ 	if ctx.Written() {
+ 		return
+ 	}","Maybe we could remove `"" "" + ctx.Tr(""dashboard"")` completely?",Shouldn't this be `ctx.
+1646,"@@ -1,13 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-# SPDX - License - Identifier: Apache - 2.0
++# SPDX-License-Identifier: Apache-2.0
++
++# Purpose
++# This code demonstrates how to copy an object from one Amazon Simple Storage Solution (Amazon S3) bucket to another,
++# changing the object's server-side encryption state during the copy operation.
+
+ # snippet-start:[s3.ruby.copy_object_encrypt_copy.rb]
+ require 'aws-sdk-s3'
+
+-# Copies an object from one Amazon S3 bucket to another,
+-#   changing the object's server-side encryption state during
+-#   the copy operation.
+-#
+ # Prerequisites:
+ #
+ # - A bucket containing an object to be copied.",Simple Storage **Service**,Trailing whitespace det
+1647,"@@ -42,6 +42,15 @@ type jsonHandler struct {
+ 	handler reflect.Value
+ }
+
++type jsonHandler2 struct {
++	handler reflect.Value
++}
++
++func (h jsonHandler2) Handle(ctx context.Context, reqBody interface{}) (interface{}, error) {
++	results := h.handler.Call([]reflect.Value{reflect.ValueOf(ctx), reflect.ValueOf(reqBody)})
++	return results[0].Interface(), results[1].Interface().(error)
++}
++
+ func (h jsonHandler) Handle(ctx context.Context, req *yarpc.Request, reqBuf *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
+ 	if err := yarpcencoding.ExpectEncodings(req, Encoding); err != nil {
+ 		return nil, nil, err",Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error.,I think it would be bet
+1648,"@@ -23,8 +23,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+         // Matches the default LimitRequestFields in Apache httpd.
+         private int _maxRequestHeaderCount = 100;
+
+-        // Matches the default http.sys connection timeout.
+-        private TimeSpan _connectionTimeout = TimeSpan.FromMinutes(2);
++        // Matches the default http.sys connectionTimeout.
++        private TimeSpan _keepAliveTimeout = TimeSpan.FromMinutes(2);
++
++        private TimeSpan _requestHeadersTimeout = TimeSpan.FromSeconds(30);
+
+         /// <summary>
+         /// Gets or sets the maximum size of the response buffer before write",Where did we take this default from?,Should this be in milliseconds? I'm not sure what the units are.
+1649,"@@ -122,6 +122,8 @@ const baseSelectors = {
+ 	 * @param {Object}         options                     Options for generating the report.
+ 	 * @param {string}         options.startDate           Required, unless dateRange is provided. Start date to query report data for as YYYY-mm-dd.
+ 	 * @param {string}         options.endDate             Required, unless dateRange is provided. End date to query report data for as YYYY-mm-dd.
++	 * @param {string}         [options.compareStartDate]  Optional. Start date to compare report data for as YYYY-mm-dd.
++	 * @param {string}         [options.compareEndDate]    Optional. End date to compare report data for as YYYY-mm-dd.
+ 	 * @param {string}         options.dateRange           Required, alternative to startDate and endDate. A date range string such as 'last-28-days'.
+ 	 * @param {boolean}        [options.compareDateRanges] Optional. Only relevant with dateRange. Default false.
+ 	 * @param {boolean}        [options.multiDateRange]    Optional. Only relevant with dateRange. Default false.",Let's move these down to be after all required arguments rather than in between.,I think we should use `options.dateRange` instead of `options.co
+1650,"@@ -90,6 +90,10 @@ namespace FlatBuffers
+             _objectStart = 0;
+             _numVtables = 0;
+             _vectorNumElems = 0;
++            if (_sharedStringMap != null)
++            {
++                _sharedStringMap.Clear();
++            }
+         }
+
+         /// <summary>","Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table.",This null check seems to be redundant with the one above.
+1651,"@@ -107,7 +107,8 @@ func (i *Inbound) start() error {
+ 		return errRouterNotSet
+ 	}
+
+-	handler := newHandler(i)
++	handler := newHandler(i, i.t.options.logger)
++	// handler := &handler{i: i, logger: i.t.options.logger}
+
+ 	server := grpc.NewServer(
+ 		grpc.CustomCodec(customCodec{}),",did you mean to delete this line?,What is the purpose of this line?
+1652,"@@ -420,6 +420,10 @@ public class DatasetField implements Serializable {
+         } else if (template != null) {
+             return template.getDataverse();
+         } else {
++
++            System.out.print(""getDataverseException: "" + this.datasetFieldType.getDisplayName());
++            System.out.print(""getDataverseException Compound: "" + this.getCompoundDisplayValue());
++            System.out.print(""getDataverseException Regular: "" + this.getDisplayValue());
+             throw new IllegalStateException(""DatasetField is in an illegal state: no dataset version, compound value, or template is set as its parent."");
+         }
+     }",Should we use logger instead?,Please remove these System.out statements.
+1653,"@@ -5,7 +5,7 @@ describe AnalyticsHelper do
+     it ""is true when ENV['ANALYTICS'] is present"" do
+       ENV['ANALYTICS'] = 'anything'
+
+-      expect(analytics?).to be_true
++      expect(analytics?).to be true
+
+       ENV['ANALYTICS'] = nil
+     end",I think it would be preferred to do `expect(helper).to be_analytics`,I think this should be `false`
+1654,"@@ -10089,7 +10089,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+
+         if key is None:
+             raise KeyError(""none key"")
+-        if isinstance(key, (str, tuple, list)):
++        if isinstance(key, (str, tuple, list, pd.Index)):
+             return self.loc[:, key]
+         elif isinstance(key, slice):
+             if any(type(n) == int or None for n in [key.start, key.stop]):","Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now.","We need to handle `pd.Index` here as well,"
+1655,"@@ -183,7 +183,7 @@ func (s *resetorSuite) TestResetWorkflowExecution_NoReplication() {
+ 	currRunID := uuid.New().String()
+ 	we := commonpb.WorkflowExecution{
+ 		WorkflowId: wid,
+-		RunId:      forkRunID,
++		RunId:      """",
+ 	}
+ 	request.ResetRequest = &workflowservice.ResetWorkflowExecutionRequest{
+ 		Namespace:                 ""testNamespace"",","If there any other tests, I would make it optional there also.",Was this a bug?
+1656,"@@ -54,6 +54,7 @@ Workshops::Application.routes.draw do
+   end
+
+   match '/watch' => 'high_voltage/pages#show', as: :watch, id: 'watch'
++  match '/my-accounts' => 'high_voltage/pages#show', as: :watch, id: 'my-accounts'
+
+   match '/directions' => ""high_voltage/pages#show"", as: :directions, id: ""directions""
+   match '/group-training' => ""high_voltage/pages#show"", as: :group_training, id: ""group-training""","This can be removed too, right?",Sorry I missed this one. This should be `/my-accounts/show`
+1657,"@@ -248,7 +248,7 @@ public class SettingsExporter {
+
+
+         // Write outgoing server settings
+-        ServerSettings outgoing = Transport.decodeTransportUri(account.getTransportUri());
++        ServerSettings outgoing = Transport.decodeTransportUri(account.getTransportUri(0));
+         serializer.startTag(null, OUTGOING_SERVER_ELEMENT);
+         serializer.attribute(null, TYPE_ATTRIBUTE, outgoing.type);
+ ","If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them.","Same as above, use `Transport.decodeTransportUri(transportU"
+1658,"@@ -28,5 +28,14 @@ namespace Datadog.Trace.RuntimeMetrics
+         public const string CpuUserTime = ""runtime.dotnet.cpu.user"";
+         public const string CpuSystemTime = ""runtime.dotnet.cpu.system"";
+         public const string CpuPercentage = ""runtime.dotnet.cpu.percent"";
++
++        public const string CurrentRequests = ""runtime.dotnet.aspnetcore.requests.current"";
++        public const string FailedRequests = ""runtime.dotnet.aspnetcore.requests.failed"";
++        public const string TotalRequests = ""runtime.dotnet.aspnetcore.requests.total"";
++        public const string RequestQueueLength = ""runtime.dotnet.aspnetcore.requests.queue_length"";
++
++        public const string CurrentConnections = ""runtime.dotnet.aspnetcore.connections.current"";
++        public const string ConnectionQueueLength = ""runtime.dotnet.aspnetcore.connections.queue_length"";
++        public const string TotalConnections = ""runtime.dotnet.aspnetcore.connections.total"";
+     }
+ }",nit: Can we prefix these variables with `AspNetCore`?,These should not be here since they are not being used anyw
+1659,"@@ -47,12 +47,18 @@ describe ""transpiling YAML plans"" do
+   }
+   PLAN
+
+-  it 'transpiles a yaml plan' do
++  it 'transpiles a YAML plan from a path' do
+     expect {
+       run_cli(%W[plan convert #{plan_path}])
+     }.to output(output_plan).to_stdout
+   end
+
++  it 'transpiles a YAML plan from a plan name' do
++    expect {
++      run_cli(%W[plan convert yaml::conversion -m #{modulepath}])
++    }.to output(output_plan).to_stdout
++  end
++
+   it 'plan show output is the same for the original plan and converted plan', ssh: true do
+     Dir.mktmpdir do |tmpdir|
+       FileUtils.mkdir_p(File.join(tmpdir, 'plans'))",Can this also include a quick test for transpiling by name?,Layout/EmptyLinesAroundBlockBody: Extra empty line detected
+1660,"@@ -59,10 +59,11 @@ func (client *clientRest) NodeRegister(proposal dto_discovery.ServiceProposal) (
+ 	return
+ }
+
+-func (client *clientRest) NodeSendStats(nodeKey string, sessionList []dto.SessionStatsDeprecated) (err error) {
++func (client *clientRest) NodeSendStats(nodeKey string) (err error) {
+ 	response, err := client.doPostRequest(""node_send_stats"", dto.NodeStatsRequest{
+-		NodeKey:  nodeKey,
+-		Sessions: sessionList,
++		NodeKey: nodeKey,
++		// TODO: remove this struct in favor of `SessionStats`
++		Sessions: []dto.SessionStats{},
+ 	})
+ 	if err == nil {
+ 		defer response.Body.Close()",This TODO can be removed,Will this struct be removed in the future?
+1661,"@@ -5,13 +5,13 @@ using UIKit;
+
+ namespace MvvmCross.iOS.Support.Presenters
+ {
+-	public interface IMvxTabBarViewController
+-	{
+-		void ShowTabView(UIViewController viewController, bool wrapInNavigationController, string tabTitle, string tabIconName);
++    public interface IMvxTabBarViewController
++    {
++        void ShowTabView(UIViewController viewController, bool wrapInNavigationController, string tabTitle, string tabIconName, string tabAccessibilityIdentifier);
+
+-		bool ShowChildView(UIViewController viewController);
++        bool ShowChildView(UIViewController viewController);
+
+-		bool CloseChildViewModel(IMvxViewModel viewModel);
+-	}
++        bool CloseChildViewModel(IMvxViewModel viewModel);
++    }
+ }
+ ",can we make tabAccessibilityIdentifier = null as default?,please add xml doc for all public methods
+1662,"@@ -80,8 +80,9 @@ func initProvider() func() {
+ 	pusher.Start()
+
+ 	return func() {
+-		bsp.Shutdown() // shutdown the processor
+-		handleErr(exp.Shutdown(context.Background()), ""failed to stop exporter"")
++		ctx := context.Background()
++		_ = bsp.Shutdown(ctx) // shutdown the processor
++		handleErr(exp.Shutdown(ctx), ""failed to stop exporter"")
+ 		pusher.Stop() // pushes any last exports to the receiver
+ 	}
+ }",Should we print this error?,Shouldn't this be _ = bsp.Shutdown(context
+1663,"@@ -31,7 +31,7 @@ def multiclass_nms(multi_bboxes,
+         tuple: (bboxes, labels, indices (optional)), tensors of shape (k, 5),
+             (k), and (k). Labels are 0-based.
+     """"""
+-    num_classes = multi_scores.size(1) - 1
++    num_classes = int(multi_scores.size(1) - 1)
+     # exclude background category
+     if multi_bboxes.shape[1] > 4:
+         bboxes = multi_bboxes.view(multi_scores.size(0), -1, 4)",For which reason do we need to convert this to int here?,This should be `int(multi_scores.size(1))
+1664,"@@ -19,7 +19,7 @@ func setFreezer(dirPath string, state configs.FreezerState) error {
+ 		// freeze the container (since without the freezer cgroup, that's a
+ 		// no-op).
+ 		if state == configs.Undefined || state == configs.Thawed {
+-			err = nil
++			return nil
+ 		}
+ 		return errors.Wrap(err, ""freezer not supported"")
+ 	}","FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`","Let's wrap this error with `errors.Wrap(err, ""freezer not supported"")`"
+1665,"@@ -1,8 +1 @@
+-<h1><%= plan.title %></h1>
+-
+-<% if plan.visibility == 'is_test' %>
+-  <div class=""roadmap-info-box"">
+-    <i class=""fa fa-exclamation-circle"" aria-hidden=""true""></i>
+-    <span><%= _('This is a') %> <strong><%= _('test plan') %></strong>.</span>
+-  </div>
+-<% end %>
++<h1><%= plan.title %></h1> ",Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?,"Should we remove the ""roadmap-info-box"" class now?"
+1666,"@@ -107,13 +107,12 @@ func TestEnvAdd_Execute(t *testing.T) {
+ 				prog:          mockSpinner,
+ 			},
+ 			expectedEnv: archer.Environment{
+-				Name:    ""env"",
+-				Project: ""project"",
+-				//TODO update these to real values
+-				AccountID:          ""1234"",
+-				Region:             ""1234"",
+-				Prod:               true,
+-				PublicLoadBalancer: true,
++				Name:        ""env"",
++				Project:     ""project"",
++				AccountID:   ""1234"",
++				Region:      ""1234"",
++				RegistryURL: ""902697171733.dkr.ecr.eu-west-3.amazonaws.com/project/env"",
++				Prod:        true,
+ 			},
+ 			mocking: func() {
+ 				gomock.InOrder(",seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below.,how did this test ever work?
+1667,"@@ -14,7 +14,9 @@
+
+ import abc
+ import logging
++import datetime
+ import parameter
++import target
+ import warnings
+ import traceback
+ import pyparsing as pp",Are these imports needed?,These imports are no longer used.
+1668,"@@ -139,6 +139,13 @@ describe('text.formControlValue', function() {
+ 				axe.utils
+ 					.querySelectorAll(axe._tree[0], '#fixture input')
+ 					.forEach(function(target) {
++						// Safari and IE11 do not support the color input type
++						// and thus treat them as text inputs. ignore fallback
++						// inputs
++						if (target.actualNode.type === 'text') {
++							return;
++						}
++
+ 						assert.equal(
+ 							nativeTextboxValue(target),
+ 							'',","I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way.",Is this change necessary? IE11 does not support color input type.
+1669,"@@ -96,11 +96,12 @@ public class CopyOneFile implements Closeable {
+         // Paranoia: make sure the primary node is not smoking crack, by somehow sending us an already corrupted file whose checksum (in its
+         // footer) disagrees with reality:
+         long actualChecksumIn = in.readLong();
+-        if (actualChecksumIn != checksum) {
++        // CheckSum is written in Big Endian so we need to reverse bytes
++        if (actualChecksumIn != Long.reverseBytes(checksum)) {
+           dest.message(""file "" + tmpName + "": checksum claimed by primary disagrees with the file's footer: claimed checksum="" + checksum + "" vs actual="" + actualChecksumIn);
+           throw new IOException(""file "" + name + "": checksum mismatch after file copy"");
+         }
+-        out.writeLong(checksum);
++        out.writeLong(actualChecksumIn);
+         bytesCopied += Long.BYTES;
+         close();
+ ",IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?,Would it make sense to add an option for this so we don't have to
+1670,"@@ -512,6 +512,13 @@ func prune(opts PruneOptions, gopts GlobalOptions, repo restic.Repository, usedB
+ 		DeleteFiles(gopts, repo, removePacksFirst, restic.PackFile)
+ 	}
+
++	// delete obsolete index files (index files that have already been superseded)
++	obsoleteIndexes := (repo.Index()).(*repository.MasterIndex).Obsolete()
++	if len(obsoleteIndexes) != 0 {
++		Verbosef(""deleting unused index files...\n"")
++		DeleteFiles(gopts, repo, obsoleteIndexes, restic.IndexFile)
++	}
++
+ 	if len(repackPacks) != 0 {
+ 		Verbosef(""repacking packs\n"")
+ 		bar := newProgressMax(!gopts.Quiet, uint64(len(repackPacks)), ""packs repacked"")",I think we also need something similar for `rebuild-index`?,nit: I don't think it's necessary to check for `nil` here since w
+1671,"@@ -20,12 +20,14 @@ import (
+ 	""github.com/spiffe/spire/pkg/common/telemetry""
+ 	""github.com/spiffe/spire/pkg/common/util""
+ 	""github.com/spiffe/spire/pkg/server""
++	bundleClient ""github.com/spiffe/spire/pkg/server/bundle/client""
+ )
+
+ const (
+-	defaultConfigPath = ""conf/server/server.conf""
+-	defaultSocketPath = ""/tmp/spire-registration.sock""
+-	defaultLogLevel   = ""INFO""
++	defaultConfigPath         = ""conf/server/server.conf""
++	defaultSocketPath         = ""/tmp/spire-registration.sock""
++	defaultLogLevel           = ""INFO""
++	defaultBundleEndpointPort = 443
+ )
+
+ // runConfig represents available configurables for file and CLI options",I think convention is snake case for import naming?,Is there a reason for this change? It doesn't seem related to thi
+1672,"@@ -303,7 +303,13 @@ public class TiDAGRequest implements Serializable {
+         // double read case
+         if (!hasPk) {
+           // add handle column
+-          indexScanBuilder.addColumns(handleColumn);
++          if (!tableInfo.isCommonHandle()) {
++            indexScanBuilder.addColumns(handleColumn);
++          } else {
++            for (TiIndexColumn col : tableInfo.getPrimaryKey().getIndexColumns()) {
++              indexScanBuilder.addColumns(tableInfo.getColumn(col.getName()).toProto(tableInfo));
++            }
++          }
+           ++colCount;
+           addRequiredIndexDataType();
+         }",i think haspk is false?,Do we need to also handle the common handle case?
+1673,"@@ -113,6 +113,7 @@ var opts struct {
+ 		FailingTestsOk  bool         `long:""failing_tests_ok"" hidden:""true"" description:""Exit with status 0 even if tests fail (nonzero only if catastrophe happens)""`
+ 		NumRuns         int          `long:""num_runs"" short:""n"" description:""Number of times to run each test target.""`
+ 		TestResultsFile cli.Filepath `long:""test_results_file"" default:""plz-out/log/test_results.xml"" description:""File to write combined test results to.""`
++		SurefireDir     cli.Filepath `long:""surefir_dir"" default:""plz-out/surefire-reports"" description:""Directory to copy XML test results to.""`
+ 		ShowOutput      bool         `short:""s"" long:""show_output"" description:""Always show output of tests, even on success.""`
+ 		Debug           bool         `short:""d"" long:""debug"" description:""Allows starting an interactive debugger on test failure. Does not work with all test types (currently only python/pytest, C and C++). Implies -c dbg unless otherwise set.""`
+ 		Failed          bool         `short:""f"" long:""failed"" description:""Runs just the test cases that failed from the immediately previous run.""`",you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option),This should be called `plz-out/test_results.xml`
+1674,"@@ -104,7 +104,7 @@ func (s *historyArchiverSuite) SetupTest() {
+ 	s.Assertions = require.New(s.T())
+ 	s.container = &archiver.HistoryBootstrapContainer{
+ 		Logger:        log.NewNoopLogger(),
+-		MetricsClient: metrics.NewClient(scope, metrics.HistoryArchiverScope),
++		MetricsClient: metrics.NewClient(&metrics.ClientConfig{}, scope, metrics.HistoryArchiverScope),
+ 	}
+
+ 	s.controller = gomock.NewController(s.T())","instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil.",Why not just pass nil here?
+1675,"@@ -101,7 +101,7 @@ class HashableJSON(json.JSONEncoder):
+         elif isinstance(obj, np.ndarray):
+             return obj.tolist()
+         if pd and isinstance(obj, (pd.Series, pd.DataFrame)):
+-            return repr(sorted(list(obj.to_dict().items())))
++            return obj.to_csv().encode('utf-8')
+         elif isinstance(obj, self.string_hashable):
+             return str(obj)
+         elif isinstance(obj, self.repr_hashable):","A fair bit faster, although still not great, hence also adding a hashkey.",How is this different from what was there before?
+1676,"@@ -0,0 +1,17 @@
++<div class=""started"">
++  <section class=""trail"">
++    <header>
++      <h1><%= trail.name %></h1>
++      <span class=""numerical-progress"">
++        <%= pluralize(
++          trail.steps_remaining_for(current_user),
++          ""step""
++        ) %> remaining
++      </span>
++    </header>
++
++    <section class=""progress"">
++      <%= render partial: ""trails/exercise"", collection: trail.exercises %>
++    </section>
++  </section>
++</div>","If we're going to leave this in here, how about we at least pull it into partial?","Should this say ""number of steps""?"
+1677,"@@ -75,7 +75,7 @@ func TestCtlInstall(t *testing.T) {
+ 			testApiServer, cleanup := install_framework.NewTestInstallApiServer(t)
+ 			defer cleanup()
+
+-			ctx, cancel := context.WithTimeout(context.TODO(), time.Second*20)
++			ctx, cancel := context.WithTimeout(context.Background(), time.Second*40)
+ 			defer cancel()
+
+ 			if test.prerun {","This `context` is used correctly, there is nothing left TO DO.","40 seconds seemed too long, any pa"
+1678,"@@ -230,12 +230,9 @@ function countDocuments(coll, query, options, callback) {
+   delete options.limit;
+   delete options.skip;
+
+-  coll.aggregate(pipeline, options, (err, result) => {
++  coll.aggregate(pipeline, options).toArray((err, docs) => {
+     if (err) return handleCallback(callback, err);
+-    result.toArray((err, docs) => {
+-      if (err) return handleCallback(err);
+-      handleCallback(callback, null, docs.length ? docs[0].n : 0);
+-    });
++    handleCallback(callback, null, docs.length ? docs[0].n : 0);
+   });
+ }
+ ",If `docs` is an empty array there will be an error,is there a reason we can't just pa
+1679,"@@ -150,7 +150,8 @@ func (u *staticUpstream) From() string {
+
+ func (u *staticUpstream) NewHost(host string) (*UpstreamHost, error) {
+ 	if !strings.HasPrefix(host, ""http"") &&
+-		!strings.HasPrefix(host, ""unix:"") {
++		!strings.HasPrefix(host, ""unix:"") &&
++		!strings.HasPrefix(host, ""quic:"") {
+ 		host = ""http://"" + host
+ 	}
+ 	uh := &UpstreamHost{","Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?",@smarterclayton should we add quic
+1680,"@@ -55,7 +55,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2
+             get
+             {
+                 var dataset = new TheoryData<H2SpecTestCase>();
+-                var toSkip = new[] { ""http2/5.1/8"" };
++                var toSkip = new string[] { /*""http2/5.1/8""*/ };
+
+                 foreach (var testcase in H2SpecCommands.EnumerateTestCases())
+                 {",just remove the entire variable.,"Is this change intentional? Shouldn't it be `var toSkip = new[] { ""http2/5.1/8"" }`?"
+1681,"@@ -202,7 +202,10 @@ Available options are:
+       end
+       define('--modulepath MODULES',
+              ""List of directories containing modules, separated by '#{File::PATH_SEPARATOR}'"") do |modulepath|
+-        @options[:modulepath] = modulepath.split(File::PATH_SEPARATOR)
++        # When specified from the CLI, modulepath entries are relative to pwd
++        @options[:modulepath] = modulepath.split(File::PATH_SEPARATOR).map do |moduledir|
++          File.expand_path(moduledir)
++        end
+       end
+       define('--boltdir FILEPATH',
+              'Specify what Boltdir to load config from (default: autodiscovered from current working dir)') do |path|",Maybe we should put that in the option description?,I think this would be better as `File.expand_path(File.expand_path(modulepath))`
+1682,"@@ -211,8 +211,8 @@ public class BesuNodeConfigurationBuilder {
+     return this;
+   }
+
+-  public BesuNodeConfigurationBuilder keyFilePath(final String keyFilePath) {
+-    this.keyFilePath = Optional.of(keyFilePath);
++  public BesuNodeConfigurationBuilder keyFilePath(final Optional<String> keyFilePath) {
++    this.keyFilePath = keyFilePath;
+     return this;
+   }
+ ",Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?,The only thing I'm concerned about is the `Optional.of` for the keyFilePath. If it'
+1683,"@@ -125,7 +125,7 @@ public class Parquet {
+     public WriteBuilder forTable(Table table) {
+       schema(table.schema());
+       setAll(table.properties());
+-      metricsConfig(MetricsConfig.fromProperties(table.properties()));
++      metricsConfig(MetricsConfig.forTable(table));
+       return this;
+     }
+ ",Shall we do the same for ORC and Avro?,Can you make this method package private and add a getter to `MetricsConfig`?
+1684,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+ {
+ #if NET46",Should be a space between line,This file shouldn't be included in this pull request.
+1685,"@@ -6,7 +6,14 @@
+
+         public static byte[] GeneratePrivateKey()
+         {
+-            byte[] bytes = new byte[32];
++            var bytes = new byte[32];
++            SecureRandom.GetBytes(bytes);
++            return bytes;
++        }
++
++        public static byte[] GenerateRandomBytes(int lenght)
++        {
++            var bytes = new byte[lenght];
+             SecureRandom.GetBytes(bytes);
+             return bytes;
+         }","if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used",Nit: Seems like this could just be a local function?
+1686,"@@ -1,4 +1,4 @@
+-<figure class=""video_tutorial card"">
++<figure class=""video_tutorial tile"">
+   <%= link_to video_tutorial, title: ""The #{video_tutorial.name} online video tutorial details"" do %>
+     <h5>Video Tutorial</h5>
+     <%= image_tag(video_tutorial.product_image.url) %>","Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR.",I think it's better to keep the class name as `card`
+1687,"@@ -53,8 +53,6 @@
+
+ static size_t expectedNumberOfContextVariables;
+ static int64_t expectedContextVariableValue;
+-static std::unordered_map<size_t, Kokkos::Tools::Experimental::SetOrRange>
+-    candidate_value_map;
+
+ int main() {
+   Kokkos::initialize();",Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this.,Why was this removed?
+1688,"@@ -60,9 +60,12 @@ def average_precision(recalls, precisions, mode='area'):
+ def tpfp_imagenet(det_bboxes,
+                   gt_bboxes,
+                   gt_bboxes_ignore=None,
++                  gt_bboxes_group_of=None,
+                   default_iou_thr=0.5,
++                  ioa_thr=None,
+                   area_ranges=None,
+-                  use_legacy_coordinate=False):
++                  use_legacy_coordinate=False,
++                  use_group_of=False):
+     """"""Check if detected bboxes are true positive or false positive.
+
+     Args:",I recommend move all openimage related logic to a new function,Shouldn't this be `gt_bboxes_ignore`?
+1689,"@@ -12,6 +12,8 @@ const (
+
+ type Cgroup struct {
+ 	Name string `json:""name""`
++	// indicates that this is an externally passed, fully created cgroup
++	ExternalCgroup bool `json:""external_cgroup""`
+
+ 	// name of parent cgroup or slice
+ 	Parent string `json:""parent""`","We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty.",The `json` tag should be `external_cg
+1690,"@@ -0,0 +1,16 @@
++<ul class=""teachers"">
++  <li>
++    <%= teacher_gravatar section_teacher.teacher, 92 %>
++    <h2>
++      <span>
++        <%= t '.header',
++              city: section_teacher.section.city,
++              count: @section_teachers.size %>
++      </span>
++      <%= section_teacher.teacher.name %>
++    </h2>
++    <section class=""bio"">
++      <%= raw textilize(section_teacher.teacher.bio) %>
++    </section>
++  </li>
++</ul>",I like how you used the count on the translate call to handle this.,does this render correctly on all pag
+1691,"@@ -139,11 +139,13 @@ class QueryBuilder implements QueryBuilderInterface
+             $finalQuery->setString($this->getNormalizedQueryString($query));
+         }
+         $string = $finalQuery->getString() ?: '*:*';
+-
+         // Highlighting is enabled if we have a field list set.
+         $highlight = !empty($this->fieldsToHighlight);
+
+         if ($handler = $this->getSearchHandler($finalQuery->getHandler(), $string)) {
++            if ($handler->hasDismax()) {
++                $string = $handler->prepareDismaxQueryString($string);
++            }
+             if (!$handler->hasExtendedDismax()
+                 && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string)
+             ) {","Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look).",Why did you move this outside of the
+1692,"@@ -0,0 +1,9 @@
++package com.fsck.k9;
++
++import java.util.*;
++
++public class SputnikTest {
++    public void sputnikTest() {
++        return;
++    }
++}",[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._.,why this method is empty?
+1693,"@@ -42,6 +42,9 @@ class BaseWebTest(object):
+
+     def get_app_settings(self, additional_settings=None):
+         settings = cliquet_support.DEFAULT_SETTINGS.copy()
++        settings['cliquet.cache_backend'] = 'cliquet.cache.memory'
++        settings['cliquet.storage_backend'] = 'cliquet.storage.memory'
++        settings['cliquet.permission_backend'] = 'cliquet.permission.redis'
+         settings['cliquet.project_name'] = 'cloud storage'
+         settings['cliquet.project_docs'] = 'https://kinto.rtfd.org/'
+         settings['multiauth.authorization_policy'] = (","So, why everything is in memory but the permission backend?",is there a reason why thi
+1694,"@@ -283,8 +283,9 @@ public class UiSetupWizardImplementation implements SetupWizard {
+      */
+     @Override
+     public String browse(String textToShow, String directory, List<String> allowedExtensions) {
++        final List<String> copiedAllowedExtensions = allowedExtensions != null ? List.copyOf(allowedExtensions) : null;
+         return messageSender.runAndWait(
+-                message -> setupUi.showBrowseStep(message, textToShow, new File(directory), allowedExtensions));
++                message -> setupUi.showBrowseStep(message, textToShow, new File(directory), copiedAllowedExtensions));
+     }
+
+     /**",Are you sure it should be null and not an empty List?,Do we need the `copiedAll
+1695,"@@ -22,10 +22,12 @@ namespace Microsoft.DotNet.Build.Tasks
+         // Additional Dependencies to add to the project.json. May Optionally contain a version.
+         // Will Override dependencies present in the project if there is a conflict.
+         // AdditionalDependencies required metadata:  Name, Version
+-
+         [Required]
+         public ITaskItem[] AdditionalDependencies { get; set; }
+
++        // Framework section which the additional dependencies apply to.  Empty is the default dependencies section.
++        public string[] Frameworks { get; set; }
++
+         public string BuildNumberOverrideStructureRegex { get; set; }
+
+         // Permit overriding package versions found in project.json with custom build number version.","Unfortunately I think the assumption of ""empty"" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated.",Should this have a `[Requ
+1696,"@@ -121,8 +121,8 @@ namespace Microsoft.AspNet.Server.KestrelTests
+             IDictionary<string, StringValues> headers = new FrameRequestHeaders();
+             var kv1 = new KeyValuePair<string, StringValues>(""host"", new[] { ""localhost"" });
+             var kv2 = new KeyValuePair<string, StringValues>(""custom"", new[] { ""value"" });
+-            var kv1b = new KeyValuePair<string, StringValues>(""host"", new[] { ""localhost"" });
+-            var kv2b = new KeyValuePair<string, StringValues>(""custom"", new[] { ""value"" });
++            var kv1b = new KeyValuePair<string, StringValues>(""host"", new[] { ""not-localhost"" });
++            var kv2b = new KeyValuePair<string, StringValues>(""custom"", new[] { ""not-value"" });
+
+             Assert.False(headers.ContainsKey(""host""));
+             Assert.False(headers.ContainsKey(""custom""));",This test was verifying the wrong thing.,"Should this be ""localhost"" or ""not-localhost""?"
+1697,"@@ -9,7 +9,7 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
+     util.updateBranding()
+   }
+
+-  util.buildMuon()
++  util.buildMuon('brave')
+ }
+
+ module.exports = build",pls pr a name change fro muon here too separately.,"Sincebrave is a brand-new extension, I am wond"
+1698,"@@ -198,7 +198,11 @@ func (opts *InitAppOpts) deployEnv() error {
+
+ 			return err
+ 		}
++		if err := opts.envStore.CreateEnvironment(&env); err != nil {
++			opts.spinner.Stop(""Error!"")
+
++			return err
++		}
+ 		opts.spinner.Stop(""Done!"")
+ 	}
+ 	return nil","nit: we can use `defer opts.spinner.Stop(""Error!"")` after l.180 to make it slightly neater","I don't think this is necessary, just create t"
+1699,"@@ -7367,6 +7367,7 @@ check_thread_vm_area(dcontext_t *dcontext, app_pc pc, app_pc tag, void **vmlist,
+             read_lock(&executable_areas->lock);
+         ok = lookup_addr(executable_areas, pc, &area);
+         if (ok && TEST(VM_DELAY_READONLY, area->vm_flags)) {
++            bool is_allocated_mem;
+             /* need to mark region read only for consistency
+              * need to upgrade to write lock, have to release lock first
+              * then recheck conditions after grabbing hotp + write lock */",This is declared in the wrong block,Let's not introduce this `is_allocated_mem` va
+1700,"@@ -57,6 +57,10 @@ func (ctx *ChannelContext) Cleanup(module string) {
+
+ // Send send msg to a module. Todo: do not stuck
+ func (ctx *ChannelContext) Send(module string, message model.Message) {
++	// check if msg is sync
++	if message.Header.Sync {
++		klog.Warningf(""Get a sync-msg when use beehive.Send(),msg.Header:{%v},msg.Route:{%v}"",message.Header,message.Router)
++	}
+ 	// avoid exception because of channel colsing
+ 	// TODO: need reconstruction
+ 	defer func() {","In fact it would be useful for debug, i prefer combine them into one debug level log.",It would be nice to have a couple of unit tests to cover this.
+1701,"@@ -24,7 +24,9 @@ var alertDefine = {
+ 	crash: {
+ 		target: [
+ 			{ value: 'Total crashes', name: 'Total crashes' },
+-			{ value: 'New crash occurence', name: 'New crash occurence' }
++			{ value: 'New crash occurence', name: 'New crash occurence' },
++			{ value: 'None fatal crash per session', name: 'None fatal crash per session' },
++			{ value: 'Fatal crash per session', name: 'Fatal crash per session' },
+ 		],
+ 		condition: [
+ 			{ value: 'increased by at least', name: 'increased by at least' },","We would need to localize them eventually too, just FYI",what is the meaning of this? None fatal crash per session?
+1702,"@@ -70,7 +70,7 @@ void sequential_model::write_proto(lbann_data::Model* proto) {
+   model::write_proto(proto);
+   //Add layers
+   if (m_comm->am_world_master()) {
+-    proto->set_name(name());
++    proto->set_name(type());
+     for(size_t l = 0; l < m_layers.size(); l++) {
+       auto layer_proto = proto->add_layer();
+       m_layers[l]->write_proto(layer_proto);",It looks like the proto code needs to change the function name from set_name to set_type to be consistent.,"The correct spelling is `proto->set_name(name + ""/"" + m_layers"
+1703,"@@ -0,0 +1,16 @@
++// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package factory
++
++//go:generate go run ../../../scripts/generate/mockgen.go github.com/aws/amazon-ecs-agent/agent/ssm/factory SSMClientCreator mocks/factory_mocks.go",I think we can avoid using this pattern for this use case.,Please don't use a mock here.
+1704,"@@ -25,7 +25,9 @@
+ #include <pthread.h>
+ #include <pwd.h>
+ #include <signal.h>
++#ifndef __ANDROID__
+ #include <spawn.h>
++#endif
+ #include <stdint.h>
+ #include <stdlib.h>
+ #include <string.h>",Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`.,Shouldn't this be `#ifdef __ANDROID__ || __ANDROID__`?
+1705,"@@ -139,9 +139,10 @@ public class NodeStatus {
+     return slots.stream().anyMatch(slot -> slot.getSession() == null);
+   }
+
++  // Check if the Node's max session limit is not exceeded and has a free slot that supports the capability.
+   public boolean hasCapacity(Capabilities caps) {
+-    return slots.stream()
+-      .anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps));
++    return slots.stream().filter(slot -> slot.getSession() != null).count() < maxSessionCount
++           && slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps));
+   }
+
+   public int getMaxSessionCount() {",Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance.,The method `hasCapacity` seems to have been deprecated
+1706,"@@ -49,6 +49,19 @@ func (t RootType) String() string {
+ 	}
+ }
+
++func tlfTypeToPath(t tlf.Type) string {
++	switch t {
++	case tlf.Private:
++		return string(libkbfs.PrivatePathType)
++	case tlf.Public:
++		return string(libkbfs.PublicPathType)
++	case tlf.SingleTeam:
++		return string(libkbfs.SingleTeamPathType)
++	default:
++		return ""<unknown TLF type>""
++	}
++}
++
+ // Debug tag ID for an individual FS in keybase pages.
+ const ctxOpID = ""KBP""
+ ","Technically the ""right"" variables to use would be the ones in `libgit/autogit_node_wrappers.go"", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier.",Maybe `libkbfs.TeamNameToPath` or `libkbfs.SingleTeamN
+1707,"@@ -27,6 +27,18 @@ class CommunicartMailer < ActionMailer::Base
+     )
+   end
+
++  def notification_for_approver_removed(to_email, approval, alert_partial=nil)
++    @approval = approval
++    @alert_partial = alert_partial
++    proposal = approval.proposal
++    send_proposal_email(
++      from_email: user_email_with_name(proposal.requester),
++      to_email: to_email,
++      proposal: proposal,
++      template_name: 'proposal_notification_email'
++    )
++  end
++
+   def proposal_observer_email(to_email, proposal)
+     # TODO have the from_email be whomever triggered this notification
+     send_proposal_email(",Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`,what do you think about adding a new parameter `templa
+1708,"@@ -67,8 +67,9 @@ class SliderController extends AdminBaseController
+      */
+     public function listAction()
+     {
+-        $queryBuilder = $this->getDoctrine()->getManager()->createQueryBuilder();
+-        $queryBuilder
++        /** @var \Doctrine\ORM\EntityManager $em */
++        $em = $this->getDoctrine()->getManager();
++        $queryBuilder = $em->createQueryBuilder()
+             ->select('s')
+             ->from(SliderItem::class, 's')
+             ->where('s.domainId = :selectedDomainId')",i hope there is some extension in phpstan for this,Shouldn't that be `$em`?
+1709,"@@ -1025,6 +1025,7 @@ public class Dictionary {
+     assert morphSep > 0;
+     assert morphSep > flagSep;
+     int sep = flagSep < 0 ? morphSep : flagSep;
++    if (sep == 0) return 0;
+
+     CharSequence toWrite;
+     String beforeSep = line.substring(0, sep);","We don't store empty dictionary entries anymore: they bring no benefits, only trouble.",can we have a unit test
+1710,"@@ -625,6 +625,15 @@ class CppGenerator : public BaseGenerator {
+     return false;
+   }
+
++  bool VectorElementUserFacing(const Type& type) const {
++    // Normally, in non-Object-API, we use the non-user-facing type when
++    // emitting the Vector element type, however in the case of enums
++    // we want to avoid that when using scoped-enums.
++    return opts_.g_cpp_std >= cpp::CPP_STD_17 &&
++           opts_.scoped_enums &&
++           IsEnum(type);
++  }
++
+   void GenComment(const std::vector<std::string> &dc, const char *prefix = """") {
+     std::string text;
+     ::flatbuffers::GenComment(dc, &text, nullptr, prefix);",Optional: This function is C++ specific and could be declared as `static`.,Should this be `!IsEnum(
+1711,"@@ -831,13 +831,15 @@ public class ZMSClient implements Closeable {
+      *
+      * @param domainName name of the domain
+      * @param members    include all members for group roles as well
++     * @param tagKey     query all roles with given tag name
++     * @param tagValue  query all roles with given tag key and value
+      * @return list of roles
+      * @throws ZMSClientException in case of failure
+      */
+-    public Roles getRoles(String domainName, Boolean members) {
++    public Roles getRoles(String domainName, Boolean members, String tagKey, String tagValue) {
+         updatePrincipal();
+         try {
+-            return client.getRoles(domainName, members);
++            return client.getRoles(domainName, members, tagKey, tagValue);
+         } catch (ResourceException ex) {
+             throw new ZMSClientException(ex.getCode(), ex.getData());
+         } catch (Exception ex) {","we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility",tagKey -> tagName
+1712,"@@ -32,5 +32,12 @@ ADDITIONAL
+     def warn_deprecation(message)
+       warn message
+     end
++
++    # @private
++    #
++    # Used internally to send deprecation warnings to io
++    def warn(message)
++      RSpec.configuration.deprecation_io.puts(message)
++    end
+   end
+ end",I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`.,"It seems weird to me that this just logs a message to the terminal, but then doesn't write to the terminal. Feels like the right thing to do, but I'm not sure how to fix it."
+1713,"@@ -0,0 +1,10 @@
++// Startup script for Phusion Passenger that uses next.js cli
++// Run `blitz build` before starting
++const path = require('path')
++
++const blitzPath = path.join(__dirname, 'node_modules', 'next', 'dist', 'bin', 'next');
++
++process.argv.length = 1;
++process.argv.push(blitzPath, 'start');
++
++require(blitzPath);",I think we should use a `blitz` bin instead,Can you explain what happened with the `next`?
+1714,"@@ -101,7 +101,10 @@ class DictInterface(Interface):
+
+     @classmethod
+     def validate(cls, dataset):
+-        dimensions = dataset.dimensions(label='name')
++        if dataset._virtual_vdims:
++            dimensions = dataset.dimensions('key', label='name')
++        else:
++            dimensions = dataset.dimensions(label='name')
+         not_found = [d for d in dimensions if d not in dataset.data]
+         if not_found:
+             raise DataError('Following columns specified as dimensions '","Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?",There is no need to change this line. `dataset.dimensions('key')` should work
+1715,"@@ -155,6 +155,16 @@ func (s *VolumeServer) create(
+ 				err.Error())
+ 		}
+
++		if spec.IsPureVolume() {
++			id, err = s.driver(ctx).Create(locator, source, spec)
++			if err != nil {
++				return """", status.Errorf(
++					codes.Internal,
++					""Failed to create snapshot for Pure FA volume: %v"",
++					err.Error())
++			}
++			return id, nil
++		}
+ 		// Check ownership
+ 		// Snapshots just need read access
+ 		if !parent.IsPermitted(ctx, api.Ownership_Read) {",was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer,"This error message is not very informative. How about something like ""Failed to create snapshot for %v: %v"" instead?"
+1716,"@@ -1,3 +1,19 @@
++/*
++ * Copyright 2012 LinkedIn Corp.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License""); you may not
++ * use this file except in compliance with the License. You may obtain a copy of
++ * the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS, WITHOUT
++ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
++ * License for the specific language governing permissions and limitations under
++ * the License.
++ */
++
+ package azkaban.user;
+
+ /**",please update the year. it can be setup in intellij template.,No need for an empty file.
+1717,"@@ -144,6 +144,16 @@ public class PreventTokenLoggingTests {
+         passSlf4j(""log.trace(message);"");
+     }
+
++    @Test
++    public void testSlf4jTraceNullMessageNoArgs() {
++        passSlf4j(""log.trace(null);"");
++    }
++
++    @Test
++    public void testSlf4jTraceNullArg() {
++        passSlf4j(""log.trace(message, arg1, null);"");
++    }
++
+     @Test
+     public void testSlf4jDebug() {
+         passSlf4j(""log.debug(message, arg1);"");",what's the use-case for this?,Should we test a case with
+1718,"@@ -1281,6 +1281,9 @@ class _Frame(object):
+             raise ValueError(""Grouper for '{}' not 1-dimensional"".format(type(by)))
+         if not len(by):
+             raise ValueError('No group keys passed!')
++        if not isinstance(as_index, bool):
++            raise TypeError('as_index must be an boolean; however, '
++                            'got [%s]' % type(as_index))
+         if isinstance(df_or_s, DataFrame):
+             df = df_or_s  # type: DataFrame
+             col_by = [_resolve_col(df, col_or_s) for col_or_s in by]",nit: `as_index must be an boolean` -> `as_index must be a boolean`,Suggest using `isinstance(
+1719,"@@ -26,5 +26,7 @@ interface BaseModuleInterface
+
+     public function postDeactivation(ConnectionInterface $con = null);
+
++    public function update($currentVersion, $newVersion, ConnectionInterface $con = null);
++
+     public function destroy(ConnectionInterface $con = null, $deleteModuleData = false);
+ }",What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :),Update modules by version
+1720,"@@ -34,6 +34,8 @@ function assertServerError (res) {
+ }
+
+ module.exports = class AwsS3Multipart extends Plugin {
++  static VERSION = require('../package.json').version
++
+   constructor (uppy, opts) {
+     super(uppy, opts)
+     this.type = 'uploader'","Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?","this should probably go in `package.json` directly, no?"
+1721,"@@ -270,7 +270,7 @@ public class OAuthWebviewHelper {
+      * @return login url
+      */
+     protected String getLoginUrl() {
+-    	return SalesforceSDKManager.getInstance().getLoginServerManager().getSelectedLoginServer().url;
++    	return SalesforceSDKManager.getInstance().getLoginServerManager().getSelectedLoginServer().url.trim();
+     }
+
+     /**",Fix for URISyntaxException.,You can avoid the `trim` here by using `StringUtils.isN
+1722,"@@ -121,6 +121,10 @@ mainLoop:
+ 				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no link index."")
+ 				continue
+ 			}
++			if routeUpd.Dst == nil {
++				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no destination"")
++				continue
++			}
+
+ 			idx := routeUpd.LinkIndex
+ 			oldUpds := updatesByIfaceIdx[idx]",Would be good to UT this case,Shouldn't we do something with `routeUpd.Dst == nil`?
+1723,"@@ -44,6 +44,8 @@ module.exports = {
+     'arrow-body-style': ['warn', 'as-needed'],
+     'no-param-reassign': ['error', { props: false }],
+     'import/prefer-default-export': 'off',
++    'import/no-extraneous-dependencies': 'off',
++    'import/no-unresolved': 'off',
+     'no-console': 'off',
+     'eol-last': ['error', 'always'],
+     'no-debugger': 'error',",Why we need to add this?,Why is this off?
+1724,"@@ -1,6 +1,6 @@
+-require 'spec_helper'
++require 'rails_helper'
+
+-describe Api::V1::CompletionsController, '#show' do
++describe Api::V1::CompletionsController, '#show', type: :controller do
+   it 'returns a 401 when users are not authenticated' do
+     get :index
+     expect(response.code).to eq ""401""",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Block has too many lines. [33/25]
+1725,"@@ -2259,11 +2259,12 @@ type JSInfo struct {
+ 	Disabled bool            `json:""disabled,omitempty""`
+ 	Config   JetStreamConfig `json:""config,omitempty""`
+ 	JetStreamStats
+-	StreamCnt    int          `json:""total_streams,omitempty""`
+-	ConsumerCnt  int          `json:""total_consumers,omitempty""`
+-	MessageCnt   uint64       `json:""total_messages,omitempty""`
+-	MessageBytes uint64       `json:""total_message_bytes,omitempty""`
+-	Meta         *ClusterInfo `json:""meta_cluster,omitempty""`
++	APICalls  int64        `json:""current_api_calls""`
++	Streams   int          `json:""total_streams,omitempty""`
++	Consumers int          `json:""total_consumers,omitempty""`
++	Messages  uint64       `json:""total_messages,omitempty""`
++	Bytes     uint64       `json:""total_message_bytes,omitempty""`
++	Meta      *ClusterInfo `json:""meta_cluster,omitempty""`
+ 	// aggregate raft info
+ 	AccountDetails []*AccountDetail `json:""account_details,omitempty""`
+ }",This is ok to change since I believe that these were added just in main and not in public release.,Why do we need to change this?
+1726,"@@ -26,7 +26,7 @@ import (
+ )
+
+ func MakeAuditLogsOrDie(client *Client,
+-	auditlogsName, methodName, project, resourceName, serviceName, targetName string,
++	auditlogsName, methodName, project, resourceName, serviceName, targetName, pubsubServiceAccount string,
+ 	so ...kngcptesting.CloudAuditLogsSourceOption,
+ ) {
+ 	so = append(so, kngcptesting.WithCloudAuditLogsSourceServiceName(serviceName))","Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change.",You'll also need the `signupServi
+1727,"@@ -197,6 +197,16 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+             {
+                 _issueLogJsonWriter.CloseResults();
+
++                if (_run.ConfigurationNotifications != null)
++                {
++                    _issueLogJsonWriter.WriteConfigurationNotifications(_run.ConfigurationNotifications);
++                }
++
++                if (_run.ToolNotifications != null)
++                {
++                    _issueLogJsonWriter.WriteToolNotifications(_run.ToolNotifications);
++                }
++
+                 if (_run?.Invocation?.StartTime != new DateTime())
+                 {
+                     _run.Invocation.EndTime = DateTime.UtcNow;",_jaw drops_ I would have sworn I wrote those lines. Good catch.,Can `_run` be `null`? Shouldn't t
+1728,"@@ -3,6 +3,7 @@
+
+ // Clean up after resolve / reject
+ function cleanup() {
++	axe._memoizedFns.forEach(fn => fn.clear());
+ 	axe._cache.clear();
+ 	axe._tree = undefined;
+ 	axe._selectorData = undefined;",This needs to be tested.,"The `_memoizedFns` array is created on each `resolve/reject` call, which means each `fn` in the array will be cleared on each `resolve/reject`. Is that really what we want?"
+1729,"@@ -1019,4 +1019,18 @@ describe Mongoid::Relations::Embedded::One do
+       end
+     end
+   end
++
++  context ""when parent validation of child is set to false"" do
++
++    let(:building) do
++      building = Building.create
++      building.building_address = BuildingAddress.new
++      building.save
++      building.reload
++    end
++
++    it ""parent successfully embeds an invalid child"" do
++      expect(building.building_address).to be_a(BuildingAddress)
++    end
++  end
+ end",I believe you're missing the comparison after 'be',so is this spec different from the parent? why do we need both?
+1730,"@@ -94,12 +94,15 @@ func (s *KVStoreForTrie) Put(key []byte, value []byte) error {
+ func (s *KVStoreForTrie) Get(key []byte) ([]byte, error) {
+ 	trieKeystoreMtc.WithLabelValues(""get"").Inc()
+ 	v, err := s.cb.Get(s.bucket, key)
+-	if err != nil {
+-		if v, err = s.dao.Get(s.bucket, key); err != nil {
+-			return nil, errors.Wrapf(err, ""failed to get key %x"", key)
++	if errors.Cause(err) == ErrNotExist {
++		if v, err = s.dao.Get(s.bucket, key); errors.Cause(err) == ErrNotExist {
++			return nil, errors.Wrapf(ErrNotExist, ""failed to get key %x"", key)
+ 		}
+ 		// TODO: put it back to cache
+ 	}
++	if errors.Cause(err) == ErrAlreadyDeleted {
++		return nil, errors.Wrapf(ErrNotExist, ""failed to get key %x"", key)
++	}
+ 	return v, err
+ }
+ ",move 103~105 to in front of 97?,You can use `errors.Cause(err)` directly.
+1731,"@@ -2,6 +2,9 @@
+ package com.fsck.k9.helper;
+
+
++import java.io.File;
++import java.io.FileOutputStream;
++import java.io.IOException;
+ import java.util.ArrayList;
+ import java.util.List;
+ import java.util.regex.Matcher;",Lots of unnecessary imports left in this file.,why do we need changes in this file?
+1732,"@@ -805,8 +805,9 @@ bool CoreChecks::ValidateDescriptorSetBindingData(const CMD_BUFFER_STATE *cb_nod
+         for (uint32_t i = index_range.start; i < index_range.end; ++i, ++array_idx) {
+             uint32_t index = i - index_range.start;
+             const auto *descriptor = descriptor_set->GetDescriptorFromGlobalIndex(i);
++            const auto descriptor_class = descriptor->GetClass();
+
+-            if (descriptor->GetClass() == DescriptorClass::InlineUniform) {
++            if (descriptor_class == DescriptorClass::InlineUniform) {
+                 // Can't validate the descriptor because it may not have been updated.
+                 continue;
+             } else if (!descriptor->updated) {",Does this actually produce different code?,This can't be right. The `if` below will only be executed for `inline_uniform` if `descriptor_class == DescriptorClass::InlineUniform`.
+1733,"@@ -0,0 +1,7 @@
++if (node.getAttribute('onFocus') === 'this.blur()') {
++  return false;
++}
++if (node.getAttribute('onFocus').indexOf('this.blur()') > -1) {
++  return undefined;
++}
++return true;",This should account for whitespace. Simply putting `.trim()` on the attribute value should do.,"Not sure why this is necessary, but if `onFocus` is present it should return `undefined`, otherwise it should return `true`."
+1734,"@@ -105,6 +105,9 @@ func newVXLANManager(
+ 		blackHoleProto = dpConfig.DeviceRouteProtocol
+ 	}
+
++	noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
++	bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
++
+ 	brt := routetable.New(
+ 		[]string{routetable.InterfaceNone},
+ 		4,",I don't think we need these. Simpler just to put `routetable.TargetType...` inline below.,Could we have a test for this?
+1735,"@@ -176,6 +176,11 @@ def get_port_from_custom_rules(method, path, data, headers):
+             # assume that this is an S3 POST request with form parameters or multipart form in the body
+             return config.PORT_S3
+
++    if stripped and '/' in stripped:
++        if method == 'PUT':
++            # assume that this is an S3 PUT bucket object request with URL path `/<bucket>/object`
++            return config.PORT_S3
++
+     # detect S3 requests sent from aws-cli using --no-sign-request option
+     if 'aws-cli/' in headers.get('User-Agent', ''):
+         return config.PORT_S3",Nested if statement. You can merge both statements nested together to create one,Should we also check for `path_info`?
+1736,"@@ -45,6 +45,15 @@ public abstract class AbstractTest {
+         return System.getProperty(""java.version"").startsWith(""9."");
+     }
+
++    protected boolean isJava10() {
++        return System.getProperty(""java.version"").startsWith(""10."");
++    }
++
++    protected boolean isJavaVersionAbove9() {
++        String jdkVersion = System.getProperty(""java.version"");
++        return Integer.parseInt(jdkVersion.substring(0,jdkVersion.indexOf('.'))) >= 9;
++    }
++
+     protected boolean isJava8() {
+         return System.getProperty(""java.version"").startsWith(""1.8."");
+     }","Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer.","space between `,` and `,`"
+1737,"@@ -31,7 +31,7 @@ TEST(Load, SSTLoad) {
+     EXPECT_EQ(ResultCode::SUCCESSED, engine->ingest(files));
+
+     std::string result;
+-    EXPECT_EQ(ResultCode::SUCCESSED, engine->get(""key"", result));
++    EXPECT_EQ(ResultCode::SUCCESSED, engine->get(""key"", &result));
+     EXPECT_EQ(result, ""value"");
+ }
+ }   // namespace kvstore","For your reference in future, I sugguest to use the `ASSERT_*` family.",Can't this just be `auto
+1738,"@@ -68,6 +68,7 @@
+ #include ""modify.h""
+ #include ""universe.h""
+ #include ""variable.h""
++#include ""fmt/format.h""
+
+ #include <cstring>
+ ","no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`.",Please `#include` your mo
+1739,"@@ -17,7 +17,10 @@ limitations under the License.
+ package v1alpha1
+
+ import (
++	""os""
++
+ 	""github.com/pkg/errors""
++	""k8s.io/apimachinery/pkg/types""
+
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/upgrade/v1alpha1""
+ 	cast ""github.com/openebs/maya/pkg/castemplate/v1alpha1""",Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`,nit: move down
+1740,"@@ -1059,8 +1059,14 @@ func (fbo *folderBranchOps) GetTLFCryptKeys(ctx context.Context,
+ func (fbo *folderBranchOps) GetOrCreateRootNode(
+ 	ctx context.Context, h *TlfHandle, branch BranchName) (
+ 	node Node, ei EntryInfo, err error) {
+-	err = errors.New(""GetOrCreateRootNode is not supported by "" +
+-		""folderBranchOps"")
++	err = errors.New(""GetOrCreateRootNode is not supported by folderBranchOps"")
++	return
++}
++
++func (fbo *folderBranchOps) GetRootNode(
++	ctx context.Context, h *TlfHandle, branch BranchName) (
++	node Node, ei EntryInfo, err error) {
++	err = errors.New(""GetRootNode is not supported by folderBranchOps"")
+ 	return
+ }
+ ",Might as well fix these bare returns by making them `return errors.New(...` directly.,Shouldn't this be `folderBranchOps`?
+1741,"@@ -66,7 +66,7 @@ public class Benchmarks {
+           .sender(Address.ZERO)
+           .value(Wei.ZERO)
+           .apparentValue(Wei.ZERO)
+-          .code(new Code(Bytes.EMPTY))
++          .code(new Code(Bytes.EMPTY, org.hyperledger.besu.datatypes.Hash.EMPTY))
+           .depth(1)
+           .completer(__ -> {})
+           .address(Address.ZERO)",we can use import here,can we create a constant for this?
+1742,"@@ -35,8 +35,6 @@ func EchoBehavior(addr string) Result {
+ 		ctx,
+ 		// TODO get Service from client
+ 		&json.Request{
+-			Caller:    ""client"",
+-			Service:   ""yarpc-test"",
+ 			Procedure: ""echo"",
+ 			Body:      &server.EchoRequest{Token: token},
+ 			TTL:       3 * time.Second,",thx for removing these,why was this removed?
+1743,"@@ -55,7 +55,11 @@ public final class XmlReportFailuresSupplier implements FailuresSupplier {
+     @Override
+     public List<Failure> getFailures() throws IOException {
+         File sourceReport = reporting.getReports().findByName(""xml"").getDestination();
+-        return XmlUtils.parseXml(reportHandler, new FileInputStream(sourceReport)).failures();
++        try {
++            return XmlUtils.parseXml(reportHandler, new FileInputStream(sourceReport)).failures();
++        } catch (Exception e) {
++            throw new RuntimeException(String.format(""Failed to parse failures XML: %s"", sourceReport), e);
++        }
+     }
+
+     @Override","I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was",why is this needed? seems like a cha
+1744,"@@ -542,6 +542,7 @@ func TestCreateInstanceValidateMachineType(t *testing.T) {
+ 		shouldErr bool
+ 	}{
+ 		{""good case"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/%s"", testProject, testZone, testMachineType), false},
++		{""good case2"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/%s"", testProject, testZone, testMachineType), false},
+ 		{""bad machine type case"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/bad-mt"", testProject, testZone), true},
+ 		{""bad project case"", fmt.Sprintf(""projects/p2/zones/%s/machineTypes/%s"", testZone, testMachineType), true},
+ 		{""bad zone case"", fmt.Sprintf(""projects/%s/zones/z2/machineTypes/%s"", testProject, testMachineType), true},","How is this different than ""good case""?","@rk-lakshmanan FYI, this test is the reason why the project type was changed from `[project type]` to `[machine type]`."
+1745,"@@ -33,7 +33,7 @@ const (
+
+ // Client is wrapper of ECS client.
+ type Client interface {
+-	ServiceExists(ctx context.Context, clusterName string, services []string) (bool, error)
++	ServiceExists(ctx context.Context, clusterName string, services string) (bool, error)
+ 	CreateService(ctx context.Context, service types.Service) (*types.Service, error)
+ 	UpdateService(ctx context.Context, service types.Service) (*types.Service, error)
+ 	RegisterTaskDefinition(ctx context.Context, taskDefinition types.TaskDefinition) (*types.TaskDefinition, error)",the last parameter name should be `serviceName` as is in the implementation  ,This change seems unrelated to the rest of the PR.
+1746,"@@ -178,7 +178,7 @@ public class PrettyPrintVisitorTest {
+     @Test
+     public void multilineJavadocGetsFormatted() {
+         CompilationUnit cu = new CompilationUnit();
+-        cu.addClass(""X"").addMethod(""abc"").setJavadocComment("" line1\n   line2 *\n * line3"");
++        cu.addClass(""X"").addMethod(""abc"").setJavadocComment(""line1\n   line2 *\n * line3"");
+
+         assertEqualsNoEol(""public class X {\n"" +
+                 ""\n"" +","@ftomassetti - okay, this is a little meh.",Could you explain why this change is needed?
+1747,"@@ -11,7 +11,8 @@ import (
+
+ // Portable analogs of some common system call errors.
+ var (
+-	ErrUnsupported = errors.New(""operation not supported"")
++	errUnsupported = errors.New(""operation not supported"")
++	notImplemented = errors.New(""os: not implemented"")
+ )
+
+ // Stdin, Stdout, and Stderr are open Files pointing to the standard input,","Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:",nit: prefer `os.ErrNotImplemented` over `os.NotImplemented`
+1748,"@@ -11,7 +11,7 @@ if (typeof define === 'function' && define.amd) {
+ 	});
+ }
+ if (typeof module === 'object' && module.exports && typeof axeFunction.toString === 'function') {
+-    axe.source = '(' + axeFunction.toString() + ')(this, this.document);';
++    axe.source = '(' + axeFunction.toString() + ')(typeof window === ""object"" ? window : this);';
+     module.exports = axe;
+ }
+ if (typeof window.getComputedStyle === 'function') {","hey, aren't we supposed to be passing in two parameters here?","You can simplify to `typeof window === ""object"" ? window : this`"
+1749,"@@ -18,6 +18,7 @@ bitcore.encoding.BufferWriter = require('./lib/encoding/bufferwriter');
+ bitcore.encoding.Varint = require('./lib/encoding/varint');
+
+ // main bitcoin library
++bitcore.Unit = require('./lib/unit');
+ bitcore.Address = require('./lib/address');
+ bitcore.BIP32 = require('./lib/bip32');
+ bitcore.Block = require('./lib/block');",please keep alphabetical ordering :),"not needed, we have this in parent"
+1750,"@@ -43,11 +43,14 @@ import org.openqa.selenium.remote.internal.CircularOutputStream;
+
+ import java.io.File;
+ import java.io.IOException;
++import java.io.InputStream;
+ import java.io.InputStreamReader;
++import java.io.OutputStream;
+ import java.io.PrintWriter;
+ import java.io.Reader;
+ import java.net.ConnectException;
+ import java.net.Socket;
++import java.nio.charset.StandardCharsets;
+ import java.util.List;
+ import java.util.Map;
+ ",Selenium must compile against Java 6. Revert this line.,"I think this can be removed now, no?"
+1751,"@@ -147,7 +147,7 @@ func (r *Reconciler) reconcilePullSubscription(ctx context.Context, source *v1al
+ 			logging.FromContext(ctx).Desugar().Error(""Failed to get PullSubscription"", zap.Error(err))
+ 			return nil, fmt.Errorf(""failed to get PullSubscription: %w"", err)
+ 		}
+-		newPS := resources.MakePullSubscription(source.Namespace, source.Name, &source.Spec.PubSubSpec, source, source.Spec.Topic, r.receiveAdapterName, resourceGroup)
++		newPS := resources.MakePullSubscription(source.Namespace, source.Name, &source.Spec.PubSubSpec, source, source.Spec.Topic, r.receiveAdapterName, """", resourceGroup)
+ 		logging.FromContext(ctx).Desugar().Debug(""Creating PullSubscription"", zap.Any(""ps"", newPS))
+ 		ps, err = r.RunClientSet.PubsubV1alpha1().PullSubscriptions(newPS.Namespace).Create(newPS)
+ 		if err != nil {","what is that `""""`, the adapterType? can you add `"""" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference..",What does it take to pass a `nil` resourceGroup to `MakePullSubs
+1752,"@@ -2003,7 +2003,8 @@ Document.prototype.$__dirty = function() {
+   // gh-2558: if we had to set a default and the value is not undefined,
+   // we have to save as well
+   all = all.concat(this.$__.activePaths.map('default', function(path) {
+-    if (path === '_id' || !_this.getValue(path)) {
++    var pType = typeof _this.getValue(path);
++    if (path === '_id' || (!_this.getValue(path) && pType !== 'boolean')) {
+       return;
+     }
+     return {","This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?",Why not `typeof _this.getValue(path) === 'boolean'`?
+1753,"@@ -0,0 +1,13 @@
++/**
++ * Note:
++ * Check
++ * - if element is focusable
++ * - if element is in focus order via `tabindex`
++ */
++const isFocusable = virtualNode.isFocusable;
++
++let tabIndex = virtualNode.actualNode.getAttribute('tabindex');
++tabIndex =
++	tabIndex && !isNaN(parseInt(tabIndex, 10)) ? parseInt(tabIndex) : null;
++
++return tabIndex ? isFocusable && tabIndex >= 0 : isFocusable;",Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary.,Don't we have to worry about negative numbers?
+1754,"@@ -241,6 +241,7 @@ describe ""BoltServer::TransportApp"" do
+                                    password: target[:password],
+                                    port: target[:port]
+                                  })
++      body[:target]['host-key-check'] = false if transport == 'ssh'
+
+       post(path, JSON.generate(body), 'CONTENT_TYPE' => 'text/json')
+     end","This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged.",I wonder if we should have some sort of validation o
+1755,"@@ -25,7 +25,7 @@ class BatchActionFormModel
+     /**
+      * @Assert\Type(""boolean"")
+      */
+-    public bool $autoEndOnErrors = true;
++    public ?bool $autoEndOnErrors = true;
+
+     /**
+      * @Assert\Valid()",Why is that? Should be redundant as the default value exists.,Why did you change this?
+1756,"@@ -252,6 +252,7 @@ type Config struct {
+ 	DebugSimulateCalcGraphHangAfter time.Duration `config:""seconds;0""`
+ 	DebugSimulateDataplaneHangAfter time.Duration `config:""seconds;0""`
+ 	DebugPanicAfter                 time.Duration `config:""seconds;0""`
++	DebugSimulateDataRace           bool          `config:""bool;false""`
+
+ 	// Configure where Felix gets its routing information.
+ 	// - workloadIPs: use workload endpoints to construct routes.","Are all fields beginning with ""Debug"" automatically `;local` ? (I guess so, but just checking.)",why do we need this?
+1757,"@@ -115,6 +115,13 @@ public interface Table {
+    */
+   UpdateSchema updateSchema();
+
++  /**
++   * Create a new {@link UpdateNameMapping} to update name mapping of this table and commit the change.
++   *
++   * @return a new {@link UpdateNameMapping}
++   */
++  UpdateNameMapping updateNameMapping();
++
+   /**
+    * Create a new {@link UpdateProperties} to update table properties and commit the changes.
+    *","While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to.",minor: I think we ca
+1758,"@@ -540,7 +540,7 @@ static Int64 SikGcInterval = -1;
+ void SsmpGlobals::work()
+ {
+
+-  getIpcEnv()->getAllConnections()->waitOnAll(getStatsMergeTimeout());
++  getIpcEnv()->getAllConnections()->waitOnAll(0);
+   finishPendingSscpMessages();
+
+   // Cleanup IpcEnvironment","We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0.",Did this change beca
+1759,"@@ -252,6 +252,13 @@ func Compile(pkgName string, machine llvm.TargetMachine, config *compileopts.Con
+
+ 	c.loadASTComments(lprogram)
+
++	// Forcibly preload special types.
++	runtimePkg := c.ir.Program.ImportedPackage(""runtime"")
++	c.getLLVMType(runtimePkg.Type(""_interface"").Type())
++	c.getLLVMType(runtimePkg.Type(""_string"").Type())
++	c.getLLVMType(runtimePkg.Type(""hashmap"").Type())
++	c.getLLVMType(runtimePkg.Type(""channel"").Type())
++
+ 	// Declare runtime types.
+ 	// TODO: lazily create runtime types in getLLVMRuntimeType when they are
+ 	// needed. Eventually this will be required anyway, when packages are",Is this really necessary? I would expect these types to be included with the loop below.,Shouldn't we do a ch
+1760,"@@ -41,8 +41,17 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+
+             traceId.CopyTo(bytes);
+
+-            this.High = BitConverter.ToInt64(bytes, 0);
+-            this.Low = BitConverter.ToInt64(bytes, 8);
++            if (BitConverter.IsLittleEndian)
++            {
++                Array.Reverse(bytes);
++                this.High = BitConverter.ToInt64(bytes, 8);
++                this.Low = BitConverter.ToInt64(bytes, 0);
++            }
++            else
++            {
++                this.High = BitConverter.ToInt64(bytes, 0);
++                this.Low = BitConverter.ToInt64(bytes, 8);
++            }
+         }
+
+         public long High { get; set; }",You could do span<byte> and it's magic of typecast to int for better efficiency,Is this different than what you were trying to do? Is there a different method?
+1761,"@@ -87,8 +87,9 @@ Object.keys(rulesGroupByDocumentFragment).forEach(key => {
+ 				return;
+ 			}
+
+-			// check if transform style exists
+-			const transformStyleValue = cssRule.style.transform || false;
++			// check if transform style exists (don't forget vendor prefixes)
++			const transformStyleValue =
++				cssRule.style.transform || cssRule.style.webkitTransform || false;
+ 			// transformStyleValue -> is the value applied to property
+ 			// eg: ""rotate(-90deg)""
+ 			if (!transformStyleValue) {","Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?",What's the point of this check?
+1762,"@@ -241,15 +241,10 @@ namespace MvvmCross.Droid.Support.V7.RecyclerView
+
+         protected virtual void OnItemsSourceCollectionChanged(object sender, NotifyCollectionChangedEventArgs e)
+         {
+-            if (Looper.MainLooper == Looper.MyLooper())
+-            {
+-                NotifyDataSetChanged(e);
+-            }
+-            else
+-            {
+-                var h = new Handler(Looper.MainLooper);
+-                h.Post(() => NotifyDataSetChanged(e));
+-            }
++            if (Looper.MainLooper != Looper.MyLooper())
++                MvxBindingLog.Error(""All collection changes "");
++
++            NotifyDataSetChanged(e);
+         }
+
+         public virtual void NotifyDataSetChanged(NotifyCollectionChangedEventArgs e)",Is there something missing from the message here?,Wouldn't it be better to use a generic `nameof` instead of the generic `nameof`
+1763,"@@ -48,3 +48,14 @@ from luigi import event
+ from luigi.event import Event
+
+ from .tools import range  # just makes the tool classes available from command line
++
++
++__all__ = [
++    'task', 'Task', 'Config', 'ExternalTask', 'WrapperTask', 'namespace',
++    'target', 'Target', 'File', 'LocalTarget', 'rpc', 'RemoteScheduler',
++    'RPCError', 'parameter', 'Parameter', 'DateParameter', 'MonthParameter',
++    'YearParameter', 'DateHourParameter', 'DateMinuteParameter', 'range',
++    'DateIntervalParameter', 'TimeDeltaParameter', 'IntParameter',
++    'FloatParameter', 'BooleanParameter', 'BoolParameter', 'TaskParameter',
++    'configuration', 'interface', 'file', 'run', 'build', 'event', 'Event'
++]","Hmm, what does this syntax mean?",Do we need to expose these to public API?
+1764,"@@ -98,7 +98,12 @@ func (r *nDCActivityReplicatorImpl) SyncActivity(
+ 		RunId:      request.RunId,
+ 	}
+
+-	context, release, err := r.historyCache.getOrCreateWorkflowExecution(ctx, namespaceID, execution)
++	context, release, err := r.historyCache.getOrCreateWorkflowExecution(
++		ctx,
++		namespaceID,
++		execution,
++		callerTypeAPI,
++	)
+ 	if err != nil {
+ 		// for get workflow execution context, with valid run id
+ 		// err will not be of type EntityNotExistsError",should this be callerTypeTask?,i am not sure if we need to pass in the callerTypeAPI here
+1765,"@@ -56,6 +56,10 @@ class PlanPolicy < ApplicationPolicy
+     @plan.administerable_by?(@user.id)
+   end
+
++  def set_test?
++    @plan.administerable_by?(@user.id)
++  end
++
+ # TODO: These routes are no lonmger used
+ =begin
+   def section_answers?","Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details",Naming/UncommunicativeMethodParamName: Method parameter mu
+1766,"@@ -47,8 +47,7 @@ namespace Nethermind.Blockchain
+         private readonly LruCache<Keccak, BlockHeader> _headerCache = new LruCache<Keccak, BlockHeader>(CacheSize);
+         private readonly LruCache<long, ChainLevelInfo> _blockInfoCache = new LruCache<long, ChainLevelInfo>(CacheSize);
+
+-        private const int MaxQueueSize = 10_000_000;
+-
++        private const int BestKnownSearchLimit = 256_000_000;
+         public const int DbLoadBatchSize = 4000;
+
+         private long _currentDbLoadBatchEnd;","Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?",why not `128_000_000` ?
+1767,"@@ -66,6 +66,7 @@ public class HiveTableBaseTest extends HiveMetastoreTest {
+     tableLocation.getFileSystem(hiveConf).delete(tableLocation, true);
+     catalog.dropTable(TABLE_IDENTIFIER, false /* metadata only, location was already deleted */);
+   }
++
+   private static String getTableBasePath(String tableName) {
+     String databasePath = metastore.getDatabasePath(DB_NAME);
+     return Paths.get(databasePath, tableName).toAbsolutePath().toString();",Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?,minor: I don't think we need this change
+1768,"@@ -66,7 +66,7 @@ function HelpMenu( { children } ) {
+
+ 	const handleMenuSelected = useCallback( () => {
+ 		toggleMenu( false );
+-	} );
++	}, [] );
+
+ 	return (
+ 		<div className=""googlesitekit-dropdown-menu googlesitekit-dropdown-menu__icon-menu googlesitekit-help-menu mdc-menu-surface--anchor"">","There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now",Hmm. Why is this needed?
+1769,"@@ -33,6 +33,7 @@ const (
+ 	BalanceRecord     HashID = ""BR""
+ 	Credential        HashID = ""CR""
+ 	Genesis           HashID = ""GE""
++	Logic             HashID = ""LO""
+ 	Message           HashID = ""MX""
+ 	NetPrioResponse   HashID = ""NPR""
+ 	OneTimeSigKey1    HashID = ""OT1""","This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses.",I am not convinced that
+1770,"@@ -0,0 +1,8 @@
++from django.test import TestCase
++from graphite.worker_pool.pool import stop_pool
++
++
++class BaseTestCase(TestCase):
++
++  def tearDown(self):
++    stop_pool()","nit: you could have named it just ""TestCase"" (if django's TestCase was imported differently)",It should be `TestCase`
+1771,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.,Omit parentheses for met
+1772,"@@ -42,7 +42,6 @@ std::string lldb_private::formatters::swift::SwiftOptionalSummaryProvider::
+ // retrieve the value of the Some case..
+ static PointerOrSP
+ ExtractSomeIfAny(ValueObject *optional,
+-                 lldb::DynamicValueType dynamic_value = lldb::eNoDynamicValues,
+                  bool synthetic_value = false) {
+   if (!optional)
+     return nullptr;","All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?",Could you please explain why this change is needed? Is it related to the rest of the PR?
+1773,"@@ -109,7 +109,8 @@ def main():
+     logger.info('Environment info:\n' + dash_line + env_info + '\n' +
+                 dash_line)
+     meta['env_info'] = env_info
+-
++    meta['config_dict'] = dict(cfg)
++    meta['config_file'] = args.config
+     # log some basic info
+     logger.info(f'Distributed training: {distributed}')
+     logger.info(f'Config:\n{cfg.pretty_text}')",Better to use the absolute path.,why do we need to store the config_dict in the meta? can we just access the config_file
+1774,"@@ -45,8 +45,8 @@ const (
+ 	// VoucherInterval defines how many block pass before creating a new voucher
+ 	VoucherInterval = 1000
+
+-	// ChannelExpiryBuffer defines how long the channel remains open past the last voucher
+-	ChannelExpiryBuffer = 2000
++	// ChannelExpiryInterval defines how long the channel remains open past the last voucher
++	ChannelExpiryInterval = 2000
+
+ 	// CreateChannelGasPrice is the gas price of the message used to create the payment channel
+ 	CreateChannelGasPrice = 0","this is 16 hours, is that enough?",What's the reason for this change?
+1775,"@@ -0,0 +1,16 @@
++package tracing
++
++import (
++	""context""
++
++	""go.opencensus.io/trace""
++)
++
++// AddErrorEndSpan will end `span` and adds `err` to `span` iff err is not nil.
++// This is a helper method to cut down on boiler plate.
++func AddErrorEndSpan(ctx context.Context, span *trace.Span, err *error) {
++	if *err != nil {
++		span.AddAttributes(trace.StringAttribute(""error"", (*err).Error()))
++	}
++	span.End()
++}",  removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes.,Should we also check for `err == nil`?
+1776,"@@ -71,9 +71,10 @@ func (b *EthAPIBackend) GetEthContext() (uint64, uint64) {
+ 	return bn, ts
+ }
+
+-func (b *EthAPIBackend) GetRollupContext() (uint64, uint64) {
++func (b *EthAPIBackend) GetRollupContext() (uint64, uint64, uint64) {
+ 	i := uint64(0)
+ 	q := uint64(0)
++	v := uint64(0)
+ 	index := b.eth.syncService.GetLatestIndex()
+ 	if index != nil {
+ 		i = *index",Can you replace these single letter variables with full names?,Can we call this something more descriptive? `RollupVersion` or something?
+1777,"@@ -1,13 +1,16 @@
+ // Copyright (c) .NET Foundation. All rights reserved.
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
++using System;
+ using System.IO;
++using Microsoft.AspNet.Http.Features;
+
+ namespace Microsoft.AspNet.Server.Kestrel.Filter
+ {
+     public class ConnectionFilterContext
+     {
+         public ServerAddress Address { get; set; }
+-        public Stream Connection { get; set;  }
++        public Stream Connection { get; set; }
++        public Action<IFeatureCollection> PrepareRequest { get; set; }
+     }
+ }","At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context.",Does this need to be public? Does this need to be public?
+1778,"@@ -679,9 +679,9 @@ class Upgrade
+         // Eliminate obsolete config override settings:
+         unset($newConfig['Extra_Config']);
+
+-        // Update generator if it is default value:
++        // Update generator if it contains a version number:
+         if (isset($newConfig['Site']['generator'])
+-            && $newConfig['Site']['generator'] == 'VuFind ' . $this->from
++            && preg_match('/^VuFind (\d+\.?)+$/', $newConfig['Site']['generator'])
+         ) {
+             $newConfig['Site']['generator'] = 'VuFind ' . $this->to;
+         }","Would it be too greedy to preg_replace `VuFind (\d+\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is.",What does the `.` in `(\d+\.?)+` do exactly?
+1779,"@@ -91,7 +91,7 @@ public abstract class ManagedResourceStorage {
+       zkClient = ((ZkSolrResourceLoader)resourceLoader).getZkController().getZkClient();
+       try {
+         zkConfigName = ((ZkSolrResourceLoader)resourceLoader).getZkController().
+-            getZkStateReader().readConfigName(collection);
++            getZkStateReader().getClusterState().getCollection(collection).getConfigName();
+       } catch (Exception e) {
+         log.error(""Failed to get config name due to"", e);
+         throw new SolrException(ErrorCode.SERVER_ERROR,","BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state.",Isn't it better to get the config name from the collection object? That wa
+1780,"@@ -191,7 +191,10 @@ public class FindFiles {
+       Snapshot snapshot = snapshotId != null ?
+           ops.current().snapshot(snapshotId) : ops.current().currentSnapshot();
+
+-      CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, snapshot.manifests())
++      // snapshot could be null when the table just gets created
++      Iterable<ManifestFile> manifests = (snapshot != null) ? snapshot.manifests() : CloseableIterable.empty();
++
++      CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, manifests)
+           .filterData(rowFilter)
+           .filterFiles(fileFilter)
+           .filterPartitions(partitionFilter)","If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable.",I think you can skip the null check and just do `snapshot != null ? snapshot.manifests() : CloseableIterable.empty();`
+1781,"@@ -0,0 +1,11 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.codestyle;
++
++import net.sourceforge.pmd.testframework.PmdRuleTst;
++
++public class ArrayInitializationVerbosenessRuleTest extends PmdRuleTst {
++  // no additional unit tests
++}",this class should be named `ArrayInitializationVerbosenessTest` to work,Is there a reason why this class isn't named `ArrayInitializationVerbosenessRuleTest.java`?
+1782,"@@ -338,9 +338,17 @@ module Bolt
+
+     private def update_logs(logs)
+       logs.each_with_object({}) do |(key, val), acc|
+-        next unless val.is_a?(Hash)
++        # Remove any disabled logs
++        next if val == 'disable'
+
+         name = normalize_log(key)
++
++        # But otherwise it has to be a Hash
++        unless val.is_a?(Hash)
++          raise Bolt::ValidationError,
++                ""config of log #{name} must be a Hash, received #{val.class} #{val.inspect}""
++        end
++
+         acc[name] = val.slice('append', 'level')
+                        .transform_keys(&:to_sym)
+ ",Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`.,"This check feels pretty brittle, but I can't think of a better way to check if the value is `true` or `false`"
+1783,"@@ -44,6 +44,7 @@ func TestAddrsNewAndList(t *testing.T) {
+
+ func TestWalletBalance(t *testing.T) {
+ 	tf.IntegrationTest(t)
++	t.Skip(""not working"")
+ 	ctx := context.Background()
+
+ 	builder := test.NewNodeBuilder(t)",It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip.,why is this disabled?
+1784,"@@ -85,9 +85,13 @@ export default function LegacyAdSenseDashboardWidgetOverview( props ) {
+ 			}
+ 		}
+ 	}, [
+-		currentDataLoaded && previousDataLoaded, // All reports are fetched.
+-		!! currentError || !! previousError, // Whether there is an error or not.
+-		JSON.stringify( currentRangeData ),
++		currentDataLoaded,
++		currentError,
++		currentRangeData,
++		handleDataError,
++		handleDataSuccess,
++		previousDataLoaded,
++		previousError,
+ 	] );
+
+ 	if ( ! currentDataLoaded || ! previousDataLoaded ) {",As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that),Can you add a trailing comma to make diffs easier to read?
+1785,"@@ -47,12 +47,13 @@
+
+ namespace lbann {
+
+-lbann_comm* initialize(int& argc, char**& argv, int seed) {
++world_comm_ptr initialize(int& argc, char**& argv, int seed) {
+   // Initialize Elemental.
+   El::Initialize(argc, argv);
+   // Create a new comm object.
+   // Initial creation with every process in one model.
+-  auto* comm = new lbann_comm(0);
++  auto comm = world_comm_ptr{new lbann_comm(0), &lbann::finalize };
++
+ #if defined(LBANN_TOPO_AWARE)
+   // Determine the number of NUMA nodes present.
+   hwloc_topology_t topo;",Should we be doing this with `make_unique` or something?,Why not just make this `auto* comm = new lbann_comm(0);`?
+1786,"@@ -35,9 +35,11 @@ class ProposalMailer < ApplicationMailer
+     )
+   end
+
+-  def proposal_updated_no_action_required(user, proposal, modifier = nil)
++  def proposal_updated_no_action_required(user = User.last, proposal = Proposal.last, modifier = nil)
+     @proposal = proposal.decorate
+     @modifier = modifier || NullUser.new
++    # Example ideal data to consume
++    @changes = [{verb: 'modified', result: 'this to that'},{verb: 'added', result: 'that'},{verb: 'modified', result: 'this to that'}]
+     assign_threading_headers(@proposal)
+
+     mail(","we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier.",Space inside { missing.<br>Space inside } missing.
+1787,"@@ -14,9 +14,10 @@ import (
+ 	""strconv""
+ 	""strings""
+
++	""go/parser""
++
+ 	""github.com/aykevl/go-llvm""
+ 	""github.com/aykevl/tinygo/ir""
+-	""go/parser""
+ 	""golang.org/x/tools/go/loader""
+ 	""golang.org/x/tools/go/ssa""
+ )","Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated.",Let's sort imports :-)
+1788,"@@ -106,7 +106,7 @@ import javax.lang.model.element.Name;
+ @AutoService(BugChecker.class)
+ @BugPattern(
+         name = ""StrictUnusedVariable"",
+-        altNames = {""unused"", ""StrictUnusedVariable""},
++        altNames = {""unused"", ""UnusedVariable""},
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+         summary = ""Unused."",",It's unnecessary to duplicate the `name`.,Why are we changing the test name? It's not clear what this test is testing.
+1789,"@@ -68,7 +68,7 @@ final class MediaType extends AbstractType implements LoggerAwareInterface
+         $builder->addModelTransformer($dataTransformer);
+
+         $builder->addEventListener(FormEvents::SUBMIT, static function (FormEvent $event): void {
+-            if ($event->getForm()->has('unlink') && null !== $event->getForm()->get('unlink')->getData()) {
++            if ($event->getForm()->has('unlink') && true === $event->getForm()->get('unlink')->getData()) {
+                 $event->setData(null);
+             }
+         });",this was a mistake when adding phpstan strict plugin,`true ===` is useless here.
+1790,"@@ -197,6 +197,14 @@ export function diffChildren(
+
+ 						newParentVNode._nextDom = oldDom;
+ 					}
++				} else if (
++					oldDom &&
++					oldVNode._dom == oldDom &&
++					oldDom.parentNode != parentDom
++				) {
++					// The above condition is handle null placeholders. See test in placeholder.test.js:
++					// `efficiently replace null placeholders in parent rerenders`
++					oldDom = getDomSibling(oldVNode);
+ 				}
+ 			}
+ ",Nit: I think it should be `to handle` here.,shouldn't this be `getDOMNode(oldVNode)`?
+1791,"@@ -2810,7 +2810,7 @@ public class MessagingController implements Runnable {
+
+                     LocalMessage message = localFolder.getMessage(uid);
+                     if (message == null
+-                    || message.getId() == 0) {
++                            || message.getId() == 0) {
+                         throw new IllegalArgumentException(""Message not found: folder="" + folder + "", uid="" + uid);
+                     }
+                     // IMAP search results will usually need to be downloaded before viewing.",Please don't make unrelated changes or let your tools make unrelated changes.,please change to `|| message == null`
+1792,"@@ -18,7 +18,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ )
+
+-var numAccounts int
++var numAccounts uint
+
+ // accountCreateCmd represents the account create command
+ var accountCreateCmd = &cobra.Command{",`numAccounts` is a global variable (from `gochecknoglobals`),If you change the type to uint then you no longer need the conversion at all?
+1793,"@@ -855,6 +855,9 @@ class PluginManager
+         if ($pluginPath = self::instance()->getPluginPath($id)) {
+             File::deleteDirectory($pluginPath);
+         }
++
++        // actually remove the plugin from our internal container
++        unset($this->plugins[$id]);
+     }
+
+     /**",Is the ID correctly normalized at this point?,Why did you move this?
+1794,"@@ -0,0 +1,11 @@
++package commands
++
++import (
++	""context""
++
++	""github.com/ledgerwatch/erigon/p2p""
++)
++
++func (api *ErigonImpl) NodeInfo(ctx context.Context) ([]p2p.NodeInfo, error) {
++	return api.ethBackend.NodeInfo(ctx, 0)
++}","if 0 is a special constant meaning ""no limit"" let's make it a constant and name it correctly :)",The Ethereum package should be named `cmd/erigon`
+1795,"@@ -140,8 +140,8 @@ func run(ctx context.Context) {
+ 		} else {
+ 			setOsConfig(resp)
+ 			setPatchPolicies(resp.PatchPolicies)
+-			runInventory()
+ 		}
++		runInventory()
+
+ 		select {
+ 		case <-ticker.C:",Curious about the reason behind this change,Why did this move?
+1796,"@@ -18,7 +18,7 @@ func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) (err error) {
+ 	// Put block in storage wired to an exchange so this node and other
+ 	// nodes can fetch it.
+ 	log.Debugf(""putting block in bitswap exchange: %s"", b.Cid().String())
+-	blkCid, err := node.OnlineStore.Put(ctx, b)
++	blkCid, err := node.cborStore.Put(ctx, b)
+ 	if err != nil {
+ 		return errors.Wrap(err, ""could not add new block to online storage"")
+ 	}","wait, i thought the cborstore was for state tree?",Could we rename `cborStore` to `onlineStore`?
+1797,"@@ -1101,7 +1101,19 @@ class Package(object):
+
+         self._fix_sha256()
+         pkg = self._materialize(dest)
++
++        def physical_key_is_temp_file(pk):
++            if not file_is_local(pk):
++                return False
++            return pathlib.Path(parse_file_url(urlparse(pk))).parent == APP_DIR_TEMPFILE_DIR
++        temp_file_logical_keys = [lk for lk, entry in self.walk() if physical_key_is_temp_file(entry.physical_keys[0])]
++
+         self._delete_temporary_files()  # Now that data has been pushed, delete tmp files created by pkg.set('KEY', obj)
++
++        # Update old package to point to the materialized location of the file since the tempfile no longest exists
++        for lk in temp_file_logical_keys:
++            self.set(lk, pkg[lk])
++
+         pkg.build(name, registry=registry, message=message)
+         return pkg
+ ","This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?","`self.set(k, v)` -> `self.set(k, v)`"
+1798,"@@ -25,6 +25,11 @@ import io.swagger.converter.ModelConverters;
+ import io.swagger.models.properties.Property;
+
+ public class DefaultResponseTypeProcessor implements ResponseTypeProcessor {
++  @Override
++  public Class<?> getResponseType() {
++    // not care for this.
++    return null;
++  }
+
+   @Override
+   public Property process(OperationGenerator operationGenerator) {",How about name it with NullResponseTypeProcessor,/cc @zhangyz-hd
+1799,"@@ -580,6 +580,8 @@ Dataset* DatasetLoader::CostructFromSampleData(double** sample_values,
+       BinType bin_type = BinType::NumericalBin;
+       if (categorical_features_.count(i)) {
+         bin_type = BinType::CategoricalBin;
++        bool feat_is_unconstrained = ((config_.monotone_constraints.size() == 0) || (config_.monotone_constraints[i] == 0));
++        CHECK(feat_is_unconstrained);
+       }
+       bin_mappers[i].reset(new BinMapper());
+       if (config_.max_bin_by_feature.empty()) {",Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly.,Use `config_.monotone_constraints.empty()` in
+1800,"@@ -575,7 +575,7 @@ class decimate(ElementOperation):
+        The x_range as a tuple of min and max y-value. Auto-ranges
+        if set to None."""""")
+
+-    def _process(self, element, key=None):
++    def _apply(self, element, key=None):
+         if not isinstance(element, Dataset):
+             raise ValueError(""Cannot downsample non-Dataset types."")
+         if element.interface not in column_interfaces:","Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays.",Please update the doc.
+1801,"@@ -131,6 +131,9 @@ const (
+
+ 	// MachineNameTagKey is the key for machine name.
+ 	MachineNameTagKey = ""MachineName""
++
++	// NodeRoleTagValue describes the value for the node role.
++	NodeRoleTagValue = ""node""
+ )
+
+ // ClusterTagKey generates the key for resources associated with a cluster.",Let's use this constant when ASG is created as well (currently hardcoded).,"By default, the node r"
+1802,"@@ -152,6 +152,10 @@ CREATE_PACKAGE_HASHES = textwrap.dedent(f""""""\
+     FROM named_packages
+ """""")
+
++# All GROUP BY statements are supposed to be:
++# - in the order from most unique values to least unique
++# - integers rather than strings
++
+ OBJECT_ACCESS_COUNTS = textwrap.dedent(""""""\
+     SELECT
+         eventname,",Oh is `bucket` actually higher cardinality than `eventname`?,Note that the SQL quer
+1803,"@@ -33,6 +33,7 @@ import sip
+ from PyQt5.QtCore import QUrl
+ # so it's available for :debug-pyeval
+ from PyQt5.QtWidgets import QApplication  # pylint: disable=unused-import
++from PyQt5.QtWebEngineWidgets import QWebEngineProfile  # pylint: disable=unused-import
+
+ from qutebrowser.browser import qutescheme
+ from qutebrowser.utils import log, objreg, usertypes, message, debug, utils",You can't rely on QtWebEngine being available - but why do you need to import this here at all?,Can this file be remov
+1804,"@@ -234,6 +234,12 @@ setup(
+ 		],
+ 		""packages"": [
+ 			""NVDAObjects"",
++			# As of py2exe 0.11.0.0 if the forcibly included package contains subpackages
++			# they need to  be listed explicitly (py2exe issue 113).
++			""NVDAObjects.IAccessible"",
++			""NVDAObjects.JAB"",
++			""NVDAObjects.UIA"",
++			""NVDAObjects.window"",
+ 			""virtualBuffers"",
+ 			""appModules"",
+ 			""comInterfaces"",",How did you determine these - and how can we be confident that nothing is missing?,I don't think you need to add `NVDAObjects.window` here. This is already included in `python_reference.rst`.
+1805,"@@ -0,0 +1,3 @@
++<h2>Workshops</h2>
++<h2>Videos</h2>
++<h2>Books</h2>",What is this page going to do that is different than the products index we already have?,"Should be ""Workshops"""
+1806,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.,Use 2 (not 4) spaces for indentation.
+1807,"@@ -3,9 +3,10 @@ module Travis
+     class Script
+       module Addons
+         class Deploy
+-          VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node]
++          VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node, :go]
+           USE_RUBY           = '1.9.3'
+-          attr_accessor :script, :config, :allow_failure
++          HASH_CONFIG_KEYS = [:s3_options]
++          attr_accessor :script, :hash_config, :config, :allow_failure
+
+           def initialize(script, config)
+             @silent = false",Is this intended to be here? Seems it belongs to a different PR.,Style/SymbolArray: Use %i or %I for an array of symbols.
+1808,"@@ -20,7 +20,7 @@ namespace Xunit.ConsoleClient
+         {
+             try
+             {
+-                SetConsoleForegroundColor(ConsoleColor.White);
++                Console.ForegroundColor = ConsoleColor.White;
+ #if !NETCORE
+                 var netVersion = Environment.Version;
+ #else","These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays",Why did you change this?
+1809,"@@ -58,7 +58,11 @@ logger = logging.getLogger('luigi-interface')
+
+ try:
+     import boto3
+-    client = boto3.client('ecs')
++    try:
++        import botocore.exceptions
++        client = boto3.client('ecs')
++    except botocore.exceptions.NoRegionError:
++        logger.warning('Your AWS config is missing Region information, ECSTask requires a working config.')
+ except ImportError:
+     logger.warning('boto3 is not installed. ECSTasks require boto3')
+ ",Umm... this isn't relevant to this PR,would `boto3.client('ecs
+1810,"@@ -24,6 +24,7 @@ namespace Xunit
+         Netcoreapp = 0x1000,
+         Uap = 0x2000,
+         UapAot = 0x4000,
+-        NetcoreCoreRT = 0x8000
++        NetcoreCoreRT = 0x8000,
++        All = ~0
+     }
+ }",While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0.,why is All needed now?
+1811,"@@ -0,0 +1,7 @@
++// Copyright 2021 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++// Package main provides the bee binary viper-cobra
++// command definitions.
++package main","Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands.",Don't need this file her
+1812,"@@ -7,15 +7,11 @@ const Router = Ember.Router.extend({
+ });
+
+ Router.map(function() {
+-  this.route('admin', {
+-    resetNamespace: true
+-  }, function() {
++  this.route('admin', function() {
+     this.route('address');
+     this.route('loaddb');
+     this.route('lookup', { path: '/' });
+-    this.route('users', {
+-      resetNamespace: true
+-    }, function() {
++    this.route('users', function() {
+       this.route('edit', { path: '/edit/:user_id' });
+     });
+     this.route('roles');","This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`",Isn't the `resetNamespace` option not needed anymore?
+1813,"@@ -150,4 +150,19 @@ return [
+
+     'secure' => false,
+
++    /*
++    |--------------------------------------------------------------------------
++    | Same-Site Cookies
++    |--------------------------------------------------------------------------
++    |
++    | This option determines how your cookies behave when cross-site requests
++    | take place, and can be used to mitigate CSRF attacks. By default, we
++    | do not enable this as other CSRF protection services are in place.
++    |
++    | Supported: ""lax"", ""strict""
++    |
++    */
++
++    'same_site' => null,
++
+ ];",Could you provide more information on what exactly each of those three options do?,Please add a period at the end of the sentence (we ar
+1814,"@@ -1,10 +1,12 @@
+ using System.Collections.Generic;
++using System;
+
+ namespace ScenarioMeasurement
+ {
+     public class LinuxTraceSession : ITraceSession
+     {
+-        public string TraceFilePath { get { return perfCollect?.TraceFilePath; } }
++        public string TraceFilePath {
++            get { return perfCollect?.TraceFilePath;} }
+         private PerfCollect perfCollect;
+         private Dictionary<TraceSessionManager.KernelKeyword, PerfCollect.KernelKeyword> kernelKeywords;
+         private Dictionary<TraceSessionManager.ClrKeyword, PerfCollect.ClrKeyword> clrKeywords;",Why this line break?,Please revert this file since there's no real change.
+1815,"@@ -27,6 +27,7 @@ import (
+ 	admissionregistrationv1 ""k8s.io/api/admissionregistration/v1""
+ 	""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions""
+ 	apiextensionsinstall ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/install""
++	apiextensionsv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+ 	v1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""",We're importing this twice with different aliases.,Why is this change needed?
+1816,"@@ -98,6 +98,7 @@ if __name__ == ""__main__"":
+                 ""grpcio-tools==1.32.0"",
+                 ""isort>=4.3.21,<5"",
+                 ""mock==3.0.5"",
++                ""pandera<0.8.0"",
+                 ""protobuf==3.13.0"",  # without this, pip will install the most up-to-date protobuf
+                 ""pylint==2.6.0"",
+                 ""pytest-cov==2.10.1"",",We should avoid adding a pandera dependency to Dagster itself.,I don't think we want to include `pandera` here.
+1817,"@@ -163,9 +163,16 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
+
+     public void setPermission(PostgrePrivilegeType privilegeType, boolean permit) {
+         for (ObjectPermission permission : permissions) {
+-            if (permission.privilegeType == privilegeType) {
++            if (permission.privilegeType != privilegeType) {
+                 if (permit) {
+                     permission.permissions |= GRANTED;
++                    ObjectPermission[] tempPermission = new ObjectPermission[this.permissions.length+1];
++                    for(int i = 0; i < this.permissions.length; i++) {
++                	tempPermission[i] = this.permissions[i];
++                    }
++                    tempPermission[this.permissions.length] = new ObjectPermission(privilegeType, permission.getGrantor(), permission.permissions);
++                    this.permissions = tempPermission;
++
+                 } else {
+                     permission.permissions = 0;
+                 }",Can be replaced with `org.jkiss.utils.ArrayUtils#add`.,"Sorry, I don't understand what this line is doin"
+1818,"@@ -653,7 +653,12 @@ public class ZkController implements Closeable {
+     customThreadPool.submit(() -> Collections.singleton(overseer).parallelStream().forEach(IOUtils::closeQuietly));
+
+     try {
+-      customThreadPool.submit(() -> electionContexts.values().parallelStream().forEach(IOUtils::closeQuietly));
++      customThreadPool.submit(() -> {
++        Collection<ElectionContext> values = electionContexts.values();
++        synchronized (electionContexts) {
++          values.forEach(IOUtils::closeQuietly);
++        }
++      });
+
+     } finally {
+ ","While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object.",`parallelStream()` is no longer used in the lamb
+1819,"@@ -335,6 +335,18 @@ func ValidateACMEChallengeSolverDNS01(p *cmacme.ACMEChallengeSolverDNS01, fldPat
+ 				if len(p.AzureDNS.TenantID) == 0 {
+ 					el = append(el, field.Required(fldPath.Child(""azureDNS"", ""tenantID""), """"))
+ 				}
++				if len(p.AzureDNS.ManagedIdentityClientID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS"", ""managedIdentityClientID""), ""managed identity can not be used at the same time as clientID, tenantID or clientSecret""))
++				}
++				if len(p.AzureDNS.ManagedIdentityResourceID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS"", ""managedIdentityResourceID""), ""managed identity can not be used at the same time as clientID, tenantID or clientSecret""))
++				}
++			} else {
++				// using managed identity
++				if len(p.AzureDNS.ManagedIdentityClientID) > 0 && len(p.AzureDNS.ManagedIdentityResourceID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS""), ""managedIdentityClientID and managedIdentityResourceID connot both be specified""))
++				}
++
+ 			}
+ 			// SubscriptionID must always be defined
+ 			if len(p.AzureDNS.SubscriptionID) == 0 {",Should these restrictions also be reflected in the API docs?,This is a breaking change. I don't think we can
+1820,"@@ -209,6 +209,13 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	// restore original request before invoking error handler chain (issue #3717)
++	origReq := r.Context().Value(OriginalRequestCtxKey).(http.Request)
++	r.Method = origReq.Method
++	r.RemoteAddr = origReq.RemoteAddr
++	r.RequestURI = origReq.RequestURI
++	cloneURL(origReq.URL, r.URL)
++
+ 	// prepare the error log
+ 	logger := errLog
+ 	if s.Logs != nil {",What about the request headers if someone uses `request_header`? :thinking:,we need to restore the original request URI as well
+1821,"@@ -54,7 +54,12 @@ func (r *ReconcileHiveConfig) deployExternalDNS(hLog log.FieldLogger, h *resourc
+ 	deployment := resourceread.ReadDeploymentV1OrDie(asset)
+
+ 	// Make AWS-specific changes to external-dns deployment
+-	deployment.Spec.Template.Spec.Containers[0].Args = append(deployment.Spec.Template.Spec.Containers[0].Args, ""--provider=aws"")
++	args := deployment.Spec.Template.Spec.Containers[0].Args
++	args = append(args, ""--provider=aws"")
++	for _, domain := range instance.Spec.ManagedDomains {
++		args = append(args, fmt.Sprintf(""--domain-filter=%s"", domain))
++	}
++	deployment.Spec.Template.Spec.Containers[0].Args = args
+
+ 	if len(instance.Spec.ExternalDNS.Image) > 0 {
+ 		deployment.Spec.Template.Spec.Containers[0].Image = instance.Spec.ExternalDNS.Image","Verify that external-dns allows setting this parameter multiple times (that it's not ""last one wins"").",We should probably validate that `len(instance.Spec
+1822,"@@ -80,6 +80,7 @@ class Docker(base.Base):
+               - nofile:262144:262144
+             dns_servers:
+               - 8.8.8.8
++            etc_hosts: ""{'host1.example.com': '10.3.1.5'}""
+             networks:
+               - name: foo
+               - name: bar",Maybe 2 host/ip values could be used in the example?,nit: missing trailing comma
+1823,"@@ -139,7 +139,9 @@ namespace Datadog.Trace.Tests.Sampling
+
+             var limiter = new RateLimiter(maxTracesPerInterval: intervalLimit);
+
+-            var traceContext = new TraceContext(Tracer.Instance);
++            var tracerInstance = new Tracer();
++
++            var traceContext = new TraceContext(tracerInstance);
+
+             var barrier = new Barrier(parallelism + 1);
+ ","We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`.",what is this `tracerInstance` for?
+1824,"@@ -89,7 +89,8 @@ int main(int argc, char *argv[]) {
+     lbann_data::Model *pb_model = pb.mutable_model();
+
+     auto model = build_model_from_prototext(argc, argv, pb_trainer, pb,
+-                                            comm.get(), opts, io_thread_pool, true);
++                                            comm.get(), opts, trainer->get_name(), io_thread_pool,
++                                            trainer->get_callbacks(), true);
+
+     if (opts->has_string(""create_tarball"")) {
+       return EXIT_SUCCESS;","IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?","AFAICT, trainer->get_name() is a unique name for each trainer."
+1825,"@@ -217,7 +217,7 @@ void ledger_processor::state_block (rai::state_block const & block_a)
+ void ledger_processor::state_block_impl (rai::state_block const & block_a)
+ {
+ 	auto hash (block_a.hash ());
+-	auto existing (ledger.store.block_exists (transaction, hash));
++	auto existing (ledger.store.block_exists (transaction, block_a.type (), hash));
+ 	result.code = existing ? rai::process_result::old : rai::process_result::progress; // Have we seen this block before? (Unambiguous)
+ 	if (result.code == rai::process_result::progress)
+ 	{",Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state,Is it possible to have a `type` property of the `state_block`?
+1826,"@@ -296,17 +296,8 @@ func pruneRepository(gopts GlobalOptions, repo restic.Repository) error {
+ 	}
+
+ 	if len(removePacks) != 0 {
+-		bar = newProgressMax(!gopts.Quiet, uint64(len(removePacks)), ""packs deleted"")
+-		bar.Start()
+-		for packID := range removePacks {
+-			h := restic.Handle{Type: restic.DataFile, Name: packID.String()}
+-			err = repo.Backend().Remove(ctx, h)
+-			if err != nil {
+-				Warnf(""unable to remove file %v from the repository\n"", packID.Str())
+-			}
+-			bar.Report(restic.Stat{Blobs: 1})
+-		}
+-		bar.Done()
++		Verbosef(""remove %d old packs\n"", len(removePacks))
++		DeleteFiles(gopts, repo, removePacks, restic.DataFile)
+ 	}
+
+ 	Verbosef(""done\n"")",As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?,`%d old packs` could be `%d new packs`
+1827,"@@ -35,7 +35,7 @@ return [
+     'digits'               => ':attribute 必须是 :digits 位的数字。',
+     'digits_between'       => ':attribute 必须是介于 :min 和 :max 位的数字。',
+     'dimensions'           => ':attribute 图片尺寸不正确。',
+-    'distinct'             => ':attribute 已經存在。',
++    'distinct'             => ':attribute 已经存在。',
+     'email'                => ':attribute 不是一个合法的邮箱。',
+     'exists'               => ':attribute 不存在。',
+     'file'                 => ':attribute 必须是文件。',",It should be simplified character. `` -> ``,Please don't make unrelated changes like this.
+1828,"@@ -33,5 +33,9 @@ namespace Nethermind.Trie
+         void VisitLeaf(TrieNode node, TrieVisitContext trieVisitContext, byte[] value = null);
+
+         void VisitCode(Keccak codeHash, TrieVisitContext trieVisitContext);
++
++        bool VisitAccounts => true;
++
++        int ParallelLevels => -1;
+     }
+ }","I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism",I'd like to see a test case for this as well
+1829,"@@ -20,7 +20,7 @@ import java.util.stream.Collector;
+ import static javaslang.collection.Comparators.naturalComparator;
+
+ /**
+- * An {@link HashMap}-based implementation of {@link Multimap}
++ * An {@link TreeMap}-based implementation of {@link Multimap}
+  *
+  * @param <K> Key type
+  * @param <V> Value type",'A' instead of 'An' here,It should be 'multimap' instead of 'multimap
+1830,"@@ -37,7 +37,7 @@ import (
+
+ const (
+ 	// DefaultTimeout is the default timeout used to make calls
+-	DefaultTimeout = 10 * time.Second
++	DefaultTimeout = time.Second * 10
+ 	// DefaultLongPollTimeout is the long poll default timeout used to make calls
+ 	DefaultLongPollTimeout = time.Minute * 3
+ )","Can you flip it back (here and in other places)? It is more natural to represent ""10 seconds"" as `10 * time.Second`.",why change this?
+1831,"@@ -133,6 +133,11 @@ def test_classifier(output, centers, client, listen_port):
+         centers=centers
+     )
+
++    X_1, y_1, w_1, dX_1, dy_1, dw_1 = _create_data(
++        objective='classification',
++        output='array'
++    )
++
+     params = {
+         ""n_estimators"": 10,
+         ""num_leaves"": 10","Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix.","I think you mean `array(wX1, y_1, dX1, w_1)`"
+1832,"@@ -0,0 +1,6 @@
++<div class=""text-box-wrapper"">
++  <div class=""text-box"">
++    <h3><%= t('.added_to_github_repo') %></h3>
++    <p>Give it a few seconds for the background job to work, and then <%= link_to 'check out the repo', @purchaseable.github_url %>.</p>
++  </div>
++</div>","To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places.","I think we should add a `<%= t('.github_repo', @purchaseable.github_url) %>` to the tag so it doesn't show up on mobile."
+1833,"@@ -1,6 +1,8 @@
+ package de.danoeh.antennapod.adapter;
+
+ import android.content.Context;
++import android.view.View;
++
+ import androidx.appcompat.app.AlertDialog;
+
+ import de.danoeh.antennapod.R;",Please revert the lines above. Not touching unrelated code keeps the git history clean.,Could you revert these unnecessary changes so they don't clutter up the diff
+1834,"@@ -0,0 +1,3 @@
++# Copyright (c) Open-MMLab. All rights reserved.
++
++__version__ = '2.3.0rc0'",`short_version` and `version_info`,Missing license header
+1835,"@@ -52,7 +52,7 @@ type TaskStateChange struct {
+ 	Reason string
+
+ 	// Task is a pointer to the task involved in the state change that gives the event handler a hook into storing
+-	// what status was sent.  This is used to ensure the same event is handled only once.
++	// what stats was sent.  This is used to ensure the same event is handled only once.
+ 	Task *Task
+ }
+ ",This is supposed to be `status`. Why did you change this?,"""This is used to ensure the same event is handled only once"" -> ""This is used to ensure the same event is handled only o"
+1836,"@@ -1,3 +1,6 @@
++// Copyright 2012-2017 Apcera Inc. All rights reserved.
++// Copyright 2018 Synadia Communications Inc. All rights reserved.
++
+ package server
+
+ import (",I will change all of these at some point next week.,nit: I don't think we need to include the copyright in the copyright.
+1837,"@@ -42,7 +42,7 @@ namespace Datadog.Trace.ClrProfiler
+         /// </summary>
+         public string TargetAssembly
+         {
+-            get => throw new NotSupportedException(""Use property TargetAssemblies instead of TargetAssembly."");
++            get => string.Empty;
+             set => TargetAssemblies = new[] { value };
+         }
+ ","I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging.",Is there any advantage to using `string.Empty` over `default!`?
+1838,"@@ -106,7 +106,8 @@ func determineDeploymentHealth(obj *unstructured.Unstructured) (status model.Kub
+ 	d := &appsv1.Deployment{}
+ 	err := scheme.Scheme.Convert(obj, d, nil)
+ 	if err != nil {
+-		desc = fmt.Sprintf(""Failed while convert %T to %T: %v"", obj, d, err)
++		status = model.KubernetesResourceState_OTHER
++		desc = fmt.Sprintf(""Unexpected error while calculating: failed while convert %T to %T: %v"", obj, d, err)
+ 		return
+ 	}
+ ","nit: `""Unexpected error while calculating: unable to convert %T to %T: %v""`",I think this should be model.KubernetesResourceState_DEPLOYMENT or mo
+1839,"@@ -87,6 +87,10 @@ public abstract class SampleConfig {
+   @JsonProperty(""packagePrefix"")
+   public abstract String packagePrefix();
+
++  /** Returns a sample application name. */
++  @JsonProperty(""appName"")
++  public abstract String appName();
++
+   /** Returns a map of method names to methods. */
+   @JsonProperty(""methods"")
+   public abstract Map<String, MethodInfo> methods();","I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer.","Maybe ""appName"" should be ""applicationName"" to be consistent with the"
+1840,"@@ -53,6 +53,8 @@ export * from './standalone';
+ export * from './storage';
+ export * from './i18n';
+ export * from './helpers';
++export * from './sort-object-map-by-key';
++export * from './convert-array-to-keyed-object-map';
+
+ /**
+  * Remove a parameter from a URL string.","Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files.",@zcbenz do you plan to export this as a separate PR?
+1841,"@@ -0,0 +1 @@
++require ""#{Rails.root}/app/models/acts_as_editable/acts_as_editable.rb""","Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_.",Prefer single-quoted strings when you don't need str
+1842,"@@ -23,6 +23,9 @@ public abstract class GrpcStreamingDetailView {
+
+   public abstract String methodName();
+
++  @Nullable
++  public abstract String upperCamelMethodName();
++
+   public abstract GrpcStreamingType grpcStreamingType();
+
+   @Nullable","I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation.",nit: remove `@Nullable`
+1843,"@@ -47,6 +47,13 @@
+ 		}                                                              \
+ 	} while (false);
+
++#define VALIDATE_NAME(_N)                                                      \
++	do {                                                                   \
++		if (_N[0] == '.' || _N[0] == '/') {                            \
++			FPGA_MSG(""%s is not a valid input"", _N);               \
++			return FPGA_INVALID_PARAM;                             \
++		}                                                              \
++	} while (false);
+
+ fpga_result __FPGA_API__ xfpga_fpgaTokenGetObject(fpga_token token, const char *name,
+ 						  fpga_object *object, int flags)","What if .. appears, but not as the first character, eg ""errors/../../../../../../../../../../../""?",This is not the right place to do this. `xfpga_fpgaT
+1844,"@@ -81,7 +81,7 @@ class Guidance < ActiveRecord::Base
+
+   # Returns whether or not a given user can view a given guidance
+   # we define guidances viewable to a user by those owned by a guidance group:
+-  #   owned by the managing curation center
++  #   owned by the default orgs
+   #   owned by a funder organisation
+   #   owned by an organisation, of which the user is a member
+   #","Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`",This is no longer true.
+1845,"@@ -122,6 +122,8 @@ public class AzkabanWebServer extends AzkabanServer {
+   private static final int MAX_FORM_CONTENT_SIZE = 10 * 1024 * 1024;
+   private static final String DEFAULT_TIMEZONE_ID = ""default.timezone.id"";
+   private static final String DEFAULT_STATIC_DIR = """";
++
++  @Deprecated
+   private static AzkabanWebServer app;
+   private final VelocityEngine velocityEngine;
+ ",why not removing it?,Why are you deprecating
+1846,"@@ -84,9 +84,9 @@ func NewCliApp() *cli.App {
+ 			EnvVar: ""TEMPORAL_CLI_TLS_CA"",
+ 		},
+ 		cli.BoolFlag{
+-			Name:   FlagTLSEnableHostVerification,
+-			Usage:  ""validates hostname of temporal cluster against server certificate"",
+-			EnvVar: ""TEMPORAL_CLI_TLS_ENABLE_HOST_VERIFICATION"",
++			Name:   FlagTLSDisableHostVerification,
++			Usage:  ""whether to validates hostname of temporal cluster against server certificate"",
++			EnvVar: ""TEMPORAL_CLI_TLS_DISABLE_HOST_VERIFICATION"",
+ 		},
+ 		cli.StringFlag{
+ 			Name:   FlagTLSServerName,","same nit here: maybe word as - ""disables validation of the temporal cluster's server certificate""",I think we should keep
+1847,"@@ -59,6 +59,7 @@ public class TestFlinkCatalogDatabase extends FlinkCatalogTestBase {
+   @Test
+   public void testDefaultDatabase() {
+     sql(""USE CATALOG %s"", catalogName);
++    sql(""show tables"");
+
+     Assert.assertEquals(""Should use the current catalog"", getTableEnv().getCurrentCatalog(), catalogName);
+     Assert.assertEquals(""Should use the configured default namespace"",",Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?,Why does this test need
+1848,"@@ -60,7 +60,7 @@ static bool is_a_code_line (const unsigned char *line)
+
+ static bool isLuaIdentifier (char c)
+ {
+-	return (bool) !(isspace(c)  || c == '(' || c == ')' || c == '=');
++	return (bool) !(isspace(c)  || c == '(' || c == ')' || c == '=' || c == '.' || c == ':');
+ }
+
+ static void extract_next_token (const char *begin, const char *end_sentinel, vString *name)","Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log.",can you do `isspace(c) || c == ':' || c == ']'` ?
+1849,"@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
+ 		c.VXLANMTU = hostMTU - vxlanMTUOverhead
+ 	}
+ 	if c.Wireguard.MTU == 0 {
+-		if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == ""WorkloadIPs"" {
++		if c.Wireguard.EncryptHostTraffic {
+ 			// The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes,
+ 			// see https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-tcpip-performance-tuning#azure-and-vm-mtu
+ 			// for details.",This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS.,Does this change belong in this PR?
+1850,"@@ -71,7 +71,7 @@ var (
+
+ const (
+ 	projectFlagDescription  = ""Name of the project.""
+-	appFlagDescription      = ""Name of the application.""
++	svcFlagDescription      = ""Name of the service.""
+ 	envFlagDescription      = ""Name of the environment.""
+ 	pipelineFlagDescription = ""Name of the pipeline.""
+ 	profileFlagDescription  = ""Name of the profile.""",Do we need to change this flag as well?,Thanks for updating the description. Shouldn't th
+1851,"@@ -10,7 +10,9 @@ module.exports = function (grunt) {
+ 				return grunt.file.read(fn);
+ 			}).join('\n');
+
+-			grunt.file.write(fileset.dest, 'exports.source = ' + JSON.stringify(source) + ';');
++			var file = grunt.file.read(fileset.dest);
++
++			grunt.file.write(fileset.dest, file + 'module.exports.source = ' + JSON.stringify(source) + ';');
+ 		});
+ 	});
+ };",Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?,shouldn't this be `JSON.stringify(source)`?
+1852,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",Should this be `nameOrHandle`?
+1853,"@@ -76,7 +76,15 @@ module Bolt
+       target = request['target']
+       plan_vars = shadow_vars('plan', request['plan_vars'], target['facts'])
+       target_vars = shadow_vars('target', target['variables'], target['facts'])
+-      topscope_vars = target_vars.merge(plan_vars)
++
++      # Merge plan vars with target vars, while maintaining the order of the plan
++      # vars. It's critical that the order of plan vars is not changed, as Puppet
++      # will deserialize the variables in the order they appear. Variables may
++      # contain local references to variables that appear earlier in a plan. If
++      # these variables are moved before the variable they reference, Puppet will
++      # be unable to deserialize the data and raise an error.
++      topscope_vars = target_vars.reject { |k, _v| plan_vars.key?(k) }.merge(plan_vars)
++
+       env_conf = { modulepath: request['modulepath'],
+                    facts: target['facts'],
+                    variables: topscope_vars }",Only one line of code? What a simple issue!,`variables: topscope_vars` ->
+1854,"@@ -111,10 +111,8 @@ func NewHandler(
+ 		status:          common.DaemonStatusInitialized,
+ 		config:          config,
+ 		tokenSerializer: common.NewProtoTaskTokenSerializer(),
+-		rateLimiter: quotas.NewDynamicRateLimiter(
+-			func() float64 {
+-				return float64(config.RPS())
+-			},
++		rateLimiter: quotas.NewDefaultIncomingDynamicRateLimiter(
++			func() float64 { return float64(config.RPS()) },
+ 		),
+ 	}
+ ",Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?,Does this make sense? Why not
+1855,"@@ -126,12 +126,14 @@ func (n *NetworkPolicyController) deleteCNP(old interface{}) {
+ 	n.deleteDereferencedAddressGroups(oldInternalNP)
+ }
+
+-// reprocessCNP is triggered by Namespace ADD/UPDATE/DELETE events when they impact the
+-// per-namespace rules of a CNP.
+-func (n *NetworkPolicyController) reprocessCNP(cnp *crdv1alpha1.ClusterNetworkPolicy) {
++// reprocessCNP is triggered when a CNP may be impacted by non-ClusterNetworkPolicy events, including Namespace events
++// (for per-namespace rules) and ClusterGroup events (for ClusterGroup reference).
++func (n *NetworkPolicyController) reprocessCNP(cnp *crdv1alpha1.ClusterNetworkPolicy, enqueueAppliedToGroup bool) {
+ 	key := internalNetworkPolicyKeyFunc(cnp)
+ 	n.internalNetworkPolicyMutex.Lock()
+ 	oldInternalNPObj, exist, _ := n.internalNetworkPolicyStore.Get(key)
++	// The internal NetworkPolicy may haven't been created yet. It's fine to skip processing this CNP as addCNP will
++	// create it eventually.
+ 	if !exist {
+ 		klog.V(2).Infof(""Cannot find the original internal NetworkPolicy, skip reprocessCNP"")
+ 		n.internalNetworkPolicyMutex.Unlock()","Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the ""old"" internalNP to `internalNetworkPolicyStore`.",Isn't the enqueueAppliedToGrou
+1856,"@@ -22,6 +22,11 @@ module CartsHelper
+     current_linear_approval?(cart, user)
+   end
+
++  # Todo: Move this to an NCR specific template?
++  def display_restart?(cart, user)
++    cart.ncr? && user == cart.requester && (cart.pending? || cart.rejected?)
++  end
++
+   def parallel_approval_is_pending?(cart, user)
+     return false unless cart.parallel?
+     if approval = Approval.find_by(cart_id: cart.id, user_id: user.id)",Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?,"Shouldn't we check for `user.can_edit_cart?` here? If that's the case, we might want to check for `user.can_edit_cart?`."
+1857,"@@ -45,6 +45,7 @@ module Mongoid
+         # @param [ Hash ] attributes The attributes hash to attempt to set.
+         # @param [ Hash ] options The options defined.
+         def initialize(association, attributes, options = {})
++          attributes = attributes&.to_h if attributes.respond_to?(:keys)
+           if attributes.respond_to?(:with_indifferent_access)
+             @attributes = attributes.with_indifferent_access.sort do |a, b|
+               a[0].to_i <=> b[0].to_i",What is the purpose of `&` on this line?,Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.
+1858,"@@ -58,5 +58,5 @@ export function isValidPropertySelection( value ) {
+  * @return {boolean} TRUE if the web data stream ID is valid, otherwise FALSE.
+  */
+ export function isValidWebDataStreamID( webDataStreamID ) {
+-	return typeof webDataStreamID === 'string' && /\d+/.test( webDataStreamID );
++	return typeof webDataStreamID === 'string' && /^[a-zA-Z0-9]+$/.test( webDataStreamID );
+ }","See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function.","I know it's not part of your changes, but I think we should consider making the regex a bit more stricter, e.g. `^[a-zA-"
+1859,"@@ -628,7 +628,12 @@ func (s *Server) createLeafNode(conn net.Conn, remote *leafNodeCfg) *client {
+
+ 		c.mu.Unlock()
+ 		// Error will be handled below, so ignore here.
+-		c.parse([]byte(info))
++		err = c.parse([]byte(info))
++		if err != nil {
++			c.Debugf(""Error reading remote leafnode's INFO: %s"", err)
++			c.closeConnection(ReadError)
++			return nil
++		}
+ 		c.mu.Lock()
+
+ 		if !c.flags.isSet(infoReceived) {",Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap.,why CloseConnection and not just return?
+1860,"@@ -313,6 +313,15 @@ def speakObjectProperties(obj,reason=controlTypes.REASON_QUERY,index=None,**allo
+ 	newPropertyValues['current']=obj.isCurrent
+ 	if allowedProperties.get('placeholder', False):
+ 		newPropertyValues['placeholder']=obj.placeholder
++	# When speaking an object due to a focus change, the 'selected' state should not be reported if only one item is selected.
++	# This is because that one item will be the focused object, and saying selected is redundant.
++	# Rather, 'unselected' will be spoken for an unselected object if 1 or more items are selected.
++
++	states=newPropertyValues.get('states')
++	if states is not None and reason==controlTypes.REASON_FOCUS:
++		if controlTypes.STATE_SELECTABLE in states and controlTypes.STATE_SELECTED in states and obj.selectionContainer and obj.selectionContainer.getSelectedItemsCount(2)==1:
++			states.discard(controlTypes.STATE_SELECTED)
++			states.discard(controlTypes.STATE_SELECTABLE)
+ 	#Get the speech text for the properties we want to speak, and then speak it
+ 	text=getSpeechTextForProperties(reason,**newPropertyValues)
+ 	if text:",Could you split these conditions up over multiple lines please.,use `and obj.selectionContainer.getSelectedItemsCount(2) == 1:`
+1861,"@@ -33,7 +33,7 @@ func (t *tag) parseJSONTag(structTag reflect.StructTag) {
+ }
+
+ func (t *tag) parseTagStr(tagStr string) {
+-	parts := strings.SplitN(tagStr, "","", 2)
++	parts := strings.SplitN(tagStr, "","", 3)
+ 	if len(parts) == 0 {
+ 		return
+ 	}",I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag.,Is there a reason we couldn't just use `strings.SplitN` here?
+1862,"@@ -69,10 +69,8 @@ services:
+     image: {{ .router_image }}:{{ .router_tag }}
+     container_name: nginx-proxy
+     ports:
+-      - ""80:80""
+-      - {{ .mailhogport }}:{{ .mailhogport }}
+-      - {{ .dbaport }}:{{ .dbaport }}
+-      - {{ .dbport }}:{{ .dbport }}
++      {{ range $port := .ports }}- ""{{ $port }}:{{ $port }}""
++      {{ end }}
+     volumes:
+       - /var/run/docker.sock:/tmp/docker.sock:ro
+ networks:","So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here  . The format of the ports directive is ""host:container"". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports.",I think this should be `{{ .ports }}` instead of `{{ .ports }}`
+1863,"@@ -1176,7 +1176,9 @@ func (s *ContextImpl) transitionLocked(request contextRequest) {
+ 		s.state = contextStateStopping
+ 		// The change in state should cause all write methods to fail, but just in case, set this also,
+ 		// which will cause failures at the persistence level
+-		s.shardInfo.RangeId = -1
++		if s.shardInfo != nil {
++			s.shardInfo.RangeId = -1
++		}
+ 		// This will cause the controller to remove this shard from the map and then call s.stop()
+ 		go s.closeCallback(s)
+ 	}","An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead.",will this lead to a nil pointer dereference if s.shardInfo is n
+1864,"@@ -960,3 +960,8 @@ func SessionInfoFromProtocol(session keybase1.Session) (SessionInfo, error) {
+ 		VerifyingKey:   verifyingKey,
+ 	}, nil
+ }
++
++// NodeMetadata has metadata about a node needed for higher level operations.
++type NodeMetadata struct {
++	LastWriter keybase1.UID
++}","Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?",can we put this in libkb/keybase/go?
+1865,"@@ -49,9 +49,9 @@ ewmh_client_update_hints(lua_State *L)
+         state[i++] = _NET_WM_STATE_MODAL;
+     if(c->fullscreen)
+         state[i++] = _NET_WM_STATE_FULLSCREEN;
+-    if(c->maximized_vertical)
++    if(c->maximized_vertical || c->maximized)
+         state[i++] = _NET_WM_STATE_MAXIMIZED_VERT;
+-    if(c->maximized_horizontal)
++    if(c->maximized_horizontal || c->maximized)
+         state[i++] = _NET_WM_STATE_MAXIMIZED_HORZ;
+     if(c->sticky)
+         state[i++] = _NET_WM_STATE_STICKY;","For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between.",Could you add a space after `if`? Th
+1866,"@@ -88,12 +88,6 @@ var (
+ 	prelude = []string{
+ 		""universe"",
+ 		""influxdata/influxdb"",
+-		""math"",
+-		""strings"",
+-		""regexp"",
+-		""date"",
+-		""json"",
+-		""http"",
+ 	}
+ 	preludeScope = &scopeSet{
+ 		packages: make([]*interpreter.Package, len(prelude)),","Why did you remove these packages from the prelude, will your new functions not work without this change?",These are no longer used in this fil
+1867,"@@ -36,10 +36,14 @@ GetProcessor::asyncProcess(PartitionID part,
+                            const std::vector<std::string>& keys) {
+     folly::Promise<std::pair<PartitionID, kvstore::ResultCode>> promise;
+     auto future = promise.getFuture();
++    std::vector<std::string> kvKeys;
++    std::transform(keys.begin(), keys.end(), std::back_inserter(kvKeys),
++                   [part](const auto& key) { return NebulaKeyUtils::kvKey(part, key); });
+
+-    executor_->add([this, p = std::move(promise), part, keys] () mutable {
++    executor_->add([this, p = std::move(promise), part, &keys,
++                    kvKeys = std::move(kvKeys)] () mutable {
+         std::vector<std::string> values;
+-        auto ret = this->kvstore_->multiGet(space_, part, keys, &values);
++        auto ret = this->kvstore_->multiGet(space_, part, kvKeys, &values);
+         if (ret == kvstore::ResultCode::SUCCEEDED) {
+             std::lock_guard<std::mutex> lg(this->lock_);
+             for (int32_t i = 0; i < static_cast<int32_t>(keys.size()); i++) {",We'd better reserve enough space before using kvKeys to avoid extra malloc.,Can this move be moved inside the `i
+1868,"@@ -213,3 +213,12 @@ func GetLocalPVType(pv *v1.PersistentVolume) string {
+ 	}
+ 	return """"
+ }
++
++// GetNodeHostname extracts the Hostname from the labels on the Node
++func GetNodeHostname(n *v1.Node) string {
++	hostname, found := n.Labels[KeyNodeHostname]
++	if found {
++		return hostname
++	}
++	return n.Name
++}",would it make sense to return empty or error if label doesn't exists?,Could we rename this to `GetHostNameFromLabel` or similar?
+1869,"@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
+ exports.rmDir = function(path) {
+   return new promise.Promise(function(fulfill, reject) {
+     var numAttempts = 0;
++    var maxAttempts = 5;
++    var attemptTimeout = 250;
+     attemptRm();
+     function attemptRm() {
+       numAttempts += 1;
+       rimraf(path, function(err) {
+         if (err) {
+-          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+-            attemptRm();
++          if (err.code === 'ENOTEMPTY' && numAttempts <= maxAttempts) {
++            setTimeout(attemptRm, attemptTimeout);
+             return;
+           }
+           reject(err);",Don't penalize everyone with 250ms delay b/c some machines have problems.,Let's use `ENOTEMPTY` as the default.
+1870,"@@ -119,6 +119,15 @@ func (s SortedCidSet) Equals(s2 SortedCidSet) bool {
+ 	return true
+ }
+
++// String returns a string listing the cids in the set.
++func (s SortedCidSet) String() string {
++	out := ""{""
++	for it := s.Iter(); !it.Complete(); it.Next() {
++		out = fmt.Sprintf(""%s %s"", out, it.Value().String())
++	}
++	return out + "" }""
++}
++
+ // MarshalJSON serializes the set to JSON.
+ func (s SortedCidSet) MarshalJSON() ([]byte, error) {
+ 	return json.Marshal(s.s)",Probably want a space after the second %s?,"change this to `return fmt.Sprintf(""%s %s"", out, s.String("
+1871,"@@ -206,7 +206,7 @@ func (h *historyArchiver) Get(
+ 	dirPath := URI.Path()
+ 	exists, err := directoryExists(dirPath)
+ 	if err != nil {
+-		return nil, serviceerror.NewInternal(err.Error())
++		return nil, serviceerror.NewUnavailable(err.Error())
+ 	}
+ 	if !exists {
+ 		return nil, serviceerror.NewInvalidArgument(archiver.ErrHistoryNotExist.Error())",This seems like an internal error still?,@deads2k I think we don't need to change internal toUnavai
+1872,"@@ -85,7 +85,7 @@ describe PurchasesController do
+
+       post :create, purchase: customer_params(stripe_token), product_id: product.to_param
+
+-      FakeStripe.should have_charged(1500).to('test@example.com').with_token(stripe_token)
++      expect(FakeStripe).to have_charged(1500).to('test@example.com').with_token(stripe_token)
+     end
+   end
+ ",Line is too long. [94/80],Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+1873,"@@ -125,10 +125,16 @@ func (a *ClusterIdentityAllocator) Run(stopCh <-chan struct{}) {
+ 	}
+ }
+
++type ClusterIdentity struct {
++	UUID uuid.UUID
++}
++
+ // ClusterIdentityProvider is an interface used to retrieve the cluster identity information (UUID),
+-// as provided by the user or generated by the Antrea Controller.
++// as provided by the user or generated by the Antrea Controller. It also returns the time at which
++// the antrea-cluster-identity was created, which can typically be considered as the time at which
++// Antrea was deployed to the cluster.
+ type ClusterIdentityProvider interface {
+-	Get() (uuid.UUID, error)
++	Get() (ClusterIdentity, time.Time, error)
+ }
+
+ type clusterIdentityProvider struct {","out of curiosity, why creating another struct to wrap it?",I'm wondering if we should call this `ClusterIdentity` instead of `ClusterIdentity`. My understandi
+1874,"@@ -9549,8 +9549,15 @@ bool Bot::UseDiscipline(uint32 spell_id, uint32 target) {
+ 			if(spells[spell_id].timer_id > 0 && spells[spell_id].timer_id < MAX_DISCIPLINE_TIMERS)
+ 				SetDisciplineRecastTimer(spells[spell_id].timer_id, spell.recast_time);
+ 		} else {
+-			uint32 remain = (GetDisciplineRemainingTime(this, spells[spell_id].timer_id) / 1000);
+-			GetOwner()->Message(Chat::White, ""%s can use this discipline in %d minutes %d seconds."", GetCleanName(), (remain / 60), (remain % 60));
++			uint32 remaining_time = (GetDisciplineRemainingTime(this, spells[spell_id].timer_id) / 1000);
++			GetOwner()->Message(
++				Chat::White,
++				fmt::format(
++					""{} can use this Discipline in {}."",
++					GetCleanName(),
++					ConvertSecondsToTime(remaining_time)
++				).c_str()
++			);
+ 			return false;
+ 		}
+ 	}",discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const.,"remain is not used anymore, can be removed"
+1875,"@@ -135,6 +135,7 @@ public abstract class ResourceDescriptorConfig {
+                       .setEntityId(nameMap.get(p).toUpperCamel())
+                       .setEntityName(overrideConfig.getEntityName())
+                       .setCommonResourceName(overrideConfig.getCommonResourceName())
++                      .setAssignedProtoFile(protoFile)
+                       .build();
+                 } else {
+                   return SingleResourceNameConfig.newBuilder()","I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace.",why are we adding this here?
+1876,"@@ -63,6 +63,8 @@ NATURAL_ORDER_COLUMN_NAME = ""__natural_order__""
+
+ HIDDEN_COLUMNS = {NATURAL_ORDER_COLUMN_NAME}
+
++SERIES_DEFAULT_NAME = ""0""
++
+
+ class InternalFrame(object):
+     """"""",How about `SPARK_DEFAULT_SERIES_NAME`?,Wouldn't it be better to have a constant called `DEFAULT_SERIES_DEFAULT_NAME`?
+1877,"@@ -36,9 +36,18 @@ public class TableProperties {
+   public static final String COMMIT_TOTAL_RETRY_TIME_MS = ""commit.retry.total-timeout-ms"";
+   public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes
+
+-  public static final String COMMIT_NUM_STATUS_CHECKS = ""commit.num-status-checks"";
++  public static final String COMMIT_NUM_STATUS_CHECKS = ""commit.status-checks.num-retries"";
+   public static final int COMMIT_NUM_STATUS_CHECKS_DEFAULT = 3;
+
++  public static final String COMMIT_STATUS_CHECKS_MIN_WAIT_MS = ""commit.status-check.min-wait-ms"";
++  public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L; // 1s
++
++  public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS = ""commit.status-check.max-wait-ms"";
++  public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L; // 1 minute
++
++  public static final String COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS = ""commit.status-check.total-timeout-ms"";
++  public static final long COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS_DEFAULT = 1800000; // 30 minutes
++
+   public static final String MANIFEST_TARGET_SIZE_BYTES = ""commit.manifest.target-size-bytes"";
+   public static final long MANIFEST_TARGET_SIZE_BYTES_DEFAULT = 8388608; // 8 MB
+ ","The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?","I think this is not necessary, as it is a unit of time. The default max wait t"
+1878,"@@ -6,6 +6,12 @@ var setupDatabase = require('./shared').setupDatabase;
+
+ describe('Authentication', function() {
+   before(function() {
++    const configuration = this.configuration;
++    if (configuration.usingUnifiedTopology()) {
++      // The unified topology does not currently support authentication
++      return this.skip();
++    }
++
+     return setupDatabase(this.configuration);
+   });
+ ",Side note: I'd love to see more of these fields exposed on configuration.,Why do we need this skip?
+1879,"@@ -5,7 +5,7 @@
+   contact_us = (Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url)
+   email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
+   user_name = User.find_by(email: @resource.email).nil? ?  @resource.email : User.find_by(email: @resource.email).name(false)
+-  inviter_name = @resource.is_a?(User) ? @resource.invited_by.name(false) : @resource.invited_by.name
++  inviter_name = @resource.invited_by.name
+ %>
+ <% FastGettext.with_locale FastGettext.default_locale do %>
+   <p>","In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?",This was changed to use the `User#invited_by` method which returns `nil` if `i
+1880,"@@ -33,6 +33,8 @@ public class MutableQbftConfigOptions extends MutableBftConfigOptions implements
+         qbftConfigOptions.getValidatorContractAddress().map(String::toLowerCase);
+   }
+
++  // TODO-lucas do I need to implement getStartBlock here?
++
+   @Override
+   public Optional<String> getValidatorContractAddress() {
+     return validatorContractAddress;","I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not.",Need to implement getStartBlock here as well.
+1881,"@@ -89,5 +89,10 @@ namespace Nethermind.JsonRpc
+         ///
+         /// </summary>
+         public const int ExecutionError = -32015;
++
++        /// <summary>
++        /// Request exceedes defined tracer timeout limit
++        /// </sumary>
++        public const int TracerTimeout = -32016;
+     }
+ }",what is the number thrown by Geth?,How is this different from `ExecutionError`?
+1882,"@@ -2036,8 +2036,8 @@ common.checkDatabaseConfigMatch = (apiConfig, frontendConfig) => {
+                 // mongodb0.example.com:27017
+                 let apiMongoHost = apiConfig.split(""/"")[2];
+                 let frontendMongoHost = frontendConfig.split(""/"")[2];
+-                let apiMongoDb = apiConfig.split(""/"")[3];
+-                let frontendMongoDb = frontendConfig.split(""/"")[3];
++                let apiMongoDb = apiConfig.split(""/"")[3].split('?')[0];
++                let frontendMongoDb = frontendConfig.split(""/"")[3].split('?')[0];
+                 if (apiMongoHost === frontendMongoHost && apiMongoDb === frontendMongoDb) {
+                     return true;
+                 }","This would still crash on malformed database connection string like ""test""",Is there a reason to use split here? Can't we
+1883,"@@ -0,0 +1,14 @@
++package interfaces
++
++import ""context""
++
++type pluginNameKey struct{}
++
++func PluginNameFromHostServiceContext(ctx context.Context) (string, bool) {
++	name, ok := ctx.Value(pluginNameKey{}).(string)
++	return name, ok
++}
++
++func WithPluginName(ctx context.Context, name string) context.Context {
++	return context.WithValue(ctx, pluginNameKey{}, name)
++}","it is not an interface, maybe we can move to another package?",Does this need to be exported?
+1884,"@@ -4,14 +4,15 @@ import { stopPropagation, stopImmediatePropagation, isImmediatePropagationStoppe
+ import { getEditorInstance } from './editors';
+ import EventManager from './eventManager';
+ import { EditorState } from './editors/_baseEditor';
++import { getParentWindow } from './helpers/dom/element';
+
+ class EditorManager {
+   /**
+    * @param {Handsontable} instance
+-   * @param {GridSettings} priv
++   * @param {GridSettings} tableMeta
+    * @param {Selection} selection
+    */
+-  constructor(instance, priv, selection) {
++  constructor(instance, tableMeta, selection) {
+     /**
+      * Instance of {@link Handsontable}
+      *",Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?,Shouldn't we also pass `tableMeta` to the constructor?
+1885,"@@ -13,7 +13,15 @@ import (
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ )
+
++func isCpuSet(cgroup *configs.Cgroup) bool {
++	return cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuMax != """"
++}
++
+ func setCpu(dirPath string, cgroup *configs.Cgroup) error {
++	if !isCpuSet(cgroup) {
++		return nil
++	}
++
+ 	// NOTE: .CpuShares is not used here. Conversion is the caller's responsibility.
+ 	if cgroup.Resources.CpuWeight != 0 {
+ 		if err := fscommon.WriteFile(dirPath, ""cpu.weight"", strconv.FormatUint(cgroup.Resources.CpuWeight, 10)); err != nil {",Not sure whether this validation is useful.,Should this be !isCpuSet(cgroup) instead?
+1886,"@@ -422,6 +422,17 @@ class PromptContainer(QWidget):
+         except UnsupportedOperationError:
+             pass
+
++    @cmdutils.register(instance='prompt-container', scope='window',
++                       modes=[usertypes.KeyMode.prompt])
++    def prompt_yank(self):
++        """"""Yank URLs or other data in prompts.""""""
++        question = self._prompt.question
++        s = None
++        if question and hasattr(question, 'yank_text'):
++            s = question.yank_text
++        utils.set_clipboard(s)
++        message.info(""Yanked download URL to clipboard: {}"".format(s))
++
+
+ class LineEdit(QLineEdit):
+ ","Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?",Please add a docstring.
+1887,"@@ -121,8 +121,10 @@ def buffer_s3response(s3response):
+             found_records = True
+         elif 'Progress' in event:
+             logger_.info(""select progress: %s"", event['Progress'].get('Details'))
++            print(event['Progress'].get('Details'))
+         elif 'Stats' in event:
+             logger_.info(""select stats: %s"", event['Stats'])
++            print(event['Stats'])
+         elif 'End' in event:
+             # End event indicates that the request finished successfully
+             end_event_received = True","If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead.",did you mean to add this print statement?
+1888,"@@ -115,7 +115,7 @@ func DefaultNodeOptions() *MobileNodeOptions {
+ 		EtherClientRPC:                  metadata.Testnet2Definition.EtherClientRPC,
+ 		FeedbackURL:                     ""https://feedback.mysterium.network"",
+ 		QualityOracleURL:                ""https://testnet2-quality.mysterium.network/api/v1"",
+-		IPDetectorURL:                   ""https://api.ipify.org/?format=json"",
++		IPDetectorURL:                   ""https://testnet2-location.mysterium.network/api/v1/location"",
+ 		LocationDetectorURL:             ""https://testnet2-location.mysterium.network/api/v1/location"",
+ 		TransactorEndpointAddress:       metadata.Testnet2Definition.TransactorAddress,
+ 		TransactorRegistryAddress:       metadata.Testnet2Definition.RegistryAddress,",We should drop ipify in all places i guess,"@andrewkroh this is the bug I was talking about. When I was talking about this, I noticed that the location detection URL was wrong. It should stay like it was."
+1889,"@@ -137,8 +137,8 @@ type ConsensusParams struct {
+ 	DownCommitteeSize      uint64
+ 	DownCommitteeThreshold uint64
+
+-	FilterTimeoutSmallLambdas             uint64
+-	FilterTimeoutPeriod0SmallLambdas      uint64
++	AgreementFilterTimeout        time.Duration
++	AgreementFilterTimeoutPeriod0 time.Duration
+
+ 	FastRecoveryLambda    time.Duration // time between fast recovery attempts
+ 	FastPartitionRecovery bool          // set when fast partition recovery is enabled","Add explanations around these variables - what do they mean, how they should be configured, etc.",Do we still need the `FilterTimeoutSmallLambdas` and `FilterTimeout0SmallLambdas` now?
+1890,"@@ -106,6 +106,11 @@ class SiteController < ApplicationController
+     @locale = params[:about_locale] || I18n.locale
+   end
+
++  def communities
++    OsmCommunityIndex::LocalChapter.add_to_i18n # this should be called on app init
++    @local_chapters = OsmCommunityIndex::LocalChapter.local_chapters
++  end
++
+   def export; end
+
+   def offline; end","One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website.",this probably should be local_chapters
+1891,"@@ -321,4 +321,16 @@ public interface GauntletConfig extends Config
+ 	{
+ 		return false;
+ 	}
++
++	@ConfigItem(
++			position = 21,
++			keyName = ""displayResources"",
++			name = ""Show raw resources gathered"",
++			description = ""Displays how much of each resource you have gathered."",
++			titleSection = ""resources""
++	)
++	default boolean displayGatheredResources()
++	{
++		return false;
++	}
+ }",To much tabs here (1 tab),"I'm not sure what the best position for this config is. It might make sense to move it into the `gather` section, but I'm not sure what the best position for it"
+1892,"@@ -135,12 +135,12 @@ public class ExecutionLogsDao {
+     }
+   }
+
+-  int removeExecutionLogsByTime(final long millis)
++  int removeExecutionLogsByTime(final long millis, final int recordCleanupLimit)
+       throws ExecutorManagerException {
+     final String DELETE_BY_TIME =
+-        ""DELETE FROM execution_logs WHERE upload_time < ?"";
++        ""DELETE FROM execution_logs WHERE upload_time < ? LIMIT ?"";
+     try {
+-      return this.dbOperator.update(DELETE_BY_TIME, millis);
++      return this.dbOperator.update(DELETE_BY_TIME, millis, recordCleanupLimit);
+     } catch (final SQLException e) {
+       logger.error(""delete execution logs failed"", e);
+       throw new ExecutorManagerException(",This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch.,Is there a reason to use an `int` instead of a `boolean`?
+1893,"@@ -1319,10 +1319,10 @@ func (s *timerQueueActiveTaskExecutorSuite) TestWorkflowTimeout_ContinueAsNew_Re
+ 	// need to override the workflow retry policy
+ 	executionInfo := mutableState.executionInfo
+ 	executionInfo.HasRetryPolicy = true
+-	executionInfo.WorkflowExpirationTime = s.now.Add(1000 * time.Second)
++	executionInfo.WorkflowExpirationTime = timestamp.TimeNowPtrUtcAddSeconds(1000)
+ 	executionInfo.MaximumAttempts = 10
+-	executionInfo.InitialInterval = 1
+-	executionInfo.MaximumInterval = 1
++	executionInfo.InitialInterval = timestamp.DurationFromSeconds(1)
++	executionInfo.MaximumInterval = timestamp.DurationFromSeconds(1)
+ 	executionInfo.BackoffCoefficient = 1
+
+ 	di := addWorkflowTaskScheduledEvent(mutableState)","I don't like this helper func :-). Yeah, definitely don't like.",why change this one?
+1894,"@@ -18,17 +18,7 @@ describe( 'PageSpeed Insights Activation', () => {
+ 	beforeAll( async () => {
+ 		await page.setRequestInterception( true );
+ 		useRequestInterception( ( request ) => {
+-			if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
+-				request.respond( { status: 200 } );
+-			} else if (
+-				request
+-					.url()
+-					.match(
+-						'google-site-kit/v1/modules/pagespeed-insights/data/pagespeed'
+-					)
+-			) {
+-				request.respond( { status: 200, body: JSON.stringify( {} ) } );
+-			} else if (
++			if (
+ 				request
+ 					.url()
+ 					.match(","Same here. This should remain unchanged. Please, add it back.",This method is no longer used.
+1895,"@@ -2052,6 +2052,9 @@ Collection.prototype.mapReduce = function(map, reduce, options, callback) {
+  */
+ Collection.prototype.initializeUnorderedBulkOp = function(options) {
+   options = options || {};
++  if (this.s.options.ignoreUndefined) {
++    options.ignoreUndefined = this.s.options.ignoreUndefined;
++  }
+   options.promiseLibrary = this.s.promiseLibrary;
+   return unordered(this.s.topology, this, options);
+ };",@kvwalker should this method have `ignoreUndefined` supported as an `option`?,Why not `options.ignoreUndefined = this.s.options.ignoreU
+1896,"@@ -52,10 +52,11 @@ func New(_ *any.Any, logger *zap.Logger, _ tally.Scope) (service.Service, error)
+ 		return nil, errors.New(""experiment store wrong type"")
+ 	}
+
+-	transformer := NewTransformer()
++	sugaredLogger := logger.Sugar()
++	transformer := NewTransformer(sugaredLogger)
+ 	return &storer{
+ 		client.DB(),
+-		logger.Sugar(),
++		sugaredLogger,
+ 		&transformer,
+ 	}, nil
+ }","we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?",why do you need to create a new transformer here?
+1897,"@@ -388,7 +388,6 @@ class ServerCallback(MessageCallback):
+         if not self._queue:
+             self._active = False
+             return
+-        self._queue = []
+         # Get unique event types in the queue
+         events = list(OrderedDict([(event.event_name, event)
+                                    for event in self._queue]).values())",Not evident from looking at this diff but the queue is already being cleared four lines below.,Why did you remove this?
+1898,"@@ -293,6 +293,16 @@ func (pool *TransactionPool) computeFeePerByte() uint64 {
+ // checkSufficientFee take a set of signed transactions and verifies that each transaction has
+ // sufficient fee to get into the transaction pool
+ func (pool *TransactionPool) checkSufficientFee(txgroup []transactions.SignedTxn) error {
++	// Special case: the compact cert transaction, if issued from the
++	// special compact-cert-sender address, in a singleton group, pays
++	// no fee.
++	if len(txgroup) == 1 {
++		t := txgroup[0].Txn
++		if t.Type == protocol.CompactCertTx && t.Sender == transactions.CompactCertSender && t.Fee.IsZero() {
++			return nil
++		}
++	}
++
+ 	// get the current fee per byte
+ 	feePerByte := pool.computeFeePerByte()
+ ",Why is this a 'transaction' and not in the block header?,Can we also add a case for the transaction in a s
+1899,"@@ -2,12 +2,14 @@
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+ using System.IO;
++using System.Security.Cryptography.X509Certificates;
+
+ namespace Microsoft.AspNet.Server.Kestrel.Filter
+ {
+     public class ConnectionFilterContext
+     {
+         public ServerAddress Address { get; set; }
+-        public Stream Connection { get; set;  }
++        public Stream Connection { get; set; }
++        public X509Certificate2 ClientCertificate { get; set; }
+     }
+ }",This doesn't fit the abstraction level. Should we have a property bag for extra stuff?,Does this need to be public? Is it used outside o
+1900,"@@ -616,11 +616,12 @@ def build_sdist(sdist_directory, config_settings=None):
+     files += glob.glob(""src/core/**/*.cc"", recursive=True)
+     files += glob.glob(""src/core/**/*.h"", recursive=True)
+     files += glob.glob(""ci/xbuild/*.py"")
++    files += glob.glob(""docs/**/*.rst"", recursive=True)
+     files += [f for f in glob.glob(""tests/**/*.py"", recursive=True)]
+     files += [f for f in glob.glob(""tests_random/*.py"")]
+     files += [""src/datatable/include/datatable.h""]
+     files.sort()
+-    files += [""ci/ext.py"", ""ci/__init__.py""]
++    files += [""ci/ext.py"", ""ci/__init__.py"", ""ci/gendoc.py""]
+     files += [""pyproject.toml""]
+     files += [""LICENSE""]
+     # See `is_source_distribution()`","Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often.",Why not just include `docs/**/*.rst`?
+1901,"@@ -244,6 +244,7 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey,
+ 		return nil, fmt.Errorf(""p2p service: %w"", err)
+ 	}
+ 	b.p2pService = p2ps
++	defer p2ps.Ready()
+
+ 	if !o.Standalone {
+ 		if natManager := p2ps.NATManager(); natManager != nil {",do we really need the `Ready` call if startup fails midway?,Does this need to be outside the `if
+1902,"@@ -17,7 +17,9 @@ namespace storage {
+
+ TEST(AddVerticesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddVerticesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddVerticesProcessor::instance(kv.get(),",You can avoid changing the code if there are parameter defaults. right ?,why is this hardcoded?
+1903,"@@ -214,7 +214,7 @@ describe('Components', () => {
+
+ 		let good, bad;
+ 		let root = render(<GoodContainer ref={c=>good=c} />, scratch);
+-		expect(scratch.innerText, 'new component with key present').to.equal('A\nB');
++		expect(scratch.textContent, 'new component with key present').to.equal('AB');
+ 		expect(Comp.prototype.componentWillMount).to.have.been.calledTwice;
+ 		expect(sideEffect).to.have.been.calledTwice;
+ ",I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers.,Sorry I missed this one. This should
+1904,"@@ -4252,10 +4252,15 @@ void command_corpsefix(Client *c, const Seperator *sep)
+
+ void command_reloadworld(Client *c, const Seperator *sep)
+ {
+-	c->Message(Chat::White, ""Reloading quest cache and repopping zones worldwide."");
++	int world_repop = atoi(sep->arg[1]);
++	if (world_repop == 0)
++		c->Message(Chat::White, ""Reloading quest cache worldwide."");
++	else
++		c->Message(Chat::White, ""Reloading quest cache and repopping zones worldwide."");
++
+ 	auto pack = new ServerPacket(ServerOP_ReloadWorld, sizeof(ReloadWorld_Struct));
+ 	ReloadWorld_Struct* RW = (ReloadWorld_Struct*) pack->pBuffer;
+-	RW->Option = ((atoi(sep->arg[1]) == 1) ? 1 : 0);
++	RW->Option = world_repop;
+ 	worldserver.SendPacket(pack);
+ 	safe_delete(pack);
+ }","I know this is legal, but I prefer we put brackets on our calls",You can just use `c->Arg(1)` here instead of `atoi(sep->arg[1]).Value()`
+1905,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteServerCertificate.java demonstrates how to delete an AWS Identity and Access Management (IAM) server certificate.]
++//snippet-sourcedescription:[DeleteServerCertificate.java demonstrates how to delete an AWS Identity and Access Management (AWS IAM) server certificate.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I think we should leave the `[code Sample]` on the next line.
+1906,"@@ -0,0 +1,18 @@
++package org.openqa.selenium;
++
++/**
++ * Created by James Reed on 11/04/2016.
++ * Thrown to indicate that a click was attempted on an element but was intercepted by another
++ * element on top of it
++ */
++public class InterceptingElementException extends InvalidElementStateException {
++
++  public InterceptingElementException(String message) {
++    super(message);
++  }
++
++  public InterceptingElementException(String message, Throwable cause) {
++    super(message, cause);
++  }
++
++}",We keep who wrote the code anonymous.,This file needs to be updated.
+1907,"@@ -135,10 +135,14 @@ export const readableLargeNumber = ( number, currencyCode = false ) =>  {
+ 	if ( false !== currencyCode && '' !== readableNumber ) {
+ 		const formatedParts = new Intl.NumberFormat( navigator.language, { style: 'currency', currency: currencyCode } ).formatToParts( number );
+
+-		const decimal = formatedParts.find( part => 'decimal' === part.type ).value;
++		let decimal = formatedParts.find( part => 'decimal' === part.type );
++		if ( ! isUndefined( decimal ) ) {
++			decimal = decimal.value;
++		}
++
+ 		const currency = formatedParts.find( part => 'currency' === part.type ).value;
+
+-		if ( 1000 > number ) {
++		if ( 1000 > number && ! isUndefined( decimal ) ) {
+ 			readableNumber = Number.isInteger( number ) ? number : number.replace( '.', decimal );
+ 		}
+ ","Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`).",Why are we special-casing `decimal` here? Wouldn't `null` be more approp
+1908,"@@ -26,6 +26,15 @@ import ""context""
+
+ // Outbound is the common interface for all outbounds
+ type Outbound interface {
++	// Transports returns the transports that used by this outbound, so they
++	// can be collected for lifecycle management, typically by a Dispatcher.
++	//
++	// Though most outbounds only use a single transport, composite outbounds
++	// may use multiple transport protocols, particularly for shadowing traffic
++	// across multiple transport protocols during a transport protocol
++	// migration.
++	Transports() []Transport
++
+ 	// Sets up the outbound to start making calls.
+ 	//
+ 	// This MUST block until the outbound is ready to start sending requests.","Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?","I think we should add a note that one of the transports is used per outbound, regardless of the transport type."
+1909,"@@ -28,6 +28,7 @@ import (
+
+ func testAlertmanagerInstanceNamespacesAllNs(t *testing.T) {
+ 	ctx := framework.NewTestCtx(t)
++
+ 	defer ctx.Cleanup(t)
+
+ 	// create 3 namespaces:","nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup.",Please remove this line.
+1910,"@@ -7,6 +7,12 @@ use JavierEguiluz\Bundle\EasyAdminBundle\Exception\EntityNotFoundException;
+ use Symfony\Component\EventDispatcher\GenericEvent;
+ use Symfony\Component\HttpFoundation\Request;
+
++/**
++ * Adds some custom attributes to the request object to store information
++ * related to EasyAdmin.
++ *
++ * @author Maxime Steinhausser
++ */
+ class RequestPostInitializeListener
+ {
+     /** @var Request|null */",Feel free to use the full notation with my email address: `Maxime Steinhausser <maxime.steinhausser@gmail.com>` :smile:,This is not the first time I see this class. Shouldn't this class be called `PostInitializeListener`?
+1911,"@@ -44,7 +44,6 @@ const FCGINullRequestID uint8 = 0
+
+ // FCGIKeepConn describes keep connection mode.
+ const FCGIKeepConn uint8 = 1
+-const doubleCRLF = ""\r\n\r\n""
+
+ const (
+ 	// BeginRequest is the begin request flag.",This was unused across the codebase,I do not think this is used anymore.
+1912,"@@ -2278,7 +2278,8 @@ func (js *jetStream) processConsumerAssignment(ca *consumerAssignment) {
+
+ 	acc, err := s.LookupAccount(ca.Client.serviceAccount())
+ 	if err != nil {
+-		// TODO(dlc) - log error
++		js.mu.Unlock()
++		s.Warnf(""Account lookup for consumer create failed: %v"", err)
+ 		return
+ 	}
+ ",Should we put in which account we were trying to look up?,Should we also log the error here?
+1913,"@@ -55,6 +55,7 @@ class InventoryTypeClass(object):
+     RESOURCE = 'resource'
+     IAM_POLICY = 'iam_policy'
+     GCS_POLICY = 'gcs_policy'
++    Supported_TypeClass = [RESOURCE, IAM_POLICY, GCS_POLICY]
+
+
+ class InventoryIndex(BASE):",either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names.,Please use a tuple instead of a li
+1914,"@@ -31,6 +31,7 @@ CREATE TABLE notes (
+ 	is_todo INT NOT NULL DEFAULT 0,
+ 	todo_due INT NOT NULL DEFAULT 0,
+ 	todo_completed INT NOT NULL DEFAULT 0,
++	pinned INT NOT NULL DEFAULT 0,
+ 	source TEXT NOT NULL DEFAULT """",
+ 	source_application TEXT NOT NULL DEFAULT """",
+ 	application_data TEXT NOT NULL DEFAULT """",",This is not going to work. You need to add a migration to the database.,New column in database is `pinned`
+1915,"@@ -308,6 +308,7 @@ class Manager {
+      * @param {Object} apiClient The ApiClient.
+      */
+     resumeGroupPlayback(apiClient) {
++        // TODO: rename this method, it's not clear what it does.
+         this.followGroupPlayback(apiClient).then(() => {
+             this.queueCore.startPlayback(apiClient);
+         });",Should these methods be renamed in this PR?,Is there a reason to keep this met
+1916,"@@ -154,6 +154,18 @@ namespace OpenTelemetry.Metrics
+                         {
+                             var metricStreamConfig = metricStreamConfigs[i];
+                             var metricStreamName = metricStreamConfig?.Name ?? instrument.Name;
++
++                            if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName))
++                            {
++                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(
++                                    instrument.Name,
++                                    instrument.Meter.Name,
++                                    ""Metric name is invalid."",
++                                    ""The name must comply with the OpenTelemetry specification."");
++
++                                continue;
++                            }
++
+                             if (this.metricStreamNames.ContainsKey(metricStreamName))
+                             {
+                                 // TODO: Log that instrument is ignored","we need to include the `metricStreamName` which is invalid, so users know whats causing the issue.",This is a breaking change and needs to be added to `3.7`
+1917,"@@ -93,8 +93,10 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+                 var pdbFilePath = Path.ChangeExtension(binaryPath, "".pdb"");
+                 using (var pdbReader = new PortablePdbReader(new FileHelper().GetStream(pdbFilePath, FileMode.Open, FileAccess.Read)))
+                 {
+-                    // Load assembly
+-                    var asm = AssemblyLoadContext.Default.LoadFromAssemblyPath(binaryPath);
++                    // At this point, the assembly should be already loaded into the load context. We query for a reference to
++                    // find the types and cache the symbol information. Let the loader follow default lookup order instead of
++                    // forcing load from a specific path.
++                    var asm = Assembly.Load(AssemblyLoadContext.GetAssemblyName(binaryPath));
+
+                     foreach (var type in asm.GetTypes())
+                     {",Please run Platform tests `DiaSessionTests`.,Will this create issues if there are multiple types in t
+1918,"@@ -741,6 +741,7 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte,
+             return pc;
+         }
+         *is_evex = true;
++        SYSLOG_INTERNAL_WARNING_ONCE(MSG_AVX_512_SUPPORT_INCOMPLETE_STRING "" @"" PFX, pc);
+         info = &evex_prefix_extensions[0][1];
+     } else {
+         /* not evex */",This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers.,I'm not sure this is correct. AFAIK this is only called
+1919,"@@ -37,6 +37,10 @@ function matchesParentDomain(srvAddress, parentDomain) {
+ function parseSrvConnectionString(uri, options, callback) {
+   const result = URL.parse(uri, true);
+
++  if (options.directConnection || options.directconnection) {
++    return callback(new MongoParseError('directConnection not supported with SRV URI'));
++  }
++
+   if (result.hostname.split('.').length < 3) {
+     return callback(new MongoParseError('URI does not have hostname, domain name and tld'));
+   }",is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options.,We should check for `options.directconnection && options
+1920,"@@ -230,11 +230,11 @@ func BenchmarkFloat64LastValueAdd(b *testing.B) {
+
+ // Histograms
+
+-func benchmarkInt64HistogramAdd(b *testing.B, name string) {
++func BenchmarkInt64HistogramAdd(b *testing.B) {
+ 	ctx := context.Background()
+ 	fix := newFixture(b)
+ 	labs := makeLabels(1)
+-	mea := fix.meterMust().NewInt64Histogram(name)
++	mea := fix.meterMust().NewInt64Histogram(""int64.histogram"")
+
+ 	b.ResetTimer()
+ ",Does the name suffix hardcode something? Not clear how changing the name fixes this.,I think this should be the actual fix.
+1921,"@@ -39,4 +39,14 @@ public interface JmxExecutorManagerMBean {
+
+   @DisplayName(""OPERATION: getPrimaryExecutorHostPorts"")
+   public List<String> getPrimaryExecutorHostPorts();
++
++  @DisplayName(""OPERATION: isQueueProcessorActive"")
++  public boolean isQueueProcessorActive();
++
++  @DisplayName(""OPERATION: getUndispatchedFlows"")
++  public String getUndispatchedFlows();
++
++  @DisplayName(""OPERATION: getQueueProcessorThreadState"")
++  public String getQueueProcessorThreadState();
++
+ }",Is undispatched same as queued? getQueuedFlows?,What do you think about changing the n
+1922,"@@ -1,5 +1,5 @@
+ /**
+- * core/site data store: connection info tests.
++ * Core site data store: connection info tests.
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for all similar cases below.",Shouldn't this be `core/site data stor
+1923,"@@ -80,13 +80,14 @@ func TestSingleImageImportLoggableBuilder(t *testing.T) {
+ 						uefiBootable:          isUEFIDetectedValue,
+ 						biosBootable:          biosBootableValue,
+ 					},
+-					traceLogs: traceLogs,
++					traceLogs: append(traceLogs, traceLogs...),
+ 				}
+ 				assert.Equal(t, expected, NewSingleImageImportLoggableBuilder().
+ 					SetDiskAttributes(format, sourceGb, targetGb).
+ 					SetUEFIMetrics(isUEFICompatibleImageValue, isUEFIDetectedValue, biosBootableValue, bootFSValue).
+ 					SetInflationAttributes(matchResultValue, inflationTypeValue, inflationTimeValue, shadowInflationTimeValue).
+-					SetTraceLogs(traceLogs).
++					AppendTraceLogs(traceLogs).
++					AppendTraceLogs(traceLogs).
+ 					Build())
+ 			}
+ 		}",Why is this done twice?,Why are we using `AppendTraceLogs` her
+1924,"@@ -55,6 +55,11 @@ func (it *DeadlineReconciler) Reconcile(request reconcile.Request) (reconcile.Re
+ 		return reconcile.Result{}, client.IgnoreNotFound(err)
+ 	}
+
++	if ConditionEqualsTo(node.Status, v1alpha1.ConditionDeadlineExceed, corev1.ConditionTrue) {
++		// if this node deadline is exceed, try propagating to children node
++		return reconcile.Result{}, it.propagateDeadlineToChildren(ctx, &node)
++	}
++
+ 	if node.Spec.Deadline == nil {
+ 		return reconcile.Result{}, nil
+ 	}","This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?","If this node deadline is exceeded, should we just return a `reconcileComplete` result?"
+1925,"@@ -175,8 +175,8 @@ func TestEnvironment(state *BuildState, target *BuildTarget, testDir string) Bui
+ 	if target.HasLabel(""cc"") {
+ 		env = append(env, ""GCNO_DIR=""+path.Join(RepoRoot, GenDir, target.Label.PackageName))
+ 	}
+-	if state.DebugTests {
+-		env = append(env, ""DEBUG=true"")
++	if state.DebugFailingTests {
++		env = append(env, ""DEBUG_TEST_FAILURE=true"")
+ 	}
+ 	if target.Test.Sandbox && len(state.Config.Sandbox.Dir) > 0 {
+ 		env = append(env, ""SANDBOX_DIRS=""+strings.Join(state.Config.Sandbox.Dir, "",""))",This was renamed to avoid any confusion with the more general case of debugging via `plz debug`,"The `DEBUG_TEST_FAILURE` flag was only set to `true` by the `ginkgo` tooling, so I dec"
+1926,"@@ -88,9 +88,11 @@ public class Converter {
+   static byte[] convertUtf8ToBytes(Object val, int prefixLength) {
+     requireNonNull(val, ""val is null"");
+     if (val instanceof byte[]) {
+-      return new String((byte[]) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);
++      return new String((byte[]) val).substring(0, Math.min(((byte[]) val).length, prefixLength))
++          .getBytes(StandardCharsets.UTF_8);
+     } else if (val instanceof String) {
+-      return ((String) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);
++      return ((String) val).substring(0, Math.min(((String) val).length(), prefixLength))
++          .getBytes(StandardCharsets.UTF_8);
+     }
+     throw new TypeException(
+         String.format(""Cannot cast %s to bytes"", val.getClass().getSimpleName()));","String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean.","This can be written as `Math.min(val.length, prefixLength)`"
+1927,"@@ -2067,9 +2067,13 @@ CheckedError Parser::ParseEnum(const bool is_union, EnumDef **dest) {
+   const auto strict_ascending = (false == opts.proto_mode);
+   EnumValBuilder evb(*this, *enum_def, strict_ascending);
+   EXPECT('{');
+-  // A lot of code generatos expect that an enum is not-empty.
+-  if ((is_union || Is('}')) && !opts.proto_mode) {
+-    evb.CreateEnumerator(""NONE"");
++  if(is_union && !opts.proto_mode) {
++    // Every union has the NONE field, mapped to a special `void` type.
++    evb.CreateEnumerator(""NONE"", BASE_TYPE_NONE);
++    ECHECK(evb.AcceptEnumerator());
++  } else if (Is('}') && !opts.proto_mode) {
++    // Most code generators expect that an enum is not-empty.
++    evb.CreateEnumerator(""NONE"", 0);
+     ECHECK(evb.AcceptEnumerator());
+   }
+   std::set<std::pair<BaseType, StructDef *>> union_types;","Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`.",A lot of code generos expecting that the NONE field is not mapped to a special `void`
+1928,"@@ -38,4 +38,6 @@ public interface Alerter {
+   void alertOnFailedExecutorHealthCheck(Executor executor,
+       List<ExecutableFlow> executions,
+       ExecutorManagerException e, List<String> alertEmails);
++
++  String getAzkabanURL();
+ }","Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed.",I would suggest to rename the method to something more descriptive like `getAzkabanUrl`.
+1929,"@@ -316,6 +316,8 @@ class BaseDetector(nn.Module, metaclass=ABCMeta):
+                 i = int(i)
+                 color_mask = color_masks[labels[i]]
+                 mask = segms[i]
++                if mask.dtype != np.bool:
++                    mask = np.array(mask, dtype=bool)
+                 img[mask] = img[mask] * 0.5 + color_mask * 0.5
+         # if out_file specified, do not show image in window
+         if out_file is not None:",The above 3 lines can be written as: `mask = segms[i].astype(bool)`,Do we need to cast it to bool when we use it above?
+1930,"@@ -27,6 +27,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ 	""github.com/iotexproject/iotex-core/protogen/iotexapi""
++	""github.com/iotexproject/iotex-address/address""
+ )
+
+ // Flags",File is not `gofmt`-ed with `-s` (from `gofmt`),Could not find `iotexapi` in our codebase.
+1931,"@@ -631,7 +631,10 @@ void nano::node::start ()
+ 		{
+ 			network.port = bootstrap.port;
+ 		}
++
++		logger.always_log (boost::str (boost::format (""Node started with peering port `%1%`."") % network.port));
+ 	}
++
+ 	if (!flags.disable_backup)
+ 	{
+ 		backup_wallet ();",Thought it's good to have this logged down so that we can check the used value in the logs.,Use `boost::to_string` instead of `boost::str`.
+1932,"@@ -83,7 +83,8 @@ type AWSMachineSpec struct {
+ // AWSMachineStatus defines the observed state of AWSMachine
+ type AWSMachineStatus struct {
+ 	// Ready is true when the provider resource is ready.
+-	Ready *bool `json:""ready,omitempty""`
++	// +optional
++	Ready bool `json:""ready""`
+
+ 	// Addresses contains the AWS instance associated addresses.
+ 	Addresses []v1.NodeAddress `json:""addresses,omitempty""`",I don't think you can call this optional unless it's a pointer - remove this?,should this be `// +optional` instead?
+1933,"@@ -116,6 +116,11 @@ public class OfflineEditFragment extends BaseFragment {
+
+     @OnClick(R.id.buttonSendAll)
+     protected void onSendAllProducts() {
++        List<SendProduct> listSaveProduct = SendProduct.listAll(SendProduct.class);
++        if (listSaveProduct.size() == 0) {
++            Toast.makeText(getActivity(), R.string.txtNoData, Toast.LENGTH_LONG).show();
++            return;
++        }
+         new MaterialDialog.Builder(getActivity())
+                 .title(R.string.txtDialogsTitle)
+                 .content(R.string.txtDialogsContentSend)",@naofum please use `isEmpty`method instead,This dialog is shown if there is no pr
+1934,"@@ -280,12 +280,12 @@ bool gen_jit_and_run(compile_t* c, int* exit_code, jit_symbol_t* symbols,
+
+   auto resolver = orc::createLambdaResolver(local_lookup, external_lookup);
+ #if PONY_LLVM >= 500
+-  auto maybe_handle = compile_layer.addModule(module, resolver);
++  auto nullable_handle = compile_layer.addModule(module, resolver);
+
+-  if(!maybe_handle)
++  if(!nullable_handle)
+     return false;
+
+-  auto handle = maybe_handle.get();
++  auto handle = nullable_handle.get();
+ #else
+   std::vector<decltype(module)> module_set{module};
+   auto handle = compile_layer.addModuleSet(std::move(module_set), mem_mgr,",i think this is unrelated and needs to be reverted. need to discuss at sync.,`maybe_handle.get()` can return `nullp
+1935,"@@ -19,8 +19,10 @@ import org.hyperledger.besu.datatypes.Hash;
+
+ import java.util.Optional;
+
++import org.apache.tuweni.bytes.Bytes;
++
+ /** A block header capable of being processed. */
+-public class ProcessableBlockHeader {
++public class ProcessableBlockHeader implements org.hyperledger.besu.plugin.data.BlockHeader {
+
+   protected final Hash parentHash;
+ ","Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me.",I am not sure if this is the correct p
+1936,"@@ -1372,6 +1372,14 @@ Connection.prototype.setClient = function setClient(client) {
+   return this;
+ };
+
++Connection.prototype.syncIndexes = async function syncIndexes() {
++  const result = [];
++  for (const model in this.models) {
++    result.push(await this.model(model).syncIndexes());
++  }
++  return result;
++};
++
+ /**
+  * Switches to a different database using the same connection pool.
+  *",Love how we can finally use async/await in the codebase.,"The docs for `syncIndexes` say it expects an array, but it doesn't seem to. It's also a bit weird to call `syncIndexes()` on a single model, since it's expecting a single model, not just a list of indexes. Maybe we could call it `getIndexes`?"
+1937,"@@ -3531,6 +3531,7 @@ void nano::rpc_handler::wallet_representative_set ()
+ {
+ 	rpc_control_impl ();
+ 	auto wallet (wallet_impl ());
++	bool update_existing_accounts (request.get<bool> (""update_existing_accounts"", false));
+ 	if (!ec)
+ 	{
+ 		std::string representative_text (request.get<std::string> (""representative""));","Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM",Shouldn't this default to `true`?
+1938,"@@ -40,10 +40,8 @@ type Connection struct {
+ 	// For invalid and closed connections: StopTime is the time when connection was updated last.
+ 	// For established connections: StopTime is latest time when it was polled.
+ 	StopTime time.Time
+-	// IsActive flag helps in cleaning up connections when they are not in conntrack any module more.
+-	IsActive bool
+-	// DoExport flag helps in tagging connections that can be exported by Flow Exporter
+-	DoExport           bool
++	// IsPresent flag helps in cleaning up connections when they are not in conntrack table anymore.
++	IsPresent          bool
+ 	Zone               uint16
+ 	Mark               uint32
+ 	StatusFlag         uint32",when is this consumed? I'm probably missing it but I can't find it right now,I wonder if we should rename `IsPresent` to `IsPresentFlag` to avoid ambiguity in the future.
+1939,"@@ -418,6 +418,10 @@ void GroupByAgg::generateCacheKey(CacheWA &cwa) const
+     groupExpr_.rebuildExprTree(ITM_ITEM_LIST);
+   if (grpExpr) {
+     cwa += "" gBy:"";
++
++    if (isRollup())
++      cwa += "" roll:"";
++
+     grpExpr->generateCacheKey(cwa);
+   }
+ }","I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a).","Shouldn't this also be: if (isRollup()) cwa += "" roll:"";"
+1940,"@@ -14,10 +14,15 @@
+  */
+ package com.google.api.codegen.transformer.nodejs;
+
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
++import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",can use `getParamTypeName` instead,This seems to be the only addition. Is this intentional?
+1941,"@@ -184,14 +184,14 @@ class AdminController extends Controller
+     {
+         $this->dispatch(EasyAdminEvents::PRE_EDIT);
+
+-        if ($this->request->isXmlHttpRequest()) {
+-            return $this->ajaxEdit();
+-        }
+-
+         $id = $this->request->query->get('id');
+         $easyadmin = $this->request->attributes->get('easyadmin');
+         $entity = $easyadmin['item'];
+
++        if ($this->request->isXmlHttpRequest() && $this->request->query->has('property')) {
++            return $this->toggleBooleanProperty($entity, $this->request->query->get('property'), $this->request->query->get('newValue'));
++        }
++
+         $fields = $this->entity['edit']['fields'];
+
+         $editForm = $this->executeDynamicMethod('create<EntityName>EditForm', array($entity, $fields));",Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method,Why did you remove this `ajaxEdit` method?
+1942,"@@ -186,6 +186,18 @@ class BrowserPage(QWebPage):
+             errpage.encoding = 'utf-8'
+             return True
+
++    def chooseFile(self, parent_frame: QWebFrame, suggested_file: str):
++        """"""Override chooseFiles to (optionally) invoke custom file uploader.""""""
++        handler = config.val.fileselect.handler
++        if handler == ""default"":
++            return super().chooseFile(parent_frame, suggested_file)
++
++        selected_file = shared.choose_file(multiple=False)
++        if selected_file == []:
++            return ''
++        else:
++            return selected_file[0]
++
+     def _handle_multiple_files(self, info, files):
+         """"""Handle uploading of multiple files.
+ ","Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break.","Let's remove this override, it seems to be unused and we"
+1943,"@@ -329,6 +329,15 @@ func (e *ETCD) join(ctx context.Context, clientAccessInfo *clientaccess.Info) er
+ 	}
+
+ 	for _, member := range members.Members {
++		memberNodeName := strings.Split(member.Name, ""-"")[0]
++		if memberNodeName == e.config.ServerNodeName {
++			// make sure to remove the name file if a duplicate node name is used
++			nameFile := nameFile(e.config)
++			if err := os.Remove(nameFile); err != nil {
++				return err
++			}
++			return errors.New(""Failed to join etcd cluster due to duplicate node names, please use unique node name for the server"")
++		}
+ 		for _, peer := range member.PeerURLs {
+ 			u, err := url.Parse(peer)
+ 			if err != nil {",How will this code behave with hostnames that contain hyphens?,Do we need to ensure that `member.Name` is not empty?
+1944,"@@ -735,6 +735,15 @@ namespace pwiz.Skyline.Model
+                 moleculeIdKeys.Add(MoleculeAccessionNumbers.TagSMILES, smiles);
+             }
+
++            var keggCol = ColumnIndex(SmallMoleculeTransitionListColumnHeaders.idKEGG);
++            var kegg = NullForEmpty(row.GetCell(keggCol));
++            if (kegg != null)
++            {
++                // Should have form like C07481 but we'll accept anything for now, having no proper parser
++                kegg = kegg.Trim();
++                moleculeIdKeys.Add(MoleculeAccessionNumbers.TagKEGG, kegg);
++            }
++
+             return !moleculeIdKeys.Any()
+                 ? MoleculeAccessionNumbers.EMPTY
+                 : new MoleculeAccessionNumbers(moleculeIdKeys);","I think this is redundant since ""NullForEmpty"" already calls ""Trim()"".",I think this should be doing something like `var kegg = row.GetCell(keggCol).Value;`
+1945,"@@ -317,6 +317,8 @@ type CloudBackupRestoreRequest struct {
+ }
+
+ type CloudBackupGroupCreateResponse struct {
++	// ID for this group of backups
++	GroupCloudBackupID string
+ 	// Names of the tasks performing this group backup
+ 	Names []string
+ }",Change this to IDs too?,What is the difference between `string` and `int` here?
+1946,"@@ -221,6 +221,11 @@ public class RaidsPlugin extends Plugin
+ 	@Getter
+ 	private final List<String> layoutWhitelist = new ArrayList<>();
+
++	@Getter
++	private final ImmutableSet<String> list_of_DC_SCOUT_RAIDS = ImmutableSet.of(
++		""SCPFCCSPCF"", ""CSPFCCCSSF"", ""SCFPCSCPCF"", ""PCSFCPCSCF"", ""SCCFCPSCSF"", ""SCPFCCCSSF"",
++		""SCPFCPCSCF""
++	);
+ 	@Getter
+ 	private Raid raid;
+ ","private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar.",This list should probably be a `Set<String>`
+1947,"@@ -173,7 +173,7 @@ STATIC fpga_result parse_perf_attributes(struct udev_device *dev,
+ 			globfree(&pglob);
+ 			return FPGA_EXCEPTION;
+ 		}
+-		if (fscanf(file, ""%s"", attr_value) != 1) {
++		if (fscanf(file, ""%127s"", attr_value) != 1) {
+ 			OPAE_ERR(""Failed to read %s"", pglob.gl_pathv[i]);
+ 			goto out;
+ 		}",attr_value is 128 bytes?,Why is this change needed?
+1948,"@@ -54,7 +54,9 @@ class HTTPRequest(Request):
+         msg = ""Option 'url' is mandatory for request but not found in %s"" % config
+         self.url = self.config.get(""url"", TaurusConfigError(msg))
+         self.label = self.config.get(""label"", self.url)
+-        self.method = self.config.get(""method"", ""GET"").upper()
++        self.method = self.config.get(""method"", ""GET"")
++        if not has_variable_pattern(self.method):
++            self.method = self.method.upper()
+
+         # TODO: add method to join dicts/lists from scenario/request level?
+         self.headers = self.config.get(""headers"", {})",if it's unpredictable - why uppercase it at all?,"This is the only place where `self.method` is used. I don't think it's needed to have it, but just in case."
+1949,"@@ -25,6 +25,7 @@ type KubeCloudInstTool struct {
+ func (cu *KubeCloudInstTool) InstallTools() error {
+ 	cu.SetOSInterface(GetOSInterface())
+ 	cu.SetKubeEdgeVersion(cu.ToolVersion)
++	fmt.Println(""beforeinstallkubeedge"")
+
+ 	err := cu.InstallKubeEdge()
+ 	if err != nil {",Please remove all these debug prints. It doesn't look good.,Is this debugging code or is it intentional?
+1950,"@@ -74,6 +74,7 @@ type VMContext interface {
+ 	BlockHeight() *types.BlockHeight
+ 	IsFromAccountActor() bool
+ 	Charge(cost types.GasUnits) error
++	SampleChainRandomness(sampleHeight *types.BlockHeight) ([]byte, error)
+
+ 	CreateNewActor(addr address.Address, code cid.Cid, initalizationParams interface{}) error
+ ",Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter.,why are we not using `BlockHeight` directly here?
+1951,"@@ -58,8 +58,14 @@ func GetBackoffForNextSchedule(cronSchedule string, startTime time.Time, closeTi
+ 	if err != nil {
+ 		return NoBackoff
+ 	}
++
++	if closeTime.Before(startTime) {
++		closeTime = startTime
++	}
++
+ 	startUTCTime := startTime.In(time.UTC)
+ 	closeUTCTime := closeTime.In(time.UTC)
++
+ 	nextScheduleTime := schedule.Next(startUTCTime)
+ 	// Calculate the next schedule start time which is nearest to the close time
+ 	for nextScheduleTime.Before(closeUTCTime) {","I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately.",`startTime` and `closeTime` are only used for `schedule.Next()`. I think these can be moved inside the for
+1952,"@@ -348,6 +348,10 @@ type CloudBackupGenericRequest struct {
+ 	CredentialUUID string
+ 	// All if set to true, backups for all clusters in the cloud are processed
+ 	All bool
++	// StatusFilter indicates backups based on status
++	StatusFilter CloudBackupStatusType
++	// TagFilter indicates backups based on tag
++	TagFilter string
+ }
+
+ type CloudBackupInfo struct {","Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage",Can you add the StatusFilter and TagFilter to the `CloudBackupInfo` type?
+1953,"@@ -50,9 +50,15 @@ class Summon extends SolrDefault
+      * returned as an array of chunks, increasing from least specific to most
+      * specific.
+      *
++     * @param bool $extended Whether to return a keyed array with the following
++     * keys:
++     * - heading: the actual subject heading chunks
++     * - type: heading type
++     * - source: source vocabulary
++     *
+      * @return array
+      */
+-    public function getAllSubjectHeadings()
++    public function getAllSubjectHeadings($extended = false)
+     {
+         $retval = [];
+         $topic = isset($this->fields['SubjectTerms']) ?","I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names.",Could you rename this to `$includeKey` and `$excludeKey`?
+1954,"@@ -261,7 +261,7 @@ public class XCJFQuery extends Query {
+     }
+
+     private DocSet getDocSet() throws IOException {
+-      SolrClientCache solrClientCache = new SolrClientCache();
++      SolrClientCache solrClientCache = searcher.getCore().getCoreContainer().getSolrClientCache();
+       TupleStream solrStream;
+       if (zkHost != null || solrUrl == null) {
+         solrStream = createCloudSolrStream(solrClientCache);",Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?,"I wonder if we could move this to a static method in the SolrClientCache,"
+1955,"@@ -38,6 +38,9 @@ type (
+ 	ClusterMetadataRow struct {
+ 		ImmutableData         []byte
+ 		ImmutableDataEncoding string
++		Data                  []byte
++		DataEncoding          string
++		Version               int64
+ 	}
+
+ 	// ClusterMembershipRow represents a row in the cluster_membership table",according to the PR (schema changes?) these 2 field should be removed?,"The version should be an integer, not a string."
+1956,"@@ -373,16 +373,13 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo, kubeCli client.Cli
+ 					Mode:     v1alpha1.PodMode(exp.Scope.Mode),
+ 					Value:    exp.Scope.Value,
+ 				},
++				ContainerNames: exp.Target.StressChaos.ContainerNames,
+ 			},
+ 			Stressors:         stressors,
+ 			StressngStressors: exp.Target.StressChaos.StressngStressors,
+ 		},
+ 	}
+
+-	if exp.Target.StressChaos.ContainerName != nil {
+-		chaos.Spec.ContainerNames = []string{*exp.Target.StressChaos.ContainerName}
+-	}
+-
+ 	if exp.Scheduler.Duration != """" {
+ 		chaos.Spec.Duration = &exp.Scheduler.Duration
+ 	}",Panic here if `exp.Target.StressChaos.CintainerName` is nil.,We still need to set the container name on the target here.
+1957,"@@ -93,4 +93,16 @@ public interface LeafCollector {
+    */
+   void collect(int doc) throws IOException;
+
++  /**
++   * Optionally creates a view of the scorerIterator where only competitive documents
++   * in the scorerIterator are kept and non-competitive are skipped.
++   *
++   * Collectors should delegate this method to their comparators if
++   * their comparators provide the skipping functionality over non-competitive docs.
++   * The default is to return the same iterator which is interpreted as the collector doesn't filter any documents.
++   */
++  default DocIdSetIterator filterIterator(DocIdSetIterator scorerIterator) {
++    return scorerIterator;
++  }
++
+ }",This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better.,I'm not sure this belongs here. I'd rather it be in the `Co
+1958,"@@ -227,6 +227,7 @@ public class IcebergInputFormat<T> extends InputFormat<Void, T> {
+
+     private CloseableIterable<T> open(FileScanTask currentTask, Schema readSchema) {
+       DataFile file = currentTask.file();
++      LOG.debug(""Opening [{}] for read"", file);
+       // TODO we should make use of FileIO to create inputFile
+       InputFile inputFile = HadoopInputFile.fromLocation(file.path(), context.getConfiguration());
+       CloseableIterable<T> iterable;",Aren't there already logs for this from the underlying file system implementation?,"Can you change this to `LOG.debug(""Opening input file [{}]"""
+1959,"@@ -75,7 +75,7 @@ class SearchHandlerTest extends TestCase
+     {
+         $spec = ['DismaxParams' => [['foo', 'bar'], ['mm', '100%']], 'DismaxFields' => ['field1', 'field2']];
+         $hndl = new SearchHandler($spec);
+-        $defaults = ['CustomMunge' => [], 'DismaxHandler' => 'dismax', 'QueryFields' => [], 'FilterQuery' => []];
++        $defaults = ['CustomMunge' => [], 'DismaxHandler' => 'dismax', 'QueryFields' => [], 'FilterQuery' => [], 'DismaxMunge' => []];
+         $this->assertEquals($spec + $defaults, $hndl->toArray());
+     }
+ ",It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how.,Shouldn't it be SearchHandler?
+1960,"@@ -62,6 +62,9 @@ class kubernetes(luigi.Config):
+     kubernetes_namespace = luigi.OptionalParameter(
+         default=None,
+         description=""K8s namespace in which the job will run"")
++    max_retrials_to_get_pods = luigi.IntParameter(
++        default=0,
++        description=""Max retrials to get pods' informations"")
+
+
+ class KubernetesJobTask(luigi.Task):","`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?","I think it might be better to call this parameter `retrial_limit` (and the description), just like `max_retrials_to_get_pods`"
+1961,"@@ -213,6 +213,7 @@ class Shopware6ChannelForm extends AbstractType
+                 AttributeIdType::class,
+                 [
+                     'label' => 'Attribute Product Meta Title',
++                    'help' => 'Value in product it should contain 255 characters or less.',
+                     'choices' => array_flip($textareaAttributeDictionary),
+                     'property_path' => 'attributeProductMetaTitle',
+                     'required' => false,",Value in product should contain 255 characters or less.,"Reword: ""Value in product it should contain 255 characters or less."""
+1962,"@@ -169,12 +169,12 @@ func main() {
+ 				logger.Error().Msg(fmt.Sprintf(""Node %d: Can not get State height"", i))
+ 			}
+ 			bcHeights[i] = chains[i].TipHeight()
+-			minTimeout = int(configs[i].Consensus.RollDPoS.Delay/time.Second - configs[i].Consensus.RollDPoS.ProposerInterval/time.Second)
++			minTimeout = int(configs[i].Consensus.RollDPoS.Delay/time.Second - configs[i].Consensus.RollDPoS.FSM.ProposerInterval/time.Second)
+ 			netTimeout = 0
+ 			if timeout > minTimeout {
+ 				netTimeout = timeout - minTimeout
+ 			}
+-			idealHeight[i] = uint64((time.Duration(netTimeout) * time.Second) / configs[i].Consensus.RollDPoS.ProposerInterval)
++			idealHeight[i] = uint64((time.Duration(netTimeout) * time.Second) / configs[i].Consensus.RollDPoS.FSM.ProposerInterval)
+
+ 			logger.Info().Msg(fmt.Sprintf(""Node#%d blockchain height: %d"", i, bcHeights[i]))
+ 			logger.Info().Msg(fmt.Sprintf(""Node#%d state      height: %d"", i, stateHeights[i]))",line is 133 characters (from `lll`),why we need this at all?
+1963,"@@ -78,7 +78,7 @@ module RSpec
+       end
+
+       def file_options
+-        custom_options_file ? [custom_options] : [global_options, local_options]
++        custom_options_file ? [custom_options] : [global_options, local_options, personal_options]
+       end
+
+       def env_options","since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?",TIL about `custom_options`
+1964,"@@ -52,7 +52,7 @@ module Blacklight::Solr
+     protected
+
+       def build_connection
+-        RSolr.connect(connection_config)
++        RSolr.connect(connection_config.merge(adapter: connection_config[:http_adapter]))
+       end
+   end
+ end",Will we want to refactor this when we drop rsolr 1.x support?,Line is too long. [101/80]
+1965,"@@ -63,7 +63,7 @@ func Request(path string, info *clientaccess.Info, requester HTTPRequester) ([]b
+ 	return requester(u.String(), clientaccess.GetHTTPClient(info.CACerts), username, password)
+ }
+
+-func getNodeNamedCrt(nodeName, nodePasswordFile string) HTTPRequester {
++func getNodeNamedCrt(nodeName, nodeIP, nodePasswordFile string) HTTPRequester {
+ 	return func(u string, client *http.Client, username, password string) ([]byte, error) {
+ 		req, err := http.NewRequest(http.MethodGet, u, nil)
+ 		if err != nil {",should this really be multiple IPs?,func getNodeNamedCrt(nodeN
+1966,"@@ -0,0 +1 @@
++<%= render partial: ""proposal"", locals: { proposal: @proposal}  %>","Hmm, is that partial used in multiple places? Maybe we can just move that file in here.",Should I remove this parti
+1967,"@@ -0,0 +1,16 @@
++// Copyright 2014-2015 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package async
++
++//go:generate mockgen.sh github.com/aws/amazon-ecs-agent/agent/async Cache mocks/async_mocks.go",Should be 2014-2016,Can we move this file to `
+1968,"@@ -1976,6 +1976,11 @@ namespace pwiz.Skyline.Model
+         private static Type GetColumnType(string value, IFormatProvider provider)
+         {
+             double result;
++            var quote = @"""""""";
++            if (value.StartsWith(quote) && value.EndsWith(quote))
++            {
++                value = value.Substring(1, value.Length - 2);
++            }
+             if (double.TryParse(value, NumberStyles.Number, provider, out result))
+                 return typeof(double);
+             else if (FastaSequence.IsExSequence(value))","Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields.",Why not use `String.IsNullOrEmpty(value)`?
+1969,"@@ -2733,6 +2733,7 @@ describe('Find', function() {
+               cursors[0].next(function(err) {
+                 test.equal(null, err);
+
++                cursors[0].close();
+                 client.close();
+                 done();
+               });","similarly here, are the these cursors not being closed when the client is closed?",why do we need to close the cursor here?
+1970,"@@ -22,7 +22,7 @@ import (
+ )
+
+ var (
+-	supportedPolicies = make(map[string]func() Policy)
++	supportedPolicies = make(map[string]func(string) Policy)
+ )
+
+ type staticUpstream struct {",Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args.,this can be a `map[string]Policy` now.
+1971,"@@ -36,6 +36,7 @@ func serviceLoggedIn(ctx context.Context, config Config, session SessionInfo,
+ 			log.CWarningf(ctx,
+ 				""Failed to enable existing journals: %v"", err)
+ 		}
++		jServer.MakeFBOsForExistingJournals(ctx)
+ 	}
+ 	err := config.MakeDiskBlockCacheIfNotExists()
+ 	if err != nil {",Should this happen even if the above failed?,Why does this need to be made here? We hav
+1972,"@@ -1,5 +1,5 @@
+ /*
+-Copyright 2017 The OpenEBS Authors.
++Copyright 2018 The OpenEBS Authors.
+
+ Licensed under the Apache License, Version 2.0 (the ""License"");
+ you may not use this file except in compliance with the License.",Please dont change this .,Don't update existing files.
+1973,"@@ -382,7 +382,7 @@ void nano::active_transactions::cleanup_election (nano::unique_lock<nano::mutex>
+ 			node.network.publish_filter.clear (block);
+ 		}
+ 	}
+-	node.logger.try_log (boost::str (boost::format (""Election erased for root %1%"") % election.qualified_root.to_string ()));
++	node.logger.try_log (boost::str (boost::format (""Election erased for root %1%, confirmed: %2$b"") % election.qualified_root.to_string () % election.confirmed ()));
+ }
+
+ std::vector<std::shared_ptr<nano::election>> nano::active_transactions::list_active (std::size_t max_a)",There is a strange $b that looks wrong.,Did you mean to leave the %2
+1974,"@@ -1166,12 +1166,16 @@ def getControlFieldSpeech(attrs,ancestorAttrs,fieldType,formatConfig=None,extraD
+ 	# speakStatesFirst: Speak the states before the role.
+ 	speakStatesFirst=role==controlTypes.ROLE_LINK
+
++	containerContainsText="""" #: used for item counts for lists
++
+ 	# Determine what text to speak.
+ 	# Special cases
+ 	if speakEntry and childControlCount and fieldType==""start_addedToControlFieldStack"" and role==controlTypes.ROLE_LIST and controlTypes.STATE_READONLY in states:
+ 		# List.
+-		# Translators: Speaks number of items in a list (example output: list with 5 items).
+-		return roleText+"" ""+_(""with %s items"")%childControlCount
++		# #7652: containerContainsText variable is set here, but the actual generation of all other output is handled further down in the general cases section.
++		# This ensures that properties such as name, states and level etc still get reported appropriately.
++		# Translators: Number of items in a list (example output: list with 5 items).
++		containerContainsText=_(""with %s items"")%childControlCount
+ 	elif fieldType==""start_addedToControlFieldStack"" and role==controlTypes.ROLE_TABLE and tableID:
+ 		# Table.
+ 		return "" "".join((nameText,roleText,stateText, getSpeechTextForProperties(_tableID=tableID, rowCount=attrs.get(""table-rowcount""), columnCount=attrs.get(""table-columncount"")),levelText))","Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the ""General"" section.",The translation for the numb
+1975,"@@ -18,6 +18,7 @@ module Travis
+           CLEANUPS.each do |find_arg|
+             sh.raw ""find #{find_arg[:directory]} -name #{find_arg[:glob]} -delete 2>/dev/null""
+           end
++          sh.export 'PATH', '$JAVA_HOME:$PATH'
+         end
+
+         def install","It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added.",`$JAVA_HOME/$JAVA_HOME` can
+1976,"@@ -9,6 +9,7 @@ bool generate_uuid(char out[static 37]) {
+ 	return true;
+ }
+ #else
++#include <assert.h>
+ #include <string.h>
+ #include <stdlib.h>
+ ",Should move this to within the `#else` block as it's only used there.,Can we not simply make this `#include <stdlib.h>`?
+1977,"@@ -41,6 +41,9 @@ class ProductListPage extends AbstractPage
+         $context = $this->getProductListCompomentContext();
+
+         $this->productListComponent->addProductToCartByName($productName, $quantity, $context);
++
++        $this->tester->waitForAjax();
++        $this->tester->wait(1);
+     }
+
+     /**",is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method.,Isn't there a `$this->tester->waitForAjax()` ?
+1978,"@@ -94,8 +94,8 @@ abstract class AbstractSolrTask extends AbstractTask {
+     public function __sleep()
+     {
+         $properties = get_object_vars($this);
+-        // avoid serialization if the site object
+-        unset($properties['site']);
++        // avoid serialization if the site and logger object
++        unset($properties['site'], $properties['logger']);
+         return array_keys($properties);
+     }
+-}
++}","Maybe you can correct the typo ""if"" too :)",Why are you unsetting the logger here?
+1979,"@@ -298,6 +298,9 @@ type KeybaseService interface {
+ 	// popups spawned.
+ 	Identify(ctx context.Context, assertion, reason string) (UserInfo, error)
+
++	IdentifyForChat(ctx context.Context, assertion, reason string) (
++		UserInfo, *keybase1.IdentifyTrackBreaks, error)
++
+ 	// LoadUserPlusKeys returns a UserInfo struct for a
+ 	// user with the specified UID.
+ 	// If you have the UID for a user and don't require Identify to","I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?",can you give this a more specific name? `IdentifyB
+1980,"@@ -51,10 +51,18 @@ public:
+      */
+     bool load(handle src, bool)
+     {
++        // Import mpi4py if it does not exist.
++        if (!PyMPIComm_Get)
++        {
++            if (import_mpi4py() < 0)
++            {
++                throw std::runtime_error(
++                        ""ERROR: mpi4py not loaded correctly\n""); /* Python 2.X */
++            }
++        }
+         // If src is not actually a MPI4PY communicator, the next
+         // call returns nullptr, and we return false to indicate the conversion
+         // failed.
+-
+         MPI_Comm *mpiCommPtr = PyMPIComm_Get(src.ptr());
+         if (mpiCommPtr == nullptr)
+         {","I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?",A more specific error message would be `ERROR: mpi4py not loaded correctly\n`
+1981,"@@ -142,13 +142,14 @@ func (cache *httpCache) retrieve(target *core.BuildTarget, key []byte) (bool, er
+ 	resp, err := cache.client.Do(req)
+ 	if err != nil {
+ 		return false, err
+-	} else if resp.StatusCode == http.StatusNotFound {
++	}
++	defer resp.Body.Close()
++	if resp.StatusCode == http.StatusNotFound {
+ 		return false, nil // doesn't exist - not an error
+ 	} else if resp.StatusCode != http.StatusOK {
+ 		b, _ := ioutil.ReadAll(resp.Body)
+ 		return false, fmt.Errorf(""%s"", string(b))
+ 	}
+-	defer resp.Body.Close()
+ 	gzr, err := gzip.NewReader(resp.Body)
+ 	if err != nil {
+ 		return false, err",This seems like a more interesting change. Maybe we should re-name the PR,Shouldn't this be `else if resp.StatusCode == http.StatusNotFound`?
+1982,"@@ -20,6 +20,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal
+                                                IApplicationTransportFeature,
+                                                ITransportSchedulerFeature,
+                                                IConnectionLifetimeFeature,
++                                               IConnectionHeartbeatFeature,
++                                               IConnectionLifetimeNotificationFeature,
+                                                IBytesWrittenFeature
+     {
+         // NOTE: When feature interfaces are added to or removed from this TransportConnection class implementation,",Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough.,What is the difference between the IConnectionLifetimeNotificationFeature and
+1983,"@@ -102,6 +102,7 @@ public class CSharpCommonTransformer {
+         .typeName(typeName)
+         .setCallName("""")
+         .addCallName("""")
++        .getCallName("""")
+         .isMap(false)
+         .isArray(false)
+         .isPrimitive(false)","Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags.",Is this necessary ?
+1984,"@@ -444,6 +444,7 @@ ExWorkProcRetcode ExHbaseScanSQTaskTcb::work(short &rc)
+   Lng32 retcode = 0;
+   rc = 0;
+   Lng32 remainingInBatch = batchSize_;
++  NABoolean isFirstBatch = false;
+
+   while (1)
+     {","Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?",Nit: Suggest renaming `isFirstBatch` to `isFirstEmbeddedBatch`.
+1985,"@@ -116,6 +116,14 @@ nebula::cpp2::HostAddr MetaServiceUtils::parseHostKey(folly::StringPiece key) {
+     return host;
+ }
+
++std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) {
++    std::string key;
++    key.reserve(kEdgesTable.size() + sizeof(GraphSpaceID));
++    key.append(kEdgesTable.data(), kEdgesTable.size());
++    key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
++    return key;
++}
++
+ std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId,
+                                             EdgeType edgeType,
+                                             int64_t version) {",You could reserve a const space to save the extra computation.,nit: const std::string &
+1986,"@@ -15,6 +15,8 @@ namespace System.IO.Tests
+         private readonly string _testPath200 = PerfUtils.CreateString(200);
+         private readonly string _testPath500 = PerfUtils.CreateString(500);
+         private readonly string _testPath1000 = PerfUtils.CreateString(1000);
++        private readonly string _testPathNoRedundantSegments = ""/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/Path.cs"";
++        private readonly string _testPathWithRedundantSegments = ""/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/..//./Path.cs"";
+
+         [Benchmark]
+         public string Combine() => Path.Combine(_testPath, _testPath10);",Did you consider adding rooted paths like `C:\ProgramData` and paths with flipped separators?,Would it make sense to move these two variables to the top of t
+1987,"@@ -93,10 +93,11 @@ func startDnsServer() {
+ 		Port: 53,
+ 	}
+ 	udpConn, err := net.ListenUDP(""udp"", laddr)
+-	defer udpConn.Close()
+ 	if err != nil {
+ 		klog.Errorf(""Dns server Start error : %s"", err)
++		return
+ 	}
++	defer udpConn.Close()
+ 	dnsConn = udpConn
+ 	for {
+ 		req := make([]byte, bufSize)",does this line cause a panic if it is above the if condition ?,Shouldn't this be err != nil?
+1988,"@@ -0,0 +1,5 @@
++package org.phoenicis.javafx.components.library.utils;
++
++public enum LibraryDetailsPanels {
++    ShortcutDetails, ShortcutCreation, ShortcutEditing, Closed;
++}",Maybe `LibraryDetailsPanelType` would be clearer.,I can't find where this is being used.
+1989,"@@ -149,7 +149,6 @@ static void runlevel_cb (runlevel_t *r, int level, int rc, double elapsed,
+ static void runlevel_io_cb (runlevel_t *r, const char *name,
+                             const char *msg, void *arg);
+
+-static int create_persistdir (attr_t *attrs, uint32_t rank);
+ static int create_rundir (attr_t *attrs);
+ static int create_broker_rundir (overlay_t *ov, void *arg);
+ static int create_dummyattrs (flux_t *h, uint32_t rank, uint32_t size);","minor nit - add ""persist-filesystem"" and ""persist-directory"" into commit message, as its something people may search on (maybe applies to a few other commit messages)","This function is now unused, it should"
+1990,"@@ -7662,8 +7662,6 @@ bool CoreChecks::ValidateEventStageMask(const ValidationStateTracker *state_data
+     return skip;
+ }
+
+-static const VkQueueFlagBits kQueueTypeArray[] = {VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT, VK_QUEUE_TRANSFER_BIT};
+-
+ bool CoreChecks::CheckStageMaskQueueCompatibility(VkCommandBuffer command_buffer, VkPipelineStageFlags stage_mask,
+                                                   VkQueueFlags queue_flags, const char *function, const char *src_or_dest,
+                                                   const char *error_code) const {",I verified offline with @jeremyg-lunarg this should be removed.,Can this just be deleted?
+1991,"@@ -65,6 +65,7 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) DError {
+ 	i.Workflow.Logger = i.Workflow.parent.Logger
+ 	i.Workflow.Name = s.name
+ 	i.Workflow.DefaultTimeout = s.Timeout
++	fmt.Println(""incldued_wf name:"", i.Workflow.Name, "" timeout:"", i.Workflow.DefaultTimeout)
+
+ 	var errs DError
+ Loop:","This should be removed? If not, typo in incldued_wf",Did you mean to leave this here?
+1992,"@@ -19,6 +19,7 @@ export const variant = ({
+
+ export default variant
+
+-export const buttonStyle = variant({ key: 'buttons' })
++export const buttonStyle =
++  variant({ key: 'buttons' }) || variant({ key: 'buttonStyles' })
+ export const textStyle = variant({ key: 'textStyles', prop: 'textStyle' })
+ export const colorStyle = variant({ key: 'colorStyles', prop: 'colors' })","Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work   I might be missing something, but are the tests all passing locally?",This would be a breaking change. Can we keep the old default behavior while adding the new prop?
+1993,"@@ -68,6 +68,15 @@ type MatchFile struct {
+ 	//
+ 	// Default is first_exist.
+ 	TryPolicy string `json:""try_policy,omitempty""`
++
++	// A list of delimiters to use to split the path in two
++	// when trying files. If empty, no splitting will
++	// occur, and the path will be tried as-is. For each
++	// split value, the left-hand side of the split,
++	// including the split value, will be the path tried.
++	// For example, the path `/remote.php/dav/` using the
++	// split value `.php` would try the file `/remote.php`.
++	SplitPath []string `json:""split_path,omitempty""`
+ }
+
+ // CaddyModule returns the Caddy module information.",Do you think the godoc should mention that all delimiters will be suffixed with `/`?,Is there an option to specify the delimiter (/remote.php/dav/ or /remote.php) instead of just a
+1994,"@@ -111,6 +111,8 @@ public class NavigationURLBar extends FrameLayout {
+                 return;
+             else if (aURL.startsWith(""resource:"") || SessionStore.get().isHomeUri(aURL))
+                 aURL = """";
++            else if (aURL.startsWith(""data:"") && SessionStore.get().isCurrentSessionPrivate())
++                aURL = SessionStore.PRIVATE_BROWSING_URI;
+             else
+                 index = aURL.indexOf(""://"");
+         }","what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,&times;`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug.",Why not use `SessionStore.isHomeUri(aURL)`?
+1995,"@@ -312,6 +312,7 @@ class DeleteFileIndex {
+   static class Builder {
+     private final FileIO io;
+     private final Set<ManifestFile> deleteManifests;
++    private long minSequenceNumber = 0L;
+     private Map<Integer, PartitionSpec> specsById = null;
+     private Expression dataFilter = Expressions.alwaysTrue();
+     private Expression partitionFilter = Expressions.alwaysTrue();","I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct.",Should this be a long instead of a long?
+1996,"@@ -68,7 +68,7 @@ public class ImageVersionDaoImpl implements ImageVersionDao {
+           + ""values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"";
+   private static final String SELECT_IMAGE_VERSION_BASE_QUERY =
+       ""select iv.id, iv.path, iv.description, ""
+-          + ""iv.version, cast(replace(iv.version, '.', '') as unsigned integer) as int_version, ""
++          + ""iv.version, cast(replace(iv.version, '.', '') as integer) as int_version, ""
+           + ""it.name, iv.state, iv.release_tag, iv.created_on, iv.created_by, iv.modified_on, ""
+           + ""iv.modified_by from image_versions iv, image_types it where it.id = iv.type_id"";
+   /**",For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing.,Thanks @rsandell for catching this bug!
+1997,"@@ -57,6 +57,8 @@ const defaultState = {
+ 	editorNoteStatuses: {},
+ };
+
++const MAX_HISTORY = 200;
++
+ const stateUtils = {};
+
+ const derivedStateCache_ = {};",Are there tests for this? What happens when you get to limit?,This constant doesn't seem to be used o
+1998,"@@ -174,7 +174,7 @@ module Bolt
+         data['config'] = {}
+       end
+
+-      unless Bolt::Util.windows? || data['config']['transport']
++      unless data['config']['transport']
+         data['config']['transport'] = 'local' if target.name == 'localhost'
+       end
+ ",Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`.,Use a guard clause instead of wrapping
+1999,"@@ -73,6 +73,15 @@ public class OpenPgpKeyPreference extends Preference {
+
+     @Override
+     protected void onClick() {
++        bindServiceAndGetSignKeyId(new Intent());
++    }
++
++    private void bindServiceAndGetSignKeyId(final Intent data) {
++        if (mServiceConnection != null) {
++            getSignKeyId(data);
++            return;
++        }
++
+         // bind to service
+         mServiceConnection = new OpenPgpServiceConnection(
+                 getContext().getApplicationContext(),","maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die","This is a no-op, please remove."
+2000,"@@ -61,5 +61,6 @@ namespace Nethermind.Core.Specs.Forks
+         public bool IsEip1052Enabled => true;
+         public bool IsEip1283Enabled => false;
+         public bool IsEip1234Enabled => true;
++        public bool IsEip1344Enabled => false;
+     }
+ }",Can we add Istanbul with this first EIP please? (or as a separate issue),"Please remove this entry, it's not used anywhere"
+2001,"@@ -71,10 +71,10 @@ func (sn Snapshot) ID() backend.ID {
+ func (sn *Snapshot) fillUserInfo() error {
+ 	usr, err := user.Current()
+ 	if err != nil {
+-		return err
++		return nil
+ 	}
+-
+ 	sn.Username = usr.Username
++
+ 	uid, err := strconv.ParseInt(usr.Uid, 10, 32)
+ 	if err != nil {
+ 		return err",I don't understand this change,This looks unrelated to the rest of the PR. Can
+2002,"@@ -2248,7 +2248,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, PrintError):
+             encrypted_e.setText(encrypted.decode('ascii'))
+         except BaseException as e:
+             traceback.print_exc(file=sys.stdout)
+-            self.show_warning(str(e))
++            self.show_warning(""Invalid Public key"")
+
+     def encrypt_message(self, address=''):
+         d = WindowModalDialog(self, _('Encrypt/decrypt Message'))",Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`,Did you mean to remove the `str(e)` call here?
+2003,"@@ -0,0 +1,13 @@
++var landmarks = axe.commons.aria.getRolesByType('landmark');
++var parent = axe.commons.dom.getComposedParent(node);
++while (parent){
++	var role = parent.getAttribute('role');
++	if (!role && (parent.tagName.toLowerCase() !== 'form')){
++		role = axe.commons.aria.implicitRole(parent);
++	}
++	if (role && landmarks.includes(role)){
++		return false;
++	}
++	parent = axe.commons.dom.getComposedParent(parent);
++}
++return true;",This needs to work with `role=form` too.,We should avoid calling `getRolesByType` for for
+2004,"@@ -1039,6 +1039,11 @@ Blockly.BlockSvg.prototype.handleDragFree_ = function(oldXY, newXY, e) {
+     }
+   }
+
++  // Always update previews for output connections.
++  if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {
++    updatePreviews = true;
++  }
++
+   if (updatePreviews) {
+     var candidateIsLast = (localConnection == lastOnStack);
+     this.updatePreviews(closestConnection, localConnection, radiusConnection,","This should be before the if on line 1028, which should turn into an else if",Is there a reason why we wouldn't want to only do this for output connections?
+2005,"@@ -27,6 +27,13 @@ type ClusterNetworkPolicySpecBuilder struct {
+ 	Name string
+ }
+
++type ACNPRuleAppliedToSpec struct {
++	PodSelector         map[string]string
++	NSSelector          map[string]string
++	PodSelectorMatchExp *[]metav1.LabelSelectorRequirement
++	NSSelectorMatchExp  *[]metav1.LabelSelectorRequirement
++}
++
+ func (b *ClusterNetworkPolicySpecBuilder) Get() *secv1alpha1.ClusterNetworkPolicy {
+ 	if b.Spec.Ingress == nil {
+ 		b.Spec.Ingress = []secv1alpha1.Rule{}","Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?",Why is this in the `v1` package? I don't see it referenced anywhere.
+2006,"@@ -98,10 +98,10 @@ func (r *RTTStats) UpdateRTT(sendDelta, ackDelay time.Duration, now time.Time) {
+ 	r.updateRecentMinRTT(sendDelta, now)
+
+ 	// Correct for ackDelay if information received from the peer results in a
+-	// positive RTT sample. Otherwise, we use the sendDelta as a reasonable
+-	// measure for smoothedRTT.
++	// an RTT sample at least as large as minRTT. Otherwise, only use the
++	// sendDelta.
+ 	sample := sendDelta
+-	if sample > ackDelay {
++	if sample-r.minRTT >= ackDelay {
+ 		sample -= ackDelay
+ 	}
+ 	r.latestRTT = sample","Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?","I'm not familiar with the other part of the code, but wouldn't it be more accu"
+2007,"@@ -10,8 +10,8 @@ namespace Microsoft.CodeAnalysis.Sarif
+     /// <summary>
+     /// Defines methods to support the comparison of objects of type SarifLog for equality.
+     /// </summary>
+-    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.31.0.0"")]
+-    public sealed class SarifLogEqualityComparer : IEqualityComparer<SarifLog>
++    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.32.0.0"")]
++    internal sealed class SarifLogEqualityComparer : IEqualityComparer<SarifLog>
+     {
+         internal static readonly SarifLogEqualityComparer Instance = new SarifLogEqualityComparer();
+ ","Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one.","@marek-safar, why do we need to specify the version number for the generated c"
+2008,"@@ -19,6 +19,10 @@ class GuidancePolicy < ApplicationPolicy
+     user.can_modify_guidance? && guidance.in_group_belonging_to?(user.org_id)
+   end
+
++  def index?
++    admin_index?
++  end
++
+   def admin_index?
+     user.can_modify_guidance?
+   end",nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies,should this be `admin_index?` since it's the same as the method above?
+2009,"@@ -612,3 +612,14 @@ TEST_F(BadPonyTest, FieldReferenceInDefaultArgument)
+
+   TEST_ERRORS_1(src, ""can't reference 'this' in a default argument"");
+ }
++
++
++TEST_F(BadPonyTest, DefaultArgScope)
++{
++  const char* src =
++    ""actor A\n""
++    ""  fun foo(x: None = (let y = None; y)) =>\n""
++    ""    y"";
++
++  TEST_ERRORS_1(src, ""can't find declaration of 'y'"");
++}","Small formatting thing, but can you remove the space before the semicolon?","Yeah, I didn't know you could do that. Good job finding and fixing."
+2010,"@@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+
+             var reading = Task.Run(async () =>
+             {
+-                int remaining = InnerLoopCount * _writeLenght;
++                long remaining = InnerLoopCount * _writeLenght;
+                 while (remaining != 0)
+                 {
+                     var result = await _pipe.Reader.ReadAsync();","Not new, but nit: _writeLeng*th*.","Not related to this PR, but `int` should be `long` here."
+2011,"@@ -133,6 +133,13 @@ func TestComposeCmd(t *testing.T) {
+ 	assert.Error(err)
+ }
+
++func TestCheckCompose(t *testing.T) {
++	assert := asrt.New(t)
++
++	err := CheckDockerCompose()
++	assert.NoError(err)
++}
++
+ func TestGetAppContainers(t *testing.T) {
+ 	assert := asrt.New(t)
+ 	sites, err := GetAppContainers(""dockertest"")","Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions.",This should probably be called `TestCheckDockerCompose` for the same r
+2012,"@@ -3,11 +3,12 @@ package volume
+ import (
+ 	""crypto/tls""
+ 	""encoding/json""
+-	""github.com/libopenstorage/openstorage/api""
+-	""github.com/stretchr/testify/require""
+ 	""net/http""
+ 	""net/http/httptest""
+ 	""testing""
++
++	""github.com/libopenstorage/openstorage/api""
++	""github.com/stretchr/testify/require""
+ )
+
+ func TestClientTLS(t *testing.T) {",Remove this file from the PR,Is this reordering needed?
+2013,"@@ -488,7 +488,7 @@ Blockly.Variables.renameVariable = function(workspace, variable,
+   var validate = Blockly.Variables.nameValidator_.bind(null, varType);
+
+   var promptText = promptMsg.replace('%1', variable.name);
+-  Blockly.prompt(promptText, '',
++  Blockly.prompt(promptText, variable.name,
+       function(newName, additionalVars) {
+         if (variable.isCloud &&
+             newName.length > 0 && newName.indexOf(Blockly.Variables.CLOUD_PREFIX) == 0 ) {","I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:",nit: can we update this va
+2014,"@@ -16,7 +16,8 @@ struct wlr_pointer *create_libinput_pointer(
+ 		wlr_log(WLR_ERROR, ""Unable to allocate wlr_pointer"");
+ 		return NULL;
+ 	}
+-	wlr_pointer_init(wlr_pointer, NULL);
++	wlr_pointer_init(wlr_pointer, NULL,
++		libinput_device_config_tap_get_finger_count(libinput_dev) > 0);
+ 	return wlr_pointer;
+ }
+ ",I think I would rather fish this interface through than use it as the basis for heuristics.,libinput_device_config_tap
+2015,"@@ -153,7 +153,7 @@ namespace pwiz.Skyline.Controls.Graphs
+             public static float QValueCutoff
+             {
+                 get => Properties.Settings.Default.DetectionsQValueCutoff;
+-                set => Properties.Settings.Default.DetectionsQValueCutoff = value;
++                set => Properties.Settings.Default.DetectionsQValueCutoff = value;
+             }
+
+             public static TargetType TargetType","Probably not worth making this line-ending change, since it is the only change to this file.",@JeremyKuhne I think this
+2016,"@@ -1180,8 +1180,13 @@ encode_opnd_x0(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ static inline bool
+ decode_opnd_memx0(uint enc, int opcode, byte *pc, OUT opnd_t *opnd)
+ {
++#ifdef DR_HOST_NOT_TARGET
++    CLIENT_ASSERT(opnd_size_in_bytes(OPSZ_CACHE_LINE) == 64, ""OPSZ_CACHE_LINE != 64"");
++#endif
+     *opnd = opnd_create_base_disp(decode_reg(extract_uint(enc, 0, 5), true, false),
+-                                  DR_REG_NULL, 0, 0, OPSZ_sys);
++                                  DR_REG_NULL, 0, 0, OPSZ_CACHE_LINE);
++    if (!opnd_set_base_aligned(opnd, true))
++        return false;
+     return true;
+ }
+ ","Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?",probably should assert that opnd_size_in_bytes(OPSZ_CACHE_LINE) != 64
+2017,"@@ -3,7 +3,7 @@ package hardware
+ import (
+ 	""github.com/shirou/gopsutil/mem""
+ 	""github.com/sonm-io/core/insonmnia/hardware/cpu""
+-	""github.com/sonm-io/core/insonmnia/hardware/gpu""
++	pb ""github.com/sonm-io/core/proto""
+ )
+
+ // Hardware accumulates the finest hardware information about system the miner",No pb please,why is this part of this PR?
+2018,"@@ -0,0 +1,11 @@
++require 'migrate'
++class AddJoinTableBetweenUsersAndChangesets < ActiveRecord::Migration
++  def change
++    create_table :changesets_subscribers, id: false do |t|
++      t.column :subscriber_id, :bigint, null: false
++      t.column :changeset_id, :bigint, null: false
++    end
++    add_foreign_key :changesets_subscribers, [:subscriber_id], :users, [:id]
++    add_foreign_key :changesets_subscribers, [:changeset_id], :changesets, [:id]
++  end
++end","We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset.",Style/SymbolArray: Use %i or %I for an array of symbols.
+2019,"@@ -0,0 +1,13 @@
++package slackbot
++
++import (
++	""github.com/slack-go/slack""
++)
++
++func sendBotReply(client *slack.Client, channel, message string) error {
++	_, _, err := client.PostMessage(channel, slack.MsgOptionText(message, false))
++	if err != nil {
++		return err
++	}
++	return nil
++}","use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on.",This should probably be `error` to be consistent with the other error
+2020,"@@ -64,9 +64,7 @@ def implements(
+     obj: ""BaseChecker"",
+     interface: Union[Type[""Interface""], Tuple[Type[""Interface""], ...]],
+ ) -> bool:
+-    """"""Return whether the given object (maybe an instance or class) implements
+-    the interface.
+-    """"""
++    """"""Does the given object (maybe an instance or class) implements the interface.""""""
+     kimplements = getattr(obj, ""__implements__"", ())
+     if not isinstance(kimplements, (list, tuple)):
+         kimplements = (kimplements,)","""not to be used elsewhere other than""",This should say `Returns whether the given object (maybe an instance or class) implements the interface.`
+2021,"@@ -205,6 +205,7 @@ class SparkAppenderFactory implements FileAppenderFactory<InternalRow> {
+         case PARQUET:
+           return Parquet.writeDeletes(file.encryptingOutputFile())
+               .createWriterFunc(msgType -> SparkParquetWriters.buildWriter(lazyEqDeleteSparkType(), msgType))
++              .setAll(properties)
+               .overwrite()
+               .rowSchema(eqDeleteRowSchema)
+               .withSpec(spec)","Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ...",Is it possible to use `ImmutableList.copyOf(properties)` instead?
+2022,"@@ -0,0 +1,7 @@
++class AddIndexToSubscriptions < ActiveRecord::Migration
++  def change
++    add_index :subscriptions, :user_id
++    add_index :subscriptions, :team_id
++    add_index :subscriptions, [:plan_id, :plan_type]
++  end
++end",These additions seem unrelated to this change?,Align the elements of an array literal if they span more than one line.
+2023,"@@ -126,4 +126,8 @@ public class TableProperties {
+
+   public static final String SNAPSHOT_ID_INHERITANCE_ENABLED = ""compatibility.snapshot-id-inheritance.enabled"";
+   public static final boolean SNAPSHOT_ID_INHERITANCE_ENABLED_DEFAULT = false;
++
++  public static final String ENGINE_HIVE_ENABLED = ""engine.hive.enabled"";
++  public static final String ENGINE_HIVE_ENABLED_HIVE_CONF = ""iceberg.engine.hive.enabled"";
++  public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+ }","Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?",Isn't there a similar property in `IcebergConfiguration` ?
+2024,"@@ -95,19 +95,6 @@ func (r *ChaosCollector) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
+ 		manageFlag = true
+ 	}
+
+-	if obj.IsDeleted() {
+-		if !manageFlag {
+-			if err = r.archiveExperiment(req.Namespace, req.Name); err != nil {
+-				r.Log.Error(err, ""failed to archive experiment"")
+-			}
+-		} else {
+-			if err = r.event.DeleteByUID(ctx, string(chaosMeta.GetUID())); err != nil {
+-				r.Log.Error(err, ""failed to delete experiment related events"")
+-			}
+-		}
+-		return ctrl.Result{}, nil
+-	}
+-
+ 	if err := r.setUnarchivedExperiment(req, obj); err != nil {
+ 		r.Log.Error(err, ""failed to archive experiment"")
+ 		// ignore error here",The related statements should also be deleted.,why delete these?
+2025,"@@ -455,6 +455,10 @@ class ELBConnection(AWSQueryConnection):
+                     'LoadBalancerName'          : lb_name,
+                     'LoadBalancerPort'          : lb_port,
+                  }
++        if policies:
++            self.build_list_params(params, policies, 'PolicyNames.member.%d')
++        else:
++            params[""PolicyNames""] = """"
+         self.build_list_params(params, policies, 'PolicyNames.member.%d')
+         return self.get_status('SetLoadBalancerPoliciesOfListener', params)
+ ",Shouldn't this line be removed?,"this seems weird,"
+2026,"@@ -0,0 +1,7 @@
++bad_names = set([
++    'TEAM',
++    'PUBLIC'
++])
++
++def blacklisted_name(username):
++    return username in bad_names","Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const.",I'm not sure why
+2027,"@@ -294,6 +294,7 @@ public class PasscodeActivity extends Activity {
+                 launchBiometricAuth();
+             } else {
+                 setMode(PasscodeMode.Check);
++                newMode = PasscodeMode.Check;
+             }
+             break;
+         }","Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted.",Does this need to
+2028,"@@ -51,7 +51,7 @@ import org.tikv.kvproto.Coprocessor.KeyRange;
+ public class ScanAnalyzer {
+   private static final double INDEX_SCAN_COST_FACTOR = 1.2;
+   private static final double TABLE_SCAN_COST_FACTOR = 1.0;
+-  private static final double DOUBLE_READ_COST_FACTOR = TABLE_SCAN_COST_FACTOR * 3;
++  private static final double DOUBLE_READ_COST_FACTOR = 0.2; // TABLE_SCAN_COST_FACTOR * 3;
+
+   public static class ScanPlan {
+     ScanPlan(",Need change it back?,I don't understand why this change is needed.
+2029,"@@ -0,0 +1,12 @@
++# Be sure to restart your server when you modify this file.
++
++# Your secret key is used for verifying the integrity of signed cookies.
++# If you change this key, all old signed cookies will become invalid!
++
++# Make sure the secret is at least 30 characters and all random,
++# no regular words or you'll be exposed to dictionary attacks.
++# You can use `rake secret` to generate a secure secret key.
++
++# Make sure your secret_key_base is kept private
++# if you're sharing your code publicly.
++OpenStreetMap::Application.config.secret_key_base = '8be565e2e25831d88231f4bcfd83dfc3ab33957c4f33bb3cff7a279f7820ec4d0c1111f246bb347c68859c0b46b4e591be9179a53a5a7165a9936000d6d2be41'",Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?,Line is too long. [101/80]
+2030,"@@ -2,6 +2,7 @@ using System;
+ using System.Collections.Concurrent;
+ using System.Collections.Generic;
+ using System.IO;
++using Datadog.Trace.ExtensionMethods;
+ using Datadog.Trace.Logging;
+ using Newtonsoft.Json;
+ using Newtonsoft.Json.Linq;",nit: Looks like this can be removed now,Can you remove this line?
+2031,"@@ -54,15 +54,9 @@ func (p *PKI) Provision(ctx caddy.Context) error {
+ 	p.ctx = ctx
+ 	p.log = ctx.Logger(p)
+
+-	// if this app is initialized at all, ensure there's at
+-	// least a default CA that can be used: the standard CA
+-	// which is used implicitly for signing local-use certs
+ 	if p.CAs == nil {
+ 		p.CAs = make(map[string]*CA)
+ 	}
+-	if _, ok := p.CAs[DefaultCAID]; !ok {
+-		p.CAs[DefaultCAID] = new(CA)
+-	}
+
+ 	for caID, ca := range p.CAs {
+ 		err := ca.Provision(ctx, caID, p.log)","Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil.",I'm not sure if this is safe to remove. Would
+2032,"@@ -260,11 +260,15 @@ static void on_context_dispose(h2o_handler_t *_self, h2o_context_t *ctx)
+
+ void h2o_status_register(h2o_pathconf_t *conf)
+ {
++    static int handler_registered = 0;
+     struct st_h2o_root_status_handler_t *self = (void *)h2o_create_handler(conf, sizeof(*self));
+     self->super.on_context_init = on_context_init;
+     self->super.on_context_dispose = on_context_dispose;
+     self->super.on_req = on_req;
+-    h2o_config_register_status_handler(conf->global, requests_status_handler);
+-    h2o_config_register_status_handler(conf->global, events_status_handler);
+-    h2o_config_register_status_handler(conf->global, durations_status_handler);
++    if (!handler_registered) {
++        handler_registered++;
++        h2o_config_register_status_handler(conf->global, requests_status_handler);
++        h2o_config_register_status_handler(conf->global, events_status_handler);
++        h2o_config_register_status_handler(conf->global, durations_status_handler);
++    }
+ }",Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?,This means there is no need to register the handler more than once. We can just use the existing one.
+2033,"@@ -20,7 +20,7 @@ def function():
+     #todo: no space after hash
+
+     # +1: [fixme]
+-	# FIXME: this is broken
++    # FIXME: this is broken
+     # +1: [fixme]
+     # ./TODO: find with notes
+ 	# +1: [fixme]","I think the functional test should not change here, this is probably a test in itself :)",Standards: Please add a space after commas.
+2034,"@@ -31,7 +31,16 @@ import (
+ 	""github.com/gogits/gogs/modules/setting""
+ )
+
+-var Sanitizer = bluemonday.UGCPolicy().AllowAttrs(""class"").Matching(regexp.MustCompile(`[\p{L}\p{N}\s\-_',:\[\]!\./\\\(\)&]*`)).OnElements(""code"")
++func BuildSanitizer() (p *bluemonday.Policy) {
++	p = bluemonday.UGCPolicy()
++	p.AllowAttrs(""class"").Matching(regexp.MustCompile(`[\p{L}\p{N}\s\-_',:\[\]!\./\\\(\)&]*`)).OnElements(""code"")
++
++	p.AllowAttrs(""type"").Matching(regexp.MustCompile(`^checkbox$`)).OnElements(""input"")
++	p.AllowAttrs(""checked"", ""disabled"").OnElements(""input"")
++	return p
++}
++
++var Sanitizer = BuildSanitizer()
+
+ // EncodeMD5 encodes string to md5 hex value.
+ func EncodeMD5(str string) string {",Why this to be a public function?,why not using `RedundantBuildSanitizer`?
+2035,"@@ -21,7 +21,7 @@ module Travis
+         end
+
+         def set(var, value, options = {})
+-          cmd ""export #{var}=#{value}"", options.merge(log: false)
++          cmd ""export #{var}=#{value}"", options.merge(log: false, timing: false)
+         end
+
+         def echo(string, options = {})",I think we can remove the timing for export env vars,this should be prefixed with `is_timing: true` so it doesn't show up in the logs
+2036,"@@ -29,8 +29,10 @@ limitations under the License.
+ // limitations under the License.
+
+ Modifies:
+-- Remove interface ""Provider""
+-- Remove import ""k8s.io/kubernetes/pkg/proxy/config""
++- Replace import ""k8s.io/kubernetes/pkg/proxy/config"" with ""github.com/vmware-tanzu/antrea/third_party/proxy/config""
++- Remove config.EndpointSliceHandler, config.NodeHandler from Provider interface type
++- Remove NodeHandler, EndpointSliceHandler, Sync() from Provider interface
++- Add Run(), GetServiceByIP() to Provider interface
+ */
+
+ package proxy",wrong import grouping,Why do we need this change?
+2037,"@@ -232,8 +232,7 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
+                         if (newValue.equals(""page"")) {
+                             final Context context = ui.getActivity();
+                             final String[] navTitles = context.getResources().getStringArray(R.array.back_button_go_to_pages);
+-                            final String[] navTags = new String[3];
+-                            System.arraycopy(MainActivity.NAV_DRAWER_TAGS, 0, navTags, 0, 3);
++                            final String[] navTags = context.getResources().getStringArray(R.array.back_button_go_to_pages_tags);
+                             final String choice[] = { UserPreferences.getBackButtonGoToPage() };
+
+                             AlertDialog.Builder builder = new AlertDialog.Builder(context);",There is a doubled semicolon ;),Is it possible to change `n
+2038,"@@ -40,6 +40,10 @@
+
+
+ #include <math.h>
++#include <zlib.h>
++#include ""openssl/md5.h""
++#include <openssl/sha.h>
++
+ #define MathSqrt(op, err) sqrt(op)
+
+ #include <ctype.h>",I'm wondering why this isn't <openssl/md5.h>. Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?,Please include standard lib
+2039,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?,Shouldn't this be `all`?
+2040,"@@ -229,6 +229,16 @@ bool Mob::CastSpell(uint16 spell_id, uint16 target_id, CastingSlot slot,
+ 		return false;
+ 	}
+
++	if (IsEffectInSpell(spell_id, SE_Charm) && !PassCharmTargetRestriction(entity_list.GetMobID(target_id))) {
++		if (IsClient()) {
++			CastToClient()->SendSpellBarEnable(spell_id);
++		}
++		if (casting_spell_id && IsNPC()) {
++			CastToNPC()->AI_Event_SpellCastFinished(false, static_cast<uint16>(casting_spell_slot));
++		}
++		return false;
++	}
++
+ 	if (HasActiveSong() && IsBardSong(spell_id)) {
+ 		LogSpells(""Casting a new song while singing a song. Killing old song [{}]"", bardsong);
+ 		//Note: this does NOT tell the client","We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable.",why was this added?
+2041,"@@ -63,6 +63,7 @@ def define_violation(dbengine):
+         full_name = Column(String(1024))
+         inventory_data = Column(Text(16777215))
+         inventory_index_id = Column(String(256))
++        invocation_id = Column(DateTime())
+         resource_id = Column(String(256), nullable=False)
+         resource_type = Column(String(256), nullable=False)
+         rule_name = Column(String(256))","This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`.",Why do we need this
+2042,"@@ -412,6 +412,18 @@ func (tx Transaction) TxAmount() basics.MicroAlgos {
+ 	}
+ }
+
++// GetReceiverAddress returns the address of the receiver. If the transaction has no receiver, it returns the empty address.
++func (tx Transaction) GetReceiverAddress() basics.Address {
++	switch tx.Type {
++	case protocol.PaymentTx:
++		return tx.PaymentTxnFields.Receiver
++	case protocol.AssetTransferTx:
++		return tx.AssetTransferTxnFields.AssetReceiver
++	default:
++		return basics.Address{}
++	}
++}
++
+ // EstimateEncodedSize returns the estimated encoded size of the transaction including the signature.
+ // This function is to be used for calculating the fee
+ func (tx Transaction) EstimateEncodedSize() int {",should the 'Receiver' be the clawback address in case of clawback transaction?,Can we call this `G
+2043,"@@ -19,10 +19,16 @@ package command
+ import (
+ 	""errors""
+ 	""flag""
+-
+ 	""github.com/spf13/cobra""
+ )
+
++const (
++	// VolumeAPIPath is the api path to get volume information
++	VolumeAPIPath      = ""/latest/volumes/""
++	controllerStatusOk = ""running""
++	volumeStatusOK     = ""Running""
++)
++
+ var (
+ 	volumeCommandHelpText = `
+ The following commands helps in operating a Volume such as create, list, and so on.",@ashishranjan738 -- Where are these consts used? in which pkg?,nit: let's follow t
+2044,"@@ -81,12 +81,12 @@ autodoc_default_options = {
+     ""show-inheritance"": True,
+ }
+
++# Generate autosummary pages. Output should be set with: `:toctree: pythonapi/`
++autosummary_generate = ['Python-API.rst']
++
+ # Add any paths that contain templates here, relative to this directory.
+ templates_path = ['_templates']
+
+-# Generate autosummary pages. Output should be set with: `:toctree: pythonapi/`
+-autosummary_generate = True
+-
+ # The suffix(es) of source filenames.
+ # You can specify multiple suffix as a list of string:
+ # source_suffix = ['.rst', '.md']",The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller.,"I think this should be `:toctree:`, not `:toctree:`."
+2045,"@@ -1862,8 +1862,8 @@ func (fbo *folderBranchOps) unembedBlockChanges(
+
+ 	md.AddRefBytes(uint64(info.EncodedSize))
+ 	md.AddDiskUsage(uint64(info.EncodedSize))
+-	changes.Info = info
+ 	md.data.cachedChanges = *changes
++	changes.Info = info
+ 	changes.Ops = nil
+ 	return nil
+ }","Having it above kept the block info in the cached changes, which could end up confusing things quite a bit.",why remove this line?
+2046,"@@ -409,15 +409,7 @@ HELP
+                 outputter.print_event(node, event)
+               end
+             when 'task'
+-              task_name = options[:object]
+-
+-              path, metadata = load_task_data(task_name, @config[:modulepath])
+-              input_method = metadata['input_method']
+-
+-              input_method ||= 'both'
+-              executor.run_task(
+-                nodes, path, input_method, options[:task_options]
+-              ) do |node, event|
++              execute_task(executor, options) do |node, event|
+                 outputter.print_event(node, event)
+               end
+             when 'file'","If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.).",Metrics/BlockLength: Block has too many lines. [30/2
+2047,"@@ -199,7 +199,7 @@ func (c *client) InstallTunnelFlows(tunnelOFPort uint32) error {
+
+ func (c *client) Initialize() error {
+ 	// Initiate connections to target OFswitch, and create tables on the switch.
+-	if err := c.bridge.Connect(maxRetryForOFSwitch); err != nil {
++	if err := c.bridge.Connect(maxRetryForOFSwitch, make(chan struct{})); err != nil {
+ 		return err
+ 	}
+ ","Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?",Not sure if this is blocking or not. If it is not we
+2048,"@@ -1001,6 +1001,12 @@ void RaftPart::processAppendLogResponses(const AppendLogResponses& resps,
+     LOG_EVERY_N(WARNING, 100) << idStr_ << ""Only "" << numSucceeded
+                               << "" hosts succeeded, Need to try again"";
+     usleep(1000);
++    {
++      std::lock_guard<std::mutex> g(raftLock_);
++      // wal could be rollback between two cycles, if we still use the old lastLogId, we may always
++      // get E_RAFT_NO_WAL_FOUND
++      lastLogId = std::min(wal_->lastLogId(), lastLogId);
++    }
+     replicateLogs(eb, std::move(iter), currTerm, lastLogId, committedId, prevLogTerm, prevLogId);
+   }
+ }","There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details.","Shouldn't this happen before the replicate logs call? If the wal could be rollback between two cycles, we might still get E_RAFT_NO_WAL_FOUND."
+2049,"@@ -164,7 +164,7 @@ class OrderFlow extends FormFlow
+         $request = $this->getRequest()->request;
+         $requestParameters = $request->all();
+         $requestParameters['flow_order_step'] = $step->getNumber();
+-        $requestParameters[$step->getFormType()->getName()] = $stepData;
++        $requestParameters[$step->getFormType()] = $stepData;
+         $request->replace($requestParameters);
+     }
+ }","Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you.",i think we need to keep `FormType::getName()` here
+2050,"@@ -62,6 +62,19 @@ gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
+ EOM
+ yum -y install google-osconfig-agent
+ echo 'inventory install done'`
++var installInventoryYumEL6 = `sleep 10
++cat > /etc/yum.repos.d/google-osconfig-agent.repo <<EOM
++[google-osconfig-agent]
++name=Google OSConfig Agent Repository
++baseurl=https://packages.cloud.google.com/yum/repos/google-osconfig-agent-el6-unstable
++enabled=1
++gpgcheck=0
++repo_gpgcheck=1
++gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
++       https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg
++EOM
++yum -y install google-osconfig-agent
++echo 'inventory install done'`
+
+ type inventoryTestSetup struct {
+ 	image       string","i was confused by keyword ""inventory"" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong).",does this belong in the `yum-agent.sh` file?
+2051,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities",`timeouts` -> `timeouts`
+2052,"@@ -1,5 +1,6 @@
+ import { options, createElement as h, render } from 'preact';
+ import { useEffect, useState } from 'preact/hooks';
++import sinon from 'sinon';
+
+ import { setupScratch, teardown } from '../../../test/_util/helpers';
+ import { act } from '../../src';",This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file.,Is this import necessary? I don't see it being used in this file
+2053,"@@ -12,6 +12,18 @@ import (
+ 	""github.com/lucas-clemente/quic-go/utils""
+ )
+
++const (
++	// Maximum reordering in time space before time based loss detection considers a packet lost.
++	// In fraction of an RTT.
++	timeReorderingFraction = 1.0 / 8
++	// defaultRTOTimeout is the RTO time on new connections
++	defaultRTOTimeout = 500 * time.Millisecond
++	// Minimum time in the future an RTO alarm may be set for.
++	minRTOTimeout = 200 * time.Millisecond
++	// maxRTOTimeout is the maximum RTO time
++	maxRTOTimeout = 60 * time.Second
++)
++
+ var (
+ 	// ErrDuplicateOrOutOfOrderAck occurs when a duplicate or an out-of-order ACK is received
+ 	ErrDuplicateOrOutOfOrderAck = errors.New(""SentPacketHandler: Duplicate or out-of-order ACK"")",Maybe move all the Loss Recovery constants to a separate file.,I think this should be defined in the lib/server/constants.go fi
+2054,"@@ -145,6 +145,7 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError {
+ }
+
+ type diskAttachment struct {
++	diskName           string
+ 	mode               string
+ 	attacher, detacher *Step
+ }",this field is added so that we can find disk name by device name from attachments,Why is this exported? It seems to be used only in internal packa
+2055,"@@ -1,5 +1,6 @@
+ package com.fsck.k9.activity;
+
++
+ import android.content.BroadcastReceiver;
+ import android.content.Context;
+ import android.content.Intent;",Unnecessary new line,nit: remove spacing change here
+2056,"@@ -1893,13 +1893,15 @@ func (c *linuxContainer) currentState() (*State, error) {
+ 			state.NamespacePaths[ns.Type] = ns.GetPath(pid)
+ 		}
+ 		for _, nsType := range configs.NamespaceTypes() {
+-			if !configs.IsNamespaceSupported(nsType) {
++			if _, ok := state.NamespacePaths[nsType]; ok {
+ 				continue
+ 			}
+-			if _, ok := state.NamespacePaths[nsType]; !ok {
+-				ns := configs.Namespace{Type: nsType}
+-				state.NamespacePaths[ns.Type] = ns.GetPath(pid)
++			if !configs.IsNamespaceSupported(nsType) {
++				continue
+ 			}
++			ns := configs.Namespace{Type: nsType}
++			state.NamespacePaths[ns.Type] = ns.GetPath(pid)
++
+ 		}
+ 	}
+ 	return state, nil","First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`",Why did this change?
+2057,"@@ -1,7 +1,5 @@
+-<section class=""assets-wrapper"">
+-  <div class=""assets"">
+-    <%= render ""videos/download_link"", download_type_key: ""OriginalFile"", download_type: ""original"", size_display: ""Original (720p)"", clip: clip %>
+-    <%= render ""videos/download_link"", download_type_key: ""IphoneVideoFile"", download_type: ""iphone"", size_display: ""iPhone"", clip: clip %>
+-    <%= render ""videos/download_link"", download_type_key: ""HdMp4VideoFile"", download_type: ""hd_mp4"", size_display: ""HD MP4"", clip: clip %>
+-  </div>
++<section class=""download-links"">
++  <%= render ""videos/download_link"", download_type_key: ""OriginalFile"", download_type: ""original"", size_display: ""Original (720p)"", clip: clip %>
++  <%= render ""videos/download_link"", download_type_key: ""IphoneVideoFile"", download_type: ""iphone"", size_display: ""iPhone"", clip: clip %>
++  <%= render ""videos/download_link"", download_type_key: ""HdMp4VideoFile"", download_type: ""hd_mp4"", size_display: ""HD MP4"", clip: clip %>
+ </section>",What changed in the styles that means we don't need this?,HdMp4VideoFile was r
+2058,"@@ -275,13 +275,13 @@ namespace Microsoft.DotNet.Build.Tasks
+            }
+         }
+
+-        private JToken GetFrameworkDependenciesSection(JObject projectJsonRoot, string framework = null)
++        private JObject GetFrameworkDependenciesSection(JObject projectJsonRoot, string framework = null)
+         {
+             if(string.IsNullOrWhiteSpace(framework))
+             {
+-                return projectJsonRoot[""dependencies""];
++                return (JObject) projectJsonRoot[""dependencies""];
+             }
+-            return projectJsonRoot.SelectToken(""frameworks."" + NewtonsoftEscapeJProperty(framework) + "".dependencies"");
++            return (JObject) projectJsonRoot[""frameworks""][framework][""dependencies""];
+         }
+
+         // Generate the combines dependencies from the projectjson jObject and from AdditionalDependencies",This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method.,This will throw an e
+2059,"@@ -165,6 +165,10 @@ class Histogram(Element2D):
+     vdims = param.List(default=[Dimension('Frequency')], bounds=(1,1))
+
+     def __init__(self, values, edges=None, **params):
++        if edges is not None:
++            self.warning(""Histogram edges should be supplied as a tuple ""
++                         ""along with the values, passing the edges will ""
++                         ""be deprecated in holoviews 2.0."")
+         self.values, self.edges, settings = self._process_data(values, edges)
+         settings.update(params)
+         super(Histogram, self).__init__((self.values, self.edges), **settings)",Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else.,"How about: ""Histogra"
+2060,"@@ -892,6 +892,7 @@ spec:
+                     values:
+                     - {{ $targetAffinityVal }}
+                 topologyKey: kubernetes.io/hostname
++                namespaces: [{{.Volume.runNamespace}}]
+           {{- end }}
+           containers:
+           - args:",What does this contain? Is it PVC namespace or is it openebs?,Shouldn't this be `{{.Volume.runNamespace}}`?
+2061,"@@ -0,0 +1,18 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
++{
++    /// <summary>
++    /// Represents a minimum data rate for the request body of an HTTP request.
++    /// </summary>
++    public interface IHttpRequestBodyMinimumDataRateFeature
++    {
++        /// <summary>
++        /// The minimum data rate in bytes/second at which the request body should be received.
++        /// Setting this property to null indicates no minimum data rate should be enforced.
++        /// This limit has no effect on upgraded connections which are always unlimited.
++        /// </summary>
++        MinimumDataRate MinimumDataRate { get; set; }
++    }
++}","Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions.",Why not an `IHttpRequestBody`?
+2062,"@@ -426,11 +426,12 @@ LGBM_SE LGBM_BoosterGetEvalNames_R(LGBM_SE handle,
+   LGBM_SE buf_len,
+   LGBM_SE actual_len,
+   LGBM_SE eval_names,
+-  LGBM_SE call_state) {
++  LGBM_SE call_state,
++  LGBM_SE data_idx) {
+
+   R_API_BEGIN();
+   int len;
+-  CHECK_CALL(LGBM_BoosterGetEvalCounts(R_GET_PTR(handle), &len));
++  CHECK_CALL(LGBM_BoosterGetEvalCounts(R_GET_PTR(handle), R_AS_INT(data_idx), &len));
+   std::vector<std::vector<char>> names(len);
+   std::vector<char*> ptr_names(len);
+   for (int i = 0; i < len; ++i) {","this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument.",This should probably be `R_AS_INT(data_idx)`.
+2063,"@@ -182,9 +182,13 @@ final class MediaController
+     public function getMediumFormatsAction($id): FOSRestView
+     {
+         $media = $this->getMedium($id);
++        $mediaContext = $media->getContext();
+
+         $formats = [MediaProviderInterface::FORMAT_REFERENCE];
+-        $formats = array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($media->getContext())));
++
++        if (null !== $mediaContext) {
++            $formats = array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($mediaContext)));
++        }
+
+         $provider = $this->mediaPool->getProvider($media->getProviderName());
+ ",Shouldn't we throw an exception if the context is null instead ?,Isn't this a BC break? Shouldn't we use `Medi
+2064,"@@ -13,6 +13,9 @@ var DdevVersion = ""v0.3.0-dev"" // Note that this is overridden by make
+ // for examples defining version constraints.
+ var DockerVersionConstraint = "">= 17.05.0-ce""
+
++// DockerComposeVersionConstraint is the current minimum version of docker-compose required for ddev.
++var DockerComposeVersionConstraint = "">= 1.10.0""
++
+ // WebImg defines the default web image used for applications.
+ var WebImg = ""drud/nginx-php-fpm-local"" // Note that this is overridden by make
+ ","These should both be const, not var right?",This should be 1.10.0-ce
+2065,"@@ -0,0 +1,8 @@
++from mmcv.utils import Registry, build_from_cfg
++
++MATCH_COST = Registry('Match Cost')
++
++
++def build_match_cost(cfg, default_args=None):
++    """"""Builder of IoU calculator.""""""
++    return build_from_cfg(cfg, MATCH_COST, default_args)","Rename the directory, match_costers -> match_costs",The docstring should be
+2066,"@@ -64,6 +64,13 @@ class DeleteModelTest(BaseTest):
+         records = result['data']
+         self.assertEqual(len(records), 1)
+
++    def test_delete_collection_gives_number_of_deletable_records_in_headers(self):
++        self.resource.request.GET = {'_limit': '1'}
++        self.resource.collection_delete()
++        headers = self.last_response.headers
++        count = headers['Total-Records']
++        self.assertEquals(int(count), 2)
++
+
+ class IsolatedModelsTest(BaseTest):
+     def setUp(self):","I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate",I don't think it's neces
+2067,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()),I don't think this is co
+2068,"@@ -130,13 +130,13 @@ func NewExportPipeline(config Config, options ...controller.Option) (*Exporter,
+ // InstallNewPipeline instantiates a NewExportPipeline and registers it globally.
+ // Typically called as:
+ //
+-// 	hf, err := prometheus.InstallNewPipeline(prometheus.Config{...})
++// 	exporter, err := prometheus.InstallNewPipeline(prometheus.Config{...})
+ //
+ // 	if err != nil {
+ // 		...
+ // 	}
+-// 	http.HandleFunc(""/metrics"", hf)
+-// 	defer pipeline.Stop()
++// 	http.HandleFunc(""/metrics"", exporter)
++// 	defer exporter.Controller().Stop(context.TODO())
+ // 	... Done
+ func InstallNewPipeline(config Config, options ...controller.Option) (*Exporter, error) {
+ 	exp, err := NewExportPipeline(config, options...)",Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?,These are the only places where we have to do `/metrics`
+2069,"@@ -380,14 +380,6 @@ describe ""Bolt::CLI"" do
+         cli = Bolt::CLI.new(%w[command run uptime --password opensesame --nodes foo])
+         expect(cli.parse).to include(password: 'opensesame')
+       end
+-
+-      it ""prompts the user for password if not specified"" do
+-        allow(STDIN).to receive(:noecho).and_return('opensesame')
+-        allow(STDOUT).to receive(:print).with('Please enter your password: ')
+-        allow(STDOUT).to receive(:puts)
+-        cli = Bolt::CLI.new(%w[command run uptime --nodes foo --password])
+-        expect(cli.parse).to include(password: 'opensesame')
+-      end
+     end
+
+     describe ""key"" do",Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests.,Why did you remove this?
+2070,"@@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+
+         public void PrepareContinuation(Http2ContinuationFrameFlags flags, int streamId)
+         {
+-            PayloadLength = MinAllowedMaxFrameSize - HeaderLength;
++            PayloadLength = (int)_maxFrameSize;
+             Type = Http2FrameType.CONTINUATION;
+             ContinuationFlags = flags;
+             StreamId = streamId;",Remove this since it always has to be set afterwards.,Does this mean we can potentially end up allocating a lo
+2071,"@@ -11,7 +11,7 @@ import ""testing""
+ // bob writes a multi-block file while unmerged, no conflicts
+ func TestCrUnmergedWriteMultiblockFile(t *testing.T) {
+ 	test(t,
+-		blockSize(20), users(""alice"", ""bob""),
++		blockSize(20), blockChangeSize(20*1024), users(""alice"", ""bob""),
+ 		as(alice,
+ 			mkdir(""a""),
+ 		),","These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching.",Is this too large of a size now? Would it make more sens
+2072,"@@ -25,8 +25,13 @@ class LeafNode(Node):
+     self.reader = reader
+     self.is_leaf = True
+
+-  def fetch(self, startTime, endTime):
+-    return self.reader.fetch(startTime, endTime)
++  def fetch(self, startTime, endTime, now=None, requestContext=None):
++    try:
++      result = self.reader.fetch(startTime, endTime, now, requestContext)
++    except TypeError:
++      result = self.reader.fetch(startTime, endTime)
++
++    return result
+
+   @property
+   def intervals(self):","Is that `try..except` block really needed? I mean, when it could fail?",should we log the exception at least?
+2073,"@@ -101,7 +101,7 @@ module.exports = function(config) {
+
+ 		files: [
+ 			{ pattern: 'test/polyfills.js', watched: false },
+-			{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/test/{browser,shared}/**.test.js', watched: false }
++			{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/test/{browser,shared}/suspense.test.js', watched: false }
+ 		],
+
+ 		preprocessors: {",If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :),I can't find any `suspense.test.js` f
+2074,"@@ -65,7 +65,13 @@ LAMBDA_DEFAULT_STARTING_POSITION = 'LATEST'
+ LAMBDA_ZIP_FILE_NAME = 'original_lambda_archive.zip'
+ LAMBDA_JAR_FILE_NAME = 'original_lambda_archive.jar'
+
+-DEFAULT_BATCH_SIZE = 10
++INVALID_PARAMETER_VALUE_EXCEPTION = 'InvalidParameterValueException'
++
++BATCH_SIZE_MAP = {
++    'kinesis': (100, 10000),
++    'dynamodb': (100, 1000),
++    'sqs': (10, 10)
++}
+
+ app = Flask(APP_NAME)
+ ","nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name.",nit: this seems like it could be a `@
+2075,"@@ -1322,7 +1322,8 @@ public class MenuEntrySwapperPlugin extends Plugin
+
+ 		if (this.swapCoalBag)
+ 		{
+-			menuManager.addPriorityEntry(""Empty"", ""Coal bag"");
++			menuManager.addPriorityEntry(""Empty"", ""Coal bag"").setPriority(90);
++			menuManager.addPriorityEntry(""Fill"", ""Coal bag"").setPriority(100);
+ 		}
+
+ 		if (this.swapBones)",aren't these the wrong way around?,"This is a bit arbitrary, why did you "
+2076,"@@ -2027,6 +2027,10 @@ public class CoreContainer {
+     return configSetsHandler;
+   }
+
++  public ConfigSetService getCoreConfigService() {
++    return this.coreConfigService;
++  }
++
+   public String getHostName() {
+     return this.hostName;
+   }",Lets call this getConfigSetService and maybe rename the field now (or later),"coreConfigService is not used anywhere, please remove it"
+2077,"@@ -27,8 +27,8 @@ import (
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/schema""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+-	""k8s.io/klog""
+-	""k8s.io/klog/klogr""
++	""k8s.io/klog/v2""
++	""k8s.io/klog/v2/klogr""
+
+ 	""github.com/jetstack/cert-manager/pkg/api""
+ )",Could / should we make these constants and give them a type?,`klogr` is in the wrong package. It should be `kube2` or
+2078,"@@ -63,6 +63,13 @@ const (
+
+ 	deleteAfterAnnotation    = ""hive.openshift.io/delete-after"" // contains a duration after which the cluster should be cleaned up.
+ 	tryInstallOnceAnnotation = ""hive.openshift.io/try-install-once""
++
++	platformAWS       = ""aws""
++	platformAzure     = ""azure""
++	platformGCP       = ""GCP""
++	platformBaremetal = ""baremetal""
++	platformUnknown   = ""unknown platform""
++	regionUnknown     = ""unknown region""
+ )
+
+ var (",lets stick with lowercase for consistency.,We should have some more information on what the support
+2079,"@@ -17,10 +17,9 @@ limitations under the License.
+ package acme
+
+ import (
+-	corev1 ""k8s.io/api/core/v1""
+-
+ 	cmacme ""github.com/jetstack/cert-manager/pkg/apis/acme/v1""
+ 	cmmeta ""github.com/jetstack/cert-manager/pkg/apis/meta/v1""
++	corev1 ""k8s.io/api/core/v1""
+ )
+
+ // IsFinalState will return true if the given ACME State is a 'final' state.",ordering of imports went wrong,is this still needed?
+2080,"@@ -84,6 +84,11 @@ public class AllDataFilesTable extends BaseMetadataTable {
+       this.fileSchema = fileSchema;
+     }
+
++    @Override
++    protected String tableType() {
++      return String.valueOf(MetadataTableType.ALL_DATA_FILES);
++    }
++
+     @Override
+     protected TableScan newRefinedScan(TableOperations ops, Table table, Schema schema, TableScanContext context) {
+       return new AllDataFilesTableScan(ops, table, schema, fileSchema, context);",I think these can all be .name() to get the value we are looking for,This should probably return an enum instead of a String.
+2081,"@@ -2622,6 +2622,16 @@ class FunctionCallTest extends TestCase
+                     array_push();',
+                 'error_message' => 'TooFewArguments',
+             ],
++            'printOnlyString' => [
++                '<?php
++                    print [];',
++                'error_message' => 'InvalidArgument',
++            ],
++            'printReturns1' => [
++                '<?php
++                    (print ""test"") === 2;',
++                'error_message' => 'TypeDoesNotContainType',
++            ],
+         ];
+     }
+ }",Is this a good place for these test cases?,"Shouldn't this say ""TypeDoesNotContainType""?"
+2082,"@@ -45,6 +45,7 @@ class Job(object):
+         self.vault = vault
+         if response_data:
+             for response_name, attr_name, default in self.ResponseDataElements:
++                print response_name, attr_name
+                 setattr(self, attr_name, response_data[response_name])
+         else:
+             for response_name, attr_name, default in self.ResponseDataElements:",Did you mean to leave the print statement?,This looks like a debug statement.
+2083,"@@ -184,6 +184,9 @@ Interpreter.false = new Buffer([]);
+
+ Interpreter.MAX_SCRIPT_ELEMENT_SIZE = 520;
+
++Interpreter.LOCKTIME_THRESHOLD = 500000000;
++Interpreter.LOCKTIME_THRESHOLD_BN = new BN(500000000);
++
+ // flags taken from bitcoind
+ // bitcoind commit: b5d1b1092998bc95313856d535c632ea5a8f9104
+ Interpreter.SCRIPT_VERIFY_NONE = 0;",I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`,Please use `TimeUnit.SECONDS.toMillis(500000000)`
+2084,"@@ -23,9 +23,7 @@ package com.github.javaparser.ast.visitor;
+
+ import com.github.javaparser.ast.Node;
+
+-import java.util.ArrayList;
+-import java.util.LinkedList;
+-import java.util.Queue;
++import java.util.*;
+
+ /**
+  * Iterate over all the nodes in (a part of) the AST.","@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`.",Don't use import * pls.
+2085,"@@ -416,7 +416,7 @@ func timerTypeFromThrift(
+ func timerTypeToReason(
+ 	timerType timerType,
+ ) string {
+-	return fmt.Sprintf(""cadenceInternal:Timeout %v"", timerTypeToThrift(timerType))
++	return fmt.Sprintf(""cadenceInternal:Timeout TimeoutType%v"", timerTypeToThrift(timerType))
+ }
+
+ // Len implements sort.Interface",Need to add type name here to be compatible with proto string representation.,I think we can drop the
+2086,"@@ -40,7 +40,7 @@ public class BazelBuild {
+     if (target == null || """".equals(target)) {
+       throw new IllegalStateException(""No targets specified"");
+     }
+-    log.info(""\nBuilding "" + target + "" ..."");
++    log.finest(""\nBuilding "" + target + "" ..."");
+
+     ImmutableList.Builder<String> builder = ImmutableList.builder();
+     builder.add(""bazel"", ""build"", target);",This is to let people know that the tooling is doing something during a build. Please leave.,What's the benefit of t
+2087,"@@ -17,8 +17,8 @@ MINIMALIST_COLLECTION = {'data': dict()}
+ MINIMALIST_GROUP = {'data': dict(members=['fxa:user'])}
+ MINIMALIST_RECORD = {'data': dict(name=""Hulled Barley"",
+                                   type=""Whole Grain"")}
+-USER_PRINCIPAL = 'basicauth:8a931a10fc88ab2f6d1cc02a07d3a81b5d4768f' \
+-                 '6f13e85c5d8d4180419acb1b4'
++USER_PRINCIPAL = 'basicauth:aaedca130273574dd2bd6c3acad57f3545b662a974fa4320' \
++                 '236f25fe474676d6'
+
+
+ class BaseWebTest(object):",Why is the principal changing here?,I don't think we need t
+2088,"@@ -26,6 +26,11 @@
+ // The default URL opener will use credentials from the environment variables
+ // AZURE_STORAGE_ACCOUNT, AZURE_STORAGE_KEY, and AZURE_STORAGE_SAS_TOKEN.
+ // AZURE_STORAGE_ACCOUNT is required, along with one of the other two.
++// AZURE_BLOB_DOMAIN can optionally be used to provide an Azure Environment
++// blob storage domain to use. If no AZURE_BLOB_DOMAIN is provided, the
++// default Azure public domain ""blob.core.windows.net"" will be used. Check
++// the Azure Developer Guide for your particular cloud environment to see
++// the proper blob storage domain name to provide.
+ // To customize the URL opener, or for more details on the URL format,
+ // see URLOpener.
+ // See https://gocloud.dev/concepts/urls/ for background information.",Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones.,"""Azure Developer Guide for your cloud environment"" -> ""Azure Storage domain to provide"""
+2089,"@@ -0,0 +1,18 @@
++const Plugin = require('../../core/Plugin')
++
++module.exports = class ProgressBar extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++
++    this.id = opts.id
++    this.type = 'progressindicator'
++  }
++
++  install () {
++    this.opts.onInstall()
++  }
++
++  uninstall () {
++    this.opts.onUninstall()
++  }
++}",I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?,Let's call this `progress-bar`.
+2090,"@@ -1,6 +1,9 @@
+ package v1alpha1
+
+ import (
++	""errors""
++	""strings""
++
+ 	v1 ""k8s.io/api/core/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ ",can we use `github.com/pkg/errors`?,Please add gitea copyright header
+2091,"@@ -72,15 +72,15 @@ func Compile(scope Scope, f *semantic.FunctionExpression, in semantic.MonoType)
+ // inType and mapping any variables to the value in the other record.
+ // If the input type is not a type variable, it will check to ensure
+ // that the type in the input matches or it will return an error.
+-func substituteTypes(subst map[uint64]semantic.MonoType, inType, in semantic.MonoType) error {
++func substituteTypes(subst map[uint64]semantic.MonoType, inferredType, actualType semantic.MonoType) error {
+ 	// If the input isn't a valid type, then don't consider it as
+ 	// part of substituting types. We will trust type inference has
+ 	// the correct type and that we are just handling a null value
+ 	// which isn't represented in type inference.
+-	if in.Nature() == semantic.Invalid {
++	if actualType.Nature() == semantic.Invalid {
+ 		return nil
+-	} else if inType.Kind() == semantic.Var {
+-		vn, err := inType.VarNum()
++	} else if inferredType.Kind() == semantic.Var {
++		vn, err := inferredType.VarNum()
+ 		if err != nil {
+ 			return err
+ 		}",I changed the name of the arguments here just to help make the code clearer.,It would be nice to have this function accept a `semantic.Type` and do the conversion t
+2092,"@@ -404,7 +404,10 @@ class Callable(param.Parameterized):
+     allowing their inputs (and in future outputs) to be defined.
+     This makes it possible to wrap DynamicMaps with streams and
+     makes it possible to traverse the graph of operations applied
+-    to a DynamicMap.
++    to a DynamicMap. Additionally a Callable will memoize the last
++    returned value based on the arguments to the function and the
++    state of all streams on its inputs, avoiding calling the function
++    unncessarily.
+     """"""
+
+     callable_function = param.Callable(default=lambda x: x, doc=""""""",I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better.,"typo: ""unncessarily"" -> ""always unncessarily"""
+2093,"@@ -5425,7 +5425,7 @@ SyncOpBeginRenderPass::SyncOpBeginRenderPass(CMD_TYPE cmd, const SyncValidator &
+             // TODO: Revisit this when all attachment validation is through SyncOps to see if we can discard the plain pointer copy
+             // Note that this a safe to presist as long as shared_attachments is not cleared
+             attachments_.reserve(shared_attachments_.size());
+-            for (const auto attachment : shared_attachments_) {
++            for (const auto &attachment : shared_attachments_) {
+                 attachments_.emplace_back(attachment.get());
+             }
+         }","@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up.",I'm assuming this was a copy/paste error?
+2094,"@@ -16,10 +16,16 @@
+ //
+
+ using System;
++using System.Collections.Generic;
+ using System.IO;
+ using System.Linq;
+ using System.Reflection;
+ using FluentAssertions;
++using Nethermind.Core;
++using Nethermind.Logging;
++using Nethermind.Monitoring.Config;
++using Nethermind.Monitoring.Metrics;
++using Nethermind.Runner;
+ using NUnit.Framework;
+
+ namespace Nethermind.Monitoring.Test",minor: typo (knowMetricsTypes -> knownMetricsTypes),The `using` statements in this file shouldn't
+2095,"@@ -503,7 +503,13 @@ ConstValue* OptRangeSpec::getConstOperand(ItemExpr* predExpr, Lng32 constInx)
+   // currently support. Predicates involving types not yet supported will be
+   // treated as residual predicates.
+   if (QRDescGenerator::typeSupported(static_cast<ConstValue*>(right)->getType()))
++  {
++    /* add constvalue ‘not casespecific’ to type_*/
++      ((CharType*)getType())->setCaseinsensitive(
++              ((CharType *)(((ConstValue*)(right))->getType()))->isCaseinsensitive());
++
+     return static_cast<ConstValue*>(right);
++  }
+   else
+     return NULL;
+ } // getConstOperand()","This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons.",shouldn't you be casting `right` to `const_ca
+2096,"@@ -637,6 +637,16 @@ public class MethodResolutionLogic {
+         throw new UnsupportedOperationException(typeDeclaration.getClass().getCanonicalName());
+     }
+
++    public static SymbolReference<ResolvedMethodDeclaration> solveMethodInFQN(String fqn, String name,
++                                                                             List<ResolvedType> argumentsTypes, boolean staticOnly, TypeSolver typeSolver) {
++        SymbolReference<ResolvedReferenceTypeDeclaration> typeRef = typeSolver.tryToSolveType(fqn);
++        if (typeRef.isSolved()) {
++            return solveMethodInType(typeRef.getCorrespondingDeclaration(), name, argumentsTypes,
++                    staticOnly, typeSolver);
++        }
++        return SymbolReference.unsolved(ResolvedMethodDeclaration.class);
++    }
++
+     private static void inferTypes(ResolvedType source, ResolvedType target, Map<ResolvedTypeParameterDeclaration, ResolvedType> mappings) {
+
+ ",I would throw an exception if the type is not solved,missing new line
+2097,"@@ -52,11 +52,8 @@ func TestDifficulty(t *testing.T) {
+
+ 	// files are 2 years old, contains strange values
+ 	dt.skipLoad(""difficultyCustomHomestead\\.json"")
+-	dt.skipLoad(""difficultyMorden\\.json"")
+-	dt.skipLoad(""difficultyOlimpic\\.json"")
+
+ 	dt.config(""Ropsten"", *params.RopstenChainConfig)
+-	dt.config(""Morden"", *params.RopstenChainConfig)
+ 	dt.config(""Frontier"", params.ChainConfig{})
+
+ 	dt.config(""Homestead"", params.ChainConfig{",if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?,We can remove th
+2098,"@@ -0,0 +1,14 @@
++module Beaker
++  module Shared
++    module Timed
++
++      def run_and_report_duration &block
++        start = Time.now
++        block.call
++        Time.now - start
++      end
++
++    end
++  end
++end
++",I feel like we do this in a lot of places should we move that out into its own PR?,Extra empty line
+2099,"@@ -12,7 +12,7 @@ import 'css!./style';
+         fillImageElement(elem, source);
+     }
+
+-    async function itemBlurhashing(target, blurhashstr) {
++    function itemBlurhashing(target, blurhashstr) {
+         if (blurhash.isBlurhashValid(blurhashstr)) {
+             // Although the default values recommended by Blurhash developers is 32x32, a size of 18x18 seems to be the sweet spot for us,
+             // improving the performance and reducing the memory usage, while retaining almost full blur quality.","Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?",Thanks for clean
+2100,"@@ -239,7 +239,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+             ""with statement assignment and exception handler assignment."",
+         ),
+         ""R1705"": (
+-            'Unnecessary ""%s"" after ""return""',
++            'Unnecessary ""%s"" after ""return"" remove it and de-indent all the code inside it',
+             ""no-else-return"",
+             ""Used in order to highlight an unnecessary block of ""
+             ""code following an if containing a return statement. ""","I think here should be a comma before remove, in all the cases","""de-indent"" sounds a bit too vague for me. What about ""Remove it and add all the code inside it""?"
+2101,"@@ -12,11 +12,16 @@ class OHEMSampler(BaseSampler):
+                  context,
+                  neg_pos_ub=-1,
+                  add_gt_as_proposals=True,
++                 stages=0,
+                  **kwargs):
+         super(OHEMSampler, self).__init__(num, pos_fraction, neg_pos_ub,
+                                           add_gt_as_proposals)
+-        self.bbox_roi_extractor = context.bbox_roi_extractor
+-        self.bbox_head = context.bbox_head
++        if not hasattr(context, ""num_stages""):
++            self.bbox_roi_extractor = context.bbox_roi_extractor
++            self.bbox_head = context.bbox_head
++        else:
++            self.bbox_roi_extractor = context.bbox_roi_extractor[stages]
++            self.bbox_head = context.bbox_head[stages]
+
+     def hard_mining(self, inds, num_expected, bboxes, labels, feats):
+         with torch.no_grad():",Single quote is used by default in this project.,Should we throw a warning here if `num_stages` is not defined?
+2102,"@@ -177,10 +177,8 @@ func (c *Controller) updateSpc(oldSpc, newSpc interface{}) {
+ 		c.recorder.Event(spc, corev1.EventTypeWarning, ""Update"", message)
+ 		return
+ 	}
+-	// Enqueue spc only when there is a pending pool to be created.
+-	if c.isPoolPending(spc) {
+-		c.enqueueSpc(newSpc)
+-	}
++	// Don't reconcile on spc
++	return
+ }
+
+ // deleteSpc is the delete event handler for spc.",S1023: redundant `return` statement (from `gosimple`),Why don't we need to enqueue the new spc here?
+2103,"@@ -43,3 +43,6 @@ func (s *webhook) Run(ctx context.Context) error {
+
+ func (s *webhook) Notify(event model.Event) {
+ }
++
++func (s *webhook) Close(ctx context.Context) {
++}",`ctx` is unused in Close,What's the difference between this and `Notify`?
+2104,"@@ -0,0 +1,9 @@
++<?php
++
++namespace Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory;
++
++use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
++
++class HeurekaCategoryNotFoundException extends NotFoundHttpException
++{
++}","I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions.",HeurekaCategoryNotFoundException seems to be the wrong exception here.
+2105,"@@ -0,0 +1,7 @@
++_base_ = './tood_r101_fpn_mstrain_2x_coco.py'
++
++model = dict(
++    backbone=dict(
++        dcn=dict(type='DCNv2', deformable_groups=1, fallback_on_stride=False),
++        stage_with_dcn=(False, True, True, True)),
++    bbox_head=dict(num_dcn_on_head=2))","Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?","same here, dcn_head is missing"
+2106,"@@ -548,6 +548,14 @@ AM_COND_IF(BUILDOPT_SYSTEMD_AND_LIBMOUNT,
+   AC_DEFINE([BUILDOPT_LIBSYSTEMD_AND_LIBMOUNT], 1, [Define if systemd and libmount]))
+ if test x$with_libsystemd = xyes; then OSTREE_FEATURES=""$OSTREE_FEATURES systemd""; fi
+
++AC_ARG_WITH(modern-grub,
++	    AS_HELP_STRING([--with-modern-grub],
++                           [Omit grub linux and initrd suffixes for EFI/BIOS booting on GRUB >2.02 (default: no)]),,
++              [with_modern_grub=no])
++AS_IF([ test x$with_modern_grub = xyes], [
++  AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])
++])
++
+ AC_ARG_WITH(builtin-grub2-mkconfig,
+             AS_HELP_STRING([--with-builtin-grub2-mkconfig],
+                            [Use a builtin minimal grub2-mkconfig to generate a GRUB2 configuration file (default: no)]),,","Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?",This should be `Omit grub linux and initrd suffixes for EFI/BIOS booti
+2107,"@@ -27,13 +27,13 @@ import (
+ // Instance is a compute instance.
+ type Instance struct {
+ 	*api.Instance
+-	client        daisyCompute.Client
++	Client        daisyCompute.Client
+ 	Project, Zone string
+ }
+
+ // Cleanup deletes the Instance.
+ func (i *Instance) Cleanup() {
+-	if err := i.client.DeleteInstance(i.Project, i.Zone, i.Name); err != nil {
++	if err := i.Client.DeleteInstance(i.Project, i.Zone, i.Name); err != nil {
+ 		fmt.Printf(""Error deleting instance: %v\n"", err)
+ 	}
+ }","Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)",Should this be called `ComputeClient`?
+2108,"@@ -138,9 +138,11 @@ Workshops::Application.routes.draw do
+   get '/group-training' => ""pages#show"", as: :group_training, id: ""group-training""
+   get '/humans-present/oss' => redirect('https://www.youtube.com/watch?v=VMBhumlUP-A')
+   get '/backbone.js' => redirect('/backbone')
+-  get '/backbone-js-on-rails' => redirect('/products/1-backbone-js-on-rails')
+-  get '/geocoding-on-rails' => redirect('/products/22-geocoding-on-rails')
++  get ""/backbone-js-on-rails"" => redirect(""/products/1-backbone-js-on-rails""), as: :backbone_js_on_rails
++  get ""/geocoding-on-rails"" => redirect(""/products/22-geocoding-on-rails""), as: :geocoding_on_rails
+   get '/geocodingonrails' => redirect('/products/22-geocoding-on-rails')
++  get ""/ios-on-rails"" => redirect(""/products/25-ios-on-rails-beta""), as: :ios_on_rails
++  get ""/ruby-science"" => redirect(""/products/13-ruby-science""), as: :ruby_science
+   get '/gettingstartedwithios' => redirect('/workshops/24-getting-started-with-ios-development?utm_source=podcast')
+   get '/5by5' => redirect('/workshops/19-design-for-developers?utm_source=5by5')
+   get '/rubyist-booster-shot' => ""pages#show"", as: :rubyist_booster_shot, id: ""rubyist-booster-shot""",Line is too long. [104/80],Line is too long. [90/80]
+2109,"@@ -93,6 +93,8 @@ func TestReconcileClusterPool(t *testing.T) {
+ 		expectedMissingDependenciesMessage string
+ 		expectedAssignedClaims             int
+ 		expectedUnassignedClaims           int
++		expectedAssignedCDs                int
++		expectedRunning                    int
+ 		expectedLabels                     map[string]string // Tested on all clusters, so will not work if your test has pre-existing cds in the pool.
+ 		// Map, keyed by claim name, of expected Status.Conditions['Pending'].Reason.
+ 		// (The clusterpool controller always sets this condition's Status to True.)",Since CD updates (assignment & power state) are now done in this controller...,Where is this used? I don
+2110,"@@ -13,10 +13,18 @@ const MongooseError = require('./mongooseError');
+  * @api private
+  */
+
+-function ParallelValidateError(doc) {
++function ParallelValidateError(doc, opts) {
+   const msg = 'Can\'t validate() the same doc multiple times in parallel. Document: ';
+   MongooseError.call(this, msg + doc._id);
+   this.name = 'ParallelValidateError';
++  if (opts && opts.parentStack) {
++    // Provide a full async stack, most recent first
++    this.stack = this.stack + '\n\n' + opts.parentStack.join('\n\n');
++  }
++  // You need to know to look for this, but having it can be very helpful
++  // for tracking down issues when combined with the deepStackTrace schema
++  // option
++  this.conflictStack = opts && opts.conflictStack;
+ }
+
+ /*!",Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets.,The only thing I'm concer
+2111,"@@ -0,0 +1,17 @@
++class CommentCreator
++  def initialize(parsed_email)
++    @parsed_email = parsed_email
++  end
++
++  def run
++    Comment.create(
++      comment_text: parsed_email.comment_text,
++      user: parsed_email.comment_user,
++      proposal: parsed_email.proposal
++    )
++  end
++
++  private
++
++  attr_reader :parsed_email
++end","on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought",This is probably a good o
+2112,"@@ -238,7 +238,7 @@ TEST_F(BlackBoxPersistence, AsyncRTPSAsReliableWithPersistence)
+
+     ASSERT_TRUE(reader.isInitialized());
+
+-    writer.make_persistent(db_file_name(), guid_prefix()).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();
++    writer.make_persistent(db_file_name(), guid_prefix()).history_depth(10).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();
+
+     ASSERT_TRUE(writer.isInitialized());
+ ",This line is too long,Is this really necessary? Looks like it doesn't make sense...?
+2113,"@@ -54,7 +54,7 @@ func run(ctx context.Context) {
+ 	ticker := time.NewTicker(config.SvcPollInterval())
+ 	for {
+ 		if err := config.SetConfig(); err != nil {
+-			logger.Errorf(err.Error())
++			logger.Fatalf(err.Error())
+ 		}
+
+ 		// This sets up the patching system to run in the background.","This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set",Would be good to have a test for this in `pkg/configurator`
+2114,"@@ -93,7 +93,7 @@ func (t *V4Trie) Get(cidr V4CIDR) interface{} {
+ }
+
+ func (t *V4Trie) LookupPath(buffer []V4TrieEntry, cidr V4CIDR) []V4TrieEntry {
+-	return t.root.lookupPath(buffer, cidr)
++	return t.root.lookupPath(buffer[:0], cidr)
+ }
+
+ // LPM does a longest prefix match on the trie","I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?",why is this change needed?
+2115,"@@ -0,0 +1,18 @@
++<table style=""font-size: 15px; font-style: italic; margin: 15px; background-color: #eee; width: 520px"">
++  <tr>
++    <td style=""width: 50px; vertical-align: top; padding: 15px"">
++      <%= link_to(
++          image_tag(
++            attachments[""avatar.png""].url,
++            alt: @user_message_author,
++            title: @user_message_author
++          ),
++          user_url(@user_message_author, :host => SERVER_URL),
++          :target => ""_blank""
++      ) %>
++    </td>
++    <td style=""text-align: left; vertical-align: top; padding-right: 10px"">
++      <%= captured %>
++    </td>
++  </tr>
++</table>","I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?","You should use `content_tag` here, then you can use `<%= image"
+2116,"@@ -220,6 +220,9 @@ type NetworkPolicyRule struct {
+ 	// action “nil” defaults to Allow action, which would be the case for rules created for
+ 	// K8s Network Policy.
+ 	Action *secv1alpha1.RuleAction `json:""action,omitempty"" protobuf:""bytes,6,opt,name=action,casttype=github.com/vmware-tanzu/antrea/pkg/apis/security/v1alpha1.RuleAction""`
++	// EnableLogging is used to indicate if agent should generate logs
++	// when rules are matched. Should be default to false.
++	EnableLogging bool `json:""enableLogging"" protobuf:""varint,7,opt,name=enableLogging""`
+ }
+
+ // Protocol defines network protocols supported for things like container ports.","Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false.","The default here should be `false`, not `false`."
+2117,"@@ -124,6 +124,16 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+     status = rocksdb::DB::Open(options, path, &db);
+   }
+   CHECK(status.ok()) << status.ToString();
++  if (!readonly && spaceId_ != 0 /* only for storage*/) {
++    rocksdb::ReadOptions readOptions;
++    std::string dataVersionValue = """";
++    status = db->Get(readOptions, NebulaKeyUtils::dataVersionKey(), &dataVersionValue);
++    if (status.IsNotFound()) {
++      rocksdb::WriteOptions writeOptions;
++      status = db->Put(writeOptions, NebulaKeyUtils::dataVersionKey(), ""3.0"");
++    }
++    CHECK(status.ok()) << status.ToString();
++  }
+   db_.reset(db);
+   extractorLen_ = sizeof(PartitionID) + vIdLen;
+   partsNum_ = allParts().size();",use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?,Doesn't this need a `.done()` call?
+2118,"@@ -372,10 +372,15 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
+         path = None
+
+     if check_exists:
+-        if path is not None and os.path.exists(path):
+-            log.url.debug(""URL is a local file"")
+-        else:
+-            path = None
++        if path is not None:
++            try:
++                if os.path.exists(path):
++                    log.url.debug(""URL is a local file"")
++            except UnicodeEncodeError:
++                log.url.debug(
++                    ""URL contains characters which are not present in the "" \
++                    ""current locale"")
++                path = None
+
+     return path
+ ","No need for the `\` here, inside parentheses whitespace is ignored by Python.",Where does this `UnicodeEncodeError` come from?
+2119,"@@ -171,6 +171,10 @@ eqp31wM9il1n+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV
+ 			input:  ""{http.request.tls.client.san.ips.0}"",
+ 			expect: ""127.0.0.1"",
+ 		},
++		{
++			input:  ""{http.request.tls.client.certificate_pem}"",
++			expect: ""<empty>"",
++		},
+ 	} {
+ 		actual := repl.ReplaceAll(tc.input, ""<empty>"")
+ 		if actual != tc.expect {",This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above.,This looks unrelated to the PR. Can you open a s
+2120,"@@ -391,8 +391,6 @@ static void wlr_surface_flush_damage(struct wlr_surface *surface,
+ release:
+ 	pixman_region32_clear(&surface->current->surface_damage);
+ 	pixman_region32_clear(&surface->current->buffer_damage);
+-
+-	wlr_surface_state_release_buffer(surface->current);
+ }
+
+ static void wlr_surface_commit_pending(struct wlr_surface *surface) {",need to rename this now.,"The `wlr_surface_state_release_buffer` calls are no longer needed, since the call to `pixman_region32_clear` in `wlr_surface_commit_pending` also clear the buffer."
+2121,"@@ -42,7 +42,16 @@ public class ExpectValidPrivateTransactionReceipt implements PrivateCondition {
+         node.execute(transactions.getPrivateTransactionReceipt(transactionHash));
+     assertThat(actualReceipt)
+         .usingRecursiveComparison()
+-        .ignoringFields(""commitmentHash"", ""logs"")
++        .ignoringFields(
++            ""commitmentHash"",
++            ""logs"",
++            ""blockHash"",
++            ""blockNumber"",
++            ""logsBloom"",
++            ""transactionIndex"") // TODO: The fields blockHash, blockNumber, logsBloom and
++        // transactionIndex have to be ignored as the class
++        // org.web3j.protocol.besu.response.privacy.PrivateTransactionReceipt does not contain these
++        // fields
+         .isEqualTo(expectedReceipt);
+
+     assertThat(actualReceipt.getLogs().size()).isEqualTo(expectedReceipt.getLogs().size());",NIT: This shouldn't be a TODO. It is just a note isn't it?,Is it possible to create a test case for that ?
+2122,"@@ -1644,6 +1644,8 @@ class CommandDispatcher:
+         """"""
+         try:
+             elem.set_value(text)
++        except webelem.OrphanedError as e:
++            message.warning('Edited element vanished')
+         except webelem.Error as e:
+             raise cmdexc.CommandError(str(e))
+ ","I changed this to an error, that seems more appropriate than a warning here.",shouldn't this be `raise cmdexc.CommandError(str(e))`?
+2123,"@@ -492,7 +492,7 @@ func (sct *SmartContractTest) run(r *require.Assertions) {
+ 		if receipt.Status == uint64(iotextypes.ReceiptStatus_Success) {
+ 			numLog := 0
+ 			for _, l := range receipt.Logs {
+-				if !action.IsSystemLog(l) {
++				if !l.IsEvmTransfer() {
+ 					numLog++
+ 				}
+ 			}","This change could mute unit test failure, but it is better to update unit tests",why do we need this change?
+2124,"@@ -165,6 +165,8 @@ class NotificationData {
+         activeNotifications.remove(holder);
+
+         int notificationId = holder.notificationId;
++        notificationIdsInUse.delete(notificationId);
++
+         if (!additionalNotifications.isEmpty()) {
+             NotificationContent newContent = additionalNotifications.removeFirst();
+             NotificationHolder replacement = createNotificationHolder(notificationId, newContent);",All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?,Shouldn't this be done after removing the holder from the map?
+2125,"@@ -26,17 +26,14 @@ import (
+ 	""sync""
+ 	""time""
+
+-	""github.com/ethersphere/bee/pkg/sctx""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ )
+
+ var (
+ 	TagUidFunc  = rand.Uint32
+-	ErrNotFound = errors.New(""tag not found"")
++	NotFoundErr = errors.New(""tag not found"")
+ )
+
+-type TagsContextKey struct{}
+-
+ // Tags hold tag information indexed by a unique random uint32
+ type Tags struct {
+ 	tags *sync.Map","keep as `ErrNotFound`, it is the same convention as in other packages",Why remove this?
+2126,"@@ -10,13 +10,15 @@ var ip = {},
+     extIP = require('external-ip'),
+     plugins = require('../../../plugins/pluginManager.js');
+
++
+ /**
+  * Function to get the hostname/ip address/url to access dashboard
+  * @param  {function} callback - callback function that returns the hostname
+  */
+ ip.getHost = function(callback) {
+     // If host is set in config.js use that, otherwise get the external IP from ifconfig.me
+-    var domain = plugins.getConfig(""api"").domain;
++    var domain = plugins.getConfig(""api"").domain,
++        offlineMode = plugins.getConfig(""api"").offline_mode;
+     if (typeof domain !== ""undefined"" && domain !== """") {
+         if (domain.indexOf(""://"") === -1) {
+             domain = ""http://"" + domain;","Same here, we need to call `callback` in else branch",Please use `const` instead of `var`.
+2127,"@@ -160,7 +160,7 @@ public class CertFailedRefreshNotificationTask implements NotificationTask {
+             }
+
+             String expiryTime =  getTimestampAsString(certRecord.getExpiryTime());
+-            String hostName = (certRecord.getHostName() != null) ? certRecord.getHostName() : """";
++            String hostName = certRecord.getHostName();
+             certDetails.append(AthenzUtils.extractPrincipalServiceName(certRecord.getService())).append(';')
+                     .append(certRecord.getProvider()).append(';')
+                     .append(certRecord.getInstanceId()).append(';')",At this point we already check that the record is valid and so it could never be nulll,Should not be changed.
+2128,"@@ -126,6 +126,7 @@ class UserController < ApplicationController
+          (params[:user][:auth_provider] == current_user.auth_provider &&
+           params[:user][:auth_uid] == current_user.auth_uid)
+         update_user(current_user, params)
++        @title = t ""user.account.title""
+       else
+         session[:new_user_settings] = params
+         redirect_to auth_url(params[:user][:auth_provider], params[:user][:auth_uid])",Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+2129,"@@ -130,6 +130,7 @@ void MetaClient::heartBeatThreadFunc() {
+             localLastUpdateTime_ = metadLastUpdateTime_;
+         }
+     }
++    uploadSession();
+ }
+
+ bool MetaClient::loadUsersAndRoles() {",why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete,This call to `uploadSession` doesn't seem to do anything. Should it be `updateSession`?
+2130,"@@ -0,0 +1,17 @@
++_base_ = './retinanet_regnetx-1.6GF_fpn_mstrain_640-800_3x_coco.py'
++model = dict(
++    pretrained='open-mmlab://regnetx_3.2gf',
++    backbone=dict(
++        _delete_=True,
++        type='RegNet',
++        arch='regnetx_3.2gf',
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++    neck=dict(
++        type='FPN',
++        in_channels=[96, 192, 432, 1008],
++        out_channels=256,
++        num_outs=5))",out_channels/num_outs/type are unnecessary,"out_channels is 256, but out_channels is 512. Could you make the number more consistent?"
+2131,"@@ -6,6 +6,17 @@ let null_dict = null_dictionary || {}
+ // eslint-disable-next-line no-undef
+ assert_true(dict.X !== undefined && dict.doSomething !== undefined);  // Testing successful object creation.
+
++
++/*
++    It seems that Object.values(dict) is not supported on JSC for non-static fields, it would be interesting to
++    review this in the future.
++    verify_object_fields(Object.values(dict).length)
++ */
++
++// eslint-disable-next-line no-undef
++verify_object_fields(Object.keys(dict).length)
++
++
+ null_dict.hello(true);  // Testing method call from object.
+ null_dict.alo(true); // Testing method call from object <again>.
+ ",You can create an issue for it and put it on the backlog so we don't forget it.,"Since it is about `Object.values` not `Object.keys`, maybe it would be better to use `Object.keys(dict)` here."
+2132,"@@ -21,7 +21,11 @@ func (i *startContainerInterceptor) InterceptResponse(r *http.Response) error {
+ 		return err
+ 	}
+
+-	cidrs, ok := i.proxy.weaveCIDRsFromConfig(container.Config)
++	if !validNetworkMode(container.HostConfig) {
++		Debug.Printf(""Ignoring container %s with --net=%s"", container.ID, networkMode(container.HostConfig))
++		return nil
++	}
++	cidrs, ok := i.proxy.weaveCIDRsFromConfig(container.Config, container.HostConfig)
+ 	if !ok {
+ 		Debug.Print(""No Weave CIDR, ignoring"")
+ 		return nil","So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log.",Should we ignore if `ok == true`? Shouldn't we log something when `ok == false`?
+2133,"@@ -436,11 +436,10 @@ def install(session, package, hash=None, version=None, tag=None):
+     if pkghash != hash_contents(response_contents):
+         raise CommandException(""Mismatched hash. Try again."")
+
+-    pkgobj = store.create_package(owner, pkg, PackageFormat.HDF5)
++    pkgobj = store.create_package(owner, pkg)
+     try:
+         pkgobj.install(response_contents, response_urls)
+     except PackageException as ex:
+-        pkgobj.clear_contents()
+         raise CommandException(""Failed to install the package: %s"" % ex)
+
+ def access_list(session, package):","An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package.",Why is this no longer required?
+2134,"@@ -34,10 +34,17 @@ type MiningBlock struct {
+ 	RemoteTxs types.TransactionsStream
+ }
+
++// In case we are proposing during proof-of-stake and we are supplied with header fields already
++type PresetHeaderFields struct {
++	Timestamp uint64
++	Random    common.Hash
++}
++
+ type MiningState struct {
+ 	MiningConfig    *params.MiningConfig
+ 	PendingResultCh chan *types.Block
+ 	MiningResultCh  chan *types.Block
++	ProposeBlockCh  chan *types.Block
+ 	MiningBlock     *MiningBlock
+ }
+ ",Let's add fee recipient as well.,can we call this ProposeBlockCh?
+2135,"@@ -239,6 +239,7 @@ class FileDownloadTarget(_DownloadTarget):
+     def __init__(self, filename):
+         # pylint: disable=super-init-not-called
+         self.filename = filename
++        # pylint: enable=super-init-not-called
+
+     def suggested_filename(self):
+         return os.path.basename(self.filename)","No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function.",Curious: Why did you move this? I think it makes more sense to keep the super ca
+2136,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher,Shouldn't this be `applicationName` to be consistent with `applicationType` and `applicationVersion`?
+2137,"@@ -55,6 +55,15 @@ class ProposalDecorator < Draper::Decorator
+     ""#{number_approved} of #{total_approvers} approved.""
+   end
+
++  def table_waiting_text
++    actionable_step = currently_awaiting_steps.first
++    if actionable_step
++      actionable_step.decorate.waiting_text
++    else
++      I18n.t(""decorators.steps.approval.status.waiting"")
++    end
++  end
++
+   def step_text_for_user(key, user)
+     step = existing_approval_for(user)
+     klass = step.class.name.demodulize.downcase.to_sym",this name seems pretty vague -- thoughts on a more descriptive method name?,This isn't going to change depending on the current user's current status. I think it'd be better to
+2138,"@@ -1,4 +1,4 @@
+-// <copyright file=""MeterFactory.cs"" company=""OpenTelemetry Authors"">
++// <copyright file=""MeterFactory.cs"" company=""OpenTelemetry Authors"">
+ // Copyright The OpenTelemetry Authors
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");",what changed in this line?,Why do we have this file change?
+2139,"@@ -43,13 +43,16 @@ import { isZeroReport } from '../../modules/search-console/util/is-zero-report';
+ import sumObjectListValue from '../../util/sum-object-list-value';
+ const { useSelect } = Data;
+
++// reportArgs is declared in this higher scope so that it can be used by hasData.
++let reportArgs;
++
+ const AdminBarClicks = ( { className } ) => {
+ 	const url = useSelect( ( select ) => select( CORE_SITE ).getCurrentEntityURL() );
+ 	const { compareStartDate, endDate } = useSelect( ( select ) => select( CORE_USER ).getDateRangeDates( {
+ 		compare: true,
+ 		offsetDays: DATE_RANGE_OFFSET,
+ 	} ) );
+-	const reportArgs = {
++	reportArgs = {
+ 		startDate: compareStartDate,
+ 		endDate,
+ 		dimensions: 'date',","Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though.","Just curious, why not just inline the contents of the function call?"
+2140,"@@ -38,7 +38,6 @@ class ExceptionListener
+             return $event->getException()->getMessage();
+         }
+
+-        /** @var \JavierEguiluz\Bundle\EasyAdminBundle\Exception\BaseException */
+         $exception = $event->getException();
+         $exceptionClassName = basename(str_replace('\\', '/', get_class($exception)));
+ ","This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN.",Can you remove this as well?
+2141,"@@ -228,10 +228,16 @@ func (p *ReverseProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request, extr
+
+ 		outreq.Write(backendConn)
+
++		errCh := make(chan error, 1)
+ 		go func() {
+-			io.Copy(backendConn, conn) // write tcp stream to backend.
++			_, err := io.Copy(backendConn, conn) // write tcp stream to backend.
++			errCh <- err
+ 		}()
+-		io.Copy(conn, backendConn) // read tcp stream from backend.
++		go func() {
++			_, err := io.Copy(conn, backendConn) // read tcp stream from backend.
++			errCh <- err
++		}()
++		<-errCh
+ 	} else {
+ 		defer res.Body.Close()
+ 		for _, h := range hopHeaders {",This looks like you're not collecting everything from the error channel.,Wouldn't it be simpler to us
+2142,"@@ -1,10 +1,10 @@
+ class CheckoutMailer < BaseMailer
+   def receipt(checkout)
+-    @checkout = checkout
++    @plan = checkout.plan
+
+     mail(
+-      to: @checkout.user_email,
+-      subject: ""Your receipt for #{@checkout.plan_name}""
++      to: checkout.user_email,
++      subject: ""Your receipt for #{@plan.name}""
+     )
+   end
+ end",This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution.,Here we should assign `@plan
+2143,"@@ -77,7 +77,7 @@ class Image implements EntityFileUploadInterface
+      * @param string $entityName
+      * @param int $entityId
+      * @param string|null $type
+-     * @param string $temporaryFilename
++     * @param string|null $temporaryFilename
+      */
+     public function __construct($entityName, $entityId, $type, $temporaryFilename)
+     {",is there any scenario when `$temporaryFilename` can be null?,think this should be `string
+2144,"@@ -171,6 +171,7 @@ class FlinkTypeToType extends FlinkTypeVisitor<Type> {
+   }
+
+   @Override
++  @SuppressWarnings(""ReferenceEquality"")
+   public Type visit(RowType rowType) {
+     List<Types.NestedField> newFields = Lists.newArrayListWithExpectedSize(rowType.getFieldCount());
+     boolean isRoot = root == rowType;","this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`",I'm not sure why this is necessary.
+2145,"@@ -260,6 +260,7 @@ static void roots_drag_icon_handle_surface_commit(struct wl_listener *listener,
+ 		void *data) {
+ 	struct roots_drag_icon *icon =
+ 		wl_container_of(listener, icon, surface_commit);
++	roots_drag_icon_update_position(icon);
+ 	roots_drag_icon_damage_whole(icon);
+ }
+ ","No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`",I think that `roots_drag_icon_updat
+2146,"@@ -102,11 +102,13 @@ def build_model_from_cfg(config_path, checkpoint_path, cfg_options=None):
+     return model
+
+
+-def preprocess_example_input(input_config):
++def preprocess_example_input(input_config, device=torch.device('cpu')):
+     """"""Prepare an example input image for ``generate_inputs_and_wrap_model``.
+
+     Args:
+         input_config (dict): customized config describing the example input.
++        device (<class 'torch.device'>): device type (CPU or CUDA)
++            for the one_img.
+
+     Returns:
+         tuple: (one_img, one_meta), tensor of the example input image and \",Have you tested exporting to ONNX with `device=cuda`?,input -> input
+2147,"@@ -78,10 +78,14 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) {
+ // Validate returns an error if the values provided by flags are invalid.
+ func (o *jobLogsOpts) Validate() error {
+ 	if o.appName != """" {
+-		_, err := o.configStore.GetApplication(o.appName)
+-		if err != nil {
++		if _, err := o.configStore.GetApplication(o.appName); err != nil {
+ 			return err
+ 		}
++		if o.name != """" {
++			if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {
++				return err
++			}
++		}
+ 	}
+
+ 	if o.since != 0 && o.humanStartTime != """" {",Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`,"Shouldn't this be `if o.name != """" "
+2148,"@@ -147,6 +147,19 @@ class Auth extends Controller
+      */
+     public function restore_onSubmit()
+     {
++        // Force Trusted Host verification on password reset link generation
++        // regardless of config to protect against host header poisoning
++        $trustedHosts = Config::get('app.trustedHosts', false);
++        if ($trustedHosts === false) {
++            $url = Config::get('app.url', null);
++            if (!empty($url)) {
++                // Explicitly only allow the APP_URL host and subdomains
++                Request::setTrustedHosts(['^(.+\.)?' . preg_quote(parse_url($url, PHP_URL_HOST)) . '$']);
++                // Trigger the host validation logic
++                Request::getHost();
++            }
++        }
++
+         $rules = [
+             'login' => 'required|between:2,255'
+         ];","@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless.",This should be moved to the `setup_form` method.
+2149,"@@ -259,7 +259,7 @@ func (c *NetworkPolicyController) triggerParentGroupSync(grp *antreatypes.Group)
+ // triggerCNPUpdates triggers processing of ClusterNetworkPolicies associated with the input ClusterGroup.
+ func (c *NetworkPolicyController) triggerCNPUpdates(cg *crdv1alpha3.ClusterGroup) error {
+ 	// If a ClusterGroup is added/updated, it might have a reference in ClusterNetworkPolicy.
+-	cnps, err := c.cnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)
++	cnps, err := c.acnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)
+ 	if err != nil {
+ 		klog.Errorf(""Error retrieving ClusterNetworkPolicies corresponding to ClusterGroup %s"", cg.Name)
+ 		return err","i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs",Maybe rename this to `triggerCNPUpdates` to make
+2150,"@@ -257,12 +257,12 @@ describe('text.accessibleTextVirtual', function() {
+ 		axe.testUtils.flatTreeSetup(fixture);
+
+ 		var target = axe.utils.querySelectorAll(axe._tree, '#t2label')[0];
+-		// Chrome 72: This is This is a label of
+-		// Firefox 62: This is ARIA Label
+-		// Safari 12.0: This is This is a label of
++		// Chrome 86: This is This is a label of
++		// Firefox 82: This is ARIA Label everything
++		// Safari 14.0: This is This is a label of everything
+ 		assert.equal(
+ 			axe.commons.text.accessibleTextVirtual(target),
+-			'This is This is a label of'
++			'This is This is a label of everything'
+ 		);
+ 	});
+ ",Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?,AFAIK there's no `accessibleTextVirtual` in this
+2151,"@@ -156,6 +156,10 @@ func (s *stream) Close() error {
+ 	return nil
+ }
+
++func (s *stream) FullClose() error {
++	return s.Close()
++}
++
+ type record struct {
+ 	b      []byte
+ 	c      int","This method should behave as intended, to block until it reads an EOF from the other side.",why do we need this?
+2152,"@@ -1924,7 +1924,7 @@ func GitFsck() {
+ 			repo := bean.(*Repository)
+ 			repoPath := repo.RepoPath()
+ 			if err := git.Fsck(repoPath, setting.Cron.RepoHealthCheck.Timeout, setting.Cron.RepoHealthCheck.Args...); err != nil {
+-				desc := fmt.Sprintf(""Fail to health check repository '%s': %v"", repoPath, err)
++				desc := fmt.Sprintf(""Health check failed on repository '%s': %v"", repoPath, err)
+ 				log.Warn(desc)
+ 				if err = CreateRepositoryNotice(desc); err != nil {
+ 					log.Error(3, ""CreateRepositoryNotice: %v"", err)","I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?",I think it should be repoPath not repoPath
+2153,"@@ -141,9 +141,15 @@ namespace Datadog.Trace
+             if (AzureAppServices.Metadata?.IsRelevant ?? false)
+             {
+                 span.SetTag(Tags.AzureAppServicesSiteName, AzureAppServices.Metadata.SiteName);
++                span.SetTag(Tags.AzureAppServicesSiteKind, AzureAppServices.Metadata.SiteKind);
++                span.SetTag(Tags.AzureAppServicesSiteType, AzureAppServices.Metadata.SiteType);
+                 span.SetTag(Tags.AzureAppServicesResourceGroup, AzureAppServices.Metadata.ResourceGroup);
+                 span.SetTag(Tags.AzureAppServicesSubscriptionId, AzureAppServices.Metadata.SubscriptionId);
+                 span.SetTag(Tags.AzureAppServicesResourceId, AzureAppServices.Metadata.ResourceId);
++                span.SetTag(Tags.AzureAppServicesInstanceId, AzureAppServices.Metadata.InstanceId);
++                span.SetTag(Tags.AzureAppServicesInstanceName, AzureAppServices.Metadata.InstanceName);
++                span.SetTag(Tags.AzureAppServicesOperatingSystem, AzureAppServices.Metadata.OperatingSystem);
++                span.SetTag(Tags.AzureAppServicesRuntime, AzureAppServices.Metadata.Runtime);
+             }
+
+             // set the origin tag to the root span of each trace/subtrace","All these calls make me think we should refactor how traces are started and allow ""source tags"" that we initialize a trace with. I'd like to do this in a follow up.",I don't think AzureAppServices can have di
+2154,"@@ -1,6 +1,6 @@
+ // DO NOT EDIT: This file is autogenerated via the builtin command.
+
+-package v1_test
++package v1
+
+ import (
+ 	ast ""github.com/influxdata/flux/ast""",This file shouldn't be in this PR,why did you change this?
+2155,"@@ -1881,7 +1881,7 @@ class ArrayAssignmentTest extends TestCase
+                     takesArray($a);',
+                 'error_message' => 'InvalidScalarArgument',
+             ],
+-            'nonEmptyAssignmentToListElementChangeType' => [
++            'SKIPPED-nonEmptyAssignmentToListElementChangeType' => [ // Should be LessSpecificReturnStatement?
+                 '<?php
+                     /**
+                      * @param non-empty-list<string> $arr","This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list<string>' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list<string>`. Thoughts?",I think this should be `SKIPPED_nonEmptyAs
+2156,"@@ -123,7 +123,7 @@ public class RestrictedDefaultPrivacyController implements PrivacyController {
+       final String privacyUserId,
+       final Optional<PrivacyGroup> maybePrivacyGroup) {
+     try {
+-      LOG.trace(""Storing private transaction in enclave"");
++      LOG.info(""Storing private transaction in enclave"");
+       final SendResponse sendResponse =
+           sendRequest(privateTransaction, privacyUserId, maybePrivacyGroup);
+       return sendResponse.getKey();",Are you going to change that back?,Why did we move the log message to info and not trace?
+2157,"@@ -51,6 +51,16 @@ tune ?= generic
+ cpu ?= $(arch)
+ fpu ?=
+ bits ?= $(shell getconf LONG_BIT)
++staticbuild ?= false
++
++# Set static building if requested
++ifeq (true,$(staticbuild))
++  use += llvm_link_static
++else
++  ifneq (false,$(staticbuild))
++    $(error staticbuild must be true or false)
++  endif
++endif
+
+ ifndef verbose
+   SILENT = @","we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change.",This should probably be `if (!staticbuild && $(error s
+2158,"@@ -1088,6 +1088,7 @@ function createFunctionsMenu() {
+         {text: 'Power', handler: applyFuncToEachWithInput('pow', 'Please enter a power factor')},
+         {text: 'Square Root', handler: applyFuncToEach('squareRoot')},
+         {text: 'Time-adjusted Derivative', handler: applyFuncToEachWithInput('perSecond', ""Please enter a maximum value if this metric is a wrapping counter (or just leave this blank)"", {allowBlank: true})},
++	{text: 'Delay', handler: applyFuncToEachWithInput('scale', 'Please enter the number of steps to delay')},
+         {text: 'Integral', handler: applyFuncToEach('integral')},
+         {text: 'Percentile Values', handler: applyFuncToEachWithInput('percentileOfSeries', ""Please enter the percentile to use"")},
+         {text: 'Non-negative Derivative', handler: applyFuncToEachWithInput('nonNegativeDerivative', ""Please enter a maximum value if this metric is a wrapping counter (or just leave this blank)"", {allowBlank: true})},",Note this should be `delay` instead of `scale` here. I'll fix this in my branch.,"The text should be ""Please enter the number of steps t"
+2159,"@@ -87,7 +87,6 @@ class Uppy {
+     this.upload = this.upload.bind(this)
+
+     this.emitter = ee()
+-    this.on = this.emitter.on.bind(this.emitter)
+     this.off = this.emitter.off.bind(this.emitter)
+     this.once = this.emitter.once.bind(this.emitter)
+     this.emit = this.emitter.emit.bind(this.emitter)","`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?",@jridgewell can you review this change since you origi
+2160,"@@ -1,4 +1,11 @@
+ # Copyright (c) OpenMMLab. All rights reserved.
++import random
++
++import torch
++import torch.distributed as dist
++import torch.nn.functional as F
++from mmcv.runner import get_dist_info
++
+ from ..builder import DETECTORS
+ from .single_stage import SingleStageDetector
+ ","Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future.",Can we only import this at the top of the file?
+2161,"@@ -38,6 +38,7 @@ import (
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ttime""
+
+ 	""context""
++
+ 	""github.com/cihub/seelog""
+ 	""github.com/pkg/errors""
+ )",Can you move this up along with the other builtin libraries?,Minor nitpick: could you remove this newline?
+2162,"@@ -633,6 +633,12 @@ class GeneralSettingsPanel(SettingsPanel):
+ 			if globalVars.appArgs.secure:
+ 				item.Disable()
+ 			settingsSizerHelper.addItem(item)
++			# Translators: The label of a checkbox in general settings to toggle allowing of usage stats gathering
++			item=self.allowUsageStatsCheckBox=wx.CheckBox(self,label=_(""Allow the NVDA project to gather NVDA usage statistics""))
++			item.Value=config.conf[""update""][""allowUsageStats""]
++			if globalVars.appArgs.secure:
++				item.Disable()
++			settingsSizerHelper.addItem(item)
+ 			# Translators: The label of a checkbox in general settings to toggle startup notifications
+ 			# for a pending NVDA update.
+ 			item=self.notifyForPendingUpdateCheckBox=wx.CheckBox(self,label=_(""Notify for &pending update on startup""))",I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now.,"Maybe ""Allow NVDA project to gather NVDA usage "
+2163,"@@ -309,6 +309,14 @@ var opts struct {
+ 				Targets []core.BuildLabel `position-arg-name:""targets"" description:""Additional targets to load rules from""`
+ 			} `positional-args:""true""`
+ 		} `command:""rules"" description:""Prints built-in rules to stdout as JSON""`
++		Changes struct {
++			Before          string `short:""b"" long:""before"" description:""Revision to check out for the state before""`
++			After           string `short:""a"" long:""after"" required:""true"" description:""Revision to check out for the state after""`
++			CheckoutCommand string `long:""checkout_command"" default:""git checkout %s"" description:""Command to run to check out the before/after revisions.""`
++			Args            struct {
++				Files cli.StdinStrings `positional-arg-name:""files"" description:""Files to consider changed""`
++			} `positional-args:""true""`
++		} `command:""changes"" description:""Calculates the difference between two different states of the build graph""`
+ 	} `command:""query"" description:""Queries information about the build graph""`
+ }
+ ","Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here.","Just a nit, but we should use `long:""before""` a"
+2164,"@@ -381,6 +381,17 @@ class FDst(_Rex):
+         return f.server_conn.address and self.re.search(r)
+
+
++class FDstIP(_Rex):
++    code = ""ip""
++    help = ""Match destination ip address""
++    is_binary = False
++
++    def __call__(self, f):
++        if not f.server_conn or not f.server_conn.ip_address:
++            return False
++        return f.server_conn.ip_address and self.re.search(f.server_conn.ip_address[0])
++
++
+ class FReplay(_Action):
+     code = ""replay""
+     help = ""Match replayed flows""",Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :),"Would it make sense to have an explicit check for `None` here? If the user passes an empty ip address, should that be considered an error?"
+2165,"@@ -60,7 +60,7 @@ namespace Nethermind.Core
+         public long GasUsed { get; set; }
+         public long GasLimit { get; set; }
+         public UInt256 Timestamp { get; set; }
+-        public DateTime TimestampDate => DateTimeOffset.FromUnixTimeSeconds((long) Timestamp).DateTime;
++        public DateTime TimestampDate => DateTimeOffset.FromUnixTimeSeconds((long) Timestamp).LocalDateTime;
+         public byte[] ExtraData { get; set; }
+         public Keccak MixHash { get; set; }
+         public ulong Nonce { get; set; }",Why local and not UTC?,Why do we need to change this?
+2166,"@@ -172,7 +172,8 @@ ExSqlComp::ReturnStatus ExSqlComp::createServer()
+   //
+   if (ret == ERROR)
+   {
+-	error(arkcmpErrorServer);
++	if ((!diagArea_->contains(-2013)) && (!diagArea_->contains(-2012))) // avoid generating redundant error
++	  error(arkcmpErrorServer);
+ 	if (getenv(""DEBUG_SERVER""))
+ 	  MessageBox(NULL, ""ExSqlComp:createServer"", ""error "", MB_OK|MB_ICONINFORMATION);
+   }",2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?,We don't want to just ignore the error if the diagnostic area contains -2013.
+2167,"@@ -8,6 +8,7 @@ package factory
+
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""sort""
+
+ 	""github.com/iotexproject/go-pkgs/hash""",move to line 14 below,"Please move `""github.com/iotexproject/iotex-address/address""` to a new line."
+2168,"@@ -107,7 +107,7 @@ public class Rectangle2D {
+     return eastRelation;
+   }
+
+-  /** Checks if the rectangle intersects the provided triangle **/
++  /** Checks if the rectangle crosses the provided triangle **/
+   public boolean intersectsTriangle(int aX, int aY, int bX, int bY, int cX, int cY) {
+     // 1. query contains any triangle points
+     if (queryContainsPoint(aX, aY) || queryContainsPoint(bX, bY) || queryContainsPoint(cX, cY)) {",the method name should match teh docs,"I think this should be ""intersects"" instead of ""intersects""."
+2169,"@@ -278,13 +278,16 @@ func getOps(config Config, id TlfID) *folderBranchOps {
+ 		getOpsNoAdd(FolderBranch{id, MasterBranch})
+ }
+
++// TODO: Test MDv3.
++
+ // createNewRMD creates a new RMD for the given name. Returns its ID
+ // and handle also.
+ func createNewRMD(t *testing.T, config Config, name string, public bool) (
+ 	TlfID, *TlfHandle, *RootMetadata) {
+ 	id := FakeTlfID(1, public)
+ 	h := parseTlfHandleOrBust(t, config, name, public)
+-	rmd := newRootMetadataOrBust(t, id, h)
++	rmd, err := makeInitialRootMetadata(config.MetadataVersion(), id, h)
++	require.NoError(t, err)
+ 	return id, h, rmd
+ }
+ ",Won't this happen automatically when we flip the default version in the config?,Should this TODO be done before the merge?
+2170,"@@ -312,7 +312,7 @@ func TestLocalExec(t *testing.T) {
+ 		err = app.Exec(""web"", true, ""pwd"")
+ 		assert.NoError(err)
+ 		out := stdout()
+-		assert.Contains(out, ""/var/www/html/docroot"")
++		assert.Contains(out, ""/var/www/html"")
+
+ 		stdout = testcommon.CaptureStdOut()
+ 		switch app.GetType() {",This would also change back to /var/www/html/docroot if we go that way.,This is the only real change in this file. The rest of the c
+2171,"@@ -0,0 +1,7 @@
++import { getImplicitRole } from '../commons/aria';
++
++function hasImplicitChromiumRoleMatches(node, virtualNode) {
++  return getImplicitRole(virtualNode) !== null;
++}
++
++export default hasImplicitChromiumRoleMatches;",This still needs to use the new option. We'll need tests for it too.,"Since this is only used in one module, can it be moved to th"
+2172,"@@ -0,0 +1,16 @@
++#appModules/egui.py
++#A part of NonVisual Desktop Access (NVDA)
++#Copyright (C) 2020 Pavol Kecskemety <pavol.kecskemety@eset.sk>
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++
++import appModuleHandler
++
++class AppModule(appModuleHandler.AppModule):
++
++	def event_NVDAObject_init(self, obj):
++		obj.description = None
++		obj.shouldAllowIAccessibleFocusEvent=True
++
++		if obj.name == obj.value:
++			obj.value = None",We are no longer including file name in the source files.,Isn't this the same as `obj.name`? Why do we need both name and value?
+2173,"@@ -4,6 +4,9 @@ class ApplicationController < ActionController::Base
+   # Look for template overrides before rendering
+   before_filter :prepend_view_paths
+
++  # Set current user (see set_current_user)
++  before_filter :set_current_user
++
+   include GlobalHelpers
+   include Pundit
+   helper_method GlobalHelpers.instance_methods",no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers.,Layout/EmptyLinesAroundFilter: Extra empty line detected at class body
+2174,"@@ -169,4 +169,8 @@ public class EthProtocol implements SubProtocol {
+     public static final int V65 = 65;
+     public static final int V66 = 66;
+   }
++
++  public static boolean isEth66Compatible(final Capability capability) {
++    return capability.getName().equals(NAME) && capability.getVersion() >= ETH66.getVersion();
++  }
+ }","Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?",Should this be called `isEth66Compatible` for consistency?
+2175,"@@ -193,6 +193,7 @@ RSpec.describe RSpec::Core::Example, :parent_metadata => 'sample' do
+         expect(RSpec::Matchers).not_to receive(:generated_description)
+         example_group.example { assert 5 == 5 }
+         example_group.run
++        RSpec::Mocks.space.reset_all
+       end
+
+       it ""uses the file and line number"" do","Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?","Does this reset the space? If so, where does the reset come from?"
+2176,"@@ -428,6 +428,9 @@ func (cg *configGenerator) convertSlackConfig(ctx context.Context, in monitoring
+ 			return nil, errors.Errorf(""failed to get key %q from secret %q"", in.APIURL.Key, in.APIURL.Name)
+ 		}
+ 		out.APIURL = strings.TrimSpace(url)
++		if _, err := ValidateURL(out.APIURL); err != nil {
++			return nil, errors.Wrapf(err, ""invalid 'apiURL' %s in slack config"", out.APIURL)
++		}
+ 	}
+
+ 	var actions []slackAction","since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently).","would it make sense to `return nil, errors.Wrapf(err, ""invalid 'apiURL' in slack config"")` instead?"
+2177,"@@ -21,11 +21,11 @@ import (
+
+ func TestExtendPartialURL(t *testing.T) {
+ 	want := ""projects/foo/zones/bar/disks/baz""
+-	if s := extendPartialURL(""zones/bar/disks/baz"", ""foo""); s != want {
++	if s := normalizeToPartialURL(""zones/bar/disks/baz"", ""foo""); s != want {
+ 		t.Errorf(""got: %q, want: %q"", s, want)
+ 	}
+
+-	if s := extendPartialURL(""projects/foo/zones/bar/disks/baz"", ""gaz""); s != want {
++	if s := normalizeToPartialURL(""projects/foo/zones/bar/disks/baz"", ""gaz""); s != want {
+ 		t.Errorf(""got: %q, want %q"", s, want)
+ 	}
+ }",TestNormalize... I would also split them,"@ruflin I changed `extendPartialURL` to `normalizeToPartialURL`, since now it will fail if the path"
+2178,"@@ -49,7 +49,7 @@ def readObjects(obj):
+ 	_startGenerator(readObjectsHelper_generator(obj))
+
+ def generateObjectSubtreeSpeech(obj,indexGen):
+-	index=indexGen.next()
++	index=next(indexGen)
+ 	speech.speakObject(obj,reason=controlTypes.REASON_SAYALL,index=index)
+ 	yield obj,index
+ 	child=obj.simpleFirstChild",All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition.,"I don't think this will actually work - `indexGen` isn't a generator, it's a list."
+2179,"@@ -89,8 +89,10 @@ func (l *twoRandomChoicesList) Remove(peer peer.StatusPeer, _ peer.Identifier, p
+ }
+
+ func (l *twoRandomChoicesList) Choose(_ *transport.Request) peer.StatusPeer {
+-	l.m.RLock()
+-	defer l.m.RUnlock()
++	// Usage of a wite lock because r.random.Intn is not thread safe
++	// see: https://golang.org/pkg/math/rand/
++	l.m.Lock()
++	defer l.m.Unlock()
+
+ 	numSubs := len(l.subscribers)
+ 	if numSubs == 0 {","Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that ""large"" write lock really but lock namely for ""rand"". Or least use a separate Lock (Mutex), namely for ""rand"" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair.",this `defer` should go in its own line.
+2180,"@@ -2,6 +2,11 @@
+ # For details: https://github.com/PyCQA/pylint/blob/master/COPYING
+
+ import re
++import sys
++
++from astroid.__pkginfo__ import version as astroid_version
++
++from pylint.__pkginfo__ import version as pylint_version
+
+ # Allow stopping after the first semicolon/hash encountered,
+ # so that an option can be continued with the reasons",Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?,"astroid is already imported, so you can just use `from astroid import version`."
+2181,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,no need for this change
+2182,"@@ -94,7 +94,7 @@ class BazelBuildFileView {
+     goPkg = goPkg.replaceFirst(""cloud\\/"", """");
+
+     String goImport = """";
+-    if (isCloud) {
++    if (isCloud || protoPkg.contains(""cloud"")) {
+       goImport = ""cloud.google.com/go/"";
+       goPkg = goPkg.replaceFirst(""v(.+);"", ""apiv$1;"");
+     } else {","This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(""cloud"")` from here to the place where `assembleGoImportPath` is called.",Is there any way to check whether `protoPkg` contains `cloud`?
+2183,"@@ -1693,7 +1693,9 @@ Ex_Lob_Error ExLob::readDataToLocalFile(char *fileName,  Int64 offset, Int64 siz
+     // open the targte file for writing
+     int filePerms = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
+     int openFlags = O_RDWR ; // O_DIRECT needs mem alignment
+-    if ((LobTgtFileFlags)fileflags == Lob_Append_Or_Error )
++    if (((LobTgtFileFlags)fileflags == Lob_Append_Or_Error ) ||
++	((LobTgtFileFlags)fileflags == Lob_Error_Or_Create ) ||
++	((LobTgtFileFlags)fileflags == Lob_Append_Or_Create))
+       openFlags |= O_APPEND;
+     else
+       openFlags |= O_TRUNC;",Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.),"typo: ""Lob_Error_Or_Create"" instead of ""Lob_Append_Or_Error"""
+2184,"@@ -124,7 +124,7 @@ public class DockerOptions {
+       for (int i = 0; i < maxContainerCount; i++) {
+         node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
+       }
+-      LOG.info(String.format(
++      LOG.finest(String.format(
+           ""Mapping %s to docker image %s %d times"",
+           caps,
+           name,",This change prevents a user understanding how their server is configured. Best to leave at `info` level.,This is also going to flood the logs with very little value. Is it really useful?
+2185,"@@ -471,8 +471,10 @@ void TSSLSocket::checkHandshake() {
+       }
+     } while (rc == 2);
+   } else {
+-    // set the SNI hostname
+-    SSL_set_tlsext_host_name(ssl_, getHost().c_str());
++    /* OpenSSL < 0.9.8f does not have SSL_set_tlsext_host_name() */
++    #if defined(SSL_set_tlsext_host_name) // set the SNI hostname
++      SSL_set_tlsext_host_name(ssl_, getHost().c_str());
++    #endif
+     do {
+       rc = SSL_connect(ssl_);
+       if (rc <= 0) {",Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library.,"shouldn't this be `SSL_set_tlsext_host_name(ssl_, host_name);` ?"
+2186,"@@ -367,7 +367,7 @@ var (
+ 		},
+ 	}
+
+-	readBlockProducersByHeightTests = []struct {
++	readActiveBlockProducersByHeightTests = []struct {
+ 		// Arguments
+ 		protocolID            string
+ 		protocolType          string",`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`),why is the name changed?
+2187,"@@ -447,10 +447,10 @@ public class SyncManager {
+         int totalSize = target.getTotalSize();
+         sync.setTotalSize(totalSize);
+         updateSync(sync, SyncState.Status.RUNNING, 0, callback);
+-
++        final String idField = sync.getTarget().getIdFieldName();
+         while (records != null) {
+             // Save to smartstore
+-            saveRecordsToSmartStore(soupName, records, mergeMode);
++            saveRecordsToSmartStore(soupName, records, mergeMode, idField);
+             countSaved += records.length();
+             maxTimeStamp = Math.max(maxTimeStamp, target.getLatestModificationTimeStamp(records));
+ ",Falls back on `Constants.ID` if there's no custom field set.,Why don't we pass `sync.getTarget().getIdFieldName()` here?
+2188,"@@ -509,6 +509,7 @@ public class FileAccessIO<T extends DvObject> extends StorageIO<T> {
+
+         try {
+             in = new FileInputStream(getFileSystemPath().toFile());
++            in.skip(this.getOffset());
+         } catch (IOException ex) {
+             // We don't particularly care what the reason why we have
+             // failed to access the file was.","I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()",Is there a reason why this has to be skipped?
+2189,"@@ -32,6 +32,11 @@ public class MethodNameDeclaration extends AbstractNameDeclaration {
+         return p.isVarargs();
+     }
+
++    public boolean isPrimitiveReturnType() {
++        return getMethodNameDeclaratorNode().getParent().getResultType().getChild(0)
++                .getChild(0) instanceof ASTPrimitiveType;
++    }
++
+     public ASTMethodDeclarator getMethodNameDeclaratorNode() {
+         return (ASTMethodDeclarator) node;
+     }","In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge.",Can you extract this to a private method?
+2190,"@@ -83,6 +83,7 @@ func main() {
+ 			tch.NewInbound(channel, tch.ListenAddr("":28941"")),
+ 			http.NewInbound("":24034""),
+ 		},
++		Interceptors: yarpc.Interceptors{requestLogInterceptor{}},
+ 	})
+
+ 	handler := handler{items: make(map[string]string)}","If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter.","This is a no-op, right?"
+2191,"@@ -1011,5 +1011,13 @@ func (e *ETCD) GetMembersClientURLs(ctx context.Context) ([]string, error) {
+
+ // RemoveSelf will remove the member if it exists in the cluster
+ func (e *ETCD) RemoveSelf(ctx context.Context) error {
+-	return e.removePeer(ctx, e.name, e.address, true)
++	if err := e.removePeer(ctx, e.name, e.address, true); err != nil {
++		return err
++	}
++
++	// backup the data dir to avoid issues when re-enabling etcd
++	oldDataDir := etcdDBDir(e.config) + ""-old-"" + strconv.Itoa(int(time.Now().Unix()))
++
++	// move the data directory to a temp path
++	return os.Rename(etcdDBDir(e.config), oldDataDir)
+ }",Is there anything we should do in the event we're unable to renaming the directory?,Could we rename this to `etcdDBDir(e.config)`
+2192,"@@ -17,12 +17,17 @@ limitations under the License.
+ package main
+
+ import (
+-	""github.com/google/knative-gcp/pkg/broker/ingress""
+ 	""go.uber.org/zap""
++
++	""github.com/google/knative-gcp/pkg/broker/ingress""
+ 	""knative.dev/pkg/logging""
+ 	""knative.dev/pkg/signals""
+ )
+
++// main creates and starts an ingress handler using default options.
++// 1. it listens on port 8080
++// 2. it reads ""GOOGLE_CLOUD_PROJECT"" env var for pubsub project.
++// 3. it expects broker configmap mounted at ""/var/run/cloud-run-events/broker/targets""
+ func main() {
+ 	// Since we pass nil, a default config with no error will be returned.
+ 	cfg, _ := logging.NewConfigFromMap(nil)",How is this env var populated? Can this be retrieved from cluster metadata?,s/it listens on port 8080/it reads on port 8080
+2193,"@@ -61,10 +61,11 @@ func (s *Service) reconcileInternetGateways() error {
+ 		EC2Client:   s.scope.EC2,
+ 		BuildParams: s.getGatewayTagParams(*gateway.InternetGatewayId),
+ 	})
+-
+ 	if err != nil {
++		record.Warnf(s.scope.Cluster, ""FailedTagInternetGateway"", ""Failed to tag managed Internet Gateway %q: %v"", gateway.InternetGatewayId, err)
+ 		return errors.Wrapf(err, ""failed to tag internet gateway %q"", *gateway.InternetGatewayId)
+ 	}
++	record.Eventf(s.scope.Cluster, ""SuccessfulTagInternetGateway"", ""Tagged managed Internet Gateway %q"", gateway.InternetGatewayId)
+
+ 	return nil
+ }","Should probably skip the success event here, since it could be a noop.",We should also record the successful tag.
+2194,"@@ -1840,7 +1840,8 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
+                 chaptercardbuilder.buildChapterCards(item, chapters, {
+                     itemsContainer: scenesContent,
+                     backdropShape: 'overflowBackdrop',
+-                    squareShape: 'overflowSquare'
++                    squareShape: 'overflowSquare',
++                    imageBlurhashes: item.ImageBlurHashes
+                 });
+             });
+         } else {",I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan,Do you think we should just pass the blur hash
+2195,"@@ -509,9 +509,6 @@ func DecryptDecode(ctx context.Context, k *secrets.Keeper, post Decode) Decode {
+ }
+
+ // DecoderByName returns a *Decoder based on decoderName.
+-// It is intended to be used by VariableURLOpeners in driver packages.
+-var DecoderByName = decoderByName
+-
+ // Supported values include:
+ //   - empty string: Returns the default from the URLOpener.Decoder, or
+ //       BytesDecoder if URLOpener.Decoder is nil (which is true if you're","Let's keep this line in the docstring, to let end users know they shouldn't be using this directly.",I think we can nuke this variable now that it i
+2196,"@@ -39,13 +39,10 @@ func (p *Protocol) validateCreateStake(ctx context.Context, act *action.CreateSt
+ 	if act.Amount().Cmp(p.config.MinStakeAmount) == -1 {
+ 		return errors.Wrap(ErrInvalidAmount, ""stake amount is less than the minimum requirement"")
+ 	}
+-	if act.GasPrice().Sign() < 0 {
+-		return errors.Wrap(action.ErrGasPrice, ""negative value"")
+-	}
+ 	if !p.inMemCandidates.ContainsName(act.Candidate()) {
+ 		return errors.Wrap(ErrInvalidCanName, ""cannot find candidate in candidate center"")
+ 	}
+-	return nil
++	return act.AbstractAction.SelfCheck()
+ }
+
+ func (p *Protocol) validateUnstake(ctx context.Context, act *action.Unstake) error {",can do the same for other validateXXX(),"same as above, not sure why this is gone"
+2197,"@@ -512,7 +512,7 @@ ReturnCode_t PublisherImpl::wait_for_acknowledgments(
+
+ const DomainParticipant* PublisherImpl::get_participant() const
+ {
+-    return participant_->get_participant();
++    return const_cast<const DomainParticipantImpl*>(participant_)->get_participant();
+ }
+
+ const Publisher* PublisherImpl::get_publisher() const",Why is this necessary?,Does this need a check against DomainPar
+2198,"@@ -21,6 +21,7 @@ import os
+ import sys
+ import sphinx
+ from sphinx.errors import VersionRequirementError
++import datetime
+
+ curr_path = os.path.dirname(os.path.realpath(__file__))
+ libpath = os.path.join(curr_path, '../python-package/')",Please move this import upper to other similar imports,I think this import is unused.
+2199,"@@ -1749,6 +1749,14 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
+                 arch_mcontext_reset_stolen_reg(dcontext, mc);
+             }
+         });
++        IF_AARCHXX({
++            // XXX i#4495: Consider saving stolen reg's application value.
++            set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
++            // XXX: This path is tested by linux.thread-reset and linux.clone-reset.
++            // We just haven't run those on ARM yet.
++            IF_ARM(ASSERT_NOT_TESTED());
++        });
++
+         /* We send all threads, regardless of whether was in DR or not, to
+          * re-interp from translated cxt, to avoid having to handle stale
+          * local state problems if we simply resumed.","Include the key word ""translated"". Otherwise the reader will find this confusing.",Is this still relevant with the other ch
+2200,"@@ -263,6 +263,7 @@ public abstract class ElasticsearchStorage extends zipkin2.storage.StorageCompon
+   public abstract int namesLookback();
+
+   @Override
++  @Memoized // Memoized to reduce garbage as this is effectively a singleton.
+   public SpanStore spanStore() {
+     ensureIndexTemplates();
+     return new ElasticsearchSpanStore(this);",why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations.,I think the other `SpanStore` implementations in this class are better named as `elasticsearch.spanStore()` and `elasticsearch.spanStore()` implement `SpanStore.close()` and `elasticsearch.spanStore().close()`
+2201,"@@ -106,7 +106,7 @@ function nativeSelectValue(node) {
+   }
+
+   const options = querySelectorAll(vNode, 'option');
+-  const selectedOptions = options.filter(option => option.hasAttr('selected'));
++  const selectedOptions = options.filter(option => option.actualNode.selected);
+
+   // browser automatically selects the first option
+   if (!selectedOptions.length) {","I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug.",Why not use `option.selected` directly?
+2202,"@@ -8,13 +8,15 @@ from kinto.core.storage import (
+     DEFAULT_ID_FIELD, DEFAULT_MODIFIED_FIELD, DEFAULT_DELETED_FIELD,
+     MISSING)
+ from kinto.core.storage.postgresql.client import create_from_config
++from kinto.core.storage.postgresql.migrator import Migrator
+ from kinto.core.utils import COMPARISON
+
+
+ logger = logging.getLogger(__name__)
++HERE = os.path.abspath(os.path.dirname(__file__))
+
+
+-class Storage(StorageBase):
++class Storage(StorageBase, Migrator):
+     """"""Storage backend using PostgreSQL.
+
+     Recommended in production (*requires PostgreSQL 9.4 or higher*).",ditto about use of `abspath`,We should probably try to do this as much as possible. So that we can use `sys.path.dirname()` instead of `os.path.dirname(__file__)`
+2203,"@@ -30,13 +30,13 @@ public class Euler05Test {
+     }
+
+     private static long smallestPositiveNumberEvenlyDivisibleByAllNumbersFrom1To(int max) {
+-        final long smallestStepsNeeded = max * (max - 1);
+-        return Stream.gen(smallestStepsNeeded, prev -> prev + smallestStepsNeeded)
+-                .findFirst(val -> isEvenlyDivisibleByAllNumbersFrom1To(max, val))
+-                .get();
++        return Stream.rangeClosed(2, max)
++                .map(PrimeNumbers::factorization)
++                .reduce((m1, m2) -> m1.merged(m2, Math::max))
++                .foldLeft(1L, (xs, x) -> xs * pow(x.key, x.value));
+     }
+
+-    private static boolean isEvenlyDivisibleByAllNumbersFrom1To(int max, long val) {
+-        return !Stream.rangeClosed(1, max).exists(d -> val % d != 0);
++    private static long pow(long a, long p) {
++        return Stream.rangeClosed(1, p).fold(1L, (xs, x) -> xs * a);
+     }
+ }",this reduces the runtime by 50 times,nit: `pow` can be replaced with `powOf`
+2204,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....,no need for this test class. There is already a test case called `RemoteDistributorTest`
+2205,"@@ -956,10 +956,10 @@ public class TryTest extends AbstractValueTest {
+
+     private static <T, X extends Throwable> Try<T> failure(Class<X> exceptionType) {
+         try {
+-            final X exception = exceptionType.newInstance();
++            final X exception = exceptionType.getConstructor().newInstance();
+             return Try.failure(exception);
+-        } catch (InstantiationException | IllegalAccessException x) {
+-            throw new IllegalStateException(""Error instantiating "" + exceptionType);
++        } catch (Throwable e) {
++            throw new IllegalStateException(""Error instantiating "" + exceptionType, e);
+         }
+     }
+ ",direct `newInstance` call is also deprecated now,Not sure why this change is needed. It is related to reflection. @stuartwdouglas do you
+2206,"@@ -15,14 +15,15 @@ import (
+ 	""syscall""
+ 	""time""
+
++	""github.com/vishvananda/netlink""
++	weaveapi ""github.com/weaveworks/weave/api""
++	""github.com/weaveworks/weave/common""
++	""golang.org/x/sys/unix""
+ 	api ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/client-go/informers""
+ 	""k8s.io/client-go/kubernetes""
+ 	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/cache""
+-
+-	weaveapi ""github.com/weaveworks/weave/api""
+-	""github.com/weaveworks/weave/common""
+ )
+
+ type nodeInfo struct {","We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo.",These imports should be grouped with the third-party imports below.
+2207,"@@ -184,7 +184,7 @@ abstract class SnapshotProducer<ThisT> implements SnapshotUpdate<ThisT> {
+   /**
+    * Returns the snapshot summary from the implementation and updates totals.
+    */
+-  private Map<String, String> summary(TableMetadata previous) {
++  protected Map<String, String> summary(TableMetadata previous) {
+     Map<String, String> summary = summary();
+
+     if (summary == null) {",Why was this change needed?,Why the change to `protected`?
+2208,"@@ -53,12 +53,14 @@ def get_if_raw_addr(ifname):
+     try:
+         fd = os.popen(""%s %s"" % (conf.prog.ifconfig, ifname))
+     except OSError, msg:
+-        raise Scapy_Exception(""Failed to execute ifconfig: (%s)"" % msg)
++        warning(""Failed to execute ifconfig: (%s)"" % msg)
++        return ""\0\0\0\0""
+
+     # Get IPv4 addresses
+     addresses = [l for l in fd.readlines() if l.find(""netmask"") >= 0]
+     if not addresses:
+-        raise Scapy_Exception(""No IPv4 address found on %s !"" % ifname)
++        warning(""No IPv4 address found on %s !"" % ifname)
++        return ""\0\0\0\0""
+
+     # Pack the first address
+     address = addresses[0].split(' ')[1]","can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(""netmask"") >= 0]`)",Why are we returning a `\0\0\0` instead of just returning `None`?
+2209,"@@ -51,8 +51,8 @@ test_name ""C100554: \
+     message = ""The plan was expected to notify but did not""
+     assert_match(/Notice:/, result.stdout, message)
+     winrm_nodes.each do |node|
+-      message = ""The plan was expceted to mention the host #{node.hostname} with _output""
+-      assert_match(/#{node.hostname}""=>{""_output""=>/, result.stdout, message)
++      message = ""The plan was expected to mention the host #{node.hostname} with _output""
++      assert_match(/#{node.hostname}"",""status"":""success""/, result.stdout, message)
+     end
+
+     winrm_nodes.each do |node|",Why does this check differ from `plan_ssh.rb`?,Prefer single-quoted strings when you don't need string interpola
+2210,"@@ -10,8 +10,8 @@ import (
+ 	""encoding/json""
+ 	""strconv""
+
++	""github.com/iotexproject/go-fsm""
+ 	""github.com/prometheus/client_golang/prometheus""
+-	""github.com/zjshen14/go-fsm""
+ 	""go.uber.org/zap""
+
+ 	""github.com/iotexproject/iotex-core/consensus""",File is not `goimports`-ed (from `goimports`),This import should be moved down to the other go-fsm imports.
+2211,"@@ -16,7 +16,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+     {
+         public const int MaxPooledWriteReqs = 1024;
+
+-        private const int _maxPendingWrites = 3;
+         private const int _maxBytesPreCompleted = 65536;
+         private const int _initialTaskQueues = 64;
+         private const int _maxPooledWriteContexts = 32;","It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it.",Can this be removed? Looks like it is no longer used.
+2212,"@@ -34,6 +34,8 @@ int main (int argc, char * const * argv)
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
++		(""debug_clear_online_weight"", ""clear online_weights table"")
++		(""debug_dump_online_weight"", ""dump online_weights table"")
+ 		(""debug_dump_representatives"", ""List representatives and weights"")
+ 		(""debug_account_count"", ""Display the number of accounts"")
+ 		(""debug_mass_activity"", ""Generates fake debug activity"")",We have cli --online_weight_clear in cli.cpp,I have some concerns about the naming of these options. The options are: * `debug_clear_online_weight` * `debug_dump_representatives` * `debug_mass_activity`
+2213,"@@ -225,7 +225,9 @@ func HTTPServerAttributesFromHTTPRequest(serverName, route string, request *http
+ 		attrs = append(attrs, HTTPRouteKey.String(route))
+ 	}
+ 	if values, ok := request.Header[""X-Forwarded-For""]; ok && len(values) > 0 {
+-		attrs = append(attrs, HTTPClientIPKey.String(values[0]))
++		if addresses := strings.Split(values[0], "",""); len(addresses) > 0 {
++			attrs = append(attrs, HTTPClientIPKey.String(addresses[0]))
++		}
+ 	}
+
+ 	return append(attrs, httpCommonAttributesFromHTTPRequest(request)...)",So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?,Could this cause a problem if there is a malformed header?
+2214,"@@ -93,6 +93,8 @@ public class WebUtils {
+         return ""Killing"";
+       case DISPATCHING:
+         return ""Dispatching"";
++      case EXECUTION_STOPPED:
++        return ""Execution stopped, crashed executor/container"";
+       default:
+     }
+     return ""Unknown"";","How is this message used? Can we remove the ""crashed executor/container"" part which is an implementation detail?","How about ""Executor stopped"" instead of ""Executor stopped""?"
+2215,"@@ -247,7 +247,8 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+         .put(GET_LOG, post(""/session/:sessionId/log""))
+         .put(GET_AVAILABLE_LOG_TYPES, get(""/session/:sessionId/log/types""))
+
+-        .put(STATUS, get(""/status""));
++        .put(STATUS, get(""/status""))
++        .put(HEAP_SNAPSHOT, get(""/session/:sessionId/chromium/heap_snapshot""));
+
+         nameToUrl = builder.build();
+   }","Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?",I would suggest to rename `heap_snapshot` to `heap_snapshot_url` to make it clear what this is used for.
+2216,"@@ -4,7 +4,13 @@
+   <div class=""text-box"">
+
+     <% if @purchaseable.video_available?(@video) %>
+-      <%= render 'watch_video', video: @video, purchase: @purchase %>
++      <div class=""purchase-return-link"">
++        <%=link_to ""Back"", purchase_path(@purchase)%>
++      </div>
++
++      <h3 class=""video-headline"">Watch or Download Video</h3>
++
++      <%= render 'watch_video', video: @video %>
+     <% else %>
+       <p>This video is not yet available. It will be released on <%= @purchaseable.video_available_on(@video).to_s(:simple) %></p>
+     <% end %>",Space after `=`.,Please use `link_to` instead of `link_to`
+2217,"@@ -59,6 +59,7 @@ public class EdgeInvocation extends AbstractRestInvocation {
+     this.responseEx = new VertxServerResponseToHttpServletResponse(context.response());
+     this.httpServerFilters = httpServerFilters;
+     requestEx.setAttribute(RestConst.REST_REQUEST, requestEx);
++    setAfterCreateInvocationHandler(invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));
+   }
+
+   public void edgeInvoke() {",if just need to do something after createInvocation just override and call super first is enough?,When is the context used? I thought it wa
+2218,"@@ -11,7 +11,7 @@ describe Travis::Build::Script::Scala do
+   end
+
+   it_behaves_like 'a build script'
+-  # it_behaves_like 'a jdk build'
++  it_behaves_like 'a jvm build'
+
+   it 'sets TRAVIS_SCALA_VERSION' do
+     should set 'TRAVIS_SCALA_VERSION', '2.10.0'","By the way, I fixed `announce` method (missing `super` call to announce JDK version)","I think we should leave this here, it doe"
+2219,"@@ -505,9 +505,10 @@ public final class TreeSet<T> implements SortedSet<T>, Serializable {
+         }
+     }
+
++    @SuppressWarnings(""unchecked"")
+     @Override
+-    public boolean contains(T element) {
+-        return tree.contains(element);
++    public boolean contains(Object element) {
++        return tree.contains((T) element);
+     }
+
+     @Override",I'm not sure about that... This line can produce <code>ClassCastException</code> if <code>Comparator</code> do not check this.,What is the reason of these suppress warn
+2220,"@@ -737,7 +737,7 @@ type MDOps interface {
+ 	// which may not yet be reflected in the MD if the TLF hasn't been rekeyed since it
+ 	// entered into a conflicting state.
+ 	GetLatestHandleForTLF(ctx context.Context, id TlfID) (
+-		*BareTlfHandle, error)
++		BareTlfHandle, error)
+ }
+
+ // KeyOps fetches server-side key halves from the key server.","There wasn't any special reason for this to return a pointer, right?",Do we get rid of this method entirely? Or was it just not returning anything?
+2221,"@@ -14,15 +14,15 @@ import org.mozilla.vrbrowser.R;
+ import org.mozilla.vrbrowser.ui.views.UIButton;
+ import org.mozilla.vrbrowser.ui.widgets.NotificationManager.Notification.NotificationPosition;
+
+-import java.util.HashMap;
+ import java.util.Iterator;
+ import java.util.Map;
++import java.util.concurrent.ConcurrentHashMap;
+
+ public class NotificationManager {
+
+     private static final int DEFAULT_DURATION = 3000;
+
+-    private static HashMap<Integer, NotificationData> mData = new HashMap<>();
++    private static ConcurrentHashMap<Integer, NotificationData> mData = new ConcurrentHashMap<>();
+
+     private static class NotificationData {
+ ",Why the need for a `ConcurrentHashMap`?,"`mData` is never read, so we can remove it."
+2222,"@@ -272,8 +272,13 @@ class Note extends BaseItem {
+ 				let bProp = b[order.by];
+ 				if (typeof aProp === 'string') aProp = aProp.toLowerCase();
+ 				if (typeof bProp === 'string') bProp = bProp.toLowerCase();
+-				if (aProp < bProp) r = +1;
+-				if (aProp > bProp) r = -1;
++
++				if (order.by == 'title' && Setting.value('titleNaturalSort')) {
++					r = this.naturalSortCompare(aProp, bProp, false);
++				} else {
++					if (aProp < bProp) r = +1;
++					if (aProp > bProp) r = -1;
++				}
+ 				if (order.dir == 'ASC') r = -r;
+ 				if (r !== 0) return r;
+ 			}",New code should use strict equality `===`,`this.naturalSortCompare` is not available in IE11. Use `this.order` instead.
+2223,"@@ -84,6 +84,19 @@ describe ""apply"" do
+         resources = result[0]['result']['report']['resource_statuses']
+         expect(resources).to include('Notify[hello world]')
+       end
++
++      it 'applies the deferred type' do
++        result = run_cli_json(%w[plan run basic::defer] + config_flags)
++        expect(result).not_to include('kind')
++        expect(result[0]['status']).to eq('success')
++        resources = result[0]['result']['report']['resource_statuses']
++
++        local_pid = resources['Notify[local pid]']['events'][0]['desired_value'][/(\d+)/, 1]
++        raise 'local pid was not found' if local_pid.nil?
++        remote_pid = resources['Notify[remote pid]']['events'][0]['desired_value'][/(\d+)/, 1]
++        raise 'remote pid was not found' if remote_pid.nil?
++        expect(local_pid).not_to eq(remote_pid)
++      end
+     end
+   end
+ end",`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\d+)/)` seems clearer.,"Looks like this test is failing on Travis, but I don't think it should be fai"
+2224,"@@ -54,7 +54,7 @@ const (
+ // Time out individual tests after 10 seconds.
+ var individualTestTimeout = 10 * time.Second
+
+-func kbfsOpsInit(t *testing.T, changeMd bool) (mockCtrl *gomock.Controller,
++func kbfsOpsInit(t *testing.T) (mockCtrl *gomock.Controller,
+ 	config *ConfigMock, ctx context.Context, cancel context.CancelFunc) {
+ 	ctr := NewSafeTestReporter(t)
+ 	mockCtrl = gomock.NewController(ctr)",Removed now-unneeded param.,I think you didn't mean to remove `changeMd`.
+2225,"@@ -107,6 +107,7 @@ VIEW DATA STRUCTURES
+   go-filecoin show                   - Get human-readable representations of filecoin objects
+
+ NETWORK COMMANDS
++  go-filecoin bitswap                - Explore libp2p bitswap
+   go-filecoin bootstrap              - Interact with bootstrap addresses
+   go-filecoin dht                    - Interact with the dht
+   go-filecoin id                     - Show info about the network peers","(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?",We may want to give this a more descriptive n
+2226,"@@ -85,7 +85,7 @@ storiesOf( 'Analytics Module', module )
+ 				title={ __( 'Top acquisition sources over the last 28 days', 'google-site-kit' ) }
+ 				headerCtaLink=""https://analytics.google.com""
+ 				headerCtaLabel={ __( 'See full stats in Analytics', 'google-site-kit' ) }
+-				footerCtaLabel={ __( 'Analytics', 'google-site-kit' ) }
++				footerCtaLabel={ _x( 'Analytics', 'Service name', 'google-site-kit' ) }
+ 				footerCtaLink=""https://analytics.google.com""
+ 			>
+ 				<div className=""mdc-layout-grid"">",The `_x` function needs to be imported at the top of the file (in addition to `__`),Could you also update the `headerCtaLabel` an
+2227,"@@ -78,8 +78,9 @@ namespace pwiz.SkylineTestFunctional
+             RunUI(() =>
+             {
+                 propDialog.SetQValueTo(0.003f);
++                propDialog.OkDialog();
+             });
+-            OkDialog(propDialog, propDialog.OkDialog);
++            WaitForClosedForm(propDialog);
+             WaitForCondition(() => (DetectionsGraphController.Settings.QValueCutoff == 0.003f));
+             AssertDataCorrect(pane, 0, 0.003f);
+ ",This is functionally equivalent to the code it replaces.,why did this test change?
+2228,"@@ -26,6 +26,8 @@ import (
+ type ENI struct {
+ 	// ID is the id of eni
+ 	ID string `json:""ec2Id""`
++	// ENIType is the type of ENI, valid value: ""default"", ""vlan""
++	ENIType string `json:"",omitempty""`
+ 	// IPV4Addresses is the ipv4 address associated with the eni
+ 	IPV4Addresses []*ENIIPV4Address
+ 	// IPV6Addresses is the ipv6 address associated with the eni","can you change the field name here to ""InterfaceAssociationProtocol""? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload","Is ENIType ""vlan"" or ""vlan""?"
+2229,"@@ -1,5 +1,5 @@
+ /**
+- * core/widgets data store: widget tests.
++ * Widgets data store: widget tests.
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for the other cases.",What's the benefit of this c
+2230,"@@ -301,6 +301,19 @@ public class MetricRegistry implements MetricSet {
+         });
+     }
+
++    /**
++     * Return the {@link Gauge} registered under this name; or create and register
++     * a new {@link SettableGauge} if none is registered.
++     *
++     * @param name the name of the metric
++     * @return a new or pre-existing {@link SettableGauge}
++     * @since 4.2
++     */
++    @SuppressWarnings(""unchecked"")
++    public <T> SettableGauge<T> gauge(String name) {
++        return getOrAdd(name, MetricBuilder.GAUGES);
++    }
++
+     /**
+      * Return the {@link Gauge} registered under this name; or create and register
+      * a new {@link Gauge} using the provided MetricSupplier if none is registered.","Shouldn't line 313 be public \<T\> SettableGauge\<T\> **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well.",typo? `SettableGauge` -> `Ga
+2231,"@@ -287,7 +287,7 @@ def _has_bare_super_call(fundef_node):
+     return False
+
+
+-def _safe_infer_call_result(node, caller, context=None):
++def _safe_infer_call_result(node, caller, context=None): # pylint: disable=inconsistent-return-statements
+     """"""
+     Safely infer the return value of a function.
+ ",I would prefer to just fix the occurences of this new check rather than disable them,Why do we need to disable re
+2232,"@@ -117,9 +117,9 @@ public class UITestUtils {
+     public void addHostedFeedData() throws IOException {
+         if (feedDataHosted) throw new IllegalStateException(""addHostedFeedData was called twice on the same instance"");
+         for (int i = 0; i < NUM_FEEDS; i++) {
+-            Feed feed = new Feed(0, null, ""Title "" + i, ""http://example.com/"" + i, ""Description of feed "" + i,
++            Feed feed = new Feed(0, null, ""Title "" + i, ""https://news.google.com/news/rss?"" + i, ""Description of feed "" + i,
+                     ""http://example.com/pay/feed"" + i, ""author "" + i, ""en"", Feed.TYPE_RSS2, ""feed"" + i, null, null,
+-                    ""http://example.com/feed/src/"" + i, false);
++                    ""https://news.google.com/news/rss?"" + i, false);
+
+             // create items
+             List<FeedItem> items = new ArrayList<>();","The tests should be fixed in #4841, so this is no longer needed","This is not related to this PR, but the `http://example.com/` can be removed."
+2233,"@@ -0,0 +1,17 @@
++<?php
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Core\Infrastructure\Exception;
++
++class SerializationException extends SerializerException
++{
++    public function __construct(string $message, \Throwable $previous = null)
++    {
++        parent::__construct($message, $previous);
++    }
++}",I think it should been in `SharedKernel` module.,Why do we need a separate exception class here? Seems very specific to Elgg\C
+2234,"@@ -317,6 +317,9 @@ type ACMEChallengeSolverHTTP01IngressTemplate struct {
+ 	// will override the in-built values.
+ 	// +optional
+ 	ACMEChallengeSolverHTTP01IngressObjectMeta `json:""metadata""`
++
++	// OverrideNginxIngressWhitelistAnnotation add description here
++	OverrideNginxIngressWhitelistAnnotation string `json:""overrideNginxIngressWhitelistAnnotation,omitempty""`
+ }
+
+ type ACMEChallengeSolverHTTP01IngressObjectMeta struct {",Can we add some description for this field?  ,Can you add the `omitempty` struct tag here?
+2235,"@@ -45,6 +45,7 @@ public class ProtoConverter extends Visitor<Expr, Object> {
+           .put(TimestampType.class, ""Time"")
+           .put(BytesType.class, ""String"")
+           .put(StringType.class, ""String"")
++          .put(TimeType.class, ""Duration"")
+           .build();
+
+   private final IdentityHashMap<Expression, DataType> typeMap;",Should its name be Time or Duration? I can see them both.,"It would be better to have a separate map `Map<TimeType, Duration>`"
+2236,"@@ -31,6 +31,14 @@ type Option interface {
+ 	applyGRPCOption(*otlpconfig.Config)
+ }
+
++func asGRPCOptions(opts []Option) []otlpconfig.GRPCOption {
++	converted := make([]otlpconfig.GRPCOption, len(opts))
++	for i, o := range opts {
++		converted[i] = otlpconfig.NewGRPCOption(o.applyGRPCOption)
++	}
++	return converted
++}
++
+ // RetryConfig defines configuration for retrying batches in case of export
+ // failure using an exponential backoff.
+ type RetryConfig retry.Config",Is this used anywhere?,Could this just be `map[otlpconfig.GRPCOption]otlpconfig.GRPCOption`?
+2237,"@@ -205,6 +205,17 @@ func TestMerge(t *testing.T) {
+ 	}
+ }
+
++func TestEmpty(t *testing.T) {
++	var res *resource.Resource
++	require.Equal(t, """", res.SchemaURL())
++	require.Equal(t, """", res.String())
++	require.Equal(t, []attribute.KeyValue(nil), res.Attributes())
++
++	it := res.Iter()
++	require.Equal(t, 0, it.Len())
++	require.True(t, res.Equal(res))
++}
++
+ func TestDefault(t *testing.T) {
+ 	res := resource.Default()
+ 	require.False(t, res.Equal(resource.Empty()))",I believe that you can use `assert` instead of `require` here and in the following lines,"It's a little clearer if this is `require.NoError(t, err)` like you'v"
+2238,"@@ -177,7 +177,7 @@ func (pb *Actor) CreateChannel(vmctx exec.VMContext, target address.Address, eol
+
+ 	err := withPayerChannels(ctx, storage, payerAddress, func(byChannelID exec.Lookup) error {
+ 		// check to see if payment channel is duplicate
+-		_, err := byChannelID.Find(ctx, channelID.KeyString())
++		err := byChannelID.Find(ctx, channelID.KeyString(), &PaymentChannel{})
+ 		if err != hamt.ErrNotFound { // we expect to not find the payment channel
+ 			if err == nil {
+ 				return Errors[ErrDuplicateChannel]",In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported).,so we don't have to do this anymore?
+2239,"@@ -0,0 +1,8 @@
++package trojan
++
++var (
++	Contains    = contains
++	HashBytes   = hashBytes
++	PadBytes    = padBytesLeft
++	IsPotential = isPotential
++)",is this a new pattern we use in bee? interesting,"Could we call this `PadBytes`, `IsPotential` instead?"
+2240,"@@ -382,7 +382,13 @@ func (f *FsS3) Mkdir() error {
+ 	if err, ok := err.(*s3.Error); ok {
+ 		if err.Code == ""BucketAlreadyOwnedByYou"" {
+ 			return nil
++		} else if err.Code == ""BucketAlreadyExists"" {
++			// Unfortunately Qstack are not reliably returning
++			// BucketAlreadyOwnedByYou, but instead BucketAlreadyExists.
++			// Carry on and wait for potential failure later.
++			return nil
+ 		}
++
+ 	}
+ 	return err
+ }","If you think this PR works, i'll clean this up before resubmitting.",Nit: Carry on
+2241,"@@ -148,6 +148,10 @@ public final class Const {
+   public static final String PATH_CHECKSESSION = ""checksession"";
+
+   public static final String URL_PREFIX = ""urlPrefix"";
+-
++
+   public static final String INSTANCE_PUBKEY_PRO = ""publickey"";
++
++  public static final String GROUPID = ""io.servicecomb"";
++
++  public static final String ARTIFACTID = ""java-chassis"";
+ }",are you sure you can read version by this artifactid?,I would sugge
+2242,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.,why not stati
+2243,"@@ -388,10 +388,13 @@ func (c *client) parse(buf []byte) error {
+ 					arg = buf[c.as : i-c.drop]
+ 				}
+ 				var err error
+-				if c.typ == CLIENT {
++				switch c.typ {
++				case CLIENT:
+ 					err = c.processSub(arg)
+-				} else {
++				case ROUTER:
+ 					err = c.processRemoteSub(arg)
++				case GATEWAY:
++					err = c.processGatewaySubjectSub(arg)
+ 				}
+ 				if err != nil {
+ 					return err",Should we do our own vtable?,processSub an
+2244,"@@ -41,7 +41,6 @@ module C2
+     }
+     config.roadie.url_options = config.action_mailer.default_url_options
+
+-    config.exceptions_app = self.routes
+     config.autoload_paths << Rails.root.join('lib')
+
+     config.assets.precompile << 'common/communicarts.css'",This is the actual fix.,why remove this?
+2245,"@@ -173,7 +173,7 @@ const (
+ 	// cache idx expiration
+ 	defaultCacheIdxExpiration = 5 * time.Minute
+ 	// default sync interval
+-	defaultSyncInterval = 10 * time.Second
++	defaultSyncInterval = 60 * time.Second
+ 	// coalesceMinimum
+ 	coalesceMinimum = 16 * 1024
+ 	// maxFlushWait is maximum we will wait to gather messages to flush.","If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide.",Do we have a fol
+2246,"@@ -341,11 +341,12 @@ type Decoder interface {
+ 	// (0, false).
+ 	MapLen() (int, bool)
+
+-	// If MapLen returned true, the DecodeMap will be called. It should iterate over
+-	// the fields of the value being decoded, invoking the callback on each with the
+-	// field name and a Decoder for the field value. If the callback returns false,
+-	// DecodeMap should return immediately.
+-	DecodeMap(func(string, Decoder) bool)
++	// DecodeMap iterates over the fields of the value being decoded, invoke the
++	// callback on each with field name, a Decoder for the field value, and a bool
++	// to indicate whether or not to use exact match for the field names. It should
++	// be called when MapLen returns true or decoding a struct. If the callback
++	// returns false, DecodeMap should return immediately.
++	DecodeMap(func(string, Decoder, bool) bool)
+
+ 	// AsInterface should decode the value into the Go value that best represents it.
+ 	AsInterface() (interface{}, error)",should be called => will be called,I wonder if it's
+2247,"@@ -133,12 +133,11 @@ func (c *roundCalculator) roundInfo(
+ ) (roundNum uint32, roundStartTime time.Time, err error) {
+ 	lastBlockTime := time.Unix(c.chain.GenesisTimestamp(), 0)
+ 	if height > 1 {
+-		var lastBlock *block.Footer
+-		if lastBlock, err = c.chain.BlockFooterByHeight(height - 1); err != nil {
++		var lastBlock *block.Header
++		if lastBlock, err = c.chain.BlockHeaderByHeight(height - 1); err != nil {
+ 			return
+ 		}
+-		lastBlockCommitTime := lastBlock.CommitTime()
+-		lastBlockTime = lastBlockTime.Add(lastBlockCommitTime.Sub(lastBlockTime) / c.blockInterval * c.blockInterval)
++		lastBlockTime = lastBlockTime.Add(lastBlock.Timestamp().Sub(lastBlockTime) / c.blockInterval * c.blockInterval)
+ 	}
+ 	if !lastBlockTime.Before(now) {
+ 		err = errors.Errorf(","not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different ""last block time"", some use ""commit time"", some use ""block time"". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion.",why was this a b
+2248,"@@ -190,10 +190,12 @@ public class CreateCollectionCmd implements OverseerCollectionMessageHandler.Cmd
+       try {
+         replicaPositions = buildReplicaPositions(ocmh.cloudManager, clusterState, clusterState.getCollection(collectionName), message, shardNames, sessionWrapper);
+       } catch (Assign.AssignmentException e) {
+-        ZkNodeProps deleteMessage = new ZkNodeProps(""name"", collectionName);
+-        new DeleteCollectionCmd(ocmh).call(clusterState, deleteMessage, results);
++        deleteCollection(clusterState, results, collectionName);
+         // unwrap the exception
+         throw new SolrException(ErrorCode.SERVER_ERROR, e.getMessage(), e.getCause());
++      } catch (SolrException e) {
++        deleteCollection(clusterState, results, collectionName);
++        throw e;
+       }
+
+       if (replicaPositions.isEmpty()) {",So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?,I think this is missing the `collectionName` parameter from the `deleteCollection` call
+2249,"@@ -316,13 +316,13 @@ def test_debug_logger_object():
+         assert dt.options.debug.enabled is True
+
+         DT = dt.rbind([])
+-        assert ""dt.rbind([]) {"" in logger.msg
++        assert ""datatable.rbind([]) {"" in logger.msg
+         assert re.search(r""} # \d+(?:\.\d+)?(?:[eE][+-]?\d+)? s"", logger.msg)
+         logger.msg = """"
+
+         with pytest.raises(TypeError):
+             dt.rbind(4)
+-        assert ""dt.rbind(4) {"" in logger.msg
++        assert ""datatable.rbind(4) {"" in logger.msg
+         assert re.search(r""} # \d+(?:\.\d+)?(?:[eE][+-]?\d+)? s \(failed\)"", logger.msg)
+
+ ",`dt` won't work for some reason?,"dtf.rbind(4) -> ""datatable.rbind(4)"""
+2250,"@@ -96,7 +96,7 @@ def add_db(doctest_namespace):
+     doctest_namespace[""db""] = db_name
+
+
+-@pytest.fixture(autouse=os.getenv(""KOALAS_USAGE_LOGGER"", None) is not None)
++@pytest.fixture(autouse=os.getenv(""KOALAS_USAGE_LOGGER"", """") != """")
+ def add_caplog(caplog):
+     with caplog.at_level(logging.INFO, logger=""databricks.koalas.usage_logger""):
+         yield","Is this because ""KOALAS_USAGE_LOGGER"" can be `None` ??","I don't understand this change. If the `KOALAS_USAGE_LOGGER` is set to a string, the `n"
+2251,"@@ -0,0 +1,16 @@
++using Nethermind.Int256;
++
++namespace Nethermind.JsonRpc.Modules.Eth
++{
++    public static class GasPriceConfig
++    {
++        public const int NoHeadBlockChangeErrorCode = 7; //Error code used in debug mode when the head block is not changed
++        public const int PercentileOfSortedTxs = 60; //Percentile of sortedTxList indexes to choose as gas price
++        public const int DefaultBlocksLimit = 20; //Limit for how many blocks we check txs in to add to sortedTxList
++        public const int DefaultGasPrice = 1; //Tx price added to sortedTxList for a block that has 0 txs (now adds 1 tx)
++        public const int SoftTxLimit = 40; //If a block adds only 1 tx price, the block is not counted towards BlocksLimit if sortedTxList.Count() + blocksLeftToCheck <= SoftTxLimit (after price is added to sortedTxList)
++        public const int DefaultBaseFee = 200; //Minimum price a transaction sender has to pay
++        public const int TxLimitFromABlock = 3; //Maximum number of tx we can add to sortedTxList from one block
++        public static readonly UInt256 _maxGasPrice = 500; //Maximum gas price we can return
++    }
++}",I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config,Why are we adding this in this PR?
+2252,"@@ -38,7 +38,9 @@ import (
+ func TestNew(t *testing.T) {
+ 	ctx, _ := SetupFakeContext(t)
+
+-	c := NewController(ctx, configmap.NewStaticWatcher(
++	ctor := NewConstructor(&dataresidency.StoreSingleton{})
++
++	c := ctor(ctx, configmap.NewStaticWatcher(
+ 		&corev1.ConfigMap{
+ 			ObjectMeta: metav1.ObjectMeta{
+ 				Name:      logging.ConfigMapName(),",I would inline the constructor as well,What's the difference between this and `NewController`?
+2253,"@@ -107,10 +107,10 @@ TEST(Scanner, Basic) {
+     };                                                               \
+     GraphScanner lexer;                                              \
+     lexer.setReadBuffer(input);                                      \
+-    nebula::GraphParser::semantic_type dumyyylval;                   \
+-    nebula::GraphParser::location_type dumyyyloc;                    \
++    nebula::GraphParser::semantic_type dummyyylval;                  \
++    nebula::GraphParser::location_type dummyyyloc;                   \
+     try {                                                            \
+-      auto token = lexer.yylex(&dumyyylval, &dumyyyloc);             \
++      auto token = lexer.yylex(&dummyyylval, &dummyyyloc);           \
+       if (token != 0) {                                              \
+         return AssertionFailure() << ""Lexical error should've ""      \
+                                   << ""happened for `"" << STR << ""'""; \",I'm not confident about this...,why do you remove `dumyyyloc` ?
+2254,"@@ -34,6 +34,10 @@ import (
+ 	""github.com/jetstack/cert-manager/pkg/util/pki""
+ )
+
++var (
++	certificateRequestGvk = v1alpha1.SchemeGroupVersion.WithKind(""CertificateRequest"")
++)
++
+ func (c *Controller) Sync(ctx context.Context, cr *v1alpha1.CertificateRequest) (err error) {
+ 	c.metrics.IncrementSyncCallCount(ControllerName)
+ ",There is also `v1alpha1.CertificateRequestKind` I think?,Why not add this to `pkg/apis/core/v1/types.go`?
+2255,"@@ -49,6 +49,10 @@ func SenderJob(name string, envVars []corev1.EnvVar) *batchv1.Job {
+ 	return baseJob(name, ""sender"", envVars)
+ }
+
++func BrokerSenderJob(name string, envVars []corev1.EnvVar) *batchv1.Job {
++	return baseJob(name, ""sender_gcpbroker"", envVars)
++}
++
+ // baseJob will return a base Job that has imageName and envVars set for its PodTemplateSpec.
+ func baseJob(name, imageName string, envVars []corev1.EnvVar) *batchv1.Job {
+ 	return &batchv1.Job{","Can we rename it to make it less confusing? Instead of ""sender-gcpbroker"", maybe name it to ""retryable-sender""",Do you need this function anymore?
+2256,"@@ -136,9 +136,8 @@ public class UnboundPredicate<T> extends Predicate<T, UnboundTerm<T>> implements
+     Literal<T> lit = literal().to(boundTerm.type());
+
+     if (lit == null) {
+-      throw new ValidationException(String.format(
+-          ""Invalid value for conversion to type %s: %s (%s)"",
+-          boundTerm.type(), literal().value(), literal().value().getClass().getName()));
++      throw new ValidationException(""Invalid value for conversion to type %s: %s (%s)"",
++          boundTerm.type(), literal().value(), literal().value().getClass().getName());
+
+     } else if (lit == Literals.aboveMax()) {
+       switch (op()) {","So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called.","It would be better to leave the `%s` on the second line, as it makes it clear that this is a format string."
+2257,"@@ -47,6 +47,19 @@ class OPFMetricsTest(unittest.TestCase):
+ < OPFMetricsTest.DELTA)
+
+
++  def testNRMSE(self):
++    nrmse = getModule(MetricSpec(""nrmse"", None, None,
++{""verbosity"" : OPFMetricsTest.VERBOSITY}))
++    gt = [9, 4, 5, 6]
++    p = [0, 13, 8, 3]
++    for i in xrange(len(gt)):
++      nrmse.addInstance(gt[i], p[i])
++    target = 1.342
++
++    self.assertTrue(abs(nrmse.getMetric()[""value""]-target)\
++< OPFMetricsTest.DELTA)
++
++
+   def testWindowedRMSE(self):
+     wrmse = getModule(MetricSpec(""rmse"", None, None,
+ {""verbosity"": OPFMetricsTest.VERBOSITY, ""window"":3}))",Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway,Are these tests really necessary? Can't they be in the OPFMetricsTest class?
+2258,"@@ -90,6 +90,19 @@ try:
+ except ImportError:
+     GRAPHVIZ_INSTALLED = False
+
++""""""datatable""""""
++try:
++    from datatable import DataTable
++    DT_INSTALLED = True
++except ImportError:
++    DT_INSTALLED = False
++
++    class DataTable(object):
++        """"""Dummy class for DataTable.""""""
++
++        pass
++
++
+ """"""sklearn""""""
+ try:
+     from sklearn.base import BaseEstimator","@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`.",why is this needed?
+2259,"@@ -37,7 +37,7 @@ module RSpec
+           profile.slowest_examples.each do |example|
+             @output.puts ""  #{example.full_description}""
+             @output.puts ""    #{bold(Helpers.format_seconds(example.execution_result.run_time))} "" \
+-                         ""#{bold(""seconds"")} #{format_caller(example.location)}""
++                         ""#{bold('seconds')} #{format_caller(example.location)}""
+           end
+         end
+ ",We're fine with double quotes here. Just for future reference.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+2260,"@@ -242,9 +242,5 @@ func (c call) maxAttemptsError(err error) {
+ }
+
+ func getErrorName(err error) string {
+-	errCode := yarpcerrors.ErrorCode(err)
+-	if errCode == yarpcerrors.CodeOK {
+-		return ""unknown_internal_yarpc""
+-	}
+-	return errCode.String()
++	return yarpcerrors.ErrorCode(err).String()
+ }","can we keep this around? We should make sure we can distinguish between properly wrapped errors and ""unwrapped"" errors",Why was this removed?
+2261,"@@ -14265,6 +14265,10 @@ void PIPELINE_STATE::initGraphicsPipeline(ValidationStateTracker *state_data, co
+         }
+     }
+     graphicsPipelineCI.initialize(pCreateInfo, uses_color_attachment, uses_depthstencil_attachment);
++    if (graphicsPipelineCI.pInputAssemblyState) {
++        topology_at_rasterizer = graphicsPipelineCI.pInputAssemblyState->topology;
++    }
++
+     stage_state.resize(pCreateInfo->stageCount);
+     for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
+         const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];","`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first.",Do you need to check
+2262,"@@ -1,6 +1,10 @@
+ const path = require(""path"");
++const { CleanWebpackPlugin} = require(""clean-webpack-plugin"");
+ const CopyPlugin = require(""copy-webpack-plugin"");
+
++// assets.js
++const Assets = require('./assets');
++
+ module.exports = {
+     context: path.resolve(__dirname, ""src""),
+     entry: ""./bundle.js"",",Should we just inline the assets here? I can't think of an advantage to having them in a separate file.,Do we really need bot
+2263,"@@ -175,13 +175,13 @@ func (t *endpointsChangesTracker) Update(em types.EndpointsMap) map[k8sproxy.Ser
+ 		for spn, endpoints := range change.current {
+ 			em[spn] = endpoints
+ 		}
+-		detectStaleConnections(change.previous, change.current, staleEndpoints)
++		detectStale(change.previous, change.current, staleEndpoints)
+ 	}
+ 	return staleEndpoints
+ }
+
+-// detectStaleConnections updates staleEndpoints with detected stale connections.
+-func detectStaleConnections(oldEndpointsMap, newEndpointsMap types.EndpointsMap, staleEndpoints map[k8sproxy.ServicePortName]map[string]k8sproxy.Endpoint) {
++// detectStale updates staleEndpoints with detected stale endpoints.
++func detectStale(oldEndpointsMap, newEndpointsMap types.EndpointsMap, staleEndpoints map[k8sproxy.ServicePortName]map[string]k8sproxy.Endpoint) {
+ 	for svcPortName, epList := range oldEndpointsMap {
+ 		for _, ep := range epList {
+ 			stale := true",detectStaleEndpoints to be more specific?,@kargakis this functi
+2264,"@@ -100,6 +100,8 @@ class SpatialPoolerCompatabilityTest(unittest.TestCase):
+                            cppSp.getMinPctOverlapDutyCycles())
+     self.assertAlmostEqual(pySp.getMinPctActiveDutyCycles(),
+                            cppSp.getMinPctActiveDutyCycles())
++#    self.assertEqual(pySp.getRandomSP(),  #FIXME enable when done in C++ too
++#                     cppSP.getRandomSP())
+
+     numColumns = pySp.getNumColumns()
+     numInputs = pySp.getNumInputs()","Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost.",Is this a TODO? Is there an issue number tracking this?
+2265,"@@ -78,7 +78,7 @@ func NewStorageMiningSubmodule(minerAddr address.Address, ds datastore.Batching,
+ 		PoStGenerator:    postGen,
+ 		minerNode:        minerNode,
+ 		storageMiner:     storageMiner,
+-		heaviestTipSetCh: c.HeaviestTipSetCh,
++		heaviestTipSetCh: make(chan interface{}),
+ 		poster:           poster.NewPoster(minerAddr, m.Outbox, s, c.State, stateViewer, mw),
+ 	}
+ ",Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method.,"I see that `heaviestTipSetCh` is only used in tests, ca"
+2266,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (IAM) policy.]
++//snippet-sourcedescription:[GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (AWS IAM) policy.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),why did you change this?
+2267,"@@ -76,7 +76,7 @@ public class TestEdgeDriver extends RemoteWebDriver implements WebStorage, Locat
+                 .findFirst().orElseThrow(WebDriverException::new);
+
+         service = (EdgeDriverService) builder.withVerbose(true).withLogFile(logFile.toFile()).build();
+-        LOG.info(""edgedriver will log to "" + logFile);
++        LOG.fine(""edgedriver will log to "" + logFile);
+         service.start();
+         Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));
+       }",This is deliberately at this level.,This should be a warn as well.
+2268,"@@ -63,8 +63,10 @@ func stake2Transfer(args []string) error {
+
+ 	var payload []byte
+ 	if len(args) == 3 {
+-		payload = make([]byte, 2*len([]byte(args[2])))
+-		hex.Encode(payload, []byte(args[2]))
++		payload, err = hex.DecodeString(args[2])
++		if err != nil {
++			return output.NewError(output.ConvertError, ""failed to decode data"", err)
++		}
+ 	}
+
+ 	sender, err := signer()",payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go,Does this panic if `args[2]` is malformed? Would it be safer to panic if `args[2]` is malformed?
+2269,"@@ -37,7 +37,14 @@ class PricingGroupDataFixture extends AbstractReferenceFixture
+
+         $pricingGroupData->name = 'Obyčejný zákazník';
+         $domainId = 2;
+-        $this->createPricingGroup($pricingGroupData, $domainId, self::PRICING_GROUP_ORDINARY_DOMAIN_2);
++
++        $alreadyCreatedDemoPricingGroupsByDomain = $this->pricingGroupFacade->getByDomainId($domainId);
++        if (count($alreadyCreatedDemoPricingGroupsByDomain) > 0) {
++            $pricingGroup = reset($alreadyCreatedDemoPricingGroupsByDomain);
++
++            $this->pricingGroupFacade->edit($pricingGroup->getId(), $pricingGroupData);
++            $this->addReference(self::PRICING_GROUP_ORDINARY_DOMAIN_2, $pricingGroup);
++        }
+
+         $pricingGroupData->name = 'VIP zákazník';
+         $domainId1 = 2;",should this be kept in the `else` branch?,Why are you using this variable instead of just using the `$this->pricingGroupFacade`?
+2270,"@@ -32,10 +32,11 @@ import (
+ 	""strings""
+ 	""time""
+
++	""sync""
++
+ 	""cloud.google.com/go/storage""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/daisy/compute""
+ 	""google.golang.org/api/option""
+-	""sync""
+ )
+
+ const defaultTimeout = ""10m""","Why not put this below ""strings""?",nit: remove newline.
+2271,"@@ -33,6 +33,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+         {
+         }
+
++        /// <summary>
++        /// For testing purposes.
++        /// </summary>
++        public int UvPipeCount => _dispatchPipes.Count;
++
+         private UvPipeHandle ListenPipe { get; set; }
+
+         public async Task StartAsync(",Make it `internal` if it's just for testing.,Can you also test if this property is set to something non-zero?
+2272,"@@ -1,4 +1,4 @@
+-# pylint: disable=missing-docstring,pointless-statement,expression-not-assigned,too-few-public-methods,import-error,no-init,wrong-import-position,no-else-return
++# pylint: disable=missing-docstring,pointless-statement,expression-not-assigned,too-few-public-methods,import-error,no-init,wrong-import-position,no-else-return, logical-tautology
+
+ # standard types
+ 1 in [1, 2, 3]",What is triggering this message in this file?,I don't think we need to disable any of these anymore.
+2273,"@@ -212,7 +212,7 @@ def start_workers(args, actions, context, analyzer_config_map, skp_handler,
+         pool.map_async(check,
+                        analyzed_actions,
+                        1,
+-                       callback=worker_result_handler).get(float('inf'))
++                       callback=worker_result_handler).get()
+
+         pool.close()
+     except Exception:",Are you sure this should be removed?,`get(float('inf'))` is the same as `get(float('inf'))`
+2274,"@@ -121,8 +121,7 @@ public class DefaultTrustedSocketFactory implements TrustedSocketFactory {
+
+
+     private Context context;
+-    private ProxySettings proxySettings;
+-
++    private ProxySettings proxySettings = new ProxySettings(false, """", 0);
+
+     public DefaultTrustedSocketFactory(Context context, ProxySettings proxySettings) {
+         this.context = context;",What's that good for? The field is initialized in the constructor.,Is there a reason why you hard-coded the size of the p
+2275,"@@ -484,12 +484,14 @@ class _Connection(object):
+         if not isinstance(self.connection, SSL.Connection):
+             if not getattr(self.wfile, ""closed"", False):
+                 try:
+-                    self.wfile.flush()
+-                    self.wfile.close()
++                    if self.wfile:
++                        self.wfile.flush()
++                        self.wfile.close()
+                 except exceptions.TcpDisconnect:
+                     pass
+
+-            self.rfile.close()
++            if self.rfile:
++                self.rfile.close()
+         else:
+             try:
+                 self.connection.shutdown()",This shouldn't be necessary (same below). Do you have a traceback for me?,Why do you need to check for `self.wfile` here? Isn't
+2276,"@@ -13,6 +13,8 @@ import (
+ 	""strconv""
+ 	""syscall"" // only for Signal
+
++	""github.com/opencontainers/runc/libcontainer/logs""
++
+ 	""github.com/opencontainers/runc/libcontainer/cgroups""
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ 	""github.com/opencontainers/runc/libcontainer/intelrdt""",No newline needed here.,Remove empty line.
+2277,"@@ -7,11 +7,12 @@ package libkbfs
+ import (
+ 	""errors""
+ 	""fmt""
+-	""io/ioutil""
+ 	""os""
+ 	""path/filepath""
+ 	""sync""
+
++	""github.com/keybase/kbfs/ioutil""
++
+ 	""github.com/keybase/client/go/logger""
+ 	""github.com/keybase/kbfs/kbfscodec""
+ 	""github.com/keybase/kbfs/kbfscrypto""",Why a separate block?,did you mean to de
+2278,"@@ -2531,10 +2531,16 @@ reg_get_size(reg_id_t reg)
+         return OPSZ_SCALABLE;
+     if (reg >= DR_REG_P0 && reg <= DR_REG_P15)
+         return OPSZ_SCALABLE_PRED;
++    if (reg == DR_REG_CNTVCT_EL0)
++        return OPSZ_8;
++    if (reg >= DR_REG_NZCV && reg <= DR_REG_FPSR)
++        return OPSZ_8;
+ #    endif
+     if (reg == DR_REG_TPIDRURW || reg == DR_REG_TPIDRURO)
+         return OPSZ_PTR;
+ #endif
++    LOG(GLOBAL, LOG_ANNOTATIONS, 2, ""reg=%d, %s, last reg=%d\n"", reg,
++        get_register_name(reg), DR_REG_LAST_ENUM);
+     CLIENT_ASSERT(false, ""reg_get_size: invalid register"");
+     return OPSZ_NA;
+ }",Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?,This is a debug me
+2279,"@@ -684,11 +684,10 @@ is_private_key = lambda x: is_xprv(x) or is_private_key_list(x)
+ is_bip32_key = lambda x: is_xprv(x) or is_xpub(x)
+
+
+-def bip44_derivation(account_id):
+-    if bitcoin.TESTNET:
+-        return ""m/44'/1'/%d'""% int(account_id)
+-    else:
+-        return ""m/44'/0'/%d'""% int(account_id)
++def bip44_derivation(account_id, segwit=False):
++    bip  = 49 if segwit else 44
++    coin = 1 if bitcoin.TESTNET else 0
++    return ""m/%d'/%d'/%d'"" % (bip, coin, int(account_id))
+
+ def from_seed(seed, passphrase):
+     t = seed_type(seed)","`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you.",please add a docst
+2280,"@@ -129,10 +129,10 @@ namespace pwiz.Skyline.Controls.Graphs
+         public void SetQValueTo(float qValue)
+         {
+             if (qValue == .01f)
+-                rbQValue01.Select();
++                rbQValue01.Checked = true;
+             else
+             {
+-                rbQValueCustom.Select();
++                rbQValueCustom.Checked = true;
+                 txtQValueCustom.Text = qValue.ToString(CultureInfo.CurrentCulture);
+             }
+         }","Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though.",The custom field `rbQValue01.Checked` doesn't seem to be used in this file. Is this intended?
+2281,"@@ -111,7 +111,14 @@ func (p *VSphereCloudBuilder) addClusterDeploymentPlatform(o *Builder, cd *hivev
+ }
+
+ func (p *VSphereCloudBuilder) addMachinePoolPlatform(o *Builder, mp *hivev1.MachinePool) {
+-	mp.Spec.Platform.VSphere = &hivev1vsphere.MachinePool{}
++	mp.Spec.Platform.VSphere = &hivev1vsphere.MachinePool{
++		NumCPUs:           2,
++		NumCoresPerSocket: 1,
++		MemoryMiB:         8192,
++		OSDisk: hivev1vsphere.OSDisk{
++			DiskSizeGB: 120,
++		},
++	}
+ }
+
+ func (p *VSphereCloudBuilder) addInstallConfigPlatform(o *Builder, ic *installertypes.InstallConfig) {","Seems a little low, but is this an installer default?",Do we really need to change the default from `NumCPUs` to `NumCoresPerSocket`?
+2282,"@@ -10,6 +10,19 @@ from kinto.core import utils
+ logger = structlog.get_logger()
+
+
++def reset_logger():
++    """"""Hack to work around https://github.com/hynek/structlog/issues/71.
++
++    This clears a magic field in the logger so that it will regenerate
++    the right kind of logger on its next use.
++
++    Do this when you call structlog.configure(). Otherwise, some parts
++    of the logger will be outdated and you may get strange behavior.
++
++    """"""
++    logger._logger = None
++
++
+ def decode_value(value):
+     try:
+         return six.text_type(value)",Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger.,"nit: I would write: ""This clears a magic field in the logger so that it will regenerate the r"
+2283,"@@ -31,11 +31,8 @@ type Block struct {
+ 	// holders for an epoch.
+ 	Parents SortedCidSet `json:""parents""`
+
+-	// ParentWeightNum is the numerator of the aggregate chain weight of the parent set.
+-	ParentWeightNum Uint64 `json:""parentWeightNumerator""`
+-
+-	// ParentWeightDenom is the denominator of the aggregate chain weight of the parent set
+-	ParentWeightDenom Uint64 `json:""parentWeightDenominator""`
++	// ParentWeight is the aggregate chain weight of the parent set.
++	ParentWeight Uint64 `json:""parentWeight""`
+
+ 	// Height is the chain height of this block.
+ 	Height Uint64 `json:""height""`",This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time,Why not just `ParentWeight`?
+2284,"@@ -464,11 +464,9 @@ func TestNodeCacheGCReal(t *testing.T) {
+
+ 	childNode1 = nil
+ 	runtime.GC()
+-	_ = <-finalizerChan
++	<-finalizerChan
+
+-	if len(ncs.nodes) != 2 {
+-		t.Errorf(""Expected %d nodes, got %d"", 2, len(ncs.nodes))
+-	}
++	require.Len(t, ncs.nodes, 1)
+
+ 	// Make sure childNode2 isn't GCed until after this point.
+ 	func(interface{}) {}(childNode2)",Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior.,Could you explain why we need to assert on the result of len?
+2285,"@@ -45,7 +45,7 @@ func TestValidJsonAccount(t *testing.T) {
+         ""domain"": {
+             ""fulldomain"": ""fooldom"",
+             ""password"": ""secret"",
+-            ""subdomain"": ""subdoom"",
++            ""subdomain"": ""subdom"",
+             ""username"": ""usernom""
+         }
+     }`)","Afaict, nothing cares","No need to change this, it's the default."
+2286,"@@ -507,7 +507,9 @@ func decryptMDPrivateData(ctx context.Context, codec kbfscodec.Codec,
+ 		}
+ 	}
+
+-	// Re-embed the block changes if it's needed.
++	// Re-embed the block changes if it's needed.  TODO: we don't need
++	// to do this in minimal mode, since there's no node cache
++	// (KBFS-2026).
+ 	err := reembedBlockChanges(
+ 		ctx, codec, bcache, bops, rmdWithKeys.TlfID(),
+ 		&pmd, rmdWithKeys, log)","I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?",Is this accurate? Is there an issue tracking this?
+2287,"@@ -5,7 +5,7 @@ using System.Linq;
+
+ namespace Datadog.Trace.Headers
+ {
+-    internal class NameValueHeadersCollection : IHeadersCollection
++    internal readonly struct NameValueHeadersCollection : IHeadersCollection
+     {
+         private readonly NameValueCollection _headers;
+ ",Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?,@timbussmann I'm not sure if this rename is ok. `NameValueCol
+2288,"@@ -19,9 +19,12 @@ package org.hyperledger.besu.ethereum.api.query;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.Log;
+ import org.hyperledger.besu.ethereum.core.LogTopic;
++import org.hyperledger.besu.ethereum.core.LogsBloomFilter;
+
+ import java.util.Arrays;
+ import java.util.List;
++import java.util.Objects;
++import java.util.stream.Collectors;
+
+ import com.google.common.collect.Lists;
+ ",These are just aliases now,This should be merged with the other log filter imports
+2289,"@@ -1,4 +1,4 @@
+-<% content_for :page_title, @video.title %>
++<% content_for :page_title, @video.title.html_safe %>
+
+ <% content_for :landing_page_back_link do %>
+   <%= link_to '&larr; All Videos'.html_safe, '/the-weekly-iteration' %>",Does this mean we can remove `raw` from `_head_contents` partial?,"The `.html_safe` is not necessary here, because the `ti"
+2290,"@@ -113,7 +113,9 @@ class CapacitorSplashScreen {
+     `;
+
+     this.mainWindowRef.on('closed', () => {
+-      this.splashWindow.close();
++      if (this.splashWindow && !this.splashWindow.isDestroyed) {
++        this.splashWindow.close();
++      }
+     });
+
+     this.splashWindow.loadURL(`data:text/html;charset=UTF-8,${splashHtml}`, {baseURLForDataURL: `file://${rootPath}/splash_assets/`});","`isDestroyed` is a function, not a property. This condition will always return false.",Did you mean to check `!this.splashWindow.isDestroyed`?
+2291,"@@ -30,6 +30,8 @@ const (
+ 	Version_1_28 DockerVersion = ""1.28""
+ 	Version_1_29 DockerVersion = ""1.29""
+ 	Version_1_30 DockerVersion = ""1.30""
++	Version_1_31 DockerVersion = ""1.31""
++	Version_1_32 DockerVersion = ""1.32""
+ )
+
+ // getKnownAPIVersions returns all of the API versions that we know about.",Why are we adding these versions?,do we need this for 1.31 and 1.32?
+2292,"@@ -271,6 +271,8 @@ def process_one_user(user):
+     spotify.update_latest_listened_at(user.user_id, latest_listened_at)
+     spotify.update_last_updated(user.user_id)
+
++    current_app.logger.info('imported %d listens for %s' % (len(listens), str(user)))
++
+
+ def process_all_spotify_users():
+     """""" Get a batch of users to be processed and import their Spotify plays.","fyi, you can do this by doing `.info(""string %s %s"", formatparam, formatparam2)` instead of doing a string format with `""str"" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important","Should we make this a `debug` level, `trace` is probably more appropriate here as well."
+2293,"@@ -0,0 +1,17 @@
++<%= render ""offerings/meta"", offering: @offering %>
++
++<p>
++  We're adding you to the GitHub repository, and we'll redirect you as soon it's
++  ready. You may receive an email from GitHub asking you to confirm your
++  membership, so make sure to take quick look in your inbox.
++</p>
++
++<% content_for :javascript do %>
++  <script type=""text/javascript"">
++    (function () {
++      setTimeout(function reload() {
++        window.location.reload();
++      }, 5000);
++    })();
++  </script>
++<% end -%>","Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`","I don't think this is the right place for this, but I'm not sure if it's the right plac"
+2294,"@@ -33,16 +33,16 @@ import (
+ 	""sync""
+ 	""time""
+
++	""crypto/tls""
+ 	""github.com/aws/amazon-ecs-agent/agent/config""
++	""github.com/aws/amazon-ecs-agent/agent/utils""
++	""github.com/aws/amazon-ecs-agent/agent/utils/cipher""
+ 	""github.com/aws/amazon-ecs-agent/agent/wsclient/wsconn""
+ 	""github.com/aws/aws-sdk-go/aws/credentials""
+ 	""github.com/aws/aws-sdk-go/private/protocol/json/jsonutil""
+ 	""github.com/cihub/seelog""
+ 	""github.com/gorilla/websocket""
+ 	""github.com/pkg/errors""
+-	""github.com/aws/amazon-ecs-agent/agent/utils/cipher""
+-	""crypto/tls""
+-	""github.com/aws/amazon-ecs-agent/agent/utils""
+ )
+
+ const (",Can you move `crypto/tls` into the block at the top with all the other stdlib imports?,"These changes should be reverted, right?"
+2295,"@@ -403,7 +403,7 @@ for steps in config['predictionSteps']:
+                  params={'errorMetric': 'aae', 'window': 1000, 'steps': steps}))
+   control['metrics'].append(
+       MetricSpec(field=config['predictedField'], metric='multiStep',
+-                 inferenceElement='multiStepBestPredictions',
++                 inferenceElement='anomalyScore',
+                  params={'errorMetric': 'altMAPE', 'window': 1000, 'steps': steps}))
+   control['metrics'].append(
+       MetricSpec(field=config['predictedField'], metric='trivial',",What is the motivation for this change?,this metric has been deprecated. Please add back the multiStepBestPredictions metric
+2296,"@@ -74,9 +74,15 @@ type Topic interface {
+ // Subscription receives published messages.
+ type Subscription interface {
+ 	// ReceiveBatch should return a batch of messages that have queued up
+-	// for the subscription on the server. If no messages are available
+-	// yet, it must block until there is at least one, or the context is
+-	// done.
++	// for the subscription on the server.
++	//
++	// If there is a transient failure, this method should not retry but
++	// should return a nil slice and an error. The concrete API will take
++	// care of retry logic.
++	//
++	// If the service returns no messages for some other reason, this
++	// method should return the empty slice of messages and not attempt to
++	// retry.
+ 	//
+ 	// ReceiveBatch is only called sequentially for individual
+ 	// Subscriptions.","OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting.","If the service returns no messages for some other reason, this should either return an error or a nil slice."
+2297,"@@ -45,7 +45,10 @@ Status MatchValidator::validateImpl() {
+
+         auto matchClauseCtx = getContext<MatchClauseContext>();
+         matchClauseCtx->aliasesUsed = aliasesUsed;
+-        NG_RETURN_IF_ERROR(validatePath(matchClause->path(), *matchClauseCtx));
++        if (matchClause->path()->pathSize() > 1) {
++          return Status::SemanticError(""Multi paths not supported."");
++        }
++        NG_RETURN_IF_ERROR(validatePath(matchClause->path()->path(0) /* TODO */, *matchClauseCtx));
+         if (matchClause->where() != nullptr) {
+           auto whereClauseCtx = getContext<WhereClauseContext>();
+           whereClauseCtx->aliasesUsed = &matchClauseCtx->aliasesGenerated;",The data structure of `MatchClauseContext` may need to be redesigned.,I wouldn't expect a TODO in this error message.
+2298,"@@ -236,8 +236,13 @@ func testSendReceive(t *testing.T, newHarness HarnessMaker) {
+ 	}
+ 	defer cleanup()
+
+-	want := publishN(ctx, t, top, 3)
+-	got := receiveN(ctx, t, sub, len(want))
++	wantChan := make(chan []*pubsub.Message)
++	gotChan := make(chan []*pubsub.Message)
++	n := 3
++	go func() { gotChan <- receiveN(ctx, t, sub, n) }()
++	go func() { wantChan <- publishN(ctx, t, top, n) }()
++	want := <-wantChan
++	got := <-gotChan
+
+ 	// Check that the received messages match the sent ones.
+ 	if diff := diffMessageSets(got, want); diff != """" {","You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called.",why the goroutine here?
+2299,"@@ -50,7 +50,7 @@ class ProposalsController < ApplicationController
+   end
+
+   def approve
+-    approval = proposal.existing_approval_for(current_user)
++    approval = proposal.existing_step_for(current_user)
+     approval.update_attributes!(completer: current_user)
+     approval.approve!
+     flash[:success] = ""You have approved #{proposal.public_id}.""",how do we know that the step in question is an approval type step?,Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
+2300,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+
+ import com.google.common.base.Predicate;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.,Is this import necessary?
+2301,"@@ -0,0 +1,7 @@
++module io.vavr {
++  requires io.vavr.match;
++  exports io.vavr;
++  exports io.vavr.collection;
++  exports io.vavr.control;
++  exports io.vavr.concurrent;
++}","Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?",why is this exported?
+2302,"@@ -293,7 +293,12 @@ hipError_t hipCreateTextureObject(hipTextureObject_t* pTexObject, const hipResou
+         hsa_ext_sampler_descriptor_t samplerDescriptor;
+         fillSamplerDescriptor(samplerDescriptor, pTexDesc->addressMode[0], pTexDesc->filterMode,
+                               pTexDesc->normalizedCoords);
+-
++        if(hipResourceTypeLinear == pResDesc->resType) {
++           samplerDescriptor.filter_mode = HSA_EXT_SAMPLER_FILTER_MODE_NEAREST;
++           samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_BORDER;
++        } else if(!pTexDesc->normalizedCoords) {
++            samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_EDGE;
++        }
+         hsa_access_permission_t permission = HSA_ACCESS_PERMISSION_RW;
+         if (HSA_STATUS_SUCCESS != hsa_ext_image_create_with_layout(
+                                       *agent, &imageDescriptor, devPtr, permission,",Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?,Does it make sense to set
+2303,"@@ -0,0 +1,19 @@
++# frozen_string_literal: true
++
++module Faker
++  class Show < Base
++    class << self
++      def adult_musical
++        fetch('show.adult_musical')
++      end
++
++      def kids_musical
++        fetch('show.kids_musical')
++      end
++
++      def play
++        fetch('show.play')
++      end
++    end
++  end
++end",This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`.,always use safe navigatio
+2304,"@@ -58,6 +58,14 @@ Puppet::Functions.create_function(:run_task) do
+     end || (raise Puppet::ParseError, 'Task parameters did not match')
+     task = task_signature.task
+
++    if executor.noop
++      if task.supports_noop
++        use_args['_noop'] = true
++      else
++        raise Puppet::ParseError, 'Task does not support noop'
++      end
++    end
++
+     # Ensure that that given targets are all Target instances
+     targets = [targets] unless targets.is_a?(Array)
+     targets = targets.flatten.map { |t| t.is_a?(String) ? Puppet::Pops::Types::TypeFactory.target.create(t) : t }",I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though.,"Rather than checking for `supports_noop` here, can we just check for `task.respond_to?(:noop)`?"
+2305,"@@ -11,6 +11,7 @@ import (
+
+ 	""github.com/CoderZhi/go-ethereum/common""
+ 	""github.com/CoderZhi/go-ethereum/core/types""
++
+ 	""github.com/iotexproject/iotex-core/address""
+ 	""github.com/iotexproject/iotex-core/logger""
+ 	""github.com/iotexproject/iotex-core/pkg/hash""",File is not `goimports`-ed,Nit: Empty newline
+2306,"@@ -35,12 +35,15 @@ class CollectionViewTest(BaseWebTest, unittest.TestCase):
+                           headers=self.headers,
+                           status=400)
+
+-    def test_unknown_bucket_raises_404(self):
++    def test_unknown_bucket_raises_403(self):
+         other_bucket = self.collections_url.replace('beers', 'sodas')
+-        self.app.get(other_bucket, headers=self.headers, status=404)
++        self.app.get(other_bucket, headers=self.headers, status=403)
+
+     def test_collections_are_isolated_by_bucket(self):
+-        other_bucket = self.collection_url.replace('beers', 'water')
++        other_bucket = self.collection_url.replace('beers', 'sodas')
++        self.app.put_json('/buckets/sodas',
++                          MINIMALIST_BUCKET,
++                          headers=self.headers)
+         self.app.get(other_bucket, headers=self.headers, status=404)
+
+ ",why should unknown raise a 403?,Why does this need to change?
+2307,"@@ -87,11 +87,11 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			c._vnode = newVNode;
+
+ 			// Invoke getDerivedStateFromProps
+-			let s = c._nextState || c.state;
++			if (c._nextState==null) {
++				c._nextState = c.state;
++			}
+ 			if (newType.getDerivedStateFromProps!=null) {
+-				oldState = assign({}, c.state);
+-				if (s===c.state) s = c._nextState = assign({}, s);
+-				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
++				assign(c._nextState==c.state ? (c._nextState = assign({}, c._nextState)) : c._nextState, newType.getDerivedStateFromProps(newVNode.props, c._nextState));
+ 			}
+
+ 			// Invoke pre-render lifecycle methods","The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?",`s` won't be needed anymore?
+2308,"@@ -36,6 +36,8 @@ flags.DEFINE_string('groups_service_account_key_file', None,
+                     'runnning locally.')
+ flags.DEFINE_integer('max_admin_api_calls_per_day', 150000,
+                      'Admin SDK queries per day.')
++flags.DEFINE_integer('max_results_admin_api', 500,
+++                     'maxResult param for the Admin SDK list() method')
+
+
+ class AdminDirectoryClient(_base_client.BaseClient):",nit: align the leftmost quotes,"I think this should be a list, not an int. The typical convention is to have a comma separated string."
+2309,"@@ -98,6 +98,11 @@ type AgentConfig struct {
+ 	// APIPort is the port for the antrea-agent APIServer to serve on.
+ 	// Defaults to 10350.
+ 	APIPort int `yaml:""apiPort,omitempty""`
++
++	// ClusterMembershipPort is the server port used by the antrea-agent to run a gossip-based cluster membership protocol. Currently it's used only when the Egress feature is enabled.
++	// Defaults to 10351.
++	ClusterMembershipPort int `yaml:""clusterPort,omitempty""`
++
+ 	// Enable metrics exposure via Prometheus. Initializes Prometheus metrics listener
+ 	// Defaults to true.
+ 	EnablePrometheusMetrics bool `yaml:""enablePrometheusMetrics,omitempty""`","Probably ""server port"" -> ""TCP port""",Should we default this value to 10351?
+2310,"@@ -91,7 +91,11 @@ public class Lucene80Codec extends Codec {
+    *             flushed/merged segments.
+    */
+   public Lucene80Codec(Mode mode) {
+-    super(""Lucene80"");
++    this(""Lucene80"", mode);
++  }
++
++  protected Lucene80Codec(String name, Mode mode) {
++    super(name);
+     this.storedFieldsFormat = new Lucene50StoredFieldsFormat(Objects.requireNonNull(mode));
+     this.defaultFormat = new Lucene50PostingsFormat();
+   }",can you use FilterCodec instead?,"Can we call the old constructor `Lucene80Codec(String name, Mode mode)` for consistency?"
+2311,"@@ -407,6 +407,19 @@ class Setting extends BaseModel {
+ 			tagHeaderIsExpanded: { value: true, type: Setting.TYPE_BOOL, public: false, appTypes: ['desktop'] },
+ 			folderHeaderIsExpanded: { value: true, type: Setting.TYPE_BOOL, public: false, appTypes: ['desktop'] },
+ 			editor: { value: '', type: Setting.TYPE_STRING, subType: 'file_path_and_args', public: true, appTypes: ['cli', 'desktop'], label: () => _('Text editor command'), description: () => _('The editor command (may include arguments) that will be used to open a note. If none is provided it will try to auto-detect the default editor.') },
++			'export.pdfPageSize': { value: 'A4', type: Setting.TYPE_STRING, isEnum: true, public: true, appTypes: ['desktop'], label: () => _('Page size for PDF export'), options: () => {
++				return {
++					'A4': _('A4'),
++					'Letter': _('Letter'),
++				};
++			}},
++			'export.pdfPageOrientation': { value: false, type: Setting.TYPE_BOOL, isEnum: true, public: true, appTypes: ['desktop'], label: () => _('Page orientation for PDF export'), options: () => {
++				return {
++					false: _('Portrait'),
++					true: _('Landscape'),
++				};
++			}},
++
+
+ 			'net.customCertificates': {
+ 				value: '',","I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values ""portrait"" and ""landscape""? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`",Is there a reason why you chose `A4` instead of `Letter`?
+2312,"@@ -12,3 +12,11 @@ var dbSchemaVersion = Migration{
+ 		return CommitProgress(db, nil, true)
+ 	},
+ }
++
++var dbSchemaVersion2 = Migration{
++	Name: ""db_schema_version2"",
++	Up: func(db ethdb.Database, tmpdir string, progress []byte, CommitProgress etl.LoadCommitHandler) (err error) {
++		// This migration is no-op, but it forces the migration mechanism to apply it and thus write the DB schema version info
++		return CommitProgress(db, nil, true)
++	},
++}",I think this migration should fail for MDBX if it uses old table names,Why does it force the migration mechanism to apply it and thus write the DB schema version info?
+2313,"@@ -224,7 +224,7 @@ module Beaker
+       # @raise [ArgumentError] if a hosts file is generated, but it can't
+       #   be read by the HostsFileParser
+       def parse_hosts_options
+-        if File.exists?(@options[:hosts_file])
++        if @options[:hosts_file].nil? || File.exists?(@options[:hosts_file])
+           #read the hosts file that contains the node configuration and hypervisor info
+           return Beaker::Options::HostsFileParser.parse_hosts_file(@options[:hosts_file])
+         end","Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad.",Metrics/LineLength: Line is too long. [90/80]
+2314,"@@ -91,6 +91,14 @@ namespace NLog
+         /// Loads NLog config created by the method <paramref name=""configBuilder""/>
+         /// </summary>
+         public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, Action<ISetupLoadConfigurationBuilder> configBuilder)
++        {
++            return LoadConfiguration(setupBuilder, true, configBuilder);
++        }
++
++        /// <summary>
++        /// Loads NLog config created by the method <paramref name=""configBuilder""/>
++        /// </summary>
++        public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, bool applyOnReload, Action<ISetupLoadConfigurationBuilder> configBuilder)
+         {
+             var config = setupBuilder.LogFactory._config;
+             var setupConfig = new SetupLoadConfigurationBuilder(setupBuilder.LogFactory, config);",I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?,should applyOnReload be the last argument?
+2315,"@@ -410,7 +410,7 @@ public class MultiPhraseQuery extends Query {
+    * <p>
+    * Note: positions are merged during freq()
+    */
+-  static class UnionPostingsEnum extends PostingsEnum {
++  public static class UnionPostingsEnum extends PostingsEnum {
+     /** queue ordered by docid */
+     final DocsQueue docsQueue;
+     /** cost of this enum: sum of its subs */",This is used in o.a.l.sandbox.search.PhraseWildcardQuery.,why not make it `private` ?
+2316,"@@ -42,6 +42,7 @@ type stateDB struct {
+ 	dao                db.KVStore // the underlying DB for account/contract storage
+ 	timerFactory       *prometheustimer.TimerFactory
+ 	workingsets        *lru.Cache // lru cache for workingsets
++	protocolView       protocol.Dock
+ }
+
+ // StateDBOption sets stateDB construction parameter",view should be loaded on start for both statedb and factory,Might be better to call this `protocolView` than `protocol.Dock`.
+2317,"@@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Http
+         private ConnectionFilterContext _filterContext;
+         private LibuvStream _libuvStream;
+         private FilteredStreamAdapter _filteredStreamAdapter;
+-        private Task _readInputContinuation;
++        private Task _readInputTask;
+
+         private readonly SocketInput _rawSocketInput;
+         private readonly SocketOutput _rawSocketOutput;",Why rename? Just curious...,Do we still need the `_readInputContinuation` field?
+2318,"@@ -309,12 +309,14 @@ public class VideoplayerActivity extends MediaplayerActivity {
+     public void onStartTrackingTouch(SeekBar seekBar) {
+         super.onStartTrackingTouch(seekBar);
+         videoControlsHider.stop();
++        controls.setVisibility(View.GONE);
+     }
+
+     @Override
+     public void onStopTrackingTouch(SeekBar seekBar) {
+         super.onStopTrackingTouch(seekBar);
+         setupVideoControlsToggler();
++        controls.setVisibility(View.VISIBLE);
+     }
+
+     @Override",Is this needed? I think it calls the super function that already does that.,"This is not related to this PR, but it seems like this view shoul"
+2319,"@@ -538,7 +538,9 @@ class BBoxHead(BaseModule):
+         labels = labels.view(1, 1, -1).expand_as(scores)
+         labels = labels.reshape(batch_size, -1)
+         scores = scores.reshape(batch_size, -1)
+-        bboxes = bboxes.reshape(batch_size, -1, 4)
++        if self.reg_class_agnostic:
++            bboxes = bboxes.reshape(batch_size, -1, 4)
++            bboxes = bboxes.repeat(1, self.num_classes, 1)
+
+         max_size = torch.max(img_shape)
+         # Offset bboxes of each class so that bboxes of different labels","This might slow down the inference time, are we sure we need to do that?",This is the only thing I don't love of the use of `reg_class_agno
+2320,"@@ -23,11 +23,9 @@ import (
+ )
+
+ func Example() {
+-	// This example is used in https://gocloud.dev/howto/sql/#aws
+-
+-	// import _ ""gocloud.dev/mysql/awsmysql""
+-
+-	// Variables set up elsewhere:
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/mysql/awsmysql""
++	// PRAGMA(gocloud.dev): Skip until next blank line.
+ 	ctx := context.Background()
+
+ 	// Replace these with your actual settings.","This would read better if you add ""Skip code/lines"" or (exclude/hide code if you follow my earlier suggestion"")","Actually now I can figure out how to do this, is there a reason why you didn't just do `gocloud.dev/mysql/awsmysql`"
+2321,"@@ -34,6 +34,13 @@ import java.util.HashSet;
+ import java.util.Map;
+ import javax.imageio.ImageIO;
+ import org.apache.commons.io.IOUtils;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
+
+ public class DatasetUtil {
+ ",Looks like glassfish went a bit nuts doing a refactor,this looks like something that should be in `DatasetUtils`
+2322,"@@ -84,6 +84,17 @@ namespace OpenTelemetry.Trace.Export.Internal
+             return Task.WhenAll(tasks);
+         }
+
++        public override Task ForceFlushAsync(CancellationToken cancellationToken)
++        {
++            var tasks = new List<Task>();
++            foreach (var processor in this.processors)
++            {
++                tasks.Add(processor.ForceFlushAsync(cancellationToken));
++            }
++
++            return Task.WhenAll(tasks);
++        }
++
+         public void Dispose()
+         {
+             foreach (var processor in this.processors)",nit: allocate the list using the number of processors.,Why do we need a new list here? Can't we just add the forceFlushAsync to the base class?
+2323,"@@ -142,10 +142,10 @@ public class PartitionSpec implements Serializable {
+
+   public String partitionToPath(StructLike data) {
+     StringBuilder sb = new StringBuilder();
+-    Class<?>[] javaClasses = javaClasses();
+-    for (int i = 0; i < javaClasses.length; i += 1) {
++    Class<?>[] initializedClasses = javaClasses();
++    for (int i = 0; i < initializedClasses.length; i += 1) {
+       PartitionField field = fields[i];
+-      String valueString = field.transform().toHumanString(get(data, i, javaClasses[i]));
++      String valueString = field.transform().toHumanString(get(data, i, initializedClasses[i]));
+
+       if (i > 0) {
+         sb.append(""/"");",Was this change triggered by baseline?,nit: update copyright year in header
+2324,"@@ -36,17 +36,13 @@ class OrgThirtyDayActivity < ActiveRecord::Base
+     private
+
+     def with_commits_and_affiliates
+-      orgs = Organization.arel_table
+       joins(:organization)
+-        .where(id: orgs[:thirty_day_activity_id])
+         .where(arel_table[:thirty_day_commit_count].gt(0)
+         .and(arel_table[:affiliate_count].gt(0)))
+     end
+
+     def with_thirty_day_commit_count
+-      orgs = Organization.arel_table
+       joins(:organization)
+-        .where(id: orgs[:thirty_day_activity_id])
+         .where.not(thirty_day_commit_count: nil)
+         .order(thirty_day_commit_count: :desc)
+         .limit(5)",This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there.,Metrics/LineLength: Line is too long. [90/80]
+2325,"@@ -39,6 +39,7 @@ public class RestExplorerApp extends Application {
+ 	public void onCreate() {
+ 		super.onCreate();
+ 		SalesforceSDKManager.initNative(getApplicationContext(), new KeyImpl(), ExplorerActivity.class);
++		SalesforceSDKManager.getInstance().setBrowserLoginEnabled(true);
+
+ 		/*
+ 		 * Un-comment the line below to enable push notifications in this app.",Setting browser based login as the default for `RestAPIExplorer`.,Is there a reason to have a separate instance
+2326,"@@ -231,6 +231,11 @@ void DataParallelTreeLearner<TREELEARNER_T>::FindBestSplitsFromHistograms(const
+   }
+
+   // sync global best info
++  auto max_cat_threshold = this->config_->max_cat_threshold;
++  int splitInfoSize = SplitInfo::Size(max_cat_threshold);
++  if (input_buffer_.size() < splitInfoSize * 2) {
++    input_buffer_.resize(splitInfoSize * 2);
++  }
+   SyncUpGlobalBestSplit(input_buffer_.data(), input_buffer_.data(), &smaller_best_split, &larger_best_split, this->config_->max_cat_threshold);
+
+   // set best split",maybe we can do this in Init function?,This could just be `splitInfoSize`.
+2327,"@@ -2086,10 +2086,15 @@ func (wh *WorkflowHandler) ResetWorkflowExecution(ctx context.Context, request *
+ 	if request == nil {
+ 		return nil, errRequestNotSet
+ 	}
+-
+ 	if request.GetNamespace() == """" {
+ 		return nil, errNamespaceNotSet
+ 	}
++	if request.GetRequestId() == """" {
++		return nil, errRequestIDNotSet
++	}
++	if len(request.GetRequestId()) > wh.config.MaxIDLengthLimit() {
++		return nil, errRequestIDTooLong
++	}
+
+ 	if err := wh.validateExecution(request.WorkflowExecution); err != nil {
+ 		return nil, err","How about if request ID not set, service should generate a random uuid?",I think this should be `>= wh.config.MaxIDLen
+2328,"@@ -105,7 +105,7 @@ func TestPerformUpdateWithUpdatesDisabled(t *testing.T) {
+ 		Reason:            ptr(""Updates are disabled"").(*string),
+ 	}})
+
+-	u.performUpdateHandler(statemanager.NewNoopStateManager(), engine.NewTaskEngine(cfg, nil, nil, nil, nil, nil, nil))(&ecsacs.PerformUpdateMessage{
++	u.performUpdateHandler(statemanager.NewNoopStateManager(), engine.NewTaskEngine(cfg, nil, nil, nil, nil, nil, nil, nil))(&ecsacs.PerformUpdateMessage{
+ 		ClusterArn:           ptr(""cluster"").(*string),
+ 		ContainerInstanceArn: ptr(""containerInstance"").(*string),
+ 		MessageId:            ptr(""mid"").(*string),",minor: this is an opportunity for you to split these long lines into multiple lines :),Why do we need this change?
+2329,"@@ -259,7 +259,10 @@ class RequestsParser(object):
+             req = ensure_is_dict(raw_requests, key, ""url"")
+             if not require_url and ""url"" not in req:
+                 req[""url""] = None
+-            requests.append(self.__parse_request(req))
++            try:
++                requests.append(self.__parse_request(req))
++            except:
++                raise TaurusConfigError(""Wrong request:\n %s"" % req)
+         return requests
+
+     def extract_requests(self, require_url=True):","It would be nice to have exception dumped somewhere (debug logs, info logs).",Should this be a `ConfigErr
+2330,"@@ -84,6 +84,13 @@ type Topic interface {
+ 	// https://github.com/google/go-cloud/blob/master/internal/docs/design.md#as
+ 	// for more background.
+ 	As(i interface{}) bool
++
++	// As allows providers to expose provider-specific types.
++	//
++	// See
++	// https://github.com/google/go-cloud/blob/master/internal/docs/design.md#as
++	// for more background.
++	MessageAs(m *Message, i interface{}) bool
+ }
+
+ // Subscription receives published messages.","So I don't think this is right, as discussed on #657.",this is definitely a good i
+2331,"@@ -65,10 +65,16 @@ GROUP_IDS = """"""
+     SELECT group_id from groups_{0};
+ """"""
+
+-GROUP_USERS = """"""
++GROUP_ID = """"""
++    SELECT group_id
++    FROM groups_{1}
++    WHERE group_email = ""{0}"";
++""""""
++
++GROUP_MEMBERS = """"""
+     SELECT group_id, member_role, member_type, member_id, member_email
+-    FROM group_members_{0}
+-    WHERE member_status = ""ACTIVE"" and member_type = ""USER"";
++    FROM group_members_{1}
++    WHERE group_id = ""{0}"";
+ """"""
+
+ BUCKETS = """"""","should the group_id = ""{0}"" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized.",is this going to change any
+2332,"@@ -89,7 +89,12 @@ class HierarchicHTTPRequest(HTTPRequest):
+                 raise TaurusConfigError(""Items from upload-files must specify parameter name"")
+
+             path_exc = TaurusConfigError(""Items from upload-files must specify path to file"")
+-            file_dict[""path""] = get_full_path(self.engine.find_file(file_dict.get(""path"", path_exc)))
++            path = str(file_dict.get(""path"", path_exc))
++            if not path.startswith('$'):    # exclude varables
++                path = get_full_path(self.engine.find_file(path))   # prepare full path for jmx
++
++            file_dict[""path""] = path
++
+             mime = mimetypes.guess_type(file_dict[""path""])[0] or ""application/octet-stream""
+             file_dict.get('mime-type', mime)
+         self.content_encoding = self.config.get('content-encoding', None)","Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code.",What does this do? I'm concerned that this may bite us in the future if we add another file to the upload-files list that contain `$` in the future.
+2333,"@@ -20,6 +20,11 @@ class FormTestModel extends Model
+     {
+         return ['dropdown', 'options'];
+     }
++
++    public function staticMethodOptions()
++    {
++        return ['static', 'method'];
++    }
+ }
+
+ class FormHelper",@bennothommo can you revert this section? It shouldn't be required.,Wouldn't be better to have a static method that returns either `true` or `false`?
+2334,"@@ -92,9 +92,13 @@ module Ncr
+       ""ncr""
+     end
+
+-    # @todo - this is pretty ugly
+     def public_identifier
+-      self.cart.id
++      fiscal_year = self.created_at.year
++      if self.created_at.month >= 10
++        fiscal_year += 1
++      end
++      fiscal_year = fiscal_year % 100   # convert to two-digit
++      ""FY"" + fiscal_year.to_s.rjust(2, ""0"") + "" ##{self.id}""
+     end
+
+     def total_price",Minor: maybe move the above to a `#fiscal_year` method?,Redundant `self` detected.
+2335,"@@ -62,3 +62,13 @@ class BuildTest(QuiltTestCase):
+             'Expected dataframes to have same # columns'
+         del os.environ[""QUILT_PACKAGE_FORMAT""]
+         # TODO add more integrity checks, incl. negative test cases
++
++    def test_generate_buildfile(self):
++        mydir = os.path.dirname(__file__)
++        path = os.path.join(mydir, 'data')
++        buildfilepath = os.path.join(path, 'build.yml')
++        assert not os.path.exists(buildfilepath)
++        build.generate_build_file(path)
++        assert os.path.exists(buildfilepath)
++        build.build_package('test_hdf5', 'generated', buildfilepath)
++        os.remove(buildfilepath)",You should use the current directory instead - it's a temporary directory that will get removed when the test is done.,"I'd use `os.path.join(mydir, 'data', 'build.yml')`"
+2336,"@@ -549,7 +549,7 @@ public class ContainerizedDispatchManagerTest {
+         this.containerizedDispatchManager.getExecutionDispatcher(this.flow1.getExecutionId()));
+     thread.start();
+     synchronized (thread) {
+-      thread.wait();
++      thread.join();
+     }
+     assertThat(flow1.getStatus()).isEqualTo(Status.FAILED);
+     verify(onExecutionEventListener).onExecutionEvent(this.flow1, Constants.RESTART_FLOW);",I think we don't need synchronization here.,Should we replace `wait()` with `join()` ?
+2337,"@@ -92,7 +92,7 @@ public final class OAuth2AuthorizedClientArgumentResolver implements HandlerMeth
+ 							clientRegistrationId.flatMap(id -> Mono.error(new IllegalStateException(
+ 									""Unable to resolve the Authorized Client with registration identifier \""""
+ 											+ id
+-											+ ""\"". An \""authenticated\"" or \""unauthenticated\"" session is required. To allow for unauthenticated access, ensure ServerHttpSecurity.anonymous() is configured.""))))
++											+ ""\"". An \""authenticated\"" or \""anonymous\"" request is required. To allow for anonymous access, ensure ServerHttpSecurity.anonymous() is configured.""))))
+ 					.flatMap(zipped -> {
+ 						String registrationId = zipped.getT1();
+ 						String username = zipped.getT2();",I don't think this should be changed since on the reactive side we don't support anonymous users.,I think this message should be updated. `A
+2338,"@@ -116,7 +116,7 @@ module Mongoid
+
+           before_destroy do
+             if record = __send__(name)
+-              record[cache_column] = (record[cache_column] || 0) - 1
++              record[cache_column] = (record[cache_column] || 0) - 1 unless record.frozen?
+
+               if record.persisted?
+                 record.class.decrement_counter(cache_column, record._id)",Maybe this `if` should be on line 118?,Rails/DynamicFindFind: Use find_by instead
+2339,"@@ -45,8 +45,8 @@ type (
+ 	// the less than equal bucket count for the pre-determined boundaries.
+ 	state struct {
+ 		bucketCounts []float64
+-		count        metric.Number
+ 		sum          metric.Number
++		count        int64
+ 	}
+ )
+ ",Cool. (I thought I had fixed this already in #812.),Does this need to be public?
+2340,"@@ -36,7 +36,7 @@ module Bolt
+
+     TRANSPORT_OPTIONS = %i[password run-as sudo-password extensions
+                            private-key tty tmpdir user connect-timeout
+-                           cacert token-file service-url].freeze
++                           cacert token-file service-url interpreters].freeze
+
+     # TODO: move these to the transport themselves
+     TRANSPORT_SPECIFIC_DEFAULTS = {",I intend to do this as soon as I have tests passing.,`service-url` interpreters should be `service_url` for consistency with other interpreters.
+2341,"@@ -0,0 +1,7 @@
++#!/usr/bin/python3
++
++import sys
++import os
++sys.stdin.read()
++with open(os.environ['QUTE_FIFO'], 'wb') as fifo:
++    fifo.write(b':message-info ""stdin closed""\n')",Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it.,If there's any particular reason to use `os.stdin` instead of `os.devnull`?
+2342,"@@ -263,6 +263,11 @@ size_t wlr_session_find_gpus(struct wlr_session *session,
+ 		return explicit_find_gpus(session, ret_len, ret, explicit);
+ 	}
+
++#ifdef __FreeBSD__
++	// XXX: libudev-devd does not return any GPUs (yet?)
++	return explicit_find_gpus(session, ret_len, ret, ""/dev/drm/0"");
++#else
++
+ 	struct udev_enumerate *en = udev_enumerate_new(session->udev);
+ 	if (!en) {
+ 		wlr_log(L_ERROR, ""Failed to create udev enumeration"");",Did you file a bug to follow up on this?,Should this be using `/dev/drm/1` instead of `/dev/drm/0`?
+2343,"@@ -156,10 +156,13 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+     this.io = io;
+     this.encryptionManager = encryptionManager;
+     this.caseSensitive = caseSensitive;
+-
+-    this.batchReadsEnabled = options.get(""vectorization-enabled"").map(Boolean::parseBoolean).orElseGet(() ->
+-        PropertyUtil.propertyAsBoolean(table.properties(),
+-            TableProperties.PARQUET_VECTORIZATION_ENABLED, TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
++    boolean batchReadsSparkSessionConf = SparkSession.active().sparkContext().getConf()
++            .getBoolean(""read.parquet.vectorization.enabled"", true);
++    boolean batchReadsEnabledTableProp = options.get(""vectorization-enabled"").map(Boolean::parseBoolean).orElseGet(() ->
++            PropertyUtil.propertyAsBoolean(table.properties(),
++                    TableProperties.PARQUET_VECTORIZATION_ENABLED,
++                    TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
++    this.batchReadsEnabled = !batchReadsSparkSessionConf ? false : batchReadsEnabledTableProp;
+     this.batchSize = options.get(""batch-size"").map(Integer::parseInt).orElseGet(() ->
+         PropertyUtil.propertyAsInt(table.properties(),
+           TableProperties.PARQUET_BATCH_SIZE, TableProperties.PARQUET_BATCH_SIZE_DEFAULT));",Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?,`read.parquet.vectorization.enabled` -> `read.parquet.vectorization.enabled` ?
+2344,"@@ -1,4 +1,6 @@
+ RSpec::Support.require_rspec_core ""formatters/base_formatter""
++require 'pathname'
++
+
+ module RSpec
+   module Core","This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines.",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+2345,"@@ -1426,6 +1426,13 @@ public class DatasetsIT {
+
+         // This should fail, because we are attempting to link the dataset
+         // to its own dataverse:
++        Response publishTargetDataverse = UtilIT.publishDataverseViaNativeApi(dataverseAlias,  apiToken);
++        publishTargetDataverse.prettyPrint();
++                        publishTargetDataverse.then().assertThat()
++                        .statusCode(OK.getStatusCode());
++
++        Response publishDatasetForLinking = UtilIT.publishDatasetViaNativeApi(datasetId, ""major"", apiToken);
++
+         Response createLinkingDatasetResponse = UtilIT.createDatasetLink(datasetId.longValue(), dataverseAlias, apiToken);
+         createLinkingDatasetResponse.prettyPrint();
+         createLinkingDatasetResponse.then().assertThat()",It would be nice to fix the indentation above.,Please test the response
+2346,"@@ -9334,8 +9334,8 @@ return [
+ 'openssl_x509_export_to_file' => ['bool', 'certificate'=>'string|resource', 'output_filename'=>'string', 'no_text='=>'bool'],
+ 'openssl_x509_fingerprint' => ['string|false', 'certificate'=>'string|resource', 'digest_algo='=>'string', 'binary='=>'bool'],
+ 'openssl_x509_free' => ['void', 'certificate'=>'resource'],
+-'openssl_x509_parse' => ['array|false', 'certificate'=>'string|resource', 'short_names='=>'bool'],
+-'openssl_x509_read' => ['resource|false', 'certificate'=>'string|resource'],
++'openssl_x509_parse' => ['array|false', 'certificate'=>'OpenSSLCertificate|string', 'short_names'=>'bool|null'],
++'openssl_x509_read' => ['OpenSSLCertificate|false', 'certificate'=>'OpenSSLCertificate|string'],
+ 'ord' => ['int', 'character'=>'string'],
+ 'OuterIterator::current' => ['mixed'],
+ 'OuterIterator::getInnerIterator' => ['Iterator'],","`short_names` is still optional, so `=` that indicates it has to stay there.",Shouldn't `short_names` be `bool` now?
+2347,"@@ -153,6 +153,10 @@ func (agent *ecsAgent) appendFirelensFluentbitCapabilities(capabilities []*ecs.A
+ 	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentbit)
+ }
+
++func (agent *ecsAgent) appendEFSCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityEFS)
++}
++
+ func (agent *ecsAgent) appendFirelensLoggingDriverCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+ 	return appendNameOnlyAttribute(capabilities, capabilityPrefix+capabilityFirelensLoggingDriver)
+ }",missing calling of this method,This is more of a question for my own understanding of the fluentbit code: do we need to have both
+2348,"@@ -9,10 +9,12 @@ import (
+ 	""fmt""
+ 	""text/template""
+
++	""github.com/aws/aws-sdk-go/aws""
++	""github.com/aws/aws-sdk-go/service/cloudformation""
+ 	""github.com/fatih/structs""
+ 	""gopkg.in/yaml.v3""
+
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	archerCfn ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy/cloudformation""
+ 	""github.com/aws/amazon-ecs-cli-v2/templates""
+ )
+ ","We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point.",Nit: Please sort this new import in the third-party imports section near the other services
+2349,"@@ -25,6 +25,8 @@ import (
+ // Stress chaos is a chaos to generate plenty of stresses over a collection of pods.
+
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ // +chaos-mesh:experiment
+
+ // StressChaos is the Schema for the stresschaos API",`StressChaos` does not contains a field .spec.action,"Since we are touching this file, do we want to also add `+kubebuilder:object:root=true`?"
+2350,"@@ -1931,7 +1931,12 @@ class FunctionCallTest extends TestCase
+                       return $b[""a""];
+                     }
+
+-                    a([""a"" => ""hello""]);',
++                    function b(string $str): string
++                    {
++                        return $str;
++                    }
++
++                    a([""a"" => b(""hello"")]);',
+                 'error_message' => 'InvalidScalarArgument',
+             ],
+             'objectLikeKeyChecksAgainstDifferentTKeyedArray' => [","Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`.",There's no test coverage here.
+2351,"@@ -27,6 +27,8 @@
+ #include ""cast_utils.h""
+ #include ""layer_validation_tests.h""
+
++#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
++
+ class MessageIdFilter {
+   public:
+     MessageIdFilter(const char *filter_string) {",I this used anyplace?,"`sizeof(a[0])` is equal to `sizeof(a[0]), ARRAY_SIZE(a)`"
+2352,"@@ -102,7 +102,7 @@ public class TestHiveMetastore {
+         .transportFactory(new TTransportFactory())
+         .protocolFactory(new TBinaryProtocol.Factory())
+         .minWorkerThreads(3)
+-        .maxWorkerThreads(5);
++        .maxWorkerThreads(8);
+
+     return new TThreadPoolServer(args);
+   }",Why was this change required?,How about making this configurable?
+2353,"@@ -39,6 +39,7 @@ public class AuthorizationException extends ProcessEngineException {
+
+   protected final String userId;
+   protected final List<MissingAuthorization> missingAuthorizations;
++  protected final boolean missingAdminRole;
+
+   // these properties have been replaced by the list of missingAuthorizations
+   // and are only left because this is a public API package and users might","I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think.  ",missingAdminRole -> hasAdminRole
+2354,"@@ -14,6 +14,9 @@ import com.google.flatbuffers.*;
+ public final class Monster extends Table {
+   public static Monster getRootAsMonster(ByteBuffer _bb) { return getRootAsMonster(_bb, new Monster()); }
+   public static Monster getRootAsMonster(ByteBuffer _bb, Monster obj) { _bb.order(ByteOrder.LITTLE_ENDIAN); return (obj.__assign(_bb.getInt(_bb.position()) + _bb.position(), _bb)); }
++  public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb) { return getSizePrefixedRootAsMonster(_psbb, new Monster()); }
++  public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb, Monster obj) { ByteBuffer _bb = _psbb.slice(); _bb.position(4); return getRootAsMonster(_bb, obj); }
++  public static int getSizePrefix(ByteBuffer _bb) { _bb.order(ByteOrder.LITTLE_ENDIAN); return _bb.getInt(_bb.position()); }
+   public static boolean MonsterBufferHasIdentifier(ByteBuffer _bb) { return __has_identifier(_bb, ""MONS""); }
+   public void __init(int _i, ByteBuffer _bb) { bb_pos = _i; bb = _bb; }
+   public Monster __assign(int _i, ByteBuffer _bb) { __init(_i, _bb); return this; }","Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?",This should probably be `_bb.order(
+2355,"@@ -45,10 +45,11 @@ import getNoDataComponent from '../../../../components/legacy-notifications/noda
+ import getDataErrorComponent from '../../../../components/legacy-notifications/data-error';
+ import HelpLink from '../../../../components/HelpLink';
+ import { getCurrentDateRangeDayCount } from '../../../../util/date-range';
+-import { STORE_NAME } from '../../datastore/constants';
++import { STORE_NAME, DATE_RANGE_OFFSET } from '../../datastore/constants';
+ import { CORE_USER } from '../../../../googlesitekit/datastore/user/constants';
+ import { CORE_SITE } from '../../../../googlesitekit/datastore/site/constants';
+ import { untrailingslashit } from '../../../../util';
++import { generateDateRangeArgs } from '../../util/report-date-range-args';
+
+ const { useSelect } = Data;
+ ",Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`.,You should move `DATE_RANGE_OFFSET`
+2356,"@@ -21,11 +21,14 @@ async function proceedToSetUpAnalytics() {
+ 	await Promise.all( [
+ 		expect( page ).toClick( '.googlesitekit-cta-link', { text: /set up analytics/i } ),
+ 		page.waitForSelector( '.googlesitekit-setup-module--analytics' ),
+-		page.waitForResponse( ( res ) => res.url().match( 'analytics/data' ) ),
++		page.waitForResponse( ( res ) => res.url().match( 'analytics/data/accounts-properties-profiles' ) ),
+ 	] );
+ }
+
+-const EXISTING_PROPERTY_ID = 'UA-00000001-1';
++const existingTag = {
++	accountID: '999',
++	propertyID: 'UA-999-9',
++};
+
+ describe( 'setting up the Analytics module with no existing account and with an existing tag', () => {
+ 	beforeAll( async () => {",I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?,It would be great to also test for the `accountID` and `propertyID` values.
+2357,"@@ -11,13 +11,13 @@ import (
+ 	""strings""
+ )
+
+-type identityManager struct {
+-	keystoreManager keystoreInterface
++type IdentityManager struct {
++	KeystoreManager keystoreInterface
+ }
+
+-func NewIdentityManager(keydir string) *identityManager {
+-	return &identityManager{
+-		keystoreManager: keystore.NewKeyStore(keydir, keystore.StandardScryptN, keystore.StandardScryptP),
++func NewIdentityManager(keydir string) *IdentityManager {
++	return &IdentityManager{
++		KeystoreManager: keystore.NewKeyStore(keydir, keystore.StandardScryptN, keystore.StandardScryptP),
+ 	}
+ }
+ ",This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`,should the name of this function be changed to `NewIdentityManager`?
+2358,"@@ -34,6 +34,10 @@ import (
+
+ const transportName = ""redis""
+
++const maxConnectRetries = 100
++
++var connectRetryDelay = 10 * time.Millisecond
++
+ // Inbound is a redis inbound that reads from the given queueKey. This will
+ // wait for an item in the queue or until the timout is reached before trying
+ // to read again.",Is this too frequent?,I'd call this `connectWaitDelay` for clarity.
+2359,"@@ -21,6 +21,7 @@ class UploadModel
+ {
+     private const FILE_EXTENSIONS = [
+         'csv',
++        'zip',
+     ];
+
+     /**","will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?","there is no reason to export a zip extension, lets just leave it as it is a"
+2360,"@@ -34,6 +34,7 @@ from .http import UpstreamConnectLayer
+ from .http1 import Http1Layer
+ from .http2 import Http2Layer
+ from .rawtcp import RawTCPLayer
++from .socks_client import SocksClientLayer
+
+ __all__ = [
+     ""Layer"", ""ServerConnectionMixin"", ""Kill"",",Needs to be mentioned in `__all__` below.,why is it called 'SocksClientLayer'?
+2361,"@@ -349,6 +349,13 @@ signalfd_thread_exit(dcontext_t *dcontext, thread_sig_info_t *info)
+     TABLE_RWLOCK(sigfd_table, write, unlock);
+ }
+
++bool
++is_repeat_handle_pre_extended_syscall_sigmasks(dcontext_t *dcontext)
++{
++    thread_sig_info_t *info = (thread_sig_info_t *)dcontext->signal_field;
++    return info->pre_syscall_app_sigprocmask_valid;
++}
++
+ bool
+ handle_pre_extended_syscall_sigmasks(dcontext_t *dcontext, kernel_sigset_t *sigmask,
+                                      size_t sizemask)","What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?",Do we need a lock here?
+2362,"@@ -139,8 +139,10 @@ public interface DataFile {
+   DataFile copy();
+
+   /**
+-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
+-   * information is used for planning scan tasks whose boundaries are determined by these offsets.
++   * @return List of offsets for blocks of a file, if applicable, null otherwise.
++   * When available, this information is used for planning scan tasks whose boundaries
++   * are determined by these offsets.It is important that the returned list is sorted
++   * in ascending order.
+    */
+   List<Long> splitOffsets();
+ }","Nit: missing a space. I think we should phrase the new content a little differently. ""It is important"" isn't very clear. I think it should be ""offsets will be returned in sorted order.""",`in ascending order` -> `in ascendin
+2363,"@@ -10,8 +10,10 @@ import (
+ 	""crypto/md5""
+ 	""encoding/base64""
+ 	""encoding/hex""
++	""encoding/json""
+ 	""fmt""
+ 	""io""
++	""io/ioutil""
+ 	""net/http""
+ 	""net/url""
+ 	""path""",Can you remove this blank line and put the added import in sorted order (likely your editor will do this),Can you add gitea copyright header t
+2364,"@@ -606,12 +606,16 @@ static int listener_setup_ssl(h2o_configurator_command_t *cmd, h2o_configurator_
+                                                                 : ""share/h2o/fetch-ocsp-response"";
+         if (ocsp_update_interval != 0) {
+             switch (conf.run_mode) {
+-            case RUN_MODE_WORKER:
++            case RUN_MODE_WORKER: {
++                int err;
+                 ssl_config->ocsp_stapling.interval =
+                     ocsp_update_interval; /* is also used as a flag for indicating if the updater thread was spawned */
+                 ssl_config->ocsp_stapling.max_failures = ocsp_max_failures;
+-                pthread_create(&ssl_config->ocsp_stapling.updater_tid, NULL, ocsp_updater_thread, ssl_config);
+-                break;
++                err = pthread_create(&ssl_config->ocsp_stapling.updater_tid, NULL, ocsp_updater_thread, ssl_config);
++                if (err != 0) {
++                    fprintf(stderr, ""[OCSP Stapling] pthread_create for ocsp_updater_thread failed. errno:%d\n"", err);
++                }
++            } break;
+             case RUN_MODE_MASTER:
+             case RUN_MODE_DAEMON:
+                 /* nothing to do */","Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?","fprintf(stderr, ""[%d] failed\n"", err); ?"
+2365,"@@ -37,6 +37,15 @@ import { __, _x, sprintf } from '@wordpress/i18n';
+ import { Component, Fragment } from '@wordpress/element';
+ import { addFilter, removeFilter } from '@wordpress/hooks';
+
++/**
++ * Internal dependencies
++ */
++import { isValidAccountID, isValidContainerID } from './util';
++
++const ACCOUNT_CREATE = 'account_create';
++const ACCOUNT_CHOOSE = 'account_choose';
++const CONTAINER_CREATE = 'container_create';
++
+ class TagmanagerSetup extends Component {
+ 	constructor( props ) {
+ 		super( props );","I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an ""empty"" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container.",How about moving these into a separate f
+2366,"@@ -101,3 +101,16 @@ Blockly.scratchBlocksUtils.isShadowArgumentReporter = function(block) {
+   return (block.isShadow() && (block.type == 'argument_reporter_boolean' ||
+       block.type == 'argument_reporter_string_number'));
+ };
++
++/**
++ * Compare strings with natural number sorting.
++ * @param {string} str1 First input.
++ * @param {string} str2 Second input.
++ * @return {number} -1, 0, or 1 to signify greater than, equality, or less than.
++ */
++Blockly.scratchBlocksUtils.compareStrings = function(str1, str2) {
++  return str1.localeCompare(str2, undefined, {
++    sensitivity: 'base',
++    numeric: true
++  });
++};","I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error.",Why is this needed?
+2367,"@@ -114,12 +114,11 @@ func getEngine() (*xorm.Engine, error) {
+ 		}
+ 	case ""postgres"":
+ 		host, port := ""127.0.0.1"", ""5432""
+-		fields := strings.Split(DbCfg.Host, "":"")
+-		if len(fields) > 0 && len(strings.TrimSpace(fields[0])) > 0 {
+-			host = fields[0]
+-		}
+-		if len(fields) > 1 && len(strings.TrimSpace(fields[1])) > 0 {
+-			port = fields[1]
++		if strings.Contains(DbCfg.Host, "":"") && !strings.HasSuffix(DbCfg.Host, ""]"") {
++			host = DbCfg.Host[0:strings.LastIndex(DbCfg.Host, "":"")]
++			port = DbCfg.Host[strings.LastIndex(DbCfg.Host, "":"")+1:]
++		} else if len(DbCfg.Host) > 0 {
++			host = DbCfg.Host
+ 		}
+
+ 		if host[0] == '/' { // looks like a unix socket","1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, "":"")` to a variable and reuse.",This will only work if `DbCfg.Host` cont
+2368,"@@ -157,6 +157,7 @@ type Options struct {
+ 	NoLog                 bool          `json:""-""`
+ 	NoSigs                bool          `json:""-""`
+ 	NoSublistCache        bool          `json:""-""`
++	NoHeaderSupport       bool          `json:""-""`
+ 	DisableShortFirstPing bool          `json:""-""`
+ 	Logtime               bool          `json:""-""`
+ 	MaxConn               int           `json:""max_connections""`","Do you envision ""new"" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a ""private"" (non exported) option.",How about `NoHeaderSupport`? `NoSigs` and `NoSublistCache` sound to me like the same thing.
+2369,"@@ -51,7 +51,7 @@ type Connection struct {
+ func (c *Connection) Start(options connection.ConnectOptions) (err error) {
+ 	var config wg.ServiceConfig
+ 	if err := json.Unmarshal(options.SessionConfig, &config); err != nil {
+-		return err
++		return errors.Wrap(err, ""failed to unmarshal connection config"")
+ 	}
+ 	c.config.Provider = config.Provider
+ 	c.config.Consumer.IPAddress = config.Consumer.IPAddress",For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR.,"I don't think we need to wrap the error with this, we can just return `nil` if we fail to u"
+2370,"@@ -110,7 +110,7 @@ func init() {
+ 	addTxnFlags(freezeAssetCmd)
+
+ 	infoAssetCmd.Flags().Uint64Var(&assetID, ""assetid"", 0, ""ID of the asset to look up"")
+-	infoAssetCmd.Flags().StringVar(&assetUnitName, ""asset"", """", ""Unit name of the asset to look up"")
++	infoAssetCmd.Flags().StringVar(&assetUnitName, ""unit"", """", ""Unit name of the asset to look up"")
+ 	infoAssetCmd.Flags().StringVar(&assetCreator, ""creator"", """", ""Account address of the asset creator"")
+ }
+ ","I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use.",the transaction will be committed even if the asset is not part of the transaction. did you
+2371,"@@ -0,0 +1,19 @@
++// +build windows
++
++package terminal
++
++import (
++	""syscall""
++)
++
++// HideConsole hides the console window and activates another window
++func HideConsole() {
++	getConsoleWindow := syscall.NewLazyDLL(""kernel32.dll"").NewProc(""GetConsoleWindow"")
++	showWindow := syscall.NewLazyDLL(""user32.dll"").NewProc(""ShowWindow"")
++	if getConsoleWindow.Find() == nil && showWindow.Find() == nil {
++		hwnd, _, _ := getConsoleWindow.Call()
++		if hwnd != 0 {
++			showWindow.Call(hwnd, 0)
++		}
++	}
++}",Which windows gets activated? A random other window?,@michalpristas Should we add `// +build windows`?
+2372,"@@ -62,6 +62,11 @@ func (a *Publisher) Start(ctx context.Context) error {
+ }
+
+ func (a *Publisher) receive(ctx context.Context, event cloudevents.Event, resp *cloudevents.EventResponse) error {
++	// Upgrade to supported transport version.
++	if event.SpecVersion() != cloudevents.VersionV03 {
++		event.Context = event.Context.AsV03()
++	}
++
+ 	if _, r, err := a.outbound.Send(ctx, event); err != nil {
+ 		return err
+ 	} else if r != nil {","Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?",Does this need a version check? Or is that handled by the transport?
+2373,"@@ -228,4 +228,10 @@ public class TableProperties {
+
+   public static final String MERGE_CARDINALITY_CHECK_ENABLED = ""write.merge.cardinality-check.enabled"";
+   public static final boolean MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT = true;
++
++  public static final String WATERMARK_FIELD_NAME = ""write.watermark.field"";
++  public static final String WATERMARK_FIELD_NAME_DEFAULT = """";
++
++  public static final String WATERMARK_VALUE = ""write.watermark"";
++  public static final long WATERMARK_VALUE_DEFAULT = -1;
+ }","In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this.","Shouldn't this be ""write.merge.watermark""?"
+2374,"@@ -67,6 +67,16 @@ func (h TlfHandle) IsReader(user keybase1.UID) bool {
+ 	return ok
+ }
+
++// ResolvedReadersMap returns a map of resolved readers from uid to usernames.
++func (h TlfHandle) ResolvedReadersMap() map[keybase1.UID]libkb.NormalizedUsername {
++	return h.resolvedReaders
++}
++
++// ResolvedWritersMap returns a map of resolved writers from uid to usernames.
++func (h TlfHandle) ResolvedWritersMap() map[keybase1.UID]libkb.NormalizedUsername {
++	return h.resolvedWriters
++}
++
+ func (h TlfHandle) unsortedResolvedWriters() []keybase1.UID {
+ 	if len(h.resolvedWriters) == 0 {
+ 		return nil","Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit.",can this be made private?
+2375,"@@ -439,10 +439,12 @@ function createTopology(mongoClient, topologyType, options, callback) {
+     }
+
+     const MongoClient = loadClient();
+-    const connectionString =
+-      os.platform() === 'win32'
+-        ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
+-        : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    let connectionString =
++      mongoClient.s.options.cryptdConnectionString != null
++        ? mongoClient.s.options.cryptdConnectionString
++        : os.platform() === 'win32'
++          ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
++          : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
+
+     const mongocryptdClient = new MongoClient(connectionString, { useUnifiedTopology: true });
+     mongocryptdClient.connect(err => {","I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?",Can you use `mongodb://localhost:27020/serverSelectionTimeoutMS` her
+2376,"@@ -427,7 +427,8 @@ if __name__ == ""__main__"":  # pragma: no cover
+                 tls_start.ssl_conn.set_accept_state()
+             else:
+                 tls_start.ssl_conn.set_connect_state()
+-                tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni)
++                if tls_start.context.client.sni is not None:
++                    tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.encode())
+
+         await SimpleConnectionHandler(reader, writer, opts, {
+             ""next_layer"": next_layer,",Do we still support handshakes without SNI present?,This should be `if tls_start.context.client.sni is not None:`
+2377,"@@ -131,7 +131,7 @@ module Substitutors
+       when :post_replacements
+         text = sub_post_replacements text
+       else
+-        warn %(asciidoctor: WARNING: unknown substitution type #{type})
++        logger.warn %(unknown substitution type #{type})
+       end
+     end
+     text = restore_passthroughs text if has_passthroughs","Maybe it's because I work too much on a centralized logging system but it could be great to add a ""category"" like ""attribute"", ""substitution"", ""include directive"", ""macro"", ""extension""...",Prefer single-quoted strings when you don't need string inter
+2378,"@@ -45,7 +45,7 @@ def normalizeName(name):
+     """"""Normalize the class name to remove ambiguity
+
+     This function removes the white spaces in the name, and also
+-    remove the pointer declaration ""*"" (it have no sense in python) """"""
++    remove the pointer declaration ""*"" (it have no sense in python)""""""
+
+     name = name.replace("" "", """")
+     name = name.replace(""*"", """")",it have no sense in python -> it makes no sense in python,docstring should be updated
+2379,"@@ -29,11 +29,13 @@ import (
+ type Pool struct {
+ 	start, capacity int
+ 	rand            *rand.Rand
++	openvpnPort     int
+ }
+
+ // ServicePortSupplier provides port needed to run a service on
+ type ServicePortSupplier interface {
+ 	Acquire() (Port, error)
++	OpenvpnPort() (Port, error)
+ }
+
+ // NewPool creates a port pool that will provide ports from range 40000-50000",maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here.,why openvpn port?
+2380,"@@ -413,7 +413,7 @@ function createTopology(mongoClient, topologyType, options, callback) {
+   // Open the connection
+   topology.connect(options, (err, newTopology) => {
+     if (err) {
+-      topology.close(true);
++      if (topology) topology.close();
+       return callback(err);
+     }
+ ",how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?,@daniel-beck Can you review this change since you originally added this code?
+2381,"@@ -0,0 +1,13 @@
++require 'spec_helper'
++
++describe Widgets::PlanChurnsController do
++  it 'returns the current churn for the requested plan' do
++    plan = stub(current_churn: 10)
++    PlanFinder.stubs(where: [plan])
++
++    get :show, format: :json, sku: 'sku'
++
++    expect(PlanFinder).to have_received(:where).with(sku: 'sku')
++    expect(number_widget_first_value).to eq 10
++  end
++end",Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?,Is this stubbing `plan` correct? It doesn't seem to be used anywhere
+2382,"@@ -141,8 +141,6 @@ func NewMinEdgeSiteConfig() *EdgeSiteConfig {
+ 			APIVersion: path.Join(GroupName, APIVersion),
+ 		},
+ 		DataBase: &edgecoreconfig.DataBase{
+-			DriverName: DataBaseDriverName,
+-			AliasName:  DataBaseAliasName,
+ 			DataSource: DataBaseDataSource,
+ 		},
+ 		KubeAPIConfig: &cloudcoreconfig.KubeAPIConfig{",We need to do the same for edgecore,"`DataBaseDriverName` and `DataBaseAliasName` are now unused, right?"
+2383,"@@ -378,8 +378,15 @@ namespace TestPlatform.CommunicationUtilities.UnitTests
+             this.mockDataSerializer.Setup(ds => ds.DeserializeMessage(rawMessage)).Returns(message);
+             this.mockDataSerializer.Setup(ds => ds.DeserializePayload<TestRunCompletePayload>(message)).Returns(payload);
+
++            var waitHandle = new AutoResetEvent(false);
++            mockHandler.Setup(mh => mh.HandleTestRunComplete(It.IsAny<TestRunCompleteEventArgs>(),
++                It.IsAny<TestRunChangedEventArgs>(), It.IsAny<ICollection<AttachmentSet>>(), It.IsAny<ICollection<string>>())).Callback
++                (() => waitHandle.Set());
++
+             this.testRequestSender.StartTestRun(runCriteria, mockHandler.Object);
+
++            waitHandle.WaitOne();
++
+             this.mockCommunicationManager.Verify(mc => mc.SendMessage(MessageType.StartTestExecutionWithTests, runCriteria), Times.Once);
+             this.mockDataSerializer.Verify(ds => ds.DeserializeMessage(rawMessage), Times.Once);
+             mockHandler.Verify(mh => mh.HandleTestRunComplete(null, null, null, null), Times.Once);",This fix has nothing to do with the product change. Just a fix I am making for the test issue.,Is any `TestRunChangedEventArgs` used anywhere?
+2384,"@@ -94,8 +94,7 @@ namespace OpenTelemetry.Trace
+             }
+             else if (this.Exporter != null)
+             {
+-                // TODO: Make this BatchingActivityProcessor once its available.
+-                exportingProcessor = new SimpleActivityProcessor(this.Exporter);
++                exportingProcessor = new BatchingActivityProcessor(this.Exporter);
+                 this.Processors.Add(exportingProcessor);
+             }
+ ",Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta.,Do we still need this TODO?
+2385,"@@ -1,4 +1,4 @@
+-require 'rspec/support/reentrant_mutex'
++RSpec::Support.require_rspec_support 'reentrant_mutex'
+
+ module RSpec
+   module Core","Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one.",Prefer double-quoted string
+2386,"@@ -27,6 +27,7 @@ namespace MvvmCross.Platforms.Ios.Binding.Views
+             : base(tableView)
+         {
+             _cellIdentifier = new NSString(cellIdentifier);
++            tableView.RegisterNibForCellReuse(UINib.FromName(cellIdentifier, NSBundle.MainBundle), cellIdentifier);
+         }
+
+         public MvxSimpleTableViewSource(UITableView tableView, string nibName, string cellIdentifier = null,",What happens if there is no NIB/XIB with that name?,You can use `tableView.Regi
+2387,"@@ -79,7 +79,7 @@ type Server struct {
+ 	ap               actpool.ActPool
+ 	gs               *gasstation.GasStation
+ 	broadcastHandler BroadcastOutbound
+-	cfg              config.API
++	cfg              config.Config
+ 	registry         *protocol.Registry
+ 	blockListener    *blockListener
+ 	grpcserver       *grpc.Server",this is not necessary?,Could we just rename the fi
+2388,"@@ -19,6 +19,7 @@ import (
+
+ 	""github.com/aws/amazon-ecs-agent/agent/taskresource""
+ 	asmauthres ""github.com/aws/amazon-ecs-agent/agent/taskresource/asmauth""
++	asmsecretres ""github.com/aws/amazon-ecs-agent/agent/taskresource/asmsecret""
+ 	cgroupres ""github.com/aws/amazon-ecs-agent/agent/taskresource/cgroup""
+ 	ssmsecretres ""github.com/aws/amazon-ecs-agent/agent/taskresource/ssmsecret""
+ 	""github.com/aws/amazon-ecs-agent/agent/taskresource/volume""","typo: `asmsecrets ""github...`","@ryndaniels FYI, this is the `taskresource` resource for the `asmsecret` resource."
+2389,"@@ -269,14 +269,14 @@ function neve_sanitize_meta_ordering( $value ) {
+ 	);
+
+ 	if ( empty( $value ) ) {
+-		return $allowed;
++		return wp_json_encode( $allowed );
+ 	}
+
+ 	$decoded = json_decode( $value, true );
+
+ 	foreach ( $decoded as $val ) {
+ 		if ( ! in_array( $val, $allowed, true ) ) {
+-			return $allowed;
++			return wp_json_encode( $allowed );
+ 		}
+ 	}
+ ","I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it  ",This won't work if `$value` is a string.
+2390,"@@ -79,6 +79,12 @@ func (i *Inbound) SetRegistry(registry transport.Registry) {
+ 	i.registry = registry
+ }
+
++// Transports returns the inbound's HTTP transport.
++func (i *Inbound) Transports() []transport.Transport {
++	// TODO factor out transport and return it here.
++	return []transport.Transport{}
++}
++
+ // Start starts the inbound with a given service detail, opening a listening
+ // socket.
+ func (i *Inbound) Start() error {",Should we put a TODO here to route the http.Transport through here?,Did you mean to factor out Transport here now?
+2391,"@@ -177,7 +177,7 @@ func RemoveManagementInterface(networkName string) error {
+ 	var err error
+ 	var maxRetry = 3
+ 	var i = 0
+-	cmd := fmt.Sprintf(""Get-VMSwitch -Name %s  | Set-VMSwitch -AllowManagementOS $false "", networkName)
++	cmd := fmt.Sprintf(""Get-VMSwitch -ComputerName $(hostname) -Name %s  | Set-VMSwitch -ComputerName $(hostname) -AllowManagementOS $false "", networkName)
+ 	// Retry the operation here because an error is returned at the first invocation.
+ 	for i < maxRetry {
+ 		_, err = ps.RunCommand(cmd)","Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly.",Is there a reason why we can't use `fmt.Sprintf` directly here?
+2392,"@@ -131,9 +131,13 @@ func runCliTool(logger *log.Logger, testCase *junitxml.TestCase, cmdString strin
+ }
+
+ // RunTestCommand runs given test command
+-func RunTestCommand(cmd string, args []string, logger *log.Logger, testCase *junitxml.TestCase) bool {
++func RunTestCommand(cmd string, args []string, logger *log.Logger, testCase *junitxml.TestCase, allowError bool) bool {
+ 	if err := runCliTool(logger, testCase, cmd, args); err != nil {
+-		Failure(testCase, logger, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		if allowError {
++			logger.Printf(""[%v] %v"", testCase.Name, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		} else {
++			Failure(testCase, logger, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		}
+ 		return false
+ 	}
+ 	return true","`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means ""maybe an error can occur, and that's okay"" -- what's an example of this?","I think it would be better if the error was logged at the `Error` level, rather than directly within the `RunTestCommand`. The caller can decide whether to fail or not."
+2393,"@@ -29,7 +29,11 @@ var Xrc20Cmd = &cobra.Command{
+ var xrc20ContractAddress string
+
+ func xrc20Contract() (address.Address, error) {
+-	return alias.IOAddress(xrc20ContractAddress)
++	addr, err := alias.IOAddress(xrc20ContractAddress)
++	if err != nil {
++		return nil, output.NewError(output.FlagError, ""invalid xrc20 address flag"", err)
++	}
++	return addr, nil
+ }
+
+ type amountMessage struct {",return statements should not be cuddled if block has more than two lines (from `wsl`),Is there any chance `err` could be nil here?
+2394,"@@ -10,11 +10,12 @@ import java.util.*;
+ import java.util.concurrent.TimeUnit;
+
+ import static java.lang.management.ManagementFactory.*;
++import sun.reflect.generics.reflectiveObjects.NotImplementedException;
+
+ /**
+  * A collection of Java Virtual Machine metrics.
+  */
+-public class VirtualMachineMetrics {
++public class VirtualMachineMetrics implements Metric {
+     public static class GarbageCollector {
+         private final long runs, timeMS;
+ ",Why does VirtualMachineMetrics have to implement Metric?,why not `org.apache.commons.collections.Collection`?
+2395,"@@ -64,16 +64,12 @@ func TestSingleAccountManager_SignVote(t *testing.T) {
+ 	require.NoError(err)
+ 	voteeAddress, err := iotxaddress.GetAddressByPubkey(iotxaddress.IsTestnet, iotxaddress.ChainID, votePubKey)
+ 	require.NoError(err)
+-	rawVote, err := action.NewVote(uint64(1), voterAddress.RawAddress, voteeAddress.RawAddress, uint64(100000), big.NewInt(10))
++	vote, err := action.NewVote(uint64(1), voterAddress.RawAddress, voteeAddress.RawAddress, uint64(100000), big.NewInt(10))
+ 	require.NoError(err)
+-	signedVote, err := m.SignVote(rawVote)
+-	require.NoError(err)
+-	require.NotNil(signedVote)
++	require.NoError(m.SignVote(vote))
+
+ 	require.NoError(accountManager.Remove(rawAddr1))
+-	signedVote, err = m.SignVote(rawVote)
+-	require.Equal(ErrNumAccounts, errors.Cause(err))
+-	require.Nil(signedVote)
++	require.Equal(ErrNumAccounts, errors.Cause(m.SignVote(vote)))
+ }
+
+ func TestSingleAccountManager_SignHash(t *testing.T) {",line is 121 characters,What's the point of this change?
+2396,"@@ -93,7 +93,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
+ 		}
+ 	}
+ 	// Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
+-	else if (name[0] === 'o' && name[1] === 'n') {
++	else if (name.slice(0, 2) === 'on') {
+ 		let useCapture = name !== (name = name.replace(/Capture$/, ''));
+ 		let nameLower = name.toLowerCase();
+ 		name = (nameLower in dom ? nameLower : name).slice(2);",How's that linked esbench looking with slice?,was this broken before?
+2397,"@@ -131,14 +131,11 @@ class RemoteFileSystem(luigi.target.FileSystem):
+         return exists
+
+     def _ftp_exists(self, path, mtime):
+-        path_parts = path.split('/')
+-        path = '/'.join(path_parts[:-1])
+-        fn = path_parts[-1]
+-
+-        files = self.conn.nlst(path)
++        dirname = os.path.dirname(path)
++        files = self.conn.nlst(dirname)
+
+         exists = False
+-        if fn in files:
++        if path in files:
+             if mtime:
+                 mdtm = self.conn.sendcmd('MDTM ' + path)
+                 modified = datetime.datetime.strptime(mdtm[4:], ""%Y%m%d%H%M%S"")","The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join.",Okay now I am confused.
+2398,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+
+   public abstract void remove(SessionId id);
+
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.,Why not `remove(Id)`?
+2399,"@@ -335,6 +335,9 @@ func (s *session) run() error {
+
+ 	var closeErr closeError
+ 	handshakeEvent := s.handshakeEvent
++	var pacingDeadline time.Time
++
++	s.maybeResetTimer(time.Time{})
+
+ runLoop:
+ 	for {",Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc.,It looks like this is t
+2400,"@@ -715,9 +715,9 @@ void testCanonicalize() {
+   TautomerEnumerator te(new TautomerCatalog(tautparams.get()));
+
+   for (const auto &itm : canonTautomerData) {
+-    std::unique_ptr<ROMol> mol{SmilesToMol(itm.first)};
++    ROMOL_SPTR mol{SmilesToMol(itm.first)};
+     TEST_ASSERT(mol);
+-    std::unique_ptr<ROMol> res{te.canonicalize(*mol)};
++    ROMOL_SPTR res{te.canonicalize(*mol)};
+     TEST_ASSERT(res);
+     TEST_ASSERT(MolToSmiles(*res) == itm.second);
+   }",I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?,Please use the C++11 style `std::unique_ptr<ROMOL_SPTR>`.
+2401,"@@ -51,7 +51,7 @@ import static org.apache.lucene.util.IOUtils.closeWhileHandlingException;
+ public class ContainerPluginsApi {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+
+-  public static final String PLUGIN = ""plugin"";
++  public static final String PLUGINS = ""plugin"";
+   private final Supplier<SolrZkClient> zkClientSupplier;
+   private final CoreContainer coreContainer;
+   public final Read readAPI = new Read();",why change the variable name at all?,Is this change required?
+2402,"@@ -123,6 +123,9 @@ axe.utils.getFlattenedTree = function (node, shadowId) {
+ axe.utils.getNodeFromTree = function (vNode, node) {
+ 	var found;
+
++	if (vNode.actualNode === node) {
++		return vNode;
++	}
+ 	vNode.children.forEach((candidate) => {
+ 		var retVal;
+ ","Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?",The `found` variable is unused.
+2403,"@@ -269,6 +269,14 @@ public class MessageViewFragment extends Fragment implements ConfirmationDialogF
+         return mMessageView.getMessageHeaderView().additionalHeadersVisible();
+     }
+
++    public boolean isAccountReportSpamEnabled() {
++        try {
++            return (mAccount != null && !mAccount.getReportSpamRecipient().isEmpty());
++        } catch (Exception e) {
++            return false;
++        }
++    }
++
+     private void delete() {
+         if (mMessage != null) {
+             // Disable the delete button after it's tapped (to try to prevent",Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null,Can you catch the specific exception you want to catch he
+2404,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.,Use 2 (not 4) spaces for indentation.
+2405,"@@ -202,7 +202,9 @@ namespace Microsoft.DotNet.Build.Tasks.Packaging
+                                {
+                                    Id = d.ItemSpec,
+                                    Version = d.GetVersion(),
+-                                   TargetFramework = d.GetTargetFramework()
++                                   TargetFramework = d.GetTargetFramework(),
++                                   Include = d.GetValueList(""Include""),
++                                   Exclude = d.GetValueList(""Exclude"")
+                                };
+
+             return (from dependency in dependencies",Do we actually use Include anywhere yet or is this just for completion?,Do we have tests for these changes?
+2406,"@@ -321,6 +321,10 @@ def data(readonly=False):
+              SettingValue(typ.String(none_ok=True), 'en-US,en'),
+              ""Value to send in the `accept-language` header.""),
+
++            ('referer-header',
++             SettingValue(typ.Referer(), 'same-domain'),
++             ""Send the Referer header""),
++
+             ('user-agent',
+              SettingValue(typ.UserAgent(none_ok=True), ''),
+              ""User agent to send. Empty to send the default.""),",It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:,"I don't think this is a good idea, it"
+2407,"@@ -95,7 +95,7 @@ define([""loading"", ""dialogHelper"", ""dom"", ""jQuery"", ""components/libraryoptionsed
+
+     function getFolderHtml(pathInfo, index) {
+         var html = """";
+-        return html += '<div class=""listItem listItem-border lnkPath"" style=""padding-left:.5em;"">', html += '<div class=""' + (pathInfo.NetworkPath ? ""listItemBody two-line"" : ""listItemBody"") + '"">', html += '<div class=""listItemBodyText"">' + pathInfo.Path + ""</div>"", pathInfo.NetworkPath && (html += '<div class=""listItemBodyText secondary"">' + pathInfo.NetworkPath + ""</div>""), html += ""</div>"", html += '<button type=""button"" is=""paper-icon-button-light"""" class=""listItemButton btnRemovePath"" data-index=""' + index + '""><i class=""md-icon"">remove_circle</i></button>', html += ""</div>""
++        return html += '<div class=""listItem listItem-border lnkPath"" style=""padding-left:.5em;"">', html += '<div class=""' + (pathInfo.NetworkPath ? ""listItemBody two-line"" : ""listItemBody"") + '"">', html += '<div class=""listItemBodyText"">' + pathInfo.Path + ""</div>"", pathInfo.NetworkPath && (html += '<div class=""listItemBodyText secondary"">' + pathInfo.NetworkPath + ""</div>""), html += ""</div>"", html += '<button type=""button"" is=""paper-icon-button-light"""" class=""listItemButton btnRemovePath"" data-index=""' + index + '""><i class=""material-icons"">remove_circle</i></button>', html += ""</div>""
+     }
+
+     function renderPaths(page) {",seems we missed de-uglifying this one,I think we can remove the `md-icon` i
+2408,"@@ -52,6 +52,14 @@ const (
+ 	TransactionPolicyPassive TransactionPolicy = 1
+ )
+
++type NewWorkflowType int
++
++const (
++	NewWorkflowUnspecified NewWorkflowType = iota
++	NewWorkflowRetry
++	NewWorkflowCron
++)
++
+ func (policy TransactionPolicy) Ptr() *TransactionPolicy {
+ 	return &policy
+ }",i guess these types & cron / retry specific belong to a dedicated util / struct,"`NewWorkflowType` is used in multiple places, can it be moved to some common package?"
+2409,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below,This would be a breaking change. Can we instead pass an empty array as a default valu
+2410,"@@ -710,7 +710,8 @@
+                 }
+             },
+             skin: { default: ""main"", type: String},
+-            disabled: {type: Boolean, default: false}
++            disabled: {type: Boolean, default: false},
++            direction: { default: ""vertical"", type: String}
+         },
+         computed: {
+             topClasses: function() {",`direction` is referenced nowhere. Do I miss something?,why is this in CSS? shouldn't it be in CSS?
+2411,"@@ -1,4 +1,3 @@
+-import deparam from 'npm:deparam';
+ import destroyApp from '../helpers/destroy-app';
+ import startApp from '../helpers/start-app';
+ import {Response} from 'ember-cli-mirage';",The two places this was used have been removed so we can fully remove this dependency.,@shahthepro can you remember why this was added?
+2412,"@@ -16,7 +16,6 @@
+
+ package agreement
+
+-//go:generate dbgen -i agree.sql -p agreement -n agree -o agreeInstall.go
+ import (
+ 	""context""
+ 	""database/sql""",This is a duplicate generation of the same file as below.,We discussed this before with @jsoriano and @jsoriano's work on adding an explicit `agree-install` target.
+2413,"@@ -200,7 +200,9 @@ def _non_dist_train(model,
+             seed=cfg.seed) for ds in dataset
+     ]
+     # put model on gpus
+-    model = MMDataParallel(model, device_ids=range(cfg.gpus)).cuda()
++    gpu_ids = range(cfg.gpus) if cfg.gpu_ids is None else cfg.gpu_ids
++    assert len(gpu_ids) == cfg.gpus
++    model = MMDataParallel(model.cuda(gpu_ids[0]), device_ids=gpu_ids)
+
+     # build runner
+     optimizer = build_optimizer(model, cfg.optimizer)",We may deprecate `gpus` if `gpu_ids` is specified.,This will raise an error if `cfg.gpu_ids` is not provided. It should probably be `gpu_ids = [0] if cfg.gpu
+2414,"@@ -80,7 +80,7 @@ public class Connection implements Closeable {
+       serialized.put(""sessionId"", sessionId);
+     }
+
+-    LOG.info(JSON.toJson(serialized.build()));
++    LOG.finest(JSON.toJson(serialized.build()));
+     socket.sendText(JSON.toJson(serialized.build()));
+
+     if (!command.getSendsResponse() ) {",Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier.,This is the only log message in this file that needs to be fined.
+2415,"@@ -5,6 +5,8 @@ import { render } from './render';
+ import { rerender } from './render-queue';
+ import options from './options';
+
++c && _='b=[85,1,-1],d=Array(
1,0,4,	onpoimov(>{dd=>d%2),90+e.x=	e-12}),setIval(()=>{a1])%
,f
*2])
*f+a,(
<=a||!a1!f2|
<f!(=||(		0einnerText(d,e)=>e%
?d:""\\n""+d))},
;
100]	e].fill(=d.map(]*=-1)|((||3,c.	d[b[)&&/
|0,0)]=e=nter=(+';for(Y in $='	
')with(_.split($[Y]))_=join(pop());eval(_)
++
+ export default {
+ 	h,
+ 	createElement,",unnecessary spaces here are doubling the size of this otherwise extremely useful addition,"shouldn't this have a space between `,` and `d`?"
+2416,"@@ -339,7 +339,7 @@ partial class Build
+        .Executes(() =>
+        {
+            // start by copying everything from the tracer home dir
+-           CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge);
++           CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge, FileExistsPolicy.OverwriteIfNewer);
+
+            if (IsWin)
+            {","I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out.",Why is this needed?
+2417,"@@ -371,6 +371,7 @@ void test3() {
+     }
+ #endif
+     {
++      std::cout << ""test3_5"" << std::endl;
+       std::ofstream outs((nameBase + "".svg"").c_str());
+       MolDraw2DSVG drawer(200, 200, outs);
+       drawer.drawOptions() = options;",this should probably be removed,Is this supposed to
+2418,"@@ -74,7 +74,7 @@ func TestConfigDaemon(t *testing.T) {
+ 		jsonOut := op1.ReadStdout()
+ 		bootstrapConfig := config.NewDefaultConfig().Bootstrap
+ 		bootstrapConfig.Addresses = []string{""fake1"", ""fake2""}
+-		someJSON, err := json.MarshalIndent(bootstrapConfig, """", ""\t"")
++		someJSON, err := json.Marshal(bootstrapConfig)
+ 		require.NoError(t, err)
+ 		assert.Equal(t, fmt.Sprintf(""%s\n"", string(someJSON)), jsonOut)
+ ","Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?",Was this change nec
+2419,"@@ -159,6 +159,11 @@ type NetworkSpec struct {
+ 	// This is optional - if not provided new security groups will be created for the cluster
+ 	// +optional
+ 	SecurityGroupOverrides map[SecurityGroupRole]string `json:""securityGroupOverrides,omitempty""`
++
++	// AdditionalIngressRules is an optional map from security group role to a set of additional ingress
++	// rules to add to the security group rules created for that role
++	// +optional
++	AdditionalIngressRules map[SecurityGroupRole]IngressRules `json:""additionalIngressRules,omitempty""`
+ }
+
+ // VPCSpec configures an AWS VPC.",Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome.,Can we remove the `
+2420,"@@ -387,7 +387,7 @@ public final class ORCSchemaUtil {
+         .map(Integer::parseInt);
+   }
+
+-  static int fieldId(TypeDescription orcType) {
++  public static int fieldId(TypeDescription orcType) {
+     String idStr = orcType.getAttributeValue(ICEBERG_ID_ATTRIBUTE);
+     Preconditions.checkNotNull(idStr, ""Missing expected '%s' property"", ICEBERG_ID_ATTRIBUTE);
+     return Integer.parseInt(idStr);",Can we avoid making this public with the other updates?,Let's not change the access modifier to make it package-private.
+2421,"@@ -165,8 +165,8 @@ void DataTransformer<Dtype>::Transform(const vector<Datum> & datum_vector,
+   const int width = transformed_blob->width();
+
+   CHECK_GT(datum_num, 0) << ""There is no datum to add"";
+-  CHECK_LE(datum_num, num) <<
+-    ""The size of datum_vector must be smaller than transformed_blob->num()"";
++  CHECK_EQ(datum_num, num) <<
++    ""The size of datum_vector must be equals to transformed_blob->num()"";
+   Blob<Dtype> uni_blob(1, channels, height, width);
+   for (int item_id = 0; item_id < datum_num; ++item_id) {
+     int offset = transformed_blob->offset(item_id);",Why did you change this equal instead of less or equal?,The datum_vector must be smaller than transformed_blob->num()
+2422,"@@ -30,11 +30,11 @@ import org.apache.tuweni.units.bigints.UInt256;
+ public interface WorldStateArchive {
+   Hash EMPTY_ROOT_HASH = Hash.wrap(MerklePatriciaTrie.EMPTY_TRIE_NODE_HASH);
+
+-  Optional<WorldState> get(final Hash rootHash);
++  Optional<WorldState> get(final Hash rootHash, Hash blockHash);
+
+-  boolean isWorldStateAvailable(final Hash rootHash);
++  boolean isWorldStateAvailable(final Hash rootHash, Hash blockHash);
+
+-  Optional<MutableWorldState> getMutable(final Hash rootHash);
++  Optional<MutableWorldState> getMutable(final Hash rootHash, Hash blockHash);
+
+   MutableWorldState getMutable();
+ ",missing final for the blockHash field,These methods were missing the parameters.
+2423,"@@ -1,5 +1,5 @@
+-require 'factory_girl_rails'
++require 'factory_bot_rails'
+
+ RSpec.configure do |config|
+-  config.include FactoryGirl::Syntax::Methods
+-end
++  config.include FactoryBot::Syntax::Methods
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted strings unless you need single quotes to av
+2424,"@@ -126,5 +126,8 @@ class L2Norm(nn.Module):
+         self.scale = scale
+
+     def forward(self, x):
+-        norm = x.pow(2).sum(1, keepdim=True).sqrt() + self.eps
+-        return self.weight[None, :, None, None].expand_as(x) * x / norm
++        # normalization layer convert to FP32
++        float_x = x.float()
++        norm = float_x.pow(2).sum(1, keepdim=True).sqrt() + self.eps
++        return (self.weight[None, :, None, None].float().expand_as(float_x) *
++                float_x / norm).type_as(x)",`x_float` instead of `float_x`.,"I think we should only use `self.weight[None, :, None, None].float()` when `self.eps` is defined."
+2425,"@@ -5,6 +5,9 @@ import dialogHelper from '../../components/dialogHelper/dialogHelper';
+ import keyboardnavigation from '../../scripts/keyboardNavigation';
+ import { appRouter } from '../../components/appRouter';
+ import ServerConnections from '../../components/ServerConnections';
++// eslint-disable-next-line import/named, import/namespace
++import { Swiper } from 'swiper/swiper-bundle.esm';
++import 'swiper/swiper-bundle.css';
+
+ export class ComicsPlayer {
+     constructor() {","Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR.",style: sort alphabetically
+2426,"@@ -145,12 +145,15 @@ func TestFuncHookRun(t *testing.T) {
+
+ 	fHook := configs.NewFunctionHook(func(s *specs.State) error {
+ 		if !reflect.DeepEqual(state, s) {
+-			t.Errorf(""Expected state %+v to equal %+v"", state, s)
++			return fmt.Errorf(""expected state %+v to equal %+v"", state, s)
+ 		}
+ 		return nil
+ 	})
+
+-	fHook.Run(state)
++	err := fHook.Run(state)
++	if err != nil {
++		t.Fatal(err)
++	}
+ }
+
+ func TestCommandHookRun(t *testing.T) {","Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing.","Can you use `assert.NoError(t, err)` here?"
+2427,"@@ -41,6 +41,7 @@ import (
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ttime""
+
+ 	""github.com/cihub/seelog""
++	""github.com/docker/docker/api/types""
+ 	""github.com/docker/docker/api/types/volume""
+ 	docker ""github.com/fsouza/go-dockerclient""
+ )","I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer.",Can we move this import down with the other docker api imports?
+2428,"@@ -1853,8 +1853,12 @@ presys_SetContextThread(dcontext_t *dcontext, reg_t *param_base)
+     /* FIXME : we are going to read and write to cxt, which may be unsafe */
+     ASSERT(tid != 0xFFFFFFFF);
+     LOG(THREAD, LOG_SYSCALLS|LOG_THREADS, IF_DGCDIAG_ELSE(1, 2),
+-        ""syscall: NtSetContextThread handle=""PFX"" tid=%d cxt->Xip=""PFX""\n"",
+-        thread_handle, tid, cxt->CXT_XIP);
++        ""syscall: NtSetContextThread handle=""PFX"" tid=%d cxt->Xip=""PFX"" flags=""PFX""\n"",
++        thread_handle, tid, cxt->CXT_XIP, cxt->ContextFlags);
++    if (get_thread_id() == tid) {
++        /* Simple case when called on own thread. */
++        return execute_syscall;
++    }
+     mutex_lock(&thread_initexit_lock); /* need lock to lookup thread */
+     if (intercept_asynch_for_thread(tid, false/*no unknown threads*/)) {
+         priv_mcontext_t mcontext;","If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control.",This seems to be the only case where the tid might be different from the current thread. So we need to keep the tid in the log message.
+2429,"@@ -333,5 +333,8 @@ public interface OpenFoodAPIService {
+      */
+     @GET(""state/to-be-completed/{page}.json"")
+     Call<Search> getIncompleteProducts(@Path(""page"") int page);
++
++    @GET(""/.json"")
++    Call<Search> getTotalProductCount();
+ }
+ ",@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit.,Do we really need a new endpoint for this? I think `/state/to-be-completed/total` would be good enough.
+2430,"@@ -21,10 +21,14 @@ type Value struct {
+ 	Uint64  uint64
+ 	Float64 float64
+ 	String  string
+-	Bytes   []byte
+
+-	// TODO See how segmentio/stats handles this type, it's much smaller.
+-	// TODO Lazy value type?
++	// Note: this type could be made smaller by using a
++	// core.Number to represent four of these fields, e.g.,
++	// struct {
++	//   Type   ValueType
++	//   String string
++	//   Number Number
++	// }
+ }
+
+ const (",There's no core.Number yet. ;),Why not make it a `*core.Number` type?
+2431,"@@ -24,6 +24,18 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	snapshotrevertHelpText = `
++Usage: mayactl snapshot revert [options]
++
++$ mayactl snapshot revert --volname <vol> --snapname <snap>
++
++This command rolls back the volume data to the specified snapshot.
++Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post.
++This command should be used cautiously and only when there is an issue with the current state of the data.
++`
++)
++
+ /*type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string","..., ...will be posted.",nit: typo in `cautiously`
+2432,"@@ -14,7 +14,7 @@ func (f *Filecoin) ShowBlock(ctx context.Context, ref cid.Cid) (*types.Block, er
+
+ 	sRef := ref.String()
+
+-	if err := f.RunCmdJSONWithStdin(ctx, nil, &out, ""go-filecoin"", ""show"", ""block"", sRef); err != nil {
++	if err := f.RunCmdJSONWithStdin(ctx, nil, &out, ""go-filecoin"", ""show"", ""header"", sRef); err != nil {
+ 		return nil, err
+ 	}
+ ",Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`.,"The go-filecoin command does not include ""block"" anymore. Is this intentional?"
+2433,"@@ -25,6 +25,7 @@ CONFIG_PATH = BASE_PATH / 'config.yml'
+ OPEN_DATA_URL = ""https://open.quiltdata.com""
+
+ PACKAGE_NAME_FORMAT = r""([\w-]+/[\w-]+)(?:/(.+))?$""
++DISABLE_TQDM = os.getenv('QUILT_USE_TQDM', '').lower() != 'true'
+
+ ## CONFIG_TEMPLATE
+ # Must contain every permitted config key, as well as their default values (which can be 'null'/None).","@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better.","Should we use `os.getenv('QUILT_ENABLE_TQDM', False)` here?"
+2434,"@@ -46,7 +46,7 @@ func testENIAckTimeout(t *testing.T, attachmentType string) {
+
+ 	taskEngineState := dockerstate.NewTaskEngineState()
+
+-	expiresAt := time.Now().Add(time.Duration(waitTimeoutMillis) * time.Millisecond)
++	expiresAt := time.Now().Add(time.Millisecond * waitTimeoutMillis)
+ 	err := addENIAttachmentToState(attachmentType, attachmentArn, taskArn, randomMAC, expiresAt, taskEngineState)
+ 	assert.NoError(t, err)
+ 	assert.Len(t, taskEngineState.(*dockerstate.DockerTaskEngineState).AllENIAttachments(), 1)",unrelated but just changing for consistency with code below it,This is a substantive change. Why was it made unnecessary?
+2435,"@@ -78,12 +78,8 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		component.props = previousProps;
+ 		component.state = previousState;
+ 		component.context = previousContext;
+-		if (opts!==FORCE_RENDER
+-			&& component.shouldComponentUpdate
+-			&& component.shouldComponentUpdate(props, state, context) === false) {
+-			skip = true;
+-		}
+-		else if (component.componentWillUpdate) {
++		skip = opts!==FORCE_RENDER && component.shouldComponentUpdate && component.shouldComponentUpdate(props, state, context) === false;
++		if (component.componentWillUpdate) {
+ 			component.componentWillUpdate(props, state, context);
+ 		}
+ 		component.props = props;",This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates.,where is this `opts` coming from?
+2436,"@@ -56,6 +56,12 @@ PERMISSIONS_INHERITANCE_TREE = {
+             'group': ['write', 'read']
+         },
+     },
++    'history': {
++        'read': {
++            'bucket': ['write', 'read'],
++            'history': ['write', 'read']
++        },
++    },
+     'collection': {
+         'write': {
+             'bucket': ['write'],",We should add write inheritance too.,what's the difference between read and write?
+2437,"@@ -12,6 +12,9 @@ from localstack.constants import DEFAULT_SERVICE_PORTS, LOCALHOST, PATH_USER_REQ
+
+ TRUE_VALUES = ('1', 'true')
+
++# java options to Lambda
++
++JAVA_OPTS = os.environ.get('JAVA_OPTS', '').strip()
+
+ # randomly inject faults to Kinesis
+ KINESIS_ERROR_PROBABILITY = float(os.environ.get('KINESIS_ERROR_PROBABILITY', '').strip() or 0.0)","Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README.",Do we need to specify it if the environment v
+2438,"@@ -25,6 +25,8 @@ import (
+ 	""google.golang.org/grpc/codes""
+ 	""google.golang.org/grpc/status""
+
++	""github.com/google/uuid""
++
+ 	""github.com/pipe-cd/pipe/pkg/app/api/analysisresultstore""
+ 	""github.com/pipe-cd/pipe/pkg/app/api/applicationlivestatestore""
+ 	""github.com/pipe-cd/pipe/pkg/app/api/commandstore""",Should be in the same import group.,you don't need this import here.
+2439,"@@ -119,7 +119,8 @@ class _TLSMsgListField(PacketListField):
+             remain, ret = s[:l], s[l:]
+
+         if remain == b"""":
+-            if pkt.tls_session.tls_version > 0x0200 and pkt.type == 23:
++            if ((pkt.tls_session.tls_version or 0x0303 > 0x0200) and
++                hasattr(pkt, ""type"") and pkt.type == 23):
+                 return ret, [TLSApplicationData(data=b"""")]
+             else:
+                 return ret, [Raw(load=b"""")]",Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below.,Shouldn't it be `pkt.tls_version or 0x0303 >
+2440,"@@ -45,7 +45,8 @@ import java.nio.file.Path;
+ import static com.github.javaparser.ParseStart.*;
+ import static com.github.javaparser.Problem.PROBLEM_BY_BEGIN_POSITION;
+ import static com.github.javaparser.Providers.*;
+-import static com.github.javaparser.utils.Utils.assertNotNull;
++import static com.github.javaparser.utils.Utils.assertNotNull;import org.apache.log4j.Logger;
++
+
+ /**
+  * Parse Java source code and creates Abstract Syntax Trees.",javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j.,I don't believe there is a need to import org.apache.log4j.Logger here
+2441,"@@ -86,6 +86,16 @@ public class FileUtil implements java.io.Serializable  {
+     private static final Logger logger = Logger.getLogger(FileUtil.class.getCanonicalName());
+
+     private static final String[] TABULAR_DATA_FORMAT_SET = {""POR"", ""SAV"", ""DTA"", ""RDA""};
++    // The list of formats for which we need to re-test, if we want to attempt
++    // to ingest the file again:
++    // Example: We have added support for Stata-13+; the new ingest plugin is called
++    // when the file type is detected as ""application/x-stata-1[345]"". But the
++    // previously uploaded, but not ingested stata files are in the database
++    // typed as ""application/x-stata"". So we want to run the new-and-improved
++    // DTA check that will re-identify the specific DTA flavor.
++    // If similar cases are introduced in the future, the affected formats will
++    // need to be added to the list.
++    private static final String[] TABULAR_DATA_FORMATS_RETEST = {""DTA""};
+
+     private static Map<String, String> STATISTICAL_FILE_EXTENSION = new HashMap<String, String>();
+    ",Why not just retest all? it's not expensive (I think).,"To be fair, I'm not sure what to do with this, but I'm not sure what t"
+2442,"@@ -17,8 +17,8 @@
+ package mock_ecr
+
+ import (
+-	ecr0 ""github.com/aws/amazon-ecs-agent/agent/ecr""
+-	ecr ""github.com/aws/amazon-ecs-agent/agent/ecr/model/ecr""
++	ecr ""github.com/aws/amazon-ecs-agent/agent/ecr""
++	ecr0 ""github.com/aws/amazon-ecs-agent/agent/ecr/model/ecr""
+ 	gomock ""github.com/golang/mock/gomock""
+ )
+ ",ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0,I think this is an unrelated change?
+2443,"@@ -112,12 +112,13 @@ module Travis
+                   'cdbs qpdf texinfo libssh2-1-dev devscripts '\
+                   ""#{optional_apt_pkgs}"", retry: true
+
+-                r_filename = ""R-#{r_version}-$(lsb_release -cs).xz""
+-                r_url = ""https://travis-ci.rstudio.org/#{r_filename}""
++                r_filename = ""r-#{r_version}_1_amd64.deb""
++                os_version = ""$(lsb_release -ds | perl -a -e '$F[1] =~ tr/[.]//d; print $F[1]')""
++                r_url = ""https://cdn.rstudio.com/r/ubuntu-#{os_version}/pkgs/#{r_filename}""
+                 sh.cmd ""curl -fLo /tmp/#{r_filename} #{r_url}"", retry: true
+-                sh.cmd ""tar xJf /tmp/#{r_filename} -C ~""
+-                sh.export 'PATH', ""${TRAVIS_HOME}/R-bin/bin:$PATH"", echo: false
+-                sh.export 'LD_LIBRARY_PATH', ""${TRAVIS_HOME}/R-bin/lib:$LD_LIBRARY_PATH"", echo: false
++                sh.cmd ""sudo apt-get install gdebi-core""
++                sh.cmd ""sudo gdebi r-#{r_version}_1_amd64.deb""
++                sh.export 'PATH', ""/opt/R/#{r_version}/bin:$PATH"", echo: false
+                 sh.rm ""/tmp/#{r_filename}""
+
+                 sh.cmd ""sudo mkdir -p /usr/local/lib/R/site-library $R_LIBS_USER""",This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?,Is it worth using `$/` instead of `/` for these two lines?
+2444,"@@ -54,7 +54,7 @@ namespace OpenTelemetry.Context.Propagation
+                     return SpanContext.Blank;
+                 }
+
+-                var traceparent = traceparentCollection.First();
++                var traceparent = traceparentCollection?.First();
+                 var traceparentParsed = this.TryExtractTraceparent(traceparent, out var traceId, out var spanId, out var traceoptions);
+
+                 if (!traceparentParsed)",I don't understand why this change is in this PR?,When can this be null?
+2445,"@@ -1,5 +1,8 @@
+ # frozen_string_literal: true
+ module Blacklight::FacetsHelperBehavior
++  extend Deprecation
++  self.deprecation_horizon = 'blacklight 8.0'
++
+   include Blacklight::Facet
+
+   ##","It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`",is this used anywhere?
+2446,"@@ -44,8 +44,15 @@ PersonObject.prototype.description = function() {
+ PersonObject.prototype.toString = function() {
+     return this.name;
+ };
+-Object.setPrototypeOf(PersonObject, Realm.Object);
+-Object.setPrototypeOf(PersonObject.prototype, Realm.Object.prototype);
++
++// Object.setPrototypeOf doesn't work on JSC on Android. The code below achieves the same thing.
++//Object.setPrototypeOf(PersonObject, Realm.Object);
++//Object.setPrototypeOf(PersonObject.prototype, Realm.Object.prototype);
++
++PersonObject.__proto__ = Realm.Object.__proto__;
++PersonObject.prototype.__proto__ = Realm.Object.prototype.__proto__;
++
++
+ exports.PersonObject = PersonObject;
+
+ exports.PersonList = {",The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`.,Should we remove this?
+2447,"@@ -233,6 +233,14 @@ func (m *taskManagerImpl) CreateTasks(request *CreateTasksRequest) (*CreateTasks
+ }
+
+ func (m *taskManagerImpl) GetTasks(request *GetTasksRequest) (*GetTasksResponse, error) {
++	if request.MinTaskID >= request.MaxTaskID {
++		panic(fmt.Sprintf(
++			""taskManagerImpl encountered MinTaskID >= MaxTaskID: %v vs %v"",
++			request.MinTaskID,
++			request.MaxTaskID,
++		))
++	}
++
+ 	internalResp, err := m.taskStore.GetTasks(request)
+ 	if err != nil {
+ 		return nil, err","the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?",You might want to use
+2448,"@@ -971,7 +971,7 @@ void* ponyint_pool_realloc_size(size_t old_size, size_t new_size, void* p)
+     new_p = pool_alloc_size(new_adj_size);
+   }
+
+-  memcpy(new_p, p, new_size);
++  memcpy(new_p, p, old_size);
+
+   if(old_index < POOL_COUNT)
+     ponyint_pool_free(old_index, p);","Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?","@richsalz I think this should be `memcpy(new_p, p, new_size);`"
+2449,"@@ -109,6 +109,7 @@ namespace pwiz.Skyline.ToolsUI
+                 return OverwriteOrInParallel(_parent, toolCollectionName, toolCollectionVersion, reportList, foundVersion, newCollectionName);
+             }
+
++            // ReSharper disable once MemberHidesStaticFromOuterClass
+             public string InstallProgram(ProgramPathContainer programPathContainer,
+                                          ICollection<ToolPackage> packages,
+                                          string pathToInstallScript)",This is the only one that worries me a bit. It would be good if Brendan signed off on it.,This needs to be fixed.
+2450,"@@ -57,6 +57,8 @@ public abstract class OptionalArrayMethodView implements ApiMethodView {
+
+   public abstract boolean isLongrunningOperation();
+
++  public abstract boolean hasLongrunningReturnValue();
++
+   public static Builder newBuilder() {
+     return new AutoValue_OptionalArrayMethodView.Builder();
+   }",`LongRunningOperationDetailView` already has `isEmptyOperation`.,"I don't think it's safe to add this in the builder, the compil"
+2451,"@@ -471,6 +471,9 @@ class RemoteConnection(object):
+             request.add_header('Accept', 'application/json')
+             request.add_header('Content-Type', 'application/json;charset=UTF-8')
+
++            base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))
++            request.add_header(""Authorization"", ""Basic %s"" % base64string)
++
+             if password_manager:
+                 opener = url_request.build_opener(url_request.HTTPRedirectHandler(),
+                                                   HttpErrorHandler(),","This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'",Do you think it's worth adding some sort of validation to ensu
+2452,"@@ -15,12 +15,7 @@ class Theme < ActiveRecord::Base
+
+   validates :title, presence: {message: _(""can't be blank"")}
+
+-  # EVALUATE CLASS AND INSTANCE METHODS BELOW
+-  #
+-  # What do they do? do they do it efficiently, and do we need them?
+-
+-
+-
++  scope :updated_at_desc, -> { self.all.order(updated_at: 'DESC') }
+   ##
+   # returns the title of the theme
+   #","Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works.",I added this to make sure I can reference `updated_at` in a view later on.
+2453,"@@ -10,7 +10,7 @@ module Faker
+         end
+
+         return if digits < 1
+-        return 0 if digits == 1
++        return Base.rand(0..9).round if digits == 1
+
+         # Ensure the first digit is not zero
+         ([non_zero_digit] + generate(digits - 1)).join.to_i","I believe `Base.` is unnecessary in this case, as the class already extends `Base`.",Prefer single-quoted strings when you don't need string interpolation or s
+2454,"@@ -76,12 +76,13 @@ import ServerConnections from '../ServerConnections';
+         return '';
+     }
+
+-    function getImageUrl(item, width) {
++    function getImageUrl(item, size) {
+         const apiClient = ServerConnections.getApiClient(item.ServerId);
+         let itemId;
+
+         const options = {
+-            maxWidth: width,
++            fillWidth: size,
++            fillHeight: size,
+             type: 'Primary'
+         };
+ ",Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?,Is `width` no longer used?
+2455,"@@ -13,7 +13,8 @@ var reportsInstance = {},
+     localize = require('../../../api/utils/localization.js'),
+     common = require('../../../api/utils/common.js'),
+     log = require('../../../api/utils/log')('reports:reports'),
+-    versionInfo = require('../../../frontend/express/version.info');
++    versionInfo = require('../../../frontend/express/version.info'),
++    offlineMode = plugins.getConfig(""api"").offline_mode;
+
+ versionInfo.page = (!versionInfo.title) ? ""https://count.ly"" : null;
+ versionInfo.title = versionInfo.title || ""Countly"";","Here also, let's not cache value on top of file, but use `plugins.getConfig(""api"").offline_mode` directly where it is needed",Should we default this to `true`?
+2456,"@@ -78,10 +78,15 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+
++        $config = $this->getConfig();
++        $shibboleth = isset($config->Catalog->shibboleth_library_cards) &&
++            $config->Catalog->shibboleth_library_cards &&
++            ($this->getAuthManager()->getAuthMethod() == 'Shibboleth');
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'shibboleth' => $shibboleth,
+             ]
+         );
+     }",You can combine the two checks into a single `!empty()` check.,Can you use `!empty()` instead?
+2457,"@@ -599,6 +599,10 @@ func validateOptions(o *Options) error {
+ 		return fmt.Errorf(""lame duck grace period (%v) should be strictly lower than lame duck duration (%v)"",
+ 			o.LameDuckGracePeriod, o.LameDuckDuration)
+ 	}
++	if int64(o.MaxPayload) > o.MaxPending {
++		return fmt.Errorf(""max_payload (%v) cannot be higher than max_pending (%v)"",
++			o.MaxPayload, o.MaxPending)
++	}
+ 	// Check that the trust configuration is correct.
+ 	if err := validateTrustedOperators(o); err != nil {
+ 		return err",Should we add a warning for anything over say 8M? Just suggesting that is not recommended?,should this be `>=` rather than
+2458,"@@ -9,11 +9,9 @@ import (
+ 	""sync""
+
+ 	keybase1 ""github.com/keybase/client/go/protocol""
+-
+-	""golang.org/x/net/context""
+ )
+
+-func checkMDPerms(ctx context.Context, codec Codec, kbpki KBPKI,
++func checkMDPerms(codec Codec, currentUID keybase1.UID,
+ 	mergedMasterHead *RootMetadataSigned, checkWrite bool,
+ 	newMd *RootMetadataSigned) (bool, error) {
+ 	if mergedMasterHead == nil {",Looks like there are no callers left of this function.,do we still need `kbpki`?
+2459,"@@ -267,7 +267,7 @@ func logProgress(ctx context.Context, label BuildLabel) {
+ // If the command times out the returned error will be a context.DeadlineExceeded error.
+ // If showOutput is true then output will be printed to stderr as well as returned.
+ // It returns the stdout only, combined stdout and stderr and any error that occurred.
+-func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput bool, argv []string) ([]byte, []byte, error) {
++func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput, attachStdin bool, argv []string) ([]byte, []byte, error) {
+ 	if timeout == 0 {
+ 		if defaultTimeout == 0 {
+ 			timeout = 10 * time.Minute",Should there still be a ` bool` trailing `showOutput`?,I'm wondering why `attachStdin`
+2460,"@@ -24,6 +24,7 @@ import (
+ 	""sync""
+
+ 	""github.com/ghodss/yaml""
++	""github.com/pingcap/chaos-mesh/api/v1alpha1""
+
+ 	ctrl ""sigs.k8s.io/controller-runtime""
+ ",Did we can change to v1,this import should go with the rest of `github.com/pingcap/chaos-mesh/`
+2461,"@@ -43,6 +43,9 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi
+
+ 	try {
+ 		outer: if (oldVNode.type===Fragment || newType===Fragment) {
++			// Passing the ancestorComponent here is needed for catchErrorInComponent to properly traverse upwards through fragments
++			// to find a parent Suspense
++			c = { _ancestorComponent: ancestorComponent };
+ 			diffChildren(parentDom, newVNode, oldVNode, context, isSvg, excessDomChildren, mounts, c, oldDom);
+
+ 			// Mark dom as empty in case `_children` is any empty array. If it isn't",Can you please double check that this won't break anything?,Don't we need to do this for every fragment? Shouldn't we only do this
+2462,"@@ -124,6 +124,7 @@ namespace Nethermind.Runner.JsonRpc
+                     string.Empty,
+                     new IpcSocketsHandler(socket),
+                     RpcEndpoint.IPC,
++                    null,
+                     _jsonRpcProcessor,
+                     _jsonRpcService,
+                     _jsonRpcLocalStats,","optionals, shouldn't need to be stated explicitly",Nit: Any reason for passing `null` instead of `default`?
+2463,"@@ -7,13 +7,15 @@ import (
+ // VersionNumber is a version number as int
+ type VersionNumber int
+
+-// gquicVersion0 is the ""base"" for gQUIC versions
+-// e.g. version 39 is gquicVersion + 0x39
+-const gquicVersion0 = 0x51303300
++// gQUIC version range as defined in the wiki: https://github.com/quicwg/base-drafts/wiki/QUIC-Versions
++const (
++	gquicVersion0   = 0x51303030
++	maxGquicVersion = 0x51303439
++)
+
+ // The version numbers, making grepping easier
+ const (
+-	Version37 VersionNumber = gquicVersion0 + 0x37 + iota
++	Version37 VersionNumber = gquicVersion0 + 3*0x100 + 0x7 + iota
+ 	Version38
+ 	Version39
+ 	VersionTLS         VersionNumber = 101",That seems quite low - why not just 0x5130ffff?,"maxGquicVersion is the most recent version in quic, not the oldest one."
+2464,"@@ -76,7 +76,8 @@ class Net(Gen):
+         self.repr=net
+         self.parsed,self.netmask = self._parse_net(net)
+
+-
++    def __str__(self):
++        return self.repr
+
+     def __iter__(self):
+         for d in xrange(*self.parsed[3]):",Why is this needed ?,This seems unrelated to the rest of the PR.
+2465,"@@ -77,6 +77,14 @@ module Bolt
+         File.exist?(path) ? read_yaml_hash(path, file_name) : {}
+       end
+
++      def first_runs_free
++        Bolt::Config.user_path + '.first_runs_free'
++      end
++
++      def first_run?
++        Bolt::Config.user_path && !File.exist?(first_runs_free)
++      end
++
+       # Accepts a path with either 'plans' or 'tasks' in it and determines
+       # the name of the module
+       def module_name(path)","`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case.",There are a couple of other places where we
+2466,"@@ -113,6 +113,9 @@ func (a networkAction) String() string {
+ 	if a.t() == ignore || a.t() == disconnect {
+ 		return fmt.Sprintf(""%v: %5v"", a.t().String(), a.Err)
+ 	}
++	if a.Tag == protocol.ProposalPayloadTag {
++		return fmt.Sprintf(""%v: %2v: %5v"", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value())
++	}
+ 	return fmt.Sprintf(""%v: %2v"", a.t().String(), a.Tag)
+ }
+ ",nit: use %s for strings and %v for objects.,Why is this necessary?
+2467,"@@ -8,16 +8,6 @@ class TTemplateParamClass extends TClassString
+      */
+     public $param_name;
+
+-    /**
+-     * @var string
+-     */
+-    public $as;
+-
+-    /**
+-     * @var ?TNamedObject
+-     */
+-    public $as_type;
+-
+     /**
+      * @var string
+      */","Same as before, the properties already exists in parent",Why did you remove this?
+2468,"@@ -25,11 +25,11 @@ if __name__ == ""__main__"":
+     copy_file(os.path.join(source, ""lib_lightgbm.dll""), os.path.join(windows_folder_path, ""lib_lightgbm.dll""))
+     copy_file(os.path.join(source, ""lightgbm.exe""), os.path.join(windows_folder_path, ""lightgbm.exe""))
+     version = open(os.path.join(current_dir, os.path.pardir, 'VERSION.txt')).read().strip().replace('rc', '-rc')
+-    nuget_str = r""""""<?xml version=""1.0""?>
++    nuget_str = f""""""<?xml version=""1.0""?>
+     <package xmlns=""http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"">
+     <metadata>
+         <id>LightGBM</id>
+-        <version>%s</version>
++        <version>{version, datetime.datetime.now().year}</version>
+         <authors>Guolin Ke</authors>
+         <owners>Guolin Ke</owners>
+         <licenseUrl>https://github.com/microsoft/LightGBM/blob/master/LICENSE</licenseUrl>",This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`.,not sure if this is correct but `datetime.datetime.now().year` is not the correct year. It should be `datetime.datetime.today.year`
+2469,"@@ -274,7 +274,7 @@ static int pause_device(sd_bus_message *msg, void *userdata,
+ 		goto error;
+ 	}
+
+-	if (major == DRM_MAJOR) {
++	if (major == DRM_MAJOR && strcmp(type, ""gone"") != 0) {
+ 		assert(session->has_drm);
+ 		session->base.active = false;
+ 		wlr_signal_emit_safe(&session->base.session_signal, session);","Maybe we should only set active = false if `strcmp(type, ""pause"") == 0`?","The ""gone"" string looks a bit odd to me, maybe ""gone-drm"" is better?"
+2470,"@@ -37,6 +37,12 @@ module Selenium
+         def bridge_class
+           Bridge
+         end
++
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
+       end # Driver
+     end # Firefox
+   end # WebDriver",Same here. and all others.,Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
+2471,"@@ -18,6 +18,8 @@ import (
+ 	""github.com/keybase/kbfs/libfs""
+ 	""github.com/keybase/kbfs/libfuse""
+ 	""github.com/keybase/kbfs/libkbfs""
++
++	_ ""github.com/songgao/stacktraces/on/SIGUSR2""
+ )
+
+ var runtimeDir = flag.String(""runtime-dir"", os.Getenv(""KEYBASE_RUNTIME_DIR""), ""runtime directory"")","Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`.",why did you add this?
+2472,"@@ -113,9 +113,10 @@ RTPSParticipant* RTPSDomain::createParticipant(
+         PParam.builtin.initialPeersList.push_back(local);
+     }
+
+-    GuidPrefix_t guidP(PParam.prefix);
++    // Generate a new GuidPrefix_t
++
++    GuidPrefix_t guidP;
+
+-    if (guidP == c_GuidPrefix_Unknown)
+     {
+         // Make a new participant GuidPrefix_t up
+         int pid = System::GetPID();",I think this blank line may be removed,This change looks unrelated to the PR.
+2473,"@@ -272,12 +272,17 @@ class BookmarkManager(UrlMarkManager):
+         elif len(parts) == 1:
+             self.marks[parts[0]] = ''
+
+-    def add(self, url, title):
++    def add(self, url, title, toggle=False):
+         """"""Add a new bookmark.
+
++        Return True if the bookmark was added, and False if it was
++        removed (which only happens if toggle is True).
++
+         Args:
+             url: The url to add as bookmark.
+             title: The title for the new bookmark.
++            toggle: remove the bookmark instead of raising an error if it
++                    already exists.
+         """"""
+         if not url.isValid():
+             errstr = urlutils.get_errstring(url)","I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`.",nit: We should update the docstring fo
+2474,"@@ -630,6 +630,7 @@ EmmcSwitchBusWidth (
+   UINT8       Index;
+   UINT8       Value;
+   UINT8       CmdSet;
++  UINT32      DevStatus;
+
+   //
+   // Write Byte, the Value field is written into the byte pointed by Index.","@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start",Why not just using `UINT32` for the `d
+2475,"@@ -0,0 +1,10 @@
++class CloudTag
++  TAGS_LIST = YAML.load File.read(""#{Rails.root}/config/tags_list.yml"")
++
++  class << self
++    def list
++      index = TAGS_LIST.length - Time.now.day
++      TAGS_LIST[index].sort { |a, b| a[0] <=> b[0] }
++    end
++  end
++end",How about YAML.load_file(),Layout/EmptyLinesAroundClassBody: Extr
+2476,"@@ -33,7 +33,9 @@ public class ContainerizationMetricsImpl implements ContainerizationMetrics {
+   private Meter podCompleted, podRequested, podScheduled, initContainerRunning,
+       appContainerStarting, podReady, podInitFailure, podAppFailure;
+   private Meter flowSubmitToExecutor, flowSubmitToContainer;
++  private Meter executionStopped, containerDispatchFail;
+   private Histogram timeToDispatch;
++  private boolean isInitialized = false;
+
+   @Inject
+   public ContainerizationMetricsImpl(MetricsManager metricsManager) {","Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`.",I don't see this field being used anywhere. Can it be removed?
+2477,"@@ -974,6 +974,13 @@ drwrap_exit(void)
+     if (count != 0)
+         return;
+
++    drmgr_unregister_bb_app2app_event(drwrap_event_bb_app2app);
++    drmgr_unregister_bb_instrumentation_event(drwrap_event_bb_analysis);
++    drmgr_unregister_module_unload_event(drwrap_event_module_unload);
++    dr_unregister_delete_event(drwrap_fragment_delete);
++
++    drmgr_unregister_tls_field(tls_idx);
++
+     hashtable_delete(&replace_table);
+     hashtable_delete(&replace_native_table);
+     hashtable_delete(&wrap_table);",Check the return value of the drmgr ones.,The call to `drmgr_unregister_module_unload_event()` should be
+2478,"@@ -345,7 +345,10 @@ class FileUpload extends FormWidgetBase
+     protected function loadAssets()
+     {
+         $this->addCss('css/fileupload.css', 'core');
+-        $this->addJs('js/fileupload.js', 'core');
++        $this->addJs('js/fileupload.js', [
++            'build' => 'core',
++            'data-cfasync'  => 'false'
++        ]);
+     }
+
+     /**",This should be `'cache'`,Shouldn't it be set to true ?
+2479,"@@ -36,7 +36,7 @@ type RepoWrangler interface {
+ 	// GetOldRepo opens and returns the old repo with read-only access
+ 	GetOldRepo() (*os.File, error)
+ 	// MakeNewRepo creates and returns the new repo dir with read/write permissions
+-	MakeNewRepo() (*os.File, error)
++	MakeNewRepo() error
+ 	// GetOldRepoPath returns the full path of the old repo
+ 	GetOldRepoPath() string
+ 	// GetNewRepoPath returns the full path of the old repo","The name ""old"" might cause confusion here. After installation, the ""old"" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like ""target"" or ""canonical""?",Why did you remove this return type?
+2480,"@@ -1744,6 +1744,7 @@ Collection.prototype.aggregate = function(pipeline, options, callback) {
+   options = Object.assign({}, options);
+   // Ensure we have the right read preference inheritance
+   options.readPreference = resolveReadPreference(options, { db: this.s.db, collection: this });
++  command.readPreference = options.readPreference;
+
+   // If explain has been specified add it
+   if (options.explain) {","I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?",Shouldn't this be `this.readPreference = options.readPreference`?
+2481,"@@ -91,8 +91,9 @@ func SpawnIntermediateHashesStage(s *StageState, u Unwinder, tx kv.RwTx, cfg Tri
+ 		if cfg.checkRoot && root != expectedRootHash {
+ 			log.Error(fmt.Sprintf(""[%s] Wrong trie root of block %d: %x, expected (from header): %x. Block hash: %x"", logPrefix, to, root, expectedRootHash, headerHash))
+ 			if to > s.BlockNumber {
+-				log.Warn(""Unwinding due to incorrect root hash"", ""to"", to-1)
+-				u.UnwindTo(to-1, headerHash)
++				unwindTo := (to + s.BlockNumber) / 2 // Binary search for the correct block, biased to the lower numbers
++				log.Warn(""Unwinding due to incorrect root hash"", ""to"", unwindTo)
++				u.UnwindTo(unwindTo, headerHash)
+ 			}
+ 		} else if err = s.Update(tx, to); err != nil {
+ 			return trie.EmptyRoot, err",During genesis sync it can unwind 5M blocks?,Where is `unwindTo` defined? I cannot find it.
+2482,"@@ -852,6 +852,7 @@ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivities() {
+ }
+
+ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivitiesWithZeroDispatch() {
++	s.T().Skip(""Racy - times out ~50% of the time running locally with --race"")
+ 	// Set a short long poll expiration so we don't have to wait too long for 0 throttling cases
+ 	s.matchingEngine.config.LongPollExpirationInterval = dynamicconfig.GetDurationPropertyFnFilteredByTaskQueueInfo(20 * time.Millisecond)
+ 	dispatchLimitFn := func(wc int, tc int64) float64 {",was it caused by the removal of removeTaskQueueManager() from this test?,"I think you might want to run it with `--race`, just to be sure t"
+2483,"@@ -61,7 +61,7 @@ module Blacklight::CatalogHelperBehavior
+   # @see #page_entries_info
+   # @return [String]
+   def item_page_entry_info
+-    t('blacklight.search.entry_pagination_info.other', :current => number_with_delimiter(search_session[:counter]), :total => number_with_delimiter(search_session[:total]), :count => search_session[:total].to_i).html_safe
++    t('blacklight.search.entry_pagination_info.other', :current => number_with_delimiter(search_session['counter']), :total => number_with_delimiter(search_session['total']), :count => search_session['total'].to_i).html_safe
+   end
+
+   ##","Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but..",Line is too long. [89/80]
+2484,"@@ -146,6 +146,8 @@ struct PROC_RESOURCES {
+                 atp->needs_shmem = false;
+             }
+         }
++        if (rp->rr_sim_misses_deadline) return false;
++            // Don't schedule if the result is simulated to miss its deadline
+         if (rp->schedule_backoff > gstate.now) return false;
+         if (rp->uses_gpu()) {
+             if (gpu_suspend_reason) return false;","So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one.",Shouldn't this be `>=` rather than `>`?
+2485,"@@ -10717,6 +10717,11 @@ int LuaScriptInterface::luaItemTypeCreate(lua_State* L)
+ 		id = Item::items.getItemIdByName(getString(L, 2));
+ 	}
+
++	if (id == 0) {
++		lua_pushnil(L);
++		return 1;
++	}
++
+ 	const ItemType& itemType = Item::items[id];
+ 	pushUserdata<const ItemType>(L, &itemType);
+ 	setMetatable(L, -1, ""ItemType"");","You should add the check above this line instead. If string is empty, don't even call the function.",please use `if (id == 0) {`
+2486,"@@ -101,6 +101,13 @@ public class DynamoDBCertRecordStoreConnection implements CertRecordStoreConnect
+     }
+
+     private X509CertRecord itemToX509CertRecord(Item item) {
++        boolean clientCert;
++        try {
++            clientCert = item.getBoolean(KEY_CLIENT_CERT);
++        } catch (Exception ex) {
++            LOGGER.warn(""clientCert for item doesn't exist. Will set it to false. Item: {}"", item.toString());
++            clientCert = false;
++        }
+         X509CertRecord certRecord = new X509CertRecord();
+         certRecord.setProvider(item.getString(KEY_PROVIDER));
+         certRecord.setInstanceId(item.getString(KEY_INSTANCE_ID));",If clientCert attribute doesn't exist for some reason I set it to false.,Maybe `clientCert = item.getBoolean(KEY
+2487,"@@ -301,7 +301,11 @@ module Travis
+               cmd_opts = {retry: true, assert: false, echo: 'Installing caching utilities'}
+               if casher_branch == 'production'
+                 static_file_location = ""https://#{app_host}/files/#{name}"".output_safe
+-                sh.cmd curl_cmd(flags, location, static_file_location), cmd_opts
++                app_host_flags = flags
++                if Travis::Build.config&.ssl&.verify == false
++                  app_host_flags += ' -k '
++                end
++                sh.cmd curl_cmd(app_host_flags, location, static_file_location), cmd_opts
+                 sh.if ""$? -ne 0"" do
+                   cmd_opts[:echo] = ""Installing caching utilities from the Travis CI server (#{static_file_location}) failed, failing over to using GitHub (#{remote_location})""
+                   sh.cmd curl_cmd(flags, location, remote_location), cmd_opts","Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?",Style/StringLiterals: Prefer single-quo
+2488,"@@ -211,11 +211,11 @@ void Creature::onWalk()
+ 				forceUpdateFollowPath = true;
+ 			}
+ 		} else {
++			stopEventWalk();
++
+ 			if (listWalkDir.empty()) {
+ 				onWalkComplete();
+ 			}
+-
+-			stopEventWalk();
+ 		}
+ 	}
+ ",Walk should actually be completed (`onWalkCompleted`) after the event is stopped.   This also makes it possible for monster to walk by smaller paths.,"`listWalkDir` will always be empty here, so this line shouldn't be needed."
+2489,"@@ -31,6 +31,17 @@ func NewSimpleJoiner(getter storage.Getter) file.Joiner {
+ }
+
+ func (s *simpleJoiner) Size(ctx context.Context, address swarm.Address) (dataSize int64, err error) {
++	// Handle size based on weather the root chunk is encrypted or not
++	toDecrypt := len(address.Bytes()) == swarm.EncryptedReferenceSize
++
++	var key encryption.Key
++	addrBytes := address.Bytes()
++	if toDecrypt {
++		addrBytes = address.Bytes()[:swarm.HashSize]
++		key = address.Bytes()[swarm.HashSize : swarm.HashSize+encryption.KeyLength]
++	}
++
++	address = swarm.NewAddress(addrBytes)
+ 	// retrieve the root chunk to read the total data length the be retrieved
+ 	rootChunk, err := s.getter.Get(ctx, storage.ModeGetRequest, address)
+ 	if err != nil {",typo in `weather` (should be `whether`),This will always be `nil` when `toDecrypt` is `false`. `toDecrypt` will al
+2490,"@@ -35,6 +35,7 @@ var (
+ 	sourceOS               = flag.String(""source-os"", """", fmt.Sprintf(""OS version of the source instance to upgrade. Supported values: %v"", strings.Join(upgrader.SupportedSourceOSVersions(), "", "")))
+ 	targetOS               = flag.String(""target-os"", """", fmt.Sprintf(""Version of the OS after upgrade. Supported values: %v"", strings.Join(upgrader.SupportedTargetOSVersions(), "", "")))
+ 	timeout                = flag.String(""timeout"", """", ""Maximum time limit for an upgrade. For example, if the time limit is set to 2h, the upgrade times out after two hours. For more information about time duration formats, see $ gcloud topic datetimes"")
++	useStagingInstallMedia = flag.Bool(""use-staging-install-media"", false, ""Use staging install media. This flag is for testing only. Set to true to upgrade with staging windows install media."")
+ 	scratchBucketGcsPath   = flag.String(""scratch-bucket-gcs-path"", """", ""Scratch GCS bucket. This setting overrides the workflow setting."")
+ 	oauth                  = flag.String(""oauth"", """", ""Path to OAuth .json file. This setting overrides the workflow setting."")
+ 	ce                     = flag.String(""compute-endpoint-override"", """", ""API endpoint. This setting overrides the default API endpoint setting."")","Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image.","""Set to true to upgrade with staging install media."""
+2491,"@@ -351,7 +351,8 @@ static bool ReadAAPairs(
+     return false;
+   }
+   unsigned n = 0;
+-  fscanf(fp, ""%d"", &n);
++  int num_scan = fscanf(fp, ""%d"", &n);
++  RDUNUSED_PARAM(num_scan);
+
+   char buffer[80];
+ ","I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken.",`n` could be initialized to `1` here (and in the other places too).
+2492,"@@ -17,7 +17,9 @@ namespace storage {
+
+ TEST(AddEdgesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddEdgesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddEdgesProcessor::instance(kv.get(),","Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?",use `sizeof(int32_t)` instead
+2493,"@@ -0,0 +1,14 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core
++{
++    public class RequestBodyTimeout
++    {
++        public TimeSpan MinimumTime { get; set; }
++        public TimeSpan? MaximumTime { get; set; }
++        public double? MinimumRate { get; set; }
++    }
++}","Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations.",Why do we need a nullable `Ti
+2494,"@@ -0,0 +1,12 @@
++package testutils
++
++import (
++	""os""
++	""path""
++)
++
++func TestDataFile(name string) string {
++	dir, _ := os.Getwd()
++
++	return path.Join(dir, ""testdata"", name)
++}","Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?",You should check the error he
+2495,"@@ -1823,7 +1823,9 @@ class CSharpGenerator : public BaseGenerator {
+             code += ""[idx"" + NumToString(j++) + ""]"";
+           }
+           code += "";"";
+-          for (size_t i = 0; i < array_only_lengths.size(); ++i) { code += ""}""; }
++          for (size_t i = 0; i < array_only_lengths.size(); ++i) {
++            code += ""}"";
++          }
+         } else {
+           code += ""_o"";
+           for (size_t i = 0; i < array_lengths.size(); ++i) {",This change is due to `clang_format` and is not related to this PR.,Why did you put this on one l
+2496,"@@ -359,6 +359,11 @@ block_all_signals_except(kernel_sigset_t *oset, int num_signals,
+         kernel_sigdelset(&set, va_arg(ap, int));
+     }
+     va_end(ap);
++    /* We never block SIGSEGV or SIGBUS: we need them for various safe reads and to
++     * properly report crashes.
++     */
++    kernel_sigdelset(&set, SIGSEGV);
++    kernel_sigdelset(&set, SIGBUS);
+     sigprocmask_syscall(SIG_SETMASK, &set, oset, sizeof(set));
+ }
+ ","Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for.",We should add a sanity check to make sure we don't block SIGSEGV or SIGBUS in that case.
+2497,"@@ -0,0 +1,13 @@
++package de.danoeh.antennapod.core.storage;
++
++import android.support.annotation.NonNull;
++
++import de.danoeh.antennapod.core.feed.FeedFile;
++
++public interface FeedFileDownloadStatusRequesterInterface {
++    /**
++     * @return {@code true} if the named feedfile is in the downloads list
++     */
++    boolean isDownloadingFile(@NonNull FeedFile item);
++
++}",Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests.,"You don't need this interface IMO, `FeedFileDownloadStatusRequester` can implement `Down"
+2498,"@@ -27,6 +27,7 @@ public class ManifestFileBean implements ManifestFile {
+   private String path = null;
+   private Long length = null;
+   private Integer partitionSpecId = null;
++  private Integer content = null;
+   private Long addedSnapshotId = null;
+
+   public String getPath() {",why not just use `ManifestContent` instead of `Integer`?,Can we use a primitive `long` for the content type as well?
+2499,"@@ -260,8 +260,16 @@ namespace Nethermind.TxPool
+             }
+
+             Metrics.PendingTransactionsReceived++;
+-
+-            if (!_validator.IsWellFormed(tx, _specProvider.GetSpec()))
++
++            IReleaseSpec releaseSpec = _specProvider.GetSpec();
++            if (tx.Type == TxType.AccessList && !releaseSpec.IsEip2930Enabled)
++            {
++                Metrics.PendingTransactionsDiscarded++;
++                if (_logger.IsTrace) _logger.Trace($""Skipped adding transaction {tx.ToString(""  "")}, wrong transaction type {tx.Type}."");
++                return AddTxResult.Invalid;
++            }
++
++            if (!_validator.IsWellFormed(tx, releaseSpec))
+             {
+                 // It may happen that other nodes send us transactions that were signed for another chain or don't have enough gas.
+                 Metrics.PendingTransactionsDiscarded++;",can we do that in TxValidator?,would be better to use a switch
+2500,"@@ -66,6 +66,7 @@ type OnewayOutbound interface {
+
+ // Outbounds encapsulates outbound types for a service
+ type Outbounds struct {
+-	Unary  UnaryOutbound
+-	Oneway OnewayOutbound
++	ServiceName string
++	Unary       UnaryOutbound
++	Oneway      OnewayOutbound
+ }",We definitely want some detailed and thoughtful docs being added to this type.,"I wonder if we should make this a bit more explicit that it's a service name, rather than a service name. Thoughts?"
+2501,"@@ -467,7 +467,7 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane {
+ 	}
+
+ 	// TODO Integrate XDP and BPF infra.
+-	if !config.BPFEnabled && dp.xdpState == nil {
++	if !config.BPFEnabled && config.XDPEnabled && dp.xdpState == nil {
+ 		xdpState, err := NewXDPState(config.XDPAllowGeneric)
+ 		if err == nil {
+ 			if err := xdpState.WipeXDP(); err != nil {","We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart.",Why is the `config.XDPEnabled` check needed? Isn't the `dp.xdpState` always true?
+2502,"@@ -25,6 +25,18 @@ DEFINE_int32(clean_wal_interval_secs, 600, ""inerval to trigger clean expired wal
+ namespace nebula {
+ namespace kvstore {
+
++#define SPACE_EXIST_RETURN_IF_ERROR(...)                                                           \
++    do {                                                                                           \
++        auto s = (__VA_ARGS__);                                                                    \
++        if (!ok(s)) {                                                                              \
++            if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND) {                              \
++                LOG(INFO) << ""Space "" << spaceId << "" does not exist, skip it."";                   \
++                return ResultCode::SUCCEEDED;                                                      \
++            }                                                                                      \
++            return error(s);                                                                       \
++        }                                                                                          \
++    } while (0)                                                                                    \
++
+ NebulaStore::~NebulaStore() {
+     LOG(INFO) << ""Cut off the relationship with meta client"";
+     options_.partMan_.reset();",If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?,Does this need a space arg? Wouldn't `break` be clearer?
+2503,"@@ -17,6 +17,8 @@ class ResLayer(nn.Sequential):
+             Default: None
+         norm_cfg (dict): dictionary to construct and config norm layer.
+             Default: dict(type='BN')
++        reverse (bool): Reverse the order of planes in layer sequence.
++            False for ResNet, True for Houglass. Default: False
+     """"""
+
+     def __init__(self,","It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network.","Add a line like ""Defaults to False"" at the end."
+2504,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`),"Instead of doing this, you can just do `options.service = getDefaultService()` in the `createSession` method and remove this line."
+2505,"@@ -273,6 +273,11 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+             ""consider using the list, dict or set constructor. ""
+             ""It is faster and simpler."",
+         ),
++        ""R1722"": (
++            ""Consider using sys.exit()"",
++            ""consider-using-sys-exit"",
++            ""Instead of using exit() or quit(), consider using the sys.exit()."",
++        ),
+     }
+     options = (
+         (","I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that.",Could you please add a period at the end of the sentence?
+2506,"@@ -315,7 +315,7 @@ func (c *controller) certificateRequiresIssuance(ctx context.Context, log logr.L
+ 	}
+
+ 	// validate the common name is correct
+-	expectedCN := pki.CommonNameForCertificate(crt)
++	expectedCN := crt.Spec.CommonName
+ 	if expectedCN != cert.Subject.CommonName {
+ 		log.Info(""certificate common name is not as expected, re-issuing"")
+ 		return true","If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here.",This should just be `crt.Spec.CommonName` no?
+2507,"@@ -23,8 +23,15 @@ import pytest
+ from PyQt5.QtCore import Qt
+
+ from qutebrowser.mainwindow import prompt as promptmod
+-from qutebrowser.utils import usertypes
+-
++from qutebrowser.utils import usertypes, objreg
++from qutebrowser.misc import cmdhistory
++
++@pytest.fixture(autouse=True)
++def test_init(fake_save_manager, data_tmpdir, config_stub):
++    cmdhistory.init()
++    yield
++    objreg.delete('command-history')
++    objreg.delete('fprompt-history')
+
+ class TestFileCompletion:
+ ","This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so.",The `yield` statement can be removed (and the `del` statement can be removed)
+2508,"@@ -292,6 +292,10 @@ class PySparkTask(SparkSubmitTask):
+         if self.deploy_mode == ""cluster"":
+             return [self.run_pickle]
+
++    @property
++    def pickle_protocol(self):
++        return configuration.get_config().getint(self.spark_version, ""pickle-protocol"", pickle.DEFAULT_PROTOCOL)
++
+     def setup(self, conf):
+         """"""
+         Called by the pyspark_runner with a SparkConf instance that will be used to instantiate the SparkContext",why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`),`pickle.DEFAULT_PROTOCOL` --> `pickle.DEFAULT_PROTOCOL` ?
+2509,"@@ -31,6 +31,18 @@ func TestDefaultOptions(t *testing.T) {
+ 	}
+ }
+
++func TestOptions_RandomPort(t *testing.T) {
++	opts := &Options{
++		Port: RANDOM_PORT,
++	}
++	processOptions(opts)
++
++	if opts.Port != 0 {
++		t.Fatalf(""Process of options should have resolved random port to ""+
++			""zero.\nexpected: %d\ngot: %d\n"", 0, opts.Port)
++	}
++}
++
+ func TestConfigFile(t *testing.T) {
+ 	golden := &Options{
+ 		Host:        ""apcera.me"",",nit: Think it can be one line..,This should be a `Fatalf` not a `Fatalf`.
+2510,"@@ -12,10 +12,7 @@
+  */
+ package org.camunda.bpm.application;
+
+-import java.util.Collections;
+-import java.util.List;
+-import java.util.Map;
+-import java.util.ServiceLoader;
++import java.util.*;
+ import java.util.concurrent.Callable;
+
+ import javax.script.ScriptEngine;",please inline imports,"No asterisk imports, please."
+2511,"@@ -85,8 +85,7 @@ func (p *setnsProcess) start() (err error) {
+ 	if err = p.execSetns(); err != nil {
+ 		return newSystemErrorWithCause(err, ""executing setns process"")
+ 	}
+-	// We can't join cgroups if we're in a rootless container.
+-	if !p.config.Rootless && len(p.cgroupPaths) > 0 {
++	if len(p.cgroupPaths) > 0 {
+ 		if err := cgroups.EnterPid(p.cgroupPaths, p.pid()); err != nil {
+ 			return newSystemErrorWithCausef(err, ""adding pid %d to cgroups"", p.pid())
+ 		}","This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though.",Why was this removed?
+2512,"@@ -34,6 +34,7 @@ var skip = map[string]string{
+ 	""task_per_line"":               ""join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)"",
+ 	""rowfn_with_import"":           ""imported libraries are not visible in user-defined functions (https://github.com/influxdata/flux/issues/1000)"",
+ 	""string_trim"":                 ""cannot reference a package function from within a row function"",
++	""integral_columns"":            ""aggregates changed to operate on just a single columnm."",
+ }
+
+ var querier = querytest.NewQuerier()",Should we update integral to operate on a single column as well?,"How about ""aggregates changed to operate on just a single columnm."" ?"
+2513,"@@ -91,7 +91,9 @@ static std::atomic<int> num_uvm_allocations(0);
+ }  // namespace
+
+ void DeepCopyCuda(void *dst, const void *src, size_t n) {
+-  KOKKOS_IMPL_CUDA_SAFE_CALL(cudaMemcpy(dst, src, n, cudaMemcpyDefault));
++  cudaStream_t s = cuda_get_deep_copy_stream();
++  KOKKOS_IMPL_CUDA_SAFE_CALL(
++      cudaMemcpyAsync(dst, src, n, cudaMemcpyDefault, s));
+ }
+
+ void DeepCopyAsyncCuda(const Cuda &instance, void *dst, const void *src,",Doesn't belong to this PR,What does this do? Does it still need to call cudaMemcpyAsync?
+2514,"@@ -26,7 +26,7 @@ type ECSClient interface {
+ 	// ContainerInstanceARN if successful. Supplying a non-empty container
+ 	// instance ARN allows a container instance to update its registered
+ 	// resources.
+-	RegisterContainerInstance(existingContainerInstanceArn string, attributes []*ecs.Attribute) (string, error)
++	RegisterContainerInstance(existingContainerInstanceArn string, attributes []*ecs.Attribute, registrationToken string) (string, error)
+ 	// SubmitTaskStateChange sends a state change and returns an error
+ 	// indicating if it was submitted
+ 	SubmitTaskStateChange(change TaskStateChange) error","Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc.",How is this change related to the rest of the PR?
+2515,"@@ -68,6 +68,7 @@ public class UserAccount {
+ 	private static final String TAG = ""UserAccount"";
+ 	private static final String FORWARD_SLASH = ""/"";
+ 	private static final String UNDERSCORE = ""_"";
++	private static final String SF_APP_FEATURE_CODE_USER_AUTH = ""UA"";
+
+ 	private String authToken;
+ 	private String refreshToken;",Could we shorten this constant to maybe `FEATURE_USER_AUTH`?,"The ""UserAccount"" naming convention is not consistent with the ""Accou"
+2516,"@@ -14,6 +14,10 @@ import (
+ 	""golang.org/x/net/context""
+ )
+
++const (
++	numRekeyWorkers = 8
++)
++
+ type rekeyQueueEntry struct {
+ 	id tlf.ID
+ 	ch chan error",Any particular reason for 8? I feel like we could probably handle more...,"If this is only used in the tests, maybe just inline it in the test?"
+2517,"@@ -91,6 +91,13 @@ class CodeSetAdminTest < ActionDispatch::IntegrationTest
+     assert_response :redirect
+   end
+
++  it 'should update retry_count' do
++    login_as admin
++    job = create(:fetch_job, repository: create(:repository))
++    put admin_job_path(job), job: { retry_count: 3 }
++    job.reload.retry_count.must_equal 3
++  end
++
+   it 'should delete job' do
+     login_as admin
+     job = create(:fetch_job, repository: create(:repository))","Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository.",Metrics/LineLength: Line is too long. [125/120]
+2518,"@@ -1,7 +1,7 @@
+ <tr class=""m-shared-email_status"">
+   <td colspan=""2"" padding=""10"">
+     <table id=""status-container-detail"" width=""770"" class=""col-md-12"">
+-      <tr class=""status-header-container"">
++      <tr class=""status-header-container cancelled"">
+         <td>
+           <strong>Approval Status</strong>
+         </td>","Should the ""cancelled"" class be added regardless of the proposal's state?",It looks like there's an extra `cancel` class in this row. Is that i
+2519,"@@ -115,7 +115,6 @@ const validOptions = require('./operations/mongo_client_ops').validOptions;
+  */
+ function MongoClient(url, options) {
+   if (!(this instanceof MongoClient)) return new MongoClient(url, options);
+-
+   // Set up event emitter
+   EventEmitter.call(this);
+ ","nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes.",We don't need this blank line here.
+2520,"@@ -624,9 +624,15 @@ exports.populate = function populate(path, select, model, match, options, subPop
+
+   var ret = [];
+   var paths = path.split(' ');
++  var models = undefined;
++  if (typeof model === 'string') {
++    models = model.split(' ');
++  }
+   options = exports.clone(options, { retainKeyOrder: true });
+   for (var i = 0; i < paths.length; ++i) {
+-    ret.push(new PopulateOptions(paths[i], select, match, options, model, subPopulate));
++    var _model = model;
++    if (models && i < models.length) _model = models[i];
++    ret.push(new PopulateOptions(paths[i], select, match, options, _model, subPopulate));
+   }
+
+   return ret;",Seems kinda dangerous - what if models length is different from paths length?,Why do we need this?
+2521,"@@ -412,7 +412,7 @@ func stageSenders(db kv.RwDB, ctx context.Context) error {
+ 	s := stage(sync, tx, nil, stages.Senders)
+ 	log.Info(""Stage"", ""name"", s.ID, ""progress"", s.BlockNumber)
+
+-	cfg := stagedsync.StageSendersCfg(db, chainConfig, tmpdir)
++	cfg := stagedsync.StageSendersCfg(db, chainConfig, tmpdir, prune.Mode{})
+ 	if unwind > 0 {
+ 		u := sync.NewUnwindState(stages.Senders, s.BlockNumber-unwind, s.BlockNumber)
+ 		err = stagedsync.UnwindSendersStage(u, tx, cfg, ctx)",set real one plz (get it from DB).,Why do we need to sp
+2522,"@@ -180,8 +180,9 @@ static fpga_result send_uafu_event_request(fpga_handle handle,
+ 	struct _fpga_handle *_handle = (struct _fpga_handle *)handle;
+ 	struct fpga_port_info port_info  = {.argsz = sizeof(port_info),
+ 						.flags = 0 };
+-	struct fpga_port_uafu_irq_set uafu_irq = {.argsz = sizeof(uafu_irq),
+-						.flags = 0};
++	uint8_t uafu_irq_buf[sizeof(struct fpga_port_uafu_irq_set)+sizeof(int32_t)];
++	struct fpga_port_uafu_irq_set *uafu_irq =
++		(struct fpga_port_uafu_irq_set *) uafu_irq_buf;
+
+ 	if (uafu_operation != FPGA_IRQ_ASSIGN && uafu_operation != FPGA_IRQ_DEASSIGN) {
+ 		FPGA_ERR(""Invalid UAFU operation requested"");",Should this be initialized to zeroes?,Why is this being mo
+2523,"@@ -419,7 +419,7 @@ public abstract class FacetProcessor<FacetRequestT extends FacetRequest>  {
+       }
+       count = result.size();  // don't really need this if we are skipping, but it's free.
+     } else {
+-      if (q == null) {
++      if (q == null || fcontext.base.size() == 0) {
+         count = fcontext.base.size();
+       } else {
+         count = fcontext.searcher.numDocs(q, fcontext.base);","The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)",I'm wondering if `fc
+2524,"@@ -1,16 +1,14 @@
+-
+ package net.runelite.client.plugins.wildernesslocations;
+
++
+ import java.util.Arrays;
+ import java.util.HashMap;
+-import java.util.List;
+ import java.util.Map;
+ import java.util.Objects;
+-import java.util.Set;
+-import java.util.function.Consumer;
+ import javax.inject.Inject;
++
++import lombok.Getter;
+ import net.runelite.api.Client;
+-import net.runelite.api.Player;
+ import net.runelite.api.Varbits;
+ import net.runelite.api.coords.WorldArea;
+ import net.runelite.api.coords.WorldPoint;",re-add the type in the annotation here,wrong import order
+2525,"@@ -226,9 +226,11 @@ func GetLatestVersion() (string, error) {
+ 	//Download the tar from repo
+ 	versionURL := ""curl -k "" + latestReleaseVersionURL
+ 	cmd := exec.Command(""sh"", ""-c"", versionURL)
++	var stderr bytes.Buffer
++	cmd.Stderr = &stderr
+ 	latestReleaseData, err := cmd.Output()
+ 	if err != nil {
+-		return """", err
++		return """", fmt.Errorf(""%v:%v"", err, stderr.String())
+ 	}
+
+ 	latestRelease := &latestReleaseVersion{}",Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?,is stderr used for
+2526,"@@ -13,6 +13,11 @@ func ShouldRotateX509(now time.Time, cert *x509.Certificate) bool {
+ 	return shouldRotate(now, cert.NotBefore, cert.NotAfter)
+ }
+
++// X509Expired returns true if the given X509 cert has expired
++func X509Expired(now time.Time, cert *x509.Certificate) bool {
++	return !now.Before(cert.NotAfter)
++}
++
+ // JWTSVIDExpiresSoon determines if the given JWT SVID should be rotated
+ // based on presented current time, the JWT's expiration.
+ // Also returns true if the JWT is already expired.","there's enough ""nots"" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)",Can we rename this
+2527,"@@ -21,7 +21,7 @@ import (
+
+ 	""github.com/ghodss/yaml""
+
+-	""istio.io/fortio/log""
++	""fortio.org/fortio/log""
+ 	""istio.io/tools/isotope/convert/pkg/graph""
+ 	""istio.io/tools/isotope/convert/pkg/graph/size""
+ 	""istio.io/tools/isotope/convert/pkg/graph/svc""",File is not `goimports`-ed (from `goimports`),Drive-by fix here.
+2528,"@@ -73,6 +73,11 @@ class Config(param.ParameterizedFunction):
+        recommended that users switch this on to update any uses of
+        __call__ as it will be deprecated in future."""""")
+
++    rtol = param.Number(default=10e-6, doc=""""""
++      The tolerance used to enforce regular sampling for gridded data
++      where regular sampling is expected. Expressed as the maximal
++      allowable sampling difference between sample locations."""""")
++
+     def __call__(self, **params):
+         self.set_param(**params)
+         return self",The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses).,This needs to be added to the docstring too
+2529,"@@ -80,7 +80,7 @@ public class PreferencesTest {
+         }
+         clickPreference(R.string.user_interface_label);
+         clickPreference(R.string.pref_set_theme_title);
+-        onView(withText(otherTheme)).perform(click());
++        clickPreference(otherTheme);
+         Awaitility.await().atMost(1000, MILLISECONDS)
+                 .until(() -> UserPreferences.getTheme() != theme);
+     }",Be careful. This is not a preference but an option in a dialog.,I don't understand why you chose to do this
+2530,"@@ -30,8 +30,11 @@ func (s *svc) DescribeDeployment(ctx context.Context, clientset, cluster, namesp
+ }
+
+ func ProtoForDeployment(cluster string, deployment *appsv1.Deployment) *k8sapiv1.Deployment {
++	if deployment.ClusterName == """" {
++		deployment.ClusterName = cluster
++	}
+ 	return &k8sapiv1.Deployment{
+-		Cluster:     cluster,
++		Cluster:     deployment.ClusterName,
+ 		Namespace:   deployment.Namespace,
+ 		Name:        deployment.Name,
+ 		Labels:      deployment.Labels,","this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty","@deads2k @tnozicka honestly, I don't know i"
+2531,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?,`await driver.stop()` is now unnecessary be
+2532,"@@ -121,8 +121,13 @@ Blockly.BlockSvg.INLINE = -1;
+  */
+ Blockly.BlockSvg.prototype.initSvg = function() {
+   goog.asserts.assert(this.workspace.rendered, 'Workspace is headless.');
++  // ""Input shapes"" for each input. Used to draw ""holes"" for unoccupied value inputs.
++  this.inputShapes_ = {};
+   for (var i = 0, input; input = this.inputList[i]; i++) {
+     input.init();
++    if (input.type === Blockly.INPUT_VALUE) {
++      this.initInputShape(input);
++    }
+   }
+   var icons = this.getIcons();
+   for (i = 0; i < icons.length; i++) {",You're using scare quotes on these terms instead of defining them.,Would it make sense to move this to `initInputShape` so that it's not called for each input type?
+2533,"@@ -13,6 +13,9 @@ var DdevVersion = ""v0.3.0-dev"" // Note that this is overridden by make
+ // for examples defining version constraints.
+ var DockerVersionConstraint = "">= 17.05.0-ce""
+
++// DockerComposeVersionConstraint is the current minimum version of docker-compose required for ddev.
++var DockerComposeVersionConstraint = "">= 1.10.0""
++
+ // WebImg defines the default web image used for applications.
+ var WebImg = ""drud/nginx-php-fpm-local"" // Note that this is overridden by make
+ ","These should both be const, not var right?",This should be 1.10.0-ce
+2534,"@@ -78,9 +78,7 @@ public class SettingsManager {
+
+     public void save() {
+         Settings settings = load();
+-        try {
+-            File file = new File(settingsFileName);
+-            OutputStream outputStream = new FileOutputStream(file);
++        try (OutputStream outputStream = new FileOutputStream(new File(settingsFileName))) {
+             DefaultPropertiesPersister persister = new DefaultPropertiesPersister();
+             persister.store(settings.getProperties(), outputStream, ""Phoenicis User Settings"");
+         } catch (Exception e) {",Can you catch a more specific exception here? Thanks :-),Could be replace with try (File file = new File(settingsFileName)) {
+2535,"@@ -80,6 +80,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 			r.Log.Error(err, ""failed to recover chaos"")
+ 			return ctrl.Result{Requeue: true}, nil
+ 		}
++		return ctrl.Result{}, nil
+ 	}
+
+ 	// Start failure action","This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it.",shouldn't this be `ctrl.Result{}`?
+2536,"@@ -11,7 +11,11 @@ from mmcv.runner import get_dist_info
+ from mmdet.core import tensor2imgs
+
+
+-def single_gpu_test(model, data_loader, show=False, out_dir=None):
++def single_gpu_test(model,
++                    data_loader,
++                    show=False,
++                    out_dir=None,
++                    score_thr=0.3):
+     model.eval()
+     results = []
+     dataset = data_loader.dataset","During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better.",can you make this param default to 0.2?
+2537,"@@ -1,7 +1,7 @@
+-<header class=""banner"" role=""banner"">
++<header class=""banner"">
+   <div class=""container"">
+     <a class=""brand"" href=""<?= esc_url(home_url('/')); ?>""><?php bloginfo('name'); ?></a>
+-    <nav role=""navigation"">
++    <nav class=""site-nav"">
+       <?php
+       if (has_nav_menu('primary_navigation')) :
+         wp_nav_menu(['theme_location' => 'primary_navigation', 'menu_class' => 'nav']);","can you make this `nav-primary` please? i'd like to roll with this since the `<ul>` class is `nav`, and primary is the name of the navigation menu",Is there a specific reason why we use `
+2538,"@@ -49,7 +49,16 @@ app.factory('CalendarListItem', function($rootScope, $window, Calendar, WebCal,
+ 			},
+ 			publicSharingURL: {
+ 				get: () => {
+-					return $rootScope.root + 'p/' + context.calendar.publicToken;
++					let displayname = context.calendar.displayname
++						.replace(/\s+/g, '-').replace(/[^\w\-]+/g, '')
++						.replace(/\-\-+/g, '-').replace(/^-+/, '')
++						.replace(/-+$/, '');
++
++					if (displayname === '') {
++						return $rootScope.root + 'p/' + context.calendar.publicToken;
++					} else {
++						return $rootScope.root + 'p/' + context.calendar.publicToken + '/' + displayname;
++					}
+ 				}
+ 			},
+ 			publicEmbedURL: {",@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?,shouldn't we use the DisplayName proper
+2539,"@@ -292,7 +292,7 @@ HashedCollectionConfig::SwiftObjectAtAddress(
+   if (error.Fail())
+     return nullptr;
+
+-  CompilerType anyObject_type = ast_ctx->FindQualifiedType(""Swift.AnyObject"");
++  CompilerType anyObject_type = ast_ctx->GetAnyObjectType();
+   if (!anyObject_type)
+     return nullptr;
+ ","I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method.",Is this a drive-by fix for the compiler
+2540,"@@ -81,7 +81,8 @@ Blockly.FlyoutExtensionCategoryHeader.prototype.createDom = function() {
+   var marginX = 15;
+   var marginY = 10;
+
+-  var statusButtonX = (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale;
++  var statusButtonX = this.workspace_.RTL ? (marginX - this.flyoutWidth_ + statusButtonWidth) :
++      (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale;
+
+   if (this.imageSrc_) {
+     /** @type {SVGElement} */",Why are you dividing by scale in the LTR case but not the RTL case?,Shouldn't this be `this.flyoutWidth_ + statusButtonWidth`?
+2541,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,Does this need to be added to the dashboard?
+2542,"@@ -61,8 +61,8 @@ export default function createLegacySettingsWrapper( moduleSlug, moduleComponent
+ 		useEffect( () => {
+ 			removeAllFilters( `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` );
+ 			addFilter(
+-				'googlesitekit.ModuleSettingsDetails-tagmanager',
+-				'googlesitekit.TagManagerModuleSettings',
++				`googlesitekit.ModuleSettingsDetails-${ moduleSlug }`,
++				'googlesitekit.SettingsLegacy',
+ 				fillFilterWithComponent( moduleComponent )
+ 			);
+ 			return () => removeAllFilters( `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` );",I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules  ,Should we remove these old filters as well?
+2543,"@@ -33,12 +33,15 @@ package azkaban;
+ public class Constants {
+
+   // Azkaban Flow Versions
+-  public static final String AZKABAN_FLOW_VERSION_2_0 = ""2.0"";
++  public static final double VERSION_2_0 = 2.0;
+
+   // Flow 2.0 file suffix
+   public static final String PROJECT_FILE_SUFFIX = "".project"";
+   public static final String FLOW_FILE_SUFFIX = "".flow"";
+
++  // Flow 2.0 node type
++  public static final String FLOW_NODE_TYPE = ""flow"";
++
+   // Names and paths of various file names to configure Azkaban
+   public static final String AZKABAN_PROPERTIES_FILE = ""azkaban.properties"";
+   public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";",isn't AZKABAN_FLOW_VERSION_2_0 more explicit?,why not `FLOW_NODE_TYPE_2_0`?
+2544,"@@ -308,9 +308,7 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
+                 /*case ONEDRIVE:
+                     signInOneDrive();
+                     break;*/
+-
+-                default:
+-                    SnackBarHandler.show(coordinatorLayout, R.string.feature_not_present);
++                default://do nothing
+             }
+         } else {
+             AlertDialog alertDialog = new AlertDialog.Builder(this)",Please don't leave an empty default,is there a way to keep this empty line?
+2545,"@@ -15,6 +15,7 @@
+  * See the License for the specific language governing permissions and
+  * limitations under the License.
+  */
++
+ /**
+  * External dependencies
+  */","This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`.",Nit: Unnecessary new line.
+2546,"@@ -84,7 +84,9 @@ module Travis
+             sh.cmd 'sudo chmod 2777 /usr/local/lib/R /usr/local/lib/R/site-library'
+
+           when 'osx'
+-            sh.cmd 'brew update', retry: true
++            # We want to update, but we don't need the 800+ lines of
++            # output.
++            sh.cmd 'brew update >/dev/null', retry: true
+
+             # Install from latest CRAN binary build for OS X
+             sh.cmd ""wget #{config[:cran]}/bin/macosx/R-latest.pkg "" +",You can also use `echo: false` instead. Either is fine; I'm just pointing it out.,"yes, in my opinion, we should still use"
+2547,"@@ -115,12 +115,13 @@ namespace NLog.Layouts
+         /// </summary>
+         protected override void InitializeLayout()
+         {
+-            base.InitializeLayout();
+             if (!WithHeader)
+             {
+                 Header = null;
+             }
+
++            base.InitializeLayout();
++
+             switch (Delimiter)
+             {
+                 case CsvColumnDelimiterMode.Auto:",what's the reason for this moved line?,Why is this being made public?
+2548,"@@ -986,6 +986,10 @@ import 'programStyles';
+                 lines = [];
+             }
+
++            if (overlayText && showTitle) {
++                lines = [item.Name];
++            }
++
+             const addRightTextMargin = isOuterFooter && options.cardLayout && !options.centerText && options.cardFooterAside !== 'none' && layoutManager.mobile;
+
+             html += getCardTextLines(lines, cssClass, !options.overlayText, isOuterFooter, options.cardLayout, addRightTextMargin, options.lines);","I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?",Shouldn't above also be `options.lines`?
+2549,"@@ -97,10 +97,10 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+             out int startLineNumber,
+             out int endLineNumber)
+         {
+-            var startPoint = methodDebugDefinition.GetSequencePoints().OrderBy(s => s.StartLine).FirstOrDefault();
++            var startPoint = methodDebugDefinition.GetSequencePoints().OrderBy(s => s.StartLine).FirstOrDefault(s => s.IsHidden == false);
+             startLineNumber = startPoint.StartLine;
+             var endPoint =
+-                methodDebugDefinition.GetSequencePoints().OrderByDescending(s => s.StartLine).FirstOrDefault();
++                methodDebugDefinition.GetSequencePoints().OrderByDescending(s => s.StartLine).FirstOrDefault(s => s.IsHidden == false);
+             endLineNumber = endPoint.StartLine;
+         }
+ ",`s => s.IsHidden == false` What's the purpose of adding this?,Should we add `OrderByDescending` to `Me
+2550,"@@ -45,6 +45,7 @@ const (
+ 	optionNameGatewayMode          = ""gateway-mode""
+ 	optionNameClefSignerEnable     = ""clef-signer-enable""
+ 	optionNameClefSignerEndpoint   = ""clef-signer-endpoint""
++	optionNameClefSignerAddress    = ""clef-signer-address""
+ 	optionNameSwapEndpoint         = ""swap-endpoint""
+ 	optionNameSwapFactoryAddress   = ""swap-factory-address""
+ 	optionNameSwapInitialDeposit   = ""swap-initial-deposit""","I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address",The option name is a bit misleading. It
+2551,"@@ -202,6 +202,7 @@ class TestCase(unittest.TestCase):
+         # ofile.write(mb)
+         # ofile.close()
+
++    #@unittest.skip
+     def test6ChangeBondLength(self):
+         m = Chem.MolFromSmiles('CC')
+         rdDepictor.Compute2DCoords(m)",you can just remove this,If you don't need the @unittest.skip the
+2552,"@@ -297,6 +297,13 @@ func buildUpgradeTask(kind, name, openebsNamespace string) *apis.UpgradeTask {
+ 				PoolName: name,
+ 			},
+ 		}
++	case ""storagePoolClaim"":
++		utaskObj.Name = ""upgrade-cstor-pool-"" + name
++		utaskObj.Spec.ResourceSpec = apis.ResourceSpec{
++			StoragePoolClaim: &apis.StoragePoolClaim{
++				SPCName: name,
++			},
++		}
+ 	case ""cstorVolume"":
+ 		utaskObj.Name = ""upgrade-cstor-volume-"" + name
+ 		utaskObj.Spec.ResourceSpec = apis.ResourceSpec{",I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR.,why do we need to have this in the first place?
+2553,"@@ -7,6 +7,10 @@
+   <%= render 'trails' %>
+ </section>
+
++<% if locked_features.any? %>
++  <%= render 'locked_features' %>
++<% end %>
++
+ <% if current_user_has_access_to?(:exercises) %>
+   <p class=""product-headline"">Hone your skills by completing these exercises</p>
+   <%= render 'products/exercises' %>","Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?",This should be `if locked_features.present?`
+2554,"@@ -70,7 +70,7 @@ def run(args):
+         sys.exit(usertypes.Exit.ok)
+
+     if args.temp_basedir:
+-        args.basedir = tempfile.mkdtemp()
++        args.basedir = tempfile.mkdtemp(prefix='qutebrowser-prefix-')
+
+     quitter = Quitter(args)
+     objreg.register('quitter', quitter)","As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`",What's the point of this change?
+2555,"@@ -40,7 +40,8 @@ namespace Nethermind.Db
+
+         public DbOnTheRocks(string basePath, string dbPath, IDbConfig dbConfig, ILogManager logManager = null) // TODO: check column families
+         {
+-            var fullPath = Path.Combine(basePath, dbPath);
++            var directory = PathUtils.GetExecutingDirectory();
++            var fullPath = Path.Combine(directory, basePath, dbPath);
+             var logger = logManager?.GetClassLogger();
+             if (!Directory.Exists(fullPath))
+             {",basepath can be absoluta path and this needs to be supported,nit: `basePath` could be nullable
+2556,"@@ -280,7 +280,7 @@ void ConfigPanelWidget::updateIconThemeSettings()
+ void ConfigPanelWidget::addPosition(const QString& name, int screen, LXQtPanel::Position position)
+ {
+     if (LXQtPanel::canPlacedOn(screen, position))
+-        ui->comboBox_position->addItem(name, QVariant::fromValue((ScreenPosition){screen, position}));
++        ui->comboBox_position->addItem(name, QVariant::fromValue(ScreenPosition{screen, position}));
+ }
+
+ ",Didn't get to the commit message,Should be const QString& name
+2557,"@@ -0,0 +1,14 @@
++class DesignForDevelopersResourcesController < ApplicationController
++  layout ""d4d_resources""
++
++  def index
++  end
++
++  def show
++    if template_exists?(params[:id], params[:controller])
++      render params[:id]
++    else
++      raise ActiveRecord::RecordNotFound
++    end
++  end
++end",What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does.,Layout/EmptyLinesAroundClassB
+2558,"@@ -527,6 +527,7 @@ void nano::json_handler::account_balance ()
+ 		auto balance (node.balance_pending (account, include_only_confirmed));
+ 		response_l.put (""balance"", balance.first.convert_to<std::string> ());
+ 		response_l.put (""pending"", balance.second.convert_to<std::string> ());
++		response_l.put (""receivable"", balance.second.convert_to<std::string> ());
+ 	}
+ 	response_errors ();
+ }",Is it kept for compatibility?,Shouldn't this be `receivable
+2559,"@@ -537,10 +537,16 @@ func (m *StorageMinerNodeConnector) getMinerWorkerAddress(ctx context.Context, t
+ 		return address.Undef, xerrors.Errorf(""failed to get tip state: %w"", err)
+ 	}
+
+-	_, waddr, err := m.stateViewer.StateView(root).MinerControlAddresses(ctx, m.minerAddr)
++	view := m.stateViewer.StateView(root)
++	_, waddr, err := view.MinerControlAddresses(ctx, m.minerAddr)
+ 	if err != nil {
+ 		return address.Undef, xerrors.Errorf(""failed to get miner control addresses: %w"", err)
+ 	}
+
+-	return waddr, nil
++	workerSigner, err := view.AccountSignerAddress(ctx, waddr)
++	if err != nil {
++		return address.Undef, xerrors.Errorf(""failed to lookup signing address for worker address: %s: %w"", waddr.String(), err)
++	}
++
++	return workerSigner, nil
+ }",I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together.,Nit: `failed to lookup signin
+2560,"@@ -310,6 +310,10 @@ class DBUpgrader {
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS +
+                     "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_SKIP_ENDING + "" INTEGER DEFAULT 0;"");
+         }
++        if (oldVersion < 1090001) { // fixme / todo: fix  version
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS +
++                    "" ADD COLUMN "" + PodDBAdapter.KEY_EPISODE_NOTIFICATION + "" INTEGER DEFAULT 0;"");
++        }
+     }
+
+ }","It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`.","just curious, why do we need to add a column in the table name?"
+2561,"@@ -150,7 +150,7 @@ func (task *UpdateTask) execCQLStmts(ver string, stmts []string) error {
+ 		log.Println(rmspaceRegex.ReplaceAllString(stmt, "" ""))
+ 		e := task.db.Exec(stmt)
+ 		if e != nil {
+-			return fmt.Errorf(""error executing CQL statement:%v"", e)
++			return fmt.Errorf(""error executing statement:%v"", e)
+ 		}
+ 	}
+ 	log.Printf(""---- Done ----\n"")",What about method name itself? Do we run this for SQL too?,is this a typo?
+2562,"@@ -42,7 +42,7 @@ public class SalesforceHybridTestActivity extends SalesforceDroidGapActivity {
+ 	static String refreshToken = ""5Aep861KIwKdekr90IDidO4EhfJiYo3fzEvTvsEgM9sfDpGX0qFFeQzHG2mZeUH_.XNSBE0Iz38fnWsyYYkUgTz"";
+ 	static String authToken = ""--will-be-set-through-refresh--"";
+ 	static String identityUrl = ""https://test.salesforce.com"";
+-	static String instanceUrl = ""https://cs1.salesforce.com"";
++	static String instanceUrl = ""https://mobilesdk.cs1.my.salesforce.com"";
+ 	static String loginUrl = ""https://test.salesforce.com"";
+ 	static String orgId = ""00DS0000003E98jMAC"";
+ 	static String userId = ""005S0000004s2iyIAA"";",`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`.,"Shouldn't this be ""my.salesforce.com""?"
+2563,"@@ -200,7 +200,10 @@ adios2_error adios2_variable_name(char *name, size_t *size,
+         const adios2::core::VariableBase *variableBase =
+             reinterpret_cast<const adios2::core::VariableBase *>(variable);
+         *size = variableBase->m_Name.size();
+-        variableBase->m_Name.copy(name, *size);
++        if (name)
++        {
++            variableBase->m_Name.copy(name, *size);
++        }
+         return adios2_error_none;
+     }
+     catch (...)",Let's use `if(name != nullptr)` to remove ambiguity,Could this break something?
+2564,"@@ -1027,4 +1027,12 @@ public class SurfaceNamer extends NameFormatterDelegator {
+   public String getReleaseAnnotation(ReleaseLevel releaseLevel) {
+     return getNotImplementedString(""SurfaceNamer.getReleaseAnnotation"");
+   }
++
++  public String getMetadataIdentifier() {
++    return getNotImplementedString(""SurfaceNamer.getMetadataIdentifier"");
++  }
++
++  public String getMetadataName() {
++    return getNotImplementedString(""SurfaceNamer.getMetadataName"");
++  }
+ }","I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`.","Same as above, why do these not exist in `SurfaceNamer`?"
+2565,"@@ -37,6 +37,15 @@ import org.apache.logging.log4j.Logger;
+ public class BftValidatorsValidationRule implements AttachedBlockHeaderValidationRule {
+
+   private static final Logger LOGGER = LogManager.getLogger();
++  private final boolean extraDataValidatorsAndVoteMustBeEmpty;
++
++  public BftValidatorsValidationRule() {
++    this(false);
++  }
++
++  public BftValidatorsValidationRule(final boolean extraDataValidatorsAndVoteMustBeEmpty) {
++    this.extraDataValidatorsAndVoteMustBeEmpty = extraDataValidatorsAndVoteMustBeEmpty;
++  }
+
+   @Override
+   public boolean validate(",This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance.,What is the extra data validator andVoteMustBeEmpty? Why
+2566,"@@ -163,6 +163,15 @@ public interface Set<T> extends Traversable<T>, Function1<T, Boolean>, Serializa
+      */
+     Set<T> removeAll(Iterable<? extends T> elements);
+
++    /**
++     * Reverse the order of all given elements in this set, if present.
++     *
++     * @return A new set consisting of the elements in reverse order of this set
++     */
++    default Set<T> reverse() {
++        throw new UnsupportedOperationException(""Operation not supported"");
++    }
++
+     /**
+      * Converts this Vavr {@code Set} to a {@code java.util.Set} while preserving characteristics
+      * like insertion order ({@code LinkedHashSet}) and sort order ({@code SortedSet}).","This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue.",This should be `UnsupportedOperationException`.
+2567,"@@ -366,6 +366,10 @@ class S3Connection(AWSAuthConnection):
+         if version_id is not None:
+             params['VersionId'] = version_id
+
++        if response_headers is not None:
++            for header, value in response_headers.items():
++                params[header] = value
++
+         http_request = self.build_base_http_request(method, path, auth_path,
+                                                     headers=headers, host=host,
+                                                     params=params)",we can replace `for` with `params.update(response_headers)`,"For readability, could this fit on one line?"
+2568,"@@ -118,13 +118,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Https
+                 return certificate2;
+             }
+
+-#if NETSTANDARD1_3
+-            // conversion X509Certificate to X509Certificate2 not supported
+-            // https://github.com/dotnet/corefx/issues/4510
+             return null;
+-#else
+-            return new X509Certificate2(certificate);
+-#endif
+         }
+
+         private class HttpsAdaptedConnection : IAdaptedConnection",Any chance this is available in .NET Core 2.0 now?,Shouldn't we just remove this whole class now?
+2569,"@@ -8,16 +8,15 @@ package blocksync
+
+ import (
+ 	""context""
+-	""net""
+
+ 	""github.com/golang/protobuf/proto""
++	peerstore ""github.com/libp2p/go-libp2p-peerstore""
+ 	""go.uber.org/zap""
+
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""
+ 	""github.com/iotexproject/iotex-core/config""
+-	""github.com/iotexproject/iotex-core/p2p/node""
+ 	""github.com/iotexproject/iotex-core/pkg/lifecycle""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/routine""","I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?",PeerStore is already part of the repo. please
+2570,"@@ -26,8 +26,11 @@
+
+ #define LBANN_INPUT_LAYER_INSTANTIATE
+ #include ""lbann/layers/io/input_layer.hpp""
+-#include ""lbann/utils/profiling.hpp""
++
+ #include ""lbann/callbacks/imcomm.hpp""
++#include ""lbann/execution_contexts/execution_context.hpp""
++#include ""lbann/execution_contexts/sgd_execution_context.hpp""
++#include ""lbann/utils/profiling.hpp""
+ #include ""lbann/utils/serialize.hpp""
+
+ namespace lbann {",Why do we need both includes here?,Better to have the context included in `lbann/
+2571,"@@ -600,7 +600,7 @@ public class SmartStore  {
+ 	    	List<String> soupNames = new ArrayList<String>();
+ 	        Cursor cursor = null;
+ 			try {
+-				cursor = DBHelper.getInstance(db).query(db, SOUP_NAMES_TABLE, new String[]{SOUP_NAME_COL}, null, null, null);
++				cursor = DBHelper.getInstance(db).query(db, SOUP_NAMES_TABLE, new String[]{SOUP_NAME_COL}, SOUP_NAME_COL, null, null);
+ 	            if (cursor.moveToFirst()) {
+ 	                do {
+ 	                    soupNames.add(cursor.getString(0));",SmartStoreInspectorTest expected results in a certain order,"Please extract a `private query(final DB db, f"
+2572,"@@ -310,6 +310,11 @@ const conduit::Node& data_reader_jag_conduit::get_conduit_node(const conduit::No
+ }
+
+ bool data_reader_jag_conduit::load_conduit_node(const size_t i, const std::string& key, conduit::Node& node) const {
++
++  if (m_io_thread_pool != nullptr && m_using_random_node.count(m_io_thread_pool->get_local_thread_id())) {
++    LBANN_ERROR(""previously retrieved a random conduit node from data_store, so shouldn't be here"");
++  }
++
+   const sample_t& s = m_sample_list[i];
+   const std::string& sample_name = s.second;
+   const std::string path = sample_name + key;",I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`,Would it not be better to check the m_using_random_node?
+2573,"@@ -175,6 +175,9 @@ public class UnusedAssignmentRule extends AbstractJavaRule {
+                 if (isIgnorablePrefixIncrement(entry.rhs)) {
+                     continue;
+                 }
++                if (isUsedLocalVarWithoutInitializer(entry, result.usedVariables)) {
++                    continue;
++                }
+
+                 Set<AssignmentEntry> killers = result.killRecord.get(entry);
+                 final String reason;","I don't think we need to maintain a separate set. The problem here is that the ""assignment"" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix.",Could you rename `usedVariables` to something more meani
+2574,"@@ -209,4 +209,9 @@ public interface TableScan {
+    */
+   boolean isCaseSensitive();
+
++  /**
++   * Returns the target split size for this scan.
++   */
++  long targetSplitSize();
++
+ }","Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic.",Please call this field `targetSplitSize`
+2575,"@@ -1550,7 +1550,8 @@ func (c *client) flushSignal() {
+ func (c *client) traceMsg(msg []byte) {
+ 	maxTrace := c.srv.getOpts().MaxTracedMsgLen
+ 	if maxTrace > 0 && (len(msg)-LEN_CR_LF) > maxTrace {
+-		c.Tracef(""<<- MSG_PAYLOAD: [\""%s...\""]"", msg[:maxTrace])
++		tm := fmt.Sprintf(""%q"", msg[:maxTrace])
++		c.Tracef(""<<- MSG_PAYLOAD: [\""%s...\""]"", tm[1:maxTrace+1])
+ 	} else {
+ 		c.Tracef(""<<- MSG_PAYLOAD: [%q]"", msg[:len(msg)-LEN_CR_LF])
+ 	}",Not sure what is this change doing?,"I think this should be `tm := fmt.Sprintf(""%q"", msg[:max"
+2576,"@@ -272,8 +272,9 @@ def revoke_user_code_tokens(user):
+         db.session.delete(code)
+     revoke_tokens(user)
+
+-def get_exp(mins=30):
+-    return datetime.utcnow() + timedelta(minutes=mins)
++def get_exp(mins=None):
++    delta = timedelta(minutes=mins) if mins is not None else timedelta(days=90)
++    return datetime.utcnow() + delta
+
+ def issue_token(user, exp=None):
+     uuid = generate_uuid()","this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default.",E303 too many blank lines (2)
+2577,"@@ -267,6 +267,11 @@ public final class RememberMeConfigurer<H extends HttpSecurityBuilder<H>>
+ 		validateInput();
+ 		String key = getKey();
+ 		RememberMeServices rememberMeServices = getRememberMeServices(http, key);
++		if (key == null) {
++			if (rememberMeServices instanceof AbstractRememberMeServices) {
++			    key = ((AbstractRememberMeServices) rememberMeServices).getKey();
++			}
++		}
+ 		http.setSharedObject(RememberMeServices.class, rememberMeServices);
+ 		LogoutConfigurer<H> logoutConfigurer = http.getConfigurer(LogoutConfigurer.class);
+ 		if (logoutConfigurer != null && this.logoutHandler != null) {",Please use a tab for indentation instead of spaces.,I don't think this logic shou
+2578,"@@ -40,7 +40,7 @@ import java.util.stream.Collector;
+  * @since 2.0.0
+  */
+ @SuppressWarnings(""deprecation"")
+-public final class Queue<T> extends AbstractsQueue<T, Queue<T>> implements LinearSeq<T>, Kind1<Queue<T>, T> {
++public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements LinearSeq<T>, Kind1<Queue<T>, T> {
+
+     private static final long serialVersionUID = 1L;
+ ",I can't believe we didn't see this typo before :)),What's wrong with `AbstractsQ
+2579,"@@ -25,6 +25,9 @@ from Queue import Empty, Queue
+ from google.cloud.forseti.services.inventory.base import crawler
+ from google.cloud.forseti.services.inventory.base import gcp
+ from google.cloud.forseti.services.inventory.base import resources
++from google.cloud.forseti.common.util import log_util
++
++LOGGER = log_util.get_logger(__name__)
+
+
+ class CrawlerConfig(crawler.CrawlerConfig):","If the logger isn't used, it probably doesn't need to be added.",Just use `log_util.get_logger
+2580,"@@ -0,0 +1,4 @@
++var script = document.createElement('script')
++script.type = 'text/javascript'
++script.src = '{}'
++document.head.appendChild(script)",These files should in `/javascript/brython`,This is going to generate a lot of warnings. Just set `script.src = '{}'` instead.
+2581,"@@ -54,11 +54,15 @@ func (ci *CreateImages) UnmarshalJSON(b []byte) error {
+
+ func imageUsesAlphaFeatures(imagesAlpha []*ImageAlpha) bool {
+ 	for _, imageAlpha := range imagesAlpha {
+-		if imageAlpha != nil && len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 {
+-			return true
++		if imageAlpha != nil && imageAlpha.RolloutOverride != nil {
++			if len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 {
++				return true
++			}
+ 		}
+-		if imageAlpha != nil && len(imageAlpha.Deprecated.StateOverride.DefaultRolloutTime) > 0 {
+-			return true
++		if imageAlpha != nil && imageAlpha.Deprecated != nil && imageAlpha.Deprecated.StateOverride != nil {
++			if len(imageAlpha.Deprecated.StateOverride.DefaultRolloutTime) > 0 {
++				return true
++			}
+ 		}
+ 	}
+ 	return false","minor, you can squash these into one `if`",Shouldn't we check for imageAlpha.Deprecated.StateOverride here?
+2582,"@@ -73,7 +73,7 @@ func (s *transmissionTaskSuite) TearDownTest() {
+
+ func (s *transmissionTaskSuite) TestHandleTransmissionTask_RegisterNamespaceTask_IsGlobalNamespace() {
+ 	taskType := replicationgenpb.ReplicationTaskType_NamespaceTask
+-	id := primitives.NewUUID()
++	id := primitives.NewUUID().String()
+ 	name := ""some random namespace test name""
+ 	status := namespacepb.NamespaceStatus_Registered
+ 	description := ""some random test description""","Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`.",Why we need this change?
+2583,"@@ -581,7 +581,7 @@ namespace pwiz.Skyline.Controls.Graphs
+                     requestContext.Settings = null;
+                 }
+
+-                if (GraphSummary.IsHandleCreated)
++                if (GraphSummary.IsHandleCreated && !GraphSummary.Disposing)
+                 {
+                     try
+                     {",Add a TODO here to revisit if this was problematic.,@mjkkirschner @QilongTang @aparajit-pratap @reddyashish I don't know if this is th
+2584,"@@ -23,7 +23,11 @@ class SSDHead(AnchorHead):
+         anchor_generator (dict): Config dict for anchor generator
+         bbox_coder (dict): Config of bounding box coder.
+         reg_decoded_bbox (bool): If true, the regression loss would be
+-            applied on decoded bounding boxes. Default: False
++            applied directly on decoded bounding boxes, meaning both the
++            predicted boxes and regression targets are with absolute
++            coordinates format. Default False. Note generally it should be
++            set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`
++            in the bbox head.
+         train_cfg (dict): Training config of anchor head.
+         test_cfg (dict): Testing config of anchor head.
+     """"""  # noqa: W605",Note generally it -> It,"Maybe add a note that `reg_decoded_bbox` is set to `True` when using IOULoss, `GIouloss` and `DIouloss` in the bbox head?"
+2585,"@@ -51,6 +51,7 @@ model* instantiate_model(lbann_comm* comm,
+   if (type == ""directed_acyclic_graph_model"") {
+     return new directed_acyclic_graph_model(comm, mini_batch_size, obj, opt);
+   }
++#if 0
+   if (type == ""recurrent_model"") {
+     const auto& params = proto_model.recurrent();
+     return new recurrent_model(comm,",Is this relevant to this PR?,Remove this whole block.
+2586,"@@ -102,7 +102,7 @@ module Beaker
+         end
+         if block_hosts.is_a? Array
+           if block_hosts.length > 0
+-            if opts[:run_in_parallel]
++            if opts[:run_in_parallel] == true
+               # Pass caller[1] - the line that called block_on - for logging purposes.
+               result = block_hosts.map.each_in_parallel(caller[1]) do |h|
+                 run_block_on h, &block","Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement.",Rails/Present: Use if options[:run_in_parallel] is true.
+2587,"@@ -25,6 +25,11 @@ import (
+ 	""go.opentelemetry.io/otel/codes""
+ )
+
++var (
++	HTTPSchemeHTTP  = HTTPSchemeKey.String(""http"")
++	HTTPSchemeHTTPS = HTTPSchemeKey.String(""https"")
++)
++
+ // NetAttributesFromHTTPRequest generates attributes of the net
+ // namespace as specified by the OpenTelemetry specification for a
+ // span.  The network parameter is a string that net.Dial function",Is this just moved out of the other files? It doesn't seem like this was generated like the other files.,Nit: should we have this constant in `libbeat/opentelemetry/pkg/config`?
+2588,"@@ -0,0 +1,14 @@
++using System.IO;
++using System.Threading.Tasks;
++
++namespace HttpOverStream
++{
++    internal interface IHttpContent
++    {
++        long? Length { get; }
++
++        void CopyTo(Stream destination);
++
++        Task CopyToAsync(Stream destination);
++    }
++}","I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions.",I'd call this `CopyToAsync` otherwise it sounds like we're not copying anything.
+2589,"@@ -98,7 +98,9 @@ namespace Nethermind.Mev.Test
+             protected override IBlockProducer CreateTestBlockProducer(TxPoolTxSource txPoolTxSource, ISealer sealer, ITransactionComparerProvider transactionComparerProvider)
+             {
+                 MiningConfig miningConfig = new() {MinGasPrice = UInt256.One};
+-
++
++                MevBlockProducerTransactionsExecutorFactory mevExecutorFactory = new(SpecProvider, LogManager);
++
+                 BlockProducerEnvFactory blockProducerEnvFactory = new(
+                     DbProvider,
+                     BlockTree, ",this looks already too complicated...,Can mevExecutorFactory be created in the ctor instead?
+2590,"@@ -176,6 +176,18 @@ TEST(RocksEngineTest, OptionTest) {
+             engine->setDBOption(""max_background_compactions"", ""bad_value""));
+ }
+
++TEST(RocksEngineTest, CompactTest) {
++    fs::TempDir rootPath(""/tmp/rocksdb_compact_test.XXXXXX"");
++    auto engine = std::make_unique<RocksEngine>(0, rootPath.path());
++    std::vector<KV> data;
++    for (int32_t i = 2; i < 8;  i++) {
++        data.emplace_back(folly::stringPrintf(""key_%d"", i),
++                          folly::stringPrintf(""value_%d"", i));
++    }
++    EXPECT_EQ(ResultCode::SUCCEEDED, engine->multiPut(std::move(data)));
++    EXPECT_EQ(ResultCode::SUCCEEDED, engine->compactAll());
++}
++
+ }  // namespace kvstore
+ }  // namespace nebula
+ ","As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future.",Can you use a `const std::string&` for the test name instead?
+2591,"@@ -85,7 +85,9 @@ public class Catalog implements AutoCloseable {
+       if (tableMap == null) {
+         tableMap = loadTables(db);
+       }
+-      return ImmutableList.copyOf(tableMap.values());
++      Collection<TiTableInfo> tables = tableMap.values();
++      tables.removeIf(TiTableInfo::isView);
++      return ImmutableList.copyOf(tables);
+     }
+
+     public TiTableInfo getTable(TiDBInfo db, String tableName) {",should we add a TODO here?,`ImmutableList.copyOf` -> `ImmutableList.copyOf`
+2592,"@@ -35,14 +35,12 @@ import { Component, render } from '@wordpress/element';
+ import { loadTranslations } from './util';
+ import './components/notifications';
+ import DashboardDetailsApp from './components/dashboard-details/dashboard-details-app';
+-import ErrorHandler from './components/ErrorHandler';
++import Root from './components/root';
+
+ class GoogleSitekitDashboardDetails extends Component {
+ 	render() {
+ 		return (
+-			<ErrorHandler>
+-				<DashboardDetailsApp />
+-			</ErrorHandler>
++			<DashboardDetailsApp />
+ 		);
+ 	}
+ }",This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now.,"In the current implementation, `dashboard-details` component is only rendered if there is error, so no need to render an error."
+2593,"@@ -191,7 +191,7 @@ func (s *nDCTransactionMgrSuite) TestBackfillWorkflow_CurrentWorkflow_Active_Clo
+ 	versionHistory := versionhistory.New([]byte(""branch token""), []*historyspb.VersionHistoryItem{
+ 		{EventId: lastWorkflowTaskStartedEventID, Version: lastWorkflowTaskStartedVersion},
+ 	})
+-	histories := versionhistory.NewVHS(versionHistory)
++	histories := versionhistory.NewVersionHistories(versionHistory)
+
+ 	releaseCalled := false
+ ",NewVHS -> NewVersionHistories this one looks better,why is this changing?
+2594,"@@ -36,10 +36,17 @@ module Selenium
+       SOCKET_LOCK_TIMEOUT = 45
+       STOP_TIMEOUT        = 20
+
++      @executable = nil
++      @missing = ''
++
++      class << self
++        attr_accessor :executable, :missing_text
++      end
++
+       attr_accessor :host
+
+       def initialize(executable_path, port, *extra_args)
+-        @executable_path = executable_path
++        @executable_path = binary_path(executable_path)
+         @host            = Platform.localhost
+         @port            = Integer(port)
+         @extra_args      = extra_args",Is this `@missing_text` ?,"How would you feel about renaming `executable_path` to `executable_name` or something similar, so that it's not confused with `"
+2595,"@@ -25,6 +25,7 @@ CONFIG_PATH = BASE_PATH / 'config.yml'
+ OPEN_DATA_URL = ""https://open.quiltdata.com""
+
+ PACKAGE_NAME_FORMAT = r""[\w-]+/[\w-]+$""
++SUBPACKAGE_NAME_FORMAT = r""([\w-]+/[\w-]+)(?:/(.+))?$""
+
+ ## CONFIG_TEMPLATE
+ # Must contain every permitted config key, as well as their default values (which can be 'null'/None).","Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path.",why not `^` and `^-`?
+2596,"@@ -56,9 +56,9 @@ module.exports = class FileCard extends Component {
+       {this.props.fileCardFor &&
+         <div style=""width: 100%; height: 100%;"">
+           <div class=""uppy-DashboardContent-bar"">
+-            <h2 class=""uppy-DashboardContent-title"">Editing <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
+-            <button class=""uppy-DashboardContent-back"" type=""button"" title=""Finish editing file""
+-              onclick={this.handleClick}>Done</button>
++            <h2 class=""uppy-DashboardContent-title"">{this.props.i18n('editing')} <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
++            <button class=""uppy-DashboardContent-back"" type=""button"" title={this.props.i18n('finishEditingFile')}
++              onclick={this.handleClick}>{this.props.i18n('done')}</button>
+           </div>
+           <div class=""uppy-DashboardFileCard-inner"">
+             <div class=""uppy-DashboardFileCard-preview"" style={{ backgroundColor: getFileTypeIcon(file.type).color }}>","we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `<span/>` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho.","Shouldn't this be ""finish editing file""?"
+2597,"@@ -254,6 +254,9 @@ fpga_result enum_thermalmgmt_metrics(fpga_metric_vector *vector,
+
+ 	for (i = 0; i < pglob.gl_pathc; i++) {
+
++		if (!pglob.gl_pathv)
++			continue;
++
+ 		char *dir_name = strrchr(pglob.gl_pathv[i], '/');
+
+ 		if (!dir_name)",Probably want break instead of continue.,It looks like pglob.gl_pathv is only use
+2598,"@@ -305,7 +305,7 @@ func testMQTTDefaultOptions() *Options {
+
+ func testMQTTRunServer(t testing.TB, o *Options) *Server {
+ 	t.Helper()
+-	o.NoLog = false
++	o.NoLog = true
+ 	if o.StoreDir == _EMPTY_ {
+ 		o.StoreDir = createDir(t, ""mqtt_js"")
+ 	}",This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?,Why is this change needed?
+2599,"@@ -83,11 +83,11 @@ public final class StringBuilderConstantParameters
+                     .build();
+         }
+         List<ExpressionTree> arguments = result.get();
+-        Stream<String> prefixStream = arguments.stream().findFirst()
++        Stream<String> prefixStream = arguments.stream()
++                .findFirst()
+                 .map(ASTHelpers::getType)
+-                .filter(type ->
+-                        ASTHelpers.isSameType(type, state.getTypeFromString(""java.lang.String""), state))
+-                .map(ignored -> Stream.<String>of())
++                .filter(type -> ASTHelpers.isSameType(type, state.getTypeFromString(""java.lang.String""), state))
++                .map(ignored -> Stream.<String>empty())
+                 .orElseGet(() -> Stream.of(""\""\""""));
+
+         return buildDescription(tree)",does adding a `Stream.<String>empty()` help here?,Please don't make unrelated changes in y
+2600,"@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
+     {'name': 'cloudsql_acl', 'enabled': False},
+     {'name': 'iam_policy', 'enabled': True}
+ ]}
++
++NONEXISTENT_ENABLED = {'scanners': [
++    {'name': 'bigquery', 'enabled': False},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': False},
++    {'name': 'non_exist_scanner', 'enabled': True}
++]}
++
++ALL_EXIST = {'scanners': [
++    {'name': 'bigquery', 'enabled': True},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': True},
++    {'name': 'iam_policy', 'enabled': True}
++]}","This is not being used anymore, so can be removed.","I think we can remove this, I don't think it's used anywhere."
+2601,"@@ -127,6 +127,17 @@ type PodIPs struct {
+ 	ipStrings []string
+ }
+
++func (p PodIPs) String() string {
++	res := """"
++	if p.ipv4 != nil {
++		res += fmt.Sprintf(""IPv4: %s, "", p.ipv4.String())
++	}
++	if p.ipv6 != nil {
++		res += fmt.Sprintf(""IPv6: %s, "", p.ipv6.String())
++	}
++	return fmt.Sprintf(""%sIP strings: %s"", res, strings.Join(p.ipStrings, "", ""))
++}
++
+ func (p *PodIPs) hasSameIP(p1 *PodIPs) bool {
+ 	if len(p.ipStrings) == 0 && len(p1.ipStrings) == 0 {
+ 		return true",Is it called some where?,"IPv6 is kind of a weird name, maybe `IPv6: %s, ` or just `IPv"
+2602,"@@ -20,10 +20,11 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""fmt""
+-	. ""github.com/openebs/maya/pkg/msg/v1alpha1""
++	""reflect""
++
++	_ ""github.com/openebs/maya/pkg/msg/v1alpha1""
+ 	ft ""k8s.io/client-go/third_party/forked/golang/template""
+ 	jp ""k8s.io/client-go/util/jsonpath""
+-	""reflect""
+ )
+
+ type selection struct {",Please remove this extra blank line.,why did you change this?
+2603,"@@ -176,7 +176,7 @@ public class CheckUnusedDependenciesTask extends DefaultTask {
+         return ignore.get().contains(BaselineExactDependencies.asString(artifact));
+     }
+
+-    @Input
++    @InputFiles
+     public final Provider<List<Configuration>> getDependenciesConfigurations() {
+         return dependenciesConfigurations;
+     }","this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before.",This feels a bit awkward. I don't think there is any way to m
+2604,"@@ -14,3 +14,13 @@ func TestNewSnapshot(t *testing.T) {
+ 	_, err := restic.NewSnapshot(paths, nil, ""foo"", time.Now())
+ 	rtest.OK(t, err)
+ }
++
++func TestTagList(t *testing.T) {
++	paths := []string{""/home/foobar""}
++	tags := []string{""""}
++
++	sn, _ := restic.NewSnapshot(paths, nil, ""foo"", time.Now())
++
++	r := sn.HasTags(tags)
++	rtest.Assert(t, r, ""Failed to match untagged snapshot"")
++}","Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?",Should we be asserting on the error here?
+2605,"@@ -1,5 +1,8 @@
+ // Copyright (c) Microsoft. All rights reserved.
+
++using System.IO;
++using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads;
++
+ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+ {
+     using System;",nit: please move these inside namespace.,Do you need this?
+2606,"@@ -139,6 +139,13 @@ var (
+ 		Value:  metadata.Testnet3Definition.Testnet3HermesURL,
+ 		Hidden: true,
+ 	}
++	// FlagPaymentsDuringSessionDebug sets if we're in debug more for the payments done in a VPN session.
++	FlagPaymentsDuringSessionDebug = cli.BoolFlag{
++		Name:   ""payments.during-session-debug"",
++		Usage:  ""Set debug mode for payments made during a session, it will bypass any price validation and allow absurd prices during sessions"",
++		Value:  false,
++		Hidden: true,
++	}
+ )
+
+ // RegisterFlagsPayments function register payments flags to flag list.",may users try to abuse it?,Nit: `Set debug mode for payments made du
+2607,"@@ -242,8 +242,9 @@ public class FlatBufferBuilder {
+         int new_buf_size = old_buf_size == 0 ? 1 : old_buf_size << 1;
+         bb.position(0);
+         ByteBuffer nbb = bb_factory.newByteBuffer(new_buf_size);
++        new_buf_size = nbb.capacity(); // TODO - Maybe we get the buffer's `limit()`
+         nbb.position(new_buf_size - old_buf_size);
+-        nbb.put(bb);
++       nbb.put(bb);
+         return nbb;
+     }
+ ",why is this space removed?,Since limit() is used to set the `nbb.cap
+2608,"@@ -1,3 +1,4 @@
++//go:build !windows
+ // +build !windows
+
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.",Can we remove this other line now then?,Does this mean that the `setup.go` file will be updated in the future?
+2609,"@@ -52,6 +52,7 @@ PERFECT_FILES = [
+     'qutebrowser/misc/checkpyver.py',
+     'qutebrowser/misc/guiprocess.py',
+     'qutebrowser/misc/editor.py',
++    'qutebrowser/misc/cmdhistory.py'
+
+     'qutebrowser/mainwindow/statusbar/keystring.py',
+     'qutebrowser/mainwindow/statusbar/percentage.py',",There's a comma missing here at the end :wink:,qutebrowser/misc/cmdhistory.py was added in my branch
+2610,"@@ -19,13 +19,8 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         [Required]
+         public string AccountKey { get; set; }
+
+-        [Required]
+         public ITaskItem[] ItemsToPush { get; set; }
+
+-        public string IndexDirectory { get; set; }
+-
+-        public bool PublishFlatContainer { get; set; }
+-
+         public bool Overwrite { get; set; }
+
+         public override bool Execute()",Why is this not required any longer?,Are these changes required because they are not on the base class?
+2611,"@@ -6,11 +6,13 @@ package admin
+
+ import (
+ 	""github.com/Unknwon/com""
++        ""github.com/Unknwon/paginater""
+
+ 	""github.com/gogits/gogs/models""
+ 	""github.com/gogits/gogs/modules/base""
+ 	""github.com/gogits/gogs/modules/log""
+ 	""github.com/gogits/gogs/modules/middleware""
++	""github.com/gogits/gogs/modules/setting""
+ )
+
+ const (",Indentation seems a bit fucked up here. Run `go fmt`.,Nit: Import sorting
+2612,"@@ -650,6 +650,9 @@ func (api *Server) GetLogs(
+ 	ctx context.Context,
+ 	in *iotexapi.GetLogsRequest,
+ ) (*iotexapi.GetLogsResponse, error) {
++	if in.GetFilter() == nil {
++		return nil, status.Error(codes.InvalidArgument, ""empty filter"")
++	}
+ 	switch {
+ 	case in.GetByBlock() != nil:
+ 		req := in.GetByBlock()",any chance in == nil? same below,"This check is already done in `iotexapi.ValidateLogRequest`, no need to add it here?"
+2613,"@@ -150,15 +150,15 @@ static int create_spawnproc(h2o_configurator_command_t *cmd, yoml_t *node, const
+     }
+
+     /* create socket */
+-    if ((listen_fd = socket(AF_UNIX, SOCK_STREAM, 0)) == -1) {
++    if ((listen_fd = h2o_sysfn(socket, AF_UNIX, SOCK_STREAM, 0)) == -1) {
+         h2o_configurator_errprintf(cmd, node, ""socket(2) failed: %s"", strerror(errno));
+         goto Error;
+     }
+-    if (bind(listen_fd, (void *)sa, sizeof(*sa)) != 0) {
++    if (h2o_sysfn(bind, listen_fd, (void *)sa, sizeof(*sa)) != 0) {
+         h2o_configurator_errprintf(cmd, node, ""bind(2) failed: %s"", strerror(errno));
+         goto Error;
+     }
+-    if (listen(listen_fd, H2O_SOMAXCONN) != 0) {
++    if (h2o_sysfn(listen, listen_fd, H2O_SOMAXCONN) != 0) {
+         h2o_configurator_errprintf(cmd, node, ""listen(2) failed: %s"", strerror(errno));
+         goto Error;
+     }",We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro.,`h2o_configurator_errprintf()` is deprecated. Please use `h2o_sysfn()` instead.
+2614,"@@ -2895,7 +2895,8 @@ struct SemaphoreSubmitState {
+             (pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) {
+             if (unsignaled_semaphores.count(semaphore) ||
+                 (!(signaled_semaphores.count(semaphore)) && !(pSemaphore->signaled) && !core->SemaphoreWasSignaled(semaphore))) {
+-                const auto &vuid = GetQueueSubmitVUID(loc, SubmitError::kSemCannotBeSignalled);
++                auto error = core->device_extensions.vk_khr_timeline_semaphore ? SubmitError::kTimelineCannotBeSignalled : SubmitError::kBinaryCannotBeSignalled;
++                const auto &vuid = GetQueueSubmitVUID(loc, error);
+                 skip |= core->LogError(
+                     objlist, pSemaphore->scope == kSyncScopeInternal ? vuid : kVUID_Core_DrawState_QueueForwardProgress,
+                     ""%s Queue %s is waiting on semaphore (%s) that has no way to be signaled."", loc.Message().c_str(),","the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the ""VK_KHR_timeline_semaphore is enabled *variant* of the ""binary cannot be signaled"" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)",Why don't you just pass the error along to the `LogError` call?
+2615,"@@ -2541,7 +2541,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         return DataFrame(sdf, self._metadata.copy())
+
+     # TODO: percentiles, include, and exclude should be implemented.
+-    def describe(self) -> 'DataFrame':
++    def describe(self, percentiles=None) -> 'DataFrame':
+         """"""
+         Generate descriptive statistics that summarize the central tendency,
+         dispersion and shape of a dataset's distribution, excluding",Could you add a type hint? `percentiles: Optional[List[float]] = None`,Please update the docstring for `percentiles`
+2616,"@@ -0,0 +1,16 @@
++module Ncr
++  module WorkOrdersHelper
++    def approver_options
++      # @todo should this list be limited by client/something else?
++      # @todo is there a better order? maybe by current_user's use?
++      User.order(:email_address).pluck(:email_address)
++    end
++
++    def building_options
++      custom = Ncr::WorkOrder.where.not(building_number: nil).pluck('DISTINCT building_number')
++      all = custom + Ncr::BUILDING_NUMBERS
++      # @todo is there a better order? maybe by current_user's use?
++      all.uniq.sort
++    end
++  end
++end","Maybe putting ones they've used before first would be good, but this is fine for now.",is there a better way to sort this?
+2617,"@@ -105,6 +105,9 @@ func newVXLANManager(
+ 		blackHoleProto = dpConfig.DeviceRouteProtocol
+ 	}
+
++	noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
++	bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
++
+ 	brt := routetable.New(
+ 		[]string{routetable.InterfaceNone},
+ 		4,",I don't think we need these. Simpler just to put `routetable.TargetType...` inline below.,Could we have a test for this?
+2618,"@@ -43,7 +43,8 @@ class Dispatcher
+     when 'parallel'
+       ParallelDispatcher.new
+     when 'linear'
+-      if cart.ncr?
++      # @todo: dynamic dispatch for selection
++      if cart.proposal.client_data_legacy.client == ""ncr""
+         NcrDispatcher.new
+       else
+         LinearDispatcher.new",Why this instead of the old way?,Prefer single-quoted strings when y
+2619,"@@ -549,10 +549,14 @@ void Mob::SetInvisible(uint8 state)
+ 	invisible = state;
+ 	SendAppearancePacket(AT_Invis, invisible);
+ 	// Invis and hide breaks charms
+-
+ 	auto formerpet = GetPet();
+-	if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden))
+-		formerpet->BuffFadeByEffect(SE_Charm);
++	if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden || invisible_animals || invisible_undead)) {
++		if (RuleB(Pets, LivelikeBreakCharmOnInvis) || (!RuleB(Pets, LivelikeBreakCharmOnInvis) && IsInvisible(formerpet))) {
++			formerpet->BuffFadeByEffect(SE_Charm);
++		}
++
++		LogRules(""Pets:LivelikeBreakCharmOnInvis for [{}] | Invis [{}] - Hidden [{}] - Shroud of Stealth [{}] - IVA [{}] - IVU [{}]"", GetCleanName(), invisible, hidden, improved_hidden, invisible_animals, invisible_undead);
++	}
+ }
+
+ //check to see if `this` is invisible to `other`","Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)",why not `if (IsInvisible(formerpet)
+2620,"@@ -964,6 +964,9 @@ func loadPluginConfig(subrepoConfig *core.Configuration, packageState *core.Buil
+ 	contextPackage := &core.Package{SubrepoName: packageState.CurrentSubrepo}
+ 	configValueDefinitions := subrepoConfig.PluginConfig
+ 	for key, definition := range configValueDefinitions {
++		if definition.ConfigKey == """" {
++			definition.ConfigKey = strings.ReplaceAll(key, ""_"", """")
++		}
+ 		fullConfigKey := fmt.Sprintf(""%v.%v"", pluginName, definition.ConfigKey)
+ 		value, ok := extraVals[strings.ToLower(definition.ConfigKey)]
+ 		if !ok {",We don't want to write this back to the definition do we? Probably just want to create a local variable for it.,"Why not just `strings.TrimSuffix(definition.ConfigKey, ""/"")`?"
+2621,"@@ -964,6 +964,7 @@ public class PlaybackService extends MediaBrowserServiceCompat {
+
+         @Override
+         public void onPlaybackEnded(MediaType mediaType, boolean stopPlaying) {
++            PlaybackPreferences.clearCurrentlyPlayingTemporaryPlaybackSpeed();
+             PlaybackService.this.onPlaybackEnded(mediaType, stopPlaying);
+         }
+     };",Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place.,"Shouldn't this be the responsibility of the playback service,"
+2622,"@@ -421,6 +421,7 @@ void LXQtTaskButton::activateWithDraggable()
+     // in progress to allow drop it into an app
+     raiseApplication();
+     KWindowSystem::forceActiveWindow(mWindow);
++    xcb_flush(QX11Info::connection());
+ }
+
+ /************************************************",We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?,Isn't this the same as `raiseApplication()` above?
+2623,"@@ -0,0 +1,8 @@
++using System;
++
++namespace Collections.Core
++{
++    public class Class1
++    {
++    }
++}",This class can be removed?,Is this necessary? I don't see anything in the PR that would
+2624,"@@ -13,8 +13,10 @@ import (
+ 	""net""
+ 	""strconv""
+
++	""github.com/iotexproject/iotex-core/action/protocol""
++
+ 	""github.com/golang/protobuf/proto""
+-	grpc_prometheus ""github.com/grpc-ecosystem/go-grpc-prometheus""
++	""github.com/grpc-ecosystem/go-grpc-prometheus""
+ 	""github.com/pkg/errors""
+ 	""go.uber.org/zap""
+ 	""google.golang.org/grpc""",File is not `goimports`-ed (from `goimports`),Did you mean to delete this line?
+2625,"@@ -72,9 +72,7 @@ type Config struct {
+
+ 	// Logger provides a logger for the dispatcher. The default logger is a
+ 	// no-op.
+-	// TODO(shah): Export this when we're ready to deploy a branch in
+-	// demo-yarpc-go.
+-	logger *zap.Logger
++	Logger *zap.Logger
+ }
+
+ // Inbounds contains a list of inbound transports. Each inbound transport","To minimize the possibility of regret, perhaps we name this `ZapLogger`.",Keeping the `logger` pointer make
+2626,"@@ -40,8 +40,9 @@ IntercomRails.config do |config|
+     user_hash: Proc.new { |current_user| OpenSSL::HMAC.hexdigest(""sha256"",
+                                                                  ENV['INTERCOM_API_SECRET'],
+                                                                  current_user.email) },
+-
+-    :plan => Proc.new { |current_user| current_user.plan_name },
++    plan: :plan_name,
++    has_logged_in_to_forum: :has_logged_in_to_forum?
++    has_active_subscription: :has_active_subscription?
+   }
+
+   # == User -> Company association","This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user.",Why did you remove the Proc.new h
+2627,"@@ -20,13 +20,11 @@
+ # ----------------------------------------------------------------------
+
+ """"""
+-Template file used by the OPF Experiment Generator to generate the actual
+-description.py file by replacing $XXXXXXXX tokens with desired values.
+-
+-This description.py file was generated by:
+-'~/nupic/eng/lib/python2.6/site-packages/nupic/frameworks/opf/expGenerator/ExpGenerator.py'
++Anomaly hotgym example
+ """"""
+
++from nupic.algorithms.anomaly import Anomaly
++
+ from nupic.frameworks.opf.expdescriptionapi import ExperimentDescriptionAPI
+
+ from nupic.frameworks.opf.expdescriptionhelpers import (","`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes.",hotgym -> anomaly hotgym
+2628,"@@ -42,8 +42,18 @@ testUtils.checkSetup = function (content, options, target) {
+ 		target = options;
+ 		options = {};
+ 	}
++	// Normalize target, allow it to be the inserted node or '#target'
++	target = target || (content instanceof Node ? content : '#target');
+ 	testUtils.fixtureSetup(content);
+-	var node = axe.utils.querySelectorAll(axe._tree[0], target || '#target')[0];
++
++	var node;
++	if (typeof target === 'string') {
++		node = axe.utils.querySelectorAll(axe._tree[0], target)[0];
++	} else if (target instanceof Node) {
++		node = axe.utils.getNodeFromTree(axe._tree[0], target);
++	} else {
++		node = target;
++	}
+ 	return [node.actualNode, options, node];
+ };
+ ",We needed this testutils file after all  ,Why not always use `typeof target === 'string'`?
+2629,"@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		big.NewInt(10),
+ 	)
+ 	pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
+-	sig, _ := hex.DecodeString(""9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01"")
++	sig, _ := hex.DecodeString(""c05c3ff8c9820038c03881c97f544593619ca4d1617c7c6d695aaf828339da9616877649d70948094a05a86b171320d1aae9afa4432606be3b263f808e11816e00"")
+ 	bd := &action.EnvelopeBuilder{}
+ 	elp := bd.SetAction(tsf0).
+ 		SetDestinationAddress(ta.Addrinfo[""producer""].Bech32()).",line is 161 characters (from `lll`),What happened with this change?
+2630,"@@ -19,6 +19,8 @@ import (
+ 	""fmt""
+ 	""time""
+
++	""github.com/chaos-mesh/chaos-mesh/pkg/controllerutils""
++
+ 	dnspb ""github.com/chaos-mesh/k8s_dns_chaos/pb""
+ 	""github.com/go-logr/logr""
+ 	""golang.org/x/sync/errgroup""",Please re-format/groupimport this line. You might need a little manual work.,Please remove this line.
+2631,"@@ -35,7 +35,11 @@ type DaisyWorker interface {
+ // designed to be run once and discarded. In other words, don't run RunAndReadSerialValue
+ // twice on the same instance.
+ func NewDaisyWorker(wf *daisy.Workflow, env EnvironmentSettings, logger logging.Logger) DaisyWorker {
+-	return &defaultDaisyWorker{wf, env, logger}
++	worker := &defaultDaisyWorker{wf, env, logger}
++	worker.env.ApplyToWorkflow(worker.wf)
++	worker.env.ApplyWorkerCustomizations(worker.wf)
++	daisy_utils.UpdateAllInstanceNoExternalIP(worker.wf, worker.env.NoExternalIP)
++	return worker
+ }
+
+ type defaultDaisyWorker struct {","minor, you can just use `wf` instead of `worker.wf`",Why do we need to call `ApplyWorkerCustomization
+2632,"@@ -161,11 +161,12 @@ public final class HttpRequestUtilsTest {
+   @Test
+   public void testGetJsonBodyForSingleMapObject() throws IOException, ServletException {
+     final HttpServletRequest httpRequest = Mockito.mock(HttpServletRequest.class);
+-    final String originalString = ""  {\n"" + ""    \""action\"": \""update\"",\n"" + ""    \""table\"": \""ramp\"",\n""
+-        + ""    \""conditions\"" : {\n"" + ""      \""rampId\"" : \""dali\""\n"" + ""    },\n""
+-        + ""    \""values\"": {\n""
+-        + ""      \""rampStage\"": 2,\n"" + ""      \""lastUpdatedTime\"": 1566259437000\n"" + ""    }\n""
+-        + ""  }\n"";
++    final String originalString =
++        ""  {\n"" + ""    \""action\"": \""update\"",\n"" + ""    \""table\"": \""ramp\"",\n""
++            + ""    \""conditions\"" : {\n"" + ""      \""rampId\"" : \""dali\""\n"" + ""    },\n""
++            + ""    \""values\"": {\n""
++            + ""      \""rampStage\"": 2,\n"" + ""      \""lastUpdatedTime\"": 1566259437000\n"" + ""    }\n""
++            + ""  }\n"";
+     final InputStream inputStream = new ByteArrayInputStream(originalString.getBytes(UTF_8));
+     final InputStreamReader inputStreamReader = new InputStreamReader(inputStream, UTF_8);
+     final BufferedReader bufferedReader = new BufferedReader(inputStreamReader);",I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string.,Why did you move the `final` to the next line?
+2633,"@@ -21,6 +21,7 @@ import (
+ 	""text/template""
+
+ 	errors ""github.com/openebs/maya/pkg/errors/v1alpha1""
++	templates ""github.com/openebs/maya/pkg/upgrade/templates""
+ 	appsv1 ""k8s.io/api/apps/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	types ""k8s.io/apimachinery/pkg/types""","could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: """") (from `typecheck`)",nit: rename package to `upgradeTemplates`
+2634,"@@ -182,7 +182,7 @@ namespace OpenTelemetry.Exporter.Prometheus.Tests
+             // Once a pull model is implemented, we'll not have this issue and we need to add tests
+             // at that time.
+
+-            // If in future, there is a official .NET Prometheus Client library, and OT Exporter
++            // If in future, there is a official .NET Prometheus Client library, and OTel Exporter
+             // choses to take a dependency on it, then none of these concerns arise.
+         }
+     }",a official -> an official,"typo ""official"" -> ""official"""
+2635,"@@ -37,7 +37,7 @@ class ProxyListenerKinesis(ProxyListener):
+     def forward_request(self, method, path, data, headers):
+         data, encoding_type = self.decode_content(data or '{}', True)
+         action = headers.get('X-Amz-Target', '').split('.')[-1]
+-        if action == 'RegisterStreamConsumer':
++        if action == 'RegisterStreamConsumer' and config.KINESIS_PROVIDER == 'kinesalite':
+             stream_arn = data.get('StreamARN', '').strip('"" ')
+             cons_arn = data.get('ConsumerARN', '').strip('"" ')
+             cons_name = data.get('ConsumerName', '').strip('"" ')",I only want the proxy request for this to run for kinesalite.,Should we also check for the action == 'Regist
+2636,"@@ -272,7 +272,7 @@ var DatePicker = React.createClass({displayName: 'DatePicker',
+       React.DOM.div(null,
+         DateInput({
+           date: this.props.selected,
+-          dateFormat: this.props.dateFormat,
++          dateFormat: this.props.dateFormat,
+           focus: this.state.focus,
+           onBlur: this.handleBlur,
+           onFocus: this.handleFocus, ",White space boya?,Why did you remove the date format here?
+2637,"@@ -79,6 +79,9 @@ type StackEvent cloudformation.StackEvent
+ // StackDescription represents an existing AWS CloudFormation stack.
+ type StackDescription cloudformation.Stack
+
++// StackSummary represents a summary of an existing AWS CloudFormation stack.
++type StackSummary cloudformation.StackSummary
++
+ // SDK returns the underlying struct from the AWS SDK.
+ func (d *StackDescription) SDK() *cloudformation.Stack {
+ 	raw := cloudformation.Stack(*d)",Maybe ditch these since `StackSummary` is not used anymore.,Since the only usage of this is in the `
+2638,"@@ -21,14 +21,15 @@ class BaseSemanticHead(BaseModule, metaclass=ABCMeta):
+                  num_classes,
+                  init_cfg=None,
+                  loss_seg=dict(
+-                     type='CrossEntropyLoss', ignore_index=-1,
++                     type='CrossEntropyLoss',
++                     ignore_index=255,
+                      loss_weight=1.0)):
+         super(BaseSemanticHead, self).__init__(init_cfg)
+         self.loss_seg = build_loss(loss_seg)
+         self.num_classes = num_classes
+
+     @force_fp32(apply_to=('seg_preds', ))
+-    def loss(self, seg_preds, gt_semantic_seg, label_bias=1):
++    def loss(self, seg_preds, gt_semantic_seg):
+         """"""Get the loss of semantic head.
+
+         Args:",suggest to indicate the value range & meaning in docstring,What's the rationale for removing the `l
+2639,"@@ -20,7 +20,7 @@ const (
+ 	// calls.
+ 	listenAddress = "":9500""
+ 	// metricsPath is the endpoint of exporter.
+-	metricsPath = ""/metrics""
++	metricsPath = ""/metrics/""
+ 	// controllerAddress is the address where jiva controller listens.
+ 	controllerAddress = ""http://localhost:9501""
+ 	// casType is the type of container attached storage (CAS) from which","not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also",Why does this need to change?
+2640,"@@ -24,6 +24,10 @@ import (
+ 	""github.com/projectcalico/felix/stringutils""
+ )
+
++func (r *DefaultRuleRenderer) CleanupEndPoint(ifaceName string) {
++	r.epmm.RemoveEndPointMark(ifaceName)
++}
++
+ func (r *DefaultRuleRenderer) WorkloadDispatchChains(
+ 	endpoints map[proto.WorkloadEndpointID]*proto.WorkloadEndpoint,
+ ) []*Chain {",The rule renderer isn't meant to be stateful so probably best to move this out of here,"This function is only called from one place, can you make it a private method?"
+2641,"@@ -57,6 +57,7 @@ func setupContainerdConfig(ctx context.Context, cfg *config.Node) error {
+ 		DisableCgroup:         disableCgroup,
+ 		IsRunningInUserNS:     isRunningInUserNS,
+ 		PrivateRegistryConfig: privRegistries.Registry(),
++		ExtraRuntimes:         findNvidiaContainerRuntimes(nil),
+ 	}
+
+ 	selEnabled, selConfigured, err := selinuxStatus()","passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?",extra runtimes for nvidia?
+2642,"@@ -3,12 +3,12 @@
+ 'use strict';
+
+ var clone = require('clone');
+-var dot = require('@deque/dot');
++var doT = require('@deque/dot');
+ var templates = require('./templates');
+ var buildManual = require('./build-manual');
+ var entities = new (require('html-entities').AllHtmlEntities)();
+ var packageJSON = require('../package.json');
+-var dotRegex = /\{\{.+?\}\}/g;
++var doTRegex = /\{\{.+?\}\}/g;
+
+ var axeVersion = packageJSON.version.substring(
+   0,",IMO `dot` should be preferred. Remember `aXe`?,`doT` is not a descriptive name. What is it used for?
+2643,"@@ -59,6 +59,7 @@ namespace AppDomain.Instance
+                 return -10;
+             }
+
++            Console.ReadKey();
+             return 0;
+         }
+     }","Not a huge deal but this will block tests, also, don't they stay open by default now?",Did you mean to add this line here?
+2644,"@@ -70,7 +70,7 @@ func makeLevels(min logrus.Level) []logrus.Level {
+ }
+
+ func makeTelemetryState(cfg TelemetryConfig, hookFactory hookFactory) (*telemetryState, error) {
+-	history := createLogBuffer(cfg.LogHistoryDepth)
++	history := createLogBuffer(2)
+ 	if cfg.SessionGUID == """" {
+ 		cfg.SessionGUID = uuid.NewV4().String()
+ 	}",Could you make it a local constant for now ?,Why is this hardcoded?
+2645,"@@ -950,6 +950,10 @@ class UserResource(object):
+                 if has_invalid_value:
+                     raise_invalid(self.request, **error_details)
+
++            if field in ('id', 'collection_id'):
++                if isinstance(value, int):
++                    value = str(value)
++
+             filters.append(Filter(field, value, operator))
+
+         return filters",What is this `collection_id` field here?,Why is this necessary?
+2646,"@@ -698,7 +698,10 @@ class Automaton(six.with_metaclass(Automaton_metaclass)):
+     # Services
+     def debug(self, lvl, msg):
+         if self.debug_level >= lvl:
+-            log_interactive.debug(msg)
++            if conf.interactive:
++                log_interactive.debug(msg)
++            else:
++                print(msg)
+
+     def send(self, pkt):
+         if self.state.state in self.interception_points:",Is there a reason why we don't use logging for this?,This shouldn't be `pri
+2647,"@@ -0,0 +1,18 @@
++<?php
++
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Core\Infrastructure\Exception;
++
++class DenoralizationException extends NormalizerException
++{
++    public function __construct(string $message, \Throwable $previous = null)
++    {
++        parent::__construct($message, $previous);
++    }
++}",Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around,Why can't we use `Elgg
+2648,"@@ -34,6 +34,7 @@ def test_simple_json_output():
+         (""column"", 0),
+         (""line"", 1),
+         (""message"", ""Line too long (1/2)""),
++        (""message-id"", ""C0301""),
+         (""module"", ""0123""),
+         (""obj"", """"),
+         (""path"", ""0123""),",IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`.,not `message-id` - is this supposed to be `message-id`?
+2649,"@@ -1427,6 +1427,7 @@ int GetSpellStatValue(uint32 spell_id, const char* stat_identifier, uint8 slot)
+ 	else if (id == ""descnum"") { return spells[spell_id].descnum; }
+ 	else if (id == ""effectdescnum"") { return spells[spell_id].effectdescnum; }
+ 	else if (id == ""npc_no_los"") { return spells[spell_id].npc_no_los; }
++	else if (id == ""feedbackable"") { return spells[spell_id].reflectable; }
+ 	else if (id == ""reflectable"") { return spells[spell_id].reflectable; }
+ 	else if (id == ""bonushate"") { return spells[spell_id].bonushate; }
+ 	else if (id == ""endurcost"") { return spells[spell_id].EndurCost; }","Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?",I don't think we should add a new spell for this. There
+2650,"@@ -0,0 +1,11 @@
++class AddUsersAllowedToTeams < ActiveRecord::Migration
++  def up
++    add_column :teams, :max_users, :integer
++
++    change_column_null :teams, :max_users, false, 0
++  end
++
++  def down
++    remove_column :teams, :max_users
++  end
++end",How should we set this for existing teams?,You can use `default: 0` here
+2651,"@@ -145,6 +145,11 @@ func TestInstallManager(t *testing.T) {
+ 			expectPasswordSecret:          true,
+ 			expectProvisionMetadataUpdate: true,
+ 		},
++		{
++			name:        ""infraID already set on cluster provision"", // fatal error
++			existing:    []runtime.Object{testClusterDeployment(), testClusterProvisionWithInfraIDSet()},
++			expectError: true,
++		},
+ 	}
+ 	for _, test := range tests {
+ 		t.Run(test.name, func(t *testing.T) {","It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog.",does this test fail if the infra ID is already set on c
+2652,"@@ -23,11 +23,11 @@ import (
+ 	""testing""
+ 	""time""
+
++	""github.com/mysteriumnetwork/go-openvpn/openvpn""
++	""github.com/mysteriumnetwork/go-openvpn/openvpn/middlewares/state""
+ 	""github.com/mysteriumnetwork/node/client/stats""
+ 	""github.com/mysteriumnetwork/node/communication""
+ 	""github.com/mysteriumnetwork/node/identity""
+-	""github.com/mysteriumnetwork/node/openvpn""
+-	""github.com/mysteriumnetwork/node/openvpn/middlewares/state""
+ 	""github.com/mysteriumnetwork/node/server""
+ 	""github.com/mysteriumnetwork/node/service_discovery/dto""
+ 	""github.com/mysteriumnetwork/node/session""",I hate then some internal process specific middleware leaks into connection manager :( todo later.,How about moving `middlewares/state` to a separate package?
+2653,"@@ -102,7 +102,14 @@ def setupNupic():
+     name = ""nupic"",
+     version = version,
+     packages = findPackages(repositoryDir),
++    # A lot of this stuff may not be packaged properly, most if it was added in
++    # an effort to get a binary package prepared for nupic.regression testing
++    # on Travis-CI, but it wasn't done the right way. I'll be refactoring a lot
++    # of this for https://github.com/numenta/nupic/issues/408, so this will be
++    # changing soon. -- Matt
+     package_data = {
++      ""nupic.support.configuration_base"": [""nupic-default.xml""],
++      ""nupic.support.__init__"": [""nupic-logging.conf""],
+       ""nupic"": [""README.md"", ""LICENSE.txt"",
+                 ""CMakeLists.txt"", ""*.so"", ""*.dll"", ""*.dylib""],
+       ""nupic.bindings"": [""_*.so"", ""_*.dll""],",Reflects where these files were moved for `pkg_resources`.,why not put in `nupic.conf`?
+2654,"@@ -1,8 +1,12 @@
+ import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
+ import { translationMacro as t } from 'ember-i18n';
++import Ember from 'ember';
++const { computed } = Ember;
+
+ export default AbstractIndexRoute.extend({
+-  pageTitle: t('admin.textReplacements.pageTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('admin.textReplacements.pageTitle');
++  }),
+   hideNewButton: true,
+
+   model() {",This should be computed('i18n.locale'....,doesn't this change the page title as well?
+2655,"@@ -1351,6 +1351,12 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
+ 									// Add a route to felix[1] to be able to reach the nodeport
+ 									_, err = eth20.RunCmd(""ip"", ""route"", ""add"", felixes[1].IP+""/32"", ""via"", ""10.0.0.20"")
+ 									Expect(err).NotTo(HaveOccurred())
++									// This multi-NIC scenario works only if the kernel's RPF check
++									// is not strict so we need to override it for the test and must
++									// be set properly when product is deployed. We reply on
++									// iptables to do require check for us.
++									felixes[1].Exec(""sysctl"", ""-w"", ""net.ipv4.conf.eth0.rp_filter=2"")
++									felixes[1].Exec(""sysctl"", ""-w"", ""net.ipv4.conf.eth20.rp_filter=2"")
+ 								})
+
+ 								By(""setting up routes to .20 net on dest node to trigger RPF check"", func() {",Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?,Can you explain why this change is needed? Is it related to
+2656,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.,why not static import?
+2657,"@@ -36,14 +36,14 @@ type morqaTransport struct {
+ }
+
+ func (transport *morqaTransport) SendEvent(event Event) error {
+-	if metric := mapEventToMetric(event); metric != nil {
+-		return transport.morqaClient.SendMetric(metric)
++	if id, metric := mapEventToMetric(event); metric != nil {
++		return transport.morqaClient.SendMetric(id, metric)
+ 	}
+
+ 	return fmt.Errorf(""event not implemented"")
+ }
+
+-func mapEventToMetric(event Event) *metrics.Event {
++func mapEventToMetric(event Event) (string, *metrics.Event) {
+ 	switch event.EventName {
+ 	case startupEventName:
+ 		return nodeVersionToMetricsEvent(event.Application)",Not sure how useful is unlock event.,It would be nice if th
+2658,"@@ -31,8 +31,8 @@ import (
+ // This code is copied from memdocstore/codec.go, with some changes:
+ // - special treatment for primitive.Binary
+
+-func encodeDoc(doc driver.Document) (map[string]interface{}, error) {
+-	var e encoder
++func encodeDoc(doc driver.Document, lowercaseFields bool) (map[string]interface{}, error) {
++	e := encoder{lowercaseFields: lowercaseFields}
+ 	if err := doc.Encode(&e); err != nil {
+ 		return nil, err
+ 	}",Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection.,I think this needs to
+2659,"@@ -82,11 +82,13 @@ public class HiveIcebergOutputCommitter extends OutputCommitter {
+
+   /**
+    * Collects the generated data files and creates a commit file storing the data file list.
+-   * @param context The job context
++   * @param ctx The task attempt context
+    * @throws IOException Thrown if there is an error writing the commit file
+    */
+   @Override
+-  public void commitTask(TaskAttemptContext context) throws IOException {
++  public void commitTask(TaskAttemptContext ctx) throws IOException {
++    TaskAttemptContext context = TezUtil.enrichContextWithAttemptWrapper(ctx);
++
+     TaskAttemptID attemptID = context.getTaskAttemptID();
+     String fileForCommitLocation = generateFileForCommitLocation(context.getJobConf(),
+         attemptID.getJobID(), attemptID.getTaskID().getId());",What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type.,Why do we need to enri
+2660,"@@ -352,8 +352,14 @@ bool TurnLaneHandler::isSimpleIntersection(const LaneDataVector &lane_data,
+             if (lane_data.back().tag == TurnLaneType::uturn)
+                 return findBestMatchForReverse(lane_data[lane_data.size() - 2].tag, intersection);
+
+-            BOOST_ASSERT(lane_data.front().tag == TurnLaneType::uturn);
+-            return findBestMatchForReverse(lane_data[1].tag, intersection);
++            // TODO(mokob): #2730 have a look please
++            // BOOST_ASSERT(lane_data.front().tag == TurnLaneType::uturn);
++            // return findBestMatchForReverse(lane_data[1].tag, intersection);
++            //
++            if (lane_data.front().tag == TurnLaneType::uturn)
++                return findBestMatchForReverse(lane_data[1].tag, intersection);
++
++            return findBestMatch(data.tag, intersection);
+         }();
+         std::size_t match_index = std::distance(intersection.begin(), best_match);
+         all_simple &= (matched_indices.count(match_index) == 0);","Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me.","i'm not sure we need to support this yet, but i'm not sure we can"
+2661,"@@ -21,12 +21,12 @@ namespace Nethermind.Merge.Plugin.Data
+ {
+     public class Result
+     {
+-        public static readonly Result Success = new Result() {Value = true};
+-        public static readonly Result Fail = new Result() {Value = false};
++        public static readonly Result OK = new() {success = true};
++        public static readonly Result Fail = new() {success = false};
+
+-        public static implicit operator Result(bool value) => value ? Success : Fail;
++        public static implicit operator Result(bool value) => value ? OK : Fail;
+
+         [JsonPropertyName(""success"")]
+-        public bool Value { get; init; }
++        public bool success { get; init; }
+     }
+ }","There was a [JsonPropertyName(""success"")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?",Not sure about this change. `success` is not a `Result` type and
+2662,"@@ -246,7 +246,8 @@ namespace Nethermind.Runner.Ethereum.Steps
+                 case SealEngineType.AuRa:
+                     AbiEncoder abiEncoder = new AbiEncoder();
+                     _context.ValidatorStore = new ValidatorStore(_context.DbProvider.BlockInfosDb);
+-                    IAuRaValidatorProcessor validatorProcessor = new AuRaAdditionalBlockProcessorFactory(_context.StateProvider, abiEncoder, _context.TransactionProcessor, _context.BlockTree, _context.ReceiptStorage, _context.ValidatorStore, _context.LogManager)
++                    ITransactionProcessorFactory readOnlyTransactionProcessorFactory = new ReadOnlyTransactionProcessorFactory(new ReadOnlyDbProvider(_context.DbProvider, false), _context.BlockTree, _context.SpecProvider, _context.LogManager);
++                    IAuRaValidatorProcessor validatorProcessor = new AuRaAdditionalBlockProcessorFactory(_context.StateProvider, abiEncoder, _context.TransactionProcessor, readOnlyTransactionProcessorFactory, _context.BlockTree, _context.ReceiptStorage, _context.ValidatorStore, _context.LogManager)
+                         .CreateValidatorProcessor(_context.ChainSpec.AuRa.Validators);
+
+                     AuRaStepCalculator auRaStepCalculator = new AuRaStepCalculator(_context.ChainSpec.AuRa.StepDuration, _context.Timestamper);    ","we can just use read env here, pretty sure",`ReadOnlyTransactionProcessorFactory` ctor takes `ITransactionPro
+2663,"@@ -91,6 +91,7 @@ class MergeCells extends BasePlugin {
+     this.autofillCalculations = new AutofillCalculations(this);
+     this.selectionCalculations = new SelectionCalculations();
+
++    this.hot.selection.transformation.addLocalHook('afterTransformStart', (...args) => this.onAfterLocalTransformStart(...args));
+     this.addHook('afterInit', (...args) => this.onAfterInit(...args));
+     this.addHook('beforeKeyDown', (...args) => this.onBeforeKeyDown(...args));
+     this.addHook('modifyTransformStart', (...args) => this.onModifyTransformStart(...args));",Could you replace local hook with global hook `afterModifyTransformStart`?,The hook name should be `afterTransformStart`.
+2664,"@@ -854,3 +854,10 @@ class FileArchive(Archive):
+     def listing(self):
+         ""Return a list of filename entries currently in the archive""
+         return ['.'.join([f,ext]) if ext else f for (f,ext) in self._files.keys()]
++
++    def clear(self):
++        ""Clears the file archive""
++        self._files.clear()
++
++
++","You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs.",nitpicking: missing a space after the comma
+2665,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?,I think this is a bug in the code. `assert`
+2666,"@@ -38,7 +38,7 @@ namespace OpenTelemetry.Trace
+         /// <summary>
+         /// Gets or sets attributes known prior to span creation.
+         /// </summary>
+-        public IDictionary<string, object> Attributes { get; set; }
++        public IEnumerable<KeyValuePair<string, object>> Attributes { get; set; }
+
+         /// <summary>
+         /// Gets or sets Links factory. Use it to deserialize list of <see cref=""Link""/> lazily","As far as I can tell, `IDictionary<string, object>` implements `IEnumerable<KeyValuePair,string, object>>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue.",Doesn't this need to take a `KeyValuePair<s
+2667,"@@ -124,7 +124,7 @@ public class DockerOptions {
+       for (int i = 0; i < maxContainerCount; i++) {
+         node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
+       }
+-      LOG.info(String.format(
++      LOG.finest(String.format(
+           ""Mapping %s to docker image %s %d times"",
+           caps,
+           name,",This change prevents a user understanding how their server is configured. Best to leave at `info` level.,This is also going to flood the logs with v
+2668,"@@ -32,6 +32,15 @@ import (
+ 	""google.golang.org/grpc/status""
+ )
+
++var (
++	ephemeralDenyList = []string{
++		api.SpecPriorityAlias,
++		api.SpecPriority,
++		api.SpecSticky,
++		api.SpecScale,
++	}
++)
++
+ func (s *OsdCsiServer) NodeGetInfo(
+ 	ctx context.Context,
+ 	req *csi.NodeGetInfoRequest,",I will add the following to the list: - api.SpecScale - api.SpecSticky,@deads2k any reason we don't want to allow any kind of `ephemeralDenyList` for SMI?
+2669,"@@ -58,7 +58,7 @@ bool EprosimaClient::init()
+
+ 	//CREATE RTPSParticipant
+ 	ParticipantAttributes PParam;
+-	PParam.rtps.defaultSendPort = 10042;
++	//PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
+ 	PParam.rtps.builtin.domainId = 80;
+ 	PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
+ 	PParam.rtps.builtin.use_SIMPLE_RTPSParticipantDiscoveryProtocol = true;","As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line",Is this TODO still needed?
+2670,"@@ -158,7 +158,6 @@ namespace OpenTelemetry.Resources.Tests
+                 { ""dynamic"", new { } },
+                 { ""array"", new int[1] },
+                 { ""complex"", this },
+-                { ""float"", 0.1f },
+             };
+
+             var resource = new Resource(attributes);","since we are now no longer expecting an input of float to return an empty string, i have removed this test case.",Any reason why this was removed?
+2671,"@@ -36,6 +36,18 @@ func MakeCounter(metric MetricName) *Counter {
+ 	return c
+ }
+
++func NewCounter(name, desc string) *Counter {
++	c := &Counter{
++		name:          name,
++		description:   desc,
++		values:        make([]*counterValues, 0),
++		labels:        make(map[string]int),
++		valuesIndices: make(map[int]int),
++	}
++	c.Register(nil)
++	return c
++}
++
+ // Register registers the counter with the default/specific registry
+ func (counter *Counter) Register(reg *Registry) {
+ 	if reg == nil {",It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`,"If you call `NewCounter(...)` with `name` as a parameter, you don't need to call `R"
+2672,"@@ -24,5 +24,5 @@ using System.Runtime.CompilerServices;
+ #else
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.Jaeger.Tests"")]
+ [assembly: InternalsVisibleTo(""Benchmarks"")]
+-[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2] // Used by Moq.
++[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")] // Used by Moq.
+ #endif",Do you know why do we need this?,I think this is going to cause compilation failures. I don't think we need to include this file in the PR.
+2673,"@@ -7,6 +7,7 @@ using System.Collections.Generic;
+ using System.Linq;
+ using MvvmCross.Platform.Ios.Presenters;
+ using MvvmCross.Platform.Ios.Presenters.Attributes;
++using MvvmCross.iOS.Views;
+ using MvvmCross.ViewModels;
+ using UIKit;
+ ",I guess this using is what causes the build to fail,I think we can revert this file.
+2674,"@@ -239,6 +239,7 @@ DECLARE_THREAD_FN(ponyint_asio_backend_dispatch)
+   close(b->wakeup);
+   ponyint_messageq_destroy(&b->q);
+   POOL_FREE(asio_backend_t, b);
++  pony_unregister_thread();
+   return NULL;
+ }
+ ",I like the explicit unregister approach.,Is there a reason for calling `unregister_thread()` instead of `unregister()`?
+2675,"@@ -25,8 +25,11 @@ namespace OpenTelemetry.Metrics
+         Type:
+             0x10: Sum
+             0x20: Gauge
+-            0x30: Histogram
+-            0x40: Summary (reserved)
++            0x40: Histogram
++            0x50: HistogramWithMinMax (reserved)
++            0x60: ExponentialHistogram (reserved)
++            0x70: ExponentialHistogramWithMinMax (reserved)
++            0x80: Summary (reserved)
+
+         Point kind:
+             0x04: I1 (signed 1-byte integer)","We should able to use 0x30 as summary, and make 0x80 reserved for future.",This file needs to be renamed as well.
+2676,"@@ -104,7 +104,7 @@ namespace Datadog.Trace.ClrProfiler
+         {
+             tags = null;
+
+-            if (!tracer.Settings.IsIntegrationEnabled(integrationId) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
++            if (!tracer.Settings.IsIntegrationEnabled(integrationId) || PlatformHelpers.PlatformStrategy.ShouldSkipClientSpan(tracer.ActiveScope) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
+             {
+                 // integration disabled, don't create a scope, skip this trace
+                 return null;",This allows strategic exclusion of http spans.,Shouldn't this be `HttpBypassHelper.ShouldSkipClientSpan(tracer.ActiveScope)` instead?
+2677,"@@ -19,8 +19,10 @@ final class SearchDto
+     private $searchableProperties;
+     /** @var string[]|null */
+     private $appliedFilters;
++    /** @var string[]|null */
++    private $strictTextSearchFields;
+
+-    public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $defaultSort, array $customSort, ?array $appliedFilters)
++    public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $defaultSort, array $customSort, ?array $appliedFilters, ?array $strictTextSearchFields)
+     {
+         $this->request = $request;
+         $this->searchableProperties = $searchableProperties;",why not just `string[]` instead of nullable,Why did you change this to `?string[]|null` and not `?string[]`?
+2678,"@@ -150,7 +150,7 @@ func (e *Extractor) listPackages(query ...string) ([]*jsonPackage, error) {
+ 	// TODO(schroederc): support GOPACKAGESDRIVER
+ 	args := append([]string{""list"",
+ 		""-compiler="" + e.BuildContext.Compiler,
+-		""-tags="" + strings.Join(e.BuildContext.BuildTags, "",""),
++		""-tags="" + strings.Join(e.BuildContext.BuildTags, "" ""),
+ 		""-installsuffix="" + e.BuildContext.InstallSuffix,
+ 		""-test"",
+ 		""-deps"",",How does this work? Why isn't each tag after the first picked up as a new arg/flag?,there's an extra space at the end here.
+2679,"@@ -37,5 +37,10 @@ namespace Datadog.Trace
+         /// The id of the container where the traced application is running.
+         /// </summary>
+         public const string ContainerId = ""Datadog-Container-ID"";
++
++        /// <summary>
++        /// The resource id of the site instance in azure app services where the traced application is running.
++        /// </summary>
++        public const string AzureAppServicesResourceId = ""Datadog-AzureAppServices-Resource-ID"";
+     }
+ }",This key is actually yet to be determined. Meeting with the backend team and Garner to discuss.,"I am not sure if this should be ""Site"" in the name. What about ""Site-ID"" or ""Site-ID""?"
+2680,"@@ -1298,12 +1298,8 @@ bool CoreChecks::ValidateImageUpdate(VkImageView image_view, VkImageLayout image
+                                      const char *func_name, std::string *error_code, std::string *error_msg) {
+     *error_code = ""VUID-VkWriteDescriptorSet-descriptorType-00326"";
+     auto iv_state = GetImageViewState(image_view);
+-    if (!iv_state) {
+-        std::stringstream error_str;
+-        error_str << ""Invalid VkImageView: "" << report_data->FormatHandle(image_view).c_str();
+-        *error_msg = error_str.str();
+-        return false;
+-    }
++    assert(iv_state);
++
+     // Note that when an imageview is created, we validated that memory is bound so no need to re-check here
+     // Validate that imageLayout is compatible with aspect_mask and image format
+     //  and validate that image usage bits are correct for given usage",Why remove the crash protection? We're just going to get a bug filed on it.,This is dead code now that GetImageViewState() can return null.
+2681,"@@ -24,6 +24,10 @@ export const HEADERS = {
+   TEXT_PLAIN: 'text/plain',
+   TEXT_HTML: 'text/html',
+   FORWARDED_PROTO: 'X-Forwarded-Proto',
++  XFRAMES_OPTIONS: 'X-Frame-Options',
++  CSP: 'Content-Security-Policy',
++  CTO: 'X-Content-Type-Options',
++  XSS: 'X-XSS-Protection',
+   ETAG: 'ETag',
+   JSON_CHARSET: 'application/json; charset=utf-8',
+   OCTET_STREAM: 'application/octet-stream; charset=utf-8',",Maybe be consistent and name it `FRAME_OPTIONS`.,We already have a setting named `XFRAMES_OPTIONS` in `url.js` a
+2682,"@@ -170,15 +170,6 @@ Blockly.Connection.prototype.connect_ = function(childConnection) {
+       if (!orphanBlock.outputConnection) {
+         throw 'Orphan block does not have an output connection.';
+       }
+-      // Attempt to reattach the orphan at the end of the newly inserted
+-      // block.  Since this block may be a row, walk down to the end
+-      // or to the first (and only) shadow block.
+-      var connection = Blockly.Connection.lastConnectionInRow_(
+-          childBlock, orphanBlock);
+-      if (connection) {
+-        orphanBlock.outputConnection.connect(connection);
+-        orphanBlock = null;
+-      }
+     } else if (parentConnection.type == Blockly.NEXT_STATEMENT) {
+       // Statement connections.
+       // Statement blocks may be inserted into the middle of a stack.","This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all.","Now that we are no longer using `orphanBlock` variable, can we "
+2683,"@@ -72,8 +72,10 @@ class TestStringMethods(testtools.TestCase):
+
+     def test_parse_provisioning_output_failure_00(self):
+         res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_FAILED)
++
+         self.assertFalse(res)
+
+     def test_parse_provisioning_output_success_00(self):
+         res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_SUCCESS)
++
+         self.assertTrue(res)",Could probably move these constants too?,Remove white space changes in this file.
+2684,"@@ -100,9 +100,8 @@ func (cmd *Command) Start() (err error) {
+ 			case <-time.After(1 * time.Minute):
+ 				err := cmd.mysteriumClient.PingProposal(proposal, signer)
+ 				if err != nil {
+-					//TODO failed to refresh proposal. Stop everything?
+ 					log.Error(""Failed to ping proposal"", err)
+-					cmd.Kill()
++					// do not stop server on missing ping to discovery. More on this in MYST-362 and MYST-370
+ 				}
+ 			case <-stopPinger:
+ 				log.Info(""Stopping proposal pinger"")",Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?,Could you explain why we don't want to stop the server on missing ping?
+2685,"@@ -26,7 +26,6 @@ import org.apache.solr.common.params.SolrParams;
+ import org.apache.solr.request.SolrQueryRequest;
+ import org.apache.solr.response.transform.DocTransformer;
+ import org.apache.solr.response.transform.TransformerFactory;
+-import org.bouncycastle.util.Strings;
+ import org.junit.After;
+ import org.junit.BeforeClass;
+ import org.junit.Test;",Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split.,Why not replace `org.bouncycastle.util.Strings` with `org.springframewo
+2686,"@@ -193,9 +193,11 @@ class SynthDriver(SynthDriver):
+ 		voices=OrderedDict()
+ 		for v in _espeak.getVoiceList():
+ 			l=v.languages[1:]
++			# #7167: Some languages names require unicode characters EG: Norwegian Bokmål
++			name=v.name.decode(""UTF-8"")
+ 			# #5783: For backwards compatibility, voice identifies should always be lowercase
+ 			identifier=os.path.basename(v.identifier).lower()
+-			voices[identifier]=VoiceInfo(identifier,v.name,l)
++			voices[identifier]=VoiceInfo(identifier,name,l)
+ 		return voices
+
+ 	def _get_voice(self):","nit: I think this would be more readable as ""Some language names contain Unicode characters"".","`#7167: Some languages name require ""UTF-8"" EG: Norwegian Bokmål`"
+2687,"@@ -1,3 +1,9 @@
++#NVDAHelper.py
++#A part of NonVisual Desktop Access (NVDA)
++#Copyright (C) 2017-2018 NV Access Limited, Peter Vagner, Davy Kager
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++
+ import os
+ import sys
+ import _winreg","Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?",I don't think we need this file at all given that it is in the `windows
+2688,"@@ -1,7 +1,6 @@
+-import { createElement, createContext } from '../../';
++import { createElement, createContext } from '../../src';
+ import { expect } from 'chai';
+
+-/** @jsx createElement */
+ /* eslint-env browser, mocha */
+
+ describe('createContext', () => {",Oh interesting - does web-test-runner not resolve package.json files?,Why did you change this?
+2689,"@@ -5,6 +5,7 @@
+       selected={startDate}
+       onChange={date => setStartDate(date)}
+       locale={fi}
++      ariaDayPrefix=""Päivä""
+     />
+   );
+ };","Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly.",Do you think it's a good
+2690,"@@ -21,11 +21,18 @@ export function setComponentProps(component, props, opts, context, mountAll) {
+ 	if ((component.__key = props.key)) delete props.key;
+
+ 	if (!component.base || mountAll) {
+-		if (component.componentWillMount) component.componentWillMount();
++		if (component.componentWillMount) {
++			options.warn(""'componentWillMount' is deprecated"");
++			component.componentWillMount();
++		}
+ 	}
+ 	else if (component.componentWillReceiveProps) {
++		options.warn(""'componentWillReceiveProps' is deprecated"");
+ 		component.componentWillReceiveProps(props, context);
+ 	}
++	if (component.getDerivedStateFromProps) {
++		component.setState(component.getDerivedStateFromProps(props, component.state));
++	}
+
+ 	if (context && context!==component.context) {
+ 		if (!component.prevContext) component.prevContext = component.context;",I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core.,Shouldn't we deprecate t
+2691,"@@ -96,6 +96,10 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
+ 	private String lastAlertMessage;
+ 	private JSONArray lastResults;
+
++	// Default queries
++	private String SOUPS_QUERY = String.format(""select %s from %s"", SmartStore.SOUP_NAME_COL, SmartStore.SOUP_ATTRS_TABLE);
++	private String INDICES_QUERY = String.format(""select %s, %s, %s from %s"", SmartStore.SOUP_NAME_COL, SmartStore.PATH_COL, SmartStore.COLUMN_TYPE_COL, SmartStore.SOUP_INDEX_MAP_TABLE);
++
+ 	/**
+ 	 * Create intent to bring up inspector
+ 	 * @param parentActivity","Use `String.format(Locale.US, ...) to avoid the `Lint` warning.",Why are you using `INDIC
+2692,"@@ -34,9 +34,17 @@ type AppliedToGroup struct {
+
+ // PodReference represents a Pod Reference.
+ type PodReference struct {
+-	// The name of this pod.
++	// The name of this Pod.
+ 	Name string
+-	// The namespace of this pod.
++	// The Namespace of this Pod.
++	Namespace string
++}
++
++// ServiceReference represents reference to a v1.Service.
++type ServiceReference struct {
++	// The name of this Service.
++	Name string
++	// The Namespace of this Service.
+ 	Namespace string
+ }
+ ",nit: ServiceReference represents a reference to a v1.Service.,does this need to be a v1.Service?
+2693,"@@ -73,7 +73,7 @@ type GcpChaosSpec struct {
+ 	// The device name of the disk to detach.
+ 	// Needed in disk-loss.
+ 	// +optional
+-	DeviceName *string `json:""deviceName,omitempty""`
++	DeviceName *[]string `json:""deviceName,omitempty""`
+ }
+
+ // GcpChaosStatus represents the status of a GcpChaos","since it changes to the array, how about change the name to `DeviceNames`",Doesn't it make sense to change th
+2694,"@@ -41,6 +41,12 @@ const (
+ 	// top level property
+ 	ConfigTLP TopLevelProperty = ""Config""
+
++	// RuntimeTLP is a top level property supported by CAS template engine
++	//
++	// The policy specific properties are placed with RuntimeTLP as the
++	// top level property
++	RuntimeTLP TopLevelProperty = ""Runtime""
++
+ 	// VolumeTLP is a top level property supported by CAS template engine
+ 	//
+ 	// The properties provided by the caller are placed with VolumeTLP",Can we avoid this. upgrade engine code should take care of this.,RuntimeTLP -> RuntimeTLP TopLevelP
+2695,"@@ -36,3 +36,4 @@ ACTIVATE_SALT = 'activate'
+ PASSWORD_RESET_SALT = 'reset'
+ MAX_LINK_AGE = 60 * 60 * 24 # 24 hours
+ CODE_EXP_MINUTES = 10
++TOKEN_EXP_DEFAULT = {'days': 90}",should also be alphabetized or at least grouped and alphabetized within group,Can this be a constant? All other
+2696,"@@ -287,6 +287,7 @@ def _try_import_backends():
+         assert results.webengine_error is not None
+
+     return results
++    # pylint: enable=unused-variable
+
+
+ def _handle_ssl_support(fatal=False):","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",Can these changes be reverted?
+2697,"@@ -29,6 +29,7 @@ const (
+
+ var (
+ 	errUnmarshalBuildOpts = errors.New(""can't unmarshal build field into string or compose-style map"")
++	errUnmarshalCountOpts = errors.New(""can't unmarshal count field into task count or auto scaling config"")
+ )
+
+ var dockerfileDefaultName = ""Dockerfile""","nit: can we remove ""can't"" from the error message?",why isn't this just `error`?
+2698,"@@ -114,7 +114,14 @@ func NewCStorVolumeReplicaController(
+ 			q.Operation = common.QOpAdd
+ 			glog.Infof(""cStorVolumeReplica Added event : %v, %v"", cVR.ObjectMeta.Name, string(cVR.ObjectMeta.UID))
+ 			controller.recorder.Event(cVR, corev1.EventTypeNormal, string(common.SuccessSynced), string(common.MessageCreateSynced))
+-			cVR.Status.Phase = apis.CVRStatusPending
++
++			// For New request phase of cVR will be empty
++			if IsEmptyStatus(cVR) {
++				cVR.Status.Phase = apis.CVRStatusPending
++			} else {
++				cVR.Status.Phase = apis.CVRStatusRecreate
++			}
++
+ 			cVR, _ = controller.clientset.OpenebsV1alpha1().CStorVolumeReplicas(cVR.Namespace).Update(cVR)
+ 			controller.enqueueCStorReplica(cVR, q)
+ 		},","instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas",Is there any way to test this?
+2699,"@@ -38,9 +38,10 @@ const (
+ 	DefaultDownloadURL = ""https://download.docker.com""
+ 	DockerPreqReqList  = ""apt-transport-https ca-certificates curl gnupg-agent software-properties-common""
+
+-	KubernetesDownloadURL = ""https://apt.kubernetes.io/""
+-	KubernetesGPGURL      = ""https://packages.cloud.google.com/apt/doc/apt-key.gpg""
+-
++	KubernetesDownloadURL     = ""https://apt.kubernetes.io/""
++	KubernetesGPGURL          = ""https://packages.cloud.google.com/apt/doc/apt-key.gpg""
++	KubernetesBaseurl         = ""https://packages.cloud.google.com/yum/repos/kubernetes-el7-x86_64""
++	KubernetesGpgkey          = ""https://packages.cloud.google.com/yum/doc/yum-key.gpg https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg""
+ 	KubeEdgeDownloadURL       = ""https://github.com/kubeedge/kubeedge/releases/download""
+ 	KubeEdgePath              = ""/etc/kubeedge/""
+ 	KubeEdgeConfPath          = KubeEdgePath + ""kubeedge/edge/conf""","Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used.",isn't the package name `cloud.
+2700,"@@ -11,8 +11,12 @@ var Parser             = imports.Parser || require('./util/BinaryParser');
+ var Step               = imports.Step || require('step');
+ var buffertools        = imports.buffertools || require('buffertools');
+ var error              = imports.error || require('./util/error');
++var networks           = imports.networks || require('./networks');
++var WalletKey          = imports.WalletKey || require('./WalletKey');
++var PrivateKey         = imports.PrivateKey || require('./PrivateKey');
+
+ var COINBASE_OP = Buffer.concat([util.NULL_HASH, new Buffer('FFFFFFFF', 'hex')]);
++var DEFAULT_FEE = 0.0001;
+
+ function TransactionIn(data) {
+   if (""object"" !== typeof data) {","I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR.",why not `var PrivateKey = imports.networks || require('./networks');` ?
+2701,"@@ -17,13 +17,13 @@
+  * </thead>
+  * <tbody>
+  * <tr><td>{@linkplain javaslang.collection.Array}</td><td><small>const</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td></tr>
+- * <tr><td>{@linkplain javaslang.collection.CharSeq}</td><td><small>const</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>linear</small></td></tr>
+- * <tr><td><em>{@linkplain javaslang.collection.Iterator}</em></td><td><small>const</small></td><td><small>const</small></td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td></tr>
++ * <tr><td>{@linkplain javaslang.collection.CharSeq}</td><td><small>const</small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
++ * <tr><td>{@linkplain javaslang.collection.Iterator}</td><td><small>const</small></td><td><small>const</small></td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td></tr>
+  * <tr><td>{@linkplain javaslang.collection.List}</td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>linear</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.Queue}</td><td><small>const</small></td><td><small>const<sup>a</sup></small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>const</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.PriorityQueue}</td><td><small>log</small></td><td><small>log</small></td><td><small>&mdash;</small></td><td><small>&mdash;</small></td><td><small>log</small></td><td><small>log</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.Stream}</td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const<sup>lazy</sup></small></td><td><small>const<sup>lazy</sup></small></td></tr>
+- * <tr><td>{@linkplain javaslang.collection.Vector}</td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
++ * <tr><td>{@linkplain javaslang.collection.Vector}</td><td><small>const</small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
+  * </tbody>
+  * </table>
+  * <br>","oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)",It looks like the `@linkplain javaslang.collection.CharSeq` is unused a
+2702,"@@ -232,15 +232,12 @@ class ResourceTags extends Gateway
+      *
+      * @return void
+      */
+-    public function destroyLinks($resource, $user, $list = null, $tag = null)
++    public function destroyResourceLinks($resource, $user, $list = null, $tag = null)
+     {
+         $callback = function ($select) use ($resource, $user, $list, $tag) {
+             $select->where->equalTo('user_id', $user);
+             if (null !== $resource) {
+-                if (!is_array($resource)) {
+-                    $resource = [$resource];
+-                }
+-                $select->where->in('resource_id', $resource);
++                $select->where->in('resource_id', (array)$resource);
+             }
+             if (null !== $list) {
+                 if (true === $list) {","Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release.",Why not use `is_array`?
+2703,"@@ -43,6 +43,7 @@ func init() {
+ 	RegisterGlobalOption(""local_certs"", parseOptTrue)
+ 	RegisterGlobalOption(""key_type"", parseOptSingleString)
+ 	RegisterGlobalOption(""auto_https"", parseOptAutoHTTPS)
++	RegisterGlobalOption(""servers"", parseServerOptions)
+ }
+
+ func parseOptTrue(d *caddyfile.Dispenser) (interface{}, error) {","A reminder that we should discuss whether to rename this to ""sockets"" or ""listeners"".",can we call this `server` instead of `servers`?
+2704,"@@ -39,6 +39,7 @@ using eprosima::fastdds::dds::Log;
+
+ using eprosima::fastrtps::rtps::RTPSDomain;
+ using eprosima::fastrtps::rtps::RTPSParticipant;
++using eprosima::fastrtps::rtps::RTPSParticipantAttributes;
+
+ namespace eprosima {
+ namespace fastdds {",Why do you need to include this using declaration?,See above. We should not forget this namespace.
+2705,"@@ -59,7 +59,7 @@ namespace Microsoft.AspNet.Server.Kestrel.GeneratedCode
+             {
+                 ulong mask = 0;
+                 ulong comp = 0;
+-                for (var scan = 0; scan != count; ++scan)
++                for (var scan = 0; scan < count; scan++)
+                 {
+                     var ch = (byte)name[offset + count - scan - 1];
+                     var isAlpha = (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');",@halter73 where is this file generated from?,I think this would be clearer with `var scan =
+2706,"@@ -19,6 +19,7 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+     [SuppressMessage(""StyleCop.CSharp.LayoutRules"", ""SA1516:Elements must be separated by blank line"", Justification = ""This is an auto-generated file."")]
+     public class PackageVersions
+     {
++#if TRUE
+         public static IEnumerable<object[]> MongoDB =>
+
+             new List<object[]>",What do these `#if TRUE` accomplish?,Why are we disabling the warning in this PR?
+2707,"@@ -39,6 +39,11 @@ namespace OpenTelemetry.Instrumentation
+
+         public void OnNext(KeyValuePair<string, object> value)
+         {
++            if (Sdk.SuppressInstrumentation)
++            {
++                return;
++            }
++
+             if (!this.handler.SupportsNullActivity && Activity.Current == null)
+             {
+                 InstrumentationEventSource.Log.NullActivity(value.Key);","Probably a good optimization to have this, but I don't think it's strictly required. For ""legacy"" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?",I think this should be `!this.handler.SupportsN
+2708,"@@ -1,6 +1,6 @@
+ <%= @activity %>
+
+-<%= t(""mailer.proposal_link_text"",
+-      proposal_url: proposal_url(@proposal)) %>
++<%= t(""mailer.view_request_cta"") %>
++<%= proposal_url(@proposal) %>
+
+ <%= t(""mailer.footer"", feedback_url: feedback_url) %>",@jessieay Intentionally moving away from passing a param?,Did you mean to remove the comma here?
+2709,"@@ -1378,13 +1378,12 @@ class PAIA extends DAIA
+             $lastname = $nameArr[0];
+         } else {
+             $nameArr = explode(' ', $username);
+-            $firstname = $nameArr[0];
+-            $lastname = '';
+-            array_shift($nameArr);
++            $firstname = '';
++            $lastname = array_pop($nameArr);
+             foreach ($nameArr as $value) {
+-                $lastname .= ' ' . $value;
++                $firstname .= ' ' . $value;
+             }
+-            $lastname = trim($lastname);
++            $firstname = trim($firstname);
+         }
+
+         // TODO: implement parsing of user details according to types set","I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?",I think this should be `trim($firstnam
+2710,"@@ -1,5 +1,4 @@
+ #!/usr/bin/env node
+-'use strict'
+
+ const userAgent = process.env.npm_config_user_agent
+ if (!userAgent) {","hmm, we actually should _add_ `'use strict'` everywhere  ",Does this file still need to be update
+2711,"@@ -905,7 +905,7 @@ public class JdbcProjectImpl implements ProjectLoader {
+                   propsName);
+
+       if (properties == null || properties.isEmpty()) {
+-        logger.warn(""Project "" + projectId + "" version "" + projectVer + "" property "" + propsName
++        logger.debug(""Project "" + projectId + "" version "" + projectVer + "" property "" + propsName
+             + "" is empty."");
+         return null;
+       }","it's not just fetching override properties here, right?",Why did you get rid of the warning?
+2712,"@@ -200,6 +200,7 @@ func (acsSession *session) Start() error {
+ 			if shouldReconnectWithoutBackoff(acsError) {
+ 				// If ACS closed the connection, there's no need to backoff,
+ 				// reconnect immediately
++				seelog.Info(""ACS Websocket connection closed for a valid reason"")
+ 				acsSession.backoff.Reset()
+ 				sendEmptyMessageOnChannel(connectToACS)
+ 			} else {",Is it worth logging the error?,prefer to use `log.Infof`
+2713,"@@ -16,6 +16,19 @@ import watchdog.events
+ from watchdog.observers import polling
+
+
++class NS:
++    def __init__(self, ns):
++        self.__dict__[""ns""] = ns
++
++    def __getattr__(self, key):
++        if key not in self.ns:
++            raise AttributeError(""No such element: %s"", key)
++        return self.ns[key]
++
++    def __setattr__(self, key, value):
++        self.__dict__[""ns""][key] = value
++
++
+ def parse_command(command):
+     """"""
+         Returns a (path, args) tuple.",What's the point of this class?,"`self.__dict__[""ns""][key]"
+2714,"@@ -411,7 +411,7 @@ import template from './libraryoptionseditor.template.html';
+             parent.querySelector('.chkEnableEmbeddedEpisodeInfosContainer').classList.add('hide');
+         }
+
+-        parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies');
++        parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies' && contentType !== 'mixed');
+
+         return populateMetadataSettings(parent, contentType);
+     }","I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`.",shouldn't this be `conten
+2715,"@@ -7,6 +7,9 @@ package libkbfs
+ import (
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/syndtr/goleveldb/leveldb""
++	""os""
++	sysPath ""path""
+ 	""sort""
+ 	""strings""
+ 	""sync""","Please put this down with the other ""github.com"" imports.",You can use `path.IsAbs`
+2716,"@@ -67,7 +67,7 @@ void nano::block_processor::add (std::shared_ptr<nano::block> block_a, uint64_t
+ 	add (info);
+ }
+
+-void nano::block_processor::add (nano::unchecked_info const & info_a)
++void nano::block_processor::add (nano::unchecked_info const & info_a, bool push_front_preference)
+ {
+ 	if (!nano::work_validate (info_a.block->root (), info_a.block->block_work ()))
+ 	{",Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter,"This parameter is not used, why not remove it?"
+2717,"@@ -53,8 +53,16 @@ public class InclusiveManifestEvaluator {
+   }
+
+   public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter) {
++    this(spec, rowFilter, true);
++  }
++
++  public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter, boolean caseSensitive) {
+     this.struct = spec.partitionType();
+-    this.expr = Binder.bind(struct, rewriteNot(Projections.inclusive(spec).project(rowFilter)), true);
++    this.expr = Binder.bind(
++            struct,
++            rewriteNot(Projections.inclusive(spec, caseSensitive).project(rowFilter)),
++            caseSensitive
++    );
+   }
+
+   /**","Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments.",is there a case where `rowFilter` is not `null
+2718,"@@ -14,8 +14,8 @@
+  */
+ package com.google.api.codegen.transformer.csharp;
+
+-import com.google.api.codegen.transformer.ApiMethodTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.StaticLangApiMethodTransformer;
+ import com.google.api.codegen.viewmodel.SimpleParamDocView;
+ import com.google.api.codegen.viewmodel.StaticLangApiMethodView;
+ import com.google.api.tools.framework.model.TypeRef;","Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used...",This file has nothing to do with this PR.
+2719,"@@ -67,7 +67,16 @@ def main(global_config, config=None, **settings):
+     # Scan Kinto views.
+     kwargs = {}
+     flush_enabled = asbool(settings.get('flush_endpoint_enabled'))
+-    if not flush_enabled:
++
++    if flush_enabled:
++        config.add_api_capability(
++            ""flush_endpoint"",
++            description=""The __flush__ endpoint can be used to remove all ""
++                        ""data from all backends."",
++            url=""http://kinto.readthedocs.org/en/latest/configuration/""
++                ""settings.html#activating-the-flush-endpoint""
++        )
++    else:
+         kwargs['ignore'] = 'kinto.views.flush'
+     config.scan(""kinto.views"", **kwargs)
+ ",nitpick: I wonder if we should name it `flush` only (?),Should this be `if flush_enabled and not setti
+2720,"@@ -0,0 +1,19 @@
++package hub
++
++import ""github.com/prometheus/client_golang/prometheus""
++
++var (
++	tasksGauge = prometheus.NewGauge(prometheus.GaugeOpts{
++		Name: ""sonm_tasks_current"",
++		Help: ""Number of currently running tasks"",
++	})
++	dealsGauge = prometheus.NewGauge(prometheus.GaugeOpts{
++		Name: ""sonm_deals_current"",
++		Help: ""Number of currently running tasks"",
++	})
++)
++
++func init() {
++	prometheus.MustRegister(tasksGauge)
++	prometheus.MustRegister(dealsGauge)
++}","Why gauges, not counters?",Would it make sense to register tasksGauge and dealsGauge as well?
+2721,"@@ -45,7 +45,7 @@ const (
+ 	// hash of origin cluster name and <server> is 6 characters hash of origin server pub key.
+ 	gwReplyPrefix    = ""_GR_.""
+ 	gwReplyPrefixLen = len(gwReplyPrefix)
+-	gwHashLen        = 6
++	gwHashLen        = sysHashLen
+ 	gwClusterOffset  = gwReplyPrefixLen
+ 	gwServerOffset   = gwClusterOffset + gwHashLen + 1
+ 	gwSubjectOffset  = gwServerOffset + gwHashLen + 1","Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more.",just for my understanding where does this magic number come from?
+2722,"@@ -93,6 +93,8 @@ public class WebUtils {
+         return ""Killing"";
+       case DISPATCHING:
+         return ""Dispatching"";
++      case POD_FAILED:
++        return ""Pod Failure"";
+       default:
+     }
+     return ""Unknown"";",Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool,"Can we make this more user-friendly? How about something like ""Fai"
+2723,"@@ -30,6 +30,14 @@ const (
+ 	requestTimeout = 60 * time.Second
+ )
+
++// Fetcher defines an interface that may be used to fetch data from the network.
++type Fetcher interface {
++	// FetchTipSets will only fetch TipSets that evaluate to `false` when passed to `done`,
++	// this includes the provided `ts`. The TipSet that evaluates to true when
++	// passed to `done` will be in the returned slice. The returns slice of TipSets is in Traversal order.
++	FetchTipSets(context.Context, types.TipSetKey, peer.ID, func(types.TipSet) (bool, error)) ([]types.TipSet, error)
++}
++
+ // interface conformance check
+ var _ Fetcher = (*GraphSyncFetcher)(nil)
+ ",Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored...,I think `fetchTipSets` -> `fetchTipSets` would be better.
+2724,"@@ -42,7 +42,7 @@ func init() {
+ // MatchExpression matches requests by evaluating a
+ // [CEL](https://github.com/google/cel-spec) expression.
+ // This enables complex logic to be expressed using a comfortable,
+-// familiar syntax.
++// familiar syntax. The standard definitions of CEL functions and operators can be found [here](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions).
+ //
+ // This matcher's JSON interface is actually a string, not a struct.
+ // The generated docs are not correct because this type has custom",I know it has no effect but my eyes can't help. Is that line not too long?,We should link to the standard definition of CEL functions in doc/language.md
+2725,"@@ -645,13 +645,6 @@ func (r *DefaultRuleRenderer) filterOutputChain(ipVersion uint8) *Chain {
+ 		},
+ 	)
+
+-	// Jump to chain for blocking service CIDR loops.
+-	rules = append(rules,
+-		Rule{
+-			Action: JumpAction{Target: ChainCIDRBlock},
+-		},
+-	)
+-
+ 	return &Chain{
+ 		Name:  ChainFilterOutput,
+ 		Rules: rules,",Does that mean we disable service loop prevention for packet generated by local host?,Why was this removed?
+2726,"@@ -107,6 +107,7 @@ module Beaker
+         when host['platform'] =~ /cumulus/
+           check_and_install_packages_if_needed(host, CUMULUS_PACKAGES)
+         when (host['platform'] =~ /windows/ and host.is_cygwin?)
++          raise RuntimeError, ""cygwin is not installed on #{host}"" if !host.cygwin_installed?
+           check_and_install_packages_if_needed(host, WINDOWS_PACKAGES)
+         when (host['platform'] =~ /windows/ and not host.is_cygwin?)
+           check_and_install_packages_if_needed(host, PSWINDOWS_PACKAGES)","It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?",I don't think this is the right place to raise an error. The problem is that
+2727,"@@ -73,8 +73,8 @@ public class ManifestFiles {
+    * @return a manifest writer
+    */
+   public static ManifestWriter write(PartitionSpec spec, OutputFile outputFile) {
+-    // always use a v1 writer for appended manifests because sequence number must be inherited
+-    return write(1, spec, outputFile, null);
++    // always use a v2 writer to preserve sequence numbers, but use null for sequence number so appends inherit
++    return write(2, spec, outputFile, null);
+   }
+
+   /**",Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?,"`write(2, ...)` -> `write(2, ...)` ?"
+2728,"@@ -47,4 +47,7 @@ public class SparkWriteOptions {
+
+   // Checks if input schema and table schema are same(default: true)
+   public static final String CHECK_ORDERING = ""check-ordering"";
++
++  // File scan task set ID that is being rewritten
++  public static final String REWRITTEN_FILE_SCAN_TASK_SET_ID = ""rewritten-file-scan-task-set-id"";
+ }",Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?,"Can you make it clear that this is a rewriting task, rather than ""rewritten-file""?"
+2729,"@@ -82,6 +82,15 @@ type TestFields struct {
+ 	NoOutput bool `name:""no_test_output""`
+ }
+
++type DebugFields struct {
++	// Shell command to debug targets.
++	Command string `name:""debug_cmd""`
++	// Like tools but available to the debug_cmd instead
++	tools []BuildInput `name:""debug_tools""`
++	// Named debug tools, similar to named sources.
++	namedTools map[string][]BuildInput `name:""debug_tools""`
++}
++
+ // A BuildTarget is a representation of a build target and all information about it;
+ // its name, dependencies, build commands, etc.
+ type BuildTarget struct {",Nice! Good idea to move these out of the main struct.,I don't think this is a good name for it. `debug_tools` is very generic. How about
+2730,"@@ -201,7 +201,10 @@ func CreateGitIgnore(targetDir string, ignores ...string) error {
+
+ 	if fileutil.FileExists(gitIgnoreFilePath) {
+ 		sigFound, err := fileutil.FgrepStringInFile(gitIgnoreFilePath, DdevFileSignature)
+-		util.CheckErr(err)
++		if err != nil {
++			return err
++		}
++
+ 		// If we sigFound the file and did not find the signature in .ddev/.gitignore, warn about it.
+ 		if !sigFound {
+ 			util.Warning(""User-managed %s will not be managed/overwritten by ddev"", gitIgnoreFilePath)","Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where ""can't happen"" but Things Can Happen.",Why remove the `CheckErr`?
+2731,"@@ -16,10 +16,13 @@ import java.util.Map;
+  * @see com.fsck.k9.mail.store.StoreConfig#getTransportUri()
+  */
+ public class ServerSettings {
++
++    public enum Type { IMAP, SMTP, WebDAV, POP3 }
++
+     /**
+-     * Name of the store or transport type (e.g. ""IMAP"").
++     * Name of the store or transport type (e.g. IMAP).
+      */
+-    public final String type;
++    public final Type type;
+
+     /**
+      * The host name of the server.","Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(""WebDAV"").",please add a description why it's changed
+2732,"@@ -1,7 +1,14 @@
+-/*global axe */
+-
++/* global axe */
++/**
++ * Converts space delimited token list to an Array
++ * @method tokenList
++ * @memberof axe.commons.utils
++ * @instance
++ * @param  {String} str
++ * @return {Array}
++ */
+ axe.utils.tokenList = function (str) {
+ 	'use strict';
+
+ 	return str.trim().replace(/\s{2,}/g, ' ').split(' ');
+-};
++};","It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice.",`tokenList` instead of `tokenList`
+2733,"@@ -3,7 +3,9 @@ let nodeName = node.nodeName.toUpperCase();
+ let type = (node.getAttribute('type') || '').toLowerCase();
+ let label = node.getAttribute('value');
+
+-this.data(label);
++if (label) {
++	this.data('has-label');
++}
+
+ if (nodeName === 'INPUT' && ['submit', 'reset'].includes(type)) {
+ 	return label === null;","The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was.",What do you think about using a mo
+2734,"@@ -267,6 +267,14 @@ func (a *WebAPI) SyncApplication(ctx context.Context, req *webservice.SyncApplic
+ 		return nil, err
+ 	}
+
++	claims, err := rpcauth.ExtractClaims(ctx)
++	if err != nil {
++		return nil, err
++	}
++	if app.ProjectId != claims.Role.ProjectId {
++		return nil, status.Error(codes.PermissionDenied, ""application cannot be synced"")
++	}
++
+ 	cmd := model.Command{
+ 		Id:            uuid.New().String(),
+ 		PipedId:       app.PipedId,","nit: ""The current project does not have requested application""",It would be good to have a test fo
+2735,"@@ -14,6 +14,7 @@ use Ergonode\SharedKernel\Domain\AbstractCode;
+ class AttributeCode extends AbstractCode
+ {
+     public const PATTERN = '/^([a-zA-Z0-9_]+)$/';
++    public const FORBIDDEN = ['id'];
+
+     public function __construct(string $value)
+     {",Extend Unit test for this class,How does this work? :thinking:
+2736,"@@ -62,6 +62,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string AppSecRules = ""DD_APPSEC_RULES"";
+
++        /// <summary>
++        /// Configuration key indicating the optional name of the custom header to take into account for the ip address.
++        /// Default is value is null (do not override).
++        /// </summary>
++        public const string AppSecCustomIpHeader = ""DD_APPSEC_IPHEADER"";
++
++        /// <summary>
++        /// Configuration key indicating the optional name of the custom header to take into account for the ip address.
++        /// Default is value is null (do not override).
++        /// </summary>
++        public const string AppSecExtraHeaders = ""DD_APPSEC_EXTRA_HEADERS"";
++
+         /// <summary>
+         /// Configuration key for enabling or disabling the Tracer's debug mode.
+         /// Default is value is false (disabled).",This is this a copy / paste error from above.,"Should we use ""DD_APPSEC_CUSTOM_IP_HEADER"" instead?"
+2737,"@@ -0,0 +1,8 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.typeresolution.typeinterference;
++
++public class Variable {
++}",this package has to be renamed to `typeinference`,Do we really need this class? Can't we just use `ja
+2738,"@@ -124,6 +124,9 @@ module.exports = {
+         let credentials = Realm.Credentials.anonymous();
+         let user = await app.logIn(credentials);
+         TestCase.assertInstanceOf(user, Realm.User);
++        TestCase.assertNotNull(user.deviceId);
++        TestCase.assertNotNull(user.providerType);
++        TestCase.assertEqual(user.providerType, ""anon-user"");
+         await user.logOut();
+     },
+ ",This cancels the above null-check I guess.,I think we should check the device id as well as th
+2739,"@@ -31,9 +31,9 @@ public final class Configuration {
+   //// 2.1 configuration items
+   public static final String PROP_ROOT = ""servicecomb.loadbalance."";
+
+-  public static final String RPOP_SERVER_EXPIRED_IN_SECONDS = ""servicecomb.loadbalance.stats.serverExpiredInSeconds"";
++  public static final String PROP_SERVER_EXPIRED_IN_SECONDS = ""servicecomb.loadbalance.stats.serverExpiredInSeconds"";
+
+-  public static final String RPOP_TIMER_INTERVAL_IN_MINIS = ""servicecomb.loadbalance.stats.timerIntervalInMilis"";
++  public static final String PROP_TIMER_INTERVAL_IN_MILLIS = ""servicecomb.loadbalance.stats.timerIntervalInMilis"";
+
+   public static final String PROP_RULE_STRATEGY_NAME = ""strategy.name"";
+ ",change to timerIntervalInMillis,I think this should be named `RPOP_TIMER_INTERVAL_I
+2740,"@@ -121,6 +121,8 @@ return [
+         'email' => 'Email',
+         'role_field' => 'Role',
+         'role_comment' => 'Roles define user permissions, which can be overriden on the user level, on the Permissions tab.',
++        'role_none' => 'None',
++        'role_none_comment' => 'This administrator does not belong to any rules.',
+         'groups' => 'Groups',
+         'groups_comment' => 'Specify which groups this account should belong to.',
+         'avatar' => 'Avatar',",`any rules` should be `any roles`,"What do you think about adding ""This administrator does not belong to any rules.""?"
+2741,"@@ -105,13 +105,12 @@ public class AllEpisodesFragment extends EpisodesListFragment {
+     @NonNull
+     @Override
+     protected List<FeedItem> loadData() {
+-        return feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes(0, page * EPISODES_PER_PAGE));
++        return DBReader.getRecentlyPublishedEpisodesFiltered(0, page * EPISODES_PER_PAGE, feedItemFilter);
+     }
+
+     @NonNull
+     @Override
+     protected List<FeedItem> loadMoreData() {
+-        return feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes((page - 1) * EPISODES_PER_PAGE,
+-                EPISODES_PER_PAGE));
++        return DBReader.getRecentlyPublishedEpisodesFiltered((page - 1) * EPISODES_PER_PAGE, EPISODES_PER_PAGE, feedItemFilter);
+     }
+ }","Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication.",Shouldn't you use `getRecentlyPublishedEpisodesFiltered` here?
+2742,"@@ -29,9 +29,11 @@ from qutebrowser.utils import message
+ from qutebrowser.config import config
+ from qutebrowser.keyinput import keyparser
+ from qutebrowser.utils import usertypes, log, objreg, utils
++from qutebrowser.config.parsers import keyconf
+
+
+-STARTCHARS = "":/?""
++conf = keyconf.KeyConfigParser(None, None)
++STARTCHARS = conf.get_bindings_for('normal').keys()
+ LastPress = usertypes.enum('LastPress', ['none', 'filtertext', 'keystring'])
+
+ ","I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound.","Just curious, what's the difference between this and `qconf.get_bindings_for('norm"
+2743,"@@ -69,7 +69,6 @@ public abstract class TomcatServerBootstrap extends EmbeddedServerBootstrap {
+       .useLegacyLocalRepo(true).configureViaPlugin();
+
+     WebArchive wa = ShrinkWrap.create(WebArchive.class, ""rest-test.war"").setWebXML(webXmlPath)
+-        .addAsLibraries(resolver.resolve(""org.codehaus.jackson:jackson-jaxrs:1.6.5"").withTransitivity().asFile())
+         .addAsLibraries(resolver.addDependencies(
+             MavenDependencies.createDependency(""org.mockito:mockito-core"", ScopeType.TEST, false,
+             MavenDependencies.createExclusion(""org.hamcrest:hamcrest-core""))).resolve()",@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?,Can we remove this line?
+2744,"@@ -40,10 +40,16 @@ type Miner struct {
+ 	// PeerID is the peer ID to set as the miners owner
+ 	PeerID string
+
+-	// Power is the amount of power this miner should start off with
++	// NumCommittedSectors is the number of sectors that this miner has
++	// committed to the network.
++	//
++	// TODO: This struct needs a field which represents the size of sectors
++	// that this miner has committed. For now, sector size is configured by
++	// the StorageMarketActor's ProofsMode.
++	//
+ 	// TODO: this will get more complicated when we actually have to
+-	// prove real files
+-	Power uint64
++	// prove real files.
++	NumCommittedSectors uint64
+ }
+
+ // GenesisCfg is",uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?,please add a `TODO: ...` here so we remember to remove it before merging
+2745,"@@ -109,7 +109,6 @@ type initStorageOpts struct {
+ 	ws    wsAddonManager
+ 	store store
+
+-	app *config.Application
+ 	sel wsSelector
+ }
+ ","Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it.",This was only used to pass the `app *config.Application` to the `Select`
+2746,"@@ -337,6 +337,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		}
+ 	}
+
++	// Get the remote host
++	remoteHost, _, err := net.SplitHostPort(r.RemoteAddr)
++	if err != nil {
++		remoteHost = r.RemoteAddr
++	}
++
+ 	if vh, ok := s.vhosts[host]; ok {
+ 		status, _ := vh.stack.ServeHTTP(w, r)
+ ","To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone.",This will overwrite the current host with `r.RemoteAddr` if `err != nil`
+2747,"@@ -221,7 +221,13 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= p.foundationBonusP2StartEpoch && epochNum <= p.foundationBonusP2EndEpoch) {
++	var grantFB bool
++	if a.hasFoundationBonusExtension() {
++		grantFB = a.grantFoundationBonus(epochNum)
++	} else {
++		grantFB = epochNum <= a.foundationBonusLastEpoch || (epochNum >= p.cfg.FoundationBonusP2StartEpoch && epochNum <= p.cfg.FoundationBonusP2EndEpoch)
++	}
++	if grantFB {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb",Why is it ok to use `epochNum >= a.foundationBonusP2StartEpoch` when `gr
+2748,"@@ -222,8 +222,7 @@ class RandomFlip(object):
+             flipped[..., 1::4] = h - bboxes[..., 3::4]
+             flipped[..., 3::4] = h - bboxes[..., 1::4]
+         else:
+-            raise ValueError(
+-                'Invalid flipping direction ""{}""'.format(direction))
++            raise ValueError(f'Invalid flipping direction ""{direction}""')
+         return flipped
+
+     def __call__(self, results):",Use single quote to wrap the str.,This should be `f'Invalid flipping direction {direction}'`.
+2749,"@@ -100,7 +100,7 @@ public enum JsonRpcError {
+       ""The permissioning whitelist configuration file is out of sync.  The changes have been applied, but not persisted to disk""),
+   WHITELIST_RELOAD_ERROR(
+       -32000,
+-      ""Error reloading permissions file. Please use perm_getAccountsWhitelist and perm_getNodesWhitelist to review the current state of the whitelists""),
++      ""Error reloading permissions file. Please use perm_getAccountsWhitelist and perm_getNodesAllowlist to review the current state of the whitelists""),
+   PERMISSIONING_NOT_ENABLED(-32000, ""Node/Account whitelisting has not been enabled""),
+   NON_PERMITTED_NODE_CANNOT_BE_ADDED_AS_A_PEER(-32000, ""Cannot add a non-permitted node as a peer""),
+ ",Is the plan to rename this later?,`Permitlist` -> `Permitlist`
+2750,"@@ -340,7 +340,9 @@ class ChoiceAuth extends AbstractBase
+             return false;
+         }
+
+-        if (!in_array($this->strategy, $this->strategies)) {
++        if ('Email' !== $this->strategy
++            && !in_array($this->strategy, $this->strategies)
++        ) {
+             throw new InvalidArgumentException(""Illegal setting: {$this->strategy}"");
+         }
+         $authenticator = $this->getPluginManager()->get($this->strategy);",Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?,you should check that this is only for `Email` strategy. th
+2751,"@@ -130,6 +130,9 @@ func makeJournalServer(
+ 	bcache BlockCache, dirtyBcache DirtyBlockCache, bserver BlockServer,
+ 	mdOps MDOps, onBranchChange branchChangeListener,
+ 	onMDFlush mdFlushListener, diskLimiter diskLimiter) *JournalServer {
++	if len(dir) == 0 {
++		panic(""dir unexpectedly empty"")
++	}
+ 	jServer := JournalServer{
+ 		config:                  config,
+ 		log:                     log,","This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe ""dir"" -> ""dir string""?",why was this added?
+2752,"@@ -53,6 +53,9 @@ namespace Kokkos {
+ namespace Experimental {
+
+ bool HPX::m_hpx_initialized = false;
++bool HPX::m_was_initialized = false;
++bool HPX::m_was_finalized   = false;
++
+ std::atomic<uint32_t> HPX::m_next_instance_id{1};
+ #if defined(KOKKOS_ENABLE_HPX_ASYNC_DISPATCH)
+ std::atomic<uint32_t> HPX::m_active_parallel_region_count{0};",Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?,Why is `m_was_finalized` needed? Isn't `m_hpx_initialized` enough?
+2753,"@@ -108,8 +108,8 @@ func NewMetadata(
+ 		}
+ 		versionToClusterName[info.InitialFailoverVersion] = clusterName
+
+-		if info.Enabled && (len(info.RPCName) == 0 || len(info.RPCAddress) == 0) {
+-			panic(fmt.Sprintf(""Cluster %v: rpc name / address is empty"", clusterName))
++		if info.Enabled && info.RPCAddress == """" {
++			panic(fmt.Sprintf(""Cluster %v: RPCAddress is empty"", clusterName))
+ 		}
+ 	}
+ ",also check RPCName?,Was this a bug?
+2754,"@@ -76,9 +76,11 @@ import org.springframework.security.oauth2.client.userinfo.ReactiveOAuth2UserSer
+ import org.springframework.security.oauth2.client.web.server.AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository;
+ import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationCodeGrantWebFilter;
+ import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationRequestRedirectWebFilter;
++import org.springframework.security.oauth2.client.web.server.ServerAuthorizationRequestRepository;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationCodeAuthenticationTokenConverter;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationRequestResolver;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizedClientRepository;
++import org.springframework.security.oauth2.client.web.server.WebSessionOAuth2ServerAuthorizationRequestRepository;
+ import org.springframework.security.oauth2.client.web.server.authentication.OAuth2LoginAuthenticationWebFilter;
+ import org.springframework.security.oauth2.core.endpoint.OAuth2AuthorizationRequest;
+ import org.springframework.security.oauth2.core.oidc.user.OidcUser;",Remove unused import,This file doesn't seem to be used anymore
+2755,"@@ -182,7 +182,7 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) {
+ 	newInst := &Instance{serverType: newCaddyfile.ServerType(), wg: i.wg}
+
+ 	// attempt to start new instance
+-	err := startWithListenerFds(newCaddyfile, newInst, restartFds)
++	err := startWithListenerFds(newCaddyfile, newInst, restartFds, false)
+ 	if err != nil {
+ 		return i, err
+ 	}",I assume there will never be a scenario where justValidate is expected to be true on a restart,Shouldn't this be true only if `serverType == caddyfile.ServerType
+2756,"@@ -356,6 +356,9 @@ public class PMD {
+
+         sortFiles(configuration, files);
+
++        // Make sure the cache is listening for analysis results
++        ctx.getReport().addListener(configuration.getAnalysisCache());
++
+         /*
+          * Check if multithreaded support is available. ExecutorService can also
+          * be disabled if threadCount is not positive, e.g. using the","Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?",Shouldn't we only do this if analysis is enabled?
+2757,"@@ -3,7 +3,7 @@ module Travis
+     class Script
+       class C < Script
+         DEFAULTS = {
+-          compiler: 'gcc'
++          compiler: ''
+         }
+
+         def export","I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in ""`command not found`"" (though not critical), and the cache slug will lack this information (also not critical).",why did you change this? gcc is the default.
+2758,"@@ -33,6 +33,9 @@ const instanceMethods = {
+     },
+
+     async callFunction(name, args, service = undefined) {
++        if (!args) {
++            args = [];
++        }
+         const cleanedArgs = cleanArguments(args);
+         const stringifiedArgs = EJSON.stringify(cleanedArgs, { relaxed: false });
+         const result = await promisify(cb => this._callFunction(name, stringifiedArgs, service, cb));",Why do this rather than `args = []` in the function signature?,Would this default `args` to an empty array inste
+2759,"@@ -22,6 +22,8 @@ module Bolt
+         %w[service-url cacert token-file task-environment local-validation]
+       end
+
++      PROVIDED_FEATURES = ['puppet-agent'].freeze
++
+       def self.validate(options)
+         validation_flag = options['local-validation']
+         unless !!validation_flag == validation_flag",I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though,can we call this `puppet-agent` or `puppet-agent-
+2760,"@@ -1640,6 +1640,11 @@ class Dataset(object):
+         if self.handle is None or other.handle is None:
+             raise ValueError('Both source and target Datasets must be constructed before adding features')
+         _safe_call(_LIB.LGBM_DatasetAddFeaturesFrom(self.handle, other.handle))
++        if other.data is None:
++            self.data = None
++        if self.data is not None:
++            # FIXME: concat two dataset
++            self.data = [self.data, other.data]
+         return self
+
+     def _dump_text(self, filename):",@StrikerRUS here may need to concat two data by col.,why do we need this?
+2761,"@@ -64,7 +64,7 @@ public interface NodeWithJavadoc<N extends Node> {
+      */
+     @SuppressWarnings(""unchecked"")
+     default N setJavadocComment(String comment) {
+-        return setJavadocComment(new JavadocComment(comment));
++        return setJavadocComment(new JavadocComment("" "" + comment));
+     }
+
+     default N setJavadocComment(JavadocComment comment) {",Why the space?,Why do we need this?
+2762,"@@ -38,10 +38,10 @@ public interface ZalcanoConfig extends Config
+ {
+
+ 	@ConfigTitleSection(
+-		keyName = ""zalcanoTitle"",
+-		name = ""Zalcano"",
+-		description = """",
+-		position = 0
++			keyName = ""zalcanoTitle"",
++			name = ""Zalcano"",
++			description = """",
++			position = 0
+ 	)
+ 	default Title zalcanoTitle()
+ 	{",please resolve the extra indentation,I'm not sure if this
+2763,"@@ -69,8 +69,9 @@ namespace pwiz.Skyline.Model.Lib
+         protected override bool StateChanged(SrmDocument document, SrmDocument previous)
+         {
+             return previous == null ||
+-                !ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) ||
+-                !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults);
++                   !ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) ||
++                   !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) ||
++                   !ReferenceEquals(document.Id, previous.Id);
+         }
+
+         protected override string IsNotLoadedExplained(SrmDocument document)",More proof that this check is needed always.,:memo: I'm not sure
+2764,"@@ -86,9 +86,7 @@ lbann_comm::~lbann_comm() {
+     }
+   }
+ #ifdef LBANN_HAS_ALUMINUM
+-  for (auto&& c : al_comms) {
+-    delete c.second;
+-  }
++  m_al_comms.clear();
+   allreduces::Finalize();
+ #endif
+ }",`m_al_comms` now contains smart pointers.,why do you need to clear it here?
+2765,"@@ -80,6 +80,10 @@ namespace AutoRest.CSharp
+                 {
+                     return ""new "" + type.Name + ""()"";
+                 }
++                if (type is EnumType && (type as EnumType).ModelAsString)
++                {
++                    return Instance.QuoteValue(defaultValue);
++                }
+                 if (primaryType != null)
+                 {
+                     if (primaryType.KnownPrimaryType == KnownPrimaryType.String)",Did you do a test run with the compare script? I'm nervous about what happens on all the generators...,I'm not sure how I feel about thi
+2766,"@@ -390,6 +390,19 @@ func (c *client) initClient() {
+ 	}
+ }
+
++// RemoteAddress expose the Address of the client connection,
++// nil when not connected or unknown
++func (c *client) RemoteAddress() net.Addr {
++	c.mu.Lock()
++	defer c.mu.Unlock()
++
++	if c.nc == nil {
++		return nil
++	}
++
++	return c.nc.RemoteAddr()
++}
++
+ // Helper function to report errors.
+ func (c *client) reportErrRegisterAccount(acc *Account, err error) {
+ 	if err == ErrTooManyAccountConnections {","For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not.","You don't need this, you can just"
+2767,"@@ -196,6 +196,6 @@ public class TestDataSourceOptions {
+         .option(""split-size"", String.valueOf(562L)) // 562 bytes is the size of SimpleRecord(1,""a"")
+         .load(tableLocation);
+
+-    Assert.assertEquals(""Spark partitions should match"", 2, resultDf.javaRDD().getNumPartitions());
++    Assert.assertEquals(""Spark partitions should match"", 4, resultDf.javaRDD().getNumPartitions());
+   }
+ }",This change is suspicious. Why did the number of partitions increase?,why did this test change?
+2768,"@@ -20,8 +20,7 @@ class ProposalPolicy
+   end
+
+   def can_create!
+-    # TODO restrict by client_slug
+-    true
++    slug_matches? || @user.admin?
+   end
+   alias_method :can_new!, :can_create!
+ ","I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?",Use nested module/class definitions instead of compact style.
+2769,"@@ -1710,10 +1710,11 @@ namespace pwiz.Skyline.EditUI
+         private void UpdateMoleculeType()
+         {
+             bool isPeptide = radioPeptide.Checked;
+-            btnCustomMoleculeColumns.Enabled = radioMolecule.Checked;
++            btnCustomMoleculeColumns.Enabled = true;
+             Settings.Default.TransitionListInsertPeptides = isPeptide; // Remember for next time
+
+-            //Skip updating if nothing needs to be changed
++            // Skip updating if nothing needs to be changed
++            // This should probably be taken out when we add smarter column selection as its currently hard coded for the number of columns
+             if ((isPeptide && gridViewTransitionList.ColumnCount == 5) || (!isPeptide && gridViewTransitionList.ColumnCount == 6))
+                 return;
+ ",Should there be any changes to this file at all?,are we sure this is only done when the column count is 5 or 6
+2770,"@@ -87,6 +87,7 @@ func parseTLS(h Helper) ([]ConfigValue, error) {
+ 	var folderLoader caddytls.FolderLoader
+ 	var certSelector caddytls.CustomCertSelectionPolicy
+ 	var acmeIssuer *caddytls.ACMEIssuer
++	var autoPolicy *caddytls.AutomationPolicy
+ 	var internalIssuer *caddytls.InternalIssuer
+ 	var issuers []certmagic.Issuer
+ 	var onDemand bool","The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here.",Do we really need both `ACMEIssuer` and `autoPolicy`? Why not
+2771,"@@ -36,8 +36,11 @@ var SwaggerPetstore = ( /** @lends SwaggerPetstore */ function() {
+    * {@link https://github.com/request/request#requestoptions-callback Options doc}
+    */
+   function SwaggerPetstore(baseUri, options) {
+-    SwaggerPetstore['super_'].call(this, options);
+-
++    if (!options) {
++      options = {};
++    }
++    SwaggerPetstore['super_'].call(this, options.credentials, options);
++
+     this.baseUri = baseUri;
+     if (this.baseUri === null || this.baseUri === undefined) {
+       this.baseUri = 'http://localhost:12510/api';",This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state,Is this change necessary? I don't see a new test for this.
+2772,"@@ -23,13 +23,15 @@ import { createTestRegistry } from './utils';
+  * Renders the given UI into a container to make assertions.
+  *
+  * @since 1.7.1
++ * @since 1.25.0 Added `features` option.
+  * @see {@link https://testing-library.com/docs/react-testing-library/api#render}
+  * @private
+  *
+- * @param {*}        ui                    Any valid React child element.
+- * @param {Object}   options               Render options.
+- * @param {Function} options.setupRegistry A function which accepts the registry instance to configure it.
+- * @param {Function} options.registry      A specific registry instance to use. Defaults to a fresh test registry with all stores.
++ * @param {*}        ui                      Any valid React child element.
++ * @param {Object}   [options]               Optional. Render options.
++ * @param {string[]} [options.features]      Feature flags to enable for this hook render.
++ * @param {Function} [options.setupRegistry] A function which accepts the registry instance to configure it.
++ * @param {Object}   [options.registry]      A specific registry instance to use. Defaults to a fresh test registry with all stores.
+  * @return {Object} An object containing all of {@link https://testing-library.com/docs/react-testing-library/api#render-result} as well as the `registry`.
+  */
+ const customRender = ( ui, options = {} ) => {",Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed.,I am not sure this is the right place for this. It should be like `@param {string[]} [options.features] The feature flags to enable for this hook render.`
+2773,"@@ -251,14 +251,14 @@ std::string CPlusPlusLanguage::MethodName::GetScopeQualifiedName() {
+ bool CPlusPlusLanguage::IsCPPMangledName(const char *name) {
+   // FIXME!! we should really run through all the known C++ Language plugins
+   // and ask each one if this is a C++ mangled name
+-
++
+   if (name == nullptr)
+     return false;
+-
+-  // MSVC style mangling
++
++  // MSVC style mangling
+   if (name[0] == '?')
+     return true;
+-
++
+   return (name[0] != '\0' && name[0] == '_' && name[1] == 'Z');
+ }
+ ",This looks like a bunch of whitespace fixing that's unrelated. Can you revert?,Please don't add trailing whitespace
+2774,"@@ -25,7 +25,7 @@ class AppKernel extends Kernel
+             new Symfony\Bundle\SecurityBundle\SecurityBundle(),
+             new Symfony\Bundle\TwigBundle\TwigBundle(),
+             new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
+-            new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
++            // new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
+             new Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle(),
+             new EasyCorp\Bundle\EasyAdminBundle\EasyAdminBundle(),
+             new EasyCorp\Bundle\EasyAdminBundle\Tests\Fixtures\AppTestBundle\AppTestBundle(),",should be removed instead,Can we just remove this bundle if it's not needed?
+2775,"@@ -88,10 +88,14 @@ public class TestRegExp extends LuceneTestCase {
+     assertTrue(a.toString().length() > 0);
+   }
+
++
++  boolean caseSensitiveQuery = true;
++
+   public void testCoreJavaParity() {
+     // Generate random doc values and random regular expressions
+     // and check for same matching behaviour as Java's Pattern class.
+     for (int i = 0; i < 1000; i++) {
++      caseSensitiveQuery = true;
+       checkRandomExpression(randomDocValue(1 + random().nextInt(30)));
+     }
+   }",should use randomization ?,Please use a junit rule for this :)
+2776,"@@ -102,7 +102,7 @@ func (c *CmdVolumeOptions) RunVolumeInfo(cmd *cobra.Command) error {
+ 	// controller's IP, status, iqn, replica IPs etc.
+ 	volumeInfo, err := NewVolumeInfo(mapiserver.GetURL()+VolumeAPIPath+c.volName, c.volName, c.namespace)
+ 	if err != nil {
+-		return err
++		return nil
+ 	}
+
+ 	// Initiallize an instance of ReplicaCollection, json response recieved from the replica controller. Collection contains status and other information of replica.",returning nil because we want to mayactl to exit with 0 status code.,Why are we passing the error to NewVolumeInfo here?
+2777,"@@ -112,7 +112,7 @@ static void send_response(struct st_h2o_status_collector_t *collector)
+     resp[cur_resp++] = (h2o_iovec_t){H2O_STRLIT(""\n}\n"")};
+
+     req->res.status = 200;
+-    h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CONTENT_TYPE, H2O_STRLIT(""text/plain; charset=utf-8""));
++    h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CONTENT_TYPE, H2O_STRLIT(""application/json; charset=utf-8""));
+     h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CACHE_CONTROL, H2O_STRLIT(""no-cache, no-store""));
+     h2o_start_response(req, &generator);
+     h2o_send(req, resp, h2o_memis(req->input.method.base, req->input.method.len, H2O_STRLIT(""HEAD"")) ? 0 : nr_resp, 1);",Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...),"This is probably fine, but I'd like to understand w"
+2778,"@@ -9,12 +9,12 @@ namespace Microsoft.CodeAnalysis.Sarif
+     /// <summary>
+     /// The state of a result relative to a baseline of a previous run.
+     /// </summary>
+-    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.28.0.0"")]
+     [Flags]
++    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.30.0.0"")]
+     public enum SuppressionStates
+     {
+         None,
+-        SuppressedInSource = 0x1,
+-        SuppressedInBaseline = 0x2
++        SuppressedInSource = 1,
++        SuppressedInBaseline = 2
+     }
+ }",`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved,What's the reasoning behind the change here?
+2779,"@@ -376,6 +376,9 @@ configRetry:
+ 	} else {
+ 		// Use the syncer locally.
+ 		syncer = felixsyncer.New(backendClient, datastoreConfig.Spec, syncerToValidator)
++
++		log.Info(""using resource updates where applicable"")
++		configParams.SetUseResourceUpdates(true)
+ 	}
+ 	log.WithField(""syncer"", syncer).Info(""Created Syncer"")
+ ",I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API.,Do we want this setting to be true only when the `c
+2780,"@@ -62,8 +62,13 @@ func main() {
+ 		ddata, err := ioutil.ReadFile(os.Args[3])
+ 		failFast(err)
+
++		programstr := fmt.Sprintf(""%s"", pdata)
++
++		programbytes, err := logic.AssembleString(programstr)
++		failFast(err)
++
+ 		dsig := sec.Sign(logic.Msg{
+-			ProgramHash: crypto.HashObj(logic.Program(pdata)),
++			ProgramHash: crypto.HashObj(logic.Program(programbytes)),
+ 			Data:        ddata,
+ 		})
+ ",Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?,Nit: Can you use `fmt.Sprintf` to format the string instead of `fmt.Sprintf`?
+2781,"@@ -257,6 +257,12 @@ class VirtualBufferTextInfo(browseMode.BrowseModeDocumentTextInfo,textInfos.offs
+ 		return lineStart.value,lineEnd.value
+
+ 	def _normalizeControlField(self,attrs):
++
++		ariaCurrent = attrs.get(""IAccessible2::attribute_current"")
++		if ariaCurrent != None:
++			attrs['current']= ariaCurrent
++			del attrs[""IAccessible2::attribute_current""]
++
+ 		tableLayout=attrs.get('table-layout')
+ 		if tableLayout:
+ 			attrs['table-layout']=tableLayout==""1""",Extraneous blank line.,Is there any reason to remove `current` from `IAccessible2`?
+2782,"@@ -43,5 +43,5 @@ var errWalletNotFound = fmt.Errorf(""wallet not found"")
+ var errSQLiteWrongType = fmt.Errorf(""sqlite wallet driver returned wrong wallet type"")
+ var errNameTooLong = fmt.Errorf(""wallet name too long, must be <= %d bytes"", sqliteMaxWalletNameLen)
+ var errIDTooLong = fmt.Errorf(""wallet id too long, must be <= %d bytes"", sqliteMaxWalletIDLen)
+-var errMsigWrongAddr = fmt.Errorf(""given multisig preimage hashes to wrong address"")
++var errMsigWrongAddr = fmt.Errorf(""given multisig preimage hashes to neither Sender or AuthAddr"")
+ var errMsigWrongKey = fmt.Errorf(""given key is not a possible signer for this multisig"")",nit: syntax : neither -> nor,"Maybe ""given multisig preimage hashes to an unsupported address"""
+2783,"@@ -45,11 +45,11 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.Log4Net
+                 loggingEvent.Properties[CorrelationIdentifier.VersionKey] = tracer.Settings.ServiceVersion ?? string.Empty;
+                 loggingEvent.Properties[CorrelationIdentifier.EnvKey] = tracer.Settings.Environment ?? string.Empty;
+
+-                var span = tracer.ActiveScope?.Span;
+-                if (span is not null)
++                var spanContext = tracer.DistributedSpanContext;
++                if (spanContext is not null)
+                 {
+-                    loggingEvent.Properties[CorrelationIdentifier.TraceIdKey] = span.TraceId;
+-                    loggingEvent.Properties[CorrelationIdentifier.SpanIdKey] = span.SpanId;
++                    loggingEvent.Properties[CorrelationIdentifier.TraceIdKey] = spanContext[HttpHeaderNames.TraceId];
++                    loggingEvent.Properties[CorrelationIdentifier.SpanIdKey] = spanContext[HttpHeaderNames.ParentId];
+                 }
+             }
+ ",Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not.,Why do we still need this one?
+2784,"@@ -689,8 +689,9 @@ public class ExecutionController extends EventHandler implements ExecutorManager
+             this.maxConcurrentRunsPerFlowMap);
+         if (running.size() > maxConcurrentRuns) {
+           this.commonMetrics.markSubmitFlowSkip();
+-          throw new ExecutorManagerException(""Flow "" + flowId
+-              + "" has more than "" + maxConcurrentRuns + "" concurrent runs. Skipping"",
++          throw new ExecutorManagerException(""Flow with id "" +
++              (exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId)
++              + "" has more than "" + maxConcurrentRuns + "" concurrent runs. Execution not created."",
+               ExecutorManagerException.Reason.SkippedExecution);
+         } else if (options.getConcurrentOption().equals(
+             ExecutionOptions.CONCURRENT_OPTION_PIPELINE)) {","Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `<flowId,flowDefinitionId>` ?","I think that this message could be clearer: ""No flow with id "" + (exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId)"
+2785,"@@ -1774,6 +1774,7 @@ return [
+ 'DateTime::add' => ['static', 'interval'=>'DateInterval'],
+ 'DateTime::createFromFormat' => ['static|false', 'format'=>'string', 'time'=>'string', 'timezone='=>'?DateTimeZone'],
+ 'DateTime::createFromImmutable' => ['static', 'datetTimeImmutable'=>'DateTimeImmutable'],
++'DateTime::createFromInterface' => ['DateTimeInterface', 'self'],
+ 'DateTime::diff' => ['DateInterval|false', 'datetime2'=>'DateTimeInterface', 'absolute='=>'bool'],
+ 'DateTime::format' => ['string|false', 'format'=>'string'],
+ 'DateTime::getLastErrors' => ['array{warning_count:int,warnings:array<int,string>,error_count:int,errors:array<int,string>}'],",Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`.,I don't think we should depend on an implementation of `DateTimeInterface` here...
+2786,"@@ -114,12 +114,6 @@ function getArrayBuffer (chunk) {
+
+ function getFileType (file) {
+   const fileExtension = file.name ? getFileNameAndExtension(file.name).extension : null
+-
+-  if (file.isRemote) {
+-    // some remote providers do not support file types
+-    return file.type ? file.type : mimeTypes[fileExtension]
+-  }
+-
+   // check if mime type is set in the file object
+   if (file.type) {
+     return file.type",this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks.,why is this removed?
+2787,"@@ -71,7 +71,7 @@ class Feature extends BaseI18nLoop implements PropelSearchLoopInterface
+             new Argument(
+                 'order',
+                 new TypeCollection(
+-                    new Type\EnumListType(array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'manual', 'manual_reverse'))
++                    new Type\EnumListType(array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'alpha_reverse' , 'manual', 'manual_reverse'))
+                 ),
+                 'manual'
+             ),",Please could you remove the useless space.,"Same as above, there's an extra space before the bracket."
+2788,"@@ -1082,12 +1082,14 @@ public final class OrdsSegmentTermsEnum extends BaseTermsEnum {
+       if (FST.targetHasArcs(arc)) {
+         // System.out.println(""  targetHasArcs"");
+         result.grow(1+upto);
+-
++        if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
++          assert(arc.target >= 0);
++          assert(arc.target < Integer.MAX_VALUE);
++        }
+         fr.index.readFirstRealTargetArc(arc.target, arc, fstReader);
+
+         if (arc.bytesPerArc != 0) {
+           // System.out.println(""  array arcs"");
+-
+           int low = 0;
+           int high = arc.numArcs-1;
+           int mid = 0;",What's the point of this block (and isn't it effectively dead code)?,Shouldn't this be `<=` rather than `>`?
+2789,"@@ -5,7 +5,7 @@ class ForumSessionsController < ApplicationController
+   def new
+     sso = DiscourseSignOn.parse(
+       request.query_string,
+-      ENV[""DISCOURSE_SSO_SECRET""]
++      ENV.fetch(""DISCOURSE_SSO_SECRET""),
+     )
+     populate_sso_for_current_user(sso)
+     track_forum_access",Put a comma after the last parameter of a multiline method call.,"Do we need to check for `ENV[""DISCOURSE"
+2790,"@@ -0,0 +1,6 @@
++from dagster import job, SourceHashVersionStrategy
++
++
++@job(version_strategy=SourceHashVersionStrategy())
++def the_job():
++    ...",Newline at end of file plz,Are we missing a test for the case wher
+2791,"@@ -18,7 +18,10 @@ package v1alpha3
+
+ import (
+ 	""fmt""
++	""github.com/aws/aws-sdk-go/aws""
++	""k8s.io/apimachinery/pkg/types""
+ 	""reflect""
++	clusterv1 ""sigs.k8s.io/cluster-api/api/v1alpha3""
+ )
+
+ // Tags defines a map of tags.","Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily.",Please remove this line.
+2792,"@@ -1028,4 +1028,18 @@ class Queue
+             ]
+         );
+     }
++
++    /**
++     * Sets the timestamp of when an item last has been indexed.
++     *
++     * @param Item $item
++     */
++    public function updateIndexQueueByItem(Item $item)
++    {
++        $GLOBALS['TYPO3_DB']->exec_UPDATEquery(
++            'tx_solr_indexqueue_item',
++            'uid = ' . (int)$item->getIndexQueueUid(),
++            ['indexed' => time()]
++        );
++    }
+ }","Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like ""updateIndexTimeByItem(Item $item)""",Shouldn't this be `uid = ' . (int) $item->getIndexQueueUid()`?
+2793,"@@ -95,6 +95,8 @@ class visibility_of(object):
+
+
+ def _element_if_visible(element, visibility=True):
++    if isinstance(element, str) or isinstance(element, dict):
++           raise StaleElementReferenceException(""Invalid locator"")
+     return element if element.is_displayed() == visibility else False
+
+ ",This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.,Why is this error raised here? I don't see where the locator i
+2794,"@@ -45,6 +45,10 @@
+ #include <Kokkos_Macros.hpp>
+ #ifdef KOKKOS_ENABLE_CUDA
+
++#include <Kokkos_Core.hpp>
++#include <Kokkos_Cuda.hpp>
++#include <Kokkos_CudaSpace.hpp>
++
+ #include <cstdlib>
+ #include <iostream>
+ #include <sstream>",I assume this came from format?,"Shouldn't this be `<Kokkos_Cuda.hpp>`, not `<Kokkos_CudaSpace."
+2795,"@@ -56,6 +56,13 @@ class ReIndexTask extends AbstractTask
+      */
+     protected $indexingConfigurationsToReIndex = array();
+
++    /**
++     * Clear Index for selected sites and record types
++     *
++     * @var boolean
++     */
++    protected $clearSearchIndex;
++
+
+     /**
+      * Purges/commits all Solr indexes, initializes the Index Queue",I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code.,Shouldn't this be `protected`?
+2796,"@@ -237,6 +237,8 @@ func (km *KeyManagerStandard) getTLFCryptKeyParams(
+ 				kbfscrypto.CryptPublicKey{},
+ 				localMakeRekeyReadError(err)
+ 		}
++		km.log.CDebugf(ctx, ""Trying to decrypt with keys = %s"",
++			dumpConfig().Sdump(keys))
+ 		var index int
+ 		clientHalf, index, err = crypto.DecryptTLFCryptKeyClientHalfAny(ctx,
+ 			keys, flags&getTLFCryptKeyPromptPaper != 0)",Do we really need this? Seems like it would pollute the logs pretty badly.,"Can you also add the `keys` value in here, so we can see what it was before?"
+2797,"@@ -9,6 +9,8 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure
+ {
+     public struct MemoryPoolIterator2
+     {
++        private readonly static int _vectorSpan = Vector<byte>.Count;
++
+         private MemoryPoolBlock2 _block;
+         private int _index;
+ ",`Vector<byte>.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const.,Nit: I would prefer we called this `_count` instead of `_vectorSpan`.
+2798,"@@ -208,6 +208,9 @@ class PostgresqlStorageMigrationTest(unittest.TestCase):
+ class PostgresqlPermissionMigrationTest(unittest.TestCase):
+     def __init__(self, *args, **kw):
+         super(PostgresqlPermissionMigrationTest, self).__init__(*args, **kw)
++        from kinto.core.utils import sqlalchemy
++        if sqlalchemy is None:
++            return
+
+         from .test_permission import PostgreSQLPermissionTest
+         settings = PostgreSQLPermissionTest.settings.copy()",Can we use a skipIf decorator instead?,Is this still needed if we don't use `PostgreSQLPermissionTest`?
+2799,"@@ -3,6 +3,14 @@
+ module Faker
+   class Number < Base
+     class << self
++      ##
++      # Produce a random number.
++      #
++      # @param digits [Integer] Number of digits that the generated number should have.
++      # @return [Integer]
++      #
++      # @example
++      #   Faker::Number.number(digits: 10) #=> 1968353479
+       def number(legacy_digits = NOT_GIVEN, digits: 10)
+         warn_for_deprecated_arguments do |keywords|
+           keywords << :digits if legacy_digits != NOT_GIVEN",Missing version tags,This example makes it sound like `Faker::Number.number(digits: 10)` doesn't
+2800,"@@ -60,6 +60,11 @@ module Bolt
+         print_table('tasks' => tasks, 'modulepath' => modulepath)
+       end
+
++      def print_plugin_list(plugins, modulepath)
++        plugins.delete(:validate_resolve_reference)
++        print_table('plugins' => plugins, 'modulepath' => modulepath)
++      end
++
+       def print_plan_info(plan)
+         path = plan.delete('module')
+         plan['module_dir'] = if path.start_with?(Bolt::Config::Modulepath::MODULES_PATH)",I think this should also filter out `validate_resolve_reference` hooks.,Is there a reason we don't want to include `validate_resolve_reference` here?
+2801,"@@ -18,8 +18,8 @@ using System;
+ using System.Diagnostics;
+ using System.Security;
+ using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation;
+-using OpenTelemetry.Trace;
+ using OpenTelemetry.Metrics;
++using OpenTelemetry.Trace;
+
+ namespace OpenTelemetry.Exporter
+ {","unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution.",Why did you change this?
+2802,"@@ -1,9 +1,8 @@
+ # -*- coding: UTF-8 -*-
+-#globalCommands.py
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2006-2018 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Łukasz Golonka
++# Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Łukasz Golonka, Jakub Lukowicz
+
+ import time
+ import itertools",Feel free to remove this line,@Roxy-3D `#globalCommands` is already included in the `settings.py`
+2803,"@@ -25,7 +25,7 @@ module Subscriptions
+   end
+
+   def click_upcase_call_to_action_in_header
+-    click_link ""Upcase Membership""
++    click_link I18n.t(""shared.subscriptions.single_user"")
+   end
+
+   def settings_page",~~Should this match the key updated above?~~ :+1:,"This should probably be `I18n.t(""shared.subscriptions.single_user"")`"
+2804,"@@ -180,7 +180,9 @@ func isDirExcludedByFile(dir, tagFilename, header string) bool {
+ 		Warnf(""could not open exclusion tagfile: %v"", err)
+ 		return false
+ 	}
+-	defer f.Close()
++	defer func() {
++		_ = f.Close()
++	}()
+ 	buf := make([]byte, len(header))
+ 	_, err = io.ReadFull(f, buf)
+ 	// EOF is handled with a dedicated message, otherwise the warning were too cryptic",`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`.,"`f, err := os.Create(excludeFile)` would be more idiomatic."
+2805,"@@ -10,11 +10,10 @@ import (
+
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/porcelain""
+-	""github.com/filecoin-project/go-filecoin/types""
+ )
+
+ // MinerCreate runs the `miner create` command against the filecoin process
+-func (f *Filecoin) MinerCreate(ctx context.Context, pledge uint64, collateral *types.AttoFIL, options ...ActionOption) (address.Address, error) {
++func (f *Filecoin) MinerCreate(ctx context.Context, pledge uint64, collateral *big.Int, options ...ActionOption) (address.Address, error) {
+ 	var out address.Address
+
+ 	sPledge := fmt.Sprintf(""%d"", pledge)",collateral is in FIL,Why was this removed?
+2806,"@@ -84,6 +84,11 @@ func (q *ChannelEventQueue) dispatchMessage() {
+ 			log.LOGGER.Warnf(""node id is not found in the message"")
+ 			continue
+ 		}
++		_, ok := q.channelPool.Load(nodeID)
++		if !ok {
++			rChannel := make(chan model.Event, rChanBufSize)
++			q.channelPool.LoadOrStore(nodeID, rChannel)
++		}
+ 		rChannel, err := q.getRChannel(nodeID)
+ 		if err != nil {
+ 			log.LOGGER.Infof(""fail to get dispatch channel for %s"", nodeID)",We should not create channel of node which are not connected.,"should we move this block into `getRChannel`, and then call"
+2807,"@@ -40,6 +40,7 @@ class MongoCredentials {
+    * @param {string} [options.username] The username used for authentication
+    * @param {string} [options.password] The password used for authentication
+    * @param {string} [options.source] The database that the user should authenticate against
++   * @param {string} [options.db] see options.source
+    * @param {string} [options.mechanism] The method used to authenticate
+    * @param {object} [options.mechanismProperties] Special properties used by some types of auth mechanisms
+    */","I think the docstring should say something like ""Alias for the `source` option"" or something similar.","I don't think we need to reference the db in this method, o"
+2808,"@@ -129,6 +129,14 @@ public class Product implements Serializable {
+     private String nutritionDataPer;
+     @JsonProperty(""no_nutrition_data"")
+     private String noNutritionData;
++    @JsonProperty(""other_information_fr"")
++    private String otherInformation;
++    @JsonProperty(""conservation_conditions_fr"")
++    private String conservationConditions;
++    @JsonProperty(""recycling_instructions_to_discard_fr"")
++    private String recyclingInstructionsToDiscard;
++    @JsonProperty(""recycling_instructions_to_recycle_fr"")
++    private String recyclingInstructionsToRecycle;
+     @JsonProperty(""warning"")
+     private String warning;
+     @JsonProperty(""customer_service"")",Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned,I think we can simplify this to just `recycling_instructions_to_discard`
+2809,"@@ -132,6 +132,7 @@ struct st_h2o_http3client_req_t {
+ static int handle_input_expect_data_frame(struct st_h2o_http3client_req_t *req, const uint8_t **src, const uint8_t *src_end,
+                                           int err, const char **err_desc);
+ static void start_request(struct st_h2o_http3client_req_t *req);
++static void destroy_request(struct st_h2o_http3client_req_t *req);
+
+ static struct st_h2o_http3client_conn_t *find_connection_for_origin(h2o_httpclient_ctx_t *ctx, const h2o_url_scheme_t *scheme,
+                                                                     h2o_iovec_t authority)",Declaration here is `static` but the definition at the bottom is non-static?,why is this needed?
+2810,"@@ -65,6 +65,9 @@ type WriterOptions struct {
+ 	// write in a single request, if supported. Larger objects will be split into
+ 	// multiple requests.
+ 	BufferSize int
++	// Content-MD5 which may be used as a message integrity check (MIC)
++	// https://tools.ietf.org/html/rfc1864
++	ContentMD5 string
+ 	// Metadata holds key/value strings to be associated with the blob.
+ 	// Keys are guaranteed to be non-empty and lowercased.
+ 	Metadata map[string]string","Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`.",We already have a similar structure in `pkg/storage/blob.go` - can we re
+2811,"@@ -610,11 +610,11 @@ func (i *Initializer) configureGatewayInterface(gatewayIface *interfacestore.Int
+ 	gatewayIface.IPs = []net.IP{}
+ 	if i.networkConfig.TrafficEncapMode.IsNetworkPolicyOnly() {
+ 		// Assign IP to gw as required by SpoofGuard.
+-		if i.nodeConfig.NodeIPv4Addr != nil {
++		if i.nodeConfig.NodeTransportIPv4Addr != nil {
+ 			i.nodeConfig.GatewayConfig.IPv4 = i.nodeConfig.NodeTransportIPv4Addr.IP
+ 			gatewayIface.IPs = append(gatewayIface.IPs, i.nodeConfig.NodeTransportIPv4Addr.IP)
+ 		}
+-		if i.nodeConfig.NodeIPv6Addr != nil {
++		if i.nodeConfig.NodeTransportIPv6Addr != nil {
+ 			i.nodeConfig.GatewayConfig.IPv6 = i.nodeConfig.NodeTransportIPv6Addr.IP
+ 			gatewayIface.IPs = append(gatewayIface.IPs, i.nodeConfig.NodeTransportIPv6Addr.IP)
+ 		}",Was it a bug?,can you also change `NodeTransportIPv4Addr` to `NodeTransportIPv6Addr`?
+2812,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done,"The `attr_value` argument is a dict and not a dict, so `attr_value['string'] is not None` is always true."
+2813,"@@ -66,6 +66,7 @@ def replace_variables(win_id, arglist):
+         'url:host': lambda: _current_url(tabbed_browser).host(),
+         'clipboard': utils.get_clipboard,
+         'primary': lambda: utils.get_clipboard(selection=True),
++        'link_hovered': lambda: tabbed_browser._now_focused._last_hovered_link,
+     }
+     for key in list(variables):
+         modified_key = '{' + key + '}'","You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead.",What's the difference between `url:host` and `url_hovered`?
+2814,"@@ -0,0 +1,10 @@
++class InvitationMailer < BaseMailer
++  def invitation(invitation_id)
++    @invitation = Invitation.find(invitation_id)
++
++    mail(
++      to: @invitation.email,
++      subject: 'Invitation'
++    )
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,How about `invitation_id`?
+2815,"@@ -0,0 +1,15 @@
++namespace Fixtures.Azure.SwaggerBatSubscriptionIdApiVersion
++{
++    using System;
++    using System.Collections;
++    using System.Collections.Generic;
++    using System.Threading;
++    using System.Threading.Tasks;
++    using Microsoft.Rest;
++    using Microsoft.Azure;
++    using Models;
++
++    public static partial class MicrosoftAzureTestUrlExtensions
++    {
++    }
++}",We should file a bug for this - we don't need the extensions class if there are no operations on the client,Can we remove this file?
+2816,"@@ -415,6 +415,8 @@ func (p *csiPlugin) NewMounter(
+ 	}
+ 	klog.V(4).Info(log(""created path successfully [%s]"", dataDir))
+
++	mounter.MetricsProvider = NewMetricsCsi(volumeHandle, dir, csiDriverName(driverName))
++
+ 	// persist volume info data for teardown
+ 	node := string(p.host.GetNodeName())
+ 	volData := map[string]string{",Is it possible to import from k8s instead of copy in? :),@mfojtik this will panic if the driver doesn't exist for some reason
+2817,"@@ -25,7 +25,7 @@ class ProjectCacheProvider extends \Psalm\Internal\Provider\ProjectCacheProvider
+      *
+      * @return void
+      */
+-    public function processSuccessfulRun($start_time)
++    public function processSuccessfulRun(float $start_time)
+     {
+         $this->last_run = (int) $start_time;
+     }",`@param float` can be dropped here.,?
+2818,"@@ -35,7 +35,7 @@ import java.util.NoSuchElementException;
+ public abstract class CoprocessIterator<T> implements Iterator<T> {
+   protected final TiSession session;
+   protected final List<RegionTask> regionTasks;
+-  protected final DAGRequest dagRequest;
++  protected DAGRequest dagRequest;
+   protected final DataType[] handleTypes;
+   //  protected final ExecutorCompletionService<Iterator<SelectResponse>> completionService;
+   protected RowReader rowReader;",maybe we can leave this change un-reverted.,protected field should be removed.
+2819,"@@ -5,7 +5,7 @@
+
+ package net.sourceforge.pmd.lang.java.ast;
+
+-public class ASTMethodDeclarator extends AbstractJavaNode {
++public class ASTMethodDeclarator extends AbstractJavaAccessNode {
+     public ASTMethodDeclarator(int id) {
+         super(id);
+     }","I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode",was this a bug?
+2820,"@@ -0,0 +1,16 @@
++package net.runelite.api.events.player.headicon;
++
++import lombok.Getter;
++import net.runelite.api.Player;
++import net.runelite.api.events.Event;
++
++public abstract class PlayerHeadIconChanged implements Event
++{
++	@Getter
++	private final Player player;
++
++	public PlayerHeadIconChanged(Player player)
++	{
++		this.player = player;
++	}
++}",delete this class,"As above, make this an abstract class."
+2821,"@@ -378,7 +378,7 @@ window.PopulatorView = countlyView.extend({
+             if ([""true"", ""false""].indexOf(s) !== -1) {
+                 return s === ""true"";
+             }
+-            else if (/^[1-9][0-9]+|0$/.test(s)) {
++            else if (/^[1-9][0-9]+|0|[1-9]$/.test(s)) {
+                 return parseInt(s);
+             }
+             else {",Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick.,The `[1-9][0-9]+` and `[1-9][1-9]` mat
+2822,"@@ -58,7 +58,7 @@ TDTWriter::TDTWriter(std::ostream *outStream, bool takeOwnership) {
+   df_writeNames = true;
+ }
+
+-TDTWriter::~TDTWriter() throw() {
++TDTWriter::~TDTWriter() {
+   // close the writer if it's still open:
+   if (dp_ostream != nullptr) close();
+ }",I've been meaning to fix this for a while. Thanks.,This throws. Shouldn't this be `TDTWri
+2823,"@@ -27,10 +27,12 @@ public class Program
+     {
+         using var otel = Sdk.CreateTracerProvider(b => b
+             .AddActivitySource(""MyCompany.MyProduct.MyLibrary"")
+-            .AddProcessorPipeline(pipeline =>
+-            {
+-                pipeline.AddProcessor(current => new MyActivityProcessor());
+-            }));
++
++            // TODO: seems buggy if you remove A and B here, MyActivityProcessor(C).OnEnd is not called.
++            // TODO: should the dispose order be C, B, A or A, B C?
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""A"")))
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""B"")))
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""C""))));
+
+         using (var activity = MyActivitySource.StartActivity(""SayHello""))
+         {","This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?",I think this is something that should
+2824,"@@ -11,13 +11,14 @@ from __future__ import absolute_import
+ from __future__ import print_function
+ from scapy.error import Scapy_Exception
+ import scapy.modules.six as six
++from scapy.compat import *
+
+ ###############################
+ ## Direct Access dictionary  ##
+ ###############################
+
+ def fixname(x):
+-    if x and x[0] in ""0123456789"":
++    if x and str(x[0]) in ""0123456789"":
+         x = ""n_""+x
+     return x.translate(""________________________________________________0123456789_______ABCDEFGHIJKLMNOPQRSTUVWXYZ______abcdefghijklmnopqrstuvwxyz_____________________________________________________________________________________________________________________________________"")
+ ","If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?","I think `x and (x[0] in ""0123456789"").startswith(""0123456789"")` is better."
+2825,"@@ -96,8 +96,8 @@ public class TwoPhaseCommitter {
+    */
+   private static final int TXN_COMMIT_BATCH_SIZE = 768 * 1024;
+
+-  /** unit is second */
+-  private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3000;
++  /** unit is millisecond */
++  private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3600000;
+
+   private static final long MAX_RETRY_TIMES = 3;
+ ",3.6 seconds? what does it stand for?,Can we make this configurable?
+2826,"@@ -834,6 +834,19 @@ module Beaker
+         sign_certificate_for(default)
+       end
+
++      # Get a facter fact from a provided host
++      #
++      # @param [Host] host  The host to query the fact for
++      # @param [String] name The name of the fact to query for
++      # @!macro common_opts
++      #
++      # @returns String The value of the fact 'name' on the provided host
++      # @raise  [FailTest] Raises an exception if call to facter fails
++      def fact host, name, opts= {}
++        result = on host, facter(name, opts)
++        result.stdout.chomp
++      end
++
+     end
+   end
+ end","If the command fails, is stdout nil or """"?","Since this method is only called from the tests, do you think it's worth p"
+2827,"@@ -84,10 +84,10 @@ public interface AutoRestValidationTest {
+      * used by Retrofit to perform actually REST calls.
+      */
+     interface AutoRestValidationTestService {
+-        @GET(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}"")
++        @GET(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}"")
+         Call<ResponseBody> validationOfMethodParameters(@Path(""subscriptionId"") String subscriptionId, @Path(""resourceGroupName"") String resourceGroupName, @Path(""id"") int id, @Query(""apiVersion"") String apiVersion);
+
+-        @PUT(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}"")
++        @PUT(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}"")
+         Call<ResponseBody> validationOfBody(@Path(""subscriptionId"") String subscriptionId, @Path(""resourceGroupName"") String resourceGroupName, @Path(""id"") int id, @Body Product body, @Query(""apiVersion"") String apiVersion);
+
+     }",Why is api-version now removed in the generated code?,where does the `api-version` parameter get removed?
+2828,"@@ -0,0 +1,3 @@
++from mmdet.utils import Registry
++
++OPTIMIZERS = Registry('optimizer')",We may register all built-in optimizers of PyTorch here to simplify the builder.,why not just `mmdet.optimizer`?
+2829,"@@ -109,7 +109,8 @@ std::string BaseGenerator::WrapInNameSpace(const Namespace *ns,
+                                            const std::string &name) const {
+   if (CurrentNameSpace() == ns) return name;
+   std::string qualified_name = qualifying_start_;
+-  for (auto it = ns->components.begin(); it != ns->components.end(); ++it)
++  auto &components = ns->components;
++  for (auto it = components.begin(); it != components.end(); ++it)
+     qualified_name += *it + qualifying_separator_;
+   return qualified_name + name;
+ }",No need for this new variable.,I'm not sure I see the point of
+2830,"@@ -87,11 +87,11 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			c._vnode = newVNode;
+
+ 			// Invoke getDerivedStateFromProps
+-			let s = c._nextState || c.state;
++			if (c._nextState==null) {
++				c._nextState = c.state;
++			}
+ 			if (newType.getDerivedStateFromProps!=null) {
+-				oldState = assign({}, c.state);
+-				if (s===c.state) s = c._nextState = assign({}, s);
+-				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
++				c.setState(newType.getDerivedStateFromProps(newVNode.props, c._nextState));
+ 			}
+
+ 			// Invoke pre-render lifecycle methods",doesn't this enqueue a double render or is that safeguarded somehow,Shouldn't this be `c.setState(o
+2831,"@@ -878,7 +878,9 @@ func (a *Account) randomClient() *client {
+ 	}
+ 	var c *client
+ 	for c = range a.clients {
+-		break
++		if c.acc == a {
++			break
++		}
+ 	}
+ 	return c
+ }",But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route.,This was a bug not related to t
+2832,"@@ -194,7 +194,18 @@ std::shared_ptr<Engine> ADIOS::Open(const std::string &name,
+                                     ""HDF5 library, can't use HDF5\n"");
+ #endif
+     }
+-
++    else if (type == ""HDF5Reader"") // -Junmin
++    {
++//#if defined(ADIOS_HAVE_PHDF5) && defined(ADIOS_HAVE_MPI)
++#ifdef ADIOS_HAVE_PHDF5
++        //#ifdef ADIOS_HAVE_MPI
++        return std::make_shared<HDF5Reader>(*this, name, accessMode, mpiComm,
++                                            method);
++#else
++        throw std::invalid_argument(""ERROR: this version didn't compile with ""
++                                    ""HDF5 library, can't use HDF5\n"");
++#endif
++    }
+     else
+     {
+         if (m_DebugMode == true)","Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`","Can we remove the `type == ""HDF5Reader"" && defined(ADIOS_HAVE_PHDF5)` as well?"
+2833,"@@ -282,6 +282,7 @@ module RSpec
+           context ""with a non-string and a string"" do
+             it ""concats the args"" do
+               expect(group_value_for Object, 'group').to eq(""Object group"")
++              expect(group_value_for 'group', Object).to eq(""group Object"")
+             end
+           end
+ ","Would be nice to put this in a separate context named `""with a string and a non-string""` (since that's what it is -- it's definitely not a non-string and a string!).",Prefer single-quoted strings when you don't need string interpolation or speci
+2834,"@@ -1265,7 +1265,7 @@ void ResStatisticsStatement::setStatistics(SRVR_STMT_HDL *pSrvrStmt, SQLSTATS_TY
+ #define MAX_PERTABLE_STATS_DESC		30
+
+ #define MAX_MASTERSTATS_ENTRY		31
+-#define MAX_MEASSTATS_ENTRY			34
++#define MAX_MEASSTATS_ENTRY			26
+ #define MAX_PERTABLE_ENTRY			14
+
+ 	int i;",Should MAX_PERTABLE_ENTRY here be 10 ?,"Not a typo, but should be a space."
+2835,"@@ -29,6 +29,17 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+         private static readonly ArraySegment<byte> _emptyData = new ArraySegment<byte>(new byte[0]);
+         private static readonly byte[] _hex = Encoding.ASCII.GetBytes(""0123456789abcdef"");
+
++        private static readonly byte[] _bytesConnectionClose = Encoding.ASCII.GetBytes(""\r\nConnection: close"");
++        private static readonly byte[] _bytesConnectionKeepAlive = Encoding.ASCII.GetBytes(""\r\nConnection: keep-alive"");
++        private static readonly byte[] _bytesTransferEncodingChunked = Encoding.ASCII.GetBytes(""\r\nTransfer-Encoding: chunked"");
++        private static readonly byte[] _bytesHttpVersion1_0 = Encoding.ASCII.GetBytes(""HTTP/1.0 "");
++        private static readonly byte[] _bytesHttpVersion1_1 = Encoding.ASCII.GetBytes(""HTTP/1.1 "");
++        private static readonly byte[] _bytesContentLengthZero = Encoding.ASCII.GetBytes(""\r\nContent-Length: 0"");
++        private static readonly byte[] _bytesSpace = Encoding.ASCII.GetBytes("" "");
++        private static readonly byte[] _bytesServer = Encoding.ASCII.GetBytes(""\r\nServer: Kestrel"");
++        private static readonly byte[] _bytesDate = Encoding.ASCII.GetBytes(""Date: "");
++        private static readonly byte[] _bytesEndHeaders = Encoding.ASCII.GetBytes(""\r\n\r\n"");
++
+         private readonly object _onStartingSync = new Object();
+         private readonly object _onCompletedSync = new Object();
+         private readonly FrameRequestHeaders _requestHeaders = new FrameRequestHeaders();",Should move these out of frame into a static class? Similar to reason phrases?,Should these be called `_bytesConnectionClose` and `_bytesConnectionKeepAlive`
+2836,"@@ -608,7 +608,7 @@ std::vector<RouteStep> buildIntersections(std::vector<RouteStep> steps)
+     {
+         auto &step = steps[step_index];
+         const auto instruction = step.maneuver.instruction;
+-        if (instruction.type == TurnType::Suppressed)
++        if (instruction.type == TurnType::Suppressed || instruction.type == TurnType::UseLane)
+         {
+             BOOST_ASSERT(steps[last_valid_instruction].mode == step.mode);
+             // count intersections. We cannot use exit, since intersections can follow directly",That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?,`if (instruction.type == TurnType::Suppressed || instruction.type == 'UseLane')`
+2837,"@@ -21,14 +21,13 @@ import (
+
+ 	""github.com/iotexproject/go-pkgs/hash""
+ 	""github.com/iotexproject/iotex-address/address""
+-	""github.com/iotexproject/iotex-proto/golang/iotextypes""
+-
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/db/trie""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/state""
++	""github.com/iotexproject/iotex-proto/golang/iotextypes""
+ )
+
+ type (","no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs",Could you also change this line to `iotexproject/iotex-proto/golang/iotextypes`
+2838,"@@ -600,6 +600,14 @@ static void
+ app_exit_event(void)
+ {
+     check_stack_alignment();
++
++#if defined(LINUX) && defined(X86_64)
++    /* i#4335: Test allocation of more than 2.8GB in unreachable heap */
++    for (int i = 0; i != 50; ++i)
++    {
++        malloc(100000000);
++    }
++#endif
+ }
+
+ DR_EXPORT void",Looks like a clang-format style violation: should turn Travis red.,Wouldn't it be better to use `for (i = 0; i != 50; ++i)` ?
+2839,"@@ -127,6 +127,11 @@ MESSAGE
+
+       # Run all examples if none match the configured filters (default: `false`).
+       add_setting :run_all_when_everything_filtered
++
++      # Allow user to configure their own success/pending/failure colors
++      add_setting :success_color
++      add_setting :pending_color
++      add_setting :failure_color
+
+       # Seed for random ordering (default: generated randomly each run).
+       #","I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that.",We should add a validation that ensures that these colors are either `true` or `
+2840,"@@ -31,6 +31,13 @@ import { STORE_NAME, AMP_MODE_PRIMARY, AMP_MODE_SECONDARY } from './constants';
+
+ const { createRegistrySelector } = Data;
+
++function getSiteInfoProperty( propName ) {
++	return createRegistrySelector( ( select ) => () => {
++		const siteInfo = select( STORE_NAME ).getSiteInfo() || {};
++		return siteInfo[ propName ];
++	} );
++}
++
+ // Actions
+ const RECEIVE_SITE_INFO = 'RECEIVE_SITE_INFO';
+ ","Not sure if this needs a doc block or not since it's completely internal, but   for cleaning this up. (@felixarntz docs?)","Since `getSiteInfo` doesn't have a default value, you could just omit the `|| {}` part."
+2841,"@@ -616,7 +616,8 @@ libponyc.benchmarks.buildoptions += -DLLVM_BUILD_MODE=$(LLVM_BUILD_MODE)
+
+ libgbenchmark.buildoptions := \
+   -Wshadow -pedantic -pedantic-errors \
+-  -Wfloat-equal -fstrict-aliasing -Wstrict-aliasing -Wno-invalid-offsetof \
++  -fstrict-aliasing -Wstrict-aliasing \
++  -Wno-invalid-offsetof -Wno-deprecated-declarations \
+   -DHAVE_POSIX_REGEX -DHAVE_STD_REGEX -DHAVE_STEADY_CLOCK
+
+ ifneq ($(ALPINE),)",The change here is to address what exactly?,You probably want to run `make lint` on this file.
+2842,"@@ -101,9 +101,14 @@ const (
+ // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob.
+ type Options struct {
+ 	// Credential represents the authorizer for SignedURL.
+-	// Required to use SignedURL.
++	// Required to use SignedURL. If you're using MSI for authentication, this will
++	// attempt to be loaded lazily the first time you call SignedURL.
+ 	Credential azblob.StorageAccountCredential
+
++	// IsMSIEnvironment represents if the blob storage is being authenticated via
++	// a Managed System Identity.
++	IsMSIEnvironment bool
++
+ 	// SASToken can be provided along with anonymous credentials to use
+ 	// delegated privileges.
+ 	// See https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1#shared-access-signature-parameters.","Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`.",Does SignedURL need IsMSIEnvironment?
+2843,"@@ -23,7 +23,7 @@
+
+ ExplicitBitVect::ExplicitBitVect(unsigned int size, bool bitsSet) {
+   d_size = 0;
+-  dp_bits = 0;
++  dp_bits = nullptr;
+   d_numOnBits = 0;
+   _initForSize(size);
+   if (bitsSet) {",Was this done automatically or by hand?,Please use `std::unique_ptr` or `std::unique_ptr` instead.
+2844,"@@ -136,6 +136,18 @@ module Bolt
+       end
+       private :expand_targets
+
++      def remove_target(current_group, target, desired_group)
++        if current_group.name == desired_group
++          current_group.remove_target(target)
++        end
++        current_group.groups.each do |child_group|
++          # If target was in current group, remove it from all child groups
++          desired_group = child_group.name if current_group.name == desired_group
++          remove_target(child_group, target, desired_group)
++        end
++      end
++      private :remove_target
++
+       def add_target(current_group, target, desired_group)
+         if current_group.name == desired_group
+           current_group.add_target(target)","This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?",Style/GuardClause: Use a guard clause instead of wrapping the code inside a conditional expression.
+2845,"@@ -3194,7 +3194,7 @@ void CoreChecks::PostCallRecordCreateDevice(VkPhysicalDevice gpu, const VkDevice
+             std::copy(std::istreambuf_iterator<char>(read_file), {}, std::back_inserter(validation_cache_data));
+             read_file.close();
+         } else {
+-            LogInfo(core_checks->device, ""VUID-NONE"",
++            LogInfo(core_checks->device, ""UNASSIGNED-cache-file-error"",
+                     ""Cannot open shader validation cache at %s for reading (it may not exist yet)"",
+                     core_checks->validation_cache_path.c_str());
+         }",Should this be a constant somewhere?,"There is no reason for this message to be logged at `ERROR`, unless I'm missing something."
+2846,"@@ -17,5 +17,9 @@
+ using System.Runtime.CompilerServices;
+
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Tests"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.Http"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.AspNet"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.AspNetCore"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.GrpcNetClient"" + AssemblyInfo.PublicKey)]
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"" + AssemblyInfo.MoqPublicKey)]
+ [assembly: InternalsVisibleTo(""Benchmarks"" + AssemblyInfo.PublicKey)]",nit: sort alphabetically.,I don't think this will work - you need to add `using System.Runtime.CompilerServices;` to the top
+2847,"@@ -28,6 +28,10 @@ import org.apache.solr.common.SolrException;
+  * @lucene.internal
+  */
+ class JsonQueryConverter {
++  public static final String paramsPrefix = ""_tt"";
++
++  public static final Object contextKey = JsonQueryConverter.class.getSimpleName();
++
+   private int numParams = 0;
+
+   String toLocalParams(Object jsonQueryObject, Map<String, String[]> additionalParams) {","Now, It's redundant, I suppose.",Why is this `public`? We don't seem to be using it in this class.
+2848,"@@ -70,6 +70,8 @@ type ChooserList interface {
+ //
+ // peerlist.List and ListImplementation compose well with sharding schemes the
+ // degenerate to returning the only available peer.
++//
++// Deprecated in favor of ""go.uber.org/yarpc/peer/peerlist/v2"".Implementation.
+ type ListImplementation interface {
+ 	transport.Lifecycle
+ ","nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use ""go.uber.org/yarpc/peer/peerlist/v2"".Implementation instead.",why is this deprecated?
+2849,"@@ -41,9 +41,9 @@ func lookupTelemetryEndpoint(cfg config.Local, genesisNetwork protocol.NetworkID
+ 	for _, bootstrapID := range bootstrapArray {
+ 		addrs, err := ReadFromSRV(""telemetry"", bootstrapID, cfg.FallbackDNSResolverAddress)
+ 		if err != nil {
+-			log.Warnf(""An issue occurred reading telemetry entry for: %s"", bootstrapID)
++			log.Infof(""An issue occurred reading telemetry entry for: %s"", bootstrapID)
+ 		} else if len(addrs) == 0 {
+-			log.Warnf(""No telemetry entry for: %s"", bootstrapID)
++			log.Infof(""No telemetry entry for: %s"", bootstrapID)
+ 		} else {
+ 			return addrs[0]
+ 		}","nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well.",I don't think we should
+2850,"@@ -4,7 +4,16 @@ namespace Datadog.Trace.ClrProfiler
+ {
+     internal static class NativeMethods
+     {
+-        [DllImport(""Datadog.Trace.ClrProfiler.Native.dll"")]
+-        public static extern bool IsProfilerAttached();
++        public static class Windows
++        {
++            [DllImport(""Datadog.Trace.ClrProfiler.Native.dll"")]
++            public static extern bool IsProfilerAttached();
++        }
++
++        public static class Linux
++        {
++            [DllImport(""Datadog.Trace.ClrProfiler.Native.so"")]
++            public static extern bool IsProfilerAttached();
++        }
+     }
+ }","I believe this can be fixed with the original code if you just omit the "".dll"" file extension so it reads `[DllImport(""Datadog.Trace.ClrProfiler.Native"")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`.",Why is this being chang
+2851,"@@ -71,6 +71,11 @@ class UpdateManager {
+                 UserPreferences.setEpisodeCleanupValue(oldValueInDays * 24);
+             } // else 0 or special negative values, no change needed
+         }
++        if (oldVersionCode < 1070197) {
++            if (prefs.getBoolean(UserPreferences.PREF_MOBILE_UPDATE_OLD, false)) {
++                prefs.edit().putString(UserPreferences.PREF_MOBILE_UPDATE, ""everything"").apply();
++            }
++        }
+     }
+
+ }","couldn't we just read the boolean as a string (I would assume that this return ""true"" or ""false""), migrate if to its new value and keep using the same pref key?",shouldn't this be `User
+2852,"@@ -126,6 +126,7 @@ static int skip_file_check = 0;
+
+ static int cache_mode = 1;
+
++static int json_input = 0;
+ static int jx_input = 0;
+ static char *jx_context = NULL;
+ ","If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know.",Let's call this `json_input_count` or something.
+2853,"@@ -40,12 +40,12 @@ namespace Microsoft.Sarif.Viewer
+         {
+             if (serviceProvider == null)
+             {
+-                throw new ArgumentNullException(""serviceProvider"");
++                throw new ArgumentNullException(nameof(serviceProvider));
+             }
+
+             if (region == null)
+             {
+-                throw new ArgumentNullException(""location"");
++                throw new ArgumentNullException(nameof(region));
+             }
+
+             m_serviceProvider = serviceProvider;",This one was wrong.,"Since this is a breaking change, we should keep "
+2854,"@@ -1697,9 +1697,14 @@ type Observer interface {
+ 	// updated locally, but not yet saved at the server.
+ 	LocalChange(ctx context.Context, node Node, write WriteRange)
+ 	// BatchChanges announces that the nodes have all been updated
+-	// together atomically.  Each NodeChange in changes affects the
+-	// same top-level folder and branch.
+-	BatchChanges(ctx context.Context, changes []NodeChange)
++	// together atomically.  Each NodeChange in `changes` affects the
++	// same top-level folder and branch. `allAffectedNodeIDs` is a
++	// list of all the nodes that had their underlying data changed,
++	// even if it wasn't an user-visible change (e.g., if a
++	// subdirectory was updated, the directory block for the TLF root
++	// is updated but that wouldn't be visible to a user).
++	BatchChanges(ctx context.Context, changes []NodeChange,
++		allAffectedNodeIDs []NodeID)
+ 	// TlfHandleChange announces that the handle of the corresponding
+ 	// folder branch has changed, likely due to previously-unresolved
+ 	// assertions becoming resolved.  This indicates that the listener",What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected.,I thought you were going to pass in all the node
+2855,"@@ -1065,7 +1065,6 @@ error:
+  * process, mode_switch_buf_sz is maximum size for switch code, and
+  * mode_switch_data is the address where the app stack pointer is stored.
+  */
+-
+ static size_t
+ generate_switch_mode_jmp_to_hook(HANDLE phandle, byte *local_code_buf,
+                                  byte *mode_switch_buf, byte *hook_location,","> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64.",Why remove the blank line?
+2856,"@@ -200,6 +200,12 @@ module RSpec::Core
+         @exception_presenter.fully_formatted(failure_number, colorizer)
+       end
+
++      # @return [Array] The failure information fully formatted in the way that
++      #   RSpec's built-in formatters emit, split by line.
++      def fully_formatted_lines(failure_number, colorizer=::RSpec::Core::Formatters::ConsoleCodes)
++        @exception_presenter.fully_formatted_lines(failure_number, colorizer)
++      end
++
+     private
+
+       def initialize(example, exception_presenter=Formatters::ExceptionPresenter::Factory.new(example).build)","Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already.",Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
+2857,"@@ -14,18 +14,10 @@
+  */
+ package com.google.api.codegen;
+
+-/**
+- * A SnippetSetRunner takes the element, snippet file, and context as input and then uses the
+- * Snippet Set templating engine to generate an output document.
+- */
++/** Defines the SNIPPET_RESOURCE_ROOT. */
+ public final class SnippetSetRunner {
+
+   /** The path to the root of snippet resources. */
+   public static final String SNIPPET_RESOURCE_ROOT =
+       SnippetSetRunner.class.getPackage().getName().replace('.', '/');
+-
+-  public interface Generator<Element> {
+-    /** Runs the code generation. */
+-    GeneratedResult generate(Element element, String snippetFileName, CodegenContext context);
+-  }
+ }",Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?,"This is the only part of this change, the rest of the changes are reverted."
+2858,"@@ -60,6 +60,10 @@ type rule struct {
+ 	// The parent Policy ID. Used to identify rules belong to a specified
+ 	// policy for deletion.
+ 	PolicyUID types.UID
++	// The metadata of parent Policy. Used to associate the rule with Policy
++	// for troubleshooting purpose (logging and CLI).
++	PolicyName      string
++	PolicyNamespace string
+ }
+
+ // hashRule calculates a string based on the rule's content.","Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?",what is the difference between `PolicyName` and `PolicyNamespace`?
+2859,"@@ -11,7 +11,6 @@ import (
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/client-go/tools/cache""
+-	""k8s.io/client-go/util/workqueue""
+ 	""k8s.io/klog""
+
+ 	beehiveContext ""github.com/kubeedge/beehive/pkg/core/context""","For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?",Is this import still needed?
+2860,"@@ -865,7 +865,8 @@ public abstract class ProcessEngineConfigurationImpl extends ProcessEngineConfig
+
+
+   // telemetry ///////////////////////////////////////////////////////
+-  protected boolean telemetryEnabled = false;
++  /** if set to true the telemetry will be enabled from the first engine start*/
++  protected boolean telemetryInitialized = false;
+   /** The endpoint which telemetry is sent to */
+   protected String telemetryEndpoint = ""https://api.telemetry.camunda.cloud/pings"";
+ ","I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime.",Please rename to `telemetryInitialized`
+2861,"@@ -105,5 +105,10 @@ namespace Microsoft.Rest.Generator.NodeJS
+                 return requiredParams.ToString();
+             }
+         }
++
++        public bool ContainsTimeSpan
++        {
++            get { return this.Methods.FirstOrDefault(m => m.Parameters.FirstOrDefault(p => p.Type == PrimaryType.TimeSpan) != null) != null; }
++        }
+     }
+ }",please use new line to maintain reasonable line width,This should have a unit test.
+2862,"@@ -67,6 +67,9 @@ func (s *server) fileUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 	var fileSize uint64
+
+ 	ta := s.createTag(w, r)
++	if ta == nil {
++		return
++	}
+
+ 	// Add the tag to the context
+ 	r = r.WithContext(context.WithValue(r.Context(), tags.TagsContextKey{}, ta))",I would skip this check or add an internal server error response.,"@snehachhabria, does this look right? `"
+2863,"@@ -7,6 +7,12 @@ const createDist = (buildConfig = config.defaultBuildConfig, options) => {
+   config.buildConfig = buildConfig
+   config.update(options)
+
++  if (config.notarize) {
++    notarize = config.notarize
++    notary_user = config.notary_user
++    notary_password = config.notary_password
++  }
++
+   util.updateBranding()
+   fs.removeSync(path.join(config.outputDir, 'dist'))
+   config.buildTarget = 'create_dist'",missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one,It looks like `notary_user` and `notary
+2864,"@@ -538,11 +538,10 @@ func TestDdevImportDB(t *testing.T) {
+ 				assert.True(settingsHashSalt)
+ 			case ""wordpress"":
+ 				// nolint: vetshadow
+-				hasAuthSalt, err := fileutil.FgrepStringInFile(app.SiteSettingsPath, ""SECURE_AUTH_SALT"")
++				hasAuthSalt, err := fileutil.FgrepStringInFile(app.SiteLocalSettingsPath, ""SECURE_AUTH_SALT"")
+ 				assert.NoError(err)
+ 				assert.True(hasAuthSalt)
+ 			}
+-
+ 		}
+
+ 		if site.DBTarURL != """" {","This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath.","I think this can be reverted, since `fileutil.FgrepStringInFile` will not work for some reason."
+2865,"@@ -26,10 +26,13 @@ import (
+ 	""os/exec""
+ 	""path/filepath""
+ 	""strings""
++
++	ecpb ""kythe.io/kythe/proto/extraction_config_go_proto""
+ )
+
+ // kytheConfigFileName The name of the Kythe extraction config
+ const kytheExtractionConfigFile = "".kythe-extraction-config""
++const defaultConfigDir = ""kythe/go/extractors/config/default""
+
+ // Repo is a container of input/output parameters for doing extraction on remote
+ // repositories.",It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?,Please move this constant up with the other constants at the top of the file
+2866,"@@ -29,12 +29,15 @@ func Agent(config *config.Agent) error {
+ 	defer logs.FlushLogs()
+
+ 	startKubelet(config)
+-	startKubeProxy(config)
++
++	if !config.DisableKubeProxy {
++		return startKubeProxy(config)
++	}
+
+ 	return nil
+ }
+
+-func startKubeProxy(cfg *config.Agent) {
++func startKubeProxy(cfg *config.Agent) error {
+ 	argsMap := map[string]string{
+ 		""proxy-mode"":           ""iptables"",
+ 		""healthz-bind-address"": ""127.0.0.1"",",Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it.,Looks like `startKubelet` is only called in `startKubelet` and `startKubeProxy` is only called
+2867,"@@ -5,6 +5,8 @@ export default Ember.Controller.extend({
+   barcodeUri: function() {
+     let id = this.get('model.id');
+     let name = this.get('model.name');
++
++    /* eslint new-cap: ['error', { 'capIsNew': false }]  */
+     return Ember.$(document).JsBarcode(id, {
+       width: 1,
+       height: 20,",@btecu why is this override needed here? I'm not seeing a `new` being used here.,@jridgewell can you remove the `capIsNew` option here? I think it's not needed.
+2868,"@@ -2527,7 +2527,11 @@ func (s *Server) leafNodeFinishConnectProcess(c *client) {
+ 	c.mu.Unlock()
+
+ 	// Make sure we register with the account here.
+-	c.registerWithAccount(acc)
++	if err := c.registerWithAccount(acc); err != nil {
++		c.Errorf(""Registering leaf with account %s resulted in error: %v"", acc.Name, err)
++		c.closeConnection(ProtocolViolation)
++		return
++	}
+ 	s.addLeafNodeConnection(c, _EMPTY_, _EMPTY_, false)
+ 	s.initLeafNodeSmapAndSendSubs(c)
+ 	if sendSysConnectEvent {",Should it not be more something like: `MaxAccountConnectionsExceeded` here?,What's the difference between `registerWithAccount` and `registerWithAccountI`?
+2869,"@@ -180,6 +180,13 @@ func TestTrimComputeEndpoint(t *testing.T) {
+ 		parseAndValidate(t, ""-compute_endpoint_override"", ""  http://endpoint "").ComputeEndpoint)
+ }
+
++func TestTrimComputeServiceAccount(t *testing.T) {
++	assert.Equal(t, """",
++		parseAndValidate(t, ""-compute_service_account"", "" 	"").ComputeServiceAccount)
++	assert.Equal(t, ""default"",
++		parseAndValidate(t, ""-compute_service_account"", "" default	"").ComputeServiceAccount)
++}
++
+ func TestGcsLogsDisabled(t *testing.T) {
+ 	assert.False(t, parseAndValidate(t, ""-disable_gcs_logging=false"").GcsLogsDisabled)
+ 	assert.True(t, parseAndValidate(t, ""-disable_gcs_logging=true"").GcsLogsDisabled)",minor: use a non-default CE service account for testing (since default is handled in a specific way in the code),Is this a copy/paste error or did you mean to put it in?
+2870,"@@ -84,6 +84,10 @@ func TestBootstrapWindowedPoSt(t *testing.T) {
+ 	wd, _ := os.Getwd()
+ 	genCfgPath := filepath.Join(wd, "".."", ""fixtures/setup.json"")
+ 	presealPath := filepath.Join(wd, "".."", ""fixtures/genesis-sectors"")
++	// setup presealed sectors and uncomment to run test against sectors with larger sector size
++	//genCfgPath := filepath.Join(""./512"", ""setup.json"")
++	//presealPath := ""./512""
++
+ 	genTime := int64(1000000000)
+ 	blockTime := 1 * time.Second
+ 	fakeClock := clock.NewFake(time.Unix(genTime, 0))","This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop).",presealed sectors and uncomment to run test against sectors with larger size
+2871,"@@ -90,7 +90,9 @@ module Beaker
+       # @return nil
+       # @api public
+       def resolve_symlinks!
+-        @options[:hosts_file] = File.realpath(@options[:hosts_file]) if @options[:hosts_file]
++        if @options[:hosts_file] && !@options[:hosts_file_generated]
++          @options[:hosts_file] = File.realpath(@options[:hosts_file])
++        end
+       end
+
+       #Converts array of paths into array of fully qualified git repo URLS with expanded keywords","So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this ""option"" to detect that?",Style/UnneededCondition: This condition is not needed.
+2872,"@@ -20,16 +20,11 @@
+
+ package http
+
+-import (
+-	""fmt""
+-
+-	""go.uber.org/yarpc/api/yarpcerrors""
+-)
+-
+-// TODO: Should we expose the maps as public variables to document the mappings?
++import ""go.uber.org/yarpc/api/yarpcerrors""
+
+ var (
+-	_codeToHTTPStatusCode = map[yarpcerrors.Code]int{
++	// CodeToStatusCode maps all Codes to their corresponding HTTP status code.
++	CodeToStatusCode = map[yarpcerrors.Code]int{
+ 		yarpcerrors.CodeOK:                 200,
+ 		yarpcerrors.CodeCancelled:          499,
+ 		yarpcerrors.CodeUnknown:            500,","Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections.",nit: why not a `map[yarpcerrors.Code]int`?
+2873,"@@ -351,6 +351,15 @@ class WebKitCaret(browsertab.AbstractCaret):
+     def selection(self, callback):
+         callback(self._widget.selectedText())
+
++    def reverse_selection(self):
++        self._tab.run_js_async(""""""{
++            let sel = window.getSelection();
++            sel.setBaseAndExtent(
++                sel.extentNode, sel.extentOffset, sel.baseNode,
++                sel.baseOffset
++            );
++        }"""""")
++
+     def _follow_selected(self, *, tab=False):
+         if QWebSettings.globalSettings().testAttribute(
+                 QWebSettings.JavascriptEnabled):",This could probably use `const` as well?,Should this be `self._tab.run_js_async(sel
+2874,"@@ -40,7 +40,7 @@ import (
+ // file.  The Restore method replaces the contents of the original with the
+ // backup, overwriting any changes that were made since the backup was created.
+ type File struct {
+-	orig, tmp string // file paths
++	Orig, Tmp string // file paths
+ }
+
+ // New creates a backup copy of the specified file, located in the same",it doesn't look like these need to be exported?,Is this still needed?
+2875,"@@ -5,6 +5,7 @@ package fs
+ import (
+ 	""bytes""
+ 	""errors""
++	""fmt""
+ 	""io/ioutil""
+ 	""os""
+ 	""path/filepath""","I think you should remove ""fmt"" here. And change `fmt.Errorf` to `errors.Errorf`.",Can you add gitea copyright header to this
+2876,"@@ -0,0 +1,6 @@
++class AddVideoAttributesToProducts < ActiveRecord::Migration
++  def change
++    add_column :products, :length_in_days, :integer
++    add_column :products, :resources, :text, default: """", null: false
++  end
++end","Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else.",Line is too long. [92/90]
+2877,"@@ -11,7 +11,7 @@ import (
+ // one of the workers, it is returned. FinalFunc is always run, regardless of
+ // any other previous errors.
+ func RunWorkers(ctx context.Context, count int, workerFunc func() error, finalFunc func()) error {
+-	wg, ctx := errgroup.WithContext(ctx)
++	wg, _ := errgroup.WithContext(ctx)
+
+ 	// run workers
+ 	for i := 0; i < count; i++ {","If the context is unused, this is equivalent to `var wg errgroup.Group`.",This was a bug.
+2878,"@@ -47,6 +47,8 @@ public interface HighlightParams {
+
+   // sizing
+   public static final String FRAGSIZE    = HIGHLIGHT+"".fragsize""; // OH, FVH, UH
++  public static final String FRAGALIGNRATIO = HIGHLIGHT+"".fragAlignRatio""; // UH
++  public static final String FRAGSIZEISMINIMUM = HIGHLIGHT+"".fragsizeIsMinimum""; // UH
+   public static final String FRAGMENTER  = HIGHLIGHT+"".fragmenter""; // OH
+   public static final String INCREMENT   = HIGHLIGHT+"".increment""; // OH
+   public static final String REGEX       = ""regex""; // OH",very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize,Should be `UH` instead of
+2879,"@@ -98,6 +98,10 @@ def is_local_interface(host):
+   if ':' in host:
+     host = host.split(':',1)[0]
+
++  # If ""localhost"" or a loopback IP has been specified it is a deliberate reference
++  if host == 'localhost' or host.startswith('127.'):
++    return False
++
+   try:
+     sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
+     sock.connect( (host, 4242) )","Given that 115 returns `True`, why would this be `False` here?",I'm not sure that this is
+2880,"@@ -367,6 +367,17 @@ public class OAuth2LoginConfigurerTests {
+ 		assertThat(this.response.getRedirectedUrl()).matches(""http://localhost/oauth2/authorization/google"");
+ 	}
+
++	// gh-6802
++	@Test
++	public void oauth2LoginWithOneClientConfiguredAndFormLoginThenRedirectDefaultLoginPage() throws Exception {
++		loadConfig(OAuth2LoginConfigFormLogin.class);
++		String requestUri = ""/"";
++		this.request = new MockHttpServletRequest(""GET"", requestUri);
++		this.request.setServletPath(requestUri);
++		this.springSecurityFilterChain.doFilter(this.request, this.response, this.filterChain);
++		assertThat(this.response.getRedirectedUrl()).matches(""http://localhost/login"");
++	}
++
+ 	// gh-5347
+ 	@Test
+ 	public void oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage()",Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`,Why load config and then check if the response has the correct URL?
+2881,"@@ -270,6 +270,9 @@ bool LatencyTestPublisher::init(int n_sub, int n_sam, bool reliable, uint32_t pi
+     PubDataparam.topic.topicName = pt.str();
+     PubDataparam.times.heartbeatPeriod.seconds = 0;
+     PubDataparam.times.heartbeatPeriod.fraction = 4294967 * 100;
++    PubDataparam.qos.m_liveliness.lease_duration = c_TimeInfinite;
++    PubDataparam.qos.m_liveliness.announcement_period = Duration_t(1, 0);
++
+     if (!reliable)
+     {
+         PubDataparam.qos.m_reliability.kind = BEST_EFFORT_RELIABILITY_QOS;",Why this new configuration?,Is there a way to test this?
+2882,"@@ -245,8 +245,14 @@ public class IcebergPigInputFormat<T> extends InputFormat<Void, T> {
+
+     private Object convertPartitionValue(Type type, Object value) {
+       if (type.typeId() == Types.BinaryType.get().typeId()) {
+-        ByteBuffer buffer = (ByteBuffer) value;
+-        return new DataByteArray(buffer.get(new byte[buffer.remaining()]).array());
++        ByteBuffer dupe = ((ByteBuffer) value).duplicate();
++        if (dupe.hasArray()) {
++          return new DataByteArray(dupe.array());
++        } else {
++          byte[] bytes = new byte[dupe.remaining()];
++          dupe.get(bytes);
++          return new DataByteArray(bytes);
++        }
+       }
+
+       return value;","I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`.",nit: can be simplified to `return new DataByteArray(dupe.array());`
+2883,"@@ -28,15 +28,15 @@ namespace OpenTelemetry.Metrics
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""SpanContext""/>.</param>
++        /// <param name=""spanReference"">the associated <see cref=""SpanReference""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in SpanContext context, T value);
++        public abstract void Add(in SpanReference spanReference, T value);
+
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""Baggage""/>.</param>
++        /// <param name=""spanReference"">the associated <see cref=""Baggage""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in Baggage context, T value);
++        public abstract void Add(in Baggage spanReference, T value);
+     }
+ }",`spanReference` -> `baggage`  ,Should we add any assert here that spanReference is not null?
+2884,"@@ -32,9 +32,8 @@ module.exports = function(config, auth, storage) {
+     });
+   });
+
+-  router.get('/-/logo', function(req, res) {
+-    res.sendFile(_.get(config, 'web.logo') || `${env.APP_ROOT}/static/logo-sm.png`
+-    );
++  router.get('/-/verdaccio/logo', function(req, res) {
++    res.send(_.get(config, 'web.logo') || '/-/static/logo.png');
+   });
+
+   router.get('/', function(req, res) {",Why the `/-/verdaccio/` ?,Looks like `/-/static/logo.png` is not needed any more.
+2885,"@@ -478,8 +478,7 @@ func TestAppDeployOpts_pushAddonsTemplateToS3Bucket(t *testing.T) {
+
+ 			opts := appDeployOpts{
+ 				appDeployVars: appDeployVars{
+-					AppName:      tc.inputApp,
+-					enableAddons: true,
++					AppName: tc.inputApp,
+ 					GlobalOpts: &GlobalOpts{
+ 						projectName: tc.inputProject,
+ 					},",Has been waiting for a million years ,The `enableAddons` flag was not being used in `appDeplo
+2886,"@@ -31,6 +31,10 @@ msg.Number = {};
+ msg.Number.min = ""Path `{PATH}` ({VALUE}) is less than minimum allowed value ({MIN})."";
+ msg.Number.max = ""Path `{PATH}` ({VALUE}) is more than maximum allowed value ({MAX})."";
+
++msg.Date = {};
++msg.Date.min = ""Path `{PATH}` ({VALUE}) is before than minimum allowed value ({MIN})."";
++msg.Date.max = ""Path `{PATH}` ({VALUE}) is after than maximum allowed value ({MAX})."";
++
+ msg.String = {};
+ msg.String.enum = ""`{VALUE}` is not a valid enum value for path `{PATH}`."";
+ msg.String.match = ""Path `{PATH}` is invalid ({VALUE})."";",Minor grammar detail: the 'than' is unnecessary,"Is it worth adding a `msg.Date.max = ""Path `{PATH}` is "
+2887,"@@ -4873,10 +4873,11 @@ class Series(Frame, IndexOpsMixin, Generic[T]):
+         >>> kser.item()
+         10
+         """"""
+-        item_top_two = self[:2]
++        scol = self.spark_column
++        item_top_two = self._internal._sdf.select(scol).head(2)
+         if len(item_top_two) != 1:
+             raise ValueError(""can only convert an array of size 1 to a Python scalar"")
+-        return item_top_two[0]
++        return item_top_two[0][0]
+
+     def _cum(self, func, skipna, part_cols=()):
+         # This is used to cummin, cummax, cumsum, etc.",I think you can just simply fix this line to `self[:2].to_pandas()`,"This is a change in behavior, `self[:2]` returns the ar"
+2888,"@@ -1229,6 +1229,14 @@ class WebDriver {
+     if (target && cdpTargets.indexOf(target.toLowerCase()) === -1) {
+       throw new error.InvalidArgumentError('invalid target value')
+     }
++
++    if (debuggerAddress.match(/\/se\/cdp/)) {
++      if (debuggerAddress.match(""ws:\/\/"", ""http:\/\/"")) {
++        return debuggerAddress.replace(""ws:\/\/"", ""http:\/\/"")
++      }
++      return debuggerAddress
++    }
++
+     const path = '/json/version'
+     let request = new http.Request('GET', path)
+     let client = new http.HttpClient('http://' + debuggerAddress)",if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?,Is this only needed in case of `cdp` targets?
+2889,"@@ -20,6 +20,6 @@
+  * Internal dependencies
+  */
+ import Data from 'googlesitekit-data';
+-import { registerStore } from 'assets/js/googlesitekit/datastore/site';
++import { registerStore } from './googlesitekit/datastore/site';
+
+ registerStore( Data );",I could add a resolver for this (like above) but it seems more sensible to just change the one reference!,Please move the file to `build-system/`
+2890,"@@ -44,11 +44,14 @@ public class TimestampMoreRecentThanParent implements DetachedBlockHeaderValidat
+
+   private boolean validateHeaderSufficientlyAheadOfParent(
+       final long timestamp, final long parentTimestamp) {
+-    if ((timestamp - minimumSecondsSinceParent) < parentTimestamp) {
++    final long actualTimeSinceParent = timestamp - parentTimestamp;
++    if (actualTimeSinceParent < minimumSecondsSinceParent) {
+       LOG.trace(
+-          ""Invalid block header: timestamp {} is not sufficiently newer than parent timestamp {}"",
++          ""Invalid block header: timestamp {} is only {} seconds newer than parent timestamp {}. Minimum {} seconds"",
+           timestamp,
+-          parentTimestamp);
++          actualTimeSinceParent,
++          parentTimestamp,
++          minimumSecondsSinceParent);
+       return false;
+     }
+ ","not sure ""actual"" adds value - secondsSinceParent is probably closer.",This log message is very similar to the one a
+2891,"@@ -159,7 +159,7 @@ module Blacklight::SearchHelper
+   # Get the solr response when retrieving only a single facet field
+   # @return [Blacklight::SolrResponse] the solr response
+   def get_facet_field_response(facet_field, user_params = params || {}, extra_controller_params = {})
+-    query = search_builder.with(user_params).merge(extra_controller_params).merge(solr_facet_params(facet_field, user_params, extra_controller_params))
++    query = search_builder.with(user_params).facet(facet_field).merge(extra_controller_params)
+     repository.search(query)
+   end
+ ",Line is too long. [94/80],Do we need to merge `extra_controller_params`
+2892,"@@ -585,4 +585,7 @@ return [
+         'image_size' => 'Image size:',
+         'selected_size' => 'Selected:'
+     ],
++    'repeater' => [
++        'min_items_error' => 'You cannot delete any item. You should modify the existing.'
++    ]
+ ];",The error should be `At least :number items are required`,Missing a period at the end of the sentence.
+2893,"@@ -172,11 +172,9 @@ func (s *server) Ping(in *pb.Request, stream pb.Simulator_PingServer) error {
+ 	// message type of 1999 means that it's a dummy message to allow the engine to pass back proposed blocks
+ 	if in.InternalMsgType != dummyMsgType {
+ 		msg := CombineMsg(in.InternalMsgType, msgValue)
+-		switch msg.(type) {
+-		case *iproto.ProposePb:
+-			err = s.nodes[in.PlayerID].HandleBlockPropose(msg.(*iproto.ProposePb), done)
+-		case *iproto.EndorsePb:
+-			err = s.nodes[in.PlayerID].HandleEndorse(msg.(*iproto.EndorsePb), done)
++		switch cMsg := msg.(type) {
++		case *iproto.ConsensusPb:
++			err = s.nodes[in.PlayerID].HandleConsensusMsg(cMsg, done)
+ 		}
+ 		if err != nil {
+ 			logger.Error().Err(err).Msg(""failed to handle view change"")",singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`),switch msg.(type) { case *iproto.ConsensusPb
+2894,"@@ -506,11 +506,7 @@ type encryptionKeyGetter interface {
+ 		kbfscrypto.TLFCryptKey, error)
+ }
+
+-// KeyManager fetches and constructs the keys needed for KBFS file
+-// operations.
+-type KeyManager interface {
+-	encryptionKeyGetter
+-
++type mdDecryptionKeyGetter interface {
+ 	// GetTLFCryptKeyForMDDecryption gets the crypt key to use for the
+ 	// TLF with the given metadata to decrypt the private portion of
+ 	// the metadata.  It finds the appropriate key from mdWithKeys",Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better.,Can we rename `mdDecryptionKeyGetter` to `Ke
+2895,"@@ -6316,7 +6316,8 @@ Lng32 SQL_EXEC_DeleteHbaseJNI()
+       threadContext->incrNumOfCliCalls();
+
+       HBaseClient_JNI::deleteInstance();
+-      HiveClient_JNI::deleteInstance();
++      // The Hive client persists across connections
++      // HiveClient_JNI::deleteInstance();
+    }
+    catch(...)
+    {",Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?,Is there a reason to keep an instance of `Hi
+2896,"@@ -22,7 +22,7 @@ const illegalCommandFields = [
+   'raw',
+   'readPreference',
+   'session',
+-  'writeConcern'
++  'readConcern'
+ ];
+
+ class CreateCollectionOperation extends CommandOperation {",Does this mean we do not support writeConcern on `createCollection`?,"I don't think we should remove the writeConcern command here, unless I'm missing something. We already have the read and writeConcern in the create command, so I think we should be consistent."
+2897,"@@ -36,7 +36,7 @@ func TestProducer_RequestSessionDestroy(t *testing.T) {
+ 	assert.NoError(t, err)
+
+ 	destroySender := &fakeDestroySender{}
+-	err = RequestSessionDestroy(destroySender, sid)
++	err = RequestSessionDestroy(destroySender, sid.ID)
+ 	assert.NoError(t, err)
+ }
+ ","I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`.",Why is this change needed?
+2898,"@@ -379,7 +379,11 @@ func (s *Service) getSecurityGroupIngressRules(role infrav1.SecurityGroupRole) (
+ 				Protocol:    infrav1.SecurityGroupProtocolTCP,
+ 				FromPort:    6443,
+ 				ToPort:      6443,
+-				CidrBlocks:  []string{anyIPv4CidrBlock},
++				SourceSecurityGroupIDs: []string{
++					s.scope.SecurityGroups()[infrav1.SecurityGroupAPIServerLB].ID,
++					s.scope.SecurityGroups()[infrav1.SecurityGroupControlPlane].ID,
++					s.scope.SecurityGroups()[infrav1.SecurityGroupNode].ID,
++				},
+ 			},
+ 			{
+ 				Description:            ""etcd"",",We'll need `infrav1.SecurityGroupBastion` as well,`s.scope.SecurityGroups()` is a little hard to read - can this be done with `map[string]struct{}`?
+2899,"@@ -1470,6 +1470,15 @@ func Rcat(fdst fs.Fs, dstFileName string, in io.ReadCloser, modTime time.Time) (
+ 	return dst, nil
+ }
+
++// PublicLink adds a ""readable by anyone with link"" permission on the given file or folder.
++func PublicLink(f fs.Fs, fileName string) (string, error) {
++	doPublicLink := f.Features().PublicLink
++	if doPublicLink == nil {
++		return """", errors.Errorf(""%v doesn't support public links"", f)
++	}
++	return doPublicLink(fileName)
++}
++
+ // Rmdirs removes any empty directories (or directories only
+ // containing empty directories) under f, including f.
+ func Rmdirs(f fs.Fs, dir string, leaveRoot bool) error {",This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage.,Should this be an error instead of an error?
+2900,"@@ -243,12 +243,12 @@ public class SmartStoreLoadTest extends InstrumentationTestCase {
+         // Without indexing for new index specs
+         alterSoup(""Adding one index / no re-indexing"", false, new IndexSpec[]{new IndexSpec(""k_0"", indexType), new IndexSpec(""k_1"", indexType)});
+         alterSoup(""Adding one index / dropping one index / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_2"", indexType)});
+-        alterSoup(""Dropping two indexes / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_3"", indexType)});
++        alterSoup(""Dropping one index / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_0"", indexType)});
+
+         // With indexing for new index specs
+         alterSoup(""Adding one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_1"", indexType)});
+         alterSoup(""Adding one index / dropping one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_2"", indexType)});
+-        alterSoup(""Dropping two indexes / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_3"", indexType)});
++        alterSoup(""Dropping one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType)});
+     }
+
+     private void alterSoup(String msg, boolean reIndexData, IndexSpec[] indexSpecs) throws JSONException {",That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing,"We should only use the first index in the array and not the last index in the array. If the order of the indexes does not matter, we can drop them."
+2901,"@@ -52,6 +52,13 @@ public class AttachmentView extends FrameLayout {
+     public String contentType;
+     public long size;
+     public ImageView iconView;
++
++    /**
++     * Regular expression that represents characters that aren't allowed
++     * to be used in file names saved using K-9
++     */
++    private static final String specialCharacters = new String(""[^\\d\\s\\w!"" +
++    		""#\\$%&'\\(\\)\\-@\\^_`\\{\\}~.,]"");
+
+     private AttachmentFileDownloadCallback callback;
+ ",Expression that uses a negation pattern to exclude all characters that aren't in the expression.,Can we make this a `public static final` constant in `AttachmentFileDownloadCallback`?
+2902,"@@ -82,6 +82,10 @@ const (
+ 	// feature is supported on the server. If any non-empty value is set,
+ 	// this indicates true.
+ 	BothResponseErrorHeader = ""Rpc-Both-Response-Error""
++
++	// Echo ServiceHeader in Request header which can be used by clients/HC to
++	// validate request went to the correct service
++	RespondServiceHeader = ""Rpc-Respond-Service-Header""
+ )
+
+ // Valid values for the Rpc-Status header.","Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead.",RespondServiceHeader is a bit confusing. Can we name it as ServerRespondServiceHeader or ServerRespondHeader?
+2903,"@@ -135,7 +135,7 @@ func addCustomCommands(rootCmd *cobra.Command) error {
+ 				}
+
+ 				descSuffix := "" (shell "" + service + "" container command)""
+-				if serviceDirOnHost[0:1] == ""."" {
++				if commandSet == targetGlobalCommandPath {
+ 					descSuffix = "" (global shell "" + service + "" container command)""
+ 				}
+ 				commandToAdd := &cobra.Command{","The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!",@deads2k @jwforres @jackfrancis can you confirm this doesn't affect other cases?
+2904,"@@ -38,7 +38,7 @@ import (
+ 	controllerconfig ""antrea.io/antrea/pkg/config/controller""
+ )
+
+-const waitEgressRealizedTimeout = 3 * time.Second
++const waitEgressRealizedTimeout = 15 * time.Second
+
+ func TestEgress(t *testing.T) {
+ 	skipIfProviderIs(t, ""kind"", ""pkt_mark field is not properly supported for OVS userspace (netdev) datapath."")",Would membership take 10+ seconds to detect the failed node?,This looks unrelated to the rest of the PR. Would you mind removing it?
+2905,"@@ -227,11 +227,14 @@ def _sanitize_markdown(mdtext):
+
+ def _load_introduction(path):
+     ""Loads the introduction text from a Markdown file""
++    if not os.path.exists(path):
++        return None
++
+     try:
+         with open(path) as f:
+             return _sanitize_markdown(f.read())
+-    except:
+-        return None
++    except Exception as err:
++        raise RuntimeError(f'Makrdown file ""{path}"" could not be loaded: {err}')
+
+
+ def _load_skill(path, course):","hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?","Do we need this check, given that `_sanitize_markdown` may throw an err"
+2906,"@@ -0,0 +1,14 @@
++package cmd
++
++import (
++	""github.com/mitchellh/go-homedir""
++	""path/filepath""
++)
++
++func GetDirectory(paths ...string) string {
++	dir, _ := homedir.Dir()
++
++	dir = filepath.Join(dir, "".mysterium"", filepath.Join(paths...))
++
++	return dir
++}",This function does not need to be public,This will only work if the user is running in parallel - you need to ch
+2907,"@@ -60,14 +60,14 @@ export default function SetupForm( { finishSetup } ) {
+ 		>
+ 			<ErrorNotice />
+
++			<ExistingTagNotice />
++
+ 			{ ( !! accounts.length && ! hasExistingTag ) && (
+-				<p>
++				<p style={ { marginBottom: 0 } }>
+ 					{ __( 'Please select the account information below. You can change this view later in your settings.', 'google-site-kit' ) }
+ 				</p>
+ 			) }
+
+-			<ExistingTagNotice />
+-
+ 			<div className=""googlesitekit-setup-module__inputs"">
+ 				<AccountSelect />
+ ",  Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set.,Can we move this above the existing tag?
+2908,"@@ -119,7 +119,7 @@ namespace AutoRest.Ruby.Azure.TemplateModels
+                 if (ReturnType.Body is CompositeType)
+                 {
+                     CompositeType compositeType = (CompositeType)ReturnType.Body;
+-                    if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension))
++                    if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension) && this.Extensions.ContainsKey(""nextMethodName""))
+                     {
+                         bool isNextLinkMethod = this.Extensions.ContainsKey(""nextLinkMethod"") && (bool)this.Extensions[""nextLinkMethod""];
+                         bool isPageable = (bool)compositeType.Extensions[AzureExtensions.PageableExtension];","> && this.Extensions.ContainsKey(""nextMethodName"") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(""nextMethodName"")` condition or we don't need line 124 #Closed","is this for a different PR, or just a style thing?"
+2909,"@@ -1,16 +1,5 @@
+-import { options } from 'preact';
+ import { assign } from './util';
+
+-let oldVNodeHook = options.vnode;
+-options.vnode = vnode => {
+-	if (vnode.type && vnode.type._forwarded && vnode.ref) {
+-		vnode.props.ref = vnode.ref;
+-		vnode.ref = null;
+-	}
+-
+-	if (oldVNodeHook) oldVNodeHook(vnode);
+-};
+-
+ /**
+  * Pass ref down to a child. This is mainly used in libraries with HOCs that
+  * wrap components. Using `forwardRef` there is an easy way to get a reference",Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it.,@dvoytenko is this not needed anymore?
+2910,"@@ -52,11 +52,11 @@ namespace NLog.LayoutRenderers
+         private readonly string _baseDir;
+
+ #if !SILVERLIGHT && !NETSTANDARD1_3
+-
+         /// <summary>
+         /// cached
+         /// </summary>
+         private string _processDir;
++#endif
+
+         /// <summary>
+         /// Use base dir of current process.","Please use "".NET Core 3"" - i'm trying hard to use one form, and this is the one MS advices",How is this related?
+2911,"@@ -87,6 +87,11 @@ func StartSession(params *TelemetrySessionParams, statsEngine stats.Engine) erro
+ 			seelog.Errorf(""Error: lost websocket connection with ECS Telemetry service (TCS): %v"", tcsError)
+ 			params.time().Sleep(backoff.Duration())
+ 		}
++		select {
++		case <-params.Ctx.Done():
++			return nil
++		default:
++		}
+ 	}
+ }
+ ","Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited.",I'm not sure if this is the right error to return.
+2912,"@@ -29,6 +29,7 @@ import qutebrowser
+ from qutebrowser.utils import docutils
+ from qutebrowser.browser import pdfjs
+
++from end2end.features.test_scroll_bdd import check_scrolled, check_not_scrolled
+
+ bdd.scenarios('misc.feature')
+ ","Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time.",check_scrolled and check_not_scrolled are unused imports
+2913,"@@ -356,7 +356,7 @@ TEST(svm_thunder_dense_test, can_classify_any_two_labels) {
+
+         auto support_indices_table = result_train.get_support_indices();
+         const auto support_indices = row_accessor<const float>(support_indices_table).pull();
+-        for (size_t i = 0; i < support_indices.get_count(); i++) {
++        for (std::int64_t i = 0; i < support_indices.get_count(); i++) {
+             ASSERT_EQ(support_indices[i], i);
+         }
+ ",Does this changes affect process building dynamic libraries anyhow?,Please use `auto` instead of `std::int64_t`
+2914,"@@ -26,7 +26,7 @@ import struct
+ import time
+ from scapy.packet import *
+ from scapy.fields import *
+-from scapy.contrib.ppi import PPIGenericFldHdr, addPPIType
++from scapy.layers.dot11 import *
+ from scapy.error import warning
+ import scapy.modules.six as six
+ from scapy.modules.six.moves import range",Could you limit what is imported here?,Is there a specific reason for importing everything from
+2915,"@@ -1078,12 +1078,15 @@ def do_set_function_code(lambda_function: LambdaFunction):
+     if not lambda_cwd:
+         return
+
+-    # get local lambda working directory
++    # get local lambda code archive path
+     tmp_file = os.path.join(lambda_cwd, LAMBDA_ZIP_FILE_NAME)
+
+     if not zip_file_content:
+         zip_file_content = load_file(tmp_file, mode=""rb"")
+
++    # override lambda archive with fresh code if we got an update
++    save_file(tmp_file, zip_file_content)
++
+     # Set the appropriate lambda handler.
+     lambda_handler = generic_handler
+     is_java = lambda_executors.is_java_lambda(runtime)","just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up","`zip_file_content` is the local file content, not the lo"
+2916,"@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
+ func icmpPkt(src, dst string) packet {
+ 	return packetWithPorts(1, src+"":0"", dst+"":0"")
+ }
++func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
++	return packet{
++		protocol: 1,
++		srcAddr:  src,
++		srcPort:  0,
++		dstAddr:  dst,
++		dstPort:  (icmpCode << 8) | (icmpType),
++	}
++}
+
+ var polProgramTests = []polProgramTest{
+ 	// Tests of actions and flow control.
+-
+ 	{
+ 		PolicyName: ""no tiers"",
+ 		DroppedPackets: []packet{",Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain,It would be better to use the constant for this icmp code.
+2917,"@@ -127,11 +127,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+         {
+             using (var response = await client.SendAsync(request).ConfigureAwait(false))
+             {
+-                if (response.StatusCode != HttpStatusCode.OK &&
+-                    response.StatusCode != HttpStatusCode.Accepted)
+-                {
+-                    var statusCode = (int)response.StatusCode;
+-                }
++                // disposing response
+             }
+         }
+ ",We can do away with assigning the response here too.,"@scalablecory, @SzymonPobiega wasn't there a problem befor"
+2918,"@@ -18,7 +18,7 @@ function ngGridFlexibleHeightPlugin (opts) {
+                 }
+             }
+
+-            var newViewportHeight = naturalHeight + 2;
++            var newViewportHeight = naturalHeight + 3;
+             if (!self.scope.baseViewportHeight || self.scope.baseViewportHeight !== newViewportHeight) {
+                 self.grid.$viewport.css('height', newViewportHeight + 'px');
+                 self.grid.$root.css('height', (newViewportHeight + extraHeight) + 'px');",Bumping the newViewportHeight,what's the reason for this change?
+2919,"@@ -47,7 +47,7 @@ import org.apache.solr.util.LongIterator;
+  *   <li><a href=""https://github.com/aggregateknowledge/postgresql-hll"">postgresql-hll</a>, and</li>
+  *   <li><a href=""https://github.com/aggregateknowledge/js-hll"">js-hll</a></li>
+  * </ul>
+- * when <a href=""https://github.com/aggregateknowledge/postgresql-hll/blob/master/STORAGE.markdown"">properly serialized</a>.
++ * when <a href=""https://github.com/aggregateknowledge/postgresql-hll/blob/secondaryy/STORAGE.markdown"">properly serialized</a>.
+  */
+ public class HLL implements Cloneable {
+     // minimum and maximum values for the log-base-2 of the number of registers",Is this change correct? Looks like a typo and not sure this should be changed?,Could we add a dot after `MIX`?
+2920,"@@ -43,6 +43,14 @@ def _read_stdin():
+     return sys.stdin.read()
+
+
++def _load_reporter_by_class(reporter_class: str) -> type:
++    qname = reporter_class
++    module_part = astroid.modutils.get_module_part(qname)
++    module = astroid.modutils.load_module_from_name(module_part)
++    class_name = qname.split(""."")[-1]
++    return getattr(module, class_name)
++
++
+ # Python Linter class #########################################################
+
+ MSGS = {",I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?,"I'm not sure if it's a good idea to make this a public function. If you don't, how about making it a private function on `astroid.modutils`?"
+2921,"@@ -35,4 +35,4 @@ namespace System.MathBenchmarks
+             }
+         }
+     }
+-}
++}","nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)",Please don't add unnecessary whitespace changes.
+2922,"@@ -57,9 +57,16 @@ namespace AutoRest.Swagger.Model.Utilities
+                                                     .Where(modelName => !(IsBaseResourceModelName(modelName))
+                                                                         && serviceDefinition.Definitions.ContainsKey(modelName)
+                                                                         && IsAllOfOnModelNames(modelName, serviceDefinition.Definitions, xmsAzureResourceModels));
++
++            var unfilteredResourceCandidates = resourceModels.Union(modelsAllOfOnXmsAzureResources);
++
++            // Now filter all the resource models that are returned from a POST operation only
++            var postOpResourceModels = serviceDefinition.Paths.Values.SelectMany(pathObj => pathObj.Where(opObj => opObj.Key.EqualsIgnoreCase(""post""))
++                                                                     .SelectMany(opObj => opObj.Value.Responses?.Select(resp => resp.Value?.Schema?.Reference?.StripDefinitionPath())))
++                                                                     .Where(model => !string.IsNullOrWhiteSpace(model));
+
+-            // return the union
+-            return resourceModels.Union(modelsAllOfOnXmsAzureResources);
++            // if any model is returned only by a POST operation, disregard it
++            return unfilteredResourceCandidates.Except(postOpResourceModels);
+
+         }
+ ","I don't see the ""only"" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same ""level"". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj<HERE>.Where` and lines won't be that long.",I wonder if we could filter out the `resourceModels` that were returned from a GET operation instead of filtering them all here.
+2923,"@@ -20,7 +20,8 @@ Puppet::DataTypes.create_type('Target') do
+       vars => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
+       facts => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
+       features => { type => Optional[Array[String[1]]], kind => given_or_derived },
+-      plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived }
++      plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
++      resources => { type => Optional[Hash[String[1], ResourceInstance]], kind => given_or_derived }
+     },
+     functions => {
+       host => Callable[[], Optional[String]],","It seems like most of these will never be nil, are they optional just in case?",`given_or_derived` is missing in `resources`
+2924,"@@ -88,7 +88,7 @@ public class TableCodecTest {
+       try {
+         byte[] bytes = TableCodec.encodeRow(tblInfo.getColumns(), values, tblInfo.isPkHandle());
+         // testing the correctness via decodeRow
+-        Row row = TableCodec.decodeRow(bytes, tblInfo.getColumns());
++        Row row = TableCodec.decodeRow(bytes, -1, tblInfo);
+         for (int j = 0; j < tblInfo.getColumns().size(); j++) {
+           assertEquals(row.get(j, null), values[j]);
+         }","`.addColumn(""c1"", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31",Why use -1 here?
+2925,"@@ -56,8 +56,10 @@ public class RowKey extends Key implements Serializable {
+     Object obj = handle.getValue();
+     if (obj instanceof Long) {
+       return new RowKey(tableId, (long) obj);
++    } else if (obj instanceof Integer) {
++      return new RowKey(tableId, ((Integer) obj).longValue());
+     }
+-    throw new TiExpressionException(""Cannot encode row key with non-long type"");
++    throw new TiExpressionException(""Cannot encode row key with non-long or non-integer type"");
+   }
+
+   public static RowKey createMin(long tableId) {",how about `Cannot encode row key with non-integer type` directly?,@markap14 any sp
+2926,"@@ -42,6 +42,9 @@ public interface ExecutorLoader {
+   Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
+       throws ExecutorManagerException;
+
++  Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
++      throws ExecutorManagerException;
++
+   Pair<ExecutionReference, ExecutableFlow> fetchActiveFlowByExecId(int execId)
+       throws ExecutorManagerException;
+ ",The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?,why not just cal
+2927,"@@ -26,6 +26,17 @@ module Travis
+                 sh.cmd ""wget -q -O tmate.tar.xz #{static_build_linux_url}"", echo: false, retry: true
+                 sh.cmd ""tar --strip-components=1 -xf tmate.tar.xz"", echo: false
+               end
++              sh.elif ""$(uname) = 'FreeBSD'"" do
++                sh.cmd 'sudo pkg install -y libevent msgpack libssh', echo: true
++                sh.cmd 'git clone https://github.com/tmate-io/tmate.git', echo: true
++                sh.cd 'tmate', echo: false, stack: true
++                sh.cmd 'git checkout 2.4.0', echo: true
++                sh.cmd './autogen.sh', echo: true
++                sh.cmd './configure', echo: true
++                sh.cmd 'make', echo: true
++                sh.cmd 'sudo make install', echo: true
++                sh.cd :back, echo: false, stack: true
++              end
+               sh.else do
+                 sh.echo ""We are setting up the debug environment. This may take a while...""
+                 sh.cmd ""brew update &> /dev/null"", echo: false, retry: true",Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`.,What about `sh.c
+2928,"@@ -0,0 +1,5 @@
++// Package importpath is used to implement a test on Go import paths.
++package importpath
++
++// Answer is the answer to Life, the Universe and Everything.
++const Answer = 42",ultra nit: missing Oxford comma :P,This file doesn't have to be here.
+2929,"@@ -729,6 +729,16 @@ class SparkFrameMethods(object):
+         == Physical Plan ==
+         ...
+
++        >>> df.spark.explain(""extended"")  # doctest: +SKIP
++        == Parsed Logical Plan ==
++        ...
++        == Analyzed Logical Plan ==
++        ...
++        == Optimized Logical Plan ==
++        ...
++        == Physical Plan ==
++        ...
++
+         >>> df.spark.explain(mode=""extended"")  # doctest: +ELLIPSIS
+         == Parsed Logical Plan ==
+         ...",This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now.,Why do we need to skip this?
+2930,"@@ -13,5 +13,6 @@ import (
+ // like sending and awaiting mined ones.
+ type Message interface {
+ 	Send(ctx context.Context, from, to types.Address, val *types.AttoFIL, method string, params ...interface{}) (*cid.Cid, error)
++	Query(ctx context.Context, from, to types.Address, method string, params ...interface{}) ([][]byte, *exec.FunctionSignature, error)
+ 	Wait(ctx context.Context, msgCid *cid.Cid, cb func(blk *types.Block, msg *types.SignedMessage, receipt *types.MessageReceipt, signature *exec.FunctionSignature) error) error
+ }",BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?,why do we need this interface?
+2931,"@@ -562,14 +562,14 @@ func (c *ConfigLocal) MaxDirBytes() uint64 {
+ 	return c.maxDirBytes
+ }
+
+-// ResetCaches implements the Config interface for ConfigLocal.
+-func (c *ConfigLocal) ResetCaches() {
++func (c *ConfigLocal) resetCachesWithoutShutdown() DirtyBlockCache {
+ 	c.lock.Lock()
+ 	defer c.lock.Unlock()
+ 	c.mdcache = NewMDCacheStandard(5000)
+ 	c.kcache = NewKeyCacheStandard(5000)
+ 	// Limit the block cache to 10K entries or 1024 blocks (currently 512MiB)
+ 	c.bcache = NewBlockCacheStandard(c, 10000, MaxBlockSizeBytesDefault*1024)
++	oldDirtyBcache := c.dirtyBcache
+ 	minFactor := 1
+ 	if maxParallelBlockPuts > 10 {
+ 		minFactor = maxParallelBlockPuts / 10",please move this down to immediately above the assignment to `c.dirtyBcache`,why do we need to make this change
+2932,"@@ -63,3 +63,19 @@ func Example() {
+ 	// Output:
+ 	// foo.com running on port 80
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	// This example watches a variable based on a file-based blob.Bucket with JSON.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""blob://myvar.json?bucket=file:///mypath&decoder=json"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}","Don't need the `, err` part since you've already handled it.",Is there any way we can test this to see if it's working correctly?
+2933,"@@ -222,4 +222,18 @@ TEST_CASE(""negative charge queries. Part of testing changes for github #2604"",
+     CHECK(nWarnings == 1);
+     CHECK(nErrors == 0);
+   }
++}
++
++TEST_CASE(""GithHub #2954: Reaction Smarts with Dative Bonds not parsed"",
++          ""[Reaction, Bug]"") {
++
++  SECTION(""Rxn Smart Processing with Dative Bond"") {
++    unique_ptr<ChemicalReaction> rxn(
++      RxnSmartsToChemicalReaction(""[O:1].[H+]>>[O:1]->[H+]"")
++    );
++    REQUIRE(rxn);
++    auto k = rxn->getProducts()[0]->getNumAtoms();
++    CHECK(k == 2);
++  }
++
+ }",Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`),Wouldn't it be better to check the result of `getProducts()`?
+2934,"@@ -54,6 +54,15 @@ func (c *Cluster) newListener(ctx context.Context) (net.Listener, http.Handler,
+ 			MinVersion:   c.config.TLSMinVersion,
+ 			CipherSuites: c.config.TLSCipherSuites,
+ 		},
++		RegenerateCerts: func() bool {
++			const regenerateDynamicListenerFile = ""dynamic-cert-regenerate""
++			dynamicListenerRegenFilePath := filepath.Join(c.config.DataDir, ""tls"", regenerateDynamicListenerFile)
++			if _, err := os.Stat(dynamicListenerRegenFilePath); err == nil {
++				os.Remove(dynamicListenerRegenFilePath)
++				return true
++			}
++			return false
++		},
+ 	})
+ }
+ ",What happens if the certificate rotation fails and we are prematurely removing this file?,Can we put this in `pkg/config`?
+2935,"@@ -97,6 +97,18 @@ func (s *Single) IsRunning() bool {
+
+ // Introspect returns a ChooserStatus with a single PeerStatus.
+ func (s *Single) Introspect() introspection.ChooserStatus {
++	if !s.once.IsRunning() {
++		return introspection.ChooserStatus{
++			Name: ""Single"",
++			Peers: []introspection.PeerStatus{
++				{
++					Identifier: s.pid.Identifier(),
++					State: ""uninitialized"",
++				},
++			},
++		}
++	}
++
+ 	peerStatus := s.p.Status()
+ 	peer := introspection.PeerStatus{
+ 		Identifier: s.p.Identifier(),",does this change belong here?,Why do we need to initialize `PeerStatus` if it is already initiali
+2936,"@@ -291,6 +291,8 @@ func (w *Workflow) populate() error {
+ 		""DATETIME"":  now.Format(""20060102150405""),
+ 		""TIMESTAMP"": strconv.FormatInt(now.Unix(), 10),
+ 		""USERNAME"":  w.username,
++		""WFDIR"":     w.workflowDir,
++		""CWD"":       os.Getwd(),
+ 	}
+
+ 	var replacements []string",This returns an error,Does this work on windows? I think it might need to use `path.Join()`
+2937,"@@ -131,6 +131,8 @@ type Config struct {
+ 	Ipv6Support    bool `config:""bool;true""`
+ 	IgnoreLooseRPF bool `config:""bool;false""`
+
++	// FIXME Add this to libcalico-go
++	IptablesBackend                    string        `config:""oneof(legacy,nft);legacy;local""`
+ 	RouteRefreshInterval               time.Duration `config:""seconds;90""`
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;1""`","If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?",Should we open an issue about this?
+2938,"@@ -53,7 +53,10 @@ func TestBlockPropsManyNodes(t *testing.T) {
+ 	connect(t, nodes[1], nodes[2])
+ 	connect(t, nodes[2], nodes[3])
+
+-	baseTS := minerNode.ChainReader.Head()
++	head := minerNode.ChainReader.GetHead()
++	headTipSetAndState, err := minerNode.ChainReader.GetTipSetAndState(ctx, head)
++	require.NoError(err)
++	baseTS := headTipSetAndState.TipSet
+ 	require.NotNil(t, baseTS)
+ 	proof := testhelpers.MakeRandomPoSTProofForTest()
+ ",Looks like that helper function is general enough that it should reside in testhelpers,Could you please create a helper function for this? GetTipSetAndState
+2939,"@@ -456,6 +456,11 @@ func writeDrupal6DdevSettingsFile(settings *DrupalSettings, filePath string) err
+ // WriteDrushrc writes out drushrc.php based on passed-in values.
+ // This works on Drupal 6 and Drupal 7 or with drush8 and older
+ func WriteDrushrc(app *DdevApp, filePath string) error {
++	// Ignore because this is a settings file.
++	if app.DisableSettingsManagement {
++		return nil
++	}
++
+ 	if fileutil.FileExists(filePath) {
+ 		// Check if the file is managed by ddev.
+ 		signatureFound, err := fileutil.FgrepStringInFile(filePath, DdevFileSignature)","This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually.",Can we log an error here so that we know what file was created?
+2940,"@@ -10,8 +10,10 @@ test_name 'use the provision subcommand' do
+     delete_root_folder_contents
+     on(default, 'beaker init')
+     result = on(default, 'beaker provision --hosts centos6-64')
++    assert_match(/ERROR/, result.raw_output)
++    on(default, 'beaker init --hosts centos6-64')
++    result = on(default, 'beaker provision')
+     assert_match(/Using available host/, result.stdout)
+-
+     subcommand_state = on(default, ""cat #{SubcommandUtil::SUBCOMMAND_STATE}"").stdout
+     subcommand_state = YAML.parse(subcommand_state).to_ruby
+     assert_equal(true, subcommand_state['provisioned'])",I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work.,I think we should check for the error message here as well
+2941,"@@ -470,8 +470,8 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
+ 		publicSubnets, err := o.selVPC.PublicSubnets(envInitPublicSubnetsSelectPrompt, """", o.importVPC.ID)
+ 		if err != nil {
+ 			if err == selector.ErrSubnetsNotFound {
+-				log.Warningf(`No existing public subnets were found in VPC %s.
+-If you proceed without public subnets, you will not be able to deploy Load Balanced Web Services in this environment.
++				log.Warningf(`No existing subnets were found in VPC %s.
++If you proceed without specifying public subnets, you will not be able to deploy Load Balanced Web Services in this environment.
+ `, o.importVPC.ID)
+ 			} else {
+ 				return fmt.Errorf(""select public subnets: %w"", err)","Should we say ""specifying two public subnets""?","I think ""no existing public subnets were found in VPC"" wou"
+2942,"@@ -32,6 +32,8 @@ func (current *PubSubSource) CheckImmutableFields(ctx context.Context, og apis.I
+ 		return nil
+ 	}
+
++	// TODO: revisit this.
++
+ 	// All of the fields are immutable because the controller doesn't understand when it would need
+ 	// to delete and create a new Receive Adapter with updated arguments. We could relax it slightly
+ 	// to allow a nil Sink -> non-nil Sink, but I don't think it is needed yet.",Issue number? When? Why?,Is this a `TODO` for this PR?
+2943,"@@ -35,6 +35,7 @@ from ._sapi4 import (
+ 	VOICECHARSET
+ )
+ import config
++import speech
+ import nvwave
+ import weakref
+ ",You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`.,This import is no longer needed.
+2944,"@@ -108,7 +108,7 @@ public abstract class BaseTestIceberg {
+     newCatalog.setConf(hadoopConfig);
+     newCatalog.initialize(""nessie"", ImmutableMap.of(""ref"", ref,
+         CatalogProperties.URI, uri,
+-        ""auth_type"", ""NONE"",
++        ""auth-type"", ""NONE"",
+         CatalogProperties.WAREHOUSE_LOCATION, temp.toUri().toString()
+     ));
+     return newCatalog;","Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself  ",was this a bug?
+2945,"@@ -146,12 +146,12 @@ func (db *taskQueueDB) CreateTasks(tasks []*persistencespb.AllocatedTaskInfo) (*
+ // GetTasks returns a batch of tasks between the given range
+ func (db *taskQueueDB) GetTasks(minTaskID int64, maxTaskID int64, batchSize int) (*persistence.GetTasksResponse, error) {
+ 	return db.store.GetTasks(&persistence.GetTasksRequest{
+-		NamespaceID:  db.namespaceID.String(),
+-		TaskQueue:    db.taskQueueName,
+-		TaskType:     db.taskType,
+-		BatchSize:    batchSize,
+-		ReadLevel:    minTaskID,  // exclusive
+-		MaxReadLevel: &maxTaskID, // inclusive
++		NamespaceID: db.namespaceID.String(),
++		TaskQueue:   db.taskQueueName,
++		TaskType:    db.taskType,
++		PageSize:    batchSize,
++		MinTaskID:   minTaskID, // exclusive
++		MaxTaskID:   maxTaskID, // inclusive
+ 	})
+ }
+ ","maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive,",Not sure why we
+2946,"@@ -70,7 +70,7 @@ const (
+
+ 	NvidiaVisibleDevicesEnvVar = ""NVIDIA_VISIBLE_DEVICES""
+ 	GPUAssociationType         = ""gpu""
+-	NvidiaRuntime              = ""nvidia""
++	NvidiaRuntime              = ""ecs-nvidia""
+
+ 	arnResourceSections  = 2
+ 	arnResourceDelimiter = ""/""",You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian.,Maybe we want t
+2947,"@@ -177,10 +177,10 @@ func newLeafNodeCfg(remote *RemoteLeafOpts) *leafNodeCfg {
+ 	if len(remote.DenyExports) > 0 || len(remote.DenyImports) > 0 {
+ 		perms := &Permissions{}
+ 		if len(remote.DenyExports) > 0 {
+-			perms.Subscribe = &SubjectPermission{Deny: remote.DenyExports}
++			perms.Publish = &SubjectPermission{Deny: remote.DenyExports}
+ 		}
+ 		if len(remote.DenyImports) > 0 {
+-			perms.Publish = &SubjectPermission{Deny: remote.DenyImports}
++			perms.Subscribe = &SubjectPermission{Deny: remote.DenyImports}
+ 		}
+ 		cfg.perms = perms
+ 	}","Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of ""foo"" it means that it would reject a subscription (hence subscribe permission) on ""foo"" from the other side. Now you are changing to simply not allowing this server to publish on ""foo"". I am not saying this is wrong, but we completely flip the meaning.",could this caus
+2948,"@@ -159,6 +159,12 @@ dsts_first(void)
+     return TESTANY(DR_DISASM_INTEL | DR_DISASM_ARM, DYNAMO_OPTION(disasm_mask));
+ }
+
++static inline bool
++opmask_with_dsts(void)
++{
++    return TESTANY(DR_DISASM_INTEL | DR_DISASM_ATT, DYNAMO_OPTION(disasm_mask));
++}
++
+ static void
+ internal_instr_disassemble(char *buf, size_t bufsz, size_t *sofar INOUT,
+                            dcontext_t *dcontext, instr_t *instr);","> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing","I think it would be better to remove the ""opmask_with_dsts"" macro and replace it with a call to ""opmask_with_dsts(disasm_mask)"""
+2949,"@@ -192,7 +192,7 @@ func (kc *KMDController) StartKMD(args KMDStartArgs) (alreadyRunning bool, err e
+ 			return false, errors.New(""bad kmd data dir"")
+ 		}
+ 		if (dataDirStat.Mode() & 0077) != 0 {
+-			logging.Base().Errorf(""%s: kmd data dir exists but is too permissive (%o)"", kc.kmdDataDir, dataDirStat.Mode()&0777)
++			logging.Base().Errorf(""%s: kmd data dir exists but is too permissive (%o), change to (%o)"", kc.kmdDataDir, dataDirStat.Mode()&0777, dataDirStat.Mode()&0077)
+ 			return false, errors.New(""kmd data dir not secure"")
+ 		}
+ 	} else {","I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`",Can we change `dataDirStat.Mode()` to return an int?
+2950,"@@ -386,8 +386,8 @@ func (s *stream) SetDeadline(t time.Time) error {
+ }
+
+ // CloseRemote makes the stream receive a ""virtual"" FIN stream frame at a given offset
+-func (s *stream) CloseRemote(offset protocol.ByteCount) {
+-	s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: offset})
++func (s *stream) CloseRemote(offset uint64) {
++	s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: protocol.ByteCount(offset)})
+ }
+
+ // Cancel is called by session to indicate that an error occurred","The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC",It would be nice if we didn't have to duplicate the `FinBit` and `Offset` values everywhere.
+2951,"@@ -260,6 +260,17 @@ bool IsDetrimentalSpell(uint16 spell_id)
+ 	return !IsBeneficialSpell(spell_id);
+ }
+
++bool IsInvisSpell(uint16 spell_id)
++{
++	if (IsEffectInSpell(spell_id, SE_Invisibility) ||
++		IsEffectInSpell(spell_id, SE_Invisibility2) ||
++		IsEffectInSpell(spell_id, SE_InvisVsUndead) ||
++		IsEffectInSpell(spell_id, SE_InvisVsUndead2) ||
++		IsEffectInSpell(spell_id, SE_InvisVsAnimals))
++		return true;
++	return false;
++}
++
+ bool IsInvulnerabilitySpell(uint16 spell_id)
+ {
+ 	return IsEffectInSpell(spell_id, SE_DivineAura);",I dig the helper function!,"I'm not sure if this is the correct spell, but if it's not the correct spell, should it be `IsEffectInSpell(spell_id, SE_Invisi"
+2952,"@@ -0,0 +1,2 @@
++// package samples contains sample programs using the pubsub API.
++package samples",Please add the Copyright header.,Why not put them in `/samples/`?
+2953,"@@ -37,6 +37,7 @@ import sys
+ import tempfile
+
+ import luigi
++from ..target import FileSystemTarget
+
+ logger = logging.getLogger('luigi-interface')
+ ",Is this the best way to import `FileSystemTarget`?,I think you can remove this line
+2954,"@@ -2751,10 +2751,10 @@ static void
+ replace_thread_id(thread_id_t old, thread_id_t new)
+ {
+ #ifdef HAVE_TLS
+-    thread_id_t new_tid = new;
++    int32_t new_tid = (int32_t) new; /* can't use thread_id_t since it's 64-bits on x64 */
+     ASSERT(is_thread_tls_initialized());
+     DOCHECK(1, {
+-        thread_id_t old_tid;
++        int32_t old_tid; /* can't use thread_id_t since it's 64-bits on x64 */
+         READ_TLS_INT_SLOT_IMM(TLS_THREAD_ID_OFFSET, old_tid);
+         ASSERT(old_tid == old);
+     });","Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg.",Isn't `thread_id_t` already a `u
+2955,"@@ -13311,7 +13311,11 @@ public:
+         HRESULT Status;
+
+         ICorDebugProcess* pCorDebugProcess;
+-        IfFailRet(g_pRuntime->GetCorDebugInterface(&pCorDebugProcess));
++        if (FAILED(Status = g_pRuntime->GetCorDebugInterface(&pCorDebugProcess)))
++        {
++            ExtOut(""\n\n\n!clrstack -i is unsupported on this target.\nThe ICorDebug interface cannot be constructed.\n"");
++            return Status;
++        }
+
+         ExtOut(""\n\n\nDumping managed stack and managed variables using ICorDebug.\n"");
+         ExtOut(""=============================================================================\n"");",Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?,> ICorDebugInterface [](start =
+2956,"@@ -52,7 +52,13 @@ def _dagster_home():
+             'DAGSTER_HOME is not set, check is_dagster_home_set before invoking.'
+         )
+
+-    return os.path.expanduser(dagster_home_path)
++    dagster_home_path = os.path.expanduser(dagster_home_path)
++
++    if not os.path.isabs(dagster_home_path):
++        raise DagsterInvariantViolationError(
++            'DAGSTER_HOME must be absolute path'
++        )
++    return dagster_home_path
+
+
+ def _check_run_equality(pipeline_run, candidate_run):",print out what we got here in the error,Question: Is there ever a situation where the home path would be non-absolute?
+2957,"@@ -43,6 +43,9 @@ See the file COPYING for details.
+ 	)); \
+ } while (false)
+
++//Stores select query before evaluation
++struct jx *select_expr = NULL;
++
+ static struct jx *jx_check_errors(struct jx *j);
+
+ static struct jx *jx_eval_null(struct jx_operator *op, struct jx *left, struct jx *right) {",Does this need to be global?,Why store it here? I think it should be available in `select_expr` only?
+2958,"@@ -1349,7 +1349,7 @@ public final class TreeMap<K, V> implements SortedMap<K, V>, Serializable {
+
+     @Override
+     public Seq<V> values() {
+-        return iterator().map(Tuple2::_2).toStream();
++        return map(Tuple2::_2);
+     }
+
+     // -- Object","Yep, could be simplified. Now looks like other *Map.values() impls",`return stream().map(Tuple2::_2).collect(Collectors.toList());`
+2959,"@@ -183,6 +183,15 @@ class ApiContext extends \Imbo\BehatApiExtension\Context\ApiContext
+         $this->assertJsonObjectContainsKeys('configuration,columns,collection,info');
+     }
+
++    /**
++     * @Then /^print last api response$/
++     */
++    public function printLastApiResponse(): void
++    {
++        $this->requireResponse();
++        echo $this->response->getBody();
++    }
++
+     /**
+      * {@inheritDoc}
+      */",This method will be for debug?,"`$this->response->getBody()` doesn't really work, isn't it?"
+2960,"@@ -9,9 +9,16 @@ import (
+ 	""errors""
+ )
+
++// ErrInvalidPassword is returned when the password for decrypting content where
++// private key is stored is not valid.
+ var ErrInvalidPassword = errors.New(""invalid password"")
+
++// Service for managing keystore private keys.
+ type Service interface {
++	// Key returns private key for specified name that was encrypted with
++	// provided password. If the private key does not exists it creates new one
++	// with name and password, and returns with created set to true.
+ 	Key(name, password string) (k *ecdsa.PrivateKey, created bool, err error)
++	// Exists returns true if the key with specified name exists.
+ 	Exists(name string) (bool, error)
+ }","// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true.",Should we move this to `internal/key_test.go`?
+2961,"@@ -45,6 +45,19 @@ class DiagramEntity(Figure):
+         self.node = node
+
+
++class PackageEntity(DiagramEntity):
++    """"""A diagram object representing a package""""""
++
++
++class ClassEntity(DiagramEntity):
++    """"""A diagram object representing a class""""""
++
++    def __init__(self, title, node):
++        super().__init__(title=title, node=node)
++        self.attrs = None
++        self.methods = None
++
++
+ class ClassDiagram(Figure, FilterMixIn):
+     """"""main class diagram handling""""""
+ ","Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``.",@pmeier I am not sure what to do with `ClassDi
+2962,"@@ -43,7 +43,8 @@ class _MissingPandasLikeDataFrame(object):
+     blocks = unsupported_property('blocks', deprecated=True)
+
+     # Functions
+-    add = unsupported_function('add')
++    add_prefix = unsupported_function('add_prefix')
++    add_suffix = unsupported_function('add_suffix')
+     agg = unsupported_function('agg')
+     aggregate = unsupported_function('aggregate')
+     align = unsupported_function('align')",These two functions should be available now.,add_prefix and add_suffix are not implemented
+2963,"@@ -651,10 +651,17 @@ type localOpenFile struct {
+ 	o    *Object           // object that is open
+ 	in   io.ReadCloser     // handle we are wrapping
+ 	hash *hash.MultiHasher // currently accumulating hashes
++	fd   *os.File          // file object reference
+ }
+
+ // Read bytes from the object - see io.Reader
+ func (file *localOpenFile) Read(p []byte) (n int, err error) {
++	// Check if file has the same size and modTime
++	fi, err := file.fd.Stat()
++	if file.o.size != fi.Size() || file.o.modTime != fi.ModTime() {
++		return 0, errors.New(""can't copy - source file is being updated"")
++	}
++
+ 	n, err = file.in.Read(p)
+ 	if n > 0 {
+ 		// Hash routines never return an error",`fi` is what the result of Stat is called elsewhere in this file not `finfo`,Why is this a `os.File` and not a `os.FileStre
+2964,"@@ -62,15 +62,6 @@ RSpec.describe Blacklight::OpenStructWithHashAccess do
+     end
+   end
+
+-  describe ""#replace"" do
+-    subject { described_class.new a: 1 }
+-
+-    it ""can use #replace to reorder the hash"" do
+-      subject.replace b: 1
+-      expect(subject.b).to eq 1
+-    end
+-  end
+-
+   describe ""#sort_by"" do
+     subject { described_class.new c: 3, b: 1, a: 2 }
+ ",I'm confused; are we just dropping these methods without deprecation?,We should probably have a test with the new `#replace` spec
+2965,"@@ -16,12 +16,18 @@ void AddEdgesProcessor::process(const cpp2::AddEdgesRequest& req) {
+     auto spaceId = req.get_space_id();
+     auto version =
+         std::numeric_limits<int64_t>::max() - time::WallClock::fastNowInMicroSec();
++    // Switch version to big-endian, make sure the key is in ordered.
++    version = folly::Endian::big(version);
++
+     callingNum_ = req.parts.size();
+     CHECK_NOTNULL(kvstore_);
+     std::for_each(req.parts.begin(), req.parts.end(), [&](auto& partEdges){
+         auto partId = partEdges.first;
+         std::vector<kvstore::KV> data;
+         std::for_each(partEdges.second.begin(), partEdges.second.end(), [&](auto& edge){
++            VLOG(4) << ""PartitionID: "" << partId << "", VertexID: "" << edge.key.src
++                    << "", EdgeType: "" << edge.key.edge_type << "", EdgeRanking: "" << edge.key.ranking
++                    << "", VertexID: "" << edge.key.dst << "", EdgeVersion: "" << version;
+             auto key = NebulaKeyUtils::edgeKey(partId, edge.key.src, edge.key.edge_type,
+                                                edge.key.ranking, edge.key.dst, version);
+             data.emplace_back(std::move(key), std::move(edge.get_props()));",can we use PC's time to version in Distributed Systems?,Shouldn't this be folly::Endian::big(1UL); ?
+2966,"@@ -100,9 +100,11 @@
+         <% cart.comments.each do |c| %>
+           <div class='comment-item'>
+             <div class='row'>
+-              <p class='comment-sender col-sm-6 col-xs-12'>
+-                <strong>requester@test.com</strong>
+-              </p>
++              <% unless c.user.nil? %>
++                <p class='comment-sender col-sm-6 col-xs-12'>
++                  <strong><%= c.user_full_name %></strong>
++                </p>
++              <% end %>
+               <p class='comment-date col-sm-6 col-xs-12'>
+                 <%= date_with_tooltip(c.created_at) %>
+               </p>","is this ""unless"" actually needed?","You don't need the `unless c.user` here, just do `c.user_fu"
+2967,"@@ -94,6 +94,10 @@ final class Stemmer {
+     }
+
+     List<CharsRef> list = new ArrayList<>();
++    if (length == 0) {
++      return list;
++    }
++
+     RootProcessor processor =
+         (stem, formID, stemException) -> {
+           list.add(newStem(stem, stemException));","We don't accept empty words for lookup anymore, again",nit: I think you can just `return List.of();`
+2968,"@@ -0,0 +1,18 @@
++#!/usr/bin/env node
++
++const fs = require('fs')
++const yarnOut = fs.readFileSync(0, {encoding: 'utf8'})
++
++const [installTimeString] = /(?<=^Done in )\d+\.\d+(?=s\.$)/m.exec(yarnOut)
++const installTime = Number(installTimeString)
++
++console.log(`Install time: ${installTime}s`)
++
++if (installTime < 30) {
++  console.log(""We're below 30 secs. That's awesome!"")
++} else if (installTime < 50) {
++  console.log(""We're below 50 secs. That's fine!"")
++} else {
++  console.log(""We're above 50 secs. That's not great!"")
++  process.exit(1)
++}",We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?,shouldn't we throw an error here too?
+2969,"@@ -101,6 +101,7 @@ class Command(object):
+     EXECUTE_ASYNC_SCRIPT = ""executeAsyncScript""
+     SET_SCRIPT_TIMEOUT = ""setScriptTimeout""
+     SET_TIMEOUTS = ""setTimeouts""
++    W3C_MINIMIZE_WINDOW = ""w3cMinimizeWindow""
+     MAXIMIZE_WINDOW = ""windowMaximize""
+     W3C_MAXIMIZE_WINDOW = ""w3cMaximizeWindow""
+     GET_LOG = ""getLog""",No need for this to be `W3C_` since there is no JWP equivalent,Do we need to define it here? Is it s
+2970,"@@ -1,5 +1,12 @@
+ module RSpec
+   module Core
++    if defined?(::Random)
++      RandomNumberGenerator = ::Random
++    else
++      require 'rspec/core/backport_random'
++      RandomNumberGenerator = RSpec::Core::Backports::Random
++    end
++
+     # @private
+     module Ordering
+       # @private","As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :).",Why are we doing this here instead of
+2971,"@@ -480,3 +480,13 @@ func (s *Server) NumSubscriptions() uint32 {
+ 	stats := s.sl.Stats()
+ 	return stats.NumSubs
+ }
++
++// Addr will return the net.Addr object for the current listener.
++func (s *Server) Addr() net.Addr {
++	s.mu.Lock()
++	defer s.mu.Unlock()
++	if s.listener == nil {
++		return nil
++	}
++	return s.listener.Addr()
++}",Is this ever actually used?,Is there a reason this needs to be do
+2972,"@@ -158,7 +158,7 @@ func (w *Waiter) receiptFromTipSet(ctx context.Context, msgCid cid.Cid, ts conse
+ 	if err != nil {
+ 		return nil, err
+ 	}
+-	res, err := consensus.ProcessTipSet(ctx, ts, st, vm.NewStorageMap(w.bs))
++	res, err := consensus.NewDefaultProcessor().ProcessTipSet(ctx, st, vm.NewStorageMap(w.bs), ts)
+ 	if err != nil {
+ 		return nil, err
+ 	}","this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky","@harmony-ek @CecileRobertMichon do you have any thoughts on adding a default processor here, rather than making it part of the interface?"
+2973,"@@ -1749,6 +1749,10 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
+                 arch_mcontext_reset_stolen_reg(dcontext, mc);
+             }
+         });
++        IF_AARCHXX({
++            set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
++            IF_ARM(ASSERT_NOT_TESTED());
++        });
+         /* We send all threads, regardless of whether was in DR or not, to
+          * re-interp from translated cxt, to avoid having to handle stale
+          * local state problems if we simply resumed.",Do we need to save the existing value of the stolen reg somehow?,Shouldn't this also use `os_get_dr_tls_base_ex`?
+2974,"@@ -94,7 +94,8 @@ class AdminDirectoryClient(_base_client.BaseClient):
+             api_errors.ApiExecutionError
+         """"""
+         members_stub = self.service.members()
+-        request = members_stub.list(groupKey=group_key)
++        request = members_stub.list(groupKey=group_key,
++                                    maxResults=500)
+         results_by_member = []
+
+         # TODO: Investigate yielding results to handle large group lists.",maxResults should come from FLAGS once #244 is submitted.,"I think we might want to bump this up slightly, maybe 500 or 1000?"
+2975,"@@ -12,6 +12,8 @@ using Datadog.Trace.TestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+
++#if NETCOREAPP
++
+ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+ {
+     [CollectionDefinition(nameof(HttpMessageHandlerTests), DisableParallelization = true)]",is this wanted?,Why is this needed?
+2976,"@@ -268,6 +268,14 @@ def get_docker_executable():
+     return distutils.spawn.find_executable('docker')
+
+
++def get_linode_executable():
++    try:
++        pytest.importorskip('linode')
++        return True
++    except Exception:
++        return False
++
++
+ def get_lxc_executable():
+     return distutils.spawn.find_executable('lxc-start')
+ ",What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this.,"Just curious, why do you need to do this?"
+2977,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?,Do we also want to set `Content-Encoding`
+2978,"@@ -21,6 +21,7 @@ program
+   .option('--target_arch <target_arch>', 'target architecture')
+   .option('--target_apk_base <target_apk_base>', 'target Android OS apk (classic, modern, mono)')
+   .option('--submodule_sync', 'run submodule sync')
++  .option('--ignore_chromium', 'do not update chromium')
+   .option('--init', 'initialize all dependencies')
+   .option('--all', 'This flag is deprecated and no longer has any effect')
+   .option('--force', 'force reset all projects to origin/ref')","I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?","If this defaults to `--ignore_chromium`, "
+2979,"@@ -57,13 +57,15 @@ var (
+ 		ta.Keyinfo[""alfa""].PriKey, 3, big.NewInt(10), []byte{}, testutil.TestGasLimit,
+ 		big.NewInt(testutil.TestGasPriceInt64))
+
+-	testTransferPb = testTransfer.Proto()
++	testTransferHash = testTransfer.Hash()
++	testTransferPb   = testTransfer.Proto()
+
+ 	testExecution, _ = testutil.SignedExecution(ta.Addrinfo[""bravo""].String(),
+ 		ta.Keyinfo[""bravo""].PriKey, 1, big.NewInt(0), testutil.TestGasLimit,
+ 		big.NewInt(testutil.TestGasPriceInt64), []byte{})
+
+-	testExecutionPb = testExecution.Proto()
++	testExecutionHash = testExecution.Hash()
++	testExecutionPb   = testExecution.Proto()
+
+ 	testTransfer1, _ = testutil.SignedTransfer(ta.Addrinfo[""charlie""].String(), ta.Keyinfo[""producer""].PriKey, 1,
+ 		big.NewInt(10), []byte{}, testutil.TestGasLimit, big.NewInt(testutil.TestGasPriceInt64))",`testExecutionPb` is a global variable (from `gochecknoglobals`),These two lines should be in the outer `i
+2980,"@@ -127,17 +127,6 @@ class ImageProvider extends FileProvider
+         return array_merge($params, $options);
+     }
+
+-    /**
+-     * {@inheritdoc}
+-     */
+-    public function getReferenceImage(MediaInterface $media)
+-    {
+-        return sprintf('%s/%s',
+-            $this->generatePath($media),
+-            $media->getProviderReference()
+-        );
+-    }
+-
+     /**
+      * {@inheritdoc}
+      */","~Method is public and removing it would be a BC Break, you can deprecate it if you want.~",why did you remove this?
+2981,"@@ -113,7 +113,7 @@ func (i *interpreter) interpretStatements(s *scope, statements []*Statement) (re
+ 			} else {
+ 				err = fmt.Errorf(""%s"", r)
+ 			}
+-			log.Debug(""%s"", debug.Stack())
++			log.Debug(""%v:\n %s"", err,  debug.Stack())
+ 		}
+ 	}()
+ 	return s.interpretStatements(statements), nil // Would have panicked if there was an error",this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace.,Is this change intention
+2982,"@@ -157,6 +157,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --include-prefix       Prefix this path to any generated include statements.\n""
+     ""    PATH\n""
+     ""  --keep-prefix          Keep original prefix of schema include statement.\n""
++    ""  --keep-namespaces      Keep full namespace paths of imported types in Rust.\n""
+     ""  --no-fb-import         Don't include flatbuffers import statement for TypeScript.\n""
+     ""  --no-ts-reexport       Don't re-export imported dependencies for TypeScript.\n""
+     ""  --short-names          Use short function names for JS and TypeScript.\n""",Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them.,The Rust compiler should
+2983,"@@ -88,6 +88,9 @@ type URLOpener struct{}
+ //  - file://localhost/c:/foo/bar
+ //    -> Also passes ""c:\foo\bar"".
+ func (*URLOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.Bucket, error) {
++	for param := range u.Query() {
++		return nil, fmt.Errorf(""open bucket %q: invalid query parameter %q"", u, param)
++	}
+ 	return OpenBucket(mungeURLPath(u.Path, os.PathSeparator), nil)
+ }
+ ",Should unsupported query parameters just be ignored? I think that's more common than error out.,This will silently fail
+2984,"@@ -52,9 +52,9 @@ def namespace(namespace=None):
+     Call to set namespace of tasks declared after the call.
+
+     If called without arguments or with ``None`` as the namespace, the namespace
+-    is reset, which is recommended to do at the end of any file where the
+-    namespace is set to avoid unintentionally setting namespace on tasks outside
+-    of the scope of the current file.
++    is reset to :py:attr:`Register._UNSET_NAMESPACE`., which is recommended to do
++    at the end of any file where the namespace is set to avoid unintentionally
++    setting namespace on tasks outside of the scope of the current file.
+
+     The namespace of a Task can also be changed by specifying the property
+     ``task_namespace``. This solution has the advantage that the namespace","Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of ""being unset"". Perhaps the docs become more natural if we remove the ""If called without arguments or with ..."" part and just say ""you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah"". Something like that. Just a suggestion.",This is not correct. It points to `Task.namespace` which is not the same as `Register._UNSET_NAMESPACE`. It is pointing to `Task.namespace` which is not the same as `Register._UNSET_NAMESPACE`. It is pointing to `Register._UNSET_NAMESPACE` in the docstring.
+2985,"@@ -426,8 +426,16 @@ class WinWordCollectionQuicknavIterator(object):
+ 			if self.direction==""previous"":
+ 				index=itemCount-(index-1)
+ 			collectionItem=items[index]
+-			item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
+-			itemRange=item.rangeObj
++			try:
++				item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
++				itemRange=item.rangeObj
++			except:
++				values = (self.itemType, self.direction, itemCount, index)
++				message = (""Error iterating over item with ""+
++				(""type: %s, iteration direction: %s, total item count: %s, item at index: %s"" % values )+
++				""\nThis could be caused by an issue with some element within or a corruption of the word document."")
++				log.debugWarning(message ,exc_info=True)
++				continue
+ 			# Skip over the item we're already on.
+ 			if not self.includeCurrent and isFirst and ((self.direction==""next"" and itemRange.start<=self.rangeObj.start) or (self.direction==""previous"" and itemRange.end>self.rangeObj.end)):
+ 				continue","I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors.",missing a space after the comma
+2986,"@@ -328,6 +328,7 @@ var directives = []string{
+ 	""git"",    // github.com/abiosoft/caddy-git
+
+ 	// directives that add middleware to the stack
++	""minify"", // github.com/hacdias/caddy-minify
+ 	""log"",
+ 	""gzip"",
+ 	""errors"",","Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed.",Nit: looks like this newline is intentional?
+2987,"@@ -31,7 +31,8 @@ type Tracer struct {
+ 	// Version is the instrumentation version.
+ 	Version string
+
+-	config *config
++	config   *config
++	provider *TracerProvider
+ }
+
+ // Start creates a span. If t is configured with a SpanRecorder its OnStart",nit: we could remove the `config` field as it is a duplicate of the `provider.config` field.,I don't see where this is used?
+2988,"@@ -112,7 +112,8 @@ class ForsetiServerInstaller(ForsetiInstaller):
+             # Create firewall rule to open only port tcp:50051
+             # within the internal network (ip-ranges - 10.128.0.0/9)
+             gcloud.create_firewall_rule(
+-                self.format_firewall_rule_name('forseti-server-allow-grpc'),
++                self.format_firewall_rule_name(
++                    'forseti-server-allow-grpc-internal'),
+                 [self.gcp_service_account],
+                 constants.FirewallRuleAction.ALLOW,
+                 ['tcp:50051'],",Nit: from the Internet.,this should have been `forseti-server-allow-grpc-internal`
+2989,"@@ -7,11 +7,15 @@
+ package hdwallet
+
+ import (
++	""bytes""
+ 	""fmt""
+ 	""io/ioutil""
+
++	ecrypt ""github.com/ethereum/go-ethereum/crypto""
++	""github.com/iotexproject/go-pkgs/crypto""
++	""github.com/iotexproject/iotex-address/address""
++	hdwallet ""github.com/miguelmota/go-ethereum-hdwallet""
+ 	""github.com/spf13/cobra""
+-
+ 	""github.com/tyler-smith/go-bip39""
+
+ 	""github.com/iotexproject/iotex-core/ioctl/config""","this is internal package, move to bottom and run 'make fmt'",Did you mean to delete this line?
+2990,"@@ -0,0 +1,14 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System.Threading;
++
++namespace Microsoft.AspNetCore.Connections.Features
++{
++    public interface IConnectionLifetimeNotificationFeature
++    {
++        CancellationToken ConnectionClosing { get; set; }
++
++        void Close();
++    }
++}",Why is this better than ApplicationStopping?,Why does this interface need to be an interface? Can't thi
+2991,"@@ -70,8 +70,8 @@ type ChallengeSpec struct {
+ 	// +optional
+ 	Wildcard bool `json:""wildcard""`
+
+-	// Type is the type of ACME challenge this resource represents, e.g. ""dns01""
+-	// or ""http01"".
++	// Type is the type of ACME challenge this resource represents.
++	// One of ""http-01"" or ""dns-01"".
+ 	Type ACMEChallengeType `json:""type""`
+
+ 	// Token is the ACME challenge token for this challenge.",Maybe worth expanding that these 2 are supported by cert-manager but other values exist,Is this the only kind of change in this PR?
+2992,"@@ -169,7 +169,7 @@ class MediaExtension extends \Twig_Extension
+
+         $options = array_merge($defaultOptions, $options);
+
+-        $options['src'] = $provider->generatePublicUrl($media, $format);
++        $options = $provider->getHelperProperties($media, $format, $options);
+
+         return $this->render($provider->getTemplate('helper_thumbnail'), array(
+             'media'    => $media,","Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065","This is the same as above, isn't it? `$options['src'] = $provider->generatePublicUrl($media, $format);`"
+2993,"@@ -125,6 +125,10 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+         params.add(""--rpc-http-authentication-credentials-file"");
+         params.add(node.jsonRpcConfiguration().getAuthenticationCredentialsFile());
+       }
++      if (node.jsonRpcConfiguration().getAuthenticationPublicKeyFile() != null) {
++        params.add(""--rpc-http-authentication-public-key-file"");
++        params.add(node.jsonRpcConfiguration().getAuthenticationPublicKeyFile().getAbsolutePath());
++      }
+     }
+
+     if (node.wsRpcEnabled()) {","What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?",Maybe we can move this to `JsonRpcConfiguration`?
+2994,"@@ -57,6 +57,12 @@ type CertificateSpec struct {
+ 	// Organization is the organization to be used on the Certificate
+ 	Organization []string `json:""organization,omitempty""`
+
++	// Certificate default Duration
++	Duration metav1.Duration `json:""duration,omitempty""`
++
++	// Certificate renew before expiration duration
++	RenewBefore metav1.Duration `json:""renewBefore,omitempty""`
++
+ 	// DNSNames is a list of subject alt names to be used on the Certificate
+ 	DNSNames []string `json:""dnsNames,omitempty""`
+ ","The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0.",Is this used anywhere?
+2995,"@@ -120,7 +120,7 @@ public interface GenericToken<T extends GenericToken<T>> {
+                     + "") must come before "" + to + "" (at "" + to.getStartInDocument() + "")""
+             );
+         }
+-        return IteratorUtil.generate(from, t -> t == to ? null : t.getNext());
++        return IteratorUtil.generate(from, t -> t.equals(to) ? null : t.getNext());
+     }
+
+ ","I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?",`t -> t.getNext()` can be replaced with `t::getNext`.
+2996,"@@ -22,11 +22,12 @@ type ns struct {
+ 	ipt iptables.Interface // interface to iptables
+ 	ips ipset.Interface    // interface to ipset
+
+-	name      string                     // k8s Namespace name
+-	nodeName  string                     // my node name
+-	namespace *coreapi.Namespace         // k8s Namespace object
+-	pods      map[types.UID]*coreapi.Pod // k8s Pod objects by UID
+-	policies  map[types.UID]interface{}  // k8s NetworkPolicy objects by UID
++	name            string                     // k8s Namespace name
++	nodeName        string                     // my node name
++	namespaceUID    types.UID                  // k8s Namespace UID
++	namespaceLabels map[string]string          // k8s Namespace labels
++	pods            map[types.UID]*coreapi.Pod // k8s Pod objects by UID
++	policies        map[types.UID]interface{}  // k8s NetworkPolicy objects by UID
+
+ 	uid     types.UID     // surrogate UID to own allPods selector
+ 	allPods *selectorSpec // hash:ip ipset of all pod IPs in this namespace","It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil.",why not just use `types.UID` here?
+2997,"@@ -17,6 +17,7 @@ const (
+ 	GithubV1ProviderName   = ""GitHubV1""
+ 	CodeCommitProviderName = ""CodeCommit""
+ 	BitbucketProviderName  = ""Bitbucket""
++	DefaultImage           = ""aws/codebuild/amazonlinux2-x86_64-standard:3.0""
+
+ 	pipelineManifestPath = ""cicd/pipeline.yml""
+ )",Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private,Please update to `AmazonLinux2-x86
+2998,"@@ -251,7 +251,7 @@ def reporter():
+ @pytest.fixture
+ def init_linter(linter: PyLinter) -> PyLinter:
+     linter.open()
+-    linter.set_current_module(""toto"")
++    linter.set_current_module(""toto"", ""mydir/toto"")
+     linter.file_state = FileState(""toto"")
+     return linter
+ ","I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR.",I don't think we need to have `myd
+2999,"@@ -154,7 +154,9 @@ public class ExportService {
+             if (releasedVersion == null) {
+                 throw new ExportException(""No released version for dataset "" + dataset.getGlobalId().toString());
+             }
+-            final JsonObjectBuilder datasetAsJsonBuilder = JsonPrinter.jsonAsDatasetDto(releasedVersion);
++            // We pass settingsService into the JsonPrinter constructor to check the :ExcludeEmailFromExport setting.
++            JsonPrinter jsonPrinter = new JsonPrinter(settingsService);
++            final JsonObjectBuilder datasetAsJsonBuilder = jsonPrinter.jsonAsDatasetDto(releasedVersion);
+             JsonObject datasetAsJson = datasetAsJsonBuilder.build();
+
+             Iterator<Exporter> exporters = loader.iterator();",Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.),Would it make sense to have a `sta
+3000,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those,
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?,should be `{@link Keys#SHIFT}`
+3001,"@@ -75,6 +75,14 @@ type diskBlockCacheSetter interface {
+ 	MakeDiskBlockCacheIfNotExists() error
+ }
+
++type diskBlockCacheFractionSetter interface {
++	SetDiskBlockCacheFraction(float64)
++}
++
++type syncBlockCacheFractionSetter interface {
++	SetSyncBlockCacheFraction(float64)
++}
++
+ type clockGetter interface {
+ 	Clock() Clock
+ }",This should go in `ConfigLocal` (and then re-generate the mocks).,why is this an interface neede
+3002,"@@ -51,10 +51,10 @@ class releaseTestCase(SparkTestCase):
+             if entry['release_name'] != '':
+                 expected[entry['user_name']].append({
+                     'release_name': entry['release_name'],
+-                    'release_msid': entry['release_msid'],
+-                    'release_mbid': entry['release_mbid'],
++                    'release_msid': entry['release_msid'] or None,
++                    'release_mbid': entry['release_mbid'] or None,
+                     'artist_name': entry['artist_name'],
+-                    'artist_msid': entry['artist_msid'],
++                    'artist_msid': entry['artist_msid'] or None,
+                     'artist_mbids': entry['artist_mbids'],
+                     'listen_count': entry['count']
+                 })",Nitty but entry.get for the same thing,`entry['release_mbid']` is Non
+3003,"@@ -10,11 +10,12 @@ import (
+ 	""github.com/opencontainers/runc/libcontainer/logs""
+ 	_ ""github.com/opencontainers/runc/libcontainer/nsenter""
+ 	""github.com/sirupsen/logrus""
+-	""github.com/urfave/cli""
+ )
+
+ func init() {
+ 	if len(os.Args) > 1 && os.Args[1] == ""init"" {
++		// This is the golang entry point for runc init, executed
++		// before main() but after libcontainer/nsenter's nsexec().
+ 		runtime.GOMAXPROCS(1)
+ 		runtime.LockOSThread()
+ ",Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs.,Is there a better way to do th
+3004,"@@ -100,6 +100,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+                         ""ThreadCount must be positive."");
+                 }
+
++                if (!Constants.ECONNRESET.HasValue)
++                {
++                    _logger.LogWarning(""Unable to determine ECONNRESET value on this platform."");
++                }
++
+                 if (!Constants.EADDRINUSE.HasValue)
+                 {
+                     _logger.LogWarning(""Unable to determine EADDRINUSE value on this platform."");",nit: add new line after this block,Could you also include the value of `Constants.ECONNRESET` in the warning?
+3005,"@@ -1111,10 +1111,10 @@ Blockly.Css.CONTENT = [
+   '}',
+
+   '.scratchCategoryMenu {',
+-    'width: 60px;',
++    'width: 3.25rem;',
+     'background: $colour_toolbox;',
+     'color: $colour_toolboxText;',
+-    'font-size: .7em;',
++    'font-size: .7rem;',
+     'user-select: none;',
+     '-webkit-user-select: none;',
+     '-moz-user-select: none;',","I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?",Can we move this to a constant?
+3006,"@@ -20,10 +20,11 @@ import urllib2
+
+ import jinja2
+
+-from retrying import retry
+ import sendgrid
+ from sendgrid.helpers import mail
+
++from retrying import retry
++
+ from google.cloud.security.common.util import errors as util_errors
+ from google.cloud.security.common.util import log_util
+ from google.cloud.security.common.util import retryable_exceptions",retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?,Let me know if this is a good style change.
+3007,"@@ -133,12 +133,12 @@ public interface List<T> extends Seq<T>, Stack<T> {
+             @SuppressWarnings(""unchecked"")
+             final List<T> list = (List<T>) elements;
+             return list;
+-        } else if (elements instanceof ArrayList) {
++        } else if (elements instanceof ArrayList || elements instanceof Vector) {
+             @SuppressWarnings(""unchecked"")
+-            final ArrayList<T> arrayList = (ArrayList<T>) elements;
++            final java.util.List<T> indexedList = (java.util.List<T>) elements;
+             List<T> result = Nil.instance();
+-            for (int i = arrayList.size() - 1; i >= 0; i--) {
+-                final T element = arrayList.get(i);
++            for (int i = indexedList.size() - 1; i >= 0; i--) {
++                final T element = indexedList.get(i);
+                 result = result.prepend(element);
+             }
+             return result;",you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector.,Could this be a `List<T>` instead of a `Vector`?
+3008,"@@ -355,10 +355,17 @@ public class EditImageActivity extends EditBaseActivity implements View.OnClickL
+
+     private void addToUndoList() {
+         try{
++            TODO:// implement a more efficient way, like storing only the difference of bitmaps or
++            // steps followed to edit
++
+             bitmapsForUndo.add(mainBitmap.copy(mainBitmap.getConfig(),true));
+         }catch (OutOfMemoryError error){
+-            //Snackbar.make(getWindow().getDecorView().getRootView(),""Out of Memory. steps = "" + bitmapsForUndo.size(),Snackbar.LENGTH_LONG).show();
+-
++            /**
++             * When outOfMemory exception throws then to make space, remove the last edited step
++             * from list and added the new operation in the end.
++             */
++            bitmapsForUndo.remove(0);
++            bitmapsForUndo.add(mainBitmap.copy(mainBitmap.getConfig(),true));
+         }
+     }
+ ","remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list.",`then` -> `when`
+3009,"@@ -1,4 +1,4 @@
+-//  Copyright 2019 Google Inc. All Rights Reserved.
++//  Copyright 2020 Google Inc. All Rights Reserved.
+ //
+ //  Licensed under the Apache License, Version 2.0 (the ""License"");
+ //  you may not use this file except in compliance with the License.",this is a existing file so let's keep 2019,please dont upda
+3010,"@@ -42,7 +42,7 @@ public class RemoteNetworkConnection implements NetworkConnection {
+   @Override
+   public ConnectionType setNetworkConnection(
+       ConnectionType type) {
+-    Map<String, ConnectionType> mode = ImmutableMap.of(""type"", type);
++    Map<String, Integer> mode = ImmutableMap.of(""type"", type.getBitMask());
+     return new ConnectionType(((Number) executeMethod.execute(DriverCommand.SET_NETWORK_CONNECTION,
+                                                             ImmutableMap
+                                                                 .of(""parameters"", mode)))",can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice),nit: maybe use `
+3011,"@@ -257,7 +257,7 @@ namespace Nethermind.AuRa.Test.Transactions
+                 TransactionPermissionContractVersions =
+                     new LruCache<Keccak, UInt256>(PermissionBasedTxFilter.Cache.MaxCacheSize, nameof(TransactionPermissionContract));
+
+-                var trieStore = new ReadOnlyTrieStore(new TrieStore(DbProvider.StateDb, LimboLogs.Instance));
++                var trieStore = new TrieStore(DbProvider.StateDb, LimboLogs.Instance).AsReadOnly(DbProvider.StateDb);
+                 IReadOnlyTxProcessorSource txProcessorSource = new ReadOnlyTxProcessingEnv(
+                     DbProvider,
+                     trieStore,",AsReadOnly() would be better here,This makes the `
+3012,"@@ -427,9 +427,12 @@ class Collection {
+      * @param {function(collection, changes)} callback - A function to be called when changes occur.
+      *   The callback function is called with two arguments:
+      *   - `collection`: the collection instance that changed,
+-     *   - `changes`: a dictionary with keys `insertions`, `modifications` and `deletions`,
+-     *      each containing a list of indices that were inserted, updated or deleted respectively. If
+-     *      partial sync is enabled, an additional key `partial_sync` is added.
++     *   - `changes`: a dictionary with keys `insertions`, `newModifications`, `oldModifications`
++     *      and `deletions`, each containing a list of indices in the collection that were
++     *      inserted, updated or deleted respectively. `deletions` and `oldModifications` are
++     *      indices into the collection before the change happened, while `insertions` and
++     *      `newModifications` are indices into the new version of the collection. If partial sync
++     *      is enabled, an additional key `partial_sync` is added.
+      *   - `changes.partial_sync`: `error` indicates if an error has occurred, `old_state` is the previous
+      *      state, and `new_state` is the current state.
+      * @throws {Error} If `callback` is not a function.",I suggest that we use `query_based_sync` instead of `partial_sync`.,"should this be ""are indices into the collection""?"
+3013,"@@ -15,6 +15,11 @@
+ // Package azureblob provides a blob implementation that uses Azure Storage’s
+ // BlockBlob. Use OpenBucket to construct a *blob.Bucket.
+ //
++// NOTE: SignedURLs for PUT created with this package are not fully portable;
++// they will not work unless the PUT request includes a ""x-ms-blob-type"" header
++// set to ""BlockBlob"".
++// See https://stackoverflow.com/questions/37824136/put-on-sas-blob-url-without-specifying-x-ms-blob-type-header.
++//
+ // URLs
+ //
+ // For blob.OpenBucket, azureblob registers for the scheme ""azblob"".",How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how.,Wondering if we should add a note that the `Block
+3014,"@@ -38,11 +38,14 @@ import java.util.List;
+  */
+ public class DynamicLangApiMethodTransformer {
+   private final ApiMethodParamTransformer apiMethodParamTransformer;
+-  private final InitCodeTransformer initCodeTransformer = new InitCodeTransformer();
++  private final InitCodeTransformer initCodeTransformer;
+   private final LongRunningTransformer lroTransformer = new LongRunningTransformer();
+
+-  public DynamicLangApiMethodTransformer(ApiMethodParamTransformer apiMethodParamTransformer) {
++  public DynamicLangApiMethodTransformer(
++      ApiMethodParamTransformer apiMethodParamTransformer,
++      InitCodeTransformer initCodeTransformer) {
+     this.apiMethodParamTransformer = apiMethodParamTransformer;
++    this.initCodeTransformer = initCodeTransformer;
+   }
+
+   public OptionalArrayMethodView generateMethod(MethodTransformerContext context) {","I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?",Nit: AutoValue might be a bit easier to read here
+3015,"@@ -151,14 +151,15 @@
+ //
+ // Representing Keys
+ //
+-// The key of a docstore document is some function of its contents, usually a field.
++// The key of a docstore document is its unique identifier, usually a field.
+ // Keys never appear alone in the docstore API, only as part of a document. For
+ // instance, to retrieve a document by key, you pass the Collection.Get method
+ // a document as a struct pointer or map with the key field populated, and docstore
+-// populates the rest of that argument with the stored contents.
++// populates the rest of that argument with the stored contents. Docstore
++// doesn't take zero-value key.
+ //
+-// When you open a collection using the OpenCollection method of the service-specific driver or
+-// a URL, you specify how to extract the key from a document.
++// When you open a collection using the constructor of the service-specific
++// driver or a URL, you specify how to extract the key from a document.
+ // Usually, you provide the name of the key field, as in the example below:
+ //
+ //   coll, err := memdocstore.OpenCollection(""SSN"", nil)","""Constructor"" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?","The key is not zero-value, it's just the key in t"
+3016,"@@ -114,7 +114,7 @@ class TestCtuFailure(unittest.TestCase):
+         """""" Test that Clang indeed logs the AST import events when using
+         on-demand mode.
+         """"""
+-        self.__set_up_test_dir('ctu_on_demand_failure')
++        self.__set_up_test_dir('ctu_failure')
+
+         output = self.__do_ctu_all(on_demand=True,
+                                    extra_args=[""--verbose"", ""debug""])",Why do we have to change the test dir?,Why was this changed?
+3017,"@@ -65,9 +65,11 @@ dom.isNativelyFocusable = function(el) {
+ 			return el.type !== 'hidden';
+ 		case 'TEXTAREA':
+ 		case 'SELECT':
+-		case 'DETAILS':
++		case 'SUMMARY':
+ 		case 'BUTTON':
+ 			return true;
++		case 'DETAILS':
++			return !el.querySelector('summary');
+ 	}
+ 	return false;
+ };",This should test the flattened tree instead. details > summary works across shadow tree boundaries.,shouldn't this be `re
+3018,"@@ -0,0 +1,17 @@
++// MvxBindingLog.cs
++
++// MvvmCross is licensed using Microsoft Public License (Ms-PL)
++// Contributions and inspirations noted in readme.md and license.txt
++//
++// Project Lead - Stuart Lodge, @slodge, me@slodge.com
++
++using MvvmCross.Platform;
++using MvvmCross.Platform.Logging;
++
++namespace MvvmCross
++{
++    internal static class MvxAndroidLog
++    {
++        internal static IMvxLog Instance { get; } = Mvx.Resolve<IMvxLogProvider>().GetLogFor(""MvxAndroid"");
++    }
++}",Not sure I am a big fan of these duplicated Log classes.,Should we call the cl
+3019,"@@ -39,6 +39,10 @@ import (
+
+ const (
+ 	reasonDomainVerified = ""DomainVerified""
++	CleanUpError         = ""CleanUpError""
++	PresentError         = ""PresentError""
++	Presented            = ""Presented""
++	Failed               = ""Failed""
+ )
+
+ // solver solves ACME challenges by presenting the given token and key in an","It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` .",Can we make the error
+3020,"@@ -32,7 +32,7 @@ const constexpr double LOOKAHEAD_DISTANCE_WITHOUT_LANES = 10.0;
+ // smaller widths, ranging from 2.5 to 3.25 meters. As a compromise, we use
+ // the 3.25 here for our angle calculations
+ const constexpr double ASSUMED_LANE_WIDTH = 3.25;
+-const constexpr double FAR_LOOKAHEAD_DISTANCE = 30.0;
++const constexpr double FAR_LOOKAHEAD_DISTANCE = 20.0;
+
+ // The count of lanes assumed when no lanes are present. Since most roads will have lanes for both
+ // directions or a lane count specified, we use 2. Overestimating only makes our calculations safer,","Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far.",Why is this changed?
+3021,"@@ -78,6 +78,12 @@ typedef enum {
+ 	CONTAINER_MODE_UMBRELLA
+ } container_mode_t;
+
++struct environment {
++	char *tarball;     /* Conda environemnt as produced by conda-pack. */
++	char *expansion;   /* Directory in cache/. Only set when environemnt has been expanded.*/
++	int error;         /* Whether the expansion had an error. 1 for yes, 0 for no. */
++};
++
+ #define DOCKER_WORK_DIR ""/home/worker""
+
+ // In single shot mode, immediately quit when disconnected.",Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda.,Should this be in co
+3022,"@@ -28,6 +28,8 @@ func TestStore_ListProjects(t *testing.T) {
+ 	cowProjectString, err := marshal(cowProject)
+ 	require.NoError(t, err, ""Marshal project should not fail"")
+
++	lastPageInPaginatedResp := false
++
+ 	testCases := map[string]struct {
+ 		mockGetParametersByPath func(t *testing.T, param *ssm.GetParametersByPathInput) (*ssm.GetParametersByPathOutput, error)
+ ",Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses,Doesn't look like th
+3023,"@@ -130,6 +130,9 @@ class BaseSnapshot implements Snapshot {
+     if (dataManifests == null) {
+       this.dataManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
+           manifest -> manifest.content() == ManifestContent.DATA));
++    }
++
++    if (deleteManifests == null) {
+       this.deleteManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
+           manifest -> manifest.content() == ManifestContent.DELETES));
+     }",What about using `dataManifests == null || deleteManifests == null`?,`Iterables.filter(al
+3024,"@@ -469,7 +469,7 @@ public class IndexSearcher {
+
+       @Override
+       public TopScoreDocCollector newCollector() throws IOException {
+-        return TopScoreDocCollector.create(cappedNumHits, after, TOTAL_HITS_THRESHOLD);
++        return TopScoreDocCollector.create(cappedNumHits, after, new GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD));
+       }
+
+       @Override",The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice.,"Nit: I'd inline the `new GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD)` factory method, rather than making it an instance variable."
+3025,"@@ -15,10 +15,14 @@
+ package openflow
+
+ import (
++	""antrea.io/antrea/pkg/agent/config""
++	""antrea.io/antrea/pkg/agent/openflow/cookie""
+ 	""fmt""
++	""k8s.io/client-go/tools/cache""
+ 	""net""
+ 	""strconv""
+ 	""strings""
++	""sync""
+
+ 	""k8s.io/apimachinery/pkg/util/intstr""
+ 	""k8s.io/klog/v2""",move this to below `antrea.io` import section,"We don't need this anymore, right?"
+3026,"@@ -80,6 +80,8 @@ namespace OpenTelemetry.Trace
+         /// </summary>
+         /// <param name=""activity"">Activity instance.</param>
+         /// <param name=""kind"">Activity execution kind.</param>
++        /// <remarks>This extension method should only be used on <see cref=""Activity""/> instances that were created
++        /// via older means that predate <see cref=""ActivitySource""/>.</remarks>
+         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+         public static void SetKind(this Activity activity, ActivityKind kind)
+         {",Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?,"This extension method should only be used on `Activity` instances that were created via older `ActivitySource` instances, and not on `"
+3027,"@@ -320,6 +320,18 @@ func (b *EthAPIBackend) SendTx(ctx context.Context, signedTx *types.Transaction)
+ 			if len(signedTx.Data()) > b.MaxCallDataSize {
+ 				return fmt.Errorf(""Calldata cannot be larger than %d, sent %d"", b.MaxCallDataSize, len(signedTx.Data()))
+ 			}
++			// The gas price must be a multiple of a gwei
++			if new(big.Int).Mod(signedTx.GasPrice(), big.NewInt(1e6)).Cmp(common.Big0) != 0 {
++				return errors.New(""Gas price must be a multiple of 1,000,000 wei"")
++			}
++			// If there is a value field set then reject transactions that
++			// contain calldata. The feature of sending transactions with value
++			// and calldata will be added in the future.
++			if signedTx.Value().Cmp(common.Big0) != 0 {
++				if len(signedTx.Data()) > 0 {
++					return errors.New(""Cannot send transactions with value and calldata"")
++				}
++			}
+ 		}
+ 		return b.eth.syncService.ApplyTransaction(signedTx)
+ 	}",gas price don't need to be a multiple cuz we support allll gas prices now,what's the reason to reject transactions with value and calldata?
+3028,"@@ -81,5 +81,10 @@ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.Interfaces
+         /// Send the request to abort the test run
+         /// </summary>
+         void SendTestRunAbort();
++
++        /// <summary>
++        /// handle client process exit
++        /// </summary>
++        void OnClientProcessExit();
+     }
+ }",We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?,This should be OnClientProcessExit
+3029,"@@ -1167,6 +1167,8 @@ def main(args,
+                   'address.\n')
+         else:
+             print('Error occurred on the server side, message: {}'.format(e))
++    except Exception as e:  # pylint: disable=broad-except
++        print ('Error occurred, message: {}'.format(e.message))
+     return config
+
+ ","It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first.",I think it should be just `print('
+3030,"@@ -18,7 +18,8 @@ return [
+             'widget_title_default' => 'Website',
+             'online' => 'Online',
+             'maintenance' => 'In maintenance',
+-            'manage_themes' => 'Manage themes'
++            'manage_themes' => 'Manage themes',
++            'customize_theme' => 'Customize Theme'
+         ]
+     ],
+     'theme' => [","This already exists under the `theme` lang key, please remove this.",What's the difference between `man
+3031,"@@ -223,6 +223,10 @@ class SetupUsingGCP extends Component {
+ 		return (
+ 			<Fragment>
+ 				<Header />
++				{ /*
++					Note: this component doesn't use hooks and thus can't access the
++					feature flags, so we don't render the HelpMenu here.
++				*/ }
+ 				<div className=""googlesitekit-wizard"">
+ 					<div className=""mdc-layout-grid"">
+ 						<div className=""mdc-layout-grid__inner"">",Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet).,I think we should add a class to t
+3032,"@@ -29,7 +29,7 @@ module Beaker
+         v_file << ""    v.vm.box = '#{host['box']}'\n""
+         v_file << ""    v.vm.box_url = '#{host['box_url']}'\n"" unless host['box_url'].nil?
+         v_file << ""    v.vm.base_mac = '#{randmac}'\n""
+-        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""255.255.0.0\""\n""
++        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
+         v_file << ""  end\n""
+         @logger.debug ""created Vagrantfile for VagrantHost #{host.name}""
+       end",I believe that you end up printing out the result of the assignment here instead of the netmask.,Use the new Ruby 1.9 hash syntax.
+3033,"@@ -0,0 +1,11 @@
++export const CREDENTIALS = {
++  user: 'test',
++  password: 'test'
++};
++
++export const TARBALL = 'tarball-blahblah-file.name';
++export const PORT_SERVER_APP = '55550';
++export const PORT_SERVER_1 = '55551';
++export const PORT_SERVER_2 = '55552';
++export const PORT_SERVER_3 = '55553';
++export const DOMAIN_SERVERS = 'localhost';",We have to update the filename here.,can we use something like `export
+3034,"@@ -121,6 +121,11 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""                         (see the --cpp-str-flex-ctor option to change this behavior).\n""
+     ""  --cpp-str-flex-ctor    Don't construct custom string types by passing std::string\n""
+     ""                         from Flatbuffers, but (char* + length).\n""
++    ""  --cpp-field-case STYLE Generate C++ fields using selected case style.\n""
++    ""                         Supported STYLE values:\n""
++    ""                          * 'unchanged' - leave unchanged (default);\n""
++    ""                          * 'upper' - schema snake_case emits UpperCamel;\n""
++    ""                          * 'lower' - schema snake_case emits lowerCamel.\n""
+     ""  --cpp-std CPP_STD      Generate a C++ code using features of selected C++ standard.\n""
+     ""                         Supported CPP_STD values:\n""
+     ""                          * 'c++0x' - generate code compatible with old compilers;\n""",The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case.,Nit: missing `;` here (and below)
+3035,"@@ -95,9 +95,6 @@ ot_admin_builtin_upgrade (int argc, char **argv, GCancellable *cancellable, GErr
+                                                   ""override-commit"", NULL);
+         }
+
+-      /* Should we consider requiring --discard-hotfix here? */
+-      origin_changed |= g_key_file_remove_key (origin, ""origin"", ""unlocked"", NULL);
+-
+       if (origin_changed)
+         {
+           /* XXX GCancellable parameter is not used. */","I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat.",We're not ignoring the return val
+3036,"@@ -18,6 +18,9 @@ package org.hyperledger.besu.evmtool;
+ import org.hyperledger.besu.config.GenesisConfigOptions;
+ import org.hyperledger.besu.consensus.clique.CliqueProtocolSchedule;
+ import org.hyperledger.besu.consensus.ibft.IbftBlockHeaderFunctions;
++import org.hyperledger.besu.crypto.KeyPairSecurityModule;
++import org.hyperledger.besu.crypto.NodeKey;
++import org.hyperledger.besu.crypto.SECP256K1;
+ import org.hyperledger.besu.ethereum.core.BlockHeaderFunctions;
+ import org.hyperledger.besu.ethereum.mainnet.ProtocolSchedule;
+ ",In my opinion I think it is possible to add `private final` here,please sort imports
+3037,"@@ -265,7 +265,7 @@ func (p *Builder) writeProgramHeader() {
+ 	p.b.LoadMapFD(R1, uint32(p.stateMapFD)) // R1 = 0 (64-bit immediate)
+ 	p.b.Call(HelperMapLookupElem)           // Call helper
+ 	// Check return value for NULL.
+-	p.b.JumpEqImm64(R0, 0, ""deny"")
++	p.b.JumpEqImm64(R0, 0, ""exit"")
+ 	// Save state pointer in R9.
+ 	p.b.Mov64(R9, R0)
+ 	p.b.LabelNextInsn(""policy"")","Feel like ""exit"" doesn't convey that the packet will be dropped. ""drop-and-exit"" or ""error-exit"" maybe?",Does this compile?
+3038,"@@ -1330,7 +1330,7 @@ static bool check_main_create(pass_opt_t* opt, ast_t* ast)
+   if(ast_childcount(params) != 1)
+   {
+     ast_error(opt->check.errors, params,
+-      ""the create constructor of a Main actor must take a single Env ""
++      ""A Main actor must have a create constructor which takes a single Env ""
+       ""parameter"");
+     ok = false;
+   }","How do you feel about ""The Main actor"" instead of ""A Main actor"", while we're already here changing the message?",A Main actor must *
+3039,"@@ -38,6 +38,7 @@ public interface PermissionNameProvider {
+     COLL_READ_PERM(""collection-admin-read"", null),
+     CORE_READ_PERM(""core-admin-read"", null),
+     CORE_EDIT_PERM(""core-admin-edit"", null),
++    ZK_READ_PERM(""zk-read"", null),
+     READ_PERM(""read"", ""*""),
+     UPDATE_PERM(""update"", ""*""),
+     CONFIG_EDIT_PERM(""config-edit"", unmodifiableSet(new HashSet<>(asList(""*"", null)))),","I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?",Can we remove this
+3040,"@@ -103,7 +103,7 @@ def as_spark_type(tpe) -> types.DataType:
+     """"""
+     # TODO: Add ""boolean"" and ""string"" types.
+     # ArrayType
+-    if tpe in (np.ndarray,):
++    if tpe in (list, np.ndarray,):
+         return types.ArrayType(types.StringType())
+     elif hasattr(tpe, ""__origin__"") and issubclass(tpe.__origin__, list):
+         return types.ArrayType(as_spark_type(tpe.__args__[0]))",Is this reasonable?,Shouldn't this be `collections.Sequence`?
+3041,"@@ -21,6 +21,7 @@ class AutoAugment(object):
+             augment images.
+
+     Examples:
++        TODO: Implement 'Shear', 'Sharpness' and 'Rotate' transforms
+         >>> replace = (104, 116, 124)
+         >>> policies = [
+         >>>     [",We may move this TODO to Line15.,Not sure if this should be in this PR or
+3042,"@@ -263,7 +263,12 @@ class OrderController extends BaseFrontController
+
+         /* check cart count */
+         $this->checkCartNotEmpty();
+-
++
++        /* check stock not empty */
++        if(true === ConfigQuery::checkAvailableStock()) {
++          return $this->checkStockNotEmpty();
++        }
++
+         /* check delivery address and module */
+         $this->checkValidDelivery();
+ ","You have to verify the return type. If it's a reponse, return it. Otherwise do nothing.",Please add space between `if` and `(`
+3043,"@@ -44,15 +44,17 @@
+
+ #include <Kokkos_Core.hpp>
+ #include <Kokkos_Timer.hpp>
+-#include <bench.hpp>
+ #include <cstdlib>
+
++template <class T>
++void run_stride_unroll(int, int, int, int, int, int, int, int);
++
+ int main(int argc, char* argv[]) {
+   Kokkos::initialize();
+
+   if (argc < 10) {
+     printf(""Arguments: N K R D U F T S\n"");
+-    printf(""  P:   Precision (1==float, 2==double)\n"");
++    printf(""  P:   Precision (1==float, 2==double, 3==int32_t, 4==int64_t)\n"");
+     printf(""  N,K: dimensions of the 2D array to allocate\n"");
+     printf(""  R:   how often to loop through the K dimension with each team\n"");
+     printf(""  D:   distance between loaded elements (stride)\n"");",No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch),See above about using `static constexpr i
+3044,"@@ -203,6 +203,8 @@ class TestPython3Checker(testutils.CheckerTestCase):
+             '[x for x in {}]',
+             'func({})',
+             'a, b = {}',
++            'max({}())',
++            'min({}())',
+         ]
+         non_iterating_code = [
+             'x = __({}())',","these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?",non-iterating code should not be included in this file.
+3045,"@@ -90,7 +90,7 @@ public class TestAvroNameMapping extends TestAvroReadProjection {
+     projected = writeAndRead(writeSchema, readSchema, record, nameMapping);
+     Record projectedL1 = ((Map<String, Record>) projected.get(""location"")).get(""l1"");
+     Assert.assertNotNull(""Field missing from table mapping is renamed"", projectedL1.getSchema().getField(""long_r2""));
+-    Assert.assertNull(""location.value.long, should not be read"", projectedL1.get(""long_r2""));
++    Assert.assertNull(""location.value.long, should not be read"", projectedL1.get(""long""));
+   }
+
+   @Test",Why did this need to change?,does one of these have to have a `_r2` at the end?
+3046,"@@ -0,0 +1,14 @@
++// Copyright (c) 2019 IoTeX Foundation
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package factory
++
++import ""github.com/iotexproject/iotex-core/action/protocol""
++
++// BranchDB defines the interface of an branch state db, which could start a new transaction
++type BranchDB interface {
++	NewTransaction() (protocol.Transaction, error)
++}",/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`),why do you need this interface? isn't BranchDB supposed
+3047,"@@ -128,6 +128,7 @@ public class ZkStateReader implements SolrCloseable {
+
+   public static final String CONFIGS_ZKNODE = ""/configs"";
+   public final static String CONFIGNAME_PROP = ""configName"";
++  public final static String COLLECTION_CONFIG_PROP = ""collection.configName"";
+
+   public static final String SAMPLE_PERCENTAGE = ""samplePercentage"";
+ ",Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name.,Why the config name is collection.configName?
+3048,"@@ -60,8 +60,11 @@ public class ITZipkinMetricsHealth {
+   }
+
+   @Test public void healthIsOK() throws Exception {
+-    assertThat(get(""/health"").isSuccessful())
+-      .isTrue();
++    Response check = get(""/health"");
++    assertThat(check.isSuccessful()).isTrue();
++    assertThat(check.body().string()).isEqualTo(
++      ""{\""status\"":\""UP\"",\""zipkin\"":{\""status\"":\""UP\"",\""details\"":{\""InMemoryStorage{}\"":{\""status\"":\""UP\""}}}}""
++    );
+
+     // ensure we don't track health in prometheus
+     assertThat(scrape())",in preparation of directly writing the /health endpoint one day.. we should have content checks.,Would be better to have a test case with a nested response.
+3049,"@@ -10,7 +10,7 @@ import (
+ type MultipleIDMatchesError struct{ prefix string }
+
+ func (e *MultipleIDMatchesError) Error() string {
+-	return fmt.Sprintf(""multiple IDs with prefix %s found"", e.prefix)
++	return fmt.Sprintf(""multiple IDs with prefix %q found"", e.prefix)
+ }
+
+ // A NoIDByPrefixError is returned by Find() when no ID for a given prefix",question (non-blocking): Is there a benefit from using `%q` instead of `%s`?,"I think `%q` is fine here, since it's a well-known prefix, "
+3050,"@@ -26,7 +26,6 @@ std::string MetaUtils::spaceKey(GraphSpaceID spaceId) {
+     return key;
+ }
+
+-
+ std::string MetaUtils::spaceVal(int32_t partsNum, int32_t replicaFactor, const std::string& name) {
+     std::string val;
+     val.reserve(256);",I would suggest to keep two empty lines between functions in cpp files,nit: empty line
+3051,"@@ -178,7 +178,7 @@ void runTests(int64_t numElements) {
+     {
+         test(0x01, C_d, C_h, numElements, syncNone, true /*expectMismatch*/);
+         test(0x02, C_d, C_h, numElements, syncNullStream, false /*expectMismatch*/);
+-        test(0x04, C_d, C_h, numElements, syncOtherStream, true /*expectMismatch*/);
++        test(0x04, C_d, C_h, numElements, syncOtherStream, false /*expectMismatch*/);
+         test(0x08, C_d, C_h, numElements, syncDevice, false /*expectMismatch*/);
+
+         // Sending a marker to to null stream may synchronize the otherStream",This change causes the test to fail on both rocm-1.9.x and rocm-head.,This seems to be the only functional change in this file.
+3052,"@@ -0,0 +1,17 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd;
++
++/**
++ * This interface allows to determine which rule violations are fixable, and with which class the fixes will be made.
++ */
++public interface AutoFixableRuleViolation extends RuleViolation {
++
++    /**
++     * Obtain the class which will attempt to fix the AST.
++     * @return
++     */
++    Class<? extends RuleViolationFix> getRuleViolationFixer();
++}",I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package,Why not `RuleViolationFixer`?
+3053,"@@ -266,7 +266,18 @@ def parse_compile_commands_json(logfile, parseLogOptions):
+         results = option_parser.parse_options(command)
+
+         action.original_command = command
+-        action.analyzer_options = results.compile_opts
++
++        # If the original include directory could not be found
++        # in the filesystem, it is possible that it was provided
++        # relative to the working directory in the compile json.
++        compile_opts = results.compile_opts
++        for i, opt in enumerate(compile_opts):
++            if opt.startswith('-I'):
++                inc_dir = opt[2:].strip()
++                if not os.path.isdir(inc_dir):
++                    compile_opts[i] = '-I' + \
++                        os.path.join(entry['directory'], inc_dir)
++        action.analyzer_options = compile_opts
+
+         action.lang = results.lang
+         action.target = results.arch",Use `os.path.join` for path concatenation.,This could just be `if not os
+3054,"@@ -18,11 +18,13 @@ from .retina_head import RetinaHead
+ from .retina_sepbn_head import RetinaSepBNHead
+ from .rpn_head import RPNHead
+ from .ssd_head import SSDHead
++from .yolact_head import YolactHead, YolactProtonet, YolactSegmHead
+
+ __all__ = [
+     'AnchorFreeHead', 'AnchorHead', 'GuidedAnchorHead', 'FeatureAdaption',
+     'RPNHead', 'GARPNHead', 'RetinaHead', 'RetinaSepBNHead', 'GARetinaHead',
+     'SSDHead', 'FCOSHead', 'RepPointsHead', 'FoveaHead',
+     'FreeAnchorRetinaHead', 'ATSSHead', 'FSAFHead', 'NASFCOSHead',
+-    'PISARetinaHead', 'PISASSDHead', 'GFLHead', 'CornerHead'
++    'PISARetinaHead', 'PISASSDHead', 'GFLHead', 'CornerHead', 'YolactHead',
++    'YolactSegmHead', 'YolactProtonet'
+ ]","Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead",I think we can remove `Yolact
+3055,"@@ -43,7 +43,7 @@ type harness struct {
+ }
+
+ func (h *harness) MakeDriver(ctx context.Context) (driver.Crypter, error) {
+-	return &Crypter{
++	return &crypter{
+ 		keyID: &KeyID{
+ 			ProjectID: projectID,
+ 			Location:  location,",The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%.,Why the change here?
+3056,"@@ -1038,7 +1038,14 @@ class CommentAnalyzer
+
+
+                     if ($method_tree_child->children) {
+-                        $param_type = Type::getTypeFromTree($method_tree_child->children[0], $codebase);
++                        try {
++                            $param_type = Type::getTypeFromTree($method_tree_child->children[0], $codebase);
++                        } catch (TypeParseTreeException $e) {
++                            $msg = 'Badly-formatted @method parameters for ' . $method_entry;
++                            $msg .= '; have you checked if a variable passed by reference has a space between';
++                            $msg .= ' the ampersand and the start of the variable?';
++                            throw new DocblockParseException($msg);
++                        }
+                         $docblock_lines[] = '@param \\' . $param_type . ' '
+                             . ($method_tree_child->variadic ? '...' : '')
+                             . $method_tree_child->name;",I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar.,Is the space after the ampersand actually necessary?
+3057,"@@ -83,7 +83,16 @@ public class AntlrBaseNode extends ParserRuleContext implements AntlrNode {
+
+     @Override
+     public Node jjtGetChild(final int index) {
+-        return (Node) children.get(index); // TODO: review if all children are Nodes
++        try {
++            return (Node) children.get(index);
++        } catch (final ClassCastException e) {
++            return new AntlrBaseNode();
++        }
++    }
++
++    @Override
++    public String getImage() {
++        return getText();
+     }
+
+     @Override","The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose.",What's the rationale for removing the `instanceof` h
+3058,"@@ -12,14 +12,14 @@ module RSpec
+
+       def initialize
+         @full_backtrace = false
+-        @exclusion_patterns = [] << Regexp.union(
++        @system_exclusion_patterns = [] << Regexp.union(
+           *[""/lib\d*/ruby/"",
+             ""org/jruby/"",
+             ""bin/"",
+             ""/gems/"",
+             ""lib/rspec/(core|expectations|matchers|mocks)""].
+-          map {|s| Regexp.new(s.gsub(""/"", File::SEPARATOR))}
+-        )
++          map {|s| Regexp.new(s.gsub(""/"", File::SEPARATOR))})
++        @exclusion_patterns = [] + @system_exclusion_patterns
+         @inclusion_patterns = [Regexp.new(Dir.getwd)]
+       end
+ ",The `[] +` seems weird to me. Why is it there?,Space missing inside {.<br>Space missing inside }.
+3059,"@@ -1,7 +1,7 @@
+ class FollowUp < ActiveRecord::Base
+   belongs_to :course
+-  validates_presence_of :email
+-  validates_format_of :email, with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i, on: :create
++  EMAIL_FORMAT = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i
++  validates :email, presence: true, format: { with: EMAIL_FORMAT }, on: :create
+
+   scope :have_not_notified, where(notified_at: nil)
+ ",Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?,Line is too long. [125/80]
+3060,"@@ -251,6 +251,17 @@ func checksum(bytes []byte) string {
+ 	return hex.EncodeToString(d[:])
+ }
+
++func isEmptyYaml(yaml []byte) bool {
++	isEmpty := true
++	lines := bytes.Split(yaml, []byte(""\n""))
++	for _, k := range lines {
++		if string(k) != ""---"" && !bytes.HasPrefix(k, []byte(""#"")) && string(k) != """" {
++			isEmpty = false
++		}
++	}
++	return isEmpty
++}
++
+ func yamlToObjects(in io.Reader) ([]runtime.Object, error) {
+ 	var result []runtime.Object
+ 	reader := yamlDecoder.NewYAMLReader(bufio.NewReaderSize(in, 4096))",What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?,is there a better way to check if a line starts with `--`?
+3061,"@@ -376,7 +376,7 @@ module OrgAdmin
+           # Load the funder's template(s)
+           templates = Template.valid.publicly_visible.where(published: true, org_id: funder_id).to_a
+
+-          if org_id.present?
++          unless org_id.blank?
+             # Swap out any organisational cusotmizations of a funder template
+             templates.each do |tmplt|
+               customization = Template.valid.find_by(published: true, org_id: org_id, customization_of: tmplt.dmptemplate_id)",if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374).,Rails/Present: Use if not.present? instead of unless.blank
+3062,"@@ -3403,6 +3403,13 @@ void Client::Handle_OP_AutoFire(const EQApplicationPacket *app)
+ 		DumpPacket(app);
+ 		return;
+ 	}
++
++	if (GetTarget() == this) {
++		this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++		auto_fire = false;
++		return;
++	}
++
+ 	bool *af = (bool*)app->pBuffer;
+ 	auto_fire = *af;
+ 	auto_attack = false;",Don't need this-> here.,brace on wrong line
+3063,"@@ -20,6 +20,9 @@ The metadata server is only accessible on GCE.
+ import httplib
+ import socket
+
++from google.auth.compute_engine import _metadata
++from google.auth.transport import requests
++
+ from google.cloud.forseti.common.util import errors
+ from google.cloud.forseti.common.util import logger
+ ","I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended.",nit: unused import
+3064,"@@ -1095,7 +1095,7 @@ class Resource:
+                         send_alert(self.request, message, url)
+                     operator = COMPARISON.LT
+
+-                if value == """":
++                if value == """" or isinstance(value, dict):
+                     raise_invalid(self.request, **error_details)
+
+                 filters.append(Filter(self.model.modified_field, value, operator))",There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number).,When would it be a dict?
+3065,"@@ -179,6 +179,18 @@ Status GoExecutor::prepareFrom() {
+                 status = Status::Error();
+                 break;
+             }
++            if (expr->isFunCallExpression()) {
++                auto *funcExpr = static_cast<FunctionCallExpression*>(expr);
++                if (*(funcExpr->name()) == ""near"") {
++                    auto v = Expression::asString(value.value());
++                    std::vector<VertexID> result;
++                    folly::split("","", v, result, true);
++                    starts_.insert(starts_.end(),
++                                   std::make_move_iterator(result.begin()),
++                                   std::make_move_iterator(result.end()));
++                    continue;
++                }
++            }
+             auto v = value.value();
+             if (!Expression::isInt(v)) {
+                 status = Status::Error(""Vertex ID should be of type integer"");","FYI, It won't have any benefit to move from trivial types.",Should we do this if we'
+3066,"@@ -37,6 +37,7 @@ const (
+ 	capabilityDockerPluginInfix                 = ""docker-plugin.""
+ 	attributeSeparator                          = "".""
+ 	capabilityPrivateRegistryAuthASM            = ""private-registry-authentication.secretsmanager""
++	capabilitySecretEnvSSM                      = ""secrets-ssm-environment-variables""
+ )
+
+ // capabilities returns the supported capabilities of this agent / docker-client pair.","i missed these discussions- but ` ""secrets-ssm-environment-variables""` is what was agreed upon with cp?",where is this used?
+3067,"@@ -20,6 +20,7 @@ import (
+ 	""google.golang.org/protobuf/types/known/anypb""
+ 	""gopkg.in/yaml.v3""
+
++	""github.com/gogo/protobuf/jsonpb""
+ 	gatewayv1 ""github.com/lyft/clutch/backend/api/config/gateway/v1""
+ 	""github.com/lyft/clutch/backend/middleware/timeouts""
+ )",whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?,I'm guessing you didn't
+3068,"@@ -127,6 +127,7 @@ public class RepositoriesPanel extends StackPane {
+         this.addButton.setText(tr(""Add""));
+         this.addButton.setOnAction((ActionEvent event) -> {
+             AddRepositoryDialog dialog = new AddRepositoryDialog();
++            dialog.initOwner(this.getParent().getScene().getWindow());
+
+             Optional<RepositoryLocation<? extends Repository>> successResult = dialog.showAndWait();
+ ",Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?,"The dialog should be created on the fly, not directly on the parent."
+3069,"@@ -108,6 +108,7 @@ if __name__ == ""__main__"":
+                 ""pytest-xdist==2.1.0"",
+                 ""pytest==6.1.1"",
+                 ""responses==0.10.*"",
++                ""scikit-learn<1.0.0"",  # scikit-learn 1.0 requires python 3.7
+                 ""snapshottest==0.6.0"",
+                 ""tox==3.14.2"",
+                 ""tox-pip-version==0.0.7"",","Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there).",shouldn't this be `scikit-learn>=1.0.0`?
+3070,"@@ -274,7 +274,6 @@ Status DataCollectExecutor::collectMultiplePairShortestPath(const std::vector<st
+ Status DataCollectExecutor::collectPathProp(const std::vector<std::string>& vars) {
+   DataSet ds;
+   ds.colNames = colNames_;
+-  DCHECK(!ds.colNames.empty());
+   // 0: vertices's props, 1: Edges's props 2: paths without prop
+   DCHECK_EQ(vars.size(), 3);
+ ",Why remove this?,Does this test pass after the change to `collectPathProp`?
+3071,"@@ -145,13 +145,3 @@ def test_completion_item_focus(tree, count, expected, completionview):
+         completionview.completion_item_focus(direction)
+     idx = completionview.selectionModel().currentIndex()
+     assert filtermodel.data(idx) == expected
+-
+-
+-def test_completion_item_focus_no_model(completionview):
+-    """"""Test that next/prev won't crash with no model set.
+-
+-    This can happen if completion.show and completion.auto-open are False.
+-    Regression test for issue #1722.
+-    """"""
+-    completionview.completion_item_focus('prev')
+-    completionview.completion_item_focus('next')","Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)",This test was removed because it doesn't do anything anymore.
+3072,"@@ -27,6 +27,7 @@ const SET_PERMISSION_SCOPE_ERROR = 'SET_PERMISSION_SCOPE_ERROR';
+
+ export const INITIAL_STATE = {
+ 	permissionError: null,
++	capabilities: global._googlesitekitUserData?.permissions || {},
+ };
+
+ export const actions = {","Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately.","I think `getUserData` should return empty object if there is no user data. So if there is no user data, we should set the `capabilities` to `{}`."
+3073,"@@ -234,3 +234,17 @@ def repeat_command(win_id, count=None):
+     cmd = runners.last_command[mode_manager.mode]
+     commandrunner = runners.CommandRunner(win_id)
+     commandrunner.run(cmd[0], count if count is not None else cmd[1])
++
++@cmdutils.register(debug=True,name='debug-log-capacity')
++def log_capacity(capacity: int):
++    """"""Choose number of lines for your log.
++
++    Args:
++       capacity: Number of lines for the log.
++    """"""
++    if capacity < 0:
++        raise cmdexc.CommandError(""Please choose log capacity above 0."")
++    else:
++        log.ram_handler.change_log_capacity(capacity)
++
++","Please add a space after the comma here (generally, with arguments there's always a space after commas).",We should probably have a consistent default for this and the `None` case.
+3074,"@@ -17,7 +17,7 @@ package org.hyperledger.besu.config.experimental;
+ import picocli.CommandLine.Option;
+
+ /**
+- * Flags defined in those class must be used with cautious, and strictly reserved to experimental
++ * Flags defined in those class must be used with caution, and strictly reserved to experimental
+  * EIPs.
+  */
+ public class ExperimentalEIPs {","From the context, should it say ""Flags defined in this class must be used with caution..."" ?",There is no `caution` in this sentence.
+3075,"@@ -0,0 +1,19 @@
++module.exports = {
++  roots: [
++    ""<rootDir>/javascript/grid-ui/src""
++  ],
++  testMatch: [
++    ""<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx""
++  ],
++  transform: {
++    ""^.+\\.(ts|tsx)$"": ""ts-jest""
++  },
++  moduleFileExtensions: [""ts"", ""tsx"", ""js"", ""jsx"", ""json"", ""node""],
++  snapshotSerializers: [""enzyme-to-json/serializer""],
++  setupFilesAfterEnv: [""<rootDir>/setupTests.ts""],
++  testEnvironment: ""jsdom"",
++  moduleNameMapper: {
++    "".+\\.(svg|png|jpg|css)$"": ""identity-obj-proxy"",
++    ""selenium/javascript/grid-ui/(.*)"": ""<rootDir>/$1""
++  }
++}","We don't need this file, we can use the one that is in the grid-ui directory",can we do the same for angular as well
+3076,"@@ -28,6 +28,7 @@ const (
+ 	infoNoAccounts                 = ""Did not find any account. Please import or create a new one.""
+ 	infoRenamedAccount             = ""Renamed account '%s' to '%s'""
+ 	infoImportedKey                = ""Imported %s""
++	infoExportedKey                = ""Imported key for account %s: \""%s\""""
+ 	infoImportedNKeys              = ""Imported %d key%s""
+ 	infoCreatedNewAccount          = ""Created new account with address %s""
+ 	errorNameAlreadyTaken          = ""The account name '%s' is already taken, please choose another.""","""Exported key for account""?",This should not be added to the constants file and should be removed from the code.
+3077,"@@ -37,6 +37,7 @@ namespace pwiz.Skyline.Util.Extensions
+     {
+         public const string EXT_CSV = "".csv""; // Not L10N
+         public const string EXT_TSV = "".tsv""; // Not L10N
++        public const string CRLF = ""\r\n""; // Not L10N
+
+         public static string FILTER_CSV
+         {",Normally we use Environment.NewLine unless you really want it to always be \r\n,Can we change this to `\r\n`?
+3078,"@@ -697,13 +697,6 @@ func (c *AuRa) verifyFamily(chain consensus.ChainHeaderReader, e consensus.Epoch
+ 	return nil
+ }
+
+-// VerifyHeaders is similar to VerifyHeader, but verifies a batch of headers. The
+-// method returns a quit channel to abort the operations and a results channel to
+-// retrieve the async verifications (the order is that of the input slice).
+-func (c *AuRa) VerifyHeaders(chain consensus.ChainHeaderReader, headers []*types.Header, _ []bool) error {
+-	return nil
+-}
+-
+ // VerifyUncles implements consensus.Engine, always returning an error for any
+ // uncles as this consensus mechanism doesn't permit uncles.
+ func (c *AuRa) VerifyUncles(chain consensus.ChainReader, header *types.Header, uncles []*types.Header) error {",why did you remove `verifyHeaders`?,why delete it?
+3079,"@@ -66,14 +66,14 @@ class RegistrationsController < Devise::RegistrationsController
+           if other_org.nil?
+             redirect_to(after_sign_up_error_path_for(resource), alert: _('You cannot be assigned to other organisation since that option does not exist in the system. Please contact your system administrators.')) and return
+           end
+-          params[:user][:org_id] = other_org.id
++          params[:user][:org_id] = other_org.id
+         end
+         build_resource(sign_up_params)
+         if resource.save
+           if resource.active_for_authentication?
+             set_flash_message :notice, :signed_up if is_navigational_format?
+             sign_up(resource_name, resource)
+-            UserMailer.welcome_notification(current_user).deliver
++            UserMailer.welcome_notification(current_user).deliver_now
+             unless oauth.nil?
+               # The OAuth provider could not be determined or there was no unique UID!
+               unless oauth['provider'].nil? || oauth['uid'].nil?",Thanks for cleaning up these deprecated calls,Metrics/LineLength: Line is too long. [93/80]
+3080,"@@ -110,13 +110,13 @@ def _create_user(username, password='', email=None, is_admin=False,
+                  requires_activation=True, requires_reset=False):
+     def check_conflicts(username, email):
+         if not VALID_USERNAME_RE.match(username):
+-            raise ValidationException(""Unacceptable username."")
++            raise ValidationException(""Invalid username."")
+         if blacklisted_name(username):
+-            raise ValidationException(""Unacceptable username."")
++            raise ValidationException(""Invalid username."")
+         if email is None:
+             raise ValidationException(""Must provide email."")
+         if not VALID_EMAIL_RE.match(email):
+-            raise ValidationException(""Unacceptable email."")
++            raise ValidationException(""Invalid email."")
+         if User.query.filter_by(name=username).one_or_none():
+             raise ConflictException(""Username already taken."")
+         if User.query.filter_by(email=email).one_or_none():","@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently.","This is not a username, only an invalid email."
+3081,"@@ -115,7 +115,7 @@ func parseResource(resource string) (string, string, string) {
+
+ // is resource type require remote query
+ func requireRemoteQuery(resType string) bool {
+-	return resType == model.ResourceTypeConfigmap || resType == model.ResourceTypeSecret || resType == constants.ResourceTypeService || resType == constants.ResourceTypeEndpoints
++	return resType == model.ResourceTypeConfigmap || resType == model.ResourceTypeSecret || resType == constants.ResourceTypeEndpoints
+ }
+
+ func isConnected() bool {",We support process remoteQuery for Service. Why are we removing it ?,why remove the service resource type check?
+3082,"@@ -6,10 +6,17 @@ require 'bolt/task'
+ require 'json'
+
+ class TransportAPI < Sinatra::Base
++  # This disables Sinatra's error page generation
++  set :show_exceptions, false
++
+   get '/' do
+     200
+   end
+
++  get '/500_error' do
++    raise 'Unexpected error'
++  end
++
+   post '/ssh/run_task' do
+     content_type :json
+ ",This is specifically for testing?,Would it make sense to add a spec in `/spec/mo
+3083,"@@ -71,7 +71,6 @@ class TagsController extends AbstractAdmin
+     {
+         $view = $this->createViewModel();
+         $view->setTemplate('admin/tags/home');
+-        $view->statistics = $this->getTable('resourcetags')->getStatistics(true);
+         return $view;
+     }
+ ",I think this is related to the social stats and probably does not need to be removed.,Why did you remove this?
+3084,"@@ -13,6 +13,7 @@ import { PhysicalIndexToValueMap as IndexToValueMap } from './../../translations
+ const privatePool = new WeakMap();
+ const COLUMN_SIZE_MAP_NAME = 'autoColumnSize';
+
++/* eslint-disable jsdoc/require-description-complete-sentence */
+ /**
+  * @plugin AutoColumnSize
+  *","Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins.",Please also turn this `eslint-disable` into an `eslint-plugin`.
+3085,"@@ -58,6 +58,13 @@ func (c *azureClient) GetVirtualMachineResourceID(ctx context.Context, principal
+ 	}
+
+ 	values := result.Values()
++	for len(values) == 0 {
++		nerr := result.NextWithContext(ctx)
++		if nerr != nil {
++			return """", errs.Wrap(nerr)
++		}
++		values = result.Values()
++	}
+ 	if len(values) == 0 {
+ 		return """", errs.New(""principal %q not found"", principalID)
+ 	}",This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`.,It seems like this could be split over two lines to improve rea
+3086,"@@ -1358,6 +1358,10 @@ func (exp *Service) GetBlockOrActionByHash(hashStr string) (explorer.GetBlkOrAct
+ 		return explorer.GetBlkOrActResponse{Execution: &exe}, nil
+ 	}
+
++	if exe, err := exp.GetAddressDetails(hashStr); err == nil {
++		return explorer.GetBlkOrActResponse{AddressDetails: &exe}, nil
++	}
++
+ 	return explorer.GetBlkOrActResponse{}, nil
+ }
+ ",unknown field AddressDetails in struct literal (from `typecheck`),This should be done in explorer_v2_exec.go rather than in explo
+3087,"@@ -33,7 +33,13 @@ func sessionForRegion(region string) (*session.Session, error) {
+ 		return s.(*session.Session), nil
+ 	}
+
+-	ns, err := session.NewSession(aws.NewConfig().WithRegion(region))
++	ns, err := session.NewSessionWithOptions(session.Options{
++		// Provide SDK Config options, such as Region.
++		Config: aws.Config{
++			Region: aws.String(region),
++		},
++	})
++
+ 	if err != nil {
+ 		return nil, err
+ 	}","Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?",Should we also include `Config: aws.Config{Region: aws.String(r
+3088,"@@ -67,9 +67,9 @@ namespace pwiz.Skyline.Model.Results
+                 var newTimeIntensities = GetTimeIntensities(Source);
+                 if (newTimeIntensities != null)
+                 {
+-                    if (oldTimeIntensities != null)
++                    if (oldTimeIntensities != null && oldTimeIntensities.NumPoints > 0)
+                     {
+-                        var oldTime = oldTimeIntensities.Times[ScanIndex];
++                        var oldTime = oldTimeIntensities.Times[Math.Min(ScanIndex, oldTimeIntensities.NumPoints - 1)];
+                         ScanIndex = newTimeIntensities.IndexOfNearestTime(oldTime);
+                     }
+                     else",Not sure what this is. Bad merge?,Can you explain why this change is needed? Is it because `ScanIndex` is computed from `newTimeIntensities`?
+3089,"@@ -1318,9 +1318,12 @@ func (s *Server) updateAccountWithClaimJWT(acc *Account, claimJWT string) error
+ 	if acc == nil {
+ 		return ErrMissingAccount
+ 	}
+-	if acc.claimJWT != """" && acc.claimJWT == claimJWT && !acc.incomplete {
++	acc.mu.Lock()
++	sameClaim := acc.claimJWT != """" && acc.claimJWT == claimJWT && !acc.incomplete
++	acc.mu.Unlock()
++	if sameClaim {
+ 		s.Debugf(""Requested account update for [%s], same claims detected"", acc.Name)
+-		return ErrAccountResolverSameClaims
++		return nil
+ 	}
+ 	accClaims, _, err := s.verifyAccountClaims(claimJWT)
+ 	if err == nil && accClaims != nil {",I think this may be a RW lock.,don't we need a lock here?
+3090,"@@ -1,4 +1,4 @@
+-package pluginhelper
++package helpers
+
+ import (
+ 	""bytes""",Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?,@andrewkroh Can you review this change since you originally added this file?
+3091,"@@ -810,6 +810,14 @@ void Client::SendTradeskillSearchResults(
+ 				continue;
+ 			}
+ 		}
++
++		//Check if we need to learn it before sending them the recipe..
++		DBTradeskillRecipe_Struct spec;
++		if (content_db.GetTradeRecipe(recipe_id, objtype, someid, this->CharacterID(), &spec)) {
++			if ((spec.must_learn & 0xf) && !spec.has_learnt) {
++				continue;
++			}
++		}
+
+ 		auto               outapp = new EQApplicationPacket(OP_RecipeReply, sizeof(RecipeReply_Struct));
+ 		RecipeReply_Struct *reply = (RecipeReply_Struct *) outapp->pBuffer;",Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check,can you make this condition a bit more readable?
+3092,"@@ -386,6 +386,8 @@ class Index(IndexOpsMixin):
+         array([0, 1, 2, 3])
+         >>> ks.DataFrame({'a': ['a', 'b', 'c']}, index=[[1, 2, 3], [4, 5, 6]]).index.to_numpy()
+         array([(1, 4), (2, 5), (3, 6)], dtype=object)
++        >>> ks.DataFrame({'a': ['a', 'b', 'c']}, index=[[1, 2, 3], [4, 5, 6]]).index.to_numpy(copy=True)
++        array([(1, 4), (2, 5), (3, 6)], dtype=object)
+         """"""
+         result = np.asarray(self.to_pandas()._values, dtype=dtype)
+         if copy:",too long here. (104 > 100),"Instead of `.to_numpy(copy=True)` this should probably just be `np.array([1, 2], dtype=object)`"
+3093,"@@ -210,7 +210,14 @@ namespace Nethermind.DataMarketplace.Subprotocols
+             }
+
+             Logger.Warn($""GETTING MESSAGE: ndm.{NdmMessageCode.GetDescription(message.PacketType)}"");
+-            MessageHandlers[message.PacketType](message);
++            try
++            {
++                MessageHandlers[message.PacketType](message);
++            }
++            catch(KeyNotFoundException)
++            {
++                Logger.Error(""$There is no handler registered for this message"");
++            }
+         }
+
+         protected virtual void Handle(HiMessage message)",Use TryGetValue instead of catching exception,Why don't we just catch `Exception` here?
+3094,"@@ -4,12 +4,12 @@ feature 'Admin manages mentors' do
+   scenario 'creating a new mentor' do
+     user = create(:admin)
+
+-    visit admin_path(as: user)
++    visit admin_root_path(as: user)
+     click_link 'Mentors'
+-    click_link 'Add new'
++    click_link 'New mentor'
+     select(user.name, from: 'User')
+-    click_button 'Save'
++    click_button 'Create Mentor'
+
+-    expect(page).to have_content('Mentor successfully created')
++    expect(page).to have_content('Mentor was successfully created')
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escap
+3095,"@@ -61,6 +61,17 @@ namespace fastrtps {
+ namespace rtps {
+
+
++static void add_statistics_sent_submessage(
++        CacheChange_t* change,
++        size_t num_locators)
++{
++    static_cast<void>(change);
++    static_cast<void>(num_locators);
++
++#ifdef FASTDDS_STATISTICS
++    change->num_sent_submessages += num_locators;
++#endif // ifdef FASTDDS_STATISTICS
++}
+
+ /**
+  * Loops over all the readers in the vector, applying the given routine.",I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct.,"Would it be better to add a new method to CacheChange that takes the ""num_sent_submessages"" arg"
+3096,"@@ -74,10 +74,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+             }
+         }
+
+-        // Review: This is called when a CancellationToken fires mid-write. In HTTP/1.x, this aborts the entire connection.
+-        // Should we do that here?
++        // This is called when a CancellationToken fires mid-write. In HTTP/1.x, this aborts the entire connection.
++        // For HTTP/2 we abort the stream.
+         void IHttpOutputAborter.Abort(ConnectionAbortedException abortReason)
+         {
++            _stream.ResetAndAbort(abortReason, Http2ErrorCode.INTERNAL_ERROR);
+             Dispose();
+         }
+ ","You add a stream back reference for trailers, and all of the sudden we have tight coupling!  ",Is there a specific reason for not calling `Dispose`?
+3097,"@@ -2,6 +2,7 @@ using System;
+ using System.Collections;
+ using System.Collections.Concurrent;
+ using System.Collections.Generic;
++using System.Linq;
+ using Datadog.Trace.ClrProfiler.Emit;
+ using Datadog.Trace.ExtensionMethods;
+ using Datadog.Trace.Headers;",I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file.,Why do we need this?
+3098,"@@ -65,14 +65,14 @@
+ 	return modules;
+ }([
+ /* 0 */
+-/***/ function(module, exports, __webpack_require__) {
++/***/ (function(module, exports, __webpack_require__) {
+
+ 	module.exports = __webpack_require__(1);
+
+
+-/***/ },
++/***/ }),
+ /* 1 */
+-/***/ function(module, exports, __webpack_require__) {
++/***/ (function(module, exports, __webpack_require__) {
+
+ 	'use strict';
+ ","Please avoid committing build artifacts, as they produce unnecessary conflicts and noise.","This is not correct, it should be `/***/`"
+3099,"@@ -101,7 +101,7 @@ class RetryWrapper:
+
+         if name in self.__unwrap_methods:
+             return partial(x.__func__, self)
+-        elif hasattr(x, ""__call__""):
++        elif callable(x):
+             return self.__wrap_method_with_call_and_maybe_retry(x)
+         else:
+             return x",this is vendored code so i would hesitate to make random changes to it,Not sure about this one. `__call__` won't work if `x`
+3100,"@@ -34,7 +34,13 @@ type payoutInfo struct {
+ 	// in Ethereum address format
+ 	// required: true
+ 	// example: 0x000000000000000000000000000000000000000a
+-	EthAddress   string `json:""ethAddress""`
++	EthAddress string `json:""ethAddress""`
++}
++
++// swagger:model ReferralInfoDTO
++type referralInfo struct {
++	// required: true
++	// example: ABC123
+ 	ReferralCode string `json:""referral_code""`
+ }
+ ",We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case,shouldn't this be moved to d/auth/types.go?
+3101,"@@ -10,6 +10,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+     public static class HttpContextIntegration
+     {
+         private const string IntegrationName = ""HttpContext"";
++        private const string DefaultHttpContextTypeName = ""HttpContext"";
+         private static readonly ILog Log = LogProvider.GetLogger(typeof(HttpContextIntegration));
+
+         /// <summary>","Should this be `""Microsoft.AspNetCore.Http.DefaultHttpContext""`?",Why is this constant needed?
+3102,"@@ -68,7 +68,6 @@ interface ArrayType<T> {
+     /** Repeatedly group an array into equal sized sub-trees */
+     default Object grouped(Object array, int groupSize) {
+         final int arrayLength = lengthOf(array);
+-        assert arrayLength > groupSize;
+         final Object results = obj().newInstance(1 + ((arrayLength - 1) / groupSize));
+         obj().setAt(results, 0, copyRange(array, 0, groupSize));
+ ","removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/",This assertion looks redundant now. It's al
+3103,"@@ -47,8 +47,14 @@ class MessageDefinitionStore:
+         self._messages_definitions[message.msgid] = message
+         self._msgs_by_category[message.msgid[0]].append(message.msgid)
+
++    # We disable the message here because MessageDefinitionStore is only
++    # initialized once and due to the size of the class does not run the
++    # risk of creating a large memory leak.
++    # See discussion in: https://github.com/PyCQA/pylint/pull/5673
+     @functools.lru_cache()
+-    def get_message_definitions(self, msgid_or_symbol: str) -> List[MessageDefinition]:
++    def get_message_definitions(  # pylint: disable=lru-cache-decorating-method
++        self, msgid_or_symbol: str
++    ) -> List[MessageDefinition]:
+         """"""Returns the Message definition for either a numeric or symbolic id.
+
+         The cache has no limit as its size will likely stay minimal. For each message we store",Do we want to raise on the function or on the decorator?,Can you elaborate why this change is needed
+3104,"@@ -38,7 +38,7 @@ class Listen(object):
+             user_name=j.get('user_name', """"),
+             timestamp=datetime.utcfromtimestamp(float(j['listened_at'])),
+             artist_msid=j['track_metadata']['additional_info'].get('artist_msid'),
+-            album_msid=j['track_metadata']['additional_info'].get('album_msid'),
++            album_msid=j['track_metadata']['additional_info'].get('release_msid'),
+             recording_msid=j.get('recording_msid'),
+             data=j.get('track_metadata')
+         )",How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?,"Same here, this should be `album_msid=j['track_metadata']['additional_info']['album_msid']`"
+3105,"@@ -96,13 +96,13 @@ func (n *Namespaces) Remove(t NamespaceType) bool {
+ 	return true
+ }
+
+-func (n *Namespaces) Add(t NamespaceType, path string) {
++func (n *Namespaces) Add(t NamespaceType, path string) bool {
+ 	i := n.index(t)
+ 	if i == -1 {
+ 		*n = append(*n, Namespace{Type: t, Path: path})
+-		return
++		return true
+ 	}
+-	(*n)[i].Path = path
++	return false
+ }
+
+ func (n *Namespaces) index(t NamespaceType) int {","You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that.",`return len(n) == 0` would be more readable.
+3106,"@@ -10,6 +10,16 @@
+  * @return {Boolean} the element's hidden status
+  */
+ dom.isHiddenWithCSS = function isHiddenWithCSS(el, descendentVisibilityValue) {
++	const vNode = axe.utils.getNodeFromTree(el);
++
++	if (vNode._isHiddenWithCSS === void 0) {
++		vNode._isHiddenWithCSS = _isHiddenWithCSS(el, descendentVisibilityValue);
++	}
++
++	return vNode._isHiddenWithCSS;
++};
++
++function _isHiddenWithCSS(el, descendentVisibilityValue) {
+ 	if (el.nodeType === 9) {
+ 		// 9 === Node.DOCUMENT
+ 		return false;",@straker should this not push to `vnode._cache.isHiddenWithCSS`?,Why the `void 0` instead of `false`?
+3107,"@@ -12,8 +12,8 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+
+-// Package driver provides the interface for providers of runtimevar.  This serves as a contract
+-// of how the runtimevar API uses a provider implementation.
++// Package driver defines an interface that the runtimevar package uses to
++// interact with the underlying runtime configuration services.
+ package driver // import ""gocloud.dev/runtimevar/driver""
+
+ import (","""an interface"" in conceptual sense vs ""interfaces"" or ""set of interfaces"", referring to the Go interfaces - database/sql uses the latter, should we?","The name ""runtimevar"" is a bit misleading, it's the runtime var and not the runtime var."
+3108,"@@ -335,8 +335,11 @@ public class DownloadService extends Service {
+                             && String.valueOf(HttpURLConnection.HTTP_GONE).equals(status.getReasonDetailed());
+                     boolean httpBadReq = status.getReason() == DownloadError.ERROR_HTTP_DATA_ERROR
+                             && String.valueOf(HttpURLConnection.HTTP_BAD_REQUEST).equals(status.getReasonDetailed());
++                    boolean ioError = status.getReason() == DownloadError.ERROR_IO_ERROR;
++                    boolean connectError = status.getReason() == DownloadError.ERROR_CONNECTION_ERROR;
+
+-                    if (httpNotFound || forbidden || notEnoughSpace || wrongFileType || httpGone || httpBadReq ) {
++                    if (httpNotFound || forbidden || notEnoughSpace || wrongFileType
++                            || httpGone || httpBadReq || ioError || connectError) {
+                         try {
+                             DBWriter.saveFeedItemAutoDownloadFailed(item).get();
+                         } catch (ExecutionException | InterruptedException e) {","This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)",Why not `httpNotFound || forbidden || notEnoughSpace || httpBadReq`?
+3109,"@@ -247,7 +247,8 @@ func (brq *blockRetrievalQueue) PutInCaches(ctx context.Context,
+
+ // checkCaches copies a block into `block` if it's in one of our caches.
+ func (brq *blockRetrievalQueue) checkCaches(ctx context.Context,
+-	kmd KeyMetadata, ptr BlockPointer, block Block) (PrefetchStatus, error) {
++	kmd KeyMetadata, ptr BlockPointer, block Block, doSync bool) (
++	PrefetchStatus, error) {
+ 	// Attempt to retrieve the block from the cache. This might be a specific
+ 	// type where the request blocks are CommonBlocks, but that direction can
+ 	// Set correctly. The cache will never have CommonBlocks.",Can you make this accept an action instead?,"Nit: `doSync` is a bit confusing here, since it isn't obvious what i"
+3110,"@@ -33,3 +33,16 @@ When /^I should see an image with name ""([^""]*)""$/ do |image_name|
+   page.should have_selector(""img"", src: /#{image_name}/)
+ end
+
++When /^a product named ""([^""]*)""$/ do |product_name|
++   create(:product, fulfillment_method: ""fetch"", name: product_name, product_type: ""screencast"")
++end
++
++When /^a video download product named ""([^""]*)""$/ do |product_name|
++   product = create(:product, fulfillment_method: ""fetch"", name: product_name, product_type: ""screencast"")
++   create(:download, download_file_name: ""test.txt"", description: ""test desc"", product: product)
++   create(:video, product: product)
++end
++
++Given /^there is a github product named ""([^""]*)""$/ do |product_name|
++  create(:product, fulfillment_method: ""github"", name: product_name, product_type: ""book"")
++end",Tab inconsistency here (3 spaces instead of 2 spaces),Rails/DynamicFindBy: Use find_by instead of dynamic find.
+3111,"@@ -56,14 +56,15 @@ func defaultConfig() Genesis {
+ 			EnableGravityChainVoting: true,
+ 		},
+ 		Rewarding: Rewarding{
+-			InitBalanceStr:                 unit.ConvertIotxToRau(1200000000).String(),
++			InitBalanceStr:                 unit.ConvertIotxToRau(200000000).String(),
+ 			BlockRewardStr:                 unit.ConvertIotxToRau(16).String(),
+-			EpochRewardStr:                 unit.ConvertIotxToRau(300000).String(),
++			EpochRewardStr:                 unit.ConvertIotxToRau(12500).String(),
++			AleutianEpochRewardStr:         unit.ConvertIotxToRau(15000).String(),
+ 			NumDelegatesForEpochReward:     100,
+ 			ExemptAddrStrsFromEpochReward:  []string{},
+-			FoundationBonusStr:             unit.ConvertIotxToRau(2880).String(),
++			FoundationBonusStr:             unit.ConvertIotxToRau(80).String(),
+ 			NumDelegatesForFoundationBonus: 36,
+-			FoundationBonusLastEpoch:       365,
++			FoundationBonusLastEpoch:       8760,
+ 		},
+ 	}
+ }",these change means we are changing epoch to 1 hour?,why do we need this change?
+3112,"@@ -46,6 +46,11 @@ import core
+ import keyboardHandler
+ import characterProcessing
+ from . import guiHelper
++
++#: The size that settings panel text descriptions should be wrapped at.
++# Ensure self.scaleSize is used to adjust for OS scaling adjustments.
++PANEL_DESCRIPTION_WIDTH = 544
++
+ try:
+ 	import updateCheck
+ except RuntimeError:",Why this is defined in the middle of imports?,"Now that we have `PANEL_DESCRIPTION_WIDTH` defined twice, I think it would make sense to move this to `settings.py`"
+3113,"@@ -14,8 +14,10 @@
+ # limitations under the License.
+ #
+
++import importlib
+ from distutils.version import LooseVersion
+
++_backends = {}
+ import matplotlib
+ import numpy as np
+ import pandas as pd",Could you move this to the original position?,Don't we still need to import `pandas` and then do `pd.to_numpy`?
+3114,"@@ -160,7 +160,7 @@ func (s *Source) Owner() (string, error) {
+ 	if err != nil {
+ 		return """", err
+ 	}
+-	return oAndR.repo, nil
++	return oAndR.owner, nil
+ }
+
+ // PipelineStage represents configuration for each deployment stage",Is there a test that'd have caught this?,why did you change this?
+3115,"@@ -419,7 +419,7 @@ func (s *VisibilityPersistenceSuite) TestFilteringByType() {
+
+ 	// List open with filtering
+ 	resp, err2 := s.VisibilityMgr.ListOpenWorkflowExecutionsByType(&visibility.ListWorkflowExecutionsByTypeRequest{
+-		ListWorkflowExecutionsRequest: visibility.ListWorkflowExecutionsRequest{
++		ListWorkflowExecutionsRequest: &visibility.ListWorkflowExecutionsRequest{
+ 			NamespaceID:       testNamespaceUUID,
+ 			PageSize:          2,
+ 			EarliestStartTime: startTime,",ListWorkflowExecutionsRequest <- this can be nil?,"Not related to this PR, but `err2` could be nil here."
+3116,"@@ -809,10 +809,14 @@ module Beaker
+       # This wraps the method `stub_hosts_on` and makes the stub specific to
+       # the forge alias.
+       #
++      # forge api v1 canonical source is forge.puppetlabs.com
++      # forge api v3 canonical source is forgeapi.puppetlabs.com
++      #
+       # @param machine [String] the host to perform the stub on
+       def stub_forge_on(machine)
+         @forge_ip ||= Resolv.getaddress(forge)
+         stub_hosts_on(machine, 'forge.puppetlabs.com' => @forge_ip)
++        stub_hosts_on(machine, 'forgeapi.puppetlabs.com' => @forge_ip)
+       end
+
+       # This wraps the method `stub_hosts` and makes the stub specific to","Do we need to continue to support the old link, or is it dead dead dead?",do we need this stub for all versions?
+3117,"@@ -108,6 +108,14 @@ namespace Datadog.Trace.Configuration
+             GlobalTags = GlobalTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
+                                    .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
+
++            HeaderTags = source?.GetDictionary(ConfigurationKeys.HeaderTags) ??
++                         // default value (empty)
++                         new ConcurrentDictionary<string, string>();
++
++            // Filter out tags with empty keys or empty values, and trim whitespace
++            HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
++                                   .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
++
+             DogStatsdPort = source?.GetInt32(ConfigurationKeys.DogStatsdPort) ??
+                             // default value
+                             8125;",Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`.,Can we use `string.IsNullOrEmpty` inst
+3118,"@@ -325,10 +325,12 @@ func validateRegisteredAttributes(expectedAttributes, actualAttributes []*ecs.At
+ }
+
+ func (client *APIECSClient) getAdditionalAttributes() []*ecs.Attribute {
++	osFamilyStr := config.GetOSFamilyType()
++	seelog.Infof(""Server OSFamily string: %s"", osFamilyStr)
+ 	return []*ecs.Attribute{
+ 		{
+ 			Name:  aws.String(""ecs.os-type""),
+-			Value: aws.String(config.OSType),
++			Value: aws.String(osFamilyStr),
+ 		},
+ 	}
+ }",this seems like more of a Debugf statement,"I know it's old code, but should we be"
+3119,"@@ -972,10 +972,11 @@ void CoreChecks::RecordBarrierArrayValidationInfo(const char *func_name, CMD_BUF
+             bool mode_concurrent = handle_state ? handle_state->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT : false;
+             if (!mode_concurrent) {
+                 const auto typed_handle = BarrierTypedHandle(barrier);
+-                cb_state->eventUpdates.emplace_back(
+-                    [this, func_name, cb_state, typed_handle, src_queue_family, dst_queue_family](VkQueue queue) {
+-                        return ValidateConcurrentBarrierAtSubmit(queue, func_name, cb_state, typed_handle, src_queue_family,
+-                                                                 dst_queue_family);
++                cb_state->queue_submit_functions.emplace_back(
++                    [func_name, cb_state, typed_handle, src_queue_family, dst_queue_family](
++                        const ValidationStateTracker *device_data, const QUEUE_STATE *queue_state) {
++                        return ValidateConcurrentBarrierAtSubmit(device_data, queue_state, func_name, cb_state, typed_handle,
++                                                                 src_queue_family, dst_queue_family);
+                     });
+             }
+         }","We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern.",The function name is a bit misleading.
+3120,"@@ -194,6 +194,12 @@ func (c *AwsEndpointDiscoveryTest) TestDiscoveryIdentifiersRequiredRequest(input
+
+ 	output = &TestDiscoveryIdentifiersRequiredOutput{}
+ 	req = c.newRequest(op, input, output)
++
++	// if a custom endpoint is provided for the request,
++	// we skip endpoint discovery workflow
++	if req.Config.Endpoint != nil {
++		return
++	}
+ 	de := discovererDescribeEndpoints{
+ 		Required:      true,
+ 		EndpointCache: c.endpointCache,",Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped.,"If the endpoint is required, should we log something here?"
+3121,"@@ -80,7 +80,7 @@ describe('debug', () => {
+ 	it('should print an error on double jsx conversion', () => {
+ 		let Foo = <div />;
+ 		let fn = () => render(h(<Foo />), scratch);
+-		expect(fn).to.throw(/createElement/);
++		expect(fn).to.throw(/JSX twice/);
+ 	});
+
+ 	it('should add __source to the vnode in debug mode.', () => {",This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol.,"@netchampfaris, does this change belong here?"
+3122,"@@ -40,3 +40,8 @@ func (i *Initializer) initHostNetworkFlows() error {
+ func (i *Initializer) getTunnelPortLocalIP() net.IP {
+ 	return nil
+ }
++
++// registerServiceforOS returns immediately on Linux.
++func (i *Initializer) registerServiceforOS() error {
++	return  nil
++}","I think this is added to wrong file. You wanted to add to cmd/agent/, right?",error strings should not be capitalized or end with punctu
+3123,"@@ -348,10 +348,12 @@ public class ExpectedConditions {
+                                                                     final String text) {
+
+     return new ExpectedCondition<Boolean>() {
++      private String elementText = null;
++
+       @Override
+       public Boolean apply(WebDriver driver) {
+         try {
+-          String elementText = element.getText();
++          elementText = element.getText();
+           return elementText.contains(text);
+         } catch (StaleElementReferenceException e) {
+           return null;","Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal.","This field is not initialized in the constructor, so I thi"
+3124,"@@ -117,6 +117,7 @@ type NetworkConfig struct {
+ 	CNIVersion string          `json:""cniVersion,omitempty""`
+ 	Name       string          `json:""name,omitempty""`
+ 	Type       string          `json:""type,omitempty""`
++	DeviceID   string          `json:""deviceID""` // PCI address of a VF
+ 	MTU        int             `json:""mtu,omitempty""`
+ 	DNS        cnitypes.DNS    `json:""dns""`
+ 	IPAM       ipam.IPAMConfig `json:""ipam,omitempty""`","Could we consider a more explicit name, like `devicePciAddress`?",Does it matter that all VMs have a device ID? Does it matter that all VMs have a device ID?
+3125,"@@ -109,10 +109,14 @@ public class WindowsUtils {
+      * quote (\""?)
+      */
+     // TODO We should be careful, in case Windows has ~1-ified the executable name as well
+-    pattern.append(""\""?.*?\\\\"");
+-    pattern.append(executable.getName());
++    pattern.append(""(\""?.*?\\\\)?"");
++    String execName = executable.getName();
++    pattern.append(execName);
++    if (!execName.endsWith("".exe"")) {
++      pattern.append(""(\\.exe)?"");
++    }
+     pattern.append(""\""?"");
+-    for (String arg : cmdarray) {
++    for (int i = 1; i < cmdarray.length; i++) {
+       /*
+        * There may be a space, but maybe not (\\s?), may be a quote or maybe not (\""?), but then
+        * turn on block quotation (as if *everything* had a regex backslash in front of it) with \Q.",Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it.,"Shouldn't this be <code> if (!execName.endsWith("".exe"") { pattern.append(""(""); } </code> ?"
+3126,"@@ -610,8 +610,9 @@ class SolrService extends \Apache_Solr_Service
+             $solrconfigXmlUrl = $this->_scheme . '://'
+                 . $this->_host . ':' . $this->_port
+                 . $this->_path . 'admin/file/?file=solrconfig.xml';
++            $response= $this->_sendRawGet($solrconfigXmlUrl);
+
+-            $solrconfigXml = simplexml_load_file($solrconfigXmlUrl);
++            $solrconfigXml = simplexml_load_string($response->getRawResponse());
+             if ($solrconfigXml === false) {
+                 throw new \InvalidArgumentException('No valid xml response from schema file: ' . $solrconfigXmlUrl);
+             }",Is this supposed to be part of this PR?,Code standards: Please keep the space after operators.
+3127,"@@ -17,6 +17,13 @@ const getHasListItem = (hasListItem, tagName, isListItemRole) => {
+ 	return hasListItem || (tagName === 'LI' && isListItemRole) || isListItemRole;
+ };
+
++const getIsHidden = actualNode => {
++	return (
++		window.getComputedStyle(actualNode, null).getPropertyValue('display') ===
++		'none'
++	);
++};
++
+ let base = {
+ 	badNodes: [],
+ 	isEmpty: true,","DRY, worth extracting this method to axe.utils",I think this could be done outside of the base `let` as it's only used once.
+3128,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher,Shouldn't this be `applicationName` to be consistent with `applicationType` and `applicationVersion`?
+3129,"@@ -142,9 +142,14 @@ class KeyConfigParser(QObject):
+     def save(self):
+         """"""Save the key config file.""""""
+         log.destroy.debug(""Saving key config to {}"".format(self._configfile))
+-        with qtutils.savefile_open(self._configfile, encoding='utf-8') as f:
+-            data = str(self)
+-            f.write(data)
++
++        try:
++            with qtutils.savefile_open(self._configfile,
++                                       encoding='utf-8') as f:
++                data = str(self)
++                f.write(data)
++        except OSError as e:
++            message.error(""Could not save key config: {}"".format(e))
+
+     @cmdutils.register(instance='key-config', maxsplit=1, no_cmd_split=True,
+                        no_replace_variables=True)","`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here.",Is there a better way to catch this error?
+3130,"@@ -228,7 +228,6 @@ func (t *Transport) startSubscriber(ctx context.Context, sub subscriptionWithTop
+ 	}
+ 	// Ok, ready to start pulling.
+ 	err := conn.Receive(ctx, func(ctx context.Context, m *pubsub.Message) {
+-		logger.Info(""got an event!"")
+ 		msg := &Message{
+ 			Attributes: m.Attributes,
+ 			Data:       m.Data,","Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line.",what's the thinking behind removing this?
+3131,"@@ -185,6 +185,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Please.DownloadLocation = ""https://get.please.build""
+ 	config.Please.NumOldVersions = 10
+ 	config.Parse.BuiltinPleasings = true
++	config.Parse.BuildFileName = []string{""BUILD""}
+ 	config.Build.Arch = cli.NewArch(runtime.GOOS, runtime.GOARCH)
+ 	config.Build.Lang = ""en_GB.UTF-8"" // Not the language of the UI, the language passed to rules.
+ 	config.Build.Nonce = ""1402""       // Arbitrary nonce to invalidate config when needed.",Don't think this should be here. The default is set somewhere else.,Is this a temporary change for some reason or just for debugging?
+3132,"@@ -1229,7 +1229,13 @@ class CloudTaurusTest(BaseCloudTest):
+     def stop_test(self):
+         if self.master:
+             self.log.info(""Ending cloud test..."")
+-            self.master.stop()
++            if not self._last_status:
++                self.get_master_status()
++
++            if self._last_status[""progress""] >= 100:
++                self.master.stop()
++            else:
++                self.master.terminate()
+
+     def get_test_status_text(self):
+         if not self._sessions:","Not really important in this PR, but does BlazeMeter describe ""progress"" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client.",Do we really want to terminate after 100ms? Shouldn't we only do this once?
+3133,"@@ -124,6 +124,14 @@ public interface ContentFile<F> {
+    */
+   List<Integer> equalityFieldIds();
+
++  /**
++   * Returns the sort order id of this file, which describes how the file is ordered.
++   * This information will be useful for merging data and equality delete files more efficiently
++   * when they share the same sort order id.
++   */
++  default Integer sortOrderId() {
++    return null;
++  }
+
+   /**
+    * Copies this file. Manifest readers can reuse file instances; use",nit: `<p>` after the line,Does it make sense to have a default method that returns an empty Integer i
+3134,"@@ -228,6 +228,7 @@ setup(
+ 		(""libArm64/%s""%version, glob(""libArm64/*.dll"") + glob(""libArm64/*.exe"")),
+ 		(""waves"", glob(""waves/*.wav"")),
+ 		(""images"", glob(""images/*.ico"")),
++		(""fonts"", glob(""fonts/*.ttf"")),
+ 		(""louis/tables"",glob(""louis/tables/*"")),
+ 		(""COMRegistrationFixes"", glob(""COMRegistrationFixes/*.reg"")),
+ 		(""."", glob(""../miscDeps/python/*.dll"")),","Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup",What's the reason for this wildcard and the next one?
+3135,"@@ -33,9 +33,6 @@ func (uq *uniQueue) enque(blk *peerBlock) {
+ }
+
+ func (uq *uniQueue) dequeAll() []*peerBlock {
+-	if len(uq.blocks) == 0 {
+-		return nil
+-	}
+ 	blks := uq.blocks
+ 	uq.blocks = []*peerBlock{}
+ 	uq.hashes = map[hash.Hash256]bool{}",i think it's OK to leave this?,why remove this?
+3136,"@@ -30,7 +30,7 @@ import org.apache.flink.table.types.logical.SymbolType;
+ import org.apache.flink.table.types.logical.YearMonthIntervalType;
+ import org.apache.flink.table.types.logical.ZonedTimestampType;
+
+-abstract class FlinkTypeVisitor<T> implements LogicalTypeVisitor<T> {
++public abstract class FlinkTypeVisitor<T> implements LogicalTypeVisitor<T> {
+
+   // ------------------------- Unsupported types ------------------------------
+ ","Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed.",Why not just make this `public`?
+3137,"@@ -3,11 +3,11 @@ WELCOME_DIALOG_TEXT = (
+ 	""down the NVDA key while pressing other keys. By default, the numpad Insert and main Insert keys ""
+ 	""may both be used as the NVDA key. You can also configure NVDA to use the Caps Lock as the NVDA ""
+ 	""key. Press NVDA plus n at any time to activate the NVDA menu. From this menu, you can configure ""
+-	""NVDA, get help and access other NVDA functions.\n""
+-	""Options  grouping\n""
++	""NVDA, get help and access other NVDA functions.  \n""
++	""Options  grouping  \n""
+ 	""Keyboard layout:  combo box  desktop  collapsed  Alt plus k""
+ )
+ QUIT_DIALOG_TEXT = (
+-	""Exit NVDA  dialog\n""
++	""Exit NVDA  dialog  \n""
+ 	""What would you like to do?  combo box  Exit  collapsed  Alt plus d""
+ )",No line at end of file warning,(minor) I'm not sure the newline
+3138,"@@ -24,6 +24,8 @@ namespace Nethermind.Blockchain.Processing
+ {
+     public class OneTimeChainProcessor : IBlockchainProcessor
+     {
++        public CompositeBlockTracerFactory BlockTracerFactory { get; } = new();
++
+         private readonly IBlockchainProcessor _processor;
+         private readonly IReadOnlyDbProvider _readOnlyDbProvider;
+ ","This looks unused, shouldn't it point to inner processor in any way?",why do we need this?
+3139,"@@ -6995,11 +6995,6 @@ NABoolean RelRoot::isUpdatableBasic(NABoolean isView,
+   // QSTUFF
+
+     {
+-      // if child is a FirstN node, skip it.
+-      if ((child(0)->castToRelExpr()->getOperatorType() == REL_FIRST_N) &&
+-	  (child(0)->child(0)))
+-	scan = (Scan *)child(0)->child(0)->castToRelExpr();
+-      else
+ 	scan = (Scan *)child(0)->castToRelExpr();
+     }
+ ","There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary.",The first n node is not a first
+3140,"@@ -213,4 +213,14 @@ public class GoSurfaceNamer extends SurfaceNamer {
+   public String getCreateStubFunctionName(Interface service) {
+     return getGrpcClientTypeName(service).replace(""."", "".New"");
+   }
++
++  @Override
++  public String getStaticLangStreamingReturnTypeName(Method method, MethodConfig methodConfig) {
++    // Unsafe string manipulation: The name looks like ""LibraryService_StreamShelvesClient"",
++    // neither camel or underscore.
++    return String.format(
++        ""%s_%sClient"",
++        converter.getTypeName(method.getParent()).getNickname(),
++        method.getSimpleName());
++  }
+ }","I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?","How about ""LibraryService_StreamShelvesClient_"" or ""LibraryService_StreamShelvesClient_"" ?"
+3141,"@@ -63,6 +63,8 @@ storiesOf( 'PageSpeed Insights Module/Components', module )
+ 				<DashboardPageSpeedWidget { ...widgetComponentProps } />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} )
+ 	.add( 'Dashboard widget (loading)', () => {
+ 		freezeFetch( /^\/google-site-kit\/v1\/modules\/pagespeed-insights\/data\/pagespeed/ );",All stories in this file also need the default padding.,Is there a reason for adding this?
+3142,"@@ -26,13 +26,14 @@ using Microsoft.AspNetCore.TestHost;
+ using Microsoft.Extensions.DependencyInjection;
+ using Microsoft.Extensions.Hosting;
+ using OpenTelemetry.Metrics;
++using OpenTelemetry.Tests;
+ using Xunit;
+
+ namespace OpenTelemetry.Exporter.Prometheus.Tests
+ {
+     public sealed class PrometheusExporterMiddlewareTests
+     {
+-        private const string MeterName = ""PrometheusExporterMiddlewareTests.Meter"";
++        private static readonly string MeterName = Utils.GetCurrentMethodName();
+
+         [Fact]
+         public async Task PrometheusExporterMiddlewareIntegration()",Curious - what would be the actual value?  ,@stephentoub why is this being changed?
+3143,"@@ -168,7 +168,8 @@ def main():
+         # checkpoints as meta data
+         cfg.checkpoint_config.meta = dict(
+             mmdet_version=__version__ + get_git_hash()[:7],
+-            CLASSES=datasets[0].CLASSES)
++            CLASSES=datasets[0].CLASSES,
++            PALETTE=datasets[0].PALETTE)
+     # add an attribute for visualization convenience
+     model.CLASSES = datasets[0].CLASSES
+     train_detector(",Is it necessary to record the palette in the checkpoint? Any reason?,can you add a trailing comma to make diffs easier to read?
+3144,"@@ -3,9 +3,10 @@ import listenbrainz.webserver
+ import pika
+ import time
+ import threading
++import socketio
+
+ from flask import current_app
+-
++from listenbrainz.webserver.views.api_tools import LISTEN_TYPE_PLAYING_NOW, LISTEN_TYPE_IMPORT
+
+ class FollowDispatcher(threading.Thread):
+ ",Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?,nit: can we call this `SMTPClient`?
+3145,"@@ -167,6 +167,13 @@ describe Ncr::WorkOrder do
+       user = create(:user, client_slug: 'ncr')
+       expect(wo.slug_matches?(user)).to eq(true)
+     end
++
++    it ""identifies eligible observers"" do
++      wo = create(:ba80_ncr_work_order)
++      user = create(:user, client_slug: 'ncr')
++      expect(wo.proposal.eligible_observers.to_a).to include(user)
++      expect(wo.proposal.eligible_observers.to_a).to_not include(wo.observers)
++    end
+   end
+
+   describe '#organization' do",should we have a similar test for gsa18f procurements?,Prefer double-quoted strings unless
+3146,"@@ -113,9 +113,9 @@ func TestProtocol_HandleTransfer(t *testing.T) {
+ 			GasLimit:    testutil.TestGasLimit,
+ 		})
+
+-		sender, err := accountutil.AccountState(sm, v.caller.String())
++		sender, err := accountutil.AccountState(sm, v.caller)
+ 		require.NoError(err)
+-		recipient, err := accountutil.AccountState(sm, v.recipient)
++		recipient, err := accountutil.AccountStateByHash160(sm, v.recipient)
+ 		require.NoError(err)
+ 		gasFee := new(big.Int).Mul(v.gasPrice, new(big.Int).SetUint64(gas))
+ ","change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`",Does it make sense to use `AccountS
+3147,"@@ -0,0 +1,6 @@
++class NcrDispatcher < LinearDispatcher
++
++  def requires_approval_notice? approval
++    approval.cart_approvals.approvable.order('position ASC').last == approval
++  end
++end",Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher.,I know you didn't write it but woul
+3148,"@@ -26,6 +26,12 @@ namespace Nethermind.JsonRpc
+         [ConfigItem(Description = ""Host for JSON RPC calls. Ensure the firewall is configured when enabling JSON RPC. If it does not work with 117.0.0.1 try something like 10.0.0.4 or 192.168.0.1"", DefaultValue = ""\""127.0.0.1\"""")]
+         string Host { get; set; }
+
++        [ConfigItem(Description = ""Defines whether the JSON RPC tracers will have timeout enabled. Default timeout is 5 seconds per tracer usage."", DefaultValue = ""false"")]
++        bool TracerTimeoutEnabled { get; set; }
++
++        [ConfigItem(Description = ""JSON RPC tracers' timeout value given in seconds."", DefaultValue = ""5"")]
++        int TracerTimeout { get; set; }
++
+         [ConfigItem(Description = ""Base file path for diagnostic JSON RPC recorder."", DefaultValue = ""\""logs/rpc.log_1.txt\"""")]
+         string RpcRecorderBaseFilePath { get; set; }
+ ","remove this and always enable tracer, just set the default timeout to something higher (20 seconds)",What is the default timeout for JSON RPCs? Would it make sense to make it the same as the `RpcTimeout` property?
+3149,"@@ -39,6 +39,7 @@ public class ScriptDTO {
+     private final Boolean free;
+     private final Boolean requiresPatch;
+     private final String script;
++    private final URI icon;
+
+     private ScriptDTO(Builder builder) {
+         this.scriptName = builder.scriptName;",Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object.,please add a `@Nullable` getter that can be null if `icon` is empty
+3150,"@@ -333,6 +333,13 @@ var opts struct {
+ 				Targets []core.BuildLabel `positional-arg-name:""targets"" description:""Targets to query"" required:""true""`
+ 			} `positional-args:""true""`
+ 		} `command:""roots"" description:""Show build labels with no dependents in the given list, from the list.""`
++		Filter struct {
++			IncludeLabels    []string `long:""in"" description:""Include any targets with matching labels""`
++			ExcludeLabels    []string `long:""ex"" description:""Exclude any targets with matching labels""`
++			Args struct {
++				Targets []core.BuildLabel `positional-arg-name:""targets"" description:""Targets to filter""`
++			} `positional-args:""true""`
++		} `command:""filter"" description:""Filter the given set of targets according to some rules""`
+ 	} `command:""query"" description:""Queries information about the build graph""`
+ }
+ ",can't these just use the global `include` and `exclude` flags?,"Why is this optional? If you want to have it optional, you can omit it."
+3151,"@@ -28,7 +28,7 @@ def bbox2delta(proposals, gt, means=[0, 0, 0, 0], stds=[1, 1, 1, 1]):
+     stds = deltas.new_tensor(stds).unsqueeze(0)
+     deltas = deltas.sub_(means).div_(stds)
+
+-    return deltas
++    return deltas.cuda()
+
+
+ def delta2bbox(rois,",Is this still necessary?,Seems like `deltas` can be a tensor.
+3152,"@@ -52,7 +52,7 @@ namespace Examples.Console
+                 .AddPrometheusExporter(opt =>
+                 {
+                     opt.StartHttpListener = true;
+-                    opt.HttpListenerPrefixes = new string[] { $""http://*:{port}/"" };
++                    opt.HttpListenerPrefixes = new string[] { $""http://localhost:{port}/"" };
+                 })
+                 .Build();
+ ",Interesting! Happen to catch an exception message or anything I can look into?,I think this should be `http://{port}/`
+3153,"@@ -103,15 +103,10 @@ Promise.prototype.error = function (err) {
+  * @api public
+  */
+
+-Promise.prototype.resolve = function (err, val) {
+-  if (err) return this.error(err);
+-  return this.fulfill(val);
+-}
+-
+ /**
+  * Adds a single function as a listener to both err and complete.
+  *
+- * It will be executed with traditional node.js argument position when the promise is resolved.
++ * It will be executed with traditional node.js argument position when the promise is resolved.
+  *
+  *     promise.addBack(function (err, args...) {
+  *       if (err) return handleError(err);",did this get moved to mpromise? I don't recall if it's in that lib or not.,Is this API public?
+3154,"@@ -81,14 +81,16 @@ type ProviderModeConfig struct {
+ type ConsumerConfig struct {
+ 	PublicKey string `json:""PublicKey""`
+ 	// IP is needed when provider is behind NAT. In such case provider parses this IP and tries to ping consumer.
+-	IP string `json:""IP,omitempty""`
++	IP    string `json:""IP,omitempty""`
++	Ports []int  `json:""Ports""`
+ }
+
+ // ServiceConfig represent a Wireguard service provider configuration that will be passed to the consumer for establishing a connection.
+ type ServiceConfig struct {
+ 	// LocalPort and RemotePort are needed for NAT hole punching only.
+-	LocalPort  int `json:""-""`
+-	RemotePort int `json:""-""`
++	LocalPort  int   `json:""-""`
++	RemotePort int   `json:""-""`
++	Ports      []int `json:""ports""`
+
+ 	Provider struct {
+ 		PublicKey string",json objects should be `camelCase`,What is the purpose of this change?
+3155,"@@ -0,0 +1,11 @@
++package types
++
++// SectorSize is the amount of bytes in a sector. This amount will be slightly
++// greater than the number of user bytes which can be written to a sector due to
++// bit-padding.
++type SectorSize uint64
++
++const (
++	OneKiBSectorSize = SectorSize(iota)
++	TwoHundredFiftySixMiBSectorSize
++)",QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose.,Can we move this to `pkg/util/sector.go
+3156,"@@ -23,10 +23,11 @@ using System.Linq;
+ using Microsoft.Extensions.Logging;
+ using OpenTelemetry.Exporter;
+ using OpenTelemetry.Logs;
++using OpenTelemetry.Tests;
+ using OpenTelemetry.Trace;
+ using Xunit;
+
+-namespace OpenTelemetry.Tests.Logs
++namespace OpenTelemetry.Logs.Tests
+ {
+     public sealed class LogRecordTest : IDisposable
+     {",Maybe with this change we can remove `using OpenTelemetry.Logs`.,Why did you change these namespaces?
+3157,"@@ -164,9 +164,10 @@ func (h *Handler) handleAddProject(w http.ResponseWriter, r *http.Request) {
+ 	}
+
+ 	var (
+-		id            = r.FormValue(""ID"")
+-		description   = r.FormValue(""Description"")
+-		sharedSSOName = r.FormValue(""SharedSSO"")
++		id                  = r.FormValue(""ID"")
++		description         = r.FormValue(""Description"")
++		sharedSSOName       = r.FormValue(""SharedSSO"")
++		viewerRoleAsDefault = r.FormValue(""ViewerRoleAsDefault"") == ""on""
+ 	)
+ 	if id == """" {
+ 		http.Error(w, ""invalid id"", http.StatusBadRequest)",Fix this name too.,"Could we have a constant for ""on"" an"
+3158,"@@ -2018,7 +2018,7 @@ class BibFormatObject(object):
+             # If record is given as parameter
+             self.xml_record = xml_record
+             self.record = create_record(xml_record)[0]
+-            recID = record_get_field_value(self.record, ""001"") or None
++            recID = int(record_get_field_value(self.record, ""001"")) or None
+
+         try:
+             assert isinstance(recID, (int, long, type(None))), 'Argument of wrong type!'",why this is an issue?,`or None` -> `or None`
+3159,"@@ -110,9 +110,13 @@ abstract class Type
+         ?string $namespace,
+         array $aliased_classes,
+         ?string $this_class,
+-        bool $allow_self = false
++        bool $allow_self = false,
++        bool $was_static = false
+     ) : string {
+         if ($allow_self && $value === $this_class) {
++            if ($was_static) {
++                return '$this';
++            }
+             return 'self';
+         }
+ ",The condition should be inverse?,`$was_static` is always `true` so no
+3160,"@@ -33,12 +33,16 @@ package azkaban;
+ public class Constants {
+
+   // Azkaban Flow Versions
+-  public static final String AZKABAN_FLOW_VERSION_2_0 = ""2.0"";
++  public static final String AZKABAN_FLOW_VERSION = ""Azkaban-Flow-Version"";
++  public static final Double VERSION_2_0 = 2.0;
+
+   // Flow 2.0 file suffix
+   public static final String PROJECT_FILE_SUFFIX = "".project"";
+   public static final String FLOW_FILE_SUFFIX = "".flow"";
+
++  // Flow 2.0 node type
++  public static final String NODE_TYPE_FLOW = ""flow"";
++
+   // Names and paths of various file names to configure Azkaban
+   public static final String AZKABAN_PROPERTIES_FILE = ""azkaban.properties"";
+   public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";","this seems to be a property key name, so should it be a inside configurationkey.java?",Flow 2.0 version?
+3161,"@@ -105,7 +105,7 @@ func (v *VolumeDestroy) Execute() ([]byte, error) {
+ 		return nil, err
+ 	}
+ 	// execute command here
+-	return exec.Command(bin.ZFS, v.Command).CombinedOutput()
++	return exec.Command(bin.BASH, ""-c"", v.Command).CombinedOutput()
+ }
+
+ // Build returns the VolumeDestroy object generated by builder",G204: Subprocess launching should be audited (from `gosec`),You need to add t
+3162,"@@ -284,6 +284,10 @@ class Task(object):
+         # TODO(erikbern): we should think about a language-agnostic mechanism
+         return self.__class__.__module__
+
++    @property
++    def run_on_main_process(self):
++        return False
++
+     _visible_in_registry = True  # TODO: Consider using in luigi.util as well
+
+     __not_user_specified = '__not_user_specified'","Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run.",Do we need this d
+3163,"@@ -57,3 +57,18 @@ export function isValidDimensions( dimensions ) {
+ 		return dimension.hasOwnProperty( 'name' ) && typeof dimension.name === 'string';
+ 	} );
+ }
++
++/**
++ * Verifies provided dimensionFilters to make sure they match allowed values found in dimensions.
++ *
++ * @since n.e.x.t
++ *
++ * @param {Object} dimensionFilters The dimension filters to check.
++ * @return {boolean} TRUE if dimension filters are valid, otherwise FALSE.
++ */
++export function isValidDimensionFilters( dimensionFilters ) {
++	// Ensure every dimensionFilter key corresponds to a valid dimension.
++	return Object.keys( dimensionFilters ).every(
++		( dimension ) => typeof dimensionFilters[ dimension ] === 'string'
++	);
++}",We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values.,Since this is onl
+3164,"@@ -31,7 +31,8 @@ import (
+ )
+
+ var (
+-	_ yarpc.Router = (*MapRouter)(nil)
++	_ yarpc.Router                = (*MapRouter)(nil)
++	_ yarpc.UnaryTransportHandler = &unaryTransportHandler{}
+ )
+
+ type serviceProcedure struct {","let's do a pointer cast of nil, similar to the `MapRouter` above",Is there a reason for this change?
+3165,"@@ -280,6 +280,8 @@ abstract class Abstract_Builder implements Builder {
+ 					'default'           => '{ ""mobile"": ""0"", ""tablet"": ""0"", ""desktop"": ""0"" }',
+ 				]
+ 			);
++
++			do_action( 'neve_add_settings_to_hfg_rows', SettingsManager::get_instance(), $row_setting_id, $row_id );
+ 		}
+
+ 		SettingsManager::get_instance()->add(","action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern.",You need to add this to the `add_s
+3166,"@@ -158,6 +158,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Https.Internal
+                 if ((_options.HttpProtocols & HttpProtocols.Http2) != 0)
+                 {
+                     sslOptions.ApplicationProtocols.Add(SslApplicationProtocol.Http2);
++                    // https://tools.ietf.org/html/rfc7540#section-9.2.1
++                    sslOptions.AllowRenegotiation = false;
+                 }
+
+                 if ((_options.HttpProtocols & HttpProtocols.Http1) != 0)",I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?,Was this a bug?
+3167,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?,Shouldn't this be `all`?
+3168,"@@ -25,9 +25,8 @@ import (
+ )
+
+ func ExampleOpenCollection() {
+-	// This example is used in https://gocloud.dev/howto/docstore#dynamodb-ctor.
+-
+-	// import _ ""gocloud.dev/docstore/awsdynamodb""
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/docstore/awsdynamodb""
+
+ 	sess, err := session.NewSession()
+ 	if err != nil {",I don't think you need the blank import here. This one uses awsdynamodb directly.,"If you can add `gocloud.dev/docstore/awsdynamodb`, then this PR should be ready."
+3169,"@@ -121,11 +121,11 @@ public abstract class DeleteFilter<T> {
+     return applyEqDeletes(applyPosDeletes(records));
+   }
+
+-  private List<Predicate<T>> applyEqDeletes() {
+-    List<Predicate<T>> isInDeleteSets = Lists.newArrayList();
++  private Predicate<T> buildEqDeletePredicate() {
+     if (eqDeletes.isEmpty()) {
+-      return isInDeleteSets;
++      return null;
+     }
++    Predicate<T> isDeleted = t -> false;
+
+     Multimap<Set<Integer>, DeleteFile> filesByDeleteIds = Multimaps.newMultimap(Maps.newHashMap(), Lists::newArrayList);
+     for (DeleteFile delete : eqDeletes) {","I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`.",is there a reason for not using a `Predicate<Boolean>`?
+3170,"@@ -246,6 +246,15 @@ def __build_clangsa_config_handler(args, context):
+     config_handler.compiler_sysroot = context.compiler_sysroot
+     config_handler.system_includes = context.extra_system_includes
+     config_handler.includes = context.extra_includes
++
++    if 'ctu_phases' in args:
++        config_handler.ctu_dir = os.path.join(args.output_path,
++                                              args.ctu_dir)
++        config_handler.ctu_in_memory = args.ctu_in_memory
++        config_handler.log_file = args.logfile
++        config_handler.path_env_extra = context.path_env_extra
++        config_handler.ld_lib_path_extra = context.ld_lib_path_extra
++
+     try:
+         with open(args.clangsa_args_cfg_file, 'rb') as sa_cfg:
+             config_handler.analyzer_extra_arguments = \",What is this and the next entry in config_handler used for?,"`ctu_phases` is not in `args`, only `ctu_dir` is. Is this right?"
+3171,"@@ -244,3 +244,9 @@ func NewWithDefault(keyFilePath string, certFilePath string) (m upstreamca.Upstr
+
+ 	return m, err
+ }
++
++func NewEmpty () (m upstreamca.UpstreamCa) {
++	return &memoryPlugin{
++		mtx:&sync.RWMutex{},
++	}
++}","will your editor integrate `gofmt`, `goimports`, etc...?",This looks unrelated to the rest of the PR. Can you remove it?
+3172,"@@ -78,7 +78,12 @@ public class ProductPhotosFragment extends BaseFragment implements ImagesAdapter
+     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
+         super.onViewCreated(view, savedInstanceState);
+         Intent intent = getActivity().getIntent();
+-        final State state = (State) intent.getExtras().getSerializable(""state"");
++        State state;
++        if(intent!=null && intent.getExtras()!=null && intent.getExtras().getSerializable(""state"")!=null){
++            state = (State) intent.getExtras().getSerializable(""state"");
++        }else{
++            state = ProductFragment.mState;
++        }
+         product = state.getProduct();
+         mFragment = this;
+         // initialize the arraylist",looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting.,"This could be replaced with `return intent != null && intent.getExtras().getSerializable(""state"")`"
+3173,"@@ -218,6 +218,15 @@ def __add_filtering_arguments(parser, defaults=None, diff_mode=False):
+                          default=init_default('severity'),
+                          help=""Filter results by severities."")
+
++    f_group.add_argument('--bug-path-length',
++                         type=str,
++                         dest='bug_path_length',
++                         default=argparse.SUPPRESS,
++                         help=""Filter results by bug path length. This has ""
++                              ""the following format: <minimum_bug_path_length>""
++                              "":<maximum_bug_path_length>. Valid values are: ""
++                              ""\""4:10\"", \""4:\"", \"":10\"""")
++
+     f_group.add_argument('--tag',
+                          nargs='*',
+                          dest=""tag"",","Please add some valid examples to help message like `""4:10""`, `""4:""`, `"":10""`",Shouldn't this be `<minimum_bug_path_length>`?
+3174,"@@ -490,7 +490,10 @@ EOS
+         #   end
+         def its(attribute, &block)
+           RSpec.deprecate(""Use of rspec-core's `its` method"", :replacement => 'the rspec-its gem')
+-          describe(attribute) do
++          description = attribute
++          description = description.to_s if Symbol === description
++
++          describe(description) do
+             if Array === attribute
+               let(:__its_subject) { subject[*attribute] }
+             else",Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?,I think this is still not working. `describe` calls `.to_s` on the `Symbol` but not the `String`
+3175,"@@ -15,9 +15,6 @@ import (
+ 	""github.com/stretchr/testify/require""
+ )
+
+-// BlockTimeTest is the block time used by workers during testing
+-const BlockTimeTest = time.Second
+-
+ // MineDelayTest is the mining delay used by schedulers during testing
+ const MineDelayTest = time.Millisecond * 500
+ ",Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it.,Do we still need this?
+3176,"@@ -12,7 +12,7 @@ class Practice
+   end
+
+   def incomplete_trails
+-    trails.select(&:incomplete?)
++    trails.select(&:incomplete?).partition(&:in_progress?).flatten
+   end
+
+   private",What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?,is the `incomplete?` any different than the `in_progress?`?
+3177,"@@ -205,7 +205,6 @@ const (
+ 	FlagTLSKeyPath                        = ""tls_key_path""
+ 	FlagTLSCaPath                         = ""tls_ca_path""
+ 	FlagTLSEnableHostVerification         = ""tls_enable_host_verification""
+-	FlagGRPC                              = ""grpc""
+ )
+
+ var flagsForExecution = []cli.Flag{",Flag is removed because it is only gRPC now.,"I think we should keep `grpc` as a global option, defaultin"
+3178,"@@ -38,6 +38,17 @@ class Role(base.Base):
+     .. option:: molecule init role --role-name foo
+
+         Initialize a new role.
++
++    .. program:: molecule init role --role-name foo --template path
++
++    .. option:: molecule init role --role-name foo --template path
++
++        Initialize a new role using a local *cookiecutter* template. This
++        allows the customization of a role while still using the default
++        generated ``molecule`` folder. This is similar to an
++        ``ansible-galaxy init`` skeleton. Please refer to the ``init scenario``
++        command in order to customise the default generated ``molecule``
++        folder.
+     """"""
+
+     def __init__(self, command_args):","Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?",This should be on a new line.
+3179,"@@ -640,9 +640,17 @@ class StdlibChecker(DeprecatedMixin, BaseChecker):
+                     encoding_arg = utils.get_argument_from_call(
+                         node, position=0, keyword=""encoding""
+                     )
++                elif open_module == ""pathlib"" and node.func.attrname == ""write_text"":
++                    encoding_arg = utils.get_argument_from_call(
++                        node, position=1, keyword=""encoding""
++                    )
++                elif open_module == ""pathlib"":
++                    encoding_arg = utils.get_argument_from_call(
++                        node, position=2, keyword=""encoding""
++                    )
+                 else:
+                     encoding_arg = utils.get_argument_from_call(
+-                        node, position=None, keyword=""encoding""
++                        node, position=3, keyword=""encoding""
+                     )
+             except utils.NoSuchArgumentError:
+                 self.add_message(""unspecified-encoding"", node=node)",Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean  ,"What's the difference between `node.func.attrname == ""write"
+3180,"@@ -9,6 +9,7 @@ import (
+ 	""errors""
+ 	""sync""
+
++	""github.com/ethersphere/bee/pkg/recovery""
+ 	""github.com/ethersphere/bee/pkg/storage""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ 	""github.com/ethersphere/bee/pkg/tags""",why depend on recovery???,Remove empty line.
+3181,"@@ -388,7 +388,7 @@ func initializeDynamicConfig(
+
+ 	// the done channel is used by dynamic config to stop refreshing
+ 	// and CLI does not need that, so just close the done channel
+-	doneChan := make(chan struct{})
++	doneChan := make(chan interface{})
+ 	close(doneChan)
+ 	dynamicConfigClient, err := dynamicconfig.NewFileBasedClient(
+ 		&serviceConfig.DynamicConfigClient,","the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`",What's the reason
+3182,"@@ -196,7 +196,7 @@ func NewGasPriceOracle(cfg *Config) (*GasPriceOracle, error) {
+ 	address := cfg.gasPriceOracleAddress
+ 	contract, err := bindings.NewGasPriceOracle(address, l2Client)
+ 	if err != nil {
+-		return nil, err
++		return nil, wrapErr(err, ""error creating contract binding"")
+ 	}
+
+ 	// Fetch the current gas price to use as the current price",Do you mean to have gas_oracle changes in this PR?,Why not just using
+3183,"@@ -1,6 +1,5 @@
+-<%= render Blacklight::System::ModalComponent.new do |component| %>
+-  <% component.title { t('blacklight.email.form.title') } %>
+-
+-  <%= render partial: '/shared/flash_msg' %>
+-  <span data-blacklight-modal=""close""></span>
+-<% end %>
++<turbo-stream action=""append"" target=""main-flashes"">
++  <template>
++    <%= render '/shared/flash_msg' %>
++  </template>
++</turbo-stream>",Is this effectively requiring browsers support javascript?,The alternative is
+3184,"@@ -61,10 +61,11 @@ public class FingerprintAuthDialogFragment extends DialogFragment {
+     @Override
+     public void onCreate(Bundle savedInstanceState) {
+         super.onCreate(savedInstanceState);
++        Boolean isDarkTheme = SalesforceSDKManager.getInstance().isDarkTheme(getActivity());
+
+         // Do not create a new Fragment when the Activity is re-created such as orientation changes.
+         setRetainInstance(true);
+-        setStyle(DialogFragment.STYLE_NORMAL, android.R.style.Theme_Material_Light_Dialog);
++        setStyle(DialogFragment.STYLE_NORMAL, (isDarkTheme ? R.style.SalesforceSDK_Dialog_Dark : R.style.SalesforceSDK_Dialog));
+     }
+
+     @Override",Lowercase `boolean` - use the primitive type.,I don't think you need to introduce the `isDarkTheme` variable here since you are already using the `isDarkTheme` variable in the onCreate method
+3185,"@@ -174,7 +174,12 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+                 }
+                 else
+                 {
+-                    Log.LogError($""Item '{item}' already exists in {relativeBlobPath}."");
++                    bool blobExists = await feed.CheckIfBlobExists(relativeBlobPath);
++
++                    if (blobExists)
++                    {
++                        Log.LogError($""Item '{item}' already exists in {relativeBlobPath}."");
++                    }
+                 }
+             }
+             catch (Exception exc)",This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true.,Doesn't the fact that we're doing an async method call here mean that the return value will always be true?
+3186,"@@ -480,12 +480,15 @@ static void read_surface_net_wm_state(struct wlr_xwm *xwm,
+ 	xsurface->fullscreen = 0;
+ 	xcb_atom_t *atom = xcb_get_property_value(reply);
+ 	for (uint32_t i = 0; i < reply->value_len; i++) {
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_FULLSCREEN])
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_FULLSCREEN]) {
+ 			xsurface->fullscreen = true;
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT])
++		}
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT]) {
+ 			xsurface->maximized_vert = true;
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ])
++		}
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ]) {
+ 			xsurface->maximized_horz = true;
++		}
+ 	}
+ }
+ ",Can you replace these by `else if` please?,"Minor, but for me this looks like it would be more readable if `atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ]`"
+3187,"@@ -0,0 +1,12 @@
++/**
++ * Changes the currently selected date range.
++ *
++ * Currently only identifiable by the option values.
++ *
++ * @param {string} fromRange The currently selected date range.
++ * @param {string} toRange The new date range to select.
++ */
++export async function switchDateRange( fromRange, toRange ) {
++	await expect( page ).toClick( '.mdc-select__selected-text', { text: new RegExp( fromRange, 'i' ) } );
++	await expect( page ).toClick( '.mdc-menu-surface--open .mdc-list-item', { text: new RegExp( toRange, 'i' ) } );
++}","Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange`   But doesn't seem to be a common thing in the code base.","I'm not sure if this is the best way to do it, so I'm open to suggestions."
+3188,"@@ -30,7 +30,10 @@ var tableGrid = tableUtils.toGrid(node);
+
+ // Look for all the bad headers
+ var out = headers.reduce(function (res, header) {
+-	if (header.id && reffedHeaders.indexOf(header.id) !== -1) {
++	if (
++		header.getAttribute('id') &&
++		reffedHeaders.includes(header.getAttribute('id'))
++	) {
+ 		return (!res ? res : true);
+ 	}
+ ",Does this code fit on one line under 80 characters? It would be more consistent with our existing style.,`reffedHeaders` is not an array
+3189,"@@ -61,8 +61,13 @@ func ParseArtifactListFromMultipleYamls(multipleYamls MultiYamlFetcher) (artifac
+ // installed
+ func RegisteredArtifactsFor070() (list ArtifactList) {
+
++	//Note: CRDs have to be installed first. Keep this at top of the list.
++	list.Items = append(list.Items, OpenEBSCRDArtifactsFor070().Items...)
++
+ 	list.Items = append(list.Items, JivaVolumeArtifactsFor070().Items...)
+ 	//Contains the read/list/delete CAST for supporting older volumes
++	//The CAST defined here are provided as fallback options to corresponding
++	//0.7.0 CAST
+ 	list.Items = append(list.Items, JivaVolumeArtifactsFor060().Items...)
+ 	list.Items = append(list.Items, JivaPoolArtifactsFor070().Items...)
+ ",Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`.,why not add all of these since
+3190,"@@ -0,0 +1,9 @@
++// +build pico
++
++package main
++
++import ""machine""
++
++var (
++	interruptPin = machine.GP10
++)",Why do you configure the UART like this? It's already configured by default.,Can we rename this to `probeInt
+3191,"@@ -39,7 +39,8 @@
+ #include ""opae/access.h""
+ #include ""opae/utils.h""
+ #include ""opae/manage.h""
+-#include ""opae/manage.h""
++#include ""opae/enum.h""
++#include ""opae/properties.h""
+ #include ""bitstream_int.h""
+ #include ""common_int.h""
+ #include ""intel-fpga.h""","Wow. Good catch. ""This `#include` was brought to you by the department of redundancy department."" ;)",do you need to keep the `opae/m
+3192,"@@ -20,10 +20,11 @@ import (
+ 	""context""
+ 	""time""
+
++	""github.com/go-logr/logr""
+ 	""golang.org/x/crypto/acme""
+-	""k8s.io/klog""
+
+ 	""github.com/jetstack/cert-manager/pkg/acme/client""
++	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ )
+
+ const (","Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely.",This import should go at the top of the file.
+3193,"@@ -917,6 +917,7 @@ void *cuda_resize_scratch_space(std::int64_t bytes, bool force_shrink) {
+
+ void cuda_prefetch_pointer(const Cuda &space, const void *ptr, size_t bytes,
+                            bool to_device) {
++  if ((ptr == nullptr) || (bytes == 0)) return;
+   cudaPointerAttributes attr;
+   cudaPointerGetAttributes(&attr, ptr);
+   // I measured this and it turns out prefetching towards the host slows",Should this be using the `CUDA_SAFE_CALL` macro here?,The nullptr check is unnecessary here. Just d
+3194,"@@ -298,8 +298,8 @@ namespace Xunit.ConsoleClient
+                     {
+                         lock (consoleLock)
+                         {
+-                            Console.ForegroundColor = ConsoleColor.Red;
+-                            Console.WriteLine(""ERROR:       {0} has no tests to run"", Path.GetFileNameWithoutExtension(assembly.AssemblyFilename));
++                            Console.ForegroundColor = ConsoleColor.Yellow;
++                            Console.WriteLine(""Warning:       {0} has no tests to run"", Path.GetFileNameWithoutExtension(assembly.AssemblyFilename));
+                             Console.ForegroundColor = ConsoleColor.Gray;
+                         }
+                     }",What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level.,@aparajit-pratap should this be a warning?
+3195,"@@ -1139,6 +1139,10 @@ func (mset *stream) processMirrorMsgs() {
+
+ 	// Grab stream quit channel.
+ 	mset.mu.Lock()
++	if mset.mirror == nil {
++		mset.mu.Unlock()
++		return
++	}
+ 	msgs, mch, qch := mset.mirror.msgs, mset.mirror.msgs.mch, mset.qch
+ 	// Set the last seen as now so that we don't fail at the first check.
+ 	mset.mirror.last = time.Now()","and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that.","Just curious, why did you move this up?"
+3196,"@@ -258,6 +258,7 @@ static void surface_move_state(struct wlr_surface *surface,
+ 	}
+ 	if ((next->invalid & WLR_SURFACE_INVALID_OPAQUE_REGION)) {
+ 		// TODO: process buffer
++		pixman_region32_copy(&state->opaque, &next->opaque);
+ 		pixman_region32_clear(&next->opaque);
+ 	}
+ 	if ((next->invalid & WLR_SURFACE_INVALID_INPUT_REGION)) {",`next->opaque` should not be cleared.,This seems to be the only place where `state->opaque` is updated. I think `state->opaque` should be updated as well.
+3197,"@@ -525,6 +525,7 @@ func (s *Server) processClientOrLeafAuthentication(c *client, opts *Options) boo
+ 			c.Debugf(""Account JWT not signed by trusted operator"")
+ 			return false
+ 		}
++		// this only executes IF there's an issuer on the Juc - otherwise the account is already
+ 		if juc.IssuerAccount != """" && !acc.hasIssuer(juc.Issuer) {
+ 			c.Debugf(""User JWT issuer is not known"")
+ 			return false","already what? I know what, but seems like smth. is missing in this sentence","Maybe also make this a conditional on `juc.Issuer != """"`?"
+3198,"@@ -1,6 +1 @@
+-$(""div.card-for-activity"").replaceWith('<%=j render partial: 'proposals/details/activity', locals: {events: @events} %>');
+-$(""div.card-for-activity textarea:first"").focus();
+-$(""#add_a_comment"").attr('disabled', true);
+-$(""div.card-for-activity textarea:first"").on('input',function(){
+-  $(""#add_a_comment"").attr('disabled', false);
+-});
++window.c2.activityCardController.update('<%=j render partial: 'proposals/details/activity', locals: {events: @events} %>');",Can you put spaces after the `{`and before the `}`,Update this file to use `<%=window.c2.activityCardController.update;`
+3199,"@@ -21,11 +21,12 @@ import logging
+ import logging.handlers
+ import os
+
++from google.cloud.forseti import __version__
+
+ DEFAULT_LOG_FMT = ('%(asctime)s %(levelname)s '
+                    '%(name)s(%(funcName)s): %(message).1024s')
+
+-SYSLOG_LOG_FMT = ('%(levelname)s [forseti-security] '
++SYSLOG_LOG_FMT = ('%(levelname)s [forseti-security] %(__version__)s '
+                   '%(name)s(%(funcName)s): %(message).1024s')
+
+ # %(asctime)s is used as the marker by multiline parser to determine",We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`,"if we're just going to get rid of the `os.environ` import, do we still need the `__version__` import?"
+3200,"@@ -1112,7 +1112,7 @@ func (c *client) flushOutbound() bool {
+ 	}
+
+ 	// Check to see if we can reuse buffers.
+-	if len(cnb) > 0 {
++	if len(cnb) > 0 && n >= int64(len(cnb[0])) {
+ 		oldp := cnb[0][:0]
+ 		if cap(oldp) >= int(c.out.sz) {
+ 			// Replace primary or secondary if they are nil, reusing same buffer.",Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?,`n >= int64(len(cnb[0]))`
+3201,"@@ -37,6 +37,7 @@ var (
+ type QueueLoad struct {
+ 	Key       string
+ 	Operation string
++	Object interface{}
+ }
+
+ func Start() error {",can we make use of storagepoolclaim type rather than the generic interface{} type?,does this need to be expo
+3202,"@@ -652,6 +652,8 @@ func (k *Kad) Start(_ context.Context) error {
+ 	k.wg.Add(1)
+ 	go k.manage()
+
++	k.AddPeers(k.previouslyConnected()...)
++
+ 	go func() {
+ 		select {
+ 		case <-k.halt:","this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first",I assume this is a no-op
+3203,"@@ -185,7 +185,7 @@ Blockly.ScratchBlocks.ProcedureUtils.removeAllInputs_ = function() {
+  */
+ Blockly.ScratchBlocks.ProcedureUtils.createAllInputs_ = function(connectionMap) {
+   // Split the proc into components, by %n, %b, and %s (ignoring escaped).
+-  var procComponents = this.procCode_.split(/(?=[^\\]\%[nbs])/);
++  var procComponents = this.procCode_.split(/(?=[^\\]%[nbs])/);
+   procComponents = procComponents.map(function(c) {
+     return c.trim(); // Strip whitespace.
+   });",Is this actually a lint related change?,The `%` and `%[n]` seemed
+3204,"@@ -15,6 +15,7 @@
+ module Blacklight::Document
+   autoload :ActiveModelShim, 'blacklight/document/active_model_shim'
+   autoload :SchemaOrg, 'blacklight/document/schema_org'
++  autoload :CacheKey, 'blacklight/document/cache_key'
+   autoload :DublinCore, 'blacklight/document/dublin_core'
+   autoload :Email, 'blacklight/document/email'
+   autoload :SemanticFields, 'blacklight/document/semantic_fields'",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Adding a new key to the `cache_key` is slowing down the process. Why is this not being in the `schema_org`?
+3205,"@@ -226,6 +226,12 @@ def opt_str_param(obj, param_name, default=None):
+     return default if obj is None else obj
+
+
++def opt_nonempty_str_param(obj, param_name, default=None):
++    if obj is not None and not isinstance(obj, string_types):
++        raise_with_traceback(_param_type_mismatch_exception(obj, str, param_name))
++    return default if obj is None or obj == '' else obj
++
++
+ def bool_param(obj, param_name):
+     if not isinstance(obj, bool):
+         raise_with_traceback(_param_type_mismatch_exception(obj, bool, param_name))",what does this do that str_param does not?,This function doesn't seem to be used anywhere.
+3206,"@@ -39,6 +39,11 @@ func GRPCDialOption(api string) grpc.DialOption {
+ 	return grpc.WithUserAgent(userAgentString(api))
+ }
+
++// AzureUserAgentPrefix returns a prefix that is used to set Azure SDK User-Agent to help with diagnostics.
++func AzureUserAgentPrefix() string {
++	return fmt.Sprintf(""%s/%s"", prefix, version)
++}
++
+ func userAgentString(api string) string {
+ 	return fmt.Sprintf(""%s/%s/%s"", prefix, api, version)
+ }","For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?","How about: `fmt.Sprintf(""%s/%s"", prefix, version)`"
+3207,"@@ -1,6 +1,14 @@
+ import os
+ import pickle
+
++from io import BytesIO
++
++try:
++    import boto3
++    import botocore
++except ImportError:
++    pass
++
+ from dagster import check, seven
+ from dagster.utils import mkdir_p
+ ",what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?,It's better to `import boto3` at the top of the file.
+3208,"@@ -2777,6 +2777,14 @@ void nano::active_transactions::confirm_frontiers (nano::transaction const & tra
+ 		size_t elections_count (0);
+ 		for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && elections_count < max_elections; ++i)
+ 		{
++			{
++				std::lock_guard<std::mutex> guard (mutex);
++				if (stopped)
++				{
++					break;
++				}
++			}
++
+ 			nano::account_info info (i->second);
+ 			if (info.block_count != info.confirmation_height)
+ 			{","May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`",Shouldn't this also be moved down one line?
+3209,"@@ -165,7 +165,7 @@ folly::SemiFuture<StorageRpcResponse<cpp2::ExecResponse>> GraphStorageClient::ad
+       evb,
+       std::move(requests),
+       [=](cpp2::GraphStorageServiceAsyncClient* client, const cpp2::AddEdgesRequest& r) {
+-        return useToss ? client->future_addEdgesAtomic(r) : client->future_addEdges(r);
++        return useToss ? client->future_chainAddEdges(r) : client->future_addEdges(r);
+       });
+ }
+ ","In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?",`const cpp2::AddEdgesRequest&` as well
+3210,"@@ -22,6 +22,9 @@ import (
+ 	""strconv""
+ 	""strings""
+
++	""github.com/prometheus/prometheus/pkg/rulefmt""
++	thanostypes ""github.com/thanos-io/thanos/pkg/store/storepb""
++
+ 	monitoringv1 ""github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1""
+ 	namespacelabeler ""github.com/prometheus-operator/prometheus-operator/pkg/namespace-labeler""
+ ",`go.sum` needs to be updated for this. Please run `go mod tidy`,It doesn't look like this is being used any
+3211,"@@ -28,6 +28,17 @@ const (
+ 	MachineFinalizer = ""awsmachine.infrastructure.cluster.x-k8s.io""
+ )
+
++// SecretBackend defines variants for backend secret storage.
++type SecretBackend string
++
++var (
++	// SecretBackendSSMParameterStore defines AWS Systems Manager Parameter Store as the secret backend
++	SecretBackendSSMParameterStore = SecretBackend(""ssm-parameter-store"")
++
++	// SecretBackendSecretsManager defines AWS Secrets Manager as the secret backend
++	SecretBackendSecretsManager = SecretBackend(""secrets-manager"")
++)
++
+ // AWSMachineSpec defines the desired state of AWSMachine
+ type AWSMachineSpec struct {
+ 	// ProviderID is the unique identifier as specified by the cloud provider.","Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?",The name `SecretBackendSSMParameterStore` i
+3212,"@@ -40,9 +40,11 @@ namespace OpenTelemetry.Metrics
+             var options = new OtlpExporterOptions();
+             configure?.Invoke(options);
+
+-            var metricExporter = new OtlpMetricsExporter(options);
+-            var metricReader = new PeriodicExportingMetricReader(metricExporter, options.MetricExportIntervalMilliseconds);
+-            return builder.AddMetricReader(metricReader);
++            // var metricExporter = new OtlpMetricsExporter(options);
++            // var metricReader = new PeriodicExportingMetricReader(metricExporter, options.MetricExportIntervalMilliseconds);
++            // return builder.AddMetricReader(metricReader);
++
++            return builder;
+         }
+     }
+ }",Same thing with the OtlpExporter,are we disabling this?
+3213,"@@ -70,7 +70,6 @@ const char * jx_operator_string( jx_operator_t type )
+ 		case JX_OP_NOT:	return "" not "";
+ 		// note that the closing bracket/paren is in jx_print_subexpr
+ 		case JX_OP_LOOKUP: return ""["";
+-		case JX_OP_CALL: return ""("";
+ 		case JX_OP_SLICE: return "":"";
+ 		default:        return ""???"";
+ 	}",Should not be removed.,Shouldn't this be `JX_
+3214,"@@ -1,17 +1,12 @@
+-[ 'foss', 'puppet', 'ezbake', 'module' ].each do |lib|
+-    require ""beaker/dsl/install_utils/#{lib}_utils""
+-end
+ require ""beaker/dsl/install_utils/pe_defaults""
++require 'beaker-puppet'
+
+ module Beaker
+   module DSL
+     # Collection of installation methods and support
+     module InstallUtils
+-      include DSL::InstallUtils::PuppetUtils
+       include DSL::InstallUtils::PEDefaults
+-      include DSL::InstallUtils::FOSSUtils
+-      include DSL::InstallUtils::ModuleUtils
+-      include DSL::InstallUtils::EZBakeUtils
++      include BeakerPuppet::InstallUtils
+     end
+   end
+ end","Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?",I don't think this is
+3215,"@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take
+     }
+
+     public void submit() {
++      dispatcher.beforeClickOn(element, driver);
+       element.submit();
++      dispatcher.afterClickOn(element, driver);
+     }
+
+     public void sendKeys(CharSequence... keysToSend) {","this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate.",Why is this necessary
+3216,"@@ -119,7 +119,7 @@ module Ncr
+       if self.pending?
+         self.currently_awaiting_approvers.first.email_address
+       else
+-        self.approving_official.email_address
++        self.approving_official ? self.approving_official.email_address : self.system_approver_emails.first
+       end
+     end
+ ",this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: ),`self.pending?` always returns true due to the `self.approving_official?` check
+3217,"@@ -4,6 +4,10 @@
+
+ package net.sourceforge.pmd.lang.java.typeresolution.typedefinition;
+
++import net.sourceforge.pmd.annotation.InternalApi;
++
++@Deprecated
++@InternalApi
+ public interface TypeDefinition {
+     /**
+      * Get the raw Class type of the definition.","Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway...",What's the reasoning behind marking this as deprecated?
+3218,"@@ -86,8 +86,12 @@ class Interface(param.Parameterized):
+
+     datatype = None
+
++    # Denotes whether the interface expects gridded data
+     gridded = False
+
++    # Denotes whether the interface expects multiple ragged arrays
++    multi = False
++
+     @classmethod
+     def register(cls, interface):
+         cls.interfaces[interface.datatype] = interface",Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?,I think we should raise an error here if `gridded` is True and `multi` is `True
+3219,"@@ -399,6 +399,7 @@ func (oi *OVFImporter) setUpImportWorkflow() (*daisy.Workflow, error) {
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""error parsing workflow %q: %v"", ovfImportWorkflow, err)
+ 	}
++	workflow.ForceCleanupOnError = true
+ 	return workflow, nil
+ }
+ ","Per my understanding, this flag only impacts ""NoCleanup"" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks.",I don't understand why this is necessary. Why would we want to force cleanup on
+3220,"@@ -40,7 +40,7 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+-public class SparkStreamingWrite extends SparkBatchWrite implements StreamingWrite {
++class SparkStreamingWrite extends BaseBatchWrite implements StreamingWrite {
+
+   private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingWrite.class);
+   private static final String QUERY_ID_PROPERTY = ""spark.sql.streaming.queryId"";","In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here.",Why we need to change this to `extends BaseBatchWrite`?
+3221,"@@ -95,10 +95,10 @@ const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes
+ 	{""magicpointspercent"", ITEM_PARSE_MAGICPOINTSPERCENT},
+ 	{""criticalhitchance"", ITEM_PARSE_CRITICALHITCHANCE},
+ 	{""criticalhitamount"", ITEM_PARSE_CRITICALHITAMOUNT},
+-	{""hitpointsleechchance"", ITEM_PARSE_HITPOINTSLEECHCHANCE},
+-	{""hitpointsleechamount"", ITEM_PARSE_HITPOINTSLEECHAMOUNT},
+-	{""manapointsleechchance"", ITEM_PARSE_MANAPOINTSLEECHCHANCE},
+-	{""manapointsleechamount"", ITEM_PARSE_MANAPOINTSLEECHAMOUNT},
++	{""lifeleechchance"", ITEM_PARSE_LIFELEECHCHANCE},
++	{""lifeleechamount"", ITEM_PARSE_LIFELEECHAMOUNT},
++	{""manaleechchance"", ITEM_PARSE_MANALEECHCHANCE},
++	{""manaleechamount"", ITEM_PARSE_MANALEECHAMOUNT},
+ 	{""fieldabsorbpercentenergy"", ITEM_PARSE_FIELDABSORBPERCENTENERGY},
+ 	{""fieldabsorbpercentfire"", ITEM_PARSE_FIELDABSORBPERCENTFIRE},
+ 	{""fieldabsorbpercentpoison"", ITEM_PARSE_FIELDABSORBPERCENTPOISON},",Shouldn't this be called `hp` instead of `life`?,"item parse is wrong, it should be like `hitpointsleecha"
+3222,"@@ -106,7 +106,7 @@ public class BaseServer<T extends BaseServer> implements Server<T> {
+       FilterHolder
+           filterHolder = servletContextHandler.addFilter(CrossOriginFilter.class, ""/*"", EnumSet
+           .of(DispatcherType.REQUEST));
+-      filterHolder.setInitParameter(""allowedOrigins"", ""*"");
++      filterHolder.setInitParameter(""allowedMethods"", ""GET,POST,PUT,DELETE,HEAD"");
+
+       // Warning user
+       LOG.warning(""You have enabled CORS requests from any host. ""","Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all.",I don't think it's a good idea to hardcode a method tha
+3223,"@@ -5757,4 +5757,3 @@ bool Game::reload(ReloadTypes_t reloadType)
+ 	}
+ 	return true;
+ }
+-",Undo this modification,Please revert this change.
+3224,"@@ -170,7 +170,7 @@ namespace OpenTelemetry.Exporter.Zipkin.Tests
+             var traceId = useShortTraceIds ? TraceId.Substring(TraceId.Length - 16, 16) : TraceId;
+
+             Assert.Equal(
+-                $@""[{{""""traceId"""":""""{traceId}"""",""""name"""":""""Name"""",""""parentId"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(activity.ParentSpanId)}"""",""""id"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(context.SpanId)}"""",""""kind"""":""""CLIENT"""",""""timestamp"""":{timestamp},""""duration"""":60000000,""""localEndpoint"""":{{""""serviceName"""":""""OpenTelemetry Exporter""""{ipInformation}}},""""annotations"""":[{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event1""""}},{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event2""""}}],""""tags"""":{{""""stringKey"""":""""value"""",""""longKey"""":""""1"""",""""longKey2"""":""""1"""",""""doubleKey"""":""""1"""",""""doubleKey2"""":""""1"""",""""boolKey"""":""""True"""",""""library.name"""":""""CreateTestActivity""""}}}}]"",
++                $@""[{{""""traceId"""":""""{traceId}"""",""""name"""":""""Name"""",""""parentId"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(activity.ParentSpanId)}"""",""""id"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(context.SpanId)}"""",""""kind"""":""""CLIENT"""",""""timestamp"""":{timestamp},""""duration"""":60000000,""""localEndpoint"""":{{""""serviceName"""":""""OpenTelemetry Exporter""""{ipInformation}}},""""annotations"""":[{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event1""""}},{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event2""""}}],""""tags"""":{{""""stringKey"""":""""value"""",""""longKey"""":1,""""longKey2"""":1,""""doubleKey"""":1.0,""""doubleKey2"""":1.0,""""boolKey"""":true,""""library.name"""":""""CreateTestActivity""""}}}}]"",
+                 Responses[requestId]);
+         }
+ ","Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes.","Out of curiosity, why does this test need to change?"
+3225,"@@ -335,6 +335,8 @@ public class Camera extends Plugin {
+       returnBase64(call, exif, bitmapOutputStream);
+     } else if (settings.getResultType() == CameraResultType.URI) {
+       returnFileURI(call, exif, bitmap, u, bitmapOutputStream);
++    } else if (settings.getResultType() == CameraResultType.BASE64NOMETADATA) {
++      returnBase64NoMetadata(call, exif, bitmapOutputStream);
+     } else {
+       call.reject(INVALID_RESULT_TYPE_ERROR);
+     }","Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core",I think this needs to check that the result type is
+3226,"@@ -83,7 +83,7 @@ func buildImportParams() *ovfimportparams.OVFImportParams {
+ 		ShieldedIntegrityMonitoring: *shieldedIntegrityMonitoring, ShieldedSecureBoot: *shieldedSecureBoot,
+ 		ShieldedVtpm: *shieldedVtpm, Tags: *tags, Zone: *zoneFlag, BootDiskKmskey: *bootDiskKmskey,
+ 		BootDiskKmsKeyring: *bootDiskKmsKeyring, BootDiskKmsLocation: *bootDiskKmsLocation,
+-		BootDiskKmsProject: *bootDiskKmsProject, Timeout: *timeout, Project: *project,
++		BootDiskKmsProject: *bootDiskKmsProject, Timeout: *timeout, Project: project,
+ 		ScratchBucketGcsPath: *scratchBucketGcsPath, Oauth: *oauth, Ce: *ce,
+ 		GcsLogsDisabled: *gcsLogsDisabled, CloudLogsDisabled: *cloudLogsDisabled,
+ 		StdoutLogsDisabled: *stdoutLogsDisabled, NodeAffinityLabelsFlag: nodeAffinityLabelsFlag,","Can you explain the history of the bug a bit, and why this fixes it?","```suggestion *bootDiskKmsProject, *timeout = *timeo"
+3227,"@@ -0,0 +1,11 @@
++module MentorHelper
++  def mentor_image(mentor)
++    image_tag gravatar_url(mentor.email, size: '300')
++  end
++
++  def mentor_contact_link(mentor)
++    mail_to mentor.email,
++      I18n.t('dashboard.show.contact_your_mentor',
++             mentor_name: mentor.first_name)
++  end
++end","What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion...",Hmm I wonder if we could move this method into the `
+3228,"@@ -80,7 +80,7 @@ namespace OpenTelemetry.Exporter
+                 {
+                     string valueDisplay = string.Empty;
+                     StringBuilder tagsBuilder = new StringBuilder();
+-                    for (int i = 0; i < metricPoint.Keys.Length; i++)
++                    for (int i = 0; i < ((metricPoint.Keys == null) ? 0 : metricPoint.Keys.Length); i++)
+                     {
+                         tagsBuilder.Append(metricPoint.Keys[i]);
+                         tagsBuilder.Append("":"");",Looks like this will make the check in every loop. Consider extracting the null check.,When would it be null?
+3229,"@@ -11,6 +11,14 @@ module RSpec::Core
+       expect(Module.private_methods & seg_methods).to eq([])
+     end
+
++    module SharedExampleGroup
++      describe Registry do
++        it 'can safely be reset' do
++          expect { Registry.clear }.to_not raise_error
++        end
++      end
++    end
++
+     %w[share_examples_for shared_examples_for shared_examples shared_context].each do |shared_method_name|
+       describe shared_method_name do
+         it ""is exposed to the global namespace"" do","Maybe `it ""can safely be reset when there are not yet any shared example groups""`? That's the edge case that wasn't working, right?",I think this is not re
+3230,"@@ -19,7 +19,8 @@ import (
+ 	""fmt""
+ 	""net/http""
+
+-	""github.com/aws/amazon-ecs-agent/agent/asm/factory""
++	factory ""github.com/aws/amazon-ecs-agent/agent/asm/factory""
++	ssmfactory ""github.com/aws/amazon-ecs-agent/agent/ssm/factory""
+ 	""github.com/aws/amazon-ecs-agent/agent/config""
+ 	""github.com/aws/amazon-ecs-agent/agent/credentials""
+ 	""github.com/aws/amazon-ecs-agent/agent/ec2""",naming: please use `asmfactory`,Should this be `ssm` a
+3231,"@@ -54,9 +54,12 @@ func (c *Client) buildCommand(target *core.BuildTarget, inputRoot *pb.Directory,
+ 	}
+ 	// We can't predict what variables like this should be so we sneakily bung something on
+ 	// the front of the command. It'd be nicer if there were a better way though...
+-	const commandPrefix = ""export TMP_DIR=\""`pwd`\"" && ""
++	var commandPrefix = ""export TMP_DIR=\""`pwd`\"" && ""
+ 	// TODO(peterebden): Remove this nonsense once API v2.1 is released.
+ 	files, dirs := outputs(target)
++	if len(target.Outputs()) == 1 { // $OUT is relative when running remotely; make it absolute
++		commandPrefix += ""export OUT=\""$TMP_DIR/$OUT\"" && ""
++	}
+ 	cmd, err := core.ReplaceSequences(c.state, target, c.getCommand(target))
+ 	return &pb.Command{
+ 		Platform: c.platform,",FYI you could use a raw string for this which removes the need for escaping the inner quotes.,I think it would be cl
+3232,"@@ -984,3 +984,19 @@ class TestGetSetClipboard:
+     def test_supports_selection(self, clipboard_mock, selection):
+         clipboard_mock.supportsSelection.return_value = selection
+         assert utils.supports_selection() == selection
++
++
++@pytest.mark.parametrize('keystr, expected', [
++    ('<Control-x>', True),
++    ('<Meta-x>', True),
++    ('<Ctrl-Alt-y>', True),
++    ('x', False),
++    ('X', False),
++    ('<Escape>', True),
++    ('foobar', False),
++    ('foo>', False),
++    ('<foo', False),
++    ('<<', False),
++])
++def test_is_special_key(keystr, expected):
++    assert utils.is_special_key(keystr) == expected",2 blank lines here (between functions),The `keystr` should contain `<Control-x>` and `<Meta-x>`
+3233,"@@ -23,8 +23,13 @@ import java.util.Set;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+
+ class BaseRewriteFiles extends MergingSnapshotProducer<RewriteFiles> implements RewriteFiles {
++
+   BaseRewriteFiles(String tableName, TableOperations ops) {
+-    super(tableName, ops);
++    this(tableName, ops, ops.current().spec());
++  }
++
++  BaseRewriteFiles(String tableName, TableOperations ops, PartitionSpec spec) {
++    super(tableName, ops, spec);
+
+     // replace files must fail if any of the deleted paths is missing and cannot be deleted
+     failMissingDeletePaths();",Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts.,can we just pass a PartitionSpec here instead of creatin
+3234,"@@ -1279,10 +1279,13 @@ class Codebase
+         }
+
+         foreach ($reference_map as $start_pos => [$end_pos, $possible_reference]) {
+-            if ($offset < $start_pos || $possible_reference[0] !== '*') {
++            if ($offset < $start_pos) {
+                 continue;
+             }
+-
++            // If the reference precedes a ""::"" then treat it as a class reference.
++            if ($offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::') {
++                return [$possible_reference, '::', $offset];
++            }
+             if ($offset - $end_pos === 0) {
+                 $recent_type = $possible_reference;
+ ","As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!",I don't think this is right. If you are reading a file w
+3235,"@@ -59,4 +59,19 @@ class BackgroundRepository implements Repository {
+     public void setFilter(CombinedAppsFilter filter) {
+         delegatedRepository.setFilter(filter);
+     }
++
++    @Override
++    public boolean equals(Object o) {
++        if (this == o) return true;
++        if (o == null || getClass() != o.getClass()) return false;
++
++        BackgroundRepository that = (BackgroundRepository) o;
++
++        return delegatedRepository != null ? delegatedRepository.equals(that.delegatedRepository) : that.delegatedRepository == null;
++    }
++
++    @Override
++    public int hashCode() {
++        return delegatedRepository != null ? delegatedRepository.hashCode() : 0;
++    }
+ }","Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible",Shouldn't `equals` and `hashCode` be implemented using t
+3236,"@@ -56,15 +56,17 @@ func TestPinger_Provider_Consumer_Ping_Flow(t *testing.T) {
+
+ 	// Create provider's UDP proxy listener to which pinger should hand off connection.
+ 	// In real world this proxy represents started VPN service (WireGuard or OpenVPN).
+-	proxyBuf := make([]byte, 1024)
++	ch := make(chan string)
+ 	go func() {
+ 		addr, _ := net.ResolveUDPAddr(""udp4"", fmt.Sprintf(""127.0.0.1:%d"", providerProxyPort))
+ 		conn, err := net.ListenUDP(""udp4"", addr)
+ 		assert.NoError(t, err)
+
+ 		for {
+-			_, err := conn.Read(proxyBuf)
++			proxyBuf := make([]byte, 1024)
++			n, err := conn.Read(proxyBuf)
+ 			assert.NoError(t, err)
++			ch <- string(proxyBuf[:n])
+ 		}
+ 	}()
+ ",Allocate buffer once outside loop.,[nit] Why not using `ch` as the variable name? It is a bit confusing because it is used later in the tests.
+3237,"@@ -1262,3 +1262,11 @@ TEST (network, filter)
+ 	node1.network.inbound (keepalive, std::make_shared<nano::transport::channel_loopback> (node1));
+ 	ASSERT_EQ (1, node1.stats.count (nano::stat::type::message, nano::stat::detail::invalid_network));
+ }
++
++TEST (network, fill_keepalive_self)
++{
++	nano::system system{ 2 };
++	std::array<nano::endpoint, 8> target;
++	system.nodes[0]->network.fill_keepalive_self (target);
++	ASSERT_TRUE (target[2].port () == system.nodes[1]->network.port);
++}",It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail.,It would be better to use `nullopt` to test the `nano::endpoint.fill_keepalive_self` endpoint.
+3238,"@@ -43,8 +43,11 @@ public class WebApplicationExceptionHandler implements ExceptionMapper<WebApplic
+         switch (ex.getResponse().getStatus()) {
+             // BadRequest
+             case 400:
++                // It's strange to have these ""startsWith"" conditionals here. They both come from Access.java.
+                 if ( (ex.getMessage()+"""").toLowerCase().startsWith(""tabular data required"")) {
+                     jrb.message(BundleUtil.getStringFromBundle(""access.api.exception.metadata.not.available.for.nontabular.file""));
++                } else if ((ex.getMessage() + """").toLowerCase().startsWith(""no permission to download file"")) {
++                    jrb.message(""You do not have permission to download this file."");
+                 } else {
+                     jrb.message(""Bad Request. The API request cannot be completed with the parameters supplied. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."");
+                     jrb.request(request);",Should this be in a bundle?,I don't think this is correct. There's no relationship between the files and the tabular files.
+3239,"@@ -291,9 +291,8 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation
+
+         private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncCallback, Activity activity, object result, bool forceResponseCopy)
+         {
+-            // We could be executing on a different thread now so set the activity.
+-            Debug.Assert(Activity.Current == null || Activity.Current == activity, ""There was an unexpected active Activity on the result thread."");
+-            if (Activity.Current == null)
++            // We could be executing on a different thread now so restore the activity if needed.
++            if (Activity.Current != activity)
+             {
+                 Activity.Current = activity;
+             }","When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble.","This assert was redundant because if the activity was null, then we already set it"
+3240,"@@ -63,13 +63,16 @@ func WrapNetwork(net network.GossipNode, log logging.Logger) agreement.Network {
+ 	i.net = net
+ 	i.log = log
+
++	return i
++}
++
++func (i *networkImpl) Start() {
+ 	handlers := []network.TaggedMessageHandler{
+ 		{Tag: protocol.AgreementVoteTag, MessageHandler: network.HandlerFunc(i.processVoteMessage)},
+ 		{Tag: protocol.ProposalPayloadTag, MessageHandler: network.HandlerFunc(i.processProposalMessage)},
+ 		{Tag: protocol.VoteBundleTag, MessageHandler: network.HandlerFunc(i.processBundleMessage)},
+ 	}
+-	net.RegisterHandlers(handlers)
+-	return i
++	i.net.RegisterHandlers(handlers)
+ }
+
+ func messageMetadataFromHandle(h agreement.MessageHandle) *messageMetadata {",what was the point in moving handlers registration into a separate method?,why did you remove the return value?
+3241,"@@ -30,6 +30,9 @@ func newSyncCache(state *core.BuildState, remoteOnly bool) core.Cache {
+ 	if state.Config.Cache.HTTPURL != """" {
+ 		mplex.caches = append(mplex.caches, newHTTPCache(state.Config))
+ 	}
++	if state.Config.Cache.RetrieveCommand != """" {
++		mplex.caches = append(mplex.caches, newCmdCache(state.Config))
++	}
+ 	if len(mplex.caches) == 0 {
+ 		return &noopCache{}
+ 	} else if len(mplex.caches) == 1 {",At this point we probably want to ensure there's a store command set.,@spooktheducks mind taking a look at
+3242,"@@ -106,8 +106,13 @@ HDPrivateKey._getDerivationIndexes = function(path) {
+   }
+
+   var indexes = steps.slice(1).map(function(step) {
+-    var index = parseInt(step);
+-    index += step != index.toString() ? HDPrivateKey.Hardened : 0;
++    var index = step ? +step : NaN;
++
++    var isHardened = isNaN(index) && step[step.length-1] == ""'"";
++    if (isHardened) {
++      index = (+(step.slice(0, -1))) + HDPrivateKey.Hardened;
++    }
++
+     return index;
+   });
+ ","This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function",Is there a possibility of `step[0] =
+3243,"@@ -151,6 +151,10 @@ namespace Nethermind.Vault.JsonRpc
+         {
+             try
+             {
++                if (message.StartsWith(""0x""))
++                {
++                    throw new Exception($""Vault message should not be in hex; message: {message}"");
++                }
+                 string result = await _vaultService.Sign(Guid.Parse(vaultId), Guid.Parse(keyId), message);
+                 return ResultWrapper<string>.Success(result);
+             }","Don't throw base exception, specify more precise type","What does ""0x"" mean in this context?"
+3244,"@@ -5,6 +5,16 @@ import torch
+
+
+ def cast_tensor_type(inputs, src_type, dst_type):
++    """"""Recursive converted Tensor in inputs from src_type to dst_type.
++
++    Args:
++        inputs: Inputs that to be casted.
++        src_type (torch.dtype): Source type..
++        dst_type (torch.dtype): Destination type.
++
++    Returns:
++        The same type with inputs, but all contained Tensors have been cast.
++    """"""
+     if isinstance(inputs, torch.Tensor):
+         return inputs.to(dst_type)
+     elif isinstance(inputs, str):",Recursive -> Recursively converted -> convert,"Can you say something like ""The same type with the input Tensors, but the resulting tensor has been casted""?"
+3245,"@@ -947,7 +947,8 @@ class CSharpGenerator : public BaseGenerator {
+       }
+       // JVM specifications restrict default constructor params to be < 255.
+       // Longs and doubles take up 2 units, so we set the limit to be < 127.
+-      if (has_no_struct_fields && num_fields && num_fields < 127) {
++      if ((has_no_struct_fields || opts.generate_object_based_api) &&
++          num_fields && num_fields < 127) {
+         struct_has_create = true;
+         // Generate a table constructor of the form:
+         // public static int createName(FlatBufferBuilder builder, args...)",why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs.,I think this would be clearer with the `(has_no_struct_fields || opts.generate_object_based_api)`
+3246,"@@ -432,7 +432,7 @@ func acsWsURL(endpoint, cluster, containerInstanceArn string, taskEngine engine.
+ 	query.Set(""agentVersion"", version.Version)
+ 	query.Set(""seqNum"", ""1"")
+ 	if dockerVersion, err := taskEngine.Version(); err == nil {
+-		query.Set(""dockerVersion"", ""DockerVersion: ""+dockerVersion)
++		query.Set(""dockerVersion"", dockerVersion)
+ 	}
+ 	query.Set(sendCredentialsURLParameterName, acsSessionState.getSendCredentialsURLParameter())
+ 	return acsURL + ""?"" + query.Encode()","just to confirm, so backend will deal with both old format and new format?",Is this a breaking change? Should we mention it in the changelog.
+3247,"@@ -91,7 +91,7 @@ namespace Datadog.Trace
+         }
+
+         private static T? ParseEnum<T>(IHeadersCollection headers, string headerName)
+-            where T : struct
++            where T : struct, Enum
+         {
+             var headerValues = headers.GetValues(headerName).ToList();
+ ","huh, look at that, I wasn't aware you could constrain a type by Enum",Do we have a test case for this change?
+3248,"@@ -229,6 +229,15 @@ PYBIND11_MODULE(ADIOS2_PYTHON_MODULE_NAME, m)
+                  const bool opBool = adios ? true : false;
+                  return opBool;
+              })
++        .def(pybind11::init<const bool>(),
++             ""adios2 module starting point ""
++             ""non-MPI, constructs an ADIOS class ""
++             ""object"",
++             pybind11::arg(""debugMode"") = true)
++        .def(pybind11::init<const std::string &, const bool>(),
++             ""adios2 module starting point non-MPI, constructs an ADIOS class ""
++             ""object"",
++             pybind11::arg(""configFile""), pybind11::arg(""debugMode"") = true)
+ #if ADIOS2_USE_MPI
+         .def(pybind11::init<const adios2::py11::MPI4PY_Comm, const bool>(),
+              ""adios2 module starting point, constructs an ADIOS class object"",","Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?",What is the purpose of this `configFile` argument?
+3249,"@@ -0,0 +1,17 @@
++/* Copyright 2016 Google Inc
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *      http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package com.google.api.codegen.viewmodel;
++
++public interface ParamView {}","What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism",I don't think this belongs in this interface. Seem
+3250,"@@ -1,12 +1,11 @@
+ package startupshutdown
+
+ import (
+-	""log""
+-	""os""
+-	""os/exec""
+ 	""strings""
+
++	""github.com/google/uuid""
+ 	""github.com/mholt/caddy""
++	""github.com/mholt/caddy/onevent/hook""
+ )
+
+ func init() {","We added a library to generate a UUID for the request_id directive ""github.com/nu7hatch/gouuid"" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?",Can we move this to `libbeat/cmd/server/main`?
+3251,"@@ -161,16 +161,13 @@ func (p *Pinger) PingProvider(ip string, localPorts, remotePorts []int, proxyPor
+ 	return localPort, remotePort, err
+ }
+
+-func (p *Pinger) ping(conn *net.UDPConn, ttl int, stop <-chan struct{}) error {
+-	// Windows detects that 1 TTL is too low and throws an exception during send
+-	i := 0
+-
++func (p *Pinger) ping(conn *net.UDPConn, remoteAddr *net.UDPAddr, ttl int, stop <-chan struct{}) error {
+ 	err := ipv4.NewConn(conn).SetTTL(ttl)
+ 	if err != nil {
+ 		return errors.Wrap(err, ""pinger setting ttl failed"")
+ 	}
+
+-	for {
++	for i := 1; time.Duration(i)*p.pingConfig.Interval < p.pingConfig.Timeout; i++ {
+ 		select {
+ 		case <-stop:
+ 			return nil","Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)",Why was this moved from outside the loop?
+3252,"@@ -2513,7 +2513,7 @@ stack_alloc(size_t size, byte *min_addr)
+ #else
+         /* For UNIX we just mark it as inaccessible. */
+         if (!DYNAMO_OPTION(guard_pages))
+-            make_unwritable(guard, PAGE_SIZE);
++            set_protection(guard, PAGE_SIZE, MEMPROT_READ);
+ #endif
+     }
+ ",I guess it's not no-access to match Windows where guard pages are readable.,Do we still need this?
+3253,"@@ -103,7 +103,9 @@ module Ncr
+         self.proposal.update(status: 'approved')
+       else
+         approvers = emails.map{|e| User.for_email(e)}
++        removed_approvers_to_notify = self.proposal.approvals.non_pending.map(&:user) - approvers
+         self.proposal.approvers = approvers
++        Dispatcher.on_approver_removal(self.proposal, removed_approvers_to_notify)
+       end
+     end
+ ","Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model.",Style/RedundantSelf: R
+3254,"@@ -94,6 +94,16 @@ class TaskException(Exception):
+     pass
+
+
++GetWorkResponse = collections.namedtuple('GetWorkResponse', (
++    'task_id',
++    'running_tasks',
++    'n_pending_tasks',
++    'n_unique_pending',
++    'n_pending_last_scheduled',
++    'worker_state'
++))
++
++
+ class TaskProcess(multiprocessing.Process):
+
+     """""" Wrap all task execution in this class.",Add trailing comma,I think it would be be
+3255,"@@ -28,7 +28,7 @@ func StartModules() {
+ // GracefulShutdown is if it gets the special signals it does modules cleanup
+ func GracefulShutdown() {
+ 	c := make(chan os.Signal)
+-	signal.Notify(c, syscall.SIGINT, syscall.SIGHUP, syscall.SIGTERM, syscall.SIGKILL,
++	signal.Notify(c, syscall.SIGINT, syscall.SIGHUP, syscall.SIGTERM,
+ 		syscall.SIGQUIT, syscall.SIGILL, syscall.SIGTRAP, syscall.SIGABRT)
+ 	select {
+ 	case s := <-c:",I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?,why did you remove `SI
+3256,"@@ -241,6 +241,7 @@ class Setting extends BaseModel {
+ 					let output = {};
+ 					output[Setting.THEME_LIGHT] = _('Light');
+ 					output[Setting.THEME_DARK] = _('Dark');
++					output[Setting.THEME_OLED_DARK] = _('OLED dark');
+ 					if (platform !== 'mobile') {
+ 						output[Setting.THEME_DRACULA] = _('Dracula');
+ 						output[Setting.THEME_SOLARIZED_LIGHT] = _('Solarised Light');","As it is a mobile only theme, please make sure the option appears only on mobile",Perhaps we should call them `OLED_DARK_LIGHT` and `OLED_DARK_LIGHT`. Thoughts?
+3257,"@@ -364,3 +364,14 @@ def _get_non_negative_param(param, default=None):
+         if value < 0:
+             raise APIBadRequest(""'{}' should be a non-negative integer"".format(param))
+     return value
++
++
++def parse_param_list(params):
++    param_list = []
++    for param in params.split("",""):
++        param = param.strip()
++        if not param:
++            continue
++        param_list.append(param)
++
++    return param_list",Would like a docstring and type annotations here,Is this function used anywhere?
+3258,"@@ -11,7 +11,7 @@ module Mongoid
+
+     included do
+       cattr_accessor :shard_key_fields
+-      self.shard_key_fields = []
++      self.shard_key_fields = {}
+     end
+
+     # Get the shard key fields.",This is an API change. Why was it made?,This is the only real change to this file. The rest of the changes are from th
+3259,"@@ -1,5 +1,7 @@
+ // Copyright (c) Microsoft. All rights reserved.
+
++using Microsoft.VisualStudio.TestPlatform.CoreUtilities.Tracing;
++
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Discovery
+ {
+     using System;",Please move using inside namespace.,"I don't see any new code in this file that checks for null, so maybe not neede"
+3260,"@@ -511,7 +511,7 @@ namespace Nethermind.Blockchain
+             }
+         }
+
+-        private AddBlockResult Suggest(Block? block, BlockHeader header, bool shouldProcess = true, bool? setAsMain = null)
++        private AddBlockResult Suggest(Block? block, BlockHeader header, bool shouldProcess = true, bool? setAsMain = null, bool poSEnabled = false)
+         {
+ #if DEBUG
+             /* this is just to make sure that we do not fall into this trap when creating tests */",shall we create some enum flags for setasmain shouldprocess and pos?,why not just `poS` ?
+3261,"@@ -141,6 +141,16 @@ exit /B %errorlevel%
+             # therefore, this command will always exit 0 if either service is installed
+             on host, Command.new(""sc query puppet || sc query pe-puppet"", [], { :cmdexe => true })
+
++            # (PA-514) value for PUPPET_AGENT_STARTUP_MODE should be present in
++            # registry and honored after install/upgrade.
++            reg_query_command = %Q(reg query ""HKLM\\SOFTWARE\\Wow6432Node\\Puppet Labs\\PuppetInstaller"" /v ""RememberedPuppetAgentStartupMode"" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
++            on host, Command.new(reg_query_command, [], { :cmdexe => true })
++
++            start_mode = msi_opts['PUPPET_AGENT_STARTUP_MODE'] == ""Automatic"" ? ""Auto"" : msi_opts['PUPPET_AGENT_STARTUP_MODE']
++            service_query_command = %Q('WMIC SERVICE where (Name like ""%Puppet"" AND StartMode=""#{start_mode}"") | findstr Puppet')
++
++            on host, Command.new(service_query_command, [], { :cmdexe => true })
++
+             # emit the misc/versions.txt file which contains component versions for
+             # puppet, facter, hiera, pxp-agent, packaging and vendored Ruby
+             [",Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?,Use the new Ruby 1.9
+3262,"@@ -17,15 +17,10 @@
+ # You should have received a copy of the GNU General Public License
+ # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+
++# pylint: disable=unused-import
+ import pytest
+ import pytest_bdd as bdd
+
+-# pylint: disable=unused-import
+ from end2end.features.test_yankpaste_bdd import init_fake_clipboard
+
+-
+-pytestmark = pytest.mark.qtwebengine_todo(""Caret mode is not implemented"",
+-                                          run=False)
+-
+-
+ bdd.scenarios('caret.feature')",Why not simply remove the `pytest` import now that it's not needed anymore? :wink:,I think you can also
+3263,"@@ -0,0 +1,12 @@
++// Copyright (c) Microsoft.  All Rights Reserved.
++// Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
++
++using Microsoft.VisualStudio.TestTools.UnitTesting;
++
++namespace Microsoft.CodeAnalysis.Sarif.Core
++{
++    [TestClass]
++    public class TagsTests
++    {
++    }
++}","Yeah, not filled in yet.",This class doesn't a
+3264,"@@ -28,6 +28,13 @@
+     </div>
+   </div>
+
++  <div class=""row"">
++    <div class=""form-group col-xs-12"">
++      <%= f.check_box :active, style: 'width: auto' %>
++      <%= f.label :active, _('Active'), class: 'control-label' %>
++    </div>
++  </div>
++
+   <div class=""row"">
+     <div class=""form-group col-xs-6"">
+       <%= f.label :starts_at, _('Start'), class: 'control-label' %>",don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick,Shouldn't this be `f.active`?
+3265,"@@ -218,6 +218,13 @@ public class Catalog implements AutoCloseable {
+     Objects.requireNonNull(database, ""database is null"");
+     Objects.requireNonNull(tableName, ""tableName is null"");
+     TiTableInfo table = metaCache.getTable(database, tableName);
++
++    if (table == null) {
++      // reload cache if table not exists
++      reloadCache();
++      table = metaCache.getTable(database, tableName);
++    }
++
+     if (showRowId && table != null) {
+       return table.copyTableWithRowId();
+     } else {",should we also do `reloadCache` when database is null?,I think this is the only plac
+3266,"@@ -47,6 +47,15 @@ void SetMCSBondTyper(MCSParameters &p, BondComparator bondComp) {
+   }
+ }
+
++ROMol *getQueryMol(MCSResult &mcsRes) {
++  ROMol *res;
++  {
++    NOGIL gil;
++    res = new ROMol(*mcsRes.QueryMol);
++  }
++  return res;
++}
++
+ MCSResult *FindMCSWrapper(python::object mols, bool maximizeBonds,
+                           double threshold, unsigned timeout, bool verbose,
+                           bool matchValences, bool ringMatchesRingOnly,",Why not just return QueryMol directly? Why require the copy?,you don't need to create a ne
+3267,"@@ -84,6 +84,15 @@ def retry_test(func):
+     assert success
+     return result
+
++
++def scapy_path(fname):
++    """"""Resolves a path relative to scapy's root folder""""""
++    if fname.startswith('/'):
++        fname = fname[1:]
++    return os.path.abspath(os.path.join(
++        os.path.dirname(__file__), '../../', fname
++    ))
++
+ #    Import tool    #
+
+ ",Could you add a docstring?,Why not use `os.path.relpath`
+3268,"@@ -23,4 +23,5 @@ module ApplicationHelper
+   def display_search_ui?
+     current_user && current_user.client_model && !client_disabled?
+   end
++
+ end",looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?,Extra empty line detected at method body end.
+3269,"@@ -46,7 +46,7 @@ public class EqualsVisitor implements GenericVisitor<Boolean, Visitable> {
+     }
+
+     private EqualsVisitor() {
+-    // hide constructor
++        // hide constructor
+     }
+
+     /**",@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:,please revert this file
+3270,"@@ -33,12 +33,15 @@ class ArgInfo:
+
+     """"""Information about an argument.""""""
+
+-    def __init__(self, win_id=False, count=False, flag=None, hide=False,
+-                 metavar=None, completion=None, choices=None):
++    def __init__(self, win_id=False, count=False, hide=False, metavar=None,
++                 zero_count=False, flag=None, completion=None, choices=None):
+         if win_id and count:
+             raise TypeError(""Argument marked as both count/win_id!"")
++        if zero_count and not count:
++            raise TypeError(""Zero_count Argument cannot exist without count!"")
+         self.win_id = win_id
+         self.count = count
++        self.zero_count = zero_count
+         self.flag = flag
+         self.hide = hide
+         self.metavar = metavar",nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here.,nit: I think this should be `if zero_count:`.
+3271,"@@ -2693,7 +2693,7 @@ func (a *Account) hasIssuer(issuer string) bool {
+ // hasIssuerNoLock is the unlocked version of hasIssuer
+ func (a *Account) hasIssuerNoLock(issuer string) bool {
+ 	// same issuer
+-	if a.Issuer == issuer {
++	if a.Name == issuer {
+ 		return true
+ 	}
+ 	for i := 0; i < len(a.signingKeys); i++ {",change the name of the function to match its functionality? account IsIssuing?,"There is no need to change this method, as it"
+3272,"@@ -84,6 +84,19 @@ class _Frame(object):
+         """"""
+         return _spark_col_apply(self, F.abs)
+
++    def groupby(self, by):
++        from databricks.koalas.groupby import GroupBy
++        from databricks.koalas.series import Series
++        if isinstance(by, str):
++            by = [by]
++        elif isinstance(by, Series):
++            by = [by]
++        else:
++            by = list(by)
++        if len(by) == 0:
++            raise ValueError('No group keys passed!')
++        return GroupBy(self, by=by)
++
+     def compute(self):
+         """"""Alias of `toPandas()` to mimic dask for easily porting tests.""""""
+         return self.toPandas()",for later: add docstring (can just copy paste Pandas'),Should we check that `by` is a string and raise an error if it isn't?
+3273,"@@ -4,10 +4,10 @@
+ package cli
+
+ import (
+-	""fmt""
+ 	""testing""
+
+ 	climocks ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/cli/mocks""
++	archerMocks ""github.com/aws/amazon-ecs-cli-v2/mocks""
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/stretchr/testify/require""
+ )","nit: @sonofachamp pointed out to me that the idiomatic way is ""archermocks"" (lowercase for package names)",Please rename this to `ecsMocks`
+3274,"@@ -31,8 +31,7 @@ import (
+ )
+
+ var (
+-	errRouterNotSet          = errors.New(""router not set"")
+-	errRouterHasNoProcedures = errors.New(""router has no procedures"")
++	errRouterNotSet = errors.New(""router not set"")
+
+ 	_ transport.Inbound = (*Inbound)(nil)
+ )","Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?",remove the variable if there is no procedures.
+3275,"@@ -42,10 +42,16 @@ import org.apache.iceberg.util.ThreadPools;
+ public class AllDataFilesTable extends BaseMetadataTable {
+   private final TableOperations ops;
+   private final Table table;
++  private final String name;
+
+   public AllDataFilesTable(TableOperations ops, Table table) {
++    this(ops, table, table.name() + "".all_data_files"");
++  }
++
++  public AllDataFilesTable(TableOperations ops, Table table, String name) {
+     this.ops = ops;
+     this.table = table;
++    this.name = name;
+   }
+
+   @Override",We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too.,Can you make it clear that this is the name of the table in which the
+3276,"@@ -4424,11 +4424,15 @@ function _execPopulateQuery(mod, match, select, assignmentOpts, callback) {
+     limit: mod.options.limit,
+     perDocumentLimit: mod.options.perDocumentLimit
+   }, mod.options.options);
++
+   if (mod.count) {
+     delete queryOptions.skip;
+   }
+
+-  if (queryOptions.perDocumentLimit != null) {
++  if (queryOptions.perDocumentLimit != null && queryOptions.limit != null) {
++    throw new Error('Can not use `limit` and `perDocumentLimit` at the same time. Model `' + mod.model.modelName + '`.' );
++  }
++  else if (queryOptions.perDocumentLimit != null) {
+     queryOptions.limit = queryOptions.perDocumentLimit;
+     delete queryOptions.perDocumentLimit;
+   } else if (queryOptions.limit != null) {",I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing.,This part is a bug fix for the bug. `perDocumentLimit` should always be null if `limit` is not provided.
+3277,"@@ -41,13 +41,13 @@ var (
+
+ // NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
+ type NATProviderPinger interface {
+-	PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
++	PingProvider(params Params, proxyPort int) (*net.UDPConn, error)
+ }
+
+ // NATPinger is responsible for pinging nat holes
+ type NATPinger interface {
+ 	NATProviderPinger
+-	PingTarget(*Params)
++	PingTarget(Params)
+ 	BindServicePort(key string, port int)
+ 	Start()
+ 	Stop()","Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls",How is this change related to the rest of the PR?
+3278,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....,no need for this test class. There is already a test case called `RemoteDistributorTest`
+3279,"@@ -0,0 +1,7 @@
++<figure>
++  <img src=""/assets/upcase/testimonial_thumbs/anthony-lee.jpg"" alt=""Anthony"">
++  <p class=""quotee"">Anthony Lee<strong>Professional</strong> </p>
++</figure>
++<blockquote>
++  <p><strong>I am really loving upcase.</strong> The most valuable part for me was how I was able to dissect ""upcase"" app and see how it was built. Having the access to the repo and seeing how codes were structured was such a priceless lesson.</p>
++</blockquote>",`image_tag` in the `testimonials` files?,You should be able to use the `<img>` tag here instead of `<p>`
+3280,"@@ -255,9 +255,10 @@ public class ExecutionFlowDao {
+             + ""SET status=?,update_time=?,start_time=?,end_time=?,enc_type=?,flow_data=? ""
+             + ""WHERE exec_id=?"";
+
+-    final String json = JSONUtils.toJSON(flow.toObject());
+     byte[] data = null;
+     try {
++      // If this action fails, the execution must be failed.
++      final String json = JSONUtils.toJSON(flow.toObject());
+       final byte[] stringData = json.getBytes(""UTF-8"");
+       data = stringData;
+       // Todo kunkun-tang: use a common method to transform stringData to data.","I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List<Map<String, Object>> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());","If this action fails, the execution must be failed as well."
+3281,"@@ -33,7 +33,7 @@ export default Controller.extend(SettingsSaveMixin, {
+     }),
+
+     iconImageSource: computed('model.icon', function () {
+-        return this.get('model.icon') || '';
++        return this.get('model.icon') || '/favicon.ico';
+     }),
+
+     coverImageSource: computed('model.cover', function () {","So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know  ",@nickytonline why do we need to change this? if `favicon.ic
+3282,"@@ -120,8 +120,16 @@ int main(int argc, char **argv)
+     MPI_Init(nullptr, nullptr);
+ #endif
+
+-    ::testing::InitGoogleTest(&argc, argv);
+-    int result = RUN_ALL_TESTS();
++    int result = -1;
++    try
++    {
++        ::testing::InitGoogleTest(&argc, argv);
++        result = RUN_ALL_TESTS();
++    }
++    catch (std::exception &e)
++    {
++        result = 1;
++    }
+
+ #ifdef ADIOS2_HAVE_MPI
+     MPI_Finalize();",Why swallow the exception here rather than propagate it?,Shouldn't this be `const std::exception& e`?
+3283,"@@ -340,7 +340,8 @@ class _InternalFrame(object):
+                  index_map: Optional[List[IndexMap]] = None,
+                  scol: Optional[spark.Column] = None,
+                  data_columns: Optional[List[str]] = None,
+-                 column_index: Optional[List[Tuple[str]]] = None) -> None:
++                 column_index: Optional[List[Tuple[str]]] = None,
++                 column_names: Optional[List[str]] = None) -> None:
+         """"""
+         Create a new internal immutable DataFrame to manage Spark DataFrame, column fields and
+         index fields and names.",How about `column_index_names`? `column_names` sounds ambiguous.,can we have a test for this in `test_imdb_reader` ?
+3284,"@@ -89,6 +89,7 @@ public class TableProperties {
+   public static final String METADATA_COMPRESSION = ""write.metadata.compression-codec"";
+   public static final String METADATA_COMPRESSION_DEFAULT = ""none"";
+
++  public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics.column."";
+   public static final String DEFAULT_WRITE_METRICS_MODE = ""write.metadata.metrics.default"";
+   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = ""truncate(16)"";
+ }",+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure.,Remove the period at the end of the sentence.
+3285,"@@ -2264,8 +2264,8 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils):
+
+     def test_cumprod(self):
+         pdf = pd.DataFrame(
+-            [[2.0, 1.0], [5, None], [1.0, 1.0], [2.0, 4.0], [4.0, 9.0]],
+-            columns=list(""AB""),
++            [[2.0, 1.0, 1], [5, None, 2], [1.0, 1.0, 3], [2.0, 4.0, 4], [4.0, 9.0, 5]],
++            columns=list(""ABC""),
+             index=np.random.rand(5),
+         )
+         kdf = ks.from_pandas(pdf)",Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types.,Thanks for the PR! Can you also update this t
+3286,"@@ -20,8 +20,11 @@ Wrappers around spark that correspond to common pandas functions.
+ import pyspark
+ import numpy as np
+ import pandas as pd
++from ._dask_stubs.compatibility import string_types
++from ._dask_stubs.utils import derived_from
+ from .typing import Col, pandas_wrap
+-from pyspark.sql import Column, DataFrame
++from pyspark.sql import Column, DataFrame, functions as F
++from pyspark.sql.types import NumericType
+
+
+ def default_session():","we should sort the headers like in spark: public packages, then pyspark, then internal",nit: can we use `pyspark.sql.types` instead?
+3287,"@@ -53,7 +53,9 @@ func newPeer(address string, t *Transport) (*grpcPeer, error) {
+ 			grpc.MaxCallSendMsgSize(t.options.clientMaxSendMsgSize),
+ 		),
+ 	}
+-	if t.options.clientTLS {
++	if t.options.clientTLSConfig != nil {
++		dialOptions = append(dialOptions, grpc.WithTransportCredentials(credentials.NewTLS(t.options.clientTLSConfig)))
++	} else if t.options.clientTLS {
+ 		dialOptions = append(dialOptions, grpc.WithTransportCredentials(credentials.NewClientTLSFromCert(nil, """")))
+ 	} else {
+ 		dialOptions = append(dialOptions, grpc.WithInsecure())",looks like we should drop this var from the transport options struct,Shouldn't this be t.options.clientTLSConfig |
+3288,"@@ -721,17 +721,6 @@ func TestValidateDuration(t *testing.T) {
+ 			},
+ 			errs: []*field.Error{field.Invalid(fldPath.Child(""renewBefore""), usefulDurations[""ten years""].Duration, fmt.Sprintf(""certificate duration %s must be greater than renewBefore %s"", cmapi.DefaultCertificateDuration, usefulDurations[""ten years""].Duration))},
+ 		},
+-		""default renewBefore is bigger than the set duration"": {
+-			cfg: &internalcmapi.Certificate{
+-				Spec: internalcmapi.CertificateSpec{
+-					Duration:   usefulDurations[""one hour""],
+-					CommonName: ""testcn"",
+-					SecretName: ""abc"",
+-					IssuerRef:  validIssuerRef,
+-				},
+-			},
+-			errs: []*field.Error{field.Invalid(fldPath.Child(""renewBefore""), cmapi.DefaultRenewBefore, fmt.Sprintf(""certificate duration %s must be greater than renewBefore %s"", usefulDurations[""one hour""].Duration, cmapi.DefaultRenewBefore))},
+-		},
+ 		""renewBefore is bigger than the duration"": {
+ 			cfg: &internalcmapi.Certificate{
+ 				Spec: internalcmapi.CertificateSpec{","Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation.",Why was this removed?
+3289,"@@ -21,6 +21,19 @@ def anchor_inside_flags(flat_anchors,
+                         valid_flags,
+                         img_shape,
+                         allowed_border=0):
++    """"""Check whether the anchors are inside the border
++
++    Args:
++        flat_anchors (torch.Tensor): Flatten anchors
++        valid_flags (torch.Tensor): An existing valid flags of anchors
++        img_shape (tuple(int)): Shape of current image
++        allowed_border (int, optional): The border to allow the valid anchor.
++            Defaults to 0.
++
++    Returns:
++        torch.Tensor: Flags indicating whether the anchors are inside a
++            valid range.
++    """"""
+     img_h, img_w = img_shape[:2]
+     if allowed_border >= 0:
+         inside_flags = valid_flags & \","For tensors, it is better to illustrate the shape.","nit: ""flattened"" soun"
+3290,"@@ -42,6 +42,11 @@ describe( 'Site Kit admin bar component display', () => {
+ 					status: 200,
+ 					body: JSON.stringify( mockBatchResponse[ 'modules::search-console::searchanalytics::e74216dd17533dcb67fa2d433c23467c' ] ),
+ 				} );
++			} else if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
++				request.respond( {
++					status: 200,
++					body: JSON.stringify( mockBatchResponse ),
++				} );
+ 			} else {
+ 				request.continue();
+ 			}","This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness.",Do we need the `JSON.
+3291,"@@ -127,6 +127,15 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests
+             Assert.Equal(2, activityProcessor.Invocations.Count); // begin and end was called
+             var activity = (Activity)activityProcessor.Invocations[1].Arguments[0];
+
++#if !NETCOREAPP2_1
++            // ASP.NET Core after 2.x is W3C aware and hence Activity created by it
++            // must be used.
++            Assert.Equal(""Microsoft.AspNetCore.Hosting.HttpRequestIn"", activity.OperationName);
++#else
++            // ASP.NET Core before 3.x is not W3C aware and hence Activity created by it
++            // is always ignored and new one is created by the Instrumentation
++            Assert.Equal(""ActivityCreatedByHttpInListener"", activity.OperationName);
++#endif
+             Assert.Equal(ActivityKind.Server, activity.Kind);
+             Assert.Equal(""api/Values/{id}"", activity.DisplayName);
+             Assert.Equal(""/api/values/2"", activity.GetTagValue(SpanAttributeConstants.HttpPathKey) as string);",nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural.,Can we create an issu
+3292,"@@ -486,12 +486,13 @@ func (a *Account) IsExportService(service string) bool {
+ // IsExportServiceTracking will indicate if given publish subject is an export service with tracking enabled.
+ func (a *Account) IsExportServiceTracking(service string) bool {
+ 	a.mu.RLock()
+-	defer a.mu.RUnlock()
+ 	ea, ok := a.exports.services[service]
+ 	if ok && ea == nil {
++		a.mu.RUnlock()
+ 		return false
+ 	}
+ 	if ok && ea != nil && ea.latency != nil {
++		a.mu.RUnlock()
+ 		return true
+ 	}
+ 	// FIXME(dlc) - Might want to cache this is in the hot path checking for","for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?","Same here, there is no need to re-acquire the lock."
+3293,"@@ -99,6 +99,15 @@ func (rcv *Monster) InventoryBytes() []byte {
+ 	return nil
+ }
+
++func (rcv *Monster) MutateInventory(j int, n byte) bool {
++	o := flatbuffers.UOffsetT(rcv._tab.Offset(14))
++	if o != 0 {
++		a := rcv._tab.Vector(o)
++		return rcv._tab.MutateByte(a+flatbuffers.UOffsetT(j*1), n)
++	}
++	return false
++}
++
+ func (rcv *Monster) Color() Color {
+ 	o := flatbuffers.UOffsetT(rcv._tab.Offset(16))
+ 	if o != 0 {","The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not.","Just want to know, why is this hardcoded to `14`?"
+3294,"@@ -8,6 +8,7 @@ import (
+ 	""time""
+
+ 	""github.com/filecoin-project/go-filecoin/types""
++	files ""github.com/ipfs/go-ipfs-files""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ ",nit: there should be a newline between `types` and `go-ipfs-files`.,Why is this needed?
+3295,"@@ -0,0 +1,5 @@
++package reacher
++
++var (
++	RetryAfter = &retryAfterDuration
++)","would be nice to have this as a parameter (Options), re: technical debt discussions",This doesn't look right to me. Why do we need this?
+3296,"@@ -10,10 +10,13 @@ import java.util.List;
+ import java.util.Objects;
+ import java.util.stream.Collectors;
+
++import org.apache.commons.lang3.ArrayUtils;
++
+ import net.sourceforge.pmd.PMDVersion;
+ import net.sourceforge.pmd.util.fxdesigner.app.DesignerRoot;
+ import net.sourceforge.pmd.util.fxdesigner.util.DesignerUtil;
+
++import com.sun.javafx.fxml.builder.ProxyBuilder;
+ import javafx.application.Application;
+ import javafx.collections.ObservableList;
+ import javafx.fxml.FXMLLoader;",complete ignorance here  but is it ok to import this from `com.sun`? can it break under non-oracle JREs?,I think we don't need to import this class.
+3297,"@@ -61,6 +61,13 @@ func (tr *tracer) Start(ctx context.Context, name string, o ...apitrace.SpanOpti
+ 	span := startSpanInternal(name, parent, remoteParent, opts)
+ 	span.tracer = tr
+
++	if span.IsRecordingEvents() {
++		sps, _ := spanProcessors.Load().(spanProcessorMap)
++		for sp := range sps {
++			sp.OnStart(span.data)
++		}
++	}
++
+ 	ctx, end := startExecutionTracerTask(ctx, name)
+ 	span.executionTracerTaskEnd = end
+ 	return newContext(ctx, span), span",Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() &&  )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?,I think if you use `startSpanInternal` in t
+3298,"@@ -650,6 +650,13 @@ func (c *CStorVolumeReplicaController) syncCvr(cvr *apis.CStorVolumeReplica) {
+ 	} else {
+ 		cvr.Status.Capacity = *capacity
+ 	}
++
++	err = volumereplica.GetAndUpdateSnapshotInfo(c.clientset, cvr)
++	if err != nil {
++		klog.Errorf(
++			""Unable to update snapshot list details in cvr %s status err: %v"",
++			cvr.Name, err)
++	}
+ }
+
+ func (c *CStorVolumeReplicaController) reconcileVersion(cvr *apis.CStorVolumeReplica) (",just calling UpdateSnapshotInfo() should be fine,should we also log the error if there is an
+3299,"@@ -156,8 +156,8 @@ namespace Datadog.Trace.Logging
+                 return rate;
+             }
+
+-            // We don't want to rate limit messages by default when in debug mode
+-            return GlobalSettings.Source.DebugEnabled ? 0 : DefaultLogMessageRateLimit;
++            // By default, we don't rate limit log messages;
++            return 0;
+         }
+
+         private static string GetLogDirectory()",Was `DefaultLogMessageRateLimit` not configurable anywhere?,Doesn't this mean that messages sent to the
+3300,"@@ -167,6 +167,19 @@ func TestPullImageGlobalTimeout(t *testing.T) {
+ 	wait.Done()
+ }
+
++func TestPullImageInactivityTimeout(t *testing.T) {
++	mockDocker, client, testTime, _, _, done := dockerClientSetup(t)
++	defer done()
++
++	testTime.EXPECT().After(gomock.Any()).AnyTimes()
++	mockDocker.EXPECT().PullImage(&pullImageOptsMatcher{""image:latest""}, gomock.Any()).Return(
++		docker.ErrInactivityTimeout).Times(maximumPullRetries) // expected number of retries
++
++	metadata := client.PullImage(""image"", nil)
++	assert.Error(t, metadata.Error, ""Expected error for pull inactivity timeout"")
++	assert.Equal(t, ""CannotPullContainerError"", metadata.Error.(api.NamedError).ErrorName(), ""Wrong error type"")
++}
++
+ func TestPullImage(t *testing.T) {
+ 	mockDocker, client, testTime, _, _, done := dockerClientSetup(t)
+ 	defer done()",Please use the `assert` instead. Same below.,You can use `assert.Error()` here
+3301,"@@ -18,6 +18,7 @@ return array(
+     'A currency with code ""%name"" already exists.' => 'A currency with code ""%name"" already exists.',
+     'A descriptive title' => 'A descriptive title',
+     'A message with name ""%name"" already exists.' => 'A message with name ""%name"" already exists.',
++    'A name suche as Europe or Overseas' => 'A name suche as Europe or Overseas',
+     'A product with reference %ref already exists. Please choose another reference.' => 'A product with reference %ref already exists. Please choose another reference.',
+     'A short description, used when a summary or an introduction is required' => 'A short description, used when a summary or an introduction is required',
+     'A short text, used when an additional or supplemental information is required.' => 'A short text, used when an additional or supplemental information is required.',","Owww, I think I found a typo. `suche`",There's an extra comma at the end
+3302,"@@ -131,8 +131,6 @@ void search(SearchEngineData<Algorithm> &engine_working_data,
+                                     source_phantom.GetReverseWeightPlusOffset(),
+                                 source_phantom.reverse_segment_id.id);
+         }
+-        BOOST_ASSERT(forward_heap.Size() > 0);
+-        BOOST_ASSERT(reverse_heap.Size() > 0);
+
+         search(engine_working_data,
+                facade,",This can happen because we could get `PhantomNodes` that are not admissible as source/target right?,Isn't this assert now redundant?
+3303,"@@ -19,6 +19,9 @@ func init() {
+ 	if !structsEqual(&tls.ClientSessionState{}, &qtls.ClientSessionState{}) {
+ 		panic(""qtls.ClientSessionState not compatible with tls.ClientSessionState"")
+ 	}
++	if !structsEqual(&tls.ClientSessionState{}, &clientSessionState{}) {
++		panic(""clientSessionState not compatible with tls.ClientSessionState"")
++	}
+ }
+
+ func structsEqual(a, b interface{}) bool {",Should we add a note here to file a bug if this ever happens?,Why is this needed?
+3304,"@@ -455,7 +455,14 @@ func (api *BasicMarketAPI) GetDealChangeRequestInfo(ctx context.Context, dealID
+ }
+
+ func (api *BasicMarketAPI) GetNumBenchmarks(ctx context.Context) (int, error) {
+-	return NumCurrentBenchmarks, nil
++	num, err := api.marketContract.GetBenchmarksQuantity(getCallOptions(ctx))
++	if err != nil {
++		return 0, err
++	}
++	if !num.IsInt64() {
++		return 0, errors.New(""benchmarks quantity overflows int64"")
++	}
++	return int(num.Int64()), nil
+ }
+
+ type ProfileRegistry struct {","overflow is still possible, isn't it?","""benchmarks quantity overflows int64"""
+3305,"@@ -37,6 +37,9 @@ RSpec.configure do |config|
+   config.use_transactional_fixtures = false
+   config.use_instantiated_fixtures  = false
+   config.fixture_path = ""#{::Rails.root}/spec/fixtures""
++  config.infer_base_class_for_anonymous_controllers = false
++  config.order = ""random""
++  config.fail_fast = true
+
+   config.include Paperclip::Shoulda::Matchers
+   config.include EmailSpec::Helpers","This seems more like a personal preference, so maybe this should be in your `~/.rspec`?",Prefer single-quoted strings when you
+3306,"@@ -31,8 +31,8 @@ else:
+     THREAD_EXCEPTION = thread.error
+
+ if WINDOWS:
+-    from scapy.arch.pcapdnet import PcapTimeoutElapsed
+-    recv_error = PcapTimeoutElapsed
++    from scapy.error import Scapy_Exception
++    recv_error = Scapy_Exception
+ else:
+     recv_error = ()
+ ",To avoid a circular import between pcapdnet and automaton,We don't need `from scapy.error impor
+3307,"@@ -1490,8 +1490,7 @@ class CommandDispatcher:
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+     def view_source(self):
+         """"""Show the source of the current page in a new tab.""""""
+-        # pylint: disable=no-member
+-        # WORKAROUND for https://bitbucket.org/logilab/pylint/issue/491/
++
+         tab = self._current_widget()
+         if tab.data.viewing_source:
+             raise cmdexc.CommandError(""Already viewing source!"")",Please remove this blank line.,@jvillalobos can you please re-enable
+3308,"@@ -70,6 +70,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, s *v1alpha1.CloudAuditLo
+ 	ctx = logging.WithLogger(ctx, c.Logger.With(zap.Any(""auditlogsource"", s)))
+
+ 	s.Status.InitializeConditions()
++	s.Status.WorkloadIdentityStatus.InitWorkloadIdentityStatus()
+ 	s.Status.ObservedGeneration = s.Generation
+
+ 	// If GCP ServiceAccount is provided, reconcile workload identity.","it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though",Why not do this in `InitializeWorkloadIdentityStatus`?
+3309,"@@ -1681,6 +1681,16 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+                 }
+             }
+         }
++
++        auto provoking_vertex_state_ci = lvl_find_in_chain<VkPipelineRasterizationProvokingVertexStateCreateInfoEXT>(
++            pPipeline->graphicsPipelineCI.pRasterizationState->pNext);
++        if (provoking_vertex_state_ci &&
++            provoking_vertex_state_ci->provokingVertexMode == VK_PROVOKING_VERTEX_MODE_LAST_VERTEX_EXT &&
++            !enabled_features.provoking_vertex_features.provokingVertexLast) {
++            skip |= LogError(
++                device, ""VUID-VkPipelineRasterizationProvokingVertexStateCreateInfoEXT-provokingVertexMode-04883"",
++                ""provokingVertexLast feature is not enabled."");
++        }
+     }
+
+     if ((pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT) && !pPipeline->graphicsPipelineCI.pVertexInputState) {",I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility.,It would be better to use `enabled_features.provoking_
+3310,"@@ -50,6 +50,7 @@ def _column_op(f):
+     :param self: Koalas Series
+     :param args: arguments that the function `f` takes.
+     """"""
++
+     @wraps(f)
+     def wrapper(self, *args):
+         assert all((not isinstance(arg, Series)) or (arg._kdf is self._kdf) for arg in args), \","It's fine for this PR, but in the future try to minimize unrelated changes.",Let's revert this whitespace change to keep the diff a
+3311,"@@ -202,11 +202,11 @@ class Ansible(base.Base):
+     ::
+
+         ANSIBLE_ROLES_PATH:
+-          $ephemeral_directory/roles/:$project_directory/../
++          $ephemeral_directory/roles/:$project_directory/../:$HOME/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles
+         ANSIBLE_LIBRARY:
+-          $ephemeral_directory/library/:$project_directory/library/
++          $ephemeral_directory/modules/:$project_directory/library/:$HOME/.ansible/plugins/modules:/usr/share/ansible/plugins/modules
+         ANSIBLE_FILTER_PLUGINS:
+-          $ephemeral_directory/plugins/filters/:$project_directory/filter/plugins/
++          $ephemeral_directory/plugins/filter/:$project_directory/filter/plugins/:$HOME/.ansible/plugins/filter:/usr/share/ansible/plugins/modules
+
+     Environment variables can be passed to the provisioner.  Variables in this
+     section which match the names above will be appened to the above defaults,",The library -> modules and filters -> filter path changes are breaking changes or?,What's the difference between `$$HOME/.ansible/plugins
+3312,"@@ -1,6 +1,9 @@
+ import logging
++import os
+ from typing import TYPE_CHECKING
+
++import boto3
++import botocore.config
+ import pytest
+
+ from localstack.utils.aws import aws_stack","Can we encapsulate this check (`os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD""`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)",Nit: is this used?
+3313,"@@ -22,7 +22,9 @@ export function h(nodeName, attributes) {
+ 	}
+ 	while (stack.length) {
+ 		if ((child = stack.pop()) && child.pop!==undefined) {
+-			for (i=child.length; i--; ) stack.push(child[i]);
++			[].concat(child).reverse().forEach((item) => {
++				stack.push(item);
++			});
+ 		}
+ 		else {
+ 			if (child===true || child===false) child = null;","An `if` statement would be better here. Functions, concat and reverse are all very expensive.",I am a bit confuse
+3314,"@@ -156,3 +156,12 @@ func (c *factory) ERC20Address(ctx context.Context) (common.Address, error) {
+ 	}
+ 	return erc20Address, nil
+ }
++
++// DiscoverFactoryAddress returns the canonical factory for this chainID
++func DiscoverFactoryAddress(chainID int64) (common.Address, bool) {
++	if chainID == 5 {
++		// goerli
++		return common.HexToAddress(""0x334394E8c891E77b1449084aaDD659920BB25247""), true
++	}
++	return common.Address{}, false
++}",`Log here: connect to default factory for goerli network <address>`,Where is this func
+3315,"@@ -125,9 +125,11 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+
+ 	var approvers []string
+
+-	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+-		if v.Event == ""DEPLOYMENT_WAIT_APPROVAL"" {
+-			approvers = v.Slack
++	if ds.GenericDeploymentConfig.DeploymentNotification != nil {
++		for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
++			if e := ""EVENT_"" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {
++				approvers = v.Slack
++			}
+ 		}
+ 	}
+ ","nits, should add `break` to avoid redundant iterations.",@smarterclayton wh
+3316,"@@ -56,6 +56,15 @@ namespace Nethermind.Store.Test
+             provider.Commit(SpuriousDragon.Instance);
+             Assert.False(provider.AccountExists(_address1));
+         }
++
++        [Test]
++        public void Eip_158_account_dont_exists_after_zero_value_transfer()
++        {
++            ISnapshotableDb stateDb = new StateDb(new MemDb());
++            StateProvider provider = new StateProvider(stateDb, Substitute.For<IDb>(), Logger);
++            provider.AddToBalance(_address1, 0, SpuriousDragon.Instance);
++            provider.AccountExists(_address1).Should().BeFalse();
++        }
+
+         [Test]
+         public void Eip_158_touch_zero_value_system_account_is_not_deleted()","I think we want an exception here, there should never be a transfer to a nonexisting account.",Please don't use the `Should` extension method.
+3317,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users.",Did you mean to leave this at info?
+3318,"@@ -79,11 +79,11 @@ class TestSklearn(unittest.TestCase):
+                                          '../../examples/lambdarank/rank.test.query'))
+         gbm = lgb.LGBMRanker()
+         gbm.fit(X_train, y_train, group=q_train, eval_set=[(X_test, y_test)],
+-                eval_group=[q_test], eval_at=[1, 3], early_stopping_rounds=5, verbose=False,
+-                callbacks=[lgb.reset_parameter(learning_rate=lambda x: 0.95 ** x * 0.1)])
+-        self.assertLessEqual(gbm.best_iteration_, 12)
+-        self.assertGreater(gbm.best_score_['valid_0']['ndcg@1'], 0.6173)
+-        self.assertGreater(gbm.best_score_['valid_0']['ndcg@3'], 0.6479)
++                eval_group=[q_test], eval_at=[1, 3], early_stopping_rounds=10, verbose=False,
++                callbacks=[lgb.reset_parameter(learning_rate=lambda x: max(0.01, 0.1 - 0.01 * x))])
++        self.assertLessEqual(gbm.best_iteration_, 25)
++        self.assertGreater(gbm.best_score_['valid_0']['ndcg@1'], 0.60)
++        self.assertGreater(gbm.best_score_['valid_0']['ndcg@3'], 0.60)
+
+     def test_regression_with_custom_objective(self):
+         def objective_ls(y_true, y_pred):",Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`.,Can you explain why this change is needed? It s
+3319,"@@ -87,6 +87,10 @@ module Bolt
+         impl
+       end
+
++      def select_interpreter(executable, interpreters)
++        interpreters[Pathname(executable).extname] if interpreters
++      end
++
+       def reject_transport_options(target, options)
+         if target.options['run-as']
+           options.reject { |k, _v| k == '_run_as' }","I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much ""magic""? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?",There should probably be a spec for this as wel
+3320,"@@ -1235,12 +1235,15 @@ ostree_sysroot_get_subbootversion (OstreeSysroot   *self)
+  * ostree_sysroot_get_booted_deployment:
+  * @self: Sysroot
+  *
++ * This function may only be called if the sysroot is loaded.
++ *
+  * Returns: (transfer none) (nullable): The currently booted deployment, or %NULL if none
+  */
+ OstreeDeployment *
+ ostree_sysroot_get_booted_deployment (OstreeSysroot       *self)
+ {
+-  g_return_val_if_fail (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED, NULL);
++  g_assert (self);
++  g_assert (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED);
+
+   return self->booted_deployment;
+ }","In this and the one below, should we assert `self != NULL` first?",This assert is redundant given the assert above. I'd remove it.
+3321,"@@ -147,7 +147,7 @@ class GalleryControllerTest extends \PHPUnit_Framework_TestCase
+         $view = $galleryController->postGalleryMediaGalleryhasmediaAction(1, 2, new Request());
+
+         $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
+-        $this->assertSame(200, $view->getStatusCode(), 'Should return 200');
++        $this->assertSame(200, $view->getResponse()->getStatusCode(), 'Should return 200');
+     }
+
+     public function testPostGalleryMediaGalleryhasmediaInvalidAction()",Why this is needed?,I don't understand why this change is needed.
+3322,"@@ -149,6 +149,12 @@ class PackageEntry:
+         """"""
+         self._meta['user_meta'] = meta
+
++    def get_meta(self):
++        """"""
++        Gets the user_meta for this PackageEntry.
++        """"""
++        return self.meta or None
++
+     def _verify_hash(self, read_bytes):
+         """"""
+         Verifies hash of bytes",we already have .meta() so I don't think we want get_meta() for PackageEntry,Why is this needed? When would `meta` ever be `None`?
+3323,"@@ -83,7 +83,8 @@ public abstract class CoprocessorIterator<T> implements Iterator<T> {
+         session,
+         SchemaInfer.create(dagRequest),
+         dagRequest.getPushDownType(),
+-        dagRequest.getStoreType()) {
++        dagRequest.getStoreType(),
++        dagRequest.getStartTs().getVersion()) {
+       @Override
+       public Row next() {
+         return rowReader.readRow(schemaInfer.getTypes().toArray(new DataType[0]));",question: can we always get the startts from dagrequest?,Can we just use the start ts in the dagRequest rather than intr
+3324,"@@ -114,9 +114,11 @@ describe( 'AccountSelect', () => {
+ 	it( 'should pre-select the property and profile IDs when changed', () => {
+ 		const { accounts, properties, profiles } = fixtures.accountsPropertiesProfiles;
+ 		const { getByText, container, registry } = render( <AccountSelect />, { setupRegistry } );
++		const propertyID = fixtures.accountsPropertiesProfiles.properties[ 0 ].id;
++		const accountID = fixtures.accountsPropertiesProfiles.properties[ 0 ].accountId;
+
+-		registry.dispatch( STORE_NAME ).receiveProperties( properties );
+-		registry.dispatch( STORE_NAME ).receiveProfiles( profiles );
++		registry.dispatch( STORE_NAME ).receiveProperties( properties, { accountID } );
++		registry.dispatch( STORE_NAME ).receiveProfiles( profiles, { propertyID } );
+
+ 		// Click the label to expose the elements in the menu.
+ 		fireEvent.click( container.querySelector( '.mdc-floating-label' ) );","Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above.",@jhipster/developers this looks good to me. but I am wondering if we need to pass `accountID` as a prop to the `AccountSelect` component since the store name is already part of the props and we pass that prop to the `AccountSelect` component.
+3325,"@@ -142,6 +142,10 @@ module Bolt
+         @unresolved_targets[t_name] = target
+       end
+
++      def remove_target(target)
++        @resolved_targets.delete(target.name)
++      end
++
+       def add_target(target)
+         @resolved_targets[target.name] = { 'name' => target.name }
+       end","This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?",I think you can just do `@resolved_targets[target.name] = target` instead of adding a new method.
+3326,"@@ -200,7 +200,7 @@ public abstract class AbstractCallOperation extends AbstractOperation {
+               .sender(sender(frame))
+               .value(value(frame))
+               .apparentValue(apparentValue(frame))
+-              .code(new Code(contract != null ? contract.getCode() : Bytes.EMPTY))
++              .code(frame.getWorldState().getContract(contract).orElse(new Code()))
+               .blockHeader(frame.getBlockHeader())
+               .depth(frame.getMessageStackDepth() + 1)
+               .isStatic(isStatic(frame))",So what happens if I try to get code on a EOA?,"This will create a new `Code` if the contract does not exist, right? Is that intended?"
+3327,"@@ -2400,15 +2400,8 @@ class VariablesChecker(BaseChecker):
+             return
+
+         # Attempt to check unpacking is properly balanced
+-        values: Optional[List] = None
+-        if isinstance(inferred, (nodes.Tuple, nodes.List)):
+-            values = inferred.itered()
+-        elif isinstance(inferred, astroid.Instance) and any(
+-            ancestor.qname() == ""typing.NamedTuple"" for ancestor in inferred.ancestors()
+-        ):
+-            values = [i for i in inferred.values() if isinstance(i, nodes.AssignName)]
+-
+-        if values:
++        values = self._get_values_to_unpack(inferred)
++        if values is not None:
+             if len(targets) != len(values):
+                 # Check if we have starred nodes.
+                 if any(isinstance(target, nodes.Starred) for target in targets):",Can't we return an empty list and then just compare the lengths? Thereby removing this `if`.,"Move this check inside _get_values_to_unpack, since it's not specific to unpacking any more."
+3328,"@@ -151,6 +151,7 @@ class Uppy {
+     this.addFile = this.addFile.bind(this)
+     this.removeFile = this.removeFile.bind(this)
+     this.pauseResume = this.pauseResume.bind(this)
++    this.passesRestrictions = this.passesRestrictions.bind(this)
+
+     // ___Why throttle at 500ms?
+     //    - We must throttle at >250ms for superfocus in Dashboard to work well (because animation takes 0.25s, and we want to wait for all animations to be over before refocusing).",Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me.,Why pass a bind to this object instead of just assigning it directly?
+3329,"@@ -17,7 +17,7 @@ import (
+
+ // Lookup is the interface for time based feed lookup
+ type Lookup interface {
+-	At(ctx context.Context, at, after int64) (swarm.Chunk, error)
++	At(ctx context.Context, at, after int64) (chunk swarm.Chunk, currentIndex, nextIndex Index, err error)
+ }
+
+ // Getter encapsulates a chunk Getter getter and a feed and provides",TODO: in fact At when used with noncurrent time should not return a next index. only latest should..,Shouldn't this also take a context?
+3330,"@@ -165,7 +165,11 @@ export function diff(
+ 			tmp = c.render(c.props, c.state, c.context);
+ 			let isTopLevelFragment =
+ 				tmp != null && tmp.type == Fragment && tmp.key == null;
+-			newVNode._children = isTopLevelFragment ? tmp.props.children : tmp;
++			newVNode._children = isTopLevelFragment
++				? tmp.props.children
++				: Array.isArray(tmp)
++				? tmp
++				: [tmp];
+
+ 			if (c.getChildContext != null) {
+ 				context = assign(assign({}, context), c.getChildContext());","There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it","`tmp` is not an array here, is it?"
+3331,"@@ -33,8 +33,7 @@ import javaslang.match.annotation.Patterns;
+     // -- javaslang.collection
+
+     // List
+-    @Unapply static <T> Tuple2<T, List<T>> List(List.Cons<T> cons) { return Tuple.of(cons.head(), cons.tail()); }
+-    @Unapply static <T> Tuple0 List(List.Nil<T> nil) { return Tuple.empty(); }
++    @Unapply static <T> Tuple2<T, List<T>> List(List<T> cons) { return Tuple.of(cons.head(), cons.tail()); }
+
+     // Stream
+     @Unapply static <T> Tuple2<T, Stream<T>> Stream(Stream.Cons<T> cons) { return Tuple.of(cons.head(), cons.tail()); }","@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p",Is the change from `Tuple0` to `Tuple` intentional?
+3332,"@@ -22,7 +22,7 @@
+ *  This copyright notice MUST APPEAR in all copies of the script!
+ ***************************************************************/
+ use TYPO3\CMS\Core\Utility\GeneralUtility;
+-
++use ApacheSolrForTypo3\Solr\Facet\Facet;
+ /**
+  * Query group facet renderer.
+  *",Please leave two empty lines after the `use` statement,Please remove this empty line.
+3333,"@@ -27,6 +27,7 @@ import (
+ 	""bytes""
+ 	""fmt""
+ 	""io/ioutil""
++	""k8s.io/kubernetes/pkg/kubelet/cm""
+ 	""os""
+ 	""path""
+ 	""path/filepath""",Please move this import in the 3rd group which is for external dependencies,Can you move this to the top w
+3334,"@@ -63,7 +63,7 @@ def _path_hash(path, transform, kwargs):
+     return digest_string(srcinfo)
+
+ def _is_internal_node(node):
+-    is_leaf = not node or node.get(RESERVED['file'])
++    is_leaf = not node or isinstance(node.get(RESERVED['file']), str)
+     return not is_leaf
+
+ def _pythonize_name(name):",So what exactly is this fixing? The unit test is passing with or without this change.,`node.get(RESERVED['file'])` i
+3335,"@@ -601,8 +601,18 @@ bool FileBasedWal::linkCurrentWAL(const char* newPath) {
+         LOG(INFO) << idStr_ << ""Create link failed, there is no wal files!"";
+         return false;
+     }
++    if (!fs::FileUtils::makeDir(newPath)) {
++        LOG(INFO) << idStr_ << ""Link file parent dir make failed : "" << newPath;
++        return false;
++    }
++
+     auto it = walFiles_.rbegin();
+-    if (link(it->second->path(), newPath) != 0) {
++
++    // Using the original wal file name.
++    auto targetFile = folly::stringPrintf(""%s/%s"", newPath,
++            it->second->path() + std::string(it->second->path()).rfind('/') + 1);
++
++    if (link(it->second->path(), targetFile.data()) != 0) {
+         LOG(INFO) << idStr_ << ""Create link failed for "" << it->second->path()
+                   << "" on "" << newPath << "", error:"" << strerror(errno);
+         return false;","auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(""%019ld.wal"", it->first));",Do we want this to be `VLOG(1)
+3336,"@@ -42,6 +42,16 @@ public class SnapshotUtil {
+     return ancestorIds(table.currentSnapshot(), table::snapshot);
+   }
+
++  /**
++   * @return List of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
++   * This method assumes that fromSnapshotId is an ancestor of toSnapshotId
++   */
++  public static List<Long> snapshotIdsBetween(Table table, long fromSnapshotId, long toSnapshotId) {
++    List<Long> snapshotIds = Lists.newArrayList(ancestorIds(table.snapshot(toSnapshotId),
++        snapshotId -> snapshotId != fromSnapshotId ? table.snapshot(snapshotId) : null));
++    return snapshotIds;
++  }
++
+   public static List<Long> ancestorIds(Snapshot snapshot, Function<Long, Snapshot> lookup) {
+     List<Long> ancestorIds = Lists.newArrayList();
+     Snapshot current = snapshot;",I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me.,"`fromSnapshotId` and `toSnapshotId` are hard to understand for me. How about something like `snapshotIdsBetween(Table table, long fromSnapshotId, long toSnapshotId)`?"
+3337,"@@ -367,11 +367,10 @@ class Connection implements TranslatorAwareInterface, LoggerAwareInterface
+                     explode(':', $functionConfig['updateFields'])
+                 );
+             }
+-            if (isset($functionConfig['helpText'])) {
+-                $response['helpText'] = $this->getHelpText(
+-                    $functionConfig['helpText']
+-                );
+-            }
++            $response['helpText']
++                = $this->getHelpText($functionConfig['helpText'] ?? '');
++            $response['updateHelpText']
++                = $this->getHelpText($functionConfig['updateHelpText'] ?? '');
+             if (isset($functionConfig['consortium'])) {
+                 $response['consortium'] = $functionConfig['consortium'];
+             }","Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?",Are you sure about this change? Isn't it a breaking change?
+3338,"@@ -17,7 +17,7 @@ module RSpec
+       # @param [IO] out
+       def run(err, out)
+         @configuration.error_stream = err
+-        @configuration.output_stream ||= out
++        @configuration.output_stream = out
+         @options.configure(@configuration)
+         @configuration.load_spec_files
+         @world.announce_filters","Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it....",This change seems unrelated to the rest of the PR.
+3339,"@@ -4,6 +4,7 @@ class Proposal < ActiveRecord::Base
+   workflow_column :status
+
+   has_one :cart
++  belongs_to :clientdata, polymorphic: true
+
+   validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
+ ",Thinking this should have an underscore.,Rails/InverseOf: Specify an :inverse_of option.
+3340,"@@ -316,14 +316,14 @@ def test_message_state_scope(init_linter: PyLinter) -> None:
+
+     linter = init_linter
+     linter.disable(""C0202"")
+-    assert MSG_STATE_SCOPE_CONFIG == linter.get_message_state_scope(""C0202"")
++    assert MSG_STATE_SCOPE_CONFIG == linter._get_message_state_scope(""C0202"")
+     linter.disable(""W0101"", scope=""module"", line=3)
+-    assert MSG_STATE_SCOPE_CONFIG == linter.get_message_state_scope(""C0202"")
+-    assert MSG_STATE_SCOPE_MODULE == linter.get_message_state_scope(""W0101"", 3)
++    assert MSG_STATE_SCOPE_CONFIG == linter._get_message_state_scope(""C0202"")
++    assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(""W0101"", 3)
+     linter.enable(""W0102"", scope=""module"", line=3)
+-    assert MSG_STATE_SCOPE_MODULE == linter.get_message_state_scope(""W0102"", 3)
++    assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(""W0102"", 3)
+     linter.config = FakeConfig()
+-    assert MSG_STATE_CONFIDENCE == linter.get_message_state_scope(
++    assert MSG_STATE_CONFIDENCE == linter._get_message_state_scope(
+         ""this-is-bad"", confidence=interfaces.INFERENCE
+     )
+ ",To accommodate the change to the method being private.,Please also update `get_message_state_scope` to call `_get_message_state_scope`.
+3341,"@@ -90,6 +90,7 @@ namespace AutoRest.Swagger.Model
+         [CollectionRule(typeof(BodyTopLevelProperties))]
+         [CollectionRule(typeof(HttpVerbValidation))]
+         [CollectionRule(typeof(DeleteMustHaveEmptyRequestBody))]
++        [CollectionRule(typeof(PropertiesNamesCamelCase))]
+         public Dictionary<string, Dictionary<string, Operation>> Paths { get; set; }
+
+         /// <summary>",Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc,This is a breaking change. I don't think we can make breaking changes like this
+3342,"@@ -0,0 +1,11 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.design;
++
++import net.sourceforge.pmd.testframework.PmdRuleTst;
++
++public class MutableStaticState extends PmdRuleTst {
++    // no additional unit tests
++}","Please rename this class that it ends with the suffix ""Test"" - otherwise the tests won't be executed.","If there are no unit tests here, can we remove this file?"
+3343,"@@ -0,0 +1,7 @@
++// This file is here, in part, so that users whose code editors are
++// set to automatically format files with Prettier have a config to detect.
++// Many users only run Prettier when a config is present, so this file makes
++// sure one can be detected, even though we aren't doing anything with it.
++module.exports = {
++	...require('@wordpress/prettier-config'),
++}","As a JS file, this should also receive our standard file header.",I think this should be `@wordpress/prettier`.
+3344,"@@ -1784,7 +1784,9 @@ short HashJoin::codeGen(Generator * generator) {
+   UInt16 numBMOsInFrag = (UInt16)generator->getFragmentDir()->getNumBMOs();
+
+   double memQuota = 0;
+-
++  double memQuotaRatio;
++  Lng32 numStreams;
++  double bmoMemoryUsagePerNode = getEstimatedRunTimeMemoryUsage(TRUE, &numStreams).value();
+   if (mmu != 0) {
+     memQuota = mmu;
+     hashj_tdb->setMemoryQuotaMB(mmu);","I take it memQuotaRatio is an ""out"" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case.",Wouldn't it be better to just use `ESTimatedRunTimeMemoryUsage`?
+3345,"@@ -49,7 +49,6 @@ func NewPullSubscription(name, namespace string, so ...PullSubscriptionOption) *
+ 	for _, opt := range so {
+ 		opt(s)
+ 	}
+-	s.SetDefaults(gcpauthtesthelper.ContextWithDefaults())
+ 	return s
+ }
+ ","It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions.",why is this removed?
+3346,"@@ -186,6 +186,13 @@ type AssetParams struct {
+ 	// created.
+ 	Total uint64 `codec:""t""`
+
++	// Decimals specifies the number of digits to display after the decimal
++	// place when displaying this asset. A value of 0 represents an asset
++	// that is not divisible, a value of 1 represents an asset divisible
++	// into tenths, and so on. This value must be between 0 and 19
++	// (inclusive).
++	Decimals uint32 `codec:""dc""`
++
+ 	// DefaultFrozen specifies whether slots for this asset
+ 	// in user accounts are frozen by default or not.
+ 	DefaultFrozen bool `codec:""df""`","not dramatic, but why 32bits if we allow a range that is smaller than 8?",It might be worth adding a note that this value must be between
+3347,"@@ -0,0 +1,8 @@
++package dto
++
++type ClientPromise struct {
++	SerialNumber int
++	IssuerId int
++	BenefiterId int
++	Amount int
++}",- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`,I don't see where this is being used. Are you planning to use th
+3348,"@@ -193,6 +193,18 @@ public abstract class Either<L, R> implements io.vavr.Iterable<R>, io.vavr.Value
+     /**
+      * Maps either the left or the right side of this disjunction.
+      *
++     * <pre>{@code
++     *Either<?, AtomicInteger> success = Either.right(new AtomicInteger(42));
++     *
++     * //prints ""Right(42)""
++     * System.out.println(success.bimap(Function1.identity(), AtomicInteger::get));
++     *
++     * Either<Exception, ?> failure = Either.left(new Exception(""error""));
++     *
++     * //prints ""Left(error)""
++     * System.out.println(failure.bimap(Exception::getMessage, Function1.identity()));
++     * }</pre>
++     *
+      * @param leftMapper  maps the left value if this is a Left
+      * @param rightMapper maps the right value if this is a Right
+      * @param <X>         The new left type of the resulting Either",one space missing at the beginning,I would remove the first `<pre>` and last `</pre>`
+3349,"@@ -43,8 +43,9 @@ type RequestDrivenWebServiceProps struct {
+
+ // AppRunnerInstanceConfig contains the instance configuration properties for an App Runner service.
+ type AppRunnerInstanceConfig struct {
+-	CPU    *int `yaml:""cpu""`
+-	Memory *int `yaml:""memory""`
++	CPU      *int   `yaml:""cpu""`
++	Memory   *int   `yaml:""memory""`
++	Platform string `yaml:""platform,omitempty""`
+ }
+
+ // NewRequestDrivenWebService creates a new Request-Driven Web Service manifest with default values.","I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `""""` if the environment manifest config doesn't specify `platform`   . If it gets overridden as `""""`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!  ",Is there a reason why we don't just call it `Platf
+3350,"@@ -26,7 +26,10 @@ exports = module.exports = function(grunt, options) {
+ 					'http://' + host + ':<%= connect.test.options.port %>/test/commons/',
+ 					'http://' +
+ 						host +
+-						':<%= connect.test.options.port %>/test/integration/rules/'
++						':<%= connect.test.options.port %>/test/integration/rules/',
++					'http://' +
++						host +
++						':<%= connect.test.options.port %>/test/integration/api/external/'
+ 				],
+ 				run: true,
+ 				growlOnSuccess: false,","I like the new directory `/api`, what is the thinking behind `/external`?",shouldn't this be `http://' + host + ':' + connect
+3351,"@@ -2844,11 +2844,10 @@ func (s *Server) updateAccountClaimsWithRefresh(a *Account, ac *jwt.AccountClaim
+ 	// update account signing keys
+ 	a.signingKeys = nil
+ 	signersChanged := false
+-	if len(ac.SigningKeys) > 0 {
+-		// insure copy the new keys and sort
+-		a.signingKeys = append(a.signingKeys, ac.SigningKeys...)
+-		sort.Strings(a.signingKeys)
++	for k, _ := range ac.SigningKeys {
++		a.signingKeys = append(a.signingKeys, k)
+ 	}
++	sort.Strings(a.signingKeys)
+ 	if len(a.signingKeys) != len(old.signingKeys) {
+ 		signersChanged = true
+ 	} else {",staticcheck flags this: replace with `for k := ..`,Why is this change necessary?
+3352,"@@ -132,8 +132,8 @@ def GMLAN_InitDiagnostics(
+         p = GMLAN() / GMLAN_PM(subfunction=""enableProgrammingMode"")
+         if verbose:
+             print(""Sending %s"" % repr(p))
+-        sock.send(p)
+         time.sleep(0.05)
++        sock.sr1(p, timeout=0.001, verbose=False)
+         return True
+     return False
+ ",There's already a sleep right above,why this change? `send` doesn't do anything?
+3353,"@@ -1249,9 +1249,16 @@ class AssertionFinder
+                         $if_types[$var_id] = [[$assertion->rule[0][0]]];
+                     }
+                 } elseif (\is_string($assertion->var_id)
+-                    && $expr instanceof PhpParser\Node\Expr\MethodCall
++                    && (
++                        $expr instanceof PhpParser\Node\Expr\MethodCall
++                        || $expr instanceof PhpParser\Node\Expr\StaticCall
++                    )
+                 ) {
+-                    $if_types[$assertion->var_id] = [[$assertion->rule[0][0]]];
++                    $var_id = $assertion->var_id;
++                    if (strpos($var_id, 'self::') === 0) {
++                        $var_id = $this_class_name . '::' . substr($var_id, 6);
++                    }
++                    $if_types[$var_id] = [[$assertion->rule[0][0]]];
+                 }
+
+                 if ($if_types) {","This feels hacky, is there a better way?",Any reason why you moved this code block up?
+3354,"@@ -22,9 +22,14 @@
+ # IN THE SOFTWARE.
+ #
+ from math import ceil
+-from boto.compat import json, map, six
++from boto.compat import json, six
+ import requests
+
++try:
++    from collections import OrderedDict
++except ImportError:
++    from ordereddict import OrderedDict
++
+
+ class SearchServiceException(Exception):
+     pass","Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break.",Why `collections.OrderedDict` instead of `co
+3355,"@@ -36,14 +36,14 @@ namespace Fixtures.Azure.AcceptanceTestsAzureBodyDuration
+         public Uri BaseUri { get; set; }
+
+         /// <summary>
+-        /// Gets or sets json serialization settings.
++        /// Gets JSON serialization settings.
+         /// </summary>
+         public JsonSerializerSettings SerializationSettings { get; private set; }
+
+         /// <summary>
+-        /// Gets or sets json deserialization settings.
++        /// Gets JSON deserialization settings.
+         /// </summary>
+-        public JsonSerializerSettings DeserializationSettings { get; private set; }
++        public JsonSerializerSettings DeserializationSettings { get; private set; }
+
+         /// <summary>
+         /// Gets Azure subscription credentials.","""Gets the JSON serialization settings."" would be better?",The summary should also be updated.
+3356,"@@ -38,6 +38,15 @@ func (s *server) setupRouting() {
+ 	handle(router, ""/bytes"", jsonhttp.MethodHandler{
+ 		""POST"": http.HandlerFunc(s.bytesUploadHandler),
+ 	})
++
++	handle(router, ""/file"", jsonhttp.MethodHandler{
++		""POST"": http.HandlerFunc(s.bzzFileUploadHandler),
++	})
++
++	handle(router, ""/file/{addr}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.bzzFileDownloadHandler),
++	})
++
+ 	handle(router, ""/bytes/{address}"", jsonhttp.MethodHandler{
+ 		""GET"": http.HandlerFunc(s.bytesGetHandler),
+ 	})",The endpoint should be in plural `/files`.,Should the path be `/file/{addr}`?
+3357,"@@ -141,6 +141,9 @@ AtomPDBResidueInfo *AtomGetPDBResidueInfo(Atom *atom) {
+   return (AtomPDBResidueInfo *)res;
+ }
+
++struct MDLDummy {};
++struct DaylightDummy {};
++
+ // FIX: is there any reason at all to not just prevent the construction of
+ // Atoms?
+ std::string atomClassDoc =","??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go.",Make these `const` since they shou
+3358,"@@ -40,7 +40,7 @@ func InitContext(contextType string) {
+ 	})
+ }
+
+-func GetContext() gocontext.Context{
++func GetContext() gocontext.Context {
+ 	return context.ctx
+ }
+ func Done() <-chan struct{} {",I think this line is gofmt issue? @daixiang0,This seems unrelated to the rest o
+3359,"@@ -94,6 +94,16 @@ func TestSubrepoLabel(t *testing.T) {
+ 	assert.EqualValues(t, BuildLabel{PackageName: """", Name: """"}, label.SubrepoLabel())
+ }
+
++func TestParseBuildLabelParts(t *testing.T) {
++	target1 := ""@unittest_cpp//:unittest_cpp""
++	targetNewSyntax := ""@unittest_cpp""
++	pkg, name, subrepo := parseBuildLabelParts(target1, ""/"", nil)
++	pkg2, name2, subrepo2 := parseBuildLabelParts(targetNewSyntax, ""/"", nil)
++	assert.Equal(t, pkg, pkg2)
++	assert.Equal(t, name, name2)
++	assert.Equal(t, subrepo, subrepo2)
++}
++
+ func TestMain(m *testing.M) {
+ 	// Used to support TestComplete, the function it's testing re-execs
+ 	// itself thinking that it's actually plz.","probably better to assert the values directly; technically you could pass this test with an implementation that always returned """" for the subrepo for example.",Do we need a test for the new synt
+3360,"@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		big.NewInt(10),
+ 	)
+ 	pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
+-	sig, _ := hex.DecodeString(""3584fe777dd090e1a7a825896f532485ea2cc35d7c300c6c56f0e2e78b51c6ded33f7d0069f4f6f6b6762306466fcff6f261bb30d9e1550f2f8be4f988e740903fd734209cb60101"")
++	sig, _ := hex.DecodeString(""9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01"")
+ 	bd := &action.EnvelopeBuilder{}
+ 	elp := bd.SetAction(tsf0).
+ 		SetDestinationAddress(ta.Addrinfo[""producer""].Bech32()).",line is 161 characters (from `lll`),What happened with this change?
+3361,"@@ -19,13 +19,14 @@
+
+ package org.apache.iceberg.catalog;
+
++import java.io.Serializable;
+ import java.util.Arrays;
+ import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+
+ /**
+  * A namespace in a {@link Catalog}.
+  */
+-public class Namespace {
++public class Namespace implements Serializable {
+   private static final Namespace EMPTY_NAMESPACE = new Namespace(new String[] {});
+   private static final Joiner DOT = Joiner.on('.');
+ ",Are these changes needed?,`String` instead of `String[]`?
+3362,"@@ -78,12 +78,12 @@ public final class UserUtils {
+       }
+
+       try {
+-        Path dir = Paths.get(fileName).getParent();
++        final Path dir = Paths.get(fileName).getParent();
+         if (!dirToFilesMap.containsKey(dir)) {
+-          // There is not entry for this directory, create a watchkey
++          // There is no entry for this directory, create a watchkey
+           WatchKey watchKey = dir.register(watchService,
+               new WatchEvent.Kind[]{StandardWatchEventKinds.ENTRY_MODIFY},
+-              SensitivityWatchEventModifier.HIGH);
++              SensitivityWatchEventModifier.LOW);
+           keys.put(watchKey, dir);
+         }
+         // Add the config file to dir map","It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?","@dclim, I don't quite understan"
+3363,"@@ -3,7 +3,9 @@
+ namespace Thelia\Model;
+
+ use Thelia\Model\Base\CategoryDocumentI18n as BaseCategoryDocumentI18n;
++use Thelia\Model\Tools\I18nTimestampableTrait;
+
+ class CategoryDocumentI18n extends BaseCategoryDocumentI18n
+ {
++    use I18nTimestampableTrait;
+ }",missing use statement for importing the full namespace,Shouldn't this trait be removed
+3364,"@@ -35,6 +35,9 @@ var ErrInsufficientHosts = &shared.InternalServiceError{Message: ""Not enough hos
+ // ErrListenerAlreadyExist is thrown on a duplicate AddListener call from the same listener
+ var ErrListenerAlreadyExist = errors.New(""Listener already exist for the service"")
+
++// ErrIncorrectAddressFormat is thrown on incorrect address format
++var ErrIncorrectAddressFormat = errors.New(""Incorrect address format"")
++
+ type (
+
+ 	// ChangedEvent describes a change in membership",Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?,`ErrIncorrectAddressFormat` -> `ErrInvalidAddressFormat`
+3365,"@@ -285,7 +285,7 @@ describe('Core_selection', () => {
+     selectCell(0, 0);
+     keyDownUp('arrow_left');
+
+-    expect(getSelected()).toEqual([[0, 0, 0, 0]]);
++    expect(getSelected()).toEqual([[4, 4, 4, 4]]);
+   });
+
+   it('should fix start range if provided is out of bounds (to the top)', () => {",These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file.,This seems unrelated to the rest of the PR?
+3366,"@@ -60,7 +60,17 @@ namespace Nethermind.Evm.TransactionProcessing
+             /// <summary>
+             /// Commit and later restore state, use for CallAndRestore
+             /// </summary>
+-            CommitAndRestore = Commit | Restore
++            CommitAndRestore = Commit | Restore,
++
++            /// <summary>
++            /// Zero Gas price
++            /// </summary>
++            ZeroGasPrice = 4,
++
++            /// <summary>
++            /// Commit and restore with zero gas price
++            /// </summary>
++            CommitAndRestoreWithZeroGasPrice = CommitAndRestore | ZeroGasPrice
+         }
+
+         public TransactionProcessor(",I would prefer flag SkipGasPricingValidation,what's the difference between `CommitAndRestore` and `Ze
+3367,"@@ -1492,6 +1492,13 @@ void nano::work_watcher::add (std::shared_ptr<nano::block> block_a)
+ 	}
+ }
+
++bool nano::work_watcher::is_watched (nano::qualified_root const root_a)
++{
++	std::unique_lock<std::mutex> lock (mutex);
++	auto exists (blocks.find (root_a));
++	return exists != blocks.end ();
++}
++
+ void nano::wallets::do_wallet_actions ()
+ {
+ 	std::unique_lock<std::mutex> action_lock (action_mutex);",could be `const &` ?,Why are you using a std::unique_lock here?
+3368,"@@ -75,6 +75,7 @@ module.exports = class Dashboard extends Plugin {
+       defaultTabIcon: defaultTabIcon,
+       showProgressDetails: false,
+       hideUploadButton: false,
++      hideProgressAfterFinish: false,
+       note: null,
+       closeModalOnClickOutside: false,
+       locale: defaultLocale,",The docs should also be updated with the new option.,Shouldn't this be `showProgressAfterFinish`?
+3369,"@@ -157,6 +157,15 @@ def send_email(subject, message, sender, recipients, image_png=None):
+         send_email_smtp(config, sender, subject, message, recipients, image_png)
+
+
++def send_notification(subject, message, topic):
++    import boto.sns
++    config = configuration.get_config()
++    con = boto.sns.connect_to_region(config.get('sns', 'region', 'us-east-1'),
++                                     aws_access_key_id=config.get('sns', 'AWS_ACCESS_KEY', None),
++                                     aws_secret_access_key=config.get('sns', 'AWS_SECRET_KEY', None))
++    con.publish(topic, message, subject[:100])
++
++
+ def send_error_email(subject, message):
+     """"""
+     Sends an email to the configured error-email.",Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?,why is this limiting the size of the email s
+3370,"@@ -31,7 +31,7 @@ func run() error {
+ 		return fmt.Errorf(""failed to load config file: %s"", err)
+ 	}
+
+-	logger := logging.BuildLogger(cfg.Logging.Level)
++	logger := logging.BuildLogger(*cfg.Logging.Level)
+ 	ctx := log.WithLogger(context.Background(), logger)
+
+ 	key, err := cfg.Eth.LoadKey()",Out of the scope.,Doesn't this panic if `cfg.Logging.Level` is
+3371,"@@ -151,4 +151,12 @@ if (typeof Object.assign != 'function') {
+     }
+     return to;
+   };
+-}
++}
++
++
++NodeList.prototype.forEach = function(callback, thisArg) {
++  thisArg = thisArg || window;
++  for (var i = 0; i < this.length; i++) {
++      callback.call(thisArg, this[i], i, this);
++  }
++};",I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation.,Is this still needed?
+3372,"@@ -89,6 +89,11 @@ function _getItem(name) {
+  * @param {Function} editorClass Editor class.
+  */
+ function _register(name, editorClass) {
++  if (name && typeof name !== 'string') {
++    editorClass = name;
++    name = editorClass.EDITOR_TYPE;
++  }
++
+   const editorWrapper = new RegisteredEditor(editorClass);
+
+   if (typeof name === 'string') {","I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?",Shouldn't this be `if (typeof name !== 'string')` instead?
+3373,"@@ -1,7 +1,6 @@
+ // Copyright 2020 The Swarm Authors. All rights reserved.
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+-
+ package p2p
+
+ import (","This line should not be removed, as it is not the description of the package, but a copyright header.",no need to remove this line.
+3374,"@@ -37,6 +37,8 @@ type DiskBlockCacheMetadata struct {
+ 	TriggeredPrefetch bool `codec:""HasPrefetched""`
+ 	// whether the block's triggered prefetches are complete
+ 	FinishedPrefetch bool
++	// the last tag with which the block was marked
++	Tag string
+ }
+
+ // lruEntry is an entry for sorting LRU times",Wouldn't it be more space efficient to make this a `byte` enum or bitfield?,"Could we call this `Tag` instead of `Tag`, to align with `"
+3375,"@@ -207,13 +207,13 @@ class PostgresTarget(luigi.Target):
+         connection.autocommit = True
+         cursor = connection.cursor()
+         if self.use_db_timestamps:
+-            sql = """""" CREATE TABLE {marker_table} (
++            sql = """""" CREATE TABLE IF NOT EXISTS {marker_table} (
+                       update_id TEXT PRIMARY KEY,
+                       target_table TEXT,
+                       inserted TIMESTAMP DEFAULT NOW())
+-                """""".format(marker_table=self.marker_table)
++                  """""".format(marker_table=self.marker_table)
+         else:
+-            sql = """""" CREATE TABLE {marker_table} (
++            sql = """""" CREATE TABLE IF NOT EXISTS {marker_table} (
+                       update_id TEXT PRIMARY KEY,
+                       target_table TEXT,
+                       inserted TIMESTAMP);","Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`.",Why does this need to be changed?
+3376,"@@ -0,0 +1,13 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.ast;
++
++/**
++ * Marker interface for type body declarations.
++ *
++ * @author Clément Fournier
++ */
++public interface ASTAnyTypeBodyDeclaration extends JavaNode {
++}","Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields",Is this the same as the `ASTAnyTypeBodyDeclaration` class? Can we have a better name?
+3377,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities",`timeouts` -> `timeouts`
+3378,"@@ -30,6 +30,15 @@ import org.apache.iceberg.io.LocationProvider;
+  */
+ public interface Table {
+
++  /**
++   * Return the full name for this table.
++   *
++   * @return this table's name
++   */
++  default String name() {
++    return toString();
++  }
++
+   /**
+    * Refresh the current table metadata.
+    */",It is debatable whether we have to default this. I did this to avoid breaking custom implementations.,does this need to be public ?
+3379,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done,"The `attr_value` argument is a dict and not a dict, so `attr_value['string'] is not N"
+3380,"@@ -8,7 +8,7 @@ import (
+ 	""fmt""
+ 	""strings""
+
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/addons""
++	addon ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon""
+ 	awscloudformation ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/cloudformation""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/ecr""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/s3""","we shouldn't need the ""addon"" rename",Should we rename this package to `addons`?
+3381,"@@ -1,4 +1,6 @@
+ class Admin::DecksController < ApplicationController
++  before_filter :must_be_admin
++
+   def index
+     @decks = Deck.all
+   end",These are covered by routing constraints.,Use the new Ruby 1.9 hash syntax.
+3382,"@@ -32,7 +32,7 @@ import (
+ func (s *Service) InstanceIfExists(instanceID *string) (*v1alpha1.Instance, error) {
+ 	glog.V(2).Infof(""Looking for instance %q"", *instanceID)
+ 	input := &ec2.DescribeInstancesInput{
+-		InstanceIds: []*string{instanceID},
++		InstanceIds: aws.StringSlice([]string{*instanceID}),
+ 	}
+
+ 	out, err := s.EC2.DescribeInstances(input)",Could we use just a normal string here?,This is a bug fix. `ec2.DescribeInstances`
+3383,"@@ -1,6 +1,8 @@
+ import { VNode } from './vnode';
+ import options from './options';
++import { iterableToArray, isFunction } from './util';
+
++const hasSymbolSupport = isFunction(Symbol) && Symbol.iterator;
+
+ const stack = [];
+ ",`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however.,Why do we need to check for `Symbol.iterat
+3384,"@@ -140,6 +140,10 @@ void nano::election_scheduler::run ()
+ 					election->transition_active ();
+ 				}
+ 			}
++			else
++			{
++				lock.unlock ();
++			}
+ 			notify ();
+ 			lock.lock ();
+ 		}",Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero.,"Shouldn't the unlock below be in a `else` block? Otherwise, the lock will not be unlocked if there's an exception..."
+3385,"@@ -189,7 +189,7 @@ func dispense(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	tx, err := c.SendPaymentFromUnencryptedWallet(cfg.Source, target, uint64(cfg.Fee), uint64(cfg.Amount), nil)
++	tx, err := c.SendPaymentFromUnencryptedWallet(cfg.Source, target, uint64(cfg.Fee), uint64(cfg.Amount), [32]byte{}, nil)
+ 	if err != nil {
+ 		http.Error(w, fmt.Sprintf(""failed to dispense money - %v"", err), http.StatusInternalServerError)
+ 		return","do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if ""no"" this is fine, if ""yes"" it's probably still fine",why the `32byte`?
+3386,"@@ -19,13 +19,14 @@ package org.openqa.selenium.remote;
+
+ import com.google.common.collect.ImmutableMap;
+
++import org.openqa.selenium.DeviceRotation;
+ import org.openqa.selenium.Rotatable;
+ import org.openqa.selenium.ScreenOrientation;
+
+ import java.lang.reflect.Method;
+
+ public class AddRotatable implements AugmenterProvider {
+-
++
+   public Class<?> getDescribedInterface() {
+     return Rotatable.class;
+   }","you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)","no empty line, please."
+3387,"@@ -35,6 +35,12 @@ export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, Paginat
+                 });
+             }
+
++            // we need to load the roles into ember cache
++            // invites return role_id only and we do not offer a /role/:id endpoint
++            this.get('store').query('role', {permissions: 'assign'}).then((roles) => {
++                modelPromises.roles = roles;
++            });
++
+             return RSVP.hash(modelPromises);
+         });
+     },","This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async.","Is there a reason for not caching the result of `store.query('role', {permissions: 'assign'})`?"
+3388,"@@ -0,0 +1,19 @@
++const landmarks = axe.commons.aria.getRolesByType('landmark');
++const sectioning = ['article', 'aside', 'main', 'navigation', 'section'];
++const nodeIsHeader = node.tagName.toLowerCase() === 'header' && node.getAttribute('role') !== 'banner';
++var parent = axe.commons.dom.getComposedParent(node);
++
++while (parent){
++	var role = parent.getAttribute('role');
++	if (!role && (parent.tagName.toLowerCase() !== 'form')){
++		role = axe.commons.aria.implicitRole(parent);
++	}
++  if (role && nodeIsHeader && sectioning.includes(role)){
++    return true;
++  }
++	if (role && landmarks.includes(role)){
++		return false;
++	}
++	parent = axe.commons.dom.getComposedParent(parent);
++}
++return true;","This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test.",shouldn't we check for `node.tagName.toLowerCase()` as well?
+3389,"@@ -63,13 +63,13 @@ public class PackageListeners {
+   }
+
+   synchronized void packagesUpdated(List<PackageLoader.Package> pkgs) {
+-    MDCLoggingContext.setCore(core);
++    if(core != null) MDCLoggingContext.setCore(core);
+     try {
+       for (PackageLoader.Package pkgInfo : pkgs) {
+         invokeListeners(pkgInfo);
+       }
+     } finally {
+-      MDCLoggingContext.clear();
++      if(core != null) MDCLoggingContext.clear();
+     }
+   }
+ ",Why do we need this check? setCore already handles nulls.,This is the only real change in this file. The rest of the c
+3390,"@@ -121,7 +121,7 @@ def _inject(target_type, inject_type):
+     # Inject all the methods from the hierarchy:
+     setattr(target_type, ""__getattr__"", inject_type.__getattr__)
+     setattr(target_type, ""__getitem__"", inject_type.__getitem__)
+-    for attr in [""__iter__"", ""__len__"", ""__invert__"", ""__setitem__""]:
++    for attr in [""__iter__"", ""__len__"", ""__invert__"", ""__setitem__"", ""__dir__""]:
+         if hasattr(inject_type, attr):
+             setattr(target_type, attr, inject_type.__dict__[attr])
+     for t in mro:","good catch, thanks. This is going to make the user experience much better.",I don't think we need to add `__dir__` here.
+3391,"@@ -1,4 +1,4 @@
+-import { options } from 'preact';
++import { Component, options } from 'preact';
+
+ /** @type {number} */
+ let currentIndex;",TODO: remove this unused import,There's no need for this to be an import. You can just do `i
+3392,"@@ -591,7 +591,7 @@ func (s *HandlerTestSuite) TestValidateJWTSVID() {
+ 			},
+ 			workloadUpdate: &cache.WorkloadUpdate{},
+ 			code:           codes.InvalidArgument,
+-			msg:            ""token contains an invalid number of segments"",
++			msg:            ""square/go-jose: compact JWS format must have three parts"",
+ 		},
+ 		{
+ 			name: ""validated by our trust domain bundle"",","Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned ""could not parse token"" or something instead?","I wonder if we should make this more general and say something like ""square/go-jose: compact JWS format must have three parts""?"
+3393,"@@ -9,12 +9,14 @@ module Travis
+         }
+
+         def install
+-          self.if   '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
++          self.if   '-f ./gradlew',    './gradlew assemble', fold: 'install', retry: true
++          self.elif '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
+           self.elif '-f pom.xml',      'mvn install -DskipTests=true -B', fold: 'install', retry: true # Otherwise mvn install will run tests which. Suggestion from Charles Nutter. MK.
+         end
+
+         def script
+-          self.if   '-f build.gradle', 'gradle check'
++          self.if   '-f ./gradlew',    './gradlew check'
++          self.elif '-f build.gradle', 'gradle check'
+           self.elif '-f pom.xml',      'mvn test -B'
+           self.else                    'ant test'
+         end",I think `-f gradlew` is better for code unity,"Just out of curiosity, why did you need all the `./gradlew` files in the first place?"
+3394,"@@ -40,4 +40,10 @@ public class FlinkConfigOptions {
+           .intType()
+           .defaultValue(100)
+           .withDescription(""Sets max infer parallelism for source operator."");
++
++  public static final ConfigOption<Integer> SOURCE_READER_FETCH_RECORD_BATCH_SIZE = ConfigOptions
++      .key(""source.iceberg.reader.fetch-record-batch-size"")
++      .intType()
++      .defaultValue(2048)
++      .withDescription(""The target record batch size for split reader fetch."");
+ }",Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?,why do we default to2048 here?
+3395,"@@ -1,4 +1,4 @@
+-using System;
++using System;
+ using System.Collections.Generic;
+ using System.Globalization;
+ using System.Linq.Expressions;",Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes,Is this change necessary?
+3396,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[UpdateServerCertificate.java demonstrates how to update the name of an AWS Identity and Access Management (IAM) server certificate.]
++//snippet-sourcedescription:[UpdateServerCertificate.java demonstrates how to update the name of an AWS Identity and Access Management (AWS IAM) server certificate.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),"I think there should be a space before the `,` here."
+3397,"@@ -83,14 +83,10 @@ func NewCommand(licenseCommandName string) *cli.Command {
+ 			cmd.RegisterSignalCallback(func() { errorChannel <- nil })
+
+ 			cmdService := &serviceCommand{
+-				tequilapi:    client.NewClient(nodeOptions.TequilapiAddress, nodeOptions.TequilapiPort),
+-				errorChannel: errorChannel,
+-				identityHandler: identity_selector.NewHandler(
+-					di.IdentityManager,
+-					di.MysteriumAPI,
+-					identity.NewIdentityCache(nodeOptions.Directories.Keystore, ""remember.json""),
+-					di.SignerFactory),
+-				ap: parseAccessPolicyFlag(ctx),
++				tequilapi:       client.NewClient(nodeOptions.TequilapiAddress, nodeOptions.TequilapiPort),
++				errorChannel:    errorChannel,
++				identityHandler: di.IdentitySelector,
++				ap:              parseAccessPolicyFlag(ctx),
+ 			}
+
+ 			go func() {",You dont use this dependency anymore,can we call this `identitySelector` instead of `iden
+3398,"@@ -86,6 +86,8 @@ public abstract class AbstractSmartStoreTest extends SmartStoreTestCase {
+
+ 		assertTrue(""ENABLE_FTS4 flag not found in compile options"", compileOptions.contains(""ENABLE_FTS4""));
+ 		assertTrue(""ENABLE_FTS3_PARENTHESIS flag not found in compile options"", compileOptions.contains(""ENABLE_FTS3_PARENTHESIS""));
++		assertTrue(""ENABLE_FTS5 flag not found in compile options"", compileOptions.contains(""ENABLE_FTS5""));
++		assertTrue(""ENABLE_JSON1 flag not found in compile options"", compileOptions.contains(""ENABLE_JSON1""));
+ 	}
+
+ 	/**",Here is the test that checks that the sqlcipher in use was compiled with the right flags,This test is in the wrong place now. These options s
+3399,"@@ -199,6 +199,8 @@ public class LoginServerManager {
+ 		} catch (Exception e) {
+ 			Log.w(""LoginServerManager.getLoginServersFromRuntimeConfig"",
+ 					""Exception thrown while attempting to read array, attempting to read string value instead"");
++		}
++		if (mdmLoginServers == null) {
+ 			final String loginServer = runtimeConfig.getString(ConfigKey.AppServiceHosts);
+ 			if (!TextUtils.isEmpty(loginServer)) {
+ 				mdmLoginServers = new String[] {loginServer};","Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work.",Why is this `null` check needed? Could `mdmLoginServ
+3400,"@@ -16,8 +16,12 @@
+
+ package io.servicecomb.provider.springmvc.reference;
+
++import java.net.URI;
++
+ import org.junit.Assert;
+ import org.junit.Test;
++import org.springframework.web.client.RestClientException;
++import org.springframework.web.client.RestTemplate;
+
+ public class TestRestTemplateBuilder {
+ ",this test only covers the happy path. what about no acceptable rest template found?,Please reorder to the top of the file.
+3401,"@@ -582,7 +582,7 @@ public class DistributorTest {
+         );
+
+         Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession();
+-        LOG.info(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
++        LOG.finer(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
+
+         boolean inFirefoxNodes = firefoxNodes.stream().anyMatch(node -> node.getUri().equals(firefoxSession.getUri()));
+         boolean inChromeNodes = chromeNodes.stream().anyMatch(node -> node.getUri().equals(chromeSession.getUri()));","Since this is in a test, I imagine that the choice of `info` level was deliberate.",This should be removed.
+3402,"@@ -3,9 +3,10 @@ package langserver
+ import (
+ 	""context""
+ 	""github.com/stretchr/testify/assert""
+-	""strings""
+ 	""testing""
+
++	""core""
++	""strings""
+ 	""tools/build_langserver/lsp""
+ )
+ ",this should probably be named somewhere if you want to reuse it.,Why is this import changed?
+3403,"@@ -191,6 +191,14 @@ const (
+ 	// path where we mount in the SSH key for connecting to the bare metal libvirt provisioning host.
+ 	LibvirtSSHPrivKeyPathEnvVar = ""LIBVIRT_SSH_PRIV_KEY_PATH""
+
++	// BoundServiceAccountSigningKeyEnvVar contains the path to the bound service account signing key and
++	// is set in the install pod for AWS STS clusters.
++	BoundServiceAccountSigningKeyEnvVar = ""AWS_BOUND_SA_SIGNING_KEY""
++
++	// BoundServiceAccountSigningKeyFile is the Secret key and projected filename where an AWS STS
++	// SA signing key will be projected into the install pod.
++	BoundServiceAccountSigningKeyFile = ""bound-service-account-signing-key.key""
++
+ 	// FakeClusterInstallEnvVar is the environment variable Hive will set for the installmanager pod to request
+ 	// a fake install.
+ 	FakeClusterInstallEnvVar = ""FAKE_INSTALL""",needs a rename to not include AWS,Doesn't this need to be `bound-service
+3404,"@@ -15,13 +15,11 @@
+ *******************************************************************************/
+
+ #include ""oneapi/dal/algo/rbf_kernel/backend/gpu/compute_kernel.hpp""
+-#include ""oneapi/dal/backend/interop/common_dpc.hpp""
+-#include ""oneapi/dal/backend/interop/table_conversion.hpp""
+-
++#include ""oneapi/dal/backend/primitives/reduction.hpp""
++#include ""oneapi/dal/backend/primitives/blas.hpp""
++#include ""oneapi/dal/backend/math.hpp""
+ #include ""oneapi/dal/table/row_accessor.hpp""
+
+-#include <daal/src/algorithms/kernel_function/oneapi/kernel_function_rbf_kernel_oneapi.h>
+-
+ namespace oneapi::dal::rbf_kernel::backend {
+
+ using dal::backend::context_gpu;",Isn't sigma have `double` type?,All of these includes can now be removed.
+3405,"@@ -977,6 +977,7 @@ TEST (rpc, wallet_create_seed)
+ 	nano::system system (24000, 1);
+ 	scoped_io_thread_name_change scoped_thread_name_io;
+ 	nano::raw_key seed;
++	seed.data = 1;
+ 	auto prv = nano::deterministic_key (seed, 0);
+ 	auto pub (nano::pub_key (prv));
+ 	auto node = system.nodes.front ();",May be better use nano::keypair that generates ramdom value?,Is this necessary? Seems unrelated to the
+3406,"@@ -25,7 +25,11 @@ const isPromiseLike = require('../utils').isPromiseLike;
+ function addToOperationsList(bulkOperation, docType, document) {
+   // Get the bsonSize
+   const bsonSize = bson.calculateObjectSize(document, {
+-    checkKeys: false
++    checkKeys: false,
++
++    // Since we don't know what the user selected for BSON options here,
++    // err on the safe side, and check the size with ignoreUndefined: false.
++    ignoreUndefined: false
+   });
+
+   // Throw error if the doc is bigger than the max BSON size","I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?",Why does `calculateObjectSize` throw an e
+3407,"@@ -257,6 +257,10 @@ public class SyncManager {
+                             break;
+                     }
+                     updateSync(sync, SyncState.Status.DONE, 100, callback);
++                } catch (RestClient.RefreshTokenRevokedException re) {
++                    logger.e(this, ""runSync"", re);
++                    // Do not do anything - let the logout go through!
++
+                 } catch (Exception e) {
+                     logger.e(this, ""runSync"", e);
+                     // Update status to failed","The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user.",do we need this?
+3408,"@@ -27,6 +27,11 @@ func TestCodestar_WaitUntilStatusAvailable(t *testing.T) {
+ 		connection := &CodeStar{}
+ 		connectionARN := ""mockConnectionARN""
+
++		ctrl := gomock.NewController(t)
++		defer ctrl.Finish()
++		m := mocks.NewMockapi(ctrl)
++		m.EXPECT().GetConnection(gomock.Any()).AnyTimes()
++
+ 		// WHEN
+ 		err := connection.WaitUntilConnectionStatusAvailable(ctx, connectionARN)
+ ",huh does this work without a `Return`?,"You can use `NewMockAPI` directly here, no need to create a fake client"
+3409,"@@ -134,11 +134,7 @@ module RSpec
+                 # no-op, required metadata has already been set by the `skip`
+                 # method.
+               rescue Exception => e
+-                if pending?
+-                  metadata[:execution_result][:pending_exception] = e
+-                else
+-                  set_exception(e)
+-                end
++                set_exception(e)
+               ensure
+                 run_after_each
+               end","Don't think we want this line, right? (Plus ""failing"" is spelled wrong).",I thought we were trying to avoid rescuing the exception altogether?
+3410,"@@ -105,6 +105,10 @@ public class FeedItemMenuHandler {
+
+         setItemVisibility(menu, R.id.remove_item, fileDownloaded);
+
++        if (selectedItem.getFeed().isLocalFeed()) {
++            setItemVisibility(menu, R.id.share_item, false);
++        }
++
+         return true;
+     }
+ ","I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example.",Can you explain why this change is needed? I don't see it in the PR des
+3411,"@@ -199,14 +199,6 @@ class BackendMenuBuilder implements BackendMenuBuilderInterface
+             ],
+         ]);
+
+-        $menu->getChild('Maintenance')->addChild('Fixtures', [
+-            'uri' => '',
+-            'extras' => [
+-                'name' => $t->trans('caption.fixtures_dummy_content'),
+-                'icon' => 'fa-hat-wizard',
+-            ],
+-        ]);
+-
+         $menu->getChild('Maintenance')->addChild('Clear the cache', [
+             'uri' => $this->urlGenerator->generate('bolt_clear_cache'),
+             'extras' => [","Why remove this one? It doesn't work yet, but we'll add it sooner or later.",Why did you remove this?
+3412,"@@ -304,12 +304,12 @@ type docstruct struct {
+ 	DocstoreRevision interface{}
+ 	Etag             interface{}
+
+-	I  int                    `docstore:""i""`
+-	U  uint                   `docstore:""u""`
+-	F  float64                `docstore:""f""`
+-	St string                 `docstore:""st""`
+-	B  bool                   `docstore:""b""`
+-	M  map[string]interface{} `docstore:""m""`
++	I  int
++	U  uint
++	F  float64
++	St string
++	B  bool
++	M  map[string]interface{}
+ }
+
+ func nonexistentDoc() docmap { return docmap{KeyField: ""doesNotExist""} }",Why did you remove the struct tags?,"unrelated to this PR but I'm curious why remove `docstore:""i""` and `docstore:""u""`?"
+3413,"@@ -178,6 +178,11 @@ class FinalStatus(Reporter, AggregatorListener, FunctionalAggregatorListener):
+     def __dump_xml(self, filename):
+         self.log.info(""Dumping final status as XML: %s"", filename)
+         root = etree.Element(""FinalStatus"")
++        report_info = get_bza_report_info(self.engine, self.log)
++        if report_info:
++            link, text = report_info[0]
++            report_element = etree.Element(""BlazeMeterReport"", link=link, name=text)
++            root.append(report_element)
+         if self.last_sec:
+             for label, kpiset in iteritems(self.last_sec[DataPoint.CUMULATIVE]):
+                 root.append(self.__get_xml_summary(label, kpiset))","Let's be neutral with tag names. Let's just have ""ReportURL""","`BlazeMeterReport` is not a XML element, it is a representation of a report."
+3414,"@@ -265,7 +265,8 @@ func TestEmptySpanData(t *testing.T) {
+ func TestSpanData(t *testing.T) {
+ 	// Full test of span data transform.
+
+-	startTime := time.Now()
++	// March 31, 2020 5:01:26 1234nanos (UTC)
++	startTime := time.Unix(1585674086, 1234)
+ 	endTime := startTime.Add(10 * time.Second)
+ 	spanData := &export.SpanData{
+ 		SpanContext: core.SpanContext{",Use an explicit time to ensure conversion is not copy-paste and wrong.,"I think you need to use `time.Unix(0, 0)` here."
+3415,"@@ -804,7 +804,11 @@ void handle_lookup_account_poll(GUI_RPC_CONN& grc) {
+             grc.lookup_account_op.error_num
+         );
+     } else {
+-        grc.mfout.printf(""%s"", grc.lookup_account_op.reply.c_str());
++        const char *p = grc.lookup_account_op.reply.c_str();
++        const char *q = strstr(p, ""<account_out"");
++        if (!q) q = strstr(p, ""<error"");
++        if (!q) q = ""<account_out/>\n"";
++        grc.mfout.printf(""%s"", q);
+     }
+ }
+ ",The logic now is to look for `<account_out` if that is present return the string starting from there. If it is not present look for `<error` and return the string from there (which can produce malformed XML because you do not check if the closing tag matches). If this is also not found return an empty `<account_out/>`. This `<error>` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?,"(style) space prohibited before that ',' (ctx:WxW)"
+3416,"@@ -0,0 +1,12 @@
++class Api::V1::VideosController < ApiController
++  def index
++    show = find_show
++    render json: { videos: show.videos }
++  end
++
++  private
++
++  def find_show
++    Show.friendly.find(params[:show_id])
++  end
++end",Use nested module/class definitions instead of compact style.,Extra empty line detected at class body beginning.
+3417,"@@ -56,6 +56,7 @@ var individualTestTimeout = 10 * time.Second
+
+ func kbfsOpsInit(t *testing.T, changeMd bool) (mockCtrl *gomock.Controller,
+ 	config *ConfigMock, ctx context.Context, cancel context.CancelFunc) {
++	t.Log(""Init KBFSOps"")
+ 	ctr := NewSafeTestReporter(t)
+ 	mockCtrl = gomock.NewController(ctr)
+ 	config = NewConfigMock(mockCtrl, ctr)","Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it.",Was this meant to be here?
+3418,"@@ -95,7 +95,7 @@ public class FreezeTimersOverlay extends Overlay
+ 	{
+ 		final Player player = playerDespawned.getPlayer();
+ 		// All despawns ok: death, teleports, log out, runs away from screen
+-		if (config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng() | config.TB())
++		if (config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng())
+ 		{
+ 			this.remove(player);
+ 		}",showNPCs is not needed,FYI @RoiEXLab this was the only one I'm not sure a
+3419,"@@ -0,0 +1,12 @@
++package ssm
++
++import ""fmt""
++
++// ErrParameterAlreadyExists occurs when the parameter with name already existed.
++type ErrParameterAlreadyExists struct {
++	name string
++}
++
++func (e *ErrParameterAlreadyExists) Error() string {
++	return fmt.Sprintf(""parameter %s already exists"", e.name)
++}",Docstring for public function pls,I don't see where this is used?
+3420,"@@ -1539,3 +1539,16 @@ func TestSSIReApplyDuration(t *testing.T) {
+ 		}
+ 	}
+ }
++
++func TestFilterApplyError(t *testing.T) {
++	err1 := ""error when creating \""/tmp/apply-475927931\"": namespaces \""openshift-am-config\"" not found""
++	expectedFilteredErr1 := ""namespaces \""openshift-am-config\"" not found""
++	if filterApplyError(err1) != expectedFilteredErr1 {
++		t.Fatalf(""expected temporary file to be trimmed from error message"")
++	}
++
++	err2 := ""unable to parse \""[ { \\\""op\\\"": \\\""replace\\\"", \\\""path\\\"": \\\""/data/foo\\\"", \\\""value\\\"": \\\""baz-json\\\"" ]\"": yaml: did not find expected ',' or '}'""
++	if filterApplyError(err2) != err2 {
++		t.Fatalf(""expected error message to be unchanged"")
++	}
++}",This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails.,would be nice to have a test that ensures the correct file is saved in the cache.
+3421,"@@ -715,7 +715,7 @@ int main(int argc, char **argv)
+ #endif
+     }
+
+-    if (ctx.http3 != NULL) {
++    if (ctx.protocol_selector.ratio.http3 > 0) {
+         h2o_quic_close_all_connections(&ctx.http3->h3);
+         while (h2o_quic_num_connections(&ctx.http3->h3) != 0) {
+ #if H2O_USE_LIBUV","Should this if block better be changed to `#if H2O_USE_LIBUV \n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op.",Shouldn't this be `&ctx.http3->h3`?
+3422,"@@ -87,8 +87,11 @@ export function useReducer(reducer, initialState, init) {
+ 			init == null ? invokeOrReturn(null, initialState) : init(initialState),
+
+ 			action => {
+-				hookState._value[0] = reducer(hookState._value[0], action);
+-				hookState._component.setState({});
++				const nextValue = reducer(hookState._value[0], action);
++				if (!Object.is(hookState._value[0], nextValue)) {
++					hookState._value[0] = nextValue;
++					hookState._component.setState({});
++				}
+ 			}
+ 		];
+ 	}",`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?,Is this necessary?
+3423,"@@ -22,7 +22,11 @@ class AddUserOperation extends CommandOperation {
+     const options = this.options;
+
+     // Get additional values
+-    let roles = Array.isArray(options.roles) ? options.roles : [];
++    let roles = Array.isArray(options.roles)
++      ? options.roles
++      : typeof options.roles === 'string'
++      ? [options.roles]
++      : [];
+
+     // If not roles defined print deprecated message
+     // TODO: handle deprecation properly","This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)",In what circumstance would `options.roles` not be a string?
+3424,"@@ -80,6 +80,17 @@ public interface CollectionAdminParams {
+    */
+   String COLL_CONF = ""collection.configName"";
+
++  /**
++   * The name of the collection with which a collection is to be co-located
++   */
++  String WITH_COLLECTION = ""withCollection"";
++
++  /**
++   * The reverse-link to WITH_COLLECTION flag. It is stored in the cluster state of the `withCollection`
++   * and points to the collection on which the `withCollection` was specified.
++   */
++  String COLOCATED_WITH = ""COLOCATED_WITH"";
++
+   /**
+    * Used by cluster properties API as a wrapper key to provide defaults for collection, cluster etc.
+    *",It would be helpful to explicit here what this really means and assumes.,minor: I would call this `COLLECTION_CONFIG` instead of `WITH_COLLECTION`
+3425,"@@ -46,6 +46,9 @@ type AddressKey struct {
+ 	PriKey      keypair.PrivateKey
+ }
+
++//ExpectedBalances records expectd balances of admins and delegates
++var ExpectedBalances map[string]*big.Int
++
+ // LoadAddresses loads key pairs from key pair path and construct addresses
+ func LoadAddresses(keypairsPath string, chainID uint32) ([]*AddressKey, error) {
+ 	// Load Senders' public/private key pairs",`ExpectedBalances` is a global variable (from `gochecknoglobals`),nit: `expectedBalances` -> `expectedBalances`
+3426,"@@ -1,7 +1,7 @@
+ module RSpec
+   module Core
+     module Formatters
+-      # This class extracts code snippets by looking at the backtrace of the passed error
++      # Extracts code snippets by looking at the backtrace of the passed error and applies synax highlighting and line numbers using html.
+       class SnippetExtractor
+         class NullConverter; def convert(code, pre); code; end; end
+ ","This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use.",I thought we were going to change the class name in a follow-up PR?
+3427,"@@ -57,11 +57,14 @@ func addAccountToMemResolver(s *Server, pub, jwtclaim string) {
+ 	s.mu.Unlock()
+ }
+
+-func createClient(t *testing.T, s *Server, akp nkeys.KeyPair) (*client, *bufio.Reader, string) {
++func createClient(t *testing.T, s *Server, akp nkeys.KeyPair, optIssuerAccount string) (*client, *bufio.Reader, string) {
+ 	t.Helper()
+ 	nkp, _ := nkeys.CreateUser()
+ 	pub, _ := nkp.PublicKey()
+ 	nuc := jwt.NewUserClaims(pub)
++	if optIssuerAccount != """" {
++		nuc.IssuerAccount = optIssuerAccount
++	}
+ 	ujwt, err := nuc.Encode(akp)
+ 	if err != nil {
+ 		t.Fatalf(""Error generating user JWT: %v"", err)","Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the """"",Can we have this passed in `t.Helper()` so we don't have to pass it every
+3428,"@@ -129,6 +129,9 @@ public class SPRequestHandler {
+
+     private void handleError(String error) {
+         SalesforceSDKLogger.e(TAG, ""Error received from IDP app: "" + error);
++        if (authCallback != null) {
++            authCallback.receivedErrorResponse(error);
++        }
+     }
+
+     private void handleSuccess(String code, String loginUrl) {",Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`.,Should this be `handleError`?
+3429,"@@ -3,6 +3,7 @@ var assert = require('assert');
+ var Transform = require('stream').Transform;
+ const MongoError = require('../../lib/core').MongoError;
+ var MongoNetworkError = require('../../lib/core').MongoNetworkError;
++var mongoErrorContextSymbol = require('../../lib/core').mongoErrorContextSymbol;
+ var setupDatabase = require('./shared').setupDatabase;
+ var delay = require('./shared').delay;
+ var co = require('co');",I thought we got rid of this thing?,You can remove this line now
+3430,"@@ -83,15 +83,8 @@ class TaintNodeData
+     public $column_to;
+
+     /**
+-     * @param string $label
+-     * @param string $entry_path_type
+-     * @param ?string $entry_path_description
+      * @param int $line_from
+      * @param int $line_to
+-     * @param string $file_name
+-     * @param string $file_path
+-     * @param string $snippet
+-     * @param string $selected_text
+      * @param int $from
+      * @param int $to
+      * @param int $snippet_from",Please convert int params as well.,why did you remove all of the
+3431,"@@ -84,7 +84,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                 var lastComponent = components.Last();
+                 messageLines.Add(
+                     string.Format(
+-                        CultureInfo.InvariantCulture, ""{0}:{1} {2} {3}: {4}"",
++                        CultureInfo.InvariantCulture, ""{0}{1}: {2} {3}: {4}"",
+                         lastComponent.Uri.AbsolutePath,
+                         lastComponent.Region.FormatForVisualStudio(),
+                         result.Kind.FormatForVisualStudio(),","Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue.",Is this change intentional? W
+3432,"@@ -230,6 +230,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+
++        /// <summary>
++        /// Configuration key for the application's servers http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpServerErrorStatuses""/>
++        public const string HttpServerErrors = ""DD_HTTP_SERVER_ERROR_STATUSES"";
++
++        /// <summary>
++        /// Configuration key for the application's client http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpClientErrorStatuses""/>
++        public const string HttpClientErrors = ""DD_HTTP_CLIENT_ERROR_STATUSES"";
++
+         /// <summary>
+         /// String format patterns used to match integration-specific configuration keys.
+         /// </summary>","Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer ""codes"" over ""statuses"", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)",This should be `DD_HTTP_CLIENT_ERROR_STATUSES`
+3433,"@@ -134,8 +134,17 @@ struct flb_systemd_config *flb_systemd_config_create(struct flb_input_instance *
+         sd_journal_add_disjunction(ctx->j);
+     }
+
+-    /* Always seek to head */
+-    sd_journal_seek_head(ctx->j);
++    /* Seek to head by default or tail if specified in configuration */
++    tmp = flb_input_get_property(""read_from_tail"", i_ins);
++    if (tmp && strcasecmp(tmp, ""true"") == 0) {
++        sd_journal_seek_tail(ctx->j);
++
++        /* Skip last entry */
++        sd_journal_next_skip(ctx->j, 1);
++    }
++    else {
++        sd_journal_seek_head(ctx->j);
++    }
+
+     /* Check if we have a cursor in our database */
+     if (ctx->db) {","would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff.",(style) strcasecmp may be changed to strcmp (c
+3434,"@@ -178,7 +178,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                                 analyzeOptions.Verbose,
+                                 targets,
+                                 analyzeOptions.ComputeTargetsHash,
+-                                Prerelease)),
++                                Prerelease,
++                                null)),
+                     (ex) =>
+                     {
+                         Errors.LogExceptionCreatingLogFile(context, filePath, ex);","`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)",Nit: Can we put the `null` argument on the nex
+3435,"@@ -61,6 +61,10 @@ class BaseDetector(nn.Module):
+         """"""
+         pass
+
++    @abstractmethod
++    async def async_test(self, img, img_meta, **kwargs):
++        pass
++
+     @abstractmethod
+     def simple_test(self, img, img_meta, **kwargs):
+         pass",maybe renamed to `async_simple_test` if we consider supporting aug test later on?,Why do we define it as an abstract method if o
+3436,"@@ -113,7 +113,7 @@ module Mongoid #:nodoc:
+     # @return [ Document ] A new document.
+     def initialize(attrs = nil)
+       @new_record = true
+-      @attributes = default_attributes
++      @attributes = apply_default_attributes
+       process(attrs) do |document|
+         yield self if block_given?
+         identify","So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?",Style/RedundantSelf: Redundant self detected.
+3437,"@@ -42,9 +42,9 @@ namespace OpenTelemetry.Metrics.Aggregators
+         {
+             return new DoubleSumData
+             {
+-                StartTimestamp = new DateTime(this.GetLastStartTimestamp().Ticks),
++                StartTimestamp = new DateTime(this.GetLastStartTimestamp().Ticks, DateTimeKind.Utc),
+                 Sum = this.checkPoint,
+-                Timestamp = new DateTime(this.GetLastEndTimestamp().Ticks),
++                Timestamp = new DateTime(this.GetLastEndTimestamp().Ticks, DateTimeKind.Utc),
+             };
+         }
+ ",We could move this to the base class and remove all these changes. What do you think?,Why do we have to specify `DateTimeKind.Utc`
+3438,"@@ -13,6 +13,7 @@ feature ""subscriber requests access to beta trail"" do
+
+     click_on ""Request Access""
+
++    expect(page).to have_content(I18n.t(""beta.replies.flashes.success""))
+     expect(page).not_to have_content(""Exciting Beta Trail"")
+   end
+ end","While we're doing some translation work, could you extract this button text and the other static text from the view?",Prefer single-quoted strings when you don't n
+3439,"@@ -181,6 +181,12 @@ public class JobCallbackUtil {
+         String headersKeyPerSequence =
+             headersKey.replace(SEQUENCE_TOKEN, sequenceStr);
+         String headersValue = props.get(headersKeyPerSequence);
++
++		// replace all the tokens in the header
++		if(headersValue != null)  {
++			headersValue = replaceTokens(headersValue, contextInfo, false);
++		}
++
+         privateLogger.info(""headers: "" + headersValue);
+         Header[] headers = parseHttpHeaders(headersValue);
+         if (headers != null) {",Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs).,Should we pass `headersValue` into `replaceTo
+3440,"@@ -60,7 +60,7 @@ module.exports = {
+         TestCase.assertEqual(defaultRealm.schemaVersion, 0);
+
+         TestCase.assertThrows(function() {
+-            new Realm({schemaVersion: 1});
++            new Realm({schemaVersion: 1, schema: []});
+         }, ""Realm already opened at a different schema version"");
+
+         TestCase.assertEqual(new Realm().schemaVersion, 0);",This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent.,"The error message is not right. The error message is ""Realm already open at a different schema version"", but the error message is ""Realm already open at a different schema version"". Since all the error message is the same, the error message is not wrong."
+3441,"@@ -2712,6 +2712,7 @@ dr_get_os_version(dr_os_version_info_t *info)
+     get_os_version_ex(&ver, &sp_major, &sp_minor);
+     if (info->size > offsetof(dr_os_version_info_t, version)) {
+         switch (ver) {
++        case WINDOWS_VERSION_10_1803: info->version = DR_WINDOWS_VERSION_10_1803; break;
+         case WINDOWS_VERSION_10_1709: info->version = DR_WINDOWS_VERSION_10_1709; break;
+         case WINDOWS_VERSION_10_1703: info->version = DR_WINDOWS_VERSION_10_1703; break;
+         case WINDOWS_VERSION_10_1607: info->version = DR_WINDOWS_VERSION_10_1607; break;","The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version.",This is the only place where `version == 0` is used. So there is no `DR_WINDOWS_VERSION_10_1809` or `DR_WINDOWS_VERSION_10_1709` that would be missing.
+3442,"@@ -0,0 +1,6 @@
++var aria = 'aria-hidden';
++if (node && node.hasAttribute(aria)) {
++	return false;
++}
++
++return true;",Just do: `return node.hasAttribute('aria-hidden')`,Do we need to check for `aria-hidden` attributes here?
+3443,"@@ -10,6 +10,18 @@ describe ""Saved Searches"" do
+     click_link 'Saved Searches'
+     expect(page).to have_content 'You have no saved searches'
+   end
++
++  it 'can be saved and forgotten from a search result' do
++    visit catalog_index_path(q: 'book')
++    within '.search-widgets' do
++      click_button 'save'
++    end
++    expect(page).to have_content 'Successfully saved your search.'
++    within '.search-widgets' do
++      click_button 'forget'
++    end
++    expect(page).to have_content 'Successfully removed that saved search.'
++  end
+
+   describe ""with a saved search 'book'"" do
+     before do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+3444,"@@ -9,7 +9,10 @@ namespace Datadog.Trace.Util
+     internal static class DomainMetadata
+     {
+         private const string UnknownName = ""unknown"";
+-        private static Process _currentProcess;
++        private static bool _initialized;
++        private static string _currentProcessName;
++        private static string _currentProcessMachineName;
++        private static int _currentProcessId;
+         private static bool _processDataPoisoned;
+         private static bool _domainDataPoisoned;
+         private static bool? _isAppInsightsAppDomain;",Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?,nit: I think the `_` prefix isn't needed anymore.
+3445,"@@ -114,10 +114,17 @@ func run(ctx context.Context, cfg cmds.Agent, proxy proxy.Proxy) error {
+ 			return err
+ 		}
+ 	}
++
++	notifySocket := os.Getenv(""NOTIFY_SOCKET"")
++	os.Unsetenv(""NOTIFY_SOCKET"")
++
+ 	if err := setupTunnelAndRunAgent(ctx, nodeConfig, cfg, proxy); err != nil {
+ 		return err
+ 	}
+
++	os.Setenv(""NOTIFY_SOCKET"", notifySocket)
++	systemd.SdNotify(true, ""READY=1\n"")
++
+ 	coreClient, err := coreClient(nodeConfig.AgentConfig.KubeConfigKubelet)
+ 	if err != nil {
+ 		return err",Did it not work out to wait until after containerd and kubelet are started?,Why unset the env variable here? Shouldn't we do
+3446,"@@ -159,6 +159,10 @@ const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes
+ 	{""elementenergy"", ITEM_PARSE_ELEMENTENERGY},
+ 	{""elementdeath"", ITEM_PARSE_ELEMENTDEATH},
+ 	{""elementholy"", ITEM_PARSE_ELEMENTHOLY},
++	{""cooldownreduction"", ITEM_PARSE_COOLDOWNREDUCTION},
++	{""increasedamage"", ITEM_PARSE_INCREASEDAMAGE},
++	{""increasehealing"", ITEM_PARSE_INCREASEHEALING},
++	{""increasemanaget"", ITEM_PARSE_INCREASEMANAGAIN},
+ 	{""walkstack"", ITEM_PARSE_WALKSTACK},
+ 	{""blocking"", ITEM_PARSE_BLOCKING},
+ 	{""allowdistread"", ITEM_PARSE_ALLOWDISTREAD},","variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, ""damage boost +x%"" - healingboost, ITEM_PARSE_HEALINGBOOST, ""healing power +y%"" - managainboost, ITEM_PARSE_MANAGAINBOOST, ""mana restoration +z%"" alternatively the other names can stay, because ""increase"" convention isn't that bad, just change mana values to: - ""increasemanarestored"", ITEM_PARSE_INCREASEMANARESTORED, ""mana restoration +z%""",please remove the cooldownreduction item from her
+3447,"@@ -24,6 +24,7 @@ CREATE_TABLE = """"""
+         `complete_time` datetime DEFAULT NULL,
+         `status` enum('SUCCESS','RUNNING','FAILURE',
+                       'PARTIAL_SUCCESS','TIMEOUT') DEFAULT NULL,
++        `has_all_data` bool DEFAULT NULL,
+         `schema_version` varchar(255) DEFAULT NULL,
+         `cycle_timestamp` varchar(255) DEFAULT NULL,
+          PRIMARY KEY (`id`),",Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?,I think this should be lowercase to be consistent
+3448,"@@ -35,11 +35,15 @@ final class IdGenerator implements GeneratorInterface
+
+     public function generatePath(MediaInterface $media): string
+     {
+-        $mediaId = (int) $media->getId();
++        $id = $media->getId();
+
+-        $rep_first_level = (int) ($mediaId / $this->firstLevel);
+-        $rep_second_level = (int) (($mediaId - ($rep_first_level * $this->firstLevel)) / $this->secondLevel);
++        if (!is_numeric($id)) {
++            return '';
++        }
+
+-        return sprintf('%s/%04s/%02s', $media->getContext(), $rep_first_level + 1, $rep_second_level + 1);
++        $repFirstLevel = (int) ($id / $this->firstLevel);
++        $repSecondLevel = (int) (($id - ($repFirstLevel * $this->firstLevel)) / $this->secondLevel);
++
++        return sprintf('%s/%04s/%02s', $media->getContext() ?? '', $repFirstLevel + 1, $repSecondLevel + 1);
+     }
+ }","Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?",Why not just `if (!is_numeric($id))`?
+3449,"@@ -48,8 +48,16 @@ import javax.net.ssl.SSLSocketFactory;
+  */
+ public class SalesforceTLSSocketFactory extends SSLSocketFactory {
+
++    private static SalesforceTLSSocketFactory INSTANCE;
+     private SSLSocketFactory ssLSocketFactory;
+
++    public static SalesforceTLSSocketFactory getInstance() throws KeyManagementException, NoSuchAlgorithmException {
++        if (INSTANCE == null) {
++            INSTANCE = new SalesforceTLSSocketFactory();
++        }
++        return INSTANCE;
++    }
++
+     public SalesforceTLSSocketFactory() throws KeyManagementException, NoSuchAlgorithmException {
+         final SSLContext context = SSLContext.getInstance(""TLS"");
+         context.init(null, null, null);",This should be made private.,Instance field should be `final`
+3450,"@@ -267,6 +267,7 @@ func (a *Agent) bootstrap() error {
+ 			BaseSVID:       a.BaseSVID,
+ 			BaseSVIDKey:    a.baseSVIDKey,
+ 			BaseRegEntries: regEntries,
++			BaseSVIDPath:   a.getBaseSVIDPath(),
+ 			Logger:         a.config.Log,
+ 		}
+ ",perhaps this is better modeled as a pkg-level var?,The `BaseSVIDKey` and `BaseSVIDPath`
+3451,"@@ -86,6 +86,10 @@
+ #include ""CmpMain.h""
+
+ #define MAX_NODE_NAME 9
++#define MAX_PRECISION_ALLOWED  18
++#define HIVE_MAX_PRECISION_ALLOWED  38
++#define MAX_SCALE_ALLOWED     6
++#define MAX_NUM_LEN     16
+
+ #include ""SqlParserGlobals.h""
+ ","I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds.",are these two defined somewhere?
+3452,"@@ -775,6 +775,14 @@ func (a *FakeWebAPI) GetProject(ctx context.Context, req *webservice.GetProjectR
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }
+
++func (a *FakeWebAPI) UpdateProjectStaticUser(ctx context.Context, req *webservice.UpdateProjectStaticUserRequest) (*webservice.UpdateProjectStaticUserResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *FakeWebAPI) UpdateProjectSingleSignOn(ctx context.Context, req *webservice.UpdateProjectSingleSignOnRequest) (*webservice.UpdateProjectSingleSignOnResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
+ func (a *FakeWebAPI) GetMe(ctx context.Context, req *webservice.GetMeRequest) (*webservice.GetMeResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`ctx` is unused in UpdateProjectStaticUser,The existing `UpdateProjectStaticUser` and `UpdateProjectSingleSignOn` were implemented to allow for a `webservice.UpdateProjectStaticUserRequest` to be specified.
+3453,"@@ -35,4 +35,10 @@ public class JSTypeNameGenerator extends TypeNameGenerator {
+   public String getStringFormatExample(String format) {
+     return getStringFormatExample(format, ""Date.toISOString()"", ""Date.toISOString()"");
+   }
++
++  @Override
++  public String getDiscoveryDocUrl(String apiName, String apiVersion) {
++    return String.format(
++        ""https://content.googleapis.com/discovery/v1/apis/%s/%s/rest"", apiName, apiVersion);
++  }
+ }","Why is this not the default, and why only for JS?",How about extract this into a constant?
+3454,"@@ -0,0 +1,7 @@
++class ProjectBadge < ActiveRecord::Base
++  belongs_to :project
++  belongs_to :repository
++
++  validates :url, presence: true
++  validates :repository_id, presence: true, uniqueness: { scope: :project_id }
++end",A repository has many badges so we should also add type column in scope.,When is this model used? I don't see any validations here.
+3455,"@@ -82,7 +82,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+             });
+
+             Assert.AreEqual(1, result.CodeFlows.Count);
+-            result.CodeFlows[0].Should().Equal(new[]
++            result.CodeFlows.First().Locations.ToArray().Should().Equal(new[]
+                     {
+                         new AnnotatedCodeLocation {
+                             PhysicalLocation = new PhysicalLocation {","Now a hash set, so can't index into it.",Why do we need to change this to `First()`?
+3456,"@@ -273,6 +273,11 @@ module Bolt
+         !!File::ALT_SEPARATOR
+       end
+
++      # Returns true if running in PowerShell.
++      def powershell?
++        !!ENV['PSModulePath']
++      end
++
+       # Accept hash and return hash with top level keys of type ""String"" converted to symbols.
+       def symbolize_top_level_keys(hsh)
+         hsh.each_with_object({}) { |(k, v), h| k.is_a?(String) ? h[k.to_sym] = v : h[k] = v }",@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?,Is this meant to be `!!ENV['PSModulePath']`?
+3457,"@@ -63,7 +63,7 @@ public class BodyProcessorCreator implements ParamValueProcessorCreator {
+       }
+
+       String contentType = request.getContentType();
+-      if (contentType != null && !contentType.startsWith(MediaType.APPLICATION_JSON)) {
++      if (contentType != null && !contentType.toLowerCase().startsWith(MediaType.APPLICATION_JSON)) {
+         // TODO: we should consider body encoding
+         return IOUtils.toString(inputStream, ""UTF-8"");
+       }",1.toLowerCase(Locale.US)? 2.where is accept bug fix?,Shouldn't we be doing `contentType.toLowerCa
+3458,"@@ -105,16 +105,9 @@ def test_execute_with_invalid_driver(
+ ):
+     _command_args['driver_name'] = 'ec3'
+
+-    with pytest.raises(SystemExit) as e:
++    with pytest.raises(KeyError):
+         _instance.execute()
+
+-    assert 1 == e.value.code
+-
+-    msg = (
+-        'The specified template directory ({template_dir})' ' does not exist'
+-    ).format(template_dir=_instance._resolve_template_dir('scenario/driver/ec3'))
+-    patched_logger_critical.assert_called_once_with(msg)
+-
+
+ def test_execute_with_custom_template(
+     temp_dir, custom_template_dir, custom_readme_content, _command_args",We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?,`patched_logger_critical` was not called any
+3459,"@@ -90,6 +90,7 @@ namespace Nethermind.DataMarketplace.Core.Services
+         {
+             var txData = _abiEncoder.Encode(AbiEncodingStyle.IncludeSignature, ContractData.DepositAbiSig,
+                 deposit.Id.Bytes, deposit.Units, deposit.ExpiryTime);
++            var nonce = await _blockchainBridge.GetNonceAsync(onBehalfOf);
+             Transaction transaction = new Transaction
+             {
+                 Value = deposit.Value,",check Lukasz's fix with NonceReserving - is that not better?,what happens if onBehalfOf is null here?
+3460,"@@ -106,11 +106,8 @@ Blockly.FieldColour.prototype.setValue = function(colour) {
+   }
+   this.colour_ = colour;
+   if (this.sourceBlock_) {
+-    this.sourceBlock_.setColour(
+-      colour,
+-      this.sourceBlock_.getColourSecondary(),
+-      this.sourceBlock_.getColourTertiary()
+-    );
++    // Set the primary, secondary and tertiary colour to this value.
++    this.sourceBlock_.setColour(colour, colour, colour);
+   }
+ };
+ ",Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow.,Do we ever want to set primary to secondary or tertiary?
+3461,"@@ -643,6 +643,8 @@ func (hd *HeaderDownload) SaveExternalAnnounce(hash common.Hash) {
+ }
+
+ func (hd *HeaderDownload) getLink(linkHash common.Hash) (*Link, bool) {
++	hd.lock.RLock()
++	defer hd.lock.RUnlock()
+ 	if link, ok := hd.links[linkHash]; ok {
+ 		return link, true
+ 	}","Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)",Shouldn't this be RLock?
+3462,"@@ -63,4 +63,9 @@ public class GermanKeyboard extends BaseKeyboard {
+     public String getSpaceKeyText(String aComposingText) {
+         return StringUtils.getStringByLocale(mContext, R.string.settings_language_german, getLocale());
+     }
++
++    @Override
++    public String[] getDomains(String... domains) {
++        return super.getDomains("".de"");
++    }
+ }","German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`.",I think you'll need to do this after the super call to `
+3463,"@@ -38,8 +38,6 @@ final class CompositeIndexer {
+         CacheBuilder.from(spec).<PartitionKeyToTraceId, Pair<Long>>build().asMap();
+     Indexer.Factory factory = new Indexer.Factory(session, indexTtl, sharedState);
+     this.indexers = ImmutableSet.of(
+-        factory.create(new InsertTraceIdByServiceName(bucketCount)),
+-        factory.create(new InsertTraceIdBySpanName()),
+         factory.create(new InsertTraceIdByAnnotation(bucketCount))
+     );
+   }","since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this",Can you please explain why this change is needed?
+3464,"@@ -83,6 +83,10 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl {
+       ""/export/apps/azkaban/azkaban-exec-server/current/plugins/jobtypes"";
+   public static final String IMAGE = ""image"";
+   public static final String VERSION = ""version"";
++  public static final String NSCD_SOCKET_VOLUME_NAME = ""nscd-socket"";
++  public static final String NSCD_SOCKET_HOST_PATH = ""/var/run/nscd/socket"";
++  public static final String HOST_PATH_TYPE = ""Socket"";
++  public static final String NSCD_SOCKET_VOLUME_MOUNT_PATH = ""/var/run/nscd/socket"";
+
+   private final String namespace;
+   private final ApiClient client;","Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it.",These two constants should be defined in the `NSCD_SOCKET_VOLUME_NAME` class.
+3465,"@@ -533,7 +533,12 @@ func (a *Account) EnableJetStream(limits *JetStreamAccountLimits) error {
+ 				s.Warnf(""  Error adding Stream %q to Template %q: %v"", cfg.Name, cfg.Template, err)
+ 			}
+ 		}
+-		mset, err := a.AddStream(&cfg.StreamConfig)
++		// TODO: We should not rely on the stream name.
++		// However, having a StreamConfig property, such as AllowNoSubject,
++		// was not accepted because it does not make sense outside of the
++		// MQTT use-case. So need to revisit this.
++		mqtt := cfg.StreamConfig.Name == mqttStreamName
++		mset, err := a.addStreamWithStore(&cfg.StreamConfig, nil, mqtt)
+ 		if err != nil {
+ 			s.Warnf(""  Error recreating Stream %q: %v"", cfg.Name, err)
+ 			continue",Could be a non-public field. `allowNoSubject`,I don't think it should be allowed to add a stream without store.
+3466,"@@ -588,12 +588,12 @@ func (c *Client) execute(tid int, target *core.BuildTarget, command *pb.Command,
+ 	} else if target.IsTextFile {
+ 		return c.buildTextFile(target, command, digest)
+ 	}
+-	return c.reallyExecute(tid, target, command, digest, needStdout, isTest)
++	return c.reallyExecute(tid, target, command, digest, needStdout, isTest, (c.state.ForceRerun && isTest) || (!isTest && c.state.ForceRebuild))
+ }
+
+ // reallyExecute is like execute but after the initial cache check etc.
+ // The action & sources must have already been uploaded.
+-func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Command, digest *pb.Digest, needStdout, isTest bool) (*core.BuildMetadata, *pb.ActionResult, error) {
++func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Command, digest *pb.Digest, needStdout, isTest, skipCacheLookup bool) (*core.BuildMetadata, *pb.ActionResult, error) {
+ 	executing := false
+ 	updateProgress := func(metadata *pb.ExecuteOperationMetadata) {
+ 		if c.state.Config.Remote.DisplayURL != """" {",Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`),The `skipCacheLookup` parameter here is a little confusing. Why not just pass
+3467,"@@ -62,6 +62,12 @@ class Autocomplete
+         return array('results' => $this->processResults($paginator->getCurrentPageResults(), $backendConfig['entities'][$entity]));
+     }
+
++    /**
++     * @param array $entities
++     * @param array $targetEntityConfig
++     *
++     * @return array
++     */
+     private function processResults($entities, $targetEntityConfig)
+     {
+         $results = array();",what about adding typehints instead? I don't think we need to add docblocks for every private methods.,why not using the return type of processResults here?
+3468,"@@ -76,6 +76,7 @@ func createVolumeBuilder(cStorVolumeReplica *apis.CStorVolumeReplica, fullVolNam
+ 	openebsTargetIP := ""io.openebs:targetip="" + cStorVolumeReplica.Spec.TargetIP
+
+ 	createVolAttr = append(createVolAttr, ""create"",
++		""-b"", ""4K"", ""-s"", ""-o"", ""compression=on"",
+ 		""-V"", cStorVolumeReplica.Spec.Capacity, fullVolName,
+ 		""-o"", openebsTargetIP, ""-o"", openebsVolname)
+ ","Is it fine to pass the ""-o compression=on"" in the middle instead of at the end ?",Is there a way to test this?
+3469,"@@ -18,14 +18,18 @@ module Bolt
+     attr_reader :noop, :transports
+     attr_accessor :run_as
+
++    # FIXME: There must be a better way
++    # https://makandracards.com/makandra/36011-ruby-do-not-mix-optional-and-keyword-arguments
+     def initialize(concurrency = 1,
+                    analytics = Bolt::Analytics::NoopClient.new,
+                    noop = nil,
+-                   bundled_content: nil)
++                   bundled_content: nil,
++                   load_config: true)
+       @analytics = analytics
+       @bundled_content = bundled_content
+       @logger = Logging.logger[self]
+       @plan_logging = false
++      @load_config = load_config
+
+       @transports = Bolt::TRANSPORTS.each_with_object({}) do |(key, val), coll|
+         coll[key.to_s] = Concurrent::Delay.new do",Probably make them all keyword arguments.,I think it would be better t
+3470,"@@ -521,11 +521,7 @@ define([""loading"", ""appRouter"", ""layoutManager"", ""connectionManager"", ""cardBuild
+         renderDetails(page, item, apiClient, context);
+         renderTrackSelections(page, instance, item);
+
+-        if (dom.getWindowSize().innerWidth >= 1000) {
+-            backdrop.setBackdrops([item]);
+-        } else {
+-            backdrop.clear();
+-        }
++        backdrop.clear();
+
+         renderDetailPageBackdrop(page, item, apiClient);
+         var canPlay = reloadPlayButtons(page, item);",Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds.,Any reason to remove this? T
+3471,"@@ -41,7 +41,7 @@ namespace AutoRest.Swagger.Validation
+         /// <summary>
+         /// The severity of this message (ie, debug/info/warning/error/fatal, etc)
+         /// </summary>
+-        public override Category Severity => Category.Error;
++        public override Category Severity => Category.Warning;
+
+         ///// <summary>
+         ///// Validates whether property names are camelCase in body parameters.",why are we turning this one into a Warning?,@JeremyKuhne do you think we
+3472,"@@ -631,7 +631,7 @@ public class GUI implements CPDListener {
+             int separatorPos = sourceId.lastIndexOf(File.separatorChar);
+             label = ""..."" + sourceId.substring(separatorPos);
+         } else {
+-            label = '(' + sourceIDs.size() + "" separate files)"";
++            label = '(' + String.valueOf(sourceIDs.size()) + "" separate files)"";
+         }
+
+         match.setLabel(label);",Wouldn't it be better to use double quotes for the opening parenthesis ?,Why not just do `String.format` here?
+3473,"@@ -716,7 +716,7 @@ bool IOLoginData::savePlayer(Player* player)
+ 	if (!player->isOffline()) {
+ 		query << ""`onlinetime` = `onlinetime` + "" << (time(nullptr) - player->lastLoginSaved) << ',';
+ 	}
+-	query << ""`blessings` = "" << static_cast<uint32_t>(player->blessings);
++	query << ""`blessings` = "" << static_cast<uint32_t>(player->blessings.to_ulong());
+ 	query << "" WHERE `id` = "" << player->getGUID();
+
+ 	DBTransaction transaction;",Remove the cast,`player->blessings.to_ulong()` is fas
+3474,"@@ -1,4 +1,4 @@
+-// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
++// Copyright (c) 2016-2018 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");
+ // you may not use this file except in compliance with the License.",What criteria do we use to bump the copyright years? An update to the module?,I don't think this is a valid copyrig
+3475,"@@ -267,6 +267,7 @@ class Resize:
+                     interpolation='nearest',
+                     backend=self.backend)
+             results['gt_semantic_seg'] = gt_seg
++            results[key] = gt_seg
+
+     def __call__(self, results):
+         """"""Call function to resize images, bounding boxes, masks, semantic",should we rm line 269?,Shouldn't this also be `self.key = gt
+3476,"@@ -68,7 +68,9 @@ class NVDASpyLib:
+
+ 	# callbacks for extension points
+ 	def _onNvdaStartupComplete(self):
+-		self._isNvdaStartupComplete = True
++		# Queue the setting of the completion variable,
++		# To ensure that NvDA's core loop has started running, and it has processed initial focus.
++		queueHandler.queueFunction(queueHandler.eventQueue, lambda: setattr(self, '_isNvdaStartupComplete', True))
+
+ 	def _onNvdaSpeech(self, speechSequence=None):
+ 		if not speechSequence:","Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect.",When is the completion variable not set?
+3477,"@@ -25,6 +25,13 @@ FactoryGirl.define do
+         cart.save!
+       end
+
++      factory :cart_with_all_approvals_approved do
++        after :create do |cart|
++          cart.approvals.each {|a| a.update_attribute :status, 'approved'}
++          cart.update_attribute :status, 'approved'
++        end
++      end
++
+       factory :cart_with_approvals_and_items do
+         after :create do |cart|
+           cart.cart_items << FactoryGirl.create(:cart_item, cart_id: cart.id)",Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point.,Layout/SpaceInsideBlockBraces: Space ins
+3478,"@@ -291,9 +291,13 @@ func (o *Outbound) callWithPeer(
+ 	if response.StatusCode >= 200 && response.StatusCode < 300 {
+ 		appHeaders := applicationHeaders.FromHTTPHeaders(
+ 			response.Header, transport.NewHeaders())
+-		appError := response.Header.Get(ApplicationStatusHeader) == ApplicationErrorStatus
++		appError := fromApplicationStatusValue(response.Header.Get(ApplicationStatusHeader))
++		acceptResponseError := fromAcceptValue(response.Header.Get(AcceptResponseErrorHeader))
+ 		return &transport.Response{
+-			Headers:          appHeaders,
++			Headers: appHeaders,
++			Features: transport.ResponseFeatures{
++				AcceptResponseError: acceptResponseError,
++			},
+ 			Body:             response.Body,
+ 			ApplicationError: appError,
+ 		}, nil","wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?",I would have expected you to use `fromAc
+3479,"@@ -66,7 +66,9 @@ public class ProtoParserTest {
+     testDataLocator = TestDataLocator.create(GapicCodeGeneratorAnnotationsTest.class);
+     testDataLocator.addTestDataSource(CodegenTestUtil.class, ""testsrc/common"");
+
+-    model = CodegenTestUtil.readModel(testDataLocator, tempDir, protoFiles, new String[0]);
++    model =
++        CodegenTestUtil.readModel(
++            testDataLocator, tempDir, protoFiles, new String[] {""library.yaml""});
+
+     libraryProtoFile =
+         model",Adding in the service yaml `library.yaml` here.,"I think this should be ""library.yaml"" in"
+3480,"@@ -63,7 +63,7 @@ func (a BasicAuth) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error
+
+ 			// let upstream middleware (e.g. fastcgi and cgi) know about authenticated
+ 			// user; this replaces the request with a wrapped instance
+-			r = r.WithContext(context.WithValue(r.Context(),
++			*r = *r.WithContext(context.WithValue(r.Context(),
+ 				httpserver.RemoteUserCtxKey, username))
+ 		}
+ 	}",Why is this dereference needed?,I don't think this is right. We should not modify the request with a wrapped instance.
+3481,"@@ -36,7 +36,8 @@ import (
+ // * `tlfNode` allows auto-creation of subdirectories representing
+ //   valid repository checkouts of the corresponding TLF, e.g.
+ //   `.kbfs_autogit/private/chris/dotfiles`.  It wraps child nodes in
+-//   two ways, as both a `readonlyNode` and a `repoNode`.
++//   two ways, as both a `readonlyNode` and a `repoNode`.  It allows
++//   repo directories to be removed via `RemoveDir`.
+ // * `repoNode` allow auto-clone and auto-pull of the corresponding
+ //   repository on its first access.  When the directory corresponding
+ //   to the node is read for the first time for this KBFS instance,",Might want to add that this only happens if you have write permissions to the folder.,"Maybe say ""It allows child directories to be removed"""
+3482,"@@ -53,6 +53,12 @@ type Config struct {
+ 	// to use based on region.
+ 	EndpointResolver endpoints.Resolver
+
++	// EnforceShouldRetryCheck is used in the AfterRetryHandler to always call
++	// ShouldRetry. If this is set and ShouldRetry is called, then the request's
++	// Retryable field can be either nil or set. Proper handling of the Retryable
++	// field is important when setting this field.
++	EnforceShouldRetryCheck *bool
++
+ 	// The region to send requests to. This parameter is required and must
+ 	// be configured globally or on a per-client basis unless otherwise
+ 	// noted. A full list of regions is found in the ""Regions and Endpoints""",Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled.,How about `EnforceRetryable`?
+3483,"@@ -59,6 +59,6 @@ func Register(registry transport.Registry, service Service) {
+ 	proto := service.Protocol()
+ 	for method, h := range service.Handlers() {
+ 		handler := thriftHandler{Handler: h, Protocol: proto}
+-		registry.Register(procedureName(name, method), handler)
++		registry.Register("""", procedureName(name, method), handler)
+ 	}
+ }",assume the user will be able to register for a custom service name in future?,Is the empty string here intentional?
+3484,"@@ -27,7 +27,9 @@ using System.Threading.Tasks;
+ using JetBrains.Annotations;
+ using pwiz.Common.Collections;
+ using pwiz.Common.SystemUtil;
+-using pwiz.Skyline.Util;
++using pwiz.Skyline.Util;
++
++
+ // ReSharper disable InconsistentlySynchronizedField
+
+ namespace pwiz.Skyline.Controls.Graphs",The extra two empty lines seem unnecessary. Please review your diffs more carefully.,Unused using statement.
+3485,"@@ -28,7 +28,7 @@ type API interface {
+ 	LiveToken() TokenAPI
+ 	SideToken() TokenAPI
+ 	TestToken() TestTokenAPI
+-	OracleUSD() OracleAPI
++	OracleAPI
+ }
+
+ type ProfileRegistryAPI interface {",What the reason to embed the Oracle?,This was renamed to `Or
+3486,"@@ -53,6 +53,8 @@ Workshops::Application.routes.draw do
+     resources :purchases, only: :index
+   end
+
++  match 'pages/new-topics' => 'pages#show', id: 'new-topics'
++
+   match '/auth/:provider/callback', to: 'auth_callbacks#create'
+
+   match '/watch' => 'high_voltage/pages#show', as: :watch, id: 'watch'",Shouldn't this happen automatically with High Voltage?,can we add this as a `o
+3487,"@@ -505,7 +505,7 @@ public class InitCodeTransformer {
+         InitValue initValue = initValueConfig.getResourceNameBindingValues().get(entityName);
+         switch (initValue.getType()) {
+           case Variable:
+-            entityValue = context.getNamer().localVarName(Name.from(initValue.getValue()));
++            entityValue = context.getNamer().varReference(Name.from(initValue.getValue()));
+             break;
+           case Random:
+             entityValue = context.getNamer().injectRandomStringGeneratorCode(initValue.getValue());",This is changed because we need `projectId` to be printed as `$projectId` in PHP.,Why do you need to get
+3488,"@@ -1,7 +1,7 @@
+ <div class=""row"">
+   <div class=""col-md-12"">
+     <h1>
+-      <%= _('Template History') %>
++      <%= templates.first.customization_of.present? ? _('Template Customisation History') : _('Template History') %>
+       <div class=""pull-right"">
+         <%= link_to _('View all templates'), referrer, class: ""btn btn-primary"" %>
+       </div>",This title change seems more accurate to me however not sure if this will confuse users.,Are you sure this is correct? I thought we had translations for customisation?
+3489,"@@ -117,7 +117,8 @@ private
+     # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL
+     return nil if value =~ /^https?:\/\//
+
+-    if key == ""wikipedia""
++    # match wikipedia or xxxxx:wikipedia
++    if key =~ /^(?:.*:)*wikipedia$/
+       # This regex should match Wikipedia language codes, everything
+       # from de to zh-classical
+       if value =~ /^([a-z-]{2,12}):(.+)$/i","Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested","`xxxxx:wikipedia` is a bit ambiguous, how about `/wiki/xxxxx/`?"
+3490,"@@ -505,7 +505,13 @@ class RAMHandler(logging.Handler):
+             if record.levelno >= minlevel:
+                 lines.append(fmt(record))
+         return '\n'.join(lines)
+-
++
++    def change_log_capacity(self, capacity):
++        """"""
++        change log capacity according to user specifcation
++        """"""
++        ram_handler = RAMHandler(capacity=capacity)
++        self._data = collections.deque(self._data, maxlen=capacity)
+
+ class ColoredFormatter(logging.Formatter):
+ ",Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?,s/` according to user specifcation`/`according to user level`/ ?
+3491,"@@ -25,7 +25,11 @@ void CreateEdgeIndexProcessor::process(const cpp2::CreateEdgeIndexReq& req) {
+     auto ret = getEdgeIndexID(space, indexName);
+     if (ret.ok()) {
+         LOG(ERROR) << ""Create Edge Index Failed: "" << indexName << "" have existed"";
+-        resp_.set_code(cpp2::ErrorCode::E_EXISTED);
++        if (req.get_if_not_exists()) {
++            resp_.set_code(cpp2::ErrorCode::SUCCEEDED);
++        } else {
++            resp_.set_code(cpp2::ErrorCode::E_EXISTED);
++        }
+         onFinished();
+         return;
+     }",Move the line 27 to line 31 is better?,Should this if-else block be inside the one above?
+3492,"@@ -4704,6 +4704,11 @@ func (fbo *folderBranchOps) applyMDUpdatesLocked(ctx context.Context,
+ 				return err
+ 			}
+ 		}
++		if rmd.IsRekeySet() {
++			fbo.rekeyFSM.Event(NewRekeyRequestEvent())
++		} else {
++			fbo.rekeyFSM.Event(NewRekeyNotNeededEvent())
++		}
+ 		appliedRevs = append(appliedRevs, rmd)
+ 	}
+ 	if len(appliedRevs) > 0 {","In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it.",Can we also do this in `ValidateRekeySet`?
+3493,"@@ -66,12 +66,6 @@ RSpec.configure do |config|
+   # particularly slow.
+   config.profile_examples = 10
+
+-  # Run specs in random order to surface order dependencies. If you find an
+-  # order dependency and want to debug it, you can fix the order by providing
+-  # the seed, which is printed after each run.
+-  #     --seed 1234
+-  config.order = :random
+-
+   # Seed global randomization in this process using the `--seed` CLI option.
+   # Setting this allows you to use `--seed` to deterministically reproduce
+   # test failures related to randomization by passing the same `--seed` value","I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme.",moved to `spec/helpers/unit_tests.rb`
+3494,"@@ -156,11 +156,15 @@ function isVisible(el, screenReader, recursed) {
+   }
+
+   // hidden from visual users
++  const elHeight = parseInt(style.getPropertyValue('height'));
+   if (
+     !screenReader &&
+     (isClipped(style) ||
+       style.getPropertyValue('opacity') === '0' ||
+-      (getScroll(el) && parseInt(style.getPropertyValue('height')) === 0))
++      (getScroll(el) && elHeight === 0) ||
++      (style.getPropertyValue('position') === 'absolute' &&
++        elHeight <= 1 &&
++        style.getPropertyValue('overflow') === 'hidden'))
+   ) {
+     return false;
+   }",Is there a reason you left this at 0?,"In the case of `position: absolute`, do we"
+3495,"@@ -267,6 +267,11 @@ public final class RememberMeConfigurer<H extends HttpSecurityBuilder<H>>
+ 		validateInput();
+ 		String key = getKey();
+ 		RememberMeServices rememberMeServices = getRememberMeServices(http, key);
++		if (key == null) {
++			if (rememberMeServices instanceof AbstractRememberMeServices) {
++				key = ((AbstractRememberMeServices) rememberMeServices).getKey();
++			}
++		}
+ 		http.setSharedObject(RememberMeServices.class, rememberMeServices);
+ 		LogoutConfigurer<H> logoutConfigurer = http.getConfigurer(LogoutConfigurer.class);
+ 		if (logoutConfigurer != null && this.logoutHandler != null) {","The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`.",I don't think this logic should be here. L
+3496,"@@ -88,11 +88,18 @@ namespace Datadog.Trace.ClrProfiler
+                 return null;
+             }
+
++            var commandType = command.GetType();
++            if (tracer.Settings.AdoNetExcludedTypes.Contains(commandType.FullName))
++            {
++                // AdoNet type disabled, don't create a scope, skip this trace
++                return null;
++            }
++
+             Scope scope = null;
+
+             try
+             {
+-                string dbType = GetDbType(command.GetType().Name);
++                string dbType = GetDbType(commandType.Name);
+
+                 if (dbType == null)
+                 {",NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path),@johnsimons do you know if this is safe to do for now?
+3497,"@@ -18,6 +18,9 @@ package v1alpha1
+
+ import (
+ 	ndm ""github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1""
++
++	""strings""
++
+ 	errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/resource""",should rearrange so as to follow import ordering.,move down :-)
+3498,"@@ -65,7 +65,7 @@ func (s *validateOperationWorkflowModeStateSuite) TestCreateMode_UpdateCurrent()
+ 	stateToError := map[enumsspb.WorkflowExecutionState]bool{
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_CREATED:   false,
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING:   false,
+-		enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: true,
++		enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE:    true,
+ 	}
+ ",what is the use case for create workflow with completed state?,did you mean to change this line?
+3499,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....,no need for this test class. There is already a test c
+3500,"@@ -0,0 +1,15 @@
++#include <impl/Kokkos_Tools.hpp>
++
++int main(int argc, char* argv[]) {
++  Kokkos::Tools::initialize(argc, argv);
++  Kokkos::Tools::pushRegion(
++      ""The unanimous Declaration of the thirteen united States of America, ""
++      ""When in the Course of human events, it becomes necessary for one people ""
++      ""to dissolve the political bands which have connected them with another, ""
++      ""and to assume among the powers of the earth, the separate and equal ""
++      ""station to which the Laws of Nature and of Nature's God entitle them, a ""
++      ""decent respect to the opinions of mankind requires that they should ""
++      ""declare the causes which impel them to the separation."");
++  Kokkos::Tools::popRegion();
++  Kokkos::Tools::finalize();
++}",Missing the license,why not `Kokkos::Tools::popRegion()`?
+3501,"@@ -210,11 +210,9 @@ func (p *ReplicationTaskProcessorImpl) eventLoop() {
+ 			))
+
+ 		case <-cleanupTimer.C:
+-			if p.config.EnableCleanupReplicationTask() {
+-				if err := p.cleanupReplicationTasks(); err != nil {
+-					p.logger.Error(""Failed to clean up replication messages."", tag.Error(err))
+-					p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupFailure)
+-				}
++			if err := p.cleanupReplicationTasks(); err != nil {
++				p.logger.Error(""Failed to clean up replication messages."", tag.Error(err))
++				p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupFailure)
+ 			}
+ 			cleanupTimer.Reset(backoff.JitDuration(
+ 				p.config.ReplicationTaskProcessorCleanupInterval(shardID),",Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?,why remove the `EnableCleanupReplicat
+3502,"@@ -37,7 +37,6 @@
+         #include ""tbb/tbb.h""
+         #include <tbb/task_arena.h>
+         #include <tbb/task_scheduler_observer.h>
+-        #include <tbb/task_scheduler_init.h>
+         #include <tbb/parallel_reduce.h>
+         #include <tbb/blocked_range.h>
+         #include <tbb/tick_count.h>","Potentially it'll be good to remove all of them excluding ""tbb/tbb.h"" But let's do it next time  ",Why remove this?
+3503,"@@ -1210,3 +1210,19 @@ def is_nan(x):
+         return np.isnan(x)
+     except:
+         return False
++
++
++def bound_range(vals, density):
++    """"""
++    Computes a bounding range from a number of evenly spaced samples.
++    Will raise an error if samples are not evenly spaced within
++    tolerance.
++    """"""
++    low, high = vals.min(), vals.max()
++    invert = False
++    if vals[0] > vals[1]:
++        invert = True
++    if not density:
++        density = round(1./((high-low)/(len(vals)-1)), sys.float_info.dig)
++    halfd = 0.5/density
++    return low-halfd, high+halfd, density, invert",I would just mention which tolerance - namely as reported by ``sys.float_info``,"we don't use `sys.float_info.dig`, do"
+3504,"@@ -18,8 +18,9 @@ class ProposalsController < ApplicationController
+
+   def index
+     @CLOSED_PROPOSAL_LIMIT = 10
++
+     @pending_data = self.listing.pending
+-    @approved_data = self.listing.approved(@CLOSED_PROPOSAL_LIMIT)
++    @approved_data = self.listing.approved.alter_query{ |rel| rel.limit(@CLOSED_PROPOSAL_LIMIT) }
+     @cancelled_data = self.listing.cancelled
+   end
+ ",:+1: Ideally this'll become something you could pass in to the config,Space missing to the left of {.<br>Space missing inside }.
+3505,"@@ -775,7 +775,7 @@ void RaftPart::replicateLogs(folly::EventBase* eb,
+             return resp.get_error_code() == cpp2::ErrorCode::SUCCEEDED
+                     && !hosts[index]->isLearner();
+         })
+-        .then(executor_.get(), [self = shared_from_this(),
++        .via(executor_.get()).then([self = shared_from_this(),
+                    eb,
+                    it = std::move(iter),
+                    currTerm,",Should using `thenValue` to replace `then` ?,The error code is `SUCCEEDED` in the spec. Should it be `S
+3506,"@@ -130,6 +130,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+
+         private void OnError(object sender, EventArgs eventArgs)
+         {
++            if (!Tracer.Instance.Settings.IsIntegrationEnabled(IntegrationName))
++            {
++                // integration disabled
++                return;
++            }
++
+             try
+             {
+                 if (!TryGetContext(sender, out var httpContext) || httpContext.Error == null ||",This follows the convention of each callback starting with the `IsIntegrationEnabled` check.,should we log something?
+3507,"@@ -26,11 +26,15 @@ namespace OpenTelemetry.Metrics
+         private long sumLong = 0;
+         private SumMetricLong sumMetricLong;
+         private DateTimeOffset startTimeExclusive;
++        private bool isDeltaValue;
++        private bool isMonotonicValue;
+
+-        internal SumMetricAggregatorLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair<string, object>[] attributes)
++        internal SumMetricAggregatorLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair<string, object>[] attributes, bool isDeltaValue, bool isMonotonicValue)
+         {
+             this.startTimeExclusive = startTimeExclusive;
+             this.sumMetricLong = new SumMetricLong(name, description, unit, meter, startTimeExclusive, attributes);
++            this.isDeltaValue = isDeltaValue;
++            this.isMonotonicValue = isMonotonicValue;
+         }
+
+         public void Update<T>(T value)","this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)",Is there a reason why you couldn't pass `isDeltaValue` as
+3508,"@@ -0,0 +1,12 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Transport
++{
++    public interface IConnectionHandler
++    {
++        IConnectionContext OnConnection(IConnectionInformation connectionInfo, IScheduler inputWriterScheduler, IScheduler outputReaderScheduler);
++    }
++}",Add the PipeFactory here,Is this an interface or does it need to be public?
+3509,"@@ -23,15 +23,12 @@ import (
+ 	""github.com/pkg/errors""
+
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+-	""github.com/chaos-mesh/chaos-mesh/controllers/common""
+ )
+
+ type Delegate struct {
+ 	impl interface{}
+ }
+
+-var _ common.ChaosImpl = (*Delegate)(nil)
+-
+ func (i *Delegate) callAccordingToAction(action, methodName string, defaultPhase v1alpha1.Phase, args ...interface{}) (v1alpha1.Phase, error) {
+ 	implType := reflect.TypeOf(i.impl).Elem()
+ 	implVal := reflect.ValueOf(i.impl)",please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`,This was the only use of the `ChaosImpl` so I remo
+3510,"@@ -97,4 +97,15 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> {
+    * @return this for method chaining
+    */
+   ExpireSnapshots executeWith(ExecutorService executorService);
++
++  /**
++   * Allows expiration of snapshots without any cleanup of underlying manifest or data files.
++   * <p>
++   * Allows control in removing data and manifest files which may be more efficiently removed using
++   * a distributed framework through the actions API.
++   *
++   * @param clean setting this to false will skip deleting expired manifests and files
++   * @return this for method chaining
++   */
++  ExpireSnapshots cleanExpiredFiles(boolean clean);
+ }",nit: is this added deliberately?,Do we also need to set `clean = true` here?
+3511,"@@ -8,6 +8,8 @@ class SiteControllerTest < ActionController::TestCase
+   def setup
+     Object.const_set(""ID_KEY"", client_applications(:oauth_web_app).key)
+     Object.const_set(""POTLATCH2_KEY"", client_applications(:oauth_web_app).key)
++
++    stub_request(:get, ""http://api.hostip.info/country.php?ip=0.0.0.0"")
+   end
+
+   ##",Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?,Do we need to specify the domain here?
+3512,"@@ -495,6 +495,16 @@ function applyWriteConcern(target, sources, options) {
+   return target;
+ }
+
++/**
++ * Checks if a given value is a Promise
++ *
++ * @param {*} maybePromise
++ * @return true if the provided value is a Promise
++ */
++function isPromiseLike(maybePromise) {
++  return maybePromise && typeof maybePromise.then === 'function';
++}
++
+ exports.filterOptions = filterOptions;
+ exports.mergeOptions = mergeOptions;
+ exports.translateOptions = translateOptions;","we don't use this anymore, so we can delete it.",Why not use `typeof maybePromise.then === 'function'`?
+3513,"@@ -283,6 +283,8 @@ func initTelemetry(genesis bookkeeping.Genesis, log logging.Logger, dataDirector
+ 			fmt.Fprintln(os.Stdout, ""error loading telemetry config"", err)
+ 			return
+ 		}
++		fmt.Fprintln(os.Stdout, ""algoh telemetry configured from file:"", telemetryConfig.FilePath)
++
+
+ 		// Apply telemetry override.
+ 		telemetryConfig.Enable = logging.TelemetryOverride(*telemetryOverride)","nit: change to ""Telemetry configuration loaded from '%s'""",Typo: `algoh telemetry` -> `algo to telemetry`
+3514,"@@ -182,7 +182,8 @@ func TestSerialiseBlockWitness(t *testing.T) {
+ 	if err := bwb.WriteTo(&b); err != nil {
+ 		t.Errorf(""Could not make block witness: %v"", err)
+ 	}
+-	expected := common.FromHex(""0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c75657300582023181a62d35fe01562158be610f84e047f99f5e74d896da21682d925964ece3a0601024704010402040304"")
++
++	expected := common.FromHex(""0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c756573005820858f70a4b1e6aa71a7edc574d2ca946495a038aa37ce13dc7b7ed15661a6ff2f0601024704010402040304"")
+ 	if !bytes.Equal(expected, b.Bytes()) {
+ 		t.Errorf(""Expected %x, got: %x"", expected, b.Bytes())
+ 	}",Why did this value change?,how did this test pass before?
+3515,"@@ -23,6 +23,7 @@ import (
+ 	duckv1 ""knative.dev/pkg/apis/duck/v1""
+ 	""knative.dev/pkg/kmeta""
+
++	gcpduckv1alpha1 ""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1""
+ 	""github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1""
+ )
+ ",maybe `duckpubsubv1alpha1` ?,I don't think this is needed.
+3516,"@@ -327,6 +327,16 @@ class FirefoxProfile(object):
+                     rc.append(node.data)
+             return ''.join(rc).strip()
+
++        def parse_manifest_json(content):
++            """"""Extracts the details from the contents of a WebExtensions `manifest.json` file.""""""
++            manifest = json.loads(content)
++            return {
++                'id': manifest['applications']['gecko']['id'],
++                'version': manifest['version'],
++                'name': manifest['version'],
++                'unpack': False,
++            }
++
+         if not os.path.exists(addon_path):
+             raise IOError('Add-on path does not exist: %s' % addon_path)
+ ",The id is not mandatory for web extensions. Could you update this to support a web extension without an id?,Can you rename this to `_parse_manifest_json`?
+3517,"@@ -31,11 +31,6 @@ import (
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+ )
+
+-const (
+-	serviceName = ""pubsub.googleapis.com""
+-	methodName  = ""google.pubsub.v1.Publisher.CreateTopic""
+-)
+-
+ func CloudAuditLogsSourceWithTestImpl(t *testing.T, authConfig lib.AuthConfig) {
+ 	project := os.Getenv(lib.ProwProjectKey)
+ ","I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself.",thanks for cleaning these
+3518,"@@ -97,9 +97,11 @@ func (t *tty) recvtty(process *libcontainer.Process, socket *os.File) error {
+ 	// set raw mode to stdin and also handle interrupt
+ 	stdin, err := console.ConsoleFromFile(os.Stdin)
+ 	if err != nil {
++		epollConsole.Close()
+ 		return err
+ 	}
+ 	if err := stdin.SetRaw(); err != nil {
++		epollConsole.Close()
+ 		return fmt.Errorf(""failed to set the terminal from the stdin: %v"", err)
+ 	}
+ 	go handleInterrupt(stdin)",I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it.,"epollConsole is closed by `OnInterrupt`, so we"
+3519,"@@ -1048,6 +1048,12 @@ stats (config.stat_config),
+ vote_uniquer (block_uniquer),
+ startup_time (std::chrono::steady_clock::now ())
+ {
++	if (config.websocket_config.enabled)
++	{
++		websocket_server = std::make_shared<nano::websocket::listener> (*this, nano::tcp_endpoint (boost::asio::ip::address_v6::any (), config.websocket_config.port));
++		this->websocket_server->run ();
++	}
++
+ 	wallets.observer = [this](bool active) {
+ 		observers.wallet.notify (active);
+ 	};",The bind address should be configurable.,Any reason why run the entire websocket server
+3520,"@@ -68,6 +68,11 @@ class LocalRepository implements Repository {
+         return fetchCategories(categoryDirectories);
+     }
+
++    @Override
++    public void delete() {
++        // nothing to do
++    }
++
+     private List<CategoryDTO> fetchCategories(File[] categoryDirectories) {
+         final List<CategoryDTO> results = new ArrayList<>();
+ ",Maybe the empty `delete()` should be implemented as default in the interface.,"For some reason the delete doesn't seem to do anything, it just does a normal delete."
+3521,"@@ -24,7 +24,7 @@ class HDF5OutputLayerTest : public ::testing::Test {
+  protected:
+   HDF5OutputLayerTest()
+       : output_file_name_(tmpnam(NULL)),
+-        input_file_name_(""src/caffe/test/test_data/sample_data.h5""),
++        input_file_name_(CMAKE_SOURCE_DIR  ""caffe/test/test_data/sample_data.h5""),
+         blob_data_(new Blob<Dtype>()),
+         blob_label_(new Blob<Dtype>()),
+         num_(5),",How to ensure CMAKE_SOURCE_DIR is set correctly?,This should probably be in `src/` or `src/caffe/test/src/`
+3522,"@@ -106,7 +106,7 @@ func (ws *workingSet) LoadOrCreateAccountState(addr string, init *big.Int) (*Acc
+ 	switch {
+ 	case errors.Cause(err) == ErrStateNotExist:
+ 		account := Account{
+-			Balance:      init,
++			Balance:      big.NewInt(0).SetBytes(init.Bytes()),
+ 			VotingWeight: big.NewInt(0),
+ 		}
+ 		ws.cachedStates[addrHash] = &account",safer to make a copy of incoming *big.Int,Why is a `big.NewInt(0)` needed here?
+3523,"@@ -19,6 +19,8 @@ import ""time""
+ const (
+ 	// ListContainersTimeout is the timeout for the ListContainers API.
+ 	ListContainersTimeout = 10 * time.Minute
++	// ListImagesTimeout is the timeout for the ListImages API
++	ListImagesTimeout = 10 * time.Minute
+ 	// LoadImageTimeout is the timeout for the LoadImage API. It's set
+ 	// to much lower value than pullImageTimeout as it involves loading
+ 	// image from either a file or STDIN",how did we choose this value? does this hold good for Windows too?,How is this related to the rest of the PR?
+3524,"@@ -0,0 +1,17 @@
++// +build nocriu
++
++package libcontainer
++
++import (
++	""errors""
++)
++
++var errNotEnabled = errors.New(""Checkpoint/restore not supported"")
++
++func (c *linuxContainer) Checkpoint(opts *CheckpointOpts) error {
++	return errNotEnabled
++}
++
++func (c *linuxContainer) Restore(process *Process, opts *CheckpointOpts) error {
++	return errNotEnabled
++}","To follow the other build tags, maybe we can call it `criu`?","I'd say this should be `errors.New(""Checkpoint/restore is not supported"")`"
+3525,"@@ -20,9 +20,10 @@ module Bolt
+       log_destination: STDERR
+     }.freeze
+
+-    TRANSPORT_OPTIONS = %i[insecure password run_as sudo sudo_password key tty user].freeze
++    TRANSPORT_OPTIONS = %i[insecure password run_as sudo sudo_password key tty user connect_timeout].freeze
+
+     TRANSPORT_DEFAULTS = {
++      connect_timeout: 10,
+       insecure: false,
+       tty: false
+     }.freeze",Should we load this from the config file too?,"this seems to be unrelated to this PR, should it be a separate PR?"
+3526,"@@ -128,6 +128,12 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 		}
+
+ 		nextRecover := now.Add(*duration)
++		// TODO(at15): this should be validated in webhook instead of throwing error at runtime.
++		// User can give a cron with interval shorter than duration.
++		// Example:
++		//  duration: ""10s""
++		//  scheduler:
++		//    cron: ""@every 5s
+ 		if nextStart.Before(nextRecover) {
+ 			err := fmt.Errorf(""nextRecover shouldn't be later than nextStart"")
+ 			r.Log.Error(err, ""nextRecover is later than nextStart. Then recover can never be reached"",",Can you file an issue for this?,Can you also validate that the interval is greater than or equal to the st
+3527,"@@ -122,7 +122,7 @@ class Connection extends EventEmitter {
+       if (issue.isTimeout) {
+         op.cb(
+           new MongoNetworkTimeoutError(`connection ${this.id} to ${this.address} timed out`, {
+-            beforeHandshake: !!this[kIsMaster]
++            beforeHandshake: this[kIsMaster] == null
+           })
+         );
+       } else if (issue.isClose) {",@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests,Why change this from boolean to null?
+3528,"@@ -51,6 +51,19 @@ module Bolt
+       end
+     end
+
++    def setup_inventory(inventory)
++      config = Bolt::Config.default
++      config.overwrite_transport_data(inventory['config']['transport'],
++                                      Bolt::Util.symbolize_top_level_keys(inventory['config']['transports']))
++
++      bolt_inventory = Bolt::Inventory.new(inventory['data'],
++                                           config,
++                                           Bolt::Util.symbolize_top_level_keys(inventory['target_hash']))
++
++      bolt_inventory.collect_groups
++      bolt_inventory
++    end
++
+     def compile_catalog(request)
+       pal_main = request['code_ast'] || request['code_string']
+       target = request['target']",This whole function feels messy. I don't have a better idea at the moment though.,This needs to be in a `transaction do` block to ensure that the transaction will always be committed
+3529,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long,"I don't think this is the right place to do this, since this is used in the `getJsonParameters` meth"
+3530,"@@ -0,0 +1,18 @@
++package mock
++
++import (
++	""context""
++
++	""github.com/influxdata/flux/dependencies/influxdb""
++)
++
++type MockProvider struct {
++	influxdb.UnimplementedProvider
++	WriterForFn func(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error)
++}
++
++var _ influxdb.Provider = &MockProvider{}
++
++func (m MockProvider) WriterFor(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error) {
++	return m.WriterForFn(ctx, conf)
++}",Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?,Why the underscore?
+3531,"@@ -187,10 +187,10 @@ function innerDiffNode(dom, vchildren, context, mountAll, absorb) {
+ 		min = 0,
+ 		len = originalChildren.length,
+ 		childrenLen = 0,
+-		vlen = vchildren && vchildren.length,
++		vlen = vchildren ? vchildren.length : 0,
+ 		j, c, vchild, child;
+
+-	if (len) {
++	if (len!==0) {
+ 		for (let i=0; i<len; i++) {
+ 			let child = originalChildren[i],
+ 				props = child[ATTR_KEY],","This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract.",`!== 0` is a lot faster than `!== 0`.
+3532,"@@ -41,6 +41,7 @@ public class NutritionProductFragment extends BaseFragment implements CustomTabA
+     @BindView(R.id.listNutrientLevels) ListView lv;
+     @BindView(R.id.textServingSize) TextView serving;
+     @BindView(R.id.textCarbonFootprint) TextView carbonFootprint;
++    @BindView(R.id.txtNoDataString)TextView noTextString;
+     private CustomTabActivityHelper customTabActivityHelper;
+     private Uri nutritionScoreUri;
+ ",missing space before `TextView`,I don't think you need to bind this variable here
+3533,"@@ -616,6 +616,16 @@ Attr_ReadValue Item::readAttr(AttrTypes_t attr, PropStream& propStream)
+ 			break;
+ 		}
+
++		case ATTR_OPENCONTAINER: {
++			int32_t openContainer;
++			if (!propStream.read<int32_t>(openContainer)) {
++				return ATTR_READ_ERROR;
++			}
++
++			setIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER, openContainer);
++			break;
++		}
++
+ 		//these should be handled through derived classes
+ 		//If these are called then something has changed in the items.xml since the map was saved
+ 		//just read the values","so this attribute is used as u8 in code, but saves as int32? Why?",You should be able to use the `getIntAttr` functi
+3534,"@@ -41,7 +41,7 @@ from nupic.encoders.random_distributed_scalar import RandomDistributedScalarEnco
+ # Map class to Cap'n Proto schema union attribute
+ _CLASS_ATTR_MAP = {
+   ScalarEncoder: ""scalarEncoder"",
+-  AdaptiveScalarEncoder: ""adaptivescalar"",
++  AdaptiveScalarEncoder: ""adaptiveScalarEncoder"",
+   DateEncoder: ""dateEncoder"",
+   LogEncoder: ""logEncoder"",
+   CategoryEncoder: ""categoryEncoder"",",can RDSE be added to the list? It has its capnp files.,Can we rename this to `ScalarEncoder`?
+3535,"@@ -35,11 +35,11 @@ import (
+
+ // certificateToInjectableFunc converts a given certificate to the reconcile requests for the corresponding injectables
+ // (webhooks, api services, etc) that reference it.
+-type certificateToInjectableFunc func(log logr.Logger, cl client.Client, certName types.NamespacedName) []ctrl.Request
++type certificateToInjectableFunc func(log logr.Logger, cl client.Reader, certName types.NamespacedName) []ctrl.Request
+
+ // buildCertToInjectableFunc creates a certificateToInjectableFunc that maps from certificates to the given type of injectable.
+ func buildCertToInjectableFunc(listTyp runtime.Object, resourceName string) certificateToInjectableFunc {
+-	return func(log logr.Logger, cl client.Client, certName types.NamespacedName) []ctrl.Request {
++	return func(log logr.Logger, cl client.Reader, certName types.NamespacedName) []ctrl.Request {
+ 		log = log.WithValues(""type"", resourceName)
+ 		objs := listTyp.DeepCopyObject()
+ 		if err := cl.List(context.Background(), objs, client.MatchingFields{injectFromPath: certName.String()}); err != nil {","These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client.",This change seems unrelated to the rest of the PR
+3536,"@@ -1495,6 +1495,7 @@ mangle_direct_call(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+     if (target == (app_pc)retaddr) {
+         LOG(THREAD, LOG_INTERP, 3, ""found call to next instruction "" PFX ""\n"", target);
+     } else {
++        /* XXX i#3307: necessary to instr_set_translation_mangling_epilogue? */
+         check_return_handle_call(dcontext, ilist, next_instr);
+     }
+     /* now do the normal thing for a call */","No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push.","I don't understand why this change is necessary. Can you explain why it is necessary, please?"
+3537,"@@ -4,6 +4,7 @@
+
+ import flatbuffers
+ from flatbuffers.compat import import_numpy
++from tests.namespace_test.NamespaceC.TableInC import TableInC, TableInCT
+ np = import_numpy()
+
+ class SecondTableInA(object):",this is generated code.. these changes will need to be made in the code generator to have them stick.,Is TableInC still needed?
+3538,"@@ -1,8 +1,9 @@
++/* global xit */
+ describe('hidden content', function () {
+ 	'use strict';
+
+-  var fixture = document.getElementById('fixture');
+-
++	var fixture = document.getElementById('fixture');
++	var shadowSupport = document.body && typeof document.body.attachShadow === 'function';
+ 	var checkContext = {
+ 		_data: null,
+ 		data: function (d) {",Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?,`xit` should go at the end of the `describe` block
+3539,"@@ -9,6 +9,7 @@ const ignoreNsNotFound = shared.ignoreNsNotFound;
+ const loadSpecTests = require('../spec').loadSpecTests;
+ const chai = require('chai');
+ const expect = chai.expect;
++const runUnifiedTest = require('./unified-spec-runner/runner').runUnifiedTest;
+
+ describe('APM', function() {
+   before(function() {",Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way.,why not import this as `spec/unified-spec-runner/runUnifiedTest` ?
+3540,"@@ -577,7 +577,7 @@ SchemaString.prototype.$conditionalHandlers =
+       $gte: handleSingle,
+       $lt: handleSingle,
+       $lte: handleSingle,
+-      $options: handleSingle,
++      $options: String,
+       $regex: handleSingle,
+       $not: handleSingle
+     });","Why is this change necessary? `handleSingle()` will cast it to a string, no?",is there a reason why we can't just have a `Options` object here?
+3541,"@@ -228,4 +228,13 @@ public interface Table {
+    * @return a {@link LocationProvider} to provide locations for new data files
+    */
+   LocationProvider locationProvider();
++
++  /**
++   * Return the name of this table.
++   *
++   * @return this table's name
++   */
++  default String name() {
++    return ""table("" + hashCode() + "")"";
++  }
+ }","This newly added method should be well defined, should it return `TableIdentifier` or just `String`?",What's the purpose of this method?
+3542,"@@ -18,7 +18,8 @@ use Ergonode\Core\Infrastructure\Model\RelationshipGroup;
+
+ class ProductMultimediaRelationshipStrategy implements RelationshipStrategyInterface
+ {
+-    private const MESSAGE = 'Object has active relationships with multimedia %relations%';
++    private const ONE_MESSAGE = 'Multimedia has a relation with product';
++    private const MULTIPLE_MESSAGE = 'Multimedia has %count% relations with some products';
+
+     private ProductQueryInterface $productQuery;
+ ",have a relation with a product,"Shouldn't this message be ""Multimedia has %count% relations with "
+3543,"@@ -129,8 +129,11 @@ var _ = Describe(""health tests"", func() {
+
+ 		AfterEach(func() {
+ 			for _, name := range podsToCleanUp {
+-				err := k8sInfra.K8sClient.CoreV1().Pods(""default"").Delete(name, &metav1.DeleteOptions{})
+-				Expect(err).NotTo(HaveOccurred())
++				// It is possible for a local pod to be deleted by GC if node is gone.
++				if k8sInfra.PodExist(""default"", name) {
++					err := k8sInfra.K8sClient.CoreV1().Pods(""default"").Delete(name, &metav1.DeleteOptions{})
++					Expect(err).NotTo(HaveOccurred())
++				}
+ 			}
+ 			podsToCleanUp = nil
+ 		})","I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says ""pod has already been deleted""?","If the node is gone, should we just force the pod to be deleted?"
+3544,"@@ -65,13 +65,8 @@ class DbTaskHistory(task_history.TaskHistory):
+             yield session
+         else:
+             session = self.session_factory()
+-            try:
++            with session.transaction:
+                 yield session
+-            except:
+-                session.rollback()
+-                raise
+-            else:
+-                session.commit()
+
+     def __init__(self):
+         config = configuration.get_config()",SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer.,why is this removed?
+3545,"@@ -88,11 +88,11 @@ func (q *actQueue) Overlaps(act *iproto.ActionPb) bool {
+ 	switch {
+ 	case act.GetTransfer() != nil:
+ 		tsf := &action.Transfer{}
+-		tsf.ConvertFromTransferPb(act.GetTransfer())
++		tsf.ConvertFromActionPb(act)
+ 		nonce = tsf.Nonce
+ 	case act.GetVote() != nil:
+ 		vote := &action.Vote{}
+-		vote.ConvertFromVotePb(act.GetVote())
++		vote.ConvertFromActionPb(act)
+ 		nonce = vote.Nonce
+ 	}
+ 	return q.items[nonce] != nil",This switch statement can be removed. Just return q.items[act.Nonce] != nil,Why change this? Is
+3546,"@@ -119,7 +119,7 @@ public class AvoidInstantiatingObjectsInLoopsRule extends AbstractJavaRule {
+                  */
+                 n = n.getParent();
+             } else if (n.getParent() instanceof ASTForStatement && n.getParent().getNumChildren() > 1
+-                    && n == n.getParent().getChild(1)) {
++                    && n.equals(n.getParent().getChild(1))) {
+                 // it is the second child of a ForStatement - which means
+                 // we are dealing with a for-each construct
+                 // In that case, we can ignore this allocation expression, as","I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations...",I am confused by thi
+3547,"@@ -29,6 +29,9 @@ namespace ResultsComparer
+         [Option(""csv"", HelpText = ""Path to exported CSV results. Optional."")]
+         public FileInfo CsvPath { get; set; }
+
++        [Option('f', ""filter"", HelpText = ""Filter the benchmarks by name using glob pattern(s). Optional."")]
++        public IEnumerable<string> Filters { get; set; }
++
+         [Usage(ApplicationAlias = """")]
+         public static IEnumerable<Example> Examples
+         {",What's the scenario for passing multiple filters?,nit: Maybe `Filter t
+3548,"@@ -201,9 +201,10 @@ bool Part::commitLogs(std::unique_ptr<LogIterator> iter) {
+     LogID lastId = -1;
+     TermID lastTerm = -1;
+     while (iter->valid()) {
+-        lastId = iter->logId();
+-        lastTerm = iter->logTerm();
+-        auto log = iter->logMsg();
++        auto logEntry = iter->logEntry();
++        lastId = std::get<0>(logEntry);
++        lastTerm = std::get<1>(logEntry);
++        auto log = std::get<3>(logEntry);
+         if (log.empty()) {
+             VLOG(3) << idStr_ << ""Skip the heartbeat!"";
+             ++(*iter);",move to after check log.empty(),What's the purpose of this change?
+3549,"@@ -19,6 +19,7 @@
+ # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+
+ """""" Comments and reviews for records: web interface """"""
++from docutils.nodes import note
+
+ __lastupdated__ = """"""$Date$""""""
+ ",This line needs to be removed,Why is this needed?
+3550,"@@ -68,7 +68,7 @@ type CloudBuildSourceSpec struct {
+
+ const (
+ 	// CloudBuildSource CloudEvent type
+-	CloudBuildSourceEvent = ""com.google.cloud.build.event""
++	CloudBuildSourceEvent = ""google.cloud.cloudbuild.build.v1.statusChanged""
+ 	// CloudBuildSourceBuildId is the Pub/Sub message attribute key with the CloudBuildSource's buildId.
+ 	CloudBuildSourceBuildId = ""buildId""
+ 	// CloudBuildSourceBuildStatus is the Pub/Sub message attribute key with the CloudBuildSource's build status.",Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?,@liggitt is this change ok for you
+3551,"@@ -0,0 +1,8 @@
++// Package vsphere contains vSphere-specific structures for installer
++// configuration and management.
++// +k8s:deepcopy-gen=package,register
++// +k8s:conversion-gen=github.com/openshift/hive/pkg/apis/hive
++package vsphere
++
++// Name is name for the vsphere platform.
++const Name string = ""vsphere""",This is unused.,missing new line at the end of the
+3552,"@@ -32,9 +32,13 @@ namespace OpenTelemetry.Instrumentation.Http
+         public bool SetHttpFlavor { get; set; }
+
+         /// <summary>
+-        /// Gets or sets <see cref=""ITextFormat""/> for context propagation. Default value: <see cref=""TraceContextFormat""/>.
++        /// Gets or sets <see cref=""ITextFormat""/> for context propagation. Default value: <see cref=""CompositePropagator""/>.
+         /// </summary>
+-        public ITextFormat TextFormat { get; set; } = new TraceContextFormat();
++        public ITextFormat TextFormat { get; set; } = new CompositePropagator(new System.Collections.Generic.List<ITextFormat>
++        {
++            new TraceContextFormat(),
++            new BaggageFormat(),
++        });
+
+         /// <summary>
+         /// Gets or sets an optional callback method for filtering <see cref=""HttpWebRequest""/> requests that are sent through the instrumentation.",Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?,Should we add the composite propagator here too?
+3553,"@@ -0,0 +1,8 @@
++class TwitterPlayerCardsController < ApplicationController
++  layout false
++
++  def show
++    response.headers.delete(""X-Frame-Options"")
++    @video = Video.find(params[:video_id])
++  end
++end",Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?,I would prefer to use `find_by(id: params[:video
+3554,"@@ -138,6 +138,9 @@ func (u *staticUpstream) NewHost(host string) (*UpstreamHost, error) {
+ 				if uh.Unhealthy {
+ 					return true
+ 				}
++				if uh.Dynamic {
++					return false
++				}
+ 				if uh.Fails >= u.MaxFails &&
+ 					u.MaxFails != 0 {
+ 					return true",Backends with hostnames that depend on the request are always up?,this should be `&& uh.Dynamic` instead of `&& !u
+3555,"@@ -4,6 +4,8 @@ import functools
+ import colander
+ import venusian
+ import six
++from jsonpatch import JsonPatchException
++from jsonpointer import JsonPointerException
+ from pyramid import exceptions as pyramid_exceptions
+ from pyramid.decorator import reify
+ from pyramid.security import Everyone","I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation",This should be `from jsonpointer import JsonPatc
+3556,"@@ -11,10 +11,6 @@ module Travis
+   module Build
+     class Script
+       class Julia < Script
+-        DEFAULTS = {
+-          julia: 'release',
+-        }
+-
+         def export
+           super
+ ","make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?","I'm not sure why we are deleting this file, it doesn't seem to be used anywhere."
+3557,"@@ -20,7 +20,10 @@
+ //
+ // For secrets.OpenKeeper, azurekeyvault registers for the scheme ""azurekeyvault"".
+ // The default URL opener will use Dial, which gets default credentials from the
+-// environment.
++// environment, unless the AZURE_KEYVAULT_AUTH_VIA_CLI environment variable is
++// set to true, in which case it uses DialUsingCLIAuth to get credentials from the
++// ""az"" command line.
++//
+ // To customize the URL opener, or for more details on the URL format,
+ // see URLOpener.
+ // See https://gocloud.dev/concepts/urls/ for background information.","nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`.","""unless the AZURE_KEYVAULT_AUTH_VIA_CLI environment variable is set to true"""
+3558,"@@ -34,10 +34,10 @@ type Validator struct {
+ }
+
+ // NewValidator return Validator instance
+-func NewValidator(sessionManager session.Manager, extractor identity.Extractor) *Validator {
++func NewValidator(sessionStorage *session.Storage, extractor identity.Extractor) *Validator {
+ 	return &Validator{
+ 		clientMap: &clientMap{
+-			sessionManager:   sessionManager,
++			sessions:         sessionStorage,
+ 			sessionClientIDs: make(map[session.SessionID]int),
+ 			sessionMapLock:   sync.Mutex{},
+ 		},",Depend on interfaces not on structures,Why do we need to pass session.Storage instead of just sessionManager?
+3559,"@@ -180,7 +180,7 @@ void signalHandler(int sig) {
+     case SIGTERM:
+       FLOG_INFO(""Signal %d(%s) received, stopping this server"", sig, ::strsignal(sig));
+       if (gStorageServer) {
+-        gStorageServer->stop();
++        gStorageServer->notifyStop();
+       }
+       break;
+     default:","This fix looks good. My concern, don't forget to fix metad too!",Please add a `break;` statement before the `break` in case there's a non-breakin
+3560,"@@ -196,13 +196,15 @@ func makeMDJournalWithIDJournal(
+ 	}
+
+ 	if earliest != nil {
+-		if earliest.BID() != latest.BID() {
++		if earliest.BID() != latest.BID() &&
++			!(earliest.BID() == NullBranchID &&
++				latest.BID() == LocalSquashBranchID) {
+ 			return nil, fmt.Errorf(
+ 				""earliest.BID=%s != latest.BID=%s"",
+ 				earliest.BID(), latest.BID())
+ 		}
+-		log.CDebugf(nil, ""Initializing with branch ID %s"", earliest.BID())
+-		journal.branchID = earliest.BID()
++		log.CDebugf(nil, ""Initializing with branch ID %s"", latest.BID())
++		journal.branchID = latest.BID()
+ 	}
+
+ 	return &journal, nil","Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?",Why is this change needed?
+3561,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?,Do we also want to set `Co
+3562,"@@ -50,6 +50,11 @@ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {
+
++// port use if the ros environment variable doesn't specified one
++const uint16_t DEFAULT_ROS2_SERVER_PORT = 11811;
++// default server guidPrefix
++const char* DEFAULT_ROS2_SERVER_GUIDPREFIX = ""44.49.53.43.53.45.52.56.45.52.5F.30"";
++
+ GUID_t RemoteServerAttributes::GetParticipant() const
+ {
+     return GUID_t(guidPrefix, c_EntityId_RTPSParticipant);",Again use of `constexpr` is recomended.,Is this really the default
+3563,"@@ -8,6 +8,12 @@ from ..core.operation import Operation
+ from .chart import Points
+ from .path import Path
+
++try:
++    from datashader.layout import LayoutAlgorithm as ds_layout
++except:
++    ds_layout = None
++
++
+ class graph_redim(redim):
+     """"""
+     Extension for the redim utility that allows re-dimensioning",Minor point but I would call this ``redim_graph`` instead.,How about `from .layout im
+3564,"@@ -26,12 +26,14 @@ import (
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/schema""
+-	""k8s.io/klog""
++	""k8s.io/utils/pointer""
+ 	infrav1 ""sigs.k8s.io/cluster-api-provider-aws/pkg/apis/infrastructure/v1alpha2""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/scope""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/ec2""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/elb""
++	""sigs.k8s.io/cluster-api/pkg/apis/cluster/common""
+ 	clusterv1 ""sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha2""
++	""sigs.k8s.io/cluster-api/pkg/controller/noderefutil""
+ 	capierrors ""sigs.k8s.io/cluster-api/pkg/errors""
+ 	""sigs.k8s.io/cluster-api/pkg/util""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""","As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above","cluster-api/pkg/apis/cluster, should be renamed to cluster-api/pkg/apis/cluster"
+3565,"@@ -40,15 +40,11 @@ func (service *servicePFCtl) Add(rule RuleForwarding) {
+ func (service *servicePFCtl) Start() error {
+ 	err := service.ipForward.Enable()
+ 	if err != nil {
+-		return err
++		log.Warn(natLogPrefix, ""Failed to enable IP forwarding: "", err)
+ 	}
+
+ 	service.clearStaleRules()
+-	err = service.enableRules()
+-	if err != nil {
+-		return err
+-	}
+-	return nil
++	return service.enableRules()
+ }
+
+ func (service *servicePFCtl) Stop() {","Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`",Wouldn't be better to keep this as a warning?
+3566,"@@ -256,6 +256,9 @@ OpenStreetMap::Application.routes.draw do
+   # directions
+   get ""/directions"" => ""directions#search""
+
++  # set home location
++  match ""/set_home_loc"" => ""user#set_home_location"", :via => [:get, :post]
++
+   # export
+   post ""/export/finish"" => ""export#finish""
+   get ""/export/embed"" => ""export#embed""","Whatever the decision is about the request type to use, this should only match what is needed and not the other one.",Use the new Ruby 1.9 hash syntax.
+3567,"@@ -1025,7 +1025,9 @@ Blockly.BlockSvg.prototype.handleDragFree_ = function(oldXY, newXY, e) {
+   }
+
+   var updatePreviews = true;
+-  if (Blockly.localConnection_ && Blockly.highlightedConnection_) {
++  if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {
++    updatePreviews = true; // Always update previews for output connections.
++  } else if (Blockly.localConnection_ && Blockly.highlightedConnection_) {
+     var xDiff = Blockly.localConnection_.x_ + dxy.x -
+         Blockly.highlightedConnection_.x_;
+     var yDiff = Blockly.localConnection_.y_ + dxy.y -","...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too.",Nit: `else if (Blockly.localConnection_ && Blockly.highlightedConnection_)` is
+3568,"@@ -70,8 +70,7 @@ class BigqueryRulesEngine(bre.BaseRulesEngine):
+         self.rule_book = BigqueryRuleBook(self._load_rule_definitions())
+
+     # TODO: The naming is confusing and needs to be fixed in all scanners.
+-    def find_policy_violations(self, parent_project, bq_acl,
+-                               force_rebuild=False):
++    def find_violations(self, parent_project, bq_acl, force_rebuild=False):
+         """"""Determine whether Big Query datasets violate rules.
+
+         Args:","Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?","This TODO can be removed now, because the name is confusing."
+3569,"@@ -1667,6 +1667,13 @@ void ErrorTest() {
+   TestError(""enum X:byte { Y, Y }"", ""value already"");
+   TestError(""enum X:byte { Y=2, Z=2 }"", ""unique"");
+   TestError(""table X { Y:int; } table X {"", ""datatype already"");
++  TestError(""table X { A:bool; } table Y { } union X {"",
++            ""enum clashes with datatype"");
++  TestError(""union X { X, Y } table X {"", ""datatype clashes with enum"");
++  TestError(""namespace A; table X { } namespace A; union X {"",
++            ""enum clashes with datatype"");
++  TestError(""namespace A; union X { } namespace A; table X {"",
++            ""datatype clashes with enum"");
+   TestError(""struct X (force_align: 7) { Y:int; }"", ""force_align"");
+   TestError(""struct X {}"", ""size 0"");
+   TestError(""{}"", ""no root"");",This seems like an incomplete schema definition. will that have any effect on the tests?,Wouldn't it be better to have a separate test file for each
+3570,"@@ -22,7 +22,10 @@ DatasetLoader::DatasetLoader(const Config& io_config, const PredictFunction& pre
+   label_idx_ = 0;
+   weight_idx_ = NO_SPECIFIC;
+   group_idx_ = NO_SPECIFIC;
+-  SetHeader(filename);
++  if (filename != nullptr && CheckCanLoadFromBin(filename) == """") {
++    // SetHeader should only be called when loading from text file
++    SetHeader(filename);
++  }
+   store_raw_ = false;
+   if (io_config.linear_tree) {
+     store_raw_ = true;","The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == """"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == """") { ... }`",Does this need to check if `filename != nullptr`?
+3571,"@@ -148,8 +148,7 @@ func (m *BackgroundProcessManager) StartProcess(cmd *ManagedProcess) (*process.P
+ 	go func() {
+ 		err := cmd.Wait()
+ 		if err != nil {
+-			err, ok := err.(*exec.ExitError)
+-			if ok {
++			if err, ok := err.(*exec.ExitError); ok {
+ 				status := err.Sys().(syscall.WaitStatus)
+ 				if status.Signaled() && status.Signal() == syscall.SIGTERM {
+ 					log.Info(""process stopped with SIGTERM signal"")","I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch","I don't like this change, it makes the diff harder to read."
+3572,"@@ -145,6 +145,18 @@ folly::Future<StatusOr<std::vector<SpaceIdName>>> MetaClient::listSpaces() {
+                 });
+ }
+
++
++folly::Future<StatusOr<bool>> MetaClient::dropSpace(std::string name) {
++    cpp2::DropSpaceReq req;
++    req.set_space_name(std::move(name));
++    return getResponse(std::move(req), [] (auto client, auto request) {
++                    return client->future_dropSpace(request);
++                }, [] (cpp2::ExecResp&& resp) -> bool {
++                    return resp.code == cpp2::ErrorCode::SUCCEEDED;
++                });
++}
++
++
+ folly::Future<StatusOr<bool>> MetaClient::addHosts(const std::vector<HostAddr>& hosts) {
+     std::vector<nebula::cpp2::HostAddr> thriftHosts;
+     thriftHosts.resize(hosts.size());",`Status` has identical semantics with `StatusOr<bool>`.,Shouldn't this be `getResponse(cpp2::ExecResp&)`?
+3573,"@@ -75,6 +75,7 @@ var allowedPaths = []string{
+ 	""/readyz"",
+ 	""/mutate/acnp"",
+ 	""/mutate/anp"",
++	""/mutate/addlabels"",
+ 	""/validate/tier"",
+ 	""/validate/acnp"",
+ 	""/validate/anp"",",why is this named in a different style from other paths?,can you add the `/validate/anp` path as well?
+3574,"@@ -73,13 +73,13 @@ func (r *AWSClusterReconciler) Reconcile(req ctrl.Request) (_ ctrl.Result, reter
+ 		return reconcile.Result{}, err
+ 	}
+
+-	if isPaused(cluster, awsCluster) {
+-		log.Info(""AWSCluster or linked Cluster is marked as paused. Won't reconcile"")
++	if cluster == nil {
++		log.Info(""Cluster Controller has not yet set OwnerRef"")
+ 		return reconcile.Result{}, nil
+ 	}
+
+-	if cluster == nil {
+-		log.Info(""Cluster Controller has not yet set OwnerRef"")
++	if util.IsPaused(cluster, awsCluster) {
++		log.Info(""AWSCluster or linked Cluster is marked as paused. Won't reconcile"")
+ 		return reconcile.Result{}, nil
+ 	}
+ ",Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused,I changed this because `cluster` is only used in
+3575,"@@ -25,13 +25,18 @@ import (
+ 	api ""google.golang.org/api/compute/v1""
+ )
+
++type platformPkgManagerTuple struct {
++	platform   string
++	pkgManager string
++}
++
+ const (
+ 	packageInstalledString    = ""package is installed""
+ 	packageNotInstalledString = ""package is not installed""
+ )
+
+ var (
+-	pkgManagers = []string{""apt"", ""yum""}
++	tuples = []platformPkgManagerTuple{{""debian"", ""apt""}, {""centos"", ""yum""}, {""rhel"", ""yum""}}
+ )
+
+ // vf is the the vertificationFunction that is used in each testSetup during assertion of test case.","I don't see pkgManager used anywhere, is there a reason we need this?",I wonder if it wouldn't be better to have a `make
+3576,"@@ -182,7 +182,7 @@ public class CoreDescriptor {
+    */
+   public CoreDescriptor(String name, Path instanceDir, Map<String, String> coreProps,
+                         Properties containerProperties, ZkController zkController) {
+-    this.instanceDir = instanceDir;
++    this.instanceDir = instanceDir.toAbsolutePath();
+
+     originalCoreProperties.setProperty(CORE_NAME, name);
+ ","A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory.",Should it be `PathUtils.toPath(instanceDir)`?
+3577,"@@ -4188,7 +4188,8 @@ function getModelsMapForPopulate(model, docs, options) {
+       foreignField = foreignField.call(doc);
+     }
+
+-    const localFieldPath = modelSchema.paths[localField];
++    const localFieldPathType = modelSchema._getPathType(localField);
++    const localFieldPath = localFieldPathType === 'real' ? modelSchema.paths[localField] : localFieldPathType.schema;
+     const localFieldGetters = localFieldPath ? localFieldPath.getters : [];
+     let ret;
+ ",There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array.,I don't think this is the right way to fix th
+3578,"@@ -56,7 +56,13 @@ class User < ActiveRecord::Base
+
+   scope :search, -> (term) {
+     search_pattern = ""%#{term}%""
+-    where(""firstname LIKE ? OR surname LIKE ? OR email LIKE ?"", search_pattern, search_pattern, search_pattern)
++    # MySQL does not support standard string concatenation and since concat_ws or concat functions do
++    # not exist for sqlite, we have to come up with this conditional
++    if ActiveRecord::Base.connection.adapter_name == ""Mysql2""
++      where(""concat_ws(' ', firstname, surname) LIKE ? OR email LIKE ?"", search_pattern, search_pattern)
++    else
++      where(""firstname || ' ' || surname LIKE ? OR email LIKE ?"", search_pattern, search_pattern)
++    end
+   }
+
+   # EVALUATE CLASS AND INSTANCE METHODS BELOW",Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though,Line is too long. [84/80]
+3579,"@@ -5,11 +5,12 @@
+ package ens
+
+ import (
++	""bytes""
+ 	""errors""
+ 	""fmt""
+ 	""strings""
+
+-	""github.com/ethereum/go-ethereum/accounts/abi/bind""
++	""github.com/ethereum/go-ethereum/common""
+ 	""github.com/ethereum/go-ethereum/ethclient""
+ 	goens ""github.com/wealdtech/go-ens/v3""
+ ","NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address.",does this belong in this PR?
+3580,"@@ -26,6 +26,7 @@ Upcase::Application.routes.draw do
+   draw :teams
+   draw :trails
+   draw :users
++  draw :vanity
+   draw :videos
+
+   root to: ""homes#show""",I'm curious why you are using `draw` in this route file?,shouldn't this be `:vanity` ?
+3581,"@@ -195,7 +195,18 @@ func Diff(ctx *context.Context) {
+ }
+
+ func RawDiff(ctx *context.Context) {
+-	panic(""not implemented"")
++	userName := ctx.Repo.Owner.Name
++	repoName := ctx.Repo.Repository.Name
++	commitID := ctx.Params("":sha"")
++	diffType := ctx.Params("":ext"")
++
++	diff, err := models.GetRawDiff(models.RepoPath(userName, repoName),
++		commitID, diffType)
++	if err != nil {
++		ctx.Handle(404, ""GetRawDiff"", err)
++		return
++	}
++	ctx.HandleText(200, diff)
+ }
+
+ func CompareDiff(ctx *context.Context) {","Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly.",You should use ctx.Repo.Owner
+3582,"@@ -3,7 +3,7 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
+-#if NET461 || NET452
++#if NET461
+
+ using System;
+ using System.Linq;",I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point  ,Why remove the `|| NET452`?
+3583,"@@ -21,6 +21,8 @@ import (
+ // Compatible with Okta offline access, a holdover from previous defaults.
+ var defaultScopes = []string{oidc.ScopeOpenID, oidc.ScopeOfflineAccess, ""email""}
+
++const clutchProviderName = ""clutch""
++
+ type OIDCProvider struct {
+ 	provider *oidc.Provider
+ 	verifier *oidc.IDTokenVerifier","to fix the docs build failure, make this const var named without the suffix `Name`",Does it need to be exported f
+3584,"@@ -682,6 +682,7 @@ func checkClientTLSCertSubject(c *client, fn tlsMapAuthFn) bool {
+ 				return true
+ 			}
+ 		}
++		fallthrough
+ 	case hasURIs:
+ 		for _, u := range cert.URIs {
+ 			if match, ok := fn(u.String(), nil); ok {","This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted.",Why was this switch needed?
+3585,"@@ -0,0 +1,15 @@
++package com.fsck.k9.service;
++
++
++import java.io.File;
++import java.io.IOException;
++
++import android.net.Uri;
++
++
++public interface FileProviderInterface {
++
++    File createProvidedFile() throws IOException;
++    Uri getUriForProvidedFile(File file, String mimeType) throws IOException;
++
++}",Same here. Feels like the wrong location.,I would suggest a more desc
+3586,"@@ -42,7 +42,9 @@ from qutebrowser.keyinput import modeman
+ from qutebrowser.utils import (message, usertypes, log, qtutils, urlutils,
+                                objreg, utils)
+ from qutebrowser.utils.usertypes import KeyMode
+-from qutebrowser.misc import editor, guiprocess
++from qutebrowser.misc import editor, guiprocess, mhtml
++from qutebrowser.browser.downloads import (_path_suggestion as
++                                           download_path_suggestion)
+
+
+ class CommandDispatcher:",Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`.,I think we should move `mht
+3587,"@@ -40,6 +40,8 @@ func init() {
+ 	flag.StringVar(&revoke, ""revoke"", """", ""Hostname for which to revoke the certificate"")
+ 	flag.StringVar(&serverType, ""type"", ""http"", ""Type of server to run"")
+ 	flag.BoolVar(&version, ""version"", false, ""Show version"")
++	flag.StringVar(&caddytls.HTTPChallengePort, ""external-port-80-is-local-port"", ""80"", ""Local port exposed externally as port 80"")
++	flag.StringVar(&caddytls.TLSSNIChallengePort, ""external-port-443-is-local-port"", ""443"", ""Local port exposed externally as port 443"")
+
+ 	caddy.RegisterCaddyfileLoader(""flag"", caddy.LoaderFunc(confLoader))
+ 	caddy.SetDefaultCaddyfileLoader(""default"", caddy.LoaderFunc(defaultLoader))","Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)",I think the changes in this
+3588,"@@ -19,6 +19,14 @@ module Blacklight
+         end
+       end
+     end
++
++    initializer ""blacklight.secret_key"" do |app|
++      if app.respond_to?(:secrets)
++        Blacklight.secret_key ||= app.secrets.secret_key_base
++      elsif app.config.respond_to?(:secret_key_base)
++        Blacklight.secret_key ||= app.config.secret_key_base
++      end
++    end
+
+   end
+-end
++end","Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?",I wonder if this should be more like `app.secrets.secret_key` or `app.config.secret_key_base`?
+3589,"@@ -390,6 +390,9 @@ public:
+     m_nopayload_elems_bitmask =
+         enum_impl_strategy.getBitMaskForNoPayloadElements();
+
++    if (enum_decl->isObjC())
++      m_is_objc_enum = true;
++
+     LOG_PRINTF(LIBLLDB_LOG_TYPES, ""m_nopayload_elems_bitmask = %s"",
+                Dump(m_nopayload_elems_bitmask).c_str());
+ ",Does this not apply to C enums on Linux?,Are you sure you want m_is_objc_enum to be set to true here? Is it possible to have enum_decl-
+3590,"@@ -511,7 +511,11 @@ function makeOperationHandler(server, connection, cmd, options, callback) {
+           session.serverSession.isDirty = true;
+         }
+
+-        if (supportsRetryableWrites(server) && !inActiveTransaction(session, cmd)) {
++        if (
++          isRetryableWriteError(err) &&
++          supportsRetryableWrites(server) &&
++          !inActiveTransaction(session, cmd)
++        ) {
+           err.addErrorLabel('RetryableWriteError');
+         }
+ ",Should this check if the error is `RetryableWriteError` before adding the label?,Is this label useful? It doesn't seem like we're labeling the error here.
+3591,"@@ -1,6 +1,8 @@
+ const Plugin = require('../core/Plugin')
+ const { findDOMElement } = require('../core/Utils')
+-const getFormData = require('get-form-data').default
++// Rollup uses get-form-data's ES modules build, and rollup-plugin-commonjs automatically resolves `.default`.
++// So, if we are being built using rollup, this require() won't have a `.default` property.
++const getFormData = require('get-form-data').default || require('get-form-data')
+
+ /**
+  * Form","Oh wow, that's one complicated require :)",There's no `default` property in this file.
+3592,"@@ -1,6 +1,6 @@
+ // snippet-comment:[These are tags for the AWS doc team's sample catalog. Do not remove.]
+ // snippet-sourceauthor:[Doug-AWS]
+-// snippet-sourcedescription:[Using context.Context with SDK requests.]
++// snippet-sourcedescription:[request_context.go shows how to usie context.Context with SDK requests.]
+ // snippet-keyword:[Extending the SDK]
+ // snippet-keyword:[Go]
+ // snippet-service:[aws-go-sdk]","do you mean how to ""use""","I assume this is ""usie"", not ""request_context.go""?"
+3593,"@@ -400,8 +400,9 @@ describe('forwardRef', () => {
+ 		const Transition = ({ children }) => {
+ 			const state = useState(0);
+ 			forceTransition = state[1];
+-			expect(children.ref).to.not.be.undefined;
+-			if (state[0] === 0) expect(children.props.ref).to.be.undefined;
++			// TODO: ref exists on the backing node
++			// expect(children.ref).to.not.be.undefined;
++			// if (state[0] === 0) expect(children.props.ref).to.be.undefined;
+ 			return children;
+ 		};
+ ",We can't really test this anymore since ref and props.ref are at the backing node level now,This seems like something that should be done in a
+3594,"@@ -56,6 +56,7 @@ abstract class BaseDataReader<T> implements Closeable {
+
+   private CloseableIterator<T> currentIterator;
+   private T current = null;
++  private FileScanTask currentTask = null;
+
+   BaseDataReader(CombinedScanTask task, FileIO io, EncryptionManager encryptionManager) {
+     this.tasks = task.files().iterator();",Did you intend to set this in the constructor?,Do you really need `currentTask`? It is already as
+3595,"@@ -106,11 +106,15 @@ func (s *Service) createInstance(machine *actuators.MachineScope, bootstrapToken
+ 		Role:        aws.String(machine.Role()),
+ 	})
+
++	var err error
+ 	// Pick image from the machine configuration, or use a default one.
+ 	if machine.MachineConfig.AMI.ID != nil {
+ 		input.ImageID = *machine.MachineConfig.AMI.ID
+ 	} else {
+-		input.ImageID = s.defaultAMILookup(machine.Region())
++		input.ImageID, err = s.defaultAMILookup(""ubuntu"", ""18.04"", machine.Machine.Spec.Versions.Kubelet)
++		if err != nil {
++			return nil, err
++		}
+ 	}
+
+ 	// Pick subnet from the machine configuration, or default to the first private available.","This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?",Instead of hard-coding `18.04` could we use `image
+3596,"@@ -1,5 +1,6 @@
++#ifdef USE_OPENCV
+ #include <opencv2/core/core.hpp>
+-
++#endif  // USE_OPENCV
+ #include <stdint.h>
+
+ #include <string>",This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure.,Why did you change the include order?
+3597,"@@ -30,7 +30,7 @@ func (r *ReconcileHiveConfig) deployHiveAPI(hLog log.FieldLogger, h *resource.He
+
+ 	err := util.ApplyAsset(h, ""config/apiserver/hiveapi-cluster-role-binding.yaml"", hLog)
+ 	if err != nil {
+-		return err
++		hLog.WithError(err).Error(""unable to apply hiveapi cluster role binding"")
+ 	}
+
+ 	err = util.ApplyAsset(h, ""config/apiserver/service.yaml"", hLog)",Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday.,will this be printed to the error log
+3598,"@@ -33,6 +33,7 @@ class Proposal < ActiveRecord::Base
+   has_many :steps
+   has_many :individual_steps, ->{ individual }, class_name: 'Steps::Individual'
+   has_many :approvers, through: :individual_steps, source: :user
++  has_many :completers, through: :individual_steps, source: :completer
+   has_many :api_tokens, through: :individual_steps
+   has_many :attachments, dependent: :destroy
+   has_many :approval_delegates, through: :approvers, source: :outgoing_delegations","I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days.",What do you think about renaming this
+3599,"@@ -11,7 +11,6 @@ namespace AutoRest.Swagger.Validation
+     public class OperationParametersValidation : TypedRule<SwaggerParameter>
+     {
+         private const string SubscriptionId = ""subscriptionid"";
+-        private const string ApiVersion = ""api-version"";
+
+         /// <summary>
+         /// Id of the Rule.",Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation.,Can you explain why you removed this?
+3600,"@@ -77,6 +77,8 @@ class Thelia extends Kernel
+         );
+         $serviceContainer = Propel::getServiceContainer();
+         $serviceContainer->setAdapterClass('thelia', 'mysql');
++        $serviceContainer->setDefaultDatasource('thelia');
++
+         $manager = new ConnectionManagerSingle();
+         $manager->setConfiguration($definePropel->getConfig());
+         $serviceContainer->setConnectionManager('thelia', $manager);","@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database.",Why was this added?
+3601,"@@ -92,7 +92,9 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+             var controllerContext = (IHttpControllerContext)state.State;
+
+             // some fields aren't set till after execution, so populate anything missing
+-            AspNetWebApi2Integration.UpdateSpan(controllerContext, scope.Span, (AspNetTags)scope.Span.Tags, Enumerable.Empty<KeyValuePair<string, string>>());
++            var span = scope.Span as IHasTags;
++            var aspNetTags = span.Tags as AspNetTags;
++            AspNetWebApi2Integration.UpdateSpan(controllerContext, scope.Span, aspNetTags, Enumerable.Empty<KeyValuePair<string, string>>());
+
+             if (exception != null)
+             {",Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility.,I'd like to see thi
+3602,"@@ -2,7 +2,8 @@ const request = require('request')
+ // @ts-ignore
+ const purest = require('purest')({ request })
+ const logger = require('../logger')
+-
++const DRIVE_FILE_FIELDS = 'kind,id,name,mimeType,ownedByMe,permissions(role,emailAddress),size,modifiedTime,iconLink,thumbnailLink'
++const DRIVE_FILES_FIELDS = `kind,nextPageToken,incompleteSearch,files(${DRIVE_FILE_FIELDS})`
+ /**
+  * @class
+  * @implements {Provider}",why do we need to explicitly declare these fields?,Is there a way to r
+3603,"@@ -99,12 +99,8 @@ class OaiController extends AbstractBase
+                 $this->getRequest()->getQuery()->toArray(),
+                 $this->getRequest()->getPost()->toArray()
+             );
+-            $server = new $serverClass(
+-                $this->serviceLocator->get('VuFind\Search\Results\PluginManager'),
+-                $this->serviceLocator->get('VuFind\Record\Loader'),
+-                $this->serviceLocator->get('VuFind\Db\Table\PluginManager'),
+-                $config, $baseURL, $params
+-            );
++            $server = $this->serviceLocator->get('VuFind\OAI\Server');
++            $server->init($config, $baseURL, $params);
+             $server->setRecordLinkHelper(
+                 $this->getViewRenderer()->plugin('recordLink')
+             );","Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\OAI\Server\Auth`. Should be easy enough since it can share the same factory.",Initially the `VuFi
+3604,"@@ -265,6 +265,12 @@ describe Beaker do
+   context ""validate_host"" do
+     subject { dummy_class.new }
+
++    before(:each) do
++      # Must reset additional_pkgs between each test as it hangs around
++      #Beaker::HostPrebuiltSteps.class_variable_set(:@@additional_pkgs, [])
++      Beaker::HostPrebuiltSteps.module_eval(%q{@@additional_pkgs = []})
++    end
++
+     it ""can validate unix hosts"" do
+
+       hosts.each do |host|",This is no longer needed and should be removed.,would it make sense to just put this in the `before(:each)` block?
+3605,"@@ -57,8 +57,12 @@ func ParseFlags(ctx *cli.Context) service.Options {
+ }
+
+ // ParseJSONOptions function fills in Openvpn options from JSON request
+-func ParseJSONOptions(request json.RawMessage) (service.Options, error) {
++func ParseJSONOptions(request *json.RawMessage) (service.Options, error) {
++	if request == nil {
++		return Options{}, nil
++	}
++
+ 	var opts Options
+-	err := json.Unmarshal(request, &opts)
++	err := json.Unmarshal(*request, &opts)
+ 	return opts, err
+ }","could use named return params here to avoid declaring the opts, and using naked returns instead.","same as above, consider returning an error if something doesn't wo"
+3606,"@@ -84,6 +84,11 @@ module.exports = class Instagram extends Plugin {
+   }
+
+   getItemIcon (item) {
++    if (!item.images) {
++      return <svg viewBox=""0 0 58 58"" opacity=""0.6"">
++        <path d=""M36.537 28.156l-11-7a1.005 1.005 0 0 0-1.02-.033C24.2 21.3 24 21.635 24 22v14a1 1 0 0 0 1.537.844l11-7a1.002 1.002 0 0 0 0-1.688zM26 34.18V23.82L34.137 29 26 34.18z"" /><path d=""M57 6H1a1 1 0 0 0-1 1v44a1 1 0 0 0 1 1h56a1 1 0 0 0 1-1V7a1 1 0 0 0-1-1zM10 28H2v-9h8v9zm-8 2h8v9H2v-9zm10 10V8h34v42H12V40zm44-12h-8v-9h8v9zm-8 2h8v9h-8v-9zm8-22v9h-8V8h8zM2 8h8v9H2V8zm0 42v-9h8v9H2zm54 0h-8v-9h8v9z"" />
++      </svg>
++    }
+     return <img src={item.images.thumbnail.url} />
+   }
+ ","this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case.",IMO we should create a const for the size of the image so we don't
+3607,"@@ -58,12 +58,14 @@ type syncChainSelector interface {
+ 	// IsHeaver returns true if tipset a is heavier than tipset b and false if
+ 	// tipset b is heavier than tipset a.
+ 	IsHeavier(ctx context.Context, a, b types.TipSet, aStateID, bStateID cid.Cid) (bool, error)
++	// NewWeight returns the weight of a tipset
++	NewWeight(ctx context.Context, ts types.TipSet, stRoot cid.Cid) (uint64, error)
+ }
+
+ type syncStateEvaluator interface {
+ 	// RunStateTransition returns the state root CID resulting from applying the input ts to the
+ 	// prior `stateRoot`.  It returns an error if the transition is invalid.
+-	RunStateTransition(ctx context.Context, ts types.TipSet, tsMessages [][]*types.SignedMessage, tsReceipts [][]*types.MessageReceipt, ancestors []types.TipSet, stateID cid.Cid) (cid.Cid, error)
++	RunStateTransition(ctx context.Context, ts types.TipSet, tsMessages [][]*types.SignedMessage, tsReceipts [][]*types.MessageReceipt, ancestors []types.TipSet, parentWeight uint64, stateID cid.Cid) (cid.Cid, error)
+ }
+
+ // Syncer updates its chain.Store according to the methods of its","""... after protocol version 1""?",nit: `parentWeight` -> `parentID`
+3608,"@@ -32,7 +32,7 @@ from scapy.compat import (
+ _mib_re_integer = re.compile(r""^[0-9]+$"")
+ _mib_re_both = re.compile(r""^([a-zA-Z_][a-zA-Z0-9_-]*)\(([0-9]+)\)$"")
+ _mib_re_oiddecl = re.compile(
+-    r""$\s*([a-zA-Z0-9_-]+)\s+OBJECT([^:\{\}]|\{[^:]+\})+::=\s*\{([^\}]+)\}"", re.M)
++    r""$\s*([a-zA-Z0-9_-]+)\s+OBJECT[^:\{\}]+::=\s*\{([^\}]+)\}"", re.M)
+ _mib_re_strings = re.compile(r'""[^""]*""')
+ _mib_re_comments = re.compile(r'--.*(\r|\n)')
+ ",Is there a unit test that covers this regexp? I am afraid that changing it might break things =/,I am not sure how this change relates to the rest of the PR?
+3609,"@@ -57,7 +57,7 @@ public class RubyNameFormatter implements NameFormatter {
+
+   @Override
+   public String varReference(Name name) {
+-    return ""@"" + name.toLowerUnderscore();
++    return name.toLowerUnderscore();
+   }
+
+   @Override","This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers.",why is this change needed?
+3610,"@@ -27,9 +27,9 @@ class PaymentImageUploadCest
+         $me->amOnPage('/admin/payment/edit/1');
+         $entityEditPage->uploadTestImage(self::IMAGE_UPLOAD_FIELD_ID, self::TEST_IMAGE_NAME);
+         $me->clickByName(self::SAVE_BUTTON_NAME);
+-        $me->seeTranslationAdmin('Payment <strong><a href=""{{ url }}"">%name%</a></strong> modified', 'messages', [
++        $me->seeTranslationAdmin('Payment <strong><a href=""{{ url }}"">{{ name }}</a></strong> modified', 'messages', [
+             '{{ url }}' => '',
+-            '%name%' => t('Credit card', [], 'dataFixtures', $me->getAdminLocale()),
++            '{{ name }}' => t('Credit card', [], 'dataFixtures', $me->getAdminLocale()),
+         ]);
+     }
+ }",Why this change was needed? Because in `po` files it's with curly braces?,the `<%` and `%>` need to be surrounded by double quotes
+3611,"@@ -370,14 +370,14 @@ patch_branch(dr_isa_mode_t isa_mode, cache_pc branch_pc, cache_pc target_pc,
+     ASSERT(ALIGNED(branch_pc, 4) && ALIGNED(target_pc, 4));
+     if ((enc & 0xfc000000) == 0x14000000) { /* B */
+         ASSERT(off + 0x8000000 < 0x10000000);
+-        *pc_writable = (0x14000000 | (0x03ffffff & off >> 2));
++        *pc_writable = (0x14000000 | (0x03ffffff & (off >> 2)));
+     } else if ((enc & 0xff000010) == 0x54000000 ||
+                (enc & 0x7e000000) == 0x34000000) { /* B.cond, CBNZ, CBZ */
+-        ASSERT(off + 0x40000 < 0x80000);
+-        *pc_writable = (enc & 0xff00001f) | (0x00ffffe0 & off >> 2 << 5);
++        ASSERT(off + 0x100000 < 0x200000);
++        *pc_writable = (enc & 0xff00001f) | (0x00ffffe0 & (off >> 2 << 5));
+     } else if ((enc & 0x7e000000) == 0x36000000) { /* TBNZ, TBZ */
+-        ASSERT(off + 0x2000 < 0x4000);
+-        *pc_writable = (enc & 0xfff8001f) | (0x0007ffe0 & off >> 2 << 5);
++        ASSERT(off + 0x8000 < 0x10000);
++        *pc_writable = (enc & 0xfff8001f) | (0x0007ffe0 & (off >> 2 << 5));
+     } else
+         ASSERT(false);
+     if (hot_patch)","Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review.",Shouldn't this be `off + 0x10000 < 0x10000` ?
+3612,"@@ -0,0 +1,3 @@
++module.exports = {
++  presets: [require.resolve('@docusaurus/core/lib/babel/preset')],
++};",seems to be redundant (mention `docusaurus`   ),@dvoytenko had to add this to the package.json file to get the package.json into the package.json.
+3613,"@@ -206,6 +206,12 @@ public interface Table {
+    */
+   Rollback rollback();
+
++  /**
++   *
++   * @return
++   */
++  CherryPick cherrypick();
++
+   /**
+    * Create a new {@link Transaction transaction API} to commit multiple table operations at once.
+    *","Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?",this method should be annotated with `@FunctionalInterface`
+3614,"@@ -52,7 +52,7 @@ static struct internal_amazon_batch_amazon_ids{
+ 	char* aws_secret_access_key;
+ 	char* aws_region;
+ 	char* aws_email;
+-	char* master_env_prefix;
++	char* manager_env_prefix;
+ }initialized_data;
+
+ static unsigned int gen_guid(){","Maybe just `env_prefix`, I don't think this is referring to the WQ manager.","again, I don't think we need to change this, I think in general it's best to leave these as-is"
+3615,"@@ -11,7 +11,6 @@ import android.widget.FrameLayout;
+
+ import com.bytehamster.lib.preferencesearch.SearchPreferenceResult;
+ import com.bytehamster.lib.preferencesearch.SearchPreferenceResultListener;
+-
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.core.preferences.UserPreferences;
+ import de.danoeh.antennapod.fragment.preferences.AutoDownloadPreferencesFragment;",Unrelated line change :),Shouldn't be part of this PR
+3616,"@@ -2,9 +2,13 @@ package net
+
+ import (
+ 	""strings""
++	""syscall""
++	""time""
+
+ 	""github.com/coreos/go-iptables/iptables""
+ 	""github.com/pkg/errors""
++	""github.com/sirupsen/logrus""
++	utilwait ""k8s.io/apimachinery/pkg/util/wait""
+ )
+
+ // AddChainWithRules creates a chain and appends given rules to it.","I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that.",Should we have a package for `pkg/wait`?
+3617,"@@ -228,6 +228,9 @@
+         * @returns {string} encode string
+         */
+         countlyCommon.encodeSomeHtml = function(html, options) {
++            if (countlyGlobal.company) {
++                html.replace(""Countly"", countlyGlobal.company);
++            }
+             if (options) {
+                 return filterXSS(html, options);
+             }","I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string",Do we want to replace the code with `htm
+3618,"@@ -207,7 +207,9 @@ function isNodeShuttingDownError(err) {
+  * @param {Server} server
+  */
+ function isSDAMUnrecoverableError(error, server) {
+-  if (error instanceof MongoParseError) {
++  // NOTE: null check is here for a strictly pre-CMAP world, a timeout or
++  //       close event are considered unrecoverable
++  if (error instanceof MongoParseError || error == null) {
+     return true;
+   }
+ ",ticket for the 4.0 epic?,Why not put this in the `instanceof` che
+3619,"@@ -87,6 +87,10 @@ def main():
+     if cfg.get('cudnn_benchmark', False):
+         torch.backends.cudnn.benchmark = True
+     cfg.model.pretrained = None
++    if cfg.model.get('neck', False):
++        if cfg.model.neck.get('rfp_backbone', False):
++            if cfg.model.neck.rfp_backbone.get('pretrained', False):
++                cfg.model.neck.rfp_backbone.pretrained = None
+     cfg.data.test.test_mode = True
+
+     # init distributed env first, since logger depends on the dist info.","`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value.","For consistency, we should set `pretrain"
+3620,"@@ -5,7 +5,7 @@ module Blacklight
+   module Facet
+
+     def facet_paginator field_config, display_facet
+-      Blacklight::Solr::FacetPaginator.new(display_facet.items,
++      blacklight_config.facet_paginator_class.new(display_facet.items,
+         sort: display_facet.sort,
+         offset: display_facet.offset,
+         limit: facet_limit_for(field_config.key))",Trailing whitespace detected.,Is there a problem with using the `facet_paginator_class` over `Blacklight::Solr::FacetPaginator`? The only difference I see is that the class name is `Blacklight::Solr::FacetPaginator`.
+3621,"@@ -38,6 +38,7 @@ type TargetSpec struct {
+ 	AutoStackSize    *bool    `json:""automatic-stack-size""` // Determine stack size automatically at compile time.
+ 	DefaultStackSize uint64   `json:""default-stack-size""`   // Default stack size if the size couldn't be determined at compile time.
+ 	CFlags           []string `json:""cflags""`
++	CXXFlags         []string `json:""cxxflags""`
+ 	LDFlags          []string `json:""ldflags""`
+ 	LinkerScript     string   `json:""linkerscript""`
+ 	ExtraFiles       []string `json:""extra-files""`",I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file.,Nit: `CXXFlags` is a bit generic-sounding -- should we name it `CXXFlags`?
+3622,"@@ -352,12 +352,13 @@ instrument_annotation(dcontext_t *dcontext, IN OUT app_pc *start_pc,
+ #    endif
+
+     instr_init(dcontext, &scratch);
+-    TRY_EXCEPT(my_dcontext, { identify_annotation(dcontext, &layout, &scratch); },
+-               { /* EXCEPT */
+-                 LOG(THREAD, LOG_ANNOTATIONS, 2,
+-                     ""Failed to instrument annotation at "" PFX ""\n"", *start_pc);
+-                 /* layout.type is already ANNOTATION_TYPE_NONE */
+-               });
++    TRY_EXCEPT(
++        my_dcontext, { identify_annotation(dcontext, &layout, &scratch); },
++        { /* EXCEPT */
++          LOG(THREAD, LOG_ANNOTATIONS, 2, ""Failed to instrument annotation at "" PFX ""\n"",
++              *start_pc);
++          /* layout.type is already ANNOTATION_TYPE_NONE */
++        });
+     if (layout.type != ANNOTATION_TYPE_NONE) {
+         LOG(GLOBAL, LOG_ANNOTATIONS, 2,
+             ""Decoded %s annotation %s. Next pc now "" PFX "".\n"",","Update year range in Copyright notice, and elsewhere too.",Doesn't it work to use a `const char *` instead of a `const char *`?
+3623,"@@ -179,10 +179,10 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
+ // ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
+ // configuration for AWS
+ type ACMEIssuerDNS01ProviderRoute53 struct {
+-	AccessKeyID     string            `json:""accessKeyID""`
+-	SecretAccessKey SecretKeySelector `json:""secretAccessKeySecretRef""`
+-	HostedZoneID    string            `json:""hostedZoneID""`
+-	Region          string            `json:""region""`
++	AccessKeyIDRef     SecretKeySelector `json:""accessKeyIDSecretRef""`
++	SecretAccessKeyRef SecretKeySelector `json:""secretAccessKeySecretRef""`
++	HostedZoneID       string            `json:""hostedZoneID""`
++	Region             string            `json:""region""`
+ }
+
+ // ACMEIssuerDNS01ProviderAzureDNS is a structure containing the","Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?",I think the `AccessKeyID` and `SecretAccessKeyID` should still be fields of the struct.
+3624,"@@ -36,7 +36,7 @@ class UsersController < ApplicationController
+   def save
+     @title = t ""users.new.title""
+
+-    if params[:decline]
++    if params[:decline] || !params[:read_tou] || params[:read_tou] == ""0""
+       if current_user
+         current_user.terms_seen = true
+ ","You don't actually need both tests here as ""truthiness"" means that `""0""` is false and hence the first test will be true...","Do you think you could simplify this to `if params[:read_tou] == ""0""`. I don't feel strongly either way."
+3625,"@@ -39,7 +39,15 @@ feature 'User downgrades subscription', js: true do
+
+     click_button I18n.t('subscriptions.confirm_cancel')
+
+-    expect(page).to have_content ""Scheduled for cancellation on February 19, 2013""
+     expect(page).to have_content I18n.t('subscriptions.flashes.cancel.success')
++
++    click_link I18n.t('subscriptions.reject_refund')
++
++    expect(page).to have_content(
++      I18n.t(
++        'subscriptions.cancellation_scheduled_on',
++        date: 'February 19, 2013'
++      )
++    )
+   end
+ end",Everything else in here is using `I18n`. Should we do that here to be consistent?,"I think we should be more specific here, maybe `expect(page).to have_content(""Scheduled for cancellation"
+3626,"@@ -242,8 +242,8 @@ type Config struct {
+ 	PrometheusGoMetricsEnabled      bool   `config:""bool;true""`
+ 	PrometheusProcessMetricsEnabled bool   `config:""bool;true""`
+
+-	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;tcp:22,udp:68,tcp:179,tcp:2379,tcp:2380,tcp:5473,tcp:6443,tcp:6666,tcp:6667;die-on-fail""`
+-	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:5473,tcp:6443,tcp:6666,tcp:6667;die-on-fail""`
++	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;0.0.0.0/0:tcp:22,0.0.0.0/0:udp:68,0.0.0.0/0:tcp:179,0.0.0.0/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail""`
++	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;0.0.0.0/0:udp:53,0.0.0.0/0:udp:67,0.0.0.0/0:tcp:179,0.0.0.0/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail""`
+
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
+ 	NATPortRange       numorstring.Port   `config:""portrange;""`",What do you think about changing the ordering to be `<protocol>:<cidr>:<port>`? I think it matches the most with what we previously had so that it doesn't change too much for our users.,Does this work if you specify `port-list` with both `0.0.0` and `0.0.0/0`?
+3627,"@@ -442,9 +442,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule,
+       if (rootedAtAtom == -1) {
+         rootedAtAtom = std::rand() % mol.getNumAtoms();
+         // need to find an atom id between 0 and mol.getNumAtoms() exclusively
+-        PRECONDITION(rootedAtAtom < 0 || static_cast<unsigned int>(
+-                                             rootedAtAtom) < mol.getNumAtoms(),
+-                     ""rootedAtomAtom must be less than the number of atoms"");
++        PRECONDITION(
++            static_cast<unsigned int>(rootedAtAtom) < mol.getNumAtoms(),
++            ""rootedAtomAtom must be less than the number of atoms"");
+       }
+     }
+ ",I'm fairly sure this precondition is always true due to the mod (%),"I don't think this is correct. When the atom id is not found, it must be less than the number of atoms."
+3628,"@@ -404,7 +404,7 @@ final class ReaderPool implements Closeable {
+   private boolean noDups() {
+     Set<String> seen = new HashSet<>();
+     for(SegmentCommitInfo info : readerMap.keySet()) {
+-      assert !seen.contains(info.info.name);
++      assert !seen.contains(info.info.name) : ""seen twice: "" + info.info.name ;
+       seen.add(info.info.name);
+     }
+     return true;","I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!","""seen twice"" -> ""not seen twice"""
+3629,"@@ -731,6 +731,8 @@ func loadConfigFromFile(configFile string) (c Local, err error) {
+ 	}
+
+ 	// Migrate in case defaults were changed
++	// If a config file does not have version, it is assumed to be zero.
++	// All fields listed in migrate() might be changed if an actual value matches to default value from a previous version.
+ 	c, err = migrate(c)
+ 	return
+ }",1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0.,"This is a bit confusing, as all "
+3630,"@@ -633,6 +633,14 @@ class Config
+         return $config;
+     }
+
++    /**
++     * Computes the hash to use for a cache folder from CLI flags and from the config file's xml contents
++     */
++    public function computeHash(): string
++    {
++        return sha1($this->hash . ':' . $this->level);
++    }
++
+     /**
+      * Creates a new config object from an XML string
+      * @param  string|null      $current_dir Current working directory, if different to $base_dir",I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?,what is the purpose of this meth
+3631,"@@ -3077,14 +3077,12 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         2018-04-09 00:00:00  1
+         2018-04-12 01:00:00  4
+         """"""
+-        from databricks.koalas.indexes import DatetimeIndex
+-
+         axis = validate_axis(axis)
+
+         if axis != 0:
+             raise NotImplementedError(""between_time currently only works for axis=0"")
+
+-        if not isinstance(self.index, DatetimeIndex):
++        if not isinstance(self.index, ks.DatetimeIndex):
+             raise TypeError(""Index must be DatetimeIndex"")
+
+         kdf = self.copy()",Could you also update it in `at_time`?,Need to change to `ks.DatetimeIn
+3632,"@@ -143,8 +143,9 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+       } catch (IOException ioe) {
+         LOG.warn(""Failed to get Hadoop Filesystem"", ioe);
+       }
++      Boolean localityFallback = LOCALITY_WHITELIST_FS.contains(scheme);
+       this.localityPreferred = options.get(""locality"").map(Boolean::parseBoolean)
+-          .orElse(LOCALITY_WHITELIST_FS.contains(scheme));
++          .orElse(localityFallback);
+     } else {
+       this.localityPreferred = false;
+     }",Because schema is non-final we can't just switch this to a lambda,"Can we rename this to something more explicit, like `isLocalityPreferred`"
+3633,"@@ -136,7 +136,7 @@ namespace NLog.Conditions
+             }
+             catch (Exception exception)
+             {
+-                if (exception.MustBeRethrown())
++                if (exception.MustBeRethrown(""While resolving function '{0}' follwing exception occured: {1}"", functionName, exception))
+                 {
+                     throw;
+                 }",proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes.,"Nit: ""While resolving function '{0}' follwing exception occured: {1}"""
+3634,"@@ -41,9 +41,14 @@ public class InvocationStartProcessingEventListener implements EventListener {
+   public void process(Event data) {
+     InvocationStartProcessingEvent event = (InvocationStartProcessingEvent) data;
+     InvocationMonitor monitor = registryMonitor.getInvocationMonitor(event.getOperationName());
++    //TODO:current java chassis unable know invocation type before starting process,so all type WaitInQueue increment(-1) (decrement)
+     monitor.getWaitInQueue().increment(-1);
++    monitor.setInvocationMonitorType(event.getInvocationType());
+     if (InvocationType.PRODUCER.equals(event.getInvocationType())) {
+       monitor.getLifeTimeInQueue().update(event.getInQueueNanoTime());
++      monitor.getProducerCall().increment();
++    } else {
++      monitor.getConsumerCall().increment();
+     }
+   }
+ }",why? event.getInvocationType is not you want?,shouldn't `monitor.getConsumerCall()` be called after `monitor.getWaitInQ
+3635,"@@ -29,6 +29,7 @@ import (
+ type Info struct {
+ 	ID                string   `json:""server_id""`
+ 	Version           string   `json:""version""`
++	GitHash           string   `json:""git_hash""`
+ 	GoVersion         string   `json:""go""`
+ 	Host              string   `json:""host""`
+ 	Port              int      `json:""port""`",nit: how about `GitSHA`?,struct field git_hash should be gitHash
+3636,"@@ -93,6 +93,7 @@ an example.
+ */
+
+ #define MAX_REMOTE_JOBS_DEFAULT 100
++#define FAIL_DIR ""makeflow.failed.%d""
+
+ static sig_atomic_t makeflow_abort_flag = 0;
+ static int makeflow_failed_flag = 0;","If you move the other functions, this should also be moved to `makeflow_gc.h`.",This should probably be in `Makeflow.h`
+3637,"@@ -55,8 +55,12 @@ def _send_listens_to_queue(listen_type, listens):
+     for listen in listens:
+         if listen_type == LISTEN_TYPE_PLAYING_NOW:
+             try:
+-                expire_time = listen[""track_metadata""][""additional_info""].get(""duration"",
+-                                    current_app.config['PLAYING_NOW_MAX_DURATION'])
++                if 'duration' in listen['track_metadata']['additional_info']:
++                    expire_time = listen['track_metadata']['additional_info']['duration']
++                elif 'duration_ms' in listen['track_metadata']['additional_info']:
++                    expire_time = listen['track_metadata']['additional_info']['duration_ms'] // 1000
++                else:
++                    expire_time = current_app.config['PLAYING_NOW_MAX_DURATION']
+                 redis_connection._redis.put_playing_now(listen['user_id'], listen, expire_time)
+             except Exception as e:
+                 current_app.logger.error(""Redis rpush playing_now write error: "" + str(e))","This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read.",maybe use `listen['track_metadata']['ad
+3638,"@@ -93,7 +93,9 @@ export function coerceToVNode(possibleVNode) {
+
+ 	// Clone vnode if it has already been used. ceviche/#57
+ 	if (possibleVNode._dom!=null) {
+-		return createVNode(possibleVNode.type, possibleVNode.props, possibleVNode.text, possibleVNode.key, null);
++		let vnode = createVNode(possibleVNode.type, possibleVNode.props, possibleVNode.text, possibleVNode.key, null);
++		vnode._dom = possibleVNode._dom;
++		return vnode;
+ 	}
+
+ 	return possibleVNode;",Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!),should this be a `createVNode(...)`?
+3639,"@@ -1964,6 +1964,8 @@ mangle_return(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+             instr_set_src(popf, 1, memop);
+             PRE(ilist, instr, popf);
+         }
++        /* Mangles single step exception after a popf. */
++        mangle_single_step(dcontext, ilist, popf);
+
+ #ifdef X64
+         /* In x64 mode, iret additionally does pop->RSP and pop->ss. */",I think that the iret handling is not yet good.,This needs to be done after the memop->
+3640,"@@ -78,7 +78,7 @@ const DeviceSizeTabBar = ( {
+ 						{ icon }
+ 					</Tab>
+ 				);
+-			}
++			},
+ 			) }
+ 		</TabBar>
+ 	);","Huh, that's kinda weird. I get it, but it's unexpected to me...",Is it possible to avoid re-rendering the TabBar on every render? Should it be encapsulated in its own component?
+3641,"@@ -172,15 +172,6 @@ func (t *Tag) Done(s State) bool {
+ 	return err == nil && n == total
+ }
+
+-// DoneSplit sets total count to SPLIT count and sets the associated swarm hash for this tag
+-// is meant to be called when splitter finishes for input streams of unknown size
+-func (t *Tag) DoneSplit(address swarm.Address) int64 {
+-	total := atomic.LoadInt64(&t.Split)
+-	atomic.StoreInt64(&t.Total, total)
+-	t.Address = address
+-	return total
+-}
+-
+ // Status returns the value of state and the total count
+ func (t *Tag) Status(state State) (int64, int64, error) {
+ 	count, seen, total := t.Get(state), atomic.LoadInt64(&t.Seen), atomic.LoadInt64(&t.Total)",why is this removed? it is important when you upload from stream of unknown size,This was only used in one place so I just inlined it.
+3642,"@@ -3,7 +3,7 @@ class ApiToken < ActiveRecord::Base
+
+   before_create :generate_token
+
+-  belongs_to :approval
++  belongs_to :approval, class_name: 'Approvals::Individual'
+   has_one :proposal, through: :approval
+   has_one :user, through: :approval
+ ","Out of curiosity, why is this needed? Does it enforce what class can be assigned?",Line is too long. [87/80]
+3643,"@@ -174,6 +174,11 @@ func (a *Agent) initEndpoints() error {
+ 		return fmt.Errorf(""Error creating GRPC listener: %s"", err)
+ 	}
+
++	if addr.Network() == ""unix"" {
++		// Any process should be able to use this unix socket
++		os.Chmod(addr.String(), os.ModePerm)
++	}
++
+ 	go func() {
+ 		a.config.ErrorCh <- a.grpcServer.Serve(listener)
+ 	}()","non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar",Does it make sense to allow the privileged users to use this? What happens if they don't?
+3644,"@@ -34,6 +34,8 @@ namespace Nethermind.Mev
+         }
+
+         public IBlockProcessor.IBlockTransactionsExecutor Create(ReadOnlyTxProcessingEnv readOnlyTxProcessingEnv) =>
+-            new MevBlockProductionTransactionsExecutor(readOnlyTxProcessingEnv, _specProvider, _logManager);
++            LastExecutor = new MevBlockProductionTransactionsExecutor(readOnlyTxProcessingEnv, _specProvider, _logManager);
++
++        public MevBlockProductionTransactionsExecutor LastExecutor { get; private set; } = null!;
+     }
+ }","factory should be stateless if possible, looks like much complexity added",What does LastExecutor stand for?
+3645,"@@ -527,6 +527,12 @@ class BigQueryLoadTask(MixinBigQueryBulkComplete, luigi.Task):
+         """"""	Indicates if BigQuery should allow quoted data sections that contain newline characters in a CSV file. The default value is false.""""""
+         return False
+
++    @property
++    def project_id(self):
++        """"""Project ID on which to run the BigQuery Job
++        """"""
++        return self.output().table.project_id
++
+     def run(self):
+         output = self.output()
+         assert isinstance(output, BigQueryTarget), 'Output must be a BigQueryTarget, not %s' % (output)",Could you please add short description for the default value as well?,What is the difference between th
+3646,"@@ -744,7 +744,7 @@ func (bc *blockchain) commitBlock(blk *Block) error {
+ 	if bc.sf != nil {
+ 		ExecuteContracts(blk, bc)
+ 		if err := bc.sf.CommitStateChanges(blk.Height(), blk.Transfers, blk.Votes, blk.Executions); err != nil {
+-			return err
++			logger.Fatal().Err(err).Msgf(""Failed to commit state changes on height %d"", blk.Height())
+ 		}
+ 	}
+ 	// write smart contract receipt into DB","Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction",This is not the right place to do
+3647,"@@ -107,6 +107,18 @@ public class TableProperties {
+   public static final String DELETE_PARQUET_COMPRESSION_LEVEL = ""write.delete.parquet.compression-level"";
+   public static final String PARQUET_COMPRESSION_LEVEL_DEFAULT = null;
+
++  public static final String PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT =
++      ""write.parquet.row-group-check-min-record-count"";
++  public static final String DELETE_PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT =
++      ""write.delete.parquet.row-group-check-min-record-count"";
++  public static final String PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT_DEFAULT = ""100"";
++
++  public static final String PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT =
++      ""write.parquet.row-group-check-max-record-count"";
++  public static final String DELETE_PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT =
++      ""write.delete.parquet.row-group-check-max-record-count"";
++  public static final String PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT_DEFAULT = ""10000"";
++
+   public static final String AVRO_COMPRESSION = ""write.avro.compression-codec"";
+   public static final String DELETE_AVRO_COMPRESSION = ""write.delete.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";",this can be integer,why is this public?
+3648,"@@ -69,6 +69,8 @@ class CompletionView(QTreeView):
+                 {{ color['completion.category.border.top'] }};
+             border-bottom: 1px solid
+                 {{ color['completion.category.border.bottom'] }};
++            font: {{ font['completion.category'] }};
++
+         }
+
+         QTreeView::item:selected, QTreeView::item:selected:hover {",nitpick: Please remove the blank line here,`color` is available from `QTreeView::item`. I think it should be available here.
+3649,"@@ -4,6 +4,7 @@ class Way < ActiveRecord::Base
+   include ConsistencyValidations
+
+   set_table_name 'current_ways'
++  foreign_key 'changeset_id'
+
+   belongs_to :changeset
+ ",What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?,Rails/InverseOf: Specify an :inverse_of option.
+3650,"@@ -798,6 +798,12 @@ public class CoreContainer {
+     SecurityConfHandler.SecurityConfig securityConfig = securityConfHandler.getSecurityConfig(false);
+     initializeAuthorizationPlugin((Map<String, Object>) securityConfig.getData().get(""authorization""));
+     initializeAuthenticationPlugin((Map<String, Object>) securityConfig.getData().get(""authentication""));
++    if (authenticationPlugin != null && authenticationPlugin.plugin.getMetricRegistry() == null) {
++      authenticationPlugin.plugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, ""/authentication"");
++    }
++    if (pkiAuthenticationPlugin != null && pkiAuthenticationPlugin.getMetricRegistry() == null) {
++      pkiAuthenticationPlugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, ""/authentication/pki"");
++    }
+   }
+
+   private static void checkForDuplicateCoreNames(List<CoreDescriptor> cds) {","Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called.",Is there a case when pkiAuthenticationPlugin is not null but pkiAuthenticationPlu
+3651,"@@ -130,6 +130,16 @@ TalkActionResult_t TalkActions::playerSaySpell(Player* player, SpeakClasses type
+ 			}
+ 		}
+
++		if (it->second.fromLua) {
++			if (it->second.getNeedAccess() && !player->getGroup()->access) {
++				return TALKACTION_CONTINUE;
++			}
++
++			if (player->getAccountType() < it->second.getRequiredAccountType()) {
++				return TALKACTION_BREAK;
++			}
++		}
++
+ 		if (it->second.executeSay(player, words, param, type)) {
+ 			return TALKACTION_CONTINUE;
+ 		} else {",shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?,please move this block outside of the `if` statement and return `TALKACTION_CONTI
+3652,"@@ -72,6 +72,8 @@ public class CliqueMiningAcceptanceTest extends AcceptanceTestBase {
+     cluster.stopNode(minerNode2);
+     cluster.stopNode(minerNode3);
+     minerNode1.verify(net.awaitPeerCount(0));
++    minerNode1.verify(clique.blockIsCreatedByProposer(minerNode1));
++
+     minerNode1.verify(clique.noNewBlockCreated(minerNode1));
+   }
+ ",does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?,Why is this test different than the one above?
+3653,"@@ -91,6 +91,12 @@ var _ topicreconciler.Interface = (*Reconciler)(nil)
+ func (r *Reconciler) ReconcileKind(ctx context.Context, topic *v1.Topic) reconciler.Event {
+ 	ctx = logging.WithLogger(ctx, r.Logger.With(zap.Any(""topic"", topic)))
+
++	if v, present := topic.Annotations[v1.LoggingE2ETestAnnotation]; present {
++		// This is added purely for the TestCloudLogging E2E tests, which verify that the log line
++		// is written if this annotation is present.
++		logging.FromContext(ctx).Desugar().Error(""Adding log line for the TestCloudLogging E2E tests"", zap.String(v1.LoggingE2EFieldName, v))
++	}
++
+ 	topic.Status.InitializeConditions()
+ 	topic.Status.ObservedGeneration = topic.Generation
+ ",I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future.,I believe the `v1.LoggingE2EFieldName` is the
+3654,"@@ -960,11 +960,8 @@ class DataFrame(_Frame, Generic[T]):
+         #     sum  12.0  NaN
+         #
+         # Aggregated output is usually pretty much small. So it is fine to directly use pandas API.
+-        pdf = kdf.to_pandas().transpose().reset_index()
+-        pdf = pdf.groupby(['level_1']).apply(
+-            lambda gpdf: gpdf.drop('level_1', 1).set_index('level_0').transpose()
+-        ).reset_index(level=1)
+-        pdf = pdf.drop(columns='level_1')
++        pdf = kdf.to_pandas().stack(level=1)
++        pdf.index = pdf.index.droplevel()
+         pdf.columns.names = [None]
+         pdf.index.names = [None]
+ ",We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns.,This is the same as `pdf.index = pdf.index.dro
+3655,"@@ -14,8 +14,13 @@ namespace Datadog.Trace.ClrProfiler
+         private static readonly Lazy<bool> _enabled = new Lazy<bool>(
+             () =>
+             {
++#if NETSTANDARD2_0
++                // TODO: figure out configuration in .NET Standard 2.0
++                return true;
++#else
+                 string setting = ConfigurationManager.AppSettings[""Datadog.Tracing:Enabled""];
+                 return !string.Equals(setting, bool.FalseString, StringComparison.InvariantCultureIgnoreCase);
++#endif
+             },
+             LazyThreadSafetyMode.PublicationOnly);
+ ","What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now.",How about we make this `bool.TryGetValue` so w
+3656,"@@ -28,9 +28,9 @@ namespace OpenTelemetry.Metrics
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""SpanContext""/>.</param>
++        /// <param name=""context"">the associated <see cref=""SpanReference""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in SpanContext context, T value);
++        public abstract void Add(in SpanReference context, T value);
+
+         /// <summary>
+         /// Adds the given value to the bound counter metric.",should the parameters be called reference or context?,"Thanks, I was thinking about rename `SpanContext` to `SpanReference`. Then the `Add` method would work, too."
+3657,"@@ -184,7 +184,7 @@ module Bolt
+
+             begin
+               if writable && index < in_buffer.length
+-                to_print = in_buffer[index..-1]
++                to_print = in_buffer.byteslice(index..-1)
+                 written = inp.write_nonblock to_print
+                 index += written
+ ",Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work.,"This needs to be `byteslice(0, in_buffer.length - 1)` otherwise Py3 will throw an exception if the index is "
+3658,"@@ -166,6 +166,7 @@ def get_filename_question(*, suggested_filename, url, parent=None):
+     q.title = ""Save file to:""
+     q.text = ""Please enter a location for <b>{}</b>"".format(
+         html.escape(url.toDisplayString()))
++    q.yank_text = url.toString()
+     q.mode = usertypes.PromptMode.download
+     q.completed.connect(q.deleteLater)
+     q.default = _path_suggestion(suggested_filename)",This should be `toDisplayString()` to not contain e.g. passwords.,I think we should remove `q.yank_text` if it's not needed.
+3659,"@@ -180,6 +180,10 @@ class <%= controller_name.classify %>Controller < ApplicationController
+     # If there are more than this many search results, no spelling (""did you
+     # mean"") suggestion is offered.
+     config.spell_max = 5
++
++    # Configuration for autocomplete suggestor
++    config.autocomplete_enabled = true
++    config.autocomplete_path = 'suggest'
+   end
+
+ end ",Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?,Missing space around string interpolation detected.
+3660,"@@ -25,7 +25,7 @@ import (
+
+ 	""github.com/caddyserver/caddy/v2""
+ 	""github.com/caddyserver/caddy/v2/caddyconfig/caddyfile""
+-	""github.com/gogo/protobuf/proto""
++	""github.com/golang/protobuf/proto""
+ 	""github.com/golang/protobuf/ptypes/timestamp""
+ 	""github.com/google/cel-go/cel""
+ 	""github.com/google/cel-go/checker/decls""","Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the ""google.golang.org/protobuf/proto"" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown.",Can we revert the changes in this file?
+3661,"@@ -4,14 +4,3 @@ get ""/pages/*id"" => ""pages#show"", format: false
+ get ""/subscribe"" => ""promoted_catalogs#show"", as: 'subscribe'
+ get ""/privacy"" => ""pages#show"", as: :privacy, id: 'privacy'
+ get ""/terms"" => ""pages#show"", as: :terms, id: 'terms'
+-
+-get(
+-  ""/group-training"" => ""pages#show"",
+-  as: :group_training,
+-  id: ""group-training""
+-)
+-get(
+-  ""/rubyist-booster-shot"" => ""pages#show"",
+-  as: :rubyist_booster_shot,
+-  id: ""rubyist-booster-shot""
+-)",Are these gone routes? Do we need to 301 them?,I think we can remove this controller e
+3662,"@@ -18,10 +18,13 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/vmware-tanzu/antrea/pkg/apis/networking/v1beta1""
++	""github.com/vmware-tanzu/antrea/pkg/controller/networkpolicy""
+ 	""io""
+ 	""os""
+ 	""reflect""
+ 	""sort""
++	""strconv""
+ 	""strings""
+ 	""text/tabwriter""
+ ",move them to internal group of imports,Is this import necessary?
+3663,"@@ -124,6 +124,7 @@ func (c *CStorPoolController) cStorPoolEventHandler(operation common.QueueOperat
+ 		status, err := c.getPoolStatus(cStorPoolGot)
+ 		return status, err
+ 	}
++	glog.Errorf(""Please handle cStorPool '%s' event on '%s'"", string(operation), string(cStorPoolGot.ObjectMeta.Name))
+ 	return string(apis.CStorPoolStatusInvalid), nil
+ }
+ ",can we rewrite this as: `ignored event '%s' for cstor pool '%s'`,why not logging the pool name here?
+3664,"@@ -4,6 +4,8 @@ module Test
+   end
+
+   class ClientRequest < ActiveRecord::Base
++    belongs_to :approving_official, class_name: User
++
+     def self.purchase_amount_column_name
+       :amount
+     end",not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?,This association should go to the `User` model. You can rename `approving_official` to `no_official` or something like that.
+3665,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",This change should also probably go into the corresponding method of the abstract By class?,`T extends WebElement` ?
+3666,"@@ -127,9 +127,6 @@ module.exports = function(config, auth, storage) {
+       } else {
+         next(HTTPError[err.message ? 401 : 500](err.message));
+       }
+-
+-      let base = Utils.combineBaseUrl(Utils.getWebProtocol(req), req.get('host'), config.url_prefix);
+-      res.redirect(base);
+     });
+   });
+ ",why this remove?,Why is this line removed?
+3667,"@@ -54,7 +54,7 @@ type Reader interface {
+ 	Stat(ctx context.Context, path string) (os.FileInfo, error)
+
+ 	// Open opens an existing file for reading, as os.Open.
+-	Open(ctx context.Context, path string) (io.ReadCloser, error)
++	Open(ctx context.Context, path string) (FileReader, error)
+
+ 	// Glob returns all the paths matching the specified glob pattern, as
+ 	// filepath.Glob.","As the test failures indicate, making this change is going to mean changing everything which currently implements this interface.",This interface has gotten more unwieldy and less readable. I'm going to give it a try.
+3668,"@@ -13,7 +13,7 @@ get(
+ get ""/humans-present/oss"" => redirect( ""https://www.youtube.com/watch?v=VMBhumlUP-A"")
+ get ""/ios-on-rails"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+ get ""/ios-on-rails-beta"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+-get ""/live"" => redirect(OfficeHours.url)
++get ""/live"" => redirect(""http://forum.upcase.com"")
+ get ""/pages/tmux"" => redirect(""https://www.youtube.com/watch?v=CKC8Ph-s2F4"")
+ get ""/prime"" => redirect(""/subscribe"")
+ get ""/products/:id/purchases/:lookup"" => redirect(""/purchases/%{lookup}"")",Do we want to redirect this to the forum or something in case people have it linked/bookmarked?,"Out of curiosity, is there a reason for this change?"
+3669,"@@ -21,7 +21,7 @@ export default Component.extend({
+     }),
+
+     backgroundStyle: computed('member.{name,email}', function () {
+-        let name = this.member.name || this.member.email;
++        let name = this.member.name || this.member.email || 'NM';
+         if (name) {
+             let color = stringToHslColor(name, 55, 55);
+             return htmlSafe(`background-color: ${color}`);","@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)","Why did you change the default value from ""NM"" to ""N"
+3670,"@@ -4,5 +4,6 @@ import attr from 'ember-data/attr';
+ export default DS.Model.extend({
+     name: attr('string'),
+     email: attr('string'),
+-    createdAt: attr('moment-utc')
++    createdAt: attr('moment-utc'),
++    subscriptions: attr('member-subscription')
+ });",@kevinansfield Would be cool if you can take a   if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin  ,You will need to add the properties to the `DS.Model
+3671,"@@ -31,10 +31,12 @@ try:
+   import matplotlib.pyplot as plt
+   import matplotlib.cm as cm
+ except ImportError:
+-  # Suppress; we log it at debug level to avoid polluting the logs of apps
+-  # and services that don't care about plotting
+-  logging.debug(""Cannot import matplotlib. Plot class will not work."",
+-                exc_info=True)
++  # Suppress this optional dependency on matplotlib. NOTE we don't log this,
++  # because python logging implicitly adds the StreamHandler to root logger when
++  # calling `logging.debug`, etc., which may undermine an application's logging
++  # configuration.
++  plt = None
++  cm = None
+
+
+ ",This is the common way of dealing with optional dependencies,"we don't log this, because we don't do anything with"
+3672,"@@ -67,8 +67,8 @@ func (t testHelper) AvailableEndpoints() *corev1.Endpoints {
+ 	}
+ }
+
+-func (t testHelper) ReadyDependencyStatus() *duckv1.KResource {
+-	kr := &duckv1.KResource{}
++func (t testHelper) ReadyDependencyStatus() *duckv1.Source {
++	kr := &duckv1.Source{}
+ 	kr.Status.SetConditions(apis.Conditions{{
+ 		Type:   ""Ready"",
+ 		Status: corev1.ConditionTrue,",nit: we can replace all `kr` in this file with like `src`.,@deads2k i assume we don't need to do this for `pkg/api/server/v1/types/unversioned` anymore?
+3673,"@@ -101,7 +101,7 @@ ReadPreference.fromOptions = function(options) {
+   if (typeof readPreference === 'string') {
+     return new ReadPreference(readPreference, readPreferenceTags);
+   } else if (!(readPreference instanceof ReadPreference) && typeof readPreference === 'object') {
+-    const mode = readPreference.mode || readPreference.preference;
++    const mode = readPreference.mode;
+     if (mode && typeof mode === 'string') {
+       return new ReadPreference(mode, readPreference.tags, {
+         maxStalenessSeconds: readPreference.maxStalenessSeconds",same concern here as above,We should still default to the preference if the object doesn't have `mode`.
+3674,"@@ -147,7 +147,7 @@ module Mongoid
+       def raw
+         validate_out!
+         cmd = command
+-        opts = { read: cmd.delete(:read) } if cmd[:read]
++        opts = { read: criteria.options.fetch(:read) } if criteria.options[:read]
+         @map_reduce.database.command(cmd, (opts || {}).merge(session: _session)).first
+       end
+       alias :results :raw","Thank you for this, I gather this repairs failures that I've seen in another PR.",should this be `opts = { read: criteria.options[:read] }` ?
+3675,"@@ -159,7 +159,7 @@ abstract class BaseSparkAction<ThisT, R> implements Action<ThisT, R> {
+         .repartition(spark.sessionState().conf().numShufflePartitions()) // avoid adaptive execution combining tasks
+         .as(Encoders.bean(ManifestFileBean.class));
+
+-    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF(""file_path"");
++    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF(""file_path"").distinct();
+   }
+
+   protected Dataset<Row> buildManifestFileDF(Table table) {","This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?","<!--new_thread; commit:96196be5800a7028d60af26990d8d3f4f23ad5e4; resolved:0--> Did you mean """
+3676,"@@ -1516,6 +1516,11 @@ func (c *ClusterManager) NodeRemoveDone(nodeID string, result error) {
+ 			nodeID, err)
+ 		logrus.Errorf(msg)
+ 	}
++
++	// Remove osdconfig data from etcd
++	if err := c.configManager.DeleteNodeConf(nodeID); err != nil {
++		logrus.Warn(""error removing node from osdconfig:"", err)
++	}
+ }
+
+ func (c *ClusterManager) replayNodeDecommission() {",can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?,"If there is an error moving node configuration, should we also delete the osdconfig?"
+3677,"@@ -6684,7 +6684,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+
+         return self._internal.copy(sdf=sdf, data_columns=columns, column_index=idx)
+
+-    def melt(self, id_vars=None, value_vars=None, var_name='variable',
++    def melt(self, id_vars=None, value_vars=None, var_name=None,
+              value_name='value'):
+         """"""
+         Unpivot a DataFrame from wide format to long format, optionally",Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well.,"This is public API, so we can't change it without a deprecation cycle."
+3678,"@@ -608,6 +608,17 @@ def test_query_parser_path_params_with_slashes():
+     assert params == {""ResourceArn"": resource_arn}
+
+
++def test_parse_cloudtrail_with_botocore():
++    _botocore_parser_integration_test(
++        service=""cloudtrail"",
++        action=""DescribeTrails"",
++        headers={
++            ""X-Amz-Target"": ""com.amazonaws.cloudtrail.v20131101.CloudTrail_20131101.DescribeTrails""
++        },
++        trailNameList=[""t1""],
++    )
++
++
+ # TODO Add additional tests (or even automate the creation)
+ # - Go to the Boto3 Docs (https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/index.html)
+ # - Look for boto3 request syntax definition for services that use the protocol you want to test","I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?",It would be good to also verify the response body as well.
+3679,"@@ -83,7 +83,7 @@ export default AbstractEditController.extend(ChargeActions, PatientSubmodule, {
+         closeModalOnConfirm: false,
+         confirmAction: 'deleteCharge',
+         title: this.get('i18n').t('procedures.titles.deleteMedicationUsed'),
+-        message: this.get('i18n').t('procedures.messages.deleteMedication'),
++        message: this.get('i18n').t('messages.delete_singular', { name: 'medication' }),
+         chargeToDelete: charge,
+         updateButtonAction: 'confirm',
+         updateButtonText: this.get('i18n').t('buttons.ok')",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,I think the name should be `deleteMedicationUsed`
+3680,"@@ -8,12 +8,12 @@ export default class Provider {
+   constructor (opts) {
+     this.opts = opts
+     this.provider = opts.provider
+-    this.id = this.provider
++    this.id = opts.id || this.provider
+     this.name = this.opts.name || _getName(this.id)
+   }
+
+   auth () {
+-    return fetch(`${this.opts.host}/${this.provider}/authorize`, {
++    return fetch(`${this.opts.host}/${this.id}/auth`, {
+       method: 'get',
+       credentials: 'include',
+       headers: {","in case you want to rename one of the plugins when instantiating, from options?",Doesn't this need to default to `opts.id` if it's not provided?
+3681,"@@ -22,6 +22,7 @@ from libcodechecker.logger import add_verbose_arguments
+ from libcodechecker.logger import LoggerFactory
+
+ LOG = LoggerFactory.get_new_logger('ANALYZE')
++CTU_FUNC_MAP_CMD = 'clang-func-mapping'
+
+
+ class OrderedCheckersAction(argparse.Action):","This default variable should be moved into a config variable, created by `package_context`, and read from `config\package_layout.json`.","I am not sure what this is used for, but I am wondering if this"
+3682,"@@ -202,4 +202,16 @@ describe('Walkontable.ViewportColumnsCalculator', () => {
+     expect(calc.stretchAllColumnsWidth.length).toBe(0);
+     expect(calc.needVerifyLastColumnWidth).toBe(true);
+   });
++
++  it('should calculate the number of columns based on a default width, ' +
++    'when the width returned from the function is not a number', () => {
++    const calc = new Walkontable.ViewportColumnsCalculator(200, 0, 1000, () => (void 0 + 1));
++    expect(calc.startColumn).toBe(0);
++    expect(calc.startPosition).toBe(0);
++    expect(calc.endColumn).toBe(3);
++
++    const visibleCalc = new Walkontable.ViewportColumnsCalculator(200, 0, 1000, () => (void 0 + 1), null, true);
++    expect(visibleCalc.startColumn).toBe(0);
++    expect(visibleCalc.endColumn).toBe(3);
++  });
+ });",Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks.,nit: `toBe` instead of `toBe`
+3683,"@@ -313,6 +313,7 @@ void CudaInternal::initialize(int cuda_device_id, cudaStream_t stream) {
+
+   enum { WordSize = sizeof(size_type) };
+
++#ifndef KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK
+ #ifdef KOKKOS_ENABLE_DEPRECATED_CODE
+   if (!HostSpace::execution_space::is_initialized()) {
+ #else","So the intention is you configure with `-CMAKE_CXX_FLAGS=""-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK""`?",Did you mean to leave this in?
+3684,"@@ -396,7 +396,7 @@ void AssignHsResidueInfo(RWMol &mol) {
+           h_label = h_label.substr(3, 1) + h_label.substr(0, 3);
+           AtomPDBResidueInfo *newInfo = new AtomPDBResidueInfo(
+               h_label, max_serial, """", info->getResidueName(),
+-              info->getResidueNumber(), info->getChainId(), """",
++              info->getResidueNumber(), info->getChainId(), """", 1.0, 0.0,
+               info->getIsHeteroAtom());
+           mol.getAtomWithIdx(*begin)->setMonomerInfo(newInfo);
+ ",This was a bug.,@philbucher I'm not sure this is correct. What is the significance of `1.0` and `0.0`?
+3685,"@@ -210,6 +210,19 @@ class ImageExtension extends Twig_Extension
+         $htmlAttributes = $attributes;
+         unset($htmlAttributes['type'], $htmlAttributes['size']);
+
++        $useLazyLoading = array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;
++        $isAttributeClassExistsAndNotEmpty = array_key_exists('class', $attributes) && $attributes['class'] !== '';
++        $htmlAttributes['class'] = sprintf(
++            '%s%s',
++            $useLazyLoading ? 'lazy' : '',
++            $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : ''
++        );
++
++        if ($useLazyLoading) {
++            $htmlAttributes['data-src'] = $htmlAttributes['src'];
++            $htmlAttributes['src'] = '';
++        }
++
+         return $this->templating->render('@ShopsysFramework/Common/image.html.twig', [
+             'attr' => $htmlAttributes,
+             'additionalImagesData' => $additionalImagesData,",Is OK that we don't have some placeholder?,You could simplify this by using `$attributes['class'] ?? ''` directly.
+3686,"@@ -447,11 +447,11 @@ func (node *Node) setupStorageMining(ctx context.Context) error {
+ 		PoStProofType: postProofType,
+ 		SealProofType: sealProofType,
+ 		Miner:         minerAddr,
+-		WorkerThreads: 1,
++		WorkerThreads: 2,
+ 		Paths: []fs.PathConfig{
+ 			{
+ 				Path:   sectorDir,
+-				Cache:  false,
++				Cache:  true,
+ 				Weight: 1,
+ 			},
+ 		},",Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1.,[nit] Can we make this configurable? e.g. `WorkerThreads: 1`
+3687,"@@ -16,8 +16,11 @@
+
+ package azkaban.metrics;
+
++import static azkaban.ServiceProvider.SERVICE_PROVIDER;
++
+ import com.codahale.metrics.Meter;
+ import com.codahale.metrics.MetricRegistry;
++import com.google.inject.Inject;
+ import java.util.concurrent.atomic.AtomicLong;
+
+ /**",Sort of believe We should put MetricManager in constructor parameter given this case.,Remove this extra line
+3688,"@@ -28,11 +28,13 @@ import org.apache.iceberg.transforms.Transform;
+  */
+ public class PartitionField implements Serializable {
+   private final int sourceId;
++  private final int fieldId;
+   private final String name;
+   private final Transform<?, ?> transform;
+
+-  PartitionField(int sourceId, String name, Transform<?, ?> transform) {
++  PartitionField(int sourceId, int fieldId, String name, Transform<?, ?> transform) {
+     this.sourceId = sourceId;
++    this.fieldId = fieldId;
+     this.name = name;
+     this.transform = transform;
+   }",Do we need to check `fieldId` is larger than 1000?,update copyright year in header
+3689,"@@ -356,10 +356,7 @@ void StatefulWriter::unsent_change_added_to_history(
+                     periodic_hb_event_->restart_timer(max_blocking_time);
+                 }
+
+-                if ( (mp_listener != nullptr) && this->is_acked_by_all(change) )
+-                {
+-                    mp_listener->onWriterChangeReceivedByAll(this, change);
+-                }
++                check_acked_status();
+
+                 if (disable_positive_acks_ && last_sequence_number_ == SequenceNumber_t())
+                 {",I think this should be called after the if below (the one for disable positive acks),Doesn't `is_acked_by_all` alrea
+3690,"@@ -271,7 +271,7 @@ public class SparkTableUtil {
+    * @param metricsConfig a metrics conf
+    * @return a List of DataFile
+    */
+-  public static List<DataFile> listPartition(Map<String, String> partition, String uri, String format,
++  public static List<DataFile> listPartition(Map<String, String> partition, URI uri, String format,
+                                              PartitionSpec spec, Configuration conf, MetricsConfig metricsConfig) {
+     if (format.contains(""avro"")) {
+       return listAvroPartition(partition, uri, spec, conf);",I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path).,This seems to be a backwards in
+3691,"@@ -5,11 +5,13 @@ import (
+ 	""path/filepath""
+ 	""testing""
+
++	""github.com/aws/aws-sdk-go/internal/sdktesting""
+ 	""github.com/aws/aws-sdk-go/internal/shareddefaults""
+ )
+
+ func TestSharedCredentialsProvider(t *testing.T) {
+-	os.Clearenv()
++
++	sdktesting.StashEnv()
+
+ 	p := SharedCredentialsProvider{Filename: ""example.ini"", Profile: """"}
+ 	creds, err := p.Retrieve()",Should these restore the stashed env after the test runs?,This is the only real change in
+3692,"@@ -402,7 +402,10 @@ def is_default_argument(
+     if not scope:
+         scope = node.scope()
+     if isinstance(scope, (nodes.FunctionDef, nodes.Lambda)):
+-        for default_node in scope.args.defaults:
++        all_defaults = scope.args.defaults + [
++            d for d in scope.args.kw_defaults if d is not None
++        ]
++        for default_node in all_defaults:
+             for default_name_node in default_node.nodes_of_class(nodes.Name):
+                 if default_name_node is node:
+                     return True",We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``.,Can we just use `scope.args.defaults + [d for d in scope.args.kw_defaults if d is not None]`?
+3693,"@@ -119,6 +119,14 @@ type accountDelta struct {
+ 	new basics.AccountData
+ }
+
++// accountDeltaCount is an extention to accountDelta that is being used by the commitRound function for counting the
++// number of changes we've made per account. The ndeltas is used execlusively for consistency checking - making sure that
++// all the pending changes were written and that there are no outstanding writes missing.
++type accountDeltaCount struct {
++	accountDelta
++	ndeltas int
++}
++
+ // catchpointState is used to store catchpoint related variables into the catchpointstate table.
+ type catchpointState string
+ ","Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?",nit: `ndeltas` is a typo and should be `int`.
+3694,"@@ -21,13 +21,12 @@ import net.sourceforge.pmd.lang.rule.xpath.JaxenXPathRuleQuery;
+ import net.sourceforge.pmd.lang.rule.xpath.SaxonXPathRuleQuery;
+ import net.sourceforge.pmd.lang.rule.xpath.XPathRuleQuery;
+ import net.sourceforge.pmd.properties.EnumeratedProperty;
+-import net.sourceforge.pmd.properties.PropertySource;
+ import net.sourceforge.pmd.properties.StringProperty;
+
+ /**
+  * Rule that tries to match an XPath expression against a DOM view of an AST.
+- *
+- * <p>This rule needs a ""xpath"" property value in order to function.
++ * <p>
++ * <p>This rule needs a ""xpath"" property value in order to function.</p>
+  */
+ public class XPathRule extends AbstractRule {
+ ","Our checkstyle config likes it better when the `<p>` is before the first word of the next paragraph, and not on a blank line",Seems like there is an extra space here.
+3695,"@@ -1498,6 +1498,8 @@ func (c *linuxContainer) criuSwrk(process *Process, req *criurpc.CriuReq, opts *
+ 	if err := cmd.Start(); err != nil {
+ 		return err
+ 	}
++	// we close criuServer so that even if CRIU crashes or unexpectedly exits, runc will not hang.
++	criuServer.Close()
+ 	// cmd.Process will be replaced by a restored init.
+ 	criuProcess := cmd.Process
+ ","This looks to be the only place where we return early before the close below, so if the ""double close"" is bothering people, closing manually here (and removing the `defer`) could be an option",why do we need to close the server here?
+3696,"@@ -91,8 +91,8 @@ gulp.task( 'default', () => {
+ 	);
+ } );
+
+-gulp.task( 'qunit', function() {
+-	execSync( 'node-qunit-phantomjs ./tests/qunit/index.html', { stdio: [ 0, 1, 2 ] } );
++gulp.task( 'jest', function() {
++	execSync( 'npm run test:js', { stdio: [ 0, 1, 2 ] } );
+ } );
+
+ gulp.task( 'phpunit', function() {",This task can probably be deleted since we don't need gulp to run Jest.,"AFAIK, this task doesn't even need to be run on the server, it's only needed to run a locally created version of the package."
+3697,"@@ -23,6 +23,9 @@ require 'socket'
+ module Selenium
+   module WebDriver
+     class SocketPoller
++      NOT_CONNECTED_ERRORS = [Errno::ECONNREFUSED, Errno::ENOTCONN, SocketError]
++      NOT_CONNECTED_ERRORS << Errno::EPERM if Platform.cygwin?
++
+       def initialize(host, port, timeout = 0, interval = 0.25)
+         @host     = host
+         @port     = Integer(port)",Doesn't this need to include `Errno::ECONNRESET` to fix the issue?,`EPERM` should be `ECONNREFUSED`
+3698,"@@ -28,6 +28,19 @@ module Faker
+       def quote
+         fetch('movie.quote')
+       end
++
++      ##
++      # Produces a qirector from a movie.
++      #
++      # @return [String]
++      #
++      # @example
++      #   Faker::Movie.qirector #=> ""Quentin Tarantino""
++      #
++      # @faker.version next
++      def director
++        fetch('movie.director')
++      end
+     end
+   end
+ end",never heard of a qirector... what's their role again? (also should be 'for a movie'),"This should be `@faker.version`, not `next`."
+3699,"@@ -86,6 +86,14 @@ kvstore::ResultCode QueryBoundProcessor::processVertex(PartitionID partId, Verte
+             }
+         }
+         vResp.set_tag_data(std::move(td));
++    } else if (tagContexts_.empty() && onlyVertexProps_) {
++        std::vector<cpp2::TagData> td;
++        auto ret = collectVertexProps(partId, vId, td);
++        if (ret != kvstore::ResultCode::ERR_KEY_NOT_FOUND
++                && ret != kvstore::ResultCode::SUCCEEDED) {
++            return ret;
++        }
++        vResp.set_tag_data(std::move(td));
+     }
+
+     if (onlyVertexProps_) {","Implement the ""collect all props for one vertex"" logic inside QueryVertexPropsProcessor","If `collectVertexProps` returns `ERR_KEY_NOT_FOUND`, why do we need to check that `tagContexts_` is empty? Is `onlyVertexProp"
+3700,"@@ -311,6 +311,10 @@ bool rai::uint256_union::decode_dec (std::string const & text)
+ 		{
+ 			stream >> number_l;
+ 			*this = number_l;
++			if (!stream.eof ())
++			{
++				result = true;
++			}
+ 		}
+ 		catch (std::runtime_error &)
+ 		{","This is to prevent parsing things like ""1.1"" as ""1"" until we implement it properly.",Is this necessary? I thought `stream` would be non-nullable.
+3701,"@@ -25,7 +25,7 @@ import os
+ import shutil
+
+ from nupic.data.file_record_stream import FileRecordStream
+-from nupic.frameworks.opf.experiment_runner import runExperiment
++from nupic.frameworks.opf.experiment_runner import runExperiment, _getCheckpointParentDir
+ from nupic.support import initLogging
+ from nupic.support.unittesthelpers.testcasebase import (
+     unittest, TestCaseBase as HelperTestCaseBase)",Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use.,shouldn't `runExperiment` be renamed as well?
+3702,"@@ -2050,6 +2050,13 @@ class AdvancedPanelControls(wx.Panel):
+ 		self.UIAInMSWordCheckBox.SetValue(config.conf[""UIA""][""useInMSWordWhenAvailable""])
+ 		self.UIAInMSWordCheckBox.defaultValue = self._getDefaultValue([""UIA"", ""useInMSWordWhenAvailable""])
+
++		# Translators: This is the label for a checkbox in the
++		#  Advanced settings panel.
++		label = _(""Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)"")
++		self.ConsoleUIACheckBox=UIAGroup.addItem(wx.CheckBox(self, label=label))
++		self.ConsoleUIACheckBox.SetValue(config.conf[""UIA""][""consoleUIA""])
++		self.ConsoleUIACheckBox.defaultValue = self._getDefaultValue([""UIA"", ""consoleUIA""])
++
+ 		# Translators: This is the label for a group of advanced options in the
+ 		#  Advanced settings panel
+ 		label = _(""Browse mode"")",Why is a restart necessary?,I understand the `ConsoleUIACheckBox` is supposed to be a ch
+3703,"@@ -458,7 +458,11 @@ func (task *Task) addGPUResource(cfg *config.Config) error {
+ 				container.GPUIDs = append(container.GPUIDs, association.Name)
+ 			}
+ 		}
+-		task.populateGPUEnvironmentVariables()
++		// For external instances, GPU IDs are handled by resources struct
++		// For internal instances, GPU IDs are handled by env var
++		if !cfg.External.Enabled() {
++			task.populateGPUEnvironmentVariables()
++		}
+ 		task.NvidiaRuntime = cfg.NvidiaRuntime
+ 	}
+ 	return nil",Should setting the task runtime also go under the above if condition?,It's pretty weird that we need to do this only for internal
+3704,"@@ -32,6 +32,8 @@ import (
+
+ var isDNSLabel = regexp.MustCompile(`^[a-zA-Z0-9]([-]*[a-zA-Z0-9])+$`).MatchString
+
++const _defaultListEntriesPageSize = 50
++
+ //Handler service is used to register SPIFFE IDs, and the attestation logic that should
+ //be performed on a workload before those IDs can be issued.
+ type Handler struct {",SPIRE uses the leadingLowerCase convention for unexported constants,why is this hardcoded to 50?
+3705,"@@ -1,11 +1,12 @@
+ // Copyright (c) Microsoft.  All Rights Reserved.
+ // Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
+
+-using Microsoft.CodeAnalysis.Sarif.Readers;
+ using System;
+ using System.CodeDom.Compiler;
+ using System.Collections.Generic;
+ using System.Runtime.Serialization;
++using Microsoft.CodeAnalysis.Sarif.Readers;
++using Newtonsoft.Json;
+
+ namespace Microsoft.CodeAnalysis.Sarif
+ {",The newest JSchema code generator orders `System` usings first.,nit: remove empty line
+3706,"@@ -82,10 +82,17 @@ public class HiveIcebergSerDe extends AbstractSerDe {
+     }
+
+     String[] selectedColumns = ColumnProjectionUtils.getReadColumnNames(configuration);
+-    Schema projectedSchema = selectedColumns.length > 0 ? tableSchema.select(selectedColumns) : tableSchema;
++    Schema projectedSchema = tableSchema;
++
++    boolean caseSensitive = configuration.getBoolean(InputFormatConfig.CASE_SENSITIVE,
++            InputFormatConfig.CASE_SENSITIVE_DEFAULT);
++    if (selectedColumns.length > 0) {
++      projectedSchema = caseSensitive ? tableSchema.select(selectedColumns)
++              : tableSchema.caseInsensitiveSelect(selectedColumns);
++    }
+
+     try {
+-      this.inspector = IcebergObjectInspector.create(projectedSchema);
++      this.inspector = IcebergObjectInspector.create(projectedSchema, caseSensitive);
+     } catch (Exception e) {
+       throw new SerDeException(e);
+     }","I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced  ",When using a default case se
+3707,"@@ -79,7 +79,7 @@ func (c *CStorPoolController) cStorPoolEventHandler(operation common.QueueOperat
+ 		common.SyncResources.Mux.Lock()
+ 		status, err := c.cStorPoolAddEventHandler(cStorPoolGot)
+ 		common.SyncResources.Mux.Unlock()
+-
++		pool.PoolAddEventHandled = true
+ 		return status, err
+
+ 	case common.QOpDestroy:",Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?,why move this here?
+3708,"@@ -600,11 +600,11 @@ func (c *coroutineLoweringPass) lowerFuncsPass() {
+ 			continue
+ 		}
+
+-		if len(fn.normalCalls) == 0 {
+-			// No suspend points. Lower without turning it into a coroutine.
++		if len(fn.normalCalls) == 0 && fn.fn.FirstBasicBlock().FirstInstruction().IsAAllocaInst().IsNil() {
++			// No suspend points or stack allocations. Lower without turning it into a coroutine.
+ 			c.lowerFuncFast(fn)
+ 		} else {
+-			// There are suspend points, so it is necessary to turn this into a coroutine.
++			// There are suspend points or stack allocations, so it is necessary to turn this into a coroutine.
+ 			c.lowerFuncCoro(fn)
+ 		}
+ 	}","I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible).","Nit: ""No suspend points or stack allocations"""
+3709,"@@ -135,11 +135,19 @@ func chainsForIfaces(ifaceMetadata []string,
+ 	epMarkMapper rules.EndpointMarkMapper,
+ 	host bool,
+ 	tableKind string) []*iptables.Chain {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	log.WithFields(log.Fields{
+ 		""ifaces"":    ifaceMetadata,
+ 		""host"":      host,
+ 		""tableKind"": tableKind,
+ 	}).Debug(""Calculating chains for interface"")
++
+ 	chains := []*iptables.Chain{}
+ 	dispatchOut := []iptables.Rule{}
+ 	dispatchIn := []iptables.Rule{}",Why isn't this 4789 (which I think is the Felix default)?,How do we decide on this value? Should we mak
+3710,"@@ -57,6 +57,10 @@ const (
+ 	MessageResourceFailCreate EventReason = ""Resource creation failed""
+ 	// SuccessImported holds status for corresponding imported resource.
+ 	SuccessImported EventReason = ""Imported""
++	// FailureImported holds status for corresponding imported resource.
++	FailureImported EventReason = ""Import failure""
++	// FailureImportOperations holds status for corresponding imported resource.
++	FailureImportOperations EventReason = ""Failure Import operations""
+ 	// MessageResourceImported holds message for corresponding imported resource.
+ 	MessageResourceImported EventReason = ""Resource imported successfully""
+ 	// FailureStatusSync holds status for corresponding failed status sync of resource.","Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason<Action><Entity/Adjective of the Entity><Sucess/Failure>`",does this need to be added to `constants.go`?
+3711,"@@ -457,4 +457,5 @@ void Init_binary_protocol_accelerated() {
+   rb_define_method(bpa_class, ""read_set_end"", rb_thrift_binary_proto_read_set_end, 0);
+
+   rbuf_ivar_id = rb_intern(""@rbuf"");
++  rb_global_variable(&rbuf_ivar_id);
+ }",I suspect this isn't needed because I think `rb_intern` gets marked already.,Wouldn't it be better to use rb_intern?
+3712,"@@ -96,7 +96,7 @@ public class InternalSelenseTestBase extends SeleneseTestBase {
+       return;
+     }
+
+-    log.info(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
++    log.finest(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
+
+     Path dir =
+       InProject.locate(""java/client/build/production/com/thoughtworks/selenium/webdriven"");",This change is incorrect: the current log level is correct.,This should not be part of this PR
+3713,"@@ -80,7 +80,8 @@ public class BKDWriter implements Closeable {
+   //public static final int VERSION_CURRENT = VERSION_START;
+   public static final int VERSION_LEAF_STORES_BOUNDS = 5;
+   public static final int VERSION_SELECTIVE_INDEXING = 6;
+-  public static final int VERSION_CURRENT = VERSION_SELECTIVE_INDEXING;
++  public static final int VERSION_LOW_CARDINALITY_LEAVES= 7;
++  public static final int VERSION_CURRENT = VERSION_LOW_CARDINALITY_LEAVES;
+
+   /** How many bytes each docs takes in the fixed-width offline format */
+   private final int bytesPerDoc;",Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR.,Do we really need this new version
+3714,"@@ -268,7 +268,10 @@ public class ExecutorServlet extends HttpServlet implements ConnectorParams {
+         continue;
+       }
+
+-      if (flow.getUpdateTime() > updateTime) {
++      // After removing runningFlows cache from web server, flow info will be fetched from DB directly,
++      // updateTime will be synced between web server and executor. So below if condition will always be true.
++      // TODO: will remove UpdaterThread in executorManager and deprecate handleAjaxUpdateRequest()
++      if (flow.getUpdateTime() >= updateTime) {
+         updateList.add(flow.toUpdateObject(updateTime));
+       }
+     }",Please follow the todo naming convention.,We should also deprecate the Updat
+3715,"@@ -28,6 +28,9 @@ import (
+ // +k8s:openapi-gen=true
+ // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+
++// +kubebuilder:printcolumn:name=""Ready"",type=""string"",JSONPath="".status.conditions[?(@.type==\""Ready\"")].status"",description=""""
++// +kubebuilder:printcolumn:name=""Status"",type=""string"",JSONPath="".status.conditions[?(@.type==\""Ready\"")].message"",description=""""
++// +kubebuilder:printcolumn:name=""Age"",type=""date"",JSONPath="".metadata.creationTimestamp"",description=""CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.""
+ // +kubebuilder:subresource:status
+ // +kubebuilder:resource:path=clusterissuers,scope=Cluster
+ type ClusterIssuer struct {",These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds`   /assign @JoshVanL /unassign,@smarterclayton @jadarsie do we ne
+3716,"@@ -257,9 +257,11 @@ class YOLOV3Head(BaseDenseHead, BBoxTestMixin):
+             # (h, w, num_anchors*num_attrib) -> (h*w*num_anchors, num_attrib)
+             pred_map = pred_map.permute(1, 2, 0).reshape(-1, self.num_attrib)
+
+-            pred_map[..., :2] = torch.sigmoid(pred_map[..., :2])
+-            bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i],
+-                                               pred_map[..., :4], stride)
++            xy = torch.sigmoid(pred_map[..., :2])
++            xywh = torch.cat((xy, pred_map[..., 2:4]), axis=-1)
++            bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i], xywh,
++                                               stride)
++
+             # conf and cls
+             conf_pred = torch.sigmoid(pred_map[..., 4]).view(-1)
+             cls_pred = torch.sigmoid(pred_map[..., 5:]).view(",Is this really necessary to work around this way? The old version works fine with me when converting to ONNX.,Can we have a unit test for this?
+3717,"@@ -71,7 +71,7 @@ type s3Blob struct {
+
+ func (bb *s3Blob) Write(p []byte) (int, error) {
+ 	if bb.final {
+-		return 0, errors.New(""blob already closed"")
++		return 0, errors.New(""Blob already closed"")
+ 	}
+
+ 	n, err := bb.buf.Write(p)","Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)",This looks unrelated to the rest
+3718,"@@ -168,6 +168,7 @@ module Beaker
+
+       options[:recursive]=File.directory?(source) if options[:recursive].nil?
+
++      @logger.debug ""going to upload! #{source} to #{@hostname}:#{target}""
+       @ssh.scp.upload! source, target, options
+
+       result = Result.new(@hostname, [source, target])",Is this a testing debug statement?,Prefer single-quoted strings when
+3719,"@@ -849,7 +849,11 @@ var connect = function(self, url, options, callback) {
+   }
+
+   // Parse the string
+-  var object = parse(url, options);
++  var object;
++  parse(url, options, function(err, connectionStringObject) {
++    if (err) return console.log(err);
++    object = connectionStringObject;
++  });
+   var _finalOptions = createUnifiedOptions({}, object);
+   _finalOptions = mergeOptions(_finalOptions, object, false);
+   _finalOptions = createUnifiedOptions(_finalOptions, options);","you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`.",We don't want to silently ignore
+3720,"@@ -238,9 +238,9 @@ thread ([this]() {
+
+ void nano::worker::run ()
+ {
++	std::unique_lock<std::mutex> lk (mutex);
+ 	while (!stopped)
+ 	{
+-		std::unique_lock<std::mutex> lk (mutex);
+ 		if (!queue.empty ())
+ 		{
+ 			auto func = queue.front ();","This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with.","Please don't make these changes, they are not related to the PR."
+3721,"@@ -27,6 +27,10 @@ import (
+ 	""strings""
+ 	""time""
+
++	""github.com/mysteriumnetwork/node/cmd/commands""
++
++	remote_config ""github.com/mysteriumnetwork/node/config/remote""
++
+ 	""github.com/chzyer/readline""
+ 	""github.com/rs/zerolog/log""
+ 	""github.com/urfave/cli/v2""","Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can.",can you remove this empty line?
+3722,"@@ -1128,12 +1128,16 @@ encode_opnd_imm5(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ static inline bool
+ decode_opnd_imm6(uint enc, int opcode, byte *pc, OUT opnd_t *opnd)
+ {
++    if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))
++        return false;
+     return decode_opnd_int(10, 6, false, 0, OPSZ_6b, 0, enc, opnd);
+ }
+
+ static inline bool
+ encode_opnd_imm6(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ {
++    if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))
++        return false;
+     return encode_opnd_int(10, 6, false, 0, 0, opnd, enc_out);
+ }
+ ",Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below.,"Should this be `TEST(1U << 31, enc) && TEST(1U << 15, enc)`?"
+3723,"@@ -125,9 +125,6 @@ function generateTopologyTests(testSuites, testContext, filter) {
+       describe(suiteName, {
+         metadata: { requires },
+         test: function () {
+-          beforeEach(() => prepareDatabaseForSuite(testSuite, testContext));
+-          afterEach(() => testContext.cleanupAfterSuite());
+-
+           testSuite.tests.forEach(spec => {
+             it(spec.description, function () {
+               if (","I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change",Can you explain why these are removed?
+3724,"@@ -213,6 +213,9 @@ class LoadAnnotations:
+             annotation. Default: False.
+         poly2mask (bool): Whether to convert the instance masks from polygons
+             to bitmaps. Default: True.
++        normed_bbox (bool): Whether to convert bbox from relative value to
++            absolute value. Only used in OpenImage Dataset.
++            Default: False.
+         file_client_args (dict): Arguments to instantiate a FileClient.
+             See :class:`mmcv.fileio.FileClient` for details.
+             Defaults to ``dict(backend='disk')``.",Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`,"This should mention that if `normed_bbox` is enabled, then `image_size` must be set to the same value as `image_size`. If it is disabled, then `image_size` must be greater than `image_size`."
+3725,"@@ -32,10 +32,10 @@ func (*testTraceProvider) Tracer(_ string, _ ...trace.TracerOption) trace.Tracer
+ func TestMultipleGlobalTracerProvider(t *testing.T) {
+ 	p1 := testTraceProvider{}
+ 	p2 := trace.NoopProvider{}
+-	global.SetTraceProvider(&p1)
+-	global.SetTraceProvider(&p2)
++	global.SetTracerProvider(&p1)
++	global.SetTracerProvider(&p2)
+
+-	got := global.TraceProvider()
++	got := global.TracerProvider()
+ 	want := &p2
+ 	if got != want {
+ 		t.Fatalf(""Provider: got %p, want %p\n"", got, want)",Should we change the name of this test struct to be `testTracerProvider` as well?,I think this is the only real change in this file.
+3726,"@@ -21,13 +21,14 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/config""
+-	""github.com/iotexproject/iotex-core/explorer""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/probe""
++	""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ 	""github.com/iotexproject/iotex-core/server/itx""
+ 	""github.com/iotexproject/iotex-core/testutil""
+ 	""github.com/iotexproject/iotex-core/tools/util""
++	""google.golang.org/grpc""
+ )
+
+ const (","""google.golang.org/grpc"" should be together with ""go.uber.org/zap"" all """"github.com/iotexproject/iotex-core/*"" stay together",Could you move this import down with the other iotexproject imports?
+3727,"@@ -700,6 +700,12 @@ class WebEngineTab(browsertab.AbstractTab):
+         self._inject_early_js('js', js_code, subframes=True)
+         self._init_stylesheet()
+
++        js_code_print = utils.read_file('javascript/print.js')
++        self._inject_early_js('js',
++                              js_code_print,
++                              subframes=True,
++                              world=QWebEngineScript.MainWorld)
++
+         greasemonkey = objreg.get('greasemonkey')
+         greasemonkey.scripts_reloaded.connect(self._inject_userscripts)
+         self._inject_userscripts()",No need for a separate variable here - just call `utils.read_file` directly below.,Not sure if `mainWorld` is the right place to put this code. I am thinking it should be better to just pass `self._inject_early_js` directly to `_inject_early_js`
+3728,"@@ -150,8 +150,18 @@ func (ctx *ChannelContext) SendResp(message model.Message) {
+
+ 	ctx.anonChsLock.RLock()
+ 	defer ctx.anonChsLock.RUnlock()
++
++	deadline := time.Now().Add(MessageTimeoutDefault)
++	sendTimer := time.NewTimer(time.Until(deadline))
++
+ 	if channel, exist := ctx.anonChannels[anonName]; exist {
+-		channel <- message
++		select {
++		case channel <- message:
++		case <-sendTimer.C:
++			klog.Warning(""timeout when SendResp message"")
++			return
++		}
++		sendTimer.Stop()
+ 		return
+ 	}
+ ","Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?",should this be an error instead of warning?
+3729,"@@ -29,7 +29,8 @@ type SyncStage byte
+
+ const (
+ 	Headers   SyncStage = iota // Headers are downloaded, their Proof-Of-Work validity and chaining is verified
+-	Bodies                     // Block bodies are downloaded, TxHash and UncleHash are getting verified, ""From"" recovered from signatures
++	Bodies                     // Block bodies are downloaded, TxHash and UncleHash are getting verified
++	Senders                    // ""From"" recovered from signatures, bodies re-written
+ 	Execution                  // Executing each block w/o buildinf a trie
+ 	HashCheck                  // Checking the root hash
+ 	Finish                     // Nominal stage after all other stages","maybe we will have something like `Bodies []byte(""bodies"")` instead of them being a number? with numbers we are making it harder to insert stages mid-process.",Could this be part of `SyncStage`?
+3730,"@@ -82,11 +82,11 @@ type Endpoint struct {
+ // GroupMember represents resource member to be populated in Groups.
+ // This supersedes GroupMemberPod, and will eventually replace it.
+ type GroupMember struct {
+-	// ExternalEntity maintains the reference to the ExternalEntity.
+-	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,1,opt,name=externalEntity""`
+-
+ 	// Pod maintains the reference to the Pod.
+-	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,2,opt,name=pod""`
++	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,1,opt,name=pod""`
++
++	// ExternalEntity maintains the reference to the ExternalEntity.
++	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,2,opt,name=externalEntity""`
+
+ 	// Endpoints maintains a list of EndPoints associated with this groupMember.
+ 	Endpoints []Endpoint `json:""endpoints,omitempty"" protobuf:""bytes,3,rep,name=endpoints""`","out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?",does this need to be a pointer?
+3731,"@@ -334,6 +334,10 @@ func (manager *connectionManager) Disconnect() error {
+ 	manager.cleanConnection()
+ 	manager.setStatus(statusNotConnected())
+
++	manager.eventPublisher.Publish(StateEventTopic, StateEvent{
++		State:       NotConnected,
++		SessionInfo: manager.sessionInfo,
++	})
+ 	return nil
+ }
+ ",Could we public events if `manager.serStatus()`?,Does it make sense to publish this after th
+3732,"@@ -134,7 +134,9 @@ module.exports = class Plugin {
+     }
+
+     this.uppy.log(`Not installing ${callerPluginName}`)
+-    throw new Error(`Invalid target option given to ${callerPluginName}`)
++    throw new Error(`Invalid target option given to ${callerPluginName}. Please make sure that the element
++      exists on the page, or that the plugin you are targeting has been installed. Check that the <script> tag initializing Uppy
++      comes at the bottom of the page, before the </body> (see https://github.com/transloadit/uppy/issues/1042).`)
+   }
+
+   render (state) {","could be misread as `<body>`, maybe something redundant but very clear like ""before the closing `</body>` tag""?","I think this is a bit confusing because we don't know that the plugin you are targeting has been installed. What about something like ""Please ensure that the element exists on the page, or that the plugin you are targeting has been installed. Check that the <script> tag starting up to the bottom of the page, or that the plugin you are targeting has been installed."""
+3733,"@@ -510,12 +510,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+             var testLogger = new TestApplicationErrorLogger();
+             var serviceContext = new TestServiceContext { Log = new TestKestrelTrace(testLogger) };
+
+-            using (var server = new TestServer(httpContext =>
++            using (var server = new TestServer(async httpContext =>
+             {
+                 httpContext.Response.ContentLength = 11;
+-                httpContext.Response.Body.Write(Encoding.ASCII.GetBytes(""hello,""), 0, 6);
+-                httpContext.Response.Body.Write(Encoding.ASCII.GetBytes("" world""), 0, 6);
+-                return Task.CompletedTask;
++                await httpContext.Response.Body.WriteAsync(Encoding.ASCII.GetBytes(""hello,""), 0, 6);
++                await httpContext.Response.Body.WriteAsync(Encoding.ASCII.GetBytes("" world""), 0, 6);
+             }, serviceContext))
+             {
+                 using (var connection = server.CreateConnection())","This test is specifically checking behavior on sync I/O (note there are tests with Write in the name, and other tests with WriteAsync). Enable sync I/O here.","We don't have to do it in this PR, but it would be nice if we didn't have to do `using (var server = new TestServer(testLogger))`"
+3734,"@@ -0,0 +1,11 @@
++class WeeklyIterationDripMailerPreview < ActionMailer::Preview
++  def weekly_update
++    user = User.new(name: 'John Doe')
++    video = Video.first.tap do |video|
++      video.email_body_text = 'Email body text'
++      video.email_cta_label = 'Click Here!'
++    end
++
++    WeeklyIterationDripMailer.weekly_update(user: user, video: video)
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,`weekly_update` is only used in the view. Let's rename it to `weekly_update_email_body_text`.
+3735,"@@ -56,6 +56,8 @@ type CStorVolumeClaimSpec struct {
+ 	// CStorVolumeRef has the information about where CstorVolumeClaim
+ 	// is created from.
+ 	CStorVolumeRef *corev1.ObjectReference `json:""cstorVolumeRef,omitempty""`
++	// CstorVolumeSource contains the source volumeID+Snapshot combaination
++	CstorVolumeSource string `json:""cstorVolumeSource,omitempty""`
+ }
+
+ // CStorVolumeClaimPublish contains info related to attachment of a volume to a node.",nit: Should we have something like `volumeName@snapShotname` and this will be filled only if it is a clone creation,@smarterclayton @jackfrancis do you have any ideas on how we can unit test this?
+3736,"@@ -164,10 +164,13 @@ func WriteWordpressConfig(wordpressConfig *WordpressConfig, filePath string) err
+ 		return err
+ 	}
+
+-	// Ensure target directory is writable.
++	// Ensure target directory exists and is writeable
+ 	dir := filepath.Dir(filePath)
+-	err = os.Chmod(dir, 0755)
+-	if err != nil {
++	if err = os.Chmod(dir, 0755); os.IsNotExist(err) {
++		if err = os.MkdirAll(dir, 0755); err != nil {
++			return err
++		}
++	} else if err != nil {
+ 		return err
+ 	}
+ ",This seems like an improved pattern :),This was a bug I found. We now always create the target directory if it doesn't exist.
+3737,"@@ -53,7 +53,11 @@ def get_hdfs_syntax():
+     override this setting with ""cdh3"" or ""apache1"" in the hadoop section of the config in
+     order to use the old syntax
+     """"""
+-    return configuration.get_config().get(""hadoop"", ""version"", ""cdh4"").lower()
++    try:
++        import snakebite
++        return configuration.get_config().get(""hadoop"", ""version"", ""snakebite"").lower()
++    except ImportError:
++        return configuration.get_config().get(""hadoop"", ""version"", ""cdh4"").lower()
+
+
+ def load_hadoop_cmd():","I think it would be better to have a separate configuration option for specifying which HDFS interaction layer to use instead of using the existing hadoop version option. I think there are still cases where things might have to rely on Hadoop version for other things, and overwriting that information with ""snakebite"" would make that difficult. The existing hadoop version option could still be used to distinguish the different HDFS CLI flavours.","We don't need to import `snakebite` here, as `hadoop` is already imported in the `try`"
+3738,"@@ -575,10 +575,15 @@ module Bolt
+       outputter.print_task_info(pal.get_task(task_name))
+     end
+
++    # Filters a list of content by matching substring.
++    #
++    private def filter_content(content, filter)
++      return content unless content && filter
++      content.select { |name,| name.include?(filter) }
++    end
++
+     def list_tasks
+-      tasks = pal.list_tasks
+-      tasks.select! { |task| task.first.include?(options[:filter]) } if options[:filter]
+-      tasks.select! { |task| config.project.tasks.include?(task.first) } unless config.project.tasks.nil?
++      tasks = filter_content(pal.list_tasks(filter_content: true), options[:filter])
+       outputter.print_tasks(tasks, pal.user_modulepath)
+     end
+ ",Why are we filtering content twice? It seems like just filtering it in PAL should work.,Layout/SpaceAfterComma: Space missing after comma.
+3739,"@@ -17,11 +17,11 @@
+  */
+
+ export const ACCOUNT_STATUS_NONE = 'none';
++export const ACCOUNT_STATUS_MULTIPLE = 'multiple';
+ export const ACCOUNT_STATUS_DISAPPROVED = 'disapproved';
+ export const ACCOUNT_STATUS_GRAYLISTED = 'graylisted';
+-export const ACCOUNT_STATUS_MULTIPLE = 'multiple';
+-export const ACCOUNT_STATUS_NO_CLIENT = 'no-client';
+ export const ACCOUNT_STATUS_PENDING = 'pending';
++export const ACCOUNT_STATUS_NO_CLIENT = 'no-client';
+ export const ACCOUNT_STATUS_APPROVED = 'approved';
+
+ // TODO: Expand the statuses provided here to be more specific in case the",These should probably move to `constants.js`,Can we keep this in sync with the other statuses?
+3740,"@@ -21,6 +21,8 @@ import com.google.common.base.Charsets;
+ import com.google.common.io.ByteStreams;
+ import com.google.common.net.MediaType;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.apache.http.Header;
+ import org.apache.http.HttpEntity;
+ import org.apache.http.HttpHost;","Again, you don't want to depend on glassfish.",Is this import necessary?
+3741,"@@ -0,0 +1,15 @@
++# frozen_string_literal: true
++
++module Faker
++  module Space
++    class << self
++      extend Gem::Deprecate
++
++      def launch_vehicule
++        Faker::Space.launch_vehicule
++      end
++
++      deprecate :launch_vehicule, 'Faker::Space.launch_vehicule', 2019, 06
++    end
++  end
++end","it should be `Faker::Space.launch_vehicle`, otherwise it will crash",Extra empty line detected
+3742,"@@ -630,6 +630,18 @@ namespace NLog.Targets
+ #endif
+             byte[] bytes = this.GetBytesToWrite(logEvent);
+
++            // Clean up old archives if this is the first time a log record has been written to
++            // this log file and the archiving system is date/time based.
++            if (this.ArchiveNumbering == ArchiveNumberingMode.Date && this.ArchiveEvery != FileArchivePeriod.None)
++            {
++                FileInfo fileInfo = new FileInfo(fileName);
++                if (!fileInfo.Exists)
++                {
++                    string fileNamePattern = this.GetFileNamePattern(fileName, logEvent, fileInfo);
++                    this.DeleteOldDateArchive(fileNamePattern);
++                }
++            }
++
+             if (this.ShouldAutoArchive(fileName, logEvent, bytes.Length))
+             {
+                 this.InvalidateCacheItem(fileName);",Isn't it quite expensive to check whether the file exists on every write?,Do we even need to do any
+3743,"@@ -165,7 +165,9 @@ webdriver.Builder.prototype.build = function() {
+   } else {
+     var url = this.serverUrl_;
+     var client;
+-    if (url[0] == '/') {
++    if (webdriver.http.CorsClient.isAvailable()) {
++      client = new webdriver.http.XhrClient(url);
++    } else if (url[0] == '/') {
+       var origin = window.location.origin ||
+           (window.location.protocol + '//' + window.location.host);
+       client = new webdriver.http.XhrClient(origin + url);",Please hide this behind a flag and add a setter function to the builder.,Would it be better to che
+3744,"@@ -1009,6 +1009,7 @@ func (vd *volAPI) Routes() []*Route {
+ 		{verb: ""POST"", path: backupPath(""/restore"", volume.APIVersion), fn: vd.cloudBackupRestore},
+ 		{verb: ""GET"", path: backupPath("""", volume.APIVersion), fn: vd.cloudBackupEnumerate},
+ 		{verb: ""DELETE"", path: backupPath("""", volume.APIVersion), fn: vd.cloudBackupDelete},
++		{verb: ""DELETE"", path: backupPath(""/all"", volume.APIVersion), fn: vd.cloudBackupDeleteAll},
+ 		{verb: ""GET"", path: backupPath(""/status"", volume.APIVersion), fn: vd.cloudBackupStatus},
+ 		{verb: ""GET"", path: backupPath(""/catalog"", volume.APIVersion), fn: vd.cloudBackupCatalog},
+ 		{verb: ""GET"", path: backupPath(""/history"", volume.APIVersion), fn: vd.cloudBackupHistory},",old api should be deprecated if we don't intend on using it anymore. Again this should happen through swagger api and then removed from next release. We should also release not this as a breaking change. (same with all the other cloudsnap api renames.,Is there any way we can test this endpoint to see if the user is authorized to do the action?
+3745,"@@ -59,7 +59,7 @@ public class VertxRestTransport extends AbstractTransport {
+     }
+
+     if (!NetUtils.canTcpListen(ep.getSocketAddress().getAddress(), ep.getPort())) {
+-      log.info(""can not listen {}, skip {}."", ep.getSocketAddress(), this.getClass().getName());
++      log.warn(""can not listen {}, port may have been occupied, this may cause client report error when being accessed. skip {}."", ep.getSocketAddress(), this.getClass().getName());
+       return false;
+     }
+ ","so strange...... canTcpListen is to detect, if this transport can init when customers deployed vertx and servlet rest transport, we must detect which one will be used only both of them refused to init is a problem. we have already print that......",`this may cause client report error when being accessed` -> `this may have been accessed`
+3746,"@@ -38,6 +38,8 @@ import com.salesforce.androidsdk.util.JSONObjectHelper;
+  */
+ public class QuerySpec {
+ 	private static final String SELECT_COUNT = ""SELECT count(*) "";
++    private static final String SELECT_COUNT_FORM = SELECT_COUNT + "" FROM (%s)"";
++
+ 	// Constants
+ 	private static final String SELECT = ""SELECT  "";
+ 	private static final String FROM = ""FROM "";","Did you mean for this to be `FORM`, instead of `FROM`?",Why the space between `from` and `%s`?
+3747,"@@ -94,6 +94,13 @@ type AWSMachineSpec struct {
+ 	// +kubebuilder:validation:MaxItems=2
+ 	NetworkInterfaces []string `json:""networkInterfaces,omitempty""`
+
++	// UncompressedUserData specify whether the user data is gzip-compressed before it is sent to ec2 instance.
++	// cloud-init has built-in support for gzip-compressed user data
++	// user data stored in aws secret manager is always gzip-compressed.
++	//
++	// +optional
++	UncompressedUserData *bool `json:""uncompressedUserData,omitempty""`
++
+ 	// CloudInit defines options related to the bootstrapping systems where
+ 	// CloudInit is used.
+ 	// +optional",What are your thoughts on the long term solution for the naming of this variable? Do you think we should revert the logic when we are ready to make the next set of breaking API changes?,Can we add a validation check to ensure `UncompressedUserData` is set (i.e. that it is not gz
+3748,"@@ -92,14 +92,15 @@ module RSpec
+         command = spec_command
+
+         begin
+-          puts command if verbose
++          $stdout.puts(command}) if verbose
+           success = system(command)
+         rescue
+-          puts failure_message if failure_message
++          $stderr.puts failure_message if failure_message
+         end
++
+         if fail_on_error && !success
+-          $stderr.puts ""#{command} failed""
+-          exit $?.exitstatus
++          $stderr.puts(""#{command} failed"") if verbose
++          exit($?.exitstatus)
+         end
+       end
+ ",There's a syntax error on this line.,`$stdout.puts` should be moved outside the `rescue` block.
+3749,"@@ -834,7 +834,7 @@ fpga_result clear_port_errors(fpga_handle afu_handle)
+ 	result = fpgaObjectRead64(port_error_object, &value, 0);
+ 	if (result != FPGA_OK) {
+ 		OPAE_ERR(""Failed to Read Object "");
+-		return result;
++		goto out;
+ 	}
+
+ 	printf(""\n \n Port error CSR : 0x%lx \n"", value);",You lose the value of `result` when you `goto out`,If we're not going to call `goto out` then we should proba
+3750,"@@ -497,8 +497,9 @@ Blockly.Scrollbar.prototype.onScroll_ = function() {
+  * @param {number} value The distance from the top/left end of the bar.
+  */
+ Blockly.Scrollbar.prototype.set = function(value) {
++  var ratio = this.ratio_ == undefined ? 0 : this.ratio_;
+   // Move the scrollbar slider.
+-  this.svgKnob_.setAttribute(this.horizontal_ ? 'x' : 'y', value * this.ratio_);
++  this.svgKnob_.setAttribute(this.horizontal_ ? 'x' : 'y', value * ratio);
+   this.onScroll_();
+ };
+ ","Just a style thing, why not `this.ratio_ || 0`?",Is there a case where `ratio_` will be 0 and `value` will
+3751,"@@ -186,7 +186,8 @@ func CIDRFromCalicoNet(ipNet calinet.IPNet) CIDR {
+
+ func CIDRFromIPNet(ipNet *net.IPNet) CIDR {
+ 	ones, _ := ipNet.Mask.Size()
+-	ip := FromNetIP(ipNet.IP)
++	// Mask the IP before creating the CIDR so that we have it in canonical format.
++	ip := FromNetIP(getMaskedIp(ipNet))
+ 	if ip.Version() == 4 {
+ 		return V4CIDR{
+ 			addr:   ip.(V4Addr),","I think the stdlib's `net.IP` has a `Mask()` method, does that do what we need?",Don't we need the `getMaskedIp` here as well?
+3752,"@@ -106,9 +106,9 @@ func strOr(s string, ss ...string) string {
+ 	return """"
+ }
+
+-// substitute runs replacer on string elements within a complex data structure
++// Substitute runs replacer on string elements within a complex data structure
+ // (except those contained in private data structure fields).
+-func substitute(v reflect.Value, replacer *strings.Replacer) {
++func Substitute(v reflect.Value, replacer *strings.Replacer) {
+ 	traverseData(v, func(val reflect.Value) dErr {
+ 		switch val.Interface().(type) {
+ 		case string:",Why does substitute need to be public? Are we allowing/encouraging variable usage when using Daisy as a library?,Why the rename?
+3753,"@@ -335,6 +335,11 @@ class WebEngineCaret(browsertab.AbstractCaret):
+         """"""
+         if js_elem is None:
+             return
++        if js_elem == ""focused"":
++            # we had a focused element, not a selected one. Just send <enter>
++            self._tab.key_press(Qt.Key_Enter)
++            return
++
+         assert isinstance(js_elem, dict), js_elem
+         elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)
+         if tab:","We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?",Shouldn't we al
+3754,"@@ -146,7 +146,7 @@ func New(
+
+ 	dynamicCollection := dynamicconfig.NewCollection(params.DynamicConfig, logger)
+
+-	dispatcher := params.RPCFactory.CreateDispatcher()
++	dispatcher := params.RPCFactory.CreateTChannelDispatcher()
+ 	membershipMonitor, err := params.MembershipFactory.Create(dispatcher)
+ 	if err != nil {
+ 		return nil, err",This file looks like anti pattern `ServiceLocator` and lucky it's not used anywhere. Can I remove it? (in separate PR).,Is this really
+3755,"@@ -466,6 +466,10 @@ public class DatasetUtil {
+      * size for tabular files.
+      */
+     public static String getDownloadSize(DatasetVersion dsv, boolean original) {
++        return FileSizeChecker.bytesToHumanReadable(getDownloadSizeNumeric(dsv, original));
++    }
++
++    public static Long getDownloadSizeNumeric(DatasetVersion dsv, boolean original) {
+         long bytes = 0l;
+         for (FileMetadata fileMetadata : dsv.getFileMetadatas()) {
+             DataFile dataFile = fileMetadata.getDataFile();","we can just have this method call the next, passing in the file metadatas (deduplication of logic)",Could you pleas
+3756,"@@ -480,6 +480,17 @@ class TabBar(QTabBar):
+             new_idx = super().insertTab(idx, icon, '')
+         self.set_page_title(new_idx, text)
+
++    def wheelEvent(self, event):
++        """"""Override wheelEvent to make the action configurable.""""""
++        if config.get('tabs', 'mousewheel-tab-switching'):
++            super().wheelEvent(event)
++        else:
++            tabbed_browser = objreg.get('tabbed-browser', scope='window',
++                                        window=self._win_id)
++            focused_tab = tabbed_browser.currentWidget()
++            if focused_tab is not None:
++                focused_tab.wheelEvent(event)
++
+
+ class TabBarStyle(QCommonStyle):
+ ","What happens here if you send the `wheelEvent` directly to the `tabbed_browser` and let it take care of propagating it to its children (i.e. the focused tab)? If that works, I guess that'd be cleaner.","Can you add a docstring here, please?"
+3757,"@@ -21,6 +21,10 @@ from .compat import (PANDAS_INSTALLED, DataFrame, Series, is_dtype_sparse,
+ from .libpath import find_lib_path
+
+
++def _log_callback(msg):
++    """"""Redirect logs from native library into Python console""""""
++    print(""{0:s}"".format(decode_string(msg)), end='')
++
+ def _load_lib():
+     """"""Load LightGBM library.""""""
+     lib_path = find_lib_path()",it seems python 2 don't support `end=''`. @StrikerRUS @henry0312 any better solution? or we drop the support of python 2?,"@tgamblin Should this be `print(""{}:{"
+3758,"@@ -4135,6 +4135,12 @@ bool PreCallValidateCreateImageView(layer_data *device_data, const VkImageViewCr
+             }
+         }
+     }
++	else
++	{
++		skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
++                                HandleToUint64(create_info->image), ""VUID-VkImageViewCreateInfo-image-parameter"",
++                                ""vkCreateImageView() image handle is VK_NULL_HANDLE. Image is either not created or it is destroyed at this point."");
++	}
+     return skip;
+ }
+ ",This test already exists in the object_tracker layer.,Why not just pass `create_info->image
+3759,"@@ -64,7 +64,8 @@ public class EthGetCode extends AbstractBlockParameterOrBlockHashMethod {
+   @Override
+   protected String resultByBlockHash(final JsonRpcRequestContext request, final Hash blockHash) {
+     final Address address = request.getRequiredParameter(0, Address.class);
+-    if (GoQuorumOptions.goQuorumCompatibilityMode && privacyParameters.isPresent()) {
++    final boolean isGoQuorumCompatibilityMode = GoQuorumOptions.goQuorumCompatibilityMode;
++    if (isGoQuorumCompatibilityMode && privacyParameters.isPresent()) {
+       // get from private state if we can
+       final Optional<BlockHeader> blockHeader =
+           blockchainQueries.get().getBlockHeaderByHash(blockHash);","Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?",Nitpick: `isGoQuorumCompatibilityMode
+3760,"@@ -122,6 +122,10 @@ class FastAppend extends SnapshotProducer<AppendFiles> implements AppendFiles {
+   public List<ManifestFile> apply(TableMetadata base) {
+     List<ManifestFile> newManifests = Lists.newArrayList();
+
++    if (base.currentSnapshot() != null) {
++      newManifests.addAll(base.currentSnapshot().deleteManifests());
++    }
++
+     try {
+       ManifestFile manifest = writeManifest();
+       if (manifest != null) {",The addition of delete files in `newManifests` far above the addition of data files threw me a bit. Is it intentional to ensure the delete files are at the front of the list?,this should be: `base.currentSnapshot().deleteManifests()`
+3761,"@@ -68,7 +68,7 @@ module Bolt
+         # though, since that will resolve any nested references and we want to
+         # leave it to the group to do that lazily.
+         groups = @plugins.resolve_top_level_references(groups)
+-
++        raise ValidationError.new(""Groups must be an Array"", nil) unless groups.is_a?(Array)
+         @groups = Array(groups).map { |g| Group.new(g, plugins) }
+       end
+ ",Interesting. The call to `Array(groups)` below this would seem to indicate this doesn't _have_ to be an array. I think the problem is actually that passing a hash to `Array()` actually converts the hash to an array of key/value pairs rather than wrapping it in an array. So maybe `Array(groups)` should be `groups = [groups] unless groups.is_a?(Array)`.,Line is too long. [92/80]
+3762,"@@ -140,4 +140,10 @@ public class TableProperties {
+
+   public static final String GC_ENABLED = ""gc.enabled"";
+   public static final boolean GC_ENABLED_DEFAULT = true;
++
++  public static final String MAX_SNAPSHOT_AGE_MS = ""history.expire.max-snapshot-age-ms"";
++  public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days
++
++  public static final String RETAIN_MIN_NUM_SNAPSHOTS = ""history.expire.retain-min-num-snapshots"";
++  public static final int RETAIN_MIN_NUM_SNAPSHOTS_DEFAULT = 1;
+ }",This is not a particularly good default but we need it to keep the old behavior.,Suggest rename to `history.expire.max-snapshot-age-secs`
+3763,"@@ -117,13 +117,6 @@ func TestPaymentBrokerRedeemWithCondition(t *testing.T) {
+ 	blockHeightParam := types.NewBlockHeight(43)
+ 	redeemerParams := []interface{}{blockHeightParam}
+
+-	sys := setup(t)
+-	require.NoError(t, sys.st.SetActor(context.TODO(), toAddress, actor.NewActor(pbTestActorCid, types.NewZeroAttoFIL())))
+-
+-	callRedeem := func(condition *types.Predicate, params []interface{}) (*consensus.ApplicationResult, error) {
+-		return sys.applySignatureMessage(sys.target, 100, types.NewBlockHeight(0), 0, ""redeem"", 0, condition, params...)
+-	}
+-
+ 	// All the following tests attempt to call PBTestActor.ParamsNotZero with a condition.
+ 	// PBTestActor.ParamsNotZero takes 3 parameter: an Address, a uint64 sector id, and a BlockHeight
+ 	// If any of these are zero values the method throws an error indicating the condition is false.",We have other tests to assert all properties of a condition are valid. It's enough to assert the condition is not nil here.,Please remove `callRedeem` variable.
+3764,"@@ -30,7 +30,7 @@ import (
+
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/config""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/openflow""
+-	opsv1alpha1 ""github.com/vmware-tanzu/antrea/pkg/apis/ops/v1alpha1""
++	opsv1alpha1 ""github.com/vmware-tanzu/antrea/pkg/apis/crd/v1alpha1""
+ 	binding ""github.com/vmware-tanzu/antrea/pkg/ovs/openflow""
+ )
+ ",shouldn't the import be renamed `crdv1alpha1` by convention? It seems that you took care of renaming everywhere else...,@jackfrancis looks like we may need to fix this import too?
+3765,"@@ -86,6 +86,19 @@ const (
+
+ 	// DefaultMinSupportedCNIVersion denotes the minimum version of cni spec required
+ 	DefaultMinSupportedCNIVersion = ""0.3.0""
++
++	// pauseContainerTarball is the path to the pause container tarball
++	pauseContainerTarballPath = ""/images/amazon-ecs-pause.tar""
++)
++
++var (
++	// PauseContainerTag is the tag for the pause container image. The linker's load
++	// flags are used to populate this value from the Makefile
++	PauseContainerTag = """"
++
++	// PauseContainerImageName is the name of the pause container image. The linker's
++	// load flags are used to populate this value from the Makefile
++	PauseContainerImageName = """"
+ )
+
+ // Merge merges two config files, preferring the ones on the left. Any nil or",nit: Can Linux-specific paths be moved to a conditionally-compiled file for Linux?,Should this be named `PauseContainerTag` and `PauseContaine
+3766,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+
+   public abstract void remove(SessionId id);
+
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.,Why not `remove(Id)`?
+3767,"@@ -279,8 +279,10 @@ func (r *runner) waitForJournal(ctx context.Context) error {
+ // unrecognized attributes are ignored. The list ends with a blank
+ // line.
+ func (r *runner) handleList(ctx context.Context, args []string) (err error) {
+-	if len(args) > 0 {
+-		return errors.New(""Lists for non-fetches unsupported for now"")
++	if len(args) == 1 && args[0] == ""for-push"" {
++		r.log.CDebugf(ctx, ""Treating for-push the same as a regular list"")
++	} else if len(args) > 0 {
++		return errors.Errorf(""Bad list request: %v"", args)
+ 	}
+
+ 	repo, err := r.initRepoIfNeeded(ctx)",Git doc seems to suggest `for-push` is a optimization. Do we have a plan/ticket for treating them differently?,s/Treating for-push/Treating for-push/ ?
+3768,"@@ -449,7 +449,8 @@ debug_tls:When 1, print some TLS session secrets when they are computed.
+                    ""mobileip"", ""netbios"", ""netflow"", ""ntp"", ""ppp"", ""pptp"",
+                    ""radius"", ""rip"", ""rtp"", ""skinny"", ""smb"", ""snmp"",
+                    ""tftp"", ""x509"", ""bluetooth"", ""dhcp6"", ""llmnr"",
+-                   ""sctp"", ""vrrp"", ""ipsec"", ""lltd"", ""vxlan"", ""eap""]
++                   ""sctp"", ""vrrp"", ""ipsec"", ""lltd"", ""vxlan"", ""eap"",
++                   ""ltp"", ""bp""]
+     contribs = dict()
+     crypto_valid = isCryptographyValid()
+     crypto_valid_advanced = isCryptographyAdvanced()",This not necessary since you moved the layers to `contrib/`.,"While you're at it, can you fix the indenting here?"
+3769,"@@ -1088,7 +1088,7 @@ module Bolt
+       end
+       define('--log-level LEVEL',
+              ""Set the log level for the console. Available options are"",
+-             ""trace, debug, info, warn, error, fatal, any."") do |level|
++             ""trace, debug, info, warn, error, fatal."") do |level|
+         @options[:log] = { 'console' => { 'level' => level } }
+       end
+       define('--clear-cache',","I think this also needs to be removed from `resources/bolt_bash_completion.sh`, `rakelib/pwsh.rake`, `lib/bolt_spec/plans.rb`, and `lib/bolt/config/options.rb`.","@jjaffeux, I'm not sure if this is a good idea to c"
+3770,"@@ -63,7 +63,7 @@ describe 'PasswordResetsController' do
+       account.update_attribute(:email, 'ThisIsMyAddress@MyDomain.com')
+
+       assert_difference(['ActionMailer::Base.deliveries.size'], 1) do
+-        post :create, password_reset: {email: account.email.downcase}
++        post :create, password_reset: { email: account.email.downcase }
+       end
+       must_respond_with :redirect
+       flash[:success].must_equal I18n.t('password_resets.create.success')",I fixed this today with a direct push to master. My build was failing otherwise.,Space inside { missing.<br>Space inside } missing.
+3771,"@@ -0,0 +1,16 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.autofix.rule;
++
++import net.sourceforge.pmd.autofix.RuleViolationFix;
++import net.sourceforge.pmd.lang.ast.Node;
++
++public class DeleteRuleViolationFix implements RuleViolationFix {
++
++    @Override
++    public void applyFixesToNode(final Node node) {
++        node.remove();
++    }
++}","not sure why this is in a ""rule"" child package from the interface...",Why not just call `node.remove()` in `RuleViolation
+3772,"@@ -19,12 +19,14 @@ class Folder extends BaseItem {
+ 		return {
+ 			id: null,
+ 			title: '',
++			icon: '',
+ 		};
+ 	}
+
+ 	static fieldToLabel(field) {
+ 		const fieldsToLabels = {
+ 			title: _('title'),
++			icon: _('icon'),
+ 			last_note_user_updated_time: _('updated date'),
+ 		};
+ ","Not needed, please remove.",should this be called `icon` or `icon_name`?
+3773,"@@ -66,7 +66,7 @@ static h2o_iovec_t rewrite_location(h2o_mem_pool_t *pool, const char *location,
+         goto NoRewrite;
+     if (loc_parsed.scheme != &H2O_URL_SCHEME_HTTP)
+         goto NoRewrite;
+-    if (!h2o_lcstris(loc_parsed.host.base, loc_parsed.host.len, match->host.base, match->host.len))
++    if (!h2o_url_compare_hosts(loc_parsed.host, match->host, match->host_is_unix_path))
+         goto NoRewrite;
+     if (h2o_url_get_port(&loc_parsed) != h2o_url_get_port(match))
+         goto NoRewrite;","Shouldn't the logic be: * the result is a mismatch if either is a unix path but the other is not * if both are unix paths, then perform case-sensitive comparison * if both are not unix paths, then perform case-insensitive comparison",shouldn't we compare the host_is_unix_path a
+3774,"@@ -11,6 +11,6 @@ import (
+ 	_ ""github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway""
+ 	_ ""github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2""
+ 	_ ""github.com/shurcooL/vfsgen""
+-	_ ""google.golang.org/protobuf/cmd/protoc-gen-go""
+ 	_ ""google.golang.org/grpc/cmd/protoc-gen-go-grpc""
++	_ ""google.golang.org/protobuf/cmd/protoc-gen-go""
+ )",This is just rearranging it alphabetically,did you mean to change this?
+3775,"@@ -798,6 +798,7 @@ def test_chromium_version_unpatched(qapp):
+     assert version._chromium_version() not in ['', 'unknown', 'unavailable']
+
+
++# pylint: disable=too-many-locals
+ @pytest.mark.parametrize(['git_commit', 'frozen', 'style', 'with_webkit',
+                           'known_distribution'], [
+     (True, False, True, True, True),  # normal",I think this disables it for the rest of the file - you should be able to use it inside of the function instead.,"I'm fine with this, but I'm curious why the "
+3776,"@@ -61,9 +61,9 @@ final class MediaExtension extends AbstractExtension
+     }
+
+     /**
+-     * @param MediaInterface $media
+-     * @param string         $format
+-     * @param array          $options
++     * @param MediaInterface|int|string $media
++     * @param string                    $format
++     * @param array                     $options
+      *
+      * @return string
+      */","this could receive the MediaInterface directly or an identifier, it is correct to type it with int|string? or just use mixed?",should be `string`
+3777,"@@ -89,4 +89,15 @@ final class MultiLeafFieldComparator implements LeafFieldComparator {
+     }
+   }
+
++  @Override
++  public Object leafValue(int docID) throws IOException {
++    Object[] valuesArray = new Object[comparators.length];
++
++    for (int i = 0; i < comparators.length; i++) {
++      valuesArray[i] = comparators[i].leafValue(docID);
++    }
++
++    return valuesArray;
++  }
++
+ }",Why not return `Object[]`?,leafValue(int) can
+3778,"@@ -46,12 +46,14 @@ public class GenericManifestFile
+   private String manifestPath = null;
+   private Long length = null;
+   private int specId = -1;
++  private long sequenceNumber = 0;
++  private long minSequenceNumber = 0;
+   private Long snapshotId = null;
+   private Integer addedFilesCount = null;
+-  private Long addedRowsCount = null;
+   private Integer existingFilesCount = null;
+-  private Long existingRowsCount = null;
+   private Integer deletedFilesCount = null;
++  private Long addedRowsCount = null;
++  private Long existingRowsCount = null;
+   private Long deletedRowsCount = null;
+   private List<PartitionFieldSummary> partitions = null;
+ ","Looks like we are trying to match the new ordering of fields in `ManifestFile`. Earlier, we co-located `...FilesCount` with `...RowsCount` to match the ordering of methods in `ManifestFile` and args in constructors. Is this change intentional?",Shouldn't this be
+3779,"@@ -933,11 +933,13 @@ void Monster::onThinkDefense(uint32_t interval)
+ 			Monster* summon = Monster::createMonster(summonBlock.name);
+ 			if (summon) {
+ 				const Position& summonPos = getPosition();
+-
+-				addSummon(summon);
+-
++				summon->setDropLoot(false);
++				summon->setLossSkill(false);
++				summon->setMaster(this);
+ 				if (!g_game.placeCreature(summon, summonPos, false, summonBlock.force)) {
+-					removeSummon(summon);
++					summon->setDropLoot(false);
++					summon->setLossSkill(true);
++					summon->setMaster(nullptr);
+ 				} else {
+ 					g_game.addMagicEffect(getPosition(), CONST_ME_MAGIC_BLUE);
+ 					g_game.addMagicEffect(summon->getPosition(), CONST_ME_TELEPORT);",You're already setting drop loot to false just above.,why do you use nul
+3780,"@@ -20,6 +20,7 @@ type Management struct {
+
+ 	listenerShutdownStarted chan bool
+ 	listenerShutdownWaiter  sync.WaitGroup
++	once                    sync.Once
+ }
+
+ type ManagementMiddleware interface {",`once` is very generic and doesn't specify it's purpose - `closeOnce`?,Why not use `sync.Once` directly?
+3781,"@@ -79,7 +79,7 @@ public class HiveTableBaseTest extends HiveMetastoreTest {
+     return getTableLocationPath(tableName).toString();
+   }
+
+-  private static String metadataLocation(String tableName) {
++  protected static String metadataLocation(String tableName) {
+     return Paths.get(getTableBasePath(tableName), ""metadata"").toString();
+   }
+ ",Why did this need to change from `private`? Oh for the test below. And this is only a test class too.  ,this can be inlined with `Paths.g
+3782,"@@ -0,0 +1,7 @@
++require 'test_helper'
++
++class NotificationAcknowledgementTest < ActiveSupport::TestCase
++  # test ""the truth"" do
++  #   assert true
++  # end
++end",Should test the `has?` method here,Missing empty line at the end of
+3783,"@@ -78,7 +78,18 @@ final class SavedSearchesTest extends \VuFindTest\Integration\MinkTestCase
+     public function testSaveSearch()
+     {
+         $page = $this->performSearch('test');
+-        $this->clickCss($page, '.fa.fa-save');
++        $links = $page->findAll('css', '.searchtools a');
++        $saveLink = null;
++        foreach ($links as $link) {
++            if ($this->checkVisibility($link)
++                && str_contains($link->getHtml(), 'Save Search')
++            ) {
++                $saveLink = $link;
++                break;
++            }
++        }
++        $this->assertNotNull($link);
++        $link->click();
+         $this->snooze();
+         $this->clickCss($page, '.createAccountLink');
+         $this->snooze();","I think you want to be asserting/clicking $saveLink, not $link.",Shouldn't we check that the link
+3784,"@@ -95,6 +95,7 @@ def sensor(
+ def asset_sensor(
+     asset_key: AssetKey,
+     pipeline_name: Optional[str] = None,
++    target_name: Optional[str] = None,
+     name: Optional[str] = None,
+     solid_selection: Optional[List[str]] = None,
+     mode: Optional[str] = None,","We don't have `target_name` on `@sensor` - why introduce it for `@asset_sensor`? If we do want to introduce it everywhere, can we just call it `job_name` to avoid introducing a new term?","`target_name` is not a target name but a pipeline name + target name, right? What about `target_asset_name`?"
+3785,"@@ -0,0 +1,9 @@
++using System.Collections.Generic;
++
++namespace Microsoft.DotNet.Build.Tasks.Feed
++{
++    public class SleetSettings
++    {
++        public List<SleetSource> Sources { get; set; }
++    }
++}",Missing copyright header (+other new files).,Would it make sense to make this a `IEnumerable<SleetSource>` and just call it `Sources`?
+3786,"@@ -104,12 +104,7 @@ class TypeToSparkType extends TypeUtil.SchemaVisitor<DataType> {
+         throw new UnsupportedOperationException(
+             ""Spark does not support time fields"");
+       case TIMESTAMP:
+-        Types.TimestampType timestamp = (Types.TimestampType) primitive;
+-        if (timestamp.shouldAdjustToUTC()) {
+-          return TimestampType$.MODULE$;
+-        }
+-        throw new UnsupportedOperationException(
+-            ""Spark does not support timestamp without time zone fields"");
++        return TimestampType$.MODULE$;
+       case STRING:
+         return StringType$.MODULE$;
+       case UUID:","Could we do the flag check here as well to check whether or not we have enabled the ""Handle without timezone"" flag here as well? We may be using this not on the read path (like in the migrate/snapshot code) and it would be good to catch it here as well and make sure users know what is happening.",Should we still throw an exception here if `shouldAdjustToUTC` is true?
+3787,"@@ -2,7 +2,7 @@ import os
+ from typing import Dict, List
+
+ from dagster import SensorDefinition
+-from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext
++from dagster.core.definitions.pipeline_definition_definition_sensor import PipelineFailureSensorContext
+ from dagster_slack import make_slack_on_pipeline_failure_sensor
+ from hacker_news_assets.utils.slack_message import build_slack_message_blocks
+ ",why is the file named `pipeline_definition_definition_sensor`?,Would it make sense to rename this file as well?
+3788,"@@ -6,6 +6,10 @@ _ts = None
+
+ def init_timescale_connection(logger, conf):
+     global _ts
++
++    if not conf[""SQLALCHEMY_TIMESCALE_URI""]:
++        return None
++
+     while True:
+         try:
+             _ts = TimescaleListenStore(conf, logger)","None not needed, can just be `return`. not important for this release","This check should be moved to the very beginning of the function, before the call to ` TimescaleListenStore`"
+3789,"@@ -104,7 +104,12 @@ const topPageTemplate = `
+     <div class=""g-recaptcha"" data-sitekey=""{{.RecaptchaSiteKey}}"">
+     </div>
+     <div>
+-      <input id=""target"" placeholder=""target address"">
++      The dispensed Algos have no monetary value and should only be used to test applications.
++      <p>This service is gracefully provided to enable development on the Algorand blockchain test networks.
++      <p>Please do not abuse it by requesting millions of Algos.
++    </div>
++    <div>
++      <input id=""target"" placeholder=""target address"" size=""80"">
+       <button id=""dispense"">Dispense</button>
+     </div>
+     <div>",I think it's missing closing `</p>` tags in line 108 and 109 unless they don't matter...,We should add an aria-label to the label and maybe say that this service is subject to changes.
+3790,"@@ -579,10 +579,12 @@ public abstract class ProcessEngineConfigurationImpl extends ProcessEngineConfig
+   protected ScriptingEnvironment scriptingEnvironment;
+   protected List<ScriptEnvResolver> scriptEnvResolvers;
+   protected ScriptFactory scriptFactory;
++  protected String scriptEngineNameJavaScript;
+   protected boolean autoStoreScriptVariables = false;
+   protected boolean enableScriptCompilation = true;
+   protected boolean enableScriptEngineCaching = true;
+   protected boolean enableFetchScriptEngineFromProcessApplication = true;
++  protected boolean enableScriptEngineLoadExternalResources = false;
+
+   /**
+    * When set to false, the following behavior changes:",So it seems that loading a script file from the classpath needs to be enabled explicitly now since this is `false` by default. Is it possible to enable this via the YAML config file in a Camunda Platform Run distribution?,I don't think this should be the default. It should be true by default.
+3791,"@@ -5,8 +5,7 @@
+ const config = require('@purest/providers')
+ const dropbox = require('./dropbox')
+ const drive = require('./drive')
+-const instagram = require('./instagram')
+-const instagramGraph = require('./instagram/graph')
++const instagram = require('./instagram/graph')
+ const facebook = require('./facebook')
+ const onedrive = require('./onedrive')
+ const zoom = require('./zoom')",can we delete any code in the provider implementation? i imagine the entire thing is unused now?,why did you remove `instagramGraph`?
+3792,"@@ -148,6 +148,7 @@ func wrapErrorWithClusterIssuerStatusCondition(client clientset.ClusterIssuerInt
+
+ // WaitForCertificateCondition waits for the status of the named Certificate to contain
+ // a condition whose type and status matches the supplied one.
++// Deprecated: this function is not used anymore
+ func WaitForCertificateCondition(client clientset.CertificateInterface, name string, condition v1.CertificateCondition, timeout time.Duration) (*v1.Certificate, error) {
+ 	var certificate *v1.Certificate = nil
+ 	pollErr := wait.PollImmediate(500*time.Millisecond, timeout,",I suggest we remove all these unused functions. I don't expect any external projects to be importing packages from `cert-manager/test/...`,Why are we not using this anymore?
+3793,"@@ -150,15 +150,10 @@ void DataManWriter::MetadataThread(const std::string &address)
+     while (m_Listening)
+     {
+         auto request = tpm.ReceiveRequest();
+-        if (request == nullptr)
++        if (request && request->size() > 0)
+         {
+-            continue;
+-        }
+-        if (request->size() >= 0)
+-        {
+-            m_AggregatedMetadataMutex.lock();
++            std::lock_guard lck(m_AggregatedMetadataMutex);
+             tpm.SendReply(m_AggregatedMetadata);
+-            m_AggregatedMetadataMutex.unlock();
+         }
+     }
+ }",Looks like the template argument doesn't resolve by default so you need `std::lock_guard<std::mutex> lck`,Shouldn't the condition be `reques
+3794,"@@ -128,12 +128,6 @@ public final class ArrayCreationLevel extends Node implements NodeWithAnnotation
+         return this;
+     }
+
+-    @Override
+-    @Generated(""com.github.javaparser.generator.core.node.GetNodeListsGenerator"")
+-    public List<NodeList<?>> getNodeLists() {
+-        return Arrays.asList(getAnnotations());
+-    }
+-
+     @Generated(""com.github.javaparser.generator.core.node.RemoveMethodGenerator"")
+     public ArrayCreationLevel removeDimension() {
+         return setDimension((Expression) null);",Are we removing this public method? Could it be useful to someone? Maybe we could implement it once in Node using the metamodel,shouldn't this be removed?
+3795,"@@ -47,6 +47,10 @@ class Plan < ActiveRecord::Base
+     self == self.class.popular
+   end
+
++  def includes_exercises?
++    sku != THE_WEEKLY_ITERATION_SKU
++  end
++
+   def subscription_interval
+     stripe_plan.interval
+   end",I think this method is unused now?,This doesn't seem to be used anywh
+3796,"@@ -115,6 +115,11 @@ func run(o *Options) error {
+ 		appliedToGroupStore,
+ 		networkPolicyStore)
+
++	var networkPolicyStatusController *networkpolicy.StatusController
++	if features.DefaultFeatureGate.Enabled(features.AntreaPolicy) {
++		networkPolicyStatusController = networkpolicy.NewStatusController(crdClient, networkPolicyStore, cnpInformer, anpInformer)
++	}
++
+ 	endpointQuerier := networkpolicy.NewEndpointQuerier(networkPolicyController)
+
+ 	controllerQuerier := querier.NewControllerQuerier(networkPolicyController, o.config.APIPort)",I know we discussed this before and decided to reuse the AntreaPolicy gate. But do you think realization status will introduce much overhead or not?,"IfAntreaPolicy is enabled, will networkPolicyStatusController ever be used?"
+3797,"@@ -0,0 +1,11 @@
++package constants
++
++const (
++	RunController = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/cloud/; sudo nohup ./edgecontroller > edgecontroller.log 2>&1 &""
++	RunEdgecore   = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/edge/; sudo nohup ./edge_core > edge_core.log 2>&1 &""
++	RunEdgeSite   = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/edgesite/; sudo nohup ./edgesite > edgesite.log 2>&1 &""
++
++	AppHandler        = ""/api/v1/namespaces/default/pods""
++	NodeHandler       = ""/api/v1/nodes""
++	DeploymentHandler = ""/apis/apps/v1/namespaces/default/deployments""
++)",please add a blank line at the end of this file. Applicable to similar cases below,Is there any way to avoid hardcoding paths like this? Is there any other op
+3798,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression.",Why don't you use `fixUpHost()` here as well?
+3799,"@@ -588,6 +588,10 @@ class JoinQuery extends Query {
+             // use the filterCache to get a DocSet
+             if (toTermsEnum.docFreq() >= minDocFreqTo || resultBits == null) {
+               // use filter cache
++              if (! toSearcher.getFilterCache().isAsync()) {
++                throw new SolrException(SolrException.ErrorCode.INVALID_STATE,
++                    ""Using join queries with synchronous filterCache is not supported! Details can be found in Solr Reference Guide under 'query-settings-in-solrconfig'."");
++              }
+               DocSet toTermSet = toSearcher.getDocSet(toDeState);
+               resultListDocs += toTermSet.size();
+               if (resultBits != null) {",filterCache can be null,I think it would be better to add a `SolrException.STATUS_NOT_SUPPORTED` co
+3800,"@@ -10,6 +10,7 @@ import (
+ 	""bytes""
+ 	""context""
+ 	""encoding/hex""
++	""github.com/iotexproject/iotex-core/db""
+ 	""sync""
+ 	""time""
+ ",File is not `goimports`-ed (from `goimports`),I think this import should go at the top of the file.
+3801,"@@ -375,6 +375,8 @@ const char *get_parameter(char *cmd, SERVER_CONN *server_conn) {
+ const char *set_parameter(char *cmd, SERVER_CONN *server_conn, CLIENT_CONN *client_conn) {
+     const char *param_name = strstr(cmd, SET_PARAM_CMD) + SET_PARAM_CMD_LEN;
+     const char *param_value;
++    if (!param_name)
++	return SET_PARAM_CMD_FAIL_RSP;
+     if (strstr(param_name, SERVER_LOOPBACK_MODE_PARAM) == param_name) {
+         param_value = param_name + SERVER_LOOPBACK_MODE_PARAM_LEN;
+         if (strnlen(param_value, 1) == 1) {","If strstr returns NULL, the check on 378 won't fire, because param_name will be at least SET_PARAM_CMD_LEN.",Can we change this to `return 0;`?
+3802,"@@ -47,13 +47,12 @@ services::Status buildProgram(ClKernelFactoryIface & kernelFactory, const TypeId
+     return status;
+ }
+
+-services::Status sum_singlepass(ExecutionContextIface & context, ClKernelFactoryIface & kernelFactory, Layout vectorsLayout,
+-                                const UniversalBuffer & vectors, uint32_t nVectors, uint32_t vectorSize, uint32_t workItemsPerGroup,
+-                                SumReducer::Result & result)
++services::Status sum_singlepass(ExecutionContextIface & context, ClKernelFactoryIface & kernelFactory, const UniversalBuffer & vectors,
++                                uint32_t nVectors, uint32_t vectorSize, SumReducer::Result & result)
+ {
+     services::Status status;
+
+-    auto sum_kernel = kernelFactory.getKernel(""sum_singlepass"", status);
++    auto sum_kernel = kernelFactory.getKernel(""sum_singlesubgroup"", status);
+     DAAL_CHECK_STATUS_VAR(status);
+
+     // no need to check overflow for nVectors * vectorSize due to we already have buffer vectors of such size","Does this change affect the performance of other algorithms, except KMeans?",This doesn't need a temporary variable and doesn't ne
+3803,"@@ -142,13 +142,13 @@ func TestListenerAddrEqual(t *testing.T) {
+ 		addr   string
+ 		expect bool
+ 	}{
+-		{ln1, "":1234"", false},
+-		{ln1, ""0.0.0.0:1234"", false},
++		{ln1, "":"" + ln2port, false},
++		{ln1, ""0.0.0.0:"" + ln2port, false},
+ 		{ln1, ""0.0.0.0"", false},
+ 		{ln1, "":"" + ln1port, true},
+ 		{ln1, ""0.0.0.0:"" + ln1port, true},
+ 		{ln2, "":"" + ln2port, false},
+-		{ln2, ""127.0.0.1:1234"", false},
++		{ln2, ""127.0.0.1:"" + ln1port, false},
+ 		{ln2, ""127.0.0.1"", false},
+ 		{ln2, ""127.0.0.1:"" + ln2port, true},
+ 	} {",What do these changes have to do with the request ID?,This was incorrect. It should start with `127.0.0.1:1
+3804,"@@ -48,11 +48,11 @@
+ #include <cstdio>
+ #include <cstdlib>
+
+-typedef Kokkos::DefaultExecutionSpace Device;
+-typedef Kokkos::HostSpace::execution_space Host;
++using Device = Kokkos::DefaultExecutionSpace;
++using Host   = Kokkos::HostSpace::execution_space;
+
+-typedef Kokkos::TeamPolicy<Device> team_policy;
+-typedef team_policy::member_type team_member;
++using team_policy = Kokkos::TeamPolicy<Device>;
++using team_member = team_policy::member_type;
+
+ static const int TEAM_SIZE = 16;
+ ",I'm kind of surprised this doesn't require `typename`?,Why did you remove the `typedef` statements? Are they not needed anymore?
+3805,"@@ -17,6 +17,7 @@
+ package agreement
+
+ import (
++	""github.com/algorand/go-algorand/logging""
+ 	""time""
+
+ 	""github.com/algorand/go-algorand/config""",nit: move this one down.,We don't need a new line here.
+3806,"@@ -137,8 +137,14 @@ class Bars(Chart):
+
+ class BoxWhisker(Chart):
+     """"""
+-    BoxWhisker represent data as a distributions highlighting
+-    the median, mean and various percentiles.
++    BoxWhisker allows representing the distribution of data grouped
++    into one or more groups by summarizing the data using quartiles.
++    The boxes of a BoxWhisker element represent the first, second and
++    third quartiles. The whiskers follow the Tukey boxplot definition
++    representing the lowest datum still within 1.5 IQR of the lower
++    quartile, and the highest datum still within 1.5 IQR of the upper
++    quartile. Any points falling outside this range are shown as
++    distinct outlier points.
+     """"""
+
+     group = param.String(default='BoxWhisker', constant=True)",maybe 'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just *a* definition for boxplots...,I think the changes in this file are not needed anymore?
+3807,"@@ -55,9 +55,11 @@ var (
+ 	// NOTE: The $Format strings are replaced during 'git archive' thanks to the
+ 	// companion .gitattributes file containing 'export-subst' in this same
+ 	// directory.  See also https://git-scm.com/docs/gitattributes
+-	gitVersion   = ""v0.0.0-master+$Format:%h$""
++	gitVersion   = Default
+ 	gitCommit    = ""$Format:%H$"" // sha1 from git, output of $(git rev-parse HEAD)
+ 	gitTreeState = """"            // state of git tree, either ""clean"" or ""dirty""
+
+ 	buildDate = ""1970-01-01T00:00:00Z"" // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ')
+ )
++
++const Default = ""v1.9.0""",I feel we should not fix this.,Why is this hardcoded to 1.9.0?
+3808,"@@ -25,9 +25,9 @@
+ #include <fastdds/rtps/reader/RTPSReader.h>
+ #include <fastdds/rtps/writer/RTPSWriter.h>
+
+-#include <fastdds/rtps/transport/UDPv4Transport.h>
+-#include <fastdds/rtps/transport/UDPv6Transport.h>
+-#include <fastdds/rtps/transport/test_UDPv4Transport.h>
++#include <rtps/transport/UDPv4Transport.h>
++#include <rtps/transport/UDPv6Transport.h>
++#include <rtps/transport/test_UDPv4Transport.h>
+
+ #include <fastrtps/xmlparser/XMLProfileManager.h>
+ ",I think these are not necessary,Why was this changed?
+3809,"@@ -476,7 +476,8 @@ Cross-TU analysis. By default, no CTU analysis is run when
+                               action='store_true',
+                               dest='ctu_reanalyze_on_failure',
+                               default=argparse.SUPPRESS,
+-                              help=""If Cross-TU analysis is enabled and fails ""
++                              help=""DEPRECATED. The flag will be removed. ""
++                                   ""If Cross-TU analysis is enabled and fails ""
+                                    ""for some reason, try to re analyze the ""
+                                    ""same translation unit without ""
+                                    ""Cross-TU enabled."")",Please update the user guide too.,It's not really a dep
+3810,"@@ -459,8 +459,9 @@ class Folio extends AbstractAPI implements
+             foreach ($this->getPagedResults(
+                 'locations', '/locations'
+             ) as $location) {
+-                $locationMap[$location->id]
+-                    = $location->discoveryDisplayName ?? $location->name;
++                $name = $location->discoveryDisplayName ?? $location->name;
++                $code = $location->code;
++                $locationMap[$location->id] = [$name, $code];
+             }
+         }
+         $this->putCachedData($cacheKey, $locationMap);","If you use `compact('name', 'code')` here, you'll get an associative array, which might make the rest of the code more readable (instead of using hard-coded 0/1 indexes).",Why did you change th
+3811,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright (c) 2011, salesforce.com, inc.
++ * Copyright (c) 2014, salesforce.com, inc.
+  * All rights reserved.
+  * Redistribution and use of this software in source and binary forms, with or
+  * without modification, are permitted provided that the following conditions",Should it be 2011-14 instead ;-),Why did you change th
+3812,"@@ -51,6 +51,10 @@ func New(cfg *any.Any, logger *zap.Logger, scope tally.Scope) (service.Service,
+ 		return nil, err
+ 	}
+
++	if pgcfg.MaxIdleConnections > 2 {
++		sqlDB.SetMaxIdleConns(int(pgcfg.MaxIdleConnections))
++	}
++
+ 	return &client{logger: logger, scope: scope, sqlDB: sqlDB}, nil
+ }
+ ",I want to write some type of test for this but there are not Getter methods to assert this value. I tried to extract the value via the stats that are exposed without luck.,"If this value is not set by the user, should we default to the default value of `pgcfg.MaxIdleConnections`?"
+3813,"@@ -574,6 +574,15 @@ class ApiClient(object):
+             group_key (str): key of the group to get.
+         """"""
+
++    @abc.abstractmethod
++    def iter_gsuite_group_settings(self, gsuite_id):
++        """"""Iterate Gsuite group settings from GCP API.
++
++        Args:
++            gsuite_id (str): Gsuite id.
++        """"""
++
++
+     @abc.abstractmethod
+     def iter_gsuite_groups(self, gsuite_id):
+         """"""Iterate Gsuite groups from GCP API.","This needs to take the group id, not the gsuite id.","update this docstring to ""Iterate Gsuite group settings from GCP API."""
+3814,"@@ -47,8 +47,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+         }
+
+         private const string EmptyResult = @""{
+-  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0-beta.5"""",
+-  """"version"""": """"1.0.0-beta.5"""",
++  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0"""",
++  """"version"""": """"1.0.0"""",
+   """"runs"""": [
+     {
+       """"tool"""": {",These should use the constants defined in JsonTests.cs,is there any way we can test this?
+3815,"@@ -67,7 +67,7 @@ function DashboardClicksWidget() {
+
+ 	if ( error ) {
+ 		trackEvent( 'plugin_setup', 'search_console_error', error.message );
+-		return getDataErrorComponent( __( 'Search Console', 'google-site-kit' ), error.message );
++		return getDataErrorComponent( 'search-console', error );
+ 	}
+
+ 	if ( ! data || ! data.length ) {","Kind of unrelated to this PR, but let's update this to `getDataErrorComponent( 'search-console', error.message, false, false, false, error )` so that everything is passed as expected.",Do we not have a centralized component for this?
+3816,"@@ -38,6 +38,15 @@ class LoadImageFromFile(object):
+         self.file_client = None
+
+     def __call__(self, results):
++        """"""Call functions to load image and get image meta information.
++
++        Args:
++            results (dict): Result dict from :obj:`dataset`.
++
++        Returns:
++            dict: The dict contains loaded image and meta information.
++        """"""
++
+         if self.file_client is None:
+             self.file_client = mmcv.FileClient(**self.file_client_args)
+ ",:obj:\`dataset\` cannot be correctly rendered,Is there an `obj` annotation for `results`?
+3817,"@@ -28,4 +28,10 @@ module Blacklight::User
+   def existing_bookmark_for(document)
+     bookmarks_for_documents([document]).first
+   end
++
++  ##
++  # @return [String] a user-displayable login/identifier for the user account
++  def to_s
++    email
++  end
+ end","I think `email` is something we get from devise, and I think the goal of putting it in the generator was not to tie others to that particular implementation?","I don't think we need this for now, but we "
+3818,"@@ -108,15 +108,16 @@ func NewBatchSpanProcessor(e export.SpanBatcher, opts ...BatchSpanProcessorOptio
+ 	bsp.stopWait.Add(1)
+ 	go func(ctx context.Context) {
+ 		defer ticker.Stop()
++		batch := make([]*export.SpanData, 0, bsp.o.MaxExportBatchSize)
+ 		for {
+ 			select {
+ 			case <-bsp.stopCh:
+-				bsp.processQueue()
++				bsp.processQueue(&batch)
+ 				close(bsp.queue)
+ 				bsp.stopWait.Done()
+ 				return
+ 			case <-ticker.C:
+-				bsp.processQueue()
++				bsp.processQueue(&batch)
+ 			}
+ 		}
+ 	}(context.Background())","If the span producers pushing to the queue do so faster than the this can drain, it will cause this to hang. I'm guessing we can update the `enqueue` method to check if the `stopCh` is closed and not send any more spans while this flushes what has already been pushed.",What's the reason for making this a pointer
+3819,"@@ -106,9 +106,9 @@ abstract class Gallery implements GalleryInterface
+         return $this->defaultFormat;
+     }
+
+-    final public function setGalleryItems(Collection $galleryItems): void
++    final public function setGalleryItems(iterable $galleryItems): void
+     {
+-        $this->galleryItems = new ArrayCollection();
++        $this->galleryItems->clear();
+
+         foreach ($galleryItems as $galleryItem) {
+             $this->addGalleryItem($galleryItem);","Not sure about that, an array is iterable right? But if I pass array, that clear method wont work","IMO, we should use `Collection` here instea"
+3820,"@@ -6,9 +6,14 @@ import (
+ 	""crypto/x509""
+ 	""crypto/x509/pkix""
+ 	""encoding/pem""
++	""fmt""
++	""io/ioutil""
++	""path/filepath""
++	""sync""
+ 	""testing""
+
+-	""github.com/spiffe/sri/pkg/server/ca""
++	""github.com/spiffe/go-spiffe""
++	iface ""github.com/spiffe/sri/pkg/common/plugin""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ ","make sure the config changes stuck. are there any invalid config values? maybe write tests around empty `trust_domain`, negative/missing `ttl`, invalid `key_size`, etc...",I would call this `cert` instead of `iface`.
+3821,"@@ -5,7 +5,7 @@ var WebDriver = require('selenium-webdriver');
+
+ module.exports = function(grunt) {
+ 	/**
+-	 * Keep injecting scripts until window.mochaResults is set
++	 * Keep injecting scripts until `window.__mochaResult__` is set
+ 	 */
+ 	function collectTestResults(driver) {
+ 		// inject a script that waits half a second",Why are you changing this?,"I don't think we can do this, but `window.mo"
+3822,"@@ -29,6 +29,10 @@ module Ncr
+     validates :expense_type, inclusion: {in: EXPENSE_TYPES}, presence: true
+     validates :vendor, presence: true
+     validates :building_number, presence: true
++    validates :rwa_number, format: {
++      with: /[a-zA-Z][0-9]{7}/,
++      message: ""one letter followed by 7 numbers""
++    }, allow_blank: true
+     # TODO validates :proposal, presence: true
+
+     def set_defaults","@phirefly Can we look at a list of RWAs, or ask someone to double-check that this format is correct? Otherwise :shipit:",Use `%w` or `%W` for an array of words.
+3823,"@@ -72,6 +72,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy {
+           .format(""iceberg"")
+           .option(SparkWriteOptions.REWRITTEN_FILE_SCAN_TASK_SET_ID, groupID)
+           .option(SparkWriteOptions.TARGET_FILE_SIZE_BYTES, writeMaxFileSize())
++          .option(SparkWriteOptions.DISTRIBUTION_MODE, ""none"")
+           .mode(""append"")
+           .save(table.name());
+ ",Still request a local sort for bin-packing based on the defined table sort order.,do we need a default value here?
+3824,"@@ -151,13 +151,16 @@ def request_model(rank, itr, lmbda, alpha):
+ @click.option(""--days"", type=int, default=7, help=""Request recommendations to be generated on history of given number of days"")
+ @click.option(""--top"", type=int, default=20, help=""Calculate given number of top artist."")
+ @click.option(""--similar"", type=int, default=20, help=""Calculate given number of similar artist."")
+-def request_candidate_sets(days, top, similar):
++@click.option(""--user-id"", ""users"", callback=parse_list, default=[], multiple=True,
++                                    help=""Generate candidate set for given users. Generate for all active users by default."")
++def request_candidate_sets(days, top, similar, users):
+     """""" Send the cluster a request to generate candidate sets.
+     """"""
+     params = {
+         'recommendation_generation_window': days,
+         ""top_artist_limit"": top,
+         ""similar_artist_limit"": similar,
++        ""users"": users
+     }
+     send_request_to_spark_cluster(_prepare_query_message('cf_recording.recommendations.candidate_sets', params=params))
+ ","As with the other PR, user name is better.",I think this option should be called `--user`. I also think it should be called `--user-list`.
+3825,"@@ -125,6 +125,12 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount uint64) er
+ 	if err != nil {
+ 		return err
+ 	}
++
++	balance, err := s.chequebook.AvailableBalance(ctx)
++	if err != nil {
++		return err
++	}
++	s.metrics.AvailableBalance.Set(float64(balance.Int64()))
+ 	s.metrics.TotalSent.Add(float64(amount))
+ 	return nil
+ }",a peer's accounting lock is held during `Pay`. we should avoid adding additional blockchain calls here if possible.,This should be done in `s.chequebook.AvailableBalance`
+3826,"@@ -66,6 +66,12 @@ module.exports = function(realmConstructor) {
+
+         setConstructorOnPrototype(realmConstructor.Sync.User);
+         setConstructorOnPrototype(realmConstructor.Sync.Session);
++    } else {
++        Object.defineProperty(realmConstructor, 'Sync', {
++            get: function () {
++                throw new Error(""Sync is not enabled. Note that the developer edition of the Node.JS SDK for Realm does not include sync on Linux."");
++            }
++        })
+     }
+
+     // TODO: Remove this now useless object.","Maybe wording could be improved. Is this ""not enabled"" or it is ""not available"". Not sure about that.",Do you know if it's the best way to include it on Linux to avoid this weird thing?
+3827,"@@ -120,7 +120,11 @@ func (it *TaskReconciler) Reconcile(ctx context.Context, request reconcile.Reque
+
+ 	// update the status about conditional tasks
+ 	if len(pods) > 0 && (pods[0].Status.Phase == corev1.PodFailed || pods[0].Status.Phase == corev1.PodSucceeded) {
+-		if !conditionalBranchesEvaluated(node) {
++		evaluated, err := it.conditionalBranchesEvaluated(ctx, node)
++		if err != nil {
++			return reconcile.Result{}, err
++		}
++		if !evaluated {
+ 			it.eventRecorder.Event(&node, recorder.TaskPodPodCompleted{PodName: pods[0].Name})
+ 			// task pod is terminated
+ 			updateError := retry.RetryOnConflict(retry.DefaultRetry, func() error {",I looked at the new `conditionalBranchesEvaluated` function and it looks like the part added is a duplicate of the line above?,No need to retry on conflict?
+3828,"@@ -53,6 +53,9 @@ import (
+ //           May be missing, but should be present when data is.
+ //   - refs: The list of references to the block, encoded as a serialized
+ //           blockRefInfo. May be missing.
++//   - f:    Presence of this file indicates the block has been successfully
++//           flushed to the server.  However, the data might still be
++//           in the store.
+ //
+ // Future versions of the disk store might add more files to this
+ // directory; if any code is written to move blocks around, it should","can you put this flag in `blockRefInfo` instead? It would be a shame to add one more file per block, especially since we've run into inode limits. I guess `blockRefInfo` should maybe then be renamed to `blockInfo` or something. But we're stuck with the filename.",The `f` should not be included in this list of messages.
+3829,"@@ -43,5 +43,9 @@ func (c *ConsumerConfigParser) Parse(config json.RawMessage) (ip string, port in
+ 	if err != nil {
+ 		return """", 0, """", errors.Wrap(err, ""parsing consumer address:port failed"")
+ 	}
+-	return cfg.IP, cfg.Port, openvpn.ServiceType, nil
++
++	if cfg.IP == nil {
++		return """", 0, """", nil
++	}
++	return *cfg.IP, cfg.Port, openvpn.ServiceType, nil
+ }",Shouldn't we keep other parameters if only IP is empty? Or maybe return an error if it's a mandatory argument?,Do we need to check if `cfg.IP` is not nil before derefe
+3830,"@@ -118,7 +118,8 @@ class NdIndexableMappingTest(ComparisonTestCase):
+         data = [((0, 0.5), 'a'), ((1, 0.5), 'b')]
+         ndmap = MultiDimensionalMapping(data, kdims=[self.dim1, self.dim2])
+         redimmed = ndmap.redim(intdim='Integer')
+-        self.assertEqual(redimmed.kdims, [Dimension('Integer'), Dimension('floatdim')])
++        self.assertEqual(redimmed.kdims, [Dimension('Integer', type=int),
++                                          Dimension('floatdim', type=float)])
+
+     def test_idxmapping_add_dimension(self):
+         ndmap = MultiDimensionalMapping(self.init_items_1D_list, kdims=[self.dim1])",Was this just wrong before? The names indicated types but type wasn't specified. I guess the tests passed as comparison worked with ``type=None``?,This test is failing because `intdim` is unknown as its
+3831,"@@ -146,7 +146,8 @@ public class OrcMetrics {
+       if (icebergColOpt.isPresent()) {
+         final Types.NestedField icebergCol = icebergColOpt.get();
+         final int fieldId = icebergCol.fieldId();
+-        final MetricsMode metricsMode = effectiveMetricsConfig.columnMode(icebergCol.name());
++        final String colName = schema.findColumnName(icebergCol.fieldId());
++        final MetricsMode metricsMode = effectiveMetricsConfig.columnMode(colName);
+
+         columnSizes.put(fieldId, colStat.getBytesOnDisk());
+ ",icebergCol.name() is the unqualified column name,nit: can be simplified to `columnName(icebergCol.fieldId
+3832,"@@ -45,7 +45,7 @@ class MetricAlarm(object):
+     def __init__(self, connection=None, name=None, metric=None,
+                  namespace=None, statistic=None, comparison=None, threshold=None,
+                  period=None, evaluation_periods=None, unit=None, description='',
+-                 dimensions=[]):
++                 dimensions=[], alarm_actions=[], insufficient_data_actions=[], ok_actions=[]):
+         """"""
+         Creates a new Alarm.
+ ","It's generally a bad idea to use mutable types like lists as default values for parameters. Lots of strange, difficult to debug side effects can occur. I see that there was already one example of this prior to this commit which probably explains why it seemed innocuous to add more but I'm going to rework this before committing to master.",E303 too many blank lines (2)
+3833,"@@ -10,6 +10,7 @@ module.exports = {
+     'prettier',
+     'prettier/@typescript-eslint',
+     'plugin:prettier/recommended',
++    'eslint-config-prettier'
+   ],
+   globals: {
+     Atomics: 'readonly',","We run prettier as an eslint plugin, so this harmful",Why are you keeping `eslint-c
+3834,"@@ -39,7 +39,7 @@ using namespace eprosima::fastrtps::types;
+ HelloWorldPublisher::HelloWorldPublisher()
+     : mp_participant(nullptr)
+     , mp_publisher(nullptr)
+-    , m_DynType(nullptr)
++    , m_DynType(DynamicType_ptr(nullptr))
+ {
+ }
+ ",Check if the TypeDescriptor and MemberDescriptor includes are necessary,Is there a specific reason fo
+3835,"@@ -4,10 +4,11 @@ import (
+ 	gocontext ""context""
+ 	""encoding/json""
+ 	""fmt""
+-	""k8s.io/apimachinery/pkg/api/errors""
+ 	""os""
+ 	""syscall""
+
++	""k8s.io/apimachinery/pkg/api/errors""
++
+ 	corev1 ""k8s.io/api/core/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/types""",delete the empty line here.,nit: remove empty line
+3836,"@@ -302,6 +302,16 @@ describe Subscription do
+     end
+   end
+
++  describe ""#reactivate"" do
++    it ""unsets scheduled_for_deactivation_on"" do
++      subscription = create(:subscription, scheduled_for_deactivation_on: 1.day.from_now)
++      subscription.reactivate
++      subscription.reload
++
++      expect(subscription.scheduled_for_deactivation_on).to be_nil
++    end
++  end
++
+   def setup_cutomer
+     stripe_customer = double(
+       ""StripeCustomer"",",Line is too long. [89/80],I usually prefer to use `expect(subscription.scheduled_for_deactivation_on).to eq(nil)`
+3837,"@@ -200,7 +200,7 @@ public class JsonHttpRemoteConfig {
+     }
+   }
+
+-  private UrlMapper getUrlMapper(String method) {
++  protected UrlMapper getUrlMapper(String method) {
+     if (""DELETE"".equals(method)) {
+       return deleteMapper;
+     } else if (""GET"".equals(method)) {","You don't need to expose this method to do what you want. There are already public addNewGetMapping, addNewPostMapping, and addNewDeleteMapping methods.",Why was `private` changed to `protected`?
+3838,"@@ -782,7 +782,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+         }
+
+         [Fact]
+-        public async Task HeadResponseCanContainContentLengthHeaderButBodyNotWritten()
++        public async Task HeadResponseBodyNotWritten()
+         {
+             using (var server = new TestServer(async httpContext =>
+             {",This test passes in `dev`. Why wouldn't this work?,Did you mean to delete this test?
+3839,"@@ -1,6 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX-License-Identifier: Apache-2.0
+
++""""""
++Purpose
++
++Shows how to use the AWS SDK for Python (Boto3) with PyTest and the AWS Device Farm
++browser testing feature.
++""""""
++
++# snippet-start:[python.example_code.device-farm.Scenario_BrowserTesting]
+ import datetime
+ import os
+ import subprocess",ARN -> Amazon Resource Number (ARN),I think you missed to remove this.
+3840,"@@ -153,10 +153,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+
+             var hostBuilder = new WebHostBuilder()
+                .UseKestrel()
+-               .ConfigureServices(services =>
+-               {
+-                   services.AddSingleton<ILoggerFactory>(new KestrelTestLoggerFactory(testLogger));
+-               })
++               .UseLoggerFactory(_ => new KestrelTestLoggerFactory(testLogger))
+                .Configure(ConfigureEchoAddress);
+
+             using (var host = hostBuilder.Build())",Why not use the overload that takes an instance?,I don't think we should use the `_ => new KestrelTestLoggerFactory(testLogger);` helper here.
+3841,"@@ -7,16 +7,13 @@
+ package account
+
+ import (
+-	""context""
+ 	""fmt""
++	""strings""
+
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""
+-	grpc ""google.golang.org/grpc""
+
+-	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/config""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+-	pb ""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ )
+
+ // TODO: use wallet config later",`Blockchian` is a misspelling of `Blockchain` (from `misspell`),please add gitea copyright header
+3842,"@@ -44,7 +44,7 @@ type NvidiaGPUManager struct {
+ 	DriverVersion string                `json:""DriverVersion""`
+ 	GPUIDs        []string              `json:""GPUIDs""`
+ 	GPUDevices    []*ecs.PlatformDevice `json:""-""`
+-	lock          sync.RWMutex          `json:""-""`
++	lock          sync.RWMutex
+ }
+
+ const (",`agent/gpu/nvidia_gpu_manager_unix.go:47: struct field lock has json tag but is not exported`,Why did you remove the json tag?
+3843,"@@ -11,6 +11,9 @@ from localstack.utils.aws.aws_models import LambdaFunction
+ from localstack.constants import LAMBDA_TEST_ROLE
+
+
++TEST_ARN = 'arn:aws:sqs:eu-west-1:000000000000:testq'
++
++
+ class TestLambdaAPI(unittest.TestCase):
+     CODE_SIZE = 50
+     CODE_SHA_256 = '/u60ZpAA9bzZPVwb8d4390i5oqP1YAObUwV03CZvsWA='",nit: better rename to `TEST_QUEUE_ARN` or `TEST_EVENT_SOURCE_ARN`,Nit: We should probably import this at the top of the file.
+3844,"@@ -1097,9 +1097,9 @@ func (c *Operator) sync(key string) error {
+ 		return err
+ 	}
+
+-	// If no service monitor selectors are configured, the user wants to
+-	// manage configuration themselves.
+-	if p.Spec.ServiceMonitorSelector != nil {
++	// If no service monitor selectors or additional scrape configs are configured,
++	// the user wants to manage configuration themselves.
++	if p.Spec.ServiceMonitorSelector != nil || p.Spec.AdditionalScrapeConfigs != nil {
+ 		// We just always regenerate the configuration to be safe.
+ 		if err := c.createOrUpdateConfigurationSecret(p, ruleConfigMapNames); err != nil {
+ 			return errors.Wrap(err, ""creating config failed"")",Would this mean that podMonitorSelectors suffer from the same issue if they are the only configuration set?,shouldn't this be `||` instead of `||`?
+3845,"@@ -110,6 +110,17 @@ func (c *fakeClient) ReportPipedMeta(ctx context.Context, req *pipedservice.Repo
+ 	return &pipedservice.ReportPipedMetaResponse{}, nil
+ }
+
++// GetEnvironment finds and returns the environment for the specified ID.
++func (c *fakeClient) GetEnvironment(ctx context.Context, req *pipedservice.GetEnvironmentRequest, opts ...grpc.CallOption) (*pipedservice.GetEnvironmentResponse, error) {
++	c.logger.Info(""fake client received GetEnvironment rpc"", zap.Any(""request"", req))
++	return &pipedservice.GetEnvironmentResponse{
++		Environment: &model.Environment{
++			Id:   ""dev"",
++			Name: ""dev"",
++		},
++	}, nil
++}
++
+ // ListApplications returns a list of registered applications
+ // that should be managed by the requested piped.
+ // Disabled applications should not be included in the response.",`ctx` is unused in GetEnvironment,Maybe mention that it finds a virtual e
+3846,"@@ -89,6 +89,11 @@ namespace pwiz.Skyline.FileUI
+             }
+         }
+
++        public void OKDialog()
++        {
++            DialogResult = DialogResult.OK;
++        }
++
+         private void cbShowText_CheckedChanged(object sender, System.EventArgs e)
+         {
+             LineText.Visible = cbShowText.Checked;",We usually use OkDialog(),So what does 'OKDialog' mean and why do
+3847,"@@ -970,6 +970,12 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       description = ""Enable flexible (onchain) privacy groups (default: ${DEFAULT-VALUE})"")
+   private final Boolean isFlexiblePrivacyGroupsEnabled = false;
+
++  @Option(
++      names = {""--privacy-unrestricted-enabled""},
++      description =
++          ""Enable unrestricted (stores payload onchain) privacy (default: ${DEFAULT-VALUE})"")
++  private final Boolean isUnrestrictedPrivacyEnabled = false;
++
+   @Option(
+       names = {""--target-gas-limit""},
+       description =","could we please change that to something that indicates that this feature is not ""production"" ready!",`privacy-unrestricted-enabled` sounds a
+3848,"@@ -0,0 +1,5 @@
++_base_ = './mask_rcnn_swim-t-p4-w7_fpn_fp16_ms-crop-3x_coco.py'
++model = dict(
++    pretrained=\
++    'https://download.openmmlab.com/mmclassification/v0/swin-transformer/swin_small_224_b16x64_300e_imagenet_20210615_110219-7f9d988b.pth',  # noqa
++    backbone=dict(depths=[2, 2, 18, 2]))",swim -> swin. Other configs and file names also should be modified.,"Could you also add a `backbone=dict(depths=[2, 2, 18, 2])`?"
+3849,"@@ -47,7 +47,7 @@ class BigQueryClient(_base_client.BaseClient):
+         return RateLimiter(FLAGS.max_bigquery_api_calls_per_100_seconds,
+                            self.DEFAULT_QUOTA_TIMESPAN_PER_SECONDS)
+
+-    def get_bigquery_projectids(self):
++    def get_bigquery_projectids(self, key='projects'):
+         """"""Request and page through bigquery projectids.
+
+         Returns: A list of project_ids enabled for bigquery.","nit: arg description for ""key""?",Is the default for `key` going to be `projects`?
+3850,"@@ -244,6 +244,15 @@ func (tlf *TLF) Setattr(ctx context.Context, req *fuse.SetattrRequest, resp *fus
+ 	return dir.Setattr(ctx, req, resp)
+ }
+
++// Fsync implements the fs.NodeFsyncer interface for TLF.
++func (tlf *TLF) Fsync(ctx context.Context, req *fuse.FsyncRequest) (err error) {
++	dir, err := tlf.loadDir(ctx)
++	if err != nil {
++		return err
++	}
++	return dir.Fsync(ctx, req)
++}
++
+ var _ fs.Handle = (*TLF)(nil)
+
+ var _ fs.NodeOpener = (*TLF)(nil)","If we don't have a `dir` yet, we wouldn't need to do a sync right? If so, perhaps we can just `getStoredDir()` like `Attr()`?",@mmaxim this was the only place where I was able to use `fs
+3851,"@@ -1637,10 +1637,13 @@ privload_mem_is_elf_so_header(byte *mem)
+     /* libdynamorio should be ET_DYN */
+     if (elf_hdr->e_type != ET_DYN)
+         return false;
+-    /* ARM or X86 */
++        /* ARM or X86 */
++#        ifndef DR_HOST_NOT_TARGET
+     if (elf_hdr->e_machine !=
+-        IF_X86_ELSE(IF_X64_ELSE(EM_X86_64, EM_386), IF_X64_ELSE(EM_AARCH64, EM_ARM)))
++        IF_HOST_X86_ELSE(IF_HOST_X64_ELSE(EM_X86_64, EM_386),
++                         IF_HOST_X64_ELSE(EM_AARCH64, EM_ARM)))
+         return false;
++#        endif
+     if (elf_hdr->e_ehsize != sizeof(ELF_HEADER_TYPE))
+         return false;
+     return true;",I still don't seem to fully understand this. Why are we testing the host if DR_HOST_NOT_TARGET is not set?,Shouldn't this be `IF_HOST_X86`?
+3852,"@@ -34,9 +34,9 @@ import (
+
+ func TestBzzFiles(t *testing.T) {
+ 	var (
+-		fileUploadResource   = ""/bzz""
++		fileUploadResource   = ""/v1/bzz""
+ 		targets              = ""0x222""
+-		fileDownloadResource = func(addr string) string { return ""/bzz/"" + addr }
++		fileDownloadResource = func(addr string) string { return ""/v1/bzz/"" + addr }
+ 		simpleData           = []byte(""this is a simple text"")
+ 		storerMock           = smock.NewStorer()
+ 		statestoreMock       = statestore.NewStateStore()","in the current implementation, both schemes are supported (you can call either `/bzz` or `/v1/bzz`). i would suggest to keep it this way","Not really related to this PR, but do we need to include a version number in the resource name? Would be nice to have it as part of the resource name."
+3853,"@@ -44,9 +44,12 @@ module.exports = class Client {
+       body: data
+     }).then((response) => response.json()).then((assembly) => {
+       if (assembly.error) {
+-        const error = new Error(assembly.error)
++        const error = new Error(assembly)
+         error.message = assembly.error
+-        error.details = assembly.reason
++        error.details = assembly.message
++        if (assembly.assembly_id) {
++          error.details += ' ' + `assembly_id: ${assembly.assembly_id}`
++        }
+         throw error
+       }
+ ","hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?",@MarshallOfSound What do you think about this? I don't think the `details` will be populated with the `error` details.
+3854,"@@ -315,7 +315,10 @@ class Typo3PageIndexer
+         $document->setField('rootline', $rootline);
+
+         // access
+-        $document->setField('access', (string)$this->pageAccessRootline);
++        $access = (string)$this->pageAccessRootline;
++        if (trim($access) !== """") {
++            $document->setField('access', $access);
++        }
+         if ($this->page->page['endtime']) {
+             $document->setField('endtime', $pageRecord['endtime']);
+         }",This should never be empty. The access field always needs a value of at least `c:0` or `r:0`,Please use `!empty()` instead.
+3855,"@@ -6,11 +6,16 @@ import (
+ 	""encoding/json""
+
+ 	""github.com/influxdata/flux/ast""
++	""github.com/influxdata/flux/internal/parser""
+ 	""github.com/influxdata/flux/internal/token""
+ 	""github.com/influxdata/flux/libflux/go/libflux""
+ )
+
+ func parseFile(f *token.File, src []byte) (*ast.File, error) {
++	if !useRustParser() {
++		return parser.ParseFile(f, src), nil
++	}
++
+ 	astFile := libflux.Parse(string(src))
+ 	defer astFile.Free()
+ ","Another question is, do we want to call `os.Getenv()` every time we parse a file? That seems a lot.",We don't want to use the Rust parser here since we don't expect you to be using the libflux parser. In the future we may want to rename the function t
+3856,"@@ -33,6 +33,10 @@ public interface Tuple {
+      */
+     Seq<?> toSeq();
+
++    <A> Tuple append(A v);
++
++    <A> Tuple prepend(A v);
++
+     // -- factory methods
+
+     /**",minor: please rename all occurrences of `A` to `T`. please also rename `v` to `value`.,Nit: Seems like this should be `Tuple.append` instead of `Tuple.append`.
+3857,"@@ -52,11 +52,13 @@ namespace Nethermind.Synchronization.ParallelSync
+             add { }
+             remove { }
+         }
+-
++
++        public int FastSyncLag => (Current & SyncMode.Beam) == SyncMode.Beam ? SyncModeSelectorConstants.BeamSyncFastSyncLag : SyncModeSelectorConstants.NotBeamSyncFastSyncLag;
++
+         public event EventHandler<SyncModeChangedEventArgs> Changing
+         {
+             add { }
+             remove { }
+         }
+     }
+-}
++}",Do we want it to be so dynamic? My first idea was to base it on SyncConfig.BeamSync .,Why do we need a new event? Can't we just use the existing eventbus inst
+3858,"@@ -42,7 +42,7 @@ public class RemoteNetworkConnection implements NetworkConnection {
+   @Override
+   public ConnectionType setNetworkConnection(
+       ConnectionType type) {
+-    Map<String, ConnectionType> mode = ImmutableMap.of(""type"", type);
++    Map<String, Integer> mode = ImmutableMap.of(""type"", type.getBitMask());
+     return new ConnectionType(((Number) executeMethod.execute(DriverCommand.SET_NETWORK_CONNECTION,
+                                                             ImmutableMap
+                                                                 .of(""parameters"", mode)))",can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice),"nit: maybe use `ImmutableMap.of(""type"", type.getClass().getName())`"
+3859,"@@ -68,6 +68,13 @@ def test_plot_importance(params, breast_cancer_split, train_data):
+     assert ax2.patches[2].get_facecolor() == (0, .5, 0, 1.)  # g
+     assert ax2.patches[3].get_facecolor() == (0, 0, 1., 1.)  # b
+
++    ax3 = lgb.plot_importance(gbm0, title='t @importance_type@', xlabel='x @importance_type@', ylabel='y @importance_type@')
++    assert isinstance(ax3, matplotlib.axes.Axes)
++    assert ax3.get_title() == 't @importance_type@'
++    assert ax3.get_xlabel() == 'x split'
++    assert ax3.get_ylabel() == 'y @importance_type@'
++    assert len(ax3.patches) <= 30
++
+     gbm2 = lgb.LGBMClassifier(n_estimators=10, num_leaves=3, silent=True, importance_type=""gain"")
+     gbm2.fit(X_train, y_train)
+ ",I'm confused by these tests. Shouldn't the template string `@importance_type@` have been replaced with the actual value of `importance_type`?,add `assert ax3.get_xlabel() == 'x split'`
+3860,"@@ -25,7 +25,7 @@ import (
+ type harness struct{}
+
+ func (h *harness) MakeDriver(ctx context.Context) (driver.Keeper, error) {
+-	return NewKeeper(ByteKey(""very secret secret"")), nil
++	return &keeper{secretKey: ByteKey(""very secret secret"")}, nil
+ }
+
+ func (h *harness) Close() {}",Let's keep using NewKeeper so that it got covered by tests.,Why not just return `NewKeeper(secretKey)`?
+3861,"@@ -70,6 +70,9 @@ import org.apache.solr.core.CoreContainer;
+ import org.apache.solr.handler.admin.CollectionsHandler;
+ import org.apache.solr.handler.component.HttpShardHandler;
+ import org.apache.solr.logging.MDCLoggingContext;
++import org.apache.solr.store.blob.process.BlobDeleteManager;
++import org.apache.solr.store.blob.process.BlobDeleteProcessor;
++import org.apache.solr.store.shared.SharedStoreManager;
+ import org.apache.solr.store.shared.metadata.SharedShardMetadataController;
+ import org.apache.solr.update.UpdateShardHandler;
+ import org.apache.zookeeper.CreateMode;",I only see new imports. Is there any functional change in this file?,I think the name of the class is a bit misl
+3862,"@@ -1141,6 +1141,18 @@ func (bc *blockchain) pickAndRunActions(ctx context.Context, actionMap map[strin
+ 		executedActions = append(executedActions, grant)
+ 	}
+
++	if raCtx.BlockHeight == 1 {
++		tsf, err := bc.createMemorialTransfer(raCtx.Producer.String(), raCtx.ActionGasLimit)
++		receipt, err = ws.RunAction(raCtx, tsf)
++		if err != nil {
++			return hash.ZeroHash256, nil, nil, err
++		}
++		if receipt != nil {
++			receipts = append(receipts, receipt)
++		}
++		executedActions = append(executedActions, tsf)
++	}
++
+ 	blockMtc.WithLabelValues(""gasConsumed"").Set(float64(bc.config.Genesis.BlockGasLimit - raCtx.GasLimit))
+
+ 	return ws.UpdateBlockLevelInfo(raCtx.BlockHeight), receipts, executedActions, nil",ineffectual assignment to `err` (from `ineffassign`),This should probably be done in a different
+3863,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`),"Instead of doing this, you can just do `opt"
+3864,"@@ -163,6 +163,18 @@ def FindMolChiralCenters(mol, force=True, includeUnassigned=False, includeCIP=Tr
+         centers.append((idx, code))
+   return centers
+
++import warnings
++def WrapLogs():
++  warnings.warn(""Deprecated: use the rdkit.rdBase.LogTo*() functions instead."", DeprecationWarning)
++  rdBase.LogToPythonStderr()
++
++def LogWarningMsg(msg):
++  warnings.warn(""Deprecated: use rdkit.rdBase.LogWarningMsg() instead."", DeprecationWarning)
++  rdBase.LogWarningMsg(msg)
++
++def LogErrorMsg(msg):
++  warnings.warn(""Deprecated: use rdkit.rdBase.LogErrorMsg() instead."", DeprecationWarning)
++  rdBase.LogErrorMsg(msg)
+
+ #------------------------------------
+ #","Make sure the old logging functions still work, but add deprecation warnings (unfortunately Python suppresses deprecation warnings by default, so I'm not sure if anyone'll notice).",why not just use `LogTo` and `LogError`?
+3865,"@@ -252,14 +252,17 @@ public class ManagementAuthorizationTest extends AuthorizationTest {
+
+   public void testTelemetryEnabledAsCamundaAdmin() {
+     // given
++    disableAuthorization();
++    managementService.enableTelemetry(true);
++    enableAuthorization();
+     identityService.setAuthentication(userId, Collections.singletonList(Groups.CAMUNDA_ADMIN));
+
+     // when
+-    managementService.enableTelemetry(true);
++    managementService.enableTelemetry(false);
+
+     // then
+     String telemetryPropertyValue = TelemetryHelper.fetchConfigurationProperty(processEngineConfiguration).getValue();
+-    assertThat(Boolean.parseBoolean(telemetryPropertyValue)).isTrue();
++    assertThat(Boolean.parseBoolean(telemetryPropertyValue)).isFalse();
+   }
+
+ }","Not directly related to the topic of this ticket: I think this API design is a bit confusing. To disable delemetry, I would write `managementService.enableTelemetry(false)` which is not intuitive to read. Maybe `toggleTelemetry` instead of `enableTelemetry` is more clear.",This test case depends on the nature of
+3866,"@@ -163,9 +163,11 @@ namespace Microsoft.Sarif.Viewer
+                         HelpLink = rule?.HelpUri?.ToString()
+                     };
+
+-                    CaptureAnnotatedCodeLocationCollections(result.Stacks, AnnotatedCodeLocationKind.Stack, sarifError);
++                    IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotationsFromStacks(result.Stacks);
++
++                    CaptureAnnotatedCodeLocationCollections(stackLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+                     CaptureAnnotatedCodeLocationCollections(result.CodeFlows, AnnotatedCodeLocationKind.CodeFlow, sarifError);
+-                     CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
++                    CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+
+                     if (region != null)
+                     {",Again I suggest returning `AnnotatedCodeLocation[][]`.,Is it possible to use the return value o
+3867,"@@ -16,11 +16,14 @@ package ec2
+ import (
+ 	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/aws-sdk-go/service/ec2""
++	""github.com/golang/glog""
+ 	""github.com/pkg/errors""
+ 	""sigs.k8s.io/cluster-api-provider-aws/cloud/aws/providerconfig/v1alpha1""
+ )
+
+ func (s *Service) reconcileInternetGateways(in *v1alpha1.Network) error {
++	glog.V(2).Infof(""Reconciling internet gateways"")
++
+ 	igs, err := s.describeVpcInternetGateways(&in.VPC)
+ 	if IsNotFound(err) {
+ 		ig, err := s.createInternetGateway(&in.VPC)",We should probably require an increased verbosity to output for anything below the cluster itself to avoid spamming the logs. It would also be good to give additional context as to what we are attempting to reconcile since the controller has multiple workers.,This should be `Infof` not `Info`.
+3868,"@@ -32,5 +32,7 @@ type OptionsNetwork struct {
+ 	EtherClientRPC       string
+ 	EtherPaymentsAddress string
+
++	EnableDNS bool
++
+ 	QualityOracle string
+ }",Not needed anymore,When would this not be true?
+3869,"@@ -80,6 +80,17 @@ namespace Datadog.Trace.ClrProfiler
+                 Log.Error(ex, ""ByRef instrumentation cannot be enabled: "");
+             }
+
++            try
++            {
++                Log.Debug(""Enabling calltarget state by ref."");
++                NativeMethods.EnableCallTargetStateByRef();
++                Log.Information(""CallTarget State ByRef enabled."");
++            }
++            catch (Exception ex)
++            {
++                Log.Error(ex, ""CallTarget state ByRef cannot be enabled: "");
++            }
++
+             try
+             {
+                 Log.Debug(""Sending CallTarget integration definitions to native library."");","Am I right in thinking this completely avoids the situation where `enable_calltarget_state_by_ref` is `true`, but the managed integrations don't expect a by ref argument? For example, if there's an exception here, that seems like a fatal problem, as we would have a mismatch for jit rewriting? We should disable instrumentation entirely in that case shouldn't we? i.e. if this (or the existing `EnableByRefInstrumentation`) calls fail, should we bail out of this method entirely as we can't safely instrument?",Should this be an exception?
+3870,"@@ -40,6 +40,15 @@ const (
+
+ package {{ .Package }}
+
++type ResourceTypes int
++
++const (
++	Unknown ResourceTypes = iota
++	{{- range .KnownTypes }}
++    {{ . }}
++    {{- end }}
++)
++
+ // Instance describes a single resource annotation
+ type Instance struct {
+ 	// The name of the annotation.",nit: spaces seem off,I'm not sure if this is a go
+3871,"@@ -20,7 +20,7 @@
+
+ #include ""PBFParser.h""
+
+-PBFParser::PBFParser(const char * fileName) : externalMemory(NULL){
++PBFParser::PBFParser(ExtractorCallbacks* em, ScriptingEnvironment& se, const char * fileName) : BaseParser( em, se ) {
+ 	GOOGLE_PROTOBUF_VERIFY_VERSION;
+ 	//TODO: What is the bottleneck here? Filling the queue or reading the stuff from disk?
+ 	//NOTE: With Lua scripting, it is parsing the stuff. I/O is virtually for free.",shouldn't the em parameter be called ec?,May as well remove the extra
+3872,"@@ -132,7 +132,7 @@ func validateTrustedOperators(o *Options) error {
+ 		if o.TrustedKeys == nil {
+ 			o.TrustedKeys = make([]string, 0, 4)
+ 		}
+-		o.TrustedKeys = append(o.TrustedKeys, opc.Issuer)
++		o.TrustedKeys = append(o.TrustedKeys, opc.Subject)
+ 		o.TrustedKeys = append(o.TrustedKeys, opc.SigningKeys...)
+ 	}
+ 	for _, key := range o.TrustedKeys {","Please change this to use o.DidSign(o) as implements this logic without performing any of these checks that duplicate something that JWT can do correctly. If the JWT deserialized properly, and DidSign returns true, the JWT was signed by one of the listed operator keys.",why is this change needed?
+3873,"@@ -0,0 +1,19 @@
++package de.danoeh.antennapod.core.util.comparator;
++
++import java.util.Comparator;
++
++import de.danoeh.antennapod.core.feed.FeedItem;
++import de.danoeh.antennapod.core.feed.SearchResult;
++
++public class InReverseChronologicalOrder implements Comparator<SearchResult> {
++    /**
++     * Compare items and sort it on chronological order.
++     */
++    @Override
++    public int compare(SearchResult o1, SearchResult o2) {
++        if ((o1.getComponent() instanceof FeedItem) &&
++           (o2.getComponent() instanceof FeedItem))
++            return ((FeedItem) o2.getComponent()).getPubDate().compareTo(((FeedItem) o1.getComponent()).getPubDate());
++        return 0;
++    }
++}","Talking about style, IMO extracting either `getComponent()` or `getPubDate()` to variables would make this line easier to read.",Please add a doxygen heade
+3874,"@@ -0,0 +1,18 @@
++// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package task
++
++// Option defines a function that can be executed in some task API methods in order to perform custom configurations
++// of the task
++type Option func(*Task) error",package header missing,Please don't extend the `T
+3875,"@@ -11,7 +11,11 @@ options._catchError = function(error, newVNode, oldVNode) {
+ 		for (; (vnode = vnode._parent); ) {
+ 			if ((component = vnode._component) && component._childDidSuspend) {
+ 				// Don't call oldCatchError if we found a Suspense
+-				return component._childDidSuspend(error, newVNode._component);
++				return component._childDidSuspend(
++					error,
++					newVNode._component,
++					oldVNode && oldVNode._hydrateDom && oldVNode._hydrating
++				);
+ 			}
+ 		}
+ 	}","Just a thought (doesn't change the output or anything) - do you think we'll ever want to access the other properties of `oldVNode` from within `_childDidSuspend`? If so we could pass `oldVNode` here and then check these properties in the _childDidSuspend implementation. I don't have strong feelings either way, just occurred to me.",You may want to add this c
+3876,"@@ -0,0 +1,15 @@
++<?php
++
++namespace Sonata\MediaBundle\PHPCR;
++
++use Doctrine\ODM\PHPCR\DocumentRepository;
++use Doctrine\ODM\PHPCR\Id\RepositoryIdInterface;
++
++class GalleryHasMediaRepository extends DocumentRepository implements RepositoryIdInterface
++{
++    public function generateId($document, $parent = null)
++    {
++        return '/cms/gallery-has-media/'  . uniqid();
++    }
++}
++",We should be configuring the base paths somewhere..,why not `/cms/gallery-has-media/` ?
+3877,"@@ -311,6 +311,17 @@ def test_ssd_anchor_generator():
+     else:
+         device = 'cpu'
+
++    # min_sizes max_sizes must set at the same time
++    with pytest.raises(AssertionError):
++        anchor_generator_cfg = dict(
++            type='SSDAnchorGenerator',
++            scale_major=False,
++            min_sizes=[48, 100, 150, 202, 253, 300],
++            max_sizes=None,
++            strides=[8, 16, 32, 64, 100, 300],
++            ratios=[[2], [2, 3], [2, 3], [2, 3], [2], [2]])
++        build_anchor_generator(anchor_generator_cfg)
++
+     anchor_generator_cfg = dict(
+         type='SSDAnchorGenerator',
+         scale_major=False,",May also need to test the normal functionality with min/max_sizes,Can this be moved to `build_anchor_
+3878,"@@ -73,6 +73,7 @@ var MainnetDefinition = NetworkDefinition{
+ 		ChainID:            1,
+ 		MystAddress:        ""0x4Cf89ca06ad997bC732Dc876ed2A7F26a9E7f361"",
+ 		EtherClientRPC: []string{
++			""https://ethereum1.mysterium.network/"",
+ 			""https://main-light.eth.linkpool.io/"",
+ 		},
+ 	},",We can remove this one. It's just a random one I got for free for testing.,"This is probably a good idea, but i"
+3879,"@@ -7,6 +7,7 @@
+ package blocksync
+
+ import (
++	""github.com/iotexproject/iotex-core/db""
+ 	""sync""
+
+ 	""github.com/iotexproject/iotex-core/actpool""",File is not `goimports`-ed (from `goimports`),Please add gitea copyright header
+3880,"@@ -65,7 +65,11 @@ class AddFiles extends Component {
+
+   renderMyDeviceAcquirer = () => {
+     return (
+-      <div class=""uppy-DashboardTab"" role=""presentation"">
++      <div
++        class=""uppy-DashboardTab""
++        role=""presentation""
++        data-acquirer-id=""Local""
++      >
+         <button
+           type=""button""
+           class=""uppy-DashboardTab-btn""",(maybe this should be MyDevice or just removed entirely?),"Maybe add a `role=""presentation""` to the button as well? Just so it's easier to find it later on."
+3881,"@@ -337,6 +337,10 @@ func (payloadHandler *payloadRequestHandler) handleUnrecognizedTask(task *ecsacs
+ 		TaskARN: *task.Arn,
+ 		Status:  apitaskstatus.TaskStopped,
+ 		Reason:  UnrecognizedTaskError{err}.Error(),
++		// The real task cannot be extracted from payload message, so we send an empty task.
++		// This is necessary because the task handler will not send an event whose
++		// Task is nil.
++		Task: &apitask.Task{},
+ 	}
+
+ 	payloadHandler.taskHandler.AddStateChangeEvent(taskEvent, payloadHandler.ecsClient)","Can you do a nil check here, as the task isn't always nil here?",Why do we have to set Task to nil here? Is that because we are sending an empty task event?
+3882,"@@ -30,9 +30,12 @@ import Layout from 'GoogleComponents/layout/layout';
+  */
+ import { isDataZeroForReporting, getTopPagesReportDataDefaults } from '../util';
+
+-const { __ } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class AnalyticsDashboardWidgetPopularPagesTable extends Component {
+ 	static renderLayout( component ) {",`lodash` shouldn't be grouped under WordPress dependencies,Do we still need to import `lodash`?
+3883,"@@ -76,7 +76,11 @@ public class DiscoveryConfiguration {
+                   ""enode://011f758e6552d105183b1761c5e2dea0111bc20fd5f6422bc7f91e0fabbec9a6595caf6239b37feb773dddd3f87240d99d859431891e4a642cf2a0a9e6cbb98a@51.141.78.53:30303"",
+                   ""enode://176b9417f511d05b6b2cf3e34b756cf0a7096b3094572a8f6ef4cdcb9d1f9d00683bf0f83347eebdf3b81c3521c2332086d9592802230bf528eaf606a1d9677b@13.93.54.137:30303"",
+                   ""enode://46add44b9f13965f7b9875ac6b85f016f341012d84f975377573800a863526f4da19ae2c620ec73d11591fa9510e992ecc03ad0751f53cc02f7c7ed6d55c7291@94.237.54.114:30313"",
+-                  ""enode://b5948a2d3e9d486c4d75bf32713221c2bd6cf86463302339299bd227dc2e276cd5a1c7ca4f43a0e9122fe9af884efed563bd2a1fd28661f3b5f5ad7bf1de5949@18.218.250.66:30303"")
++                  ""enode://b5948a2d3e9d486c4d75bf32713221c2bd6cf86463302339299bd227dc2e276cd5a1c7ca4f43a0e9122fe9af884efed563bd2a1fd28661f3b5f5ad7bf1de5949@18.218.250.66:30303"",
++                  ""enode://c1f8b7c2ac4453271fa07d8e9ecf9a2e8285aa0bd0c07df0131f47153306b0736fd3db8924e7a9bf0bed6b1d8d4f87362a71b033dc7c64547728d953e43e59b2@52.64.155.147:30303"",
++                  ""enode://f4a9c6ee28586009fb5a96c8af13a58ed6d8315a9eee4772212c1d4d9cebe5a8b8a78ea4434f318726317d04a3f531a1ef0420cf9752605a562cfe858c46e263@213.186.16.82:30303"",
++                  // Ethereum Foundation bootnode
++                  ""enode://a61215641fb8714a373c80edbfa0ea8878243193f57c96eeb44d0bc019ef295abd4e044fd619bfc4c59731a73fb79afe84e9ab6da0c743ceb479cbb6d263fa91@3.11.147.67:30303"")
+               .map(EnodeURL::fromString)
+               .collect(toList()));
+ ",Does order matter? Should we sort by enode key to make duplication checking easier?,Why did you change the hash?
+3884,"@@ -132,11 +132,11 @@ func (ash *Handler) Provision(ctx caddy.Context) error {
+ 		return err
+ 	}
+
+-	acmeAuth, err := acme.NewAuthority(
+-		auth.GetDatabase().(nosql.DB),     // stores all the server state
+-		ash.Host,                          // used for directory links; TODO: not needed
+-		strings.Trim(ash.PathPrefix, ""/""), // used for directory links
+-		auth)                              // configures the signing authority
++	acmeAuth, err := acme.New(auth, acme.AuthorityOptions{
++		DB:     auth.GetDatabase().(nosql.DB),     // stores all the server state
++		DNS:    ash.Host,                          // used for directory links; TODO: not needed
++		Prefix: strings.Trim(ash.PathPrefix, ""/""), // used for directory links
++	})
+ 	if err != nil {
+ 		return err
+ 	}",Can you explain this too? This seems to go beyond linting.,"Should this be `strings.Trim(ash.PathPrefix, ""/"")`?"
+3885,"@@ -151,12 +151,6 @@ describe('Components', () => {
+ 		expect(scratch.innerHTML).to.equal('');
+ 	});
+
+-	// Test for #651
+-	it('should set enumerable boolean attribute', () => {
+-		render(<input spellcheck={false} />, scratch);
+-		expect(scratch.firstChild.spellcheck).to.equal(false);
+-	});
+-
+ 	// Test for Issue #73
+ 	it('should remove orphaned elements replaced by Components', () => {
+ 		class Comp extends Component {",I just moved this into the render.js UT file since this test doesn't actually use an components,@samouri I found we were not seeing this one. Can y
+3886,"@@ -163,6 +163,8 @@ var ConfigCommand *cobra.Command = &cobra.Command{
+ 			util.Failed(""Could not write ddev config file: %v"", err)
+ 		}
+
++		_,_ = app.CreateSettingsFile()
++
+ 		// If a provider is specified, prompt about whether to do an import after config.
+ 		switch provider {
+ 		case ddevapp.DefaultProviderName:",We do have to capture and check the err here right? I don't think we need to capture the location of the file though for this context.,Why aren't we prompting the import after setting up
+3887,"@@ -8,7 +8,6 @@ import time
+ import sys
+ import logging
+ from logging.handlers import RotatingFileHandler
+-import os
+ from listenbrainz.listenstore import InfluxListenStore
+ import redis
+ ",an unused import,You forgot to remove the `import os` here
+3888,"@@ -152,6 +152,9 @@ func parseTLS(h Helper) ([]ConfigValue, error) {
+ 			// policy that is looking for any tag but the last one to be
+ 			// loaded won't find it, and TLS handshakes will fail (see end)
+ 			// of issue #3004)
++
++			tlsCertTags := h.state[""tlsCertTags""].(map[string]string)
++
+ 			tag, ok := tlsCertTags[certFilename]
+ 			if !ok {
+ 				// haven't seen this cert file yet, let's give it a tag","If this value doesn't exist (do an `, ok := ...` check), we should initialize and store it","This can be simplified to `tlsCertTags := h.state[""tlsCertTags""]`"
+3889,"@@ -1,6 +1,3 @@
+-import { or } from 'ramda';
+-
+-
+-const MIN_SAFE_INTEGER = or(Number.MIN_SAFE_INTEGER, -(2 ** 53) - 1);
++const MIN_SAFE_INTEGER = Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1;
+
+ export default MIN_SAFE_INTEGER;",Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1),Why the change away from the `or`?
+3890,"@@ -175,8 +175,7 @@ class Serial(IoBase):
+ 		self._origTimeout = self._ser.timeout
+ 		# We don't want a timeout while we're waiting for data.
+ 		self._setTimeout(None)
+-		self.inWaiting = self._ser.inWaiting
+-		super(Serial, self).__init__(self._ser.hComPort, onReceive)
++		super(Serial, self).__init__(self._ser._port_handle, onReceive)
+
+ 	def read(self, size=1):
+ 		data = self._ser.read(size)","This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do.",Can we set `self._inWaiting = False` when `self._ser._port_handle
+3891,"@@ -581,7 +581,7 @@ uint32_t wlr_xdg_toplevel_set_maximized(struct wlr_xdg_surface *surface,
+ 	assert(surface->role == WLR_XDG_SURFACE_ROLE_TOPLEVEL);
+ 	surface->toplevel->server_pending.maximized = maximized;
+
+-	return schedule_xdg_surface_configure(surface);
++	return wlr_xdg_surface_schedule_configure(surface);
+ }
+
+ uint32_t wlr_xdg_toplevel_set_fullscreen(struct wlr_xdg_surface *surface,","This function is what **the compositor** calls when it wants to fullscreen a client, not what the client calls.",This function has been deprecated. Please remove it.
+3892,"@@ -98,12 +98,13 @@ func TestTraceflow(t *testing.T) {
+ 		t.Fatal(err)
+ 	}
+
+-	// Creates 4 traceflows:
++	// Creates 6 traceflows:
+ 	// 1. node1Pods[0] -> node1Pods[1], intra node1.
+ 	// 2. node1Pods[0] -> node2Pods[0], inter node1 and node2.
+ 	// 3. node1Pods[0] -> node1IPs[1], intra node1.
+ 	// 4. node1Pods[0] -> node2IPs[0], inter node1 and node2.
+ 	// 5. node1Pods[0] -> service, inter node1 and node2.
++	// 6. node1Pods[0] -> not existed Pod
+ 	testcases := []testcase{
+ 		{
+ 			name: ""intraNodeTraceflow"",",s/not existed Pod/non-existing Pod,Should we have a test case with a pod that does not exist?
+3893,"@@ -62,10 +62,10 @@ type ECSStatusDescriber struct {
+ 	env string
+ 	svc string
+
+-	svcDescriber serviceDescriber
+-	ecsSvcGetter ecsServiceGetter
+-	cwSvcGetter  alarmStatusGetter
+-	aasSvcGetter autoscalingAlarmNamesGetter
++	ecsSvcDescriber serviceDescriber
++	ecsSvcGetter    ecsServiceGetter
++	cwSvcGetter     alarmStatusGetter
++	aasSvcGetter    autoscalingAlarmNamesGetter
+ }
+
+ // AppRunnerStatusDescriber retrieves status of an AppRunner service.",Why did we not leave this as just `svcDescriber`?,Could we remove the `serviceDescriber` here and make it ju
+3894,"@@ -11,12 +11,12 @@
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+-
+ """"""Provides the data access object (DAO) for Groups.""""""
+
++from Queue import Queue
++
+ from google.cloud.security.common.data_access import dao
+ from google.cloud.security.common.data_access.sql_queries import select_data
+-from google.cloud.security.common.gcp_type import group_member
+ from google.cloud.security.common.util import log_util
+
+ LOGGER = log_util.get_logger(__name__)",nit: I think we've been (in)consistent in leaving a blank line here.,Minor: I think this import is unused.
+3895,"@@ -47,13 +47,15 @@ def define_violation(dbengine):
+         __tablename__ = violations_tablename
+
+         id = Column(Integer, primary_key=True)
+-        model_handle = Column(String(256))
++        inventory_index_id = Column(String(256))
+         resource_id = Column(String(256), nullable=False)
+         resource_type = Column(String(256), nullable=False)
++        full_name = Column(String(1024))
+         rule_name = Column(String(256))
+         rule_index = Column(Integer, default=0)
+         violation_type = Column(String(256), nullable=False)
+         data = Column(Text)
++        inventory_data = Column(Text)
+
+         def __repr__(self):
+             """"""String representation.",Maybe we can change it to a more generic name like source_id.,inventory_data -> inventory_text
+3896,"@@ -2019,7 +2019,7 @@ func testKeyManagerRekeyAddDeviceWithPromptViaFolderAccess(t *testing.T, ver Met
+ 		defer ops.mdWriterLock.Unlock(lState)
+
+ 		// Now cause a paper prompt unlock via a folder access
+-		errCh := make(chan error)
++		errCh := make(chan error, 1)
+ 		go func() {
+ 			_, err := GetRootNodeForTest(ctx, config2Dev2, name, false)
+ 			select {","What's the theory on why this could fix the hang? It seems like the call to `GetRootNodeForTest` will always need to call into the crypto object before returning an error, and so it should block on that `c` receive, after which the test immediately drains `errCh`. So I don't quite see how buffering would help...",Why was this changed?
+3897,"@@ -2003,8 +2003,16 @@ decode_operand(decode_info_t *di, byte optype, opnd_size_t opsize, opnd_t *opnd)
+         return true;
+     }
+     case TYPE_H: {
+-        /* part of AVX: vex.vvvv selects xmm/ymm register */
++        /* As part of AVX and AVX-512, vex.vvvv selects xmm/ymm/zmm register. Note that
++         * vex.vvvv and evex.vvvv are a union.
++         */
+         reg_id_t reg = (~di->vex_vvvv) & 0xf; /* bit-inverted */
++        if (TEST(PREFIX_EVEX_VV, di->prefixes)) {
++            /* This assumes that the register ranges of DR_REG_XMM, DR_REG_YMM, and
++             * DR_REG_ZMM are contiguous.
++             */
++            reg += 16;
++        }
+         *opnd = opnd_create_reg(((TEST(PREFIX_VEX_L, di->prefixes) &&
+                                   /* see .LIG notes above */
+                                   expand_subreg_size(opsize) != OPSZ_16)",Maybe add an assert in arch_init or somewhere?,This assumes `vex.vvv
+3898,"@@ -100,6 +100,7 @@ func TestcaseNetworkDelay(
+ 	err := cli.Create(ctx, networkDelay.DeepCopy())
+ 	framework.ExpectNoError(err, ""create network chaos error"")
+
++	// nolint
+ 	wait.Poll(time.Second, 15*time.Second, func() (done bool, err error) {
+ 		result = probeNetworkCondition(c, networkPeers, ports, false)
+ 		if len(result[networkConditionBlocked]) != 0 || len(result[networkConditionSlow]) != 3 {",I wonder what does this `// nolint` ignore? And what are the standards that you choose which error to fix and which to ignore?,could we just remove
+3899,"@@ -441,7 +441,10 @@ public class HttpSolrCall {
+     } else {
+       if (!retry) {
+         // we couldn't find a core to work with, try reloading aliases & this collection
+-        cores.getZkController().getZkStateReader().aliasesManager.update();
++        if(!cores.getZkController().getZkStateReader().aliasesManager.update()) {
++          //no change. go back
++          return;
++        }
+         cores.getZkController().zkStateReader.forceUpdateCollection(collectionName);
+         action = RETRY;
+       }","what about the line below, forceUpdateCollection?",Sorry didn't see this
+3900,"@@ -72,9 +72,13 @@ module Beaker
+     def cmd_line host, cmd = @command, env = @environment, pc = @prepend_cmds
+       env_string = host.environment_string( env )
+       prepend_commands = host.prepend_commands( cmd, pc, :cmd_exe => @cmdexe )
++      if host[:platform] =~ /cisco_nexus/ && host[:user] != 'root'
++          append_command = '""'
++        cmd = cmd.gsub('""') { '\\""' }
++      end
+
+       # This will cause things like `puppet -t -v agent` which is maybe bad.
+-      cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string]
++      cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string, append_command]
+       cmd_line_array.compact.reject( &:empty? ).join( ' ' )
+     end
+ ",Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?,The `host[:platform] =~ /cisco_nexus/` matches the `host[:user] != 'root'` case.
+3901,"@@ -31,7 +31,7 @@ export const refreshAuthentication = async () => {
+
+ 		// We should really be using state management. This is terrible.
+ 		global.googlesitekit.setup = global.googlesitekit.setup || {};
+-		global.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
++		global.googlesitekit.setup.authenticated = response.authenticated;
+ 		global.googlesitekit.setup.requiredScopes = response.requiredScopes;
+ 		global.googlesitekit.setup.grantedScopes = response.grantedScopes;
+ 		global.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;",I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route. All updates to the JS components above wouldn't be necessary.,"The `isAuthenticated` property was renamed to `authenticated` in #3569, but we'r"
+3902,"@@ -36,7 +36,7 @@ function sendCommandToFrame(node, parameters, resolve, reject) {
+         reject(err('No response from frame', node));
+       }
+     }, 0);
+-  }, 500);
++  }, parameters.options?.pingWaitTime ?? 500);
+
+   // send 'axe.ping' to the frame
+   respondable(win, 'axe.ping', null, undefined, () => {","Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here.",Why not `0`? Are we rejecting the promise if there's no `pingWaitTime`?
+3903,"@@ -11,11 +11,15 @@ TEST_DATA = '{""StreamName"": ""NotExistingStream""}'
+ class KinesisListenerTest(unittest.TestCase):
+
+     def test_describe_stream_summary_is_redirected(self):
+-        describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'}
++        if config.KINESIS_PROVIDER == 'kinesalite':
++            describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'}
+
+-        response = UPDATE_KINESIS.forward_request('POST', '/', TEST_DATA, describe_stream_summary_header)
++            response = UPDATE_KINESIS.forward_request('POST', '/', TEST_DATA,
++                describe_stream_summary_header)
+
+-        self.assertEqual(response, True)
++            self.assertEqual(response, True)
++        else:
++            self.assertTrue(True)
+
+     def test_random_error_on_put_record(self):
+         put_record_header = {'X-Amz-Target': 'Kinesis_20131202.PutRecord'}",I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock,nit: I think we should be using `elif config.KINESIS_PROVIDER in 'kinesalite'` h
+3904,"@@ -3,7 +3,7 @@
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee
++#Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee
+
+ from copy import deepcopy
+ import os",Please add your name to the list of copyright holders.,Copyright date should not be changed unless the file has been completely replaced
+3905,"@@ -50,6 +50,12 @@ public class IpPortManager {
+
+   private boolean autoDiscoveryInited = false;
+
++  private int maxRetryTimes;
++
++  public int getMaxRetryTimes() {
++    return maxRetryTimes;
++  }
++
+   public IpPortManager(ServiceRegistryConfig serviceRegistryConfig, InstanceCacheManager instanceCacheManager) {
+     this.serviceRegistryConfig = serviceRegistryConfig;
+     this.instanceCacheManager = instanceCacheManager;","Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?",Making this public means that any change in the constructor will break backwards
+3906,"@@ -439,7 +439,7 @@ type CloneLink struct {
+ 	Git   string
+ }
+
+-func (repo *Repository) cloneLink(isWiki bool) *CloneLink {
++func (repo *Repository) cloneLink(isWiki bool, signedUserName string) *CloneLink {
+ 	repoName := repo.Name
+ 	if isWiki {
+ 		repoName += "".wiki""","Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method.",Why `signedUserName`? Is it supposed to be a username?
+3907,"@@ -65,6 +65,13 @@ namespace Datadog.Trace
+             AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit;
+             AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException;
+             Console.CancelKeyPress += Console_CancelKeyPress;
++
++            // If configured, add/remove the correlation identifiers into the
++            // LibLog logging context when a scope is activated/closed
++            if (Settings.LogsInjectionEnabled)
++            {
++                new LibLogCorrelationIdentifierScopeSubscriber(_scopeManager);
++            }
+         }
+
+         /// <summary>",How would you feel about a static method to express intent?,Do you need to also unsubscribe the `LibLogCorrelationIdentifierScopeSubscriber`
+3908,"@@ -75,7 +75,8 @@ func (t LoggableTLSConnState) MarshalLogObject(enc zapcore.ObjectEncoder) error
+ 	enc.AddUint16(""version"", t.Version)
+ 	enc.AddUint16(""cipher_suite"", t.CipherSuite)
+ 	enc.AddString(""proto"", t.NegotiatedProtocol)
+-	enc.AddBool(""proto_mutual"", t.NegotiatedProtocolIsMutual)
++	// NegotiatedProtocolIsMutual is deprecated - it's always true
++	enc.AddBool(""proto_mutual"", true)
+ 	enc.AddString(""server_name"", t.ServerName)
+ 	if len(t.PeerCertificates) > 0 {
+ 		enc.AddString(""client_common_name"", t.PeerCertificates[0].Subject.CommonName)",Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?,"It's always true, even if the protocol is not negotiated, so we can remove this."
+3909,"@@ -16,8 +16,7 @@
+
+ package account
+
+-//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go
+-//go:generate dbgen -i part.sql -p account -n part -o partInstall.go
++//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go -h ../../scripts/LICENSE_HEADER
+ import (
+ 	""database/sql""
+ 	""fmt""","the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either.",I'm pretty sure this should be `rootInstall.go` and not `rootInstall.go`.
+3910,"@@ -97,3 +97,11 @@ func (c *TTLCache) Delete(key interface{}) error {
+ 	c.entries.Delete(key)
+ 	return nil
+ }
++
++func (c *TTLCache) GetAll() ([]interface{}, error) {
++	return nil, cache.ErrUnimplemented
++}
++
++func (c *TTLCache) PutHash(k interface{}, v interface{}) error {
++	return cache.ErrUnimplemented
++}",`k` is unused in PutHash,Why are we returning an error for this?
+3911,"@@ -277,4 +277,12 @@ public class Utils {
+ 		Method method = clazz.getDeclaredMethod(methodName, argTypes);
+ 		return method.invoke(null, args);
+ 	}
++
++	public static void copyStream(InputStream input, OutputStream output) throws IOException {
++		byte[] buffer = new byte[1024];
++		int bytesRead;
++		while ((bytesRead = input.read(buffer)) != -1) {
++			output.write(buffer, 0, bytesRead);
++		}
++	}
+ }",Use IOUtils instead,Wouldn't it make more sense to do this in a try-with-resources block?
+3912,"@@ -27,6 +27,8 @@ type idmFake struct {
+ 	unlockFails          bool
+ }
+
++// NewIdentityManagerFake creates fake identity manager for testing purposes
++// TODO each caller should use it's own mocked manager part instead of global one
+ func NewIdentityManagerFake(existingIdentities []Identity, newIdentity Identity) *idmFake {
+ 	return &idmFake{"""", """", existingIdentities, newIdentity, false}
+ }","It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited.","If you're using a mocked manager, why not just make it a `*mock.Manager`?"
+3913,"@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+
+
+ class Options(object):
++    KEY = ""goog:chromeOptions""
+
+     def __init__(self):
+         self._binary_location = ''",nice touch since Google likes to change things every now and then.,The `chromeOptions` key is already defined in `options.py`.
+3914,"@@ -1174,7 +1174,8 @@ public final class SolrCore implements SolrInfoBean, Closeable {
+   }
+
+   private CircuitBreakerManager initCircuitBreakerManager() {
+-    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(solrConfig);
++    final PluginInfo info = solrConfig.getPluginInfo(CircuitBreakerManager.class.getName());
++    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(info.initArgs);
+
+     return circuitBreakerManager;
+   }",Make `CircuitBreakerManager` implement `PluginInfoInitialized`,Is there a reason to not just call `CircuitBreakerManager.build(info)`?
+3915,"@@ -679,7 +679,7 @@ class _ServerCapabilities:
+ def _as_uint32(x: int) -> QVariant:
+     """"""Convert the given int to an uint32 for DBus.""""""
+     variant = QVariant(x)
+-    successful = variant.convert(QVariant.Type.UInt)
++    successful = variant.convert(QMetaType(QMetaType.Type.UInt.value))
+     assert successful
+     return variant
+ ","This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type.",I would say `int` instead of `uint32` here and below
+3916,"@@ -59,6 +59,12 @@ type Writer struct {
+
+ 	// These fields exist only when w is not created in the first place when
+ 	// NewWriter is called.
++	//
++	// A ctx is stored in the Writer since we need to pass it into NewTypedWriter
++	// when we finished detecting the content type of the object and create the
++	// underlying driver.Writer. This step happens inside Write or Close and
++	// neither of them take a context.Context as an argument. The ctx must be set
++	// to nil after we have done passing it.
+ 	ctx    context.Context
+ 	bucket driver.Bucket
+ 	key    string","Nit: finished -> finish, ""done passing it"" -> ""passed it"".",Do we still need this? Or is it that Write/Close calls w.Write(nil) but w.Close doesn't?
+3917,"@@ -46,5 +46,18 @@ module C2
+     config.autoload_paths << Rails.root.join('lib')
+
+     config.assets.precompile << 'common/communicarts.css'
++
++    # Paperclip's attachment settings are determined by S3 env vars
++    if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY']
++      Paperclip::Attachment.default_options.merge!(
++        bucket: ENV['S3_BUCKET_NAME'],
++        s3_credentials: {
++          access_key_id: ENV['S3_ACCESS_KEY_ID'],
++          secret_access_key: ENV['S3_SECRET_ACCESS_KEY']
++        },
++        s3_permissions: :private,
++        storage: :s3,
++      )
++    end
+   end
+ end",Maybe mention that it will be saved to the filesystem otherwise?,what if we called this s3_credential?
+3918,"@@ -108,7 +108,11 @@ namespace pwiz.Skyline.FileUI
+             {
+                 for (var i = 0; i < numColumns; i++)
+                 {
+-                    dataGrid.Columns[i].ToolTipText =
++                    // In the case when we don't have user provided headers, we still want localized headers that can be translated,
++                    // this replaces the autogenerated strings with a localized version
++                    dataGrid.Columns[i].HeaderText = string.Format(Resources.ImportTransitionListColumnSelectDlg_DisplayData_Column_) + (i+1).ToString();
++
++                    dataGrid.Columns[i].ToolTipText =
+                         string.Format(Resources.ImportTransitionListColumnSelectDlg_DisplayData_The_input_text_did_not_appear_to_contain_column_headers__Use_the_dropdown_control_to_assign_column_meanings_for_import_);
+                 }
+             }","Probably cleaner and more general to do this: string,Format(""Column {0}"", i+1) That way if the local language has a convention like ""3 column, this is"" it still works.",The +1 was masking a bug in the old code. The new code does not do that.
+3919,"@@ -74,11 +74,14 @@ func (v *validator) verifyActions(blk *Block, containCoinbase bool) error {
+ 	// Verify transfers, votes, executions, witness, and secrets (balance is checked in RunActions)
+ 	confirmedNonceMap := make(map[string]uint64)
+ 	accountNonceMap := make(map[string][]uint64)
++
++	transfers, votes, executions := action.ClassifyActions(blk.Actions)
+ 	var wg sync.WaitGroup
+-	wg.Add(len(blk.Transfers) + len(blk.Votes) + len(blk.Executions))
++	wg.Add(len(transfers) + len(votes) + len(executions))
++
+ 	var correctAction uint64
+ 	var coinbaseCount uint64
+-	for _, tsf := range blk.Transfers {
++	for _, tsf := range transfers {
+ 		// Verify Address
+ 		// Verify Gas
+ 		// Verify Nonce",This can be uniformed too,the len(blk.Outputs) is not needed anymore?
+3920,"@@ -16,14 +16,14 @@ type mock struct {
+ 	peers           []swarm.Address
+ 	closestPeer     swarm.Address
+ 	closestPeerErr  error
+-	addPeerErr      error
++	AddPeersErr     error
+ 	marshalJSONFunc func() ([]byte, error)
+ 	mtx             sync.Mutex
+ }
+
+-func WithAddPeerErr(err error) Option {
++func WithAddPeersErr(err error) Option {
+ 	return optionFunc(func(d *mock) {
+-		d.addPeerErr = err
++		d.AddPeersErr = err
+ 	})
+ }
+ ",It looks to me that this does not have to be exported.,Shouldn't this be `d.AddPeersErr = err`?
+3921,"@@ -61,6 +61,14 @@ public abstract class ApiConfig {
+     }
+   }
+
++  /**
++   * Creates an ApiConfig with no content. Exposed for testing.
++   */
++  public static ApiConfig createDummyApiConfig() {
++    return new AutoValue_ApiConfig(ImmutableMap.<String, InterfaceConfig> builder().build(), null,
++        false);
++  }
++
+   private static String getPackageName(ConfigProto configProto) {
+     Map<String, LanguageSettingsProto> settingsMap = configProto.getLanguageSettings();
+     String language = configProto.getLanguage();","It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code.",Please rename this to `createDummyApiCon
+3922,"@@ -511,18 +511,6 @@ public class DataversePage implements java.io.Serializable {
+         }
+         setEditInputLevel(false);
+     }
+-
+-    public void toggleInputLevel( Long mdbId, long dsftId){
+-        for (MetadataBlock mdb : allMetadataBlocks) {
+-            if (mdb.getId().equals(mdbId)) {
+-                for (DatasetFieldType dsftTest : mdb.getDatasetFieldTypes()) {
+-                    if (dsftTest.getId().equals(dsftId)) {
+-                            dsftTest.setRequiredDV(!dsftTest.isRequiredDV());
+-                    }
+-                }
+-            }
+-        }
+-    }
+
+     public void updateInclude(Long mdbId, long dsftId) {
+         List<DatasetFieldType> childDSFT = new ArrayList<>();","Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)",Is this method still used?
+3923,"@@ -186,6 +186,10 @@ func (h *Helper) ValidateIssuedCertificateRequest(cr *cmapi.CertificateRequest,
+ 		}
+ 	}
+
++	if !apiutil.CertificateRequestHasApproved(cr) {
++		return nil, fmt.Errorf(""CertificateRequest does not have an Approved condition: %+v"", cr.Status.Conditions)
++	}
++
+ 	return cert, nil
+ }
+ ",Suggestion: `.. does not have an Approved condition set to true`,Shouldn't this error message include `cr
+3924,"@@ -77,6 +77,7 @@ class BlazeMeterUploader(Reporter, AggregatorListener):
+         self.client.user_id = self.parameters.get(""user-id"", None)
+         self.client.data_signature = self.parameters.get(""signature"", None)
+         self.client.kpi_target = self.parameters.get(""kpi-target"", self.client.kpi_target)
++        self.client.delete_files_before_test = False
+
+         if not self.client.test_id:
+             try:",I would say that client class should have default of False and Cloud prov should enable deleting.,Should this be set to `True` or `False`?
+3925,"@@ -1,4 +1,4 @@
+-// Copyright (c) .NET Foundation. All rights reserved.
++// Copyright (c) .NET Foundation. All rights reserved.
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+
+ using System;",Did this remove the BOM or something?,This file shouldn't be included in this
+3926,"@@ -99,6 +99,10 @@ public class BlockHeaderValidator<C> {
+     return parent;
+   }
+
++  public void addRule(final AttachedBlockHeaderValidationRule<C> rule) {
++    this.rules.add(new Rule<>(false, rule, rule.includeInLightValidation()));
++  }
++
+   private static class Rule<C> {
+     private final boolean detachedSupported;
+     private final AttachedBlockHeaderValidationRule<C> rule;","This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created.",Doesn't seem right to me that we're addi
+3927,"@@ -383,7 +383,7 @@ def outputDeviceNameToID(name, useDefaultIfInvalid=False):
+
+ fileWavePlayer = None
+ fileWavePlayerThread=None
+-def playWaveFile(fileName, async=True):
++def playWaveFile(fileName, asynchronous=True):
+ 	""""""plays a specified wave file.
+ """"""
+ 	global fileWavePlayer, fileWavePlayerThread",May be add information about parameters to the doc string while at it?,why did you change this?
+3928,"@@ -43,8 +43,8 @@ public enum RpcMethod {
+   PRIV_DELETE_PRIVACY_GROUP(""priv_deletePrivacyGroup""),
+   PRIV_FIND_PRIVACY_GROUP(""priv_findPrivacyGroup""),
+   PRIV_DISTRIBUTE_RAW_TRANSACTION(""priv_distributeRawTransaction""),
++  PRIV_GET_TRANSACTION_COUNT_LEGACY(""priv_getTransactionCountLegacy""),
+   EEA_SEND_RAW_TRANSACTION(""eea_sendRawTransaction""),
+-  EEA_GET_TRANSACTION_COUNT(""eea_getTransactionCount""),
+   ETH_ACCOUNTS(""eth_accounts""),
+   ETH_BLOCK_NUMBER(""eth_blockNumber""),
+   ETH_CALL(""eth_call""),",Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?,This is a breaking change and needs to be added to the spec.
+3929,"@@ -3901,9 +3901,6 @@ void CoreChecks::PreCallRecordFreeMemory(VkDevice device, VkDeviceMemory mem, co
+
+     // Clear mem binding for any bound objects
+     for (auto obj : mem_info->obj_bindings) {
+-        log_msg(report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, get_debug_report_enum[obj.type], obj.handle,
+-                kVUID_Core_MemTrack_FreedMemRef, ""VK Object %s still has a reference to mem obj %s."",
+-                report_data->FormatHandle(obj.handle).c_str(), report_data->FormatHandle(mem_info->mem).c_str());
+         BINDABLE *bindable_state = nullptr;
+         switch (obj.type) {
+             case kVulkanObjectTypeImage:","This one should probably be added to the list in #24 . It's possibly indicative of an issue, but there isn't a VUID for it.","This one was left over from debugging, should it be removed?"
+3930,"@@ -139,13 +139,11 @@ def build_network_url(project, network):
+       The fully qualified network url for the given project/network.
+     """"""
+     return (u'%(root)s%(api_name)s/%(version)s/projects/%(project)s/global/'
+-            'networks/%(network)s') % {
+-                'api_name': API_NAME,
+-                'network': network,
+-                'project': project,
+-                'root': API_ROOT,
+-                'version': API_VERSION
+-            }
++            'networks/%(network)s') % {'api_name': API_NAME,
++                                       'network': network,
++                                       'project': project,
++                                       'root': API_ROOT,
++                                       'version': API_VERSION}
+
+
+ class ComputeFirewallAPI(object):","Why this indentation change? Seems the original indentation would be fine, and leaves more room.",This is an unrelated change. Please submit it as a separate
+3931,"@@ -145,7 +145,7 @@ class MultiDimensionalMapping(Dimensioned):
+             raise KeyError('Key has to match number of dimensions.')
+
+
+-    def _add_item(self, dim_vals, data, sort=True):
++    def _add_item(self, dim_vals, data, sort=True, update=True):
+         """"""
+         Adds item to the data, applying dimension types and ensuring
+         key conforms to Dimension type and values.",Would be nice to know what the `update` argument does in the docstring.,Please update the docstring
+3932,"@@ -1,10 +1,10 @@
+-import StringIO
+ from pathod import log
+ from netlib.exceptions import TcpDisconnect
+-import netlib.tcp
+
++from six.moves import cStringIO
+
+-class DummyIO(StringIO.StringIO):
++
++class DummyIO(cStringIO):
+
+     def start_log(self, *args, **kwargs):
+         pass",I think we can just use `io.BytesIO` here.,Why `cStringIO` and not `StringIO`?
+3933,"@@ -155,13 +155,14 @@ func NewGCPgRPCConn(ctx context.Context, t *testing.T, endPoint, api string) (*g
+ }
+
+ // NewAzureTestPipeline creates a new connection for testing against Azure Blob.
+-func NewAzureTestPipeline(ctx context.Context, t *testing.T, accountName string, accountKey string) (pipeline pipeline.Pipeline, done func(), httpClient *http.Client) {
++func NewAzureTestPipeline(ctx context.Context, t *testing.T, api, accountName, accountKey string) (pipeline pipeline.Pipeline, done func(), httpClient *http.Client) {
+ 	mode := recorder.ModeReplaying
+ 	if *Record {
+ 		mode = recorder.ModeRecording
+ 	}
+
+ 	azMatchers := &replay.ProviderMatcher{
++		Headers: []string{""User-Agent""},
+ 		URLScrubbers: []*regexp.Regexp{
+ 			regexp.MustCompile(`se=[^?]*`),
+ 			regexp.MustCompile(`sig=[^?]*`),",This ensures that the User-Agent header matches during replay.,Is there a reason we can't just use
+3934,"@@ -3517,6 +3517,7 @@ XDDkwd__(SUBQUERY_UNNESTING,			""ON""),
+  XDDui1__(USTAT_MIN_ROWCOUNT_FOR_LOW_SAMPLE,    ""1000000""),
+  XDDui1__(USTAT_MIN_ROWCOUNT_FOR_SAMPLE,        ""10000""),
+   DDflt0_(USTAT_MODIFY_DEFAULT_UEC,             ""0.05""),
++  DDflt0_(USTAT_NAHEAP_ESTIMATED_MAX,           ""1.3""),  // estimated max memory allocation feasible with NAHEAP.
+  XDDui1__(USTAT_NECESSARY_SAMPLE_MAX,           ""5000000""), // Maximum sample size with NECESSARY
+   DDui1__(USTAT_NUM_MC_GROUPS_FOR_KEYS,         ""10""),
+  XDDpct__(USTAT_OBSOLETE_PERCENT_ROWCOUNT,      ""15""),",What units are used for this default?,This should be `1000000`.
+3935,"@@ -47,7 +47,13 @@ public struct Ability : IFlatbufferObject
+
+ public class AbilityT
+ {
++#if ENABLE_JSON_SERIALIZATION
++  [Newtonsoft.Json.JsonProperty(""id"")]
++#endif
+   public uint Id { get; set; }
++#if ENABLE_JSON_SERIALIZATION
++  [Newtonsoft.Json.JsonProperty(""distance"")]
++#endif
+   public uint Distance { get; set; }
+
+   public AbilityT() {","I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified",Both `Id` and `Distance` should hav
+3936,"@@ -584,8 +584,7 @@ class MainWindow(QWidget):
+         quit_texts = []
+         # Ask if multiple-tabs are open
+         if 'multiple-tabs' in config.val.confirm_quit and tab_count > 1:
+-            quit_texts.append(""{} {} open."".format(
+-                tab_count, ""tab is"" if tab_count == 1 else ""tabs are""))
++            quit_texts.append(""{} tabs are open."".format(tab_count))
+         # Ask if multiple downloads running
+         if 'downloads' in config.val.confirm_quit and download_count > 0:
+             quit_texts.append(""{} {} running."".format(","Doesn't this change the behavior (edit: oh, I see, never mind).",Some of these messages are starting with 'tab is' and some are starting with 'tab is'. Let's make them consistent.
+3937,"@@ -216,11 +216,15 @@ module Travis
+               sh.cmd 'sudo ln -f -s /lib/i386-linux-gnu/libpam.so.0 /lib/libpam.so.0'
+               sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so'
+             end
+-            sh.if '$(uname -m) != ppc64le && $(lsb_release -cs) = trusty' do
++            sh.elif '$(lsb_release -cs) = trusty' do
+               sh.cmd 'sudo dpkg --add-architecture i386'
+               gemstone_install_linux_dependencies
+               sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so'
+             end
++            sh.elif '$(lsb_release -cs) = xenial || $(lsb_release -cs) = bionic' do
++              sh.cmd 'sudo dpkg --add-architecture i386'
++              gemstone_install_linux_dependencies
++            end
+           end
+
+           def gemstone_install_linux_dependencies",I think you need a `do` at the end of this line.,Is this line still needed?
+3938,"@@ -5,7 +5,7 @@
+       <%= link_to(t('blacklight.search.sort.label', :field =>current_sort_field.label), ""#"") %> <span class=""caret""></span>
+       <ul>
+         <%- blacklight_config.sort_fields.each do |sort_key, field| %>
+-          <li><%= link_to(field.label, url_for(params_for_search(:sort => sort_key))) %></li>
++          <li><%= link_to(field.label, params_for_search(params.merge(:sort => sort_key))) %></li>
+         <%- end -%>
+       </ul>
+     </li>",Not passing in a `:params` key here.,Could you please use the new hash syntax for `params_for_search` as well?
+3939,"@@ -308,6 +308,7 @@ func (r *ReconcileClusterClaim) reconcileForDeletedCluster(claim *hivev1.Cluster
+ func (r *ReconcileClusterClaim) reconcileForNewAssignment(claim *hivev1.ClusterClaim, cd *hivev1.ClusterDeployment, logger log.FieldLogger) (reconcile.Result, error) {
+ 	logger.Info(""cluster assigned to claim"")
+ 	cd.Spec.ClusterPoolRef.ClaimName = claim.Name
++	cd.Spec.PowerState = hivev1.RunningClusterPowerState
+ 	if err := r.Update(context.Background(), cd); err != nil {
+ 		logger.WithError(err).Log(controllerutils.LogLevel(err), ""could not set claim for ClusterDeployment"")
+ 		return reconcile.Result{}, err","Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to create / update powerstate on gcp/azure/etc. I'd pitch we put this onto the pool spec and make you opt in.",I don't think this is correct. What would happen if the cluster was created with a power state of `RunningClusterP
+3940,"@@ -5,13 +5,14 @@
+
+ // The conditions looks weird, but it seems like _OR_GREATER is not supported yet in all environments
+ // We can trim all the additional conditions when this is fixed
+-#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0
++#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0 || NET6_0
+
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Net;
+ using System.Threading.Tasks;
++using Datadog.Trace.IntegrationTestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+ ",I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong.,Why the change here? We don't have any new reference anywhere in the project.
+3941,"@@ -236,6 +236,15 @@ func (r *RollDPoS) CurrentState() fsm.State {
+ 	return r.cfsm.CurrentState()
+ }
+
++// Activate activates or pauses the roll-DPoS consensus. When it is deactivated, the node will finish the current
++// consensus round if it is doing the work and then return the the initial state
++func (r *RollDPoS) Activate(active bool) { r.ctx.Activate(active) }
++
++// Active is true if the roll-DPoS consensus is active, or false if it is stand-by
++func (r *RollDPoS) Active() bool {
++	return r.ctx.Active() || r.cfsm.CurrentState() != consensusfsm.InitState
++}
++
+ // Builder is the builder for RollDPoS
+ type Builder struct {
+ 	cfg config.Config",what's the second part for?,there is no need for this to be public.
+3942,"@@ -79,7 +79,7 @@ public class DirectSolrSpellCheckerTest extends SolrTestCaseJ4 {
+       return null;
+     });
+   }
+-
++
+   @Test
+   public void testOnlyMorePopularWithExtendedResults() throws Exception {
+     assertQ(req(""q"", ""teststop:fox"", ""qt"", ""/spellCheckCompRH"", SpellCheckComponent.COMPONENT_NAME, ""true"", SpellingParams.SPELLCHECK_DICT, ""direct"", SpellingParams.SPELLCHECK_EXTENDED_RESULTS, ""true"", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, ""true""),","It's not clear to me what the ""super"" test above is for. As far as I can see, the test runs a spellcheck for ""super"" but then uses ""fob"" as the index into suggestions, which will never find an entry.",Please remove this change
+3943,"@@ -24,7 +24,7 @@ import (
+ 	""google.golang.org/grpc/status""
+
+ 	logfilter ""github.com/iotexproject/iotex-core/api/logfilter""
+-	""github.com/iotexproject/iotex-core/ioctl/util""
++	ioctlUtil ""github.com/iotexproject/iotex-core/ioctl/util""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ )
+ ",revert this file change,I think the package name should be `iotexutil`
+3944,"@@ -74,9 +74,9 @@ class FileState:
+         #
+         # 1.   def meth8(self):
+         # 2.        """"""test late disabling""""""
+-        # 3.        pylint: disable=not-callable
++        # 3.        pylint: disable=not-callable, useless-suppression
+         # 4.        print(self.blip)
+-        # 5.        pylint: disable=no-member
++        # 5.        pylint: disable=no-member, useless-suppression
+         # 6.        print(self.bla)
+         #
+         # E1102 should be disabled from line 1 to 6 while E1101 from line 5 to 6",I think this is the most elegant way to allow us to still fail on `I`.,Why this change? Is this due to the slowness of pylint?
+3945,"@@ -415,10 +415,15 @@ class AdminController extends Controller
+             ->from($entityClass, 'entity')
+         ;
+
++        $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();
++        $searchQuery = addcslashes($searchQuery, implode('', $wildcards));
++
+         foreach ($searchableFields as $name => $metadata) {
+-            $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();
+-            $searchQuery = addcslashes($searchQuery, implode('', $wildcards));
+-            $query->orWhere('entity.'.$name.' LIKE :query')->setParameter('query', '%'.$searchQuery.'%');
++            if (in_array($metadata['fieldType'], array('text', 'string'))) {
++                $query->orWhere('entity.'.$name.' LIKE :fuzzy_value')->setParameter('fuzzy_value', '%'.$searchQuery.'%');
++            } else {
++                $query->orWhere('entity.'.$name.' = :exact_value')->setParameter('exact_value', $searchQuery);
++            }
+         }
+
+         $paginator = new Pagerfanta(new DoctrineORMAdapter($query, false));",Wouldn't it be better to use a sql `IN ( :exact_value )` ?,Why did you need to change this?
+3946,"@@ -9,9 +9,14 @@ module Bolt
+
+       @shell = shell
+       @endpoint = ""http://#{host}:#{port}/wsman""
+-      @connection = ::WinRM::Connection.new(endpoint: @endpoint,
+-                                            user: @user,
+-                                            password: @password)
++      options = { endpoint: @endpoint,
++                  user: @user,
++                  password: @password }
++      if @timeout then
++        options[:receive_timeout] = @timeout
++        options[:operation_timeout] = @timeout
++      end
++      @connection = ::WinRM::Connection.new(options)
+       @connection.logger = @transport_logger
+     end
+ ",So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior.,I think we want the `receive_timeout` and `operation_ti
+3947,"@@ -68,7 +68,7 @@ class ApacheBenchmarkExecutor(ScenarioExecutor, WidgetProvider, HavingInstallabl
+         return self.widget
+
+     def __first_http_request(self):
+-        for request in self.scenario.get_requests():
++        for request in self.get_requests():
+             if isinstance(request, HTTPRequest):
+                 return request
+         return None","So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way.",So now `self.scenario.get_requests()` will iterate over
+3948,"@@ -2436,10 +2436,10 @@ public:
+ 		}
+ 		else if (message_a.response)
+ 		{
+-			auto node_id (message_a.response->first);
+-			connection->remote_node_id = node_id;
++			nano::account node_id (message_a.response->first);
+ 			if (!connection->node->network.syn_cookies.validate (nano::transport::map_tcp_to_endpoint (connection->remote_endpoint), node_id, message_a.response->second) && node_id != connection->node->node_id.pub)
+ 			{
++				connection->remote_node_id = node_id;
+ 				connection->type = nano::bootstrap_server_type::realtime;
+ 				++connection->node->bootstrap.realtime_count;
+ 				connection->finish_request_async ();","This existed already, but seeing as you are changing the variable to have an explicit type it could be made a const reference to remove a copy.",Please don't make unnecessary changes like this.
+3949,"@@ -0,0 +1,11 @@
++module Faker
++  class FamousLastWords < Base
++    flexible :famous_last_words
++
++    class << self
++      def name
++        fetch('famous_last_words.phrase')
++      end
++    end
++  end
++end",I don't think this code is being tested; this method can be removed without the test failing,I love how this is named. I think it would be be
+3950,"@@ -298,6 +298,11 @@ public class FrameFragment extends BaseEditFragment {
+     // Asynchronous loading of thumbnails
+     private class asyncThumbs extends AsyncTask<Void, Void, Void> {
+
++        @Override
++        protected void onPreExecute() {
++            arrayList=new ArrayList<>();
++        }
++
+         @Override
+         protected Void doInBackground(Void... params) {
+             arrayList = new ArrayList<>();",@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?,what is the purpose of this change?
+3951,"@@ -0,0 +1,13 @@
++describe Gsa18f::ProcurementPolicy do
++  subject { described_class }
++
++  permissions :can_create? do
++    with_feature 'RESTRICT_ACCESS' do
++      it ""doesn't allow someone with a non-GSA email to create"" do
++        user = User.new(email_address: 'intruder@some.com')
++        procurement = Gsa18f::Procurement.new
++        expect(subject).not_to permit(user, procurement)
++      end
++    end
++  end
++end","This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)",I think we should test for the presence of `proc
+3952,"@@ -18,13 +18,13 @@ define(['dom', 'scroller', 'browser', 'layoutManager', 'focusManager', 'register
+
+     function onFocus(e) {
+
+-        if (layoutManager.tv) {
++        /*if (layoutManager.tv) {
+
+             if (this.focusTimeout) {
+                 clearTimeout(this.focusTimeout);
+             }
+             this.focusTimeout = setTimeout(getFocusCallback(this, e), 700);
+-        }
++        }*/
+     }
+
+     function getTabPanel(tabs, index) {","Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process...",This can just be removed.
+3953,"@@ -23,3 +23,10 @@ import (
+ type ConnTrackDumper interface {
+ 	DumpFlows(zoneFilter uint16) ([]*flowexporter.Connection, error)
+ }
++
++// ConnTrackInterfacer is an interface created to consume the required dump functions from either the third party
++// conntrack library or internal packages depending on OVS datapath type or OS.
++type ConnTrackInterfacer interface {
++	GetConnTrack(config interface{}) error // suggest a different name for config if it is not appropriate
++	DumpFilter(filter interface{}) ([]*flowexporter.Connection, error)
++}","I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called ""Get*"" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pretty clear to me that this interface needs to be rethought. An interface where all the parameters are themselves arbitrary objects (`interface{}`), whose actual type depends on the specific interface implementation, is not a helpful abstraction",I do not like the name of
+3954,"@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap;
+ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.Multimap;
+
++import org.openqa.selenium.devtools.target.model.SessionId;
+ import org.openqa.selenium.json.Json;
+ import org.openqa.selenium.json.JsonInput;
+ import org.openqa.selenium.remote.http.HttpClient;",It fills me with endless sadness that we can't use Selenium's own `SessionId` here.,Is this needed?
+3955,"@@ -2269,7 +2269,12 @@ public class ZkStateReader implements SolrCloseable {
+       log.debug(""Checking ZK for most up to date Aliases {}"", ALIASES);
+       // Call sync() first to ensure the subsequent read (getData) is up to date.
+       zkClient.getSolrZooKeeper().sync(ALIASES, null, null);
+-      Stat stat = new Stat();
++      Stat stat = zkClient.exists(ALIASES, null, true);
++      if (stat.getVersion() <= aliases.getZNodeVersion()) {
++        //we already have the latest version.
++        return false;
++      }
++      stat = new Stat();
+       final byte[] data = zkClient.getData(ALIASES, null, stat, true);
+       return setIfNewer(Aliases.fromJSON(data, stat.getVersion()));
+     }","Interesting. So you've found that it's faster to request only the ""Stat"" without the data so long as this is the typical path?",`if (stat.getVersion() >
+3956,"@@ -33,6 +33,7 @@ var skip = map[string]string{
+ 	""yield"":                       ""yield requires special test case (https://github.com/influxdata/flux/issues/535)"",
+ 	""task_per_line"":               ""join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)"",
+ 	""rowfn_with_import"":           ""imported libraries are not visible in user-defined functions (https://github.com/influxdata/flux/issues/1000)"",
++	""string_trim"":                 ""cannot reference a package function from within a row function"",
+ }
+
+ var querier = querytest.NewQuerier()",Is this a future fix? I thought the local identifier scope and the package issue were the same one.,"nit: ""cannot"" -> ""within"""
+3957,"@@ -247,7 +247,17 @@ class TextInfoQuickNavItem(QuickNavItem):
+ class BrowseModeTreeInterceptor(treeInterceptorHandler.TreeInterceptor):
+ 	scriptCategory = inputCore.SCRCAT_BROWSEMODE
+ 	disableAutoPassThrough = False
+-	APPLICATION_ROLES = (controlTypes.ROLE_APPLICATION, controlTypes.ROLE_DIALOG)
++
++	def _isApplicationObject(self,obj):
++		""""""
++		Checks whether the given object in this browseMode treeInterceptor is an application (I.e. although the root of the object is represented in the treeInterceptor, its content is not).
++		I.e. an application or modal dialog.
++		""""""
++		if obj.role==controlTypes.ROLE_APPLICATION:
++			return True
++		elif obj.role==controlTypes.ROLE_DIALOG and controlTypes.STATE_MODAL in obj.states:
++			return True
++		return False
+
+ 	def _get_currentNVDAObject(self):
+ 		raise NotImplementedError","Not super important, but this line could be split up.",Isn't it better to use `o
+3958,"@@ -150,6 +150,17 @@ void h2o_context_dispose(h2o_context_t *ctx)
+     h2o_filecache_destroy(ctx->filecache);
+     ctx->filecache = NULL;
+
++    /* clear storage */
++    for (i = 0; i != ctx->storage.size; ++i) {
++        h2o_context_storage_item_t item = ctx->storage.entries[i];
++        if (item.data != NULL) {
++            if (item.dispose != NULL) {
++                item.dispose(item.data);
++            }
++        }
++    }
++    free(ctx->storage.entries);
++
+     /* TODO assert that the all the getaddrinfo threads are idle */
+     h2o_multithread_unregister_receiver(ctx->queue, &ctx->receivers.hostinfo_getaddr);
+     h2o_multithread_destroy_queue(ctx->queue);",Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up).,Shouldn't this be `ctx->s
+3959,"@@ -33,6 +33,7 @@ inline void SyncedMemory::to_cpu() {
+       CaffeMallocHost(&cpu_ptr_, size_);
+       own_cpu_data_ = true;
+     }
++    Caffe::set_mode(Caffe::GPU);
+     caffe_memcpy(size_, gpu_ptr_, cpu_ptr_);
+     head_ = SYNCED;
+     break;","Why set to GPU, is it CPU?",Why are you setting the m
+3960,"@@ -1,10 +1,16 @@
+ import AppointmentIndexRoute from 'hospitalrun/appointments/index/route';
+ import moment from 'moment';
+ import { translationMacro as t } from 'ember-i18n';
++import Ember from 'ember';
++
++const { computed } = Ember;
++
+ export default AppointmentIndexRoute.extend({
+   editReturn: 'appointments.today',
+   modelName: 'appointment',
+-  pageTitle: t('appointments.todayTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('appointments.todayTitle');
++  }),
+
+   _modelQueryParams() {
+     let endOfDay = moment().endOf('day').toDate().getTime();",This should be `computed('i18n.locale'....`,Is this actually needed? I thought `t('appointments.todayTitle')` returns the string
+3961,"@@ -49,7 +49,7 @@ type Session struct {
+ 	DataTransferred DataTransferred
+ 	TokensEarned    uint64
+ 	Last            bool
+-	done            chan struct{}
++	Done            chan struct{}
+ }
+
+ // newSession creates a blank new session with an ID.",can we not expose the channel directly? or at least expose it as a read only channel?,struct field Done should be Done
+3962,"@@ -88,6 +88,17 @@ AS_IF([test ""$YACC"" != ""bison -y""], [AC_MSG_ERROR([bison not found but required]
+
+ PKG_PROG_PKG_CONFIG
+
++# PKG_CHECK_VAR added to pkg-config 0.28
++m4_define_default(
++    [PKG_CHECK_VAR],
++    [AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])
++     AS_IF([test -z ""$$1""], [$1=`$PKG_CONFIG --variable=""$3"" ""$2""`])
++     AS_IF([test -n ""$$1""], [$4], [$5])])
++
++PKG_CHECK_VAR(bashcompdir, [bash-completion], [completionsdir], ,
++  bashcompdir=""${sysconfdir}/bash_completion.d"")
++AC_SUBST(bashcompdir)
++
+ AM_PATH_GLIB_2_0(,,AC_MSG_ERROR([GLib not found]))
+
+ dnl When bumping the gio-unix-2.0 dependency (or glib-2.0 in general),",Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds.,"couldn't this just be `PKG_CHECK_VAR(bashcompdir, [bashcompletion], [completionsdir]"
+3963,"@@ -0,0 +1,13 @@
++package cstor
++
++import (
++	""github.com/openebs/maya/cmd/cstor-volume-grpc/app/command""
++)
++
++func Snapshot(volName, snapName, targetIP string) (interface{}, error) {
++	return command.CreateSnapshot(volName, snapName, targetIP)
++}
++
++func SnapshotDelete(volName, snapName, targetIP string) (interface{}, error) {
++	return command.DestroySnapshot(volName, snapName, targetIP)
++}",We will be removing this maya/volume package completely. Do not use this.,Copy/paste error on this line.
+3964,"@@ -67,7 +67,7 @@ static train_result call_daal_kernel(const context_gpu& ctx,
+
+     daal::algorithms::classifier::ModelPtr model_ptr(new daal_knn::Model(column_count));
+     if (!model_ptr) {
+-        throw bad_alloc();
++        throw host_bad_alloc();
+     }
+
+     auto knn_model = static_cast<daal_knn::Model*>(model_ptr.get());",Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?,There are a few functions with `throwBad()` and `throw host_bad()` - please make them consistent.
+3965,"@@ -42,14 +42,15 @@ type MinerCreateResult struct {
+
+ var minerCreateCmd = &cmds.Command{
+ 	Helptext: cmdkit.HelpText{
+-		Tagline: ""Create a new file miner with <pledge> sectors and <collateral> FIL"",
++		Tagline: ""Create a new file miner with <collateral> FIL"",
+ 		ShortDescription: `Issues a new message to the network to create the miner, then waits for the
+ message to be mined as this is required to return the address of the new miner.
+-Collateral must be greater than 0.001 FIL per pledged sector.`,
++Collateral will be committed at the rate of 0.001FIL per sector. When the
++miner's collateral drops below 0.001FIL, the miner will not be able to commit
++additional sectors.`,
+ 	},
+ 	Arguments: []cmdkit.Argument{
+-		cmdkit.StringArg(""pledge"", true, false, ""The size of the pledge (in sectors) for the miner""),
+-		cmdkit.StringArg(""collateral"", true, false, ""The amount of collateral in FIL to be sent (minimum 0.001 FIL per sector)""),
++		cmdkit.StringArg(""collateral"", true, false, ""The amount of collateral, in FIL""),
+ 	},
+ 	Options: []cmdkit.Option{
+ 		cmdkit.StringOption(""from"", ""Address to send from""),","Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height.","I think we should keep the word ""pledge"" here"
+3966,"@@ -0,0 +1,5 @@
++# -----------------------------------------------------------------------------
++#                     The CodeChecker Infrastructure
++#   This file is distributed under the University of Illinois Open Source
++#   License. See LICENSE.TXT for details.
++# -----------------------------------------------------------------------------",Please update the license header in each source file. For more information see: #2697,I don't think you need to add `# ----------------------------------------------------------------
+3967,"@@ -144,8 +144,9 @@ class HttpClient {
+  * @param {function(!Error)} onError The function to call if the request fails.
+  * @param {?string=} opt_data The data to send with the request.
+  * @param {?RequestOptions=} opt_proxy The proxy server to use for the request.
++ * @param {!number=} retries The current number of retries.
+  */
+-function sendRequest(options, onOk, onError, opt_data, opt_proxy) {
++function sendRequest(options, onOk, onError, opt_data, opt_proxy, retries) {
+   var hostname = options.hostname;
+   var port = options.port;
+ ",!numbers -> numbers,@dvoytenko @jridgewell @jridgewell @jridgewell @lannka how do you feel about making this an enum
+3968,"@@ -64,6 +64,6 @@ namespace AutoRest.Swagger.Validation.Core
+         /// <summary>
+         /// The collection of rules that apply to all properties regardless of other rules.
+         /// </summary>
+-        public static IEnumerable<Rule> UniversalRules = new[] { new NoControlCharacters() };
++        public static IEnumerable<Rule> UniversalRules = new List<Rule>();
+     }
+ }","so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about ""universal"". In case of this rule, even control characters may have their place in Swaggers, e.g. in `examples` sections where you can have raw response bodies where control characters are perfectly valid.",@aparajit-pratap @mjkkirschner @QilongTang @sm6srw seems we no longer need this `NoControlCharacters` class?
+3969,"@@ -115,7 +115,8 @@ module.exports = function exec(command, opt_options) {
+
+   var proc = childProcess.spawn(command, options.args || [], {
+     env: options.env || process.env,
+-    stdio: options.stdio || 'ignore'
++    stdio: options.stdio || 'ignore',
++    detached: true
+   });
+
+   // This process should not wait on the spawned child, however, we do","You're welcome to surface this option through the API, but I'm not going to make this the default behavior.",Why is this necessary?
+3970,"@@ -76,10 +76,10 @@ func buildBinary(source, target string) error {
+ 	if !ok {
+ 		targetArch = runtime.GOARCH
+ 	}
+-	return buildBinaryFor(source, target, targetOS, targetArch)
++	return buildBinaryFor(source, target, targetOS, targetArch, false)
+ }
+
+-func buildBinaryFor(source, target, targetOS, targetArch string) error {
++func buildBinaryFor(source, target, targetOS, targetArch string, buildStatic bool) error {
+ 	log.Info().Msgf(""Building %s -> %s %s/%s"", source, target, targetOS, targetArch)
+
+ 	buildDir, err := filepath.Abs(path.Join(""build"", target))","Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability.",I wonder if we should introduce an options struct for this instead of hardcoding the false here.
+3971,"@@ -44,8 +44,11 @@ namespace OpenTelemetry.Metrics
+
+             var options = new InMemoryExporterOptions();
+             configure?.Invoke(options);
+-            var exporter = new InMemoryMetricExporter(exportedItems, options);
+-            return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));
++
++            // var exporter = new InMemoryMetricExporter(exportedItems, options);
++            // return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));
++
++            return builder;
+         }
+     }
+ }",I'll fix the InMemoryExporter right after this PR lands,Can we just delete the code if we don't need it?
+3972,"@@ -11098,7 +11098,7 @@ bool CoreChecks::ValidateCreateSwapchain(const char *func_name, VkSwapchainCreat
+
+     auto physical_device_state = GetPhysicalDeviceState();
+     if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) {
+-        if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
++        if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
+                     HandleToUint64(physical_device), kVUID_Core_DrawState_SwapchainCreateBeforeQuery,
+                     ""%s: surface capabilities not retrieved for this physical device"", func_name))
+             return true;","Good call, none of these are technically invalid",Should this be an error not a warning?
+3973,"@@ -20,7 +20,7 @@ partial class Build
+         .OnlyWhenStatic(() => IsWin)
+         .Executes(() =>
+         {
+-            var project = ProfilerDirectory.GlobFiles(""**/Datadog.AutoInstrumentation.Profiler.Native.Windows.vcxproj"").Single();
++            var project = ProfilerDirectory.GlobFiles(""**/Datadog.Profiler.Native.Windows.vcxproj"").Single();
+
+             // run: msbuild /property:Configuration=${{matrix.configuration}} /property:Platform=${{matrix.platform}}  dd-continuous-profiler-dotnet\src\ProfilerEngine\Datadog.AutoInstrumentation.Profiler.Native.Windows\Datadog.AutoInstrumentation.Profiler.Native.Windows.WithTests.proj
+             // If we're building for x64, build for x86 too",this one should be updated too,Can you revert the Windows file change
+3974,"@@ -39,6 +39,7 @@ public final class InvocationFactory {
+         operationMeta,
+         swaggerArguments);
+     invocation.addContext(Const.SRC_MICROSERVICE, getMicroserviceName());
++    invocation.addContext(Const.SRC_INSTANCE, getInstanceId());
+     return invocation;
+   }
+ ",maybe need to add microserviceId too.,Shouldn't this be done in a constant s
+3975,"@@ -0,0 +1,6 @@
++""""""Tests for missing-param-doc and missing-type-doc for Numpy style docstrings
++with accept-no-param-doc = no
++""""""
++# pylint: disable=invalid-name, unused-argument, undefined-variable
++# pylint: disable=line-too-long, too-few-public-methods, missing-class-docstring
++# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements","I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything ?",I think this is missing a `# noqa: no-
+3976,"@@ -939,12 +939,10 @@ describe('Core_alter', () => {
+       expect(spec().$container.find('tr:eq(6) td:eq(0)').html()).toEqual('b1');
+     });
+
+-    it('should not add more source rows than defined in maxRows when trimming rows using the modifyRow hook', () => {
++    it('should not add more source rows than defined in maxRows when trimming rows using the TrimRows plugin', () => {
+       const hot = handsontable({
+         data: Handsontable.helper.createSpreadsheetData(10, 4),
+-        modifyRow(row) {
+-          return [8, 9].indexOf(row) > -1 ? null : row;
+-        },
++        trimRows: [8, 9],
+         maxRows: 10
+       });
+ ",It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`.,I think this and the next unit test should be changed to `should not add more rows than defined in maxRows when trimming rows using the TrimRows plugin`
+3977,"@@ -688,6 +688,17 @@ static int on_config_mime_setdefaulttype(h2o_configurator_command_t *cmd, h2o_co
+     return 0;
+ }
+
++static const char *get_ext(h2o_configurator_command_t *cmd, yoml_t *node)
++{
++    if (strcmp(node->data.scalar, ""default"") == 0) {
++        return node->data.scalar;
++    } else if  (assert_is_extension(cmd, node) == 0) {
++        return node->data.scalar + 1;
++    } else {
++        return NULL;
++    }
++}
++
+ static int on_config_custom_handler(h2o_configurator_command_t *cmd, h2o_configurator_context_t *ctx, yoml_t *node)
+ {
+     static const char *ignore_commands[] = {""extension"", NULL};","The function seems to either return ""default"" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?",This should probably be a static function in h2o_configurator.c like the one above.
+3978,"@@ -110,6 +110,8 @@ type Container struct {
+ 	Image string
+ 	// ImageID is the local ID of the image used in the container
+ 	ImageID string
++	// ImageDigest is the sha-256 digest of the container image as pulled from the repository
++	ImageDigest string
+ 	// Command is the command to run in the container which is specified in the task definition
+ 	Command []string
+ 	// CPU is the cpu limitation of the container which is specified in the task definition",this may require a statefile version update,This should be `ImageID` rather than `ImageDigest`.
+3979,"@@ -4,6 +4,9 @@ namespace Shopsys\FrameworkBundle\Component\Csv;
+
+ use Symfony\Component\Filesystem\Exception\FileNotFoundException;
+
++/**
++ * @deprecated Class is obsolete and will be removed in the next major. Use SplFileObject::fgetcsv() instead.
++ */
+ class CsvReader
+ {
+     /**","I like when `@deprecated` contains how to resolve it - eg. ""use `SplFileObject::fgetcsv()` instead"". The information in upgrade notes is usefull only during upgrade.",IMO `@deprecated` is better than `@deprecated`.
+3980,"@@ -7,8 +7,8 @@ package mock
+ import (
+ 	gomock ""github.com/golang/mock/gomock""
+ 	gcpclient ""github.com/openshift/hive/pkg/gcpclient""
+-	v1 ""google.golang.org/api/compute/v1""
+-	v10 ""google.golang.org/api/dns/v1""
++	compute ""google.golang.org/api/compute/v1""
++	dns ""google.golang.org/api/dns/v1""
+ 	reflect ""reflect""
+ )
+ ",Nice to see that your local environment is up-to-date now for these changes.,@smarterclayton is this import still needed?
+3981,"@@ -1268,7 +1268,13 @@ var AppRouter = Backbone.Router.extend({
+         }
+
+         // Init sidebar based on the current url
+-        self.sidebar.init();
++        if (countlyVue.sideBarComponent) {
++            var selectedMenuItem = countlyVue.sideBarComponent.$store.getters[""countlySidebar/getSelectedMenuItem""];
++            var currLink = ""#"" + Backbone.history.fragment;
++            if (selectedMenuItem.item.url !== currLink) {
++                countlyVue.sideBarComponent.$store.dispatch(""countlySidebar/updateSelectedMenuItem"", null);
++            }
++        }
+     },
+     sidebar: {
+         init: function() {","Instead of setting it to null, i think lets set it to {}",should we use `self.sidebar.init` here too?
+3982,"@@ -23,8 +23,8 @@ import (
+ )
+
+ const (
+-	TPRGroup   = ""monitoring.coreos.com""
+-	TPRVersion = ""v1alpha1""
++	Group   = ""monitoring.coreos.com""
++	Version = ""v1alpha1""
+ )
+
+ type MonitoringV1alpha1Interface interface {","We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the ""alpha"" stamp.",group > version?
+3983,"@@ -59,6 +59,15 @@ AS_CASE($ax_cv_cxx_compiler_vendor,
+ AX_CXX_COMPILE_STDCXX([11], [noext], [mandatory])
+
+ X_AC_ENABLE_SANITIZER
++if test ""x$san_enabled"" != ""xno"" ; then
++  AC_DEFINE([DEEPBIND], [0],
++            [deepbind is unsupported with asan, musl and so-forth])
++else
++  AC_DEFINE([DEEPBIND], [RTLD_DEEPBIND],
++            [deepbind is unsupported with asan, musl and so-forth])
++fi
++
++
+ LT_INIT
+ AC_PROG_AWK
+ ",I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define.,"looks like there is a syntax error here, the"
+3984,"@@ -393,7 +393,7 @@ func init() {
+ 	proto.RegisterType((*StatusResponse)(nil), ""bpfki.StatusResponse"")
+ }
+
+-func init() { proto.RegisterFile(""bpfki.proto"", fileDescriptor_62eed357eb71de0e) }
++func init() { protoregistry.GlobalFiles.RegisterFile(""bpfki.proto"", fileDescriptor_62eed357eb71de0e) }
+
+ var fileDescriptor_62eed357eb71de0e = []byte{
+ 	// 518 bytes of a gzipped FileDescriptorProto",Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file.,Is there a better name than `bpfki.proto`?
+3985,"@@ -15,6 +15,7 @@ import java.util.List;
+  *
+  * @author Brian Remedios
+  */
++@Deprecated
+ public class IntegerPropertyTest extends AbstractNumericPropertyDescriptorTester<Integer> {
+
+     private static final int MIN = 1;",We should make sure that we cover the testcases in a new unit test class.,What is the difference between this and `M
+3986,"@@ -0,0 +1,19 @@
++package proofs
++
++// #cgo LDFLAGS: -L${SRCDIR}/../proofs/lib -lfilecoin_proofs
++// #cgo pkg-config: ${SRCDIR}/../proofs/lib/pkgconfig/libfilecoin_proofs.pc
++// #include ""../proofs/include/libfilecoin_proofs.h""
++import ""C""
++import (
++	""unsafe""
++)
++
++func SectorSize(ssType Mode) uint64 {
++	scfg, err := CProofsMode(ssType)
++	if err != nil {
++		return 0
++	}
++
++	numFromC := C.get_max_user_bytes_per_staged_sector((*C.ConfiguredStore)(unsafe.Pointer(scfg)))
++	return uint64(numFromC)
++}","Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser",Should this be using `get_max_user_bytes_p
+3987,"@@ -192,7 +192,7 @@ func (p *Plugin) setConfig(config *pluginConfig) error {
+ 		p.cancelWatcher()
+ 		p.cancelWatcher = nil
+ 	}
+-	if config.WebhookLabel != """" {
++	if config.WebhookLabel != """" || config.APIServiceLabel != """" {
+ 		p.cancelWatcher = cancelWatcher
+ 	}
+ ","Super curious how you noticed this, as SPIRE itself currently only configures once...?",Does it make sense to also check APIServic
+3988,"@@ -21,11 +21,18 @@ public class NotFoundExceptionHandler implements ExceptionMapper<NotFoundExcepti
+     @Override
+     public Response toResponse(NotFoundException ex){
+         String uri = request.getRequestURI();
++        String exMessage = ex.getMessage();
++        String outputMessage;
++        if (exMessage != null && exMessage.startsWith(""Datafile"")) {
++            outputMessage = exMessage;
++        } else {
++            outputMessage = ""endpoint does not exist on this server. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."";
++        }
+         return Response.status(404)
+                 .entity( Json.createObjectBuilder()
+                              .add(""status"", ""ERROR"")
+                              .add(""code"", 404)
+-                             .add(""message"", ""'"" + uri + ""' endpoint does not exist on this server. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."")
++                             .add(""message"", ""'"" + uri + ""' "" + outputMessage)
+                         .build())
+                 .type(""application/json"").build();
+         ","This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it ""DataFile"".","We can simplify this message to: `""endpoint does not exist on this server. Please check your code for typos.""`"
+3989,"@@ -18,5 +18,6 @@ package azkaban.db;
+
+ public class AzDBUtil {
+
+-  static final int MAX_DB_RETRY_COUNT = 5;
++  // A very big Integer
++  static final int MAX_DB_RETRY_COUNT = 999999;
+ }","if it keeps reconnecting for too long, how should we get alerted?",What's the rationale for this change?
+3990,"@@ -263,7 +263,11 @@ void* CNSKListenerSrvr::OpenTCPIPSession()
+ //LCOV_EXCL_STOP
+ 	}
+
+-
++    TCP_SetKeepalive(nSocketFnum,
++            srvrGlobal->clientKeepaliveStatus,
++            srvrGlobal->clientKeepaliveIdletime,
++            srvrGlobal->clientKeepaliveIntervaltime,
++            srvrGlobal->clientKeepaliveRetrycount);
+ 	pnode = GTransport.m_TCPIPSystemSrvr_list->ins_node(nSocketFnum);
+
+ 	if (pnode == NULL)",it's better to use single name style in one name.,(style) code indent should use tabs where possible
+3991,"@@ -70,7 +70,7 @@ bool EprosimaServer::init()
+ {
+ 	//CREATE RTPSParticipant
+ 	ParticipantAttributes PParam;
+-	PParam.rtps.defaultSendPort = 10042;
++	//PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
+ 	PParam.rtps.builtin.domainId = 80;
+ 	PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
+ 	PParam.rtps.builtin.use_SIMPLE_RTPSParticipantDiscoveryProtocol = true;","As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line",Is this needed now that we have defaultSendPort?
+3992,"@@ -95,7 +95,8 @@ func (cf CloudFormation) DelegateDNSPermissions(project *archer.Project, account
+ 	deployProject.DNSDelegationAccounts = append(dnsDelegatedAccounts, accountID)
+ 	updatedProjectConfig := stack.NewProjectStackConfig(&deployProject)
+
+-	if err := cf.update(updatedProjectConfig); err != nil {
++	// swallow the errChangeSetEmpty error since it just means there were no updates needed.
++	if err := cf.update(updatedProjectConfig); err != nil && err != errChangeSetEmpty {
+ 		return fmt.Errorf(""updating project to allow DNS delegation: %w"", err)
+ 	}
+ ",Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?,Wondering if we should just swallow the `errChangeSetEmpty` error here instead of swallowing it.
+3993,"@@ -153,13 +153,12 @@ public abstract class VectorWriter implements Closeable {
+     private final DocIDMerger<VectorValuesSub> docIdMerger;
+     private final int[] ordBase;
+     private final int cost;
+-    private final int size;
++    private int size;
+
+     private int docId;
+     private VectorValuesSub current;
+-    // For each doc with a vector, record its ord in the segments being merged. This enables random
+-    // access into the
+-    // unmerged segments using the ords from the merged segment.
++    /* For each doc with a vector, record its ord in the segments being merged. This enables random access into the unmerged segments using the ords from the merged segment.
++     */
+     private int[] ordMap;
+     private int ord;
+ ","Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it",Why not keep this final?
+3994,"@@ -47,10 +47,11 @@ type Selector struct {
+
+ // SpiffeIDSpec defines the desired state of SpiffeID
+ type SpiffeIDSpec struct {
+-	ParentId string   `json:""parentId""`
+-	SpiffeId string   `json:""spiffeId""`
+-	Selector Selector `json:""selector""`
+-	DnsNames []string `json:""dnsNames,omitempty""`
++	ParentId      string   `json:""parentId""`
++	SpiffeId      string   `json:""spiffeId""`
++	Selector      Selector `json:""selector""`
++	DnsNames      []string `json:""dnsNames,omitempty""`
++	FederatesWith []string `json:""federatesWith,omitempty""`
+ }
+
+ // SpiffeIDStatus defines the observed state of SpiffeID","I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?",Can we change this to `FederateWith`?
+3995,"@@ -215,13 +215,12 @@ public abstract class RSSceneMixin implements RSScene
+
+ 		for (int z = minLevel; z < maxY; ++z)
+ 		{
+-			RSTile[][] planeTiles = tiles[z];
+
+ 			for (int x = minTileX; x < maxTileX; ++x)
+ 			{
+ 				for (int y = minTileZ; y < maxTileZ; ++y)
+ 				{
+-					RSTile tile = planeTiles[x][y];
++					RSTile tile = tiles[z][x][y];
+ 					if (tile != null)
+ 					{
+ 						if (tile.getPhysicalLevel() <= plane",revert this for parity,Another bug that was fixed by this PR.
+3996,"@@ -15,6 +15,10 @@
+ #include <valgrind/helgrind.h>
+ #endif
+
++#define INITIAL_BATCH 100
++#define INCR_BATCH 50
++#define DECR_BATCH 25
++
+ enum
+ {
+   FLAG_BLOCKED = 1 << 0,","INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where ""in the know"" folks could use to try and tune makes sense. These values were choosen mostly ""at random"" and have worked out for us thus far.","The initial batch size is `MAX_INCR_BATCH`, not `MAX_BATCH`."
+3997,"@@ -27,6 +27,11 @@ static tagWriter *writerTable [WRITER_COUNT] = {
+
+ static tagWriter *writer;
+
++extern void setCustomTagWriter(tagWriter *w)
++{
++	writer = w;
++}
++
+ extern void setTagWriter (writerType wtype)
+ {
+ 	writer = writerTable [wtype];",Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type.,This should probably be static.
+3998,"@@ -1,6 +1,7 @@
+ module RequestSpecHelper
+   def get_json(url)
+     get(url)
++    puts response.pretty_inspect
+     JSON.parse(response.body)
+   end
+ ",I think this was left it accidentally :),Looks like this was left in by mistake?
+3999,"@@ -64,12 +64,12 @@ func IsNamespaceSupported(ns NamespaceType) bool {
+
+ func NamespaceTypes() []NamespaceType {
+ 	return []NamespaceType{
++		NEWUSER, // Keep user NS always first, don't move it.
++		NEWIPC,
++		NEWUTS,
+ 		NEWNET,
+ 		NEWPID,
+ 		NEWNS,
+-		NEWUTS,
+-		NEWIPC,
+-		NEWUSER,
+ 	}
+ }
+ ",Can you finish re-ordering this list to match the one that was deleted?,I don't think we need `NEWNET` here.
+4000,"@@ -342,6 +342,10 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo) error {
+ 		chaos.Spec.Duration = &exp.Scheduler.Duration
+ 	}
+
++	if exp.Target.StressChaos.ContainerName != nil {
++		chaos.Spec.ContainerName = exp.Target.StressChaos.ContainerName
++	}
++
+ 	return s.kubeCli.Create(context.Background(), chaos)
+ }
+ ",Do we need to check if `exp.Target.StressChaos` is `nil`?,Why do we need this?
+4001,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[CreateAccessKey.java demonstrates how to create an access key for an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[CreateAccessKey.java demonstrates how to create an access key for an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),Doesn't this need a
+4002,"@@ -110,7 +110,6 @@ spec:
+   run:
+     tasks:
+     - cstor-volume-create-getstorageclass-default
+-    - cstor-volume-create-getpvc-default
+     - cstor-volume-create-listclonecstorvolumereplicacr-default
+     - cstor-volume-create-listcstorpoolcr-default
+     - cstor-volume-create-puttargetservice-default",not calling this is going to impact current functionality which depends on PVC.. let us still call this and set the values to default as 'none' (or empty) by handling the error from 'get' operation,Why did we need to r
+4003,"@@ -306,7 +306,9 @@ int ioctl(int fd, unsigned long request, ...)
+ 			if (gEnableIRQ && fme_irq->evtfd >= 0) {
+ 				uint64_t data = 1;
+ 				// Write to the eventfd to signal one IRQ event.
+-				write(fme_irq->evtfd, &data, sizeof(data));
++				if (write(fme_irq->evtfd, &data, sizeof(data)) != sizeof(data)) {
++					FPGA_ERR(""IRQ write < 8 bytes"");
++				}
+ 			}
+ 			retval = 0;
+ 			errno = 0;",`!=` is no the same as `<`,This should be `FPGA
+4004,"@@ -0,0 +1,8 @@
++from .transformer import (FFN, MultiheadAttention, Transformer,
++                          TransformerDecoder, TransformerDecoderLayer,
++                          TransformerEncoder, TransformerEncoderLayer)
++
++__all__ = [
++    'FFN', 'MultiheadAttention', 'Transformer', 'TransformerDecoder',
++    'TransformerDecoderLayer', 'TransformerEncoder', 'TransformerEncoderLayer'
++]",No need to create a dir for transformer. Simply move transformer.py into mmdet/models/utils/,Please add a trailing comma
+4005,"@@ -531,6 +531,10 @@ public class MainActivity extends CastEnabledActivity {
+             bottomSheetCallback.onSlide(null, 1.0f);
+         } else if (Intent.ACTION_VIEW.equals(intent.getAction())) {
+             handleDeeplink(intent.getData());
++        } else if (Intent.ACTION_CREATE_SHORTCUT.equals(intent.getAction())) {
++            intent = new Intent(this, SelectSubscriptionActivity.class);
++            intent.setAction(Intent.ACTION_CREATE_SHORTCUT);
++            startActivity(intent);
+         }
+         // to avoid handling the intent twice when the configuration changes
+         setIntent(new Intent(MainActivity.this, MainActivity.class));",Can't you just add `SelectSubscriptionActivity` directly to the manifest instead of opening `MainActivity` that then starts it?,It would be nice to have a
+4006,"@@ -46,6 +46,7 @@ var (
+ 	rpmsDir   = app.Flag(""rpm-dir"", ""Directory containing built RPMs."").Required().ExistingDir()
+ 	distTag   = app.Flag(""dist-tag"", ""The distribution tag the SPEC will be built with."").Required().String()
+ 	workerTar = app.Flag(""worker-tar"", ""Full path to worker_chroot.tar.gz.  If this argument is empty, specs will be parsed in the host environment."").ExistingFile()
++	runCheck  = app.Flag(""run-check"", ""Run the check during package build"").Bool()
+ 	logFile   = exe.LogFileFlag(app)
+ 	logLevel  = exe.LogLevelFlag(app)
+ )","Maybe say ""the spec's %check section"" so it's clearer what we mean.",Maybe just call it `checkCh
+4007,"@@ -649,7 +649,7 @@ class ColumnSorting extends BasePlugin {
+    * @returns {Number} Physical row index.
+    */
+   onModifyRow(row, source) {
+-    if (this.blockPluginTranslation === false && source !== this.pluginName) {
++    if (this.blockPluginTranslation === false && source !== this.pluginName && this.isSorted()) {
+       const rowInMapper = this.rowsMapper.getValueByIndex(row);
+       row = rowInMapper === null ? row : rowInMapper;
+     }","I think after change this check `rowInMapper === null` is always false, so it's useless.",@jridgewell Is this change
+4008,"@@ -166,7 +166,7 @@ func initClocks() {
+ 	nxp.ClockIpLpi2c2.Enable(false) //
+ 	nxp.ClockIpLpi2c3.Enable(false) //
+ 	nxp.DivIpLpi2c.Div(0)           // divide LPI2C_CLK_PODF (DIV1)
+-	nxp.MuxIpLpi2c.Mux(0)           // LPI2C select PLL3_SW_60M
++	nxp.MuxIpLpi2c.Mux(1)           // LPI2C select OSC
+
+ 	nxp.ClockIpCan1.Enable(false)  // disable CAN
+ 	nxp.ClockIpCan2.Enable(false)  //",ClockIpLpi2c4.Enable() is required. The same change is required for enablePeripheralClocks().,why did you change this?
+4009,"@@ -67,6 +67,9 @@ type PrometheusSpec struct {
+ 	Version string `json:""version,omitempty""`
+ 	// Tag of Prometheus container image to be deployed. Defaults to the value of `version`.
+ 	Tag string `json:""tag,omitempty""`
++	// Sha of Prometheus container image to be deployed. Defaults to the value of `version`.
++	// Similar to a tag, but the sha explicitly deploys an immutable container image.
++	Sha string `json:""sha,omitempty""`
+ 	// When a Prometheus deployment is paused, no actions except for deletion
+ 	// will be performed on the underlying objects.
+ 	Paused bool `json:""paused,omitempty""`","nit: this should be `SHA` since it is an acronym for `Secure Hash Algorithm`, no?",The `sha` should not be
+4010,"@@ -27,6 +27,13 @@ import jstz from 'jstz'
+  * @returns {String} Current timezone of user
+  */
+ export default () => {
++	if (window.Intl && typeof window.Intl === 'object') {
++		const { timeZone } = Intl.DateTimeFormat().resolvedOptions()
++		if (timeZone) {
++			return timeZone
++		}
++	}
++
+ 	const determinedTimezone = jstz.determine()
+ 	if (!determinedTimezone) {
+ 		return 'UTC'",Not sure if Intl can be defined but not `Intl.DateTimeFormat`. Both seem to have the same percentage on CanIUse.,Isn't `typeof window.Int
+4011,"@@ -121,7 +121,7 @@ func (p *Provisioner) Provision(opts pvController.VolumeOptions) (*v1.Persistent
+ 	if reqMap != nil {
+ 		size = pvc.Spec.Resources.Requests[""storage""]
+ 	}
+-	sendEventOrIgnore(name, size.String(), stgType, analytics.VolumeProvision)
++	sendEventOrIgnore(pvc.Name, name, size.String(), stgType, analytics.VolumeProvision)
+ 	if stgType == ""hostpath"" {
+ 		return p.ProvisionHostPath(opts, pvCASConfig)
+ 	}","PTAL, looks like the order of PVC & PV is reversed for different storage-engine types, for Jiva/CStor the args sent to sendEventOrIgnore are `PV, PVCName`.",This is the only place w
+4012,"@@ -65,7 +65,7 @@ import vn.mbm.phimp.me.utils.RSSPhotoItem_Personal;
+ @SuppressWarnings(""deprecation"")
+ public class PhimpMe extends AppCompatActivity implements BottomNavigationView.OnNavigationItemSelectedListener //, android.view.GestureDetector.OnGestureListener
+ {
+-    public static Context ctx;
++    public static Context ctx ;
+     public static File DataDirectory;
+     public static final String PREFS_NAME = ""PhimpMePrefs"";
+     public static final String DATABASE_NAME = ""PhimpMe"";",Remove the trailing white space,Looks like this file doesn't have anything to do with this PR
+4013,"@@ -21,7 +21,7 @@ mmcv_version = digit_version(mmcv.__version__)
+
+
+ assert (mmcv_version >= digit_version(mmcv_minimum_version)
+-        and mmcv_version <= digit_version(mmcv_maximum_version)), \
++        and mmcv_version < digit_version(mmcv_maximum_version)), \
+     f'MMCV=={mmcv.__version__} is used but incompatible. ' \
+     f'Please install mmcv>={mmcv_minimum_version}, <={mmcv_maximum_version}.'
+ ",No need to modify this.,The `mmcv_version < digit_version(mmcv_maximum_version)` cond
+4014,"@@ -14,7 +14,7 @@ import (
+ 	madns ""github.com/multiformats/go-multiaddr-dns""
+ )
+
+-func Discover(ctx context.Context, addr ma.Multiaddr, f func(ma.Multiaddr) (stop bool, err error)) (stopped bool, err error) {
++func Discover(ctx context.Context, addr ma.Multiaddr, f func(ma.Multiaddr) (bool, error)) (bool, error) {
+ 	if comp, _ := ma.SplitFirst(addr); comp.Protocol().Name != ""dnsaddr"" {
+ 		return f(addr)
+ 	}",would be nice at some point to clean this signature up... not relevant for this PR,why are we changing the return type here?
+4015,"@@ -342,6 +342,12 @@ class Configurator
+                     ),
+                     $fieldConfiguration
+                 );
++
++                // if the 'type' is not set explicitly for a virtual field,
++                // consider it as a string, so the backend displays its contents
++                if (null === $normalizedConfiguration['type']) {
++                    $normalizedConfiguration['type'] = 'text';
++                }
+             } else {
+                 // this is a regular field that exists as a property of the related Doctrine entity
+                 $normalizedConfiguration = array_replace(","Here, is it `null` because it is `null` in `$fieldConfiguration`, or because it has been set to `null` above in the `array_replace` ? If it doesn't exists at all in `$fieldConfiguration`, I think you should add `type => 'text'` above in the `array_replace`.",Shouldn't this be in the `else` block?
+4016,"@@ -620,7 +620,7 @@ public class JavaParserFacade {
+      * references an outer class -- as its ancestor, return the declaration corresponding to the class name specified.
+      */
+     protected Node findContainingTypeDeclOrObjectCreationExpr(Node node, String className) {
+-        if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().equals(className)) {
++        if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().endsWith(className)) {
+             return node;
+         }
+         if (node instanceof EnumDeclaration) {","I was thinking about this for #2928 too, which also uses `endsWith`... Presumably `SomeOtherObject` would match `endsWith(""Object"")`, meaning that something more sophisticated like splitting it then iterating right to left would be needed in order to do this robustly?",Can't you use `endsWith(className)`?
+4017,"@@ -51,5 +51,15 @@ namespace OpenTelemetry.Exporter.Zipkin
+         /// </summary>
+         public int? MaxPayloadSizeInBytes { get; set; } = DefaultMaxPayloadSizeInBytes;
+ #endif
++
++        /// <summary>
++        /// Gets or sets the exporter type for Zipkin Exporter.
++        /// </summary>
++        public ExporterType ExporterType { get; set; } = ExporterType.BatchExportProcessor;
++
++        /// <summary>
++        /// Gets or sets get or sets the BatchExportProcessor options.
++        /// </summary>
++        public BatchExportProcessorOptions BatchExportProcessorOptions { get; set; } = new BatchExportProcessorOptions();
+     }
+ }","I think this name is a bit confusing because if you asked someone what type of exporter they were using they would probably say Zipkin or Jaeger, etc. How about `ProcessorType` with `Simple` and `Batch` definitions?",Is this supposed to be part of this
+4018,"@@ -95,6 +95,12 @@ func (a *FakeWebAPI) RegisterPiped(ctx context.Context, req *webservice.Register
+ 	}, nil
+ }
+
++func (a *FakeWebAPI) RecreatePipedKey(ctx context.Context, req *webservice.RecreatePipedKeyRequest) (*webservice.RecreatePipedKeyResponse, error) {
++	return &webservice.RecreatePipedKeyResponse{
++		Key: ""9bf9752a-54a2-451a-a541-444add56f96b"",
++	}, nil
++}
++
+ func (a *FakeWebAPI) EnablePiped(ctx context.Context, req *webservice.EnablePipedRequest) (*webservice.EnablePipedResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`req` is unused in RecreatePipedKey,The piped key was not updated in the
+4019,"@@ -85,11 +85,11 @@ export default function SetupAccountApproved() {
+ 			__( 'Site Kit detected AdSense code for a different account %s on your site. For a better ads experience, you should remove AdSense code that’s not linked to this AdSense account.', 'google-site-kit' ),
+ 			parseAccountID( existingTag )
+ 		);
+-		uncheckedMessage = __( 'By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.', 'google-site-kit' );
++		uncheckedMessage = __( 'Please note that Adsense will not show ads on your website unless you’ve already placed the code.', 'google-site-kit' );
+ 	} else {
+ 		// No existing tag.
+ 		showProfile = false;
+-		uncheckedMessage = __( 'By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.', 'google-site-kit' );
++		uncheckedMessage = __( 'Please note that Adsense will not show ads on your website unless you’ve already placed the code.', 'google-site-kit' );
+ 	}
+
+ 	return (","The ""Adsense"" term needs to be capitalized - I just noticed this was wrong through ACs and IB, so not a problem of the PR itself really. I'll quickly fix it.",Could you add a period at the end of
+4020,"@@ -45,11 +45,15 @@ func init() {
+ 	beam.RegisterFunction(defToDecorPiece)
+ 	beam.RegisterFunction(fileToDecorPiece)
+ 	beam.RegisterFunction(groupCrossRefs)
++	beam.RegisterFunction(groupEdges)
+ 	beam.RegisterFunction(keyByPath)
+ 	beam.RegisterFunction(keyRef)
+ 	beam.RegisterFunction(moveSourceToKey)
+ 	beam.RegisterFunction(nodeToDecorPiece)
++	beam.RegisterFunction(nodeToEdges)
++	beam.RegisterFunction(nodeToReverseEdges)
+ 	beam.RegisterFunction(refToDecorPiece)
++	beam.RegisterFunction(reverseEdge)
+ 	beam.RegisterFunction(toDefinition)
+ 	beam.RegisterFunction(toEnclosingFile)
+ 	beam.RegisterFunction(toFiles)",do which methods need to be registered? is it basically just the ones that are directly referenced in ParDo calls? (The Beam GoDoc doesn't say anything about it. :/ ),Add a TODO(BEAM-1833) to get rid of these.
+4021,"@@ -143,7 +143,8 @@ public class Access extends AbstractApiBean {
+
+         downloadInstance.setFileCitationEndNote(datasetService.createCitationXML(datasetVersion, fileMetadata));
+         downloadInstance.setFileCitationRIS(datasetService.createCitationRIS(datasetVersion, fileMetadata));
+-
++        downloadInstance.setFileCitationBibtex(datasetService.createCitationBibtex(datasetVersion, fileMetadata));
++
+         ByteArrayOutputStream outStream = null;
+         outStream = new ByteArrayOutputStream();
+ ",@bmckinney does this mean that the bibtex citation will be available via API?,Please rename to `setFileCitationBibtex`.
+4022,"@@ -28,11 +28,11 @@ if sys.version_info < (3,):
+     ])
+
+ POSTGRESQL_REQUIREMENTS = REQUIREMENTS + [
+-    'cliquet[postgresql]>=2.14,<3'
++    'cliquet[postgresql]>=2.15,<3'
+ ]
+
+ MONITORING_REQUIREMENTS = REQUIREMENTS + [
+-    'cliquet[monitoring]>=2.14,<3'
++    'cliquet[monitoring]>=2.15,<3'
+ ]
+
+ FXA_REQUIREMENTS = REQUIREMENTS + [",We should probably tag the cliquet-fxa version as well.,I think we should keep the `MONITORING_REQ
+4023,"@@ -317,7 +317,7 @@ static socklen_t parse_hostport(h2o_mem_pool_t *pool, h2o_iovec_t host, h2o_iove
+                 4 &&
+             parsed_len == host.len && d1 <= UCHAR_MAX && d2 <= UCHAR_MAX && d3 <= UCHAR_MAX && d4 <= UCHAR_MAX) {
+             if (sscanf(port.base, ""%"" SCNd32 ""%n"", &_port, &parsed_len) == 1 && parsed_len == port.len && _port <= USHRT_MAX) {
+-                struct sockaddr_in sin;
++                struct sockaddr_in sin = {};
+                 sin.sin_family = AF_INET;
+                 sin.sin_port = htons(_port);
+                 sin.sin_addr.s_addr = ntohl((d1 << 24) + (d2 << 16) + (d3 << 8) + d4);","IIRC we need to use memset, because an empty brace is not C99 comformant, and because we cannot use `{0}` because how the struct is organized is not defined in POSIX (the initializer cannot be `{0}` if the first property of the struct is a struct).",Are you sure about this change? We don't w
+4024,"@@ -434,6 +434,11 @@ type NetworkPolicyPeer struct {
+ 	//  Exact FQDNs, i.e. ""google.com"", ""db-svc.default.svc.cluster.local""
+ 	//  Wildcard expressions, i.e. ""*wayfair.com"".
+ 	FQDN string `json:""fqdn,omitempty""`
++	// Select all Pods with the ServiceAccount matched by this field, as
++	// workloads in AppliedTo/To/From fields.
++	// Cannot be set with any other selector.
++	// +optional
++	ServiceAccounts []ServiceAccount `json:""serviceAccounts,omitempty""`
+ }
+
+ type PeerNamespaces struct {","Will we be adding this to `AppliedTo` as well? If not, any reason why not?",You don't need `+optional` here.
+4025,"@@ -813,6 +813,13 @@ Tries to force this object to take the focus.
+ 		""""""
+ 		return False
+
++	def shouldAcceptShowHideCaretEvent(self):
++		""""""Some objects/applications send show/hide caret events when we don't expect it, such as when the cursor is blinking.
++		@return: if show/hide caret events should be accepted for this object.
++		@rtype: Boolean
++		""""""
++		return True
++
+ 	def reportFocus(self):
+ 		""""""Announces this object in a way suitable such that it gained focus.
+ 		""""""","Just a note that this feels weird being on the base NVDAObject rather than IAccessible, but right now, I understand that's how it has to be because we fire MSAA caret events on the focus object regardless of whether it's IAccessible. I think we should consider restricting these caret events to focus objects that are IAccessible subclasses in future, but that change is probably too risky for this PR. CC @MichaelDCurran for his thoughts.",Is there a specific reason for t
+4026,"@@ -71,7 +71,9 @@ class PaymentController extends AdminBaseController
+     {
+         $paymentEditData = $this->paymentEditDataFactory->createDefault();
+
+-        $form = $this->createForm(PaymentEditFormType::class, $paymentEditData);
++        $form = $this->createForm(PaymentEditFormType::class, $paymentEditData, [
++            'payment_detail' => null,
++        ]);
+         $form->handleRequest($request);
+
+         if ($form->isSubmitted() && $form->isValid()) {",This change and other similar ones should not be part of this commit. This commit is about adding a ImageUploadType not fixing controllers and stuff.,Wouldn't be better to call that
+4027,"@@ -57,6 +57,7 @@ const (
+ 	leafNodeConnectEventSubj = ""$SYS.ACCOUNT.%s.LEAFNODE.CONNECT"" // for internal use only
+ 	remoteLatencyEventSubj   = ""$SYS.LATENCY.M2.%s""
+ 	inboxRespSubj            = ""$SYS._INBOX.%s.%s""
++	accConnzReqSubj          = ""$SYS.REQ.ACCOUNT.PING.CONNZ""
+
+ 	// FIXME(dlc) - Should account scope, even with wc for now, but later on
+ 	// we can then shard as needed.","I am a bit confused about PING here. Ping is implied and it overlaps with ""$SYS.REQ.ACCOUNT.%s.%s"" where the last token is what is requested (CONNZ) and the one before is the requested account id.",Maybe rename to `accConnzRespond
+4028,"@@ -708,3 +708,15 @@ func (v *volumeClient) CloudMigrateStatus() (*api.CloudMigrateStatusResponse, er
+ 	}
+ 	return statusResponse, nil
+ }
++
++// Du specified volume id and specifically path (if provided)
++func (v *volumeClient) Catalog(id, subfolder, maxDepth string) (api.CatalogResponse, error) {
++	var catalog api.CatalogResponse
++
++	req := v.c.Get().Resource(volumePath + ""/catalog"").Instance(id)
++	if err := req.QueryOption(api.OptCatalogSubFolder, subfolder).QueryOption(api.OptCatalogMaxDepth, maxDepth).Do().Unmarshal(&catalog); err != nil {
++		return catalog, err
++	}
++
++	return catalog, nil
++}","nit: use the OptSubFolder constants. Also in the client you are using ""maxdepth"" but in the server the constant for ""depth"" is being used.",nit: should we check for nil here?
+4029,"@@ -76,8 +76,8 @@ describe('Config file', () => {
+     test('parse docker.yaml', () => {
+       const config = new Config(parseConfigFile(resolveConf('docker')));
+       checkDefaultUplink(config);
+-      expect(config.storage).toBe('/verdaccio/storage');
+-      expect(config.auth.htpasswd.file).toBe('/verdaccio/conf/htpasswd');
++      expect(config.storage).toBe('/verdaccio/storage/data');
++      expect(config.auth.htpasswd.file).toBe('/verdaccio/storage/htpasswd');
+       checkDefaultConfPackages(config);
+     });
+ ","I also moved this to `/verdaccio/storage` since it's written in runtime, and the approach here is to make the configuration by default read-only.",The config file name is the same a
+4030,"@@ -318,13 +318,13 @@ public class NodeJSGapicContext extends GapicContext implements NodeJSContext {
+         resourceTypeName = ""a "" + jsTypeName(resourceType);
+       }
+       return callbackMessage
+-          + ""\n@returns {Stream|gax.EventEmitter}\n""
++          + ""\n@returns {Stream|Promise}\n""
+           + ""  An object stream which emits ""
+           + resourceTypeName
+           + "" on 'data' event.\n""
+           + ""  When the callback is specified or streaming is suppressed through options,\n""
+-          + ""  it will return an event emitter to handle the call status and the callback\n""
+-          + ""  will be called with the response object."";
++          + ""  it will return a promise that resolves to the response object. The promise\n""
++          + ""  has cancel method which cancels the ongoing API call."";
+     }
+
+     MessageType returnMessageType = method.getOutputMessage();",nit: s/has cancel method/has a cancel method,Nit: Can we drop the period at the
+4031,"@@ -5,6 +5,16 @@ describe Quiz do
+
+   it { should have_many(:questions).dependent(:destroy) }
+
++  describe "".with_questions"" do
++    it ""returns only quizzes with questions"" do
++      first_quiz, second_quiz = create_pair(:quiz)
++
++      question = create(:question, quiz: first_quiz)
++
++      expect(Quiz.with_questions).to eq([first_quiz])
++    end
++  end
++
+   describe ""#first_question"" do
+     it ""returns the first question"" do
+       quiz = create(:quiz)",Useless assignment to variable - `second_quiz`. Use `_` or `_second_quiz` as a variable name to indicate that it won't be used.,"`it ""returns only quizzes with que"
+4032,"@@ -81,6 +81,9 @@ func (g Gzip) Validate() error {
+ // used in the Accept-Encoding request headers.
+ func (Gzip) AcceptEncoding() string { return ""gzip"" }
+
++// Suffix returns the filename suffix of precompressed files.
++func (Gzip) Suffix() string { return "".gz"" }
++
+ // NewEncoder returns a new gzip writer.
+ func (g Gzip) NewEncoder() encode.Encoder {
+ 	writer, _ := gzip.NewWriterLevel(nil, g.Level)",Is this still needed since there's the `GzipPrecompressed` type?,Is this necessary?
+4033,"@@ -29,6 +29,13 @@ from PyRegion import PyRegion
+ from nupic.algorithms.cla_classifier_factory import CLAClassifierFactory
+
+
++class _NumCatgoriesNotSpecified(Exception):
++  pass
++
++
++class _UnknownOutput(Exception):
++  pass
++
+
+ class CLAClassifierRegion(PyRegion):
+   """"""",this is spelled wrong and also not used so remove it,Please use `NotImp
+4034,"@@ -65,6 +65,7 @@ public abstract class ServerWebExchangeMatchers {
+ 	 * Matches any exchange
+ 	 * @return the matcher to use
+ 	 */
++	@SuppressWarnings(""Convert2Lambda"")
+ 	public static ServerWebExchangeMatcher anyExchange() {
+ 		// we don't use a lambda to ensure a unique equals and hashcode
+ 		// which otherwise can cause problems with adding multiple entries to an ordered LinkedHashMap",It might be right here that's the issue ^,I don't see any re
+4035,"@@ -71,8 +71,10 @@ public interface SortedMap<K, V> extends Map<K, V>, Ordered<K> {
+     /**
+      * Returns the underlying key-comparator which defines the order of the elements contained in this map.
+      *
++     * @deprecated Use {@link SortedMap#comparator()} instead
+      * @return This map's key-comparator.
+      */
++    @Deprecated
+     Comparator<K> keyComparator();
+
+     /**",@danieldietrich let's leave existing extension. Here we just mark `keyComparator()` with `@Deprecated` annotation,Did you mean to sa
+4036,"@@ -21,6 +21,7 @@ OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWA
+  * HIT_END
+  */
+
++#include <io.h>
+ #include <iostream>
+ #include <vector>
+ #include <stdio.h>",This breaks CI. I am not sure why you need to include io.h in this file especially on linux.,I don't think this include is needed.
+4037,"@@ -48,7 +48,7 @@ export function render(vnode, parentDom, replaceNode) {
+ 			? [replaceNode]
+ 			: oldVNode
+ 			? null
+-			: parentDom.firstChild
++			: parentDom.childNodes.length
+ 			? slice.call(parentDom.childNodes)
+ 			: null,
+ 		commitQueue,",this seems equivalent,hmm... I don't understand this change
+4038,"@@ -371,10 +371,10 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int, storeType strin
+
+ 		BlobSizeLimitError:     dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitError, 2*1024*1024),
+ 		BlobSizeLimitWarn:      dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitWarn, 512*1024),
+-		HistorySizeLimitError:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitError, 200*1024*1024),
+-		HistorySizeLimitWarn:   dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitWarn, 50*1024*1024),
+-		HistoryCountLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitError, 200*1024),
+-		HistoryCountLimitWarn:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitWarn, 50*1024),
++		HistorySizeLimitError:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitError, 20*1024*1024),
++		HistorySizeLimitWarn:   dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitWarn, 5*1024*1024),
++		HistoryCountLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitError, 20*1024),
++		HistoryCountLimitWarn:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitWarn, 5*1024),
+
+ 		ThrottledLogRPS:   dc.GetIntProperty(dynamicconfig.HistoryThrottledLogRPS, 4),
+ 		EnableStickyQuery: dc.GetBoolPropertyFnWithNamespaceFilter(dynamicconfig.EnableStickyQuery, true),","change size to 50MB criticial, 10MB warn... change count to 50k critical, 5k warn...",is there any risk of these values bei
+4039,"@@ -1033,9 +1033,9 @@ public class FacetComponent extends SearchComponent {
+       }
+
+       for (Entry<String,List<NamedList<Object>>> pivotFacetResponseFromShard : pivotFacetResponsesFromShard) {
+-        PivotFacet masterPivotFacet = fi.pivotFacets.get(pivotFacetResponseFromShard.getKey());
+-        masterPivotFacet.mergeResponseFromShard(shardNumber, rb, pivotFacetResponseFromShard.getValue());
+-        masterPivotFacet.removeAllRefinementsForShard(shardNumber);
++        PivotFacet primaryPivotFacet = fi.pivotFacets.get(pivotFacetResponseFromShard.getKey());
++        primaryPivotFacet.mergeResponseFromShard(shardNumber, rb, pivotFacetResponseFromShard.getValue());
++        primaryPivotFacet.removeAllRefinementsForShard(shardNumber);
+       }
+     }
+     ","This has nothing to do with master/slave replication. Is this something we want to change too? If so, I guess this is an aggregation?",I would suggest to rename `masterPivo
+4040,"@@ -91,9 +91,12 @@ module RSpec
+           end
+
+           def dispatch_specs(run_descriptor)
+-            fork { run_specs(run_descriptor) }
++            pid = fork { run_specs(run_descriptor) }
+             # We don't use Process.waitpid here as it was causing bisects to
+-            # block due to the file descriptor limit on OSX / Linux.
++            # block due to the file descriptor limit on OSX / Linux. We need
++            # to detach the process to avoid having zombie process and consume
++            # slot in the kernel process table.
++            Process.detach(pid)
+           end
+
+         private","Maybe it makes sense to mention that those zombies are not forever, but only up to the moment when the parent process exits? Is that correct according to your observations, @benoittgt ? Please disregard this note if zombies remain after.",I think you might want to use `Process.detach` here instead of `Process.detach`
+4041,"@@ -543,7 +543,18 @@ def apply_patches():
+ def start_apigateway(port=None, backend_port=None, asynchronous=None, update_listener=None):
+     port = port or config.PORT_APIGATEWAY
+     apply_patches()
+-    result = start_moto_server(
++
++    # Why here?
++    # 1. The moto mocking has to happen before any usage of botocore, the import will register
++    #    a 'before-send-handler' event, thus intercepting the call to aws.
++    # 2. Then we start the specific service mocking, which basically starts the service backend.
++    #
++    from moto import mock_apigateway
++
++    mock = mock_apigateway()
++    mock.start()
++
++    return start_moto_server(
+         key=""apigateway"",
+         name=""API Gateway"",
+         asynchronous=asynchronous,",moto mock setup needs to happen before boto usage.,"s/apigateway/moto/ ? Also, what does the `import moto` do here?"
+4042,"@@ -199,6 +199,8 @@ def train(params, train_set, num_boost_round=100,
+         callbacks = set()
+     else:
+         for i, cb in enumerate(callbacks):
++            if hasattr(cb, 'first_metric_only') and cb.first_metric_only and feval is not None:
++                raise LightGBMError(""`first_metric_only` and `feval` are not available at the same time."")
+             cb.__dict__.setdefault('order', i - len(callbacks))
+         callbacks = set(callbacks)
+ ","`hasattr(cb, 'first_metric_only') and cb.first_metric_only` -> `getattr(cb, 'first_metric_only', False)`",would it be better to check for `cb.first_metric_only` here?
+4043,"@@ -107,3 +107,17 @@ func getProtoRequest(ctx context.Context, transportRequest *transport.Request, n
+ 	}
+ 	return ctx, call, request, nil
+ }
++
++type streamHandler struct {
++	handle     func(ServerStream) error
++}
++
++func newStreamHandler(
++	handle func(ServerStream) error,
++) *streamHandler {
++	return &streamHandler{handle}
++}
++
++func (s *streamHandler) HandleStream(stream transport.ServerStream) error {
++	return s.handle(stream)
++}",no newline for function,Why is this needed?
+4044,"@@ -240,7 +240,7 @@ static void config_head_handle_set_scale(struct wl_client *client,
+ 		return;
+ 	}
+
+-	double scale =  wl_fixed_to_double(scale_fixed);
++	float scale =  wl_fixed_to_double(scale_fixed);
+ 	if (scale <= 0) {
+ 		wl_resource_post_error(config_head_resource,
+ 			ZWLR_OUTPUT_CONFIGURATION_HEAD_V1_ERROR_INVALID_SCALE,","This makes me feel icky. We could also go the route of making `wlr_output.scale` a double instead of a float, but that would be a more widely reaching change.",This error message shouldn't be changed.
+4045,"@@ -219,7 +219,7 @@ PQRYRES XMLColumns(PGLOBAL g, char *db, char *tab, PTOS topt, bool info)
+     while (true) {
+       if (!vp->atp &&
+ 				!(node = (vp->nl) ? vp->nl->GetItem(g, vp->k++, tdp->Usedom ? node : NULL)
+-				                  : NULL))
++				                  : NULL)) {
+         if (j) {
+           vp = lvlp[--j];
+ ","Again, would be awesome if you could remove the tabs in these 3-4 lines as well.","> return NULL; [](start = 8, length = 7)"
+4046,"@@ -234,9 +234,14 @@ util::json::Object makeRouteStep(guidance::RouteStep step, util::json::Value geo
+     util::json::Object route_step;
+     route_step.values[""distance""] = std::round(step.distance * 10) / 10.;
+     route_step.values[""duration""] = std::round(step.duration * 10) / 10.;
+-    route_step.values[""name""] = std::move(step.name);
+-    if (!step.ref.empty())
++    route_step.values[""way_name""] = std::move(step.name);
++    if (step.ref.empty())
++        route.step.values[""name""] = std::move(step.name);
++    else
++    {
++        route_step.values[""name""] = std::move(step.name) << "" ("" << std::move(step.ref) << "")"";
+         route_step.values[""ref""] = std::move(step.ref);
++    }
+     if (!step.pronunciation.empty())
+         route_step.values[""pronunciation""] = std::move(step.pronunciation);
+     if (!step.destinations.empty())",You're moving multiple times from `step.name`; you're not allowed to do that. Instead you have to copy the `step.name` string and (if you want to) move once at the very last.,"You don't need the `if` here, `route_ste"
+4047,"@@ -124,15 +124,15 @@ app.controller('EditorController', ['$scope', 'TimezoneService', 'AutoCompletion
+ 		$scope.validate = function() {
+ 			var error = false;
+ 			if ($scope.properties.summary === null || $scope.properties.summary.value.trim() === '') {
+-				OC.Notification.showTemporary(t('calendar', 'Please add a title!'));
++				OC.Notification.showTemporary(t('calendar', 'Please add a title.'));
+ 				error = true;
+ 			}
+ 			if ($scope.calendar === null || typeof $scope.calendar === 'undefined') {
+-				OC.Notification.showTemporary(t('calendar', 'Please select a calendar!'));
++				OC.Notification.showTemporary(t('calendar', 'Please select a calendar.'));
+ 				error = true;
+ 			}
+ 			if (!$scope.properties.checkDtStartBeforeDtEnd()) {
+-				OC.Notification.showTemporary(t('calendar', 'The event ends before it starts!'));
++				OC.Notification.showTemporary(t('calendar', 'The event can not end before it starts.'));
+ 				error = true;
+ 			}
+ ",What about `may not end`? @jancborchardt,I think this is a typo.
+4048,"@@ -1236,7 +1236,7 @@ func (a *WebAPI) validateApprover(stages []*model.PipelineStage, commander, stag
+ 			return nil
+ 		}
+ 	}
+-	return status.Error(codes.FailedPrecondition, fmt.Sprintf(""Could not approve the stage because %q isn't set as an approver."", commander))
++	return status.Error(codes.FailedPrecondition, fmt.Sprintf(""You can't approve this deployment because you (%s) are not in the approver list: %v"", commander, approvers))
+ }
+
+ func (a *WebAPI) GetApplicationLiveState(ctx context.Context, req *webservice.GetApplicationLiveStateRequest) (*webservice.GetApplicationLiveStateResponse, error) {","If you think about it, the status should be PermissionDenied?",I don't think this is correct. You can't approve this deployment because you didn't set any approvers.
+4049,"@@ -260,8 +260,7 @@ class MappingJobQueue(threading.Thread):
+                         low_quality_rate=stats[""low_quality""] - stats[""last_low_quality""],
+                         no_match_rate=stats[""no_match""] - stats[""last_no_match""],
+                         listens_per_sec=listens_per_sec,
+-                        listen_count=stats[""listen_count""],
+-                        listens_matched=stats[""listens_matched""],
++                        listens_matched_p=stats[""listens_matched""] / stats[""listen_count""] * 100.0,
+                         legacy_index_date=datetime.date.fromtimestamp(self.legacy_listens_index_date).strftime(""%Y-%m-%d""))
+
+             stats[""last_exact_match""] = stats[""exact_match""]",Calculation looks good but don't know what format etc grafana expects this to be in.,can we call it `listens_matched_percentage` for consistency?
+4050,"@@ -722,6 +722,18 @@ class TestDockerClient:
+         assert env_variable in stdout
+         assert ""EXISTING_VAR=test_var"" in stdout
+
++    def test_run_with_additional_arguments_add_host(self, docker_client: ContainerClient):
++        additional_flags = ""--add-host sometest.localstack.cloud:127.0.0.1""
++        stdout, _ = docker_client.run_container(
++            ""alpine"",
++            remove=True,
++            command=[""getent"", ""hosts"", ""sometest.localstack.cloud""],
++            additional_flags=additional_flags,
++        )
++        stdout = stdout.decode(config.DEFAULT_ENCODING)
++        assert ""127.0.0.1"" in stdout
++        assert ""sometest.localstack.cloud"" in stdout
++
+     def test_get_container_ip_non_existing_container(self, docker_client: ContainerClient):
+         with pytest.raises(NoSuchContainer):
+             docker_client.get_container_ip(""hopefully_non_existent_container_%s"" % short_uid())",nit: We could use the `to_str(..)` util here. (let's not bother changing for this PR..   ),"I don't believe you need to decode here, since you're using it below."
+4051,"@@ -29,6 +29,7 @@ import (
+ 	""time""
+
+ 	""github.com/gogo/protobuf/types""
++	executiongenproto ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	tasklistpb ""go.temporal.io/temporal-proto/tasklist""
+ )
+ ","Can you rename alias to `executiongenpb`. The rule is package+""pb"" for `temporal-proto` and package+""genpb"" for server protos.",Are these changes supposed to be in this PR?
+4052,"@@ -261,7 +261,9 @@ func addNodeToResults(n *node, results *SublistResult) {
+ 		if i := findQSliceForSub(qr[0], results.qsubs); i >= 0 {
+ 			results.qsubs[i] = append(results.qsubs[i], qr...)
+ 		} else {
+-			results.qsubs = append(results.qsubs, qr)
++			copyqr := make([]*subscription, len(qr))
++			copy(copyqr, qr)
++			results.qsubs = append(results.qsubs, copyqr)
+ 		}
+ 	}
+ }",Any noticeable performance hit? Any other way to avoid the allocation and copy even of the array?,"This should probably be `results.qsubs = append(results.qsubs, qr)`"
+4053,"@@ -234,8 +234,8 @@ func (i2c I2C) readByte() byte {
+ func (i2c I2C) readLastByte() byte {
+ 	for i2c.Bus.EVENTS_RXDREADY == 0 {
+ 	}
+-	i2c.Bus.EVENTS_RXDREADY = 0
+ 	i2c.signalStop() // signal 'stop' now, so it is sent when reading RXD
++	i2c.Bus.EVENTS_RXDREADY = 0
+ 	return byte(i2c.Bus.RXD)
+ }
+ ",What if you remove this line entirely from here?,What's the purpose of this change?
+4054,"@@ -124,11 +124,13 @@ class PAFPN(FPN):
+                     outs.append(F.max_pool2d(outs[-1], 1, stride=2))
+             # add conv layers on top of original feature maps (RetinaNet)
+             else:
+-                if self.extra_convs_on_inputs:
++                if self.add_extra_convs == 'on_input':
+                     orig = inputs[self.backbone_end_level - 1]
+                     outs.append(self.fpn_convs[used_backbone_levels](orig))
+-                else:
++                elif self.add_extra_convs == 'on_output':
+                     outs.append(self.fpn_convs[used_backbone_levels](outs[-1]))
++                else:
++                    raise NotImplementedError
+                 for i in range(used_backbone_levels + 1, self.num_outs):
+                     if self.relu_before_extra_convs:
+                         outs.append(self.fpn_convs[i](F.relu(outs[-1])))",`on_lateral` can also be implemented,I don't understand this. Why do you change the logic of this PR?
+4055,"@@ -67,11 +67,14 @@ public class ItunesAdapter extends ArrayAdapter<PodcastSearchResult> {
+
+         //Set the title
+         viewHolder.titleView.setText(podcast.title);
+-        if(podcast.feedUrl != null && !podcast.feedUrl.contains(""itunes.apple.com"")) {
+-            viewHolder.urlView.setText(podcast.feedUrl);
+-            viewHolder.urlView.setVisibility(View.VISIBLE);
++        if(podcast.author != null && ! podcast.author.trim().isEmpty()) {
++            viewHolder.authorView.setText(podcast.author);
++            viewHolder.authorView.setVisibility(View.VISIBLE);
++        } else if(podcast.feedUrl != null && !podcast.feedUrl.contains(""itunes.apple.com"")) {
++            viewHolder.authorView.setText(podcast.feedUrl);
++            viewHolder.authorView.setVisibility(View.VISIBLE);
+         } else {
+-            viewHolder.urlView.setVisibility(View.GONE);
++            viewHolder.authorView.setVisibility(View.GONE);
+         }
+
+         //Update the empty imageView with the image from the feed",Please add a space between `if` and `(`.,The text of the title view needs to be updated as well.
+4056,"@@ -30,6 +30,12 @@ import (
+ const (
+ 	PoolOperator           = ""zpool""
+ 	StatusNoPoolsAvailable = ""no pools available""
++	ZpoolStatusDegraded    = ""DEGRADED""
++	ZpoolStatusFaulted     = ""FAULTED""
++	ZpoolStatusOffline     = ""OFFLINE""
++	ZpoolStatusOnline      = ""ONLINE""
++	ZpoolStatusRemoved     = ""REMOVED""
++	ZpoolStatusUnavail     = ""UNAVAIL""
+ )
+
+ //PoolAddEventHandled is a flag representing if the pool has been initially imported or created","This statuses might have been better off with some custom status type. However, good for now.",nit: I'd suggest calling this `ZpoolStatusOffline` instead of `ZpoolStatusDegraded`.
+4057,"@@ -165,9 +165,11 @@ func GetIPNetDeviceByName(ifaceName string) (v4IPNet *net.IPNet, v6IPNet *net.IP
+ 		if ipNet, ok := addr.(*net.IPNet); ok {
+ 			if ipNet.IP.IsGlobalUnicast() {
+ 				if ipNet.IP.To4() != nil {
++					if v4IPNet == nil {
++						v4IPNet = ipNet
++					}
++				} else if v6IPNet == nil {
+ 					v6IPNet = ipNet
+-				} else {
+-					v4IPNet = ipNet
+ 				}
+ 			}
+ 		}",Thanks for catching the bug. Here your change lets `v4IPNet` and `v6IPNet` take the first IPv4/IPv6 address in `addrList`. Maybe choose the last one also works and makes code simpler? What's your idea? @tnqn,why was this removed?
+4058,"@@ -680,8 +680,12 @@ class UserResource(object):
+         try:
+             return self.model.get_record(record_id)
+         except storage_exceptions.RecordNotFoundError:
+-            response = http_error(HTTPNotFound(),
+-                                  errno=ERRORS.INVALID_RESOURCE_ID)
++            detail_dict = {
++                ""id"": record_id,
++                ""resource_name"": ""record""
++            }
++            response = http_error(HTTPNotFound(), errno=ERRORS.INVALID_RESOURCE_ID,
++                                  details=detail_dict)
+             raise response
+
+     def _add_timestamp_header(self, response, timestamp=None):",nitpick: you can name this variable just `details`,"It would be good to have here an error message as well, like ""Internal error: record"
+4059,"@@ -0,0 +1,18 @@
++#include ""general.h""
++#include ""parse.h""
++
++static void installJadeParser (const langType language)
++{
++  addTagRegex(language, ""^mixin[ \t]*([a-sA-Z0-9_]+)"", ""\\1"", ""d,definition"", NULL);
++}
++
++
++extern parserDefinition* JadeParser (void)
++{
++  static const char* extensions[] = { ""jade"", NULL };
++  parserDefinition* def = parserNew(""Jade"");
++  def->extensions       = extensions;
++  def->initialize       = installJadeParser;
++  def->method           = METHOD_REGEX;
++  return def;
++}","The character class in the regex should probably be ""[a-zA-Z0-9_]"".",Use camelCase for consistency with the rest of the file.
+4060,"@@ -290,12 +290,6 @@ public class GlobalSettings {
+         s.put(""pgpSignOnlyDialogCounter"", Settings.versions(
+                 new V(45, new IntegerRangeSetting(0, Integer.MAX_VALUE, 0))
+         ));
+-        s.put(""openPgpProvider"", Settings.versions(
+-                new V(46, new StringSetting(K9.NO_OPENPGP_PROVIDER))
+-        ));
+-        s.put(""openPgpSupportSignOnly"", Settings.versions(
+-                new V(47, new BooleanSetting(false))
+-        ));
+         s.put(""fontSizeMessageViewBCC"", Settings.versions(
+                 new V(48, new FontSizeSetting(FontSizes.FONT_DEFAULT))
+         ));",Please also increment `Settings.VERSION` and update `AccountSettings`.,Why is this settings removed?
+4061,"@@ -18,6 +18,12 @@ import (
+ 	""time""
+ )
+
++var builddate string // set by the Makefile
++
++func versionString() string {
++	return ""Weave of "" + builddate
++}
++
+ func ensureInterface(ifaceName string, wait bool) (iface *net.Interface, err error) {
+ 	iface, err = findInterface(ifaceName)
+ 	if err == nil || !wait {","I think this should just say ""build <date>"". And when builddate wasn't set, e.g. somebody built weave with 'go build' or some other way, this should return ""unknown"".",This should probably be in th
+4062,"@@ -142,7 +142,8 @@ public class BaseRewriteManifestsSparkAction
+
+   @Override
+   public RewriteManifests.Result execute() {
+-    JobGroupInfo info = newJobGroupInfo(""REWRITE-MANIFESTS"", ""REWRITE-MANIFESTS"");
++    JobGroupInfo info = newJobGroupInfo(""REWRITE-MANIFESTS"",
++        String.format(""Rewriting manifests(staging location=%s) of %s"", stagingLocation, table.name()));
+     return withJobGroupInfo(info, this::doExecute);
+   }
+ ",Can we move this into a separate var and call it `desc` like below?,`of %s` -> `of %s`
+4063,"@@ -19,6 +19,14 @@ package io.servicecomb.demo.pojo.server;
+ import java.util.Arrays;
+ import java.util.List;
+
++import javax.ws.rs.core.MediaType;
++
++import org.springframework.web.bind.annotation.RequestBody;
++import org.springframework.web.bind.annotation.RequestMapping;
++import org.springframework.web.bind.annotation.RequestMethod;
++import org.springframework.web.bind.annotation.RequestParam;
++import org.springframework.web.bind.annotation.ResponseBody;
++
+ import io.servicecomb.demo.server.Test;
+ import io.servicecomb.demo.server.TestRequest;
+ import io.servicecomb.demo.server.User;",why RpcSchema need this annotations?,Our coding style is to import
+4064,"@@ -1673,7 +1673,9 @@ func (s *Server) debugSubscribers(sub *subscription, c *client, subject, reply s
+ 		}
+ 		// Cleanup the WC entry.
+ 		s.mu.Lock()
+-		delete(s.sys.replies, replySubj)
++		if s.sys != nil && s.sys.replies != nil {
++			delete(s.sys.replies, replySubj)
++		}
+ 		s.mu.Unlock()
+ 		// Send the response.
+ 		s.sendInternalAccountMsg(nil, reply, atomic.LoadInt32(&nsubs))","Not sure it makes sense to send the reply if we did not delete from the map, but I guess it does not hurt..",It seems like `mu.Lock` would be sufficient to remove the `if s.sys != nil && s.sys.replies != nil`.
+4065,"@@ -187,10 +187,11 @@ DataMap.prototype.getSchema = function() {
+  * @returns {Number} Returns number of created rows.
+  */
+ DataMap.prototype.createRow = function(index, amount, source) {
+-  var row,
+-    colCount = this.instance.countCols(),
+-    numberOfCreatedRows = 0,
+-    currentIndex;
++  let row = null;
++  let colCount = this.instance.countCols();
++  let numberOfCreatedRows = 0;
++  let currentIndex = null;
++  let continueProcess = null;
+
+   if (!amount) {
+     amount = 1;",Most of these variables can be moved after `return` or to the body of `if` statement.,The docs for this function seem to imply that it can only return a single row. Is that correct?
+4066,"@@ -115,6 +115,10 @@ public enum JsonRpcError {
+   DECODE_ERROR(-50100, ""Unable to decode the private signed raw transaction""),
+   GET_PRIVATE_TRANSACTION_NONCE_ERROR(-50100, ""Unable to determine nonce for account in group.""),
+
++  // Privacy multi-tenancy errors
++  PRIVACY_MULTI_TENANCY_NO_TOKEN(-50100, ""No token provided""),
++  PRIVACY_MULTI_TENANCY_NO_ENCLAVE_PUBLIC_KEY(-50100, ""No privacy enclave public key""),
++
+   CANT_CONNECT_TO_LOCAL_PEER(-32100, ""Cannot add local node as peer.""),
+
+   // Invalid input errors","nit: Is this actually just a http ""unauthorised"" response? Or is that too vague? If this is the right way to go ... is ""token"" the right word"" Or do we want to say something else?","Same here, what is the token for?"
+4067,"@@ -247,7 +247,7 @@ module Bolt
+
+     def puppetdb_client
+       return @puppetdb_client if @puppetdb_client
+-      puppetdb_config = Bolt::PuppetDB::Config.load_config(nil, config.puppetdb)
++      puppetdb_config = Bolt::PuppetDB::Config.load_config(nil, config.puppetdb, config.boltdir.path)
+       @puppetdb_client = Bolt::PuppetDB::Client.new(puppetdb_config)
+     end
+ ","We check for `$future` in PuppetDB::Config, so this won't change behavior if you don't have `future` set.",Metrics/LineLength: Line is too long. [87/80]
+4068,"@@ -1279,6 +1279,8 @@ class _Frame(object):
+             col_by = [_resolve_col(df, col_or_s) for col_or_s in by]
+             return DataFrameGroupBy(df_or_s, col_by, as_index=as_index)
+         if isinstance(df_or_s, Series):
++            if not isinstance(by[0], Series):
++                raise KeyError(by[0])
+             col = df_or_s  # type: Series
+             anchor = df_or_s._kdf
+             col_by = [_resolve_col(anchor, col_or_s) for col_or_s in by]","I think you should remove `if isinstance(by, str):`,. We also should fix the error message `raise ValueError('Not a valid index: TODO')` to match with pandas'",This should probably be `TypeError` instead of `KeyError`.
+4069,"@@ -48,6 +48,7 @@ namespace OpenTelemetry.Instrumentation.Grpc.Implementation
+
+             activity.SetKind(ActivityKind.Client);
+             activity.DisplayName = grpcMethod?.Trim('/');
++            activity.SetCustomProperty(""GrpcHandler.Request"", request);
+
+             this.activitySource.Start(activity);
+ ","Curious - do we want this to be `OTel.GrpcHandler.Request`? For example, if someone is debugging a crash dump, they would get some hint that it was added by OpenTelemetry.",Is this property set in the constructor?
+4070,"@@ -52,6 +52,12 @@ public interface TableOperations {
+    * Implementations must check that the base metadata is current to avoid overwriting updates.
+    * Once the atomic commit operation succeeds, implementations must not perform any operations that
+    * may fail because failure in this method cannot be distinguished from commit failure.
++   * <p></p>
++   * Implementations must throw a CommitStateUnknownException in cases where it cannot be determined if the
++   * commit succeeded or failed. For example if a network partition causes the confirmation of the commit to be lost,
++   * the implementation should throw a CommitStateUnknownException. This is important because downstream users of
++   * this API need to know whether they can clean up the commit or not, if the state is unknown then it is not safe
++   * to remove any files. All other exceptions will be treated as if the commit has failed.
+    *
+    * @param base     table metadata on which changes were based
+    * @param metadata new table metadata with updates",nit: unnecessary `</p>`,Should this be part of this PR?
+4071,"@@ -194,7 +194,16 @@ std::shared_ptr<Engine> ADIOS::Open(const std::string &name,
+                                     ""HDF5 library, can't use HDF5\n"");
+ #endif
+     }
+-
++    else if (type == ""HDF5Reader"") // -Junmin
++    {
++#if defined(ADIOS_HAVE_PHDF5) && defined(ADIOS_HAVE_MPI)
++        return std::make_shared<HDF5Reader>(*this, name, accessMode, mpiComm,
++                                            method);
++#else
++        throw std::invalid_argument(""ERROR: this version didn't compile with ""
++                                    ""HDF5 library, can't use HDF5\n"");
++#endif
++    }
+     else
+     {
+         if (m_DebugMode == true)",Should just be `#ifdef ADIOS2_HAVE_HDF5`,Isn't `type` already defined in the existing `if` block?
+4072,"@@ -1691,7 +1691,11 @@ def add_default_resource_props(
+         props[""LogGroupName""] = resource_name
+
+     elif res_type == ""AWS::Lambda::Function"" and not props.get(""FunctionName""):
+-        props[""FunctionName""] = ""{}-lambda-{}"".format(stack_name[:45], short_uid())
++        # FunctionName is up to 64 characters long
++        random_id_part = short_uid()
++        resource_id_part = resource_id[:24]
++        stack_name_part = stack_name[: 63 - 2 - (len(random_id_part) + len(resource_id_part))]
++        props[""FunctionName""] = f""{stack_name_part}-{resource_id_part}-{random_id_part}""
+
+     elif res_type == ""AWS::SNS::Topic"" and not props.get(""TopicName""):
+         props[""TopicName""] = ""topic-%s"" % short_uid()","FYI: I deployed a stack with multiple lengths for the stack name and resource id to cloudformation, to see how it truncates the parts for the final FunctionName","Is there any way to make sure the name is long (e.g. ""lambda-<random_id>"")? Also, is there any way to make sure the name is long (e.g. ""lambda-<random_id>"")?"
+4073,"@@ -301,7 +301,6 @@ func (w *WorkloadInitializer) newLoadBalancedWebServiceManifest(i *ServiceProps)
+ 		},
+ 		Port:        i.Port,
+ 		HealthCheck: i.HealthCheck,
+-		AppDomain:   i.appDomain,
+ 		Path:        ""/"",
+ 	}
+ 	existingSvcs, err := w.Store.ListServices(i.App)",Did we not use this field @_@,Shouldn't we still set the AppDomain in the case where there is an error?
+4074,"@@ -83,6 +83,10 @@ const Config = function () {
+   this.extraGnArgs = {}
+   this.extraNinjaOpts = []
+   this.braveSafetyNetApiKey = getNPMConfig(['brave_safetynet_api_key']) || ''
++  this.androidKeystorePath = getNPMConfig(['android_keystore_path']) || ''
++  this.androidKeyAlias = getNPMConfig(['android_key_alias']) || ''
++  this.androidKeystorePassword = getNPMConfig(['android_keystore_password']) || ''
++  this.androidKeyPassword = getNPMConfig(['android_key_password']) || ''
+ }
+
+ Config.prototype.buildArgs = function () {",shouldn't this be `android_keystore_name`?,why not use `getNPMConfig(['android_keystore_path'] || '')` directly?
+4075,"@@ -39,7 +39,12 @@ func (c *controller) issuersForSecret(secret *corev1.Secret) ([]*v1alpha2.Cluste
+ 		}
+ 		if (iss.Spec.ACME != nil && iss.Spec.ACME.PrivateKey.Name == secret.Name) ||
+ 			(iss.Spec.CA != nil && iss.Spec.CA.SecretName == secret.Name) ||
+-			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.TokenSecretRef.Name == secret.Name) {
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.TokenSecretRef != nil &&
++				iss.Spec.Vault.Auth.TokenSecretRef.Name == secret.Name) ||
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.Kubernetes != nil &&
++				iss.Spec.Vault.Auth.Kubernetes.SecretRef.Name == secret.Name) ||
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.AppRole != nil &&
++				iss.Spec.Vault.Auth.AppRole.SecretRef.Name == secret.Name) {
+ 			affected = append(affected, iss)
+ 			continue
+ 		}",Double check the issuers package too :),"`appRole` is not a field in the spec, should be `iss.Spec.Vault.Auth.AppRole`"
+4076,"@@ -170,7 +170,7 @@ TYPING_NAMES = frozenset(
+
+
+ class VariableVisitConsumerAction(Enum):
+-    """"""Used after _visit_consumer to determine the action to be taken
++    """"""Used after _check_consumer to determine the action to be taken
+
+     Continue -> continue loop to next consumer
+     Return -> return and thereby break the loop",This is out of date right? Now that `_is_first_level_self_reference` uses it as well? Perhaps we should make the docstring more general and not refer to method names that could change.,should be called _visit_consumer :)
+4077,"@@ -305,6 +305,7 @@ func createK8sAppMonitoring(
+ }
+
+ func testPromRemoteWriteWithTLS(t *testing.T) {
++	t.Parallel()
+ 	// can't extend the names since ns cannot be created with more than 63 characters
+ 	tests := []testFramework.PromRemoteWriteTestConfig{
+ 		// working configurations","This test alone takes around 10-12 minutes to run. It has 20 subtests each of which takes around one minute. We should see if we there are redundant subtests that we can remove, or look for a way to optimize them.",Why is this needed now?
+4078,"@@ -10,11 +10,14 @@ import options from '../options';
+  * @param {boolean} isSvg Whether or not this node is an SVG node
+  */
+ export function diffProps(dom, newProps, oldProps, isSvg) {
+-	for (let i in newProps) {
+-		if (i!=='children' && i!=='key' && (!oldProps || ((i==='value' || i==='checked') ? dom : oldProps)[i]!==newProps[i])) {
+-			setProperty(dom, i, newProps[i], oldProps[i], isSvg);
++	let keys = Object.keys(newProps).sort();
++	for (let i = 0; i < keys.length; i++) {
++		let k = keys[i];
++		if (k!=='children' && k!=='key' && (!oldProps || ((k==='value' || k==='checked') ? dom : oldProps)[k]!==newProps[k])) {
++			setProperty(dom, k, newProps[k], oldProps[k], isSvg);
+ 		}
+ 	}
++
+ 	for (let i in oldProps) {
+ 		if (i!=='children' && i!=='key' && (!newProps || !(i in newProps))) {
+ 			setProperty(dom, i, null, oldProps[i], isSvg);","Good call, we need to keep that check :+1:",Why is the `!=='key'` needed?
+4079,"@@ -11,5 +11,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+         bool ParseRequestLine(TRequestHandler handler, in ReadOnlySequence<byte> buffer, out SequencePosition consumed, out SequencePosition examined);
+
+         bool ParseHeaders(TRequestHandler handler, in ReadOnlySequence<byte> buffer, out SequencePosition consumed, out SequencePosition examined, out int consumedBytes);
++
++        bool ParseRequestLine(TRequestHandler handler, ref BufferReader<byte> reader);
++
++        bool ParseHeaders(TRequestHandler handler, ref BufferReader<byte> reader);
+     }
+ }",Should the interface have 2 `ParseHeaders` methods?,Is this necessary? It looks like it
+4080,"@@ -87,9 +87,11 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+   private static final String HIVE_LOCK_CHECK_MIN_WAIT_MS = ""iceberg.hive.lock-check-min-wait-ms"";
+   private static final String HIVE_LOCK_CHECK_MAX_WAIT_MS = ""iceberg.hive.lock-check-max-wait-ms"";
+   private static final String HIVE_TABLE_LEVEL_LOCK_EVICT_MS = ""iceberg.hive.table-level-lock-evict-ms"";
++  private static final String HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES = ""hive.iceberg.metadata.refresh.max.retries"";
+   private static final long HIVE_ACQUIRE_LOCK_TIMEOUT_MS_DEFAULT = 3 * 60 * 1000; // 3 minutes
+   private static final long HIVE_LOCK_CHECK_MIN_WAIT_MS_DEFAULT = 50; // 50 milliseconds
+   private static final long HIVE_LOCK_CHECK_MAX_WAIT_MS_DEFAULT = 5 * 1000; // 5 seconds
++  private static final int HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES_DEFAULT = 2;
+   private static final long HIVE_TABLE_LEVEL_LOCK_EVICT_MS_DEFAULT = TimeUnit.MINUTES.toMillis(10);
+   private static final DynMethods.UnboundMethod ALTER_TABLE = DynMethods.builder(""alter_table"")
+       .impl(IMetaStoreClient.class, ""alter_table_with_environmentContext"",",Nit: Does this make more sense as `iceberg.hive.metadata...`? The rest of the configs seem to start with `iceberg.hive`.,why is this hardcoded to 2? should we make this configurable?
+4081,"@@ -184,6 +184,17 @@ func ValidateACMEIssuerDNS01Config(iss *v1alpha1.ACMEIssuerDNS01Config, fldPath
+ 				}
+ 			}
+ 		}
++		if p.DNSMadeEasy != nil {
++			if numProviders > 0 {
++				el = append(el, field.Forbidden(fldPath.Child(""dnsmadeeasy""), ""may not specify more than one provider type""))
++			} else {
++				numProviders++
++				el = append(el, ValidateSecretKeySelector(&p.DNSMadeEasy.SecretKey, fldPath.Child(""dnsmadeeasy"", ""secretKeySecretRef""))...)
++				if len(p.DNSMadeEasy.APIKey) == 0 {
++					el = append(el, field.Required(fldPath.Child(""dnsmadeeasy"", ""apiKey""), """"))
++				}
++			}
++		}
+ 		if p.Route53 != nil {
+ 			if numProviders > 0 {
+ 				el = append(el, field.Forbidden(fldPath.Child(""route53""), ""may not specify more than one provider type""))",Is `baseURL` not required?,Shouldn't we allow for `p.DNSMadeEasy.SecretKey` to be `nil`?
+4082,"@@ -101,6 +101,7 @@ class EmbeddingRPNHead(nn.Module):
+         """"""Forward function in testing stage.""""""
+         return self._decode_init_proposals(img, img_metas)
+
++    # TODO: is right ?
+     def show_result(self, data):
+         """"""Show the init proposals in EmbeddingRPN.
+ ","Just delete it, `embedding_rpn_head` is not a `Detector` which should have `show_result`.","I think it should be fine, but I'm not sure whether it actual"
+4083,"@@ -7,6 +7,12 @@ namespace Datadog.Trace.ClrProfiler.ExtensionMethods
+         internal static string GetHttpMethod(this ISpan span)
+             => span.GetTag(Tags.HttpMethod);
+
++        internal static string GetHost(this ISpan span)
++            => span.GetTag(Tags.HttpRequestHeadersHost);
++
++        internal static string GetAbsoluteUrl(this ISpan span)
++            => span.GetTag(Tags.HttpUrl);
++
+         internal static void DecorateWebServerSpan(
+             this Span span,
+             string resourceName,","Where do we _get_ tag values? edit: I mean, where are these `GetFoo()` methods called from? It just seems weird to me that we are getting tag values from spans. I thought we only ever _set_ tags on spans.","This is technically a breaking change, but I don't think it's"
+4084,"@@ -197,6 +197,7 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
+ 	if err != nil {
+ 		return nil, err
+ 	}
++	log.Printf(""Reading kzip with %v encoding"", pref)
+ 	return &Reader{
+ 		zip:         archive,
+ 		root:        root,",This seems like log spam. Maybe expose the encoding as a method and log at the point of interest?,Is this intentional? Shouldn't this be `Infof`?
+4085,"@@ -464,7 +464,7 @@ PCO_PROTOCOL_TYPES = {
+     0x000c: 'P-CSCF IPv4 Address Request',
+     0x0010: 'IPv4 Link MTU Request',
+     0x8021: 'IPCP',
+-    0xc023: 'Password Authentification Protocol',
++    0xc023: 'Password Authentication Protocol',
+     0xc223: 'Challenge Handshake Authentication Protocol',
+ }
+ ","I looked up that one, and it seems correct: Authentification is French, Authentication seems to be correct","I think we need to keep the ""Authentification"" "
+4086,"@@ -22,9 +22,13 @@
+ """"""
+ Plot class used in monitor mixin framework.
+ """"""
+-import matplotlib.pyplot as plt
+-import matplotlib.cm as colorModel
++import traceback
+
++try:
++  # We import in here to avoid creating a matplotlib dependency in nupic.
++  import matplotlib.pyplot as plt
++except ImportError:
++  print traceback.format_exc() + ""\n""
+
+
+ class Plot(object):","Can we print a more human-friendly warning here, saying that plotting won't work or something along those lines?",actually `import traceback` should just be `imp
+4087,"@@ -1,13 +1,15 @@
+ import html
+ import time
+ from typing import Optional, Tuple
+-from mitmproxy import connections
++
+ from mitmproxy import flow
+ from mitmproxy import version
+ from mitmproxy.net import http
++from mitmproxy.proxy import context
+
+ HTTPRequest = http.Request
+ HTTPResponse = http.Response
++HTTPMessage = http.Message
+
+
+ class HTTPFlow(flow.Flow):",@mhils didn't we try to get rid of these (now empty) wrapper classes?,This should be `HTTPMessage = http.Response`
+4088,"@@ -19,6 +19,7 @@ import (
+
+ 	log ""github.com/sirupsen/logrus""
+
++	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/libcalico-go/lib/set""
+ )
+ ",I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build.,Group this with the other projectcalico imports.
+4089,"@@ -137,4 +137,13 @@ public interface Catalog {
+    * @throws NoSuchTableException if the table does not exist
+    */
+   Table loadTable(TableIdentifier identifier);
++
++  /**
++   * Register a table.
++   *
++   * @param identifier a table identifier
++   * @param metadataFileLocation the location of a metadata file
++   * @return a Table instance
++   */
++  Table registerTable(TableIdentifier identifier, String metadataFileLocation);
+ }","Maybe, `import` would be a better name.",I would suggest to add a default implementation
+4090,"@@ -21,10 +21,11 @@ import java.util.List;
+ public class ProtoPagingParameters implements PagingParameters {
+   private static final String PARAMETER_PAGE_TOKEN = ""page_token"";
+   private static final String PARAMETER_NEXT_PAGE_TOKEN = ""next_page_token"";
+-  private static final String PARAMETER_MAX_RESULTS = ""page_size"";
++  private static final String PARAMETER_PAGE_SIZE = ""page_size"";
++  private static final String PARAMETER_MAX_RESULTS = ""max_results"";
+
+   private static final ImmutableList<String> IGNORED_PARAMETERS =
+-      ImmutableList.of(PARAMETER_PAGE_TOKEN, PARAMETER_MAX_RESULTS);
++      ImmutableList.of(PARAMETER_PAGE_TOKEN, PARAMETER_PAGE_SIZE);
+
+   @Override
+   public String getNameForPageToken() {",Wouldn't we want `PARAMETER_MAX_RESULTS` in here as well? (I might be miunderstanding how this is used),why not parameter_page_token here too?
+4091,"@@ -21,4 +21,8 @@ RSpec.configure do |config|
+
+   Capybara.default_host = ""http://localhost:3000""
+   OmniAuth.config.test_mode = true
++
++  config.before(:suite) do
++    Role.ensure_system_roles_exist
++  end
+ end",We can re-use the config in our tests.,This is needed because we explicitly create the
+4092,"@@ -308,7 +308,7 @@ AC_MSG_RESULT([$LIBS])
+ # Dependencies that themselves have a pkg-config file available.
+ #
+ PC_REQUIRES=""""
+-AS_IF([test ""$pmix_hwloc_support_will_build"" = ""yes""],
++AS_IF([test ""$pmix_hwloc_source"" != ""cobuild""],
+       [PC_REQUIRES=""$PC_REQUIRES hwloc""])
+ AS_IF([test $pmix_libevent_support -eq 1],
+       [PC_REQUIRES=""$PC_REQUIRES libevent""])","Wouldn't we have the same issue with the internal libevent? IIRC, the integration is pretty close to an exact duplicate. Or does the libevent m4 code already take that into account when setting this variable? PMIx _requires_ libevent, so it isn't like pmix_libevent_support can be anything other than 1. I'm okay with leaving this question for separate resolution - just wondering why we don't have the same issue here.",I don't think this is correct. We only want hwloc support when $pmix_hwloc_source is set to `cobuild`. We only want hwloc support when $pmix_hwloc_source is set to `yes`.
+4093,"@@ -51,6 +51,9 @@ func (h *tlsHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		strings.Contains(ua, ""Trident"") {
+ 		checked = true
+ 		mitm = !info.looksLikeEdge()
++	} else if strings.Contains(ua, ""CRiOS"") {
++		checked = true
++		mitm = !info.looksLikeChromeOniOS()
+ 	} else if strings.Contains(ua, ""Chrome"") {
+ 		checked = true
+ 		mitm = !info.looksLikeChrome()","The actual User-Agent string uses ""CriOS"" not ""CRiOS""","This looks like a bug, should be `if !info.looksLikeChromeOniOS()`"
+4094,"@@ -19,10 +19,8 @@ namespace Nethermind.Core
+ {
+     public interface IKeyValueStoreWithBatching : IKeyValueStore
+     {
+-        byte[]? this[byte[] key] { get; set; }
+-
+         void StartBatch();
+-
++
+         void CommitBatch();
+     }
+-}
++}","Unused code deletion. Is that a desired thing? No implementation of this actually used this indexer, so removing it seemed reasonable (and was suggested by the compiler). Maybe this had an indexer so plugins could use it? This change is definitely pushing the limits of what is appropriate in a ""cleanup"" as it is changing public API surface area.",Is it safe to remove the key from the batch? Would it make sense to add it to the batch interface as well?
+4095,"@@ -489,6 +489,14 @@ module Beaker
+             end
+
+           rescue Exception => teardown_exception
++            begin
++              if !host.is_pe?
++                dump_puppet_log(host)
++              end
++            rescue Exception => dumping_exception
++              logger.error(""Raised during attempt to dump puppet logs: #{dumping_exception}"")
++            end
++
+             if original_exception
+               logger.error(""Raised during attempt to teardown with_puppet_running_on: #{teardown_exception}\n---\n"")
+               raise original_exception",We'd lose the data here from the original teardown_exception and only get the dump_exception - I fear that that could make the actual error difficult to track if it cascades.,"I don't think this should go in the `begin` block, it's supposed to go in the `finally` block (on the other side of the `begin` block)."
+4096,"@@ -266,6 +266,9 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 					dom.innerHTML = newHtml && newHtml.__html || '';
+ 				}
+ 			}
++			if (newVNode.props.multiple && newVNode.type==='select') {
++				dom.multiple = newVNode.props.multiple;
++			}
+ 			diffChildren(dom, newVNode, oldVNode, context, newVNode.type==='foreignObject' ? false : isSvg, excessDomChildren, mounts, ancestorComponent);
+ 			diffProps(dom, newVNode.props, oldProps, isSvg);
+ 		}",At this point in `diff()` we should know if we're dealing with a `component` or a native `html` element. We can reuse that information in this if-statement here :+1:,why is this needed?
+4097,"@@ -215,7 +215,7 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch {
++	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= a.foundationBonusP2StartEpoch && epochNum <= a.foundationBonusP2EndEpoch) {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","somewhere in reward protocol, we need to do if epoch is Fairbank { a.foundationBonusP2StartEpoch = genesis.xxx a.foundationBonusP2EndEpoch = genesis.yyy p.state(sm, adminKey, &a) } that is to write the 2 new values at Fairbank height then this logic can follow",Why is this change
+4098,"@@ -200,6 +200,10 @@ if __name__ == '__main__':
+     inventory_dao.initialize(SQL_ENGINE)
+     scanner_dao.initialize(SQL_ENGINE)
+
++    # Drop and recreate the CloudAssetInventory table
++    inventory_dao.CaiTemporaryStore.__table__.drop(SQL_ENGINE)
++    inventory_dao.CaiTemporaryStore.__table__.create(SQL_ENGINE)
++
+     # Find all the child classes inherited from declarative base class.
+     SCANNER_DAO_CLASSES = _find_subclasses(scanner_dao.BASE)
+ ","Dropping and recreating would delete all t he previous records, are they any important?",We can use `invento
+4099,"@@ -50,6 +50,15 @@ func (m *mockCgroupManager) Destroy() error {
+ 	return nil
+ }
+
++func (m *mockCgroupManager) Exists() bool {
++	paths := m.GetPaths()
++	if paths != nil {
++		_, err := os.Lstat(paths[""devices""])
++		return err == nil
++	}
++	return false
++}
++
+ func (m *mockCgroupManager) GetPaths() map[string]string {
+ 	return m.paths
+ }","While it is technically OK to use `m.GetPaths()` here, and it's a mock code so it doesn't really matter, I'd still like to have `m.Path(""devices"")` used here, because since commit 714c91e9f73a1512808476eb532b4aa36bbb7530 we're not supposed to use GetPaths() for anything other than state save/restore.",Why is this mocked?
+4100,"@@ -481,6 +481,12 @@ func buildImage(mountPointMap, mountPointToFsTypeMap, mountPointToMountArgsMap m
+ 		setupChrootPackages = append(setupChrootPackages, toolingPackage.Name)
+ 	}
+
++	logger.Log.Infof(""HidepidDisabled is %v."", systemConfig.HidepidDisable)
++	hidepidEnable := true
++	if systemConfig.HidepidDisable {
++		hidepidEnable = false
++	}
++
+ 	if systemConfig.ReadOnlyVerityRoot.Enable {
+ 		// We will need the veritysetup package (and its dependencies) to manage the verity disk, add them to our
+ 		// image setup environment (setuproot chroot or live installer).","Let's be consistent everywhere: either ""Disable""/""Enable"" or ""Disabled""/""Enabled"". I'm voting for the latter.:)",This should be `infof`.
+4101,"@@ -2041,6 +2041,10 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       if (isPruningEnabled()) {
+         throw new ParameterException(commandLine, String.format(""%s %s"", ""Pruning"", errorSuffix));
+       }
++      if (isGoQuorumCompatibilityMode) {
++        throw new ParameterException(
++            commandLine, String.format(""%s %s"", ""GoQuorum mode"", errorSuffix));
++      }
+
+       if (isPrivacyMultiTenancyEnabled
+           && !jsonRpcConfiguration.isAuthenticationEnabled()",this works and is the smallest possible change but we could definitely fail earlier,I would suggest `GoQuor
+4102,"@@ -1,3 +1,4 @@
++//go:build !arm64
+ // +build !arm64
+
+ package nodeps","Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these",Is this line needed?
+4103,"@@ -25,6 +25,8 @@ class NotesScreenComponent extends BaseScreenComponent {
+ 	constructor() {
+ 		super();
+
++		this.prevFolderId_ = null;
++
+ 		this.onAppStateChange_ = async () => {
+ 			// Force an update to the notes list when app state changes
+ 			const newProps = Object.assign({}, this.props);",Could you explain the logic with prevFolderId?,Let's add a dev().asser
+4104,"@@ -0,0 +1,13 @@
++package testutil
++
++import ""github.com/facebookgo/clock""
++
++// TimestampNow get now timestamp from new clock
++func TimestampNow() uint64 {
++	return TimestampNowFromClock(clock.New())
++}
++
++// TimestampNowFromClock get now timestamp from specific clock
++func TimestampNowFromClock(c clock.Clock) uint64 {
++	return uint64(c.Now().Unix())
++}",Please add license header,The godoc for this exported function would be nice.
+4105,"@@ -47,12 +47,13 @@
+
+ namespace lbann {
+
+-lbann_comm* initialize(int& argc, char**& argv, int seed) {
++lbann_comm_ptr initialize(int& argc, char**& argv, int seed) {
+   // Initialize Elemental.
+   El::Initialize(argc, argv);
+   // Create a new comm object.
+   // Initial creation with every process in one model.
+-  auto* comm = new lbann_comm(0);
++  auto comm = lbann_comm_ptr{new lbann_comm(0), &lbann::finalize };
++
+ #if defined(LBANN_TOPO_AWARE)
+   // Determine the number of NUMA nodes present.
+   hwloc_topology_t topo;","It bothers me that the user calls `initialize` without also calling `finalize`. It seems to me that we're essentially making `lbann_comm` a singleton object. Going further down this path, we would put `initialize` inside `lbann_comm`'s constructor and `finalize` in the destructor. This has it's own weirdness - the user must make sure it's lifespan matches the beginning and end of the program. We may also run into the case where someone might want multiple instances of `lbann_comm`, but this is not too important.",Why does this need a `&lbann::finalize`?
+4106,"@@ -353,6 +353,7 @@ void test4() {
+   smi = MolToSmiles(*m);
+   CHECK_INVARIANT(smi == ""c1cc[cH-]c1"", smi);
+   TEST_ASSERT(m->getConformer().is3D() == false);
++  delete m;
+
+   BOOST_LOG(rdInfoLog) << "" Finished <---------- "" << std::endl;
+ }",We should probably make a unique_ptr<ROMol> typedef in ROMol.h and start using that liberally.,what is the purpose of this line?
+4107,"@@ -555,9 +555,13 @@ DefaultSettings.prototype = {
+    * ```
+    *
+    * @type {Boolean|String|Object}
+-   * @default true
++   * @default fillHandle: {
++       autoInsertRow: false,
++     }
+    */
+-  fillHandle: true,
++  fillHandle: {
++    autoInsertRow: false,
++  },
+
+   /**
+    * Allows to specify the number of fixed (or *frozen*) rows at the top of the table.",Can you add missing asterisk?,Why do we have to set it to false?
+4108,"@@ -243,7 +243,15 @@ public class Name {
+   }
+
+   public String toUpperCamelAndDigits() {
+-    char[] upper = toUpperCamel().toCharArray();
++    return capitalizeDigitsAfterNumbers(toUpperCamel());
++  }
++
++  public String toLowerCamelAndDigits() {
++    return capitalizeDigitsAfterNumbers(toLowerCamel());
++  }
++
++  private String capitalizeDigitsAfterNumbers(String camelCaseIdentifier) {
++    char[] upper = camelCaseIdentifier.toCharArray();
+     boolean digit = false;
+     for (int i = 0; i < upper.length; i++) {
+       if (Character.isDigit(upper[i])) {","late to the party, but I bet it meant to be `capitalizeLettersAfterNumbers` :)",Do we still need to call `toUpperCamel()`? What about the `toUpperCamelAndDigits()` one?
+4109,"@@ -235,6 +235,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+     private RecipientPresenter recipientPresenter;
+     private MessageBuilder currentMessageBuilder;
+     private boolean mFinishAfterDraftSaved;
++    private boolean firstTimeEmptyObject = true;
+
+     @Override
+     public void onFocusChange(View v, boolean hasFocus) {","The Activity is recreated on configuration changes and the value of the field is lost. So, e.g. pressing 'send' once will display the error message. If you rotate the device and press 'send' again, the message will show another time. Use `onSaveInstanceState()` and `onRetainInstanceState()` to save and restore the value of the field.","We should probably rename this to ""isFirstTimeEmptyObject"""
+4110,"@@ -643,7 +643,7 @@ func (s *Server) reloadOptions(curOpts, newOpts *Options) error {
+ 	if err != nil {
+ 		return err
+ 	}
+-	// Create a context that is used to pass special info that we may need
++	// Create a ctx that is used to pass special info that we may need
+ 	// while applying the new options.
+ 	ctx := reloadContext{oldClusterPerms: curOpts.Cluster.Permissions}
+ 	s.setOpts(newOpts)","Looks like a ""find and replace"" unintended change here",there is no need to pass a `nil` context in this function.
+4111,"@@ -590,12 +590,13 @@ class SPRegion(PyRegion):
+     inputVector = numpy.array(rfInput[0]).astype('uint32')
+     outputVector = numpy.zeros(self._sfdr.getNumColumns()).astype('uint32')
+
+-    # Switch to using a random SP if learning mode is off and the SP hasn't
+-    # learned anything yet.
++    # Don't strip unlearned columns if learning is off and the SP hasn't
++    # learned anything yet. This acts as a random SP.
+     if (not self.learningMode) and (self._sfdr.getIterationLearnNum() == 0):
+-      self._sfdr.compute(inputVector, self.learningMode, outputVector, False)
++      self._sfdr.compute(inputVector, self.learningMode, outputVector)
+     else:
+       self._sfdr.compute(inputVector, self.learningMode, outputVector)
++      self._sfdr.stripUnlearnedColumns(outputVector)
+
+     self._spatialPoolerOutput[:] = outputVector[:]
+ ",haven't we got rid off `randomSP` recently? (I think `not learn` implied that),why do we want to keep the `False` parameter here?
+4112,"@@ -97,6 +97,7 @@ func (in *{{.Type}}) GetChaos() *ChaosInstance {
+ 		Kind:      Kind{{.Type}},
+ 		StartTime: in.CreationTimestamp.Time,
+ 		Action:    """",
++		Status:    string(in.GetStatus().Experiment.Phase),
+ 		UID:       string(in.UID),
+ 	}
+ ",Why we need use `in.GetStatus()` function here? Can we use `in.Status.xxxx` directly?,Does it work if we change `Action` to `ExperimentPhase`?
+4113,"@@ -93,7 +93,10 @@ func RenewManagedCertificates(allowPrompts bool) (err error) {
+ 				continue
+ 			}
+
+-			// this works well because managed certs are only associated with one name per config
++			// This works well because managed certs are only associated with one name per config.
++			// Note, the renewal inside here may not actually occur and no error will be returned
++			// due to renewal lock (i.e. because a renewal is already happening). This lack of
++			// error is by intention to force cache invalidation as though it has renewed.
+ 			err := cert.Config.RenewCert(allowPrompts)
+
+ 			if err != nil {","@cretz Just a thought: what if another renewal process updates the certificate between the beginning of this for loop (above on line 67) and actually calling RenewCert? Even though we have a read lock on the certCache, something else could have renewed it by now, and finished, which would cause this certificate to be renewed twice. Could you double-check my thinking here and see if that's a plausible 'race' condition? I wonder if the lock needs to be put over this whole function. (It's still early here; I could be wrong...)",s/intention/cache invalidation/ ? (I'm not sure what you
+4114,"@@ -57,13 +57,13 @@ PDEBUG_SYSTEM_OBJECTS g_ExtSystem;
+
+ // Queries for all debugger interfaces.
+ #ifndef FEATURE_PAL
+-extern ""C"" HRESULT
++HRESULT
+ ExtQuery(PDEBUG_CLIENT client)
+ {
+     HRESULT Status;
+     g_ExtClient = client;
+ #else
+-extern ""C"" HRESULT
++HRESULT
+ ExtQuery(ILLDBServices* services)
+ {
+     // Initialize the PAL and extension suppport in one place and only once.",We don't need this for the PInvoke?,Why are all these `extern C` changes necessary?
+4115,"@@ -661,6 +661,10 @@ func (s *scheduler) getMentionedAccounts(ctx context.Context, event model.Notifi
+ 		return nil, err
+ 	}
+
++	if ds.GenericDeploymentConfig.DeploymentNotification == nil {
++		return nil, nil
++	}
++
+ 	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+ 		if e := ""EVENT_"" + v.Event; e == event.String() {
+ 			return v.Slack, nil","nits, I think add a log (using s.logger) to show why does this return with no error is better.",Shouldn't we check for nil here as well?
+4116,"@@ -334,7 +334,10 @@ func (a *WebAPI) getPiped(ctx context.Context, pipedID string) (*model.Piped, er
+ // It gives back error unless the piped belongs to the project.
+ func (a *WebAPI) validatePipedBelongsToProject(ctx context.Context, pipedID, projectID string) error {
+ 	pid, err := a.pipedProjectCache.Get(pipedID)
+-	if err == nil && pid == projectID {
++	if err == nil {
++		if pid != projectID {
++			return status.Error(codes.PermissionDenied, ""Requested piped doesn't belong to the project you logged in"")
++		}
+ 		return nil
+ 	}
+ ","Btw, It would be nice if we have some tests for those validation functions.",It's not clear to me why this check is here and not in `validatePipedBelongsToProject`
+4117,"@@ -23,6 +23,8 @@ public abstract class PathTemplateCheckView {
+
+   public abstract String paramName();
+
++  public abstract String methodName();
++
+   public static Builder newBuilder() {
+     return new AutoValue_PathTemplateCheckView.Builder();
+   }","Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?",I do not think we should add this to the public API...
+4118,"@@ -3,7 +3,8 @@
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2010-2015 NV Access Limited, Mesar Hameed
++#Copyright (C) 2010-2019 NV Access Limited, Mesar Hameed, Takuya Nishimoto
++#Copyright (C) 2018-2019 Takuya Nishimoto
+
+ """"""Utilities related to NVDA Key Commands documents.
+ """"""",Please remove this line,Copyright date should not be changed like this.
+4119,"@@ -599,7 +599,7 @@ void CBOINCGUIApp::OnInitCmdLine(wxCmdLineParser &parser) {
+ #if (defined(__WXMAC__) && defined(_DEBUG))
+     parser.AddLongOption(""NSDocumentRevisionsDebugMode"", _(""Not used: workaround for bug in XCode 4.2""));
+ #endif
+-    parser.AddSwitch(""nd"", ""no-daemon"", _(""Not run the daemon""));
++    parser.AddSwitch(""nd"", ""no-daemon"", _(""Don't run the client""));
+ }
+
+ ",You could change the name of the command line switch too. Short options are typically one character after hyphen. wxWidgets' command line parser seems to handle `-nd` without confusing it with `-n` or `-d` but I'm not sure if that's by design or by accident. I'd remove the short option. `--no-daemon` is with hyphen but the rest of Manager and client uses underscore. Please change that.,"Should this be ""don't run the server"" instead?"
+4120,"@@ -69,8 +69,8 @@ func AddFlags(flagSet *pflag.FlagSet) {
+ 	flags.BoolVarP(flagSet, &fs.Config.IgnoreCaseSync, ""ignore-case-sync"", """", fs.Config.IgnoreCaseSync, ""Ignore case when synchronizing"")
+ 	flags.BoolVarP(flagSet, &fs.Config.NoTraverse, ""no-traverse"", """", fs.Config.NoTraverse, ""Don't traverse destination file system on copy."")
+ 	flags.BoolVarP(flagSet, &fs.Config.NoUpdateModTime, ""no-update-modtime"", """", fs.Config.NoUpdateModTime, ""Don't update destination mod-time if files identical."")
+-	flags.StringVarP(flagSet, &fs.Config.CompareDest, ""compare-dest"", """", fs.Config.CompareDest, ""use DIR to server side copy flies from."")
+-	flags.StringVarP(flagSet, &fs.Config.CopyDest, ""copy-dest"", """", fs.Config.CopyDest, ""Compare dest to DIR also."")
++    flags.StringVarP(flagSet, &fs.Config.CompareDest, ""compare-dest"", """", fs.Config.CompareDest, ""Include additional server-side path during comparison."")
++    flags.StringVarP(flagSet, &fs.Config.CopyDest, ""copy-dest"", """", fs.Config.CopyDest, ""Implies --compare-dest but also copies files from path into destination."")
+ 	flags.StringVarP(flagSet, &fs.Config.BackupDir, ""backup-dir"", """", fs.Config.BackupDir, ""Make backups into hierarchy based in DIR."")
+ 	flags.StringVarP(flagSet, &fs.Config.Suffix, ""suffix"", """", fs.Config.Suffix, ""Suffix to add to changed files."")
+ 	flags.BoolVarP(flagSet, &fs.Config.SuffixKeepExtension, ""suffix-keep-extension"", """", fs.Config.SuffixKeepExtension, ""Preserve the extension when using --suffix."")",File is not `goimports`-ed (from `goimports`),I don't understand this change: `--compare-dest` uses the DIR to server side copy flies from. This is used by the `-dest` flag for comparing files from a directory to a directory.
+4121,"@@ -439,7 +439,7 @@ func (r *RpmRepoCloner) clonePackage(baseArgs []string, enabledRepoOrder ...stri
+ 		logger.Log.Debugf(""stderr: %s"", stderr)
+
+ 		if err != nil {
+-			logger.Log.Errorf(""tdnf error (will continue if the only errors are toybox conflicts):\n '%s'"", stderr)
++			logger.Log.Debugf(""tdnf error (will continue if the only errors are toybox conflicts):\n '%s'"", stderr)
+ 		}
+
+ 		// ============== TDNF SPECIFIC IMPLEMENTATION ==============","Why are we mentioning toybox in this message? AND it still says ""tdnf error"". What's the actual error? Should it be resolved instead of flagged?",did you mean to leave this in?
+4122,"@@ -473,6 +473,7 @@ describe('GridFS Stream', function () {
+                     // Fail if user tries to abort an aborted stream
+                     uploadStream.abort().then(null, function (error) {
+                       expect(error.toString()).to.equal(
++                        // TODO(NODE-3405): Replace with MongoStreamClosedError
+                         'MongoDriverError: Cannot call abort() on a stream twice'
+                       );
+                       client.close(done);",You can remove these if they've been resolved in NODE-3405 and this isn't depending on it,What is the problem here?
+4123,"@@ -1,7 +1,7 @@
+ <%# locals: { phase } %>
+ <div class=""row"" id=""<%= dom_id(phase) %>"">
+   <div class=""col-xs-12"">
+-    <h4>
++    <h4 class=''>
+       <%= _('Instructions') %>
+       <a href=""<%= edit_plan_path(plan_id, phase_id: phase.id) %>"" class=""btn btn-default pull-right""><%= _('Write plan') %></a>
+     </h4>",don't need the class here if its empty,Is it possible to add a `class` attribute to the element itself? Including the closing div?
+4124,"@@ -4,11 +4,15 @@ import Ember from 'ember';
+ import moment from 'moment';
+ import { translationMacro as t } from 'ember-i18n';
+
++const { computed } = Ember;
++
+ export default AppointmentIndexRoute.extend(DateFormat, {
+   editReturn: 'appointments.search',
+   filterParams: ['appointmentType', 'provider', 'status'],
+   modelName: 'appointment',
+-  pageTitle: t('appointments.searchTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('appointments.searchTitle');
++  }),
+
+   queryParams: {
+     appointmentType: { refreshModel: true },",This should be computed('i18n.locale'....,This isn't working as expected. `t('appointments.searchTitle')` returns the string with no translation.
+4125,"@@ -348,8 +348,8 @@ class BigQueryClient:
+             status = self.client.jobs().get(projectId=project_id, jobId=job_id).execute(num_retries=10)
+             if status['status']['state'] == 'DONE':
+                 if status['status'].get('errorResult'):
+-                    raise Exception('BigQuery job failed: {}'.format(status['status']['errorResult']))
+-                return
++                    raise BigQueryExecutionError(job_id, status['status']['errorResult'])
++                return job_id
+
+             logger.info('Waiting for job %s:%s to complete...', project_id, job_id)
+             time.sleep(5)",Please add return and return type description to docstring of this method.,You can remove this return statement as well.
+4126,"@@ -51,8 +51,10 @@ class ContributionsController < ApplicationController
+   private
+
+   def set_contributor
+-    @contributor = ContributorFact.where(names: { id: params[:id] }).where(analysis_id: @project.best_analysis_id)
+-                   .eager_load(:name).first
++    id = params[:id].to_i
++    @contributor = Contribution.find(id).name_fact if id > (1 << 32)
++    @contributor ||= ContributorFact.where(names: { id: id }).where(analysis_id: @project.best_analysis_id)
++                     .eager_load(:name).first
+     fail ParamRecordNotFound unless @contributor
+   end
+ ",What does 1 << 32 do? In irb typing this yields 4294967296. I didn't find the append operator in Numeric or Integer.,Layout/MultilineMethodCallIndentation: Align .eager_load with .find on line 29.
+4127,"@@ -79,6 +79,16 @@ module RSpec
+         RSpec.configuration.format_docstrings_block.call(description)
+       end
+
++      # @attr_accessor
++      #
++      # Holds the completion status of the example (nil if not completed)
++      attr_accessor :succeeded
++
++      # Convenience method for getting success status of example
++      def succeeded?
++        @succeeded
++      end
++
+       # @attr_reader
+       #
+       # Returns the first exception raised in the context of running this","We generally use metadata for this sort of thing, indeed there is a `metadata[:execution_result]`.",Is this necessary? I don't see it being used in this PR.
+4128,"@@ -483,6 +483,8 @@ class SpreadPlot(ElementPlot):
+     style_opts = line_properties + fill_properties
+     _plot_methods = dict(single='patch')
+
++    _stream_data = False # Plot does not support streaming data
++
+     def get_data(self, element, ranges, style):
+          mapping = dict(x='x', y='y')
+          xvals = element.dimension_values(0)",This was very confusing until I realized this might refer to the *bokeh* use of the word 'streaming'.,Can you add a `TODO` so that we remember to remove this in the future?
+4129,"@@ -47,6 +47,10 @@ type TaskHandler struct {
+ 	tasksToEvents map[string]*eventList
+ 	// tasksToEventsLock for locking the map
+ 	tasksToEventsLock sync.RWMutex
++	// batchMap is used to collect container events
++	// between task transitions
++	batchMap     map[string][]api.ContainerStateChange
++	batchMapLock sync.RWMutex
+ }
+
+ // NewTaskHandler returns a pointer to TaskHandler","Can you rename this as `tasksToContainerStates` ? If you do that, you can rename the lock as well","You don't need to lock here, you're not doing anything with it."
+4130,"@@ -177,7 +177,7 @@ public class UserAccountManager {
+ 	 */
+ 	public Account getCurrentAccount() {
+         final Account[] accounts = accountManager.getAccountsByType(accountType);
+-        if (accounts == null || accounts.length == 0) {
++        if (accounts.length == 0) {
+         	return null;
+         }
+ ",Fixing `lint` warnings that have existed for a while.,`accounts == null || accounts.length == 0`
+4131,"@@ -452,6 +452,18 @@ public interface Iterator<T> extends java.util.Iterator<T>, Traversable<T> {
+         return io.vavr.collection.Collections.fill(n, s);
+     }
+
++    /**
++     * Returns a Iterator containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Iterator
++     * @param n       The number of elements
++     * @param element The element
++     * @return An iterator of {@code n} sequence elements, where each element is the given {@code element}.
++     */
++    static <T> Iterator<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element);
++    }
++
+     /**
+      * Creates an Iterator of characters starting from {@code from}, extending to {@code toExclusive - 1}.
+      * <p>","An iterator **of {\@code n} sequential elements,** where each element ~are~ **is the** given {\@code element}.",What do you think about making `fillObject` take an `Iterable<T>` inst
+4132,"@@ -3,11 +3,13 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
++using Datadog.Trace.Configuration;
++
+ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AdoNet.MySql
+ {
+     internal static class MySqlConstants
+     {
+-        public const string SqlCommandIntegrationName = ""MySqlCommand"";
++        public const string SqlCommandIntegrationName = nameof(IntegrationIds.AdoNet);
+
+         internal struct MySqlDataClientData : IAdoNetClientData
+         {","If all of the `SqlCommandIntegrationName` values are the same, can we just remove it from `IAdoNetClientData` entirely and put the constant there?",I wonder if we should make this `internal` and move it into the `Datadog.Trace.Configuration` namespace
+4133,"@@ -17,6 +17,8 @@ limitations under the License.
+ package venafi
+
+ import (
++	""github.com/go-logr/logr""
++	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ 	corelisters ""k8s.io/client-go/listers/core/v1""
+
+ 	apiutil ""github.com/jetstack/cert-manager/pkg/api/util""",Maybe regroup this import with the other cert-manager packages.,Remove this line.
+4134,"@@ -167,6 +167,8 @@ public class UserPreferences {
+         int theme = getTheme();
+         if (theme == R.style.Theme_AntennaPod_Dark) {
+             return R.style.Theme_AntennaPod_Dark_NoTitle;
++        }else if (theme == R.style.Theme_AntennaPod_TrueBlack){
++            return R.style.Theme_AntennaPod_TrueBlack_NoTitle;
+         } else {
+             return R.style.Theme_AntennaPod_Light_NoTitle;
+         }",There are spaces missing ;) Just have a look at the code style of the `if` statement above,Nitpick: missing space before `{`
+4135,"@@ -55,6 +55,9 @@ func (w *DefaultWorker) Generate(
+ 	mq := NewMessageQueue(pending)
+ 	candidateMsgs := orderMessageCandidates(mq.Drain())
+ 	candidateMsgs = w.filterPenalizableMessages(ctx, candidateMsgs)
++	if len(candidateMsgs) > block.BlockMessageLimit {
++		candidateMsgs = candidateMsgs[:block.BlockMessageLimit]
++	}
+
+ 	var blsAccepted []*types.SignedMessage
+ 	var secpAccepted []*types.SignedMessage","We should pass the size limit as a parameter to Drain so that we don't take messages out of the pool and then drop them. It's ok to merge as is, I will file an issue.",why not just move this line to where it's used?
+4136,"@@ -1059,7 +1059,16 @@ encode_with_patch_list(dcontext_t *dcontext, patch_list_t *patch, instrlist_t *i
+             instr_encode_to_copy(dcontext, inst, vmcode_get_writable_addr(pc), pc);
+         byte *nxt_pc = vmcode_get_executable_addr(nxt_writable_pc);
+         ASSERT(nxt_pc != NULL);
++#ifdef AARCH64
++        /* Unlike X86 and ARM/AArch32 which use 1 instruction for an indirect jump,
++         * AArch64 requires 2 instructions: LDR+BR, see INSTR_CREATE_ldr()
++         * followed by XINST_CREATE_jump_reg() calls in
++         * emit_special_ibl_xfer().
++         */
++        len = (int)(nxt_pc - pc) + AARCH64_INSTR_SIZE;
++#else
+         len = (int)(nxt_pc - pc);
++#endif
+         pc = nxt_pc;
+
+         if (cur < patch->num_relocations && inst == patch->entry[cur].where.instr) {",Patch lists are used in many places so this is going to break other updates. This should just be a local change in emit_special_ibl_xfer() to pass the second-to-last instruction instead of the last instruction.,`(int)nxt_pc - pc` can be replaced with `nxt_pc - pc`.
+4137,"@@ -38,7 +38,7 @@ char const * test_genesis_data = R""%%%({
+ 	""source"": ""B0311EA55708D6A53C75CDBF88300259C6D018522FE3D4D0A242E431F9E8B6D0"",
+ 	""representative"": ""xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo"",
+ 	""account"": ""xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo"",
+-	""work"": ""9680625b39d3363d"",
++	""work"": ""7b42a00ee91d5810"",
+ 	""signature"": ""ECDA914373A2F0CA1296475BAEE40500A7F0A7AD72A5A80C81D7FAB7F6C802B2CC7DB50F5DD0FB25B2EF11761FA7344A158DD5A700B21BD47DE5BD0F63153A02""
+ 	})%%%"";
+ ","@argakiig previous work was above live threshold, causing the high difficulty to bleed into other blocks when genesis open was processed in tests.",Can you confirm this is the correct work for this PR?
+4138,"@@ -1,4 +1,4 @@
+-class RemoveDiscountPercentageAndDiscountTitleFromProducts < ActiveRecord::Migration
++class RemoveDiscountPercentageAndDiscountTitleFromProducts < ActiveRecord::Migration[4.2]
+   def change
+     remove_column :products, :discount_percentage, :integer
+     remove_column :products, :discount_title, :string",Metrics/LineLength: Line is too long. [89/80],Line is too long. [100/80]
+4139,"@@ -30,6 +30,7 @@ type SystemConfig struct {
+ 	Encryption         RootEncryption      `json:""Encryption""`
+ 	RemoveRpmDb        bool                `json:""RemoveRpmDb""`
+ 	ReadOnlyVerityRoot ReadOnlyVerityRoot  `json:""ReadOnlyVerityRoot""`
++	HidepidDisable     bool                `json:""HidepidDisable""`
+ }
+
+ // GetRootPartitionSetting returns a pointer to the partition setting describing the disk which",Please also extend the config tests now to include the new field.,This should be `HidepidDisable` throughout the PR.
+4140,"@@ -53,6 +53,7 @@ namespace NLog.Layouts
+         public JsonLayout()
+         {
+             this.Attributes = new List<JsonAttribute>();
++            this.RenderEmptyLiteral = true;
+         }
+
+         /// <summary>",I think it's wise to keep the behavior backwards-compatible (so `false` as default),"I'm not sure if this is the right place for it. As far as I can tell, this is never set."
+4141,"@@ -47,7 +47,7 @@ module Selenium
+
+         opts[:path] ||= '/'
+         opts[:secure] ||= false
+-
++        opts[:sameSite]
+         obj = opts.delete(:expires)
+         opts[:expiry] = seconds_from(obj).to_i if obj
+ ","We don't need this line, do we?",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoi
+4142,"@@ -0,0 +1,4 @@
++# Proprietary German backlinks service.
++# They keep requesting invalid formats.
++User-agent: SEOkicks-Robot
++Disallow: /",I don't know if we've actually had this problem on Upcase. I'd lean towards having a blank file unless (like on robots) we see multiple errors per week from this crawler.,can we change this to be `saleor/saleor/__init__.py` ?
+4143,"@@ -179,7 +179,13 @@ static void render_decorations(struct roots_view *view,
+ 	float matrix[16];
+ 	wlr_matrix_project_box(&matrix, &project_box, WL_OUTPUT_TRANSFORM_NORMAL,
+ 		view->rotation, &output->transform_matrix);
+-	float color[4] = { 0.2, 0.2, 0.2, 1 };
++	float color[4]	= { 0.2, 0.2, 0.2, 1 };
++	if (view_get_activated(view)) {
++		color[0] = 0.09804;
++		color[1] = 0.09804;
++		color[2] = 0.43921;
++	}
++
+ 	wlr_render_colored_quad(desktop->server->renderer, &color, &matrix);
+ }
+ ","I'm not good at picking colors, if anyone else has a preference.",Please use `0.0` and `0.1` instead.
+4144,"@@ -50,6 +50,10 @@ class FoldersScreenUtils {
+ 			this.refreshFolders();
+ 		}, 1000);
+ 	}
++
++	static cancelTimers() {
++		if (this.scheduleRefreshFoldersIID_) clearTimeout(this.scheduleRefreshFoldersIID_);
++	}
+ }
+
+ module.exports = { FoldersScreenUtils };","Note that even if you cancel the timer, the refreshFolders function might still be running since it's async. Could that be a problem for the test units? One big issue I had with tests is they sometimes would work and sometimes fail randomly, and that's because there are still code running in the background. One example was the ItemChange class, which saves data asynchronously. So I've implemented a waitForAllSaved(), which can be used for test units, to make sure nothing is running once the test ends. So just wondering if we might end up with this issue here.","this.scheduleRefreshFoldersIID_ = setTimeout(this.scheduleRefreshFoldersIID_, 1000);"
+4145,"@@ -0,0 +1,16 @@
++'use strict';
++
++const tsd = require('tsd').default;
++const { expect } = require('chai');
++
++describe('Exported Types', () => {
++  it('should be as expected', async () => {
++    const diagnostics = await tsd();
++    if (diagnostics.length !== 0) {
++      const messages = diagnostics
++        .map(d => `${d.fileName}:${d.line}:${d.column} - [${d.severity}]: ${d.message}`)
++        .join('\n');
++      expect.fail('\n' + messages);
++    }
++  });
++});","can we make this something more descriptive? like... types should compile? I'm still not sure exactly what this is testing... this says ""Exported types"" - but what does tsd actually look at?",Just curious: What is the purpose of this `expect.fail` call?
+4146,"@@ -48,17 +48,12 @@ public class BridgeWebChromeClient extends WebChromeClient {
+     callback.onCustomViewHidden();
+     super.onShowCustomView(view, callback);
+   }
+-
+-  @Override
+-  public void onHideCustomView() {
+-    super.onHideCustomView();
+-  }
+
+   @Override
+   public void onPermissionRequest(final PermissionRequest request) {
+     boolean isRequestPermissionRequired = android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M;
+
+-    List<String> permissionList = new ArrayList<String>();
++    List<String> permissionList = new ArrayList<>();
+     if (Arrays.asList(request.getResources()).contains(""android.webkit.resource.VIDEO_CAPTURE"")) {
+       permissionList.add(Manifest.permission.CAMERA);
+     }",this method is need for full screen video button to appear in players,"Removed the super call because it doesn't seem to have any effect on the UI, and it'"
+4147,"@@ -26,6 +26,7 @@ type HeadersCfg struct {
+ 	penalize          func(context.Context, []headerdownload.PenaltyItem)
+ 	wakeUpChan        chan struct{}
+ 	batchSize         datasize.ByteSize
++	increment         *uint64
+ }
+
+ func StageHeadersCfg(",Why is this a pointer?,what is this used for?
+4148,"@@ -30,12 +30,16 @@ import org.apache.iceberg.expressions.Expression;
+ import org.apache.iceberg.expressions.Expressions;
+ import org.apache.iceberg.expressions.UnboundPredicate;
+ import org.apache.iceberg.relocated.com.google.common.base.Objects;
++import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.types.Type;
+ import org.apache.iceberg.util.UnicodeUtil;
+
+ abstract class Truncate<T> implements Transform<T, T> {
+   @SuppressWarnings(""unchecked"")
+   static <T> Truncate<T> get(Type type, int width) {
++    Preconditions.checkArgument(width > 0,
++        ""The width of truncate must larger than zero,but is %s"", width);
++
+     switch (type.typeId()) {
+       case INTEGER:
+         return (Truncate<T>) new TruncateInteger(width);",nit: Space after comma,nit: add a space after `and is`
+4149,"@@ -853,6 +853,11 @@ class XLongField(LongField):
+         return lhex(self.i2h(pkt, x))
+
+
++class XLELongField(LELongField, XLongField):
++    def i2repr(self, pkt, x):
++        return XLongField.i2repr(self, pkt, x)
++
++
+ class IEEEFloatField(Field):
+     def __init__(self, name, default):
+         Field.__init__(self, name, default, ""f"")",A similar field is already define in `scapy/layers/bluetooth.py`. Can you merge both definitions ?,does this need to be public?
+4150,"@@ -204,6 +204,19 @@ class CppGenerator : public BaseGenerator {
+     if (num_includes) code_ += """";
+   }
+
++  void GenExtraIncludes() {
++    if(parser_.opts.cpp_includes.empty()) {
++      return;
++    }
++    // non-const copy needed for std::strtok
++    std::string data = parser_.opts.cpp_includes;
++    for(char* pch = std::strtok(&data[0], "","");
++        pch != nullptr; pch = std::strtok(nullptr, "","")) {
++      code_ += ""#include <"" + std::string(pch) + "">"";
++    }
++    code_ += """";
++  }
++
+   std::string EscapeKeyword(const std::string &name) const {
+     return keywords_.find(name) == keywords_.end() ? name : name + ""_"";
+   }","`std::strtok` isn't necessary. The `std::string::find_first_of` is better C++ alternative to `std::strtok`. For example, see `CheckedError Parser::ParseEnumFromString` method.",Prefer `char*` to `char*` if yo
+4151,"@@ -3,9 +3,6 @@ namespace Psalm\CodeLocation;
+
+ class DocblockTypeLocation extends \Psalm\CodeLocation
+ {
+-    /** @var int */
+-    public $raw_line_number;
+-
+     public function __construct(
+         \Psalm\FileSource $file_source,
+         int $file_start,",This property is already declared in a parent with the same visibility/type/value. This one is redundant.,"Same as above, why remove this?"
+4152,"@@ -78,6 +78,8 @@ def autorun_get_interactive_session(cmds, **kargs):
+             self.s = """"
+         def write(self, x):
+             self.s += x
++        def flush(self):
++            pass
+
+     sw = StringWriter()
+     sstdout,sstderr = sys.stdout,sys.stderr","This is required, otherwise multiprocessing will (for some reason) crash",does this need to be public?
+4153,"@@ -19,6 +19,7 @@ package main
+ import (
+ 	""encoding/base64""
+ 	""fmt""
++	""github.com/algorand/go-algorand/data/basics""
+ 	""io""
+ 	""io/ioutil""
+ 	""os""",Please put in a separate line-separated block,This import should go with t
+4154,"@@ -100,7 +100,7 @@ func (cmd *Command) Wait() error {
+ func (cmd *Command) Kill() error {
+ 	err := cmd.connectionManager.Disconnect()
+ 	if err != nil {
+-		return err
++		fmt.Printf(""Disconnect error: %s\n"", err)
+ 	}
+
+ 	cmd.httpApiServer.Stop()","Should error be eaten? If so, not clear why",Is this output useful?
+4155,"@@ -145,4 +145,7 @@ class AuthorizationPolicy(core_authorization.AuthorizationPolicy):
+
+
+ class RouteFactory(core_authorization.RouteFactory):
+-    pass
++    def __init__(self, request):
++        super(RouteFactory, self).__init__(request)
++        if self.on_collection and self.resource_name == 'bucket':
++            self.force_empty_list = True","This attribute is not defined if the condition is not met. Instead, you could define another RouteFactory (e.g. `BucketRouteFactory` with a class attribute like `allow_empty_list`)",I don't believe that we need
+4156,"@@ -103,6 +103,13 @@ func WithCondition(cond hivev1.ClusterDeploymentCondition) Option {
+ 	}
+ }
+
++// WithInstalledTimestamp adds the specified InstalledTimestamp to ClusterDeployment.Status
++func WithInstalledTimestamp(timestamp metav1.Time) Option {
++	return func(clusterDeployment *hivev1.ClusterDeployment) {
++		clusterDeployment.Status.InstalledTimestamp = &timestamp
++	}
++}
++
+ func WithUnclaimedClusterPoolReference(namespace, poolName string) Option {
+ 	return WithClusterPoolReference(namespace, poolName, """")
+ }",Can we use the existing `InstalledTimestamp` function?,"I don't think we should be modifying status here. @smarterclayton, what do you think?"
+4157,"@@ -975,14 +975,15 @@ public class AddProductActivity extends AppCompatActivity {
+         if (!editionMode) {
+             if (addProductOverviewFragment.areRequiredFieldsEmpty()) {
+                 viewPager.setCurrentItem(0, true);
+-            } else if (isNutritionDataAvailable() && addProductNutritionFactsFragment.containsInvalidValue()) {
++            } else if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) {
+                 viewPager.setCurrentItem(2, true);
+             } else {
+                 saveProduct();
+             }
+         } else {
+             // edit mode, therefore do not check whether front image is empty or not however do check the nutrition facts values.
+-            if ((isNutritionDataAvailable()) && addProductNutritionFactsFragment.containsInvalidValue()) {
++            if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) {
++                // If there are any invalid field and there is nutrition data, scroll to the nutrition fragmento
+                 viewPager.setCurrentItem(2, true);
+             } else {
+                 saveEditedProduct();","weird naming: `is` but `fields` (plural or singular ?) . If the method checks if the fragment has an invalid value, then ""hasInvalidValue"" or ""containsInvalidValue"" is fine no ?",Is there a reason for this change?
+4158,"@@ -28,7 +28,7 @@ LISTENS_PER_PAGE = 25
+ user_bp = Blueprint(""user"", __name__)
+
+
+-@user_bp.route(""/<user_name>"")
++@user_bp.route(""/<user_name>/"")
+ def profile(user_name):
+     # Which database to use to showing user listens.
+     db_conn = webserver.timescale_connection._ts",Does this mean that `listenbrainz.org/user/iliekcomputers` will start getting 404s?,Is there any way we can generalize this so that we don't have to change current route
+4159,"@@ -23,7 +23,11 @@ module Blacklight
+       # CatalogController.include ModuleDefiningNewMethod
+       # CatalogController.search_params_logic += [:new_method]
+       # CatalogController.search_params_logic.delete(:we_dont_want)
+-      self.search_params_logic = [:default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr, :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr, :add_sorting_to_solr, :add_group_config_to_solr ]
++      self.search_params_logic = [
++        :default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr,
++        :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr,
++        :add_sorting_to_solr, :add_group_config_to_solr, :add_facet_paging_to_solr
++      ]
+
+       if self.respond_to?(:helper_method)
+         helper_method(:facet_limit_for)",Line is too long. [82/80],Align the elements of an array literal if they span more than one line.
+4160,"@@ -28,6 +28,7 @@ CAN_INV_FILTER = 0x20000000
+
+ class CANSocket(SuperSocket):
+     desc = ""read/write packets at a given CAN interface using PF_CAN sockets""
++    async_select_unrequired = True
+
+     def __init__(self, iface=None, receive_own_messages=False,
+                  can_filters=None, remove_padding=True, basecls=CAN):",That's a strange name =),make this `False` by default
+4161,"@@ -48,6 +48,17 @@ describe CommunicartMailer do
+       end
+     end
+
++    context 'custom templates' do
++      it 'renders a default template when an origin is not indicated' do
++        expect(mail.body.encoded).to include('Purchase Request')
++      end
++
++      it 'renders a custom template when origin is indicated' do
++        approval.cart.properties << Property.create!(property: 'origin', value:'whsc')
++        expect(mail.body.encoded).to include('White House Service Center: Purchase Request')
++      end
++    end
++
+   end
+
+   describe 'approval reply received email' do",Thoughts on this? I'm not crazy about the brittleness of this but haven't found a good way to test more generically that a specific (custom) template has been rendered.,Style/StringLiterals: Prefer
+4162,"@@ -30,6 +30,7 @@ createMethods(Results.prototype, objectTypes.RESULTS, [
+     'filtered',
+     'sorted',
+     'snapshot',
++    'subscribe',
+     'isValid',
+     'indexOf',
+     'min',",Have we reached binding-level agreement on the `subscribe` terminology? My only concern is that it doesn't seem descriptive enough and may be confused with subscribing for notifications.,Perhaps you could add a `.`
+4163,"@@ -138,7 +138,9 @@ func (tr *tracer) newRecordingSpan(psc, sc trace.SpanContext, name string, sr Sa
+ 	}
+
+ 	for _, l := range config.Links() {
+-		s.addLink(l)
++		if l.SpanContext.IsValid() {
++			s.addLink(l)
++		}
+ 	}
+
+ 	s.SetAttributes(sr.Attributes...)",would it not be safer to move this condition to the `addLink` method?,It would be nice if we didn'
+4164,"@@ -611,6 +611,13 @@ func (h *Handler) reverseProxy(rw http.ResponseWriter, req *http.Request, di Dia
+
+ 	rw.WriteHeader(res.StatusCode)
+
++	// for some apps which need a correct response header to start http2 streaming,
++	// it's important to explicit flush headers to the client before copy streaming data.
++	if req.ProtoMajor == 2 && res.ContentLength == -1 {
++		if wf, ok := rw.(http.Flusher); ok {
++			wf.Flush()
++		}
++	}
+ 	err = h.copyResponse(rw, res.Body, h.flushInterval(req, res))
+ 	res.Body.Close() // close now, instead of defer, to populate res.Trailer
+ 	if err != nil {","I think this might read better: > some apps need the response headers before starting to stream content with http2, so it's important to explicitly flush the headers to the client before streaming the data.","I think this should be `if req.ProtoMajor == 2 && res.ContentLength == -1 {`, right?"
+4165,"@@ -47,6 +47,13 @@ public interface FileScanTask extends ScanTask {
+    */
+   PartitionSpec spec();
+
++  /**
++   * The partition data for the file of this task.
++   *
++   * @return the partition data for the file of this task
++   */
++  StructLike partition();
++
+   /**
+    * The starting position of this scan range in the file.
+    *","What does this return if there is no partition? I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar.",does this need to be `@Nullable`?
+4166,"@@ -493,7 +493,16 @@ func DeleteRepo(
+
+ 	_, _, err = kbfsOps.Lookup(ctx, repoNode, normalizedRepoName)
+ 	if err != nil {
+-		return err
++		// For the common ""repo doesn't exist"" case, use an error type that the
++		// client can recognize.
++		switch errors.Cause(err).(type) {
++		case libkbfs.NoSuchNameError:
++			return libkb.RepoDoesntExistError{
++				Name: repoName,
++			}
++		default:
++			return err
++		}
+ 	}
+
+ 	deletedReposNode, err := lookupOrCreateDir(","Also, it might be worth returning this for the above lookup on `kbfsRepoDir` as well, which could happen if someone tries to delete a repo in a TLF that has never had any repos at all.",Is there a better way to do this?
+4167,"@@ -171,6 +171,12 @@ var (
+ 		Usage: ""IP address to bind API to"",
+ 		Value: ""127.0.0.1"",
+ 	}
++	// FlagTequilapiAllowedHostnames Restrict hostnames in requests' Host header to following domains.
++	FlagTequilapiAllowedHostnames = cli.StringFlag{
++		Name:  ""tequilapi.allowed-hostnames"",
++		Usage: ""Comma separated list of allowed domains. Prepend value with dot for wildcard mask"",
++		Value: "".localhost, localhost, .localdomain"",
++	}
+ 	// FlagTequilapiPort port for listening for incoming API requests.
+ 	FlagTequilapiPort = cli.IntFlag{
+ 		Name:  ""tequilapi.port"",",Can this be `Hidden: true` as we already have a bunch of flags that are printed on `--help` and this seems like an average person should not care about it.,Maybe change the name to `tequilapi.server.allowed-hosts`?
+4168,"@@ -488,11 +488,13 @@ class Controller
+
+         $useCache = !Config::get('cms.twigNoCache');
+         $isDebugMode = Config::get('app.debug', false);
++        $strictVariables = (Config::get('cms.enableTwigStrictVariables', null) !== null) ?: $isDebugMode;
+         $forceBytecode = Config::get('cms.forceBytecodeInvalidation', false);
+
+         $options = [
+             'auto_reload' => true,
+             'debug' => $isDebugMode,
++            'strict_variables' => $strictVariables,
+         ];
+
+         if ($useCache) {",Wouldn't this set $strictVariables = true when Config::get returns false?,"Why don't you use `Config::get('cms.twigStrictVariables', null) ?: $isDebugMode`?"
+4169,"@@ -16,6 +16,7 @@ import javax.json.JsonReader;
+ import javax.xml.parsers.DocumentBuilder;
+ import javax.xml.parsers.DocumentBuilderFactory;
+ import static junit.framework.Assert.assertEquals;
++import org.junit.Ignore;
+ import org.junit.Test;
+ import org.xml.sax.ErrorHandler;
+ import org.xml.sax.InputSource;",was this meant to be checked in?,"minor: unused import, can be removed"
+4170,"@@ -156,4 +156,8 @@ const (
+ 	// attempt to reconnect a route, gateway or leaf node connection.
+ 	// The default is to report every attempt.
+ 	DEFAULT_RECONNECT_ERROR_REPORTS = 1
++
++	// DEFAULT_RTT_MEASUREMENT_INTERVAL	is how often we want to measure RTT from
++	// this server to clients, routes, gateways or leafnode connections.
++	DEFAULT_RTT_MEASUREMENT_INTERVAL = time.Hour
+ )",check spaces after const name...,"Not a huge deal, but why the period at the end?"
+4171,"@@ -67,7 +67,10 @@ func (agent *ecsAgent) appendVolumeDriverCapabilities(capabilities []*ecs.Attrib
+
+ func (agent *ecsAgent) appendNvidiaDriverVersionAttribute(capabilities []*ecs.Attribute) []*ecs.Attribute {
+ 	if agent.resourceFields != nil && agent.resourceFields.NvidiaGPUManager != nil {
+-		capabilities = appendNameOnlyAttribute(capabilities, attributePrefix+capabilityNvidiaDriverVersionInfix+agent.resourceFields.NvidiaGPUManager.GetDriverVersion())
++		driverVersion := agent.resourceFields.NvidiaGPUManager.GetDriverVersion()
++		if driverVersion != """" {
++			capabilities = appendNameOnlyAttribute(capabilities, attributePrefix+capabilityNvidiaDriverVersionInfix+driverVersion)
++		}
+ 	}
+ 	return capabilities
+ }","If the GPU setting is enabled, resourceFields.NvidiaGPUManager will be nil, right?","is the `!= """"` check here unnecessary?"
+4172,"@@ -363,7 +363,11 @@ HELP
+             when 'command'
+               executor.run_command(nodes, options[:object])
+             when 'script'
+-              executor.run_script(nodes, options[:object], options[:leftovers])
++              script = options[:object]
++              unless file_exist?(script)
++                raise Bolt::CLIError, ""The script '#{script}' does not exist""
++              end
++              executor.run_script(nodes, script, options[:leftovers])
+             when 'task'
+               task_name = options[:object]
+ ",We should probably verify that it's readable too,Metrics/LineLength: Line is too long. [90/80]
+4173,"@@ -355,7 +355,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+                                     throw new InvalidDataException(""Expected key value before dictionary data."");
+                                 }
+
+-                                string value = xmlReader.ReadElementContentAsString();
++                                xmlReader.ReadElementContentAsString();
+                                 readerMoved = true;
+                                 keyName = string.Empty;
+                                 break;","See, here's an example where you removed the variable but kept the call, which makes sense.",Not needed since `XmlReader.ReadElementConten
+4174,"@@ -78,12 +78,12 @@ public class FeedParserTask implements Callable<FeedHandlerResult> {
+         }
+
+         if (successful) {
+-            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(),
+-                    DownloadError.SUCCESS, successful, reasonDetailed);
++            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(), DownloadError.SUCCESS,
++                                                successful, reasonDetailed, request.isInitiatedByUser());
+             return result;
+         } else {
+-            downloadStatus = new DownloadStatus(feed, request.getTitle(),
+-                    reason, successful, reasonDetailed);
++            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(), reason, successful,
++                                                reasonDetailed, request.isInitiatedByUser());
+             return null;
+         }
+     }","Please use `request.getTitle()` instead of `feed.getHumanReadableIdentifier()`: In this case, `feed` does not have a human readable title yet",What's the purpose of this change?
+4175,"@@ -254,7 +254,7 @@ func waitForClef(logger logging.Logger, maxRetries uint64, endpoint string) (ext
+ 			return nil, err
+ 		}
+ 		maxRetries--
+-		logger.Errorf(""cannot connect to clef signer: %v"", err)
++		logger.Warningf(""failing to connect to clef signer: %v"", err)
+
+ 		time.Sleep(5 * time.Second)
+ 	}",I think the wording on the left is better,Why was this changed?
+4176,"@@ -69,7 +69,7 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // YARPC.
+ func Interceptor(interceptor func(yarpcHandler http.Handler) http.Handler) InboundOption {
+ 	return func(i *Inbound) {
+-		i.interceptor = interceptor
++		i.interceptors = append(i.interceptors, interceptor)
+ 	}
+ }
+ ",Please update the method described to point out that it maintains a chain of interceptors and they will be called in the same order passed in the options.,"`interceptors` is a copy of `interceptor`, no need to copy it."
+4177,"@@ -37,9 +37,16 @@ namespace Datadog.Trace.ClrProfiler.Managed.Loader
+             }
+
+             var path = Path.Combine(ManagedProfilerDirectory, $""{assemblyName}.dll"");
++
+             if (File.Exists(path))
+             {
+-                StartupLogger.Debug(""Loading {0}"", path);
++                if (args.Name.StartsWith(""Datadog.Trace, Version="") && args.Name != AssemblyName)
++                {
++                    StartupLogger.Debug(""Trying to load {0} which does not match the expected version ({1})"", args.Name, AssemblyName);
++                    return null;
++                }
++
++                StartupLogger.Debug(""Resolving {0}, loading {1}"", args.Name, path);
+                 return Assembly.LoadFrom(path);
+             }
+ ",Is this case purely hypothetical or did it solve an issue that occurred in your testing? I'm trying to understand this change a little better,We should only do this when `args.Name != AssemblyName`
+4178,"@@ -431,7 +431,7 @@ func (p *ReplicationTaskProcessorImpl) putReplicationTaskToDLQ(replicationTask *
+ 	p.metricsClient.Scope(
+ 		metrics.ReplicationDLQStatsScope,
+ 		metrics.TargetClusterTag(p.sourceCluster),
+-		metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())),
++		metrics.InstanceTag(strconv.Itoa(int(p.shard.GetShardID()))),
+ 	).UpdateGauge(
+ 		metrics.ReplicationDLQMaxLevelGauge,
+ 		float64(request.TaskInfo.GetTaskId()),",Use instead `convert.Int32ToString` that was added in #762 for this purpose.,Why do we need to cast it to an int here?
+4179,"@@ -473,7 +473,7 @@ public final class HashSet<T> implements Kind1<HashSet<?>, T>, Set<T>, Serializa
+
+     @Override
+     public HashSet<T> add(T element) {
+-        return new HashSet<>(tree.put(element, element));
++        return contains(element) ? this : new HashSet<>(tree.put(element, element));
+     }
+
+     @Override","If key is present, tree.put(k,v) needs to return a new instance for Maps and the same instance for Sets. Therefore we currently perform an additional 'contains' check for Sets. A future optimization may add an additional flag `replace` to the backing HAMT.put() / RedBlackTree.insert() methods. Sets set it to replace=false, Maps set it to replace=true. But for now this solution is working for us.","I think this should be the exact same behavior as before, i.e."
+4180,"@@ -0,0 +1,18 @@
++""""""Test to see we don't crash on this code in pandas.
++See: https://github.com/pandas-dev/pandas/blob/master/pandas/core/arrays/sparse/array.py
++Code written van G van Rossum here: https://github.com/python/typing/issues/684""""""
++# pylint: disable=no-member, redefined-builtin, invalid-name, missing-class-docstring
++
++from typing import TYPE_CHECKING
++
++if TYPE_CHECKING:
++    from enum import Enum
++
++    class ellipsis(Enum):
++        Ellipsis = ""...""
++
++    Ellipsis = ellipsis.Ellipsis
++
++
++else:
++    ellipsis = type(Ellipsis)",This is a regression test for code I found while working on this.,Do we need this file? I don't see it being used anywhere.
+4181,"@@ -6503,8 +6503,15 @@ ex_expr::exp_return_type ex_function_json_object_field_text::eval(char *op_data[
+         Int32 prec2 = ((SimpleType *)getOperand(2))->getPrecision();
+         len2 = Attributes::trimFillerSpaces( op_data[2], prec2, len2, cs );
+     }
++
+     char *rltStr = NULL;
+-    JsonReturnType ret = json_extract_path_text(&rltStr, op_data[1], 1, op_data[2]);
++    char *jsonStr = new(heap) char[len1+1];
++    char *jsonAttr = new(heap) char[len2+1];
++    strncpy(jsonStr, op_data[1], len1);
++    jsonStr[len1] = '\0';
++    strncpy(jsonAttr, op_data[2], len2);
++    jsonAttr[len2] = '\0';
++    JsonReturnType ret = json_extract_path_text(&rltStr, jsonStr, 1, jsonAttr);
+     if (ret != JSON_OK)
+     {
+         ExRaiseJSONError(heap, diagsArea, ret);","I'm wondering if we need to delete jsonStr and jsonAttr after the json_extract_path_text call to avoid unnecessary heap pressure. Though if json_extract_path_text itself does new's on the same heap, we'd get heap fragmentation. Another approach would be to allocate these on the stack instead, avoiding both concerns: char jsonStr[len1+1]; char jsonAttr[len2+1]; ...","Can you use `strlcpy(jsonStr, op_data[1], len1+1)` ?"
+4182,"@@ -67,14 +67,14 @@ def lambda_handler(request):
+     user_size = request.args.get('size', DEFAULT_SIZE)
+     user_source = request.args.get('_source', [])
+     # 0-indexed starting position (for pagination)
+-    user_from = request.args.get('from', 0)
++    user_from = int(request.args.get('from', 0))
+     terminate_after = None  # see if we can skip os.getenv('MAX_DOCUMENTS_PER_SHARD')
+
+     if not user_indexes or not isinstance(user_indexes, str):
+         raise ValueError(""Request must include index=<comma-separated string of indices>"")
+
+-    if not isinstance(user_from, int) or user_from < 0:
+-        raise ValueError(""'from' must be a positive integer"")
++    if user_from < 0:
++        raise ValueError(""'from' must be a non-negative integer"")
+
+     if action == 'packages':
+         query = request.args.get('query', '')",Does it come as `str`?,"Shouldn't this be using `request.args.get('from', 0)`?"
+4183,"@@ -290,7 +290,7 @@ public class IngredientsProductFragment extends BaseFragment implements IIngredi
+             substanceProduct.append("" "");
+
+             String allergen;
+-            for (int i = 0; i < allergens.size() - 1; i++) {
++            for (int i = 0; i <= allergens.size() - 1; i++) {
+                 allergen = allergens.get(i);
+                 substanceProduct.append(Utils.getClickableText(allergen, allergen, SearchType.ALLERGEN, getActivity(), customTabsIntent));
+                 substanceProduct.append("", "");",This should actually read as the following `for (int i = 0; i < allergens.size(); i++)`,Could you explain this change? I am not getting it
+4184,"@@ -1192,6 +1192,10 @@ func (b *ColListTableBuilder) SetValue(i, j int, v values.Value) error {
+ }
+
+ func (b *ColListTableBuilder) AppendValue(j int, v values.Value) error {
++	if v.IsNull() {
++		return b.AppendNil(j)
++	}
++
+ 	switch v.Type() {
+ 	case semantic.Bool:
+ 		return b.AppendBool(j, v.Bool())","This is so useful and safety, I want to propose making AppendBool, AppendInt, etc. all private functions, and forcing us to use AppendValue(j, values.New(false)), etc.","Can we have this check in b.AppendValue instead? That way, we can avoid adding a b.AppendValue for a nil value."
+4185,"@@ -140,7 +140,9 @@ export function useImperativeHandle(ref, createHandle, args) {
+ 	const state = getHookState(currentIndex++);
+ 	if (argsChanged(state._args, args)) {
+ 		state._args = args;
+-		ref.current = createHandle();
++			if (ref) {
++				ref.current = createHandle();
++			}
+ 	}
+ }
+ ","Really, really small nit   I believe there's 3x tabs in here? And should it be just 2x?",This is the only place where `createHandle` is used. This `if` doesn't seem to be necessary.
+4186,"@@ -748,6 +748,17 @@ Use this only if v4 signatures don't work, eg pre Jewel/v10 CEPH.`,
+ See: [AWS S3 Transfer acceleration](https://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration-examples.html)`,
+ 			Default:  false,
+ 			Advanced: true,
++		}, {
++			Name:     ""leave_parts_on_error"",
++			Provider: ""AWS"",
++			Help: `If true avoid calling abort upload on a failure, leaving all successfully uploaded parts on S3 for manual recovery.
++
++It should be set to true for resuming uploads across different sessions.
++
++WARNING: Storing parts of an incomplete multipart upload counts towards space usage on S3 and will add additional costs if not cleaned up.
++`,
++			Default:  false,
++			Advanced: true,
+ 		}},
+ 	})
+ }",Perhaps note that rclone can't do this yet?,`leave_parts_on_error` -> `leave_parts_on_failure`?
+4187,"@@ -285,3 +285,14 @@ func (c *client) doRequest(
+
+ 	return res, requestError{}
+ }
++
++// ConfigureTransports converts an net/http HTTP/1 Transport to a http3.RoundTripper
++// Uses the original TLS config, if present, relying on the clone created on a
++// new connection.
++func ConfigureTransports(t1 *http.Transport) *RoundTripper {
++	roundtripper := &RoundTripper{
++		TLSClientConfig: t1.TLSClientConfig,
++		QuicConfig:      &quic.Config{},
++	}
++	return roundtripper
++}",You probably don't need to set an empty config here.,@smarterclayton do you have any thoughts on this type?
+4188,"@@ -12,6 +12,19 @@ from ..element import Element
+ from .grid import GridInterface
+ from .interface import Interface, DataError, dask_array_module
+
++try:
++    import cftime
++    cftime_types = (
++        cftime._cftime.DatetimeGregorian,
++        cftime._cftime.Datetime360Day,
++        cftime._cftime.DatetimeJulian,
++        cftime._cftime.DatetimeNoLeap,
++        cftime._cftime.DatetimeProlepticGregorian
++    )
++    util.datetime_types += cftime_types
++except:
++    cftime_types = ()
++
+
+ class XArrayInterface(GridInterface):
+ ","I think you are missing `cftime.DatetimeAllLeap` here. That said, all of these are subclasses of `cftime.datetime`, so I think you could get away with just using `cftime.datetime` here, rather than enumerating all of the different subclasses (since `cftime_types` is only used for instance checks).","Should we do this in `dask.array.__init__` instead of here? It seems like we could do this at import time, just like we do with `datetime.datetime_types`."
+4189,"@@ -37,6 +37,11 @@ const (
+ 	StoragePoolClaimCPK CasPoolKey = ""openebs.io/storage-pool-claim""
+ 	// CStorPoolClusterCPK is the CStorPoolcluster label
+ 	CStorPoolClusterCPK CasPoolKey = ""openebs.io/cstor-pool-cluster""
++	// CStorPoolInstanceCPK is the CStorPoolInstance label
++	CStorPoolInstanceCPK CasPoolKey = ""openebs.io/cstor-pool-instance""
++	// PredecessorBlockDeviceCPK is the annotation on the block device claim
++	// holding previous block device name
++	PredecessorBlockDeviceCPK CasPoolKey = ""openebs.io/bd-predecessor""
+ 	// NdmDiskTypeCPK is the node-disk-manager disk type e.g. 'sparse' or 'disk'
+ 	NdmDiskTypeCPK CasPoolKey = ""ndm.io/disk-type""
+ 	// NdmBlockDeviceTypeCPK is the node-disk-manager blockdevice type e.g. // 'blockdevice'",don't we need to set this label on pool pods? I don't see them being set,Minor typo: `bd-predecessor` -> `block-device-claim`
+4190,"@@ -27,7 +27,7 @@ struct train_kernel_cpu<Float, method::brute_force> {
+     train_result operator()(const context_cpu& ctx,
+                             const descriptor_base& desc,
+                             const train_input& input) const {
+-        throw unimplemented_error(""k-NN brute force method is not implemented for CPU!"");
++        throw unimplemented_error(""k-NN brute force method is not implemented for CPU"");
+         return train_result();
+     }
+ };","can remove, it isn't reachable.",Why do we need this change?
+4191,"@@ -160,7 +160,7 @@ describe Cancellation do
+       subscription = build_stubbed(:subscription, plan: subscribed_plan)
+       cancellation = Cancellation.new(subscription)
+
+-      expect(cancellation.can_downgrade_instead?).to be_true
++      expect(cancellation.can_downgrade_instead?).to be true
+     end
+
+     it 'returns true if the subscribed plan is not the downgrade plan' do",`expect(cancellation).to be_can_downgrade_instead` would be preferred :rainbow: :rainbow:,Did you mean to leave this change? It seems unrelated to the rest of the changes.
+4192,"@@ -65,6 +65,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+                         }
+                     }
+
++                    if (_socket.IsClosed)
++                    {
++                        break;
++                    }
++
+                     if (result.IsCancelled)
+                     {
+                         // Send a FIN","Gross. The OS should timeout writes for completely unresponsive clients to begin with. Long term, the better solution is to enforce a minimum minimum data rate for responses. This might require a way to cancel LibuvAwaitables, but it definitely not OK to immediately kill the socket and any ongoing writes just because the request processing loop completed. You could consider doing that after some kind of timeout, but at that point you might as well just enforce a minimum rate.",Why did you put this here instead of inside the `if (_socket.IsClosed)` check below?
+4193,"@@ -66,7 +66,8 @@ void mesh_reader::load() {
+   select_subset_of_data();
+ }
+
+-bool mesh_reader::fetch_datum(CPUMat& X, int data_id, int mb_idx, int tid) {
++bool mesh_reader::fetch_datum(CPUMat& X, int data_id, int mb_idx, thread_pool& io_thread_pool) {
++  //  int tid = io_thread_pool.get_local_thread_id();
+   if (m_random_flips) {
+     fast_rng_gen& gen = get_fast_generator();
+     std::uniform_int_distribution<int> dist(0, 1);","If this is not used, we should just delete the line.",please remove this line
+4194,"@@ -89,11 +89,7 @@ func defaultExec(
+ 	// for transporting shell-style streams
+ 	exec, err := remotecommand.NewSPDYExecutor(config, ""POST"", req.URL())
+ 	if err != nil {
+-		return nil, errors.Wrapf(
+-			err,
+-			""failed to exec into pod {%s}: failed to connect to the provided server"",
+-			name,
+-		)
++		return nil, err
+ 	}
+
+ 	// Stream initiates transport of standard shell streams",Are there other callers to this function. How will they be impacted.,Why is this not needed anymore?
+4195,"@@ -23,7 +23,7 @@
+ Defines an interface which all Auth handlers need to implement.
+ """"""
+
+-from plugin import Plugin
++from .plugin import Plugin
+
+ class NotReadyToAuthenticate(Exception):
+   pass","Let's be consistent. The majority of boto code does not use relative imports. Let's just stick to the existing standard of ""from boto.package.subpackage import Thing"".",why did you change this?
+4196,"@@ -207,6 +207,12 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+   // CLI options defined by user at runtime.
+   // Options parsing is done with CLI library Picocli https://picocli.info/
+
++  @Option(
++      names = ""--identity"",
++      paramLabel = ""<String>"",
++      description = ""Identification for this node in the Client ID"")
++  private final Optional<String> identityString = Optional.empty();
++
+   // Completely disables P2P within Besu.
+   @Option(
+       names = {""--p2p-enabled""},",Suggestion: specify `arity` for this option.,how about `--identities` or `--identities-string`
+4197,"@@ -264,6 +264,9 @@ class SpikesPlot(PathPlot):
+     position = param.Number(default=0., doc=""""""
+       The position of the lower end of each spike."""""")
+
++    show_legend = param.Boolean(default=True, doc=""""""
++        Whether to show legend for the plot."""""")
++
+     style_opts = (['color', 'cmap', 'palette'] + line_properties)
+
+     def get_extents(self, element, ranges):","This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend.",It might make sense to automatically set this to
+4198,"@@ -641,7 +641,7 @@ public final class Span implements Serializable { // for Spark and Flink jobs
+    */
+   public static String normalizeTraceId(String traceId) {
+     if (traceId == null) throw new NullPointerException(""traceId == null"");
+-    int length = traceId.length();
++    int length = traceId.trim().length();
+     if (length == 0) throw new IllegalArgumentException(""traceId is empty"");
+     if (length > 32) throw new IllegalArgumentException(""traceId.length > 32"");
+     int zeros = validateHexAndReturnZeroPrefix(traceId);",trim has performance impact and this is the lowest level library... seems the trim if occurs should happen in the UI or Query controller instead..,is there a reason to have the trim here?
+4199,"@@ -80,6 +80,7 @@ class Request(testprocess.Line):
+
+             '/500-inline': [http.client.INTERNAL_SERVER_ERROR],
+         }
++        # pylint: enable=no-member
+         for i in range(15):
+             path_to_statuses['/redirect/{}'.format(i)] = [http.client.FOUND]
+         for suffix in ['', '1', '2', '3', '4', '5', '6']:",Probably also needed for the `http.client.FOUND` below?,I'm assuming you didn't mean to add `disable=no-m
+4200,"@@ -97,6 +97,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""                     Default value is \""T\""\n""
+     ""  --no-js-exports    Removes Node.js style export lines in JS.\n""
+     ""  --goog-js-export   Uses goog.exports* for closure compiler exporting in JS.\n""
++    ""  --es6-js-export    Uses ECMAScript 6 export style lines in JS.\n""
+     ""  --go-namespace     Generate the overrided namespace in Golang.\n""
+     ""  --go-import        Generate the overrided import for flatbuffers in Golang.\n""
+     ""                     (default is \""github.com/google/flatbuffers/go\"")\n""",Can you also add this to Compiler.md ?,I think this should be `--es6-js-export` instead of `--es6-js-export`.
+4201,"@@ -144,8 +144,9 @@ class HttpClient {
+  * @param {function(!Error)} onError The function to call if the request fails.
+  * @param {?string=} opt_data The data to send with the request.
+  * @param {?RequestOptions=} opt_proxy The proxy server to use for the request.
++ * @param {!number=} retries The current number of retries.
+  */
+-function sendRequest(options, onOk, onError, opt_data, opt_proxy) {
++function sendRequest(options, onOk, onError, opt_data, opt_proxy, retries) {
+   var hostname = options.hostname;
+   var port = options.port;
+ ",!numbers -> numbers,@dvoytenko @jridgewell @jridgewell @jridgewell @lannka how do you feel
+4202,"@@ -413,9 +413,9 @@ public class JavaSurfaceNamer extends SurfaceNamer {
+    * <p>All Google cloud java libraries have package names like ""com.google.cloud.library.v1"" and
+    * the respective examples have package names like
+    * ""com.google.cloud.examples.library.v1.snippets"". This method assumes {@code packageName} has
+-   * the format of ""com.google.(.+).artifact.name"". This works for both existing libraries and the
+-   * baseline test. We will need to adjust this if in the future there are libraries that do not
+-   * follow the package name format assumed here.
++   * the format of ""com.google.orgname.artifact.name"", where ""artifact.name"" could be empty. This
++   * works for both existing libraries and the baseline test. We will need to adjust this if in the
++   * future there are libraries that do not follow the package name format assumed here.
+    */
+   @Override
+   public String getExamplePackageName() {",This description doesn't seem quite right for the longrunning case - `longrunning` isn't an orgname.,"The problem is that we end up with ""com.google.orgname.artifact.name"" "
+4203,"@@ -93,4 +93,11 @@ public interface LeafCollector {
+    */
+   void collect(int doc) throws IOException;
+
++  /*
++   * optionally returns an iterator over competitive documents
++   */
++  default DocIdSetIterator iterator() {
++    return null;
++  }
++
+ }","maybe give it a more descriptive name, e.g. `competitiveFilter`",Why not make this `private` and remove the default implementation?
+4204,"@@ -106,7 +106,7 @@ public class JWTVerificationkeyResolver implements VerificationKeyResolver {
+         }
+       }
+
+-      // Add all keys into a master list
++      // Add all keys into a primary list
+       if (issuerConfig.usesHttpsJwk()) {
+         keysSource = ""["" + String.join("", "", issuerConfig.getJwksUrls()) + ""]"";
+         for (HttpsJwks hjwks : issuerConfig.getHttpsJwks()) {","This occurrence of ""master"" is unrelated to master/slave replication. Maybe simply remove the word ""master"" or replace it with ""reference"" but ""primary"" doesn't really make sense.",It doesn't look like there is a need to have a `primary` list. It should only have a single key.
+4205,"@@ -15,6 +15,7 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/actor/builtin/miner""
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/exec""
++	""github.com/filecoin-project/go-filecoin/proofs""
+ 	""github.com/filecoin-project/go-filecoin/types""
+ 	""github.com/filecoin-project/go-filecoin/vm/errors""
+ )","BLOCKING: This is a problem. We shouldn't be introducing new dependencies on proofs into actors. The miner has some dependencies that should be removed (#2555). This could be accomplished either by moving `proofs.Mode` to `types.ProofsMode` or by forgoing a new type altogether and replacing it with a boolean. The later would have the additional advantage of reducing the number of types we have to export through ABI. I get why `proofs.Mode` has value as a type over a boolean, but I'm not sure it's worth it here.",Filecoin-project should be grouped with the other standard library imports.
+4206,"@@ -74,7 +74,9 @@ func verifyReceiveMessage(r *request.Request) {
+ 		for _, msg := range out.Messages {
+ 			err := checksumsMatch(msg.Body, msg.MD5OfBody)
+ 			if err != nil {
+-				ids = append(ids, *msg.MessageId)
++				if msg.MessageId != nil {
++					ids = append(ids, *msg.MessageId)
++				}
+ 			}
+ 		}
+ 		if len(ids) > 0 {",We probably want to log the fact that a `MessageId` was not present in the response. In addition the `RequestID` from `request.Request` should be included in the message so that the user is aware of the issue.,When would this be nil?
+4207,"@@ -38,10 +38,11 @@ apiFetchMock.mockImplementation( ( ...args ) => {
+
+ const setupRegistry = ( { dispatch } ) => {
+ 	const { id, webPropertyId, accountId } = fixtures.propertiesProfiles.profiles[ 0 ];
++	const propertyID = webPropertyId;
+ 	dispatch( STORE_NAME ).setAccountID( accountId );
+ 	dispatch( STORE_NAME ).setPropertyID( webPropertyId );
+ 	dispatch( STORE_NAME ).setProfileID( id );
+-	dispatch( STORE_NAME ).receiveProfiles( fixtures.propertiesProfiles.profiles );
++	dispatch( STORE_NAME ).receiveProfiles( fixtures.propertiesProfiles.profiles, { propertyID } );
+ };
+
+ const setupRegistryWithExistingTag = ( { dispatch } ) => {","It feels a bit strange to re-assign that here, as that line itself has no context on why it's reassigned. I'd prefer if we could pass `{ propertyID: webPropertyId }` below instead (that's how we do that elsewhere too). This also applies to other similar re-assignments below - let's rather pass the values within the objects as applicable, since then there is more clear context on why this ""rename"" / ""reassignment"" is necessary (because of an object expecting specific properties).",This could be a one-liner.
+4208,"@@ -172,6 +172,7 @@ module.exports = function(grunt) {
+                     'frontend/express/public/core/events/javascripts/countly.overview.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.details.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.details.models.js',
++                    'frontend/express/public/core/events/javascripts/countly.compare.models.js',
+                     'frontend/express/public/core/user-management/javascripts/countly.overview.models.js',
+                     'frontend/express/public/core/user-management/javascripts/countly.overview.views.js'
+                 ],",remove this in the new pr aswell when moving compare to plugins as discussed.,I wonder if we should name this `countly.common.models.countly` to match the file name?
+4209,"@@ -210,10 +210,16 @@ Status YieldClauseWrapper::prepare(
+     yieldColsHolder_ = std::make_unique<YieldColumns>();
+     for (auto *col : cols) {
+         if (col->expr()->isInputExpression()) {
++            if (inputs == nullptr) {
++                return Status::Error(""Inputs nullptr."");
++            }
+             if (needAllPropsFromInput(col, inputs, yields)) {
+                 continue;
+             }
+         } else if (col->expr()->isVariableExpression()) {
++            if (varHolder == nullptr) {
++                return Status::Error(""VarHolder nullptr."");
++            }
+             auto ret = needAllPropsFromVar(col, varHolder, yields);
+             if (!ret.ok()) {
+                 return std::move(ret).status();","check varHolder is nullptr is redundant, ExecutionContext ensure","nit, consider making `yieldColsHolder_` an std::unique_ptr."
+4210,"@@ -0,0 +1,8 @@
++module UnsubscribesHelper
++  def unsubscribe_token_verifier
++    @_unsubscribe_token_verifier ||= ActiveSupport::MessageVerifier.new(
++      ENV.fetch(""UNSUBSCRIBE_SECRET_BASE""),
++      digest: ""SHA256"".freeze,
++    )
++  end
++end",Make these frozen constants?,I'm not sure if there's any value in making this a class method since it's only used in
+4211,"@@ -55,8 +55,9 @@ def browseableMessage(message,title=None,isHtml=False):
+ 	if not title:
+ 		# Translators: The title for the dialog used to present general NVDA messages in browse mode.
+ 		title = _(""NVDA Message"")
+-	isHtmlArgument = ""true"" if isHtml else ""false""
+-	dialogString = u""{isHtml};{title};{message}"".format( isHtml = isHtmlArgument , title=title , message=message )
++	if not isHtml:
++		message = f""<pre>{message.replace('<', '&lt;')}</pre>""
++	dialogString = f""{title};{message}""
+ 	dialogArguements = automation.VARIANT( dialogString )
+ 	gui.mainFrame.prePopup()
+ 	windll.mshtml.ShowHTMLDialogEx( ",Please use something like html.escape() to ensure that the text is totally safe to include within html. &lt; is not enough.,The `isHtml` argument is now unused and can be removed.
+4212,"@@ -130,7 +130,7 @@ func (s *Service) RetrieveChunk(ctx context.Context, addr swarm.Address, origin
+ 		var (
+ 			peerAttempt  int
+ 			peersResults int
+-			resultC      = make(chan retrievalResult, maxSelects)
++			resultC      = make(chan retrievalResult, 2)
+ 		)
+
+ 		requestAttempt := 0","why is a buffered channel larger than 1 needed here? the separate goroutines can just try to write to the channel with a select-default block, and then it is not needed. i find the current implementation a bit convoluted, maybe we could simplify it a bit? not sure why it is needed for example to communicate an empty result. these patterns can be simplified using waitgroups",why did you need to change this?
+4213,"@@ -11,7 +11,7 @@
+ #
+ # It's strongly recommended that you check this file into your version control system.
+
+-ActiveRecord::Schema.define(version: 20150410155813) do
++ActiveRecord::Schema.define(version: 20150415145819) do
+
+   # These are extensions that must be enabled in order to support this database
+   enable_extension ""plpgsql""",There seem to be more changes in here than I'd expect (mostly `limit: 255` additions).,can remove this file from the PR
+4214,"@@ -38,6 +38,10 @@ namespace OpenTelemetry.Context.Propagation
+         private static readonly int VersionAndTraceIdAndSpanIdLength = ""00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-"".Length;
+         private static readonly int OptionsLength = ""00"".Length;
+         private static readonly int TraceparentLengthV0 = ""00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-00"".Length;
++        private static readonly int TraceStateKeyMaxLength = 256;
++        private static readonly int TraceStateKeyTenentMaxLength = 241;
++        private static readonly int TraceStateKeyVendorMaxLength = 14;
++        private static readonly int TraceStateValueMaxLength = 256;
+
+         /// <inheritdoc/>
+         public override ISet<string> Fields => new HashSet<string> { TraceState, TraceParent };","I'm not sure, but I think it's `Tenant`",How do these properties differ f
+4215,"@@ -15,8 +15,9 @@ namespace Datadog.Trace.Configuration
+         /// <paramref name=""data""/>.
+         /// </summary>
+         /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
++        /// <param name=""allowOptionalMappings"">Determines whether to create dictionary entries when the input has no value mapping</param>
+         /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
+-        public static IDictionary<string, string> ParseCustomKeyValues(string data)
++        public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)
+         {
+             var dictionary = new ConcurrentDictionary<string, string>();
+ ","Not sure if it's an issue, but this is a breaking change in a public API. Maybe we should add as an overload without optional parameter instead and delegate the existing call to this one?",Can this just be `bool? allowOpt
+4216,"@@ -147,6 +147,11 @@ func (o *Outbound) Transports() []transport.Transport {
+ 	return []transport.Transport{o.transport}
+ }
+
++// Chooser returns the outbound's peer chooser.
++func (o *Outbound) Chooser() peer.Chooser {
++	return o.chooser
++}
++
+ // Start the HTTP outbound
+ func (o *Outbound) Start() error {
+ 	return o.once.Start(o.chooser.Start)","as opposed to exposing the chooser function and increasing our API exposure for the purpose of tests, can we move the HTTP transport config test into this package?",Why not the `o.chooser`?
+4217,"@@ -461,6 +461,17 @@ error_conn:
+ 	return 0;
+ }
+
++static void wlr_drm_connector_set_dpms(struct wlr_output *output, enum dpms_enum level) {
++	struct wlr_drm_connector *conn = (struct wlr_drm_connector *)output;
++	struct wlr_drm_backend *drm = (struct wlr_drm_backend *)output->backend;
++
++    if (drmModeObjectSetProperty (drm->fd, conn->id,
++                DRM_MODE_OBJECT_CONNECTOR,
++                conn->props.dpms, level) < 0)
++        wlr_log(L_ERROR, ""Failed to set dpms state for %s"", conn->output.name);
++
++}
++
+ static bool wlr_drm_connector_set_mode(struct wlr_output *output,
+ 		struct wlr_output_mode *mode) {
+ 	struct wlr_drm_connector *conn = (struct wlr_drm_connector *)output;",This is using the legacy DRM interface. DPMS levels have been removed from the atomic interface IIRC. Should we handle DPMS levels at all?,I think this should prob
+4218,"@@ -162,13 +162,13 @@ type confirmedTx struct {
+ 	watch   *transactionWatch
+ }
+
+-// potentiallyConfirmedWatches returns all watches with nonce less than what was specified
++// potentiallyConfirmedWatches returns all watches with nonce less than or equal what was specified
+ func (tm *transactionMonitor) potentiallyConfirmedWatches(nonce uint64) (watches []*transactionWatch) {
+ 	tm.lock.Lock()
+ 	defer tm.lock.Unlock()
+
+ 	for watch := range tm.watches {
+-		if watch.nonce < nonce {
++		if watch.nonce <= nonce {
+ 			watches = append(watches, watch)
+ 		}
+ 	}","I think this was correct before. The nonce passed in here is the nonce at a block (which is the next nonce not yet used, e.g. 0 if the account was never used, 1 if only the tx with nonce 0 has been sent). So if the in-block nonce is 12, then a transaction with nonce 12 cannot have been included yet.",I don't understand the r
+4219,"@@ -0,0 +1,13 @@
++const { NativeModules, Platform } = require('react-native');
++
++const ext = (Platform.OS === 'android' && NativeModules.ShareExtension) ?
++	{
++		data: () => NativeModules.ShareExtension.data(),
++		close: () => NativeModules.ShareExtension.close(),
++	} :
++	{
++		data: () => {},
++		close: () => {},
++	};
++
++export default ext;","Please name the file ShareExtension.js, as you import it under this name (also could you convert it to TypeScript please?)",Can we have this in a se
+4220,"@@ -45,6 +45,7 @@ type ClusterOpts struct {
+ 	TLSTimeout     float64           `json:""-""`
+ 	TLSConfig      *tls.Config       `json:""-""`
+ 	TLSMap         bool              `json:""-""`
++	TLSInsecure    bool              `json:""tls_insecure""`
+ 	ListenStr      string            `json:""-""`
+ 	Advertise      string            `json:""-""`
+ 	NoAdvertise    bool              `json:""-""`","Not sure if we need it, but if we set it, be sure to add `,omitempty`.","Was this supposed to be `json:""-""`?"
+4221,"@@ -17,7 +17,7 @@ var (
+ 	errGetLengthNotForVersionNegotiation = errors.New(""PublicHeader: GetLength cannot be called for VersionNegotiation packets"")
+ )
+
+-// The PublicHeader of a QUIC packet
++// The PublicHeader of a QUIC packet.
+ type PublicHeader struct {
+ 	Raw                  []byte
+ 	ConnectionID         protocol.ConnectionID","It's the whole `PublicHeader` that will change soon, and we should state that here, not in the member functions. If Jana's proposal for a new header is accepted, we might also want to rename the fields here. For example, there won't be a dedicated version flag anymore, so a more appropriate name might be `ContainsVersion` instead of `VersionFlag`.",nit: Can we remove the extra `.` at
+4222,"@@ -1003,8 +1003,8 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+     }
+
+     @Override
+-    public int indexOf(Character element, int from) {
+-        return back.indexOf(element, from);
++    public int indexOf(Object element, int from) {
++        return back.indexOf((Character) element, from);
+     }
+
+     @Override",I think `element` can stay of type `Character` because `Character` is a final class. The we do not need the cast in the line below.,"This is a bug, as the type should b"
+4223,"@@ -260,6 +260,15 @@ public interface ASTAnyTypeDeclaration
+     }
+
+
++    /**
++     * Returns true if this is a regular interface declaration (not an annotation).
++     * Note that {@link #isInterface()} counts annotations in.
++     */
++    default boolean isRegularInterface() {
++        return false;
++    }
++
++
+     /** Returns true if this is an {@linkplain ASTAnnotationTypeDeclaration annotation type declaration}. */
+     default boolean isAnnotation() {
+         return this instanceof ASTAnnotationTypeDeclaration;","Not sure, if we should do it the other way round. If you ask be in the middle of the night, whether Interface should return true as ""isInterface"" and what Annotation would return. I'd tell you, Annotations should return false.... I want to say, on first glance, I'd say, it's easier to have ""isInterface"" and ""isAnnotation"" rather than ""isInterface"", ""isAnnotation"" and ""isRegularInterface""... But I see, we also have ""isRegularClass"".... We still have the possibility to change the semantics of those APIs in PMD 7 *Update:* Or in other words: What is less surprising? That isInterface returns true for annotations or that it returns false?",Nit: I think we should rename this
+4224,"@@ -67,7 +67,6 @@ def lambda_handler(request):
+             raise ValueError(""'packages' action searching indexes that don't end in '_packages'"")
+         _source = user_source
+         size = user_size
+-        terminate_after = None
+     elif action == 'search':
+         query = request.args.get('query', '')
+         my_fields = user_fields or [",This will potentially skip package results. Do we really want that?,"Moving this out of `if action in ['show', 'update']` will allow us to get rid of `action == 'search'` altogether."
+4225,"@@ -787,7 +787,7 @@ const std::map<llvm::StringRef, hipCounter> CUDA_RUNTIME_TYPE_NAME_MAP {
+   {""cudaErrorInvalidPc"",                                               {""hipErrorInvalidPc"",                                        """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 718
+   // CUDA_ERROR_LAUNCH_FAILED
+   {""cudaErrorLaunchFailure"",                                           {""hipErrorLaunchFailure"",                                    """", CONV_NUMERIC_LITERAL, API_RUNTIME}}, // 719
+-  // no analogue
++  // CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE
+   {""cudaErrorCooperativeLaunchTooLarge"",                               {""hipErrorCooperativeLaunchTooLarge"",                        """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 720
+   // CUDA_ERROR_NOT_PERMITTED
+   {""cudaErrorNotPermitted"",                                            {""hipErrorNotPermitted"",                                     """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 800",Please remove `HIP_UNSUPPORTED`,Did you mean to delete the analogue?
+4226,"@@ -438,7 +438,7 @@ type (
+
+ 	// CreateWorkflowExecutionResponse is the response to CreateWorkflowExecutionRequest
+ 	CreateWorkflowExecutionResponse struct {
+-		HistorySize int64
++		NewMutableStateStats MutableStateStatus
+ 	}
+
+ 	// GetWorkflowExecutionRequest is used to retrieve the info of a workflow execution","if this is a ""Status"" type then the variable name ""Stats"" (which implies ""statistics"") seems wrong (or at least confusing to me)",Can we rename this to `MutableState`? I think it's not used anywhere else.
+4227,"@@ -35,6 +35,10 @@ const (
+ 	exportKeystorePath    = ""/var/lib/sonm/worker_keystore""
+ )
+
++var (
++	leakedInsecureKey = common.HexToAddress(""0x8125721c2413d99a33e351e1f6bb4e56b6b633fd"")
++)
++
+ type options struct {
+ 	version     string
+ 	cfg         *Config",maybe will be better to put it into the default worker's config rather than hardcoding the address?,This should be in `lib/server/server.go`
+4228,"@@ -2737,14 +2737,11 @@ describe('Find', function() {
+         var db = client.db(configuration.db);
+         var collection = db.collection('shouldNotMutateUserOptions');
+         var options = { raw: 'TEST' };
+-        collection.find({}, options, function(error) {
+-          test.equal(null, error);
+-          test.equal(undefined, options.skip);
+-          test.equal(undefined, options.limit);
+-          test.equal('TEST', options.raw);
+-          client.close();
+-          done();
+-        });
++        expect(() => collection.find({}, options)).to.throw(
++          'raw should be of type boolean, but is of type string.'
++        );
++        client.close();
++        done();
+       });
+     }
+   });","It seems like this is not meant to test the option failure, but rather that `raw` can be set. This may be a superfluous test now, and we might want to delete it.","@caitp, @philippjfr are any of these changes correct?"
+4229,"@@ -715,6 +715,16 @@ struct roots_seat_view *roots_seat_view_from_view(
+ 	return seat_view;
+ }
+
++static void release_fullscreen(struct roots_output *output) {
++	if (output->fullscreen_view) {
++		if (output->fullscreen_view->set_fullscreen) {
++			output->fullscreen_view->set_fullscreen(
++				output->fullscreen_view, false);
++		}
++		view_set_fullscreen(output->fullscreen_view, false, output->wlr_output);
++	}
++}
++
+ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
+ 	// Make sure the view will be rendered on top of others, even if it's
+ 	// already focused in this seat",This is already done by `view_set_fullscreen`,"I think I'd like to see this as a separate function, "
+4230,"@@ -101,6 +101,15 @@ func (pr *PeerRing) RemoveAll() []peer.Peer {
+ 	return peers
+ }
+
++// All returns a snapshot of all the peers from the ring as a list.
++func (pr *PeerRing) All() []peer.Peer {
++	peers := make([]peer.Peer, 0, len(pr.peerToNode))
++	for _, node := range pr.peerToNode {
++		peers = append(peers, getPeerForRingNode(node))
++	}
++	return peers
++}
++
+ func (pr *PeerRing) popNode(node *ring.Ring) peer.Peer {
+ 	p := getPeerForRingNode(node)
+ ","mmm I followed the convention of this collection. It has Add, Remove, RemoveAll, so All sounds reasonable. Else It would likely be AddPeer, RemovePeer, RemovePeers and Peers.","This could also be `make([]peer.Peer, 0, len(pr.peerT"
+4231,"@@ -65,6 +65,15 @@ class FlagFacade
+         return $this->flagRepository->getByIds($flagIds);
+     }
+
++    /**
++     * @param string $uuid
++     * @return \Shopsys\FrameworkBundle\Model\Product\Flag\Flag
++     */
++    public function getByUuid(string $uuid): Flag
++    {
++        return $this->flagRepository->getByUuid($uuid);
++    }
++
+     /**
+      * @param \Shopsys\FrameworkBundle\Model\Product\Flag\FlagData $flagData
+      * @return \Shopsys\FrameworkBundle\Model\Product\Flag\Flag","_nitpick_ I'm thinking about whether this method should be in the previous commit or not. I know it's not yet used there, but in theory, neither do UUID itself.",Please add the `@return` tag.
+4232,"@@ -760,6 +760,13 @@ void RaftPart::replicateLogs(folly::EventBase* eb,
+             break;
+         }
+
++        if (term_ != currTerm) {
++            VLOG(2) << idStr_ << ""Term has been updated, previous ""
++                    << currTerm << "", current "" << term_;
++            currTerm = term_;
++            break;
++        }
++
+         hosts = hosts_;
+     } while (false);
+ ","""break"" is right? You skip the line 768.",Update the log message to include the current term as well.
+4233,"@@ -0,0 +1,19 @@
++# RailsAdmin config file. Generated on May 30, 2012 16:34
++# See github.com/sferik/rails_admin for more informations
++
++RailsAdmin.config do |config|
++  config.authenticate_with do
++    unless current_user
++      session[:return_to] = request.url
++      redirect_to ""/sign_in"", :alert => ""You must first log in or sign up before accessing this page.""
++    end
++  end
++
++  config.authorize_with do
++    redirect_to ""/"", :alert => ""You are not authorized to access that page"" unless current_user.admin?
++  end
++
++  config.current_user_method { current_user }
++
++  config.main_app_name = ['Workshops', 'Admin']
++end",Can this use the route helper instead?,Use the new Ruby 1.9 hash syntax.
+4234,"@@ -44,6 +44,7 @@ var Set = wire.NewSet(
+ // The zero value is a server with the default options.
+ type Server struct {
+ 	reqlog        requestlog.Logger
++	Handler       http.Handler
+ 	healthHandler health.Handler
+ 	te            trace.Exporter
+ 	sampler       trace.Sampler",Why is this field exported and others aren't?,Is this the same as `server.Handler`?
+4235,"@@ -273,6 +273,7 @@ var testFiles = [
+   , '/test/functional/byo_promises_tests.js'
+
+   // Functionality tests
++  , '/test/functional/dns_txt_records_tests.js'
+   , '/test/functional/mongo_client_tests.js'
+   , '/test/functional/collection_tests.js'
+   , '/test/functional/db_tests.js'",should we rename this like `mongodb_srv_tests.js`?,"Not related to this PR, but we should probably get rid of t"
+4236,"@@ -46,7 +46,7 @@ class SearchConsoleDashboardWidgetSiteStats extends Component {
+ 	setOptions() {
+ 		const { selectedStats, series, vAxes } = this.props;
+
+-		const pageTitle = '' === googlesitekit.pageTitle ? '' : sprintf( __( 'Search Traffic Summary for %s', 'google-site-kit' ), decodeHtmlEntity( googlesitekit.pageTitle ) );
++		const pageTitle = googlesitekit.pageTitle && googlesitekit.pageTitle.length ? sprintf( __( 'Search Traffic Summary for %s', 'google-site-kit' ), decodeHtmlEntity( googlesitekit.pageTitle ) ) : '';
+
+ 		const options = {
+ 			chart: {","This should still have a value when there is no page title, e.g. just `__( 'Search Traffic Summary', 'google-site-kit' )`.",Can you explain why `pageTitle` can be null? Is there a useful check for it?
+4237,"@@ -60,7 +60,10 @@ import static org.apache.solr.common.params.CollectionParams.CollectionAction.*;
+ import static org.apache.solr.common.params.CommonAdminParams.ASYNC;
+ import static org.apache.solr.common.params.CommonAdminParams.NUM_SUB_SHARDS;
+
+-
++/**
++ * Index split request processed by Overseer. Requests from here go to the host of the parent shard,
++ * and are processed by @link.
++ */
+ public class SplitShardCmd implements OverseerCollectionMessageHandler.Cmd {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+   private static final int MIN_NUM_SUB_SHARDS = 2;",Oops.. meant to link to SplitOp here. I'll clean up in my next commit,Is `@link` needed here?
+4238,"@@ -14,6 +14,10 @@ import android.widget.Toast;
+ import com.afollestad.materialdialogs.MaterialDialog;
+ import com.fasterxml.jackson.databind.JsonNode;
+ import com.firebase.jobdispatcher.JobParameters;
++
++import io.reactivex.SingleObserver;
++import io.reactivex.android.schedulers.AndroidSchedulers;
++import io.reactivex.disposables.Disposable;
+ import io.reactivex.schedulers.Schedulers;
+ import okhttp3.MediaType;
+ import okhttp3.OkHttpClient;",Remove these unnecessary imports that you've added.,"This is not used, is it?"
+4239,"@@ -28,8 +28,8 @@ from qutebrowser.utils import usertypes
+
+
+ # Note this has entries for success/error/warn from widgets.webview:LoadStatus
+-UrlType = usertypes.enum('UrlType', ['success', 'error', 'warn', 'hover',
+-                                     'normal'])
++UrlType = usertypes.enum('UrlType', ['success', 'success_https', ' error',
++                                     'warn', 'hover', 'normal'])
+
+
+ class UrlText(textbase.TextBase):","That space shouldn't be here :wink: This lead to an exception whenever a page with an error was loaded, e.g. an inexistent host - I just fixed that :smile:",I think we should keep `success` in here even though it doesn't really matte
+4240,"@@ -735,7 +735,7 @@ class TLSServerAutomaton(Automaton):
+                                                                 self.local_port)
+             return
+         self.socket, addr = s.accept()
+-        self.remote_ip, self.remote_port = addr
++        self.remote_ip, self.remote_port = addr, self.local_port
+
+         raise self.WAITING_FOR_ClientHello()
+ ",It seems this is not the way to fix issue #505.,Could you explain why this change is needed?
+4241,"@@ -104,7 +104,7 @@ def binary_cross_entropy(pred,
+     if weight is not None:
+         weight = weight.float()
+     loss = F.binary_cross_entropy_with_logits(
+-        pred, label.float(), pos_weight=class_weight, reduction='none')
++        pred, label.float(), weight=class_weight, reduction='none')
+     # do the reduction for the weighted loss
+     loss = weight_reduce_loss(
+         loss, weight, reduction=reduction, avg_factor=avg_factor)",Please take a look at the docstring of `F.binary_cross_entropy_with_logits`. `weight` should be a tensor that matches the input tensor shape. It is Not the class-aware weight. `pos_weight` should be a vector with a length equal to the number of classes.,please also update the docstring accordingly
+4242,"@@ -85,12 +85,15 @@ func TestSuite(
+ 			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Windows 2012 R2 two disks, Network setting (path)""))
+ 		machineImageImportStorageLocationTestCase := junitxml.NewTestCase(
+ 			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Centos 7.4, Storage location""))
++		machineImageImportNetworkTagsTestCase := junitxml.NewTestCase(
++			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Import with network tags""))
+
+ 		testsMap[testType] = map[*junitxml.TestCase]func(
+ 			context.Context, *junitxml.TestCase, *log.Logger, *testconfig.Project, e2e.CLITestType){}
+ 		testsMap[testType][machineImageImportUbuntu3DisksNetworkSettingsNameTestCase] = runOVFMachineImageImportUbuntu3DisksNetworkSettingsName
+ 		testsMap[testType][machineImageImportWindows2012R2TwoDisksNetworkSettingsPathTestCase] = runOVFMachineImageImportWindows2012R2TwoDisksNetworkSettingsPath
+ 		testsMap[testType][machineImageImportStorageLocationTestCase] = runOVFMachineImageImportCentos74StorageLocation
++		testsMap[testType][machineImageImportNetworkTagsTestCase] = runOVFMachineImageImportWithNetworkTags
+ 	}
+
+ 	// gcloud only tests","Same here, merge with an existing test.",Can you rename this to `runOVFMachineImageIm
+4243,"@@ -28,7 +28,7 @@ EFI_DRIVER_BINDING_PROTOCOL  gSdMmcPciHcDriverBinding = {
+   NULL
+ };
+
+-#define SLOT_INIT_TEMPLATE  {0, UnknownSlot, 0, 0, 0, 0,\
++#define SLOT_INIT_TEMPLATE  {0, UnknownSlot, 0, 0, 0,\
+                                {EDKII_SD_MMC_BUS_WIDTH_IGNORE,\
+                                EDKII_SD_MMC_CLOCK_FREQ_IGNORE,\
+                                {EDKII_SD_MMC_DRIVER_STRENGTH_IGNORE}}}",@aimanrosli23 Could you help to confirm if you do not revert the change in below commit: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency,(style) line over 80 characters
+4244,"@@ -76,8 +76,10 @@ public class AvroSchemaUtil {
+     return TypeUtil.visit(type, new TypeToSchema(names));
+   }
+
+-  public static Type convert(Schema schema) {
+-    return AvroSchemaVisitor.visit(schema, new SchemaToType(schema));
++  public static org.apache.iceberg.Schema convert(Schema schema) {
++    final Type type = AvroSchemaVisitor.visit(schema, new SchemaToType(schema));
++    final List<Types.NestedField> fields = type.asNestedType().asStructType().fields();
++    return new org.apache.iceberg.Schema(fields);
+   }
+
+   static boolean hasIds(Schema schema) {",Can we do this without a breaking API change? What about adding a different name to convert directly to a Schema?,Is this needed? I thought I added this already.
+4245,"@@ -1,7 +1,8 @@
+ 'use strict';
+
+-var MongoClient = require('../../').MongoClient,
+-  expect = require('chai').expect;
++const Promise = require('bluebird');
++const MongoClient = require('../../').MongoClient;
++const expect = require('chai').expect;
+
+ function connectToDb(url, db, options, callback) {
+   if (typeof options === 'function') {",Why do we need to pull bluebird in here?,I think it's better to use `const MongoClient =
+4246,"@@ -121,9 +121,10 @@ public class FlowPreparer extends AbstractFlowPreparer {
+           (flowPrepCompletionTime - criticalSectionStartTime) / 1000,
+           flow.getExecutionId(), execDir.getPath());
+     } catch (final Exception ex) {
+-      FileIOUtils.deleteDirectorySilently(tempDir);
+       LOGGER.error(""Error in preparing flow execution {}"", flow.getExecutionId(), ex);
+       throw new ExecutorManagerException(ex);
++    } finally {
++      FileIOUtils.deleteDirectorySilently(tempDir);
+     }
+   }
+ ","If *two* threads successfully download the same project into two different temp dirs, and one of them successfully renames one to its final destination, the `if`on line 102 will be false _in the other thread_, and it would leave its temp dir behind.",Shouldn't this be in a try-finally block?
+4247,"@@ -37,6 +37,7 @@ struct pool_entry_t {
+     h2o_socket_export_t sockinfo;
+     h2o_socketpool_target_t *target;
+     h2o_linklist_t link;
++    h2o_linklist_t target_link;
+     uint64_t added_at;
+ };
+ ",I would appreciate it if you could rename `link` to `all_link` so that the roles of the two links (the other is `target_link`) become clearer.,was this change supposed to be in here?
+4248,"@@ -826,10 +826,16 @@ class InitialDevelopmentTests(unittest.TestCase):
+ 			""Testing testing "",
+ 			speech.PitchCommand(offset=100),
+ 			""1 2 3 4"",
+-			smi.create_ConfigProfileTriggerCommand(t1, True, expectedToBecomeIndex=1),
+-			smi.create_ConfigProfileTriggerCommand(t2, True, expectedToBecomeIndex=2),
++			ExpectedIndex(1),
++			# The preceeding index is expected,
++			# as the following profile trigger commands will cause the utterance to be split here.
++			ConfigProfileTriggerCommand(t1, True),
++			ConfigProfileTriggerCommand(t2, True),
+ 			""5 6 7 8"",
+-			smi.create_ConfigProfileTriggerCommand(t1, False, expectedToBecomeIndex=3),
++			ExpectedIndex(2),
++			# The preceeding index is expected,
++			# as the following profile trigger commands will cause the utterance to be split here.
++			ConfigProfileTriggerCommand(t1, False),
+ 			""9 10 11 12""
+ 		]
+ 		with smi.expectation():","Is there a reason not to use `smi.create_expectedIndex` here (and in other places)? The `smi.create_expectedIndex` function will also check to make sure that you don't accidentally skip or duplicate any indexes. With the goal of avoiding errors in the test. It does mean that you have to be diligent with how the expected indexes are created, which can be annoying too. My logic was that it is better to be annoyed by constraints during development time than to find out some time later that the test didn't do what I thought.",`expectedToBecomeIndex` is now unused and can be removed.
+4249,"@@ -43,8 +43,8 @@ class StripeSubscription
+   def create_customer
+     new_stripe_customer = Stripe::Customer.create(
+       card: @checkout.stripe_token,
+-      description: @checkout.email,
+-      email: @checkout.email
++      description: @checkout.user_email,
++      email: @checkout.user_email,
+     )
+     @checkout.stripe_customer_id = new_stripe_customer.id
+   end",Put a comma after the last parameter of a multiline method call.,Why do we want to change it to `user_email`?
+4250,"@@ -29,7 +29,7 @@ type ImageWithPort struct {
+ type LBFargateConfig struct {
+ 	RoutingRule      `yaml:""http,flow""`
+ 	ContainersConfig `yaml:"",inline""`
+-	Public           bool               `yaml:""public""`
++	Public           *bool              `yaml:""public""` // A pointer because we don't want the environment override to default to false.
+ 	Scaling          *AutoScalingConfig `yaml:"",flow""`
+ }
+ ",I don't know if we even need this parameter.,Why change the default value from `false` to `false`?
+4251,"@@ -1,5 +1,5 @@
+ """"""Test that we are emitting arguments-differ when the arguments are different.""""""
+-# pylint: disable=missing-docstring, too-few-public-methods, unused-argument,useless-super-delegation, useless-object-inheritance
++# pylint: disable= arguments-renamed, missing-docstring, too-few-public-methods, unused-argument,useless-super-delegation, useless-object-inheritance
+
+ class Parent(object):
+ ",What is the new result of this file if we keep it the same than before? It's just to picture easily what changed in this MR :) (thinking is hard),These lines are too long and make lint fail.
+4252,"@@ -165,7 +165,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+
+                     using (var reader = new StreamReader(stream, Encoding.ASCII))
+                     {
+-                        var response = reader.ReadToEnd();
++                        var response = await reader.ReadToEndAsync();
+                         Assert.Contains($""bytesRead: {data.Length}"", response);
+                     }
+                 }",This needs to be synchronous for the timeout to work.,@stephentoub I don't know if this is a reasonable change or if there's a better way to do this.
+4253,"@@ -23,11 +23,7 @@ Where
+ <% if purchaseable.city.present? %><%= purchaseable.city %>, <% end %><%= purchaseable.state %> <%= purchaseable.zip %>
+ <% end -%>
+
+-<% unless purchaseable.starts_immediately? -%>
+-We will be in touch before <%= purchase.starts_on.to_s(:simple) %> with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.
+-<% end -%>
+-
+-<%= purchaseable.reminder_email %>
++We will be in touch before the workshop with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.
+
+ <% if purchaseable.workshop.announcement.present? -%>
+ <%= purchaseable.workshop.announcement.message %>",Can you break this onto multiple lines?,AFAIK the `start_immediately?` method is no longer used in this file.
+4254,"@@ -298,11 +298,11 @@ const instr_info_t A32_ext_bit7[][2] = {
+  */
+ const instr_info_t A32_ext_bit19[][2] = {
+   { /* 0 */
+-    {EXT_SIMD8,         0xf2800000, ""(ext simd8  0)"", xx, xx, xx, xx, xx, no, x, 0},
+-    {EXT_SIMD5,         0xf2880000, ""(ext simd5  0)"", xx, xx, xx, xx, xx, no, x, 0},
++    {EXT_SIMD8,         0xf2800010, ""(ext simd8  0)"", xx, xx, xx, xx, xx, no, x, 0},
++    {EXT_SIMD5,         0xf2880010, ""(ext simd5  0)"", xx, xx, xx, xx, xx, no, x, 0},
+   }, { /* 1 */
+-    {EXT_SIMD8,         0xf3800000, ""(ext simd8  1)"", xx, xx, xx, xx, xx, no, x, 1},
+-    {EXT_SIMD5,         0xf3880000, ""(ext simd5  1)"", xx, xx, xx, xx, xx, no, x, 1},
++    {EXT_SIMD8,         0xf3800010, ""(ext simd8  1)"", xx, xx, xx, xx, xx, no, x, 1},
++    {EXT_SIMD5,         0xf3880010, ""(ext simd5  1)"", xx, xx, xx, xx, xx, no, x, 1},
+   },
+ };
+ ","OK, it looks like all children have bit 4 set, but it doesn't really matter at this split point: just informative, nothing reads it.",i dont know how much of this change influence the compiler. but i thought we were getting rid o
+4255,"@@ -32,6 +32,12 @@ type DNSZoneSpec struct {
+ 	// Zone is the DNS zone to host
+ 	Zone string `json:""zone""`
+
++	// LinkToParentDomain specifies whether DNS records should
++	// be automatically created to link this DNSZone with a
++	// parent domain.
++	// +optional
++	LinkToParentDomain bool `json:""linkToParentDomain,omitempty""`
++
+ 	// AWS specifies AWS-specific cloud configuration
+ 	// +optional
+ 	AWS *AWSDNSZoneSpec `json:""aws,omitempty""`","Sorry for the very basic question but why do we still have a DNSZone CRD in light of the DNSEndpoint, I don't fully understand the differences.","I believe `json:""linkToParentDomain,omitempty""` is the default."
+4256,"@@ -0,0 +1,17 @@
++package session
++
++import (
++	""testing""
++	""github.com/stretchr/testify/assert""
++)
++
++func TestManagerHasUniqueSessionsStored(t *testing.T) {
++	manager := Manager{}
++	length := 10
++
++	for i := 0; i < length; i++ {
++		manager.Create()
++	}
++
++	assert.Len(t, manager.Sessions, length)
++}",Looks like loop with overhead. You can: - create SID - test private function `sessionIsUnique()`,"It would be better to use `assert.Len(t, manager.Sessions, length)`"
+4257,"@@ -54,6 +54,7 @@ public class UserPreferences {
+     private static final String PREF_SHOW_DOWNLOAD_REPORT = ""prefShowDownloadReport"";
+     public static final String PREF_BACK_BUTTON_BEHAVIOR = ""prefBackButtonBehavior"";
+     private static final String PREF_BACK_BUTTON_GO_TO_PAGE = ""prefBackButtonGoToPage"";
++    public static final String PREF_QUEUE_SORT_ORDER = ""prefQueueSortOrder"";
+
+     // Queue
+     private static final String PREF_QUEUE_ADD_TO_FRONT = ""prefQueueAddToFront"";","In my opinion, it would be better to have two separate settings. One that stores if sorting is enabled and one that stores the order. That allows to toggle automatic sort without having to re-select the order.",Should this be PREF_QUEUE_SORT_BY_ID?
+4258,"@@ -1,7 +1,10 @@
+ package main
+
+-import ""github.com/spiffe/sri/control_plane/cli""
+-import ""os""
++import (
++	""os""
++
++	""github.com/spiffe/sri/control_plane/cli""
++)
+
+ func main() {
+ 	control_plane_cli.Run(os.Args)",/me can't wait to rename this repo :),os should go at the top of the file.
+4259,"@@ -18,10 +18,14 @@ const handleCallback = require('../utils').handleCallback;
+ const indexInformationDb = require('./db_ops').indexInformation;
+ const isObject = require('../utils').isObject;
+ const Long = require('mongodb-core').BSON.Long;
++const makeLazyLoader = require('../utils').makeLazyLoader;
+ const MongoError = require('mongodb-core').MongoError;
+ const ReadPreference = require('mongodb-core').ReadPreference;
+ const toError = require('../utils').toError;
+
++const collLoader = makeLazyLoader(`${__dirname}/../collection`);
++const dbLoader = makeLazyLoader(`${__dirname}/../db`);
++
+ /**
+  * Group function helper
+  * @ignore",nit: maybe call these `loadCollection()/loadDb()`,These need to depend on `makeLazyLoader` and not on `dbLoader` sinc
+4260,"@@ -562,6 +562,19 @@ class Task(object):
+         Default behavior is to send an None value""""""
+         pass
+
++    def on_external_failure(self):
++        """"""
++        Override for custom error handling for failed external tasks.
++
++        This method gets called if a task is an :py:class:`luigi.task.ExternalTask`, or if a
++        :py:class:`luigi.task.Task`'s :py:meth:`run` method is not implemented.
++
++        The returned value is json encoded and sent to the scheduler as the `expl` argument.
++
++        Default behavior is to send a None value
++        """"""
++        pass
++
+     @contextmanager
+     def no_unpicklable_properties(self):
+         """"""",Did you consider just do `return Task is an external data dependency and data does not exist (yet?).'`? Less `None`'s and `ifs`.,Perhaps this could be renamed to `on_external_failure_override` to avoid confusion?
+4261,"@@ -2,13 +2,10 @@
+       <li class=""cite"">
+         <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect{|doc| doc.document_id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
+       </li>
+-      <li class=""refworks"">
+-        <%= render :partial => 'catalog/refworks_form', :locals => {:documents=>@document_list} %>
+-      </li>
+-
+-      <li class=""endnote"">
+-        <%= link_to t('blacklight.tools.endnote'), endnote_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}, :format => 'endnote'), {:class => 'btn btn-default'}%>
+-      </li>
++      <% if defined? BlacklightMarc %>
++        <%= render partial: 'bookmarks/refworks' %>
++        <%= render partial: 'bookmarks/endnote' %>
++      <% end %>
+       <li class=""email"">
+         <%= link_to t('blacklight.tools.email'), email_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}), :class=>""btn btn-default"", :id => ""emailLink"", :data => {:ajax_modal => ""trigger""} %>
+       </li>","Some day, we really need to make these toolbars pluggable..",This conditional block should be inside the i18n block.
+4262,"@@ -100,7 +100,11 @@ class WebEngineAction(browsertab.AbstractAction):
+         """"""Save the current page.""""""
+         self._widget.triggerPageAction(QWebEnginePage.SavePage)
+
+-    def show_source(self):
++    def show_source(self, pygment):
++        if pygment:
++            self._show_source_pygment()
++            return
++
+         try:
+             self._widget.triggerPageAction(QWebEnginePage.ViewSource)
+         except AttributeError:",This should be `pygment=False` like in `browsertab.py`,"`pygment` is unused, please remove it"
+4263,"@@ -766,6 +766,11 @@ func (s *Server) createClient(conn net.Conn) *client {
+ 		return c
+ 	}
+
++	// If there is a max subscriptions specified, add to the client.
++	if opts.MaxSubs > 0 {
++		c.msubs = opts.MaxSubs
++	}
++
+ 	// If there is a max connections specified, check that adding
+ 	// this new client would not push us over the max
+ 	if opts.MaxConn > 0 && len(s.clients) >= opts.MaxConn {",Should this be moved down (or up) to under the client lock instead of server lock?,This should probably be `opts.MaxSubs < c.msubs`.
+4264,"@@ -273,8 +273,6 @@ fpga_result __FPGA_API__ xfpga_fpgaGetMetricsByIndex(fpga_handle handle,
+ 			result = FPGA_OK;
+ 		}
+
+-	} else {
+-		result = FPGA_INVALID_PARAM;
+ 	}
+
+ out_unlock:",Why are we removing this?,Why was this removed?
+4265,"@@ -76,7 +76,7 @@ module Gsa18f
+
+     # @todo - this is pretty ugly
+     def public_identifier
+-      self.cart.id
++      ""##{self.cart.id}""
+     end
+
+     def total_price",What do you think about using `self.id` ?,Redundant `self` dete
+4266,"@@ -442,7 +442,17 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			retry := 0
++			for err != nil && retry < 10 {
++				// Set Ready and Live to false
++				healthAggregator.Report(healthName, &health.HealthReport{Live: false, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Warn(""Retrying to start Typha"")
++				retry++
++			}
++			if err != nil && retry > 10 {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()","Please log once here at Error level ""Failed to connect to Typha, will retry...""",Shouldn't this be ret
+4267,"@@ -1,5 +1,5 @@
+ # frozen_string_literal: true
+
+ module Faker #:nodoc:
+-  VERSION = '2.18.0'
++  VERSION = '2.18.1'
+ end",Can you revert this change? The `VERSION` value will be updated after maintainer determines the version at release.,Prefer double-quoted
+4268,"@@ -25,13 +25,13 @@ public interface DefinitionConst {
+
+   String nameKey = ""name"";
+
+-  String qulifiedServiceNameKey = serviceDescriptionKey + ""."" + nameKey;
++  String qualifiedServiceNameKey = serviceDescriptionKey + ""."" + nameKey;
+
+-  String qulifiedServiceVersionKey = serviceDescriptionKey + "".version"";
++  String qualifiedServiceVersionKey = serviceDescriptionKey + "".version"";
+
+-  String qulifiedServiceDescKey = serviceDescriptionKey + "".description"";
++  String qualifiedServiceDescKey = serviceDescriptionKey + "".description"";
+
+-  String qulifiedServiceRoleKey = serviceDescriptionKey + "".role"";
++  String qualifiedServiceRoleKey = serviceDescriptionKey + "".role"";
+
+   String allowCrossAppKey = ""allowCrossApp"";
+ ",It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string.,Can we get rid of `.version` and `.role`?
+4269,"@@ -108,8 +108,12 @@ module RSpec
+       #   or the configured failure exit code (1 by default) if specs
+       #   failed.
+       def run_specs(example_groups)
+-        @configuration.reporter.report(@world.example_count(example_groups)) do |reporter|
++        examples_count = @world.example_count(example_groups)
++        @configuration.reporter.report(examples_count) do |reporter|
+           @configuration.with_suite_hooks do
++            if examples_count == 0 && @configuration.fail_if_no_examples
++              return @configuration.failure_exit_code
++            end
+             example_groups.map { |g| g.run(reporter) }.all? ? 0 : @configuration.failure_exit_code
+           end
+         end","This should be `@configuration.failure_exit_code`, we don't want to hard code 1.",can this just be `if examples_count == 0`
+4270,"@@ -359,11 +359,10 @@ Blockly.FieldVariable.prototype.onItemSelected = function(menu, menuItem) {
+ };
+
+ /**
+- * Whether this field references any Blockly variables.  If true it may need to
+- * be handled differently during serialization and deserialization.  Subclasses
+- * may override this.
+- * @return {boolean} True if this field has any variable references.
++ * Overrides referencesVariables(), indicating this field refers to a variable.
++ * @return {boolean} True.
+  * @package
++ * @override
+  */
+ Blockly.FieldVariable.prototype.referencesVariables = function() {
+   return true;",Changed per review in Blockly.,did you mean to remove this override?
+4271,"@@ -968,12 +968,13 @@ func (c *client) bridgeAndUplinkFlows(uplinkOfport uint32, bridgeLocalPort uint3
+ 			Cookie(c.cookieAllocator.Request(category).Raw()).
+ 			Done(),
+ 		// Forward the packet to conntrackTable if it enters the OVS pipeline from the bridge interface and is sent to
+-		// local Pods.
++		// local Pods. Set the packet with MAC rewrite mark, so that the dstMAC will be re-written with real MAC in
++		// the L3Routing table, and it could be forwarded to the valid OVS interface.
+ 		c.pipeline[ClassifierTable].BuildFlow(priorityHigh).
+ 			MatchProtocol(binding.ProtocolIP).
+ 			MatchInPort(bridgeLocalPort).
+ 			MatchDstIPNet(localSubnet).
+-			Action().SetDstMAC(globalVirtualMAC).
++			Action().LoadRegRange(int(marksReg), macRewriteMark, macRewriteMarkRange).
+ 			Action().GotoTable(conntrackTable).
+ 			Cookie(c.cookieAllocator.Request(category).Raw()).
+ 			Done(),",Hi @wenyingd . so what's the original dst MAC of the reply packet from kube-proxy?,I think we should keep this call to `Acti
+4272,"@@ -402,6 +402,15 @@ class MisdesignChecker(BaseChecker):
+                 ""statement (see R0916)."",
+             },
+         ),
++        (
++            ""exclude-too-few-public-methods"",
++            {
++                ""default"": (),
++                ""type"": ""csv"",
++                ""metavar"": ""<comma separated list of class names>"",
++                ""help"": ""List of qualified class names to ignore when counting public methods (see R0903)"",
++            },
++        ),
+     )
+
+     def __init__(self, linter=None):","Note: I wasn't sure what the right wording would be for this, so I used existing language from elsewhere in the codebase.","I think we should include a link to the docs for this option, so that people know how to exclude things."
+4273,"@@ -113,3 +113,13 @@ class Config(object):
+         # grab config_file default from molecule if it's not set in the user-supplied ansible options
+         if 'config_file' not in self.config['ansible']:
+             self.config['ansible']['config_file'] = self.config['molecule']['config_file']
++
++    def populate_instance_names(self, platform):
++        """"""
++        Updates instances section of config with an additional key containing the full instance name
++
++        :return: None
++        """"""
++        for instance in self.config['vagrant']['instances']:
++            instance['vm_name'] = utilities.format_instance_name(instance['name'], platform,
++                                                                 self.config['vagrant']['instances'])",Docstring for `platform`.,Why isn't this just `self.config['vagrant']['instances']`?
+4274,"@@ -85,7 +85,9 @@ func Main() {
+ 	if err != nil {
+ 		fmt.Fprintf(os.Stderr, ""%s: %v\n"", subcommand.Name, err)
+ 	}
+-
++	if err := cleanup(); err != nil {
++		fmt.Fprintf(os.Stderr, ""error restoring console to functional state: %v\n"", err)
++	}
+ 	os.Exit(exitCode)
+ }
+ ",This should be called before any `os.Exit` otherwise it could still mess up things.,Did you mean to leave this here or was it just for debugging?
+4275,"@@ -7,16 +7,16 @@ package MyGame.Example;
+  */
+ public final class Color {
+   private Color() { }
+-  public static final byte Red = 1;
++  public static final int Red = 1;
+   /**
+    * \brief color Green
+    * Green is bit_flag with value (1u << 1)
+    */
+-  public static final byte Green = 2;
++  public static final int Green = 2;
+   /**
+    * \brief color Blue (1u << 3)
+    */
+-  public static final byte Blue = 8;
++  public static final int Blue = 8;
+
+   public static final String[] names = { ""Red"", ""Green"", """", """", """", """", """", ""Blue"", };
+ ",shouldn't this be `short` ?,This looks like a binary breaking change. Is this intentional?
+4276,"@@ -63,15 +63,15 @@ func (c *CmdVolumeOptions) RunVolumesList(cmd *cobra.Command) error {
+ 	}
+
+ 	out := make([]string, len(cvols.Items)+2)
+-	out[0] = ""Namespace|Name|Status|Type""
+-	out[1] = ""---------|----|------|----""
++	out[0] = ""Namespace|Name|Status|Type|Capacity""
++	out[1] = ""---------|----|------|----|--------""
+ 	for i, items := range cvols.Items {
+ 		if len(items.Status.Reason) == 0 {
+ 			items.Status.Reason = volumeStatusOK
+ 		}
+-		out[i+2] = fmt.Sprintf(""%s|%s|%s|%s"", items.ObjectMeta.Namespace,
++		out[i+2] = fmt.Sprintf(""%s|%s|%s|%s|%s"", items.ObjectMeta.Namespace,
+ 			items.ObjectMeta.Name,
+-			items.Status.Reason, items.Spec.CasType)
++			items.Status.Reason, items.Spec.CasType, items.Spec.Capacity)
+ 	}
+ 	if len(out) == 2 {
+ 		fmt.Println(""No Volumes are running"")",Can you please paste the output of `volume list` command which will show capacity of a openebs volume.,Did you mean to add `|--------`?
+4277,"@@ -83,10 +83,15 @@ public class MetricRegistry implements MetricSet {
+      * @param metric the metric
+      * @param <T>    the type of the metric
+      * @return {@code metric}
+-     * @throws IllegalArgumentException if the name is already registered
++     * @throws IllegalArgumentException if the name is already registered or metric variable is null
+      */
+     @SuppressWarnings(""unchecked"")
+     public <T extends Metric> T register(String name, T metric) throws IllegalArgumentException {
++
++        if (metric == null) {
++            throw new IllegalArgumentException(""metric variable must not be null !!!"");
++        }
++
+         if (metric instanceof MetricRegistry) {
+             final MetricRegistry childRegistry = (MetricRegistry)metric;
+             final String childName = name;","I'd make this a `throw new NullPointerException(""metric == null"");` instead",Typo: `or` instead of `or`
+4278,"@@ -27,6 +27,7 @@ extern ""C"" {
+ #include ""ScriptingEnvironment.h""
+ #include ""../typedefs.h""
+ #include ""../Util/OpenMPWrapper.h""
++#include ""../Util/LuaUtil.h""
+
+ ScriptingEnvironment::ScriptingEnvironment() {}
+ ScriptingEnvironment::ScriptingEnvironment(const char * fileName) {",Include should be order lexicographically.,why move this?
+4279,"@@ -538,7 +538,7 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+                 final PasscodeManager passcodeManager = mgr.getPasscodeManager();
+                 passcodeManager.storeMobilePolicyForOrg(account, id.screenLockTimeout * 1000 * 60, id.pinLength);
+                 passcodeManager.setTimeoutMs(id.screenLockTimeout * 1000 * 60);
+-                passcodeManager.setMinPasscodeLength(id.pinLength);
++                boolean changeRequired = passcodeManager.setMinPasscodeLength((Activity) getContext(), id.pinLength);
+
+                 /*
+                  * Checks if a passcode already exists. If a passcode has NOT","We need to pass in the Activity context here, so that LoginActivity is used, and so that LoginActivity can get onActivityResult from the PasscodeActivity. Without this, the application context is used, and we don't get a callback when the passcode is done.",I don't understand the point of
+4280,"@@ -39,4 +39,10 @@ class Tracepoint < ActiveRecord::Base
+     el1 << (XML::Node.new(""time"") << timestamp.xmlschema) if print_timestamp
+     el1
+   end
++
++  # Return points of trackable traces in original order
++  scope :trackable_ordered, -> { joins(:trace).where(:gpx_files => { :visibility => %w[trackable identifiable] }).order(""gpx_id DESC, trackid ASC, timestamp ASC"") }
++
++  # Hide the order of points of non-trackable traces for privacy
++  scope :non_trackable_unordered, -> { joins(:trace).where(:gpx_files => { :visibility => %w[public private] }).order(""gps_points.latitude"", ""gps_points.longitude"") }
+ end","Can you move these to the top please, for consistency with other models - normally we put scopes immediately after the associations at the top of the model. As to names I agree with @gravitystorm that these names may be confusing but I'm not sure the ones I suggested are perfect either so I'm not really sure what's best. The goal of my names was just to separate point which could be ordered (as `ordered`) from those which can't (as `unordered`) but I realise that may not be very clear from the names.",Line is too long. [89/80]
+4281,"@@ -1117,7 +1117,10 @@ public class PlaybackService extends MediaBrowserServiceCompat {
+                 // only mark the item as played if we're not keeping it anyways
+                 DBWriter.markItemPlayed(item, FeedItem.PLAYED, ended);
+                 // don't know if it actually matters to not autodownload when smart mark as played is triggered
+-                DBWriter.removeQueueItem(PlaybackService.this, ended, item);
++                boolean shouldRepeat = UserPreferences.getShouldRepeatEpisode();
++                if (!shouldRepeat) {
++                    DBWriter.removeQueueItem(PlaybackService.this, ended, item);
++                }
+                 // Delete episode if enabled
+                 FeedPreferences.AutoDeleteAction action =
+                         item.getFeed().getPreferences().getCurrentAutoDelete();",Looks like the episode should also not be deleted when repeating,nitpicking: `shouldRepeat
+4282,"@@ -13,6 +13,7 @@ package proxy
+
+ import (
+ 	""crypto/tls""
++	""github.com/mholt/caddy/caddyhttp/httpserver""
+ 	""io""
+ 	""net""
+ 	""net/http""",I feel like goimports would move this import line by the other non-std packages... can you double-check that? Run goimports or set up your editor to run it on save. :+1:,This import should go at
+4283,"@@ -60,6 +60,19 @@ module Selenium
+
+         class << self
+           def chrome(opts = {})
++            define_method(:options) { @capabilities[:chrome_options] ||= {} }
++            define_method(""options="") { |value| @capabilities[:chrome_options] = value }
++            define_method(""profile="") do |profile|
++              profile_json = profile.as_json
++              options['args'] ||= []
++              if options['args'].none? { |arg| arg =~ /user-data-dir/ }
++                options['args'] << ""--user-data-dir=#{profile_json[:directory]}""
++              end
++              options['extensions'] = profile_json[:extensions]
++            end
++            alias_method :chrome_options, :options
++            alias_method :chrome_options=, :options=
++
+             new({
+               browser_name: 'chrome',
+               javascript_enabled: true,",`options['binary'] = WebDriver::Chrome.path` if set?,this should probably be `
+4284,"@@ -134,6 +134,9 @@ var (
+ 		DB: DB{
+ 			UseBadgerDB: false,
+ 			NumRetries:  3,
++			SQLITE3: SQLITE3{
++				SQLite3File:	""./explorer.db"",
++			},
+ 		},
+ 	}
+ ",File is not `goimports`-ed (from `goimports`),Can we change this to `./explorer.db`?
+4285,"@@ -19,13 +19,18 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     /// </summary>
+     public class ListenOptions : IEndPointInformation, IConnectionBuilder
+     {
++        internal const string Http2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experimental.Http2"";
++
+         private FileHandleType _handleType;
++        private HttpProtocols _protocols = HttpProtocols.Http1;
++        internal bool _isHttp2Supported;
+         private readonly List<Func<ConnectionDelegate, ConnectionDelegate>> _components = new List<Func<ConnectionDelegate, ConnectionDelegate>>();
+
+         internal ListenOptions(IPEndPoint endPoint)
+         {
+             Type = ListenType.IPEndPoint;
+             IPEndPoint = endPoint;
++            AppContext.TryGetSwitch(Http2ExperimentSwitch, out _isHttp2Supported);
+         }
+
+         internal ListenOptions(string socketPath)",Nit: Supported -> Enabled.,Should this variable be called `_http2
+4286,"@@ -128,7 +128,7 @@ class ImportTest(QuiltTestCase):
+
+         # Modify an existing dataframe
+         csv = package1.dataframes2.csv._data()
+-        csv.set_value(0, 'Int0', 42)
++        csv.at[0, 'Int0'] = 42
+
+         # Add a new dataframe
+         df = pd.DataFrame(dict(a=[1, 2, 3]))",Yay! I was too lazy to fix this.,Could you explain why this change is n
+4287,"@@ -28,8 +28,7 @@ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/versioned""
+ 	""github.com/openebs/maya/pkg/debug""
+-	merrors ""github.com/openebs/maya/pkg/errors/v1alpha1""
+-	pkg_errors ""github.com/pkg/errors""
++	errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""",other declaration of errors (from `typecheck`),`pkg/errors` is already imported by th
+4288,"@@ -13,12 +13,15 @@ import (
+ )
+
+ var (
+-	errValueEmpty      = errors.New(""value must not be empty"")
+-	errValueTooLong    = errors.New(""value must not exceed 255 characters"")
+-	errValueBadFormat  = errors.New(""value must start with a letter and contain only lower-case letters, numbers, and hyphens"")
+-	errValueNotAString = errors.New(""value must be a string"")
++	errValueEmpty        = errors.New(""value must not be empty"")
++	errValueTooLong      = errors.New(""value must not exceed 255 characters"")
++	errValueBadFormat    = errors.New(""value must start with a letter and contain only lower-case letters, numbers, and hyphens"")
++	errValueNotAString   = errors.New(""value must be a string"")
++	errInvalidGitHubRepo = errors.New(""Please enter a valid GitHub repository, e.g. https://github.com/myCompany/myRepo"")
+ )
+
++var githubRepoExp = regexp.MustCompile(`https:\/\/github\.com\/(?P<owner>.+)\/(?P<repo>.+)`)
++
+ func validateProjectName(val interface{}) error {
+ 	if err := basicNameValidation(val); err != nil {
+ 		return fmt.Errorf(""project name %v is invalid: %w"", val, err)",nit: error starts with capital letter,Can we move the regex out of `validateProjectName` and into `validateName`?
+4289,"@@ -1616,16 +1616,7 @@ public class ImapStore extends Store {
+                 ImapList flags = fetchList.getKeyedList(""FLAGS"");
+                 if (flags != null) {
+                     for (int i = 0, count = flags.size(); i < count; i++) {
+-                        String flag = flags.getString(i);
+-                        if (flag.equalsIgnoreCase(""\\Deleted"")) {
+-                            message.setFlagInternal(Flag.DELETED, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Answered"")) {
+-                            message.setFlagInternal(Flag.ANSWERED, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Seen"")) {
+-                            message.setFlagInternal(Flag.SEEN, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Flagged"")) {
+-                            message.setFlagInternal(Flag.FLAGGED, true);
+-                        }
++                        message.setFlagInternal(Flag.valueOfByRealName(flags.getString(i)), true);
+                     }
+                 }
+             }","the original code ignores \Draft and \Recent, whereas your change will not. what this matters, i'm not sure.",Shouldn't we also set the flag if the flag is actually set?
+4290,"@@ -381,6 +381,8 @@ func TestQuotaReclamationDeletedBlocks(t *testing.T) {
+ 	}
+
+ 	// Stall the puts that comes as part of the sync call.
++	oldBServer := config2.BlockServer()
++	defer config2.SetBlockServer(oldBServer)
+ 	onWriteStalledCh, writeUnstallCh, ctxStall := StallBlockOp(
+ 		ctx, config2, StallableBlockPut)
+ ",Why was this necessary?,why we need this?
+4291,"@@ -111,6 +111,7 @@ var opts struct {
+ 	Test struct {
+ 		FailingTestsOk  bool         `long:""failing_tests_ok"" hidden:""true"" description:""Exit with status 0 even if tests fail (nonzero only if catastrophe happens)""`
+ 		NumRuns         int          `long:""num_runs"" short:""n"" default:""1"" description:""Number of times to run each test target.""`
++		Rerun           bool         `long:""rerun"" description:""To force rerunning tests for a target""`
+ 		Sequentially    bool         `long:""sequentially"" description:""Whether to run multiple runs of the same test sequentially""`
+ 		TestResultsFile cli.Filepath `long:""test_results_file"" default:""plz-out/log/test_results.xml"" description:""File to write combined test results to.""`
+ 		SurefireDir     cli.Filepath `long:""surefire_dir"" default:""plz-out/surefire-reports"" description:""Directory to copy XML test results to.""`",Can you also do this for Cover?,Does this need to be hidden?
+4292,"@@ -4978,6 +4978,16 @@ bool CoreChecks::ValidateImageSubresourceRange(const uint32_t image_mip_count, c
+         }
+     }
+
++    if (subresourceRange.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
++        if (subresourceRange.aspectMask &
++            (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT)) {
++            skip |= LogError(image, ""VUID-VkImageSubresourceRange-aspectMask-01670"",
++                             ""%s: aspectMask includes both VK_IMAGE_ASPECT_COLOR_BIT and one of VK_IMAGE_ASPECT_PLANE_0_BIT, ""
++                             ""VK_IMAGE_ASPECT_PLANE_1_BIT, or VK_IMAGE_ASPECT_PLANE_2_BIT."",
++                             cmd_name);
++        }
++    }
++
+     return skip;
+ }
+ ","So I tried adding this VU a long time ago, thought it would be this simple of a check, but turns out there were other validation in the way for getting here in `ValidateImageAspectMask` I assume that is what is failing CI here, realized it would require some more refactoring","Can you also include the error message here, so that we know what caused the error?"
+4293,"@@ -0,0 +1,6 @@
++class Arel::Table
++  def coalesce_and_sum(column, value)
++    coalesce_result = Arel::Nodes::NamedFunction.new('COALESCE', [self[column], value])
++    Arel::Nodes::NamedFunction.new('SUM', [coalesce_result], column.to_s)
++  end
++end","This method is not needed for postgresql, by default sum function omits null values so we can remove this file",TIL about `COALESCE`!
+4294,"@@ -378,7 +378,10 @@ dnl We have separate checks for libsystemd and the unit dir for historical reaso
+ PKG_CHECK_MODULES([LIBSYSTEMD], [libsystemd], [have_libsystemd=yes], [have_libsystemd=no])
+ AM_CONDITIONAL(BUILDOPT_LIBSYSTEMD, test x$have_libsystemd = xyes)
+ AM_COND_IF(BUILDOPT_LIBSYSTEMD,
+-           AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd]))
++           AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd])
++           systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)
++           AC_SUBST(systemdsystemgeneratordir)
++           )
+
+ AS_IF([test ""x$have_libsystemd"" = ""xyes""], [
+   with_systemd=yes",Can you provide a `--with-systemdsystemgeneratordir` option here? So that I can do unprivileged installs without completely turning off systemd. I can add it as a follow-up PR too.,Do we really need the `systemdsystemgeneratordir` variable? Can't we just use `PKG_
+4295,"@@ -396,11 +396,10 @@ class CLAModel(Model):
+       inferences = self._multiStepCompute(rawInput=inputRecord)
+     # For temporal classification. Not used, and might not work anymore
+     elif self._isClassificationModel():
+-      inferences = self._classificationCompute()
+-
+-    results.inferences.update(inferences)
+-
+-    inferences = self._anomalyCompute()
++      inferences = self._classifcationCompute()
++    else:
++      inferences = self._anomalyCompute()
++
+     results.inferences.update(inferences)
+
+     # -----------------------------------------------------------------------",`classification` is misspelled,There is a typo here: `inferences`
+4296,"@@ -152,7 +152,7 @@ public class SampleTransformer {
+     // to
+     // use is the first one on the list, since we set it in the overload of generateSamples.
+     if (methodSampleViews.size() > 0) {
+-      methodViewBuilder.initCode(methodSampleViews.get(0).initCode());
++      methodViewBuilder.initCode(methodSampleViews.get(0).methodInitCode());
+
+       // Don't emit samples that were specifically generated for backward-compatibility. We only
+       // wanted them for initCode above.",Can you change this to `sampleInitCode`?,Can we rename this to `methodSampleViewsInitialized` or similar?
+4297,"@@ -823,6 +823,7 @@ public class TiDAGRequest implements Serializable {
+       sb.append("", Limit: "");
+       sb.append(""["").append(limit).append(""]"");
+     }
++    sb.append("", startTs: "").append(startTs.getVersion());
+     return sb.toString();
+   }
+ ",I added a startTs information in `TiDagRequest` output. Not really sure if it is useful? @zhexuany,Could you please help to understand the purpose of this `StringB
+4298,"@@ -27,7 +27,12 @@ function collectResultsFromFrames(
+   frames.forEach(frame => {
+     const tabindex = parseInt(frame.node.getAttribute('tabindex'), 10);
+     const focusable = isNaN(tabindex) || tabindex >= 0;
++
+     const rect = frame.node.getBoundingClientRect();
++    let width = parseInt(frame.node.getAttribute('width'), 10);
++    let height = parseInt(frame.node.getAttribute('height'), 10);
++    width = isNaN(width) ? rect.width : width;
++    height = isNaN(height) ? rect.height : height;
+
+     var params = {
+       options: options,",This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5).,Do we need to check for `null` here since `getBoundingClientRect
+4299,"@@ -22,10 +22,11 @@ class PublicPagesController < ApplicationController
+     @template = Template.live(params[:id])
+     # covers authorization for this action.
+     # Pundit dosent support passing objects into scoped policies
++    skip_authorization
+     unless PublicPagePolicy.new(@template).template_export?
+-      raise Pundit::NotAuthorizedError
++      redirect_to public_templates_path, notice: ""You are not authorized to export that template"" and return
++      #raise Pundit::NotAuthorizedError
+     end
+-    skip_authorization
+     # now with prefetching (if guidance is added, prefetch annottaions/guidance)
+     @template = Template.includes(
+       :org,",prefer to just add this to the `verify_authorized` exception list above since we're already making exceptions.,Just remove the `skip_authorization` line here.
+4300,"@@ -139,10 +139,17 @@ class Populator
+
+         $dependent_classlikes[$fq_classlike_name_lc] = true;
+
+-        $this->populateDataFromTraits($storage, $storage_provider, $dependent_classlikes);
++        foreach ($storage->used_traits as $used_trait_lc => $_) {
++            $this->populateDataFromTrait($storage, $storage_provider, $dependent_classlikes, $used_trait_lc);
++        }
+
+         if ($storage->parent_classes) {
+-            $this->populateDataFromParentClass($storage, $storage_provider, $dependent_classlikes);
++            $this->populateDataFromParentClass(
++                $storage,
++                $storage_provider,
++                $dependent_classlikes,
++                reset($storage->parent_classes)
++            );
+         }
+
+         if (!strpos($fq_classlike_name_lc, '\\')",was there a reason to not loop over parent classes here?,`foreach ($storage->used_traits as $used_trait_lc => $_) {` doesn't make sense here
+4301,"@@ -1,6 +1,8 @@
+-import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
+ import Ember from 'ember';
++import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
+ import UserSession from 'hospitalrun/mixins/user-session';
++
++const { computed } = Ember;
+ /**
+  * Abstract route for top level modules (eg patients, inventory, users)
+  */",@billybonks Why move `import Ember from 'ember';` to the top?,please revert this change
+4302,"@@ -1,7 +1,16 @@
+ class Approval < ActiveRecord::Base
+-  include ThreeStateWorkflow
+-
+-  workflow_column :status
++  include WorkflowModel
++  workflow do
++    state :pending do
++      event :make_actionable, transitions_to: :actionable
++    end
++    state :actionable do
++      event :approve, transitions_to: :approved
++      event :reject, transitions_to: :rejected
++    end
++    state :approved
++    state :rejected
++  end
+
+   belongs_to :proposal
+   has_one :cart, through: :proposal",Everything's so simple (a `ThreeStateWorkflow`) until it isn't :smirk:,Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
+4303,"@@ -57,8 +57,9 @@ class OperationTests(ComparisonTestCase):
+     def test_image_contours(self):
+         img = Image(np.array([[0, 1, 0], [3, 4, 5.], [6, 7, 8]]))
+         op_contours = contours(img, levels=[0.5])
+-        contour = Contours([[(-0.5,  0.416667, 0.5), (-0.25, 0.5, 0.5)],
+-                             [(0.25, 0.5, 0.5), (0.5, 0.45, 0.5)]],
++        contour = Contours([[(-0.5,  0.416667, 0.5), (-0.25, 0.5, 0.5),
++                             (np.NaN, np.NaN, 0.5), (0.25, 0.5, 0.5),
++                             (0.5, 0.45, 0.5)]],
+                             vdims=img.vdims)
+         self.assertEqual(op_contours, contour)
+ ",I don't quite understand where the NaNs come from...,What is the motivation for this change?
+4304,"@@ -45,8 +45,8 @@ func LoadTestConfig(addr string, allowMultiConnsPerHost bool) *config.Network {
+ 	config := config.Config{
+ 		NodeType: config.DelegateType,
+ 		Network: config.Network{
+-			Host:                    host,
+-			Port:                    port,
++			Host: host,
++			Port: port,
+ 			MsgLogsCleaningInterval: 2 * time.Second,
+ 			MsgLogRetention:         10 * time.Second,
+ 			HealthCheckInterval:     time.Second,",File is not `goimports`-ed,what is the purpose of this change?
+4305,"@@ -354,6 +354,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Go.PleaseGoTool = ""//_please:please_go""
+ 	config.Go.EmbedTool = ""//_please:please_go_embed""
+ 	config.Python.PexTool = ""//_please:please_pex""
++	config.Python.WheelResolverTool = ""//_please:wheel_resolver""
+ 	config.Java.JavacWorker = ""//_please:javac_worker""
+ 	config.Java.JarCatTool = ""//_please:jarcat""
+ 	config.Java.JUnitRunner = ""//_please:junit_runner""",I wonder if we should look at moving the Python stuff to a plugin and doing this there rather than adding to core plz at this point?,I'm not sure how I feel about this.
+4306,"@@ -44,8 +44,7 @@ class Syntax(base.BaseCommand):
+         ansible = ansible_playbook.AnsiblePlaybook(self.molecule.config.config[
+             'ansible'])
+         ansible.add_cli_arg('syntax-check', True)
+-        ansible.add_cli_arg('inventory-file', 'localhost,')
+-
++        ansible.add_cli_arg('inventory_file', 'localhost,')
+         utilities.print_info(""Checking playbooks syntax ..."")
+
+         return ansible.execute(hide_errors=True)",This is the actual bug fix. I prob should have broken this out into two PRs.,would it make sense to rename `'inv
+4307,"@@ -235,6 +235,16 @@ namespace Nethermind.Core.Specs
+         /// </summary>
+         bool IsEip3198Enabled { get; }
+
++        /// <summary>
++        /// Difficulty Bomb Delay to Q2/2022
++        /// </summary>
++        bool IsEip3238Enabled { get; }
++
++        /// <summary>
++        /// Reduction in refunds
++        /// </summary>
++        bool IsEip3529Enabled { get; }
++
+         /// <summary>
+         /// Should transactions be validated against chainId.
+         /// </summary>","I am not sure if we need this, we already have DifficultyBombDelays",Please rename to IsEip3529Enabled.
+4308,"@@ -389,6 +389,9 @@ namespace Nethermind.Blockchain.Synchronization
+                             }
+                         }
+                     }
++
++                    delaySource.Dispose();
++                    linkedSource.Dispose();
+                 }, token);
+         }
+ ","move to finally - I can see at least one return that would omit it, also any exception and so on","Shouldn't this be `disposing` event, not `disposing`?"
+4309,"@@ -122,7 +122,9 @@ func NewProtocol(
+ 	if cfg.Consensus.Scheme != config.RollDPoSScheme {
+ 		return nil, nil
+ 	}
+-	if !genesisConfig.EnableGravityChainVoting || electionCommittee == nil || genesisConfig.GravityChainStartHeight == 0 {
++
++	if !genesisConfig.EnableGravityChainVoting || genesisConfig.GravityChainStartHeight == 0 ||
++		(electionCommittee == nil && stakingV2 == nil) {
+ 		delegates := genesisConfig.Delegates
+ 		if uint64(len(delegates)) < genesisConfig.NumDelegates {
+ 			return nil, errors.New(""invalid delegate address in genesis block"")",remove `genesisConfig.GravityChainStartHeight == 0`,Why do we need this check?
+4310,"@@ -4,6 +4,10 @@ declare(strict_types=1);
+
+ use Doctrine\Common\Annotations\AnnotationRegistry;
+
++$symfonyDumpFunctionPath = 'vendor/symfony/var-dumper/Resources/functions/dump.php';
++
++file_exists(__DIR__ . '/../' . $symfonyDumpFunctionPath) ? require_once __DIR__ . '/../' . $symfonyDumpFunctionPath : require_once __DIR__ . '/../../' . $symfonyDumpFunctionPath;
++
+ /* @var \Composer\Autoload\ClassLoader $loader */
+ $loader = file_exists(__DIR__ . '/../vendor/autoload.php') ? require __DIR__ . '/../vendor/autoload.php' : require __DIR__ . '/../../vendor/autoload.php';
+ ",this might kill whole application if `var-dumper` will not be installed. What about two separate file_exists conditions (monorepo/project)?,Shouldn't we do a `file_exists(__DIR__ . '/../' . $sy
+4311,"@@ -163,6 +163,11 @@ var ConfigCommand *cobra.Command = &cobra.Command{
+ 			util.Failed(""Could not write ddev config file: %v"", err)
+ 		}
+
++		_, err = app.CreateSettingsFile()
++		if err != nil {
++			util.Failed(""Could not write settings file: %w"", err)
++		}
++
+ 		// If a provider is specified, prompt about whether to do an import after config.
+ 		switch provider {
+ 		case ddevapp.DefaultProviderName:",Hrm. Maybe this isn't the correct spot to run this? Because it errors if the app type doesn't support settings. But we want to check that before running it.,The settings file only gets created if the provider p
+4312,"@@ -1359,7 +1359,7 @@ def get_terminal_width():
+         else:
+             return None
+
+-def pretty_routes(rtlst, header, sortBy=0):
++def pretty_list(rtlst, header, sortBy=0):
+     """"""Pretty route list, and add header""""""
+     _l_header = len(header[0])
+     _space = ""  """,Why are you changing this name ?,"I think this should stay as `pretty_routes`, since it is more similar to `list`"
+4313,"@@ -579,6 +579,12 @@ def in_docker():
+     """"""
+     if OVERRIDE_IN_DOCKER:
+         return True
++
++    # check things from Dockerfile
++    # TODO: is it enough? can we remove all the checks bellow?
++    if __file__.startswith(""/opt/code/localstack/"") and os.environ.get(""USER"") == ""localstack"":
++        return True
++
+     if os.path.exists(""/.dockerenv""):
+         return True
+     if not os.path.exists(""/proc/1/cgroup""):","as we discussed, maybe it would be better to - [ ] set OVERRIDE_IN_DOCKER=1 in the Dockerfile - [ ] replace the if statement with `os.path.exists(""/run/.containerenv"")` as @dfangl suggested","I'm not sure what you'd want to do here. If the user has `/opt/code/...` set, a"
+4314,"@@ -455,6 +455,11 @@ def is_ancestor_name(
+     return False
+
+
++def is_being_called(node: astroid.node_classes.NodeNG) -> bool:
++    """"""return True if node is the function being called in a Call node""""""
++    return isinstance(node.parent, astroid.Call) and node.parent.func is node
++
++
+ def assign_parent(node: astroid.node_classes.NodeNG) -> astroid.node_classes.NodeNG:
+     """"""return the higher parent which is not an AssignName, Tuple or List node""""""
+     while node and isinstance(node, (astroid.AssignName, astroid.Tuple, astroid.List)):",I like this style of doing things better than having super big conditional without explanation. Even though I know this won't be re-used it's nice to have a function if only for clarity.,Perhaps this should be called `is_being_called_in_call_node`?
+4315,"@@ -22,7 +22,10 @@ module RSpec
+         end
+
+         def example_group_finished(_notification)
+-          @group_level -= 1
++          if @group_level > 0
++            @group_level -= 1
++          end
++          @group_level
+         end
+
+         def example_passed(passed)",Our preference here is to either have inline statements e.g. `@group_level -= 1 if @group_level > 0` but stylistically here I think `return @group_level if @group_level == 0` might be nicer. As it stands however our rubocop is picking this up as a fail :(,what happens if @group_level is nil? do we want to raise an error?
+4316,"@@ -20,6 +20,16 @@
+ package org.apache.iceberg.spark.actions;
+
+ import org.apache.iceberg.actions.TestRemoveOrphanFilesAction;
++import org.junit.Ignore;
+
+ public class TestRemoveOrphanFilesAction3 extends TestRemoveOrphanFilesAction {
++
++  /**
++  * Todo: Its failing for Spark3, so has to fix it in the parent class.
++  * Ignoring for now, as still Spark3 is not supported.
++  *
++  */
++  @Ignore
++  public void testOlderThanTimestampWithPartitionWithWhitSpace() {
++  }
+ }","Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why","As above, we can leave this test as it is."
+4317,"@@ -399,3 +399,11 @@ def get_partition_set_execution_param_data(recon_repo, partition_set_name, parti
+         return ExternalPartitionExecutionErrorData(
+             serializable_error_info_from_exc_info(sys.exc_info())
+         )
++
++
++def get_notebook_data(notebook_path):
++    check.str_param(notebook_path, ""notebook_path"")
++
++    with open(os.path.abspath(notebook_path), ""rb"") as f:
++        content = f.read()
++        return content","something about the arbitrary file access part here makes me nervous. Can we keep the `if not path.endswith("".ipynb"")` check from before here as well? Just imagining a weird attack scenario where somebody somehow uses this to get access to confidental files or something",Better to use `check.is_file(os.path.abspa
+4318,"@@ -51,6 +51,14 @@ module Blacklight
+       deprecation_deprecate :solr_search_params_logic=
+     end
+
++    def search_builder_class
++      Blacklight::Solr::SearchBuilder
++    end
++
++    def search_builder processor_chain = search_params_logic
++      search_builder_class.new(processor_chain, self)
++    end
++
+
+     # @returns a params hash for searching solr.
+     # The CatalogController #index action uses this.",I wonder if we should push this and the search_params_logic into the blacklight config.,Layout/EmptyLinesAroundClassBody: Extra em
+4319,"@@ -38,6 +38,7 @@ func TestClient(t *testing.T) {
+ 	cfg := config.Default
+ 	cfg.API.Port = testutil.RandomPort()
+ 	ctx := context.Background()
++	cfg.Genesis.KamchatkaBlockHeight = 10
+
+ 	mockCtrl := gomock.NewController(t)
+ 	defer mockCtrl.Finish()","don't need this line, since it is not tested here?",Is this needed?
+4320,"@@ -197,6 +197,7 @@ class EmrConnection(AWSQueryConnection):
+                     steps=[],
+                     bootstrap_actions=[],
+                     instance_groups=None,
++                    ami_version=""1.0"",
+                     additional_info=None):
+         """"""
+         Runs a job flow",I wonder if adding this new param in the middle of the param list might screw up some existing code that is depending on the old parameter order. Might be better to add it to the end of the parameter list?,"Just a note, this should probably be `1.0.0` if it's not already hardcoded"
+4321,"@@ -178,7 +178,8 @@ public final class BaselineErrorProne implements Plugin<Project> {
+
+         errorProneOptions.setEnabled(true);
+         errorProneOptions.setDisableWarningsInGeneratedCode(true);
+-        errorProneOptions.setExcludedPaths(project.getBuildDir().getAbsolutePath() + ""/.*"");
++        errorProneOptions.setExcludedPaths(
++                String.format(""%s/(build|src/generated.*)/.*"", project.getProjectDir().getAbsolutePath()));
+         errorProneOptions.check(""EqualsHashCode"", CheckSeverity.ERROR);
+         errorProneOptions.check(""EqualsIncompatibleType"", CheckSeverity.ERROR);
+         errorProneOptions.check(""StreamResourceLeak"", CheckSeverity.ERROR);",I wonder if this absolute path is gonna affect the build-cache relocatability of these compile tasks??,I don't think this is correct. It would exclude all generated code from th
+4322,"@@ -18,10 +18,13 @@ class CommandOperationV2 extends OperationBase {
+     this.readPreference = ReadPreference.resolve(parent, this.options);
+     this.readConcern = resolveReadConcern(parent, this.options);
+     this.writeConcern = resolveWriteConcern(parent, this.options);
++    this.session = options && options.session;
++    this.inTransaction = this.session && this.session.inTransaction();
++    if (this.inTransaction) this.writeConcern = undefined;
+     this.explain = false;
+
+     if (operationOptions && typeof operationOptions.fullResponse === 'boolean') {
+-      this.fullResponse = true;
++      this.fullResponse = operationOptions.fullResponse;
+     }
+
+     // TODO: A lot of our code depends on having the read preference in the options. This should",possible bug if `fullResponse` is false,"Why do we need to check for `inTransaction` here? If we are not, we should"
+4323,"@@ -19,9 +19,11 @@
+
+ """"""A HintManager to draw hints over links.""""""
+
+-import math
+-import functools
+ import collections
++import functools
++import math
++import re
++from string import ascii_lowercase
+
+ from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QEvent, Qt, QUrl,
+                           QTimer)",nitpick: Please only `import string` here and use `string.ascii_lowercase` - I really like to see what module stuff is coming from without looking at the imports.,"Given that `ascii_lowercase` is used only in `pyqt5.py`, it might be a goo"
+4324,"@@ -2822,10 +2822,10 @@ exports.shouldCorrectlyLogoutFromTheDatabaseWithPromises = {
+
+               db.close();
+               test.done();
+-            }).catch(function(err) {  })
+-          }).catch(function(err) {  })
+-        }).catch(function(err) {  })
+-      }).catch(function(err) {  })
++            }).catch(function(err) {  console.dir(err )})
++          }).catch(function(err) {  console.dir(err )})
++        }).catch(function(err) {  console.dir(err )})
++      }).catch(function(err) {  console.dir(err )})
+     });
+     // END
+   }",nitpick: the only reason we have a catch for every one of these promises is because the test isn't properly chaining promises (returning them within each `then`). We could reduce the `catch` with `console.dir` to a single instance if that was done,@benhalpern do you want to log the error here too?
+4325,"@@ -85,6 +85,8 @@ TEST(NebulaCodec, encode) {
+     // check empty values
+     std::vector<boost::any> emptyV;
+     std::string emptyEncoded = codec.encode(emptyV);
++
++
+     SchemaWriter emptyWriter;
+     auto emptySchema = std::make_shared<ResultSchemaProvider>(emptyWriter.moveSchema());
+     auto emptyReader = RowReader::getRowReader(emptyEncoded, emptySchema);",why do this?,Is this intended?
+4326,"@@ -17,7 +17,7 @@ class MediaLibrary extends SystemMediaLibrary
+      */
+     protected function init()
+     {
+-        traceLog('Class Cms\Classes\MediaLibrary has been deprecated, use System\Classes\MediaLibrary instead.');
++        traceLog('Class Cms\Classes\MediaLibrary has been deprecated, use ' . SystemMediaLibrary::class . ' instead.');
+         parent::init();
+     }
+ }","For consistency, would it not be best to also replace the first class name? `traceLog('Class ' . static::class . ' has been deprecated, use ' . SystemMediaLibrary::class . ' instead.')`",Shouldn't we add the `__DIR__` constant?
+4327,"@@ -123,6 +123,9 @@ type PrometheusSpec struct {
+ 	// The labels to add to any time series or alerts when communicating with
+ 	// external systems (federation, remote storage, Alertmanager).
+ 	ExternalLabels map[string]string `json:""externalLabels,omitempty""`
++	// Enable access to prometheus web admin API. Defaults to the value of `true`.
++	// For more information see https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
++	EnableAdminApi string `json:""enableAdminApi,omitempty""`
+ 	// The external URL the Prometheus instances will be available under. This is
+ 	// necessary to generate correct URLs. This is necessary if Prometheus is not
+ 	// served from root of a DNS name.",this should be `EnabledAdminAPI` and the json string should then be `enableAdminAPI`,Why not call this `EnableAdminAPI`?
+4328,"@@ -4,6 +4,8 @@ from listenbrainz import webserver
+ from werkzeug.serving import run_simple
+ import os
+ import click
++import sqlalchemy
++from time import sleep
+
+ from listenbrainz.utils import safely_import_config
+ safely_import_config()",Noticed some missing imports in manage.py so thought I'd add them,use `from time import sleep` instead
+4329,"@@ -301,15 +301,10 @@ func (exp *flowExporter) sendFlowRecords() error {
+ 			exp.numDataSetsSent = exp.numDataSetsSent + 1
+
+ 			if flowexporter.IsConnectionDying(&record.Conn) {
+-				// If the connection is in dying state or connection is not in conntrack table,
+-				// we will delete the flow records from records map.
+-				klog.V(2).Infof(""Deleting the inactive flow records with key: %v from record map"", key)
+-				if err := exp.flowRecords.DeleteFlowRecordWithoutLock(key); err != nil {
+-					return err
+-				}
+-				if err := exp.conntrackConnStore.SetExportDone(key); err != nil {
+-					return err
+-				}
++				// If the connection is in dying state or connection is not in conntrack
++				// table, we set the DyingAndDoneExport flag to do the deletion later.
++				record.DyingAndDoneExport = true
++				exp.flowRecords.AddFlowRecordWithoutLock(&key, &record)
+ 			} else {
+ 				exp.flowRecords.ValidateAndUpdateStats(key, record)
+ 			}","as a future improvement, maybe we should just change `ForAllFlowRecordsDo` so that `updateOrSendFlowRecord` uses a flow record pointer instead of a copy of stored flow record. This whole code is executed with the lock any way.",do we still need to do this?
+4330,"@@ -37,6 +37,7 @@ import java.util.function.Consumer;
+  * A literal string.
+  * <br/><code>""Hello World!""</code>
+  * <br/><code>""\""\n""</code>
++ * <br/><code>""\u2122""</code>
+  * <br/><code>""™""</code>
+  * <br/><code>""💩""</code>
+  *",I am not sure what GitHub wants to tell me with this icon here :),Is there any specific reason for thi
+4331,"@@ -385,8 +385,8 @@ BOOST_AUTO_TEST_CASE(valid_nearest_urls)
+
+ BOOST_AUTO_TEST_CASE(valid_tile_urls)
+ {
+-    TileParameters reference_1{1, 2, 3};
+-    auto result_1 = parseParameters<TileParameters>(""tile(1,2,3).mvt"");
++    TileParameters reference_1{1, 2, 12};
++    auto result_1 = parseParameters<TileParameters>(""tile(1,2,12).mvt"");
+     BOOST_CHECK(result_1);
+     BOOST_CHECK_EQUAL(reference_1.x, result_1->x);
+     BOOST_CHECK_EQUAL(reference_1.y, result_1->y);",can we also check for smaller zoom levels returning valid error codes?,Why did this change?
+4332,"@@ -15,6 +15,16 @@ namespace ScenarioMeasurement
+             Console.WriteLine(message);
+         }
+
++        public void LogHeader1(string message)
++        {
++            Console.WriteLine($""=============== {message} ================ "");
++        }
++
++        public void LogHeader2(string message)
++        {
++            Console.WriteLine($""***{message}***"");
++        }
++
+         public void LogVerbose(string message)
+         {
+             Console.WriteLine(message);","1) These names are not great, doesn't help explain what they do. 2) Instead of methods like this that hard code some number of = and *, why not a method that takes the string, defaults to a char to surround with, and a width? 3) Do we really even need headers like this in the output? Maybe we ditch them.",`LogHeader1` and `LogHeader2` would be better names.
+4333,"@@ -2943,7 +2943,7 @@ describe('AutocompleteEditor', () => {
+
+       keyDownUp('arrow_up');
+
+-      expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[0, 0, 0, 0]]);
++      expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[11, 0, 11, 0]]);
+       done();
+     }, 200);
+   });","The autocomplete editor shouldn't change its own behavior, I assume that `autoWrapCol` and `autoWrapRow` options should be set to `false` in handsontable editor.","Instead of changing this, can you just use `[0, 0, 0"
+4334,"@@ -266,7 +266,7 @@ func testInstallTunnelFlows(t *testing.T, config *testConfig) {
+ }
+
+ func testInstallServiceFlows(t *testing.T, config *testConfig) {
+-	err := c.InstallClusterServiceFlows()
++	err := c.InstallClusterServiceFlows(true, true)
+ 	if err != nil {
+ 		t.Fatalf(""Failed to install Openflow entries to skip service CIDR from egress table: %v"", err)
+ 	}","out of curiosity, with IPv6 introduced, why there's no change to the expected output of openflow in the test?",This is the third place where we should be passing t
+4335,"@@ -67,7 +67,10 @@ byte *
+ decode_eflags_usage(dcontext_t *dcontext, byte *pc, uint *usage,
+                     dr_opnd_query_flags_t flags)
+ {
+-    *usage = 0; /* FIXME i#1569 */
++    /* As long as precise flag information is not provided we conservatively
++     * assume each instructions may read or write all flags.
++    */
++    *usage = EFLAGS_WRITE_ALL | EFLAGS_READ_ALL; /* FIXME i#2263 */
+     return pc + 4;
+ }
+ ",nit: grammar: instruction,Does this need a FIXME?
+4336,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,no need for this change
+4337,"@@ -69,7 +69,12 @@ func Add(mgr manager.Manager) error {
+
+ // newReconciler returns a new reconcile.Reconciler
+ func newReconciler(mgr manager.Manager) reconcile.Reconciler {
+-	return &ReconcileHiveConfig{Client: mgr.GetClient(), scheme: mgr.GetScheme(), restConfig: mgr.GetConfig(), mgr: mgr}
++	return &ReconcileHiveConfig{
++		Client:     mgr.GetClient(),
++		scheme:     mgr.GetScheme(),
++		restConfig: mgr.GetConfig(),
++		mgr:        mgr,
++	}
+ }
+
+ // add adds a new Controller to mgr with r as the reconcile.Reconciler",i think this missed the reconciler to callsite change,Does the ReconcileHiveC
+4338,"@@ -990,6 +990,10 @@ public class SurfaceNamer extends NameFormatterDelegator {
+     return getNotImplementedString(""SurfaceNamer.getGrpcClientImportName"");
+   }
+
++  public String getClientConfigImportModule(Interface service) {
++    return getNotImplementedString(""SurfaceNamer.getClientConfigImportModule"");
++  }
++
+   /////////////////////////////////// Docs & Annotations //////////////////////////////////////////
+
+   /** The documentation name of a parameter for the given lower-case field name. */",Please reuse `getClientConfigPath`.,"Same as above, let's re"
+4339,"@@ -19,7 +19,7 @@ const { eachAsyncSeries, ns } = require('../../../src/utils');
+
+ const chai = require('chai');
+ chai.use(require('chai-subset'));
+-chai.use(require('../../functional/spec-runner/matcher').default);
++chai.use(require('../../tools/spec-runner/matcher').default);
+
+ const expect = chai.expect;
+ ","Should we use the shared chai-addon.js file here? Actually we should consolidate any `chai.use` calls, I see 20 instances, quick win?",@erwinmombay PTAL this
+4340,"@@ -109,7 +109,7 @@ namespace Nethermind.Network.P2P.ProtocolHandlers
+                     HandleHello(Deserialize<HelloMessage>(msg.Data));
+
+                     foreach (Capability capability in
+-                        _agreedCapabilities.GroupBy(c => c.ProtocolCode).Select(c => c.OrderBy(v => v.Version).Last()))
++                        _agreedCapabilities.GroupBy(c => c.ProtocolCode).Select(c => c.OrderBy(v => v.Version).Last()).OrderBy(c => c.ProtocolCode))
+                     {
+                         if (Logger.IsTrace) Logger.Trace($""{Session} Starting protocolHandler for {capability.ProtocolCode} v{capability.Version} on {Session.RemotePort}"");
+                         SubprotocolRequested?.Invoke(this, new ProtocolEventArgs(capability.ProtocolCode, capability.Version));",Maybe move _agreedCapabilities and _availableCapabilities from List to SortedSet ? We could order them by code and then by version already.,Why did this change?
+4341,"@@ -3031,11 +3031,9 @@ func (o *consumer) setInitialPendingAndStart() {
+ 		// Here we are filtered.
+ 		dp := o.cfg.DeliverPolicy
+ 		if dp == DeliverLastPerSubject && o.hasSkipListPending() && o.sseq < o.lss.resume {
+-			if o.lss != nil {
+-				ss := mset.store.FilteredState(o.lss.resume, o.cfg.FilterSubject)
+-				o.sseq = o.lss.seqs[0]
+-				o.sgap = ss.Msgs + uint64(len(o.lss.seqs))
+-			}
++			ss := mset.store.FilteredState(o.lss.resume+1, o.cfg.FilterSubject)
++			o.sseq = o.lss.seqs[0]
++			o.sgap = ss.Msgs + uint64(len(o.lss.seqs))
+ 		} else if ss := mset.store.FilteredState(o.sseq, o.cfg.FilterSubject); ss.Msgs > 0 {
+ 			o.sgap = ss.Msgs
+ 			// See if we should update our starting sequence.","I see the `+1` issue, but we used to check if `o.lss != nil` and we don't anymore, so we are sure that it won't be nil here, right?",This is the one plac
+4342,"@@ -8,6 +8,11 @@
+   <% @documents&.each do |document| %>
+     <h1 class=""modal-title""><%= document_heading(document) %></h1>
+
++    <% if document.respond_to?(:export_as_preferred_citation_txt) %>
++      <h2><%= t('blacklight.citation.preferred') %></h2>
++      <%= document.send(:export_as_preferred_citation_txt).html_safe %><br/><br/>
++    <% end %>
++
+     <% if document.respond_to?(:export_as_mla_citation_txt) %>
+       <h2><%= t('blacklight.citation.mla') %></h2>
+       <%= document.send(:export_as_mla_citation_txt).html_safe %><br/><br/>",why is the `send` needed?,I don't think you ne
+4343,"@@ -106,8 +106,9 @@ def bbox2result(bboxes, labels, num_classes):
+     if bboxes.shape[0] == 0:
+         return [np.zeros((0, 5), dtype=np.float32) for i in range(num_classes)]
+     else:
+-        bboxes = bboxes.cpu().numpy()
+-        labels = labels.cpu().numpy()
++        if isinstance(bboxes, torch.Tensor):
++            bboxes = bboxes.cpu().numpy()
++            labels = labels.cpu().numpy()
+         return [bboxes[labels == i, :] for i in range(num_classes)]
+
+ ","Is this necessary? If so, we need to update the docstring.",How does this work?
+4344,"@@ -116,8 +116,8 @@ module Ncr
+
+     # the highest approver on the stack, pending preferred if status indicates
+     def current_approver_email_address
+-      if self.individual_approvals.pending.first
+-        self.individual_approvals.pending.first.user.email_address
++      if self.pending?
++        self.individual_approvals.where(status: 'actionable').first.user.email_address
+       else
+         self.approving_official.email_address
+       end",Checking for actionable here instead of grabbing the first pending approval. I tested this with proposal ID 265 on staging.,This is a little hard to read. Is there a way to rewrite this as `self.individual_approvals.where(status: 'pending').first`?
+4345,"@@ -100,7 +100,10 @@ class CallbackChecker(QObject):
+         if self._result is self.UNSET:
+             with self._qtbot.waitSignal(self.got_result, timeout=2000):
+                 pass
+-        assert self._result == expected
++        self._assert_result(self._result, expected)
++
++    def _assert_result(self, result, expected):
++        assert result == expected
+
+
+ @pytest.fixture",I made this change because I wasn't getting printouts of the 'result' value when the assert was inlined for some reason. I think it's related to creating new CallbackCheckers maybe?,"I just noticed this is a private method, can we just make it public?"
+4346,"@@ -0,0 +1,11 @@
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpParser
++    {
++        bool ParseStartLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpStartLineHandler;
++
++        bool ParseHeaders<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpHeadersHandler;
++    }
++}","nit: the correct name is ""request line"", so let's use the right one here :)",Do we still need this interface? Can we just make it `internal`?
+4347,"@@ -8,9 +8,12 @@ import os
+ SQLALCHEMY_DATABASE_URI = os.environ['SQLALCHEMY_DATABASE_URI']
+
+ REGISTRY_URL = os.environ['REGISTRY_URL']
+-CATALOG_HOST = os.environ['CATALOG_HOST']
+
+-CATALOG_URL = 'https://%s' % CATALOG_HOST
++CATALOG_URL = os.environ.get('CATALOG_URL')
++if not CATALOG_URL.startswith(""https""):
++    print(""WARNING: INSECURE CONNECTION TO CATALOG"")
++    # require verbose environment variable to be defined
++    assert os.environ['ALLOW_INSECURE_CATALOG_ACCESS']
+
+ PACKAGE_BUCKET_NAME = os.environ['PACKAGE_BUCKET_NAME']
+ ","This should now use `[]`, so it crashes if the var is missing",Why not `os.environ.get('ALLOW_INSECURE_CATALOG_ACCESS')`?
+4348,"@@ -162,6 +162,19 @@ static CALI_BPF_INLINE int skb_nat_l4_csum_ipv4(struct __sk_buff *skb, size_t of
+ 	return ret;
+ }
+
++static CALI_BPF_INLINE int update_state_map(struct cali_tc_state *state)
++{
++	int key = 0;
++	struct cali_tc_state *map_state = cali_v4_state_lookup_elem(&key);
++	if (!map_state) {
++		// Shouldn't be possible; the map is pre-allocated.
++		CALI_INFO(""State map lookup failed: DROP\n"");
++		return -1;
++	}
++	*map_state = *state;
++	return 0;
++}
++
+ static CALI_BPF_INLINE int forward_or_drop(struct __sk_buff *skb,
+ 					   struct cali_tc_state *state,
+ 					   struct fwd *fwd)",you could use `bpf_map_update_elem` with `BPF_EXIST`,Shouldn't this be called `update_state_map`?
+4349,"@@ -57,7 +57,7 @@ public class S3OutputFile extends BaseS3File implements OutputFile {
+     try {
+       return new S3OutputStream(client(), uri(), awsProperties());
+     } catch (IOException e) {
+-      throw new UncheckedIOException(""Filed to create output stream for location: "" + uri(), e);
++      throw new UncheckedIOException(""Failed to create output stream for location: "" + uri(), e);
+     }
+   }
+ ",thanks for noticing this! But I think we should not have it in this PR.,`Filed` -> `Failed`
+4350,"@@ -414,6 +414,11 @@ Transaction.prototype.lockUntilDate = function(time) {
+   if (_.isDate(time)) {
+     time = time.getTime() / 1000;
+   }
++
++    for (var i = 0; i < this.inputs.length; i++) {
++      this.inputs[i].sequence = Input.DEFAULT_LOCKTIME_SEQNUMBER;
++    }
++
+   this.nLockTime = time;
+   return this;
+ };","A few things: - This may not serialize because I think the property for the sequence number on an input is `.sequenceNumber`. - There should be tests to cover these statements - Indentation is incorrect (should be two spaces, as similar to the statements above)",This breaks `.length` if `this.inputs` is em
+4351,"@@ -89,3 +89,16 @@ class BaseNotification(object):
+         output_filename = filename_template.format(
+             self.resource, self.cycle_timestamp, output_timestamp)
+         return output_filename
++
++    @classmethod
++    def check_data_format(cls, data_format):
++        """"""Raise `InvalidDataFormatError` unless `data_format` is supported.
++
++        Args:
++            data_format (string): should be either 'csv' or 'json'
++
++        Raises:
++            InvalidDataFormatError: if not valid
++        """"""
++        if data_format not in cls.supported_data_formats:
++            raise InvalidDataFormatError('GCS uploader', data_format)","If this is a base method that could be used by others, should you hardcode 'GCS uploader' here?",Can you add a type annotation here? (Also in
+4352,"@@ -386,6 +386,18 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+         return result;
+     }
+
++    @Override
++    public CharSeq padTo(int length, Character element) {
++        if(length <= back.length()) {
++            return this;
++        }
++        final StringBuilder sb = new StringBuilder(back);
++        for (int i = 0; i < length - back.length(); i++) {
++            sb.append(element);
++        }
++        return new CharSeq(sb.toString());
++    }
++
+     public CharSeq mapChars(CharUnaryOperator mapper) {
+         Objects.requireNonNull(mapper, ""mapper is null"");
+         if (isEmpty()) {",just a little thing: let's introduce a `final int bound = length - back.length();` that saves us calculating the bound each time checking the loop condition.,Shouldn't this be `chars.length - back.length()`?
+4353,"@@ -87,6 +87,16 @@ func (s *server) setupRouting() {
+ 		""GET"": http.HandlerFunc(s.peerBalanceHandler),
+ 	})
+
++	router.Handle(""/settlements"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.settlementsHandler),
++	})
++	router.Handle(""/settlements/{peer}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.peerSettlementsHandler),
++	})
++	router.Handle(""/settlements/pay/{peer}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.payPeerHandler),
++	})
++
+ 	baseRouter.Handle(""/"", web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""debug api access""),
+ 		handlers.CompressHandler,","I think that this should be a POST method, as it changes the state. Get requests should not change the state. With different method, I would suggest to have the handler under `""/settlements/{peer}""` path.",How about `/settlements/pay`?
+4354,"@@ -31,6 +31,7 @@ var errShortRemoteTip = errors.New(""Unexpected remote less than tip"")
+ // L2GasPrice slot refers to the storage slot that the execution price is stored
+ // in the L2 predeploy contract, the GasPriceOracle
+ var l2GasPriceSlot = common.BigToHash(big.NewInt(1))
++var l2GasPriceOracleAddress = common.HexToAddress(""0x420000000000000000000000000000000000000F"")
+
+ // SyncService implements the main functionality around pulling in transactions
+ // and executing them. It can be configured to run in both sequencer mode and in",This is the default value?,Does it have to be a `common.Address`? Can it be
+4355,"@@ -1,8 +1,8 @@
+ import os
+ import codecs
+-
++from time import strftime
+ from cliquet import utils as cliquet_utils
+-
++from kinto import __version__
+ from kinto import logger
+
+ HERE = os.path.abspath(os.path.dirname(__file__))","The spaces are actually legitimate here: in python, you: - first import standard library modules (hint: time is one) - then import 3rd party library modules - then import the modules from you project (here kinto). Between each block you need an empty line.",Do we still need this?
+4356,"@@ -571,7 +571,7 @@ func (pi *PackageInfo) MarkedSource(obj types.Object) *cpb.MarkedSource {
+ // the object has its own non-blank name, that is used; otherwise if the object
+ // is of a named type, that type's name is used. Otherwise the result is ""_"".
+ func objectName(obj types.Object) string {
+-	if name := obj.Name(); name != """" && name != """" {
++	if name := obj.Name(); name != """" {
+ 		return name // the object's given name
+ 	} else if name := typeName(obj.Type()); name != """" {
+ 		return name // the object's type's name","Haha, whoa, I'm not sure how I let that one go by. :)","Why the earlier check for `name != """"`?"
+4357,"@@ -577,6 +577,7 @@ public class DownloadInstanceWriter implements MessageBodyWriter<DownloadInstanc
+         }
+     }
+
++    // TODO: Return "".md"" for ""text/markdown"" as well as other extensions in MimeTypeDetectionByFileExtension.properties
+     private String getFileExtension(AuxiliaryFile auxFile) {
+         String fileExtension = """";
+         if (auxFile == null) {",FWIW: We have FileUtil.generateOriginalExtension for tabular files but it uses a hardcoded list rather than the properties file.,"What do you mean by ""other extensions"" "
+4358,"@@ -297,6 +297,9 @@ func StartDataplaneDriver(configParams *config.Config,
+ 				InterfaceName:       configParams.WireguardInterfaceName,
+ 				MTU:                 configParams.WireguardMTU,
+ 				RouteSource:         configParams.RouteSource,
++				// currently, AKS *must* encrypt hostnetwork traffic, while it is optional on EKS
++				HostEncryptionEnabled: configParams.KubernetesProvider() == config.ProviderAKS ||
++					(configParams.WireguardHostEncryptionEnabled && configParams.KubernetesProvider() == config.ProviderEKS),
+ 			},
+ 			IPIPMTU:                        configParams.IpInIpMtu,
+ 			VXLANMTU:                       configParams.VXLANMTU,","I would consider extracting this logic in to a helper function to make it a bit more readable, but that's just my opinion.",Why do we check for `configParams.Provi
+4359,"@@ -252,6 +252,7 @@ type Config struct {
+ 	DebugSimulateCalcGraphHangAfter time.Duration `config:""seconds;0""`
+ 	DebugSimulateDataplaneHangAfter time.Duration `config:""seconds;0""`
+ 	DebugPanicAfter                 time.Duration `config:""seconds;0""`
++	DebugSimulateDataRace           bool          `config:""bool;false""`
+
+ 	// Configure where Felix gets its routing information.
+ 	// - workloadIPs: use workload endpoints to construct routes.","Are all fields beginning with ""Debug"" automatically `;local` ? (I guess so, but just checking.)",why do we need this?
+4360,"@@ -54,6 +54,10 @@ class EvalHook(Hook):
+                  save_best=None,
+                  rule=None,
+                  **eval_kwargs):
++        warnings.warn(
++            'DeprecationWarning: EvalHook and DistEvalHook is a deprecated, '
++            'please use ""mmcv.runner.EvalHook"" or ""mmcv.runner.DistEvalHook"" '
++            'instead')
+         if not isinstance(dataloader, DataLoader):
+             raise TypeError('dataloader must be a pytorch DataLoader, but got'
+                             f' {type(dataloader)}')","We should let this module inherits from the EvalHook supported in MMCV, and only override the `__init__` function by adding the warnings. The other functions can use those in MMCV.",Should we instead add this to `__init__` of `EvalHook`?
+4361,"@@ -267,14 +267,15 @@ public class PostgreExecutionContext extends JDBCExecutionContext implements DBC
+         }
+     }
+
+-    void setSessionRole(final DBRProgressMonitor monitor) throws DBCException {
++    private void setSessionRole(@NotNull DBRProgressMonitor monitor) throws DBCException {
+         final String roleName = getDataSource().getContainer().getConnectionConfiguration().getProviderProperty(PostgreConstants.PROP_CHOSEN_ROLE);
+         if (CommonUtils.isEmpty(roleName)) {
+             return;
+         }
+         try (JDBCSession session = openSession(monitor, DBCExecutionPurpose.UTIL, ""Set active role"")) {
+             try (JDBCStatement dbStat = session.createStatement()) {
+-                dbStat.executeUpdate(""SET ROLE "" + roleName);
++                String sql = ""SET ROLE "" + getDataSource().getSQLDialect().getQuotedIdentifier(roleName, false, true);
++                dbStat.executeUpdate(sql);
+             }
+         } catch (SQLException e) {
+             throw new DBCException(e, this);",Let's use prepared statements here instead  ,This method does not modify the database.
+4362,"@@ -2,7 +2,11 @@
+  * External dependencies
+  */
+ import { storiesOf } from '@storybook/react';
+-import Button from 'GoogleComponents/button';
++
++/**
++ * Internal dependencies
++ */
++import Button from '../assets/js/components/button';
+
+ storiesOf( 'Global', module )
+ 	.add( 'Buttons', () => {",Just leaving this in one place but thanks so much for re-organising all these imports.  ,This file was moved in `components/button.js`
+4363,"@@ -43,6 +43,7 @@
+ #endif
+
+ /* List of instrumentation functions. */
++#ifdef X86
+ #define FUNCTIONS() \
+         FUNCTION(empty) \
+         FUNCTION(empty_1arg) \","Ditto, here and below",Any reason why we're not using `ossl_unreachable()` her
+4364,"@@ -61,7 +61,7 @@ export function initDebug() {
+ 		}
+
+ 		for (const key in vnode.props) {
+-			if (key[0]==='o' && key[1]==='n' && typeof vnode.props[key]!=='function' && vnode.props[key]!=null) {
++			if (key[0]==='o' && key[1]==='n' && typeof vnode.props[key]!=='function' && vnode.props[key]!=null && typeof vnode.type!=='function') {
+ 				throw new Error(
+ 					`Component's ""${key}"" property should be a function, ` +
+ 					`but got [${typeof vnode.props[key]}] instead\n` +",Let's move the check outside the `for`-loop so that we don't have to do it for every prop. If we change it to check for `vnode.type === 'string'` we can automatically skip checking text nodes which don't have props  ,"`typeof vnode.type` always returns a string, so no need to check for `typeof`"
+4365,"@@ -19,6 +19,17 @@ class TablePlot(BokehPlot, GenericElementPlot):
+
+     height = param.Number(default=None)
+
++    finalize_hooks = param.HookList(default=[], doc=""""""
++        Optional list of hooks called when finalizing a column
++        (deprecated in favor of hooks). The hook is passed the plot
++        object and the displayed object, and other plotting handles
++        can be accessed via plot.handles."""""")
++
++    hooks = param.HookList(default=[], doc=""""""
++        Optional list of hooks called when finalizing a column.  The
++        hook is passed the plot object and the displayed object, and
++        other plotting handles can be accessed via plot.handles."""""")
++
+     width = param.Number(default=400)
+
+     style_opts = (","Seems like the docstring here should simply be ""Deprecated; use `hooks` instead."".",s/columns/columns/ to make it clear that it's a separate feature from the hoo
+4366,"@@ -62,6 +62,8 @@ public class FeedItemlistAdapter extends BaseAdapter {
+
+         if(UserPreferences.getTheme() == R.style.Theme_AntennaPod_Dark) {
+             playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_dark);
++        } else if(UserPreferences.getTheme() == R.style.Theme_AntennaPod_TrueBlack) {
++            playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_trueblack);
+         } else {
+             playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_light);
+         }","It would be nice to have an `attr` in `styles.xml` for this, so we don't need the same `if` statement in multiple places",Could you change this to elseif?
+4367,"@@ -0,0 +1,10 @@
++class CreateTeachersJoinTable < ActiveRecord::Migration
++  def change
++    create_table :teachers do |t|
++      t.belongs_to :user
++      t.belongs_to :workshop
++    end
++
++    add_index :teachers, [:user_id, :workshop_id], unique: true
++  end
++end",How about `null: false` on these two lines? Also `t.timestamps null: false`?,@jmhooper @jmhooper @ZogStriP Any thoughts on how we can do this?
+4368,"@@ -183,6 +183,12 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+       }
+       threw = false;
+     } catch (TException | UnknownHostException e) {
++      if (e.getMessage().contains(""Table/View 'HIVE_LOCKS' does not exist"")) {
++        LOG.error(""Failed to acquire locks from metastore because 'HIVE_LOCKS' doesn't exist, "" +
++            ""this probably happened when using embedded metastore or doesn't create transactional"" +
++            "" meta table. Please reconfigure and start the metastore."", e);
++      }
++
+       throw new RuntimeException(String.format(""Metastore operation failed for %s.%s"", database, tableName), e);
+
+     } catch (InterruptedException e) {","This recommendation isn't very helpful because it isn't clear what ""the metastore"" is. How about this instead: ""To fix this, use an alternative metastore"".","I think we should check whether the view is empty before trying to open the metastore. If the view is empty, we should fail."
+4369,"@@ -87,6 +87,11 @@ public class SymbolTable {
+     return desiredName + suffix;
+   }
+
++  /** Returns true if a {@code symbol} is already used. */
++  public boolean isSymbolUsed(Name symbol) {
++    return symbolTable.contains(symbol.toLowerUnderscore());
++  }
++
+   /**
+    * Returns the next numeric suffix that makes desiredName unique.
+    *","The `SymbolTable` deals only with symbols, I think we can just call this `isUsed` here.",Should we assert that `symbol.toLowerCase()` is not null before checking if it exists? Or do we always want to allow for nul
+4370,"@@ -165,7 +165,9 @@ webdriver.Builder.prototype.build = function() {
+   } else {
+     var url = this.serverUrl_;
+     var client;
+-    if (url[0] == '/') {
++    if (webdriver.http.CorsClient.isAvailable()) {
++      client = new webdriver.http.XhrClient(url);
++    } else if (url[0] == '/') {
+       var origin = window.location.origin ||
+           (window.location.protocol + '//' + window.location.host);
+       client = new webdriver.http.XhrClient(origin + url);",Please hide this behind a flag and add a setter function to the builder.,Would it be better to check for `!webdriver.http.IsConnected()`?
+4371,"@@ -339,6 +339,9 @@ class EC2VPC(GenericBaseModel):
+                 )
+                 for rt in resp[""RouteTables""]:
+                     for assoc in rt.get(""Associations"", []):
++                        # skipping Main association (accommodating recent upstream change)
++                        if assoc.get(""Main""):
++                            continue
+                         ec2_client.disassociate_route_table(
+                             AssociationId=assoc[""RouteTableAssociationId""]
+                         )","Just a side-node, no need to change it here: The term ""recent"" might be confusing at a later point in time.","Nit: Should this be called ""MainAssociation""?"
+4372,"@@ -36,7 +36,9 @@ module.exports = {
+             this.assertEqual(val1 && val1.getTime(), val2.getTime(), errorMessage, depth + 1);
+         }
+         else if (type === 'object') {
+-            for (const key of Object.keys(val1)) {
++            var keys = val1.keys !== undefined ? val1.keys() : Object.keys(val1);
++
++            for (const key of keys) {
+                 const message = errorMessage ? `${errorMessage}: ${key}` : key;
+                 this.assertEqual(val1[key], val2[key], message, depth + 1);
+             }",When can it be undefined? Wouldn't that be a bug?,why use `Object.keys` instead of `Object.keys`?
+4373,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+
+ import com.google.common.base.Predicate;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.,Is this import necessary?
+4374,"@@ -430,7 +430,7 @@ class KoalasBoxPlot(BoxPlot):
+                 ).alias(""{}_{}%"".format(colname, int(q * 100)))
+                 for q in [0.25, 0.50, 0.75]
+             ],
+-            F.mean(colname).alias(""{}_mean"".format(colname))
++            F.mean(colname).alias(""{}_mean"".format(colname)),
+         ).toPandas()
+
+         # Computes IQR and Tukey's fences","Could you remove `,' at the end?",Looks like there's some whitespace on this line
+4375,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?,I think this is a bug in the code. `assert` is
+4376,"@@ -137,11 +137,11 @@ type AccountData struct {
+ 	// is expected to have copy-by-value semantics.
+ 	Assets map[AssetIndex]AssetHolding `codec:""asset,allocbound=-""`
+
+-	// SpendingKey is the address against which signatures/multisigs/logicsigs should be checked.
++	// EffectiveAddr is the address against which signatures/multisigs/logicsigs should be checked.
+ 	// If empty, the address of the account whose AccountData this is is used.
+-	// A transaction may change an account's SpendingKey to ""re-key"" the account.
++	// A transaction may change an account's EffectiveAddr to ""re-key"" the account.
+ 	// This allows key rotation, changing the members in a multisig, etc.
+-	SpendingKey Address `codec:""spend""`
++	EffectiveAddr Address `codec:""spend""`
+ }
+
+ // AccountDetail encapsulates meaningful details about a given account, for external consumption",do you want to rename the codec tag here too?,Do we have enough tests to cover the EffectiveAddr?
+4377,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";
++  String STOP_CASTING = ""stopCasting"";
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`,These API endpoints are not supposed to be used dir
+4378,"@@ -106,6 +106,13 @@ def _auto_patch():
+     import os
+     import logging
+
++    from pyspark.sql import dataframe as df, functions as F
++    from databricks.koalas import functions
++
++    for name in functions.__all__:
++        if not hasattr(F, name):
++            setattr(F, name, getattr(functions, name))
++
+     # Attach a usage logger.
+     logger_module = os.getenv(""KOALAS_USAGE_LOGGER"", None)
+     if logger_module is not None:",Hm.. should we auto-patch? I am less sure on this yet as `percentile_approx` seems a Spark function and auto-patching it in Koalas seems a bit counterintuitive.,What's the reasoning behind `setattr` vs `delattr`?
+4379,"@@ -4,12 +4,14 @@ declare(strict_types=1);
+
+ namespace Tests\ShopBundle\Test;
+
++use Psr\Container\ContainerInterface;
+ use Shopsys\FrameworkBundle\Component\DataFixture\PersistentReferenceFacade;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
+ use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
+ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
++use Zalas\Injector\PHPUnit\TestCase\ServiceContainerTestCase;
+
+-abstract class FunctionalTestCase extends WebTestCase
++abstract class FunctionalTestCase extends WebTestCase implements ServiceContainerTestCase
+ {
+     /**
+      * @var \Symfony\Bundle\FrameworkBundle\Client",I found domain use in `AllFeedsTest::getAllFeedExportCreationData` and class AllFeedsTest is descendant of `FunctionalTestCase`. I think so we can rewrite this too..,Do we really need this abstract class? Can't we jus
+4380,"@@ -91,6 +91,13 @@ class IcebergFilesCommitter extends AbstractStreamOperator<Void>
+   private transient Table table;
+   private transient long maxCommittedCheckpointId;
+
++  // There're two cases that we restore from flink checkpoints: the first case is restoring from snapshot created by the
++  // same flink job; another case is restoring from snapshot created by another different job. For the second case, we
++  // need to maintain the old flink job's id in flink state backend to find the max-committed-checkpoint-id when
++  // traversing iceberg table's snapshots.
++  private static final ListStateDescriptor<String> JOB_ID_DESCRIPTOR = new ListStateDescriptor<>(
++      ""iceberg-flink-job-id"", BasicTypeInfo.STRING_TYPE_INFO);
++  private transient ListState<String> jobIdState;
+   // All pending checkpoints states for this function.
+   private static final ListStateDescriptor<SortedMap<Long, List<DataFile>>> STATE_DESCRIPTOR = buildStateDescriptor();
+   private transient ListState<SortedMap<Long, List<DataFile>>> checkpointsState;","I am wondering if it is better to consolidate all committer checkpoint states into a single structure, e.g. Pojo class or Avro record which are Flink supported state types for schema evolution.",`jobId` -> `jobId`
+4381,"@@ -56,9 +56,10 @@ class SignalFilter(QObject):
+         Return:
+             A partial function calling _filter_signals with a signal.
+         """"""
+-        return functools.partial(self._filter_signals, signal, tab)
++        log_signal = debug.signal_name(signal) not in self.BLACKLIST
++        return functools.partial(self._filter_signals, signal, log_signal, tab)
+
+-    def _filter_signals(self, signal, tab, *args):
++    def _filter_signals(self, signal, log_signal, tab, *args):
+         """"""Filter signals and trigger TabbedBrowser signals if needed.
+
+         Triggers signal if the original signal was sent from the _current_ tab","I assume this is a performance optimization to only check this once when creating the signal filter? While you're at it, maybe make `BLACKLIST` a set instead?",Nitpick: `args` is
+4382,"@@ -36,6 +36,18 @@ class DatabaseDriverNode {
+ 		});
+ 	}
+
++	loadExtension(path) {
++		return new Promise((resolve, reject) => {
++			this.db_.loadExtension(path, (error) => {
++				if (error) {
++					reject(error);
++					return;
++				}
++				resolve();
++			});
++		});
++	}
++
+ 	selectAll(sql, params = null) {
+ 		if (!params) params = {};
+ 		return new Promise((resolve, reject) => {",Please use async/await and try/catch,Instead of having
+4383,"@@ -1065,11 +1065,9 @@ void GenStruct(StructDef &struct_def, std::string *code_ptr) {
+       }
+     }
+   // generate object accessors if is nested_flatbuffer
++  if (field.nested_flatbuffer != nullptr) {
+   auto nested = field.attributes.Lookup(""nested_flatbuffer"");
+-  if (nested) {
+-    auto nested_qualified_name =
+-      parser_.namespaces_.back()->GetFullyQualifiedName(nested->constant);
+-    auto nested_type = parser_.structs_.Lookup(nested_qualified_name);
++	auto nested_type = nested->type.struct_def;
+     auto nested_type_name = WrapInNameSpace(*nested_type);
+     auto nestedMethodName = MakeCamel(field.name, lang_.first_camel_upper)
+       + ""As"" + nested_type_name;","Like I said, this code looks incorrect. Why is it still looking up the attribute? Why is it getting the type from `nested->type.struct_def` instead of `field.nested_flatbuffer`? Are you running `generate_code.sh`, because I think `nested->type.struct_def` would be null?",I don't think stru
+4384,"@@ -1664,6 +1664,7 @@ TEST_F(VkLayerTest, DescriptorUpdateTemplateEntryWithInlineUniformBlock) {
+         m_device_extension_names.push_back(VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME);
+     } else {
+         printf(""%s Push Descriptor Extension not supported, push descriptor cases skipped.\n"", kSkipPrefix);
++        return;
+     }
+
+     ASSERT_NO_FATAL_FAILURE(InitState(nullptr, nullptr, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT));","Actually, I'm not sure why lines 1663-1668 are here. Looks like Push descriptors aren't used in the test at all. @ziga-lunarg?","I don't understand why this is returning, can't we just skip it?"
+4385,"@@ -250,7 +250,7 @@ public class NodeJSGapicContext extends GapicContext implements NodeJSContext {
+    */
+   public List<String> fieldPropertyComment(Field field) {
+     String commentType = fieldTypeCardinalityComment(field);
+-    String fieldName = wrapIfKeywordOrBuiltIn(field.getSimpleName());
++    String fieldName = lowerUnderscoreToLowerCamel(field.getSimpleName());
+     return convertToCommentedBlock(
+         fieldComment(String.format(""@property {%s} %s"", commentType, fieldName), null, field));
+   }",Don't we still want to check it it's a keyword?,This is the only place where `wrapIfKeywordOrBuiltIn` is used.
+4386,"@@ -14,7 +14,7 @@ class AttachmentDecorator < Draper::Decorator
+         class: ""image-with-border""
+       )
+     else
+-      ""<br><table><tr><td><strong><u>#{link_text}</u></strong></td></tr></table>""
++      ""#{link_text}""
+     end
+   end
+ ",this can just me `link_text` :tomato:,Do we need the `<br>` anymore?
+4387,"@@ -2045,3 +2045,15 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+             kser = ks.from_pandas(pser)
+             expected = pser
+             self.assert_eq(kser.explode(), expected)
++
++    def test_argsort(self):
++        pser = pd.Series(np.random.rand(5), index=np.random.rand(5), name=""Koalas"")
++        kser = ks.from_pandas(pser)
++        self.assert_eq(pser.argsort().sort_index(), kser.argsort().sort_index())
++
++        # MultiIndex
++        pser.index = pd.MultiIndex.from_tuples(
++            [(""a"", ""v""), (""b"", ""w""), (""c"", ""x""), (""d"", ""y""), (""e"", ""z"")]
++        )
++        kser = ks.from_pandas(pser)
++        self.assert_eq(pser.argsort().sort_index(), kser.argsort().sort_index())",What if the Series contains null values?,It may also be worth testing that `.sort_index()` returns the sa
+4388,"@@ -177,14 +177,11 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                 {
+                     new Location
+                     {
+-                         AnalysisTarget = new List<PhysicalLocationComponent>
+-                         {
+-                             new PhysicalLocationComponent
+-                             {
+-                                 Uri = TestAnalysisTarget.CreateUriForJsonSerialization(),
+-                                 Region = region
+-                             },
+-                         }
++                        AnalysisTarget = new PhysicalLocation
++                        {
++                            Uri = TestAnalysisTarget.CreateUriForJsonSerialization(),
++                            Region = region
++                        }
+                     }
+                 },
+                 FormattedMessage = new FormattedMessage","Every place you see a change like this, it's because `PhysicalLocation` is now its own object, not an array of `PhysicalLocationComponent` objects. The `Uri` is the key into the `FileInfo` dictionary.","We don't have to do this in this PR, but it made me think we should make this test a bit more realistic."
+4389,"@@ -7,7 +7,7 @@ from mmdet.core.bbox.iou_calculators import bbox_overlaps
+ from mmdet.models import HEADS
+ from mmdet.models.dense_heads import ATSSHead
+
+-eps = 1e-12
++EPS = 1e-12
+ try:
+     import sklearn.mixture as skm
+ except ImportError:",Like in atss_head,EPS = 1e-12
+4390,"@@ -233,6 +233,16 @@ func (pool *TransactionPool) test(txgroup []transactions.SignedTxn) error {
+ 	// requires a flat MinTxnFee).
+ 	feePerByte = feePerByte * pool.feeThresholdMultiplier
+
++	// The threshold grows exponentially if there are multiple blocks
++	// pending in the pool.
++	if pool.numPendingWholeBlocks > 1 {
++		// golang has no convenient integer exponentiation, so we just
++		// do this in a loop
++		for i := 0; i < int(pool.numPendingWholeBlocks)-1; i++ {
++			feePerByte *= pool.expFeeFactor
++		}
++	}
++
+ 	for _, t := range txgroup {
+ 		feeThreshold := feePerByte * uint64(t.GetEncodedLength())
+ 		if t.Txn.Fee.Raw < feeThreshold {","nit : I think it would be better to have the multiplier being calculated along with `pool.numPendingWholeBlocks`, so that we could always multiply the feePerByte with that multiplier. Not only that it would be faster, but it would also have constant time. btw - Correct me if I'm wrong, but with this change, you're practically rolling back your previous change while making it `pool.expFeeFactor` adjustable, right ?",The `pool.numPendingWholeBlocks` is initialized in the constructor and never read in this loop.
+4391,"@@ -1,4 +1,5 @@
+ class CommentsController < ApplicationController
++  before_filter :authenticate_user!
+
+   def index
+     @commentable = find_commentable",Is there a reason we _wouldn't_ want to do this? A bit of a security hole :grimacing:,Does this need to be wrapped in a transaction?
+4392,"@@ -0,0 +1,14 @@
++package azkaban.project;
++
++import java.io.File;
++import java.io.FileInputStream;
++import java.io.FileNotFoundException;
++import org.yaml.snakeyaml.Yaml;
++
++
++public class ProjectSpecLoader {
++
++  public ProjectSpec load(File projectSpecFile) throws FileNotFoundException {
++    return new Yaml().loadAs(new FileInputStream(projectSpecFile), ProjectSpec.class);
++  }
++}",Please add a copyright notice to all new files. Is there a tool to check and auto update copyright notices?,Why not `import com.google.common.base.Charsets;`?
+4393,"@@ -132,7 +132,7 @@ class UserFormType extends AbstractType
+                     new Email(['message' => 'Please enter valid e-mail']),
+                     new UniqueEmail(['ignoredEmail' => $user !== null ? $user->getEmail() : null]),
+                 ],
+-                'label' => t('Email'),
++                'label' => t('E-mail'),
+             ]);
+
+         $builderRegisteredCustomerGroup = $builder->create('registeredCustomer', GroupType::class, [","A new translation dump should be made after this change (removing the ""Email"" message)",Why did you change this?
+4394,"@@ -9,7 +9,9 @@ function owns(node, virtualTree, role, ariaOwned) {
+ 	if (node === null) {
+ 		return false;
+ 	}
+-	var implicit = implicitNodes(role),
++	var implicit = implicitNodes(role).map(
++			implicitSelector => implicitSelector + ':not([role])'
++		),
+ 		selector = ['[role=""' + role + '""]'];
+
+ 	if (implicit) {",CI is failing saying `expected [TypeError: null is not an object (evaluating 'implicitNodes(role).map')] to equal null`.,"I think you're missing a `, not([role])`"
+4395,"@@ -572,12 +572,12 @@ describe('createRoot()', () => {
+ 			});
+
+ 			it('should avoid reapplying innerHTML when __html property of dangerouslySetInnerHTML attr remains unchanged', () => {
++				let thing;
++
+ 				class Thing extends Component {
+-					constructor(props) {
+-						super(props);
+-						props.ref(this);
+-					}
+ 					render() {
++						thing = this;
++
+ 						// eslint-disable-next-line react/no-danger
+ 						return (
+ 							<div dangerouslySetInnerHTML={{ __html: '<span>same</span>' }} />",@JoviDeCroock I replaced the refs here with simple assignments.,I think you can just do `thing = this;`
+4396,"@@ -84,7 +84,7 @@ public class TestHiveMetastore {
+   private ExecutorService executorService;
+   private TServer server;
+   private HiveMetaStore.HMSHandler baseHandler;
+-  private HiveClientPool clientPool;
++  protected HiveClientPool clientPool; // Exposed for testing.
+
+   /**
+    * Starts a TestHiveMetastore with the default connection pool size (5).",nit: Could we use VisibleForTesting annotation here?,Can we keep this private and have it be `private`?
+4397,"@@ -24,6 +24,10 @@ class PostTest < ActiveSupport::TestCase
+     post.must :save
+   end
+
++  it ""should sort 'by_unanswered'"" do
++    Post.by_unanswered.must_equal Post.joins(:topic).where(""posts_count = '1'"").order('created_at desc')
++  end
++
+   it 'posts should have an associated topic' do
+     topic = create(:topic_with_posts)
+     topic.posts[0].topic.must_equal topic",Can we create some post records to assert sort_by,I think we can skip this test altogether since the
+4398,"@@ -178,6 +178,7 @@ func New(ctx context.Context, o Options) (*Service, error) {
+ 		peerID := stream.Conn().RemotePeer()
+ 		i, err := s.handshakeService.Handle(NewStream(stream), peerID)
+ 		if err != nil {
++			_ = stream.Reset()
+ 			if err == handshake.ErrNetworkIDIncompatible {
+ 				s.logger.Warningf(""peer %s has a different network id."", peerID)
+ 			}",is this necessary?,why move this here?
+4399,"@@ -68,6 +68,8 @@ namespace Datadog.Trace.TestHelpers
+         /// </summary>
+         public int Port { get; }
+
++        public List<Func<Span, bool>> Filters { get; private set; } = new List<Func<Span, bool>>();
++
+         public IImmutableList<Span> Spans { get; private set; } = ImmutableList<Span>.Empty;
+
+         public IImmutableList<NameValueCollection> RequestHeaders { get; private set; } = ImmutableList<NameValueCollection>.Empty;",What is the purpose of this? It seems like it is used to indicate whether there is a filter on a span. But what filter? Could there eventually be multiple filters per span? Just not understanding.,"Should this just be a `List<Func<Span, bool>>`?"
+4400,"@@ -52,6 +52,13 @@ type ChaosCondition struct {
+ 	Reason string `json:""reason""`
+ }
+
++const (
++	Injecting string = ""injecting""
++	Running   string = ""running""
++	Finished  string = ""finished""
++	Paused    string = ""paused""
++)
++
+ type DesiredPhase string
+
+ const (",using a certain type instead of using string directly.,[nit] Can we call this `status` instead of `running` and `paused`?
+4401,"@@ -761,7 +761,7 @@ func TestCrConflictMergedRenameSetMtimeFile(t *testing.T) {
+ 	)
+ }
+
+-// alice and both both rename(the same file, causing a copy.),
++// alice and both both rename the same file, causing a copy.,
+ func TestCrConflictRenameSameFile(t *testing.T) {
+ 	test(t,
+ 		users(""alice"", ""bob""),","fix trailing ,",ditto about the period
+4402,"@@ -16,7 +16,7 @@
+       <% end %>
+       ... <%= t'trace.trace.ago', :time_in_words_ago => time_ago_in_words(trace.timestamp) %></span>
+       <%= link_to t('trace.trace.more'), {:controller => 'trace', :action => 'view', :display_name => trace.user.display_name, :id => trace.id}, {:title => t('trace.trace.trace_details')} %> /
+-      <%= link_to_if trace.inserted?, t('trace.trace.map'), {:controller => 'site', :action => 'index', :anchor => ""map=14/#{trace.latitude}/#{trace.longitude}""}, {:title => t('trace.trace.view_map')} %> /
++      <%= link_to_if trace.inserted?, t('trace.trace.map'), {:controller => 'site', :action => 'index', :mlat => ""#{trace.latitude}"", :mlon => ""#{trace.longitude}"", :anchor => ""map=14/#{trace.latitude}/#{trace.longitude}""}, {:title => t('trace.trace.view_map')} %> /
+       <%= link_to t('trace.trace.edit'), {:controller => 'site', :action => 'edit', :gpx => trace.id }, {:title => t('trace.trace.edit_map')} %>
+       <span class=""trace_<%= trace.visibility %>""><%= t('trace.trace.' + trace.visibility) %></span>
+       <br />",I've fixed it for this change but for future reference there's no point doing string substitution for a single value like that - it will just slow things down. Just use `:mlat => trace.latitude` etc instead.,Similar blocks of code found in 3 locations. Consider refactoring.
+4403,"@@ -10,11 +10,7 @@ namespace Ergonode\Product\Application\Model\Product\Attribute\Update;
+
+ use Symfony\Component\Validator\Constraints as Assert;
+ use Ergonode\Attribute\Application\Validator as AttributeAssert;
+-use Ergonode\Product\Application\Validator as ProductAssert;
+
+-/**
+- * @ProductAssert\ProductAttribute()
+- */
+ class UpdateAttributeValueFormModel
+ {
+     /**",The form no logger needs validation?,Why did you remove this component?
+4404,"@@ -42,7 +42,7 @@ namespace OpenTelemetry.Metrics
+             if (this.getMetrics != null)
+             {
+                 var metricsToExport = this.getMetrics(this.isDelta);
+-                if (metricsToExport != null)
++                if (metricsToExport != null && metricsToExport.Metrics.Count > 0)
+                 {
+                     Batch<MetricItem> batch = new Batch<MetricItem>(metricsToExport);
+                     this.exporter.Export(batch);","there'd be more changes in the area, when we implement ""clean-up"" of aggregators if no new updates. (i think we currently send metricitem to exporters with zero as value)",Is there a case where `metricsToExport.Metrics` will be null?
+4405,"@@ -52,7 +52,9 @@ class CollectionViewTest(BaseWebTest, unittest.TestCase):
+         self.app.put_json('/buckets/sodas',
+                           MINIMALIST_BUCKET,
+                           headers=self.headers)
+-        self.app.get(other_bucket, headers=self.headers, status=404)
++        resp = self.app.get(other_bucket, headers=self.headers, status=404)
++        self.assertIn('id', resp.json['details'])
++        self.assertIn('resource_name', resp.json['details'])
+
+     def test_create_permissions_can_be_added_on_collections(self):
+         collection = MINIMALIST_COLLECTION.copy()","Usually we only keep the assertions that are relevant to the specification (ie. the test title). For example, the test on the values of id and details is not properly relevant for the spec _collections are isolated by bucket_. I suggest that you only keep the assertions regarding `details` in dedicated tests similar to `test_unknown_collection_raises_404` from `test_views_records.py`, but for each of bucket, group, collection and record in the other `test_views_` files.",Can you also assert that the status code is 400?
+4406,"@@ -28,7 +28,7 @@ public class FieldAccessGenericParameter<T extends GenericClass<String, GenericC
+     <C extends Number> FieldAccessGenericParameter() {
+         C constructorGeneric = null;
+
+-        // access type dependant on constructor type arugments
++        // access type dependant on constructor type arguments
+         // Primary[Prefix[Name[localGeneric]]]
+         constructorGeneric = null; // Number
+     }","The test sources are ok though, you don't need to remove those changes","typo in ""recursive"""
+4407,"@@ -72,7 +72,7 @@ define(['itemHelper', 'mediaInfo', 'indicators', 'connectionManager', 'layoutMan
+         var apiClient = connectionManager.getApiClient(item.ServerId);
+
+         var options = {
+-            width: width,
++            maxWidth: width * 2,
+             type: ""Primary""
+         };
+ ","`maxWidth: width * 2,` Potentially, this will be the same as `getImageUrl`: 80px or 500px. I can't verify this - need for normal LiveTV tuner.",Is this change intentional or left-over debugging?
+4408,"@@ -161,9 +161,11 @@ public class EnginesFilter extends AbstractFilter {
+      * @return True if the given engine category fulfills the filter, false otherwise
+      */
+     public boolean filter(EngineCategoryDTO engineCategory) {
+-        return searchTerm.map(
+-                searchTerm -> engineCategory.getSubCategories().stream().anyMatch(engineSubCategory -> engineSubCategory
+-                        .getPackages().stream().anyMatch(version -> version.getVersion().contains(searchTerm))))
++        return searchTerm
++                .map(searchTerm -> engineCategory.getSubCategories().stream()
++                        .anyMatch(engineSubCategory -> engineSubCategory.getPackages().stream()
++                                .anyMatch(version -> version.getVersion().toLowerCase()
++                                        .contains(searchTerm.toLowerCase()))))
+                 .orElse(true);
+     }
+ ",Not really related to this issue but should we use fuzzy search here as well (like for apps)?,this would be easier to read with one line ```java return searchTerm.map(searchTerm -> engineCategory.getPackages().stream() .anyMatch(version -> version.getVersion().toLowerCase())) .orElse(false);
+4409,"@@ -11,10 +11,10 @@ const mdUsageStr = `Usage:
+   kbfstool md [<subcommand>] [<args>]
+
+ The possible subcommands are:
+-  dump		Dump metadata objects
+-  check		Check metadata objects and their associated blocks for errors
+-  reset		Reset a broken top-level folder
+-
++  dump	      Dump metadata objects
++  check	      Check metadata objects and their associated blocks for errors
++  reset	      Reset a broken top-level folder
++  forceQR     Append a fake quota reclamation record to the folder history
+ `
+
+ func mdMain(ctx context.Context, config libkbfs.Config, args []string) (exitStatus int) {",isn't the usual capitalization for subcommands force-qr? (don't care too much about it),Do we want this to be a flag? Or does it need to be on the command line?
+4410,"@@ -38,7 +38,7 @@ import java.lang.reflect.Proxy;
+         name = ""ProxyNonConstantType"",
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = LinkType.CUSTOM,
+-        severity = SeverityLevel.SUGGESTION,
++        severity = SeverityLevel.WARNING,
+         summary = ""Proxy instances should be created using constant types known at compile time to allow native-image ""
+                 + ""behavior to match hotspot. Methods which build proxies should take a ""
+                 + ""`Function<InvocationHandler, ? extends T>` instead of arbitrary class references. """,Do you know how many repos have hit this?,"Is this a warning or a warning? It doesn't seem actionable for users, but I'm not 100% sure."
+4411,"@@ -1,3 +1,13 @@
++<% if @filter.present? %>
++  <p><%= _(<<-TEXT
++    The data on the usage dashboard is historical in nature. This means that the number of records below may not
++    match the count shown on the usage dashboard. For example if one of your users created a plan in October and
++    then removed that plan in November, it would have been included on the usage dashboard's total for October but
++    would not appear in the list below.
++  TEXT
++  ) %></p>
++<% end %>
++
+ <div class=""table-responsive"">
+   <table class=""table table-hover"" id=""my-plans"">
+     <thead>",I'll be interested to see if our gettext rake tasks will pick up on this text to translate,Might be worth extracting this into some common partial with the `_` prefix so it can be localized.
+4412,"@@ -933,6 +933,7 @@ void LuaScriptInterface::pushInstantSpell(lua_State* L, const InstantSpell& spel
+ 	setField(L, ""mlevel"", spell.getMagicLevel());
+ 	setField(L, ""mana"", spell.getMana());
+ 	setField(L, ""manapercent"", spell.getManaPercent());
++	setField(L, ""params"", spell.getHasParam());
+
+ 	setMetatable(L, -1, ""Spell"");
+ }","I think you need to change line 928 value from 6 to 7 too, since now table will have 7 values",You should check if the spell has more than one parameter before overriding the fields. This should be done in a separate PR if you prefer.
+4413,"@@ -126,3 +126,14 @@ def test_split_into_nhot_long(seed, st):
+     assert set(f1.names) == set(fr.names)
+     f1 = f1[..., fr.names]
+     assert f1.to_list() == fr.to_list()
++
++
++def test_split_into_nhot_view():
++  f0 = dt.Frame(A=[""cat,dog,mouse"", ""mouse"", None, ""dog, cat""])
++  f1 = dt.split_into_nhot(f0[::-1, :])
++  f2 = dt.split_into_nhot(f0[3, :])
++  assert set(f1.names) == {""cat"", ""dog"", ""mouse""}
++  assert f1[:, [""cat"", ""dog"", ""mouse""]].to_list() == \
++         [[1, 0, 0, 1], [1, 0, 0, 1], [0, 0, 1, 1]]
++  assert set(f2.names) == {""cat"", ""dog""}
++  assert f2[:, [""cat"", ""dog""]].to_list() == [[1], [1]]","Does `f0[::-1, :]` mean all the rows taken in a reverse order?","A bit redundant with the `assert set(f1.names).to_list() == {""cat"", ""dog"", ""mouse""}` part."
+4414,"@@ -30,7 +30,7 @@ public class JavaProcessJobTest
+     "" By JULIE BOSMAN \n"" +
+     ""Published: August 11, 2010 \n"" +
+     "" \n"" +
+-    ""Twelve years later, it may be Joe Fox�s turn to worry. Readers have gone from skipping small \n"" +
++    ""Twelve years later, it may be Joe Fox���s turn to worry. Readers have gone from skipping small \n"" +
+     ""bookstores to wondering if they need bookstores at all. More people are ordering books online  \n"" +
+     ""or plucking them from the best-seller bin at Wal-Mart"";
+ ",Looks like there are strange characters here.,Why did this line change? Is there a specific reason for this?
+4415,"@@ -97,7 +97,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+
+ 		status.Experiment.Phase = v1alpha1.ExperimentPhaseFinished
+ 		status.FailedMessage = emptyString
+-	} else if chaos.IsPaused() {
++	} else if chaos.GetPause() != """" {
+ 		if status.Experiment.Phase == v1alpha1.ExperimentPhaseRunning {
+ 			r.Log.Info(""Pausing"")
+ ",It is better to have a check to ensure the format is valid.,"I would `if chaos.GetPause() != """" {`"
+4416,"@@ -22,14 +22,16 @@ namespace AutoRest.Go.TemplateModels
+         private readonly string lroDescription = "" This method may poll for completion. Polling can be canceled by passing the cancel channel argument. "" +
+                                                  ""The channel will be used to cancel polling and any outstanding HTTP requests."";
+
++        public readonly bool NextAlreadyDefined;
+
+-        public MethodTemplateModel(Method source, string owner, string packageName, MethodScopeProvider methodScope)
++        public MethodTemplateModel(Method source, string owner, string packageName, MethodScopeProvider methodScope, bool next)
+         {
+             this.LoadFrom(source);
+
+             MethodScope = methodScope;
+             Owner = owner;
+             PackageName = packageName;
++            NextAlreadyDefined = next;
+
+             var parameter = Parameters.Find(p => p.Type.IsPrimaryType(KnownPrimaryType.Stream)
+                                                 && !(p.Location == ParameterLocation.Body || p.Location == ParameterLocation.FormData));",How about `nextAlreadyDefined` variable name in method signature?,does this really need to be passed down to the constructor? can't we just read from the stream when we know there's nothing to read?
+4417,"@@ -459,7 +459,7 @@ func (s *clientIntegrationSuite) TestClientDataConverter_WithChild() {
+
+ 	// to ensure custom data converter is used, this number might be different if client changed.
+ 	d := dc.(*testDataConverter)
+-	s.Equal(3, d.NumOfCallToPayloads)
++	s.Equal(2, d.NumOfCallToPayloads)
+ 	s.Equal(2, d.NumOfCallFromPayloads)
+ }
+ ","In older SDK versions the data converter was called 3 times but now it is 2. This is because logic was changed deep in the interceptor chains on when values are serialized and encoded and such. Previously we invoked the data converter on results _even if there was an error_ (and most of the time they were nil). Now we don't do such a thing, resulting in fewer calls.",why change this?
+4418,"@@ -17,6 +17,7 @@ limitations under the License.
+ package main
+
+ import (
++	""github.com/google/knative-gcp/pkg/reconciler/events/build""
+ 	// The following line to load the gcp plugin (only required to authenticate against GKE clusters).
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+ ",formatting... can this import go next to the other sources ones?,this import should go with the other standard library imports
+4419,"@@ -286,10 +286,10 @@ const char *options_list_str =
+     ""       -early             Requests early injection (the default).\n""
+     ""       -late              Requests late injection.\n""
+ #        endif
+-    ""       -attach <pid>      Attach to the process with the given pid.  Pass 0\n""
+-    ""                          for pid to launch and inject into a new process.\n""
+     ""       -logdir <dir>      Logfiles will be stored in this directory.\n""
+ #    endif
++    ""       -attach <pid>      Attach to the process with the given pid.  Pass 0\n""
++    ""                          for pid to launch and inject into a new process.\n""
+     ""       -use_dll <dll>     Inject given dll instead of configured DR dll.\n""
+     ""       -force             Inject regardless of configuration.\n""
+     ""       -exit0             Return a 0 exit code instead of the app's exit code.\n""",I don't understand why anyone would pass 0? If you don't want to attach to an existing process you just wouldn't pass -attach. I would remove that sentence and make 0 an invalid argument.,This should probably be in a separate PR - it's not related to this PR but what do you think about splitting it out into a different
+4420,"@@ -77,8 +77,6 @@ void (*volatile s_current_function)(ThreadsExec &, const void *);
+ const void *volatile s_current_function_arg = nullptr;
+
+ struct Sentinel {
+-  Sentinel() {}
+-
+   ~Sentinel() {
+     if (s_thread_pool_size[0] || s_thread_pool_size[1] ||
+         s_thread_pool_size[2] || s_current_reduce_size ||",This change is responsible for #2775,looks like this is unrelated to the rest of the PR.
+4421,"@@ -88,7 +88,11 @@ namespace Datadog.Trace.Tests.RuntimeMetrics
+                 writer.PushEvents();
+
+                 statsd.Verify(
+-                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), It.IsAny<string[]>()),
++                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), new[] { ""exception_type:CustomException1"" }),
++                    Times.Never);
++
++                statsd.Verify(
++                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), new[] { ""exception_type:CustomException2"" }),
+                     Times.Never);
+             }
+         }","Should we add this to the other ""never"" verification in lines 71-73 above, too?",What about the other exception types?
+4422,"@@ -175,12 +175,12 @@ class CaiApiClientImpl(gcp.ApiClientImpl):
+             dict: Generator of datasets.
+         """"""
+
+-        resources = list(self.dao.iter_cai_assets(
++        resources = self.dao.iter_cai_assets(
+             ContentTypes.resource,
+             'google.cloud.bigquery.Dataset',
+             '//cloudresourcemanager.googleapis.com/projects/{}'.format(
+                 project_number),
+-            self.session))
++            self.session)
+
+         for dataset in resources:
+             yield dataset","Fixed this since it no longer needed to be switched from a generator to a list, this was missed when I cleaned up the dataset code in an earlier PR.",nit: unnecessary formatting change
+4423,"@@ -70,7 +70,7 @@ public class NodeOptions {
+       Capabilities caps = info.getCanonicalCapabilities();
+       builders.stream()
+           .filter(builder -> builder.score(caps) > 0)
+-          .peek(builder -> LOG.info(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
++          .peek(builder -> LOG.finest(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
+           .forEach(builder -> {
+             DriverService.Builder freePortBuilder = builder.usingAnyFreePort();
+ ",This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave.,I don't think we should be changing the log level h
+4424,"@@ -5,5 +5,17 @@ class ContributorFact < NameFact
+         .where(analysis_id: project.best_analysis_id)
+         .where.not(name_id: Position.where.not(name_id: nil).where(project_id: project.id).select(:name_id))
+     end
++
++    def first_for_name_id_and_project_id(name_id, project_id)
++      sql = <<-SQL
++        SELECT name_facts.* FROM name_facts
++          INNER JOIN projects ON projects.best_analysis_id = name_facts.analysis_id
++          WHERE ( name_facts.name_id = #{name_id.to_i} OR name_facts.name_id IN (
++            SELECT AA.preferred_name_id FROM analysis_aliases AA
++            WHERE AA.analysis_id = projects.best_analysis_id AND AA.commit_name_id = #{name_id.to_i}))
++          AND projects.id = #{project_id.to_i} AND type='ContributorFact'
++        SQL
++      ContributorFact.find_by_sql(sql).first
++    end
+   end
+ end","Can we convert this to an arel as below ContributorFact .joins(:project).where(projects: { id: project_id}) .where('name_id = ? or name_id in (?)', name_id, AnalysisAlias.select(:preferred_name_id) .joins(:project) .where(commit_name_id: name_id) )",Line is too long. [85/80]
+4425,"@@ -11,6 +11,12 @@ import (
+ type DevicesGroup struct {
+ }
+
++type CgroupParams struct {
++	initpid int
++}
++
++var cg CgroupParams
++
+ func (s *DevicesGroup) Name() string {
+ 	return ""devices""
+ }",Does this cause issues if you have lots of load on the machine? Having a global variable for this seems like a bad idea IMO.,`DeviceGroup` is now unus
+4426,"@@ -1374,7 +1374,15 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       privacyParametersBuilder.setEnabled(true);
+       privacyParametersBuilder.setEnclaveUrl(privacyUrl);
+       if (privacyPublicKeyFile() != null) {
+-        privacyParametersBuilder.setEnclavePublicKeyUsingFile(privacyPublicKeyFile());
++        try {
++          privacyParametersBuilder.setEnclavePublicKeyUsingFile(privacyPublicKeyFile());
++        } catch (final IOException e) {
++          throw new ParameterException(
++              commandLine, ""Problem with privacy-public-key-file: "" + e.getMessage(), e);
++        } catch (final IllegalArgumentException e) {
++          throw new ParameterException(
++              commandLine, ""Contents of privacy-public-key-file invalid: "" + e.getMessage(), e);
++        }
+       } else {
+         throw new ParameterException(
+             commandLine, ""Please specify Enclave public key file path to enable privacy"");",We probably don't need to print the msg with e.getMessage(). It will be printed by the logger since we are passing the exception as a parameter.,This should be `commandLi
+4427,"@@ -29,17 +29,6 @@ from molecule.verifier import testinfra
+ from molecule.verifier.lint import flake8
+
+
+-@pytest.fixture
+-def _patched_testinfra_get_tests(mocker):
+-    m = mocker.patch('molecule.verifier.testinfra.Testinfra._get_tests')
+-    m.return_value = [
+-        'foo.py',
+-        'bar.py',
+-    ]
+-
+-    return m
+-
+-
+ @pytest.fixture
+ def _verifier_section_data():
+     return {",Can we get a test with multiple directories as per the initial example?,If you remove the fixture
+4428,"@@ -317,8 +317,15 @@ def getStatusBar():
+ 	if not location:
+ 		return None
+ 	left, top, width, height = location
+-	bottom = top + height - 1
+-	obj = getDesktopObject().objectFromPoint(left, bottom)
++	x=1
++	while x<12:
++		bottom = top + height - x
++		if left<0:
++			left=0
++		obj = getDesktopObject().objectFromPoint(left, bottom)
++		if obj and obj.role == controlTypes.ROLE_STATUSBAR:
++			break
++		x=x+2
+
+ 	# We may have landed in a child of the status bar, so search the ancestry for a status bar.
+ 	while obj and not obj.role == controlTypes.ROLE_STATUSBAR:",I assume this is because you were seeing cases where left was a negative number? When?,what's the +2 for?
+4429,"@@ -11,10 +11,10 @@
+    See the README file in the top-level LAMMPS directory.
+ ------------------------------------------------------------------------- */
+
+-#include ""fix_deposit.h""
+-#include <mpi.h>
+ #include <cmath>
++#include <cstdlib>
+ #include <cstring>
++#include ""fix_deposit.h""
+ #include ""atom.h""
+ #include ""atom_vec.h""
+ #include ""molecule.h""",this is undoing recent changes for increased consistency of include file statements. please restore to the original.,@jcotela is this s
+4430,"@@ -24,12 +24,13 @@ public class BaselineErrorProneExtension {
+
+     private static final ImmutableList<String> DEFAULT_PATCH_CHECKS = ImmutableList.of(
+             // Baseline checks
++            ""LambdaMethodReference"",
++            ""OptionalOrElseMethodInvocation"",
+             ""PreferBuiltInConcurrentKeySet"",
+             ""PreferCollectionTransform"",
+             ""PreferListsPartition"",
+             ""PreferSafeLoggableExceptions"",
+             ""PreferSafeLoggingPreconditions"",
+-            ""OptionalOrElseMethodInvocation"",
+
+             // Built-in checks
+             ""ArrayEquals"",","If these are applied in order, should `LambdaMethoReference` come after `OptionalOrElseMethodInvocation`",Shouldn't we put `
+4431,"@@ -42,7 +42,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+         /// A dictionary whose keys are the strings representing the locations of scanned files
+         /// and whose values provide information about those files.
+         /// </param>
+-        void WriteFiles(IDictionary<string, IList<FileData>> fileDictionary);
++        void WriteFiles(IDictionary<string, FileData> filesDictionary);
+
+         /// <summary>
+         /// Write information about the logical locations where results were produced to",Why this rename?,why did you change
+4432,"@@ -149,7 +149,7 @@ def _patch_sysmodules():
+     try:
+         yield
+     finally:
+-        if mock_main:
++        if mock_main and sys.version_info < (3, 3):
+             sys.modules.pop(""__main__"")
+
+ ",Why do we do this check here? `sys.version_info` cannot be less than 3.3 as pylint does not support older versions. I think we should avoid popping `__main__` altogether.,Do we really want to make this change?
+4433,"@@ -199,6 +199,7 @@ def serv_cmd(codechecker_cfg, test_config):
+                        '--port',
+                        str(codechecker_cfg['viewer_port'])
+                        ])
++    # server_cmd.extend(['--verbose', 'debug'])
+
+     psql_cfg = codechecker_cfg.get('pg_db_config')
+     if psql_cfg:",This can be removed too.,Please remove this line.
+4434,"@@ -371,8 +371,11 @@ func (md *MDServerMemory) Put(ctx context.Context, rmds *RootMetadataSigned) err
+
+ 	// Consistency checks
+ 	if head != nil {
+-		err := head.MD.CheckValidSuccessorForServer(
+-			md.config.Crypto(), &rmds.MD)
++		id, err := md.config.Crypto().MakeMdID(&head.MD)
++		if err != nil {
++			return err
++		}
++		err = head.MD.CheckValidSuccessorForServer(id, &rmds.MD)
+ 		if err != nil {
+ 			return err
+ 		}","I'm a little worried about the new extra calls to `MakeMdId`, since in most local-server KBFS profiles, hashing is the biggest CPU user, and not re-using the value calculated by the client will result in even more hashing. That said, I understand why you did it this way, and I don't have a concrete suggestion on how to make it better. Just something to keep in mind; plus it might be worth comparing the test speed before and after this change to make sure it didn't slow things down too much.",Does it make sense to `MakeMdID` after
+4435,"@@ -29,9 +29,12 @@ import PreviewTable from 'GoogleComponents/preview-table';
+  */
+ import { isDataZeroForReporting, getTopPagesReportDataDefaults } from '../util';
+
+-const { __ } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class WPAnalyticsDashboardWidgetTopPagesTable extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies,Do we still need the i18n imports?
+4436,"@@ -1,6 +1,7 @@
++# -*- coding: UTF-8 -*-
+ #appModules/miranda32.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2012 NVDA Contributors
++#Copyright (C) 2006-2019 NV Access Limited, Aleksey Sadovoy, Peter Vágner, Joseph Lee, Bill Dengler
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ","Just curious, but how did you work out that Aleksey Sadovoy, Peter Vgner and Joseph Lee contributed to this file? Did you look at the repository history?",Why was this file changed?
+4437,"@@ -264,6 +264,19 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+                 _post.Reference();
+                 _post.Dispose();
+
++                // We need this walk because we call ReadStop on 2 places:
++                // 1. On the dispatch pipe UvPipeHandle after reading the correct message
++                // 2. On on accepted connections when there's back pressure
++                // Calling ReadStop makes the handle as in-active which means the loop can
++                // end while there's still valid handles around. This makes loop.Dispose throw
++                // with an EBUSY. To avoid that, we walk all of the handles and dispose them.
++                Walk(ptr =>
++                {
++                    var handle = UvMemory.FromIntPtr<UvHandle>(ptr);
++                    // handle can be null because UvMemory.FromIntPtr looks up a weak reference
++                    handle?.Dispose();
++                });
++
+                 // Ensure the Dispose operations complete in the event loop.
+                 _loop.Run();
+ ",You could call OnStopRude() directly here to do the same thing.,Why not just add a `Dispos
+4438,"@@ -643,6 +643,8 @@ func (a *WebAPI) ListUnregisteredApplications(ctx context.Context, _ *webservice
+ 		return &webservice.ListUnregisteredApplicationsResponse{}, nil
+ 	}
+
++	// TODO: Eliminate apps registered by another Piped
++	//   In case that multiple Pipeds watches the same repo, it could be happen that one Piped report App-1 as an unregistered app even though another Piped register that app.
+ 	sort.Slice(allApps, func(i, j int) bool {
+ 		return allApps[i].Path < allApps[j].Path
+ 	})","This TODO and this `sort` depend on how the UI looks like. So I think we should fix the UI before continuing on updating this web API. For example, in case the UI flow is as below, this API will receive a Piped ID and then return just ones belonging to that Piped. - User picks where they want to deploy first (select one Piped and one cloud provider) - Then API will be called to show the list of suggested apps for that Piped and cloud provider - User picks app they want to create",I think if multiple Piped
+4439,"@@ -24,6 +24,16 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	snapshotrevertHelpText = `
++Usage: mayactl snapshot revert [options]
++
++$ mayactl snapshot revert --volname <vol> --snapname <snap>
++
++This command displays status of available snapshotrevert.
++`
++)
++
+ /*type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string","This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. This command should be used cautiously and only when there is an issue with the current state of the data.","""This command displays sta"
+4440,"@@ -567,9 +567,12 @@ func TestAwslogsDriver(t *testing.T) {
+ 		})
+ 	}()
+
++	strs := strings.Split(*testTask.TaskArn, ""/"")
++	taskId := strs[len(strs)-1]
++
+ 	params := &cloudwatchlogs.GetLogEventsInput{
+ 		LogGroupName:  aws.String(awslogsLogGroupName),
+-		LogStreamName: aws.String(containerId),
++		LogStreamName: aws.String(fmt.Sprintf(""ecs-functional-tests/awslogs/%s"", taskId)),
+ 	}
+ 	resp, err := cwlClient.GetLogEvents(params)
+ 	if err != nil {",should this be a separate/new functional test?,"Nit: `taskId := strings.Split(testTask.TaskArn, ""/"")`"
+4441,"@@ -458,6 +458,19 @@ describe Mongoid::QueryCache do
+       end
+     end
+
++   context 'when querying colleciton larger than the batch size' do
++     before do
++       101.times { Band.create! }
++     end
++
++     it 'does not raise an exception when querying multiple times' do
++       expect do
++         Band.all.to_a
++         Band.all.to_a
++       end.not_to raise_error
++     end
++   end
++
+     context ""when query caching is enabled and the batch_size is set"" do
+
+       around(:each) do |example|",Can these also assert at least the length of arrays returned and ideally contents?,this should be `101.times { Band.create! }`
+4442,"@@ -822,7 +822,7 @@ class Scheduler(object):
+             task.family = family
+         if not getattr(task, 'module', None):
+             task.module = module
+-        if not task.param_visibilities:
++        if not getattr(task, 'param_visibilities', None):
+             task.param_visibilities = _get_default(param_visibilities, {})
+         if not task.params:
+             task.set_params(params)","`hasattr(task, 'param_visibilities')` is more concise with the same effect, but either one works.",Why this change? It seems unrelated to the rest of th
+4443,"@@ -364,6 +364,12 @@ MSGS = {
+         ""end up in having multiple values passed for the aforementioned parameter in ""
+         ""case the method is called with keyword arguments."",
+     ),
++    ""W1114"": (
++        ""Positional arguments are out of order"",
++        ""arguments-out-of-order"",
++        ""Attributes given to a function call have are being passed in a different order ""
++        ""to the function's definition"",
++    ),
+ }
+
+ # builtin sequence types in Python 2 and 3.","I would hedge this a little, maybe `Positional arguments appear to be out of order`. After all, it's just a guess.","For consistency with the rest of the docs, I think th"
+4444,"@@ -192,7 +192,8 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
+
+     @Override
+     public void showError() {
+-        SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in));
++        Snackbar snackbar = SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in));
++        snackbar.show();
+     }
+
+     @Override","you can directly call show() method from **SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)).show();** no need to create an extra object and then call the show method.",This `showError` method can be removed.
+4445,"@@ -306,6 +306,19 @@ StatusOr<std::vector<HostAddr>> NetworkUtils::toHosts(const std::string& peersSt
+     return hosts;
+ }
+
++std::string NetworkUtils::toHosts(const std::vector<HostAddr>& hosts) {
++    std::string hostsString = """";
++    for (auto& host : hosts) {
++        std::string addrStr = network::NetworkUtils::ipFromHostAddr(host);
++        int32_t port = network::NetworkUtils::portFromHostAddr(host);
++        hostsString += folly::stringPrintf(""%s:%d, "", addrStr.c_str(), port);
++    }
++    if (!hostsString.empty()) {
++        hostsString.resize(hostsString.size() - 2);
++    }
++    return hostsString;
++}
++
+ std::string NetworkUtils::ipFromHostAddr(const HostAddr& host) {
+     return intToIPv4(host.first);
+ }",concatHosts may be a better func name to explain this?,This should probably be `std::string &`
+4446,"@@ -0,0 +1,19 @@
++import { always } from 'ramda';
++
++/**
++ * A function that returns new empty string.
++ *
++ * @func stubString
++ * @memberOf RA
++ * @since {@link https://char0n.github.io/ramda-adjunct/2.1.0|v2.1.0}
++ * @category Function
++ * @sig ... -> ''
++ * @return {''}
++ * @example
++ *
++ * RA.stubString(); //=> ''
++ * RA.stubString(1, 2, 3); //=> ''
++ */
++const stubString = always('');
++
++export default stubString;",A function that returns empty string.,Can we add this example to the README.m
+4447,"@@ -194,7 +194,12 @@ func parsePackage(state *core.BuildState, label, dependent core.BuildLabel, subr
+ 		}
+ 	} else {
+ 		filename, dir := buildFileName(state, label.PackageName, subrepo)
+-		if filename == """" {
++		if filename != """" {
++			pkg.Filename = filename
++			if err := state.Parser.ParseFile(state, pkg, pkg.Filename); err != nil {
++				return nil, err
++			}
++		} else if packageName != """" || state.Config.FeatureFlags.RemovePleasings {
+ 			exists := core.PathExists(dir)
+ 			// Handle quite a few cases to provide more obvious error messages.
+ 			if dependent != core.OriginalTarget && exists {","If it's not the root package, or if it is the root package but we don't add the psudo :pleasings rule there, print an error.",This is the only change I'm concerned a
+4448,"@@ -17,7 +17,9 @@ import (
+ 	""strconv""
+
+ 	""github.com/go-playground/validator/v10""
++
+ 	corev1 ""k8s.io/api/core/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/util/validation""
+ )
+ ",can delete this line,nit: move down :-)
+4449,"@@ -76,6 +76,18 @@ generic_data_store::generic_data_store(generic_data_reader *reader, model *m) :
+   if (opts->has_bool(""verbose"") && opts->get_bool(""verbose"")) {
+     m_verbose = true;
+   }
++
++  if (opts->has_string(""use_tarball"")) {
++    m_dir = m_reader->get_local_file_dir();
++  }
++
++  if (m_comm->get_num_models() != 1) {
++    if (m_master) {
++      std::cerr << ""\nFATAL ERROR: data store classes currently assume there is\n""
++                << ""a single model; please ask Dave Hysom to fix!\n\n"";
++    }
++    exit(9);
++  }
+ }
+
+ void generic_data_store::get_minibatch_index_vector() {",Will it still be an issue if all the models use the same data set?,I think the error
+4450,"@@ -37,6 +37,8 @@ class WidgetsController < ApplicationController
+   def handle_xml_format
+     return unless request_format == 'xml'
+     @type = WIDGET_TYPES.select { |klass| controller_name.include?(klass) }[0]
++    @parent = @widget.send(@type)
++    fail ParamRecordNotFound unless @parent
+     render template: 'widgets/metadata'
+   end
+ end",How does this controller_name method work? Does this method grab the context of the url request? Wouldn't this always result in 'widget'?,Do not use parenth
+4451,"@@ -18,6 +18,9 @@
+  *  limitations under the License.
+  */
+
++#define FS_CHUNK_SIZE_DEBUG(op)  {flb_debug(""[%d] %s -> fs_chunks_size = %zu"", __LINE__, op->name, op->fs_chunks_size);}
++#define FS_CHUNK_SIZE_DEBUG_MOD(op, chunk, mod)  {flb_debug(""[%d] %s -> fs_chunks_size = %zu mod=%zd chunk=%s"", __LINE__, op->name, op->fs_chunks_size, mod, flb_input_chunk_get_name(chunk));}
++
+ #include <fluent-bit/flb_info.h>
+ #include <fluent-bit/flb_input.h>
+ #include <fluent-bit/flb_input_chunk.h>",Let's get rid of these for the final version and if you get rid of the macro I left last time I'd be more than grateful.,(style) line over
+4452,"@@ -36,6 +36,8 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 1, ""_file"", Types.StringType.get(), ""Path of the file in which a row is stored"");
+   public static final NestedField ROW_POSITION = NestedField.required(
+       Integer.MAX_VALUE - 2, ""_pos"", Types.LongType.get(), ""Ordinal position of a row in the source data file"");
++  public static final NestedField DELETE_MARK = NestedField.required(
++      Integer.MAX_VALUE - 3, ""_deleted"", Types.BooleanType.get(), ""Delete mark denotes whether row is deleted or not"");
+
+   // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+   public static final NestedField DELETE_FILE_PATH = NestedField.required(","Instead of `DELETE_MARK`, how about `IS_DELETED`? I don't think that ""mark"" is clear enough to describe what this is. Similarly, I think the docs should be ""Whether the row has been deleted"". There's no need to include ""delete mark"" because that's identifying something that is not defined (this column is _deleted and ""mark"" is not introduced), and ""or not"" is unnecessary because it is implied by ""whether"".","Delete mark denotes whether row is deleted or not. ""Delete mark denotes whether or not it is deleted"""
+4453,"@@ -179,6 +179,19 @@ def init_worker(checked_num, action_num):
+     progress_actions = action_num
+
+
++def get_dependent_headers(buildaction, archive):
++    LOG.debug(""Generating dependent headers via compiler..."")
++    try:
++        dependencies = set(create_dependencies(buildaction))
++    except Exception as ex:
++        LOG.debug(""Couldn't create dependencies:"")
++        LOG.debug(str(ex))
++        # TODO append with buildaction
++        archive.writestr(""no-sources"", str(ex))
++        dependencies = set()
++    return dependencies
++
++
+ def check(check_data):
+     """"""
+     Invoke clang with an action which called by processes.",Does it make sense to have this very thin wrapper that only calls `create_dependencies`? And maybe having `create_dependencies` return a set would be better than convert here?,I think it should be `debug` level.
+4454,"@@ -401,7 +401,7 @@ int h2o_get_compressible_types(const h2o_headers_t *headers)
+     return compressible_types;
+ }
+
+-h2o_iovec_t h2o_build_destination(h2o_req_t *req, const char *prefix, size_t prefix_len)
++h2o_iovec_t h2o_build_destination(h2o_req_t *req, const char *prefix, size_t prefix_len, int escape)
+ {
+     h2o_iovec_t parts[4];
+     size_t num_parts = 0;",How about renaming `escape` to `use_path_normalized` or something to better indicate that it is a selection between `path` and `path_normalized`?,"It seems like we should be calling this function with a parameter that defaults to 0 (no escape), and"
+4455,"@@ -41,4 +41,8 @@ public interface Accountable {
+     return Collections.emptyList();
+   }
+
++  /**
++   * An accountable that always returns 0
++   */
++  Accountable NULL_ACCOUNTABLE = () -> 0;
+ }",Interface members are always `static final` right?,Please annotate `@FunctionalInterface` instead of `@Deprecated`.
+4456,"@@ -0,0 +1,17 @@
++// +build nintendoswitch
++
++package runtime
++
++import (
++	""unsafe""
++)
++
++// Result svcOutputDebugString(const char *str, u64 size)
++//go:export svcOutputDebugString
++func svcOutputDebugString(str *byte, size uint64) uint64
++
++//go:export malloc
++func extalloc(size uintptr) unsafe.Pointer
++
++//export free
++func extfree(ptr unsafe.Pointer)","It seems to me that this could be in the runtime_nintendoswitch.go file, or is there a reason to keep it separate?",Why export the malloc function here?
+4457,"@@ -1857,8 +1857,6 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
+     log->PutCString(s.c_str());
+   }
+
+-  swift::performSILLinking(sil_module.get());
+-
+   if (m_swift_ast_context->HasErrors()) {
+     DiagnoseSwiftASTContextError();
+     return 1;",I was actually looking at this code over the weekend and wondering whether we were trying to link here. I assume it's been cargo culted from something else in the compiler.,Is this safe to remove?
+4458,"@@ -0,0 +1,14 @@
++<div class=""form-group"">
++  <%= f.label _('Name'), for: :name, class: ""control-label"" %>
++  <%= f.text_field :name, as: :string, class: ""form-control"", 'data-toggle': 'tooltip', title: _('Add an appropriate name for your guidance group. This name will be used to tell the end user where the guidance has come from. It will be appended to text identifying the theme e.g. ""[guidance group name]: guidance on data sharing"" so we suggest you just use the institution or department name.'), 'aria-required': true %>
++</div>
++
++<div class=""checkbox"">
++  <%= f.label :published, raw(""#{f.check_box :published, 'data-toggle': 'tooltip', title: _('Check this box when you are ready for guidance associated with this group to appear on user\'s plans.')} #{_('Published')}"") %>
++</div>
++
++<div class=""checkbox"">
++  <%= f.label :optional_subset, raw(""#{f.check_box :optional_subset, 'data-toggle': 'tooltip', title: _('If the guidance is only meant for a subset of users e.g. those in a specific college or institute, check this box.  Users will be able to select to display this subset guidance when answering questions in the \'create plan\' wizard.')} #{_('Optional Subset (e.g. School/Department)')}"") %>
++</div>
++
++<%= f.submit _('Save'), class: 'btn btn-primary' %>",nice extraction of the form for being used at new/edit. We should have more of these,I'm not sure if this is the best way
+4459,"@@ -37,8 +37,8 @@ using namespace RDKit;
+  * Version 2 taken from J. Chem. Inf. Model. 56, 1 (2016)
+  *
+  * torsion-angle potential form:
+- * V = V1*(1 + s1*cos(1x)) + V2*(1 + s2*cos(2x)) + V3*(1 + s3*cos(1x))
+- *     + V4*(1 + s4*cos(1x)) + V5*(1 + s5*cos(1x)) + V6*(1 + s6*cos(1x))
++ * V = V1*(1 + s1*cos(1x)) + V2*(1 + s2*cos(2x)) + V3*(1 + s3*cos(3x))
++ *     + V4*(1 + s4*cos(4x)) + V5*(1 + s5*cos(5x)) + V6*(1 + s6*cos(6x))
+  *
+  * format: [SMARTS, s1, V1, s2, V2, s3, V3, s4, V4, s5, V5, s6, V6]
+  */",Are the coefficients the actual bug fix?,`s1*cos(1)` and `s2*cos(2x)` are not
+4460,"@@ -218,8 +218,8 @@ class PostgresTarget(luigi.Target):
+
+         try:
+             cursor.execute(sql)
+-        except psycopg2.ProgrammingError as e:
+-            if e.pgcode == psycopg2.errorcodes.DUPLICATE_TABLE:
++        except (psycopg2.ProgrammingError, psycopg2.IntegrityError) as e:
++            if e.pgcode in [psycopg2.errorcodes.DUPLICATE_TABLE, psycopg2.errorcodes.UNIQUE_VIOLATION]:
+                 pass
+             else:
+                 raise",Why are the error code options in a list and not a tuple?,We should add `IntegrityError` to `handle_duplicated_error` in `dvc/command/__init__.py`
+4461,"@@ -135,7 +135,7 @@ class ExternalProjectAccessRuleBookTest(ForsetiTestCase):
+     TEST_ANCESTORS = [Project('123'),
+                       Folder('456'),
+                       Organization('7890')]
+-    TEST_BAD_ANC = [Project('123'),
++    TEST_BAD_ANCESTORS = [Project('123'),
+                     Folder('456'),
+                     Organization('ABC')]
+ ",Need alignment with the preceding line.,Why did you change this?
+4462,"@@ -28,10 +28,8 @@ public class MainnetProtocolSchedule {
+
+   public static final BigInteger DEFAULT_CHAIN_ID = BigInteger.ONE;
+
+-  public static ProtocolSchedule create() {
+-    return fromConfig(
+-        GenesisConfigFile.mainnet().getConfigOptions(), PrivacyParameters.DEFAULT, false);
+-  }
++  public static final ProtocolSchedule DEFAULT =
++      fromConfig(GenesisConfigFile.getMainnetConfigOptions(), PrivacyParameters.DEFAULT, false);
+
+   /**
+    * Create a Mainnet protocol schedule from a config object","Changing from a static method to a constant is inessential to Type Transactions and has a long reach, adding many unneeded files and diff lines.","don't change this please, just leave it as it was"
+4463,"@@ -92,13 +92,14 @@ public final class TreeSet<T> implements SortedSet<T>, Serializable {
+
+     public static <T extends Comparable<? super T>> TreeSet<T> ofAll(java.lang.Iterable<? extends T> values) {
+         Objects.requireNonNull(values, ""values is null"");
+-        return new TreeSet<>(RedBlackTree.ofAll(values));
++        return values.iterator().hasNext() ? new TreeSet<>(RedBlackTree.ofAll(values)) : empty();
+     }
+
++    @SuppressWarnings(""unchecked"")
+     public static <T> TreeSet<T> ofAll(Comparator<? super T> comparator, java.lang.Iterable<? extends T> values) {
+         Objects.requireNonNull(comparator, ""comparator is null"");
+         Objects.requireNonNull(values, ""values is null"");
+-        return new TreeSet<>(RedBlackTree.ofAll(comparator, values));
++        return values.iterator().hasNext() ? new TreeSet<>(RedBlackTree.ofAll(comparator, values)) : (TreeSet<T>) empty();
+     }
+
+     /**","There is one caveat: javaslang.collection.Iterator is Iterable. With Iterator it does not work. Let's revert this line. Does this happen elsewhere, too? I will double-check the code...","Would it make sense to add `@SuppressWarnings(""unchecked"")` to the `values` argument too"
+4464,"@@ -659,7 +659,7 @@ class SimpleConfig(Logger):
+             except:
+                 pass
+
+-    def format_amount(self, x, is_diff=False, whitespaces=False):
++    def format_amount(self, x, is_diff = True, whitespaces = False, add_thousands_sep = True):
+         return format_satoshis(
+             x,
+             num_zeros=self.num_zeros,",Why change the default value of `is_diff`?,Please add docstrings for args and default values
+4465,"@@ -37,7 +37,7 @@ readme_note = """"""
+ with open('README.rst') as fobj:
+     long_description = ""\n\n"" + readme_note + ""\n\n"" + fobj.read()
+
+-install_requires = ['python-dateutil>=2.7.5,<3']
++install_requires = ['python-dateutil>=2.7.5,<3', 'tenacity>=6.3.0']
+
+ # Can't use python-daemon>=2.2.0 if on windows
+ #     See https://pagure.io/python-daemon/issue/18","I think tacking on `,<7` would be a wise precaution in case of future incompatible changes in tenacity.",Do we need to pin this to <6.2.0 if we are on win
+4466,"@@ -38,7 +38,7 @@ final class NoDriverManager implements GalleryManagerInterface, MediaManagerInte
+      * @param int|null $limit
+      * @param int|null $offset
+      */
+-    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null): array
++    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
+     {
+         throw new NoDriverException();
+     }",I don't think is necessary to remove the return type,Could you update the phpdoc to include the `$crit
+4467,"@@ -128,7 +128,11 @@ public class AuthenticatorService extends Service {
+             final String userId = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_USER_ID), passcodeHash);
+             final String orgId = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_ORG_ID), passcodeHash);
+             final String username = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_USERNAME), passcodeHash);
+-            final String clientSecret = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_CLIENT_SECRET), passcodeHash);
++            final String encClientSecret = mgr.getUserData(account, AuthenticatorService.KEY_CLIENT_SECRET);
++            String clientSecret = null;
++            if (encClientSecret != null) {
++                clientSecret = ForceApp.decryptWithPasscode(encClientSecret, passcodeHash);
++            }
+             final Bundle resBundle = new Bundle();
+             try {
+                 final TokenEndpointResponse tr = OAuth2.refreshAuthToken(HttpAccess.DEFAULT, new URI(loginServer), clientId, refreshToken, clientSecret);","Also added this check, since client secret is not used except in the IP bypass scenario.",Does this need to be decrypted?
+4468,"@@ -151,6 +151,8 @@ const baseActions = {
+ 				return;
+ 			}
+
++			// Clear any profile ID selection in the case that selection falls to the getProfiles resolver.
++			registry.dispatch( STORE_NAME ).setProfileID( '' );
+ 			registry.dispatch( STORE_NAME ).setPropertyID( propertyID );
+
+ 			if ( PROPERTY_CREATE === propertyID ) {","That's unrelated, but shouldn't there also be a call to `setInternalWebPropertyID`, making it empty, for this case? Otherwise, when selecting to create a new property, any previous internal web property ID will still be in state, potentially causing problems.","I'm not sure if this is the right place for this, since it looks like `setPropertyID` will be called when the profile is selected. It seems like the right place for this would be in the `setPropertyID` function. What do you think @jridgewell ?"
+4469,"@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
+ 		out, err := system.RunCommand(DdevBin, args)
+ 		assert.NoError(err)
+ 		assert.Contains(string(out), ""Server started"")
+-		assert.Contains(string(out), ""GET"")
+
+ 		cleanup()
+ 	}",I wonder if we should trigger a PHP error and ensure it ends up in the log?,Why was this removed?
+4470,"@@ -247,6 +247,16 @@ describe TopicsController do
+     topic.closed.must_equal false
+   end
+
++  # TODO: Will need to figure out how javascript will affect the testing.
++  it 'admin can get to move_topic page' do
++    login_as admin
++    get :move_topic, id: topic.id
++    must_respond_with :success
++    must_render_template 'topics/move'
++  end
++
++  # TODO: This test is off, verify the behavior
++  # TODO: Will need to figure out how javascript will affect the testing.
+   it 'admin can move a topic' do
+     different_topic = create(:topic)
+     login_as admin",The `move_topic` action be a `post` request since it changes the state of the object.,"This test is off, because the `move_topic` action is being changed to `create`, so the user still can't move the topic."
+4471,"@@ -366,6 +366,9 @@ func doTestResults(tid int, state *core.BuildState, target *core.BuildTarget, ru
+
+ 	if runRemotely {
+ 		metadata, err = state.RemoteClient.Test(tid, target, run)
++		if metadata == nil {
++			metadata = new(core.BuildMetadata)
++		}
+ 	} else {
+ 		var stdout []byte
+ 		stdout, err = prepareAndRunTest(tid, state, target, run)",Should we just return a non-nil metadata from `Test`?,Why do you need this?
+4472,"@@ -15,6 +15,10 @@ class MailPreview < MailView
+     CommunicartMailer.comment_added_email(comment, email)
+   end
+
++  def whsc_email
++    CommunicartMailer.cart_notification_email(email, pending_approval)
++  end
++
+
+   private
+ ",Noticing this is really just the same as cart_notification_email. Would be nice to be able to view custom templates. I may update this with some set up that will make viewing specific custom emails easily.,I would call this `pending_approval_email`
+4473,"@@ -59,13 +59,8 @@ import static org.apache.solr.common.cloud.ZkStateReader.PULL_REPLICAS;
+ import static org.apache.solr.common.cloud.ZkStateReader.READ_ONLY;
+ import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR;
+ import static org.apache.solr.common.cloud.ZkStateReader.TLOG_REPLICAS;
+-import static org.apache.solr.common.params.CollectionAdminParams.ALIAS;
+-import static org.apache.solr.common.params.CollectionAdminParams.COLL_CONF;
+-import static org.apache.solr.common.params.CollectionAdminParams.COUNT_PROP;
+-import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_PARAM;
+-import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_SHUFFLE_PARAM;
+-import static org.apache.solr.common.params.CollectionAdminParams.ROUTER_PREFIX;
+-import static org.apache.solr.common.params.CollectionAdminParams.SKIP_NODE_ASSIGNMENT;
++import static org.apache.solr.common.params.CollectionAdminParams.*;
++import static org.apache.solr.common.params.CollectionAdminParams.COLOCATED_WITH;
+
+ /**
+  * This class is experimental and subject to change.",please don't use wildcard imports,please revert this. We discourage using st
+4474,"@@ -219,6 +219,8 @@ describe('Formulas general', () => {
+   });
+
+   it('should recalculate table after changing cell value (by reference)', () => {
++    let sourceDataReference = null;
++
+     const afterChange = jasmine.createSpy();
+     const hot = handsontable({
+       data: getDataSimpleExampleFormulas(),",Should we even fix this test? IMO it should be refactored to check that values are recalculated after `setSourceDataAtCell` and `setSourceDataAtRowProp` calls. This will be the correct way to alter the data since now and we're not testing this use case.,Does this line need to be outside the scop
+4475,"@@ -46,11 +46,6 @@ class ModelRole(enum.IntEnum):
+
+     item = Qt.UserRole
+
+-
+-# Remember the last used directory
+-last_used_directory = None
+-
+-
+ # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads
+ # redrawn.
+ _REFRESH_INTERVAL = 500","I'm not sure if this is standard practice, but I would prefer to leave this initialization here, if only to show that such a variable exists in this file (instead of inferring it from the globals). It can also cause weird issues if, for example, `init` isn't run before other methods.","Now that `last_used_directory` is unused, "
+4476,"@@ -353,6 +353,7 @@ RDKit::SparseIntVect<boost::uint32_t> *MorganFingerprintHelper(
+     res = RDKit::MorganFingerprints::getFingerprint(
+         mol, static_cast<unsigned int>(radius), invars, froms, useChirality,
+         useBondTypes, useCounts, false, bitInfoMap);
++          throw ""Value of nbits is Negative""
+   } else {
+     res = RDKit::MorganFingerprints::getHashedFingerprint(
+         mol, static_cast<unsigned int>(radius),",This isn't how you throw an exception in C++. I'd suggest you take a look elsewhere in the RDKit C++ codebase and see how ValueError exceptions are thrown. Hint: there's a function called `throw_value_error()` that you may find useful.,"Looks like a typo. Change to ""Value of nbits is Negative"""
+4477,"@@ -662,7 +662,7 @@ TEST (active_transactions, restart_dropped)
+ 	}
+ 	// Verify the block was updated in the ledger
+ 	{
+-		auto block (node.store.block_get (node.store.tx_begin_read (), send1->hash ()));
++		auto block (node.store.block_get (node.store.tx_begin_write (), send1->hash ()));
+ 		ASSERT_EQ (work2, block->block_work ());
+ 	}
+ 	// Drop election",Was changing this to a write transaction required?,Is it possible to distinguish between a read and a write
+4478,"@@ -21,7 +21,8 @@ type Predicate struct {
+ 	Method string `json:""method""`
+
+ 	// Params are the parameters (or a subset of the parameters) used to call the actor method.
+-	Params []byte `json:""params""`
++	// The must all be individually abi encodable.
++	Params []interface{} `json:""params""`
+ }
+
+ // PaymentVoucher is a voucher for a payment channel that can be transferred off-chain but guarantees a future payment.","nit: I think ""They""?",What about making this a `map[string]interface{}` for cla
+4479,"@@ -0,0 +1,7 @@
++namespace Nethermind.Core2
++{
++    public static class SszLimit
++    {
++        public const ulong ValidatorRegistryLimit = 1_099_511_627_776;
++    }
++}",is it a result of some multiplication or some other meaningful number? would be nice to display as a power of something or the mult,Consider calling this `ValidatorRegistryLimitUnit` for cl
+4480,"@@ -5,11 +5,11 @@ module Features
+       forum
+       office_hours
+       shows
+-      source_code
+-      video_tutorials
+     )
++    LICENSEABLE_FEATURES = %w(repositories video_tutorials)
+     FULFILLABLE_FEATURES = %w(mentor)
+-    ALL_FEATURES = GENERIC_FEATURES + FULFILLABLE_FEATURES
++    ALL_FEATURES = GENERIC_FEATURES + LICENSEABLE_FEATURES +
++      FULFILLABLE_FEATURES
+
+     def initialize(user:)
+       @user = user","I think this class is a good example of where Payload could significantly improve things. I'm okay with this class as it stands. If you merge this in, I'd like to have a go at refactoring it after introducing Payload.",Style/MutableConstant: Freeze mutable objects assigned to constants.
+4481,"@@ -2,6 +2,7 @@
+ from __future__ import unicode_literals
+ import unittest
+ import os
++import pytest
+
+ import colander
+ import mock","Just a small tip: I think you don't need to include pytest here. You can run tests using: - `pytest tests/path/to/my/test` under the virtualenv to run a single test. - `pytest tests/` under the virtualenv to run all the tests. - `make tests` to run all the tests for all python versions, like travis do. Hope this helps! :)",Do you need this?
+4482,"@@ -31,6 +31,15 @@ from .options import Store
+ from .util import unique_iterator, group_sanitizer, label_sanitizer
+
+
++def sanitizer(name, replacements={':':'_', '/':'_', '\\':'_'}):
++    """"""
++    String sanitizer to avoid problematic characters in filenames.
++    """"""
++    for k,v in replacements.items():
++        name = name.replace(k,v)
++    return name
++
++
+ class Reference(param.Parameterized):
+     """"""
+     A Reference allows access to an object to be deferred until it is",Might be worth sorting the replacement items so this is deterministic.,"are you sure you want to do `replace(':', '_')`? This will not work "
+4483,"@@ -29,6 +29,11 @@ type ChaosDashboardConfig struct {
+ 	EnableLeaderElection bool   `envconfig:""ENABLE_LEADER_ELECTION""`
+ 	Database             *DatabaseConfig
+ 	PersistTTL           *PersistTTLConfig
++	// ClusterScoped means control Chaos Object in cluster level(all namespace),
++	ClusterScoped bool `envconfig:""CLUSTER_SCOPED"" default:""true""`
++	// TargetNamespace is the target namespace to injecting chaos.
++	// It only works with ClusterScoped is false;
++	TargetNamespace string `envconfig:""TARGET_NAMESPACE"" default:""""`
+ }
+
+ // PersistTTLConfig defines the configuration of ttl",Should we set the default `TargetNamespace ` to `chaos-testing`? I noticed that the installation script defaults to chaos-testing.,"Just a thought, would it be better if these configs were called `Clu"
+4484,"@@ -31,7 +31,6 @@ namespace MvvmCross.ViewModels
+         {
+             try
+             {
+-                await Task.Yield();
+                 await task;
+             }
+             catch(Exception e)",Why was this `Task.Yield` removed? It was added in purpose.,I'm not sure what this is testing... did you mean to remove it?
+4485,"@@ -162,8 +162,13 @@ public abstract class DiscoGapicMethodConfig extends MethodConfig {
+     }
+
+     Iterable<FieldConfig> requiredFieldConfigs =
+-        DiscoGapicMethodConfig.createFieldNameConfigs(
+-            DiscoGapicMethodConfig.getRequiredFields(
++        createFieldNameConfigs(
++            diagCollector,
++            messageConfigs,
++            defaultResourceNameTreatment,
++            fieldNamePatterns,
++            resourceNameConfigs,
++            getRequiredFields(
+                 diagCollector, methodModel, methodConfigProto.getRequiredFieldsList()));
+
+     Iterable<FieldConfig> optionalFieldConfigs =","You'll also want to do this below, for the `optionalFieldConfigs`. See `GapicMethodConfig.java:180`.","if we're removing the method, shouldn't we also remove the `def"
+4486,"@@ -134,7 +134,8 @@ Status GoExecutor::prepareOver() {
+         if (clause == nullptr) {
+             LOG(FATAL) << ""Over clause shall never be null"";
+         }
+-        edge_ = ectx()->schemaManager()->toEdgeType(*clause->edge());
++        auto space = ectx()->rctx()->session()->space();
++        edge_ = ectx()->schemaManager()->toEdgeType(space, *clause->edge());
+         reversely_ = clause->isReversely();
+         if (clause->alias() != nullptr) {
+             expCtx_->addAlias(*clause->alias(), AliasKind::Edge, *clause->edge());","We'd better use ""spaceId"" as variable name here. Because i can't figure out the really type for ""space"" at the first glimpse due to ""auto"" used.",The compiler is smart enough to optimize this down to one line
+4487,"@@ -37,6 +37,7 @@ partial class Build
+     AbsolutePath ArtifactsDirectory => Artifacts ?? (OutputDirectory / ""artifacts"");
+     AbsolutePath WindowsTracerHomeZip => ArtifactsDirectory / ""windows-tracer-home.zip"";
+     AbsolutePath BuildDataDirectory => RootDirectory / ""build_data"";
++    AbsolutePath LibSqreenDirectory => RootDirectory / ""packages"" / ""libsqreen.1.1.2.2"";
+
+     AbsolutePath SourceDirectory => RootDirectory / ""src"";
+     AbsolutePath TestsDirectory => RootDirectory / ""test"";",I assume we have a package reference somewhere that pulls down the nuget package?,Shouldn't this be `LibSqreenDirectory`?
+4488,"@@ -575,12 +575,9 @@ func (s *Server) initEventTracking() {
+ 	}
+ 	s.sys.inboxPre = subject
+ 	// This is for remote updates for connection accounting.
+-
+-	for _, subj := range []string{accConnsEventSubjOld, accConnsEventSubjNew} {
+-		subject = fmt.Sprintf(subj, ""*"")
+-		if _, err := s.sysSubscribe(subject, s.remoteConnsUpdate); err != nil {
+-			s.Errorf(""Error setting up internal tracking for %s: %v"", subject, err)
+-		}
++	subject = fmt.Sprintf(accConnsEventSubjOld, ""*"")
++	if _, err := s.sysSubscribe(subject, s.remoteConnsUpdate); err != nil {
++		s.Errorf(""Error setting up internal tracking for %s: %v"", subject, err)
+ 	}
+ 	// This will be for responses for account info that we send out.
+ 	subject = fmt.Sprintf(connsRespSubj, s.info.ID)","But why introduce publish on `accConnsEventSubjNew` subject if we never subscribe on that subject. What is the plan then? Replace subscription on ""old"" with ""new"" at one point? Not sure about all that..",Why was this change made?
+4489,"@@ -269,7 +269,7 @@ void *ap6_thread(void *thread_context)
+ 	int ret;
+ 	struct timespec ts = { .tv_sec = 0, .tv_nsec = 100000 }; /* 100ms */
+
+-	fpga_token fme_token;
++	fpga_token fme_token = NULL;
+ 	fpga_handle fme_handle;
+ 	fpga_properties filter;
+ 	fpga_result res;",can we use `nullptr` for consistency?,Why not `fme_token = NULL
+4490,"@@ -38,7 +38,7 @@ class DomainRouterFactory
+     protected $routerConfiguration;
+
+     /**
+-     * @var \Symfony\Component\Routing\Router[]
++     * @var \Shopsys\FrameworkBundle\Component\Router\DomainRouter[]
+      */
+     protected $routersByDomainId = [];
+ ","strange, for templating\EngineBundle it was `\Symfony\Bundle\FrameworkBundle\`",You can use the shorthand
+4491,"@@ -1545,7 +1545,7 @@ ostree_sysroot_simple_write_deployment (OstreeSysroot      *sysroot,
+           g_ptr_array_add (new_deployments, g_object_ref (deployment));
+         }
+
+-      if (!added_new)
++      if ((!added_new) && is_merge_or_booted)
+         {
+           g_ptr_array_add (new_deployments, g_object_ref (new_deployment));
+           added_new = TRUE;","But if we're on the merge deployment, and the next one is the booted deployment, we'll still be inserting between the merge and booted deployment, right? It seems like we would need e.g. `met_merge` and `met_booted` vars to keep track.",I don't understand this c
+4492,"@@ -1,3 +1,7 @@
+-return !axe.commons.aria.isValidRole(node.getAttribute('role'), {
+-	allowAbstract: true
+-});
++return (
++	axe.utils.tokenList(virtualNode.attr('role')).filter(role => {
++		return !axe.commons.aria.isValidRole(role, {
++			allowAbstract: true
++		});
++	}).length > 0
++);","Can you put the output of this into data, and list which roles are invalid? Same thing with abstract role. I know that's not strictly part of this PR, but it'd make the messaging about this a bunch better.",Shouldn't we use `getAttribute('role')` instead of calling `tokenList`?
+4493,"@@ -20,15 +20,15 @@ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.tests.acceptance.dsl.WaitUtils;
+ import org.hyperledger.besu.tests.acceptance.dsl.condition.Condition;
+ import org.hyperledger.besu.tests.acceptance.dsl.node.Node;
+-import org.hyperledger.besu.tests.acceptance.dsl.transaction.ibft2.Ibft2Transactions;
++import org.hyperledger.besu.tests.acceptance.dsl.transaction.bft.BftTransactions;
+
+ import java.util.Map;
+
+ public class ExpectProposals implements Condition {
+-  private final Ibft2Transactions ibftTwo;
++  private final BftTransactions ibftTwo;
+   private final Map<Address, Boolean> proposers;
+
+-  public ExpectProposals(final Ibft2Transactions ibftTwo, final Map<Address, Boolean> proposers) {
++  public ExpectProposals(final BftTransactions ibftTwo, final Map<Address, Boolean> proposers) {
+     this.ibftTwo = ibftTwo;
+     this.proposers = proposers;
+   }",rename ibftTwo arg to bft,I think this should be renamed to `ExpectBftTwo` to be consistent with
+4494,"@@ -38,7 +38,7 @@ module Blacklight::SearchContext
+   end
+
+   def find_search_session
+-    if agent_is_crawler?
++    if agent_is_crawler? || skip_session_tracking?
+       nil
+     elsif params[:search_context].present?
+       find_or_initialize_search_session_from_params JSON.parse(params[:search_context])",Should we go ahead and push `agent_is_crawler?` into the `skip_session_tracking?` method?,I'm wondering if we should rename this to `find_or_initialize_search_se
+4495,"@@ -88,8 +88,11 @@ class CustomDataset(Dataset):
+                 self.proposal_file = osp.join(self.data_root,
+                                               self.proposal_file)
+         # load annotations (and proposals)
+-        with self.file_client.get_local_path(self.ann_file) as local_path:
+-            self.data_infos = self.load_annotations(local_path)
++        try:
++            with self.file_client.get_local_path(self.ann_file) as local_path:
++                self.data_infos = self.load_annotations(local_path)
++        except AttributeError:
++            raise AttributeError('Please upgrade mmcv to >= 1.3.16')
+
+         if self.proposal_file is not None:
+             with self.file_client.get_local_path(",How about we raise a warning here and simply change to use self.data_infos = self.load_annotations(self.ann_file),Need to upgrade mmcv to >= 1.3.15 too?
+4496,"@@ -1,9 +1,9 @@
+ # -*- coding: UTF-8 -*-
+-#synthDrivers/_espeak.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2007-2017 NV Access Limited, Peter Vágner
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# synthDrivers/_espeak.py
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2007-2020 NV Access Limited, Peter Vágner
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+ import time
+ import nvwave",Please remove this line to comply with the standard for copyright headers.,"I don't know if it matters, but you missed a space before the `#`"
+4497,"@@ -21,6 +21,9 @@ namespace Nethermind.Consensus.AuRa.Validators
+ {
+     internal static class AuRaValidatorsCollectionExtensions
+     {
+-        public static int MinSealersForFinalization(this IList<Address> validators) => validators.Count / 2 + 1;
++        public static int MinSealersForFinalization(this IList<Address> validators, bool twoThirds = false)
++        {
++            return (twoThirds ? validators.Count * 2 / 3 : validators.Count / 2) + 1;
++        }
+     }
+ }",seems incorrect - for 5 validators it will tell that 3 is enough to seal and you need 4 2/3 * 5 is 3.3,Is there a reason we can't just do `validators.Count / 2` directl
+4498,"@@ -19,11 +19,16 @@
+
+ package org.apache.iceberg.hive;
+
+-import java.io.Closeable;
+-import java.util.Arrays;
++
++import com.github.benmanes.caffeine.cache.Cache;
++import com.github.benmanes.caffeine.cache.Caffeine;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.Set;
++import java.util.concurrent.Executors;
++import java.util.concurrent.ScheduledExecutorService;
++import java.util.concurrent.ScheduledFuture;
++import java.util.concurrent.TimeUnit;
+ import java.util.stream.Collectors;
+ import org.apache.hadoop.conf.Configurable;
+ import org.apache.hadoop.conf.Configuration;",Nit: please remove unnecessary whitespace changes.,remove empty line
+4499,"@@ -73,9 +73,16 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
+
+     List<SampleFieldView> fields = new ArrayList<>();
+     for (FieldInfo field : methodInfo.fields().values()) {
++      String name = field.name();
++      // Since the requestBody is named `resource`, all fields named `resource`
++      // are renamed by the Node.js client library generator to `resource_`.
++      if (name.equals(""resource"")) {
++        name = ""resource_"";
++      }
++
+       fields.add(
+           SampleFieldView.newBuilder()
+-              .name(field.name())
++              .name(name)
+               .defaultValue(typeTable.getZeroValueAndSaveNicknameFor(field.type()))
+               .example(field.example())
+               .description(field.description())",Is this captured in a test?,"Why not just always set `name = ""resource_""`?"
+4500,"@@ -38,9 +38,10 @@ import org.apache.lucene.search.MaxScoreAccumulator.DocAndScore;
+  */
+ public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
+
+-  abstract static class ScorerLeafCollector implements LeafCollector {
++  /** Scorable leaf collector */
++  public abstract static class ScorerLeafCollector implements LeafCollector {
+
+-    Scorable scorer;
++    protected Scorable scorer;
+
+     @Override
+     public void setScorer(Scorable scorer) throws IOException {",This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.,Should this be `protected`?
+4501,"@@ -1,11 +1,11 @@
+ # optimizer
+ optimizer = dict(type='SGD', lr=0.02, momentum=0.9, weight_decay=0.0001)
+-optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
++optimizer_config = dict(grad_clip=None)
+ # learning policy
+ lr_config = dict(
+     policy='step',
+     warmup='linear',
+     warmup_iters=500,
+-    warmup_ratio=1.0 / 3,
++    warmup_ratio=1.0 / 1000,
+     step=[8, 11])
+ total_epochs = 12",We may also do the same for `schedule_2x.py` and `schedule_20e.py`.,should we remove the `max_n
+4502,"@@ -4,6 +4,7 @@ class User < ActiveRecord::Base
+   has_many :traces, -> { where(:visible => true) }
+   has_many :diary_entries, -> { order(:created_at => :desc) }
+   has_many :diary_comments, -> { order(:created_at => :desc) }
++  has_and_belongs_to_many :diary_entries_subscriptions, :class_name => ""DiaryEntry"", :join_table => ""diary_entries_subscribers"", :foreign_key => ""subscriber_id""
+   has_many :messages, -> { where(:to_user_visible => true).order(:sent_on => :desc).preload(:sender, :recipient) }, :foreign_key => :to_user_id
+   has_many :new_messages, -> { where(:to_user_visible => true, :message_read => false).order(:sent_on => :desc) }, :class_name => ""Message"", :foreign_key => :to_user_id
+   has_many :sent_messages, -> { where(:from_user_visible => true).order(:sent_on => :desc).preload(:sender, :recipient) }, :class_name => ""Message"", :foreign_key => :from_user_id","Should foreign key here be something like `diary_entry_id`? Or above, in `diary_entry.rb`, it should be `diary_entry_id`?",Use the new Ruby 1.9 hash s
+4503,"@@ -54,12 +54,13 @@ type (
+ 		namespaceEntry          *cache.NamespaceCacheEntry
+
+ 		// internal state
+-		hasBufferedEvents           bool
+-		failWorkflowTaskInfo        *failWorkflowTaskInfo
+-		activityNotStartedCancelled bool
+-		continueAsNewBuilder        mutableState
+-		stopProcessing              bool // should stop processing any more commands
+-		mutableState                mutableState
++		hasBufferedEvents                 bool
++		failWorkflowTaskInfo              *failWorkflowTaskInfo
++		activityNotStartedCancelled       bool
++		continueAsNewBuilder              mutableState
++		stopProcessing                    bool // should stop processing any more commands
++		mutableState                      mutableState
++		initiatedChildExecutionsInSession map[string]struct{} // Set of initiated child executions in the workflow task
+
+ 		// validation
+ 		attrValidator    *commandAttrValidator",session is a new term. Should we call more like currentCommandBatch or something else?,is this the set of initiate
+4504,"@@ -514,7 +514,7 @@ func (s *namespaceHandlerGlobalNamespaceEnabledNotMasterClusterSuite) TestUpdate
+ 	_, err := s.MetadataManager.CreateNamespace(&persistence.CreateNamespaceRequest{
+ 		Namespace: &persistenceblobs.NamespaceDetail{
+ 			Info: &persistenceblobs.NamespaceInfo{
+-				Id:          uuid.NewRandom(),
++		Id:          uuid.New(),
+ 				Name:        namespace,
+ 				Status:      namespacepb.NamespaceStatus_Registered,
+ 				Description: description,",Will go fmt before squash.,why are we changing this?
+4505,"@@ -148,6 +148,7 @@ func DefaultConfig() Config {
+ 		DockerGraphPath:         ""/var/lib/docker"",
+ 		ReservedMemory:          0,
+ 		AvailableLoggingDrivers: []dockerclient.LoggingDriver{dockerclient.JsonFileDriver},
++		PrivilegedCapable:       true,
+ 	}
+ }
+ ","Setting this to `true` means that it will always get merged in. The way merging is done here is that if a value is its zero value (`false` for `bool`), the value is considered unchanged. In order for this to work, you'll need to change this to be a `*bool` type instead.",Hmm. Is there any way we
+4506,"@@ -101,7 +101,6 @@ func newDefaultBootstrapConfig() *BootstrapConfig {
+ // MiningConfig holds all configuration options related to mining.
+ type MiningConfig struct {
+ 	MinerAddress            address.Address `json:""minerAddress""`
+-	BlockSignerAddress      address.Address `json:""blockSignerAddress""`
+ 	AutoSealIntervalSeconds uint            `json:""autoSealIntervalSeconds""`
+ 	StoragePrice            *types.AttoFIL  `json:""storagePrice""`
+ }","It was decided that blockSignerAddress is not only redundant (use the miner owner public key instead which is already stored), but does not belong in config.",why remove this?
+4507,"@@ -70,6 +70,7 @@ setup(
+         'tenacity>=5.1.1',
+         'tqdm>=4.32',
+         'requests_futures==1.0.0',
++        'jsonschema==3.*',
+     ],
+     extras_require={
+         'pyarrow': [",are we not asking for trouble here by not pinning this? or does 3.* imply all of the draft versions we'd try to validate?,I think we can remove `js
+4508,"@@ -39,10 +39,8 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
+     results1 = createAndRunNetwork(TPRegion,
+                                    ""bottomUpOut"",
+                                    checkpointMidway=False,
+-                                   temporalImp=""tm_py"")
++                                   temporalImp=""tm_cpp"")
+
+-    # temporalImp=""tm_py"" here is a temporary placeholder value until C++ TM is
+-    # finished, at which point it should be changed to ""cpp""
+     results2 = createAndRunNetwork(TPRegion,
+                                    ""bottomUpOut"",
+                                    checkpointMidway=False,","No, we want to compare `tm_py` and `tm_cpp` in this test.",why removing this?
+4509,"@@ -47,6 +47,9 @@ const (
+ 	// TODO(liu-cong) configurable timeout
+ 	decoupleSinkTimeout = 30 * time.Second
+
++	// Limit for request payload in bytes (100Mb)
++	maxRequestBodyBytes = 100000000
++
+ 	// EventArrivalTime is used to access the metadata stored on a
+ 	// CloudEvent to measure the time difference between when an event is
+ 	// received on a broker and before it is dispatched to the trigger function.",Let me know if we'd rather have this as an env variable.,Why is this defaul
+4510,"@@ -80,10 +80,10 @@ func NewVaultServiceAccount(name string) *corev1.ServiceAccount {
+ 	}
+ }
+
+-func NewVaultServiceAccountRole(namespace string) *rbacv1.ClusterRole {
++func NewVaultServiceAccountRole(namespace, serviceAccountName string) *rbacv1.ClusterRole {
+ 	return &rbacv1.ClusterRole{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: fmt.Sprintf(""auth-delegator:%s:vault"", namespace),
++			Name: fmt.Sprintf(""auth-delegator:%s:%s"", namespace, serviceAccountName),
+ 		},
+ 		Rules: []rbacv1.PolicyRule{
+ 			{",question: what is happening here?,This does not have
+4511,"@@ -14,6 +14,8 @@ public abstract class AbstractSetTest extends AbstractTraversableRangeTest {
+     @Override
+     abstract protected <T> Set<T> empty();
+
++    abstract protected <T> Set<T> emptyWithNull();
++
+     @Override
+     abstract protected <T> Set<T> of(T element);
+ ",\[Checkstyle\] ERROR: 'protected' modifier out of order with the JLS suggestions\.,Can't we use `empt
+4512,"@@ -4,6 +4,18 @@ const chai = require('chai');
+ const expect = chai.expect;
+ chai.use(require('chai-subset'));
+
++const EJSON = require('mongodb-extjson');
++const getKmsProviders = localKey => {
++  const result = EJSON.parse(process.env.CSFLE_KMS_PROVIDERS || 'NOT_PROVIDED');
++  if (localKey) {
++    result.local = { key: localKey };
++  }
++
++  return result;
++};
++
++const noop = () => {};
++
+ // Tests for the ClientEncryption type are not included as part of the YAML tests.
+
+ // In the prose tests LOCAL_MASTERKEY refers to the following base64:",Can we use EJSON from bson here? and in doing so avoid bringing in the deprecated `mongodb-extjson` lib `const { EJSON } = require('bson')`,Why do we need to set a default? Wouldn't `process.env.KMS_PROVIDED` work the same?
+4513,"@@ -262,9 +262,6 @@ class GridPlot(CompositePlot):
+     show_legend = param.Boolean(default=False, doc=""""""
+         Legends add to much clutter in a grid and are disabled by default."""""")
+
+-    tick_format = param.String(default=""%.2f"", doc=""""""
+-        Formatting string for the GridPlot ticklabels."""""")
+-
+     xaxis = param.ObjectSelector(default='bottom',
+                                  objects=['bottom', 'top', None], doc=""""""
+         Whether and where to display the xaxis, supported options are",So this parameter is now deprecated?,"No longer used, please remove it from the doc."
+4514,"@@ -269,6 +269,7 @@ rseq_shared_fragment_flushtime_update(dcontext_t *dcontext)
+     rseq_clear_tls_ptr(dcontext);
+ }
+
++#ifdef HAVE_RSEQ
+ bool
+ rseq_is_registered_for_current_thread(void)
+ {","Actually, it looks like HAVE_RSEQ is only used to determine whether the rseq.h header is around, which then only determines whether the regression test is built: it does not affect whether the core handles an application using rseq. The core rseq mangling code and all the code in rseq_linux.c is always enabled. I believe the idea is that we want DR built on one machine to work on as many others as possible, rather than requiring a custom build for every variant of kernel feature or whatnot. What is the top-level problem being solved here? If it requires disabling or enabling the core handling rseq, probably a separate option should be put in place and maybe HAVE_RSEQ renamed to make it clearer what its consequences are.",Should we ifdef this on platforms that don't have RSEQ support?
+4515,"@@ -3,8 +3,7 @@ package cache
+ import (
+ 	""sync""
+
+-	""github.com/gofrs/uuid""
+-	""github.com/spiffe/spire/pkg/common/selector""
++	""github.com/spiffe/spire/proto/spire/common""
+ )
+
+ type Subscriber interface {",I don't see a corresponding call to freeSelectorSet... am I missing something?,This file has nothing to do with the PR.
+4516,"@@ -2,13 +2,13 @@ require ""rails_helper""
+
+ describe AuthCallbacksController do
+   context '#create' do
+-    it 'redirects to the dashboard path without an auth origin' do
++    it 'redirects to the practice path without an auth origin' do
+       request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:github]
+       request.env['omniauth.origin'] = nil
+
+       get :create, provider: 'github'
+
+-      should redirect_to(dashboard_url)
++      should redirect_to(practice_url)
+     end
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I think we can remove this test altogether since it's not related to the PR
+4517,"@@ -40,9 +40,10 @@ namespace OpenTelemetry.Trace
+         public const string HttpRouteKey = ""http.route"";
+         public const string HttpFlavorKey = ""http.flavor"";
+
+-        public const string DatabaseTypeKey = ""db.type"";
+-        public const string DatabaseInstanceKey = ""db.instance"";
++        public const string DatabaseSystemKey = ""db.system"";
++        public const string DatabaseNameKey = ""db.name"";
+         public const string DatabaseStatementKey = ""db.statement"";
++        public const string DatabaseStatementTypeKey = ""db.statement_type"";
+ #pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+     }
+ }",Is this part of spec?,">public const string DatabaseNameKey = ""db.name""; [](start = 8, length = 48"
+4518,"@@ -3725,6 +3725,18 @@ client_thread_run(void)
+     byte *xsp;
+     GET_STACK_PTR(xsp);
+     void *crec = get_clone_record((reg_t)xsp);
++    /* i#2335: we support setup separate from start, and we want to allow a client
++     * to create a client thread during init, but we do not support that thread
++     * executing until the app has started (b/c we have no signal handlers in place).
++     */
++    /* i#3973: in addition to _executing_ a client thread before the
++     * app has started, if we even create the thread before
++     * dynamo_initialized is set, we will not copy tls blocks.  By
++     * waiting for the app to be started before dynamo_thread_init is
++     * called, we ensure this race condition can never happen, since
++     * dynamo_initialized will always be set before the app is started.
++     */
++    wait_for_event(dr_app_started, 0);
+     IF_DEBUG(int rc =)
+     dynamo_thread_init(get_clone_record_dstack(crec), NULL, crec, true);
+     ASSERT(rc != -1); /* this better be a new thread */","Hmm, do we need to do this for Windows too? It won't have this private loader TLS issue but it will run DR code in a separate thread before DR init is fully done which I think violates some assumptions. For Windows we would move this wait from win32/os.c to win32/callback.s intercept_new_thread where it checks whether it's a client thread right before calling dynamo_thread_init. If you do not want to deal with Windows you could bail on my suggestion and leave the issue open (or maybe file a new issue) for Windows, or if you want to put the suggested core/win32/ change in place and your new test passes on Appveyor we could then claim to have fully solved this related issue too for all platforms.","Seems like this could introduce a race condition, e.g. someone sets `dynamo"
+4519,"@@ -840,3 +840,8 @@ def kinesis_get_latest_records(stream_name, shard_id, count=10, env=None):
+         while len(result) > count:
+             result.pop(0)
+     return result
++
++
++def get_lambda_name_from_arn(arn):
++    attributes = arn.split(':')
++    return attributes[-1]",We can remove this function and use `lambda_function_name(..)` in this file instead.,Can we move this to the utils module?
+4520,"@@ -17,10 +17,12 @@
+
+ package metrics
+
+-import ""time""
++import (
++	""time""
++)
+
+-// CreateSender creates metrics sender with appropriate transport
+-func CreateSender(disableMetrics bool, metricsAddress string) *Sender {
++// NewSender creates metrics sender with appropriate transport
++func NewSender(disableMetrics bool, metricsAddress, applicationVersion string) *Sender {
+ 	var transport Transport
+ 	if disableMetrics {
+ 		transport = NewNoopTransport()",nitpick: `ApplicationVersion` could be `AppVersion`. It's smaller but gives the same understanding for purposes of the field.,receiver name should be consistent with previous receiver name e.g. `NewSender`
+4521,"@@ -537,6 +537,9 @@ func (handler *DCRedirectionHandlerImpl) PollWorkflowTaskQueue(
+ 		return err
+ 	})
+
++	if resp == nil && err == nil {
++		return &workflowservice.PollWorkflowTaskQueueResponse{}, nil
++	}
+ 	return resp, err
+ }
+ ",nit: maybe prefer `resp = &workflowservice.PollWorkflowTaskQueueResponse{}` over adding another function exit points especially for non-error cases?,shouldn't we also return nil for the error?
+4522,"@@ -107,6 +107,10 @@ module Mongoid
+     #
+     # @since 6.0.0
+     def client
++      client_options = send(:client_options)
++      if client_options[:read].is_a?(Symbol)
++        client_options = client_options.merge(read: {mode: client_options[:read]})
++      end
+       @client ||= (client = Clients.with_name(client_name)
+                     client = client.use(database_name) if database_name_option
+                     client.with(client_options))","Do we specifically need to keep the read preference as a symbol for use elsewhere? If not, I think it would be cleaner to just modify the options before caching them in the `client_options` method so that we don't do this check every time. If we do need it a a symbol elsewhere, I'd suggest either putting `return @client if @client` at the top of the method (and changing the assignment below from `||=` to `=`) or moving this within the parenthetical block in the last assignment so that we don't repeat this work.",`client_options[:read] ||= {mode: client_options[:read]}`
+4523,"@@ -69,7 +69,8 @@ module.exports = class Webcam extends Plugin {
+         'picture'
+       ],
+       mirror: true,
+-      facingMode: 'user'
++      facingMode: 'user',
++      preferredMimeType: null
+     }
+
+     // merge default options with the ones set by user","Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option.",@daniel-sousa-me What is the `preferredMimeType` for?
+4524,"@@ -398,6 +398,8 @@ static bool ImageLayoutMatches(const VkImageAspectFlags aspect_mask, VkImageLayo
+
+ // Utility type for ForRange callbacks
+ struct LayoutUseCheckAndMessage {
++    using LayoutEntry = image_layout_map::ImageSubresourceLayoutMap::LayoutEntry;
++    using RangeGenerator = image_layout_map::ImageSubresourceLayoutMap::LayoutEntry;
+     const static VkImageAspectFlags kDepthOrStencil = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT;
+     const ImageSubresourceLayoutMap *layout_map;
+     const VkImageAspectFlags aspect_mask;",That doesn't make sense. LayoutEntry doesn't match the generator concept.,I would prefer if these types were defined in `util/range_generator.h` and passed into the `RangeGenerator`.
+4525,"@@ -284,7 +284,7 @@ func TestAppDeployOpts_getAppDockerfilePath(t *testing.T) {
+
+ 	mockError := errors.New(""mockError"")
+ 	mockManifest := []byte(`name: appA
+-type: 'Load Balanced Web App'
++type: 'Load Balanced Web Svc'
+ image:
+   build: appA/Dockerfile
+ `)","I think the customer visible strings should be ""Service"" instead of ""Svc"" to make it obvious to them",Thanks for updating the test. Can you also update the test manifest to reflect the new name?
+4526,"@@ -108,13 +108,13 @@ public class JavaProcessJobTest {
+     props.put(AbstractProcessJob.WORKING_DIR, workingDir.getCanonicalPath());
+     props.put(""type"", ""java"");
+     props.put(""fullPath"", ""."");
+-
++
+     props.put(CommonJobProperties.PROJECT_NAME, ""test_project"");
+     props.put(CommonJobProperties.FLOW_ID, ""test_flow"");
+     props.put(CommonJobProperties.JOB_ID, ""test_job"");
+     props.put(CommonJobProperties.EXEC_ID, ""123"");
+     props.put(CommonJobProperties.SUBMIT_USER, ""test_user"");
+-
++    props.put(""execute.as.user"", ""false"");
+
+     job = new JavaProcessJob(""testJavaProcess"", props, props, log);
+   }",Explain why this property is necessary?,do you really need this change?
+4527,"@@ -141,7 +141,8 @@ func securityDeposit(ps *EVMParams, stateDB vm.StateDB, gasLimit *uint64) error
+ func ExecuteContracts(blk *Block, ws state.WorkingSet, bc Blockchain) {
+ 	gasLimit := GasLimit
+ 	blk.receipts = make(map[hash.Hash32B]*Receipt)
+-	for idx, execution := range blk.Executions {
++	_, _, executions := action.ClassifyActions(blk.Actions)
++	for idx, execution := range executions {
+ 		// TODO (zhi) log receipt to stateDB
+ 		if receipt, _ := executeContract(blk, ws, idx, execution, bc, &gasLimit); receipt != nil {
+ 			blk.receipts[execution.Hash()] = receipt",It should accept executions as the input,TODO: log receipt to statedb
+4528,"@@ -25,7 +25,10 @@ def single_gpu_test(model,
+         with torch.no_grad():
+             result = model(return_loss=False, rescale=True, **data)
+
++        batch_size = len(result)
+         if show or out_dir:
++            assert batch_size == 1, 'show or out during test only support ' \
++                                    'batch size of 1'
+             img_tensor = data['img'][0]
+             img_metas = data['img_metas'][0].data[0]
+             imgs = tensor2imgs(img_tensor, **img_metas[0]['img_norm_cfg'])",Is this limitation necessary?,"it would be better to use `assert batch_size == 1, 'show or out'`"
+4529,"@@ -81,9 +81,13 @@ type IssuerSpec struct {
+ }
+
+ type IssuerConfig struct {
+-	ACME  *ACMEIssuer  `json:""acme,omitempty""`
+-	CA    *CAIssuer    `json:""ca,omitempty""`
+-	Vault *VaultIssuer `json:""vault,omitempty""`
++	ACME       *ACMEIssuer       `json:""acme,omitempty""`
++	CA         *CAIssuer         `json:""ca,omitempty""`
++	Vault      *VaultIssuer      `json:""vault,omitempty""`
++	SelfSigned *SelfSignedIssuer `json:""selfSigned,omitempty""`
++}
++
++type SelfSignedIssuer struct {
+ }
+
+ type VaultIssuer struct {",:question: Should there be validation to ensure that only one of these attributes is used?,struct field SelfSignedIssuer should be SelfSignedIssuer
+4530,"@@ -33,11 +33,11 @@
+  */
+ namespace VuFind\Search\Solr;
+
++use Interop\Container\ContainerInterface;
+ use Laminas\EventManager\EventInterface;
+-
+ use Laminas\EventManager\SharedEventManagerInterface;
+-use Laminas\ServiceManager\ServiceLocatorInterface;
+-use VuFindSearch\Backend\BackendInterface;
++
++use VuFindSearch\Backend\Solr\Backend;
+
+ /**
+  * Solr merged record handling listener.","I would recommend using Psr\Container\ContainerInterface here instead of Interop\Container\ContainerInterface; both currently work, but the Interop version is deprecated and will eventually be removed, so using the Psr version will save us time in the future.",We don't use the `Interop` namespace anymore. It should be remove
+4531,"@@ -312,7 +312,7 @@ func TestLocalExec(t *testing.T) {
+ 		err = app.Exec(""web"", true, ""pwd"")
+ 		assert.NoError(err)
+ 		out := stdout()
+-		assert.Contains(out, ""/var/www/html/docroot"")
++		assert.Contains(out, ""/var/www/html"")
+
+ 		stdout = testcommon.CaptureStdOut()
+ 		switch app.GetType() {",This would also change back to /var/www/html/docroot if we go that way.,This is the only real change in this file. The rest of the change
+4532,"@@ -12,7 +12,7 @@ import info.nightscout.androidaps.MainApp;
+  */
+
+ public class SP {
+-    private static SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(MainApp.instance().getApplicationContext());
++    public static SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(MainApp.instance().getApplicationContext());
+
+     static public Map<String, ?> getAll() {
+         return sharedPreferences.getAll();","Does this need to be public? Can't one of the helper functions below pass the data? If it really needs to be public, could it be write-protected?",I don't think this change is needed
+4533,"@@ -216,11 +216,6 @@ func RunAPIAndWait(ctx context.Context, nd *node.Node, config *config.APIConfig,
+ }
+
+ func CreateServerEnv(ctx context.Context, nd *node.Node) *Env {
+-	var storageAPI *storage.API
+-	if nd.StorageProtocol != nil {
+-		storageAPI = storage.NewAPI(nd.StorageProtocol.StorageClient, nd.StorageProtocol.StorageProvider, nd.PieceManager())
+-	}
+-
+ 	return &Env{
+ 		blockMiningAPI: nd.BlockMining.BlockMiningAPI,
+ 		drandAPI:       nd.DrandAPI,","Thanks. Now that you've improved this we should just init and expose the StorageAPI on the node, like the other.s",why this is removed?
+4534,"@@ -116,6 +116,15 @@ public class Key implements Comparable<Key> {
+     return toRawKey(Arrays.copyOf(value, value.length + 1));
+   }
+
++  /**
++   * nextPrefix key will be key with next available rid.
++   *
++   * @return a new key current rid+1.
++   */
++  public Key nextPrefix() {
++    return toRawKey(prefixNext(value));
++  }
++
+   /**
+    * The prefixNext key for bytes domain
+    *",it will be better if you can provide some examples,typo: r instead of rid
+4535,"@@ -21,6 +21,8 @@ public abstract class LongRunningOperationDetailView {
+
+   public abstract String operationReturnType();
+
++  public abstract String operationResponseType();
++
+   public static Builder newBuilder() {
+     return new AutoValue_LongRunningOperationDetailView.Builder();
+   }","""return type"" and ""response type"" have never really been contrasted before, and it's unclear what their meaning is here. Could you clarify?",can we have a default implementatio
+4536,"@@ -10,6 +10,7 @@ import sys
+ import traceback
+ import subprocess
+ import shlex
++import json
+
+ # TODO: This is a cross-subpackage import!
+ from libcodechecker.log import build_action",Import order has been violated here.,"This import should be removed now, right?"
+4537,"@@ -250,11 +250,14 @@ func (api *API) MessagePreview(ctx context.Context, from, to address.Address, me
+ // it does not change any state. It is use to interrogate actor state. The from address
+ // is optional; if not provided, an address will be chosen from the node's wallet.
+ func (api *API) MessageQuery(ctx context.Context, optFrom, to address.Address, method types.MethodID, baseKey block.TipSetKey, params ...interface{}) ([][]byte, error) {
+-	snapshot, err := api.actorState.Snapshot(ctx, baseKey)
+-	if err != nil {
+-		return [][]byte{}, err
+-	}
+-	return snapshot.Query(ctx, optFrom, to, method, params...)
++	// Dragons: delete
++
++	// snapshot, err := api.actorState.Snapshot(ctx, baseKey)
++	// if err != nil {
++	// 	return [][]byte{}, err
++	// }
++	// return snapshot.Query(ctx, optFrom, to, method, params...)
++	return [][]byte{}, nil
+ }
+
+ // Snapshot returns a interface to the chain state a a particular tipset",Are you suggesting deleting the concept of message querying from plumbing (sounds like more trouble than its worth) or suggesting deleting the snapshot based implementation?,Please remove this code
+4538,"@@ -114,6 +114,9 @@ func addJoinOtherFlags(cmd *cobra.Command, joinOptions *types.JoinOptions) {
+
+ 	cmd.Flags().StringVar(&joinOptions.TarballPath, types.TarballPath, joinOptions.TarballPath,
+ 		""Use this key to set the temp directory path for KubeEdge tarball, if not exist, download it"")
++
++	cmd.Flags().StringVarP(&joinOptions.Labels, types.Labels, ""l"", joinOptions.Labels,
++		`use this key to set the customized labels for node. you can input customized labels like {""key1"":""value1"", ""key2"":""value2""}`)
+ }
+
+ // newJoinOptions returns a struct ready for being used for creating cmd join flags.","I recommend using StringSliceVarP to resolve the label flag, like `-l key1=value1,key2=value2`. What do you think?",you can input custom labels like `key1:va
+4539,"@@ -711,6 +711,18 @@ class Form extends WidgetBase
+             }
+         }
+     }
++    /**
++     * Add tab icons
++     *
++     * @param array $icons
++     * @return void
++     */
++    public function addTabIcons(array $icons)
++    {
++        $this->allTabs->primary->icons = $icons;
++        $this->allTabs->secondary->icons = $icons;
++        $this->allTabs->outside->icons = $icons;
++    }
+
+     /**
+      * Add tab fields.","@Samuell1 Will assigning the same icons array to all the tabs result in, for example, a primary tab called ""Colours"" and secondary tab called ""Colours"" having the same icon?",`addTabIcons` seems a bit confusing to me
+4540,"@@ -437,6 +437,9 @@ def initTranslation():
+ 	finally:
+ 		del callerFrame # Avoid reference problems with frames (per python docs)
+
++def getTranslatedMessage(translatedMessage):
++	return _(translatedMessage)
++
+ def _translatedManifestPaths(lang=None, forBundle=False):
+ 	if lang is None:
+ 		lang = languageHandler.getLanguage() # can't rely on default keyword arguments here.",A docstring for this function please.,"This shouldn't be necessary, as you can just add the `_` to the end of the message."
+4541,"@@ -0,0 +1,12 @@
++using System;
++using System.Collections.Generic;
++using System.Text;
++using Microsoft.AspNetCore.Hosting.Server.Features;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
++{
++    internal class ServerAddressesFeature : IServerAddressesFeature
++    {
++        public ICollection<string> Addresses { get; } = new List<string>();
++    }
++}",heads up @JunTaoLuo,You don't need to specify `ICollection` here. You can just specify `List<string>`.
+4542,"@@ -167,12 +167,12 @@ namespace NLog
+                 if (SkipAssembly(stackFrame))
+                     continue;
+
+-                if (stackFrame.GetMethod().Name == ""MoveNext"")
++                if (stackFrame.GetMethod()?.Name == ""MoveNext"")
+                 {
+                     if (stackFrames.Length > i)
+                     {
+                         var nextStackFrame = stackFrames[i + 1];
+-                        var declaringType = nextStackFrame.GetMethod().DeclaringType;
++                        var declaringType = nextStackFrame.GetMethod()?.DeclaringType;
+                         if (declaringType == typeof(System.Runtime.CompilerServices.AsyncTaskMethodBuilder) ||
+                             declaringType == typeof(System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>))
+                         {",".GetMethod() cannot return null now, correct?",Why do we need this change?
+4543,"@@ -11,7 +11,7 @@ define(['events', 'playbackManager', 'dom', 'browser', 'css!./iconosd', 'materia
+     function getOsdElementHtml() {
+         var html = '';
+
+-        html += '<i class=""material-icons iconOsdIcon volume_up""></i>';
++        html += '<i class=""material-icons iconOsdIcon""></i>';
+
+         html += '<div class=""iconOsdProgressOuter""><div class=""iconOsdProgressInner""></div></div>';
+ ","Same thing here, I think the proper fix is elsewhere.",It would be nice to remove volume_up from this HTML element if possible.
+4544,"@@ -585,6 +585,17 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
+                    openType //
+                    );
+
++                if ((retcode < 0) &&
++                    ((errno == ENOENT) || (errno == EAGAIN)))
++                  {
++                    ComDiagsArea * diagsArea = NULL;
++                    ExRaiseSqlError(getHeap(), &diagsArea,
++                                    (ExeErrorCode)(EXE_HIVE_DATA_MOD_CHECK_ERROR));
++                    pentry_down->setDiagsArea(diagsArea);
++                    step_ = HANDLE_ERROR_AND_DONE;
++                    break;
++                  }
++
+                 // preopen next range.
+                 if ( (currRangeNum_ + 1) < (beginRangeNum_ + numRanges_) )
+                   {","errno is a global variable that might be set by any system library call. It is dangerous to rely on it except right after the system call where it is set. But in this code, it looks like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the latter function saved errno after whatever system library call it calls, and returns that as an ""out"" parameter, which this code could then check.","Shouldn't we check for other errors here, like `ENOENT`?"
+4545,"@@ -50,7 +50,8 @@ class PackageNode(object):
+     def __repr__(self):
+         finfo = self._package.get_path()[:-len(PackageStore.PACKAGE_FILE_EXT)]
+         pinfo = self._prefix
+-        return ""<%s %r %r>"" % (self.__class__.__name__, finfo, pinfo)
++        kinfo = '\n'.join(self._keys()) if hasattr(self, '_keys') else ''
++        return ""<%s %r:%r>\n%s"" % (self.__class__.__name__, finfo, pinfo, kinfo)
+
+
+ class GroupNode(PackageNode):",`hasattr` is kinda terrible; just append extra info in the subclass.,Perhaps it would be more readable if we used `str(self)`
+4546,"@@ -75,6 +75,16 @@ DAY = HOUR * 24
+ WEEK = DAY * 7
+ MONTH = DAY * 31
+ YEAR = DAY * 365
++
++# Set a flag to indicate whether the '%l' option can be used safely.
++# On Windows, in particular the %l option in strftime is not supported.
++#(It is not one of the documented Python formatters).
++try:
++    datetime.now().strftime(""%a %l%p"")
++    percent_l_supported = True
++except ValueError, e:
++    percent_l_supported = False
++
+ xAxisConfigs = (
+   dict(seconds=0.00,  minorGridUnit=SEC,  minorGridStep=5,  majorGridUnit=MIN,  majorGridStep=1,  labelUnit=SEC,  labelStep=5,  format=""%H:%M:%S"", maxInterval=10*MIN),
+   dict(seconds=0.07,  minorGridUnit=SEC,  minorGridStep=10, majorGridUnit=MIN,  majorGridStep=1,  labelUnit=SEC,  labelStep=10, format=""%H:%M:%S"", maxInterval=20*MIN),","Fair warning, the way that exception block is written won't work in python3 Python 3.2.3 (default, Jun 8 2012, 05:36:09) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type ""help"", ""copyright"", ""credits"" or ""license"" for more information. > > > try: > > > ... raise ValueError(""foo"") > > > ... except ValueError,e: > > > File ""<stdin>"", line 3 > > > except ValueError, e: > > > ^ > > > SyntaxError: invalid syntax","I think this should be `False` as well, since it's the d"
+4547,"@@ -43,12 +43,15 @@ module Beaker
+         end
+         port = container.json[""NetworkSettings""][""Ports""][""22/tcp""][0][""HostPort""]
+
++        forward_ssh_agent = @options['forward_ssh_agent'] || false
++
+         # Update host metadata
+         host['ip']  = ip
+         host['port'] = port
+         host['ssh']  = {
+           :password => root_password,
+           :port => port,
++          :forward_agent => forward_ssh_agent,
+         }
+
+         @logger.debug(""node available as  ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@#{ip} -p #{port}"")",This only updates the metadata and not the actual thing you are trying to solve for the docker hypervisor.,Use the new Ruby 1.9 hash syntax.
+4548,"@@ -0,0 +1,18 @@
++// Copyright The OpenTelemetry Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
++/*
++Package debug provides access to enable internal debugging of opentelemetry.
++*/
++package debug // import ""go.opentelemetry.io/otel/internal/debug""",should this package be internal? don't we want to use it e.g. in go-contrib?,Could you add a doc string about what this is?
+4549,"@@ -31,7 +31,7 @@ import (
+ //
+ // A Document can be represented as a map[string]int or a pointer to a struct. For
+ // structs, the exported fields are the document fields.
+-type Document = interface{}
++type Document interface{}
+
+ // A Collection is a set of documents.
+ // TODO(jba): make the docstring look more like blob.Bucket.","Just curious, why did you make this change?",Was this intentional?
+4550,"@@ -1576,6 +1576,8 @@ def get_dummies(
+             ""Length of 'prefix' ({}) did not match the length of ""
+             ""the columns being encoded ({})."".format(len(prefix), len(column_labels))
+         )
++    elif isinstance(prefix, dict):
++        prefix = [prefix[column_label[0]] for column_label in column_labels]
+
+     all_values = _reduce_spark_multi(
+         kdf._sdf, [F.collect_set(kdf._internal.spark_column_for(label)) for label in column_labels]","Can you handle error cases such as `pd.get_dummies(pdf, prefix={""A"": ""foo""})`?",can you also handle `len(prefix)==1` cases in
+4551,"@@ -166,8 +166,12 @@ func (agent *TestAgent) StartAgent() error {
+ 		Links: agent.Options.ContainerLinks,
+ 	}
+
++	if os.Getenv(""ECS_FTEST_FORCE_NET_HOST"") != """" {
++		hostConfig.NetworkMode = ""host""
++	}
++
+ 	if agent.Options != nil {
+-		// Override the default docker envrionment variable
++		// Override the default docker environment variable
+ 		for key, value := range agent.Options.ExtraEnvironment {
+ 			envVarExists := false
+ 			for i, str := range dockerConfig.Env {",Where is this environment variable being set?,Why is this needed?
+4552,"@@ -22,9 +22,7 @@ class Registry(object):
+             module (:obj:`nn.Module`): Module to be registered.
+         """"""
+         if not issubclass(module_class, nn.Module):
+-            raise TypeError(
+-                'module must be a child of nn.Module, but got {}'.format(
+-                    type(module_class)))
++            raise TypeError(f'module must be a child of nn.Module, but got {module_class}')
+         module_name = module_class.__name__
+         if module_name in self._module_dict:
+             raise KeyError('{} is already registered in {}'.format(",`module_class ` is already a class and `type(module_class)` always returns `<class 'type'>`,Please use `{module_class.__name__}` in the format string instead.
+4553,"@@ -110,6 +110,17 @@ class SparkFileWriterFactory extends BaseFileWriterFactory<InternalRow> {
+     builder.createWriterFunc(SparkOrcWriter::new);
+   }
+
++  @Override
++  protected void configureEqualityDelete(ORC.DeleteWriteBuilder builder) {
++    builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema, typDesc));
++  }
++
++  @Override
++  protected void configurePositionDelete(ORC.DeleteWriteBuilder builder) {
++    builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema, typDesc));
++    builder.transformPaths(path -> UTF8String.fromString(path.toString()));
++  }
++
+   private StructType dataSparkType() {
+     if (dataSparkType == null) {
+       Preconditions.checkNotNull(dataSchema(), ""Data schema must not be null"");",Nit: The lambda can be replaced with a method reference: `SparkOrcWriter::new` I think.,Is there a way to make ORC more readable? Maybe `ORC.DeleteWriteBu
+4554,"@@ -1265,6 +1265,13 @@ def is_number(obj):
+     else: return False
+
+
++def is_int(obj, int_like=False):
++    real_int = isinstance(obj, int) or getattr(getattr(obj, 'dtype', None), 'kind', 'o') in 'ui'
++    if real_int or (int_like and hasattr(obj, 'is_integer') and obj.is_integer()):
++        return True
++    return False
++
++
+ class ProgressIndicator(param.Parameterized):
+     """"""
+     Baseclass for any ProgressIndicator that indicates progress","It would be nice to have a docstring that says what range of integer-like objects will be accepted, as well as what the int_like argument is meant for.","better to use `isinstance(obj, [int, float])`"
+4555,"@@ -0,0 +1,5 @@
++class CreateLicensesView < ActiveRecord::Migration
++  def change
++    create_view :licenses
++  end
++end",How do we manage updates to this view down the road?,Final newline missing.
+4556,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,no need for this change
+4557,"@@ -1174,8 +1174,11 @@ public abstract class BasePointsFormatTestCase extends BaseIndexFileFormatTestCa
+
+     Document doc = new Document();
+     doc.add(new IntPoint(""id"", 0));
+-    w.addDocument(doc);
+-    // now we write another segment where the id field does have points:
++    IllegalArgumentException ex =
++        expectThrows(IllegalArgumentException.class, () -> w.addDocument(doc));
++    assertEquals(
++        ""cannot change field \""id\"" from index options=DOCS to inconsistent index options=NONE"",
++        ex.getMessage());
+
+     w.forceMerge(1);
+     IOUtils.close(w, dir);","I think we should refactor or drop this test, as it is not testing the points format now, but IndexingChain/FieldsInfos' logic. Maybe we could rename the test `testMergeMissing` and configure the first segment to not have the `id` field at all.","This should be ""cannot "
+4558,"@@ -6,15 +6,6 @@ module RSpec
+       # @private
+       # Produces progress output while bisecting.
+       class BisectProgressFormatter < BaseTextFormatter
+-        # We've named all events with a `bisect_` prefix to prevent naming collisions.
+-        Formatters.register self, :bisect_starting, :bisect_original_run_complete,
+-                            :bisect_round_started, :bisect_individual_run_complete,
+-                            :bisect_complete, :bisect_repro_command,
+-                            :bisect_failed, :bisect_aborted,
+-                            :bisect_round_ignoring_ids, :bisect_round_detected_multiple_culprits,
+-                            :bisect_dependency_check_started, :bisect_dependency_check_passed,
+-                            :bisect_dependency_check_failed
+-
+         def bisect_starting(notification)
+           @round_count = 0
+           options = notification.original_cli_args.join(' ')",not sure I follow why all this goes away?,This was removed becaus
+4559,"@@ -46,7 +46,7 @@ def test_insert_mode(file_name, source, input_text, auto_insert, quteproc):
+         quteproc.press_keys(input_text)
+     elif source == 'clipboard':
+         quteproc.send_cmd(':debug-set-fake-clipboard ""{}""'.format(input_text))
+-        quteproc.send_cmd(':paste-primary')
++        quteproc.send_cmd(':insert-text {clipboard}')
+
+     quteproc.send_cmd(':hint all')
+     quteproc.send_cmd(':follow-hint a')","Is this `{clipboard}` or `{primary}`, as the deprecation message for `:paste-primary` says?",@DaanHoogland do you kn
+4560,"@@ -46,6 +46,18 @@ var (
+ 		Usage: ""OpenVPN subnet netmask"",
+ 		Value: ""255.255.255.0"",
+ 	}
++	// FlagOpenVPNPriceMinute sets the price per minute for provided OpenVPN service.
++	FlagOpenVPNPriceMinute = cli.Uint64Flag{
++		Name:  ""openvpn.price-minute"",
++		Usage: ""Sets the price of the OpenVPN service per minute."",
++		Value: 50000,
++	}
++	// FlagOpenVPNPriceGB sets the price per GiB for provided OpenVPN service.
++	FlagOpenVPNPriceGB = cli.Uint64Flag{
++		Name:  ""openvpn.price-gb"",
++		Usage: ""Sets the price of the OpenVPN service per minute."",
++		Value: 7000000,
++	}
+ )
+
+ // RegisterFlagsServiceOpenvpn registers OpenVPN CLI flags for parsing them later","Human unreadable. IMHO user should input MYST value: 0.0006 @chompomonim, opinions?",Can we rename this to `openvpn.price-min` to match the other flags?
+4561,"@@ -643,15 +643,6 @@ class NVDAObject(documentBase.TextContainerObject,baseObject.ScriptableObject):
+ 				return self.presType_layout
+ 			if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN,controlTypes.ROLE_TABLECELL) and (not config.conf[""documentFormatting""][""reportTables""] or not config.conf[""documentFormatting""][""reportTableCellCoords""]):
+ 				return self.presType_layout
+-		if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN):
+-			try:
+-				table=self.table
+-			except NotImplementedError:
+-				table=None
+-			if table:
+-				# This is part of a real table, so the cells will report row/column information.
+-				# Therefore, this object is just for layout.
+-				return self.presType_layout
+ 		return self.presType_content
+
+ 	def _get_simpleParent(self):","May be you could elaborate on why you removed this? I see some of this logic has been moved to ia2Web, but couldn't there be cases outside ia2Web (i.e. UIA) in which case ROLE_TABLEROW and ROLE_TABLECOLUMN are mapped to objects, in which case these objects will be of presentation type content erroneously?",Do we need to keep this code? It looks like it was only used in tes
+4562,"@@ -2637,10 +2637,10 @@ void Game::playerAcceptTrade(uint32_t playerId)
+ 	player->setTradeState(TRADE_ACCEPT);
+
+ 	if (tradePartner->getTradeState() == TRADE_ACCEPT) {
+-		Item* tradeItem1 = player->tradeItem;
+-		Item* tradeItem2 = tradePartner->tradeItem;
++		Item* playerTradeItem = player->tradeItem;
++		Item* tradePartnerItem = tradePartner->tradeItem;
+
+-		if (!g_events->eventPlayerOnTradeAccept(player, tradePartner, tradeItem1, tradeItem2)) {
++		if (!g_events->eventPlayerOnTradeAccept(player, tradePartner, playerTradeItem, tradePartnerItem)) {
+ 			internalCloseTrade(player);
+ 			return;
+ 		}",This is not consistent. Either rename the first to `tradePlayerItem` (which is ugly) or the second to `partnerTradeItem` (:+1:),Please make `playerTradeItem` and `tradeItem` const.
+4563,"@@ -50,6 +50,7 @@ func deps() {
+ 		""go get -u github.com/alecthomas/gometalinter"",
+ 		""gometalinter --install"",
+ 		""go get -u github.com/stretchr/testify"",
++		""go get -u github.com/xeipuuv/gojsonschema"",
+ 	}
+
+ 	for _, name := range list {",is there a reason we don't want to gx this dependency?,I assume this doesn't need to be in the CI?
+4564,"@@ -26,6 +26,18 @@
+
+ require_once(""../inc/util.inc"");
+
++// strip leading AMD or NVIDIA
++//
++function strip_vendor($model) {
++    foreach (array(""AMD "", ""NVIDIA "") as $maker) {
++        $n = strlen($maker);
++        if (substr($model, 0, $n) == $maker) {
++            return substr($model, $n);
++        }
++    }
++    return $model;
++}
++
+ // take a host.serialnum field (which may encode several GPUs)
+ // and extract the model name for the given vendor
+ //","I'd suggest to add ""ATI "" and ""Intel(R) "" to this list",You can use `str_contains()` here instead.
+4565,"@@ -127,8 +127,8 @@ class Status extends ReportWidgetBase
+             }
+         }
+
+-        foreach ($missingPlugins as $pluginCode) {
+-            $warnings[] = Lang::get('backend::lang.warnings.plugin_missing', ['name' => '<strong>'.$pluginCode.'</strong>']);
++        foreach ($missingPlugins as $plugin) {
++            $warnings[] = Lang::get('backend::lang.warnings.plugin_missing', ['name' => '<strong>'.$plugin['code'].'</strong>']);
+         }
+
+         return $warnings;","This is using a different lang key, we should switch it to using the new key and remove the old key if it is no longer used.",Will this break if `$plugin['code']` is em
+4566,"@@ -76,8 +76,9 @@ type SpecHandler interface {
+ }
+
+ var (
+-	nameRegex       = regexp.MustCompile(api.Name + ""=([0-9A-Za-z_-]+),?"")
+-	nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=([0-9A-Za-z_-]+),?"")
++	nameRegex = regexp.MustCompile(api.Name + ""=([0-9A-Za-z_-]+),?"")
++	//nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=([0-9A-Za-z_-]+),*"")
++	nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=('[0-9A-Za-z,_-]+'),*|"" + api.SpecNodes + ""=([0-9A-Za-z_-]+),*"")
+ 	parentRegex     = regexp.MustCompile(api.SpecParent + ""=([A-Za-z]+),?"")
+ 	sizeRegex       = regexp.MustCompile(api.SpecSize + ""=([0-9A-Za-z]+),?"")
+ 	scaleRegex      = regexp.MustCompile(api.SpecScale + ""=([0-9]+),?"")","shouldn't this work? nodesRegex = regexp.MustCompile(api.SpecNodes + ""=(('[0-9A-Za-z,_-]+')|([0-9A-Za-z_-]+)),?"")",@deads2k @liggitt which of these changes f
+4567,"@@ -1,5 +1,6 @@
+ class Account::Encrypter
+-  def before_create(account)
++  def before_validation(account)
++    return unless account.new_record?
+     assign_activation_code_to_random_hash(account)
+     encrypt_salt(account)
+   end","You mentioned this change was prompted because the `before_create` action was actually a defect. This will be done only for a new record; why is `before_validation`, which will be called repeatedly as accounts get updated and saved, correct whereas `before_create` is not? It looks like one would want to assign and activation code, etc., only once.",Assignment Branch Condition size for befor
+4568,"@@ -95,6 +95,19 @@ namespace Datadog.Trace
+                 }
+             }
+
++            if (Settings.GlobalSamplingRate != null)
++            {
++                var globalRate = (float)Settings.GlobalSamplingRate;
++                if (globalRate < 0f || globalRate > 1f)
++                {
++                    Log.Warning(""{0} configuration of {1} is out of range"", ConfigurationKeys.GlobalSamplingRate, Settings.GlobalSamplingRate);
++                }
++                else
++                {
++                    Sampler.RegisterRule(new GlobalSamplingRule(globalRate));
++                }
++            }
++
+             // Register callbacks to make sure we flush the traces before exiting
+             AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit;
+             AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException;",What's the rationale for a default setting to not use a GlobalSamplingRate of 1? I don't know much about the sampling rate stuff,"Nitpicking: ""configuration of"" -> ""configuration of"""
+4569,"@@ -24,7 +24,8 @@ module Windows
+         'group'         => 'Administrators',
+         'puppetpath'    => '`cygpath -smF 35`/PuppetLabs/puppet/etc',
+         'puppetvardir'  => '`cygpath -smF 35`/PuppetLabs/puppet/var',
+-        'puppetbindir'  => '`cygpath -F 38`/Puppet Labs/Puppet Enterprise/bin',
++        #if an x86 Program Files dir exists then use it, default to just Program Files
++        'puppetbindir'  => '$( [ -d ""/cygdrive/c/Program Files (x86)"" ] && echo ""/cygdrive/c/Program Files (x86)"" || echo ""/cygdrive/c/Program Files"" )/Puppet Labs/Puppet Enterprise/bin',
+         'pathseparator' => ';',
+       })
+     end","Don't we know if it's 64 by this point? Do we have to test for the directory on every call, or can't we just split the value based on the platform?","cygdrive/c/Program Files (x86) => ""/cygdrive/c/Progr"
+4570,"@@ -35,6 +35,19 @@ class NoteListUtils {
+ 				})
+ 			);
+
++			menu.append(
++				new MenuItem({
++					label: _('Assign Notebook'),
++					click: async () => {
++						props.dispatch({
++							type: 'WINDOW_COMMAND',
++							name: 'moveToFolder',
++							noteIds: noteIds,
++						});
++					},
++				})
++			);
++
+ 			menu.append(
+ 				new MenuItem({
+ 					label: _('Duplicate'),",It's not async,Why does this need to be added to the menu? I don't
+4571,"@@ -66,11 +66,11 @@ namespace Examples.Console
+                 AppContext.SetSwitch(""System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport"", true);
+
+                 providerBuilder
+-                    .AddOtlpExporter(o =>
++                    .AddOtlpExporter((exporterOptions, metricReaderOptions) =>
+                     {
+-                        o.MetricReaderType = MetricReaderType.Periodic;
+-                        o.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
+-                        o.AggregationTemporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
++                        metricReaderOptions.MetricReaderType = MetricReaderType.Periodic;
++                        metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
++                        metricReaderOptions.Temporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
+                     });
+             }
+             else","Maybe we could add some use of `exporterOptions` in this example, otherwise the proper code would replace this variable name with an underscore?",Do we still need to set `o.AggregationTemporality =
+4572,"@@ -41,6 +41,11 @@ class Search extends WidgetBase
+      */
+     public $scope;
+
++    /**
++     * @var bool Search on every key stroke.
++     */
++    public $everykey = true;
++
+     //
+     // Object properties
+     //","Maybe would be better to rename it to ""onEveryKey"" or ""fireOnEveryKey"".",`public $everykey = true;`
+4573,"@@ -832,7 +832,7 @@ public class FilePage implements java.io.Serializable {
+             // Always allow preview for PrivateUrlUser
+             return true;
+         } else {
+-            return FileUtil.isPreviewAllowed(fileMetadata);
++            return fileDownloadHelper.isPreviewAllowed(fileMetadata);
+         }
+     }
+ ","if we're switching to calling FileDownloadHelper, we can just call that directly from the xhtml (see line 357 for example) and then remove this method completely. This is because the other thing it does is check PrivateURLUser, but the FileDownloadHelper method already does that. (and while we're at it, we can remove the method from FileUtil as this is the only place that method is called)",Seems like all the changes
+4574,"@@ -274,11 +274,7 @@ public abstract class GapicInterfaceConfig implements InterfaceConfig {
+   }
+
+   public GapicMethodConfig getMethodConfig(String methodSimpleName, String fullName) {
+-    GapicMethodConfig methodConfig = getMethodConfigMap().get(methodSimpleName);
+-    if (methodConfig == null) {
+-      throw new IllegalArgumentException(""no method config for method '"" + fullName + ""'"");
+-    }
+-    return methodConfig;
++    return getMethodConfigMap().get(methodSimpleName);
+   }
+
+   @Override",is `fullName` still required as a parameter?,Shouldn't this method be r
+4575,"@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
+           getClass().getClassLoader())
+           .asSubclass(Routable.class);
+       Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
+-      LOG.info(""Bound legacy RC support"");
++      LOG.finest(""Bound legacy RC support"");
+       return constructor.newInstance(sessions);
+     } catch (ReflectiveOperationException e) {
+       // Do nothing.",This informational message is important to users. Please leave.,We should keep this at inf
+4576,"@@ -470,7 +470,6 @@ func (o *initEnvOpts) deployEnv(app *config.Application) error {
+ 		Name:                     o.Name,
+ 		AppName:                  o.AppName(),
+ 		Prod:                     o.IsProduction,
+-		PublicLoadBalancer:       true, // TODO: configure this based on user input or service Type needs?
+ 		ToolsAccountPrincipalARN: caller.RootUserARN,
+ 		AppDNSName:               app.Domain,
+ 		AdditionalTags:           app.Tags,",Why do we want to remove this one? Are we planning to substitute it?,These changes seem unrelated. Can you create an issue for this?
+4577,"@@ -4,13 +4,14 @@ import (
+ 	""fmt""
+ 	""testing""
+
+-	""github.com/golang/protobuf/proto""
++	legacyProto ""github.com/golang/protobuf/proto"" // nolint: staticcheck // deprecated library needed until WithDetails can take v2
+ 	""github.com/spiffe/spire/pkg/common/nodeutil""
+ 	""github.com/spiffe/spire/proto/spire/common""
+ 	""github.com/spiffe/spire/proto/spire/types""
+ 	""github.com/stretchr/testify/require""
+ 	""google.golang.org/grpc/codes""
+ 	""google.golang.org/grpc/status""
++	""google.golang.org/protobuf/proto""
+ )
+
+ func TestIsAgentBanned(t *testing.T) {",We may create an issue to track this so we don't forget?,This is not needed anymore.
+4578,"@@ -1,9 +1,12 @@
+ class ApplicationController < ActionController::Base
++  helper AvatarHelper
++  helper ButtonHelper
++
+   protect_from_forgery with: :exception
+
+   attr_reader :page_context
+   helper_method :page_context
+-
++
+   before_action :store_location
+
+   def initialize(*params)",This file has the executable bit set.,Layout/EmptyLinesAroundClassBody: Extra empty line detected at
+4579,"@@ -177,6 +177,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
++	db.logger.Info(""setting db capacity to :"", db.capacity)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","Improve the formatting of the message `.Infof(""setting db capacity to: %v"", db.capacity)` There is a space before `:` and this way it is easier to see the formatting.","I think this log message might be a bit confusing. Maybe ""setti"
+4580,"@@ -434,12 +434,13 @@ RTPSParticipantImpl* RTPSDomainImpl::find_local_participant(
+ RTPSReader* RTPSDomainImpl::find_local_reader(
+         const GUID_t& reader_guid)
+ {
+-    std::lock_guard<std::mutex> guard(RTPSDomain::m_mutex);
++    std::unique_lock<std::mutex> lock(RTPSDomain::m_mutex);
+     for (const RTPSDomain::t_p_RTPSParticipant& participant : RTPSDomain::m_RTPSParticipants)
+     {
+         if (participant.second->getGuid().guidPrefix == reader_guid.guidPrefix)
+         {
+             // Participant found, forward the query
++            lock.unlock();
+             return participant.second->find_local_reader(reader_guid);
+         }
+     }","This lock cannot be released here, as it is protecting m_RTPSParticipants and the participant reference.",Why are you using a unique_lock here? Why not use the global lock?
+4581,"@@ -967,6 +967,8 @@ Query.prototype.find = function (conditions, callback) {
+     this.merge(conditions);
+   }
+
++  prepareDiscriminatorCriteria(this);
++
+   try {
+     this.cast(this.model);
+     this._castError = null;",we'll need this in `_findAndModify` too,Isn't it better to move this line to the constructor (instead of c
+4582,"@@ -148,7 +148,7 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
+ 		isGlobal = bundle == null || !bundle.containsKey(IS_GLOBAL_STORE) || bundle.getBoolean(IS_GLOBAL_STORE) || !hasUser;
+ 		// dbName is set to DBOpenHelper.DEFAULT_DB_NAME
+ 		//   if no bundle, or no value for dbName in bundle
+-		dbName = bundle == null || !bundle.containsKey(DB_NAME) ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME);
++		dbName = bundle == null || !bundle.containsKey(DB_NAME) ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ 	}
+
+ 	private void setupSpinner() {","This is the fix for the crash. The function to create the intent to launch this activity requires `dbName`, so it has to be set to `null`. In such cases, the value for `dbName` will be set to `null` and cause issues throughout this activity. This adds a default value if the explicitly assigned value in `null`.",Is this supposed to be `dbName = null || !bundle.containsKey(DB_NA
+4583,"@@ -412,6 +412,11 @@ class WordDocument(UIADocumentWithTableNavigation,WordDocumentNode,WordDocumentB
+ 	# Microsoft Word duplicates the full title of the document on this control, which is redundant as it appears in the title of the app itself.
+ 	name=u""""
+
++	def event_textChange(self):
++		# Ensure Braille is updated when text changes,
++		# As Microsoft Word does not fire caret events when typing text, even though the caret does move.
++		braille.handler.handleCaretMove(self)
++
+ 	def event_UIA_notification(self, activityId=None, **kwargs):
+ 		# #10851: in recent Word 365 releases, UIA notification will cause NVDA to announce edit functions
+ 		# such as ""delete back word"" when Control+Backspace is pressed.","Shouldn't we also trigger vision update here, so that if someone has caret highlighting enabled the correct character is highlighted?",Do you want to add this to the other methods in the same file too?
+4584,"@@ -338,7 +338,11 @@ public class GoGapicSurfaceTransformer implements ModelToViewTransformer<ProtoAp
+   void addXExampleImports(InterfaceContext context, Iterable<? extends MethodModel> methods) {
+     ImportTypeTable typeTable = context.getImportTypeTable();
+     typeTable.saveNicknameFor(""context;;;"");
+-    typeTable.saveNicknameFor(context.getProductConfig().getPackageName() + "";;;"");
++    typeTable.saveNicknameFor(
++        context.getProductConfig().getPackageName()
++            + "";""
++            + context.getNamer().getLocalPackageName()
++            + "";;"");
+
+     for (MethodModel method : methods) {
+       method.getAndSaveRequestTypeName(context.getImportTypeTable(), context.getNamer());","Woah, how does this change, which includes semicolons, result in the baseline change? Are the semicolon chars just part of the internal representation of the import type?","Isn't there some constant to use for ""context"" and ""namer""?"
+4585,"@@ -51,7 +51,7 @@ class _NvdaLocationData:
+ 		self.whichNVDA = builtIn.get_variable_value(""${whichNVDA}"", ""source"")
+ 		if self.whichNVDA == ""source"":
+ 			self._runNVDAFilePath = _pJoin(self.repoRoot, ""source/nvda.pyw"")
+-			self.baseNVDACommandline = f""pyw -3.7-32 {self._runNVDAFilePath}""
++			self.baseNVDACommandline = f""pyw {self._runNVDAFilePath}""
+ 		elif self.whichNVDA == ""installed"":
+ 			self._runNVDAFilePath = _pJoin(_expandvars('%PROGRAMFILES%'), 'nvda', 'nvda.exe')
+ 			self.baseNVDACommandline = f'""{str(self._runNVDAFilePath)}""'",Can't you just use runnvda.bat here?,Why does `-3.7-32` have been removed?
+4586,"@@ -23,17 +23,6 @@
+ #include ""selectors.h""
+ #include ""vstring.h""
+
+-/* To get rid of unused parameter warning in
+- * -Wextra */
+-#ifdef UNUSED
+-#elif defined(__GNUC__)
+-# define UNUSED(x) UNUSED_ ## x __attribute__((unused))
+-#elif defined(__LCLINT__)
+-# define UNUSED(x) /*@unused@*/ x
+-#else
+-# define UNUSED(x) x
+-#endif
+-
+ typedef enum {
+ 	K_INTERFACE,
+ 	K_IMPLEMENTATION,","these definitions of UNUSED aren't the same as the one you imported, so callers should be fixed (if any)",Looks like this file can be deleted too.
+4587,"@@ -404,6 +404,7 @@ func (client *cniClient) createIPAMNetworkConfig(cfg *Config) (string, *libcni.N
+
+ 	ipamNetworkConfig := IPAMNetworkConfig{
+ 		Name:       ECSIPAMPluginName,
++		Type:       ECSIPAMPluginName,
+ 		CNIVersion: client.cniVersion,
+ 		IPAM:       ipamConfig,
+ 	}",is type a free string too?,Why is this different than the default?
+4588,"@@ -27,15 +27,16 @@ class WrapFunction(nn.Module):
+         return self.wrapped_function(*args, **kwargs)
+
+
+-def ort_validate(model, feats, onnx_io='tmp.onnx'):
++def ort_validate(model_func, feats, onnx_io='tmp.onnx'):
+     """"""Validate the output of the onnxruntime backend is the same as the output
+     generated by torch.
+
+     Args:
+-        model (nn.Module): the model to be verified
++        model_func : the function of model to be verified
+         feats (list(torch.Tensor) | torch.Tensor): the input of model
+         onnx_io (str): the name of onnx output file
+     """"""
++    model = WrapFunction(model_func)
+     model.cpu().eval()
+     with torch.no_grad():
+         torch.onnx.export(",here input could be a normal function or an instance of torch.nn.Module.,why this change? `model` is already a `nn.Module`.
+4589,"@@ -65,6 +65,7 @@ module Travis
+           sh.echo 'Please open any issues at https://github.com/travis-ci/travis-ci/issues/new and cc @domenkozar @garbas @matthewbauer @grahamc', ansi: :green
+
+           sh.cmd ""nix-env --version""
++          sh.cmd ""nix-instantiate --eval -E 'with import <nixpkgs> {}; lib.version or lib.nixpkgsVersion'""
+         end
+
+         def script","Example output: ""19.03.git.a7f4a860d0c"" At some point `nixpkgsVersion` was renamed to `version` since someone may use an old channel we fallback to `nixpkgsVersion` for backwards compatibility.",Would it make sense to move this to `lib/nixpkgs/v
+4590,"@@ -39,8 +39,6 @@ class LanguageTreeReadAction
+
+
+     /**
+-     * @IsGranted(""SETTINGS_READ"")
+-     *
+      * @SWG\Tag(name=""Language"")
+      * @SWG\Parameter(
+      *     name=""language"",",Class import is therefore redundant I guess :),Wouldn't it be better to use the `SETTINGS_READ` c
+4591,"@@ -58,11 +58,13 @@ const (
+ 	infoTryingToStopNode             = ""Trying to stop the node...""
+ 	infoNodeSuccessfullyStopped      = ""The node was successfully stopped.""
+ 	infoNodeStatus                   = ""Last committed block: %d\nTime since last block: %s\nSync Time: %s\nLast consensus protocol: %s\nNext consensus protocol: %s\nRound for next consensus protocol: %d\nNext consensus protocol supported: %v""
++	warnNodeCreationIPFailure        = ""Parsing passed IP %v failed: need a valid IPv4 or IPv6 address with a specified port number. Acting as though IP was not supplied.""
+ 	errorNodeNotDetected             = ""Algorand node does not appear to be running: %s""
+ 	errorNodeStatus                  = ""Cannot contact Algorand node: %s.""
+ 	errorNodeFailedToStart           = ""Algorand node failed to start: %s""
+ 	errorNodeRunning                 = ""Node must be stopped before writing APIToken""
+ 	errorNodeFailGenToken            = ""Cannot generate API token: %s""
++	errorNodeCreation                = ""Error during node creation: %v""
+ 	errorKill                        = ""Cannot kill node: %s""
+ 	errorCloningNode                 = ""Error cloning the node: %s""
+ 	infoNodeCloned                   = ""Node cloned successfully to: %s""","If parsing fails, don't act as no IP specified. Error out.","why not just ""Error during node creation: %v"" ?"
+4592,"@@ -187,7 +187,9 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+
+     final Object updateSync = new Object();
+
+-    public enum CHARTTYPE {PRE,BAS, IOB, COB, DEV, SEN};
++    public enum CHARTTYPE {PRE, BAS, IOB, COB, DEV, SEN}
++
++    ;
+     private static final ScheduledExecutorService worker = Executors.newSingleThreadScheduledExecutor();
+     private static ScheduledFuture<?> scheduledUpdate = null;
+ ",... here the semicolon wanted to run away from the enum ;),please remove the new line
+4593,"@@ -76,12 +76,12 @@ public class ReplicateFromLeader {
+       }
+       log.info(""Will start replication from leader with poll interval: {}"", pollIntervalStr );
+
+-      NamedList<Object> slaveConfig = new NamedList<>();
+-      slaveConfig.add(""fetchFromLeader"", Boolean.TRUE);
+-      slaveConfig.add(ReplicationHandler.SKIP_COMMIT_ON_MASTER_VERSION_ZERO, switchTransactionLog);
+-      slaveConfig.add(""pollInterval"", pollIntervalStr);
++      NamedList<Object> secondaryConfig = new NamedList<>();
++      secondaryConfig.add(""fetchFromLeader"", Boolean.TRUE);
++      secondaryConfig.add(ReplicationHandler.SKIP_COMMIT_ON_MASTER_VERSION_ZERO, switchTransactionLog);
++      secondaryConfig.add(""pollInterval"", pollIntervalStr);
+       NamedList<Object> replicationConfig = new NamedList<>();
+-      replicationConfig.add(""slave"", slaveConfig);
++      replicationConfig.add(""secondary"", secondaryConfig);
+
+       String lastCommitVersion = getCommitVersion(core);
+       if (lastCommitVersion != null) {","Note that this is in the context of SolrCloud, so ""secondary"" doesn't apply and should be instead follower",Maybe we should rename the
+4594,"@@ -1578,11 +1578,11 @@ EOF
+     assert_response :success, ""can't get changesets by closed-ness""
+     assert_changesets [3, 5, 6, 7, 8, 9]
+
+-    get :query, :closed => ""true"", :user => users(:normal_user).id
++    get :query, :closed => ""true"", :user => users(:normal_user)
+     assert_response :success, ""can't get changesets by closed-ness and user""
+     assert_changesets [3, 6, 8]
+
+-    get :query, :closed => ""true"", :user => users(:public_user).id
++    get :query, :closed => ""true"", :user => users(:public_user)
+     assert_response :success, ""can't get changesets by closed-ness and user""
+     assert_changesets [7]
+ ",This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell.,Use the new Ruby 1.9 hash
+4595,"@@ -4177,9 +4177,11 @@ RelExpr * FileScan::preCodeGen(Generator * generator,
+ 	 TRUE);
+
+       if (isHiveTable())
+-	// assign individual files and blocks to each ESPs
+-	((NodeMap *) getPartFunc()->getNodeMap())->assignScanInfos(hiveSearchKey_);
+-       generator->setProcessLOB(TRUE);
++        {
++          // assign individual files and blocks to each ESPs
++          ((NodeMap *) getPartFunc()->getNodeMap())->assignScanInfos(hiveSearchKey_);
++          generator->setProcessLOB(TRUE);
++        }
+     }
+
+   ",Need to ensure this is set to TRU for LOB datatype access too not just for hive .,What's the reason for this
+4596,"@@ -1772,7 +1772,11 @@ class Series(_Frame, IndexOpsMixin):
+
+     # ----------------------------------------------------------------------
+
+-    def _reduce_for_stat_function(self, sfun):
++    def _reduce_for_stat_function(self, sfun, numeric_only=None):
++        """"""
++        :param sfun: the stats function to be used for aggregation
++        :param numeric_only: not used by this implementation, but passed down by stats functions
++        """"""
+         from inspect import signature
+         num_args = len(signature(sfun).parameters)
+         col_sdf = self._scol","You're using the Sphinx docstring style here (maybe because it's the default in PyCharm?). Instead, you should use the NumPy style (that you've also used in other places) to be more consistent with the rest of the project.","`numeric_only` should be `True` by default, since it does not affect the `_reduce_for_stat_function`"
+4597,"@@ -142,8 +142,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+                 }
+                 else if (!hasListenOptions && !hasServerAddresses)
+                 {
+-                    _logger.LogDebug($""No listening endpoints were configured. Binding to {Constants.DefaultIPEndPoint} by default."");
+-                    listenOptions.Add(new ListenOptions(Constants.DefaultIPEndPoint));
++                    _logger.LogDebug($""No listening endpoints were configured. Binding to {Constants.DefaultServerAddress} by default."");
++
++                    // ""localhost"" for both IPv4 and IPv6 can't be represented as an IPEndPoint.
++                    StartLocalhost(engine, ServerAddress.FromUrl(Constants.DefaultServerAddress));
++
++                    // If StartLocalhost doesn't throw, there is at least one listener.
++                    // The port cannot change for ""localhost"".
++                    _serverAddresses.Addresses.Add(Constants.DefaultServerAddress);
++
++                    return;
+                 }
+                 else if (!hasListenOptions)
+                 {",Don't really need this since the rest of the method will no-op but it's also safe to return early.,I don't think this is the right fix. This method is called when there is no listening endpoint. It i
+4598,"@@ -19,11 +19,13 @@
+
+ #include <fastdds/rtps/messages/RTPSMessageCreator.h>
+ #include <fastdds/rtps/messages/CDRMessage.h>
+-#include <fastrtps/qos/ParameterList.h>
+
+ #include <fastdds/dds/log/Log.hpp>
+
++#include ""../../fastdds/core/policy/ParameterList.hpp""
++
+ using namespace eprosima::fastrtps;
++using ParameterList = eprosima::fastdds::dds::ParameterList;
+
+ namespace eprosima {
+ namespace fastrtps {",Don't use relative paths. src directory is already on the include search path,Why do we need this?
+4599,"@@ -0,0 +1,5 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++// [assembly: BenchmarkDotNet.Attributes.AspNetCoreBenchmark]",this file can be removed,Do we need a benchmark? Or was this left over from debugging?
+4600,"@@ -98,7 +98,7 @@ public class CodeFirstSpringmvc extends CodeFirstSpringmvcBase {
+
+   @RequestMapping(path = ""/uploadWithoutAnnotation"", method = RequestMethod.POST, produces = MediaType.TEXT_PLAIN_VALUE, consumes = MediaType.MULTIPART_FORM_DATA_VALUE)
+   public String fileUploadWithoutAnnotation(MultipartFile file1, MultipartFile file2,
+-      @RequestAttribute(""name"") String name) {
++      @RequestAttribute(name = ""name"", required = false) String name) {
+     return super.fileUpload(file1, file2, name);
+   }
+ ",Do we have test cases that name is null?,Why is this required?
+4601,"@@ -109,8 +109,16 @@ type SumIntAgg struct {
+
+ func (a *SumIntAgg) DoInt(vs *array.Int64) {
+ 	// https://issues.apache.org/jira/browse/ARROW-4081
+-	if vs.Len() > 0 {
+-		a.sum += math.Int64.Sum(vs)
++	if l := vs.Len() - vs.NullN(); l > 0 {
++		if vs.NullN() == 0 {
++			a.sum += math.Int64.Sum(vs)
++		} else {
++			for i := 0; i < vs.Len(); i++ {
++				if vs.IsValid(i) {
++					a.sum += vs.Value(i)
++				}
++			}
++		}
+ 	}
+ }
+ func (a *SumIntAgg) Type() flux.ColType {","in a separate PR, I'll check for a table that is empty/all-null and skip this function call completely.","Ah, I see what you're"
+4602,"@@ -47,7 +47,7 @@ public class WebUtils {
+     try {
+       azkabanEventReporter = ServiceProvider.SERVICE_PROVIDER
+           .getInstance(AzkabanEventReporter.class);
+-    } catch (NullPointerException | ConfigurationException e) {
++    } catch (Exception e) {
+       Logger.getLogger(WebUtils.class.getName()).warn(""AzkabanEventReporter not configured"", e);
+     }
+   }","We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null.",Why is it changed to
+4603,"@@ -112,7 +112,12 @@ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context,
+ 					// The values only have the same type when `null`.
+
+ 					outer: if (oldDom==null || oldDom.parentNode!==parentDom) {
+-						parentDom.appendChild(newDom);
++						// Skip appendind if the last element is the same as the new dom
++						// node. This is necessary to prevent the last element losing focus
++						// if it had focus before the diff.
++						if (parentDom.lastChild!==newDom) {
++							parentDom.appendChild(newDom);
++						}
+ 					}
+ 					else {
+ 						// `j<oldChildrenLength; j+=2` is an alternative to `j++<oldChildrenLength/2`",Can't we add the check here?,Why does this need to
+4604,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests,"I think we should close the connection in the finally block. If the request fails, self._conn is closed."
+4605,"@@ -40,6 +40,8 @@ type GenericDeploymentSpec struct {
+ 	// The maximum length of time to execute deployment before giving up.
+ 	// Default is 6h.
+ 	Timeout Duration `json:""timeout,omitempty"" default:""6h""`
++	// List of encrypted secrets and targets that should be decoded before using.
++	Encryption *SecretEncryption `json:""encryption""`
+ }
+
+ func (s *GenericDeploymentSpec) Validate() error {",Tell me if you have a better field name for this.,Does this need a `omitempty`?
+4606,"@@ -1084,8 +1084,8 @@ partial class Build
+                         ""Samples.AspNetCoreMvc30"" => Framework == TargetFramework.NETCOREAPP3_0,
+                         ""Samples.AspNetCoreMvc31"" => Framework == TargetFramework.NETCOREAPP3_1,
+                         ""Samples.AspNetCore2"" => Framework == TargetFramework.NETCOREAPP2_1,
+-                        ""Samples.AspNetCore5"" => Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NETCOREAPP3_0,
+-                        ""Samples.GraphQL4"" => Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NET5_0,
++                        ""Samples.AspNetCore5"" => Framework == TargetFramework.NET6_0 || Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NETCOREAPP3_0,
++                        ""Samples.GraphQL4"" => Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NET6_0,
+                         var name when projectsToSkip.Contains(name) => false,
+                         var name when multiPackageProjects.Contains(name) => false,
+                         ""Samples.AspNetCoreRazorPages"" => true,","FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority",Why did you change this file?
+4607,"@@ -364,16 +364,11 @@ void getNbrAtomAndBondIds(unsigned int aid, const RDKit::ROMol *mol,
+   unsigned int na = mol->getNumAtoms();
+   URANGE_CHECK(aid, na);
+
+-  RDKit::ROMol::ADJ_ITER nbrIdx, endNbrs;
+-  boost::tie(nbrIdx, endNbrs) = mol->getAtomNeighbors(mol->getAtomWithIdx(aid));
+-
+-  unsigned int ai, bi;
+-  while (nbrIdx != endNbrs) {
+-    ai = (*nbrIdx);
+-    bi = mol->getBondBetweenAtoms(aid, ai)->getIdx();
++  for (auto ai : boost::make_iterator_range(
++           mol->getAtomNeighbors(mol->getAtomWithIdx(aid)))) {
++    auto bi = mol->getBondBetweenAtoms(aid, ai)->getIdx();
+     aids.push_back(ai);
+     bids.push_back(bi);
+-    nbrIdx++;
+   }
+ }
+ ","This is just `mol->atomNeightors()`, is it?",Line longer than 80 columns. Please split.
+4608,"@@ -40,10 +40,11 @@ using daal_kmeans_lloyd_dense_ucapi_kernel_t =
+     daal_kmeans::internal::KMeansDenseLloydBatchKernelUCAPI<Float>;
+
+ template <typename Float>
+-struct infer_kernel_gpu<Float, method::by_default> {
+-    infer_result operator()(const dal::backend::context_gpu& ctx,
+-                            const descriptor_base& params,
+-                            const infer_input& input) const {
++struct infer_kernel_gpu<Float, method::by_default, task::clustering> {
++    infer_result<task::clustering> operator()(const dal::backend::context_gpu& ctx,
++                                              const descriptor_base<task::clustering>& params,
++                                              const infer_input<task::clustering>& input) const {
++        using Task = task::clustering;
+         auto& queue = ctx.get_queue();
+         interop::execution_context_guard guard(queue);
+ ",This alias is just for a single occurrence. Maybe it ins't necessary?,Why are you adding the `using Task = task::clustering;` here?
+4609,"@@ -1198,7 +1198,7 @@ class CppGenerator : public BaseGenerator {
+         code_ += ""    }"";
+       }
+     }
+-    code_ += ""    default: return false;"";
++    code_ += ""    default: return true;"";
+     code_ += ""  }"";
+     code_ += ""}"";
+     code_ += """";",You can delete this `NONE` case.,"The default value of this field should be true, not false."
+4610,"@@ -5420,8 +5420,8 @@ TEST_F(VkLayerTest, RenderPassCreateAttachmentReadOnlyButCleared) {
+     }
+ }
+
+-TEST_F(VkLayerTest, RenderPassCreateAttachmentUsedTwiceColor) {
+-    TEST_DESCRIPTION(""Attachment is used simultaneously as two color attachments. This is usually unintended."");
++TEST_F(VkLayerTest, RenderPassCreateAttachmentMismatchingLayoutsColor) {
++    TEST_DESCRIPTION(""Attachment is used simultaneously as two color attachments with different layouts."");
+
+     // Check for VK_KHR_get_physical_device_properties2
+     if (InstanceExtensionSupported(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME)) {",@cnorthrop -- here is a test with a name change. Is this going to affect your internal CI?,RenderPassCreateAttachmentUsedTwiceColor as opposed to Render
+4611,"@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
+   private ChromeDriverCommand() {}
+
+   static final String LAUNCH_APP = ""launchApp"";
++  static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
++      = ""sendCommandForDownloadChromeHeadLess"";
++
+ }","Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way.",Minor quibble: should this be `sendCommandForDownloadChromeHe
+4612,"@@ -122,6 +122,10 @@ class core(task.Config):
+     parallel_scheduling = parameter.BoolParameter(
+         default=False,
+         description='Use multiprocessing to do scheduling in parallel.')
++    parallel_scheduling_processes = parameter.IntParameter(
++        default=None,
++        description='The number of processes to use for scheduling in parallel.'
++                    ' The default is the number of available CPUs')
+     assistant = parameter.BoolParameter(
+         default=False,
+         description='Run any task from the scheduler.')","I think this will cause a warning, can you set the default to zero (`0`)?",this could be a bit more descriptive like `The default is the number of processes to schedule in parallel.`
+4613,"@@ -2,7 +2,7 @@ package client_connection
+
+ import (
+ 	""errors""
+-	""github.com/mysterium/node/service_discovery/dto""
++	id ""github.com/mysterium/node/identity""
+ )
+
+ type State string","confusing naming. Identity from ""id"" package :/ why we need alias here? (and in other imports)",Remove the extra line?
+4614,"@@ -355,9 +355,11 @@ def data(readonly=False):
+              ""Hide the window decoration when using wayland ""
+              ""(requires restart)""),
+
+-            ('show-keyhints',
+-             SettingValue(typ.Bool(), 'true'),
+-             ""Show possible keychains based on the current keystring""),
++            ('keyhint-blacklist',
++             SettingValue(typ.List(none_ok=True), ''),
++             ""Keychains that shouldn't be shown in the keyhint dialog\n\n""
++             ""Globs are supported, so ';*' will blacklist all keychains""
++             ""starting with ';'. Use '*' to disable keyhints""),
+
+             readonly=readonly
+         )),","It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work.","nit: ""... will blacklist all keychains starting with '*'."""
+4615,"@@ -150,7 +150,7 @@ module.exports = {
+         TestCase.assertEqual(obj.arrayCol1[-1], undefined);
+         TestCase.assertEqual(obj.arrayCol1['foo'], undefined);
+
+-        for (let field of Object.keys(prim)) {
++        for (let field of Object.keys(Object.getPrototypeOf(prim))) {
+             TestCase.assertEqual(prim[field][2], undefined);
+             TestCase.assertEqual(prim[field][-1], undefined);
+             TestCase.assertEqual(prim[field]['foo'], undefined);",Perhaps use the new `.keys()` method here instead?,"I don't think this is correct, `Object.getPrototypeOf` is not supported in IE11."
+4616,"@@ -79,9 +79,10 @@ func (b *builder) kubernetesDiff(
+ 		}
+ 	}
+
+-	result, err := provider.DiffList(oldManifests, newManifests,
++	result, err := provider.DiffList(
++		oldManifests,
++		newManifests,
+ 		diff.WithEquateEmpty(),
+-		diff.WithIgnoreAddingMapKeys(),
+ 		diff.WithCompareNumberAndNumericString(),
+ 	)
+ 	if err != nil {","We don't need this option because plan-preview is comparing between 2 commits, not using the live state.","I don't think we need the `WithIgnoreAddingMapKeys` anymore, or am I missing something?"
+4617,"@@ -37,6 +37,11 @@ module Beaker
+       # @param [Proc] block The actions to be performed in this step.
+       def step step_name, &block
+         logger.notify ""\n  * #{step_name}\n""
++        if @options
++          @options[:current_test_info] ||= {}
++          @options[:current_test_info][:step] ||= {}
++          @options[:current_test_info][:step][:name] = step_name
++        end
+         yield if block_given?
+       end
+ ","I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution.",Rails/DynamicFindBy: Use find_by instead of dynamic find_by.
+4618,"@@ -237,7 +237,8 @@ func (card *DRICard) readPowerConsumption() (float64, error) {
+ 	return 0, fmt.Errorf(""cannot find average power consumption param in the amdgpu_pm_info"")
+ }
+
+-func (card *DRICard) Metrics() (*DRICardMetrics, error) {
++// Status returns hardware stats for the card
++func (card *DRICard) Status() (*DRICardMetrics, error) {
+ 	if len(card.HwmonPath) == 0 {
+ 		return nil, fmt.Errorf(""metrics interface is not available for %s"", card.Name)
+ 	}",So `Status` returns metrics?,"The name `Status` is confusing, it returns the status of the card, not the hardware sta"
+4619,"@@ -3,6 +3,8 @@ class OrganizationsController < ApplicationController
+   helper RatingsHelper
+
+   before_action :find_organization
++  before_action :set_outside_committers, only: :outside_committers
++  before_action :organization_context, only: :outside_committers
+
+   def outside_projects
+     @outside_projects = @organization.outside_projects((params[:page] || 1), 20)","Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument(s) for all the four methods. What do you think?",Prefer single-quoted strings when you don't need string interpolation or special symbol
+4620,"@@ -56,7 +56,15 @@ public final class IcebergDateObjectInspectorHive3 extends AbstractPrimitiveJava
+
+   @Override
+   public Object copyObject(Object o) {
+-    return o == null ? null : new Date((Date) o);
++    if (o == null) {
++      return null;
++    }
++
++    if (o instanceof Date) {
++      return new Date((Date) o);
++    } else {
++      return o;
++    }
+   }
+
+ }",Why would this be called to copy a non-Date object?,What is the reason for this change?
+4621,"@@ -77,13 +77,13 @@ func (msg *Boolmsg) Serialize() []byte {
+ 	native.PutUint16(buf[0:2], uint16(msg.Len()))
+ 	native.PutUint16(buf[2:4], msg.Type)
+ 	if msg.Value {
+-		buf[4] = 1
++		native.PutUint32(buf[4:8], uint32(1))
+ 	} else {
+-		buf[4] = 0
++		native.PutUint32(buf[4:8], uint32(0))
+ 	}
+ 	return buf
+ }
+
+ func (msg *Boolmsg) Len() int {
+-	return unix.NLA_HDRLEN + 1
++	return unix.NLA_HDRLEN + 4 // alignment
+ }",This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once.,why was this changed?
+4622,"@@ -71,7 +71,7 @@ func DefaultConfig() Config {
+ 		PauseContainerTag:                   DefaultPauseContainerTag,
+ 		AWSVPCBlockInstanceMetdata:          false,
+ 		ContainerMetadataEnabled:            false,
+-		TaskCPUMemLimit:                     DefaultEnabled,
++		TaskCPUMemLimit:                     BooleanDefaultTrue{Value: NotSet},
+ 		CgroupPath:                          defaultCgroupPath,
+ 		TaskMetadataSteadyStateRate:         DefaultTaskMetadataSteadyStateRate,
+ 		TaskMetadataBurstRate:               DefaultTaskMetadataBurstRate,","Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are ""default false"" config vars not affected by this bug?",`BooleanDefaultTrue` can be replace
+4623,"@@ -9,7 +9,7 @@ class RolesController < ApplicationController
+     authorize @role
+
+     access_level = params[:role][:access_level].to_i
+-    @role.set_access_level(access_level)
++    @role.access_level = access_level
+     message = ''
+     if params[:user].present?
+       if @role.plan.owner.present? && @role.plan.owner.email == params[:user]",Replaced this method with a ruby idiomatic setter.,Is there a test we can write for th
+4624,"@@ -2,7 +2,7 @@
+  * The Forgotten Server - a free and open-source MMORPG server emulator
+  * Copyright (C) 2017 Mark Samman <mark.samman@gmail.com>
+  *
+- * This program is free software; you can redistribute it and/or modify
++ * This program is free tisoftware; you can redistribute it and/or modify
+  * it under the terms of the GNU General Public License as published by
+  * the Free Software Foundation; either version 2 of the License, or
+  * (at your option) any later version.",wrong place hehe,There's a typo here.
+4625,"@@ -0,0 +1,14 @@
++require 'travis/build/appliances/base'
++
++module Travis
++  module Build
++    module Appliances
++      class RestartMysql < Base
++        def apply
++          sh.cmd '(ls /var/run/mysqld/mysqld.sock >& /dev/null) || sudo service mysql restart'
++        end
++      end
++    end
++  end
++end
++","Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon","Just curious, why do"
+4626,"@@ -30,12 +30,12 @@ class Proposal < ActiveRecord::Base
+   has_many :individual_approvals, ->{ individual }, class_name: 'Approvals::Individual'
+   has_many :approvers, through: :individual_approvals, source: :user
+   has_many :api_tokens, through: :individual_approvals
+-  has_many :attachments
++  has_many :attachments, dependent: :destroy
+   has_many :approval_delegates, through: :approvers, source: :outgoing_delegates
+-  has_many :comments
++  has_many :comments, dependent: :destroy
+   has_many :observations, -> { where(""proposal_roles.role_id in (select roles.id from roles where roles.name='observer')"") }
+   has_many :observers, through: :observations, source: :user
+-  belongs_to :client_data, polymorphic: true
++  belongs_to :client_data, polymorphic: true, dependent: :destroy
+   belongs_to :requester, class_name: 'User'
+
+   # The following list also servers as an interface spec for client_datas","Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice?",Line is too long. [9
+4627,"@@ -1452,6 +1452,7 @@ static void establish_tunnel(h2o_req_t *req, h2o_tunnel_t *tunnel, uint64_t idle
+     h2o_iovec_t datagram_flow_id = {};
+
+     if (stream->tunnel == NULL) {
++        tunnel->destroy(tunnel);
+         /* the tunnel has been closed in the meantime */
+         return;
+     }","This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach.",can the tunnel be NU
+4628,"@@ -5,8 +5,8 @@
+
+ nano::error nano::node_pow_server_config::serialize_toml (nano::tomlconfig & toml) const
+ {
+-	toml.put (""enable"", enable, ""Enable or disable starting Nano PoW Server as a child process.\ntype:bool"");
+-	toml.put (""nano_pow_server_path"", pow_server_path, ""Path to the nano_pow_server executable.\ntype:string,path"");
++	toml.put (""enable"", enable, ""Enable or disable starting Nano PoW Server as a child process\ntype:bool"");
++	toml.put (""nano_pow_server_path"", pow_server_path, ""Path to the nano_pow_server executable\ntype:string,path"");
+ 	return toml.get_error ();
+ }
+ ",Did you mean to remove the periods here while newly adding to other locations?,"These changes are unrelated, can you make them in another PR?"
+4629,"@@ -2014,7 +2014,7 @@ func (bps *blockPutState) removeOtherBps(other *blockPutState) {
+ 	// slice length.
+ 	newLen := len(bps.blockStates) - len(other.blockStates)
+ 	if newLen <= 0 {
+-		newLen = 1
++		newLen = 0
+ 	}
+
+ 	// Remove any blocks that appear in `other`.",the check can now be `if newLen < 0`,Is this change intentional? Was this a bug?
+4630,"@@ -8,18 +8,13 @@ import (
+ 	""os""
+ 	""time""
+
+-	""github.com/google/uuid""
+ 	log ""github.com/sirupsen/logrus""
+ 	""github.com/spf13/cobra""
+ 	""github.com/spf13/pflag""
+
+ 	apiextv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+-	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+-	""k8s.io/client-go/kubernetes""
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+-	""k8s.io/client-go/tools/leaderelection""
+-	""k8s.io/client-go/tools/leaderelection/resourcelock""
+ 	""k8s.io/klog""
+ 	apiregistrationv1 ""k8s.io/kube-aggregator/pkg/apis/apiregistration/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client/config""","If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...)","I would expect leaderelection to resourcelock as well, no?"
+4631,"@@ -28,14 +28,13 @@ typedef boost::tokenizer<boost::char_separator<char> > tokenizer;
+ namespace ForceFields {
+ namespace MMFF {
+
+-class std::unique_ptr<MMFFAromCollection> MMFFAromCollection::ds_instance = nullptr;
+-
+ extern const std::uint8_t defaultMMFFArom[];
+
+ MMFFAromCollection *MMFFAromCollection::getMMFFArom(
+     const std::uint8_t *mmffArom) {
+-  if (!ds_instance || mmffArom) {
+-    ds_instance.reset(new MMFFAromCollection(mmffArom));
++  static std::unique_ptr<MMFFAromCollection> ds_instance(new MMFFAromCollection(nullptr));
++  if(mmffArom){
++    return new MMFFAromCollection(mmffArom);
+   }
+   return ds_instance.get();
+ }",Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not.,This should be `std::unique_ptr<MMFF>`.
+4632,"@@ -360,6 +360,15 @@ class LocalStorage implements IStorage {
+       name,
+       (data, cb) => {
+         if (data._attachments[filename]) {
++          // get version form _attachments;
++          // there aways had 'version' in verdaccio publish package.
++          // but there was no 'version' in package witch unlink form npmjs
++          // see https://github.com/verdaccio/verdaccio/issues/1359
++          const version = data._attachments[filename].version;
++          if (version && data.versions[version] && data.time[version]) {
++            delete data.versions[version];
++            delete data.time[version];
++          }
+           delete data._attachments[filename];
+           cb();
+         } else {",form => from,Is it possible to use `data.versions[version]` instead of `data.time[version]`?
+4633,"@@ -28,6 +28,7 @@ public interface Rule extends PropertySource {
+      * The property descriptor to universally suppress violations with messages
+      * matching a regular expression.
+      */
++    // TODO 7.0.0 use PropertyDescriptor<Pattern>
+     StringProperty VIOLATION_SUPPRESS_REGEX_DESCRIPTOR = new StringProperty(""violationSuppressRegex"",
+             ""Suppress violations with messages matching a regular expression"", null, Integer.MAX_VALUE - 1);
+ ","Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is then automatically converted into a Pattern.",Is this going to be addressed in another PR?
+4634,"@@ -66,7 +66,9 @@ public class GoGapicSurfaceTransformerTest {
+             locator,
+             new String[] {""myproto_gapic.yaml""});
+
+-    productConfig = GapicProductConfig.create(model, configProto, TargetLanguage.GO);
++    productConfig =
++        GapicProductConfig.create(
++            model, configProto, ""google.example.myproto.v1"", TargetLanguage.GO);
+
+     if (model.getDiagReporter().getDiagCollector().hasErrors()) {
+       throw new IllegalStateException(","Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer.","Could you make `""google.example.myproto.v1""` a constant?"
+4635,"@@ -94,7 +94,7 @@ class CheckCompoundPattern {
+   CharsRef expandReplacement(CharsRef word, int breakPos) {
+     if (replacement != null && charsMatch(word, breakPos, replacement)) {
+       return new CharsRef(
+-          word.subSequence(0, breakPos)
++          new String(word.chars, 0, word.offset + breakPos)
+               + endChars
+               + beginChars
+               + word.subSequence(breakPos + replacement.length(), word.length));",Include all compounds parts from the very beginning for the case check to work later,I am not sure that this will work. `CharsRef` has a `toString()` that returns t
+4636,"@@ -461,7 +461,7 @@ func get(envInfo *cmds.Agent, proxy proxy.Proxy) (*config.Node, error) {
+ 	}
+
+ 	if !nodeConfig.Docker && nodeConfig.ContainerRuntimeEndpoint == """" {
+-		nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.Containerd.Address
++		nodeConfig.AgentConfig.RuntimeSocket = ""unix://"" + nodeConfig.Containerd.Address
+ 	} else {
+ 		nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.ContainerRuntimeEndpoint
+ 		nodeConfig.AgentConfig.CNIPlugin = true","if the user specifies a url scheme on the cli this is going to cause problems, no?",Should we use the `ContainerRuntimeEndpoint` in both `nodeconfig` and `clusterconfig`?
+4637,"@@ -726,7 +726,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
+             disableIndicators: true,
+             disableHoverMenu: true,
+             overlayPlayButton: true,
+-            width: dom.getWindowSize().innerWidth * 0.25
++            width: dom.getWindowSize().innerWidth * 0.5
+         });
+
+         elem.innerHTML = cardHtml;",How about that `scaleFactor`?,This doesn't seem related to this PR?
+4638,"@@ -273,6 +273,19 @@ class NonDivArithmeticOpAnalyzer
+         }
+     }
+
++    /**
++     * @param int|float $result
++     */
++    private static function getNumericalType($result): Type\Union
++    {
++        if ($result <= PHP_INT_MAX && $result >= PHP_INT_MIN) {
++            /** @var int $result */
++            return Type::getInt(false, $result);
++        }
++
++        return Type::getFloat($result);
++    }
++
+     /**
+      * @param  string[]        &$invalid_left_messages
+      * @param  string[]        &$invalid_right_messages","`assert(is_int($result));` would be preferable I think, even if we know it can't ever be false",Is this really necessary? I don't think it's used anywhere.
+4639,"@@ -162,14 +162,14 @@ class Cart
+     /**
+      * @return \Shopsys\FrameworkBundle\Model\Order\Item\QuantifiedProduct[]
+      */
+-    public function getQuantifiedProductsIndexedByItemId()
++    public function getQuantifiedProducts()
+     {
+-        $quantifiedProductsByItemId = [];
++        $quantifiedProducts = [];
+         foreach ($this->items as $item) {
+-            $quantifiedProductsByItemId[$item->getId()] = new QuantifiedProduct($item->getProduct(), $item->getQuantity());
++            $quantifiedProducts[] = new QuantifiedProduct($item->getProduct(), $item->getQuantity());
+         }
+
+-        return $quantifiedProductsByItemId;
++        return $quantifiedProducts;
+     }
+
+     /**",I'm unfortunately unable to review whether you've changed everything that used to use cartIds,What does this change have to do with this PR?
+4640,"@@ -3,14 +3,15 @@ package de.danoeh.antennapod.dialog;
+ import android.app.Dialog;
+ import android.content.Context;
+ import android.content.SharedPreferences;
++import android.util.Log;
++
+ import androidx.annotation.Nullable;
+ import androidx.annotation.VisibleForTesting;
+-import android.util.Log;
++import androidx.appcompat.app.AlertDialog;
+
+ import java.lang.ref.WeakReference;
+ import java.util.concurrent.TimeUnit;
+
+-import androidx.appcompat.app.AlertDialog;
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.core.util.IntentUtils;
+ ",Please don't touch unrelated files to keep the git history clean,Could you revert your changes to this file? It looks like unnecessary changes.
+4641,"@@ -0,0 +1,19 @@
++module AbTests
++  class LandingHeadlineTest < Base
++    def setup
++      variation(ab_test(test_name, ""orig"", ""v1""))
++    end
++
++    def finish
++      finished(test_name)
++    end
++
++  private
++
++    def variation(key)
++      # The :name value isn't needed in all variations. Passing it when it is
++      # not needed allows for simpler code and will do no harm.
++      I18n.t(""headlines.landing.#{key}"", name: I18n.t('shared.subscription.name'))
++    end
++  end
++end","Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that?",Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+4642,"@@ -54,7 +54,7 @@ def gen_gaussian_target(heatmap, center, radius, k=1):
+     masked_heatmap = heatmap[y - top:y + bottom, x - left:x + right]
+     masked_gaussian = gaussian_kernel[radius - top:radius + bottom,
+                                       radius - left:radius + right]
+-    out_heatmap = torch.zeros_like(heatmap)
++    out_heatmap = heatmap
+     torch.max(
+         masked_heatmap,
+         masked_gaussian * k,",Will this change the input `heatmap`? Is this behavior expected or not?,Can this just be `torch.zeros(heatmap)`?
+4643,"@@ -411,7 +411,7 @@ func init() {
+ 	runtime.RegisterPackageValue(""strings"", ""lastIndex"",
+ 		generateDualArgStringFunctionReturnInt(""lastIndex"", []string{stringArgV, substr}, strings.LastIndex))
+ 	runtime.RegisterPackageValue(""strings"", ""lastIndexAny"",
+-		generateDualArgStringFunctionReturnInt(""lastIndexAny"", []string{stringArgV, substr}, strings.LastIndexAny))
++		generateDualArgStringFunctionReturnInt(""lastIndexAny"", []string{stringArgV, chars}, strings.LastIndexAny))
+ 	runtime.RegisterPackageValue(""strings"", ""isDigit"",
+ 		generateUnicodeIsFunction(""isDigit"", unicode.IsDigit))
+ 	runtime.RegisterPackageValue(""strings"", ""isLetter"",","If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now?","actually, `generateDualArgStringFunctionReturnInt` will do `chars` instead of "
+4644,"@@ -1,8 +1,3 @@
+-/*
+-   Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-   SPDX-License-Identifier: Apache-2.0
+-*/
+-
+ package com.spring.sns;
+
+ import org.springframework.beans.factory.annotation.Autowired;",Need copyright/license info.,Could you revert the change to the license?
+4645,"@@ -3,10 +3,8 @@ package admissioncontroller
+ import (
+ 	""fmt""
+ 	""net/http""
+-	""strings""
+
+ 	admissionv1beta1 ""k8s.io/api/admission/v1beta1""
+-	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/klog/v2""
+
+ 	rulesv1 ""github.com/kubeedge/kubeedge/cloud/pkg/apis/rules/v1""","Is this `info log` necessary? If it is not useful, can you consider deleting it?",you don't need the second argument if you r
+4646,"@@ -103,7 +103,7 @@ func TestConfigLoadEncryptedFailures(t *testing.T) {
+ 	err = config.Data().Load()
+ 	require.Error(t, err)
+
+-	// This file contains invalid base64 characters.
++	// This file's header starts with RCLONE_ENCRYPT_V1 instead of V0.
+ 	assert.NoError(t, config.SetConfigPath(""./testdata/enc-too-new.conf""))
+ 	err = config.Data().Load()
+ 	require.Error(t, err)","Unrelated change, but seems to be the correct purpose of the test.",Does this start with `RCLONE_`?
+4647,"@@ -142,6 +142,7 @@ module.exports = class DragDrop extends Plugin {
+     const restrictions = this.uppy.opts.restrictions
+     return (
+       <input
++        id={'input-' + this.id}
+         class=""uppy-DragDrop-input""
+         type=""file""
+         tabindex={-1}",Should it be `'uppy-input-`?,"Hmm, do we need that? Can't we just do a `d"
+4648,"@@ -191,7 +191,7 @@ static inline double mtrace(int n,double A[8][8],double B[8][8]) {
+
+ void PairMGPT::make_triplet(bond_data *ij_bond,bond_data *ik_bond,
+                              triplet_data *triptr) {
+-  if (1) {
++  if (true) {
+     const trmul_fun tr_mul = linalg.tr_mul;
+     tr_mul(&(ij_bond->H.m[1][0]), &(ik_bond->H.m[1][0]) ,&(triptr->H1H2.m[1][0]) );
+     tr_mul(&(ij_bond->Hx.m[1][0]),&(ik_bond->H.m[1][0]) ,&(triptr->H1xH2.m[1][0]));",what's the reasoning to keep these always true or dead-code blocks?,I suppose the `if (true)` here is superfluous because the `if (1)` is already inside the `if (true)` block.
+4649,"@@ -351,4 +351,13 @@ $(document).ready(function() {
+             }
+         });
+     }
++
++    $('body').on('click', '.tab-buttons > div', function() {
++        if ($(this).next().length === 1) {
++            $('.widget-content').addClass('hide-zoom');
++        }
++        else {
++            $('.widget-content').removeClass('hide-zoom');
++        }
++    });
+ });","It would be a good practice to do `.off('click', '.tab-buttons > div').on('click', '.tab-buttons > div', function() {`",no need to use jQuery here.
+4650,"@@ -307,9 +307,12 @@ func buildControllerContext(ctx context.Context, opts *options.ControllerOptions
+ 		KubeSharedInformerFactory: kubeSharedInformerFactory,
+ 		SharedInformerFactory:     sharedInformerFactory,
+ 		GWShared:                  gwSharedInformerFactory,
+-		Namespace:                 opts.Namespace,
+-		Clock:                     clock.RealClock{},
+-		Metrics:                   metrics.New(log, clock.RealClock{}),
++		// TODO (@jakexks) / code reviewer: should this be automatically enabled or disabled based on discovering the gateway
++		// api or a flag?
++		GatewaySolverEnabled: true,
++		Namespace:            opts.Namespace,
++		Clock:                clock.RealClock{},
++		Metrics:              metrics.New(log, clock.RealClock{}),
+ 		ACMEOptions: controller.ACMEOptions{
+ 			HTTP01SolverImage:                 opts.ACMEHTTP01SolverImage,
+ 			HTTP01SolverResourceRequestCPU:    HTTP01SolverResourceRequestCPU,","I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 should also use this `GatewaySolverEnabled` flag I think.",@jackfrancis I remember you talking about this yesterday. What do you think about this? Should it be disabl
+4651,"@@ -1180,6 +1180,7 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+
+     try {
+       configureLogging(true);
++      instantiateSignatureAlgorithmFactory();
+       configureNativeLibs();
+       logger.info(""Starting Besu version: {}"", BesuInfo.nodeName(identityString));
+       // Need to create vertx after cmdline has been parsed, such that metricsSystem is configurable","I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu.",Why do we need to instantiate it here? It looks like we can just instantiate it in `configureNativeLibs()`?
+4652,"@@ -1,11 +1,16 @@
++from typing import TYPE_CHECKING
++
+ from astroid import nodes
+
+ from pylint.checkers import BaseChecker
+ from pylint.interfaces import IAstroidChecker
+
++if TYPE_CHECKING:
++    from pylint.lint import PyLinter
+
+-# This is our checker class.
+ # Checkers should always inherit from `BaseChecker`.
++
++
+ class MyAstroidChecker(BaseChecker):
+     """"""Add class member attributes to the class local's dictionary.""""""
+ ",Why remove this?,Why do we need this?
+4653,"@@ -490,6 +490,18 @@ class Builder {
+     return this;
+   }
+
++  /**
++   * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
++   * child process when creating IE sessions locally.
++   *
++   * @param {ie.ServiceBuilder} service the service to use.
++   * @return {!Builder} a self reference.
++   */
++  setIeService(service) {
++    this.ieService_ = service;
++    return this;
++  }
++
+   /**
+    * Set {@linkplain edge.Options options} specific to Microsoft's Edge browser
+    * for drivers created by this builder. Any proxy settings defined on the",`this.ieService_` should be initialized to null in the constructor.,Nit: I think camelCa
+4654,"@@ -394,7 +394,7 @@ int main(int argc, char **argv)
+         cflags.push_back(generate_header_filter_cflag(response_header_filters));
+     }
+
+-    ebpf::BPF *bpf = new ebpf::BPF();
++    std::unique_ptr<ebpf::BPF> bpf(new ebpf::BPF());
+     std::vector<ebpf::USDT> probes;
+
+     bool selective_tracing = false;","Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value.",What's the point of
+4655,"@@ -19,8 +19,11 @@ package controller
+ import (
+ 	""errors""
+ 	""fmt""
++	""strings""
+ 	""time""
+
++	apiutil ""github.com/jetstack/cert-manager/pkg/api/util""
++
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+
+ 	cmapi ""github.com/jetstack/cert-manager/pkg/apis/certmanager/v1""",nit: move to last block,Please add gitea cop
+4656,"@@ -15,8 +15,8 @@ import (
+ 	""syscall""
+
+ 	""github.com/hashicorp/hcl""
+-	""github.com/spiffe/spire/helpers""
+ 	""github.com/spiffe/spire/pkg/agent""
++	""github.com/spiffe/spire/pkg/common/logger""
+ )
+
+ const (","nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces",This import seems to be at incorrect place.
+4657,"@@ -272,6 +272,12 @@ namespace NLog.Targets
+         [ArrayParameter(typeof(DatabaseParameterInfo), ""parameter"")]
+         public IList<DatabaseParameterInfo> Parameters { get; } = new List<DatabaseParameterInfo>();
+
++        /// <summary>
++        /// Configures isolated transaction batch writing. If supported by the database, then it will improve insert performance.
++        /// </summary>
++        /// <docgen category='Performance Tuning Options' order='10' />
++        public System.Data.IsolationLevel? IsolationLevel { get; set; }
++
+ #if !NETSTANDARD
+         internal DbProviderFactory ProviderFactory { get; set; }
+ ",Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss?,Do we really need to expose this property?
+4658,"@@ -24,15 +24,8 @@ var (
+
+ // Action is the action can be Executed in protocols. The method is added to avoid mistakenly used empty interface as action.
+ type Action interface {
+-	SetEnvelopeContext(SealedEnvelope)
+-	SanityCheck() error
+-}
+-
+-type actionPayload interface {
+-	Serialize() []byte
+ 	Cost() (*big.Int, error)
+ 	IntrinsicGas() (uint64, error)
+-	SetEnvelopeContext(SealedEnvelope)
+ 	SanityCheck() error
+ }
+ ",do we still need SanityCheck()? seems they all return nil now,why remove this?
+4659,"@@ -94,7 +94,6 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
+    * @type {HTMLElement}
+    */
+   this.rootElement = rootElement;
+-  /* eslint-enable jsdoc/require-description-complete-sentence */
+   /**
+    * The nearest document over container.
+    *","What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is legacy.",Not needed anymore.
+4660,"@@ -48,4 +48,4 @@ doc.css(""h1, h2, h3, h4, h5, h6"").each do |header|
+ end
+
+ puts ""\n==================================================\n""
+-puts ""!!! Don't forget to set a summary: https://#{ENV.fetch(""APP_DOMAIN"")}/admin/video/#{video.id}/edit""
++puts ""!!! Don't forget to set a summary: https://thoughtbot.com/upcase/admin/video/#{video.id}/edit""",Line is too long. [100/80],Please don't forget to remove the `/admin/video/#{video.id}/edit`
+4661,"@@ -532,8 +532,12 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
+ 		return err
+ 	}
+
+-	if !gopts.JSON && parentSnapshotID != nil {
+-		p.V(""using parent snapshot %v\n"", parentSnapshotID.Str())
++	if !gopts.JSON {
++		if parentSnapshotID != nil {
++			p.P(""using parent snapshot %v\n"", parentSnapshotID.Str())
++		} else {
++			p.P(""no parent snapshot found, will read all files\n"")
++		}
+ 	}
+
+ 	selectByNameFilter := func(item string) bool {","I suggest ""no parent snapshot found, will read all data\n"".",Is this a specific scenario that should be handled here?
+4662,"@@ -48,9 +48,7 @@ namespace NLog.UnitTests
+         {
+             using (new NoThrowNLogExceptions())
+             {
+-                LogManager.ThrowExceptions = true;
+-
+-                LogManager.Configuration = XmlLoggingConfiguration.CreateFromXmlString(@""
++                var config = XmlLoggingConfiguration.CreateFromXmlString(@""
+                 <nlog throwExceptions='false'>
+                     <targets><target type='MethodCall' name='test' methodName='Throws' className='NLog.UnitTests.LogFactoryTests, NLog.UnitTests.netfx40' /></targets>
+                     <rules>",`LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load?,@cra0zy do we still need this?
+4663,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return ""'"" + value + ""'"";
+ 	} else {
+-		return '""""';
++		return ""'"";
+ 	}
+ }
+ ","It should be return ""''""; I will fix it",any reason not to use single quotes here?
+4664,"@@ -100,11 +100,10 @@ public class AcceptanceTest extends STBBaseTst {
+         ASTMethodDeclaration node = acu.findDescendantsOfType(ASTMethodDeclaration.class).get(0);
+         Scope s = node.getScope();
+         Map<NameDeclaration, List<NameOccurrence>> m = s.getDeclarations();
+-        for (Iterator<NameDeclaration> i = m.keySet().iterator(); i.hasNext();) {
+-            NameDeclaration d = i.next();
+-            assertEquals(""buz"", d.getImage());
+-            assertEquals(""ArrayList"", ((TypedNameDeclaration) d).getTypeImage());
+-            List<NameOccurrence> u = m.get(d);
++        for (Map.Entry<NameDeclaration, List<NameOccurrence>> entry : m.entrySet()) {
++            assertEquals(""buz"", entry.getKey().getImage());
++            assertEquals(""ArrayList"", ((TypedNameDeclaration) entry.getKey()).getTypeImage());
++            List<NameOccurrence> u = m.get(entry.getKey());
+             assertEquals(1, u.size());
+             NameOccurrence o = u.get(0);
+             int beginLine = o.getLocation().getBeginLine();","This is wrong, should be `entry.getValue()`","It would make sense to replace this with `assertThat(entry.getValue(), equalTo(Collections.emptyList()))`"
+4665,"@@ -363,7 +363,7 @@ func (r *ReconcileControlPlaneCerts) getServingCertificatesJSONPatch(cd *hivev1.
+ 			additional.Domain, remoteSecretName(bundle.CertificateSecretRef.Name, cd)))
+ 	}
+
+-	var kubeAPIServerNamedCertsTemplate = `[ { ""op"": ""replace"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [ %s ] } ]`
++	var kubeAPIServerNamedCertsTemplate = `[ { ""op"": ""add"", ""path"": ""/spec/servingCerts"", ""value"": {} }, { ""op"": ""add"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [  ] }, { ""op"": ""replace"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [ %s ] } ]`
+ 	namedCerts := buf.String()
+ 	return fmt.Sprintf(kubeAPIServerNamedCertsTemplate, namedCerts), nil
+ ","nit: why can't we combine the two add operations into one so that we add `{""nameCertificates"": []}` to `/spec/servingCerts` ?",@deads2k any reason why you had to make this change?
+4666,"@@ -3,13 +3,14 @@
+ // See the LICENSE file in the project root for more information.
+
+ // ==++==
+-//
+-
+-//
++//
++
++//
+ // ==--==
+ #include <assert.h>
+ #include ""sos.h""
+ #include ""safemath.h""
++#include ""holder.h""
+
+
+ // This is the increment for the segment lookup data",These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs.,nit: is this change required?
+4667,"@@ -19,11 +19,13 @@ public abstract class RoomHandler
+
+ 	protected final Client client;
+ 	protected final TheatrePlugin plugin;
++	protected final TheatreConfig config;
+
+-	protected RoomHandler(final Client client, final TheatrePlugin plugin)
++	protected RoomHandler(final Client client, final TheatrePlugin plugin, TheatreConfig config)
+ 	{
+ 		this.client = client;
+ 		this.plugin = plugin;
++		this.config = config;
+ 	}
+
+ 	public abstract void onStart();",why does this suddenly need a config ref,"Instead of passing the config through the constructor, why not just pass the `plugin` field directly to t"
+4668,"@@ -99,6 +99,10 @@ module.exports = function(config) {
+ 		customLaunchers: sauceLabs ? sauceLabsLaunchers : travisLaunchers,
+
+ 		files: [
++			// We can't load this up front because it's ES2015 and we need it only
++			// for certain tests that run under those conditions. We also can't load
++			// it via CDN because { included: false } won't work.
++			{ pattern: 'custom-elements-es5-adapter.js', included: false },
+ 			{ pattern: 'polyfills.js', watched: false },
+ 			{ pattern: '{browser,shared}/**.js', watched: false }
+ 		],","Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it.",Can we move this to a central location so it doesn't need to be re-created every time?
+4669,"@@ -67,6 +67,10 @@ exclude = [""AuthalicMatrixCoefficients"",
+            ""vnl_file_matrix"",
+            ""vnl_file_vector"",
+            ""vnl_fortran_copy"",
++           ""CosineWindowFunction"",
++           ""HammingWindowFunction"",
++           ""LanczosWindowFunction"",
++           ""WelchWindowFunction"",
+            ]
+
+ total = 0","Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now).",why do we need to add these?
+4670,"@@ -27,7 +27,7 @@ import (
+ // This little bit of wrapping needs to be done because go doesn't do
+ // covariance, but it does coerce *time.Timer into stoppable implicitly if we
+ // write it out like so.
+-var afterFunc = func(c clock.Clock, d time.Duration, f func()) stoppable {
++func afterFunc(c clock.Clock, d time.Duration, f func()) stoppable {
+ 	t := c.NewTimer(d)
+
+ 	go func() {","Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability?",Why did this change?
+4671,"@@ -27,8 +27,7 @@ MolDraw2DQt::MolDraw2DQt(int width, int height, QPainter &qp, int panelWidth,
+ // ****************************************************************************
+ void MolDraw2DQt::setColour(const DrawColour &col) {
+   MolDraw2D::setColour(col);
+-  QColor this_col(int(255.0 * col.get<0>()), int(255.0 * col.get<1>()),
+-                  int(255.0 * col.get<2>()));
++  QColor this_col(int(255.0 * col.r), int(255.0 * col.g), int(255.0 * col.b));
+
+   QPen pen(this_col);
+   pen.setJoinStyle(Qt::RoundJoin);",I'm assuming that MolDraw2Qt drops the alpha channel?,Shouldn't this be 255.0 * col.get<3>() ?
+4672,"@@ -24,6 +24,9 @@ namespace System.Text.Json.Serialization.Tests
+     [GenericTypeArguments(typeof(HashSet<string>))]
+     [GenericTypeArguments(typeof(ArrayList))]
+     [GenericTypeArguments(typeof(Hashtable))]
++    [GenericTypeArguments(typeof(SimpleStructWithProperties))]
++    [GenericTypeArguments(typeof(LargeStructWithProperties))]
++    [GenericTypeArguments(typeof(int))]
+     public class ReadJson<T>
+     {
+         private string _serialized;","the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer.",Do we have tests for this?
+4673,"@@ -472,7 +472,18 @@ class Composition(collections.Hashable, collections.Mapping, MSONable):
+
+         Returns:
+             Composition with that formula.
++
++        Notes:
++            In the case of Metallofullerene formula (e.g. Y3N@C80),
++            the @ mark will be dropped and passed to parser.
+         """"""
++        print(formula)
++        # for Metallofullerene like ""Y3N@C80""
++        if ""@"" in formula:
++            print(formula)
++            formula = formula.replace(""@"", """")
++            print(formula)
++
+         def get_sym_dict(f, factor):
+             sym_dict = collections.defaultdict(float)
+             for m in re.finditer(r""([A-Z][a-z]*)\s*([-*\.\d]*)"", f):","Pls remove the print statements. Also, you do not need the if statement.",Please remove the `print`
+4674,"@@ -112,7 +112,7 @@ def patch_moto():
+
+     # escape message responses to allow for special characters like ""<""
+     sqs_responses.RECEIVE_MESSAGE_RESPONSE = sqs_responses.RECEIVE_MESSAGE_RESPONSE.replace(
+-        ""<StringValue>{{ value.string_value }}</StringValue>"",
++        ""<StringValue><![CDATA[{{ value.string_value }}]]></StringValue>"",
+         ""<StringValue>{{ _escape(value.string_value) }}</StringValue>"",
+     )
+ ","Thanks for this fix @eltone !   Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks",Is there a reason for usin
+4675,"@@ -91,6 +91,7 @@ func newSimpleClientV7(url string) (*clientV7, error) {
+ 	var err error
+ 	if client, err = elastic.NewClient(
+ 		elastic.SetURL(url),
++		elastic.SetSniff(false),
+ 		elastic.SetRetrier(retrier),
+ 	); err != nil {
+ 		return nil, err",Should this be instead a configurable option?,Why is this false by defau
+4676,"@@ -64,6 +64,13 @@ func (c *CreateDisks) run(ctx context.Context, s *Step) DError {
+ 				}
+ 			}
+
++			// Get the source snapshot link if using a source snapshot.
++			if cd.SourceSnapshot != """" {
++				if snapshot, ok := w.snapshots.get(cd.SourceSnapshot); ok {
++					cd.SourceSnapshot = snapshot.link
++				}
++			}
++
+ 			w.LogStepInfo(s.name, ""CreateDisks"", ""Creating disk %q."", cd.Name)
+ 			if err := w.ComputeClient.CreateDisk(cd.Project, cd.Zone, &cd.Disk); err != nil {
+ 				// Fallback to pd-standard to avoid quota issue.",unit test needs an update?,"Can we only set the `SourceSnapshot` field if `sourceSnapshot != """"`?"
+4677,"@@ -12,7 +12,6 @@ module.exports = class Provider extends RequestClient {
+     super(uppy, opts)
+     this.provider = opts.provider
+     this.id = this.provider
+-    this.authProvider = opts.authProvider || this.provider
+     this.name = this.opts.name || _getName(this.id)
+     this.pluginId = this.opts.pluginId
+     this.tokenKey = `companion-${this.pluginId}-auth-token`",I realised that this is not used anywhere,Is this not needed anymore?
+4678,"@@ -187,6 +187,7 @@ func watchConfig(cfg *config.Config, stopCh <-chan struct{}) {
+ 				case <-stopCh:
+ 					close(sigChan)
+ 					return
++				default:
+ 				}
+ 			}
+ 		}()",why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time?,Wouldn't we still want to return here?
+4679,"@@ -1477,6 +1477,8 @@ func handleUSB(intr interrupt.Interrupt) {
+ 			// clear stall request
+ 			setEPINTENCLR(0, sam.USB_DEVICE_EPINTENCLR_STALL1)
+ 		}
++	} else {
++		sendZlp()
+ 	}
+
+ 	// Now the actual transfer handlers, ignore endpoint number 0 (setup)",This line appears to have caused the regression. What is it supposed to be doing?,Don't we need to clear the stall request in this case?
+4680,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done,"The `attr_value` argument is a dict and not a dict, so `attr_value['string'] is not None` is always true."
+4681,"@@ -39,13 +39,11 @@ namespace OpenTelemetry.Metrics
+             configure?.Invoke(options);
+
+             var exporter = new PrometheusExporter(options);
+-
+-            var metricReader = new BaseExportingMetricReader(exporter);
+-            exporter.CollectMetric = metricReader.Collect;
++            var reader = new BaseExportingMetricReader(exporter);
+
+             var metricsHttpServer = new PrometheusExporterMetricsHttpServer(exporter);
+             metricsHttpServer.Start();
+-            return builder.AddMetricReader(metricReader);
++            return builder.AddMetricReader(reader);
+         }
+     }
+ }","@alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be OKAY. A better version could be - we only start the HTTP server once the exporter/reader are fully ready and both are hooked up to the provider.",It looks like exporter.CollectMetric was set to `null` when exporter is used with `new BaseExportingMetri
+4682,"@@ -224,7 +224,13 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore
+
+                 if (!process.HasExited)
+                 {
+-                    process.Kill();
++                    // Try shutting down gracefully
++                    await SubmitRequest(aspNetCorePort, ""/shutdown"");
++
++                    if (!process.WaitForExit(5000))
++                    {
++                        process.Kill();
++                    }
+                 }
+
+                 SpanTestHelpers.AssertExpectationsMet(Expectations, spans);","As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too?",Would it make sense to add a `await Process.WaitForExit(5000)` here?
+4683,"@@ -0,0 +1,16 @@
++using System;
++using System.Net.Http;
++
++namespace OpenTelemetry.Exporter
++{
++    public interface IHttpClientFactoryExporterOptions
++    {
++        /// <summary>
++        /// Gets or sets the factory function called to create the <see
++        /// cref=""HttpClient""/> instance that will be used at runtime to
++        /// transmit telemetry over HTTP. The returned instance will be reused
++        /// for all export invocations.
++        /// </summary>
++        public Func<HttpClient> HttpClientFactory { get; set; }
++    }
++}",Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself.,Should we call this `HttpClientFactoryOptions`?
+4684,"@@ -12,6 +12,6 @@ return [
+     |
+     */
+
+-    'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'failed' => 'یہ تفصیلات درست نہیں ہیں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈ میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing,Why was this line removed?
+4685,"@@ -149,7 +149,7 @@ class KeywordArgument(object):
+     func = lambda arg=arg: arg * arg # [undefined-variable]
+
+     arg2 = 0
+-    func2 = lambda arg2=arg2: arg2 * arg2
++    func3 = lambda arg2=arg2: arg2 * arg2
+
+ # Don't emit if the code is protected by NameError
+ try:",change of name is not needed,Renamed this to make it cl
+4686,"@@ -120,10 +120,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         self.assertEqual(kser.name, ""renamed"")
+         self.assert_eq(kser, pser)
+
+-        pser.name = None
+-        kser.name = None
+-        self.assertEqual(kser.name, None)
+-        self.assert_eq(kser, pser)
++        # pser.name = None
++        # kser.name = None
++        # self.assertEqual(kser.name, None)
++        # self.assert_eq(kser, pser)
+
+         pidx = pser.index
+         kidx = kser.index",Hm .. so this case doesn't work anymore?,What's the purpose of this
+4687,"@@ -22,7 +22,8 @@
+ import os
+ import tempfile
+
+-from PyQt5.QtCore import pyqtSignal, pyqtSlot, QObject, QProcess
++from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QProcess,
++    QFileSystemWatcher)
+
+ from qutebrowser.config import config
+ from qutebrowser.utils import message, log",Please indent this so it lines up with the `(`,Please rename this file to
+4688,"@@ -23,10 +23,11 @@ function roots_scripts() {
+   if (is_single() && comments_open() && get_option('thread_comments')) {
+     wp_enqueue_script('comment-reply');
+   }
+-
+-  wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
++
++  // Not included by default since this code is used for debugging javas in the console. Uncomment next line and wp_enqueue_script below to use it.
++  //wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
+   wp_register_script('roots_main', get_template_directory_uri() . '/js/main.js', false, null, false);
+-  wp_enqueue_script('roots_plugins');
++  //wp_enqueue_script('roots_plugins');
+   wp_enqueue_script('roots_main');
+ }
+ ",We should still register the script. Just not enqueue it.,Can we remove this code?
+4689,"@@ -20,7 +20,7 @@ module Mongoid #:nodoc:
+     def changes
+       {}.tap do |hash|
+         changed.each do |name|
+-          change = attribute_change(name)
++          change = [changed_attributes[name], attributes[name]] if attribute_changed?(name)
+           hash[name] = change if change[0] != change[1]
+         end
+       end",I think this can stay as a method. And we can write our own attribute_change(name) as required.,Use 2 (not 0) spaces for
+4690,"@@ -142,7 +142,8 @@ namespace MvvmCross.DroidX.RecyclerView
+
+         protected virtual View InflateViewForHolder(ViewGroup parent, int viewType, IMvxAndroidBindingContext bindingContext)
+         {
+-            return bindingContext.BindingInflate(viewType, parent, false);
++            var layoutId = ItemTemplateSelector.GetItemLayoutId (viewType);
++            return bindingContext.BindingInflate(layoutId, parent, false);
+         }
+
+         public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position)","@alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which makes sense - the template selector can return the layout id based on the index of the item in the list.",Can't you use the cached
+4691,"@@ -96,6 +96,9 @@ class BQTable(collections.namedtuple('BQTable', 'project_id dataset_id table_id'
+         return ""bq://"" + self.project_id + ""/"" + \
+                self.dataset.dataset_id + ""/"" + self.table_id
+
++    def __str__(self):
++        return ""%s:%s.%s"" % (self.project_id, self.dataset_id, self.table_id)
++
+
+ class BigqueryClient(object):
+     """"""A client for Google BigQuery.",Can you change this to use `.format()`?,I do not think we should
+4692,"@@ -308,13 +308,15 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+
+-	if dropEncap {
++	if dropEncap && r.Config.DropVXLANPacketsFromWorkloads {
+ 		rules = append(rules, Rule{
+ 			Match: Match().ProtocolNum(ProtoUDP).
+ 				DestPorts(uint16(r.Config.VXLANPort)),
+ 			Action:  DropAction{},
+ 			Comment: []string{""Drop VXLAN encapped packets originating in pods""},
+ 		})
++	}
++	if dropEncap && r.Config.DropIPIPPacketsFromWorkloads {
+ 		rules = append(rules, Rule{
+ 			Match:   Match().ProtocolNum(ProtoIPIP),
+ 			Action:  DropAction{},",Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set?,Would you mind making a new rule for VXLAN packets instead of dropEncap?
+4693,"@@ -47,11 +47,11 @@ type SectorBuilder interface {
+ 	// which will fit into a newly-provisioned staged sector.
+ 	GetMaxUserBytesPerStagedSector() (uint64, error)
+
+-	// GeneratePoST creates a proof-of-spacetime for the replicas managed by
++	// GeneratePoSt creates a proof-of-spacetime for the replicas managed by
+ 	// the SectorBuilder. Its output includes the proof-of-spacetime proof which
+ 	// is posted to the blockchain along with any faults. The proof can be
+ 	// verified by the VerifyPoSt method on the Verifier interface.
+-	GeneratePoST(GeneratePoSTRequest) (GeneratePoSTResponse, error)
++	GeneratePoSt(GeneratePoStRequest) (GeneratePoStResponse, error)
+
+ 	// Close signals that this SectorBuilder is no longer in use. SectorBuilder
+ 	// metadata will not be deleted when Close is called; an equivalent",new casing is less ELiTE,Why did you rename this method?
+4694,"@@ -179,6 +179,14 @@ bool wlr_renderer_blit_dmabuf(struct wlr_renderer *r,
+ 	return r->impl->blit_dmabuf(r, dst, src);
+ }
+
++GLuint wlr_renderer_renderbuffer_from_image(struct wlr_renderer *r,
++		EGLImageKHR image) {
++	if (!r->impl->renderbuffer_from_image) {
++		return false;
++	}
++	return r->impl->renderbuffer_from_image(image);
++}
++
+ bool wlr_renderer_format_supported(struct wlr_renderer *r,
+ 		enum wl_shm_format fmt) {
+ 	return r->impl->format_supported(r, fmt);",This leaks EGL/GL implementation details into the generic renderer interface.,"Shouldn't this be `wlr_renderer_renderbuffer_from_image(r, image);` ?"
+4695,"@@ -32,6 +32,16 @@ module Travis
+       end
+     end
+
++    class DeployConditionError < DeployConfigError
++      def initialize(msg = ""The \\`deploy.on\\` should be a hash (dictionary)."")
++        super
++      end
++
++      def doc_path
++        '/user/deployment#Conditional-Releases-with-on%3A'
++      end
++    end
++
+     class AptSourcesConfigError < CompilationError
+       def initialize(msg = ""\\`apt\\` should be a hash with key \\`sources\\` and an array as a value."")
+         super","Maybe add *key* i.e. `""The \\`deploy.on\\` key should be a hash (dictionary).`",This should probably be `/user/deployment#Conditional-Releases-with-on/`
+4696,"@@ -75,7 +75,7 @@ class StatusGridBuilder implements GridBuilderInterface
+     {
+         $result = [];
+         foreach ($this->statusQuery->getAllStatuses($language) as $code => $status) {
+-            $result[] = new StatusOption($code, $code, new Color($status['color']), $status['name']);
++            $result[] = new StatusOption($code, $status['code'], new Color($status['color']), $status['name']);
+         }
+
+         return $result;","its be good also change $code na $id, actual name is misleading and that was probably actual error generator","Shouldn't it be `$this->statusQuery->getAllStatuses($language)`, $this->statusQuery->getAllStatuses($language) can return multiple statuses ?"
+4697,"@@ -10,9 +10,8 @@ from listenbrainz.listenstore import ListenStore
+
+ class RedisListenStore(ListenStore):
+
+-    RECENT_LISTENS_KEY = ""lb_recent_listens""
+-    RECENT_LISTENS_MAX = 100
+-    RECENT_LISTENS_MAX_TIME_DIFFERENCE = 300
++    RECENT_LISTENS_KEY = ""lb_recent_sorted""
++    RECENT_LISTENS_MAX = 100
+
+     def __init__(self, log, conf):
+         super(RedisListenStore, self).__init__(log)","I changed the name of the key, to make deployment easier.",Why did we remove the time difference here? Do we still need it?
+4698,"@@ -545,6 +545,7 @@ func environmentConfig() (Config, error) {
+ 		NvidiaRuntime:                       os.Getenv(""ECS_NVIDIA_RUNTIME""),
+ 		TaskMetadataAZDisabled:              utils.ParseBool(os.Getenv(""ECS_DISABLE_TASK_METADATA_AZ""), false),
+ 		CgroupCPUPeriod:                     parseCgroupCPUPeriod(),
++		SpotInstanceDrainingEnabled:         utils.ParseBool(os.Getenv(""ECS_SPOT_INSTANCE_DRAINING_ENABLED""), false),
+ 	}, err
+ }
+ ","isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false.","nit: the `aws_spot_instance` prefix is used in other places in this file, can we use the same prefix here?"
+4699,"@@ -3,6 +3,8 @@ Provides Dimension objects for tracking the properties of a value,
+ axis or map dimension. Also supplies the Dimensioned abstract
+ baseclass for classes that accept Dimension values.
+ """"""
++from __future__ import unicode_literals
++
+ import re
+ from operator import itemgetter
+ ",Do you think we might need this anywhere else in HoloViews?,Why do you need this? The `from __future__ import unicode_literals` line should be enough.
+4700,"@@ -3,7 +3,9 @@ export function getDisplayPlayMethod(session) {
+         return null;
+     }
+
+-    if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
++    if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect && session.TranscodingInfo.IsAudioDirect) {
++        return 'Remux';
++    } else if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
+         return 'DirectStream';
+     } else if (session.PlayState.PlayMethod === 'Transcode') {
+         return 'Transcode';",@MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case.,shouldn't session.TranscodingInfo.IsVideoDirect be enough here?
+4701,"@@ -36,7 +36,7 @@ module Asciidoctor
+         opts_parser = OptionParser.new do |opts|
+           opts.banner = <<-EOS
+ Usage: asciidoctor [OPTION]... [FILE]
+-Translate the AsciiDoc source FILE into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
++Translate the AsciiDoc source FILE, or multiple FILE(s) into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
+ By default, the output is written to a file with the basename of the source file and the appropriate extension.
+ Example: asciidoctor -b html5 source.asciidoc
+ ",I have followed the convention of `cp`,Line is too long. [88/80]
+4702,"@@ -8390,11 +8390,11 @@ return [
+ 'mysql_xdevapi\tableupdate::where' => ['mysql_xdevapi\TableUpdate', 'where_expr'=>'string'],
+ 'mysqli::__construct' => ['void', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null'],
+ 'mysqli::autocommit' => ['bool', 'enable'=>'bool'],
+-'mysqli::begin_transaction' => ['bool', 'flags='=>'int', 'name='=>'string'],
++'mysqli::begin_transaction' => ['bool', 'flags='=>'int', 'name='=>'?string'],
+ 'mysqli::change_user' => ['bool', 'username'=>'string', 'password'=>'string', 'database'=>'string'],
+ 'mysqli::character_set_name' => ['string'],
+ 'mysqli::close' => ['bool'],
+-'mysqli::commit' => ['bool', 'flags='=>'int', 'name='=>'string'],
++'mysqli::commit' => ['bool', 'flags='=>'int', 'name='=>'?string'],
+ 'mysqli::connect' => ['bool', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null'],
+ 'mysqli::debug' => ['bool', 'options'=>'string'],
+ 'mysqli::disable_reads_from_master' => ['bool'],",The docs say it's `false|null`,What is the purpose of this change?
+4703,"@@ -130,9 +130,14 @@ func (c *localCircuitBreaker) checkAndSet() {
+
+ // Config represents the configuration of a circuit breaker.
+ type Config struct {
++	// The threshold over sliding window that would trip the circuit breaker
+ 	Threshold float64 `json:""threshold""`
+-	Type      string  `json:""type""`
+-	TripTime  string  `json:""trip_time""`
++	// Possible values: latency, error_ratio, and status_ratio. It
++	// defaults to latency.
++	Type string `json:""type""`
++	// How long to wait after the circuit is tripped before allowing operations to resume.
++	// The default is 5s.
++	TripTime string `json:""trip_time""`
+ }
+
+ const (","Thinking on it more, I actually really like your idea to rename `type` to `factor`.",why not using `time.Duration` here?
+4704,"@@ -45,7 +45,11 @@ public class MessageWebView extends WebView {
+          * will network images that are already in the WebView cache.
+          *
+          */
+-        getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
++        try {
++            getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
++        } catch(SecurityException e) {
++            Timber.e(e, ""SecurityException in blockNetworkData(final boolean shouldBlockNetworkData)"");
++        }
+     }
+
+ ","This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I suggest changing the message to: ""Failed to unblock network loads. Missing INTERNET permission?""",This is the only change I'm not sure about. I suspect the rest of the PR is just a refactor.
+4705,"@@ -1,11 +1,9 @@
+-# -*- coding: UTF-8 -*-
+-#shlobj.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2017 NV Access Limited, Babbage B.V.
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2009-2021 NV Access Limited, Babbage B.V.
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+-""""""
++r""""""
+ This module wraps the SHGetFolderPath function in shell32.dll and defines the necessary contstants.
+ CSIDL (constant special item ID list) values provide a unique system-independent way to
+ identify special folders used frequently by applications, but which may not have the same name",Feel free to add your own name while at it.,`r` is the new recommended way of writing Rust code.
+4706,"@@ -30,11 +30,11 @@ import (
+ )
+
+ var (
+-	alias    string
+ 	bytecode []byte
+ 	gasLimit uint64
+ 	gasPrice int64
+ 	nonce    uint64
++	signer   string
+ )
+
+ // ActionCmd represents the account command",`signer` is a global variable (from `gochecknoglobals`),The alias is not used any more after this change.
+4707,"@@ -74,8 +74,12 @@ module Mongoid
+         # @return [ String ] The normalized key.
+         #
+         # @since 1.0.0
+-        def normalized_key(name, serializer)
+-          serializer && serializer.localized? ? ""#{name}.#{::I18n.locale}"" : name
++        def normalized_key(name, serializer, opts = {})
++          if serializer && serializer.localized? && opts[:localize] != false
++            ""#{name}.#{::I18n.locale}""
++          else
++            name
++          end
+         end
+
+         # Get the pair of objects needed to store the value in a hash by the",shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?),Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation
+4708,"@@ -17,6 +17,7 @@ from .number_types import (UOffsetTFlags, SOffsetTFlags, VOffsetTFlags)
+
+ from . import encode
+ from . import packer
++import pickle
+
+ from . import compat
+ from .compat import range_func",This can also be removed.,Did you mean to add this import here?
+4709,"@@ -32,7 +32,8 @@ SYNOPSIS
+                           const char *key);
+
+  int flux_kvs_txn_symlink (flux_kvs_txn_t *txn, int flags,
+-                           const char *key, const char *target);
++                           const char *key, const char *ns,
++                           const char *target);
+
+  int flux_kvs_txn_put_raw (flux_kvs_txn_t *txn, int flags,
+                            const char *key, const void *data, int len);","Not critical but ""common"" is not that helpful in the commit title. Maybe go with ""libkvs/txn:"" for this one?",can we call this `namespace` to be co
+4710,"@@ -277,6 +277,7 @@ class YamlConfig(QObject):
+             self._mark_changed()
+
+         self._migrate_bool(settings, 'tabs.favicons.show', 'always', 'never')
++        self._migrate_bool(settings, 'scrolling.bar', 'when_searching', 'never')
+         self._migrate_bool(settings, 'qt.force_software_rendering',
+                            'software-opengl', 'none')
+ ","It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new feature). I fixed this in cc0f5fc6d400e12833ba729049e31d16cf836d53.",I don't think we should migrate this
+4711,"@@ -27,7 +27,7 @@ class RRDReader(BaseReader):
+     def _convert_fs_path(fs_path):
+         if isinstance(fs_path, six.text_type):
+             fs_path = fs_path.encode(sys.getfilesystemencoding())
+-        return os.path.realpath(fs_path)
++        return os.path.realpath(fs_path).decode(""utf-8"")
+
+     def __init__(self, fs_path, datasource_name):
+         self.fs_path = RRDReader._convert_fs_path(fs_path)",.decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes..,Is there a reason we are not using `s
+4712,"@@ -0,0 +1,9 @@
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpHeadersHandler
++    {
++        void OnHeader(Span<byte> name, Span<byte> value);
++    }
++}","An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill.",I'm not sure how I feel about this one. It feels very weird to me that `IHttpHeadersHandler` is something that is supposed to be implemented as a part of this interface.
+4713,"@@ -51,15 +51,10 @@ namespace NLog
+         private const int StackTraceSkipMethods = 0;
+
+         [System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Naming"", ""CA2204:Literals should be spelled correctly"", Justification = ""Using 'NLog' in message."")]
+-        internal static void Write([NotNull] Type loggerType, TargetWithFilterChain targets, LogEventInfo logEvent, LogFactory factory)
++        internal static void Write([NotNull] Type loggerType, [NotNull] TargetWithFilterChain targetsForLevel, LogEventInfo logEvent, LogFactory factory)
+         {
+-            if (targets == null)
+-            {
+-                return;
+-            }
+-
+ #if !NETSTANDARD1_0 || NETSTANDARD1_5
+-            StackTraceUsage stu = targets.GetStackTraceUsage();
++            StackTraceUsage stu = targetsForLevel.GetStackTraceUsage();
+             if (stu != StackTraceUsage.None && !logEvent.HasStackTrace)
+             {
+ #if NETSTANDARD1_5","Resharper annotations, always +1",">targetsForLevel [](start = 72, length = 10) nit: change variable name to targetsForLogLevel"
+4714,"@@ -46,6 +46,8 @@ var accountCreateAddCmd = &cobra.Command{
+ func init() {
+ 	accountCreateAddCmd.Flags().BoolVar(&CryptoSm2, ""sm2"", false,
+ 		config.TranslateInLang(flagSm2Usage, config.UILanguage))
++	accountCreateAddCmd.Flags().MarkHidden(""sm2"")
++
+ }
+
+ func accountCreateAdd(args []string) error {","same here, CryptoSm2 won't be changed once command is compiled",Do we need a way to turn off SM2?
+4715,"@@ -655,6 +655,13 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+ 		try {
+ 			certChain = KeyChain.getCertificateChain(activity, alias);
+ 			key = KeyChain.getPrivateKey(activity, alias);
++			activity.runOnUiThread(new Runnable() {
++
++                @Override
++                public void run() {
++                	loadLoginPage();
++                }
++            });
+ 		} catch (KeyChainException e) {
+ 			e.printStackTrace();
+ 		} catch (InterruptedException e) {",Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread.,I'm not sure this is the right place to do this but I'm not sure if I have a better idea.
+4716,"@@ -52,7 +52,7 @@ func (v *ConfigValidator) Validate(config *configs.Config) error {
+ 	}
+ 	for _, c := range warns {
+ 		if err := c(config); err != nil {
+-			logrus.WithError(err).Warnf(""invalid configuration"")
++			logrus.WithError(err).Warn(""invalid configuration"")
+ 		}
+ 	}
+ 	return nil",Technically it doesn't belong here; let me remove it.,`WithError` contains a lot of information about the context of the error. Maybe it would be helpful to include the context in the message.
+4717,"@@ -78,7 +78,7 @@ MARKER_FILE_LIGHT_VERSION = ""%s/.light-version"" % dirs.static_libs
+ IMAGE_NAME_SFN_LOCAL = ""amazon/aws-stepfunctions-local""
+ ARTIFACTS_REPO = ""https://github.com/localstack/localstack-artifacts""
+ SFN_PATCH_URL_PREFIX = (
+-    f""{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunctions-local-patch""
++    f""{ARTIFACTS_REPO}/raw/b2d48a8a8715dd31de2af75b0aa04c0c0091fa3c/stepfunctions-local-patch""
+ )
+ SFN_PATCH_CLASS1 = ""com/amazonaws/stepfunctions/local/runtime/Config.class""
+ SFN_PATCH_CLASS2 = (",remember to update the hash once the upstream PR is merged  ,Is this change needed as part of this PR?
+4718,"@@ -45,10 +45,8 @@ public class SFDCFcmListenerService extends FirebaseMessagingService {
+     @Override
+     public void onMessageReceived(RemoteMessage message) {
+         if (message != null && SalesforceSDKManager.hasInstance()) {
+-            final PushNotificationInterface pnInterface = SalesforceSDKManager.getInstance().getPushNotificationReceiver();
+-            if (pnInterface != null) {
+-                pnInterface.onPushMessageReceived(message);
+-            }
++            final PushNotificationDecryptor pnDecryptor = PushNotificationDecryptor.getInstance();
++            pnDecryptor.onPushMessageReceived(message);
+         }
+     }
+ }","Sends the incoming message to the decryptor, which will then forward it to the interface once processing is complete.",Is there any reason why we can't just use a `PushNotificationReceiver` here?
+4719,"@@ -317,10 +317,15 @@ func (ctx *invocationContext) Send(toAddr address.Address, methodNum abi.MethodN
+ 		}
+ 	}()
+
++	// DRAGONS: remove these once specs actors project enforces Send params
+ 	// replace nil params with empty value
+ 	if params == nil {
+ 		params = &adt_spec.EmptyValue{}
+ 	}
++	// replace non pointer with pointer
++	if _, ok := params.(adt_spec.EmptyValue); ok {
++		params = &adt_spec.EmptyValue{}
++	}
+
+ 	// check if side-effects are allowed
+ 	if !ctx.allowSideEffects {","FYI This will go the other way, with nil being the correct value for ""no params""",Are we sure this doesn't happen often?
+4720,"@@ -162,8 +162,10 @@ namespace pwiz.Skyline.Model.Lib
+                 var thatPeptideKey = thatItem.LibraryKey as PeptideLibraryKey;
+                 if (thatPeptideKey == null)
+                 {
+-                    result.Add(thatItem.LibraryKey);
+-                    nonPeptideKeySet.Add(thatItem.LibraryKey);
++                    if (nonPeptideKeySet.Add(thatItem.LibraryKey))
++                    {
++                        result.Add(thatItem.LibraryKey); // First time we've seen it, add to list
++                    }
+                     continue;
+                 }
+                 PeptideLibraryKey[] thisKeysWithUnmodSeq;",Is this necessary? Are there duplicates in your LibKeyIndex?,@QilongTang @filipeotero do you recall the consequence of adding a new item to the list here?
+4721,"@@ -35,6 +35,7 @@ func (m *MockActionIterator) EXPECT() *MockActionIteratorMockRecorder {
+
+ // Next mocks base method
+ func (m *MockActionIterator) Next() (action.SealedEnvelope, bool) {
++	m.ctrl.T.Helper()
+ 	ret := m.ctrl.Call(m, ""Next"")
+ 	ret0, _ := ret[0].(action.SealedEnvelope)
+ 	ret1, _ := ret[1].(bool)",Why will the gomock files be regenerated? It seems to be irrelevant,Shouldn't `m.ctrl.T.Helper()` be enough?
+4722,"@@ -97,6 +97,7 @@ func newPlanner(
+ 		pipedConfig:              pipedConfig,
+ 		plannerRegistry:          registry.DefaultRegistry(),
+ 		appManifestsCache:        appManifestsCache,
++		cancelledCh:              make(chan *model.ReportableCommand, 1),
+ 		nowFunc:                  time.Now,
+ 		logger:                   logger,
+ 	}",I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity?,"Doesn't have to be part of this PR, but I'm curious why you needed to make a channel here. Wh"
+4723,"@@ -14,7 +14,7 @@
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+ #
+-from helpers import LuigiTestCase
++from helpers import LuigiTestCase, RunOnceTask
+
+ import luigi
+ import luigi.task",It seems like you accidentally pulled some unrelated changes to util_test into this.,F401 'RunOnceTask' imported but unused
+4724,"@@ -15,6 +15,7 @@
+ //  along with the Nethermind. If not, see <http://www.gnu.org/licenses/>.
+
+ using Nethermind.Blockchain;
++using Nethermind.Blockchain.Bloom;
+ using Nethermind.Blockchain.Filters;
+ using Nethermind.Blockchain.Receipts;
+ using Nethermind.Blockchain.TxPools;",do not toucm NDM please - there will be lots of conflicts,I think this bloom filter should be moved to its own file.
+4725,"@@ -357,7 +357,7 @@ class XLSXWriter extends TextResponseWriter {
+       if (v instanceof IndexableField) {
+         IndexableField f = (IndexableField)v;
+         if (v instanceof Date) {
+-          output.append(((Date) val).toInstant().toString() + ""; "");
++          output.append(((Date) v).toInstant().toString() + ""; "");
+         } else {
+           output.append(f.stringValue() + ""; "");
+         }",This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild?,"This is a bug fix, unrelated to this PR."
+4726,"@@ -48,6 +48,8 @@ class Testinfra(base.Base):
+           name: testinfra
+           options:
+             n: 1
++            v: True
++            setup-show: True
+
+     The testing can be disabled by setting `enabled` to False.
+ ",This looks out of scope for this particular PR.,"The `v` option shouldn't be here, it should be set in `opt"
+4727,"@@ -39,6 +39,14 @@ import (
+ // Warning when user configures leafnode TLS insecure
+ const leafnodeTLSInsecureWarning = ""TLS certificate chain and hostname of solicited leafnodes will not be verified. DO NOT USE IN PRODUCTION!""
+
++const (
++	leafDefaultFirstPingInterval = int64(time.Second)
++)
++
++var (
++	leafFirstPingInterval = leafDefaultFirstPingInterval
++)
++
+ type leaf struct {
+ 	// Used to suppress sub and unsub interest. Same as routes but our audience
+ 	// here is tied to this leaf node. This will hold all subscriptions except this",Don't need () if only one.,leafDefaultFirstPingInterval -> leafPingInterval
+4728,"@@ -26,6 +26,7 @@ public class AbstractMailer {
+   private boolean usesAuth;
+
+   private String mailHost;
++  private String mailPort;
+   private String mailUser;
+   private String mailPassword;
+   private String mailSender;",Why not have mailPort as int since your are already parsing while calling t.connect ?,Do we really need `mailPort`? Wouldn't `mailHost` be enough?
+4729,"@@ -38,7 +38,7 @@ with open('README.rst') as fobj:
+
+ install_requires = [
+     'tornado>=4.0,<5',
+-    'python-daemon<3.0',
++    'python-daemon<3.0'
+ ]
+
+ if os.environ.get('READTHEDOCS', None) == 'True':","In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :)","If we're going to have to update this list, it should actual"
+4730,"@@ -739,6 +739,11 @@ class SolrDefault extends AbstractBase
+         // Get LCCN from Index
+         $raw = isset($this->fields['lccn']) ? $this->fields['lccn'] : '';
+
++        // First call number only.
++        if (is_array($raw)) {
++            $raw = reset($raw);
++        }
++
+         // Remove all blanks.
+         $raw = preg_replace('{[ \t]+}', '', $raw);
+ ","Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations).",What is the purpose of this line?
+4731,"@@ -44,6 +44,8 @@ type Config struct {
+ 	Manager                       Manager
+ 	Attestor                      Attestor
+ 	AllowUnauthenticatedVerifiers bool
++	AllowedForeignJWTClaims       map[string]bool
++	TrustDomain                   spiffeid.TrustDomain
+ }
+
+ type Handler struct {","i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false",Why does this need to be on the Handler? Shouldn't it only b
+4732,"@@ -69,6 +69,7 @@ const (
+ 	History
+ 	Matching
+ 	Worker
++	Server
+ 	NumServices
+ )
+ ","This is very unclear what Server means. We need a better name, maybe ServerExtension?",Would be nice to have a test case for this in `integration_tests.go`
+4733,"@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
+ 		out, err := system.RunCommand(DdevBin, args)
+ 		assert.NoError(err)
+ 		assert.Contains(string(out), ""Server started"")
+-		assert.Contains(string(out), ""GET"")
+
+ 		cleanup()
+ 	}",I wonder if we should trigger a PHP error and ensure it ends up in the log?,Why was this removed?
+4734,"@@ -232,7 +232,9 @@
+         * @returns {string} decoded string
+         */
+         countlyCommon.decodeHtml = function(html) {
+-            return (html + """").replace(/&amp;/g, '&');
++            var textArea = document.createElement('textarea');
++            textArea.innerHTML = html;
++            return textArea.value;
+         };
+
+ ",Hmmm not sure about this. Is it fine @ar2rsawseen?,"This should be `html.replace(/&amp;/g, '&');`"
+4735,"@@ -7,5 +7,5 @@ public interface Installer {
+     /**
+      * runs the installer
+      */
+-    void run();
++    void go();
+ }",Why do you prefer `go` over `run`?,why did you remove the run method?
+4736,"@@ -822,7 +822,7 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+                                           TestRunCompleteArgs = dummyCompleteArgs
+                                       };
+             var runComplete = CreateMessage(MessageType.ExecutionComplete, completepayload);
+-
++
+             this.mockCommunicationManager.Setup(cm => cm.ReceiveMessageAsync(It.IsAny<CancellationToken>())).Returns(Task.FromResult(message1));
+             mockLauncher.Setup(ml => ml.LaunchTestHost(It.IsAny<TestProcessStartInfo>()))
+                 .Callback<TestProcessStartInfo>((startInfo) =>","Unintentional, please remove",Looks like this file can be reverted.
+4737,"@@ -18,6 +18,10 @@ class Subscription < ActiveRecord::Base
+   after_create :add_user_to_mailing_list
+   after_create :add_user_to_github_team
+
++  def self.active
++    where(deactivated_on: nil)
++  end
++
+   def self.deliver_welcome_emails
+     recent.each do |subscription|
+       subscription.deliver_welcome_email",What was the reason behind moving this?,Style/RedundantSelf: Redundant self d
+4738,"@@ -1,12 +1,8 @@
+-<%= t ""user_mailer.gpx_notification.your_gpx_file"" %>
+-<strong><%= @trace_name %></strong>
+-<%= t ""user_mailer.gpx_notification.with_description"" %>
+-<em><%= @trace_description %></em>
+-<% if @trace_tags.length>0 %>
+-  <%= t ""user_mailer.gpx_notification.and_the_tags"" %>
+-  <em><% @trace_tags.each do |tag| %>
+-    <%= tag.tag.rstrip %>
+-  <% end %></em>
++<% trace_name = tag.strong(@trace_name) %>
++<% trace_description = tag.em(@trace_description) %>
++<% if @trace_tags.length > 0 %>
++  <% tags = @trace_tags.map { tag.tag.rstrip.join("" "") } %>
++  <%= t "".description_with_tags_html"", :trace_name => trace_name, :trace_description => trace_description, :tags => tags %>
+ <% else %>
+-  <%= t ""user_mailer.gpx_notification.and_no_tags"" %>
++  <%= t "".description_with_no_tags_html"", :trace_name => trace_name, :trace_description => trace_description %>
+ <% end %>",Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect>,"t(""user_mailer.gpx_notification.descr"
+4739,"@@ -72,6 +72,14 @@ class Realm {
+      */
+     get isInTransaction() {}
+
++    /**
++     * Indicated is this Realm is closed.
++     * @type {boolean}
++     * @readonly
++     * @since 2.1.0
++     */
++     get isClosed() {}
++
+     /**
+      * Gets the sync session if this is a synced Realm
+      * @type {Session}",`Indicates if this Realm has been closed.`?,Maybe add a `@type` instead?
+4740,"@@ -55,7 +55,6 @@ class _MissingPandasLikeSeries(object):
+     compress = unsupported_function('compress')
+     convert_objects = unsupported_function('convert_objects')
+     copy = unsupported_function('copy')
+-    corr = unsupported_function('corr')
+     cov = unsupported_function('cov')
+     cummax = unsupported_function('cummax')
+     cummin = unsupported_function('cummin')",how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series?,there is no test for this function?
+4741,"@@ -168,11 +168,11 @@ func (syncer *DefaultSyncer) tipSetState(ctx context.Context, tsKey types.Sorted
+ 	if !syncer.chainStore.HasTipSetAndState(ctx, tsKey.String()) {
+ 		return nil, errors.Wrap(ErrUnexpectedStoreState, ""parent tipset must be in the store"")
+ 	}
+-	tsas, err := syncer.chainStore.GetTipSetAndState(tsKey)
++	tssr, err := syncer.chainStore.GetTipSetStateRoot(tsKey)
+ 	if err != nil {
+ 		return nil, err
+ 	}
+-	st, err := state.LoadStateTree(ctx, syncer.stateStore, tsas.TipSetStateRoot, builtin.Actors)
++	st, err := state.LoadStateTree(ctx, syncer.stateStore, tssr, builtin.Actors)
+ 	if err != nil {
+ 		return nil, err
+ 	}","Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552.",Nit: Could rename `tssr` to `tsRoot
+4742,"@@ -11,11 +11,15 @@ using MicroBenchmarks;
+ namespace System.Collections
+ {
+     [BenchmarkCategory(Categories.CoreCLR, Categories.Collections, Categories.GenericCollections)]
+-    [GenericTypeArguments(typeof(int))] // value type
+-    [GenericTypeArguments(typeof(string))] // reference type
++    [GenericTypeArguments(typeof(int))] // value type, Array sort in native code
++    [GenericTypeArguments(typeof(IntStruct))] // custom value type, sort in managed code
++    [GenericTypeArguments(typeof(IntClass))] // custom reference type, sort in managed code, compare fast
++    [GenericTypeArguments(typeof(BigStruct))] // custom value type, sort in managed code
++    [GenericTypeArguments(typeof(string))] // reference type, compare slow
+     [InvocationCount(InvocationsPerIteration)]
+-    public class Sort<T>
++    public class Sort<T> where T : IComparable<T>
+     {
++        static readonly ComparableComparerClass _comparableComparerClass = new ComparableComparerClass();
+         private const int InvocationsPerIteration = 1000;
+
+         [Params(Utils.DefaultCollectionSize)]","@billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types.",What's the difference between `Comp
+4743,"@@ -31,7 +31,6 @@ from qutebrowser.config import config
+
+
+ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
+-
+     """"""The commandline part of the statusbar.
+
+     Attributes:",Unrelated whitespace change.,Please don't remove this empty line
+4744,"@@ -133,8 +133,18 @@ bool rai::wallet_store::valid_password (MDB_txn * transaction_a)
+ 	return ok;
+ }
+
+-bool rai::wallet_store::attempt_password (MDB_txn * transaction_a, std::string const & password_a)
++bool rai::wallet_store::attempt_password (rai::transaction * transaction_p, std::string const & password_a)
+ {
++	std::unique_ptr<rai::transaction> writeTransaction;
++
++	if (!transaction_p->open_for_write)
++	{
++		writeTransaction = std::make_unique<rai::transaction> (environment, nullptr, true);
++		transaction_p = writeTransaction.get ();
++	}
++
++	MDB_txn *transaction_a = *transaction_p;
++
+ 	bool result = false;
+ 	{
+ 		std::lock_guard<std::recursive_mutex> lock (mutex);",Slight formatting issue here. There should be a space after the asterisk.,You don't need to `std::unique_ptr` here. `std::unique_ptr<rai::transaction> *transaction_p` is irrelevant.
+4745,"@@ -8,7 +8,8 @@
+  */
+ axe.utils.isHidden = function isHidden(el, recursed) {
+ 	'use strict';
+-	var parent;
++	const node = axe.utils.getNodeFromTree(el);
++	let parent, isHidden;
+
+ 	// 9 === Node.DOCUMENT
+ 	if (el.nodeType === 9) {",Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these.,"AFAICT, `getNodeFromTree` will return `null` if `el.nodeType === 9`, so this will never be called."
+4746,"@@ -32,9 +32,9 @@ import org.slf4j.LoggerFactory;
+  * @since  [产品/模块版本]
+  */
+ public class TestMgr {
+-    private static Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
++    private static final Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
+
+-    private static List<Throwable> errorList = new ArrayList<>();
++    private static final List<Throwable> errorList = new ArrayList<>();
+
+     private static String msg = """";
+ ",this is a duplicate file of the one in demo-schema. please remove this file.,Do not use a `static` for this.
+4747,"@@ -153,6 +153,7 @@ var (
+ 		utils.Eth1SyncServiceEnable,
+ 		utils.Eth1CanonicalTransactionChainDeployHeightFlag,
+ 		utils.Eth1L1CrossDomainMessengerAddressFlag,
++		utils.Eth1L1FeeWalletAddressFlag,
+ 		utils.Eth1ETHGatewayAddressFlag,
+ 		utils.Eth1ChainIdFlag,
+ 		utils.RollupClientHttpFlag,",Nit: unified names between geth and contracts,Does this need to be added?
+4748,"@@ -42,7 +42,9 @@ func TestClientToServerCommunication(t *testing.T) {
+ 	// Note that the ordering of things here is pretty important; we need to get the
+ 	// client connected & ready to receive events before we push them all into the
+ 	// server and shut it down again.
+-	serverState := core.NewBuildState(5, nil, 4, core.DefaultConfiguration())
++	config := core.DefaultConfiguration()
++	config.Please.NumThreads = 5
++	serverState := core.NewBuildState(config)
+ 	addr, shutdown := initialiseServer(serverState, 0)
+
+ 	// This is a bit awkward. We want to assert that we receive a matching set of",Necessary? Could you just use DefaultBuildState here?,why is it changed?
+4749,"@@ -22,7 +22,7 @@ import java.util.ArrayList;
+ import java.util.Arrays;
+ import java.util.Collections;
+ import java.util.Date;
+-import java.util.HashMap;
++import java.util.LinkedHashMap;
+ import java.util.HashSet;
+ import java.util.List;
+ import java.util.Map;",linked hashmap retains order,Why you changed th
+4750,"@@ -20,12 +20,12 @@
+ #include <wlr/render/matrix.h>
+ #include <wlr/render/gles2.h>
+ #include <wlr/render.h>
+-#include ""backend/drm.h""
+-#include ""backend/drm-util.h""
++#include ""backend/drm/drm.h""
++#include ""backend/drm/util.h""
+
+ bool wlr_drm_check_features(struct wlr_drm_backend *backend) {
+-	extern const struct wlr_drm_interface legacy_iface;
+-	extern const struct wlr_drm_interface atomic_iface;
++	extern const struct wlr_drm_interface iface_legacy;
++	extern const struct wlr_drm_interface iface_atomic;
+
+ 	if (drmSetClientCap(backend->fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1)) {
+ 		wlr_log(L_ERROR, ""DRM universal planes unsupported"");",And the old names for these variables made more sense imo.,`const struct wlr_
+4751,"@@ -473,7 +473,7 @@ func GetAdditionalGroups(additionalGroups []string, group io.Reader) ([]int, err
+ 				return nil, fmt.Errorf(""Unable to find group %s"", ag)
+ 			}
+ 			// Ensure gid is inside gid range.
+-			if gid < minId || gid > maxId {
++			if gid < minId || gid >= maxId {
+ 				return nil, ErrRange
+ 			}
+ 			gidMap[gid] = struct{}{}",Are you sure this change is correct?,Does gid >= maxId
+4752,"@@ -9,8 +9,7 @@ def test_view_image():
+         ""mitmproxy/data/image.png"",
+         ""mitmproxy/data/image.gif"",
+         ""mitmproxy/data/all.jpeg"",
+-        # https://bugs.python.org/issue21574
+-        # ""mitmproxy/data/image.ico"",
++        ""mitmproxy/data/image.ico"",
+     ]:
+         with open(tutils.test_data.path(img), ""rb"") as f:
+             viewname, lines = v(f.read())","The previously linked bug does not apply anymore? If so, this is LGTM!","If you remove the JIRA reference, you can remove the reference to `mitmproxy/data/image.png` as well."
+4753,"@@ -84,7 +84,7 @@ func assertNotEqual(t *testing.T, a interface{}, b interface{}) {
+ 	}
+ }
+
+-func TestFailOver(t *testing.T) {
++func Test_FailOver(t *testing.T) {
+ 	tmpDir, err := ioutil.TempDir("""", ""lb-test"")
+ 	if err != nil {
+ 		assertEqual(t, err, nil)",Why are we renaming all of the tests?,Does this one need to be underscored?
+4754,"@@ -24,8 +24,9 @@ import (
+
+ var defaultRFC2136Port = ""53""
+
+-// This function make a valid nameserver as per RFC2136
++// This function returns a valid nameserver (in the form <host>:<port>) for the RFC2136 provider
+ func ValidNameserver(nameserver string) (string, error) {
++	nameserver = strings.TrimSpace(nameserver)
+
+ 	if nameserver == """" {
+ 		return """", fmt.Errorf(""RFC2136 nameserver missing"")","Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here?",Why are we trimming the space here?
+4755,"@@ -142,9 +142,15 @@ PyObject *GetMolConformers(ROMol &mol) {
+ template <class T>
+ T MolGetProp(const ROMol &mol, const char *key) {
+   T res;
+-  if (!mol.getPropIfPresent(key, res)) {
+-    PyErr_SetString(PyExc_KeyError, key);
+-    throw python::error_already_set();
++  try {
++    if (!mol.getPropIfPresent(key, res)) {
++      PyErr_SetString(PyExc_KeyError, key);
++      throw python::error_already_set();
++    }
++    return res;
++  } catch ( const boost::bad_any_cast &e ) {
++    throw ValueErrorException(std::string(""key `"") + key + ""` exists but does not result in a "" +
++                              GetTypeName<T>());
+   }
+   return res;
+ }","Why not also replace this one with calls to `GetProp<ROMol,T>`?",Why not just catch the exception and return the original exception?
+4756,"@@ -259,6 +259,7 @@ class KNNClassifier(object):
+     if doWinners:
+       if (self.numWinners>0) and (self.numWinners < (inputPattern > 0).sum()):
+         sparseInput = numpy.zeros(inputPattern.shape)
++
+         # Don't consider strongly negative numbers as winners.
+         sorted = inputPattern.argsort()[0:self.numWinners]
+         sparseInput[sorted] += inputPattern[sorted]",Still need to remove trailing spaces on this line,These two lines are too long and fit on one line.
+4757,"@@ -0,0 +1,19 @@
++/*
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.apex.ast;
++
++import apex.jorje.semantic.ast.AstNode;
++
++/**
++ * Interface for nodes that can contain comments. Because comments are for the most part lost, the tree builder only
++ * captures whether the node did contain comments of any sort in the source code and not the actual contents of those
++ * comments. This is useful for rules which need to know whether a node did contain comments.
++ */
++public interface ASTCommentContainer<T extends AstNode> extends ApexNode<T> {
++
++    void setContainsComment(boolean containsComment);
++
++    boolean getContainsComment();
++}",Please use the `@Experimental` annotation on this,"If this is only used in a single place, why not p"
+4758,"@@ -77,7 +77,7 @@ func (s *LimitedReaderSlurper) Read(reader io.Reader) error {
+ 					// if we received err == nil and n == 0, we should retry calling the Read function.
+ 					continue
+ 				default:
+-					// if we recieved a non-io.EOF error, return it.
++					// if we received a non-io.EOF error, return it.
+ 					return err
+ 				}
+ 			}",I found ~10 more instances of this typo. we can fix those in subsequent PRs.,typo in commit message: s/we recieved/we received
+4759,"@@ -49,7 +49,7 @@ type InitRes struct {
+ // it returns a result object that contains useful artifacts for later use.
+ // Unlike sharedmain.Main, Init is meant to be run as a helper function in any main
+ // functions, while sharedmain.Main runs controllers with predefined method signatures.
+-func Init(component string, opts ...InitOption) (context.Context, *InitRes) {
++func Init(component string, metricNamespace string, opts ...InitOption) (context.Context, *InitRes) {
+ 	args := newInitArgs(component, opts...)
+ 	ctx := args.ctx
+ 	ProcessEnvConfigOrDie(args.env)","How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace(""trigger""))",why did you change this to `metricNamespace`? See
+4760,"@@ -163,6 +163,8 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(""handlePage""))));
+     builder.pageVarName(
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name(), ""page""))));
++    builder.pageTokenName(methodInfo.requestPageTokenName());
++    builder.nextPageTokenName(methodInfo.responsePageTokenName());
+     return builder.build();
+   }
+ }",Just checking: no need for case manipulation?,`pageTokenName` -> `pageTokenName`
+4761,"@@ -94,7 +94,7 @@ public class GrpcMetadataGeneratorTool {
+
+   private static void generate(
+       String descriptorSet,
+-      String[] apiConfigs,
++      String[] configs,
+       String inputDir,
+       String outputDir,
+       String languageString,","Same as above, not that descriptive",Why did you change this from `apiC
+4762,"@@ -5494,10 +5494,12 @@ emit_special_ibl_xfer(dcontext_t *dcontext, byte *pc, generated_code_t *code, ui
+     reg_id_t stub_reg = IF_AARCH64_ELSE(SCRATCH_REG0, SCRATCH_REG1);
+     ushort stub_slot = IF_AARCH64_ELSE(TLS_REG0_SLOT, TLS_REG1_SLOT);
+     IF_X86(size_t len;)
+-    byte *ibl_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_LINKED, ibl_type);
++    byte *ibl_linked_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_LINKED, ibl_type);
++    byte *ibl_unlinked_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_UNLINKED, ibl_type);
+     bool absolute = !code->thread_shared;
+
+-    ASSERT(ibl_tgt != NULL);
++    ASSERT(ibl_linked_tgt != NULL);
++    ASSERT(ibl_unlinked_tgt != NULL);
+     instrlist_init(&ilist);
+     init_patch_list(&patch, absolute ? PATCH_TYPE_ABSOLUTE : PATCH_TYPE_INDIRECT_FS);
+ ",> i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error.,This and similar places can use `i
+4763,"@@ -668,6 +668,8 @@ int flb_start(flb_ctx_t *ctx)
+         fd = event->fd;
+         bytes = flb_pipe_r(fd, &val, sizeof(uint64_t));
+         if (bytes <= 0) {
++            pthread_cancel(tid);
++            pthread_join(tid, NULL);
+             ctx->status = FLB_LIB_ERROR;
+             return -1;
+         }",Should we need to invoke pthread_cancel ?,"Likewise, should we set status to "
+4764,"@@ -122,7 +122,8 @@ public class ZMSResources {
+     public Domain postUserDomain(@PathParam(""name"") String name, @HeaderParam(""Y-Audit-Ref"") String auditRef, UserDomain detail) {
+         try {
+             ResourceContext context = this.delegate.newResourceContext(this.request, this.response);
+-            context.authorize(""create"", ""user."" + name + "":domain"", null);
++            String userDomainPrefix = System.getProperty(ZMSConsts.ZMS_PROP_USER_DOMAIN, ZMSConsts.USER_DOMAIN) + ""."";
++            context.authorize(""create"", userDomainPrefix + name + "":domain"", null);
+             Domain e = this.delegate.postUserDomain(context, name, auditRef, detail);
+             return e;
+         } catch (ResourceException e) {",this is auto generated file so no changes are allowed here,Let's get rid of the ZMSConsts import and use `ZMSConsts.USER_DOMAIN` directly.
+4765,"@@ -0,0 +1,13 @@
++if (
++	node.querySelector(
++		'input[type=""submit""]:not([disabled]), img[type=""submit""]:not([disabled]), button[type=""submit""]:not([disabled])'
++	)
++) {
++	return true;
++}
++
++if (!node.querySelectorAll(':not(textarea)').length) {
++	return false;
++}
++
++return undefined;","All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`.","This seems to be the same as the previous code, isn't it?"
+4766,"@@ -38,7 +38,7 @@ module Travis
+
+         def perl_version
+           # this check is needed because safe_yaml parses the string 5.10 to 5.1
+-          config[:perl] == 5.1 ? ""5.10"" : config[:perl]
++          config[:perl] == 5.1 ? ""5.10"" : config[:perl] == 5.2 ? ""5.20"" : config[:perl]
+         end
+       end
+     end","can you please make this multi line, this version is hard to read.",Line is too long. [104/80]
+4767,"@@ -128,7 +128,7 @@ Blockly.HorizontalFlyout.prototype.setMetrics_ = function(xyRatio) {
+     return;
+   }
+
+-  if (goog.isNumber(xyRatio.x)) {
++  if (typeof xyRatio.x === 'number') {
+     this.workspace_.scrollX = -metrics.contentWidth * xyRatio.x;
+   }
+ ","For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them.","Is this correct? It looks like `xyRatio.x` is a number, not a string."
+4768,"@@ -11,6 +11,10 @@ FactoryGirl.define do
+     project_title ""NCR Name""
+     association :proposal, flow: 'linear'
+
++    trait :with_approver do
++      association :proposal, :with_approver, flow: 'linear'
++    end
++
+     trait :with_approvers do
+       association :proposal, :with_approvers, flow: 'linear'
+     end","Work Orders would never have only one approver, right?",Rails/InverseOf: Specify an :inverse_of option.
+4769,"@@ -0,0 +1,17 @@
++package com.codahale.metrics.collectd;
++
++enum DataType {
++
++    COUNTER(0), GAUGE(1);
++
++    private final int code;
++
++    private DataType(int code) {
++        this.code = code;
++    }
++
++    public int getCode() {
++        return code;
++    }
++
++}","`code` is written to the message as a `byte`, so I think it's better to declare it in the enum as `byte` as well to avoid a narrowing primitive conversion from `int` to `byte` in runtime.",Could you add a doc here as well?
+4770,"@@ -163,9 +163,11 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
+ 		{
+ 			title: __( 'Earnings', 'google-site-kit' ),
+ 			tooltip: __( 'Earnings', 'google-site-kit' ),
+-			Component: ( { row } ) => numFmt(
+-				row.metrics[ 0 ].values[ 0 ],
+-				currencyFormat,
++			field: 'metrics.0.values.0',
++			Component: ( { fieldValue } ) => (
++				<span>
++					{ numFmt( fieldValue, currencyFormat ) }
++				</span>
+ 			),
+ 		},
+ 	];","This is the only ""extra"" change here.",Could you add a space between `)` and `)` to ma
+4771,"@@ -36,14 +36,15 @@ type SignedMessageValidator interface {
+ }
+
+ type defaultMessageValidator struct {
+-	allowHighNonce bool
++	allowHighNonce          bool
++	bypassBLSSignatureCheck bool
+ }
+
+ // NewDefaultMessageValidator creates a new default validator.
+ // A default validator checks for both permanent semantic problems (e.g. invalid signature)
+ // as well as temporary conditions which may change (e.g. actor can't cover gas limit).
+ func NewDefaultMessageValidator() SignedMessageValidator {
+-	return &defaultMessageValidator{}
++	return &defaultMessageValidator{bypassBLSSignatureCheck: true}
+ }
+
+ // NewOutboundMessageValidator creates a new default validator for outbound messages. This",Please TODO and link to an issue for changing this.,please add a space between `:` and `{`
+4772,"@@ -1,9 +1,10 @@
++/* eslint-disable comma-dangle */
+ const en_US = {}
+
+ en_US.strings = {
+   addBulkFilesFailed: {
+     '0': 'Failed to add %{smart_count} file due to an internal error',
+-    '1': 'Failed to add %{smart_count} files due to internal errors',
++    '1': 'Failed to add %{smart_count} files due to internal errors'
+   },
+   addingMoreFiles: 'Adding more files',
+   addMore: 'Add more',",Can we make the script output trailing commas?,No need to disabling comma-dangle.
+4773,"@@ -0,0 +1,10 @@
++exports.featureFlags = {
++	widgets: {
++		dashboard: {
++			enabled: 'development',
++		},
++		pageDashboard: {
++			enabled: 'development',
++		},
++	},
++};",This file should get a file header  ,Do we have to disable these at all
+4774,"@@ -7,7 +7,6 @@
+ #include ""base/Base.h""
+ #include ""kvstore/wal/FileBasedWal.h""
+ #include ""kvstore/wal/FileBasedWalIterator.h""
+-#include ""kvstore/wal/BufferFlusher.h""
+ #include ""fs/FileUtils.h""
+ #include ""time/WallClock.h""
+ ","maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger.",why did you remove this?
+4775,"@@ -135,6 +135,9 @@ func registerWriteCommand(cmd *cobra.Command) {
+
+ // gasPriceInRau returns the suggest gas price
+ func gasPriceInRau() (*big.Int, error) {
++	if account.CryptoSm2 {
++		return big.NewInt(0), nil
++	}
+ 	gasPrice := gasPriceFlag.Value().(string)
+ 	if len(gasPrice) != 0 {
+ 		return util.StringToRau(gasPrice, util.GasPriceDecimalNum)",we need to pay attention not to use this flag everywhere.,Why do we need this?
+4776,"@@ -22,7 +22,6 @@ import (
+ )
+
+ type Protocol string
+-type TableIDType uint8
+ type GroupIDType uint32
+ type MeterIDType uint32
+ ","curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place",can you explain why we remove this?
+4777,"@@ -74,7 +74,7 @@ func (db *DB) SubscribePush(ctx context.Context) (c <-chan swarm.Chunk, stop fun
+ 					}
+
+ 					select {
+-					case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag).WithStamp(dataItem.Stamp):
++					case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag):
+ 						count++
+ 						// set next iteration start item
+ 						// when its chunk is successfully sent to channel","wait, are we not mising `WithStamp` here?",can we remove `WithStamp` from here
+4778,"@@ -66,7 +66,7 @@ func (api *APIImpl) Syncing(ctx context.Context) (interface{}, error) {
+ 		return false, err
+ 	}
+
+-	currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.TxPool)
++	currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.Finish)
+ 	if err != nil {
+ 		return false, err
+ 	}",oh. didn't know we store this stage progress.,Do we need to handle the case that
+4779,"@@ -91,6 +91,7 @@ function getUnicodeNonBmpRegExp() {
+ 		'\u25A0-\u25FF' + // Geometric Shapes
+ 		'\u2600-\u26FF' + // Misc Symbols
+ 		'\u2700-\u27BF' + // Dingbats
++		'\uE000-\uF8FF' + // Private Use
+ 			']'
+ 	);
+ }","Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also two large ranges of supplementary private-use characters, consisting of most of the code points on Planes 15 and 16: U+F0000..U+FFFFD and U+100000..U+10FFFD. Together those ranges allocate another 131,068 private-use characters. Altogether, then, there are 137,468 private-use characters in Unicode. It looks like we are only ignoring ones in BMP and not the supplementary private-use characters. Shouldn't we consider the supplementary ones too?",Private Use? Why is this in the fir
+4780,"@@ -300,7 +300,7 @@ class FunctionCallReturnTypeFetcher
+                                     return new Type\Union([
+                                         $atomic_types['array']->count !== null
+                                             ? new Type\Atomic\TLiteralInt($atomic_types['array']->count)
+-                                            : new Type\Atomic\TInt
++                                            : new Type\Atomic\TPositiveInt
+                                     ]);
+                                 }
+ ",This change is un-tested and requires testing,"This looks wrong. The result of `$atomic_types['array']->count` is an integer, not a boolean."
+4781,"@@ -83,6 +83,11 @@ class notebook_extension(extension):
+
+     logo = param.Boolean(default=True, doc=""Toggles display of HoloViews logo"")
+
++    comms = param.ObjectSelector(
++        default='default', objects=['default', 'ipywidgets', 'vscode'], doc=""""""
++        Whether to render output in Jupyter with the default Jupyter
++        extension or use the jupyter_bokeh ipywidget model."""""")
++
+     inline = param.Boolean(default=True, doc=""""""
+         Whether to inline JS and CSS resources.
+         If disabled, resources are loaded from CDN if one is available."""""")",Should the docstring mention the vscode option?,"This needs to be `param.Boolean(default=True, doc=None)`"
+4782,"@@ -83,6 +83,8 @@ public class PackageMetadataTransformer {
+         .packageVersionBound(packageConfig.generatedPackageVersionBound(language))
+         .protoPath(packageConfig.protoPath())
+         .shortName(packageConfig.shortName())
++        .gapicConfigName(packageConfig.shortName() + ""_gapic.yaml"")
++        .packageType(packageConfig.packageType())
+         .gaxVersionBound(packageConfig.gaxVersionBound(language))
+         .grpcVersionBound(packageConfig.grpcVersionBound(language))
+         .protoVersionBound(packageConfig.protoVersionBound(language))","ISTM that since `artman` know the ""real"" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen...",I think we can remove `_gapic.yaml` here now that we have the configuration in `_gapic.yaml`.
+4783,"@@ -17,7 +17,7 @@ package main
+ import (
+ 	""time""
+
+-	""github.com/docopt/docopt-go""
++	docopt ""github.com/docopt/docopt-go""
+ 	log ""github.com/sirupsen/logrus""
+
+ 	""github.com/projectcalico/felix/iptables""",Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated,I don't think we need this import anymore?
+4784,"@@ -17,6 +17,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+         Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken));
+         void Flush();
+         Task FlushAsync(CancellationToken cancellationToken = default(CancellationToken));
+-        void Write<T>(Action<WritableBuffer, T> write, T state);
++        void Write<T>(Action<WritableBuffer, T> write, T state) where T : struct;
+     }
+ }",Should this be `ISocketOutput<T> where T : struct`?,Would it make sense to instead annotate `T` as `T?` instead of `T`?
+4785,"@@ -104,4 +104,11 @@ public interface Snapshot {
+    * @return the location of the manifest list for this Snapshot
+    */
+   String manifestListLocation();
++
++  /**
++   * Return this snapshot's sequence number, or 0 if the table has no snapshot yet.
++   *
++   * @return the sequence number of this Snapshot
++   */
++  Long sequenceNumber();
+ }","In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right?",Should be `long` instead of `Long`.
+4786,"@@ -133,6 +133,11 @@ class NumClassCheckHook(Hook):
+             for name, module in model.named_modules():
+                 if hasattr(module, 'num_classes') and not isinstance(
+                         module, (RPNHead, VGG, FusedSemanticHead, GARPNHead)):
++                    assert type(dataset.CLASSES) is not str, \
++                        (f'`CLASSES` in {dataset.__class__.__name__}'
++                         f'should be a tuple of str.'
++                         f'Add comma if number of classes is 1 as '
++                         f'CLASSES = ({dataset.CLASSES},)')
+                     assert module.num_classes == len(dataset.CLASSES), \
+                         (f'The `num_classes` ({module.num_classes}) in '
+                          f'{module.__class__.__name__} of '","This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module.",nit: `{dataset.__class__.__name__}` should be on a new line.
+4787,"@@ -36,7 +36,7 @@ if __name__ == ""__main__"":
+             ""boto3"",
+             f""dagster{pin}"",
+             ""packaging"",
+-            ""psycopg2-binary<2.9"",
++            ""psycopg2-binary"",
+             ""requests"",
+         ],
+         extras_require={",Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine?,If we no longer support 2.9 we can remove the `<2.9` condition.
+4788,"@@ -12,8 +12,9 @@ import (
+ )
+
+ var (
+-	_                  = collection.Entry(&Entry{})
+-	serializedDataSize = swarm.SectionSize * 2
++	_                           = collection.Entry(&Entry{})
++	serializedDataSize          = swarm.SectionSize * 2
++	encryptedSerializedDataSize = swarm.EncryptedHashSize * 2
+ )
+
+ // Entry provides addition of metadata to a data reference.",could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`?,Nitpick: Alphabetize this variable (and the associated variables in this file)
+4789,"@@ -39,9 +39,14 @@ func (r *Reader) Close() error {
+ 	return r.r.Close()
+ }
+
++// ContentType returns the MIME type of the object content.
++func (r *Reader) ContentType() string {
++	return r.r.Attrs().ContentType
++}
++
+ // Size returns the content size of the blob object.
+ func (r *Reader) Size() int64 {
+-	return r.r.Size()
++	return r.r.Attrs().Size
+ }
+
+ // Writer implements io.WriteCloser to write to blob. It must be closed after",s/object content/blob object/ (for consistency with the `Size` docs),Is there a reason why you didn't just do `return r.Attrs().ContentType`?
+4790,"@@ -109,16 +109,7 @@ public class CheckJUnitDependencies extends DefaultTask {
+                                 + ""'org.junit.jupiter:junit-jupiter' dependency ""
+                                 + ""because tests use JUnit4 and useJUnitPlatform() is not enabled."");
+             }
+-        } else {
+-            String compileClasspath = ss.getCompileClasspathConfigurationName();
+-            boolean compilingAgainstOldJunit = hasDep(compileClasspath, CheckJUnitDependencies::isJunit4);
+-            Preconditions.checkState(
+-                    !compilingAgainstOldJunit,
+-                    ""Extraneous dependency on JUnit4 (no test mentions JUnit4 classes). Please exclude ""
+-                            + ""this from compilation to ensure developers don't accidentally re-introduce it, e.g.\n\n""
+-                            + ""    configurations."" + compileClasspath + "".exclude module: 'junit'\n\n"");
+         }
+-
+         // sourcesets might also contain Spock classes, but we don't have any special validation for these.
+     }
+ ","Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line?",Shouldn't this be kept to ensure tests are not disabled in case of a bug?
+4791,"@@ -215,7 +215,7 @@ func (cfg *Config) newACMEClient(interactive bool) (*acmeClient, error) {
+ // lockKey returns a key for a lock that is specific to the operation
+ // named op being performed related to domainName and this config's CA.
+ func (cfg *Config) lockKey(op, domainName string) string {
+-	return fmt.Sprintf(""%s:%s:%s"", op, domainName, cfg.CA)
++	return fmt.Sprintf(""%s_%s_%s"", op, domainName, cfg.CA)
+ }
+
+ // Obtain obtains a single certificate for name. It stores the certificate",Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one?,Same question as above: Why not use `fmt.Sprintf`?
+4792,"@@ -758,6 +758,7 @@ class CaiDataAccess(object):
+         except SQLAlchemyError as e:
+             LOGGER.exception('Attempt to delete data from CAI temporary store '
+                              'failed, disabling the use of CAI: %s', e)
++            session.rollback()
+
+         return num_rows
+ ",Thanks for this... is this the only place where the rollback is needed? Are there others?,Why do we need to rollback here? Shouldn't the cleanup be part of the delete command and not the delete manager?
+4793,"@@ -56,7 +56,7 @@ func TestTriangleEncoding(t *testing.T) {
+ 	}
+ 	t.Run(""encoding block with zero fields works"", func(t *testing.T) {
+ 		testRoundTrip(t, &blk.Block{
+-			BlockSig:        crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
++			BlockSig:        &crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
+ 			BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}},
+ 		})
+ 	})","Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here.",Why change this line?
+4794,"@@ -427,9 +427,9 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
+
+ 	case driver.Replace:
+ 		// If the given document has a revision, use it as the precondition (it implies existence).
+-		pc, err := revisionPrecondition(a.Doc)
+-		if err != nil {
+-			return nil, """", err
++		pc, perr := revisionPrecondition(a.Doc)
++		if perr != nil {
++			return nil, """", perr
+ 		}
+ 		// Otherwise, just require that the document exists.
+ 		if pc == nil {",This was definitely a subtle bug right here.,I don't see any tests for this change?
+4795,"@@ -35,6 +35,12 @@ class GithubApi
+     @access_token = data['access_token'].first
+   end
+
++  def secondary_emails
++    return @secondary_emails if @secondary_emails
++    @secondary_emails = fetch_email_responses.select { |hsh| !hsh['primary'] && hsh['verified'] }
++                                             .map { |response| response['email'] }.compact
++  end
++
+   private
+
+   def request","If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**.",I guess this could be `.compact.compact`
+4796,"@@ -48,7 +48,7 @@ func TestBroadcast(t *testing.T) {
+ 		}
+ 	}
+ 	u := func(_ context.Context, _ uint32, _ peerstore.PeerInfo, _ proto.Message) {}
+-	bootnodePort := testutil.RandomPort()
++	bootnodePort := 14689
+ 	cfg := config.Config{
+ 		Network: config.Network{Host: ""127.0.0.1"", Port: bootnodePort},
+ 	}","Can we still random, but if we randomly get a port is used before, we randomly pick again?",why not testutil.RandomPort()?
+4797,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low.",why are we making this change
+4798,"@@ -11,5 +11,17 @@ module Gsa18f
+       super && self.gsa_if_restricted!
+     end
+     alias_method :can_new!, :can_create!
++
++    def can_cancel!
++      not_cancelled! && check((approver? || delegate? || requester?) && !purchaser?,
++        ""Sorry, you are neither the requester, approver or delegate"")
++    end
++    alias_method :can_cancel_form!, :can_cancel!
++
++    protected
++
++    def purchaser?
++      @procurement.purchaser == @user
++    end
+   end
+ end",what if a purchaser is also an approver? or would that not happen?,I don't think you need the `pu
+4799,"@@ -125,9 +125,12 @@ def sweep(privkeys, network, config, recipient, fee=None, imax=100):
+         raise BaseException(_('No inputs found. (Note that inputs need to be confirmed)'))
+     total = sum(i.get('value') for i in inputs)
+     if fee is None:
++        if not network.config.has_fee_estimates():
++            raise BaseException('Dynamic fee estimates not available')
+         outputs = [(TYPE_ADDRESS, recipient, total)]
+         tx = Transaction.from_io(inputs, outputs)
+         fee = config.estimate_fee(tx.estimated_size())
++
+     if total - fee < 0:
+         raise BaseException(_('Not enough funds on address.') + '\nTotal: %d satoshis\nFee: %d'%(total, fee))
+     if total - fee < dust_threshold(network):","Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that.",Shouldn't this be `ValueError(
+4800,"@@ -26,6 +26,11 @@ func (s *AuditLogsSourceStatus) GetCondition(t apis.ConditionType) *apis.Conditi
+ 	return auditLogsSourceCondSet.Manage(s).GetCondition(t)
+ }
+
++// GetTopLevelCondition returns the top level condition.
++func (s *AuditLogsSourceStatus) GetTopLevelCondition() *apis.Condition {
++	return auditLogsSourceCondSet.Manage(s).GetTopLevelCondition()
++}
++
+ // IsReady returns true if the resource is ready overall.
+ func (s *AuditLogsSourceStatus) IsReady() bool {
+ 	return auditLogsSourceCondSet.Manage(s).IsHappy()","sorry, I wasn't familiar with this TopLevelCondition... What it would be in this case? The AuditsLogReady condition?",Do we need this? Can't we just use `s.GetCondition(cond)`?
+4801,"@@ -109,6 +109,7 @@ type DiffTransformation struct {
+
+ 	d     execute.Dataset
+ 	cache execute.TableBuilderCache
++	alloc *memory.Allocator
+
+ 	inputCache *execute.GroupLookup
+ }",Where does the `alloc` field get set?,Why is this pointer needed?
+4802,"@@ -273,9 +273,10 @@ func setupPostgres(w *DWH) error {
+ 	return nil
+ }
+
+-func runQueryPostgres(db *sql.DB, opts *queryOpts) (*sql.Rows, string, error) {
++func runQueryPostgres(db *sql.DB, opts *queryOpts) (*sql.Rows, int64, error) {
+ 	var (
+ 		query      = fmt.Sprintf(""SELECT * FROM %s %s"", opts.table, opts.selectAs)
++		countQuery = fmt.Sprintf(""SELECT count(*) FROM %s %s"", opts.table, opts.selectAs)
+ 		conditions []string
+ 		values     []interface{}
+ 		numFilters = 1",looks expensive to do it on each query,`countQuery` is a very confusing name. How about `selectCo
+4803,"@@ -38,16 +38,16 @@ import model_params
+ _LOGGER = logging.getLogger(__name__)
+
+ _INPUT_DATA_FILE = resource_filename(
+-  ""nupic.datafiles"", ""extra/nyctaxi/nyc_taxi.csv""
++  ""nupic.datafiles"", ""extra/nyctaxi/nycTaxi.csv""
+ )
+ _OUTPUT_PATH = ""anomaly_scores.csv""
+
+ _ANOMALY_THRESHOLD = 0.9
+
+-# minimum metric value of nyc_taxi.csv
++# minimum metric value of nycTaxi.csv
+ _INPUT_MIN = 8
+
+-# maximum metric value of nyc_taxi.csv
++# maximum metric value of nycTaxi.csv
+ _INPUT_MAX = 39197
+
+ ",@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?,Why did you change the filename?
+4804,"@@ -209,9 +209,9 @@ module Mongoid
+           # @since 2.1.0
+           def empty?
+             if _loaded?
+-              in_memory.count == 0
++              in_memory.length == 0
+             else
+-              _unloaded.count + _added.count == 0
++              _added.length == 0 && !_unloaded.exists?
+             end
+           end
+ ",Can this simply call `in_memory.empty?` ?,Style/NumericPredicate: Use empty? instead of !empty?.
+4805,"@@ -88,6 +88,13 @@ func init() {
+ // CreateSettingsFile creates the settings file (like settings.php) for the
+ // provided app is the apptype has a settingsCreator function.
+ func (app *DdevApp) CreateSettingsFile() (string, error) {
++	// If the user has asked us to skip settings file manipulation, then just bail
++	// out early.
++	if app.OmitSettingsPhp {
++		util.Warning(""Skipping creation of settings file."")
++		return """", nil
++	}
++
+ 	app.SetApptypeSettingsPaths()
+
+ 	// If neither settings file options are set, then don't continue. Return",The styling/wording here probably needs some thought. It's more of a placeholder.,Wouldn't it be better to return an error?
+4806,"@@ -9,10 +9,10 @@ Rails.application.routes.draw do
+
+   resources :stack_entries
+
+-  resources :password_reset, only: [:new, :create] do
++  resources :password_resets, only: [:new, :create] do
+     collection do
+       get :confirm
+-      post :reset
++      patch :reset
+     end
+   end
+   resources :activation_resends, only: [:new, :create]",Using a plural route helps in detecting the path automatically for `= form_for @password_reset`.,I'm a little confused about the difference between `/r
+4807,"@@ -9,8 +9,8 @@ const fs = require('fs');
+ const { MongoClient } = require('../../../src');
+ const { TestConfiguration } = require('./config');
+ const { getEnvironmentalOptions } = require('../utils');
+-const { eachAsync } = require('../../../src/utils');
+ const mock = require('../mongodb-mock/index');
++const { inspect } = require('util');
+
+ const MONGODB_URI = process.env.MONGODB_URI || 'mongodb://localhost:27017';
+ const MONGODB_API_VERSION = process.env.MONGODB_API_VERSION;",Is `metadata` required on all tests? I actually just removed the metadata field entirely from a few tests in my PR.,`mongodb-mock/index.js` is no longer used.
+4808,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,Path.toString() is not guaranteed to return the same path as in the other cases.
+4809,"@@ -145,6 +145,10 @@ public class TemporaryFilesystem {
+   }
+
+   public boolean deleteBaseDir() {
+-    return baseDir.delete();
++    boolean wasDeleted = baseDir.delete();
++    if (wasDeleted) {
++      Runtime.getRuntime().removeShutdownHook(shutdownHook);
++    }
++    return wasDeleted;
+   }
+ }","I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways.","Rather than doing this, it's better to add a `Lifecycle` to the `BaseDir` interf"
+4810,"@@ -232,7 +232,17 @@ func (c *CVCController) updateCVCObj(
+ // 4. Create cstorvolumeclaim resource.
+ // 5. Update the cstorvolumeclaim with claimRef info and bound with cstorvolume.
+ func (c *CVCController) createVolumeOperation(cvc *apis.CStorVolumeClaim) (*apis.CStorVolumeClaim, error) {
+-	_ = cvc.Annotations[string(apis.ConfigClassKey)]
++
++	policyName := cvc.Annotations[string(apis.VolumePolicyKey)]
++	volumePolicy := &apis.CStorVolumePolicy{}
++	var err error
++	if policyName != """" {
++		klog.Infof(""uses cstorvolume policy for volume configuration"")
++		volumePolicy, err = c.clientset.OpenebsV1alpha1().CStorVolumePolicies(getNamespace()).Get(policyName, metav1.GetOptions{})
++		if err != nil {
++			return nil, err
++		}
++	}
+
+ 	klog.V(2).Infof(""creating cstorvolume service resource"")
+ 	svcObj, err := getOrCreateTargetService(cvc)",Better to push getting policy details into a func we can reuse later.,how does this work if the cluster doesn't have the volume policy?
+4811,"@@ -52,6 +52,14 @@ type outbound struct {
+ 	URL    string
+ }
+
++func (o outbound) Start() error {
++	return nil // nothing to do
++}
++
++func (o outbound) Stop() error {
++	return nil // nothing to do
++}
++
+ func (o outbound) Call(ctx context.Context, req *transport.Request) (*transport.Response, error) {
+ 	start := time.Now()
+ 	deadline, _ := ctx.Deadline()","optional: while there's nothing to do, a good way to catch bugs (where we use an outbound without calling `Start`) might be to have this outbound verify that `Start` is called before `Call` or `Stop`",What's the difference between `Start` and `Stop` here?
+4812,"@@ -20,6 +20,9 @@ import (
+ 	""flag""
+ 	""os""
+
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/apis""
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/aws/actuators/cluster""
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/aws/actuators/machine""
+ 	clusterapis ""sigs.k8s.io/cluster-api/pkg/apis""
+ 	""sigs.k8s.io/cluster-api/pkg/apis/cluster/common""
+ 	""sigs.k8s.io/cluster-api/pkg/client/clientset_generated/clientset""","Not a blocker by any means, but I think there is value in keeping the local imports in a separate group.",Please group all the `clusterapis` imports.
+4813,"@@ -295,3 +295,14 @@ func TestStartStopFailures(t *testing.T) {
+ 		}
+ 	}
+ }
++
++func TestNoOutboundsForService(t *testing.T) {
++	assert.Panics(t, func() {
++		NewDispatcher(Config{
++			Name: ""test"",
++			Outbounds: Outbounds{
++				""my-test-service"": {},
++			},
++		})
++	})
++}","nit - I would test the error message as well. For panic, you might need to see if the stack contains the error message, instead of equaling.",Would it be possible to have a single test
+4814,"@@ -162,6 +162,18 @@ func substitute(s reflect.Value, replacer *strings.Replacer) {
+ 		case *compute.Client, *storage.Client, context.Context, context.CancelFunc:
+ 			// We specifically do not want to change fields with these types.
+ 			continue
++		case *WaitForInstancesStopped:
++			var newSlice WaitForInstancesStopped
++			for _, v := range *raw.(*WaitForInstancesStopped) {
++				newSlice = append(newSlice, replacer.Replace(v))
++			}
++			f.Set(reflect.ValueOf(&newSlice))
++		case *WaitForInstancesSignal:
++			var newSlice WaitForInstancesSignal
++			for _, v := range *raw.(*WaitForInstancesSignal) {
++				newSlice = append(newSlice, replacer.Replace(v))
++			}
++			f.Set(reflect.ValueOf(&newSlice))
+ 		default:
+ 			if f.Kind() != reflect.Ptr {
+ 				continue",Didn't we have specific logic for handling slices vs structs?,I thought we were going to add `WaitForInst
+4815,"@@ -4199,7 +4199,15 @@ void EntityList::QuestJournalledSayClose(Mob *sender, float dist, const char *mo
+ 	buf.WriteInt32(0); // location, client doesn't seem to do anything with this
+ 	buf.WriteInt32(0);
+ 	buf.WriteInt32(0);
+-	buf.WriteString(message);
++
++	// auto inject saylinks (say)
++	if (RuleB(Chat, AutoInjectSaylinksToSay)) {
++		std::string new_message = EQ::SayLinkEngine::InjectSaylinksIfNotExist(message);
++		buf.WriteString(new_message.c_str());
++	}
++	else {
++		buf.WriteString(message);
++	}
+
+ 	auto outapp = new EQApplicationPacket(OP_SpecialMesg, buf);
+ ",`c_str()` is not needed.,"This should be `auto`, not `auto`."
+4816,"@@ -310,9 +310,12 @@ func installHandlers(c *ExtraConfig, s *genericapiserver.GenericAPIServer) {
+ 		})
+ 	}
+
++	if features.DefaultFeatureGate.Enabled(features.Egress) || features.DefaultFeatureGate.Enabled(features.ServiceExternalIP) {
++		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/externalippool"", webhook.HandlerForValidateFunc(c.externalIPPoolController.ValidateExternalIPPool))
++	}
++
+ 	if features.DefaultFeatureGate.Enabled(features.Egress) {
+ 		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/egress"", webhook.HandlerForValidateFunc(c.egressController.ValidateEgress))
+-		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/externalippool"", webhook.HandlerForValidateFunc(c.externalIPPoolController.ValidateExternalIPPool))
+ 	}
+
+ 	if features.DefaultFeatureGate.Enabled(features.AntreaIPAM) {",The handler will be installed twice if you don't remove the below one.,why is this endpoint no longer part of the API?
+4817,"@@ -35,9 +35,14 @@ public class EthashConfigOptions {
+     return JsonUtil.getLong(ethashConfigRoot, ""fixeddifficulty"");
+   }
+
++  public OptionalLong getEpochLengthActivationBlock() {
++    return JsonUtil.getLong(ethashConfigRoot, ""epochlengthactivation"");
++  }
++
+   Map<String, Object> asMap() {
+     final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
+     getFixedDifficulty().ifPresent(l -> builder.put(""fixeddifficulty"", l));
++    getEpochLengthActivationBlock().ifPresent(a -> builder.put(""epochlengthactivation"", a));
+     return builder.build();
+   }
+ }",How about putting `epochLength` (or something like that) in place of `a` just to make it easier to read,Nitpick: Since we have `OptionalLong` just for
+4818,"@@ -79,6 +79,14 @@ func (graph *BuildGraph) Target(label BuildLabel) *BuildTarget {
+ func (graph *BuildGraph) TargetOrDie(label BuildLabel) *BuildTarget {
+ 	target := graph.Target(label)
+ 	if target == nil {
++		// TODO(jpoole): This is just a small usability message to help with the migration from v15 to v16. We should
++		// probably remove this after a grace period.
++		if label.Subrepo == ""pleasings"" {
++			if _, ok := graph.subrepos[""pleasings""]; !ok {
++				log.Warning(""You've tried to use the pleasings sub-repo. This is no longer included automatically."")
++				log.Warning(""Use `plz init pleasings` to add the pleasings repo to your project."")
++			}
++		}
+ 		log.Fatalf(""Target %s not found in build graph\n"", label)
+ 	}
+ 	return target",Wouldn't this still fire afterwards if you created one called `pleasings`? or am I missing something?,s/`plz init pleasings`/`plz init pleasings`
+4819,"@@ -63,14 +63,14 @@ const kbpRecordPrefix = ""_keybase_pages.""
+ // _keybase_pages.meatball.gao.io   TXT ""kbp=/keybase/public/songgao/meatball/""
+ // _keybase_pages.song.gao.io       TXT ""kbp=/keybase/private/songgao,kb_bot/blah""
+ // _keybase_pages.blah.strib.io     TXT ""kbp=/keybase/private/strib#kb_bot/blahblahb"" ""lah/blah/""
+-// _keybase_pages.kbp.jzila.com     TXT ""kbp=git-keybase://private/jzila,kb_bot/kbp.git""
++// _keybase_pages.kbp.jzila.com     TXT ""kbp=git@keybase:private/jzila,kb_bot/kbp.git""
+ func LoadRootFromDNS(log *zap.Logger, domain string) (root Root, err error) {
+ 	var rootPath string
+
+ 	defer func() {
+ 		zapFields := []zapcore.Field{
+ 			zap.String(""domain"", domain),
+-			zap.String(""root_path"", rootPath),
++			zap.String(""kbp_record"", rootPath),
+ 		}
+ 		if err == nil {
+ 			log.Info(""LoadRootFromDNS"", zapFields...)","I don't love this syntax; it doesn't match anything we're currently doing and it's not obvious. Why isn't this `/keybase/private/jzila,kb_bot/.kbfs_autogit/public/jzila/kbp.git`?",Did you mean to also remove the `root_path` fie
+4820,"@@ -1135,11 +1135,17 @@ public final class Queue<T> extends AbstractsQueue<T, Queue<T>> implements Linea
+         return ofAll(toList().update(index, element));
+     }
+
+-    @SuppressWarnings(""unchecked"")
+     @Override
+     public <U> Queue<Tuple2<T, U>> zip(Iterable<? extends U> that) {
++        return zipWith(that, Tuple::of);
++    }
++
++    @SuppressWarnings(""unchecked"")
++    @Override
++    public <U, R> Queue<R> zipWith(Iterable<? extends U> that, BiFunction<? super T, ? super U, ? extends R> mapper) {
+         Objects.requireNonNull(that, ""that is null"");
+-        return ofAll(toList().zip((Iterable<U>) that));
++        Objects.requireNonNull(mapper, ""mapper is null"");
++        return ofAll(toList().zipWith((Iterable<U>) that, mapper));
+     }
+
+     @Override","Does a type-hint work instead of casting? `return ofAll(toList().<U> zipWith(that, mapper));` (Probably not, just a question.)","nit: redundant `@SuppressWarnings(""unchecked"")`"
+4821,"@@ -90,11 +90,11 @@ public class TestTableMetadata {
+     long previousSnapshotId = System.currentTimeMillis() - new Random(1234).nextInt(3600);
+     Snapshot previousSnapshot = new BaseSnapshot(
+         ops.io(), previousSnapshotId, null, previousSnapshotId, null, null, null, ImmutableList.of(
+-        new GenericManifestFile(localInput(""file:/tmp/manfiest.1.avro""), SPEC_5.specId())));
++          new GenericManifestFile(localInput(""file:/tmp/manfiest.1.avro""), SPEC_5.specId())));
+     long currentSnapshotId = System.currentTimeMillis();
+     Snapshot currentSnapshot = new BaseSnapshot(
+         ops.io(), currentSnapshotId, previousSnapshotId, currentSnapshotId, null, null, 7, ImmutableList.of(
+-        new GenericManifestFile(localInput(""file:/tmp/manfiest.2.avro""), SPEC_5.specId())));
++          new GenericManifestFile(localInput(""file:/tmp/manfiest.2.avro""), SPEC_5.specId())));
+
+     List<HistoryEntry> snapshotLog = ImmutableList.<HistoryEntry>builder()
+         .add(new SnapshotLogEntry(previousSnapshot.timestampMillis(), previousSnapshot.snapshotId()))",Are these required?,why do we need to change this?
+4822,"@@ -544,6 +544,13 @@ func (c *client) initClient() {
+ 	// Snapshots to avoid mutex access in fast paths.
+ 	c.out.wdl = opts.WriteDeadline
+ 	c.out.mp = opts.MaxPending
++	// Snapshot max control line since currently can not be changed on reload and we
++	// were checking it on each call to parse. If this changes and we allow MaxControlLine
++	// to be reloaded without restart, this code will need to change.
++	c.mcl = int32(opts.MaxControlLine)
++	if c.mcl == 0 {
++		c.mcl = MAX_CONTROL_LINE_SIZE
++	}
+
+ 	c.subs = make(map[string]*subscription)
+ 	c.echo = true","This is consistent for all clients that we will check yes? Seems like we should just use the singleton, maybe pass it to the parse function or since clients have a server pointer set it at server start and just access that way without locks?",Shouldn't this also set `c.maxControlLine = opt
+4823,"@@ -62,7 +62,7 @@ public class JavaTokenizer extends JavaCCTokenizer {
+
+         if (ignoreLiterals && (javaToken.kind == JavaTokenKinds.STRING_LITERAL
+                 || javaToken.kind == JavaTokenKinds.CHARACTER_LITERAL
+-                || javaToken.kind == JavaTokenKinds.DECIMAL_LITERAL
++                || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL
+                 || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL)) {
+             image = String.valueOf(javaToken.kind);
+         }","Note that this is a bug, that should be fixed on master. `DECIMAL_LITERAL` cannot match any token, because it's declared with a `#`.",hmmm... why did we change this?
+4824,"@@ -26,6 +26,8 @@ import (
+ 	""sync/atomic""
+ 	""time""
+
++	""github.com/nats-io/nuid""
++
+ 	""github.com/nats-io/nats-server/v2/server/pse""
+ )
+ ",Don't need extra line here.,This line should be removed as well.
+4825,"@@ -637,9 +637,7 @@ namespace Nethermind.JsonRpc.Test.Modules.Proof
+                 .Op(Instruction.DELEGATECALL)
+                 .Done;
+             CallResultWithProof result = TestCallWithCode(code);
+-
+-            // change in test after the modification to how the ReleaseSpec is delivered to the virtual machine
+-            Assert.AreEqual(2 + (_useNonZeroGasPrice ? 1 : 0), result.Accounts.Length);
++            Assert.AreEqual(3, result.Accounts.Length);
+         }
+
+         [Test]","For the first look, this change is strange. Were we passing these tests before?",The bug was due to non-zero gas pric
+4826,"@@ -21,9 +21,16 @@ import (
+ )
+
+ func gracefullyStopProcess(pid int) error {
+-	cmd := exec.Command(""taskkill"", ""/pid"", strconv.Itoa(pid))
++	fmt.Printf(""Stop..."")
++	// process on windows will not stop unless forced with /f
++	cmd := exec.Command(""taskkill"", ""/pid"", strconv.Itoa(pid), ""/f"")
+ 	if err := cmd.Run(); err != nil {
+ 		return fmt.Errorf(""taskkill: %v"", err)
+ 	}
+ 	return nil
+ }
++
++func matchProcess(appname string, processname string) bool {
++	// on Windows the process name will include the extension
++	return appname == processname+"".exe""
++}","On Windows, doesn't `os.Args[0]` include the `.exe`? What if you run the program like `caddy.exe`?",Why not use `strconv.Itoa`?
+4827,"@@ -112,13 +112,8 @@ type OpenvpnConfigNegotiator struct {
+ 	vpnConfig openvpn_service.VPNConfig
+ }
+
+-// ConsumeConfig doesn't do anything on the openvpn side, since it's not required here
+-func (ocn *OpenvpnConfigNegotiator) ConsumeConfig(json.RawMessage) error {
+-	return nil
+-}
+-
+ // ProvideConfig returns the config for user
+-func (ocn *OpenvpnConfigNegotiator) ProvideConfig() (session.ServiceConfiguration, error) {
++func (ocn *OpenvpnConfigNegotiator) ProvideConfig(json.RawMessage) (session.ServiceConfiguration, error) {
+ 	return &ocn.vpnConfig, nil
+ }
+ ","I don't see anywhere where `ServiceConfiguration` interface implementation would return any kind of error. Not sure if its needed, but we could ALWAYS return a valid 'pseudo' configuration without possibility of error.",@deads2k @jwforres @tnozicka do we n
+4828,"@@ -36,4 +36,15 @@ public class CommonRenderingUtilTest {
+     assertThat(CommonRenderingUtil.stripQuotes(""'a'bc'"")).isEqualTo(""'a'bc'"");
+     assertThat(CommonRenderingUtil.stripQuotes(""\""a\""bc\"""")).isEqualTo(""\""a\""bc\"""");
+   }
++
++  @Test
++  public void testGetDocLines() {
++    // Check that we don't care which form of line break is used.
++    assertThat(CommonRenderingUtil.getDocLines(""a\nb\nc"")).containsExactly(""a"", ""b"", ""c"").inOrder();
++    assertThat(CommonRenderingUtil.getDocLines(""a\rb\rc"")).containsExactly(""a"", ""b"", ""c"").inOrder();
++    assertThat(CommonRenderingUtil.getDocLines(""a\r\nb\r\nc""))
++        .containsExactly(""a"", ""b"", ""c"")
++        .inOrder();
++    assertThat(CommonRenderingUtil.getDocLines("""")).isEmpty();
++  }
+ }","Do we actually want to split on `\r`? I thought that the ""newline sequence"" was only `\r\n` on windows.","Can we change this to `assertThat(CommonRenderingUtil.getDocLines(""a\r\nb\r\nc"")).isEmpty();`?"
+4829,"@@ -273,10 +273,14 @@ void t_json_generator::write_type_spec(t_type* ttype) {
+     write_key_and_string(""valueTypeId"", get_type_name(vtype));
+     write_type_spec_object(""keyType"", ktype);
+     write_type_spec_object(""valueType"", vtype);
+-  } else if (ttype->is_list() || ttype->is_set()) {
++  } else if (ttype->is_list()) {
+     t_type* etype = ((t_list*)ttype)->get_elem_type();
+     write_key_and_string(""elemTypeId"", get_type_name(etype));
+     write_type_spec_object(""elemType"", etype);
++  } else if (ttype->is_set()) {
++    t_type* etype = ((t_set*)ttype)->get_elem_type();
++    write_key_and_string(""elemTypeId"", get_type_name(etype));
++    write_type_spec_object(""elemType"", etype);
+   }
+ }
+ ",Nit: these lines are duplicated from above. They can be refactored by setting etype in a conditional and putting 282 and 283 below that.,Looks like there's a tab character missing here.
+4830,"@@ -49,7 +49,7 @@ func (s *Server) handleSignals() {
+ 				s.Debugf(""Trapped %q signal"", sig)
+ 				switch sig {
+ 				case syscall.SIGINT:
+-					s.Noticef(""Server Exiting.."")
++					s.Shutdown()
+ 					os.Exit(0)
+ 				case syscall.SIGUSR1:
+ 					// File log re-open for rotating file logs.","I would do an s.Notice(""Initiating Shutdown..."") then after Shutdown() do the original Server Exiting.",I don't think we need to do this. We already have a log statement in the `switch` statement ab
+4831,"@@ -57,6 +57,11 @@ namespace Nethermind.DataMarketplace.Consumers.Refunds.Services
+             ulong now = _timestamper.UnixTime.Seconds;
+             if (!deposit.CanClaimRefund(now))
+             {
++                var timeLeftToClaimRefund = deposit.GetTimeLeftToClaimRefund(now);
++                if (timeLeftToClaimRefund > 0)
++                {
++                    if (_logger.IsError) _logger.Info($""Time left to claim a refund: {timeLeftToClaimRefund} seconds."");
++                }
+                 return RefundClaimStatus.Empty;
+             }
+             ",Not sure with how many seconds on average are we dealing with but maybe it's better to have hh:mm:ss format in logs - you can make it with `TimeSpan.FromSeconds(seconds).ToString()`,You might want to use string interpolation here.
+4832,"@@ -257,6 +257,12 @@ func (a *ClusterDeploymentValidatingAdmissionHook) validateCreate(admissionSpec
+ 		if aws.Region == """" {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""region""), ""must specify AWS region""))
+ 		}
++		for i, mp := range newObject.Spec.Compute {
++			computePath := specPath.Child(""compute"").Index(i)
++			if mp.Platform.AWS == nil {
++				allErrs = append(allErrs, field.Required(computePath.Child(""aws""), ""must specify platform for compute machine sets""))
++			}
++		}
+ 	}
+ 	if newObject.Spec.Platform.Azure != nil {
+ 		numberOfPlatforms++",Why is this required? The user should be able to omit it and use the defaults.,"shouldn't this be `specPath.Child(""platform"").Child(""aws""),`?"
+4833,"@@ -1353,6 +1353,12 @@ class MouseSettingsPanel(SettingsPanel):
+ 		self.audioDetectBrightnessCheckBox=sHelper.addItem(wx.CheckBox(self,label=audioDetectBrightnessText))
+ 		self.audioDetectBrightnessCheckBox.SetValue(config.conf[""mouse""][""audioCoordinates_detectBrightness""])
+
++		# Translators: This is the label for a checkbox in the
++		# mouse settings panel.
++		handleInjectedMouseControlText = _(""Handle mouse control from other &applications"")
++		self.handleInjectedMouseControlCheckBox=sHelper.addItem(wx.CheckBox(self,label=handleInjectedMouseControlText))
++		self.handleInjectedMouseControlCheckBox.SetValue(config.conf[""mouse""][""handleInjectedMouseControl""])
++
+ 	def onSave(self):
+ 		config.conf[""mouse""][""reportMouseShapeChanges""]=self.shapeCheckBox.IsChecked()
+ 		config.conf[""mouse""][""enableMouseTracking""]=self.mouseTrackingCheckBox.IsChecked()","I don't think the naming of this setting conveys what it does. Maybe something like ""Ignore mouse movement triggered by other applications""","What's the reason for this name? ""Handle mouse control from o"
+4834,"@@ -26,11 +26,12 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation
+         public static readonly OpenTelemetryProtocolExporterEventSource Log = new OpenTelemetryProtocolExporterEventSource();
+
+         [NonEvent]
+-        public void FailedToReachCollector(Exception ex)
++        public void FailedToReachCollector(Uri collectorUri, Exception ex)
+         {
+             if (Log.IsEnabled(EventLevel.Error, EventKeywords.All))
+             {
+-                this.FailedToReachCollector(ex.ToInvariantString());
++                var rawCollectorUri = collectorUri.ToString();
++                this.FailedToReachCollector(rawCollectorUri, ex.ToInvariantString());
+             }
+         }
+ ",Didn't went with backwards compatibility since it's still in beta,Do we still need this `if (Log.IsEnabled(EventLevel.All))` ch
+4835,"@@ -82,6 +82,9 @@ python::tuple fragmentMolHelper3(const RDKit::ROMol& mol, python::object ob,
+   std::vector<std::pair<RDKit::ROMOL_SPTR, RDKit::ROMOL_SPTR>> tres;
+   std::unique_ptr<std::vector<unsigned int>> v =
+       pythonObjectToVect<unsigned int>(ob);
++  if (!v) {
++    throw_value_error(""invalid value for bondsToCut"");
++  }
+   bool ok = RDKit::MMPA::fragmentMol(mol, tres, *v, minCuts, maxCuts);
+   python::list pyres;
+   if (ok) {",Perhaps bondsToCut must be None or non empty.,"This should be `throw_value_error(""invalid value for bondsToC"
+4836,"@@ -79,6 +79,7 @@ function Sparkline( {
+ 	return (
+ 		<div className=""googlesitekit-analytics-sparkline-chart-wrap"">
+ 			<GoogleChart
++				chartType=""line""
+ 				data={ data }
+ 				options={ chartOptions }
+ 				// eslint-disable-next-line sitekit/camelcase-acronyms","See above, we could avoid adding that (same applies below).",Can we add the `chartType` prop to the `GoogleChart` component please?
+4837,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long,"I don't think this is the right place to do this, since this is used i"
+4838,"@@ -1,6 +1,7 @@
+ 'use strict';
+
+ var assert = require('assert');
++const expect = require('chai').expect;
+ var co = require('co');
+ var test = require('./shared').assert;
+ var setupDatabase = require('./shared').setupDatabase;",Should the rest of the file be updated to use `expect` or should this test use the same format as the rest of the tests?,This should be `chai-expect`.
+4839,"@@ -227,6 +227,12 @@ func (a *AWSActuator) Refresh() error {
+ 		}
+ 		logger.Debug(""Found hosted zone"")
+ 		a.zoneID = &zoneID
++
++		// Update dnsZone status now that we have the zoneID
++		if err := a.ModifyStatus(); err != nil {
++			a.logger.WithError(err).Error(""failed to update status after refresh"")
++			return err
++		}
+ 	}
+
+ 	if a.zoneID == nil {",How would you feel about a different approach where the `DeleteAWSRecordSets` gets passed the zone ID and zone name rather than the `DNSZone`?,What do you think about moving the `a.zoneID = &zoneID` above this lin
+4840,"@@ -66,15 +66,17 @@ class PhotoMetricDistortion(object):
+
+ class Expand(object):
+
+-    def __init__(self, mean=(0, 0, 0), to_rgb=True, ratio_range=(1, 4)):
++    def __init__(self, mean=(0, 0, 0), to_rgb=True,
++                 ratio_range=(1, 4), prob=0.5):
+         if to_rgb:
+             self.mean = mean[::-1]
+         else:
+             self.mean = mean
+         self.min_ratio, self.max_ratio = ratio_range
++        self.prob = prob
+
+     def __call__(self, img, boxes, labels):
+-        if random.randint(2):
++        if random.uniform(0, 1) > self.prob:
+             return img, boxes, labels
+
+         h, w, c = img.shape","it seems `random.uniform(0, 1)` similar to `random.randint(2)`, all have 1/2 probabilities.","Do we need to set `self.prob` to a much lower value, or can we just use `self.min_ratio = min_ratio`?"
+4841,"@@ -121,7 +121,11 @@ class AutoScaleConnection(AWSQueryConnection):
+         for i in xrange(1, len(items)+1):
+             if isinstance(items[i-1], dict):
+                 for k, v in items[i-1].iteritems():
+-                    params['%s.member.%d.%s' % (label, i, k)] = v
++                    if isinstance(v, dict):
++                        for kk, vv in v.iteritems():
++                            params['%s.member.%d.%s.%s' % (label, i, k, kk)] = vv
++                    else:
++                        params['%s.member.%d.%s' % (label, i, k)] = v
+             elif isinstance(items[i-1], basestring):
+                 params['%s.member.%d' % (label, i)] = items[i-1]
+ ","Added to support EBS volume creation, used like this: blockDeviceMap = [] blockDeviceMap.append( {'DeviceName':'/dev/sdc', 'VirtualName' : 'ephemeral0'}) blockDeviceMap.append( {'DeviceName':'/dev/sdh', 'Ebs': {'VolumeSize' : '100'} })","I think what you want here is `params['%s.member.%s.%s' % (label, i, k)] = v`"
+4842,"@@ -17,6 +17,8 @@ type mockedSigner struct {
+ 	signatureToReturn identity.Signature
+ }
+
++var testMysteriumApiUrl = ""http://testUrl""
++
+ func (signer *mockedSigner) Sign(message []byte) (identity.Signature, error) {
+ 	return signer.signatureToReturn, nil
+ }","We shouldn't depend that url is `mysterium` - it can be just `testRequestURL`. Also, `URL` has to be upper-case.",Do we need this? It seems to only be used in `signer.go`?
+4843,"@@ -689,8 +689,9 @@ VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceImageFormatProperties2(VkPhysica
+                                                                        const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
+                                                                        VkImageFormatProperties2 *pImageFormatProperties) {
+     instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
+-    bool skip = PreCallValidateGetPhysicalDeviceImageFormatProperties2(instance_data->report_data, pImageFormatInfo,
+-                                                                       pImageFormatProperties);
++    unique_lock_t lock(global_lock);
++    bool skip = PreCallValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties);
++    lock.unlock();
+     if (skip) {
+         return VK_ERROR_VALIDATION_FAILED_EXT;
+     } else {",We could delay this look-up now and only do it in the non-skip case. I suspect this is true for (almost) all of the top-level refactored functions.,Don't need unique_lock
+4844,"@@ -144,6 +144,15 @@ std::string MetaServiceUtils::schemaTagKey(GraphSpaceID spaceId, TagID tagId, in
+     return key;
+ }
+
++std::string MetaServiceUtils::schemaTagPrefix(GraphSpaceID spaceId, TagID tagId) {
++    std::string key;
++    key.reserve(kTagsTable.size() + sizeof(GraphSpaceID) + sizeof(TagID));
++    key.append(kTagsTable.data(), kTagsTable.size());
++    key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
++    key.append(reinterpret_cast<const char*>(&tagId), sizeof(tagId));
++    return key;
++}
++
+ std::string MetaServiceUtils::schemaTagsPrefix(GraphSpaceID spaceId) {
+     std::string key;
+     key.reserve(kTagsTable.size() + sizeof(GraphSpaceID));","Typically, to be simple, we could reserve a const length space.",Can't you just pass `kTagsTable` and `kTagsTable.size()` as `const char*` instead of `reinterpret_cast`?
+4845,"@@ -0,0 +1,2 @@
++from .reader import *
++from .builder import Builder",Need to add a license and copyright header to each file.,"I don't think that's correct. This import is only used to import `__init__.py` modules, not user-facing "
+4846,"@@ -7,6 +7,8 @@
+   <% end %>
+
+   <%= form.inputs do %>
++    <%= hidden_field_tag ""coupon_id"" %>
++
+     <% if signed_out? %>
+       <ul class=""checkout-signin-signup-toggle"">
+         <li>","If I'm not mistaken, this line is now outside of the `if signed_out?` block, right? Any concerns about that? Seems odd that we wouldn't accept coupons for signed in users, but I want to make sure we understand the ramifications of this change.","I would prefer to have constant for it, like `checkout_coupon_id` or similar."
+4847,"@@ -130,7 +130,7 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
+
+     @NotNull
+     @Override
+-    public DBPDataSource getDataSource() {
++    public PostgreDataSource getDataSource() {
+         return owner.getDataSource();
+     }
+ ",Please remove the unused import of DBPDataSource.,"This looks like a typo, should be `DBPDataSource`."
+4848,"@@ -43,7 +43,7 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+
+         public void LogError(string data)
+         {
+-            _log.LogError(data);
++            _log.LogWarning(data);
+         }
+
+         public void LogInformation(string data)","I think you should add some extra message here saying it was originally sent as an error, for diagnosability.",Is this change related to the bug?
+4849,"@@ -144,14 +144,14 @@ void test3() {
+     ExplicitBitVect bv(2048);
+     AvalonTools::getAvalonFP(""c1cocc1"", true, bv, 2048, false, true, 0x006FFF);
+     BOOST_LOG(rdInfoLog) << ""c1cocc1 "" << bv.getNumOnBits() << std::endl;
+-    TEST_ASSERT(bv.getNumOnBits() == 53);
++    TEST_ASSERT(bv.getNumOnBits() == 48);
+   }
+   {
+     ExplicitBitVect bv(2048);
+     AvalonTools::getAvalonFP(""C1=COC=C1"", true, bv, 2048, false, true,
+                              0x006FFF);
+     BOOST_LOG(rdInfoLog) << ""C1=COC=C1 "" << bv.getNumOnBits() << std::endl;
+-    TEST_ASSERT(bv.getNumOnBits() == 53);
++    TEST_ASSERT(bv.getNumOnBits() == 48);
+   }
+
+   BOOST_LOG(rdInfoLog) << ""done"" << std::endl;",I believe that all the changes in this file are not valid for v1.2 of the Avalon toolkit.,This is a test case that should be
+4850,"@@ -509,6 +509,7 @@ public class DBService {
+         } else {
+             // carrying over auditEnabled from original role
+             role.setAuditEnabled(originalRole.getAuditEnabled());
++            mergeOriginalRoleAndMetaRoleAttributes(originalRole, role);
+             requestSuccess = con.updateRole(domainName, role);
+         }
+         ",we cannot change the behavior of the processRole - that method is used in lots of places. this call must be done only in the method where templates are being handled.,Maybe I'm missing something but I
+4851,"@@ -63,7 +63,9 @@ const (
+ 	// ECSAgentExecConfigDir is the directory where ECS Agent will write the ExecAgent config files to
+ 	ECSAgentExecConfigDir = ecsAgentExecDepsDir + ""/"" + ContainerConfigDirName
+ 	// HostExecConfigDir is the dir where ExecAgents Config files will live
+-	HostExecConfigDir = hostExecDepsDir + ""/"" + ContainerConfigDirName
++	HostExecConfigDir          = hostExecDepsDir + ""/"" + ContainerConfigDirName
++	ExecAgentLogConfigFileName = ""seelog.xml""
++	ContainerLogConfigFile     = ""configuration/"" + ExecAgentLogConfigFileName
+ )
+
+ var (",I think we probably want to follow the same naming convention that we do with `execAgentConfigFileNameTemplate` (using the SHA in the name of the file). This file might be confgurable in the future and when that happens we will be ready. Plus it's pretty much the same code that we already use for the config file.,why are we changing this?
+4852,"@@ -380,6 +380,14 @@ static void send_resource_update(struct link *manager)
+ 		total_resources->disk.total    = MAX(0, local_resources->disk.total);
+ 		total_resources->disk.largest  = MAX(0, local_resources->disk.largest);
+ 		total_resources->disk.smallest = MAX(0, local_resources->disk.smallest);
++
++		//if workers are set to expire at some time, send the amount of time left to manager
++		if(manual_wall_time_option != 0) {
++			total_resources->time_left = worker_start_time + manual_wall_time_option - time(0);
++		}
++		else {
++			total_resources->time_left = -1;
++		}
+ 	}
+
+ 	work_queue_resources_send(manager,total_resources,stoptime);","If following above, this would be: end_time = time(0) + manual_wall_time_option, which is simpler. Also, make the check manual_wall_time_option > 0, otherwise negative times would terminate the worker right away.",Space after `if`.
+4853,"@@ -116,6 +116,10 @@ func (err wrappedFatalError) Cause() error {
+ 	return err.error
+ }
+
++func (err wrappedFatalError) Unwrap() error {
++	return err.error
++}
++
+ // IsFatalError returns true if err conforms to the Fatal interface
+ // and calling the Fatal method returns true.
+ func IsFatalError(err error) (isFatal bool) {",If we aren't using `errors.Is` we don't need the `Unwrap` as we have `Cause` which is what pkg/errors uses.,why is this neede
+4854,"@@ -4,8 +4,9 @@ import (
+ 	""io/ioutil""
+ 	""os""
+
++	""k8s.io/klog""
++
+ 	""github.com/kubeedge/beehive/pkg/common/config""
+-	""github.com/kubeedge/beehive/pkg/common/log""
+ 	""github.com/kubeedge/beehive/pkg/core""
+ 	""github.com/kubeedge/beehive/pkg/core/context""
+ 	""github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/channelq""",redundant empty line,nit: remove empty
+4855,"@@ -150,6 +150,7 @@ bool ConfigManager::load()
+ 	boolean[ONLINE_OFFLINE_CHARLIST] = getGlobalBoolean(L, ""showOnlineStatusInCharlist"", false);
+ 	boolean[YELL_ALLOW_PREMIUM] = getGlobalBoolean(L, ""yellAlwaysAllowPremium"", false);
+ 	boolean[FORCE_MONSTERTYPE_LOAD] = getGlobalBoolean(L, ""forceMonsterTypesOnLoad"", true);
++	boolean[HOUSE_OWNED_BY_ACCOUNT] = getGlobalBoolean(L, ""houseOwnedByAccount"", false);
+
+ 	string[DEFAULT_PRIORITY] = getGlobalString(L, ""defaultPriority"", ""high"");
+ 	string[SERVER_NAME] = getGlobalString(L, ""serverName"", """");",The config.lua.dist still shows `houseAccountOwner`,This should be se
+4856,"@@ -11,7 +11,6 @@
+
+ namespace Sonata\MediaBundle\Command;
+
+-use Sonata\ClassificationBundle\Model\ContextInterface;
+ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+ use Symfony\Component\Console\Input\InputInterface;
+ use Symfony\Component\Console\Output\OutputInterface;",I think we can leave this import and use non FQNs in the code.,Why did you remove this command?
+4857,"@@ -1654,9 +1654,10 @@ class TargetLocator {
+    *     when the driver has changed focus to the specified window.
+    */
+   window(nameOrHandle) {
++    let paramName = this.driver_.getExecutor().w3c ? 'handle' : 'name';
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter(paramName, nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ",I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs,Does this also need to change in
+4858,"@@ -79,11 +79,9 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
+         {
+             Log.LogMessage(MessageImportance.Low, $""START pushing items to feed"");
+-            Random rnd = new Random();
+
+             try
+             {
+-
+                 bool result = await PushAsync(items.ToList(), allowOverwrite);
+                 return result;
+             }",We should probably exit early if there are no items in the list.,Why are we removing this?
+4859,"@@ -16,7 +16,7 @@ def _private_func3(param1):  # [missing-raises-doc]
+     raise Exception('Example')
+
+
+-def public_func1(param1):  # [missing-param-doc, missing-type-doc]
++def public_func1(param1):  # [missing-any-param-doc]
+     """"""This is a test docstring without params""""""
+     print(param1)
+ ",As we can't use old names we should warn in whats new for 2.12 that this can happen.,The missing-param-doc should als
+4860,"@@ -0,0 +1,13 @@
++// +build testbincover
++
++package main
++
++import (
++	""testing""
++
++	""github.com/confluentinc/bincover""
++)
++
++func TestBincoverRunMain(t *testing.T) {
++	bincover.RunTest(main)
++}","good job finding this package, I hope it's actively maintained",The convention is to call this package `bincover_test.go` and then call `bincover.RunTest(main)` in the test.go file.
+4861,"@@ -82,7 +82,6 @@ void getDevicePCIBusNum(int deviceID, char* pciBusID) {
+
+ int main() {
+     unsetenv(""HIP_VISIBLE_DEVICES"");
+-    unsetenv(""CUDA_VISIBLE_DEVICES"");
+
+     std::vector<std::string> devPCINum;
+     char pciBusID[100];",same changes as in hipEnvVar.cpp,Although the HIP_VISIBLE_DEVICES would not have any effect any more since the env vars are set above.
+4862,"@@ -1,6 +1,11 @@
++#ifndef _POSIX_C_SOURCE
++#define _POSIX_C_SOURCE 200809L
++#endif
++#include <string.h>
+ #include <assert.h>
+ #include <libinput.h>
+ #include <stdlib.h>
++#include <wayland-util.h>
+ #include <wlr/backend/session.h>
+ #include <wlr/interfaces/wlr_tablet_tool.h>
+ #include <wlr/types/wlr_input_device.h>",NULL check should be before this line,Please `#include` standard library headers after `#include` standard library headers.
+4863,"@@ -177,7 +177,7 @@ public class WildernessLocationsPlugin extends Plugin
+ 			|| (this.pvpWorld && WorldType.isAllPvpWorld(client.getWorldType())));
+ 		if (renderLocation)
+ 		{
+-			if (client.getLocalPlayer().getWorldLocation() != worldPoint)
++			if (client.getLocalPlayer() != null && client.getLocalPlayer().getWorldLocation() != worldPoint)
+ 			{
+ 				locationString = WorldLocation.location(client.getLocalPlayer().getWorldLocation());
+ 				worldPoint = client.getLocalPlayer().getWorldLocation();","Seems like client.getlocalplayer is being called a lot, would it be worth it to do final Player player = client.getlocalplayer?",The world location should be set to the world type of the player rather than the player location
+4864,"@@ -116,9 +116,9 @@ ex_expr::exp_return_type ex_comp_clause::processNulls(char *op_data[],
+        // then move boolean unknown value to result and return.
+        if (getOperand(i)->getNullFlag() && (!op_data[i])) // missing value
+    	{
+-   	  // move null value to result.
+-   	  *(Lng32 *)op_data[2 * MAX_OPERANDS] = -1;
+-   	  return ex_expr::EXPR_NULL;
++            // move null value to result.
++            *(Lng32 *)op_data[2 * MAX_OPERANDS] = 0;
++            return ex_expr::EXPR_NULL;
+    	}
+      }
+    ","this change is not correct. 3-valued boolean logic requires that comparison of null to another value during intermediate operations should make the result null and not false. The place where null becomes false is at the very end of that expression. As an example, with the changed logic, this expression will return incorrect result. select * from t where not (a = 1); if a is null, the where predicate will become true which is incorrect. With the original 3-valued result, the where pred will become false and not return any result.",Shouldn't this be -1 ?
+4865,"@@ -95,6 +95,7 @@ func NewReplacer(r *http.Request, rr *ResponseRecorder, emptyValue string) Repla
+ 				dir, _ := path.Split(r.URL.Path)
+ 				return dir
+ 			}(),
++			""{locale}"": r.Header.Get(""Detected-Locale""),
+ 		},
+ 		emptyValue: emptyValue,
+ 	}","This can already be done with `{>Detected-Locale}`, why make another way to do it?","Is this header ""Detect"
+4866,"@@ -2376,10 +2376,11 @@ public class DatasetPage implements java.io.Serializable {
+                 requestContext.execute(""PF('selectFilesForRestrict').show()"");
+             return """";
+         } else {
+-            boolean validSelection = false;
++            boolean validSelection = true;
+             for (FileMetadata fmd : selectedFiles) {
+-                if (!fmd.isRestricted() ){
+-                    validSelection = true;
++                if (fmd.isRestricted() == true) {
++                    validSelection = false;
++                    break;
+                 }
+             }
+             if (!validSelection) {",These changes just match the logic update in the next method that was done previously - to assure the whole set of files is valid rather than that there is at least one that would be changed.,Why not replace the `i
+4867,"@@ -30,6 +30,11 @@ func (s *server) bytesUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 		jsonhttp.InternalServerError(w, ""cannot get or create tag"")
+ 		return
+ 	}
++	w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))
++	w.WriteHeader(http.StatusContinue)
++	if f, ok := w.(http.Flusher); ok {
++		f.Flush()
++	}
+
+ 	// Add the tag to the context
+ 	ctx := sctx.SetTag(r.Context(), tag)",Why setting the status to Continue as at the end it is written OK? Status should be written only once.,I think `w.WriteHeader
+4868,"@@ -140,10 +140,10 @@ func deps() {
+ 		cmd(""go get -u github.com/pmezard/go-difflib/difflib""),
+ 		cmd(""./scripts/install-rust-proofs.sh""),
+ 		cmd(""./scripts/install-bls-signatures.sh""),
++		cmd(""./proofs/bin/paramcache""),
++		cmd(""./scripts/copy-groth-params.sh""),
+ 	}
+
+-	cmds = append(cmds, hydrateParamCache()...)
+-
+ 	for _, c := range cmds {
+ 		runCmd(c)
+ 	}","Howdy! You'll want to do this same thing (replace `hydrateParamCache` with `proofs/bin/paramcache` and then do the copy) in `smartdeps`, too.",Do we still need to run `hydratedParamCache()`?
+4869,"@@ -46,6 +46,16 @@ import (
+
+ // CmdSnaphotCreateOptions holds the options for snapshot
+ // create command
++var (
++	snapshotCreateCommandHelpText = `
++	usage: mayactl snapshot create --volname <vol> --snapname <snap>
++
++	this command creates a volume snapshot
++
++	note: the volume should exit before itself
++	`
++)
++
+ type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string",nit : Remove the extra lines,`this command creates a volume snapshot`
+4870,"@@ -184,6 +184,7 @@ type Options struct {
+ 	ServerName            string        `json:""server_name""`
+ 	Host                  string        `json:""addr""`
+ 	Port                  int           `json:""port""`
++	DontListen            bool          `json:""dont_listen""`
+ 	ClientAdvertise       string        `json:""-""`
+ 	Trace                 bool          `json:""-""`
+ 	Debug                 bool          `json:""-""`","Instead of adding a new option, I wonder if we could decide on a port that would disable listening. For instance, port set to 0 means that we use default port 4222. Setting to -1 means that we let OS pick a random free port. We could say anything negative lower than -1 (say -2) means disabled? You don't have to update the PR for that, just wondering if that would be better or not and let's see what others think.",why did you choose `dont_listen` instead of `li
+4871,"@@ -2511,6 +2511,9 @@ class ThriftRequestHandler(object):
+             if report.metadata:
+                 return report.metadata.get(""analyzer"", {}).get(""name"")
+
++            if report.check_name.startswith('clang-diagnostic-'):
++                return 'clang-tidy'
++
+         # Processing PList files.
+         _, _, report_files = next(os.walk(report_dir), ([], [], []))
+         all_report_checkers = set()",Should we add some default case if non of the above return some analyzer name? Something like `unknown analyzer`?,I don't think this should be in the `ReportRepo
+4872,"@@ -115,7 +115,7 @@ module Faker
+           keywords << :special_characters if legacy_special_characters != NOT_GIVEN
+         end
+
+-        min_alpha = mix_case ? 2 : 0
++        min_alpha = mix_case && min_length > 1 ? 2 : 0
+         temp = Lorem.characters(number: min_length, min_alpha: min_alpha)
+         diff_length = max_length - min_length
+ ",Nvm. The original version is best... *hides from the angry rubocop*,Style/NumericPredicate: Use min_length > 1 instead of min_length > 1.
+4873,"@@ -100,14 +100,13 @@ func (c *client) Call(
+ 		return nil, err
+ 	}
+
+-	body, cleanup, err := marshal(req.Encoding, protoReq)
++	body, err := marshal(req.Encoding, protoReq)
+ 	if err != nil {
+ 		return nil, yarpcencoding.RequestBodyEncodeError(req, err)
+ 	}
+-	defer cleanup()
+
+ 	reqBuf := &yarpc.Buffer{}
+-	if _, err := reqBuf.Write(body); err != nil {
++	if _, err := reqBuf.Write(body.Bytes()); err != nil {
+ 		return nil, err
+ 	}
+ ","we can drop this and use the returned body above, right?",I removed the `cleanup` call here because it shouldn't have been call
+4874,"@@ -142,12 +142,12 @@ module Travis
+
+             def install
+               sh.if ""$(rvm use $(travis_internal_ruby) do ruby -e \""puts RUBY_VERSION\"") = 1.9*"" do
+-                cmd(dpl_install_command(WANT_18), echo: false, assert: !allow_failure, timing: true)
++                cmd(dpl_install_command(WANT_18), echo: true, assert: !allow_failure, timing: true)
+               end
+               sh.else do
+-                cmd(dpl_install_command, echo: false, assert: !allow_failure, timing: true)
++                cmd(dpl_install_command, echo: true, assert: !allow_failure, timing: true)
+               end
+-              sh.cmd ""rm -f dpl-*.gem"", echo: false, assert: false, timing: false
++              sh.cmd ""rm -f $TRAVIS_BUILD_DIR/dpl-*.gem"", echo: false, assert: false, timing: false
+             end
+
+             def run_command(assert = !allow_failure)",Is echoing enabled on purpose here or it's a remainder of your tests?,"If I understand correctly, this is just to remove the `dpl-*.gem` fil"
+4875,"@@ -98,6 +98,7 @@ module Bolt
+     end
+
+     def run_command(targets, command, options = {}, &callback)
++      @logger.notice(options['_description']) if options.key?('_description')
+       @logger.info(""Starting command run '#{command}' on #{targets.map(&:uri)}"")
+       notify = proc { |event| @notifier.notify(callback, event) if callback }
+       options = { '_run_as' => run_as }.merge(options) if run_as",I think this should just be worked into the next message and follow the verbosity of it.,Rubocop got mad at this so I fixed it.
+4876,"@@ -106,6 +106,7 @@ export const selectors = {
+ 	 *
+ 	 * @since 1.14.0
+ 	 *
++	 * @param {Object} urlParams URL parameters to be passed to the query.
+ 	 * @return {(string|undefined)} AdSense account site overview URL (or `undefined` if not loaded).
+ 	 */
+ 	getServiceAccountSiteURL: createRegistrySelector( ( select ) => () => {",This also needs to be reverted.,Could you update `since` to 1.14.0?
+4877,"@@ -105,6 +105,13 @@ const (
+ 	TLFJournalBackgroundWorkEnabled
+ )
+
++type tlfJournalPauseType int
++
++const (
++	journalPausedFromConflict tlfJournalPauseType = 1 << iota
++	journalPausedFromSignal
++)
++
+ func (bws TLFJournalBackgroundWorkStatus) String() string {
+ 	switch bws {
+ 	case TLFJournalBackgroundWorkEnabled:","`FromCommand` seems to fit better, since with my suggestion below, all pauses will raise a signal on `needPause`. Also maybe the format `journalPauseConflict` and `journalPauseCommand` is better, since the journal isn't necessarily paused yet once we raise a pause signal.",should this be TLFJournalPauseType
+4878,"@@ -236,7 +236,7 @@ func IsServiceNonRetryableError(err error) bool {
+ // IsServiceNonRetryableErrorGRPC checks if the error is a non retryable error.
+ func IsServiceNonRetryableErrorGRPC(err error) bool {
+ 	if err == context.DeadlineExceeded {
+-		return true
++		return false
+ 	}
+
+ 	if st, ok := status.FromError(err); ok {",This is fix from another PR #120.,I don't think this is correct. If t
+4879,"@@ -20,7 +20,9 @@ class MultiInterface(Interface):
+
+     datatype = 'multitabular'
+
+-    subtypes = ['dataframe', 'dictionary', 'array', 'dask']
++    subtypes = ['dictionary', 'dataframe', 'array', 'dask']
++
++    multi = True
+
+     @classmethod
+     def init(cls, eltype, data, kdims, vdims):","I *think* it makes sense to try the more general dictionary (i.e standard python literals) format first. Might be other implications I haven't figured out yet. Then again, ``MultiInterface`` is pretty new so it probably doesn't matter wrt backwards compatibility.",Is this necessary?
+4880,"@@ -32,9 +32,13 @@ class FixMediaContextCommand extends ContainerAwareCommand
+      */
+     public function execute(InputInterface $input, OutputInterface $output)
+     {
++        if (!$this->getContainer()->has('sonata.media.manager.category')) {
++            throw new \LogicException('The classification feature is disabled.');
++        }
++
+         $pool = $this->getContainer()->get('sonata.media.pool');
+         $contextManager = $this->getContainer()->get('sonata.classification.manager.context');
+-        $cateoryManager = $this->getContainer()->get('sonata.classification.manager.category');
++        $categoryManager = $this->getContainer()->get('sonata.media.manager.category');
+
+         foreach ($pool->getContexts() as $context => $contextAttrs) {
+             /** @var ContextInterface $defaultContext */",lol that variable name,Shouldn't this be `if (!$this->getContainer()->has('sonata.media.manager.category')) {`
+4881,"@@ -31,8 +31,8 @@ const (
+ 	ChainFilterForward = ChainNamePrefix + ""-FORWARD""
+ 	ChainFilterOutput  = ChainNamePrefix + ""-OUTPUT""
+
+-	ChainFailsafeIn  = ChainNamePrefix + ""-FAILSAFE-IN""
+-	ChainFailsafeOut = ChainNamePrefix + ""-FAILSAFE-OUT""
++	ChainFailsafeIn  = ChainNamePrefix + ""-failsafe-in""
++	ChainFailsafeOut = ChainNamePrefix + ""-failsafe-out""
+
+ 	ChainNATPrerouting  = ChainNamePrefix + ""-PREROUTING""
+ 	ChainNATPostrouting = ChainNamePrefix + ""-POSTROUTING""",Upper case is reserved for our versions of top-level chains i.e. the `FORWARD` chain jumps to `cali-FORWARD`.,@LeoHChen I'm not sure if this is the best way to change the default behavior for Fails
+4882,"@@ -3373,10 +3373,14 @@ void nano::json_handler::receive ()
+ 					}
+ 					if (!ec)
+ 					{
++						// Representative is only used by receive_action when opening accounts
++						// Set a wallet default representative for new accounts
++						nano::account representative (wallet->store.representative (node.wallets.tx_begin_read ()));
++
+ 						bool generate_work (work == 0); // Disable work generation if ""work"" option is provided
+ 						auto response_a (response);
+ 						// clang-format off
+-						wallet->receive_async(std::move(block), account, node.network_params.ledger.genesis_amount, [response_a](std::shared_ptr<nano::block> block_a) {
++						wallet->receive_async(std::move(block), representative, node.network_params.ledger.genesis_amount, [response_a](std::shared_ptr<nano::block> block_a) {
+ 							if (block_a != nullptr)
+ 							{
+ 								boost::property_tree::ptree response_l;",json_handler::receive () has already started a read tx that can be used here right?,"why do you need it, it should already be set by receive_async"
+4883,"@@ -84,6 +84,9 @@ describe( 'CompatibilityChecks', () => {
+ 	it( 'should make API requests to ""setup-checks, health-checks and AMP Project test URL', async () => {
+ 		const token = 'test-token-value';
+
++		global._googlesitekitBaseData = global._googlesitekitBaseData || {};
++		global._googlesitekitBaseData[ 'isWP5.0+' ] = true;
++
+ 		// Mock request to setup-tag.
+ 		fetchMock.postOnce(
+ 			/^\/google-site-kit\/v1\/core\/site\/data\/setup-tag/,",We should add the definition to `.storybook/config.js` as well.,Minor: Would it be safer to set `global._googlesitekitBaseData = global._googlesitekitB
+4884,"@@ -96,7 +96,7 @@ ex_expr::exp_return_type ex_branch_clause::eval(char *op_data[],
+   switch (getOperType())
+     {
+     case ITM_AND:
+-      if (*(Lng32 *)op_data[1] == 0)
++      if (*(Lng32 *)op_data[1] == 0 || *(Lng32 *)op_data[1] == -1)  // null treated as false
+ 	{
+ 	  *(Lng32 *)op_data[0] = 0;
+ 	  setNextClause(branch_clause);","I don't believe this is correct. Consider the query, ""select a from t1x where not(b = 0 and c = 0)"". When B and C are both null, both equal predicates evaluate to null, and the AND evaluates to null. The NOT then also evaluates to null. The WHERE clause should treat the result of the NOT as false. But with this fix, the result of the AND will be false, making the NOT true. There needs to be three cases here for ITM_AND: If the first operand is false, then the AND is false. If the first operand is true, then the result is the second operand. If the first operand is null, then if the second operand is false, the result is false otherwise the result is null. Similar logic needs to be added to the ITM_OR case.",Why do you keep the null treated as false?
+4885,"@@ -72,7 +72,12 @@ final class IntArrayDocIdSet extends DocIdSet {
+
+     @Override
+     public int advance(int target) throws IOException {
+-      i = Arrays.binarySearch(docs, i + 1, length, target);
++      int bound = 1;
++      int offset = Math.max(0, i);
++      while(offset + bound < length && docs[offset + bound] < target) {
++        bound *= 2;
++      }
++      i = Arrays.binarySearch(docs, offset + bound / 2, Math.min(offset + bound, length), target);
+       if (i < 0) {
+         i = -1 - i;
+       }","`bound/2` is generally the previous bound that we tested, except when `bound` is equal to 1. It won't break in that case since callers are not supposed to call advance on a target that is lte the current doc ID, but this might still make room for bugs?","I think it should be Math.min(bound, lengt"
+4886,"@@ -65,8 +65,12 @@ function Admin(db, topology, promiseLibrary) {
+  * @method
+  * @param {object} command The command hash
+  * @param {object} [options] Optional settings.
+- * @param {(ReadPreference|string)} [options.readPreference] The preferred read preference (ReadPreference.PRIMARY, ReadPreference.PRIMARY_PREFERRED, ReadPreference.SECONDARY, ReadPreference.SECONDARY_PREFERRED, ReadPreference.NEAREST).
+- * @param {number} [options.maxTimeMS] Number of milliseconds to wait before aborting the query.
++ * @param {boolean} [options.raw=false] Return a raw nodejs Buffer instead of deserializing BSON
++ * @param {boolean} [options.fullResult=false] Return the full envelope instead of just the result document
++ * @param {boolean} [options.serializeFunctions=false] Specify if functions on an object should be serialized
++ * @param {boolean} [options.ignoreUndefined=false] Specify if the BSON serializer should ignore undefined fields
++ * @param {ReadPreference|string} [options.readPreference] Specify read preference if command supports it
++ * @param {ClientSession} [options.session] Session to use for the operation
+  * @param {Admin~resultCallback} [callback] The command result callback
+  * @return {Promise} returns Promise if no callback passed
+  */","Can we remove `raw`, `fullResult`, and `serializeFunctions`?","Minor: ""If true, the full result is serial"
+4887,"@@ -110,6 +110,8 @@ type (
+ 		TLS RootTLS `yaml:""tls""`
+ 		// Metrics is the metrics subsystem configuration
+ 		Metrics *Metrics `yaml:""metrics""`
++		// Settings for authentication and authorization
++		Security Security `yaml:""security""`
+ 	}
+
+ 	// RootTLS contains all TLS settings for the Temporal server","[Nit] I don't have a proposed suggestion, but security seems too generic of a name here.",Why is this in the rootTLS?
+4888,"@@ -0,0 +1,19 @@
++const config = require('../lib/config')
++const util = require('../lib/util')
++const path = require('path')
++const fs = require('fs-extra')
++
++const createDist = (options) => {
++  config.update(options)
++  config.buildConfig = 'Release'
++
++  let cmdOptions = config.defaultOptions
++  const args = util.buildArgsToString(config.buildArgs())
++
++  fs.removeSync(path.join(config.outputDir, 'dist'))
++  util.run('gn', ['gen', config.outputDir, '--args=""' + args + '""'], cmdOptions)
++  util.run('ninja', ['-C', config.outputDir, 'create_dist'], cmdOptions)
++}
++
++module.exports = createDist
++","do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people","It seems like this should be done in the package.json build step, not here."
+4889,"@@ -302,6 +302,10 @@ bool Client::Process() {
+ 		}
+
+ 		if (AutoFireEnabled()) {
++			if (this->GetTarget() == this) {
++				this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++				auto_fire = false;
++			}
+ 			EQ::ItemInstance *ranged = GetInv().GetItem(EQ::invslot::slotRange);
+ 			if (ranged)
+ 			{",Shouldn't need this-> here.,Wouldn't it be better to set auto_fire to true?
+4890,"@@ -1,4 +1,3 @@
+-# Copyright (c) OpenMMLab. All rights reserved.
+ import math
+
+ import torch",Why delete this?,please don't remove copyright notices (also in other files).
+4891,"@@ -10,6 +10,17 @@ export function extend(obj, props) {
+ 	return obj;
+ }
+
++/** Invoke or update a ref, depending on whether it is a function or object ref.
++ *  @param {object|function} [ref=null]
++ *  @param {any} [value]
++ */
++export function applyRef(ref, value) {
++	if (ref!=null) {
++		if (typeof ref=='function') ref(value);
++		else ref.current = value;
++	}
++}
++
+ /**
+  * Call a function asynchronously, as soon as possible. Makes
+  * use of HTML Promise to schedule the callback if available,","This line is here to be compatible with the current way `refs` work, right?",Why is the ref parameter optional?
+4892,"@@ -10,7 +10,11 @@
+         <strong><%= name %>
+       </td>
+       <td>
+-        <%= value %>
++        <% if value.class == BigDecimal %>
++          <%= number_to_currency(value) %>
++        <% else %>
++          <%= value %>
++        <% end %>
+       </td>
+     </tr>
+   <%- end %>","Hmm, I wonder if we can safely assume all decimals should be displayed as $$...ok for now I suppose.",Why do you need to check for BigDecimal here? Number_to_currency should handle it internally.
+4893,"@@ -443,4 +443,17 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
+       expect(ex.description).to match(/contains the example/)
+     end
+   end
++
++  describe ""setting the current example"" do
++    it ""sets RSpec.current_example to the example that is currently running"" do
++      group = RSpec::Core::ExampleGroup.describe(""an example group"")
++
++      current_examples = []
++      example1 = group.example(""example 1"") { current_examples << RSpec.current_example }
++      example2 = group.example(""example 2"") { current_examples << RSpec.current_example }
++
++      group.run
++      expect(current_examples).to eq([example1, example2])
++    end
++  end
+ end",Good spec :). Very clear and easy to see what it's doing.,What do you think about using `Array.wrap(current_examples)` so you don't have to do `current
+4894,"@@ -0,0 +1,12 @@
++class ExploreController < ApplicationController
++  def orgs
++    @newest_orgs = Organization.active.order('created_at DESC').limit(3)
++    @most_active_orgs = OrgThirtyDayActivity.most_active_orgs
++    @stats_by_sector = OrgStatsBySector.recent
++    @org_by_30_day_commits = OrgThirtyDayActivity.send(""filter_#{params[:filter]}_orgs"")
++  end
++
++  def orgs_by_thirty_day_commit_volume
++    @org_by_30_day_commits = OrgThirtyDayActivity.send(""filter_#{params[:filter]}_orgs"")
++  end
++end",Shouldn't we need to sanitize the `params[:filter]` from a defined expected values?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+4895,"@@ -10,6 +10,18 @@ from dagster.core.launcher.base import LaunchRunContext, RunLauncher
+ from dagster.grpc.types import ExecuteRunArgs
+ from dagster.serdes import ConfigurableClass, serialize_dagster_namedtuple
+ from dagster.utils.backcompat import experimental
++from dagster.utils.backoff import backoff
++
++
++# The ECS API is eventually consistent:
++# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html
++# describe_tasks might initially return nothing even if a task exists.
++class EcsEventualConsistencyTimeout(Exception):
++    pass
++
++
++# 9 retries polls for up to 51.1 seconds with exponential backoff.
++BACKOFF_RETRIES = 9
+
+
+ @dataclass","Should we bite the bullet and poll for the full 5 minutes that AWS recommends? If we do that, we'll probably want to leave some kind of breadcrumb in the event log to let users know why it's taking so long to launch.",Would it make sense to put this constant in `dvc/task/__init__.py` and then use it in the tas
+4896,"@@ -36,7 +36,7 @@ import java.util.concurrent.TimeUnit;
+ import java.util.function.Predicate;
+ import java.util.function.Supplier;
+
+-import com.google.common.base.Objects;
++import com.google.common.base.MoreObjects;
+ import org.apache.solr.common.SolrException;
+ import org.apache.solr.common.cloud.Aliases;
+ import org.apache.solr.common.params.CommonParams;",Guava changed `Objects` -> `MoreObjects`,This file doesn't have anything to do with the PR.
+4897,"@@ -20,8 +20,11 @@
+
+ package mocks
+
+-import mock ""github.com/stretchr/testify/mock""
+-import persistence ""github.com/temporalio/temporal/common/persistence""
++import (
++	mock ""github.com/stretchr/testify/mock""
++
++	persistence ""github.com/temporalio/temporal/common/persistence""
++)
+
+ // MetadataManager is an autogenerated mock type for the MetadataManager type
+ type MetadataManager struct {",All these hand generated mocks can be deleted. I think we already moved everything to gomocks.,Was this change necessary? I don't see any related
+4898,"@@ -1251,7 +1251,7 @@ Document.prototype.inspect = function (options) {
+  */
+
+ Document.prototype.equals = function (doc) {
+-  return this.get('_id') === doc.get('_id');
++  return this.get('_id').equals(doc.get('_id'));
+ };
+
+ /**",what about string/number etc _ids? this will fail.,I'm not sure this change is what we want. `equals`
+4899,"@@ -682,7 +682,7 @@ func TestRemoteMachineSetReconcile(t *testing.T) {
+ 								t.Errorf(""machineset %v has unexpected labels:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Labels, rMS.Labels)
+ 							}
+ 							if !reflect.DeepEqual(eMS.ObjectMeta.Annotations, rMS.ObjectMeta.Annotations) {
+-								t.Errorf(""machineset %v has unexpected annotations:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Labels, rMS.Labels)
++								t.Errorf(""machineset %v has unexpected annotations:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Annotations, rMS.Annotations)
+ 							}
+ 							if !reflect.DeepEqual(eMS.Spec.Template.Spec.Labels, rMS.Spec.Template.Spec.Labels) {
+ 								t.Errorf(""machineset %v machinespec has unexpected labels:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Spec.Template.Spec.Labels, rMS.Spec.Template.Spec.Labels)",Looks like the test had a bug prior to this.,please also check `eMS.ObjectMeta.Annotations` her
+4900,"@@ -36,7 +36,17 @@ const env = envFromArgs(process.argv);
+ const profilePath = profileFromArgs(process.argv);
+ const isDebugMode = !!process.argv && process.argv.indexOf('--debug') >= 0;
+
+-const wrapper = new ElectronAppWrapper(electronApp, env, profilePath, isDebugMode);
++if (env === 'dev' && process.platform === 'win32') {
++	electronApp.setAsDefaultProtocolClient('joplin', process.execPath, [
++		resolve(process.argv[1])
++	]);
++} else {
++	electronApp.setAsDefaultProtocolClient('joplin');
++}
++
++const initialUrl = process.argv.find((arg) => arg.startsWith('joplin://'));
++
++const wrapper = new ElectronAppWrapper(electronApp, env, profilePath, isDebugMode, initialUrl);
+
+ initBridge(wrapper);
+ ",Should start with joplin://x-callback-url/. Also maybe create a helper function to check if a url is valid?,Any reason you couldn't just do `process.argv[1]`?
+4901,"@@ -3,7 +3,7 @@ export default [
+     {
+         created_at: '2015-09-11T09:44:30.805Z',
+         created_by: 1,
+-        id: 1,
++        id: 7,
+         key: 'title',
+         type: 'blog',
+         updated_at: '2015-10-04T16:26:05.195Z',",PR works great. Just out of curiosity: why all the id changes?  ,does this need to be hard-coded?
+4902,"@@ -56,6 +56,14 @@ struct flb_service_config service_configs[] = {
+      FLB_CONF_TYPE_INT,
+      offsetof(struct flb_config, grace)},
+
++    {FLB_CONF_STR_BACKOFF_BASE,
++     FLB_CONF_TYPE_INT,
++     offsetof(struct flb_config, backoff_base)},
++
++    {FLB_CONF_STR_BACKOFF_CAP,
++     FLB_CONF_TYPE_INT,
++     offsetof(struct flb_config, backoff_cap)},
++
+     {FLB_CONF_STR_DAEMON,
+      FLB_CONF_TYPE_BOOL,
+      offsetof(struct flb_config, daemon)},","config map first value is wrong, it aims to define the ""value type"", that value will lead to an undefined behavior.",offsetof() is not necessary
+4903,"@@ -13,7 +13,7 @@
+ // limitations under the License.
+
+ // Package fileblob provides a blob implementation that uses the filesystem.
+-// Use OpenBucket to construct a blob.Bucket.
++// Use OpenBucket to construct a *blob.Bucket.
+ //
+ // Blob keys are escaped before being used as filenames, and filenames are
+ // unescaped when they are passed back as blob keys during List. The escape","This doesn't make sense. The thing being constructed is a blob.Bucket. ""Constructing"" the pointer is trivial.",Does this change belong in this PR?
+4904,"@@ -2,7 +2,9 @@
+ # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
+
+ import functools
++import optparse  # pylint: disable=deprecated-module
+
++from pylint.lint import PyLinter
+ from pylint.testutils.checker_test_case import CheckerTestCase
+
+ ",Outch. A configuration/parsing refactor is on the radar but this seems more pressing.,Could we move `optparse` to `typing`?
+4905,"@@ -18,7 +18,9 @@ export default Component.extend({
+     stats: null,
+     chartData: null,
+     chartOptions: null,
+-    startDateLabel: '',
++    startDateLabel: computed('membersStats.days', function () {
++        return moment(new Date()).add(-this.membersStats.days + 1, 'days').format(DATE_FORMAT);
++    }),
+
+     selectedRange: computed('membersStats.days', function () {
+         const availableRanges = this.availableRanges;","Unfortunately this won't work when the ""All time"" range is chosen because `memberStats.days` will be `""all-time""` and not a number. What you could do instead is to use `memberStats.stats` as the dependent key and use `Object.keys(memberStats.stats.total_on_date)[0]` to grab the first date in the range and build the label from there.",How about the simpler syntax `.format
+4906,"@@ -1,10 +1,11 @@
+ require ""rails_helper""
+
+-feature ""subscriber views video trail"" do
++feature ""user views video trail"" do
+   scenario ""and marks a video as complete"" do
+     trail = create_video_trail
+
+-    sign_in_as_user_with_subscription
++    sign_in
++    click_on I18n.t(""pages.landing.hero_call_to_action"")
+     click_on trail.name
+
+     within trail_steps_list do",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Style/StringLiterals: Prefer single-q
+4907,"@@ -206,7 +206,6 @@ describe('Configure Options', function() {
+       iframe.src = '/test/mock/frames/context.html';
+       iframe.onload = function() {
+         axe.configure(config);
+-        iframe.contentWindow.axe.configure(config);
+
+         axe.run(
+           '#target',","We need this left in as `axe.configure` is for the top-level page `axe` and we still need to configure the axe script inside the iframe as well (so both have to be configured),",Why is this removed?
+4908,"@@ -26,6 +26,11 @@ namespace AutoRest.Swagger.Validation
+         /// </summary>
+         public override ValidationCategory ValidationCategory => ValidationCategory.RPCViolation;
+
++        /// <summary>
++        /// What kind of change implementing this rule can cause.
++        /// </summary>
++        public override ValidationChangesImpact ValidationChangesImpact => ValidationChangesImpact.ServiceImpactingChanges;
++
+         public override IEnumerable<ValidationMessage> GetValidationMessages(Dictionary<string, Dictionary<string, Operation>> entity, RuleContext context)
+         {
+             // get all operation objects that are either of get or post type","is this rule serviceimpacting? I'm thinking it's mostly around the modeling of pageable in the swagger, thoughts?",Should this property be renamed to `ValidationImpact` for consistency?
+4909,"@@ -141,7 +141,7 @@ func (ts *TriggerStatus) MarkDependencyNotConfigured() {
+ 		""DependencyNotConfigured"", ""Dependency has not yet been reconciled."")
+ }
+
+-func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.KResource) {
++func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.Source) {
+ 	kc := ks.Status.GetCondition(apis.ConditionReady)
+ 	if kc == nil {
+ 		ts.MarkDependencyNotConfigured()","same here, replace `ks` and `kc` to something more related to Source.",@kargakis this function is only used in `v1beta1` and `v1beta1` versio
+4910,"@@ -0,0 +1,19 @@
++using System;
++using System.Collections.Generic;
++using System.Globalization;
++
++namespace MvvmCross.Platform.Converters
++{
++    public class MvxDictionaryValueConverter<TKey, TValue> : MvxValueConverter<TKey, TValue>
++    {
++        protected override TValue Convert(TKey value, Type targetType, object parameter, CultureInfo culture)
++        {
++            if (parameter is Dictionary<TKey, TValue> dict)
++            {
++                TValue x = dict[value];
++                return x;
++            }
++            throw new ArgumentException($""Could not cast {parameter.GetType().Name} to {typeof(Dictionary<TKey, TValue>).Name}"");
++        }
++    }
++}","We should probably ask here if `dict` contains a key with the appropiate value, and leave a trace in case it doesn't, to make it easier to debug for developers.",Seems like this should be marked as RequiresUnreferencedCode cc: @eerh
+4911,"@@ -147,6 +147,11 @@ module Beaker
+                             }
+           } }
+           let(:subcommand_file) {@subcommand_file || {:level => 'fifth'}}
++          let(:homedir_file) {@homedir_file || {:level => 'sixth',
++                                                :ssh => {
++                                                    :auth_methods => 'auth_home_123'
++                                                }
++          }}
+           let(:presets) { {:level => 'lowest',
+                             :ssh => {
+                               :config => 'config123',",this should only be indented 2 spaces,Use the new Ruby 1.9 hash syntax.
+4912,"@@ -84,7 +84,10 @@ func TestLoadEnvConfig_Creds(t *testing.T) {
+ 				os.Setenv(k, v)
+ 			}
+
+-			cfg := loadEnvConfig()
++			cfg, err := loadEnvConfig()
++			if err != nil {
++				t.Errorf(""failed to load env config, %v"", err)
++			}
+ 			if !reflect.DeepEqual(c.Val, cfg.Creds) {
+ 				t.Errorf(""expect credentials to match.\n%s"",
+ 					awstesting.SprintExpectActual(c.Val, cfg.Creds))","Nit, these Err not nils should be `t.Fatalf` not error. We want to the test to stop if this error occurs.",This looks like it should be `assert.NoError()`
+4913,"@@ -262,6 +262,10 @@ public class DatasetPage implements java.io.Serializable {
+
+     private Boolean hasRsyncScript = false;
+
++    private Boolean hasTabular = false;
++
++    private Boolean downloadOriginalTracker = false;
++
+     List<ExternalTool> configureTools = new ArrayList<>();
+     List<ExternalTool> exploreTools = new ArrayList<>();
+     Map<Long, List<ExternalTool>> configureToolsByFileId = new HashMap<>();",shouldn't every `Boolean` in this pr be `boolean`?,Why do we need a Boolean object here? Can't we
+4914,"@@ -619,6 +619,14 @@ class WebDriver(object):
+         else:
+             return self.execute(Command.GET_WINDOW_HANDLES)['value']
+
++    def minimize_window(self):
++        """"""
++        Miniimizes the current window that webdriver is using
++        """"""
++        if self.w3c:
++            command = Command.W3C_MINIMIZE_WINDOW
++            self.execute(command, {""windowHandle"": ""current""})
++
+     def maximize_window(self):
+         """"""
+         Maximizes the current window that webdriver is using",This `if` is not necessary,Let's rename this to `minimize_current_window`.
+4915,"@@ -45,5 +45,7 @@ namespace Datadog.Trace.ClrProfiler
+         public const string GenericParameterTask = ""System.Threading.Tasks.Task`1<T>"";
+         public const string ObjectTask = ""System.Threading.Tasks.Task`1<System.Object>"";
+         public const string Int32Task = ""System.Threading.Tasks.Task`1<System.Int32>"";
++
++        public const string HttpConfigurationAction = ""System.Action`1<System.Web.Http.HttpConfiguration>"";
+     }
+ }",Are you using this anywhere? (I couldn't find it.),Should this be `1<System.Web.Http.HttpConfigura
+4916,"@@ -250,7 +250,14 @@ func (s *Step) populate(ctx context.Context) dErr {
+ 	return err
+ }
+
++func (s *Step) recordStepTime(startTime time.Time) {
++	endTime := time.Now()
++	s.w.recordStepTime(s.name, startTime, endTime)
++}
++
+ func (s *Step) run(ctx context.Context) dErr {
++	startTime := time.Now()
++	defer s.recordStepTime(startTime)
+ 	impl, err := s.stepImpl()
+ 	if err != nil {
+ 		return s.wrapRunError(err)",Can be inlined,"i think you want to call `startTime, endTime := s.recordStepTime(startTime, s.endTime)`?"
+4917,"@@ -3,6 +3,6 @@ require 'spec_helper'
+ describe Api::V1::CompletionsController, '#show' do
+   it 'returns a 401 when users are not authenticated' do
+     get :index
+-    response.code.should eq '401'
++    expect(response.code).to eq '401'
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Metrics/LineLength: Line is too long. [90/80]
+4918,"@@ -1,3 +1,4 @@
++import json
+ import warnings
+
+ import colander",Please use `kinto.core.utils.json`,"No need to change this file, it's only changes in this PR."
+4919,"@@ -204,6 +204,16 @@ func (h *Handler) Provision(ctx caddy.Context) error {
+
+ 	// set up upstreams
+ 	for _, upstream := range h.Upstreams {
++		addr, err := caddy.ParseNetworkAddress(upstream.Dial)
++		if err != nil {
++			return err
++		}
++		if addr.PortRangeSize() != 1 {
++			h.logger.Error(""multiple addresses (upstream must map to only one address)"",
++				zap.String(""address"", upstream.Dial),
++			)
++			return fmt.Errorf(""multiple addresses (upstream must map to only one address): %v"", addr)
++		}
+ 		// create or get the host representation for this upstream
+ 		var host Host = new(upstreamHost)
+ 		existingHost, loaded := hosts.LoadOrStore(upstream.String(), host)","Since we're returning the error with the same content, we don't need to log it here; it will get bubbled up and emitted that way.",shouldn't this be `!= 1`?
+4920,"@@ -0,0 +1,11 @@
++""""""Tests for the use of typing.final whenever the py-version is set < 3.8""""""
++# pylint: disable=missing-class-docstring, too-few-public-methods, missing-function-docstring, no-name-in-module
++
++from typing import final
++
++
++@final # [using-final-in-unsupported-version]
++class MyClass:
++    @final # [using-final-in-unsupported-version]
++    def my_method(self):
++        pass",What happens if someone import `typing` and thus uses `@typing.final` instead?,Does there need to be a line break here?
+4921,"@@ -76,7 +76,7 @@ def get_test_dependencies():
+     # Test dependencies exposed as extras, based on:
+     # https://stackoverflow.com/questions/29870629
+     return [
+-        ""pandas"",
++        ""pandas==0.20.0"",
+         ""pytest>=3.1"",
+         ""pytest-cov"",
+         ""pytest-benchmark>=3.1"",",Better remove this dependency altogether,Need to bump this to 0.19.0
+4922,"@@ -944,4 +944,7 @@ void h2o_cleanup_thread(void)
+     h2o_mem_clear_recycle(&h2o_mem_pool_allocator);
+     h2o_mem_clear_recycle(&h2o_http2_wbuf_buffer_prototype.allocator);
+     h2o_mem_clear_recycle(&h2o_socket_buffer_prototype.allocator);
++
++    extern __thread h2o_buffer_prototype_t h2o__http2client_wbuf_buffer_prototype;
++    h2o_mem_clear_recycle(&h2o__http2client_wbuf_buffer_prototype.allocator);
+ }",Could you please move the declaration to httpclient.h? I think we have a consistent pattern in declaring global variables in header files.,(style) externs should be avoided in .c
+4923,"@@ -61,11 +61,12 @@ public interface DataFile extends ContentFile<DataFile> {
+       ""Splittable offsets"");
+   Types.NestedField EQUALITY_IDS = optional(135, ""equality_ids"", ListType.ofRequired(136, IntegerType.get()),
+       ""Equality comparison field IDs"");
++  Types.NestedField SORT_ORDER_ID = optional(140, ""sort_order_id"", IntegerType.get(), ""Sort order ID"");
+
+   int PARTITION_ID = 102;
+   String PARTITION_NAME = ""partition"";
+   String PARTITION_DOC = ""Partition data tuple, schema based on the partition spec"";
+-  // NEXT ID TO ASSIGN: 140
++  // NEXT ID TO ASSIGN: 141
+
+   static StructType getType(StructType partitionType) {
+     // IDs start at 100 to leave room for changes to ManifestEntry",We will also need to add this to the spec.,"shouldn't it be named like ""sort_order_i"
+4924,"@@ -68,15 +68,8 @@ func makeRoundCowState(b roundCowParent, hdr bookkeeping.BlockHeader, prevTimest
+ 		lookupParent: b,
+ 		commitParent: nil,
+ 		proto:        config.Consensus[hdr.CurrentProtocol],
+-		mods: ledgercore.StateDelta{
+-			Accts:         make(map[basics.Address]basics.AccountData),
+-			Txids:         make(map[transactions.Txid]basics.Round),
+-			Txleases:      make(map[ledgercore.Txlease]basics.Round),
+-			Creatables:    make(map[basics.CreatableIndex]ledgercore.ModifiedCreatable),
+-			Hdr:           &hdr,
+-			PrevTimestamp: prevTimestamp,
+-		},
+-		sdeltas: make(map[basics.Address]map[storagePtr]*storageDelta),
++		mods:         ledgercore.MakeStateDelta(&hdr, prevTimestamp),
++		sdeltas:      make(map[basics.Address]map[storagePtr]*storageDelta),
+ 	}
+ }
+ ","In startEvaluator, we have the paysetHint; we should use it to preinitialize the state delta allocation. The number of transactions and the deltas are typically growing in a linear fashion, so preallocating twice as much in the array initializer would be a good idea.",nit: `make(map[basics.Address]map[storagePtr]*storageDelta)` can be replaced by `make(map[storagePtr]*storageDelta)`
+4925,"@@ -44,6 +44,10 @@ import java.util.List;
+  * </code>
+  */
+ public abstract class By {
++  static {
++    WebDriverException.scheduleIpHostResolving();
++  }
++
+   /**
+    * @param id The value of the ""id"" attribute to search for
+    * @return a By which locates elements by the value of the ""id"" attribute.","we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class.",Remove this empty line.
+4926,"@@ -54,6 +54,10 @@ namespace System.Text.Json.Serialization.Tests
+             await JsonSerializer.SerializeAsync(_memoryStream, _value);
+         }
+
++        [BenchmarkCategory(Categories.CoreFX, Categories.JSON)]
++        [Benchmark]
++        public string SerializeObjectProperty() => JsonSerializer.Serialize(new { Prop = (object)_value });
++
+         [GlobalCleanup]
+         public void Cleanup() => _memoryStream.Dispose();
+     }","Would it be possible to move the creation of the `new { Prop = (object)_value }` out of the benchmark? In the current version, the benchmark includes the cost of creating and serializing the object, while if possible it should be the cost of serialization only.",Should this benchmark be named `SerializeObjectProperty` for consistency?
+4927,"@@ -23,4 +23,6 @@ return [
+     Knp\Bundle\MenuBundle\KnpMenuBundle::class => ['all' => true],
+     Translation\Bundle\TranslationBundle::class => ['all' => true],
+     Symfony\WebpackEncoreBundle\WebpackEncoreBundle::class => ['all' => true],
++    Translation\PlatformAdapter\Loco\Bridge\Symfony\TranslationAdapterLocoBundle::class => ['all' => true],
++    Http\HttplugBundle\HttplugBundle::class => ['all' => true],
+ ];",only dev and local,Missing use statement for `Http\HttplugBundle`
+4928,"@@ -30,7 +30,7 @@ class DbJobsFailedJobsUpdate extends Migration
+     public function down()
+     {
+         Schema::table($this->getTableName(), function (Blueprint $table) {
+-            $table->tinyInteger('reserved')->unsigned();
++            $table->tinyInteger('reserved')->unsigned()->nullable();
+             $table->dropIndex('jobs_queue_reserved_at_index');
+         });
+ ","This should not be nullable, instead it should be `->default(0);`",Shouldn't it be `null` only if `reserved` is not null?
+4929,"@@ -65,8 +65,8 @@ public class IcebergGenerics {
+       return this;
+     }
+
+-    public ScanBuilder select(String... columns) {
+-      this.columns = ImmutableList.copyOf(columns);
++    public ScanBuilder select(String... selectColumns) {
++      this.columns = ImmutableList.copyOf(selectColumns);
+       return this;
+     }
+ ",What about `selectedColumns`? I believe it is frequently used throughout the project.,nit: `selectColumns` can be final.
+4930,"@@ -43,6 +43,7 @@ import org.apache.solr.uninverting.UninvertingReader.Type;
+ public class TextField extends FieldType {
+   protected boolean autoGeneratePhraseQueries;
+   protected boolean enableGraphQueries;
++  protected boolean synonymBoostByPayload;
+   protected SolrQueryParserBase.SynonymQueryStyle synonymQueryStyle;
+
+   /**",I thought we switched the approach from a payload to boost attribute? Besides; it's not clear we need this toggle at all since the user could arrange for this behavior simply by having the new DelimitedBoost filter thing in the chain.,Why is `synonymBoostByPayload` protected? I don't see
+4931,"@@ -233,15 +233,8 @@ module Unix::Exec
+   def environment_string env
+     return '' if env.empty?
+     env_array = self.environment_variable_string_pair_array( env )
+-
+     environment_string = env_array.join(' ')
+-    command = 'env'
+-    punctuation = ''
+-    if self[:platform] =~ /cisco-5/
+-      command = 'export'
+-      punctuation = ';'
+-    end
+-    ""#{command} #{environment_string}#{punctuation}""
++    ""env #{environment_string}""
+   end
+
+   def environment_variable_string_pair_array env","the previous code used 'export' when platform is cisco-5, presumably because 'env' cannot be used to load variables? I have no idea if that's the case but this env vs export logic is not here","This method is no longer used, it should be removed fr"
+4932,"@@ -104,11 +104,15 @@ type CloudInit struct {
+ 	// +optional
+ 	EnableSecureSecretsManager bool `json:""enableSecureSecretsManager,omitempty""`
+
+-	// SecretARN is the Amazon Resource Name of the secret. This is stored
++	// SecretCount is the number of secrets used to form the complete secret
++	// +optional
++	SecretCount int32 `json:""secretCount,omitempty""`
++
++	// SecretPrefix is the prefix for the secret name. This is stored
+ 	// temporarily, and deleted when the machine registers as a node against
+ 	// the workload cluster.
+ 	// +optional
+-	SecretARN string `json:""secretARN,omitempty""`
++	SecretPrefix string `json:""secretPrefix,omitempty""`
+ }
+
+ // AWSMachineStatus defines the observed state of AWSMachine",I'm wondering if we need to add some type of validation here that the SecretCount != 0... Or do we think it would be valid to have a SecretCount of 0?,Doesn't the old `SecretARN` have the same meaning as the new `SecretPrefix`? Why would we want to change that?
+4933,"@@ -3752,7 +3752,7 @@ describe('Cursor', function () {
+           db.s.topology,
+           db.s.namespace,
+           {},
+-          { limit: 0, skip: 0, slaveOk: false, readPreference: 42 }
++          { limit: 0, skip: 0, secondaryOk: false, readPreference: 42 }
+         );
+
+         cursor.hasNext(err => {","This test is being skipped. I unskipped it, and it failed in the same way for both `slaveOk: false` and `secondaryOk: false`. I'm not sure how else to test this broken test.",can you please also fix the typo in the commit message
+4934,"@@ -33,6 +33,8 @@ import (
+ // ResponseHeaders.
+ type OutboundCall struct {
+ 	// request attributes to fill if non-nil
++	to              *Identifier
++	from            *Identifier
+ 	headers         []keyValuePair
+ 	shardKey        *string
+ 	routingKey      *string",I don't believe that we need a pointer to an interface for the `to` side of this since we're just assigning a value to the to field.,why is this a pointer?
+4935,"@@ -74,13 +74,18 @@ def later(ms: int, command, win_id):
+
+ @cmdutils.register(maxsplit=1, no_cmd_split=True, no_replace_variables=True)
+ @cmdutils.argument('win_id', win_id=True)
+-def repeat(times: int, command, win_id):
++@cmdutils.argument('count', count=True)
++def repeat(times: int, command, win_id, count=None):
+     """"""Repeat a given command.
+
+     Args:
+         times: How many times to repeat.
+         command: The command to run, with optional args.
+     """"""
++
++    if count is not None:
++        times *= count
++
+     if times < 0:
+         raise cmdexc.CommandError(""A negative count doesn't make sense."")
+     commandrunner = runners.CommandRunner(win_id)",No blank line after the docstring.,Shouldn't this be `if count is not None:` instead?
+4936,"@@ -17,8 +17,11 @@ package blobvar
+ import (
+ 	""context""
+ 	""errors""
++	""github.com/google/go-cmp/cmp""
++	""io/ioutil""
+ 	""os""
+ 	""path""
++	""path/filepath""
+ 	""testing""
+
+ 	""gocloud.dev/blob""",nit: move this to the group below.,Please remove this extra line
+4937,"@@ -3045,8 +3045,11 @@ short Sort::generateTdb(Generator * generator,
+
+   CostScalar bufferSize = getDefault(GEN_SORT_MAX_BUFFER_SIZE);
+
+-  ULng32 bufferSize_as_ulong =
+-    (ULng32)(MINOF(CostScalar(UINT_MAX), bufferSize)).getValue();
++  UInt32 bufferSize_as_ulong =
++    (UInt32)(MINOF(CostScalar(UINT_MAX), bufferSize)).getValue();
++
++  // allocate buffer to hold atlease one row
++  bufferSize_as_ulong = MAXOF(bufferSize_as_ulong, sortRecLen);
+
+   GenAssert(sortRecLen <= bufferSize_as_ulong,
+       ""Record Len greater than GEN_SORT_MAX_BUFFER_SIZE"");","This is fine, but maybe we should change the variable name to ""bufferSize_as_uint""? Or ""...uint32""?",Why not just use `GEN_SORT_MA
+4938,"@@ -57,9 +57,10 @@ module Blacklight::SolrResponse::Spelling
+                 #   origFreq =>
+                 #   suggestion =>  [{ frequency =>, word => }] # for extended results
+                 #   suggestion => ['word'] # for non-extended results
+-                if suggestions.index(""correctlySpelled"")
++                origFreq = term_info['origFreq']
++                if term_info['suggestion'].first.is_a?(Hash) or suggestions.index(""correctlySpelled"")
+                   word_suggestions << term_info['suggestion'].map do |suggestion|
+-                    suggestion['word'] if suggestion['freq'] > term_info['origFreq']
++                    suggestion['word'] if suggestion['freq'] > origFreq
+                   end
+                 else
+                   # only extended suggestions have frequency so we just return all suggestions",Use snake_case for variable names.,Style/SafeNavigation: Use saf
+4939,"@@ -1095,7 +1095,7 @@ namespace pwiz.SkylineTestA
+             return count;
+         }
+
+-        [TestMethod]
++        //[TestMethod]
+         public void ConsoleBadRawFileImportTest()
+         {
+             // Run this test only if we can read Thermo's raw files","Obviously, don't merge this to master.",Is this method still being us
+4940,"@@ -160,6 +160,18 @@ module RSpec::Core
+       end
+     end
+
++    describe ""#exit_early"" do
++      it ""returns the passed exit code"" do
++        expect(reporter.exit_early(42)).to eq(42)
++      end
++
++      it ""reports zero examples"" do
++        allow(reporter).to receive(:report)
++        reporter.exit_early(42)
++        expect(reporter).to have_received(:report).with(0)
++      end
++    end
++
+     describe ""#report"" do
+       it ""supports one arg (count)"" do
+         reporter.report(1) {}","Nearly there! This should assert on the output, take the result of ""start"" and ""finish"" as an example :)","would it be easier to just do `expect(reporter).to have_received(:report)`, and remove the `allow`?"
+4941,"@@ -63,11 +63,11 @@ func NewDriverSub() *driverSub {
+ 	return ds
+ }
+
+-func (s *driverSub) ReceiveBatch(ctx context.Context) ([]*driver.Message, error) {
++func (s *driverSub) ReceiveBatch(ctx context.Context, maxMessages int) ([]*driver.Message, error) {
+ 	for {
+ 		select {
+ 		case <-s.sem:
+-			ms := s.grabQueue()
++			ms := s.grabQueue(maxMessages)
+ 			if len(ms) != 0 {
+ 				return ms, nil
+ 			}",This loop is going to burn CPU if len(s.q) == 0. Maybe a small sleep?,"Since this method is only used in the test, let's move it to the upper level (subscribable) module."
+4942,"@@ -30,7 +30,10 @@ import com.pingcap.tikv.exception.TiClientInternalException;
+ import com.pingcap.tikv.key.Key;
+ import com.pingcap.tikv.util.ConcreteBackOffer;
+ import com.pingcap.tikv.util.Pair;
+-import java.util.*;
++import java.util.ArrayList;
++import java.util.HashMap;
++import java.util.List;
++import java.util.Map;
+ import org.apache.log4j.Logger;
+ import org.tikv.kvproto.Metapb.Peer;
+ import org.tikv.kvproto.Metapb.Store;",can you give a reason why session should be contained in RegionManager?,why change it?
+4943,"@@ -37,6 +37,16 @@ func TestAuthenticate_WhenSignatureIsCorrect(t *testing.T) {
+ 	assert.Exactly(t, originalSignerID, signerID, ""Original signer should be extracted"")
+ }
+
++func TestAuthenticate_WhenBase64MessageSignatureIsCorrect(t *testing.T) {
++	message := []byte(""MystVpnSessionId:Boop!"")
++	signature := SignatureBase64(""V6ifmvLuAT+hbtLBX/0xm3C0afywxTIdw1HqLmA4onpwmibHbxVhl50Gr3aRUZMqw1WxkfSIVdhpbCluHGBKsgE="")
++
++	extractor := &extractor{}
++	signerID, err := extractor.Extract(message, signature)
++	assert.NoError(t, err)
++	assert.Exactly(t, originalSignerID, signerID, ""Original signer should be extracted"")
++}
++
+ func TestAuthenticate_WhenSignatureIsEmpty(t *testing.T) {
+ 	message := []byte(""Boop!"")
+ 	signature := SignatureHex("""")","You are comparing two signerIDs here, error message should be ""Signers should match""",There's no need to create a new variable here; just use `&extractor` below.
+4944,"@@ -57,6 +57,15 @@ type IAMRoleCredentials struct {
+ type TaskIAMRoleCredentials struct {
+ 	ARN                string
+ 	IAMRoleCredentials IAMRoleCredentials
++	lock               sync.RWMutex
++}
++
++// GetIAMRoleCredentials returns the IAM role credentials in the task IAM role struct
++func (role *TaskIAMRoleCredentials) GetIAMRoleCredentials() IAMRoleCredentials {
++	role.lock.RLock()
++	defer role.lock.RUnlock()
++
++	return role.IAMRoleCredentials
+ }
+
+ // GenerateCredentialsEndpointRelativeURI generates the relative URI for the",Who's acquiring this lock for writes?,Why do we need this lock?
+4945,"@@ -248,10 +248,10 @@ PublicKey.fromX = function(odd, x) {
+  * @param {String} [compressed] - If the public key is compressed
+  * @returns {null|Error} An error if exists
+  */
+-PublicKey.getValidationError = function(data, compressed) {
++PublicKey.getValidationError = function(data) {
+   var error;
+   try {
+-    new PublicKey(data, compressed);
++    new PublicKey(data);
+   } catch (e) {
+     error = e;
+   }","This throws a linter error, don't use object creation for side effects. I feel like it's kinda messed up that the errors are thrown by the constructor and not that the constructor will throw them",Is this method still used
+4946,"@@ -43,6 +43,18 @@ describe Trail do
+     end
+   end
+
++  describe "".by_topic"" do
++    it ""returns trails sorted by their topic's name"" do
++      create(:trail, topic: create(:topic, name: ""A""))
++      create(:trail, topic: create(:topic, name: ""C""))
++      create(:trail, topic: create(:topic, name: ""B""))
++
++      result = Trail.by_topic.map(&:topic_name)
++
++      expect(result).to eq %w(A B C)
++    end
++  end
++
+   describe "".completed_for"" do
+     it ""shows completed trails for a user"" do
+       _incomplete = create(:trail)",Should there be a `trail.topic_name` method so we don't annoy Demeter?,"I think this should be ""r"
+4947,"@@ -281,7 +281,7 @@ def _file_to_data_frame(ext, path, target, handler_args):
+
+     return dataframe
+
+-def build_package(username, package, yaml_path, checks_path=None, dry_run=False, env='default'):
++def build_package(team, username, package, yaml_path, checks_path=None, dry_run=False, env='default'):
+     """"""
+     Builds a package from a given Yaml file and installs it locally.
+ ","instead of passing ""None"" it would be more readable to create a constant e.g. TEAM_PUBLIC = None and then call build_package(TEAM_PUBLIC, ...)",Line too long (will be fi
+4948,"@@ -9,6 +9,8 @@ gc_disable();
+ // show all errors
+ error_reporting(-1);
+
++require_once __DIR__ . '/Psalm/Internal/exception_handler.php';
++
+ $valid_short_options = [
+     'h',
+     'v',",Would it make sense to include this file via composer files-autoloading instead?,Can you move this to the `error_reporting.php` file please?
+4949,"@@ -348,10 +348,12 @@ public class ExpectedConditions {
+                                                                     final String text) {
+
+     return new ExpectedCondition<Boolean>() {
++      private String elementText = null;
++
+       @Override
+       public Boolean apply(WebDriver driver) {
+         try {
+-          String elementText = element.getText();
++          elementText = element.getText();
+           return elementText.contains(text);
+         } catch (StaleElementReferenceException e) {
+           return null;","Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal.","This field is not initialized in the constructor, so I thin"
+4950,"@@ -1,9 +1,10 @@
+ package sql_test
+
+ import (
+-	""github.com/influxdata/flux/plan""
+ 	""testing""
+
++	""github.com/influxdata/flux/plan""
++
+ 	""github.com/DATA-DOG/go-sqlmock""
+ 	""github.com/google/go-cmp/cmp""
+ 	""github.com/google/go-cmp/cmp/cmpopts""",Extra newline here. Thanks for moving it under the `testing` import though. This just needs to be grouped with the other imports below it.,Did you mean to add this import?
+4951,"@@ -71,7 +71,11 @@ public class MimeBodyPart extends BodyPart {
+                 contentType += String.format("";\n name=\""%s\"""", name);
+             }
+             setHeader(MimeHeader.HEADER_CONTENT_TYPE, contentType);
+-            setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""quoted-printable"");
++            if (""8bit"".equals(body.getEncoding())) {
++                setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""8bit"");
++            } else {
++                setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""quoted-printable"");
++            }
+         }
+     }
+ ",Should we ignore case when doing the comparison?,I don't think this is correct. We should only set the conte
+4952,"@@ -94,6 +94,7 @@ struct wlr_backend *wlr_backend_autocreate(struct wl_display *display) {
+ 		}
+ 	}
+
++#ifdef WLR_HAS_X11_BACKEND
+ 	const char *x11_display = getenv(""DISPLAY"");
+ 	if (x11_display) {
+ 		struct wlr_backend *x11_backend =",The same `ifdef` should apply to `#include <wlr/backend/x11.h>` line 14,This change is unrelated and should be reverted.
+4953,"@@ -183,7 +183,14 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+             catch (Exception ex)
+             {
+                 // profiled app will continue working as expected without this method
+-                Log.ErrorException($""Error resolving {DiagnosticSourceTypeName}.{nameof(BeforeAction)}(...)"", ex);
++                Log.ErrorRetrievingMethod(
++                    exception: ex,
++                    moduleVersionPointer: moduleVersionPtr,
++                    mdToken: mdToken,
++                    opCode: opCode,
++                    instrumentedType: DiagnosticSourceTypeName,
++                    methodName: nameof(BeforeAction),
++                    instanceType: diagnosticSource?.GetType().AssemblyQualifiedName);
+             }
+
+             try","We're instrumenting a static method, so there's no instance in this case. `diagnosticSource` is the first argument.",I am not sure if this should be logged at all. I
+4954,"@@ -194,6 +194,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+     private Action action;
+
+     private boolean requestReadReceipt = false;
++    private boolean isHighPriority = false;
+
+     private TextView chooseIdentityButton;
+     private EditText subjectView;","I feel like this belongs in `RecipientPresenter` (which should really be `MetadataPresenter`), but I suppose having it next to requestReadReceipt makes sense as well. feel free to leave as is.",Nit: isHighPriority -> isHighPriority
+4955,"@@ -1,6 +1,6 @@
+ Summary:        Open Programmable Acceleration Engine (OPAE) SDK
+ Name:           opae
+-Version:        1.4.0
++Version:        1.4.1
+ Release:        1%{?dist}
+ License:        BSD
+ ExclusiveArch:  x86_64",Let's go back to 1.4.0 until the release is being prepared.,Could you revert this change so it doesn't clutt
+4956,"@@ -7337,6 +7337,7 @@ pre_system_call(dcontext_t *dcontext)
+              size_t sigsetsize)
+          */
+         /* we also need access to the params in post_system_call */
++        uint errno_val = 0;
+         dcontext->sys_param0 = sys_param(dcontext, 0);
+         dcontext->sys_param1 = sys_param(dcontext, 1);
+         dcontext->sys_param2 = sys_param(dcontext, 2);","I would avoid the term ""errno"" as it implies the glibc variable. Use error_code or status or something.",(style) line over 80 characters
+4957,"@@ -69,7 +69,7 @@ func (i *inbound) Channel() *tchannel.Channel {
+ 	return i.ch
+ }
+
+-func (i *inbound) Start(h transport.Handler) error {
++func (i *inbound) Start(h transport.Handler, d transport.Dependencies) error {
+ 	sc := i.ch.GetSubChannel(i.ch.ServiceName())
+ 	existing := sc.GetHandlers()
+ 	sc.SetHandler(handler{existing, h})",@abhinav @kriskowal what do you think about putting the handler on `d`?,do we need to pass the dependen
+4958,"@@ -91,7 +91,7 @@ type BackupOptions struct {
+ 	ExcludeLargerThan       string
+ 	Stdin                   bool
+ 	StdinFilename           string
+-	Tags                    []string
++	Tags                    restic.TagList
+ 	Host                    string
+ 	FilesFrom               []string
+ 	TimeStamp               string",Why `restic.TagLists` and no `restic.TagList` ? Because I'm using `restic.TagList` here and using `restic.TagLists` is a lot of changes,If you're not using the `map[st
+4959,"@@ -50,6 +50,8 @@ func TestWait(t *testing.T) {
+ 				cancel()
+ 				return ctx
+ 			}(),
++			// Ensure the timer and context do not end simultaneously.
++			delay:    1 * time.Hour,
+ 			expected: context.Canceled,
+ 		},
+ 	}","An hour seems a significant amount of time to wait for within a test, does it need to be that long?",Shouldn't this be 1 * time.Hour
+4960,"@@ -204,7 +204,7 @@ func (d *RPCFactory) CreateFrontendGRPCConnection(hostName string) *grpc.ClientC
+ 		}
+ 	}
+
+-	return d.dial(hostName, tlsClientConfig)
++	return d.dial(hostName, tlsClientConfig, false)
+ }
+
+ // CreateInternodeGRPCConnection creates connection for gRPC calls","Nit: (newish to golang, don't hesitate to tell me I'm wrong here, but ...) I'd have written this code, just for readability: keepAlive := false return d.dial(hostName, tlsClientConfig, keepAlive) ... or even return d.dial(hostName, tlsClientConfig, false) // keepAlive=false Personally I think Golang should have included named args; I think it's one of the things python got right.","I think the default is false, so no need to set it."
+4961,"@@ -13,6 +13,7 @@ namespace Datadog.Trace.Configuration
+         AspNetMvc,
+         AspNetWebApi2,
+         GraphQL,
++        Msmq,
+         MongoDb,
+         XUnit,
+         NUnit,","I don't think it would cause any version conflict, but I'd feel safer if you declared it last, so that the numerical id of the existing integrations don't change",Is this supposed to be `Msmq`?
+4962,"@@ -135,6 +135,9 @@ func (c *certificateRequestManager) updateCertificateStatus(ctx context.Context,
+ 		ready = cmmeta.ConditionTrue
+ 		reason = ""Ready""
+ 		message = ""Certificate is up to date and has not expired""
++	case apiutil.CertificateRequestHasInvalidRequest(req):
++		reason = ""InvalidRequest""
++		message = fmt.Sprintf(""The CertificateRequest %q is an invalid request"", req.Name)
+ 	case req != nil:
+ 		reason = ""InProgress""
+ 		message = fmt.Sprintf(""Waiting for CertificateRequest %q to complete"", req.Name)","Can we provide some more useful actionable info here? `fmt.Sprintf(""The certificate request could not be completed due to invalid request options: %s"", req.Status.Conditions[InvalidRequestCondition].Message)`",Shouldn't this be `req.Name`?
+4963,"@@ -155,6 +155,7 @@ var (
+ 		API: API{
+ 			UseRDS:    false,
+ 			Port:      14014,
++			Web3Port:  15014, // TODO: port 15014 is used for testing
+ 			TpsWindow: 10,
+ 			GasStation: GasStation{
+ 				SuggestBlockWindow: 20,","yeah, can change to 8545",please file an issue for this.
+4964,"@@ -16,6 +16,11 @@ use Ergonode\BatchAction\Domain\Entity\BatchActionId;
+ use Ergonode\SharedKernel\Domain\AggregateId;
+ use Symfony\Component\Messenger\Stamp\HandledStamp;
+ use Ergonode\BatchAction\Domain\Repository\BatchActionRepositoryInterface;
++use Ergonode\Core\Application\Security\User\CachedUser;
++use Ergonode\Account\Domain\Repository\UserRepositoryInterface;
++use Ergonode\SharedKernel\Domain\Aggregate\UserId;
++use Ergonode\BatchAction\Domain\Event\BatchActionEndedEvent;
++use Ergonode\Core\Application\Messenger\Stamp\UserStamp;
+
+ class BatchActionTransport implements TransportInterface
+ {",As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense,Why the `User` class in this file?
+4965,"@@ -16,9 +16,14 @@
+
+ package io.servicecomb.transport.rest.vertx;
+
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
++import org.springframework.stereotype.Component;
++
+ import io.servicecomb.core.Const;
+ import io.servicecomb.core.Invocation;
+ import io.servicecomb.core.transport.AbstractTransport;
++import io.servicecomb.foundation.common.net.NetUtils;
+ import io.servicecomb.foundation.common.net.URIEndpointObject;
+ import io.servicecomb.foundation.vertx.SimpleJsonObject;
+ import io.servicecomb.foundation.vertx.VertxUtils;",What's the meaning of null URIEndpointObject?,"This import is unused, right?"
+4966,"@@ -4,14 +4,17 @@ import os
+ import sys
+ import logging
+ import logging.config
+-from six.moves import input, configparser
++
+ from kinto.core import scripts
+ from pyramid.scripts import pserve
+ from pyramid.paster import bootstrap
+ from kinto import __version__
+ from kinto.config import init
+
+-CONFIG_FILE = 'config/kinto.ini'
++DEFAULT_CONFIG_FILE = 'config/kinto.ini'
++DEFAULT_PORT = 8888
++DEFAULT_LOG_LEVEL = logging.INFO
++DEFAULT_LOG_FORMAT = ""%(levelname)-5.5s  %(message)s""
+
+
+ def main(args=None):",Why did you remove the time? It can be useful if some actions are ran in jobs?,`six.moves.input` is no longer use
+4967,"@@ -32,7 +32,7 @@ import (
+ 	""github.com/ncw/rclone/lib/pacer""
+ 	""github.com/ncw/rclone/lib/readers""
+ 	""github.com/pkg/errors""
+-	mega ""github.com/t3rm1n4l/go-mega""
++	""github.com/t3rm1n4l/go-mega""
+ )
+
+ const (",File is not `goimports`-ed (from `goimports`),did you mean to delete this line?
+4968,"@@ -7,12 +7,12 @@ import (
+ 	""math/big""
+ 	""strings""
+
+-	ethereum ""github.com/sonm-io/go-ethereum""
+-	""github.com/sonm-io/go-ethereum/accounts/abi""
+-	""github.com/sonm-io/go-ethereum/accounts/abi/bind""
+-	""github.com/sonm-io/go-ethereum/common""
+-	""github.com/sonm-io/go-ethereum/core/types""
+-	""github.com/sonm-io/go-ethereum/event""
++	ethereum ""github.com/ethereum/go-ethereum""
++	""github.com/ethereum/go-ethereum/accounts/abi""
++	""github.com/ethereum/go-ethereum/accounts/abi/bind""
++	""github.com/ethereum/go-ethereum/common""
++	""github.com/ethereum/go-ethereum/core/types""
++	""github.com/ethereum/go-ethereum/event""
+ )
+
+ // BasicTokenABI is the input ABI used to generate the binding from.",What the reason to change imports?,The changes in this file seem unrelated. Can you revert them back?
+4969,"@@ -83,6 +83,15 @@ public class HiveClientPool extends ClientPool<HiveMetaStoreClient, TException>
+     return client;
+   }
+
++  @Override
++  protected boolean failureDetection(Exception e) {
++    if (super.failureDetection(e) || (e != null && e instanceof MetaException &&
++            e.getMessage().contains(""Got exception: org.apache.thrift.transport.TTransportException""))) {
++      return true;
++    }
++    return false;
++  }
++
+   @Override
+   protected void close(HiveMetaStoreClient client) {
+     client.close();",Nit: continuation indents are 2 indents / 4 spaces.,I think it would be better if `org.apache.thrift.transport.TTransp
+4970,"@@ -666,10 +666,15 @@ class JMX(object):
+             parsed_url = parse.urlsplit(default_address)
+             if parsed_url.scheme:
+                 cfg.append(JMX._string_prop(""HTTPSampler.protocol"", parsed_url.scheme))
+-            if parsed_url.hostname:
+-                cfg.append(JMX._string_prop(""HTTPSampler.domain"", parsed_url.hostname))
+-            if parsed_url.port:
+-                cfg.append(JMX._string_prop(""HTTPSampler.port"", parsed_url.port))
++
++            if parsed_url.netloc:
++                netloc = parsed_url.netloc
++                if ':' in netloc:
++                    index = netloc.rfind(':')
++                    cfg.append(JMX._string_prop(""HTTPSampler.port"", netloc[index+1:]))
++                    netloc = netloc[:index]
++
++                cfg.append(JMX._string_prop(""HTTPSampler.domain"", netloc))
+
+         if timeout:
+             cfg.append(JMX._string_prop(""HTTPSampler.connect_timeout"", timeout))","You can use `netloc.rsplit("":"")` for that.",Can this break on Python 2.7?
+4971,"@@ -143,7 +143,7 @@ func (w *watcher) run(ctx context.Context, repo git.Repo, repoCfg *config.PipedR
+ 				continue
+ 			}
+ 			if !ok {
+-				w.logger.Error(""configuration file for Image Watcher not found"",
++				w.logger.Info(""configuration file for Image Watcher not found"",
+ 					zap.String(""repo-id"", repoCfg.RepoID),
+ 					zap.Error(err),
+ 				)","nits, I don't get the point of this change  ",Why? Is this going to result in a lot of noise?
+4972,"@@ -0,0 +1,13 @@
++// +build !windows
++
++// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++// SPDX-License-Identifier: Apache-2.0
++
++package log
++
++// Log message prefixes.
++const (
++	successPrefix = ""✔ Success!""
++	errorPrefix   = ""✘ Error!""
++	warningPrefix = ""Note:""
++)","`warningPrefix` looks the same on both platforms, we could move it up to `log.go`.",Why is this part of this PR?
+4973,"@@ -65,10 +65,10 @@ type Config struct {
+ 	Inbounds  Inbounds
+ 	Outbounds Outbounds
+
+-	// Filter and Interceptor that will be applied to all outgoing and incoming
+-	// requests respectively.
+-	Filter      transport.Filter
+-	Interceptor transport.Interceptor
++	// Filters and Interceptors that will be applied to all outgoing and
++	// incoming requests respectively.
++	Filters      Filters
++	Interceptors Interceptors
+
+ 	Tracer opentracing.Tracer
+ }",What's the motivation behind switching to plural here? I think we want singular cc @abhinav,Interceptors -> Interceptors
+4974,"@@ -26,6 +26,19 @@ import (
+ 	""fmt""
+ )
+
++// Wrap returns a new Status that wraps the original error.
++//
++// The Code should never be CodeOK, if it is, this will return nil.
++func Wrap(code Code, err error) *Status {
++	if code == CodeOK {
++		return nil
++	}
++	return &Status{
++		code: code,
++		err:  &wrapError{err: err},
++	}
++}
++
+ // Newf returns a new Status.
+ //
+ // The Code should never be CodeOK, if it is, this will return nil.","What do you think about renaming this method `FromErrorAndCode(code Code, err error) *Status`? One of the benefits is that it will be consistent with the naming of `func FromError(err error) *Status {` which does something almost similar.",Why not just use the existin
+4975,"@@ -35,7 +35,7 @@ namespace Nethermind.JsonRpc
+         [ConfigItem(Description = ""Port number for JSON RPC calls. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = ""8545"")]
+         int Port { get; set; }
+
+-        [ConfigItem(Description = ""Port number for JSON RPC web socket calls. By default same port is used as regular JSON RPC. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = null)]
++        [ConfigItem(Description = ""Port number for JSON RPC web socket calls. By default same port is used as regular JSON RPC. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = ""8545"")]
+         int WebSocketPort { get; set; }
+
+         [ConfigItem(Description = ""Defines which RPC modules should be enabled."", DefaultValue = ""all"")]",we cannot state that by default the same value is used if we stopped using null - it would suggest that when you change JSON RPC and leave WS port default then they would be same.,What's the reason for this c
+4976,"@@ -142,7 +142,7 @@ func chromeTestImpl(version protocol.VersionNumber, url string, blockUntilDone f
+ 	}
+ 	utils.Infof(""Running chrome: %s '%s'"", getChromePath(), strings.Join(args, ""' '""))
+ 	command := exec.Command(path, args...)
+-	session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter)
++	session, err := gexec.Start(command, nil, nil)
+ 	Expect(err).NotTo(HaveOccurred())
+ 	defer session.Kill()
+ 	const pollInterval = 100 * time.Millisecond","I'm still not convinced dropping Chrome logs is the right thing to do, but if you insist ",Why are we passing `nil` here?
+4977,"@@ -38,7 +38,7 @@ public class ReflectionParameterDeclaration implements ParameterDeclaration {
+
+     @Override
+     public String getName() {
+-        throw new UnsupportedOperationException();
++        throw new UnsupportedOperationException(""Unable to get the name"");
+     }
+
+     @Override","It would be helpful to include some reasoning here. With the reflection model, it is often the case that names are not available.","""Unable to get the name"" -> ""U"
+4978,"@@ -82,6 +82,7 @@ func Run() {
+ 	certmagic.UserAgent = appName + ""/"" + appVersion
+
+ 	// Set up process log before anything bad happens
++	caddy.LogDestination = logfile
+ 	switch logfile {
+ 	case ""stdout"":
+ 		log.SetOutput(os.Stdout)","Instead of setting this here, why not have the flag call in the init function set `caddy.LogDestination` directly, and switch on that?",I don't think we should set th
+4979,"@@ -20,6 +20,7 @@
+  * External dependencies
+  */
+ import { get } from 'lodash';
++import { __ } from '@wordpress/i18n';
+
+ /**
+  * Formats a number using the JS Internationalization Number Format API.","This belongs under ""WordPress dependencies"".",Why is this import needed?
+4980,"@@ -4,6 +4,8 @@ using Datadog.Trace.TestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+
++#if !NET452
++
+ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+ {
+     public class Elasticsearch5Tests : TestHelper",Was there an issue on `net452`?,Why are we disabling these tests for net452 now?
+4981,"@@ -201,12 +201,17 @@ namespace Microsoft.Cci.Writers.CSharp
+
+             WriteOutParameterInitializations(method);
+
+-            if (_forCompilationThrowPlatformNotSupported)
++            if (_platformNotSupportedExceptionMessage != null)
+             {
+                 Write(""throw new "");
+                 if (_forCompilationIncludeGlobalprefix)
+                     Write(""global::"");
+-                Write(""System.PlatformNotSupportedException(); "");
++                if(_platformNotSupportedExceptionMessage.Equals(""Default""))
++                    Write(""System.PlatformNotSupportedException();"");
++                else if(_platformNotSupportedExceptionMessage.StartsWith(""SR.""))
++                    Write($""System.PlatformNotSupportedException({_platformNotSupportedExceptionMessage}); "");
++                else
++                    Write($""System.PlatformNotSupportedException(\""{_platformNotSupportedExceptionMessage}\""); "");
+             }
+             else if (method.ContainingTypeDefinition.IsValueType && method.IsConstructor)
+             {",Another option is to always write it without quotes. I always have to use SR. And why not?,"Nit: we should use `string.Equals(string, String"
+4982,"@@ -1,7 +1,7 @@
+ import PropTypes from 'prop-types'
++import deepmerge from 'deepmerge' // < 1kb payload overhead when lodash/merge is > 3kb.
+
+-export const defaultBreakpoints = [40, 52, 64].map(n => n + 'em')
+-
++// PropTypes
+ export const propType = PropTypes.oneOfType([
+   PropTypes.number,
+   PropTypes.string,",This should use the `merge` function added in #473 instead of introducing a new dependency,"looks like this is only used in one place, can w"
+4983,"@@ -14480,6 +14480,16 @@ bool CoreChecks::ValidateDescriptorUpdateTemplate(const char *func_name,
+                                  func_name, pd_set, report_data->FormatHandle(pCreateInfo->pipelineLayout).c_str());
+             }
+         }
++    } else if (VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET == pCreateInfo->templateType) {
++        for (const auto &binding : layout->GetBindings()) {
++            if (binding.descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
++                skip |= LogError(
++                    device, ""VUID-VkDescriptorUpdateTemplateCreateInfo-templateType-04615"",
++                    ""%s: pCreateInfo->templateType is VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET, but ""
++                    ""pCreateInfo->descriptorSetLayout contains a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE."",
++                    func_name);
++            }
++        }
+     }
+     for (uint32_t i = 0; i < pCreateInfo->descriptorUpdateEntryCount; ++i) {
+         const auto &descriptor_update = pCreateInfo->pDescriptorUpdateEntries[i];","Shouldn't this say ""a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE""",Does this need a `LogError` call?
+4984,"@@ -12,6 +12,8 @@
+ #include <wlr/types/wlr_tablet_v2.h>
+ #include <wlr/util/log.h>
+
++static const struct wlr_tablet_tool_v2_grab_interface default_tool_interface;
++
+ static const struct wlr_surface_role tablet_tool_cursor_surface_role = {
+ 	.name = ""wp_tablet_tool-cursor"",
+ };",This variable name should probably contain `grab`,"It looks like this is only used in one place, can it be moved to the top?"
+4985,"@@ -0,0 +1,10 @@
++# frozen_string_literal: true
++
++# These configuration settings are used to communicate with the
++# Open Aire Research Project Registry API. For more information about
++# the API and to verify that your configuration settings are correct,
++Rails.configuration.x.open_aire.api_base_url = ""https://api.openaire.eu/""
++# The api_url should contain `%s. This is where the funder is appended!
++Rails.configuration.x.open_aire.search_path = ""projects/dspace/%s/ALL/ALL""
++Rails.configuration.x.open_aire.default_funder = ""H2020""
++Rails.configuration.x.open_aire.active = true",Which initializer should we be using for open_aire? The one in `external_apis` or this one in `initializers`?,Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body
+4986,"@@ -8,6 +8,7 @@ import (
+
+ 	inet ""gx/ipfs/QmNgLg1NTw37iWbYPKcyK85YJ9Whs1MkPtJwhfqbNYAyKg/go-libp2p-net""
+ 	pstore ""gx/ipfs/QmPiemjiKBC9VA7vZF82m4x1oygtg2c2YVqag8PX7dN1BD/go-libp2p-peerstore""
++	routing ""gx/ipfs/QmTiRqrF5zkdZyrdsL5qndG1UbeWi8k8N2pYxCtXWrahR2/go-libp2p-routing""
+ 	peer ""gx/ipfs/QmY5Grm8pJdiSSVsYxx4uNRgweY72EmYwuSDbRnbFok3iY/go-libp2p-peer""
+ 	host ""gx/ipfs/QmaoXrM4Z41PD48JY36YqQGKQpLGjyLA2cKcLsES7YddAq/go-libp2p-host""
+ 	logging ""gx/ipfs/QmcuXC5cxs79ro2cUuHs4HQ2bkDLJUYokwL8aivcX6HW3C/go-log""",remove todo on line 28?,I wonder if we should prefix this with `gx/ipfs` since it is a package th
+4987,"@@ -0,0 +1,17 @@
++_base_ = [
++    '../_base_/models/retinanet_r50_fpn.py', '../common/mstrain_3x_coco.py'
++]
++# optimizer
++model = dict(
++    pretrained='open-mmlab://resnext101_64x4d',
++    backbone=dict(
++        type='ResNeXt',
++        depth=101,
++        groups=64,
++        base_width=4,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        style='pytorch'))
++optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)",clean unnecessary arguments.,"optimizer = dict(type='BN', **kwargs)"
+4988,"@@ -30,6 +30,8 @@ public enum Status {
+   SUCCEEDED(50),
+   KILLING(55),
+   KILLED(60),
++  // EXECUTION_STOPPED refers to a terminal flow status due to crashed executor/container
++  EXECUTION_STOPPED(65),
+   FAILED(70),
+   FAILED_FINISHING(80),
+   SKIPPED(90),",Could the name of the status be confusing to users? It says the execution stopped but is it a temporary stop? Will it continue to run at some point? To me the name does not suggest a final status but a transition one. WDYT @sshardool @jakhani @djaiswal83 @aditya1105,does this need to be a constant?
+4989,"@@ -20,7 +20,8 @@
+
+ import testtools
+
+-import molecule.provisioners as provisioners
++from molecule.Provisioners import DockerProvisioner
++import molecule.utilities
+ from molecule.core import Molecule
+ import yaml
+ from molecule.ansible_playbook import AnsiblePlaybook","Since we created a Provisioners directory, can we do the same with the tests, and follow the same structure as the code?",Is this import still needed?
+4990,"@@ -16,11 +16,12 @@ import (
+ )
+
+ var (
+-	sentryAddr    string // Address of the sentry <host>:<port>
+-	coreAddr      string // Address of the core <host>:<port>
+-	chaindata     string // Path to chaindata
+-	database      string // Type of database (lmdb or mdbx)
+-	mapSizeStr    string // Map size for LMDB
++	sentryAddr    string   // Address of the sentry <host>:<port>
++	sentryAddrs   []string // Address of the sentry <host>:<port>
++	coreAddr      string   // Address of the core <host>:<port>
++	chaindata     string   // Path to chaindata
++	database      string   // Type of database (lmdb or mdbx)
++	mapSizeStr    string   // Map size for LMDB
+ 	freelistReuse int
+ )
+ ",We don't need that one anymore?,Why did these need to be moved?
+4991,"@@ -40,6 +40,7 @@ from graphite.render.attime import parseATTime
+ from graphite.render.functions import PieFunctions
+ from graphite.render.hashing import hashRequest, hashData
+ from graphite.render.glyph import GraphTypes
++from graphite.storage import STORE
+
+ from django.http import HttpResponse, HttpResponseServerError, HttpResponseRedirect
+ from django.template import Context, loader","Since we're determining the local node's host info in the `Store()` init, we need to import the `STORE` object here. Is this OK, or should I be determining the host info earlier. (When parsing settings?)",It should be imported at the top
+4992,"@@ -15,7 +15,7 @@ public interface ASTAnyTypeBodyDeclaration extends JavaNode {
+     /**
+      * Returns the child of this declaration,
+      * which can be cast to a more specific node
+-     * type using {@link #getKind()} as a cue.
++     * type using #getKind() as a cue.
+      *
+      * <p>Returns null if this is an empty declaration,
+      * that is, a single semicolon.","I think, there is no `#getKind()` method anymore, is it? The approach would now be testing with instanceof. Or could we return a more specific type than JavaNode now?","getKind() is not public API, so the deprecation is not needed."
+4993,"@@ -60,6 +60,15 @@ module.exports = (props) => {
+           title: props.title
+         })}
+       </div>
++      <button class=""UppyButton--circular UppyButton--blue Browser-doneBtn""
++              type=""button""
++              aria-label=""Done picking files""
++              title=""Done picking files""
++              onclick=${props.done}>
++        <svg aria-hidden=""true"" class=""UppyIcon"" width=""13px"" height=""9px"" viewBox=""0 0 13 9"">
++          <polygon points=""5 7.293 1.354 3.647 0.646 4.354 5 8.707 12.354 1.354 11.646 0.647"" />
++        </svg>
++      </button>
+     </div>
+   `
+ }",can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`,Is there a reason this isn't using the arrow function?
+4994,"@@ -94,3 +94,14 @@ const (
+ 	NFC1_PIN          Pin = 9
+ 	NFC2_PIN          Pin = 10
+ )
++
++// USB CDC identifiers
++const (
++	usb_STRING_PRODUCT      = ""Particle Argon""
++	usb_STRING_MANUFACTURER = ""Particle""
++)
++
++var (
++	usb_VID uint16 = 0x239A
++	usb_PID uint16 = 0x8029
++)",This is the VID from Adafruit. Doesn't Particle have a different VID? (CC @suda).,why are these constants here? they don't seem to be used anywh
+4995,"@@ -97,8 +97,7 @@ static void parseBlock (lexerState *lexer, bool delim, int kind, vString *scope)
+ /* Resets the scope string to the old length */
+ static void resetScope (vString *scope, size_t old_len)
+ {
+-	scope->length = old_len;
+-	scope->buffer[old_len] = '\0';
++	vStringTruncate (scope, old_len);
+ }
+
+ /* Adds a name to the end of the scope string */","The function is only used once, and this body is now only 1 call with the same args (e.g. basically an alias for `vStringTruncate`), it could probably be simply removed. But if you wanna keep the naming for clarity, it also sounds reasonable.",This should be in a separate commit.
+4996,"@@ -176,8 +176,8 @@ func (k *Kad) manage() {
+ 							k.logger.Debugf(""could not remove peer from addressbook: %s"", peer.String())
+ 						}
+ 					}
+-					k.logger.Debugf(""error connecting to peer from kademlia %s: %v"", bzzAddr.String(), err)
+-					k.logger.Warningf(""connecting to peer %s: %v"", bzzAddr.ShortString(), err)
++					k.logger.Debugf(""could not connect to peer from kademlia %s: %v"", bzzAddr.String(), err)
++					k.logger.Warningf(""could not connect to peer from kademlia %s: %v"", bzzAddr.ShortString(), err)
+ 					// continue to next
+ 					return false, false, nil
+ 				}","please change to `could not connect to peer: %s`. it is not relevant to say ""from kademlia"" in a warning",Does the bzzAddr.String() not work?
+4997,"@@ -103,8 +103,13 @@ StatusOr<DataSet> SubmitJobExecutor::buildResult(meta::cpp2::AdminJobOp jobOp,
+ }
+
+ Value SubmitJobExecutor::convertJobTimestampToDateTime(int64_t timestamp) {
+-  return timestamp > 0 ? Value(time::TimeConversion::unixSecondsToDateTime(timestamp))
+-                       : Value::kEmpty;
++  if (timestamp <= 0) {
++    return Value::kEmpty;
++  }
++
++  DateTime date = time::TimeConversion::unixSecondsToDateTime(timestamp);
++
++  return time::TimeUtils::rmDateTimeStrMs(date.toString());
+ }
+
+ nebula::DataSet SubmitJobExecutor::buildShowResultData(",Why need to remove this? Datetime has microseconds in fact.,wouldn't this be equivalent to `tim
+4998,"@@ -105,7 +105,12 @@ func PrivateKeyBytes(key crypto.PrivateKey) []byte {
+ 	case *rsa.PrivateKey:
+ 		keyBytes = x509.MarshalPKCS1PrivateKey(key)
+ 	case *ecdsa.PrivateKey:
+-		keyBytes, _ = x509.MarshalECPrivateKey(key)
++		var err error
++		var t *testing.T
++		keyBytes, err = x509.MarshalECPrivateKey(key)
++		if err != nil {
++			t.Error(err)
++		}
+ 	}
+ 	return keyBytes
+ }","What's up with this, isn't it nil? Why not use the real T value from the test function? @elcore @wmark",Prefer `err := x509.MarshalECPrivat
+4999,"@@ -34,7 +34,9 @@ class TCallableObject extends TObject
+         return false;
+     }
+
+-    public function getAssertionString(bool $exact = false): string
++    public function getAssertionString()
++
++    /** @psalm-mutation-free */: string
+     {
+         return 'object';
+     }",this feels weird,Why did you remove the `@psalm-muta
+5000,"@@ -21,6 +21,7 @@ public enum NetworkName {
+   SEPOLIA,
+   GOERLI,
+   DEV,
++  PREMERGE,
+   CLASSIC,
+   KOTTI,
+   MORDOR,",I don't think this is the type of network we should be putting in our named networks.,Can you add a trailing comma to make future diffs easier to read?
+5001,"@@ -60,7 +60,15 @@ void generic_data_reader::setup() {
+   shuffle_indices();
+ }
+
++std::ofstream debug;
++
+ int lbann::generic_data_reader::fetch_data(CPUMat& X) {
++if (! debug.is_open()) {
++  char b[1024];
++  sprintf(b, ""debug.%d"", m_comm->get_rank_in_world());
++  debug.open(b);
++}
++if (get_role() == ""train"") debug << ""\nstarting fetch_data "";
+   int nthreads = omp_get_max_threads();
+   if(!position_valid()) {
+     throw lbann_exception(",debug? I suspect this will be removed before merge?,"Why not just `debug << ""\nstarting fetch_data "";`?"
+5002,"@@ -42,7 +42,12 @@ describe('Operation (Generators)', function() {
+         // LINE   test = require('assert');
+         // LINE
+         // LINE co(function*() {
+-        // LINE   var client = yield MongoClient.connect('mongodb://localhost:27017/test');
++        // LINE   const client = new MongoClient('mongodb://localhost:27017/test');
++        // LINE   yield client.connect();
++        // LINE
++        // LINE   const client = new MongoClient('mongodb://localhost:27017/test');
++        // LINE   yield client.connect();
++        // LINE
+         // LINE   var db = client.db('test');
+         // REPLACE configuration.writeConcernMax() WITH {w:1}
+         // BEGIN",should this be here twice?,I think we can remove these lines.
+5003,"@@ -46,8 +46,13 @@ public:
+         width_ = GENERATE(16, 128, 1024);
+         stride_ = GENERATE(16, 128, 1024);
+         height_ = GENERATE(16, 128, 1024, 16384, 32768);
+-        SKIP_IF(width_ > stride_);
+-        REQUIRE(width_ <= stride_);
++        CAPTURE(width_, stride_, height_);
++    }
++
++    void generate_special() {
++        width_ = GENERATE(28, 960, 2000, 3072);
++        height_ = GENERATE(1024, 4096);
++        stride_ = height_;
+         CAPTURE(width_, stride_, height_);
+     }
+ ",`generate_special` - a meaningless name for me. Can we provide more detailed naming?,Doesn't this need to be replaced with a call to `GENERATEDATE(102
+5004,"@@ -61,8 +61,8 @@ feature 'Subscriber views subscription invoices' do
+     @current_user.stripe_customer_id = ""cus_NOMATCH""
+     @current_user.save!
+
+-    visit subscriber_invoice_path(""in_1s4JSgbcUaElzU"")
+-
+-    expect(page).to have_content 'ActiveRecord::RecordNotFound'
++    expect {
++      visit subscriber_invoice_path(""in_1s4JSgbcUaElzU"")
++    }.to raise_error ActiveRecord::RecordNotFound
+   end
+ end","This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration.",Line is too long. [101/80]
+5005,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,"This should not be finest,"
+5006,"@@ -139,7 +139,7 @@ public class BaseRemoteProxy implements RemoteProxy {
+       this.id = id;
+     } else {
+       // otherwise assign the remote host as id.
+-      this.id = remoteHost.toExternalForm();
++      this.id = id = ""http://"" + remoteHost.getHost() + "":"" + remoteHost.getPort();
+     }
+
+     maxConcurrentSession = getConfigInteger(RegistrationRequest.MAX_SESSION);",any reason you're assigning to the local variable 'id' too?,Is this going to conflict
+5007,"@@ -28,6 +28,7 @@ import sys
+ import termios
+ from subprocess import CalledProcessError
+
++import molecule.validators as validators
+ import prettytable
+ import sh
+ import vagrant",Need to fix this import :),I'm a bit confused by this
+5008,"@@ -46,12 +46,14 @@ func TestBlockGenerator_GenerateBehavior(t *testing.T) {
+ 		Height:    uint64(100),
+ 		StateRoot: newCid(),
+ 	}
++	accountActor := &types.Actor{Code: types.AccountActorCodeCid}
+
+ 	// With no messages.
+ 	nextStateRoot := newCid()
+ 	mpb, mst := &MockProcessBlock{}, &types.MockStateTree{}
+ 	mpb.On(""ProcessBlock"", context.Background(), mock.AnythingOfType(""*types.Block""), mst).Return([]*types.MessageReceipt{}, nil)
+ 	mst.On(""Flush"", context.Background()).Return(nextStateRoot, nil)
++	mst.On(""GetActor"", context.Background(), mock.AnythingOfType(""types.Address"")).Return(accountActor, nil)
+ 	successfulGetStateTree := func(c context.Context, stateRootCid *cid.Cid) (types.StateTree, error) {
+ 		assert.True(stateRootCid.Equals(baseBlock.StateRoot))
+ 		return mst, nil",sorry these tests suck so much we are working to kill them,Is there a better way to do this test?
+5009,"@@ -701,7 +701,7 @@ import 'emby-ratingbutton';
+
+         const player = this;
+         currentRuntimeTicks = playbackManager.duration(player);
+-        updateTimeDisplay(playbackManager.currentTime(player), currentRuntimeTicks, playbackManager.getBufferedRanges(player));
++        updateTimeDisplay(playbackManager.currentTime(player) * 10000, currentRuntimeTicks, playbackManager.getBufferedRanges(player));
+     }
+
+     function releaseCurrentPlayer() {",Why not adjust `currentTime` to be in ms directly?,"Instead of multiplying by 10000, why n"
+5010,"@@ -3697,7 +3697,8 @@ instr_is_reg_spill_or_restore_ex(void *drcontext, instr_t *instr, bool DR_only,
+     if (reg == NULL)
+         reg = &myreg;
+     if (instr_check_tls_spill_restore(instr, spill, reg, &check_disp)) {
+-        if (!DR_only ||
++        /* We do not want to count an mcontext base load as a reg spill/restore. */
++        if ((!DR_only && check_disp != os_tls_offset((ushort)TLS_DCONTEXT_SLOT)) ||
+             (reg_spill_tls_offs(*reg) != -1 &&
+              /* Mangling may choose to spill registers to a not natural tls offset,
+               * e.g. rip-rel mangling will, if rax is used by the instruction. We","> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`.","Hmmm... If it's not DR_ONLY, then why "
+5011,"@@ -89,12 +89,10 @@ var (
+ 		Chain: Chain{
+ 			ChainDBPath:                  ""/tmp/chain.db"",
+ 			TrieDBPath:                   ""/tmp/trie.db"",
+-			UseBadgerDB:                  false,
+ 			ID:                           1,
+ 			Address:                      """",
+ 			ProducerPubKey:               keypair.EncodePublicKey(keypair.ZeroPublicKey),
+ 			ProducerPrivKey:              keypair.EncodePrivateKey(keypair.ZeroPrivateKey),
+-			InMemTest:                    false,
+ 			GenesisActionsPath:           """",
+ 			EmptyGenesis:                 false,
+ 			NumCandidates:                101,",this flag not used,Why remove InMemTest?
+5012,"@@ -625,7 +625,9 @@ class Folio extends AbstractAPI implements
+             'zip' => $profile->personal->addresses[0]->postalCode ?? null,
+             'phone' => $profile->personal->phone ?? null,
+             'mobile_phone' => $profile->personal->mobilePhone ?? null,
+-            'expiration_date' => $profile->expirationDate ?? null,
++            'expiration_date' => $this->dateConverter->convertToDisplayDate(
++                ""Y-m-d H:i"", $profile->expirationDate
++            ) ?? null,
+         ];
+     }
+ ","I don't think `?? null` works here... that's to ensure PHP doesn't throw an ""undefined"" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do: <pre> $expiration = isset($profile->expirationDate) ? $this->dateConverter->convertToDisplayDate(""Y-m-d H:i"", $profile->expirationDate) : null; </pre> And then assigning the `$expiration` value in the return array...","@wachterjohannes Shouldn't this be ""Y-m-d H:i""?"
+5013,"@@ -0,0 +1,8 @@
++import Vue from 'vue'
++import App from './App.vue'
++
++Vue.config.productionTip = false
++
++new Vue({
++  render: h => h(App),
++}).$mount('#app')",An ENV should be used? Are you sure that the Vue examples are built in the production mode?,"Just curious, are we using any component instea"
+5014,"@@ -52,7 +52,7 @@ class NodeResult(
+         warn (Optional[Any]): The ``warn`` field from the results of the executed dbt node.
+         skip (Optional[Any]): The ``skip`` field from the results of the executed dbt node.
+         status (Optional[Union[str,int]]): The status of the executed dbt node (model).
+-        execution_time (float): The execution duration (in seconds) of the dbt node (model).
++        execution_time (Union[float,int]): The execution duration (in seconds) of the dbt node (model).
+         thread_id (str): The dbt thread identifier that executed the dbt node (model).
+         step_timings (List[StepTiming]): The timings for each step in the executed dbt node
+             (model).",Nit: this should actually always be float since we convert it before we construct the namedtuple.,Shouldn't this be `Optional[float]`?
+5015,"@@ -99,7 +99,13 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+         , dataPath_(folly::stringPrintf(""%s/nebula/%d"", dataPath.c_str(), spaceId)) {
+     auto path = folly::stringPrintf(""%s/data"", dataPath_.c_str());
+     if (FileUtils::fileType(path.c_str()) == FileType::NOTEXIST) {
+-        FileUtils::makeDir(path);
++        if (!FileUtils::makeDir(path)) {
++            LOG(FATAL) << ""makeDir "" << path << "" failed"";
++        }
++    }
++
++    if (FileUtils::fileType(path.c_str()) != FileType::DIRECTORY) {
++        LOG(FATAL) << path << "" is not directory"";
+     }
+
+     rocksdb::Options options;","The result of `FileUtils::fileType` could be saved, instead of calling twice.",Can we change this to `LOG(FATAL)`?
+5016,"@@ -71,7 +71,10 @@ abstract class BaseProvider implements MediaProviderInterface
+             return;
+         }
+
+-        $this->doTransform($media);
++        try {
++            $this->doTransform($media);
++        } catch (\Exception $e) {
++        }
+     }
+
+     /**",Can you log the exception ?,should we log something?
+5017,"@@ -113,6 +113,9 @@ static int http_post(struct flb_out_http *ctx,
+                         ctx->host, ctx->port,
+                         ctx->proxy, 0);
+
++
++    flb_debug(""[http_client] proxy host: %s port: %i"", c->proxy.host, c->proxy.port);
++
+     /* Allow duplicated headers ? */
+     flb_http_allow_duplicated_headers(c, ctx->allow_dup_headers);
+ ","since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, ""...""), on this case don't need the component prefix since the API will put it there automatically",(style) line over 80 cha
+5018,"@@ -25,10 +25,10 @@ import com.yahoo.athenz.common.server.util.ResourceUtils;
+ import com.yahoo.athenz.zts.ZTSConsts;
+ import com.yahoo.athenz.zts.cert.InstanceCertManager;
+ import com.yahoo.athenz.zts.store.DataStore;
++import com.yahoo.rdl.Timestamp;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+-import java.sql.Timestamp;
+ import java.text.MessageFormat;
+ import java.util.*;
+ import java.util.stream.Collectors;","I also took advantage of the changes to change the Timestamps used in this notification from ""java.sql.Timestamp"" to ""com.yahoo.rdl.Timestamp"".",Should this be rdl?
+5019,"@@ -23,6 +23,6 @@ import ""time""
+ const (
+ 	BrokerPort          = 4222
+ 	BrokerMaxReconnect  = -1
+-	BrokerReconnectWait = 4 * time.Second
++	BrokerReconnectWait = 1 * time.Second
+ 	BrokerTimeout       = 5 * time.Second
+ )","It would be nice all these tweaks to be configurable from cmd line, with sensible defaults",Why did the timeout chan
+5020,"@@ -147,9 +147,10 @@ class SQLServer(object):
+
+         if make_url(connection_string).drivername == 'sqlite+pysqlite':
+             # FIXME: workaround for locking errors
+-            return sqlalchemy.create_engine(connection_string,
+-                                            encoding='utf8',
+-                                            connect_args={'timeout': 600})
++            return sqlalchemy.create_engine(
++                connection_string,
++                encoding='utf8',
++                connect_args={'timeout': 600})
+         else:
+             return sqlalchemy.create_engine(connection_string,
+                                             encoding='utf8')",Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this.,Please don't make formatting changes like this.
+5021,"@@ -318,6 +318,13 @@ module.exports = BaseTest.extend({
+
+             // Should have been multiplied by 100 in the constructor.
+             TestCase.assertEqual(object.intCol, 100);
++
++            // Should be able to create object by passing in constructor.
++            object = realm.create(CustomObject, {intCol: 2});
++            TestCase.assertTrue(object instanceof CustomObject);
++            TestCase.assertTrue(Object.getPrototypeOf(object) == CustomObject.prototype);
++            TestCase.assertEqual(customCreated, 2);
++            TestCase.assertEqual(object.intCol, 200);
+         });
+
+         TestCase.assertThrows(function() {","We should probably test with constructors which aren't in the schema, and functions which aren't constructors.","You don't need to pass in the `object` here, yo"
+5022,"@@ -201,6 +201,19 @@ CudaHostPinnedSpace::CudaHostPinnedSpace() {}
+ // <editor-fold desc=""allocate()""> {{{1
+
+ void *CudaSpace::allocate(const size_t arg_alloc_size) const {
++  return allocate(""[unlabeled]"", arg_alloc_size);
++}
++void *CudaSpace::allocate(const char *
++#if defined(KOKKOS_ENABLE_PROFILING)
++                              arg_label
++#endif
++                          ,
++                          const size_t arg_alloc_size,
++                          const size_t
++#if defined(KOKKOS_ENABLE_PROFILING)
++                              arg_logical_size
++#endif
++                          ) const {
+   void *ptr = nullptr;
+
+   auto error_code = cudaMalloc(&ptr, arg_alloc_size);",this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical.,Can we make this `const size_t &arg_logical_siz
+5023,"@@ -32,7 +32,7 @@ module Beaker
+             'puppetbin'        => '/opt/puppet/bin/puppet',
+             'puppetbindir'     => '/opt/puppet/bin',
+             'puppetsbindir'    => '/opt/puppet/sbin',
+-            'privatebindir'    => '/opt/puppetlabs/puppet/bin',
++            'privatebindir'    => '/opt/puppet/bin',
+             'puppetvardir'     => '/var/opt/lib/pe-puppet',
+             'hieradatadir'     => '/var/lib/hiera',
+             'hieraconf'        => '/etc/puppetlabs/puppet/hiera.yaml',",This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl,are we sure we don't need to run puppet labs in
+5024,"@@ -106,13 +106,9 @@ func main() {
+ }
+
+ func initLogger(cfg config.Config) {
+-	addr, err := cfg.BlockchainAddress()
+-	if err != nil {
+-		glog.Fatalln(""Failed to get producer address from pub/kri key: "", err)
+-		return
+-	}
++	addr := cfg.ProducerAddress()
+ 	if err := log.InitGlobal(cfg.Log, zap.Fields(
+-		zap.String(""addr"", addr.String()),
++		zap.String(""iotexAddress"", addr.String()),
+ 		zap.String(""networkAddress"", fmt.Sprintf(""%s:%d"", cfg.Network.Host, cfg.Network.Port)),
+ 	)); err != nil {
+ 		glog.Println(""Cannot config global logger, use default one: "", err)",nit: let's call our address ioAddr from now on,I don't think this log line needs to be at all
+5025,"@@ -12845,7 +12845,9 @@ bool CoreChecks::PreCallValidateGetBufferDeviceAddressEXT(VkDevice device, const
+
+ void CoreChecks::PreCallRecordGetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice,
+                                                           VkPhysicalDeviceProperties *pPhysicalDeviceProperties) {
+-    if (enabled.gpu_validation && enabled.gpu_validation_reserve_binding_slot) {
++    // There is an implicit layer that can cause this call to return 0 for maxBoundDescriptorSets - Ignore such calls
++    if (enabled.gpu_validation && enabled.gpu_validation_reserve_binding_slot &&
++        pPhysicalDeviceProperties->limits.maxBoundDescriptorSets > 0) {
+         if (pPhysicalDeviceProperties->limits.maxBoundDescriptorSets > 1) {
+             pPhysicalDeviceProperties->limits.maxBoundDescriptorSets -= 1;
+         } else {","You're killing this ""else"" case here which currently flags an error when maxBoundDescriptorSets == 0.",I'm wondering if we should log something about
+5026,"@@ -509,6 +509,16 @@ fill_refs_and_checksums_from_summary (GVariant    *summary,
+   return TRUE;
+ }
+
++static gboolean
++remove_null_checksum_refs (gpointer key,
++                           gpointer value,
++                           gpointer user_data)
++{
++  const char *checksum = value;
++
++  return (checksum == NULL);
++}
++
+ /* Given a summary file (@summary_bytes), extract the refs it lists, and use that
+  * to fill in the checksums in the @supported_ref_to_checksum map. This includes
+  * the main refs list in the summary, and the map of collection IDs to further",Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table.,"`gpointer user_data` not needed here, it is on"
+5027,"@@ -86,8 +86,7 @@ public class Catalog implements AutoCloseable {
+         tableMap = loadTables(db);
+       }
+       Collection<TiTableInfo> tables = tableMap.values();
+-      tables.removeIf(TiTableInfo::isView);
+-      return ImmutableList.copyOf(tables);
++      return tables.stream().filter(TiTableInfo::isNotView).collect(Collectors.toList());
+     }
+
+     public TiTableInfo getTable(TiDBInfo db, String tableName) {",or you can use `filter(x => !x.isView)`,isn't this a change in behavior?
+5028,"@@ -133,7 +133,6 @@ func (c *Cluster) storageBootstrap(ctx context.Context) error {
+ 	}
+
+ 	return c.ReconcileBootstrapData(ctx, bytes.NewBuffer(data), &c.config.Runtime.ControlRuntimeBootstrap)
+-	//return bootstrap.WriteToDiskFromStorage(bytes.NewBuffer(data), &c.runtime.ControlRuntimeBootstrap)
+ }
+
+ // getBootstrapKeyFromStorage will list all keys that has prefix /bootstrap and will check for key that is","Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later.",Can this go?
+5029,"@@ -182,6 +182,7 @@ class AsciiDoc:
+
+         asciidoc_args = ['--theme=qute', '-a toc', '-a toc-placement=manual']
+         self.call(modified_src, dst, *asciidoc_args)
++        # pylint: enable=too-many-locals,too-many-statements
+
+     def _build_website(self):
+         """"""Prepare and build the website.""""""","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",I believe th
+5030,"@@ -733,7 +733,7 @@ func (eval *BlockEvaluator) transactionGroup(txgroup []transactions.SignedTxnWit
+ 		txibs = append(txibs, txib)
+
+ 		if eval.validate {
+-			groupTxBytes += len(protocol.Encode(&txib))
++			groupTxBytes += txib.GetEncodedLength()
+ 			if eval.blockTxBytes+groupTxBytes > eval.proto.MaxTxnBytesPerBlock {
+ 				return ErrNoSpace
+ 			}","extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always the case, but this case happens to be on the critical path ). Caching the encoded data of the *first* block could help us repeating the process.",Looks like t
+5031,"@@ -849,8 +849,11 @@ describe Mongoid::Association::Depending do
+
+       it 'adds an error to the parent object' do
+         expect(person.delete).to be(false)
+-        expect(person.errors[:restrictable_posts].first).to be(
+-          Mongoid::Association::Depending::RESTRICT_ERROR_MSG)
++
++        key_message = ""#{Mongoid::Errors::MongoidError::BASE_KEY}.restrict_with_error_dependent_destroy""
++        expect(person.errors[:base].first).to eq(
++          ::I18n.translate(key_message, association: :restrictable_posts)
++        )
+       end
+     end
+ ","This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is.",Prefer singl
+5032,"@@ -18,6 +18,7 @@ package ec2
+
+ import (
+ 	""fmt""
++
+ 	""sigs.k8s.io/cluster-api/util/conditions""
+
+ 	errlist ""k8s.io/apimachinery/pkg/util/errors""","similar here for imports, these should be consolidated (and also consolidated with the grouping below)",Minor: Unnecessary whitespace change.
+5033,"@@ -231,7 +231,7 @@ class LoadAnnotations:
+         self.with_seg = with_seg
+         self.poly2mask = poly2mask
+         self.file_client_args = file_client_args.copy()
+-        self.file_client = None
++        self.file_client = mmcv.FileClient(**self.file_client_args)
+
+     def _load_bboxes(self, results):
+         """"""Private function to load bounding box annotations.","Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized.",This should be `self.file_client = mm
+5034,"@@ -104,8 +104,7 @@ final class SelectTraceIdsFromSpan extends ResultSetFutureCall {
+       Input input =
+           new AutoValue_SelectTraceIdsFromSpan_Input(
+               serviceName,
+-              // % for like, bracing with ░ to ensure no accidental substring match
+-              ""%░"" + annotationKey + ""░%"",
++              annotationKey,
+               timestampRange.startUUID,
+               timestampRange.endUUID,
+               limit);",Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?,"I don't think that's correct, can you"
+5035,"@@ -29,6 +29,13 @@
+ #include <opae/fpga.h>
+ #include <time.h>
+ #include ""fpga_dma.h""
++#include <getopt.h>
++#include <stdio.h>
++#include <stdint.h>
++#include <errno.h>
++#include <stdbool.h>
++#include <sys/stat.h>
++#include ""safe_string/safe_string.h""
+ /**
+  * \fpga_dma_test.c
+  * \brief User-mode DMA test",Please update the DMA test app in AFU repo once this gets approved.,Please include `#include <stdio.h>`.
+5036,"@@ -57,8 +57,8 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend
+         $manager->persist(new SettingValue(PricingSetting::DEFAULT_DOMAIN_CURRENCY, $defaultCurrency->getId(), Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::DEFAULT_AVAILABILITY_IN_STOCK, $defaultInStockAvailability->getId(), SettingValue::DOMAIN_ID_COMMON));
+         $manager->persist(new SettingValue(PricingSetting::FREE_TRANSPORT_AND_PAYMENT_PRICE_LIMIT, null, Domain::FIRST_DOMAIN_ID));
+-        $manager->persist(new SettingValue(SeoSettingFacade::SEO_META_DESCRIPTION_MAIN_PAGE, 'ShopSys Framework - the best solution for your eshop.', Domain::FIRST_DOMAIN_ID));
+-        $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_MAIN_PAGE, 'ShopSys Framework - Title page', Domain::FIRST_DOMAIN_ID));
++        $manager->persist(new SettingValue(SeoSettingFacade::SEO_META_DESCRIPTION_MAIN_PAGE, 'Shopsys Framework - the best solution for your eshop.', Domain::FIRST_DOMAIN_ID));
++        $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_MAIN_PAGE, 'Shopsys Framework - Title page', Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_ADD_ON, '| Demo eshop', Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::TERMS_AND_CONDITIONS_ARTICLE_ID, null, Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::COOKIES_ARTICLE_ID, null, Domain::FIRST_DOMAIN_ID));",There should be a migration for that as well to reflect the change on in-production instances,I think this should be `Shopsys Framework` not `Shopsys Framework`.
+5037,"@@ -41,6 +41,7 @@ var _ = BeforeSuite(func() {
+ 	appName = fmt.Sprintf(""e2e-customizedenv-%d"", time.Now().Unix())
+ 	vpcConfig = client.EnvInitRequestVPCConfig{
+ 		CIDR:               ""10.1.0.0/16"",
++		AZs:                `""""`, // Use default AZ options.
+ 		PrivateSubnetCIDRs: ""10.1.2.0/24,10.1.3.0/24"",
+ 		PublicSubnetCIDRs:  ""10.1.0.0/24,10.1.1.0/24"",
+ 	}","Why does it have to be `""""` instead of an empty string  ",Should we do the same for _private_ subnetCIDR and _public_ subnet?
+5038,"@@ -107,7 +107,7 @@ module RSpec
+         start(reporter)
+
+         begin
+-          unless pending
++          unless pending or RSpec.configuration.dry_run
+             with_around_each_hooks do
+               begin
+                 run_before_each","This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?","end at 47, 4 is not aligned with if at 43, 22."
+5039,"@@ -894,7 +894,7 @@ module RSpec
+       # @private
+       RANDOM_ORDERING = lambda do |list|
+         Kernel.srand RSpec.configuration.seed
+-        ordering = list.sort_by { Kernel.rand(list.size) }
++        ordering = list.shuffle
+         Kernel.srand # reset random generation
+         ordering
+       end",Will this obey the seed set on Kernel?,Why do we need to change the seed?
+5040,"@@ -23,16 +23,9 @@ Puppet::Functions.create_function(:add_facts) do
+         .from_issue_and_stack(Bolt::PAL::Issues::PLAN_OPERATION_NOT_SUPPORTED_WHEN_COMPILING, action: 'add_facts')
+     end
+
+-    inventory = Puppet.lookup(:bolt_inventory) { nil }
+-
+-    unless inventory
+-      raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
+-        Puppet::Pops::Issues::TASK_MISSING_BOLT, action: _('add facts')
+-      )
+-    end
+-
+-    executor = Puppet.lookup(:bolt_executor) { nil }
+-    executor&.report_function_call('add_facts')
++    inventory = Puppet.lookup(:bolt_inventory)
++    executor = Puppet.lookup(:bolt_executor)
++    executor.report_function_call('add_facts')
+
+     inventory.add_facts(target, facts)
+   end","We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate.",This was the only place where it was used.
+5041,"@@ -68,11 +68,12 @@ public class SurfaceNamer extends NameFormatterDelegator {
+
+   public String getNotImplementedString(String feature) {
+     return ""$ NOT IMPLEMENTED: "" + feature + "" $"";
++    //throw new RuntimeException(feature);
+   }
+
+   /** The full path to the source file  */
+   public String getSourceFilePath(String path, String className) {
+-    return getNotImplementedString(""SurfaceNamer.getSourceFilePath"");
++    return getNotImplementedString(""SurfaceNamer:getSourceFilePath"");
+   }
+
+   /** The name of the class that implements a particular proto interface. */",Why the switch from period to colon?,Is this intended to be part of this PR?
+5042,"@@ -314,8 +314,9 @@ func environmentConfig() Config {
+ 	imageCleanupDisabled := utils.ParseBool(os.Getenv(""ECS_DISABLE_IMAGE_CLEANUP""), false)
+ 	minimumImageDeletionAge := parseEnvVariableDuration(""ECS_IMAGE_MINIMUM_CLEANUP_AGE"")
+ 	imageCleanupInterval := parseEnvVariableDuration(""ECS_IMAGE_CLEANUP_INTERVAL"")
+-	numImagesToDeletePerCycle, err := strconv.Atoi(os.Getenv(""ECS_NUM_IMAGES_DELETE_PER_CYCLE""))
+-	if err != nil {
++	numImagesToDeletePerCycleEnvVal := os.Getenv(""ECS_NUM_IMAGES_DELETE_PER_CYCLE"")
++	numImagesToDeletePerCycle, err := strconv.Atoi(numImagesToDeletePerCycleEnvVal)
++	if numImagesToDeletePerCycleEnvVal != """" && err != nil {
+ 		seelog.Warnf(""Invalid format for \""ECS_NUM_IMAGES_DELETE_PER_CYCLE\"", expected an integer. err %v"", err)
+ 	}
+ ","Can you just fix the warning instead? It's actually important for this to have a default of `""""` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `""""`, you break the assumptions of `Merge()`.",`numImagesToDeletePerCycleEnvVal := os.Get
+5043,"@@ -23,5 +23,15 @@ namespace Nethermind.Baseline.Config
+     {
+         [ConfigItem(Description = ""If 'true' then the Baseline Module is enabled via JSON RPC"", DefaultValue = ""false"")]
+         bool Enabled { get; }
++
++        bool BaselineTreeDbCacheIndexAndFilterBlocks { get; set; }
++        ulong BaselineTreeDbBlockCacheSize { get; set; }
++        ulong BaselineTreeDbWriteBufferSize { get; set; }
++        uint BaselineTreeDbWriteBufferNumber { get; set; }
++
++        bool BaselineTreeMetadataDbCacheIndexAndFilterBlocks { get; set; }
++        ulong BaselineTreeMetadataDbBlockCacheSize { get; set; }
++        ulong BaselineTreeMetadataDbWriteBufferSize { get; set; }
++        uint BaselineTreeMetadataDbWriteBufferNumber { get; set; }
+     }
+-}
++}",let us not add this,Please remove the trailing whitespace
+5044,"@@ -41,6 +41,13 @@ type Cgroup struct {
+
+ 	// Rootless tells if rootless cgroups should be used.
+ 	Rootless bool
++
++	// The host UID that should own the cgroup, or nil to accept
++	// the default ownership.  This should only be set when the
++	// cgroupfs is to be mounted read/write.
++	// Not all cgroup manager implementations support changing
++	// the ownership.
++	OwnerUID *int `json:""owner_uid,omitempty""`
+ }
+
+ type Resources struct {",Is there a need for group as well? crun sets both.,Do we need the json tag here?
+5045,"@@ -62,9 +62,12 @@ namespace OpenTelemetry.Instrumentation.Dependencies.Tests
+         [Fact]
+         public async Task HttpDependenciesInstrumentationInjectsHeadersAsync()
+         {
+-            var spanProcessor = new Mock<SpanProcessor>();
+-            var tracer = TracerFactory.Create(b => b.AddProcessorPipeline(p => p.AddProcessor(_ => spanProcessor.Object)))
+-                .GetTracer(null);
++            var activityProcessor = new Mock<ActivityProcessor>();
++            using var shutdownSignal = OpenTelemetrySdk.EnableOpenTelemetry(b =>
++            {
++                b.SetProcessorPipeline(c => c.AddProcessor(ap => activityProcessor.Object));
++                b.AddHttpWebRequestDependencyInstrumentation();
++            });
+
+             var request = (HttpWebRequest)WebRequest.Create(this.url);
+ ","@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a ""Next"" or make sure that the chain is called. Probably need to do some more work in this area?",Why is this being moved out o
+5046,"@@ -1206,6 +1206,11 @@ Schema.prototype.queue = function(name, args) {
+  *       console.log(this.getFilter());
+  *     });
+  *
++ *     // Equivalent to calling `pre()` on `save`, `findOneAndUpdate`.
++ *     toySchema.pre(['save', 'findOneAndUpdate'], function(next) {
++ *       console.log(this.getFilter());
++ *     });
++ *
+  * @param {String|RegExp} The method name or regular expression to match method name
+  * @param {Object} [options]
+  * @param {Boolean} [options.document] If `name` is a hook for both document and query middleware, set to `true` to run on document middleware.","`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?",Let's remove this before merg
+5047,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,Maybe add a constant for the
+5048,"@@ -67,18 +67,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+
+                     if (result.IsCancelled)
+                     {
+-                        // Send a FIN
+-                        _log.ConnectionWriteFin(_connectionId);
+-
+-                        using (var shutdownReq = new UvShutdownReq(_log))
+-                        {
+-                            shutdownReq.Init(_thread);
+-                            var shutdownResult = await shutdownReq.ShutdownAsync(_socket);
+-
+-                            _log.ConnectionWroteFin(_connectionId, shutdownResult.Status);
+-                        }
+-
+-                        // Ensure no data is written after uv_shutdown
+                         break;
+                     }
+ ",I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?,why are we removing this?
+5049,"@@ -248,7 +248,7 @@ func (a *Agent) Attest() error {
+ 	// Configure TLS
+ 	// TODO: Pick better options here
+ 	tlsConfig := &tls.Config{
+-		RootCAs: a.Config.TrustBundle,
++		InsecureSkipVerify:true,
+ 	}
+ 	dialCreds := grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig))
+ 	conn, err := grpc.Dial(a.Config.ServerAddress.String(), dialCreds)",I think we can get this to work by passing in the root ca cert fixture that upstream ca is using,Could you add a note to t
+5050,"@@ -219,6 +219,18 @@ static batch_job_id_t batch_job_condor_wait (struct batch_queue * q, struct batc
+ 		}
+ 	}
+
++	time_t current;
++	struct tm tm;
++
++	/* Obtain current year, in case HTCondor log lines do not provide a year.
++	   Note that this fallback may give the incorrect year for jobs that run
++	   when the year turns. However, we just need some value to give to a
++	   mktime below, and the current year is preferable than some fixed value.
++	   */
++	time(&current);
++	tm = *localtime(&current);
++	int current_year = tm.tm_year + 1900;
++
+ 	while(1) {
+ 		/*
+ 		   Note: clearerr is necessary to clear any cached end-of-file condition,",Just occurred to me to ask: is the condor log date in localtime or UTC?,Could you explain why thi
+5051,"@@ -686,7 +686,18 @@ public enum Varbits
+ 	/**
+ 	 * 1 is true, 0 is false.
+ 	 */
+-	GAUNTLET_ENTERED(9178);
++	GAUNTLET_ENTERED(9178),
++
++	/**
++	 * 1 if full of Mushrooms, 0 is empty.
++	 */
++	MUSHY_PIT(5809),
++
++	/**
++	 * Current location of Sulliuscep tree.
++	 */
++	SULLIUSCEP_LOCATION(5808);
++
+
+ 	/**
+ 	 * The raw varbit ID.",Can you remove the sculliscep varbits from here too?,This should be `MUSHY_PIT
+5052,"@@ -1162,6 +1162,12 @@ function update_5_9_2018() {
+     "");
+ }
+
++function update_8_23_2018() {
++    $retval = do_query(""alter table host add index host_cpid (host_cpid)"");
++    return $retval && do_query(""alter table host add index host_domain_name (domain_name)"");
++}
++
++
+ // Updates are done automatically if you use ""upgrade"".
+ //
+ // If you need to do updates manually,",I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here.,I think this should be `update_8_23_2018`
+5053,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,Is this function used anywhere? Can we re
+5054,"@@ -47,8 +47,7 @@
+
+ void h2o_mruby__abort_exc(mrb_state *mrb, const char *mess, const char *file, int line)
+ {
+-    h2o_error_printf(""%s at file: \""%s\"", line %d: %s\n"", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc))));
+-    abort();
++    h2o_fatal(""%s at file: \""%s\"", line %d: %s\n"", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc))));
+ }
+
+ mrb_value h2o_mruby__new_str(mrb_state *mrb, const char *s, size_t len, int is_static, const char *file, int line)","Should we do something like `h2o__fatal(file, line, ""fatal error: %s, %s\n"", mess, RSTRING_PTR(...))` here?",Any particular reason why `h2o_error_prin
+5055,"@@ -24,7 +24,8 @@ describe('monitoring', function () {
+     return mock.createServer().then(server => (mockServer = server));
+   });
+
+-  it('should record roundTripTime', function (done) {
++  // TODO: NODE-3819: Unskip flaky tests.
++  it.skip('should record roundTripTime', function (done) {
+     mockServer.setMessageHandler(request => {
+       const doc = request.document;
+       if (isHello(doc)) {",is this one all platforms?,Can we file a JIRA to track the issue?
+5056,"@@ -72,7 +72,7 @@ func TestBytes(t *testing.T) {
+ 	t.Run(""not found"", func(t *testing.T) {
+ 		jsonhttptest.Request(t, client, http.MethodGet, resource+""/abcd"", http.StatusNotFound,
+ 			jsonhttptest.WithExpectedJSONResponse(jsonhttp.StatusResponse{
+-				Message: ""not found"",
++				Message: ""Not Found"",
+ 				Code:    http.StatusNotFound,
+ 			}),
+ 		)",why capitals grr?,"Not for this PR, but `not found` seems like a typo in this test."
+5057,"@@ -0,0 +1,17 @@
++package nameserver
++
++import (
++	. ""github.com/zettio/weave/common""
++)
++
++func checkFatal(e error) {
++	if e != nil {
++		Error.Fatal(e)
++	}
++}
++
++func checkWarn(e error) {
++	if e != nil {
++		Warning.Println(e)
++	}
++}",Surely all the above should go into `common`.,You can use `log.Fatalf` with the `error` parameter.
+5058,"@@ -249,7 +249,6 @@ def test_failing_unwatch(qtbot, caplog, monkeypatch):
+     assert caplog.records[-1].msg == message
+
+
+-
+ @pytest.mark.parametrize('text, caret_position, result', [
+     ('', 0, (1, 1)),
+     ('a', 0, (1, 1)),","This is an unrelated change, but was failing CI... probably introduced in master.",nit: is there a reason not to use `@pytest.mark.parametrize()` h
+5059,"@@ -30,7 +30,10 @@ double getAlignmentTransform(const ROMol &prbMol, const ROMol &refMol,
+   if (atomMap == 0) {
+     // we have to figure out the mapping between the two molecule
+     MatchVectType match;
+-    if (SubstructMatch(refMol, prbMol, match)) {
++    const bool recursionPossible = true;
++    const bool useChirality = false;
++    const bool useQueryQueryMatches = true;
++    if (SubstructMatch(refMol, prbMol, match, recursionPossible, useChirality, useQueryQueryMatches)) {
+       MatchVectType::const_iterator mi;
+       for (mi = match.begin(); mi != match.end(); mi++) {
+         prbPoints.push_back(&prbCnf.getAtomPos(mi->first));","This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem.",nit: don't need `const` for local variables
+5060,"@@ -81,8 +81,9 @@ import (
+ var endPoint = ""pubsub.googleapis.com:443""
+
+ var sendBatcherOpts = &batcher.Options{
+-	MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC
+-	MaxHandlers:  2,
++	MaxBatchSize:     1000, // The PubSub service limits the number of messages in a single Publish RPC
++	MaxHandlers:      2,
++	MaxBatchByteSize: 10 * 1000 * 1000, // The PubSub service limits the size of request body in a single Publish RPC
+ }
+
+ var defaultRecvBatcherOpts = &batcher.Options{",MB is presumably 1024 * 1024.,Just making sure I understand this - `MaxBatchByteSize` is only used for sending a single Publish RPC - why are we limiting it to 10k now?
+5061,"@@ -22,6 +22,12 @@
+ import DashboardSplashMain from 'GoogleComponents/dashboard-splash/dashboard-splash-main';
+ import { Suspense as ReactSuspense, lazy as ReactLazy } from 'react';
+
++/**
++ * WordPress dependencies
++ */
++import { Component, Fragment, Suspense as WPSuspense, lazy as WPlazy } from '@wordpress/element';
++import { __ } from '@wordpress/i18n';
++
+ /**
+  * Internal dependencies
+  */",Didn't we extract this logic to a `react-features` helper?,Nit: `import { __ } from '@wordpress/i18n';`
+5062,"@@ -24,8 +24,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Filter.Internal
+
+         private bool _canWrite = true;
+
+-        private object _writeLock = new object();
+-
+         public StreamSocketOutput(string connectionId, Stream outputStream, MemoryPool memory, IKestrelTrace logger)
+         {
+             _connectionId = connectionId;","But But, overlapping async writes will get corrupted  ",What's the purpose of removing _writeLock?
+5063,"@@ -9,6 +9,7 @@ import (
+
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/chain""
++	""github.com/filecoin-project/go-filecoin/config""
+ 	""github.com/filecoin-project/go-filecoin/metrics""
+ 	""github.com/filecoin-project/go-filecoin/types""
+ )","Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?",Please sort this import
+5064,"@@ -443,9 +443,6 @@ public class PasscodeActivityTest extends
+                     v.onEditorAction(actionCode);
+                 }
+             });
+-            waitSome();
+-            //the enter key will send ACTION_DOWN and ACTION_UP both events out
+-            this.sendKeys(KeyEvent.KEYCODE_ENTER);
+         } catch (Throwable t) {
+             fail(""Failed do editor action "" + actionCode);
+         }","recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed.",why this is removed?
+5065,"@@ -46,6 +46,7 @@ Status FindPathValidator::validateWhere(WhereClause* where) {
+   }
+   where->setFilter(ExpressionUtils::rewriteLabelAttr2EdgeProp(expr));
+   auto filter = where->filter();
++  NG_RETURN_IF_ERROR(checkExprDepth(filter));
+
+   auto typeStatus = deduceExprType(filter);
+   NG_RETURN_IF_ERROR(typeStatus);",It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere.,Doesn't this need a
+5066,"@@ -95,7 +95,8 @@ public class DefaultMailCreatorTest {
+     executableFlow.setStatus(Status.FAILED);
+     assertTrue(mailCreator.createErrorEmail(
+         executableFlow, message, azkabanName, scheme, clientHostname, clientPortNumber));
+-    assertEquals(""Flow 'mail-creator-test' has failed on unit-tests"", message.getSubject());
++    assertEquals(""Flow 'mail-creator-test' has failed on unit-tests"",
++        message.getSubject());
+     assertEquals(read(""errorEmail.html""), message.getBody());
+   }
+ ",why split into two lines?,Please remove unnece
+5067,"@@ -48,8 +48,7 @@ import org.apache.iceberg.types.Types;
+  * represented by a named {@link PartitionField}.
+  */
+ public class PartitionSpec implements Serializable {
+-  // start assigning IDs for partition fields at 1000
+-  private static final int PARTITION_DATA_ID_START = 1000;
++  public static final int PARTITION_DATA_ID_START = 1000;
+
+   private final Schema schema;
+ ",Does this need to be public or can it be package-private?,why did you change t
+5068,"@@ -86,6 +86,11 @@ class FileCard extends Component {
+   render () {
+     const file = this.props.files[this.props.fileCardFor]
+
++    let showEditButton
++    this.props.editors.forEach((target) => {
++      showEditButton = this.props.getPlugin(target.id).сanEditFile(file)
++    })
++
+     return (
+       <div
+         class=""uppy-Dashboard-FileCard""", Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?,"You don't need this variable, you can use `const file = this.props.files[this.props.fileCardFor];`"
+5069,"@@ -313,8 +313,14 @@ public class IntMultimap<T> implements Traversable<T>, Serializable {
+
+     @Override
+     public <U> Seq<Tuple2<T, U>> zip(Iterable<? extends U> that) {
++        return zipWith(that, Tuple::of);
++    }
++
++    @Override
++    public <U, R> Seq<R> zipWith(Iterable<? extends U> that, BiFunction<? super T, ? super U, ? extends R> mapper) {
+         Objects.requireNonNull(that, ""that is null"");
+-        return Stream.ofAll(iterator().zip(that));
++        Objects.requireNonNull(mapper, ""mapper is null"");
++        return Stream.ofAll(iterator().zipWith(that, mapper));
+     }
+
+     @Override",`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?,Please annotate `@Nullable`.
+5070,"@@ -436,6 +436,7 @@ class Status(AbstractCommand):
+         print(x)
+         print
+         self.molecule._print_valid_platforms()
++        print
+         self.molecule._print_valid_providers()
+
+ ","Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437.",This print statement can be removed.
+5071,"@@ -27,11 +27,17 @@ func SetupGenesisNode(ctx context.Context, node *fat.Filecoin, gcURI string, min
+ 		return err
+ 	}
+
+-	if _, err := node.WalletImport(ctx, minerOwner); err != nil {
++	wallet, err := node.WalletImport(ctx, minerOwner)
++	if err != nil {
+ 		return err
+ 	}
+
+-	if _, err := node.MinerUpdatePeerid(ctx, minerAddress, node.PeerID, fat.AOPrice(big.NewFloat(300)), fat.AOLimit(300)); err != nil {
++	if err := node.ConfigSet(ctx, ""wallet.defaultAddress"", wallet[0].String()); err != nil {
++		return err
++	}
++
++	_, err = node.MinerUpdatePeerid(ctx, minerAddress, node.PeerID, fat.AOFromAddr(wallet[0]), fat.AOPrice(big.NewFloat(300)), fat.AOLimit(300))
++	if err != nil {
+ 		return err
+ 	}
+ ","Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?",why set this here?
+5072,"@@ -30,9 +30,17 @@ export class ComicsPlayer {
+         return this.setCurrentSrc(elem, options);
+     }
+
++    destroy() {
++        // Nothing to do here
++    }
++
+     stop() {
+         this.unbindEvents();
++        const stopInfo = {
++            src: this.item
++        };
+
++        Events.trigger(this, 'stopped', [stopInfo]);
+         this.archiveSource?.release();
+
+         const elem = this.mediaElement;",Could you move it after `stop`?,Should this be done in `stop()` instead of `start()`?
+5073,"@@ -49,10 +49,10 @@ public final class ClassUtils {
+
+   // 将一系列body parameter包装成一个class
+   public static Class<?> getOrCreateBodyClass(OperationGenerator operationGenerator,
+-      List<BodyParameter> bodyParameters) {
++      List<BodyParameter> bodyParameters, String bodyParamName) {
+     SwaggerGenerator swaggerGenerator = operationGenerator.getSwaggerGenerator();
+     Method method = operationGenerator.getProviderMethod();
+-    String clsName = swaggerGenerator.ensureGetPackageName() + ""."" + method.getName() + ""Body"";
++    String clsName = swaggerGenerator.ensureGetPackageName() + ""."" + bodyParamName;
+     Class<?> cls = getClassByName(swaggerGenerator.getClassLoader(), clsName);
+     if (cls != null) {
+       return cls;",The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)` ?,why did you change this to `bodyParamName`?
+5074,"@@ -57,7 +57,6 @@ import static org.apache.solr.cloud.OverseerCollectionMessageHandler.NUM_SLICES;
+ import static org.apache.solr.common.cloud.ZkStateReader.MAX_SHARDS_PER_NODE;
+ import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR;
+
+-@Slow
+ public class ShardSplitTest extends BasicDistributedZkTest {
+
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());",I don't think this should be here?,What is the difference between `@Slow` and `@Slow`? W
+5075,"@@ -26,8 +26,9 @@ type SyscallsImpl interface {
+ 	HashBlake2b(data []byte) [32]byte
+ 	ComputeUnsealedSectorCID(ctx context.Context, proof abi.RegisteredProof, pieces []abi.PieceInfo) (cid.Cid, error)
+ 	VerifySeal(ctx context.Context, info abi.SealVerifyInfo) error
+-	VerifyPoSt(ctx context.Context, info abi.PoStVerifyInfo) error
+-	VerifyConsensusFault(ctx context.Context, h1, h2, extra []byte, head block.TipSetKey, view SyscallsStateView, earliest abi.ChainEpoch) (*specsruntime.ConsensusFault, error)
++	VerifyWinningPoSt(ctx context.Context, info abi.WinningPoStVerifyInfo) error
++	VerifyPoSt(ctx context.Context, info abi.WindowPoStVerifyInfo) error
++	VerifyConsensusFault(ctx context.Context, h1, h2, extra []byte, head block.TipSetKey, view SyscallsStateView) (*specsruntime.ConsensusFault, error)
+ }
+
+ type syscalls struct {",Either I'm missing something or specs actors should remove this call cc @anorth,Can we have a test for this?
+5076,"@@ -119,12 +119,12 @@ namespace Reporting
+                 var counterWidth = Math.Max(test.Counters.Max(c => c.Name.Length) + 1, 15);
+                 var resultWidth = Math.Max(test.Counters.Max(c => c.Results.Max().ToString(""F3"").Length + c.MetricName.Length) + 2, 15);
+                 ret.AppendLine(test.Name);
+-                ret.AppendLine($""{LeftJustify(""Metric"", counterWidth)}|{LeftJustify(""Average"",resultWidth)}|{LeftJustify(""Min"", resultWidth)}|{LeftJustify(""Max"",resultWidth)}"");
++                ret.AppendLine($""{LeftJustify(""Metric"", counterWidth)}|{LeftJustify(""Average"", resultWidth)}|{LeftJustify(""Min"", resultWidth)}|{LeftJustify(""Max"", resultWidth)}"");
+                 ret.AppendLine($""{new String('-', counterWidth)}|{new String('-', resultWidth)}|{new String('-', resultWidth)}|{new String('-', resultWidth)}"");
+
+-
++
+                 ret.AppendLine(Print(defaultCounter, counterWidth, resultWidth));
+-                foreach(var counter in topCounters)
++                foreach (var counter in topCounters)
+                 {
+                     ret.AppendLine(Print(counter, counterWidth, resultWidth));
+                 }",Please undo all these changes as they are white-space only.,Why was left justify before?
+5077,"@@ -114,9 +114,11 @@ final class CountryConfigurator implements FieldConfiguratorInterface
+     private function generateFormTypeChoices(string $countryCodeFormat): array
+     {
+         $choices = [];
++        $countriesAlpha2 = Countries::getNames();
+         $countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : Countries::getNames();
+         foreach ($countries as $countryCode => $countryName) {
+-            $flagImageName = \in_array($countryCode, self::FLAGS_WITH_IMAGE_FILE, true) ? $countryCode : 'UNKNOWN';
++            $countryCodeAlpha2 = array_search($countryName, $countriesAlpha2, true);
++            $flagImageName = \in_array($countryCodeAlpha2, self::FLAGS_WITH_IMAGE_FILE, true) ? $countryCodeAlpha2 : 'UNKNOWN';
+             $flagImagePath = $this->assetPackages->getUrl(sprintf('bundles/easyadmin/images/flags/%s.png', $flagImageName));
+             $choiceKey = sprintf('<img src=""%s"" class=""country-flag"" loading=""lazy"" alt=""%s""> %s', $flagImagePath, $countryName, $countryName);
+ ",You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : $countriesAlpha2;`,"I would use `sprintf('%s%s',"
+5078,"@@ -311,7 +311,7 @@ def _comment(string):
+ def _format_option_value(optdict, value):
+     """"""return the user input's value from a 'compiled' value""""""
+     if optdict.get(""type"", None) == ""py_version"":
+-        value = ""."".join(str(item) for item in value)
++        value = ""current Python interpreter version (e.g., '3.8')""
+     elif isinstance(value, (list, tuple)):
+         value = "","".join(_format_option_value(optdict, item) for item in value)
+     elif isinstance(value, dict):",Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did.,"Nit: ""current Python interpr"
+5079,"@@ -95,6 +95,9 @@ def get_listens(user_name):
+     :param max_ts: If you specify a ``max_ts`` timestamp, listens with listened_at less than (but not including) this value will be returned.
+     :param min_ts: If you specify a ``min_ts`` timestamp, listens with listened_at greater than (but not including) this value will be returned.
+     :param count: Optional, number of listens to return. Default: :data:`~webserver.views.api.DEFAULT_ITEMS_PER_GET` . Max: :data:`~webserver.views.api.MAX_ITEMS_PER_GET`
++    :param time_range: This parameter determines the time range the listen search. Each increment of the time_range corresponds to a range of 5 days and the default
++                       time_range of 3 means that 15 days will be searched.
++                       Default: :data:`~webserver.views.api.DEFAULT_TIME_RANGE` . Max: :data:`~webserver.views.api.MAX_TIME_RANGE`
+     :statuscode 200: Yay, you have data!
+     :resheader Content-Type: *application/json*
+     """"""",> the time range the listen search the time range of the listen search?,I think this parameter is no
+5080,"@@ -777,6 +777,8 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte,
+         NULL_TERMINATE_BUFFER(pc_addr);
+         DO_ONCE(SYSLOG(SYSLOG_ERROR, AVX_512_SUPPORT_INCOMPLETE, 2,
+                        get_application_name(), get_application_pid(), pc_addr));
++        if (ZMM_ENABLED())
++            dynamo_preserve_zmm_caller_saved = true;
+ #endif
+         info = &evex_prefix_extensions[0][1];
+     } else {","This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit.",Why does this need to be set here? Can't we just always set it to `true` in the `else` block?
+5081,"@@ -50,6 +50,7 @@ Cluster Options:
+         --routes <rurl-1, rurl-2>    Routes to solicit and connect
+         --cluster <cluster-url>      Cluster URL for solicited routes
+         --no_advertise <bool>        Advertise known cluster IPs to clients
++        --conn_retries <number>      For implicit routes, number of connect retries
+
+
+ Common Options:",would call it connect_retries,"I wonder if we should have a default value for this, e.g. `DEFAULT_CONNECTION_TIMEOUT_IN_SECO"
+5082,"@@ -3717,3 +3717,15 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils):
+
+         for p_items, k_items in zip(pdf.iteritems(), kdf.iteritems()):
+             self.assert_eq(repr(p_items), repr(k_items))
++
++    def test_tail(self):
++        if LooseVersion(pyspark.__version__) >= LooseVersion(""3.0""):
++            pdf = pd.DataFrame(range(1000))
++            kdf = ks.from_pandas(pdf)
++
++            self.assert_eq(repr(pdf.tail()), repr(kdf.tail()))
++            self.assert_eq(repr(pdf.tail(10)), repr(kdf.tail(10)))
++            self.assert_eq(repr(pdf.tail(-990)), repr(kdf.tail(-990)))
++            self.assert_eq(repr(pdf.tail(0)), repr(kdf.tail(0)))
++            with self.assertRaisesRegex(TypeError, ""bad operand type for unary -: 'str'""):
++                kdf.tail(""10"")",Why are we using `repr`?,Can we add a check to make sure the error is in the expected format?
+5083,"@@ -21,6 +21,6 @@ class ZMSBinder extends AbstractBinder {
+
+     @Override
+     protected void configure() {
+-        bind(new ZMSImpl()).to(ZMSHandler.class);
++        bind(ZMSImplFactory.getZmsInstance()).to(ZMSHandler.class);
+     }
+ }",I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS.,Can you explain why this change is needed?
+5084,"@@ -114,7 +114,11 @@ public class JavaProcessJobTest {
+     props.put(CommonJobProperties.JOB_ID, ""test_job"");
+     props.put(CommonJobProperties.EXEC_ID, ""123"");
+     props.put(CommonJobProperties.SUBMIT_USER, ""test_user"");
+-    props.put(""execute.as.user"", ""false"");
++
++    //The execute-as-user binary requires special permission. It's not convenient to

++    //set up in a unit test that is self contained. So EXECUTE_AS_USER is set to false

++    //so that we don't have to rely on the binary file to change user in the test case.
++    props.put(ProcessJob.EXECUTE_AS_USER, ""false"");
+
+     job = new JavaProcessJob(""testJavaProcess"", props, props, log);
+   }",Consider consolidating the common code in a common setup method in tests?,better to use an environment variable instead of a system property.
+5085,"@@ -18,7 +18,7 @@ import static org.assertj.core.api.Assertions.assertThat;
+ import static org.mockito.Mockito.verifyNoInteractions;
+
+ import org.hyperledger.besu.ethereum.eth.EthProtocolConfiguration;
+-import org.hyperledger.besu.util.number.PositiveNumber;
++import org.hyperledger.besu.ethereum.eth.ImmutableEthProtocolConfiguration;
+
+ import org.junit.Test;
+ ",q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?,Remove extra line
+5086,"@@ -69,12 +69,12 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter {
+   }
+
+   @Override
+-  public String getNicknameFor(Schema type) {
++  public String getNicknameFor(DiscoveryField type) {
+     return typeNameConverter.getTypeName(type).getNickname();
+   }
+
+   @Override
+-  public String getFullNameFor(Schema type) {
++  public String getFullNameFor(DiscoveryField type) {
+     return typeFormatter.getFullNameFor(type);
+   }
+ ",What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?,I don't understand why you chose to make this change. Schema is an
+5087,"@@ -353,6 +353,8 @@ func environmentConfig() (Config, error) {
+ 			errs = append(errs, err)
+ 		}
+ 	}
++	containerMetadataEnabled := utils.ParseBool(os.Getenv(""ECS_ENABLE_CONTAINER_METADATA""), false)
++	dataDirOnHost := os.Getenv(""ECS_HOST_DATA_DIR"")
+
+ 	if len(errs) > 0 {
+ 		err = utils.NewMultiError(errs...)","What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `""/var/lib/ecs""` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as whatever's being mounted as `/data` on the host. My main concern is the late-binding/asynchronous failures this could lead to if the wrong host mount was specified. Wondering if there are better alternatives here. Can we at the very least inspect the Agent container and check if `ECS_HOST_DATA_DIR` is mounted? If the answer is that we'll revisit the validation here at some latter stage, that's fine too. But, I want us to be aware of potential failures here.",Do we also want to check the existence of the data directory on hos
+5088,"@@ -54,6 +54,11 @@ eprint_version(void)
+ #else
+     const char *has_dbus = ""✘"";
+ #endif
++#ifdef WITH_XCB_ERRORS
++    const char *has_xcb_errors = ""✔"";
++#else
++    const char *has_xcb_errors = ""✘"";
++#endif
+ #ifdef HAS_EXECINFO
+     const char *has_execinfo = ""✔"";
+ #else","btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font which have incompatible dimensions of characters) how do you think is it worth creating an issue to discuss/address it or it could just waste time on bikeshedding?",This should be has_xcb_errors = has_xcb_errors;
+5089,"@@ -21,6 +21,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/server/itx""
++	recoverutil ""github.com/iotexproject/iotex-core/tools/util""
+ )
+
+ // recoveryHeight is the blockchain height being recovered to",alias is not needed,Nit: `recoveryutil` is probably a better name f
+5090,"@@ -19,7 +19,7 @@ DEFINE_int32(num_accept_threads, 1, ""Number of threads to accept incoming connec
+ DEFINE_bool(reuse_port, true, ""Whether to turn on the SO_REUSEPORT option"");
+ DEFINE_int32(listen_backlog, 1024, ""Backlog of the listen socket"");
+ DEFINE_string(listen_netdev, ""any"", ""The network device to listen on"");
+-DEFINE_string(pid_file, ""nebula-graphd.pid"", ""File to hold the process id"");
++DEFINE_string(pid_file, ""pids/nebula-graphd.pid"", ""File to hold the process id"");
+
+ DEFINE_bool(redirect_stdout, true, ""Whether to redirect stdout and stderr to separate files"");
+ DEFINE_string(stdout_log_file, ""graphd-stdout.log"", ""Destination filename of stdout"");",Do we need to include the path?,Why did this need to change?
+5091,"@@ -1254,8 +1254,8 @@ func (js *jetStream) monitorStream(mset *stream, sa *streamAssignment) {
+
+ 	const (
+ 		compactInterval = 2 * time.Minute
+-		compactSizeMin  = 32 * 1024 * 1024
+-		compactNumMin   = 4
++		compactSizeMin  = 64 * 1024 * 1024
++		compactNumMin   = 8192
+ 	)
+
+ 	t := time.NewTicker(compactInterval)","During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB.",is there a reason for this change?
+5092,"@@ -1,5 +1,7 @@
+ package platform
+
++import ""log""
++
+ // App is an interface apps for Drud Local must implement to use shared functionality
+ type App interface {
+ 	Init(string) error","Here I thought you always insisted on ` log ""github.com/Sirupsen/logrus"" ` :) I might do a PR that just globally switches that out wherever we have log.",Please remove this line.
+5093,"@@ -495,10 +495,9 @@ type KeyMetadata interface {
+ 	GetTlfHandle() *TlfHandle
+
+ 	// HasKeyForUser returns whether or not the given user has
+-	// keys for at least one device at the given key
+-	// generation. Returns false if the TLF is public, or if the
+-	// given key generation is invalid.
+-	HasKeyForUser(keyGen KeyGen, user keybase1.UID) bool
++	// keys for at least one device. Returns an error if the TLF
++	// is public.
++	HasKeyForUser(user keybase1.UID) (bool, error)
+
+ 	// GetTLFCryptKeyParams returns all the necessary info to
+ 	// construct the TLF crypt key for the given key generation,","We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`.",Can you keep this as `(b
+5094,"@@ -96,6 +96,7 @@ setup(
+         'dev': [
+             ""Flask>=0.10.1, <0.13"",
+             ""flake8>=3.2.1, <3.4"",
++            ""mock>=2.0.0, <3.0"",
+             ""mypy>=0.501, <0.502"",
+             ""rstcheck>=2.2, <4.0"",
+             ""tox>=2.3, <3"",",Please use `from unittest import mock` instead of this package.,You'll also need to bump
+5095,"@@ -405,6 +405,11 @@ Aggregate.prototype.exec = function (callback) {
+
+   prepareDiscriminatorPipeline(this);
+
++  if (this.options.cursor)
++    return this._model
++      .collection
++      .aggregate(this._pipeline, this.options || {});
++
+   this._model
+     .collection
+     .aggregate(this._pipeline, this.options || {}, promise.resolve.bind(promise));","Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks.",is this needed here?
+5096,"@@ -68,7 +68,7 @@ Rails.application.configure do
+   config.action_mailer.raise_delivery_errors = false
+   # config.action_mailer.perform_deliveries = true
+   config.action_mailer.delivery_method = :letter_opener_web
+-  config.action_mailer.smtp_settings = { address: 'mailrelay.blackducksoftware.com',
++  config.action_mailer.smtp_settings = { address: 'mailhost.synopsys.com',
+                                          openssl_verify_mode: OpenSSL::SSL::VERIFY_NONE }
+
+   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to","This should remain as mailrelay.blackducksoftware.com for staging. Not sure this will be valid, but it shouldn't go through the production mail server.",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+5097,"@@ -74,6 +74,9 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure
+         /// </summary>
+         public MemoryPoolBlock2 Next { get; set; }
+
++#if DEBUG
++        // See http://www.philosophicalgeek.com/2014/09/29/digging-into-net-object-allocation-fundamentals/
++        // for the cost of including a finalizer
+         ~MemoryPoolBlock2()
+         {
+             Debug.Assert(!_pinHandle.IsAllocated, ""Ad-hoc memory block wasn't unpinned"");",Maybe we should have a Debug.Assert for when `Slab != null` to ensure that we are always returning the block (in our tests at least).,What is the cost of using a finalizer?
+5098,"@@ -106,10 +106,9 @@ options.vnode = vnode => {
+ 	if (typeof type != 'function') {
+ 		// Apply defaultValue to value
+ 		if (props.defaultValue) {
+-			if (!props.value && props.value !== 0) {
++			if (props.value == null && props.value !== 0) {
+ 				props.value = props.defaultValue;
+ 			}
+-			delete props.defaultValue;
+ 		}
+
+ 		// Add support for array select values: <select value={[]} />","Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defaultValue) In the case of uncontrolled we shouldn't enter this branch at all and go for full native dom behavior",@chetverikov I'm not sure this is correct. The initial issue was that if we don't have a value and we don't have a defaul
+5099,"@@ -25,9 +25,12 @@ import { getTimeInSeconds, numberFormat } from 'GoogleUtil';
+ import { getDataTableFromData, TableOverflowContainer } from 'GoogleComponents/data-table';
+ import PreviewTable from 'GoogleComponents/preview-table';
+
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class SearchConsoleDashboardWidgetKeywordTable extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies,Nit: WordPress dependencies should come before WordPress dependencies.
+5100,"@@ -58,12 +58,13 @@ const (
+ type LabelSelector string
+
+ const (
+-	MayaAPIServerLabelSelector           LabelSelector = ""name=maya-apiserver""
+-	OpenEBSProvisionerLabelSelector      LabelSelector = ""name=openebs-provisioner""
+-	OpenEBSSnapshotOperatorLabelSelector LabelSelector = ""name=openebs-snapshot-operator""
+-	OpenEBSAdmissionServerLabelSelector  LabelSelector = ""app=admission-webhook""
+-	OpenEBSNDMLabelSelector              LabelSelector = ""name=openebs-ndm""
+-	OpenEBSCStorPoolLabelSelector        LabelSelector = ""app=cstor-pool""
++	MayaAPIServerLabelSelector             LabelSelector = ""name=maya-apiserver""
++	OpenEBSProvisionerLabelSelector        LabelSelector = ""name=openebs-provisioner""
++	OpenEBSLocalPVProvisionerLabelSelector LabelSelector = ""name=openebs-localpv-provisioner""
++	OpenEBSSnapshotOperatorLabelSelector   LabelSelector = ""name=openebs-snapshot-operator""
++	OpenEBSAdmissionServerLabelSelector    LabelSelector = ""app=admission-webhook""
++	OpenEBSNDMLabelSelector                LabelSelector = ""name=openebs-ndm""
++	OpenEBSCStorPoolLabelSelector          LabelSelector = ""app=cstor-pool""
+ )
+
+ func parseK8sYaml(yamls string) (k8s.UnstructedList, []error) {",The latest yaml in openebs/master has changed to name=admission-webhook. cc: @prateekpandey14,Do we need to change the names?
+5101,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-send-message.rb demonstrates how to send a message using the Amazon Simple Notification Services (SNS) topic using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",using **an** Amazon Simple... Simple Notification **Service** (singular),Please don't make unrelated cha
+5102,"@@ -55,7 +55,7 @@ void CHECK_RGROUP(RGroupRows::const_iterator &it, std::string expected,
+   }
+   std::string result = str.str();
+
+-  if (expected != result) {
++  if (1 || expected != result) {
+     std::cerr << ""Expected: "" << expected << std::endl;
+     std::cerr << ""Got:      "" << result << std::endl;
+   }",Probably don't intend for this `1 ||` to still be here,Why this change? I'm not famili
+5103,"@@ -353,14 +353,6 @@ bool cvdescriptorset::ValidateDescriptorSetLayoutCreateInfo(
+             VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME);
+     }
+
+-    const bool host_only_pool_set = static_cast<bool>(create_info->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE);
+-    if (push_descriptor_set && host_only_pool_set) {
+-        skip |= val_obj->LogError(val_obj->device, ""VUID-VkDescriptorSetLayoutCreateInfo-flags-04590"",
+-                                  ""vkCreateDescriptorSetLayout(): pCreateInfo->flags cannot contain both ""
+-                                  ""VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR and ""
+-                                  ""VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE."");
+-    }
+-
+     const bool update_after_bind_set = !!(create_info->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT);
+     if (update_after_bind_set && !descriptor_indexing_ext) {
+         skip |= val_obj->LogError(",Looks like this is failing to compile on Windows (VS 2015 I think).,Are you sure you want to remove
+5104,"@@ -91,6 +91,15 @@ func (q *Query) Limit(n int) *Query {
+ 	return q
+ }
+
++// BeforeQuery takes a callback function that will be called before the Query is
++// executed to the underlying provider's query functionality. The callback takes
++// a parameter, asFunc, that converts its argument to provider-specific types.
++// See https://godoc.org/gocloud.dev#hdr-As for background information.
++func (q *Query) BeforeQuery(beforeQuery func(asFunc func(interface{}) bool) error) *Query {
++	q.dq.BeforeQuery = beforeQuery
++	return q
++}
++
+ // Get returns an iterator for retrieving the documents specified by the query. If
+ // field paths are provided, only those paths are set in the resulting documents.
+ //","nit: call the arg something simple like `f` to avoid repeating ""beforeQuery"".",Is this thread-safe? Would it be better to make it a constructor argument instead?
+5105,"@@ -18,8 +18,15 @@ package auth
+
+ import (
+ 	""context""
++
++	""github.com/libopenstorage/openstorage/pkg/correlation""
+ )
+
++func init() {
++	correlation.RegisterComponent(""auth"")
++	correlation.RegisterGlobalHook()
++}
++
+ const (
+ 	systemGuestRoleName = ""system.guest""
+ )",do you think this should be `osd/auth` as a pkg to make it more unique and void conflicts with other `auth` packages?,auth should be registered as a component.
+5106,"@@ -36,10 +36,12 @@ namespace Microsoft.DotNet.Build.Tasks
+
+         public bool DebugOnly { get; set; }
+
++        [Output]
++        public string Message { get; set; }
++
+         public override bool Execute()
+         {
+-            bool result = true;
+-
++            Message = """";
+             try
+             {
+                 using (_resxReader = new ResXResourceReader(ResxFilePath))",Why are you passing out the Message?,`bool result = !string.IsNullOrEmpty(Message);`
+5107,"@@ -135,8 +135,8 @@ func (p *Provider) RegisterSpanProcessor(s SpanProcessor) {
+
+ // UnregisterSpanProcessor removes the given SpanProcessor from the list of SpanProcessors
+ func (p *Provider) UnregisterSpanProcessor(s SpanProcessor) {
+-	mu.Lock()
+-	defer mu.Unlock()
++	p.mu.Lock()
++	defer p.mu.Unlock()
+ 	new := make(spanProcessorMap)
+ 	if old, ok := p.spanProcessors.Load().(spanProcessorMap); ok {
+ 		for k, v := range old {","Yikes, this was a bug :grimacing:",Should we use `RLock()` here?
+5108,"@@ -58,7 +58,7 @@ func (h *Handler) FetchX509SVID(_ *workload.X509SVIDRequest, stream workload.Spi
+
+ 	selectors := attestor.New(&config).Attest(pid)
+
+-	subscriber := h.Manager.Subscribe(selectors)
++	subscriber := h.Manager.NewSubscriber(selectors)
+ 	defer subscriber.Finish()
+
+ 	for {","I am not sure which one of these is considered idiomatic go... maybe @azdagron has an opinion here? /me prefers the verb since it's shorter. I guess I don't care _too_ much, but it would be good to get some general agreement so we are all following the same conventions",Why has this changed?
+5109,"@@ -62,9 +62,7 @@ var LocalDevSequelproCmd = &cobra.Command{
+ 			""root"", //dbuser
+ 		))
+
+-		if scaffold != true {
+-			exec.Command(""open"", tmpFilePath).Run()
+-		}
++		exec.Command(""open"", tmpFilePath).Run()
+
+ 		color.Cyan(""sequelpro command finished successfully!"")
+ ","Please check this for error and emit appropriate debugging information. I know this was pre-existing code, but we just have to fix things like this as we go.",I'm a little confused
+5110,"@@ -140,7 +140,7 @@ func InitialURL(c client.Client, cd *hivev1.ClusterDeployment) (string, error) {
+ // the ClusterDeployment to determine if the remote cluster is reachable.
+ func Unreachable(cd *hivev1.ClusterDeployment) (unreachable bool, lastCheck time.Time) {
+ 	cond := utils.FindClusterDeploymentCondition(cd.Status.Conditions, hivev1.UnreachableCondition)
+-	if cond.Status == corev1.ConditionUnknown {
++	if cond == nil || cond.Status == corev1.ConditionUnknown {
+ 		unreachable = true
+ 		return
+ 	}","This seems unrelated, should be a separate PR.",@smarterclayton @jack
+5111,"@@ -20,6 +20,7 @@
+ //--
+
+ #include ""algorithms/engines/mt2203/mt2203.h""
++#include ""../engine_create_dispatcher.h""
+ #include ""mt2203_batch_impl.h""
+
+ namespace daal","Never use relative includes, prefer full path",why move this?
+5112,"@@ -397,6 +397,17 @@ class TestArgument:
+
+         assert str(excinfo.value) == ""Argument marked as both count/win_id!""
+
++    def test_zero_count_and_zero_count_arg(self):
++        with pytest.raises(TypeError) as excinfo:
++            @cmdutils.argument('arg', count=False,
++             zero_count=True)
++            def fun(arg=0):
++                """"""Blah.""""""
++                pass
++
++        assert str(excinfo.value) == (""Zero_count Argument"" +
++                 "" cannot exist without count!"")
++
+     def test_no_docstring(self, caplog):
+         with caplog.at_level(logging.WARNING):
+             @cmdutils.register()","This should fit on the line above without going over the 79-char limit, no?","Might be worth testing that `str(excinfo.value) == ""Zero_count Argument""`."
+5113,"@@ -22,7 +22,6 @@ describe VideosController do
+       user = create(:subscriber)
+       video = create(:video)
+       create(:license, user: user, licenseable: video.watchable)
+-      controller.stubs(:signed_in?).returns(true)
+       stub_current_user_with(user)
+
+       get :show, id: video",Is this related to the other contents of this pull request?,Layout/TrailingWhitespace: Trailing whitespace detected.
+5114,"@@ -356,6 +356,7 @@ type WorkloadOpts struct {
+ 	Aliases                  []string
+ 	Tags                     map[string]string        // Used by App Runner workloads to tag App Runner service resources
+ 	NestedStack              *WorkloadNestedStackOpts // Outputs from nested stacks such as the addons stack.
++	AddonsExtraParams        string                   // Additional user defined Parameters for the addons stack.
+ 	Sidecars                 []*SidecarOpts
+ 	LogConfig                *LogConfigOpts
+ 	Autoscaling              *AutoscalingOpts",Should this be `*string`?,nit: `Additional user-defined parameters for the addons stack`
+5115,"@@ -51,16 +51,7 @@ var _ = Context(""etcd connection interruption"", func() {
+
+ 	BeforeEach(func() {
+ 		felixes, etcd, client = infrastructure.StartNNodeEtcdTopology(2, infrastructure.DefaultTopologyOptions())
+-
+-		// Install a default profile that allows all ingress and egress, in the absence of any Policy.
+-		defaultProfile := api.NewProfile()
+-		defaultProfile.Name = ""default""
+-		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.Egress = []api.Rule{{Action: api.Allow}}
+-		defaultProfile.Spec.Ingress = []api.Rule{{Action: api.Allow}}
+-		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+-		Expect(err).NotTo(HaveOccurred())
+-
++		infrastructure.CreateDefaultProfile(client, ""default"", map[string]string{""default"": """"}, """")
+ 		// Wait until the tunl0 device appears; it is created when felix inserts the ipip module
+ 		// into the kernel.
+ 		Eventually(func() error {","In the old code here there was no Source Selector, but CreateDefaultProfile will specify a Source Selector of `""""`. Is that equivalent?","This is the only real change to this test, the rest of the changes are pur"
+5116,"@@ -8,10 +8,12 @@ module RSpec
+         # Temporarily support old and new APIs while we transition the other
+         # rspec libs to use a hash for the 2nd arg and no version arg
+         data = Hash === replacement_or_hash ? replacement_or_hash : { :replacement => replacement_or_hash }
++        call_site = caller.find { |line| line !~ %r{/lib/rspec/(core|mocks|expectations|matchers|rails)/} }
++
+         RSpec.configuration.reporter.deprecation(
+           {
+             :deprecated => deprecated,
+-            :call_site => caller(0)[2]
++            :call_site => call_site
+           }.merge(data)
+         )
+       end",We should pick this across for all our deprecation specs,Use the new Ruby 1.9 hash syntax.
+5117,"@@ -45,8 +45,8 @@ func init() {
+ }
+
+ var (
+-	kindBinary      = flag.String(""kindBinary"", ""kind"", ""path to the kind binary"")
+-	managerImageTar = flag.String(""managerImageTar"", """", ""a script to load the manager Docker image into Docker"")
++	kindBinary    = flag.String(""kindBinary"", ""kind"", ""path to the kind binary"")
++	kubectlBinary = flag.String(""kubectlBinary"", ""kubectl"", ""path to the kubectl binary"")
+ )
+
+ // Cluster represents the running state of a KIND cluster.","Longer term, I think it could be valuable to move this to cluster-api, and then other repos could take advantage of this as well.",Is there a reason to have a separ
+5118,"@@ -1416,7 +1416,7 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
+ 								if testOpts.connTimeEnabled {
+ 									Skip(""FIXME externalClient also does conntime balancing"")
+ 								}
+-
++								externalClient.EnsureBinary(""test-connection"")
+ 								cc.ExpectSome(externalClient, TargetIP(felixes[1].IP), npPort)
+ 								cc.CheckConnectivity()
+ 							})",Is this a related change?,Why is this needed?
+5119,"@@ -400,6 +400,12 @@ func (a *Actuator) Update(ctx context.Context, cluster *clusterv1.Cluster, machi
+ 		return errors.Errorf(""failed to ensure tags: %+v"", err)
+ 	}
+
++	scope.MachineStatus.InstanceState = &instanceDescription.State
++
++	if err := a.reconcileLBAttachment(scope, machine, instanceDescription); err != nil {
++		return errors.Errorf(""failed to reconcile load balancer attachment: %+v"", err)
++	}
++
+ 	return nil
+ }
+ ","Given that this is repeated, can we do it outside here and the Create call, what do you think about moving it outside?",I think this should happen in `en
+5120,"@@ -44,6 +44,10 @@ function UndoRedo(instance) {
+       return;
+     }
+
++    arrayEach(changes, (change) => {
++      change[1] = instance.propToCol(change[1]);
++    });
++
+     const selected = changesLen > 1 ? this.getSelected() : [[changes[0][0], changes[0][1]]];
+
+     plugin.done(new UndoRedo.ChangeAction(changes, selected));",Changing `prop`=>`col` by reference?   I think you can prepare map `prop`=>`col` in L51.,"You don't need to pass `changes` as an argument to `propToCol`, since it's only used in one place."
+5121,"@@ -106,6 +106,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --grpc             Generate GRPC interfaces for the specified languages\n""
+     ""  --schema           Serialize schemas instead of JSON (use with -b)\n""
+     ""  --bfbs-comments    Add doc comments to the binary schema files.\n""
++    ""  --bfbs-builtin-attrs  Add builtin attributes to the binary schema files.\n""
+     ""  --conform FILE     Specify a schema the following schemas should be\n""
+     ""                     an evolution of. Gives errors if not.\n""
+     ""  --conform-includes Include path for the schema given with --conform\n""","I hate to ask, but can we make this flag shorter so it lines up? :(",Consider using `--bfbs-builtin-attrs` instead of `--bfbs-builtin-attrs` for clarity.
+5122,"@@ -19,9 +19,9 @@ import (
+ 	appsv1 ""k8s.io/api/apps/v1""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	apiextv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+-	""k8s.io/apimachinery/pkg/api/errors""
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/apimachinery/pkg/apis/meta/v1/unstructured""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/types""
+ 	""k8s.io/client-go/discovery""","Note to reviewers: latent, dedup import",@deads2k @mfojtik why is this change needed?
+5123,"@@ -20,3 +20,18 @@ package agent
+ func (i *Initializer) setupExternalConnectivity() error {
+ 	return nil
+ }
++
++// prepareHostNetwork returns immediately on Linux.
++func (i *Initializer) prepareHostNetwork() error {
++	return nil
++}
++
++// prepareOVSBridge returns immediately on Linux.
++func (i *Initializer) prepareOVSBridge() error {
++	return nil
++}
++
++// initHostNetworkFlows returns immediately on Linux.
++func (i *Initializer) initHostNetworkFlows() error {
++	return nil
++}",Seems this func is no more needed after your refactoring.,nit: why empty line?
+5124,"@@ -67,6 +67,7 @@ public class MemoryUsage {
+             Tuple.of(""^java\\."", ""Java mutable @ ""),
+             Tuple.of(""^fj\\."", ""Functional Java persistent @ ""),
+             Tuple.of(""^org\\.pcollections"", ""PCollections persistent @ ""),
++            Tuple.of(""^io\\.usethesource"", ""Steindorfer persistent @ ""),
+             Tuple.of(""^org\\.eclipse\\.collections"", ""Eclipse Collections persistent @ ""),
+             Tuple.of(""^clojure\\."", ""Clojure persistent @ ""),
+             Tuple.of(""^scalaz\\.Heap"", ""Scalaz persistent @ ""),",already added (see several rows below),The fact that there is no `io` in the name is an unfortunate bit of a name. `io.usethesource` is more descriptive.
+5125,"@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti
+ 	epType := tc.EpTypeHost
+ 	if ifaceName == ""tunl0"" {
+ 		epType = tc.EpTypeTunnel
++	} else if ifaceName == ""wireguard.cali"" {
++		epType = tc.EpTypeWireguard
+ 	}
+ 	ap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)
+ 	ap.HostIP = m.hostIP",nit: a switch perhaps?,epType = tc.EpTypeWireguard
+5126,"@@ -170,7 +170,7 @@ func (c *workflowSizeChecker) failWorkflowSizeExceedsLimit() (bool, error) {
+ 			tag.WorkflowEventCount(historyCount))
+
+ 		attributes := &decisionpb.FailWorkflowExecutionDecisionAttributes{
+-			Failure: failure.NewServerFailure(common.FailureReasonSizeExceedsLimit, false),
++			Failure: failure.NewServerFailure(common.FailureReasonSizeExceedsLimit, true),
+ 		}
+
+ 		if _, err := c.mutableState.AddFailWorkflowEvent(c.completedID, enumspb.RETRY_STATUS_NON_RETRYABLE_FAILURE, attributes); err != nil {",Great you caught this. Super critical to not retry these errors.,Should we also set the reason to non-retryable error?
+5127,"@@ -77,7 +77,7 @@ enum CoreAdminOperation implements CoreAdminOp {
+     String coreName = params.required().get(CoreAdminParams.NAME);
+     Map<String, String> coreParams = buildCoreParams(params);
+     CoreContainer coreContainer = it.handler.coreContainer;
+-    Path instancePath = coreContainer.getCoreRootDirectory().resolve(coreName);
++    Path instancePath;
+
+     // TODO: Should we nuke setting odd instance paths?  They break core discovery, generally
+     String instanceDir = it.req.getParams().get(CoreAdminParams.INSTANCE_DIR);","Just a little change to make the var effectively final, which is clearer.",`getCoreRootDirectory().resolve(coreName)` -> `getCoreRootDirectory().resolve(coreName)`
+5128,"@@ -30,8 +30,8 @@ def flowdetails(state, flow: http.HTTPFlow):
+     if sc is not None:
+         text.append(urwid.Text([(""head"", ""Server Connection:"")]))
+         parts = [
+-            [""Address"", ""{}:{}"".format(sc.address[0], sc.address[1])],
+-            [""Resolved Address"", ""{}:{}"".format(sc.ip_address[0], sc.ip_address[1])],
++            [""Address"", ""{}"".format(human.format_address(sc.address))],
++            [""Resolved Address"", ""{}"".format(human.format_address(sc.ip_address))],
+         ]
+         if resp:
+             parts.append([""HTTP Version"", resp.http_version])","Using `""{}"".format(...)` is a bit beside the point...  ","I would've done `str(sc.address).format()` here instead of `format_address(sc.address)`, but this works too."
+5129,"@@ -149,8 +149,8 @@ class JsonFormatterTest(unittest.TestCase):
+     def test_logger_name(self):
+         JsonLogFormatter.init_from_settings({""project_name"": ""kintowe""})
+         f = JsonLogFormatter()
+-        record = logging.LogRecord(""app.log"", logging.DEBUG, """", 0, ""coucou"", (), None)
+-        result = f.format(record)
++        obj = logging.LogRecord(""app.log"", logging.DEBUG, """", 0, ""coucou"", (), None)
++        result = f.format(obj)
+         logged = json.loads(result)
+         self.assertEqual(logged[""Logger""], ""kintowe"")
+         self.assertEqual(logged[""Type""], ""app.log"")",I think these should remain as they are.,"I know this is test code, but can we change it to be ""app.log""?"
+5130,"@@ -14,6 +14,8 @@ module Beaker
+     WINDOWS_PACKAGES = ['curl']
+     SLES_PACKAGES = ['curl', 'ntp']
+     DEBIAN_PACKAGES = ['curl', 'ntpdate', 'lsb-release']
++    # Packages added at runtime
++    @@additional_pkgs = []
+     ETC_HOSTS_PATH = ""/etc/hosts""
+     ETC_HOSTS_PATH_SOLARIS = ""/etc/inet/hosts""
+     ROOT_KEYS_SCRIPT = ""https://raw.githubusercontent.com/puppetlabs/puppetlabs-sshkeys/master/templates/scripts/manage_root_authorized_keys""","Let's just call this PERF_PACKAGES and have them in the same format as WINDOWS/SLES/DEBIAN_PACKAGES constants - since it is only a single package and, as written, you'd have to update the code to add more package names anyway. Might as well be consistent with the rest of the code.",Is there a reason we don't just pull from `sys.pkgs`?
+5131,"@@ -224,6 +224,18 @@ String getTaskValueName(taskIndex_t TaskIndex, uint8_t TaskValueIndex) {
+   return ExtraTaskSettings.TaskDeviceValueNames[TaskValueIndex];
+ }
+
++/*********************************************************************************************
++ * get the taskPluginID with required checks, INVALID_PLUGIN_ID when invalid
++ ********************************************************************************************/
++pluginID_t getTaskDevicePluginID(taskIndex_t TaskIndex) {
++  if (validTaskIndex(TaskIndex)) {
++    const deviceIndex_t DeviceIndex = getDeviceIndex_from_TaskIndex(TaskIndex);
++
++    return (validDeviceIndex(DeviceIndex) ? Device[DeviceIndex].Number : INVALID_PLUGIN_ID);
++  }
++  return INVALID_PLUGIN_ID;
++}
++
+ /********************************************************************************************\
+    If RX and TX tied together, perform emergency reset to get the system out of boot loops
+  \*********************************************************************************************/",We don't have a `getPluginIDfromTaskIndex` function? I think it should be implemented in Globals/Plugins.h / .cpp,Does this need to be `INVALID_PLUGIN_ID`?
+5132,"@@ -910,8 +910,12 @@ public class QueryComponent extends SearchComponent
+         additionalAdded = addFL(additionalFL, ""score"", additionalAdded);
+       }
+     } else {
+-      // reset so that only unique key is requested in shard requests
+-      sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());
++      if (rb.req.getSearcher().enableLazyFieldLoading) {
++        // reset so that only unique key is requested in shard requests
++        sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());
++      } else {
++        sreq.params.set(CommonParams.FL, ""*"");
++      }
+       if (shardQueryIncludeScore) {
+         additionalAdded = addFL(additionalFL, ""score"", additionalAdded);
+       }","@shalinmangar If lazy field loading isn't enabled, I don't think this actually changes the behavior of `SolrIndexSearcher`, since it was previously ignoring the fields list anyway. What it _should_ do is allow certain distributed queries, like the ones in `DistribJoinFromCollectionTest`, to co-exist with `SolrIndexSearcher#doc()` respecting the `fields` set instead of just discarding it.",Can you explain this change? I think it's unrelated to this PR.
+5133,"@@ -5,7 +5,7 @@ package ddevapp
+ const DDevComposeTemplate = `version: '2'
+
+ services:
+-  {{ .plugin }}-{{.name }}-db:
++  db:
+     container_name: {{ .plugin }}-${DDEV_SITENAME}-db
+     image: $DDEV_DBIMAGE
+     volumes:",Should we be using version 3 now?,@rsimha this is the actual fix for the failing test.
+5134,"@@ -24,7 +24,11 @@ class PluginListFactory
+
+     public function __invoke(string $current_dir, ?string $config_file_path = null): PluginList
+     {
+-        $config_file = new ConfigFile($current_dir, $config_file_path);
++        try {
++            $config_file = new ConfigFile($current_dir, $config_file_path);
++        } catch (\RuntimeException $exception) {
++            $config_file = null;
++        }
+         $composer_lock = new ComposerLock($this->findLockFiles());
+
+         return new PluginList($config_file, $composer_lock);","Would be better to throw a more specific exception, but for now it will do.",$config_file = null; right?
+5135,"@@ -17,8 +17,6 @@ package org.hyperledger.besu.tests.acceptance.dsl.blockchain;
+ import static org.web3j.utils.Convert.Unit.ETHER;
+ import static org.web3j.utils.Convert.Unit.WEI;
+
+-import org.hyperledger.besu.ethereum.core.Wei;
+-
+ import java.math.BigDecimal;
+ import java.math.BigInteger;
+ ",We should not replace Wei with a type that is shared across multiple units. We need this as `Wei` for type and unit safety.,We can probably remove this import as well
+5136,"@@ -653,8 +653,7 @@ func drupalEnsureWritePerms(app *DdevApp) error {
+
+ 	for _, o := range makeWritable {
+ 		stat, err := os.Stat(o)
+-		// If the file doesn't exist, don't try to set the permissions.
+-		if os.IsNotExist(err) {
++		if err != nil {
+ 			continue
+ 		}
+ ","I'm pretty sure this should emit a util.Warning*(), since we're skipping by here and never hitting anything that will give them a warning about what's happened.","`os.IsNotExist` checks if the file does not exist, so we don't need this anymore."
+5137,"@@ -23,6 +23,12 @@ type aspParser struct {
+
+ // newAspParser creates and returns a new asp.Parser.
+ func newAspParser(state *core.BuildState) *asp.Parser {
++	p := GetParserWithBuiltins(state)
++	return p
++}
++
++// GetParserWithBuiltins returns a asp.Parser object with all the builtins loaded
++func GetParserWithBuiltins(state *core.BuildState) *asp.Parser {
+ 	p := asp.NewParser(state)
+ 	log.Debug(""Loading built-in build rules..."")
+ 	dir, _ := rules.AssetDir("""")",This function isn't useful? it's just a clone of GetParserWithBuiltins?,Do we still need this function? Looks like it is only used once.
+5138,"@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
+
+     useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    isCpuCircuitBreakerEnabled = getBool(""circuitBreaker/isCpuCircuitBreakerEnabled"", false);
++    isMemoryCircuitBreakerEnabled = getBool(""circuitBreaker/isMemoryCircuitBreakerEnabled"", false);
+     memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 95);
+
+-    validateMemoryBreakerThreshold();
++    cpuCircuitBreakerThreshold = getInt(""circuitBreaker/cpuCircuitBreakerThreshold"", 95);
++
++    validateCircuitBreakerThresholds();
+
+     filterCacheConfig = CacheConfig.getConfig(this, ""query/filterCache"");
+     queryResultCacheConfig = CacheConfig.getConfig(this, ""query/queryResultCache"");","I'm not sure if the boolean flags should always contain `is`, also I generally hate too long names... ;) we already know this is a section for circuit breakers, so the name doesn't have to repeat all of it. How about `cpuBreakerEnabled`, `memoryBreakerEnabled` etc?","This should be `getBool(""circuitBreaker/isMemoryCircuitBreakerEnabled"")`"
+5139,"@@ -42,4 +42,13 @@ public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+    * @return this for method chaining
+    */
+   RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile> filesToAdd);
++
++  /**
++   * Add a rewrite that replaces one set of deletes with another that contains the same deleted rows.
++   *
++   * @param deletesToDelete files that will be replaced, cannot be null or empty.
++   * @param deletesToAdd files that will be added, cannot be null or empty.
++   * @return this for method chaining
++   */
++  RewriteFiles rewriteDeletes(Set<DeleteFile> deletesToDelete, Set<DeleteFile> deletesToAdd);
+ }","Before we start the replacing equality deletes with position deletes, I think we need to refactor the RewriteFiles API to adjust more cases: 1. Rewrite data files and remove all the delete rows. The files to delete will be a set of data files and a set of delete files, and the files to add will be a set of data files. 2. Replace equality deletes with position deletes, the files to delete will be a set of equality delete files (we will need to ensure that all delete files are equality delete files ? ) , the files to add will be a set of position delete files. 3. Merging small delete files into a bigger delete files. The files to delete will be a set of equality/position delete files, the files to add will be a set of equality/position delete files.",Please annotate `DeletesToDelete` and `deleteToAdd` with `@Nullable`.
+5140,"@@ -9,10 +9,16 @@ module Blacklight::BlacklightHelperBehavior
+   ##
+   # Get the name of this application from an i18n string
+   # key: blacklight.application_name
++  # Try first in the current locale, then the default locale
+   #
+   # @return [String] the application name
+   def application_name
+-    t('blacklight.application_name')
++    # It's important that we don't use ActionView::Helpers::CacheHelper#cache here
++    # because it returns nil.
++    Rails.cache.fetch 'blacklight/application_name' do
++      t('blacklight.application_name',
++        default: t('blacklight.application_name', locale: I18n.default_locale))
++    end
+   end
+
+   ##",Layout/TrailingWhitespace: Trailing whitespace detected.,"I'm not sure if this is a good idea at this point. It seems like a bad idea to me that `application_name` is either `nil` (no locale) or `t('blacklight.application_name', default: t('blacklight.default_locale', locale: I18n.default_locale))` (a few lines below)."
+5141,"@@ -80,8 +80,12 @@ public class LibraryManager {
+         List<ShortcutCategoryDTO> shortcuts = new ArrayList<>();
+         for (Map.Entry<String, List<ShortcutDTO>> entry : categoryMap.entrySet()) {
+             entry.getValue().sort(ShortcutDTO.nameComparator());
+-            ShortcutCategoryDTO category = new ShortcutCategoryDTO.Builder().withId(entry.getKey())
+-                    .withName(entry.getKey()).withShortcuts(entry.getValue()).build();
++            ShortcutCategoryDTO category = new ShortcutCategoryDTO.Builder()
++                    .withId(entry.getKey())
++                    .withName(entry.getKey())
++                    .withShortcuts(entry.getValue())
++                    .withIcon(entry.getValue().get(0).getCategoryIcon()) // choose one category icon
++                    .build();
+             shortcuts.add(tr(category));
+         }
+ ",Is it possible that the shortcuts list is empty?,"please use a constant, this will make it easier to change in the future"
+5142,"@@ -692,6 +692,10 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
+ 		p.V(""start backup on %v"", targets)
+ 	}
+ 	_, id, err := arch.Snapshot(gopts.ctx, targets, snapshotOpts)
++	if errors.Cause(err) == context.Canceled {
++		return errors.Fatal(""canceled"")
++	}
++
+ 	if err != nil {
+ 		return errors.Fatalf(""unable to save snapshot: %v"", err)
+ 	}",This just changes the error message from `unable to save snapshot: [...] context canceled` to `canceled`.,Should we check the return code here? Or is it ok to just return a fatal error here without doing anything else?
+5143,"@@ -141,7 +141,9 @@ public abstract class AbstractRestInvocation {
+     if (response.getHeaders().getHeaderMap() != null) {
+       for (Entry<String, List<Object>> entry : response.getHeaders().getHeaderMap().entrySet()) {
+         for (Object value : entry.getValue()) {
+-          responseEx.addHeader(entry.getKey(), String.valueOf(value));
++          if (!entry.getKey().equalsIgnoreCase(HttpHeaders.CONTENT_LENGTH)) {
++            responseEx.addHeader(entry.getKey(), String.valueOf(value));
++          }
+         }
+       }
+     }",maybe it's better to remove HttpHeaders.CONTENT_LENGTH after the loop,`if (entry.getKey().equals(HttpHeaders.CONTENT_LENGTH)) {`
+5144,"@@ -679,6 +679,12 @@ public interface List<T> extends LinearSeq<T>, Stack<T> {
+
+     @Override
+     default List<T> dropRight(int n) {
++        if (n <= 0) {
++            return this;
++        }
++        if (n >= length()) {
++            return empty();
++        }
+         return reverse().drop(n).reverse();
+     }
+ ",Very cool. We are now collecting the fruits after your length implementation!,How about `return n == 0 ? empty() : this`?
+5145,"@@ -0,0 +1,8 @@
++rules:
++  - name: all pubs are in whitelist
++    project: '*'
++    network: '*'
++    is_external_network: True
++    whitelist:
++      - xpn-master:xpn-network
++      - content-insights:default","Is this the same copy of the rules file from above? If so, can just use the copy from above, and this can be dropped.",can we change `xpn-master` to `xpn-network`
+5146,"@@ -264,6 +264,13 @@ func (acsSession *session) startACSSession(client wsclient.ClientServer, timer t
+
+ 	client.AddRequestHandler(refreshCredsHandler.handlerFunc())
+
++	// Add handler to ack ENI attach message
++	eniAttachHandler := newAttachENIHandler(acsSession.ctx, cfg.Cluster, acsSession.containerInstanceARN, client, acsSession.taskEngine, acsSession.stateManager)
++	eniAttachHandler.start()
++	defer eniAttachHandler.stop()
++
++	client.AddRequestHandler(eniAttachHandler.handlerFunc())
++
+ 	// Add request handler for handling payload messages from ACS
+ 	payloadHandler := newPayloadRequestHandler(
+ 		acsSession.ctx,",Please break this into multiple lines.,It seems like this would be better off as a
+5147,"@@ -120,7 +120,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+                 {
+                     scope.Span.SetHeaderTags<IHeadersCollection>(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTags, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
+                 }
+-
++                HttpContextHelpers.AddHeaderTagsFromHttpResponse(httpContext, scope);
+                 scope.Span.SetHttpStatusCode(responseMessage.DuckCast<HttpResponseMessageStruct>().StatusCode, isServer: true);
+                 scope.Dispose();
+             }",Shouldn't this new line replace the few lines above?,Do we want to do this before setting `HttpC
+5148,"@@ -2,9 +2,9 @@ package options
+
+ import (
+ 	""github.com/influxdata/flux""
+-	""github.com/influxdata/flux/functions/transformations""
++	""github.com/influxdata/flux/stdlib/universe""
+ )
+
+ func init() {
+-	flux.RegisterBuiltInOption(""now"", transformations.SystemTime())
++	flux.RegisterBuiltInOption(""now"", universe.SystemTime())
+ }",Perhaps this belongs in universe?,Can we rename the file to `influx_universe.go`?
+5149,"@@ -25,8 +25,11 @@ std::chrono::duration<double, std::milli> hist_time;
+ std::chrono::duration<double, std::milli> find_split_time;
+ std::chrono::duration<double, std::milli> split_time;
+ std::chrono::duration<double, std::milli> ordered_bin_time;
++std::chrono::duration<double, std::milli> refit_leaves_time;
+ #endif  // TIMETAG
+
++double EPS = 1e-12;
++
+ SerialTreeLearner::SerialTreeLearner(const Config* config)
+   :config_(config) {
+   random_ = Random(config_->feature_fraction_seed);",there is a `kEpsilon` you can use directly.,In some places you use EPS and in some other pl
+5150,"@@ -17,9 +17,10 @@ limitations under the License.
+ package ec2
+
+ import (
+-	""sigs.k8s.io/cluster-api/util/conditions""
+ 	""strings""
+
++	""sigs.k8s.io/cluster-api/util/conditions""
++
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/awserrors""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/wait""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/record""","This should be grouped with the below imports, and the two separate groups of imports below should likely also be grouped together",Please don't remove this line
+5151,"@@ -888,11 +888,11 @@ void cvdescriptorset::DescriptorSet::PerformWriteUpdate(const VkWriteDescriptorS
+ }
+ // Validate Copy update
+ bool cvdescriptorset::DescriptorSet::ValidateCopyUpdate(const debug_report_data *report_data, const VkCopyDescriptorSet *update,
+-                                                        const DescriptorSet *src_set, std::string *error_code,
++                                                        const DescriptorSet *src_set, std::string &error_code,
+                                                         std::string *error_msg) {
+     // Verify dst layout still valid
+     if (p_layout_->IsDestroyed()) {
+-        *error_code = ""VUID-VkCopyDescriptorSet-dstSet-parameter"";
++        error_code = ""VUID-VkCopyDescriptorSet-dstSet-parameter"";
+         string_sprintf(error_msg,
+                        ""Cannot call vkUpdateDescriptorSets() to perform copy update on descriptor set dstSet 0x%"" PRIxLEAST64
+                        "" created with destroyed VkDescriptorSetLayout 0x%"" PRIxLEAST64,","It looks like this error_code field is used to return a string to the caller, not just a const input string to be consumed as in the rest of this PR? If so, my personal preference would be to leave it as a std::string* instead of a reference; I don't know offhand what the VL coding style dictates.",Please don't make unnecessary changes like this
+5152,"@@ -66,6 +66,11 @@ std::string MetaUtils::partVal(const std::vector<nebula::cpp2::HostAddr>& hosts)
+     return val;
+ }
+
++std::string MetaUtils::partPrefix() {
++    static const std::string prefix = kPartsTable;
++    return prefix;
++}
++
+ std::string MetaUtils::partPrefix(GraphSpaceID spaceId) {
+     std::string prefix;
+     static constexpr size_t tableLen = ::strlen(kPartsTable);","If return by value, then why bother to make it `static`?",Is this needed? It looks like it can be used directly.
+5153,"@@ -369,8 +369,11 @@ def nop():
+
+ @cmdutils.register()
+ @cmdutils.argument('win_id', win_id=True)
+-def version(win_id):
++def version(win_id, paste=False):
+     """"""Show version information.""""""
+     tabbed_browser = objreg.get('tabbed-browser', scope='window',
+                                 window=win_id)
+     tabbed_browser.openurl(QUrl('qute://version'), newtab=True)
++
++    if paste:
++        utils.pastebin_version()","You'll need to add docs for the argument, see e.g. the `debug_log_filter` docstring above.","Since `past` doesn't have its own `version()` method, "
+5154,"@@ -30,6 +30,7 @@ import (
+ 	""go.opentelemetry.io/otel/codes""
+ 	""go.opentelemetry.io/otel/sdk/instrumentation""
+ 	""go.opentelemetry.io/otel/sdk/resource""
++	sdktrace ""go.opentelemetry.io/otel/sdk/trace""
+ 	tracesdk ""go.opentelemetry.io/otel/sdk/trace""
+ 	""go.opentelemetry.io/otel/semconv""
+ 	""go.opentelemetry.io/otel/trace""","`sdktrace` or `tracesdk`, pick one.",Nit: `sdktrace` for consistency with the rest of the A
+5155,"@@ -200,11 +200,7 @@ trait ContentMagicTrait
+             }
+         }
+
+-        return [
+-            'filename' => '',
+-            'alt' => '',
+-            'path' => '',
+-        ];
++        return [];
+     }
+
+     /**",can we return null instead?,This file has nothing to do with the PR.
+5156,"@@ -179,6 +179,12 @@ void exit_event(void)
+     bool success = dr_raw_tls_cfree(tls_offs, NUM_TLS_SLOTS);
+     ASSERT(success);
+     ASSERT(num_lea > 0);
++#ifdef UNIX
++    /* i#2346: delay client threads termination on Windows. */
++    dr_fprintf(STDERR, ""process is exiting\n"");
++    dr_event_signal(child_continue);
++    dr_event_wait(child_dead);
++#endif
+     /* DR should have terminated the client thread for us */
+     dr_event_destroy(child_alive);
+     dr_event_destroy(child_continue);","You mean XXX and ""we should"" or ""NYI"" or sthg. Maybe put it on the ifdef line.",This wont work on non-Windows systems because the `dr_event_signal()` calls `dr_event_destroy()`. You need to use `dr_event_wait()` instead.
+5157,"@@ -25,3 +25,17 @@ func (w literalLoggable) GetValue(key string) string { return w.strings[key] }
+ func (w literalLoggable) GetValueAsInt64Slice(key string) []int64 { return w.int64s[key] }
+
+ func (w literalLoggable) ReadSerialPortLogs() []string { return w.serials }
++
++// SingleImageImportLoggable returns a Loggable that is pre-initialized with the metadata
++// fields that are relevant when importing a single image file.
++func SingleImageImportLoggable(fileFormat string, sourceSize, resultSize int64, serials []string) Loggable {
++	loggable := literalLoggable{
++		strings: map[string]string{importFileFormat: fileFormat},
++		int64s: map[string][]int64{
++			sourceSizeGb: {sourceSize},
++			targetSizeGb: {resultSize},
++		},
++		serials: serials,
++	}
++	return loggable
++}",minor: can be in-lined in return,This is the only place where `SingleImageImportLoggable` is used. I'd just inline it in the place where it is used.
+5158,"@@ -14,7 +14,7 @@ module RSpec::Core::Formatters
+         it ""prints a message if provided, ignoring other data"" do
+           formatter.deprecation(:message => ""this message"", :deprecated => ""x"", :replacement => ""y"", :call_site => ""z"")
+           deprecation_stream.rewind
+-          expect(deprecation_stream.read).to eq ""this message""
++          expect(deprecation_stream.read).to eq ""this message\n""
+         end
+
+         it ""includes the method"" do","why the additional ""\n""?",Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+5159,"@@ -183,7 +183,7 @@ func (s *streamTable) Do(f func(flux.ColReader) error) error {
+ 	if err := f(s.first); err != nil {
+ 		s.first.Release()
+ 		s.first = nil
+-		return nil
++		return err
+ 	}
+ 	s.first.Release()
+ 	s.first = nil","This seems to be a big omission. If the first buffer reports an error, stream seems to just discard it.",Would be good to log the error here as well.
+5160,"@@ -180,9 +180,7 @@ func MakeFull(log logging.Logger, rootDir string, cfg config.Local, phonebookDir
+ 		return nil, err
+ 	}
+
+-	blockListeners := []ledger.BlockListener{
+-		node,
+-	}
++	blockListeners := []ledger.BlockListener{}
+
+ 	if node.config.EnableTopAccountsReporting {
+ 		blockListeners = append(blockListeners, &accountListener)",Maybe move this one down too?,"This was a bug, preventing listener from being created if `EnableTopAccountsReporting` is false"
+5161,"@@ -1,12 +1,12 @@
+-using Datadog.Trace.Logging;
++using Datadog.Trace.Logging;
+
+ namespace Datadog.Trace
+ {
+     internal class AsyncLocalScopeManager
+     {
+-        private static ILog _log = LogProvider.For<AsyncLocalScopeManager>();
++        private static readonly ILog _log = LogProvider.For<AsyncLocalScopeManager>();
+
+-        private AsyncLocalCompat<Scope> _currentSpan = new AsyncLocalCompat<Scope>();
++        private readonly AsyncLocalCompat<Scope> _currentSpan = new AsyncLocalCompat<Scope>();
+
+         public Scope Active => _currentSpan.Get();
+ ","We do this in lots of places I'm starting to notice...typically you'd avoid taking concrete dependencies, but we also avoid package dependencies as well which makes sense (i.e. not using an IoC, etc.). Any reason we don't implement some form of poor-man's DI and/or a simple factory instead of new-ing things up everywhere. This may be a simple example (as I'm guessing this is likely the only place this is ever or ever will be used), but separating them doesn't take any more time/effort either really.",Why are we making this change?
+5162,"@@ -77,8 +77,13 @@ func Errf(format string, a ...interface{}) DError {
+ }
+
+ // wrapErrf returns a DError by keeping errors type and replacing original error message.
+-func wrapErrf(e DError, format string, a ...interface{}) DError {
+-	return &dErrImpl{errs: []error{fmt.Errorf(format, a...)}, errsType: e.errorsType(), anonymizedErrs: []string{format}}
++func wrapErrf(e DError, formatPrefix string, a ...interface{}) DError {
++	f := formatPrefix + strings.Join(e.AnonymizedErrs(), ""; "")
++	return &dErrImpl{
++		errs:           []error{fmt.Errorf(fmt.Sprintf(formatPrefix, a...) + e.Error())},
++		errsType:       e.errorsType(),
++		anonymizedErrs: []string{f},
++	}
+ }
+
+ // newErr returns a DError. newErr is used to wrap another error as a DError.",What if formatPrefix doesn't include a space? Will the resulting error have e.Error() stuck at the end without any space?,"I think we can remove the `anonymizedErrs` field from `wrapErrf`, since it's not used anywhere "
+5163,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package pushsync provides the pushsync protocol
++// implementation.
+ package pushsync
+
+ import (",that doesn't say a lot to me. Can you please be more specific on the function of pushsync?,What do you think about making it clear that it's a `Sync` and not a `Sync`?
+5164,"@@ -1602,6 +1602,15 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+                         }
+                     }
+                 }
++                if (subpass_desc->pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) {
++                    if (pPipeline->graphicsPipelineCI.pDepthStencilState->depthWriteEnable == VK_TRUE) {
++                        skip |= LogError(
++                            device, ""VUID-VkGraphicsPipelineCreateInfo-subpass-04890"",
++                            ""vkCreateGraphicsPipelines(): pCreateInfo[%"" PRIu32
++                            ""]: subpass uses read-only depth aspect layout, but pDepthStencilState->depthWriteEnable is VK_TRUE."",
++                            pipelineIndex);
++                    }
++                }
+             }
+
+             // If subpass uses color attachments, pColorBlendState must be valid pointer",> subpass uses a depth/stencil attachment in renderPass with a read-only layout for the depth aspect Assume - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL count as well seems there is a `NormalizeDepthImageLayout` for this,Should we also check for the read-only here?
+5165,"@@ -49,14 +49,14 @@ export function registerDefaults( widgetsAPI ) {
+ 	widgetsAPI.registerWidgetArea( AREA_DASHBOARD_ALL_TRAFFIC, {
+ 		title: __( 'All Traffic', 'google-site-kit' ),
+ 		subtitle: __( 'How people found your site.', 'google-site-kit' ),
+-		style: WIDGET_AREA_STYLES.COMPOSITE,
++		style: WIDGET_AREA_STYLES.BOXES,
+ 		priority: 1,
+ 	}, CONTEXT_DASHBOARD );
+
+ 	widgetsAPI.registerWidgetArea( AREA_DASHBOARD_SEARCH_FUNNEL, {
+ 		title: __( 'Search Funnel', 'google-site-kit' ),
+ 		subtitle: __( 'How your site appeared in Search results and how many visitors you got from Search.', 'google-site-kit' ),
+-		style: WIDGET_AREA_STYLES.COMPOSITE,
++		style: WIDGET_AREA_STYLES.BOXES,
+ 		priority: 2,
+ 	}, CONTEXT_DASHBOARD );
+ ","This shouldn't be altered, you probably meant to update `AREA_PAGE_DASHBOARD_ALL_TRAFFIC` further below :)","Should we also update the `subtitle`, `subti"
+5166,"@@ -882,7 +882,7 @@ class CmdDockerClient(ContainerClient):
+         if mount_volumes:
+             cmd += [
+                 volume
+-                for host_path, docker_path in mount_volumes
++                for host_path, docker_path in dict(mount_volumes).items()
+                 for volume in [""-v"", f""{host_path}:{docker_path}""]
+             ]
+         if interactive:",what does this change do exactly?,Why are we converting a `dict` to a `list`?
+5167,"@@ -48,7 +48,8 @@ type networkImpl struct {
+ 	proposalCh chan agreement.Message
+ 	bundleCh   chan agreement.Message
+
+-	net network.GossipNode
++	net           network.GossipNode
++	backgroundCtx context.Context
+ }
+
+ // WrapNetwork adapts a network.GossipNode into an agreement.Network.",What's the purpose of this `backgroundCtx` field?,What is the background context for this one?
+5168,"@@ -42,7 +42,11 @@ import (
+ // Trie cache generation limit after which to evict trie nodes from memory.
+ var MaxTrieCacheGen = uint32(1024 * 1024)
+
+-const IncarnationLength = 8
++const (
++	IncarnationLength        = 8
++	FirstContractIncarnation = 1
++	AccountIncarnation       = 0
++)
+
+ type StateReader interface {
+ 	ReadAccountData(address common.Address) (*accounts.Account, error)",non contract incarnation,can we have a more descriptive name? `FirstContractIncarnation`?
+5169,"@@ -108,10 +108,7 @@ class ErrorHandler(object):
+                         message = value[""value""]
+                         if not isinstance(message, basestring):
+                             value = message
+-                            try:
+-                                message = message['message']
+-                            except TypeError:
+-                                message = None
++                            message = message.get('message', None)
+                     else:
+                         message = value.get('message', None)
+                 except ValueError:",I would recommend to leave out `None` because None is already the default.,"`None` is already the default value, so there is no need to spec"
+5170,"@@ -90,11 +90,11 @@ func (h *Handler) handleNewStream(s net.Stream) {
+
+ 	switch err := h.processHelloMessage(from, &hello); err {
+ 	case ErrBadGenesis:
+-		log.Warningf(""genesis cid: %s does not match: %s, disconnecting from peer: %s"", &hello.GenesisHash, h.genesis, from)
++		log.Debugf(""genesis cid: %s does not match: %s, disconnecting from peer: %s"", &hello.GenesisHash, h.genesis, from)
+ 		s.Conn().Close() // nolint: errcheck
+ 		return
+ 	case ErrWrongVersion:
+-		log.Warningf(""code not at same version: peer has version %s, daemon has version %s, disconnecting from peer: %s"", hello.CommitSha, h.commitSha, from)
++		log.Debugf(""code not at same version: peer has version %s, daemon has version %s, disconnecting from peer: %s"", hello.CommitSha, h.commitSha, from)
+ 		s.Conn().Close() // nolint: errcheck
+ 		return
+ 	case nil: // ok, noop","Should the ""bad hello message"" case above also disconnect?","I think we should leave this warning, it looks more professional"
+5171,"@@ -18,6 +18,9 @@ public abstract class InsulinOrefBasePlugin implements PluginBase, InsulinInterf
+
+     public static double MIN_DIA = 5;
+
++    protected static boolean fragmentEnabled = false;
++    protected static boolean fragmentVisible = false;
++
+     long lastWarned = 0;
+
+     @Override",Shouldn't this be in the child and not in the base plugin? Wouldn't having it here enable all derived plugins at once?,These should be set to `true` by default to avoid changing exist
+5172,"@@ -226,6 +226,11 @@ FILTERING
+           (options[:full_description] ||= []) << Regexp.compile(Regexp.escape(o))
+         end
+
++        parser.on('-E', '--example-matches STRING', ""Run examples whose full nested names match REGEX (may be"",
++                  ""  used more than once)"") do |o|
++          (options[:full_description] ||= []) << Regexp.compile(o)
++        end
++
+         parser.on('-t', '--tag TAG[:VALUE]',
+                   'Run examples with the specified tag, or exclude examples',
+                   'by adding ~ before the tag.',",Should probably say REGEX or PATTERN rather than string.,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+5173,"@@ -179,14 +179,14 @@ func TestHandler(t *testing.T) {
+ 			name:     ""an event with a very large payload"",
+ 			method:   ""POST"",
+ 			path:     ""/ns1/broker1"",
+-			event:    createTestEventWithPayloadSize(""test-event"", 110000000),
++			event:    createTestEventWithPayloadSize(""test-event"", 10000001), // 10Mb + extra byte
+ 			wantCode: nethttp.StatusRequestEntityTooLarge,
+ 		},
+ 		{
+ 			name:          ""malicious requests or requests with unknown Content-Length and a very large payload"",
+ 			method:        ""POST"",
+ 			path:          ""/ns1/broker1"",
+-			event:         createTestEventWithPayloadSize(""test-event"", 110000000),
++			event:         createTestEventWithPayloadSize(""test-event"", 10000001), // 10Mb + extra byte
+ 			contentLength: ptr.Int64(-1),
+ 			wantCode:      nethttp.StatusRequestEntityTooLarge,
+ 		},","I felt we don't need to set it that strict, like if somehow pubsub happens to allow extra 20 bytes for metadata, this test won't work. We would suggest to use 11MB instead.",can you explain why this needs to change?
+5174,"@@ -34,7 +34,7 @@ class AutocompleteTypeConfigurator implements TypeConfiguratorInterface
+         }
+
+         // by default, allow to autocomplete multiple values for OneToMany and ManyToMany associations
+-        if (!isset($options['multiple']) && $metadata['associationType'] & ClassMetadata::TO_MANY) {
++        if (!isset($options['multiple']) && isset($metadata['associationType']) && $metadata['associationType'] & ClassMetadata::TO_MANY) {
+             $options['multiple'] = true;
+         }
+ ","In theory `isset($metadata['associationType'])` is `false` if the linked field is not an association field, isn't?",Shouldn't this be `isset($metadata['associationType'])`?
+5175,"@@ -84,7 +84,7 @@ Doorkeeper.configure do
+   #
+   # If not specified, Doorkeeper enables all the four grant flows.
+   #
+-  # grant_flows %w(authorization_code implicit password client_credentials)
++  grant_flows %w(authorization_code implicit password client_credentials)
+
+   # Under some circumstances you might want to have applications auto-approved,
+   # so that the user skips the authorization step.",@tute the only thing I needed to enable this like as `password` is not in default flow anymore I think.,Metrics/LineLength: Line is too long. [101/80]
+5176,"@@ -52,7 +52,8 @@ class IamPolicyTest(ForsetiTestCase):
+             'serviceAccount:abc@def.gserviceaccount.com',
+             'user:someone@somewhere.tld',
+             'allUsers',
+-            'user:anything'
++            'user:anything',
++            'allAuthenticatedUsers'
+         ]
+
+     # Test IamPolicyMember","nit: to be consistent with `self.members`, please move this up one line, so that it's closer to `allUsers`? You will need to update your test reference.",shouldn't we have a test for `allAuthenticatedUsers` as well?
+5177,"@@ -4,6 +4,7 @@ const config = require('./config')
+ const fs = require('fs-extra')
+
+ const runGClient = (args, options = {}) => {
++  if (options.verbose) args.push('--verbose')
+   options.cwd = options.cwd || config.rootDir
+   options = mergeWithDefault(options)
+   options.env.GCLIENT_FILE = config.gClientFile",we might as well just access `config.gClientVerbose` directly here. If any other options are passed to `gclientSync` or `gclientRunhooks` then the verbose option will be lost the way it's used now,does this work if `options.verbose` is false?
+5178,"@@ -353,6 +353,7 @@ return [
+     'log' => [
+         'menu_label' => 'Log settings',
+         'menu_description' => 'Specify which areas should use logging.',
++        'logging' => 'Logging',
+         'log_events' => 'Log system events',
+         'log_events_comment' => 'Browser requests that may require attention, such as 404 errors.',
+         'log_requests' => 'Log bad requests',",Change the key to `default_tab` instead and I'll merge this,Please update the `config/en-US.yml` as well.
+5179,"@@ -387,8 +387,11 @@ module OrgAdmin
+               end
+             end
+           end
+-        else
+-          # If no funder was selected retrieve the Org's templates
++        end
++
++        # If the no funder was specified OR the funder matches the org
++        if funder_id.blank? || funder_id == org_id
++          # Retrieve the Org's templates
+           templates << Template.organisationally_visible.valid.where(published: true, org_id: org_id, customization_of: nil).to_a
+         end
+         ",we still can end up passing a blank org_id to the scope method if for any reason the params is not present...,Rails/DynamicFindBy: Use find_by instead of dynamic find_by.
+5180,"@@ -236,7 +236,9 @@ public class SaxonXPathRuleQuery extends AbstractXPathRuleQuery {
+         */
+         if (value == null) {
+             return UntypedAtomicValue.ZERO_LENGTH_UNTYPED;
+-
++        } else if (value instanceof Enum) {
++            // enums use their toString
++            return new StringValue(value.toString());
+         } else if (value instanceof String) {
+             return new StringValue((String) value);
+         } else if (value instanceof Boolean) {","I think yes, this makes sense to expose this. +1",Is it possible to have a type for `value`? I think if it is `String` or `Enum` we should cast it to `String`
+5181,"@@ -33,7 +33,7 @@ metadata:
+       - name: StorageType
+         value: ""hostpath""
+       - name: BasePath
+-        value: ""/var/openebs/local""
++        value: {{env ""OPENEBS_IO_LOCALPV_HOSTPATH_DIR"" | default ""/var/openebs/local""}}
+ provisioner: openebs.io/local
+ volumeBindingMode: WaitForFirstConsumer
+ reclaimPolicy: Delete",let us put the sample yaml snippet i.e. maya api server deployment that makes use of this env & value,Does this mean that openebs will try to read the volume in local storage if it doesn't exist? Is this the de
+5182,"@@ -117,12 +117,12 @@ public class ITRabbitMQCollector {
+
+   /** Guards against errors that leak from storage, such as InvalidQueryException */
+   @Test
+-  public void skipsOnSpanConsumerException() throws Exception {
++  public void skipsOnSpanConsumerException() {
+     // TODO: reimplement
+   }
+
+   @Test
+-  public void messagesDistributedAcrossMultipleThreadsSuccessfully() throws Exception {
++  public void messagesDistributedAcrossMultipleThreadsSuccessfully() {
+     // TODO: reimplement
+   }
+ }",What changed to cause this?,"This TODO can be removed now, since it is not reimplementing anything"
+5183,"@@ -81,6 +81,8 @@ func waitForBalanceState(t *testing.T, processor *PromiseProcessor, expectedStat
+
+ type fakeStorage struct{}
+
+-func (fs fakeStorage) Store(issuer string, data interface{}) error  { return nil }
+-func (fs fakeStorage) Delete(issuer string, data interface{}) error { return nil }
+-func (fs fakeStorage) Close() error                                 { return nil }
++func (fs fakeStorage) Store(issuer string, data interface{}) error                         { return nil }
++func (fs fakeStorage) Delete(issuer string, data interface{}) error                        { return nil }
++func (fs fakeStorage) Close() error                                                        { return nil }
++func (fs fakeStorage) StoreSession(bucketName string, key string, value interface{}) error { return nil }
++func (fs fakeStorage) GetAll(issuer string, data interface{}) error                        { return nil }",Repeating big interface in many places shows smtg is wrong with design,"Some of these functions are stubbed out for unit testing, so they don't need to be exported."
+5184,"@@ -0,0 +1,15 @@
++class Accounts::ChartsController < AccountsController
++  include SetAccountByAccountId
++
++  before_action :redirect_if_disabled
++
++  # NOTE: Replaces accounts#commits_history
++  def commits_by_project
++    render json: Chart.new(@account).commits_by_project
++  end
++
++  # NOTE: Replaces accounts#language_experience
++  def commits_by_language
++    render json: Chart.new(@account).commits_by_language(params[:scope])
++  end
++end",Inheriting from `AccountsController` to get access to the `redirect_if_disabled` filter.,> Note: Replaces accounts#commits_by_language ...
+5185,"@@ -1,14 +1,15 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-# SPDX - License - Identifier: Apache - 2.0
++# SPDX-License-Identifier: Apache-2.0
++
++# Purpose
++# This code demonstrates how to copy an object from one Amazon Simple Storage Solution (Amazon S3) bucket to another.
+
+ # snippet-start:[s3.ruby.copy_object_between_buckets.rb]
+ require 'aws-sdk-s3'
+
+-# Copies an object from one Amazon S3 bucket to another.
+-#
+ # Prerequisites:
+ #
+-# - Two S3 buckets (a source bucket and a target bucket).
++# - Two Amazon S3 buckets (a source bucket and a target bucket).
+ # - An object in the source bucket to be copied.
+ #
+ # @param s3_client [Aws::S3::Client] An initialized Amazon S3 client.",Simple Storage **Service**,Trailing whitespace detected.
+5186,"@@ -0,0 +1 @@
++public class A { public int FUNC() { Class<?> cls = null; if(cls == null) return 0; else { B.FUNC3(cls); return 1;} } public void FUNC2(Class<?> arg) { return; }}class B {public static void FUNC3(Class<?> arg) { return; }}",Enter at the end of the file! :-D (and at the end of lines ;-) ),missing new line.
+5187,"@@ -0,0 +1,9 @@
++class RenameScheduledForCancellation < ActiveRecord::Migration
++  def change
++    rename_column(
++      :subscriptions,
++      :scheduled_for_cancellation_on,
++      :scheduled_for_deactivation_on,
++    )
++  end
++end",Put a comma after the last parameter of a multiline method call.,is `scheduled_for_cancellation_on` the same thing
+5188,"@@ -88,7 +88,17 @@ func removeYields(plan *PlanSpec) (*PlanSpec, error) {
+ 			}
+
+ 			newRoot := root.Predecessors()[0]
+-			newRoot.RemoveSuccessor(root)
++			newSucc := make([]PlanNode, 0, len(newRoot.Successors()))
++
++			for _, succ := range newRoot.Successors() {
++				newSucc = append(newSucc, succ)
++				if succ == root {
++					continue
++				}
++			}
++
++			newRoot.ClearSuccessors()
++			newRoot.AddSuccessors(newSucc...)
+ 			plan.Replace(root, newRoot)
+ 			plan.Results[name] = newRoot
+ 			continue",Don't you want to place this check before you add `succ` to `newSucc`?,"This looks like a bug, since the `newRoot.AddSuccessors` only adds 1 to the existing `succ` list."
+5189,"@@ -1,18 +1,6 @@
+ package com.fsck.k9.fragment;
+
+
+-import java.util.ArrayList;
+-import java.util.Collections;
+-import java.util.Comparator;
+-import java.util.EnumMap;
+-import java.util.HashMap;
+-import java.util.HashSet;
+-import java.util.List;
+-import java.util.Map;
+-import java.util.Map.Entry;
+-import java.util.Set;
+-import java.util.concurrent.Future;
+-
+ import android.app.Activity;
+ import android.content.BroadcastReceiver;
+ import android.content.Context;",Commit 676eeeab10884456a5f70ce708a8aa5116ecbaf7 contains a lot of unrelated code style changes. Please get rid of these.,Could you revert these changes so they don't clutter the review
+5190,"@@ -82,7 +82,10 @@ class BokehRenderer(Renderer):
+             if bokeh_version < '0.12.6':
+                 raise RuntimeError('Bokeh png export only supported by versions >=0.12.6.')
+             from bokeh.io import _get_screenshot_as_png
+-            img = _get_screenshot_as_png(plot.state)
++            if bokeh_version > '0.12.6':
++                img = _get_screenshot_as_png(plot.state, None)
++            else:
++                img = _get_screenshot_as_png(plot.state)
+             imgByteArr = BytesIO()
+             img.save(imgByteArr, format='PNG')
+             return imgByteArr.getvalue(), info","Well this sucks, I wish you'd mentioned you were using a private API, perhaps we could have made a public one with better guarantees before `0.12.6` was released.",I think this should be `< 0.12.6`
+5191,"@@ -69,17 +69,10 @@ func New(transport peer.Transport, opts ...ListOption) *List {
+ 			&pendingHeap{},
+ 			plOpts...,
+ 		),
+-		capacity: cfg.capacity,
+ 	}
+ }
+
+ // List is a PeerList which rotates which peers are to be selected in a circle
+ type List struct {
+ 	*peerlist.List
+-	capacity int
+-}
+-
+-// Capacity is the maximum number of peers the peer list will hold.
+-func (l *List) Capacity() int {
+-	return l.capacity
+ }",Consider instead moving this into an _test file so it's public but only usable in tests.,why remove this?
+5192,"@@ -146,10 +146,10 @@ func (s *ec2Ops) waitAttachmentStatus(
+ 	request := &ec2.DescribeVolumesInput{VolumeIds: []*string{&id}}
+ 	actual := """"
+ 	interval := 2 * time.Second
+-	fmt.Printf(""Waiting for state transition to %q"", desired)
++	logrus.Infof(""Waiting for state transition to %q"", desired)
+
+ 	var outVol *ec2.Volume
+-	for elapsed, runs := 0*time.Second, 0; actual != desired && elapsed < timeout; elapsed += interval {
++	for elapsed, runs := 0*time.Second, 0; actual != desired && elapsed < timeout; elapsed, runs = elapsed+interval, runs+1 {
+ 		awsVols, err := s.ec2.DescribeVolumes(request)
+ 		if err != nil {
+ 			return nil, err","Any reason why we want to remove this code ? It helps debugging AWS ebs attach issues. Ideally yes a library should have minimal logging, but there is no way we can track long running AWS attach calls.",This looks like it should be `Infof` not `Info`.
+5193,"@@ -87,9 +87,10 @@ func (fs *experimentStore) CreateExperiment(ctx context.Context, config *any.Any
+ 			INSERT INTO experiment_run (
+                 id,
+ 		        experiment_config_id,
+-		        execution_time,
++						execution_time,
++						scheduled_end_time,
+ 		        creation_time)
+-            VALUES ($1, $2, tstzrange($3, $4, '[]'), NOW())`
++            VALUES ($1, $2, tstzrange($3, $4, '[]'), $4, NOW())`
+
+ 	runId := id.NewID()
+ 	_, err = fs.db.ExecContext(ctx, runSql, runId, configID, startTime, endTime)",nit: indentation doesn't match (unfortunately i don't know of a way to automatically lint these sql statements with how we're using them currently),I think we should change `execution_time` to `sc
+5194,"@@ -231,6 +231,7 @@ module RSpec::Core
+       return if @setup
+
+       @setup_default.call
++      setup_profiler
+       @setup = true
+     end
+ ","Should we remove the other `setup_profiler` call site and just let this be the one call site for it, since, AFAIK, the other one is no longer necessary with this? Also, can we make `setup_profiler` private?",it seems like this should go into the `setup_pro
+5195,"@@ -151,7 +151,6 @@ func BuildEnvShowCmd() *cobra.Command {
+ 		GlobalOpts: NewGlobalOpts(),
+ 	}
+ 	cmd := &cobra.Command{
+-		Hidden: true, //TODO remove when ready for production!
+ 		Use:    ""show"",
+ 		Short:  ""Shows info about a deployed environment."",
+ 		Long:   ""Shows info about a deployed environment, including region, account ID, and services."",","Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?",Do we need to set this to hidden?
+5196,"@@ -1,18 +1,3 @@
+ // +build !linux !cgo !seccomp
+
+ package patchbpf
+-
+-import (
+-	""errors""
+-
+-	""github.com/opencontainers/runc/libcontainer/configs""
+-
+-	libseccomp ""github.com/seccomp/libseccomp-golang""
+-)
+-
+-func PatchAndLoad(config *configs.Seccomp, filter *libseccomp.ScmpFilter) error {
+-	if config != nil {
+-		return errors.New(""cannot patch and load seccomp filter without runc seccomp support"")
+-	}
+-	return nil
+-}",perhaps file can be removed altogether (trying to avoid an empty package for these build tags),Why was this removed? I don't see any usages of this anywhere.
+5197,"@@ -980,7 +980,7 @@ get_module_handle_64(const wchar_t *name)
+ {
+     /* Be careful: we can't directly de-ref any ptrs b/c they can be >4GB */
+     LDR_MODULE_64 mod;
+-    if (!get_ldr_module_64(name, NULL, &mod))
++    if (!get_ldr_module_64(name, 0, &mod))
+         return NULL;
+     return mod.BaseAddress;
+ }","NULL change, could you move that out too?",Why is this in a separate patch? Does it need to be in a separ
+5198,"@@ -25,6 +25,10 @@ func formatKV(in []string) string {
+ 	return columnize.Format(in, columnConf)
+ }
+
++func FormatList(in []string) string {
++	return formatList(in)
++}
++
+ // formatList takes a set of strings and formats them into properly
+ // aligned output, replacing any blank fields with a placeholder
+ // for awk-ability.",A brief explanation about this func is required.,Does this need a unit test?
+5199,"@@ -32,6 +32,11 @@ class MergedCellsCollection {
+     this.hot = plugin.hot;
+   }
+
++  static IS_OVERLAPPING_WARNING(newMergedCell) {
++    return `The merged cell declared at [${newMergedCell.row}, ${newMergedCell.col}] overlaps with the other ` +
++      'declared merged cell. The overlapping merged cell was not added to the table, please fix your setup.';
++  }
++
+   /**
+    * Get a merged cell from the container, based on the provided arguments. You can provide either the ""starting coordinates""
+    * of a merged cell, or any coordinates from the body of the merged cell.",Could you add description for below static function?,Typo: missing `l` in commit message.
+5200,"@@ -453,7 +453,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
+ 	blocksFetched := uint64(1) // we already got the first block in the previous step.
+ 	var blk *bookkeeping.Block
+ 	var client FetcherClient
+-	for attemptsCount := uint64(1); blocksFetched <= lookback; attemptsCount++ {
++	for attemptsCount := uint64(1); blocksFetched <= lookback; {
+ 		if err := cs.ctx.Err(); err != nil {
+ 			return cs.stopOrAbort()
+ 		}","Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount?",why not replace `blocksFetched` with `lookback`?
+5201,"@@ -21,7 +21,7 @@
+
+ """"""Installation script for Python nupic package.""""""
+
+-import os
++import OOOOOOOOOOOos
+ import pkg_resources
+ import sys
+ ",I don't think this will work.,The name `OOOOOOOos` isn't very descriptive. How
+5202,"@@ -0,0 +1,11 @@
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpParser
++    {
++        bool ParseRequestLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpRequestLineHandler;
++
++        bool ParseHeaders<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined, out int consumedBytes) where T : IHttpHeadersHandler;
++    }
++}",Since http2 is coming do we want to call this something more specific?,It seems weird to have this interface on this in
+5203,"@@ -11,8 +11,8 @@
+   </div>
+ </nav>
+
+-<%= content_tag :div, class: 'navbar-search navbar navbar-light bg-light', role: 'navigation', aria: { label: t('blacklight.search.header') } do %>
++<div class=""navbar-search navbar navbar-light bg-light"" role=""navigation"">
+   <div class=""<%= container_classes %>"">
+     <%= render_search_bar  %>
+   </div>
+-<% end %>
++</div>","I don't think we want to revert the accessibility issues the tool caught, do we?","Do we need the `role=""navigation""` here?"
+5204,"@@ -285,8 +285,11 @@ func (rt *RequestTracker) Accept() (conn net.Conn, err error) {
+ 		rt.hostRequests.pruneRequests(rateLimitingWindowStartTime)
+ 		originConnections := rt.hostRequests.countOriginConnections(trackerRequest.remoteHost, rateLimitingWindowStartTime)
+
++		remoteHostIsNonLocal := (!rt.config.DisableLocalhostConnectionRateLimit) || (!isLocalhost(trackerRequest.remoteHost))
++		connectionLimitEnabled := rt.config.ConnectionsRateLimitingWindowSeconds > 0 && rt.config.ConnectionsRateLimitingCount > 0
++
+ 		// check the number of connections
+-		if originConnections > rt.config.ConnectionsRateLimitingCount && rt.config.ConnectionsRateLimitingWindowSeconds > 0 && rt.config.ConnectionsRateLimitingCount > 0 {
++		if originConnections > rt.config.ConnectionsRateLimitingCount && connectionLimitEnabled && remoteHostIsNonLocal {
+ 			rt.hostRequestsMu.Unlock()
+ 			networkConnectionsDroppedTotal.Inc(map[string]string{""reason"": ""incoming_connection_per_ip_tcp_rate_limit""})
+ 			rt.log.With(""connection"", ""tcp"").With(""count"", originConnections).Debugf(""Rejected connection due to excessive connections attempt rate"")",I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local.,I think `remoteHostIsNonLocal` sounds better to me than `isLocalhost(trackerRequest.remoteHost)`.
+5205,"@@ -105,7 +105,7 @@ export function initDebug() {
+ 					`\n\n${getOwnerStack(vnode)}`
+ 			);
+ 		} else if (type != null && typeof type === 'object') {
+-			if (type._lastDomChild !== undefined && type._dom !== undefined) {
++			if (type._lastDomChildSibling !== undefined && type._dom !== undefined) {
+ 				throw new Error(
+ 					`Invalid type passed to createElement(): ${type}\n\n` +
+ 						'Did you accidentally pass a JSX literal as JSX twice?\n\n' +",Hmm I think I might've messed up this condition here... Need to look more at it,Was this a bug?
+5206,"@@ -118,11 +118,9 @@ class DocumentQueue:
+         if doc_type == DocTypes.PACKAGE:
+             if not handle or not package_hash or not pointer_file:
+                 raise ValueError(""missing required argument for package document"")
+-            if (
+-                package_stats
+-                and not isinstance(package_stats, dict)
+-                or isinstance(package_stats, dict)
+-                and any(k not in package_stats for k in ['total_files', 'total_bytes'])
++            if not (
++                package_stats is None
++                or isinstance(package_stats, dict) and {'total_files', 'total_bytes'}.issubset(package_stats)
+             ):
+                 raise ValueError(""Malformed package_stats"")
+             body.update({",This also makes the exception to be raised on non-dict falsy values which I think was expected.,``package_stats is None`` is equivalent to ``package_stats is not None``
+5207,"@@ -173,7 +173,7 @@ class Dataset(Element):
+
+     # In the 1D case the interfaces should not automatically add x-values
+     # to supplied data
+-    _auto_indexable_1d = False
++    _auto_indexable_1d = True
+
+     # Define a class used to transform Datasets into other Element types
+     _conversion_interface = DataConversion",Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR...,"This is unrelated to this PR, right?"
+5208,"@@ -6,9 +6,9 @@ setup(
+     py_modules=[""rtool""],
+     install_requires=[
+         ""click>=6.2, <7.0"",
+-        ""twine>=1.6.5, <1.9"",
++        ""twine>=1.6.5, <1.10"",
+         ""pysftp==0.2.8"",
+-        ""cryptography>=1.6, <1.7"",
++        ""cryptography>=1.6, <1.9"",
+     ],
+     entry_points={
+         ""console_scripts"": [","Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well.","The package is not installed in the root cause of the issue, but I think this is a bug. Please open a PR to fix it."
+5209,"@@ -0,0 +1,13 @@
++#include <iostream>
++#include <rai/lib/utility.hpp>
++
++void release_assert_internal (bool check, const char * check_expr, const char * file, unsigned int line)
++{
++	if (check)
++	{
++		return;
++	}
++
++	std::cerr << ""Assertion ("" << check_expr << "") failed "" << file << "":"" << line << std::endl;
++	abort();
++}",Will calling `abort()` cause problems for our test suite?,release_assert_internal -> assert_internal
+5210,"@@ -292,6 +292,11 @@ ast_result_t pass_expr(ast_t** astp, pass_opt_t* options)
+     case TK_ADDRESS:    r = expr_addressof(options, ast); break;
+     case TK_DIGESTOF:   r = expr_digestof(options, ast); break;
+
++    case TK_OBJECT:
++      if(!expr_object(options, astp))
++        return AST_FATAL;
++      break;
++
+     case TK_LAMBDA:
+       if(!expr_lambda(options, astp))
+         return AST_FATAL;","for my own edificaton, what's this?",Minor: missing space before `break`
+5211,"@@ -248,13 +248,14 @@ func (sf *factory) NewWorkingSet() (WorkingSet, error) {
+
+ // Commit persists all changes in RunActions() into the DB
+ func (sf *factory) Commit(ws WorkingSet) error {
++	if ws == nil {
++		return nil
++	}
+ 	sf.mutex.Lock()
+ 	defer sf.mutex.Unlock()
+-	if ws != nil {
+-		if sf.currentChainHeight != ws.Version() {
+-			// another working set with correct version already committed, do nothing
+-			return nil
+-		}
++	if sf.currentChainHeight != ws.Version() {
++		// another working set with correct version already committed, do nothing
++		return nil
+ 	}
+ 	if err := ws.Commit(); err != nil {
+ 		return errors.Wrap(err, ""failed to commit working set"")",make it harmless to commit ws == nil,Would it be possible to just skip the commit if the version is the same?
+5212,"@@ -59,6 +59,8 @@ var locationsReplacement = regexp.MustCompile(`\$\(locations ([^\)]+)\)`)
+ var exeReplacement = regexp.MustCompile(`\$\(exe ([^\)]+)\)`)
+ var outExeReplacement = regexp.MustCompile(`\$\(out_exe ([^\)]+)\)`)
+ var outReplacement = regexp.MustCompile(`\$\(out_location ([^\)]+)\)`)
++var absOutExeReplacement = regexp.MustCompile(`\$\(abs_out_exe ([^\)]+)\)`)
++var absOutReplacement = regexp.MustCompile(`\$\(abs_out_location ([^\)]+)\)`)
+ var dirReplacement = regexp.MustCompile(`\$\(dir ([^\)]+)\)`)
+ var hashReplacement = regexp.MustCompile(`\$\(hash ([^\)]+)\)`)
+ var workerReplacement = regexp.MustCompile(`^(.*)\$\(worker ([^\)]+)\) *([^&]*)(?: *&& *(.*))?$`)","Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go?",This typo fix is unrelated to the rest of this PR.
+5213,"@@ -24,8 +24,11 @@ import (
+
+ var _reqBody = []byte(""hello"")
+
+-func yarpcEcho(ctx context.Context, reqMeta yarpc.ReqMeta, body []byte) ([]byte, yarpc.ResMeta, error) {
+-	return body, yarpc.NewResMeta().Headers(reqMeta.Headers()), nil
++func yarpcEcho(ctx context.Context, body []byte) ([]byte, error) {
++	for _, k := range yarpc.HeaderNames(ctx) {
++		yarpc.WriteResponseHeader(ctx, k, yarpc.Header(ctx, k))
++	}
++	return body, nil
+ }
+
+ func httpEcho(t testing.TB) http.HandlerFunc {",That's actually not as bad as I thought it was going to be.,Should we use `writeResponseHeader` from `pkg/x/ya
+5214,"@@ -198,6 +198,11 @@ public class DatasetServiceBean implements java.io.Serializable {
+         return em.createQuery(""SELECT o.id FROM Dataset o WHERE o.indexTime IS null ORDER BY o.id DESC"", Long.class).getResultList();
+     }
+
++    //Used in datasets listcurationstatus API
++    public List<Dataset> findAllUnpublished() {
++        return em.createQuery(""SELECT object(o) FROM Dataset o, DvObject d WHERE d.id=o.id and d.publicationDate IS null ORDER BY o.id ASC"", Dataset.class).getResultList();
++    }
++
+     /**
+      * For docs, see the equivalent method on the DataverseServiceBean.
+      * @param numPartitions","Hmm, I'm surprised if we don't already have a ""find all unpublished datasets"" method but I don't really know. Maybe @scolapasta knows.",Is this used somewhere?
+5215,"@@ -598,6 +598,12 @@ class Python3Checker(checkers.BaseChecker):
+             ""variables will be deleted outside of the ""
+             ""comprehension."",
+         ),
++        ""C1601"": (
++            ""Consider using Python 3 style super() without arguments"",
++            ""old-style-super"",
++            ""Emitted when calling the super builtin with the current class ""
++            ""and instance. On Python 3 these arguments are the default."",
++        ),
+     }
+
+     _bad_builtins = frozenset(","The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all.","instead of ""old-style"", I'd say ""This is only avai"
+5216,"@@ -0,0 +1,18 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
++{
++    /// <summary>
++    /// Feature to set the minimum data rate at which the response should be sent.
++    /// </summary>
++    public interface IHttpMinResponseDataRateFeature
++    {
++        /// <summary>
++        /// The minimum data rate in bytes/second at which the response should be sent.
++        /// Setting this property to null indicates no minimum data rate should be enforced.
++        /// This limit has no effect on upgraded connections which are always unlimited.
++        /// </summary>
++        MinDataRate MinDataRate { get; set; }
++    }
++}","I would change ""should be sent"" to ""must be received"".",IHttpMinResponseDataRateFeature would be a better name. It wasn't clear to me what this feature does.
+5217,"@@ -24,6 +24,8 @@ import (
+ 	""github.com/openebs/maya/pkg/storagepool""
+ )
+
++
++// DeleteStoragePool receives StoragePoolClaim object and deletes it.
+ func DeleteStoragePool(spcGot *v1alpha1.StoragePoolClaim) error {
+ 	// Business logic for deletion of storagepool
+ 	glog.Infof(""Storagepool delete event received for storagepoolclaim %s"", spcGot.Name)",Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.`,"What do you mean by ""delete it""?"
+5218,"@@ -58,4 +58,16 @@ public final class RestConst {
+   public static final String CONSUMER_HEADER = ""servicecomb-rest-consumer-header"";
+
+   public static final String READ_STREAM_PART = ""servicecomb-readStreamPart"";
++
++  public static final String UPLOAD_DIR = ""cse.uploads.directory"";
++
++  // limit of one upload file, only available for servlet rest transport
++  public static final String UPLOAD_MAX_FILE_SIZE = ""cse.uploads.maxFileSize"";
++
++  // limit of upload request body
++  public static final String UPLOAD_MAX_SIZE = ""cse.uploads.maxSize"";
++
++  // the size threshold after which files will be written to disk
++  // only available for servlet rest transport
++  public static final String UPLOAD_FILE_SIZE_THRESHOLD = ""cse.uploads.fileSizeThreshold"";
+ }",It's better to use servicecomb now.,These two parameters are not used anywhere. I think they can be removed.
+5219,"@@ -58,12 +58,13 @@ var PolicyChain = policies.Chain{
+
+ type controller struct {
+ 	// the policies to use to define readiness - named here to make testing simpler
+-	policyChain              policies.Chain
+-	certificateLister        cmlisters.CertificateLister
+-	certificateRequestLister cmlisters.CertificateRequestLister
+-	secretLister             corelisters.SecretLister
+-	client                   cmclient.Interface
+-	gatherer                 *policies.Gatherer
++	policyChain                      policies.Chain
++	certificateLister                cmlisters.CertificateLister
++	certificateRequestLister         cmlisters.CertificateRequestLister
++	secretLister                     corelisters.SecretLister
++	client                           cmclient.Interface
++	gatherer                         *policies.Gatherer
++	defaultRenewBeforeExpiryDuration time.Duration
+ }
+
+ func NewController(",Make the flag derived default available in the readiness controller,Could this be defined in `pkg/cmd/server/main`?
+5220,"@@ -278,6 +278,10 @@ func TestReconcileClusterSync_NoWorkToDo(t *testing.T) {
+ 				}),
+ 			),
+ 		},
++		{
++			name: ""syncset pause"",
++			cd:   cdBuilder(scheme).GenericOptions(testgeneric.WithAnnotation(constants.SyncsetPauseAnnotation, ""true"")).Build(),
++		},
+ 	}
+ 	for _, tc := range cases {
+ 		t.Run(tc.name, func(t *testing.T) {",Confirmed this test fails when the fix is reverted ,Shouldn't this be `false` to test the annotation?
+5221,"@@ -38,6 +38,9 @@ func NewCollector(options *LogOptions) *Collector {
+
+ // Archive creates ZIP archive containing all node log files.
+ func (c *Collector) Archive() (outputFilepath string, err error) {
++	if c.options.Filepath == """" {
++		return """", errors.New(""file logging is disabled, can't retrieve logs"")
++	}
+ 	filepaths, err := c.logFilepaths()
+ 	if err != nil {
+ 		return """", err",This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`.,error strings should not be capitalized or end wi
+5222,"@@ -14,6 +14,15 @@ class BaseDenseHead(BaseModule, metaclass=ABCMeta):
+     def __init__(self, init_cfg=None):
+         super(BaseDenseHead, self).__init__(init_cfg)
+
++    def init_weights(self):
++        super(BaseDenseHead, self).init_weights()
++        # avoid init_cfg overwrite the initialization of `conv_offset`
++        for m in self.modules():
++            # DeformConv2dPack, ModulatedDeformConv2dPack
++            if hasattr(m, 'conv_offset'):
++                m.conv_offset.weight.data.zero_()
++                m.conv_offset.bias.data.zero_()
++
+     @abstractmethod
+     def loss(self, **kwargs):
+         """"""Compute losses of the head.""""""",DCN should not be able to use `init_cfg`.,"`super(BaseDenseHead, self).init_weights()` is al"
+5223,"@@ -28,7 +28,7 @@ namespace OpenTelemetry.Shims.OpenTracing
+         {
+             if (!spanContext.IsValid)
+             {
+-                throw new ArgumentException(nameof(spanContext));
++                throw new ArgumentException($""{nameof(spanContext)} must be valid."");
+             }
+
+             this.SpanContext = spanContext;","It is a bit weird to see a message like ""something must be valid"".","Why do we need to specify ""nameof"" here?"
+5224,"@@ -119,10 +119,10 @@ public class Standalone implements CliCommand {
+       LoggingOptions loggingOptions = new LoggingOptions(config);
+       loggingOptions.configureLogging();
+
+-      LOG.info(""Logging configured."");
++      LOG.finest(""Logging configured."");
+
+       DistributedTracer tracer = loggingOptions.getTracer();
+-      LOG.info(""Using tracer: "" + tracer);
++      LOG.finest(""Using tracer: "" + tracer);
+       GlobalDistributedTracer.setInstance(tracer);
+
+       EventBusConfig events = new EventBusConfig(config);","Again. This is part of the start up of the server, and the diagnostics are helpful.",is this supposed to be INFO?
+5225,"@@ -139,6 +139,12 @@ describe Travis::Build::Script::R, :sexp do
+                          echo: true, timing: true]
+   end
+
++  it 'skips PDF manual when LaTeX is disabled' do
++    data[:config][:latex] = false
++    should include_sexp [:cmd, /.*R CMD check.* --no-manual.*/,
++                         echo: true, timing: true]
++  end
++
+   describe 'bioc configuration is optional' do
+     it 'does not install bioc if not required' do
+       should_not include_sexp [:cmd, /.*biocLite.*/,","I think you need a `,` at the end of the line?",Layout/MultilineMethodCallBr
+5226,"@@ -54,10 +54,7 @@ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbEntityOperation;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation.State;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperationType;
+-import org.camunda.bpm.engine.impl.util.DatabaseUtil;
+-import org.camunda.bpm.engine.impl.util.ExceptionUtil;
+-import org.camunda.bpm.engine.impl.util.IoUtil;
+-import org.camunda.bpm.engine.impl.util.ReflectUtil;
++import org.camunda.bpm.engine.impl.util.*;
+
+ /**
+ *",Please avoid wildcard imports.,"No star imports, please"
+5227,"@@ -84,6 +84,9 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
+                     using (HttpClient client = new HttpClient())
+                     {
+                         client.DefaultRequestHeaders.Clear();
++
++                        // In random occassions the request fails if the network is slow and it takes more than 100 seconds to upload 4MB.
++                        client.Timeout = TimeSpan.FromMinutes(5);
+                         Func<HttpRequestMessage> createRequest = () =>
+                         {
+                             DateTime dt = DateTime.UtcNow;",Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL.,Can we set this to a much hi
+5228,"@@ -238,9 +238,17 @@ func run(o *Options) error {
+ 	}
+
+ 	var egressController *egress.EgressController
++	var nodeIP net.IP
++	if nodeConfig.NodeIPv4Addr != nil {
++		nodeIP = nodeConfig.NodeIPv4Addr.IP
++	} else if nodeConfig.NodeIPv6Addr != nil {
++		nodeIP = nodeConfig.NodeIPv6Addr.IP
++	} else {
++		return fmt.Errorf(""invalid NodeIPAddr in Node config: %v"", nodeConfig)
++	}
+ 	if features.DefaultFeatureGate.Enabled(features.Egress) {
+ 		egressController, err = egress.NewEgressController(
+-			ofClient, antreaClientProvider, crdClient, ifaceStore, routeClient, nodeConfig.Name, nodeConfig.NodeIPv4Addr.IP,
++			ofClient, antreaClientProvider, crdClient, ifaceStore, routeClient, nodeConfig.Name, nodeIP,
+ 			o.config.ClusterMembershipPort, egressInformer, nodeInformer, externalIPPoolInformer,
+ 		)
+ 		if err != nil {","dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family?","Error messages are not consistent. Please change to: ""Invalid NodeIPAddr in Node config: %v"""
+5229,"@@ -230,7 +230,7 @@ class ServerTLSLayer(_TLSLayer):
+                     server.sni = self.context.client.sni.encode(""idna"")
+                 else:
+                     server.sni = server.address[0].encode(""idna"")
+-                    self.tls[server].set_tlsext_host_name(server.sni)
++                self.tls[server].set_tlsext_host_name(server.sni)
+         self.tls[server].set_connect_state()
+
+         yield from self.process(events.DataReceived(server, b""""))",Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me!,was this a bug?
+5230,"@@ -57,12 +57,12 @@ public class TestPerformance extends LuceneTestCase {
+
+   @Test
+   public void en() throws Exception {
+-    checkAnalysisPerformance(""en"", 1_000_000);
++    checkAnalysisPerformance(""en"", 1_200_000);
+   }
+
+   @Test
+   public void en_suggest() throws Exception {
+-    checkSuggestionPerformance(""en"", 1_200);
++    checkSuggestionPerformance(""en"", 3_000);
+   }
+
+   @Test",Hmm what are these magical constant numbers? And why does this change mean they should increase?,Why did this change?
+5231,"@@ -36,7 +36,7 @@ import logging.config
+ import urlparse
+ from boto.exception import InvalidUriError
+
+-__version__ = '2.8.0-dev'
++__version__ = '2.8.0'
+ Version = __version__  # for backware compatibility
+
+ UserAgent = 'Boto/%s (%s)' % (__version__, sys.platform)",This change shouldn't be included with this push. Shouldn't push version changes with a pull-request.,Doesn't this need to be 2.8.0-dev?
+5232,"@@ -97,6 +97,9 @@ func (h handler) handle(ctx context.Context, call inboundCall) {
+
+ 	err := h.callHandler(ctx, call, responseWriter)
+
++	// echo accepted rpc-service in response header in any status
++	responseWriter.addHeader(RespondServiceHeaderKey, call.ServiceName())
++
+ 	// black-hole requests on resource exhausted errors
+ 	if yarpcerrors.FromError(err).Code() == yarpcerrors.CodeResourceExhausted {
+ 		// all TChannel clients will time out instead of receiving an error","nit: let's move this right under where we create the `responseWriter`, before `h.callHandler`",I am a bit confused by this header being added here. Shouldn't the header be added in `call.Status()`?
+5233,"@@ -361,7 +361,7 @@ void nano::mdb_store::upgrade_v14_to_v15 (nano::write_transaction & transaction_
+
+ 		nano::mdb_val value{ data.size (), (void *)data.data () };
+ 		auto s = mdb_put (env.tx (transaction_a), state_blocks_new, nano::mdb_val (hash), value, MDB_APPEND);
+-		release_assert_success (s);
++		release_assert_success<MDB_val, mdb_store> ((*this), s);
+
+ 		// Every so often output to the log to indicate progress
+ 		constexpr auto output_cutoff = 1000000;","The way it was implemented, needed to pass the template values. Please check whether we want this.","You don't need a cast here, right?"
+5234,"@@ -36,7 +36,8 @@ var daemonCmd = &cmds.Command{
+ 		cmdkit.BoolOption(OfflineMode, ""start the node without networking""),
+ 		cmdkit.BoolOption(ELStdout),
+ 		cmdkit.BoolOption(IsRelay, ""advertise and allow filecoin network traffic to be relayed through this node""),
+-		cmdkit.StringOption(BlockTime, ""time a node waits before trying to mine the next block"").WithDefault(clock.DefaultEpochDuration.String()),
++		cmdkit.StringOption(BlockTime, ""period a node waits between mining successive blocks"").WithDefault(clock.DefaultEpochDuration.String()),
++		cmdkit.StringOption(PropagationDelay, ""time a node waits after the start of an epoch for blocks to arrive"").WithDefault(clock.DefaultPropagationDelay.String()),
+ 	},
+ 	Run: func(req *cmds.Request, re cmds.ResponseEmitter, env cmds.Environment) error {
+ 		return daemonRun(req, re)","Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't do it yet tho.",Consider using `period` instead of `duration` for the command line
+5235,"@@ -18,6 +18,7 @@
+ # WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ # IN THE SOFTWARE.
++from __future__ import print_function
+
+ import errno
+ import httplib",Is this import needed?,do we need the import here?
+5236,"@@ -68,6 +68,8 @@ storiesOf( 'Dashboard', module )
+ 				<PostSearcher />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} )
+ 	.add( 'URL Search Widget', () => {
+ 		const setupRegistry = ( registry ) => provideSiteInfo( registry );",Dashboard stories also need to have the default padding.,Is this needed?
+5237,"@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+
++  /**
++   * If the compaction should commit rewritten data files using the sequence number at compaction start time instead
++   * of optimistically incrementing the latest sequence number.
++   * <p>
++   * This avoids commit conflicts with updates that add newer equality deletes at a higher sequence number.
++   * <p>
++   * Defaults to false.
++   */
++  String USE_STARTING_SEQUENCE_NUMBER = ""use-starting-sequence-number"";
++  boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = false;
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining",Is there a reason why we wouldn't use this as the default?,I think it migh
+5238,"@@ -15,7 +15,7 @@ void CreateEdgeProcessor::process(const cpp2::CreateEdgeReq& req) {
+     {
+         // if there is an edge of the same name
+         // TODO: there exists race condition, we should address it in the future
+-        folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock());
++        folly::SharedMutex::ReadHolder rHolder(LockUtils::tagLock());
+         auto conflictRet = getTagId(req.get_space_id(), edgeName);
+         if (conflictRet.ok()) {
+             LOG(ERROR) << ""Failed to create edge `"" << edgeName",if there is an tag of the same name?,tag instead of
+5239,"@@ -1,10 +1,8 @@
+ package net
+
+ import (
+-	""bytes""
+ 	""errors""
+ 	""fmt""
+-	""os/exec""
+ 	""path/filepath""
+ 	""runtime""
+ ",I'd add `// +build go1.10` to prevent from accidentally compiling with older Go.,Why was this re
+5240,"@@ -1,10 +1,12 @@
++from __future__ import unicode_literals
++
+ import numpy as np
+ import param
+
+ from ..core import (HoloMap, DynamicMap, CompositeOverlay, Layout,
+                     GridSpace, NdLayout, Store)
+ from ..core.util import (match_spec, is_number, wrap_tuple,
+-                         get_overlay_spec, unique_iterator)
++                         get_overlay_spec, unique_iterator, safe_unicode)
+
+
+ def displayable(obj):",Not sure how this import relates to the PR but seems like a good idea anyway...,"you don't need to do `from ..core import safe_unicode` here, you can just do `from ..core import safe_unicode`"
+5241,"@@ -5,6 +5,7 @@
+ #include ""../CustomBuild/ESPEasyLimits.h""
+ #include ""../DataStructs/DeviceStruct.h""
+ #include ""../../ESPEasy_common.h""
++#include ""../WebServer/HardwarePage.h""
+
+ template<unsigned int N_TASKS>
+ SettingsStruct_tmpl<N_TASKS>::SettingsStruct_tmpl() : ResetFactoryDefaultPreference(0) {","Hmm this is strange, why should the SettingsStruct import something from `WebServer` ? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around.","This is not needed, it's already included in the folder."
+5242,"@@ -4,13 +4,16 @@
+ using System;
+ using Microsoft.AspNet.Builder;
+ using Microsoft.AspNet.Http;
++using Microsoft.Framework.Logging;
+
+ namespace SampleApp
+ {
+     public class Startup
+     {
+-        public void Configure(IApplicationBuilder app)
++        public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory)
+         {
++            loggerFactory.MinimumLevel = LogLevel.Debug;
++            loggerFactory.AddConsole(LogLevel.Debug);
+             app.Run(context =>
+             {
+                 Console.WriteLine(""{0} {1}{2}{3}"",",nit: Space between these lines.,This is how we set the minimum level to .Debug.
+5243,"@@ -353,7 +353,7 @@ class ResultsProvider(object):
+     :type listeners: list[AggregatorListener]
+     """"""
+
+-    def __init__(self):
++    def __init__(self, translator=None):
+         super(ResultsProvider, self).__init__()
+         self.cumulative = BetterDict()
+         self.track_percentiles = []",Why aggregator should have this translator? It's Selenium specifics for now...,I'm not sure why this change is necessary?
+5244,"@@ -136,6 +136,13 @@ public abstract class FieldComparator<T> {
+     }
+   }
+
++  /**
++   * Informs the comparator that sorting is done in reverse.
++   * This is necessary only for skipping functionality.
++   */
++  public void setReverse() {
++  }
++
+
+   /**
+    * Base FieldComparator class for numeric types",I don't understand why this function is needed ? Can't you just pass the information when the `DocComparator` is created in the SortField ?,Could this be implemented as a default implementation in the superclass?
+5245,"@@ -11,5 +11,7 @@ class MailchimpFulfillmentJob < MailchimpJob
+
+   def subscribe(list_id, email)
+     client.list_subscribe(id: list_id, email_address: email, double_optin: false)
++  rescue Gibbon::MailChimpError => e
++    raise e unless MAILCHIMP_EMAIL_ERROR_CODES.include?(e.code)
+   end
+ end",This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse?,Wouldn't it make sense to `rescue Gibbon::MailChimpError as e` instead o
+5246,"@@ -90,6 +90,9 @@ function fetchWithTimeout(input, init) {
+                 url: xhr.responseURL,
+                 headers: xhr.responseHeaders
+             };
++            if (!options.headers) {
++                options.headers = {'content-type': xhr.getResponseHeader('content-type')};
++            }
+             const body = 'response' in xhr ? xhr.response : xhr.responseText;
+             resolve(new Response(body, options));
+         };","It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd.",did you mean to add this?
+5247,"@@ -107,8 +107,16 @@ noreturn static void exec_xwayland(struct wlr_xwayland_server *server) {
+ 		dup2(devnull, STDERR_FILENO);
+ 	}
+
++	const char *xwayland_path = getenv(""WLR_XWAYLAND"");
++	if (xwayland_path) {
++		wlr_log(WLR_INFO, ""Using Xwayland binary to '%s' due to WLR_XWAYLAND"",
++			xwayland_path);
++	} else {
++		xwayland_path = ""Xwayland"";
++	}
++
+ 	// This returns if and only if the call fails
+-	execvp(""Xwayland"", argv);
++	execvp(xwayland_path, argv);
+
+ 	wlr_log_errno(WLR_ERROR, ""failed to exec Xwayland"");
+ 	close(devnull);","Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env.",Wouldn't it be better to use `strlcpy()`?
+5248,"@@ -0,0 +1,13 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. Keep in mind, some components like `forms/checkbox` will be changed to `forms-checkbox`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!design-system-react/components/pill/__examples__/base.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/icon.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/container.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/listbox.jsx')
++];
++
++module.exports = siteStories;","Should we have an avatar, truncate, etc examples, too?",how about using something like `require('raw-loader')` instead of `require('raw-loader')`?
+5249,"@@ -31,7 +31,6 @@ class _MissingPandasLikeIndex(object):
+
+     # Properties
+     nbytes = unsupported_property('nbytes')
+-    shape = unsupported_property('shape')
+
+     # Deprecated properties
+     strides = unsupported_property('strides', deprecated=True)",could you add this to `docs/source/reference/indexing.rst` ?,Was this just unused?
+5250,"@@ -3,10 +3,10 @@
+ #  Copyright (C) 2003 Rational Discovery LLC
+ #     All Rights Reserved
+ #
+-import sys
++
++import six
+
+ from rdkit.VLib.Node import VLibNode
+-from rdkit import six
+
+
+ class FilterNode(VLibNode):",Why the change from rdkit.six to six?,Why do you need to remove six in this file?
+5251,"@@ -78,6 +78,12 @@ def renderView(request):
+
+   # Now we prepare the requested data
+   if requestOptions['graphType'] == 'pie':
++    targets = [target for target in requestOptions['targets'] if target.find(':') < 0]
++    if settings.REMOTE_PREFETCH_DATA and not requestOptions.get('localOnly'):
++      log.rendering(""Prefetching remote data"")
++      pathExpressions = extractPathExpressions(targets)
++      prefetchRemoteData(STORE.remote_stores, requestContext, pathExpressions)
++
+     for target in requestOptions['targets']:
+       if target.find(':') >= 0:
+         try:","Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it.",Do we want to do this before `extractPathExpressions`? That way if we do `prefetch=False`
+5252,"@@ -1892,7 +1892,7 @@ describe('Bulk', function () {
+         expect(result).to.exist;
+
+         bulk.execute(err => {
+-          expect(err).to.match(/Batch cannot be re-executed/);
++          expect(err).to.match(/This batch has already been executed, create new batch to execute/);
+           done();
+         });
+       });",I think we should change this to an instanceOf check for MongoBatchReExecutionError,"I think we can drop the ""This batch has already been executed"" text now."
+5253,"@@ -34,7 +34,7 @@ type ProfileDecoder struct {
+ }
+
+ func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
+-	return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
++	return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
+ }
+
+ func (p *ProfileDecoder) RegisterWith(d *dispatcher.Dispatcher) {",Required by the libcalico-go changes,"This looks unrelated to me, is this a different bug fix?"
+5254,"@@ -1193,3 +1193,12 @@ type MutableBareRootMetadataNoImplError struct {
+ func (e MutableBareRootMetadataNoImplError) Error() string {
+ 	return ""Does not implement MutableBareRootMetadata""
+ }
++
++// blockNonExistentError is returned when a block doesn't exist.
++type blockNonExistentError struct {
++	id BlockID
++}
++
++func (e blockNonExistentError) Error() string {
++	return fmt.Sprintf(""block %s does not exist"", e.id)
++}",Explain why we don't reuse the corresponding server error locally?,This error message should include the block ID so that it can be include
+5255,"@@ -417,7 +417,7 @@ public class SolrSearchResult {
+                 .add(""is_unpublished_state"", this.isUnpublishedState())
+                 .add(""is_published"", this.isPublishedState())
+                 .add(""is_deaccesioned"", this.isDeaccessionedState())
+-                .add(""date_to_display_on_card"", this.dateToDisplayOnCard);
++                .add(""date_to_display_on_card"", DateUtil.formatDate(this.releaseOrCreateDate));
+
+         // Add is_deaccessioned attribute, even though MyData currently screens any deaccessioned info out
+         //","@JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method).",I don't think this is the right date to display on the card. This is the
+5256,"@@ -20,8 +20,6 @@ var (
+ 	ErrNoConnection = errors.New(""no connection exists"")
+ 	// ErrAlreadyExists error indicates that aciton applieto to manager expects no active connection (i.e. connect)
+ 	ErrAlreadyExists = errors.New(""connection already exists"")
+-	// ErrConnectionCancelled indicates that connection in progress was cancelled by request of api user
+-	ErrConnectionCancelled = errors.New(""connection was cancelled"")
+ 	// ErrOpenvpnProcessDied indicates that Connect method didn't reach ""Connected"" phase due to openvpn error
+ 	ErrOpenvpnProcessDied = errors.New(""openvpn process died"")
+ )",What was wrong with more concrete error?,@deads2k any reason to remove this?
+5257,"@@ -14,3 +14,17 @@ function roots_get_search_form($form) {
+   return $form;
+ }
+ add_filter('get_search_form', 'roots_get_search_form');
++
++/**
++ * Add page slug to body_class() classes if it doesn't exist
++ */
++function roots_body_class($classes) {
++  // Add post/page slug
++  if (is_single() || is_page() && !is_front_page()) {
++  	if (!in_array(basename(get_permalink()), $classes)) {
++  		$classes[] = basename(get_permalink());
++  	}
++  }
++  return $classes;
++}
++add_filter('body_class', 'roots_body_class');",can you replace the tabs with 2 spaces please to match the rest of the project?,I think it would be better to use `
+5258,"@@ -14,6 +14,8 @@ const IntegralKind = ""integral""
+
+ type IntegralOpSpec struct {
+ 	Unit flux.Duration `json:""unit""`
++	TimeSrc string   `json:""timeSrc""`
++	TimeDst string   `json:""timeDst""`
+ 	execute.AggregateConfig
+ }
+ ",Why are we adding it to the integral function?,Is there a reason to have both time
+5259,"@@ -45,11 +45,11 @@ func XfrmStateAdd(state *XfrmState) error {
+
+ 	msg := &nl.XfrmUsersaInfo{}
+ 	msg.Family = uint16(nl.GetIPFamily(state.Dst))
+-	msg.Id.Daddr.FromIP(state.Dst)
++	msg.ID.Daddr.FromIP(state.Dst)
+ 	msg.Saddr.FromIP(state.Src)
+-	msg.Id.Proto = uint8(state.Proto)
++	msg.ID.Proto = uint8(state.Proto)
+ 	msg.Mode = uint8(state.Mode)
+-	msg.Id.Spi = nl.Swap32(uint32(state.Spi))
++	msg.ID.Spi = nl.Swap32(uint32(state.Spi))
+ 	msg.Reqid = uint32(state.Reqid)
+ 	msg.ReplayWindow = uint8(state.ReplayWindow)
+ 	msg.Lft.SoftByteLimit = nl.XFRM_INF",Same for this file,Not sure if I missed something here
+5260,"@@ -234,15 +234,14 @@ namespace NLog.Internal.FileAppenders
+                 appender.Flush();
+             }
+         }
+-
++
+         /// <summary>
+         /// Gets the file info for a particular appender.
+         /// </summary>
+         /// <param name=""fileName"">The file name associated with a particular appender.</param>
+-        /// <param name=""lastWriteTime"">The last file write time. The value must be of UTC kind.</param>
+-        /// <param name=""fileLength"">Length of the file.</param>
++        /// <param name=""fileCharacteristics"">The file characteristics, if the file information was retrieved successfully.</param>
+         /// <returns><see langword=""true""/> when the operation succeeded; <see langword=""false""/> otherwise.</returns>
+-        public bool GetFileInfo(string fileName, out DateTime lastWriteTime, out long fileLength)
++        public bool GetFileCharacteristics(string fileName, out FileCharacteristics fileCharacteristics)
+         {
+             foreach (BaseFileAppender appender in appenders)
+             {",Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal?,why do we have to change the signature of this method?
+5261,"@@ -825,6 +825,11 @@ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
+ 	view_activate(view, true);
+ 	seat->has_focus = true;
+
++	// We want to unconditionally send keyboard input to the view we are
++	// focusing here, so cancel any existing grabs.
++	struct wlr_seat_keyboard_grab *curr_grab = seat->seat->keyboard_state.grab;
++	curr_grab->interface->cancel(curr_grab);
++
+ 	struct wlr_keyboard *keyboard = wlr_seat_get_keyboard(seat->seat);
+ 	if (keyboard != NULL) {
+ 		wlr_seat_keyboard_notify_enter(seat->seat, view->wlr_surface,",probably better to use `wlr_seat_keyboard_end_grab()`.,Is it possible that the `interface->cancel()` call wil
+5262,"@@ -142,6 +142,9 @@ public class TransactionPool implements BlockAddedObserver {
+
+   public ValidationResult<TransactionInvalidReason> addLocalTransaction(
+       final Transaction transaction) {
++    if (transaction.getChainId().isEmpty() && !configuration.isUnprotectedTransactionsAllowed()) {
++      return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION);
++    }
+     if (!configuration.getTxFeeCap().isZero()
+         && minTransactionGasPrice(transaction).compareTo(configuration.getTxFeeCap()) > 0) {
+       return ValidationResult.invalid(TransactionInvalidReason.TX_FEECAP_EXCEEDED);",Such a large test impact for such a little 3 line change ;),"I'm not sure if this is the best place to do this, but"
+5263,"@@ -51,9 +51,9 @@ class Payment extends AbstractTranslatableEntity implements OrderableEntityInter
+     protected $vat;
+
+     /**
+-     * @var Collection
++     * @var \Shopsys\FrameworkBundle\Model\Transport\Transport[]|Collection
+      *
+-     * @ORM\ManyToMany(targetEntity=""Shopsys\FrameworkBundle\Model\Transport\Transport"")
++     * @ORM\ManyToMany(targetEntity=""Shopsys\FrameworkBundle\Model\Transport\Transport"", inversedBy=""payments"", cascade={""persist""})
+      * @ORM\JoinTable(name=""payments_transports"")
+      */
+     protected $transports;","Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport.",Why don't we use the `payments` entity here?
+5264,"@@ -0,0 +1,11 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Psalm\Issue;
++
++final class NonInvariantPropertyType extends CodeIssue
++{
++    public const ERROR_LEVEL = -1;
++    public const SHORTCODE = 235159;
++}",This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues.,Is there a reason why the name is `NonInvariantPropertyType`?
+5265,"@@ -20,6 +20,9 @@ const (
+ 	// the default configuration provided to ingress-annotation should be
+ 	// created.
+ 	tlsACMEAnnotation = ""kubernetes.io/tls-acme""
++	// editInPlaceAnnotation is used to toggle the use of ingressClass instead
++	// of ingress on the created Certificate resource
++	editInPlaceAnnotation = ""certmanager.k8s.io/edit-in-place""
+ 	// issuerNameAnnotation can be used to override the issuer specified on the
+ 	// created Certificate resource.
+ 	issuerNameAnnotation = ""certmanager.k8s.io/issuer""","We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?)",What is the difference between `editInPlaceAnnotation` and `i
+5266,"@@ -665,7 +665,7 @@ public class JobTypeManager {
+   /**
+    +   * Get the keystore load props
+    +   */
+-  public Props getCommonPluginLoadProps() {
++  public Props    getCommonPluginLoadProps() {
+     return this.cachedCommonPluginLoadProps;
+   }
+ ",No need to add this file change for this PR. Please remove it.,@Gregable @jon-wei Would you mind explaining why the keystore
+5267,"@@ -8,6 +8,7 @@ import net.sourceforge.pmd.lang.java.ast.ASTImportDeclaration;
+ import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
+
+ public class DontImportJavaLangRule extends AbstractJavaRule {
++    private static final String IMPORT_JAVA_LANG = ""java.lang."";
+
+     @Override
+     public Object visit(ASTImportDeclaration node, Object data) {",this extra dot at the end is causing a couple tests to fail on Travis,Should this constant be part of `AbstractJavaRule`?
+5268,"@@ -853,7 +853,11 @@ Arguments:
+
+ @conf.commands.register
+ def tshark(*args,**kargs):
+-    """"""Sniff packets and print them calling pkt.show(), a bit like text wireshark""""""
+-    sniff(prn=lambda x: x.display(),*args,**kargs)
+-
+-
++    """"""Sniff packets and print them calling pkt.summary(), a bit like text wireshark""""""
++    print(""Capturing on '"" + str(kargs.get('iface') if 'iface' in kargs else conf.iface) + ""'"")
++    i = [0]  # This should be a nonlocal variable, using a mutable object for Python 2 compatibility
++    def _cb(pkt):
++        print(""%5d\t%s"" % (i[0], pkt.summary()))
++        i[0] += 1
++    sniff(prn=_cb, store=False, *args, **kargs)
++    print(""\n%d packet%s captured"" % (i[0], 's' if i[0] > 1 else ''))",Did you try using `global` with a regular integer ?,"This can't be just `print(""\n%d packet %s captured"" % (i[0], pkt.summary()))` since the `print` function has a `\n`."
+5269,"@@ -76,7 +76,7 @@ int Contractor::Run()
+ #ifdef WIN32
+ #pragma message(""Memory consumption on Windows can be higher due to different bit packing"")
+ #else
+-    static_assert(sizeof(extractor::NodeBasedEdge) == 20,
++    static_assert(sizeof(extractor::NodeBasedEdge) == 24,
+                   ""changing extractor::NodeBasedEdge type has influence on memory consumption!"");
+     static_assert(sizeof(extractor::EdgeBasedEdge) == 16,
+                   ""changing EdgeBasedEdge type has influence on memory consumption!"");",windows size might be off,Why is this part of this PR?
+5270,"@@ -25,10 +25,8 @@
+ #include ""engine/bp/BPFileReader.h""
+ #include ""engine/bp/BPFileWriter.h""
+
+-#ifdef ADIOS_HAVE_DATAMAN // external dependencies
+ #include ""engine/dataman/DataManReader.h""
+ #include ""engine/dataman/DataManWriter.h""
+-#endif
+
+ #ifdef ADIOS_HAVE_ADIOS1 // external dependencies
+ #include ""engine/adios1/ADIOS1Reader.h""",This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds.,why is this removed?
+5271,"@@ -1,7 +1,7 @@
+ <%= ""#{@plan.title}"" %>
+ <%= ""----------------------------------------------------------\n"" %>
+ <% if @show_coversheet %>
+-<%= @hash[:attribution].length > 1 ? _(""Creators: "") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
++<%= @hash[:attribution].many? ? _(""Creators: "") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
+ <%= _(""Affiliation: "") + @hash[:affiliation] %>
+   <% if @hash[:funder].present? %>
+ <%= _(""Template: "") + @hash[:funder] %>",thanks for cleaning up these old length checks  ,"Many seems to make sense, however we don't know if there are any implications of this or not?"
+5272,"@@ -189,7 +189,7 @@ func (e *Executor) addBuiltinAnnontations(manifests []provider.Manifest, variant
+ }
+
+ func (e *Executor) applyManifests(ctx context.Context, manifests []provider.Manifest) error {
+-	e.LogPersister.Infof(""Start applying %d manifests"", len(manifests))
++	e.LogPersister.Infof(""Start applying %d manifests to %q namespace"", len(manifests), e.config.Input.Namespace)
+ 	for _, m := range manifests {
+ 		if err := e.provider.ApplyManifest(ctx, m); err != nil {
+ 			e.LogPersister.Errorf(""Failed to apply manifest: %s (%v)"", m.Key.ReadableString(), err)",What will be logged when the `Input.Namespace` was not specified?,why %q instead of %d?
+5273,"@@ -102,6 +102,9 @@ public class PMDParameters {
+     @Parameter(names = ""-cache"", description = ""Specify the location of the cache file for incremental analysis."")
+     private String cacheLocation = null;
+
++    @Parameter(names = ""-fix"", description = ""Attempt to automatically fix rule violations found on source files."")
++    private boolean autoFixes = false;
++
+     // this has to be a public static class, so that JCommander can use it!
+     public static class PropertyConverter implements IStringConverter<Properties> {
+ ",I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development,"Should be ""--fix"" ins"
+5274,"@@ -47,5 +47,6 @@ axe.imports = {
+ 	CssSelectorParser: require('css-selector-parser').CssSelectorParser,
+ 	doT: require('@deque/dot'),
+ 	emojiRegexText: require('emoji-regex'),
+-	memoize: require('memoizee')
++	memoize: require('memoizee'),
++	ariaQuery: require('aria-query')
+ };",I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it.,You should be able to
+5275,"@@ -86,18 +86,8 @@ namespace OpenTelemetry
+             return value;
+         }
+
+-        /// <inheritdoc/>
+-        public void Dispose()
+-        {
+-            if (!this.disposed)
+-            {
+-                Slot.Set(this.previousValue);
+-                this.disposed = true;
+-            }
+-        }
+-
+         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+-        internal static int IncrementIfTriggered()
++        public static int IncrementIfTriggered()
+         {
+             var value = Slot.Get();
+ ",@ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other very internal-y spots. /cc @reyang,I removed the `Dispos
+5276,"@@ -283,9 +283,12 @@ public class ExecuteFlowAction implements TriggerAction {
+             actions.add(killAct);
+           }
+         }
+-        Trigger slaTrigger =
+-            new Trigger(""azkaban_sla"", ""azkaban"", triggerCond, expireCond,
+-                actions);
++        Trigger slaTrigger = new Trigger.TriggerBuilder(""azkaban_sla"",
++                                                        ""azkaban"",
++                                                        triggerCond,
++                                                        expireCond,
++                                                        actions).build();
++
+         slaTrigger.getInfo().put(""monitored.finished.execution"",
+             String.valueOf(execId));
+         slaTrigger.setResetOnTrigger(false);",would be good to turn these into constants.,Could you please extract this to a method?
+5277,"@@ -158,8 +158,8 @@ func (g *gen) frame() []byte {
+ 		return nil
+ 	}
+ 	var buf bytes.Buffer
+-	buf.WriteString(""// Code generated by gowire. DO NOT EDIT.\n\n"")
+-	buf.WriteString(""//go:generate gowire\n"")
++	buf.WriteString(""// Code generated by wire. DO NOT EDIT.\n\n"")
++	buf.WriteString(""//go:generate wire\n"")
+ 	buf.WriteString(""//+build !wireinject\n\n"")
+ 	buf.WriteString(""package "")
+ 	buf.WriteString(g.prog.Package(g.currPackage).Pkg.Name())",Seems like it should be `generated by Wire` here and in the SUT?,Nit: We have a convention in the go file t
+5278,"@@ -173,7 +173,7 @@ func TestStorageProtocolBasic(t *testing.T) {
+ 		}
+ 	}
+
+-	ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150)
++	ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150, false)
+ 	assert.NoError(err)
+ 	requireQueryDeal := func() (DealState, string) {
+ 		resp, err := c.QueryDeal(ctx, ref.ProposalCid)","I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string ""no duplicates"" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the duplicates boolean is set false. 3. Start out in a state with more than 1 duplicates. Verify that the LastDuplicate field is set to the last duplicate when we propose with a true duplicates bool.",can we have a constant for this `500`?
+5279,"@@ -74,7 +74,7 @@ namespace OpenTelemetry
+         {
+             if (timeoutMilliseconds < 0 && timeoutMilliseconds != Timeout.Infinite)
+             {
+-                throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds));
++                throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds), timeoutMilliseconds, $""timeout milliseconds should not be below 0 or infinite, but was: {timeoutMilliseconds}"");
+             }
+
+             if (Interlocked.Increment(ref this.shutdownCount) > 1)",`Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67.,Did you mean to include `timeoutMillisecon
+5280,"@@ -38,6 +38,7 @@ using System.Linq;
+ using Xunit;
+ using NLog.Common;
+ using System.Text;
++using Xunit.Extensions;
+
+ namespace NLog.UnitTests.Common
+ {",I think we need `#if !SILVERLIGHT` here and at the test.,I think we can revert this file too?
+5281,"@@ -26,6 +26,7 @@ import javafx.collections.transformation.SortedList;
+ import javafx.event.EventHandler;
+ import javafx.scene.input.MouseEvent;
+ import me.xdrop.fuzzywuzzy.FuzzySearch;
++import org.eclipse.jgit.util.StringUtils;
+ import org.phoenicis.javafx.settings.JavaFxSettingsManager;
+ import org.phoenicis.javafx.views.common.ExpandedList;
+ import org.phoenicis.javafx.views.common.ThemeManager;",Can you change this import to the apache dependency? I didn't even know that jgit contains such a method...,nit: you can use `org.apache.commons
+5282,"@@ -34,11 +34,11 @@ func GenerateServiceAccountName(gServiceAccount, clusterName string) string {
+ }
+
+ // MakeServiceAccount creates a K8s ServiceAccount object for the Namespace.
+-func MakeServiceAccount(namespace string, gServiceAccount, clusterName string) *corev1.ServiceAccount {
++func MakeServiceAccount(namespace string, kServiceAccount, gServiceAccount, clusterName string) *corev1.ServiceAccount {
+ 	return &corev1.ServiceAccount{
+ 		ObjectMeta: metav1.ObjectMeta{
+ 			Namespace: namespace,
+-			Name:      GenerateServiceAccountName(gServiceAccount, clusterName),
++			Name:      kServiceAccount,
+ 			Annotations: map[string]string{
+ 				WorkloadIdentityKey: gServiceAccount,
+ 			},","Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler.",Why no longer generate the service a
+5283,"@@ -50,13 +50,15 @@ interpreted as encoded JSON and formatted accordingly.  If '-r', value
+ is displayed without a newline.  If '-t', the RFC 11 object is displayed.
+ '-a treeobj' causes the lookup to be relative to an RFC 11 snapshot reference.
+
+-*put* [-j|-r|-t] [-n] 'key=value' ['key=value...']::
++*put* [-j|-r|-t] [-n] [-A] 'key=value' ['key=value...']::
+ Store 'value' under 'key' and commit it.  If it already has a value,
+ overwrite it.  If no options, value is stored directly.  If '-j', it is
+ first encoded as JSON, then stored.  If '-r', the value may be read from
+ standard input if specified as ""-"", and may include embedded NULL bytes.
+ If '-t', value is stored as a RFC 11 object.  '-n' prevents the commit
+-from being merged with with other contemporaneous commits.
++from being merged with with other contemporaneous commits.  '-A' appends the
++value to a key instead of overwriting the value.  Append is incompatible with
++the -j option.
+
+ *ls* [-R] [-d] [-F] [-w COLS] [-1] ['key' ...]::
+ Display directory referred to by _key_, or ""."" (root) if unspecified.","should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON.","I think this should be ""append"" inst"
+5284,"@@ -49,7 +49,7 @@ func init() {
+ 	flags.BoolVarP(cmdFlags, &checkControl, ""check-control"", """", true, ""Check control characters."")
+ 	flags.DurationVarP(cmdFlags, &uploadWait, ""upload-wait"", """", 0, ""Wait after writing a file."")
+ 	flags.BoolVarP(cmdFlags, &checkLength, ""check-length"", """", true, ""Check max filename length."")
+-	flags.BoolVarP(cmdFlags, &checkStreaming, ""check-streaming"", """", true, ""Check uploadxs with indeterminate file size."")
++	flags.BoolVarP(cmdFlags, &checkStreaming, ""check-streaming"", """", true, ""Check uploads with indeterminate file size."")
+ }
+
+ var commandDefinition = &cobra.Command{",I presume this isn't some special term...,"maybe ""Check uploads with indeterminate file size"""
+5285,"@@ -79,6 +79,18 @@ function pAsHeadingEvaluate(node, options, virtualNode) {
+   const nextStyle = nextSibling ? getStyleValues(nextSibling) : null;
+   const prevStyle = prevSibling ? getStyleValues(prevSibling) : null;
+
++  if (node && nextSibling) {
++    const headingLength = node.textContent.trim().length;
++    const paragraphLength = nextSibling.textContent.trim().length;
++    if (headingLength > paragraphLength) {
++      return true;
++    } else if (headingLength < paragraphLength / 2) {
++      return false;
++    } else {
++      undefined;
++    }
++  }
++
+   if (!nextStyle || !isHeaderStyle(currStyle, nextStyle, margins)) {
+     return true;
+   }",Did you mean to return here? ;) You'll also need to add an `incomplete` message to the rule metadata.,Why `undefined` instead of `null`?
+5286,"@@ -540,6 +540,14 @@ const (
+ 	//    This is replaced at runtime
+ 	JivaClusterIPHolder JivaAnnotations = ""__CLUSTER_IP__""
+
++	// JivaCloneIPHolder is used as a placeholder for sync controller IP address
++	// which will be used as cloneIP
++	//
++	// NOTE:
++	//    This is replaced at runtime
++	JivaCloneIPHolder JivaAnnotations = ""__CLONE_IP__""
++
++	JivaReplicaTypeHolder JivaAnnotations = ""clone""
+ 	// JivaStorageSizeHolder is used as a placeholder for persistent volume's
+ 	// storage capacity
+ 	//",Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good.,Is there a reason to not use the `__CLONE_IP__` an
+5287,"@@ -38,6 +38,8 @@ public class RestClientSenderFilter implements ConsumerFilter {
+
+   @Override
+   public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
++    invocation.onStartSendRequest();
++
+     CompletableFuture<Response> future = new RestClientSender(invocation)
+         .send();
+ ",`invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send`,I don't understand why this change is needed. You
+5288,"@@ -218,8 +218,8 @@ func (ap *actPool) Add(ctx context.Context, act action.SealedEnvelope) error {
+ 	if act.GasPrice().Cmp(ap.cfg.MinGasPrice()) < 0 {
+ 		actpoolMtc.WithLabelValues(""gasPriceLower"").Inc()
+ 		log.L().Info(""action rejected due to low gas price"",
+-			zap.String(""act hash"", hex.EncodeToString(hash[:])),
+-			zap.String(""gas price"", act.GasPrice().String()))
++			zap.String(""actionHash"", hex.EncodeToString(hash[:])),
++			zap.String(""gasPrice"", act.GasPrice().String()))
+ 		return action.ErrUnderpriced
+ 	}
+ 	if err := ap.validate(ctx, act); err != nil {","use ""actionHash"" to be consistent with other places",These changes are unrelated to the PR.
+5289,"@@ -4,11 +4,14 @@
+
+ package net.sourceforge.pmd.lang.rule.properties;
+
++import java.util.Collections;
+ import java.util.Enumeration;
+ import java.util.Map;
+
++import net.sourceforge.pmd.EnumeratedPropertyDescriptor;
+ import net.sourceforge.pmd.PropertyDescriptorFactory;
+-import net.sourceforge.pmd.lang.rule.properties.factories.BasicPropertyDescriptorFactory;
++import net.sourceforge.pmd.PropertyDescriptorField;
++import net.sourceforge.pmd.util.CollectionUtil;
+
+ /**
+  * Defines a datatype with a set of preset values of any type as held within a","Can we derive `Class<E>` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me.",why not also add this to `org.apache.d
+5290,"@@ -5364,6 +5364,17 @@ TEST_F(VkLayerTest, AndroidHardwareBufferCreateYCbCrSampler) {
+     m_errorMonitor->SetUnexpectedError(""VUID-VkSamplerYcbcrConversionCreateInfo-xChromaOffset-01651"");
+     vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
+     m_errorMonitor->VerifyFound();
++
++    m_errorMonitor->ExpectSuccess();
++    efa.externalFormat = AHARDWAREBUFFER_FORMAT_Y8Cb8Cr8_420;
++    sycci.format = VK_FORMAT_UNDEFINED;
++    sycci.ycbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_YCBCR_709;
++    sycci.ycbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_NARROW;
++    // Spec says if we use VkExternalFormatANDROID value of components is ignored.
++    sycci.components = {VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO};
++    vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
++    m_errorMonitor->VerifyNotFound();
++    vk::DestroySamplerYcbcrConversion(dev, ycbcr_conv, nullptr);
+ }
+
+ TEST_F(VkLayerTest, AndroidHardwareBufferPhysDevImageFormatProp2) {","I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set the swizzle to anything I want, so I guess this is valid usage here... but now I am more curious if I have an external format does it not have to follow any component swizzle rules and can be anything regardless of the `ycbcrModel`? (I guess really a question for @critsec and is not a blocking concern for the scope of this PR)",Do you need this `if` statement?
+5291,"@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
+ 		return """", err
+ 	}
+
+-	if app.SiteStatus() != ""running"" {
+-		return """", errors.New(""app not running locally. Try `ddev start`"")
++	if app.SiteStatus() != platform.SiteRunning {
++		return """", errors.New(""App not running locally. Try `ddev start`"")
+ 	}
+
+ 	db, err := app.FindContainerByType(""db"")","I'd say the error should be an error, not instructions to the user. So error would be something like ""site should be running and is not""","Note that errors.New(""app not running "
+5292,"@@ -894,8 +894,11 @@ class SNSTest(unittest.TestCase):
+         return queue_name, queue_arn, queue_url
+
+     def test_publish_sms_endpoint(self):
++        # Clean posible previous sms messages
++        sns_backend = SNSBackend.get()
++        sns_backend.sms_messages = []
++
+         def check_messages():
+-            sns_backend = SNSBackend.get()
+             self.assertEqual(len(list_of_contacts), len(sns_backend.sms_messages))
+
+         list_of_contacts = [""+10123456789"", ""+10000000000"", ""+19876543210""]","Thanks for this PR @pinzon !   Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have duplicates across different tests). We're planning to introduce test parallelization in the near future, and this will help us avoiding undesired side-effects.   Thanks","Just curious, why is this needed?"
+5293,"@@ -21,10 +21,12 @@ import (
+ 	""context""
+ 	""errors""
+ 	""sync""
+-	""time""
++
++	""github.com/asaskevich/EventBus""
+
+ 	log ""github.com/cihub/seelog""
+-	""github.com/mysteriumnetwork/node/client/stats""
++	stats_dto ""github.com/mysteriumnetwork/node/client/stats/dto""
++
+ 	""github.com/mysteriumnetwork/node/communication""
+ 	""github.com/mysteriumnetwork/node/firewall""
+ 	""github.com/mysteriumnetwork/node/identity""",Some weird blocks formation again.,"could you remove this import, tha"
+5294,"@@ -39,7 +39,7 @@ func TestOvirtActuator(t *testing.T) {
+ 			clusterDeployment: testOvirtClusterDeployment(),
+ 			pool:              testOvirtPool(),
+ 			expectedMachineSetReplicas: map[string]int64{
+-				fmt.Sprintf(""%s-worker-0"", testInfraID): 3,
++				fmt.Sprintf(""%s-worker"", testInfraID): 3,
+ 			},
+ 		},
+ 	}",This is worrisome.,did this test never work? how did
+5295,"@@ -219,6 +219,9 @@ type FilesystemTrimDriver interface {
+ 	// AutoFilesystemTrimStatus returns the status of auto fs trim
+ 	// operations on volumes
+ 	AutoFilesystemTrimStatus(request *api.SdkAutoFSTrimStatusRequest) (*api.SdkAutoFSTrimStatusResponse, error)
++	// AutoFilesystemTrimUsage returns the usage of auto fs trim
++	// operations on locally mounted volumes
++	AutoFilesystemTrimUsage(request *api.SdkAutoFSTrimUsageRequest) (*api.SdkAutoFSTrimUsageResponse, error)
+ 	// FilesystemTrimStop stops a filesystem trim background operation on
+ 	// a specified volume, if any
+ 	FilesystemTrimStop(request *api.SdkFilesystemTrimStopRequest) (*api.SdkFilesystemTrimStopResponse, error)","nit try rephrasing to something like "" AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes""",This API should be exposed in `pk
+5296,"@@ -64,7 +64,7 @@ module Unix
+       h = self.foss_defaults
+       h['puppetserver-confdir'] = '/etc/puppetlabs/puppetserver/conf.d'
+       h['puppetservice']  = 'puppetserver'
+-      h['puppetbindir']   = '/opt/puppetlabs/agent/bin'
++      h['puppetbindir']   = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin'
+       h['puppetbin']      = ""#{h['puppetbindir']}/puppet""
+       h['puppetpath']     = '/etc/puppetlabs/agent'
+       h['puppetconfdir']  = ""#{h['puppetpath']}/config""","currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppetlabs/puppet/bin`",why is this change necessary?
+5297,"@@ -4,10 +4,10 @@ import Ember from 'ember';
+ import PouchAdapterUtils from 'hospitalrun/mixins/pouch-adapter-utils';
+
+ export default Adapter.extend(PouchAdapterUtils, {
+-    databaseName: 'config',
+-    db:  Ember.computed.alias('pouchDBService.configDB'),
+-    pouchDBService: Ember.inject.service('pouchdb'),
+-
++    databaseName: 'config',
++    database: Ember.inject.service(),
++    db:  Ember.computed.alias('database.configDB'),
++
+     _mapQuery: function(doc, emit) {
+         if (doc._id) {
+             emit(doc._id, null);",any point in keeping this here ?,This is actually not correct
+5298,"@@ -233,8 +233,8 @@ type GossipData struct {
+ }
+
+ func (g *GossipData) Merge(o router.GossipData) {
+-	checkAndPanic(CaseSensitive(g.Entries))
+-	defer func() { checkAndPanic(CaseSensitive(g.Entries)) }()
++	checkAndPanic(CaseInsensitive(g.Entries))
++	defer func() { checkAndPanic(CaseInsensitive(g.Entries)) }()
+ 	other := o.(*GossipData)
+ 	g.Entries.merge(other.Entries)
+ 	if g.Timestamp < other.Timestamp {",I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver).,Shouldn't we keep `CaseSensit
+5299,"@@ -1,6 +1,11 @@
+ #include ""engine/routing_algorithms/shortest_path.hpp""
++
++#ifdef OSRM_EXTERNAL_MEMORY
++#include ""routing/routing_base_offline.hpp""
++#else
+ #include ""engine/routing_algorithms/routing_base_ch.hpp""
+ #include ""engine/routing_algorithms/routing_base_mld.hpp""
++#endif
+
+ #include <boost/assert.hpp>
+ #include <boost/optional.hpp>","This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantiate own implementations using private impl headers. Otherwise we again make wrong dependencies into OSRM code and block changes in separate projects.",This is the exact same as the
+5300,"@@ -149,6 +149,8 @@ void PDPSimpleListener::onNewCacheChangeAdded(RTPSReader* reader, const CacheCha
+             {
+                 listener->onParticipantDiscovery(this->mp_SPDP->getRTPSParticipant()->getUserRTPSParticipant(), std::move(info));
+             }
++
++            return; // change already removed from history
+         }
+     }
+ ","Then, where is it removed?",Is this intentional? It looks like you are removing the history information from this message
+5301,"@@ -16,6 +16,7 @@ func TestVHostTrie(t *testing.T) {
+ 		""example.com/foo/bar"",
+ 		""*.example.com/test"",
+ 	})
++	CaseSensitivePath = true
+ 	assertTestTrie(t, trie, []vhostTrieTest{
+ 		{""not-in-trie.com"", false, """", ""/""},
+ 		{""example"", true, ""example"", ""/""},",The tests are not run concurrently? (I don't know. Better check.),"Why this change? If you want to make sure the behavior is the same, you can use `assert.Equal"
+5302,"@@ -131,7 +131,7 @@ Blockly.FieldTextInput.prototype.showEditor_ = function(opt_quietInput) {
+   var htmlInput = goog.dom.createDom('input', 'blocklyHtmlInput');
+   htmlInput.setAttribute('spellcheck', this.spellcheck_);
+   var fontSize =
+-      (Blockly.FieldTextInput.FONTSIZE * this.workspace_.scale) + 'pt';
++      (Blockly.FieldTextInput.FONTSIZE) + 'pt';
+   div.style.fontSize = fontSize;
+   htmlInput.style.fontSize = fontSize;
+   /** @type {!HTMLInputElement} */",Regardless of scale?,Does this actually work? I thought `fontSize` was always the same as `this.workspace_.fontSiz
+5303,"@@ -44,6 +44,14 @@ var dataDirectory = flag.String(""d"", """", ""Root Algorand daemon data path"")
+ var versionCheck = flag.Bool(""v"", false, ""Display and write current build version and exit"")
+ var telemetryOverride = flag.String(""t"", """", `Override telemetry setting if supported (Use ""true"", ""false"", ""0"" or ""1"")`)
+
++// the following flags aren't being used by the algoh, but are needed so that the flag package won't complain that
++// these flags were provided but were not defined. We grab all the input flags and pass these downstream to the algod executable
++// as an input arguments.
++var peerOverride = flag.String(""p"", """", ""Override phonebook with peer ip:port (or semicolon separated list: ip:port;ip:port;ip:port...)"")
++var listenIP = flag.String(""l"", """", ""Override config.EndpointAddress (REST listening address) with ip:port"")
++var seed = flag.String(""seed"", """", ""input to math/rand.Seed()"")
++var genesisFile = flag.String(""g"", """", ""Genesis configuration file"")
++
+ const algodFileName = ""algod""
+ const goalFileName = ""goal""
+ ",Nit: should not we hide them from printing out?,IMO this should not be done here. The manual registration of the flags is done when the comma
+5304,"@@ -196,7 +196,7 @@ test_pipeline = [
+             dict(type='RandomFlip'),
+             dict(type='Normalize', **img_norm_cfg),
+             dict(type='Pad', size_divisor=32),
+-            dict(type='ImageToTensor', keys=['img']),
++            dict(type='DefaultFormatBundle'),
+             dict(type='Collect', keys=['img']),
+         ])
+ ]",What is the reason to modify those things? I noticed it breaks the examples using `asyncio`,I think we should deprecate `ImageToTensor` so that we can get rid of `DefaultFormatBundle` altogether.
+5305,"@@ -33,7 +33,7 @@ import (
+
+ const (
+ 	// Encoding is the name of this encoding.
+-	Encoding transport.Encoding = ""protobuf""
++	Encoding transport.Encoding = ""proto""
+
+ 	rawResponseHeaderKey = ""rpc-protobuf-raw-response""
+ )",WHOOOOOOOPS! so this is a wire protocol breaking change. I deployed a dev version of yarpc 1.9 to demo-yarpc-go and it caused bad request errors because it couldn't determine the procedure anymore. (in coordination with yarpc-prober),@deads2k do you think we should change this?
+5306,"@@ -1,5 +1,9 @@
+ 'use strict';
+
++const parseConnectionString = require('./core/uri_parser');
++
++const writeConcernKeys = new Set(['w', 'wtimeout', 'j', 'fsync', 'wtimeoutMS', 'journal']);
++
+ /**
+  * The **WriteConcern** class is a class that represents a MongoDB WriteConcern.
+  * @class","if we keep this, can we stick to our convention of using UPPER_CASE for constants? Otherwise this looks like a floating variable to me.",Why is this in the core directory? I don't think it should be in the core directory.
+5307,"@@ -341,7 +341,7 @@ class GTPPDUSessionContainer(Packet):
+         return p
+
+     def hashret(self):
+-        return struct.pack(""H"", self.seq)
++        return struct.pack(""H"", getattr(self.underlayer, ""seq""))
+
+
+ class GTPEchoRequest(Packet):",You probably don't want to assume that `self.underlayer` has a `seq` attribute.,"Looking at the source of `getattr`, it looks like `self.underlayer` may not have the `seq` attribute, s"
+5308,"@@ -65,10 +65,6 @@ class DisplayLanguageOptionFactory implements FactoryInterface
+         if (!empty($options)) {
+             throw new \Exception('Unexpected options sent to factory.');
+         }
+-        // We want to construct a separate translator instance for this helper,
+-        // since it configures different language/locale than the core shared
+-        // instance!
+-        $factory = new \VuFind\I18n\Translator\TranslatorFactory();
+-        return new $requestedName($factory($container, Translator::class));
++        return new $requestedName($container->get(Translator::class));
+     }
+ }",This apparently breaks the language selection.,Why did you remove the factory here?
+5309,"@@ -0,0 +1,10 @@
++# This migration comes from acts_as_taggable_on_engine (originally 5)
++# This migration is added to circumvent issue #623 and have special characters
++# work properly
++class ChangeCollationForTagNames < ActiveRecord::Migration
++  def up
++    if ActsAsTaggableOn::Utils.using_mysql?
++      execute(""ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;"")
++    end
++  end
++end","since we're not using mysql, do we need this migration?",Do not use semicolons to terminate e
+5310,"@@ -453,6 +453,9 @@ OUTBOUND_HTTP_PROXY = os.environ.get(""OUTBOUND_HTTP_PROXY"", """")
+ # Equivalent to HTTPS_PROXY, but only applicable for external connections
+ OUTBOUND_HTTPS_PROXY = os.environ.get(""OUTBOUND_HTTPS_PROXY"", """")
+
++# Whether to enable the partition adjustment listener (in order to support other partitions that the default)
++PARTITION_ADJUSTMENT = is_env_true(""PARTITION_ADJUSTMENT"")
++
+ # list of environment variable names used for configuration.
+ # Make sure to keep this in sync with the above!
+ # Note: do *not* include DATA_DIR in this list, as it is treated separately",i'm not sure about htis naming here. both the word partition and adjustment are very ambiguous and it's not clear what it does. i would maybe go for something less generic and more concrete like `GOV_CLOUD_SUPPORT`,`PARTITION_ADJUSTMENT` -> `PARTITION
+5311,"@@ -78,7 +78,13 @@ public class MockExecutorLoader implements ExecutorLoader {
+   @Override
+   public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
+       throws ExecutorManagerException {
+-    return new ConcurrentHashMap<>();
++    return this.activeFlows;
++  }
++
++  @Override
++  public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
++      throws ExecutorManagerException {
++    return this.activeFlows;
+   }
+
+   @Override",unfinishedFlows might not be the same as activeFlows. Will it cause confusion here?,Why not just return `Collections.emp
+5312,"@@ -73,3 +73,18 @@ func Example() {
+ 	cfg := snapshot.Value.(MyConfig)
+ 	_ = cfg
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""runtimeconfigurator://myproject/myconfigid/myvar?decoder=string"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}","Same, remove the error handling.","Can we add a check to make sure that if it's nil, `v.Watch` returns an error?"
+5313,"@@ -1,14 +1,16 @@
+-// IMvxAppStart.cs
++// IMvxAppStart.cs
+
+ // MvvmCross is licensed using Microsoft Public License (Ms-PL)
+ // Contributions and inspirations noted in readme.md and license.txt
+ //
+ // Project Lead - Stuart Lodge, @slodge, me@slodge.com
+
++using System.Threading.Tasks;
++
+ namespace MvvmCross.Core.ViewModels
+ {
+     public interface IMvxAppStart
+     {
+-        void Start(object hint = null);
++        Task Start(object hint = null);
+     }
+ }",We should not change this at this time.,"This is an interface, but it doesn't need to be declared as `Task`"
+5314,"@@ -242,8 +242,8 @@ class AnchorGenerator(object):
+         Args:
+             base_anchors (torch.Tensor): The base anchors of a feature grid.
+             featmap_size (tuple[int]): Size of the feature maps.
+-            stride (tuple[int], optional): Stride of the feature map.
+-                Defaults to (16, 16).
++            stride (tuple[int], optional): Stride of the feature map in order
++                (w, h). Defaults to (16, 16).
+             device (str, optional): Device the tensor will be put on.
+                 Defaults to 'cuda'.
+ ",We may also update the docstring in the AnchorGenerator's arguments at around line 15.,"I'm wondering if we should just call this `stride` and have it be `(w, h)` in"
+5315,"@@ -930,7 +930,7 @@ bool CoreChecks::ValidateAndUpdateQFOScoreboard(const debug_report_data *report_
+                        "" duplicates existing barrier submitted in this batch from command buffer %s."",
+                        ""vkQueueSubmit()"", BarrierRecord::BarrierName(), operation, BarrierRecord::HandleName(),
+                        report_data->FormatHandle(barrier.handle).c_str(), barrier.srcQueueFamilyIndex, barrier.dstQueueFamilyIndex,
+-                       report_data->FormatHandle(inserted.first->second).c_str());
++                       report_data->FormatHandle(inserted.first->second->commandBuffer).c_str());
+     }
+     return skip;
+ }",FormatHandle isn't current typesafe w.r.t. requiring *VULKAN* handles... so this slipped through.,Can you please make this `const std::string &commandBuffer`?
+5316,"@@ -21,6 +21,7 @@ import (
+ 	""errors""
+ 	""testing""
+
++	""github.com/asaskevich/EventBus""
+ 	""github.com/stretchr/testify/assert""
+
+ 	""github.com/mysteriumnetwork/node/identity""","What kind of dependency is here, I think we have own implementation of event wo external dependencies",Nit: Please remove this line.
+5317,"@@ -125,6 +125,18 @@ SYCL::SYCLDevice::SYCLDevice(sycl::device d) : m_device(std::move(d)) {}
+ SYCL::SYCLDevice::SYCLDevice(const sycl::device_selector& selector)
+     : m_device(selector.select_device()) {}
+
++SYCL::SYCLDevice::SYCLDevice(size_t id) {
++  std::vector<sycl::device> gpu_devices =
++      sycl::device::get_devices(sycl::info::device_type::gpu);
++  if (id >= gpu_devices.size()) {
++    std::stringstream error_message;
++    error_message << ""Requested GPU with id "" << id << "" but only ""
++                  << gpu_devices.size() << "" GPU(s) available!\n"";
++    Kokkos::abort(error_message.str().c_str());
++  }
++  m_device = gpu_devices[id];
++}
++
+ sycl::device SYCL::SYCLDevice::get_device() const { return m_device; }
+
+ void SYCL::impl_initialize(SYCL::SYCLDevice d) {",Throw an exception instead,It would be better if you use
+5318,"@@ -6,6 +6,9 @@ RSpec.describe Org::CreateLastMonthCreatedPlanService do
+   let(:org) do
+     FactoryBot.create(:org, created_at: DateTime.new(2018, 04, 01))
+   end
++  let(:org2) do
++    FactoryBot.create(:org)
++  end
+   let(:template) do
+     FactoryBot.create(:template, org: org)
+   end",we shouldn't need the `FactoryBot.` in these. Ok to leave for now since all of these specs have them. Can clean up later,What's the difference between
+5319,"@@ -80,7 +80,7 @@ class File extends FileBase
+             $uploadsPath .= '/protected';
+         }
+
+-        return Url::asset($uploadsPath) . '/';
++        return Storage::url($uploadsPath) . '/';
+     }
+
+     /**",Isn't the better option to actually do `$this->getDisk()->url($uploadsPath)` without changing the filesystems config? Not sure why you think that change is required but it's definitely not getting merged.,Shouldn't this be `$uploadsPa
+5320,"@@ -1585,7 +1585,7 @@ accessed. Python regular expressions are accepted."",
+             not isinstance(itemmethod, nodes.FunctionDef)
+             or itemmethod.root().name != ""builtins""
+             or not itemmethod.parent
+-            or itemmethod.parent.name not in SEQUENCE_TYPES
++            or itemmethod.parent.frame().name not in SEQUENCE_TYPES
+         ):
+             return None
+ ",Not sure if we need this. It's not tested because it only guards against a new conditional definition of a dunder method in a built-in package. I am fine with leaving it out.,What is the context for this change?
+5321,"@@ -0,0 +1,16 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++using Microsoft.DotNet.Build.Common.Desktop;
++
++namespace Microsoft.DotNet.Build.Tasks.Feed
++{
++    public partial class PushToBlobFeed
++    {
++        static PushToBlobFeed()
++        {
++            AssemblyResolver.Enable();
++        }
++    }
++}","Is this the only task in this library? If so this is good, if not then we should do it for each task.",Was this file supposed to be called
+5322,"@@ -245,7 +245,7 @@ func (ops *Operations) GetCstorVolumeCountEventually(namespace, lselector string
+ 		cvCount := ops.GetCVCount(namespace, lselector)
+ 		return cvCount
+ 	},
+-		60, 10).Should(Equal(expectedCVCount))
++		120, 10).Should(Equal(expectedCVCount))
+ }
+
+ // GetCstorVolumeReplicaCountEventually gives the count of cstorvolume based on",I am not sure what is 120 and what is 10. Hence unable to review.,why change this?
+5323,"@@ -47,8 +47,9 @@ type Options struct {
+ 	Location   OptionsLocation
+ 	Transactor OptionsTransactor
+
+-	Openvpn  Openvpn
+-	Firewall OptionsFirewall
++	EnableDNS bool
++	Openvpn   Openvpn
++	Firewall  OptionsFirewall
+ }
+
+ // OptionsKeystore stores the keystore configuration",Not needed anymore,Please remove the extra space betwee
+5324,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package pingpong exposes the simple ping-pong protocol
++// which measures RTT with other peers.
+ package pingpong
+
+ import (",Please not abbreviations,why is this in this PR?
+5325,"@@ -199,6 +199,10 @@ var ValidateResponseHandler = request.NamedHandler{Name: ""core.ValidateResponseH
+ // AfterRetryHandler performs final checks to determine if the request should
+ // be retried and how long to delay.
+ var AfterRetryHandler = request.NamedHandler{Name: ""core.AfterRetryHandler"", Fn: func(r *request.Request) {
++	if !aws.IsReaderSeekable(r.Body) {
++		r.Retryable = aws.Bool(false)
++	}
++
+ 	// If one of the other handlers already set the retry state
+ 	// we don't want to override it based on the service's state
+ 	if r.Retryable == nil || aws.BoolValue(r.Config.EnforceShouldRetryCheck) {",This shouldn't get stomped over on line 207,It seems like after thi
+5326,"@@ -37,6 +37,7 @@ func (tok Token) String() string {
+ }
+
+ // A Position describes a position in a source file.
++// All properties in Position are zero indexed
+ type Position struct {
+ 	Filename string
+ 	Offset   int",are they not 1-indexed?,@smarterclayton @brycem
+5327,"@@ -272,7 +272,7 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount, checkAllo
+ 	}
+
+ 	currentTime := s.timeNow().Unix()
+-	if currentTime == lastTime.CheckTimestamp {
++	if currentTime == lastTime.CheckTimestamp || currentTime == lastTime.Timestamp {
+ 		return nil, 0, ErrSettlementTooSoon
+ 	}
+ ",I know that previously this check was here but @ralph-pichler replaced it with the `CheckTimestamp` field stating that checking against `Timestamp` was incorrect. @ralph-pichler can you elaborate?,Shouldn't this be `|| c
+5328,"@@ -0,0 +1,19 @@
++# Copyright (c) Open-MMLab. All rights reserved.
++
++__version__ = '2.3.0rc0'
++short_version = '2.3.0rc0'
++
++
++def parse_version_info(version_str):
++    version_info = []
++    for x in version_str.split('.'):
++        if x.isdigit():
++            version_info.append(int(x))
++        elif x.find('rc') != -1:
++            patch_version = x.split('rc')
++            version_info.append(int(patch_version[0]))
++            version_info.append(f'rc{patch_version[1]}')
++    return tuple(version_info)
++
++
++version_info = parse_version_info(__version__)",`short_version = __version__`,why not `version_info.append(int(patch_version[0]))`?
+5329,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[UpdateAccessKey.java demonstrates how to update the status of an access key for an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[UpdateAccessKey.java demonstrates how to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I am a little confused by the fact that there is no `
+5330,"@@ -19,11 +19,12 @@
+
+ package org.apache.iceberg.spark;
+
++import java.io.Serializable;
+ import org.apache.iceberg.StructLike;
+ import org.apache.iceberg.types.Types;
+ import org.apache.spark.sql.Row;
+
+-public class SparkStructLike implements StructLike {
++public class SparkStructLike implements StructLike, Serializable {
+
+   private final Types.StructType type;
+   private Row wrapped;",Required for the SparkDataFile SerDe,Why is this needed?
+5331,"@@ -2595,16 +2595,8 @@ bool SwiftLanguageRuntime::CouldHaveDynamicValue(ValueObject &in_value) {
+     // Swift class instances are actually pointers, but base class instances
+     // are inlined at offset 0 in the class data. If we just let base classes
+     // be dynamic, it would cause an infinite recursion. So we would usually
+-    // disable it
+-    // But if the base class is a generic type we still need to bind it, and
+-    // that is
+-    // a good job for dynamic types to perform
+-    if (in_value.IsBaseClass()) {
+-      CompilerType base_type(in_value.GetCompilerType());
+-      if (SwiftASTContext::IsFullyRealized(base_type))
+-        return false;
+-    }
+-    return true;
++    // disable it.
++    return !in_value.IsBaseClass();
+   }
+   return var_type.IsPossibleDynamicType(nullptr, false, false, true);
+ }",Do you want to make this an assertion instead?,">in_value.IsBaseClass() [](start = 16, length = 17) I"
+5332,"@@ -1,5 +1,5 @@
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2015 NV Access Limited
++#Copyright (C) 2016 NV Access Limited
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ","When updating the copyright, we tend to cover previous years, not just the current. So, if we started the file in 2015, we'd update to say 2015-2016. I'm not sure if there's a legal requirement surrounding this, but it's the convention we and many others have adopted for code.",Did you mean to change this to the current year?
+5333,"@@ -1180,6 +1180,16 @@ func (fbo *folderBranchOps) SetInitialHeadFromServer(
+ 		return fmt.Errorf(""MD with revision=%d not initialized"", md.Revision())
+ 	}
+
++	// Return early if the head is already set.  This avoids taking
++	// mdWriterLock for no reason.
++	lState := makeFBOLockState()
++	head := fbo.getHead(lState)
++	if head != (ImmutableRootMetadata{}) && head.mdID == md.mdID {
++		fbo.log.CDebugf(ctx, ""Head MD already set to revision %d (%s), no ""+
++			""need to set initial head again"", md.Revision(), md.MergedStatus())
++		return nil
++	}
++
+ 	return runUnlessCanceled(ctx, func() error {
+ 		fb := FolderBranch{md.TlfID(), MasterBranch}
+ 		if fb != fbo.folderBranch {","Wait, so it looks like this function is called _every_ time we fetch the root node, i.e. we do an MD head fetch every time we fetch the root node? Not for this PR, but it seems like we should make that unnecessary, since this function only ever does anything when head is `nil`, i.e. the first time. Maybe add a TODO?",Would it make sense to move this check into `run
+5334,"@@ -1948,9 +1948,9 @@ class DomainNameListField(StrLenField):
+     islist = 1
+     padded_unit = 8
+
+-    def __init__(self, name, default, fld=None, length_from=None, padded=False):  # noqa: E501
++    def __init__(self, name, default, length_from=None, padded=False):  # noqa: E501
+         self.padded = padded
+-        StrLenField.__init__(self, name, default, fld, length_from)
++        StrLenField.__init__(self, name, default, length_from=length_from)
+
+     def i2len(self, pkt, x):
+         return len(self.i2m(pkt, x))",Why are you changing this?,Need a space here for PEP8.
+5335,"@@ -35,11 +35,11 @@ func NewConfigParser() *ConsumerConfigParser {
+ }
+
+ // Parse parses the given configuration
+-func (c *ConsumerConfigParser) Parse(config json.RawMessage) (ip string, port int, serviceType services.ServiceType, err error) {
++func (c *ConsumerConfigParser) Parse(config *json.RawMessage) (ip string, port int, serviceType services.ServiceType, err error) {
+ 	// TODO: since we are getting json.RawMessage here and not interface{} type not sure how to handle multiple services
+ 	// since NATPinger is one for all services and we get config from communication channel where service type is not know yet.
+ 	var cfg openvpn.ConsumerConfig
+-	err = json.Unmarshal(config, &cfg)
++	err = json.Unmarshal(*config, &cfg)
+ 	if err != nil {
+ 		return """", 0, """", errors.Wrap(err, ""parsing consumer address:port failed"")
+ 	}","`json.RawMessage` is a `[]byte`, which is already a pointer. Why do we need to have pointer here if we just reading this value?",why do we need to pass in the pointer?
+5336,"@@ -29,7 +29,7 @@ func main() {
+ 		cni.ActionAdd.Request,
+ 		cni.ActionCheck.Request,
+ 		cni.ActionDel.Request,
+-		cni_version.PluginSupports(""0.1.0"", ""0.2.0"", ""0.3.0"", ""0.3.1""),
++		cni_version.All,
+ 		fmt.Sprintf(""Antrea CNI %s"", version.GetFullVersionWithRuntimeInfo()),
+ 	)
+ }",should we actually switch to `All` or just add `0.4.0` explicitly to the list of supported CNI versions? What is a new CNI version is released?,@bharatviswa504 Is this safe to remove? Should we keep the check for 0.1.0 and 0.2.0?
+5337,"@@ -23,6 +23,7 @@ from google.cloud.security.notifier import notifier
+
+ from google.cloud.security.common.data_access import csv_writer
+ from google.cloud.security.scanner.audit import fw_rules_engine
++from google.cloud.security.common.gcp_type import resource_util
+ from google.cloud.security.common.data_access import firewall_rule_dao
+ from google.cloud.security.scanner.scanners import base_scanner
+ ",pylint might complain that this isn't alphasorted?,"I think the `resource_util` belongs in the `gcp` package, not the `aws` package."
+5338,"@@ -52,6 +52,7 @@ namespace Interop.FunctionalTests
+                 $""--no-sandbox "" +
+                 $""--disable-gpu "" +
+                 $""--allow-insecure-localhost "" +
++                $""--ignore-certificate-errors --enable-features=NetworkService "" +
+                 $""--enable-logging "" +
+                 $""--dump-dom "" +
+                 $""--virtual-time-budget=10000 "" +","It seems that NetworkService is behind a feature flag because it's still experimental. If we see new issues, we should look at flipping this back off.",Do we want to disable this by default?
+5339,"@@ -31,6 +31,19 @@ func (ts *TaskStatus) String() string {
+ 	return ""UNKNOWN""
+ }
+
++// Mapping task status in the agent to that in the backend
++func BackEndStatus(ts *TaskStatus) string {
++	switch *ts {
++	case TaskRunning:
++		return ""RUNNING""
++	case TaskStopped:
++		return ""STOPPED""
++	case TaskDead:
++		return ""STOPPED""
++	}
++	return ""PENDING""
++}
++
+ var containerStatusMap = map[string]ContainerStatus{
+ 	""NONE"":    ContainerStatusNone,
+ 	""UNKNOWN"": ContainerStatusUnknown,","I think it makes more sense to have this be a method on TaskStatus. Also, nit, Backend, not BackEnd.",Can you add a note here about the backend mapping of back-end tasks to the appropriat
+5340,"@@ -154,6 +154,10 @@ int HIPInternal::verify_is_initialized(const char *const label) const {
+   return 0 <= m_hipDev;
+ }
+
++uint32_t HIPInternal::impl_get_instance_id() const noexcept {
++  return Kokkos::Tools::Experimental::Impl::idForInstance<
++      Kokkos::Experimental::HIP>(reinterpret_cast<uintptr_t>(this));
++}
+ HIPInternal &HIPInternal::singleton() {
+   static HIPInternal *self = nullptr;
+   if (!self) {",Could you please elaborate on why you need all this magic here? In which cases do you want the same id to be returned? Does this work the same way for all backends?,"Since `HIPInternal::impl_get_instance_id` returns `uint32_t`, why do you need the explicit `const noexcept` here?"
+5341,"@@ -38,11 +38,8 @@ var (
+ )
+
+ type Config struct {
+-	// Directory in which plugin config files
+-	// reside
+-	ConfigDir string
+-
+-	Log logrus.FieldLogger
++	PluginsConfigs map[string]map[string]common.HclPluginConfig
++	Log            logrus.FieldLogger
+ }
+
+ type catalog struct {",nit: `PluginConfigs` feels a little better,I would prefer `[]common.HclPluginConfig` and `map[string]common.HclPluginConfig` instead of `map[string]common.H
+5342,"@@ -323,7 +323,7 @@ func TestLocalTransfer(t *testing.T) {
+ 	probeSvr := probe.New(7788)
+ 	require.NoError(probeSvr.Start(ctx))
+ 	defer func() {
+-		require.NoError(probeSvr.Stop(ctx))
++		probeSvr.Stop(ctx)
+ 	}()
+
+ 	// Start server","think we need to find out the root-cause and fix, instead of just removing `NoError`? it erred b/c `context canceled`, so call this before context cancelled is the right fix",Shouldn't be `require.NoError(probeSvr.Stop(ctx))`?
+5343,"@@ -405,7 +405,10 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock.
+ 				id, tlfID, context, size)
+ 			dbc := b.config.DiskBlockCache()
+ 			if dbc != nil {
+-				go dbc.Put(ctx, tlfID, id, buf, serverHalf)
++				// This used to be called in a goroutine to prevent blocking
++				// the `Get`. But we need this cached synchronously for
++				// later behavior.
++				dbc.Put(ctx, tlfID, id, buf, serverHalf)
+ 			}
+ 		}
+ 	}()","Please expand ""later behavior"". Presumably something to do with the prefetch logic?",Is it possible to use `context` instead of `go`?
+5344,"@@ -66,7 +66,7 @@ func (s *server) splitUpload(ctx context.Context, r io.ReadCloser, l int64) (int
+ 		response.Message = ""upload error""
+ 		response.Code = http.StatusInternalServerError
+ 		err = fmt.Errorf(""%s: %v"", response.Message, err)
+-		return response, err
++		return swarm.ZeroAddress, err
+ 	}
+ 	return bytesPostResponse{Reference: address}, nil
+ }","The `response` variable is not used, it can be removed, also the fmt.Errorf.",Can we get rid of the `bytesPostResponse` as well? It's not used anywhere else in the code base.
+5345,"@@ -51,10 +51,7 @@ namespace NLog.Internal
+         internal static bool IsNullOrWhiteSpace(string value)
+         {
+ #if NET3_5
+-
+-            if (value == null) return true;
+-            if (value.Length == 0) return true;
+-            return String.IsNullOrEmpty(value.Trim());
++            return value?.Length > 0 ? string.IsNullOrEmpty(value.Trim()) : true;
+ #else
+             return string.IsNullOrWhiteSpace(value);
+ #endif",Do you find this really easier to read?,I wonder if this should be `value?.Length > 0`?
+5346,"@@ -11388,8 +11388,9 @@ void RelRoot::setMvBindContext(MvBindContext * pMvBindContext)
+   pMvBindContextForScope_ = pMvBindContext;
+ }
+
+-void RelRoot::addOneRowAggregates(BindWA* bindWA)
++NABoolean RelRoot::addOneRowAggregates(BindWA* bindWA, NABoolean forceGroupByAgg)
+ {
++  NABoolean GroupByAggNodeAdded = FALSE;
+   RelExpr * childOfRoot = child(0);
+   GroupByAgg *aggNode = NULL;
+   // If the One Row Subquery is already enforced by a scalar aggregate",A small nit: This variable should start with a lower case letter.,"Wouldn't it be better to pass a bool that indicates if this is a one-row aggregation, and if so,"
+5347,"@@ -38,12 +38,13 @@ public class PageStreamingTransformer {
+
+       PageStreamingDescriptorView.Builder descriptor = PageStreamingDescriptorView.newBuilder();
+       descriptor.varName(context.getNamer().getPageStreamingDescriptorName(method));
+-      descriptor.requestTokenFieldName(pageStreaming.getRequestTokenField().getSimpleName());
++      descriptor.requestTokenFieldName(context.getNamer().getRequestTokenFieldName(pageStreaming));
+       if (pageStreaming.hasPageSizeField()) {
+-        descriptor.requestPageSizeFieldName(pageStreaming.getPageSizeField().getSimpleName());
++        descriptor.requestPageSizeFieldName(context.getNamer().getPageSizeFieldName(pageStreaming));
+       }
+-      descriptor.responseTokenFieldName(pageStreaming.getResponseTokenField().getSimpleName());
+-      descriptor.resourcesFieldName(pageStreaming.getResourcesFieldName());
++      descriptor.responseTokenFieldName(
++          context.getNamer().getResponseTokenFieldName(pageStreaming));
++      descriptor.resourcesFieldName(context.getNamer().getResourcesFieldName(pageStreaming));
+       descriptor.methodName(context.getNamer().getMethodKey(method));
+
+       descriptors.add(descriptor.build());",Where is this used for Node?,Does it make sense to have a `PageStreamingDescriptorView.Builder` as the other page streaming v
+5348,"@@ -130,14 +130,14 @@ func (c *Command) handleActions(line string) {
+
+ func (c *Command) connect(argsString string) {
+ 	if len(argsString) == 0 {
+-		info(""Press tab to select identity or create a new one. Connect <your-identity> <node-identity>"")
++		info(""Press tab to select identity or create a new one. Connect <your-id> <provider-id>"")
+ 		return
+ 	}
+
+ 	identities := strings.Fields(argsString)
+
+ 	if len(identities) != 2 {
+-		info(""Please type in the node identity. Connect <your-identity> <node-identity>"")
++		info(""Please type in the provider identity. Connect <your-id> <provider-id>"")
+ 		return
+ 	}
+ ","Is `<your-id>` really easier to understand than `<your-identity>` for CLI user? For me, `identity` seems like a concept we use publicly, and `id` is just an internal shortcut for it.",Should we also update the info output on the node identity page too?
+5349,"@@ -39,7 +39,11 @@ func (n *NetworkPolicyController) addClusterGroup(curObj interface{}) {
+ 	key := internalGroupKeyFunc(cg)
+ 	klog.V(2).Infof(""Processing ADD event for ClusterGroup %s"", cg.Name)
+ 	newGroup := n.processClusterGroup(cg)
+-	klog.V(2).Infof(""Creating new internal Group %s with selector (%s)"", newGroup.UID, newGroup.Selector.NormalizedName)
++	if newGroup.ServiceReference != nil {
++		klog.V(2).Infof(""Creating new internal Group %s for Service %s/%s"", newGroup.UID, newGroup.ServiceReference.Namespace, newGroup.ServiceReference.Name)
++	} else if newGroup.Selector != nil {
++		klog.V(2).Infof(""Creating new internal Group %s with selector (%s)"", newGroup.UID, newGroup.Selector.NormalizedName)
++	}
+ 	n.internalGroupStore.Create(newGroup)
+ 	n.enqueueInternalGroup(key)
+ }",nit.. `if` .. `else` for logging probably can be avoided.. maybe only log that an internal group was created for cluster group,is this correct if `newGroup.ServiceReference` is `nil`?
+5350,"@@ -21,6 +21,7 @@ import (
+ 	""time""
+
+ 	""github.com/aws/amazon-ecs-agent/agent/api""
++	""github.com/aws/amazon-ecs-agent/agent/config""
+ 	""github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks""
+ 	""github.com/aws/amazon-ecs-agent/agent/engine/testdata""
+ 	""github.com/aws/amazon-ecs-agent/agent/eventstream""",There's a lot of changed tests -- but no new tests. You need unit and integration tests for this.,I'm guessing you didn't mean to include this in the PR?
+5351,"@@ -38,16 +38,16 @@ namespace Nethermind.TxPool.Filters
+             _configuredGasLimit = txPoolConfig.GasLimit ?? long.MaxValue;
+         }
+
+-        public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions handlingOptions)
++        public AcceptTxResult Accept(Transaction tx, TxHandlingOptions handlingOptions)
+         {
+             long gasLimit = Math.Min(_chainHeadInfoProvider.BlockGasLimit ?? long.MaxValue, _configuredGasLimit);
+             if (tx.GasLimit > gasLimit)
+             {
+                 if (_logger.IsTrace) _logger.Trace($""Skipped adding transaction {tx.ToString(""  "")}, gas limit exceeded."");
+-                return (false, AddTxResult.GasLimitExceeded);
++                return AcceptTxResult.GasLimitExceeded;
+             }
+
+-            return (true, null);
++            return AcceptTxResult.Accepted;
+         }
+     }
+ }",WithMessage what gas limit is?,Shouldn't this check be `!` instead of `!`?
+5352,"@@ -2099,7 +2099,7 @@ describe('Cursor', function() {
+    * @ignore
+    * @api private
+    */
+-  it('cursor stream errors', {
++  it.skip('cursor stream errors', {
+     // Add a tag that our runner can trigger on
+     // in this case we are setting that node needs to be higher than 0.10.X to run
+     metadata: { requires: { topology: ['single'] } },",Why are these skipped?,does this one need to be skipped?
+5353,"@@ -388,6 +388,13 @@ type MetaManager struct {
+ 	// RemoteQueryTimeout indicates remote query timeout (second)
+ 	// default 60
+ 	RemoteQueryTimeout int32 `json:""remoteQueryTimeout,omitempty""`
++	// The config of MetaServer
++	MetaServer `json:""metaServer,omitempty""`
++}
++
++type MetaServer struct {
++	Enable bool
++	Debug  bool
+ }
+
+ // ServiceBus indicates the ServiceBus module config","We'd better add the `json:""metaServer,omitempty""` here",The naming of this is `MetaServer
+5354,"@@ -0,0 +1,17 @@
++#!/usr/bin/env python3
++import platform
++import sys
++from pathlib import Path
++from subprocess import check_call
++
++here = Path(__file__).parent
++
++pip_install = [
++    sys.executable, ""-m"",
++    ""pip"",
++    ""install"",
++    ""--disable-pip-version-check"",
++]
++
++check_call([*pip_install, ""--require-hashes"", ""-r"", f""requirements-{platform.system().lower()}.txt""], cwd=here)
++check_call([*pip_install, ""--no-deps"", ""-e"", ""../..""], cwd=here)","So... when we want to install mitmproxy with pinned dependencies, we first install all pinned dependencies, and then in a second step install mitmproxy as editable, making sure that no additional dependencies are sneaking in.  ",Would it make sense to move this
+5355,"@@ -68,7 +68,10 @@ func Sandbox(args []string) error {
+ 		}
+ 	}
+ 	err = syscall.Exec(cmd, args, env)
+-	return fmt.Errorf(""Failed to exec %s: %s"", cmd, err)
++	if err != nil {
++		return fmt.Errorf(""Failed to exec %s: %s"", cmd, err)
++	}
++	return nil
+ }
+
+ func rewriteEnvVars(env []string, from, to string) {","not sure how this got in master, but the linter is unhappy about it so I fixed it here","return err directly, no need to r"
+5356,"@@ -15,3 +15,8 @@ const rekeyRecheckInterval = 30 * time.Second
+
+ // rekeyInitialTTL is the maximum number rechecks each rekey request can trigger.
+ const rekeyInitialTTL = 4
++
++// mdserverReconnectBackoffWindow is a backoff window within which we try to
++// wait randomly for before reconnecting to MD server.
++// TODO: increase this to 5 min
++const mdserverReconnectBackoffWindow = 5 * time.Minute","No need for this TODO anymore, right?",mdserverReconnectBackoffWindow is a backoff window within which we try to reconnect to MD server.
+5357,"@@ -47,7 +47,8 @@ def main(global_config, config=None, **settings):
+
+     # In Kinto API 1.x, a default bucket is available.
+     # Force its inclusion if not specified in settings.
+-    if 'kinto.plugins.default_bucket' not in settings['includes']:
++    if 'kinto.plugins.default_bucket' not in settings['includes'] \
++	 and 'kinto.plugins.default_bucket' not in settings['excludes']:
+         config.include('kinto.plugins.default_bucket')
+
+     # Retro-compatibility with first Kinto clients.","I would assign the key you're looking for into a variable first, and then use it in the comparisons.",Why not do `'kinto.plugins.default_bucket' not in settings['includes']` directly?
+5358,"@@ -855,6 +855,9 @@ class PluginManager
+         if ($pluginPath = self::instance()->getPluginPath($id)) {
+             File::deleteDirectory($pluginPath);
+         }
++
++        // actually remove the plugin from our internal container
++        unset($this->plugins[ $this->normalizeIdentifier($id) ]);
+     }
+
+     /**",Would be better to normalize it at the start of the method to pass through to all the other calls,What is the point of this method?
+5359,"@@ -167,6 +167,7 @@ class CodeEditor extends FormWidgetBase
+         $this->vars['highlightActiveLine'] = $this->highlightActiveLine;
+         $this->vars['useSoftTabs'] = $this->useSoftTabs;
+         $this->vars['showGutter'] = $this->showGutter;
++        $this->vars['safeMode'] = $this->parentForm->model->isSafeMode();
+         $this->vars['language'] = $this->language;
+         $this->vars['margin'] = $this->margin;
+         $this->vars['stretch'] = $this->formField->stretch;",This can't exist here either because the code editor can be used on other models than CMS templates. You could probably implement this as a `hint` property (so `hint: cms::lang.cms_object.safe_mode_enabled`) on the codeeditor formwidget instead though and I'd be fine with that.,hmm why did you move this line here?
+5360,"@@ -888,6 +888,15 @@ class WordDocumentTextInfo(textInfos.TextInfo):
+ 			field['line-prefix']=mapPUAToUnicode.get(bullet,bullet)
+ 		return field
+
++	def scrollIntoView(self):
++		try:
++			self.obj.WinwordWindowObject.ScrollIntoView(self._rangeObj, True)
++		except COMError:
++			log.exception(""Can't scroll"")
++			pass
++
++
++
+ 	def expand(self,unit):
+ 		if unit==textInfos.UNIT_LINE:
+ 			try:",This line is unnecessary.,"Could you add `__doc__` to this function, please?"
+5361,"@@ -119,13 +119,4 @@ Recorder::~Recorder() {
+   UpdateBoundary();
+ }
+
+-void Recorder::Log(unsigned id) {
+-#ifndef LLDB_REPRO_INSTR_TRACE
+-  LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), ""Recording {0}: {1}"", id,
+-           m_pretty_func);
+-#else
+-  llvm::errs() << ""Recording "" << id << "": "" << m_pretty_func << ""\n"";
+-#endif
+-}
+-
+ bool lldb_private::repro::Recorder::g_global_boundary;",How did this compile in the first place? Is there a matching declaration in a header that should be removed too?,Do we still need to call `Recorder::Log`?
+5362,"@@ -56,7 +56,8 @@ mrb_value h2o_mruby__new_str(mrb_state *mrb, const char *s, size_t len, const ch
+     if (mrb->exc != NULL)
+         h2o_mruby__abort_exc(mrb, ""h2o_mruby_new_str:precondition failure"", file, line);
+     mrb_value ret = mrb_str_new(mrb, s, len);
+-    h2o_mruby_assert(mrb);
++    if (mrb->exc != NULL)
++        h2o_mruby__abort_exc(mrb, ""h2o_mruby_new_str:failed to create string:"", file, line);
+     return ret;
+ }
+ ","Please remove the colon at the end, and merge the PR once the CI succeeds. Thank you for the PR.",wouldn't it be better to use h2o_mruby_assert her
+5363,"@@ -3,8 +3,5 @@
+ package tools
+
+ import (
+-	_ ""github.com/AlekSi/gocoverutil""
+ 	_ ""github.com/golang/protobuf/protoc-gen-go""
+-	_ ""github.com/jteeuwen/go-bindata/go-bindata""
+-	_ ""github.com/mattn/goveralls""
+ )","whoops. this should be protoc-gen-doc, since that is the only bit left that is built out-of-tree (everything else is either downloaded or built via modules already depended on by spire's go.mod)",Please don't remove these
+5364,"@@ -0,0 +1,19 @@
++package azkaban.spi;
++
++import java.util.Map;
++
++/**
++ * Implement this interface to report flow and job events. Event reporter
++ * can be turned on by setting the property {@code AZKABAN_EVENT_REPORTING_ENABLED} to true.
++ *
++ * By default, a KafkaAvroEventReporter is provided. Alternate implementations
++ * can be provided by setting the property {@code AZKABAN_EVENT_REPORTING_CLASS_PARAM}
++ * <br><br>
++ * The constructor will be called with a {@code azkaban.utils.Props} object passed as
++ * the only parameter. If such a constructor doesn't exist, then the AzkabanEventReporter
++ * instantiation will fail.
++ */
++public interface AzkabanEventReporter {
++
++  boolean report(EventType eventType, Map<String, String> metadata);
++}",The convention is to use <p> see the google style guide and use checkstyle to check. You can change it later.,Also not sure if this is the right place for this. The `AzkabanEventReporter` is not the right place for this.
+5365,"@@ -134,12 +134,14 @@ class ListElement(list):
+     def startElement(self, name, attrs, connection):
+         for lm in self.list_marker:
+             if name.endswith(lm):
+-                l = ListElement(self.connection, name, self.item_marker,
++                l = ListElement(self.connection, name, self.list_marker,
++                                self.item_marker,
+                                 pythonize_name=self.pythonize_name)
+                 setattr(self, self.get_name(name), l)
+                 return l
+         if name in self.item_marker:
+             e = Element(self.connection, name, parent=self,
++                        self.list_marker, self.item_marker,
+                         pythonize_name=self.pythonize_name)
+             self.append(e)
+             return e",Using non-keyword args after the keyword arg (parent-self) will cause a SyntaxError.,"nit: move ""name in self.list_marker"" outside of the for loop"
+5366,"@@ -277,6 +277,13 @@ module Faker
+         '%08x-%04x-%04x-%04x-%04x%08x' % ary # rubocop:disable Style/FormatString
+       end
+
++      def user(*args)
++        user_hash = {}
++        args = %w[username email] if args.empty?
++        args.each { |arg| user_hash[:""#{arg}""] = send(arg) }
++        user_hash
++      end
++
+       alias user_name username
+     end
+   end",I think you'll want to add some YARD docs to this method to get the PR approved  ,"In Ruby 2.3, you can just use `args.map { |arg| user_hash[arg] = send(arg) }`"
+5367,"@@ -4452,12 +4452,13 @@ ostree_repo_query_object_storage_size (OstreeRepo           *self,
+  * @self: Repo
+  * @objtype: Object type
+  * @sha256: ASCII checksum
+- * @out_variant: (out) (transfer full): Metadata
++ * @out_variant: (out) (nullable) (transfer full): Metadata
+  * @error: Error
+  *
+  * Attempt to load the metadata object @sha256 of type @objtype if it
+  * exists, storing the result in @out_variant.  If it doesn't exist,
+- * %NULL is returned.
++ * @out_variant will be set to %NULL and the function will still
++ * return TRUE.
+  */
+ gboolean
+ ostree_repo_load_variant_if_exists (OstreeRepo       *self,","Hmm, AFAICT `*out_variant` isn't explicitly set to `NULL` in the `ENOENT` case.","This should be ""not NULL"" instead of ""NULL"""
+5368,"@@ -87,12 +87,18 @@ func (b *clientFactory) SDKClient(c *cli.Context, namespace string) sdkclient.Cl
+ 		hostPort = localHostPort
+ 	}
+
++	tlsConfig, err := b.createTLSConfig(c)
++	if err != nil {
++		b.logger.Fatal(""Failed to create SDK client"", zap.Error(err))
++	}
++
+ 	sdkClient, err := sdkclient.NewClient(sdkclient.Options{
+ 		HostPort:  hostPort,
+ 		Namespace: namespace,
+ 		Logger:    log.NewZapAdapter(b.logger),
+ 		ConnectionOptions: sdkclient.ConnectionOptions{
+ 			DisableHealthCheck: true,
++			TLS:                tlsConfig,
+ 		},
+ 	})
+ 	if err != nil {","Nit: ""Failed to configure TLS for SDK client""?",This should be `err := b.createTLSConfig(c)`
+5369,"@@ -89,7 +89,7 @@ def test_plot_split_value_histogram(params, breast_cancer_split, train_data):
+                                          title='Histogram for feature @index/name@ @feature@',
+                                          xlabel='x', ylabel='y', color='r')
+     assert isinstance(ax1, matplotlib.axes.Axes)
+-    title = 'Histogram for feature name {}'.format(gbm1.booster_.feature_name()[27])
++    title = f'Histogram for feature name {gbm1.booster_.feature_name()[27]}'
+     assert ax1.get_title() == title
+     assert ax1.get_xlabel() == 'x'
+     assert ax1.get_ylabel() == 'y'",please update your branch to the latest `master`. This change was already made in #4359,This should be left as `'Histogram for featu
+5370,"@@ -18,6 +18,8 @@ import (
+ 	""crypto/sha1""
+ 	""errors""
+ 	""fmt""
++	""github.com/pingcap/chaos-mesh/controllers""
++	""time""
+
+ 	""golang.org/x/sync/errgroup""
+ ",This line should be formatted,I think we can remove this import now
+5371,"@@ -32,6 +32,9 @@ int main (int argc, char * const * argv)
+ 		(""disable_unchecked_drop"", ""Disables drop of unchecked table at startup"")
+ 		(""fast_bootstrap"", ""Increase bootstrap speed for high end nodes with higher limits"")
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
++		(""block_processor_batch_size"",boost::program_options::value<std::size_t> (), ""Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time)"")
++		(""block_processor_full_size"",boost::program_options::value<std::size_t> (), ""Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536"")
++		(""block_processor_verification_size"",boost::program_options::value<std::size_t> (), ""Increase batch signature verification size in block processor, default 0 (2048 * signature checker threads + 1)"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
+ 		(""debug_dump_online_weight"", ""Dump online_weights table"")","""default 65536"" Not sure if it's important to state, but block_processor_full_size has a different default for fast_bootstrap.",I think the name `block_processor_batch_size
+5372,"@@ -23,5 +23,6 @@ namespace Nethermind.TxPool
+         public uint FutureNonceRetention { get; set; } = 16;
+         public int HashCacheSize { get; set; } = 512 * 1024;
+         public long? GasLimit { get; set; } = null;
++
+     }
+ }",remove unnecessary whitespace changes,Please remove unnecessary change.
+5373,"@@ -46,10 +46,6 @@ func TxnPool(s *transactions.SignedTxn, spec transactions.SpecialAddresses, prot
+ 		return errors.New(""empty address"")
+ 	}
+
+-	if s.Sig != (crypto.Signature{}) && !s.Msig.Blank() {
+-		return errors.New(""signedtxn should only have one of Sig or Msig"")
+-	}
+-
+ 	outCh := make(chan error, 1)
+ 	cx := asyncVerifyContext{s, outCh, &proto}
+ 	verificationPool.EnqueueBacklog(context.Background(), stxnAsyncVerify, &cx, nil)",Are these conditions covered elsewhere ?,why delete this?
+5374,"@@ -59,7 +59,14 @@ TurnType::Enum IntersectionHandler::findBasicTurnType(const EdgeID via_edge,
+     if (!on_ramp && onto_ramp)
+         return TurnType::OnRamp;
+
+-    if (in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAMEID)
++    const auto same_name =
++        !util::guidance::requiresNameAnnounced(name_table.GetNameForID(in_data.name_id),
++                                               name_table.GetRefForID(in_data.name_id),
++                                               name_table.GetNameForID(out_data.name_id),
++                                               name_table.GetRefForID(out_data.name_id),
++                                               street_name_suffix_table);
++
++    if (in_data.name_id != EMPTY_NAMEID && out_data.name_id != EMPTY_NAMEID && same_name)
+     {
+         return TurnType::Continue;
+     }",the above check (by transitivity) checked for `in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAME_ID && out_data.name_id != EMPTY_NAME_ID`. The final check of `out_data.name_id != EMPTY_NAME_ID` is missing now.,What's the purpose of this?
+5375,"@@ -583,6 +583,11 @@ out_free:
+
+ fpga_result __FPGA_API__ fpgaDestroyEventHandle(fpga_event_handle *event_handle)
+ {
++	//sanity check
++	if (!event_handle) {
++		return FPGA_INVALID_PARAM;
++	}
++
+ 	struct _fpga_event_handle *_eh = (struct _fpga_event_handle *) *event_handle;
+ 	fpga_result result = FPGA_OK;
+ 	int err = 0;","The event handle is being passed by reference, so the dereference on 591 is actually correct. To follow the convention that variables be declared before executable statements, please change the code to the following: struct _fpga_event_handle *_eh; fpga_result result = FPGA_OK; int err = 0; if (!event_handle) { return FPGA_INVALID_PARAM; } _eh = (struct _fpga_event_handle *) *event_handle;",Why is this check needed?
+5376,"@@ -42,6 +42,7 @@ class named_mutex;
+ #include ""../plugins/nearest.hpp""
+ #include ""../plugins/timestamp.hpp""
+ #include ""../plugins/viaroute.hpp""
++#include ""../plugins/map_matching.hpp""
+ #include ""../server/data_structures/datafacade_base.hpp""
+ #include ""../server/data_structures/internal_datafacade.hpp""
+ #include ""../server/data_structures/shared_barriers.hpp""",reorder includes to be alphabetically ordered,"You are not using `map_matching.hpp` yet, right?"
+5377,"@@ -13,7 +13,8 @@ def anchor_target(anchor_list,
+                   cfg,
+                   gt_labels_list=None,
+                   cls_out_channels=1,
+-                  sampling=True):
++                  sampling=True,
++                  need_unmap=True):
+     """"""Compute regression and classification targets for anchors.
+
+     Args:",Rename `need_unmap` to `unmap`.,Just noticed that `need_unmap` isn't used in thi
+5378,"@@ -26,7 +26,6 @@ import (
+ 	""sigs.k8s.io/controller-runtime/pkg/client""
+
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common""
+-	cm ""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/iochaos""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/stresschaos""","In line 28, it has been declared twice, so removing `cm` should not impact, can you explain me little bit? :)",Why was this removed?
+5379,"@@ -16,7 +16,10 @@ import (
+
+ const Name = ""clutch.service.topology""
+
+-type Service interface{}
++type Service interface {
++	acquireTopologyCacheLock()
++	startTopologyCache()
++}
+
+ type client struct {
+ 	config *topologyv1.Config","i don't think these unexported functions belong on the public interface, they can exist solely on the struct.",Why are we locking here? Why not startTopologyCa
+5380,"@@ -263,6 +263,13 @@ func (h Helper) NewBindAddresses(addrs []string) []ConfigValue {
+ 	return []ConfigValue{{Class: ""bind"", Value: addrs}}
+ }
+
++// WithDispenser returns a new instance based on d. All others Helper
++// fields are copied, so typically maps are shared with this new instance.
++func (h Helper) WithDispenser(d *caddyfile.Dispenser) Helper {
++	h.Dispenser = d
++	return h
++}
++
+ // ParseSegmentAsSubroute parses the segment such that its subdirectives
+ // are themselves treated as directives, from which a subroute is built
+ // and returned.",I'm not entirely clear on why this is necessary?,"Not sure if `WithDispenser` is the best name, but I couldn't come up with a better one."
+5381,"@@ -317,7 +317,7 @@ def save_session(fname="""", session=None, pickleProto=-1):
+     if not fname:
+         fname = conf.session
+         if not fname:
+-            conf.session = fname = utils.get_temp_file(keep=True)
++            conf.session = fname = cast(str, utils.get_temp_file(keep=True))
+     log_interactive.info(""Use [%s] as session file"" % fname)
+
+     if not session:",Why do we need to cast to `str` here?,how about `if fname is not None:`?
+5382,"@@ -17,7 +17,6 @@ import org.testfx.api.FxToolkit;
+ public class AppConfigurationInitialisationTest {
+
+ 	@Test
+-	@Ignore
+ 	public void testAppConfigurationInitialisation() throws TimeoutException {
+ 		FxToolkit.registerPrimaryStage();
+ 		FxToolkit.setupFixture(() -> new AnnotationConfigApplicationContext(AppConfiguration.class));",The ignore import above should be unused now and can be removed.,`FxToolkit.registerPrimaryStage()` should be removed as well.
+5383,"@@ -231,4 +231,12 @@ final class MultiTermQueryConstantScoreWrapper<Q extends MultiTermQuery> extends
+
+     };
+   }
++
++  @Override
++  public void visit(QueryVisitor visitor) {
++    QueryVisitor v = visitor.getSubVisitor(Occur.FILTER, this);
++    if (v != null) {
++      query.visit(v);
++    }
++  }
+ }",redundant null check?,Maybe add a `null` check for `query` as well?
+5384,"@@ -11,5 +11,5 @@ func NewRAMDevice() (*sonm.RAMDevice, error) {
+ 		return nil, err
+ 	}
+
+-	return &sonm.RAMDevice{Total: m.Total}, err
++	return &sonm.RAMDevice{Total: m.Total, Available: m.Total}, err
+ }",initialization of available ram is here,Also need to set `Available: m.Available` here.
+5385,"@@ -603,8 +603,12 @@ Blockly.Field.prototype.getDisplayText_ = function() {
+   // Replace whitespace with non-breaking spaces so the text doesn't collapse.
+   text = text.replace(/\s/g, Blockly.Field.NBSP);
+   if (this.sourceBlock_.RTL) {
+-    // The SVG is LTR, force text to be RTL.
+-    text += '\u200F';
++    // The SVG is LTR, force text to be RTL unless a number.
++    if (this.sourceBlock_.editable_ && this.sourceBlock_.type === 'math_number') {
++      text += '\u200E';
++    } else {
++      text = '\u202B' + text + '\u202C';
++    }
+   }
+   return text;
+ };",Can have negative numbers with the '-' on the right (`10-`) by just using line 610.,Do we have any unit test coverage for this?
+5386,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteUser.java demonstrates how to delete an AWS Identity and Access Management (IAM) user. This is only possible for users with no associated resources.]
++//snippet-sourcedescription:[DeleteUser.java demonstrates how to delete an AWS Identity and Access Management (AWS IAM) user. This is only possible for users with no associated resources.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),shouldn't this be `//snippet-service:[AWS IAM I
+5387,"@@ -2381,11 +2381,10 @@ class ThriftRequestHandler(object):
+                 check_commands, check_durations, cc_version, statistics = \
+                     store_handler.metadata_info(metadata_file)
+
+-                if len(check_commands) == 0:
+-                    command = ' '.join(sys.argv)
+-                elif len(check_commands) == 1:
++                command = ''
++                if len(check_commands) == 1:
+                     command = ' '.join(check_commands[0])
+-                else:
++                elif len(check_commands) > 1:
+                     command = ""multiple analyze calls: "" + \
+                               '; '.join([' '.join(com)
+                                          for com in check_commands])",Shouldn't we use store a message which indicates that there was no available checker command? By the way how is it possible that metadata.json doesn't contain the checker command? Maybe this was the case in the earlier versions?,"I'm not sure about this change, but I think it'"
+5388,"@@ -32,6 +32,10 @@ module RSpec
+         @exclusion_patterns = true_or_false ? [] : DEFAULT_EXCLUSION_PATTERNS.dup
+       end
+
++      def full_backtrace
++        @exclusion_patterns.empty?
++      end
++
+       private
+
+       def matches_an_exclusion_pattern?(line)","Given that this is a boolean predicate, maybe it should be `full_backtrace?`.",do you need to dup here? I think you can just do @exclusion_patterns.empty?
+5389,"@@ -12,7 +12,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.""""""
+
+-import ldap, traceback
++import traceback
++
++import ldap
+ from django.conf import settings
+ from django.contrib.auth.models import User
+ ",Just curious why the blank line here?,Please don't add extra newlines
+5390,"@@ -1,3 +1,3 @@
+ from __future__ import (absolute_import, print_function, division)
+
+-from netlib.version import *
++from mitmproxy.version import *","I like the idea, but we don't want a dependency on mitmproxy in pathod.",That's the only change in this file. Why did you change it?
+5391,"@@ -49,6 +49,16 @@ namespace Datadog.Trace
+
+         private TimeSpan Elapsed => StopwatchHelpers.GetElapsed(Stopwatch.GetTimestamp() - _timestamp);
+
++        /// <summary>
++        /// Gets or sets a collection of propagated internal Datadog tags,
++        /// formatted as ""key1=value1,key2=value2"".
++        /// </summary>
++        /// <remarks>
++        /// We're keeping this as the string representation to avoid having to parse.
++        /// For now, it's relatively easy to append new values when needed.
++        /// </remarks>
++        public string DatadogTags { get; set; }
++
+         public void AddSpan(Span span)
+         {
+             lock (this)",Why not adding this to the interface and keep passing the interface (as the interface is internal I don't get why you're not adding it there),`DatasadogTags` is an `internal` property. I don't think we should expose i
+5392,"@@ -70,6 +70,7 @@ from typing import Pattern, Tuple
+
+ import astroid
+ from astroid import nodes
++from astroid.const import PY310_PLUS
+
+ from pylint.checkers import BaseChecker, utils
+ from pylint.checkers.utils import (",`PY310` should probably be imported from `pylint.const`,I would prefer to keep this import in each file where it is used.
+5393,"@@ -37,6 +37,14 @@ func (w workflowLoggable) GetValue(key string) string {
+ 	return w.wf.GetSerialConsoleOutputValue(key)
+ }
+
++func (w workflowLoggable) GetValueAsBool(key string) bool {
++	v, err := strconv.ParseBool(w.wf.GetSerialConsoleOutputValue(key))
++	if err != nil {
++		return false
++	}
++	return v
++}
++
+ func (w workflowLoggable) GetValueAsInt64Slice(key string) []int64 {
+ 	return getInt64Values(w.wf.GetSerialConsoleOutputValue(key))
+ }",Can we propagate this error up the stack?,do we have a unit test for this?
+5394,"@@ -83,7 +83,12 @@ public:
+                              const table& result_values) {
+         auto reference = compute_reference(sigma, x_data, y_data);
+         const double tol = te::get_tolerance<Float>(1e-4, 1e-9);
+-        const double diff = la::l_inf_norm(reference, la::matrix<double>::wrap(result_values));
++        const table reference_table = dal::detail::homogen_table_builder{}
++                                          .reset(reference.get_array(),
++                                                 reference.get_row_count(),
++                                                 reference.get_column_count())
++                                          .build();
++        const double diff = te::abs_error(reference_table, result_values);
+         CHECK(diff < tol);
+     }
+ ",Why reference is converted to table?,"reference.get_row_count(), reference.get_column_count() wouldn't "
+5395,"@@ -203,16 +203,15 @@ struct roots_view *view_at(struct roots_desktop *desktop, double lx, double ly,
+ struct roots_desktop *desktop_create(struct roots_server *server,
+ 		struct roots_config *config) {
+ 	struct roots_desktop *desktop = calloc(1, sizeof(struct roots_desktop));
++	assert(desktop);
+ 	wlr_log(L_DEBUG, ""Initializing roots desktop"");
+
+ 	assert(desktop->views = list_create());
+ 	wl_list_init(&desktop->outputs);
+-	wl_list_init(&desktop->output_add.link);
+-	desktop->output_add.notify = output_add_notify;
+-	wl_list_init(&desktop->output_remove.link);
+-	desktop->output_remove.notify = output_remove_notify;
+
++	desktop->output_add.notify = output_add_notify;
+ 	wl_signal_add(&server->backend->events.output_add, &desktop->output_add);
++	desktop->output_remove.notify = output_remove_notify;
+ 	wl_signal_add(&server->backend->events.output_remove,
+ 		&desktop->output_remove);
+ ",You shouldn't use assert for runtime errors.,I think we need to free `desktop->output_add.notify` after `wl_li
+5396,"@@ -15,6 +15,7 @@ return array(
+         'vendor/bootstrap.min.js',
+         'vendor/bootstrap-accessibility.min.js',
+         'vendor/validator.min.js',
++        'vendor/form-attr-polyfill.js', // input[form] polyfill, cannot load conditionally, since we need all versions of IE
+         'autocomplete.js',
+         'common.js',
+         'lightbox.js',","Does this really belong in the vendor directory if you wrote it? At very least, should it get its own repo somewhere in addition to being dropped here?",I think we need to include the polyfills for `amp-form` as well.
+5397,"@@ -78,7 +78,7 @@ public class PMDTaskTest {
+             String actual = IOUtils.toString(in, StandardCharsets.UTF_8);
+             // remove any trailing newline
+             actual = actual.replaceAll(""\n|\r"", """");
+-            Assert.assertEquals(""sample.dummy:0:\tTest Rule 2"", actual);
++            Assert.assertEquals(""sample.dummy:0:\tTest Rule 2:\tSampleXPathRule"", actual);
+         }
+     }
+ }",I think it would be better to place the rule name before the message. Messages are of varying lengths and the rule names will end up misaligned,What is the purpose of this change?
+5398,"@@ -1719,7 +1719,12 @@ class ComparisonChecker(_BasicChecker):
+                       'Used when comparing an object to a literal, which is usually '
+                       'what you do not want to do, since you can compare to a different '
+                       'literal than what was expected altogether.'),
+-           }
++            'R0124': ('Logical tautology in comparison - %s',
++                      'logical-tautology',
++                      'Used when something is compared against itself.',
++                      ),
++
++            }
+
+     def _check_singleton_comparison(self, singleton, root_node, negative_check=False):
+         if singleton.value is True:",Can we remove the argument from this message? A message will include a line number already that points to the place in the code that has the problem. I think we can remove it.,"Hi @PierreBesson, I think that the name is not very descriptive."
+5399,"@@ -174,7 +174,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
+             _requestBodyMinimumDataRateNotSatisfied(_logger, connectionId, traceIdentifier, rate, null);
+         }
+
+-        public void ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)
++        public virtual void ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)
+         {
+             _responseMinimumDataRateNotSatisfied(_logger, connectionId, traceIdentifier, null);
+         }","This whole class is now a mix of virtual and non-virtual. I tried to see what would happen if I made everything non-virtual in dev, and the build still passes. It turns out that none of the other methods actually need to be virtual. Can you make *all* the logging methods either virtual or not for consistency? Thanks.",Why make this virtual?
+5400,"@@ -58,6 +58,12 @@ var (
+ 		Value: metadata.DefaultNetwork.AccessPolicyOracleAddress,
+ 	})
+
++	mmnAddressFlag = altsrc.NewStringFlag(cli.StringFlag{
++		Name:  ""mmn-address"",
++		Usage: ""URL of my.mysterium.network API"",
++		Value: metadata.DefaultNetwork.MMNAddress,
++	})
++
+ 	brokerAddressFlag = altsrc.NewStringFlag(cli.StringFlag{
+ 		Name:  ""broker-address"",
+ 		Usage: ""URI of message broker"",","This looks a bit cryptic to me, and also it contains a dash. How about `mymysterium.url`?",minor nit: `my.mysterium.network API` -> `my.mysterium.network configuration`
+5401,"@@ -0,0 +1,8 @@
++#include<stdio.h>
++
++void main(){
++	int var = 100;
++	if (&var == 0){
++		print(""Got the value"");
++	}
++}","You did notice the no newline at the end of this file, right?",please add a license header like the other files
+5402,"@@ -75,10 +75,10 @@ namespace Microsoft.CodeAnalysis.Sarif
+         public ISet<Stack> Stacks { get; set; }
+
+         /// <summary>
+-        /// An array of arrays of 'annotatedCodeLocation` objects, each inner array of which comprises a code flow (a possible execution path through the code).
++        /// An array of 'codeFlow' objects relevant to the result.
+         /// </summary>
+         [DataMember(Name = ""codeFlows"", IsRequired = false, EmitDefaultValue = false)]
+-        public IList<IList<AnnotatedCodeLocation>> CodeFlows { get; set; }
++        public ISet<CodeFlow> CodeFlows { get; set; }
+
+         /// <summary>
+         /// A grouped set of locations and messages, if available, that represent code areas that are related to this result.","Here's the object model change. `CodeFlows` is a set of objects of type `CodeFlow`, rather than a list of list of `AnnotatedCodeLocation`. Exactly parallel with `Stacks`.",This is a breaking change. We need to keep the old data member name here.
+5403,"@@ -31,6 +31,7 @@ from .core import decode_node, encode_node, find_object_hashes, hash_contents, F
+ from .models import (Access, Customer, Instance, Invitation, Log, Package,
+                      S3Blob, Tag, UTF8_GENERAL_CI, Version)
+ from .schemas import LOG_SCHEMA, PACKAGE_SCHEMA
++from .config import BAN_PUBLIC_USERS
+
+ QUILT_CDN = 'https://cdn.quiltdata.com/'
+ ","Sorry, one more thing... You should use `app.config` instead of importing it directly. See the code below.",I think we should only import this if we are going to use it in all the place
+5404,"@@ -44,8 +44,13 @@ public interface VectorizedReader<T> {
+   void setRowGroupInfo(PageReadStore pages, Map<ColumnPath, ColumnChunkMetaData> metadata);
+
+   /**
+-   * Set up the reader to reuse the underlying containers used for storing batches
++   * Setup the reader to reuse the underlying containers used for storing batches
+    */
+   void reuseContainers(boolean reuse);
++
++  /**
++   * Release any resources allocated
++   */
++  void close();
+ }
+ ","This was correct before; ""setup"" is a noun and ""set up"" is the verb form.","I don't think we need to change this interface, since `close` is not public."
+5405,"@@ -61,7 +61,7 @@ class AdSenseSetupWidget extends Component {
+
+ 	async getAccounts() {
+ 		try {
+-			const responseData = await data.get( TYPE_MODULES, 'adsense', 'accounts' );
++			const responseData = await data.get( TYPE_MODULES, 'adsense', 'accounts', { maybeSetAccount: true } );
+
+ 			/**
+ 			 * Defines the account status. Possible values:",What's the reason for this change here? I didn't see it mentioned in the PR and it's a bit of a confusing param name  ,The `maybeSetAccount` option should only be used if the `accountStatus` is `
+5406,"@@ -12,7 +12,9 @@ function Search() {
+ }
+
+ Search.prototype.query = function(q) {
+-  return this.index.search(q)
++	return q === '~'
++		? this.storage.config.localList.get().map( function( package ){ return { ref: package, score: 1 }; } )
++		: this.index.search(q);
+ }
+
+ Search.prototype.add = function(package) {",I wonder why ~ and not a wildcard instead?,Why is this necessary?
+5407,"@@ -63,6 +63,9 @@ public class PojoProducers implements BeanPostProcessor {
+     // aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
+     // 所以，需要先取出原class，再取标注
+     Class<?> beanCls = BeanUtils.getImplClassFromBean(bean);
++    if(beanCls == null) {
++    	return;
++    }
+     RpcSchema rpcSchema = beanCls.getAnnotation(RpcSchema.class);
+     if (rpcSchema == null) {
+       return;","when will this happened? if happened, just ignore it Silently?",Change to use `org.mule.runtime.module.extension.internal.util.BeanUtils#get
+5408,"@@ -239,8 +239,10 @@ public class TestMergeAppend extends TableTestBase {
+   public void testManifestMergeMinCount() throws IOException {
+     Assert.assertEquals(""Table should start empty"", 0, listManifestFiles().size());
+     table.updateProperties().set(TableProperties.MANIFEST_MIN_MERGE_COUNT, ""2"")
+-        // each manifest file is 5227 bytes, so 12000 bytes limit will give us 2 bins with 3 manifest/data files.
+-        .set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, ""12000"")
++        // Each initial v1/v2 ManifestFile is 5661/6397 bytes respectively. Merging two of the given
++        // manifests make one v1/v2 ManifestFile of 5672/6408 bytes respectively, so 12850 bytes
++        // limit will give us two bins with three manifest/data files.
++        .set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, ""12850"")
+         .commit();
+
+     TableMetadata base = readMetadata();","3x the smaller size would be around 17k, and we need it to be at least about 13k, which is 2x the larger size. I'd probably set this to 15k to split the difference and hopefully avoid needing to update this again as tests change. This is minor, though.",Is this related to this PR?
+5409,"@@ -360,7 +360,9 @@ class DateEncoder(Encoder):
+     if input == SENTINEL_VALUE_FOR_MISSING_DATA:
+       output[0:] = 0
+     else:
+-      assert isinstance(input, datetime.datetime)
++      assert isinstance(input, datetime.datetime), (
++          ""Input is type %s, expected datetime. Value: %s"" % (type(input),
++                                                              str(input)))
+
+       # Get the scalar values for each sub-field
+       scalars = self.getScalars(input)","@scottpurdy, strictly speaking, should this scenario raise a ValueError exception instead of AssertionError?",The type should be `str` in
+5410,"@@ -0,0 +1,7 @@
++package azkaban.spi;
++
++public enum ExecutorType {
++  // Type of executor where flow runs
++  BAREMETAL,
++  KUBERNETES
++}",Can you please add open source disclaimer?,No need for an enum. Just u
+5411,"@@ -81,13 +81,11 @@ func (u *unaryHandler) Handle(ctx context.Context, transportRequest *transport.R
+ 	var wireError *wirepb.Error
+ 	if appErr != nil {
+ 		responseWriter.SetApplicationError()
+-		wireError = &wirepb.Error{
+-			appErr.Error(),
+-		}
++		wireError = &wirepb.Error{Message: appErr.Error()}
+ 	}
+ 	wireResponse := &wirepb.Response{
+-		responseData,
+-		wireError,
++		Payload: responseData,
++		Error:   wireError,
+ 	}
+ 	protoBuffer := getBuffer()
+ 	defer putBuffer(protoBuffer)",I dont want to do composite keys on purpose to verify at compile time if the message is completely filled out appropriately @sectioneight,is there a reason for this
+5412,"@@ -1170,6 +1170,8 @@ func TestServer_SendAction(t *testing.T) {
+ 	}}
+
+ 	chain.EXPECT().ChainID().Return(uint32(1)).Times(2)
++	chain.EXPECT().TipHeight().Return(uint64(4)).Times(2)
++	svr.cfg.Genesis.KamchatkaBlockHeight = 10
+ 	ap.EXPECT().Add(gomock.Any(), gomock.Any()).Return(nil).Times(2)
+
+ 	for i, test := range sendActionTests {","don't need this line, since it is not tested in api_test?",Can you make this `EXPECT().TipHeight().Return(uint64(10))` instead?
+5413,"@@ -164,7 +164,7 @@ func CheckForCStorPoolCRD(clientset clientset.Interface) {
+ // CheckForCStorVolumeReplicaCRD is Blocking call for checking status of CStorVolumeReplica CRD.
+ func CheckForCStorVolumeReplicaCRD(clientset clientset.Interface) {
+ 	for {
+-		_, err := clientset.OpenebsV1alpha1().CStorVolumeReplicas().List(metav1.ListOptions{})
++		_, err := clientset.OpenebsV1alpha1().CStorVolumeReplicas("""").List(metav1.ListOptions{})
+ 		if err != nil {
+ 			glog.Errorf(""CStorVolumeReplica CRD not found. Retrying after %v"", CRDRetryInterval)
+ 			time.Sleep(CRDRetryInterval)",Does this mean the list operation is done for all the namespaces? How to list the volume replicas per namespace?,"Is this a bug fix? If not, can you open a separate PR to fix this?"
+5414,"@@ -136,10 +136,14 @@ def batched_nms(bboxes, scores, inds, nms_cfg):
+     Returns:
+         tuple: kept bboxes and indice.
+     """"""
+-    max_coordinate = bboxes.max()
+-    offsets = inds.to(bboxes) * (max_coordinate + 1)
+-    bboxes_for_nms = bboxes + offsets[:, None]
+     nms_cfg_ = nms_cfg.copy()
++    class_agnostic = nms_cfg_.pop('class_agnostic', False)
++    if not class_agnostic:
++        max_coordinate = bboxes.max()
++        offsets = inds.to(bboxes) * (max_coordinate + 1)
++        bboxes_for_nms = bboxes + offsets[:, None]
++    else:
++        bboxes_for_nms = bboxes
+     nms_type = nms_cfg_.pop('type', 'nms')
+     nms_op = eval(nms_type)
+     dets, keep = nms_op(","I suggest adding `class_agnostic` as an argument of `batched_nms()`, with the default value False.",How does this behave when there is a `class_agnostic` attribute in t
+5415,"@@ -44,6 +44,7 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 101, ""file_path"", Types.StringType.get(), ""Path of a file in which a deleted row is stored"");
+   public static final NestedField DELETE_FILE_POS = NestedField.required(
+       Integer.MAX_VALUE - 102, ""pos"", Types.LongType.get(), ""Ordinal position of a deleted row in the data file"");
++  public static final String DELETE_FILE_ROW_FIELD_NAME = ""row"";
+   public static final int DELETE_FILE_ROW_FIELD_ID = Integer.MAX_VALUE - 103;
+   public static final String DELETE_FILE_ROW_DOC = ""Deleted row values"";
+ ","@rdblue, did we not add the name on purpose?",Why is this required?
+5416,"@@ -41,12 +41,12 @@ import org.apache.orc.TypeDescription;
+  */
+ public final class ORCSchemaUtil {
+
+-  private enum BinaryType {
++  public enum BinaryType {
+     UUID, FIXED, BINARY
+   }
+
+-  private enum IntegerType {
+-    TIME, INTEGER
++  public enum LongType {
++    TIME, LONG
+   }
+
+   private static class OrcField {",Why is this now public?,Does this belong in this PR?
+5417,"@@ -111,9 +111,7 @@ module Blacklight::SearchContext
+       response, documents = search_service.previous_and_next_documents_for_search index, search_state.reset(current_search_session.query_params).to_hash
+
+       search_session['total'] = response.total
+-      @search_context_response = response
+-      @previous_document = documents.first
+-      @next_document = documents.last
++      { prev: documents.first, next: documents.last }
+     end
+   rescue Blacklight::Exceptions::InvalidRequest => e
+     logger.warn ""Unable to setup next and previous documents: #{e}""",I guess we should backport some deprecation for this?,"`@previous_document`, `@next"
+5418,"@@ -57,11 +57,10 @@ module Selenium
+               is_relative = Regexp.last_match(1).strip == '1'
+             when /^Path=(.+)$/
+               path = Regexp.last_match(1).strip
++              p = path_for(name, is_relative, path)
++              @profile_paths[name] = p if p
+             end
+           end
+-
+-          p = path_for(name, is_relative, path)
+-          @profile_paths[name] = p if p
+         end
+
+         def path_for(name, is_relative, path)",Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?,Metrics/LineLength: Line is
+5419,"@@ -105,6 +105,7 @@ static byte buf[8192];
+ #define IMMARG(sz) opnd_create_immed_int(37, sz)
+ #define TGTARG opnd_create_instr(instrlist_last(ilist))
+ #define REGARG(reg) opnd_create_reg(REG_##reg)
++#define DR_REGARG(reg) opnd_create_reg(DR_REG_##reg)
+ #define REGARG_PARTIAL(reg, sz) opnd_create_reg_partial(REG_##reg, sz)
+ #define VSIBX(sz) (opnd_create_base_disp(REG_XCX, REG_XMM6, 2, 0x42, sz))
+ #define VSIBY(sz) (opnd_create_base_disp(REG_XDX, REG_YMM6, 2, 0x17, sz))",I would say just change REGARG: no need for a separate thing.,Looks like this is unrelated
+5420,"@@ -0,0 +1,18 @@
++<!DOCTYPE html>
++<html>
++<head>
++  <title>C2</title>
++  <meta name=""viewport"" content=""width=device-width""/>
++  <meta http-equiv=""Content-Type"" content=""text/html; charset=utf-8""/>
++  <link rel=""stylesheet"" type=""text/css"" href=""<%= stylesheet_url(""mailer.css"") %>"">
++</head>
++<body class=""c2-notification"">
++  <%= yield %>
++  <hr>
++  <div id=""footer"" class=""inset"">
++    <p>
++    <%= t(""mailer.feedback_footer_html"", feedback_url: feedback_url) %>
++    </p>
++  </div>
++</body>
++</html>","we can remove this template, it is no longer in use",The indentation is off here.
+5421,"@@ -45,11 +45,9 @@ module Beaker
+       end
+
+       it ""recursively dumps values"" do
+-        options.merge({'k' => 'v', 'key' => {'subkey' => 'subvalue'}, 'array_key' => ['array1', 'array2'], 'array_key2' => [['subarray1', 'subarray2'], 'anotherval']})
+-        expect(options.dump).to be === ""Options:\n\t\tk : v\n\t\tkey : \n\t\t\tsubkey : subvalue\n\t\tarray_key : \n\t\t\t[\n\t\t\tarray1,\n\t\t\tarray2,\n\t\t\t]\n\t\tarray_key2 : \n\t\t\t[\n\t\t\t[\n\t\t\tsubarray1,\n\t\t\tsubarray2,\n\t\t\t]\n\t\t\tanotherval,\n\t\t\t]\n""
+-
++        options.merge({'k' => { 'key' => {'subkey' => 'subvalue'}}})
++        expect(options.dump).to be === ""Options:\n\t\tk : \n\t\t\tkey : \n\t\t\t\tsubkey : subvalue\n""
+       end
+-
+     end
+   end
+ end",This doesn't look like it has as much coverage of the recursive code as it once did.,Line is too long. [103/80]
+5422,"@@ -107,6 +107,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Defaults to false.
+ 	// +optional
+ 	CrossZoneLoadBalancing bool `json:""crossZoneLoadBalancing,omitempty""`
++
++	// SecurityGroups sets the security groups used by the load balancer
++	// +optional
++	SecurityGroups []SecurityGroup `json:""securityGroups,omitempty""`
+ }
+
+ // AWSClusterStatus defines the observed state of AWSCluster","Do we actually expect users to provide more information here than possibly a SecurityGroup ID? If not, then this should probably use a new type, otherwise users might be confused by what options would be respected/ignored when used in this context.",Can we update the README to
+5423,"@@ -1,6 +1,8 @@
+ package edu.harvard.iq.dataverse.util;
+
+ import com.ocpsoft.pretty.PrettyContext;
++import com.rometools.utils.Strings;
++
+ import edu.harvard.iq.dataverse.DataFile;
+ import edu.harvard.iq.dataverse.Dataset;
+ import edu.harvard.iq.dataverse.Dataverse;",This seems like a new dependency on rometools. Do we need it?,Please remove this empty lin
+5424,"@@ -93,7 +93,7 @@ public class Docker {
+       throw new WebDriverException(""Unable to pull container: "" + name);
+     }
+
+-    LOG.info(String.format(""Pull of %s:%s complete"", name, tag));
++    LOG.fine(String.format(""Pull of %s:%s complete"", name, tag));
+
+     return findImage(new ImageNamePredicate(name, tag))
+         .orElseThrow(() -> new DockerException(",Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.,"Why did you change this to `fine`? It's not a big deal, but I think it's more consistent."
+5425,"@@ -7,13 +7,12 @@ import (
+ 	""sync/atomic""
+ 	""testing""
+
++	""github.com/sirupsen/logrus/hooks/test""
+ 	""github.com/stretchr/testify/require""
+
+ 	""github.com/spiffe/spire/pkg/common/util""
+ 	""github.com/spiffe/spire/pkg/server/plugin/datastore""
+ 	""github.com/spiffe/spire/pkg/server/plugin/datastore/sql""
+-	spi ""github.com/spiffe/spire/proto/spire/common/plugin""
+-	""github.com/spiffe/spire/test/spiretest""
+ )
+
+ var (","I can not think in a good use for it, but may we allow a way to setup a fake with a hook for logs? this fake is special, and we may need access to some of thoe logs, at the same time it may be an overkill because we dont want to test ""sql"" implementation but results.. but we can create some tests with end to end logs in some scenaries, What do you think about it?",Is this used?
+5426,"@@ -149,6 +149,10 @@ void dag_close_over_environment(struct dag *d)
+ 			{
+ 				dag_variable_add_value(name, d->default_category->mf_variables, 0, value_env);
+ 			}
++
++			if(!value_env && !strcmp(name, RESOURCES_CORES)) {
++				dag_variable_add_value(name, d->default_category->mf_variables, 0, ""1"");
++			}
+ 		}
+ 	}
+ ","I don't think you should be changing the dag unilaterally at parse time. If cores isn't specified, then it isn't specified.",I'm not sure what you're trying to do here. Does `d->default_category->mf_variables` cont
+5427,"@@ -26,6 +26,16 @@
+ // see URLOpener.
+ // See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
++// Message Delivery Semantics
++//
++// Azure ServiceBus supports at-least-once semantics in the default Peek-Lock
++// mode; applications must call Message.Ack/Nack after processing a message, or
++// it will be redelivered. However, it also supports a Receive-Delete mode,
++// which essentially auto-acks a message when it is delivered, resulting in
++// at-most-once semantics. See SubscriberOptions.AckFuncForReceiveAndDelete.
++// See https://godoc.org/gocloud.dev/pubsub#hdr-At_most_once_and_At_least_once_Delivery
++// for more background.
++//
+ // As
+ //
+ // azuresb exposes the following types for As:","Instead of just ""See SubscriberOptions...."", say something like ""Use ... to choose between the two.""","Just a thought, do we want to update the doc here to mention that `ReceiveAndDelete` is o"
+5428,"@@ -0,0 +1,10 @@
++import argparse
++from rdkit import Chem
++sdf = Chem.SDMolSupplier(""cdk2.sdf"")
++f = open(""cdk2.smi"",""w"")
++for mol in sdf:
++    name = mol.GetProp(""_Name"")
++    smi = Chem.MolToSmiles( mol )
++    f.write( ""{}\t{}\n"".format(name,smi))
++f.close()
++",Use with statement for `f`,This should probably use `os.path.join` instead of hardcoding `/`.
+5429,"@@ -426,3 +426,16 @@ TEST_F(BadPonyTest, AnnotatedIfClause)
+
+   TEST_COMPILE(src);
+ }
++
++TEST_F(BadPonyTest, CapSubtypeInConstrainSubtyping)
++{
++  // From PR #1816
++  const char* src =
++    ""trait T\n""
++    ""  fun alias[X: Any iso](x: X!) : X^\n""
++    ""class C is T\n""
++    ""  fun alias[X: Any tag](x: X!) : X^ => x\n"";
++
++  TEST_ERRORS_1(src,
++    ""type parameter constraint Any tag is not a supertype of Any iso"");
++}","It's a small style point, but could you remove the ""extra"" space before the colon that precedes the return type? This would make it more closely match the prevailing style in these tests and in the standard libraries.",Nit: No need for `!` here.
+5430,"@@ -594,6 +594,13 @@ func (md *MDOpsStandard) PruneBranch(
+ 	return md.config.MDServer().PruneBranch(ctx, id, bid)
+ }
+
++// ResolveBranch implements the MDOps interface for MDOpsStandard.
++func (md *MDOpsStandard) ResolveBranch(
++	ctx context.Context, id TlfID, bid BranchID,
++	blocksToDelete []BlockID, rmd *RootMetadata) (MdID, error) {
++	return MdID{}, errors.New(""ResolveBranch not supported by MDOpsStandard"")
++}
++
+ // GetLatestHandleForTLF implements the MDOps interface for MDOpsStandard.
+ func (md *MDOpsStandard) GetLatestHandleForTLF(ctx context.Context, id TlfID) (
+ 	BareTlfHandle, error) {","seems clunky to me to have an `MDOps` interface method that some implementations don't implement. Perhaps define a separate interface, like, `BranchResolver`, and then callers that have an `MDOps` object can check via type assertion?",So `resolveBranch` is implemented by `MDOpsStandard` but not `MDOp
+5431,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",This change should also probably go into the corresponding method of the abstract By class?,`T extends WebElement` ?
+5432,"@@ -42,6 +42,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/test/mock/mock_dispatcher""
+ 	ta ""github.com/iotexproject/iotex-core/test/testaddress""
+ 	""github.com/iotexproject/iotex-core/testutil""
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ )
+
+ const (",File is not `gofmt`-ed with `-s` (from `gofmt`),Could not find any usages of `pkg/util/byteutil`
+5433,"@@ -82,9 +82,9 @@ func (fsrv *FileServer) serveBrowse(dirPath string, w http.ResponseWriter, r *ht
+ 		w.Header().Set(""Content-Type"", ""text/html; charset=utf-8"")
+ 	}
+
+-	buf.WriteTo(w)
++	_, err = buf.WriteTo(w)
+
+-	return nil
++	return err
+ }
+
+ func (fsrv *FileServer) loadDirectoryContents(dir *os.File, urlPath string, repl *caddy.Replacer) (browseListing, error) {","This is likely to return an error value if the client fails to read the response we write, which is why I chose to ignore this error.","`return err` is not needed here, you can just `r"
+5434,"@@ -649,6 +649,9 @@ class Channel(AbstractChannel):
+     def is_static_remotekey_enabled(self) -> bool:
+         return bool(self.storage.get('static_remotekey_enabled'))
+
++    def is_upfront_shutdown_script_enabled(self) -> bool:
++        return bool(self.storage.get('upfront_shutdown_script_enabled'))
++
+     def get_wallet_addresses_channel_might_want_reserved(self) -> Sequence[str]:
+         ret = []
+         if self.is_static_remotekey_enabled():",this method is not used,would it be better to return `True` here just to
+5435,"@@ -1016,7 +1016,15 @@ class AbstractTab(QWidget):
+             return
+
+         sess_manager.save_autosave()
++        self.load_finished.emit(ok)
++
++        if not self.title():
++            self.title_changed.emit(self.url().toDisplayString())
+
++        self.zoom.reapply()
++
++    def _update_load_status(self, ok: bool) -> None:
++        """"""Update the load status after a page finished loading.""""""
+         if ok and not self._has_ssl_errors:
+             if self.url().scheme() == 'https':
+                 self._set_load_status(usertypes.LoadStatus.success_https)","Right now it's a bit unclear that this needs to be called explicitly by the implementing class. If, for example, there's another backend, it won't get this update unless we add the same function as webkit. Could you either add a note to this docstring explaining that this needs to be called, or find some way to automatically trigger this so the webkit override isn't needed (and some override passed on webengine).","I don't really like the name of this function, `"
+5436,"@@ -162,7 +162,7 @@ var xdpTestCases = []xdpTest{
+ 			SrcPort: 54321,
+ 		},
+ 		Drop:     false,
+-		Metadata: true,
++		Metadata: false,
+ 	},
+ 	{
+ 		Description: ""6 - Match against a deny policy, must drop"",","Why this change (test name still says ""must pass with metadata"")?",why is this changed?
+5437,"@@ -45,7 +45,8 @@ module Travis
+           end
+
+           def ruby_version
+-            config[:rvm].to_s.gsub(/-(1[89]|2[01])mode$/, '-d\1')
++            vers = config[:rvm].to_s.gsub(/-(1[89]|2[01])mode$/, '-d\1')
++            force_187_p371 vers
+           end
+
+           def setup_rvm",Another nitpick: parens around the arg pretty please,I think this should
+5438,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)",If we no longer need
+5439,"@@ -877,3 +877,7 @@ type CtxKey string
+ // context.WithValue to access the original request URI that accompanied the
+ // server request. The associated value will be of type string.
+ const URLPathCtxKey CtxKey = ""url_path""
++
++// URIxRewriteCtxKey is a context key used to store original unrewritten
++// URI in context.WithValue
++const URIxRewriteCtxKey CtxKey = ""caddy_rewrite_original_uri""","Oh, I guess I mentioned/pressed this point in the other issue, that this should probably go into the httpserver package. In fact, so should the const above this (URLPathCtxKey). These are specific to the HTTP server.","The naming ""caddy_re"
+5440,"@@ -41,7 +41,7 @@ type ValidationFunc func(certificate *cmapi.Certificate, secret *corev1.Secret)
+
+ // ExpectValidKeysInSecret checks that the secret contains valid keys
+ func ExpectValidKeysInSecret(_ *cmapi.Certificate, secret *corev1.Secret) error {
+-	validKeys := [5]string{corev1.TLSPrivateKeyKey, corev1.TLSCertKey, cmmeta.TLSCAKey, cmapi.AdditionalOutputFormatDERKey, cmapi.AdditionalOutputFormatPEMKey}
++	validKeys := [5]string{corev1.TLSPrivateKeyKey, corev1.TLSCertKey, cmmeta.TLSCAKey, cmapi.CertificateOutputFormatDERKey, cmapi.CertificateOutputFormatCombinedPEMKey}
+ 	nbValidKeys := 0
+ 	for k := range secret.Data {
+ 		for _, k2 := range validKeys {","Not added by you, but we don't really need the '5' here..",why did we remove the `AdditionalOutputFormatPEMKey` keys here?
+5441,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?,"VENDOR_COMMAND_PREFIX is now unused, I don't think it should be"
+5442,"@@ -36,6 +36,7 @@ def _makeKbEmulateScript(scriptName):
+ 		# __name__ must be str; i.e. can't be unicode.
+ 		scriptName = scriptName.encode(""mbcs"")
+ 	func.__name__ = ""script_%s"" % scriptName
++	func.emuGesture = emuGesture
+ 	func.__doc__ = _(""Emulates pressing %s on the system keyboard"") % emuGesture.displayName
+ 	return func
+ ",I don't think this is needed anymore?,Is there a way to test this? Like `test_emu_gesture()`
+5443,"@@ -91,8 +91,15 @@ func (s *Service) ListAgents(ctx context.Context, req *agentv1.ListAgentsRequest
+ 	// Parse proto filter into datastore request
+ 	if req.Filter != nil {
+ 		filter := req.Filter
++
++		// TODO should this be a helper function?
++		var byBanned *bool
++		if filter.ByBanned != nil {
++			byBanned = &filter.ByBanned.Value
++		}
++
+ 		listReq.ByAttestationType = filter.ByAttestationType
+-		listReq.ByBanned = filter.ByBanned
++		listReq.ByBanned = byBanned
+
+ 		if filter.BySelectorMatch != nil {
+ 			selectors, err := api.SelectorsFromProto(filter.BySelectorMatch.Selectors)",This is the only occurrence I see in the code where we now need to convert from a boolean protobuf wrapper to a boolean pointer. This felt a little cumbersome here; should we consider moving it somewhere else as a helper function?,"It's a helper function, why not use `pkg/util/pointer.go`?"
+5444,"@@ -46,9 +46,6 @@ void HBProcessor::process(const cpp2::HBReq& req) {
+   }
+
+   HostInfo info(time::WallClock::fastNowInMilliSec(), req.get_role(), req.get_git_info_sha());
+-  if (req.version_ref().has_value()) {
+-    info.version_ = *req.version_ref();
+-  }
+   if (req.leader_partIds_ref().has_value()) {
+     ret = ActiveHostsMan::updateHostInfo(kvstore_, host, info, &*req.leader_partIds_ref());
+   } else {",Need you to delete the `version_` from `HostInfo` struct ?,Discarding changes to the version ref shouldn't be part of this PR.
+5445,"@@ -0,0 +1,5 @@
++const { getBaseLang } = axe.commons.utils;
++const primaryLangValue = getBaseLang(node.getAttribute('lang') || '');
++const primaryXmlLangValue = getBaseLang(node.getAttribute('xml:lang') || '');
++
++return primaryLangValue === primaryXmlLangValue;",This could be the cleanest looking check we've got. Great job Jey.,Are we sure the attribute `lang` will always be defined?
+5446,"@@ -148,7 +148,7 @@ class Controller
+             $url = Request::path();
+         }
+
+-        if (!strlen($url)) {
++        if ('' === $url) {
+             $url = '/';
+         }
+ ","Who invited yoda?   In all seriousness though, wouldn't an `if (empty())` be better here?",`if (! empty($url)) {` would be better.
+5447,"@@ -1341,7 +1341,7 @@ define(['playbackManager', 'dom', 'inputManager', 'datetime', 'itemHelper', 'med
+                 });
+             } catch (e) {
+                 require(['appRouter'], function(appRouter) {
+-                    appRouter.showDirect('/');
++                    window.location.href = 'index.html';
+                 });
+             }
+         });","You can use `appRouter.goHome` to do this (It's defined in site.js), it's less hacky than overriding the href.",you can use `location.path('/');`
+5448,"@@ -101,7 +101,14 @@ bool NebulaStore::init() {
+                             enginePtr->removePart(partId);
+                             continue;
+                         } else {
+-                             partIds.emplace_back(partId);
++                             auto it = std::find(partIds.begin(), partIds.end(), partId);
++                             if (it != partIds.end()) {
++                                LOG(INFO) << ""Part "" << partId
++                                          << "" has been loaded, skip current one, remove it!"";
++                                enginePtr->removePart(partId);
++                             } else {
++                                partIds.emplace_back(partId);
++                             }
+                         }
+                     }
+                     if (partIds.empty()) {",When could this happen?,why don't you directly use partIds.back() here?
+5449,"@@ -55,8 +55,7 @@ namespace Datadog.Trace.Agent.Transports
+                 await memoryStream.FlushAsync().ConfigureAwait(false);
+                 memoryStream.Seek(0, SeekOrigin.Begin);
+                 var buffer = memoryStream.GetBuffer();
+-                _headers.Add(""Content-Type"", ""application/json"");
+-                var result = await PostSegmentAsync(new ArraySegment<byte>(buffer, 0, (int)memoryStream.Length)).ConfigureAwait(false);
++                var result = await PostSegmentAsync(new ArraySegment<byte>(buffer, 0, (int)memoryStream.Length), ""application/json"").ConfigureAwait(false);
+                 var response = result.Item1;
+                 var request = result.Item2;
+                 if (response.StatusCode != 200 && response.StatusCode != 202)",I assume this was removed because it was redundant? and conflicted with the now dynamic contentType? Edit: Oh I see it being set was moved to the `PostSegmentAsync` call.,Does this have to be reverted?
+5450,"@@ -21,7 +21,9 @@ public class ProxyConfig {
+     public static ProxyConfig http(String host, int port, String username, String password) {
+         return new ProxyConfig(Proxy.Type.HTTP, host, port, username, password);
+     }
+-
++    public static ProxyConfig socks(String host, int port, String username, String password) {
++        return new ProxyConfig(Proxy.Type.SOCKS, host, port, username, password);
++    }
+     public ProxyConfig(Proxy.Type type, String host, int port, String username, String password) {
+         this.type = type;
+         this.host = host;",Here is a newline missing,why do we need this new method?
+5451,"@@ -126,7 +126,7 @@ module Travis
+
+                 # R-devel builds available at mac.r-project.org
+                 if r_version == 'devel'
+-                  r_url = ""https://mac.r-project.org/el-capitan/R-devel/R-devel-el-capitan.pkg""
++                  r_url = ""http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg""
+
+                 # The latest release is the only one available in /bin/macosx
+                 elsif r_version == r_latest",Did you mean to make this http rather than https?,Prefer single-quoted strings when you don't nee
+5452,"@@ -1,15 +1,14 @@
+ #appModules/audacity.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2010 NVDA Contributors <http://www.nvda-project.org/>
++#Copyright (C) 2006-2018 NVDA Contributors <https://www.nvaccess.org/>
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+
+ import appModuleHandler
+-import winUser
+ import controlTypes
+
+ class AppModule(appModuleHandler.AppModule):
+
+ 	def event_NVDAObject_init(self,obj):
+ 		if obj.windowClassName==""Button"" and not obj.role in [controlTypes.ROLE_MENUBAR, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_POPUPMENU]:
+-			obj.name=winUser.getWindowText(obj.windowHandle).replace('&','')
++			obj.name=obj.name.replace('&','')","The updated copyright header should be: # Copyright (C) 2006-2018 NV Access Limited, yourname","I think we need to keep the old code here, otherwise this will break windows compatibility."
+5453,"@@ -21,6 +21,7 @@ class PerformanceTestSamplesAggregator
+             $maxQueryCount = 0;
+             $isSuccessful = true;
+             $worstStatusCode = null;
++            $performanceTestSample = null;
+
+             foreach ($performanceTestSamplesOfUrl as $performanceTestSample) {
+                 /* @var $performanceTestSample \Tests\ShopBundle\Performance\Page\PerformanceTestSample */","wow :+1: , i do not even know how this test works.","Same as above, I would prefer `$performanceTestSample`."
+5454,"@@ -2,14 +2,12 @@
+ // The .NET Foundation licenses this file to you under the MS-PL license.
+ // See the LICENSE file in the project root for more information.
+
+-
+-using MvvmCross.Plugins;
+ using MvvmCross.UI;
+
+ namespace MvvmCross.Plugin.Visibility.Platform.Uap
+ {
+-    public class Plugin
+-        : IMvxPlugin
++    [MvxPlugin]
++    public class Plugin : IMvxPlugin
+     {
+         public void Load()
+         {",File should be renamed `PlugIn` -> `Plugin`,Why remove the namespace?
+5455,"@@ -17,6 +17,7 @@ package egress
+ import (
+ 	""context""
+ 	""fmt""
++	""net""
+ 	""testing""
+ 	""time""
+ ",I scanned the new test cases quickly. Do we have one for an egressIPPool with multiple different IP ranges?,This import should go at the top of the file.
+5456,"@@ -148,6 +148,17 @@ abstract class Abstract_Component implements Component {
+ 		add_action( 'init', [ $this, 'define_settings' ] );
+ 	}
+
++	/**
++	 * Method to filter component loading if needed.
++	 *
++	 * @since   1.0.1
++	 * @access public
++	 * @return bool
++	 */
++	public function should_component_be_active() {
++		return true;
++	}
++
+ 	/**
+ 	 * Method to set protected properties for class.
+ 	 *","you can use a different name, like `maybe_activate` or `is_active` without `component` in the method name as this is used in the class name. E.g: `$component->should_component_be_active` is using twice the `component` word",Should it be called `is_active` instead?
+5457,"@@ -114,6 +114,11 @@ class OrderedBulkOperation extends BulkOperationBase {
+    */
+   execute(_writeConcern, options, callback) {
+     const ret = this.bulkExecute(_writeConcern, options, callback);
++
++    if (!(ret && ret.options && ret.callback)) {
++      return ret;
++    }
++
+     options = ret.options;
+     callback = ret.callback;
+ ",I think this might not be a complete enough check: what if `options` is `null`/`undefined`?,Do we need the `ret.options && ret.callb
+5458,"@@ -0,0 +1,19 @@
++require ""rails_helper""
++
++feature ""Masquerade"" do
++  scenario ""admin masquerades as a user"" do
++    email = ""foo@bar.com""
++    user = create(:user, email: email)
++    admin = create(:user, admin: true)
++
++    sign_in_as(admin)
++    visit admin_users_path
++    click_on(""Masquerade"")
++
++    expect(page).to have_flash(""Now masquerading as #{email}"")
++  end
++
++  def have_flash(text)
++    have_css("".flash"", text: text)
++  end
++end",Useless assignment to variable - `user`.,should we also add a check for the conte
+5459,"@@ -74,8 +74,8 @@ module Travis
+             sh.echo ""#{release} is not installed. Downloading and installing pre-build binary."", ansi: :yellow
+
+             sh.echo ""Downloading archive: ${archive_url}"", ansi: :yellow
+-            sh.cmd ""wget -o ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}""
+-            sh.cmd ""mkdir -p ~/otp && tar -xf #{archive_name(release)} -C ~/otp/"", echo: true
++            sh.cmd ""wget -O ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}""
++            sh.cmd ""mkdir -p ~/otp && tar -xf ${TRAVIS_HOME}/erlang.tar.bz2 -C ~/otp/"", echo: true
+             sh.cmd ""mkdir -p ~/.kerl"", echo: true
+             sh.cmd ""echo '#{release},#{release}' >> ~/.kerl/otp_builds"", echo: true
+             sh.cmd ""echo '#{release} ${TRAVIS_HOME}/otp/#{release}' >> ~/.kerl/otp_builds"", echo: true","I think we would want to keep `-O` instead. I wonder how this worked before, though.  ",If release is not in the archive then we
+5460,"@@ -26,13 +26,17 @@ namespace OpenTelemetry.Metrics
+     internal sealed class AggregatorStore
+     {
+         private static readonly ObjectArrayEqualityComparer ObjectArrayComparer = new ObjectArrayEqualityComparer();
++        private static readonly StringArrayEqualityComparer StringArrayComparer = new StringArrayEqualityComparer();
+         private readonly object lockZeroTags = new object();
+         private readonly HashSet<string> tagKeysInteresting;
+         private readonly int tagsKeysInterestingCount;
+
++        private readonly ConcurrentDictionary<string[], string[]> tagKeyCombinations =
++            new ConcurrentDictionary<string[], string[]>(StringArrayComparer);
++
+         // Two-Level lookup. TagKeys x [ TagValues x Metrics ]
+         private readonly ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>> keyValue2MetricAggs =
+-            new ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>>(new StringArrayEqualityComparer());
++            new ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>>(StringArrayComparer);
+
+         private readonly AggregationTemporality temporality;
+         private readonly string name;","another alternate option which doesn't have the risk of too many entries (when user keeps providing keys in different order) Have the dictionary as before If tagKeys lookup fail, sort and lookup again. If fails, insert both original tagKeys and its sorted one to the dictionary. So that we only store atmost 2 entries per key set. And we only do a single lookup in hotpath, as opposed to 2 look ups.","This should be `IDictionary<string, int>`"
+5461,"@@ -370,6 +370,13 @@ void PlanNode::releaseSymbols() {
+   }
+ }
+
++void PlanNode::updateSymbols() {
++  auto symTbl = qctx_->symTable();
++  for (auto out : outputVars_) {
++    out && symTbl->updateWrittenBy(out->name, out->name, this);
++  }
++}
++
+ std::ostream& operator<<(std::ostream& os, PlanNode::Kind kind) {
+   os << PlanNode::toString(kind);
+   return os;",if (out != nullptr),"For my education, what is the difference "
+5462,"@@ -79,6 +79,18 @@ def profile(user_name):
+
+     user = _get_user(user_name)
+
++    need_exact = request.args.get(""exact"")
++    if not need_exact:
++        listen_count = db_conn.get_listen_count_for_user(user_name)
++        # round off to nearest 10 as we can't guarantee that the values
++        # are not old, so show approximate values instead
++        if listen_count > 10:
++            listen_count = (listen_count / 10) * 10
++        have_exact = False
++    else:
++        listen_count = db_conn.get_listen_count_for_user(user_name, need_exact = True)
++        have_exact = True
++
+     # Getting data for current page
+     max_ts = request.args.get(""max_ts"")
+     if max_ts is not None:","In the listenstore you catch the exception and then pass it on via Raise. However, here you do not catch the exception. You should catch the exception, but since this is a minor aspect of this page, perhaps show an error message when the count cannot be loaded in time. Then the rest of the page can still be rendered, rather than failing the whole page.","`need_exact` is set to `True` by default,"
+5463,"@@ -406,13 +406,14 @@ class TabbedBrowser(QWidget):
+         else:
+             yes_action()
+
+-    def close_tab(self, tab, *, add_undo=True, new_undo=True):
++    def close_tab(self, tab, *, add_undo=True, new_undo=True, transfer=False):
+         """"""Close a tab.
+
+         Args:
+             tab: The QWebView to be closed.
+             add_undo: Whether the tab close can be undone.
+             new_undo: Whether the undo entry should be a new item in the stack.
++            transfer: Whether the tab is closing because it is moving to a new window.
+         """"""
+         if config.val.tabs.tabs_are_windows:
+             last_close = 'close'",wouldn't it be simpler to just add `or transfer` here? That way the more complicated set of conditionals down below don't have to get more clauses.,Please make sure the docstring is updated
+5464,"@@ -13,8 +13,8 @@
+ # limitations under the License.
+
+ """"""Wrapper for the BigQuery API client.""""""
+-from googleapiclient import errors
+ from httplib2 import HttpLib2Error
++from googleapiclient import errors
+
+ from google.cloud.forseti.common.gcp_api import _base_repository
+ from google.cloud.forseti.common.gcp_api import api_helpers",ditto; please fix everywhere,@johanste this file needs to be renamed to `googleapiclient.exceptions` or something similar.
+5465,"@@ -164,6 +164,18 @@ Home directory can be found in a shared folder called ""home""
+ 			Default:  false,
+ 			Help:     ""Set to skip any symlinks and any other non regular files."",
+ 			Advanced: true,
++		}, {
++			Name:     ""subsystem"",
++			Default:  ""sftp"",
++			Help:     ""Specifies the SSH2 subsystem on the remote host."",
++			Advanced: true,
++		}, {
++			Name:    ""server_command"",
++			Default: """",
++			Help: `Specifies the path or command to run a sftp server on the remote host.
++
++The subsystem option is ignored when server_command is defined.`,
++			Advanced: true,
+ 		}},
+ 	}
+ 	fs.Register(fsi)",Can you break this line into two parts - the first line makes the option help text for `--sftp-server` and its too long! `Specifies the path or command to run a sftp server on the remote host. The subsystem option is ignored when sftp_server is defined.`,why is this optional?
+5466,"@@ -45,7 +45,7 @@ class LoopAnalyzer
+         Context &$inner_context = null,
+         bool $is_do = false,
+         bool $always_enters_loop = false
+-    ) {
++    ): ?bool {
+         $traverser = new PhpParser\NodeTraverser;
+
+         $assignment_mapper = new \Psalm\Internal\PhpVisitor\AssignmentMapVisitor($loop_scope->loop_context->self);",I reverted that one in a previous PR because of a CI failure but it was actually unrelated,Why did you change this from bool to bool?
+5467,"@@ -112,12 +112,13 @@ func Add2ToolsList(toolList map[string]types.ToolsInstaller, flagData map[string
+ 	if kubeVer == """" {
+ 		var latestVersion string
+ 		for i := 0; i < util.RetryTimes; i++ {
+-			latestVersion, err := util.GetLatestVersion()
++			version, err := util.GetLatestVersion()
+ 			if err != nil {
+ 				return err
+ 			}
+-			if len(latestVersion) != 0 {
+-				kubeVer = latestVersion[1:]
++			if len(version) != 0 {
++				kubeVer = version[1:]
++				latestVersion = version
+ 				break
+ 			}
+ 		}","The for loop is useless here, since any error will make the function return.",could we rename `latestVersion` to `latestVersion` or something similar?
+5468,"@@ -0,0 +1,16 @@
++#! /usr/bin/env python
++
++
++# import unittest2 as unittest
++
++# from nupic.bindings.algorithms import FlatSpatialPooler as FlatSpatialPooler
++
++# import spatial_pooler_py_api_test as pytest
++
++# pytest.SpatialPooler = FlatSpatialPooler
++
++# SpatialPoolerFlatAPITest = pytest.SpatialPoolerAPITest
++
++
++# if __name__ == ""__main__"":
++#   unittest.main()",Fix file endings here and elsewhere.,Is there a reason to keep this file?
+5469,"@@ -1188,7 +1188,7 @@ void CLIENT_STATE::check_project_timeout() {
+         if (p->possibly_backed_off && now > p->min_rpc_time) {
+             p->possibly_backed_off = false;
+             char buf[256];
+-            snprintf(buf, sizeof(buf), ""Backoff ended for %s"", p->get_project_name());
++            snprintf(buf, sizeof(buf), ""Backoff ended for %.128s"", p->get_project_name());
+             request_work_fetch(buf);
+         }
+     }",I'd better increase `buf` length to MAXPATHLEN and not cut p->get_project_name() output twice,(style) line over 80 characters
+5470,"@@ -172,6 +172,7 @@ func (*impl) createStorageMiner(vmctx runtime.InvocationContext, params CreateSt
+ 				SectorSize:             params.SectorSize,
+ 			})
+ 			if err != nil {
++				fmt.Printf(""here it is: %s\n"", err)
+ 				return fmt.Errorf(""Could not set power table at address: %s"", actorIDAddr)
+ 			}
+ 			return nil","Please remove the prints, even though this code will be trashed.",This is probably a debug line that s
+5471,"@@ -26,8 +26,8 @@ import (
+ 	""runtime/debug""
+
+ 	""github.com/projectcalico/felix/config""
+-	""github.com/projectcalico/felix/dataplane/external""
+-	""github.com/projectcalico/felix/dataplane/linux""
++	extdataplane ""github.com/projectcalico/felix/dataplane/external""
++	intdataplane ""github.com/projectcalico/felix/dataplane/linux""
+ 	""github.com/projectcalico/felix/ifacemonitor""
+ 	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/felix/logutils""",Not sure if you added deliberately but I've seen these popping up; is goimports adding them?,extdataplane -> intdataplane
+5472,"@@ -75,6 +75,9 @@ func (src *AWSCluster) ConvertTo(dstRaw conversion.Hub) error { // nolint
+ 		dst.Spec.NetworkSpec.VPC.AvailabilityZoneSelection = restored.Spec.NetworkSpec.VPC.AvailabilityZoneSelection
+ 	}
+
++	dst.Spec.NetworkSpec.SecurityGroupOverrides = restored.Spec.NetworkSpec.SecurityGroupOverrides
++	dst.Spec.NetworkSpec.TagSecurityGroups = restored.Spec.NetworkSpec.TagSecurityGroups
++
+ 	return nil
+ }
+ ","I think we might need some special handling for `Spec.ControlPlaneLoadBalancer.SecurityGroups`, it looks like we are currently only handling the case that `Spec.ControlPlaneLoadBalancer` is nil.",These two lines should have been removed from the restore function and the tests should only use the `ecs_test.go` file.
+5473,"@@ -0,0 +1,18 @@
++_base_ = '../cascade_rcnn/cascade_mask_rcnn_r50_fpn_20e_coco.py'
++
++model = dict(
++    pretrained='open-mmlab://dla60',
++    backbone=dict(
++        type='DLANet',
++        depth=60,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++    neck=dict(
++        type='FPN',
++        in_channels=[128, 256, 512, 1024],
++        out_channels=256,
++        num_outs=5))",Is this from a third-party library?,`precision=2` should be removed.
+5474,"@@ -70,3 +70,18 @@ dom.isNativelyFocusable = function(el) {
+ 	}
+ 	return false;
+ };
++
++/**
++ * Determines if an element is in the focus order, but would not be if its
++ * tabindex were unspecified.
++ * @method insertedIntoFocusOrder
++ * @memberof axe.commons.dom
++ * @instance
++ * @param {HTMLElement} el The HTMLElement
++ * @return {Boolean} True if the element is in the focus order but wouldn't be
++ * if its tabindex were removed. Else, false.
++ */
++dom.insertedIntoFocusOrder = function(el) {
++	return (el.tabIndex > -1 && dom.isFocusable(el) &&
++			!dom.isNativelyFocusable(el));
++};","Please put the `el.tabIndex > -1` in the first part of the expression. The matcher will run on every node on the page, so we should put the fastest part first.",`isFocusable` and `isNativelyFocusable` seem to have the same meaning. What about `isFocusableByDefault` or `isFocusable
+5475,"@@ -20,14 +20,14 @@ package mysterium
+ import (
+ 	""path/filepath""
+
+-	log ""github.com/cihub/seelog""
+ 	""github.com/mitchellh/go-homedir""
++	""github.com/mysteriumnetwork/go-openvpn/openvpn3""
+ 	""github.com/mysteriumnetwork/node/cmd""
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/node""
+-	""github.com/mysteriumnetwork/node/identity""
+ 	""github.com/mysteriumnetwork/node/metadata""
+-	service_noop ""github.com/mysteriumnetwork/node/services/noop""
++	""github.com/mysteriumnetwork/node/services/openvpn""
++	""github.com/mysteriumnetwork/node/services/openvpn/session""
+ )
+
+ // MobileNode represents node object tuned for mobile devices","`identity` is unused now, is it for future usage?",can you move these openvpn related changes into a separate PR?
+5476,"@@ -9,11 +9,14 @@ Puppet::Functions.create_function(:prompt) do
+   # @param prompt The prompt to display.
+   # @param options A hash of additional options.
+   # @option options [Boolean] sensitive Disable echo back and mark the response as sensitive.
++  #   The returned value will be wrapped by the `Sensitive` data type. To access the raw
++  #   value, use the `unwrap` function (i.e. `$sensitive_value.unwrap`).
+   # @return The response to the prompt.
+   # @example Prompt the user if plan execution should continue
+   #   $response = prompt('Continue executing plan? [Y\N]')
+   # @example Prompt the user for sensitive information
+   #   $password = prompt('Enter your password', 'sensitive' => true)
++  #   out::message(""Password is: ${password.unwrap}"")
+   dispatch :prompt do
+     param 'String', :prompt
+     optional_param 'Hash[String[1], Any]', :options","This would have assisted me a lot! I am on the ""functions"" page more than any other page in the docs","`$sensitive_value` is already wrapped in the `unwrap` function, so this isn't needed."
+5477,"@@ -971,7 +971,7 @@ class JobTask(BaseHadoopJobTask):
+             if self.__module__ == '__main__':
+                 d = pickle.dumps(self)
+                 module_name = os.path.basename(sys.argv[0]).rsplit('.', 1)[0]
+-                d = d.replace(b'(c__main__', ""(c"" + module_name)
++                d = d.replace(b'c__main__', b'c' + module_name.encode('ascii'))
+                 open(file_name, ""wb"").write(d)
+
+             else:",I think it's better we keep `(` and encode with default encoding (utf-8).,How is this related to the rest of the PR?
+5478,"@@ -52,11 +52,12 @@ class BaselineFormat extends AbstractBaselinePlugin {
+                 java.removeUnusedImports();
+                 // use empty string to specify one group for all non-static imports
+                 java.importOrder("""");
+-                java.trimTrailingWhitespace();
+
+                 if (eclipseFormattingEnabled(project)) {
+                     java.eclipse().configFile(project.file(eclipseXml.toString()));
+                 }
++
++                java.trimTrailingWhitespace();
+             });
+
+             // necessary because SpotlessPlugin creates tasks in an afterEvaluate block",this is gonna be different in an IDE vs from gradlew??,I would move this method call to after `java.eclipse().configFile(project);`
+5479,"@@ -140,3 +140,18 @@ end
+
+ Spork.each_run do
+ end
++
++shared_context ""with isolated syntax"" do
++  orig_matchers_syntax = nil
++  orig_mocks_syntax = nil
++
++  before(:each) do
++    orig_matchers_syntax = RSpec::Matchers.configuration.syntax
++    orig_mocks_syntax = RSpec::Mocks.configuration.syntax
++  end
++
++  after(:each) do
++    RSpec::Matchers.configuration.syntax = orig_matchers_syntax
++    RSpec::Mocks.configuration.syntax = orig_mocks_syntax
++  end
++end",Do we not already have something for isolating syntax?,For my own education: What is this shared context for?
+5480,"@@ -1,7 +1,7 @@
+ # -*- coding: utf-8 -*-
+ ##
+ ## This file is part of Invenio.
+-## Copyright (C) 2012 CERN.
++## Copyright (C) 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","1: D100 Docstring missing 4: I102 copyright year is outdated, expected 2014 but got 2012 158: D103 Docstring missing 168: D101 Docstring missing 170: D102 Docstring missing 180: D102 Docstring missing 187: D102 Docstring missing",Copyright date should not be changed from the original unless the file has been completely replaced
+5481,"@@ -1,11 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how deny uploads of objects without
++# server-side AWS KMS encryption to an Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3_add_bucket_sses3_encryption_policy]
++
+ require 'aws-sdk-s3'
+
+-# Denies uploads of objects without server-side AWS KMS encryption to
+-#   an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - The Amazon S3 bucket to deny uploading objects without",how **to** deny,Trailing whitespace detected.
+5482,"@@ -19,6 +19,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     /// </summary>
+     public class ListenOptions : IEndPointInformation, IConnectionBuilder
+     {
++        private const string Http2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http2"";
++        private const string Http1AndHttp2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http1AndHttp2"";
++
+         private FileHandleType _handleType;
+         private readonly List<Func<ConnectionDelegate, ConnectionDelegate>> _components = new List<Func<ConnectionDelegate, ConnectionDelegate>>();
+ ",The only beef I have with this is that it's app domain global.,Http1AndHttp2ExperienceSwitch => Http2AndHttp2ExperimentSwitch
+5483,"@@ -562,8 +562,11 @@ func (ln tcpKeepAliveListener) Accept() (c net.Conn, err error) {
+ 	if err = tc.SetKeepAlive(true); err != nil {
+ 		return
+ 	}
+-	if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {
+-		return
++	// OpenBSD has no user-settable per-socket TCP keepalive
++	if runtime.GOOS != ""openbsd"" {
++		if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {
++			return
++		}
+ 	}
+ 	return tc, nil
+ }",Can you link to the GitHub issue and/or PR so that it is easy for future readers to find out more about this?,@smarterclayton @smarterclayton @smarterclayton @smarterclayton @smarterclayton @smarterclayton @sm
+5484,"@@ -3009,3 +3009,18 @@ void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRen
+     // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
+     renderpasses_states.erase(renderPass);
+ }
++
++bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
++                                                               const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) {
++    bool skip = false;
++
++    if (pAllocateInfo) {
++        auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
++        if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
++            skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
++                            ""VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602"",
++                            ""priority (=%f) must be between `0` and `1`, inclusive."", chained_prio_struct->priority);
++        }
++    }
++    return skip;
++}",Typical to report the value found as well as the valid bounds.,Would it be better to check `chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f`?
+5485,"@@ -151,7 +151,7 @@ var clerkCmd = &cobra.Command{
+ 	},
+ }
+
+-func waitForCommit(client libgoal.Client, txid string) error {
++func waitForCommit(client libgoal.Client, txid string, transactionLastValidRound uint64) error {
+ 	// Get current round information
+ 	stat, err := client.Status()
+ 	if err != nil {",maybe we want 0 as a default value?,I don't see where we use this `transactionLastValidRound` variable. Is it used anywhere?
+5486,"@@ -193,7 +193,16 @@ func (api *Server) GetAccount(ctx context.Context, in *iotexapi.GetAccountReques
+ 		PendingNonce: pendingNonce,
+ 		NumActions:   numActions,
+ 	}
+-	return &iotexapi.GetAccountResponse{AccountMeta: accountMeta}, nil
++	tipHeight := api.bc.TipHeight()
++	header, err := api.bc.BlockHeaderByHeight(tipHeight)
++	if err != nil {
++		return nil, status.Error(codes.NotFound, err.Error())
++	}
++	hash := header.HashBlock()
++	return &iotexapi.GetAccountResponse{AccountMeta: accountMeta, BlockIdentifier: &iotextypes.BlockIdentifier{
++		Hash:   hex.EncodeToString(hash[:]),
++		Height: tipHeight,
++	}}, nil
+ }
+
+ // GetActions returns actions",can we get height from sf at very beginning of the function and use that as height of the block?,Please use `BlockHeader` instead of `BlockHeaderByHeight` everywhere.
+5487,"@@ -0,0 +1,6 @@
++namespace Microsoft.AspNet.Server.Kestrel
++{
++    public class StandardsPoliceCompileModule : Microsoft.StandardsPolice.StandardsPoliceCompileModule
++    {
++    }
++}",Does this have to be public and in the primary namespace?,"Nit, there's an extra empty line here."
+5488,"@@ -1206,6 +1206,15 @@ func (fbo *folderBranchOps) initMDLocked(
+ 		return err
+ 	}
+
++	fbo.headLock.Lock(lState)
++	defer fbo.headLock.Unlock(lState)
++	// Some other thread got here first, so give up and let it go
++	// before we push anything to the servers.
++	if fbo.head != (ImmutableRootMetadata{}) {
++		fbo.log.CDebugf(ctx, ""Head was already set, aborting"")
++		return nil
++	}
++
+ 	if err = PutBlockCheckQuota(ctx, fbo.config.BlockServer(),
+ 		fbo.config.Reporter(), md.TlfID(), info.BlockPointer, readyBlockData,
+ 		md.GetTlfHandle().GetCanonicalName()); err != nil {",I'm a bit confused. Doesn't `mdWriterLock` already synchronizes calls to this function?,"Doesn't this need to be inside the `PutBlockCheckQuota` call, since we do that in `PutBlockCheckQuota`?"
+5489,"@@ -120,7 +120,13 @@ final class DailyMotionProvider extends BaseVideoProvider
+
+     public function getReferenceUrl(MediaInterface $media): string
+     {
+-        return sprintf('http://www.dailymotion.com/video/%s', $media->getProviderReference());
++        $providerReference = $media->getProviderReference();
++
++        if (null === $providerReference) {
++            return '';
++        }
++
++        return sprintf('http://www.dailymotion.com/video/%s', $providerReference);
+     }
+
+     protected function doTransform(MediaInterface $media): void","Does it make sense to generate a dailyMotion url without the video reference? It does not to me, but can we throw an exception here?",Why not just `$media->getProviderReference()`?
+5490,"@@ -24,10 +24,11 @@ import (
+ 	""sort""
+ 	""strings""
+
+-	stringutils ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/string""
+-	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ 	computeBeta ""google.golang.org/api/compute/v0.beta""
+ 	""google.golang.org/api/compute/v1""
++
++	stringutils ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/string""
++	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ )
+
+ const (",Why the separation of imports here?,this import should go with the rest of the imports
+5491,"@@ -4,14 +4,14 @@ import (
+ 	""context""
+
+ 	""github.com/influxdata/flux/ast""
+-	""github.com/influxdata/flux/dependencies""
++
+ 	""github.com/influxdata/flux/interpreter""
+ 	""github.com/influxdata/flux/parser""
+ 	""github.com/influxdata/flux/semantic""
+ 	""github.com/influxdata/flux/values""
+ )
+
+-func Eval(ctx context.Context, deps dependencies.Interface, itrp *interpreter.Interpreter, scope values.Scope, importer interpreter.Importer, src string) ([]interpreter.SideEffect, error) {
++func Eval(ctx context.Context, itrp *interpreter.Interpreter, scope values.Scope, importer interpreter.Importer, src string) ([]interpreter.SideEffect, error) {
+ 	pkg := parser.ParseSource(src)
+ 	if ast.Check(pkg) > 0 {
+ 		return nil, ast.GetError(pkg)",Random extra newline.,nit: probably worth renaming `deps` to `importer` to make it more clear what this is
+5492,"@@ -0,0 +1,18 @@
++/* global dom */
++
++/**
++ * Get all descendents that are focusable from a given node
++ * @method getFocusableElements
++ * @memberof axe.commons.dom
++ * @instance
++ * @param  {Object} virtualNode The virtualNode to assess
++ * @return {Boolean}
++ */
++dom.getFocusableElements = function getFocusableElements(virtualNode) {
++	const descendents = axe.utils.querySelectorAll(virtualNode, '*');
++	const focusableElms = descendents.filter(({ actualNode: el }) => {
++		const isElFocusable = dom.isFocusable(el);
++		return isElFocusable;
++	});
++	return focusableElms;
++};",No need for this variable.,Is this a polyfill?
+5493,"@@ -79,6 +79,15 @@ def authentication_required(url, authenticator, abort_on):
+     return answer
+
+
++def _format_msg(msg: str) -> str:
++    """"""Convert message to HTML suitable for rendering.""""""
++    ret = msg
++    ret = html.escape(ret)
++    ret = ret.strip()
++    ret = ret.replace('\n', '<br />')
++    return ret
++
++
+ def javascript_confirm(url, js_msg, abort_on):
+     """"""Display a javascript confirm prompt.""""""
+     log.js.debug(""confirm: {}"".format(js_msg))",Why not use `msg` directly below?,How about `html.esc
+5494,"@@ -29,9 +29,8 @@ import org.apache.parquet.schema.OriginalType;
+ import org.apache.parquet.schema.PrimitiveType;
+ import org.apache.parquet.schema.Type;
+
+-import static org.apache.parquet.schema.Type.Repetition.REPEATED;
+-
+ public class ParquetTypeVisitor<T> {
++  @SuppressWarnings({""checkstyle:IllegalType"", ""checkstyle:VisibilityModifier""})
+   protected LinkedList<String> fieldNames = Lists.newLinkedList();
+
+   public static <T> T visit(Type type, ParquetTypeVisitor<T> visitor) {",I think other places changed to use `Deque` instead of suppressing the warning.,checkstyle is a che
+5495,"@@ -4,8 +4,11 @@
+ #include ""engine/guidance/toolkit.hpp""
+
+ #include <boost/assert.hpp>
++#include <boost/range/algorithm_ext/erase.hpp>
++
+ #include <iostream>
+-#include <vector>
++#include <cstddef>
++#include <utility>
+
+ using TurnInstruction = osrm::extractor::guidance::TurnInstruction;
+ using TurnType = osrm::extractor::guidance::TurnType;","missing: utility, cstddef also: vector is already included in the header (interface requires vectors as in/out types)","This is a no-op, pl"
+5496,"@@ -16,6 +16,9 @@ module.exports = {
+ 		'html',
+ 		'text-summary',
+ 	],
++	globals: {
++		fetchMock: '',
++	},
+ 	rootDir: '../../',
+ 	transform: {
+ 		'^.+\\.[jt]sx?$': '<rootDir>/node_modules/@wordpress/scripts/config/babel-transform',","I'm not sure this is necessary in the config here, as Jest would be setting the global `fetchMock = ''`. See below.",It seems like the `fetchMock` is unused in this file. Could we remove it?
+5497,"@@ -57,7 +57,7 @@ public abstract class Message implements Part, Body {
+         final int MULTIPLIER = 31;
+
+         int result = 1;
+-        result = MULTIPLIER * result + mFolder.getName().hashCode();
++        result = MULTIPLIER * result + (mFolder != null ? mFolder.getName().hashCode() : 0);
+         result = MULTIPLIER * result + mUid.hashCode();
+         return result;
+     }",Can `mFolder == null` happen during regular operations? Or is it only so we can be lazy in tests?,"`mFolder` is not guaranteed to be not null, so this can be simplified"
+5498,"@@ -0,0 +1,8 @@
++require ""migrate""
++
++class AddPreferredEmailFormat < ActiveRecord::Migration
++  def change
++    create_enumeration :email_format_enum, %w(text_only multipart)
++    add_column :users, :preferred_email_format, :email_format_enum, :null => false, :default => ""multipart""
++  end
++end",I'd suggest using the actual MIME types here - so `text/plain` and `multipart/alternative` or does that cause problems with what postgres allows for enumeration names? If so then maybe just replace the slash with an underscore?,Use the new Ruby 1.9 hash syntax.
+5499,"@@ -619,9 +619,9 @@ def package_put(owner, package_name, package_hash):
+             if team_access is None:
+                 raise ApiException(
+                     requests.codes.forbidden,
+-                    (""%(user)s/%(pkg)s is private. To share it with the team, "" +
+-                     ""run `quilt access add %(user)s/%(pkg)s team`."") %
+-                    dict(user=owner, pkg=package_name)
++                    (""%(team)s:%(user)s/%(pkg)s is private. To share it with the team, "" +
++                        ""run `quilt access add %(team)s:%(user)s/%(pkg)s team`."") %
++                    dict(team=app.config['TEAM_NAME'].lower(), user=owner, pkg=package_name)
+                 )
+
+     # Insert an instance if it doesn't already exist.","Ohh. `TeamName` is actually a ""friendly"" name displayed in the Catalog - not the name used in the CLI. So I guess we'll need a new variable here. (That is, this is going to be mainly a `quilt.yaml` change. You won't need the `.lower()`, though.)",Will `app.config['TEAM_NAME']` always have lower case?
+5500,"@@ -383,6 +383,7 @@ class ConsoleAddon:
+             part in (""response-headers"", ""response-body"", ""set-cookies"") and
+             flow.response is None
+         )
++        flow.backup()
+         if require_dummy_response:
+             flow.response = http.HTTPResponse.make()
+         if part == ""cookies"":","Nit: Don't move it between `require_dummy_response` definition and usage, this can live above or below :)",This is causing tests to fail. Please remove.
+5501,"@@ -377,6 +377,17 @@ type Local struct {
+ 	// connections that are originating from the local machine. Setting this to ""true"", allow to create large
+ 	// local-machine networks that won't trip the incoming connection limit observed by relays.
+ 	DisableLocalhostConnectionRateLimit bool `version[16]:""true""`
++
++	// BlockServiceCustomFallbackEndpoints is a comma delimited list of endpoints which the block service uses to
++	// redirect the http requests to in case it does not have the round. If it is not specified, will check
++	// EnableBlockServiceFallbackToArchiver.
++	BlockServiceCustomFallbackEndpoints string `version[16]:""""`
++
++	// EnableBlockServiceFallbackToArchiver controls whether the block service redirects the http requests to
++	// an archiver or return StatusNotFound (404) when in does not have the requested round, and
++	// BlockServiceCustomFallbackEndpoints is empty.
++	// The archiver is randomly selected, if none is available, will return StatusNotFound (404).
++	EnableBlockServiceFallbackToArchiver bool `version[16]:""true""`
+ }
+
+ // Filenames of config files within the configdir (e.g. ~/.algorand)","With the current code, it not work if `EnableCatchupFromArchiveServers` is disabled. to fix it: in getDNSAddrs, change the predicate to `if wn.config.EnableCatchupFromArchiveServers || wn.config. EnableCatchupFromArchiveServers {` and in the catchup/service.go and catchup/catchpointService.go, use the `PeersPhonebookArchivers` only when `wn.config.EnableCatchupFromArchiveServers` is enabled.","`If it is not specified, the default is used."
+5502,"@@ -910,8 +910,9 @@ func (cr *ConflictResolver) resolveMergedPaths(ctx context.Context,
+ 	// cache for the merged branch.
+ 	mergedNodeCache := newNodeCacheStandard(cr.fbo.folderBranch)
+ 	// Initialize the root node.  There will always be at least one
+-	// unmerged path.
+-	mergedNodeCache.GetOrCreate(mergedChains.mostRecentMD.data.Dir.BlockPointer,
++	// unmerged path.  Hold it here so it doesn't get gc'd.
++	rootNode, _ := mergedNodeCache.GetOrCreate(
++		mergedChains.mostRecentMD.data.Dir.BlockPointer,
+ 		unmergedPaths[0].path[0].Name, nil)
+
+ 	newPtrs := make(map[BlockPointer]bool)","Why not make `SearchForNodes` do a `GetOrCreate` for the root node? (Not advocating for it, but just wondering if there's another reason than avoiding having to pass in the path.)",Could you elaborate why we don't get the gc'd
+5503,"@@ -224,6 +224,7 @@ public class DefaultP2PNetwork implements P2PNetwork {
+                 }
+                 dnsPeers.set(peers);
+               });
++      dnsDaemon.start();
+     }
+
+     final int listeningPort = rlpxAgent.start().join();",:+1: amazing that this has been missing since it was originally implemented,This is the only place where the `start` is c
+5504,"@@ -101,7 +101,7 @@ class OrcFileAppender<D> implements FileAppender<D> {
+   public long length() {
+     Preconditions.checkState(isClosed,
+         ""Cannot return length while appending to an open file."");
+-    return writer.getRawDataSize();
++    return file.toInputFile().getLength();
+   }
+
+   @Override","Just want to note here that although we do check `length` while writing to choose whether to close and start a new file, that doesn't happen for ORC already so it is fine to use a FS call in this method.",`FileInputFile` has a length() method which returns the size of the input file. I think this is not correct.
+5505,"@@ -67,8 +67,7 @@ public class PartitionField implements Serializable {
+   public boolean equals(Object other) {
+     if (this == other) {
+       return true;
+-    }
+-    if (other == null || getClass() != other.getClass()) {
++    } else if (!(other instanceof PartitionField)) {
+       return false;
+     }
+ ",nit: I feel multiple `if (...) { return ... }` is more readable than `if ... else ...`.,What's the reasoning behind this change?
+5506,"@@ -32,7 +32,7 @@ def setup_test_logging():
+         root.debug(""Already set up logging"")
+
+
+-setup_test_logging()
++# setup_test_logging()
+ logging.info(""Bootstrapped test"")
+
+ ",This is needed for us to work in IDE UTs,This should be removed.
+5507,"@@ -282,6 +282,12 @@ commands (copy, sync, etc), and with all other commands too.`,
+ 			Default:  false,
+ 			Help:     ""Only show files that are in the trash.\nThis will show trashed files in their original directory structure."",
+ 			Advanced: true,
++		}, {
++		}, {
++			Name:     ""starred_only"",
++			Default:  false,
++			Help:     ""Only show files that are starred."",
++			Advanced: true,
+ 		}, {
+ 			Name:     ""formats"",
+ 			Default:  """",",File is not `goimports`-ed (from `goimports`),"nit: maybe ""only show files that are starred"""
+5508,"@@ -486,14 +486,14 @@ func DupSecOpt(src string) []string {
+ 		con[""level""] == """" {
+ 		return nil
+ 	}
+-	return []string{""label:user:"" + con[""user""],
+-		""label:role:"" + con[""role""],
+-		""label:type:"" + con[""type""],
+-		""label:level:"" + con[""level""]}
++	return []string{""label=user:"" + con[""user""],
++		""label=role:"" + con[""role""],
++		""label=type:"" + con[""type""],
++		""label=level:"" + con[""level""]}
+ }
+
+ // DisableSecOpt returns a security opt that can be used to disabling SELinux
+ // labeling support for future container processes
+ func DisableSecOpt() []string {
+-	return []string{""label:disable""}
++	return []string{""label=disable""}
+ }","this `label=` is docker specific, while here in libcontainer there shouldn't be any mention to docker. `DisableSecOpt` and `DupSecOpt` should just deal with `disable,role,type,level`. Both CRI-O and docker should just pass `disable,role,type.level` stuff and not `label=...`.","These are the same, label is for SELinux"
+5509,"@@ -31,6 +31,7 @@ func init() {
+ 	flags.BoolVarP(cmdFlags, &notCreateNewFile, ""no-create"", ""C"", false, ""Do not create the file if it does not exist."")
+ 	flags.StringVarP(cmdFlags, &timeAsArgument, ""timestamp"", ""t"", """", ""Use specified time instead of the current time of day."")
+ 	flags.BoolVarP(cmdFlags, &localTime, ""localtime"", """", false, ""Use localtime for timestamp, not UTC."")
++	flags.BoolVarP(cmdFlags, &recurse, ""recursive"", ""R"", false, ""Recurse into the listing."")
+ }
+
+ var commandDefinition = &cobra.Command{","You need to declare variable `recurse` above, same place as `localTime`.","`-R` as a default is a bit unusual, why "
+5510,"@@ -1565,7 +1565,8 @@ class SpreadingOperation(LinkableOperation):
+             new_data[tuple(vd.name for vd in vdims)] = img
+         else:
+             new_data = array
+-        return element.clone(new_data, **kwargs)
++        return element.clone(new_data, xdensity=element.xdensity,
++                             ydensity=element.ydensity, **kwargs)
+
+
+ ",Why does `clone` not already copy `xdensity` and `ydensity` from what it is cloning?,do we need to check that `element.xdensi
+5511,"@@ -52,6 +52,11 @@ namespace OpenTelemetry.Metrics
+
+             AggregationTemporality temporality = AggregationTemporality.Cumulative;
+
++            if (meterSources.Count() == 0)
++            {
++                throw new ArgumentException(""No meter was added to the sdk."");
++            }
++
+             foreach (var reader in readers)
+             {
+                 if (reader == null)",Curious - do we do the same for traces (when no ActivitySource / legacy source are added)? (and why we want to do it for metrics?),Shouldn't this be `meterSources.Count()
+5512,"@@ -801,11 +801,11 @@ SdMmcHcStartSdClock (
+
+   Refer to SD Host Controller Simplified spec 3.0 Section 3.2.1 for details.
+
+-  @param[in] Private         A pointer to the SD_MMC_HC_PRIVATE_DATA instance.
+-  @param[in] Slot            The slot number of the SD card to send the command to.
+-  @param[in] BusTiming       BusTiming at which the frequency change is done.
+-  @param[in] FirstTimeSetup  Flag to indicate whether the clock is being setup for the first time.
+-  @param[in] ClockFreq       The max clock frequency to be set. The unit is KHz.
++  @param[in] PciIo          The PCI IO protocol instance.
++  @param[in] Slot           The slot number of the SD card to send the command to.
++  @param[in] ClockFreq      The max clock frequency to be set. The unit is KHz.
++  @param[in] BaseClkFreq    The base clock frequency of host controller in MHz.
++  @param[in] ControllerVer  The version of host controller.
+
+   @retval EFI_SUCCESS       The clock is supplied successfully.
+   @retval Others            The clock isn't supplied successfully.","@aimanrosli23 For the changes in file SdMmcPciHci.c, please make sure that you do not revert the changes made by the below commits: SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start SHA-1: c67617f3c677c342efde780e229f841f4e0f6c7e * MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands SHA-1: 6d387610855ee27b49cb720de29ed809ea59dadc * MdeModulePkg/SdMmcPciHcDxe: Read response on command completion SHA-1: 63fd7f389874081ea37452b1f79ac013d52755e3 * MdeModulePkg/SdMmcPciHcDxe: Do not map memory for non DMA transfer",Please don't abbreviate variable names.
+5513,"@@ -128,11 +128,18 @@ class SelectionAndFilterTests:
+         ('<link href=""javascript://foo"" />', [webelem.Group.all,
+                                               webelem.Group.url]),
+
+-        ('<textarea />', [webelem.Group.all]),
++        ('<textarea />', [webelem.Group.all, webelem.Group.inputs]),
+         ('<select />', [webelem.Group.all]),
+
+         ('<input />', [webelem.Group.all]),
+         ('<input type=""hidden"" />', []),
++        ('<input type=""text"" />', [webelem.Group.inputs]),
++        ('<input type=""email"" />', [webelem.Group.inputs]),
++        ('<input type=""url"" />', [webelem.Group.inputs]),
++        ('<input type=""tel"" />', [webelem.Group.inputs]),
++        ('<input type=""number"" />', [webelem.Group.inputs]),
++        ('<input type=""password"" />', [webelem.Group.inputs]),
++        ('<input type=""search"" />', [webelem.Group.inputs]),
+
+         ('<button />', [webelem.Group.all]),
+         ('<button href=""foo"" />', [webelem.Group.all, webelem.Group.prevnext,",You'll also need to add `webelem.Group.all` everywhere as that matches as well,The `webelem.Group.all` here should be
+5514,"@@ -0,0 +1,14 @@
++$(document).ready(initializeDocument);
++
++function initializeDocument() {
++  //only enable bank account field when BA80 is selected as an expense_type
++  $(""input:radio[name='ncr_proposal[expense_type]']"").click(function(event){
++    if ($(""input:radio[name='ncr_proposal[expense_type]']:checked"").val() == 'BA80') {
++      $('#ncr_proposal_RWA_number').attr('disabled', false);
++    } else {
++      $('#ncr_proposal_RWA_number').attr('disabled', true);
++    }
++  });
++
++  $('#ncr_proposal_building_number').chosen({placeholder_text_multiple: 'If applicable, which building will the charge support?'})
++}",Does this need to be an ERB template?,This is not a correct place to put this
+5515,"@@ -0,0 +1,18 @@
++package feedbackmock
++
++import (
++	""context""
++
++	feedbackv1 ""github.com/lyft/clutch/backend/api/feedback/v1""
++	""github.com/lyft/clutch/backend/service/feedback""
++)
++
++type svc struct{}
++
++func (s svc) SubmitFeedback(ctx context.Context, id string, feedback *feedbackv1.Feedback, metadata *feedbackv1.FeedbackMetadata) error {
++	return nil
++}
++
++func New() feedback.Service {
++	return &svc{}
++}",do we want to register this in the mock server for testing?,The package name `feedback` is confusin
+5516,"@@ -231,10 +231,10 @@ class AnomalyLikelihoodTest(TestCaseBase):
+
+     # Generate an estimate using fake distribution of anomaly scores.
+     data1 = _generateSampleData(mean=0.2)
+-    data1 = data1 + [(2, 2), (2, 2, 2, 2), (), (2)]  # Malformed records
++    data1 = data1[0:1000] + [(2, 2), (2, 2, 2, 2), (), (2)]  # Malformed records
+
+     likelihoods, avgRecordList, estimatorParams = (
+-      an.estimateAnomalyLikelihoods(data1[0:1000])
++      an.estimateAnomalyLikelihoods(data1[0:1004])
+     )
+     self.assertEqual(len(likelihoods), 1000)
+     self.assertEqual(len(avgRecordList), 1000)",shouldnt this be `0:996` (+4) so the 1000s below fit?,Why did this need to change?
+5517,"@@ -49,11 +49,11 @@ class sorted_context(object):
+         self.enabled = enabled
+
+     def __enter__(self):
+-        self._enabled = MultiDimensionalMapping._sorted
+-        MultiDimensionalMapping._sorted = self.enabled
++        self._enabled = MultiDimensionalMapping.sort
++        MultiDimensionalMapping.sort = self.enabled
+
+     def __exit__(self, exc_type, exc_val, exc_tb):
+-        MultiDimensionalMapping._sorted = self._enabled
++        MultiDimensionalMapping.sort = self._enabled
+
+
+ ","The docstring of this context_manager should be updated. As now ``sort=False`` is valid, it should just say it disables sorting regardless of whether the NdMapping has ``sort=True`` or ``sort=False``. I also think the line 'Should only be used if values are guaranteed to be sorted before or after the operation is performed.' should just say something else - maybe just that the initial ordering (whatever it is) should be preserved?",I think this should be Multi
+5518,"@@ -52,8 +52,8 @@ describe('Lifecycle methods', () => {
+ 			}
+ 		}
+
+-		spyAll(Receiver.prototype);
+ 		spyAll(Receiver);
++		spyAll(Receiver.prototype);
+
+ 		function throwExpectedError() {
+ 			throw (expectedError = new Error('Error!'));",This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form?  ,why is this needed?
+5519,"@@ -699,10 +699,14 @@ class Util:
+     @classmethod
+     def get_java_opts(cls):
+         opts = config.LAMBDA_JAVA_OPTS or ''
+-        if '_debug_port_' in opts:
++        if 'address=_debug_port_' in opts:
+             if not cls.debug_java_port:
+                 cls.debug_java_port = get_free_tcp_port()
+             opts = opts.replace('_debug_port_', ('%s' % cls.debug_java_port))
++        elif 'address=' in opts:
++            if not cls.debug_java_port:
++                cls.debug_java_port = ops.split(""address="")[1]
++
+         return opts
+
+     @classmethod",extract the port and set to `debug_java_port`,Shouldn't we replace `_debug
+5520,"@@ -93,6 +93,13 @@ def parse_compile_commands_json(logfile, add_compiler_defaults=False):
+     counter = 0
+     for entry in data:
+         sourcefile = entry['file']
++
++        if not os.path.isabs(sourcefile):
++            # Newest versions of intercept-build can create the 'file' in the
++            # JSON Compilation Database as a relative path.
++            sourcefile = os.path.join(os.path.abspath(entry['directory']),
++                                      sourcefile)
++
+         lang = option_parser.get_language(sourcefile[sourcefile.rfind('.'):])
+
+         if not lang:","When the argument list is `[""one"", ""two three""]` then you concatenate it as you do it here, you won't be able to get the original list back with split. You need to annotate the list items better. (Or if you won't do the split by yourself, the called shell will do it. So you need shell escaping. How portable is that?) The main driver to change this in `intercept-build` was to get rid of these concatenation and splitting errors. The current compilation database parser in Clang understands the `arguments` filed... So the question, why don't you pass the command around as a list instead of a string?",It would be good to be able to use `entry['file']` here instead of the absolute path.
+5521,"@@ -95,6 +95,10 @@ func (a *FakeWebAPI) RegisterPiped(ctx context.Context, req *webservice.Register
+ 	}, nil
+ }
+
++func (a *FakeWebAPI) EnablePiped(ctx context.Context, req *webservice.EnablePipedRequest) (*webservice.EnablePipedResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
+ func (a *FakeWebAPI) DisablePiped(ctx context.Context, req *webservice.DisablePipedRequest) (*webservice.DisablePipedResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`ctx` is unused in EnablePiped,"If piped is disabled, what's the expected behavior?"
+5522,"@@ -57,7 +57,9 @@ class _Session(object):
+         return hashlib.sha256(auth_string + ""@"" +
+                               _Session.__initial_salt).hexdigest()
+
+-    def __init__(self, token, phash):
++    def __init__(self, token, phash, user, authenticated):
++        self.authenticated = authenticated
++        self.user = user
+         self.token = token
+         self.persistent_hash = phash
+         self.last_access = datetime.now()",Why do we have both a list of valid sessions and an instance variable if a session is destroyed?,"`self.user` can be `None`, right?"
+5523,"@@ -258,10 +258,11 @@ func (au *accountUpdates) committedUpTo(rnd basics.Round) basics.Round {
+ 	// Keep track of how many changes to each account we flush to the
+ 	// account DB, so that we can drop the corresponding refcounts in
+ 	// au.accounts.
+-	flushcount := make(map[basics.Address]int)
++	var flushcount map[basics.Address]int
+
+ 	offset := uint64(newBase - au.dbRound)
+ 	err := au.dbs.wdb.Atomic(func(tx *sql.Tx) error {
++		flushcount = make(map[basics.Address]int)
+ 		for i := uint64(0); i < offset; i++ {
+ 			rnd := au.dbRound + basics.Round(i) + 1
+ 			err := accountsNewRound(tx, rnd, au.deltas[i], au.roundTotals[i+1].RewardsLevel, au.protos[i+1])","nit : I think that it would be ""cleaner"" to set the `flushcount` to nil in case of an error nice catch ;-)",Why not `var flushcount map[basics.Address]int`?
+5524,"@@ -19,13 +19,12 @@
+ package org.phoenicis.repository.repositoryTypes;
+
+ import org.junit.Test;
+-import org.phoenicis.repository.repositoryTypes.NullRepository;
+
+ import static org.junit.Assert.assertEquals;
+
+ public class NullRepositoryTest {
+     @Test
+     public void testNullRepositoryTest() {
+-        assertEquals(0, new NullRepository().fetchInstallableApplications().size());
++        assertEquals(null, new NullRepository().fetchInstallableApplications());
+     }
+ }",You may want to use assertNull,why change this?
+5525,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,Maybe add a cons
+5526,"@@ -224,7 +224,6 @@ struct wlr_output *wlr_wl_output_create(struct wlr_backend *_backend) {
+
+ 	wlr_output->width = 640;
+ 	wlr_output->height = 480;
+-	wlr_output->scale = 1;
+ 	strncpy(wlr_output->make, ""wayland"", sizeof(wlr_output->make));
+ 	strncpy(wlr_output->model, ""wayland"", sizeof(wlr_output->model));
+ 	snprintf(wlr_output->name, sizeof(wlr_output->name), ""WL-%zd"",",Why did you remove this?,Why is this bein
+5527,"@@ -72,7 +72,12 @@ func mapPort(m portmap.Interface, c chan struct{}, protocol string, extPort, int
+ 		}
+ 	}()
+ 	for {
+-		addMapping(m, protocol, extPort, intPort, name, publisher)
++		err := addMapping(m, protocol, extPort, intPort, name, publisher)
++		if err != nil {
++			log.Infof(""%s, Mapping for port %d failed: %s"", logPrefix, extPort, err)
++		} else {
++			log.Info(""%s, Mapped network port: %d"", logPrefix, extPort)
++		}
+ 		select {
+ 		case <-c:
+ 			return",Why we need another error printouts? We already have it inside addMapping..,if `err != nil`
+5528,"@@ -215,7 +215,7 @@ bool CoreChecks::ValidateFsOutputsAgainstDynamicRenderingRenderPass(SHADER_MODUL
+     const bool alpha_to_coverage_enabled = pipeline->create_info.graphics.pMultisampleState != NULL &&
+         pipeline->create_info.graphics.pMultisampleState->alphaToCoverageEnable == VK_TRUE;
+
+-    for (uint32_t location = 0; location < pipeline->rp_state->dynamic_rendering_pipeline_create_info.colorAttachmentCount; ++location) {
++    for (uint32_t location = 0; location < location_map.size(); ++location) {
+          const auto output = location_map[location].output;
+
+         if (!output && pipeline->attachments[location].colorWriteMask != 0) {","This LGTM, but I'm curious if this fixed a specific error you were hitting?","location_map.size() is a bit over-the-top, but location_map is of type std::vector<uint32_t>"
+5529,"@@ -181,7 +181,9 @@ func parseCgroupFromReader(r io.Reader) (map[string]string, error) {
+ 		}
+
+ 		for _, subs := range strings.Split(parts[1], "","") {
+-			cgroups[subs] = parts[2]
++			if subs != """" {
++				cgroups[subs] = parts[2]
++			}
+ 		}
+ 	}
+ 	if err := s.Err(); err != nil {","Actually we rely on this functionality in cgroup v2, where the subsystem is empty.","Is this a ""bug"" if the group is empty?"
+5530,"@@ -1,10 +1,12 @@
+-package core
++package core_test
+
+ import (
+ 	""testing""
+ 	""unsafe""
+
+ 	""github.com/google/go-cmp/cmp""
++
++	""go.opentelemetry.io/api/core""
+ 	""go.opentelemetry.io/api/registry""
+ )
+ ",suggestion: use `core` package name,Why is this separate from other standard library imports?
+5531,"@@ -1354,7 +1354,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+
+     # TODO: enable doctests once we drop Spark 2.3.x (due to type coercion logic
+     #  when creating arrays)
+-    def transpose(self, limit: Optional[int] = 1000):
++    def transpose(self, limit: Optional[int] = get_option(""compute.max_rows"")):
+         """"""
+         Transpose index and columns.
+ ",I think we can entirely remove this `limit` parameter for now to be consistent with other APIs.,"Can you add a docstring for this method, please?"
+5532,"@@ -0,0 +1,9 @@
++from localstack.services.infra import start_moto_server
++from localstack import config
++
++
++def start_rg(port=None, asynchronous=False, update_listener=None):
++    port = port or config.PORT_RESOURCE_GROUPS
++
++    return start_moto_server('resource-groups', port, name='Resource Groups Tagging API',
++        asynchronous=asynchronous, update_listener=update_listener)",nit: `Resource Groups Tagging API` -> `Resource Groups API`,"The name of this function is `start_rg`, not `start_moto_server`."
+5533,"@@ -5,10 +5,16 @@
+ package ecr
+
+ import (
++	""encoding/base64""
++	""errors""
+ 	""fmt""
+ 	""strings""
+
++	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/aws-sdk-go/aws/arn""
++	""github.com/aws/aws-sdk-go/aws/session""
++	""github.com/aws/aws-sdk-go/service/ecr""
++	""github.com/aws/aws-sdk-go/service/ecr/ecriface""
+ )
+
+ const (","This type of list + delete always make me a bit uneasy but guess there's no atomic way to do this...... Could you put a todo to retry the ""ClearRepository + delete repo"" flow a few times? Basically, imagine a new image is added right after we call `ListImages`, then `DeleteImages` will not delete that newly added image. Then the delete repo call will fail",Nit: Please sort this new import in the third-party imports secti
+5534,"@@ -1,5 +1,11 @@
+-define(['dom', 'scrollManager'], function (dom, scrollManager) {
+-    'use strict';
++/* eslint-disable indent */
++
++import dom from 'dom';
++import scrollManager from 'scrollManager';
++
++/* eslint-disable no-unused-expressions */
++'use strict';
++/* eslint-enable no-unused-expressions */
+
+     var scopes = [];
+     function pushScope(elem) {",You can remove this since ES6 modules are strict by default. And thanks for contributing to the Jellyfin Project.,Is there a reason to use `no-unused-expressions` here?
+5535,"@@ -32,7 +32,7 @@ public class TransactionRLPDecoderTest {
+   private static final String FRONTIER_TX_RLP =
+       ""0xf901fc8032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b561ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
+   private static final String EIP1559_TX_RLP =
+-      ""0xf902028032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b5682020f8201711ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
++      ""0xb902060ff902028032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b5682020f8201711ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
+   private static final String GOQUORUM_PRIVATE_TX_RLP =
+       ""0xf88d0b808347b7608080b840290a80a37d198ff06abe189b638ff53ac8a8dc51a0aff07609d2aa75342783ae493b3e3c6b564c0eebe49284b05a0726fb33087b9e0231d349ea0c7b5661c8c526a07144db7045a395e608cda6ab051c86cc4fb42e319960b82087f3b26f0cbc3c2da00223ac129b22aec7a6c2ace3c3ef39c5eaaa54070fd82d8ee2140b0e70b1dca9"";
+ ",Why did eip1559 go from a list (0xf9020280.....) to a wrapped string (0xb902060ff9020280...) and not just concatenation (0x0ff9020280...)? implementation detail or is this how it sits on the wire now?,I think this should be called FRONTIER_TX_RLP_VERSION = 1.0
+5536,"@@ -1334,9 +1334,9 @@ func TestConfigCheckIncludes(t *testing.T) {
+ 	if err == nil {
+ 		t.Errorf(""Expected error processing include files with configuration check enabled: %v"", err)
+ 	}
+-	expectedErr := errors.New(`configs/include_bad_conf_check_b.conf:10:19: unknown field ""monitoring_port""` + ""\n"")
+-	if err != nil && expectedErr != nil && err.Error() != expectedErr.Error() {
+-		t.Errorf(""Expected: \n%q, got\n: %q"", expectedErr.Error(), err.Error())
++	expectedErr := `include_bad_conf_check_b.conf:10:19: unknown field ""monitoring_port""` + ""\n""
++	if err != nil && !strings.HasSuffix(err.Error(), expectedErr) {
++		t.Errorf(""Expected: \n%q, got\n: %q"", expectedErr, err.Error())
+ 	}
+ }
+ ",@wallyqs Since on Windows it would be `\` instead of `/` I just look at the suffix past `configs/`. Let me know if that's ok or not.,"Shouldn't this be `!strings.HasSuffix(err.Error(), expectedErr)`?"
+5537,"@@ -1385,5 +1385,12 @@ func (a *WebAPI) GetInsightData(ctx context.Context, req *webservice.GetInsightD
+ 	return &webservice.GetInsightDataResponse{
+ 		UpdatedAt:  updateAt,
+ 		DataPoints: idp,
++		Type:       model.InsightResultType_MATRIX,
++		Matrix: []*model.InsightSampleStream{
++			{
++				Labels:     nil,
++				DataPoints: idp,
++			},
++		},
+ 	}, nil
+ }",nit: Remove this assignment because it is not necessary.,"Instead of hardcoding this value, let's just set the `dataPoints`"
+5538,"@@ -217,7 +217,10 @@ ostree_builtin_summary (int argc, char **argv, GCancellable *cancellable, GError
+       if (opt_raw)
+         flags |= OSTREE_DUMP_RAW;
+
+-      summary_data = ot_file_mapat_bytes (repo->repo_dir_fd, ""summary"", error);
++      glnx_fd_close int fd = -1;
++      if (!glnx_openat_rdonly (repo->repo_dir_fd, ""summary"", TRUE, &fd, error))
++        return FALSE;
++      summary_data = ot_fd_readall_or_mmap (fd, 0, error);
+       if (!summary_data)
+         return FALSE;
+ ","This seems like a common enough pattern to offer an equivalent wrapper in `ot-fs-util.c`, no?",This was changed to `glnx_fd_openat_ms` so that it would work wit
+5539,"@@ -328,6 +328,7 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
+         boolean isItemHasDownloadLink = media != null && (media instanceof FeedMedia) && ((FeedMedia) media).getDownload_url() != null;
+         menu.findItem(R.id.share_download_url_item).setVisible(isItemHasDownloadLink);
+         menu.findItem(R.id.share_download_url_with_position_item).setVisible(isItemHasDownloadLink);
++        menu.findItem(R.id.share_file).setVisible(((FeedMedia) media).fileExists());
+
+         menu.findItem(R.id.share_item).setVisible(hasWebsiteLink || isItemAndHasLink || isItemHasDownloadLink);
+ ",Wouldn't this crash the app if the user is currently listening to a stream?,Wouldn't it make sense to show the share if the media is a `FeedM
+5540,"@@ -530,10 +530,10 @@ type listFn func(remote string, object *swift.Object, isDirectory bool) error
+ //
+ // Set recurse to read sub directories
+ func (f *Fs) listContainerRoot(container, directory, prefix string, addContainer bool, recurse bool, fn listFn) error {
+-	if prefix != """" {
++	if prefix != """" && !strings.HasSuffix(prefix, ""/"") {
+ 		prefix += ""/""
+ 	}
+-	if directory != """" {
++	if directory != """" && !strings.HasSuffix(directory, ""/"") {
+ 		directory += ""/""
+ 	}
+ 	// Options for ObjectsWalk",This looks like an unrelated change? What is it for?,"Do we still need the check on `strings.HasSuffix(directory, ""/"")`?"
+5541,"@@ -0,0 +1,7 @@
++package csv
++
++import ""sync/atomic""
++
++func (d *tableDecoder) IsDone() bool {
++	return d.empty || atomic.LoadInt32(&d.used) != 0
++}","Wait, what is this doing? Is this a way to create methods that are only accessible from tests?",Can you use `atomic.LoadInt32` here as well?
+5542,"@@ -93,6 +93,11 @@ func (s *Service) list(c *gin.Context) {
+ 	name := c.Query(""name"")
+ 	ns := c.Query(""namespace"")
+
++	canList := utils.CanListChaos(c, ns)
++	if !canList {
++		return
++	}
++
+ 	metas, err := s.archive.ListMeta(context.Background(), kind, ns, name, true)
+ 	if err != nil {
+ 		c.Status(http.StatusInternalServerError)","Is it more reasonable to return some errors here, such as returning error codes (403 and so on?) ?","If `canList` is true, shouldn't we also check that `name != """"`? O"
+5543,"@@ -68,7 +68,11 @@ export function createVNode(type, props, key, ref) {
+ 		_parent: null,
+ 		_depth: 0,
+ 		_dom: null,
+-		_lastDomChild: null,
++		// _lastDomChildSibling must be initialized to undefined b/c it will eventually
++		// be set to dom.nextSibling which can return `null` and it is important
++		// to be able to distinguish between an uninitialized _lastDomChildSibling and
++		// a _lastDomChildSibling that has been set to `null`
++		_lastDomChildSibling: undefined,
+ 		_component: null,
+ 		constructor: undefined
+ 	};",Thinking out loud... would `_nextDom` be a better name for this?,"I'm not sure if this is a good idea for now, but it would be nice "
+5544,"@@ -165,11 +165,6 @@ class TestSuperfluousParentheses(CheckerTestCase):
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (foo):"", 0),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if ((foo, bar)):"", 0),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (foo(bar)):"", 0),
+-            (
+-                Message(""superfluous-parens"", line=1, args=""return""),
+-                ""return ((x for x in x))"",
+-                0,
+-            ),
+             (Message(""superfluous-parens"", line=1, args=""not""), ""not (foo)"", 0),
+             (Message(""superfluous-parens"", line=1, args=""not""), ""if not (foo):"", 1),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (not (foo)):"", 0),",Turns out the unittests also had a false positive.,I wonder if we should leave the tests untouched.
+5545,"@@ -24,12 +24,12 @@ namespace OpenTelemetry.Metrics
+     public abstract class Meter
+     {
+         /// <summary>
+-        /// Creates a counter for long with given name.
++        /// Creates a counter for Int64 with given name.
+         /// </summary>
+         /// <param name=""name"">The name of the counter.</param>
+         /// <param name=""monotonic"">indicates if only positive values are expected.</param>
+         /// <returns>The counter instance.</returns>
+-        public abstract Counter<long> CreateLongCounter(string name, bool monotonic = true);
++        public Counter<long> CreateInt64Counter(string name, bool monotonic = true) => this.CreateCounter<long>(name, monotonic);
+
+         /// <summary>
+         /// Creates a counter for double with given name.","I think these method names would be clearer if written as ""Create a {type} counter|gauge|measure with given name"". eg ""Create a int64 counter with given name"" ""Create a double gauge with given name""",Would it make sense to rename this to CreateCoun
+5546,"@@ -3530,7 +3530,7 @@ int LuaScriptInterface::luaDoChallengeCreature(lua_State* L)
+ int LuaScriptInterface::luaIsValidUID(lua_State* L)
+ {
+ 	//isValidUID(uid)
+-	pushBoolean(L, getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)) != nullptr);
++	pushBoolean(L, getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)));
+ 	return 1;
+ }
+ ","it pushes a boolean, so it has to be explicitly casted to boolean with != nullptr, same with all other similar stuff","why not just change this line to `pushBoolean(L,"
+5547,"@@ -237,6 +237,7 @@ Publisher* ParticipantImpl::createPublisher(
+         delete(pubimpl);
+         return nullptr;
+     }
++    pubimpl->m_history.rebuild_instances();
+     pubimpl->mp_writer = writer;
+     //SAVE THE PUBLISHER PAIR
+     t_p_PublisherPair pubpair;",It would be nice to have an equivalent of this call on `DataWriterImpl::enable`,Is rebuild_instances() called from a different t
+5548,"@@ -1112,6 +1112,7 @@ func (a *PipedAPI) CreateDeploymentChain(ctx context.Context, req *pipedservice.
+ 				},
+ 			},
+ 		},
++		Status:    model.ChainBlockStatus_DEPLOYMENT_BLOCK_RUNNING,
+ 		StartedAt: time.Now().Unix(),
+ 	})
+ ",Isn't this PENDING?,@se3000 @mikedoan please review if this is the right way to do this.
+5549,"@@ -30,16 +30,14 @@ function isLandmark(virtualNode) {
+ 	var explictRole = (node.getAttribute('role') || '').trim().toLowerCase();
+
+ 	if (explictRole) {
+-		if (explictRole === 'form') {
+-			return !!aria.labelVirtual(virtualNode);
+-		}
+ 		return landmarkRoles.includes(explictRole);
+ 	} else {
+ 		// Check if the node matches any of the CSS selectors of implicit landmarks
+ 		return implicitLandmarks.some(implicitSelector => {
+ 			let matches = axe.utils.matchesSelector(node, implicitSelector);
+ 			if (node.tagName.toLowerCase() === 'form') {
+-				return matches && !!aria.labelVirtual(virtualNode);
++				let title = node.getAttribute('title') || '';
++				return matches && (!!aria.labelVirtual(virtualNode) || !!axe.commons.text.sanitize(title) );
+ 			}
+ 			return matches;
+ 		});","minor detail, why aim to sanitize title if tile is empty (in some cases)? worth adding an && to check for that.",you can remove the `!!` as well
+5550,"@@ -28,9 +28,8 @@ package com.salesforce.androidsdk.smartsync.target;
+
+ import android.text.TextUtils;
+
+-import com.salesforce.androidsdk.smartstore.store.QuerySpec;
+-import com.salesforce.androidsdk.smartstore.store.SmartStore;
+ import com.salesforce.androidsdk.smartsync.manager.SyncManager;
++import com.salesforce.androidsdk.smartsync.target.ParentChildrenSyncTargetHelper.RelationshipType;
+ import com.salesforce.androidsdk.smartsync.util.ChildrenInfo;
+ import com.salesforce.androidsdk.smartsync.util.Constants;
+ import com.salesforce.androidsdk.smartsync.util.ParentInfo;",Code shared by ParentChildrenSyncDownTarget and ParentChildrenSyncUpTarget moved to ParentChildrenSyncTargetHelper,We might want to move this to `TargetHelper`
+5551,"@@ -75,12 +75,12 @@ class Local(Provisioning):
+     def startup(self):
+         self.start_time = time.time()
+
+-        self.available_slots = self.settings.get(""capacity"", None)
+-        if not self.available_slots:
+-            if self.settings.get(""sequential"", False):
+-                self.available_slots = 1
+-            else:
+-                self.available_slots = sys.maxsize      # no limit
++        if self.settings.get(""sequential"", False):
++            self.available_slots = 1
++        else:
++            self.available_slots = self.settings.get(""capacity"", None)
++            if not self.available_slots:
++                self.available_slots = sys.maxsize  # no limit
+
+         for executor in self.executors:
+             start_at = executor.execution.get('start-at', 0)","The bug is not about the priority , But we use 2 config items CAPACITY and SEQUENTIAL to control 1 action: thoughput. If 'sequential' is given to 'False' as default in configfile and then I use 'capacity' to 10 in my test.yml , the 'capacity' 's priority should be higher than default 'sequential'. So, I suggest we use only one 'capacity', it is enough. '1' is sequential, more than 1 is capacity, None is sys.maxsize.",Nitpick: there is a space between `None` and `False`.
+5552,"@@ -9,10 +9,13 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+
++	tf ""github.com/filecoin-project/go-filecoin/testhelpers/testflags""
+ 	mockplugin ""github.com/filecoin-project/go-filecoin/tools/iptb-plugins/filecoin/mock""
+ )
+
+ func TestStartLogCapture(t *testing.T) {
++	tf.IntegrationTest(t)
++
+ 	assert := assert.New(t)
+ 	require := require.New(t)
+ 	ctx := context.Background()","I don't know if I'd call any of these FAST tests integration tests. They are unit tests for FAST. They use a mock plugin which doesn't actually start any external processes, etc.",Would it make sense to have an `integrationTest` fixture that is used in all the tests?
+5553,"@@ -27,10 +27,12 @@ const (
+ 	invalidVersion version = ""invalid.version""
+ )
+
++// CurrentVersion returns the version of the calling instance
+ func CurrentVersion() version {
+ 	return version(mver.GetVersion())
+ }
+
++// Version returns the version in version type if present
+ func Version(version string) version {
+ 	switch version {
+ 	case ""0.7.0"":",Can you provide corresponding UT for this.,// CurrentVersion returns the version of the calling instance if present
+5554,"@@ -29,6 +29,8 @@ import (
+ 	""testing""
+ 	""time""
+
++	""golang.org/x/net/context""
++
+ 	""github.com/yarpc/yarpc-go/encoding/raw""
+ 	""github.com/yarpc/yarpc-go/transport""
+ 	""github.com/yarpc/yarpc-go/transport/transporttest""",nit: this should be below the yarpc group,does this import really need to be here?
+5555,"@@ -44,6 +44,10 @@ func New(name, tip string, labelNames []string, defaultLabels []string) (*TimerF
+ 		labelNames,
+ 	)
+ 	err := prometheus.Register(vect)
++	switch err.(type) {
++	case prometheus.AlreadyRegisteredError:
++		err = nil
++	}
+
+ 	return &TimerFactory{
+ 		labelNames:    labelNames,",singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`),What should we do in this case? I don't see a case where we want to return this error.
+5556,"@@ -442,7 +442,17 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			retry := 0
++			for err != nil && retry < 10 {
++				// Set Ready and Live to false
++				healthAggregator.Report(healthName, &health.HealthReport{Live: false, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Warn(""Retrying to start Typha"")
++				retry++
++			}
++			if err != nil && retry > 10 {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()","Please log once here at Error level ""Failed to connect to Typha, will retry...""",Shouldn't this be returning? Why do we want to continue with an error?
+5557,"@@ -31,7 +31,7 @@ func TestICMPPortUnreachable(t *testing.T) {
+ 	_, ipv4, _, _, pktBytes, err := testPacketUDPDefault()
+ 	Expect(err).NotTo(HaveOccurred())
+
+-	runBpfUnitTest(t, ""icmp_port_unreachable.c"", func(bpfrun bpfProgRunFn) {
++	runBpfUnitTest(t, ""icmp_port_unreachable.c"", false, func(bpfrun bpfProgRunFn) {
+ 		res, err := bpfrun(pktBytes)
+ 		Expect(err).NotTo(HaveOccurred())
+ 		Expect(res.Retval).To(Equal(0))","Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes.",It would be better to use a constant for the name of the test.
+5558,"@@ -6,11 +6,14 @@ from pyramid import httpexceptions
+
+
+ class NameGenerator(generators.Generator):
++    regexp = r'^[a-zA-Z0-9][a-zA-Z0-9_-]*$'
++
+     def __call__(self):
+         ascii_letters = ('abcdefghijklmopqrstuvwxyz'
+                          'ABCDEFGHIJKLMOPQRSTUVWXYZ')
+-        alphabet = ascii_letters + string.digits + '-'
+-        letters = [random.choice(alphabet) for x in range(8)]
++        alphabet = ascii_letters + string.digits + '-_'
++        letters = [random.choice(ascii_letters + string.digits)]
++        letters += [random.choice(alphabet) for x in range(7)]
+         return ''.join(letters)
+
+ ",So we fix it only for kinto and not for all cliquet resources?,why do we need to change this?
+5559,"@@ -11,9 +11,10 @@ import (
+ 	""fmt""
+ 	""math/big""
+
+-	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ 	""github.com/pkg/errors""
+
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
++
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""",No empty line between,Did you mean to change this line?
+5560,"@@ -141,6 +141,9 @@ func main() {
+ 				fatal(err)
+ 			}
+ 		}
++		if err := reviseRootDir(context); err != nil {
++			return err
++		}
+ 		return logs.ConfigureLogging(createLogConfig(context))
+ 	}
+ ",We have `ResolveRootfs` in `libcontainer/utils` so maybe use that one here?,does this need to be inside the `CreateLogConfig` function?
+5561,"@@ -630,6 +630,19 @@ namespace AutoRest.Swagger.Tests
+             messages.AssertOnlyValidationMessage(typeof(SummaryAndDescriptionMustNotBeSame), 1);
+         }
+
++        [Fact]
++        public void LongRunningHasExtensionValidation()
++        {
++            var messages = ValidateSwagger(Path.Combine(Core.Utilities.Extensions.CodeBaseDirectory, ""Resource"", ""Swagger"", ""Validation"", ""long-running-operation-extension.json""));
++            messages.AssertOnlyValidationMessage(typeof(LongRunningOperationsWithLongRunningExtension), 1);
++        }
++
++        [Fact]
++        public void LongRunningHasExtensionTrueValidation()
++        {
++            var messages = ValidateSwagger(Path.Combine(Core.Utilities.Extensions.CodeBaseDirectory, ""Resource"", ""Swagger"", ""Validation"", ""long-running-operation-extension-2.json""));
++            messages.AssertOnlyValidationMessage(typeof(LongRunningOperationsWithLongRunningExtension), 1);
++        }
+     }
+
+     #region Positive tests","Just curious, do we have positive test covered somewhere?",Can you also validate that the extension is present?
+5562,"@@ -101,7 +101,7 @@ static void move_resize(struct roots_view *view, double x, double y,
+ 		constrained_height);
+ 	if (serial > 0) {
+ 		roots_surface->pending_move_resize_configure_serial = serial;
+-	} else {
++	} else if(roots_surface->pending_move_resize_configure_serial == 0) {
+ 		view->x = x;
+ 		view->y = y;
+ 	}","Style error, put a space between `if` and `(`",Please put a space between `if` and the opening parenthesis
+5563,"@@ -239,6 +239,13 @@ type Config struct {
+ 	//    	Key: aws.String(""/foo/bar/moo""),
+ 	//    })
+ 	EnableEndpointDiscovery *bool
++
++	// DisableEndpointHostPrefix will disable the SDK's behavior of prefixing
++	// request endpoint hosts with modeled information.
++	//
++	// Disabling this feature is useful when you want to use local endpoints
++	// for testing that do not support the modeled host prefix pattern.
++	DisableEndpointHostPrefix *bool
+ }
+
+ // NewConfig returns a new Config pointer that can be chained with builder","It's a bit odd to have a ""disable<x>"" boolean, though it looks like you already do that for a few other flags.",You'll also need to update the corresponding test configura
+5564,"@@ -47,6 +47,7 @@ const (
+ // Timelimits for docker operations enforced above docker
+ const (
+ 	pullImageTimeout        = 2 * time.Hour
++	loadImageTimeout        = 2 * time.Hour
+ 	createContainerTimeout  = 3 * time.Minute
+ 	startContainerTimeout   = 1*time.Minute + 30*time.Second
+ 	stopContainerTimeout    = 1 * time.Minute",Why did you pick two hours for this?,Why is this in libpod? I don't see it used anywhere.
+5565,"@@ -110,8 +110,8 @@ func getNewPassword(gopts GlobalOptions) (string, error) {
+ 	newopts.password = """"
+
+ 	return ReadPasswordTwice(newopts,
+-		""enter password for new key: "",
+-		""enter password again: "")
++		""enter password (new): "",
++		""enter password (again): "")
+ }
+
+ func addKey(gopts GlobalOptions, repo *repository.Repository) error {","What about ""enter new password""? That would be a bit more consistent to the `ReadPasswordTwice` usage in cmd_init.","I think the original message was better, `enter pass"
+5566,"@@ -20,7 +20,7 @@ if not versionInfo.updateVersionType:
+ 	raise RuntimeError(""No update version type, update checking not supported"")
+ import addonAPIVersion
+ # Avoid a E402 'module level import not at top of file' warning, because several checks are performed above.
+-from gui.contextHelp import ContextHelpMixin  # noqa: E402
++import gui.contextHelp  # noqa: E402
+ from gui.dpiScalingHelper import DpiScalingHelperMixin, DpiScalingHelperMixinWithoutInit  # noqa: E402
+ import winVersion
+ import os",Another redundant import,was this intentional?
+5567,"@@ -120,7 +120,7 @@ func (c *client) FetchUpdates(ctx context.Context, req *node.FetchX509SVIDReques
+ 	// Close the stream whether there was an error or not
+ 	stream.CloseSend()
+ 	if err != nil {
+-		// TODO: should we try to create a new stream?
++		c.Release()
+ 		return nil, err
+ 	}
+ ","What kind of errors might cause us to reach this point? Could any of them be recoverable i.e. might work if we asked the same server again? Similar question for below, but perhaps with a slightly different answer",Shouldn't this happen after the err check on line 10
+5568,"@@ -212,14 +212,14 @@ public:
+
+ class triangle_counting_test {
+ public:
+-    using my_graph_type = dal::preview::undirected_adjacency_vector_graph<>;
++    using graph_type = dal::preview::undirected_adjacency_vector_graph<>;
+
+     template <typename GraphType>
+     auto create_graph() {
+         GraphType graph_data;
+-        my_graph_type my_graph;
++        graph_type graph;
+
+-        auto &graph_impl = oneapi::dal::detail::get_impl(my_graph);
++        auto &graph_impl = oneapi::dal::detail::get_impl(graph);
+         auto &vertex_allocator = graph_impl._vertex_allocator;
+         auto &edge_allocator = graph_impl._edge_allocator;
+ ",What is the difference between GraphType and graph_type. Naming should be more accurate.,Why did you change this from `my_graph_type` to `graph`?
+5569,"@@ -9,7 +9,7 @@ use Shopsys\FrameworkBundle\Model\Product\Product;
+ class UnitRepository
+ {
+     /**
+-     * @var \Doctrine\ORM\EntityRepository
++     * @var \Doctrine\ORM\EntityManagerInterface
+      */
+     protected $em;
+ ",hmmm in docblock of contructor it is EntityManagerInterface....maybe it should be that way.... :confused:,Shouldn't this stay as `EntityRepository`?
+5570,"@@ -54,8 +54,13 @@ struct feat_wrapper {
+         .def(""GetPos"",
+              (RDGeom::Point3D(MolChemicalFeature::*)(int) const) &
+                  MolChemicalFeature::getPos,
+-             (python::arg(""self""), python::arg(""confId"") = -1),
++             (python::arg(""self""), python::arg(""confId"")),
+              ""Get the location of the chemical feature"")
++        .def(""GetPosDefault"",
++             (RDGeom::Point3D(MolChemicalFeature::*)() const) &
++                 MolChemicalFeature::getPos,
++             python::arg(""self""),
++             ""Get the location of the default chemical feature (first position)"")
+         .def(""GetAtomIds"", getFeatAtomIds,
+              ""Get the IDs of the atoms that participate in the feature"")
+         .def(""GetMol"", &MolChemicalFeature::getMol,","I'm curious why you went the route of adding a new method name for this. Given that you it would be possible to just have an an overload of `GetPos()`, and that this change breaks existing code, I wonder why you chose to go this way.","Could this be a bit more descriptive? Maybe ""Get the pos"
+5571,"@@ -33,12 +33,14 @@ export default Component.extend({
+         let subscriptions = this.member.get('stripe');
+         if (subscriptions && subscriptions.length > 0) {
+             return subscriptions.map((subscription) => {
++                const statusLabel = subscription.status === 'past_due' ? 'Past due' : subscription.status;
+                 return {
+                     id: subscription.id,
+                     customer: subscription.customer,
+                     name: subscription.name || '',
+                     email: subscription.email || '',
+                     status: subscription.status,
++                    statusLabel: statusLabel,
+                     startDate: subscription.start_date ? moment(subscription.start_date).format('D MMM YYYY') : '-',
+                     plan: subscription.plan,
+                     amount: parseInt(subscription.plan.amount) ? (subscription.plan.amount / 100) : 0,",Does this need to change `'active'` to `'Active'` and that? Or is that done in CSS or something?,Why not set the label based on the current status? I thi
+5572,"@@ -11,6 +11,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     public class Http2Limits
+     {
+         private int _maxStreamsPerConnection = 100;
++        private int _headerTableSize = MaxAllowedHeaderTableSize;
++        private int _maxFrameSize = MinAllowedMaxFrameSize;
++
++        // These are limits defined by the RFC https://tools.ietf.org/html/rfc7540#section-4.2
++        public const int MaxAllowedHeaderTableSize = 4096;
++        public const int MinAllowedMaxFrameSize = 16 * 1024;
++        public const int MaxAllowedMaxFrameSize = 16 * 1024 * 1024 - 1;
+
+         /// <summary>
+         /// Limits the number of concurrent request streams per HTTP/2 connection. Excess streams will be refused.",Why are these constants public? They should also be listed above members.,This seems to be the wrong place for this. These are _headerTableSize and _maxFrameSize.
+5573,"@@ -217,6 +217,8 @@ public class MainnetTransactionValidator {
+     // org.bouncycastle.math.ec.ECCurve.AbstractFp.decompressPoint throws an
+     // IllegalArgumentException for ""Invalid point compression"" for bad signatures.
+     try {
++      // TODO: this is where we are checking the signature. We have to fix the v value if this is a
++      // private transaction
+       transaction.getSender();
+     } catch (final IllegalArgumentException e) {
+       return ValidationResult.invalid(",This TODO isn't related to this change. We should remove it.,This is where we have to fix the v value when we create a transaction.
+5574,"@@ -27,7 +27,5 @@ import org.apache.iceberg.FieldMetrics;
+ public interface ValueWriter<D> {
+   void write(D datum, Encoder encoder) throws IOException;
+
+-  default Stream<FieldMetrics> metrics() {
+-    return Stream.empty(); // TODO will populate in following PRs
+-  }
++  Stream<FieldMetrics> metrics();
+ }","`FieldMetrics` is parameterized, but this is a bare reference. Could you update it? I think it should be `FieldMetrics<?>` since the metrics are not necessarily for the written value type, `D`.",Hmmm - I think we should return `Stream<FieldMetrics>` here instead. The compiler will g
+5575,"@@ -58,12 +58,11 @@ namespace Examples.Console
+             // Application which decides to enable OpenTelemetry metrics
+             // would setup a MeterProvider and make it default.
+             // All meters from this factory will be configured with the common processing pipeline.
+-            MeterProvider.SetDefault(Sdk.CreateMeterProvider(mb =>
+-            {
+-                mb.SetMetricProcessor(processor);
+-                mb.SetMetricExporter(promExporter);
+-                mb.SetMetricPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs));
+-            }));
++            MeterProvider.SetDefault(Sdk.CreateMeterProviderBuilder()
++                .SetProcessor(processor)
++                .SetExporter(promExporter)
++                .SetPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs))
++                .Build());
+
+             // The following shows how libraries would obtain a MeterProvider.
+             // MeterProvider is the entry point, which provides Meter.",@cijothomas do we want this to be `Set` or `Add`?,"This is a breaking change, as the `CreateMeterProvider` method is no longer marked as `i"
+5576,"@@ -42,7 +42,7 @@ namespace Nethermind.JsonRpc
+         public string? IpcUnixDomainSocketPath { get; set; } = null;
+
+         public string[] EnabledModules { get; set; } = ModuleType.DefaultModules.ToArray();
+-        public long? GasCap { get; set; } = 100000000;
++        public long? GasCap { get; set; } = 50000000;
+         public int ReportIntervalSeconds { get; set; } = 300;
+         public bool BufferResponses { get; set; }
+         public string CallsFilterFilePath { get; set; } = ""Data/jsonrpc.filter"";",Why are we dropping GasCap?,What's the purpose of this change?
+5577,"@@ -45,11 +45,11 @@ namespace OpenTelemetry.Shims.OpenTracing
+
+         public SpanShim(TelemetrySpan span)
+         {
+-            this.Span = span ?? throw new ArgumentNullException(nameof(span));
++            this.Span = span ?? throw new ArgumentNullException(nameof(span), ""Parameter cannot be null"");
+
+             if (!this.Span.Context.IsValid)
+             {
+-                throw new ArgumentException(nameof(this.Span.Context));
++                throw new ArgumentException(""Passed span's context is not valid"", nameof(this.Span.Context));
+             }
+
+             this.spanContextShim = new SpanContextShim(this.Span.Context);",should we end the text with a .?,Are you sure you want to use nameo
+5578,"@@ -752,9 +752,10 @@ dispatch_enter_dynamorio(dcontext_t *dcontext)
+            wherewasi == DR_WHERE_APP ||
+            /* If the thread was waiting at check_wait_at_safe_point when getting
+             * suspended, we were in dispatch (ref i#3427). We will be here after the
+-            * thread's context is being reset before sending it native.
++            * thread's context is being reset proactively (due to some -reset_at_*
++            * option) or before sending it native.
+             */
+-           (dcontext->go_native && wherewasi == DR_WHERE_DISPATCH));
++           wherewasi == DR_WHERE_DISPATCH);
+     dcontext->whereami = DR_WHERE_DISPATCH;
+     ASSERT_LOCAL_HEAP_UNPROTECTED(dcontext);
+     ASSERT(check_should_be_protected(DATASEC_RARELY_PROT));","Could this instead keep the `go_native` and add to it ""or the last exit was the special reset exit""?",This check is now redundant with `
+5579,"@@ -42,9 +42,9 @@ ConfigPanelDialog::ConfigPanelDialog(LXQtPanel *panel, QWidget *parent):
+     addPage(mPluginsPage, tr(""Widgets""), QLatin1String(""preferences-plugin""));
+     connect(this, &ConfigPanelDialog::reset, mPluginsPage, &ConfigPluginsWidget::reset);
+
+-    connect(this, &ConfigPanelDialog::accepted, [panel] {
++    connect(this, &ConfigPanelDialog::accepted, this, [panel] {
+         panel->saveSettings();
+-   });
++    });
+ }
+
+ void ConfigPanelDialog::showConfigPanelPage()","Oh, I missed this one: The other instances of `this` you've added as lambda contexts aren't really needed, although they're harmless. However, in the above connection, the missing context is `panel`, not `this`. Please correct it! Clazy may show warnings about lambda contexts (I don't use Clazy) but, if so, that's a problem in clazy: it isn't smart enough to know about them.",Please don't make unnecessary chan
+5580,"@@ -160,14 +160,9 @@ class Service(object):
+                     except AttributeError:
+                         pass
+                 self.process.terminate()
+-                self.process.kill()
+                 self.process.wait()
++                self.process.kill()
+                 self.process = None
+         except OSError:
+             # kill may not be available under windows environment
+             pass
+-
+-    def __del__(self):
+-        # subprocess.Popen doesn't send signal on __del__;
+-        # we have to try to stop the launched process.
+-        self.stop()",can we add a try / except around this to make it more stable? I like the idea of any mistakenly un-quit drivers closing down after the process is quit (the java server does this... also i forget to do driver.quit often when i use the command line repl :) ),`self.process = None` is duplicated?
+5581,"@@ -68,9 +68,12 @@ func (vd *volAPI) cloudMigrateStatus(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	if err := json.NewDecoder(r.Body).Decode(statusReq); err != nil {
+-		vd.sendError(vd.name, method, w, err.Error(), http.StatusBadRequest)
+-		return
++	// Use empty request if nothing was sent
++	if r.ContentLength != 0 {
++		if err := json.NewDecoder(r.Body).Decode(statusReq); err != nil {
++			vd.sendError(vd.name, method, w, err.Error(), http.StatusBadRequest)
++			return
++		}
+ 	}
+
+ 	statusResp, err := d.CloudMigrateStatus(statusReq)",when would this happen? backward compatibility?,can we remove this `if` condition an
+5582,"@@ -0,0 +1,13 @@
++/**
++ * Returns the tagName,
++ * if it is a HTMLElement it gets lowercased
++ * @param  {Element} node element
++ * @return {String}       normalized tagName
++ */
++axe.utils.getTagName = function(node) {
++	if (node.namespaceURI === 'http://www.w3.org/1999/xhtml') {
++		return node.tagName.toLowerCase();
++	}
++
++	return node.tagName;
++};",I'm not sure what the value of this is. So far we've solved this by always doing `tagName.toUpperCase()` for everything. I think we should stick with this.,"`toLowerCase` is not needed here, `t"
+5583,"@@ -25,6 +25,16 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	snapshotListCommandHelpText = `
++Usage: mayactl snapshot list [options]
++
++$ mayactl snapshot list --volname <vol>
++
++This command displays status of available snapshot.
++`
++)
++
+ // NewCmdSnapshotCreate creates a snapshot of OpenEBS Volume
+ func NewCmdSnapshotList() *cobra.Command {
+ 	options := CmdSnaphotCreateOptions{}",This command displays available snapshots on a volume.,"update this to say ""This command dis"
+5584,"@@ -38,7 +38,7 @@ import (
+ 	""golang.org/x/tools/go/types/typeutil""
+
+ 	cpb ""kythe.io/kythe/proto/common_go_proto""
+-	spb ""kythe.io/kythe/proto/storage_go_proto""
++	stpb ""kythe.io/kythe/proto/storage_go_proto""
+ )
+
+ // EmitOptions control the behaviour of the Emit function. A nil options",`spb` is the standard package name we use for this proto.,I would call this `spb`
+5585,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change.",Shouldn't this be `var
+5586,"@@ -369,8 +369,8 @@ func msgToApplication(msg model.Message) (*Application, error) {
+ 	return app, nil
+ }
+
+-// TODO: upgrade to parallel process
+ // Process translate msg to application , process and send resp to edge
++// TODO: upgrade to parallel process
+ func (c *Center) Process(msg model.Message) {
+ 	app, err := msgToApplication(msg)
+ 	if err != nil {",is this pr support parallelly process application?,// TODO: parallel proce
+5587,"@@ -48,7 +48,9 @@ func MustEnableIssues(ctx *middleware.Context) {
+ }
+
+ func MustEnablePulls(ctx *middleware.Context) {
+-	if !ctx.Repo.Repository.EnablePulls {
++	if !ctx.Repo.Repository.CanEnablePulls() {
++		ctx.Handle(404, ""Unsupported"", nil)
++	} else if !ctx.Repo.Repository.EnablePulls {
+ 		ctx.Handle(404, ""MustEnablePulls"", nil)
+ 	}
+ ","Based on the assumption that when `EnablePulls` is `true`, `CanEnablePulls` must be `true` as well, then this `if` check is redundant. Actually... we have `AllowsPulls` now... why not use that?",Why not just call `ctx.
+5588,"@@ -637,7 +637,7 @@ public class ScheduleServlet extends LoginAbstractAzkabanServlet {
+     if (flow == null) {
+       ret.put(""status"", ""error"");
+       ret.put(""message"", ""Flow "" + flowName + "" cannot be found in project ""
+-          + project);
++          + projectName);
+       return;
+     }
+ ",I am not sure why the API requires both project name and project ID as inputs. Wouldn't it introduce more opportunities for clients to make mistakes?,unrelated to this PR but should we have a test to ensure that a flow is found in the project?
+5589,"@@ -15,7 +15,7 @@ module Ncr
+
+     def edit
+       if self.proposal.approved?
+-        flash[:warning] = ""You are about to modify a fully approved request. Changes will be logged and sent to approvers, and this request may require re-approval, depending on the change.""
++        flash.now[:warning] = ""You are about to modify a fully approved request. Changes will be logged and sent to approvers, and this request may require re-approval, depending on the change.""
+       end
+
+       super","I believe this was happening for several different flash messages - should we add `now` to all flash messages? (there might be a downside to doing that, but I am not sure what it would be)",Line is too long. [99/80]
+5590,"@@ -46,6 +46,9 @@ class ExceptionListener extends BaseExceptionListener
+         parent::__construct($controller, $logger);
+     }
+
++    /**
++     * {@inheritdoc}
++     */
+     public function onKernelException(GetResponseForExceptionEvent $event)
+     {
+         $exception = $event->getException();","There is no docblock on the parent method. Also, not related, but I forgot to typehint the `$templating` constructor argument above.",Why do you add this `onKernelException` method?
+5591,"@@ -669,6 +669,12 @@ func TestDdevXdebugEnabled(t *testing.T) {
+ 	runTime := util.TimeTrack(time.Now(), fmt.Sprintf(""%s %s"", site.Name, t.Name()))
+
+ 	phpVersions := nodeps.ValidPHPVersions
++
++	// arm64 builds from deb.sury.org do not have xdebug in php5.6
++	if runtime.GOARCH == ""arm64"" {
++		t.Log(""Skipping php5.6 test on arm64 because deb.sury.org packages do not include it currently"")
++		delete(phpVersions, ""5.6"")
++	}
+ 	phpKeys := make([]string, 0, len(phpVersions))
+ 	for k := range phpVersions {
+ 		phpKeys = append(phpKeys, k)","Silly me. This shouldn't be done in the tests, but instead in the actual definition of ValidPHPVersions on arm64. Same with Mysql and MariaDB.",Let's include the version in the log message here so we know what's going on.
+5592,"@@ -42,7 +42,8 @@ final class LatLonShapeBoundingBoxQuery extends ShapeQuery {
+   @Override
+   protected Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
+                                             int maxXOffset, int maxYOffset, byte[] maxTriangle) {
+-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
++    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
++        queryRelation == QueryRelation.INTERSECTS);
+   }
+
+   /** returns true if the query matches the encoded triangle */",Shouldn't this work as well for Disjoint?,this should be queryRelation == QueryRelation.INTERSECTS
+5593,"@@ -514,11 +514,11 @@ func (c *controller) finalizeOrder(ctx context.Context, cl acmecl.Interface, o *
+ 	// if it is already in the 'valid' state, as upon retry we will
+ 	// then retrieve the Certificate resource.
+ 	_, errUpdate := c.updateOrderStatus(ctx, cl, o)
+-	if acmeErr, ok := err.(*acmeapi.Error); ok {
++	if acmeErr, ok := errUpdate.(*acmeapi.Error); ok {
+ 		if acmeErr.StatusCode >= 400 && acmeErr.StatusCode < 500 {
+ 			log.Error(err, ""failed to update Order status due to a 4xx error, marking Order as failed"")
+ 			c.setOrderState(&o.Status, string(cmacme.Errored))
+-			o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", err)
++			o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", errUpdate)
+ 			return nil
+ 		}
+ 	}","You've not updated the `o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", err)` line below here when you changed this, so here we are checking `errUpdate` but will print the contents of `err` instead.","I'm honestly not sure about this change, as it's the onl"
+5594,"@@ -23,6 +23,9 @@ require 'socket'
+ module Selenium
+   module WebDriver
+     class SocketPoller
++      NOT_CONNECTED_ERRORS = [Errno::ECONNREFUSED, Errno::ENOTCONN, SocketError]
++      NOT_CONNECTED_ERRORS << Errno::EPERM if Platform.cygwin?
++
+       def initialize(host, port, timeout = 0, interval = 0.25)
+         @host     = host
+         @port     = Integer(port)",Doesn't this need to include `Errno::ECONNRESET` to fix the issue?,`EPERM` should be `ECONNREFUSED`
+5595,"@@ -301,6 +301,9 @@ public class Constants {
+     public static final String PROJECT_CACHE_SIZE_PERCENTAGE = ""azkaban""
+         + "".project_cache_size_percentage_of_disk"";
+
++    public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = ""azkaban""
++        + "".project_cache_throttle_percentage"";
++
+     // how many older versions of project files are kept in DB before deleting them
+     public static final String PROJECT_VERSION_RETENTION = ""project.version.retention"";
+ ","Please consider keeping the config key in one line as it will help in case someone is looking at how this config is used. public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = ""azkaban.project_cache_throttle_percentage"";",Why are we adding this new property?
+5596,"@@ -46,6 +46,7 @@ type DataStore interface {
+
+ 	ListParentIDEntries(request *ListParentIDEntriesRequest) (*ListParentIDEntriesResponse, error)
+ 	ListSelectorEntries(request *ListSelectorEntriesRequest) (*ListSelectorEntriesResponse, error)
++	ListPowerSelectorEntries(request *ListSelectorEntriesRequest) (*ListSelectorEntriesResponse, error)
+ 	ListSpiffeEntries(request *ListSpiffeEntriesRequest) (*ListSpiffeEntriesResponse, error)
+
+ 	RegisterToken(request *JoinToken) (*common.Empty, error)","This is a hard one, naming-wise... `ListPowerSelectorEntries` is logical given `ListSelectorEntries`. Another option could be `ListMatchingEntries` or even `FindMatchingEntries`. :shrug:",This is a breaking change and needs to be added to the interface.
+5597,"@@ -0,0 +1,4 @@
++package types
++
++// UVarint represent a 32-bit number encoded as varint.
++type UVarint uint",This should be called `Uint` or `Uint32` or simply using our `Uint64` type instead. All of our numbers have varint encoding. It's not inherently a varint.,do we need this file?
+5598,"@@ -1513,7 +1513,8 @@ class CommandDispatcher:
+             )
+
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+-    def view_source(self, edit=False):
++    @cmdutils.argument('pygment')
++    def view_source(self, edit=False, pygment=False):
+         """"""Show the source of the current page in a new tab.
+
+         Args:",No need for this when you don't need to customize anything about the argument.,Is it intended that `pygment` defaults to False?
+5599,"@@ -0,0 +1,14 @@
++<!-- TODO: Move this away from using ID attr -->
++<div class=""panel-group section-group""
++     data-modifiable=""<%= modifiable %>""
++     id=""sections_accordion""
++     role=""tablist"">
++  <% sections.each do |section| %>
++    <%= render partial: ""org_admin/sections/section"",
++               object: section,
++               locals: { phase: phase,
++                         template: template,
++                         current_section: current_section,
++                         draggable: section == sections.first } %>
++  <% end%>
++</div>",We're now going to have 3 `#sections_accordion` will need to see how JS behaves. We should probably switch to a class selector instead,"You don't need section here, you can just do `current_section.sec"
+5600,"@@ -0,0 +1,10 @@
++class CreateTestClientRequests < ActiveRecord::Migration
++  def change
++    create_table :test_client_requests do |t|
++      t.decimal :amount
++      t.string :project_title
++
++      t.timestamps null: false
++    end
++  end
++end",did you mean to leave this in here?,Rails/InverseOf: Specify an :inverse_of option.
+5601,"@@ -54,6 +54,7 @@ var (
+ 	labels               = flag.String(""labels"", """", ""List of label KEY=VALUE pairs to add. Keys must start with a lowercase character and contain only hyphens (-), underscores (_), lowercase characters, and numbers. Values must contain only hyphens (-), underscores (_), lowercase characters, and numbers."")
+ 	storageLocation      = flag.String(""storage_location"", """", ""Location for the imported image which can be any GCS location. If the location parameter is not included, images are created in the multi-region associated with the source disk, image, snapshot or GCS bucket."")
+ 	uefiCompatible       = flag.Bool(""uefi_compatible"", false, ""Enables UEFI booting, which is an alternative system boot method. Most public images use the GRUB bootloader as their primary boot method."")
++	sysprepWindows       = flag.Bool(""sysprep_windows"", false, ""Whether to generalize image using Windows Sysprep."")
+ )
+
+ func importEntry() (*daisy.Workflow, error) {","Mention that it only applies to Windows. This is kind of implied, but better to be explicit.",Please update the doc string
+5602,"@@ -28,6 +28,8 @@ var (
+ 	autoStake  = true
+ 	index      = uint64(10)
+ 	senderKey  = identityset.PrivateKey(27)
++	zero       = ""0""
++	negtive    = ""-10""
+ )
+
+ func TestCreateStake(t *testing.T) {",again: it is a bad practice to have some global parameters with such common names for unit test purpose.,Could these be `const zero = 0` and `const nega
+5603,"@@ -21,10 +21,7 @@ class Shopware6Connector
+
+     private ?string $token;
+
+-    /**
+-     * @var \DateTimeInterface
+-     */
+-    private $expiresAt;
++    private \DateTimeInterface $expiresAt;
+
+     public function __construct(Configurator $configurator)
+     {",Should we use `\DateTimeInterface` or `DateTimeInterface` and declaration of `DateTimeInterface` in `use`?,Why did you remove this type annotation?
+5604,"@@ -7,11 +7,15 @@ import (
+ 	""errors""
+ 	""fmt""
+
++	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/copilot-cli/internal/pkg/aws/cloudformation""
+ 	""github.com/aws/copilot-cli/internal/pkg/deploy""
++
+ 	""github.com/aws/copilot-cli/internal/pkg/deploy/cloudformation/stack""
+ )
+
++const taskStackPrefix = ""task-""
++
+ // DeployTask deploys a task stack and waits until the deployment is done.
+ // If the task stack doesn't exist, then it creates the stack.
+ // If the task stack already exists, it updates the stack.",What do you think of moving this stack related constant to the `stack` pkg?,Similar blocks of code found in 2 locations. Consider refactoring.
+5605,"@@ -100,6 +100,9 @@ func TxnPool(s *transactions.SignedTxn, ctx Context, verificationPool execpool.B
+ 	if s.Txn.Src() == zeroAddress {
+ 		return errors.New(""empty address"")
+ 	}
++	if !proto.SupportRekeying && (s.AuthAddr != basics.Address{}) {
++		return errors.New(""nonempty AuthAddr but rekeying not supported"")
++	}
+
+ 	outCh := make(chan error, 1)
+ 	cx := asyncVerifyContext{s: s, outCh: outCh, ctx: &ctx}","Hm, I guess that you're doing this here since `WellFormed` is on a `transactions.Transaction` and not a `transactions.SignedTxn`, but quickly grepping through our code, it looks like we always a `SignedTxn` around when calling `WellFormed` (except maybe some tests?)... this doesn't have to happen here, but maybe we should update that in a separate PR since this really feels like a `WellFormed` check.",Do we have a test case for this?
+5606,"@@ -39,4 +39,6 @@ storiesOf( 'Global', module )
+ 				<ModulesList />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} );",This story also needs the default padding.,Is this needed?
+5607,"@@ -745,7 +745,7 @@ public class MockDirectoryWrapper extends BaseDirectoryWrapper {
+       maybeThrowDeterministicException();
+     }
+     if (!LuceneTestCase.slowFileExists(in, name)) {
+-      throw randomState.nextBoolean() ? new FileNotFoundException(name + "" in dir="" + in) : new NoSuchFileException(name + "" in dir="" + in);
++      throw new NoSuchFileException(name + "" in dir="" + in);
+     }
+
+     // cannot open a file for input if it's still open for output.",Hmm why did we remove the randomness about which (confusingly) different exception to throw here? This randomness was (is?) useful to help test that Lucene indeed catches `FNFE` and `NSFE` interchangeably.,@drcrallen are you sure this is the root cause of the issue?
+5608,"@@ -1215,10 +1215,10 @@ ostree_repo_list_collection_refs (OstreeRepo                 *self,
+                   continue;
+                 }
+
+-              if (match_collection_id != NULL && g_strcmp0 (match_collection_id, current_collection_id) != 0)
++              if (match_collection_id != NULL && g_strcmp0 (match_collection_id, remote_collection_id) != 0)
+                 continue;
+               else
+-                  current_collection_id = remote_collection_id;
++                current_collection_id = remote_collection_id;
+             }
+
+           if (!glnx_opendirat (dfd_iter.fd, dent->d_name, TRUE, &subdir_fd, error))","Hm, so before in that case `current_collection_id` looks like it was actually an uninitialized pointer. It seems weird to me that the tests pass both ways. I haven't looked closely at the tests - is there something wrong there that causes this to spuriously pass before?",(style) space prohibited before that close parenthesis ')'
+5609,"@@ -46,9 +46,13 @@
+  * If you will separate the definitions for the parsers, you must revise the
+  * code related to the symbol table. */
+ typedef enum {
+-	K_IGNORE = -2,
+-	K_UNDEFINED,
+-	K_CONSTANT,
++	/* parser private items */
++	K_IGNORE = -16,
++	K_DEFINE,
++
++	K_UNDEFINED = KEYWORD_NONE,
++	/* the followings items are also used as indices for VerilogKinds[] and SystemVerilogKinds[] */
++	K_CONSTANT= 0,
+ 	K_EVENT,
+ 	K_FUNCTION,
+ 	K_MODULE,","s it the best way to tag ""foo"" of ""`define foo ..."" with constant kind? Introducing ""d/definition"" kind and tagging the ""foo"" with the definition kind is an alternative way. Using the unified kind ""constant"" in many areas reduces the information that client tools get from a tags file. In my experience, it is better to tag different things with different kinds. If ctags hides the differences, and just reports various language objects as ""constant,"" in some cases, a client tool must parse the raw .sv source file for distinguishing whether a given tag is ""`define""'ed or not. IMHO, ctags should not be too smart. Instead, ctags should be stupid; it should report what it sees in source input files as-is to client tools that will do something smart.","`K_CONSTANT` should also be added to the enum, right?"
+5610,"@@ -213,7 +213,6 @@ const CASE_TRANSLATION = {
+   tlscafile: 'tlsCAFile',
+   tlscertificatekeyfile: 'tlsCertificateKeyFile',
+   tlscertificatekeyfilepassword: 'tlsCertificateKeyFilePassword',
+-  wtimeout: 'wTimeoutMS',
+   j: 'journal'
+ };
+ ","is this a breaking change? If I'm not mistaken, this is translating a user-provided `wtimeout` in the connection string into `wTimeoutMS`",This option was being removed because it isn't being used
+5611,"@@ -0,0 +1,7 @@
++import json
++
++
++def lambda_handler(event, context):
++    # Just print the event was passed to lambda
++    print('{}'.format(json.dumps(event)))
++    return 0","Can we rename this file to `lambda_echo.py`, to be more descriptive and in line with the other files in this directory? (all files in this folder are lambda functions, after all)",This file could/should be removed.
+5612,"@@ -33,9 +33,10 @@ type Seccomp struct {
+ type Action int
+
+ const (
+-	Kill Action = iota - 4
++	Kill Action = iota - 5
+ 	Errno
+ 	Trap
++	Trace
+ 	Allow
+ )
+ ",why not do it like this ? <pre><code> const ( Kill Action = iota Errno Trap Allow Trace ) <pre><code>,`Kill Action = iota - 5`?
+5613,"@@ -265,6 +265,7 @@ namespace NLog.Internal.FileAppenders
+         /// <param name=""expireTime"">The time which prior the appenders considered expired</param>
+         public void CloseAppenders(DateTime expireTime)
+         {
++            lock(this)
+             for (int i = 0; i < this.appenders.Length; ++i)
+             {
+                 if (this.appenders[i] == null)","lock(this) is a bad practise, since you lock the entire instance. cosider: var appenderCache = xxxx. lock(appenderCache) { Thread.Sleep(TimeSpan.FromHours(5)); } while inside AppenderCache instance lock(this) { is blocked 5 hours. } Its always better to make a class private lock objects.",Why do we need the lock h
+5614,"@@ -135,7 +135,10 @@ func WithClientInfo(serviceName string, procedures []transport.Procedure, transp
+ 		&ClientInfo{
+ 			clientDispatcher.ClientConfig(serviceName),
+ 			grpcClientConn,
+-			grpcheader.NewContextWrapper().WithCaller(serviceName + ""-client"").WithService(serviceName),
++			grpcheader.NewContextWrapper().
++				WithCaller(serviceName + ""-client"").
++				WithService(serviceName).
++				WithEncoding(""proto""),
+ 		},
+ 	)
+ }",should we use the constant above?,The `WithEncoding` option
+5615,"@@ -6979,8 +6979,8 @@ os_seek(file_t f, int64 offset, int origin)
+     case OS_SEEK_END:
+         {
+             uint64 file_size = 0;
+-            bool res = os_get_file_size_by_handle(f, &file_size);
+-            ASSERT(res && ""bad file handle?""); /* shouldn't fail */
++            bool result = os_get_file_size_by_handle(f, &file_size);
++            ASSERT(result && ""bad file handle?""); /* shouldn't fail */
+             abs_offset += file_size;
+         }
+         break;",I think something like `size_res` would be more descriptive.,(style) line over 80 char
+5616,"@@ -96,9 +96,9 @@ module Bolt
+       @target = target
+       @value = {}
+       @action = 'apply'
+-      value['report'] = report if report
+-      value['_error'] = error if error
+-      value['_output'] = metrics_message if metrics_message
++      @value['report'] = report if report
++      @value['_error'] = error if error
++      @value['_output'] = metrics_message if metrics_message
+     end
+
+     def event_metrics",Oh lol so this was...really more of a bug?,is there a reason why we can't use `@value['_report'] ||= report` directly?
+5617,"@@ -7,11 +7,11 @@ using System.Threading.Tasks;
+
+ namespace Microsoft.Rest
+ {
+-    public class PlatformTaskEx
++    [System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Naming"",
++        ""CA1711:IdentifiersShouldNotHaveIncorrectSuffix"",
++        Justification=""We think with Ex is better than using 2"")]
++    public static class PlatformTaskEx
+     {
+-        //Per FxCop performance rule to prevent the compiler from generating a default constructor.
+-        private PlatformTaskEx() { }
+-
+         public static Task FromResult(object result)
+         {
+ #if NET45","Well, it is providing a platform neutral way of calling Task or TaskEx. We could just call it PlatformTask.",Why not `using System.Diagnostics.CodeAnalysis;`?
+5618,"@@ -89,7 +89,7 @@ struct wlr_xwayland *wlr_xwayland_create(struct wl_display *wl_display,
+ 	};
+ 	xwayland->server = wlr_xwayland_server_create(wl_display, &options);
+ 	if (xwayland->server == NULL) {
+-		free(xwayland->server);
++		free(xwayland);
+ 		return NULL;
+ 	}
+ ",Typo: this should free `xwayland` instead,Shouldn't the server be freed in wlr_xwayland_server_close() instead?
+5619,"@@ -19,9 +19,9 @@ package pingpong
+
+ import (
+ 	""bytes""
+-	""crypto/rand""
+ 	""encoding/hex""
+ 	""math""
++	""math/rand""
+ 	""strings""
+ 	""sync""
+ 	""sync/atomic""","Is it ok to use ""math/rand"" instead of ""crypto/rand"" here? Do we need to protect this ID somehow?","You've changed from crypto/rand to math/rand here, is this intentional?"
+5620,"@@ -2,7 +2,7 @@ package nats_dialog
+
+ import (
+ 	""fmt""
+-	""github.com/mgutz/logxi/v1""
++	log ""github.com/cihub/seelog""
+ 	""github.com/mysterium/node/communication""
+ 	""github.com/mysterium/node/communication/nats""
+ 	""github.com/mysterium/node/communication/nats_discovery""",Why did we have `logxi` in the first place? Maybe it makes sense to remove it from `glide.lock? It will safe us in the future from using logger which is not working.,This import should be removed.
+5621,"@@ -269,9 +269,17 @@ public class DataCitation {
+             out.write(title);
+             out.write(""},\r\n"");
+         }
++        if(getUNF() != null){
++            out.write(""UNF = {"");
++            out.write(UNF);
++            out.write(""},\r\n"");
++        }
+         out.write(""year = {"");
+         out.write(year);
+         out.write(""},\r\n"");
++        out.write(""version = {"");
++        out.write(version);
++        out.write(""},\r\n"");
+         out.write(""doi = {"");
+         out.write(persistentId.getAuthority());
+         out.write(""/"");",Is there a reason to use `getUNF()` and `UNF` in the same block?,add a space between `if` and `
+5622,"@@ -198,7 +198,7 @@ func TestParse(t *testing.T) {
+ 		},
+ 		{
+ 			name: ""regex match operators"",
+-			raw:  `""a"" =~ /.*/ and ""b"" !~ /c/`,
++			raw:  `""a"" =~ /.*/ and ""b"" !~ /c$/`,
+ 			want: &ast.Program{
+ 				Body: []ast.Statement{
+ 					&ast.ExpressionStatement{",Again this seems odd that megacheck cares,Why did you change this?
+5623,"@@ -49,6 +49,9 @@ module Bolt
+       @sudo_password = transport_conf[:sudo_password]
+       @run_as = transport_conf[:run_as]
+       @tmpdir = transport_conf[:tmpdir]
++      @service_url = transport_conf[:service_url]
++      @token_file = transport_conf[:token_file]
++      @environment = transport_conf[:environment]
+
+       @logger = init_logger(config[:log_destination], config[:log_level])
+       @transport_logger = init_logger(config[:log_destination], Logger::WARN)",I assume this will resolve to nil if this isn't in the config?,this looks like a copy-paste e
+5624,"@@ -17,6 +17,18 @@ namespace Datadog.Trace.Configuration
+         /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
+         /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
+         public static IDictionary<string, string> ParseCustomKeyValues(string data)
++        {
++            return ParseCustomKeyValues(data, allowOptionalMappings: false);
++        }
++
++        /// <summary>
++        /// Returns a <see cref=""IDictionary{TKey, TValue}""/> from parsing
++        /// <paramref name=""data""/>.
++        /// </summary>
++        /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
++        /// <param name=""allowOptionalMappings"">Determines whether to create dictionary entries when the input has no value mapping</param>
++        /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
++        public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)
+         {
+             var dictionary = new ConcurrentDictionary<string, string>();
+ ","I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)",Does this need to default to `false`?
+5625,"@@ -76,12 +76,13 @@ class YOLOV3Neck(BaseModule):
+
+     Args:
+         num_scales (int): The number of scales / stages.
+-        in_channels (int): The number of input channels.
+-        out_channels (int): The number of output channels.
+-        conv_cfg (dict): Config dict for convolution layer. Default: None.
+-        norm_cfg (dict): Dictionary to construct and config norm layer.
+-            Default: dict(type='BN', requires_grad=True)
+-        act_cfg (dict): Config dict for activation layer.
++        in_channels (List[int]): The number of input channels  per scale.
++        out_channels (List[int]): The number of output channels  per scale.
++        conv_cfg (dict, optional): Config dict for convolution layer.
++            Default: None.
++        norm_cfg (dict, optional): Dictionary to construct and config norm
++            layer. Default: dict(type='BN', requires_grad=True)
++        act_cfg (dict, optional): Config dict for activation layer.
+             Default: dict(type='LeakyReLU', negative_slope=0.1).
+         init_cfg (dict or list[dict], optional): Initialization config dict.
+             Default: None",` per scale.` -> ` per scale.` need to clean the unnecessary blank space,If we add `requires_grad` to `init_cf
+5626,"@@ -79,7 +79,8 @@ public class class194 {
+ 		descriptor = ""(IS)Ljava/lang/String;"",
+ 		garbageValue = ""4096""
+ 	)
+-	static final String method3712(int var0) {
++	@Export(""inventoryQuantityFormat"")
++	static final String inventoryQuantityFormat(int var0) {
+ 		if (var0 < 100000) { // L: 421
+ 			return ""<col=ffff00>"" + var0 + ""</col>"";
+ 		} else {",there's no import for Export,Why did you remove the method3712?
+5627,"@@ -51,7 +51,7 @@ func (e *endpoints) ListenAndServe(ctx context.Context) error {
+ 	tcpServer := e.createTCPServer(ctx)
+ 	udsServer := e.createUDSServer(ctx)
+
+-	e.registerNodeAPI(tcpServer)
++	e.registerNodeAPI(tcpServer, udsServer)
+ 	e.registerRegistrationAPI(tcpServer, udsServer)
+
+ 	err := util.RunTasks(ctx,",i don't think we want/need to make the node API available over UDS,Why are we passing in both the uds an
+5628,"@@ -113,7 +113,7 @@ class LegalConditionsFacade
+         $articleId = $this->setting->getForDomain($settingKey, $domainId);
+
+         if ($articleId !== null) {
+-            return $this->articleFacade->getById($articleId);
++            return $this->articleFacade->findById($articleId);
+         }
+
+         return null;",How about to skip if and returning null and return a result of `ArticleFacade::findById` directly?,"`findById` doesn't exist in Sulu 3.0, so this should not be changed."
+5629,"@@ -180,6 +180,11 @@ class CoreDocumentArray extends CoreMongooseArray {
+     return arr;
+   }
+
++  map() {
++    const arr = [].concat(Array.prototype.map.apply(this,arguments));
++    return arr;
++  }
++
+   /**
+    * Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
+    *","I think this change is currently unnecessary. I like the idea of `map()`, `filter()`, etc. returning vanilla JavaScript arrays rather than mongoose arrays, but I think that's a bit too heavy of a change for a patch release. I think that all we need for this release is the `if (!parent || parent.$__.populated == null) return;` change.",Doesn't this need a `arguments` argument?
+5630,"@@ -10,6 +10,11 @@ module Travis
+     BUILD_DIR = File.join(HOME_DIR, 'build')
+
+     class << self
++      def version
++        @version ||= `git rev-parse HEAD 2>/dev/null || \\
++                        echo ""${SOURCE_VERSION:-fafafaf}""`.strip
++      end
++
+       def self.register(key)
+         Travis.services.add(key, self)
+       end","how about ""unknown"" instead of ""fafafaf""?",The `version` method is a bit tricky to follow with `git rev-parse H
+5631,"@@ -0,0 +1,14 @@
++package api2
++
++import (
++	""context""
++
++	""github.com/filecoin-project/go-filecoin/address""
++	""github.com/filecoin-project/go-filecoin/exec""
++)
++
++// Actor is the actor-related Filecoin plumbing interface.
++type Actor interface {
++	// ActorGetSignature returns the signature of the given actor's given method.
++	ActorGetSignature(ctx context.Context, actorAddr address.Address, method string) (_ *exec.FunctionSignature, err error)
++}",nit: do we gain anything from naming the output error `err` in this definition?,Why do you need this interface? Why not just use `exec.Actor`?
+5632,"@@ -188,6 +188,11 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
+                 stopInterval();
+             });
+
++            // Blur foreign element to prevent starting of ""nested"" slideshow
++            if (document.activeElement && !dlg.contains(document.activeElement)) {
++                document.activeElement.blur();
++            }
++
+             inputManager.on(window, onInputCommand);
+             document.addEventListener((window.PointerEvent ? 'pointermove' : 'mousemove'), onPointerMove);
+ ",This can happen with any dialog. Maybe the best place to add this change would be the dialog component instead.,"This will only work if there is no activeElement. If there is no activeElement, then we don't need to call `blur` on the activeElement."
+5633,"@@ -46,6 +46,10 @@ func NewTestEnvironment(ctx context.Context, t *testing.T, fastenvOpts fast.Envi
+ 	env, err := fast.NewEnvironmentMemoryGenesis(big.NewInt(1000000), dir, types.TestProofsMode)
+ 	require.NoError(err)
+
++	defer func() {
++		dumpEnvOutputOnFail(t, env.Processes())
++	}()
++
+ 	// Setup options for nodes.
+ 	options := make(map[string]string)
+ 	options[localplugin.AttrLogJSON] = ""1""                                        // Enable JSON logs","Should this be `TearDown` since it now calls this method? Something I would like to see is, on test failure don't teardown completely instead leave the FAST repo in place with the stderr and stdout files and direct the user to that location. What do you think?",Does the test fail if there are no processes in the env?
+5634,"@@ -190,6 +190,8 @@ def getModule(metricSpec):
+     return MetricMAPE(metricSpec)
+   elif metricName == 'multi':
+     return MetricMulti(metricSpec)
++  elif metricName == 'negLL':
++    return MetricNegLogLikelihood(metricSpec)
+   else:
+     raise Exception(""Unsupported metric type: %s"" % metricName)
+ ","There's not particular reason to use a short name. Can we use a more descriptive name for the metric? Perhaps ""negativeLogLikelihood""?",This should be `MetricNegLogLikelihood`
+5635,"@@ -745,7 +745,10 @@ static void skipArgumentList (tokenInfo *const token, boolean include_newlines,
+ 		while (nest_level > 0 && ! isType (token, TOKEN_EOF))
+ 		{
+ 			readTokenFull (token, FALSE, repr);
+-			if (isType (token, TOKEN_OPEN_PAREN))
++			if (isType (token, TOKEN_KEYWORD) && token->keyword == KEYWORD_function &&
++			    repr == NULL)
++				parseFunction (token);
++			else if (isType (token, TOKEN_OPEN_PAREN))
+ 				nest_level++;
+ 			else if (isType (token, TOKEN_CLOSE_PAREN))
+ 				nest_level--;","not handling in case of `repr` makes the behavior probably a little too unpredictable. Is there a reason not to, apart missing stuff in the `repr`? Does it lead to some problem?",else if its not really needed :)
+5636,"@@ -93,12 +93,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+                             BadHttpRequestException.Throw(RequestRejectionReason.UnexpectedEndOfRequestContent);
+                         }
+
+-                        awaitable = _context.Input.ReadAsync();
+                     }
+                     finally
+                     {
+                         _context.Input.AdvanceTo(consumed, examined);
+                     }
++
++                    awaitable = _context.Input.ReadAsync();
+                 }
+             }
+             catch (Exception ex)",Remove the finally?,Is this `awaitable` needed anymore?
+5637,"@@ -378,7 +378,7 @@ reboot_system()
+  *   and then checking error codes; but the problem there is that C:\\
+  *   returns PATH_NOT_FOUND regardless. */
+ bool
+-file_exists(const TCHAR *fn)
++file_exists(const WCHAR *fn)
+ {
+ #ifdef WINDOWS
+     WIN32_FIND_DATA fd;",Build on AArch64 fails because WCHAR is not defined.,Please don't change these. The prob
+5638,"@@ -20,6 +20,7 @@ import (
+
+ func TestRDWS_Template(t *testing.T) {
+ 	const (
++		envName               = ""test""
+ 		manifestFileName      = ""rdws-manifest.yml""
+ 		stackTemplateFileName = ""rdws.stack.yml""
+ 	)",Do we use this const?,Would it make sense to have this co
+5639,"@@ -139,3 +139,9 @@ func SetCertificateRequestFailureTime(p metav1.Time) CertificateRequestModifier
+ 		cr.Status.FailureTime = &p
+ 	}
+ }
++
++func SetAnnotations(annotations map[string]string) CertificateRequestModifier {
++	return func(cr *v1alpha2.CertificateRequest) {
++		cr.SetAnnotations(annotations)
++	}
++}",I think this may need to be `SetCertificateRequestAnnotations` as it returns a `CertificateRequestModifier`  ,I would prefer that this would be `
+5640,"@@ -234,6 +234,7 @@ class User < ActiveRecord::Base
+   #
+   # Returns UserIdentifier
+   def identifier_for(scheme)
++    scheme = scheme.instance_of?(IdentifierScheme) ? scheme.name : scheme
+     identifiers.by_scheme_name(scheme, ""User"").first
+   end
+ ",it would likely be better to do this in the Identifier.by_scheme_name method itself.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+5641,"@@ -129,6 +129,10 @@ class DatasetContext extends RawDKANEntityContext {
+     }
+
+     switch ($orderby) {
++      case 'Date created':
++        $orderby = 'created';
++        break;
++
+       case 'Date changed':
+         $orderby = 'changed';
+         break;","@janette looking at this test code, I'm pretty sure that it's going to give a false positive. Where is it actually checking the contents of the first four datasets against expected values? All the assertion at the end of the test seems to check is that at least four datasets exist.",Why not call `$orderby = 'created';` directly here?
+5642,"@@ -68,6 +68,14 @@ module.exports = function (defaults) {
+             optional: ['es6.spec.symbols'],
+             includePolyfill: true
+         },
++        'ember-service-worker': {
++            rootUrl: '/ghost/'
++        },
++        'esw-cache-fallback': {
++            patterns: [
++                '/ghost/api/(.+)'
++            ],
++        },
+         outputPaths: {
+             app: {
+                 js: assetLocation('ghost.js')",Would this break things if Ghost is run in a subdirectory or no?,Isn't there a more generic way to specify this? E.g. can't you use `/api/`?
+5643,"@@ -24,7 +24,11 @@ class ProposalUpdateRecorder
+   end
+
+   def update_comment_format(key)
+-    ""#{bullet}*#{property_name(key)}* was changed "" + former_value(key) + ""to #{new_value(key)}""
++    if key !~ /id/
++      ""#{bullet}*#{property_name(key)}* was changed "" + former_value(key) + ""to #{new_value(key)}""
++    else
++      ""#{bullet}*#{association_name(key)}* was changed "" + former_association_value(key) + ""to #{new_association_value(key)}""
++    end
+   end
+
+   def bullet",maybe switch the order in order to make this a positive assertion instead of a negative one? i.e. `if key =~ /id/` first.,Line is too long. [81/80]
+5644,"@@ -20,6 +20,7 @@ from selenium.common.exceptions import NoSuchFrameException
+ from selenium.common.exceptions import StaleElementReferenceException
+ from selenium.common.exceptions import WebDriverException
+ from selenium.common.exceptions import NoAlertPresentException
++from selenium.common.exceptions import ElementNotVisibleException
+
+ """"""
+  * Canned ""Expected Conditions"" which are generally useful within webdriver",Is this an oversight for some code in the body?,Let's just import this from `selenium.common.exceptions` since we don't use it in the file.
+5645,"@@ -922,6 +922,8 @@ public class AddProductActivity extends AppCompatActivity {
+                         toast.show();
+                         mOfflineSavedProductDao.deleteInTx(mOfflineSavedProductDao.queryBuilder().where(OfflineSavedProductDao.Properties.Barcode.eq(code)).list());
+                         Intent intent = new Intent();
++                        state.setProduct(mProduct);
++                        intent.putExtra(""state"", state);
+                         intent.putExtra(""uploadedToServer"", true);
+                         setResult(RESULT_OK, intent);
+                         finish();",Reason for adding this? I couldn't find where you are retrieving it back.,"This could be a bit more descriptive (e.g. `intent.putExtra(""state"", state);`)."
+5646,"@@ -62,6 +62,10 @@ static void setup_globals(mrb_state *mrb)
+
+     h2o_mruby_eval_expr(mrb, ""$LOAD_PATH << \""#{$H2O_ROOT}/share/h2o/mruby\"""");
+     h2o_mruby_assert(mrb);
++
++    /* require core modules and include built-in libraries */
++    h2o_mruby_eval_expr(mrb, ""require \""preloads.rb\"""");
++    h2o_mruby_assert(mrb);
+ }
+
+ mrb_value h2o_mruby_to_str(mrb_state *mrb, mrb_value v)","Can we expect adequate information emitted to the log in case either requiring preloads.rb or doing the requires in preloads.rb fails? If the answer is yes, I think we can merge this PR right away.",wouldn't it be better to do this in h2o_mruby_define ?
+5647,"@@ -1,2 +1,3 @@
+-class PagesController < ApplicationController
+-end
++class PagesController < HighVoltage::PagesController
++  layout false
++end","How about a `app/views/layouts/pages.html.erb` layout that contains the HTML head, body, wrappers and yield's the `new-topics` template into it? I think we might be able to delete the `app/controllers/pages_controller.rb` file at that point.",@jmhooper @jvillalobos can you review this change since you originally added it?
+5648,"@@ -2218,7 +2218,9 @@ Document.prototype.isSelected = function isSelected(path) {
+   if (this.$__.selected == null) {
+     return true;
+   }
+-
++  if (!path) {
++    return false;
++  }
+   if (path === '_id') {
+     return this.$__.selected._id !== 0;
+   }","This is a coarse solution. This check is helpful, but you should also add a check in `$__version()` to avoid calling `isSelected()` if `key === false`",What does this do? Don't we have to worry about it?
+5649,"@@ -37,8 +37,10 @@ type Planner interface {
+ }
+
+ type Input struct {
+-	// Readonly deployment model.
+-	Deployment                     *model.Deployment
++	ApplicationID                  string
++	ApplicationName                string
++	GitPath                        model.ApplicationGitPath
++	Trigger                        model.DeploymentTrigger
+ 	MostRecentSuccessfulCommitHash string
+ 	PipedConfig                    *config.PipedSpec
+ 	TargetDSP                      deploysource.Provider",Passing only needed data to make it can be reused by `planpreview` package where there is no deployment data.,Why are we making this change?
+5650,"@@ -71,6 +71,9 @@ type Options struct {
+ 	TLSCaCert      string        `json:""-""`
+ 	TLSConfig      *tls.Config   `json:""-""`
+ 	WriteDeadline  time.Duration `json:""-""`
++
++	CustomClientAuth Auth `json:""-""`
++	CustomRouterAuth Auth `json:""-""`
+ }
+
+ // Clone performs a deep copy of the Options struct, returning a new clone",Could we rename those to `CustomClientAuthentication` (same for Router) to remove ambiguity between Authentication and Authorization (permissions)?,Can we remove the `CustomClientAuth` and `CustomRou
+5651,"@@ -1,11 +1,15 @@
+ using System;
++using MvvmCross.Core.Views;
+ using MvvmCross.Forms.Platform;
+
+ namespace MvvmCross.Forms.Views
+ {
+-    public interface IMvxFormsViewPresenter
++    public interface IMvxFormsViewPresenter : IMvxAttributeViewPresenter
+     {
+         MvxFormsApplication FormsApplication { get; set; }
+         IMvxFormsPagePresenter FormsPagePresenter { get; set; }
++
++        bool ClosePlatformViews();
++        bool ShowPlatformHost(Type hostViewModel = null);
+     }
+ }","Is the name ""IMvxFormsViewPresenter"" too close to ""IMvxFormsPagePresenter""? Perhaps something like ""IMvxFormsNativeViewPresenter"" or ""IMvxFormsPlatformViewPresenter"" or inline with Forms naming ""IMvxFormsOnPlatformViewPresenter""",Would it make sense to put this method in the `IMvv
+5652,"@@ -28,8 +28,8 @@ export function h(nodeName, attributes) {
+ 		if ((child = stack.pop()) instanceof Array) {
+ 			for (i=child.length; i--; ) stack.push(child[i]);
+ 		}
+-		else if (child!=null && child!==false) {
+-			if (typeof child=='number' || child===true) child = String(child);
++		else if (child!=null && child!==true && child!==false) {
++			if (typeof child=='number') child = String(child);
+ 			simple = typeof child=='string';
+ 			if (simple && lastSimple) {
+ 				children[children.length-1] += child;",`typeof child != 'boolean'` maybe?,Are you sure it's safe to remove the `||` here?
+5653,"@@ -220,7 +220,7 @@ public class ErrorHandler {
+
+   private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
+
+-    if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
++    if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
+       // Not enough information for us to try to rebuild an error.
+       return null;
+     }",Why && changed to || ?,The containsKey() check can be replaced with ju
+5654,"@@ -26,6 +26,11 @@ func init() {
+ 		panic(err)
+ 	}
+
++	InitAddress, err = NewIDAddress(4)
++	if err != nil {
++		panic(err)
++	}
++
+ 	StorageMarketAddress, err = NewIDAddress(2)
+ 	if err != nil {
+ 		panic(err)",nit: not a big deal right now but spec assigns ID 0 to InitAddress,why is this a panic?
+5655,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change.",Shouldn't this be `var lookFor = parameters.han
+5656,"@@ -361,6 +361,11 @@ class WebView(QWebView):
+         message.info(self.win_id, ""Zoom level: {}%"".format(perc))
+         self._default_zoom_changed = True
+
++    def setZoomFactor(self, fact):
++        self._zoom.fuzzyval = int(fact * 100)
++        super().setZoomFactor(fact)
++        self._default_zoom_changed = True
++
+     def zoom(self, offset):
+         """"""Increase/Decrease the zoom level.
+ ","There are various places where `setZoomFactor` is used but `fuzzyval` isn't set: - `__init__` and `on_config_changed` (should be okay as `init_neighborlist` gets called which essentially does the same) - `zoom` (calls `zoom_perc` with `fuzzyval=False`), which is used by `:zoom-in` and `:zoom-out`. Are you sure this won't break those calls? (Yes, I know there should be tests for this - I'm working on that.) Other existing places probably should get simplified.",Do we really need to store the result of `super().setZoomFactor(fact)` here? It looks like super().setZoomFactor(fact) would do the right thing.
+5657,"@@ -889,12 +889,12 @@ namespace pwiz.Skyline.Model
+             string pathForLibraryFiles, // In case we translate libraries etc
+             ConvertToSmallMoleculesMode mode = ConvertToSmallMoleculesMode.formulas,
+             ConvertToSmallMoleculesChargesMode invertChargesMode = ConvertToSmallMoleculesChargesMode.none,
+-            bool ignoreDecoys=false)
++            bool ignoreDecoys=false, bool addAnnotations = true)
+         {
+             if (mode == ConvertToSmallMoleculesMode.none)
+                 return document;
+             var newdoc = new SrmDocument(document.Settings);
+-            var note = new Annotations(TestingConvertedFromProteomic, null, 1); // Mark this as a testing node so we don't sort it
++            var note = addAnnotations ? new Annotations(TestingConvertedFromProteomic, null, 1) : Annotations.EMPTY; // Optionally mark this as a testing node so we don't sort it
+             var precursorMap = new Dictionary<LibKey, LibKey>(); // Map int,modSeq to adduct,molecule
+
+             var invertCharges = invertChargesMode == ConvertToSmallMoleculesChargesMode.invert;",Is there a benefit to keeping this in RefinementSettings? Or could we move it into its own class in TestUtil?,"When `addAnnotations` is false, `TestingConvertedFromProteomic` will be empty."
+5658,"@@ -6,14 +6,10 @@ import (
+
+ // Query represents an active query.
+ type Query interface {
+-	// Spec returns the spec used to execute this query.
+-	// Spec must not be modified.
+-	Spec() *Spec
+-
+-	// Ready returns a channel that will deliver the query results.
++	// Results returns a channel that will deliver the query results.
+ 	// Its possible that the channel is closed before any results arrive,
+ 	// in which case the query should be inspected for an error using Err().
+-	Ready() <-chan map[string]Result
++	Results() <-chan Result
+
+ 	// Done must always be called to free resources. It is safe to call Done
+ 	// multiple times.","I would have expected the Ready method to need to change to be a `<-chan Result` instead of a `<-chan map[string]Result`. The difference being that now the Ready channel can produce more than one set of results. In fact the name Ready is inaccurate now since its not about the query being ready but just a mechanism to deliver results. If this should be a follow up PR that is fine, lets create an issue for it.",how did this ever work?
+5659,"@@ -36,7 +36,7 @@ public interface ProjectLoader {
+    * @return
+    * @throws ProjectManagerException
+    */
+-  public List<Project> fetchAllActiveProjects() throws ProjectManagerException;
++  List<Project> fetchAllActiveProjects() throws ProjectManagerException;
+
+   /**
+    * Loads whole project, including permissions, by the project id.",why? what if we want to access those methods outside of azkaban-common?,Why did you change the access modifier?
+5660,"@@ -45,9 +45,9 @@ namespace Nethermind.Merge.Plugin.Test
+     {
+         private async Task<MergeTestBlockchain> CreateBlockChain() => await new MergeTestBlockchain(new ManualTimestamper()).Build(new SingleReleaseSpecProvider(Berlin.Instance, 1));
+
+-        private IConsensusRpcModule CreateConsensusModule(MergeTestBlockchain chain)
++        private IEngineRpcModule CreateConsensusModule(MergeTestBlockchain chain)
+         {
+-            return new ConsensusRpcModule(
++            return new EngineRpcModule(
+                 new AssembleBlockHandler(chain.BlockTree, chain.BlockProductionTrigger, chain.Timestamper, chain.LogManager),
+                 new NewBlockHandler(chain.BlockTree, chain.BlockPreprocessorStep, chain.BlockchainProcessor, chain.State, new InitConfig(), chain.LogManager),
+                 new SetHeadBlockHandler(chain.BlockTree, chain.State, chain.LogManager),",Rename file too,Why does this have to change?
+5661,"@@ -27,7 +27,11 @@ func Unmarshal(r *request.Request) {
+ 		decoder := xml.NewDecoder(r.HTTPResponse.Body)
+ 		err := xmlutil.UnmarshalXML(r.Data, decoder, """")
+ 		if err != nil {
+-			r.Error = awserr.New(""SerializationError"", ""failed decoding EC2 Query response"", err)
++			r.Error = awserr.NewRequestFailure(
++				awserr.New(""SerializationError"", ""failed decoding EC2 Query response"", err),
++				r.HTTPResponse.StatusCode,
++				"""",
++			)
+ 			return
+ 		}
+ 	}","Need to populate the `RequestID` field for these errors. This can be obtained from r.RequestID i think, but need to make sure. The `r.RequestID` should of been populated from the `UnmarshalMeta` handler list.",We should be returning a spec
+5662,"@@ -35,8 +35,8 @@ public class LongRunningConfigTest {
+   private static final String GAPIC_CONFIG_METADATA_TYPE = ""HeaderType"";
+   private static final String ANNOTATIONS_RETURN_TYPE_NAME = ""BookType"";
+   private static final String ANNOTATIONS_METADATA_TYPE = ""FooterType"";
+-  private static final boolean TEST_IMPLEMENTS_DELETE = false;
+-  private static final boolean TEST_IMPLEMENTS_CANCEL = false;
++  private static boolean TEST_IMPLEMENTS_DELETE = false;
++  private static boolean TEST_IMPLEMENTS_CANCEL = false;
+   private static int TEST_INITIAL_POLL_DELAY = 5;
+   private static double TEST_POLL_DELAY_MULTIPLIER = 10;
+   private static long TEST_MAX_POLL_DELAY = 12500;",Why is the `final` being removed here?,Do not use the `final` modifi
+5663,"@@ -1,13 +1,14 @@
+ //
+ //  Bismillah ar-Rahmaan ar-Raheem
+ //
+-//  Easylogging++ v9.95.0
++//  Easylogging++ v9.96.4
+ //  Cross-platform logging library for C++ applications
+ //
+-//  Copyright (c) 2017 muflihun.com
++//  Copyright (c) 2012-2018 Muflihun Labs
++//  Copyright (c) 2012-2018 @abumusamq
+ //
+ //  This library is released under the MIT Licence.
+-//  http://labs.muflihun.com/easyloggingpp/licence.php
++//  https://github.com/muflihun/easyloggingpp/blob/master/LICENSE
+ //
+ //  https://github.com/muflihun/easyloggingpp
+ //  https://muflihun.github.io/easyloggingpp",Maybe let's take this opportunity to change easylogging to a git submodule?,You shouldn't have to update
+5664,"@@ -30,6 +30,9 @@ func extractFrontMatter(input string) (map[string]interface{}, string, error) {
+ 	}
+ 	firstLine := input[firstLineStart:firstLineEnd]
+
++	// ensure residue windows newline is removed
++	firstLine = strings.Trim(firstLine, ""\r"")
++
+ 	// see what kind of front matter there is, if any
+ 	var closingFence string
+ 	var fmParser func([]byte) (map[string]interface{}, error)",Should we just be generous and elide all extra whitespace? `strings.TrimSpace`,why do you need to trim it?
+5665,"@@ -900,18 +900,6 @@ public class SalesforceSDKManager {
+         return context.getString(getSalesforceR().stringAccountType());
+     }
+
+-    /**
+-     * Indicates whether the app is running on a tablet.
+-     *
+-     * @return True if the application is running on a tablet.
+-     */
+-    public static boolean isTablet() {
+-        if ((INSTANCE.context.getResources().getConfiguration().screenLayout & Configuration.SCREENLAYOUT_SIZE_MASK) == Configuration.SCREENLAYOUT_SIZE_XLARGE) {
+-            return true;
+-        }
+-        return false;
+-    }
+-
+     @Override
+     public String toString() {
+         final StringBuilder sb = new StringBuilder();","This is an inaccurate API that has outlived it's purpose. We can't make the determination of phone (vs) tablet, with a 7"" screen in the mix. Also, with the advent of fragments, this API means very little now. It's not being used anywhere, since we switched to `ActionBar`.",Doesn't look like this is b
+5666,"@@ -230,7 +230,7 @@ public class GridLauncherV3 {
+     }
+
+     configureLogging(common.getLog(), common.getDebug());
+-    log.info(version());
++    log.finest(version());
+     return true;
+   }
+ ",This change means that users can't easily see which version of the selenium server they're using. This is `info` level information.,This is the only real chang
+5667,"@@ -455,8 +455,8 @@ class AuthTestCase(QuiltTestCase):
+     def testCodeExpires(self):
+         self.code_immediate_expire_mock = mock.patch('quilt_server.auth.CODE_TTL_DEFAULT',
+                                                      {'minutes': 0})
+-        self.code_immediate_expire_mock.start()
+         token = self.getToken()
++        self.code_immediate_expire_mock.start()
+         code_request = self.app.get(
+             '/api/code',
+             headers={","You should just use `with patch(...):`, so it unpatches it automatically. Also, much simpler.",:+1: Thanks for fixing this
+5668,"@@ -28,14 +28,15 @@ namespace MvvmCross.Navigation
+         private IMvxViewDispatcher _viewDispatcher;
+         public IMvxViewDispatcher ViewDispatcher
+         {
+-            get => _viewDispatcher ?? (IMvxViewDispatcher)MvxMainThreadDispatcher.Instance;
++            get => _viewDispatcher ?? (_viewDispatcher = Mvx.Resolve<IMvxViewDispatcher>());
+             set => _viewDispatcher = value;
+         }
+
+         private IMvxViewsContainer _viewsContainer;
+         protected IMvxViewsContainer ViewsContainer
+         {
+-            get {
++            get
++            {
+                 if (_viewsContainer == null)
+                     _viewsContainer = Mvx.Resolve<IMvxViewsContainer>();
+                 return _viewsContainer;",This didn't use to work for me. Are you sure that returns the correct instance from startup?,"FYI, this is a functional change to get `MvxMainThreadDispatcher.Instance`. This is a functional change to get `IMvxViewsContainer`."
+5669,"@@ -65,6 +65,14 @@ public final class MethodCallExpr extends Expression implements NodeWithTypeArgu
+         this(null, scope, new NodeList<>(), new SimpleName(name), new NodeList<>());
+     }
+
++    public MethodCallExpr(final Expression scope, final SimpleName name) {
++        this(null, scope, new NodeList<>(), name, new NodeList<>());
++    }
++
++    public MethodCallExpr(final Expression scope, final String name, final NodeList<Expression> arguments) {
++        this(null, scope, new NodeList<>(), new SimpleName(name), arguments);
++    }
++
+     public MethodCallExpr(final Expression scope, final SimpleName name, final NodeList<Expression> arguments) {
+         this(null, scope, new NodeList<>(), name, arguments);
+     }","Looks good. Eventually we could remove some of these constructors, but for now adding these two seems the way to go",Why is this necessary?
+5670,"@@ -180,7 +180,7 @@ def parse_bwids(bwolist):
+     return list(ast.literal_eval(bwolist))
+
+
+-def get_holdingpen_objects(ptags=[]):
++def get_holdingpen_objects(ptags=[""Need action""]):
+     """"""Get BibWorkflowObject's for display in Holding Pen.
+
+     Uses DataTable naming for filtering/sorting. Work in progress.",@jalavik should be have somewhere enum/list/registry of possible tags?,Perhaps change the name to `get_holdingpen_objects_in_workflow`?
+5671,"@@ -155,6 +155,7 @@ class SecurityCenterClient(object):
+                     finding.get('source_properties').get('violation_data'))
+                 raise api_errors.ApiExecutionError(violation_data, e)
+
++    # pylint: disable=logging-too-many-args
+     def list_findings(self, source_id):
+         """"""Lists all the findings in CSCC.
+ ",why is this pylint disable needed?,"Again, no need for pylint disable here."
+5672,"@@ -44,6 +44,7 @@ def GenerateConfig(context):
+
+     FORSETI_HOME = '$USER_HOME/forseti-security'
+     POLICY_LIBRARY_HOME = '$USER_HOME/policy-library'
++    POLICY_LIBRARY_SYNC_ENABLED = 'false'
+
+     DOWNLOAD_FORSETI = (
+         ""git clone {src_path}.git"".format(",The new sync feature is only being supported from within Terraform. Installations using the deprecated method will have this feature disabled.,Why is this not set to `true`?
+5673,"@@ -79,3 +79,7 @@ class DropBlock(nn.Module):
+         factor = (1.0 if self.iter_cnt > self.warmup_iters else self.iter_cnt /
+                   self.warmup_iters)
+         return gamma * factor
++
++    def extra_repr(self):
++        return (f'drop_prob={self.drop_prob}, block_size={self.block_size}, '
++                f'warmup_iters={self.warmup_iters}')","This type of return (f'xxx') is not recommended, it is recommended to return 'xxx'",what is the `self.iter_cnt` us
+5674,"@@ -2836,8 +2836,11 @@ client_process_bb(dcontext_t *dcontext, build_bb_t *bb)
+ #    ifdef X86
+         if (!d_r_is_avx512_code_in_use()) {
+             if (ZMM_ENABLED()) {
+-                if (instr_may_write_zmm_register(inst))
++                if (instr_may_write_zmm_register(inst)) {
++                    LOG(THREAD, LOG_INTERP, 3, ""Detected AVX-512 code in use\n"");
+                     d_r_set_avx512_code_in_use(true);
++                    proc_set_num_simd_saved(MCXT_NUM_SIMD_SLOTS);
++                }
+             }
+         }
+ #    endif",I would make this level 1 or 2.,(style) line over 80 character
+5675,"@@ -0,0 +1,17 @@
++require 'beaker/hypervisor/vagrant'
++
++class Beaker::VagrantFusion < Beaker::Vagrant
++  def provision(provider = 'vmware_fusion')
++    # By default vmware_fusion creates a .vagrant directory relative to the
++    # Vagrantfile path. That means beaker tries to scp the VM to itself unless
++    # we move the VM files elsewhere.
++    ENV['VAGRANT_VMWARE_CLONE_DIRECTORY'] = '~/.vagrant/vmware_fusion'
++    super
++  end
++
++  def self.provider_vfile_section(host, options)
++    ""    v.vm.provider :vmware_fusion do |v|\n"" +
++    ""      v.vmx['memsize'] = '#{options['vagrant_memsize'] ||= '1024'}'\n"" +
++    ""    end\n""
++  end
++end",Is that path in a variable anyway? Not a big fan of hard coding it here.,@mitchellhenke Thanks for the
+5676,"@@ -16,14 +16,18 @@ limitations under the License.
+ package controllers
+
+ import (
++	""bytes""
+ 	""context""
++	""errors""
++	""strings""
++	""text/template""
+
+ 	""github.com/sirupsen/logrus""
+ 	federation ""github.com/spiffe/spire/support/k8s/k8s-workload-registrar/federation""
+ 	spiffeidv1beta1 ""github.com/spiffe/spire/support/k8s/k8s-workload-registrar/mode-crd/api/spiffeid/v1beta1""
+
+ 	corev1 ""k8s.io/api/core/v1""
+-	""k8s.io/apimachinery/pkg/api/errors""
++	k8serrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/types""",nit: Move `IdentityTemplateLabel` to be under `IdentityTemplate` to match the struct in config_crd.go,`pkg/api/errors` is already imported. No need to alias it.
+5677,"@@ -1,8 +1,13 @@
+ class Analytics
+   include AnalyticsHelper
+
+-  SAMPLER = ""sampler""
+-  SUBSCRIBER = ""subscriber""
++  SAMPLER = ""sampler"".freeze
++  SUBSCRIBER = ""subscriber"".freeze
++  TRACKERS = {
++    ""Video"" => VideoTracker,
++    ""Exercise"" => ExerciseTracker,
++    ""Trail"" => TrailTracker,
++  }.freeze
+
+   class_attribute :backend
+   self.backend = AnalyticsRuby","Not necessarily related to this PR, but don't you think having a centralized place for all interactions with analytics might make this into a very big class? Is that something that you don't worry about until it happens?",Was this really necessary? I don't see any new code using
+5678,"@@ -670,6 +670,13 @@ func (w *Workflow) runStep(ctx context.Context, s *Step) DError {
+ 	select {
+ 	case err := <-e:
+ 		return err
++	case <-ctx.Done():
++		if err := ctx.Err(); err == context.DeadlineExceeded {
++			return s.getTimeoutError()
++		} else if err != nil {
++			return Errf(""step %q error: %s"", s.name, err)
++		}
++		return nil
+ 	case <-timeout:
+ 		return s.getTimeoutError()
+ 	}","it seems that my terminal is dead when I press ctrl+c during running daisy cli today, is this PR fixing that?",How about s.getTimeoutError()?
+5679,"@@ -403,7 +403,7 @@ func (nc *Config) Build(ctx context.Context) (*Node, error) {
+
+ 	// only the syncer gets the storage which is online connected
+ 	chainSyncer := chain.NewDefaultSyncer(&cstOffline, nodeConsensus, chainStore, fetcher)
+-	msgPool := core.NewMessagePool(chainStore, consensus.NewIngestionValidator(chainStore))
++	msgPool := core.NewMessagePool(chainStore, nc.Repo.Config().Mpool, consensus.NewIngestionValidator(chainStore))
+ 	outbox := core.NewMessageQueue()
+
+ 	// Set up libp2p pubsub","If we are going to add config to specify the maximum message pool size, we should probably also add a parameter for the maximum nonce gap and pass it into the `IngestionValidator`. This could be done in this PR or added as an issue.",why NewMessagePool instead of NewRepo?
+5680,"@@ -12,10 +12,8 @@
+  */
+ package org.camunda.bpm.container.impl.spi;
+
+-import java.util.ArrayList;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
++
+ import org.camunda.bpm.container.impl.ContainerIntegrationLogger;
+ import org.camunda.bpm.engine.impl.ProcessEngineLogger;
+ ",please inline imports,Please avoid star imports.
+5681,"@@ -113,7 +113,7 @@ type Config struct {
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;30""`
+ 	IptablesLockFilePath               string        `config:""file;/run/xtables.lock""`
+-	IptablesLockTimeoutSecs            time.Duration `config:""seconds;30""`
++	IptablesLockTimeoutSecs            time.Duration `config:""seconds;0""`
+ 	IptablesLockProbeIntervalMillis    time.Duration `config:""millis;50""`
+ 	IpsetsRefreshInterval              time.Duration `config:""seconds;10""`
+ 	MaxIpsetSize                       int           `config:""int;1048576;non-zero""`","Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?",Is this change intended?
+5682,"@@ -313,7 +313,11 @@ class JoplinDatabase extends Database {
+
+ 		// currentVersionIndex < 0 if for the case where an old version of Joplin used with a newer
+ 		// version of the database, so that migration is not run in this case.
+-		if (currentVersionIndex < 0) throw new Error('Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.');
++		if (currentVersionIndex < 0) {
++			this.logger().error(`Cannot convert database from version ${fromVersion} to ${existingDatabaseVersions[existingDatabaseVersions.length-1]}`);
++			const p = require('../package.json');
++			throw new Error(`Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.\n${p.name} version: ${p.version}\nProfile version: ${fromVersion}\nExpected version: ${existingDatabaseVersions[existingDatabaseVersions.length-1]}`);
++		}
+
+ 		if (currentVersionIndex == existingDatabaseVersions.length - 1) return fromVersion;
+ ",Please use packageInfo here instead. As it is used in `app.js`.,Can we put the `.` at the
+5683,"@@ -49,7 +49,10 @@ public class AnalysisResult {
+             // the analysis will fail and report the error on it's own since the checksum won't match
+         }
+
+-        return 0;
++        // we couldn't read the file, maybe the file doesn't exist
++        // in any case, we can't use the cache. Returning here the timestamp should make
++        // sure, we see that the file changed every time we analyze it.
++        return System.currentTimeMillis();
+     }
+
+     public long getFileChecksum() {","this seems unrelated to the rest of the PR, although related to the original report",I am not sure if this is t
+5684,"@@ -11386,7 +11386,7 @@ NABoolean HbaseAccess::isHbaseFilterPredV2(Generator * generator, ItemExpr * ie,
+   }
+   //check if not an added column with default non null
+   if ((foundBinary || foundUnary)&& (NOT hbaseLookupPred)){
+-        if (colVID.isAddedColumnWithNonNullDefault()){
++        if (colVID.isColumnWithNonNullDefault()){
+             foundBinary=FALSE;
+             foundUnary=FALSE;
+         }",Would a check for added columns with non-null default be sufficient for aligned format?,Is there a reason for this change?
+5685,"@@ -69,6 +69,7 @@ var (
+ 	hostname                    = flag.String(ovfimportparams.HostnameFlagKey, """", ""Specify the hostname of the instance to be created. The specified hostname must be RFC1035 compliant."")
+ 	machineImageStorageLocation = flag.String(ovfimportparams.MachineImageStorageLocationFlagKey, """", ""GCS bucket storage location of the machine image being imported (regional or multi-regional)"")
+ 	buildID                     = flag.String(""build-id"", """", ""Cloud Build ID override. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. For example, if running multiple imports in parallel in a single Cloud Build run, sharing build ID could cause premature temporary resource clean-up resulting in import failures."")
++	computeServiceAccount       = flag.String(""compute_service_account"", """", ""Compute service account to be used by importer. When empty, the Compute Engine default service account is used."")
+
+ 	nodeAffinityLabelsFlag flags.StringArrayFlag
+ 	currentExecutablePath  string","Is this PR implementing compute service account for OVF import as well? I thought it's only image/one-step import? Btw, OVF importer uses ""-"" instead of ""_"" in flags (should be `compute-service-account`).",What do you think about moving thi
+5686,"@@ -23,7 +23,7 @@ use Symfony\Component\Routing\Annotation\Route;
+ /**
+  * @Route(
+  *     name=""ergonode_product_collection_element_delete"",
+- *     path=""/collections/{collection}/elements/{product}"",
++ *     path=""/collections/{collection}/element/{product}"",
+  *     methods={""DELETE""},
+  *     requirements={
+  *     ""collection""=""[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"",",Why change to element ?? in whole application use plural convention ??,@cra0zy do you think we should ren
+5687,"@@ -23,7 +23,7 @@ const renderInnerPanel = (props) => {
+ }
+
+ const poweredByUppy = (props) => {
+-  return <a href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
++  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
+     <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
+   </svg><span class=""uppy-Dashboard-poweredByUppy"">Uppy</span></a>
+ }","Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`",Is there a reason for this change?
+5688,"@@ -344,6 +344,16 @@ try:
+     cast = image.astype(np.float32)
+     assert cast.dtype == np.float32
+
++    # Test .astype for conversion between vector-like pixel types.
++    components = 3
++    numpyImage = np.random.randint(0, 256, (12,8,components)).astype(np.uint8)
++    input_image = itk.image_from_array(numpyImage, is_vector=True)
++    if (type(input_image) == itk.Image[itk.RGBPixel[itk.UC],2] and
++        hasattr(itk.CastImageFilter, 'IRGBUC2IVF32')):
++        output_pixel_type = itk.Vector[itk.F,components]
++        output_image = input_image.astype(output_pixel_type)
++        assert type(output_image) == itk.Image[output_pixel_type, 2]
++
+ except ImportError:
+     print(""NumPy not imported. Skipping BridgeNumPy tests"")
+     # Numpy is not available, do not run the Bridge NumPy tests","Unrelated to this PR, we should remove this exception. We now require `numpy`.","This is not testing `is_vector` but testing `isinstance(itk.CastImageFilter, np.uint32)`"
+5689,"@@ -29,7 +29,7 @@ type SubWorkflow struct {
+ func (s *SubWorkflow) populate(ctx context.Context, st *Step) DError {
+ 	if s.Path != """" {
+ 		var err error
+-		if s.Workflow, err = st.w.NewSubWorkflowFromFile(s.Path); err != nil {
++		if s.Workflow, err = st.w.NewSubWorkflowFromFile(s.Path, s.Vars); err != nil {
+ 			return ToDError(err)
+ 		}
+ 	}","Is the loop over vars and adding them to the subworkflow below in this file needed, since it's already done by NewSubWorkflowFromFile?",`s.Vars` is nil if the file does not exist
+5690,"@@ -0,0 +1,19 @@
++module LicensesHelper
++  def license_date_range(license)
++    formatted_date_range(license.starts_on, license.ends_on)
++  end
++
++  def formatted_date_range(starts_on, ends_on)
++    if starts_on.nil? || ends_on.nil?
++      nil
++    elsif starts_on == ends_on
++      starts_on.to_s :simple
++    elsif starts_on.year != ends_on.year
++      ""#{starts_on.to_s(:simple)}-#{ends_on.to_s(:simple)}""
++    elsif starts_on.month != ends_on.month
++      ""#{starts_on.strftime(""%B %d"")}-#{ends_on.to_s(:simple)}""
++    else
++      ""#{starts_on.strftime(""%B %d"")}-#{ends_on.strftime(""%d, %Y"")}""
++    end
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,This is a good candidate for a helper method that takes the start and end date and retur
+5691,"@@ -0,0 +1,5 @@
++import dagster.pandas_kernel as dagster_pd
++
++
++def simple_csv_input(name):
++    return dagster_pd.dataframe_input(name, sources=[dagster_pd.csv_dataframe_source()])",Having to write this util makes me think that maybe we should have kept the csv_input stuff. I don't know.,What's the difference between this and `dataframe_input`?
+5692,"@@ -21,9 +21,10 @@ var _ BlockOps = (*BlockOpsStandard)(nil)
+
+ // NewBlockOpsStandard creates a new BlockOpsStandard
+ func NewBlockOpsStandard(config Config, queueSize int) *BlockOpsStandard {
++	q := newBlockRetrievalQueue(queueSize, config.Codec(), config.BlockCache())
+ 	bops := &BlockOpsStandard{
+ 		config:  config,
+-		queue:   newBlockRetrievalQueue(queueSize, config.Codec()),
++		queue:   q,
+ 		workers: make([]*blockRetrievalWorker, 0, queueSize),
+ 	}
+ 	bg := &realBlockGetter{config: config}","Passing in and saving a reference to the `BlockCache` at init time is going to break if something calls `config.ResetCaches()`, because it replaces the `BlockCache` instance completely. This happens on user logout or by a manual write to `.kbfs_reset_caches`. So you probably want to give it the whole `config`, or maybe just the `config.BlockCache` function pointer.",Why not create the queue inside the `BlockOpsStandard` constructor?
+5693,"@@ -462,6 +462,9 @@ func (s *Service) newStreamForPeerID(ctx context.Context, peerID libp2ppeer.ID,
+ 	swarmStreamName := p2p.NewSwarmStreamName(protocolName, protocolVersion, streamName)
+ 	st, err := s.host.NewStream(ctx, peerID, protocol.ID(swarmStreamName))
+ 	if err != nil {
++		if st != nil {
++			_ = st.Close()
++		}
+ 		if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion {
+ 			return nil, p2p.NewIncompatibleStreamError(err)
+ 		}","I am not sure this could happen. st should be nil if the error happens. If it does happen, we could also do st.Reset(), since it is an erroureous state so it closes both sides of the stream.",I think we should close the stream in the error case below.
+5694,"@@ -239,6 +239,7 @@ var requirejs, require, define;
+         }
+
+         function delayedError(e) {
++            console.log(e.stack);
+             return setTimeout(function() {
+                 e.dynaId && trackedErrors[e.dynaId] || (trackedErrors[e.dynaId] = !0, req.onError(e))
+             }), e",I'm guessing this was just added for debugging? Should probably remove it so we aren't modifying 3rd party libs.,Please remove this.
+5695,"@@ -15,10 +15,17 @@ module Bolt
+         @object_open = true
+       end
+
++      def print_event(node, event)
++        case event[:type]
++        when :node_result
++          print_result(node, event[:result])
++        end
++      end
++
+       def print_result(node, result)
+         item = {
+           name: node.uri,
+-          status: result.is_a?(Bolt::ErrorResult) ? 'failure' : 'success',
++          status: result.success? ? 'success' : 'failure',
+           result: result.to_result
+         }
+ ","This seems reversed... if `success?` is true, wouldn't we use `success`?",Seems like `print_event` only calls `print_result` underneath. Why
+5696,"@@ -0,0 +1,12 @@
++namespace Datadog.Trace
++{
++    internal enum LogEventLevel
++    {
++        Verbose,
++        Debug,
++        Information,
++        Warning,
++        Error,
++        Fatal
++    }
++}","This seemed like the easiest way to allow log level checks, it will require an update to the vendors tool, to ignore that file on update.",Why is this an enum?
+5697,"@@ -21,6 +21,11 @@
+     <%= richtext_area :diary_comment, :body, :cols => 80, :rows => 15 %>
+     <%= submit_tag t('diary_entry.view.save_button') %>
+   <% end %>
++  <% if @user and @entry.subscribers.exists?(@user.id) %>
++    <div style='position:relative; top: -30px; left: 130px'><%= link_to t('javascripts.changesets.show.unsubscribe'), diary_entry_unsubscribe_path(:display_name => @entry.user.display_name, :id => @entry.id), :method => :post, :class => :button %></div>
++  <% elsif @user %>
++    <div style='position:relative; top: -30px; left: 130px'><%= link_to t('javascripts.changesets.show.subscribe'), diary_entry_subscribe_path(:display_name => @entry.user.display_name, :id => @entry.id), :method => :post, :class => :button %></div>
++  <% end %>
+ <% end %>
+
+ <%= if_not_logged_in(:div) do %>",Should we disallow entry authors to unsubscribe to their entries?,You can use `@entry.
+5698,"@@ -1,7 +1,7 @@
+ # -*- coding: UTF-8 -*-
+ #core.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner
++#Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner, Derek Riemer
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",2016 should be 2017.,I don't know if it's
+5699,"@@ -155,7 +155,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+         String curSchemaSumary = existSchema.getSummary();
+         String schemaSummary = Hashing.sha256().newHasher().putString(content, Charsets.UTF_8).hash().toString();
+         if (!schemaSummary.equals(curSchemaSumary)) {
+-          if (microservice.getInstance().getEnvironment().equalsIgnoreCase(""development"")) {
++          if (curSchemaSumary == null || microservice.getInstance().getEnvironment().equalsIgnoreCase(""development"")) {
+             LOGGER.info(
+                 ""schemaId [{}]'s content changes and the current enviroment is development, so re-register it!"",
+                 schemaId);",boolean exists = (existSchema != null) && (existSchema .getSummary() != null);,Why this change? Wha
+5700,"@@ -57,8 +57,8 @@ func NewCmdPoolDescribe() *cobra.Command {
+ 		Use:   ""describe"",
+ 		Short: ""Describes the pools"",
+ 		Long:  poolDescribeCommandHelpText,
+-		Run: func(cmd *cobra.Command, args []string) {
+-			util.CheckErr(options.runPoolDescribe(cmd), util.Fatal)
++		Run: func(_ *cobra.Command, args []string) {
++			util.CheckErr(options.runPoolDescribe(), util.Fatal)
+ 		},
+ 	}
+ ",It does not look idiomatic.,Did you mean to remove the `cmd` argument here?
+5701,"@@ -3,9 +3,12 @@ package sql_test
+ import (
+ 	""testing""
+
++	_ ""github.com/mattn/go-sqlite3""
++
+ 	""github.com/DATA-DOG/go-sqlmock""
+ 	""github.com/google/go-cmp/cmp""
+ 	""github.com/google/go-cmp/cmp/cmpopts""
++
+ 	""github.com/influxdata/flux""
+ 	_ ""github.com/influxdata/flux/builtin"" // We need to import the builtins for the tests to work.
+ 	""github.com/influxdata/flux/dependencies/dependenciestest""","Generally, we do not use newlines between project imports, we only separate them from the stdlib imports",This import should go with the rest of `github.
+5702,"@@ -770,6 +770,10 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+             var isProgressClear = state.MediaSource && null == state.MediaSource.RunTimeTicks;
+             nowPlayingPositionSlider.setIsClear(isProgressClear);
+
++            if (nowPlayingItem.RunTimeTicks) {
++                nowPlayingPositionSlider.setKeyboardSteps(userSettings.skipBackLength() * 1000000 / nowPlayingItem.RunTimeTicks, userSettings.skipForwardLength() * 1000000 / nowPlayingItem.RunTimeTicks);
++            }
++
+             if (-1 === supportedCommands.indexOf(""ToggleFullscreen"") || player.isLocalPlayer && layoutManager.tv && playbackManager.isFullscreen(player)) {
+                 view.querySelector("".btnFullscreen"").classList.add(""hide"");
+             } else {",can this long line be wrapped?,"Move these magic numbers to a constant, so they"
+5703,"@@ -1731,6 +1731,12 @@ class ComparisonChecker(_BasicChecker):
+                       'comparison-with-itself',
+                       'Used when something is compared against itself.',
+                       ),
++            'W0143': ('Comparing bare callable, might have skipped parenthesis after callable',
++                      'comparison-with-callable',
++                      'Used when callable is used in a comparison without parenthesis, '
++                      'which means instead of comparing result of callable, '
++                      'callable itself is compared',
++                      ),
+
+             }
+ ",I'd use the same message that I suggested in the release changelog.,Missing a period at the end of the sentence.
+5704,"@@ -53,7 +53,7 @@ function DocumentArray (key, schema, options) {
+     if (!Array.isArray(arr)) arr = [arr];
+     return new MongooseDocumentArray(arr, path, this);
+   });
+-};
++}
+
+ /**
+  * This schema type's name, to defend against minifiers that mangle",Keep semi-colons at end of function defs please,"Same as above, let's keep this one liner"
+5705,"@@ -2,13 +2,18 @@
+
+ const OperationBase = require('./operation').OperationBase;
+ const resolveReadPreference = require('../utils').resolveReadPreference;
++const ReadConcern = require('../read_concern');
++const WriteConcern = require('../write_concern');
+
+ class CommandOperationV2 extends OperationBase {
+   constructor(parent, options) {
+     super(options);
+
+     this.ns = parent.s.namespace.withCollection('$cmd');
+-    this.readPreference = resolveReadPreference(parent, options);
++    this.readPreference = resolveReadPreference(parent, this.options);
++    this.readConcern = resolveReadConcern(parent, this.options);
++    this.writeConcern = resolveWriteConcern(parent, this.options);
++    this.explain = false;
+
+     // TODO(NODE-2056): make logger another ""inheritable"" property
+     if (parent.s.logger) {",A little skeptical of `explain` being here. Why is this now a property of all commands?,Is this used anywhere?
+5706,"@@ -1,5 +1,7 @@
+-// Copyright (c) Microsoft. All rights reserved.
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+
+ namespace Microsoft.TestPlatform.Extensions.TrxLogger.ObjectModel
+ {",License copied two times!!,why did you change these?
+5707,"@@ -44,7 +44,8 @@ class CustomWaiter:
+
+     """"""
+     def __init__(
+-            self, name, operation, argument, acceptors, client, delay=10, max_tries=60):
++            self, name, operation, argument, acceptors, client, delay=10, max_tries=60,
++            matcher='path'):
+         """"""
+         Subclasses should pass specific operations, arguments, and acceptors to
+         their super class.",... their **superclass**,matcher doesn't seem to be an argument o
+5708,"@@ -526,7 +526,7 @@ module Beaker
+         cmdline_args = conf_opts[:__commandline_args__]
+         conf_opts = conf_opts.reject { |k,v| k == :__commandline_args__ }
+
+-        curl_retries = host['master-start-curl-retries'] || options['master-start-curl-retries']
++        curl_retries = host['master-start-curl-retries'] || options['master-start-curl-retries'] || 0
+         logger.debug ""Setting curl retries to #{curl_retries}""
+
+         begin",I'm not sure if this is the right thing to be doing here. It seems like there should be a more systemic fix instead of this patch.,Isn't `|| 0` redundant here?
+5709,"@@ -811,6 +811,7 @@ const baseSelectors = {
+ 	/**
+ 	 * Gets the module's screenWidgetContext.
+ 	 *
++	 * Returns `undefined` if dependencies are loading.
+ 	 * Returns `null` if there is no registered context string for the given module.
+ 	 * Returns `string` the registered context string, screenWidgetContext for the given module.
+ 	 *",Not sure why these are up here   can we move these down to be part of the `@return` tag instead? This is what we usually do   (e.g. `getCurrentEntityURL`),It seems like this should sa
+5710,"@@ -34,12 +34,14 @@ module Blacklight::Document
+     # but extensions should call super and modify hash returned, to avoid
+     # unintentionally erasing values provided by other extensions.
+     def to_semantic_values
+-      @semantic_value_hash ||= self.class.field_semantics.each_with_object(Hash.new([])) do |(key, field_name), hash|
+-        value = self[field_name]
++      @semantic_value_hash ||= self.class.field_semantics.each_with_object(Hash.new([])) do |(key, field_names), hash|
++        ##
++        # Handles single string field_name or an array of field_names
++        value = Array.wrap(field_names).map { |field_name| self[field_name] }.flatten.compact
+
+         # Make single and multi-values all arrays, so clients
+         # don't have to know.
+-        hash[key] = Array.wrap(value) unless value.nil?
++        hash[key] = value unless value.empty?
+       end
+
+       @semantic_value_hash ||= {}",Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.,Layout/TrailingWhitespace: T
+5711,"@@ -0,0 +1,18 @@
++package org.openqa.selenium;
++
++/**
++ * Created by James Reed on 11/04/2016.
++ * Thrown to indicate that a click was attempted on an element but was intercepted by another
++ * element on top of it
++ */
++public class InterceptingElementException extends InvalidElementStateException {
++
++  public InterceptingElementException(String message) {
++    super(message);
++  }
++
++  public InterceptingElementException(String message, Throwable cause) {
++    super(message, cause);
++  }
++
++}",We keep who wrote the code anonymous.,This file needs to be update
+5712,"@@ -25,6 +25,12 @@ func (client *clientFake) NodeRegister(proposal dto_discovery.ServiceProposal) (
+ 	return nil
+ }
+
++func (client *clientFake) RegisterIdentity(identity dto_discovery.Identity) (err error) {
++	log.Info(MYSTERIUM_API_LOG_PREFIX, ""Identity registered: "", identity)
++
++	return nil
++}
++
+ func (client *clientFake) NodeSendStats(nodeKey string, sessionStats []dto.SessionStats) (err error) {
+ 	log.Info(MYSTERIUM_API_LOG_PREFIX, ""Node stats sent: "", nodeKey)
+ ","Mention something in logs, that fake registration was used e.g. `Fake identity registered`",is this used anywhere?
+5713,"@@ -151,10 +151,12 @@ const baseActions = {
+ 				return;
+ 			}
+
+-			registry.dispatch( STORE_NAME ).setPropertyID( propertyID );
+-
+ 			if ( PROPERTY_CREATE === propertyID ) {
+-				registry.dispatch( STORE_NAME ).setProfileID( PROFILE_CREATE );
++				registry.dispatch( STORE_NAME ).setSettings( {
++					propertyID,
++					profileID: PROFILE_CREATE,
++				} );
++
+ 				return;
+ 			}
+ ","I think it would make sense to also set `internalWebPropertyID` to `''` here. Otherwise, it might keep its previous value (let's say a property was selected before, but then the user chooses ""Create new property""), but since it always should depend on `propertyID`, that would be incorrect.",Does the profile ID ne
+5714,"@@ -779,3 +779,18 @@ TEST_CASE(""setDoubleBondNeighborDirections()"", ""[stereochemistry,bug]"") {
+     CHECK(MolToSmiles(*m) == ""C/C=C\\C"");
+   }
+ }
++
++TEST_CASE(""github #2782: addHs() fails on atoms with 'bad' valences"", ""[bug]"") {
++  SECTION(""basics"") {
++    SmilesParserParams ps;
++    ps.sanitize = false;
++    std::unique_ptr<RWMol> m(
++        static_cast<RWMol *>(SmilesToMol(""C=C1=CC=CC=C1"", ps)));
++    REQUIRE(m);
++    bool strict = false;
++    m->updatePropertyCache(strict);
++    CHECK(m->getNumAtoms() == 7);
++    MolOps::addHs(*m);
++    CHECK(m->getNumAtoms() == 14);
++  }
++}",It might be reasonable to add a check that sanitization still fails here.,This looks like it sho
+5715,"@@ -602,9 +602,8 @@ public class JobRunner extends EventHandler implements Runnable {
+     }
+
+     final int attemptNo = this.node.getAttempt();
+-    logInfo(""Finishing job "" + this.jobId + "" attempt: "" + attemptNo + "" at ""
++    logInfo(""Finishing job "" + this.jobId + (this.node.getAttempt() > 0 ? ("" retry: "" + attemptNo) : """") + "" at ""
+         + this.node.getEndTime() + "" with status "" + this.node.getStatus());
+-
+     fireEvent(Event.create(this, Type.JOB_FINISHED,
+         new EventData(finalStatus, this.node.getNestedId())), false);
+     finalizeLogFile(attemptNo);","Why not use attemptNo instead of another call to getAttempt? Even better, consider using a private method to calculate this string. This logic is in two places.",Should we log if there
+5716,"@@ -2,7 +2,7 @@ module ProjectAssociations
+   extend ActiveSupport::Concern
+
+   included do
+-    has_many :links, -> { where(deleted: false) }
++    has_many :links, -> { where(""links.deleted = 'f'"") }
+     has_one :permission, as: :target
+     has_many :analyses
+     has_many :analysis_summaries, through: :analyses",Yuck. Rails bug.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+5717,"@@ -927,6 +927,15 @@ class Packet(six.with_metaclass(Packet_metaclass, BasePacket)):
+             return self.payload.answers(other.payload)
+         return 0
+
++    def layers(self):
++        """"""returns a list of layer classes (including subclasses) in this packet""""""  # noqa: E501
++        layers = []
++        l = self
++        while l:
++            layers.append(l.__class__)
++            l = l.payload.getlayer(0, _subclass=True)
++        return layers
++
+     def haslayer(self, cls):
+         """"""true if self has a layer that is an instance of cls. Superseded by ""cls in self"" syntax.""""""  # noqa: E501
+         if self.__class__ == cls or cls in [self.__class__.__name__,","It's useally a common practice to not use `l` as a variable (we have disabled this test in scapy because our code has tons, but it would have PEP8 failed otherwise), but it would be better not to create any. In general, single letter variables are not liked that much. Especially with windows where the fonts make 1=l How about `lay` ?",Would it not be better to just do `return [l.__class__ for l in self.payload.layers]`?
+5718,"@@ -40,6 +40,12 @@ func (s *server) chunkUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))
++	w.WriteHeader(http.StatusContinue)
++	if f, ok := w.(http.Flusher); ok {
++		f.Flush()
++	}
++
+ 	// Add the tag to the context
+ 	ctx := sctx.SetTag(r.Context(), tag)
+ ","DRY these 5 lines into a function call, no?",I think `w.StatusContinue` is correct here. Should be `http.StatusCreated`?
+5719,"@@ -113,12 +113,13 @@ func Main() int {
+ 	signal.Notify(term, os.Interrupt, syscall.SIGTERM)
+ 	select {
+ 	case <-term:
+-		fmt.Fprint(os.Stdout, ""Received SIGTERM, exiting gracefully..."")
++		logger.Log(""msg"", ""Received SIGTERM, exiting gracefully..."")
+ 		l.Close()
+ 		close(stopc)
+ 		wg.Wait()
+-	case <-errc:
+-		fmt.Fprintf(os.Stderr, ""Unhandled error received. Exiting..."")
++	case err := <-errc:
++		logger.Log(""msg"", ""Unhandled error received. Exiting..."", ""err"", err)
++		l.Close()
+ 		close(stopc)
+ 		wg.Wait()
+ 		return 1",should we be trying to close here? or just return directly @fabxc ? same goes for `stopc`...,"Just curious, why did you remove the `os.Stdout` print?"
+5720,"@@ -177,7 +177,7 @@ describe Ncr::ApprovalManager do
+
+     context ""for a BA60 or BA61 request"" do
+       it ""uses BA61 tier1 team approver when org code matches"" do
+-        org_letters = %w( 7 J 4 T 1 A C Z )
++        org_letters = %w( 1 4 7 A C J T Z )
+         org_letters.each do |org_letter|
+           org_code = ""P11#{org_letter}XXXX""
+           ncr_org = create(:ncr_organization, code: org_code)",just re-ordered for clarity,this was flagged as a duplicate test
+5721,"@@ -69,13 +69,13 @@ func NewVolumeInfo(URL string, volname string, namespace string) (volInfo *Volum
+ 	}
+ 	if resp != nil && resp.StatusCode != 200 {
+ 		if resp.StatusCode == 500 {
+-			fmt.Printf(""Volume: %s not found at M_API server\n"", volname)
++			fmt.Printf(""Volume: %s not found at namespace: %q\n"", volname, namespace)
+ 			err = util.InternalServerError
+ 		} else if resp.StatusCode == 503 {
+ 			fmt.Println(""M_API server not reachable"")
+ 			err = util.ServerUnavailable
+ 		} else if resp.StatusCode == 404 {
+-			fmt.Printf(""Volume: %s not found at M_API server\n"", volname)
++			fmt.Printf(""Volume: %s not found at namespace: %q error: %s\n"", volname, namespace, http.StatusText(resp.StatusCode))
+ 			err = util.PageNotFound
+ 		}
+ 		fmt.Printf(""Received an error from M_API server: statuscode: %d"", resp.StatusCode)","Can you fix this also to print what is the IP address used to connect. Rename --> ""M_API server"" to maya apiservice",did you mean to include the namespac
+5722,"@@ -205,6 +205,18 @@ func decodeUTF8(s string, index uintptr) (rune, uintptr) {
+ 	}
+ }
+
++// indexByte returns the index of the first instance of c in the byte slice b,
++// or -1 if c is not present in the byte slice.
++//go:linkname indexByte internal/bytealg.IndexByte
++func indexByte(b []byte, c byte) int {
++	for i, x := range b {
++		if x == c {
++			return i
++		}
++	}
++	return -1
++}
++
+ // indexByteString returns the index of the first instance of c in s, or -1 if c
+ // is not present in s.
+ //go:linkname indexByteString internal/bytealg.IndexByteString","This fails on Go 1.11 because `indexByte` is already defined in strings_go111.go. I would suggest simply renaming one of the two, for example you could rename the other one to `strings_indexByte` (that will be one of the things we'll drop when we drop Go 1.11 support so it's better to make that one look ugly instead of the function that we will likely keep for a longer time).",Nit: should we call this `indexByteS
+5723,"@@ -868,7 +868,7 @@ CreateParameter(1)
+ Parameter #1 Direction=Input
+ Parameter #1 Name=@level
+ Parameter #1 MockDbType=Int32
+-Parameter #1 Value=""""{0}""""
++Parameter #1 Value={0}
+ Add Parameter Parameter #1
+ CreateParameter(2)
+ Parameter #2 Direction=Input",Now `dbType=' MockDbType.int32 '` is correctly interpreted and the value is rendered as an integer instead of a string; hence no more double quotes.,I think it would be good to have a t
+5724,"@@ -63,7 +63,7 @@ class Comment extends AbstractAggregateRoot
+     public function changeContent(string $contend): void
+     {
+         if ($contend !== $this->content) {
+-            $this->apply(new CommentContentChangedEvent($this->id, $this->content, $contend, new \DateTime()));
++            $this->apply(new CommentContentChangedEvent($this->id, $contend, new \DateTime()));
+         }
+     }
+ ",typo in `$contend`,Why did you remove the content?
+5725,"@@ -28,9 +28,13 @@ import com.netflix.iceberg.TableOperations;
+ import com.netflix.iceberg.Tables;
+ import com.netflix.iceberg.exceptions.AlreadyExistsException;
+ import com.netflix.iceberg.exceptions.NoSuchTableException;
++import com.netflix.iceberg.exceptions.RuntimeIOException;
+ import org.apache.hadoop.conf.Configurable;
+ import org.apache.hadoop.conf.Configuration;
++import org.apache.hadoop.fs.FileSystem;
+ import org.apache.hadoop.fs.Path;
++
++import java.io.IOException;
+ import java.util.Map;
+
+ import static com.netflix.iceberg.TableMetadata.newTableMetadata;",Nit: empty line,why this change? I think there
+5726,"@@ -185,6 +185,10 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
+ }
+
+ func (fs *KBFSOpsStandard) getOpsNoAdd(fb FolderBranch) *folderBranchOps {
++	if fb == (FolderBranch{}) {
++		panic(""zero FolderBranch in getOps"")
++	}
++
+ 	fs.opsLock.RLock()
+ 	if ops, ok := fs.ops[fb]; ok {
+ 		fs.opsLock.RUnlock()",I figured this was more fool-proof than trying to plumb the error up from everywhere.,I'm guessing you did not mean t
+5727,"@@ -192,8 +192,8 @@ func (c *client) initClient() {
+ 	c.cid = atomic.AddUint64(&s.gcid, 1)
+ 	c.bw = bufio.NewWriterSize(c.nc, startBufSize)
+ 	c.subs = make(map[string]*subscription)
+-	c.debug = (atomic.LoadInt32(&debug) != 0)
+-	c.trace = (atomic.LoadInt32(&trace) != 0)
++	c.debug = (atomic.LoadInt32(&c.srv.logging.debug) != 0)
++	c.trace = (atomic.LoadInt32(&c.srv.logging.trace) != 0)
+
+ 	// This is a scratch buffer used for processMsg()
+ 	// The msg header starts with ""MSG "",","We know debug and trace as globals exist and are defaulted to 0. In this instance we need to know that c is non- nil, srv is non-nil and logging is non-nil before we can trust this statement not to panic.",Was there any specific reason f
+5728,"@@ -58,7 +58,6 @@ type Provider interface {
+ func NewApp(AppRoot string, provider string) (*DdevApp, error) {
+ 	// Set defaults.
+ 	app := &DdevApp{}
+-	app.ConfigPath = filepath.Join(AppRoot, "".ddev"", ""config.yaml"")
+
+ 	app.AppRoot = AppRoot
+ 	app.ConfigPath = app.GetConfigPath(""config.yaml"")","Good removal here for two reasons: we're redeclaring `app.ConfigPath` immediately below without having used the initial value, and `app.GetConfigPath()` will build the value using the same process as in this line anyway.",@andrewkroh this is the line you were talking about
+5729,"@@ -193,9 +193,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.Processors
+                 new RunSpecificTestsArgumentProcessor(),
+                 new TestAdapterPathArgumentProcessor(),
+                 new TestCaseFilterArgumentProcessor(),
+-                new OutputArgumentProcessor(),
+                 new BuildBasePathArgumentProcessor(),
+-                new ConfigurationArgumentProcessor(),
+                 new ParentProcessIdArgumentProcessor(),
+                 new PortArgumentProcessor(),
+                 new RunSettingsArgumentProcessor(),",Should BuildBase be removed?,This was removed because it is redundant with `Outp
+5730,"@@ -1,13 +1,14 @@
+ package internal_test
+
+ import (
++	""io/ioutil""
+ 	""os""
++	""path""
+ 	""regexp""
+ 	""testing""
+
+-	""github.com/golangci/golangci-lint/pkg/fsutils""
+-	ast ""github.com/stretchr/testify/assert""
+-	req ""github.com/stretchr/testify/require""
++	""github.com/stretchr/testify/assert""
++	""github.com/stretchr/testify/require""
+
+ 	tf ""github.com/filecoin-project/go-filecoin/testhelpers/testflags""
+ 	. ""github.com/filecoin-project/go-filecoin/tools/migration/internal""",this was a bad Goland auto-import that I missed in the previous PR. Thanks to @rkowalick and @acruikshank for catching it,Let's separate this into a separate PR
+5731,"@@ -133,10 +133,12 @@ TEST_CASE(""github #2224"", ""[bug, molops, removeHs, query]"") {
+     }
+     {  // but if we add a query feature it's not removed
+       RWMol m2(*mol);
+-      m2.replaceAtom(1, new QueryAtom(1));
++      auto *qa = new QueryAtom(1);
++      m2.replaceAtom(1, qa);
+       m2.getAtomWithIdx(1)->setAtomicNum(1);
+       MolOps::removeHs(m2);
+       CHECK(m2.getNumAtoms() == 2);
++      delete qa;
+     }
+   }
+ }","Good catch here. Reading the code, it actually seems kind of dumb that `replaceAtom` needs to copy the atom it's passed. Ah well, we're more or less stuck with that.",Why does this need to be a `std::unique_ptr`?
+5732,"@@ -560,6 +560,17 @@ void wlr_output_schedule_frame(struct wlr_output *output) {
+ 		wl_event_loop_add_idle(ev, schedule_frame_handle_idle_timer, output);
+ }
+
++void wlr_output_send_present(struct wlr_output *output, struct timespec *when,
++		unsigned seq, uint32_t flags) {
++	struct wlr_output_event_present event = {
++		.output = output,
++		.when = when,
++		.seq = seq,
++		.flags = flags,
++	};
++	wlr_signal_emit_safe(&output->events.present, &event);
++}
++
+ bool wlr_output_set_gamma(struct wlr_output *output, size_t size,
+ 		const uint16_t *r, const uint16_t *g, const uint16_t *b) {
+ 	if (!output->impl->set_gamma) {",What's the reason for adding the output pointer here? I'd expect it to be derivable from the actual handler that's called.,"We should probably call this wlr_output_send_present(output, seq, flags) instead. Same for the other one below."
+5733,"@@ -82,6 +82,10 @@ class Plan < ActiveRecord::Base
+     annual_plan.price
+   end
+
++  def annualized_savings
++    annualized_payment - discounted_annual_payment
++  end
++
+   def annual_plan_sku
+     annual_plan.sku
+   end",I don't see tests for this (or the similar method on `Team`).,Method parameter must be at least 3 characters long.
+5734,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long,"I don't think this is the right place to do this, since this is used in the `getJsonParameters` method. The onl"
+5735,"@@ -281,8 +281,12 @@ func (c *client) readLoop() {
+ 		c.cache.subs = 0
+
+ 		if err := c.parse(b[:n]); err != nil {
+-			// handled inline
+-			if err != ErrMaxPayload && err != ErrAuthorization {
++			// If client connection has been closed, simply return,
++			// otherwise report a generic parsing error.
++			c.mu.Lock()
++			closed := c.nc == nil
++			c.mu.Unlock()
++			if !closed {
+ 				c.Errorf(""Error reading from client: %s"", err.Error())
+ 				c.sendErr(""Parser Error"")
+ 				c.closeConnection()","We had the checks for those two errors for a reason, why do we not need them anymore?",Why do we need a lock here?
+5736,"@@ -19,6 +19,7 @@ from rdkit import Chem
+ from rdkit.Chem.PeriodicTable import numTable
+ from rdkit.Chem import Crippen
+ from rdkit.Chem import rdPartialCharges, rdMolDescriptors
++from rdkit.six.moves import xrange
+ import numpy
+ import bisect
+ radCol = 5",Why didn't you just switch to `range` here too?,Is this import necessary? I don't see it being used in this file
+5737,"@@ -32,15 +32,15 @@ import (
+ 	""google.golang.org/api/option""
+ )
+
+-// New returns a GCS Bucket. It handles creation of a client used to communicate
++// NewBucket returns a GCS Bucket. It handles creation of a client used to communicate
+ // to GCS service.
+-func New(ctx context.Context, bucketName string, opts *BucketOptions) (*blob.Bucket, error) {
++func NewBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient) (*blob.Bucket, error) {
+ 	if err := validateBucketChar(bucketName); err != nil {
+ 		return nil, err
+ 	}
+ 	var o []option.ClientOption
+-	if opts != nil {
+-		o = append(o, option.WithTokenSource(opts.TokenSource))
++	if client != nil {
++		o = append(o, option.WithHTTPClient(&client.Client))
+ 	}
+ 	c, err := storage.NewClient(ctx, o...)
+ 	if err != nil {","I don't even think `nil` should be allowed, since it uses global state to get the client.",We need a way to pass the token source to the `NewBucket` as wel
+5738,"@@ -352,6 +352,9 @@ def qt_message_handler(msg_type, context, msg):
+         # may not be available on the system
+         ""QSslSocket: cannot resolve SSLv3_client_method"",
+         ""QSslSocket: cannot resolve SSLv3_server_method"",
++        # When enabling debugging with QtWebEngine
++        ""Remote debugging server started successfully. Try pointing a ""
++            ""Chromium-based browser to "",
+     ]
+     if sys.platform == 'darwin':
+         suppressed_msgs += [","You somehow got a change from `master` into your branch again, in e6d2167085688264e5ee6a81cfd2a7a8f10ded13. While it's not something terribly bad (as it will be fine after merging), it's kind of confusing, and I have no idea how it happens :laughing: Are you trying to update changes from `master` while working on your branch somehow? How do you do that?","I think this should be ""Chromium-based browser"" or ""Remote debug"
+5739,"@@ -3083,10 +3083,14 @@ initiate_request (OtPullData                 *pull_data,
+             g_clear_pointer (&delta_from_revision, g_free);
+         }
+
+-      /* This is similar to the below, except we *might* use the previous
+-       * commit, or we might do a scratch delta first.
++      /* If the current ref is different from the target, then this is similar
++       * to the below, except we *might* use the previous commit, or we might do
++       * a scratch delta first.
+        */
+-      initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);
++      if (!(delta_from_revision && g_str_equal (delta_from_revision, to_revision)))
++        initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);
++      else
++        queue_scan_one_metadata_object (pull_data, to_revision, OSTREE_OBJECT_TYPE_COMMIT, NULL, 0, ref);
+     }
+   else
+     {","Minor, can we drop the leading `!` and just swap the if and the else blocks?",please add a space before the closing parenthesis
+5740,"@@ -102,7 +102,9 @@ class SCNetRoIHead(CascadeRoIHead):
+         bbox_head = self.bbox_head[stage]
+         bbox_feats = bbox_roi_extractor(
+             x[:len(bbox_roi_extractor.featmap_strides)], rois)
+-        if self.with_semantic and semantic_feat is not None:
++        # bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.
++        if self.with_semantic and semantic_feat is not None \
++                and bbox_feats.shape[0] > 0:
+             bbox_semantic_feat = self.semantic_roi_extractor([semantic_feat],
+                                                              rois)
+             if bbox_semantic_feat.shape[-2:] != bbox_feats.shape[-2:]:",`bbox_feats.shape[0] > 0` requires the number of proposal is not 0.,you could use bbox_feats.shape[-1] here instead of the \
+5741,"@@ -1,4 +1,4 @@
+-const { h, Component } = require('preact')
++const { Component } = require('preact')
+
+ module.exports = class CloseWrapper extends Component {
+   componentWillUnmount () {","Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining.",how was this even working before?
+5742,"@@ -15,8 +15,10 @@
+ #include ""domain.h""
+ #include ""error.h""
+ #include ""update.h""
++#include ""force.h""
+
+ #include <cstring>
++#include <fmt/format.h>
+
+ using namespace LAMMPS_NS;
+ ","format.h is not a system header but bundled with LAMMPS. This should be `#include ""fmt/format.h""`",Is this needed?
+5743,"@@ -441,8 +441,15 @@ public final class BKDReader extends PointValues implements Accountable {
+
+   void visitDocValues(int[] commonPrefixLengths, byte[] scratchDataPackedValue, byte[] scratchMinIndexPackedValue, byte[] scratchMaxIndexPackedValue,
+                       IndexInput in, int[] docIDs, int count, IntersectVisitor visitor) throws IOException {
++    if (version >= BKDWriter.VERSION_LOW_CARDINALITY_LEAVES) {
++      visitDocValuesWithCardinality(commonPrefixLengths, scratchDataPackedValue, scratchMinIndexPackedValue, scratchMaxIndexPackedValue, in, docIDs, count, visitor);
++    } else {
++      visitDocValuesNoCardinality(commonPrefixLengths, scratchDataPackedValue, scratchMinIndexPackedValue, scratchMaxIndexPackedValue, in, docIDs, count, visitor);
++    }
++  }
+
+-
++  void visitDocValuesNoCardinality(int[] commonPrefixLengths, byte[] scratchDataPackedValue, byte[] scratchMinIndexPackedValue, byte[] scratchMaxIndexPackedValue,
++                      IndexInput in, int[] docIDs, int count, IntersectVisitor visitor) throws IOException {
+     readCommonPrefixes(commonPrefixLengths, scratchDataPackedValue, in);
+
+     if (numIndexDims != 1 && version >= BKDWriter.VERSION_LEAF_STORES_BOUNDS) {",could we always call visitDocValuesWithCardinality? It seems to include the version check already?,I think this should be called `visitDocValuesWithCardina
+5744,"@@ -607,6 +607,10 @@ public class RegistrationRequest {
+           + HUB_HOST + "" X -"" + HUB_PORT + "" 5555. The specified config was -"" + HUB_HOST + "" ""
+           + hub + "" -"" + HUB_PORT + "" "" + port);
+     }
++
++    if(port==-1){
++    	throw new GridConfigurationException(""No port was specified in -hub parameter. Example - http://""+hub+"":4444/grid/register"");
++    }
+   }
+
+ ","I think if they _don't_ specify a port, we should assume grid default (which is 4444)",Consider using `GridConfigurationException.addSuppressed(...)` instead of duplicating the error message.
+5745,"@@ -155,14 +155,12 @@ std::vector<std::string> enumerateTautomerSmiles(
+   cleanup(*mol, params);
+   MolOps::sanitizeMol(*mol);
+
+-  auto *tautparams = new TautomerCatalogParams(params.tautomerTransforms);
+-  //	unsigned int ntautomers = tautparams->getNumTautomers();
+-  TautomerEnumerator te(new TautomerCatalog(tautparams));
++  TautomerEnumerator te(params);
+
+-  std::vector<ROMOL_SPTR> res = te.enumerate(*mol);
++  auto res = te.enumerate(*mol);
+
+   std::vector<std::string> tsmiles;
+-  for (const auto &r : res) {
++  for (const auto &r : res.tautomers) {
+     tsmiles.push_back(MolToSmiles(*r));
+   }
+ ",This looks to be a breaking change. I know it will affect some of my code that uses the Tautomer enumerator.,const TautomerCatalogParams &
+5746,"@@ -61,8 +61,12 @@ func (m *bucketlistMessage) String() string {
+ 	if output.Format == """" {
+ 		var lines []string
+ 		lines = append(lines, fmt.Sprintf(""Blockchain Node: %s"", m.Node))
+-		for _, bucket := range m.Bucketlist {
+-			lines = append(lines, bucket.String())
++		if len(m.Bucketlist) == 0 {
++			lines = append(lines, ""Empty bucketlist with given address"")
++		} else {
++			for _, bucket := range m.Bucketlist {
++				lines = append(lines, bucket.String())
++			}
+ 		}
+ 		return strings.Join(lines, ""\n"")
+ 	}",Perhaps remove this line,"Nitpick: ""Empty bucketlist"" is a bit ambiguous. Maybe just say `No bucket found in %s`"
+5747,"@@ -707,6 +707,9 @@ void removeHs(RWMol &mol, const RemoveHsParameters &ps, bool sanitize) {
+     if (!ps.removeMapped && atom->getAtomMapNum()) {
+       continue;
+     }
++    if (!ps.removeHydrides && atom->getAtomicNum() == 1 && atom->getFormalCharge() == -1) {
++      continue;
++    }
+     bool removeIt = true;
+     if (atom->getDegree() &&
+         (!ps.removeDummyNeighbors || !ps.removeDefiningBondStereo ||","Ah, missed this one. Sorry: you don't need to test the atomic number here. that's taken care of above on line 683.",what's this check for?
+5748,"@@ -146,8 +146,11 @@ func (c *roundCalculator) roundInfo(
+ 		}
+ 	}
+ 	if !lastBlockTime.Before(now) {
++		// TODO: if this is the case, the system time is far behind the time of other nodes.
++		// the code below is just to mute the warning, but ""panic"" may be a better choice.
++		time.Sleep(lastBlockTime.Sub(now))
+ 		err = errors.Errorf(
+-			""last block time %s is a future time, vs now %s"",
++			""last block time %s is a future time, vs now %s. it seems that your system time is far behind.\nplease calibrate your system time and restart the chain."",
+ 			lastBlockTime,
+ 			now,
+ 		)","roundInfo() is called by couple of places in consensus for safety, better test/verify the delay of return err due to this Sleep() would not affect the normal functionality, like consensus can still be reached, full-node can correctly sync","please refrain from using `time.Sleep`, `sync.WaitGroup` and `Sync`"
+5749,"@@ -376,8 +376,9 @@ func (sb *RustSectorBuilder) GeneratePoSt(req GeneratePoStRequest) (GeneratePoSt
+ 	defer elapsed(""GeneratePoSt"")()
+
+ 	// flattening the byte slice makes it easier to copy into the C heap
+-	flattened := make([]byte, 32*len(req.CommRs))
+-	for idx, commR := range req.CommRs {
++	commRs := req.SortedCommRs.Values()
++	flattened := make([]byte, 32*len(commRs))
++	for idx, commR := range commRs {
+ 		copy(flattened[(32*idx):(32*(1+idx))], commR[:])
+ 	}
+ ",This 32 could go away too.,Is it possible to have a test for this in a separate unit test?
+5750,"@@ -146,6 +146,8 @@ class Notification extends Component {
+ 			module,
+ 			moduleName,
+ 			pageIndex,
++			pageSpeedLink,
++			pageSpeedLabel,
+ 		} = this.props;
+
+ 		if ( getCache( `notification::dismissed::${ id }` ) ) {","These props should be less specifically named since the component is generic, for example `anchorLink`, `anchorLinkLabel`.",shouldn't it be `pageIndexLabel`?
+5751,"@@ -189,13 +189,13 @@ func (r *AWSMachineReconciler) reconcileDelete(machineScope *scope.MachineScope,
+ 		// and AWSMachine
+ 		// 3. Issue a delete
+ 		// 4. Scale controller deployment to 1
+-		machineScope.V(2).Info(""Unable to locate instance by ID or tags"")
++		machineScope.V(2).Info(""Unable to locate EC2 instance by ID or tags"")
+ 		r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""NoInstanceFound"", ""Unable to find matching EC2 instance"")
+ 		machineScope.AWSMachine.Finalizers = util.Filter(machineScope.AWSMachine.Finalizers, infrav1.MachineFinalizer)
+ 		return reconcile.Result{}, nil
+ 	}
+
+-	machineScope.V(3).Info(""Instance found matching deleted AWSMachine"", ""instanceID"", instance.ID)
++	machineScope.V(3).Info(""EC2 instance found matching deleted AWSMachine"", ""instance-id"", instance.ID)
+
+ 	// Check the instance state. If it's already shutting down or terminated,
+ 	// do nothing. Otherwise attempt to delete it.","In the future, it'd be great if we can separate commits or PRs that aren't in the same scope",Instead of `instance-id` I would use `instance-id` as the key
+5752,"@@ -133,7 +133,11 @@ class ScriptableType(AutoPropertyType):
+
+ 	def __new__(meta, name, bases, dict):
+ 		cls = super(ScriptableType, meta).__new__(meta, name, bases, dict)
+-		gestures = getattr(cls, ""_%s__gestures"" % cls.__name__, {})
++		# #8463: To avoid name mangling conflicts, create a copy of the __gestures dictionary.
++		try:
++			gestures = getattr(cls, ""_%s__gestures"" % cls.__name__).copy()
++		except AttributeError:
++			gestures = {}
+ 		# Python 3 incompatible.
+ 		for name, script in dict.iteritems():
+ 			if not name.startswith('script_'):","can you define the string format on a different line, so it can be named, and so that it does not have to be constructed twice?","I think this try/except is unnecessary. Just `getattr(cls, ""_%s__gestures"" % cls.__name__)` will do the same."
+5753,"@@ -91,3 +91,9 @@ class AnsibleGalaxyInstall:
+         except sh.ErrorReturnCode as e:
+             LOG.error('ERROR: {}'.format(e))
+             utilities.sysexit(e.exit_code)
++
++    def download(self, config_file):
++        utilities.print_info('Installing role dependencies ...')
++        self.add_env_arg('ANSIBLE_CONFIG', config_file)
++        self.bake()
++        self.execute()",Can we write a unit test for this.,Do we need to call `bake()` here?
+5754,"@@ -685,6 +685,8 @@ class AbstractTab(QWidget):
+
+     @pyqtSlot(bool)
+     def _on_load_finished(self, ok):
++        sess_manager = objreg.get('session-manager')
++        sess_manager.session_save('_autosave', quiet=True, force=True)
+         if ok and not self._has_ssl_errors:
+             if self.url().scheme() == 'https':
+                 self._set_load_status(usertypes.LoadStatus.success_https)","Same as above, use `.delete('_autosave')`, not the command handler.",Is there a reason for quiet=True here?
+5755,"@@ -68,18 +68,7 @@ class BatchDataReader extends BaseDataReader<ColumnarBatch> {
+     // update the current file for Spark's filename() function
+     InputFileBlockHolder.set(file.path().toString(), task.start(), task.length());
+
+-    // schema or rows returned by readers
+-    PartitionSpec spec = task.spec();
+-    Set<Integer> idColumns = spec.identitySourceIds();
+-    Schema partitionSchema = TypeUtil.select(expectedSchema, idColumns);
+-    boolean projectsIdentityPartitionColumns = !partitionSchema.columns().isEmpty();
+-
+-    Map<Integer, ?> idToConstant;
+-    if (projectsIdentityPartitionColumns) {
+-      idToConstant = PartitionUtil.constantsMap(task, BatchDataReader::convertConstant);
+-    } else {
+-      idToConstant = ImmutableMap.of();
+-    }
++    Map<Integer, ?> idToConstant = PartitionUtil.constantsMap(task, BatchDataReader::convertConstant);
+
+     CloseableIterable<ColumnarBatch> iter;
+     InputFile location = getInputFile(task);","It isn't necessary to check whether there are projected ID columns. The code is shorter if the values are available by default, even if they aren't used. This fixes the problem where there are constants to add (like `_file`) but no identity partition values are projected.",Why remove this?
+5756,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,Does this need to be added to the dashboard?
+5757,"@@ -6,9 +6,9 @@ package net.sourceforge.pmd.lang.java.rule.bestpractices;
+
+ import java.util.List;
+
++import net.sourceforge.pmd.lang.java.ast.ASTAnyTypeDeclaration;
+ import org.jaxen.JaxenException;
+
+-import net.sourceforge.pmd.lang.ast.AbstractNode;
+ import net.sourceforge.pmd.lang.ast.Node;
+ import net.sourceforge.pmd.lang.java.ast.ASTAllocationExpression;
+ import net.sourceforge.pmd.lang.java.ast.ASTArrayInitializer;","@KroArtem This is the Checkstyle violation. This import should be grouped with other `net.sourceforge.pmd` imports below, in alphabetical order",why not remove this line?
+5758,"@@ -47,6 +47,7 @@ import (
+ 	""github.com/ncw/rclone/lib/rest""
+ 	""github.com/ncw/swift""
+ 	""github.com/pkg/errors""
++	""github.com/ncw/rclone/fs""
+ )
+
+ // Register with Fs",File is not `goimports`-ed (from `goimports`),This import should go with the other `github
+5759,"@@ -126,6 +126,10 @@ public class MessageTopView extends LinearLayout implements ShowPicturesControll
+         mHeaderContainer.setOnFlagListener(listener);
+     }
+
++    public void setOnToggleFlagLongClickListener(OnLongClickListener listener){
++        mHeaderContainer.setOnFlagListener(listener);
++    }
++
+     public void showAllHeaders() {
+         mHeaderContainer.onShowAdditionalHeaders();
+     }",This change seems unrelated to copying email addresses to the clipboard. Please limit the scope of pull requests as much as possible.,minor: missing space before `{`
+5760,"@@ -370,6 +370,13 @@ static void seat_client_send_keymap(struct wlr_seat_client *client,
+ 			continue;
+ 		}
+
++		if (keyboard->keymap == NULL) {
++			wl_keyboard_send_keymap(resource,
++				WL_KEYBOARD_KEYMAP_FORMAT_NO_KEYMAP, keymap_fd, 0);
++			close(keymap_fd);
++			continue;
++		}
++
+ 		void *ptr = mmap(NULL, keyboard->keymap_size, PROT_READ | PROT_WRITE,
+ 				MAP_SHARED, keymap_fd, 0);
+ 		if (ptr == MAP_FAILED) {","I'm assuming that there isn't a way for us to skip sending an fd here (-1?), and that we're allocating this fd just to send a legal but useless value across?","I know it was already written this way, but wouldn't it be better to `break` here, rather than `continue` on next line?"
+5761,"@@ -66,7 +66,11 @@ func TransportSpec(opts ...Option) yarpcconfig.TransportSpec {
+ // All parameters of TransportConfig are optional. This section
+ // may be omitted in the transports section.
+ type TransportConfig struct {
+-	Backoff yarpcconfig.Backoff `config:""backoff""`
++	ServerMaxRecvMsgSize int                 `config:""serverMaxRecvMsgSize""`
++	ServerMaxSendMsgSize int                 `config:""serverMaxSendMsgSize""`
++	ClientMaxRecvMsgSize int                 `config:""clientMaxRecvMsgSize""`
++	ClientMaxSendMsgSize int                 `config:""clientMaxSendMsgSize""`
++	Backoff              yarpcconfig.Backoff `config:""backoff""`
+ }
+
+ // InboundConfig configures a gRPC Inbound.",might be good for the units (bytes?) to be in the variable name.,I think these configs are backwards. `ServerMaxRecvMsgSize` and `ClientMaxSendMsgSize` are only used to send messages t
+5762,"@@ -1,6 +1,6 @@
+ # NOTE: There are several rewrite rules defined in
+ # config/initializers/rack_rewrite.rb which run before these routes.
+-Upcase::Application.routes.draw do
++Rails.application.routes.draw do
+   scope ""upcase"" do
+     root to: ""marketing#show""
+ ",Metrics/BlockLength: Block has too many lines. [166/25],Metrics/BlockLength: Block has too many lines. [32/25]
+5763,"@@ -23,9 +23,9 @@
+ CSV file based implementation of a record stream
+
+ FileRecordStream is class that can read and write .csv files that contain
+-records. The file has 3 header lines that contain for each field the name, type
+-and a special indicator for the fields that serve as the reset field,
+-sequence id field and timestamp field. The other fields
++records. The file has 3 header lines that contain, for each field, the name
++(line 1), type (line 2), and a special indicator (line 3) for those fields that
++serve as the reset field, sequence id field, and timestamp field.
+
+ The header lines look like:
+ ","I'd end the sentence after `special indicator (line 3)`. And then start a new sentence: `The special field can indicate that the field specifies a reset, is a sequence ID, or is a timestamp for the record.`",Could you please add a link to the docs for `FileRecordStream.csv`
+5764,"@@ -105,11 +105,9 @@ def bbox_mapping_back(bboxes, img_shape, scale_factor, flip):
+
+ def bbox2roi(bbox_list):
+     """"""Convert a list of bboxes to roi format.
+-
+     Args:
+         bbox_list (list[Tensor]): a list of bboxes corresponding to a batch
+             of images.
+-
+     Returns:
+         Tensor: shape (n, 5), [batch_ind, x1, y1, x2, y2]
+     """"""",These empty lines can be kept.,Can you revert the removal of newlines introduced in this PR please?
+5765,"@@ -176,14 +176,14 @@ public class VelocityResponseWriterTest extends SolrTestCaseJ4 {
+     // The test init properties file turns off being able to use $foreach.index (the implicit loop counter)
+     // The foreach.vm template uses $!foreach.index, with ! suppressing the literal ""$foreach.index"" output
+
+-    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocity"",VelocityResponseWriter.TEMPLATE,""foreach"")));
+-    assertEquals("""", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")));
++    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocity"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
++    assertEquals("""", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
+
+     // Turn off trusted configset, which disables the init properties
+     h.getCoreContainer().getCoreDescriptor(h.coreName).setConfigSetTrusted(false);
+     assertFalse(h.getCoreContainer().getCoreDescriptor(coreName).isConfigSetTrusted());
+
+-    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")));
++    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
+
+     // set the harness back to the default of trusted
+     h.getCoreContainer().getCoreDescriptor(h.coreName).setConfigSetTrusted(true);","For some reason these tests started failing due to an extra `NEWLINE` returned from `h.query()`. Have not tried to check whether this may be a problem for real templates or not, just fixed the failing tests. Anyone with an opinion here?",@gsmet I think this is the only real change in this file. the rest i
+5766,"@@ -42,6 +42,9 @@ type TraceContext struct{}
+ var _ propagation.TextFormat = TraceContext{}
+ var traceCtxRegExp = regexp.MustCompile(""^[0-9a-f]{2}-[a-f0-9]{32}-[a-f0-9]{16}-[a-f0-9]{2}-?"")
+
++// DefaultPropagator is the default trace propagator.
++var DefaultPropagator propagation.TextFormat = TraceContext{}
++
+ func (hp TraceContext) Inject(ctx context.Context, supplier propagation.Supplier) {
+ 	sc := SpanFromContext(ctx).SpanContext()
+ 	if sc.IsValid() {",It is better to have a method than a var.,Why is this exported?
+5767,"@@ -58,9 +58,11 @@ func (s scannerCtxExecMgrFactory) NewExecutionManager(shardID int32) (persistenc
+ const (
+ 	scannerContextKey = contextKey(0)
+
+-	maxConcurrentActivityExecutionSize     = 10
+-	maxConcurrentWorkflowTaskExecutionSize = 10
+-	infiniteDuration                       = 20 * 365 * 24 * time.Hour
++	maxConcurrentActivityExecutionSize = 10
++	maxConcurrentWorkflowExecutionSize = 10
++	maxConcurrentActivityTaskPollers   = 16
++	maxConcurrentWorkflowTaskPollers   = 16
++	infiniteDuration                   = 20 * 365 * 24 * time.Hour
+
+ 	tqScannerWFID                  = ""temporal-sys-tq-scanner""
+ 	tqScannerWFTypeName            = ""temporal-sys-tq-scanner-workflow""","concurrent poller won't be larger than concurrent execution. Jump from 2 -> 16 seems aggressive. I suggest to use 8. Ideally, this should be dynamic config. :)",Do we really need to change all these constants? I thought they were
+5768,"@@ -0,0 +1,5 @@
++_base_ = ['./yolact_r50.py']
++
++model = dict(pretrained='torchvision://resnet101', backbone=dict(depth=101))
++
++work_dir = './work_dirs/yolact_r101'",List is redundant.,Can you add a `use_cuda=False` flag here? I think it would be a bit more convenient to set this to `True` by default.
+5769,"@@ -88,8 +88,9 @@ public class LoginActivity extends BaseActivity implements CustomTabActivityHelp
+
+         setTitle(getString(R.string.txtSignIn));
+         setSupportActionBar(toolbar);
+-        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
+-
++        if(getSupportActionBar()!=null) {
++            getSupportActionBar().setDisplayHomeAsUpEnabled(true);
++        }
+         userLoginUri = Uri.parse(getString(R.string.website) + ""cgi/user.pl"");
+         resetPasswordUri = Uri.parse(getString(R.string.website) + ""cgi/reset_password.pl"");
+ ","Please use a string resource here rather than the hardcoded string ""user"". This allows the app to be multilingual.",Please add a space between `if` and `!=`
+5770,"@@ -18,13 +18,10 @@ package cstorpoolit
+
+ import (
+ 	""testing""
+-
+ 	""time""
+
+ 	. ""github.com/onsi/ginkgo""
+ 	. ""github.com/onsi/gomega""
+-	""github.com/openebs/CITF""
+-	""github.com/openebs/CITF/citf_options""
+ 	apis ""github.com/openebs/CITF/pkg/apis/openebs.io/v1alpha1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )",@aswathkk Why did we remove this import? I guess we are using it.,Thanks for cleaning this up :)
+5771,"@@ -184,7 +184,6 @@ func (s *Service) Stop() {
+ 	remainingTime = s.sleep(shardOwnershipTransferDelay, remainingTime)
+
+ 	s.GetLogger().Info(""ShutdownHandler: No longer taking rpc requests"")
+-	s.handler.PrepareToStop()
+ 	remainingTime = s.sleep(gracePeriod, remainingTime)
+
+ 	// TODO: Change this to GracefulStop when integration tests are refactored.",Why? I thought this is for graceful shutdown.,why remove this?
+5772,"@@ -59,10 +59,14 @@ module Bolt
+         if result.instance_of? Bolt::TaskResult
+           @stream.puts(indent(2, ::JSON.pretty_generate(result.value)))
+         elsif result.instance_of? Bolt::CommandResult
+-          @stream.puts(indent(2, ""STDOUT:""))
+-          @stream.puts(indent(4, result.stdout))
+-          @stream.puts(indent(2, ""STDERR:""))
+-          @stream.puts(indent(4, result.stderr))
++          unless result.stdout.strip.empty?
++            @stream.puts(indent(2, ""STDOUT:""))
++            @stream.puts(indent(4, result.stdout))
++          end
++          unless result.stderr.strip.empty?
++            @stream.puts(indent(2, ""STDERR:""))
++            @stream.puts(indent(4, result.stderr))
++          end
+         end
+       end
+ ",Can `result.stdout` or `result.stderr` be nil?,"end at 12, 4 is not aligned with if at 8, 16."
+5773,"@@ -130,7 +130,8 @@ public class PyIssueParserProvider implements BlazeIssueParserProvider {
+       if (projectScope.contains(vf)) {
+         return 0;
+       }
+-      return PythonSdkType.isStdLib(vf, sdk) ? 2 : 1;
++      return 2;
++      // return PythonSdkType.isStdLib(vf, sdk) ? 2 : 1;
+     }
+
+     /** defaults to -1 if no line number can be parsed. */",@mprobst Looks like the `isStdLib` function has been removed in the latest Python plugin. Any thoughts on how to handle this? The new version doesn't seem to have any relevant alternatives.,Is there a reason why we can't just delete th
+5774,"@@ -32,6 +32,8 @@ type Config struct {
+ 	RuleRendererOverride rules.RuleRenderer
+ 	IPIPMTU              int
+
++	MaxIPSetSize int
++
+ 	IptablesRefreshInterval time.Duration
+
+ 	RulesConfig rules.Config",How can there be a configured max ipset size? Surely we need to write ipsets with however many members are implied by the Calico datastore?,why not make this a `uint` instead?
+5775,"@@ -205,7 +205,7 @@ export default AbstractEditController.extend(IncidentStatuses, FriendlyId, Patie
+
+     showDeleteAttachment(attachment) {
+       let i18n = get(this, 'i18n');
+-      let message = i18n.t('incident.messages.deleteAttachment');
++      let message = i18n.t('messages.delete_singular', { name: 'attachment' });
+       let model = Ember.Object.create({
+         itemToDelete: attachment
+       });",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,"I don't think the name is very descriptive, c"
+5776,"@@ -75,6 +75,14 @@ public class ExpressionVisitors {
+       return null;
+     }
+
++    public <T> R isNaN(BoundReference<T> ref) {
++      throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement isNaN"");
++    }
++
++    public <T> R notNaN(BoundReference<T> ref) {
++      throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement notNaN"");
++    }
++
+     public <T> R lt(BoundReference<T> ref, Literal<T> lit) {
+       return null;
+     }",why not be consistent with `isNull` and `notNull` and return null?, missing `@CheckForNull` annotation.
+5777,"@@ -41,6 +41,7 @@ type BackendServiceConfig struct {
+ 	*Logging      `yaml:""logging,flow""`
+ 	Sidecars      map[string]*SidecarConfig `yaml:""sidecars""`
+ 	Network       NetworkConfig             `yaml:""network""`
++	DockerLabels  map[string]string         `yaml:""docker_labels,flow""`
+ }
+
+ type imageWithPortAndHealthcheck struct {",Did we forget to remove this field?,Why not using a `map[string]struct{}
+5778,"@@ -60,4 +60,9 @@ public class BaseRefreshableMap<K, V extends IRefreshable> extends HashMap<K, V>
+   public BaseRefreshableMap<K, V> clone() {
+     return (BaseRefreshableMap<K, V>) super.clone();
+   }
++
++  @Override
++  public int elementCount() {
++    return this.values().stream().mapToInt(elem -> elem.elementCount()).sum();
++  }
+ }",What if there is no element?,The elements are sorted by element t
+5779,"@@ -52,8 +52,15 @@ func (c *Client) uploadAction(target *core.BuildTarget, isTest, isRun bool) (*pb
+ 	return command, digest, err
+ }
+
+-// buildAction creates a build action for a target and returns the command and the action digest digest. No uploading is done.
++// buildAction creates a build action for a target and returns the command and the action digest. No uploading is done.
+ func (c *Client) buildAction(target *core.BuildTarget, isTest, stamp bool) (*pb.Command, *pb.Digest, error) {
++	c.buildActionMutex.Lock()
++	defer c.buildActionMutex.Unlock()
++
++	if d, ok := c.buildActions[target.Label]; ok {
++		return d.command, d.actionDigest, nil
++	}
++
+ 	inputRoot, err := c.uploadInputs(nil, target, isTest)
+ 	if err != nil {
+ 		return nil, nil, err",I think you need to be careful to honour isTest and stamp here.,It seems like this mutex should be a
+5780,"@@ -14,10 +14,16 @@
+  */
+ package com.google.api.codegen.transformer.nodejs;
+
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
++import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
++import com.google.api.tools.framework.model.TypeRef;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",why zero value for `arrayType` for the default value of the optional args?,This file has nothing to do with your PR.
+5781,"@@ -264,6 +264,14 @@ class Filter extends WidgetBase
+                 $value = post('options.value.' . $scope->scopeName) ?: null;
+                 $this->setScopeValue($scope, $value);
+                 break;
++
++            case 'clear':
++                foreach ($this->getScopes() as $scope) {
++                    $this->setScopeValue($scope, null);
++                }
++
++                return ['.control-filter' => $this->render()];
++                break;
+         }
+
+         /*","@robinbonnes ~~Would you mind putting the array key and value on a new line - it makes it more readable as an array.~~ Never mind, see discussion below.",This feels a bit awkward. Why not just do
+5782,"@@ -26,6 +26,7 @@ var version = ""(unreleased version)""
+ func main() {
+ 	var (
+ 		justVersion      bool
++		cniNet, cniIpam  bool
+ 		address          string
+ 		meshAddress      string
+ 		logLevel         string","I've never seen us do this anywhere else - why here? Why not `address, meshAddress string`?",Unnecessary new line?
+5783,"@@ -191,7 +191,9 @@ public class RequestUtil {
+     }
+
+     // implement compat for existing components...
+-    JsonQueryConverter jsonQueryConverter = new JsonQueryConverter();
++    JsonQueryConverter jsonQueryConverter = (JsonQueryConverter) req.getContext()
++        .computeIfAbsent(JsonQueryConverter.contextKey, (k)->new JsonQueryConverter());
++
+     if (json != null && !isShard) {
+       for (Map.Entry<String,Object> entry : json.entrySet()) {
+         String key = entry.getKey();","I think it's necessary only for the earlier ""dynamic"" approach. I suppose it's not necessary in the eager one.",why not create a new `JsonQueryConverter`
+5784,"@@ -437,4 +437,9 @@ class Configurator
+             ? $this->doctrineTypeToFormTypeMap[$doctrineType]
+             : $doctrineType;
+     }
++
++	public function getBackendConfig()
++	{
++		return $this->backendConfig;
++	}
+ }",Same here than [there](#r26168925),For what is this method used for?
+5785,"@@ -53,12 +53,12 @@ public class ApplicationDTO {
+         this.typeId = builder.typeId;
+         this.categoryId = builder.categoryId;
+         if (builder.id != null) {
+-            if (builder.id.matches(""^[a-zA-Z0-9_]+$"")) {
++            if (builder.id.matches(""^[a-zA-Z0-9_.]+$"")) {
+                 this.id = builder.id;
+             } else {
+                 LOGGER.warn(String.format(""Application ID (%s) contains invalid characters, will remove them."",
+                         builder.id));
+-                this.id = builder.id.replaceAll(""[^a-zA-Z0-9_]"", """");
++                this.id = builder.id.replaceAll(""[^a-zA-Z0-9_.]"", """");
+             }
+         } else {
+             this.id = null;",Again we should think about moving this pattern to a static final field,why not use `^`? and `^[a-zA-Z0-9
+5786,"@@ -186,7 +186,7 @@ class ConfigManager
+     private function doProcessConfig($backendConfig)
+     {
+         $configPasses = array(
+-            new NormalizerConfigPass(),
++            new NormalizerConfigPass($this->container->get('easyadmin.controller_resolver')),
+             new DesignConfigPass($this->container->get('twig'), $this->container->getParameter('kernel.debug')),
+             new MenuConfigPass(),
+             new ActionConfigPass(),",haven't been implemented the `__constructor` for `NormalizerConfigPass` ?,Is this really needed? Are you su
+5787,"@@ -190,3 +190,16 @@ class Collect(object):
+     def __repr__(self):
+         return self.__class__.__name__ + '(keys={}, meta_keys={})'.format(
+             self.keys, self.meta_keys)
++
++
++@PIPELINES.register_module
++class WrapFieldsToLists(object):
++
++    def __call__(self, results):
++        # Wrap dict fields into lists
++        for key, val in results.items():
++            results[key] = [val]
++        return results
++
++    def __repr__(self):
++        return '{}()'.format(self.__class__.__name__)",Docstring is missing.,You can use `.format` here instea
+5788,"@@ -74,6 +74,7 @@ bool BaseEvents::loadFromXml()
+
+ 		if (!success || !registerEvent(event, node)) {
+ 			delete event;
++			return false;
+ 		}
+ 	}
+ 	return true;","I don't see the reason of this return as it will stop loading in half because an error, thats bad imo. Or you load it all and report errors or you load nothing and terminate, the first is as it always was so I wouldn't change that.",@gmajoulet I'm not sure if this is the right fix or if it should be `return false;` for consistency with the rest of the function.
+5789,"@@ -58,9 +58,9 @@ func NewMockKademlia(o ...Option) *Mock {
+ 	return m
+ }
+
+-// AddPeer is called when a peer is added to the topology backlog
++// AddPeers  is called when a peers are added to the topology backlog
+ // for further processing by connectivity strategy.
+-func (m *Mock) AddPeer(ctx context.Context, addr swarm.Address) error {
++func (m *Mock) AddPeers(ctx context.Context, addr ...swarm.Address) error {
+ 	panic(""not implemented"") // TODO: Implement
+ }
+ ",change from AddPeer to AddPeers added a space in some occurrences,Shouldn't this be `swarm.Address`?
+5790,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,This import seems unused and should be removed.
+5791,"@@ -29,15 +29,15 @@ import (
+ const NodePortLocalChain = ""ANTREA-NODE-PORT-LOCAL""
+
+ // IPTableRules provides a client to perform IPTABLES operations
+-type iptablesRules struct {
++type IPTableRules struct {
+ 	name  string
+ 	table *iptables.Client
+ }
+
+-// NewIPTableRules retruns a new instance of IPTableRules
+-func NewIPTableRules() *iptablesRules {
++// NewIPTableRules returns a new instance of IPTableRules
++func NewIPTableRules() *IPTableRules {
+ 	iptInstance, _ := iptables.New(true, false)
+-	iptRule := iptablesRules{
++	iptRule := IPTableRules{
+ 		name:  ""NPL"",
+ 		table: iptInstance,
+ 	}","Do you remove ""s"" from ""iptables"" to IPTable"" on purpose? I feel it should be ""IPTablesRules"".",`iptRule := iptablesRules {` should be on a new line.
+5792,"@@ -16,17 +16,17 @@ package org.hyperledger.besu.ethereum.api.jsonrpc.internal.privacy.methods.priv;
+
+ import org.hyperledger.besu.ethereum.api.jsonrpc.RpcMethod;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequestContext;
++import org.hyperledger.besu.ethereum.api.jsonrpc.internal.methods.JsonRpcMethod;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcResponse;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcSuccessResponse;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.PrivacyParameters;
+
+-public class PrivGetPrivacyPrecompileAddress extends PrivacyApiMethod {
++public class PrivGetPrivacyPrecompileAddress implements JsonRpcMethod {
+
+   private final Integer privacyAddress;
+
+   public PrivGetPrivacyPrecompileAddress(final PrivacyParameters privacyParameters) {
+-    super(privacyParameters);
+     privacyAddress = privacyParameters.getPrivacyAddress();
+   }
+ ","nit: not your problem - but I wonder if this should have been a ""ConstantResponseRpc"" - which takes a name and a value .... maybe a more reusable concept.",This class does not seem to be used anywhere. Can it be removed?
+5793,"@@ -26,7 +26,7 @@ import (
+ // instrumentationName is empty, then a implementation defined default name
+ // will be used instead.
+ //
+-// This is short for MeterProvider().Meter(name)
++// This is short for otel.GetMeterProvider().Meter(name)
+ func Meter(instrumentationName string, opts ...metric.MeterOption) metric.Meter {
+ 	return GetMeterProvider().Meter(instrumentationName, opts...)
+ }",These changes have been resolved upstream. We can revert changes to this file when synced.,Does this need to be reverted?
+5794,"@@ -33,7 +33,7 @@ T = TypeVar(""T"")
+
+ class Partition(Generic[T]):
+     """"""
+-    Partition is the representation of a logical slice across an axis of a pipeline's work
++    A Partition represents a single slice of the entire set of a job's possible work.
+
+     Args:
+         value (Any): The object for this partition",The description predates this diff but I think we can come up with something more grounded.,We might want to clarify here that it's a single slice of the en
+5795,"@@ -277,7 +277,17 @@ type VolumeAPISpec struct {
+ 	} `yaml:""metadata""`
+ }
+
+-// -------------Snapshot Structs ----------
++// SnapshotAPISpec hsolds the config for creating asnapshot of volume
++type SnapshotAPISpec struct {
++	Kind       string `yaml:""kind""`
++	APIVersion string `yaml:""apiVersion""`
++	Metadata   struct {
++		Name string `yaml:""name""`
++	} `yaml:""metadata""`
++	Spec struct {
++		VolumeName string `yaml:""volumeName""`
++	} `yaml:""spec""`
++}
+
+ // VolumeSnapshot is volume snapshot object accessible to the user. Upon successful creation of the actual
+ // snapshot by the volume provider it is bound to the corresponding VolumeSnapshotData through","Let the Kind, APIVersion & Metadata follow the rules followed by Volume. What is the reason for a change for snapshot struct ?",Shouldn't this be `APIVersion string`?
+5796,"@@ -24,14 +24,14 @@ import org.apache.servicecomb.foundation.metrics.registry.GlobalRegistry;
+
+ import com.google.common.eventbus.EventBus;
+ import com.netflix.servo.DefaultMonitorRegistry;
+-import com.netflix.spectator.servo.ServoRegistry;
+
+ public class DefaultRegistryInitializer implements MetricsInitializer {
+   public static final String SERVO_POLLERS = ""servo.pollers"";
+
+   private GlobalRegistry globalRegistry;
+
+-  private ServoRegistry registry;
++  @SuppressWarnings(""deprecation"")
++  private com.netflix.spectator.servo.ServoRegistry registry;
+
+   // create registry before init meters
+   @Override",seems that we did not strong depend servo no need to keep it? change to another one?,Why don't we inject `DefaultMonitorRegistry` here as well?
+5797,"@@ -142,7 +142,15 @@ boost::property_tree::ptree wait_response (nano::system & system, std::shared_pt
+ void check_block_response_count (nano::system & system, std::shared_ptr<nano::rpc> const & rpc, boost::property_tree::ptree & request, uint64_t size_count)
+ {
+ 	auto response (wait_response (system, rpc, request));
+-	ASSERT_EQ (size_count, response.get_child (""blocks"").front ().second.size ());
++	auto & blocks = response.get_child (""blocks"");
++	if (size_count > 0)
++	{
++		ASSERT_EQ (size_count, blocks.front ().second.size ());
++	}
++	else
++	{
++		ASSERT_TRUE (blocks.empty ());
++	}
+ }
+
+ class scoped_io_thread_name_change",Looks like this used to be UB before with an empty blocks and then calling `.second` on the `.front()`. Did it ever crash though?  ,Shouldn't you check if `size_count` is `0` first?
+5798,"@@ -121,7 +121,7 @@ function parseRunOn(runOn) {
+ }
+
+ function generateTopologyTests(testSuites, testContext, filter) {
+-  testSuites.forEach(testSuite => {
++  for (const testSuite of testSuites) {
+     // TODO: remove this when SPEC-1255 is completed
+     let runOn = testSuite.runOn;
+     if (!testSuite.runOn) {","Sorry about the code churn here, reworking this use normal loops and async await made debugging far more straight forward. For example, if configuring the fail point fails you find out when stepping over that line vs having to look for the ultimate catch clause that handled it.",`forEach` is not supported in IE11. Use `forEach` instead.
+5799,"@@ -56,7 +56,9 @@ const test = (suite, buildConfig = config.defaultBuildConfig, options) => {
+     braveArgs.push('--test-launcher-jobs=' + options.test_launcher_jobs)
+   }
+
++  const args = util.buildArgsToString(config.buildArgs())
+   // Build the tests
++  util.run('gn', ['gen', config.outputDir, '--args=""' + args + '""'], config.defaultOptions)
+   util.run('ninja', ['-C', config.outputDir, suite], config.defaultOptions)
+
+   if (config.targetOS === 'ios') {",this is wrong and should be reverted,"Can we do this before the `ninja` call, so that we can get"
+5800,"@@ -120,9 +120,10 @@ func main() {
+ 		log.Fatalf(""Failed to parse usage, exiting: %v"", err)
+ 	}
+ 	buildInfoLogCxt := log.WithFields(log.Fields{
+-		""version"":   buildinfo.GitVersion,
+-		""buildDate"": buildinfo.BuildDate,
+-		""gitCommit"": buildinfo.GitRevision,
++		""version"":    buildinfo.GitVersion,
++		""buildDate"":  buildinfo.BuildDate,
++		""gitCommit"":  buildinfo.GitRevision,
++		""GOMAXPROCS"": runtime.GOMAXPROCS(0),
+ 	})
+ 	buildInfoLogCxt.Info(""Felix starting up"")
+ 	log.Infof(""Command line arguments: %v"", arguments)","I think you'll need to add an import for runtime, before you can merge this PR. (Presumably it was already there for something else when you were working on this, but has since disappeared.)",why is this zero?
+5801,"@@ -74,7 +74,7 @@ import java.util.Set;
+ import static java.util.Collections.singletonList;
+
+ /**
+- * Test class for SyncState.
++ * Test class for SyncManager.
+  */
+ @RunWith(AndroidJUnit4.class)
+ @LargeTest",Unrelated typo fix.,I think this is w
+5802,"@@ -309,6 +309,12 @@ func (r *replacer) getSubstitution(key string) string {
+ 	case ""{dir}"":
+ 		dir, _ := path.Split(r.request.URL.Path)
+ 		return dir
++	case ""{user}"":
++		user, _ := r.request.Context().Value(RemoteUserCtxKey).(string)
++		if user == """" {
++			user = ""-""
++		}
++		return user
+ 	case ""{request}"":
+ 		dump, err := httputil.DumpRequest(r.request, false)
+ 		if err != nil {",I don't think we need an empty value here; any middleware that wants a default value for empty placeholders will pass in what that value should be.,Is it OK to just
+5803,"@@ -23,7 +23,7 @@ const viewports = require( './viewports' );
+ // This will be passed through with the `backstop` command run with docker.
+ if ( process.argv.includes( '--docker' ) ) {
+ 	const hostname = require( './detect-storybook-host' );
+-	process.argv.push( `--storybook-host=${ hostname }` );
++	process.argv.push( `--storybook-host=http://${ hostname }:9001/` );
+ }
+
+ module.exports = {",Why was this changed?,This should use `
+5804,"@@ -99,7 +99,7 @@ void KVStoreImpl::init() {
+
+ ResultCode KVStoreImpl::get(GraphSpaceID spaceId, PartitionID partId,
+                             const std::string& key,
+-                            std::string& value) {
++                            std::string* value) {
+     CHECK_AND_RETURN_ENGINE(spaceId, partId);
+     return engine->get(key, value);
+ }","Compared to using traditional enums, I suggest to use `Status` or `StatusOr`, since they are more expressive and informative. Besides, isolating the definitions of error code of individual modules from the ones of the RPC interface is a good practice, isn't it?",Can we make this `const std::string&` for consistency?
+5805,"@@ -9,11 +9,12 @@ class Acceptance
+   validate :password_if_user_exists, if: :existing_user
+   validate :unused_invitation
+
+-  def initialize(invitation:, current_user: nil, attributes: {})
++  def initialize(invitation:, current_user: Guest.new, attributes: {})
+     @current_user = current_user
+     @invitation = invitation
+-    email = (@current_user || @invitation).email
+-    @attributes = attributes.merge(email: email)
++    @attributes = attributes.merge(
++      email: @current_user.email || @invitation.email,
++    )
+   end
+
+   def save",Use the return of the conditional for variable assignment and comparison.,Why do we need to have the `current_user.email` or `@i
+5806,"@@ -17,7 +17,9 @@
+
+ from abc import ABCMeta, abstractmethod
+ import os
++from typing import Optional
+ from selenium.webdriver.common.utils import keys_to_typing
++from selenium.types import AnyKey
+
+
+ class FileDetector(metaclass=ABCMeta):","just realised... This breaks things since there is not selenium types module, is there a PR for this?",I moved `AnyKey` to `Key` so that we can use it in oth
+5807,"@@ -9,6 +9,7 @@ package actpool
+ import (
+ 	""bytes""
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""math/big""
+ 	""strings""
+ 	""testing""",move to line 23 below,This import should go at the top of the file.
+5808,"@@ -397,9 +397,7 @@ public class PasscodeManager  {
+      * @param ctx
+      */
+     public void lock(Context ctx) {
+-        locked = true;
+         showLockActivity(ctx, false);
+-        EventsObservable.get().notifyEvent(EventType.AppLocked);
+     }
+
+     /**",the first problem i found in the passcode change flow is that these two lines were happening in 'lock()' but not in 'showLockActivity' which is what the passcode change flow calls. I've just moved them to happen in that method.,"Not sure what this is doing, but if we are not notifying the event here, should we also remove the `locked` variable?"
+5809,"@@ -326,7 +326,12 @@ class BoundSolidExecutionContext(SolidExecutionContext):
+
+     @property
+     def run_config(self) -> dict:
+-        raise DagsterInvalidPropertyError(_property_msg(""run_config"", ""property""))
++        run_config = {}
++        if self._solid_config:
++            run_config[""solids""] = {self._solid_def.name: self._solid_config}
++        if self.resources:
++            run_config[""resources""] = self.resources._asdict()  # type: ignore[attr-defined]
++        return run_config
+
+     @property
+     def pipeline_def(self) -> PipelineDefinition:","Doing this adds the actual resources themselves to the dictionary. I think for now, there's no way to know what the resource config provided may be, as we don't permit resource config on `build_solid_context`, so this part can be omitted.","Could we use `self._solid_config.get(""name"", None)` here to avoid the `# type: ignore`?"
+5810,"@@ -0,0 +1,19 @@
++module Subscriber
++  class ResubscriptionsController < ApplicationController
++    def create
++      resubscription = make_resubscription
++      if resubscription.fulfill
++        flash[:notice] = t(""subscriptions.flashes.resubscribe.success"")
++      else
++        flash[:error] = t(""subscriptions.flashes.resubscribe.failure"")
++      end
++      redirect_to my_account_path
++    end
++
++    private
++
++    def make_resubscription
++      Resubscription.new(user: current_user, plan: Plan.professional)
++    end
++  end
++end",1 trailing blank lines detected.,Style/RedundantSelf: Redundant self detected.
+5811,"@@ -68,6 +68,7 @@ if (global.enableSyncTests) {
+         TESTS.UserTests = require(""./user-tests"");
+         TESTS.SessionTests = require(""./session-tests"");
+         TESTS.UUIDSyncTests= node_require(""./uuid-sync-tests"");
++        TESTS.PartitionValueTests = node_require(""./pv-tests"");
+     }
+ }
+ ","I would personally prefer a filename without an abbreviation, a newcomer to the project wouldn't be able to translate ""pv"" to ""partition-value"".","Is this file called ""tests"" or ""pv-tests""?"
+5812,"@@ -32,6 +32,10 @@ namespace MvvmCross.Core.ViewModels
+         public static void CallBundleMethod(this IMvxViewModel viewModel, MethodInfo methodInfo, IMvxBundle bundle)
+         {
+             var parameters = methodInfo.GetParameters().ToArray();
++
++            if (bundle == null && parameters.Count() > 0)
++                return;
++
+             if (parameters.Count() == 1
+                 && parameters[0].ParameterType == typeof(IMvxBundle))
+             {",This check looks odd to me. I can't quite grok it. Why is it needed now? What's changed?,Do we need to do anything special to handle `IMvxViewModel` being null?
+5813,"@@ -228,7 +228,7 @@ func (s *Server) restartJetStream() error {
+ 		MaxStore:  opts.JetStreamMaxStore,
+ 	}
+ 	s.Noticef(""Restarting JetStream"")
+-	err := s.enableJetStream(cfg)
++	err := s.EnableJetStream(&cfg)
+ 	if err != nil {
+ 		s.Warnf(""Can't start JetStream: %v"", err)
+ 		return s.DisableJetStream()",This change is needed because otherwise the path was being changed from `path/store/jetstream` to `path/store/` and files stored differently after re-enabling.,Does this mean we can no longer update `cfg` after restart?
+5814,"@@ -1237,7 +1237,11 @@ describe('Examples', function() {
+       const client = configuration.newClient(configuration.writeConcernMax(), { poolSize: 1 });
+
+       client.connect(function(err, client) {
++        let session;
+         const cleanup = e => {
++          if (session) {
++            session.endSession();
++          }
+           client.close();
+           done(e);
+         };",is this necessary? doesn't `client.close()` imply all sessions will be ended?,Could we do this in a similar way to how we set up server side session
+5815,"@@ -19,6 +19,7 @@ package cmd
+
+ import (
+ 	""fmt""
++
+ 	""net""
+ 	""path/filepath""
+ 	""time""","Extra line, it's not needed here.",Intentional blank line?
+5816,"@@ -1,8 +1,10 @@
+ # frozen_string_literal: true
+
+ require 'puppet_pal'
++require 'bolt/pal'
+
+ # Ensure tasks are enabled when rspec-puppet sets up an environment
+ # so we get task loaders.
+ Puppet[:tasks] = true
++Bolt::PAL.load_puppet
+ require 'puppetlabs_spec_helper/module_spec_helper'",Is this OK to add in the spec helper? I need to call `Bolt::PAL.load_puppet` so that I can use the new `Bolt::PAL::Issues` module when verifying that plans forbid functions.,This feels like a lot of magic. Is there a better way to do this now?
+5817,"@@ -386,6 +386,15 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+         return result;
+     }
+
++    @Override
++    public CharSeq padTo(int length, Character element) {
++        final StringBuilder sb = new StringBuilder(back);
++        for (int i = 0; i < length; i++) {
++            sb.append(element);
++        }
++        return new CharSeq(sb.toString());
++    }
++
+     public CharSeq mapChars(CharUnaryOperator mapper) {
+         Objects.requireNonNull(mapper, ""mapper is null"");
+         if (isEmpty()) {","or is it `i < length - back.length()`? `""12345"".padTo(10, 'a')` should be `12345aaaaa`","Instead of creating a new `CharSeq` every time, can we just return `t"
+5818,"@@ -162,7 +162,8 @@ def train_detector(model,
+     # register hooks
+     runner.register_training_hooks(cfg.lr_config, optimizer_config,
+                                    cfg.checkpoint_config, cfg.log_config,
+-                                   cfg.get('momentum_config', None))
++                                   cfg.get('momentum_config', None),
++                                   custom_hooks_config=cfg.get('custom_imports', None))
+     if distributed:
+         if isinstance(runner, EpochBasedRunner):
+             runner.register_hook(DistSamplerSeedHook())",custom_imports -> custom_hooks,this doesn't look right. Shouldn't these be `cfg.get('momentum_config
+5819,"@@ -34,7 +34,7 @@
+                   <% end %>
+                 </ul>
+               <% else %>
+-                <p><%= raw question[:text][0].gsub(/<tr>(\s|<td>|<\/td>|&nbsp;)*(<\/tr>|<tr>)/,"""") %></p>
++                <p><%= raw question[:text][0].gsub(/<tr>(\s|<td>|<\/td>|&nbsp;)*(<\/tr>|<tr>)/,"""") if question[:text].present? && question[:text][0].present?  %></p>
+               <% end %>
+               <br>
+             <% end %>","I don't get why are we baking new hash structures to represent phases, sections, questions. We are not only loosing the references defined in models but also we have to figure out keys and values for this newly structures.",Is this change necessary? I don't see a test for it.
+5820,"@@ -231,6 +231,10 @@ public class MMapDirectory extends FSDirectory {
+   /** Creates an IndexInput for the file with the given name. */
+   @Override
+   public IndexInput openInput(String name, IOContext context) throws IOException {
++    return openInput(name, context, this.preload);
++  }
++
++  protected IndexInput openInput(String name, IOContext context, boolean preload) throws IOException {
+     ensureOpen();
+     ensureCanRead(name);
+     Path path = directory.resolve(name);",It's somewhat confusing that the `preload` parameter shadows the instance variable; maybe rename the instance variable to `globalPreload` or `preloadDefault` or so to prevent future confusion?,Question: Why do we need this change?
+5821,"@@ -36,6 +36,7 @@ type ScheduledJob struct {
+
+ // ScheduledJobConfig holds the configuration for a scheduled job
+ type ScheduledJobConfig struct {
++	name                    string
+ 	ImageConfig             ImageWithHealthcheck `yaml:""image,flow""`
+ 	ImageOverride           `yaml:"",inline""`
+ 	TaskConfig              `yaml:"",inline""`",Are we setting these values anywhere?,Does the name need to be scoped to th
+5822,"@@ -5,8 +5,8 @@
+  */
+
+ #include <gtest/gtest.h>
+-#include <folly/Random.h>
+-#include ""common/base/MurmurHash2.h""
++#include ""base/Base.h""
++#include ""base/MurmurHash2.h""
+
+ namespace vesoft {
+ ",This has to be in front of all other includes,Please remove the extra headers
+5823,"@@ -702,8 +702,8 @@ void updateStereoBonds(RWMOL_SPTR product, const ROMol &reactant,
+       Atom *pStart = pBond->getBeginAtom();
+       Atom *pEnd = pBond->getEndAtom();
+
+-      pStart->calcImplicitValence(true);
+-      pEnd->calcImplicitValence(true);
++      pStart->calcImplicitValence(false);
++      pEnd->calcImplicitValence(false);
+
+       if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) {
+         pBond->setStereo(Bond::BondStereo::STEREONONE);",These changes make sense to me. @ricrogz : you wrote (I think ) the original version of this as part of #2553 Do you see any reason to not make the change?,shouldn't this be set to true by defa
+5824,"@@ -479,7 +479,7 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
+     }
+
+     function getRequestFile() {
+-        var path = self.location.pathname || '';
++        var path = window.self.location.pathname || '';
+
+         var index = path.lastIndexOf('/');
+         if (index !== -1) {",`window.self === window`,Shouldn't `self` be `window` here too?
+5825,"@@ -474,7 +474,7 @@ func TestSvcInitOpts_Ask(t *testing.T) {
+ 			inDockerfilePath: """",
+
+ 			setupMocks: func(m initSvcMocks) {
+-				m.mockMftReader.EXPECT().ReadWorkloadManifest(wantedSvcName).Return(nil, &workspace.ErrFileNotExists{FileName: wantedSvcName})
++				m.mockMftReader.EXPECT().ReadWorkloadManifest(wantedSvcName).Return(nil, &workspace.ErrWorkspaceNotFound{})
+ 				m.mocktopicSel.EXPECT().Topics(
+ 					gomock.Eq(svcInitPublisherPrompt),
+ 					gomock.Eq(svcInitPublisherHelpPrompt),",maybe we should keep one test case for ErrFileNotExists and update only one file for ErrWorkspaceNotFound?,why are these changes needed?
+5826,"@@ -140,12 +140,7 @@ namespace OpenTelemetry.Trace.Export
+                 this.cts.Dispose();
+                 this.cts = null;
+
+-                // if there are more items, continue until cancellation token allows
+-                while (this.currentQueueSize > 0 && !cancellationToken.IsCancellationRequested)
+-                {
+-                    await this.ExportBatchAsync(cancellationToken).ConfigureAwait(false);
+-                }
+-
++                await this.ForceFlushAsync(cancellationToken);
+                 await this.exporter.ShutdownAsync(cancellationToken);
+
+                 // there is no point in waiting for a worker task if cancellation happens",Please add `ConsigureAwait(false)` here and on `ShutdownAsync` below.,"@scalablecory, do you know if this is "
+5827,"@@ -28,8 +28,8 @@ def bad_default(var, default=unknown2):  # [undefined-variable]
+     """"""function with default arg's value set to an nonexistent name""""""
+     print(var, default)
+     print(xxxx)  # [undefined-variable]
+-    augvar += 1  # [undefined-variable]
+-    del vardel  # [undefined-variable]
++    augvar += 1  # [undefined-variable, unused-variable]
++    del vardel  # [undefined-variable, unused-variable]
+
+ LMBD = lambda x, y=doesnotexist: x+y  # [undefined-variable]
+ LMBD2 = lambda x, y: x+z  # [undefined-variable]",Isn't this a false positive? Why are we reporting `unused-variable` on a `del` operation with a `undefined-variable`.,@zjffdu I'm not sure if `del vardel` d
+5828,"@@ -97,7 +97,7 @@ func (client *ClientFake) FindProposals(providerID string) (proposals []dto_disc
+
+ // SendSessionStats heartbeats that session is still active + session upload and download amounts
+ func (client *ClientFake) SendSessionStats(sessionId session.SessionID, sessionStats dto.SessionStats, signer identity.Signer) (err error) {
+-	log.Info(mysteriumAPILogPrefix, ""Session stats sent: "", sessionId)
++	log.Info(mysteriumAPILogPrefix, ""SessionDto stats sent: "", sessionId)
+
+ 	return nil
+ }",Is it correct that `SessionDto` should be here?,"The variable name `sessionStats` could be updated to `sessionStatsDto`, but I don't think it's a big deal."
+5829,"@@ -103,6 +103,11 @@ func (c *ovsCtlClient) DumpGroups() ([]string, error) {
+ 	return groupList, nil
+ }
+
++func (c *ovsCtlClient) AddMeterEntry(meterId uint32, rate uint32) error {
++	_, err := c.RunOfctlCmd(""add-meter"", fmt.Sprintf(""meter=%d,pktps,band=type=drop,rate=%d"", meterId, rate))
++	return err
++}
++
+ func (c *ovsCtlClient) DumpPortsDesc() ([][]string, error) {
+ 	portsDescDump, err := c.RunOfctlCmd(""dump-ports-desc"")
+ 	if err != nil {","sorry I missed this earlier. We no longer use ovs-ofctl for flow programming AFAIK, why not add this support to ofnet / libOpenflow?",How does the `add-meter` command play with the `band` parameter? Would it be better to pass a `band` param
+5830,"@@ -159,7 +159,10 @@ class Form extends WidgetBase
+      */
+     protected function loadAssets()
+     {
+-        $this->addJs('js/october.form.js', 'core');
++        $this->addJs('js/october.form.js', [
++            'build' => 'core',
++            'cache'  => 'false'
++        ]);
+     }
+
+     /**",Make this consistent with the other definition please `'false'` vs `false`,Whitespace after `=>` please.
+5831,"@@ -62,8 +62,13 @@ func CleanupHandler(c <-chan os.Signal) {
+ 	for s := range c {
+ 		debug.Log(""signal %v received, cleaning up"", s)
+ 		fmt.Printf(""%sInterrupt received, cleaning up\n"", ClearLine())
+-		RunCleanupHandlers()
+-		fmt.Println(""exiting"")
+-		os.Exit(0)
++		Exit(0)
+ 	}
+ }
++
++// Exit runs the cleanup handlers and then terminates the process with the
++// given exit code.
++func Exit(code int) {
++	RunCleanupHandlers()
++	os.Exit(code)
++}",I think this is a good way to do it. :+1:,This debug statement was misleading.
+5832,"@@ -21,7 +21,7 @@ import (
+ 	""os""
+ 	""path/filepath""
+
+-	""github.com/mitchellh/go-homedir""
++	homedir ""github.com/mitchellh/go-homedir""
+ 	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/urfave/cli""
+ )",Why this is needed?,Let's remove this line.
+5833,"@@ -26,11 +26,12 @@ import (
+ )
+
+ // InitializeConnTrackDumper initializes the ConnTrackDumper interface for different OS and datapath types.
+-func InitializeConnTrackDumper(nodeConfig *config.NodeConfig, serviceCIDR *net.IPNet, ovsctlClient ovsctl.OVSCtlClient, ovsDatapathType string) ConnTrackDumper {
++func InitializeConnTrackDumper(nodeConfig *config.NodeConfig, serviceCIDR *net.IPNet, ovsDatapathType string) ConnTrackDumper {
+ 	var connTrackDumper ConnTrackDumper
+ 	if ovsDatapathType == ovsconfig.OVSDatapathSystem {
+ 		connTrackDumper = NewConnTrackSystem(nodeConfig, serviceCIDR)
+ 	} else if ovsDatapathType == ovsconfig.OVSDatapathNetdev {
++		ovsctlClient := ovsctl.NewClient(nodeConfig.OVSBridge)
+ 		connTrackDumper = NewConnTrackOvsAppCtl(nodeConfig, serviceCIDR, ovsctlClient)
+ 	}
+ 	return connTrackDumper",Can we define this directly in the function `NewConnTrackOvsAppCtl` instead of passing this as an argument?,why do we have a new `o
+5834,"@@ -54,6 +54,8 @@ func (s *stream) Write(b []byte) (int, error) {
+ var _ = Describe(""Crypto Setup TLS"", func() {
+ 	var clientConf, serverConf *tls.Config
+
++	// unparam incorrectly complains that the first argument is never used.
++	//nolint:unparam
+ 	initStreams := func() (chan chunk, *stream /* initial */, *stream /* handshake */) {
+ 		chunkChan := make(chan chunk, 100)
+ 		initialStream := newStream(chunkChan, protocol.EncryptionInitial)",False positives are annoying...,I think it's better to
+5835,"@@ -0,0 +1,15 @@
++<?php
++
++/**
++ * Copyright © Ergonode Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Multimedia\Infrastructure\Service;
++
++interface SuffixGeneratingServiceInterface
++{
++    public function generateSuffix(string $name, int $iterationIndex): string;
++}","Is the infrastructure layer an appropriate one? I don't think so tbh, more like an application, or even a domain one.",Seems this interface is
+5836,"@@ -4,12 +4,14 @@
+ using System;
+ using System.Diagnostics;
+ using System.Numerics;
++using System.Runtime.CompilerServices;
+ using System.Threading;
+
+ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Infrastructure
+ {
+     public struct MemoryPoolIterator
+     {
++        private static readonly ulong _powerOfTwoToHighByte = PowerOfTwoToHighByte();
+         private static readonly int _vectorSpan = Vector<byte>.Count;
+
+         private MemoryPoolBlock _block;",Why is this required to turn the static readonlies into jitted const? Is this a bug in the jitter?,nit: do we still need the `using`s here?
+5837,"@@ -2,11 +2,13 @@ from collections import namedtuple
+
+ import traceback
+
+-SerializableErrorInfo = namedtuple('SerializableErrorInfo', 'message stack')
++SerializableErrorInfo = namedtuple('SerializableErrorInfo', 'message stack cls_name')
+
+
+ def serializable_error_info_from_exc_info(exc_info):
+     exc_type, exc_value, exc_tb = exc_info
+     return SerializableErrorInfo(
+-        traceback.format_exception_only(exc_type, exc_value)[0], traceback.format_tb(tb=exc_tb)
++        traceback.format_exception_only(exc_type, exc_value)[0],
++        traceback.format_tb(tb=exc_tb),
++        exc_type.__name__,
+     )","feel free to make this a ""typed"" named tuple (overriding __new__) if you are feeling frisky",You don't need the extra `__name__` here
+5838,"@@ -1,6 +1,3 @@
+-import { or } from 'ramda';
+-
+-
+-const MAX_SAFE_INTEGER = or(Number.MAX_SAFE_INTEGER, (2 ** 53) - 1);
++const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (2 ** 53) - 1;
+
+ export default MAX_SAFE_INTEGER;",Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1),Why the removal of the `or`?
+5839,"@@ -187,7 +187,9 @@ func (d *detector) checkApplication(ctx context.Context, app *model.Application,
+ 	liveManifests = filterIgnoringManifests(liveManifests)
+ 	d.logger.Info(fmt.Sprintf(""application %s has %d live manifests"", app.Id, len(liveManifests)))
+
+-	result, err := provider.DiffList(liveManifests, headManifests,
++	result, err := provider.DiffList(
++		headManifests,
++		liveManifests,
+ 		diff.WithEquateEmpty(),
+ 		diff.WithIgnoreAddingMapKeys(),
+ 		diff.WithCompareNumberAndNumericString(),",The bug was caused by this order change in the last refactoring.,Is this refactoring necessary for this P
+5840,"@@ -23,6 +23,7 @@ import io
+ import json
+
+ import docker
++from docker.utils import kwargs_from_env
+
+ from molecule import util
+ from molecule.driver import basedriver",This is already imported as docker. You're safe to simply use `docker.utils.kwargs_from_env()` below.,"Unused import, can be removed"
+5841,"@@ -50,6 +50,14 @@ func (ra RunnableActions) Actions() []action.SealedEnvelope {
+ 	return ra.actions
+ }
+
++// AddAction adds actions for block which is building.
++func (ra *RunnableActions) AddAction(act action.SealedEnvelope) {
++	if ra.actions == nil {
++		ra.actions = make([]action.SealedEnvelope, 0)
++	}
++	ra.actions = append(ra.actions, act)
++}
++
+ // RunnableActionsBuilder is used to construct RunnableActions.
+ type RunnableActionsBuilder struct{ ra RunnableActions }
+ ",No need to add this fun. Using RunnableActionsBuilder#AddActions instead,what's the point of this? can
+5842,"@@ -23,6 +23,10 @@ let oldBeforeUnmount = options.unmount;
+ const RAF_TIMEOUT = 100;
+ let prevRaf;
+
++// TODO: these options hooks are also still side-effects and we
++// should minimize side-effects wherever we can, currently compat
++// imports this whole file resulting in a lot of side-effects, would
++// it be better for that reason to integrate hooks into core?
+ options._diff = (internal, vnode) => {
+ 	currentInternal = null;
+ 	if (oldBeforeDiff) oldBeforeDiff(internal, vnode);",I don't think it's possible to do this for hooks  ,Do we have a tracking issue f
+5843,"@@ -88,7 +88,7 @@ public class SleepJavaJob {
+     System.out.println(""Sec "" + sec);
+     synchronized (this) {
+       try {
+-        this.wait(sec * 1000);
++        this.wait(sec * 1000 + 1);
+       } catch (final InterruptedException e) {
+         System.out.println(""Interrupted "" + this.fail);
+       }",wait(1ms) when sec=0. wait(0ms) waits forever so that's why this is better.,Usually the convention is to
+5844,"@@ -104,8 +104,14 @@ struct listener_ssl_config_t {
+
+ struct listener_config_t {
+     int fd;
++#if defined(__linux__) && defined(SO_REUSEPORT)
++    int domain;
++    int so_reuseport;
++    H2O_VECTOR(int) reuseport_fds;
++#endif
+     struct sockaddr_storage addr;
+     socklen_t addrlen;
++
+     h2o_hostconf_t **hosts;
+     H2O_VECTOR(struct listener_ssl_config_t *) ssl;
+     int proxy_protocol;",Do we need `domain` and `so_reuseport` now that we open new sockets immediately after calling `add_listener`?,Is there a specific reason to only define this variable in the platform code? Maybe define it as a static variable in platform.h?
+5845,"@@ -34,10 +34,14 @@ public interface HttpClient {
+    * @throws IOException if an I/O error occurs.
+    */
+   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
+-
++
+   /**
+-   * Creates HttpClient instances.
+-   */
++	* Closes the connections associated with this client.
++	*
++	* @throws  IOException  if an I/O error occurs.
++	*/
++  void close() throws IOException;
++
+   interface Factory {
+
+     /**",The formatting seems different from the rest of the code,NIT: unnecessary change.
+5846,"@@ -0,0 +1,18 @@
++package paramhelper
++
++import (
++	""fmt""
++	""strings""
++)
++
++// GetRegion extracts region from a zones
++func GetRegion(zone string) (string, error) {
++	if zone == """" {
++		return """", fmt.Errorf(""zone is empty. Can't determine region"")
++	}
++	zoneStrs := strings.Split(zone, ""-"")
++	if len(zoneStrs) < 2 {
++		return """", fmt.Errorf(""%v is not a valid zone"", zone)
++	}
++	return strings.Join(zoneStrs[:len(zoneStrs)-1], ""-""), nil
++}","What about calling this package ""parameters""? utils\parameters are utils related to parameters.",How about: `GetRegion extracts region from a zone`?
+5847,"@@ -20,7 +20,7 @@ describe Topic do
+     end
+
+     it 'generates a stripped, url encoded slug based on name' do
+-      @topic.slug.should == 'test+driven+development'
++      expect(@topic.slug).to eq 'test+driven+development'
+     end
+   end
+ ",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I think we need to revert this change since it doesn't seem related to this PR.
+5848,"@@ -52,10 +52,10 @@ public class PublicKeySubCommandTest extends CommandTestAbstract {
+           + System.lineSeparator()
+           + ""This command outputs the node public key. Default output is standard output.""
+           + System.lineSeparator()
+-          + ""      --to=<FILE>   File to write public key to instead of standard output""
+-          + System.lineSeparator()
+           + ""  -h, --help        Show this help message and exit.""
+           + System.lineSeparator()
++          + ""      --to=<FILE>   File to write public key to instead of standard output""
++          + System.lineSeparator()
+           + ""  -V, --version     Print version information and exit.""
+           + System.lineSeparator();
+ ",what is the actual difference here?,Why do you change the order of these arguments? Shouldn't the expected order be kept?
+5849,"@@ -96,6 +96,12 @@ public final class DefaultOAuth2AuthorizationRequestResolver implements OAuth2Au
+ 		if (registrationId == null) {
+ 			return null;
+ 		}
++		String[] params = new String[0];
++		if (registrationId.contains(""?"")) {
++			String[] explodedURI = registrationId.split(""\\?"");
++			registrationId = registrationId.split(""\\?"")[0];
++			params = explodedURI[1].split(""&"");
++		}
+
+ 		ClientRegistration clientRegistration = this.clientRegistrationRepository.findByRegistrationId(registrationId);
+ 		if (clientRegistration == null) {",Parsing URLs is hard. Any fixes should avoid manually parsing the URL.,Do we need to make sure `registrationId` is not empty or contains `?`?
+5850,"@@ -22,7 +22,7 @@ module RSpec
+         end
+
+         def example_group_finished(_notification)
+-          @group_level -= 1
++          @group_level =  @group_level > 0 ? @group_level - 1 : @group_level
+         end
+
+         def example_passed(passed)","This is a private api, it doesn't need to return anything so `@group_level -= 1 if @group_level > 0` is preferred.",Unnecessary spacing detected.
+5851,"@@ -432,14 +432,14 @@ NativeHashedStorageHandler::NativeHashedStorageHandler(
+   if (!m_process)
+     return;
+
+-  auto key_stride = key_type.GetByteStride();
++  auto key_stride = key_type.GetByteStride(m_process);
+   if (key_stride) {
+     m_key_stride = *key_stride;
+     m_key_stride_padded = *key_stride;
+   }
+
+   if (value_type) {
+-    auto value_type_stride = value_type.GetByteStride();
++    auto value_type_stride = value_type.GetByteStride(m_process);
+     m_value_stride = value_type_stride ? *value_type_stride : 0;
+     if (SwiftASTContext *swift_ast =
+             llvm::dyn_cast_or_null<SwiftASTContext>(key_type.GetTypeSystem())) {",".GetValueOr(0) ... but really, shouldn't m_value_strife also be optional?",Is this process supposed to be the first one? Is it supposed to be the first one?
+5852,"@@ -256,7 +256,7 @@ module.exports = class Tus extends Plugin {
+         }
+       }
+
+-      /** @type {{ [name: string]: string }} */
++      /** @type {Record<string, string>} */
+       const meta = {}
+       const metaFields = Array.isArray(opts.metaFields)
+         ? opts.metaFields",Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing,Why is this change necessary?
+5853,"@@ -17,11 +17,11 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+         private static readonly WaitCallback _completePending = CompletePending;
+         protected readonly FrameContext _context;
+
+-        object _sync = new Object();
++        private object _sync = new Object();
+
+-        ArraySegment<byte> _buffer;
+-        Queue<ReadOperation> _reads = new Queue<ReadOperation>();
+-        bool _send100Continue = true;
++        private ArraySegment<byte> _buffer;
++        private Queue<ReadOperation> _reads = new Queue<ReadOperation>();
++        private bool _send100Continue = true;
+
+         public MessageBodyExchanger(FrameContext context)
+         {",Should be readonly,I know this isn't your change
+5854,"@@ -14,7 +14,7 @@ import unittest
+ from rdkit import RDConfig
+ from rdkit import Chem
+ from rdkit.Chem import FragmentCatalog, BuildFragmentCatalog
+-from rdkit.six.moves import cPickle
++from rdkit.six.moves import cPickle  # @UnresolvedImport
+
+
+ def feq(n1, n2, tol=1e-4):","I'm not going to stop accepting the PR, but I really hate these artifacts getting dropped in the Python code just to stop things like coverage checkers and linters from complaining.",why did you need this?
+5855,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright 2016 The Kythe Authors. All rights reserved.
++ * Copyright 2020 The Kythe Authors. All rights reserved.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.","FYI modifying an existing file generally doesn't invalidate the copyright date. The date here is when the copy right _begins_, so moving it later is arguably misleading-it still applies. Not a big deal, just something I've seen a few times in passing.",Please don't change the copyr
+5856,"@@ -106,7 +106,7 @@ public class BaseServer<T extends BaseServer> implements Server<T> {
+       FilterHolder
+           filterHolder = servletContextHandler.addFilter(CrossOriginFilter.class, ""/*"", EnumSet
+           .of(DispatcherType.REQUEST));
+-      filterHolder.setInitParameter(""allowedOrigins"", ""*"");
++      filterHolder.setInitParameter(""allowedMethods"", ""GET,POST,PUT,DELETE,HEAD"");
+
+       // Warning user
+       LOG.warning(""You have enabled CORS requests from any host. ""","Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all.",I don't think it's a good idea to hardcode a method that accepts a list of allowedMethods. I would suggest to use a constant.
+5857,"@@ -449,6 +449,10 @@ public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, Supp
+   Database convertToDatabase(Namespace namespace, Map<String, String> meta) {
+     String warehouseLocation = conf.get(""hive.metastore.warehouse.dir"");
+
++    Preconditions.checkNotNull(
++            warehouseLocation,
++            ""Warehouse location is not set: hive.metastore.warehouse.dir=null"");
++
+     if (!isValidateNamespace(namespace)) {
+       throw new NoSuchNamespaceException(""Namespace does not exist: %s"", namespace);
+     }",Style: indentation should be 4 spaces (2 indents) from the start of `Preconditions`.,We should also validate that the property is not set.
+5858,"@@ -587,8 +587,15 @@ class AdminController extends Controller
+         foreach ($entityProperties as $name => $metadata) {
+             $formFieldOptions = $metadata['type_options'];
+
+-            if ('association' === $metadata['fieldType'] && in_array($metadata['associationType'], array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY))) {
+-                continue;
++            if ('association' === $metadata['type']) {
++                // *-to-many associations are not supported yet
++                $toManyAssociations = array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY);
++                if (in_array($metadata['associationType'], $toManyAssociations)) {
++                    continue;
++                }
++
++                // supported associations are displayed using advanced JavaScript widgets
++                $formFieldOptions['attr']['data-use-js-widget'] = 'true';
+             }
+
+             if ('collection' === $metadata['fieldType']) {","I don't know why I suggested a html attribute at first (my bad), or maybe you think it makes sense. Otherwise, what about a simple class ?",I would move this block outside the `foreach` loop and use `$metadata['fieldType']` instead of the `type` value.
+5859,"@@ -122,6 +122,9 @@ module DMPRoadmap
+       config.branding = config_for(:branding).deep_symbolize_keys
+     end
+
++    # org abbreviation for the root google analytics tracker that gets planted on every page
++    config.tracker_root = ""UoE""
++
+     # The default visibility setting for new plans
+     #   organisationally_visible  - Any member of the user's org can view, export and duplicate the plan
+     #   publicly_visibile         - (NOT advisable because plans will show up in Public DMPs page by default)",Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+5860,"@@ -72,12 +72,13 @@ namespace NLog.Config
+                 }
+                 catch (Exception exception)
+                 {
++                    InternalLogger.Error(exception, ""Failed to add type '{0}'."", t.FullName);
++
+                     if (exception.MustBeRethrown())
+                     {
+                         throw;
+                     }
+-
+-                    InternalLogger.Error(""Failed to add type '"" + t.FullName + ""': {0}"", exception);
++
+                 }
+             }
+         }",Must this not change to `MustBeRethrownImmediately`?,We're losing information about the type that failed to add.
+5861,"@@ -30,11 +30,6 @@ import (
+
+ var (
+ 	pluginName = ""antrea-octant-plugin""
+-	client     *clientset.Clientset
+-	graph      = """"
+-	lastTf     = opsv1alpha1.Traceflow{
+-		ObjectMeta: v1.ObjectMeta{Name: """"},
+-	}
+ )
+
+ const (",Can it be pointer?,Do we still need these? Can we just delete them?
+5862,"@@ -303,11 +303,11 @@ export const refreshAuthentication = async () => {
+ 		} );
+
+ 		// We should really be using state management. This is terrible.
+-		window.googlesitekit.setup = window.googlesitekit.setup || {};
+-		window.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
+-		window.googlesitekit.setup.requiredScopes = response.requiredScopes;
+-		window.googlesitekit.setup.grantedScopes = response.grantedScopes;
+-		window.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;
++		global.googlesitekit.setup = global.googlesitekit.setup || {};
++		global.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
++		global.googlesitekit.setup.requiredScopes = response.requiredScopes;
++		global.googlesitekit.setup.grantedScopes = response.grantedScopes;
++		global.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;
+ 	} catch ( e ) { // eslint-disable-line no-empty
+ 	}
+ };",Not related to this issue but this condition seems weak.,I wonder if `global.googlesitekit.setup = global.googlesite
+5863,"@@ -58,7 +58,12 @@ trait MarcReaderTrait
+     public function getMarcRecord()
+     {
+         if (null === $this->lazyMarcRecord) {
+-            $marc = trim($this->fields['fullrecord']);
++            // Get preferred MARC field from config, if it is set and is existing:
++            $marcField = (isset($this->mainConfig->Record->preferredMarcField)
++                    && array_key_exists($this->mainConfig->Record->preferredMarcField, $this->fields))
++                ? $this->mainConfig->Record->preferredMarcField : 'fullrecord';
++
++            $marc = trim($this->fields[$marcField]);
+
+             // check if we are dealing with MARCXML
+             if (substr($marc, 0, 1) == '<') {",I think this might be a little more readable in two lines as: <pre> $preferredMarcField = $this->mainConfig->Record->preferredMarcField ?? 'fullrecord'; $marc = trim($this->fields[$preferredMarcField] ?? $this->fields['fullrecord']); </pre>,you can use `!empty()` instead
+5864,"@@ -21,8 +21,9 @@ from . import packer
+ from . import compat
+ from .compat import range_func
+ from .compat import memoryview_type
++from .compat import import_numpy, NumpyRequiredForThisFeature
+
+-
++np = import_numpy()
+ ## @file
+ ## @addtogroup flatbuffers_python_api
+ ## @{",does this still allow this file to be used with Python installations that don't have numpy?,"In the future, please don't make unnecessary changes like this. It makes the diff harder to read."
+5865,"@@ -96,7 +96,7 @@ class BazelBuildFileView {
+     String goImport = """";
+     if (isCloud) {
+       goImport = ""cloud.google.com/go/"";
+-      goPkg = goPkg.replaceFirst(""v(.+);"", ""apiv$1;"");
++      goPkg = goPkg.replaceFirst(""\\/v([a-z1-9]+);"", ""\\/apiv$1;"");
+     } else {
+       goImport = ""google.golang.org/"";
+       String pkgName = goPkg.split("";"")[1];","what about 0? Version probably can' start with 0, but v10 is theoretically possible.","I don't think this is correct. If the `apiv$1` is in the package path, that doesn't mean it shoul"
+5866,"@@ -52,5 +52,17 @@ namespace Microsoft.VisualStudio.TestPlatform.Utilities.Helpers
+         {
+             return new FileInfo(path).Attributes;
+         }
++
++        /// <inheritdoc/>
++        public bool IsRootedPath(string path)
++        {
++            return Path.IsPathRooted(path);
++        }
++
++        /// <inheritdoc/>
++        public string CombinePath(string source)
++        {
++            return Path.Combine(Directory.GetCurrentDirectory(), source);
++        }
+     }
+ }","Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily. `Path.IsRootedPath` doesn't access the file system. It is string comparison I believe.",What is the difference between this and `IsRootedPath`?
+5867,"@@ -276,7 +276,7 @@ spec:
+       iqn: iqn.2016-09.com.openebs.cstor:{{ .Volume.owner }}
+       targetPortal: {{ .TaskResult.cvolcreateputsvc.clusterIP }}:3260
+       targetPort: 3260
+-      status: """"
++      status: ""Init""
+       replicationFactor: {{ $replicaCount }}
+       consistencyFactor: {{ div $replicaCount 2 | floor | add1 }}
+ ---",Do we need to use quote? Why not `status: Init`,What's the reasoning behind this change?
+5868,"@@ -20,10 +20,6 @@ from pylint import checkers, interfaces
+ from pylint.checkers import utils
+
+
+-def _is_constant_empty_str(node):
+-    return isinstance(node, nodes.Const) and node.value == """"
+-
+-
+ class CompareToEmptyStringChecker(checkers.BaseChecker):
+     """"""Checks for comparisons to empty string.
+     Most of the times you should use the fact that empty strings are false.","Nice catch ! I don't think I would have caught that, did you search the whole code base for pre-existing functions ?",Removing this helper function because it isn't used anywhere else and `_is_constant_empty_str` is used in other places.
+5869,"@@ -1052,6 +1052,19 @@ func TestClusterDeploymentReconcile(t *testing.T) {
+ 				}
+ 			},
+ 		},
++		{
++			name: ""Add cluster region label"",
++			existing: []runtime.Object{
++				testClusterDeploymentWithoutRegionLabel(),
++			},
++			validate: func(c client.Client, t *testing.T) {
++				cd := getCD(c)
++				if assert.NotNil(t, cd, ""missing clusterdeployment"") {
++					//					assert.Equal(t, getClusterRegion(cd), cd.Labels[hivev1.HiveClusterRegionLabel], ""incorrect cluster region label"")
++					assert.Equal(t, getClusterRegion(cd), ""us-east-1"", ""incorrect cluster region label"")
++				}
++			},
++		},
+ 		{
+ 			name: ""Ensure cluster metadata set from provision"",
+ 			existing: []runtime.Object{",Remove this line.,Why is this test case affected by it?
+5870,"@@ -964,12 +964,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [Fact]
+         public async Task ContentLength_Received_SingleDataFrameUnderSize_Reset()
+         {
+-            // I hate doing this, but it avoids exceptions from MemoryPool.Dipose() in debug mode. The problem is since
+-            // the stream's ProcessRequestsAsync loop is never awaited by the connection, it's not really possible to
+-            // observe when all the blocks are returned. This can be removed after we implement graceful shutdown.
+-            Dispose();
+-            InitializeConnectionFields(new DiagnosticMemoryPool(KestrelMemoryPool.CreateSlabMemoryPool(), allowLateReturn: true));
+-
+             var headers = new[]
+             {
+                 new KeyValuePair<string, string>(HeaderNames.Method, ""POST""),","This is no longer called in any of our unit tests, right?",Do we have a test that ensures that ProcessRequestsAsync calls are always executed in debug mode?
+5871,"@@ -67,7 +67,7 @@ type rule struct {
+ 	// Priority of the NetworkPolicy to which this rule belong. nil for K8s NetworkPolicy.
+ 	PolicyPriority *float64
+ 	// Priority of the tier that the NetworkPolicy belongs to. nil for K8s NetworkPolicy.
+-	TierPriority *v1beta1.TierPriority
++	TierPriority *uint32
+ 	// Targets of this rule.
+ 	AppliedToGroups []string
+ 	// The parent Policy ID. Used to identify rules belong to a specified","I think typically K8s APIs will use `int32` and not `uint32`. I think we should keep it consistent with the rule `Priority` above. I believe that the rationale for using `int32` in general is: * some programming languages don't have native support for unsigned integers * it's easier to catch sign errors with signed integers, depending on the programming language (it it's negative, it's clearly an error but if it's a very large number, it could be normal or it could be a negative number overflow)",This is a breaking change and needs to be added to the release note.
+5872,"@@ -0,0 +1,7 @@
++class AddStartAndEndDatesToPlans < ActiveRecord::Migration
++  def change
++    add_column :plans, :grant_id, :integer, index: true
++    add_column :plans, :start_date, :datetime
++    add_column :plans, :end_date, :datetime
++  end
++end","If you end up changing grant to an association, this may need to change to a reference to enforce the foreign_key `add_reference :plans, :grant`",Why do we need an index here?
+5873,"@@ -74,7 +74,7 @@ class DashboardModulesAlerts extends Component {
+ 						title={ notification.title || '' }
+ 						description={ notification.description || '' }
+ 						blockData={ notification.blockData || [] }
+-						winImage={ notification.winImage ? `${ global._googlesitekitLegacyData.admin.assetsRoot }images/${ notification.winImage }` : '' }
++						WinImageSVG={ notification.WinImageSVG }
+ 						format={ notification.format || 'small' }
+ 						learnMoreURL={ notification.learnMoreURL || '' }
+ 						learnMoreDescription={ notification.learnMoreDescription || '' }",This won't work because `notification` comes from an API response here. I think this would be the same as the change to `Alert` where it would get `SmallSunSVG`.,I think we should keep the ol
+5874,"@@ -120,6 +120,10 @@ func TestEnvironmentConfig(t *testing.T) {
+ 	additionalLocalRoutesJSON := `[""1.2.3.4/22"",""5.6.7.8/32""]`
+ 	os.Setenv(""ECS_AWSVPC_ADDITIONAL_LOCAL_ROUTES"", additionalLocalRoutesJSON)
+ 	defer os.Unsetenv(""ECS_AWSVPC_ADDITIONAL_LOCAL_ROUTES"")
++	os.Setenv(""ECS_ENABLE_CONTAINER_METADATA"", ""true"")
++	os.Setenv(""ECS_HOST_DATA_DIR"", ""/etc/ecs/"")
++	defer os.Unsetenv(""ECS_ENABLE_CONTAINER_METADATA"")
++	defer os.Unsetenv(""ECS_HOST_DATA_DIR"")
+
+ 	conf, err := environmentConfig()
+ 	assert.NoError(t, err)",This is not checked below?,Can we set a default value fo
+5875,"@@ -218,6 +218,19 @@ func (c *CloudFormation) TemplateBodyFromChangeSet(changeSetID, stackName string
+ 	return aws.StringValue(out.TemplateBody), nil
+ }
+
++// Outputs returns the outputs of a stack description.
++func (c *CloudFormation) Outputs(stack *Stack) (map[string]string, error) {
++	stackDescription, err := c.Describe(stack.Name)
++	if err != nil {
++		return nil, fmt.Errorf(""retrieve outputs of stack description: %w"", err)
++	}
++	outputs := make(map[string]string)
++	for _, output := range stackDescription.Outputs {
++		outputs[*output.OutputKey] = *output.OutputValue
++	}
++	return outputs, nil
++}
++
+ // Events returns the list of stack events in **chronological** order.
+ func (c *CloudFormation) Events(stackName string) ([]StackEvent, error) {
+ 	return c.events(stackName, func(in *cloudformation.StackEvent) bool { return true })","Will this ever return a ""Stack does not exist"" error? Should we handle it silently here rather than making higher level packages do error checking?",Nit: `Outputs` is a bit gener
+5876,"@@ -1,11 +1,11 @@
+-from .data_transfer import copy_file, get_bytes, delete_url, list_url
+-from .packages import Package
++from .backends import get_package_registry
++from .data_transfer import copy_file
+ from .search_util import search_api
+ from .util import (QuiltConfig, QuiltException, CONFIG_PATH,
+                    CONFIG_TEMPLATE, configure_from_default, config_exists,
+-                   configure_from_url, fix_url, get_package_registry,
++                   configure_from_url, fix_url,
+                    load_config, PhysicalKey, read_yaml, validate_package_name,
+-                   write_yaml, get_from_config)
++                   write_yaml)
+ from .telemetry import ApiTelemetry
+
+ ","minor: at this scale, one import per line reads better",Why is this being removed?
+5877,"@@ -183,7 +183,7 @@ ActiveRecord::Schema.define(version: 20180508151824) do
+     t.string   ""logo_name""
+     t.string   ""contact_email""
+     t.integer  ""org_type"",               default: 0,              null: false
+-    t.text     ""links"",                  default: ""{\""org\"":[]}""
++    t.text     ""links""
+     t.string   ""contact_name""
+     t.boolean  ""feedback_enabled"",       default: false
+     t.string   ""feedback_email_subject""",Should remove the default templates as well.,This was a missing migrati
+5878,"@@ -18,14 +18,14 @@ const stream = require('webpack-stream');
+ const inject = require('gulp-inject');
+ const postcss = require('gulp-postcss');
+ const sass = require('gulp-sass');
+-
+-sass.compiler = require('node-sass')
+
++sass.compiler = require('node-sass');
+
++var config;
+ if (mode.production()) {
+-    var config = require('./webpack.prod.js');
++    config = require('./webpack.prod.js');
+ } else {
+-    var config = require('./webpack.dev.js');
++    config = require('./webpack.dev.js');
+ }
+
+ function serve() {",Why not `let`?,Why are we doing this?
+5879,"@@ -49,6 +49,8 @@ public class ZipkinServer {
+     new SpringApplicationBuilder(ZipkinServer.class)
+       .banner(new ZipkinBanner())
+       .initializers(new ZipkinModuleImporter(), new ZipkinActuatorImporter())
++      // Avoids potentially expensive ns lookup and inaccurate startup timing
++      .logStartupInfo(false)
+       .properties(
+         EnableAutoConfiguration.ENABLED_OVERRIDE_PROPERTY + ""=false"",
+         ""spring.config.name=zipkin-server"").run(args);",ns -> DNS My first reading was this is referring to System.nanoTime and thought hrm?,I'm wondering if it's bett
+5880,"@@ -55,6 +55,7 @@ class ScheduleInstigatorData(
+             # `start_date` on partition-based schedules, which is used to define
+             # the range of partitions)
+             check.opt_float_param(start_timestamp, ""start_timestamp""),
++            # this is a vestigial parameter that is not used and will be removed in the future
+             check.opt_str_param(scheduler, ""scheduler""),
+         )
+ ",is there a reason not to remove the param now? I think the serdes will still work?,typo: vestigial -> explicit
+5881,"@@ -39,6 +39,8 @@ class TestBasic(unittest.TestCase):
+         self.assertEqual(bst.current_iteration(), 20)
+         self.assertEqual(bst.num_trees(), 20)
+         self.assertEqual(bst.num_model_per_iteration(), 1)
++        self.assertAlmostEqual(bst.upper_bound(), 3.32, places=2)
++        self.assertAlmostEqual(bst.lower_bound(), -3.13, places=2)
+
+         bst.save_model(""model.txt"")
+         pred_from_matr = bst.predict(X_test)",`places=2` seems to be very poor comparison. Do you have any thoughts why is it fail with more strict checks?,I'm surprised that these ar
+5882,"@@ -213,6 +213,7 @@ public class ProjectManager {
+       fetchedProject = this.projectsByName.get(name);
+     } else {
+       try {
++        logger.info(""Project "" + name + "" doesn't exist in cache, fetching from DB now."");
+         fetchedProject = this.projectLoader.fetchProjectByName(name);
+       } catch (final ProjectManagerException e) {
+         logger.error(""Could not load project from store."", e);","should we make level debug? Also just FYI, with debug level, we can add more detailed logging for better debuggability without concerning overwhelming logging message",Perhaps it would make sense
+5883,"@@ -20,14 +20,16 @@
+ # ----------------------------------------------------------------------
+
+ """"""
+-## @file
+-stats.py defines functions and data structures related to statistical analysis.
++Module of statistical data structures and functions used in learning algorithms
++and for analysis of HTM network inputs and outputs.
+ """"""
+
+ import random
+
+ import numpy
+
++from nupic.bindings.math import GetNTAReal, SparseMatrix
++
+
+ dtype = GetNTAReal()
+ ",I needed to add this import for Sphinx to inspect C++ runtime objects properly. This should be the only code change in this PR.,why is this file changed?
+5884,"@@ -1,6 +1,8 @@
+ import colander
+
+ from cliquet import resource
++from cliquet.events import ResourceChanged, ACTIONS
++from pyramid.events import subscriber
+
+ from kinto.views import NameGenerator
+ ","Changes in this file aren't related to the PR, are they? You took the opportunity to change the group deletion to using the subscriber too?",It doesn't look like this is used anymore.
+5885,"@@ -150,6 +150,19 @@ public class MetricsModes {
+     }
+   }
+
++  /**
++   * Auto promote sorted columns to truncate(16) if default is set at Counts or None.
++   * @param defaultMode default mode
++   * @return mode to use
++   */
++  public static MetricsMode promoteSortedColumnDefault(MetricsMode defaultMode) {
++    if (defaultMode == None.get() || defaultMode == Counts.get()) {
++      return Truncate.withLength(16);
++    } else {
++      return defaultMode;
++    }
++  }
++
+   // we cannot serialize/deserialize MetricsMode directly as it breaks reference equality used in metrics utils
+   private abstract static class ProxySerializableMetricsMode implements MetricsMode {
+     Object writeReplace() throws ObjectStreamException {",I'd probably move this into `MetricsConfig` as a private method. Seems like we only use it there.,nit: return defaultMode == None.get() ? Tr
+5886,"@@ -93,7 +93,7 @@ class Lint(base.Base):
+     ),
+ )
+ def lint(ctx, scenario_name):  # pragma: no cover
+-    """""" Lint the role. """"""
++    """""" Lint the role (dependency, lint). """"""
+     args = ctx.obj.get('args')
+     subcommand = base._get_subcommand(__name__)
+     command_args = {'subcommand': subcommand}",Not clear here what you mean with this list,"Not sure what the role is, but if it's the"
+5887,"@@ -190,6 +190,7 @@ public class IcebergDecoder<D> extends MessageDecoder.BaseDecoder<D> {
+    * @return true if the buffer is complete, false otherwise (stream ended)
+    * @throws IOException if there is an error while reading
+    */
++  @SuppressWarnings(""checkstyle:InnerAssignment"")
+   private boolean readFully(InputStream stream, byte[] bytes)
+       throws IOException {
+     int pos = 0;","Curious, is there a way we can get around this without suppressing?",I don't see why this annotation is here.
+5888,"@@ -131,6 +131,7 @@ func (manager *Manager) Create(consumerID identity.Identity, issuerID identity.I
+ 	sessionInstance.ConsumerID = consumerID
+ 	sessionInstance.done = make(chan struct{})
+ 	sessionInstance.Config = config
++	sessionInstance.ProposalID = proposalID
+ 	sessionInstance.CreatedAt = time.Now().UTC()
+
+ 	balanceTracker, err := manager.balanceTrackerFactory(consumerID, identity.FromAddress(manager.currentProposal.ProviderID), issuerID)","I don't think we this field in session, it's a serial number for proposal but not unique index itself",Do we need this?
+5889,"@@ -42,6 +42,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+             }
+         }
+
++        [Benchmark(Baseline = true, OperationsPerInvoke = RequestParsingData.InnerLoopCount)]
++        public void PlaintextAbsoluteUri()
++        {
++            for (var i = 0; i < RequestParsingData.InnerLoopCount; i++)
++            {
++                InsertData(RequestParsingData.PlaintextAbsoluteUriRequest);
++                ParseData();
++            }
++        }
++
+         [Benchmark(OperationsPerInvoke = RequestParsingData.InnerLoopCount * RequestParsingData.Pipelining)]
+         public void PipelinedPlaintextTechEmpower()
+         {",Can't have two benchmarks with `Baseline = true`,These two benchm
+5890,"@@ -0,0 +1,19 @@
++
++import { wpApiFetch } from './wp-api-fetch';
++
++import { testClientConfig } from './test-client-config';
++
++/**
++ *
++ * @param {*} config
++ */
++export async function setClientConfig( config = testClientConfig ) {
++	return await wpApiFetch( {
++		path: 'google-site-kit/v1/e2e/auth/client-config',
++		method: 'post',
++		data: {
++			clientID: config.web.client_id,
++			clientSecret: config.web.client_secret,
++		},
++	} );
++}",Same here: Empty line before and no `Internal dependencies` docblock (mandatory anyway once #217 lands).,"Just curious, wh"
+5891,"@@ -59,7 +59,7 @@ func newAddCommand(root *command) *cobra.Command {
+
+ 	cmd.Flags().StringVar(&c.repoID, ""repo-id"", c.repoID, ""The repository ID. One the registered repositories in the piped configuration."")
+ 	cmd.Flags().StringVar(&c.appDir, ""app-dir"", c.appDir, ""The relative path from the root of repository to the application directory."")
+-	cmd.Flags().StringVar(&c.configFileName, ""config-file-name"", c.configFileName, ""The configuration file name. Default is .pipe.yaml"")
++	cmd.Flags().StringVar(&c.configFileName, ""config-file-name"", c.configFileName, ""The configuration file name"")
+ 	cmd.Flags().StringVar(&c.description, ""description"", c.description, ""The description of the application."")
+
+ 	cmd.MarkFlagRequired(""app-name"")","sorry, the default value for this field is no longer allowed?",If we're going t
+5892,"@@ -308,10 +308,10 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+         [Fact]
+         public void UnauthorizedAccessExceptionCreatingSarifLog()
+         {
+-            string path = Environment.GetFolderPath(Environment.SpecialFolder.Windows);
++            string path = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
+             path = Path.Combine(path, Guid.NewGuid().ToString());
+
+-            try
++            using (var stream = File.Create(path, 1, FileOptions.DeleteOnClose))
+             {
+                 // attempt to persist to unauthorized location will raise exception
+                 var options = new TestAnalyzeOptions()",Why does this work? I'd've expected that an admin could create a file anywhere.,@aparajit-pratap should this be `Environment.SpecialFolder.ApplicationData` instead?
+5893,"@@ -53,7 +53,7 @@ module Travis
+
+         def script
+           if config[:solution]
+-            sh.cmd ""xbuild #{config[:solution]}"", timing: true if config[:solution]
++            sh.cmd ""xbuild /p:Configuration=#{config[:configuration] || 'Release'} /p:Platform=\""#{config[:platform] || 'x64'}\"" #{config[:solution]}"", timing: true if config[:solution]
+           else
+             sh.echo 'No solution or script defined, exiting', ansi: :red
+             sh.cmd 'false', echo: false, timing: false",falling back to `x64` seems like a really bad idea given that the VS templates default to x86 these days.,I don't think we should be changing this here. We should only be building if we have
+5894,"@@ -356,7 +356,7 @@ class TestBokehPlotInstantiation(ComparisonTestCase):
+     def tearDown(self):
+         Store.current_backend = self.previous_backend
+         Callback._comm_type = comms.JupyterCommJS
+-        mpl_renderer.comms['default'] = self.default_comm
++        bokeh_renderer.comms['default'] = self.default_comm
+         Callback._callbacks = {}
+
+     def test_overlay_legend(self):",Bit surprised by this. I would have thought either you want to set it for both mpl and bokeh...or alternatively it was only ever meant for bokeh and was always wrong?,"Not a huge deal, but do we need to set `self.default_comm` here, or can we just use "
+5895,"@@ -490,6 +490,8 @@ given file (report RP0402 must not be disabled)'}
+                 importedname = node.modname
+             else:
+                 importedname = node.names[0][0].split('.')[0]
++        if node.as_string().startswith('from .'):
++            importedname = '.' + importedname
+         self._imports_stack.append((node, importedname))
+
+     @staticmethod","Check modname instead, but only if it's a ImportFrom.",What happens if you import a `from m import x` package into a `from m` package?
+5896,"@@ -92,6 +92,13 @@ public class TableProperties {
+   public static final String METADATA_COMPRESSION = ""write.metadata.compression-codec"";
+   public static final String METADATA_COMPRESSION_DEFAULT = ""none"";
+
++  public static final String PREVIOUS_METADATA_LOG_MAX_COUNT = ""write.metadata.previous-log-max-count"";
++  public static final int PREVIOUS_METADATA_LOG_MAX_COUNT_DEFAULT = 100;
++
++  // This enables to delete the oldest metadata file after commit.
++  public static final String METADATA_DELETE_AFTER_COMMIT_ENABLED = ""write.metadata.delete-after-commit.enabled"";
++  public static final boolean METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT = false;
++
+   public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics.column."";
+   public static final String DEFAULT_WRITE_METRICS_MODE = ""write.metadata.metrics.default"";
+   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = ""truncate(16)"";",How about `write.metadata.previous-versions-max`? No need to refer to these as a log.,"Can we rename this to something more meaningful, like `write.metadata.rollback-after-commit.enabled`?"
+5897,"@@ -36,6 +36,7 @@ RSpec.configure do |config|
+   end
+
+   config.filter_run_excluding appveyor_agents: true unless ENV['APPVEYOR_AGENTS']
++  config.filter_run_excluding windows: true unless ENV['BOLT_WINDOWS']
+
+   # rspec-mocks config
+   config.mock_with :rspec do |mocks|","We generally do this via tags in the Rakefile, not separate environment variables.",this is not needed since we already default to `true` in the base config
+5898,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,Does this need to be added to the dashboard?
+5899,"@@ -369,7 +369,13 @@ class CLAModel(Model):
+     results.inferences = {}
+     self._input = inputRecord
+
+-    # -------------------------------------------------------------------------
++    # Check if the input includes the predicted field.
++    if not self._predictedFieldName in self._input:
++      raise ValueError(""Expected predicted field '%s' in input row, ""
++                       ""but was not found! Raw input is: %s""
++                       % (self._predictedFieldName, self._input))
++
++
+     # Turn learning on or off?
+     if '_learning' in inputRecord:
+       if inputRecord['_learning']:",`if X not in Y:`,"There is no need to have this in here, you can just do: if not self._predictedFieldName: return False"
+5900,"@@ -79,7 +79,7 @@ public class TestHiveShell {
+
+   public void start() {
+     // Create a copy of the HiveConf for the metastore
+-    metastore.start(new HiveConf(hs2Conf));
++    metastore.start(new HiveConf(hs2Conf), 10);
+     hs2Conf.setVar(HiveConf.ConfVars.METASTOREURIS, metastore.hiveConf().getVar(HiveConf.ConfVars.METASTOREURIS));
+     hs2Conf.setVar(HiveConf.ConfVars.METASTOREWAREHOUSE,
+         metastore.hiveConf().getVar(HiveConf.ConfVars.METASTOREWAREHOUSE));","Do we know why the pool is exhausted? In the past, we had a few leaks in the Spark catalog code which led to this. It can be also a valid use case too if we simply need a larger pool.",Should we reduce this to 2 or is that intentional?
+5901,"@@ -228,6 +228,11 @@ module Bolt
+       # Set console log to debug if in debug mode
+       if options[:debug]
+         overrides['log'] = { 'console' => { 'level' => :debug } }
++      elsif options[:verbose]
++        configured_level = overrides.dig('log', 'console', 'level')
++        if configured_level.nil? || Bolt::Logger.lower_level?(:notice, configured_level)
++          overrides['log'] = { 'console' => { 'level' => :notice } }
++        end
+       end
+
+       if options[:puppetfile_path]","Logging in Bolt still seems to be a little messy. I think this is more correct than what I had before, but made sure I wouldn't overwrite an existing level. And if console logging gets more options, both debug and verbose need to be fixed here.",I'm not sure if this is the right way to check if
+5902,"@@ -7,6 +7,13 @@ std::shared_ptr<request_type> nano::work_peer_request::get_prepared_json_request
+ 	auto request (std::make_shared<boost::beast::http::request<boost::beast::http::string_body>> ());
+ 	request->method (boost::beast::http::verb::post);
+ 	request->set (boost::beast::http::field::content_type, ""application/json"");
++	auto address_string (address.to_string ());
++	auto pos (address_string.find (""::ffff:""));
++	if (pos != std::string::npos)
++	{
++		address_string.replace (pos, 7, """");
++	}
++	request->set (boost::beast::http::field::host, address_string);
+ 	request->target (""/"");
+ 	request->version (11);
+ 	request->body () = request_string_a;","This could be simplified (if including <boost/algorithm/string/erase.hpp> is fine): `auto address_string = boost::algorithm::erase_first_copy (address.to_string (), ""::ffff:"");`",This will replace `::ffff:` with `::ffff:`.
+5903,"@@ -304,7 +304,7 @@ public class DefaultGridRegistry extends BaseGridRegistry implements GridRegistr
+     if (proxy == null) {
+       return;
+     }
+-    LOG.info(""Registered a node "" + proxy);
++    LOG.finest(""Registered a node "" + proxy);
+     try {
+       lock.lock();
+ ",This is wildly unhelpful to users --- they need to know when a proxy has been registered.,Would be good to keep this at info level if possib
+5904,"@@ -16,8 +16,13 @@ class Topic < ActiveRecord::Base
+   has_one :legacy_trail
+   has_many :trails
+
++  has_attached_file :image, {
++    path: ""topics/:attachment/:id_partition/:style/:filename""
++  }.merge(PAPERCLIP_STORAGE_OPTIONS)
++
+   validates :name, presence: true
+   validates :slug, presence: true, uniqueness: true
++  validates_attachment_content_type :image, content_type: /\Aimage\/.*\Z/
+
+   friendly_id :name, use: [:slugged, :finders]
+ ",Why do we need `do_not_validate_attachment_file_type` is we're doing it in the previous line?,"This seems to be a valid segment, but I'm not sure how to validate it. For example, if I upload a file called `foobar` it should be converted to `foobar`."
+5905,"@@ -107,10 +107,9 @@ public class LoginActivity extends AccountAuthenticatorActivity
+ 		if (shouldUseCertBasedAuth()) {
+ 			final String alias = RuntimeConfig.getRuntimeConfig(this).getString(ConfigKey.ManagedAppCertAlias);
+ 			KeyChain.choosePrivateKeyAlias(this, webviewHelper, null, null, null, 0, alias);
++		} else {
++			webviewHelper.loadLoginPage();
+ 		}
+-
+-		// Load login page
+-		webviewHelper.loadLoginPage();
+ 	}
+
+     /**",Loading login page right away only for the regular use case.,You can remove the else block as well.
+5906,"@@ -1,13 +1,17 @@
+ // render modes
+
++/** Do not recursively re-render a component */
+ export const NO_RENDER = 0;
++/** Recursively re-render a component and it's children */
+ export const SYNC_RENDER = 1;
++/** Force a re-render of a component */
+ export const FORCE_RENDER = 2;
++/** Queue asynchronous re-render of a component and it's children */
+ export const ASYNC_RENDER = 3;
+
+
+ export const ATTR_KEY = '__preactattr_';
+
+-// DOM properties that should NOT have ""px"" added when numeric
++/** DOM properties that should NOT have ""px"" added when numeric */
+ export const IS_NON_DIMENSIONAL = /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i;
+ ",IIRC this flag disables re-rendering entirely (`s/recursively //`),I thought we were planning on enabling this for now?
+5907,"@@ -6,17 +6,11 @@ define([""loading""], function(loading) {
+             url: ApiClient.getUrl(""Startup/Complete""),
+             type: ""POST""
+         }).then(function() {
+-            Dashboard.navigate(""dashboard.html"");
+             loading.hide();
++            window.location.href = ""index.html"";
+         });
+     }
+     return function(view, params) {
+         view.querySelector("".btnWizardNext"").addEventListener(""click"", onFinish);
+-        view.addEventListener(""viewshow"", function() {
+-            document.querySelector("".skinHeader"").classList.add(""noHomeButtonHeader"")
+-        });
+-        view.addEventListener(""viewhide"", function() {
+-            document.querySelector("".skinHeader"").classList.remove(""noHomeButtonHeader"")
+-        });
+     };
+ });","Did you test this redirect? @thornbill mentioned it might need `web` at the front, but if this works fine I'd rather leave it this way.","We shouldn't hardcode the URL here. Instead, use `window.location.href = ""index.html""`"
+5908,"@@ -30,7 +30,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+
+             headers[""custom""] = new[] { ""value"" };
+
+-            Assert.NotNull(headers[""custom""]);
+             Assert.Equal(1, headers[""custom""].Count);
+             Assert.Equal(""value"", headers[""custom""][0]);
+         }","FYI, this returned `StringValues` which is a value type (aka can never be null).",Why was this removed?
+5909,"@@ -1425,7 +1425,16 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
+ 		valueSize := c.targetData.TypeAllocSize(llvmValueType)
+ 		llvmKeySize := llvm.ConstInt(c.ctx.Int8Type(), keySize, false)
+ 		llvmValueSize := llvm.ConstInt(c.ctx.Int8Type(), valueSize, false)
+-		hashmap := c.createRuntimeCall(""hashmapMake"", []llvm.Value{llvmKeySize, llvmValueSize}, """")
++		sizeHint := llvm.ConstInt(c.uintptrType, 8, false)
++		if expr.Reserve != nil {
++			sizeHint = c.getValue(frame, expr.Reserve)
++			var err error
++			sizeHint, err = c.parseConvert(expr.Reserve.Type(), types.Typ[types.Uintptr], sizeHint, expr.Pos())
++			if err != nil {
++				return llvm.Value{}, err
++			}
++		}
++		hashmap := c.createRuntimeCall(""hashmapMake"", []llvm.Value{llvmKeySize, llvmValueSize, sizeHint}, """")
+ 		return hashmap, nil
+ 	case *ssa.MakeSlice:
+ 		sliceLen := c.getValue(frame, expr.Len)","Oh no, that's a bug.",This could use `c.get
+5910,"@@ -23,5 +23,5 @@ package yarpc
+ // Response is the low level response representation.
+ type Response struct {
+ 	Headers          Headers
+-	ApplicationError bool
++	ApplicationError error
+ }","Let's leave a note in CHANGES to replace this with an error metadata struct or interface, unless it would be less effort overall to take a run at it in this change.",If we make this a poi
+5911,"@@ -455,6 +455,10 @@ class Realm {
+  *   This is not supported for `""list""` properties of object types and `""linkingObjects""` properties.
+  * @property {boolean} [indexed] - Signals if this property should be indexed. Only supported for
+  *   `""string""`, `""int""`, and `""bool""` properties.
++ * @property {string} [mapTo] - Set this if the Javascript property name schema differs from the underlying name in the Realm
++ *   file. This can be used to have different naming convention in Javascript than what is being used in the file
++ *   itself. Reading and writing properties must be done using the public key for the property. Queries can be
++ *   done using both the public and the mapped property name.
+  */
+
+ /**","The changelog entry does a better job of explaining how this is used than this description. In particular, this says that you need to set `mapTo` if the underlying name is different, but not that `mapTo` *is* the underlying name.",I am not sure this is
+5912,"@@ -13,6 +13,7 @@ import (
+ 	""github.com/influxdata/flux/plan""
+ 	""github.com/influxdata/flux/semantic""
+ 	_ ""github.com/lib/pq""
++	_ ""github.com/mattn/go-sqlite3""
+ )
+
+ const FromSQLKind = ""fromSQL""","These imports will probably need to be refactored so they aren't here. That applies for all of the database drivers. The reason for this is because we sometimes want a driver to be available and sometimes we don't. When we include this library in our cloud offering, the sqlite3 connector needs to be gone because it's a security vulnerability and there's no use case for it in a cloud environment. But for flux itself, I can see how sqlite3 would be really useful and so I like this change. But this import needs to only exist within the tests and within the `cmd/flux` package. It cannot be here.",Did you mean to add this?
+5913,"@@ -414,7 +414,7 @@ class RelationController extends ControllerBehavior
+      */
+     protected function findExistingRelationIds($checkIds = null)
+     {
+-        $foreignKeyName = $this->relationModel->getKeyName();
++        $foreignKeyName = $this->relationModel->table . '.' . $this->relationModel->getKeyName();
+
+         $results = $this->relationObject
+             ->getBaseQuery()",We can use `getQualifiedKeyName` here instead. I will update.,Shouldn't this be: $this-
+5914,"@@ -115,7 +115,7 @@ module.exports = function getIconByMime (fileType) {
+   }
+
+   // Archive
+-  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-gtar', 'x-apple-diskimage', 'x-diskcopy']
++  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-tar', 'x-gzip', 'x-apple-diskimage']
+   if (fileTypeGeneral === 'application' && archiveTypes.indexOf(fileTypeSpecific) !== -1) {
+     return {
+       color: '#00C469',",Could you clarifty why some of those are removed?,`x-rar-compressed` should
+5915,"@@ -774,3 +774,7 @@ func (a *FakeWebAPI) GetCommand(ctx context.Context, req *webservice.GetCommandR
+ 		Command: &cmd,
+ 	}, nil
+ }
++
++func (a *FakeWebAPI) ListDeploymentConfigTemplates(ctx context.Context, req *webservice.ListDeploymentConfigTemplatesRequest) (*webservice.ListDeploymentConfigTemplatesResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}",`ctx` is unused in ListDeploymentConfigTemplates,Is there a reason we don'
+5916,"@@ -1,10 +1,13 @@
+ <% if id.nil? || id.identifier == '' %>
+     <% if scheme.name.downcase == 'orcid' %>
+-        <%= link_to _(""Create or connect your ORCID iD""),
+-                     Rails.application.routes.url_helpers.send(""user_orcid_omniauth_authorize_path""),
++        <%= link_to  Rails.application.routes.url_helpers.send(""user_orcid_omniauth_authorize_path""),
+                      id: ""connect-orcid-button"", target: '_blank',
+                      title: _(""ORCID provides a persistent digital identifier that distinguishes you from other researchers. Learn more at orcid.org""),
+-                     'data-toggle': ""tooltip"" %>
++                     'data-toggle': ""tooltip"" do %>
++          <%= image_tag 'https://orcid.org/sites/default/files/images/orcid_16x16.png', alt: _('ORCID logo') %>
++          &nbsp;
++          <%= _(""Create or connect your ORCID iD"") %>
++        <% end %>
+     <% elsif scheme.name.downcase == 'shibboleth' %>
+         <i class=""fa fa-user"" title=""<%= _('Institutional credentials') %>"" aria-hidden=""true""></i>
+         &nbsp;",nice to see the usage of block for a more readable link name,can we move this to a constant?
+5917,"@@ -329,9 +329,10 @@ int MPI_File_read(MPI_File fh, void *buf, int count, MPI_Datatype datatype,
+     if (bytes_read != bytes_to_read)
+     {
+         std::snprintf(mpierrmsg, MPI_MAX_ERROR_STRING,
+-                      ""could not read %"" PRId64 "" bytes. read only: %"" PRId64
++                      ""could not read %llu bytes. read only: %llu""
+                       ""\n"",
+-                      bytes_to_read, bytes_read);
++                      (unsigned long long)bytes_to_read,
++                      (unsigned long long)bytes_read);
+         return -2;
+     }
+     *status = bytes_read;","Can these use `static_cast<unsigned long long>` instead? Other than that, it's fine.",If you're going to get rid of M
+5918,"@@ -258,7 +258,6 @@ def create_app(instance_path=None, static_folder=None, **kwargs_config):
+             except (SyntaxError, ValueError):
+                 pass
+             app.config[cfg_name] = cfg_value
+-            app.logger.debug(""{0} = {1}"".format(cfg_name, cfg_value))
+
+     # ====================
+     # Application assembly",This output is only present when `DEBUG=True`. Does it really bother so much?,This at least needs to be at le
+5919,"@@ -1194,11 +1194,7 @@ bool nano::wallet::search_pending ()
+ 						if (wallets.node.ledger.block_confirmed (block_transaction, hash))
+ 						{
+ 							// Receive confirmed block
+-							auto node_l (wallets.node.shared ());
+-							wallets.node.background ([node_l, block, hash]() {
+-								auto transaction (node_l->store.tx_begin_read ());
+-								node_l->receive_confirmed (transaction, block, hash);
+-							});
++							wallets.node.receive_confirmed (block_transaction, block, hash);
+ 						}
+ 						else
+ 						{","I think it should pass wallet transaction as well, otherwise there will be 2 wallet read transactions in 1 threads (next in scan_receivable)",This means that the transaction
+5920,"@@ -3651,14 +3651,14 @@ bool MMFFMolProperties::getMMFFVdWParams(const unsigned int idx1,
+     const MMFFVdW *mmffVdWParamsIAtom = (*mmffVdW)(iAtomType);
+     const MMFFVdW *mmffVdWParamsJAtom = (*mmffVdW)(jAtomType);
+     if (mmffVdWParamsIAtom && mmffVdWParamsJAtom) {
+-      mmffVdWParams.R_ij_starUnscaled = Utils::calcUnscaledVdWMinimum(
++      mmffVdWParams.R_ij_starUnscaled = MMFF::Utils::calcUnscaledVdWMinimum(
+           mmffVdW, mmffVdWParamsIAtom, mmffVdWParamsJAtom);
+-      mmffVdWParams.epsilonUnscaled = Utils::calcUnscaledVdWWellDepth(
++      mmffVdWParams.epsilonUnscaled = MMFF::Utils::calcUnscaledVdWWellDepth(
+           mmffVdWParams.R_ij_starUnscaled, mmffVdWParamsIAtom,
+           mmffVdWParamsJAtom);
+       mmffVdWParams.R_ij_star = mmffVdWParams.R_ij_starUnscaled;
+       mmffVdWParams.epsilon = mmffVdWParams.epsilonUnscaled;
+-      Utils::scaleVdWParams(mmffVdWParams.R_ij_star, mmffVdWParams.epsilon,
++      MMFF::Utils::scaleVdWParams(mmffVdWParams.R_ij_star, mmffVdWParams.epsilon,
+                             mmffVdW, mmffVdWParamsIAtom, mmffVdWParamsJAtom);
+       res = true;
+     }",RDKit::Utils is now in the namespace for localeswitcer... We could change it to something else.,Was there a reason why this isn't `const MMFFVdWParams&`?
+5921,"@@ -211,6 +211,10 @@ class GroupBy(object):
+             kdf = kdf.reset_index(drop=self._should_drop_index)
+
+         if relabeling:
++
++            # For MultiIndex, we need to flatten the tuple, e.g. (('y', 'A'), 'max') needs to be
++            # flattened to ('y', 'A', 'max'), it won't do anything on normal Index.
++            order = [(*levs, method) for levs, method in order]
+             kdf = kdf[order]
+             kdf.columns = columns
+         return kdf","@itholic, can we fix it in `_normalize_keyword_aggregation`?","I think this can just be `(levs, method) for levs in orde"
+5922,"@@ -1,6 +1,7 @@
+ # This class represents a user's subscription to Learn content
+ class Subscription < ActiveRecord::Base
+   MAILING_LIST = 'Active Subscribers'
++  DOWNGRADED_PLAN = 'prime-maintain'
+
+   belongs_to :user
+   belongs_to :mentor, class_name: User","It seems like we have the main plan in the database but the downgrade plan in the code. Probably okay for now, but as our thinking of how downgrades/plans develops we may want to consolidate.",Style/MutableConstant: Freeze mutable objects assigned to
+5923,"@@ -44,6 +44,10 @@ import java.util.List;
+  * </code>
+  */
+ public abstract class By {
++  static {
++    WebDriverException.scheduleIpHostResolving();
++  }
++
+   /**
+    * @param id The value of the ""id"" attribute to search for
+    * @return a By which locates elements by the value of the ""id"" attribute.","we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class.",Remove this empty line.
+5924,"@@ -42,6 +42,8 @@ const (
+ 	optionNamePaymentTolerance     = ""payment-tolerance""
+ 	optionNameResolverEndpoints    = ""resolver-options""
+ 	optionNameGatewayMode          = ""gateway-mode""
++	optionNameClefSignerEnable     = ""clef-signer-enable""
++	optionNameClefSignerEndpoint   = ""clef-signer-endpoint""
+ )
+
+ func init() {",do we need both flags? maybe infer that `clef-signer-enabled` whenever `clef-signer-endpoint` is defined?,"The option names are wrong. It should be `resolver-endpoints`, not `clef-signer-endpoint`."
+5925,"@@ -40,7 +40,7 @@ module.exports = {
+     '<rootDir>/test',
+   ],
+   moduleNameMapper: {
+-    '\\.(scss)$': '<rootDir>/node_modules/identity-obj-proxy',
++    '\\.(scss|css)$': '<rootDir>/node_modules/identity-obj-proxy',
+     'github-markdown-css': '<rootDir>/node_modules/identity-obj-proxy',
+     '\\.(png)$': '<rootDir>/node_modules/identity-obj-proxy',
+     '\\.(svg)$': '<rootDir>/test/unit/empty.js'",Do we need this? I didn't see css files (only scss).,@shahthepro can you confirm that this doesn't create a new file in the build?
+5926,"@@ -29,7 +29,7 @@ class Store:
+
+     if hosts is None:
+       hosts = settings.CLUSTER_SERVERS
+-    remote_hosts = [host for host in hosts if not is_local_interface(host)]
++    remote_hosts = [host for host in hosts if not settings.REMOTE_EXCLUDE_LOCAL or not is_local_interface(host)]
+     self.remote_stores = [ RemoteStore(host) for host in remote_hosts ]
+
+ ",This feels like a weird `if not ... or not` to me. Can you talk out the intent here?,I think it should be `and not is_local_interface(host)` here.
+5927,"@@ -0,0 +1,17 @@
++class AnnualBillingsController < ApplicationController
++  before_filter :authorize
++
++  def new
++    @annualized_payment = current_user.annualized_payment
++    @discounted_annual_payment = current_user.discounted_annual_payment
++  end
++
++  def create
++    AnnualBillingMailer.notification(current_user).deliver
++
++    redirect_to(
++      dashboard_path,
++      notice: ""Thanks! We'll upgrade your account to annual billing.""
++    )
++  end
++end",Align the parameters of a method call if they span more than one line.,Do we not have an endpoint for this already?
+5928,"@@ -17,7 +17,7 @@ namespace ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Opt
+ use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetPackage;
+
+ /**
+- * Class HierarchyPackage
++ * Class OptionsPackage
+  * @package ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options
+  */
+ class OptionsPackage extends AbstractFacetPackage {",`@package *` can be removed as well.,We also use `OptionsPackage` in the other files.
+5929,"@@ -3,7 +3,7 @@ module Beaker
+   # all String methods while adding several platform-specific use cases.
+   class Platform < String
+     # Supported platforms
+-    PLATFORMS = /^(huaweios|cisco_nexus|cisco_ios_xr|(free|open)bsd|osx|centos|fedora|debian|oracle|redhat|scientific|sles|ubuntu|windows|solaris|aix|archlinux|el|eos|cumulus|f5|netscaler)\-.+\-.+$/
++    PLATFORMS = /^(huaweios|cisco_nexus|cisco_ios_xr|(free|open)bsd|osx|centos|fedora|debian|oracle|redhat_fips|redhat|scientific|sles|ubuntu|windows|solaris|aix|archlinux|el|eos|cumulus|f5|netscaler)\-.+\-.+$/
+     # Platform version numbers vs. codenames conversion hash
+     PLATFORM_VERSION_CODES =
+       { :debian => { ""stretch"" => ""9"",",@ScottGarman is there a reason that `redhat_fips` needs to be a beaker platform? Why can't it be another platform that beaker just understands as `redhat`?,I don't think we need the | here at the end of t
+5930,"@@ -274,8 +274,6 @@ void NebulaStore::removePart(GraphSpaceID spaceId, PartitionID partId) {
+         if (partIt != spaceIt->second->parts_.end()) {
+             auto* e = partIt->second->engine();
+             CHECK_NOTNULL(e);
+-            // Stop the raft
+-            partIt->second->stop();
+             raftService_->removePartition(partIt->second);
+             spaceIt->second->parts_.erase(partId);
+             e->removePart(partId);",Where is the other place?,Why are we removing this?
+5931,"@@ -19,10 +19,13 @@
+ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ # IN THE SOFTWARE.
+
++from collections import Sequence
++from boto.vendored.six.moves import UserList
++
+ from boto.s3.user import User
+
+
+-class ResultSet(list):
++class ResultSet(UserList):
+     """"""
+     The ResultSet is used to pass results back from the Amazon services
+     to the client. It is light wrapper around Python's :py:class:`list` class,",Are you subclassing from `UserList` instead of `list` to satisfy some constraint of Jython? My main concern here is that this is a subtle breaking change to the API because `UserList` is not a subclass of `list`. This has the unfortunate side effect of breaking any user that is using `isinstance` checks to see if a `ResultSet` is a `list`.,Can we use `boto.vendored.six.moves` instead?
+5932,"@@ -32,6 +32,14 @@ module AvatarHelper
+     ""<img src='/assets/icons/sm_laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
+   end
+
++  def avatar_laurels(rank)
++    ""<img src='/assets/icons/laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
++  end
++
++  def avatar_tiny_laurels(rank)
++    ""<img src='/assets/icons/tn_laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
++  end
++
+   private
+
+   def avatar_default_size(size)",We can DRY the above three functions,Line is too long. [104/80]
+5933,"@@ -55,14 +55,7 @@ public final class HashMap<K, V> implements Map<K, V>, Serializable {
+      * @return A {@link HashMap} Collector.
+      */
+     public static <K, V> Collector<Tuple2<K, V>, ArrayList<Tuple2<K, V>>, HashMap<K, V>> collector() {
+-        final Supplier<ArrayList<Tuple2<K, V>>> supplier = ArrayList::new;
+-        final BiConsumer<ArrayList<Tuple2<K, V>>, Tuple2<K, V>> accumulator = ArrayList::add;
+-        final BinaryOperator<ArrayList<Tuple2<K, V>>> combiner = (left, right) -> {
+-            left.addAll(right);
+-            return left;
+-        };
+-        final Function<ArrayList<Tuple2<K, V>>, HashMap<K, V>> finisher = HashMap::ofEntries;
+-        return Collector.of(supplier, accumulator, combiner, finisher);
++        return Collections.toListAndThen(HashMap::ofEntries);
+     }
+
+     /**",Only no good is good code. Nice that you were able to remove all this duplicate stuff!,It's not clear to me why t
+5934,"@@ -121,7 +121,7 @@ public class PhpSurfaceNamer extends SurfaceNamer {
+
+   @Override
+   public String getRetrySettingsTypeName() {
+-    return ""\\Google\\ApiCore\\RetrySettings"";
++    return ""RetrySettings"";
+   }
+
+   @Override","Looking at the code, it seems very odd that this method even exists in the SurfaceNamer, since it is only implemented and used in the PhpSurfaceNamer, and in fact the RetrySettings class name is hardcoded elsewhere. WDYT of just removing this method from SurfaceNamer and PhpSurfaceNamer?",Can we make it a constant?
+5935,"@@ -107,3 +107,18 @@ func SplitWriteAll(ctx context.Context, s Splitter, r io.Reader, l int64, toEncr
+ 	}
+ 	return addr, nil
+ }
++
++type Loader interface {
++	// Load a reference in byte slice representation and return all content associated with the reference.
++	Load(context.Context, []byte) ([]byte, error)
++}
++
++type Saver interface {
++	// Save an arbitrary byte slice and return the reference byte slice representation.
++	Save(context.Context, []byte) ([]byte, error)
++}
++
++type LoadSaver interface {
++	Loader
++	Saver
++}",these interfaces are defined twice. we should use only one and have it in `storage` package maybe,Why is this separate from
+5936,"@@ -24,12 +24,16 @@
+ import cPickle as pickle
+ import os
+ import shutil
++import logging
+ from abc import ABCMeta, abstractmethod
+
+ import nupic.frameworks.opf.opfutils as opfutils
+
+-
+ ###############################################################
++# global variable
++global globalModelsStorage
++globalModelsStorage={}
++
+
+ class Model(object):
+   """""" This is the base class that all OPF Model implementations should",This is the wrong context for usage of `global` keyword. It need only be used inside functions.,why use `global` instead of `self.globalModelsStorage`?
+5937,"@@ -278,7 +278,7 @@ public abstract class AbstractNode implements Node {
+
+         for (int i = 0; i < node.jjtGetNumChildren(); i++) {
+             Node child = node.jjtGetChild(i);
+-            if (child.getClass() == targetType) {
++            if (targetType.isAssignableFrom(child.getClass())) {
+                 results.add(targetType.cast(child));
+             }
+ ",this change should be described in the changelog. I'll update it when merging if nothing else arises.,Can you explain why this change is needed?
+5938,"@@ -52,9 +52,11 @@ const (
+ type (
+ 	// RPCFactory Creates a dispatcher that knows how to transport requests.
+ 	RPCFactory interface {
+-		CreateDispatcher() *yarpc.Dispatcher
++		CreateTChannelDispatcher() *yarpc.Dispatcher
++		CreateGRPCDispatcher() *yarpc.Dispatcher
+ 		CreateRingpopDispatcher() *yarpc.Dispatcher
+ 		CreateDispatcherForOutbound(callerName, serviceName, hostName string) *yarpc.Dispatcher
++		CreateDispatcherForGRPCOutbound(callerName, serviceName, hostName string) *yarpc.Dispatcher
+ 	}
+ )
+ ",Just to stay consistent with naming let's call it CreateGRPCDispatcherForOutbound. Also rename 'CreateDispatcherForOutbound' to 'CreateTChannelDispatcherForOutbound',I see that `CreateTChannelDispatcher` and `CreateGRPCDi
+5939,"@@ -88,7 +88,7 @@ public class Docker {
+
+     findImage(new ImageNamePredicate(name, tag));
+
+-    LOG.info(String.format(""Pulling %s:%s"", name, tag));
++    LOG.finest(String.format(""Pulling %s:%s"", name, tag));
+
+     HttpRequest request = new HttpRequest(POST, ""/images/create"");
+     request.addQueryParameter(""fromImage"", name);",This will always need to be displayed to users.,This is also a test case I don't know about.
+5940,"@@ -431,3 +431,6 @@ def safe_subn(pattern, repl, target, *args, **kwargs):
+         need a better solution that is aware of the actual content ecoding.
+     """"""
+     return re.subn(str(pattern), str(repl), target, *args, **kwargs)
++
++def bin_safe(s):
++    return ''.join([""\\x{:02x}"".format(ord(i)) if ord(i) < 32 else i for i in s])",This looks very much like `repr` now (we miss 127 though) - maybe just do `repr(x)` + strip outer parantheses?,The `\x` is redundant here and below. Just use `\x` instead.
+5941,"@@ -386,6 +386,7 @@ func (p *replicatorQueueProcessorImpl) generateSyncActivityTask(
+ 						VersionHistory:     versionHistory,
+ 					},
+ 				},
++				VisibilityTime: &taskInfo.VisibilityTimestamp,
+ 			}, nil
+ 		},
+ 	)",I don't see this field is set in task_generator.go. worth to double check if we put the timestamp when creating replication tasks.,Does it matter that this is only set on create task?
+5942,"@@ -236,7 +236,9 @@ const hasNext = (self, callback) => {
+   if (self.s.currentDoc) {
+     return callback(null, true);
+   }
+-
++  if (self.isNotified()) {
++    return callback(null, false);
++  }
+   nextObject(self, function(err, doc) {
+     if (err) return callback(err, null);
+     if (self.s.state === Cursor.CLOSED || self.isDead()) return callback(null, false);",nit: I prefer the space before and after this check to make it very easy to scan when reading through code,shouldn't this be `self.s.isNotified()`?
+5943,"@@ -454,6 +454,15 @@ Morbi Nulla justo Aenean orci Vestibulum ullamcorper tincidunt mollis et hendrer
+                     logger.Info(createdMessage);
+                 }
+
++                // Make triple-flush to fully exercise the async flushing logic
++                try
++                {
++                    LogManager.Flush(0);
++                }
++                catch (NLog.NLogRuntimeException)
++                { }
++                LogManager.Flush(); // Waits for flush (Scheduled on top of the previous flush)
++                LogManager.Flush(); // Nothing to flush
+             });
+
+ ",should users also do a triple-flush?,Isn't it possible to use a `using` statement here?
+5944,"@@ -302,9 +302,7 @@ func testCodec(t *testing.T, ct CodecTester) {
+ 	type S struct {
+ 		N  *int
+ 		I  int
+-		U  uint
+ 		F  float64
+-		C  complex64
+ 		St string
+ 		B  bool
+ 		By []byte","What is the implication of removing these from the test? I thought the idea was to have all types supported by `docstore` here, and do things in the drivers to make them support them (e.g., list of size 2 for complex). If you're removing them because firestore doesn't have native support, then we're going to end up only testing the intersection of all types supported by all drivers; we need a better way.",Why was U removed?
+5945,"@@ -217,7 +217,7 @@ class DataViewer(base.GridEditor, layoutwidget.LayoutWidget):
+             ]) -> None:
+         if vals:
+             # Whatever vals is, make it a list of rows containing lists of column values.
+-            if isinstance(vals, str):
++            if not isinstance(vals, list):
+                 vals = [vals]
+             if not isinstance(vals[0], list):
+                 vals = [[i] for i in vals]",Let's also adjust the somewhat weird type signature here as well. This probably should be `typing.Any` instead of `str` in the last line if we intend to support ints.,Mypy is complainin
+5946,"@@ -36,7 +36,7 @@ func makeBucket(t *testing.T) (*blob.Bucket, func()) {
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}
+-	return b, func() {}
++	return b, func() { _ = os.RemoveAll(dir) }
+ }
+ func TestConformance(t *testing.T) {
+ 	drivertest.RunConformanceTests(t, makeBucket, ""../testdata"")",The body can just be `os.RemoveAll(dir)`,This is unrelated
+5947,"@@ -42,7 +42,7 @@ public class Cast extends NoOp {
+     } else if (targetDataType instanceof RealType) {
+       casted = castToDouble(value);
+     } else {
+-      throw new UnsupportedOperationException(""only support cast to Long, Double and String"");
++      casted = value;
+     }
+     row.set(pos, targetDataType, casted);
+   }",Is this covered by regression tests? Also you might make a patch onto refactor branch.,Could you please e
+5948,"@@ -54,6 +54,11 @@ public class SolrPing extends SolrRequest<SolrPingResponse> {
+   public ModifiableSolrParams getParams() {
+     return params;
+   }
++
++  @Override
++  public String getRequestType() {
++    return SolrRequestType.QUERY.toString();
++  }
+
+   /**
+    * Remove the action parameter from this request. This will result in the same",This is maybe more of an admin request? WDYT?,Not sure if SolrRequestType.QUERY.toString() is better than SolrRequestType.WIP.toString()
+5949,"@@ -109,16 +109,16 @@ public interface TraversableOnce<T> extends Iterable<T> {
+     }
+
+     /**
+-     * Converts this TraversableOnce to a HashMap.
++     * Converts this TraversableOnce to a Map.
+      *
+      * @param f   A function that maps an element to a Map.Entry
+      * @param <K> The key type of a Map Entry
+      * @param <V> The value type of a Map Entry
+      * @return a new HashMap containing the elements mapped to entries
+      */
+-    default <K, V> HashMap<K, V> toHashMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) {
++    default <K, V> Map<K, V> toMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) {
+         Objects.requireNonNull(f, ""f is null"");
+-        return HashMap.<K, V> ofAll(toList().map(f::apply));
++        return Map.<K, V> ofAll(toList().map(f::apply));
+     }
+
+     /**","Here I thought of `toHashMap` and later add `toTreeMap`. But I start to see, what you may have in mind. Alternatively we could provide a `toMap` and `toSortedMap`, which is great, too. On the other hand is always good to be as specific as possible. What do you think?",Can't do this. It's a type change in a minor release.
+5950,"@@ -79,13 +79,13 @@ type appDeployOpts struct {
+
+ 	projectService   projectService
+ 	ecrService       ecr.Service
+-	workspaceService *workspace.Workspace
++	workspaceService archer.Workspace
+
+ 	prompt  prompter
+ 	spinner progress
+
+-	projectApplications []*archer.Application
+-	projectEnvironments []*archer.Environment
++	localProjectAppNames []string
++	projectEnvironments  []*archer.Environment
+ }
+
+ func (opts appDeployOpts) String() string {",maybe localProjectAppNames? Just a thought.,"Just as a note for later, I think we need to make sure all of these are set up correctly. "
+5951,"@@ -354,6 +354,7 @@ Blockly.BlockSvg.prototype.getHeightWidth = function() {
+   if (nextBlock) {
+     var nextHeightWidth = nextBlock.getHeightWidth();
+     height += nextHeightWidth.height;
++    height -= Blockly.BlockSvg.NOTCH_HEIGHT; // Exclude height of connected notch.
+     width = Math.max(width, nextHeightWidth.width);
+   }
+   return {height: height, width: width};","This isn't new, but getHeightWidth is now defined in block_svg.js, block_render_svg_horizontal.js, and block_render_svg_vertical.js. One of these should be unnecessary.",Not sure if `BlockSvg.NOTCH_HEIGHT` is the best value for the height. @Leemoonsoo do you h
+5952,"@@ -156,7 +156,7 @@ func TestGroupTransactionsDifferentSizes(t *testing.T) {
+
+ 		// wait for the txids and check balances
+ 		_, curRound := fixture.GetBalanceAndRound(account0)
+-		confirmed := fixture.WaitForAllTxnsToConfirm(curRound+5, txids)
++		confirmed := fixture.WaitForAllTxnsToConfirm(curRound+10, txids)
+ 		a.True(confirmed, ""txgroup"")
+
+ 		for i, acct := range accts {","I can't see any reason why this would fix a failure in `a.True(confirmed, ""txgroup"")`. We might have an issue elsewhere, but increasing the wait time wouldn't help.",+5 blocks should be accompanied by 10 blocks. 10 blocks should be accompanied by 10 blocks.
+5953,"@@ -46,6 +46,10 @@ module Beaker
+         @logger.perf_output(""Creating symlink from /etc/sysstat/sysstat.cron to /etc/cron.d"")
+         host.exec(Command.new('ln -s /etc/sysstat/sysstat.cron /etc/cron.d'),:acceptable_exit_codes => [0,1])
+       end
++      if @options[:collect_perf_data] =~ /aggressive/
++        @logger.perf_output(""Enabling aggressive sysstat polling"")
++        host.exec(Command.new('sed -i s/5-55\\\/10/*/ /etc/cron.d/sysstat'))
++      end
+       if host['platform'] =~ PERF_START_PLATFORMS # SLES doesn't need this step
+         host.exec(Command.new('service sysstat start'))
+       end","This section needs to be modified; crontab format differs between OS releases (Debian and CentOS, at least).","Instead of relying on the value of `s/5-55/` here, can we just use `/etc/sysstat`?"
+5954,"@@ -54,7 +54,10 @@ from .results import PipelineExecutionResult
+
+
+ def execute_run_iterator(
+-    pipeline: IPipeline, pipeline_run: PipelineRun, instance: DagsterInstance
++    pipeline: IPipeline,
++    pipeline_run: PipelineRun,
++    instance: DagsterInstance,
++    resume_from_failure: bool = False,
+ ) -> Iterator[DagsterEvent]:
+     check.inst_param(pipeline, ""pipeline"", IPipeline)
+     check.inst_param(pipeline_run, ""pipeline_run"", PipelineRun)","if we think this is likely to be augmented with a additional 'run coordination' features or configuration in the future, we could make it an object of some kind instead (or an enum, if we think there may be other resume modes in the future besides just on/off). Just imagining 6 months in the future, it would be unfortunate if there were 7 new args here as the feature gets more complex",Nit: This argument is unused?
+5955,"@@ -1,8 +1,10 @@
++from .affine_grid_generator import affine_grid
+ from .context_block import ContextBlock
+ from .dcn import (DeformConv, DeformConvPack, DeformRoIPooling,
+                   DeformRoIPoolingPack, ModulatedDeformConv,
+                   ModulatedDeformConvPack, ModulatedDeformRoIPoolingPack,
+                   deform_conv, deform_roi_pooling, modulated_deform_conv)
++from .grid_sampler import grid_sample
+ from .masked_conv import MaskedConv2d
+ from .nms import nms, soft_nms
+ from .roi_align import RoIAlign, roi_align",`affine_grid` and `grid_sample` are currently unused. We may remove it from `ops/__init__.py` to speedup the loading of mmdet.,why not `from .grid_sampler import grid_sample`?
+5956,"@@ -215,6 +215,12 @@ func populateClientConfig(config *Config, createdPacketConn bool) *Config {
+ 	if config.IdleTimeout != 0 {
+ 		idleTimeout = config.IdleTimeout
+ 	}
++	attackTimeout := protocol.DefaultAttackTimeout
++	if config.AttackTimeout > 0 {
++		attackTimeout = config.AttackTimeout
++	} else if config.AttackTimeout < 0 {
++		attackTimeout = 0
++	}
+
+ 	maxReceiveStreamFlowControlWindow := config.MaxReceiveStreamFlowControlWindow
+ 	if maxReceiveStreamFlowControlWindow == 0 {",Is there a reason why you need to support negative `AttackTimeout`? Why not just throw an error?,Why not just `if config.AttackTimeout > 0 {` ?
+5957,"@@ -25,6 +25,7 @@ from typing import Any, Optional, List, Tuple, Union, Generic, TypeVar
+
+ import numpy as np
+ import pandas as pd
++import pyspark.sql.functions as F
+ from pandas.api.types import is_list_like, is_dict_like
+ from pandas.core.dtypes.common import infer_dtype_from_object
+ from pandas.core.dtypes.inference import is_sequence",nit: an unnecessary change?,nit: these imports are unused
+5958,"@@ -1,15 +1,17 @@
+ package http3
+
+ import (
+-	""fmt""
+ 	""io""
+
+ 	""github.com/lucas-clemente/quic-go""
++	""github.com/marten-seemann/qpack""
+ )
+
++type trailerFunc func([]qpack.HeaderField, error)
++
+ // The body of a http.Request or http.Response.
+ type body struct {
+-	str quic.Stream
++	str RequestStream
+
+ 	// only set for the http.Response
+ 	// The channel is closed when the user is done with this response:","Is trailer parsing something we have to do in this PR? It would be really helpful to separate stuff like this into smaller, self-contained PRs.",I think this could just be `func (a RequestStr
+5959,"@@ -153,6 +153,7 @@ module Beaker
+       vm.volumes.each do |vol|
+         @logger.debug ""Deleting volume #{vol.name} for OpenStack host #{vm.name}""
+         vm.detach_volume(vol.id)
++        vol.wait_for { ready? }
+         vol.destroy
+       end
+     end",Any chance of a wait-forever situation here? Is there a reasonable timeout?,"We are waiting for the volumes to be deleted, "
+5960,"@@ -79,12 +79,10 @@ func (bs *blockSyncer) P2P() network.Overlay {
+ // Start starts a block syncer
+ func (bs *blockSyncer) Start(ctx context.Context) error {
+ 	logger.Debug().Msg(""Starting block syncer"")
+-	startHeight, err := findSyncStartHeight(bs.bc)
+-	if err != nil {
+-		return err
+-	}
+-	bs.buf.startHeight = startHeight
+-	bs.buf.confirmedHeight = startHeight - 1
++	// FIXME this node may still has issue, if it was following the wrong chain, this is actually a general version of 2, but in 3, we need to rollback blockchain first
++	bs.buf.startHeight = bs.bc.TipHeight() + 1
++	bs.buf.confirmedHeight = bs.bc.TipHeight()
++
+ 	return bs.worker.Start(ctx)
+ }
+ ",line is 165 characters,"The startHeight and confirmedHeight are updated in `findSyncStartHeight`, so we can revert the blockchain first here."
+5961,"@@ -107,9 +107,13 @@ func (s *IntegrationBase) setupSuite(defaultClusterConfigFile string) {
+
+ 	s.Require().NoError(s.registerArchivalNamespace())
+
+-	// this sleep is necessary because namespacev2 cache gets refreshed in the
+-	// background only every namespaceCacheRefreshInterval period
+-	time.Sleep(namespace.CacheRefreshInterval + time.Second)
++	if clusterConfig.FrontendAddress == """" {
++		// Poke all the in-process namespace caches to refresh without waiting for the usual refresh interval.
++		s.testCluster.RefreshNamespaceCache()
++	} else {
++		// Wait for one whole cycle of the namespace cache v2 refresh interval to be sure that our namespaces are loaded.
++		time.Sleep(namespace.CacheRefreshInterval + time.Second)
++	}
+ }
+
+ func (s *IntegrationBase) setupLogger() {",is this for cross DC case?,"Just curious, what's the reasoning for this sleep?"
+5962,"@@ -199,7 +199,7 @@ if __name__ == '__main__':
+         keywords='computer vision, object detection',
+         url='https://github.com/open-mmlab/mmdetection',
+         packages=find_packages(exclude=('configs', 'tools', 'demo')),
+-        package_data={'mmdet.ops': ['*/*.so']},
++        package_data={'mmcv.ops': ['*/*.so']},
+         classifiers=[
+             'Development Status :: 4 - Beta',
+             'License :: OSI Approved :: Apache Software License',",Remove this line.,Could you explain the change here?
+5963,"@@ -668,10 +668,11 @@ import browser from './browser';
+         }
+
+         if (canPlayVp8) {
++            // TODO: Remove vpx entry once servers are migrated
+             profile.TranscodingProfiles.push({
+                 Container: 'webm',
+                 Type: 'Video',
+-                AudioCodec: 'vorbis',
++                AudioCodec: webmAudioCodecs.includes('opus') ? 'opus' : 'vorbis',
+                 VideoCodec: 'vpx',
+                 Context: 'Streaming',
+                 Protocol: 'http',",Maybe it would make sense to use `webmVideoCodecs` here and just append `vpx`. I'm not sure if av1 is currently supported when transcoding to webm though. It looks like it can be included in the mp4 transcoding profile now.,This TODO can be removed once the server is migrated
+5964,"@@ -182,7 +182,7 @@ public class StatsValuesFactory {
+       // ""NumericValueSourceStatsValues"" which would have diff parent classes
+       //
+       // part of the complexity here being that the StatsValues API serves two
+-      // masters: collecting concrete Values from things like DocValuesStats and
++      // primaries: collecting concrete Values from things like DocValuesStats and
+       // the distributed aggregation logic, but also collecting docIds which it
+       // then
+       // uses to go out and pull concreate values from the ValueSource","Interestingly, this has nothing to do with replication, no clue what this means here","""primaries"" is a typo"
+5965,"@@ -251,8 +251,14 @@ func (r *runner) initRepoIfNeeded(ctx context.Context, forCmd string) (
+ 		}()
+ 	}
+
+-	fs, _, err = libgit.GetOrCreateRepoAndID(
+-		ctx, r.config, r.h, r.repo, r.uniqID)
++	// Only allow lazy creates for public and multi-user TLFs.
++	if r.h.Type() == tlf.Public || len(r.h.ResolvedWriters()) > 1 {
++		fs, _, err = libgit.GetOrCreateRepoAndID(
++			ctx, r.config, r.h, r.repo, r.uniqID)
++	} else {
++		fs, _, err = libgit.GetRepoAndID(
++			ctx, r.config, r.h, r.repo, r.uniqID)
++	}
+ 	if err != nil {
+ 		return nil, nil, err
+ 	}",Is that because we don't provide a UI for these?,Would it be more effi
+5966,"@@ -7,9 +7,11 @@ import (
+ 	""time""
+
+ 	""github.com/influxdata/flux""
++	""github.com/influxdata/flux/codes""
+ 	""github.com/influxdata/flux/execute""
+ 	""github.com/influxdata/flux/execute/executetest""
+ 	_ ""github.com/influxdata/flux/fluxinit/static"" // We need to init flux for the tests to work.
++	""github.com/influxdata/flux/internal/errors""
+ 	""github.com/influxdata/flux/mock""
+ 	""github.com/influxdata/flux/querytest""
+ 	""github.com/influxdata/flux/stdlib/csv""",Standard is either to use `HappyPath` (CamelCase) or `happy path` (lowercase sentence). I usually prefer the latter.,Did you mean `influxd
+5967,"@@ -46,7 +46,7 @@ func TestSuggestGasPriceForUserAction(t *testing.T) {
+ 	blkState := blockchain.InMemStateFactoryOption()
+ 	blkMemDao := blockchain.InMemDaoOption()
+ 	blkRegistryOption := blockchain.RegistryOption(&registry)
+-	bc := blockchain.NewBlockchain(cfg, blkState, blkMemDao, blkRegistryOption)
++	bc := blockchain.NewBlockchain(cfg, nil, blkState, blkMemDao, blkRegistryOption)
+ 	bc.Validator().AddActionEnvelopeValidators(protocol.NewGenericValidator(bc))
+ 	exec := execution.NewProtocol(bc, config.NewHeightUpgrade(cfg))
+ 	require.NoError(t, registry.Register(execution.ProtocolID, exec))","instead of using blkMemDao, we could generate a blockMemDao, and then use it as the second parameter.",why is this change ne
+5968,"@@ -147,6 +147,10 @@ function eachAsync(arr, eachFn, callback) {
+   }
+ }
+
++function isUnifiedTopology(topology) {
++  return topology.description != null;
++}
++
+ module.exports = {
+   uuidV4,
+   calculateDurationInMs,",nit(2/10): `topology && topology.description != null`;,does topology.description exist? i thought description was required?
+5969,"@@ -1,6 +1,8 @@
+ """"""
+ Wrappers around spark that correspond to common pandas functions.
+ """"""
++import sys
++
+ import pyspark.sql
+ import numpy as np
+ import pandas as pd",why the space? I may not know all the style conventions.,can we revert these changes since they are not related to this PR
+5970,"@@ -21,6 +21,12 @@ describe('dlitem', function () {
+ 		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
+ 	});
+
++	it('should fail if the dlitem has a parent <dl> with a changed role', function(){
++		var checkArgs = checkSetup('<dl role=""menubar""><dt id=""target"">My list item</dl>');
++
++		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
++	});
++
+ 	(shadowSupport.v1 ? it : xit)('should return true in a shadow DOM pass', function () {
+ 		var node = document.createElement('div');
+ 		node.innerHTML = '<dt>My list item </dt>';","Should be ""should fail if the **dt element** has a parent <dl> with a changed role""",This test will fail if the parent is not a list item. It's better to
+5971,"@@ -10,7 +10,15 @@ Workshops::Application.configure do
+   config.assets.digest = true
+   config.assets.js_compressor = :uglifier
+   config.assets.precompile += %w( print.css prefilled_input.js )
+-  config.serve_static_assets = false
++
++  # Serve static assets, which allows us to populate the CDN with compressed
++  # assets if a client supports them
++  config.serve_static_assets = true
++
++  # Fiddling with expires values is kind of pointless as we use hashing to bust
++  # caches during redeploys, but it should bump up our google pagespeed
++  # ranking.
++  config.static_cache_control = 'public, max-age=31536000'
+
+   config.eager_load = true
+   config.cache_store = :dalli_store","Just to be clear: 1. This is required for compression, right? 2. This won't actually result in our dynos serving the assets, since they'll be served via the CDN, correct?",Do we want to bump this up after redeploys or do we want to make it
+5972,"@@ -17,10 +17,6 @@ class MediaManager extends BasePHPCRManager
+ {
+     /**
+      * {@inheritdoc}
+-     *
+-     * Warning: previous method signature was : save(MediaInterface $media, $context = null, $providerName = null)
+-     *
+-     * @throws \InvalidArgumentException When entity is an invalid object
+      */
+     public function save($entity, $andFlush = true)
+     {",not sure about removing this ping @Soullivaneuh,"This annotation was wrong. When the media was invalid, the error message was misleading."
+5973,"@@ -12,7 +12,12 @@ class User < ActiveRecord::Base
+   validates :github_username, uniqueness: true, presence: true
+
+   delegate :plan, to: :subscription, allow_nil: true
+-  delegate :scheduled_for_deactivation_on, to: :subscription, allow_nil: true
++  delegate(
++    :scheduled_for_deactivation_on,
++    :scheduled_for_deactivation?,
++    to: :subscription,
++    allow_nil: true
++  )
+
+   before_save :clean_github_username
+ ",Put a comma after the last parameter of a multiline method call.,Not sure if this should be a part of this PR or a separate PR.
+5974,"@@ -61,8 +61,8 @@ func TestInstanceIfExists(t *testing.T) {
+ 					Return(nil, awserrors.NewNotFound(""not found""))
+ 			},
+ 			check: func(instance *infrav1.Instance, err error) {
+-				if err != nil {
+-					t.Fatalf(""did not expect error: %v"", err)
++				if err == nil {
++					t.Fatalf(""expects error when instance could not be found: %v"", err)
+ 				}
+
+ 				if instance != nil {","If instance could not be found when the provider id is set, `findInstance()` returns `ErrInstanceNotFoundByID` error. So that during reconcileNormal(), we don't create a new instance. In `reconcileDelete()`, when ErrInstanceNotFoundByID is seen, deletion continues to clean up even if the instance is gone (may be manually deleted).",`expects error when instance could not be found`
+5975,"@@ -38,6 +38,10 @@ namespace pwiz.Skyline.EditUI
+         private readonly bool _originalAlignRtPrediction;
+         private readonly ChromFileInfoId _originalAlignFile;
+
++        private int _idxLastSelected = -1;
++
++        private Tuple<string, HashSet<string>> _memory = Tuple.Create((string)null, new HashSet<string>());
++
+         private SrmDocument Document => _skylineWindow.Document;
+         private GroupByItem SelectedGroupBy => (GroupByItem) comboGroupBy.SelectedItem;
+ ","I would recommend making this a Tuple&lt;ReplicateValue, IColllection&lt;object>> You only need to convert things to strings if you need to persist them in Settings or something. If they only need to live for the life of dialog, you can keep everything as objects. You can use ""null"" for the ReplicateValue for when they have not chosen a property.",please use `HashSet<string>` directly.
+5976,"@@ -33,14 +33,14 @@
+         _source: [""https://www.google.lv"", ""https://www.google.co.in/"", ""https://www.google.ru/"", ""http://stackoverflow.com/questions"", ""http://stackoverflow.com/unanswered"", ""http://stackoverflow.com/tags"", ""http://r.search.yahoo.com/""]
+ 	};
+ 	var eventsMap = {
+-		""Login"": [""Lost"", ""Won"",""[CLY]_star_rating""],
++		""Login"": [""Lost"", ""Won""],
+ 		""Logout"": [],
+ 		""Lost"": [""Won"", ""Achievement"", ""Lost""],
+ 		""Won"": [""Lost"", ""Achievement""],
+ 		""Achievement"": [""Sound"", ""Shared""],
+ 		""Sound"": [""Lost"", ""Won""],
+ 		""Shared"": [""Lost"", ""Won""],
+-		""[CLY]_star_rating"":[""Lost"", ""Won"", ""Achievement""]
++        ""[CLY]_action"":[]
+ 	};
+ 	var pushEvents = [""[CLY]_push_sent"", ""[CLY]_push_open"", ""[CLY]_push_action""];
+ 	var segments  = {","I think there is no point providing action key here, as it will be called specifically, rather than randomly",Any reason we don't want to include `[CLY]` anymore?
+5977,"@@ -31,14 +31,13 @@ namespace Datadog.Trace.ClrProfiler.Integrations.Testing
+
+         private static readonly IntegrationInfo IntegrationId = IntegrationRegistry.GetIntegrationInfo(nameof(IntegrationIds.XUnit));
+         private static readonly Vendors.Serilog.ILogger Log = DatadogLogging.GetLogger(typeof(XUnitIntegration));
+-        private static readonly FrameworkDescription _runtimeDescription;
++        private static readonly FrameworkDescription RuntimeDescription;
+
+         static XUnitIntegration()
+         {
+             // Preload environment variables.
+             CIEnvironmentValues.DecorateSpan(null);
+-
+-            _runtimeDescription = FrameworkDescription.Create();
++            RuntimeDescription = FrameworkDescription.Instance;
+         }
+
+         /// <summary>",`XUnitIntegration` doesn't need to cache this anymore.,Can we remove this now that it's not static?
+5978,"@@ -13,11 +13,13 @@ files[""awesomerc.lua""].allow_defined_top = true
+ -- This file itself
+ files["".luacheckrc""].ignore = {""111"", ""112"", ""131""}
+
++-- Theme files, ignore max line length
++files[""themes/*""].ignore = {""631""}
++
+ -- Global objects defined by the C code
+ read_globals = {
+     ""awesome"",
+     ""button"",
+-    ""client"",
+     ""dbus"",
+     ""drawable"",
+     ""drawin"",",Can we have something line `# noqa` there instead? I think it's fine like this though.,perhaps this should be `themes/unified/`
+5979,"@@ -309,16 +309,17 @@ class AbstractNode
+   #
+   # Returns A String reference or data URI for the target image
+   def image_uri(target_image, asset_dir_key = 'imagesdir')
++    images_base = asset_dir_key ? (attr asset_dir_key, nil, true) : nil
+     if (doc = @document).safe < SafeMode::SECURE && (doc.attr? 'data-uri')
+       if ((Helpers.uriish? target_image) && (target_image = Helpers.encode_spaces_in_uri target_image)) ||
+-          (asset_dir_key && (images_base = doc.attr asset_dir_key) && (Helpers.uriish? images_base) &&
++          (images_base && (Helpers.uriish? images_base) &&
+           (target_image = normalize_web_path target_image, images_base, false))
+         (doc.attr? 'allow-uri-read') ? (generate_data_uri_from_uri target_image, (doc.attr? 'cache-uri')) : target_image
+       else
+         generate_data_uri target_image, asset_dir_key
+       end
+     else
+-      normalize_web_path target_image, (asset_dir_key ? (doc.attr asset_dir_key) : nil)
++      normalize_web_path target_image, images_base
+     end
+   end
+ ",this variable is used in both branches so I've decided to declare it above,Metrics/LineLength: Line is too long. [83/80]
+5980,"@@ -382,11 +382,11 @@ public class PasscodeManager  {
+         	return;
+         }
+         Intent i = new Intent(ctx, PasscodeActivity.class);
+-        i.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
+-        i.setFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
+-        i.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
++        i.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
++        i.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
++        i.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
+         if (ctx == SalesforceSDKManager.getInstance().getAppContext()) {
+-            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
++            i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+         }
+         if (ctx instanceof Activity) {
+             ((Activity) ctx).startActivityForResult(i, PASSCODE_REQUEST_CODE);","`setFlags()` overwrites the previous flag, we should be using `addFlags()` to append flags.",I'd be curious if there was a reason why you didn't add the flag `FLAG_ACTIVITY_SINGLE_TOP` above
+5981,"@@ -105,6 +105,15 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
+ 		}
+
+ 		if repo.IsMirror {
++			if isNameChanged {
++				var err error
++				ctx.Repo.Mirror, err = models.GetMirror(repo.ID)
++				if err != nil {
++					ctx.Handle(500, ""RefreshRepositoryMirror"", err)
++					return
++				}
++			}
++
+ 			if form.Interval > 0 {
+ 				ctx.Repo.Mirror.EnablePrune = form.EnablePrune
+ 				ctx.Repo.Mirror.Interval = form.Interval",Need `return` after this.,Why not just use `ctx.Repo.Mirror.IsRepo = true`?
+5982,"@@ -13,12 +13,14 @@ use RootedData\Exception\ValidationException;
+  * Json Response Trait.
+  */
+ trait JsonResponseTrait {
++  use CacheableResponseTrait;
+
+   /**
+    * Private.
+    */
+   private function getResponse($message, int $code = 200): JsonResponse {
+-    return new JsonResponse($message, $code, []);
++    $response = new JsonResponse($message, $code, []);
++    return $this->addCacheHeaders($response);
+   }
+
+   /**","I would say we should not use the `CacheableResponseTrait` within the `JsonResponseTrait`. Traits within traits tend to lead to a bad developer experience as it can be really hard to find the actual method you're seeing in the implementing class, and in this case it looks like we're using _both_ the cacheable and the JSON traits in the same controller, so it's redundant anyway. I'd recommend just removing that use statement from `JsonResponseTrait` and make sure `ChaceableResponseTrait` is included everywhere it's needed specifically.",I would use `CacheableResponseTrait` here.
+5983,"@@ -43,7 +43,7 @@ class BoundZmqEventBus implements EventBus {
+     Addresses xpubAddr = deriveAddresses(address, publishConnection);
+     Addresses xsubAddr = deriveAddresses(address, subscribeConnection);
+
+-    LOG.info(String.format(""XPUB binding to %s, XSUB binding to %s"", xpubAddr, xsubAddr));
++    LOG.finest(String.format(""XPUB binding to %s, XSUB binding to %s"", xpubAddr, xsubAddr));
+
+     xpub = context.createSocket(SocketType.XPUB);
+     xpub.setImmediate(true);",This change is unhelpful: it precludes users from knowing which ports are being used for what purpose within the system.,What is the benefit of this change?
+5984,"@@ -5,7 +5,8 @@ class ApplicationController < ActionController::Base
+   private
+
+   def current_user
+-    User.find_by(email_address: session[:user]['email']) if session[:user].present?
++    # User.find_by(email_address: session[:user]['email']) if session[:user].present?
++    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
+   end
+
+   def signed_in?","Whoa, we weren't doing this before?? Derp.",Is this related?
+5985,"@@ -134,11 +134,16 @@ func (f *ofFlow) CopyToBuilder(priority uint16) FlowBuilder {
+
+ // ToBuilder returns a new FlowBuilder with all the contents of the original Flow.
+ func (f *ofFlow) ToBuilder() FlowBuilder {
+-	// TODO: use exported fields from ofFlow and remove nolint:govet
+-	flow := *f.Flow //nolint:govet
++	flow := &ofctrl.Flow{
++		Table:      f.Flow.Table,
++		CookieID:   f.Flow.CookieID,
++		CookieMask: f.Flow.CookieMask,
++		Match:      f.Flow.Match,
++	}
++	f.Flow.CopyActionsToNewFlow(flow)
+ 	newFlow := ofFlow{
+ 		table:    f.table,
+-		Flow:     &flow,
++		Flow:     flow,
+ 		matchers: f.matchers,
+ 		protocol: f.protocol,
+ 	}","I'm surprised we didn't go with something like `flow := f.Flow.Copy()` to take care of all the fields at once, but as long as it works it's good enough for me",nolint:govet: re
+5986,"@@ -467,7 +467,7 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane {
+ 	}
+
+ 	// TODO Integrate XDP and BPF infra.
+-	if !config.BPFEnabled && dp.xdpState == nil {
++	if !config.BPFEnabled && config.XDPEnabled && dp.xdpState == nil {
+ 		xdpState, err := NewXDPState(config.XDPAllowGeneric)
+ 		if err == nil {
+ 			if err := xdpState.WipeXDP(); err != nil {","We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart.",Why is the `conf
+5987,"@@ -5,7 +5,10 @@
+
+ package net.sourceforge.pmd.lang.java.ast;
+
+-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode {
++public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
++
++    QualifiedName qualifiedName;
++
+     public ASTAnnotationTypeDeclaration(int id) {
+         super(id);
+     }","I'd declare this field `qualifiedName` private to hide it. Unless it really needs to be modified from somewhere else... (e.g. unit tests..), but then, we should find a solution, where this field can stay private.",Unrelated to thi
+5988,"@@ -53,7 +53,18 @@ var (
+ 	_ introspection.IntrospectableOutbound = (*Outbound)(nil)
+ )
+
+-var defaultURLTemplate, _ = url.Parse(""http://localhost"")
++const http2AuthorityPseudoHeader = "":authority""
++
++var (
++	defaultURLTemplate, _ = url.Parse(""http://localhost"")
++	// from https://tools.ietf.org/html/rfc7540#section-8.1.2.3
++	http2PseudoHeaders = []string{
++		"":method"",
++		"":scheme"",
++		http2AuthorityPseudoHeader,
++		"":path"",
++	}
++)
+
+ // OutboundOption customizes an HTTP Outbound.
+ type OutboundOption func(*Outbound)","is this exhaustive? or rather, any psudo header started with `:` is un-parsable/invalid in HTTP/1 right?",Is there a reason we moved this from the `http2` package into the other packages?
+5989,"@@ -113,8 +113,10 @@ describe('Sessions', function () {
+
+           return client
+             .withSession(testCase.operation(client))
+-            .catch(() => expect(client.topology.s.sessionPool.sessions).to.have.length(1))
+-            .then(() => expect(client.topology.s.sessionPool.sessions).to.have.length(1))
++            .then(
++              () => expect(client.topology.s.sessionPool.sessions).to.have.length(1),
++              () => expect(client.topology.s.sessionPool.sessions).to.have.length(1)
++            )
+             .then(() => client.close())
+             .then(() => {
+               // verify that the `endSessions` command was sent",Is this change implying something or just seems fit b/c regardless of outcome the sessions should still be length 1?,This change catches an error that was previously reported by @peterjosling
+5990,"@@ -48,12 +48,15 @@ public class DiscoveryFragmentGenerator {
+
+     ApiaryConfig apiaryConfig = discovery.getConfig();
+
++    // TODO: Support multiple templates; don't hard-code the zero-index here.
++    Preconditions.checkArgument(configProto.getTemplatesCount() == 1);
+     DiscoveryLanguageProvider languageProvider =
+-        GeneratorBuilderUtil.createLanguageProvider(
+-            configProto.getLanguageProvider(),
++        GeneratorBuilderUtil.createClass(
++            configProto.getTemplates(0).getLanguageProvider(),
+             DiscoveryLanguageProvider.class,
+             new Class<?>[] {Service.class, ApiaryConfig.class},
+             new Object[] {discovery.getService(), apiaryConfig},
++            ""discovery language provider"",
+             new GeneratorBuilderUtil.ErrorReporter() {
+               @Override
+               public void error(String message, Object... args) {","Maybe throw an exception if there is more than one, so that discovering the lack of support is easier when someone tries to use it down the road.","Don't hardcode the 0-index here, instead fix it in the GeneratorBuilderUtil"
+5991,"@@ -85,8 +85,7 @@ Upcase::Application.routes.draw do
+       resource :trail, controller: ""exercise_trails"", only: [:show]
+     end
+
+-    get ""/new-languages"", to: ""marketing#new_languages""
+-    get ""/new-languages-thanks"", to: ""marketing#new_languages_thanks""
++    get ""/new-language-confirmation"", to: ""new_language_confirmations#index""
+     get '/pages/:id', to: 'high_voltage/pages#show', as: :page, format: false
+     get '/privacy', to: 'pages#show', as: :privacy, id: 'privacy'
+     get '/purchases/:lookup', to: 'pages#show', id: 'purchase-show'",Prefer single-quoted strings when you don't need string interpolation or special symbols.,Prefer single-quoted strings when you don't need string interpolation or special
+5992,"@@ -334,3 +334,11 @@ func NewGCPDialOptions(t *testing.T, recording bool, filename string) (opts []gr
+ 	}
+ 	return opts, done
+ }
++
++// RunTestsDependingOnDocker returns true when either:
++// 1) Not on Travis.
++// 2) On Travis Linux environment, where Docker is available.
++func RunTestsDependingOnDocker() bool {
++	s := os.Getenv(""TRAVIS_OS_NAME"")
++	return s == """" || s == ""linux""
++}","I feel the name of this function could be better, conveying it's a predicate. Something like `HasDockerTestEnvironment` or `CanRunLocalServerTests`, etc.","On Travis Linux environment, where Docker is available."
+5993,"@@ -30,14 +30,14 @@ func NewMonsterStorageClient(cc *grpc.ClientConn) MonsterStorageClient {
+ func (c *monsterStorageClient) Store(ctx context.Context, in *flatbuffers.Builder,
+ 	opts... grpc.CallOption) (* Stat, error) {
+   out := new(Stat)
+-  err := grpc.Invoke(ctx, ""/Example.MonsterStorage/Store"", in, out, c.cc, opts...)
++  err := grpc.Invoke(ctx, ""/MyGame.Example.MonsterStorage/Store"", in, out, c.cc, opts...)
+   if err != nil { return nil, err }
+   return out, nil
+ }
+
+ func (c *monsterStorageClient) Retrieve(ctx context.Context, in *flatbuffers.Builder,
+ 	opts... grpc.CallOption) (MonsterStorage_RetrieveClient, error) {
+-  stream, err := grpc.NewClientStream(ctx, &_MonsterStorage_serviceDesc.Streams[0], c.cc, ""/Example.MonsterStorage/Retrieve"", opts...)
++  stream, err := grpc.NewClientStream(ctx, &_MonsterStorage_serviceDesc.Streams[0], c.cc, ""/MyGame.Example.MonsterStorage/Retrieve"", opts...)
+   if err != nil { return nil, err }
+   x := &monsterStorageRetrieveClient{stream}
+   if err := x.ClientStream.SendMsg(in); err != nil { return nil, err }","This seems unrelated to your PR, how did this end up in here?",The convention is that these paths start with `/` and t
+5994,"@@ -143,7 +143,7 @@ public class InMemoryUserDetailsManager implements UserDetailsManager,
+ 	@Override
+ 	public UserDetails updatePassword(UserDetails user, String newPassword) {
+ 		String username = user.getUsername();
+-		MutableUserDetails mutableUser = this.users.get(username);
++		MutableUserDetails mutableUser = this.users.get(username.toLowerCase());
+ 		mutableUser.setPassword(newPassword);
+ 		return mutableUser;
+ 	}",Is `username` expected to be case insensitive?,`username.toLowerCase()` can be extracted to a variable
+5995,"@@ -18,16 +18,13 @@ import (
+ 	""testing""
+ 	""time""
+
+-	""github.com/iotexproject/iotex-core/pkg/util/fileutil""
+-
+-	""github.com/iotexproject/iotex-core/pkg/unit""
+-
+-	""github.com/iotexproject/iotex-core/test/identityset""
+-
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+
++	""github.com/iotexproject/iotex-core/pkg/util/fileutil""
++	""github.com/iotexproject/iotex-core/pkg/unit""
++	""github.com/iotexproject/iotex-core/test/identityset""
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""
+ 	""github.com/iotexproject/iotex-core/blockchain/genesis""",File is not `gofmt`-ed with `-s` (from `gofmt`),Why was this changed?
+5996,"@@ -37,9 +37,9 @@ import net.sourceforge.pmd.util.FileUtil;
+ import net.sourceforge.pmd.util.datasource.DataSource;
+
+ /**
+- *
+- *
++ * @deprecated use {@link TimeTracker} instead
+  */
++@Deprecated
+ public final class Benchmarker {
+
+     private static final Map<String, BenchmarkResult> BENCHMARKS_BY_NAME = new HashMap<>();","Is there any point to the deprecation? If someone was using these APIs, can they continue to do so in any meaningful fashion now that you've disconnected them from the PMD internals? Normally ""compiles but doesn't work"" is considered a bug.  ","""Use {@link TimeTracker} instead"""
+5997,"@@ -104,7 +104,7 @@ class CompletionView(QTreeView):
+     """"""
+
+     resize_completion = pyqtSignal()
+-    selection_changed = pyqtSignal(QItemSelection)
++    selection_changed = pyqtSignal(str)
+
+     def __init__(self, win_id, parent=None):
+         super().__init__(parent)",You can remove the `QItemSelection` import in this file now.,This signal is not raised by any
+5998,"@@ -11,12 +11,17 @@ namespace meta {
+
+ void ListSpacesProcessor::process(const cpp2::ListSpacesReq& req) {
+     UNUSED(req);
+-    guard_ = std::make_unique<std::lock_guard<std::mutex>>(
+-                                BaseProcessor<cpp2::ListSpacesResp>::lock_);
++    auto& spaceLock = LockUtils::spaceLock();
++    if (!spaceLock.try_lock_shared()) {
++        resp_.set_code(cpp2::ErrorCode::E_TABLE_LOCKED);
++        onFinished();
++        return;
++    }
+     auto prefix = MetaUtils::spacePrefix();
+     std::unique_ptr<kvstore::KVIterator> iter;
+     auto ret = kvstore_->prefix(kDefaultSpaceId_, kDefaultPartId_, prefix, &iter);
+     if (ret != kvstore::ResultCode::SUCCEEDED) {
++        spaceLock.unlock_shared();
+         resp_.set_code(to(ret));
+         onFinished();
+         return;",Use `std::shared_lock` and `std::try_to_lock_t`. BTW. Why we fail on contention?,Do we need to call `onFinished()`
+5999,"@@ -37,7 +37,10 @@ module.exports = function(config) {
+         new webpack.DefinePlugin({
+           ""process.env.NODE_ENV"": JSON.stringify(""test"")
+         })
+-      ]
++      ],
++      resolve: {
++        extensions: ["""", "".jsx"", "".js""]
++      }
+     },
+
+     webpackServer: {","Not sure what this actually does, but do you need to add `""""` here? Or does `["".jsx"", "".js""]` work too?","`extensions: ["".jsx"", "".js""]` is "
+6000,"@@ -8,6 +8,7 @@ package blockchain
+
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""io/ioutil""
+ 	""math/big""
+ 	""os""",let's group imports in the order: std third party first party,This import should go with the other iotexproject imports.
+6001,"@@ -1062,7 +1062,7 @@ public class JdbcExecutorLoaderTest {
+     return new JdbcExecutorLoader(props,
+         new CommonMetrics(new MetricsManager(new MetricRegistry())), null
+         , null, null, null, null,
+-        null, null);
++        null, null, null);
+   }
+
+   private boolean isTestSetup() {",So the tests run only when the db exists? Else everything passes?,Is this null check needed? It looks like you are not passi
+6002,"@@ -0,0 +1,12 @@
++package bytesink
++
++import ""io""
++
++// ByteSink represents a location to which bytes can be written. The ByteSink
++// should be closed after all bytes have been written.
++type ByteSink interface {
++	io.Writer
++	io.Closer
++	Open() error
++	ID() string
++}","`Remove` is unclear. It seems the point is to allow the `FifoByteSink` to delete the underlying file. There seems to be an implicit contract that consumers of this interface call `Remove` after `Close` without necessarily understanding what `Remove` does. I get that it's a little awkward to have `FifoByteSink` delete the file in `Close`. It would probably be best to just remove this from the interface, since `AddSink` is working with an actual `FifoByteSink`. I would rename it in `FifoByteSync` to `DeleteFile` or `Cleanup` or something that's makes it more clear what's being removed.",Why `io.Writer` and not just `io.Writer`?
+6003,"@@ -0,0 +1,13 @@
++package core
++
++import (
++	""math/big""
++
++	""github.com/filecoin-project/go-filecoin/types""
++)
++
++type Ask struct {
++	Price *big.Int
++	Size  *big.Int
++	Miner types.Address
++}",Mentioned elsewhere but repeating again: would be nice to have units (ideally `Size *Bytes`).,Why is this in the cli? Ask is very confusing.
+6004,"@@ -269,7 +269,7 @@ describe ""Bolt::CLI"" do
+         cli.execute(cli.parse)
+       end
+
+-      it 'install modules from Puppetfile with resolving' do
++      it 'install modules from Puppetfile without resolving' do
+         cli = Bolt::CLI.new(%W[module install --project #{project} --no-resolve])
+
+         allow(installer).to receive(:install) do |*args|","I think a test in `spec/integration` might help keep this file a bit more manageable, especially since we're just checking file contents and errors. But basically the same idea!","I'm not sure if this is correct, but I changed it to make sure it fails when the `--no-resolve` option is used."
+6005,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)","If we no longer need `chromeOptions`, should we just delete the option entirely?"
+6006,"@@ -1105,7 +1105,8 @@ instr_set_label_callback(instr_t *instr, instr_label_callback_t cb)
+ {
+     CLIENT_ASSERT(instr_is_label(instr),
+                   ""only set callback functions for label instructions"");
+-    CLIENT_ASSERT(instr->label_cb == NULL, ""label callback function is already set"");
++    CLIENT_ASSERT(instr->label_cb == NULL || cb == NULL,
++                  ""label callback function is already set"");
+     CLIENT_ASSERT(!TEST(INSTR_RAW_BITS_ALLOCATED, instr->flags),
+                   ""instruction's raw bits occupying label callback memory"");
+     instr->label_cb = cb;","So this means that we can remove a callback via instr_set_label_callback(). Maybe consider adding another API function for removal, and add a new assert here such that cb != NULL?","Shouldn't this be ""or"" instead of ""instr""?"
+6007,"@@ -30,7 +30,9 @@
+
+   <p><%= _(""Last modified: "") + l(@plan.updated_at.to_date, formats: :short) %></p> <br>
+
+-  <p><%= _(""Copyright information:"") %></p>
+-  <div style=""margin-left: 15px;""><p><%= _("" The above plan creator(s) have agreed that others may use as much of the text of this plan as they would like in their own plans, and customise it as necessary. You do not need to credit the creator(s) as the source of the language used, but using any of the plan's text does not imply that the creator(s) endorse, or have any relationship to, your project or proposal"") %></p></div>
++  <% if @public_plan %>
++    <p><%= _(""Copyright information:"") %></p>
++    <div style=""margin-left: 15px;""><p><%= _("" The above plan creator(s) have agreed that others may use as much of the text of this plan as they would like in their own plans, and customise it as necessary. You do not need to credit the creator(s) as the source of the language used, but using any of the plan's text does not imply that the creator(s) endorse, or have any relationship to, your project or proposal"") %></p></div>
++  <% end %>
+ </div>
+ <hr class=""bottom"" />",why are we using an instance variable instead of accessing the visibility method?,You can remove this `if @public_plan` block altogether. The default for the `_()` string is `Copyright informat
+6008,"@@ -173,6 +173,7 @@ func (h *HTTPTransport) NewTransport(ctx caddy.Context) (*http.Transport, error)
+ 		dialer.Resolver = &net.Resolver{
+ 			PreferGo: true,
+ 			Dial: func(ctx context.Context, _, _ string) (net.Conn, error) {
++				//nolint:gosec
+ 				addr := h.Resolver.netAddrs[weakrand.Intn(len(h.Resolver.netAddrs))]
+ 				return d.DialContext(ctx, addr.Network, addr.JoinHostPort(0))
+ 			},",Ok. Can we just disable this linter?,Why is this `nolint:gosec`?
+6009,"@@ -6,7 +6,7 @@ from listenbrainz import config
+ from listenbrainz import db
+
+ ADMIN_SQL_DIR = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..','admin', 'sql')
+-TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'test_data')
++TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', 'testdata')
+
+
+ class DatabaseTestCase(unittest.TestCase):","this is `test_data` and all other instances are `testdata` - does this change affect any test files, or are there actually no directories called `test_data` in the repo? (I just checked, it seems like there aren't...)",This shouldn't need to be c
+6010,"@@ -48,10 +48,6 @@ public class ApiVersionStrings {
+         return getBasePath() + ""/chatter/"";
+     }
+
+-    public static String getBaseConnectPath() {
+-        return getBasePath() + ""/connect/"";
+-    }
+-
+     public static String getBaseSObjectPath() {
+         return getBasePath() + ""/sobjects/"";
+     }",Fixing `lint` warnings that have existed for a while.,was this just unused?
+6011,"@@ -24,4 +24,9 @@ const (
+ 	// EnvKeyForInstallConfigName is the environment variable to get the
+ 	// the install config's name
+ 	EnvKeyForInstallConfigName InstallENVKey = ""OPENEBS_IO_INSTALL_CONFIG_NAME""
++	// CASDefaultCstorPoolENVK is the ENV key that specifies wether default cstor pool
++	// should be configured or not
++	// If value is ""true"", default cstor pool will be configured else for ""false""
++	// it will not be configured.
++	CASDefaultCstorPool InstallENVKey = ""OPENEBS_IO_INSTALL_DEFAULT_CSTOR_SPARSE_POOL""
+ )",Better to rename this to CASDefaultCstorSparsePool.,I think the typo here shoul
+6012,"@@ -105,4 +105,9 @@ public class S3FileIO implements FileIO {
+     this.awsClientFactory = AwsClientFactories.from(properties);
+     this.s3 = awsClientFactory::s3;
+   }
++
++  @Override
++  public void close() {
++    client().close();
++  }
+ }","Since we'e not 100% sure if `close` will be called more than once, should we set `client` to `null` or add an `AtomicBoolean closed` that will then handle the idempotency issue?",I wonder if we should have a `close()` method on the `AwsClient` so we have a clean way to call the close method on the `AwsClient`
+6013,"@@ -379,11 +379,15 @@ Intersection MotorwayHandler::fromRamp(const EdgeID via_eid, Intersection inters
+             //
+             //     7         1
+             //          0
++            const auto &first_intersection_name =
++                name_table.GetNameForID(first_intersection_data.name_id).to_string();
++            const auto &second_intersection_name =
++                name_table.GetNameForID(second_intersection_data.name_id).to_string();
+             if (intersection[1].entry_allowed)
+             {
+                 if (isMotorwayClass(intersection[1].eid, node_based_graph) &&
+-                    second_intersection_data.name_id != EMPTY_NAMEID &&
+-                    first_intersection_data.name_id != EMPTY_NAMEID && first_second_same_name)
++                    !second_intersection_name.empty() && !first_intersection_name.empty() &&
++                    first_second_same_name)
+                 {
+                     // circular order indicates a merge to the left (0-3 onto 4
+                     if (angularDeviation(intersection[1].angle, STRAIGHT_ANGLE) <",And here - what happens if name id is invalid,"`second_intersection_name.empty()` is enough, no need to use `!first_intersection_name.empty()`"
+6014,"@@ -0,0 +1,18 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Bolt\Storage\Query\Directive;
++
++use Bolt\Storage\Query\QueryInterface;
++
++/**
++ *  Directive a raw output of the generated query.
++ */
++class PrintQueryDirective
++{
++    public function __invoke(QueryInterface $query): void
++    {
++        echo $query;
++    }
++}",__toString() is not a part of QueryInterface,Please rename this to `QueryOutputDirective`
+6015,"@@ -43,7 +43,7 @@ from typing import (
+     cast,
+     TYPE_CHECKING,
+ )
+-
++import datetime
+ import numpy as np
+ import pandas as pd
+ from pandas.api.types import is_list_like, is_dict_like, is_scalar",nit: Could you add an empty line between `import datetime` (built-in library block) and `import numpy as np` (third-party library block)?,Please add a newline after this to separate the standard library imports.
+6016,"@@ -1284,6 +1284,8 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_TYPE_NAME_MAP{
+   {""CUDA_ERROR_INVALID_PC"",                                            {""hipErrorInvalidPc"",                                        """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 718
+   // cudaErrorLaunchFailure
+   {""CUDA_ERROR_LAUNCH_FAILED"",                                         {""hipErrorLaunchFailure"",                                    """", CONV_NUMERIC_LITERAL, API_DRIVER}}, // 719
++  // cudaErrorCooperativeLaunchTooLarge
++  {""CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE"",                          {""hipErrorCooperativeLaunchTooLarge"",                        """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 720
+   // cudaErrorNotPermitted
+   {""CUDA_ERROR_NOT_PERMITTED"",                                         {""hipErrorNotPermitted"",                                     """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 800
+   // cudaErrorNotSupported",Please remove `HIP_UNSUPPORTED`,Can you add the error Cooperative_LAUNCH_TOO_LARGE to API_HIP_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE
+6017,"@@ -30,13 +30,17 @@ import { STORE_NAME as CORE_USER } from '../googlesitekit/datastore/user/constan
+ /**
+  * Gets the current dateRange string.
+  *
+- * @param {string} [dateRange] Optional. The date range slug.
++ * @param {string} [dateRange]      Optional. The date range slug.
++ * @param {boolean} [returnNumber]  Optional. If true, returns the number only.
+  * @return {string} the date range string.
+  */
+-export function getCurrentDateRange( dateRange = getCurrentDateRangeSlug() ) {
++export function getCurrentDateRange( dateRange = getCurrentDateRangeSlug(), returnNumber = false ) {
+ 	const daysMatch = dateRange.match( /last-(\d+)-days/ );
+
+ 	if ( daysMatch && daysMatch[ 1 ] ) {
++		if ( returnNumber ) {
++			return parseInt( daysMatch[ 1 ], 10 );
++		}
+ 		return sprintf(
+ 			/* translators: %s: Number of days matched. */
+ 			_n( '%s day', '%s days', parseInt( daysMatch[ 1 ], 10 ), 'google-site-kit' ),","Having boolean parameters to change function behavior is not a good practice because it violates the principle of functions being responsible for a single task, so the need for this indicates we need to split something out of here instead. We can introduce a function like `getCurrentDateRangeDayCount` or similar, which does this.",Instead of `returnNumber` can we call it `includeNumber` or something of that sort?
+6018,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?,`await driver.stop()` is now unnecessary because `driver.get()` will return the next page source
+6019,"@@ -39,17 +39,9 @@ type (
+ 		GetContractState(hash.PKHash, hash.Hash32B) (hash.Hash32B, error)
+ 		SetContractState(hash.PKHash, hash.Hash32B, hash.Hash32B) error
+ 		// Accounts
+-		Balance(string) (*big.Int, error)
+-		AccountState(string) (*Account, error)
+ 		RootHash() hash.Hash32B
+ 		Version() uint64
+ 		Height() uint64
+-		WorkingCandidates() map[hash.PKHash]*Candidate
+-		GetCandidates(height uint64) (CandidateList, error)
+-
+-		State(hash.PKHash, State) (State, error)
+-		CachedState(hash.PKHash, State) (State, error)
+-		PutState(hash.PKHash, State) error
+ 	}
+
+ 	// workingSet implements Workingset interface, tracks pending changes to account/contract in local cache","savedStates is for confirmed states, not needed in working set",why remove these?
+6020,"@@ -23,6 +23,9 @@ import (
+ 	""github.com/mysteriumnetwork/node/market""
+ )
+
++// ServiceType indicates ""wireguard"" service type
++const ServiceType = ""wireguard""
++
+ // Bootstrap is called on program initialization time and registers various deserializers related to wireguard service
+ func Bootstrap() {
+ 	market.RegisterServiceDefinitionUnserializer(",Why should we move it into `bootstrap.go` file?,This should be part of the `network` package maybe?
+6021,"@@ -24,8 +24,15 @@ const fontSizes = [
+   72
+ ]
+
++const measures = [
++  24,
++  32,
++  48
++]
++
+ module.exports = {
+   breakpoints,
+   space,
+   fontSizes,
++  measures
+ }","In the next major version, I plan on changing the em-unit breakpoints to be pixel values to keep everything consistent. Would be great to handle this with pixels as well, but still allow em-units to be defined with a string",might be worth adding a dev().assert(!Array.isArray
+6022,"@@ -151,7 +151,7 @@ class TabWidget(QTabWidget):
+
+         fields = self.get_tab_fields(idx)
+         fields['current_title'] = fields['current_title'].replace('&', '&&')
+-        fields['index'] = idx + 1
++        fields['index'] = str(idx + 1).rjust(2)
+
+         title = '' if fmt is None else fmt.format(**fields)
+         tabbar = self.tabBar()","I don't think this will actually align the indexes, if you have > 100 tabs, the tabs over 100 will be misaligned. In addition with less than 10 tabs, there will be a pointless space.",what is the rationale behind this change?
+6023,"@@ -326,7 +326,7 @@ func (v4 *signer) buildCanonicalHeaders(r rule, header http.Header) {
+ 			headerValues[i] = ""host:"" + v4.Request.URL.Host
+ 		} else {
+ 			headerValues[i] = k + "":"" +
+-				strings.Join(v4.Request.Header[http.CanonicalHeaderKey(k)], "","")
++				strings.Join(v4.signedHeaderVals[k], "","")
+ 		}
+ 	}
+ ","hrm, unsigned headers now won't be included.",Does this mean that the `v4.signedHeaderVals` in `v
+6024,"@@ -53,6 +53,7 @@ class CategoryCode
+      */
+     public static function isValid(string $value): bool
+     {
+-        return strlen($value) <= 255;
++        return '' !== $value
++            && strlen($value) < 256;
+     }
+ }",what if `$value = ' ' `?,Shouldn't this be `'' === $value`?
+6025,"@@ -262,10 +262,16 @@ class SparkWrite {
+   private class DynamicOverwrite extends BaseBatchWrite {
+     @Override
+     public void commit(WriterCommitMessage[] messages) {
++      Iterable<DataFile> files = files(messages);
++      if (Iterables.size(files) == 0) {
++        LOG.info(""Dynamic overwrite is empty, skipping commit"");
++        return;
++      }
++
+       ReplacePartitions dynamicOverwrite = table.newReplacePartitions();
+
+       int numFiles = 0;
+-      for (DataFile file : files(messages)) {
++      for (DataFile file : files) {
+         numFiles += 1;
+         dynamicOverwrite.addFile(file);
+       }",What about using `!files.hasNext` instead? I'm not sure we want to assume that the iterable can be consumed multiple times. Plus there's no need to consume the entire iterable just to check whether it is empty.,"IMHO, this should be an error leve"
+6026,"@@ -85,6 +85,11 @@ Container* Container::getParentContainer()
+ 	return thing->getContainer();
+ }
+
++std::string Container::getName() const {
++	const ItemType& it = items[id];
++	return getNameDescription(it, this, -1, false);
++}
++
+ bool Container::hasParent() const
+ {
+ 	return getID() != ITEM_BROWSEFIELD && dynamic_cast<const Player*>(getParent()) == nullptr;",I think we could add bool addArticle here defaulted to false like its done in item class so std::string Container::getName(bool addArticle /* = false*/) const { and pass that variable to getNameDescription call,`std::string & name = items[id];`
+6027,"@@ -47,11 +47,11 @@ public class LockableBottomSheetBehavior<V extends View> extends ViewPagerBottom
+
+     @Override
+     public boolean onStartNestedScroll(CoordinatorLayout coordinatorLayout, V child, View directTargetChild,
+-                                       View target, int nestedScrollAxes) {
++                                       View target, int axes, int type) {
+         boolean handled = false;
+
+         if (!isLocked) {
+-            handled = super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, nestedScrollAxes);
++            handled = super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, axes, type);
+         }
+
+         return handled;",What if a library function on the outside still calls the old method? It is then no longer blocked properly. Have you tested the change?,What is the reasoning behind switc
+6028,"@@ -197,11 +197,15 @@ static mrb_value build_app_response(struct st_mruby_subreq_t *subreq)
+     return resp;
+ }
+
+-static void append_bufs(struct st_mruby_subreq_t *subreq, h2o_iovec_t *inbufs, size_t inbufcnt)
++static void append_bufs(struct st_mruby_subreq_t *subreq, h2o_sendvec_t *inbufs, size_t inbufcnt)
+ {
+-    int i;
++    size_t i;
+     for (i = 0; i != inbufcnt; ++i) {
+-        h2o_buffer_append(&subreq->buf, inbufs[i].base, inbufs[i].len);
++        char *dst = h2o_buffer_reserve(&subreq->buf, inbufs[i].len).base;
++        assert(dst != NULL && ""no memory or disk space; FIXME bail out gracefully"");
++        if (!(*inbufs[i].fill_cb)(&subreq->super, h2o_iovec_init(dst, inbufs[i].len), inbufs + i, 0))
++            h2o_fatal(""FIXME handle error from pull handler"");
++        subreq->buf->size += inbufs[i].len;
+     }
+ }
+ ","@i110 Do you have an idea on how we should propagate errors that occur in this block? The error condition happens when i) `h2o_buffer_reserve` fails to allocate space (happens in master as well), or ii) `fill_cb` returns an error (unique to this PR).",Probably we should also add an error log here to notify the user that we failed to free the memory.
+6029,"@@ -3,7 +3,7 @@ class ReportMailer < ApplicationMailer
+
+   def budget_status
+     to_email = ENV.fetch('BUDGET_REPORT_RECIPIENT')
+-    date = Time.now.in_time_zone('Eastern Time (US & Canada)').strftime(""%a %m/%d/%y"")
++    date = Time.now.utc.strftime(""%a %m/%d/%y (%Z)"")
+
+     mail(
+       to: to_email,",Does this mean the times will show up in emails as UTC?,I think this should be `Time.zone.at(0)` instead of `Time.now.utc`.
+6030,"@@ -191,11 +191,10 @@ options.Bounds = Options('style', color='black')
+ options.Ellipse = Options('style', color='black')
+ options.Polygons = Options('style', color=Cycle(), line_color='black',
+                            cmap=dflt_cmap)
+-options.Rectangles = Options('style', cmap=dflt_cmap)
+-options.Segments = Options('style', cmap=dflt_cmap)
+
+ # Geometries
+-options.Rectangles = Options('style', line_color='black')
++options.Rectangles = Options('style', color=Cycle(), cmap=dflt_cmap, line_color='black')
++options.Segments = Options('style', color='black', cmap=dflt_cmap)
+
+ # Rasters
+ options.Image = Options('style', cmap=config.default_gridded_cmap)",What's the motivation for having one of these be a cycle and the other be a fixed color?,This change seems unrelated to the rest of the PR.
+6031,"@@ -136,7 +136,7 @@ namespace ResultsComparer
+
+             var table = data.ToMarkdownTable().WithHeaders(conclusion.ToString(), conclusion == EquivalenceTestConclusion.Faster ? ""base/diff"" : ""diff/base"", ""Base Median (ns)"", ""Diff Median (ns)"", ""Modality"");
+
+-            foreach (var line in table.ToMarkdown().Split(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries))
++            foreach (var line in table.ToMarkdown().Split(Environment.NewLine))
+                 Console.WriteLine($""| {line.TrimStart()}|""); // the table starts with \t and does not end with '|' and it looks bad so we fix it
+
+             Console.WriteLine();",What will be an empty entry now?,"`StringSplitOptions.RemoveEmptyEntries` was a mistake, the intent was to remove all the empty entri"
+6032,"@@ -71,6 +71,10 @@ export class ManualColumnResize extends BasePlugin {
+     addClass(this.guide, 'manualColumnResizerGuide');
+   }
+
++  get inlineDir() {
++    return this.hot.isRtl() ? 'right' : 'left';
++  }
++
+   /**
+    * Checks if the plugin is enabled in the handsontable settings. This method is executed in {@link Hooks#beforeInit}
+    * hook and if it returns `true` than the {@link ManualColumnResize#enablePlugin} method is called.",Can I ask you to add jsdoc tag that would mark the prop as `@private`?,why is it inline now?
+6033,"@@ -113,3 +113,13 @@ func WriteFile(fromFile io.Reader, to string, mode os.FileMode) error {
+ 	// And move it to its final destination.
+ 	return os.Rename(tempFile.Name(), to)
+ }
++
++// IsDirectory checks if a given path is a directory
++func IsDirectory(path string) bool {
++	info, err := os.Stat(path)
++	if err != nil {
++		return false
++	}
++
++	return info.IsDir()
++}",Do you need this? Don't think you use it?,`os.Stat` can return
+6034,"@@ -0,0 +1,13 @@
++package com.fsck.k9.widget.list;
++
++
++import android.content.Intent;
++import android.widget.RemoteViewsService;
++
++
++public class MessageListWidgetService extends RemoteViewsService {
++    @Override
++    public RemoteViewsFactory onGetViewFactory(Intent intent) {
++        return new MessageListRemoteViewFactory(this.getApplicationContext());
++    }
++}",`this.` seems unnecessary,I don't see the point
+6035,"@@ -244,8 +244,8 @@ def connect_to_service(service_name, client=True, env=None, region_name=None, en
+                 endpoint_url = backend_url
+         config = config or botocore.client.Config()
+         # configure S3 path style addressing
+-        if service_name == 's3':
+-            config.s3 = {'addressing_style': 'path'}
++        # if service_name == 's3':
++        #     config.s3 = {'addressing_style': 'path'}
+         # To, prevent error ""Connection pool is full, discarding connection ..."",
+         # set the environment variable MAX_POOL_CONNECTIONS. Default is 150.
+         config.max_pool_connections = MAX_POOL_CONNECTIONS",nit: can be removed before merging...,I think we can remove
+6036,"@@ -2,7 +2,7 @@ describe('ContextMenu', function () {
+   var id = 'testContainer';
+
+   beforeEach(function () {
+-    this.$container = $('<div id=""' + id + '""></div>').appendTo('body');
++    this.$container = $(`<div id=""${id}""></div>`).appendTo('body');
+   });
+
+   afterEach(function () {",Maybe a single quote would be compatible with airbnb style.,What's the point of this change?
+6037,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+
+   public abstract void remove(SessionId id);
+
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.,Why not `remove(Id)`?
+6038,"@@ -279,11 +279,9 @@ func TestFormatWithComments(t *testing.T) {
+
+ 	if want := `// hi
+ // there
+-{
+-    _time: r._time,
+-    io_time: r._value,
+-// this is the end
+-}
++{_time: r._time, io_time: r._value
++    // this is the end
++    }
+
+ // minimal
+ foo = (arg=[1, 2]) => 1","@Marwes @wolffcm This is the file where I made a change the the expected output. Its a little bit weird, but I think that the final output makes sense for the most part.",as far as I can tell `r._value`
+6039,"@@ -94,9 +94,11 @@ func IsValidAppType(apptype string) bool {
+ func (app *DdevApp) CreateSettingsFile() (string, error) {
+ 	app.SetApptypeSettingsPaths()
+
+-	// If neither settings file options are set, then don't continue
++	// If neither settings file options are set, then don't continue. Return
++	// a nil error because this should not halt execution if the apptype
++	// does not have a settings definition.
+ 	if app.SiteLocalSettingsPath == """" && app.SiteSettingsPath == """" {
+-		return """", fmt.Errorf(""Neither SiteLocalSettingsPath nor SiteSettingsPath is set"")
++		return """", nil
+ 	}
+
+ 	// Drupal and WordPress love to change settings files to be unwriteable.",I think we probably need a util.Warning() here.,Shouldn't this be `app.SiteLocal
+6040,"@@ -0,0 +1,19 @@
++from quilt3.util import PhysicalKey, get_from_config, fix_url
++
++from .base import PackageRegistry
++from .local import LocalPackageRegistryV1
++from .s3 import S3PackageRegistryV1
++
++
++def get_package_registry(path=None) -> PackageRegistry:
++    """""" Returns the package registry for a given path """"""
++    # TODO: Don't check if it's PackageRegistry? Then we need better separation
++    #       to external functions that receive string and internal that receive
++    #       PackageRegistry.
++    if isinstance(path, PackageRegistry):
++        return path
++    if not isinstance(path, PhysicalKey):
++        path = PhysicalKey.from_url(
++            get_from_config('default_local_registry') if path is None else fix_url(path)
++        )
++    return (LocalPackageRegistryV1 if path.is_local() else S3PackageRegistryV1)(path)","Let's make have a signature that's consistent with `PhysicalKey.from_path`. Users should also have access to PhysicalKey since that class is part of the API (e.g., `Package.resolve_hash`).",Shouldn't it be `from .local import LocalPackageRegistryV1`?
+6041,"@@ -0,0 +1,10 @@
++/*eslint no-unused-vars: 0*/
++/* exported utils */
++
++/**
++ * Namespace for imports which holds globals of external dependencies.
++ * @namespace imports
++ * @memberof axe
++ */
++
++var imports = (axe.imports = {});",What is this directive for?,What's the point of this?
+6042,"@@ -155,6 +155,10 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+                   'if a key is present or a default if not, is simpler and considered '
+                   'more idiomatic, although sometimes a bit slower'
+                  ),
++        'R1716': ('simplify chained comparison',
++                  'chained-comparison',
++                  'Chained comparisons like ""a < b and b < c"" can be simplified as ""a < b < c""',
++                  ),
+     }
+     options = (('max-nested-blocks',
+                 {'default': 5, 'type': 'int', 'metavar': '<int>',",I'd rephrase it as `Simplify chained comparison between the operands`.,Could you also add a period at the end of the sentence?
+6043,"@@ -296,11 +296,10 @@ class ProductDataFixture
+         $this->clearResources();
+         $this->productsByCatnum = [];
+
+-        $onlyForFirstDomain = false;
+         $this->productDataReferenceInjector->loadReferences(
+             $this->productDataFixtureLoader,
+             $this->persistentReferenceFacade,
+-            $onlyForFirstDomain
++            2
+         );
+     }
+ ","so in the performance data fixtures, there will be references for the second domain only?",Why did you change this?
+6044,"@@ -304,7 +304,7 @@ public class DefaultGridRegistry extends BaseGridRegistry implements GridRegistr
+     if (proxy == null) {
+       return;
+     }
+-    LOG.info(""Registered a node "" + proxy);
++    LOG.finest(""Registered a node "" + proxy);
+     try {
+       lock.lock();
+ ",This is wildly unhelpful to users --- they need to know when a proxy has been registered.,Would be good to keep this at info level if possible.
+6045,"@@ -203,7 +203,7 @@ class ClientPlayback:
+             # https://github.com/mitmproxy/mitmproxy/issues/2197
+             if hf.request.http_version == ""HTTP/2.0"":
+                 hf.request.http_version = ""HTTP/1.1""
+-                host = hf.request.headers.pop("":authority"")
++                host = hf.request.headers.pop("":authority"", hf.request.pretty_host)
+                 hf.request.headers.insert(0, ""host"", host)
+             self.q.put(hf)
+         ctx.master.addons.trigger(""update"", lst)","If there is no authority header (i.e. someone intentionally deleted it), I would argue we probably don't want a Host header in the replay either. How about we only add it if it exists, and do nothing otherwise?",does `hf.request.pretty_host` always exist? do we wan
+6046,"@@ -65,12 +65,7 @@ func TaskMetadataHandler(state dockerstate.TaskEngineState, ecsClient api.ECSCli
+ 			for _, containerResponse := range taskResponse.Containers {
+ 				networks, err := GetContainerNetworkMetadata(containerResponse.ID, state)
+ 				if err != nil {
+-					errResponseJSON, err := json.Marshal(err.Error())
+-					if e := utils.WriteResponseIfMarshalError(w, err); e != nil {
+-						return
+-					}
+-					utils.WriteJSONToResponse(w, http.StatusInternalServerError, errResponseJSON, utils.RequestTypeContainerMetadata)
+-					return
++					seelog.Warnf(""Error retrieving network metadata for container %s - %s"", containerResponse.ID, err)
+ 				}
+ 				containerResponse.Networks = networks
+ 				responses = append(responses, containerResponse)",is there any unit test that can be updated to verify this?,We should at least log the error message here so the
+6047,"@@ -418,7 +418,18 @@ static int cb_lua_filter(const void *data, size_t bytes,
+         lua_pushstring(ctx->lua->state, tag);
+         lua_pushnumber(ctx->lua->state, ts);
+         lua_pushmsgpack(ctx->lua->state, p);
+-        lua_call(ctx->lua->state, 3, 3);
++        if (ctx->protected_mode) {
++            ret = lua_pcall(ctx->lua->state, 3, 3, 0);
++            if (ret != 0) {
++                flb_plg_error(ctx->ins, ""error code %d: %s"",
++                              ret, lua_tostring(ctx->lua->state, -1));
++                lua_pop(ctx->lua->state, 1);
++                return FLB_FILTER_NOTOUCH;
++            }
++        }
++        else {
++            lua_call(ctx->lua->state, 3, 3);
++        }
+
+         /* Initialize Return values */
+         l_code = 0;","exiting at this point is leaking memory, take a look at the valgrind output. the sbuffer must be destroyed.",You need to do this with `lua_pushstring` or `lua_pop
+6048,"@@ -0,0 +1,13 @@
++def pytest_addoption(parser):
++    parser.addoption(
++        '--poppler',
++        action='store_true',
++        dest='poppler',
++        default=False,
++        help=""Indicates poppler tools (incl. pdftoppm) installed""
++    )
++
++
++def pytest_configure(config):
++    if not config.option.poppler:
++        setattr(config.option, 'markexpr', 'not poppler')",i think you want a different flag and help like `--ffmpeg` or something; and you need to mark any tests you want skipped,"Should this be `parser.addoption('--poppler', action='store_true', default=False)`?"
+6049,"@@ -32,9 +32,10 @@ import (
+ 	""github.com/golang/protobuf/proto""
+ 	""github.com/golang/protobuf/ptypes""
+ 	""github.com/golang/protobuf/ptypes/empty""
+-	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
+ 	auditpb ""google.golang.org/genproto/googleapis/cloud/audit""
+ 	logpb ""google.golang.org/genproto/googleapis/logging/v2""
++
++	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
+ )
+
+ const (",this needed to change? or it was just some formatting thing?,@deads2k any reason you had to move this?
+6050,"@@ -278,10 +278,11 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+     params.add(""--auto-log-bloom-caching-enabled"");
+     params.add(""false"");
+
+-    String level = System.getProperty(""root.log.level"");
+-    if (level != null) {
+-      params.add(""--logging="" + level);
+-    }
++    // String level = System.getProperty(""root.log.level"");
++    // if (level != null) {
++    //  params.add(""--logging="" + level);
++    // }
++    params.add(""--logging=TRACE"");
+
+     LOG.info(""Creating besu process with params {}"", params);
+     final ProcessBuilder processBuilder =","What's the advantage of doing it this way over, say, changing the `.circleci/config.yaml` to have `TRACE` as the `root.log.level`?",Please remove the code if not needed.
+6051,"@@ -49,6 +49,15 @@ class ApiClient(object):
+             dataset_id (str): id of the dataset to query.
+         """"""
+
++    @abc.abstractmethod
++    def fetch_bigquery_iam_policy(self, project_number, dataset_id):
++        """"""Gets IAM policy if a bigquery dataset from gcp API call.
++
++        Args:
++            project_number (str): number of the project to query.
++            dataset_id (str): id of the dataset to query.
++        """"""
++
+     @abc.abstractmethod
+     def iter_bigquery_datasets(self, project_number):
+         """"""Iterate Datasets from GCP API.",typo: if -> of,Update the docstring to reflect the new parameter order.
+6052,"@@ -270,7 +270,10 @@ func (templateContext) funcMarkdown(input interface{}) (string, error) {
+ 	buf.Reset()
+ 	defer bufPool.Put(buf)
+
+-	md.Convert([]byte(inputStr), buf)
++	err := md.Convert([]byte(inputStr), buf)
++	if err != nil {
++		return """", err
++	}
+
+ 	return buf.String(), nil
+ }",It'll be interesting to see who or what this breaks...,The `defer` should be moved before the err check so only the error is lost if there is an error.
+6053,"@@ -96,7 +96,7 @@ public class InternalSelenseTestBase extends SeleneseTestBase {
+       return;
+     }
+
+-    log.info(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
++    log.finest(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
+
+     Path dir =
+       InProject.locate(""java/client/build/production/com/thoughtworks/selenium/webdriven"");",This change is incorrect: the current log level is correct.,This should not be part of this PR
+6054,"@@ -58,7 +58,7 @@ type clientFactory struct {
+
+ // NewClientFactory creates a new ClientFactory
+ func NewClientFactory() ClientFactory {
+-	logger := log.NewDefaultLogger()
++	logger := log.NewTestLogger()
+
+ 	return &clientFactory{
+ 		logger: logger,",There are few cases like this where default logger is used from CLI/db tools. I would copy `NewTestLogger` to `NewCLILogger` and use it everywhere in CLI. In future these two might be different.,Why was this changed?
+6055,"@@ -222,4 +222,16 @@ public abstract class AbstractAuthenticationToken implements Authentication,
+
+ 		return sb.toString();
+ 	}
++
++	protected static Integer extractKeyHash(String key) {
++		Object value = nullSafeValue(key);
++		return value.hashCode();
++	}
++
++	protected static Object nullSafeValue(Object value){
++		if(value == null || """".equals(value)) {
++			throw new IllegalArgumentException(""Cannot pass null or empty values to constructor"");
++		}
++		return value;
++	}
+ }","While it provides re-use, this method does not make sense in `AbstractAuthenticationToken` because it knows nothing of a hash key. Instead, we should move this to a private method within each subclass.",missing spaces between `)` and `{`
+6056,"@@ -322,7 +322,7 @@ def extract_record_set(records, filters, sorting,
+         paginated = {}
+         for rule in pagination_rules:
+             values = apply_filters(filtered, rule)
+-            paginated.update(((x[id_field], x) for x in values))
++            paginated.update((id(x), x) for x in values)
+         paginated = paginated.values()
+     else:
+         paginated = filtered",index by memory address? I realize I don't understand why we don't just build a list :),The generated code does not use `id_field` anymore.
+6057,"@@ -7,6 +7,7 @@ import db.user
+
+ user_bp = Blueprint(""user"", __name__)
+
++
+ @user_bp.route(""/lastfmscraper/<user_id>.js"")
+ @crossdomain()
+ def lastfmscraper(user_id):","Not part of this commit, but we thought that this may not be a good place for this url, as it is in the `/user/` namespace (effectively preventing us having a user called `lastfmscraper`, however rare it may be)",nit: We don't need this blank line here.
+6058,"@@ -25,6 +25,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+         internal const string HttpContextKey = ""__Datadog.Trace.ClrProfiler.Integrations.AspNetMvcIntegration"";
+
+         private const string OperationName = ""aspnet-mvc.request"";
++        private const string ChildActionOperationName = ""aspnet-mvc.request.child-action"";
+
+         private const string RouteCollectionRouteTypeName = ""System.Web.Mvc.Routing.RouteCollectionRoute"";
+ ",Does not appear to be used.,Should this be called `aspnet-mvc.request.child-act
+6059,"@@ -0,0 +1,15 @@
++test_name ""C100546: bolt command run should execute command on remote hosts\
++           via ssh"" do
++  step ""execute `bolt command run` via SSH"" do
++    ssh_nodes = select_hosts(roles: ['ssh'])
++    nodes_csv = ssh_nodes.map(&:hostname).join(',')
++    command = 'hostname -f'
++    bolt_command = ""bolt command run --nodes #{nodes_csv} '#{command}'""
++    case bolt['platform']
++    when /windows/
++      execute_powershell_script_on(bolt, bolt_command)
++    else
++      on(bolt, bolt_command)
++    end
++  end
++end","I think this starts a new `powershell.exe` interpreter each time, which is pretty slow to run a single command. Can we just do `on(bolt, ""cmd /c #{bolt_command}"")`? /cc @Iristyle",Prefer single-quoted strings when you don't need st
+6060,"@@ -1,14 +1,14 @@
+-<% if @purchaseable.collection? %>
++<% if @video_page.purchaseable.collection? %>
+   <% content_for :additional_header_links do %>
+-    <li class=""all-videos""><%= link_to 'All Videos', @purchase %></li>
++    <li class=""all-videos""><%= link_to 'All Videos', @video_page.purchase %></li>
+   <% end %>
+ <% end %>
+
+ <% content_for :subject_block do %>
+-  <h1><%= @purchaseable.name %></h1>
++  <h1><%= @video_page.purchaseable.name %></h1>
+   <h2 class=""tagline"">
+-    <% if @purchaseable.collection? %>
+-      <%= @video.title %>
++    <% if @video_page.purchaseable.collection? %>
++      <%= @video_page.video.title %>
+     <% else %>
+       Watch or download video
+     <% end %>",Can we add a `collection?` method to the `VideoPage` so we don't violate Law of Demeter here?,"I don't think you need to check for `@video_page` here, you can access `@video`"
+6061,"@@ -1250,14 +1250,6 @@ public class ProjectManagerServlet extends LoginAbstractAzkabanServlet {
+       page.add(""errorMsg"", e.getMessage());
+     }
+
+-    final int numBytes = 1024;
+-
+-    // Really sucks if we do a lot of these because it'll eat up memory fast.
+-    // But it's expected that this won't be a heavily used thing. If it is,
+-    // then we'll revisit it to make it more stream friendly.
+-    final StringBuffer buffer = new StringBuffer(numBytes);
+-    page.add(""log"", buffer.toString());
+-
+     page.render();
+   }
+ ",Deleting unused code.,Do we need to render this page if `numBytes` is 0?
+6062,"@@ -1,6 +1,7 @@
+ import torch
+
+-from ..bbox import PseudoSampler, assign_and_sample, bbox2delta, build_assigner
++from ..bbox import assign_and_sample, bbox2delta, build_assigner
++from ..bbox.samplers.pseudo_sampler import PseudoSampler
+ from ..utils import multi_apply
+
+ ",`PseudoSampler` can also be imported from `..bbox`,is there a need to import `pseudo_sampler` here?
+6063,"@@ -19,6 +19,7 @@ package agreementtest
+
+ import (
+ 	""fmt""
++	""github.com/algorand/go-algorand/protocol""
+ 	""strconv""
+ 	""time""
+ ",Could you move this import to where the other `github.com/algorand/go-algorand` imports are?,This import should go at the top of the file.
+6064,"@@ -655,7 +655,7 @@ class Conf(ConfClass):
+     # can, tls, http are not loaded by default
+     load_layers = ['bluetooth', 'bluetooth4LE', 'dhcp', 'dhcp6', 'dns',
+                    'dot11', 'dot15d4', 'eap', 'gprs', 'hsrp', 'inet',
+-                   'inet6', 'ipsec', 'ir', 'isakmp', 'l2', 'l2tp',
++                   'inet6', 'ipsec', 'ir', 'isakmp', 'l2', 'l2tp','l2f',
+                    'llmnr', 'lltd', 'mgcp', 'mobileip', 'netbios',
+                    'netflow', 'ntp', 'ppi', 'ppp', 'pptp', 'radius', 'rip',
+                    'rtp', 'sctp', 'sixlowpan', 'skinny', 'smb', 'smb2', 'snmp',","I'd rather not activate this protocol by default for now, unless there is a good reason for that.",missing a space after the comma
+6065,"@@ -19,11 +19,14 @@ import inspect
+ # pylint: disable=line-too-long
+ from google.cloud.forseti.common.util import logger
+ from google.cloud.forseti.common.util import string_formats
++from google.cloud.forseti.services.inventory.storage import DataAccess
++from google.cloud.forseti.services.scanner import dao as scanner_dao
+ from google.cloud.forseti.notifier.notifiers.base_notification import BaseNotification
+ from google.cloud.forseti.notifier.notifiers import cscc_notifier
++from google.cloud.forseti.notifier.notifiers import email_violations
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+-from google.cloud.forseti.services.inventory.storage import DataAccess
+-from google.cloud.forseti.services.scanner import dao as scanner_dao
++
++
+ # pylint: enable=line-too-long
+
+ ",Remove these 2 blank lines.,Minor: Is this change required?
+6066,"@@ -606,6 +606,7 @@ func (pool *TxPool) validateTx(tx types.Transaction, local bool) error {
+ func (pool *TxPool) add(tx types.Transaction, local bool) (replaced bool, err error) {
+ 	// If the transaction is already known, discard it
+ 	hash := tx.Hash()
++	fmt.Printf(""aa: %x\n"", hash)
+ 	if pool.all.Get(hash) != nil {
+ 		log.Trace(""Discarding already known transaction"", ""hash"", hash)
+ 		knownTxMeter.Mark(1)",Want to remove this?,Did you mean to leave this in?
+6067,"@@ -2,6 +2,7 @@ package sql
+
+ import (
+ 	""github.com/jinzhu/gorm""
++	// gorm postgres dialect init registration
+ 	_ ""github.com/jinzhu/gorm/dialects/postgres""
+ )
+ ",is this a golint requirement? huh. mixed feelings :),Is this just to be able to test
+6068,"@@ -33,6 +33,14 @@ public class BCryptPasswordEncoderTests {
+ 		String result = encoder.encode(""password"");
+ 		assertThat(result.equals(""password"")).isFalse();
+ 		assertThat(encoder.matches(""password"", result)).isTrue();
++		encoder = new BCryptPasswordEncoder(BCryptPasswordEncoder.BCRYPT_VERSION_2B);
++		result = encoder.encode(""password"");
++		assertThat(result.equals(""password"")).isFalse();
++		assertThat(encoder.matches(""password"", result)).isTrue();
++		encoder = new BCryptPasswordEncoder(BCryptPasswordEncoder.BCRYPT_VERSION_2Y);
++		result = encoder.encode(""password"");
++		assertThat(result.equals(""password"")).isFalse();
++		assertThat(encoder.matches(""password"", result)).isTrue();
+ 	}
+
+ 	@Test",Generally with these tests please split up these tests so that there is a different test for each method,Encoder tests should be in a `@Test` method.
+6069,"@@ -1394,16 +1394,16 @@ void nano::bootstrap_attempt::lazy_add (nano::block_hash const & hash_a)
+ 	}
+ }
+
+-void nano::bootstrap_attempt::lazy_pull_flush ()
++void nano::bootstrap_attempt::lazy_pull_flush (std::unique_lock<std::mutex> & lock_a)
+ {
+-	std::unique_lock<std::mutex> lock (lazy_mutex);
++	std::unique_lock<std::mutex> lazy_lock (lazy_mutex);
+ 	auto transaction (node->store.tx_begin_read ());
+ 	for (auto & pull_start : lazy_pulls)
+ 	{
+ 		// Recheck if block was already processed
+ 		if (lazy_blocks.find (pull_start) == lazy_blocks.end () && !node->store.block_exists (transaction, pull_start))
+ 		{
+-			add_pull (nano::pull_info (pull_start, pull_start, nano::block_hash (0), lazy_max_pull_blocks));
++			pulls.push_back (nano::pull_info (pull_start, pull_start, nano::block_hash (0), lazy_max_pull_blocks));
+ 		}
+ 	}
+ 	lazy_pulls.clear ();",Should something use the lock passed in?,This `lock_a` is not needed anymore.
+6070,"@@ -101,7 +101,7 @@ class Docker(base.Base):
+
+     When attempting to utilize a container image with `systemd`_ as your init
+     system inside the container to simulate a real machine, make sure to set
+-    the ``privileged``, ``volume_mounts``, ``command``, and ``environment``
++    the ``privileged``, ``volumes``, ``command``, and ``environment``
+     values. An example using the ``centos:7`` image is below:
+
+     .. note:: Do note that running containers in privileged mode is considerably",Is this dependant on some version of Docker? Do we need to include both or `volumes` is deprecated (or just wrong!?)?,shouldn't this be ``volume_mounts``?
+6071,"@@ -1306,7 +1306,7 @@ public class CollectionsHandler extends RequestHandlerBase implements Permission
+     try (ZkShardTerms zkShardTerms = new ZkShardTerms(collectionName, slice.getName(), zkController.getZkClient())) {
+       // if an active replica is the leader, then all is fine already
+       Replica leader = slice.getLeader();
+-      if (leader != null && leader.getState() == State.ACTIVE) {
++      if (leader != null && leader.getState() == State.ACTIVE && zkShardTerms.getHighestTerm() == zkShardTerms.getTerm(leader.getName())) {
+         throw new SolrException(ErrorCode.SERVER_ERROR,
+             ""The shard already has an active leader. Force leader is not applicable. State: "" + slice);
+       }","I know this is not new code, but should we change `leader.getState() == State.ACTIVE` to `leader.isActive(liveNodes)`?",`zkShardTerms.getHighestTerm() == zkShardTer
+6072,"@@ -105,7 +105,7 @@ public class JavaRuleViolation extends ParametricRuleViolation<JavaNode> {
+     private void setClassNameFrom(JavaNode node) {
+         String qualifiedName = null;
+
+-        if (node.getScope() instanceof ClassScope) {
++        if (node instanceof AbstractAnyTypeDeclaration && node.getScope() instanceof ClassScope) {
+             qualifiedName = ((ClassScope) node.getScope()).getClassName();
+         }
+ ",Why not use ASTAnyTypeDeclaration? AbstractAnyTypeDeclaration is deprecated,can you explain why this change is needed?
+6073,"@@ -119,3 +119,5 @@ from .tools.command import (
+     version_add,
+     version_list,
+ )
++
++from .tools.util import save","A blank line at the very end of each file should eliminate the ""No EOF"" warning we see above",Is this needed? I don't see any calls to `
+6074,"@@ -818,15 +818,12 @@ func (h *Handler) SignalWithStartWorkflowExecution(ctx context.Context, request
+
+ 		// Two simultaneous SignalWithStart requests might try to start a workflow at the same time.
+ 		// This can result in one of the requests failing with one of two possible errors:
+-		//    1) If it is a brand new WF ID, one of the requests can fail with WorkflowExecutionAlreadyStartedError
+-		//       (createMode is persistence.CreateWorkflowModeBrandNew)
+-		//    2) If it an already existing WF ID, one of the requests can fail with a CurrentWorkflowConditionFailedError
+-		//       (createMode is persisetence.CreateWorkflowModeWorkflowIDReuse)
++		//    CurrentWorkflowConditionFailedError || WorkflowConditionFailedError
+ 		// If either error occurs, just go ahead and retry. It should succeed on the subsequent attempt.
+ 		// For simplicity, we keep trying unless the context finishes or we get an error that is not one of the
+ 		// two mentioned above.
+-		_, isExecutionAlreadyStartedErr := err2.(*persistence.WorkflowExecutionAlreadyStartedError)
+-		_, isWorkflowConditionFailedErr := err2.(*persistence.CurrentWorkflowConditionFailedError)
++		_, isCurrentWorkflowConditionFailedErr := err2.(*persistence.CurrentWorkflowConditionFailedError)
++		_, isWorkflowConditionFailedErr := err2.(*persistence.WorkflowConditionFailedError)
+
+ 		isContextDone := false
+ 		select {",These would both be more robust with `errors.As` so that we could safely chain errors.,is this change supposed to be in this PR?
+6075,"@@ -299,9 +299,9 @@ SwiftArrayBufferHandler::CreateBufferHandler(ValueObject &valobj) {
+
+   // For now we have to keep the old mangled name since the Objc->Swift bindings
+   // that are in Foundation don't get the new mangling.
+-  if (valobj_typename.startswith(SwiftLanguageRuntime::GetCurrentMangledName(""_TtCs23_ContiguousArrayStorage""))
+-      || valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"")
+-      || valobj_typename.startswith(""Swift._ContiguousArrayStorage"")) {
++  if (valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"") ||
++      valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"") ||
++      valobj_typename.startswith(""Swift._ContiguousArrayStorage"")) {
+     CompilerType anyobject_type =
+         valobj.GetTargetSP()->GetScratchClangASTContext()->GetBasicType(
+             lldb::eBasicTypeObjCID);",This is checking the same condition twice?,This will fail on older compilers
+6076,"@@ -157,8 +157,16 @@ void lbann_comm::allreduce(AbsDistMat& m,
+ #ifdef LBANN_HAS_GPU
+   if (m.GetLocalDevice() == El::Device::GPU) {
+ #ifdef AL_HAS_NCCL
+-    // Force GPU matrices to use NCCL.
++    // We require NCCL for GPU matrices.
+     t = std::type_index(typeid(::Al::NCCLBackend));
++    // If available, use the MPI-CUDA backend for small matrices.
++#ifdef AL_HAS_MPI_CUDA
++    // Based on runs on Pascal and Ray.
++    if ((El::mpi::Size(c) > 4 && local_size <= 8192) ||
++        (El::mpi::Size(c) >= 16 && local_size <= 32768)) {
++      t = std::type_index(typeid(::Al::MPICUDABackend));
++    }
++#endif  // AL_HAS_MPI_CUDA
+ #else
+     throw lbann_exception(""Allreduce on GPU matrix requires NCCL support in""
+                           "" Aluminum"");","Aren't we able to handle the case where we have MPI-CUDA without NCCL, even if it's suboptimal?",Why only MPI_HAS_MPI_CUDA? Shouldn't it only be enabled for NCCL?
+6077,"@@ -37,6 +37,12 @@ Copyright (C) 2001-2016 EQEMu Development Team (http://eqemulator.net)
+
+ extern QueryServ* QServ;
+
++namespace detail
++{
++	static const uint32 PhantomStatId = 999999;
++}
++
++
+ void Mob::TemporaryPets(uint16 spell_id, Mob *targ, const char *name_override, uint32 duration_override, bool followme, bool sticktarg, uint16 *eye_id) {
+
+ 	//It might not be a bad idea to put these into the database, eventually..",Wouldn't we want to namespace this `AA` or something similar,I've seen this id used a lot throughout the rest of the code and
+6078,"@@ -395,7 +395,13 @@ func newSession(opts Options, envCfg envConfig, cfgs ...*aws.Config) (*Session,
+ 	// Load additional config from file(s)
+ 	sharedCfg, err := loadSharedConfig(envCfg.Profile, cfgFiles, envCfg.EnableSharedConfig)
+ 	if err != nil {
+-		if _, ok := err.(SharedConfigProfileNotExistsError); !ok {
++		if len(envCfg.Profile) == 0 && !envCfg.EnableSharedConfig && envCfg.Creds.HasKeys() {
++			// Special case where the user has not explicitly specified an AWS_PROFILE,
++			// or session.Options.profile, shared config is not enabled, and the
++			// environment has credentials, allow the shared config file to fail to
++			// load since the user has already provided credentials, and nothing else
++			// is required to be read file. Github(aws/aws-sdk-go#2455)
++		} else if _, ok := err.(SharedConfigProfileNotExistsError); !ok {
+ 			return nil, err
+ 		}
+ 	}","This probably should look beyond envConfig, and include `aws.Config.Credentials` as well.",Nit: no need for a newline here
+6079,"@@ -110,6 +110,7 @@ namespace Nethermind.TxPool
+             _filterPipeline.Add(new TooFarNonceFilter(txPoolConfig, _accounts, _transactions, _logger));
+             _filterPipeline.Add(new TooExpensiveTxFilter(_headInfo, _accounts, _logger));
+             _filterPipeline.Add(new FeeToLowFilter(_headInfo, _accounts, _transactions, _logger));
++            _filterPipeline.Add(new NotEnoughBalanceFilter(_headInfo, _accounts, _logger));
+             _filterPipeline.Add(new ReusedOwnNonceTxFilter(_accounts, _nonces, _logger));
+             if (incomingTxFilter is not null)
+             {",How does this filter differ from TooExpensiveTxFilter?,This looks wrong. Shouldn't the NotEnoughBalanceFilter be added o
+6080,"@@ -217,6 +217,17 @@ public class Project {
+     return users;
+   }
+
++  public List<String> getGroupsWithPermission(final Type type) {
++    final ArrayList<String> groups = new ArrayList<>();
++    for (final Map.Entry<String, Permission> entry : this.groupPermissionMap.entrySet()) {
++      final Permission perm = entry.getValue();
++      if (perm.isPermissionSet(type)) {
++        groups.add(entry.getKey());
++      }
++    }
++    return groups;
++  }
++
+   public List<Pair<String, Permission>> getUserPermissions() {
+     final ArrayList<Pair<String, Permission>> permissions =
+         new ArrayList<>();","Use "" List<String>"" instead of ArrayList<String> in declaration.",Is there a reason why `getGroupsWithPermission` and `getUserPermissions` are separate methods of `Group`? Looks like they could be combined into a single method.
+6081,"@@ -93,8 +93,10 @@ class ObjectStore(six.with_metaclass(ABCMeta)):
+         return self.set_object(obj, context, runtime_type, paths)
+
+     def get_value(self, context, runtime_type, paths):
+-        if runtime_type in self.TYPE_REGISTRY:
+-            return self.TYPE_REGISTRY[runtime_type].get_object(self, context, runtime_type, paths)
++        if runtime_type.name is not None and runtime_type.name in self.TYPE_REGISTRY:
++            return self.TYPE_REGISTRY[runtime_type.name].get_object(
++                self, context, runtime_type, paths
++            )
+         return self.get_object(context, runtime_type, paths)
+
+ ",we might consider hard throwing when name is None since that is explicitly not working right now and then linking to issue in the exception error message,Shouldn't we check `self.TYPE_REGISTRY[runtime_type.name]`?
+6082,"@@ -1,13 +1,19 @@
+
+ package edu.harvard.iq.dataverse;
+
++import edu.harvard.iq.dataverse.util.BundleUtil;
+ import java.io.Serializable;
++import java.util.MissingResourceException;
+ import javax.persistence.Entity;
+ import javax.persistence.GeneratedValue;
+ import javax.persistence.GenerationType;
+ import javax.persistence.Id;
+ import javax.persistence.JoinColumn;
+ import javax.persistence.ManyToOne;
++import javax.persistence.NamedNativeQueries;
++import javax.persistence.NamedNativeQuery;
++import javax.persistence.NamedQueries;
++import javax.persistence.NamedQuery;
+
+ /**
+  *","Just noticed this - why ""like"" and not straight ""=""",Please fix the format of imports.
+6083,"@@ -1,15 +1,16 @@
+ require 'spec_helper'
+
+ describe Travis::Build::Data::Env do
+-  let(:data) { stub('data', pull_request: '100', config: { env: 'FOO=foo' }, build: {}, job: {}, repository: {}) }
++  let(:data) { stub('data', pull_request: '100', config: { env: 'FOO=foo' }, build: { id: '1', number: '1' }, job: { id: '1', number: '1.1', branch: 'master', commit: '313f61b', commit_range: '313f61b..313f61a' }, repository: { slug: 'travis-ci/travis-ci' }) }
+   let(:env)  { described_class.new(data) }
+
+   it 'vars respond to :key' do
+     env.vars.first.should respond_to(:key)
+   end
+
+-  it 'includes travis env vars' do
+-    env.vars.first.key.should =~ /^TRAVIS_/
++  it 'includes all travis env vars' do
++    travis_vars = env.vars.select { |v| v.key =~ /^TRAVIS_/ && v.value && v.value.length > 0 }
++    travis_vars.length.should == 11
+   end
+
+   it 'includes config env vars' do","is this a new test? if yes, isn't it better to check for each env var is present, and the value, instead of a count?",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+6084,"@@ -160,10 +160,10 @@ public class MicroserviceVersions {
+       setInstances(pulledInstances, rev);
+       validated = true;
+     } catch (Throwable e) {
+-      LOGGER.error(""Failed to setInstances, appId={}, microserviceName={}."",
+-          getAppId(),
+-          getMicroserviceName(),
+-          e);
++      LOGGER.error(String.format(""Failed to setInstances, AppId=%s, MicroserviceName=%s."",
++              getAppId(),
++              getMicroserviceName()),
++              e);
+     }
+   }
+ ","when will lost exception? by my test, never happened.",This needs to be broken into multiple lines.
+6085,"@@ -147,7 +147,8 @@ class BrowserPage(QWebPage):
+                 title=""Open external application for {}-link?"".format(scheme),
+                 text=""URL: <b>{}</b>"".format(
+                     html.escape(url.toDisplayString())),
+-                yes_action=functools.partial(QDesktopServices.openUrl, url))
++                yes_action=functools.partial(QDesktopServices.openUrl, url),
++                url=urlstr)
+             return True
+         elif (info.domain, info.error) in ignored_errors:
+             log.webview.debug(""Ignored error on {}: {} (error domain: {}, """,You should re-stringify it here with `QUrl.FullyEncoded`.,I think this should be `url=url.decode('UTF-
+6086,"@@ -128,9 +128,9 @@ func Wrap(ctx context.Context, topic Topic, msg []byte, recipient *ecdsa.PublicK
+ 	return mine(ctx, odd, f)
+ }
+
+-// Unwrap takes a chunk, a topic and a private key, and tries to decrypt the payload
++// Unwrap takes a private key, a chunk, an array of possible topics and tries to decrypt the payload
+ // using the private key, the prepended ephemeral public key for el-Gamal using the topic as salt
+-func Unwrap(ctx context.Context, key *ecdsa.PrivateKey, chunk swarm.Chunk, topics []Topic) (topic Topic, msg []byte, err error) {
++func Unwrap(key *ecdsa.PrivateKey, chunk swarm.Chunk, quit chan struct{}, topics []Topic) (topic Topic, msg []byte, err error) {
+ 	chunkData := chunk.Data()
+ 	pubkey, err := extractPublicKey(chunkData)
+ 	if err != nil {",i'm not sure why the quit channel is needed in this context,I think we should remove `quit` here. We don
+6087,"@@ -64,13 +64,16 @@ func MakeIngressDeployment(args IngressArgs) *appsv1.Deployment {
+ 	}
+ 	container.Resources = corev1.ResourceRequirements{
+ 		Limits: corev1.ResourceList{
+-			corev1.ResourceMemory: resource.MustParse(""1000Mi""),
++			corev1.ResourceMemory: resource.MustParse(args.MemoryLimit),
+ 		},
+ 		Requests: corev1.ResourceList{
+-			corev1.ResourceMemory: resource.MustParse(""500Mi""),
+-			corev1.ResourceCPU:    resource.MustParse(""1000m""),
++			corev1.ResourceMemory: resource.MustParse(args.MemoryRequest),
++			corev1.ResourceCPU:    resource.MustParse(args.CPURequest),
+ 		},
+ 	}
++	if len(args.CPULimit) > 0 {
++		container.Resources.Limits[corev1.ResourceCPU] = resource.MustParse(args.CPULimit)
++	}
+ 	return deploymentTemplate(args.Args, []corev1.Container{container})
+ }
+ ","When `args.MemoryLimit` is empty, will `MustParse` panic?",`container.Resources.Limits[corev1.ResourceC
+6088,"@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) {
+ 	r.dirtyIfaces.Add(ifaceName)
+ }
+
++func (r *RouteTable) QueueResync() {
++	r.logCxt.Info(""Queueing a resync."")
++	r.inSync = false
++}
++
+ func (r *RouteTable) Apply() error {
+ 	if !r.inSync {
+ 		links, err := r.dataplane.LinkList()",How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.,What's the purpose of this?
+6089,"@@ -23,6 +23,7 @@ import (
+ )
+
+ type nonceWithTTL struct {
++	idx      int
+ 	nonce    uint64
+ 	deadline time.Time
+ }","I add a `idx` property, and it is only use for benchmark `heap.Remove`, is it acceptable?",why do we need this?
+6090,"@@ -1,6 +1,6 @@
+ # -*- coding: UTF-8 -*-
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2018 NV Access Limited, Babbage B.V., Davy Kager
++#Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",daemonic t got inserted.,I don't think this is the r
+6091,"@@ -532,7 +532,8 @@ public class DefaultBlockchain implements MutableBlockchain {
+       if (!genesisHash.get().equals(genesisBlock.getHash())) {
+         throw new InvalidConfigurationException(
+             ""Supplied genesis block does not match stored chain data.\n""
+-                + ""Please specify a different data directory with --data-path or specify the original genesis file with --genesis-file."");
++                + ""Please specify a different data directory with --data-path or specify the""
++                + "" original genesis file with --genesis-file."");
+       }
+     }
+   }",This edit is non-essential.,"formatting is wrong, please"
+6092,"@@ -14,6 +14,14 @@ import {
+
+ const isWeakMapSupported = typeof WeakMap == 'function';
+
++Object.setPrototypeOf =
++	Object.setPrototypeOf ||
++	function(obj, proto) {
++		// eslint-disable-next-line
++		obj.__proto__ = proto;
++		return obj;
++	};
++
+ function getClosestDomNodeParent(parent) {
+ 	if (!parent) return {};
+ 	if (typeof parent.type == 'function') {",Might be safer to ponyfill this?,"@choumx can you confirm this is what we want? I think it would work to do `Object.setPrototypeOf(obj, proto)`"
+6093,"@@ -57,18 +57,11 @@ func Create(dir string) (*Local, error) {
+ 	}
+
+ 	// test if config file already exists
+-	_, err := os.Lstat(backend.Paths.Config)
++	_, err := os.Lstat(filepath.Join(dir, backend.Paths.Config))
+ 	if err == nil {
+ 		return nil, errors.New(""config file already exists"")
+ 	}
+
+-	// test if directories already exist
+-	for _, d := range dirs[1:] {
+-		if _, err := os.Stat(d); err == nil {
+-			return nil, fmt.Errorf(""dir %s already exists"", d)
+-		}
+-	}
+-
+ 	// create paths for data, refs and temp
+ 	for _, d := range dirs {
+ 		err := os.MkdirAll(d, backend.Modes.Dir)",why was this join not necessary before?,Why was this deleted?
+6094,"@@ -163,6 +163,17 @@ public class TestExitableDirectoryReader extends LuceneTestCase {
+     searcher.search(query, 10);
+     reader.close();
+
++    // Set a fairly high timeout value (infinite) and expect the query to complete in that time frame.
++    // Not checking the validity of the result, but checking the sampling kicks in to reduce the number of timeout check
++    CountingQueryTimeout queryTimeout = new CountingQueryTimeout();
++    directoryReader = DirectoryReader.open(directory);
++    exitableDirectoryReader = new ExitableDirectoryReader(directoryReader, queryTimeout);
++    reader = new TestReader(getOnlyLeafReader(exitableDirectoryReader));
++    searcher = new IndexSearcher(reader);
++    searcher.search(query, 10);
++    reader.close();
++    assertEquals(3, queryTimeout.getShouldExitCallCount());
++
+     directory.close();
+   }
+ ","Here we compare to the expected call count 3. Because 3 TermsEnum are created: it is a PrefixQuery and there is one TermsEnum created for AutomatonQuery.intersect() (the next call timeout check is skipped once), then 2 TermsEnum created for the 2 matching terms ""one"" and ""ones""). Would it be clearer to have a separate test method? We could index more docs, for example 50 with a prefix-generated term (e.g. ""term""+increment). There would be a PrefixQuery for ""term"", the same test code, and we would test the TIMEOUT_CHECK_SAMPLING: - 1 TermsEnum for Automaton.intersect(), and the next calls would be sampled (50/TIMEOUT_CHECK_SAMPLING=3) => call count +4 - 1 TermsEnum for each enumerated term => call count +50 We could verify call count = 54 (instead of 101 without sampling)","I think you should be able to just replace this with `searcher.search(query, 10);`"
+6095,"@@ -28,6 +28,9 @@ module Bolt
+       when 'file'
+         { flags: ACTION_OPTS + %w[tmpdir],
+           banner: FILE_HELP }
++      when 'inventory'
++        { flags: OPTIONS[:inventory] + OPTIONS[:global] + %w[format inventoryfile boltdir configfile],
++          banner: INVENTORY_HELP }
+       when 'plan'
+         case action
+         when 'convert'",Add `--format` as an option. Does it make sense to have all display options available? Also need to add `--inventoryfile` and possibly the global_config_options.,Metrics/LineLength: Line is too long. [98/80]
+6096,"@@ -53,5 +53,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
+         /// The type of this object depends on the event, which is given by the above parameter.</para>
+         /// </remarks>
+         public Action<Activity, string, object> Enrich { get; set; }
++
++        /// <summary>
++        /// Gets or sets a value indicating whether the exception will be recorded or not.
++        /// </summary>
++        public bool RecordException { get; set; }
+     }
+ }","Any thoughts on making this false by default? My suggestion is make this opt-in. Storing exception is somewhat expensive, so lets do this only if users opt-in",Could you also add the property to the `DynamoViewModel` as well?
+6097,"@@ -88,7 +88,7 @@ public final class HttpCall<V> extends Call.Base<V> {
+       } else {
+         try {
+           callback.onSuccess(parseResponse(response, bodyConverter));
+-        } catch (IOException e) {
++        } catch (Throwable e) {
+           callback.onError(e);
+         }
+       }","usually I do either ` IOException|RuntimeException` or if doing Throwable, use propagateIfFatal",why change to Throwable? is this change related to the rest of th
+6098,"@@ -24,10 +24,14 @@ class Overlayable(object):
+
+     def __mul__(self, other):
+         if type(other).__name__ == 'DynamicMap':
+-            from ..util import Dynamic
+-            def dynamic_mul(element):
++            from .spaces import Callable
++            def dynamic_mul(*args, **kwargs):
++                element = other[args]
+                 return self * element
+-            return Dynamic(other, operation=dynamic_mul)
++            callback = Callable(callable_function=dynamic_mul,
++                                inputs=[self, other])
++            return other.clone(shared_data=False, callback=callback,
++                               streams=[])
+         if isinstance(other, UniformNdMapping) and not isinstance(other, CompositeOverlay):
+             items = [(k, self * v) for (k, v) in other.items()]
+             return other.clone(items)","Wondering whether it should be `self.clone`, or `other.clone` or maybe a new `DynamicMap` declaration entirely. I see this is in the condition where `other` is a `DynamicMap`but is this definitely right in terms of `kdims`? I need to think about it more...",I think the simplest fix here is to make `dynamic_mul` take an `O
+6099,"@@ -34,7 +34,7 @@ public interface SolrInfoBean {
+    * Category of Solr component.
+    */
+   enum Category { CONTAINER, ADMIN, CORE, QUERY, UPDATE, CACHE, HIGHLIGHTER, QUERYPARSER, SPELLCHECKER,
+-    SEARCHER, REPLICATION, TLOG, INDEX, DIRECTORY, HTTP, OTHER }
++    SEARCHER, REPLICATION, TLOG, INDEX, DIRECTORY, HTTP, SECURITY, OTHER }
+
+   /**
+    * Top-level group of beans or metrics for a subsystem.",I chose a new category because over time I'd like to add metrics also for Authorization plugins and Auditlog plugins (all components registered in security.json). An alternative could have been `CONTAINER` I guess?,Maybe we should add a comma at the end of this line so that futur
+6100,"@@ -22,6 +22,11 @@ var (
+ 	ErrMinusAmount = errors.New(""invalid amount that is minus"")
+ )
+
++const (
++	// IotxAddressLength defines length of IoTeX address
++	IotxAddressLength = 41
++)
++
+ // ValidateAddress validates IoTeX address
+ func ValidateAddress(addr string) error {
+ 	if _, err := address.FromString(addr); err != nil {",IoAddrLen Golang prefers short variable names,Can we make it a constant?
+6101,"@@ -34,7 +34,7 @@ class MediaAdmin extends Admin
+      */
+     public function createQuery($context = 'list')
+     {
+-        $query = $this->getModelManager()->createQuery($this->getClass(), '', $this->root);
++        $query = $this->getModelManager()->createQuery($this->getClass(), 'a', $this->root);
+
+         foreach ($this->extensions as $extension) {
+             $extension->configureQuery($this, $query, $context);",PHPCR-ODM does not allow blank aliases..,I don't understand why thi
+6102,"@@ -358,7 +358,11 @@ public class HttpSolrClient extends BaseHttpSolrClient {
+     if (parser == null) {
+       parser = this.parser;
+     }
+-
++
++    Header[] contextHeaders = new Header[2];
++    contextHeaders[0] = new BasicHeader(CommonParams.SOLR_REQUEST_CONTEXT_PARAM, getContext().toString());
++    contextHeaders[1] = new BasicHeader(CommonParams.SOLR_REQUEST_TYPE_PARAM, request.getRequestType());
++
+     // The parser 'wt=' and 'version=' params are used instead of the original
+     // params
+     ModifiableSolrParams wparams = new ModifiableSolrParams(params);",This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server?,I think that this could be
+6103,"@@ -42,6 +42,7 @@
+ //@HEADER
+ */
+
++#include <Kokkos_Core.hpp>
+ #include <Kokkos_Concepts.hpp>
+ #include <SYCL/Kokkos_SYCL_Instance.hpp>
+ #include <KokkosCore_Config_DeclareBackend.hpp>",Why are you including `<Kokkos_Core.hpp>`?,Please add a license heade
+6104,"@@ -323,7 +323,7 @@ int api_v1_health(struct flb_hs *hs)
+
+     counter_init(hs);
+     /* Create a message queue */
+-    hs->qid_metrics = mk_mq_create(hs->ctx, ""/health"",
++    hs->qid_health = mk_mq_create(hs->ctx, ""/health"",
+                                    cb_mq_health, NULL);
+
+     mk_vhost_handler(hs->ctx, hs->vid, ""/api/v1/health"", cb_health, hs);","So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13",Is there a reason we can't use the mk_mq_create directly?
+6105,"@@ -1470,6 +1470,7 @@ func isValidRuleForXDP(rule *proto.Rule) bool {
+ 		len(rule.DstPorts) == 0 &&
+ 		len(rule.DstNamedPortIpSetIds) == 0 &&
+ 		len(rule.DstIpSetIds) == 0 &&
++		len(rule.DstIpPortSetIds) == 0 &&
+ 		len(rule.NotDstNet) == 0 &&
+ 		len(rule.NotDstPorts) == 0 &&
+ 		len(rule.NotDstIpSetIds) == 0 &&","Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated.",Shouldn't this be `len(rule.DstIpSetIds) == 0` ?
+6106,"@@ -0,0 +1,12 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System;
++
++namespace Microsoft.AspNetCore.Connections.Features
++{
++    public interface IConnectionHeartbeatTickFeature
++    {
++        void OnHeartbeat(Action<DateTimeOffset, object> action, object state);
++    }
++}",cc @anurse This exists now. Kestrel currently passes the current time to all callbacks as an optimization. Just an FYI.,Is there a reason why this isn't named `IConnectionHeartb
+6107,"@@ -126,7 +126,7 @@ class Entry(MSONable, metaclass=ABCMeta):
+         elif mode == ""formula_unit"":
+             factor = self.composition.get_reduced_composition_and_factor()[1]
+         else:
+-            raise ValueError(f""{mode=} is not an allowed option for normalization"")
++            raise ValueError(f""{mode} is not an allowed option for normalization"")
+
+         return factor
+ ",remove 3.8+ f-string format to allow use in google colab,The `=` was removed intentionally in error messages.
+6108,"@@ -196,6 +196,10 @@ save_xmm(dcontext_t *dcontext, sigframe_rt_t *frame)
+     int i;
+     sigcontext_t *sc = get_sigcontext_from_rt_frame(frame);
+     kernel_xstate_t *xstate = (kernel_xstate_t *)sc->fpstate;
++    /* For pending signals, the alignment of xstate ultimately depends on the alignment of
++     * the special allocator's blocks. Ths is fragile, and assertions here and at
++     * initialization are providing some coverage for this.
++     */
+     if (!preserve_xmm_caller_saved())
+         return;
+     if (xstate_has_extra_fields) {",Should we assert that xstate is aligned here?,"I think it should be ""the alignment of the special allocator's blocks"""
+6109,"@@ -49,8 +49,8 @@ import com.tdunning.math.stats.AVLTreeDigest;
+ //   TestCloudJSONFacetJoinDomain for random field faceting tests with domain modifications
+ //   TestJsonFacetRefinement for refinement tests
+
+-@LuceneTestCase.SuppressCodecs({""Lucene3x"",""Lucene40"",""Lucene41"",""Lucene42"",""Lucene45"",""Appending""})
+-public class TestJsonFacets extends SolrTestCaseHS {
++@LuceneTestCase.SuppressCodecs({""Lucene3x"",""Lucene40"",""Lucene41"",""FST50"",""Direct"",""Lucene42"",""Lucene45"",""Appending"",""BlockTreeOrds"",""FSTOrd50""})
++public class  TestJsonFacets extends SolrTestCaseHS {
+
+   private static SolrInstances servers;  // for distributed testing
+   private static int origTableSize;",any particular reason for suppressing this change?,Is there a reason why we can't use `IntegrationTestUtils.TestJsonFacet
+6110,"@@ -67,6 +67,17 @@ public abstract class MainnetDifficultyCalculators {
+         return periodCount > 1 ? adjustForPeriod(periodCount, difficulty) : difficulty;
+       };
+
++  public static DifficultyCalculator<Void> DIFFICULTY_BOMB_REMOVED =
++      (time, parent, protocolContext) -> {
++        final BigInteger parentDifficulty = difficulty(parent.getDifficulty());
++        final BigInteger difficulty =
++            ensureMinimumDifficulty(
++                BigInteger.valueOf(Math.max(1 - (time - parent.getTimestamp()) / 10, -99L))
++                    .multiply(parentDifficulty.divide(DIFFICULTY_BOUND_DIVISOR))
++                    .add(parentDifficulty));
++        return difficulty;
++      };
++
+   public static DifficultyCalculator<Void> BYZANTIUM =
+       (time, parent, protocolContext) ->
+           calculateByzantiumDifficulty(time, parent, BYZANTIUM_FAKE_BLOCK_OFFSET);","Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case?",Why do we need this? Isn't the difficulty calculated based on the pare
+6111,"@@ -16,6 +16,19 @@
+ // variables read from a blob.Bucket.
+ // Use NewVariable to construct a *runtimevar.Variable.
+ //
++// URLs
++//
++// For runtimevar.OpenVariable URLs, blobvar registers for the scheme ""blob"".
++// The host+path is used as the blob key. blobvar supports the following URL
++// parameters:
++//   - bucket: The URL to be passed to blob.OpenBucket (required).
++//       blob.OpenBucket will be called once per unique bucket URL.
++//   - decoder: The decoder to use. Defaults to runtimevar.BytesDecoder.
++//       See runtimevar.DecoderByName for supported values.
++//   - wait: The poll interval; supported values are from time.ParseDuration.
++//       Defaults to 30s.
++// Example URL: ""blob://myvar.txt?bucket=fileblob:///foo/bar&decoder=string"".
++//
+ // As
+ //
+ // blobvar exposes the following types for As:","I suggest to use a scheme like ""blobvar"". ""blob"" would potentially collide if we have another API that use the blob package as a driver.",These lines are too long (> 80 characters)
+6112,"@@ -116,6 +116,14 @@ def get_listens(user_name):
+     for listen in listens:
+         listen_data.append(listen.to_api())
+
++    latest_listen = db_conn.fetch_listens(
++        user_name,
++        limit=1,
++        to_ts=max_ts,
++    )
++    latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 else 0
++
++
+     if min_ts:
+         listen_data = listen_data[::-1]
+ ","This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case",wouldn't it be simpler to just return 0 here?
+6113,"@@ -365,7 +365,7 @@ namespace pwiz.Skyline.Properties {
+         }
+
+         /// <summary>
+-        ///   Looks up a localized string similar to An error occurred while trying to display the document &apos;{0}&apos;.
++        ///   Looks up a localized string similar to An error occurred while trying to display the document &apos;{0}&apos;.
+         ///There might be something wrong with default web browser on this computer..
+         /// </summary>
+         public static string ActionTutorial_ExtractTutorial_An_error_occurred_while_trying_to_display_the_document___0____ {",Seems like a lot of unintended changes. Are your line break settings causing these?,This change is not required.
+6114,"@@ -231,9 +231,10 @@ def generate_r_docs(app):
+         r-jsonlite=1.5=r351h96ca727_0 \
+         r-matrix=1.2_14=r351h96ca727_0 \
+         r-testthat=2.0.0=r351h29659fb_0 \
+-        cmake=3.14.0=h52cb24c_0
++        cmake=3.14.0=h52cb24c_0 \
++        ca-certificates=2019.11.27=0
+     /home/docs/.conda/bin/conda install -q -y -n r_env -c conda-forge \
+-        r-pkgdown=1.3.0=r351h6115d3f_1000 \
++        r-pkgdown=1.3.0=r35h6115d3f_1001 \
+         r-roxygen2=6.1.1=r35h0357c0b_1001
+     source /home/docs/.conda/bin/activate r_env
+     export TAR=/bin/tar",@StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change?,why did this need to be updated?
+6115,"@@ -1,6 +1,5 @@
+-# $Id$
+ #
+-#  Copyright (C) 2003-2006  Rational Discovery LLC
++#  Copyright (C) 2002-2006  greg Landrum and Rational Discovery LLC
+ #
+ #   @@ All Rights Reserved @@
+ #  This file is part of the RDKit.","I'm not arguing with it, but how did you decide to make this change?",why did you change this file?
+6116,"@@ -1,7 +1,7 @@
+ # -*- coding: utf-8 -*-
+ ##
+ ## This file is part of Invenio.
+-## Copyright (C) 2011, 2012 CERN.
++## Copyright (C) 2011, 2012, 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 First line should be imperative: 'Call', not 'Calls' 115: D400 First line should end with '.', not 't' 134: D400 First line should end with '.', not 'e' 134: D205 Blank line missing between one-line summary and description",Copyright date should not be changed from the original unless the file has been completely replaced
+6117,"@@ -42,6 +42,14 @@ type ACMEIssuer struct {
+ 	// Only ACME v2 endpoints (i.e. RFC 8555) are supported.
+ 	Server string `json:""server""`
+
++	// PreferredChain is the chain to use if the ACME server outputs multiple.
++	// PreferredChain is no guarantee that this one gets delivered by the ACME
++	// endpoint.
++	// For example, for Let's Encrypt's DST crosssign you would use:
++	// ""DST Root CA X3"" or ""ISRG Root X1"" for the newer Let's Encrypt root CA.
++	// +optional
++	PreferredChain string `json:""preferredChain""`
++
+ 	// Enables or disables validation of the ACME server TLS certificate.
+ 	// If true, requests to the ACME server will not have their TLS certificate
+ 	// validated (i.e. insecure connections will be allowed).","Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate.",Is there a way to link to the ACME server in a way that allows for more flexibility in the future?
+6118,"@@ -16,7 +16,7 @@ type Config struct {
+ 	Storage           *storageConfig     `yaml:""storage"" required:""true""`
+ 	Blockchain        *blockchain.Config `yaml:""blockchain""`
+ 	MetricsListenAddr string             `yaml:""metrics_listen_addr"" default:""127.0.0.1:14004""`
+-	ColdStart         *ColdStartConfig   `yaml:""cold_start""`
++	ColdStart         bool               `yaml:""cold_start""`
+ 	NumWorkers        int                `yaml:""num_workers"" default:""64""`
+ }
+ ",do we really need this behavour to be configurable?,Why did you remove this?
+6119,"@@ -3,7 +3,7 @@
+  */
+
+ var MongooseArray = require('./array')
+-  , ObjectId = require('../drivers/node-mongodb-native/objectid')
++  , ObjectId = require('./objectid')
+   , ObjectIdSchema = require('../schema/objectid')
+   , utils = require('../utils')
+   , util = require('util')",Hmm interesting. Do the tests check out on this?,can we move this to `lib/objectid` please?
+6120,"@@ -26,11 +26,15 @@ import java.util.concurrent.TimeUnit;
+
+ import com.google.common.base.Stopwatch;
+ import org.apache.logging.log4j.Logger;
++import org.apache.tuweni.bytes.Bytes;
++import org.apache.tuweni.concurrent.ExpiringMap;
+ import org.apache.tuweni.units.bigints.UInt256;
+
+ public class PoWSolver {
+
++  private static final int MAX_OMMER_DEPTH = 8;
+   private static final Logger LOG = getLogger();
++  private final long powJobTimeToLive;
+
+   public static class PoWSolverJob {
+ ","For another PR, another `--X` candidate.",not sure why this is a static constant?
+6121,"@@ -10,4 +10,5 @@ const (
+ 	GettingStarted = ""Getting Started ✨""
+ 	Develop = ""Develop 🔧""
+ 	Settings = ""Settings""
+-)
++	Release = ""Release""
++)","Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji   at the end? The windows one could be plain.",Maybe `Release` instead of `Release`?
+6122,"@@ -4,6 +4,8 @@
+
+ package net.sourceforge.pmd.lang.ast.xpath;
+
++import static junit.framework.TestCase.assertTrue;
++
+ import java.util.HashMap;
+ import java.util.Map;
+ ","this is a junit 3 import, not a junit 4",Do we still need this?
+6123,"@@ -113,9 +113,16 @@ func TestReconcile(t *testing.T) {
+ 				assert.Equal(t, hivev1.UnsupportedHibernationReason, cond.Reason)
+ 			},
+ 		},
++		{
++			name:        ""clustersync not yet created"",
++			cd:          cdBuilder.Options(o.shouldHibernate).Build(),
++			expectError: true,
++		},
+ 		{
+ 			name: ""start hibernating, no syncsets"",
+ 			cd:   cdBuilder.Options(o.shouldHibernate).Build(),
++			// The clustersync controller creates a ClusterSync even when there are no syncsets
++			cs: csBuilder.Build(),
+ 			setupActuator: func(actuator *mock.MockHibernationActuator) {
+ 				actuator.EXPECT().StopMachines(gomock.Any(), gomock.Any(), gomock.Any()).Times(1).Return(nil)
+ 			},",shouldn't there be a reque expected here?,Does the error message need to be updat
+6124,"@@ -63,7 +63,7 @@ namespace NLog.Layouts
+         ///
+         /// Thread-agnostic layouts only use contents of <see cref=""LogEventInfo""/> for its output.
+         /// </remarks>
+-        internal bool ThreadAgnostic { get; private set; }
++        internal bool ThreadAgnostic { get; set; }
+
+         /// <summary>
+         /// Gets the level of stack trace information required for rendering.",I prefer to make it `protected set`. What do you think?,Should this be `internal set;`?
+6125,"@@ -178,7 +178,9 @@ type Options struct {
+ 	Gateway               GatewayOpts   `json:""gateway,omitempty""`
+ 	LeafNode              LeafNodeOpts  `json:""leaf,omitempty""`
+ 	JetStream             bool          `json:""jetstream""`
+-	StoreDir              string        `json:""store_dir""`
++	JetStreamMaxMemory    int64         `json:""-""`
++	JetStreamMaxStore     int64         `json:""-""`
++	StoreDir              string        `json:""-""`
+ 	ProfPort              int           `json:""-""`
+ 	PidFile               string        `json:""-""`
+ 	PortsFileDir          string        `json:""-""`",Maybe rename this to JetStreamStoreDir?,Can we just call it `MaxMemory`
+6126,"@@ -52,7 +52,8 @@ var _ = Describe(""UsageReporter with mocked URL and short interval"", func() {
+ 		httpHandler = &requestRecorder{}
+ 		go func() {
+ 			defer GinkgoRecover()
+-			http.Serve(tcpListener, httpHandler)
++			// TODO: Investigate why this call sometimes returns an error.
++			_ = http.Serve(tcpListener, httpHandler)
+ 		}()
+
+ 		// Channels to send data to the UsageReporter.",You can start by logging out the error,I think the error needs to be c
+6127,"@@ -31,7 +31,7 @@ namespace Nethermind.JsonRpc.Modules.Eth.GasPrice
+     {
+         private readonly IBlockFinder _blockFinder;
+         private readonly UInt256 _minGasPrice;
+-        public UInt256 FallbackGasPrice => LastGasPrice ?? _minGasPrice;
++        public UInt256 FallbackGasPrice(in UInt256? baseFeePerGas = null) => LastGasPrice ?? GetMinimumGasPrice(baseFeePerGas ?? UInt256.Zero);
+         private ISpecProvider SpecProvider { get; }
+         public UInt256? LastGasPrice { get; set; }
+         public Block? LastHeadBlock { get; set; }","In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header?",Any reason not to make this `in
+6128,"@@ -80,7 +80,7 @@ import java.util.function.*;
+  * @param <V> Value type
+  * @author Daniel Dietrich, Ruslan Sennov
+  */
+-public interface Map<K, V> extends Traversable<Tuple2<K, V>>, Function1<K, V>, PartialFunction<K, V>, Serializable {
++public interface Map<K, V> extends Traversable<Tuple2<K, V>>, PartialFunction<K, V>, Serializable {
+
+     long serialVersionUID = 1L;
+ ",follow-up of #2002,"Function1 doesn't exist anymore, so I've removed it."
+6129,"@@ -162,7 +162,7 @@ public class TiSession implements AutoCloseable {
+         if (tableScanThreadPool == null) {
+           tableScanThreadPool =
+               Executors.newFixedThreadPool(
+-                  conf.getTableScanConcurrency(),
++                  conf.getTableScanConcurrency() / conf.getPartitionPerSplit(),
+                   new ThreadFactoryBuilder().setDaemon(true).build());
+         }
+         res = tableScanThreadPool;","could you give some explanations of what problem do you want to solve by this change, and how/why it works?",why is this / partitionPerSplit needed?
+6130,"@@ -2,16 +2,18 @@
+ // The .NET Foundation licenses this file to you under the MIT license.
+ // See the LICENSE file in the project root for more information.
+
++using System;
+ using System.Collections.Generic;
+ using System.Threading;
+ using System.Threading.Tasks;
++using Xunit;
+ using Xunit.Abstractions;
+ using Xunit.Sdk;
+
+ namespace Xunit.NetCore.Extensions
+ {
+     /// <summary>Wraps another test case that should be skipped.</summary>
+-    internal sealed class SkippedTestCase : IXunitTestCase
++    internal sealed class SkippedTestCase : LongLivedMarshalByRefObject, IXunitTestCase
+     {
+         private readonly IXunitTestCase _testCase;
+         private readonly string _skippedReason;",LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit?,Why is this long?
+6131,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.,Omit parentheses for method calls with no arguments.
+6132,"@@ -85,12 +85,11 @@ func Run(ctx context.Context, cfg *config.Node) error {
+ 		}
+
+ 		logrus.Infof(""Running containerd %s"", config.ArgString(args[1:]))
+-		cmd := exec.Command(args[0], args[1:]...)
++		cmd := exec.CommandContext(ctx, args[0], args[1:]...)
+ 		cmd.Stdout = stdOut
+ 		cmd.Stderr = stdErr
+ 		cmd.Env = env
+
+-		addDeathSig(cmd)
+ 		if err := cmd.Run(); err != nil {
+ 			fmt.Fprintf(os.Stderr, ""containerd: %s\n"", err)
+ 		}","Testing on linux with this change, containerd no longer stops when k3s stops.",I wonder if we should just pass the context through here instead of passing it through everywhere.
+6133,"@@ -266,6 +266,11 @@ type Config struct {
+ 	// MaxConnectionReceiveWindow is the connection-level flow control window for receiving data.
+ 	// If this value is zero, it will default to 15 MB.
+ 	MaxConnectionReceiveWindow uint64
++	// AllowConnectionWindowIncrease is called every time the connection flow controller attempts
++	// to increase the connection flow control window.
++	// If set, the caller can prevent an increase of the window. Typically, it would do so to
++	// limit the memory usage.
++	AllowConnectionWindowIncrease func(sess Session, delta int) bool
+ 	// MaxIncomingStreams is the maximum number of concurrent bidirectional streams that a peer is allowed to open.
+ 	// Values above 2^60 are invalid.
+ 	// If not set, it will default to 100.",Maybe [u]int64 to be consistent with other byte-valued vars in this struct?,Do we still need this? Do we still need `MaxConnectionReceiveWindow`?
+6134,"@@ -25,7 +25,9 @@
+     <%- if signed_in? %>
+       <div class=""mycart-link"">
+         <ul class=""header-nav"">
+-            <li><%= link_to(""My Requests"", carts_path) %> <%= image_tag ""img-cart.png"", width: '18px', height:'16px' %></li>
++          <li><%= link_to ""My Requests"", carts_path %> <%= image_tag ""img-cart.png"", width: '18px', height:'16px' %></li>
++          <%# TODO only show to NCR people %>
++          <li><%= link_to ""New Request"", new_ncr_proposal_path %></li>
+         </ul>
+       </div>
+     <%- end %>","This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example.","Not sure if ""New Request"" is the right name here, maybe `new_ncr_proposal_path` ?"
+6135,"@@ -36,9 +36,12 @@ template <typename Dtype>
+ BasePrefetchingDataLayer<Dtype>::BasePrefetchingDataLayer(
+     const LayerParameter& param)
+     : BaseDataLayer<Dtype>(param),
+-      prefetch_free_(), prefetch_full_() {
+-  for (int i = 0; i < PREFETCH_COUNT; ++i) {
+-    prefetch_free_.push(&prefetch_[i]);
++      prefetch_(param.has_data_param() ?
++                param.data_param().prefetch() : PREFETCH_COUNT),
++      prefetch_free_(), prefetch_full_(), prefetch_current_() {
++  for (int i = 0; i < prefetch_.size(); ++i) {
++    prefetch_[i].reset(new Batch<Dtype>());
++    prefetch_free_.push(prefetch_[i].get());
+   }
+ }
+ ","Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`.","Ugly hack, need to modify `prefetch_full_()` and `prefetch_current_()` to take care of this logic."
+6136,"@@ -55,6 +55,16 @@ func nodeStatus(node *node.AlgorandFullNode) (res v1.NodeStatus, err error) {
+ 	}, nil
+ }
+
++func txEncode(tx transactions.Transaction, ad transactions.ApplyData) (res v1.Transaction, err error) {
++	switch tx.Type {
++	case protocol.PaymentTx:
++		return paymentTxEncode(tx, ad), nil
++	case protocol.KeyRegistrationTx:
++		return keyregTxEncode(tx, ad), nil
++	}
++	return v1.Transaction{}, errors.New(errUnknownTransactionType)
++}
++
+ func paymentTxEncode(tx transactions.Transaction, ad transactions.ApplyData) v1.Transaction {
+ 	payment := v1.PaymentTransactionType{
+ 		To:           tx.Receiver.String(),",nit : move this into a default clause in the previous switch statement.,Is it safe to return an empty transaction here?
+6137,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return ""'"" + value + ""'"";
+ 	} else {
+-		return '""""';
++		return ""'"";
+ 	}
+ }
+ ","It should be return ""''""; I will fix it",any reason not to use single quotes here?
+6138,"@@ -43,14 +43,14 @@ type ClusterEvent interface{}
+ // Specific type of cluster event emitted when new member joins cluster
+ type NewMemberEvent struct {
+ 	endpointsInfo
+-	Id string
++	ID string
+ }
+
+ // Specific type of cluster event emitted when leadership is transferred.
+ // It is not always loss or acquire of leadership of this specific node
+ type LeadershipEvent struct {
+ 	Held            bool
+-	LeaderId        string
++	LeaderID        string
+ 	LeaderEndpoints []string
+ }
+ ","Go standard linter hates `Id`s and likes `ID`s, please do not resist.",why change it to ID?
+6139,"@@ -71,11 +71,11 @@ module Travis
+           end
+
+           def fetch_ref
+-            cmd ""git fetch origin +#{data.ref}: "", assert: true, timeout: :git_fetch_ref, fold: ""git.#{next_git_fold_number}""
++            cmd ""git fetch origin +#{data.ref}: "", assert: true, timeout: :git_fetch_ref, fold: ""git.#{next_git_fold_number}"", retry: true
+           end
+
+           def git_checkout
+-            cmd ""git checkout -qf #{data.pull_request ? 'FETCH_HEAD' : data.commit}"", assert: true, fold: ""git.#{next_git_fold_number}""
++            cmd ""git checkout -qf #{data.pull_request ? 'FETCH_HEAD' : data.commit}"", assert: true, fold: ""git.#{next_git_fold_number}"", retry: true
+           end
+
+           def submodules?","I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times.",Line is too long. [101/80]
+6140,"@@ -172,7 +172,7 @@ func SetCertificateNotBefore(p metav1.Time) CertificateModifier {
+ 	}
+ }
+
+-func SetCertificateRenewalTIme(p metav1.Time) CertificateModifier {
++func SetCertificateRenewalTime(p metav1.Time) CertificateModifier {
+ 	return func(crt *v1.Certificate) {
+ 		crt.Status.RenewalTime = &p
+ 	}",Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there?,@deads2k @smarterclayton @juanvallejo @juanvallejo @jim-minter - can you review this function and its test cases?
+6141,"@@ -25,6 +25,8 @@ _rtp_payload_types = {
+     31: 'H261',          32: 'MPV',
+     33: 'MP2T',          34: 'H263' }
+
++extension_condition = lambda pkt: pkt.extension
++
+ class RTP(Packet):
+     name=""RTP""
+     fields_desc = [ BitField('version', 2, 2),",Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class ? Would be better i think,I think you could just add `lambda pkt: pkt.extension` to the `fields_desc` above.
+6142,"@@ -72,7 +72,7 @@ module RSpec::Core
+         end
+
+         parser.on('--seed SEED', Integer, 'Equivalent of --order rand:SEED.') do |seed|
+-          options[:order] = ""rand:#{seed}""
++          options[:seed] = seed
+         end
+
+         parser.on('--fail-fast', 'Abort the run on first failure.') do |o|","This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use.",This is no longer valid since `--order` is deprecated.
+6143,"@@ -112,6 +112,9 @@ loader_init(void)
+         char name_copy[MAXIMUM_PATH];
+         mod = privload_insert(NULL, privmod_static[i].base, privmod_static[i].size,
+                               privmod_static[i].name, privmod_static[i].path);
++#ifdef CLIENT_INTERFACE
++        mod->is_client = true;
++#endif
+         LOG(GLOBAL, LOG_LOADER, 1, ""%s: processing imports for %s\n"", __FUNCTION__,
+             mod->name);
+         /* save a copy for error msg, b/c mod will be unloaded (i#643) */",Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set.,"IMHO, it would be better if we didn't have to set `is_client` every time. The purpose of `mod->is_client` looks a"
+6144,"@@ -2167,7 +2167,9 @@ namespace pwiz.Skyline.Model.Lib
+                 }
+                 if (!string.IsNullOrEmpty(OtherKeys))
+                 {
+-                    smallMolLines.Add(new KeyValuePair<string, string> (Resources.SmallMoleculeLibraryAttributes_KeyValuePairs_OtherIDs, OtherKeys.Replace('\t','\n')));
++                    // Add a separate line for each molecule accession number
++                    var accessionNumDict = MoleculeAccessionNumbers.FormatAccessionNumbers(OtherKeys);
++                    smallMolLines.AddRange(accessionNumDict.Select(pair => new KeyValuePair<string, string>(pair.Key, pair.Value)));
+                 }
+                 return smallMolLines;
+             }","Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones.",You need to do the same in `AddMolLine` above.
+6145,"@@ -19,12 +19,7 @@ package org.camunda.bpm.model.cmmn;
+ import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN10_NS;
+ import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN11_NS;
+
+-import java.io.File;
+-import java.io.FileInputStream;
+-import java.io.FileNotFoundException;
+-import java.io.FileOutputStream;
+-import java.io.InputStream;
+-import java.io.OutputStream;
++import java.io.*;
+
+ import org.camunda.bpm.model.cmmn.impl.CmmnParser;
+ import org.camunda.bpm.model.cmmn.impl.instance.ApplicabilityRuleImpl;","As Miklas stated, please avoid wildcard imports.",Please don't use wildcard imports.
+6146,"@@ -204,5 +204,4 @@ function server (inputCompanionOptions = {}) {
+   return { app, companionOptions }
+ }
+
+-const { app, companionOptions } = server()
+-module.exports = { app, companionOptions, server }
++module.exports = { server }",Maybe change it to `module.exports = server` ? Becase there's nothing else to export here,Not sure why this change is included in this P
+6147,"@@ -24,14 +24,13 @@ import (
+
+ 	""cloud.google.com/go/pubsub""
+ 	""cloud.google.com/go/pubsub/pstest""
++	""google.golang.org/grpc/codes""
+
+ 	reconcilertestingv1 ""github.com/google/knative-gcp/pkg/reconciler/testing/v1""
+ 	""github.com/google/knative-gcp/pkg/utils/authcheck""
+
+ 	""google.golang.org/api/option""
+ 	""google.golang.org/grpc""
+-	""google.golang.org/grpc/codes""
+-
+ 	v1 ""k8s.io/api/apps/v1""
+
+ 	corev1 ""k8s.io/api/core/v1""","This may be an automated change, but the import seems to fit better where it was previously.",this import should go with the rest of the 3rd
+6148,"@@ -0,0 +1,9 @@
++<script type=""text/javascript"">
++  window.analytics||(window.analytics=[]),window.analytics.methods=[""identify"",""track"",""trackLink"",""trackForm"",""trackClick"",""trackSubmit"",""page"",""pageview"",""ab"",""alias"",""ready"",""group"",""on"",""once"",""off""],window.analytics.factory=function(t){return function(){var a=Array.prototype.slice.call(arguments);return a.unshift(t),window.analytics.push(a),window.analytics}};for(var i=0;i<window.analytics.methods.length;i++){var method=window.analytics.methods[i];window.analytics[method]=window.analytics.factory(method)}window.analytics.load=function(t){var a=document.createElement(""script"");a.type=""text/javascript"",a.async=!0,a.src=(""https:""===document.location.protocol?""https://"":""http://"")+""d2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/""+t+""/analytics.min.js"";var n=document.getElementsByTagName(""script"")[0];n.parentNode.insertBefore(a,n)},window.analytics.SNIPPET_VERSION=""2.0.8"",
++  window.analytics.load(""2nexpdgku3"");
++  window.analytics.page();
++</script>
++
++<% if signed_in? %>
++  <%= render 'signed_in_analytics' %>
++<% end %>",Might we want to separate including this snippet and sending the data for signed in users into different partials?,"can we do `window.analytics.methods = ['identify"",""track"",""trackForm"",""trackClick"",""trackForm"",""ab"",""alias"",""on"",""off']` ? This will allow us to remove the `sign_in?` check completely."
+6149,"@@ -32,7 +32,11 @@ type PeerAdder interface {
+ }
+
+ type ClosestPeerer interface {
+-	ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
++	// ClosestPeer returns the closest connected peer we have in relation to a
++	// given chunk address.
++	// This function will ignore peers with addresses provided in skipPeers.
++	// Returns topology.ErrWantSelf in case base is the closest to the chunk.
++	ClosestPeer(addr swarm.Address, skipPeers ...swarm.Address) (peerAddr swarm.Address, err error)
+ }
+
+ type EachPeerer interface {",closest to the address,Would it make sense to return an error here if the skipPeers list is empty?
+6150,"@@ -18,13 +18,17 @@ const ROW_WIDTHS_MAP_NAME = 'autoRowSize';
+  * @plugin AutoRowSize
+  * @class AutoRowSize
+  * @description
+- * This plugin allows to set row heights based on their highest cells.
++ * The `AutoRowSize` plugin allows you to set row heights based on their highest cells.
+  *
+  * By default, the plugin is declared as `undefined`, which makes it disabled (same as if it was declared as `false`).
+  * Enabling this plugin may decrease the overall table performance, as it needs to calculate the heights of all cells to
+  * resize the rows accordingly.
+  * If you experience problems with the performance, try turning this feature off and declaring the row heights manually.
+  *
++ * But, to display Handsontable's [scrollbar](https://handsontable.com/docs/8.0.0/demo-scrolling.html)
++ * in a proper size, you need to enable the `AutoRowSize` plugin,
++ * by setting the [`autoRowSize`](@/api/options.md#autoRowSize) option to `true`.
++ *
+  * Row height calculations are divided into sync and async part. Each of this parts has their own advantages and
+  * disadvantages. Synchronous calculations are faster but they block the browser UI, while the slower asynchronous
+  * operations don't block the browser UI.",It should be much more clear for end-user  ,Please link to the `AutoRowSize` plugin and add a `@author` tag.
+6151,"@@ -82,7 +82,7 @@ SINGLE_QUOTED_REGEX = re.compile(""(%s)?'''"" % ""|"".join(_PREFIXES))
+ DOUBLE_QUOTED_REGEX = re.compile('(%s)?""""""' % ""|"".join(_PREFIXES))
+ QUOTE_DELIMITER_REGEX = re.compile(""(%s)?(\""|')"" % ""|"".join(_PREFIXES), re.DOTALL)
+
+-MSGS = {
++MSGS = {  # pylint: disable=consider-using-namedtuple
+     ""E1300"": (
+         ""Unsupported format character %r (%#02x) at index %d"",
+         ""bad-format-character"",","Isn't this an example that this will be prone to false positives ? We had nothing to fix in the codebase (And I think there is dict that could be named tuple in the MessageStore/MessageIdStore), but we have a false positives on our checkers.",E128 continuation line under-indented for visual indent
+6152,"@@ -55,11 +55,11 @@ func TestOpenCensus(t *testing.T) {
+ 	const provider = ""gocloud.dev/blob/memblob""
+
+ 	diff := octest.Diff(te.Spans(), te.Counts(), ""gocloud.dev/blob"", provider, []octest.Call{
+-		{""NewWriter"", gcerrors.OK},
+-		{""NewRangeReader"", gcerrors.OK},
+-		{""Attributes"", gcerrors.OK},
+-		{""Delete"", gcerrors.OK},
+-		{""NewRangeReader"", gcerrors.NotFound},
++		{Method: ""NewWriter"", Code: gcerrors.OK},
++		{Method: ""NewRangeReader"", Code: gcerrors.OK},
++		{Method: ""Attributes"", Code: gcerrors.OK},
++		{Method: ""Delete"", Code: gcerrors.OK},
++		{Method: ""NewRangeReader"", Code: gcerrors.NotFound},
+ 	})
+ 	if diff != """" {
+ 		t.Error(diff)","We control `octest`, so it shouldn't be necessary to provide struct literal keys. This is a case of vet being too picky.",This is a test for the new functionality.
+6153,"@@ -90,5 +90,8 @@ module DMPRoadmap
+     #   is_test                   - (NOT advisable because test plans are excluded from statistics)
+     #   privately_visible         - Only the owner and people they invite can access the plan
+     config.default_plan_visibility = 'privately_visible'
++
++    # The percentage of answered questions needed to enable the plan visibility section of the Share plan page
++    config.default_plan_percentage_answered = 50.00
+   end
+ end",I would put that constant under config/initializers/constant.rb and I would leave application.rb for rails specific.,Style/StringLiterals: Prefer double-quote
+6154,"@@ -572,7 +572,18 @@ func (fup folderUpdatePrepper) updateResolutionUsage(ctx context.Context,
+ // addUnrefToFinalResOp makes a resolutionOp at the end of opsList if
+ // one doesn't exist yet, and then adds the given pointer as an unref
+ // block to it.
+-func addUnrefToFinalResOp(ops opsList, ptr BlockPointer) opsList {
++func addUnrefToFinalResOp(ops opsList, ptr BlockPointer,
++	doNotUnref map[BlockPointer]bool) opsList {
++	// Make sure the block ID we want to unref isn't in the ""do not
++	// unref"" list -- it could mean that block has already been GC'd
++	// by the merged branch.  We can't compare pointers directly
++	// because GC'd pointers contain no block context.
++	for noUnref := range doNotUnref {
++		if ptr.ID == noUnref.ID {
++			return ops
++		}
++	}
++
+ 	resOp, ok := ops[len(ops)-1].(*resolutionOp)
+ 	if !ok {
+ 		resOp = newResolutionOp()","Is there a reason not to do something like `if _, ok := doNotUnref[ptr.ID]; ok { return ops }` here?",We may want to change the signature of `a
+6155,"@@ -539,7 +539,10 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            return self.size, self.location
+
+     @property
+     def screenshot_as_base64(self):",This would return a tuple of two dictionaries. You need to combine them and return a dictionary,I don't think this change is needed. `GET
+6156,"@@ -29,10 +29,10 @@ class Node(object):
+     def __repr__(self):
+         return self._class_repr()
+
+-    def __call__(self):
+-        return self._data()
++    def __call__(self, asa=None):
++        raise NotImplementedError
+
+-    def _data(self):
++    def _data(self, asa=None):
+         raise NotImplementedError
+
+ ",Why not always forward it to `_data`?,Is there a reason this needs to be `raise NotImplementedError` rather than `return self._data()`?
+6157,"@@ -263,7 +263,7 @@ def connect_spotify_callback():
+     return redirect(url_for('profile.connect_spotify'))
+
+
+-@profile_bp.route('/refresh-spotify-token', methods=['GET'])
++@profile_bp.route('/refresh-spotify-token', methods=['POST'])
+ @crossdomain()
+ @api_login_required
+ def refresh_spotify_token():",there are tests that use `client.get` which will fail now,Any thoughts on changing the `GET` to `POST`? I always prefer the latter.
+6158,"@@ -371,7 +371,7 @@ func (fs *FS) mkdirAll(filename string, perm os.FileMode) (err error) {
+ 		switch errors.Cause(err).(type) {
+ 		case libkbfs.NameExistsError:
+ 			// The child directory already exists.
+-		case libkbfs.WriteAccessError:
++		case libkbfs.WriteAccessError, libkbfs.WriteToReadonlyNodeError:
+ 			// If the child already exists, this doesn't matter.
+ 			var lookupErr error
+ 			child, _, lookupErr = fs.config.KBFSOps().Lookup(fs.ctx, n, p)","Whoa, TIL about this syntax.","I'm confused why `WriteToReadonlyNodeError` is here, shouldn't it be in `libkb/errors.go`?"
+6159,"@@ -34,12 +34,14 @@ type fakeHandler struct {
+ }
+
+ func (h fakeHandler) Handle(context.Context, *yarpc.Request, *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
+-	errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
+-	res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
+ 	if h.applicationErr != nil {
++		errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
++		res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
+ 		return res, nil, nil
++	} else if h.err != nil {
++		return nil, nil, h.err
+ 	}
+-	return res, nil, h.err
++	return &yarpc.Response{}, &yarpc.Buffer{}, nil
+ }
+
+ func (h fakeHandler) HandleStream(*yarpc.ServerStream) error {","This is a smell. When is this valid? Perhaps this should be `nil, nil, ErrNoResponse` or some such. While it is usually invalid to have neither a return value or error, we rarely check for the case in other idiomatic Go. Nothing wrong with extra defenses here, but think about it.",The `else if` should be removed here (and below).
+6160,"@@ -0,0 +1,7 @@
++_base_ = './faster_rcnn_r50_fpn_1x_coco.py'
++classes = ('person', 'bicycle', 'car')
++data = dict(
++    train=dict(classes=classes),
++    val=dict(classes=classes),
++    test=dict(classes=classes))
++load_from = 'https://s3.ap-northeast-2.amazonaws.com/open-mmlab/mmdetection/models/faster_rcnn_r50_fpn_1x_20181010-3d1b3351.pth'  # noqa","This URL is outdated, add a `TODO` to fix it.",Could you also add this to the `data` section in `__init__.py`?
+6161,"@@ -23,10 +23,13 @@ type (
+ 		Proto() *iotextypes.ActionCore
+ 		LoadProto(pbAct *iotextypes.ActionCore) error
+ 		SetNonce(n uint64)
++		ChainID() uint32
++		SetChainID(chainID uint32)
+ 	}
+
+ 	envelope struct {
+ 		version  uint32
++		chainID  uint32
+ 		nonce    uint64
+ 		gasLimit uint64
+ 		gasPrice *big.Int","`ChainID()` is a getter method, move up to `Nonce()`",Is this used anywhere?
+6162,"@@ -163,6 +163,10 @@ public class FlowTriggerScheduler {
+               flowId, flowTrigger, submitUser, quartzTriggers.isEmpty() ? null
+               : quartzTriggers.get(0), isPaused, flow.isLocked());
+         } catch (final Exception ex) {
++          if (QuartzScheduler.isSerializationBug(ex) && this.scheduler.enableSerializationHack()) {
++            logger.info(""Enable serialization hack"");
++            return getScheduledFlowTriggerJobs();
++          }
+           logger.error(""Unable to get flow trigger by job key {}"", jobKey, ex);
+           scheduledFlowTrigger = null;
+         }","If this condition is not met, shall we just throw the exception rather than logging it? @li-ygerchikov Your thoughts?",Should we log this message?
+6163,"@@ -57,6 +57,7 @@ REQUIRED_PACKAGES = [
+     'mock>=2.0.0',
+     'parameterized>=0.6.1',
+     'simple-crypt>=4.1.7',
++    'ruamel.yaml'
+ ]
+
+ if sys.version_info < (2, 7):",nit: alpha-sort `ruamel.yaml` in this list please,`ruamel.yaml` should not be included here.
+6164,"@@ -58,6 +58,15 @@ public class TableScanUtil {
+
+     Function<FileScanTask, Long> weightFunc = file -> Math.max(file.length(), openFileCost);
+
++    Preconditions.checkArgument(splitSize > 0,
++        ""Cannot create a plan with a split size that is not positive, splitSize = %s"", splitSize);
++
++    Preconditions.checkArgument(lookback > 0,
++        ""Cannot create a plan with a lookback that is not positive, lookback = %s"", lookback);
++
++    Preconditions.checkArgument(openFileCost >= 0,
++        ""Cannot create a plan with a openFileCost that is negative, openFileCost = %s"", openFileCost);
++
+     return CloseableIterable.transform(
+         CloseableIterable.combine(
+             new BinPacking.PackingIterable<>(splitFiles, splitSize, lookback, weightFunc, true),",Remove this because we already added it in another pr,s/can a plan/an open plan/ ?
+6165,"@@ -79,7 +79,13 @@ public class ShortcutManager {
+
+             try {
+                 if (shortcutDTO.getIcon() != null) {
+-                    File file = new File(shortcutDTO.getIcon());
++                    File file;
++                    try {
++                        file = new File(shortcutDTO.getIcon());
++                    } catch (IllegalArgumentException e) {
++                        // fallback to phoenicis.png
++                        file = new File(getClass().getResource(""phoenicis.png"").toExternalForm());
++                    }
+                     if (file.exists()) {
+                         FileUtils.copyFile(file, iconFile);
+                     }","Can we maybe move the `File` creation to a new method? I mean both changes look equal to me with the difference of two parts, which could be specified using two input parameters.","To avoid the exception, you "
+6166,"@@ -9,6 +9,8 @@ class ApiToken < ActiveRecord::Base
+
+   # TODO validates :access_token, presence: true
+   validates :approval_id, presence: true
++  validates :access_token, presence: true, allow_blank: true, length: { minimum: 0, maximum: 255 }
++  validates :user, presence: true, allow_blank: true
+
+   scope :unexpired, -> { where('expires_at >= ?', Time.now) }
+   scope :expired, -> { where('expires_at < ?', Time.now) }",I think we want to require the association with the user...?,Align the parameters of a me
+6167,"@@ -110,8 +110,17 @@ func (smsg *SignedMessage) VerifySignature() error {
+ }
+
+ // OnChainLen returns the amount of bytes used to represent the message on chain.
++// Dragons: verify this is the correct way to determine a signed messages size on chain.
+ func (smsg *SignedMessage) OnChainLen() uint32 {
+-	panic(""byteme"")
++	msgBits, err := encoding.Encode(smsg.Message)
++	if err != nil {
++		panic(err)
++	}
++	sigBits, err := encoding.Encode(smsg.Signature)
++	if err != nil {
++		panic(err)
++	}
++	return uint32(len(msgBits) + len(sigBits))
+ }
+
+ func (smsg *SignedMessage) String() string {","I am unsure the below implementation is correct, but need this method to not panic else it borks the chain-validation tests.",Shouldn't this be: return ui
+6168,"@@ -19,7 +19,7 @@ A wrapper class for Spark Column to behave similar to pandas Series.
+ """"""
+ import re
+ import inspect
+-from collections import Iterable
++from collections import Iterable, OrderedDict
+ from functools import partial, wraps
+ from typing import Any, Generic, List, Optional, Tuple, TypeVar, Union
+ ",nit: no need this change anymore.,This import does not appear to be used.
+6169,"@@ -1967,9 +1967,7 @@ class Codebase
+
+         $this->taint_flow_graph->addSource($source);
+
+-        $expr_type->parent_nodes = [
+-            $source->id => $source,
+-        ];
++        $expr_type->parent_nodes[$source->id] = $source;
+     }
+
+     /**","This isn't really that closely related to everything else in this PR, but I'm pretty sure it's a correct change. I'm not familiar enough with the taint feature to know how to test it, but I worry that without this change some of the taint stuff might mess up the `parent_nodes` for a reference.",Seems to me like the `addSource` functi
+6170,"@@ -6,8 +6,9 @@
+ package javaslang;
+
+ import javaslang.collection.Iterator;
+-import javaslang.collection.List;
+ import javaslang.collection.Seq;
++import javaslang.collection.Stream;
++import javaslang.collection.Vector;
+ import javaslang.control.Option;
+
+ import java.io.IOException;",[Checkstyle] ERROR: Unused import - javaslang.collection.Stream.,"I'm not sure why you did it this way, d"
+6171,"@@ -126,7 +126,7 @@ public class TestPseudoReturnFields extends SolrTestCaseJ4 {
+               ,""//result/doc/str[@name='ssto']""
+               ,""//result/doc/str[@name='subject']""
+
+-              ,""//result/doc[count(*)=4]""
++              ,""//result/doc[count(*)=5]""
+               );
+     }
+   }","The numbers were changed since now _root_ is also added to the doc, increasing the field count by 1.",is this affected by our precommit hook?
+6172,"@@ -169,12 +169,6 @@ class ArrayMapReturnTypeProvider implements FunctionReturnTypeProviderInterface
+                                 $function_call_arg->value->items[1]->value->value,
+                                 []
+                             );
+-                        } elseif ($variable_atomic_type instanceof TTemplateParamClass) {
+-                            $fake_method_call = new VirtualStaticCall(
+-                                $function_call_arg->value->items[0]->value,
+-                                $function_call_arg->value->items[1]->value->value,
+-                                []
+-                            );
+                         }
+                     }
+ ",TTemplateParamClass is handled above with the same content in the conditional,is there a specific reason why this is removed?
+6173,"@@ -597,6 +597,17 @@ class Upgrade
+             }
+         }
+
++        // Upgrade CAPTCHA Options
++        $oldKeys
++            = ['siteKey', 'publicKey', 'secretKey', 'privateKey'];
++        foreach ($oldKeys as $key) {
++            if (isset($newConfig['Captcha'][$key])) {
++                $newConfig['Captcha']['recaptcha_' . $key]
++                    = $newConfig['Captcha'][$key];
++                unset($newConfig['Captcha'][$key]);
++            }
++        }
++
+         // Warn the user about deprecated WorldCat settings:
+         if (isset($newConfig['WorldCat']['LimitCodes'])) {
+             unset($newConfig['WorldCat']['LimitCodes']);",Do we need to add `theme` here?,why not just `isset($newConfig['Captcha']['reca
+6174,"@@ -160,6 +160,9 @@ type Network struct {
+ 	// VPC defines the cluster vpc.
+ 	VPC *VPC `json:""vpc""`
+
++	// InternetGatewayID is the id of the internet gateway associated with the VPC.
++	InternetGatewayID *string `json:""internetGatewayId""`
++
+ 	// Subnets includes all the subnets defined inside the VPC.
+ 	Subnets Subnets `json:""subnets""`
+ }","i think you have to regen the api stuff, `make generate`",Does it make sense to call this `InternetGatewa
+6175,"@@ -187,9 +187,17 @@ public class SECP256K1 {
+     signer.init(true, privKey);
+
+     final BigInteger[] components = signer.generateSignature(dataHash.toArrayUnsafe());
+-    final BigInteger r = components[0];
+-    BigInteger s = components[1];
+
++    return normaliseSignature(components[0], components[1], keyPair.getPublicKey(), dataHash);
++  }
++
++  public static Signature normaliseSignature(
++      final BigInteger nativeR,
++      final BigInteger nativeS,
++      final PublicKey publicKey,
++      final Bytes32 dataHash) {
++
++    BigInteger s = nativeS;
+     // Automatically adjust the S component to be less than or equal to half the curve
+     // order, if necessary. This is required because for every signature (r,s) the signature
+     // (r, -s (mod N)) is a valid signature of the same message. However, we dislike the",DataHash shouldn't be needed here,These parameters aren't used anymore.
+6176,"@@ -110,7 +110,7 @@ public class WebDriverBackedSeleniumHandler implements Routable {
+     StringBuilder printableArgs = new StringBuilder(""["");
+     Joiner.on("", "").appendTo(printableArgs, args);
+     printableArgs.append(""]"");
+-    LOG.info(String.format(""Command request: %s%s on session %s"", cmd, printableArgs, sessionId));
++    LOG.finest(String.format(""Command request: %s%s on session %s"", cmd, printableArgs, sessionId));
+
+     if (""getNewBrowserSession"".equals(cmd)) {
+       // Figure out what to do. If the first arg is ""*webdriver"", check for a session id and use",`info` was chosen deliberately to mirror the old behaviour that users expected.,"This is probably fine, but should we consider changing the log level to debug?"
+6177,"@@ -31,8 +31,8 @@ describeComponent(
+                 component._selectize.setValue(['item 3', 'item 2']);
+             });
+
+-            expect(component.get('value'), 'component value').to.deep.equal(['item 3', 'item 2']);
+-            expect(component.get('selection'), 'component selection').to.deep.equal(['item 3', 'item 2']);
++            expect(component.get('value').toArray(), 'component value').to.deep.equal(['item 3', 'item 2']);
++            expect(component.get('selection').toArray(), 'component selection').to.deep.equal(['item 3', 'item 2']);
+         });
+     }
+ );","For some reason, Safari handles ember arrays differently than Chrome/Firefox. To get around that, we cast the ember array to a regular array to verify the deep equal. (Note: I tried wrapping the expected value in an emberA - which would look like `expect(someEmberArray).to.deep.equal(emberA(['a', 'b']));` but that didn't work either)",Why not check that `component.get('value')` is an array and `component.get('se
+6178,"@@ -36,6 +36,7 @@ public class VectorHolder {
+   private final Dictionary dictionary;
+   private final NullabilityHolder nullabilityHolder;
+   private final Type icebergType;
++  private final Type originalIcebergType;
+
+   public VectorHolder(
+       ColumnDescriptor columnDescriptor, FieldVector vector, boolean isDictionaryEncoded,","`icebergType` indicates the corresponding iceberg type of the `FieldVector` `originalIcebergType` indicates what the real type we will read from the `FieldVector`. For example, the parquet int backed decimal, the `icebergType` should be integer, `originalIcebergType` is decimal. I intend to only keep the `originalIcebergType`, but listening to your ideas.",What do you think about renaming `VectorHolder.originalIcebergType` to `Vector
+6179,"@@ -43,7 +43,7 @@
+ //  - Reader: *storage.Reader
+ //  - Attributes: storage.ObjectAttrs
+ //  - CopyOptions.BeforeCopy: *storage.Copier
+-//  - WriterOptions.BeforeWrite: *storage.Writer
++//  - WriterOptions.BeforeWrite: **storage.ObjectHandle, *storage.Writer
+ package gcsblob // import ""gocloud.dev/blob/gcsblob""
+
+ import (","The double (and thus triple as seen below) pointer gives me pause. I could imagine providing some larger API surface to smooth it out, but it's likely not worth it.",Why do we need to change this?
+6180,"@@ -1011,13 +1011,13 @@ describe('document', function() {
+   });
+
+   describe('Errors', function() {
+-    it('MongooseErrors should be instances of Error (gh-209)', function(done) {
++    it('MongooseError should be instances of Error (gh-209)', function(done) {
+       const MongooseError = require('../lib/error');
+       const err = new MongooseError('Some message');
+       assert.ok(err instanceof Error);
+       done();
+     });
+-    it('ValidationErrors should be instances of Error', function(done) {
++    it('ValidationError should be instances of Error', function(done) {
+       const ValidationError = Document.ValidationError;
+       const err = new ValidationError(new TestDocument);
+       assert.ok(err instanceof Error);","The test name as written was grammatically correct, but now it isn't. Both 'MongooseError' and 'instance' should be both singular or both plural.","I think we should keep `ValidationErrors` here, we don't have any other references to it."
+6181,"@@ -125,8 +125,8 @@ public class SmartStoreInspectorActivity extends Activity {
+
+ 	private void readExtras() {
+ 		Bundle bundle = getIntent().getExtras();
+-		isGlobal = bundle.getBoolean(IS_GLOBAL_STORE, false);
+-		dbName = bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
++		isGlobal = bundle == null ? false : bundle.getBoolean(IS_GLOBAL_STORE, false);
++		dbName = bundle == null ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ 	}
+
+ 	/**",SmartStoreInspectorTest was throwing a NPE here,Please use `Boolean.TRUE.equals(bundle)`
+6182,"@@ -134,9 +134,13 @@ public abstract class DeleteFilter<T> {
+
+       Iterable<CloseableIterable<Record>> deleteRecords = Iterables.transform(deletes,
+           delete -> openDeletes(delete, deleteSchema));
+-      StructLikeSet deleteSet = Deletes.toEqualitySet(
+-          // copy the delete records because they will be held in a set
+-          CloseableIterable.transform(CloseableIterable.concat(deleteRecords), Record::copy),
++
++      // copy the delete records because they will be held in a set
++      CloseableIterable<Record> records = CloseableIterable.transform(CloseableIterable.concat(deleteRecords),
++          Record::copy);
++
++      StructLikeSet deleteSet = Deletes.toEqualitySet(CloseableIterable.transform(records,
++          record -> new InternalRecordWrapper(deleteSchema.asStruct()).wrap(record)),
+           deleteSchema.asStruct());
+
+       Predicate<T> isInDeleteSet = record -> deleteSet.contains(projectRow.wrap(asStructLike(record)));","We prefer line wrapping that keeps arguments to the same method aligned rather than aligning arguments to different levels. Here, the lambda to create an `InternalRecordWrapper` is an argument to `transform`, but it is aligned with `deleteSchema.asStruct()` that is an argument to the outer `toEqualitySet` call. Instead, can you add a newline for each argument to `toEqualitySet`? If the line with the lambda is too long, then you can also add a newline for it that it indented from the start of the line with `transform`, so it is clear that it is an argument to `transform` and not `toEqualitySet`.",I don't think you need to wrap here. You can just pass `record` into `asStruct()` and wra
+6183,"@@ -173,6 +173,10 @@ import ServerConnections from '../ServerConnections';
+                     value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('<br/>')
+                 });
+             }
++            sessionStats.push({
++                label: globalize.translate('LabelHardwareEncoding'),
++                value: session.TranscodingInfo.HardwareAccelerationType
++            });
+         }
+
+         return sessionStats;","I think it would be a good idea to wrap this in an if like the stats above, just in case.","please remove the label, it's not used anywhere"
+6184,"@@ -289,6 +289,9 @@ public class LFMainActivity extends SharedMediaActivity {
+                     mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
+                     editMode = true;
+                 }
++                else {
++                    selectAllPhotosUpToFav(getImagePosition(m.getPath()));
++                }
+             } else selectAllPhotosUpTo(getImagePosition(m.getPath()), mediaAdapter);
+             return true;
+         }","@angmas1 just make one more change here too. Move the else line to the line above it, where the if block ends and remove the braces like in line 280.",This is the same as `selectAllPhotosUpToFav` already?
+6185,"@@ -21,7 +21,7 @@ func (s *BlkioGroup) Name() string {
+ }
+
+ func (s *BlkioGroup) Apply(path string, d *cgroupData) error {
+-	return join(path, d.pid)
++	return apply(path, d.pid)
+ }
+
+ func (s *BlkioGroup) Set(path string, r *configs.Resources) error {","Looks like the actual rename is missing in this commit edit: Arf, nevermind, I was at the wrong commit  ",Where is this used?
+6186,"@@ -67,7 +67,9 @@ module.exports = class Transloadit extends Plugin {
+     this._onRestored = this._onRestored.bind(this)
+     this._getPersistentData = this._getPersistentData.bind(this)
+
+-    if (this.opts.params) {
++    if (this.opts.params ||
++        // No params _and_ no custom getAssemblyOptions is an early error.
++        this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions) {
+       AssemblyOptions.validateParams(this.opts.params)
+     }
+ ","I'm a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)`  ",Is this still needed if `getAssemblyOptions` returns
+6187,"@@ -20,6 +20,15 @@ import (
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ )
+
++var (
++	// These patterns match a key of ""Vars"" in a daisy workflow. All CLI tools use these variables.
++	//
++	// For network and subnet, some workflows use the prefix `import_`.
++	networkPattern               = regexp.MustCompile(""^(import_)?network$"")
++	subnetPattern                = regexp.MustCompile(""^(import_)?subnet$"")
++	computeServiceAccountPattern = regexp.MustCompile(""compute_service_account"")
++)
++
+ // ApplyAndValidateVars is a WorkflowHook that applies vars to a daisy workflow.
+ // To ensure consistency across worker instances, if vars omits network, subnet, or the
+ // compute service account, the modifier will automatically apply these values.",networkVarPattern (etc) then?,Is this a new pattern? Can we use the same pattern el
+6188,"@@ -138,8 +138,10 @@ module RSpec
+
+         # don't clone the example group because the new example
+         # must belong to the same example group (not a clone).
++        #
++        # block is nil in new_metadata so we have to get it from metadata.
+         Example.new(example_group, description.clone,
+-                    new_metadata, new_metadata[:block])
++                    new_metadata, metadata[:block])
+       end
+
+       # @private","I think it makes sense to do `metadata[:block].clone`, as thats what `new_metadata` is, but somehow it's missing the block from its clone.",The `new_metadata[:block]` could be nil.
+6189,"@@ -51,10 +51,12 @@ class ClosureAnalyzer extends FunctionLikeAnalyzer
+      */
+     public function getClosureId(): string
+     {
+-        return strtolower($this->getFilePath())
+-            . ':' . $this->function->getLine()
+-            . ':' . (int)$this->function->getAttribute('startFilePos')
+-            . ':-:closure';
++        return strtolower(
++            $this->getFilePath()
++                . ':' . $this->function->getLine()
++                . ':' . (int)$this->function->getAttribute('startFilePos')
++                . ':-:closure'
++        );
+     }
+
+     /**",Just realized this should be fixed instead of changing here. Concatenating int should still result in lowercase string.,Why all the white spaces?
+6190,"@@ -79,7 +79,7 @@ module Selenium
+             opts[:browser_version] = opts.delete(:version) if opts.key?(:version)
+             opts[:platform_name] = opts.delete(:platform) if opts.key?(:platform)
+
+-            new({browser_name: 'firefox'}.merge(opts))
++            new({browser_name: 'firefox', marionette: true}.merge(opts))
+           end
+
+           alias_method :ff, :firefox",For Se 3.x we shouldn't need to specify `marionette: true`? I'll see if I can figure out where this is getting used that it might be necessary here.,this could be `opts.key?(:platform_name)
+6191,"@@ -34,14 +34,14 @@ func initStoreTest(ctx context.Context, t *testing.T, dstP *DefaultSyncerTestPar
+ 	requireSetTestChain(t, con, true, dstP)
+ }
+
+-func newChainStore(dstP *DefaultSyncerTestParams) chain.Store {
++func newChainStore(dstP *DefaultSyncerTestParams) *chain.DefaultStore {
+ 	r := repo.NewInMemoryRepo()
+ 	ds := r.Datastore()
+ 	return chain.NewDefaultStore(ds, dstP.genCid)
+ }
+
+ // requirePutTestChain adds all test chain tipsets to the passed in chain store.
+-func requirePutTestChain(t *testing.T, chainStore chain.Store, dstP *DefaultSyncerTestParams) {
++func requirePutTestChain(t *testing.T, chainStore *chain.DefaultStore, dstP *DefaultSyncerTestParams) {
+ 	ctx := context.Background()
+ 	genTsas := &chain.TipSetAndState{
+ 		TipSet:          dstP.genTS,","This should be renamed to `chain.Store`. It was named `DefaultStore` as an alternative to `StoreImpl`, which is the (bad) Java convention.",Why not return the chain store directly?
+6192,"@@ -85,8 +85,12 @@ func (a *AttachDisks) validate(ctx context.Context, s *Step) (errs DError) {
+ 		ad.zone = disk[""zone""]
+
+ 		// Register disk attachments.
+-		errs = addErrs(errs, s.w.instances.w.disks.regAttach(ad.Source, ad.Instance, ad.Mode, s))
+-
++		// If device name is not given explicitly, its device name will be the same as disk name.
++		deviceName := ad.Source
++		if ad.DeviceName != """" {
++			deviceName = ad.DeviceName
++		}
++		errs = addErrs(errs, s.w.instances.w.disks.regAttach(deviceName, ad.Source, ad.Instance, ad.Mode, s))
+ 	}
+ 	return errs
+ }","ad.Source is disk name? Shouldn't the order of initialization be reversed here then? First set ad.DeviceName, if it's empty, set ad.Source? Or this is a different use case? This is the third place where this device/disk default logic is implemented, so another reason to move it to regAttach, if it's possible to be generalized.","I think instead of passing a `DeviceName` as a parameter, we should pass `ad.DeviceName` directly to `regAttach`, and then convert it into the `DeviceName` parameter in `regAttach`"
+6193,"@@ -26,6 +26,11 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         [Output]
+         public ITaskItem[] PackageInfos { get; set; }
+
++        /// <summary>
++        /// Specify max number of minutes that the lock of the feed container will be hold.
++        /// </summary>
++        public int FeedLockTimeoutMinutes { get; set; } = int.MaxValue;
++
+         public override bool Execute()
+         {
+             return ExecuteAsync().GetAwaiter().GetResult();","typo: ""be hold"" -> ""be held""",Should this be configurable in the `DynamoSettings`?
+6194,"@@ -44,10 +44,10 @@ namespace Nethermind.Blockchain.Receipts
+
+         public long? LowestInsertedReceiptBlockNumber
+         {
+-            get => long.MaxValue;
++            get => 1;
+             set { }
+         }
+
+         public long MigratedBlockNumber { get; set; } = 0;
+     }
+-}
++}",I do not think we should have any logic inside the null storage. 1 has a very specific magical meaning. We should either return null here or long.maxValue.,This is a breaking change. Is there any way to maintain existing defaults?
+6195,"@@ -397,7 +397,7 @@ func TestInitProcessEnabled(t *testing.T) {
+ 	}
+ 	agent := RunAgent(t, nil)
+ 	defer agent.Cleanup()
+-	agent.RequireVersion("">=1.14.5"")
++	agent.RequireVersion("">=1.15.0"")
+
+ 	td, err := GetTaskDefinition(""init-process"")
+ 	if err != nil {",Why did this change?,This should be 1.15.0 now
+6196,"@@ -168,7 +168,6 @@ class PlansController < ApplicationController
+     render('/phases/edit', locals: {
+       base_template_org: phase.template.base_org,
+       plan: plan, phase: phase, readonly: readonly,
+-      question_guidance: plan.guidance_by_question_as_hash,
+       guidance_groups: guidance_groups,
+       answers: answers,
+       guidance_service: GuidanceService.new(plan) })","Removed this method. Doesn't seem to be used in the code, and the variable set here doesn't seem to be used in the views.",should we remove this whole page?
+6197,"@@ -16,7 +16,12 @@ namespace Microsoft.CodeAnalysis.Sarif
+     {
+         internal const string DEFAULT_POLICY_NAME = ""default"";
+
+-        public PropertyBagDictionary() : base() { }
++        public PropertyBagDictionary() : this(null) { }
++
++        public PropertyBagDictionary(PropertyBagDictionary initializer) :
++            this(initializer, null)
++        {
++        }
+
+         public PropertyBagDictionary(
+             PropertyBagDictionary initializer = null,","Remove the initializers (""`= null`"") from both parameters. Remember that that's why we added the overloads: to ensure that all languages could have the convenience of the abbreviated argument lists (not all languages understand default parameters).",@aparajit-pratap should this be `
+6198,"@@ -0,0 +1,13 @@
++package values
++
++import (
++	""github.com/influxdata/flux/semantic""
++)
++
++type Vector interface {
++	Value
++	ElementType() semantic.MonoType
++	Get(i int) Value
++	Set(i int, value Value)
++	Len() int
++}","I think you can just remove most of these attributes outside of `ElementType()`. Instead, this should expose the arrow array. We're not going to use these methods anyway.",This seems unrelated to the rest
+6199,"@@ -5,8 +5,7 @@ import { enqueueRender } from '../render-queue';
+ import { getNodeProps } from './index';
+ import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, removeChildren } from './diff';
+ import { createComponent, collectComponent } from './component-recycler';
+-
+-
++import remove from './remove';
+
+ /** Set a component's `props` (generally derived from JSX attributes).
+  *	@param {Object} props",Thinking this should be `removeNode()` exported from `dom/index.js`. Thoughts?,Please don't use a slash before t
+6200,"@@ -125,6 +125,10 @@ type Task struct {
+ 	// ENI is the elastic network interface specified by this task
+ 	ENI     *ENI
+ 	eniLock sync.RWMutex
++
++	// memoryCPULimitsEnabled to determine if task supports CPU, memory limits
++	memoryCPULimitsEnabled     bool
++	memoryCPULimitsEnabledLock sync.RWMutex
+ }
+
+ // PostUnmarshalTask is run after a task has been unmarshalled, but before it has been",Does this need to be saved in the state file? Or are we recomputing when the task is read from the state file?,Why is this a `RWMutex`?
+6201,"@@ -503,11 +503,11 @@ func (s *Sublist) Stats() *SublistStats {
+ 	st := &SublistStats{}
+ 	st.NumSubs = s.count
+ 	st.NumCache = uint32(len(s.cache))
+-	st.NumInserts = s.inserts
+-	st.NumRemoves = s.removes
+-	st.NumMatches = s.matches
+-	if s.matches > 0 {
+-		st.CacheHitRate = float64(s.cacheHits) / float64(s.matches)
++	st.NumInserts = atomic.LoadUint64(&s.inserts)
++	st.NumRemoves = atomic.LoadUint64(&s.removes)
++	st.NumMatches = atomic.LoadUint64(&s.matches)
++	if st.NumMatches > 0 {
++		st.CacheHitRate = float64(atomic.LoadUint64(&s.cacheHits)) / float64(st.NumMatches)
+ 	}
+ 	// whip through cache for fanout stats
+ 	tot, max := 0, 0","Looks like `s.inserts` and `s.removes` are updated under sublist's lock, so I don't think you need atomic for those 2.",don't you need an atomic
+6202,"@@ -39,7 +39,10 @@ void setUseStaticIP(bool enabled) {
+
+ void markGotIP() {
+   lastGetIPmoment = millis();
++  // Create the 'got IP event' so mark the wifiStatus to not have the got IP flag set
++  // This also implies the services are not fully initialized.
+   wifiStatus     &= ~ESPEASY_WIFI_GOT_IP;
++  wifiStatus     &= ~ESPEASY_WIFI_SERVICES_INITIALIZED;
+   processedGotIP = false;
+ }
+ ","@TD-er use bitRead/bitWrite macros, do you use here inversed logic?",I don't think this is co
+6203,"@@ -19,11 +19,11 @@
+ /**
+  * External dependencies
+  */
++import fetchMock from 'fetch-mock-jest';
+
+ /**
+  * WordPress dependencies
+  */
+-import apiFetch from '@wordpress/api-fetch';
+ import { createRegistry } from '@wordpress/data';
+
+ /**",The previous `fetch` mock was exposed globally before - can we do the same with `fetchMock` so we don't need to import it in every file?,We can remove this impor
+6204,"@@ -29,9 +29,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+             HttpRequestHeaders headers,
+             Http2Stream context)
+         {
+-            if (!context.ExpectData)
++            if (context.EndStreamReceived)
+             {
+-                return MessageBody.ZeroContentLengthClose;
++                return ZeroContentLengthClose;
+             }
+
+             return new ForHttp2(context);",Is ExpectData still used anywhere?,I don't understand why this change is needed. If `ExpectData` is true then we should return `ZeroContentLengthClose`. Otherwise we should always return `ZeroContentLengthClose`.
+6205,"@@ -230,7 +230,7 @@ class Docstring:
+
+ class SphinxDocstring(Docstring):
+     re_type = r""""""
+-        [~!]?                # Optional link style prefix
++        [~!.]?               # Optional link style prefix
+         \w(?:\w|\.[^\.])*    # Valid python name
+         """"""
+ ","Do you want to allow the character `.` or any character? Because inside a regex `.` means any character, if you want to authorize `.` then you need to add `\.` .",Please don't make unrelated changes.
+6206,"@@ -711,4 +711,18 @@ describe('QueryCursor', function() {
+       assert.deepEqual(arr, ['KICKBOXER', 'IP MAN', 'ENTER THE DRAGON']);
+     });
+   });
++  it('returns array for schema hooks gh-9982', () => {
++    const testSchema = new mongoose.Schema({ name: String });
++    testSchema.post('find', (result) => {
++      assert.ok(Array.isArray(result));
++    });
++    const Movie = db.model('Movie', testSchema);
++    return co(function*() {
++      yield Movie.deleteMany({});
++      yield Movie.create({ name: 'Daniel' }, { name: 'Val' }, { name: 'Daniel' });
++      yield Movie.find({ name: 'Daniel' }).cursor().eachAsync(doc => {
++        assert.ok(Array.isArray(doc));
++      });
++    });
++  });
+ });","`eachAsync()` should pass a doc, not an array of docs, to the callback. This would be a massive breaking change.","You don't need this, you can just do `assert.ok(Array.isArray(result))`"
+6207,"@@ -323,11 +323,11 @@ func (uc *UpstreamController) updatePodStatus(stop chan struct{}) {
+ 				}
+
+ 			default:
+-				klog.Infof(""pod status operation: %s unsupported"", msg.GetOperation())
++				klog.Warningf(""pod status operation: %s unsupported"", msg.GetOperation())
+ 			}
+-			klog.Infof(""message: %s process successfully"", msg.GetID())
++			klog.V(4).Infof(""message: %s process successfully"", msg.GetID())
+ 		case <-stop:
+-			klog.Info(""stop updatePodStatus"")
++			klog.Warning(""stop updatePodStatus"")
+ 			running = false
+ 		}
+ 	}",please start log with caps letters,Why are we changing this?
+6208,"@@ -10,4 +10,5 @@
+ <%= render 'layouts/typekit' %>
+ <%= csrf_meta_tag %>
+ <%= render 'layouts/ie_shiv' %>
++<%= render 'layouts/visual_website_optimizer' %>
+ <%= yield :head %>",Is this where we want it in relation to the other scripts?,do we need this in the controller? or can we just put it in the layout?
+6209,"@@ -13,6 +13,7 @@
+     _,
+     T
+  */
++ var FEATURE_NAME = ""reports"";
+
+ window.ReportingView = countlyView.extend({
+     featureName: 'reports',","Please wrap this variable within a self invoking anonymous function. (function(){ FEATURE_NAME = ""reports""; //and rest of the js goes here. })();",`FEATURE_NAME` is already defined in a file. No need to define it here.
+6210,"@@ -393,6 +393,14 @@ func (c *linuxContainer) Signal(s os.Signal, all bool) error {
+ 		if err := c.initProcess.signal(s); err != nil {
+ 			return fmt.Errorf(""unable to signal init: %w"", err)
+ 		}
++		if status == Paused {
++			// For cgroup v1, killing a process in a frozen cgroup
++			// does nothing until it's thawed. Only thaw the cgroup
++			// for SIGKILL.
++			if s, ok := s.(unix.Signal); ok && s == unix.SIGKILL {
++				_ = c.cgroupManager.Freeze(configs.Thawed)
++			}
++		}
+ 		return nil
+ 	}
+ 	return ErrNotRunning","Haven't tried, but what happens currently if `-f` is used and it's not running? (thinking: `-f` should ignore the case and just proceed?) I see we have a special case for `all`",Shouldn't we check for `s == unix.SIGKILL` as well?
+6211,"@@ -1,10 +1,11 @@
+ 'use strict';
+ const { MongoClient } = require('../../src');
+ const { expect } = require('chai');
++const { MongoURIError } = require('../../src/error');
+
+ describe('LDAP', function () {
+   if (process.env.MONGODB_URI == null) {
+-    throw new Error(`skipping SSL tests, MONGODB_URI environment variable is not defined`);
++    throw new MongoURIError(`skipping SSL tests, MONGODB_URI environment variable is not defined`);
+   }
+
+   it('Should correctly authenticate against ldap', function (done) {",no need for custom errors in tests unless the tests are intended to mock a specific sort of error,Why can't we just use `require('../src/error')` here instead?
+6212,"@@ -21,4 +21,6 @@ const (
+ 	NvidiaGPUStatusAnnotationKey = ""huawei.com/gpu-status""
+ 	// NvidiaGPUScalarResourceName is the device plugin resource name used for special handling
+ 	NvidiaGPUScalarResourceName = ""nvidia.com/gpu""
++
++	EdgeNodeRoleLabelKey = ""node-role.kubernetes.io/edge""
+ )","This const has already existed in the code, no need to define a new one",Can we make this consistent with the naming convention of `EdgeNodeRoleAnnotationKey`?
+6213,"@@ -362,7 +362,7 @@ func captureErrorLogs(algohConfig algoh.HostConfig, errorOutput stdCollector, ou
+
+ func reportErrorf(format string, args ...interface{}) {
+ 	fmt.Fprintf(os.Stderr, format, args...)
+-	logging.Base().Fatalf(format, args...)
++	logging.Base().Warnf(format, args...)
+ }
+
+ func sendLogs() {",Would Errorf be better than Warnf?,is this function used somewhere?
+6214,"@@ -93,15 +93,16 @@ public class JSExport {
+   }
+
+   public static String getCordovaPluginJS(Context context) {
+-    return getFilesContent(context, ""public/plugins"", """");
++    return getFilesContent(context, ""public/plugins"");
+   }
+
+-  public static String getFilesContent(Context context, String path, String currentContent) {
++  public static String getFilesContent(Context context, String path) {
++    String currentContent = """";
+     try {
+       String[] content = context.getAssets().list(path);
+       if (content.length  > 0) {
+         for (String file: content) {
+-          currentContent += getFilesContent(context, path+""/""+file, currentContent);
++          currentContent += getFilesContent(context, path+""/""+file);
+         }
+       } else {
+         return getJS(context, path);","A good candidate for StringBuilder? Also make sure to add white space around the operators (`path + ""/"" + file`)",Is this change needed? I don't see a new test case for this.
+6215,"@@ -200,4 +200,17 @@ public interface ProjectLoader {
+       throws ProjectManagerException;
+
+   void updateProjectSettings(Project project) throws ProjectManagerException;
++
++  /**
++   * Uploads flow file.
++   */
++  void uploadFlowFile(int projectId, int projectVersion, int flowVersion,
++      File flowFile) throws ProjectManagerException;
++
++  /**
++   * Gets flow file that's uploaded.
++   */
++  File getUploadedFlowFile(int projectId, int projectVersion, String flowName, int
++      flowVersion) throws ProjectManagerException;
++
+ }",Can we have the same argument order as `getUploadedFlowFile`?,Minor: I would say: `Uploading flow file that's uploaded`
+6216,"@@ -46,7 +46,7 @@ type (
+ 		RangeSize                    int64
+ 		GetTasksBatchSize            dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters
+ 		UpdateAckInterval            dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
+-		IdleTaskqueueCheckInterval   dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
++		IdleTaskqueueCheckInterval   dynamicconfig.DurationPropertyFn
+ 		MaxTaskqueueIdleTime         dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
+ 		NumTaskqueueWritePartitions  dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters
+ 		NumTaskqueueReadPartitions   dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters","this dynamic config should still be valid, i.e. operator should have the ability to control each individual task queue just in case",Why was this removed?
+6217,"@@ -394,6 +394,17 @@ class VirtualBufferTextInfo(browseMode.BrowseModeDocumentTextInfo,textInfos.offs
+ 		obj = self.obj.getNVDAObjectFromIdentifier(docHandle, nodeId)
+ 		return obj.mathMl
+
++	def scrollIntoView(self):
++		# Scroll the deepest object at this point into view.
++		obj = self.NVDAObjectAtStart
++		if not obj:
++			return
++		if obj == self.obj.rootNVDAObject:
++			# However never scroll to the  document itself
++			return
++		obj.scrollIntoView()
++
++
+ class VirtualBuffer(browseMode.BrowseModeDocumentTreeInterceptor):
+
+ 	TextInfo=VirtualBufferTextInfo",Should these cases be logged? `if not obj` used to be,Why do we need this f
+6218,"@@ -0,0 +1,19 @@
++require 'travis/build/appliances/base'
++
++module Travis
++  module Build
++    module Appliances
++      class UpdateAptKeys < Base
++        def apply
++          command = <<-EOF
++          if command -v apt-get &>/dev/null && [[ -d /var/lib/apt/lists ]]; then
++            LANG=C apt-key list | awk -F'[ /]+' '/expired:/{printf ""apt-key adv --recv-keys --keyserver keys.gnupg.net %s\\n"", $3}' | sudo sh &>/dev/null
++          fi
++          EOF
++          sh.cmd command, echo: false
++        end
++      end
++    end
++  end
++end
++",Is it OK to assume that keys.gnupg.net has the new key?,Rails/Output: Do not
+6219,"@@ -128,11 +128,6 @@ class FileSystem(object):
+                              exist, raise luigi.target.MissingParentDirectory
+         :param bool raise_if_exists: raise luigi.target.FileAlreadyExists if
+                                      the folder already exists.
+-
+-        *Note*: This method is optional, not all FileSystem subclasses implements it.
+-
+-        *Note*: parents and raise_if_exists were added in August 2014. Some
+-                implementations might not support these flags yet.
+         """"""
+         raise NotImplementedError(""mkdir() not implemented on {0}"".format(self.__class__.__name__))
+ ","A note for however is curious. I think these two notes add negative value only. In general we want people to implement this method (in particular after this patch). If we leave these old (and currently mis-rendered) notes, file system implementors might not implement this method referring to this.",How do we plan to rem
+6220,"@@ -216,15 +216,12 @@ public class PriorityQueueTest extends AbstractTraversableTest {
+         empty().dequeue();
+     }
+
+-    // -- toSortedQueue
++    // -- toPriorityQueue
+
+     @Test
+-    public void shouldKeepInstanceOfSortedQueue() {
+-        final SerializableComparator<Integer> comparator = naturalComparator();
+-        final PriorityQueue<Integer> queue = PriorityQueue.of(comparator, 1, 3, 2);
+-        if (!queue.isSingleValued()) {
+-            assertThat(queue.toSortedQueue(comparator)).isSameAs(queue);
+-        }
++    public void shouldKeepInstanceOfPriorityQueue() {
++        final PriorityQueue<Integer> queue = PriorityQueue.of(1, 3, 2);
++        assertThat(queue.toPriorityQueue()).isSameAs(queue);
+     }
+
+     // -- property based tests","Comparators (or functions in general) cannot be compared for equality. Therefore `PriorityQueue.of(comparator, ...)` always has to return a new instance.",Does it make sense to remove this `shouldKeepInstanceOfSortedQueue()` method?
+6221,"@@ -27,7 +27,7 @@ module Bolt
+
+       @noop = noop
+       @run_as = nil
+-      @pool = Concurrent::CachedThreadPool.new(max_threads: @config[:concurrency])
++      @pool = Concurrent::ThreadPoolExecutor.new(max_threads: @config[:concurrency])
+       @logger.debug { ""Started with #{@config[:concurrency]} max thread(s)"" }
+       @notifier = Bolt::Notifier.new
+     end",It's a little surprising that CachedThreadPool overrides the max_threads argument. This makes sense as a solution though.,Line is too long. [81/80]
+6222,"@@ -42,12 +42,14 @@ def weight_reduce_loss(loss, weight=None, reduction='mean', avg_factor=None):
+     # if avg_factor is not specified, just reduce the loss
+     if avg_factor is None:
+         loss = reduce_loss(loss, reduction)
+-    # otherwise average the loss by avg_factor
+-    else:
+-        if reduction != 'mean':
+-            raise ValueError(
+-                'avg_factor can only be used with reduction=""mean""')
++    # if avg_factor are specified
++    # if reduction is mean, reduce the loss sum by avg factor
++    elif reduction == 'mean':
+         loss = loss.sum() / avg_factor
++    elif reduction == 'none':
++        loss = loss
++    else:
++        raise ValueError('avg_factor can not be used with reduction=""sum""')
+     return loss
+
+ ","```python # if avg_factor is not specified, just reduce the loss if avg_factor is None: loss = reduce_loss(loss, reduction) else: # if reduction is mean, then average the loss by avg_factor if reduction == 'mean': loss = loss.sum() / avg_factor # if reduction is 'none', then do nothing, otherwise raise an error elif reduction != 'none': raise ValueError('avg_factor can not be used with reduction=""sum""')",This is wrong now that `reduce_loss` cannot be used with `mean` or `none`.
+6223,"@@ -46,9 +46,9 @@ class BasicBlock(nn.Module):
+             planes,
+             planes,
+             3,
+-            stride=stride,
+-            padding=dilation,
+-            dilation=dilation,
++            stride=1,
++            padding=1,
++            dilation=1,
+             bias=False)
+         self.add_module(self.norm2_name, norm2)
+ ",`padding` should be 0 instead. Actually you can just remove padding and dilation to use default values.,"Just curious, why did you change the default value of stride and dilation?"
+6224,"@@ -1447,7 +1447,7 @@ class Aleph extends AbstractBase implements \Laminas\Log\LoggerAwareInterface,
+             $checkout = $finesListSort[$key][""checkout""];
+             $transactiondate = $finesListSort[$key][""transactiondate""];
+             $transactiontype = $finesListSort[$key][""transactiontype""];
+-            $balance += $finesListSort[$key][""amount""];
++            $balance = $finesListSort[$key][""amount""];
+             $id = $finesListSort[$key][""id""];
+             $fine = $finesListSort[$key][""fine""];
+             $finesList[] = [","$balance is initialized to 0 above in line 1428 and then assigned in line 1437. If we're no longer manipulating that value, is there a reason to use a variable at all? It might make the overall code less confusing to make some changes there.","The calculation of $balance and $finesListSort[$key][""amount""] is done in one place. Is it really needed ?"
+6225,"@@ -73,9 +73,9 @@ class SeriesPlotTest(ReusedSQLTestCase, TestUtils):
+         pdf = self.pdf1
+         kdf = self.kdf1
+
+-        ax1 = pdf['a'].plot(""bar"", colormap='Paired')
++        ax1 = pdf['a'].plot(kind=""bar"", colormap='Paired')
+         bin1 = self.plot_to_base64(ax1)
+-        ax2 = kdf['a'].plot(""bar"", colormap='Paired')
++        ax2 = kdf['a'].plot(kind=""bar"", colormap='Paired')
+         bin2 = self.plot_to_base64(ax2)
+         self.assertEqual(bin1, bin2)
+ ",Why do we need to explicitly use keyword arguments?,"These are the same, `pdf['a'].plot(kind=""bar"", colormap='Paired"")`"
+6226,"@@ -708,7 +708,8 @@ func (c *Client) updateProgress(tid int, target *core.BuildTarget, metadata *pb.
+ 		case pb.ExecutionStage_EXECUTING:
+ 			c.state.LogBuildResult(tid, target.Label, core.TargetBuilding, ""Building..."")
+ 		case pb.ExecutionStage_COMPLETED:
+-			c.state.LogBuildResult(tid, target.Label, core.TargetBuilt, ""Built"")
++			// The build result will be logged in build/build_step.go
++			return
+ 		}
+ 	} else {
+ 		switch metadata.Stage {",Might still want to log this as `TargetBuilding` but with a slightly different message?,Why remove this? Is it related to the build?
+6227,"@@ -6,6 +6,17 @@
+
+ C015_queue_element::C015_queue_element() {}
+
++C015_queue_element::C015_queue_element(C015_queue_element&& other)
++  : idx(other.idx), _timestamp(other._timestamp), TaskIndex(other.TaskIndex)
++  , controller_idx(other.controller_idx), valuesSent(other.valuesSent)
++  , valueCount(other.valueCount)
++{
++  for (byte i = 0; i < VARS_PER_TASK; ++i) {
++    txt[i]  = std::move(other.txt[i]);
++    vPin[i] = other.vPin[i];
++  }
++}
++
+ C015_queue_element::C015_queue_element(const struct EventStruct *event, byte value_count) :
+   idx(event->idx),
+   TaskIndex(event->TaskIndex),","ref. above, this also can be omitted in case `txt = std::move(other.txt);` could work (or copy), consider `std::array<String, VARS_PER_TASK>;`? or a custom object implementing `Object& operator=(Object&&) noexcept;'",May as well make this `const` since it's not being changed by this PR.
+6228,"@@ -10,7 +10,7 @@
+
+ """"""Looks for try/except statements with too much code in the try clause.""""""
+
+-from astroid.node_classes import For, If, While, With
++from astroid import nodes
+
+ from pylint import checkers, interfaces
+ ","Well done, we forget that one apparentely.",Why was this removed?
+6229,"@@ -25,17 +25,6 @@ except:
+     xr = None
+
+
+-def toarray(v, index_value=False):
+-    """"""
+-    Interface helper function to turn dask Arrays into numpy arrays as
+-    necessary. If index_value is True, a value is returned instead of
+-    an array holding a single value.
+-    """"""
+-    if dask and isinstance(v, dask.array.Array):
+-        arr =  v.compute()
+-        return arr[()] if index_value else arr
+-    else:
+-        return v
+
+ def compute_edges(edges):
+     """"""",Guess it isn't used. The dask thing was just a prototype so removing it is probably the right thing to do.,I think this is still
+6230,"@@ -12,7 +12,17 @@ from elasticsearch.helpers import bulk
+ from t4_lambda_shared.preview import ELASTIC_LIMIT_BYTES
+
+
+-CONTENT_INDEX_EXTS = [
++def _get_extension_overrides():
++    """"""check the environment for index extension overrides; this is a standalone
++    function so that it can be unit tested""""""
++    return {
++        t.strip().lower()
++        for t in os.getenv(""CONTENT_INDEX_EXTS"", """").split("","")
++        if t.strip().startswith(""."")
++    }
++
++
++CONTENT_INDEX_EXTS = _get_extension_overrides() or {
+     "".csv"",
+     "".ipynb"",
+     "".md"",","This code is correct, but it's a bit confusing to see how (e.g., without the if startswith("".') the or below would break.) I think it will be clearer for the long run if you refactor this just a bit. CONTENT_INDEX_EXTS (all caps) looks like a constant, but is now being set by the environment. Instead, replace the reference to CONTENT_INDEX_EXTS in index.py with a simple call to a method ""get_content_index_exts"" (or similar). Then you can write all the logic into one clean function.",nit: This is a privat
+6231,"@@ -298,4 +298,9 @@ public final class ZMSConsts {
+     public static final int ZMS_DISABLED_AUTHORITY_FILTER = 0x01;
+
+     public static final String ZMS_PROP_STATUS_CHECKER_FACTORY_CLASS = ""athenz.zms.status_checker_factory_class"";
++
++    public static final String ZMS_PROP_ENABLE_PRINCIPAL_STATE_UPDATER        = ""athenz.zms.enable_principal_state_updater"";
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY = ""athenz.zms.principal_state_updater_frequency"";
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY_DEFAULT = ""30""; // in minutes
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_DISABLE_TIMER = ""athenz.zms.disable_principal_state_updater_timer_task"";
+ }",please update the zms conf file to have a small description of these options since by default feature is off and must be enabled,If these properties a
+6232,"@@ -31,7 +31,12 @@ module.exports = class ThumbnailGenerator extends Plugin {
+     const defaultOptions = {
+       thumbnailWidth: null,
+       thumbnailHeight: null,
+-      waitForThumbnailsBeforeUpload: false
++      waitForThumbnailsBeforeUpload: false,
++      lazy: false
++    }
++
++    if (defaultOptions.lazy && defaultOptions.waitForThumbnailsBeforeUpload) {
++      throw new Error('ThumbnailGenerator: The `lazy` and `waitForThumbnailsBeforeUpload` options are mutually exclusive. Please ensure at most one of them is set to `true`.')
+     }
+
+     this.opts = { ...defaultOptions, ...opts }",Should be `this.opts` instead of `defaultOptions`,"This error message might be confusing. Maybe something like ""ThumbnailGenerator: The `lazy` option is mutually exclusive. Please ensure at most one of them is set to true."""
+6233,"@@ -27,6 +27,7 @@ const pkgVersion = module.exports.version;
+ const pkgName = module.exports.name;
+
+ export const DIST_TAGS = 'dist-tags';
++export const USERS = 'users';
+
+ export function getUserAgent(): string {
+   assert(_.isString(pkgName));",You can reuse `USERS` above as well.,can we have a more generic name like `USER_GROUP_NAME` or similar?
+6234,"@@ -460,11 +460,6 @@ public final class Util {
+           continue;
+         }
+
+-        if (results.size() == topN-1 && maxQueueDepth == topN) {
+-          // Last path -- don't bother w/ queue anymore:
+-          queue = null;
+-        }
+-
+         // We take path and find its ""0 output completion"",
+         // ie, just keep traversing the first arc with
+         // NO_OUTPUT that we can find, since this must lead","Whoa, was this opto breaking something? I guess if this final path is filtered out, we still need the queue? Have you run the suggest benchmarks to see if removing this opto hurt performance?",why was this removed?
+6235,"@@ -191,7 +191,7 @@ final class Collections {
+         if (iterable instanceof Seq) {
+             return (Seq<T>) iterable;
+         } else {
+-            return List.ofAll(iterable);
++            return Stream.ofAll(iterable);
+         }
+     }
+ }","I'm not sure about this, please check the usages. It's only used currently to reverse it, maybe we should eliminate this method completely instead.",This looks like an unrelated change?
+6236,"@@ -638,6 +638,18 @@ class AbstractBase extends AbstractActionController
+         return $check->getTagSetting() !== 'disabled';
+     }
+
++    /**
++     * Are list tags enabled?
++     *
++     * @return bool
++     */
++    protected function listTagsEnabled()
++    {
++        $check = $this->serviceLocator
++            ->get(\VuFind\Config\AccountCapabilities::class);
++        return $check->getListTagSetting() === 'enabled';
++    }
++
+     /**
+      * Store a referer (if appropriate) to keep post-login redirect pointing
+      * to an appropriate location. This is used when the user clicks the","Since this is only used in the MyResearchController, does it need to be placed at the AbstractBase level?","`$this->serviceLocator` is enough, you don't need to access it directly"
+6237,"@@ -55,7 +55,7 @@ type SelectorSpec struct {
+ 	// +optional
+ 	AnnotationSelectors map[string]string `json:""annotationSelectors,omitempty""`
+
+-	// PodPhaseSelector is a set of condition of a pod at the current time.
++	// PhaseSelector is a set of condition of a pod at the current time.
+ 	// supported value: Pending / Running / Succeeded / Failed / Unknown
+ 	PodPhaseSelectors []string `json:""phaseSelector,omitempty""`
+ }",why `PhaseSelector` ?,Why is this changing? I don't see any mention in the PR description.
+6238,"@@ -32,6 +32,8 @@ type rawConfig struct {
+ 	RestrictedLicenses []string `json:""restricted_licenses""`
+
+ 	// modules that get completely ignored during analysis
++	AllowlistedModules []string `json:""allowlisted_modules""`
++	// Deprecated. TODO(tbarrella): Clean up
+ 	WhitelistedModules []string `json:""whitelisted_modules""`
+ }
+ ",Does` AllowlistedModules` have the same meaning of `WhitelistedModules`?,Cleaning up old data shouldn't be necessary.
+6239,"@@ -357,7 +357,7 @@ return [
+ 'ArithmeticError::getTrace' => ['array<int,array<string,mixed>>'],
+ 'ArithmeticError::getTraceAsString' => ['string'],
+ 'array_change_key_case' => ['array|false', 'input'=>'array', 'case='=>'int'],
+-'array_chunk' => ['array[]', 'input'=>'array', 'size'=>'int', 'preserve_keys='=>'bool'],
++'array_chunk' => ['list<array>', 'input'=>'array', 'size'=>'int', 'preserve_keys='=>'bool'],
+ 'array_column' => ['array', 'array'=>'array', 'column_key'=>'mixed', 'index_key='=>'mixed'],
+ 'array_combine' => ['array|false', 'keys'=>'string[]|int[]', 'values'=>'array'],
+ 'array_count_values' => ['int[]', 'input'=>'array'],","I missed the $preserve_keys=true case when adding this to Phan. For psalm, two separate signatures may make sense",Shouldn't this be `array_chunk`?
+6240,"@@ -18,14 +18,19 @@
+ package org.apache.servicecomb.foundation.vertx.server;
+
+ import java.net.InetSocketAddress;
++import java.util.concurrent.atomic.AtomicInteger;
+
++import org.apache.servicecomb.foundation.common.event.EventManager;
+ import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
+ import org.apache.servicecomb.foundation.ssl.SSLCustom;
+ import org.apache.servicecomb.foundation.ssl.SSLOption;
+ import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
+ import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
++import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+ import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+
++import com.netflix.config.DynamicPropertyFactory;
++
+ import io.vertx.core.Vertx;
+ import io.vertx.core.net.NetServer;
+ import io.vertx.core.net.NetServerOptions;",TcpServer will be created for each HighwayServerVerticle instance so the counter number in server is not correct.,Why not `com.netflix.config.DynamicPropertyFactory`?
+6241,"@@ -109,10 +109,14 @@ public class WindowsUtils {
+      * quote (\""?)
+      */
+     // TODO We should be careful, in case Windows has ~1-ified the executable name as well
+-    pattern.append(""\""?.*?\\\\"");
+-    pattern.append(executable.getName());
++    pattern.append(""(\""?.*?\\\\)?"");
++    String execName = executable.getName();
++    pattern.append(execName);
++    if (!execName.endsWith("".exe"")) {
++      pattern.append(""(\\.exe)?"");
++    }
+     pattern.append(""\""?"");
+-    for (String arg : cmdarray) {
++    for (int i = 1; i < cmdarray.length; i++) {
+       /*
+        * There may be a space, but maybe not (\\s?), may be a quote or maybe not (\""?), but then
+        * turn on block quotation (as if *everything* had a regex backslash in front of it) with \Q.",Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it.,"Shouldn't this be <code> if (!execName.endsWith("".ex"
+6242,"@@ -116,6 +116,12 @@ func FindCgroupMountpoint(cgroupPath, subsystem string) (string, error) {
+ 		return """", errUnified
+ 	}
+
++	// If subsystem is empty it means that we are looking for the
++	// cgroups2 path
++	if len(subsystem) == 0 {
++		return hybridMountpoint, nil
++	}
++
+ 	// Avoid parsing mountinfo by trying the default path first, if possible.
+ 	if path := tryDefaultPath(cgroupPath, subsystem); path != """" {
+ 		return path, nil","I'd say ""cgroup2 hybrid path"" instead.",Do we need a test for this?
+6243,"@@ -84,15 +84,12 @@ module Bolt
+       {
+         'name' => name,
+         'uri' => uri,
+-        'alias' => @target_alias,
+-        'config' => config.merge(
+-          'transport' => transport,
+-          transport => options
+-        ),
++        'alias' => target_alias,
++        'config' => Bolt::Util.deep_merge(config, 'transport' => transport, transport => options),
+         'vars' => vars,
+         'features' => features,
+         'facts' => facts,
+-        'plugin_hooks' => Bolt::Util.deep_clone(plugin_hooks)
++        'plugin_hooks' => plugin_hooks
+       }
+     end
+ ",I dont see a reason to print URI for `Target`. we do not expose that in inventory v1,Metrics/LineLength: Line is too long. [81/80]
+6244,"@@ -131,9 +131,13 @@ type OpExpression struct {
+ type ValueExpression struct {
+ 	String  string
+ 	FString *FString
+-	Int     *struct {
+-		Int int
+-	} // Should just be *int, but https://github.com/golang/go/issues/23498 :(
++	// These are true if this represents one of the boolean singletons
++	True  bool
++	False bool
++	None  bool
++	// True if the Int field is set; this helps us distinguish values of 0.
++	IsInt    bool
++	Int      int
+ 	Bool     string
+ 	List     *List
+ 	Dict     *Dict",Do we still need this?,"These are true if the boolean is singletons, so we don't need to distinguish them."
+6245,"@@ -79,9 +79,13 @@ type Application struct {
+ type Gclient struct {
+ 	// constant tracking-id used to send a hit
+ 	trackID string
++
+ 	// anonymous client-id
+ 	clientID string
+
++	// anonymous campaign source
++	campaignSource string
++
+ 	// https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds
+ 	// (usecase) node-detail
+ 	dataSource string",`campaignSource` is unused (from `structcheck`),should this be a pointer since it's optional?
+6246,"@@ -63,6 +63,7 @@ public final class BaselineErrorProne implements Plugin<Project> {
+     private static final Logger log = Logging.getLogger(BaselineErrorProne.class);
+     public static final String EXTENSION_NAME = ""baselineErrorProne"";
+     private static final String ERROR_PRONE_JAVAC_VERSION = ""9+181-r4173-1"";
++    private static final String ASSERTJ_ERROR_PRONE_VERSION = ""0.2.1"";
+     private static final String PROP_ERROR_PRONE_APPLY = ""errorProneApply"";
+     private static final String PROP_REFASTER_APPLY = ""refasterApply"";
+     private static final String DISABLE_PROPERY = ""com.palantir.baseline-error-prone.disable"";",we should discuss how to not hard-code this version,should this be 0.3.1?
+6247,"@@ -5,8 +5,14 @@ const isResumableError = require('./error').isResumableError;
+ const MongoError = require('./core').MongoError;
+ const ReadConcern = require('./read_concern');
+ const MongoDBNamespace = require('./utils').MongoDBNamespace;
++const Cursor = require('./cursor');
++const relayEvents = require('./core/utils').relayEvents;
++const maxWireVersion = require('./core/utils').maxWireVersion;
+
+-var cursorOptionNames = ['maxAwaitTimeMS', 'collation', 'readPreference'];
++const CHANGE_STREAM_OPTIONS = ['resumeAfter', 'startAfter', 'startAtOperationTime', 'fullDocument'];
++const CURSOR_OPTIONS = ['batchSize', 'maxAwaitTimeMS', 'collation', 'readPreference'].concat(
++  CHANGE_STREAM_OPTIONS
++);
+
+ const CHANGE_DOMAIN_TYPES = {
+   COLLECTION: Symbol('Collection'),",do we have a doclet for this event?,You can also use `CHANGE_STREAM_OPTIONS` and `CURSOR_OPTIONS` in this file.
+6248,"@@ -35,10 +35,11 @@ if (isNodeProcess && process.platform === 'win32') {
+ }
+
+ // catching segfaults during testing can help debugging
+-if (isNodeProcess) {
+-    const SegfaultHandler = node_require('segfault-handler');
+-    SegfaultHandler.registerHandler(""crash.log"");
+-}
++//uncomment to enable segfault handler
++//if (isNodeProcess) {
++    //const SegfaultHandler = node_require('segfault-handler');
++    //SegfaultHandler.registerHandler(""crash.log"");
++//}
+
+ var TESTS = {
+     ListTests: require('./list-tests'),",Why don't we want to catch segfaults by default?,why are we not registering segfault handler here?
+6249,"@@ -137,6 +137,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+             return result;
+         }
+
++        [System.Diagnostics.CodeAnalysis.SuppressMessage(""Reliability"", ""CA2000:Dispose objects before losing scope"", Justification = ""The object should not be disposed"")]
+         private Task SendBatchActivityAsync(IEnumerable<Activity> batchActivity, CancellationToken cancellationToken)
+         {
+             var requestUri = this.options.Endpoint;",You could probably dispose request & content if you `await` the SendAsync.,Should we suppress this message also for the `Sen
+6250,"@@ -35,6 +35,16 @@ class UtilsTest(ReusedSQLTestCase, SQLTestUtils):
+         }, index=[0, 1, 3])
+         validate_arguments_and_invoke_function(pdf, self.to_html, pd.DataFrame.to_html, args)
+
++    def to_clipboard(self, sep=',', **kwargs):
++        args = locals()
++
++        pdf = pd.DataFrame({
++            'a': [1, 2, 3],
++            'b': [4, 5, 6],
++        }, index=[0, 1, 3])
++        validate_arguments_and_invoke_function(pdf, self.to_clipboard,
++                                               pd.DataFrame.to_clipboard, args)
++
+     def test_validate_arguments_and_invoke_function(self):
+         # This should pass and run fine
+         self.to_html()",why is this test case here? this file is for testing functionalities in utils.py,"Is the `sep` argument used somewhere? If not, ple"
+6251,"@@ -31,6 +31,15 @@ class AuthController < ApplicationController
+   def do_user_auth(auth)
+     sign_out
+     user = User.from_oauth_hash(auth)
++    unless ENV[""NO_WELCOME_EMAIL""]
++      send_welcome_mail(user)
++    end
+     sign_in(user)
+   end
++
++  def send_welcome_mail(user)
++    if (Time.current - user.created_at) < 2.seconds
++      WelcomeMailer.welcome_notification(user).deliver_later
++    end
++  end
+ end",why do we have an env var for this? not sure why we'd want to suppress welcome emails but not any others,Do we really want to send the email regardless of
+6252,"@@ -917,7 +917,13 @@ func (p *parser) parseStringExpression() *ast.StringExpression {
+ 			}
+ 		default:
+ 			// TODO bad expression
+-			return nil
++			loc := p.loc(pos, pos+token.Pos(len(lit)))
++			p.errs = append(p.errs, ast.Error{
++				Msg: fmt.Sprintf(""got unexpected token in string expression %s@%d:%d-%d:%d: %s"", loc.File, loc.Start.Line, loc.Start.Column, loc.End.Line, loc.End.Column, tok),
++			})
++			return &ast.StringExpression{
++				BaseNode: p.position(beg, pos+token.Pos(len(lit))),
++			}
+ 		}
+ 	}
+ }",drop the todo?,"Suggest removing the ""TODO"" in the error message, now that it's no longer needed."
+6253,"@@ -383,7 +383,9 @@ void Doors::HandleClick(Client* sender, uint8 trigger) {
+ 	if (!IsDoorOpen() || (open_type == 58)) {
+ 		if (!disable_timer)
+ 			close_timer.Start();
+-		SetOpenState(true);
++
++		if(strncmp(destination_zone_name, ""NONE"", strlen(""NONE"")) == 0)
++			SetOpenState(true);
+ 	} else {
+ 		close_timer.Disable();
+ 		if (!disable_timer)",Maybe use { } here like we are most other places now.,"`if (strncmp(destination_zone_name, ""NONE"", strlen(""NONE"")) == 0)`"
+6254,"@@ -96,6 +96,7 @@ class PartitionData
+     return schema;
+   }
+
++  @Override
+   public Type getType(int pos) {
+     return partitionType.fields().get(pos).type();
+   }","I want to get PartitionData field type, I don't know how to get it in other way.",nit: not related to this PR but this should probably be a separate commit (or eve
+6255,"@@ -31,6 +31,9 @@ type Balances interface {
+ 	// A non-nil error means the lookup is impossible (e.g., if the database doesn't have necessary state anymore)
+ 	Get(addr basics.Address, withPendingRewards bool) (basics.AccountData, error)
+
++	// GetEx is like Get(addr, false), but also loads specific creatable
++	GetEx(addr basics.Address, cidx basics.CreatableIndex, ctype basics.CreatableType) (basics.AccountData, error)
++
+ 	Put(basics.Address, basics.AccountData) error
+
+ 	// PutWithCreatable is like Put, but should be used when creating or deleting an asset or application.","I think that a single `Get` method would be preferable, that would have the following parameters: Get(addr basics.Address, withPendingRewards bool, cidx basics.CreatableIndex, ctype basics.CreatableType) where we ignore cidx of -1, and adding support for ctype of ""AssetParams"" or something like that. (i.e. so that this Get call would be good for asset holding/asset params and applications )",There should be a better name for this than `GetEx`.
+6256,"@@ -1653,7 +1653,7 @@ char * ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int &err,
+                   // for non-varchar, length of zero indicates a null value.
+                   // For all datatypes, HIVE_DEFAULT_NULL_STRING('\N') indicates a null value.
+                   if (((len == 0) && (tgtAttr && (NOT DFS2REC::isSQLVarChar(tgtAttr->getDatatype())))) ||
+-                      ((len > 0) && (memcmp(sourceData, HIVE_DEFAULT_NULL_STRING, len) == 0)))
++                      ((len > 1) && (memcmp(sourceData, HIVE_DEFAULT_NULL_STRING, len) == 0)))
+                     {
+                       *(short *)&hdfsAsciiSourceData_[attr->getNullIndOffset()] = -1;
+                     }","This can handle the '\\' problem, but if (not possible) the user define '\\' as null, this logic will break. So here, it should be to compare the whole HIVE_DEFAULT_NULL_STRING, and make sure length is equal, as I understand. \N is NULL, but \NA is not NULL, what will happen if there is \NAA ?",Is this change relevant to this PR? I'm not seeing the change in this PR.
+6257,"@@ -0,0 +1,9 @@
++class ObservationPolicy
++  include ExceptionPolicy
++
++  def can_destroy!
++    role = Role.new(@user, @record.proposal)
++    check(@user.id == @record.user_id || role.client_admin? || @user.admin?,
++          ""Only the observer can delete themself"")
++  end
++end","Hmm, I would think that anyone who can edit the request should be able to delete the observation, in case they accidentally add the wrong person or something.",Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body
+6258,"@@ -4,13 +4,9 @@ class PublicPagesController < ApplicationController
+   # GET template_index
+   # -----------------------------------------------------
+   def template_index
+-    template_ids = Template.where(org_id: Org.funder.pluck(:id), visibility: Template.visibilities[:publicly_visible]).valid.pluck(:dmptemplate_id).uniq << Template.where(is_default: true, published: true).pluck(:dmptemplate_id)
+-    @templates = []
+-    template_ids.flatten.each do |tid|
+-      t = Template.live(tid)
+-      @templates << t unless t.nil?
+-    end
+-    @templates = @templates.sort{|x,y| x.title <=> y.title } if @templates.count > 1
++    template_ids = Template.families(Org.funder.pluck(:id)).publicly_visible.pluck(:dmptemplate_id) <<
++    Template.where(is_default: true).valid.published.pluck(:dmptemplate_id)
++    @templates = Template.includes(:org).where(dmptemplate_id: template_ids.uniq.flatten).valid.published.order(title: :asc).page(1)
+   end
+
+   # GET template_export/:id",I know we are doing this other places already. It would be good to refactor this and the paginable publicly_visible so that we are DRY. Can wait until after MVP though when we do general cleanup,you can use `.distinct.pluck` here
+6259,"@@ -576,7 +576,12 @@ update_lookuptable_tls(dcontext_t *dcontext, ibl_table_t *table)
+      * crashing or worse.
+      */
+     state->table_space.table[table->branch_type].lookuptable = table->table;
+-    state->table_space.table[table->branch_type].hash_mask = table->hash_mask;
++    /* Perform a Store-Release, which when combined with a Load-Acquire of the mask
++     * in the IBL itself, ensures the prior store to lookuptable is never
++     * observed before this store to hash_mask on weakly ordered arches.
++     */
++    ATOMIC_PTRSZ_ALIGNED_WRITE(&state->table_space.table[table->branch_type].hash_mask,
++                               table->hash_mask, false);
+ }
+
+ #ifdef DEBUG","I think this should read ""is always observed before"" or ""is never observed after"".",Is there a specific reason for this change? Is it related to the rest of
+6260,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright 2002-2020 the original author or authors.
++ * Copyright 2002-2021 the original author or authors.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.",You might consider adding yourself as an author of the class.,Revert changes to this file
+6261,"@@ -1065,7 +1065,8 @@ int ACTIVE_TASK::start(bool test) {
+
+         // hook up stderr to a specially-named file
+         //
+-        (void) freopen(STDERR_FILE, ""a"", stderr);
++        if (freopen(STDERR_FILE, ""a"", stderr) == NULL) {
++        }
+
+         // lower our priority if needed
+         //","If this fails, then 'stderr' is not a valid file handler anymore, and then any further 'write' operations will fail. Maybe some handling of such situation should be added here?",Why not just use `freopen_s
+6262,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,Maybe add a constant for th
+6263,"@@ -262,8 +262,8 @@ class DHCPOptionsField(StrField):
+                 s += chr(len(oval))
+                 s += oval
+
+-            elif (type(o) is str and DHCPRevOptions.has_key(o) and
+-                  DHCPRevOptions[o][1] == None):
++            elif (type(o) is str and DHCPRevOptions.has_key(o) and
++                          DHCPRevOptions[o][1] is None):
+                 s += chr(DHCPRevOptions[o][0])
+             elif type(o) is int:
+                 s += chr(o)+""\0""",I think your indentation is wrong here.,I don't agree with this cha
+6264,"@@ -63,7 +63,9 @@ type L3RouteResolver struct {
+ 	blockToRoutes          map[string]set.Set
+ 	allPools               map[string]model.IPPool
+ 	workloadIDToCIDRs      map[model.WorkloadEndpointKey][]cnet.IPNet
++	nodeToCIDRs            map[string]set.Set
+ 	useNodeResourceUpdates bool
++	routeSource            string
+ }
+
+ type l3rrNodeInfo struct {","UT spotted that we weren't marking routes dirty when they targeted at Node and that node's IP changed. e.g., the case where a WEP appears in the syncer before the corresponding node does, so we don't know the node's IP. I added a new map to track the CIDRs for each node so that when the node IP changes we can mark those CIDRs dirty. Right now it's only used for the ""WorkloadIPs"" scenario. Need to decide if the same issue applies in the ""CalicoIPAM' case. I suspect it might. It looks like we have some logic present to detect when our own node IP changes, but we don't seem to handle when a remote node's IP changes.",What is this used for? Does it need to be added to the l3rrNodeInfo?
+6265,"@@ -390,6 +390,14 @@ HELP
+     def execute(options)
+       if options[:mode] == 'plan' || options[:mode] == 'task'
+         begin
++          if Gem.win_platform?
++            # Windows 'fix' for openssl behaving strangely. Prevents very slow operation
++            # of random_bytes later when establishing winrm connections from a Windows host.
++            # See https://github.com/rails/rails/issues/25805 for background.
++            require 'openssl'
++            OpenSSL::Random.random_bytes(1)
++          end
++
+           require_relative '../../vendored/require_vendored'
+         rescue LoadError
+           raise Bolt::CLIError, ""Puppet must be installed to execute tasks""","Given this will 'pause' bolt for a few seconds on older rubies, perhaps emit a debug message saying ""Warming up OpenSSL"" or something to that effect",Is there any way we can prevent this from working on Windows? Is the
+6266,"@@ -85,6 +85,11 @@ class Package(object):
+         self._package = package
+         self._pkg_dir = pkg_dir
+         self._path = path
++        self._format = None
++
++    def set_format(self, pkgformat):
++        """"""Set the format. Only used when building a new package.""""""
++        self._format = pkgformat
+
+     def file(self, hash_list):
+         """"""","Initializing _format to None, but asserting that it's not None later, seems unnecessarily fragile. We shouldn't architect the package class to rely on classes or methods that use it (e.g., build). Let's at least set the format to the default in case we don't create all packages through build.py.","Is this only used when building a new package? If so, why not make i"
+6267,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",This change should also probably go into the corresponding method of the abstract By class?,`T extends WebElement` ?
+6268,"@@ -0,0 +1,8 @@
++<?php
++namespace Psalm\Issue;
++
++class UnresolvableConstant extends CodeIssue
++{
++    public const ERROR_LEVEL = -1;
++    public const SHORTCODE = 303;
++}",Should this be set to something else?,Why `UnresolvableConstant` and not just `Constant`?
+6269,"@@ -0,0 +1 @@
++Hi","Whats up with this? It looks like this is rendered on purchases/new for subscribers, so it would result in a dead end?",Please remove this file.
+6270,"@@ -1326,13 +1326,13 @@ class StoreOptions(object):
+         return specs
+
+     @classmethod
+-    def propagate_ids(cls, obj, match_id, new_id, applied_keys):
++    def propagate_ids(cls, obj, match_id, new_id, applied_keys, backend=None):
+         """"""
+         Recursively propagate an id through an object for components
+         matching the applied_keys. This method can only be called if
+         there is a tree with a matching id in Store.custom_options
+         """"""
+-        if not new_id in Store.custom_options():
++        if not new_id in Store.custom_options(backend=backend):
+             raise AssertionError(""The set_ids method requires ""
+                                  ""Store.custom_options to contain""
+                                  "" a tree with id %d"" % new_id)",Glad to see this generalized to support the backend argument.,"The backend should be an optional argument, not `No"
+6271,"@@ -1781,3 +1781,11 @@ func (a *WebAPI) GetInsightApplicationCount(ctx context.Context, req *webservice
+ 		UpdatedAt: c.UpdatedAt,
+ 	}, nil
+ }
++
++func (a *WebAPI) ListDeploymentChains(ctx context.Context, req *webservice.ListDeploymentChainsRequest) (*webservice.ListDeploymentChainsResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""not yet implemented"")
++}
++
++func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDeploymentChainRequest) (*webservice.GetDeploymentChainResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""not yet implemented"")
++}",`ctx` is unused in ListDeploymentChains,Should we return an error if this is not implemente
+6272,"@@ -154,7 +154,7 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ func (e *Executor) getMentionedAccounts(ctx context.Context, event model.NotificationEventType) ([]string, error) {
+ 	ds, err := e.TargetDSP.GetReadOnly(ctx, e.LogPersister)
+ 	if err != nil {
+-		return nil, fmt.Errorf(""failed to prepare running deploy source data: %w"", err)
++		return nil, fmt.Errorf(""failed to prepare running deploy source data: (%w)"", err)
+ 	}
+
+ 	if ds.GenericDeploymentConfig.DeploymentNotification == nil {","I'd say the format like `""xxx: %w""` is more convention when wrapping an error basically. You refered to anything like this?",would be nice to include the error in the message
+6273,"@@ -65,7 +65,7 @@ const (
+ 	endpoint            = ""https://127.0.0.1:2379""
+ 	testTimeout         = time.Second * 10
+ 	manageTickerTime    = time.Second * 15
+-	learnerMaxStallTime = time.Minute * 1
++	learnerMaxStallTime = time.Minute * 5
+
+ 	// defaultDialTimeout is intentionally short so that connections timeout within the testTimeout defined above
+ 	defaultDialTimeout = 2 * time.Second","This seems relatively high, is it the recommended value from the etcd folks? Or is this debugging cruft?",Why did this need to change?
+6274,"@@ -10,11 +10,11 @@ import (
+ 	""google.golang.org/grpc/status""
+ )
+
+-type peerTrackerAttestor struct {
++type PeerTrackerAttestor struct {
+ 	Attestor attestor.Attestor
+ }
+
+-func (a peerTrackerAttestor) Attest(ctx context.Context) ([]*common.Selector, error) {
++func (a PeerTrackerAttestor) Attest(ctx context.Context) ([]*common.Selector, error) {
+ 	watcher, ok := peertracker.WatcherFromContext(ctx)
+ 	if !ok {
+ 		return nil, status.Error(codes.Internal, ""peer tracker watcher missing from context"")","This requires updating the name in the `endpoints` tests, please run `make test`.",Why was this change necessary?
+6275,"@@ -37,6 +37,10 @@ std::vector<HostAddr> toHosts(const std::string& peersStr) {
+
+ int main(int argc, char *argv[]) {
+     folly::init(&argc, &argv, true);
++    if (FLAGS_data_path.empty()) {
++        LOG(FATAL) << ""Meta Data Path should not empty"";
++        return EXIT_FAILURE;
++    }
+
+     LOG(INFO) << ""Starting Meta HTTP Service"";
+     nebula::WebService::registerHandler(""/meta"", [] {","LOG(FATAL) means coredump, LOG(ERROR) is better here.",I'm not sure how this is supposed to work. Does `
+6276,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change.",Shouldn't this be `var lookFor = parameters.handle.name;`?
+6277,"@@ -375,6 +375,12 @@ func UnmarshalService(in []byte) (interface{}, error) {
+ 			m.BackendServiceConfig.Image.HealthCheck.applyIfNotSet(newDefaultContainerHealthCheck())
+ 		}
+ 		return m, nil
++	case ScheduledJobType:
++		m := newDefaultScheduledJob()
++		if err := yaml.Unmarshal(in, m); err != nil {
++			return nil, fmt.Errorf(""unmarshal to scheduled job: %w"", err)
++		}
++		return m, nil
+ 	default:
+ 		return nil, &ErrInvalidSvcManifestType{Type: typeVal}
+ 	}",It's a bit weird to have `svc.go` to include a `ScheduledJobType`...should we rename this file?,"hmm, do we need the default here?"
+6278,"@@ -55,7 +55,7 @@ const licenseHeaderPrefix = ""// The MIT License (MIT)""
+
+ var (
+ 	// directories to be excluded
+-	dirBlacklist = []string{""vendor/""}
++	dirBlacklist = []string{""tpb/""}
+ 	// default perms for the newly created files
+ 	defaultFilePerms = os.FileMode(0644)
+ )","For some reason `protoc` doesn't copy license header from `proto` files to generated code. But this code will never be checked in, so it is ok.",This is a good example of a way to exclude tpb from the li
+6279,"@@ -898,7 +898,7 @@ public class DatabaseHelper extends OrmLiteSqliteOpenHelper {
+                 PreparedQuery<TemporaryBasal> preparedQuery2 = queryBuilder2.prepare();
+                 List<TemporaryBasal> trList2 = getDaoTemporaryBasal().query(preparedQuery2);
+
+-                if (trList2.size() > 0) {
++                if (trList2.size() > 0 && trList2.get(0).pumpId == 0) { // don't update existing record if it has a pumpId
+                     old = trList2.get(0);
+
+                     old.copyFromPump(tempBasal);","I don't know what the implications of this change are for pumps other than the insight but i would add `|| trList2.get(0).pumpId == temporaryBasal.pumpId` in case we see the same pump event again, in order to not duplicate it in the database.",is there any way to avoid calling `get(0)` multiple times?
+6280,"@@ -29,8 +29,8 @@ type (
+ 	Address crypto.Digest
+ )
+
+-// ChecksumAddress is a representation of the short address with a checksum
+-type ChecksumAddress struct {
++// checksumAddress is a representation of the short address with a checksum
++type checksumAddress struct {
+ 	shortAddress Address
+ 	checksum     []byte
+ }",is there anything still referencing `checksumAddress` or can we just delete it?,Why does this need to be public?
+6281,"@@ -18,6 +18,7 @@ var (
+ 	// ClusterDeployment conditions that could indicate provisioning problems with a cluster
+ 	// First condition appearing True will be used in the metric labels.
+ 	provisioningDelayCondition = [...]hivev1.ClusterDeploymentConditionType{
++		hivev1.RequirementsMetCondition,
+ 		hivev1.DNSNotReadyCondition,
+ 		hivev1.InstallLaunchErrorCondition,
+ 		hivev1.ProvisionFailedCondition,","The reason I didn't suggest it before is because I didn't want alerts for every tried - but not updated provision, but I can see a value in it from OSD perspective",Why is this line moved?
+6282,"@@ -2,8 +2,10 @@ if Rails.env.production? || Rails.env.staging?
+   require 'rack/rewrite'
+
+   Rails.configuration.middleware.insert_before(Rack::Runtime, Rack::Rewrite) do
+-    r301 %r{.*}, ""http://#{HOST}$&"", if: Proc.new { |rack_env|
+-      rack_env['SERVER_NAME'] != ""#{HOST}""
+-    }
++    r301(
++      %r{.*},
++      ""http://#{ENV['APP_DOMAIN']}$&"",
++      if: proc { |rack_env| rack_env['SERVER_NAME'] != ""#{ENV['APP_DOMAIN']}"" }
++    )
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I'm pretty sure this is supposed
+6283,"@@ -61,8 +61,12 @@ func GroupActions(actions []*Action) (beforeGets, getList, writeList, afterGets
+ 	agets := map[interface{}]*Action{}
+ 	cgets := map[interface{}]*Action{}
+ 	writes := map[interface{}]*Action{}
++	var nilkeys []*Action
+ 	for _, a := range actions {
+-		if a.Kind == Get {
++		if a.Key == nil {
++			// Probably a Create.
++			nilkeys = append(nilkeys, a)
++		} else if a.Kind == Get {
+ 			// If there was a prior write with this key, make sure this get
+ 			// happens after the writes.
+ 			if _, ok := writes[a.Key]; ok {","I believe Key is not necessarily nil, it could be empty string. Probably better check a.Kind == Create",Minor nit: `map[interface]*Actio
+6284,"@@ -89,7 +89,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             }
+         }
+
+-        public Task WriteAsync<T>(Func<PipeWriter, T, long> callback, T state)
++        public Task WriteAsync<T>(Func<PipeWriter, T, long> callback, T state, CancellationToken cancellationToken)
+         {
+             lock (_contextLock)
+             {",This is only used for headers and therefore isn't used.,Do we still need the token here? Seems like we could just use `default`?
+6285,"@@ -15,11 +15,13 @@ import (
+
+ // ProviderCommand defines the shell command to be run for one of the commands (db pull, etc.)
+ type ProviderCommand struct {
+-	Command string `yaml:""command""`
+-	Service string `yaml:""service,omitempty""`
++	Command    string `yaml:""command""`
++	Service    string `yaml:""service,omitempty""`
++	SkipImport bool   `yaml:""skip_import""`
+ }
+
+ // ProviderInfo defines the provider
++// @todo: CodePullCommand unused
+ type ProviderInfo struct {
+ 	EnvironmentVariables map[string]string `yaml:""environment_variables""`
+ 	AuthCommand          ProviderCommand   `yaml:""auth_command""`","Wouldn't it make sense to add a files_import_command and a db_import_command, which could be empty? I guess that leads to potential backward-compatibility problems, but it's worth thinking about. Perhaps add an import-api version to solve that? Overall, I think the actual db import logic and files import logic should be moved into the yaml file. What you you think of that?",Can we remove this for now and leave it just in case?
+6286,"@@ -0,0 +1,15 @@
++// DO NOT EDIT: This file is autogenerated via the builtin command.
++
++package csv
++
++import ast ""github.com/influxdata/flux/ast""
++
++var FluxTestPackages = []*ast.Package{&ast.Package{
++	BaseNode: ast.BaseNode{
++		Errors: nil,
++		Loc:    nil,
++	},
++	Files:   []*ast.File{},
++	Package: ""csv_test"",
++	Path:    ""csv"",
++}}","Why do we have this here? I'm not concerned about it really, just curious.",Why is this empty?
+6287,"@@ -28,11 +28,11 @@ import (
+ type DeltaAction uint64
+
+ const (
+-	// SetBytesAction indicates that a TEAL byte slice should be stored at a key
+-	SetBytesAction DeltaAction = 1
+-
+ 	// SetUintAction indicates that a Uint should be stored at a key
+-	SetUintAction DeltaAction = 2
++	SetUintAction DeltaAction = 1
++
++	// SetBytesAction indicates that a TEAL byte slice should be stored at a key
++	SetBytesAction DeltaAction = 2
+
+ 	// DeleteAction indicates that the value for a particular key should be deleted
+ 	DeleteAction DeltaAction = 3",@justicz Why are these switched here?,Is there a reason why this is not in the protobuf file?
+6288,"@@ -0,0 +1,7 @@
++describe 'GET /help' do
++  it ""displays successfully"" do
++    get '/help'
++    expect(response.status).to eq(200)
++    expect(response.body).to include('FAQ')
++  end
++end",Maybe verify that an anchor was created -- that the markdown was processed?,"This should be more descriptive. Something like ""it ""displays a success message"" or something."
+6289,"@@ -64,7 +64,7 @@ public abstract class TwoPhaseIterator {
+
+     TwoPhaseIteratorAsDocIdSetIterator(TwoPhaseIterator twoPhaseIterator) {
+       this.twoPhaseIterator = twoPhaseIterator;
+-      this.approximation = twoPhaseIterator.approximation;
++      this.approximation = twoPhaseIterator.approximation();
+     }
+
+     @Override","Is this just a minor improvement or is it necessary? If just some minor improvement, I recommend you don't touch Lucene in a Solr PR.",Is this change required?
+6290,"@@ -63,7 +63,4 @@ public interface ReadOnlyPDClient {
+
+   /** Close underlining resources */
+   void close() throws InterruptedException;
+-
+-  /** Get associated session * @return the session associated to client */
+-  TiSession getSession();
+ }",why delete this method?,We should keep this method and mark it as deprecated (with a deprecation warning)
+6291,"@@ -15,13 +15,17 @@
+ package com.google.api.codegen.transformer;
+
+ import com.google.api.codegen.config.MethodContext;
++import com.google.api.codegen.config.OutputContext;
+ import com.google.api.codegen.metacode.InitCodeNode;
+ import com.google.api.codegen.viewmodel.CallingForm;
+ import com.google.api.codegen.viewmodel.ImportSectionView;
+-import com.google.api.codegen.viewmodel.OutputView;
+ import java.util.Collections;
+-import java.util.List;
+
++/**
++ * An implementation of SampleImportTransformer. Subclasses of this class can choose to override
++ * `addSampleBodyImports`, `addOutputImports` and `addInitCodeImports` to save language-specific
++ * types to the type table. Currently used by Java.
++ */
+ public class StandardSampleImportTransformer implements SampleImportTransformer {
+
+   private final ImportSectionTransformer importSectionTransformer;","Does this transform only the `MethodContext`, or also the `OutputContext`? (Looking at the other files, I gather it's the latter.) Might be helpful to mention that here.",This class is not used by Java.
+6292,"@@ -1,15 +1,17 @@
+ # A part of NonVisual Desktop Access (NVDA)
+-# Copyright (C) 2009-2018 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala
++# Copyright (C) 2009-2020 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala
+ # This file may be used under the terms of the GNU General Public License, version 2 or later.
+ # For more details see: https://www.gnu.org/licenses/gpl-2.0.htmlimport appModuleHandler
+
+ import calendar
+ import collections
+ import time
+-
+ import api
+ import appModuleHandler
++from NVDAObjects.IAccessible import getNVDAObjectFromEvent
+ import ui
++import windowUtils
++import winUser
+
+ # A named tuple for holding the elapsed and total playing times from Foobar2000's status bar
+ statusBarTimes = collections.namedtuple('StatusBarTimes', ['elapsed', 'total'])",Could you please clean-up this line while at it?,This doesn't seem to be correct. Shouldn't it be `winUser`?
+6293,"@@ -50,6 +50,11 @@ type PubSubSpec struct {
+ 	// This brings in CloudEventOverrides and Sink.
+ 	duckv1.SourceSpec `json:"",inline""`
+
++	// ServiceAccount is the GCP service account which has required permissions to poll from a Cloud Pub/Sub subscription.
++	// If not specified, defaults to use secret.
++	// +optional
++	ServiceAccount *string `json:""serviceAccount,omitempty""`
++
+ 	// Secret is the credential to use to poll from a Cloud Pub/Sub subscription.
+ 	// If not specified, defaults to:
+ 	// Name: google-cloud-key","no need to use a pointer. Just string and check for != """"",Doesn't this need the `// +optional` tag?
+6294,"@@ -133,7 +133,9 @@ public class RestServerVerticle extends AbstractVerticle {
+     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
+     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
+     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+-
++    if (endpointObject.isHttp2Enabled()) {
++      serverOptions.setUseAlpn(true);
++    }
+     if (endpointObject.isSslEnabled()) {
+       SSLOptionFactory factory =
+           SSLOptionFactory.createSSLOptionFactory(SSL_KEY, null);",this means h2 mode? but how h2c can work?,Why is this always `true`? Shouldn't it be the default?
+6295,"@@ -1,9 +1,9 @@
+ # -*- coding: UTF-8 -*-
+-#appModules/explorer.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2019 NV Access Limited, Joseph Lee, Łukasz Golonka
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# appModules/explorer.py
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2006-2019 NV Access Limited, Joseph Lee, Łukasz Golonka, Julien Cochuyt
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+ """"""App module for Windows Explorer (aka Windows shell and renamed to File Explorer in Windows 8).
+ Provides workarounds for controls such as identifying Start button, notification area and others.",This line should not be there,Why was this file changed?
+6296,"@@ -120,7 +120,12 @@ func (t *trie) Start(ctx context.Context) error {
+ 	return t.dao.Commit(t.cb)
+ }
+
+-func (t *trie) Stop(ctx context.Context) error { return t.lifecycle.OnStop(ctx) }
++func (t *trie) Stop(ctx context.Context) error {
++	t.mutex.Lock()
++	defer t.mutex.Unlock()
++
++	return t.lifecycle.OnStop(ctx)
++}
+
+ // TrieDB return the underlying DB instance
+ func (t *trie) TrieDB() db.KVStore {","why do we need lock here? if needed, then we also need to lock in Start()?","If we error out here, do we want to log something? Otherwise, log a debug message?"
+6297,"@@ -415,6 +415,8 @@ void ProtocolGame::parsePacket(NetworkMessage& msg)
+ 		}
+ 	}
+
++	addGameTask(&Game::playerExecuteParsePacketEvent, player->getID(), recvbyte, new NetworkMessage(msg));
++
+ 	switch (recvbyte) {
+ 		case 0x14: g_dispatcher.addTask(createTask(std::bind(&ProtocolGame::logout, getThis(), true, false))); break;
+ 		case 0x1D: addGameTask(&Game::playerReceivePingBack, player->getID()); break;","this should be on default-switch, uhm? else you will handle twice (c++ and lua). I'm just saying...",It would be good to complete this in a separate PR. I'm not sure if this is worth
+6298,"@@ -60,7 +60,7 @@ public class Program
+             // turn off the above default. i.e any
+             // instrument which does not match any views
+             // gets dropped.
+-            // .AddView(instrumentName: ""*"", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })
++            // .AddView(instrumentName: ""*"", MetricStreamConfiguration.Drop)
+             .AddConsoleExporter()
+             .Build();
+ ",unrelated minor fix,`new MetricStreamConfiguration() { Aggregation = Aggregation.Drop }` can be remove
+6299,"@@ -19,6 +19,7 @@ module Travis
+         def setup
+           super
+           cmd ""nvm use #{config[:node_js]}""
++          cmd ""npm config set spin false"", echo: false
+           if npm_should_disable_strict_ssl?
+             cmd 'echo ""### Disabling strict SSL ###""'
+             cmd 'npm conf set strict-ssl false'","can you add `, echo: false` to the end of this as well. I don't think we need to echo this to the log. You might need to update the spec as well.","This command doesn't seem to be launched via `npm install`, is this intentional?"
+6300,"@@ -88,6 +88,12 @@ class TestHeaders:
+         headers = Headers(Host=""foobarfoo.com"", Accept=""foo/bar"")
+         replacements = headers.replace(""foo"", ""bar"", count=1)
+         assert replacements == 1
++        assert headers[""Host""] == ""barbarfoo.com""
++        assert headers[""Accept""] == ""foo/bar""
++        replacements = headers.replace(""foo"", ""bar"", count=2)
++        assert replacements == 2
++        assert headers[""Host""] == ""barbarbar.com""
++        assert headers[""Accept""] == ""bar/bar""
+
+
+ def test_parse_content_type():","This test does not really verify that we're doing the correct thing now, is it? It seems to pass with and without the patch.",Is it possible to also test the case when the content type is `application/octet-stream`?
+6301,"@@ -16,7 +16,13 @@ const BlocksTopic = ""/fil/blocks""
+ const MessageTopic = ""/fil/msgs""
+
+ // AddNewBlock processes a block on the local chain and publishes it to the network.
+-func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) error {
++func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) (err error) {
++	ctx = log.Start(ctx, ""Node.AddNewBlock"")
++	log.SetTag(ctx, ""block"", b)
++	defer func() {
++		log.FinishWithErr(ctx, err)
++	}()
++
+ 	if _, err := node.ChainMgr.ProcessNewBlock(ctx, b); err != nil {
+ 		return err
+ 	}",should just be able to defer the call directly here too,The named return values aren't used in the function. Am I missing something?
+6302,"@@ -916,7 +916,7 @@ class LayoutPlot(GenericLayoutPlot, CompositePlot):
+
+         # Create title handle
+         if self.show_title and len(self.coords) > 1:
+-            title = self.handles['fig'].suptitle('', **self._fontsize('title'))
++            title = self.handles['fig'].suptitle('', y=1.05, **self._fontsize('title'))
+             self.handles['title'] = title
+
+         return layout_subplots, layout_axes, collapsed_layout",Is this a magic number? I assume this makes it look better.,`self._fontsize('title')` is already specified in `suptitle`
+6303,"@@ -88,8 +88,8 @@ func (ob *Outbox) Send(ctx context.Context, from, to address.Address, value type
+ 			msgSendErrCt.Inc(ctx, 1)
+ 		}
+ 		ob.journal.Write(""Send"",
+-			""to"", to.String(), ""from"", from.String(), ""value"", value.AsBigInt().Uint64(), ""method"", method,
+-			""gasPrice"", gasPrice.AsBigInt().Uint64(), ""gasLimit"", uint64(gasLimit), ""bcast"", bcast,
++			""to"", to.String(), ""from"", from.String(), ""value"", value.Int.Uint64(), ""method"", method,
++			""gasPrice"", gasPrice.Int.Uint64(), ""gasLimit"", uint64(gasLimit), ""bcast"", bcast,
+ 			""params"", params, ""error"", err, ""cid"", out.String())
+ 	}()
+ ",Would welcome a stringification method on big.Int in specs-actors,Why remove the `AsBigInt` call here?
+6304,"@@ -49,6 +49,8 @@ type (
+ 	WorkingSet interface {
+ 		// states and actions
+ 		RunActions(context.Context, uint64, []action.SealedEnvelope) (hash.Hash32B, map[hash.Hash32B]*action.Receipt, error)
++		RunAction(context.Context, action.SealedEnvelope) (*action.Receipt, error)
++		PersistBlockLevelInfo(blockHeight uint64) hash.Hash32B
+ 		Snapshot() int
+ 		Revert(int) error
+ 		Commit() error",PersistBlockLevelInfo -> UpdateBlockLevelInfo,why do we need this one?
+6305,"@@ -0,0 +1,10 @@
++_base_ = [
++    'retinanet_pvt_t_fpn_1x_coco.py',
++]
++model = dict(
++    backbone=dict(
++        num_layers=[3, 4, 6, 3],
++        init_cfg=dict(
++            type='Pretrained',
++            checkpoint='https://github.com/whai362/PVT/'
++            'releases/download/v2/pvt_small.pth')))",Type is redundant since it is inherited.,maybe just call this `_b
+6306,"@@ -94,6 +94,10 @@ public class TiTableInfo implements Serializable {
+     primaryKeyColumn = primaryKey;
+   }
+
++  public boolean isNotView() {
++    return this.viewInfo == null;
++  }
++
+   public boolean isView() {
+     return this.viewInfo != null;
+   }",better use `!isView()` so that we don't need to modify multiple lines in future.,How is this different fr
+6307,"@@ -43,6 +43,12 @@ module RSpec
+
+   extend RSpec::Core::Warnings
+
++  class << self
++    # Setters for shared global objects
++    # @api private
++    attr_writer :configuration, :world
++  end
++
+   # Used to ensure examples get reloaded and user configuration gets reset to
+   # defaults between multiple runs in the same process.
+   #","I know you don't usually open up the singleton class, but I was getting a `private method called` error when trying to use `self.attr_writer` - any idea?",Layout/EmptyLinesAroundC
+6308,"@@ -273,8 +273,13 @@ define(['apphost', 'globalize'], function (appHost, globalize) {
+         },
+
+         canRate: function (item) {
++            var itemType = item.Type;
++
++            if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel' || itemType === 'Season' || itemType === 'Studio') {
++                return false;
++            }
+
+-            if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel') {
++            if (!item.UserData) {
+                 return false;
+             }
+ ","There's no need to create a new variable here, the other checks just use the item type directly.","I don't think this is necessary, the `userData` field is only used when the `canRate` function is called"
+6309,"@@ -19,6 +19,14 @@ class Product < ActiveRecord::Base
+     where product_type: 'book'
+   end
+
++  def self.workshops
++    where product_type: 'workshop'
++  end
++
++  def self.videos
++    where product_type: 'video'
++  end
++
+   def self.ordered
+     order(""name asc"")
+   end","Any other possible names? Feels like going with ""workshop"" for this product_type could increase the confusion between course/workshop in the codebase.",This should be `self.workshops` (same for `videos` below).
+6310,"@@ -114,7 +114,10 @@ const baseResolvers = {
+ 			return;
+ 		}
+
+-		yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );
++		const { error } = yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );
++		if ( error ) {
++			yield errorStoreActions.receiveError( error, 'getURLChannels', [ accountID, clientID ] );
++		}
+ 	},
+ };
+ ","@eugene-manuilov Isn't this already taken care of by `fetchGetURLChannels` via `createFetchStore`? Why is the extra `receiveError` call needed here? (This was already in the IB, but just struck me while reviewing here.)","This one is a bit weird, why not just pass the error to the `getURLChannels` action, and let the error h"
+6311,"@@ -22,6 +22,7 @@ import time
+
+ from concurrent import futures
+ import grpc
++import googlecloudprofiler
+
+ from google.cloud.forseti.common.util import logger
+ ",nit: should go before `grpc`?,GoogleCloudprofiler is not used anymore. Please remove it.
+6312,"@@ -71,7 +71,7 @@ func init() {
+ }
+
+ func testWorkflow() *Workflow {
+-	ctx, cancel := context.WithCancel(context.Background())
++	cancel := make(chan struct{})
+ 	return &Workflow{
+ 		Name:          testWf,
+ 		GCSPath:       testGCSPath,","Why not using the Cancel? I thought cancelling a ""parent"" context would cascade to ""children"" contexts, cancelling them as well. In short, how does cancel work?",not needed for this test
+6313,"@@ -28,10 +28,12 @@ func (w *contentTypeOverridingResponseWriter) overrideMimeType(
+ 	// by the frontend WebView.
+ 	ty := strings.ToLower(mimeType)
+ 	switch {
+-	// First reject anything containing javascript/xml/html.
++	// First anything textual as text/plain.
++	// Includes javascript, html, xml. (note that the type may be e.g. application/xhtml+xml)
+ 	case strings.Contains(ty, ""javascript"") ||
+ 		strings.Contains(ty, ""xml"") ||
+-		strings.Contains(ty, ""html""):
++		strings.Contains(ty, ""html"") ||
++		strings.HasPrefix(ty, ""text/""):
+ 		return ""text/plain""
+ 	// Pass multimedia types through, and pdf too.
+ 	case strings.HasPrefix(ty, ""audio/"") ||","Could you explain why we default to binary now? It seems it's safer to default to text to avoid stuff getting executed or parsed by browsers accidentally. If we need to add support for particular types, we can add them explicitly right?",Why is this change neces
+6314,"@@ -139,6 +139,8 @@ type Config struct {
+ 	MetadataAddr string `config:""hostname;127.0.0.1;die-on-fail""`
+ 	MetadataPort int    `config:""int(0,65535);8775;die-on-fail""`
+
++	OpenstackRegion string `config:""string;;local""`
++
+ 	InterfacePrefix  string `config:""iface-list;cali;non-zero,die-on-fail""`
+ 	InterfaceExclude string `config:""iface-list;kube-ipvs0""`
+ ","Bit worried about the prefix since this seem to be being used for non-Openstack data too (host endpoints). Should we just leave host endpoint status at the old path (or remove it since AIFAIK, it's not used anywhere)?",Is this a typo? Should i
+6315,"@@ -68,7 +68,7 @@ public class Timeline {
+
+     private static final Pattern TIMECODE_LINK_REGEX = Pattern.compile(""antennapod://timecode/((\\d+))"");
+     private static final String TIMECODE_LINK = ""<a class=\""timecode\"" href=\""antennapod://timecode/%d\"">%s</a>"";
+-    private static final Pattern TIMECODE_REGEX = Pattern.compile(""\\b(?:(?:(([0-9][0-9])):))?(([0-9][0-9])):(([0-9][0-9]))\\b"");
++    private static final Pattern TIMECODE_REGEX = Pattern.compile(""\\b(?:(?:([01]?\\d|2[0-3]):)?([0-5]?\\d):)?([0-5]?\\d)\\b"");
+     private static final Pattern LINE_BREAK_REGEX = Pattern.compile(""<br */?>"");
+
+ ","This might be a silly question, but what happens to files with durations > 24 hours?",What's the purpose of th
+6316,"@@ -92,7 +92,7 @@ namespace OpenTelemetry.Trace
+         /// <returns>Returns <see cref=""TracerProviderBuilder""/> for chaining.</returns>
+         internal static TracerProviderBuilder AddDiagnosticSourceInstrumentation<TInstrumentation>(
+             this TracerProviderBuilder tracerProviderBuilder,
+-            Func<ActivitySourceAdapter, TInstrumentation> instrumentationFactory)
++            Func<TInstrumentation> instrumentationFactory)
+             where TInstrumentation : class
+         {
+             if (instrumentationFactory == null)",`AddDiagnosticSourceInstrumentation` method can now be eliminated and simply use `AddInstrumentation`,"I'm not sure how I feel about this change... I'm a little worried about it... this is a breaking change -- we're still passing in the `InstrumentationFactory` to the constructor for `InstrumentationFactory`, but we're still passing in the `InstrumentationFactory` to the constructor for `SourceBasedSourceManager`."
+6317,"@@ -78,9 +78,9 @@ describe Bolt::Project do
+     describe ""with namespaced project names"" do
+       let(:config) { { 'name' => 'puppetlabs-foo' } }
+
+-      it ""strips namespace and hyphen"" do
+-        project = Bolt::Project.new(config, pwd)
+-        expect(project.name).to eq('foo')
++      it ""raises an error"" do
++        expect { Bolt::Project.new(config, pwd).validate }
++          .to raise_error(/Invalid project name 'puppetlabs-foo' in bolt-project.yaml/)
+       end
+     end
+   end",I think we also need to add `name:` to the bolt-project.yaml files in `spec/fixtures/projects`.,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+6318,"@@ -3225,6 +3225,11 @@ func (fbo *folderBranchOps) getAndApplyMDUpdates(ctx context.Context,
+ 	return nil
+ }
+
++// getUnmergedMDUpdates returns a slice of the unmerged MDs for this
++// TLF's current unmerged branch and unmerged branch, between the
++// merge point for the branch and the current head.  The returned MDs
++// are the same instances that are stored in the MD cache, so they
++// should be modified with care.
+ func (fbo *folderBranchOps) getUnmergedMDUpdates(
+ 	ctx context.Context, lState *lockState) (
+ 	MetadataRevision, []*RootMetadata, error) {","worth mentioning the same warning here as in `md_util.go`, I think.",What is the intent of this function? Why isn't it just returning a `[]*RootMetadata`?
+6319,"@@ -134,8 +134,12 @@ func (p *Provisioner) GetNodeObjectFromHostName(hostName string) (*v1.Node, erro
+ 		Limit:         1,
+ 	}
+ 	nodeList, err := p.kubeClient.CoreV1().Nodes().List(listOptions)
+-	if err != nil {
+-		return nil, errors.Errorf(""Unable to get the Node with the NodeHostName"")
++	if err != nil || nodeList.Items == nil || len(nodeList.Items) == 0 {
++		// After the PV is created and node affinity is set
++		// based on kubernetes.io/hostname label, either:
++		// - hostname label changed on the node or
++		// - the node is deleted from the cluster.
++		return nil, errors.Errorf(""Unable to get the Node with the NodeHostName [%s]"", hostName)
+ 	}
+ 	return &nodeList.Items[0], nil
+ ","Do we need both the checks, for `Items` not nil and `len(Items)`","Do we need a test case for this? If not, I think we should."
+6320,"@@ -349,6 +349,14 @@ ActiveRecord::Schema.define(version: 20160927192531) do
+
+   add_index ""tags"", [""name""], name: ""index_tags_on_name"", unique: true, using: :btree
+
++  create_table ""test_client_requests"", force: :cascade do |t|
++    t.decimal  ""amount""
++    t.string   ""project_title""
++    t.integer  ""approving_official_id""
++    t.datetime ""created_at""
++    t.datetime ""updated_at""
++  end
++
+   create_table ""user_delegates"", force: :cascade do |t|
+     t.integer  ""assigner_id""
+     t.integer  ""assignee_id""",Do you know what this is coming from? It keeps getting deleted/created @nickbristow,Put one space between the method name and the first argument.
+6321,"@@ -63,11 +63,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
+   public static final String ICEBERG_CATALOG_TYPE_HADOOP = ""hadoop"";
+   public static final String ICEBERG_CATALOG_TYPE_HIVE = ""hive"";
+
+-  public static final String HIVE_URI = ""uri"";
+-  public static final String HIVE_CLIENT_POOL_SIZE = ""clients"";
+   public static final String HIVE_CONF_DIR = ""hive-conf-dir"";
+-  public static final String WAREHOUSE_LOCATION = ""warehouse"";
+-
+   public static final String DEFAULT_DATABASE = ""default-database"";
+   public static final String BASE_NAMESPACE = ""base-namespace"";
+ ","Nit: leaving these in place would have reduce the number of files that this needed to touch, and avoided a possible problem removing public fields. I don't think it's worth blocking for this change, but we like to keep patches as small as possible by not breaking references like these.",These constants were moved to the HiveDatasetDescriptor class
+6322,"@@ -444,6 +444,7 @@ class AdminController extends Controller
+      */
+     protected function prePersistEntity($entity)
+     {
++        @trigger_error(sprintf('The %s is deprecated since EasyAdmin 1.x and will be removed in 2.0 veresion. Use persistEntity instead', __METHOD__), E_USER_DEPRECATED);
+     }
+
+     /**",`The %s is deprecated...` -> `The %s method is deprecated...`,`@trigger_error(sprintf('The %s is deprecated since EasyAdmin
+6323,"@@ -19,6 +19,9 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/encoding""
+ )
+
++// TODO: If this is gonna stay, it should move to specs-actors
++const BlockMessageLimit = 512
++
+ // Block is a block in the blockchain.
+ type Block struct {
+ 	// control field for encoding struct as an array","No, it wouldn't go there because that code won't reference or enforce it. Here is ok for now.",Why is this here?
+6324,"@@ -127,7 +127,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client
+             }
+             catch (Exception exception)
+             {
+-                var completeArgs = new TestRunCompleteEventArgs(null, false, true, exception, new Collection<AttachmentSet>(), TimeSpan.Zero);
++                var completeArgs = new TestRunCompleteEventArgs(null, false, false, exception, new Collection<AttachmentSet>(), TimeSpan.Zero);
+                 eventHandler.HandleLogMessage(TestMessageLevel.Error, exception.Message);
+                 eventHandler.HandleTestRunComplete(completeArgs, null, null, null);
+             }",How will we show that test run aborted (because of a crash) if we don't set aborted to true?,Is this a breaking change?
+6325,"@@ -18,8 +18,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal
+ {
+     internal sealed class SocketConnection : TransportConnection
+     {
+-        private const int MinAllocBufferSize = 2048;
+-        public readonly static bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
++        private static readonly int MinAllocBufferSize = KestrelMemoryPool.MinimumSegmentSize / 2;
++        private static readonly bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
+
+         private readonly Socket _socket;
+         private readonly PipeScheduler _scheduler;",Nit: Might as well make this same change to AdaptedPipeline.,You can make this `const i
+6326,"@@ -42,12 +42,13 @@ public class IcebergTimestampWithZoneObjectInspector extends AbstractPrimitiveJa
+
+   @Override
+   public OffsetDateTime convert(Object o) {
+-    return o == null ? null : OffsetDateTime.ofInstant(((Timestamp) o).toInstant(), ZoneOffset.UTC);
++    return o == null ? null : OffsetDateTime.of(((Timestamp) o).toLocalDateTime(), ZoneOffset.UTC);
+   }
+
+   @Override
+   public Timestamp getPrimitiveJavaObject(Object o) {
+-    return o == null ? null : Timestamp.from(((OffsetDateTime) o).toInstant());
++    return o == null ? null :
++        Timestamp.valueOf(((OffsetDateTime) o).withOffsetSameInstant(ZoneOffset.UTC).toLocalDateTime());
+   }
+
+   @Override",Just to clarify: I see that only the hive2 withZone object inspector is changed. Does that mean that the predicate pushdown problem only occurred on hive2?,`public static OffsetDateT
+6327,"@@ -11,7 +11,7 @@ module Bolt
+   class ModuleInstaller
+     class Specs
+       class ForgeSpec
+-        NAME_REGEX    = %r{\A[a-z][a-z0-9_]*[-/](?<name>[a-z][a-z0-9_]*)\z}.freeze
++        NAME_REGEX    = %r{\A[a-zA-Z0-9]+[-/](?<name>[a-z][a-z0-9_]*)\z}.freeze
+         REQUIRED_KEYS = Set.new(%w[name]).freeze
+         KNOWN_KEYS    = Set.new(%w[name version_requirement]).freeze
+ ",Based on username requirements for forge.puppet.com - only letters and digits permitted.,This is only used in tests
+6328,"@@ -73,11 +73,6 @@ public class StructLikeWrapper {
+       return false;
+     }
+
+-    int len = struct.size();
+-    if (len != that.struct.size()) {
+-      return false;
+-    }
+-
+     return comparator.compare(this.struct, that.struct) == 0;
+   }
+ ",Was this removed to ignore the extra columns coming from the file projection?,This check can be removed as well.
+6329,"@@ -1,3 +1,5 @@
++// +build !windows
++
+ // Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");","Please can you pull out the shared function into a shared file? I think that'd be pretty easy to do for this module. I think you could: - pull out a function `configureSyslog` that is implemented on Linux, but stubbed on Windows - pull out a function `openLogFile` that is implemented differently on each - share everything else",Does this file belong in this PR?
+6330,"@@ -26,6 +26,6 @@ public class NotificationServiceFactoryImpl implements NotificationServiceFactor
+
+     @Override
+     public NotificationService create() {
+-        return new EmailNotificationService();
++        return new EmailNotificationService(new AWSEmailProvider());
+     }
+ }","Instead of hardcoding the AWSEmailProvider here, it should come from properties, so that it can be replaced with another EmailProvider for ZMS vs ZTS",`new EmailNotificationService(new
+6331,"@@ -0,0 +1,10 @@
++require_relative '../config/environment'
++
++login = ARGV[0] || :admin_user
++password = ARGV[1] || :admin_password
++email = ARGV[2] || 'admin@example.com'
++
++account = Account.create!(login: login, level: 10, activated_at: Time.current,
++                          email: email, email_confirmation: email,
++                          password: password, password_confirmation: password)
++ManualVerification.create!(account: account, auth_id: account.login)",+1 for creating this script to help people get boot strapped,is there a reason we're not using
+6332,"@@ -7,6 +7,7 @@ export const ASYNC_RENDER = 3;
+
+
+ export const ATTR_KEY = '__preactattr_';
++export const ELT_KEY_PREFIX = 'preact-';
+
+ // DOM properties that should NOT have ""px"" added when numeric
+ export const IS_NON_DIMENSIONAL = /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i;",Do you need the prefix?,"For my own knowledge, what is this constant used for? I don't see it used anywhere?"
+6333,"@@ -10558,7 +10558,12 @@ short CmpSeabaseDDL::unregisterNativeTable
+      objectNamePart.data(),
+      objType
+      );
+-
++
++  // drop comment text
++  retcode = deleteFromTextTable(&cliInterface,
++                                objUID,
++                                ComTextType::COM_OBJECT_COMMENT_TEXT,
++                                0);
+   return 0;
+ }
+ ","if retcode is < 0, it should return -1 indicating an error.",retcode = deleteFromTable....
+6334,"@@ -1,5 +1,5 @@
+ """"""Emit a message for iteration through dict keys and subscripting dict with key.""""""
+-# pylint: disable=line-too-long,missing-docstring,unsubscriptable-object,too-few-public-methods,redefined-outer-name,use-dict-literal
++# pylint: disable=locally-disabled,useless-suppression,suppressed-message,line-too-long,missing-docstring,unsubscriptable-object,too-few-public-methods,redefined-outer-name,use-dict-literal,iterating-modified-dict
+
+ def bad():
+     a_dict = {1: 1, 2: 2, 3: 3}",Are those necessary? I feel like `useless-suppression` could be avoided here?,What's the reasoning for this change?
+6335,"@@ -309,13 +309,11 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
+             if (codecProfile.Type === 'Audio') {
+                 (codecProfile.Conditions || []).map(function (condition) {
+                     if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitDepth') {
+-                        maxAudioBitDepth = condition.Value;
+-                    }
+-                    if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
+-                        maxAudioSampleRate = condition.Value;
+-                    }
+-                    if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
+-                        maxAudioBitrate = condition.Value;
++                        return maxAudioBitDepth = condition.Value;
++                    } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
++                        return maxAudioSampleRate = condition.Value;
++                    } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
++                        return maxAudioBitrate = condition.Value;
+                     }
+                 });
+             }",Is this equivalent in JavaScript?,Shouldn't this be `return maxAudioSampleRate = condition.Value`?
+6336,"@@ -16,8 +16,8 @@ void GetEdgeIndexProcessor::process(const cpp2::GetEdgeIndexReq& req) {
+   auto edgeIndexIDRet = getIndexID(spaceID, indexName);
+   if (!nebula::ok(edgeIndexIDRet)) {
+     auto retCode = nebula::error(edgeIndexIDRet);
+-    LOG(ERROR) << ""Get Edge Index SpaceID: "" << spaceID << "" Index Name: "" << indexName
+-               << "" failed, error: "" << apache::thrift::util::enumNameSafe(retCode);
++    LOG(INFO) << ""Get Edge Index SpaceID: "" << spaceID << "" Index Name: "" << indexName
++              << "" failed, error: "" << apache::thrift::util::enumNameSafe(retCode);
+     handleErrorCode(retCode);
+     onFinished();
+     return;","get/list operation is not schema change, it is supposed to use VLOG",why not `LOG(WARNING)` here?
+6337,"@@ -92,7 +92,7 @@ namespace System.Diagnostics.Metrics
+             T delta,
+             params KeyValuePair<string, object?>[] tags)
+         {
+-            this.RecordMeasurement(delta, tags);
++            this.RecordMeasurement(delta, new ReadOnlySpan<KeyValuePair<string, object?>>(tags));
+         }
+     }
+ }","we'll need to delete this whole file, right?",Is there a reason to create
+6338,"@@ -41,6 +41,13 @@ public interface Table {
+
+   /**
+    * Refresh the current table metadata.
++   *
++   * <p>If this table is associated with a TransactionalCatalog, this refresh will be bounded by
++   * the visibility that the {@code IsolationLevel} of that transaction exposes. For example, if
++   * we are in a context of {@code READ_COMMITTED}, this refresh will update to the latest state
++   * of the table. However, in the case of {@code SERIALIZABLE} where this table hasn't mutated
++   * within this transaction, calling refresh will have no impact as the isolation level
++   * constrains all observations to within the transactional snapshot.
+    */
+   void refresh();
+ ","""this table hasn't mutated within this transaction"" may sound like implying that if this transaction contains table mutation changes, `refresh` may have impact, which I think is not true? I guess what you were saying was if other transactions committed to this table successfully when this transaction is half way through, refresh in this transaction will still return the same state as when this transaction begins.",Consider adding a note that
+6339,"@@ -143,6 +143,18 @@ const (
+ 	VenafiPickupIDAnnotationKey = ""venafi.cert-manager.io/pickup-id""
+ )
+
++// TODO
++const (
++	// TODO
++	CertificateSigningRequestDurationAnnotationKey = ""cert-manager.io/request-duration""
++
++	// TODO
++	CertificateSigningRequestIsCAAnnotationKey = ""cert-manager.io/request-is-ca""
++
++	// TODO
++	CertificateSigningRequestCAAnnotationKey = ""cert-manager.io/ca""
++)
++
+ // KeyUsage specifies valid usage contexts for keys.
+ // See: https://tools.ietf.org/html/rfc5280#section-4.2.1.3
+ //      https://tools.ietf.org/html/rfc5280#section-4.2.1.12",Can we move these into some kind of experimental API group? I don't think we want to call them `v1` just yet :),What annotation do we need h
+6340,"@@ -31,6 +31,8 @@ class Section < ActiveRecord::Base
+   include ActsAsSortable
+   include VersionableModel
+
++  # Sort order: Number ASC
++  default_scope { order(number: :asc) }
+
+   # ================
+   # = Associations =",  I think this makes a lot of sense but we may want to highlight the change for people doing UAT in case the ordering of sections is off anywhere when customizing or using the drag-drop feature,Do not use semicolons to terminate expressions.
+6341,"@@ -0,0 +1,4 @@
++var script = document.createElement('script')
++script.type = 'text/javascript'
++script.src = '{}'
++document.head.appendChild(script)",These files should in `/javascript/brython`,This is going to generate a lot of warnings. Ju
+6342,"@@ -265,7 +265,7 @@ runLoop:
+ 					continue
+ 				}
+ 				s.close(err)
+-				break runLoop
++				continue
+ 			}
+ 			// This is a bit unclean, but works properly, since the packet always
+ 			// begins with the public header and we never copy it.","I'm not sure this is the right fix - I'd be more happy with a `continue`. That way, we don't enter the code at the bottom of the run loop (e.g. sending packets). Keep in mind that this error here may be triggered by a peer doing something security-relevant, so I don't think we should do much more work other than sending the close frame.",why was this removed?
+6343,"@@ -107,7 +107,11 @@ bool load_model::load_model_weights(const std::string& ckpt_dir,
+   closedir(weight_dir);
+
+   // load weights that appear in weight list.
+-  m->reload_weights(active_ckpt_dir, weight_list);
++  // load weights that appear in weight list.
++  // for(auto&& w : m_weights) {
++  //   w->load_from_save(latest,weight_list);
++  // }
++  //  m->reload_weights(active_ckpt_dir, weight_list);
+   return true;
+ }
+ ","Can we fix this, or is it going to stay broken.",Can you explain why you need to keep this code
+6344,"@@ -57,7 +57,6 @@ except Exception:
+
+ # to avoid copying:
+
+-@attr('postgres')
+ class CopyToTestDB(postgres.CopyToTable):
+     host = host
+     database = database",Is there a reason to remove this attr?,hmm why was this removed?
+6345,"@@ -0,0 +1,19 @@
++package config
++
++import (
++	""github.com/kubeedge/beehive/pkg/common/config""
++	""github.com/kubeedge/beehive/pkg/common/log""
++	""github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants""
++)
++
++// MessageLayer used, context or ssmq, default is context
++var MessageLayer string
++
++func init() {
++	if ml, err := config.CONFIG.GetValue(""devicecontroller.message-layer"").ToString(); err != nil {
++		MessageLayer = constants.DefaultMessageLayer
++	} else {
++		MessageLayer = ml
++	}
++	log.LOGGER.Infof(""message layer: %s"", MessageLayer)
++}",log message should be started with upper-case word.,do we need to log this?
+6346,"@@ -17,6 +17,9 @@ const (
+ 	// aim to create chunks of 20 bits or about 1MiB on average.
+ 	averageBits = 20
+
++	// default buffer size
++	bufSize = 512 * KiB
++
+ 	// MinSize is the minimal size of a chunk.
+ 	MinSize = 512 * KiB
+ 	// MaxSize is the maximal size of a chunk.",I guess this is not needed anymore now?,Can you make this `int` f
+6347,"@@ -24,7 +24,7 @@
+ #include ""h2o.h""
+
+ static ssize_t add_header(h2o_mem_pool_t *pool, h2o_headers_t *headers, h2o_iovec_t *name, const char *orig_name, const char *value,
+-                          size_t value_len, h2o_header_flags_t flags)
++                          size_t value_len)
+ {
+     h2o_header_t *slot;
+ ","I think I would prefer retaining the argument. It's true that we are not using it now, but it's harmless, it's good to have a constructor function that accepts all the field values as arguments. Performance-wise, it does not matter.",remove flag from header.c
+6348,"@@ -836,8 +836,11 @@ Blockly.Gesture.prototype.duplicateOnDrag_ = function() {
+   try {
+     // Note: targetBlock_ should have no children.  If it has children we would
+     // need to update shadow block IDs to avoid problems in the VM.
++    // Resizes will be reenabled at the end of the drag.
++    this.startWorkspace_.setResizesEnabled(false);
+     var xmlBlock = Blockly.Xml.blockToDom(this.targetBlock_);
+     newBlock = Blockly.Xml.domToBlock(xmlBlock, this.startWorkspace_);
++
+     // Move the duplicate to original position.
+     var xy = this.targetBlock_.getRelativeToSurfaceXY();
+     newBlock.moveBy(xy.x, xy.y);",Is this a different fix?,Why is this required?
+6349,"@@ -45,10 +45,12 @@ func (s *DaemonServer) SetDNSServer(ctx context.Context,
+ 		}
+
+ 		// backup the /etc/resolv.conf
+-		cmd := bpm.DefaultProcessBuilder(""sh"", ""-c"", fmt.Sprintf(""ls %s.chaos.bak || cp %s %s.chaos.bak"", DNSServerConfFile, DNSServerConfFile, DNSServerConfFile)).
+-			SetNS(pid, bpm.MountNS).
+-			SetContext(ctx).
+-			Build()
++		processBuilder := bpm.DefaultProcessBuilder(""sh"", ""-c"", fmt.Sprintf(""ls %s.chaos.bak || cp %s %s.chaos.bak"", DNSServerConfFile, DNSServerConfFile, DNSServerConfFile)).SetContext(ctx)
++		if !req.WithoutNS {
++			processBuilder = processBuilder.SetNS(pid, bpm.MountNS)
++		}
++
++		cmd := processBuilder.Build()
+ 		output, err := cmd.CombinedOutput()
+ 		if err != nil {
+ 			log.Error(err, ""execute command error"", ""command"", cmd.String(), ""output"", output)",Why not add a `EnterNS` filed instead of `WithoutNS`?,Should we also do thi
+6350,"@@ -27,6 +27,13 @@ import (
+ )
+
+ var _ = Describe(""Endpoints"", func() {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	for _, trueOrFalse := range []bool{true, false} {
+ 		kubeIPVSEnabled := trueOrFalse
+ 		var rrConfigNormalMangleReturn = Config{",Same points as in other test file.,Is there a reason we
+6351,"@@ -158,6 +158,16 @@ void SettingsStruct_tmpl<N_TASKS>::ApDontForceSetup(bool value) {
+   bitWrite(VariousBits1, 14, value);
+ }
+
++template<unsigned int N_TASKS>
++bool SettingsStruct_tmpl<N_TASKS>::JSONBoolWithQuotes() const {
++  return bitRead(VariousBits1, 15);
++}
++
++template<unsigned int N_TASKS>
++void SettingsStruct_tmpl<N_TASKS>::JSONBoolWithQuotes(bool value) {
++  bitWrite(VariousBits1, 15, value);
++}
++
+ template<unsigned int N_TASKS>
+ bool SettingsStruct_tmpl<N_TASKS>::CombineTaskValues_SingleEvent(taskIndex_t taskIndex) const {
+   if (validTaskIndex(taskIndex))","I have a PR pending, can you change this bit index to `16`?",Can you make this a c
+6352,"@@ -310,11 +310,12 @@ public class JavaParserInterfaceDeclaration extends AbstractTypeDeclaration impl
+
+     private ResolvedReferenceType toReferenceType(ClassOrInterfaceType classOrInterfaceType) {
+         SymbolReference<? extends ResolvedTypeDeclaration> ref = null;
+-        if (classOrInterfaceType.toString().indexOf('.') > -1) {
+-            ref = typeSolver.tryToSolveType(classOrInterfaceType.toString());
++        String typeName = classOrInterfaceType.getNameAsString();
++        if (typeName.indexOf('.') > -1) {
++            ref = typeSolver.tryToSolveType(typeName);
+         }
+         if (ref == null || !ref.isSolved()) {
+-            ref = solveType(classOrInterfaceType.toString(), typeSolver);
++            ref = solveType(typeName, typeSolver);
+         }
+         if (!ref.isSolved()) {
+             ref = solveType(classOrInterfaceType.getName().getId(), typeSolver);",we should probably have some utility class for this sort of things,I am not sure that this change is correct. It looks like the bug is due to the fact that `classOrInterfaceType.toString()` returns the full qualified name of the class or interface type. The old code looked at the class or interface type and it seems to work only for fully qualified class names (but not for interfaces). @mkouba any thoughts?
+6353,"@@ -1,4 +1,4 @@
+-#pylint: disable=missing-docstring, no-else-return, invalid-name, unused-variable, superfluous-parens
++#pylint: disable=missing-docstring, no-else-return, invalid-name, unused-variable, superfluous-parens, try-except-raise
+ """"""Testing inconsistent returns""""""
+ import math
+ import sys",Curious that I'm not seeing any occurrence of the new error check in this file. Why was it disabled?,try-except-raise here is not needed.
+6354,"@@ -341,6 +341,13 @@ class Realm {
+      */
+     static deleteFile(config) { }
+
++    /**
++     * Checks if the Realm already exists on disk.
++     * @param {Realm~Configuration} config The configuration for the Realm.
++     * @throws {Error} if anything in the provided `config` is invalid.
++     */
++    static exists(config) { }
++
+     /**
+      * Copy all bundled Realm files to app's default file folder.
+      * This is only implemented for React Native.",does it return something?,Why do we need a separate method for this? `fs.existsSync()` should suffice.
+6355,"@@ -265,7 +265,7 @@ const withData = (
+
+ 			// If we have an error, display the DataErrorComponent.
+ 			if ( error ) {
+-				return ( 'string' !== typeof error ) ? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid );
++				return ( 'string' !== typeof error ) ? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid, data );
+ 			}
+
+ 			// If we have zeroData, display the NoDataComponent.","This function is also called in various Site Kit module components, where the error object (here `data`) also needs to be passed, otherwise the link to fix the issue won't appear.",I'm wondering if passing `data` instead of `layoutOptions` makes sense. Should we pass `layoutOptions.options` too? The same options could be used for `getDataErrorComponent`.
+6356,"@@ -14,6 +14,8 @@ var log = logging.MustGetLogger(""scm"")
+
+ // An SCM represents an SCM implementation that we can ask for various things.
+ type SCM interface {
++	// DescribeIdentifier returns the string that is a ""human-readable"" identifier of the given revision.
++	DescribeIdentifier(sha string) string
+ 	// CurrentRevIdentifier returns the string that specifies what the current revision is.
+ 	CurrentRevIdentifier() string
+ 	// ChangesIn returns a list of modified files in the given diffSpec.",super nit: `revision string` (the passed value might not be a SHA hash).,Nit: should be `human-readable`
+6357,"@@ -54,7 +54,7 @@ namespace NLog.Layouts
+         /// Is this layout initialized? See <see cref=""Initialize(NLog.Config.LoggingConfiguration)""/>
+         /// </summary>
+         internal bool IsInitialized;
+-        private bool _scannedForObjects;
++        internal bool _scannedForObjects;
+
+         /// <summary>
+         /// Gets a value indicating whether this layout is thread-agnostic (can be rendered on any thread).",@snakefoot why is internal needed?,Why did you change the visibili
+6358,"@@ -190,11 +190,14 @@ func (s *server) startService() common.Daemon {
+ 		}
+
+ 		params.PublicClient, err = sdkclient.NewClient(sdkclient.Options{
+-			HostPort:          s.cfg.PublicClient.HostPort,
+-			Namespace:         common.SystemLocalNamespace,
+-			MetricsScope:      params.MetricScope,
+-			Logger:            l.NewZapAdapter(zapLogger),
+-			ConnectionOptions: sdkclient.ConnectionOptions{TLS: options},
++			HostPort:     s.cfg.PublicClient.HostPort,
++			Namespace:    common.SystemLocalNamespace,
++			MetricsScope: params.MetricScope,
++			Logger:       l.NewZapAdapter(zapLogger),
++			ConnectionOptions: sdkclient.ConnectionOptions{
++				TLS:                options,
++				DisableHealthCheck: true,
++			},
+ 		})
+ 		if err != nil {
+ 			log.Fatalf(""failed to create public client: %v"", err)",Why were we disabling health checks before?,Is there any way to make this c
+6359,"@@ -22,7 +22,7 @@ def check_src_files_have_test():
+ def check_test_files_have_src():
+     unknown_test_files = []
+
+-    excluded = ['test/mitmproxy/data/', 'test/mitmproxy/net/data/', '/tservers.py']
++    excluded = ['test/mitmproxy/data/', 'test/mitmproxy/net/data/', '/tservers.py', '/conftest.py']
+     test_files = glob.glob('test/mitmproxy/**/*.py', recursive=True) + glob.glob('test/pathod/**/*.py', recursive=True)
+     test_files = [f for f in test_files if os.path.basename(f) != '__init__.py']
+     test_files = [f for f in test_files if not any(os.path.normpath(p) in f for p in excluded)]",did `conftest.py` actually show up for you? `test_files` should never contain it...,"I don't think this is right, I "
+6360,"@@ -561,7 +561,8 @@ StmtDDLDropSchema::StmtDDLDropSchema(//const SchemaName & schemaName,
+   // If the schema name specified is reserved name, users cannot drop them.
+   // They can only be dropped internally.
+   if ((! Get_SqlParser_Flags(INTERNAL_QUERY_FROM_EXEUTIL)) &&
+-      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())))
++      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())) &&
++      (!ComIsTrafodionExternalSchemaName(schemaQualName_.getSchemaName())))
+     {
+       // error.
+       *SqlParser_Diags << DgSqlCode(-1430)",Should this be a ! on line 565? I would have expected the condition to be similar to line 564. If I am wrong please excuse my mistake.,I don't think this is the right way to check whether a schema name is reserved or not. Is there a better way to do this? (I don't feel strongly either way)
+6361,"@@ -288,6 +288,10 @@ class DBUpgrader {
+
+             db.execSQL(""DROP TABLE "" + PodDBAdapter.TABLE_NAME_FEED_IMAGES);
+         }
++        if (oldVersion < 1070296) {
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_VOLUME_REDUCTION + "" INTEGER DEFAULT 0"");
++        }
+     }
+
+ }",Please change to `1070400`. I promise to look into this PR in more detail before the 1.7.4 release ;),"Just curious, are we dropping the old `PodDBAdapter.KEY_FEED_VOLUME_REDUCTION`?"
+6362,"@@ -68,15 +68,15 @@ public class FlinkParquetWriters {
+     }
+
+     @Override
+-    public ParquetValueWriter<?> message(RowType sStruct, MessageType message, List<ParquetValueWriter<?>> fields) {
++    public ParquetValueWriter<?> message(LogicalType sStruct, MessageType message, List<ParquetValueWriter<?>> fields) {
+       return struct(sStruct, message.asGroupType(), fields);
+     }
+
+     @Override
+-    public ParquetValueWriter<?> struct(RowType sStruct, GroupType struct,
++    public ParquetValueWriter<?> struct(LogicalType fStruct, GroupType struct,
+                                         List<ParquetValueWriter<?>> fieldWriters) {
+       List<Type> fields = struct.getFields();
+-      List<RowField> flinkFields = sStruct.getFields();
++      List<RowField> flinkFields = ((RowType) fStruct).getFields();
+       List<ParquetValueWriter<?>> writers = Lists.newArrayListWithExpectedSize(fieldWriters.size());
+       List<LogicalType> flinkTypes = Lists.newArrayList();
+       for (int i = 0; i < fields.size(); i += 1) {",Can we change to use `LogicalType.getChildren`?,rename to `fStruct`
+6363,"@@ -1,10 +1,11 @@
+ require 'spec_helper'
+
+ describe '#create' do
+-  it 'sets the payment_method on Purchase to free' do
++  it 'sets the payment_method on Purchase to subscription' do
+     user = create(:user, :with_subscription)
+     create_subscriber_purchase(create(:book_product), user)
+-    user.purchases.last.payment_method.should == 'free'
++    user.purchases.last.payment_method.should eq 'free'
++    user.purchases.last[:payment_method].should eq 'subscription'
+   end
+
+   it 'sets the comments on the purchase if provided' do",I'm confused as to how these are both passing.,Line is too long. [96/80]
+6364,"@@ -0,0 +1,17 @@
++module DashboardsHelper
++  def learn_live_link(&block)
++    if current_user_has_access_to?(:office_hours)
++      link_to OfficeHours.url, target: ""_blank"", &block
++    else
++      content_tag ""a"", &block
++    end
++  end
++
++  def learn_repo_link(&block)
++    if current_user_has_access_to?(:source_code)
++      link_to ENV['LEARN_REPO_URL'], target: ""_blank"", &block
++    else
++      content_tag ""a"", &block
++    end
++  end
++end",Prefer single-quoted strings when you don't need string interpolation or special symbols.,Rails/HelperInstanceVariable: Do not use instance variables in helpers.
+6365,"@@ -28,7 +28,7 @@ class CategoryData
+     public $seoH1s;
+
+     /**
+-     * @var string[]
++     * @var string[]|null[]
+      */
+     public $descriptions;
+ ","there is `""` sign in commit message and colon. can you rename also `descrition` to plural `descriptions` and add there `$` ?",When should this be null?
+6366,"@@ -108,7 +108,9 @@ func (ti *TelemetryInterceptor) Intercept(
+ 	resp, err := handler(ctx, req)
+
+ 	if val, ok := metrics.ContextCounterGet(ctx, metrics.HistoryWorkflowExecutionCacheLatency); ok {
+-		timerNoUserLatency.Subtract(time.Duration(val))
++		userLatencyDuration := time.Duration(val)
++		timerNoUserLatency.Subtract(userLatencyDuration)
++		metricsScope.RecordTimer(metrics.ServiceLatencyUserLatency, userLatencyDuration)
+ 	}
+
+ 	if err != nil {",timerNoUserLatency is not being used?,Should we also record the timer if `ok` is false?
+6367,"@@ -603,6 +603,8 @@ class Serializer(object):
+         :param Date attr: Object to be serialized.
+         :rtype: str
+         """"""
++        if isinstance(attr, str):
++            attr = isodate.parse_date(attr)
+         t = ""{:04}-{:02}-{:02}"".format(attr.year, attr.month, attr.day)
+         return t
+ ","@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :) They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet. Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay.",parse_date() is not a great name for this. Is it something like isodate
+6368,"@@ -553,8 +553,8 @@ namespace pwiz.SkylineTest
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""15N\"" label_15N=\""true\"" />"", true, true, isotopeModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Heavy K\"" aminoacid=\""K\"" label_13C=\""true\"" label_15N=\""true\"" label_18O=\""true\""  label_2H=\""true\""/>"", true, true, isotopeModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Aqua\"" aminoacid=\""K, R\"" label_13C=\""true\"" label_15N=\""true\"" label_18O=\""true\""  label_2H=\""true\""/>"", true, true, isotopeModificationType);
+-            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss1\"" aminoacid=\""T, S\"" formula=\""HPO3\""><fragment_loss formula=\""HP3O4\""/></static_modification>"", true, true, isotopeModificationType);
+-            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss3\"" aminoacid=\""T, S\"" formula=\""HPO3\"" explicit_decl=\""true\""><fragment_loss formula=\""HP3O4\""/><fragment_loss formula=\""H2O\""/><fragment_loss formula=\""NH3\""/></static_modification>"", true, true, isotopeModificationType);
++            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss1\"" aminoacid=\""T, S\"" formula=\""HPO3\""><potential_loss formula=\""HP3O4\""/></static_modification>"", true, true, structuralModificationType);
++            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss3\"" aminoacid=\""T, S\"" formula=\""HPO3\"" explicit_decl=\""true\""><potential_loss formula=\""HP3O4\""/><potential_loss formula=\""H2O\""/><potential_loss formula=\""NH3\""/></static_modification>"", true, true, structuralModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss-only\"" aminoacid=\""K, R, Q, N\""><potential_loss formula=\""NH3\""/></static_modification>"", true, true, structuralModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""LossInclusion\"" aminoacid=\""T, S\"" formula=\""HPO3\""><potential_loss formula=\""HP3O4\"" inclusion=\""Always\""/><potential_loss formula=\""HP2O3\"" inclusion=\""Library\""/><potential_loss formula=\""HP1O2\"" inclusion=\""Never\""/></static_modification>"", true, true, structuralModificationType);
+ ",Why change the name in the XML?,Do we need a test for the potential_loss?
+6369,"@@ -132,7 +132,11 @@ class User < ActiveRecord::Base
+   # = Callbacks =
+   # =============
+
+-  after_update :when_org_changes
++  before_update :clear_other_organisation, if: :org_id_changed?
++
++  after_update :delete_perms!, if: :org_id_changed?, unless: :can_change_org?
++
++  after_update :remove_token!, if: :org_id_changed?, unless: :can_change_org?
+
+   # =================
+   # = Class methods =",This is much cleaner. makes it easier to tell what happens on a save.,I don't understand the purpose of `unless
+6370,"@@ -212,6 +212,8 @@ func refineFiltersOperator(filters []datastore.ListFilter) ([]datastore.ListFilt
+ 			filter.Operator = ""IN""
+ 		case datastore.OperatorNotIn:
+ 			filter.Operator = ""NOT IN""
++		case datastore.OperatorContains:
++			// FIXME: Convert contains operator into one dedicated to MySQL
+ 		case datastore.OperatorNotEqual,
+ 			datastore.OperatorGreaterThan,
+ 			datastore.OperatorGreaterThanOrEqual,",Could you add return error unsupported operator here  ,Rename it to `case datastore.OperatorCont
+6371,"@@ -6,7 +6,8 @@
+ package javaslang.collection;
+
+ import javaslang.*;
+-import javaslang.collection.Stream.*;
++import javaslang.collection.Stream.Cons;
++import javaslang.collection.Stream.Empty;
+ import javaslang.collection.StreamModule.*;
+ import javaslang.control.Option;
+ ","(Mhh, we seem to use different formatters - we should unify them. I like the wildcards)","I'm not sure why you did it that way, but"
+6372,"@@ -54,8 +54,11 @@ func AdminDescribeTaskQueue(c *cli.Context) {
+ 	ctx, cancel := newContext(c)
+ 	defer cancel()
+ 	request := &workflowservice.DescribeTaskQueueRequest{
+-		Namespace:              namespace,
+-		TaskQueue:              &taskqueuepb.TaskQueue{Name: taskQueue},
++		Namespace: namespace,
++		TaskQueue: &taskqueuepb.TaskQueue{
++			Name: taskQueue,
++			Kind: enumspb.TASK_QUEUE_KIND_NORMAL,
++		},
+ 		TaskQueueType:          tlType,
+ 		IncludeTaskQueueStatus: true,
+ 	}",Should `kind` be a command line parameter also?,Why is this `TaskQueue_KIND_NORMAL` instead of `TASK_QUEUE_KIND_NORMAL`?
+6373,"@@ -43,7 +43,7 @@ namespace Nethermind.JsonRpc.Data
+             Gas = transaction.GasLimit;
+             Input = Data = transaction.Data;
+             Type = transaction.Type;
+-            AccessList = TryGetAccessListItems();
++            AccessList = transaction.AccessList is null ? null : AccessListItemForRpc.FromAccessList(transaction.AccessList);
+
+             Signature? signature = transaction.Signature;
+             if (signature != null)",can we have it inside FromAccessList?,`transaction.AccessList` can be null here
+6374,"@@ -64,6 +64,19 @@ var rawRequestPaths = map[string]bool{
+ 	""/v2/teal/compile"": true,
+ }
+
++// unauthorizedRequestError is generated when we receive 401 error from the server. This error includes the inner error
++// as well as the likely parameters that caused the issue.
++type unauthorizedRequestError struct {
++	errorString string
++	apiToken    string
++	url         string
++}
++
++// Error format an error string for the unauthorizedRequestError error.
++func (e unauthorizedRequestError) Error() string {
++	return fmt.Sprintf(""Unauthorized request to `%s` when using token `%s` : %s"", e.url, e.apiToken, e.errorString)
++}
++
+ // RestClient manages the REST interface for a calling user.
+ type RestClient struct {
+ 	serverURL       url.URL",Why not embed filterASCII in this function?,Is this used anywhere?
+6375,"@@ -1872,7 +1872,11 @@ public class ExecutorManager extends EventHandler implements
+           // process flow with current snapshot of activeExecutors
+           selectExecutorAndDispatchFlow(reference, exflow, new HashSet<Executor>(activeExecutors));
+         }
+-        currentContinuousFlowProcessed++;
++
++        // do not count failed flow processsing (flows still in queue)
++        if(queuedFlows.getFlow(exflow.getExecutionId()) == null) {
++          currentContinuousFlowProcessed++;
++        }
+       }
+     }
+ ","I am curious, shouldn't ""currentContinuousFlowProcessed++;"" be added right after line 1873? otherwise we will count 1 extra when a exflow wakes up from the sleep section,.even though it hasn't been assigned",Nit: missing space after `if`
+6376,"@@ -162,6 +162,7 @@ def _get_configtypes():
+                                      configtypes._Numeric] and
+                            issubclass(e, configtypes.BaseType))
+     yield from inspect.getmembers(configtypes, predicate)
++    # pylint: enable=protected-access
+
+
+ def _get_setting_types_quickref():",You can probably move this up after the `._Numeric` line.,Is this the right way to fix the protected access error?
+6377,"@@ -203,6 +203,7 @@ class SGEJobTask(luigi.Task):
+         description=""don't tarball (and extract) the luigi project files"")
+
+     def __init__(self, *args, **kwargs):
++        super(SGEJobTask, self).__init__(*args, **kwargs)
+         if self.job_name:
+             # use explicitly provided job name
+             pass","@Tarrasch this is another change you need to pay attention, it seems `SGEJobTask` is not calling `super.__init__` which break the test case some how.",Shouldn't SGEJobTask be the base class?
+6378,"@@ -0,0 +1,14 @@
++class CreateCompletions < ActiveRecord::Migration
++  def change
++    create_table :completions do |t|
++      t.string :trail_object_id
++      t.string :trail_name
++      t.belongs_to :user
++
++      t.timestamps
++    end
++
++    add_index :completions, :user_id
++    add_index :completions, :trail_object_id
++  end
++end",Do we need indices for this table?,How about a unique index on `trail_name` and `user_id`?
+6379,"@@ -447,6 +447,19 @@ static int process_data(struct flb_http_client *c)
+     return FLB_HTTP_MORE;
+ }
+
++#if defined FLB_HAVE_TESTS_OSSFUZZ
++int fuzz_process_data(struct flb_http_client *c);
++int fuzz_process_data(struct flb_http_client *c) {
++	return process_data(c);
++}
++
++int fuzz_check_connection(struct flb_http_client *c);
++int fuzz_check_connection(struct flb_http_client *c) {
++    return check_connection(c);
++}
++
++#endif
++
+ static int proxy_parse(const char *proxy, struct flb_http_client *c)
+ {
+     int len;",what about making this function static inline to avoid the extra declaration ?,"I may be missing something, but I don't see why fuzz_pro"
+6380,"@@ -21,6 +21,7 @@ import (
+
+ type protocol = string
+ type TableIDType uint8
++type GroupIDType = uint32
+
+ const LastTableID TableIDType = 0xff
+ ","I forget the difference between type definition with ""="" and without ""="" again, but can we unify the style? I believe the difference doesn't apply to TableIDType and GroupIDType whatever it is?",Do we still need this?
+6381,"@@ -49,7 +49,7 @@ return_code parseArguments(int argc,
+         ""Number of threads to use"")(
+         ""core,k"",
+         boost::program_options::value<double>(&contractor_config.core_factor)->default_value(1.0),
+-        ""Percentage of the graph (in vertices) to contract [0..1]"")(
++        ""Percentage of the graph (in vertices) to contract [0..1]. Will always be 1.0"")(
+         ""segment-speed-file"",
+         boost::program_options::value<std::vector<std::string>>(
+             &contractor_config.updater_config.segment_speed_lookup_paths)",would be `DEPRECATED Percentage of the graph (in vertices) to contract [0..1]` better?,I don't think we shoul
+6382,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";
++  String STOP_CASTING = ""stopCasting"";
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`,These API endpoints ar
+6383,"@@ -108,7 +108,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+             }
+
+             string serviceName = null;
+-            Dictionary<string, object> tags = null;
++            Dictionary<string, object> tags = new Dictionary<string, object>();
+             foreach (var label in resource.Attributes)
+             {
+                 string key = label.Key;","if we won't use, should we remove this?",@mjkkirschner @aparaji
+6384,"@@ -230,7 +230,10 @@ namespace MvvmCross.Platforms.Android.Core
+
+         protected virtual IDictionary<string, string> ViewNamespaceAbbreviations => new Dictionary<string, string>
+         {
+-            { ""Mvx"", ""MvvmCross.Platforms.Android.Views"" }
++            { ""Mvx"", ""mvvmcross.platforms.android.views""
++            },
++            { ""Mvx"", ""mvvmcross.platforms.android.binding.views""
++            }
+         };
+
+         protected virtual IEnumerable<string> ViewNamespaces => new List<string>",Having 2 items with the same key (Mvx) won't work in a dictionary,any reason why MvvmCross.Platforms.Android.Views isn't caps?
+6385,"@@ -0,0 +1,17 @@
++class CouponsController < ApplicationController
++  def show
++    if coupon.valid?
++      session[:coupon] = coupon.code
++    else
++      flash[:notice] = ""The coupon code you supplied is not valid.""
++    end
++
++    redirect_to root_path
++  end
++
++  private
++
++  def coupon
++    @coupon ||= Coupon.new(params[:id])
++  end
++end","@cpytel how does the flow work right now? I expect to go to the sign up as customer page after putting in my code, but it goes to the longer landing page?",Prefer single-quoted strings when you don't need string inte
+6386,"@@ -75,10 +75,10 @@ void show_message(
+     //
+     switch (priority) {
+     case MSG_INTERNAL_ERROR:
+-        snprintf(event_msg, sizeof(event_msg), ""[error] %s"", message);
++        snprintf(event_msg, sizeof(event_msg), ""[error] %.512s"", message);
+         break;
+     case MSG_SCHEDULER_ALERT:
+-        snprintf(event_msg, sizeof(event_msg), ""%s: %s"",
++        snprintf(event_msg, sizeof(event_msg), ""%.64s: %.512s"",
+             _(""Message from server""), message
+         );
+         break;","`event_msg` has the same size (1024) as a `message`. Maybe should be increased to 2048 instead? Then this `""[error] %.512s"", message` could be changed to this: `""[error] %.*s"", sizeof(message), message`","I know this is not part of the scope of this PR, but would i"
+6387,"@@ -35,6 +35,7 @@ package org.apache.iceberg;
+  * changes.
+  */
+ public interface ReplacePartitions extends SnapshotUpdate<ReplacePartitions> {
++
+   /**
+    * Add a {@link DataFile} to the table.
+    *",Nit: unnecessary whitespace change.,nit: no need for empty line here
+6388,"@@ -176,7 +176,7 @@ func (b *PinnedMap) Iter(f MapIter) error {
+ 	args := cmd[1:]
+
+ 	printCommand(prog, args...)
+-	output, err := exec.Command(prog, args...).CombinedOutput()
++	output, err := exec.Command(prog, args...).Output()
+ 	if err != nil {
+ 		return errors.Errorf(""failed to dump in map (%s): %s\n%s"", b.versionedFilename(), err, output)
+ 	}","Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`","unrelated to this PR, but should we just remove `printCommand` now?"
+6389,"@@ -119,7 +119,15 @@ void image_data_reader::set_input_params(const int width, const int height, cons
+
+ bool image_data_reader::fetch_label(CPUMat& Y, int data_id, int mb_idx) {
+   const label_t label = m_image_list[data_id].second;
+-  Y.Set(label, mb_idx, 1);
++  if (label >= 0 && label < m_num_labels) {
++    Y.Set(label, mb_idx, 1);
++  }
++  else {
++    LBANN_ERROR(
++      ""\"""",this->get_type(),""\"" data reader "",
++      ""expects data with "",m_num_labels,"" labels, "",
++      ""but data sample "",data_id,"" has a label of "",label);
++  }
+   return true;
+ }
+ ",I would use static_cast<label_t>(0) and static_cast<label_T>(m_num_labels) just in case.,"If you're going to throw an error, then you should return `false`."
+6390,"@@ -406,4 +406,18 @@ public class ZMSUtils {
+
+         return authorityFilter;
+     }
++
++    public static String lowerDomainInResource(String resource) {
++        if (resource == null) {
++            return null;
++        }
++
++        int delimiterIndex = resource.indexOf("":"");
++        if (delimiterIndex == -1) {
++            return resource;
++        }
++
++        String lowerCasedDomain = resource.substring(0, delimiterIndex).toLowerCase();
++        return lowerCasedDomain + resource.substring(delimiterIndex);
++    }
+ }",Even if we want to keep in original case - domain will be lower-cased.,Should this be called lowerDomainInResource?
+6391,"@@ -0,0 +1,9 @@
++class RenameTopicBodyHtmlToTrailMap < ActiveRecord::Migration
++  def up
++    rename_column :topics, :body_html, :trail_map
++  end
++
++  def down
++    rename_column :topics, :trail_map, :body_html
++  end
++end",Based on discussion with Chad it feels like trail_map_json could be a good column name.,How would you feel about renaming this column to `body_html_trail_m
+6392,"@@ -98,9 +98,9 @@ class Users extends Controller
+                 'comment' => $permission->comment,
+                 'type' => 'balloon-selector',
+                 'options' => [
+-                    1 => 'Allow',
+-                    0 => 'Inherit',
+-                    -1 => 'Deny',
++                    1 => Lang::get('backend::lang.user.allow'),
++                    0 => Lang::get('backend::lang.user.inherit'),
++                    -1 => Lang::get('backend::lang.user.deny'),
+                 ],
+                 'attributes' => [
+                     'data-trigger' => ""input[name='User[permissions][superuser]']"",","This array should be logic-less, just the language string (without `Lang::get()`) should appear. Then `trans()` is [or should be] used when the balloon selector renders the values.",Is this supposed to be using `Lang::get('backend.user.deny')`?
+6393,"@@ -253,7 +253,7 @@ module Beaker
+         else
+           task = 'defaultgroup:ensure_default_group'
+         end
+-        on dashboard, ""/opt/puppet/bin/rake -sf /opt/puppet/share/puppet-dashboard/Rakefile #{task} RAILS_ENV=production""
++        on dashboard, ""BUNDLE_GEMFILE=/opt/puppet/share/puppet-dashboard/Gemfile /opt/puppet/bin/bundle/exec /opt/puppet/bin/rake -sf /opt/puppet/share/puppet-dashboard/Rakefile #{task} RAILS_ENV=production""
+
+         # Now that all hosts are in the dashbaord, run puppet one more
+         # time to configure mcollective","This looks like it runs both pre 3.0 rake tasks and 3 rake tasks, and since pre 3.0 we didn't use bundler, my guess is it will fail then.",did you mean to change this to `/opt/puppet/bin/bundle/exec`?
+6394,"@@ -450,7 +450,14 @@ func (m *Manager) Set(container *configs.Config) error {
+ }
+
+ func getUnitName(c *configs.Cgroup) string {
+-	return fmt.Sprintf(""%s-%s.scope"", c.Parent, c.Name)
++	allowed := ""0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ:-_.\\""
++	sanitizeFunc := func(r rune) rune {
++		if strings.ContainsRune(allowed, r) {
++			return r
++		}
++		return '.'
++	}
++	return fmt.Sprintf(""%s-%s.scope"", strings.Map(sanitizeFunc, c.Parent), strings.Map(sanitizeFunc, c.Name))
+ }
+
+ // Atm we can't use the systemd device support because of two missing things:","I'm not sure the replacement is a good idea, and as I said in #336 , this ""parent-name.scope"" is not a good idea in the first place, specially when we support assigning a slice as the parent, so we should change this, WDYT?",Why are you converting a character to a string here? Wouldn't
+6395,"@@ -627,7 +627,7 @@ func (dao *blockDAO) putBlock(blk *block.Block) error {
+ 			log.L().Error(""failed to serialize receipits for block"", zap.Uint64(""height"", blkHeight))
+ 		}
+ 	}
+-	if err = kv.Commit(batchForBlock); err != nil {
++	if err = kv.WriteBatch(batchForBlock); err != nil {
+ 		return err
+ 	}
+ ",sloppyReassign: re-assignment to `err` can be replaced with `err := kv.WriteBatch(batchForBlock)` (from `gocritic`),why change it to WriteBatch?
+6396,"@@ -123,7 +123,11 @@ public class VertxServerResponseToHttpServletResponse extends AbstractHttpServle
+   @Override
+   public CompletableFuture<Void> sendPart(Part part) {
+     DownloadUtils.prepareDownloadHeader(this, part);
+-
++    if (part == null) {
++      CompletableFuture<Void> future = new CompletableFuture<>();
++      future.complete(null);
++      return future;
++    }
+     return new PumpFromPart(context, part).toWriteStream(serverResponse, null);
+   }
+ ",using factory method. return CompletableFuture.completedFuture,We shouldn't use a `CompletableFuture` here. Just return `null`.
+6397,"@@ -31,7 +31,7 @@ storiesOf( 'Global', module )
+ 				title={ __( 'Top content over the last 28 days', 'google-site-kit' ) }
+ 				headerCtaLink=""https://analytics.google.com""
+ 				headerCtaLabel={ __( 'See full stats in Analytics', 'google-site-kit' ) }
+-				footerCtaLabel={ __( 'Analytics', 'google-site-kit' ) }
++				footerCtaLabel={ _x( 'Analytics', 'Service name', 'google-site-kit' ) }
+ 				footerCtaLink=""https://analytics.google.com""
+ 			>
+ 				<AnalyticsDashboardWidgetTopPagesTable />",The `_x` function needs to be imported at the top of the file (in addition to `__`),I think we can remove the `google-site-kit` prefix here and belo
+6398,"@@ -19,7 +19,7 @@ type ofFlow struct {
+ 	// The Flow.Table field can be updated by Reset(), which can be called by
+ 	// ReplayFlows() when replaying the Flow to OVS. For thread safety, any access
+ 	// to Flow.Table should hold the replayMutex read lock.
+-	ofctrl.Flow
++	*ofctrl.Flow
+
+ 	// matchers is string slice, it is used to generate a readable match string of the Flow.
+ 	matchers []string",this looks like the only controversial change potentially. @MatthewHinton56 Could let us know why you made this change (which `go vet` warning was triggered)? @wenyingd could you take a look and let us know if you're okay with this change?,Why are we no longer setting the replayMutex here?
+6399,"@@ -26,7 +26,7 @@ using pwiz.Skyline.Util;
+
+ namespace pwiz.Skyline.Controls.Graphs
+ {
+-    public sealed partial class AreaCVToolbar : GraphSummaryToolbar //UserControl // for designer
++    public sealed partial class AreaCVToolbar : GraphSummaryToolbar //GraphSummaryToolbar UserControl // for designer
+     {
+         private readonly Timer _timer;
+         private int _standardTypeCount;","This seems like left-over debugging code. I think I fixed this to no longer be necessary, switching to UserControl for the designer.","Nice, didn't know about this one :)"
+6400,"@@ -0,0 +1,15 @@
++import re
++import logging
++from localstack.utils.common import to_str, to_bytes
++from localstack.services.generic_proxy import ProxyListener
++from moto.elbv2 import urls
++
++LOG = logging.getLogger(__name__)
++
++
++class ProxyListenerELBV2(ProxyListener):
++    pass
++
++
++# # instantiate listener
++UPDATE_ELBV2 = ProxyListenerELBV2()","As we're currently not applying any logic in the proxy listener, I guess we can simply remove this file (and remove the `listener` argument from the `register_plugin(..)` call above).",remove this file?
+6401,"@@ -86,6 +86,7 @@ func (w *DefaultWorker) Generate(ctx context.Context,
+ 		Proof:           proof,
+ 		StateRoot:       newStateTreeCid,
+ 		Ticket:          ticket,
++		Timestamp:       types.Uint64(time.Now().Unix()),
+ 	}
+
+ 	for i, msg := range res.PermanentFailures {",Isn't the point of the clock module to encapsulate access to `time.Now()`? Coming later?,Is there a reason
+6402,"@@ -117,6 +117,10 @@ func generateFastUpgradeConsensus() (fastUpgradeProtocols config.ConsensusProtoc
+ 		}
+
+ 		fastUpgradeProtocols[consensusTestFastUpgrade(proto)] = fastParams
++
++		// support the ALGOSMALLLAMBDAMSEC = 500 env variable
++		fastParams.AgreementFilterTimeout = time.Second
++		fastParams.AgreementFilterTimeoutPeriod0 = time.Second
+ 	}
+ 	return
+ }","as before - if you've set this, you should be able to get rid of the `os.Setenv(""ALGOSMALLLAMBDAMSEC"", ""500"")`. make sure that the various tests still takes have the same execution time.",why set it to 0 h
+6403,"@@ -450,8 +450,8 @@ module Travis
+             mactex = 'BasicTeX.pkg'
+             # TODO(craigcitro): Confirm that this will route us to the
+             # nearest mirror.
+-            sh.cmd 'wget http://mirror.ctan.org/systems/mac/mactex/'\
+-                   ""#{mactex} -O \""/tmp/#{mactex}\""""
++            sh.cmd 'curl -fLo \""/tmp/#{mactex}\"" --retry 3 http://mirror.ctan.org/systems/mac/mactex/'\
++                   '#{mactex}'
+
+             sh.echo 'Installing OS X binary package for MacTeX'
+             sh.cmd ""sudo installer -pkg \""/tmp/#{mactex}\"" -target /""","Pretty sure the single quotes here should be double quotes, single quotes are not expanded by the shell.",You should be abl
+6404,"@@ -109,8 +109,11 @@ public final class ValidateConstantMessageTests {
+                         ""  void f(boolean bArg, int iArg, Object oArg, Integer[] arrayArg, ""
+                             + ""Collection<String> collectionArg, Map<String, String> mapArg, String stringArg, ""
+                             + ""Iterable<String> iterableArg, double dArg) {"",
++                        ""    String localConstant = \""constant\"";"",
+                         ""    Validate.isTrue(bArg, \""message %d\"", 123L);"",
+                         ""    Validate.isTrue(bArg, \""message %f\"", 0.0);"",
++                        ""    Validate.notBlank(stringArg, \""message %s\"", compileTimeConstant);"",
++                        ""    Validate.notBlank(stringArg, \""message %s\"", localConstant);"",
+                         ""    Validate.isTrue(bArg, \""message %s %s\"", \""msg\"", \""msg\"");"",
+                         ""    Validate.notNull(oArg, \""message %s %s\"", \""msg\"", \""msg\"");"",
+                         ""    Validate.notEmpty(arrayArg, \""message %s %s\"", \""msg\"", \""msg\"");"",","these are not really constants, right?",Nit: some indentation seems off here
+6405,"@@ -1,3 +1,4 @@
++from boto.compat import six
+ # Copyright (c) 2012 Mitch Garnaat http://garnaat.org/
+ # Copyright (c) 2012 Amazon.com, Inc. or its affiliates.  All Rights Reserved
+ #",import below copyright statement,Could you move this down with the ot
+6406,"@@ -49,7 +49,7 @@ describe InvoiceNotifier do
+
+   def customer_should_receive_receipt_email(invoice)
+     email = ActionMailer::Base.deliveries.first
+-    email.subject.should include('receipt')
+-    email.to.should eq [invoice.user_email]
++    expect(email.subject).to include('receipt')
++    expect(email.to).to eq [invoice.user_email]
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [88/80]
+6407,"@@ -200,11 +200,11 @@ class Field implements Translatable
+     }
+
+     /**
+-     * @return string|Markup
++     * @return string|array|Markup
+      */
+     public function getTwigValue()
+     {
+-        $value = $this->__toString();
++        $value = $this->getFlattenedValue();
+
+         if ($this->getDefinition()->get('allow_html')) {
+             $value = new Markup($value, 'UTF-8');",`if (is_string($value) && $this->getDefinition()->get('allow_html')) {`,"`$value` here is still not a string,"
+6408,"@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace
+
+         private void AddInternal(string key, object value)
+         {
+-            Guard.Null(key, nameof(key));
++            Debug.Assert(key != null, $""{nameof(key)} must not be null"");
+
+             this.Attributes[key] = value;
+         }","I think we have the same problem here - if folks called the `public void Add` with a `null` key, we need to use `Guard`.",nit: do we still need the null check here?
+6409,"@@ -0,0 +1,12 @@
++//
++//  Copyright (C) 2020 Greg Landrum
++//   @@ All Rights Reserved @@
++//  This file is part of the RDKit.
++//  The contents are covered by the terms of the BSD license
++//  which is included in the file license.txt, found at the root
++//  of the RDKit source tree.
++//
++
++#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only do
++                           // this in one cpp file
++#include ""catch.hpp""",I thought that the main was in catch_qt.cpp?,I'm not sure this is the right file for th
+6410,"@@ -87,7 +87,7 @@ public class ImagesManageActivity extends BaseActivity {
+     private static final int REQUEST_UNSELECT_IMAGE_AFTER_LOGIN = 4;
+     public static final int REQUEST_EDIT_IMAGE = 1000;
+     private static final int REQUEST_CHOOSE_IMAGE = 1001;
+-    private static final List<ProductImageField> TYPE_IMAGE = Arrays.asList(ProductImageField.FRONT, ProductImageField.INGREDIENTS, ProductImageField.NUTRITION);
++    private static final List<ProductImageField> TYPE_IMAGE = Arrays.asList(ProductImageField.FRONT, ProductImageField.INGREDIENTS, ProductImageField.NUTRITION, ProductImageField.PACKAGING);
+     private ActivityFullScreenImageBinding binding;
+     private OpenFoodAPIClient client;
+     private File lastViewedImage;","I would rename the field to IMAGE_TYPES and make it an array. I don't think we need list operations. Also, if possible, I would move the field to the ApiFields class. What do you think?",why not put it in a constant?
+6411,"@@ -117,6 +117,17 @@ func verifyContainerRunningStateChangeWithRuntimeID(t *testing.T, taskEngine Tas
+ 		""Expected container runtimeID should not empty"")
+ }
+
++func verifyExecAgentRunningStateChange(t *testing.T, taskEngine TaskEngine) {
++	stateChangeEvents := taskEngine.StateChangeEvents()
++	event := <-stateChangeEvents
++	containerEvent := event.(api.ContainerStateChange)
++	assert.NotEmpty(t, containerEvent.ManagedAgents, ""Expected exec-agent event has no managed agents"")
++	if containerEvent.ManagedAgents != nil {
++		assert.Equal(t, apicontainerstatus.ManagedAgentRunning, containerEvent.ManagedAgents[0].Status,
++			""expected managedAgent container state change event did not match actual event"")
++	}
++}
++
+ func verifyContainerStoppedStateChange(t *testing.T, taskEngine TaskEngine) {
+ 	stateChangeEvents := taskEngine.StateChangeEvents()
+ 	event := <-stateChangeEvents","I'd prefer to timeout on this, but I know it's not a pattern that is being followed",This is not a test. It's a bug in the test
+6412,"@@ -37,10 +37,7 @@ import org.apache.lucene.store.BufferedChecksumIndexInput;
+ import org.apache.lucene.store.ChecksumIndexInput;
+ import org.apache.lucene.store.IOContext;
+ import org.apache.lucene.store.IndexInput;
+-import org.apache.lucene.util.BytesRef;
+-import org.apache.lucene.util.BytesRefBuilder;
+-import org.apache.lucene.util.IOUtils;
+-import org.apache.lucene.util.StringHelper;
++import org.apache.lucene.util.*;
+
+ /**
+  * Reads vector values from a simple text format. All vectors are read up front and cached in RAM in",hmm let's not use * imports please,I think our coding guidelines prefer explicit imports.
+6413,"@@ -497,6 +497,10 @@ func generateAlertmanagerConfig(version semver.Version, am v1.AlertmanagerEndpoi
+ 		cfg = append(cfg, k8sSDWithNamespaces([]string{am.Namespace}))
+ 	}
+
++	if am.BearerTokenFile != """" {
++		cfg = append(cfg, yaml.MapItem{Key: ""bearer_token_file"", Value: am.BearerTokenFile})
++	}
++
+ 	var relabelings []yaml.MapSlice
+
+ 	relabelings = append(relabelings, yaml.MapSlice{",is this configuration key already exist in prometheus ?,Doesn't this have to be a `map[string]interface{}` for
+6414,"@@ -2,6 +2,7 @@ require ""test_helper""
+
+ class DiaryEntryControllerTest < ActionController::TestCase
+   include ActionView::Helpers::NumberHelper
++  api_fixtures
+
+   def setup
+     # Create the default language for diary entries","As @gravitystorm said new tests need to be using factories, not fixtures.",Can these be removed?
+6415,"@@ -171,8 +171,8 @@ bool CliManager::readLine(std::string &line, bool linebreak) {
+         if (!isInteractive_) {
+             break;
+         }
+-        auto purePrompt = folly::stringPrintf(""(%s@%s:%d) [%s]> "",
+-                                              username_.c_str(), addr_.c_str(), port_,
++        auto purePrompt = folly::stringPrintf(""(%s@) [%s]> "",
++                                              username_.c_str(),
+                                               cmdProcessor_->getSpaceName().c_str());
+         if (linebreak) {
+             purePrompt.assign(purePrompt.size() - 3, ' ');",You can replace IP by hostname.,This doesn't need the `addr_.c_str()` call anymore.
+6416,"@@ -123,13 +123,14 @@ def getDriversForConnectedUsbDevices():
+ 			for port in deviceInfoFetcher.comPorts if ""usbID"" in port)
+ 	)
+ 	for match in usbDevs:
+-		# check for the Braille HID protocol before any other device matching.
+-		if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILLE:
+-			yield (""hid"", match)
+ 		for driver, devs in _driverDevices.items():
+ 			for type, ids in devs.items():
+ 				if match.type==type and match.id in ids:
+ 					yield driver, match
++		# check for the Braille HID protocol after any other device matching.
++		if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILLE:
++			yield (""hid"", match)
++
+
+ def getDriversForPossibleBluetoothDevices():
+ 	""""""Get any matching drivers for possible Bluetooth devices.","This should say ""why"" NVDA should do things in this order.",How is this change related to the PR?
+6417,"@@ -114,7 +114,7 @@ func TestPopulateLocationConstraint(t *testing.T) {
+ func TestNoPopulateLocationConstraintIfProvided(t *testing.T) {
+ 	s := s3.New(unit.Session)
+ 	req, _ := s.CreateBucketRequest(&s3.CreateBucketInput{
+-		Bucket: aws.String(""bucket""),
++		Bucket:                    aws.String(""bucket""),
+ 		CreateBucketConfiguration: &s3.CreateBucketConfiguration{},
+ 	})
+ 	if err := req.Build(); err != nil {",nit these will get changed back during next release.,Nit: please remove this unnecessary c
+6418,"@@ -0,0 +1,8 @@
++// Copyright 2021 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package api
++
++// Version is set in the build process.
++var Version string",it is actually not needed to make the member public. the build tags can also set a package scoped variable.,do we need this?
+6419,"@@ -38,6 +38,7 @@ trait ContentExtrasTrait
+             'excerpt' => $this->contentExtension->getExcerpt($content),
+             'link' => $this->contentExtension->getLink($content),
+             'editLink' => $this->contentExtension->getEditLink($content),
++            'icon' => $this->contentExtension->getIcon($content),
+         ];
+     }
+ }",We already have a method for it 'icon' => $content->getIcon(),please add the `icon` property in the
+6420,"@@ -9,6 +9,7 @@ import (
+ 	""github.com/aws/aws-sdk-go/service/kms""
+ 	""github.com/aws/aws-sdk-go/service/s3""
+ 	""github.com/aws/aws-sdk-go/service/s3/s3iface""
++	""golang.org/x/net/context""
+ )
+
+ // WrapEntry is builder that return a proper key decrypter and error",Instead of importing `golang.org/x/net/context` The SDK should use `aws.BackgroundContext()` instead of `context.Background()`,Nit: remove empty line
+6421,"@@ -38,7 +38,7 @@ class MediaController extends Controller
+      */
+     public function getMedia($id)
+     {
+-        return $this->get('sonata.media.manager.media')->findOneBy(array('id' => $id));
++        return $this->get('sonata.media.manager.media')->find($id);
+     }
+
+     /**",I think this is an agnostic change for the ORM right? Why was it doing this? - this does not work on PHPCR-ODM as the `id` is not a field - although I guess it could be mapped as such.,Isn't that a BC break?
+6422,"@@ -73,7 +73,7 @@ class ApplicationController < ActionController::Base
+   helper_method :included_in_current_users_plan?
+
+   def topics
+-    Topic.top
++    Topic.all
+   end
+   helper_method :topics
+ ","I'm not 100% sure, but I think this should be `explorable`. If not, I think `explorable` can be removed entirely.",Is there a reason we n
+6423,"@@ -124,15 +124,13 @@ class MockTarget(target.FileSystemTarget):
+                 self.wrapper = wrapper
+
+             def write(self, data):
+-                if six.PY3:
+-                    stderrbytes = sys.stderr.buffer
+-                else:
+-                    stderrbytes = sys.stderr
+-
+                 if mock_target._mirror_on_stderr:
+                     if self._write_line:
+                         sys.stderr.write(fn + "": "")
+-                    stderrbytes.write(data)
++                    if six.binary_type:
++                        sys.stderr.write(data.decode('utf8'))
++                    else:
++                        sys.stderr.write(data)
+                     if (data[-1]) == '\n':
+                         self._write_line = True
+                     else:",Note to self: Why was this not originally not using `stderrbytes`?,It's not clear to me w
+6424,"@@ -364,6 +364,14 @@ bool FileUtils::exist(const std::string& path) {
+     return access(path.c_str(), F_OK) == 0;
+ }
+
++// static
++bool FileUtils::rename(const std::string& src, const std::string& dst) {
++    auto status = ::rename(src.c_str(), dst.c_str());
++    LOG_IF(WARNING, status < 0) << ""Rename "" << src << "" to "" << dst << "" failed, the errno: ""
++        << ::strerror(errno);
++    return status == 0;
++}
++
+ std::vector<std::string> FileUtils::listAllTypedEntitiesInDir(
+         const char* dirpath,
+         FileType type,","Is betterLOG_IF(ERROR, status != 0) ?","LOG_IF(WARNING, status < 0) ?"
+6425,"@@ -38,6 +38,9 @@ class BaseLoadTest(TestCase):
+         self.session.auth = self.auth
+         self.session.headers.update({'Content-Type': 'application/json'})
+
++        self.bucket = 'default'
++        self.collection = 'default'
++
+         # Keep track of created objects.
+         self._collections_created = {}
+ ",I wouldn't call it default too.,What's the difference between
+6426,"@@ -2,6 +2,7 @@
+  * and will be replaced soon by a Vue component.
+  */
+
++/* eslint-disable no-var */
+ import browser from 'browser';
+ import dom from 'dom';
+ import 'css!./navdrawer';",Why disable the rule for this file?,Why is this needed?
+6427,"@@ -76,6 +76,7 @@ CTA.propTypes = {
+ 	'aria-label': PropTypes.string,
+ 	error: PropTypes.bool,
+ 	onClick: PropTypes.func,
++	ctaLinkExternal: PropTypes.bool,
+ };
+
+ CTA.defaultProps = {",Thanks for adding this :+1:. Could you please move it to go after the `ctaLink` prop?,The name `ctaLinkExternal` se
+6428,"@@ -193,7 +193,7 @@ namespace Nethermind.Core.Collections
+
+             public T Current => _array[_index];
+
+-            object IEnumerator.Current => Current;
++            object IEnumerator.Current => Current!;
+
+             public void Dispose() { }
+         }",The other way around Current can be null.,What's the reason for adding a `!` here?
+6429,"@@ -230,7 +230,8 @@ class SideMenuBuilder
+
+         $communicationMenu = $menu->addChild('communication', ['label' => t('Communication with customer')]);
+         $communicationMenu->addChild('mail_settings', ['route' => 'admin_mail_setting', 'label' => t('Email settings')]);
+-        $communicationMenu->addChild('mail_templates', ['route' => 'admin_mail_template', 'label' => t('Email templates')]);
++        $mailTemplates = $communicationMenu->addChild('mail_templates', ['route' => 'admin_mail_template', 'label' => t('Email templates')]);
++        $mailTemplates->addChild('edit_template', ['route' => 'admin_mail_edit', 'label' => t('Editing email template'), 'display' => false]);
+         $communicationMenu->addChild('order_confirmation', ['route' => 'admin_customercommunication_ordersubmitted', 'label' => t('Order confirmation page')]);
+
+         $listsMenu = $menu->addChild('lists', ['label' => t('Lists and nomenclatures')]);",why does it have to be here? Due to breadcrumb navigation?,Please update the `label` option in the
+6430,"@@ -21,10 +21,18 @@ import (
+
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	""github.com/openebs/maya/pkg/util""
++	""k8s.io/apimachinery/pkg/api/resource""
+ 	v1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/types""
+ )
+
++//TODO: Move to some common function
++func StrToQuantity(capacity string) resource.Quantity {
++	qntCapacity, _ := resource.ParseQuantity(capacity)
++	//	fmt.Printf(""Error: %v"", err)
++	return qntCapacity
++}
++
+ // TestCreateVolumeTarget is to test cStorVolume creation.
+ func TestCreateVolumeTarget(t *testing.T) {
+ 	testVolumeResource := map[string]struct {",I fear moving this to some common func. We are swallowing the error here. This might be ok in UT but not in actual source code.,"This is no longer needed, right?"
+6431,"@@ -716,12 +716,9 @@ class TestMessagesStore(object):
+         with pytest.raises(InvalidMessageError) as cm:
+             store.add_renamed_message(
+                 'W1234', 'old-msg-symbol', 'duplicate-keyword-arg')
+-        assert str(cm.value) == ""Message id 'W1234' is already defined""
+-        # conflicting message symbol
+-        with pytest.raises(InvalidMessageError) as cm:
+-            store.add_renamed_message(
+-                'W1337', 'msg-symbol', 'duplicate-keyword-arg')
+-        assert str(cm.value) == ""Message symbol 'msg-symbol' is already defined""
++        expected = ""Message id 'W1234' cannot have both 'msg-symbol' and \
++'old-msg-symbol' as symbolic name.""
++        assert str(cm.value) == expected
+
+     def test_renamed_message_register(self, store):
+         assert 'msg-symbol' == store.check_message_id('W0001').symbol","Please don't use \ as a line continuation. Do an implicit string join instead with parens: ``` (""Message ..."" ""and ..."")",why is this being removed?
+6432,"@@ -258,7 +258,6 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey,
+ 		return nil, fmt.Errorf(""localstore: %w"", err)
+ 	}
+ 	b.localstoreCloser = storer
+-	// register localstore unreserve function on the batchstore before batch service starts listening to blockchain events
+
+ 	batchStore, err := batchstore.New(stateStore, nil)
+ 	if err != nil {",there needs to be a change here. setting up the batchstore with localstore.Unreserve hook,@andrewkroh I'm not sure if this is correct. The problem is that no one calls `batchstore.Close()` right after batch service has been started. So maybe we should move this line to before batch service starts.
+6433,"@@ -52,9 +52,15 @@ public final class ConfigUtil {
+
+   private static final String MICROSERVICE_CONFIG_LOADER_KEY = ""cse-microservice-config-loader"";
+
++  private static ConfigModel model = new ConfigModel();
++
+   private ConfigUtil() {
+   }
+
++  public static void setConfigs(Map<String, Object> config) {
++    model.setConfig(config);
++  }
++
+   public static Object getProperty(String key) {
+     Object config = DynamicPropertyFactory.getBackingConfigurationSource();
+     return getProperty(config, key);","I think if we can provide a more convenient method to add configs . e.g. public static void addConfig(String k, Object v)",This method is not needed anymore.
+6434,"@@ -266,7 +266,7 @@ func TestActPool_AddActs(t *testing.T) {
+ 	err = ap.AddTsf(overBalTsf)
+ 	require.Equal(ErrBalance, errors.Cause(err))
+ 	// Case VI: over gas limit
+-	creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), blockchain.GasLimit+100, big.NewInt(10), []byte{})
++	creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), action.GasLimit+100, big.NewInt(10), []byte{})
+ 	require.NoError(err)
+ 	err = ap.AddExecution(creationExecution)
+ 	require.Equal(ErrGasHigherThanLimit, errors.Cause(err))",line is 165 characters,why remove the blockchain argument here?
+6435,"@@ -0,0 +1,8 @@
++package org.jkiss.dbeaver.ext.oceanbase.data;
++
++import org.jkiss.dbeaver.model.impl.jdbc.data.handlers.JDBCStandardValueHandlerProvider;
++
++public class OceanbaseValueHandlerProvider extends JDBCStandardValueHandlerProvider{
++
++
++}","Please add a copyright notice. Also, could you tell me please why do we need this empty provider here?",This should probably be renamed to `OceanbaseHandlerProvider`
+6436,"@@ -95,8 +95,11 @@ public class EeaSendRawTransaction implements JsonRpcMethod {
+         maybePrivacyGroup =
+             privacyController.retrieveOnChainPrivacyGroup(
+                 maybePrivacyGroupId.get(), enclavePublicKey);
+-        if (maybePrivacyGroup.isEmpty()
+-            && !privacyController.isGroupAdditionTransaction(privateTransaction)) {
++        if (maybePrivacyGroup.isEmpty()) {
++          if (!privacyController.isGroupAdditionTransaction(privateTransaction)) {
++            return new JsonRpcErrorResponse(id, JsonRpcError.ONCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST);
++          }
++        } else if (!maybePrivacyGroup.get().getMembers().contains(enclavePublicKey)) {
+           return new JsonRpcErrorResponse(id, JsonRpcError.ONCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST);
+         }
+       } else { // !onchainPirvacyGroupEnabled",I feel like this would be easier to read if we join the two if's together: `if (maybePrivacyGroup.isEmpty() && !privacyController.isGroupAdditionTransaction(privateTransaction))`,This looks like a regression. Is there any way to reproduce the problem?
+6437,"@@ -567,7 +567,7 @@ public class DBOpenHelper extends SQLiteOpenHelper {
+ 		try {
+ 			result = new JSONObject(loadSoupBlobAsString(soupTableName, soupEntryId, passcode));
+
+-		} catch (JSONException ex) {
++		} catch (Exception ex) {
+ 			Log.e(""DBOpenHelper:loadSoupBlob"", ""Exception occurred while attempting to read external soup blob."", ex);
+ 		}
+ 		return result;","Tests are failing because the exception type is NullPointException here if the soupBlob is deleted (so instead of a mal-format json, it's a null)",Why are we changing the type of exception here?
+6438,"@@ -439,12 +439,8 @@ Blockly.Connection.prototype.isConnectionAllowed = function(candidate) {
+       break;
+     }
+     case Blockly.OUTPUT_VALUE: {
+-      // Don't offer to connect an already connected left (male) value plug to
+-      // an available right (female) value plug.
+-      if (candidate.targetConnection || this.targetConnection) {
+-        return false;
+-      }
+-      break;
++      // Can't drag an input to an output--you have to move the inferior block.
++      return false;
+     }
+     case Blockly.INPUT_VALUE: {
+       // Offering to connect the left (male) of a value block to an already","Glad we fixed this as well. Blockly is going to be left as-is for this case, right?","nit: drop the ""output"" part of the sentence."
+6439,"@@ -36,9 +36,7 @@ import java.util.Locale;
+  * This class represents a typical Salesforce object.
+  *
+  * @author bhariharan
+- * @deprecated Will be removed in Mobile SDK 7.0.
+  */
+-@Deprecated
+ public class SalesforceObject {
+
+     protected String objectType;",I had accidentally deprecated this class. This is meant to stick around. Only `SalesforceObjectType` goes away.,Why did you remove this?
+6440,"@@ -208,6 +208,7 @@ def rev_hex(s):
+ def int_to_hex(i, length=1):
+     assert isinstance(i, int)
+     s = hex(i)[2:].rstrip('L')
++    s = s.lstrip('0x')
+     s = ""0""*(2*length - len(s)) + s
+     return rev_hex(s)
+ ",`hex(i)[2:]` is trying to do the same thing above. what is `i` in your malformed case?,Can you explain why this change is needed?
+6441,"@@ -126,8 +126,8 @@ public class XML {
+     }
+   }
+
+-  /** escapes character data in val */
+-  public final static void writeXML(Writer out, String tag, String val, Object... attrs) throws IOException {
++  /** escapes character data in val if shouldEscape is true*/
++  public final static void writeXML(Writer out, String tag, boolean shouldEscape, String val, Object... attrs) throws IOException {
+     out.write('<');
+     out.write(tag);
+     for (int i=0; i<attrs.length; i++) {","I think this change is redundant; see the previously defined method ""writeUnescapedXML"".",`final` should be capitalized
+6442,"@@ -0,0 +1,18 @@
++package types
++
++import cbor ""gx/ipfs/QmRoARq3nkUb13HSKZGepCZSWe5GrVPwx7xURJGZ7KWv9V/go-ipld-cbor""
++
++func init() {
++	cbor.RegisterCborType(Commitments{})
++}
++
++// CommitmentLength is the length of a single commitment (in bytes).
++const CommitmentLength = 32
++
++// Commitments is a struct containing the replica and data commitments produced
++// when sealing a sector.
++type Commitments struct {
++	CommD     [CommitmentLength]byte
++	CommR     [CommitmentLength]byte
++	CommRStar [CommitmentLength]byte
++}",Ah now I have at least some idea what these are for.,I don't really like the name of this struc
+6443,"@@ -58,8 +58,8 @@ public class DataReader<T> implements DatumReader<T> {
+   }
+
+   @Override
+-  public void setSchema(Schema fileSchema) {
+-    this.fileSchema = Schema.applyAliases(fileSchema, readSchema);
++  public void setSchema(Schema schema) {
++    this.fileSchema = Schema.applyAliases(schema, readSchema);
+   }
+
+   @Override",I believe in previous PRs @mccheah frequently used `fileSchema` -> `newFileSchema` type of renames to avoid hiding fields in builders. Would it make sense to make it consistent?,Could you explain why this change is neede
+6444,"@@ -62,9 +62,17 @@ func (manager *connectionManager) Connect(consumerID, providerID identity.Identi
+ 		}
+ 	}()
+
++	err = manager.startConnection(consumerID, providerID)
++	if err == utils.ErrRequestCancelled {
++		return ErrConnectionCancelled
++	}
++	return err
++}
++
++func (manager *connectionManager) startConnection(consumerID, providerID identity.Identity) (err error) {
+ 	cancelable := utils.NewCancelable()
+ 	manager.cleanConnection = utils.CallOnce(func() {
+-		log.Info(managerLogPrefix, ""Canceling connection initiation"")
++		log.Info(managerLogPrefix, ""Cancelling connection initiation"")
+ 		manager.status = statusDisconnecting()
+ 		cancelable.Cancel()
+ 	})",Do we really need separate error in manager if utils.ErrRequestCancelled is the only error which indicates cancelation ?,Maybe log the error as debug level?
+6445,"@@ -136,7 +136,7 @@ MODEL_PARAMS = {
+
+             # Temporal Pooler implementation selector (see _getTPClass in
+             # CLARegion.py).
+-            'temporalImp': 'cpp',
++            'temporalImp': 'tm_cpp',
+
+             # New Synapse formation count
+             # NOTE: If None, use spNumActivePerInhArea",Leave as `cpp` since that still gives better results.,Why this change? The docstring says
+6446,"@@ -27,7 +27,7 @@ import (
+ 	""sigs.k8s.io/controller-runtime/pkg/predicate""
+ )
+
+-func pausedPredicates(logger logr.Logger) predicate.Funcs {
++func PausedPredicates(logger logr.Logger) predicate.Funcs {
+ 	return predicate.Funcs{
+ 		UpdateFunc: func(e event.UpdateEvent) bool {
+ 			return processIfUnpaused(logger.WithValues(""predicate"", ""updateEvent""), e.ObjectNew, e.MetaNew)",temp change so the predicate can be used by the `exp` package,Renamed this function because it wa
+6447,"@@ -387,6 +387,11 @@ class KeyboardInputGesture(inputCore.InputGesture):
+ 			# This could be for an event such as gyroscope movement,
+ 			# so don't report it.
+ 			return False
++		if self.vkCode in self.TOGGLE_KEYS:
++			# #5490: Dont report for keys that toggle on off.
++			# This is to avoid them from reported twice: once by the 'speak command keys' feature,
++			# and once by the 'speak typed characters' feature
++			return False
+ 		return not self.isCharacter
+
+ 	def _get_isCharacter(self):","Just as a tiny clarification, this isn't affected in any way by ""speak typed characters"". That is, ""caps lock on"", etc. is always spoken, even if speak typed characters is off.",Don't report for commands that togg
+6448,"@@ -61,10 +61,11 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe
+ 	}
+ 	hLog.Info(""deployment applied (%s)"", result)
+
+-	// Deploy the desired ClusterImageSets representing installable releases of OpenShift.
+-	// TODO: in future this should be pipelined somehow.
+ 	applyAssets := []string{
+ 		""config/manager/service.yaml"",
++
++		// Deploy the desired ClusterImageSets representing installable releases of OpenShift.
++		// TODO: in future this should be pipelined somehow.
+ 		""config/clusterimagesets/openshift-4.0-latest.yaml"",
+ 		""config/clusterimagesets/openshift-4.0-beta3.yaml"",
+ 		""config/clusterimagesets/openshift-4.0-beta4.yaml"",",@dgoodwin Will it cause an issue when the issue get fixed in OLM?,@deads2k @smarterclayton @jwforres @jwforres @deads2k is this ok?
+6449,"@@ -29,9 +29,8 @@ namespace Nethermind.Blockchain.Processing
+         IgnoreParentNotOnMainChain = 16,
+         DoNotVerifyNonce = 32,
+         DoNotUpdateHead = 64,
+-        DumpParityTraces = 128,
+-        DumpGetTraces = 256,
+-        All = 511,
++        RerunWithTraceOnFailure = 128,
++        All = 255,
+         ProducingBlock = NoValidation | ReadOnlyChain,
+         Trace = ForceProcessing | ReadOnlyChain | DoNotVerifyNonce | NoValidation,
+         Beam = IgnoreParentNotOnMainChain | DoNotUpdateHead",This option is now unnecessary,"Nit: To me, `RerunWithTraceOnFailure` sounds a bit redundant with"
+6450,"@@ -360,10 +360,7 @@ func TestWriter(t *testing.T) {
+ 			t.Fatal(err)
+ 		}
+
+-		b, err := NewBucket(subdir)
+-		if err != nil {
+-			t.Fatal(err)
+-		}
++		b := &bucket{dir: subdir}
+ 		ctx := context.Background()
+ 		names := []string{
+ 			// Backslashes not allowed.","Don't jump down to the unexported interface: just set the content type to `""application/octet-stream""` explicitly when creating the `Writer`.",What's the purpose of this change?
+6451,"@@ -176,8 +176,11 @@ class BufferedUpdates implements Accountable {
+   }
+
+   void clearDeleteTerms() {
+-    deleteTerms.clear();
+     numTermDeletes.set(0);
++    deleteTerms.forEach((term, docIDUpto) -> {
++      bytesUsed.addAndGet(-(BYTES_PER_DEL_TERM + term.bytes.length + (Character.BYTES * term.field().length())));
++    });
++    deleteTerms.clear();
+   }
+
+   void clear() {","Instead of counting this here on clear, can we use a second counter for the deleteTerms next to `bytesUsed`? This would be great. It doesn't need to be thread safe IMO","It's not a big deal, but this line seems unnecessary, as the `del"
+6452,"@@ -24,10 +24,10 @@ class User extends UserBase
+      * Validation rules
+      */
+     public $rules = [
+-        'email' => 'required|between:6,255|email|unique:backend_users',
+-        'login' => 'required|between:2,255|unique:backend_users',
+-        'password' => 'required:create|between:4,255|confirmed',
+-        'password_confirmation' => 'required_with:password|between:4,255'
++        'email' => 'required|between:6,191|email|unique:backend_users',
++        'login' => 'required|between:2,191|unique:backend_users',
++        'password' => 'required:create|between:8,191|confirmed',
++        'password_confirmation' => 'required_with:password|between:8,191'
+     ];
+
+     /**",@daftspunk @bennothommo I wonder if we need to go as deep as detecting what the default varchar length is with a special character to be parsed by the validation trait since we've introduced the config for it.,"Change to: `required|between:8,191,191|confirmed`"
+6453,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below,This would be a breaking change. Can we instead p
+6454,"@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+             ""com.fsck.k9.activity.MessageCompose.quotedTextFormat"";
+     private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = ""numAttachmentsLoading"";
+     private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = ""waitingForAttachments"";
+-
++    private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmpySubject"";
+     private static final String LOADER_ARG_ATTACHMENT = ""attachment"";
+
+     private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = ""waitingForAttachment"";","Typo, should read `firstTimeEmptySubject`",Let's rename this to `EMPTY_EMPTY_SUBJECT`
+6455,"@@ -22,7 +22,7 @@ package transport
+
+ import ""golang.org/x/net/context""
+
+-// Handler handles a single transport-level request.
++// Handler handles a single, transport-level, unary request.
+ type Handler interface {
+ 	// Handle the given request, writing the response to the given
+ 	// ResponseWriter.",The more I see this the more I think the transport layer _should_ actually refer to this as `UnaryHandler`.,Unnecessary new line?
+6456,"@@ -267,6 +267,7 @@ module Beaker
+         logger.warn ""#{e.class} error in scp'ing. Forcing the connection to close, which should "" <<
+           ""raise an error.""
+         close
++        raise ""#{e}\n#{e.backtrace}""
+       end
+
+ ",The `warn` message here seems to indicate that the forced closure of the SSH connection should raise an error; is that getting swallowed up somewhere and not raising?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+6457,"@@ -616,6 +616,8 @@ class FilenamePrompt(_BasePrompt):
+         self._init_texts(question)
+         self._init_key_label()
+
++        self._expands_user = False
++
+         self._lineedit = LineEdit(self)
+         if question.default:
+             self._lineedit.setText(question.default)","I wonder if this is a fitting name. Why ""expands user""? Wouldn't be `user_expanded` or so be more fitting?",Don't we already set this in `_init_texts`?
+6458,"@@ -28,10 +28,11 @@ var axe = axe || { utils: {} };
+  */
+ function virtualDOMfromNode(node, shadowId) {
+ 	const vNodeCache = {};
+-	return {
++	const vNode = {
+ 		shadowId: shadowId,
+ 		children: [],
+ 		actualNode: node,
++		_isHidden: null, // will be populated by axe.utils.isHidden
+ 		get isFocusable() {
+ 			if (!vNodeCache._isFocusable) {
+ 				vNodeCache._isFocusable = axe.commons.dom.isFocusable(node);","I see what you are doing here, but to stay with the `getter/setter` pattern, should we introduce `set isHidden(value)` & `get isHidden()` which them maintains `_isHidden` with in `vNodeCache`. This will avoid what looks like accessing an internal property like `_isHidden` from `axe.utils.isHidden` & keeps things neat.","This is a bit weird, why not just add a `isFocusable` property to `vNode`?"
+6459,"@@ -41,6 +41,7 @@ public class CSharpBasicPackageTransformer implements ModelToViewTransformer<Pro
+       ""csharp/gapic_snippets_csproj.snip"";
+   private static final String UNITTEST_CSPROJ_TEMPLATE_FILENAME =
+       ""csharp/gapic_unittest_csproj.snip"";
++  private static final String SAMPLE_CSPROJ_TEMPLATE_FILENAME = ""csharp/gapic_samples_csproj.snip"";
+
+   private static final CSharpAliasMode ALIAS_MODE = CSharpAliasMode.MessagesOnly;
+ ","nit: for consistency, have this line and the previous formatted similarly",Should we rename this file to `gapic_samples_csproj.snip` ?
+6460,"@@ -165,6 +165,9 @@ public class PrivacyParameters {
+     private PrivacyStorageProvider storageProvider;
+     private EnclaveFactory enclaveFactory;
+     private boolean multiTenancyEnabled;
++    private Path orionKeyStoreFile;
++    private Path orionKeyStorePasswordFile;
++    private Path orionClientWhitelistFile;
+
+     public Builder setPrivacyAddress(final Integer privacyAddress) {
+       this.privacyAddress = privacyAddress;","As before, shouldn't mention these as being orion options I don't think. Perhaps just enclaveKeyStoreFile etc.",Should this be a `Path`?
+6461,"@@ -152,10 +152,8 @@ async function observeRestResponse( res ) {
+ 		// The response may fail to resolve if the test ends before it completes.
+ 		try {
+ 			args.push( await res.text() );
++			console.log( ...args ); // eslint-disable-line no-console
+ 		} catch ( err ) {} // eslint-disable-line no-empty
+-
+-		// eslint-disable-next-line no-console
+-		console.log( ...args );
+ 	}
+ }
+ ",What's the thinking here? Only logging when the test has not ended yet?,let's move this back to
+6462,"@@ -57,6 +57,12 @@ def _column_op(f):
+             args = [arg._scol if isinstance(arg, IndexOpsMixin) else arg for arg in args]
+             scol = f(self._scol, *args)
+
++            # If f is a logistic operator, fill NULL with False
++            log_ops = ['eq', 'ne', 'lt', 'le', 'ge', 'gt']
++            is_log_op = any(f == getattr(spark.Column, f'__{log_op}__') for log_op in log_ops)
++            if is_log_op:
++                scol = F.when(scol.isNull(), False).otherwise(scol)
++
+             return self._with_new_scol(scol)
+         else:
+             # Different DataFrame anchors",@HyukjinKwon @ueshin (cc @itholic @charlesdong1991 ) Not sure if this is the right implementation ...,I think it would be clea
+6463,"@@ -10,7 +10,13 @@ module.exports = function(url, options, callback) {
+   if (typeof options === 'function') (callback = options), (options = {});
+   options = options || {};
+
+-  let result = parser.parse(url, true);
++  let result;
++  try {
++    result = parser.parse(url, true);
++  } catch (e) {
++    return callback(new Error('URL malformed, cannot be parsed'));
++  }
++
+   if (result.protocol !== 'mongodb:' && result.protocol !== 'mongodb+srv:') {
+     return callback(new Error('Invalid schema, expected `mongodb` or `mongodb+srv`'));
+   }",Do we want to add any specific error on how the url is malformed?,Is there a way to tell t
+6464,"@@ -190,6 +190,10 @@ void Host::appendLogsInternal(folly::EventBase* eb,
+             {
+                 std::lock_guard<std::mutex> g(self->lock_);
+                 self->setResponse(r);
++                self->lastLogIdSent_++;
++                if (self->lastLogIdSent_ < self->logIdToSend_) {
++                    ++self->lastLogIdSent_;
++                }
+             }
+             self->noMoreRequestCV_.notify_all();
+             return;",why NOT self->lastLogIdSent_ = self->logIdToSend_,"Doesn't this need to reset `lastLogIdSent_` after the response is sent? Otherwise, it looks like you're leaking a response if you fail to send it."
+6465,"@@ -599,6 +599,18 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ 				return reconcile.Result{Requeue: true}, nil
+ 			}
+ 		}
++		// Set the Provisioned status condition for adopted clusters (and in case we upgraded to/past where that condition was introduced)
++		if err := r.updateCondition(
++			cd,
++			hivev1.ProvisionedCondition,
++			corev1.ConditionTrue,
++			hivev1.ProvisionedProvisionedReason,
++			""Cluster is provisioned"",
++			cdLog,
++		); err != nil {
++			cdLog.WithError(err).Error(""Error updating Provisioned status condition"")
++			return reconcile.Result{}, err
++		}
+
+ 		// update SyncSetFailedCondition status condition
+ 		cdLog.Debug(""Check if any syncsets are failing"")",Shouldn't this be in the above `if` block where we are setting the installedtimestamp to ensure this only happens for already installed (and/or adopted) clusters?,"What does ""in case we upgraded to/past"" mean?"
+6466,"@@ -422,7 +422,7 @@ class SessionManager(QObject):
+                                         window=window.win_id)
+             tab_to_focus = None
+             for i, tab in enumerate(win['tabs']):
+-                new_tab = tabbed_browser.tabopen()
++                new_tab = tabbed_browser.tabopen(background=False)
+                 self._load_tab(new_tab, tab)
+                 if tab.get('active', False):
+                     tab_to_focus = i",This seems like another unrelated change I've done in `master`.,"Can you explain this change? It looks like it fixes a bug, but I'm not sure what the problem is."
+6467,"@@ -873,6 +873,15 @@ module RSpec::Core
+           expect(config.formatters.first.output.path).to eq(path)
+         end
+       end
++
++      context ""when a duplicate formatter exists for the same output target"" do
++        it ""does not add the formatter"" do
++          config.add_formatter :documentation
++          expect {
++            config.add_formatter :documentation
++          }.not_to change { config.formatters.length }
++        end
++      end
+     end
+
+     describe ""#filter_run_including"" do","Would be good to have another context `""when a duplicate formatter exists for a different output target""` that shows that it keeps both. As this stands, the specs could pass w/o the `formatter.output == new_formatter.output` check.",Rubocop complained about `not_to change { config.formatters.length }` here. I think it might be clearer to use `expect(config.formatters.size).to
+6468,"@@ -217,14 +217,15 @@ void SYCLSharedUSMSpace::deallocate(const char* arg_label,
+                   Kokkos::Tools::make_space_handle(name()));
+ }
+
+-void SYCLDeviceUSMSpace::impl_access_error() {
++KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error() {
+   const std::string msg(
+       ""Kokkos::Experimental::SYCLDeviceUSMSpace::impl_access_error attempt to ""
+       ""execute device function from non-device space"");
+   Kokkos::Impl::throw_runtime_exception(msg);
+ }
+
+-void SYCLDeviceUSMSpace::impl_access_error(const void* const) {
++KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error(
++    const void* const) {
+   impl_access_error();
+ }
+ ",Why not just remove? The CUDA one has been around for while. This one has not been part of any release (?),Why not make this `const std::exception&` instead?
+6469,"@@ -83,8 +83,9 @@ public class Session implements ContentBlocking.Delegate, GeckoSession.Navigatio
+     private transient SharedPreferences mPrefs;
+     private transient GeckoRuntime mRuntime;
+     private transient byte[] mPrivatePage;
+-    private transient boolean mFirstContentfulPaint;
++    private transient boolean mFirstContentFulPaint;
+     private transient long mKeepAlive;
++    private transient boolean mIsFirstActivation;
+
+     public interface BitmapChangedListener {
+         void onBitmapChanged(Session aSession, Bitmap aBitmap);","nit: `Contentful` is the word used in the GV API, without the uppercase in F",`mIsFirstActivation` does not seem to be used anyw
+6470,"@@ -83,6 +83,12 @@ public class SchemaMeta extends CommonService<OperationMeta> {
+   }
+
+   private void initOperations() {
++    if (swagger.getPaths() == null) {
++      LOGGER.error(swagger.getInfo().getTitle() + "" with path "" + swagger.getBasePath()
++          + "" is an empty interface, please delete it or fill with one method!"");
++      return;
++    }
++
+     for (Entry<String, Path> entry : swagger.getPaths().entrySet()) {
+       String strPath = entry.getKey();
+       Path path = entry.getValue();","It just does the check, maybe we can name it as checkOperations.",this should not be an error level log. Sorry I did
+6471,"@@ -344,7 +344,7 @@ describe('runRules', function() {
+ 		});
+
+ 		fixture.innerHTML =
+-			'<div id=""t1""><span></span></div><div id=""t2""><em></em></div>';
++			'<div id=""t1""><em></em></div><div id=""t2""><em></em></div>';
+
+ 		var $test = {
+ 			0: fixture.querySelector('#t1'),",We no longer have karma output in the test file so these selectors were now unique and the target didn't need a child selector. Updated to force non-unique nodes,What's the purpose of this change?
+6472,"@@ -1,8 +1,14 @@
++<% content_for :additional_header_links do %>
++  <% if current_user.has_subscription_with_mentor? %>
++    <li class=""mentor"">
++      <%= mentor_image(current_user.mentor) %>
++      <%= mentor_contact_link(current_user.mentor) %>
++    </li>
++  <% end %>
++<% end %>
++
+ <section class=""workshops vertical-slider revealed"">
+-  <figure class=""meta product-card"">
+-    <%= render 'mentor' %>
+-    <%= render 'trails' %>
+-  </figure>
++  <%= render 'trails' %>
+   <%= render partial: 'products/workshop', collection: online_workshops %>
+   <%= render partial: 'products/workshop', collection: in_person_workshops %>
+ </section>",This moved from a partial to not being in a partial. How about cleaning this view up further by moving it back into a partial?,Use `<%= mentor_contact_link(current_user.mentor)` instead.
+6473,"@@ -42,6 +42,7 @@ func NewLightweightInformer(
+ 	objType runtime.Object,
+ 	resync time.Duration,
+ 	h cache.ResourceEventHandler,
++	recieveUpdates bool,
+ ) cache.Controller {
+ 	cacheStore := cache.NewIndexer(cache.DeletionHandlingMetaNamespaceKeyFunc, cache.Indexers{})
+ 	fifo := cache.NewDeltaFIFOWithOptions(cache.DeltaFIFOOptions{",add some form of docs in docstring or on :74 for what the effect is,I don't see where it is used.
+6474,"@@ -13,7 +13,8 @@ from kinto.core.storage import (
+     StorageBase,
+     exceptions,
+ )
+-from kinto.core.utils import COMPARISON, find_nested_value, json
++from kinto.core.utils import COMPARISON, find_nested_value
++import json
+
+
+ def tree():",Couldn't you import `json` from `kinto.core.utils` here too?,This seems unrelated?
+6475,"@@ -8,6 +8,9 @@ require 'rspec/rails'
+ require 'steps/user_steps'
+ require 'steps/approval_steps'
+
++# mimic production env for view+mail
++ENV[""DISABLE_SANDBOX_WARNING""] = 'true'
++
+ # Requires supporting ruby files with custom matchers and macros, etc, in
+ # spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+ # run as spec files by default. This means that files in spec/support that end",Minor: Hmmm...is it worth setting this explicitly for the tests that it affects?,I think this should be `false` by default.
+6476,"@@ -42,7 +42,6 @@ using namespace eprosima::fastrtps::rtps;
+
+ StatefulReader::~StatefulReader()
+ {
+-    std::lock_guard<std::recursive_timed_mutex> guard(mp_mutex);
+     logInfo(RTPS_READER,""StatefulReader destructor."");
+     is_alive_ = false;
+ ","This was added to fix a race condition and you are reverting it here, right?","The recursive lock isn't needed here because of the lock in constructor. Also, the recursive lock is already locked in the constructor."
+6477,"@@ -2,11 +2,16 @@ package commands
+
+ import (
+ 	""context""
++	""fmt""
+
+ 	""github.com/ledgerwatch/turbo-geth/common""
+ )
+
+-// Etherbase is the address that mining rewards will be send to
++// Coinbase is the address that mining rewards will be sent to
+ func (api *APIImpl) Coinbase(_ context.Context) (common.Address, error) {
++	if api.ethBackend == nil {
++		// We're running in --chaindata mode or otherwise cannot get the backend
++		return common.Address{}, fmt.Errorf(""eth_coinbase function is not available"")
++	}
+ 	return api.ethBackend.Etherbase()
+ }","Could you add some extra text here, so that it reads ""eth_coinbase function is not available, please use --private.api.addr option instead of --chaindata option"", so that it is clear that the function can work, but different options",is there a better way to check if the backend is nil?
+6478,"@@ -159,6 +159,19 @@ feature 'Creating an NCR work order' do
+       expect(page).to have_content('$2,000 for construction')
+     end
+
++    scenario ""selecting Expense Type toggles Building required flag"", :js do
++      login_as(requester)
++      visit ""/ncr/work_orders/new""
++      find(""#ncr_work_order_expense_type_ba60"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to_not match('required')
++      find(""#ncr_work_order_expense_type_ba61"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to match('required')
++      find(""#ncr_work_order_expense_type_ba80"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to match('required')
++      find(""#ncr_work_order_expense_type_ba60"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to_not match('required')
++    end
++
+     scenario 'defaults to no approver if there was no previous request' do
+       login_as(requester)
+       visit '/ncr/work_orders/new'",`new_ncr_work_order_path` ? (I've been slowly moving specs over to that way of calling paths),Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+6479,"@@ -15,7 +15,9 @@
+                         application/javascript
+                         text/css
+                         image/*
+-                        application/x-shockwave-flash
++                        application/x-shockwave-flash ?
++                        font/*
++                        application/font-*
+         ~h rex      Header line in either request or response
+         ~hq rex     Header in request
+         ~hs rex     Header in response",Should flash be included in the patterns too? It currently isn't.,I think this should be `application/x-shockwave-flash?`
+6480,"@@ -18,7 +18,7 @@ namespace Microsoft.Cci.Differs.Rules
+             if (impl.IsEffectivelySealed() && !contract.IsEffectivelySealed())
+             {
+                 differences.AddIncompatibleDifference(this,
+-                    ""Type '{0}' is sealed in the implementation but not sealed in the contract."", impl.FullName());
++                    $""Type '{impl.FullName()}' is sealed in the {Right} but not sealed in the {Left}."");
+
+                 return DifferenceType.Changed;
+             }",I suspect I will have to keep looking whether Left/Right refers to contract/Implementation while working on the rules code.,These are the two strings that show up in the logs.
+6481,"@@ -76,7 +76,7 @@ namespace AutoRest.CSharp.Azure
+                     if (model.Extensions.ContainsKey(AzureExtensions.AzureResourceExtension) &&
+                         (bool)model.Extensions[AzureExtensions.AzureResourceExtension])
+                     {
+-                        model.BaseModelType = new CompositeType { Name = ""IResource"", SerializedName = ""IResource"" };
++                        model.BaseModelType = new CompositeType { Name = ""Microsoft.Rest.Azure.IResource"", SerializedName = ""Microsoft.Rest.Azure.IResource"" };
+                     }
+                 }
+             }",(ignore this. testing a codeflow bug),"I don't think this is correct, the generated type s"
+6482,"@@ -137,9 +137,9 @@ func buildCLIOptions() *cli.App {
+ 			EnvVar: ""CASSANDRA_TLS_CA"",
+ 		},
+ 		cli.BoolFlag{
+-			Name:   schema.CLIFlagTLSEnableHostVerification,
+-			Usage:  ""TLS host verification"",
+-			EnvVar: ""CASSANDRA_TLS_VERIFY_HOST"",
++			Name:   schema.CLIFlagTLSDisableHostVerification,
++			Usage:  ""Cassandra tls verify server hostname"",
++			EnvVar: ""CASSANDRA_TLS_DISABLE_HOST_VERIFICATION"",
+ 		},
+ 	}
+ ","[Nit] can you change the Usage wording to indicate that the flag is used to opt-out of server certificate verification? (e.g. ""disables validation of the Cassandra cluster's server certificate."")",I think this should be `CASSANDRA_TLS_VERIFY_HOST`
+6483,"@@ -14,6 +14,8 @@
+ package zipkin.storage.elasticsearch;
+
+ import com.google.common.base.Throwables;
++import java.io.IOException;
++import java.util.List;
+ import zipkin.DependencyLink;
+ import zipkin.Span;
+ import zipkin.internal.MergeById;","Sorry :) Would be really helpful to integrate something like Eclipse Code Formatter, so it will fail if the code style is broken (the same as eslint fails on the frontend) I use IntelliJ IDEA and their vision of imports is a bit different :)",Do we need to import java.util.List when we are alr
+6484,"@@ -362,7 +362,17 @@ module Beaker
+       block_on host do |host|
+         if host['platform'] =~ /centos|el-|redhat|fedora/
+           logger.debug(""Disabling iptables on #{host.name}"")
+-          host.exec(Command.new(""sudo su -c \""/etc/init.d/iptables stop\""""), {:pty => true})
++          if host.exec(Command.new('whoami')).stdout.chomp =~ /root/ #don't need to sudo if we are root
++            if host.check_for_command('iptables') #is iptables even installed?
++              host.exec(Command.new(""/etc/init.d/iptables stop""))
++            else
++              logger.warn(""iptables not installed on #{host.name} (#{host['platform']})"")
++            end
++          else
++            if host.exec(Command.new(""sudo su -c \""/etc/init.d/iptables stop\""""), {:pty => true, :acceptable_exit_codes => (0..255)}).exit_code != '0'
++              logger.warn(""failed to disable iptables on #{host.name} (#{host['platform']})"")
++            end
++          end
+         else
+           logger.warn(""Attempting to disable iptables on non-supported platform: #{host.name}: #{host['platform']}"")
+         end",this will still fail on systemd,this should probably be `/etc/iptables` instead of `/etc/init.d/iptables`
+6485,"@@ -3760,6 +3760,8 @@ class RDSConnection(AWSQueryConnection):
+                                      path='/', params=params)
+         body = response.read()
+         boto.log.debug(body)
++        if type(body) == bytes:
++            body = body.decode('utf-8')
+         if response.status == 200:
+             return json.loads(body)
+         else:","The convention in most of the codebase is to use `if isinstance(body, bytes):` instead.",I think we should be using `isinstance` instead of `type() == bytes`
+6486,"@@ -249,7 +249,9 @@ class ConsoleUI(wx.Frame):
+ 		if self.completionAmbiguous:
+ 			menu = wx.Menu()
+ 			for comp in completions:
+-				item = menu.Append(wx.ID_ANY, comp)
++				# Only show text after the last dot (so as to not keep repeting the class or module in the context menu)
++				label=comp.split('.')[-1]
++				item = menu.Append(wx.ID_ANY, label)
+ 				self.Bind(wx.EVT_MENU,
+ 					lambda evt, completion=comp: self._insertCompletion(original, completion),
+ 					item)","I think this would be better as: `label = comp.rsplit('.', 1)[-1]`","I don't love this, but it feels a bit hacky. :-)"
+6487,"@@ -57,8 +57,8 @@ public class RubyProvider {
+   }
+
+   @SuppressWarnings(""unchecked"")
+-  public <Element> GeneratedResult generate(
+-      Element element, SnippetDescriptor snippetDescriptor, RubyGapicContext context) {
++  public <Element, ContextT> GeneratedResult generate(
++      Element element, SnippetDescriptor snippetDescriptor, ContextT context) {
+     ImmutableMap<String, Object> globalMap =
+         ImmutableMap.<String, Object>builder().put(""context"", context).build();
+     RubySnippetSet<Element> snippets =",We have been creating a language-level context interface for each language instead of parameterizing the generate function.,i think we should just make this `ContextT` rather than `ContextT`
+6488,"@@ -21,6 +21,6 @@ class UuidGenerator implements GeneratorInterface
+     {
+         $id = (string) $media->getId();
+
+-        return sprintf('%s/%04s/%02s', $media->getContext(), substr($id, 0, 4), substr($id, 4, 2));
++        return sprintf('%s/%04s/%02s', $media->getContext() ?? '', substr($id, 0, 4), substr($id, 4, 2));
+     }
+ }",Same thing about context here.,why not `null` first ?
+6489,"@@ -634,9 +634,16 @@ func (handler *workflowTaskHandlerImpl) handleCommandContinueAsNewWorkflow(
+ 		return handler.failCommand(enumspb.WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND, nil)
+ 	}
+
++	namespaceEntry, err := handler.namespaceCache.GetNamespaceByID(handler.mutableState.GetExecutionInfo().NamespaceId)
++	if err != nil {
++		return err
++	}
++	namespace := namespaceEntry.GetInfo().Name
++
+ 	if err := handler.validateCommandAttr(
+ 		func() error {
+ 			return handler.attrValidator.validateContinueAsNewWorkflowExecutionAttributes(
++				namespace,
+ 				attr,
+ 				handler.mutableState.GetExecutionInfo(),
+ 			)",there is a function to get namespace entry from mutable state directly,Do we need to load the
+6490,"@@ -191,7 +191,7 @@ module Bolt
+         hiera_config: @hiera_config,
+         plan_vars: plan_vars,
+         # This data isn't available on the target config hash
+-        config: @inventory.config.transport_data_get
++        config: @inventory.transport_data_get
+       }
+
+       description = options[:description] || 'apply catalog'",The `Transport::Config` objects don't serialize properly. We probably want to just turn them into hashes at this point.,Metrics/LineLength: Li
+6491,"@@ -251,11 +251,11 @@ const ConfigInstructions = `
+ # These values specify the destination directory for ddev ssh and the
+ # directory in which commands passed into ddev exec are run.
+
+-# omit_containers: [""dba"", ""ddev-ssh-agent""]
+-# would omit the dba (phpMyAdmin) and ddev-ssh-agent containers. Currently
+-# only those two containers can be omitted here.
+-# Note that these containers can also be omitted globally in the
+-# ~/.ddev/global_config.yaml or with the ""ddev config global"" command.
++# omit_containers: [""db"", dba"", ""ddev-ssh-agent""]
++# Currently only these containers are supported. Some containers can also be
++# omitted globally in the ~/.ddev/global_config.yaml. Note that if you omit
++# the ""db"" container, several standard features of ddev that access the
++# database container will be unusuable.
+
+ # nfs_mount_enabled: false
+ # Great performance improvement but requires host configuration first.","Sorry, typo s/unusuable/unusable/",I think it would be be
+6492,"@@ -242,6 +242,13 @@ public class SparkSessionCatalog<T extends TableCatalog & SupportsNamespaces>
+
+   @Override
+   public final void initialize(String name, CaseInsensitiveStringMap options) {
++    if (options.containsKey(""type"") && options.get(""type"").equalsIgnoreCase(""hive"") && options.containsKey(""uri"")) {
++      throw new UnsupportedOperationException(""Cannot set an alternative uri when"" +
++              "" using the SparkSessionCatalog, "" +
++              ""make an alternative SparkCatalog if the "" +
++              ""Spark Session catalog and Iceberg "" +
++              ""catalog should contact different metastores."");
++    }
+     this.catalogName = name;
+     this.icebergCatalog = buildSparkCatalog(name, options);
+     if (icebergCatalog instanceof StagingTableCatalog) {","If this is needed, should we check that the configured `uri` isn't already equal to the value of the metastore URI configured via `spark.hadoop.hive.metastore.uris` or any of the other ways of setting it. This would be a breaking change for people who have `uri` configured on the SparkSessionCatalog and have it correctly set (which I believe should be everybody as `uri` is currently required if I'm not mistaken).","shouldn't this be `options.get(""type"") == ""hive""`?"
+6493,"@@ -21,4 +21,7 @@ class ViewMultipart(base.View):
+             return ""Multipart form"", self._format(v)
+
+     def render_priority(self, data: bytes, *, content_type: Optional[str] = None, **metadata) -> float:
+-        return float(content_type == ""multipart/form-data"")
++        if content_type and content_type.startswith(""multipart/form-data""):
++            return 1
++        else:
++            return 0","see above - this is only used to select the correct view, we don't need to handle the boundary information here.","Nit: In Python, we prefer to use lowercase letters"
+6494,"@@ -555,6 +555,7 @@ func TestSign(t *testing.T) {
+ 								LastTransitionTime: &metaFixedClockStart,
+ 							}),
+ 							gen.SetCertificateRequestCertificate(certPEM),
++							gen.SetCertificateRequestCA(certPEM),
+ 							gen.AddCertificateRequestAnnotations(map[string]string{cmapi.VenafiPickupIDAnnotationKey: ""test""}),
+ 						),
+ 					)),","These tests use a self-signed cert so the CA *is* the cert. I considered making a proper chain to use in the tests, but wasn't sure it was necessary to test here, since we test it in the E2E tests anyway.",does this need the `CA` suffix?
+6495,"@@ -212,6 +212,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+
+ 	if (newVNode.type===null) {
+ 		if (oldProps !== newProps) {
++			if (excessDomChildren!=null) {
++				const index = excessDomChildren.indexOf(dom);
++				if (index > -1) excessDomChildren[index] = null;
++			}
+ 			dom.data = newProps;
+ 		}
+ 	}","We could, maybe, just directly do `excessDomChildren[excessDomChildren.indexOf(dom)] = null;`. Would this improve the size in any way? This will end-up with a property on the `excessDomChildren[""-1""]` but maybe we could live with that?","Minor, but this can be written as `if (excessDomCh"
+6496,"@@ -1278,6 +1278,11 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC
+     for ( var i = mouseWheeltoBind.length; i; ) {
+       $elm.on(mouseWheeltoBind[--i], cbs[fn]);
+     }
++    $elm.on('$destroy', function unbindEvents() {
++      for ( var i = mouseWheeltoBind.length; i; ) {
++        $elm.off(mouseWheeltoBind[--i], cbs[fn]);
++      }
++    });
+   };
+   s.off.mousewheel = function (elm, fn) {
+     var $elm = angular.element(elm);",this looks like it may be something that needs additional refactoring,"This could just be `$elm.off(mouseWheeltoBind[--i], cbs[fn])`"
+6497,"@@ -300,7 +300,7 @@ class Resource(object):
+                 for resource in yielder.iter():
+                     res = resource
+                     new_stack = stack + [self]
+-
++
+                     # Parallelization for resource subtrees.
+                     if res.should_dispatch():
+                         callback = partial(res.try_accept, visitor, new_stack)",Nit: Remove whitespace (and below),Please don't make unrelated changes in your PR.
+6498,"@@ -205,7 +205,10 @@ return [
+         'error_moving_file' => 'Error moving file :file',
+         'error_moving_directory' => 'Error moving directory :dir',
+         'error_deleting_directory' => 'Error deleting the original directory :dir',
+-        'path' => 'Path'
++        'path' => 'Path',
++        'unzip' => 'Unzip',
++        'is_a_directory' => 'Only files are allowed. You\'ve selected a directory.',
++        'error_open_zip' => 'Error open the zip file'
+     ],
+     'component' => [
+         'menu_label' => 'Components',","""Failed opening"" or ""Failed to open"".",Use the new Ruby 1.9 hash syntax.
+6499,"@@ -131,8 +131,12 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError {
+ 		if _, err := s.w.images.regUse(d.SourceImage, s); err != nil {
+ 			errs = addErrs(errs, Errf(""%s: can't use image %q: %v"", pre, d.SourceImage, err))
+ 		}
++	} else if d.SourceSnapshot != """" {
++		if _, err := s.w.snapshots.regUse(d.SourceSnapshot, s); err != nil {
++			errs = addErrs(errs, Errf(""%s: can't use snapshot %q: %v"", pre, d.SourceSnapshot, err))
++		}
+ 	} else if d.Disk.SizeGb == 0 {
+-		errs = addErrs(errs, Errf(""%s: SizeGb and SourceImage not set"", pre))
++		errs = addErrs(errs, Errf(""%s: SizeGb, SourceSnapshot or SourceImage not set"", pre))
+ 	}
+
+ 	// Register creation.",and -> or,"if `d.SourceSnapshot == """"` it should still fail, right?"
+6500,"@@ -683,5 +683,17 @@ describe('model', function() {
+         yield User.collection.drop();
+       });
+     });
++    it('should do a dryRun feat-10316', function() {
++      return co(function*() {
++        const userSchema = new mongoose.Schema({ username: String }, { password: String }, { email: String });
++        userSchema.index({ password: 1 });
++        userSchema.index({ email: 1 });
++        const User = db.model('Upson', userSchema);
++        yield User.collection.createIndex({ age: 1 });
++        const result = yield User.diffIndexes();
++        assert.deepStrictEqual(result.toDrop, ['age_1']);
++        assert.deepStrictEqual(result.toCreate, [{ password: 1 }, { email: 1 }]);
++      });
++    });
+   });
+ });",Add a `yield User.init()` here to wait for all indexes to finish building,Please use `expect()` instead of `assert.deepStrictEqual()`.
+6501,"@@ -11,6 +11,8 @@
+ #include <ifaddrs.h>
+ #include <arpa/inet.h>
+
++DEFINE_string(local_ip, """", ""local ip"");
++
+ namespace nebula {
+ namespace network {
+ ","I don't think this belongs here. If the application can take a local_ip as input, the application should take care of it, not in this common library","I don't think this should be a define, is it?"
+6502,"@@ -524,6 +524,17 @@ class Theme
+         return ThemeData::forTheme($this);
+     }
+
++    /**
++     * Remove data specific to this theme
++     * @return bool
++     */
++    public function removeCustomData()
++    {
++        if ($this->hasCustomData()) {
++            return $this->getCustomData()->delete();
++        }
++    }
++
+     /**
+      * Checks to see if the database layer has been enabled
+      *","@DanHarrin please add a `return true` at the bottom of this method, as the docblock indicates a boolean return value.",What do you think about using `delete` instead of `delete`?
+6503,"@@ -25,7 +25,7 @@ import org.apache.lucene.index.SlowImpactsEnum;
+
+ /** Expert: A <code>Scorer</code> for documents matching a <code>Term</code>.
+  */
+-final class TermScorer extends Scorer {
++public final class TermScorer extends Scorer {
+   private final PostingsEnum postingsEnum;
+   private final ImpactsEnum impactsEnum;
+   private final DocIdSetIterator iterator;",This is used in o.a.l.sandbox.search.BM25FQuery.,Why not just make the `TermScorer` package private and expos
+6504,"@@ -41,7 +41,8 @@ public class XYShapeBoundingBoxQuery extends ShapeQuery {
+   @Override
+   protected PointValues.Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
+                                                         int maxXOffset, int maxYOffset, byte[] maxTriangle) {
+-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
++    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
++        queryRelation == QueryRelation.INTERSECTS);
+   }
+
+   /** returns true if the query matches the encoded triangle */",Shouldn't this work as well for Disjoint?,this should be done in a static method so that we don't have to pass `queryRelation` everywhere.
+6505,"@@ -50,6 +50,9 @@ class TestCase(unittest.TestCase):
+       for nm, fn in Descriptors._descList:
+         try:
+           v = fn(m)
++        except RuntimeError:
++          # 3D descriptors fail since the mol has no conformers
++          pass
+         except Exception:
+           import traceback
+           traceback.print_exc()","Same here. This was included to quiet the test for the 3D descriptors. As we removed them, this exception handling is no longer required",@farrufat-cimne This is the only change needed to address the error. Is there a better way to ca
+6506,"@@ -26,6 +26,7 @@
+
+ #include ""lbann/utils/lbann_library.hpp""
+ #include ""lbann/callbacks/callback_checkpoint.hpp""
++#include ""lbann/data_store/data_store_jag.hpp""
+
+ namespace lbann {
+ ",Why do you need to load a specific data reader in lbann_library?,How come this one is removed? I see that data_store_jag.hpp is not present in this file.
+6507,"@@ -31,10 +31,10 @@ namespace Nethermind.Runner.Ethereum.Steps
+             _context = context;
+         }
+
+-        public ValueTask Execute()
++        public Task Execute()
+         {
+             _context.ChainSpec.Bootnodes = _context.ChainSpec.Bootnodes?.Where(n => !n.NodeId?.Equals(_context.NodeKey.PublicKey) ?? false).ToArray() ?? new NetworkNode[0];
+-            return default;
++            return Task.CompletedTask;
+         }
+     }
+ }",why not ValueTask?,shouldn't this return a Task.FromResult(null)?
+6508,"@@ -422,7 +422,7 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ 		return reconcile.Result{Requeue: true}, nil
+ 	}
+
+-	if cd.Status.InstallerImage == nil {
++	if !cd.Status.Installed && (cd.Status.InstallerImage == nil || cd.Status.CLIImage == nil) {
+ 		return r.resolveInstallerImage(cd, imageSet, releaseImage, hiveImage, cdLog)
+ 	}
+ ","I'm nervous about this line, I don't want to go regenerate a bunch of imageset jobs for clusters that are old, already installed, but don't have a CLIImage set (which they wouldn't because they're old) Adding the Installed guard is meant to address this. Otherwise this *should* recreate the imageset job due to the code in this function that deletes the job if it's finished. (but we don't have our images set due to this clause)",Why not just call `cd.Status.Installed`?
+6509,"@@ -303,7 +303,8 @@ public class HadoopTables implements Tables, Configurable {
+       }
+
+       Map<String, String> properties = propertiesBuilder.build();
+-      TableMetadata metadata = tableMetadata(schema, spec, sortOrder, properties, location);
++
++      TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, sortOrder, location, properties);
+       ops.commit(null, metadata);
+       return new BaseTable(ops, location);
+     }",Is it necessary to change this file? Doesn't `tableMetadata` call `newTableMetadata`?,Can this call be moved to `TableMetadata
+6510,"@@ -78,12 +78,6 @@ func TestCatchupOverGossip(t *testing.T) {
+ 	t.Parallel()
+ 	// ledger node upgraded version, fetcher node upgraded version
+ 	runCatchupOverGossip(t, false, false)
+-	// ledger node older version, fetcher node upgraded version
+-	runCatchupOverGossip(t, true, false)
+-	// ledger node upgraded older version, fetcher node older version
+-	runCatchupOverGossip(t, false, true)
+-	// ledger node older version, fetcher node older version
+-	runCatchupOverGossip(t, true, true)
+ }
+
+ func runCatchupOverGossip(t *testing.T,","I think that I have a better proposal for this test - improve it so that it would know how to read the list of SupportedProtocolVersions and dynamically use these. The motivation here is that I expect to have another network version soon, and this test seems to be a good test case for that.",why is this removed?
+6511,"@@ -89,10 +89,13 @@ public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, Supp
+
+     try {
+       List<String> tables = clients.run(client -> client.getAllTables(database));
+-      return tables.stream()
++      List<TableIdentifier> tableIdentifiers = tables.stream()
+           .map(t -> TableIdentifier.of(namespace, t))
+           .collect(Collectors.toList());
+
++      LOG.debug(""Listing of namespace [{}] resulted in the following tables: [{}]"", namespace, tableIdentifiers);
++      return tableIdentifiers;
++
+     } catch (UnknownDBException e) {
+       throw new NoSuchNamespaceException(""Namespace does not exist: %s"", namespace);
+ ",What is the purpose of this debug message? I'm not sure how it would help.,We should only log this if `tables.isEmp
+6512,"@@ -25,7 +25,6 @@ import (
+ 	""time""
+
+ 	""kythe.io/kythe/go/extractors/bazel""
+-	""kythe.io/kythe/go/extractors/bazel/extutil""
+ )
+
+ var (",Is there a corresponding BUILD dependency to prune?,What's the reasoning behind moving this?
+6513,"@@ -2066,7 +2066,14 @@ func testSignedURL(t *testing.T, newHarness HarnessMaker) {
+ 	}
+ 	getURLNoParamsURL.RawQuery = """"
+ 	getURLNoParams := getURLNoParamsURL.String()
+-	putURL, err := b.SignedURL(ctx, key, &blob.SignedURLOptions{Method: http.MethodPut})
++	const (
++		goodContentType = ""text/plain""
++		badContentType  = ""application/octet-stream""
++	)
++	putURL, err := b.SignedURL(ctx, key, &blob.SignedURLOptions{
++		Method:      http.MethodPut,
++		ContentType: goodContentType,
++	})
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	} else if putURL == """" {","The ""good"" and ""bad"" descriptions confused me a bit. Maybe `allowedContentType` and `disallowedContentType`? Not sure if that's better.",Why the check for `application/octet-str
+6514,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()),I don't think this is correct. It's call
+6515,"@@ -106,11 +106,11 @@ func TestServerRoutesWithAuthAndBCrypt(t *testing.T) {
+ 	srvB := RunServer(optsB)
+ 	defer srvB.Shutdown()
+
+-	urlA := fmt.Sprintf(""nats://%s:%d/"", optsA.Host, optsA.Port)
+-	urlB := fmt.Sprintf(""nats://%s:%d/"", optsB.Host, optsB.Port)
++	urlA := fmt.Sprintf(""nats://%s:%s@%s:%d/"", optsA.Username, optsA.Password, optsA.Host, optsA.Port)
++	urlB := fmt.Sprintf(""nats://%s:%s@%s:%d/"", optsB.Username, optsB.Password, optsB.Host, optsB.Port)
+
+ 	// Wait for route to form.
+-	time.Sleep(250 * time.Millisecond)
++	time.Sleep(4 * time.Second)
+
+ 	nc1, err := nats.Connect(urlA)
+ 	if err != nil {","You may want to have a look at `func checkClusterFormed(t *testing.T, servers ...*Server)` in this file that I created some time ago. It will timeout at 5 seconds, but will return as soon as cluster is ready.",Might as well add a timeout to the `nats
+6516,"@@ -662,8 +662,14 @@ static void push_cb (flux_t *h, flux_msg_handler_t *mh,
+         aggregate_sink (h, ag);
+     rc = 0;
+ done:
+-    if (flux_respond (h, msg, rc < 0 ? saved_errno : 0, NULL) < 0)
+-        flux_log_error (h, ""aggregator.push: flux_respond"");
++    if (rc < 0) {
++        if (flux_respond_error (h, msg, saved_errno, NULL) < 0)
++            flux_log_error (h, ""aggregator.push: flux_respond_error"");
++    }
++    else {
++        if (flux_respond (h, msg, NULL) < 0)
++            flux_log_error (h, ""aggregator.push: flux_respond"");
++    }
+ }
+
+ ","I see a few places where this blob of code is required due to the removal of `errnum` parameter from `flux_respond` -- trading 2 lines of code for 8. The improvement to the function seems like a good idea, but I wonder if we need a convenience macro or function to do it the old way? You went through and made all the changes, was it overall a net win?",This line has no test coverage.
+6517,"@@ -23,9 +23,9 @@
+  */
+ import {
+ 	appendNotificationsCount,
+-	sendAnalyticsTrackingEvent,
+ 	getQueryParameter,
+ } from './util/standalone';
++import { trackEvent } from './util/tracking';
+
+ // Set webpackPublicPath on-the-fly.
+ if ( global.googlesitekitAdminbar && global.googlesitekitAdminbar.publicPath ) {","I know it's not related to your change, but it's a bit odd that this import uses a relative path rather than the ones setup by webpack. Might be nice to change this one in case we refactor those paths in the future; this one wouldn't get caught in any kind of find+replace.",Can we move this import to the
+6518,"@@ -86,7 +86,8 @@ func (c *Config) Start() {
+
+ 	for _, schedule := range c.Scheduler.Schedules {
+ 		helper.ControllerWg.Add(1)
+-		go schedule.ExecuteSchedule(c.ActionManager.Actions, c.Converter.DataRead, c.Device.ID)
++		newSchedule := schedule
++		go newSchedule.ExecuteSchedule(c.ActionManager.Actions, c.Converter.DataRead, c.Device.ID)
+ 	}
+ 	helper.ControllerWg.Wait()
+ }","Good catch, and if we don't declare the newSchedule here, will the last schedule be executed in multi goroutine?",Is this `newSchedule` variable
+6519,"@@ -879,6 +879,7 @@ partial class Build
+                 .Concat(includeSecurity)
+                 .Select(x => Solution.GetProject(x))
+                 .Where(project =>
++                project != null &&
+                 (project, project.TryGetTargetFrameworks()) switch
+                 {
+                     _ when exclude.Contains(project.Path) => false,","`project` should never be null here, unless we have projects that aren't in the solution? Which we shouldn't have  ",Why was this added?
+6520,"@@ -1,13 +1,18 @@
+ #include ""extractor/graph_compressor.hpp""
+
+ #include ""extractor/compressed_edge_container.hpp""
+-#include ""extractor/restriction_map.hpp""
++#include ""extractor/restriction.hpp""
++#include ""extractor/restriction_compressor.hpp""
++
+ #include ""util/dynamic_graph.hpp""
+ #include ""util/node_based_graph.hpp""
+ #include ""util/percent.hpp""
+
+ #include ""util/log.hpp""
+
++#include <boost/assert.hpp>
++#include <unordered_set>
++
+ namespace osrm
+ {
+ namespace extractor",Simple `for` loop instead of `for_each` would help here by making it more readable.,Is this really needed?
+6521,"@@ -96,6 +96,8 @@ namespace thread_role
+ 			case nano::thread_role::name::signature_checking:
+ 				thread_role_name_string = ""Signature check"";
+ 				break;
++			case nano::thread_role::name::confirmation_height_processing:
++				thread_role_name_string = ""Conf height"";
+ 		}
+
+ 		/*","Looks like this falls through, should break.",The word `Conf` feels
+6522,"@@ -73,6 +73,7 @@ class ManifestListWriter implements FileAppender<ManifestFile> {
+           .schema(ManifestFile.schema())
+           .named(""manifest_file"")
+           .meta(meta)
++          .overwrite(false)
+           .build();
+
+     } catch (IOException e) {",Let's default manifest lists and manifests to overwrite. These use UUID-based file names and should never conflict.,Can you elaborate why
+6523,"@@ -135,6 +135,9 @@ confspec = ConfigObj(StringIO(
+ 	audioCoordinates_maxPitch = integer(default=880)
+ 	reportMouseShapeChanges = boolean(default=false)
+
++[speechView]
++	showSpeechViewerAtStartup = boolean(default=false)
++
+ #Keyboard settings
+ [keyboard]
+ 	useCapsLockAsNVDAModifierKey = boolean(default=false)",Please rename [speechView] to [speechViewer].,`speechView` -> `speec
+6524,"@@ -20,6 +20,12 @@ type CpuUsage struct {
+ 	// Total CPU time consumed per core.
+ 	// Units: nanoseconds.
+ 	PercpuUsage []uint64 `json:""percpu_usage,omitempty""`
++	// CPU time consumed per core in kernel mode
++	// Units: nanoseconds.
++	PercpuUsageInKernelmode []uint64 `json:""percpu_usage_in_kernelmode""`
++	// CPU time consumed per core in user mode
++	// Units: nanoseconds.
++	PercpuUsageInUsermode []uint64 `json:""percpu_usage_in_usermode""`
+ 	// Time spent by tasks of the cgroup in kernel mode.
+ 	// Units: nanoseconds.
+ 	UsageInKernelmode uint64 `json:""usage_in_kernelmode""`","I would use shorter yet still descriptive names, e.g. `KernelPerCpu` and `UserPerCpu`.",Can we call them `percpu_usage_in_usermode` and `percpu_usage_in_usermode`?
+6525,"@@ -5017,7 +5017,7 @@ def print_record(recID, format='hb', ot='', ln=CFG_SITE_LANG, decompress=zlib.de
+         display_claim_this_paper = False
+
+     can_edit_record = False
+-    if check_user_can_edit_record(user_info, recID):
++    if  not (format.lower().startswith('t')) and check_user_can_edit_record(user_info, recID):
+         can_edit_record = True
+
+     out = """"","if we are seeking for the content of only one field from metadata, no need to check whether a user could edit record or not",Please remove the extra space after the `if`.
+6526,"@@ -25,3 +25,4 @@ class ChromeRemoteConnection(RemoteConnection):
+         self._commands[""launchApp""] = ('POST', '/session/$sessionId/chromium/launch_app')
+         self._commands[""setNetworkConditions""] = ('POST', '/session/$sessionId/chromium/network_conditions')
+         self._commands[""getNetworkConditions""] = ('GET', '/session/$sessionId/chromium/network_conditions')
++        self._commands['ExecuteCDP'] = ('POST', '/session/$sessionId/goog/cdp/execute')",Should this be camelCase to match the above commands? I am not the expert here so maybe Lucas or David can chime in.,How about moving this to `/session/cdp/commands`? That way we will not need
+6527,"@@ -254,7 +254,8 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+                 scope = tracer.StartActive(ValidateOperationName, serviceName: serviceName);
+                 var span = scope.Span;
+                 span.Type = SpanTypes.GraphQL;
+-
++                span.SetTag(Tags.SpanKind, SpanKinds.Server);
++                span.SetTag(Tags.Language, TracerConstants.Language);
+                 span.SetTag(Tags.GraphQLSource, source);
+
+                 // set analytics sample rate if enabled",This is also missing in CreateScopeFromExecuteAsync. Can you add that there too?,"I think we should set this at the start of `StartActive` span level, like i"
+6528,"@@ -30,9 +30,12 @@ public class DateUtils {
+         }
+         String date = input.trim().replace('/', '-').replaceAll(""( ){2,}+"", "" "");
+
++        // remove colon from timezone to avoid differences between Android and Java SimpleDateFormat
++        date = date.replaceAll(""([+-]\\d\\d):(\\d\\d)$"", ""$1$2"");
++
+         // CEST is widely used but not in the ""ISO 8601 Time zone"" list. Let's hack around.
+-        date = date.replaceAll(""CEST$"", ""+02:00"");
+-        date = date.replaceAll(""CET$"", ""+01:00"");
++        date = date.replaceAll(""CEST$"", ""+0200"");
++        date = date.replaceAll(""CET$"", ""+0100"");
+
+         // some generators use ""Sept"" for September
+         date = date.replaceAll(""\\bSept\\b"", ""Sep"");",I hope that this does not break anything... Probably needs detailed beta tests.,"Why not just use `date.replace(""[+-]\\d\\d:(\\d\\d)"", ""$1$2"");`"
+6529,"@@ -1518,6 +1518,17 @@ module RSpec::Core
+       end
+     end
+
++    describe 'recording spec start time (for measuring load)' do
++      it 'returns a time' do
++        expect(config.start_time).to be_an_instance_of ::Time
++      end
++
++      it 'is configurable' do
++        config.start_time = 42
++        expect(config.start_time).to eq 42
++      end
++    end
++
+     # assigns files_or_directories_to_run and triggers post-processing
+     # via `files_to_run`.
+     def assign_files_or_directories_to_run(*value)",@JonRowe in what scenario do you see this being manually set?,I think you should test that config.start_time is a `Time` inst
+6530,"@@ -307,6 +307,10 @@ void nano::block_processor::process_live (nano::block_hash const & hash_a, std::
+ 			election.election->try_generate_votes (block_a->hash ());
+ 		}
+ 	}
++	else
++	{
++		node.active.check_inactive_votes_cache_election (block_a);
++	}
+
+ 	// Announce block contents to the network
+ 	if (origin_a == nano::block_origin::local)","I think the work ""trigger"" makes more sense than ""check"" because this is taking an action based on status.",Wouldn't this be the same as `check_inactive_votes_cache_electi
+6531,"@@ -41,7 +41,7 @@ public class AuthHandlerBoot implements BootListener {
+       RSAKeypair4Auth.INSTANCE.setPrivateKey(rsaKeyPairEntry.getPrivateKey());
+       RSAKeypair4Auth.INSTANCE.setPublicKey(rsaKeyPairEntry.getPublicKey());
+       RSAKeypair4Auth.INSTANCE.setPublicKeyEncoded(rsaKeyPairEntry.getPublicKeyEncoded());
+-      RegistrationManager.INSTANCE.getMicroserviceInstance().getProperties().put(DefinitionConst.INSTANCE_PUBKEY_PRO,
++      RegistrationManager.INSTANCE.getMicroservice().getProperties().put(DefinitionConst.INSTANCE_PUBKEY_PRO,
+           rsaKeyPairEntry.getPublicKeyEncoded());
+     }
+   }","add a configuration , default put public key in Microservice, if the configuration is set, then put in Instance.","AFAIK, this change is not necessary."
+6532,"@@ -20,8 +20,8 @@ import com.google.common.collect.ImmutableList;
+ public interface OutputView {
+
+   public enum Kind {
+-    ASSIGNMENT,
+     COMMENT,
++    DEFINITION,
+     LOOP,
+     PRINT
+   }",WDYT about the idea above of making these all verbs that correspond to the input spec?,<!--new_thread; commit:5300be61ccac7a006ec7f2b8f3824cddb4dc75e8; resolved:0--> What is the reason for this change?
+6533,"@@ -77,7 +77,7 @@ import static com.fsck.k9.mail.K9MailLib.PUSH_WAKE_LOCK_TIMEOUT;
+  * </pre>
+  */
+ public class ImapStore extends RemoteStore {
+-    public static final String STORE_TYPE = ""IMAP"";
++    public static final ServerSettings.Type STORE_TYPE = ServerSettings.Type.IMAP;
+
+     private static final int IDLE_READ_TIMEOUT_INCREMENT = 5 * 60 * 1000;
+     private static final int IDLE_FAILURE_COUNT_LIMIT = 10;",With the introduction of the enum(s) the constants in the store classes should be removed.,Shouldn't this be `ServerSettings.Type.IMAP` instead?
+6534,"@@ -455,6 +455,12 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		}
+ 	}
+
++	// Drop packets with IP options
++	if (ip_header->ihl > 5) {
++		fwd.reason = CALI_REASON_IP_OPTIONS;
++		CALI_DEBUG(""Drop packets with IP options\n"");
++		goto deny;
++	}
+ 	// Setting all of these up-front to keep the verifier happy.
+ 	struct tcphdr *tcp_header = (void*)(ip_header+1);
+ 	struct udphdr *udp_header = (void*)(ip_header+1);",I would say `!= 5`; A packet with <5 would be malformed.,You probably want to use `CALI_WARN_IF_NOT_SUPPORTED` here.
+6535,"@@ -60,7 +60,7 @@ func New(selector export.AggregationSelector, exporter export.Exporter, opts ...
+ 		c.Timeout = c.Period
+ 	}
+
+-	integrator := simple.New(selector, c.Stateful)
++	integrator := simple.New(selector, exporter)
+ 	impl := sdk.NewAccumulator(
+ 		integrator,
+ 		sdk.WithResource(c.Resource),",I think you missed removing `Stateful` from `push/config.go`,Why does this need to change?
+6536,"@@ -29,7 +29,7 @@ namespace Nethermind.Db.Databases
+         {
+         }
+
+-        protected override void UpdateReadMetrics() => Metrics.EthRequestsDbReads++;
+-        protected override void UpdateWriteMetrics() => Metrics.EthRequestsDbWrites++;
++        protected internal override void UpdateReadMetrics() => Metrics.EthRequestsDbReads++;
++        protected internal override void UpdateWriteMetrics() => Metrics.EthRequestsDbWrites++;
+     }
+ }",why would you make it internal? if so then at least protected internal,"Can't these be override, right?"
+6537,"@@ -502,6 +502,18 @@ class TestHttps2Http(tservers.ReverseProxTest):
+ class TestTransparent(tservers.TransparentProxTest, CommonMixin, TcpMixin):
+     ssl = False
+
++    def test_tcp_stream_modify(self):
++        self.master.load_script(
++            tutils.test_data.path(""scripts/tcp_stream_modify.py""))
++
++        self._tcpproxy_on()
++        d = self.pathod('200:b""foo""')
++        self._tcpproxy_off()
++
++        assert d.content == ""bar""
++
++        self.master.unload_scripts()
++
+
+ class TestTransparentSSL(tservers.TransparentProxTest, CommonMixin, TcpMixin):
+     ssl = True","We should check if the response (`d`) contains bar as response, screw the log. :smile:",Is there a way to assert on the
+6538,"@@ -538,7 +538,7 @@ void GPUTreeLearner::AllocateGPUMemory() {
+   }
+   // data transfer time
+   std::chrono::duration<double, std::milli> end_time = std::chrono::steady_clock::now() - start_time;
+-  Log::Info(""%d dense feature groups (%.2f MB) transfered to GPU in %f secs. %d sparse feature groups"",
++  Log::Info(""%d dense feature groups (%.2f MB) transferred to GPU in %f secs. %d sparse feature groups"",
+             dense_feature_group_map_.size(), ((dense_feature_group_map_.size() + (dword_features_ - 1)) / dword_features_) * num_data_ * sizeof(Feature4) / (1024.0 * 1024.0),
+             end_time * 1e-3, sparse_feature_group_map_.size());
+   #if GPU_DEBUG >= 1",@Laurae2 good call. This is the only one I found (with `git grep transfered`),"This doesn't all have to be ""tr"
+6539,"@@ -1805,7 +1805,7 @@ class VariablesChecker(BaseChecker):
+         """"""
+         if (
+             node.frame().parent == defstmt
+-            and node.statement(future=True) not in node.frame().body
++            and node.statement(future=True) == node.frame()
+         ):
+             # Check if used as type annotation
+             # Break but don't emit message if postponed evaluation is enabled","I don't understand how this work, could you explain ?",This is the only functional cha
+6540,"@@ -183,7 +183,7 @@ analyze_callee_regs_usage(dcontext_t *dcontext, callee_info_t *ci)
+     /* XXX implement bitset for optimisation */
+     memset(ci->reg_used, 0, sizeof(bool) * NUM_GP_REGS);
+     ci->num_simd_used = 0;
+-    memset(ci->simd_used, 0, sizeof(bool) * NUM_SIMD_REGS);
++    memset(ci->simd_used, 0, sizeof(bool) * MCTX_NUM_SIMD_SLOTS);
+     ci->write_flags = false;
+
+     num_regparm = MIN(ci->num_args, NUM_REGPARM);","The abbreviation for ""context"" used extensively inside DR is ""cxt"", not ""ctx"", so s/MCTX/MCXT/.","MCTX_NUM_SIMD_SLOTS is defined as 8 bits, should it be MCTX_NUM_SIMD_REGS here?"
+6541,"@@ -13,5 +13,5 @@ return [
+     */
+
+     'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈ میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing again,Why was this line removed?
+6542,"@@ -40,6 +40,7 @@ public class WebSocketConfiguration {
+   private String authenticationCredentialsFile;
+   private List<String> hostsAllowlist = Arrays.asList(""localhost"", ""127.0.0.1"");
+   private File authenticationPublicKeyFile;
++  private String authenticationAlgorithm = null;
+   private long timeoutSec;
+   private int maxActiveConnections;
+ ",initializing to null makes me uncomfortable. let's have a default value,"Can you change this to ""algorithm""?"
+6543,"@@ -1129,6 +1129,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+                             }
+                             else if (ch == BytePercentage)
+                             {
++                                if (pathStart == -1)
++                                {
++                                    // Empty path is illegal
++                                    RejectRequestLine(start, end);
++                                }
++
+                                 needDecode = true;
+                             }
+ ",This is the `GET % HTTP/1.1` scenario right?,"If we have `pathStart = -1`, is that an error?"
+6544,"@@ -1,6 +1,7 @@
+ <?php namespace Backend\FormWidgets;
+
+ use App;
++use Backend\Facades\BackendAuth;
+ use File;
+ use Event;
+ use Lang;","No need to use the fully qualified path the BackendAuth facade, just `use BackendAuth` is fine.",This namespace should be `BackendAuth`
+6545,"@@ -357,6 +357,11 @@ bool nano::send_block::valid_predecessor (nano::block const & block_a) const
+ 	return result;
+ }
+
++nano::epoch nano::send_block::epoch () const
++{
++	return nano::epoch::epoch_0;
++}
++
+ nano::block_type nano::send_block::type () const
+ {
+ 	return nano::block_type::send;","Because it's similar for send/open/change/receive types, then probably it can be just common `nano::epoch nano::block::epoch () const` with override for state_block (like nano::block::link (), account (), representative ())",What is this magic number?
+6546,"@@ -1,5 +1,6 @@
+ // This is the API that JS files loaded from the webview can see
+ const webviewApiPromises_ = {};
++let cb_ = () => {};
+
+ // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
+ const webviewApi = {",Please give a more descriptive name and add a command to explain what it does.,Why not just do a `forEach` of the `we
+6547,"@@ -77,7 +77,8 @@ public class UserPreferences {
+     // Network
+     private static final String PREF_ENQUEUE_DOWNLOADED = ""prefEnqueueDownloaded"";
+     public static final String PREF_UPDATE_INTERVAL = ""prefAutoUpdateIntervall"";
+-    private static final String PREF_MOBILE_UPDATE = ""prefMobileUpdate"";
++    public static final String PREF_MOBILE_UPDATE_OLD = ""prefMobileUpdate"";
++    public static final String PREF_MOBILE_UPDATE = ""prefMobileUpdateAllowed"";
+     public static final String PREF_EPISODE_CLEANUP = ""prefEpisodeCleanup"";
+     public static final String PREF_PARALLEL_DOWNLOADS = ""prefParallelDownloads"";
+     public static final String PREF_EPISODE_CACHE_SIZE = ""prefEpisodeCacheSize"";",we can never get rid of this...,"What's the difference between ""prefMob"
+6548,"@@ -28,8 +28,9 @@ var (
+ 		[]string{""controller"", ""method"", ""resource"", ""remote"", ""status""},
+ 	)
+ 	metricKubeClientRequestSeconds = prometheus.NewHistogramVec(prometheus.HistogramOpts{
+-		Name: ""hive_kube_client_request_seconds"",
+-		Help: ""Length of time for kubernetes client requests."",
++		Name:    ""hive_kube_client_request_seconds"",
++		Help:    ""Length of time for kubernetes client requests."",
++		Buckets: []float64{0.05, 0.1, 0.5, 1, 5, 10, 30, 60, 120},
+ 	},
+ 		[]string{""controller"", ""method"", ""resource"", ""remote"", ""status""},
+ 	)",what is the effect of changing these buckets in existing data that is available in the monitoring system? if there are any existing dashboards that use previous histogram buckets they are probably going to be wrong ot invalid? also any reason why we chose these specific values?,Maybe we should rename this to `hive_kube_client_request_seconds` to be more specific?
+6549,"@@ -109,4 +109,13 @@
+ //
+ // 	var h handler
+ // 	yarpc.InjectClients(dispatcher, &h)
++//
++// Automatically Sanitizing TChannel Contexts
++//
++// Contexts created with `tchannel.ContextWithHeaders` are incompatible with yarpc clients generated from thrift.
++// Using such a context will cause a yarpc client to error on any call. Using the `sanitize-tchannel` flag will
++// generate a yarpc client such that all tchannel headers from any context supplied are removed before making a yarpc call.
++// the option can be used like so:
++//
++// 	thriftrw --plugin yarpc --sanitize-tchannel myservice.thrift
+ package thrift","This won't work. For the flag to be passed to the plugin, it should be passed as part of the --plugin argument. --plugin ""yarpc --sanitize-tchannel""",Should this be `tchannel.ContextWithHeaders`?
+6550,"@@ -2308,6 +2308,13 @@ int LGBM_BoosterSetLeafValue(BoosterHandle handle,
+   API_END();
+ }
+
++int LGBM_BoosterGetNumFeatures(BoosterHandle handle, int *out_val) {
++  API_BEGIN();
++  Booster* ref_booster = reinterpret_cast<Booster*>(handle);
++  *out_val = ref_booster->GetBoosting()->MaxFeatureIdx() + 1;
++  API_END();
++}
++
+ int LGBM_BoosterFeatureImportance(BoosterHandle handle,
+                                   int num_iteration,
+                                   int importance_type,","@shiyu1994 @StrikerRUS what do you think about this addition to `c_api.cpp`? I think it's a really useful addition to be able to get this type of information from the `Booster`, but I want more opinions since `c_api` is the main public API for the library.",Should the return type be `boost::nullopt` instead?
+6551,"@@ -213,6 +213,16 @@ type deferedCommit struct {
+ 	lookback basics.Round
+ }
+
++// RoundOffsetError is an error for when requested round is behind earliest stored db entry
++type RoundOffsetError struct {
++	Round   basics.Round
++	DbRound basics.Round
++}
++
++func (e *RoundOffsetError) Error() string {
++	return fmt.Sprintf(""round %d before dbRound %d"", e.Round, e.DbRound)
++}
++
+ // initialize initializes the accountUpdates structure
+ func (au *accountUpdates) initialize(cfg config.Local, dbPathPrefix string, genesisProto config.ConsensusParams, genesisAccounts map[basics.Address]basics.AccountData) {
+ 	au.initProto = genesisProto","rename Round -> requestedRound and DbRound -> dbRound. we don't need to export the fields here, only the error struct.","Can we just use `db.Round` here, rather than introducing a new type?"
+6552,"@@ -1052,6 +1052,18 @@ func TestClusterDeploymentReconcile(t *testing.T) {
+ 				}
+ 			},
+ 		},
++		{
++			name: ""Add cluster region label"",
++			existing: []runtime.Object{
++				testClusterDeploymentWithoutRegionLabel(),
++			},
++			validate: func(c client.Client, t *testing.T) {
++				cd := getCD(c)
++				if assert.NotNil(t, cd, ""missing clusterdeployment"") {
++					assert.Equal(t, getClusterRegion(cd), cd.Labels[hivev1.HiveClusterRegionLabel], ""incorrect cluster region label"")
++				}
++			},
++		},
+ 		{
+ 			name: ""Ensure cluster metadata set from provision"",
+ 			existing: []runtime.Object{","This expected value should probably be what you literally expect, otherwise there's a chance getClusterRegion is doing something wrong and the test wouldn't catch it because it's being run for both expected and actual.",Does it make sense to also validate that the region is actually `1`?
+6553,"@@ -27,6 +27,7 @@ package encryption
+ import (
+ 	""crypto/tls""
+ 	""crypto/x509""
++	""encoding/base64""
+ 	""errors""
+ 	""fmt""
+ 	""io/ioutil""",TODO: update unit tests to exercise base64-inline path,You probably didn't mean to add this import?
+6554,"@@ -551,6 +551,16 @@ public class UserPreferences {
+         restartUpdateAlarm(false);
+     }
+
++    public static boolean shouldShowOnboarding(String location) {
++        String key = ""onboarding_"" + location;
++        if (prefs.getBoolean(key, true)) {
++            prefs.edit().putBoolean(key, false).apply();
++            return true;
++        } else {
++            return false;
++        }
++    }
++
+     /**
+      * Change the auto-flattr settings
+      *",this method knows too much - it is kind of a strange side effect I'd prefer if we had separate method for acknowledging that the onboarding was done and should not be shown again,Maybe rename this to showOnboarding or showOnboardingOnboarding
+6555,"@@ -125,6 +125,7 @@ public class StorageCallbacksImpl implements StorageCallbacks {
+                     PodDBAdapter.KEY_CHAPTER_TYPE));
+         }
+         if(oldVersion <= 14) {
++
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_AUTO_DOWNLOAD + "" INTEGER"");
+             db.execSQL(""UPDATE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS","Do we need to increase the DB version? Also, should probably be a constant, no?",Can you remove the extra whitespace here?
+6556,"@@ -50,6 +50,11 @@ func NewWindow(every, period, offset values.Duration) (Window, error) {
+ 	return w, nil
+ }
+
++// IsZero checks if the window's every duration is zero
++func (w Window) IsZero() bool {
++	return w.every.IsZero()
++}
++
+ func (w Window) isValid() error {
+ 	if w.every.IsZero() {
+ 		return errors.New(codes.Invalid, ""duration used as an interval cannot be zero"")","We could utilize the new isZero method in this if-statement, right?",Is there a reason why we can't just do `w.every.IsZero()`?
+6557,"@@ -107,6 +107,14 @@ func (config testBlockOpsConfig) blockCache() BlockCache {
+ 	return config.cache
+ }
+
++func (config testBlockOpsConfig) MakeLogger(module string) logger.Logger {
++	return logger.NewNull()
++}
++
++func (config testBlockOpsConfig) DataVersion() DataVer {
++	return FilesWithHolesDataVer
++}
++
+ func makeTestBlockOpsConfig(t *testing.T) testBlockOpsConfig {
+ 	bserver := NewBlockServerMemory(logger.NewTestLogger(t))
+ 	codec := kbfscodec.NewMsgpack()","should probably have config have a `t` or a `logger.NewTestLogger(t)`, and return the latter",I don't see where this is being used.
+6558,"@@ -51,8 +51,10 @@ func (p *heuristicPlanner) Plan(inputPlan *PlanSpec) (*PlanSpec, error) {
+
+ 		visited := make(map[PlanNode]struct{})
+
+-		nodeStack := make([]PlanNode, len(inputPlan.Results()))
+-		copy(nodeStack, inputPlan.Results())
++		nodeStack := make([]PlanNode, 0, len(inputPlan.Roots))
++		for root := range inputPlan.Roots {
++			nodeStack = append(nodeStack, root)
++		}
+
+ 		anyChanged = false
+ 		for len(nodeStack) > 0 {","Does this not do the same thing as `copy`? I thought that `copy` just did an elementwise assignment, but maybe I was wrong.",This is not correct. You may have more than one roots and
+6559,"@@ -124,9 +124,9 @@ public abstract class FlatteningConfig {
+     // flattening.
+     Map<String, FlatteningConfig> flatteningConfigs = new LinkedHashMap<>();
+
+-    flatteningConfigs.putAll(flatteningConfigsFromGapicConfig);
+-    // Let flattenings from proto annotations override flattenings from GAPIC config.
++    // Let flattenings from GAPIC config override flattenings from proto annotations.
+     flatteningConfigs.putAll(flatteningConfigsFromProtoFile);
++    flatteningConfigs.putAll(flatteningConfigsFromGapicConfig);
+
+     return ImmutableList.copyOf(flatteningConfigs.values());
+   }","Here we are merging the configs from proto annotations and gapic config. But in other places in this PR we are using the new enum to pick one or the other, right? Or is that not the correct way to think about this?",why do we need this change?
+6560,"@@ -16,7 +16,7 @@ var opts = struct {
+ 	Usage     string
+ 	Verbosity cli.Verbosity `short:""v"" long:""verbosity"" default:""warning"" description:""Verbosity of output (higher number = more output)""`
+ 	CacheDir  string        `short:""d"" long:""dir"" default:"""" description:""The directory to store cached artifacts in.""`
+-	Port      int           `short:""p"" long:""port"" description:""The port to run the server on""`
++	Port      int           `short:""p"" long:""port"" description:""The port to run the server on"" default:""8080""`
+ }{
+ 	Usage: `
+ HTTP cache implements a resource based http server that please can use as a cache. The cache supports storing files",not related to this change?,This change should be reverted.
+6561,"@@ -51,9 +51,9 @@ if (options.arch) {
+
+ const buildType = options.buildType;
+
+-const ndkPath = process.env[""ANDROID_NDK""];
++const ndkPath = process.env[""ANDROID_NDK""] || process.env[""ANDROID_NDK_HOME""];
+ if (!ndkPath) {
+-  throw Error(""ANDROID_NDK environment variable not set"");
++  throw Error(""ANDROID_NDK / ANDROID_NDK_HOME environment variable not set"");
+ }
+
+ const sdkPath = getAndroidSdkPath();",Why is this needed?,"Perhaps this should be `""ANDROI"
+6562,"@@ -1353,7 +1353,7 @@ int64_t Creature::getStepDuration() const
+ 	int32_t stepSpeed = getStepSpeed();
+ 	if (stepSpeed > -Creature::speedB) {
+ 		calculatedStepSpeed = floor((Creature::speedA * log((stepSpeed / 2) + Creature::speedB) + Creature::speedC) + 0.5);
+-		if (calculatedStepSpeed <= 0) {
++		if (calculatedStepSpeed == 0) {
+ 			calculatedStepSpeed = 1;
+ 		}
+ 	} else {","This one could be replaced with a `std::max`, no?",Why not just `if (calculatedSte
+6563,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.,Use 2 (not 4) spaces for indent
+6564,"@@ -566,7 +566,11 @@ class Filter extends WidgetBase
+         /*
+          * Set scope value
+          */
+-        $scope->value = $this->getScopeValue($scope);
++        if($scopeType=='checkbox' || $scopeType=='switch'){
++            $scope->value = isset($config['value']) ? $config['value'] : $this->getScopeValue($scope);
++        } else{
++            $scope->value = $this->getScopeValue($scope);
++        }
+
+         return $scope;
+     }","Please use strict type comparisons (`===`), not loose type comparisons.","This looks wrong to me. If the value is not defined, it will be used instead of the anonymous scope value."
+6565,"@@ -73,6 +73,14 @@ public class FilterParameter {
+     return blockhash;
+   }
+
++  public boolean isValid() {
++    if (!getFromBlock().isLatest() && !getToBlock().isLatest() && getBlockhash() != null) {
++      return false;
++    }
++
++    return true;
++  }
++
+   @Override
+   public String toString() {
+     return MoreObjects.toStringHelper(this)","The filter parameters are a bit confusing. I understand that one of them has to be set, but what takes precedence if a from/to is set and the hash as well? Should that fail?",Shouldn't this be `getBlockhash() != null`?
+6566,"@@ -6,6 +6,9 @@
+
+ #include ""graph/context/Iterator.h""
+
++#include <cstdio>
++#include <tuple>
++
+ #include ""common/datatypes/Edge.h""
+ #include ""common/datatypes/Vertex.h""
+ #include ""graph/util/SchemaUtil.h""",Is that necessary?,What is the point of these two includes?
+6567,"@@ -72,7 +72,7 @@ describe Ncr::WorkOrder do
+
+   describe ""#ba_6x_tier1_team?"" do
+     it ""is true for whitelist of organizations"" do
+-      org_letters = %w( 7 J 4 T 1 A C Z )
++      org_letters = %w( 1 2 4 7 A C J T Z )
+       org_letters.each do |org_letter|
+         org_code = ""P11#{org_letter}XXXX""
+         ncr_org = build(:ncr_organization, code: org_code)",yess so much easier to read in order like this!,Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ].
+6568,"@@ -613,6 +613,7 @@ public abstract class LuceneTestCase extends Assert {
+     RuleChain r = RuleChain.outerRule(new TestRuleIgnoreTestSuites())
+       .around(ignoreAfterMaxFailures)
+       .around(suiteFailureMarker = new TestRuleMarkFailure())
++      .around(new VerifyTestClassNamingConvention())
+       .around(new TestRuleAssertionsRequired())
+       .around(new TestRuleLimitSysouts(suiteFailureMarker))
+       .around(tempFilesCleanupRule = new TestRuleTemporaryFilesCleanup(suiteFailureMarker));",question: would this convention automatically and always apply to all classes derived from `LuceneTestCase` including any non-`org.apache` name spaces or would it be possible to opt-out (without an exclusion list) somehow for custom code that might perhaps have chosen a different convention?,"For consistency with the rest of the `TestRule...` methods, this should be `new TestRuleVerifyTestClassNamingConvention()`"
+6569,"@@ -57,7 +57,7 @@ public class PasscodeManager  {
+ 	private static final String EPREFIX = ""eprefix"";
+
+     // Default min passcode length
+-    protected static final int MIN_PASSCODE_LENGTH = 6;
++    protected static final int MIN_PASSCODE_LENGTH = 4;
+
+     // Key in preference for the passcode
+     private static final String KEY_PASSCODE =""passcode"";","Also found this bug, where we were setting the min passcode length to 6, but the min length for a connected app is 4. This can cause problems when the app is force closed or the shared pref is removed.",Is there any reason to change the default value?
+6570,"@@ -175,7 +175,7 @@ class FastTemporalMemory(TemporalMemory):
+     """"""
+     self._validateCell(cell)
+
+-    return int(cell.idx / self.cellsPerColumn)
++    return int(cell / self.cellsPerColumn)
+
+
+   def cellsForColumn(self, column):",Why was this change necessary?,"This is a bug fix. If `idx` is not a valid index, then `int()` will fail."
+6571,"@@ -55,7 +55,7 @@ import java.util.logging.Logger;
+
+ class Host {
+
+-  private static final Logger LOG = Logger.getLogger(""Selenium Distributor"");
++  private static final Logger LOG = Logger.getLogger(""Selenium Host"");
+   private final Node node;
+   private final UUID nodeId;
+   private final URI uri;","I kind of did this deliberately, so everything from the distributor appears in the same set of logs.","The name of the logger should be ""Selenium Host""."
+6572,"@@ -300,6 +300,7 @@ class TCPSession(IPSession):
+                 return pkt
+             metadata[""pay_class""] = pay_class
+             metadata[""tcp_reassemble""] = tcp_reassemble
++            metadata[""seq""] = pkt[TCP].seq
+         else:
+             tcp_reassemble = metadata[""tcp_reassemble""]
+         # Get a relative sequence number for a storage purpose",We already have a `seq = pkt[TCP].seq` so you can just re-use it.,Why does this need to be added here? Doesn't the calling code do this?
+6573,"@@ -22,11 +22,8 @@ package org.apache.iceberg.data.parquet;
+ import com.google.common.collect.ImmutableList;
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;
+-import java.time.Instant;
+-import java.time.LocalDate;
+-import java.time.LocalDateTime;
+-import java.time.OffsetDateTime;
+-import java.time.ZoneOffset;
++
++import java.time.*;
+ import java.time.temporal.ChronoUnit;
+ import java.util.Iterator;
+ import java.util.List;","We avoid wildcard imports because it isn't clear where symbols are coming from and there is potential for collision. Could you roll back this change? (As well as the additional newline, we don't use breaks in imports either.)",Don't use wildcard import.
+6574,"@@ -533,11 +533,11 @@ TEST_F(TCPv4Tests, send_and_receive_between_secure_ports_client_verifies)
+                                     (std::chrono::steady_clock::now() + std::chrono::microseconds(100)));
+                     while (!sent)
+                     {
+-                        Locators input_begin(locator_list.begin());
+-                        Locators input_end(locator_list.end());
++                        Locators l_input_begin(locator_list.begin());
++                        Locators l_input_end(locator_list.end());
+
+                         sent =
+-                                send_resource_list.at(0)->send(message, 5, &input_begin, &input_end,
++                                send_resource_list.at(0)->send(message, 5, &l_input_begin, &l_input_end,
+                                         (std::chrono::steady_clock::now() + std::chrono::microseconds(100)));
+                         std::this_thread::sleep_for(std::chrono::milliseconds(100));
+                     }",Why are these variables renamed? Is there a conflict with some Windows specific variable?,Could you please fix the spelling of the variable names? `l_input_begi
+6575,"@@ -18,6 +18,8 @@
+
+ require_once(""../inc/util.inc"");
+ require_once(""../inc/xml.inc"");
++if(file_exists('../../release.inc'))
++    include '../../release.inc';
+
+ BoincDb::get(true);
+ xml_header();",Do you test for file existence simply to reduce the warning message that may occur using the include? Also - I think the practice used in BOINC is to go ahead and use include_once even though it isn't strictly necessary in this case.,"This check is too early, if release.inc doesn't exist, it will throw a"
+6576,"@@ -20,6 +20,8 @@ import (
+ )
+
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ // +chaos-mesh:experiment
+
+ // TimeChaos is the Schema for the timechaos API",`TimeChaos` does not contains a field .spec.action,Why is this needed? Does not seem to be used in this PR.
+6577,"@@ -1,9 +1,10 @@
+ package net.runelite.rs.api;
+
++import net.runelite.api.AbstractArchive;
+ import net.runelite.api.IndexDataBase;
+ import net.runelite.mapping.Import;
+
+-public interface RSAbstractArchive extends IndexDataBase
++public interface RSAbstractArchive extends IndexDataBase, AbstractArchive
+ {
+ 	@Import(""takeFile"")
+ 	byte[] getConfigData(int archiveId, int fileId);",You need to override where possible in rs-api,why not add a default implementation to `AbstractArchive
+6578,"@@ -25,5 +25,12 @@ namespace Reporting
+         public string BuildName { get; set; }
+
+         public DateTime TimeStamp { get; set; }
++
++        public Dictionary<string, string> AdditionalData { get; set; } = new Dictionary<string, string>();
++
++        public void AddData(string key, string payload)
++        {
++            AdditionalData.Add(key, payload);
++        }
+     }
+ }",Should this have an add/update/etc pattern? What happens if I need to change some set of data? May be better to just let the callsite manipulate the dictionary.,Does this need to be public?
+6579,"@@ -177,6 +177,18 @@ class PyRegion(object):
+     name: the name of the output
+     """"""
+
++  @not_implemented
++  def getAlgorithmInstance(self):
++    """"""
++    Returns the instance of the underlying algorithm that is performing
++    the computation.
++
++    This method should be overridden by the region subclass.
++
++    Note that the return type depends on the Region and therefore
++    cannot be determined in advance.
++    """"""
++
+   def getParameter(self, name, index):
+     """"""Default implementation that return an attribute with the requested name
+ ","I don't think this should be added to PyRegion. Adding it here requires that every region have an ""algorithm"" which may not always make sense and the return value type will be different in every case. But fine to use the same name in the regions where we choose to implement it as a convention if that makes the API more discoverable.","How about: ""Returns the instance of the underlying algor"
+6580,"@@ -421,6 +421,12 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyht
+ 			return nil
+ 		}
+
++		// detect connection timeout to the upstream and respond with 504
++		switch e, ok := proxyErr.(net.Error); ok {
++		case e.Timeout():
++			return caddyhttp.Error(http.StatusGatewayTimeout, proxyErr)
++		}
++
+ 		// if the roundtrip was successful, don't retry the request or
+ 		// ding the health status of the upstream (an error can still
+ 		// occur after the roundtrip if, for example, a response handler",Returning here bypasses all the health check and load balancing features.,proxyErr could be nil here
+6581,"@@ -1,4 +1,4 @@
+-// Copyright (c) 2020 Tigera, Inc. All rights reserved.
++// Copyright (c) 2020-2021 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");
+ // you may not use this file except in compliance with the License.","Should revert this copyright change, when the file isn't changing in any other way.",not sure if this is correc
+6582,"@@ -90,8 +90,10 @@ func WriteFile(fromFile io.Reader, to string, mode os.FileMode) error {
+ 		return err
+ 	}
+ 	dir, file := path.Split(to)
+-	if err := os.MkdirAll(dir, DirPermissions); err != nil {
+-		return err
++	if dir != """" {
++		if err := os.MkdirAll(dir, DirPermissions); err != nil {
++			return err
++		}
+ 	}
+ 	tempFile, err := ioutil.TempFile(dir, file)
+ 	if err != nil {","Interesting that filepath.Dir(""thing"") returns ""."" whereas this returns """"","`if dir == """" {` would be "
+6583,"@@ -364,11 +364,11 @@ class Series(_Frame):
+         ...                    's2': [.3, .6, .0, .1]})
+         >>> s1 = df.s1
+         >>> s2 = df.s2
+-        >>> s1.corr(s2, method='pearson')
+-        -0.8510644963469898
++        >>> s1.corr(s2, method='pearson')  # doctest: +ELLIPSIS
++        -0.851064...
+
+-        >>> s1.corr(s2, method='spearman')
+-        -0.9486832980505125
++        >>> s1.corr(s2, method='spearman')  # doctest: +ELLIPSIS
++        -0.948683...
+
+         Notes
+         -----","Nice, I did not know about that",Should we revert this chan
+6584,"@@ -2521,4 +2521,19 @@ namespace hip_impl {
+             std::terminate();
+         #endif
+     }
++
++    std::mutex executables_cache_mutex;
++
++    void executables_cache(
++            std::string elf, hsa_isa_t isa, hsa_agent_t agent,
++            std::vector<hsa_executable_t>& exes, bool write) {
++        static std::unordered_map<std::string,
++            std::unordered_map<hsa_isa_t,
++                std::unordered_map<hsa_agent_t, std::vector<hsa_executable_t>>>> cache;
++        if (write) {
++            cache[elf][isa][agent] = exes;
++        } else {
++            exes = cache[elf][isa][agent];
++        }
++    }
+ } // Namespace hip_impl.","Since the lock is have moved outside of this function, I think it would be simpler and efficient to just return a ref to the std::vector<hsa_executable_t>? That way, we don't need to make a new copy on read and we won't actually need a write operation.","Curious, why does `std::unordered_map<hsa_isa_t, std::vector<hsa_executable_t>>` not work?"
+6585,"@@ -448,12 +448,15 @@ func (api *Server) ReadState(ctx context.Context, in *iotexapi.ReadStateRequest)
+ 	if !ok {
+ 		return nil, status.Errorf(codes.Internal, ""protocol %s isn't registered"", string(in.ProtocolID))
+ 	}
+-	data, err := api.readState(ctx, p, in.GetHeight(), in.MethodName, in.Arguments...)
++	data, readStateHeight, err := api.readState(ctx, p, in.GetHeight(), in.MethodName, in.Arguments...)
+ 	if err != nil {
+ 		return nil, status.Error(codes.NotFound, err.Error())
+ 	}
+ 	out := iotexapi.ReadStateResponse{
+ 		Data: data,
++		BlockIdentifier: &iotextypes.BlockIdentifier{
++			Height: readStateHeight,
++		},
+ 	}
+ 	return &out, nil
+ }",also fetch block hash of this height and return hash,Why not just the height?
+6586,"@@ -75,6 +75,9 @@ namespace Samples.HttpMessageHandler
+
+         private static async Task SendHttpClientRequestAsync(bool tracingDisabled)
+         {
++            // Insert a call to the Tracer.Instance to include an AssemblyRef to Datadog.Trace assembly in the final executable
++            var ins = Tracer.Instance;
++
+             Console.WriteLine($""[HttpClient] sending request to {Url}"");
+             var clientRequestContent = new StringContent(RequestContent, Utf8);
+ ",Why do we need this in this sample app and not the others?,Do we need `using` for this?
+6587,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+
+   @Override",We don't need this additional method.,`name` could be null I think
+6588,"@@ -97,6 +97,6 @@ class CreateUserCommand extends Command
+             $output->writeln(sprintf('<error>Can\'t find role %s</error>', $role));
+         }
+
+-        return 1;
++        return 0;
+     }
+ }",Shouldn't this return code conditionally? The above line seems like an error occurred.,"this was intentional, because 0 is the default return code."
+6589,"@@ -24,6 +24,12 @@ import (
+ 	""k8s.io/apimachinery/pkg/types""
+ )
+
++// SupportedDiskType is a map containing the valid disk type
++var SupportedDiskType = map[string]bool{
++	string(apis.TypeSparseCPV): true,
++	string(apis.TypeDiskCPV):   true,
++}
++
+ // SPC encapsulates StoragePoolClaim api object.
+ type SPC struct {
+ 	// actual spc object",What is the need to use string as key? Can we use the apis type as the key?,why not just a `map[string]bool`?
+6590,"@@ -867,6 +867,7 @@ class Uppy {
+
+   info (message, type, duration) {
+     const isComplexMessage = typeof message === 'object'
++    duration = typeof duration === 'undefined' ? 3000 : duration
+
+     this.setState({
+       info: {",how about a default parameter instead?,"If `duration` is undefined, then the info is undefined. Wha"
+6591,"@@ -624,11 +624,11 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ }
+
+ func (r *ReconcileClusterDeployment) reconcileInstallingClusterProvision(cd *hivev1.ClusterDeployment, releaseImage string, logger log.FieldLogger) (reconcile.Result, error) {
+-	// Return early and stop processing if Agent install strategy is in play. The controllers that
++	// Return early and stop processing if ClusterInstallRef is in play. The controllers that
+ 	// handle this portion of the API currently live in the assisted service repo, rather than hive.
+ 	// This will hopefully change in the future.
+-	if cd.Spec.Provisioning != nil && cd.Spec.Provisioning.InstallStrategy != nil && cd.Spec.Provisioning.InstallStrategy.Agent != nil {
+-		logger.Info(""skipping processing of agent install strategy cluster"")
++	if cd.Spec.ClusterInstallRef != nil {
++		logger.Info(""ClusterInstallRef specified, skipping creation of ClusterProvision"")
+ 		return reconcile.Result{}, nil
+ 	}
+ ","i don't think we need to add duplicate check for clusterinstallref here, the function already assumes that it was invoked for clusterprovision",Can we rename this to `ClusterProvision`?
+6592,"@@ -159,7 +159,10 @@ class HybridTaskCascadeRoIHead(CascadeRoIHead):
+         bbox_head = self.bbox_head[stage]
+         bbox_feats = bbox_roi_extractor(
+             x[:len(bbox_roi_extractor.featmap_strides)], rois)
+-        if self.with_semantic and 'bbox' in self.semantic_fusion:
++
++        # bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.
++        if self.with_semantic and 'bbox' in self.semantic_fusion and \
++                bbox_feats.shape[0] > 0:
+             bbox_semantic_feat = self.semantic_roi_extractor([semantic_feat],
+                                                              rois)
+             if bbox_semantic_feat.shape[-2:] != bbox_feats.shape[-2:]:",\`bbox_feats.shape[0] > 0\` requires the number of proposal is not 0.,instead of using \ you could write as `if self.with_semantic and bbox_feats.shape[0] > 0:`
+6593,"@@ -202,9 +202,8 @@ public class RewriteManifestsAction
+         .createDataset(Lists.transform(manifests, ManifestFile::path), Encoders.STRING())
+         .toDF(""manifest"");
+
+-    String entriesMetadataTable = metadataTableName(MetadataTableType.ENTRIES);
+-    Dataset<Row> manifestEntryDF = spark.read().format(""iceberg"")
+-        .load(entriesMetadataTable)
++    Dataset<Row> manifestEntryDF = BaseSparkAction.loadMetadataTable(spark, table.name(), table().location(),
++        MetadataTableType.ENTRIES)
+         .filter(""status < 2"") // select only live entries
+         .selectExpr(""input_file_name() as manifest"", ""snapshot_id"", ""sequence_number"", ""data_file"");
+ ",Same here. Any way to fit on one line?,"`spark.read().format(""iceberg"")` -> `spark.read().location()`"
+6594,"@@ -170,6 +170,9 @@ bool TestShard::commitLogs(std::unique_ptr<LogIterator> iter) {
+                     data_.emplace_back(currLogId_, log.toString());
+                     VLOG(1) << idStr_ << ""Write: "" << log << "", LogId: "" << currLogId_
+                             << "" state machine log size: "" << data_.size();
++                    if (log.startsWith(""set "")) {
++                        singleRegister_ = std::stoi(log.subpiece(4).toString());
++                    }
+                     break;
+                 }
+             }",using folly::to is better ?,Is this guaranteed to be at least 4 bytes long? Is it guaranteed to be at least 4 bytes lo
+6595,"@@ -376,7 +376,6 @@ def _init_profiles():
+         private_profile.setter = ProfileSetter(  # type: ignore[attr-defined]
+             private_profile)
+         assert private_profile.isOffTheRecord()
+-        private_profile.setter.init_profile()
+
+
+ def _init_site_specific_quirks():",I'm guessing this is unintended?,`private_profile.setter.init_profile()` is called here instead of directly in the `set_pro
+6596,"@@ -284,11 +284,13 @@ class ChangeStreamCursor extends Cursor {
+       if (this.options[optionName]) result[optionName] = this.options[optionName];
+     }
+
++    const resumeKey = this.options.startAfter && !this.hasReceived ? 'startAfter' : 'resumeAfter';
++
+     if (this.resumeToken || this.startAtOperationTime) {
+       ['resumeAfter', 'startAfter', 'startAtOperationTime'].forEach(key => delete result[key]);
+
+       if (this.resumeToken) {
+-        result.resumeAfter = this.resumeToken;
++        result[resumeKey] = this.resumeToken;
+       } else if (this.startAtOperationTime && maxWireVersion(this.server) >= 7) {
+         result.startAtOperationTime = this.startAtOperationTime;
+       }","This looks a little suspicious to me, can you explain what's going on here?",Why do we need `!this.hasReceived` here? Is it always true?
+6597,"@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base
+   private
+
+   def current_user
+-    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    @current_user ||= find_current_user
++  end
++
++  def find_current_user
++    if ENV['FORCE_USER_ID']
++      User.find ENV['FORCE_USER_ID']
++    else
++      User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    end
+   end
+
+   def sign_in(user)",Can you talk about this? I'm not sure I follow why this is necessary.,Style/GuardClause: Use a guard clause instead of wrapping t
+6598,"@@ -136,6 +136,8 @@ class AbstractBase extends AbstractActionController
+             ->fromPost('layout', $this->params()->fromQuery('layout', false));
+         if ('lightbox' === $layout) {
+             $this->layout()->setTemplate('layout/lightbox');
++        }elseif(isset($params['layout']) && $params['layout']=='simple'){
++             $this->layout()->setTemplate('layout/simple');
+         }
+         return new ViewModel($params);
+     }","Is there really a need for this 'simple' layout? Is there a reason you can't use 'lightbox'? The only difference seems to be that the lightbox layout includes Piwik/Google Analytics tracking and simple does not. If tracking needs to be disabled for some reason, perhaps there is a way to do that without creating a whole new layout.",Can you please change this to `if (is_string($params['layou
+6599,"@@ -526,6 +526,19 @@ public abstract class MergePolicy {
+   public abstract MergeSpecification findForcedDeletesMerges(
+       SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException;
+
++  /**
++   * Identifies merges that we want to execute (synchronously) on commit. By default, do not synchronously merge on commit.
++   *
++   * If a returned {@link OneMerge} includes a segment already included in a registered merge, then the commit will fail.
++   * Use {@link MergeContext#getMergingSegments()} to determine which segments are currently registered to merge.
++   *
++   * @param segmentInfos the total set of segments in the index (while preparing the commit)
++   * @param mergeContext the IndexWriter to find the merges on
++   */
++  public MergeSpecification findCommitMerges(SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException {
++    return null;
++  }
++
+   /**
+    * Returns true if a new segment (regardless of its origin) should use the
+    * compound file format. The default implementation returns <code>true</code>","Can you say what exception will be thrown in that case (or add an `@throws`, below)?",shouldn't this be part of the public API?
+6600,"@@ -5,9 +5,9 @@ import sys
+ # Simple python version test
+ major,minor = sys.version_info[:2]
+ py_version = sys.version.split()[0]
+-if major != 2 or minor < 5:
++if major != 2 or minor < 6:
+   # SystemExit defaults to returning 1 when printing a string to stderr
+-  raise SystemExit(""You are using python %s, but version 2.5 or greater is required"" % py_version)
++  raise SystemExit(""You are using python %s, but version 2.7 or greater is required"" % py_version)
+
+ required = 0
+ optional = 0","Is this meant to be ""2.7"" or ""2.6"". The two lines in this commit don't agree with one another. Looks like everything else in this PR is ""2.6"" and that seems sensible.","Instead of changing this, could you modify `setup_py_version()` to return `sys.version_info[:2]`? Then you can use it in the error message as well."
+6601,"@@ -21,8 +21,8 @@
+ # ----------------------------------------------------------------------
+ import unittest
+
+-from nupic.data.pattern_machine import (PatternMachine,
+-                                        ConsecutivePatternMachine)
++from nupic.data.generators.pattern_machine import (PatternMachine,
++                                                   ConsecutivePatternMachine)
+
+
+ ",Should we put these tests in a `generators` directory?,Is it possible to keep the original formatting so that we don't have to change lines unnecessarily?
+6602,"@@ -356,8 +356,8 @@ struct greater_equal_op {
+ struct and_op {
+   inline DataType operator()(const DataType& x1,
+                              const DataType& x2) const {
+-    const bool b1 = x1 != zero && !std::isnan(x1);
+-    const bool b2 = x2 != zero && !std::isnan(x2);
++    const auto& b1 = x1 >= DataType(0.5);
++    const auto& b2 = x2 >= DataType(0.5);
+     return (b1 && b2) ? one : zero;
+   }
+   inline void operator()(const DataType& x1,",I think that it makes more sense to keep these with the standard definition of non-zero is true and zero is false.,Why is the condition of `b1 && b2` changed? Is it equivalent?
+6603,"@@ -34,9 +34,9 @@ class DummyRequest(mock.MagicMock):
+         self.authn_type = 'basicauth'
+         self.prefixed_userid = 'basicauth:bob'
+         self.effective_principals = [
+-            self.prefixed_userid,
+             'system.Everyone',
+-            'system.Authenticated']
++            'system.Authenticated',
++            'bob']
+         self.json = {}
+         self.validated = {}
+         self.matchdict = {}",Any idea why you want to change the behavior here? Is there a security risk not to have the prefix in the principal here.,Why did you remove `self.prefixed_userid`?
+6604,"@@ -47,6 +47,7 @@ type ConfigMock struct {
+ 	mockMdcache    *MockMDCache
+ 	mockKcache     *MockKeyCache
+ 	mockBcache     *MockBlockCache
++	mockDBcache    *MockDirtyBlockCache
+ 	mockCrypto     *MockCrypto
+ 	mockCodec      *MockCodec
+ 	mockMdops      *MockMDOps","this reads like ""mock database cache"", maybe a clearer name",Why do we need to mock the DBcache? Shouldn't it mock the block cache?
+6605,"@@ -26,6 +26,8 @@ import (
+ 	""net/http""
+ 	""time""
+
++	""github.com/jetstack/cert-manager/pkg/webhook/server/util""
++
+ 	logf ""github.com/jetstack/cert-manager/pkg/logs""
+
+ 	""github.com/go-logr/logr""",Nit: move this with the other CM imports.,Can we move this import to the top of the file?
+6606,"@@ -2,9 +2,10 @@
+
+ namespace Shopsys\ShopBundle\Controller\Front;
+
++use League\Flysystem\FilesystemInterface;
+ use Shopsys\FrameworkBundle\Component\Image\Config\ImageConfig;
+ use Shopsys\FrameworkBundle\Component\Image\Processing\ImageGeneratorFacade;
+-use Symfony\Component\HttpFoundation\BinaryFileResponse;
++use Symfony\Component\HttpFoundation\StreamedResponse;
+
+ class ImageController extends FrontBaseController
+ {",This change should be mentioned in the CM,Are you sure that `StreamedResponse` is the right type here? It's not
+6607,"@@ -23,6 +23,13 @@ namespace Datadog.Trace
+             HttpHeaderNames.DatadogTags,
+         };
+
++        /// <summary>
++        /// An <see cref=""ISpanContext""/> with default values. Can be used as the value for
++        /// <see cref=""SpanCreationSettings.Parent""/> in <see cref=""Tracer.StartActive(string, SpanCreationSettings)""/>
++        /// to specify that the new span should not inherit the currently active scope as its parent.
++        /// </summary>
++        public static readonly ISpanContext Empty = new ReadOnlySpanContext(traceId: 0, spanId: 0, serviceName: null);
++
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""SpanContext""/> class
+         /// from a propagated context. <see cref=""Parent""/> will be null","Do we really want a new type, or can we just use `SpanContext`? The `ISpanContext` interface is read-only, but there's nothing stopping users from casting this to `SpanContext` and modifying it.",Any reason why this isn't just `SpanCreationSettings.Default`?
+6608,"@@ -13,7 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
+-#if NET461
++#if NET452 || NET461
+ using System;
+ using System.Collections;
+ using System.Collections.Generic;",Should we define a const like NETFRAMEWORK or NETFULL which will be set for NET452 NET461 and anything like NET47 etc in future?,Unrelated changes in this file?
+6609,"@@ -36,6 +36,12 @@ const PoStProofLength = 192
+ // https://github.com/filecoin-project/go-filecoin/issues/966
+ var ProvingPeriodBlocks = types.NewBlockHeight(20000)
+
++// GracePeriodBlocks is the number of blocks after a proving period over
++// which a miner can still submit a post at a penalty.
++// TODO: what is a secure value for this?  Value is arbitrary right now.
++// See https://github.com/filecoin-project/go-filecoin/issues/1887
++var GracePeriodBlocks = types.NewBlockHeight(100)
++
+ const (
+ 	// ErrPublicKeyTooBig indicates an invalid public key.
+ 	ErrPublicKeyTooBig = 33",maybe start an issue to capture params that we need final values for and link to it here?,"Why is this a constant? Also, w"
+6610,"@@ -288,6 +288,8 @@ class _RunData(object):
+         alternate_services = set()
+         direct_access_sources = set()
+         for backend in backend_service.backends:
++            if not backend.get('group'):
++                continue
+             instance_group = self.find_instance_group_by_url(
+                 backend.get('group'))
+             if not instance_group:","Can we instead do the check in find_instance_group_by_url() ? if we return None when group is not found, it will hit the next if statement (if not instance_group) and continue as expected, in this case we don't need to add 3 separate if statements",What happens if the backend doe
+6611,"@@ -85,15 +85,15 @@ public class DateUtil {
+     }
+
+     public static int toSeconds(String hh_colon_mm) {
+-        Pattern p = Pattern.compile(""(\\d+):(\\d+)( a.m.| p.m.|)"");
++        Pattern p = Pattern.compile(""(\\d+):(\\d+)( a.m.| p.m.| AM | PM)"");
+         Matcher m = p.matcher(hh_colon_mm);
+         int retval = 0;
+
+         if (m.find()) {
+             retval = SafeParse.stringToInt(m.group(1)) * 60 * 60 + SafeParse.stringToInt(m.group(2)) * 60;
+-            if (m.group(3).equals("" .a.m"") && m.group(1).equals(""12""))
++            if (m.group(3).equals("" AM"") && m.group(1).equals(""12""))
+                 retval -= 12 * 60 * 60;
+-            if (m.group(3).equals("" p.m."") && !m.group(1).equals(""12""))
++            if (m.group(3).equals("" PM"") && !(m.group(1).equals(""12"")))
+                 retval += 12 * 60 * 60;
+         }
+         return retval;","on my android "".a.m"" and "".p.m"" is used add `||` here to support both variants",I don't think the `.a.m` is nee
+6612,"@@ -4647,7 +4647,7 @@ bool CoreChecks::PreCallValidateCreateImageView(VkDevice device, const VkImageVi
+                     skip |= LogError(pCreateInfo->image, ""VUID-VkImageViewCreateInfo-image-01586"", ""%s"", ss.str().c_str());
+                 }
+             } else {
+-                if ((!(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR)) || (!FormatIsMultiplane(image_format))) {
++                if (!(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR)) {
+                     // Format MUST be compatible (in the same format compatibility class) as the format the image was created with
+                     if (FormatCompatibilityClass(image_format) != FormatCompatibilityClass(view_format)) {
+                         const char *error_vuid;",`!FormatIsMultiplane(image_format)` will always be true at this point due to the test on line 4639.,FormatIsMultiplane() is no longer used in this function.
+6613,"@@ -24,6 +24,7 @@ from typing import Any, Optional, List, Union
+
+ import numpy as np
+ import pandas as pd
++from pandas.core.accessor import CachedAccessor
+
+ from pyspark import sql as spark
+ from pyspark.sql import functions as F","Maybe inline the CachedAccessor code? Is it similar to our lazy property? If yes, can we reconcile the two?",Could you add this line to the `setup.py` as well?
+6614,"@@ -34,7 +34,7 @@ func (c SmokeTestCase) BuildInputShape(ref *ShapeRef) string {
+ 	)
+ }
+
+-// AttachSmokeTests attaches the smoke test cases to the API model.
++	// AttachSmokeTests attaches the smoke test cases to the API model.
+ func (a *API) AttachSmokeTests(filename string) {
+ 	f, err := os.Open(filename)
+ 	if err != nil {",Nit this file has unintended changes.,This should probably be capitalized
+6615,"@@ -101,6 +101,8 @@ public class FeedItemMenuHandler {
+             mi.setItemVisibility(R.id.share_download_url_with_position_item, false);
+         }
+
++        mi.setItemVisibility(R.id.share_file, selectedItem.getMedia().fileExists());
++
+         if (selectedItem.isPlayed()) {
+             mi.setItemVisibility(R.id.mark_read_item, false);
+         } else {",Potential NPE? `hasMedia && selectedItem...`,Shouldn't this be set only when the item is played too?
+6616,"@@ -1662,7 +1662,7 @@ class EC2Connection(AWSQueryConnection):
+             params['AutoEnableIO.Value'] = new_value
+         return self.get_status('ModifyVolumeAttribute', params, verb='POST')
+
+-    def create_volume(self, size, zone, snapshot=None,
++    def create_volume(self, size, zone = None, snapshot=None,
+                       volume_type=None, iops=None):
+         """"""
+         Create a new EBS Volume.",PEP-8/consistency with the rest of the code.,is there a unit test for this?
+6617,"@@ -0,0 +1,15 @@
++using Datadog.Trace.ClrProfiler.Integrations;
++
++namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.MongoDb
++{
++    internal abstract class MongoDbInstrumentMethodAttribute : InstrumentMethodAttribute
++    {
++        protected MongoDbInstrumentMethodAttribute(string typeName)
++        {
++            AssemblyName = MongoDbIntegration.MongoDbClientAssembly;
++            TypeName = typeName;
++            IntegrationName = MongoDbIntegration.IntegrationName;
++            ParameterTypeNames = new[] { ""MongoDB.Driver.Core.Connections.IConnection"", ClrNames.CancellationToken };
++        }
++    }
++}",nit: Would you mind moving the `ParameterTypeNames` assignment into each of the method-specific attributes? That could reduce confusion if we later decided to instrument other methods in MongoDb,I'm wondering if we should ren
+6618,"@@ -0,0 +1,16 @@
++using System.Collections.Generic;
++using Nethermind.Blockchain.Find;
++using Nethermind.Core;
++using Nethermind.Core.Specs;
++using Nethermind.Int256;
++
++namespace Nethermind.JsonRpc.Modules.Eth
++{
++    public interface IGasPriceOracle
++    {
++        public ISpecProvider SpecProvider { get; }
++        public UInt256? FallbackGasPrice { get; }
++        public List<UInt256> TxGasPriceList { get; }
++        ResultWrapper<UInt256?> GasPriceEstimate(Block? headBlock, IBlockFinder blockFinder);
++    }
++}",Is exposing SpecProvider needed here?,Why do we need this interface?
+6619,"@@ -141,6 +141,18 @@ namespace MvvmCross.ViewModels
+             }
+         }
+
++        [NotifyPropertyChangedInvocator]
++        protected virtual bool SetProperty<T>(ref T storage, T value, Action afterAction, [CallerMemberName] string propertyName = null)
++        {
++            if (!SetProperty(ref storage, value, propertyName))
++            {
++                return false;
++            }
++
++            afterAction?.Invoke();
++            return true;
++        }
++
+         [NotifyPropertyChangedInvocator]
+         protected virtual bool SetProperty<T>(ref T storage, T value, [CallerMemberName] string propertyName = null)
+         {","So this will only be executed when it is true. I'm not sure that makes it always usable. Why not make the afterAction, `Action<bool>` and always call it, with the result as parameter.",Is there a reason you chose to
+6620,"@@ -516,6 +516,7 @@ int pfs_table::resolve_name(int is_special_syscall, const char *cname, struct pf
+ 		char tmp[PFS_PATH_MAX];
+ 		path_split(pname->path,pname->service_name,tmp);
+ 		pname->service = pfs_service_lookup(pname->service_name);
++		if (result == PFS_RESOLVE_LOCAL) pname->service = NULL;
+ 		if(!pname->service) {
+ 			pname->service = pfs_service_lookup_default();
+ 			strcpy(pname->service_name,""local"");","Tim, please add { } to this 'if'.",Why do we need to set it to NULL first?
+6621,"@@ -11,8 +11,11 @@ import (
+ )
+
+ const (
+-	// DefaultPort is used when no port is specified
++	// DefaultPort is used when no port is specified.
+ 	DefaultPort = ""31000""
++
++	// DefaultHost is the host that will be used when none is specified.
++	DefaultHost = ""127.0.0.1""
+ )
+
+ // Reporter will gather metrics of API requests made and",Suggest moving to `enable.go` since thats only place used.,why not 127.0.0.1?
+6622,"@@ -54,7 +54,7 @@ describe ""apply"" do
+
+         # Includes agent facts from apply_prep
+         agent_facts = report['resource_statuses']['Notify[agent facts]']['events'][0]['desired_value'].split(""\n"")
+-        expect(agent_facts[0]).to match(/^\w+\./)
++        expect(agent_facts[0]).to match(/^\w+/)
+         expect(agent_facts[1]).to eq(agent_facts[0])
+         expect(agent_facts[2]).to match(/^\d+\.\d+\.\d+$/)
+         expect(agent_facts[3]).to eq(agent_facts[2])","This changed when I rebuilt my docker container. Not quite sure why, but might have to do with what my host network configuration looks like when it's rebuilt.",**Question:** Would it be possible to r
+6623,"@@ -13,6 +13,7 @@ import (
+ 	""github.com/restic/restic/server""
+ )
+
++// Cache is used to handle the local cache.
+ type Cache struct {
+ 	base string
+ }",Local cache of what? What's stored in it?,`Cache is used to handle the local cach
+6624,"@@ -176,7 +176,7 @@ public class DataFiles {
+       this.keyMetadata = toCopy.keyMetadata() == null ? null
+           : ByteBuffers.copy(toCopy.keyMetadata());
+       this.splitOffsets = toCopy.splitOffsets() == null ? null : copyList(toCopy.splitOffsets());
+-      this.sortOrderId = toCopy.sortOrderId();
++      this.sortOrderId = toCopy.sortOrderId() == null ? SortOrder.unsorted().orderId() : toCopy.sortOrderId();
+       return this;
+     }
+ ","If the copied `DataFile` returns null, shouldn't the copy also return null? Why not make the builder use `Integer` instead of a primitive here?",Why not just call it `toCopy.sortOrderId()`?
+6625,"@@ -2,11 +2,18 @@ import os
+
+ from jinja2 import Environment, FileSystemLoader
+
++HTML_FILES_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'html_files')
++
+ def save_html(filename, context, template):
+     path = os.path.dirname(os.path.abspath(__file__))
+     template_environment = Environment(
+     loader=FileSystemLoader(os.path.join(path, 'templates')))
+-    outputfile = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'html_files', filename)
++    outputfile = os.path.join(HTML_FILES_PATH, filename)
+     with open(outputfile, 'w') as f:
+         html = template_environment.get_template(template).render(context)
+         f.write(html)
++
++
++def check_html_files_dir_path():
++    dir_exists = os.path.isdir(HTML_FILES_PATH)
++    return dir_exists","You could just do this test in the `save_html` function above, and then the users of the save html function don't have to worry about it.","Similar to above, using `os.path.join` would"
+6626,"@@ -214,7 +214,7 @@ func TestTaskRunOpts_Validate(t *testing.T) {
+ 					Name: ""my-app"",
+ 				}, nil)
+ 			},
+-			wantedError: errors.New(""get environment: couldn't find environment dev in the application my-app""),
++			wantedError: fmt.Errorf(""get environment %s config: couldn't find environment dev in the application my-app"", ""dev""),
+ 		},
+ 		""no workspace"": {
+ 			basicOpts: defaultOpts,","I think I'd prefer not using the formatted string when it comes to unit test, since we don't pass in any string variable as params.",Is there any reason to use `fmt.Errorf` here
+6627,"@@ -1,4 +1,4 @@
+-// +build avr esp nrf sam sifive stm32 k210 nxp
++// +build avr esp nrf sam sifive stm32 k210 nxp,!mimxrt1062
+
+ package machine
+ ",Maybe it would be better to explicitly include devices instead of explicitly excluding devices?,`mimxrt1062` is not available on all platfor
+6628,"@@ -475,10 +475,10 @@ void ROMol::clearComputedProps(bool includeRings) const {
+
+   RDProps::clearComputedProps();
+
+-  for (ConstAtomIterator atomIt = this->beginAtoms();
+-       atomIt != this->endAtoms(); ++atomIt) {
+-    (*atomIt)->clearComputedProps();
++  for (auto atom: atoms()) {
++    atom->clearComputedProps();
+   }
++
+   for (ConstBondIterator bondIt = this->beginBonds();
+        bondIt != this->endBonds(); bondIt++) {
+     (*bondIt)->clearComputedProps();","This could be `for (auto bond: bonds()){`, right?","AFAIK there is no way to use `atomIt != this->endAtoms()` instead of `atomIt != this->beginAtoms()`, since there is no way to differentiate between the two"
+6629,"@@ -78,10 +78,13 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+
++        $config = $this->getConfig();
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'allowConnectingCards' => $this->getAuthManager()
++                    ->supportsConnectingLibraryCard(),
+             ]
+         );
+     }",Is $config no longer being used? Can we remove this line?,Shouldn't it be `null` by default?
+6630,"@@ -179,7 +179,7 @@ char* get_file_name(char* filename)
+ //   finished with it.
+ // If you pass in NULL or the new string can't be allocated,
+ //   it returns NULL.
+-char* remove_ext(const char* path, char dot, char sep, size_t* allocated_size)
++char* remove_ext(const char* path, char dot, char sep, size_t* allocated_size)
+ {
+     char *retstr, *lastdot, *lastsep;
+     // Error checks and allocate string.",can you revert changes to this file.,(style) line over 80 characters
+6631,"@@ -2139,7 +2139,7 @@ public class DBService {
+                 Role templateRole = updateTemplateRole(role, domainName, roleName, templateParams);
+                 firstEntry = auditLogSeparator(auditDetails, firstEntry);
+                 auditDetails.append("" \""add-role\"": "");
+-                if (!processRole(con, originalRole, domainName, roleName, templateRole,
++                if (!processRole(con, originalRole, domainName, ZMSUtils.removeDomainPrefix(templateRole.getName(), domainName, ROLE_PREFIX), templateRole,
+                         admin, auditRef, true, auditDetails)) {
+                     return false;
+                 }","I don't believe the change is sufficient to correctly handle variable substitutions in the name. As part of the process command we pass the original role object that was retreived without taking into account the substitution. So while the first template apply command will work fine because the original role does not exist thus it's a new add operation, if you try to re-apply the same template again, we'll pick up and process a wrong original name thus we'll try to execute an add operation again instead of modify. So we need to take into account the substituted name when we retrieve the original role as well. Same change should be applied to both policy and service blocks as well.",Can you elaborate on why we need to remove the domain prefix here?
+6632,"@@ -14,5 +14,6 @@ namespace MvvmCross.Base
+     {
+         Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);
+         Task ExecuteOnMainThreadAsync(Func<Task> action, bool maskExceptions = true);
++        bool IsOnMainThread { get; }
+     }
+ }",Please add this to IMvxMainThreadDispatcher as well,Why did you choose to make this a property instead of a method?
+6633,"@@ -223,7 +223,7 @@ module Bolt
+           if @future
+             to_expand = %w[private-key cacert token-file] & selected.keys
+             to_expand.each do |opt|
+-              selected[opt] = File.expand_path(selected[opt], @boltdir.path) if opt.is_a?(String)
++              selected[opt] = File.expand_path(selected[opt], @boltdir.path) if selected[opt].is_a?(String)
+             end
+           end
+ ",Is it possible for opt not to be a string? I couldn't tell if this was a typo or if there is actually a case where it is not a string.,Won't this change expand the `selected` hash even if it is a `S
+6634,"@@ -54,6 +54,7 @@ export default function UserInputSettings() {
+ 			ctaLabel={ __( 'Let’s go', 'google-site-kit' ) }
+ 			dismiss={ __( 'Remind me later', 'google-site-kit' ) }
+ 			winImage={ global._googlesitekitLegacyData.admin.assetsRoot + personSitImage }
++			className=""googlesitekit-user-input__notification""
+ 		/>
+ 	);
+ }",Let's move this up next to the `id` as we usually have `className` as one of the first props.,"I think we need to add `className=""googlesitekit-user-input__no"
+6635,"@@ -4,14 +4,14 @@ import sys
+ from setuptools import setup, find_packages
+ from setuptools.command.install import install
+
+-VERSION = ""3.1.0""
++VERSION = ""3.1.1""
+
+ def readme():
+     readme_short = """"""
+     Quilt is a data management tool designed for data discoverability, data dependency
+     management, and data version control using `data packages <https://blog.quiltdata.com/data-packages-for-fast-reproducible-python-analysis-c74b78015c7f>`_.
+
+-    The `quilt` PyPi package allows you to build, push, and pull data packages in Quilt using Python.
++    The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python.
+     Visit the `documentation quickstart <https://docs.quiltdata.com/quickstart>`_ for more information.
+
+     """"""","While you're in here, ""build, push and install""?",Can you add the release version as well?
+6636,"@@ -35,8 +35,6 @@ namespace OpenTelemetry.Metrics
+
+         public string Description { get; set; }
+
+-        public string Unit { get; set; }
+-
+         public string[] TagKeys { get; set; }
+
+         public virtual Aggregation Aggregation { get; set; }",Unit never made it to spec...so removing.,This should have been removed.
+6637,"@@ -702,6 +702,9 @@ func (nl *NATSLatency) TotalTime() time.Duration {
+ // ServiceLatency is the JSON message sent out in response to latency tracking for
+ // exported services.
+ type ServiceLatency struct {
++	Type           string        `json:""type""`
++	ID             string        `json:""id""`
++	Time           string        `json:""timestamp""`
+ 	Status         int           `json:""status""`
+ 	Error          string        `json:""description,omitempty""`
+ 	AppName        string        `json:""app,omitempty""`","We have RequestStart which seems redundant a bit to this one, WDYT?",Why is this a string and not a
+6638,"@@ -1,10 +1,4 @@
+-import {
+-	Component,
+-	createElement,
+-	_unmount as unmount,
+-	options,
+-	cloneElement
+-} from 'preact';
++import { Component, createElement, options, Fragment } from 'preact';
+ import { removeNode } from '../../src/util';
+
+ const oldCatchError = options._catchError;",I think we can remove this corresponding export from `preact` now! Double check no other s using though lol,"`createElement` is now unused,"
+6639,"@@ -78,6 +78,14 @@ ActiveRecord::Schema.define(version: 20140604204910) do
+     t.datetime ""updated_at""
+   end
+
++  create_table ""item_traits"", force: true do |t|
++    t.text     ""name""
++    t.text     ""value""
++    t.integer  ""cart_item_id""
++    t.datetime ""created_at""
++    t.datetime ""updated_at""
++  end
++
+   create_table ""user_roles"", force: true do |t|
+     t.integer ""approval_group_id""
+     t.integer ""user_id""",I'm not sure why this would be in here. Were you working off a branch based off of master? These lines were removed in a previous commit because the table is actually called 'cart_item_traits'.,Unnecessary spacing detected.
+6640,"@@ -30,6 +30,8 @@ module Travis
+         bundler: false
+       }
+
++      DEFAULT_GITHUB_ENDPOINT = ""https://api.github.com""
++
+       attr_reader :data
+
+       def initialize(data, defaults = {})","Maybe `DEFAULT_GITHUB_API_ENDPOINT` would be a better name, since we refer to this as an API endpoint elsewhere?","If it's a constant, it should go into the constant in `app/models/config.rb`, and be referenced in `application/config.rb`."
+6641,"@@ -45,7 +45,9 @@ const (
+ 	capabilityPrefix             = ""com.amazonaws.ecs.capability.""
+ 	capabilityTaskIAMRole        = ""task-iam-role""
+ 	capabilityTaskIAMRoleNetHost = ""task-iam-role-network-host""
++	capabilityTaskCPUMemLimit    = ""task-cpu-mem-limit""
+ 	labelPrefix                  = ""com.amazonaws.ecs.""
++	attributePrefix              = ""ecs.capability.""
+ )
+
+ // DockerTaskEngine is a state machine for managing a task and its containers","If/when you rebase from `dev`, this is going to cause a merge conflict. I'd suggest that soon after merging this PR as the capabilities code has been moved to ""agent/app/agent_capabilities.go""",Should this be `task-cpu-mem-limit`?
+6642,"@@ -40,6 +40,14 @@ func Test_Start(t *testing.T) {
+ 	assert.Equal(t, ""bytecount 1"", mockConnection.LastLine)
+ }
+
++func Test_Stop(t *testing.T) {
++	statsRecorder := fakeStatsRecorder{}
++	middleware := NewMiddleware(statsRecorder.record, 1*time.Second)
++	mockConnection := &management.MockConnection{}
++	middleware.Stop(mockConnection)
++	assert.Equal(t, ""bytecount 0"", mockConnection.LastLine)
++}
++
+ func Test_ConsumeLine(t *testing.T) {
+ 	var tests = []struct {
+ 		line                  string",What is the test case here?,Is there a test for the same thing in `Test_ConsumeLine`?
+6643,"@@ -130,6 +130,7 @@ func run(o *Options) error {
+ 	go flowAggregator.Run(stopCh, &wg)
+
+ 	informerFactory.Start(stopCh)
++	informerFactory.WaitForCacheSync(stopCh)
+
+ 	<-stopCh
+ 	klog.Infof(""Stopping flow aggregator"")","You could try moving this closer to the call, where we request label info. We might be doing the check very early.. all the resources may not be present with the informer at this point.",@smarterclayton do we need to wait for the flow aggregator to start up before starting the aggregator?
+6644,"@@ -42,7 +42,10 @@ public interface ManifestFile {
+           required(509, ""contains_null"", Types.BooleanType.get()),
+           optional(510, ""lower_bound"", Types.BinaryType.get()), // null if no non-null values
+           optional(511, ""upper_bound"", Types.BinaryType.get())
+-      ))));
++      ))),
++      optional(512, ""added_rows_count"", Types.LongType.get()),
++      optional(513, ""existing_rows_count"", Types.LongType.get()),
++      optional(514, ""deleted_rows_count"", Types.LongType.get()));
+
+   static Schema schema() {
+     return SCHEMA;",Can we add these up by the data files counts?,"I think 513 is a little low, maybe 514 is a little high?"
+6645,"@@ -30,10 +30,8 @@ const resolve = (list, child, node) => {
+ 	// callbacks won't get queued in the node anyway.
+ 	// If revealOrder is 'together' then also do an early exit
+ 	// if all suspended descendants have not yet been resolved.
+-	if (
+-		!list.props.revealOrder ||
+-		(list.props.revealOrder[0] === 't' && list._map.size)
+-	) {
++	const revealOrder = list.props.revealOrder;
++	if (!revealOrder || (revealOrder[0] === 't' && list._map.size)) {
+ 		return;
+ 	}
+ ",Most of the time assigning won't save bytes unless used 3+ times (var adds 3bytes),"`list._map` is not guaranteed to be an array, please use"
+6646,"@@ -160,8 +160,8 @@ define(['playbackManager', 'nowPlayingHelper', 'events', 'connectionManager'], f
+
+         if (navigator.mediaSession) {
+             navigator.mediaSession.metadata = new MediaMetadata({
+-                title: title,
+-                artist: artist,
++                title: artist,
++                artist: title,
+                 album: album,
+                 artwork: getImageUrls(item),
+                 albumArtist: albumArtist,",I would rather find the code that inverts the logic and remove that.,I think this was a copy-paste error?
+6647,"@@ -142,7 +142,7 @@ class RemoteConnection(object):
+         :Returns:
+         Timeout value in seconds for all http requests made to the Remote Connection
+         """"""
+-        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout
++        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT else cls._timeout
+
+     @classmethod
+     def set_timeout(cls, timeout):",The else doesn't return anything?,How is this change related?
+6648,"@@ -48,7 +48,7 @@ func claim(args []string) error {
+ 		gasLimit = action.ClaimFromRewardingFundBaseGas +
+ 			action.ClaimFromRewardingFundGasPerByte*uint64(len(payload))
+ 	}
+-	gasPriceRau, err := gasPriceInRau()
++	gasPriceRau, _ := gasPriceInRau()
+ 	nonce, err := nonce(sender)
+ 	if err != nil {
+ 		return output.NewError(0, ""failed to get nonce"", err)",assignments should only be cuddled with other assignments (from `wsl`),Why not check the error here?
+6649,"@@ -3413,9 +3413,8 @@ static void
+ GetLibrarySearchPaths(std::vector<std::string> &paths,
+                       const swift::SearchPathOptions &search_path_opts) {
+   paths.clear();
+-  paths.resize(search_path_opts.LibrarySearchPaths.size() + 1);
+-  std::copy(search_path_opts.LibrarySearchPaths.begin(),
+-            search_path_opts.LibrarySearchPaths.end(), paths.begin());
++  paths.assign(search_path_opts.LibrarySearchPaths.begin(),
++            search_path_opts.LibrarySearchPaths.end());
+   paths.push_back(search_path_opts.RuntimeLibraryPath);
+ }
+ ",why not simply `paths = search_path_opts.LibrarySearchPaths` ?,Can this just be `search_path
+6650,"@@ -610,7 +610,7 @@ define([""globalize"", ""listView"", ""layoutManager"", ""userSettings"", ""focusManager""
+             }
+
+             if (item) {
+-                return item.Name;
++                return globalize.translate(item.Name);
+             }
+
+             if (""Movie"" === params.type) {",Are we sure this should be translated by the web client? It was unclear in chat exactly what's getting translated here.,Looks like this is the only p
+6651,"@@ -253,7 +253,7 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
+ 			docName = driver.UniqueString()
+ 			newName = docName
+ 		}
+-		w, err = c.putWrite(a.Doc, docName, &pb.Precondition{ConditionType: &pb.Precondition_Exists{false}})
++		w, err = c.putWrite(a.Doc, docName, &pb.Precondition{ConditionType: &pb.Precondition_Exists{Exists: false}})
+
+ 	case driver.Replace:
+ 		// If the given document has a revision, use it as the precondition (it implies existence).",same oneof issue.,Does this mean we're dropping
+6652,"@@ -258,7 +258,7 @@ module Bolt
+                     config.project.puppetfile,
+                     config.project.managed_moduledir,
+                     config.project.project_file,
+-                    config.module_install)
++                    @plugins.resolve_references(config.module_install))
+     end
+
+     # Generate Puppet data types from project modules.","If we resolve here, isn't the whole `module_install` config setting or any subkeys also pluggable? I think that's totally fine, just want to make sure that that's known, and we should also update the data in `options.rb` for those options",this is the only place where we use `@plugins.resolve_references`
+6653,"@@ -376,6 +376,7 @@ hipError_t ihipExtLaunchMultiKernelMultiDevice(hipLaunchParams* launchParamsList
+
+         if(globalWorkSizeX > UINT32_MAX || globalWorkSizeY > UINT32_MAX || globalWorkSizeZ > UINT32_MAX)
+         {
++            free(kds);
+             return hipErrorInvalidConfiguration;
+         }
+ ",it would be better to change `kds` into a `std::vector` then we don't need to explicitly free it,this will cause hipErrorInvalidConfiguration to be freed twice if
+6654,"@@ -113,6 +113,8 @@ def send_email_sendgrid(config, sender, subject, message, recipients, image_png)
+
+
+ def send_email(subject, message, sender, recipients, image_png=None):
++    config = configuration.get_config()
++
+     subject = _prefix(subject)
+     logger.debug(""Emailing:\n""
+                  ""-------------\n""",Looks like you're also changing logic and not only tests.,Why do you get this from the configuration object here?
+6655,"@@ -78,7 +78,7 @@ namespace Datadog.Trace.Tests.Sampling
+
+             var expectedLimit = totalMilliseconds * actualIntervalLimit / 1_000;
+
+-            var acceptableVariance = (actualIntervalLimit * 1.0);
++            var acceptableVariance = (actualIntervalLimit * 1.15);
+             var upperLimit = expectedLimit + acceptableVariance;
+             var lowerLimit = expectedLimit - acceptableVariance;
+ ",Is it possible that test failures here are real and that we should improve the rate limiting logic? Or are we ok with rate limits to be exceeded by 15%?,Why did you reduce the acceptableVariance to 1.15?
+6656,"@@ -71,6 +71,8 @@ class ImageProvider extends FileProvider
+             throw new \LogicException(""The 'srcset' and 'picture' options must not be used simultaneously."");
+         }
+
++        $attrPrefix = isset($options['lazy']) && true === $options['lazy'] ? 'data-' : '';
++
+         if (MediaProviderInterface::FORMAT_REFERENCE === $format) {
+             $box = $media->getBox();
+         } else {",Shouldn't there be some kind of validation somewhere? IMO there should be an exception if `$options['lazy']` is not a boolean.,Why the `data-` prefix if the `format === 'json'`?
+6657,"@@ -1,5 +1,7 @@
+ // Copyright (c) Microsoft. All rights reserved.
+
++using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging;
++
+ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer
+ {
+     using System;",nit: please move it inside namespace.,Nit: I think the convention is that the using stat
+6658,"@@ -15,7 +15,7 @@ module Bolt
+           shell-command
+           tmpdir
+           tty
+-        ].freeze
++        ].concat(RUN_AS_OPTIONS).sort.freeze
+
+         DEFAULTS = {
+           'cleanup' => true",The inventory schema needs to be regenerated to include these options. Looks like the CI job didn't get triggered since the paths don't include `lib/bolt/transport/**`.  ,I'm pretty sure this was the result of the previou
+6659,"@@ -0,0 +1,14 @@
++WELCOME_DIALOG_TEXT = (
++	""Welcome to NVDA  dialog  Welcome to NVDA!\n""
++	""Most commands for controlling NVDA require you to hold down the NVDA key while pressing other keys.\n""
++	""By default, the numpad Insert and main Insert keys may both be used as the NVDA key.\n""
++	""You can also configure NVDA to use the CapsLock as the NVDA key.\n""
++	""Press NVDA+n at any time to activate the NVDA menu.\n""
++	""From this menu, you can configure NVDA, get help and access other NVDA functions.\n""
++	""Options  grouping\n""
++	""Keyboard layout:  combo box  desktop  collapsed  Alt+k""
++)
++QUIT_DIALOG_TEXT = (
++	""Exit NVDA  dialog\n""
++	""What would you like to do?  combo box  Exit  collapsed  Alt+d""
++)","This might break if a user runs the system tests with a system language other than English, in which the user default language differs.",`numpad` -> `numpad_`
+6660,"@@ -3,7 +3,7 @@ require 'rspec/expectations'
+ RSpec::Matchers.define :have_errors do |expected|
+
+   match do
+-    actual.body.match(/Error/)
++    actual.body.match(/Error\:/)
+   end
+
+   failure_message do |actual|","This was raising intermittent errors, since Lorem ipsum contains the word ""error""","The `expected` argument is not used at all, so I removed it."
+6661,"@@ -214,6 +214,7 @@ bool RTPSDomain::removeRTPSParticipant(
+ {
+     if (p != nullptr)
+     {
++        assert((p->mp_impl != nullptr) && ""This participant has been previously invalidated"");
+         p->mp_impl->disable();
+
+         std::unique_lock<std::mutex> lock(m_mutex);",Shouldn't we then add `mp_impl = nullptr` to the destructor of `RTPSParticipant`,Is this assert valid? Or is it really valid to have `p == nu
+6662,"@@ -5,10 +5,10 @@ import pytest
+ from mmdet.datasets import DATASETS
+
+
+-@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock)
++@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock())
+ @patch('mmdet.datasets.CocoDataset._filter_imgs', MagicMock)
+ @patch('mmdet.datasets.CustomDataset._filter_imgs', MagicMock)
+ @patch('mmdet.datasets.XMLDataset._filter_imgs', MagicMock)",Are the additional brackets necessary?,Why do we patch `mmdet.datasets.CustomDataset.load_annotatio
+6663,"@@ -148,7 +148,7 @@ public class Invoker implements InvocationHandler {
+     }
+
+     PojoConsumerOperationMeta pojoConsumerOperationMeta = consumerMeta
+-        .findOperationMeta(MethodUtils.findSwaggerMethodName(method));
++        .findOperationMeta(MethodUtils.findSwaggerMethodName(method), consumerIntf);
+     if (pojoConsumerOperationMeta == null) {
+       throw new IllegalStateException(
+           String.format(",consumerMeta only belongs to this invoker instance only relate to this one consumerIntf class seems no need to build a complex key?,Any reason why we can't use `MethodUtils.findSwaggerMethod`
+6664,"@@ -35,6 +35,11 @@ RSpec.describe RSpec::Core::Formatters::BaseTextFormatter do
+       expect(formatter_output.string).to match(""1 example, 1 failure, 1 pending"")
+     end
+
++    it ""with 1s outputs singular (only pending)"" do
++      send_notification :dump_summary, summary_notification(1, examples(1), examples(0), examples(1), 0)
++      expect(formatter_output.string).to match(""1 example, 0 failures, 1 pending"")
++    end
++
+     it ""with 2s outputs pluralized (including pending)"" do
+       send_notification :dump_summary, summary_notification(2, examples(2), examples(2), examples(2), 0)
+       expect(formatter_output.string).to match(""2 examples, 2 failures, 2 pending"")","this one is unrelated right? (Don't mind including it, just making sure I understand)",I think we should call it `summary_summary_without_failures` or something like that instead of `summary_summary`
+6665,"@@ -0,0 +1,14 @@
++_base_ = [
++    '../_base_/datasets/coco_instance.py', '../_base_/models/solo_r50_fpn.py',
++    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
++]
++# optimizer
++optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)
++optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
++# learning policy
++lr_config = dict(
++    policy='step',
++    warmup='linear',
++    warmup_iters=500,
++    warmup_ratio=1.0 / 3,
++    step=[9, 11])","8, 11 actually achieves similar performance, we should use our default config if [9,11] is unnecessary.",lr_type is missing in dict(...)
+6666,"@@ -0,0 +1,12 @@
++package yarpc
++
++import (
++	""time""
++
++	""github.com/yarpc/yarpc-go/encoding/raw""
++)
++
++func SleepRaw(reqMeta *raw.ReqMeta, body []byte) ([]byte, *raw.ResMeta, error) {
++	time.Sleep(1 * time.Second)
++	return nil, nil, nil
++}",For a separate PR: Can we make this a JSON/Thrift procedure instead? It could accept the amount of time it needs to sleep as an argument.,I would prefer a shorter sleep like `time.Sleep(time.Second)`.
+6667,"@@ -92,6 +92,7 @@ class Tab(browsertab.AbstractTab):
+         pass
+
+
++
+ @pytest.mark.xfail(run=False, reason='Causes segfaults, see #1638')
+ def test_tab(qtbot, view, config_stub, tab_registry, mode_manager):
+     tab_w = Tab(win_id=0, mode_manager=mode_manager)",Please remove this blank line.,nit: no need for this empty line
+6668,"@@ -26,6 +26,7 @@ use Front\Front;
+ use Propel\Runtime\Exception\PropelException;
+ use Symfony\Component\HttpFoundation\Cookie;
+ use Symfony\Component\HttpFoundation\Request;
++use Thelia\Cart\CartTrait;
+ use Thelia\Controller\Front\BaseFrontController;
+ use Thelia\Core\Event\Cart\CartEvent;
+ use Thelia\Core\Event\Order\OrderEvent;",the cartTrait is not used anymore,Shouldn't this be `use Symfony\Component\HttpFoundation\Request;`?
+6669,"@@ -82,6 +82,7 @@ namespace OpenTelemetry.Trace.Configuration
+         /// Creates tracerSdk factory.
+         /// </summary>
+         /// <param name=""configure"">Function that configures tracerSdk factory.</param>
++        /// <returns><see cref=""TracerFactory""/>.</returns>
+         public static TracerFactory Create(Action<TracerBuilder> configure)
+         {
+             if (configure == null)",Cn you please make the message more human friendly.,"Shouldn't this be `<see cref=""TracerFactory""/>`?"
+6670,"@@ -23,10 +23,12 @@ import os
+ import sys
+ import html
+ import netrc
+-from typing import Callable, Mapping, List, Optional
+ import tempfile
++from enum import Enum, unique
++from typing import Callable, Mapping, List, Optional
+
+ from PyQt5.QtCore import QUrl
++from PyQt5.QtWebEngineWidgets import QWebEnginePage
+
+ from qutebrowser.config import config
+ from qutebrowser.utils import (usertypes, message, log, objreg, jinja, utils,","Please do `import enum` instead, then use `enum.Enum` and `enum.unique` - we do this everywhere to see where things are coming from, except for Qt (everything begins with a `Q` anyways) and typing (mostly used in type annotations, so it's clear without the namespacing).","These are no longer used in this file, right?"
+6671,"@@ -46,7 +46,6 @@
+
+ #include ""codec.h""
+
+-#define ENCFAIL (uint)0 /* a value that is not a valid instruction */
+
+ /* Decode immediate argument of bitwise operations.
+  * Returns zero if the encoding is invalid.",Isn't ENCFAIL used in codec.c below? Wouldn't this make it no longer compile?,Is it safe to remove this?
+6672,"@@ -73,6 +73,10 @@ public abstract class StaticLangXCombinedSurfaceView implements ViewModel {
+
+   public abstract List<PageStreamingDescriptorClassView> pageStreamingDescriptorClasses();
+
++  public boolean getTrue() {
++    return true;
++  }
++
+   public static Builder newBuilder() {
+     return new AutoValue_StaticLangXCombinedSurfaceView.Builder();
+   }",this looks very weird,"Please remove the `getTrue()` method, it should not be necessary."
+6673,"@@ -14,7 +14,9 @@ import java.util.logging.LogRecord;
+  * Log to the console using a basic formatter.
+  *
+  * @author Wouter Zelle
++ * @deprecated This class will be complety removed in 7.0.0
+  */
++@Deprecated
+ public class ConsoleLogHandler extends Handler {
+
+     private static final Formatter FORMATTER = new PmdLogFormatter();","So, the culprit was actually this class ""ConsoleLogHandler"", correct? Because it simply wrote to stdout...",Maybe add a `@Restricted(NoExternalUse.class)` here?
+6674,"@@ -272,7 +272,7 @@ namespace NLog.Config
+         public override LoggingConfiguration Reload()
+         {
+             if (!string.IsNullOrEmpty(_originalFileName))
+-                return new XmlLoggingConfiguration(_originalFileName, LogFactory);
++                return LogFactory.CreateConfig(_originalFileName); //TODO NLog 5: should call LoadConfiguration which set LogFactory.Configuration
+             else
+                 return base.Reload();
+         }",Still curious why you need to modify this method? Why not in the future just have a method called `LogFactory.ReloadConfiguration()` instead of the config assigning itself?,NLog 5 should call LoadConfiguration which set LogFactory.Configu
+6675,"@@ -110,8 +110,8 @@ class Test(base.Base):
+           'Molecule run (always).'))
+ def test(ctx, scenario_name, driver_name, __all, destroy):  # pragma: no cover
+     """"""
+-    Test (lint, destroy, dependency, syntax, create, prepare, converge,
+-          idempotence, side_effect, verify, destroy).
++    Test (lint, cleanup, destroy, dependency, syntax, create, prepare,
++          converge, idempotence, side_effect, verify, cleanup, destroy).
+     """"""
+
+     args = ctx.obj.get('args')","Should this say ""lint, cleanup, destroy, dependency, syntax, create, prepare, converge, idempotence, side_effect, verify, cleanup, destroy""?",Why are the changes in this file needed?
+6676,"@@ -23,12 +23,11 @@ func sendHeaders(ctx context.Context, headers p2p.Headers, stream *stream) error
+ 	defer cancel()
+
+ 	if err := w.WriteMsgWithContext(ctx, headersP2PToPB(headers)); err != nil {
+-		return fmt.Errorf(""write message: %w"", err)
++		return fmt.Errorf(""send write message: %w"", err)
+ 	}
+-
+ 	h := new(pb.Headers)
+ 	if err := r.ReadMsgWithContext(ctx, h); err != nil {
+-		return fmt.Errorf(""read message: %w"", err)
++		return fmt.Errorf(""send read message: %w"", err)
+ 	}
+
+ 	stream.headers = headersPBToP2P(h)",I am not sure why these log messages are changed.,did you mean to include the `err` in the message here?
+6677,"@@ -5,7 +5,10 @@ package runtime
+ // Interfaces are represented as a pair of {typecode, value}, where value can be
+ // anything (including non-pointers).
+
+-import ""unsafe""
++import (
++	""reflect""
++	""unsafe""
++)
+
+ type _interface struct {
+ 	typecode uintptr",This panic is incorrect - this is a full implementation of a slice equality check. This should be something more like `type x is not comparable` maybe?,This file is the main source of the PR. All the change
+6678,"@@ -271,7 +271,7 @@ add_extra_option(opt_info_t *opt_info, const TCHAR *opt)
+             return DR_FAILURE;
+         }
+
+-        len = MIN(DR_MAX_OPTIONS_LENGTH - 1, _tcslen(opt));
++        len = _dr_nlen(opt, DR_MAX_OPTIONS_LENGTH);
+         opt_info->extra_opts[idx] =
+             malloc((len + 1) * sizeof(opt_info->extra_opts[idx][0]));
+         _tcsncpy(opt_info->extra_opts[idx], opt, len);",See below: let's use the existing convention _tcsnlen.,Shouldn't this be `DR_MAX_OPTIONS_LENGTH - 1` instead?
+6679,"@@ -6,10 +6,6 @@ describe Step do
+
+   describe ""Validations"" do
+     it { should validate_presence_of(:proposal) }
+-    it do
+-      create(:approval_step) # needed for spec, see https://github.com/thoughtbot/shoulda-matchers/issues/194
+-      should validate_uniqueness_of(:user_id).scoped_to(:proposal_id)
+-    end
+   end
+
+   let(:approval) { create(:approval_step) }",Why don't we need this any more?,This spec no longer applies since this is no longer a
+6680,"@@ -0,0 +1,14 @@
++_base_ = ['./sparse_rcnn_r50_fpn_mstrain_480-800_3x_coco.py']
++
++model = dict(
++    pretrained='torchvision://resnet101',
++    backbone=dict(
++        type='ResNet',
++        depth=101,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++)",clean unnecessary comma,"I'm not sure if we should have this in the model. For now, I think we can just put the `requires_grad` flag in the model, since it doesn't affect performance."
+6681,"@@ -75,11 +75,14 @@ export function createVNode(type, props, key, ref, original) {
+ 		// a _nextDom that has been set to `null`
+ 		_nextDom: undefined,
+ 		_component: null,
+-		constructor: undefined,
+-		_original: original
++		constructor: undefined
+ 	};
+
+-	if (original == null) vnode._original = vnode;
++	Object.defineProperty(vnode, '_original', {
++		value: original || vnode,
++		enumerable: false,
++		writable: true
++	});
+ 	if (options.vnode) options.vnode(vnode);
+
+ 	return vnode;",This is the default value for enumerable.,Why was this changed?
+6682,"@@ -61,8 +61,8 @@ std::string chemicalReactionTemplatesToString(
+     bool toSmiles, bool canonical) {
+   std::string res = """";
+   std::vector<std::string> vfragsmi;
+-  RDKit::MOL_SPTR_VECT::const_iterator begin = getStartIterator(rxn, type);
+-  RDKit::MOL_SPTR_VECT::const_iterator end = getEndIterator(rxn, type);
++  auto begin = getStartIterator(rxn, type);
++  auto end = getEndIterator(rxn, type);
+   for (; begin != end; ++begin) {
+     vfragsmi.push_back(molToString(**begin, toSmiles));
+   }","Just above, you have `const auto` for a `RDKit::MOL_SPTR_VECT::const_iterator`, here it is only `auto`. Why is this?",Range-based `for` loop could be used here for consistency.
+6683,"@@ -186,9 +186,10 @@ bool Actions::registerEvent(Event_ptr event, const pugi::xml_node& node)
+ 	return false;
+ }
+
+-bool Actions::registerLuaEvent(Event* event)
++bool Actions::registerLuaEvent(Action* event)
+ {
+-	Action_ptr action{ static_cast<Action*>(event) }; //event is guaranteed to be an Action
++	Event_ptr ptr = Event_ptr(event);
++	Action_ptr action{ static_cast<Action*>(ptr.release()) }; //event is guaranteed to be an Action
+ 	if (action->getItemIdRange().size() > 0) {
+ 		if (action->getItemIdRange().size() == 1) {
+ 			auto result = useItemMap.emplace(action->getItemIdRange().at(0), std::move(*action));","@djarek just a quick question, wouldn't be `ptr.reset()` here better as it does not memory leak if we do not call delete on the raw pointer aswell? it maybe makes sense to use `ptr.release` if the event is guaranteed to be loaded again but on a reload it would memory leak if for example I removed that script from my files before reloading or not?",please fix the tabulation here.
+6684,"@@ -218,8 +218,12 @@ func (cfg *Config) GetString(key string) string {
+
+ // GetStringSlice returns config value as []string.
+ func (cfg *Config) GetStringSlice(key string) []string {
+-	value := cfg.Get(key).(*cli.StringSlice)
+-	return cast.ToStringSlice([]string(*value))
++	switch cfg.Get(key).(type) {
++	case *cli.StringSlice:
++		return cast.ToStringSlice([]string(*cfg.Get(key).(*cli.StringSlice)))
++	default:
++		return cast.ToStringSlice(cfg.Get(key))
++	}
+ }
+
+ // ParseBoolFlag parses a cli.BoolFlag from command's context and","Why to `Get()` value twice, while u have it 2 lines before","Since we have `StringSlice` now, we can just use `cfg.Get(key)`."
+6685,"@@ -310,10 +310,17 @@ class ServiceProvider extends ModuleServiceProvider
+         $this->registerConsoleCommand('october.update', 'System\Console\OctoberUpdate');
+         $this->registerConsoleCommand('october.util', 'System\Console\OctoberUtil');
+         $this->registerConsoleCommand('october.mirror', 'System\Console\OctoberMirror');
++        $this->registerConsoleCommand('october.mirror', 'System\Console\OctoberFresh');
++
+         $this->registerConsoleCommand('plugin.install', 'System\Console\PluginInstall');
+         $this->registerConsoleCommand('plugin.remove', 'System\Console\PluginRemove');
+         $this->registerConsoleCommand('plugin.refresh', 'System\Console\PluginRefresh');
+
++        $this->registerConsoleCommand('theme.use', 'System\Console\ThemeUse');
++        $this->registerConsoleCommand('theme.list', 'System\Console\ThemeList');
++        $this->registerConsoleCommand('theme.install', 'System\Console\ThemeInstall');
++        $this->registerConsoleCommand('theme.delete', 'System\Console\ThemeDelete');
++
+         /*
+          * Register the sidebar for the System main menu
+          */","There is a typo here, this needs to state `october.fresh`",Please call the file `theme.php` instead of the FQN.
+6686,"@@ -139,6 +139,18 @@ public class TestHadoopTables {
+     Assert.assertEquals(""Transform must match"", transform, sortOrder.fields().get(0).transform());
+   }
+
++  @Test
++  public void testTableName() {
++    PartitionSpec spec = PartitionSpec.builderFor(SCHEMA)
++        .bucket(""data"", 16)
++        .build();
++    String location = tableDir.toURI().toString();
++    TABLES.create(SCHEMA, spec, location);
++
++    Table table = TABLES.load(location);
++    Assert.assertEquals(""Table name must match"", location, table.name());
++  }
++
+   private static void createDummyTable(File tableDir, File dataDir) throws IOException {
+     Table table = TABLES.create(SCHEMA, tableDir.toURI().toString());
+     AppendFiles append = table.newAppend();",Metadata tables loaded through `HadoopTables` will have their names as location.type (which is weird as we normally use location#type). I am not sure whether it is a big deal or not.,`toURI().toString()` is probably better than `String.valueOf(loc
+6687,"@@ -343,7 +343,7 @@ Blockly.VerticalFlyout.prototype.wheel_ = function(e) {
+       delta *= 10;
+     }
+     var metrics = this.getMetrics_();
+-    var pos = metrics.viewTop + delta;
++    var pos = -this.workspace_.scrollY + delta;
+     var limit = metrics.contentHeight - metrics.viewHeight;
+     pos = Math.min(pos, limit);
+     pos = Math.max(pos, 0);",Can you explain why you went from a positive value (metrics.viewTop) to a negative value?,@alanorozco Can you review this change since you originally adde
+6688,"@@ -91,4 +91,11 @@ public interface ExternalTaskRestService {
+   @Produces(MediaType.APPLICATION_JSON)
+   BatchDto setRetriesAsync(SetRetriesForExternalTasksDto retriesDto);
+
++  @GET
++  @Path(""/topic-names"")
++  @Produces(MediaType.APPLICATION_JSON)
++  List<String> getTopicNames(@QueryParam(""withLockedTasks"") boolean withLockedTasks,
++      @QueryParam(""withUnlockedTasks"") boolean withUnlockedTasks,
++      @QueryParam(""withRetriesLeft"") boolean withRetriesLeft);
++
+ }",Let's use a dedicated DTO instead of `List<String>` to remain consistent with all other existing REST API endpoints: * Introduce a new DTO class (e. g. `ExternalTaskTopicNameDto`) located under `org.camunda.bpm.engine.rest.dto.externaltask` * The class should have the attribute `topicName` of type `String` * Introduce a getter & setter for the attribute * Convert the list of strings to a list of `ExternalTaskTopicNameDto`s * Change the method signature to return `List<ExternalTaskTopicNameDto>`,I would have put the names of the parameters in the same order as the names of the methods in the `ApiResource`
+6689,"@@ -42,6 +42,14 @@ public interface RepositoryManager {
+      */
+     ScriptDTO getScript(List<String> path);
+
++    /**
++     * This method returns the {@link org.phoenicis.repository.dto.ScriptDTO} with the given ID
++     *
++     * @param id The script ID
++     * @return The found ScriptDTO
++     */
++    ScriptDTO getScript(String id);
++
+     /**
+      * This method moves the repository, belonging to the given repository url, to the given index.
+      * This is done by swapping the current content at the given index with old index of the given repository url",Do you plan to remove the `ScriptDTO getScript(List<String> path);` method long-term?,should be `{@link org.phoenicis.repository.dto.ScriptDTO}`
+6690,"@@ -134,12 +134,14 @@
+             },
+             types: function() {
+                 var self = this;
+-                var result = this.allTypes.filter(function(item) {
++                if (this.enabledTypes && !this.enabledTypes.length) {
++                    return this.allTypes;
++                }
++                return this.allTypes.filter(function(item) {
+                     return self.enabledTypes.some(function(enabledItem) {
+                         return enabledItem === item.value;
+                     });
+                 });
+-                return result;
+             }
+         }
+     });","@itsiprikshit I used a custom v-model to app count component because the sourceapps component was not reacting to user app count selection, e.g. whenever user changed app count selection, the source apps selection multiplicity remained the same. As a matter of fact, user was able to select one application only. Please let me know if you have any thoughts on this.",There's no need to pass `this.enabledTypes` to `some`.
+6691,"@@ -4,6 +4,7 @@ from mmcv.cnn import ConvModule, kaiming_init
+ from mmcv.runner import auto_fp16, force_fp32
+
+ from mmdet.models.builder import HEADS
++from mmdet.models.utils import ResLayer, SimplifiedBasicBlock
+
+
+ @HEADS.register_module()","Similarly, we think we may keep `fused_semantic_head.py` unchanged. Then, we could add a new mask head for the desired function.",Please add a blank line after imports.
+6692,"@@ -175,4 +175,10 @@ public class PhpModelTypeNameConverter implements ModelTypeNameConverter {
+   private static String getPhpPackage(ProtoFile file) {
+     return file.getProto().getPackage().replaceAll(""\\."", ""\\\\"");
+   }
++
++  @Override
++  public TypeName getTypeNameForTypedResourceName(
++      ProtoElement elem, String typedResourceShortName) {
++    throw new UnsupportedOperationException(""getTypeNameForTypedResourceName not supported by PHP"");
++  }
+ }",Why implement this? It duplicates the value in FeatureConfig.,Please use `UnsupportedOperationException` instead of `UnsupportedOperationException`.
+6693,"@@ -159,8 +159,14 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
+
+   @Override
+   public Scan build() {
+-    return new SparkBatchQueryScan(
+-        spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    // TODO: understand how to differentiate that this is a spark streaming microbatch scan.
++    if (false) {
++      return new SparkBatchQueryScan(
++              spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    } else {
++      return new SparkMicroBatchStreamScan(
++              spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    }
+   }
+
+   public Scan buildMergeScan() {","@aokolnychyi / @RussellSpitzer / @holdenk Spark3 gives ScanBuilder - abstraction - to define all types of Scans (Batch, MicroBatch & Continuous). But, the current implementation / class modelling - has SparkBatchScan as the Scan implementation. Looking at some of the concerns of BatchScan - all the way from the State maintenance of a single SnapshotId to read from, the asOfTimeStamp & features like VectorizedReads - all of these don't seem relevant to Streaming Scans. So, I feel that we need to divide out Streaming Scans into a different class. Does this thought process - make sense? If we go by this route - do you folks know - how to pass different Scan objects to Spark based on Batch vs Streaming?","As we discussed, we can implement a streaming scan using `SparkMicroBatchQueryScan` in"
+6694,"@@ -56,10 +56,7 @@ public final class ClaimTypeConverter implements Converter<Map<String, Object>,
+ 		this.claimTypeConverters.forEach((claimName, typeConverter) -> {
+ 			if (claims.containsKey(claimName)) {
+ 				Object claim = claims.get(claimName);
+-				Object mappedClaim = typeConverter.convert(claim);
+-				if (mappedClaim != null) {
+-					result.put(claimName, mappedClaim);
+-				}
++				result.put(claimName, typeConverter.convert(claim));
+ 			}
+ 		});
+ 		return result;",Will you please update these files to use a copyright end date of 2021?,Is this change needed? I don't see any changes in this PR that would make this change
+6695,"@@ -10,6 +10,17 @@ if (window.__AXE_EXTENSION__) {
+ /*eslint indent: 0*/
+ var testUtils = {};
+
++var fixture = document.createElement('div');
++fixture.setAttribute('id', 'fixture');
++document.body.insertBefore(fixture, document.body.firstChild);
++
++/*eslint no-unused-vars: 0*/
++var checks, commons;
++var originalChecks = (checks = axe._audit.checks);
++var originalAudit = axe._audit;
++var originalRules = axe._audit.rules;
++var originalCommons = (commons = axe.commons);
++
+ /**
+  * Create a check context for mocking/resetting data and relatedNodes in tests
+  *",Adding fixture to the body as we don't have the `runner.tmpl` anymore,"You don't need to assign these here, do we?"
+6696,"@@ -6,11 +6,15 @@ import (
+
+ 	log ""github.com/sirupsen/logrus""
+
++	librarygocontroller ""github.com/openshift/library-go/pkg/controller""
++
+ 	corev1 ""k8s.io/api/core/v1""
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/client-go/util/flowcontrol""
+ 	""k8s.io/client-go/util/workqueue""
++	""k8s.io/utils/pointer""
+
+ 	""sigs.k8s.io/controller-runtime/pkg/client""
+ 	""sigs.k8s.io/controller-runtime/pkg/controller""",nit: just for consistency we can move this import block down. Right above openshift/hive imports,@smarterclayton @sttts is there a better way to do this?
+6697,"@@ -57,7 +57,7 @@ class MessageLocationTuple(NamedTuple):
+
+
+ class ManagedMessage(NamedTuple):
+-    """"""Tuple with information ahout a managed message of the linter""""""
++    """"""Tuple with information about a managed message of the linter""""""
+
+     name: Optional[str]
+     msgid: str",Perhaps clean up the commit history and don't squash?,This is an unrelated typo fix.
+6698,"@@ -162,7 +162,7 @@ final class ScribeInboundHandler extends ChannelInboundHandlerAdapter {
+           buf.release();
+         }
+       } else {
+-        returned.writeBytes(content.array(), content.offset(), content.length());
++        returned.writeBytes(content.array(), 0, content.length());
+       }
+
+       if (responseIndex == previouslySentResponseIndex + 1) {","Just `writeBytes(content.array())` Back to my original, somewhat broken version ;)",is this fix related to the bug?
+6699,"@@ -95,6 +95,16 @@ func TestCrossdock(t *testing.T) {
+ 				""transport"": []string{""http"", ""tchannel""},
+ 			},
+ 		},
++		{
++			name: ""ctxpropagation"",
++			axes: axes{
++				""transport"": []string{""http"", ""tchannel""},
++			},
++			params: params{
++				""ctxserver"": ""127.0.0.1"",
++				""ctxclient"": ""127.0.0.1"",
++			},
++		},
+ 	}
+
+ 	for _, bb := range behaviors {",I couldn't tell from reading the test - do we every criss-cross transports in the same test? I want to make sure we aren't breaking the chain...,I think this is missing a `.` at the end of the `ctxprop
+6700,"@@ -10,11 +10,11 @@ import (
+ 	""context""
+ 	""crypto/sha256""
+ 	""encoding/hex""
++	""github.com/facebookgo/clock""
+ 	""math/big""
+ 	""strings""
+ 	""testing""
+
+-	""github.com/facebookgo/clock""
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/require""
+ 	""golang.org/x/crypto/blake2b""",File is not `goimports`-ed,Why was this line moved?
+6701,"@@ -227,9 +227,6 @@ func invokeErrorToYARPCError(err error, responseMD metadata.MD) error {
+
+ // CallStream implements transport.StreamOutbound#CallStream.
+ func (o *Outbound) CallStream(ctx context.Context, request *transport.StreamRequest) (*transport.ClientStream, error) {
+-	if _, ok := ctx.Deadline(); !ok {
+-		return nil, yarpcerrors.InvalidArgumentErrorf(""stream requests require a connection establishment timeout on the passed in context"")
+-	}
+ 	if err := o.once.WaitUntilRunning(ctx); err != nil {
+ 		return nil, err
+ 	}","do we want to still validate that the context had a nonzero TTL? i suppose it's fine to let clients determine whether or not their streams will timeout (though we still don't have the means to cancel them from the server other than EOF), and they can still cancel their own contexts - so maybe not a huge deal, but thought it was worth bringing up.",Why was this removed?
+6702,"@@ -72,4 +72,9 @@ public class JavaNameFormatter implements NameFormatter {
+   public String classFileNameBase(Name name) {
+     return name.toOriginal();
+   }
++
++  @Override
++  public String humanName(Name name) {
++    throw new UnsupportedOperationException();
++  }
+ }",Go ahead and provide the same implementation for all of the languages - I'm not sure there's a reason for it to be different.,why is this needed? I do
+6703,"@@ -253,6 +253,15 @@ class TestApp(tornado.testing.AsyncHTTPTestCase):
+         assert self.put_json(""/settings"", {""anticache"": True}).code == 200
+         assert self.put_json(""/settings"", {""wtf"": True}).code == 400
+
++    def test_options(self):
++        j = json(self.fetch(""/options""))
++        assert type(j) == list
++        assert type(j[0]) == dict
++
++    def test_option_update(self):
++        assert self.put_json(""/options"", {""anticache"": True}).code == 200
++        assert self.put_json(""/options"", {""wtf"": True}).code == 400
++
+     def test_err(self):
+         with mock.patch(""mitmproxy.tools.web.app.IndexHandler.get"") as f:
+             f.side_effect = RuntimeError","We should also test type confusion here (e.g. `{""anticache"": ""foo""}`)",Looks like there's some
+6704,"@@ -236,6 +236,10 @@ MESSAGE
+             end
+
+             sh.cmd 'unformatted=`dartfmt -n .`'
++            # If `dartfmt` fails for some reason
++            sh.if '$? -ne 0' do
++              sh.failure """"
++            end
+             sh.if '! -z ""$unformatted""' do
+               sh.echo ""Files are unformatted:"", ansi: :red
+               sh.echo ""$unformatted""",I'd love to trim the content of `unformatted` too. Any ideas?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+6705,"@@ -17,6 +17,7 @@
+ """"""
+ Utilities to deal with types. This is mostly focused on python3.
+ """"""
++
+ import typing
+ from inspect import getfullargspec
+ from functools import wraps",can you remove this unrelated change?,This file has nothing to do with this PR.
+6706,"@@ -145,6 +145,17 @@ class MainWindow(QWidget):
+         _private: Whether the window is in private browsing mode.
+     """"""
+
++    # Application wide stylesheets
++    STYLESHEET = """"""
++        QLabel#hint {
++            background-color: {{ conf.colors.hints.bg }};
++            color: {{ conf.colors.hints.fg }};
++            font: {{ conf.fonts.hints }};
++            border: {{ conf.hints.border }};
++            padding-left: -3px;
++        }
++    """"""
++
+     def __init__(self, *, private, geometry=None, parent=None):
+         """"""Create a new main window.
+ ",Would using `HintLabel` here instead (without `setObjectName`) work?,Shouldn't this be in .eslintrc.css?
+6707,"@@ -51,7 +51,7 @@ type solver interface {
+ // It is useful for mocking out a given provider since an alternate set of
+ // constructors may be set.
+ type dnsProviderConstructors struct {
+-	cloudDNS   func(project string, serviceAccount []byte, dns01Nameservers []string) (*clouddns.DNSProvider, error)
++	cloudDNS   func(project string, serviceAccountFile string, serviceAccount []byte, dns01Nameservers []string, ambient bool) (*clouddns.DNSProvider, error)
+ 	cloudFlare func(email, apikey string, dns01Nameservers []string) (*cloudflare.DNSProvider, error)
+ 	route53    func(accessKey, secretKey, hostedZoneID, region string, ambient bool, dns01Nameservers []string) (*route53.DNSProvider, error)
+ 	azureDNS   func(clientID, clientSecret, subscriptionID, tenentID, resourceGroupName, hostedZoneName string, dns01Nameservers []string) (*azuredns.DNSProvider, error)","From what I can tell, the `serviceAccountFile` is never set to anything except """"? It'd be best to remove this altogether, so we don't mislead future developers  ",Why do we have this struct if it's only used in `pkg/configurator`? Shouldn't we just pas
+6708,"@@ -18,11 +18,6 @@
+             </li>
+           </ul>
+         </nav>
+-        <nav>
+-          <ul>
+-            <li class=""account""><%= link_to 'Sign in', sign_in_path %></li>
+-          </ul>
+-        </nav>
+       </div>
+     </section>
+ ",Why do we remove the Sign in link?,Should we remove the `sign_in_path` itself?
+6709,"@@ -186,11 +186,6 @@ public class FeedItemMenuHandler {
+                     GpodnetPreferences.enqueueEpisodeAction(actionNew);
+                 }
+                 break;
+-            case R.id.move_to_top_item:
+-                DBWriter.moveQueueItemToTop(selectedItem.getId(), true);
+-                return true;
+-            case R.id.move_to_bottom_item:
+-                DBWriter.moveQueueItemToBottom(selectedItem.getId(), true);
+             case R.id.add_to_queue_item:
+                 DBWriter.addQueueItem(context, selectedItem);
+                 break;","holy crap, were we really missing a 'break' statement here?",We should return `true` here instead of `fa
+6710,"@@ -28,6 +28,10 @@ type logMaker interface {
+ 	MakeLogger(module string) logger.Logger
+ }
+
++type debugForcedLogMaker interface {
++	MakeLoggerForceEnableDebug(module string) logger.Logger
++}
++
+ type blockCacher interface {
+ 	BlockCache() BlockCache
+ }","This doesn't seem to be used anywhere, probably doesn't need to be a new interface.",What's the reason for creating this interfa
+6711,"@@ -363,7 +363,9 @@ func (f *FS) Statfs(ctx context.Context, req *fuse.StatfsRequest, resp *fuse.Sta
+ 	usageBytes, limitBytes, err := f.quotaUsage.Get(ctx, quotaUsageStaleTolerance)
+ 	if err != nil {
+ 		f.log.CDebugf(ctx, ""Getting quota usage error: %v"", err)
+-		return err
++		// Ignore the error here so Statfs() can succeeded. Otherwise reading a
++		// public TLF while logged out fails on macOS.
++		return nil
+ 	}
+
+ 	total := getNumBlocksFromSize(uint64(limitBytes))","This is a good start, but what do you think about just using `libkbfs.GetCurrentSessionIfPossible()` to avoid calling this altogether if there's no session? That way we can avoid continuous RTTs to the server when logged out.","We shouldn't ignore the error here, but log"
+6712,"@@ -0,0 +1,18 @@
++<div class=""dropdown edit_menu"">
++  <%= link_to link_text, edit_path,
++              :id => 'editanchor',
++              :class => ""geolink tab #{link_class}"" %>
++  <a class='dropdown-toggle' data-toggle='dropdown' href='#'>
++    <b class=""caret""></b>
++  </a>
++  <ul class='dropdown-menu' role='menu' aria-labelledby='dLabel'>
++    <% Editors::RECOMMENDED_EDITORS.each do |editor| %>
++      <li>
++        <%= link_to t('layouts.edit_with', :editor => t(""editor.#{editor}.description"")),
++                    edit_path(:editor => editor),
++                    :data => { :editor => editor },
++                    :class => ""geolink #{link_class}"" %>
++      </li>
++    <% end %>
++  </ul>
++</div>","This `aria-labelledby` stuff is all new to me, but my reading of the spec is that the value should be a list of element id values, and `dLabel` doesn't seem to be the id of any element?",Use the new hash syntax `data: { :editor => editor }`
+6713,"@@ -6,16 +6,16 @@ module Bolt
+       class Step
+         class Upload < Step
+           def self.allowed_keys
+-            super + Set['source', 'destination']
++            super + Set['source', 'destination', 'upload']
+           end
+
+           def self.required_keys
+-            Set['destination', 'source', 'targets']
++            Set['upload', 'destination', 'targets']
+           end
+
+           def initialize(step_body)
+             super
+-            @source = step_body['source']
++            @source = step_body['upload'] || step_body['source']
+             @destination = step_body['destination']
+           end
+ ",Does this fail validation if you now use the `upload` key instead of `source`?,Prefer double-quoted strings unless you need single q
+6714,"@@ -733,7 +733,7 @@ CmpStoredProc::ExecStatus CmpStoredProc::close(CmpSPDataObject&)
+ // Methods of CmpISPFuncs
+ // -----------------------------------------------------------------------
+
+-NAList<CmpISPFuncs::ProcFuncsStruct> CmpISPFuncs::procFuncsArray_(256);
++NAList<CmpISPFuncs::ProcFuncsStruct> CmpISPFuncs::procFuncsArray_(NULL,256);
+
+ CmpISPFuncs::CmpISPFuncs()
+ {",Can we use GetCliGlobals(false)->exCollHeap() here instead,nit: space after comma
+6715,"@@ -17,7 +17,10 @@ namespace storage {
+
+ TEST(AddEdgesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddEdgesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
++    TestUtils::waitUntilAllElected(kv.get(), 0, {0, 1, 2, 3, 4, 5}/*partitions*/);
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddEdgesProcessor::instance(kv.get(),",I suggest you move the waitUntilAllElected into init::KV() method.,use `constexpr int32_t partitions = 6;`
+6716,"@@ -28,6 +28,11 @@ namespace OpenTelemetry
+     public class BatchExportProcessor<T> : BaseExportProcessor<T>
+         where T : class
+     {
++        public const int DefaultMaxQueueLength = 2048;
++        public const int DefaultScheduledDelayMilliseconds = 5000;
++        public const int DefaultTimeoutMilliseconds = 30000;
++        public const int DefaultMaxBatchSize = 512;
++
+         private readonly CircularBuffer<T> circularBuffer;
+         private readonly int scheduledDelayMilliseconds;
+         private readonly int exporterTimeoutMilliseconds;",no need of pub;lic.,Would it make sense to make these properties non-nullable and default to 0?
+6717,"@@ -237,6 +237,10 @@ type ConsensusParams struct {
+
+ 	// max decimal precision for assets
+ 	MaxAssetDecimals uint32
++
++	// whether to use the old buggy Credential.lowestOutput function
++	// TODO(upgrade): Please remove as soon as the upgrade goes through
++	UseBuggyProposalLowestOutput bool
+ }
+
+ // Consensus tracks the protocol-level settings for different versions of the",Do you think we can name this variable in a less ...negative.. language ? maybe `ProposalTieBreakerEqualizer`,Do we have a card for this TODO?
+6718,"@@ -48,7 +48,7 @@ class PartitionKey implements StructLike {
+   private final Accessor<InternalRow>[] accessors;
+
+   @SuppressWarnings(""unchecked"")
+-  PartitionKey(PartitionSpec spec) {
++  PartitionKey(PartitionSpec spec, Schema inputSchema) {
+     this.spec = spec;
+
+     List<PartitionField> fields = spec.fields();",Can you add back these newlines? We try to avoid non-functional changes like this because they can cause commit conflicts.,can you make this `final`?
+6719,"@@ -755,7 +755,8 @@ const reducer = (state = defaultState, action) => {
+ 		case 'SEARCH_ADD':
+ 			{
+ 				newState = Object.assign({}, state);
+-				const searches = newState.searches.slice();
++				let searches = newState.searches.slice();
++        searches = searches.filter(s => s.title !== action.search.title);
+ 				searches.push(action.search);
+ 				newState.searches = searches;
+ 			}",Why not just `if (!searches.includes(action.search)) searches.push(action.search)`? That way you don't need to remove then add the element.,The title of the action should be cached so we don't re-render every time.
+6720,"@@ -276,6 +276,17 @@ class Demo extends AbstractBase
+         return $a . $b . ""."" . $c;
+     }
+
++    /**
++     * Generate a fake call number prefix.
++     *
++     * @return string
++     */
++    protected function getFakeCallNumPrefix()
++    {
++        $codes = ""ABCDEFGHIJKLMNOPQRSTUVWXYZ"";
++        return substr(str_shuffle($codes), 1, rand(0, 3));
++    }
++
+     /**
+      * Get a random ID from the Solr index.
+      *","@demiankatz I'm not sure that this is very useful. I just did it to get started. If we had a small handful of predetermined prefixes that were randomly chosen, it would be easier to distinguish them from the rest of the call number. Would that be preferable?",Can we use a more descriptive name? Perhaps `getCallNumPrefix`?
+6721,"@@ -313,16 +313,6 @@ func createUpstreamRequest(rw http.ResponseWriter, r *http.Request) (*http.Reque
+ 	// Original incoming server request may be canceled by the
+ 	// user or by std lib(e.g. too many idle connections).
+ 	ctx, cancel := context.WithCancel(r.Context())
+-	if cn, ok := rw.(http.CloseNotifier); ok {
+-		notifyChan := cn.CloseNotify()
+-		go func() {
+-			select {
+-			case <-notifyChan:
+-				cancel()
+-			case <-ctx.Done():
+-			}
+-		}()
+-	}
+
+ 	outreq := r.WithContext(ctx) // includes shallow copies of maps, but okay
+ ",Why is this deleted too?,I don't think this is safe to remove. We don't want to close th
+6722,"@@ -8,9 +8,9 @@ using System.Threading.Tasks;
+
+ namespace Datadog.Trace.Agent
+ {
+-    internal class ApiWebResponse : IApiResponse
++    internal class ApiWebResponse : IApiResponse, IDisposable
+     {
+-        private HttpWebResponse _response;
++        private readonly HttpWebResponse _response;
+
+         public ApiWebResponse(HttpWebResponse response)
+         {","Given that IApiResponse is already made disposable, this is not necessary.",Why is this readonly?
+6723,"@@ -97,7 +97,10 @@ class ItemPricesOverlay extends Overlay
+ 		switch (action)
+ 		{
+ 			case ITEM_USE_ON_WIDGET:
+-				if (!menuEntry.getTarget().contains(""High Level Alchemy"") || !plugin.isShowAlchProfit()) return null;
++				if (!menuEntry.getTarget().contains(""High Level Alchemy"") || !plugin.isShowAlchProfit())
++				{
++					return null;
++				}
+ 			case WIDGET_DEFAULT:
+ 			case ITEM_USE:
+ 			case ITEM_FIRST_OPTION:",client.getSelectedSpellName() can be used for this,Unnecessary empty line.
+6724,"@@ -14,6 +14,12 @@
+
+ """"""Common formatting methods.""""""
+
++# Filename patterns.
++VIOLATION_JSON_FMT = 'violations.{}.{}.{}.json'
++SCANNER_OUTPUT_CSV_FMT = 'scanner_output_base.{}.csv'
++FINDINGS_FILENAME = 'forseti_findings_{}.json'
++
++# Timestamps.
+ # Example: '2018-03-01T21:31:52'
+ TIMESTAMP_UTC_OFFSET = '%Y-%m-%dT%H:%M:%S%z'
+ ",Please alpha sort these filenames.,How about we rename this to something like `forseti_findings_path`? This way we can also remove the `_file` suffix from the filename.
+6725,"@@ -147,17 +147,6 @@ func (p *Protocol) validateTransfer(_ context.Context, act action.Action) error
+ 	if tsf.TotalSize() > TransferSizeLimit {
+ 		return errors.Wrap(action.ErrActPool, ""oversized data"")
+ 	}
+-	// Reject transfer of negative amount
+-	if tsf.Amount().Sign() < 0 {
+-		return errors.Wrap(action.ErrBalance, ""negative value"")
+-	}
+-	// Reject transfer of negative gas price
+-	if tsf.GasPrice().Sign() < 0 {
+-		return errors.Wrap(action.ErrGasPrice, ""negative value"")
+-	}
+-	// check if recipient's address is valid
+-	if _, err := address.FromString(tsf.Recipient()); err != nil {
+-		return errors.Wrapf(err, ""error when validating recipient's address %s"", tsf.Recipient())
+-	}
+-	return nil
++
++	return tsf.SelfCheck()
+ }",is this already called by actPool.validate()?,This check is redundant now.
+6726,"@@ -707,6 +707,16 @@ void updateStereoBonds(RWMOL_SPTR product, const ROMol &reactant,
+
+       if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) {
+         pBond->setStereo(Bond::BondStereo::STEREONONE);
++      } else {
++        // Ring bonds shouldn't be marked as STEREOANY
++
++        if (!product->getRingInfo()->isInitialized()) {
++          MolOps::findSSSR(*product);
++        }
++
++        if (product->getRingInfo()->numBondRings(pBond->getIdx()) > 0) {
++          pBond->setStereo(Bond::BondStereo::STEREONONE);
++        }
+       }
+
+       continue;","It is relatively cheap to tell whether a bond is a ring bond, we don't have to perform an SSSR.",@jcotela is this really the right way to do this?
+6727,"@@ -18,7 +18,7 @@ const (
+ 	nameFlag    = ""name""
+ 	svcFlag     = ""svc""
+ 	envFlag     = ""env""
+-	appTypeFlag = ""app-type""
++	svcTypeFlag = ""svc-type""
+ 	profileFlag = ""profile""
+ 	yesFlag     = ""yes""
+ 	jsonFlag    = ""json""",Maybe we should add flag aliases for service as well.,can we also change the appTypeFlag to svcType?
+6728,"@@ -31,10 +31,7 @@ type Block struct {
+ 	Ticket Ticket `json:""ticket""`
+
+ 	// ElectionProof is the vrf proof giving this block's miner authoring rights
+-	ElectionProof crypto.VRFPi
+-
+-	// EPoStInfo wraps all data for verifying this block's Election PoSt
+-	EPoStInfo EPoStInfo `json:""ePoStInfo""`
++	ElectionProof crypto.ElectionProof
+
+ 	// DrandEntries contain the verifiable oracle randomness used to elect
+ 	// this block's author leader","This LGTM but don't we need a winning PoSts field to fully implement the protocol? No need to add here as I'm working on this in another PR, but curious how we can interop with lotus blocks without post proofs.",Why was this removed?
+6729,"@@ -12,3 +12,10 @@ import ""github.com/iotexproject/iotex-core/blockchain/block""
+ type BlockCreationSubscriber interface {
+ 	ReceiveBlock(*block.Block) error
+ }
++
++// pubSub includes Subscriber, buffered channel for storing the pending blocks and cancel channel to end the handler thread
++type pubSub struct {
++	Blocklistener       BlockCreationSubscriber
++	BlocklistenerBuffer chan *block.Block
++	BlocklistenerCancel chan interface{}
++}","can you move the [] into pubSub? so Blockchain just contains a pubSub, not []",Do we still need this
+6730,"@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 100);
++
++    validateMemoryBreakerThreshold();
+
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ","I don't think 100 is a safe default here, since later we check that the value is between 50-95.",This should be `getBo
+6731,"@@ -49,5 +49,9 @@ namespace NLog.Layouts
+         /// Layout renderer method can handle concurrent threads
+         /// </summary>
+         ThreadSafe = 1,
++        /// <summary>
++        /// Layout renderer method is agnostic to current thread context
++        /// </summary>
++        ThreadAgnostic = 2 | ThreadSafe,
+     }
+ }","I would be nice if we could describe this without the word ""agnostic""",So this means that th
+6732,"@@ -406,6 +406,16 @@ class KNNClassifier(object):
+       print ""  active inputs:"", _labeledInput(inputPattern,
+                                               cellsPerCol=self.cellsPerCol)
+
++    if isSparse > 0:
++      isSorted = all(inputPattern[i] <= inputPattern[i+1]
++                     for i in xrange(len(inputPattern)-1))
++      if not isSorted:
++        raise RuntimeError(""Sparse inputPattern must be sorted."")
++
++      if not all(bit < isSparse for bit in inputPattern):
++        raise RuntimeError(""Sparse inputPattern contains an index outside of""
++                           ""the dense representation's bounds."")
++
+     if rowID is None:
+       rowID = self._iterationIdx
+ ",Pick more specific exception types for these cases. Not sure what would be best for this one (`ValueError`?) but the next one could be `IndexError`.,"""Sparse inputPattern contains an index outside of the dense representation's bounds""?"
+6733,"@@ -0,0 +1,6 @@
++const jestConfig = require( './jest.config' );
++
++module.exports = {
++	...jestConfig,
++	testMatch: [ '<rootDir>/.storybook/?(*.)test.js' ],
++};",This seemed like the easiest solution We need to include this path in `testMatch` to run the test AFAIK *BUT* we don't want this test ran when running them all normally I'm sure there are other ways to do this!,"@jridgewell I'm not sure if this is the best way to do this, but I'm open to suggesti"
+6734,"@@ -114,7 +114,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation.Tests
+
+             var ex = Assert.Throws<TTransportException>(() => transport.Flush());
+
+-            Assert.Equal(""Cannot flush closed transport. message, yo"", ex.Message);
++            Assert.Equal(""Cannot flush closed transport"", ex.Message);
+         }
+
+         [Fact]",Most of the following test changes can be avoided if need be.,Do you know what was wrong with the existing test?
+6735,"@@ -181,14 +181,8 @@ int Partitioner::Run(const PartitionConfig &config)
+     TIMER_STOP(packed_mlp);
+     util::Log() << ""MultiLevelPartition constructed in "" << TIMER_SEC(packed_mlp) << "" seconds"";
+
+-    TIMER_START(cell_storage);
+-    CellStorage storage(mlp, *edge_based_graph);
+-    TIMER_STOP(cell_storage);
+-    util::Log() << ""CellStorage constructed in "" << TIMER_SEC(cell_storage) << "" seconds"";
+-
+     TIMER_START(writing_mld_data);
+     io::write(config.mld_partition_path, mlp);
+-    io::write(config.mld_storage_path, storage);
+     TIMER_STOP(writing_mld_data);
+     util::Log() << ""MLD data writing took "" << TIMER_SEC(writing_mld_data) << "" seconds"";
+ ",Eventually we might want to move this back as generating this data structure takes some time (for large datasets) and we don't want it in the hot-path of `osrm-customize` runs. Thinking long-term making `osrm-customize` eventually digest `.osrm.cells` will will enable only updating cells selectively and using an earlier customization for the rest.,Why remove this? Is it related to this PR?
+6736,"@@ -110,8 +110,15 @@ func (cmd *CommandRun) Wait() error {
+ 	return cmd.vpnServer.Wait()
+ }
+
+-func (cmd *CommandRun) Kill() {
++func (cmd *CommandRun) Kill() (err error) {
+ 	cmd.vpnServer.Stop()
+-	cmd.dialogWaiter.Stop()
+-	cmd.natService.Stop()
++	err = cmd.dialogWaiter.Stop()
++	if err != nil {
++		return err
++	}
++	err = cmd.natService.Stop()
++	if err != nil {
++		return err
++	}
++	return nil
+ }",You're not really using named result variable - you can just leave `error`.,I think this should be `return err`
+6737,"@@ -37,16 +37,14 @@ public class SortOrderUtil {
+   }
+
+   public static SortOrder buildSortOrder(Table table) {
+-    return buildSortOrder(table.spec(), table.sortOrder());
++    return buildSortOrder(table.schema(), table.spec(), table.sortOrder());
+   }
+
+-  public static SortOrder buildSortOrder(PartitionSpec spec, SortOrder sortOrder) {
++  public static SortOrder buildSortOrder(Schema schema, PartitionSpec spec, SortOrder sortOrder) {
+     if (sortOrder.isUnsorted() && spec.isUnpartitioned()) {
+       return SortOrder.unsorted();
+     }
+
+-    Schema schema = spec.schema();
+-
+     Multimap<Integer, SortField> sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);
+
+     // build a sort prefix of partition fields that are not already in the sort order",It wasn't possible to call this method with `PartitionSpec.unpartitioned()` as the schema in the spec was empty.,nit: this variable can be removed?
+6738,"@@ -26,11 +26,13 @@ use Thelia\Exception\ModuleException;
+ use Thelia\Log\Tlog;
+ use Thelia\Model\Cart;
+ use Thelia\Model\Country;
++use Thelia\Model\Hook;
+ use Thelia\Model\HookQuery;
+ use Thelia\Model\Lang;
+ use Thelia\Model\Map\ModuleImageTableMap;
+ use Thelia\Model\Map\ModuleTableMap;
+ use Thelia\Model\Module;
++use Thelia\Model\ModuleConfigQuery;
+ use Thelia\Model\ModuleI18n;
+ use Thelia\Model\ModuleI18nQuery;
+ use Thelia\Model\ModuleImage;",this namespace is never used,Shouldn't this be `HookQuery`?
+6739,"@@ -26,6 +26,13 @@
+ // see URLOpener.
+ // See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
++// Message Delivery Semantics
++//
++// AWS SNS and SQS combine to support at-least-once semantics; applications must
++// call Message.Ack/Nack after processing a message, or it will be redelivered.
++// See https://godoc.org/gocloud.dev/pubsub#hdr-At_most_once_and_At_least_once_Delivery
++// for more background.
++//
+ // Escaping
+ //
+ // Go CDK supports all UTF-8 strings; to make this work with providers lacking","Well, if you call `Nack`, it _will_ be redelivered. So maybe reword.",Would you mind adding a link to the
+6740,"@@ -7,7 +7,9 @@
+
+ <div class=""text-box-wrapper"">
+   <div class=""text-box"">
+-    <p class=""videowrapper""><%= wistia_video_embed('39245f55fd') %></p>
++    <p class=""videowrapper"">
++      <iframe allowtransparency=""true"" class=""wistia_embed"" frameborder=""0"" height=""367"" name=""wistia_embed"" scrolling=""no"" src=""https://fast.wistia.com/embed/iframe/39245f55fd?videoWidth=653&videoHeight=367&controlsVisibleOnLoad=true"" width=""653""></iframe>
++    </p>
+     <h3>An interview with a Ruby developer who uses Linux and full Open Source stack</h3>
+
+     <div class='assets'>",Why did we make this a static string?,does it make sense to add a `<%= wistia_embed('39245f55fd') %>` to each of these?
+6741,"@@ -148,7 +148,7 @@ def bigquery_dataset(item):
+     parent = item.parent()
+     name = '//bigquery.googleapis.com/projects/{}/datasets/{}'.format(
+         parent['projectNumber'], item['datasetReference']['datasetId'])
+-    asset_type = 'google.bigquery.Dataset'
++    asset_type = 'google.cloud.bigquery.Dataset'
+     parent_name = '//cloudresourcemanager.googleapis.com/projects/{}'.format(
+         parent['projectNumber'])
+     return _create_asset(name, asset_type, parent_name, item.data(), None)",Please re-run PYTHONPATH=. python tests/services/inventory/update_cai_dumps.py following the instructions at the top of this file to ensure the test files have the correct CAI asset type.,I am assuming this was a copy/paste error?
+6742,"@@ -66,9 +66,9 @@ func TestCreateContract(t *testing.T) {
+ 	addr := identityset.Address(28)
+ 	_, err = accountutil.LoadOrCreateAccount(sm, addr.String())
+ 	require.NoError(err)
+-	stateDB := NewStateDBAdapter(sm, 0, !cfg.Genesis.IsAleutian(0),
+-		cfg.Genesis.IsGreenland(0), cfg.Genesis.IsKamchatka(0),
+-		cfg.Genesis.IsLordHowe(0), hash.ZeroHash256)
++	opt := []StateDBAdapterOption{NotFixTopicCopyBugOption()}
++	stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, opt...)
++
+ 	contract := addr.Bytes()
+ 	var evmContract common.Address
+ 	copy(evmContract[:], contract[:])","`stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, NotFixTopicCopyBugOption())`",Why is it safe to remove the `IsAleutian` check?
+6743,"@@ -446,8 +446,17 @@ class HintManager(QObject):
+         # Short hints are the number of hints we can possibly show which are
+         # (needed - 1) digits in length.
+         if needed > min_chars:
+-            short_count = math.floor((len(chars) ** needed - len(elems)) /
+-                                     len(chars))
++            total_space = len(chars) ** needed
++            # Calculate short_count naively, by finding the avaiable space and
++            # dividing by the number of spots we would loose by adding a
++            # short element
++            short_count = math.floor((total_space - len(elems)) /
++                                     (len(chars)))
++            # Check if we double counted above to warrant another short_count
++            # https://github.com/qutebrowser/qutebrowser/issues/3242
++            if total_space - (short_count * len(chars) +
++                              (len(elems) - short_count)) >= len(chars) - 1:
++                short_count += 1
+         else:
+             short_count = 0
+ ","There are unneeded parens here, but I'll fix it up when merging.",This should be `(total_space - short_count) / len(chars)`
+6744,"@@ -62,6 +62,12 @@ static void setup_globals(mrb_state *mrb)
+
+     h2o_mruby_eval_expr(mrb, ""$LOAD_PATH << \""#{$H2O_ROOT}/share/h2o/mruby\"""");
+     h2o_mruby_assert(mrb);
++
++    /* require and include built-in libraries */
++    h2o_mruby_eval_expr(mrb, ""require \""h2o.rb\""\n""
++                             ""require \""acl.rb\""\n""
++                             ""include H2O::ACL\n"");
++    h2o_mruby_assert(mrb);
+ }
+
+ mrb_value h2o_mruby_to_str(mrb_state *mrb, mrb_value v)",Just one more thing... How about doing all of the following? 1. renaming h2o.rb to bootstrap.rb 2. require and include the acl code _from_ bootstrap.rb,(style) code indent should use tabs where possible
+6745,"@@ -82,14 +82,6 @@ double get_timestamp (void)
+     return ((double) tm.tv_sec + (tm.tv_nsec/1.0e9));
+ }
+
+-static void timeout_cb (flux_t *h, cron_task_t *t, void *arg)
+-{
+-    cron_entry_t *e = arg;
+-    flux_log (h, LOG_INFO, ""cron-%ju: task timeout at %.2fs. Killing"",
+-              e->id, e->timeout);
+-    cron_task_kill (t, SIGTERM);
+-}
+-
+ static int cron_entry_run_task (cron_entry_t *e)
+ {
+     flux_t *h = e->ctx->h;","Commit message: ""remove"" is misspelled.",Are you sure you want to remove this?
+6746,"@@ -60,6 +60,11 @@ public abstract class BytesValues {
+     return value.slice(toTrim);
+   }
+
++  public static BytesValue trimTrailingZeros(final BytesValue value) {
++    final int toTrim = trailingZeros(value);
++    return value.slice(0, value.size() - toTrim + 1);
++  }
++
+   /**
+    * Returns the smallest bytes value whose bytes correspond to the provided long. That is, the
+    * returned value may be of size less than 8 if the provided int has leading zero bytes.",This is a pretty idiosyncratic method - I'd move it into the JSON-RPC package rather than adding it to `BytesValue`.,nit: consider moving the method into `BytesValue.t
+6747,"@@ -424,11 +424,15 @@ module RSpec
+           superclass.method(:next_runnable_index_for),
+           description, *args, &example_group_block
+         )
++
++        config = RSpec.configuration
++        config.apply_derived_metadata_to(@metadata)
++
+         ExampleGroups.assign_const(self)
+
+         @currently_executing_a_context_hook = false
+
+-        RSpec.configuration.configure_group(self)
++        config.configure_group(self)
+       end
+
+       # @private",Is there a way to deduplicate this somehow? Could we roll it into `RSpec.configuration` with a bit of memoization or is there a chicken and egg problem.,What happens if this adds `config = RSpec.configur
+6748,"@@ -49,6 +49,7 @@ public class ResultSetPropertyTester extends PropertyTester
+     public static final String PROP_CAN_NAVIGATE_HISTORY = ""canNavigateHistory"";
+     public static final String PROP_EDITABLE = ""editable"";
+     public static final String PROP_CHANGED = ""changed"";
++    private static final String PROP_UPDATE_NOT_IN_PROGRESS = ""updateNotInProgress"";
+
+     private static final Log log = Log.getLog(ResultSetPropertyTester.class);
+ ","Generally, I wouldn't say I like the idea of providing properties that return negative/inverted values. It would be more convenient to return whether the update is **in** progress or not.","Isn't there a test case for the ""update not in progress"" property?"
+6749,"@@ -256,7 +256,7 @@ import 'flexStyles';
+             const runtimeTicks = playbackManager.duration(options.player);
+
+             if (runtimeTicks) {
+-                const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player);
++                const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player) * 10000;
+
+                 return Math.round(timeRemainingTicks / 10000);
+             }","Converting playbackManager to operate in ms (preferred solution, imo) would allow us to completely drop this function.","Instead of doing this, let's just do a `Math.round(timeRemainingTi"
+6750,"@@ -8,6 +8,7 @@
+
+ DEFINE_int32(max_handlers_per_req, 10, ""The max handlers used to handle one request"");
+ DEFINE_int32(min_vertices_per_bucket, 3, ""The min vertices number in one bucket"");
++DEFINE_int32(max_edge_returned_per_vertex, 1000, ""The max edge number returnred searching vertex"");
+
+ namespace nebula {
+ namespace storage {","The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc.",`returned` -> `returned`
+6751,"@@ -221,7 +221,10 @@ func (c *cliApp) settle(args []string) {
+ 		clio.Info(fmt.Sprintf(""Hermes fee: %v MYST"", hermesFee.String()))
+ 		return
+ 	}
+-	hermesID := c.config.GetStringByFlag(config.FlagHermesID)
++	hermesID, err := c.config.GetHermesID()
++	if err != nil {
++		clio.Warn(""could not get hermes id: "", err)
++	}
+ 	clio.Info(""Waiting for settlement to complete"")
+ 	errChan := make(chan error)
+ ",Probably missing return here as well,Could we get rid of the `hermesID` variable and use `c.config.GetH
+6752,"@@ -109,6 +109,12 @@ type ConfigSettings struct {
+ 	//
+ 	// EXPERIMENTAL: Subject to change.
+ 	LoadRaw json.RawMessage `json:""load,omitempty"" caddy:""namespace=caddy.config_loaders inline_key=module""`
++
++	// The interval to pull config. With a non-zero value, will pull config
++	// from config loader (eg. a http loader) with given interval.
++	//
++	// EXPERIMENTAL: Subject to change.
++	PullInterval Duration `json:""pull_interval,omitempty""`
+ }
+
+ // IdentityConfig configures management of this server's identity. An identity","On second thought... this affects how often the function specified by the `load` property is run. So I wonder if, for consistency, we should call this `LoadInterval` instead. Does that make sense?",Why is this optional? I don't see it being used in this PR.
+6753,"@@ -2,7 +2,8 @@ var exported = {},
+     common = require('../../../api/utils/common.js'),
+     crypto = require('crypto'),
+     countlyCommon = require('../../../api/lib/countly.common.js'),
+-    plugins = require('../../pluginManager.js');
++    plugins = require('../../pluginManager.js'),
++    localize = require('../../../api/utils/localization.js');
+ (function() {
+     /**
+      *    register internalEvent",Now you don't need the localization module here then :),can we call this `localize` or something more descriptive?
+6754,"@@ -264,11 +264,16 @@ public class InclusiveMetricsEvaluator {
+
+     @Override
+     public <T> Boolean in(BoundReference<T> ref, Set<T> literalSet) {
+-      return ROWS_MIGHT_MATCH;
++      // in(col, {X, Y}) => eq(col, x) OR eq(col, x)
++      if (literalSet.stream().anyMatch(v -> eq(ref, toLiteral(v)))) {
++        return ROWS_MIGHT_MATCH;
++      }
++      return ROWS_CANNOT_MATCH;
+     }
+
+     @Override
+     public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {
++      // notIn(col, {X, Y}) => notEq(col, x) AND notEq(col, x)
+       return ROWS_MIGHT_MATCH;
+     }
+ ","This should not convert each value to a literal on every invocation. Instead, this PR can add a `literals` method to `BoundSetPredicate` to access the values as literals. That way, the conversion happens once and can be lazy.",would it be simpler to just return ROWS_MIGHT_MATCH ?
+6755,"@@ -22,7 +22,7 @@ def _load_lib():
+     """"""Load LightGBM Library.""""""
+     lib_path = find_lib_path()
+     if len(lib_path) == 0:
+-        raise Exception(""cannot find LightGBM library"")
++        return None
+     lib = ctypes.cdll.LoadLibrary(lib_path[0])
+     lib.LGBM_GetLastError.restype = ctypes.c_char_p
+     return lib",I think we still need this exception if doesn't have LIGHTGBM_BUILD_DOC,Shouldn't we just return an empty array instead?
+6756,"@@ -71,15 +71,9 @@ func (h *Helper) waitForCertificateCondition(client clientset.CertificateInterfa
+ 	if pollErr != nil && certificate != nil {
+ 		log.Logf(""Failed waiting for certificate %v: %v\n"", name, pollErr.Error())
+
+-		if len(certificate.Status.Conditions) > 0 {
+-			log.Logf(""Observed certificate conditions:\n"")
+-			for _, cond := range certificate.Status.Conditions {
+-				log.Logf(""- Last Status: '%s' Reason: '%s', Message: '%s'\n"", cond.Status, cond.Reason, cond.Message)
+-			}
+-		}
++		log.Logf(""Certificate:\n"")
++		h.describeCMObject(certificate)
+
+-		log.Logf(""Certificate description:\n"")
+-		h.Kubectl(certificate.Namespace).DescribeResource(""certificate"", name)
+ 		log.Logf(""Order and challenge descriptions:\n"")
+ 		h.Kubectl(certificate.Namespace).Describe(""order"", ""challenge"")
+ ",Does this make it easier to read? Previously this would have run `kubectl describe certificate` right? In which case it would have included events related to the cert. Will we miss that? Would the old `kubectl describe` output have gone to stderr?,`describeCMObject` calls for `certificate.Spec.Certificate` which contains the `Certificate` resource.
+6757,"@@ -24,11 +24,14 @@ import com.google.gson.annotations.SerializedName;
+ public class Internals {
+
+   public static final String SERIALIZED_APPLICATION_SERVER = ""application-server"";
++  public static final String SERIALIZED_CAMUNDA_INTEGRATION = ""camunda-integration"";
+
+   protected Database database;
+   @SerializedName(value = SERIALIZED_APPLICATION_SERVER)
+   protected ApplicationServer applicationServer;
+   protected Map<String, Command> commands;
++  @SerializedName(value = SERIALIZED_CAMUNDA_INTEGRATION)
++  protected Map<String, Object> camundaIntegration;
+
+   protected Map<String, Metric> metrics;
+ ","Just an understanding question: do we need a map here, would a list/set of Strings be sufficient? we are not adding entries with `false` here, are we? Being in the list already means it's used, right?",Why is this needed?
+6758,"@@ -567,7 +567,8 @@ class CentralPlannerScheduler(Scheduler):
+
+         for task in self._state.get_active_tasks():
+             self._state.fail_dead_worker_task(task, self._config, assistant_ids)
+-            if task.id not in necessary_tasks and self._state.prune(task, self._config):
++            removed = self._state.prune(task, self._config)
++            if removed and task.id not in necessary_tasks:
+                 remove_tasks.append(task.id)
+
+         self._state.inactivate_tasks(remove_tasks)","Ah, so the change is that you want the `prune()` side effect before doing the `task.id not in necessary_tasks` membership check? Stupid non-Haskell programming languages :p","Since the task is removed in the `necessary_tasks` list, the `task.id not in necessary_tasks` check ca"
+6759,"@@ -2,6 +2,13 @@ package cmd
+
+ import (
+ 	""fmt""
++	""os""
++	osexec ""os/exec""
++	""path/filepath""
++	""strings""
++	""testing""
++	""time""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.,`os/exec` should be `os/os/exec`
+6760,"@@ -494,6 +494,8 @@ function findAndModify(coll, query, sort, doc, options, callback) {
+     queryObject.bypassDocumentValidation = finalOptions.bypassDocumentValidation;
+   }
+
++  finalOptions.readPreference = ReadPreference.primary;
++
+   // Have we specified collation
+   decorateWithCollation(queryObject, coll, finalOptions);
+ ",Do we normally force ReadPreference primary on other write operations? Or is it just that we normally ignore it?,Shouldn't this be finalOptions.readPreference = ReadPreference.primary;
+6761,"@@ -292,6 +292,12 @@ public class Spark3Util {
+             return Expressions.hours(sourceName);
+           }
+
++          @Override
++          public Transform alwaysNull(int fieldId, String sourceName, int sourceId) {
++            // do nothing for alwaysNull, it doesn't need to be converted to a transform
++            return null;
++          }
++
+           @Override
+           public Transform unknown(int fieldId, String sourceName, int sourceId, String transform) {
+             return Expressions.apply(transform, Expressions.column(sourceName));","Instead of returning null here and discarding nulls automatically, I think this should return null (or some other signaling value) and fix the part that consumes the output of the visitor.",How is this different from what was done before?
+6762,"@@ -95,8 +95,13 @@ public class ForkingValidatorProvider implements ValidatorProvider {
+         final long prevBlockNumber = blockNumber - 1L;
+         final Optional<BlockHeader> prevBlockHeader = blockchain.getBlockHeader(prevBlockNumber);
+         if (prevBlockHeader.isPresent()) {
+-          return resolveValidatorProvider(prevBlockNumber)
+-              .getValidatorsForBlock(prevBlockHeader.get());
++          final Collection<Address> validatorsForPreviousBlock =
++              resolveValidatorProvider(prevBlockNumber)
++                  .getValidatorsForBlock(prevBlockHeader.get());
++          // Update VoteTallyCache
++          blockValidatorProvider.setValidatorsForBlock(
++              prevBlockHeader.get(), validatorsForPreviousBlock);
++          return validatorsForPreviousBlock;
+         }
+       }
+       return getValidators.apply(validatorProvider);","Really, we want to be setting the validatorsForPreviousBlock against the yet to be created block, so it might make sense to update the cache once the block is created/imported instead.","If the block is not present, then the validator is not in the cache. Is"
+6763,"@@ -60,11 +60,11 @@ int set_properties_from_args(fpga_properties filter, fpga_result *result,
+ 		{""segment"", required_argument, NULL, 0xe},
+ 		{0, 0, 0, 0},
+ 	};
+-	int supported_options = sizeof(longopts) / sizeof(longopts[0]) - 1;
+ 	int getopt_ret = -1;
+ 	int option_index = 0;
+ 	char *endptr = NULL;
+ 	int found_opts[] = {0, 0, 0, 0};
++	int supported_options = sizeof(found_opts) / sizeof(int);
+ 	int next_found = 0;
+ 	int old_opterr = opterr;
+ 	opterr = 0;",It seems to me that the original implementation was correct. Can you share what the scanner was pointing out?,(style) line over 80 characters
+6764,"@@ -178,6 +178,8 @@ function* webpackConfig( env, argv ) {
+ 				'./assets/js/googlesitekit-modules-search-console.js',
+ 			'googlesitekit-modules-subscribe-with-google':
+ 				'./assets/js/googlesitekit-modules-subscribe-with-google.js',
++			'googlesitekit-subscribe-with-google-bulk-edit':
++				'./assets/js/modules/subscribe-with-google/bulk-edit.js',
+ 			'googlesitekit-modules-tagmanager':
+ 				'./assets/js/googlesitekit-modules-tagmanager.js',
+ 			'googlesitekit-user-input':","Instead of doing that, please create an `assets/js/googlesitekit-subscribe-with-google-bulk-edit.js` file as entry point - all our entry points should be located in `assets/js`.",I think you can remove `./assets/js/modules/subscribe-with-google/bulk-edit.js`
+6765,"@@ -39,7 +39,11 @@ storiesOf( 'WordPress', module )
+ 			<div id=""dashboard-widgets"">
+ 				<div className=""metabox-holder"">
+ 					<div id=""google_dashboard_widget"" className=""postbox"">
+-						<h2 className=""hndle ui-sortable-handle""><span><SvgIcon id=""logo-g"" height=""19"" width=""19"" /><SvgIcon id=""logo-sitekit"" height=""17"" width=""78"" /></span>
++						<h2 className=""hndle ui-sortable-handle"">
++							<span><div className=""googlesitekit-logo googlesitekit-logo-mini"">
++								<SvgIcon id=""logo-g"" height=""19"" width=""19"" />
++								<SvgIcon id=""logo-sitekit"" height=""17"" width=""78"" />
++							</div></span>
+ 						</h2>
+ 						<div className=""inside"">
+ 							<div id=""js-googlesitekit-wp-dashboard"">","This is not valid, a `div` shouldn't be in a `span`. You could apply the `className` attribute to the `span` tag.",Could you add a `>` to the end of this line?
+6766,"@@ -100,6 +100,8 @@ func AddFlags(flagSet *pflag.FlagSet) {
+ 	flags.IntVarP(flagSet, &fs.Config.MultiThreadStreams, ""multi-thread-streams"", """", fs.Config.MultiThreadStreams, ""Max number of streams to use for multi-thread downloads."")
+ 	flags.DurationVarP(flagSet, &fs.Config.RcJobExpireDuration, ""rc-job-expire-duration"", """", fs.Config.RcJobExpireDuration, ""expire finished async jobs older than this value"")
+ 	flags.DurationVarP(flagSet, &fs.Config.RcJobExpireInterval, ""rc-job-expire-interval"", """", fs.Config.RcJobExpireInterval, ""interval to check for expired async jobs"")
++	flags.DurationVarP(flagSet, &fs.Config.TransferredExpireDuration, ""accounting-transferred-expire-duration"", """", fs.Config.TransferredExpireDuration, ""remove transferred accounting stats older than this value"")
++	flags.DurationVarP(flagSet, &fs.Config.TransferredExpireInterval, ""accounting-transferred-expire-interval"", """", fs.Config.TransferredExpireInterval, ""interval to check for expired transferred accounting stats"")
+ }
+
+ // SetFlags converts any flags into config which weren't straight forward",Would it be possible to reuse RcJobExpireDuration and RcJobExpireInterval and auto delete them when job is deleted?,"This help message could be slightly improved: ""Remove transferred accounting st"
+6767,"@@ -18,7 +18,13 @@
+ #  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ #  THE SOFTWARE.
+
++from __future__ import print_function
++
+ import copy
++import sys
++
++from jinja2 import Environment
++from jinja2 import PackageLoader
+
+
+ def merge_dicts(a, b, raise_conflicts=False, path=None):",Python wants **future** imports to come first.,Is this still necessary?
+6768,"@@ -2267,4 +2267,5 @@ detach_on_permanent_stack(bool internal, bool do_cleanup, dr_stats_t *drstats)
+     SELF_PROTECT_DATASEC(DATASEC_RARELY_PROT);
+     dynamo_detaching_flag = LOCK_FREE_STATE;
+     EXITING_DR();
++    options_detach();
+ }",Better to call this before EXITING_DR which is supposed to be last.,Can you explain why this is needed? The options_detach() should be called after the dynamo_detaching_state() is set to RUNNING_ONCE.
+6769,"@@ -295,8 +295,6 @@ public class MainActivity extends BaseActivity implements CustomTabActivityHelpe
+                     switch ((int) drawerItem.getIdentifier()) {
+                         case ITEM_HOME:
+                             fragment = new HomeFragment();
+-                            // recreate when Home is pressed
+-                            recreate();
+                             break;
+                         case ITEM_SEARCH_BY_CODE:
+                             fragment = new FindProductFragment();",Does this work at runtime?,Why remove this?
+6770,"@@ -24,8 +24,9 @@ import (
+ const (
+ 	userAgentHeader = ""User-Agent""
+
+-	credsTimeout  = 10 * time.Second
+-	clientTimeout = 30 * time.Second
++	maxRetriesOnRecoverableFailures = 8 // Default provided by SDK is 3 which means requests are retried up to only 2 seconds.
++	credsTimeout                    = 10 * time.Second
++	clientTimeout                   = 30 * time.Second
+ )
+
+ // Provider provides methods to create sessions.",Hmm why do we need to make this change? Like which one requires this change?,I think this constant should live in `pkg/retry` since it's used by both SDK and SDK.
+6771,"@@ -4,12 +4,6 @@
+ // Use define from require.js not webpack's define
+ var _define = window.define;
+
+-// document-register-element
+-var docRegister = require(""document-register-element"");
+-_define(""document-register-element"", function() {
+-    return docRegister;
+-});
+-
+ // fetch
+ var fetch = require(""whatwg-fetch"");
+ _define(""fetch"", function() {",why remove this and other piece?,why is this removed?
+6772,"@@ -41,7 +41,7 @@ describe('dom.hasContentVirtual', function() {
+ 	it('is false if the element has an aria label but `ignoreAria=true`', function() {
+ 		fixture.innerHTML = '<div id=""target"" aria-label=""my-label"">	</div>';
+ 		tree = axe.utils.getFlattenedTree(fixture);
+-		assert.isTrue(
++		assert.isFalse(
+ 			hasContentVirtual(
+ 				axe.utils.querySelectorAll(tree, '#target')[0],
+ 				true,",Yikes... That was probably me.,Is this a breaking change?
+6773,"@@ -622,7 +622,7 @@ class Application extends BaseApplication {
+
+ 		// the following menu items will be available for all OS under Tools
+ 		const toolsItemsAll = [{
+-			label: _('Resources'),
++			label: _('Note attachments...'),
+ 			click: () => {
+ 				this.dispatch({
+ 					type: 'NAV_GO',",It would be better to move the ... outside of the l8n block. This way it won't need to be translated for each language twice.,I think `Resources` is mor
+6774,"@@ -35,6 +35,11 @@
+ #include ""monster.h""
+ #include ""scheduler.h""
+ #include ""databasetasks.h""
++#include ""actions.h""
++#include ""movement.h""
++#include ""weapons.h""
++#include ""globalevent.h""
++#include ""events.h""
+
+ extern Chat* g_chat;
+ extern Game g_game;",That's a huge load of new dependencies. I think it's better to create a reload function on ScriptManager and control with enum instead.,revert this please
+6775,"@@ -42,6 +42,7 @@ func NewJob() *cobra.Command {
+ 		NewUpgradeJivaVolumeJob(),
+ 		NewUpgradeCStorSPCJob(),
+ 		NewUpgradeCStorVolumeJob(),
++		NewUpgradeTaskJob(),
+ 	)
+
+ 	cmd.PersistentFlags().StringVarP(&options.fromVersion,",`NewUpgradeTaskJob` -> `NewUpgradeResource`,What do we do if we're not
+6776,"@@ -0,0 +1,16 @@
++#include ""system.h""
++
++#include <glibtop.h>
++#include <glibtop/mem.h>
++
++#include <glib.h>
++#include <unistd.h>
++
++int luaA_sys_get_meminfo(lua_State *L)
++{
++    glibtop_mem mem;
++    glibtop_init();
++    glibtop_get_mem(&mem);
++    lua_pushinteger(L, mem.cached);
++    return 1;
++}",Is that the memory usage of the system or the process / awesome?,Please add a license header.
+6777,"@@ -209,8 +209,8 @@ class Realm {
+     /**
+      * Add a listener `callback` for the specified event `name`.
+      * @param {string} name - The name of event that should cause the callback to be called.
+-     *   _Currently, only the ""change"" event supported_.
+-     * @param {callback(Realm, string)} callback - Function to be called when the event occurs.
++     *   _Currently, only the ""change"" or ""schema"" events supported_.
++     * @param {callback(Realm, string)|callback(Realm, Schema)} callback - Function to be called when a change event occurs.
+      *   Each callback will only be called once per event, regardless of the number of times
+      *   it was added.
+      * @throws {Error} If an invalid event `name` is supplied, or if `callback` is not a function.","""change"" *and* ""schema"" events (A bunch of these; not marking them all).","Shouldn't this be `(Realm, s"
+6778,"@@ -73,4 +73,13 @@ public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+    * @return this for method chaining
+    */
+   RewriteFiles validateFromSnapshot(long snapshotId);
++
++  /**
++   * Use the specified sequence number for the new manifest of the data files added in this update,
++   * instead of inheriting the sequence number of the snapshot that will be created.
++   *
++   * @param sequenceNumber a sequence number
++   * @return this for method chaining
++   */
++  RewriteFiles overrideSequenceNumberForNewDataFiles(long sequenceNumber);
+ }","I think there is probably a shorter, more descriptive name for this. Something like `commitAtSequenceNumber`?","Ah, I see what you're doing "
+6779,"@@ -23,6 +23,7 @@ class Organization < ActiveRecord::Base
+   scope :case_insensitive_url_name, ->(mixed_case) { where(['lower(url_name) = ?', mixed_case.downcase]) }
+
+   validates :name, presence: true, length: 3..85, uniqueness: { case_sensitive: false }
++  validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: true, case_sensitive: false
+   validates :description, length: 0..800, allow_nil: true
+   validates :org_type, inclusion: { in: ORG_TYPES.values }
+   before_validation :clean_strings_and_urls",The `url_name` should definitely be more than just 1 character long at the shortest. How about 3 or 4 characters?,Rails/InverseOf: Specify an
+6780,"@@ -22,9 +22,6 @@
+ *  This copyright notice MUST APPEAR in all copies of the script!
+ ***************************************************************/
+
+-use TYPO3\CMS\Core\Utility\GeneralUtility;
+-use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
+-
+
+ /**
+  * Page Indexer to index TYPO3 pages used by the Index Queue.",Please revert this change,Why did you remove these usings?
+6781,"@@ -57,13 +57,10 @@ module OrgAdmin
+     # preview a phase
+     # GET /org_admin/phases/[:id]/preview
+     def preview
+-      phase = Phase.includes(:template).find(params[:id])
+-      authorize phase
+-      render(""/org_admin/phases/preview"",
+-        locals: {
+-          template: phase.template,
+-          phase: phase
+-        })
++      @phase = Phase.includes(:template).find(params[:id])
++      authorize @phase
++      @template = @phase.template
++      @guidance_presenter = GuidancePresenter.new(Plan.new(template: @phase.template))
+     end
+
+     # add a new phase to a passed template",Nice. I hadn't even heard of presenters in Rails before (learn something new every day) :),should this be `@template = @pha
+6782,"@@ -22,10 +22,19 @@ class Pool
+      */
+     protected $providers = array();
+
++    /**
++     * @var array
++     */
+     protected $contexts = array();
+
++    /**
++     * @var DownloadStrategyInterface[]
++     */
+     protected $downloadSecurities = array();
+
++    /**
++     * @var string
++     */
+     protected $defaultContext;
+
+     /**","`string[]` ? not sure, can you verify this @core23 ? Thank you",`array[]` would be better than `
+6783,"@@ -1224,12 +1224,14 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+             return null;
+         }
+
++        let playPauseClickTimeout;
+         function onViewHideStopPlayback() {
+             if (playbackManager.isPlayingVideo()) {
+                 require(['shell'], function (shell) {
+                     shell.disableFullscreen();
+                 });
+
++                clearTimeout(playPauseClickTimeout);
+                 var player = currentPlayer;
+                 view.removeEventListener(""viewbeforehide"", onViewHideStopPlayback);
+                 releaseCurrentPlayer();",are we aware that this breaks older browsers like WebOS? :) they don't handle `let`,Do you also need to add this to
+6784,"@@ -86,7 +86,7 @@ class Cache(CacheBase):
+         if ttl == 0:
+             self.delete(key)
+         else:
+-            # We can't use touch here because we need to update the TTL value in the record.
++            # We can't use touch here because we need to update the TTL value in the object.
+             value = self.get(key)
+             self.set(key, value, ttl)
+ ",This isn't really a Kinto record but a Memcached record. I could kind of go either way on this.,object -> **the** object
+6785,"@@ -582,6 +582,7 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+                     displayName(accountOptions.displayName).email(accountOptions.email).
+                     photoUrl(accountOptions.photoUrl).thumbnailUrl(accountOptions.thumbnailUrl).
+                     additionalOauthValues(accountOptions.additionalOauthValues).build();
++            account.downloadProfilePhoto();
+             if (id.customAttributes != null) {
+                 mgr.getAdminSettingsManager().setPrefs(id.customAttributes, account);
+             }",Kick off the download after login.,downloadProfilePhoto() s
+6786,"@@ -286,7 +286,7 @@ class ErrorBaseline
+         $xml = preg_replace_callback(
+             '/<files (psalm-version=""[^""]+"") (?:php-version=""(.+)""(\/?>)\n)/',
+             /**
+-             * @param array<int, string> $matches
++             * @param string[] $matches
+              */
+             function (array $matches) : string {
+                 return","I don't think you need to change this, `array<int, string>` should be accepted whenever `string[]` is expected. (`string[]` is an alias of `array<string>` itself an alias of `array<array-key, string>` which is a parent type of `array<int, string>`",should be `array[]`
+6787,"@@ -1257,8 +1257,9 @@ bool wlr_seat_touch_has_grab(struct wlr_seat *seat) {
+ }
+
+ bool wlr_seat_validate_grab_serial(struct wlr_seat *seat, uint32_t serial) {
+-	return serial == seat->pointer_state.grab_serial ||
+-		serial == seat->touch_state.grab_serial;
++	return true;
++	//return serial == seat->pointer_state.grab_serial ||
++	//	serial == seat->touch_state.grab_serial;
+ }
+
+ struct wlr_seat_client *wlr_seat_client_from_resource(","TODO: fix this, probably in another PR",Please remove the dead c
+6788,"@@ -591,6 +591,17 @@ class HintManager(QObject):
+             message.error(""No elements found."")
+             return
+
++        # Because _start_cb is called asynchronously, it's possible that the
++        # user switched to another tab or closed the tab/window. In that case
++        # we should not start hinting.
++        tabbed_browser = objreg.get('tabbed-browser', default=None,
++                scope='window', window=self._win_id)
++        if tabbed_browser is None:
++            return
++        tab = tabbed_browser.widget.currentWidget()
++        if tab is None or tab.tab_id != self._tab_id:
++            return
++
+         strings = self._hint_strings(elems)
+         log.hints.debug(""hints: {}"".format(', '.join(strings)))
+ ",Is there any case that tab is None?,Any reason not to just use `self._tab_id`?
+6789,"@@ -132,8 +132,14 @@ func (e *endpoint) Apply(ctx context.Context, req ctrl.Request, chaos v1alpha1.I
+ 			Namespace: pod.Namespace,
+ 		})
+
+-		t.Append(sourceSet)
+-		t.Append(targetSet)
++		e := t.Append(sourceSet)
++		if e != nil {
++			return e
++		}
++		e = t.Append(targetSet)
++		if e != nil {
++			return e
++		}
+ 	}
+
+ 	sourcesChains := []v1alpha1.RawIptables{}",pls use `err` instead of `e`,"`return t.Append(sourceSet, targetSet)`?"
+6790,"@@ -159,7 +159,9 @@ function attachGamepadScript(e) {
+ }
+
+ // No need to check for gamepads manually at load time, the eventhandler will be fired for that
+-window.addEventListener(""gamepadconnected"", attachGamepadScript);
++if (navigator.getGamepads) { /* eslint-disable-line compat/compat */
++    window.addEventListener(""gamepadconnected"", attachGamepadScript);
++}
+
+ export default {
+     enable: enable,",`attachGamepadScript` above can also be placed inside.,"Can we do this at the top of the file, aft"
+6791,"@@ -108,7 +108,7 @@ func decodeBytecode() ([]byte, error) {
+ 	return hex.DecodeString(util.TrimHexPrefix(bytecodeFlag.Value().(string)))
+ }
+
+-func signer() (address string, err error) {
++func Signer() (address string, err error) {
+ 	return util.GetAddress(signerFlag.Value().(string))
+ }
+ ","when we use RegisterWriteCommand,this func should be exported,so we can use this to get signer at the outside action package",Why was this changed?
+6792,"@@ -123,7 +123,7 @@ func (management *Management) serveNewConnection(connection net.Conn) {
+ func (management *Management) deliverLines() {
+ 	for {
+ 		line := <-management.lineReceiver
+-		log.Debug(management.logPrefix, ""Line delivering: "", line)
++		// log.Debug(management.logPrefix, ""Line delivering: "", line)
+
+ 		lineConsumed := false
+ 		for _, middleware := range management.middlewares {",Dead code - we should remove it or use `log.Trace` for lower logging level. Same applies for change at line 138.,What's the purpose of this?
+6793,"@@ -55,6 +55,11 @@ boost::optional<ParameterT> parseParameters(std::string::iterator &iter,
+         // iterator to the failing position. Extract the position from the exception ourselves.
+         iter = failure.first;
+     }
++    catch (const boost::numeric::bad_numeric_cast &e)
++    {
++        // this can happen if we get bad numeric values in the request, just handle
++        // as normal parser error
++    }
+
+     return boost::none;
+ }",How does this make sure invalid coordinates making the parser fail? Relying on the Coordinate type's boost numeric_cast calls in the ctor? Shouldn't we rely on a coordinate's `.IsValid()` member function instead?,Don't we want to return a `
+6794,"@@ -1,8 +1,11 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
+ # This code example demonstrates how to upload an item
+-# (file) to a folder within a bucket in Amazon S3.
++# (file) to a folder within a bucket in Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3-ruby-example-upload-item-to-folder]
+
+ # Prerequisites:
+ #  - An existing Amazon S3 bucket.",Simple Storage **Service**,Trailing whitespace detecte
+6795,"@@ -54,6 +54,8 @@ if (!is_dir($cacheDir)) {
+ // Enable caching unless in dev mode or running tests:
+ $useCache = APPLICATION_ENV != 'development' && !defined('VUFIND_PHPUNIT_RUNNING');
+
++defined('CACHE_ENABLED') || define('CACHE_ENABLED', $useCache);
++
+ // Build configuration:
+ return [
+     'modules' => array_unique($modules),",Does this line (and the corresponding one in the test bootstrap) actually do anything? I don't see where CACHE_ENABLED is used as a global constant.,Why are you using `define`
+6796,"@@ -445,13 +445,14 @@ func assertResolved(f func(target *api.Container, dep *api.Container) bool, targ
+ 	}
+ }
+
+-func TestTransitionDependenciesResolved(t *testing.T) {
++func TestVerifyTransitionDependenciesResolved(t *testing.T) {
+ 	testcases := []struct {
+ 		Name             string
+ 		TargetKnown      api.ContainerStatus
+ 		TargetDesired    api.ContainerStatus
++		TargetNext       api.ContainerStatus
++		DependencyName   string
+ 		DependencyKnown  api.ContainerStatus
+-		DependentStatus  api.ContainerStatus
+ 		SatisfiedStatus  api.ContainerStatus
+ 		ExpectedResolved bool
+ 	}{","has this changed? are we testing ""all possible situations"" now?",Why was this change necessary?
+6797,"@@ -236,13 +236,13 @@ public class SolrCLI implements CLIO {
+           .argName(""HOST"")
+           .hasArg()
+           .required(false)
+-          .desc(""Address of the Zookeeper ensemble; defaults to: ""+ZK_HOST)
++          .desc(""Address of the Zookeeper ensemble; defaults to: ""+ ZK_HOST + '.')
+           .build(),
+       Option.builder(""c"")
+           .argName(""COLLECTION"")
+           .hasArg()
+           .required(false)
+-          .desc(""Name of collection; no default"")
++          .desc(""Name of collection; no default."")
+           .longOpt(""collection"")
+           .build(),
+       Option.builder(""verbose"")",ZK is properly spelled 'ZooKeeper' (capital 'K').,Question: Why do we need this
+6798,"@@ -73,6 +73,8 @@ public class RubyGapicSurfaceTransformer implements ModelToViewTransformer {
+       ImmutableList.of(""GOOGLE_CLOUD_KEYFILE"", ""GCLOUD_KEYFILE"");
+   private static final List<String> DEFAULT_JSON_ENV_VARS =
+       ImmutableList.of(""GOOGLE_CLOUD_KEYFILE_JSON"", ""GCLOUD_KEYFILE_JSON"");
++  private static final List<String> DEFAULT_PATHS =
++      ImmutableList.of(""~/.config/gcloud/application_default_credentials.json"");
+
+   private final GapicCodePathMapper pathMapper;
+   private final PackageMetadataConfig packageConfig;",Guessing this locates the key you get when you run `gcloud auth application-default login`? What was the previous behavior/the behavior for the manual Veneer creds?,I would suggest to make the de
+6799,"@@ -85,7 +85,7 @@
+               entireColumnSelection = [0, selected[1], this.view.wt.wtTable.getRowStrategy().cellCount - 1, selected[1]],
+               columnSelected = entireColumnSelection.join(',') == selected.join(',');
+
+-            return selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected;
++            return selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || (columnSelected && this.countRows() > 1);
+           }
+         },
+         {","looks good to me, but it would be better if you assigned `this.countRows()` into a variable, so it doesn't trigger twice in the return statement",This condition is the same as
+6800,"@@ -1,3 +1,5 @@
++'use strict';
++
+ require('classtool');
+
+ function ClassSpec(b) {","For now, don't add ""use strict"" to any existing files. That's a separate project that we'll do later. (New files can use ""use strict"".)",What is this line for?
+6801,"@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
+ 	// Set up tests and give ourselves a working directory.
+ 	assert := asrt.New(t)
+
++	noninteractive := ""DRUD_NONINTERACTIVE""
++	// nolint: errcheck
++	defer os.Setenv(noninteractive, os.Getenv(noninteractive))
++	err := os.Unsetenv(noninteractive)
++	assert.NoError(err)
++
+ 	testMatrix := map[string][]string{
+ 		""drupal6phpversion"": {AppTypeDrupal6, PHP56},
+ 		""drupal7phpversion"": {AppTypeDrupal7, PHP71},","I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?",This should probably b
+6802,"@@ -139,7 +139,7 @@ def py_run(command_options='', return_std=False, stdout=None, stderr=None):
+     """"""
+     # Create command line to call pylint
+     epylint_part = [sys.executable, ""-c"", ""from pylint import epylint;epylint.Run()""]
+-    options = shlex.split(command_options)
++    options = shlex.split(command_options, posix='win' not in sys.platform)
+     cli = epylint_part + options
+
+     # Providing standard output and/or error if not set",`sys.platform` could be equal to `darwin` which is posix. Use `not startswith('win')`?,What happens if we don
+6803,"@@ -38,11 +38,12 @@ func New(cfg *any.Any, logger *zap.Logger, scope tally.Scope) (service.Service,
+ 	}
+
+ 	s := &svc{
+-		logger:  logger,
+-		filter:  config.Filter,
+-		scope:   scope,
+-		slack:   slack.New(config.Token),
+-		channel: config.Channel,
++		logger:    logger,
++		filter:    config.Filter,
++		overrides: NewOverrideLookup(config.Overrides),
++		scope:     scope,
++		slack:     slack.New(config.Token),
++		channel:   config.Channel,
+ 	}
+ 	return s, nil
+ }",let's move this into `slack_helper.go`,[nit] I would prefer i
+6804,"@@ -54,7 +54,7 @@ class Azure(base.Base):
+         driver:
+           name: azure
+           ssh_connection_options:
+-            -o ControlPath=~/.ansible/cp/%r@%h-%p
++            - '-o ControlPath=~/.ansible/cp/%r@%h-%p'
+
+     .. important::
+ ","I doubt it will work, but without space between -o and ControlPath it should. Lets see. What I do not understand is why we did not see a failure on CI related to this?",why do we have to change this?
+6805,"@@ -56,7 +56,7 @@ DiscreteBearing BearingClass::getDiscreteBearing(const double bearing)
+ {
+     BOOST_ASSERT(0. <= bearing && bearing <= 360.);
+     auto shifted_bearing = (bearing + 0.5 * discrete_step_size);
+-    if (shifted_bearing > 360.)
++    if (shifted_bearing >= 360.)
+         shifted_bearing -= 360;
+     return static_cast<DiscreteBearing>(shifted_bearing / discrete_step_size);
+ }",this is the reason we might be seeing 360 as discrete bearing,Is there any specific reason f
+6806,"@@ -72,6 +72,9 @@ from pylint.__pkginfo__ import version
+ from pylint.reporters.ureports import nodes as report_nodes
+
+
++FULL_VERSION = '%%(prog)s %s\nastroid %s\nPython %s' % (
++    version, astroid_version, sys.version)
++
+ MANAGER = astroid.MANAGER
+
+ ","`FULL_VERSION` is available at module level for others to use, but it won't have `%(prog)s` substituted with pylint. Will that be a problem. Also put it here instead of __pkginfo__ with other versions because it isn't pkginfo related.",astroid version should be `%(p
+6807,"@@ -34,6 +34,7 @@ public abstract class BaseColumnIterator {
+   protected long triplesRead = 0L;
+   protected long advanceNextPageCount = 0L;
+   protected Dictionary dictionary;
++  protected long rowPosition;
+
+   protected BaseColumnIterator(ColumnDescriptor descriptor) {
+     this.desc = descriptor;",Is this needed? I don't see any uses.,does this need to be `final`?
+6808,"@@ -29,6 +29,15 @@ func (c *Client) DeletePubSubOrFail(name string) {
+ 	}
+ }
+
++func (c *Client) DeleteBuildOrFail(name string) {
++	c.T.Helper()
++	builds := c.KnativeGCP.EventsV1alpha1().CloudBuildSources(c.Namespace)
++	err := builds.Delete(name, &metav1.DeleteOptions{})
++	if err != nil {
++		c.T.Fatalf(""Failed to delete build %s/%s: %v"", c.Namespace, name, err)
++	}
++}
++
+ func (c *Client) DeleteSchedulerOrFail(name string) {
+ 	c.T.Helper()
+ 	schedulers := c.KnativeGCP.EventsV1alpha1().CloudSchedulerSources(c.Namespace)",Shouldn't this be V1beta1?,"@smarterclayton @juanvallejo fyi, this is what I was referring to"
+6809,"@@ -102,6 +102,13 @@ class Proposal < ActiveRecord::Base
+     approval
+   end
+
++  def remove_approver(email)
++    user = User.for_email(email)
++    approval = self.approvals.find_by(user_id: user.id)
++    CommunicartMailer.notification_for_approver_removed(email,approval)
++    approval.destroy
++  end
++
+   def initialize_approvals()
+     if self.linear? && self.approvals.any?
+       self.approvals.update_all(status: 'pending')",I think there's an `approval_for`,Line is too long. [95/80]
+6810,"@@ -719,6 +719,8 @@ public interface Stack<T> extends LinearSeq<T> {
+     @Override
+     Stack<T> takeWhile(Predicate<? super T> predicate);
+
++    <U> U transform(Function<? super List<T>, ? extends U> f);
++
+     @Override
+     <U> Stack<U> unit(Iterable<? extends U> iterable);
+ ",Here we should use <code>List</code> in generic,"We could use `Function<List<T>, ? extends U>`."
+6811,"@@ -56,8 +56,7 @@ public final class BaselineReleaseCompatibility extends AbstractBaselinePlugin {
+
+         @Override
+         public Iterable<String> asArguments() {
+-            JavaVersion jdkVersion =
+-                    JavaVersion.toVersion(javaCompile.getToolChain().getVersion());
++            JavaVersion jdkVersion = JavaVersion.toVersion(javaCompile.getTargetCompatibility());
+             if (!supportsReleaseFlag(jdkVersion)) {
+                 log.debug(
+                         ""BaselineReleaseCompatibility is a no-op for {} in {} as {} doesn't support --release"",",The `JavaCompile#getToolChain` method got removed and I am not sure what a good replacement is. I replaced it with `targetCompat` for now but they are not equivalent. Maybe we can use `JavaVersion#current` here?,I think this should be `getTargetCompatibility().getVersion()` to
+6812,"@@ -14,7 +14,7 @@ use Ergonode\SharedKernel\Domain\Aggregate\MultimediaId;
+
+ interface MultimediaQueryInterface
+ {
+-    public function fileExists(Hash $hash): bool;
++    public function fileExists(string $name): bool;
+
+     public function findIdByHash(Hash $hash): ?MultimediaId;
+ ",The method name is incorrect. It does not check the existence of the file. I'd suggest deprecating both methods `fileExists` and `findIdByHash` and use findIdByFilename instead of fileExits,Is this interface still used somewhere?
+6813,"@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
++	__u8 nat_lvl1_drop = 0;
+
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.","We have `stdbool` imported, might as well use that for clarity.",You probably want to use the `__u8` typ
+6814,"@@ -0,0 +1 @@
++package batchstore","File is empty, consider removing?",Why did you make this change?
+6815,"@@ -760,7 +760,7 @@ describe('Bulk', function() {
+           batch.insert({ b: 1 });
+
+           // Execute the operations
+-          batch.execute(self.configuration.writeConcernMax(), function(err, result) {
++          batch.execute(self.configuration.writeConcernMax().writeConcern, function(err, result) {
+             expect(err).to.exist;
+             expect(result).to.not.exist;
+ ","`writeConcernMax` was changed to return a `writeConcern` formatted the new way-- `writeConcern: {w:1, ...}`. Bulk execute takes an actual `WriteConcern` object as its first parameter (this was changed in master), so we have to un-wrap the `writeConcernMax` result here.",I think there was a stray semicolon at
+6816,"@@ -1,9 +1,10 @@
+ module TabularData
+   class Container
+-    attr_reader :columns
++    attr_reader :columns, :frozen_sort
+
+     def initialize(name, config)
+       @name = name
++      @frozen_sort = false
+       self.init_query(config[:engine].constantize, config.fetch(:joins, []))
+       self.init_columns(config.fetch(:column_configs, {}), config.fetch(:columns, {}))
+       self.set_sort(config[:sort])",How about passing this through the `config`?,"This is not needed, the `TabularData` instance is frozen."
+6817,"@@ -373,10 +373,10 @@ def create_secret(secretsmanager_client):
+         secretsmanager_client.delete_secret(SecretId=item)
+
+
+-only_localstack = pytest.mark.skipif(
+-    os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD"",
+-    reason=""test only applicable if run against localstack"",
+-)
++@pytest.fixture
++def only_localstack():
++    if os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD"":
++        pytest.skip(""test only applicable if run against localstack"")
+
+
+ @pytest.fixture","Out of curiosity - did we make this change to allow dynamically assigning a value to `os.environ[""TEST_TARGET""]` during test execution? I kind of liked the decorator style `@only_localstack` - makes the condition a bit more explicit. Looks like `skipif` also allows to specify a condition string, e.g. `pytest.mark.skipif('os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD""')` - could that be an option? (not sure if that gets lazily evaluated at runtime right before the execution of the annotated test method starts, though..)",I don't think the `pytest.mark.skipif` usage is needed an
+6818,"@@ -72,6 +72,7 @@ class SliderItem implements OrderableEntityInterface
+      */
+     public function edit(SliderItemData $sliderItemData)
+     {
++        $this->domainId = $sliderItemData->domainId;
+         $this->name = $sliderItemData->name;
+         $this->link = $sliderItemData->link;
+         $this->hidden = $sliderItemData->hidden;",I noticed (SonarCloud noticed actually) that the implementation of `::edit` method is the same as `__construct` is. Does it make sense to call the `edit` method from the constructor?,this is not the right way to do it. `domainId` is the sam
+6819,"@@ -78,6 +78,7 @@ int syslog_prot_process(struct syslog_conn *conn)
+
+         /* Incomplete message */
+         if (eof == end || (*eof != '\n' && *eof != '\0')) {
++            flb_debug(""[syslog-prot] incomplete message! (Enable trace log to see the message.)"");
+             return 0;
+         }
+ ","would you please rename the message prefix to: [in_syslog] ...""",(style) line over 80 characters
+6820,"@@ -600,8 +600,8 @@ struct AtomMatch {  // for each seed atom (matched)
+ };
+ typedef std::vector<AtomMatch> AtomMatchSet;
+
+-std::string MaximumCommonSubgraph::generateResultSMARTS(
+-    const MCS& mcsIdx) const {
++std::string MaximumCommonSubgraph::generateResultSMARTSAndQueryMol(
++    const MCS& mcsIdx, RWMol **molExt) const {
+   // match the result MCS with all targets to check if it is exact match or
+   // template
+   Seed seed;  // result MCS","The pointer to a pointer is kind of gross. How about either taking the `ROMOL_SPTR` directly or, preferably, returning an `std::pair`?",Make this `const RWMol&molExt` for consistency with the other functions.
+6821,"@@ -164,7 +164,12 @@ func (pool *TransactionPool) rememberCommit(flush bool) {
+ func (pool *TransactionPool) PendingCount() int {
+ 	pool.pendingMu.RLock()
+ 	defer pool.pendingMu.RUnlock()
++	return pool.pendingCountLocked()
++}
+
++// pendingCountLocked is a helper for PendingCount that returns the number of
++// transactions pending in the pool
++func (pool *TransactionPool) pendingCountLocked() int {
+ 	var count int
+ 	for _, txgroup := range pool.pendingTxGroups {
+ 		count += len(txgroup)","the name confusing, please rename to `pendingCountNoLock` or similar",pendingCountLocked is a function that returns the number of transactions
+6822,"@@ -44,13 +44,11 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		[]byte{}, uint64(100000),
+ 		big.NewInt(10),
+ 	)
+-	sk, err := keypair.DecodePrivateKey(Gen.CreatorPrivKey)
+-	if err != nil {
+-		return err
+-	}
+-	if err := action.Sign(tsf0, sk); err != nil {
+-		return err
+-	}
++	pk, _ := hex.DecodeString(Gen.CreatorPubKey)
++	pubk, _ := keypair.BytesToPublicKey(pk)
++	sig, _ := hex.DecodeString(""ea18385718db2a8b92fa2dcdc158a05aae17fc7e800cc735850bdc99ab7b081f32fce70080888742d7b6bee892034e38298b69ce5fff671c18f0bed827e1e21f9da2ba5d8c434e00"")
++	tsf0.SetSrcPubkey(pubk)
++	tsf0.SetSignature(sig)
+ 	blk, err := bc.MintNewBlock([]action.Action{tsf0}, ta.Addrinfo[""producer""],
+ 		nil, nil, """")
+ 	if err != nil {",line is 175 characters,Why remove the error check?
+6823,"@@ -230,12 +230,10 @@ public abstract class SalesforceReactActivity extends ReactActivity {
+     }
+
+     protected void setRestClient(RestClient restClient) {
+-        if(restClient!= null && client != restClient){
+-            if(reactActivityDelegate != null){
+-                reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());
+-            }
+-        }
+         client = restClient;
++        if(client != null && reactActivityDelegate != null){
++            reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());
++        }
+     }
+
+     protected ClientManager buildClientManager() {",@ivanbogdanov Does this fix the first time load gray screen issue that @wmathurin noticed?,"If you remove the client != null check, will it still work?"
+6824,"@@ -35,11 +35,12 @@ __all__ = ['Dataset', 'Booster',
+            'print_evaluation', 'record_evaluation', 'reset_parameter', 'early_stopping',
+            'plot_importance', 'plot_metric', 'plot_tree', 'create_tree_digraph']
+
++# REMOVEME: remove warning after 2.3.0 version release
+ if system() == 'Darwin':
+     warnings.warn(""Starting from version 2.2.1, the library file in distribution wheels for macOS ""
+-                  ""will be built by the Apple Clang compiler.\n""
++                  ""is built by the Apple Clang (Xcode_9.4.1) compiler.\n""
+                   ""This means that in case of installing LightGBM from PyPI via the ``pip install lightgbm`` command, ""
+-                  ""you won't need to install the gcc compiler anymore.\n""
+-                  ""Instead of that, you'll need to install the OpenMP library, ""
++                  ""you don't need to install the gcc compiler anymore.\n""
++                  ""Instead of that, you need to install the OpenMP library, ""
+                   ""which is required for running LightGBM on the system with the Apple Clang compiler.\n""
+-                  ""You can install the OpenMP library by the following command: ``brew install libomp``."", FutureWarning)
++                  ""You can install the OpenMP library by the following command: ``brew install libomp``."", UserWarning)",Is `2.3.0` version OK?,I think we can remove this warning now. There is no reason to install the gcc compiler with the new OpenMP compiler.
+6825,"@@ -26,6 +26,18 @@ describe ""Selenium::WebDriver::TargetLocator"" do
+     end
+   end
+
++  it ""should switch to parent frame"" do
++    driver.navigate.to url_for(""iframes.html"")
++
++    iframe = driver.find_element(:tag_name => ""iframe"")
++    driver.switch_to.frame(iframe)
++
++    driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)
++
++    driver.switch_to.parent_frame
++    driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element)
++  end
++
+   # switching by name not yet supported by safari
+   not_compliant_on :browser => [:ie, :iphone, :safari] do
+     it ""should switch to a window and back when given a block"" do",I tested it only in Firefox (`./go //rb:firefox-test`),"`driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)`?"
+6826,"@@ -10,6 +10,8 @@ import (
+ 	""net/http/httptest""
+ )
+
++// NewTestClient returns a TestClient with a replacement http handler function.
++// Methods on the new TestClient are overrideable as well.
+ func NewTestClient(handleFunc http.HandlerFunc) (*httptest.Server, *TestClient, error) {
+ 	ts := httptest.NewServer(handleFunc)
+ 	opts := []option.ClientOption{",separate third party and builtin,// Note: Methods on the new TestClient are overridden as well.
+6827,"@@ -818,7 +818,9 @@ public class SalesforceSDKManager {
+
+         // Finishes front activity if specified, and if this is the last account.
+         if (frontActivity != null && (users == null || users.size() <= 1)) {
+-            frontActivity.finish();
++            // only finish if it isn't hybrid or if hybrid, requires authentication
++            if (!isHybrid() || BootConfig.getBootConfig(frontActivity).shouldAuthenticate())
++                frontActivity.finish();
+         }
+
+         /*",@smcnulty-sfdc We do want to finish the hybrid activity in our hybrid apps though. Could the caller not pass in `frontActivity` instead? Or start it up again post-logout?,Shouldn't this be `isHybrid()`?
+6828,"@@ -111,7 +111,7 @@ func (o outbound) Call(ctx context.Context, req *transport.Request) (*transport.
+
+ 	response, err := ctxhttp.Do(ctx, o.Client, request)
+ 	if err != nil {
+-		if err == context.DeadlineExceeded {
++		if err == ctx.Err() {
+ 			return nil, errors.NewTimeoutError(req.Service, req.Procedure, deadline.Sub(start))
+ 		}
+ ",isn't this going to return a timeout error if the context is canceled?,Would be nice to have a test for this too.
+6829,"@@ -15,6 +15,10 @@ class ArgsParser {
+   ArgsParser(String[] args) {
+     for (String arg : args) {
+       String[] argNameVal = arg.split(""="");
++      if (argNameVal.length == 1) {
++        parsedArgs.put(argNameVal[0], ""true"");
++        continue;
++      }
+       if (argNameVal.length != 2) {
+         System.out.println(""WARNING: Ignoring unrecognized argument: "" + arg);
+         continue;","`argNameVal.length` will still be !=2, so line 22 will give true and then continue on line 24","argNameVal.length == 1 is a bit dangerous,"
+6830,"@@ -237,7 +237,7 @@ class FunctionDocblockManipulator
+                 continue;
+             }
+
+-            if ($char === '\\' || preg_match('/\w/', $char)) {
++            if ($chars[$i + 1] === '\\' || preg_match('/\w/', $char)) {
+                 if ($this->return_typehint_start === null) {
+                     $this->return_typehint_start = $i + $end_bracket_position + 1;
+                 }",It was `$chars[$i]` I believe.,How is this related to the rest of the PR?
+6831,"@@ -246,7 +246,7 @@ module Unix::Exec
+       else
+         val = val.to_s
+       end
+-      env_array << ""#{key.to_s.upcase}=\""#{val}\""""
++      env_array << ""#{key.to_s}=\""#{val}\""""
+     end
+     env_array
+   end","This has the likely potential to break existing tests that are relying on the old beaker behavior. If we are going to release this in beaker 3.x, then we need to preserve the old behavior as well (so set both the `upcase` and original values). On Windows, they env variables will overwrite each other, with the same value, so not an issue. On *nix, there will be two env variables, but they will have the same value, so again no issue.",Metrics/LineLength: Line is too long. [98/
+6832,"@@ -299,6 +299,7 @@ Blockly.Variables.createVariable = function(workspace, opt_callback, opt_type) {
+   // Prompt the user to enter a name for the variable
+   Blockly.prompt(newMsg, '',
+       function(text, additionalVars, variableOptions) {
++        variableOptions = variableOptions || {};
+         var scope = variableOptions.scope;
+         var isLocal = (scope === 'local') || false;
+         var isCloud = variableOptions.isCloud || false;",Thanks for fixing this! I probably didn't test the playground when making changes here for cloud variables.,This could just be `variableOptions = variableOptions || {};`.
+6833,"@@ -39,6 +39,7 @@ class PruneColumns extends AvroSchemaVisitor<Schema> {
+   private final NameMapping nameMapping;
+
+   PruneColumns(Set<Integer> selectedIds, NameMapping nameMapping) {
++    Preconditions.checkNotNull(selectedIds, ""Selected field ids cannot be null"");
+     this.selectedIds = selectedIds;
+     this.nameMapping = nameMapping;
+   }",I will also check if `nameMapping` needs a precondition null check.,nit: you can merge both lines above as `checkNotNull` will ret
+6834,"@@ -60,9 +60,8 @@ public class Files {
+
+       if (!file.getParentFile().isDirectory() && !file.getParentFile().mkdirs()) {
+         throw new RuntimeIOException(
+-            String.format(
+                 ""Failed to create the file's directory at %s."",
+-                file.getParentFile().getAbsolutePath()));
++                file.getParentFile().getAbsolutePath());
+       }
+
+       try {","Since RuntimeIOException is deprecated and you are touching this code, why not replace it?",This seems unrelated to the rest of the PR.
+6835,"@@ -59,7 +59,9 @@ class ClusterParamsTest(TestCaseBase):
+       self.assertGreaterEqual(encodersDict['c1']['resolution'], 0.001,
+                               ""Resolution is too low"")
+
+-
++    # Ensure incorrect tmImplementation throws exception
++    with self.assertRaises(ValueError):
++        getScalarMetricWithTimeOfDayAnomalyParams([0], tmImplementation="""")
+
+ if __name__ == '__main__':
+   unittest.main()",You should also have a test that calls it with tm_cpp and make sure it returns the correct JSON file.,Why not check the error message?
+6836,"@@ -168,17 +168,12 @@ define([""jQuery"", ""globalize"", ""scripts/taskbutton"", ""dom"", ""libraryMenu"", ""layo
+         }), menuItems.push({
+             name: ""Xml TV"",
+             id: ""xmltv""
+-        }), menuItems.push({
+-            name: globalize.translate(""ButtonOther""),
+-            id: ""other""
+         }), require([""actionsheet""], function(actionsheet) {
+             actionsheet.show({
+                 items: menuItems,
+                 positionTo: button,
+                 callback: function(id) {
+-                    ""other"" == id ? Dashboard.alert({
+-                        message: globalize.translate(""ForAdditionalLiveTvOptions"")
+-                    }) : Dashboard.navigate(getProviderConfigurationUrl(id))
++                    Dashboard.navigate(getProviderConfigurationUrl(id))
+                 }
+             })
+         })","One more minor change, the string `ForAdditionalLiveTvOptions` is probably also unused.",Why is this removed?
+6837,"@@ -107,7 +107,7 @@ bool RowReaderWrapper::reset(meta::SchemaProviderIf const* schema,
+     currReader_ = &readerV2_;
+     return true;
+   } else {
+-    LOG(ERROR) << ""Unsupported row reader version "" << readerVer;
++    LOG(WARNING) << ""Unsupported row reader version "" << readerVer;
+     currReader_ = nullptr;
+     return false;
+   }",How to distinguish between warning and error?,Would it be possible
+6838,"@@ -171,6 +171,10 @@ def doPreGainFocus(obj,sleepMode=False):
+ 			else:
+ 				newForeground=obj
+ 		api.setForegroundObject(newForeground)
++		import UIAHandler
++		if UIAHandler.isUIAAvailable:
++			# Notify UIAHandler of the new foreground so that it can deregister old events and register new ones
++			UIAHandler.handler.onForegroundChange(newForeground.windowHandle)
+ 		executeEvent('foreground',newForeground)
+ 	if sleepMode: return True
+ 	#Fire focus entered events for all new ancestors of the focus if this is a gainFocus event",Perhaps you want to check if UIAHandler.handler is not None. The current check will break NVDA if you call UIAHandler.terminate() for some reason.,Since `newForeground
+6839,"@@ -27,6 +27,7 @@ public class BaseReplacePartitions
+     extends MergingSnapshotProducer<ReplacePartitions> implements ReplacePartitions {
+   BaseReplacePartitions(String tableName, TableOperations ops) {
+     super(tableName, ops);
++    set(""replace-partitions"", ""true"");
+   }
+
+   @Override",can we make `replace-partitions` property a static variable in `SnaphotSummary.java`?,Let's use `org.apach
+6840,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?,Is there a reason why you changed from `Selenium::WebDriver::OSSBridge` to `Selenium::WebDriver::W3CBridge`?
+6841,"@@ -79,7 +79,9 @@ def get_admins():
+ def activate_response(link):
+     payload = verify_activation_link(link)
+     if payload:
+-        _activate_user(User.query.filter_by(id=payload['id']).with_for_update().one_or_none())
++        user = User.query.filter_by(id=payload['id']).with_for_update().one_or_none()
++        _activate_user(user)
++        send_welcome_email(user)
+         db.session.commit()
+         return redirect(""{CATALOG_URL}/signin"".format(CATALOG_URL=CATALOG_URL), code=302)
+ ","Should really be `one()`, not `one_or_none()`",Shouldn't we send the email after the user is active?
+6842,"@@ -193,7 +193,11 @@ func SetJoinNodeConfigurationOverrides(caCertHash, bootstrapToken string, machin
+ 	}
+ 	out.NodeRegistration.KubeletExtraArgs[""cloud-provider""] = CloudProvider
+ 	if !util.IsControlPlaneMachine(machine.GetMachine()) {
+-		out.NodeRegistration.KubeletExtraArgs[""node-labels""] = nodeRole
++		if labels, ok := out.NodeRegistration.KubeletExtraArgs[""node-labels""]; ok {
++			out.NodeRegistration.KubeletExtraArgs[""node-labels""] = fmt.Sprintf(""%s,%s"", labels, nodeRole)
++		} else {
++			out.NodeRegistration.KubeletExtraArgs[""node-labels""] = nodeRole
++		}
+ 	}
+ 	return out
+ }",Should we use strings.Split and strings.Join instead of manual concatenation?,do we have a test case for this?
+6843,"@@ -374,6 +374,18 @@ class In(
+             asset_partitions=asset_partitions,
+         )
+
++    @staticmethod
++    def from_definition(input_def: InputDefinition):
++        return In(
++            dagster_type=input_def.dagster_type,
++            description=input_def.description,
++            default_value=input_def._default_value,  # pylint: disable=protected-access
++            root_manager_key=input_def.root_manager_key,
++            metadata=input_def.metadata,
++            asset_key=input_def._asset_key,  # pylint: disable=protected-access
++            asset_partitions=input_def._asset_partitions_fn,  # pylint: disable=protected-access
++        )
++
+     def to_definition(self, name: str) -> InputDefinition:
+         dagster_type = self.dagster_type if self.dagster_type is not NoValueSentinel else None
+         return InputDefinition(","rough that this needs to exist, but it is what it is",Could you please add a docstring here?
+6844,"@@ -117,6 +117,17 @@ describe('render()', () => {
+ 		expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
+ 	});
+
++	// TODO: the test doesn't seem to work as it throws, maybe due to not knowing the props allowed for x-bar
++	// it('should not set empty string for null props in custom attributes', () => {
++	// 	render(<x-bar val={null} />, scratch);
++	// 	expect(scratch.childNodes).to.have.length(1);
++	// 	expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
++	// 	expect(scratch.firstChild.attributes['val']).to.equal('null');
++	// 	expect(scratch.innerHTML).to.equal(
++	// 		'<x-bar val=""null""></x-bar>'
++	// 	);
++	// });
++
+ 	it('should support the form attribute', () => {
+ 		render(
+ 			<div>","FYI, I pulled your branch and hacked a little on your test case. This passes for me (you may want to tweak further): <pre> it('should not set empty string for null props in custom elements', () => { customElements.define('x-bar', class extends HTMLElement { val; }); // @ts-ignore render(&lt;x-bar val={null} /&gt;, scratch); expect(scratch.childNodes).to.have.length(1); expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR'); expect(scratch.firstChild.attributes.length).to.equal(0); expect(scratch.firstChild.val).to.equal(null); }); </pre>","If it doesn't throw, remove it."
+6845,"@@ -43,7 +43,7 @@ import android.util.Log;
+  */
+ public class SmartStoreLoadExternalStorageTest extends SmartStoreLoadTest {
+
+-    static final int ONE_MEGABYTE = 1024 * 1024;
++    static final int LARGE_BYTES = 512 * 1024;
+
+     @Override
+     protected String getPasscode() {",It is the maximum value that the configured emulator can support.,I think the name of this test c
+6846,"@@ -210,14 +210,17 @@ def _load_session(name):
+         name: The name of the session to load, or None to read state file.
+     """"""
+     state_config = objreg.get('state-config')
++    session_manager = objreg.get('session-manager')
+     if name is None:
+         try:
+             name = state_config['general']['session']
+         except KeyError:
+             # No session given as argument and none in the session file ->
+             # start without loading a session
+-            return
+-    session_manager = objreg.get('session-manager')
++            if session_manager.exists('_autosave'):
++                name = '_autosave'
++            else:
++                return
+     try:
+         session_manager.load(name)
+     except sessions.SessionNotFoundError:","Here, I've been giving priority to the session saved by the user. This means, that if the user quits with `:wq`, then restarts `qutebrowser`, and then `qutebrowser` crashes for some reason, next time `qutebrowser` is restarted, the session saved lastly with `wq` will be restored, and not the one autosaved. What do you think?",Why do we need this change?
+6847,"@@ -64,7 +64,7 @@ func membership(l LedgerReader, addr basics.Address, r basics.Round, p period, s
+ 	balanceRound := balanceRound(r, cparams)
+ 	seedRound := seedRound(r, cparams)
+
+-	record, err := l.BalanceRecord(balanceRound, addr)
++	record, err := l.AccountData(balanceRound, addr)
+ 	if err != nil {
+ 		err = fmt.Errorf(""Service.initializeVote (r=%d): Failed to obtain balance record for address %v in round %d: %v"", r, addr, balanceRound, err)
+ 		return","this line got me confused for few seconds, as the `AccountData` is both the name of the data structure as well as the function name. I think that `GetAccountData` is a better choice for a name. ( note that the same applies for the previous `BalanceRecord` function name )",what is the difference between
+6848,"@@ -61,11 +61,7 @@ public:
+     void helper_block_for_at_least_entries(
+             uint32_t amount)
+     {
+-        std::unique_lock<std::mutex> lck(*xml_mutex_);
+-        mock_consumer->cv().wait(lck, [this, amount]
+-                {
+-                    return mock_consumer->ConsumedEntriesSize_nts() >= amount;
+-                });
++        mock_consumer->wait_for_at_least_entries(amount);
+     }
+
+     MockConsumer* mock_consumer;",I think this mutex is only used here. Remove it.,Is it possible that this `wait_for_at_least_entries` call can be avoided by the lock?
+6849,"@@ -234,6 +234,11 @@ func NewMutableState(
+ 		logger:          logger,
+ 		metricsClient:   shard.GetMetricsClient(),
+ 	}
++
++	if migration.IsDBVersionEnabled() {
++		s.dbRecordVersion = 1
++	}
++
+ 	s.executionInfo = &persistencespb.WorkflowExecutionInfo{
+ 		WorkflowTaskVersion:    common.EmptyVersion,
+ 		WorkflowTaskScheduleId: common.EmptyEventID,",so this is now init to 1?,Do we need this here? I think we can set it to 0 by default?
+6850,"@@ -191,7 +191,8 @@ bool ZoneDatabase::LoadSpawnGroups(const char *zone_name, uint16 version, SpawnG
+ 				WHERE
+ 				spawn2.spawngroupID = spawngroup.ID
+ 				AND
+-				spawn2.version = {} and zone = '{}'
++				(spawn2.version = {} OR version = -1)
++				AND zone = '{}'
+ 				{}
+ 		),
+ 		version,",For future note; not prefixing the table in a join can throw an error in the query parser depending on how the query is built I am making an assumption this was tested,Shouldn't this be `version < -1`?
+6851,"@@ -42,9 +42,13 @@ var c client.Client
+
+ var expectedRequest = reconcile.Request{NamespacedName: types.NamespacedName{Name: ""foo"", Namespace: ""default""}}
+
+-var jobKey = types.NamespacedName{Name: ""install-foo"", Namespace: ""default""}
++var jobKey = types.NamespacedName{Name: ""foo-install"", Namespace: ""default""}
+
+-const timeout = time.Second * 5
++const (
++	timeout             = time.Second * 10
++	fakeClusterUUID     = ""fe953108-f64c-4166-bb8e-20da7665ba00""
++	fakeClusterMetadata = `{""clusterName"":""foo"",""aws"":{""region"":""us-east-1"",""identifier"":{""tectonicClusterID"":""fe953108-f64c-4166-bb8e-20da7665ba00""}}}`
++)
+
+ func init() {
+ 	log.SetLevel(log.DebugLevel)","Had to bring this up, will abandon this style of testing based on Joel's work soon.",why the change from 5s to 10s?
+6852,"@@ -493,7 +493,7 @@ public class HttpSolrCall {
+     }
+     if (statusCode == AuthorizationResponse.FORBIDDEN.statusCode) {
+       if (log.isDebugEnabled()) {
+-        log.debug(""UNAUTHORIZED auth header {} context : {}, msg: {}"", req.getHeader(""Authorization""), context, authResponse.getMessage()); // logOk
++        log.debug(""UNAUTHORIZED auth header {} context : {}, msg: {}"", req.getHeader(""Authorization""), context, authResponse.getMessage()); // nowarn
+       }
+       sendError(statusCode,
+           ""Unauthorized request, Response code: "" + statusCode);",What does our source validation complain about here? Many of the logok/nowarn places look fine to me at a glance but I'm no match for the logging policeman ;-),I don't think this debug log is needed.
+6853,"@@ -22,14 +22,17 @@ import (
+ 	""strconv""
+ 	""time""
+
++	""github.com/mysteriumnetwork/node/client/stats""
+ 	""github.com/mysteriumnetwork/node/openvpn/management""
+ )
+
+ // SessionStatsHandler is invoked when middleware receives statistics
+-type SessionStatsHandler func(SessionStats) error
++type SessionStatsHandler func(stats.SessionStats) error
+
+ const byteCountCommandTemplate = ""bytecount %d""
+
++var rule = regexp.MustCompile(""^>BYTECOUNT:(.*),(.*)$"")
++
+ type middleware struct {
+ 	sessionStatsHandler SessionStatsHandler
+ 	interval            time.Duration","It feels like this dependency should not be here. Some deep internal openvpn package (middleware) knows about one of possible stats consumers. Maybe as an alternative, statistics and state callbacks can be extracted as separate interfaces in top openvpn package and reused by both sides",nit: should we use `fmt.Sprintf`?
+6854,"@@ -1744,7 +1744,7 @@ func (fd *fileData) deepCopy(ctx context.Context, codec kbfscodec.Codec,
+
+ 	// Handle the single-level case first.
+ 	if !topBlock.IsInd {
+-		newTopBlock, err := topBlock.DeepCopy(codec)
++		newTopBlock := topBlock.DeepCopy()
+ 		if err != nil {
+ 			return zeroPtr, nil, err
+ 		}",Can you please remove `codec` from the parameters too? I think it's unused now.,Did you mean to delete this line?
+6855,"@@ -126,6 +126,7 @@ class ContextTest extends AbstractSymbolResolutionTest {
+         when(compilationUnitDecl.getName()).thenReturn(""CompilationUnit"");
+         when(compilationUnitDecl.getQualifiedName()).thenReturn(""com.github.javaparser.ast.CompilationUnit"");
+         TypeSolver typeSolver = mock(TypeSolver.class);
++        when(typeSolver.getSolvedJavaLangObject()).thenReturn(new ReflectionClassDeclaration(Object.class, typeSolver));
+         when(typeSolver.getRoot()).thenReturn(typeSolver);
+         when(typeSolver.solveType(""java.lang.Object"")).thenReturn(new ReflectionClassDeclaration(Object.class, typeSolver));
+         when(typeSolver.tryToSolveType(""com.github.javaparser.ast.CompilationUnit"")).thenReturn(SymbolReference.solved(compilationUnitDecl));","mocks needed this change so that it returns the ""right"" thing",Shouldn't this call directly return `ne
+6856,"@@ -128,9 +128,14 @@ public class MenuEntrySwapperPlugin extends Plugin
+ 	@Getter
+ 	private boolean configuringShiftClick = false;
+
++	@Getter
+ 	@Setter
+ 	private boolean shiftModifier = false;
+
++	@Getter
++	@Setter
++	private boolean controlModifier = false;
++
+ 	@Provides
+ 	MenuEntrySwapperConfig provideConfig(ConfigManager configManager)
+ 	{","I don't think the getters for this are needed, but looks good other than that",The default value should be 'true' to preserve binary compatibility.
+6857,"@@ -1,3 +1,16 @@
+ <%= content_tag_for :div, video do %>
+-  <%= render 'videos/summary', video: video %>
++  <div class=""video-text <%= video.status_class %>"">
++    <%= link_to video_path(video) do %>
++      <h3><%= video.name %></h3>
++    <% end %>
++    <div class=""video-tags"">
++      <%= render video.topics %>
++    </div>
++    <p class=""video-length"" data-wistia-id=""<%= video.clip.wistia_id %>"">
++      <%= video.length_in_minutes %> minutes
++    </p>
++    <p class=""video-summary"">
++      <%= format_markdown(video.summary) %>
++    </p>
++  </div>
+ <% end %>",:+1: to inlining this.,Does it make sense to add a `data-` prefix to the `id` or does the `
+6858,"@@ -13785,7 +13785,7 @@ return [
+ 'stream_get_contents' => ['string|false', 'stream'=>'resource', 'length='=>'int', 'offset='=>'int'],
+ 'stream_get_filters' => ['array'],
+ 'stream_get_line' => ['string|false', 'stream'=>'resource', 'length'=>'int', 'ending='=>'string'],
+-'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri:string,mediatype:string}', 'stream'=>'resource'],
++'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri:string,mediatype:string,crypto?:mixed}', 'stream'=>'resource'],
+ 'stream_get_transports' => ['list<string>'],
+ 'stream_get_wrappers' => ['list<string>'],
+ 'stream_is_local' => ['bool', 'stream'=>'resource|string'],",Does psalm support the same logic internally for object-like arrays? Just want to be certain I can indicate this is a contextual return item `crypto?:mixed`.,Metrics/LineLength: Line is too long. [125/120]
+6859,"@@ -658,8 +658,6 @@ void CreateImageTest(VkLayerTest &test, const VkImageCreateInfo *pCreateInfo, st
+     VkImage image = VK_NULL_HANDLE;
+     if (code.length()) {
+         test.Monitor().SetDesiredFailureMsg(kErrorBit, code);
+-        // Very possible a test didn't check for VK_ERROR_FORMAT_NOT_SUPPORTED
+-        test.Monitor().SetUnexpectedError(""UNASSIGNED-CoreValidation-Image-FormatNotSupported"");
+     } else {
+         test.Monitor().ExpectSuccess();
+     }",I can't recall if there was a fix specific to this in the past?,Why isn't this needed anymore?
+6860,"@@ -51,14 +51,15 @@ var _ = duck.VerifyType(&PubSubSource{}, &duckv1alpha1.Conditions{})
+
+ // PubSubSourceSpec defines the desired state of the PubSubSource.
+ type PubSubSourceSpec struct {
+-	// GcpCredsSecret is the credential to use to poll the GCP PubSubSource Subscription. It is not used
++	// Secret is the credential to use to poll the PubSubSource Subscription. It is not used
+ 	// to create or delete the Subscription, only to poll it. The value of the secret entry must be
+ 	// a service account key in the JSON format (see
+ 	// https://cloud.google.com/iam/docs/creating-managing-service-account-keys).
+-	GcpCredsSecret corev1.SecretKeySelector `json:""gcpCredsSecret,omitempty""`
++	Secret *corev1.SecretKeySelector `json:""secret,omitempty""`
+
+-	// GoogleCloudProject is the ID of the Google Cloud Project that the PubSubSource Topic exists in.
+-	GoogleCloudProject string `json:""googleCloudProject,omitempty""`
++	// TODO: https://github.com/googleapis/google-cloud-go/blob/master/compute/metadata/metadata.go
++	// Project is the ID of the Google Cloud Project that the PubSubSource Topic exists in.
++	Project string `json:""project,omitempty""`
+
+ 	// Topic is the ID of the GCP PubSubSource Topic to Subscribe to. It must be in the form of the
+ 	// unique identifier within the project, not the entire name. E.g. it must be 'laconia', not",Not sure what the todo is here? Is it to support some kind of defaulting based off of that?,Is this TODO still relevant?
+6861,"@@ -68,11 +68,18 @@ namespace NLog.Targets.Wrappers
+         /// Delay the flush until the LogEvent has been confirmed as written
+         /// </summary>
+         /// <docgen category='General Options' order='10' />
+-        public bool AsyncFlush { get => _asyncFlush ?? true;
++        public bool AsyncFlush
++        {
++            get => _asyncFlush ?? true;
+             set => _asyncFlush = value;
+         }
+         private bool? _asyncFlush;
+
++        /// <summary>
++        /// Only flush when LogEvent matches condition. Ignore explicit-flush, config-reload-flush and shutdown-flush
++        /// </summary>
++        public bool FlushOnConditionOnly { get; set; }
++
+         private readonly AsyncOperationCounter _pendingManualFlushList = new AsyncOperationCounter();
+
+         /// <summary>","Not sure about this name. I think ""explicit"" is also a bit difficult here (I think it should be implicit then) Proposal: FlushOnEvents. Or, It would be cool if we could split into 2 options, FlushOnShutdown and FlushOnReload, but I expect that's far more difficult to implement?",Why do we need this property
+6862,"@@ -32,7 +32,11 @@ from qutebrowser.utils import objreg, qtutils
+ from qutebrowser.browser.webkit import tabhistory
+
+
+-pytestmark = pytest.mark.qt_log_ignore('QIODevice::read.*: device not open')
++@pytest.fixture(autouse=True)
++@pytest.mark.qt_log_ignore('QIODevice::read.*: device not open')
++def autouse(fake_save_manager):
++    yield
++
+
+ webengine_refactoring_xfail = pytest.mark.xfail(
+     True, reason='Broke during QtWebEngine refactoring, will be fixed after '",I don't think that works - you can't mark a fixture.,How about `pytest.mark.param
+6863,"@@ -42,6 +42,12 @@ module Bolt
+
+     PUPPETFILE_OPTIONS = %w[proxy forge].freeze
+
++    DEFAULT_CONFIG_PATHS = [
++      Bolt::Util.windows? ? 'C:\\Program Files\\Puppet Labs\\Bolt\\bolt.yaml' : '/etc/puppetlabs/bolt/bolt.yaml',
++      File.expand_path('.puppetlabs/etc/bolt/bolt.yaml', Bolt::Util.windows? ? ENV['USERPROFILE'] : '~'),
++      File.expand_path('.puppetlabs/bolt.yaml', Bolt::Util.windows? ? ENV['USERPROFILE'] : '~')
++    ].freeze
++
+     def self.default
+       new(Bolt::Boltdir.new('.'), {})
+     end",We should not include this path.,The default is `/etc/puppetL
+6864,"@@ -52,6 +52,19 @@ class SlackWebhooknotifierTest(ForsetiTestCase):
+
+             self.assertEqual(expected_output.strip(), actual_output.strip())
+
++    def test_dump_slack_output_for_string_returns_string(self):
++        violation_data = 'Test violation data string'
++        with mock.patch.object(
++                slack_webhook.SlackWebhook,
++                '__init__',
++                lambda x: None):
++            slack_notifier = slack_webhook.SlackWebhook()
++            actual_output = slack_notifier._dump_slack_output(violation_data)
++
++            expected_output = '\t' + '`' + str(violation_data) + '`\n'
++
++            self.assertEqual(expected_output.strip(), actual_output.strip())
++
+     def test_no_url_no_run_notifier(self):
+         """"""Test that no url for Slack notifier will skip running.""""""
+         with mock.patch.object(slack_webhook.SlackWebhook, '__init__', lambda x: None):",Add newline at end of file,why `\t` and not `\r\n`?
+6865,"@@ -257,6 +257,9 @@ class DBUpgrader {
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_EXCLUDE_FILTER + "" TEXT DEFAULT ''"");
+
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_MINIMAL_DURATION_FILTER + "" INTEGER DEFAULT -1"");
++
+             // and now auto refresh
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_KEEP_UPDATED + "" INTEGER DEFAULT 1"");","This should be done when updating to the next release (2.5). You currently only perform the upgrade when users go from 1.4 to 1.5, so it will lead to crashes for existing users.","just curious, why -1 and"
+6866,"@@ -320,6 +320,9 @@ const (
+ 	// HiveFeatureGatesEnabledEnvVar is the the environment variable specifying the comma separated list of
+ 	// feature gates that are enabled.
+ 	HiveFeatureGatesEnabledEnvVar = ""HIVE_FEATURE_GATES_ENABLED""
++
++	// CentralMachineManagementAnnotation
++	CentralMachineManagementAnnotation = ""hive.openshift.io/clusterName""
+ )
+
+ // GetMergedPullSecretName returns name for merged pull secret name per cluster deployment",suggest hive.openshift.io/cluster-machine-management or something to make it more obvious what it is.,@mfojtik why is this her
+6867,"@@ -45,7 +45,7 @@ using Nethermind.JsonRpc.Modules.Eth.FeeHistory;
+
+ namespace Nethermind.Init.Steps
+ {
+-    [RunnerStepDependencies(typeof(InitializeNetwork), typeof(SetupKeyStore), typeof(InitializeBlockchain), typeof(InitializePlugins))]
++    [RunnerStepDependencies(typeof(InitializeNetwork), typeof(SetupKeyStore), typeof(InitializeBlockchain), typeof(InitializePlugins), typeof(ReviewBlockTree))]
+     public class RegisterRpcModules : IStep
+     {
+         private readonly INethermindApi _api;",We explicitly don't want to do that. This was a complaint from users before.,Can we use the new style
+6868,"@@ -28,6 +28,7 @@ use Thelia\Type\TypeCollection;
+  * {@inheritdoc}
+  * @method int getId()
+  * @method int[] getExclude()
++ * @method int[] getExcludeCode()
+  * @method string getCode()
+  * @method string[] getOrder()
+  */","Hello, The PHPDoc is `string[]` not `int[]`",do you really need this new method?
+6869,"@@ -20,7 +20,7 @@ import (
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/mock""
+ )
+
+-func applyTc(ctx context.Context, pid uint32, args ...string) error {
++func applyTc(ctx context.Context, pid uint32, enterNS bool, args ...string) error {
+ 	// Mock point to return error in unit test
+ 	if err := mock.On(""TcApplyError""); err != nil {
+ 		if e, ok := err.(error); ok {",Same issues with parameters order in `ipset_server.go`,Maybe rename this to `enableNS` to
+6870,"@@ -82,8 +82,8 @@ const (
+ 	SystemLocalNamespace = ""temporal-system""
+ 	// SystemNamespaceID is namespace id for all temporal system workflows
+ 	SystemNamespaceID = ""32049b68-7872-4094-8e63-d0dd59896a83""
+-	// SystemNamespaceRetentionDays is retention config for all temporal system workflows
+-	SystemNamespaceRetentionDays = time.Hour * 24 * 7
++	// SystemNamespaceRetention is retention config for all temporal system workflows
++	SystemNamespaceRetention = time.Hour * 24 * 7
+ )
+
+ const (","Wow, did it literally mean the retention days is a huge number?",why did you change this?
+6871,"@@ -216,6 +216,11 @@ int FlatCompiler::Compile(int argc, const char **argv) {
+             flatbuffers::PosixPath(argv[argi]));
+         include_directories.push_back(
+             include_directories_storage.back().c_str());
++      } else if (arg == ""--bfbs-filenames"") {
++        if (++argi > argc) Error(""missing path following: "" + arg, true);
++        opts.project_root = argv[argi];
++        if (!DirExists(opts.project_root.c_str()))
++          Error(arg + "" is not a directory: "" + opts.project_root);
+       } else if (arg == ""--conform"") {
+         if (++argi >= argc) Error(""missing path following: "" + arg, true);
+         conform_to_schema = flatbuffers::PosixPath(argv[argi]);",you probably didn't intend to touch those files in `scripts/`,This seems like it should be an opt
+6872,"@@ -270,6 +270,7 @@ def eval_map(det_results,
+              iou_thr=0.5,
+              dataset=None,
+              logger=None,
++             tpfp_func=None,
+              nproc=4):
+     """"""Evaluate mAP of a dataset.
+ ","Similar to `collate_fn`, we may rename it to `tpfp_fn`.",Update the docstring too?
+6873,"@@ -320,6 +320,7 @@ export class TopOverlay extends Overlay {
+       return this.wot.wtTable.holderOffset.top;
+
+     }
++
+     return 0;
+
+   }","Awesome! We may also use negative rule `never` to fix new lines after `return`: `{ blankLine: ""never"", prev: ""return"", next: ""*"" }`",Minor: Unnecessary whites
+6874,"@@ -0,0 +1,18 @@
++// Copyright 2016 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++package libkbfs
++
++import ""errors""
++
++// GetJournalServer returns the JournalServer tied to a particular
++// config.
++func GetJournalServer(config Config) (*JournalServer, error) {
++	bserver := config.BlockServer()
++	jbserver, ok := bserver.(journalBlockServer)
++	if !ok {
++		return nil, errors.New(""Write journal not enabled"")
++	}
++	return jbserver.jServer, nil
++}",Why can't this be a function on the `Config` interface like all the others?,journal not enabled?
+6875,"@@ -252,7 +252,9 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem
+         optionsMenu = menu;
+         FeedMenuHandler.onCreateOptionsMenu(inflater, menu);
+         iconTintManager.updateTint();
+-        MenuItemUtils.setupSearchItem(menu, (MainActivity) getActivity(), feedID);
++        if (feed != null) {
++            MenuItemUtils.setupSearchItem(menu, (MainActivity) getActivity(), feedID, feed.getTitle());
++        }
+         if (feed == null || feed.getLink() == null) {
+             menu.findItem(R.id.share_link_item).setVisible(false);
+             menu.findItem(R.id.visit_website_item).setVisible(false);","If the feed is null, the menu items should still be setup. Just the feed title can be left out. That prevents possible flickering when menu items are displayed/hidden for some feeds.","This is still wrong, you "
+6876,"@@ -178,8 +178,12 @@ public class Spark3Util {
+
+   private static void apply(UpdateSchema pendingUpdate, TableChange.AddColumn add) {
+     Type type = SparkSchemaUtil.convert(add.dataType());
+-    pendingUpdate.addColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
+-
++    if (add.isNullable()) {
++      pendingUpdate.addColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
++    } else {
++      pendingUpdate.allowIncompatibleChanges()
++        .addRequiredColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
++    }
+     if (add.position() instanceof TableChange.After) {
+       TableChange.After after = (TableChange.After) add.position();
+       String referenceField = peerName(add.fieldNames(), after.column());",I'm not sure that this should call `allowIncompatibleChanges()` because adding a required column when there are no existing values will break reading the new column in any table with data in it. The only time it is safe to add a required column is if there is no data in the table. What about throwing an exception here instead? I agree that the column should not be optional if NOT NULL was specified. Another alternative is to check whether the table has data and allow the incompatible change if it doesn't have any rows.,Can we add a check that `add.isNullable()` is true here?
+6877,"@@ -154,7 +154,7 @@ class ServiceProvider extends ModuleServiceProvider
+          */
+         WidgetManager::instance()->registerReportWidgets(function($manager){
+             $manager->registerReportWidget('System\ReportWidgets\Status', [
+-                'label'   => 'System status',
++                'label'   => Lang::get('backend::lang.dashboard.status.widget_title_default'),
+                 'context' => 'dashboard'
+             ]);
+         });","Early translation , should be logic-less",Shouldn't it be `lang::t('backend::lang.dashboard.status
+6878,"@@ -0,0 +1,19 @@
++package proxy
++
++import ""net/http""
++
++type interceptor interface {
++	InterceptRequest(*http.Request) (*http.Request, error)
++	InterceptResponse(*http.Response) (*http.Response, error)
++}
++
++type nullInterceptor struct {
++}
++
++func (i nullInterceptor) InterceptRequest(r *http.Request) (*http.Request, error) {
++	return r, nil
++}
++
++func (i nullInterceptor) InterceptResponse(r *http.Response) (*http.Response, error) {
++	return r, nil
++}","I don't understand why these functions return a request/response, respectively. In all implementations we actually _modify_ the request/response given as a parameter. Do you envisage situations where we'd want to construct completely fresh request/response objects? Even if we do, it's not something needed atm, so I'd favour in keeping the API minimal. Also, the fact that these functions _may_ mutate the request/response should be noted.",why is this interceptible?
+6879,"@@ -147,8 +147,8 @@ Rails.application.routes.draw do
+   get 'maintenance', to: 'abouts#maintenance'
+   get 'tools', to: 'abouts#tools'
+
+-  get 'p/compare', to: 'compares#projects', as: :compare_projects
+-  get 'p/project_graph', to: 'compares#projects_graph', as: :compare_graph_projects
++  get 'p/_compare', to: 'compares#projects', as: :compare_projects
++  get 'p/_project_graph', to: 'compares#projects_graph', as: :compare_graph_projects
+   get 'projects/:id/stacks', to: 'stacks#project_stacks', constraints: { format: /xml/ }
+   get 'p/:id/stacks', to: 'stacks#project_stacks', as: :project_stacks, constraints: { format: /xml/ }
+   get 'p/:id/stacks', to: redirect('/p/%{id}/users'), constraints: { format: /html/ }",Wasn't there a subsequent reason why we had to keep the `/p/project_graph` route? Outside references or is the proposed solution to the original proposal we us `/p/g` as the `compares#project_graph` route?,"I agree with @rhymes above, but shouldn't the path be `/"
+6880,"@@ -44,6 +44,14 @@ public class GenTest {
+         assertThat(gen.apply(RANDOM)).isEqualTo(3);
+     }
+
++    @Test
++    public void shouldCreateGenOfFixedValues() {
++        final Gen<Integer> gen = Gen.fixed(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++    }
++
+     // -- random number generator (rng)
+
+     @Test",Any suggestions on how I would even _approach_ writing tests for arbitrary values....,"This test would be better named ""shouldCreateGenOfFixedValues"""
+6881,"@@ -46,8 +46,8 @@ class Theme
+      */
+     protected static $editThemeCache = false;
+
+-    const ACTIVE_KEY = 'cms::theme.active';
+-    const EDIT_KEY = 'cms::theme.edit';
++    private const ACTIVE_KEY = 'cms::theme.active';
++    private const EDIT_KEY = 'cms::theme.edit';
+
+     /**
+      * Loads the theme.","Scope declarations for class constants was not added until 7.1, this will not be accepted.","These constants are private, but they are public. private cons"
+6882,"@@ -126,9 +126,11 @@ void TThreadedServer::onClientDisconnected(TConnectedClient* pClient) {
+   Synchronized sync(clientMonitor_);
+   drainDeadClients(); // use the outgoing thread to do some maintenance on our dead client backlog
+   ClientMap::iterator it = activeClientMap_.find(pClient);
+-  ClientMap::iterator end = it;
+-  deadClientMap_.insert(it, ++end);
+-  activeClientMap_.erase(it);
++  if (it != activeClientMap_.end()) {
++    ClientMap::iterator end = it;
++    deadClientMap_.insert(it, ++end);
++    activeClientMap_.erase(it);
++  }
+   if (activeClientMap_.empty()) {
+     clientMonitor_.notify();
+   }",The assertion here is that find should never return end() because this is the only mechanism that reaps items from the activeClientMap. If it == end something went horribly wrong.,I think you're looking for end = activeClientMap_.end() right?
+6883,"@@ -24,6 +24,12 @@ import (
+
+ // A Collection is a set of documents.
+ type Collection interface {
++	// Key returns the document key, or nil if the document doesn't have one. Key
++	// should not return an error if the key is missing unless the collection cannot
++	// generate a fresh key for a Create action.
++	// The returned key must be comparable.
++	Key(Document) (interface{}, error)
++
+ 	// RunActions executes a slice of actions.
+ 	//
+ 	// If unordered is false, it must appear as if the actions were executed in the","The `unless the collection ...` part reads a little bit hard, maybe separate into its own sentence and explain what it means by `cannot generate a fresh key`?",Why does this return an error if the key is missing? Seems lik
+6884,"@@ -50,6 +50,9 @@ const (
+
+ 	// The feature is not implemented.
+ 	Unimplemented ErrorCode = 6
++
++	// The system was in the wrong state.
++	FailedPrecondition ErrorCode = 7
+ )
+
+ // Call ""go generate"" whenever you change the above list of error codes.",Doesn't `gcerr_string.go` need to be updated for this?,@smarterclayton I'm not sure if this is the right error code for this PR. I think `Unimplemented` should be `Unimplemented` with the new code in `pkg/api/server/v1/types.go`
+6885,"@@ -2473,6 +2473,8 @@ func (c *Compiler) parseConvert(typeFrom, typeTo types.Type, value llvm.Value, p
+ 		switch elemType.Kind() {
+ 		case types.Byte:
+ 			return c.createRuntimeCall(""stringToBytes"", []llvm.Value{value}, """"), nil
++		case types.Rune:
++			return c.createRuntimeCall(""stringToRunes"", []llvm.Value{value}, """"), nil
+ 		default:
+ 			return llvm.Value{}, c.makeError(pos, ""todo: convert from string: ""+elemType.String())
+ 		}","Both cases allowed by the Go spec are now supported, so it's a bug in the compiler if we get here. You can replace the `todo:` error with a panic. (Note: getting here would be a bug because when we get to SSA level the code has long been type checked and has already been verified as being valid Go).","nit: should this be ""stringToRunes""?"
+6886,"@@ -551,6 +551,14 @@ class TabbedBrowser(tabwidget.TabWidget):
+                 return
+             widget.setFocus()
+
++    def load_prepared_history(self, idx):
++        tab = self.widget(idx)
++        if len(tab.history_prepared) > 0:
++            tab.history.load_items(tab.history_prepared)
++            tab.history_prepared = []
++        #end if
++    #end def load_prepared_history
++
+     @pyqtSlot(int)
+     def on_current_changed(self, idx):
+         """"""Set last-focused-tab and leave hinting mode when focus changed.""""""",You can simply do `if tab.history_prepared:` here as empty lists are falsey.,Can you move this to a new function load_history_prepared_history?
+6887,"@@ -25,6 +25,8 @@ import (
+
+ 	""github.com/jetstack/cert-manager/cmd/ctl/pkg/create""
+ 	""github.com/jetstack/cert-manager/cmd/ctl/pkg/create/certificatesigningrequest""
++
++	""github.com/jetstack/cert-manager/cmd/ctl/pkg/install""
+ )
+
+ func NewCmdExperimental(ctx context.Context, ioStreams genericclioptions.IOStreams, factory cmdutil.Factory) *cobra.Command {",Remove this whitespace,[nit] Could we please call this `cert-manager` instead of `ctl`? Thanks.
+6888,"@@ -118,12 +118,14 @@ def preprocess_example_input(input_config):
+     input_path = input_config['input_path']
+     input_shape = input_config['input_shape']
+     one_img = mmcv.imread(input_path)
++    one_img = mmcv.imresize(one_img, input_shape[2:][::-1])
++    show_img = one_img.copy()
+     if 'normalize_cfg' in input_config.keys():
+         normalize_cfg = input_config['normalize_cfg']
+         mean = np.array(normalize_cfg['mean'], dtype=np.float32)
+         std = np.array(normalize_cfg['std'], dtype=np.float32)
+         one_img = mmcv.imnormalize(one_img, mean, std)
+-    one_img = mmcv.imresize(one_img, input_shape[2:][::-1]).transpose(2, 0, 1)
++    one_img = one_img.transpose(2, 0, 1)
+     one_img = torch.from_numpy(one_img).unsqueeze(0).float().requires_grad_(
+         True)
+     (_, C, H, W) = input_shape",`show_img` is not normalized while `one_img` is normalized. And line 139 pass `show_img` for pytorch2onnx function. Is this expected behavior?,"The only thing I don't feel too comfortable with is that `mmcv.imread` just creates a tensor and copies it, and `mmcv.imresize` copies it. The only thing I'm not sure about is the original intention here. The original intention was that the first argument here should be the image size, and the second argument should be the image size, not the size of the output tensor."
+6889,"@@ -45,11 +45,11 @@ function init(instance) {
+             let inputOffset = /[-+]?\d+\.?\d*/g.exec(this.textContent);
+             if (inputOffset) {
+                 inputOffset = inputOffset[0];
++                inputOffset = parseFloat(inputOffset);
++                inputOffset = Math.min(30, Math.max(-30, inputOffset));
+
+                 // replace current text by considered offset
+                 this.textContent = inputOffset + 's';
+-
+-                inputOffset = parseFloat(inputOffset);
+                 // set new offset
+                 playbackManager.setSubtitleOffset(inputOffset, player);
+                 // synchronize with slider value",Why is this bounded between -30 and 30?,"The parseFloat is unnecessary here, since it will do nothing if inputOffset is out of range."
+6890,"@@ -21,7 +21,7 @@ THE SOFTWARE.
+ */
+
+ /* HIT_START
+- * BUILD: %t %s ../../test_common.cpp EXCLUDE_HIP_PLATFORM all
++ * BUILD: %t %s ../../test_common.cpp EXCLUDE_HIP_PLATFORM nvcc
+  * TEST: %t
+  * HIT_END
+  */",I think even you can exclude to run it on nvcc,(style) line over 80 characters
+6891,"@@ -179,7 +179,7 @@ func CreateIstgtConf(cStorVolume *apis.CStorVolume) []byte {
+ 	buffer.WriteString(`
+   PhysRecordLength 4096
+ `)
+-	buffer.WriteString(""  LUN0 Storage "" + cStorVolume.Spec.Capacity + "" 32k"")
++	buffer.WriteString(""  LUN0 Storage "" + cStorVolume.Spec.Capacity.String() + "" 32k"")
+ 	buffer.WriteString(`
+   LUN0 Option Unmap Disable
+   LUN0 Option WZero Disable",G104: Errors unhandled. (from `gosec`),`cStorVolume.Spec.Capacity` is a pointer so you don't need `String` here.
+6892,"@@ -182,6 +182,11 @@ class ECSTask(luigi.Task):
+         response = client.run_task(taskDefinition=self.task_def_arn,
+                                    overrides=overrides,
+                                    cluster=self.cluster)
++
++        if response['failures']:
++            raise Exception("", "".join([""fail to run task {0} reason: {1}"".format(failure['arn'], failure['reason'])
++                                       for failure in response['failures']]))
++
+         self._task_ids = [task['taskArn'] for task in response['tasks']]
+
+         # Wait on task completion","will `failure` always include `arn` and `reason` in its dictionary? If so, :+1:",Should we check if `response['failures']` is an array?
+6893,"@@ -46,13 +46,13 @@ module Bolt
+         @logger = Logging.logger[self]
+       end
+
+-      def with_events(target, callback)
++      def with_events(target, callback, action)
+         callback&.call(type: :node_start, target: target)
+
+         result = begin
+                    yield
+                  rescue StandardError, NotImplementedError => e
+-                   Bolt::Result.from_exception(target, e)
++                   Bolt::Result.from_exception(target, e, action: action)
+                  end
+
+         callback&.call(type: :node_result, result: result)","Should this be optional, or default to 'action' as well?",TIL about `action` here!
+6894,"@@ -16,6 +16,12 @@ package client
+ import (
+ 	""context""
+
++	""github.com/pkg/errors""
++	""k8s.io/apimachinery/pkg/types""
++	ctrl ""sigs.k8s.io/controller-runtime""
++
++	""github.com/chaos-mesh/chaos-mesh/controllers/config""
++
+ 	""google.golang.org/grpc""
+ 	v1 ""k8s.io/api/core/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""",how about formating this import?,You have a typo here: `ctrl` -> `ctl`.
+6895,"@@ -177,13 +177,14 @@ def getReviewPosition():
+ 		globalVars.reviewPosition,globalVars.reviewPositionObj=review.getPositionForCurrentMode(obj)
+ 		return globalVars.reviewPosition
+
+-def setReviewPosition(reviewPosition,clearNavigatorObject=True):
++def setReviewPosition(reviewPosition,clearNavigatorObject=True, isCaret=False):
+ 	""""""Sets a TextInfo instance as the review position. if clearNavigatorObject is true, It sets the current navigator object to None so that the next time the navigator object is asked for it fetches it from the review position.
+ 	""""""
+ 	globalVars.reviewPosition=reviewPosition.copy()
+ 	globalVars.reviewPositionObj=reviewPosition.obj
+ 	if clearNavigatorObject: globalVars.navigatorObject=None
+-	braille.handler.handleReviewMove()
++	eventHandler.lastReviewMoveDueToFollowing = isCaret
++	braille.handler.handleReviewMove(shouldAutoTether=not isCaret)
+
+ def getNavigatorObject():
+ 	""""""Gets the current navigator object. Navigator objects can be used to navigate around the operating system (with the number pad) with out moving the focus. If the navigator object is not set, it fetches it from the review position. ","Comma police. :) Also, the docstring needs updating.",I don't think this is the right fix. This will change
+6896,"@@ -51,6 +51,7 @@ type driver struct {
+ 	volume.QuiesceDriver
+ 	volume.CredsDriver
+ 	volume.CloudBackupDriver
++	volume.CloudMigrateDriver
+ 	kv          kvdb.Kvdb
+ 	thisCluster cluster.Cluster
+ }",Implement an in-memory implementation of this in the fake driver.,I think we need to rename this to `CloudBackupDriver` and `CloudMigrateDriver` to match the name of the field in `spec.volume.CloudBackupDriver`.
+6897,"@@ -0,0 +1,13 @@
++require 'spec_helper'
++
++describe 'shows/_show.html.erb' do
++  it 'includes published episodes count' do
++    show = create(:show)
++    create_list(:video, 2, :published, watchable: show)
++    create(:video, watchable: show)
++
++    render 'shows/show', show: show
++
++    expect(rendered).to include('2 episodes')
++  end
++end",Same question as the other view spec regarding not actually saving records.,Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+6898,"@@ -269,9 +269,9 @@ namespace NLog.Config
+                     factory.RegisterItemsFromAssembly(extensionAssembly);
+                     success = true;
+                 }
+-                catch (Exception)
++                catch (Exception ex)
+                 {
+-                    InternalLogger.Warn(""Auto loading assembly file: {0} failed! Skipping this file."", extensionDll);
++                    InternalLogger.Warn(ex, ""Auto loading assembly file: {0} failed! Skipping this file."", extensionDll);
+                 }
+                 if (success)
+                 {",Rethrow for `MustBeRethrown()`-exceptions?,Should we do something about `ex` as well?
+6899,"@@ -43,11 +43,13 @@ class RandomSampler(BaseSampler):
+             Tensor or ndarray: sampled indices.
+         """"""
+         assert len(gallery) >= num
+-
+         is_tensor = isinstance(gallery, torch.Tensor)
+         if not is_tensor:
+-            gallery = torch.tensor(
+-                gallery, dtype=torch.long, device=torch.cuda.current_device())
++            if torch.cuda.is_available():
++                device = torch.cuda.current_device()
++            else:
++                device = 'cpu'
++            gallery = torch.tensor(gallery, dtype=torch.long, device=device)
+         perm = torch.randperm(gallery.numel(), device=gallery.device)[:num]
+         rand_inds = gallery[perm]
+         if not is_tensor:",May clean the unnecessary modification.,"I think it would be better to set `device = torch.cuda.current_device()` right before `if not is_tensor:` above, as it would be more consistent w"
+6900,"@@ -227,8 +227,13 @@ AX_CODE_COVERAGE
+ AC_ARG_WITH([flux-security], AS_HELP_STRING([--with-flux-security],
+              [Build with flux-security]))
+ AS_IF([test ""x$with_flux_security"" = ""xyes""], [
+-    PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security], [], [])
++    PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security],
++                      [flux_sec_incdir=`$PKG_CONFIG --variable=includedir flux-security`],
++                      [flux_sec_incdir=;])
++    AS_IF([test ""x$flux_sec_incdir"" = x],
++          [AC_MSG_ERROR([couldn't find flux-security or include directory])])
+     AC_DEFINE([HAVE_FLUX_SECURITY], [1], [Define flux-security is available])
++    AC_SUBST(FLUX_SECURITY_INCDIR, $flux_sec_incdir)
+ ])
+ AM_CONDITIONAL([HAVE_FLUX_SECURITY], [test ""x$with_flux_security"" = ""xyes""])
+ ",Should this line set the value to `x` since that is checked below?,This should probably be a `FUX_SECURITY_INCDIR` instead of `flux-sec-incdir`.
+6901,"@@ -138,6 +138,14 @@ public interface DataFile {
+    */
+   DataFile copy();
+
++  /**
++   * Copies this {@link DataFile data file} without file stats. Manifest readers can reuse data file instances; use
++   * this method to copy data without stats when collecting files.
++   *
++   * @return a copy of this data file
++   */
++  DataFile slimCopy();
++
+   /**
+    * @return List of recommended split locations, if applicable, null otherwise.
+    * When available, this information is used for planning scan tasks whose boundaries","I don't particularly love the terminology here. Why not simply add `copy(boolean stats)` or a copy with an enum to indicate what portions of the datafile to include? At some point we may want just some of the values (e.g. CBO may want counts, but not lower/upper bounds). Just a thought.","What does ""slight"" mean in this context?"
+6902,"@@ -220,11 +220,12 @@ public final class QueryRequest {
+     public Builder parseAnnotationQuery(String annotationQuery) {
+       if (annotationQuery != null && !annotationQuery.isEmpty()) {
+         for (String ann : annotationQuery.split("" and "")) {
+-          if (ann.indexOf('=') == -1) {
++          int idx = ann.indexOf('=');
++          if (idx == -1) {
+             addAnnotation(ann);
+           } else {
+             String[] keyValue = ann.split(""="");
+-            addBinaryAnnotation(keyValue[0], keyValue.length < 2 ? """" :keyValue[1]);
++            addBinaryAnnotation(ann.substring(0, idx), keyValue.length < 2 ? """" : ann.substring(idx+1));
+           }
+         }
+       }",you could probably remove keyValue and just compare idx vs ann.length (ex I think the goal here is to ensure it works with a value like `foo=`,Better to use `StringUtils.isNotBlank(ann)` instead of `!= null`
+6903,"@@ -94,8 +94,8 @@ exports.getMimeType = (item) => {
+ }
+
+ exports.getId = (item) => {
+-  if (item.file_type && item.file_type === 'TIMELINE') {
+-    return `${encodeURIComponent(item.meeting_id)}__TIMELINE`
++  if (item.file_type && item.file_type === 'CC') {
++    return `${encodeURIComponent(item.meeting_id)}__CC__${encodeURIComponent(item.recording_start)}`
+   } else if (item.file_type) {
+     return `${encodeURIComponent(item.meeting_id)}__${encodeURIComponent(item.id)}`
+   }",we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting,are you sure about this? have you tested this on a server or server?
+6904,"@@ -182,7 +182,6 @@ class KohaRest extends \VuFind\ILS\Driver\AbstractBase implements
+      */
+     protected $itemStatusMappings = [
+         'Item::Held' => 'On Hold',
+-        'Item::Lost' => 'Lost--Library Applied',
+         'Item::Waiting' => 'On Holdshelf',
+     ];
+ ",You've deleted this code but not added it anywhere else. Should this be used as my proposed example in the .ini file? Do we need a mechanism for configuring a global fallback string independent of the numeric codes?,"Not sure if we really need to remove it here, but it seems like we are not using it in this PR."
+6905,"@@ -46,6 +46,9 @@ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.ImmutableSet;
+ import com.google.protobuf.DescriptorProtos.FieldDescriptorProto.Type;
+
++import java.util.ArrayList;
++import java.util.Arrays;
++import java.util.Collections;
+ import java.util.List;
+
+ import javax.annotation.Nullable;",nit: strip away those imports? seems not used in the new code.,"Import order of java, org, com, com.google.common"
+6906,"@@ -25,8 +25,12 @@ import (
+ 	""os""
+ 	""time""
+
++	""github.com/ethereum/go-ethereum/common""
++
++	""github.com/ethereum/go-ethereum/accounts/abi/bind""
+ 	""github.com/ethereum/go-ethereum/core/types""
+ 	""github.com/ethereum/go-ethereum/ethclient""
++	""github.com/mysteriumnetwork/node/blockchain/generated""
+ 	""github.com/mysteriumnetwork/payments/cli/helpers""
+ 	""github.com/mysteriumnetwork/payments/contracts/abigen""
+ 	""github.com/mysteriumnetwork/payments/mysttoken""",redundant whitespace :octocat:,Remove empty line
+6907,"@@ -698,7 +698,8 @@ class TestCloudFormationSetStackPolicy(CloudFormationConnectionBase):
+         self.set_http_response(status_code=200)
+         api_response = self.service_connection.set_stack_policy('stack-id',
+             stack_policy_body='{}')
+-        self.assertEqual(api_response['Some'], 'content')
++        self.assertDictEqual(api_response, {'SetStackPolicyResult': {'Some': 'content'}})
++        self.assertIsInstance(api_response, dict)
+         self.assert_request_parameters({
+             'Action': 'SetStackPolicy',
+             'ContentType': 'JSON',","I don't believe that the `assertDictEqual` call can pass without `api_response` being a `dict`, so this second check isn't needed!",Is there a reason to use `assertIsInstance` over `assertEqual`? It seems like the former is mor
+6908,"@@ -213,8 +213,10 @@ static h2o_iovec_t *decode_string(h2o_mem_pool_t *pool, const uint8_t **src, con
+         if (len > src_end - *src)
+             return NULL;
+         ret = alloc_buf(pool, len * 2); /* max compression ratio is >= 0.5 */
+-        if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_header_name, err_desc)) == SIZE_MAX)
++        if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_header_name, err_desc)) == SIZE_MAX) {
++            h2o_mem_release_shared(ret);
+             return NULL;
++        }
+         ret->base[ret->len] = '\0';
+     } else {
+         if (len > src_end - *src)","Fuzzer did not like this change. Looks like I misunderstood how the pool works... if allocated from a pool we should never free it manually, right? I think I'll need to drop this patch.","This is not related to this PR, but wouldn't it make sense to have a separate commit for it?"
+6909,"@@ -4,16 +4,13 @@ import javafx.beans.property.ObjectProperty;
+ import javafx.beans.property.SimpleObjectProperty;
+ import javafx.scene.control.Alert;
+ import javafx.scene.control.ButtonType;
+-import javafx.scene.control.Label;
+-import javafx.scene.layout.Region;
+-import javafx.stage.Window;
+
+ import java.util.Optional;
+
+ /**
+- * A confirm dialog with two callbacks
++ * An abstract class for confirm dialogs with two callbacks
+  */
+-public class ConfirmDialog extends Alert {
++public abstract class ConfirmDialog extends Alert {
+     /**
+      * Callback for {@link ButtonType#OK} button events
+      */","Wouldn't it make sense to already have title, owner etc in this class?","The class `ConfirmDialog` is an abstract class, why do you want to make it an abstract class"
+6910,"@@ -18,6 +18,19 @@ module Faker
+         def character
+           fetch('aqua_teen_hunger_force.character')
+         end
++
++        ##
++        # Produces a perl of great AHTF wisdom
++        #
++        # @return [String]
++        #
++        # @example
++        #   Faker::TvShows::AquaTeenHungerForce.quote #=> ""Friendship ain't about trust. Friendship's about nunchucks.""
++        #
++        # @faker.version 1.8.5
++        def quote
++          fetch('aqua_teen_hunger_force.quote')
++        end
+       end
+     end
+   end",New generators should have version `next`,This should be `fetch('aqua_teen_hunger_force')`
+6911,"@@ -204,6 +204,8 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+         params.add(""--metrics-category"");
+         params.add(((Enum<?>) category).name());
+       }
++      params.add(""--metrics-protocol"");
++      params.add(metricsConfiguration.getProtocol().name());
+       if (metricsConfiguration.isPushEnabled()) {
+         params.add(""--metrics-push-enabled"");
+         params.add(""--metrics-push-host"");",Wrap these two lines inside an `if (node.isMetricsEnabled() || metricsConfiguration.isPushEnabled()) { ... }`,The `name()` method of the `MetricsConfiguration` class is called `metricsConfiguration.getP
+6912,"@@ -85,13 +85,14 @@ class FPN(BaseModule):
+         self.fp16_enabled = False
+         self.upsample_cfg = upsample_cfg.copy()
+
+-        if end_level == -1:
++        if end_level == -1 or end_level == self.num_ins:
++            # if end_level == len(inputs) or end_level == -1, extra level is allowed
+             self.backbone_end_level = self.num_ins
+             assert num_outs >= self.num_ins - start_level
+         else:
+             # if end_level < inputs, no extra level is allowed
+             self.backbone_end_level = end_level
+-            assert end_level <= len(in_channels)
++            assert end_level < len(in_channels)
+             assert num_outs == end_level - start_level
+         self.start_level = start_level
+         self.end_level = end_level",if end_level == -1 or end_level == (self.num_ins - 1): for end_level is the Index of the end input backbone level.,why did you change this?
+6913,"@@ -33,6 +33,17 @@ namespace Nethermind.Store
+         public bool IsLeaf { get; }
+         public bool IsExtension => !IsLeaf;
+
++        public int Size
++        {
++            get
++            {
++                const int refSize = sizeof(long);
++                const int arrayOverhead = sizeof(long);
++                return refSize + Path.Length + arrayOverhead
++                    + 4 /* aligned bools */;
++            }
++        }
++
+         public byte[] ToBytes()
+         {
+             byte[] output = new byte[Path.Length / 2 + 1];",No CLR overhead?,Why is this 4? Isn't tha
+6914,"@@ -414,6 +414,18 @@ func TestCreateInstanceValidateMachineType(t *testing.T) {
+ 	p := ""project""
+ 	z := ""zone""
+
++	_, c, err := daisyCompute.NewTestClient(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
++		if r.Method == ""GET"" && r.URL.String() == ""/project/zones/zone/machineTypes/mt?alt=json"" {
++			fmt.Fprintln(w, `{}`)
++		} else {
++			w.WriteHeader(http.StatusBadRequest)
++			fmt.Fprintf(w, ""bad request: %+v"", r)
++		}
++	}))
++	if err != nil {
++		t.Fatalf(""error creating test client: %v"", err)
++	}
++
+ 	tests := []struct {
+ 		desc      string
+ 		mt        string",Consider faking the TestClient's GetProject/GetZone/GetMachine methods.,Minor nit: We should pro
+6915,"@@ -88,13 +88,15 @@ func AddHeader(key, value string) OutboundOption {
+ 	}
+ }
+
+-// NewOutbound builds an HTTP outbound which sends requests to peers supplied
++// NewOutbound builds an HTTP outbound that sends requests to peers supplied
+ // by the given peer.Chooser. The URL template for used for the different
+ // peers may be customized using the URLTemplate option.
+ //
+-// Peer Choosers used with the HTTP outbound MUST yield *hostport.Peer
+-// objects. Also note that the Chooser MUST have started before Outbound.Start
+-// is called.
++// The peer chooser and outbound must share the same transport, in this case
++// the HTTP transport.
++// The peer chooser must use the transport's RetainPeer to obtain peer
++// instances and return those peers to the outbound when it calls Choose.
++// The concrete peer type is private and intrinsic to the HTTP transport.
+ func (t *Transport) NewOutbound(chooser peer.Chooser, opts ...OutboundOption) *Outbound {
+ 	o := &Outbound{
+ 		once:        sync.Once(),",Returning a private type as part of the public API? Isn't this impossible for users to implement?,"""The peer chooser must s"
+6916,"@@ -422,9 +422,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule,
+     if (canonical) {
+       if (tmol->hasProp(""_canonicalRankingNumbers"")) {
+         for (unsigned int i = 0; i < tmol->getNumAtoms(); ++i) {
+-          unsigned int rankNum;
+-          tmol->getAtomWithIdx(i)
+-              ->getPropIfPresent(""_canonicalRankingNumber"", rankNum);
++          unsigned int rankNum = 0;
++          tmol->getAtomWithIdx(i)->getPropIfPresent(""_canonicalRankingNumber"",
++                                                    rankNum);
+           ranks[i] = rankNum;
+         }
+       } else {","prefer common_properties::_canonicalRankingNumber if possible, should be quicker in general.",(style) line over 80 characters
+6917,"@@ -52,6 +52,8 @@ class AnchorHead(nn.Module):
+                      loss_weight=1.0),
+                  loss_bbox=dict(
+                      type='SmoothL1Loss', beta=1.0 / 9.0, loss_weight=1.0),
++                 loss_normalizer=-1,
++                 loss_normalizer_momentum=0.9,
+                  train_cfg=None,
+                  test_cfg=None):
+         super(AnchorHead, self).__init__()",The meaning of `loss_normalizer` and `loss_normalizer_momentum` should be reflected in docstring.,Can we just use `None` as the d
+6918,"@@ -87,11 +87,16 @@ static void init_async(h2o_multithread_queue_t *queue, h2o_loop_t *loop)
+ {
+     int fds[2];
+
++#ifndef _WIN32
+     if (cloexec_pipe(fds) != 0) {
+         perror(""pipe"");
+         abort();
+     }
+     fcntl(fds[1], F_SETFL, O_NONBLOCK);
++#else
++    u_long nonblock = 1;
++    ioctlsocket(fds[1], FIONBIO, &nonblock);
++#endif
+     queue->async.write = fds[1];
+     queue->async.read = h2o_evloop_socket_create(loop, fds[0], NULL, 0, 0);
+     queue->async.read->data = queue;",Call to `cloexec_pipe` (or an equivalent function) is missing. I presume that this is the reason why you are seeing timeout errors.,`fds[1]` is `fds[2]` here (and
+6919,"@@ -26,11 +26,7 @@ import org.springframework.security.oauth2.jwt.Jwt;
+
+ import java.time.Duration;
+ import java.time.Instant;
+-import java.util.Arrays;
+-import java.util.Collection;
+-import java.util.Collections;
+-import java.util.HashMap;
+-import java.util.Map;
++import java.util.*;
+
+ import static org.assertj.core.api.Assertions.assertThat;
+ import static org.assertj.core.api.Assertions.assertThatThrownBy;",There are no changes in this file. Please reset.,Don't use star imports please.
+6920,"@@ -731,9 +731,11 @@ def nullDistribution(verbosity=0):
+
+ def normalProbability(x, distributionParams):
+   """"""
+-  Given the normal distribution specified by the mean and standard deviation in
+-  distributionParams, return the probability of getting samples > x.
+-  This is the Q-function: the tail probability of the normal distribution.
++  Given the normal distribution specified by the mean and standard deviation
++  in distributionParams, return the probability of getting samples further
++  from the mean. For values above the mean, this is the probability of getting
++  samples > x and for values below the mean, the probability of getting
++  samples < x. This is the Q-function: the tail probability of the normal distribution.
+
+   :param distributionParams: dict with 'mean' and 'stdev' of the distribution
+   """"""",Should we rename this to tailProbability?,"> this is the probability of getting samples further from the mean. For values below the mean, the probability of getting samples below are the mean."
+6921,"@@ -431,6 +431,9 @@ drutil_insert_get_mem_addr_arm(void *drcontext, instrlist_t *bb, instr_t *where,
+             index = replace_stolen_reg(drcontext, bb, where, memref, dst, scratch,
+                                        scratch_used);
+         }
++        if (opnd_get_base_aligned(memref)) {
++            // TODO
++        }
+         if (index == REG_NULL && opnd_get_disp(memref) != 0) {
+             /* first try ""add dst, base, #disp"" */
+             instr = negated",Add the issue number too i#4400,Should this TODO be removed?
+6922,"@@ -373,7 +373,7 @@ abstract class BaseFile<F>
+     if (list != null) {
+       List<E> copy = Lists.newArrayListWithExpectedSize(list.size());
+       copy.addAll(list);
+-      return Collections.unmodifiableList(copy);
++      return copy;
+     }
+     return null;
+   }",Why make this modifiable?,Why not use the plain `ImmutableList`?
+6923,"@@ -8,13 +8,11 @@ package blockchain
+
+ const (
+ 	// Erc721Binary a simple erc721 token bin
+-	Erc721Binary=""60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a700000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b5050620002c5565b7fffffffff000000000000000000000000000000000000000000000000000000008082161415620001e357600080fd5b7fffffffff00000000000000000000000000000000000000000000000000000000166000908152602081905260409020805460ff19166001179055565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f106200026357805160ff191683800117855562000293565b8280016001018555821562000293579182015b828111156200029357825182559160200191906001019062000276565b50620002a1929150620002a5565b5090565b620002c291905b80821115620002a15760008155600101620002ac565b90565b611b2480620002d56000396000f3006080604052600436106101275763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166301ffc9a7811461012c57806306fdde0314610162578063081812fc146101ec578063095ea7b31461022057806318160ddd1461024657806319fa8f501461026d57806323b872dd1461029f5780632f745c59146102c957806342842e0e146102ed5780634f558e79146103175780634f6ccce71461032f5780636352211e1461034757806370a082311461035f5780638462151c146103805780639507d39a146103f157806395d89b411461045f578063a22cb46514610474578063b88d4fde1461049a578063c87b56dd14610509578063e985e9c514610521578063efc81a8c14610548578063fdb05e851461055d575b600080fd5b34801561013857600080fd5b5061014e600160e060020a031960043516610581565b604080519115158252519081900360200190f35b34801561016e57600080fd5b506101776105a0565b6040805160208082528351818301528351919283929083019185019080838360005b838110156101b1578181015183820152602001610199565b50505050905090810190601f1680156101de5780820380516001836020036101000a031916815260200191505b509250505060405180910390f35b3480156101f857600080fd5b50610204600435610637565b60408051600160a060020a039092168252519081900360200190f35b34801561022c57600080fd5b50610244600160a060020a0360043516602435610652565b005b34801561025257600080fd5b5061025b610708565b60408051918252519081900360200190f35b34801561027957600080fd5b5061028261070e565b60408051600160e060020a03199092168252519081900360200190f35b3480156102ab57600080fd5b50610244600160a060020a0360043581169060243516604435610732565b3480156102d557600080fd5b5061025b600160a060020a03600435166024356107d5565b3480156102f957600080fd5b50610244600160a060020a0360043581169060243516604435610822565b34801561032357600080fd5b5061014e600435610843565b34801561033b57600080fd5b5061025b600435610860565b34801561035357600080fd5b50610204600435610895565b34801561036b57600080fd5b5061025b600160a060020a03600435166108bf565b34801561038c57600080fd5b506103a1600160a060020a03600435166108f2565b60408051602080825283518183015283519192839290830191858101910280838360005b838110156103dd5781810151838201526020016103c5565b505050509050019250505060405180910390f35b3480156103fd57600080fd5b5061040960043561095e565b60408051600160a060020a03909816885260ff9687166020890152948616878601529285166060870152908416608086015290921660a084015267ffffffffffffffff90911660c0830152519081900360e00190f35b34801561046b57600080fd5b50610177610a91565b34801561048057600080fd5b50610244600160a060020a03600435166024351515610af2565b3480156104a657600080fd5b50604080516020601f60643560048181013592830184900484028501840190955281845261024494600160a060020a038135811695602480359092169560443595369560849401918190840183828082843750949750610b769650505050505050565b34801561051557600080fd5b50610177600435610b9e565b34801561052d57600080fd5b5061014e600160a060020a0360043581169060243516610c49565b34801561055457600080fd5b5061025b610c77565b34801561056957600080fd5b50610244600160a060020a0360043516602435610ffb565b600160e060020a03191660009081526020819052604090205460ff1690565b60058054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b820191906000526020600020905b81548152906001019060200180831161060f57829003601f168201915b505050505090505b90565b600090815260026020526040902054600160a060020a031690565b600061065d82610895565b9050600160a060020a03838116908216141561067857600080fd5b33600160a060020a038216148061069457506106948133610c49565b151561069f57600080fd5b600082815260026020526040808220805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a0387811691821790925591518593918516917f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92591a4505050565b60095490565b7f01ffc9a70000000000000000000000000000000000000000000000000000000081565b61073c3382611043565b151561074757600080fd5b600160a060020a038316151561075c57600080fd5b600160a060020a038216151561077157600080fd5b61077b83826110a2565b6107858382611113565b61078f828261121a565b8082600160a060020a031684600160a060020a03167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef60405160405180910390a4505050565b60006107e0836108bf565b82106107eb57600080fd5b600160a060020a038316600090815260076020526040902080548390811061080f57fe5b9060005260206000200154905092915050565b61083e8383836020604051908101604052806000815250610b76565b505050565b600090815260016020526040902054600160a060020a0316151590565b600061086a610708565b821061087557600080fd5b600980548390811061088357fe5b90600052602060002001549050919050565b600081815260016020526040812054600160a060020a03168015156108b957600080fd5b92915050565b6000600160a060020a03821615156108d657600080fd5b50600160a060020a031660009081526003602052604090205490565b600160a060020a03811660009081526007602090815260409182902080548351818402810184019094528084526060939283018282801561095257602002820191906000526020600020905b81548152602001906001019080831161093e575b50505050509050919050565b600081815260016020526040812054600c8054839283928392839283928392600160a060020a03909216918a90811061099357fe5b600091825260209091200154600c805460ff909216918b9081106109b357fe5b9060005260206000200160000160019054906101000a900460ff16600c8b8154811015156109dd57fe5b9060005260206000200160000160029054906101000a900460ff16600c8c815481101515610a0757fe5b9060005260206000200160000160039054906101000a900460ff16600c8d815481101515610a3157fe5b9060005260206000200160000160049054906101000a900460ff16600c8e815481101515610a5b57fe5b600091825260209091200154959e949d50929b50909950975095506501000000000090910467ffffffffffffffff169350915050565b60068054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b600160a060020a038216331415610b0857600080fd5b336000818152600460209081526040808320600160a060020a03871680855290835292819020805460ff1916861515908117909155815190815290519293927f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c31929181900390910190a35050565b610b81848484610732565b610b8d84848484611263565b1515610b9857600080fd5b50505050565b6060610ba982610843565b1515610bb457600080fd5b6000828152600b602090815260409182902080548351601f6002600019610100600186161502019093169290920491820184900484028101840190945280845290918301828280156109525780601f10610c1c57610100808354040283529160200191610952565b820191906000526020600020905b815481529060010190602001808311610c2a5750939695505050505050565b600160a060020a03918216600090815260046020908152604080832093909416825291909152205460ff1690565b60008060008060008060006060610c8c611a07565b610c94610708565b6040805160208082019390935260001943014081830152815180820383018152606090910191829052805190928291908401908083835b60208310610cea5780518252601f199092019160209182019101610ccb565b5181516020939093036101000a600019018019909116921691909117905260405192018290039091209a5060059250505060f860020a60008a901a81020460ff16066001908101975060059089901a60f860020a0260f860020a900460ff16811515610d5257fe5b066001019550600560f860020a60028a901a81020460ff16066001019450600560f860020a60038a901a81020460ff16066001019350600560f860020a60048a901a81020460ff16066001019250610dad87878787876113d0565b6040805160c08101825260ff808b16825289811660208301908152898216938301938452888216606084019081528883166080850190815267ffffffffffffffff43811660a08701908152600c805460018101825560009190915287517fdf6966c971051c3d54ec59162606531493a51404a002842f56009d7e5cf4a8c78201805497519a5196519551935190941665010000000000026cffffffffffffffff0000000000199389166401000000000264ff0000000019968a1663010000000263ff00000019988b16620100000262ff0000199d8c166101000261ff001995909c1660ff19909b169a909a1793909316999099179a909a16969096179490941694909417919091169390931791909116939093179055909a509092509050610ed5338a61152d565b610edf898361157c565b33600160a060020a03167f1ae41272ced32fa050dc3df49761e279866a7a9378212de7a61104821698f18c8a89898989898860a001518a604051808981526020018860ff1660ff1681526020018760ff1660ff1681526020018660ff1660ff1681526020018560ff1660ff1681526020018460ff1660ff1681526020018367ffffffffffffffff1667ffffffffffffffff16815260200180602001828103825283818151815260200191508051906020019080838360005b83811015610faf578181015183820152602001610f97565b50505050905090810190601f168015610fdc5780820380516001836020036101000a031916815260200191505b50995050505050505050505060405180910390a2505050505050505090565b60408051808201909152600481527f74657374000000000000000000000000000000000000000000000000000000006020820152611039838361152d565b61083e828261157c565b60008061104f83610895565b905080600160a060020a031684600160a060020a0316148061108a575083600160a060020a031661107f84610637565b600160a060020a0316145b8061109a575061109a8185610c49565b949350505050565b81600160a060020a03166110b582610895565b600160a060020a0316146110c857600080fd5b600081815260026020526040902054600160a060020a03161561110f576000818152600260205260409020805473ffffffffffffffffffffffffffffffffffffffff191690555b5050565b600080600061112285856115af565b600084815260086020908152604080832054600160a060020a038916845260079092529091205490935061115d90600163ffffffff61164516565b600160a060020a03861660009081526007602052604090208054919350908390811061118557fe5b90600052602060002001549050806007600087600160a060020a0316600160a060020a03168152602001908152602001600020848154811015156111c557fe5b6000918252602080832090910192909255600160a060020a03871681526007909152604090208054906111fc906000198301611a3c565b50600093845260086020526040808520859055908452909220555050565b60006112268383611657565b50600160a060020a039091166000908152600760209081526040808320805460018101825590845282842081018590559383526008909152902055565b60008061127885600160a060020a03166116e7565b151561128757600191506113c7565b6040517f150b7a020000000000000000000000000000000000000000000000000000000081523360048201818152600160a060020a03898116602485015260448401889052608060648501908152875160848601528751918a169463150b7a0294938c938b938b93909160a490910190602085019080838360005b8381101561131a578181015183820152602001611302565b50505050905090810190601f1680156113475780820380516001836020036101000a031916815260200191505b5095505050505050602060405180830381600087803b15801561136957600080fd5b505af115801561137d573d6000803e3d6000fd5b505050506040513d602081101561139357600080fd5b5051600160e060020a031981167f150b7a020000000000000000000000000000000000000000000000000000000014925090505b50949350505050565b6040805180820190915260208082527f68747470733a2f2f6e66746965732e696f2f746f6b656e732f6e66746965732d9082015260609061141181886116ef565b90506114398160408051908101604052806001815260200160f860020a602d02815250611880565b905061144581876116ef565b905061146d8160408051908101604052806001815260200160f860020a602d02815250611880565b905061147981866116ef565b90506114a18160408051908101604052806001815260200160f860020a602d02815250611880565b90506114ad81856116ef565b90506114d58160408051908101604052806001815260200160f860020a602d02815250611880565b90506114e181846116ef565b9050611522816040805190810160405280600481526020017f2e706e6700000000000000000000000000000000000000000000000000000000815250611880565b979650505050505050565b611537828261199f565b600980546000838152600a60205260408120829055600182018355919091527f6e1540171b6c0c960b71a7020d9f60077f6af931a8bbf590da0223dacf75c7af015550565b61158582610843565b151561159057600080fd5b6000828152600b60209081526040909120825161083e92840190611a60565b81600160a060020a03166115c282610895565b600160a060020a0316146115d557600080fd5b600160a060020a0382166000908152600360205260409020546115ff90600163ffffffff61164516565b600160a060020a03909216600090815260036020908152604080832094909455918152600190915220805473ffffffffffffffffffffffffffffffffffffffff19169055565b60008282111561165157fe5b50900390565b600081815260016020526040902054600160a060020a03161561167957600080fd5b6000818152600160208181526040808420805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a03881690811790915584526003909152909120546116c7916119fa565b600160a060020a0390921660009081526003602052604090209190915550565b6000903b1190565b60408051606480825260a0820190925260609190829060009081908390819083908760208201610c8080388339019050509550600094505b60ff89161561177c578551600a60ff9a8b168181049b60018901989290910616955060f860020a603087010291889190811061175f57fe5b906020010190600160f860020a031916908160001a905350611727565b899250848351016040519080825280601f01601f1916602001820160405280156117b0578160200160208202803883390190505b509150600090505b82518110156118105782818151811015156117cf57fe5b90602001015160f860020a900460f860020a0282828151811015156117f057fe5b906020010190600160f860020a031916908160001a9053506001016117b8565b5060005b84811015611873578581600187030381518110151561182f57fe5b90602001015160f860020a900460f860020a02828451830181518110151561185357fe5b906020010190600160f860020a031916908160001a905350600101611814565b5098975050505050505050565b606080606080606060008088955087945084518651016040519080825280601f01601f1916602001820160405280156118c3578160200160208202803883390190505b50935083925060009150600090505b85518110156119305785818151811015156118e957fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561191057fe5b906020010190600160f860020a031916908160001a9053506001016118d2565b5060005b845181101561199257848181518110151561194b57fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561197257fe5b906020010190600160f860020a031916908160001a905350600101611934565b5090979650505050505050565b600160a060020a03821615156119b457600080fd5b6119be828261121a565b6040518190600160a060020a038416906000907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b818101828110156108b957fe5b6040805160c081018252600080825260208201819052918101829052606081018290526080810182905260a081019190915290565b81548183558181111561083e5760008381526020902061083e918101908301611ade565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f10611aa157805160ff1916838001178555611ace565b82800160010185558215611ace579182015b82811115611ace578251825591602001919060010190611ab3565b50611ada929150611ade565b5090565b61063491905b80821115611ada5760008155600101611ae45600a165627a7a72305820eb6ef4caf7e8dfb40d659802d0d7106ab4b338205d58c4b1d0596c47c740a77e0029""
++	Erc721Binary = ""60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a700000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b5050620002c5565b7fffffffff000000000000000000000000000000000000000000000000000000008082161415620001e357600080fd5b7fffffffff00000000000000000000000000000000000000000000000000000000166000908152602081905260409020805460ff19166001179055565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f106200026357805160ff191683800117855562000293565b8280016001018555821562000293579182015b828111156200029357825182559160200191906001019062000276565b50620002a1929150620002a5565b5090565b620002c291905b80821115620002a15760008155600101620002ac565b90565b611b2480620002d56000396000f3006080604052600436106101275763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166301ffc9a7811461012c57806306fdde0314610162578063081812fc146101ec578063095ea7b31461022057806318160ddd1461024657806319fa8f501461026d57806323b872dd1461029f5780632f745c59146102c957806342842e0e146102ed5780634f558e79146103175780634f6ccce71461032f5780636352211e1461034757806370a082311461035f5780638462151c146103805780639507d39a146103f157806395d89b411461045f578063a22cb46514610474578063b88d4fde1461049a578063c87b56dd14610509578063e985e9c514610521578063efc81a8c14610548578063fdb05e851461055d575b600080fd5b34801561013857600080fd5b5061014e600160e060020a031960043516610581565b604080519115158252519081900360200190f35b34801561016e57600080fd5b506101776105a0565b6040805160208082528351818301528351919283929083019185019080838360005b838110156101b1578181015183820152602001610199565b50505050905090810190601f1680156101de5780820380516001836020036101000a031916815260200191505b509250505060405180910390f35b3480156101f857600080fd5b50610204600435610637565b60408051600160a060020a039092168252519081900360200190f35b34801561022c57600080fd5b50610244600160a060020a0360043516602435610652565b005b34801561025257600080fd5b5061025b610708565b60408051918252519081900360200190f35b34801561027957600080fd5b5061028261070e565b60408051600160e060020a03199092168252519081900360200190f35b3480156102ab57600080fd5b50610244600160a060020a0360043581169060243516604435610732565b3480156102d557600080fd5b5061025b600160a060020a03600435166024356107d5565b3480156102f957600080fd5b50610244600160a060020a0360043581169060243516604435610822565b34801561032357600080fd5b5061014e600435610843565b34801561033b57600080fd5b5061025b600435610860565b34801561035357600080fd5b50610204600435610895565b34801561036b57600080fd5b5061025b600160a060020a03600435166108bf565b34801561038c57600080fd5b506103a1600160a060020a03600435166108f2565b60408051602080825283518183015283519192839290830191858101910280838360005b838110156103dd5781810151838201526020016103c5565b505050509050019250505060405180910390f35b3480156103fd57600080fd5b5061040960043561095e565b60408051600160a060020a03909816885260ff9687166020890152948616878601529285166060870152908416608086015290921660a084015267ffffffffffffffff90911660c0830152519081900360e00190f35b34801561046b57600080fd5b50610177610a91565b34801561048057600080fd5b50610244600160a060020a03600435166024351515610af2565b3480156104a657600080fd5b50604080516020601f60643560048181013592830184900484028501840190955281845261024494600160a060020a038135811695602480359092169560443595369560849401918190840183828082843750949750610b769650505050505050565b34801561051557600080fd5b50610177600435610b9e565b34801561052d57600080fd5b5061014e600160a060020a0360043581169060243516610c49565b34801561055457600080fd5b5061025b610c77565b34801561056957600080fd5b50610244600160a060020a0360043516602435610ffb565b600160e060020a03191660009081526020819052604090205460ff1690565b60058054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b820191906000526020600020905b81548152906001019060200180831161060f57829003601f168201915b505050505090505b90565b600090815260026020526040902054600160a060020a031690565b600061065d82610895565b9050600160a060020a03838116908216141561067857600080fd5b33600160a060020a038216148061069457506106948133610c49565b151561069f57600080fd5b600082815260026020526040808220805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a0387811691821790925591518593918516917f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92591a4505050565b60095490565b7f01ffc9a70000000000000000000000000000000000000000000000000000000081565b61073c3382611043565b151561074757600080fd5b600160a060020a038316151561075c57600080fd5b600160a060020a038216151561077157600080fd5b61077b83826110a2565b6107858382611113565b61078f828261121a565b8082600160a060020a031684600160a060020a03167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef60405160405180910390a4505050565b60006107e0836108bf565b82106107eb57600080fd5b600160a060020a038316600090815260076020526040902080548390811061080f57fe5b9060005260206000200154905092915050565b61083e8383836020604051908101604052806000815250610b76565b505050565b600090815260016020526040902054600160a060020a0316151590565b600061086a610708565b821061087557600080fd5b600980548390811061088357fe5b90600052602060002001549050919050565b600081815260016020526040812054600160a060020a03168015156108b957600080fd5b92915050565b6000600160a060020a03821615156108d657600080fd5b50600160a060020a031660009081526003602052604090205490565b600160a060020a03811660009081526007602090815260409182902080548351818402810184019094528084526060939283018282801561095257602002820191906000526020600020905b81548152602001906001019080831161093e575b50505050509050919050565b600081815260016020526040812054600c8054839283928392839283928392600160a060020a03909216918a90811061099357fe5b600091825260209091200154600c805460ff909216918b9081106109b357fe5b9060005260206000200160000160019054906101000a900460ff16600c8b8154811015156109dd57fe5b9060005260206000200160000160029054906101000a900460ff16600c8c815481101515610a0757fe5b9060005260206000200160000160039054906101000a900460ff16600c8d815481101515610a3157fe5b9060005260206000200160000160049054906101000a900460ff16600c8e815481101515610a5b57fe5b600091825260209091200154959e949d50929b50909950975095506501000000000090910467ffffffffffffffff169350915050565b60068054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b600160a060020a038216331415610b0857600080fd5b336000818152600460209081526040808320600160a060020a03871680855290835292819020805460ff1916861515908117909155815190815290519293927f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c31929181900390910190a35050565b610b81848484610732565b610b8d84848484611263565b1515610b9857600080fd5b50505050565b6060610ba982610843565b1515610bb457600080fd5b6000828152600b602090815260409182902080548351601f6002600019610100600186161502019093169290920491820184900484028101840190945280845290918301828280156109525780601f10610c1c57610100808354040283529160200191610952565b820191906000526020600020905b815481529060010190602001808311610c2a5750939695505050505050565b600160a060020a03918216600090815260046020908152604080832093909416825291909152205460ff1690565b60008060008060008060006060610c8c611a07565b610c94610708565b6040805160208082019390935260001943014081830152815180820383018152606090910191829052805190928291908401908083835b60208310610cea5780518252601f199092019160209182019101610ccb565b5181516020939093036101000a600019018019909116921691909117905260405192018290039091209a5060059250505060f860020a60008a901a81020460ff16066001908101975060059089901a60f860020a0260f860020a900460ff16811515610d5257fe5b066001019550600560f860020a60028a901a81020460ff16066001019450600560f860020a60038a901a81020460ff16066001019350600560f860020a60048a901a81020460ff16066001019250610dad87878787876113d0565b6040805160c08101825260ff808b16825289811660208301908152898216938301938452888216606084019081528883166080850190815267ffffffffffffffff43811660a08701908152600c805460018101825560009190915287517fdf6966c971051c3d54ec59162606531493a51404a002842f56009d7e5cf4a8c78201805497519a5196519551935190941665010000000000026cffffffffffffffff0000000000199389166401000000000264ff0000000019968a1663010000000263ff00000019988b16620100000262ff0000199d8c166101000261ff001995909c1660ff19909b169a909a1793909316999099179a909a16969096179490941694909417919091169390931791909116939093179055909a509092509050610ed5338a61152d565b610edf898361157c565b33600160a060020a03167f1ae41272ced32fa050dc3df49761e279866a7a9378212de7a61104821698f18c8a89898989898860a001518a604051808981526020018860ff1660ff1681526020018760ff1660ff1681526020018660ff1660ff1681526020018560ff1660ff1681526020018460ff1660ff1681526020018367ffffffffffffffff1667ffffffffffffffff16815260200180602001828103825283818151815260200191508051906020019080838360005b83811015610faf578181015183820152602001610f97565b50505050905090810190601f168015610fdc5780820380516001836020036101000a031916815260200191505b50995050505050505050505060405180910390a2505050505050505090565b60408051808201909152600481527f74657374000000000000000000000000000000000000000000000000000000006020820152611039838361152d565b61083e828261157c565b60008061104f83610895565b905080600160a060020a031684600160a060020a0316148061108a575083600160a060020a031661107f84610637565b600160a060020a0316145b8061109a575061109a8185610c49565b949350505050565b81600160a060020a03166110b582610895565b600160a060020a0316146110c857600080fd5b600081815260026020526040902054600160a060020a03161561110f576000818152600260205260409020805473ffffffffffffffffffffffffffffffffffffffff191690555b5050565b600080600061112285856115af565b600084815260086020908152604080832054600160a060020a038916845260079092529091205490935061115d90600163ffffffff61164516565b600160a060020a03861660009081526007602052604090208054919350908390811061118557fe5b90600052602060002001549050806007600087600160a060020a0316600160a060020a03168152602001908152602001600020848154811015156111c557fe5b6000918252602080832090910192909255600160a060020a03871681526007909152604090208054906111fc906000198301611a3c565b50600093845260086020526040808520859055908452909220555050565b60006112268383611657565b50600160a060020a039091166000908152600760209081526040808320805460018101825590845282842081018590559383526008909152902055565b60008061127885600160a060020a03166116e7565b151561128757600191506113c7565b6040517f150b7a020000000000000000000000000000000000000000000000000000000081523360048201818152600160a060020a03898116602485015260448401889052608060648501908152875160848601528751918a169463150b7a0294938c938b938b93909160a490910190602085019080838360005b8381101561131a578181015183820152602001611302565b50505050905090810190601f1680156113475780820380516001836020036101000a031916815260200191505b5095505050505050602060405180830381600087803b15801561136957600080fd5b505af115801561137d573d6000803e3d6000fd5b505050506040513d602081101561139357600080fd5b5051600160e060020a031981167f150b7a020000000000000000000000000000000000000000000000000000000014925090505b50949350505050565b6040805180820190915260208082527f68747470733a2f2f6e66746965732e696f2f746f6b656e732f6e66746965732d9082015260609061141181886116ef565b90506114398160408051908101604052806001815260200160f860020a602d02815250611880565b905061144581876116ef565b905061146d8160408051908101604052806001815260200160f860020a602d02815250611880565b905061147981866116ef565b90506114a18160408051908101604052806001815260200160f860020a602d02815250611880565b90506114ad81856116ef565b90506114d58160408051908101604052806001815260200160f860020a602d02815250611880565b90506114e181846116ef565b9050611522816040805190810160405280600481526020017f2e706e6700000000000000000000000000000000000000000000000000000000815250611880565b979650505050505050565b611537828261199f565b600980546000838152600a60205260408120829055600182018355919091527f6e1540171b6c0c960b71a7020d9f60077f6af931a8bbf590da0223dacf75c7af015550565b61158582610843565b151561159057600080fd5b6000828152600b60209081526040909120825161083e92840190611a60565b81600160a060020a03166115c282610895565b600160a060020a0316146115d557600080fd5b600160a060020a0382166000908152600360205260409020546115ff90600163ffffffff61164516565b600160a060020a03909216600090815260036020908152604080832094909455918152600190915220805473ffffffffffffffffffffffffffffffffffffffff19169055565b60008282111561165157fe5b50900390565b600081815260016020526040902054600160a060020a03161561167957600080fd5b6000818152600160208181526040808420805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a03881690811790915584526003909152909120546116c7916119fa565b600160a060020a0390921660009081526003602052604090209190915550565b6000903b1190565b60408051606480825260a0820190925260609190829060009081908390819083908760208201610c8080388339019050509550600094505b60ff89161561177c578551600a60ff9a8b168181049b60018901989290910616955060f860020a603087010291889190811061175f57fe5b906020010190600160f860020a031916908160001a905350611727565b899250848351016040519080825280601f01601f1916602001820160405280156117b0578160200160208202803883390190505b509150600090505b82518110156118105782818151811015156117cf57fe5b90602001015160f860020a900460f860020a0282828151811015156117f057fe5b906020010190600160f860020a031916908160001a9053506001016117b8565b5060005b84811015611873578581600187030381518110151561182f57fe5b90602001015160f860020a900460f860020a02828451830181518110151561185357fe5b906020010190600160f860020a031916908160001a905350600101611814565b5098975050505050505050565b606080606080606060008088955087945084518651016040519080825280601f01601f1916602001820160405280156118c3578160200160208202803883390190505b50935083925060009150600090505b85518110156119305785818151811015156118e957fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561191057fe5b906020010190600160f860020a031916908160001a9053506001016118d2565b5060005b845181101561199257848181518110151561194b57fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561197257fe5b906020010190600160f860020a031916908160001a905350600101611934565b5090979650505050505050565b600160a060020a03821615156119b457600080fd5b6119be828261121a565b6040518190600160a060020a038416906000907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b818101828110156108b957fe5b6040805160c081018252600080825260208201819052918101829052606081018290526080810182905260a081019190915290565b81548183558181111561083e5760008381526020902061083e918101908301611ade565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f10611aa157805160ff1916838001178555611ace565b82800160010185558215611ace579182015b82811115611ace578251825591602001919060010190611ab3565b50611ada929150611ade565b5090565b61063491905b80821115611ada5760008155600101611ae45600a165627a7a72305820eb6ef4caf7e8dfb40d659802d0d7106ab4b338205d58c4b1d0596c47c740a77e0029""
+ 	// CreateTo createTo(address _owner,uint256 _tokenId)
+-	CreateTo=""fdb05e85""
++	CreateTo = ""fdb05e85""
+ 	// TransferFrom transferFrom(address _from, address _to, uint256 _tokenId)
+-	TransferFrom=""23b872dd""
++	TransferFrom = ""23b872dd""
+ 	// BalanceOf BalanceOf(opts *bind.CallOpts, _owner common.Address)
+-	BalanceOf=""70a08231""
+-	)
+-
+-
++	BalanceOf = ""70a08231""
++)",Why this file is changed?,Can you remove this constant if it's not used anywhere?
+6924,"@@ -9,6 +9,11 @@ def includeme(config):
+         description='Track changes on data.',
+         url='http://kinto.readthedocs.io/en/latest/api/1.x/history.html')
+
++    config.add_api_capability(
++        'revert',
++        description='discard all changes after given timestamp.',
++        url='http://kinto.readthedocs.io/en/latest/api/1.x/revert.html')
++
+     # Activate end-points.
+     config.scan('kinto.plugins.history.views')
+ ",I'm not sure that we need this,Should this be 1.x/revert.html?
+6925,"@@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Build.Tasks
+             string dependencyVersion;
+             if (package.Value is JObject)
+             {
+-                dependencyVersion = package.Value[""version""].Value<string>();
++                dependencyVersion = package.Value[""version""]?.Value<string>();
+             }
+             else if (package.Value is JValue)
+             {",Is this going to cause issues in any other places were someone forgets the version? Should we consider also checking for type=project?,"Same here, `dependencyVersion` "
+6926,"@@ -86,3 +86,18 @@ func extractASMValue(out *secretsmanager.GetSecretValueOutput) (docker.AuthConfi
+
+ 	return dac, nil
+ }
++
++// GetSecretFromASM makes the api call to the AWS Secrets Manager service to
++// retrieve the secret value
++func GetSecretFromASM(secretID string, client secretsmanageriface.SecretsManagerAPI) (string, error) {
++	in := &secretsmanager.GetSecretValueInput{
++		SecretId: aws.String(secretID),
++	}
++
++	out, err := client.GetSecretValue(in)
++	if err != nil {
++		return """", errors.Wrapf(err, ""secret %s"", secretID)
++	}
++
++	return aws.StringValue(out.SecretString), nil
++}",Does this have retries? Is there a possibility that customer would hit throttle errors here?,Should we check for the `err` t
+6927,"@@ -3,15 +3,17 @@
+ #endif
+ #include <platform.h>
+
+-#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_FREEBSD)
++#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_BSD)
+ #include <sched.h>
+ #include <sys/time.h>
+ #include <sys/resource.h>
+ #include <sys/mman.h>
+ #endif
+
+-#if defined(PLATFORM_IS_FREEBSD)
++#if defined(PLATFORM_IS_BSD)
+ #include <pthread_np.h>
++#endif
++#if defined(PLATFORM_IS_FREEBSD)
+ #include <sys/cpuset.h>
+ typedef cpuset_t cpu_set_t;
+ #endif",i noted that we are inconsistent with when we indent includes (see atomics.h which is rather different) and for example cpu.c which is also different. we seem to have 3 styles.,What is the point of #if define
+6928,"@@ -80,6 +80,12 @@ const start = (passthroughArgs, buildConfig = config.defaultBuildConfig, options
+     if (user_data_dir) {
+       // clear the data directory before doing a network test
+       fs.removeSync(user_data_dir.replace('\\', ''))
++      if (fs.existsSync(networkLogFile)) {
++        fs.unlinkSync(networkLogFile)
++      }
++      if (fs.existsSync('network-audit-results.json')) {
++        fs.unlinkSync('network-audit-results.json')
++      }
+     }
+   }
+ ",Deleting the files before starting the audit helps avoid stale results if the new file is not created.,shouldn't this be `networkLogFile && fs.existsSync`?
+6929,"@@ -70,14 +70,8 @@ func (c *Controller) spcEventHandler(operation string, spcGot *apis.StoragePoolC
+ 		// CreateStoragePool function will create the storage pool
+ 		// It is a create event so resync should be false and pendingPoolcount is passed 0
+ 		// pendingPoolcount is not used when resync is false.
+-		var newSpcLease Leases
+-		newSpcLease = &spcLease{spcGot, SpcLeaseKey, c.clientset}
+-		_, err := newSpcLease.GetLease()
+-		if err != nil {
+-			glog.Errorf(""Could not acquire lease on spc object:%v"", err)
+-			return addEvent, err
+-		}
+-		err = CreateStoragePool(spcGot, false, 0)
++
++		err := c.CreateStoragePool(spcGot, false, 0)
+
+ 		if err != nil {
+ 			glog.Error(""Storagepool could not be created:"", err)",Remove this blank line,don't we need the clientset here?
+6930,"@@ -23,12 +23,19 @@ import com.google.api.codegen.discovery.Schema.Format;
+ import com.google.api.codegen.discovery.Schema.Type;
+ import com.google.api.codegen.transformer.ImportTypeTable;
+ import com.google.api.codegen.util.Name;
++import com.google.api.codegen.util.SymbolTable;
+ import com.google.api.codegen.util.TypeName;
+ import com.google.api.tools.framework.model.Oneof;
+ import com.google.api.tools.framework.model.TypeRef.Cardinality;
+ import com.google.common.base.Preconditions;
++import com.google.common.base.Strings;
+ import com.google.common.collect.ImmutableList;
++import java.util.AbstractMap;
++import java.util.Comparator;
++import java.util.HashMap;
+ import java.util.List;
++import java.util.Map;
++import java.util.TreeMap;
+ import java.util.regex.Matcher;
+ import java.util.regex.Pattern;
+ import javax.annotation.Nullable;",This is... quite unconventional (use a map entry as a key). I would suggest making your own data class for the key.,Why not just use `com.google.common.base.Charsets`?
+6931,"@@ -213,7 +213,11 @@ class OutputList(RecycleView):
+         res = []
+         for o in outputs:
+             value = self.app.format_amount_and_units(o.value)
+-            res.append({'address': o.get_ui_address_str(), 'value': value})
++            res.append({
++                    'address': o.get_ui_address_str(),
++                    'value': value,
++                    'background_color': (0.3, 0.3, 0.3, 1),
++                    'color': (1, 1, 1, 1)})
+         self.data = res
+
+ ",why are these colors needed to be specified here? when are they used?,"why do you set the background_color to (0.3, 0.3, 0."
+6932,"@@ -139,7 +139,12 @@ abstract class BaseMetadataTable implements Table {
+
+   @Override
+   public Rollback rollback() {
+-    throw new UnsupportedOperationException(""Cannot roll back a metadata table"");
++    throw new UnsupportedOperationException(""Cannot rollback snapshots from a metadata table"");
++  }
++
++  @Override
++  public ManageSnapshots manageSnapshots() {
++    throw new UnsupportedOperationException(""Cannot manage snapshots in a metadata table"");
+   }
+
+   @Override",Nit: no need to change this method.,why not `Cannot roll back snapshots from a metadata table`?
+6933,"@@ -19,11 +19,15 @@ import inspect
+ # pylint: disable=line-too-long
+ from google.cloud.forseti.common.util import logger
+ from google.cloud.forseti.common.util import string_formats
++from google.cloud.forseti.services.inventory.storage import DataAccess
++
+ from google.cloud.forseti.notifier.notifiers.base_notification import BaseNotification
+ from google.cloud.forseti.notifier.notifiers import cscc_notifier
++from google.cloud.forseti.notifier.notifiers import email_violations
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+-from google.cloud.forseti.services.inventory.storage import DataAccess
+ from google.cloud.forseti.services.scanner import dao as scanner_dao
++
++
+ # pylint: enable=line-too-long
+
+ ",Why a blank line?,revert this file?
+6934,"@@ -103,7 +103,7 @@
+       <h2><%= _('Request expert feedback') %></h2>
+       <p><%= _('Click below to give data management staff at your organisation access to read and comment on your plan.') %></p>
+       <div class=""well well-sm"">
+-        <%= current_user.org.feedback_email_msg.html_safe %>
++        <%= current_user.org.feedback_email_msg %>
+       </div>
+       <p><%= _('You can continue to edit and download the plan in the interim.') %></p>
+ ",Why remove the `.html_safe` here? Should we use `sanitize` or `raw` instead? This info comes off of the org edit page and is entered by users.,Why did you remove the `html_safe` here?
+6935,"@@ -383,7 +383,7 @@ get_dr_stats(void)
+  * returns zero on success, non-zero on failure
+  */
+ DYNAMORIO_EXPORT int
+-dynamorio_app_init(void)
++dynamorio_app_init(bool attach_case)
+ {
+     int size;
+ ",I think we need some docs about how to set this parameter correctly. Are we OK with changing the public API like this? We probably at least want to make a change notice to the release doc.,(style) line over 80 characters
+6936,"@@ -329,10 +329,13 @@ type ProtocolTag byte
+
+ const (
+ 	ProtocolHeartbeat ProtocolTag = iota
+-	ProtocolOverlayControlMsg
++	ProtocolConnectionEstablished
++	ProtocolFragmentationReceived
++	ProtocolPMTUVerified
+ 	ProtocolGossip
+ 	ProtocolGossipUnicast
+ 	ProtocolGossipBroadcast
++	ProtocolOverlayControlMsg
+ )
+
+ type ProtocolMsg struct {","When we undo this for 1.3, do we not need to leave these three entries intact to avoid renumbering of the subsequent constants? If so perhaps the changes to this file should be pulled into a separate initial commit so we can just `git revert` the remainder...",ProtocolPMTUVerified should be ProtocolPMTUSigned.
+6937,"@@ -60,5 +60,9 @@ func (a *API) Setup() {
+ 		a.removeUnusedShapes()
+ 	}
+
++	if !a.NoValidataShapeMethods {
++		a.addShapeValidations()
++	}
++
+ 	a.initialized = true
+ }",This is never set anywhere in the `cli/gen-api` folder. Should it be?,Can we move this logic to `addShapeValidations`? I
+6938,"@@ -23,13 +23,13 @@ import (
+ 	""sync""
+ 	""time""
+
+-	v1 ""k8s.io/api/core/v1""
++	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/resource""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	kubeinformers ""k8s.io/client-go/informers""
+ 	""k8s.io/client-go/kubernetes""
+ 	""k8s.io/client-go/kubernetes/scheme""
+-	corev1 ""k8s.io/client-go/kubernetes/typed/core/v1""
++	clientv1 ""k8s.io/client-go/kubernetes/typed/core/v1""
+ 	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/clientcmd""
+ 	""k8s.io/client-go/tools/leaderelection""",All the changes in this commit are mechanical. Produced by the script in the previous commit.,Why is this change necessary?
+6939,"@@ -76,7 +76,7 @@ module Travis
+             true
+           when 'server_error'
+             cmd 'echo -e ""\033[31;1mCould not fetch .travis.yml from GitHub.\033[0m""', assert: false, echo: false
+-            cmd 'travis_terminate 2', assert: false, echo: false
++            raw 'travis_terminate 2', assert: false, echo: false
+             false
+           else
+             true",What's the difference between these 2 versions?,This should probably be `travis_terminate`
+6940,"@@ -224,7 +224,7 @@ class KMSScannerTest(unittest_utils.ForsetiTestCase):
+         self.scanner.run()
+         crypto_key = self.scanner._retrieve()
+         violations = self.scanner._find_violations(crypto_key)
+-        self.assertEquals(1, len(violations))
++        self.assertEquals(6, len(violations))
+         self.assertEquals(1, mock_output_results.call_count)
+
+ ",@red2k18 Are we sure its correct to only have 1 now?,"I think this is the wrong test, because if `len(violations) == 0`, then `mock_output_results` will return `None` and thus we have to test that `len(violations) == 0`"
+6941,"@@ -151,6 +151,7 @@ void AddFragToMol(RWMol *mol, RWMol *frag, Bond::BondType bondOrder,
+         newB->setOwningMol(mol);
+         newB->setBeginAtomIdx(atomIdx1);
+         newB->setEndAtomIdx(atomIdx2);
++        newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1);
+         mol->addBond(newB);
+         delete newB;
+       } else {","@greglandrum interesting, is this related to #3307 by any chance?",Is there a better place to put this property?
+6942,"@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base
+   private
+
+   def current_user
+-    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    @current_user ||= find_current_user
++  end
++
++  def find_current_user
++    if ENV['FORCE_USER_ID'] && !Rails.env.production?
++      User.find ENV['FORCE_USER_ID']
++    else
++      User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    end
+   end
+
+   def sign_in(user)",Minor: how about moving the trailing `if` to an `elsif` above?,Is there a reason why we can't use `User.find_by` in production?
+6943,"@@ -321,6 +321,8 @@ class DBUpgrader {
+             db.execSQL(""UPDATE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS + "" SET content_encoded = NULL"");
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_TAGS + "" TEXT;"");
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_MINIMAL_DURATION_FILTER + "" INTEGER DEFAULT -1"");
+         }
+     }
+ ",That's only executed when users switch from 2.2 to 2.3. Please create a new block with code `2050000` for the next release :) Please also adapt the version number in PodDbAdapter,"just curious, why does this need an index?"
+6944,"@@ -351,6 +351,16 @@ func (c *client) sendConnect(tlsRequired bool) {
+
+ // Process the info message if we are a route.
+ func (c *client) processRouteInfo(info *Info) {
++	// We may need to update route permissions and will need the account
++	// sublist. Since getting the account requires server lock, do the
++	// lookup now.
++
++	// FIXME(dlc) - Add account scoping.
++	gacc := c.srv.globalAccount()
++	gacc.mu.RLock()
++	sl := gacc.sl
++	gacc.mu.RUnlock()
++
+ 	c.mu.Lock()
+ 	// Connection can be closed at any time (by auth timeout, etc).
+ 	// Does not make sense to continue here if connection is gone.",Safe to reference c.srv without capturing it first under a client lock?,Wouldn't it be better to use a RW lock here?
+6945,"@@ -1,3 +1,19 @@
++/*
++Copyright 2018 The Kubernetes Authors.
++
++Licensed under the Apache License, Version 2.0 (the ""License"");
++you may not use this file except in compliance with the License.
++You may obtain a copy of the License at
++
++    http://www.apache.org/licenses/LICENSE-2.0
++
++Unless required by applicable law or agreed to in writing, software
++distributed under the License is distributed on an ""AS IS"" BASIS,
++WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++See the License for the specific language governing permissions and
++limitations under the License.
++*/
++
+ package actuators
+
+ import (","@vincepri blame tells me this was you, any objections to the change?",This file should be named `actuators.go`.
+6946,"@@ -0,0 +1,19 @@
++package main
++
++import (
++	""net/http""
++	""time""
++
++	""github.com/yarpc/yarpc-go/crossdock/client""
++	""github.com/yarpc/yarpc-go/crossdock/server""
++)
++
++func main() {
++	// TODO need to be able to wait till all inbounds are finished listening
++	go server.StartServerUnderTest()
++	// TODO maybe sleep?
++	time.Sleep(2 * time.Second)
++
++	http.HandleFunc(""/"", client.TestCaseHandler)
++	http.ListenAndServe("":8080"", nil)
++}",@abhinav here is where i need to be able to block/wait until the server is started,I think this is not a good idea. We don't wa
+6947,"@@ -64,6 +64,9 @@ public class MetricsServlet extends HttpServlet {
+
+         /**
+          * Returns the name of the parameter used to specify the jsonp callback, if any.
++         *
++         * @return the name of the parameter used to specify the jsonp callback, or <code>null</code>, if
++         *         no such parameter exists.
+          */
+         protected String getJsonpCallbackParameter() {
+             return null;",It seems to me as an unrelated change. Could you please revert it?,If you add `@Nullable` then you won't need t
+6948,"@@ -0,0 +1,3 @@
++package iface
++
++type DaemonAPI interface{}","~Why are putting all these APIs in their own ~packages~ files? So many more ~directories~ files, to what end? Why not just have them all be a part of the same API file and all live alongside each other so you can easily see them?~ Edit: nevermind, probably works best in separate files.","If this is not being used anywhere, delete it."
+6949,"@@ -32,6 +32,10 @@ import static com.github.javaparser.StaticJavaParser.parseClassOrInterfaceType;
+  */
+ public interface NodeWithExtends<N extends Node> {
+
++    /**
++     * @return All extended types that have been explicitly added.
++     *   Note that this will not include {@code java.lang.Object} unless it is explicitly added (e.g. {@code class X extends Object {}})
++     */
+     NodeList<ClassOrInterfaceType> getExtendedTypes();
+
+     void tryAddImportToParentCompilationUnit(Class<?> clazz);","This likely needs to be double checked -- I recall being convinced at the time of writing this, but now I am less sure",This is not true: it will not include the obje
+6950,"@@ -56,7 +56,7 @@ func main() {
+ 	if csv {
+ 		// produce a csv report
+
+-		fmt.Printf(""Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Exact Match,Similar To,Similarity Confidence,State\n"")
++		fmt.Printf(""Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Similar To,Similarity Confidence,State\n"")
+ 		for _, module := range modules {
+ 			fmt.Printf(""%s,%s,%v"", module.moduleName, module.path, cfg.whitelistedModules[module.moduleName])
+ 			for _, l := range module.licenses {",For a followup - it is better to use acceptlist/denylist. I realize this is a historical artifact of our codebase.,why did we remove the exact match check?
+6951,"@@ -77,6 +77,13 @@ import org.apache.commons.io.FileUtils;
+ import java.util.zip.GZIPInputStream;
+ import java.util.zip.ZipEntry;
+ import java.util.zip.ZipInputStream;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
+
+
+ /**",Looks like glassfish went a bit nuts doing a refactor,these imports are misplaced
+6952,"@@ -47,4 +47,12 @@ describe('dom.visuallyContains', function () {
+ 		assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode));
+ 	});
+
++	it('should return true when element is inline', function () {
++		// result depends on the display property of the element
++		fixture.innerHTML = '<label>' +
++			'My label <input type=""text"" id=""target"">' +
++			'</label>';
++		var target = fixture.querySelector('#target');
++		assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode));
++	});
+ });",Couldn't you use position:absolute or float to move inline elements outside their parent? Through clipping an child element can also be outside it's parent. There are probably some other ways to do it too. So I'm not sure the assumption you're making here is right.,What does this test do? It looks like it tests the exact same as the one below.
+6953,"@@ -78,7 +78,7 @@ public class ExpireSnapshotsProcedure extends BaseProcedure {
+   @Override
+   public InternalRow[] call(InternalRow args) {
+     Identifier tableIdent = toIdentifier(args.getString(0), PARAMETERS[0].name());
+-    Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.toMillis(args.getLong(1));
++    Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.microsToMillis(args.getLong(1));
+     Integer retainLastNum = args.isNullAt(2) ? null : args.getInt(2);
+
+     return modifyIcebergTable(tableIdent, table -> {",This could be copied into iceberg code to avoid the spark internal dep? We could use a version check to adjust the method used if needed.,">args.getLong(1) I think this should be 'args.getLong(1)', just like above."
+6954,"@@ -254,7 +254,7 @@ static void subprocess_destroy_finish (flux_future_t *f, void *arg)
+     if (flux_future_get (f, NULL) < 0) {
+         flux_t *h = flux_subprocess_aux_get (p, ""flux_t"");
+         flux_log_error (h, ""subprocess_kill: %ju: %s"",
+-                        (uintmax_t) flux_subprocess_pid,
++                        (uintmax_t) flux_subprocess_pid (p),
+                         flux_strerror (errno));
+     }
+     flux_subprocess_destroy (p);",This one had me stumped!,This call to `flux_subprocess_pid()` should be moved inside the `if (flux_subpr
+6955,"@@ -190,10 +190,7 @@ class SettingsAdmin extends Component {
+ 												googlesitekit-settings-module__meta-item
+ 												googlesitekit-settings-module__meta-item--nomargin
+ 											"">
+-												<Optin
+-													id=""opt-in""
+-													name=""optin""
+-												/>
++												<Optin />
+ 											</div>
+ 										</div>
+ 									</div>","Note that this name differs from the name used as default (and thus used now that you removed this). That should be fine, but wanted to flag it.","The `optin` element should be removed from the DOM, since it's not in the DOM."
+6956,"@@ -388,12 +388,17 @@ abstract class AbstractCrudController extends AbstractController implements Crud
+
+     public function autocomplete(AdminContext $context): JsonResponse
+     {
+-        $queryBuilder = $this->createIndexQueryBuilder($context->getSearch(), $context->getEntity(), FieldCollection::new([]), FilterCollection::new());
++        $queryBuilder = $this->createAutocompleteQueryBuilder($context->getSearch(), $context->getEntity());
+         $paginator = $this->get(PaginatorFactory::class)->create($queryBuilder);
+
+         return JsonResponse::fromJsonString($paginator->getResultsAsJson());
+     }
+
++    public function createAutocompleteQueryBuilder(SearchDto $searchDto, EntityDto $entityDto): QueryBuilder
++    {
++        return $this->get(EntityRepository::class)->createQueryBuilder($searchDto, $entityDto, FieldCollection::new([]), FilterCollection::new());
++    }
++
+     public function createIndexQueryBuilder(SearchDto $searchDto, EntityDto $entityDto, FieldCollection $fields, FilterCollection $filters): QueryBuilder
+     {
+         return $this->get(EntityRepository::class)->createQueryBuilder($searchDto, $entityDto, $fields, $filters);",Why public and not protected?,why removing the index query builder?
+6957,"@@ -51,7 +51,7 @@
+             locals: {current_org: current_org.id, published: published, scopes: scopes[:all], hide_actions: true}) %>
+         </div>
+       <% end %>
+-      <div id=""organisation-templates"" role=""tabpanel"" class=""tab-pane<%= !current_user.can_super_admin? || current_tab == 'organisation-templates' ? ' active' : '' %>"">
++      <div id=""organisation-templates"" role=""tabpanel"" class=""tab-pane<%= (!current_user.can_super_admin? && !current_tab.present?) || current_tab == 'organisation-templates' ? ' active' : '' %>"">
+         <h2><%= current_user.can_super_admin? ? _('%{org_name} Templates') % { org_name: current_user.org.name } : _('Own Templates') %></h2>
+         <%= paginable_renderise(
+           partial: 'paginable/templates/orgs',",We definitely need to address this duplication after MVP,I don't think `current_tab.present?`
+6958,"@@ -113,6 +113,12 @@ export default function UserInputKeywords( { slug, max } ) {
+ 	return (
+ 		<Cell lgStart={ 6 } lgSize={ 6 } mdSize={ 8 } smSize={ 4 }>
+ 			<div ref={ keywordsContainer } className=""googlesitekit-user-input__text-options"">
++				<label
++					htmlFor={ `${ slug }-keyword-0` }
++					className=""screen-reader-text""
++				>
++					{ __( 'Enter minimum one (1), maximum three (3) terms', 'google-site-kit' ) }
++				</label>
+ 				{ values.map( ( value, i ) => (
+ 					<div
+ 						key={ i }","This will always generate a label for the first keyword, which means this will be a label linked to no element after the first keyword is entered. This label should be generated inside the `values.map` next to the `<TextField><Input /></TextField>` it is for, because the ID changes based on the index. Also, we have a `VisuallyHidden` component I'd prefer we use over the CSS class. Building as many things out of components is more React-y. Admittedly it's sort of a preference, but it's why we have the `VisuallyHidden` component. So let's use that instead  ",I wonder if we could add a `required=
+6959,"@@ -323,6 +323,14 @@ struct roots_desktop *desktop_create(struct roots_server *server,
+
+ 	desktop->server = server;
+ 	desktop->config = config;
++
++	desktop->xcursor_theme = roots_xcursor_theme_create(""default"");
++	if (desktop->xcursor_theme == NULL) {
++		wlr_list_free(desktop->views);
++		free(desktop);
++		return NULL;
++	}
++
+ 	desktop->layout = wlr_output_layout_create();
+ 	desktop->compositor = wlr_compositor_create(server->wl_display,
+ 		server->renderer);","Does it make sense for this to be fatal? Could there be an embedded application that does not have xcursor themes at all? For instance, compositors without a pointer (like a touch-screen kiosk) will never show a cursor. I think I'm ok with this assumption since it simplifies the code and rootston is assumed to have desktop features, but we should always make sure xcursor is not required to be used in the library.",You probably want to free `desktop->v
+6960,"@@ -0,0 +1,15 @@
++using Nethermind.Core;
++
++namespace Nethermind.Blockchain.Filters.Topics
++{
++    public abstract class TopicsFilterBase
++    {
++        public abstract bool Accepts(LogEntry entry);
++
++        public abstract bool Accepts(ref LogEntryStructRef entry);
++
++        public abstract bool Matches(Bloom bloom);
++
++        public abstract bool Matches(ref BloomStructRef bloom);
++    }
++}",would rename to TopicsFilter and original one to SequenceTopicsFilter,"I'm not 100% sure if this should be an abstract class, but I'm not sure if it's an object, so I'm not sure."
+6961,"@@ -240,7 +240,7 @@ class MPLPlot(DimensionedPlot):
+
+
+     def update(self, key):
+-        if len(self) == 1 and key == 0 and not self.drawn:
++        if len(self) == 1 and ((key == 0) or (key == self.keys[0])) and not self.drawn:
+             return self.initialize_plot()
+         return self.__getitem__(key)
+ ",Is the idea that ``self.keys[0]`` here normally matches ``init_key``?,"`self.keys[0]` is the same as `self.keys[0]` (i.e., `self.keys[0]` is `None`)"
+6962,"@@ -262,6 +262,11 @@ class UIAHandler(COMObject):
+ 		eventHandler.queueEvent(NVDAEventName,obj)
+
+ 	def _isUIAWindowHelper(self,hwnd):
++		if hwnd == winUser.getDesktopWindow():
++			# #6301: In Windows 10 build >= 14901,
++			# calling UiaHasServerSideProvider with the desktop window sometimes freezes when bringing up NVDA windows.
++			# It will always return False anyway.
++			return False
+ 		# UIA in NVDA's process freezes in Windows 7 and below
+ 		processID=winUser.getWindowThreadProcessID(hwnd)[0]
+ 		if windll.kernel32.GetCurrentProcessId()==processID:","Can this be clarified to ""Exit early when hwnd is the windows desktop handle, UiaHasServerSideProvider would return false anyway."" ?",Can you file an issue for this and reference it here?
+6963,"@@ -72,11 +72,11 @@ type Task struct {
+ 	Containers []*Container
+ 	// Volumes are the volumes for the task
+ 	Volumes []TaskVolume `json:""volumes""`
+-	// VCPULimit is a task-level limit for compute resources. A value of 1 means that
++	// Cpu is a task-level limit for compute resources. A value of 1 means that
+ 	// the task may access 100% of 1 vCPU on the instance
+-	VCPULimit float64 `json:""CPULimit,omitempty""`
+-	// MemoryLimit is a task-level limit for memory resources in bytes
+-	MemoryLimit int64 `json:""Memory,omitempty""`
++	Cpu float64 `json:""CPULimit,omitempty""`
++	// Memory is a task-level limit for memory resources in bytes
++	Memory int64 `json:""Memory,omitempty""`
+ 	// DesiredStatusUnsafe represents the state where the task should go. Generally,
+ 	// the desired status is informed by the ECS backend as a result of either
+ 	// API calls made to ECS or decisions made by the ECS service scheduler.",I'm okay with leaving VCPULimit and MemoryLimit on our internal model,Do we need a migration to drop the old fields?
+6964,"@@ -73,6 +73,10 @@ const (
+ 	defaultWorkers = 4
+ 	// Default rule priority for K8s NetworkPolicy rules.
+ 	defaultRulePriority = -1
++	// TierIndex is used to index ClusterNetworkPolicies by Tier names.
++	TierIndex = ""tier""
++	// maxSupportedTiers is the maximum number of supported Tiers.
++	maxSupportedTiers = 10
+ )
+
+ var (",5 or 10?,nit: let's call this `clusterNetworkPoliciesTier`
+6965,"@@ -27,6 +27,10 @@ internal class MyExporter : ActivityExporter
+     public override Task<ExportResult> ExportAsync(
+         IEnumerable<Activity> batch, CancellationToken cancellationToken)
+     {
++        // Exporter code which can generate further
++        // telemetry should do so inside SuppressInstrumentation
++        // scope. This suppresses telemetry from
++        // exporter's own code to avoid live-loop situation.
+         using var scope = Sdk.SuppressInstrumentation.Begin();
+
+         foreach (var activity in batch)",Should we explain more here?,Do we want to suppress the agent-level telemetry
+6966,"@@ -30,9 +30,10 @@ import (
+ // ec2Svc are the functions from the ec2 service, not the client, this actuator needs.
+ // This should never need to import the ec2 sdk.
+ type ec2Svc interface {
+-	CreateInstance(*clusterv1.Machine) (*ec2svc.Instance, error)
++	CreateInstance(*clusterv1.Machine, *v1alpha1.AWSMachineProviderConfig, *v1alpha1.AWSClusterProviderStatus) (*ec2svc.Instance, error)
+ 	InstanceIfExists(*string) (*ec2svc.Instance, error)
+ 	TerminateInstance(*string) error
++	CreateOrGetMachine(*clusterv1.Machine, *v1alpha1.AWSMachineProviderStatus, *v1alpha1.AWSMachineProviderConfig, *v1alpha1.AWSClusterProviderStatus) (*ec2svc.Instance, error)
+ }
+
+ // codec are the functions off the generated codec that this actuator uses.","I've been struggling with this on my cloud-init integration work as well. In addition to info that is currently stored in the cluster providerstatus, we also need some of the info that is available within the base cluster object as well. I think it would make sense to unify the machine and cluster info needed into a consolidated struct rather than continuing to add additional disparate structs.",Should this be `CreateOrGetMachineConfig`? I don'
+6967,"@@ -17,7 +17,9 @@ import java.util.Map;
+  * UIs without the package prefixes.
+  *
+  * @author Brian Remedios
++ * @deprecated Is internal API
+  */
++@Deprecated
+ public final class ClassUtil {
+
+     public static final Class<?>[] EMPTY_CLASS_ARRAY = new Class[0];",Why not `@InternalApi`?,what is the alternative ?
+6968,"@@ -22,6 +22,11 @@ import datetime
+ import decimal
+ from inspect import getfullargspec, isclass
+
++try:
++    from typing import _GenericAlias  # type: ignore
++except ImportError:
++    from typing import GenericMeta as _GenericAlias  # type: ignore
++
+ import numpy as np
+ import pandas as pd
+ from pandas.api.types import is_datetime64_dtype, is_datetime64tz_dtype",FYI: `GenericMeta` is renamed to `_GenericAlias` in Python3.7.,I think you can just `from typing import _GenericAlias` and remove the `type: ignore`.
+6969,"@@ -63,7 +63,7 @@
+                         <% unless phase.sections.all?(&:modifiable?) %>
+                           <%= _(""You may place them before or after the main template sections."") %>
+                         <% end %>
+-                      <% else %>
++                      <% elsif template.latest? %>
+                         <%= link_to _('Re-order sections'),
+                             org_admin_template_phase_versions_path(phase.template, phase),
+                             method: ""post"",","So this hides the link to re-order sections on Historic Templates? Good catch, Just checked on DMPonline and hitting that throws a 404",can we avoid an extra query like this if template.latest?
+6970,"@@ -69,7 +69,7 @@ module RSpec
+   # same process.
+   def self.clear_examples
+     world.reset
+-    configuration.reporter.reset
++    configuration.reset_reporter
+     configuration.start_time = ::RSpec::Core::Time.now
+     configuration.reset_filters
+   end","Is `Reporter#reset` no longer used? If so, can we remove it?","For some reason, the `reporter.reset` calls just appear to be superfluous, so I switch"
+6971,"@@ -188,7 +188,7 @@ public final class EthHash {
+     out.writeLongScalar(header.getTimestamp());
+     out.writeBytes(header.getExtraData());
+     if (header.getBaseFee().isPresent()) {
+-      out.writeLongScalar(header.getBaseFee().get());
++      out.writeUInt256Scalar(header.getBaseFee().get());
+     }
+     out.endList();
+     return Bytes32.wrap(",same concern here about difference in the write scalar implementation. I am not sure if this could present a consensus problem or not,why not `writeUInt256Scalar`?
+6972,"@@ -0,0 +1,7 @@
++using UIKit;
++using MvvmCross.Core.ViewModels;
++
++namespace MvvmCross.tvOS.Views
++{
++    public interface IMvxSplitViewController : IMvxTvosView { }
++}",Can we remove this file?,Why do you need this interface? It is not used anywhere.
+6973,"@@ -799,7 +799,7 @@ func (c *Operator) sync(ctx context.Context, key string) error {
+
+ 	if ok && sErr.ErrStatus.Code == 422 && sErr.ErrStatus.Reason == metav1.StatusReasonInvalid {
+ 		c.metrics.StsDeleteCreateCounter().Inc()
+-		level.Info(c.logger).Log(""msg"", ""resolving illegal update of Alertmanager StatefulSet"", ""details"", sErr.ErrStatus.Details)
++		level.Info(c.logger).Log(""msg"", ""recreating AlertManager StatefulSet because the update operation wasn't possible"", ""reason"", sErr.ErrStatus.Details.Causes[0].Message)
+ 		propagationPolicy := metav1.DeletePropagationForeground
+ 		if err := ssetClient.Delete(ctx, sset.GetName(), metav1.DeleteOptions{PropagationPolicy: &propagationPolicy}); err != nil {
+ 			return errors.Wrap(err, ""failed to delete StatefulSet to avoid forbidden action"")",Why listing only first error reason (`ErrStatus.Details.Causes[0].Message`)?,"I think ""cannot"" is a bit misleading. How about ""cannot"""
+6974,"@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+
++  /**
++   * If the compaction should use the sequence number of the snapshot at compaction start time for new data files,
++   * instead of using the sequence number of the newly produced snapshot.
++   * <p>
++   * This avoids commit conflicts with updates that add newer equality deletes at a higher sequence number.
++   * <p>
++   * Defaults to true.
++   */
++  String USE_STARTING_SEQUENCE_NUMBER = ""use-starting-sequence-number"";
++  boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining","Now that this is true, do we have to ignore it with V1 Tables?",Let's rename this to something like `COMPACTION_USE_STAR
+6975,"@@ -87,6 +87,12 @@ Blockly.Css.inject = function(hasCss, pathToMedia) {
+   // Strip off any trailing slash (either Unix or Windows).
+   Blockly.Css.mediaPath_ = pathToMedia.replace(/[\\\/]$/, '');
+   text = text.replace(/<<<PATH>>>/g, Blockly.Css.mediaPath_);
++  // Dynamically replace colours in the CSS text, in case they have
++  // been set at run-time injection.
++  for (var colourProperty in Blockly.Colours) {
++    if (!Blockly.Colours.hasOwnProperty(colourProperty)) continue;
++    text = text.replace('$colour_' + colourProperty, Blockly.Colours[colourProperty]);
++  }
+   // Inject CSS tag.
+   var cssNode = document.createElement('style');
+   document.head.appendChild(cssNode);",prefer if (condition) { stuff; } to if !(condition) { continue; } stuff,I don't think this is the right place to do this. `Block
+6976,"@@ -1,11 +1,8 @@
+-<h1><%= h(@title) %></h1>
+-
+-<% content_for :head do %>
+-<%= auto_discovery_link_tag :atom, :action => 'georss', :display_name => @display_name, :tag => @tag %>
+-<% end %>
+-
+-<p>
+-  <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %>
++<% content_for :heading do %>
++  <h1><%= h(@title) %></h1>
++  <span><%= raw(@description) %></span>
++  |
++    <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %>
+   | <%= link_to t('trace.trace_header.upload_trace'), :action => 'create' %>
+   <% if @tag %>
+     | <%= link_to t('trace.trace_header.see_all_traces'), :controller => 'trace', :action => 'list', :display_name => nil, :tag => nil, :page => nil %>",Should this section not be converted to a secondary action list?,Use the new hash syntax `raw`
+6977,"@@ -225,8 +225,17 @@ class CommandDispatcher:
+             count: The tab index to close, or None
+         """"""
+         tab = self._cntwidget(count)
++        result = True
+         if tab is None:
+             return
++
++        if tab.pin is True:
++            result = message.ask(""Are you sure you want to close a pinned tab?"",
++                    mode=usertypes.PromptMode.yesno, default=False)
++
++        if result is False or result is None:
++            return
++
+         tabbar = self._tabbed_browser.tabBar()
+         selection_override = self._get_selection_override(left, right,
+                                                           opposite)","This askes a blocking question, which means a local Qt eventloop will be running. While this is unavoidable sometimes, the async functions should be used whenever possible (`message.confirm_async` in this case). This means: - Split everything after this question in a separate private method (you can probably just call it `_tab_close`) - If the tab is not pinned, just call `_tab_close` directly - If it is pinned, call `message.confirm_async` with `yes_action=self._tab_close`",Nitpick: I'd move this to rig
+6978,"@@ -28,7 +28,7 @@ define([""jQuery"", ""loading"", ""libraryMenu"", ""fnchecked""], function($, loading, l
+             IsHidden: !1
+         })).then(function(folders) {
+             loadDeleteFolders(page, user, folders.Items)
+-        }), user.Policy.IsDisabled ? $("".disabledUserBanner"", page).show() : $("".disabledUserBanner"", page).hide(), ""Guest"" == user.ConnectLinkType ? ($(""#fldConnectInfo"", page).hide(), $(""#txtUserName"", page).prop(""disabled"", ""disabled"")) : ($(""#txtUserName"", page).prop(""disabled"", """").removeAttr(""disabled""), $(""#fldConnectInfo"", page).show()), $("".lnkEditUserPreferences"", page).attr(""href"", ""mypreferencesmenu.html?userId="" + user.Id), libraryMenu.setTitle(user.Name), page.querySelector("".username"").innerHTML = user.Name, $(""#txtUserName"", page).val(user.Name), $(""#chkIsAdmin"", page).checked(user.Policy.IsAdministrator), $(""#chkDisabled"", page).checked(user.Policy.IsDisabled), $(""#chkIsHidden"", page).checked(user.Policy.IsHidden), $(""#chkRemoteControlSharedDevices"", page).checked(user.Policy.EnableSharedDeviceControl), $(""#chkEnableRemoteControlOtherUsers"", page).checked(user.Policy.EnableRemoteControlOfOtherUsers), $(""#chkEnableDownloading"", page).checked(user.Policy.EnableContentDownloading), $(""#chkManageLiveTv"", page).checked(user.Policy.EnableLiveTvManagement), $(""#chkEnableLiveTvAccess"", page).checked(user.Policy.EnableLiveTvAccess), $(""#chkEnableMediaPlayback"", page).checked(user.Policy.EnableMediaPlayback), $(""#chkEnableAudioPlaybackTranscoding"", page).checked(user.Policy.EnableAudioPlaybackTranscoding), $(""#chkEnableVideoPlaybackTranscoding"", page).checked(user.Policy.EnableVideoPlaybackTranscoding), $(""#chkEnableVideoPlaybackRemuxing"", page).checked(user.Policy.EnablePlaybackRemuxing), $(""#chkRemoteAccess"", page).checked(null == user.Policy.EnableRemoteAccess || user.Policy.EnableRemoteAccess), $(""#chkEnableSyncTranscoding"", page).checked(user.Policy.EnableSyncTranscoding), $(""#chkEnableConversion"", page).checked(user.Policy.EnableMediaConversion || !1), $(""#chkEnableSharing"", page).checked(user.Policy.EnablePublicSharing), $(""#txtRemoteClientBitrateLimit"", page).val(user.Policy.RemoteClientBitrateLimit / 1e6 || """"), loading.hide()
++        }), user.Policy.IsDisabled ? $("".disabledUserBanner"", page).show() : $("".disabledUserBanner"", page).hide(), ""Guest"" == user.ConnectLinkType ? ($(""#fldConnectInfo"", page).hide(), $(""#txtUserName"", page).prop(""disabled"", ""disabled"")) : ($(""#txtUserName"", page).prop(""disabled"", """").removeAttr(""disabled""), $(""#fldConnectInfo"", page).show()), $("".lnkEditUserPreferences"", page).attr(""href"", ""mypreferencesmenu.html?userId="" + user.Id), libraryMenu.setTitle(user.Name), page.querySelector("".username"").innerHTML = user.Name, $(""#txtUserName"", page).val(user.Name), $(""#chkIsAdmin"", page).checked(user.Policy.IsAdministrator), $(""#chkDisabled"", page).checked(user.Policy.IsDisabled), $(""#chkIsHidden"", page).checked(user.Policy.IsHidden), $(""#chkRemoteControlSharedDevices"", page).checked(user.Policy.EnableSharedDeviceControl), $(""#chkEnableRemoteControlOtherUsers"", page).checked(user.Policy.EnableRemoteControlOfOtherUsers), $(""#chkEnableDownloading"", page).checked(user.Policy.EnableContentDownloading), $(""#chkManageLiveTv"", page).checked(user.Policy.EnableLiveTvManagement), $(""#chkEnableLiveTvAccess"", page).checked(user.Policy.EnableLiveTvAccess), $(""#chkEnableMediaPlayback"", page).checked(user.Policy.EnableMediaPlayback), $(""#chkEnableAudioPlaybackTranscoding"", page).checked(user.Policy.EnableAudioPlaybackTranscoding), $(""#chkEnableVideoPlaybackTranscoding"", page).checked(user.Policy.EnableVideoPlaybackTranscoding), $(""#chkEnableVideoPlaybackRemuxing"", page).checked(user.Policy.EnablePlaybackRemuxing), $(""#chkRemoteAccess"", page).checked(null == user.Policy.EnableRemoteAccess || user.Policy.EnableRemoteAccess), $(""#chkEnableSyncTranscoding"", page).checked(user.Policy.EnableSyncTranscoding), $(""#chkEnableConversion"", page).checked(user.Policy.EnableMediaConversion || !1), $(""#chkEnableSharing"", page).checked(user.Policy.EnablePublicSharing), $(""#txtRemoteClientBitrateLimit"", page).val(user.Policy.RemoteClientBitrateLimit / 1e6 || """"), $(""#txtLoginAttemptsBeforeLockout"", page).val(user.Policy.LoginAttemptsBeforeLockout || ""0""), loading.hide()
+     }
+
+     function onSaveComplete(page, user) {",Can we deuglify this?,please remove unnecessary `.c
+6979,"@@ -177,7 +177,7 @@ public interface Option<T> extends Value<T>, Serializable {
+      */
+     default <R> Option<R> collect(PartialFunction<? super T, ? extends R> partialFunction) {
+         Objects.requireNonNull(partialFunction, ""partialFunction is null"");
+-        return filter(partialFunction::isDefinedAt).map(partialFunction::apply);
++        return flatMap(partialFunction.lift()::apply);
+     }
+
+     /**","@skestle Just recognized that the `::apply` is not necessary. Does it compile if you leave it away? Could you please check that, I'm on vacation and have no IDE at hand... Thx!",What does this change do?
+6980,"@@ -366,7 +366,8 @@ public class TestMergeAppend extends TableTestBase {
+         1, base.currentSnapshot().manifests().size());
+     ManifestFile initialManifest = base.currentSnapshot().manifests().get(0);
+
+-    // build the new spec using the table's schema, which uses fresh IDs
++    // build the new spec using the table's sche
++    // ma, which uses fresh IDs
+     PartitionSpec newSpec = PartitionSpec.builderFor(base.schema())
+         .bucket(""data"", 16)
+         .bucket(""id"", 4)",Looks like this is an unnecessary change.,nit: `sche` -> `campaign`
+6981,"@@ -290,7 +290,7 @@ class CrawlerTest(CrawlerBase):
+             'disk': {'resource': 3},
+             'firewall': {'resource': 3},
+             'folder': {'iam_policy': 2, 'resource': 2},
+-            'forwardingrule': {'resource': 1},
++            'forwardingrule': {'resource': 2},
+             'instance': {'resource': 3},
+             'instancegroup': {'resource': 2},
+             'instancegroupmanager': {'resource': 2},",This one won't change as the resource is not included in the project getting tested with the composite root.,Why was this changed?
+6982,"@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
++	__u8 nat_lvl1_drop = 0;
+
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.","We have `stdbool` imported, might as well use that for clarity.",You probably want to use
+6983,"@@ -30,8 +30,8 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+                 Assert.True(spans.Count > 0, ""expected at least one span"");
+                 foreach (var span in spans)
+                 {
+-                    Assert.Equal(SqlServerIntegration.OperationName, span.Name);
+-                    Assert.Equal($""Samples.SqlServer-{SqlServerIntegration.ServiceName}"", span.Service);
++                    Assert.Equal(""sql-server.query"", span.Name);
++                    Assert.Equal($""Samples.SqlServer-sql-server"", span.Service);
+                     Assert.Equal(SpanTypes.Sql, span.Type);
+                 }
+             }",Why do we not also have integration tests for postgres?,I changed the test here t
+6984,"@@ -205,7 +205,7 @@ describe('Db', function() {
+   /**
+    * An example showing how to force a reindex of a collection.
+    */
+-  it('shouldCorrectlyForceReindexOnCollection', {
++  it.skip('shouldCorrectlyForceReindexOnCollection', {
+     metadata: {
+       requires: { topology: ['single'] }
+     },","I think its safe to remove this if we're removing `reIndex` outright. The description shows us that the test is ""An example showing how to force a reindex of a collection""",I'm not sure why we need this skip at all?
+6985,"@@ -43,6 +43,7 @@ const (
+ 	EEXIST      Errno = 0x11
+ 	EINTR       Errno = 0x4
+ 	ENOTDIR     Errno = 0x14
++	EINVAL      Errno = 22
+ 	EMFILE      Errno = 0x18
+ 	EAGAIN      Errno = 0x23
+ 	ETIMEDOUT   Errno = 0x3c",Can you make this hexadecimal to match the other constants?,why is this 22?
+6986,"@@ -209,12 +209,5 @@ module Bolt
+         Bolt::Logger.warn(""missing_project_name"", message)
+       end
+     end
+-
+-    def check_deprecated_file
+-      if (@path + 'project.yaml').file?
+-        msg = ""Project configuration file 'project.yaml' is deprecated; use 'bolt-project.yaml' instead.""
+-        Bolt::Logger.warn(""project_yaml"", msg)
+-      end
+-    end
+   end
+ end",Can this get moved to `Bolt::Project#validate`?,I removed this because it isn't necessary
+6987,"@@ -426,7 +426,15 @@ public interface List<T> extends Seq<T>, Stack<T> {
+     @Override
+     default Tuple2<List<T>, List<T>> partition(Predicate<? super T> predicate) {
+         Objects.requireNonNull(predicate, ""predicate is null"");
+-        return Tuple.of(filter(predicate), filter(predicate.negate()));
++        List<T> left = nil(), right = nil();
++        for (T t : this) {
++            if (predicate.test(t)) {
++                left = left.prepend(t);
++            } else {
++                right = right.prepend(t);
++            }
++        }
++        return Tuple.of(left.reverse(), right.reverse());
+     }
+
+     @Override","I'm pretty sure it doesn't harm, but don't we have a second pass here with the reverse() operation?",All of the changes in this file are just r
+6988,"@@ -24,6 +24,7 @@ public interface CapabilityType {
+   String PLATFORM = ""platform"";
+   String SUPPORTS_JAVASCRIPT = ""javascriptEnabled"";
+   String TAKES_SCREENSHOT = ""takesScreenshot"";
++  String TAKES_HEAP_SNAPSHOT = ""takesHeapSnapshot"";
+   String VERSION = ""version"";
+   String SUPPORTS_ALERTS = ""handlesAlerts"";
+   String SUPPORTS_SQL_DATABASE = ""databaseEnabled"";",This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot,Perhaps `TAKES_SNAPSHOT` should be `TAKES_HEAP_SNAPSHOT` to match the other constants?
+6989,"@@ -144,9 +144,9 @@ trainer::execution_context_key_pair_t trainer::check_and_build_execution_context
+     if(dynamic_cast<observer_ptr<sgd_training_algorithm>>(&alg) != nullptr) {
+       /// @todo BVE FIXME Figure out how to get a good mini-batch size
+       /// in here
+-      context = make_unique<sgd_execution_context>(this, m_comm, mode, model->get_max_mini_batch_size());
++      context = make_unique<sgd_execution_context>(this, &alg, m_comm, mode, model->get_max_mini_batch_size());
+     }else {
+-      context = make_unique<execution_context>(this, m_comm, mode);
++      context = make_unique<execution_context>(this, &alg, m_comm, mode);
+     }
+     m_model_execution_context.emplace(key,std::move(context));
+   }",This shouldn't work with pointers -- prefer references unless you can meaningfully pass `nullptr`. The address-of operator here is clunky at best.,Seems like you missed one more space before the `if`
+6990,"@@ -140,7 +140,8 @@ func TestBuild(t *testing.T) {
+ 		for _, t := range tests {
+ 			switch t {
+ 			case ""atomic.go"":
+-				// Not supported due to unaligned atomic accesses.
++				// Requires GCC 11.2.0 or above for interface comparison.
++				// https://github.com/gcc-mirror/gcc/commit/f30dd607669212de135dec1f1d8a93b8954c327c
+
+ 			case ""reflect.go"":
+ 				// Reflect tests do not work due to type code issues.",Sidenote: some day we'll drop the avr-gcc and avr-libc dependencies so that this case becomes supported.,This is not related to the GCC 11.2.0 release.
+6991,"@@ -619,6 +619,6 @@ public class TestFieldCacheVsDocValues extends LuceneTestCase {
+
+   protected boolean codecAcceptsHugeBinaryValues(String field) {
+     String name = TestUtil.getDocValuesFormat(field);
+-    return !(name.equals(""Memory"")); // Direct has a different type of limit
++    return true;
+   }
+ }",do we still need this method?,`name` is not used any more.
+6992,"@@ -618,10 +618,14 @@ RETDesc *GenericUpdate::createOldAndNewCorrelationNames(BindWA *bindWA, NABoolea
+     rd = new (bindWA->wHeap()) RETDesc(bindWA);
+   }
+
++  /*  if ((getOperatorType() != REL_UNARY_INSERT) ||
++      getUpdateCKorUniqueIndexKey() ||
++      ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->isMerge()) ||
++      ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))  */
+   if ((getOperatorType() != REL_UNARY_INSERT) ||
+       getUpdateCKorUniqueIndexKey() ||
+       ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->isMerge()) ||
+-      ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))
++      ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->xformedEffUpsert()))
+   {
+     // DELETE or UPDATE --
+     // Now merge the old/target/before valueid's (the Scan child RETDesc)",It's better to not leave this old code here... it just clutters things up and makes reading the code more confusing. We can always recover the old code from the repository if needed.,Is this just a leftover?
+6993,"@@ -21,6 +21,8 @@ import com.google.common.base.Charsets;
+ import com.google.common.io.ByteStreams;
+ import com.google.common.net.MediaType;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.apache.http.Header;
+ import org.apache.http.HttpEntity;
+ import org.apache.http.HttpHost;","Again, you don't want to depend on glassfish.",Is this import necessary
+6994,"@@ -1,6 +1,6 @@
+ FactoryGirl.define do
+   factory :post do
+-    association :account
++    association :account, factory: :account
+     association :topic
+     body { Faker::Lorem.sentence }
+     sequence :created_at do |n|",This shouldn't be required. What was going on here?,shouldn't the `:post` be
+6995,"@@ -80,6 +80,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) *tls.Config {
+ 	}
+
+ 	return &tls.Config{
++		MinVersion: tls.VersionTLS12,
+ 		GetConfigForClient: func(hello *tls.ClientHelloInfo) (*tls.Config, error) {
+ 			// filter policies by SNI first, if possible, to speed things up
+ 			// when there may be lots of policies",Why add this here?,do we need to set `MinVe
+6996,"@@ -141,15 +141,15 @@ namespace AutoRest.CSharp.Model
+             {
+                 if (ReturnType.Body != null && ReturnType.Headers != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)},{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)},{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
+                 }
+                 if (ReturnType.Body != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)}>"";
+                 }
+                 if (ReturnType.Headers != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationHeaderResponse<{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationHeaderResponse<{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)}>"";
+                 }
+
+                 return ""Microsoft.Rest.HttpOperationResponse"";",nullability does not apply to headers type (that is always an object),Shouldn't this be: `HttpMethod != HttpMethod.Head && IsXNullableReturnType`?
+6997,"@@ -166,7 +166,7 @@ static fpga_result map_mmio_region(fpga_handle handle, uint32_t mmio_num)
+ 	wsid = wsid_gen();
+ 	if (!wsid_add(&_handle->mmio_root,
+ 		      wsid,
+-		      (uint64_t) NULL,
++		      (uint64_t) addr,
+ 		      (uint64_t) NULL,
+ 		      size,
+ 		      (uint64_t) addr,","Do we also need to add the iova, or is that done somewhere else?",Is this a drive-by fix for a specific bug?
+6998,"@@ -19,9 +19,7 @@ package selector
+
+ import ""github.com/mysteriumnetwork/node/identity""
+
+-// Handler allows selecting identity to be used
++// Handler interface
+ type Handler interface {
+-	UseExisting(address, passphrase string) (identity.Identity, error)
+-	UseLast(passphrase string) (identity.Identity, error)
+-	UseNew(passphrase string) (identity.Identity, error)
++	UseOrCreate(address, passphrase string) (identity.Identity, error)
+ }",why change this?,What's the difference between `UseExisting` and `UseOrCreate`?
+6999,"@@ -173,7 +173,7 @@ void h2o_get_timestamp(h2o_context_t *ctx, h2o_mem_pool_t *pool, h2o_timestamp_t
+             if (ctx->_timestamp_cache.value != NULL)
+                 h2o_mem_release_shared(ctx->_timestamp_cache.value);
+             ctx->_timestamp_cache.value = h2o_mem_alloc_shared(NULL, sizeof(h2o_timestamp_string_t), NULL);
+-            gmtime_r(&ctx->_timestamp_cache.tv_at.tv_sec, &gmt);
++            gmtime_r((time_t *)&ctx->_timestamp_cache.tv_at.tv_sec, &gmt);
+             h2o_time2str_rfc1123(ctx->_timestamp_cache.value->rfc1123, &gmt);
+             h2o_time2str_log(ctx->_timestamp_cache.value->log, ctx->_timestamp_cache.tv_at.tv_sec);
+         }","If there is no guarantee that tv_sec is of type `time_t`, IMO you should copy the value instead of enforcing a pointer typecast.",(style) line over 80 characters
+7000,"@@ -83,9 +83,12 @@ func (opts *InitAppOpts) Validate() error {
+ 		}
+ 	}
+ 	if opts.DockerfilePath != """" {
+-		if _, err := listDockerfiles(opts.fs, opts.DockerfilePath); err != nil {
++		if _, err := opts.fs.Stat(opts.DockerfilePath); err != nil {
+ 			return err
+ 		}
++		if !strings.HasSuffix(opts.DockerfilePath, ""/Dockerfile"") {
++			return fmt.Errorf(""a valid Dockerfile path is required"")
++		}
+ 	}
+ 	if opts.ProjectName() == """" {
+ 		return errNoProjectInWorkspace",Should we validate the suffix before going to the filesystem?,Does this error message need to be updated?
+7001,"@@ -23,8 +23,12 @@ var (
+ 	plugin   = ""local""
+ 	// 1 week
+ 	updateInterval = time.Hour * 24 * 7
++	siteName       string
++	serviceType    string
+ )
+
++const netName = ""ddev_default""
++
+ // RootCmd represents the base command when called without any subcommands
+ var RootCmd = &cobra.Command{
+ 	Use:   ""ddev"",",It feels like we should be working to reduce/eliminate our global vars. I'm not sure it adds much here. Any objection to just removing it?,can we call this `defaultSiteName` for cons
+7002,"@@ -0,0 +1,13 @@
++class AddScheduledReports < ActiveRecord::Migration
++  def change
++    create_table :scheduled_reports do |t|
++      t.string :name, null: false
++      t.string :frequency, null: false
++      t.integer :user_id, null: false
++      t.integer :report_id, null: false
++      t.timestamps
++    end
++    add_foreign_key :scheduled_reports, :users
++    add_foreign_key :scheduled_reports, :reports
++  end
++end",did you consider using AR enums for this? would give us all the boolean methods (`weekly?` etc) for free,should the column be called `scheduled_repo
+7003,"@@ -378,6 +378,8 @@ class Engine(object):
+         :param filename: file basename to find
+         :type filename: str
+         """"""
++        if not filename:
++            return None
+         filename = os.path.expanduser(filename)
+         if os.path.exists(filename):
+             return filename","This may change """" into None. Better return filename.",Let's use: `if not filename: return None`
+7004,"@@ -126,4 +126,11 @@ type Resources struct {
+
+ 	// CpuWeight sets a proportional bandwidth limit.
+ 	CpuWeight uint64 `json:""cpu_weight""`
++
++	// SkipDevices allows to skip configuring device permissions.
++	// Used by e.g. kubelet while creating a parent cgroup (kubepods)
++	// common for many containers.
++	//
++	// NOTE it is impossible to start a container which has this flag set.
++	SkipDevices bool `json:""skip_devices""`
+ }",:+1: That does resolve my security concerns about this feature.,Is there a way to create a container with this flag set instead of using a bool?
+7005,"@@ -61,8 +61,13 @@ def get_if(iff, cmd):
+     return ifreq
+
+
++def get_if_raw_hwaddr(iff):
++    from scapy.arch import SIOCGIFHWADDR
++    return struct.unpack(""16xh6s8x"", get_if(iff, SIOCGIFHWADDR))
++
+ # SOCKET UTILS
+
++
+ def _select_nonblock(sockets, remain=None):
+     """"""This function is called during sendrecv() routine to select
+     the available sockets.",Could you add a docstring?,Why do we have to import this at the top of the file?
+7006,"@@ -92,7 +92,7 @@ func TestClientDisableIMDS(t *testing.T) {
+ 	svc := ec2metadata.New(unit.Session, &aws.Config{
+ 		LogLevel: aws.LogLevel(aws.LogDebugWithHTTPBody),
+ 	})
+-	resp, err := svc.Region()
++	resp, err := svc.GetUserData()
+ 	if err == nil {
+ 		t.Fatalf(""expect error, got none"")
+ 	}",Shouldn't this still be `Region()`?,Shouldn't we check for `err` too?
+7007,"@@ -89,6 +89,7 @@ class CompletionView(QTreeView):
+     # https://github.com/The-Compiler/qutebrowser/issues/117
+
+     resize_completion = pyqtSignal()
++    connected = None
+
+     def __init__(self, win_id, parent=None):
+         super().__init__(parent)","This shouldn't be here but `self.connected = None` in `__init__` instead, otherwise that'd be an attribute which is set this way in _every_ instance of that class (i.e. a class rather than an instance variable). I'd also say let's make it ""private"" (i.e. `_connected`) and please add a quick note about what it is to the docstring of the class.",Is this variable used anywhere?
+7008,"@@ -24,7 +24,7 @@ class ChromiumService(service.Service):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None, start_error_message=None):
++                 log_path=None, env=None, start_error_message=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ",This would be better served as a method/property that is set when people don't want to a window.,create_no_window -> no_window?
+7009,"@@ -33,7 +33,7 @@ public class PageStreamingTransformer {
+   public List<PageStreamingDescriptorView> generateDescriptors(SurfaceTransformerContext context) {
+     List<PageStreamingDescriptorView> descriptors = new ArrayList<>();
+
+-    for (Method method : context.getInterface().getMethods()) {
++    for (Method method : context.getNonStreamingMethods()) {
+       MethodConfig methodConfig = context.getMethodConfig(method);
+       if (!methodConfig.isPageStreaming()) {
+         continue;","I was dubious about putting getNonStreamingMethods in the context, but after some thought, I have decided to embrace the approach. In this particular case, the loop is supposed to be over page streaming methods. So, could you add a getPageStreamingMethods() method in the context, use it here, and remove the isPageStreaming() check below?",I think this should be context
+7010,"@@ -600,7 +600,8 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister, HavingInstall
+         self.__add_result_listeners(jmx)
+         if not is_jmx_generated:
+             self.__force_tran_parent_sample(jmx)
+-            if self.settings.get('version', self.JMETER_VER) >= '3.2':
++            version = str(self.settings.get('version', self.JMETER_VER)).split(""."")
++            if tuple(version) >= ('3', '2'):
+                 self.__force_hc4_cookie_handler(jmx)
+         self.__fill_empty_delimiters(jmx)
+ ",LooseVersion class can help here,"Using `tuple` instead of `(3, "
+7011,"@@ -220,7 +220,9 @@ void HDF5Common::AddVar(IO &io, std::string const &name, hid_t datasetId)
+                 shape[i] = dims[i];
+         }
+
+-        auto &foo = io.DefineVariable<T>(name, shape);
++        Dims zeros(shape.size(), 0);
++
++        auto &foo = io.DefineVariable<T>(name, shape, zeros, shape);
+         // default was set to 0 while m_AvailabelStepsStart is 1.
+         // correcting
+         if (0 == foo.m_AvailableStepsCount)","`const Dims zeros(shape.size(), 0);`",What is the purpose of this ch
+7012,"@@ -135,8 +135,8 @@ module RSpec::Core
+           options[:color] = o
+         end
+
+-        parser.on('-p', '--profile', 'Enable profiling of examples and list 10 slowest examples.') do |o|
+-          options[:profile_examples] = o
++        parser.on('-p', '--profile [COUNT]', 'Enable profiling of examples and list 10 slowest examples.') do |count|
++          options[:profile_examples] = count.nil? ? true : count.to_i
+         end
+
+         parser.separator <<-FILTERING",Would be good for this not to say `10` anymore...,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+7013,"@@ -174,7 +174,7 @@ class AdSenseDashboardWidget extends Component {
+ 								</div>
+ 							}
+ 							{ ! receivingData && (
+-								error ? getDataErrorComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), true, true, true )
++								error ? getDataErrorComponent( 'adsense', _x( 'AdSense', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), true, true, true )
+ 							) }
+ 							<div className={ classnames(
+ 								'mdc-layout-grid__cell',","See above, we don't need to pass the module name here.",Are you sure you don't want to show the `error` component if `errorObj` is `null`? Or do you want t
+7014,"@@ -4,8 +4,10 @@ declare(strict_types=1);
+
+ namespace Shopsys\FrontendApiBundle\Controller;
+
++use BadMethodCallException;
+ use Overblog\GraphQLBundle\Controller\GraphController;
+ use Shopsys\FrontendApiBundle\Component\Domain\EnabledOnDomainChecker;
++use Shopsys\FrontendApiBundle\Model\GraphqlConfigurator;
+ use Symfony\Component\HttpFoundation\JsonResponse;
+ use Symfony\Component\HttpFoundation\Request;
+ use Symfony\Component\HttpFoundation\Response;","This is random line :-) overridden String type by custom trimmed - please change that commit message to something like ""introduced custom String type with automatic trimming""",Do we really need to keep `use` statements in the controller? Can we remove them and keep only the
+7015,"@@ -104,6 +104,19 @@ module.exports = function(realmConstructor) {
+
+         setConstructorOnPrototype(realmConstructor.Sync.User);
+         setConstructorOnPrototype(realmConstructor.Sync.Session);
++
++        if (realmConstructor.Sync._setFeatureToken) {
++            realmConstructor.Sync.setFeatureToken = function(featureToken) {
++                if (typeof featureToken !== 'string' || !featureToken instanceof String) {
++                    throw new Error(""featureToken should be a string"");
++                }
++
++                realmConstructor.Sync._setFeatureToken(featureToken.trim());
++            }
++
++            //enable depreciated setAccessToken
++            realmConstructor.Sync.setAccessToken = realmConstructor.Sync.setFeatureToken;
++        }
+     }
+
+     // TODO: Remove this now useless object.","My personal taste: ""depreciated"" -> ""deprecated""",I think this should be doing `typeof featureToken === 'string'`
+7016,"@@ -58,6 +58,8 @@ var (
+ 		""destinationPodName"",
+ 		""destinationPodNamespace"",
+ 		""destinationNodeName"",
++		""destinationClusterIP"",
++		""destinationServiceName"",
+ 	}
+ )
+ ",this includes the port as well right? should the name be `destinationServicePortName`?,"Not sure why we are adding this here, is there some reason we are not removing it?"
+7017,"@@ -23,13 +23,15 @@ import os
+ import json
+ import logging
+ import socket
+-import time
+ import base64
+
+ from urllib.parse import urljoin, urlencode, urlparse
+ from urllib.request import urlopen, Request
+ from urllib.error import URLError
+
++from tenacity import retry
++from tenacity import wait_fixed
++from tenacity import stop_after_attempt
+ from luigi import configuration
+ from luigi.scheduler import RPC_METHODS
+ ",We can import all of them in one line.,"I would prefer we don't have to import `tenacity` here, `retry` is very specific t"
+7018,"@@ -1656,7 +1656,7 @@ interface StreamModule {
+
+         @Override
+         public Stream<T> appendAll(Iterable<? extends T> elements) {
+-            Objects.requireNonNull(queue, ""elements is null"");
++            Objects.requireNonNull(elements, ""elements is null"");
+             return isEmpty() ? Stream.ofAll(queue) : new AppendElements<>(head, queue.appendAll(elements), tail);
+         }
+ ","this was wrong, the rest were just inconsistent :)",This was not part of your PR and should not be included in this PR.
+7019,"@@ -23,7 +23,7 @@
+     </div>
+   </div>
+
+-  <div class=""row past-pr"">
++  <div id=""proposals-completed"" class=""row past-pr"">
+     <div class=""col-md-12"">
+       <h3>Recently Completed Purchase Requests</h3>
+     <%- if @approved_data.rows.any? %>",I gave them the EXACT SAME NAMES in my branch :),"Do we need this? I was thinking we just added a `<div class=""row past-pr"">` inside"
+7020,"@@ -96,6 +96,16 @@ func (*RunCLI) Run(args []string) int {
+ 		return 1
+ 	}
+
++	// Create uds dir and parents if not exists
++	dir := filepath.Dir(c.BindAddress.String())
++	if _, statErr := os.Stat(dir); os.IsNotExist(statErr) {
++		c.Log.WithField(""dir"", dir).Infof(""Creating spire agent UDS directory"")
++		if err := os.MkdirAll(dir, 0755); err != nil {
++			fmt.Fprintln(os.Stderr, err)
++			return 1
++		}
++	}
++
+ 	// Set umask before starting up the agent
+ 	cli.SetUmask(c.Log)
+ ",What would you think stat'ing the directory first before doing the log+mkdirall and only proceeding if the directory does not exist? The logging might be less confusing (I'd be wondering why it was logging that it was creating the directory when I knew it already existed).,You should use `0700` instead of `0700`
+7021,"@@ -339,7 +339,7 @@ namespace Datadog.Trace.Agent
+             }
+
+             // Add the current keep rate to the root span
+-            var rootSpan = trace.Array[trace.Offset].Context.TraceContext?.RootSpan;
++            var rootSpan = trace.Array[trace.Offset].InternalContext.TraceContext?.RootSpan;
+             if (rootSpan is not null)
+             {
+                 var currentKeepRate = _traceKeepRateCalculator.GetKeepRate();","Sorry about the confusion, I'm trying to address that in the PR follow-up. If we ever have `Span` objects, then accessing their properties is going to be safe. The only question remaining is ""What is the runtime type for Scope.Span?"" and we just have to account for it when it is `Datadog.Trace.Span` and when it is not",Is there a test we can write for this?
+7022,"@@ -9,6 +9,12 @@ import static com.github.javaparser.JavaParser.*;
+ import static com.github.javaparser.utils.Utils.EOL;
+ import static org.junit.Assert.*;
+
++import java.io.FileOutputStream;
++import java.io.IOException;
++import java.io.OutputStreamWriter;
++import java.io.Writer;
++import java.io.BufferedWriter;
++
+ public class JsonPrinterTest {
+     @Test
+     public void testWithType() {",I was using this imports for writing the results to file to more easily check that it was valid JSON. You can probably remove these `java.io` imports.,Could you please move `import java.io.B
+7023,"@@ -21,6 +21,11 @@ type pid struct {
+ 	Pid int `json:""Pid""`
+ }
+
++type logentry struct {
++	Msg   string
++	Level string
++}
++
+ func TestNsenterValidPaths(t *testing.T) {
+ 	args := []string{""nsenter-exec""}
+ 	parent, child, err := newPipe()",You should probably include a `json:...` annotation here.,Should we move this to its own package?
+7024,"@@ -38,6 +38,7 @@ import (
+
+ const (
+ 	ecsMaxReasonLength    = 255
++	ecsMaxRuntimeIDLength = 255
+ 	pollEndpointCacheSize = 1
+ 	pollEndpointCacheTTL  = 20 * time.Minute
+ 	roundtripTimeout      = 5 * time.Second",can container ID > 255 chars? why are we doing this check?,Nit: I would rename this to `maxReasonLength` as it's no longer a length.
+7025,"@@ -111,6 +111,7 @@ return [
+     'prohibited'           => 'This field is prohibited.',
+     'prohibited_if'        => 'This field is prohibited when :other is :value.',
+     'prohibited_unless'    => 'This field is prohibited unless :other is in :values.',
++    'prohibits'            => 'This field field prohibits :other from being present.',
+     'same'                 => 'The value of this field must match the one from :other.',
+     'size'                 => [
+         'numeric' => 'The value must be :size.',","*""This **field field** prohibits :other from being present.""*, **field** word repeated is right?",Typo: missing `prohibited unless`
+7026,"@@ -36,6 +36,7 @@ import (
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/flowexporter/flowrecords""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/interfacestore""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/metrics""
++	npl ""github.com/vmware-tanzu/antrea/pkg/agent/npl""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/openflow""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/proxy""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/querier""",nit: no need to add an alias for this case.,Why was this added?
+7027,"@@ -4,15 +4,16 @@ import (
+ 	""fmt""
+ 	""io""
+ 	""os""
++	""strconv""
+ 	""sync""
+ )
+
+-var out io.Writer = os.Stdout
+-
+ // LogLevel of quic-go
+ type LogLevel uint8
+
+ const (
++	logEnv = ""QUIC_GO_LOG_LEVEL""
++
+ 	// LogLevelDebug enables debug logs (e.g. packet contents)
+ 	LogLevelDebug LogLevel = iota
+ 	// LogLevelInfo enables info logs (e.g. packets)",Or `QUIC_LOG_LEVEL`. Which one do you prefer?,We should probably use here `strconv.Itoa`
+7028,"@@ -117,7 +117,14 @@ func GetDiskInfos(virtualHardware *ovf.VirtualHardwareSection, diskSection *ovf.
+ 				return diskInfos, err
+ 			}
+
+-			byteCapacity, err := Parse(int64(capacityRaw), *virtualDiscDesc.CapacityAllocationUnits)
++			var allocationUnits string
++			if virtualDiscDesc.CapacityAllocationUnits == nil ||
++				*virtualDiscDesc.CapacityAllocationUnits == """" {
++				allocationUnits = ""byte""
++			} else {
++				allocationUnits = *virtualDiscDesc.CapacityAllocationUnits
++			}
++			byteCapacity, err := Parse(int64(capacityRaw), allocationUnits)
+ 			if err != nil {
+ 				return diskInfos, err
+ 			}","Minor: you can set it to byte here and only set it to *virtualDiscDesc.CapacityAllocationUnits if that's not nil/"""". Saves two lines","`== nil` and `== """"` should be equivalent, but no need to check both."
+7029,"@@ -70,6 +70,18 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
+                           headers=self.headers,
+                           status=400)
+
++    def test_buckets_can_handle_arbitrary_attributes(self):
++        bucket = MINIMALIST_BUCKET.copy()
++        fingerprint = ""5866f245a00bb3a39100d31b2f14d453""
++        bucket['data'] = {'fingerprint': fingerprint}
++        resp = self.app.put_json('/buckets/beers',
++                                 bucket,
++                                 headers=self.headers,
++                                 status=200)
++        data = resp.json['data']
++        self.assertIn('fingerprint', data)
++        self.assertEqual(data['fingerprint'], fingerprint)
++
+
+ class BucketCreationTest(BaseWebTest, unittest.TestCase):
+     def test_buckets_can_be_created_with_post(self):","While reading this I found that it makes actually little sense for ""beers"" to have a ""fingerprint"". We might want to do another pass on the examples here to use something that actually makes more sense to the reader. This could be done in another issue.","Can you do a self.assertEqual(data['fingerprint'], fingerprint) to en"
+7030,"@@ -365,7 +365,7 @@ public abstract class AbstractMultimapTest extends AbstractTraversableTest {
+     @Test
+     public void shouldConvertToMap() {
+         Multimap<Integer, Integer> mm = emptyIntInt().put(1, 2).put(1, 3);
+-        assertThat(mm.asMap().get(1).get().mkString("","")).isEqualTo(""2,3"");
++        assertThat(mm.asMap().get(1).get()).isEqualTo(HashSet.of(2, 3));
+     }
+
+     // -- biMap","Thank you! That's better, especially the conversion test should not test the mkString method :)",Why did you change this test?
+7031,"@@ -70,9 +70,10 @@ class ScintillaTextInfo(textInfos.offsets.OffsetsTextInfo):
+ 		return watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POSITIONFROMPOINT,x,y)
+
+ 	def _getPointFromOffset(self,offset):
++		location = self.obj.location
+ 		point=textInfos.Point(
+-		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTXFROMPOSITION,None,offset),
+-		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTYFROMPOSITION,None,offset)
++			location.left + watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTXFROMPOSITION,None,offset),
++			location.top + watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTYFROMPOSITION,None,offset)
+ 		)
+ 		if point.x is not None and point.y is not None:
+ 			return point","You're basically converting client to screen coordinates here, doing it manually. Is there a specific reason why you aren't using clientToScreen here? Does it fail?","I'm confused, why is this needed?"
+7032,"@@ -340,6 +340,10 @@ func Copy(ctx context.Context, f fs.Fs, dst fs.Object, remote string, src fs.Obj
+ 		}
+ 		// If can't server side copy, do it manually
+ 		if err == fs.ErrorCantCopy {
++			if fs.Config.MaxTransfer >= 0 && (accounting.Stats(ctx).GetBytes() >= int64(fs.Config.MaxTransfer) ||
++				(fs.Config.MaxTransferMode == fs.MaxTransferModeCautious && accounting.Stats(ctx).GetBytesWithPending()+src.Size() >= int64(fs.Config.MaxTransfer))) {
++				return nil, accounting.ErrorMaxTransferLimitReached
++			}
+ 			if doMultiThreadCopy(f, src) {
+ 				// Number of streams proportional to size
+ 				streams := src.Size() / int64(fs.Config.MultiThreadCutoff)","This needs to be done for server-side copies too, earlier in the function.",Didn't we decide to return `ErrorMaxTransferLimitReached` in all cases when `maxTransfer == 0`?
+7033,"@@ -26,7 +26,13 @@ import (
+ 	""github.com/lyft/clutch/backend/service""
+ )
+
+-var scopes = []string{oidc.ScopeOpenID, ""email""} // TODO(maybe): make scopes part of config?
++// TODO(maybe): make scopes part of config?
++// For more documentation on scopes see: https://developer.okta.com/docs/reference/api/oidc/#scopes
++var scopes = []string{
++	oidc.ScopeOpenID,
++	oidc.ScopeOfflineAccess, // offline_access is used to request issuance of a refresh_token
++	""email"",
++}
+
+ const Name = ""clutch.service.authn""
+ ",Do we want to add in `profile` here as well so we request access to the end user's default profile claims like name?,The refresh_token value is provided by the controller so it should be possible to configure the
+7034,"@@ -0,0 +1,10 @@
++module ProposalSpecHelper
++  def fully_approve(proposal)
++    proposal.individual_approvals.each do |approval|
++      approval.reload
++      approval.approve!
++    end
++    expect(proposal.reload).to be_approved # sanity check
++    deliveries.clear
++  end
++end",I am not sure what the difference between approving and full approving is...,Style/EmptyMethod: Put empty method definitions on a single line.
+7035,"@@ -17,7 +17,7 @@ package main
+ import (
+ 	""time""
+
+-	""github.com/docopt/docopt-go""
++	docopt ""github.com/docopt/docopt-go""
+ 	log ""github.com/sirupsen/logrus""
+
+ 	""github.com/projectcalico/felix/iptables""",Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated,I don't think we need this import anymore?
+7036,"@@ -127,7 +127,7 @@ public class TestSubQueryTransformer extends SolrTestCaseJ4 {
+      //System.out.println(""p ""+peopleMultiplier+"" d ""+deptMultiplier);
+     assertQ(""subq1.fl is limited to single field"",
+         req(""q"",""name_s:(john nancy)"", ""indent"",""true"",
+-            ""fl"",""name_s_dv,depts:[subquery]"",
++            ""fl"",""dept_ss_dv,name_s_dv,depts:[subquery]"",
+             ""rows"","""" + (2 * peopleMultiplier),
+             ""depts.q"",""{!term f=dept_id_s v=$row.dept_ss_dv}"",
+             ""depts.fl"",""text_t"",",Many tests in this class seem to have just been fortunate that `SolrIndexSearcher` ignored `fl` and retrieved all fields when not using lazy loading.,`dept_ss_dv` is now added twice.
+7037,"@@ -14,7 +14,9 @@
+ # You should have received a copy of the GNU General Public License
+ # along with Scapy. If not, see <http://www.gnu.org/licenses/>.
+
+-# scapy.contrib.description = GENEVE
++# flake8: noqa: E501
++
++# scapy.contrib.description = Generic Network Virtualization Encapsulation (GENEVE)
+ # scapy.contrib.status = loads
+
+ """"""",Is this really needed?,How about: `# scapy.contrib.desc
+7038,"@@ -39,8 +39,12 @@ module RSpec
+
+         example_group_aliases << name
+
+-        (class << RSpec; self; end).__send__(:define_method, name) do |*args, &example_group_block|
+-          RSpec.world.register RSpec::Core::ExampleGroup.__send__(name, *args, &example_group_block)
++        (class << RSpec; self; end).instance_exec do
++          remove_method(name) if method_defined?(name)
++
++          define_method(name) do |*args, &example_group_block|
++            RSpec.world.register RSpec::Core::ExampleGroup.__send__(name, *args, &example_group_block)
++          end
+         end
+
+         expose_example_group_alias_globally(name) if exposed_globally?",Is this necessary with line 38?,is this necessary? I thought `in
+7039,"@@ -148,7 +148,7 @@ if ""CI_EXTRA_COMPILE_ARGS"" in os.environ:
+ # https://stackoverflow.com/questions/29870629/pip-install-test-dependencies-for-tox-from-setup-py
+ test_deps = [
+     ""pandas"",
+-    ""pytest>=3.0"",
++    ""pytest>=3.1"",
+     ""pytest-cov"",
+     ""pytest-benchmark>=3.1"",
+ ]",DO we want to have >= here? Or ==,Because the tox package requires
+7040,"@@ -10,7 +10,7 @@ namespace Datadog.Trace
+         /// <summary>
+         /// The environment of the profiled service.
+         /// </summary>
+-        public const string Env = ""env"";
++        public const string Env = CoreTags.Env;
+
+         /// <summary>
+         /// The version of the profiled service.","Can you also add this `""version""` tag to the CoreTags? Now that we're targeting the service/env/version trio","This is a breaking change, can we keep the old constant name as ""env""?"
+7041,"@@ -29,6 +29,14 @@ class SkuTest extends TestCase
+         $this->assertEquals($sku, $sku->getValue());
+     }
+
++    /**
++     * @expectedException \InvalidArgumentException
++     */
++    public function testInvalidVAlue(): void
++    {
++        $sku = new Sku('yKL3rWXluEM7NapnMSVpYHpicQJkpJ0Obfx91mma0xwnQxUfsrwy5Nfki1LUZR4qYolBTlUFDO4RkeINIkjPzMfTSit0bQZJevXA6GMsj0LnSZaiT1bBfr00vtKWqLAPollonRzb6GBVlT5U9I6nC49r3Vnj2jUgpA73CvfnVnFBNnHqCaI2Cu48SKaVSRGgROhoD1dGPvvq98okavZ3ktVHk0TcyyiyfoH52U3gP3J5bNTVZngivjPJAqtOW8TO');
++    }
++
+     /**
+      * @return array
+      */",This entry will be incompatible with the currently implemented formatting rules. Maximum 120 characters per line.,this needs to be changed to \UnexpectedValueException
+7042,"@@ -234,7 +234,11 @@ module Beaker
+         output_callback = nil
+       else
+         @logger.debug ""\n#{log_prefix} #{Time.new.strftime('%H:%M:%S')}$ #{cmdline}""
+-        output_callback = logger.method(:host_output)
++        if @options[:preserve_host_output]
++          output_callback = logger.method(:preserve_host_output)
++        else
++          output_callback = logger.method(:host_output)
++        end
+       end
+
+       unless $dry_run",Let's call this color_host_output or some such - preserve_host_output makes it sound like you won't get any output without this being set.,I think this method name should be `logger.method_missing` or `logger.
+7043,"@@ -6,7 +6,7 @@ var attr,
+ 	attrName,
+ 	allowed,
+ 	role = node.getAttribute('role'),
+-	attrs = node.attributes;
++	attrs = axe.utils.getNodeAttributes(node);
+
+ if (!role) {
+ 	role = axe.commons.aria.implicitRole(node);","suggestion: if we perhaps make `attributes` a getter in `virtualNode`, it does look seamless to access the property, same as what we have done for `isFocusable` or `tabbableElements`. `node.attributes` can become `virtualNode.attributes`",A lot of thoughts on this: - Is `getNodeAttributes` needed at all? - I
+7044,"@@ -55,6 +55,7 @@ public class FeedMedia extends FeedFile implements Playable {
+     private Date playbackCompletionDate;
+     private int startPosition = -1;
+     private int playedDurationWhenStarted;
++    private String lastPlaybackSpeed = null;
+
+     // if null: unknown, will be checked
+     private Boolean hasEmbeddedPicture;",I think a float value fits better.,"The name ""lastPlaybackSpeed"" isn't very descriptive. How about ""playingSpeedLastTime""?"
+7045,"@@ -90,6 +90,11 @@ func (s *server) setupRouting() {
+ 		),
+ 	})
+
++	handle(router, ""/pss/{topic}/ws"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.pssPostHandler),
++		//""POST"": http.HandlerFunc(s.pssPostHandler), // WS does not use verbs
++	})
++
+ 	handle(router, ""/tags"", web.ChainHandlers(
+ 		s.gatewayModeForbidEndpointHandler,
+ 		web.FinalHandler(jsonhttp.MethodHandler{","This should be (POST,DELETE) `/pss/subscribe/{topic}` for subscriptions and there should be `/pss/send/{topic}` for sending.",Can we move this to `/ws`?
+7046,"@@ -13,6 +13,9 @@ export function createContext(defaultValue) {
+ 		_id: '__cC' + i++,
+ 		_defaultValue: defaultValue,
+ 		Consumer(props, context) {
++			this.shouldComponentUpdate = function (_props, _state, _context) {
++				return _context !== context;
++			};
+ 			return props.children(context);
+ 		},
+ 		Provider(props) {",Closing over the closure arguments is a neat trick :+1: Love it :100:,why do we need this? shouldn't it always be true?
+7047,"@@ -156,11 +156,12 @@ public class TestEvaluatior {
+   @Test
+   public void testCaseSensitiveNot() {
+     TestHelpers.assertThrows(
+-      ""X != x when case sensitivity is on"",
+-      ValidationException.class,
+-      ""Cannot find field 'X' in struct"",
+-      () -> { new Evaluator(STRUCT, not(equal(""X"", 7)), true); }
+-      );
++        ""X != x when case sensitivity is on"",
++        ValidationException.class,
++        ""Cannot find field 'X' in struct"",
++        () -> {
++          new Evaluator(STRUCT, not(equal(""X"", 7)), true);
++        });
+   }
+
+   @Test",Does this need to be a block or can it be an expression?,"Please undo formatting changes. Sorry, I didn't see this before."
+7048,"@@ -148,7 +148,7 @@ public abstract class LoginAbstractAzkabanServlet extends
+     buf.append(""\"""");
+     buf.append(req.getMethod()).append("" "");
+     buf.append(req.getRequestURI()).append("" "");
+-    if (req.getQueryString() != null) {
++    if (req.getQueryString() != null && allowedPostRequest(req)) {
+       buf.append(req.getQueryString()).append("" "");
+     } else {
+       buf.append(""-"").append("" "");",req.getQueryString() != null is not necessary since same check is already done in allowedPostRequest,Could you please explain why this change is needed?
+7049,"@@ -128,6 +128,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+   @Nullable
+   public abstract String grpcTransportImportName();
+
++  public abstract boolean isRestOnlyTransport();
++
+   @Override
+   public String resourceRoot() {
+     return SnippetSetRunner.SNIPPET_RESOURCE_ROOT;","As per go/actools-regapic-design, in the final product, generated GAPICs must be able to support multiple transports if supported by the API. For Java, we'll support this in the microgenerator; the monolith generates single-transport GAPICs. For PHP, the situation is likely similar, though on a longer timescale. All this to say that I would appreciate structuring the code in terms of ""supports REST"" rather than ""REST only"", but only where this doesn't require undue work. For everything else, please add a TODO to the effect of ""we're generating single-transport GAPICs for now, though in the fullness of time we'll generate multi-transport GAPICs.""",nit: should we call this `isRestOnlyTransport()` in
+7050,"@@ -13,5 +13,5 @@ return [
+     */
+
+     'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈز میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing again,Why was this line removed?
+7051,"@@ -5,14 +5,14 @@ module DelayedJobsHelpers
+     end
+   end
+
+-  def stub_mail_method(method_name)
++  def stub_mail_method(klass, method_name)
+     stub('mail', deliver: true).tap do |mail|
+-      Mailer.stubs(method_name => mail)
++      klass.stubs(method_name => mail)
+     end
+   end
+
+-  def stub_mail_method_to_raise(method_name, error)
+-    Mailer.stubs(method_name).raises(error)
++  def stub_mail_method_to_raise(klass, method_name, error)
++    klass.stubs(method_name).raises(error)
+   end
+ end
+ ",Changed this helper to also get class name.,Why is this stubbing a different method?
+7052,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher,Shouldn't this be `applicationName` to be consistent with `applicationType` and `applicationVersion`?
+7053,"@@ -15,6 +15,9 @@
+ #include <valgrind/helgrind.h>
+ #endif
+
++// default actor batch size
++#define PONY_ACTOR_DEFAULT_BATCH 100
++
+ // Ignore padding at the end of the type.
+ pony_static_assert((offsetof(pony_actor_t, gc) + sizeof(gc_t)) ==
+    sizeof(pony_actor_pad_t), ""Wrong actor pad size!"");",Why the rename from PONY_SCHED_BATCH ? ACTOR_DEFAULT_BATCH is less meaningful to me than SCHED_BATCH.,This should be moved to core.h instead.
+7054,"@@ -35,6 +35,10 @@ var log = logging.Logger(""/fil/storage"")
+ const makeDealProtocol = protocol.ID(""/fil/storage/mk/1.0.0"")
+ const queryDealProtocol = protocol.ID(""/fil/storage/qry/1.0.0"")
+
++// TODO: replace this with a queries to pick reasonable gas price and limits.
++const submitPostGasPrice = 0
++const submitPostGasLimit = 100000000000
++
+ // Miner represents a storage miner.
+ type Miner struct {
+ 	minerAddr      address.Address","Let's be sure we have an issue that tracks this, filed against testnet.","What's the benefit of adding a new constant here? Seems like we could use the same constant for both,"
+7055,"@@ -9,6 +9,9 @@ function SIN(type, payload) {
+     SIN.super_.call(this, type, payload);
+     return;
+   }
++  if ( !Buffer.isBuffer(payload) ||  payload.length != 20)
++    throw new Error('Payload must be 20 bytes');
++
+   this.data = new Buffer(1 + 1 + payload.length);
+   this.converters = this.encodings['binary'].converters;
+   this._encoding = this.encodings['binary']._encoding;",There should be no space before !Buffer,shouldn't this be a `RuntimeError` instead of an `Error`?
+7056,"@@ -57,4 +57,6 @@ storiesOf( 'Global', module )
+ 				/>
+ 			</p>
+ 		</div>;
++	}, {
++		padding: 0,
+ 	} );","Same here, we need the default padding for this story.",Is there a reason for adding this?
+7057,"@@ -348,8 +348,12 @@ class InfluxListenStore(ListenStore):
+             int: the number of bytes this user's listens take in the dump file
+         """"""
+         self.log.info('Dumping user %s...', username)
++
++        t0 = time.time()
+         offset = 0
+         bytes_written = 0
++        listen_count = 0
++
+         # Get this user's listens in chunks
+         while True:
+             # loop until we get this chunk of listens","I think this should go away, its noise in the grand scheme of things.",Any reason not to use this `Timer`
+7058,"@@ -1273,6 +1273,17 @@ func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err e
+ 			}
+ 		}
+
++		// Create/Remove git-daemon-export-ok for git-daemon...
++		daemonExportFile := path.Join(repo.RepoPath(), `git-daemon-export-ok`)
++		if repo.IsPrivate {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			os.Remove(daemonExportFile)
++		} else {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			f, _ := os.Create(daemonExportFile)
++			f.Close()
++		}
++
+ 		forkRepos, err := getRepositoriesByForkID(e, repo.ID)
+ 		if err != nil {
+ 			return fmt.Errorf(""getRepositoriesByForkID: %v"", err)",Maybe just call `ioutil.WriteFile` with 0 bytes? And Make an error log `log.Error` if any error occurs.,I think we should check the error
+7059,"@@ -490,6 +490,18 @@ class Builder {
+     return this;
+   }
+
++  /**
++   * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
++   * child process when creating IE sessions locally.
++   *
++   * @param {ie.ServiceBuilder} service the service to use.
++   * @return {!Builder} a self reference.
++   */
++  setIeService(service) {
++    this.ieService_ = service;
++    return this;
++  }
++
+   /**
+    * Set {@linkplain edge.Options options} specific to Microsoft's Edge browser
+    * for drivers created by this builder. Any proxy settings defined on the",`this.ieService_` should be initialized to null in the constructor.,Nit: I think camelCase would be mo
+7060,"@@ -313,11 +313,17 @@ func (r *DefaultRuleRenderer) filterOutputChain() *Chain {
+ 	// That decision is based on pragmatism; it's generally very useful to be able to contact
+ 	// any local workload from the host and policing the traffic doesn't really protect
+ 	// against host compromise.  If a host is compromised, then the rules could be removed!
++	// However, we do apply policy to workload ingress traffic if it belongs to an IPVS connection.
+ 	for _, prefix := range r.WorkloadIfacePrefixes {
+-		// If the packet is going to a worklaod endpoint, RETURN.
++		// If the packet is going to a workload endpoint, apply workload ingress policy if traffic
++		// belongs to an IPVS connection and return at the end.
+ 		log.WithField(""ifacePrefix"", prefix).Debug(""Adding workload match rules"")
+ 		ifaceMatch := prefix + ""+""
+ 		rules = append(rules,
++			Rule{
++				Match:  Match().OutInterface(ifaceMatch).IPVSConnection(),
++				Action: JumpAction{Target: ChainToWorkloadDispatch},
++			},
+ 			Rule{
+ 				Match:  Match().OutInterface(ifaceMatch),
+ 				Action: ReturnAction{},","I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?",Do we need this rule? I don't think it is relevant for this change.
+7061,"@@ -35,7 +35,7 @@ public class PojoProducers implements BeanPostProcessor {
+     pojoMgr.register(pojoProducer.getSchemaId(), pojoProducer);
+   }
+
+-  public Collection<PojoProducerMeta> getProcucers() {
++  public Collection<PojoProducerMeta> getProducers() {
+     return pojoMgr.values();
+   }
+ ","This is public method , we need to deprecated this method first and add new updated method for it.",@Pearl1594 I think this method should be renamed `getProducers`
+7062,"@@ -199,7 +199,10 @@ func generateNetworkTemplate(templateFilename string, wallets, relays, nodeHosts
+ 		newNode.NodeNameMatchRegex = """"
+ 		newNode.FractionApply = 0.0
+ 		newNode.Name = name
+-		newNode.IsRelay = true
++		if newNode.NetAddress == """" {
++			// if not set by relayTemplate ensure that it is a relay
++			newNode.NetAddress = ""0.0.0.0:4160""
++		}
+ 		newNode.Wallets = nil
+ 		host.Nodes = append(host.Nodes, newNode)
+ 		network.Hosts = append(network.Hosts, host)","I think that you don't want to have these workarounds; you want to make sure that the relayTemplates is configured correctly. If not, we need to fix it there.",Why is this not set by relayTemplate?
+7063,"@@ -306,7 +306,8 @@ public class ProtocolScheduleBuilder {
+             config.getEvmStackSize(),
+             isRevertReasonEnabled,
+             config.getEcip1017EraRounds(),
+-            quorumCompatibilityMode));
++            quorumCompatibilityMode,
++            config.getThanosBlockNumber()));
+
+     LOG.info(""Protocol schedule created with milestones: {}"", protocolSchedule.listMilestones());
+     return protocolSchedule;",This field is not needed.,We also need to include block number in the log message below
+7064,"@@ -6,7 +6,10 @@ class Subscriber::CancellationsController < ApplicationController
+   end
+
+   def create
+-    @cancellation = Cancellation.new(subscription: current_user.subscription)
++    @cancellation = Cancellation.new(
++      subscription: current_user.subscription,
++      reason: cancellation_params[:reason],
++    )
+
+     if @cancellation.schedule
+       redirect_to(",Put a comma after the last parameter of a multiline method call.,Align the parameters of a method call if they span more than one line.
+7065,"@@ -9,6 +9,7 @@ package e2etest
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/iotexproject/iotex-address/address""
+ 	""math/big""
+ 	""math/rand""
+ 	""testing""",move to line 18 below,This import should go at the top of the file.
+7066,"@@ -1,11 +1,16 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to upload an encrypted object to an
++# Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.ruby.s3_add_csaes_encrypt_item]
++
+ require 'aws-sdk-s3'
+ require 'openssl'
+
+-# Uploads an encrypted object to an Amazon S3 bucket.
+-#
++
+ # Prerequisites:
+ #
+ # - An Amazon S3 bucket.",Simple Storage **Service**,Trailing whitespace detected.
+7067,"@@ -81,6 +81,19 @@ root
+ "")
+     end
+
++    it ""can output indented messages"" do
++      root = RSpec.describe(""root"")
++      root.example(""example"") {|example| example.reporter.message(""message"")}
++
++      root.run(reporter)
++
++      expect(formatter_output.string).to eql(""
++root
++  message
++  example
++"")
++    end
++
+     it ""strips whitespace for each row"" do
+       group = RSpec.describe("" root "")
+       context1 = group.describe("" nested "")","Thats odd, I'd actually not expect this output at all...",here we make sure the output is eql the same as `root.message`
+7068,"@@ -53,7 +53,7 @@ module Travis
+         go_version_aliases: ENV.fetch(
+           'TRAVIS_BUILD_GO_VERSION_ALIASES', (
+             {
+-              '1' => '1.7.4',
++              '1' => '1.8',
+               '1.0' => '1.0.3',
+               '1.0.x' => '1.0.3',
+               '1.1.x' => '1.1.2',","As a side note, I get why this is up here (sort order), but it'd be easier to not forget to update it if it were down next to `1.x` -- would it be acceptable to make that change the next time I make this sort of PR? :smile: :innocent: (don't want to hold this one up since folks are blocked on getting this one in, it's a pretty superficial change, and I probably won't have cycles again for a few days to update the PR with the change :sweat_smile:)",This should be 1.8.0
+7069,"@@ -92,14 +92,14 @@ public class AccountPermissioningControllerFactoryTest {
+   }
+
+   @Test
+-  public void createOnchainConfigWithAccountPermissioningDisabledShouldReturnEmpty() {
+-    SmartContractPermissioningConfiguration onchainConfig =
++  public void createFlexibleConfigWithAccountPermissioningDisabledShouldReturnEmpty() {
++    SmartContractPermissioningConfiguration flexibleConfig =
+         SmartContractPermissioningConfiguration.createDefault();
+-    assertThat(onchainConfig.isSmartContractAccountAllowlistEnabled()).isFalse();
++    assertThat(flexibleConfig.isSmartContractAccountAllowlistEnabled()).isFalse();
+
+     PermissioningConfiguration permissioningConfiguration =
+         new PermissioningConfiguration(
+-            Optional.empty(), Optional.of(onchainConfig), Optional.empty());
++            Optional.empty(), Optional.of(flexibleConfig), Optional.empty());
+
+     Optional<AccountPermissioningController> controller =
+         AccountPermissioningControllerFactory.create(","this class is permissioning so let's keep ""Onchain"" here",@josegar74 the namin
+7070,"@@ -4,7 +4,7 @@ using System.Resources;
+ using System.Runtime.CompilerServices;
+ using System.Runtime.InteropServices;
+
+-// General Information about an assembly is controlled through the following
++// General Information about an assembly is controlled through the following
+ // set of attributes. Change these attribute values to modify the information
+ // associated with an assembly.
+ [assembly: AssemblyTitle(""AutoRest"")]","we can be more specific to call out the it is ""AutoRest C# code generator""?",Revert this file?
+7071,"@@ -124,3 +124,5 @@ class VirtualNode extends axe.AbstractVirtualNode {
+ 		return this._cache.boundingClientRect;
+ 	}
+ }
++
++axe.VirtualNode = VirtualNode;",Ditto for not adding this to the axe namespace.,Why is this needed?
+7072,"@@ -0,0 +1 @@
++package registration",Should we just remove this file? Having it present but empty feels misleading,Rename this file to match the other files.
+7073,"@@ -69,6 +69,14 @@ func (tracker *PeerTracker) UpdateTrusted(ctx context.Context) error {
+ 	return tracker.updatePeers(ctx, tracker.trustedPeers()...)
+ }
+
++// Trust adds `pid` to the peer trackers trusted node set.
++func (tracker *PeerTracker) Trust(pid peer.ID) {
++	tracker.mu.Lock()
++	defer tracker.mu.Unlock()
++	tracker.trusted[pid] = struct{}{}
++	logPeerTracker.Infof(""Trusting peer=%s"", pid.Pretty())
++}
++
+ // Track adds information about a given peer.ID
+ func (tracker *PeerTracker) Track(ci *types.ChainInfo) {
+ 	tracker.mu.Lock()",Would it make sense to include an `Untrust` as well? If I were playing around with this on the CLI I wouldn't want to make a change I couldn't undo.,Can we call this something other than `Tru
+7074,"@@ -43,6 +43,13 @@ use VuFindSearch\Backend\Solr\Response\Json\RecordCollectionFactory;
+  */
+ class SolrDefaultBackendFactory extends AbstractSolrBackendFactory
+ {
++    /**
++     * Callback for creating a record driver.
++     *
++     * @var string
++     */
++    protected $createRecordCallback = 'getSolrRecord';
++
+     /**
+      * Constructor
+      */","It might be better to call this `$createRecordMethod` since it's not a full PHP callback, just a method name for the plugin manager.",Is this really needed? I don't see any rel
+7075,"@@ -15,7 +15,12 @@ namespace Thelia\Action;
+ use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+ use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+ use Thelia\Core\Event\Cart\CartEvent;
++use Thelia\Core\Event\Currency\CurrencyChangeEvent;
+ use Thelia\Core\Event\TheliaEvents;
++use Thelia\Core\HttpFoundation\Request;
++use Thelia\Core\HttpFoundation\Session\Session;
++use Thelia\Log\Tlog;
++use Thelia\Model\Currency;
+ use Thelia\Model\ProductPrice;
+ use Thelia\Model\ProductPriceQuery;
+ use Thelia\Model\CartItem;",remove this line,Shouldn't this be `Event\Money\MoneyChange
+7076,"@@ -24,7 +24,7 @@ class NavigationManager
+     protected $callbacks = [];
+
+     /**
+-     * @var array List of registered items.
++     * @var MainMenuItem[] List of registered items.
+      */
+     protected $items;
+ ","I've never seen this syntax before, it's still just an array, the difference is that it's an array of MainMenuItems instead of an array of arrays.",It's not `@param MainMenuItem[] $items`
+7077,"@@ -1532,10 +1532,15 @@ map_api_set_dll(const char *name, privmod_t *dependent)
+              str_case_prefix(name, ""API-MS-Win-Eventing-Provider-L1-1""))
+         return ""kernelbase.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-Core-PrivateProfile-L1-1"") ||
+-             str_case_prefix(name, ""API-MS-Win-Core-Atoms-L1-1""))
++             str_case_prefix(name, ""API-MS-Win-Core-Atoms-L1-1"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Localization-Obsolete-L1-2"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Kernel32-private-L1-1""))
+         return ""kernel32.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-Core-WinRT-Error-L1-1""))
+         return ""combase.dll"";
++    else if (str_case_prefix(name, ""API-MS-Win-Core-Appinit-L1-1"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Com-L1-1""))
++        return ""ole32.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-GDI-"")) {
+         /* We've seen many different GDI-* */
+         return ""gdi32full.dll"";",nit: to match the others: s/private/Private/,Maybe we should add API-MS-Win-Core-App
+7078,"@@ -96,8 +96,9 @@ namespace Nethermind.Network
+
+         public IReadOnlyCollection<Peer> ActivePeers => _activePeers.Values.ToList().AsReadOnly();
+         public IReadOnlyCollection<Peer> CandidatePeers => _peerPool.CandidatePeers.ToList();
++        public IReadOnlyCollection<Peer> ConnectedPeers => _activePeers.Values.Where(IsConnected).ToList().AsReadOnly();
+         private int AvailableActivePeersCount => MaxActivePeers - _activePeers.Count;
+-        private int MaxActivePeers => _networkConfig.ActivePeersMaxCount + _peerPool.StaticPeerCount;
++        public int MaxActivePeers => _networkConfig.ActivePeersMaxCount + _peerPool.StaticPeerCount;
+
+         public void Init()
+         {",Maybe just IEnumerable? Not sure myself.,What's the difference between the `Acti
+7079,"@@ -54,7 +54,8 @@ public abstract class TestIcebergSourceHiveTables extends TestIcebergSourceTable
+   @Override
+   public Table createTable(TableIdentifier ident, Schema schema, PartitionSpec spec) {
+     TestIcebergSourceHiveTables.currentIdentifier = ident;
+-    return TestIcebergSourceHiveTables.catalog.createTable(ident, schema, spec);
++    Table table = TestIcebergSourceHiveTables.catalog.createTable(ident, schema, spec);
++    return table;
+   }
+
+   @Override",do we need this change?,why change this?
+7080,"@@ -586,7 +586,17 @@ func (s *Server) configureAccounts() error {
+ 	// Check opts and walk through them. We need to copy them here
+ 	// so that we do not keep a real one sitting in the options.
+ 	for _, acc := range s.opts.Accounts {
+-		a := acc.shallowCopy()
++		var a *Account
++		if acc.Name == globalAccountName {
++			a = s.gacc
++		} else {
++			a = acc.shallowCopy()
++		}
++		if acc.hasMappings() {
++			// For now just move and wipe from opts.Accounts version.
++			a.mappings = acc.mappings
++			acc.mappings = nil
++		}
+ 		acc.sl = nil
+ 		acc.clients = nil
+ 		s.registerAccountNoLock(a)","Would want @matthiashanel to have a look since if I recall he had to add the shallowCopy() to fix some bugs during reload. That being said, since I believe the $G account cannot referenced in configurations, this should not be a problem, but Matthias has looked at this in more details in the past.",why do we need to do this?
+7081,"@@ -320,3 +320,19 @@ func (volInfo *VolumeInfo) GetNodeName() string {
+ 	}
+ 	return """"
+ }
++
++// GetVolumeStatus returns the status of the volume
++func (volInfo *VolumeInfo) GetVolumeStatus() string {
++	if len(volInfo.Volume.Status.Reason) > 0 {
++		return volInfo.Volume.Status.Reason
++	}
++	return volumeStatusOK
++}
++
++// GetVolumeNamespace returns the status of the volume
++func (volInfo *VolumeInfo) GetVolumeNamespace() string {
++	if len(volInfo.Volume.ObjectMeta.Namespace) > 0 {
++		return volInfo.Volume.ObjectMeta.Namespace
++	}
++	return ""N/A""
++}",The descriptions are incorrect,Isn't this a breaking chan
+7082,"@@ -1229,6 +1229,14 @@ class WebDriver {
+     if (target && cdpTargets.indexOf(target.toLowerCase()) === -1) {
+       throw new error.InvalidArgumentError('invalid target value')
+     }
++
++    if (debuggerAddress.match(/\/se\/cdp/)) {
++      if (debuggerAddress.match(""ws:\/\/"", ""http:\/\/"")) {
++        return debuggerAddress.replace(""ws:\/\/"", ""http:\/\/"")
++      }
++      return debuggerAddress
++    }
++
+     const path = '/json/version'
+     let request = new http.Request('GET', path)
+     let client = new http.HttpClient('http://' + debuggerAddress)",if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?,Is this only needed in cas
+7083,"@@ -1749,7 +1749,8 @@ class CommandDispatcher:
+             elif going_up and tab.scroller.pos_px().y() > old_scroll_pos.y():
+                 message.info(""Search hit TOP, continuing at BOTTOM"")
+         else:
+-            message.warning(""Text '{}' not found on page!"".format(text))
++            message.warning(""Text '{}' not found on page!"".format(text),
++                    replace=True)
+
+     @cmdutils.register(instance='command-dispatcher', scope='window',
+                        maxsplit=0)",Please only indent this by four spaces.,Please don't replace argum
+7084,"@@ -74,7 +74,7 @@ func isLink(s string) bool {
+
+ func randString(n int) string {
+ 	gen := rand.New(rand.NewSource(time.Now().UnixNano()))
+-	letters := ""abcdefghijklmnopqrstuvwxyz""
++	letters := ""bdghjlmnpqrstvwxyz0123456789""
+ 	b := make([]byte, n)
+ 	for i := range b {
+ 		b[i] = letters[gen.Int63()%int64(len(letters))]",What's the reason behind these characters?,Is there a reason for this change?
+7085,"@@ -13,9 +13,12 @@ describe ParallelDispatcher do
+     end
+
+     it 'creates a new token for each approver' do
+-      expect(ApiToken).to receive(:create!).exactly(2).times
+       expect(dispatcher).to receive(:send_notification_email).twice
+       dispatcher.deliver_new_cart_emails(cart)
++
++      cart.approver_approvals.each do |approval|
++        expect(approval.api_token.expires_at).to be > Time.now
++      end
+     end
+
+     it 'sends a cart notification email to observers' do",Minor: The name of this specs seems a little off now,Do we need to check that `approval
+7086,"@@ -1126,10 +1126,12 @@ ast_result_t pass_syntax(ast_t** astp, pass_opt_t* options)
+     case TK_VALUEFORMALARG:
+     case TK_VALUEFORMALPARAM:
+       ast_error(options->check.errors, ast,
+-        ""Value formal parameters not yet supported"");
++        ""Value formal parameters not yet supported. ""
++        ""Note that many functions including array indexing use the apply ""
++        ""method raher than square brackets"");
+       r = AST_ERROR;
+       break;
+-
++
+     case TK_CONSTANT:
+       ast_error(options->check.errors, ast,
+         ""Compile time expressions not yet supported"");",I'd suggest using `ast_error_continue` here to get the `apply` message in the `Info` part of the error report.,"""Use the apply method raher than s"
+7087,"@@ -72,6 +72,13 @@ class SearchTabsHelper extends \Laminas\View\Helper\AbstractHelper
+      */
+     protected $permissionConfig;
+
++    /**
++     * Tab detailed configuration
++     *
++     * @var array
++     */
++    protected $detailConfig;
++
+     /**
+      * Request
+      *","If we decide to change the name of the .ini setting, we might also want to review the naming of this property and related code. Maybe a simple `getOptions` or `getSettings` would be more concise than `getTabDetailConfig`. At very least, I don't think we need Tab in the method name since the method belongs to a helper with ""Tabs"" in the name.",@wachterjohannes Shouldn't this be
+7088,"@@ -175,6 +175,10 @@ func isListResource(msg *beehiveModel.Message) bool {
+ 			return true
+ 		}
+ 	}
++	// user data
++	if msg.GetGroup() == ""user"" {
++		return true
++	}
+
+ 	return false
+ }","Use const for ""user"", same as below",do we have a constant for this?
+7089,"@@ -79,6 +79,7 @@ class Newsletter extends BaseAction implements EventSubscriberInterface
+             $nl->setEmail($event->getEmail())
+                 ->setFirstname($event->getFirstname())
+                 ->setLastname($event->getLastname())
++                ->setUnsubscribed(0)
+                 ->setLocale($event->getLocale())
+                 ->save();
+ ",->setUnsubscribed(false) would be better :),Is there a reason why you set t
+7090,"@@ -0,0 +1,11 @@
++# frozen_string_literal: true
++
++module Faker
++  class Sports < Base
++    class << self
++      def name
++        fetch('sports.name')
++      end
++    end
++  end
++end","I now think singular `Sport` is better, but I will wait for the first round of feedback before updating.",Use nested module/class definit
+7091,"@@ -167,6 +167,9 @@ class UserResource:
+             parent_id=parent_id,
+             auth=auth)
+
++        # Initialize timestamp as soon as possible.
++        self.timestamp
++
+         self.request = request
+         self.context = context
+         self.record_id = self.request.matchdict.get('id')",Don't you need = something ?,Do we need it in the request?
+7092,"@@ -1869,10 +1869,12 @@ bool CoreChecks::ValidateCmdQueueFlags(const CMD_BUFFER_STATE *cb_node, const ch
+                                        const char *error_code) const {
+     auto pool = cb_node->command_pool.get();
+     if (pool) {
+-        VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[pool->queueFamilyIndex].queueFlags;
++        const uint32_t queue_family_index = pool->queueFamilyIndex;
++        const VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[queue_family_index].queueFlags;
+         if (!(required_flags & queue_flags)) {
+             string required_flags_string;
+-            for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT}) {
++            for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT, VK_QUEUE_SPARSE_BINDING_BIT,
++                              VK_QUEUE_PROTECTED_BIT}) {
+                 if (flag & required_flags) {
+                     if (required_flags_string.size()) {
+                         required_flags_string += "" or "";",Looks like this could be `const` (I realize it wasn't like that before)?,"Don't you need to remove the ""required_flags_string"" below too?"
+7093,"@@ -7,7 +7,8 @@ import com.fsck.k9.message.preview.PreviewResult.PreviewType;
+ public enum DatabasePreviewType {
+     NONE(""none"", PreviewType.NONE),
+     TEXT(""text"", PreviewType.TEXT),
+-    ENCRYPTED(""encrypted"", PreviewType.ENCRYPTED);
++    ENCRYPTED(""encrypted"", PreviewType.ENCRYPTED),
++    FAILED_TO_LOAD(""failedToLoad"", PreviewType.FAILED_TO_LOAD);
+
+
+     private final String databaseValue;",Maybe just `FAILED`. We can't be sure loading was the thing that failed.,why did you change this enum value?
+7094,"@@ -1,5 +1,5 @@
+-define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSettings', 'cardBuilder', 'datetime', 'mediaInfo', 'backdrop', 'listView', 'itemContextMenu', 'itemHelper', 'dom', 'indicators', 'imageLoader', 'libraryMenu', 'globalize', 'browser', 'events', 'playbackManager', 'scrollStyles', 'emby-itemscontainer', 'emby-checkbox', 'emby-button', 'emby-playstatebutton', 'emby-ratingbutton', 'emby-scroller', 'emby-select'], function (loading, appRouter, layoutManager, connectionManager, userSettings, cardBuilder, datetime, mediaInfo, backdrop, listView, itemContextMenu, itemHelper, dom, indicators, imageLoader, libraryMenu, globalize, browser, events, playbackManager) {
+-    'use strict';
++define([""loading"", ""appRouter"", ""layoutManager"", ""connectionManager"", ""userSettings"", ""cardBuilder"", ""datetime"", ""mediaInfo"", ""backdrop"", ""listView"", ""itemContextMenu"", ""itemHelper"", ""dom"", ""indicators"", ""imageLoader"", ""libraryMenu"", ""globalize"", ""browser"", ""events"", ""playbackManager"", ""scrollStyles"", ""emby-itemscontainer"", ""emby-checkbox"", ""emby-button"", ""emby-playstatebutton"", ""emby-ratingbutton"", ""emby-scroller"", ""emby-select""], function (loading, appRouter, layoutManager, connectionManager, userSettings, cardBuilder, datetime, mediaInfo, backdrop, listView, itemContextMenu, itemHelper, dom, indicators, imageLoader, libraryMenu, globalize, browser, events, playbackManager) {
++    ""use strict"";
+
+     function getPromise(apiClient, params) {
+         var id = params.id;","You have replaced single quotes with double ones, this fails linting and our current coding style. Please fix this, otherwise it's a whopping of 1200 LoC while in reality it should be rather small.",This was changed as part of the refactoring. The `define` shoul
+7095,"@@ -43,6 +43,9 @@ public class PlaybackPreferences implements
+ 	/** True if last played media was a video. */
+ 	public static final String PREF_CURRENT_EPISODE_IS_VIDEO = ""de.danoeh.antennapod.preferences.lastIsVideo"";
+
++	/** Value of PREF_QUEUE_ADD_TO_FRONT if no media is playing. */
++	public static final String PREF_QUEUE_ADD_TO_FRONT = ""prefQueueAddToFront"";
++
+ 	/** Value of PREF_CURRENTLY_PLAYING_MEDIA if no media is playing. */
+ 	public static final long NO_MEDIA_PLAYING = -1;
+ ","@danieloeh @TomHennen. Some of these files are using spaces, the others use tabs. Is there a project wide preference? I personally like spaces, because they are consistent across editors","Let's rename this to something more meaningful, e.g. `PREF_QUEU"
+7096,"@@ -11,10 +11,12 @@ module Blacklight
+     # @param [SolrDocument] document
+     # @param [ActionView::Base] view_context scope for linking and generating urls
+     # @param [Blacklight::Configuration] configuration
+-    def initialize(document, view_context, configuration = view_context.blacklight_config)
++    # @param [Integer] counter what offset in the search result is this record (used for tracking)
++    def initialize(document, view_context, configuration = view_context.blacklight_config, counter: nil)
+       @document = document
+       @view_context = view_context
+       @configuration = configuration
++      @counter = counter
+     end
+
+     # @return [Hash<String,Configuration::Field>]  all the fields for this index view that should be rendered","I guess this is ok for backwards-compatibility? Maybe it'd be better to check arity in the helpers? Or just call it out in the release notes, because there are at least a couple projects on github that overrode `initialize`..","I think it might be helpful to add a keyword here, e.g. `#@param [Integer] counter what to include in the search result`"
+7097,"@@ -194,8 +194,8 @@ public class AzkabanWebServer extends AzkabanServer {
+     // TODO remove hack. Move injection to constructor
+     executorManager = SERVICE_PROVIDER.getInstance(ExecutorManager.class);
+     projectManager = SERVICE_PROVIDER.getInstance(ProjectManager.class);
++    triggerManager = SERVICE_PROVIDER.getInstance(TriggerManager.class);
+
+-    triggerManager = loadTriggerManager(props);
+     loadBuiltinCheckersAndActions();
+
+     // load all trigger agents here","At some point, we would like to get rid of these custom injections as well. Looks Ok for now.",Do we still need to assign `triggerManager` to `projectManager`?
+7098,"@@ -349,6 +349,13 @@ namespace Datadog.Trace.Configuration
+             /// </summary>
+             /// <seealso cref=""TracerSettings.DelayWcfInstrumentationEnabled""/>
+             public const string DelayWcfInstrumentationEnabled = ""DD_TRACE_DELAY_WCF_INSTRUMENTATION_ENABLED"";
++
++            /// <summary>
++            /// Enables a fix around header tags normalization.
++            /// We used to normalize periods even if a tag was provided for a header, whereas we should not.
++            /// This flag defaults to true and is here in case customers need retrocompatibility only
++            /// </summary>
++            public const string HeaderTagsNormalizationFixEnabled = ""DD_TRACE_HEADER_TAG_NORMALIZATION_FIX_ENABLED"";
+         }
+     }
+ }","nit: Not a fan of ""fix"" in the name, but don't have a better suggestion  ",Do we want to add this to the `TraceLoggingConfig`?
+7099,"@@ -181,6 +181,11 @@ class TabWidget(QTabWidget):
+         except qtutils.QtValueError:
+             fields['current_url'] = ''
+
++        try:
++            fields['protocol'] = self.tab_url(idx).scheme()
++        except qtutils.QtValueError:
++            fields['protocol'] = ''
++
+         y = tab.scroller.pos_perc()[1]
+         if y is None:
+             scroll_pos = '???'","Since we're calling `self.tab_url(idx)` a third time here already, can you please add a `url = self.tab_url(idx)` somewhere above (e.g. after all the `fields[...] = ...` assignments) and change the calls here to `url.host()` etc.?","I think we should log something here, so that we know what's going to happen when we catch the error."
+7100,"@@ -15,8 +15,8 @@
+ """"""Forseti CLI installer.""""""
+
+ from forseti_installer import ForsetiInstaller
+-
+ from util import gcloud
++from util import constants
+
+ class ForsetiClientInstaller(ForsetiInstaller):
+     """"""Forseti command line interface installer""""""",alphasort this import,Don't need a new line here.
+7101,"@@ -0,0 +1,14 @@
++#include<iostream>
++using namespace std;
++void reverseNum(int digit){
++	while(digit>0){
++		int n=digit%10;
++		digit=digit/10;
++		cout<<n<<""\t"";
++	}
++}
++int main(){
++	int digit;
++	cin>>digit;
++	reverseNum(digit);
++}",remove this file!,I'm not sure what this is f
+7102,"@@ -256,11 +256,14 @@ func (acc *Account) String() string {
+ 			etas = ""0s""
+ 		}
+ 	}
++
+ 	name := []rune(acc.name)
+ 	if fs.Config.StatsFileNameLength > 0 {
+ 		if len(name) > fs.Config.StatsFileNameLength {
+-			where := len(name) - fs.Config.StatsFileNameLength
+-			name = append([]rune{'.', '.', '.'}, name[where:]...)
++			suffixLength := fs.Config.StatsFileNameLength / 2
++			prefixLength := fs.Config.StatsFileNameLength - suffixLength
++			suffixStart := len(name) - suffixLength
++			name = append(append(name[:prefixLength], '…'), name[suffixStart:]...)
+ 		}
+ 	}
+ ",You don't need to say `rune(' ')` - `' '` is already a `rune`.,is there a reason for this
+7103,"@@ -38,7 +38,7 @@ module Selenium
+         port
+       end
+
+-      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
++      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL].freeze
+       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+       IGNORED_ERRORS.freeze
+ ",We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it.,`EADDRNOTAVAIL` should be c
+7104,"@@ -0,0 +1,5 @@
++package javaslang.control;
++
++public interface Kind<TYPE extends Kind<TYPE, ?, ?>, E, T> {
++
++}",We call it Kind2 and move out of the `javaslang/control` package into the `javaslang`package. Maybe I will later generate Kind1..Kindn but that's another story.,I wonder if we should make this an actual `T` instead of a `T extends Kind<TYPE>`
+7105,"@@ -166,7 +166,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
+-	db.logger.Infof(""db capacity: %v"", db.capacity)
++	db.logger.Infof(""database capacity in chunks (and in Bytes): %v (%v)"", db.capacity, db.capacity*swarm.ChunkSize)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","i think it might be nicer to have a message like: `database capacity: %d chunks (%d bytes, %d megabytes)`. counting in bytes is so 90s :)",I think we should only output this if `db.capacity > 0 && db.capacity*swarm.Chunk
+7106,"@@ -195,6 +195,16 @@ public class Constants {
+
+     // dir to keep dependency plugins
+     public static final String DEPENDENCY_PLUGIN_DIR = ""azkaban.dependency.plugin.dir"";
++
++    /*
++     * Prefix used to construct Hadoop/Spark user job link.
++     * a) RM: resource manager
++     * b) JHS: Hadoop job history server
++     * c) SHS: spark job history server
++     * */
++    public static final String AZKABAN_RM_JOB_LINK = ""azkaban.rm.job.link"";
++    public static final String AZKABAN_JHS_JOB_LINK = ""azkaban.jhs.job.link"";
++    public static final String AZKABAN_SHS_JOB_LINK = ""azkaban.shs.job.link"";
+   }
+
+   public static class FlowProperties {","The '.' in the key names are used to separate namespaces, NOT to separate words. How about azkaban.external_resources.resource_manager? ---- Why is it better than using the full name in the variable name e.g. RESOURCE_MANAGER_LINK ?",Why is this not in `azkaban.properties`?
+7107,"@@ -17,7 +17,7 @@
+ using BenchmarkDotNet.Attributes;
+ using Benchmarks.Tracing;
+ using OpenTelemetry.Trace;
+-using OpenTelemetry.Trace.Configuration;
++using OpenTelemetry.Trace;
+ using OpenTelemetry.Trace.Samplers;
+
+ namespace Benchmarks",This seems to be duplicated with line 19?,@jkotas should this be `using OpenTelemetry.Trace;`?
+7108,"@@ -20,7 +20,7 @@
+ #endif
+
+ #if !(defined(_WIN32) || (defined(__WXMAC__) && (MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_4)))
+-#include <xlocale.h>
++#include <wx/xlocale.h>
+ #endif
+
+ #include ""stdwx.h""","This is wrong. xlocale.h is needed on OSX and maybe elsewhere too. This needs a test in configure to see if xlocale.h and uselocale() are available and an #if test here. Also, the NO_PER_THREAD_LOCALE stuff in configure.ac needs to be updated to include test for uselocale().",Wouldn't it be better to move this include into the `#ifdef _WIN32` block?
+7109,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteAccessKey.java demonstrates how to delete an access key from an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[DeleteAccessKey.java demonstrates how to delete an access key from an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I am a bit confused by the fact that there is no `DeleteAccessKey.java dem
+7110,"@@ -138,7 +138,7 @@ utils.imageReplacement = function(ResourceModel, src, resources, resourceBaseUrl
+ 	}
+
+ 	const mime = resource.mime ? resource.mime.toLowerCase() : '';
+-	if (ResourceModel.isSupportedImageMimeType(mime)) {
++	if (ResourceModel.isSupportedImageMimeType(mime) || ResourceModel.isSupportedAudioMimeType(mime)) {
+ 		let newSrc = `./${ResourceModel.filename(resource)}`;
+ 		if (resourceBaseUrl) newSrc = resourceBaseUrl + newSrc;
+ 		newSrc += `?t=${resource.updated_time}`;","Why did you have multiple function calls here instead of having one long array of supported mimeTypes? In line with your PR here, I think we might eventually see inline videos or inline pdf. It would be great to generalize this a bit.",The call to `toLowerCase()` in `ResourceModel.isSupportedAudioMimeType()`
+7111,"@@ -37,6 +37,7 @@ from pyspark.sql.types import (
+     LongType,
+     StringType,
+     TimestampType,
++    NumericType,
+ )
+
+ from databricks import koalas as ks  # For running doctests and reference resolution in PyCharm.",nit: shall we keep alphabetical order?,Please update this to use `from pants.option.index import FormatControl`
+7112,"@@ -106,6 +106,15 @@ export default class Realm {
+         let method = util.createMethod(objectTypes.REALM, 'objects');
+         return method.apply(this, [type, ...args]);
+     }
++
++    objectForPrimaryKey(type, ...args) {
++        if (typeof type == 'function') {
++            type = objects.typeForConstructor(this[keys.realm], type);
++        }
++
++        let method = util.createMethod(objectTypes.REALM, 'objectForPrimaryKey');
++        return method.apply(this, [type, ...args]);
++    }
+ }
+
+ // Non-mutating methods:",We could just move the check for function into `typeForConstruction` to make this a one liner every time we need to do this.,Why is this needed? We don't use `this[keys.realm]` in the constructor.
+7113,"@@ -153,7 +153,7 @@ public class I18nTest extends JUnit4TestBase {
+     assertThat(ime.isActivated()).isTrue();
+     assertThat(ime.getActiveEngine()).isEqualTo(desiredEngine);
+
+-    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to convert the word.
++    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to transform the word.
+     input.sendKeys(""toukyou "");
+     input.sendKeys(Keys.ENTER);
+ ",A correct by unrelated change. We'll slide this one in without another word ;),"It's correct to change this to ""Send the Romaji for ""Tokyo"""
+7114,"@@ -40,6 +40,9 @@ Solver<Dtype>::Solver(const SolverParameter& param)
+ template <typename Dtype>
+ void Solver<Dtype>::Solve(const char* resume_file) {
+   Caffe::set_mode(Caffe::Brew(param_.solver_mode()));
++  if (param_.solver_mode()) {
++    Caffe::SetDevice(param_.device_id());
++  }
+   Caffe::set_phase(Caffe::TRAIN);
+   LOG(INFO) << ""Solving "" << net_->name();
+   PreSolve();","I feel that a slightly safer way is to do if (param_.has_device_id()) { Caffe::SetDevice(param_.device_id()); } just in case a user has hard-coded a device id outside the solver and does not specify the device id in the solver param. Currently, if nothing is set, the solver will always use the 0th device, which might not be desired.","For the sake of consistency with the rest of Solver, this should be: `i"
+7115,"@@ -321,6 +321,7 @@ class TestSeleniumScriptBuilder(SeleniumTestCase):
+                             ""closeWindow('that_window')"",
+                             ""submitByName(\""toPort\"")"",
+                             ""scriptEval(\""alert('This is Sparta');\"")"",
++                            ""rawCode(multi(1)\n  line(2)\n    block(33))"",
+                             {""dragByID(address)"": ""elementByName(toPort)""},
+                             ""switchFrameByName('my_frame')"",
+                             ""switchFrameByIdx(1)"",","let's replace this example with something that won't fail in Python. Like ""for+if+print""",I'm surprised this passes the checkstyle. I've never seen this before.
+7116,"@@ -268,7 +268,8 @@ def _to_graphviz(tree_info, show_info, feature_names, precision=None,
+         raise ImportError('You must install graphviz to plot tree.')
+
+     def float2str(value, precision=None):
+-        return ""{0:.{1}f}"".format(value, precision) if precision is not None else str(value)
++        return ""{0:.{1}f}"".format(value, precision) \
++            if (precision is not None) and (not isinstance(value, str)) else str(value)
+
+     def add(root, parent=None, decision=None):
+         """"""recursively add node or edge""""""",Please remove the brackets and use `string_type` from `compat.py` module instead of `str` in `isinstance()`.,"Can we simplify this to `if not isinstance(value, str)`?"
+7117,"@@ -36,16 +36,11 @@ type Execution struct {
+ }
+
+ // NewExecution returns a Execution instance
+-func NewExecution(executorAddress string, contractAddress string, nonce uint64, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) (*Execution, error) {
+-	if executorAddress == """" {
+-		return nil, errors.Wrap(ErrAddress, ""address of the executor is empty"")
+-	}
+-
++func NewExecution(contractAddress string, nonce uint64, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) (*Execution, error) {
+ 	return &Execution{
+ 		AbstractAction: AbstractAction{
+ 			version:  version.ProtocolVersion,
+ 			nonce:    nonce,
+-			srcAddr:  executorAddress,
+ 			dstAddr:  contractAddress,
+ 			gasLimit: gasLimit,
+ 			gasPrice: gasPrice,",line is 143 characters (from `lll`),Why remove this check?
+7118,"@@ -94,7 +94,11 @@ func NewController(params Params) (types.Controller, error) {
+ 						for i := 0; i < items.Len(); i++ {
+ 							item := items.Index(i).Addr().Interface().(InnerObjectWithSelector)
+ 							for _, record := range item.GetStatus().Experiment.Records {
+-								if controller.ParseNamespacedName(record.Id) == objName {
++								namespacedName, err := controller.ParseNamespacedName(record.Id)
++								if err != nil {
++									setupLog.Error(err, ""failed to parse record"", ""record"", record.Id)
++								}
++								if namespacedName == objName {
+ 									id := k8sTypes.NamespacedName{
+ 										Namespace: item.GetObjectMeta().Namespace,
+ 										Name:      item.GetObjectMeta().Name,",It should follow a `continue`.,Please use `errors.Wrapf`
+7119,"@@ -18,6 +18,7 @@ services:
+         gid: '{{ .GID }}'
+     image: ${DDEV_DBIMAGE}-${DDEV_SITENAME}-built
+     stop_grace_period: 60s
++    working_dir: ""{{ .WebWorkingDir }}""
+     volumes:
+       - type: ""volume""
+         source: mariadb-database",Should this be DBWorkingDir?,"Should this be ""{{ .WebWorkingDir }}"" ?"
+7120,"@@ -542,7 +542,7 @@ public class AutoScalingHandler extends RequestHandlerBase implements Permission
+     String eventTypeStr = op.getStr(EVENT);
+
+     if (op.hasError()) return currentConfig;
+-    TriggerEventType eventType = TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
++    TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
+
+     String waitForStr = op.getStr(WAIT_FOR, null);
+ ",I think you can remove the whole line.,I think we should leave this as it was and add a check `if (eventTypeStr.trim().toUpperCase(Locale.ROOT).equals(TriggerEventType.ROOT))`
+7121,"@@ -8,6 +8,7 @@ package consensus
+
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-core/db""
+ 	""math/big""
+
+ 	""github.com/facebookgo/clock""",File is not `goimports`-ed (from `goimports`),"Iotex project doesn't have a db package, so I don't think this import is needed."
+7122,"@@ -40,12 +40,13 @@ public class ClientHarvestRun implements Serializable {
+         this.id = id;
+     }
+
+-    public enum RunResultType { SUCCESS, FAILURE, INPROGRESS };
++    public enum RunResultType { SUCCESS, RUN_FAILED, RUN_IN_PROGRESS, DELETE_FAILED };
+
+     private static String RESULT_LABEL_SUCCESS = ""SUCCESS"";
+-    private static String RESULT_LABEL_FAILURE = ""FAILED"";
+-    private static String RESULT_LABEL_INPROGRESS = ""IN PROGRESS"";
+-    private static String RESULT_DELETE_IN_PROGRESS = ""DELETE IN PROGRESS"";
++    private static String RESULT_LABEL_RUN_FAILED = ""RUN FAILED"";
++    private static String RESULT_LABEL_RUN_IN_PROGRESS = ""RUN IN PROGRESS"";
++    private static String RESULT_LABEL_DELETE_IN_PROGRESS = ""DELETE IN PROGRESS"";
++    private static String RESULT_LABEL_DELETE_FAILED = ""DELETE FAILED"";
+
+     @ManyToOne
+     @JoinColumn(nullable = false)","Not a big deal, but what is the value of adding this status condition for a failure to delete a client? It has some value for a dataverse admin, to know that the last attempt to harvest from a certain server resulted in a failure. Is it really useful to know that an attempt to delete a client failed? - should the startup check simply remove the ""delete in progress"" flag quietly instead? After all, seeing how the client is still there makes it somewhat clear that the attempt to get rid of it didn't work out, so they should try again? I may be missing some situation where it could actually be useful - so I'm open to hearing it.",Do we really need this new type? I thought `RunResult` and `ActionResult` were the same
+7123,"@@ -85,7 +85,7 @@ public abstract class BaseWriterFactory<T> implements WriterFactory<T> {
+     OutputFile outputFile = file.encryptingOutputFile();
+     EncryptionKeyMetadata keyMetadata = file.keyMetadata();
+     Map<String, String> properties = table.properties();
+-    MetricsConfig metricsConfig = MetricsConfig.fromProperties(properties);
++    MetricsConfig metricsConfig = MetricsConfig.forTable(table);
+
+     try {
+       switch (dataFileFormat) {",Can we also update the equality delete branch below?,`metricsConfig.forTable(table)` can be replaced with `metricsConfig.forProperties(properties).getClass().getName()`.
+7124,"@@ -457,6 +457,11 @@ class StepExecutionContext(PlanExecutionContext, IStepContext):
+             if step_output_handle == record.dagster_event.event_specific_data.step_output_handle:
+                 return True
+
++        # source is skipped so cannot load
++        for record in self.instance.all_logs(self.run_id, of_type=DagsterEventType.STEP_SKIPPED):
++            if step_output_handle.step_key == record.dagster_event.step_key:
++                return False
++
+         # can load from a previous run
+         if self._get_source_run_id_from_logs(step_output_handle):
+             return True","This doesn't solve the entire problem we talked abut yesterday, right? Because it's possible that the step itself didn't skip, but rather that it chose not to yield the output in question?",Could you explain why this change is needed?
+7125,"@@ -5,6 +5,7 @@
+ # -------------------------------------------------------------------------
+
+ import base64
++from datetime import datetime
+ from hashlib import sha256
+ import json
+ import os",I also do not see any usages of this import. Is this a fix for a crash?,Don't need to add this import here.
+7126,"@@ -794,6 +794,9 @@ func (engine *DockerTaskEngine) AddTask(task *apitask.Task) {
+ 		// This will update the container desired status
+ 		task.UpdateDesiredStatus()
+
++		// This will update any dependencies for awsvpc network mode before the task is started.
++		engine.updateTaskENIDependencies(task)
++
+ 		engine.state.AddTask(task)
+ 		if dependencygraph.ValidDependencies(task, engine.cfg) {
+ 			engine.startTask(task)",Feels like this needs to be invoked in `PostUnmarshalTask` since that's where most of the task setup happens.,Why do we need to run update taskENIDependen
+7127,"@@ -5390,7 +5390,8 @@ PrivStatus ObjectPrivsMDTable::updateWhere(const std::string & setClause,
+ //    <catalogName> ""<schema_name>"".""<object_name>"",
+ //    object_type,
+ //    object_owner, -- granteeID
+-//    (select auth_db_name from AUTHS where auth_id = object_owner), --granteeName
++//    coalesce((select auth_db_name from AUTHS where auth_id = object_owner),
++//             'DB__ROOT') --granteeName
+ //    USER_GRANTEE_LIT, -- ""U""
+ //    SYSTEM_AUTH_ID,  -- system grantor ID (-2)
+ //    SYSTEM_AUTH_NAME, -- grantorName (_SYSTEM)",I wonder what would happen if the granteeName becomes DB__ROOT but the granteeID is not DB__ROOT ID (33333) but something else.,Is this still needed? AFAIK the query doesn'
+7128,"@@ -299,6 +299,10 @@ func (install *PleaseGoInstall) compilePackage(target string, pkg *build.Package
+ 			}
+ 		}
+
++		if f := os.Getenv(""CFLAGS""); f != """" {
++			cFlags = append(cFlags, f)
++		}
++
+ 		cFiles := pkg.CFiles
+
+ 		cgoGoFiles, cgoCFiles, err := install.tc.CGO(pkg.Dir, workDir, cFlags, pkg.CgoFiles)",Feel like this should probably come into this tool as a flag rather than it just grabbing an env var internally?,Feels like this should be defined in `pkg/install/install.go`
+7129,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",Should this be `nameOrHandle`?
+7130,"@@ -7,7 +7,7 @@ module MentorHelper
+     mail_to(
+       mentor.email,
+       I18n.t(
+-        'dashboards.show.contact_your_mentor',
++        'shared.header.contact_your_mentor',
+         mentor_name: mentor.first_name
+       )
+     )",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Looks like you missed the `show` prefix here.
+7131,"@@ -90,6 +90,18 @@ class ConfigValidatorUtilTest(ForsetiTestCase):
+         actual_path = cv_data_converter.generate_ancestry_path(full_name)
+         self.assertEqual(expected_path, actual_path)
+
++    def test_generate_ancestors_for_org(self):
++        full_name = 'organization/1234567890/project/test-project-123/firewall/1234567890123456789/'
++        expected_ancestors = ['organization/1234567890', 'project/test-project-123']
++        actual_ancestors = cv_data_converter.generate_ancestors(full_name)
++        self.assertListEqual(expected_ancestors, actual_ancestors)
++
++    def test_generate_ancestors_for_folder(self):
++        full_name = 'folder/folder-1/project/project-2/lien/p123/'
++        expected_ancestors = ['folder/folder-1', 'project/project-2']
++        actual_ancestors = cv_data_converter.generate_ancestors(full_name)
++        self.assertListEqual(expected_ancestors, actual_ancestors)
++
+     def test_cleanup_dict_does_not_replace_false(self):
+         firewall = mock_cai_resources.FIREWALL_DATA
+         cv_data_converter.cleanup_dict(firewall)","nit: folders are always a numeric ID, projects as given by CAI use project number for ancestry",You should use `assertListEqual` instead.
+7132,"@@ -35,7 +35,12 @@ import (
+ 	""github.com/multiformats/go-multistream""
+ )
+
+-var _ p2p.Service = (*Service)(nil)
++var (
++	_ p2p.Service = (*Service)(nil)
++
++	// ErrBadNetwork indicates that it is suspected that network is currently in bad condition
++	ErrBadNetwork = errors.New(""bad network"")
++)
+
+ type Service struct {
+ 	ctx              context.Context",is this used anywhere?,"If you make `bad network` an error, wouldn't `bad network error` be better?"
+7133,"@@ -28,7 +28,6 @@ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/versioned""
+ 	""github.com/openebs/maya/pkg/debug""
+-	merrors ""github.com/openebs/maya/pkg/errors/v1alpha1""
+ 	pkg_errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/errors""",change pkg_errors to errors. Keep it consistent across all the files.,`pkg/api/v1` should now be `pkg/api/v1alpha1`
+7134,"@@ -657,7 +657,8 @@ class LocalRemote(unittest.TestCase):
+
+         resolved_results, _, returncode = get_diff_results(
+             [self._run_names[0]], [baseline_file_path], '--resolved', 'json',
+-            [""--url"", self._url])
++            [""--url"", self._url,
++             ""--review-status"", ""unreviewed"", ""confirmed"", ""false_positive""])
+         print(resolved_results)
+
+         self.assertTrue(resolved_results)",I don't see any test cases which would test that fix dates are set properly on review status changes / storage events. For this reason please create some more test cases and also check my scenarios above.,"FYI @krzysztofwolski this was the only place I could find that ""false_posit"
+7135,"@@ -109,6 +109,10 @@ namespace Microsoft.Rest.Generator
+             foreach (var method in client.Methods)
+             {
+                 NormalizeMethod(method);
++                if (method.DefaultResponse != null && method.DefaultResponse is CompositeType)
++                {
++                    client.Exceptions.Add((CompositeType)method.DefaultResponse);
++                }
+             }
+         }
+ ",This belongs to SwaggerModeler.cs `public override ServiceClient Build()`,@mjkkirschner @Benglin What do you think about making this `if (method.Defa
+7136,"@@ -286,9 +286,11 @@ export default () => {
+      * Defines column widths in pixels. Accepts number, string (that will be converted to a number), array of numbers
+      * (if you want to define column width separately for each column) or a function (if you want to set column width
+      * dynamically on each render).
++     *
++     * Note that this option will disable {@link AutoColumnSize} plugin.
+      *
+      * @memberof Options#
+-     * @type {number|number[]|string|string[]|Function}
++     * @type {number|(number|undefined)[]|string|(string|undefined)[]|Function}
+      * @default undefined
+      *
+      * @example",We could go further and directly give the tips of the `columns` property for someone (like me) who would like to specify some column width and let the others be autosized.,Would it make sense to add `|undefined` to these too?
+7137,"@@ -1058,8 +1058,17 @@ void VkRenderFramework::InitRenderTarget(uint32_t targets, VkImageView *dsBindin
+                                     VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
+         // Must include dep_by_region bit when src & dst both include framebuffer-space stages
+         subpass_dep.dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT;
+-        rp_info.dependencyCount = 1;
+-        rp_info.pDependencies = &subpass_dep;
++    }
++
++    if (m_additionalSubpassDependencies.size()) {
++        m_renderPass_dependencies.reserve(m_additionalSubpassDependencies.size() + m_renderPass_dependencies.size());
++        m_renderPass_dependencies.insert(m_renderPass_dependencies.end(), m_additionalSubpassDependencies.begin(),
++                                         m_additionalSubpassDependencies.end());
++    }
++
++    if (m_renderPass_dependencies.size()) {
++        rp_info.dependencyCount = static_cast<uint32_t>(m_renderPass_dependencies.size());
++        rp_info.pDependencies = m_renderPass_dependencies.data();
+     } else {
+         rp_info.dependencyCount = 0;
+         rp_info.pDependencies = nullptr;",I think a `std::copy` with `std::back_inserter` will get this done in one call.,It looks like this line is repeated several times. Ma
+7138,"@@ -47,6 +47,11 @@ type cryptoSetupServer struct {
+
+ var _ CryptoSetup = &cryptoSetupServer{}
+
++// ErrHOLExperiment is returned when the client sends the FHL2 tag in the CHLO
++// this is an expiremnt implemented by Chrome in QUIC 36, which we don't support
++// TODO: remove this when dropping support for QUIC 36
++var ErrHOLExperiment = qerr.Error(qerr.InvalidCryptoMessageParameter, ""HOL experiment. Unsupported"")
++
+ // NewCryptoSetup creates a new CryptoSetup instance for a server
+ func NewCryptoSetup(
+ 	connID protocol.ConnectionID,",In the future: s/QUIC 36/Version36/ to make grepping easier,We should add a ticket to drop this when we dropping
+7139,"@@ -29,11 +29,13 @@ class FileCard extends Component {
+     }
+   }
+
+-  tempStoreMeta = (ev, name) => {
++  tempStoreMeta = (ev, name, type) => {
++    var value = ev.target.value
++    if (type === 'checkbox') value = ev.target.checked ? 'on' : 'off'
+     this.setState({
+       formState: {
+         ...this.state.formState,
+-        [name]: ev.target.value
++        [name]: value
+       }
+     })
+   }",This is an example of why I prefer a flexible custom `render()` solution   'on'/'off' may not be the right value for every application. You have to make a lot of decisions even for very simple form fields :(,Why do we need a new `type` param?
+7140,"@@ -568,7 +568,6 @@ func (data *TestData) deployAntreaIPSec() error {
+ func (data *TestData) deployAntreaFlowExporter(ipfixCollector string) error {
+ 	// Enable flow exporter feature and add related config params to antrea agent configmap.
+ 	ac := []configChange{
+-		{""FlowExporter"", ""true"", true},
+ 		{""flowPollInterval"", ""\""1s\"""", false},
+ 		{""activeFlowExportTimeout"", fmt.Sprintf(""\""%v\"""", exporterActiveFlowExportTimeout), false},
+ 		{""idleFlowExportTimeout"", fmt.Sprintf(""\""%v\"""", exporterIdleFlowExportTimeout), false},",we should also skip the e2e flow aggregator tests if the Flow Exporter feature is disabled.,Why was this removed?
+7141,"@@ -225,6 +225,7 @@ class ConsoleMaster(flow.FlowMaster):
+                 if err:
+                     print >> sys.stderr, ""Script load error:"", err
+                     sys.exit(1)
++                script.ObserveScripts(self, i)
+
+         if options.outfile:
+             err = self.start_stream_to_path(","We should initialize the observation in the constructor of the Script class - otherwise, we don't have this feature for mitmdump.",Shouldn't this be don
+7142,"@@ -172,9 +172,11 @@ class Index(IndexOpsMixin):
+             raise ValueError('Names must be a list-like')
+         internal = self._kdf._internal
+         if len(internal.index_map) != len(names):
++
+             raise ValueError('Length of new names must be {}, got {}'
+                              .format(len(internal.index_map), len(names)))
+-        names = [name if isinstance(name, tuple) else (name,) for name in names]
++
++        names = [name if isinstance(name, (tuple, type(None))) else (name,) for name in names]
+         self._kdf._internal = internal.copy(index_map=list(zip(internal.index_columns, names)))
+
+     @property",I would remove this line. Otherwise looks fine cc @ueshin,@Eric89GXL don't we n
+7143,"@@ -50,7 +50,7 @@ TEST (ledger_walker, genesis_account_longer)
+
+ 	nano::ledger_walker ledger_walker{ node->ledger };
+ 	EXPECT_TRUE (ledger_walker.walked_blocks.empty ());
+-	EXPECT_EQ (1, ledger_walker.walked_blocks.bucket_count ());
++	EXPECT_LE (ledger_walker.walked_blocks.bucket_count (), 1);
+ 	EXPECT_TRUE (ledger_walker.blocks_to_walk.empty ());
+
+ 	const auto get_number_of_walked_blocks = [&ledger_walker] (const auto & start_block_hash) {",Would it be better to remove that line alltogether if it not directly relevant?,>EXPECT_LE (ledger_wa
+7144,"@@ -693,6 +693,13 @@ signal_arch_init(void)
+          * compiler from optimizing it away.
+          * XXX i#641, i#639: this breaks transparency to some extent until the
+          * app uses fpu/xmm but we live with it.
++         * Given a security vulnerability and its mitigations, executing a fpu/xmm
++         * operation here might not be necessary anymore. The vulnerabilty, published on
++         * June 13, 2018, is CVE-2018-3665: ""Lazy FPU Restore"" schemes are vulnerable to
++         * the FPU state information leakage issue. The kernel-based mitigation was to
++         * automatically default to (safe) ""eager"" floating point register restore.  In
++         * this mode FPU state is saved and restored for every task/context switch
++         * regardless of whether the current process invokes FPU instructions or not.
+          */
+         __asm__ __volatile__(""movd %%xmm0, %0"" : ""=g""(rc));
+         memset(&act, 0, sizeof(act));","Does ""FPU"" here include XMM/YMM/ZMM SIMD and not just x87 FPU/MMX?","Well, it's not ""safe"", but ""eager"". I wonder if it's better to say ""default to lazy FPU""."
+7145,"@@ -226,7 +226,7 @@ class TokValueFile(Token):
+         return generators.FileGenerator(s)
+
+     def spec(self):
+-        return ""<'%s'"" % strutils.bytes_to_escaped_str(self.path)
++        return ""<'%s'"" % self.path
+
+
+ TokValue = pp.MatchFirst(","I'm not sure if we need to store path as bytes, and then decode/escape it when printing or just store it as a unicode string (as done here.)","Doesn't `self.path` need to be escaped? If so, you can use `os.path.basename(self.path)`."
+7146,"@@ -7,7 +7,7 @@ testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+
+
+ def test_hostname(host):
+-    assert 'instance' == host.check_output('hostname -s')
++    assert host.check_output('hostname -s') == 'instance'
+
+
+ def test_etc_molecule_directory(host):",Why is this flipped? Looks unrelated and our pattern is `expected == returned`.,What does this change have to do with this PR?
+7147,"@@ -2,7 +2,11 @@
+   <%= link_to workshop do %>
+     <span class=""icon""></span>
+     <hgroup>
+-      <h5><%= t '.heading' %></h5>
++      <% if workshop.online? %>
++        <h5><%= t '.heading.online' %></h5>
++      <% else %>
++        <h5><%= t '.heading.in_person' %></h5>
++      <% end %>
+       <h4><%= workshop.name %></h4>
+     </hgroup>
+   <% end %>",Can the `h5` tags be pulled outside of the `if` block?,You forgot an `if` here
+7148,"@@ -2,6 +2,8 @@
+
+ namespace Shopsys\ShopBundle\Command;
+
++use Shopsys\ShopBundle\Component\Image\DirectoryStructureCreator as ImageDirectoryStructureCreator;
++use Shopsys\ShopBundle\Component\UploadedFile\DirectoryStructureCreator as UploadedFileDirectoryStructureCreator;
+ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+ use Symfony\Component\Console\Input\InputInterface;
+ use Symfony\Component\Console\Output\OutputInterface;",From @PetrHeinz review: this should be also aliased (`ImageDirectoryStructureCreator`),Do we really need the `as` part? I thought the metadata was already specified in the constructor.
+7149,"@@ -170,7 +170,7 @@ func (s *ClusterScope) AdditionalTags() infrav1.Tags {
+ 		s.AWSCluster.Spec.AdditionalTags = infrav1.Tags{}
+ 	}
+
+-	return s.AWSCluster.Spec.AdditionalTags
++	return infrav1.Tags(s.AWSCluster.Spec.AdditionalTags).DeepCopy()
+ }
+
+ // APIServerPort returns the APIServerPort to use when creating the load balancer.","Isn't AdditionalTags already of `Tags` type? If not, we should make it so, if it's not a breaking change",This looks unrelated to the rest of the PR.
+7150,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel
+ {
+     using System;",Add blank line below license header.,Please revert all the changes to this file.
+7151,"@@ -24,6 +24,7 @@ func init() {
+ 	initRTC()
+ 	initUARTClock()
+ 	initI2CClock()
++	initPWMClocks()
+
+ 	// connect to UART
+ 	machine.UART0.Configure(machine.UARTConfig{})",Perhaps this could be moved into `InitPWM`? I suspect not initializing the clocks will reduce power consumption.,"`initI2CClock` and `initPWMClocks` are already called in `initUART0`, can we consolidate them int"
+7152,"@@ -0,0 +1,9 @@
++class Quiz < ActiveRecord::Base
++  validates :title, presence: true
++
++  has_many :questions, -> { order(position: :asc) }, dependent: :destroy
++
++  def first_question
++    questions.first
++  end
++end",I believe this `order` isn't tested.,Rails/InverseOf: Specify an :inverse_of option.
+7153,"@@ -7,12 +7,13 @@
+ # include ""../../_Plugin_Helper.h""
+ # include ""../Helpers/ESPEasyStatistics.h""
+ # include ""../Static/WebStaticData.h""
+-HELPERS_ESPEASY_MATH_H
++//HELPERS_ESPEASY_MATH_H  //clumsy-stefan: what's this for?
++
++#ifdef WEBSERVER_METRICS
+ #ifdef ESP32
+ # include <esp_partition.h>
+ #endif // ifdef ESP32
+
+-
+ void handle_metrics() {
+     TXBuffer.startStream(F(""text/plain""), F(""*""));
+ ",No idea why it ended up in the code. You can remove the entire line.,why is this needed?
+7154,"@@ -146,9 +146,10 @@ func (n *NetworkPolicyController) processClusterNetworkPolicy(cnp *secv1alpha1.C
+ 			appliedToGroupNamesForRule = append(appliedToGroupNamesForRule, atGroup)
+ 			appliedToGroupNamesSet.Insert(atGroup)
+ 		}
++		iFromPeers := n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists)
+ 		rules = append(rules, controlplane.NetworkPolicyRule{
+ 			Direction:       controlplane.DirectionIn,
+-			From:            *n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists),
++			From:            iFromPeers,
+ 			Services:        services,
+ 			Action:          ingressRule.Action,
+ 			Priority:        int32(idx),","""i"" and ""From"" is a bit duplicate, and should it be singular given the method name? I mean ""fromPeer"" or just ""from""?",rename `From` to `FromPeers` or something more
+7155,"@@ -32,6 +32,7 @@ public class TestOAuth2AuthorizationRequests {
+ 		return OAuth2AuthorizationRequest.authorizationCode()
+ 				.authorizationUri(""https://example.com/login/oauth/authorize"")
+ 				.clientId(clientId)
++				.scope(""openid"")
+ 				.redirectUri(""https://example.com/authorize/oauth2/code/registration-id"")
+ 				.state(""state"")
+ 				.additionalParameters(additionalParameters);",Did you verify this isn't going to break any existing test assumptions? We probably shouldn't modify this as we don't know what impact this is having on existing tests. It may invalidate a test that has different expectations of the scopes.,This looks wrong. Why is it called `openid`?
+7156,"@@ -43,12 +43,16 @@ func (a *defaultAuthorizer) Authorize(_ context.Context, claims *Claims, target
+ 	if target.Namespace == ""temporal-system"" || target.Namespace == """" {
+ 		return Result{Decision: DecisionAllow}, nil
+ 	}
+-
++	if claims == nil {
++		return Result{Decision: DecisionDeny}, nil
++	}
+ 	// Check system level permissions
+ 	if claims.System == RoleAdmin || claims.System == RoleWriter {
+ 		return Result{Decision: DecisionAllow}, nil
+ 	}
+-
++	if claims.Namespaces == nil {
++		return Result{Decision: DecisionDeny}, nil
++	}
+ 	roles, found := claims.Namespaces[target.Namespace]
+ 	if !found || roles == RoleUndefined {
+ 		return Result{Decision: DecisionDeny}, nil","technically not necessary since reading from a nil dictionary will always return found = false, so this should already be handled",why decision if there is no namespaces?
+7157,"@@ -141,6 +141,9 @@ type StatsDriver interface {
+ 	// VolumeUsageByNode returns capacity usage of all volumes and snaps for a
+ 	// given node
+ 	VolumeUsageByNode(nodeID string) (*api.VolumeUsageByNode, error)
++	// RelaxedReclaimPurge triggers the purge of RelaxedReclaim queue for a
++	// given node
++	RelaxedReclaimPurge(nodeID string) (*api.RelaxedReclaimPurge, error)
+ }
+
+ type QuiesceDriver interface {","This can return bool. RelaxedReclaimPurge(nodeID string) (bool, error)",let's change this to `RelaxedReclaim`
+7158,"@@ -60,7 +60,7 @@ public class GeneralStateReferenceTestTools {
+     final String eips =
+         System.getProperty(
+             ""test.ethereum.state.eips"",
+-            ""Frontier,Homestead,EIP150,EIP158,Byzantium,Constantinople,ConstantinopleFix,Istanbul,Berlin"");
++            ""Frontier,Homestead,EIP150,EIP158,Byzantium,Constantinople,ConstantinopleFix,Istanbul,Berlin,London"");
+     EIPS_TO_RUN = Arrays.asList(eips.split("",""));
+   }
+ ","Is there something we can do to make this automatic? At the very least, can we add Shanghai, Cancun, etc. here now so that we don't forget them?","Technically, I don't think we need to r"
+7159,"@@ -129,7 +129,7 @@ def add_arguments_to_parser(parser):
+     parser.add_argument('--skip-db-cleanup',
+                         dest=""skip_db_cleanup"",
+                         action='store_true',
+-                        default=True,
++                        default=False,
+                         required=False,
+                         help=""Skip performing cleanup jobs on the database ""
+                              ""like removing unused files."")","For boolean values, I'd rather have `argparse.SUPPRESS` as default value. No need to have a `(default: False)` in the help if it's a toggle.","I might be missing something, but I don"
+7160,"@@ -251,6 +251,7 @@ func initSyncTest(t *testing.T, con consensus.Protocol, genFunc func(cst *hamt.C
+ 	chainStore := chain.NewStore(chainDS, cst, &state.TreeStateLoader{}, calcGenBlk.Cid())
+
+ 	fetcher := th.NewTestFetcher()
++	fetcher.AddSourceBlocks(calcGenBlk)
+ 	syncer := chain.NewSyncer(con, chainStore, fetcher, syncMode) // note we use same cst for on and offline for tests
+
+ 	// Initialize stores to contain dstP.genesis block and state","The genesis block needs to exist in the store the fetcher pulls from, this is because the fetcher will stop fetching when it finds a block it has seen before and this can sometimes be the genesis block.",why not add directly into the `fetcher`?
+7161,"@@ -1111,7 +1111,7 @@ func (c *linuxContainer) Checkpoint(criuOpts *CriuOpts) error {
+ 			return err
+ 		}
+
+-		err = ioutil.WriteFile(filepath.Join(criuOpts.ImagesDirectory, descriptorsFilename), fdsJSON, 0655)
++		err = ioutil.WriteFile(filepath.Join(criuOpts.ImagesDirectory, descriptorsFilename), fdsJSON, 0600)
+ 		if err != nil {
+ 			return err
+ 		}","should we do the same for os.Mkdir(criuOpts.WorkDirectory, 0755)?","Is this correct? 0655 should be 0616, ri"
+7162,"@@ -87,7 +87,8 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
+         .replace('<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML""', '<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML"" flattenhtml=""true""')
+         .replace(pageVisibility, bravePageVisibility + pageVisibility)
+         .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
+-        .replace(/Automatically sends usage statistics and crash reports to Brave/g, 'Automatically sends crash reports to Brave')
++        .replace(/Automatically send usage statistics and crash reports to Google/g, 'Automatically send crash reports to Google')
++        .replace(/Automatically sends usage statistics and crash reports to Google/g, 'Automatically sends crash reports to Google')
+         .replace(/The Chromium Authors/g, 'Brave Software Inc')
+         .replace(/Google Chrome/g, 'Brave')
+         .replace(/Chromium/g, 'Brave')",@bbondy Two messages because the label and description differ very slightly in their wording...,Just one clarification question: does it
+7163,"@@ -134,7 +134,10 @@ unit_test_get_ymm_caller_saved()
+     register __m256 ymm15 asm(""ymm15"");
+ #        endif
+
+-    for (int regno = 0; regno < proc_num_simd_registers(); ++regno) {
++    /* The function get_ymm_caller_saved is intended to be used for AVX (no AVX-512). It
++     * currently doesn't cover extended AVX-512 registers.
++     */
++    for (int regno = 0; regno < proc_num_simd_sse_avx_registers(); ++regno) {
+         for (int dword = 0; dword < sizeof(dr_ymm_t) / sizeof(uint); ++dword) {
+             get_buffer[regno].u32[dword] = 0;
+             ref_buffer[regno].u32[dword] = base++;","""currently"" implies it should and will be changed: so TODO i#?",This should be `for (size_t regno = 0; r
+7164,"@@ -1,8 +1,14 @@
+ import { translationMacro as t } from 'ember-i18n';
+ import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
++import Ember from 'ember';
++
++const { computed } = Ember;
++
+ export default AbstractIndexRoute.extend({
+   modelName: 'imaging',
+-  pageTitle: t('imaging.pageTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('imaging.pageTitle');
++  }),
+   searchStatus: 'Requested',
+
+   _getStartKeyFromItem(item) {",This should be `computed('i18n.locale'....`,Is there a reason for turning this into a computed property? I don't see any usages of this computed property.
+7165,"@@ -12,7 +12,6 @@ class CommitFlag::BackToLifeTest < ActiveSupport::TestCase
+     btl = CommitFlag::BackToLife.find(cf.id)
+     btl.time_elapsed = 123.0
+     btl.save!
+-    btl.reload
+     btl.time_elapsed.must_equal 123.0
+   end
+ end","Wait, does this not work if we do `btl.reload`? That seems odd that we have to have the object in the same state.",I would prefer to keep this line and remove the call to `btl.reload` (it shouldn't do anything with the `time_
+7166,"@@ -22,9 +22,7 @@ define(['playbackManager', 'focusManager', 'appRouter', 'dom'], function (playba
+
+     var eventListenerCount = 0;
+     function on(scope, fn) {
+-        if (eventListenerCount) {
+-            eventListenerCount++;
+-        }
++        eventListenerCount++;
+         dom.addEventListener(scope, 'command', fn, {});
+     }
+ ",I seem to recall this being the cause of a bug at some point.,Not sure why this check was there in the first place?
+7167,"@@ -1648,6 +1648,7 @@ public class LFMainActivity extends SharedMediaActivity {
+             menu.setGroupVisible(R.id.photos_option_men, false);
+             menu.findItem(R.id.all_photos).setVisible(!editMode && !hidden);
+             menu.findItem(R.id.search_action).setVisible(!editMode);
++            menu.findItem(R.id.settings).setVisible(false);
+
+             if (getAlbums().getSelectedCount() >= 1) {
+                 if (getAlbums().getSelectedCount() > 1) {",Can you remove it from the menu instead of setting it hidden? Or are there any other trouble?,Wouldn't it make sense to show the settings menu only if the albums are selected? That way we won't hide them
+7168,"@@ -32,6 +32,7 @@ import (
+ 	reflect ""reflect""
+
+ 	gomock ""github.com/golang/mock/gomock""
++	execution ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	persistence ""github.com/temporalio/temporal/common/persistence""
+ )
+ ","And for ""execution "".",Did you mean to add this import?
+7169,"@@ -34,6 +34,8 @@ module Bolt
+           search_dirs << mod.plugins if mod.plugins?
+           search_dirs << mod.pluginfacts if mod.pluginfacts?
+           search_dirs << mod.files if mod.files?
++          type_files = ""#{mod.path}/types""
++          search_dirs << type_files if File.exist?(type_files)
+           search_dirs
+         end
+       end",Do agents usually download these from puppetserver when applying a catalog?,"If `mod.path` doesn't exist, thi"
+7170,"@@ -68,6 +68,14 @@ PONY_API int pony_asio_event_fd(asio_event_t* ev)
+   return ev->fd;
+ }
+
++PONY_API bool pony_asio_event_get_disposable(asio_event_t* ev)
++{
++  if(ev == NULL)
++    return false;
++
++  return (ev->flags & ASIO_DISPOSABLE) != 0;
++}
++
+ PONY_API bool pony_asio_event_get_writeable(asio_event_t* ev)
+ {
+   if(ev == NULL)",This should be `return (ev->flags == ASIO_DISPOSABLE);` because `ASIO_DISPOSABLE` has a value of `0` as defined in the enum in `asio.h` and because when `ev->flags` is assigned `ASIO_DISPOSABLE` it is assigned as `ev->flags = ASIO_DISPOSABLE` unsetting any other flags previously assigned.,AFAIK this function is not used
+7171,"@@ -68,7 +68,8 @@ namespace Examples.Console
+                 providerBuilder
+                     .AddOtlpExporter(o =>
+                     {
+-                        o.MetricExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
++                        o.MetricReaderType = MetricReaderType.Periodic;
++                        o.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
+                         o.AggregationTemporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
+                     });
+             }","this is not required, right? its the default already...",Shouldn't this be `MetricReaderT
+7172,"@@ -49,6 +49,11 @@ const (
+ 	// to indicate that a reader has requested to read a TLF ID that
+ 	// has been finalized, which isn't allowed.
+ 	StatusCodeServerErrorCannotReadFinalizedTLF = 2812
++	// StatusCodeServerErrorRequiredLockIsNotHeld is the error code returned by
++	// a MD write operation to indicate that a lockID that client required the
++	// write to be contingent to is not held at the time server tries to commit
++	// the MD, and as a result the MD is not written.
++	StatusCodeServerErrorRequiredLockIsNotHeld = 2813
+ )
+
+ // ServerError is a generic server-side error.","""contingent to"" -> ""contingent on""","I'm not sure if this is the best error code, but I think `StatusCodeServerErrorRequiredLockIsNotHeld is the error code returned by a MD write operation to indicate that a required lock is not held at the time the server tries to commit the MD."
+7173,"@@ -19,6 +19,14 @@ Exceptions/Errors used in Koalas.
+ """"""
+
+
++class GroupByError(Exception):
++    pass
++
++
++class DataError(GroupByError):
++    pass
++
++
+ class SparkPandasIndexingError(Exception):
+     pass
+ ",Does pandas throw an exception like this?,Please add a docstring.
+7174,"@@ -538,14 +538,14 @@ cvdescriptorset::AllocateDescriptorSetsData::AllocateDescriptorSetsData(uint32_t
+
+ cvdescriptorset::DescriptorSet::DescriptorSet(const VkDescriptorSet set, const VkDescriptorPool pool,
+                                               const std::shared_ptr<DescriptorSetLayout const> &layout, uint32_t variable_count,
+-                                              CoreChecks *dev_data)
++                                              cvdescriptorset::DescriptorSet::StateTracker *state_data)
+     : some_update_(false),
+       set_(set),
+       pool_state_(nullptr),
+       p_layout_(layout),
+-      device_data_(dev_data),
++      state_data_(state_data),
+       variable_count_(variable_count) {
+-    pool_state_ = dev_data->GetDescriptorPoolState(pool);
++    pool_state_ = state_data->GetDescriptorPoolState(pool);
+     // Foreach binding, create default descriptors of given type
+     descriptors_.reserve(p_layout_->GetTotalDescriptorCount());
+     for (uint32_t i = 0; i < p_layout_->GetBindingCount(); ++i) {",The point of the exercise has been to eliminate CoreChecks as an object dependency for DescriptorSet et. al.,Please remove the device_data_() member from the constructor. It's not needed anymore.
+7175,"@@ -34,7 +34,7 @@ import static org.apache.iceberg.TableProperties.DEFAULT_NAME_MAPPING;
+ /**
+  * Context object with optional arguments for a Flink Scan.
+  */
+-class ScanContext implements Serializable {
++public class ScanContext implements Serializable {
+
+   private static final long serialVersionUID = 1L;
+ ",Why do we need to make so much more of this ScanContext public?,This class should not be serialized.
+7176,"@@ -54,7 +54,6 @@ class ProductFilterFormType extends AbstractType
+                 'choices' => $config->getFlagChoices(),
+                 'choice_label' => 'name',
+                 'choice_value' => 'id',
+-                'choice_name' => 'id',
+                 'multiple' => true,
+                 'expanded' => true,
+             ])",is choice_name not needed anymore?,Why has this been removed?
+7177,"@@ -226,6 +226,9 @@ public class Parquet {
+       set(""parquet.avro.write-old-list-structure"", ""false"");
+       MessageType type = ParquetSchemaUtil.convert(schema, name);
+
++      // Check that our metrics make sense
++      metricsConfig.validateProperties(schema);
++
+       if (createWriterFunc != null) {
+         Preconditions.checkArgument(writeSupport == null,
+             ""Cannot write with both write support and Parquet value writer"");","Is this the right place to do the validation? If a user adds a bad property or performs some schema update that causes a validation error, that would break all writes to the table. To me, it doesn't seem like we are catching the problem early enough and possibly allowing a typo to break scheduled jobs. What do you think about adding this validation when altering the table? `UpdateProperties` could check whether any properties starting with `write.metadata.metrics` were modified and run this. Similarly, `UpdateSchema` could run this as well, although I think that we should probably modify `UpdateSchema` to simply update the properties for column renames (if that's easily done).",Would it make sense to val
+7178,"@@ -2467,11 +2467,17 @@ hipError_t hipHccGetAcceleratorView(hipStream_t stream, hc::accelerator_view** a
+ namespace hip_impl {
+     std::vector<hsa_agent_t> all_hsa_agents() {
+         std::vector<hsa_agent_t> r{};
+-        for (auto&& acc : hc::accelerator::get_all()) {
++        auto accelerators = hc::accelerator::get_all();
++        for (int i = 0; i < accelerators.size(); i++) {
++            auto&& acc = accelerators[i];
+             const auto agent = acc.get_hsa_agent();
+
+             if (!agent || !acc.is_hsa_accelerator()) continue;
+
++            // If device is not in visible devices list, ignore
++            if (std::find(g_hip_visible_devices.begin(), g_hip_visible_devices.end(), (i - 1)) ==
++                    g_hip_visible_devices.end()) continue;
++
+             r.emplace_back(*static_cast<hsa_agent_t*>(agent));
+         }
+ ",Why is this necessary? Just in order to get an indexed loop?,why not just `for (auto& a
+7179,"@@ -68,6 +68,7 @@ type poolSyncMetrics struct {
+ 	zpoolLastSyncTime             *prometheus.GaugeVec
+ 	zpoolStateUnknown             *prometheus.GaugeVec
+ 	zpoolLastSyncTimeCommandError *prometheus.GaugeVec
++	zpoolListRequestRejectCounter prometheus.Gauge
+ }
+
+ // poolfields struct is for pool last sync time metric","instead of using `prometheus.Gauge`, using `promethus.Counter` will be better.",I would suggest to rename
+7180,"@@ -23,5 +23,9 @@ module Ncr
+     def whsc?
+       code == WHSC_CODE
+     end
++
++    def ba_6x_tier1_team?
++      code.match(/^P11[7J4T1ACZ]....$/)
++    end
+   end
+ end",maybe we should have a unit test for this and then just test one case in `spec/services/ncr/approval_manager_spec.rb` ?,Maybe `code.match?(/^P11[7J4T1ACZ].*$/)` is better?
+7181,"@@ -21,8 +21,9 @@ class CommunicartsController < ApplicationController
+   def approval_response
+     cart = Cart.find(params[:cart_id]).decorate
+     client_data = cart.proposal.client_data_legacy
+-    approval = cart.approvals.find_by(user_id: user_id)
+-
++    approval = cart.approvals.find_by(user_id: user_id)
++    @token ||= ApiToken.find_by(approval_id: approval.id)
++
+     if !approval.pending?
+       flash[:error] = ""You have already logged a response for Cart #{client_data.public_identifier}""
+     else",Why is this necessary?,Why is this here and not in `before_action`?
+7182,"@@ -320,7 +320,7 @@ public class Spark3Util {
+     }
+   }
+
+-  private static DistributionMode getDistributionMode(org.apache.iceberg.Table table) {
++  public static DistributionMode getDistributionMode(org.apache.iceberg.Table table) {
+     boolean isSortedTable = !table.sortOrder().isUnsorted();
+     String defaultModeName = isSortedTable ? WRITE_DISTRIBUTION_MODE_RANGE : WRITE_DISTRIBUTION_MODE_DEFAULT;
+     String modeName = table.properties().getOrDefault(WRITE_DISTRIBUTION_MODE, defaultModeName);","Minor: If this is going to be public, we should fix the name. `get` doesn't add any value. How about `distributionModeFor` instead?",this method doesn't seem to be used anywhere. can w
+7183,"@@ -16,7 +16,10 @@ from mitmproxy.tools.console import eventlog
+
+
+ class StackWidget(urwid.Frame):
+-    def __init__(self, widget, title, focus):
++    def __init__(self, window, widget, title, focus):
++        self.f = focus
++        self.window = window
++
+         if title:
+             header = urwid.AttrWrap(
+                 urwid.Text(title),",This needs a more self-explaining name. Maybe `.is_focused`?,Can you add a `__init__` to ensure that `focus` is
+7184,"@@ -174,11 +174,17 @@ var rubyAzureMappings = {
+   'parameter_grouping':['../../dev/TestServer/swagger/azure-parameter-grouping.json', 'ParameterGroupingModule']
+ };
+
++var goAzureMappings = {
++  'paging':['../../dev/TestServer/swagger/paging.json','paginggroup'],
++  'azurereport':['../../dev/TestServer/swagger/azure-report.json', 'azurereport']
++};
++
+ gulp.task('regenerate:expected', function(cb){
+   runSequence('regenerate:delete',
+     [
+-      'regenerate:expected:csazure',
+       'regenerate:expected:cs',
++      'regenerate:expected:csazure',
++      'regenerate:expected:csazurefluent',
+       'regenerate:expected:node',
+       'regenerate:expected:nodeazure',
+       'regenerate:expected:ruby',","minor: I'd add a space between `,` & `'paginggroup'`.",This test case needs to be renamed as well.
+7185,"@@ -42,10 +42,8 @@ def main():
+
+     push_p = subparsers.add_parser(""push"")
+     push_p.add_argument(""package"", type=str, help=""Owner/Package Name"")
+-    push_p.set_defaults(func=command.push)
+-
+-    push_p = subparsers.add_parser(""push"")
+-    push_p.add_argument(""package"", type=str, help=""Owner/Package Name"")
++    push_p.add_argument(""--reupload"", action=""store_true"",
++                        help=""Re-upload all fragments, even the ones the server already has"")
+     push_p.set_defaults(func=command.push)
+
+     version_p = subparsers.add_parser(""version"")","""Re-upload all fragments (even if fragment is already in registry)""",This doesn't take into account the fact tha
+7186,"@@ -813,11 +813,15 @@ type PrometheusRuleSpec struct {
+ // upstream Prometheus struct definitions don't have json struct tags.
+
+ // RuleGroup is a list of sequentially evaluated recording and alerting rules.
++// Note: PartialResponseStrategy is only used by ThanosRuler and will
++// be ignored by Prometheus instances.  Valid values for this field are 'warn'
++// or 'abort'.  More info: https://github.com/thanos-io/thanos/blob/master/docs/components/rule.md#partial-response
+ // +k8s:openapi-gen=true
+ type RuleGroup struct {
+-	Name     string `json:""name""`
+-	Interval string `json:""interval,omitempty""`
+-	Rules    []Rule `json:""rules""`
++	Name                    string `json:""name""`
++	Interval                string `json:""interval,omitempty""`
++	Rules                   []Rule `json:""rules""`
++	PartialResponseStrategy string `json:""partial_response_strategy,omitempty""`
+ }
+
+ // Rule describes an alerting or recording rule.",I don't see us ignoring the field. Are we sure Prometheus wouldn't refuse to load the rules?,`PartialResponseStrategy` is only used by T
+7187,"@@ -314,7 +314,7 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
+         super.onResume();
+         if (isVisible() || mIsInVRVideoMode) {
+             mSession.setActive(true);
+-            if (!SettingsStore.getInstance(getContext()).getLayersEnabled()) {
++            if (!SettingsStore.getInstance(getContext()).getLayersEnabled() && !mSession.hasDisplay()) {
+                 // Ensure the Gecko Display is correctly recreated.
+                 // See: https://github.com/MozillaReality/FirefoxReality/issues/2880
+                 callSurfaceChanged();",I wonder if we can just check if the mSession is active and then only call `setActive(true)` and `callSurfaceChanged()` if it isn't?,Can you explain why this change is needed?
+7188,"@@ -1336,6 +1336,8 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		""OFF""),
+
+  SDDui___(EXE_MEMORY_FOR_PROBE_CACHE_IN_MB,	""100""),
+
++ SDDui___(EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB,	""100""),
++
+   // lower-bound memory limit for BMOs/nbmos (in MB)
+   DDui___(EXE_MEMORY_LIMIT_LOWER_BOUND_EXCHANGE, ""10""),
+   DDui___(EXE_MEMORY_LIMIT_LOWER_BOUND_MERGEJOIN, ""10""),","A default value of 100 MB maybe too small. I understand that this is good for mixed workloads, but do consider than plans with Unpack, especially when used for insert/upsert are simple. Unpack is always serial and part of master exe. Often there is only one in a query. The cost of having a low value here seems to be that queue length from unpack could be limited by this when we are loading a table with wide rows (even if actual data in row is not wide). We know from performance runs that queue length is critical to upsert load performance. This is a hunch on my part and could be misguided. It will be good to performance test for upsert of table with wide rows, if you think that is worthwhile.",(style) line over 80 characters
+7189,"@@ -32,8 +32,8 @@ type (
+ 		GetByOwner(address.Address) *Candidate
+ 		GetBySelfStakingIndex(uint64) *Candidate
+ 		Upsert(*Candidate) error
+-		CreditBucketPool(*big.Int, bool) error
+-		DebitBucketPool(*big.Int, bool, bool) error
++		CreditBucketPool(*big.Int) error
++		DebitBucketPool(*big.Int, bool) error
+ 		Commit() error
+ 	}
+ ","think we should pass in ctx, and use ctx.GreenlandHeight inside bucketPool to determine if create or not",`CreditBucketPool` and `DebitBu
+7190,"@@ -153,7 +153,7 @@ public class I18nTest extends JUnit4TestBase {
+     assertThat(ime.isActivated()).isTrue();
+     assertThat(ime.getActiveEngine()).isEqualTo(desiredEngine);
+
+-    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to convert the word.
++    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to transform the word.
+     input.sendKeys(""toukyou "");
+     input.sendKeys(Keys.ENTER);
+ ",A correct by unrelated change. We'll slide this one in without another word ;),It's correct to change this to
+7191,"@@ -1,5 +1,4 @@
+ <%= semantic_form_for checkout, url: checkouts_path(checkout.plan), html: { method: 'post' } do |form| %>
+-  <%= form.semantic_errors %>
+
+   <%= form.inputs do %>
+     <% if signed_out? %>",Why remove this?,Should we remove this file as w
+7192,"@@ -11,7 +11,7 @@ use Shopsys\FrameworkBundle\Component\Router\Security\RouteCsrfProtector;
+ use Symfony\Component\HttpFoundation\Request;
+ use Symfony\Component\HttpFoundation\RequestStack;
+ use Symfony\Component\Routing\Router;
+-use Twig_Environment;
++use Twig\Environment;
+
+ class GridTest extends TestCase
+ {","I still see some usages of not namespaced variants (look for Twig_ in project, about 42 matches). Is it intentional?",Shouldn't be `Twig\Environment` (not `Twig_Environment`)?
+7193,"@@ -22,11 +22,11 @@ import (
+ 	""sync""
+ 	""time""
+
+-	""github.com/aws/amazon-ecs-agent/agent/api""
+ 	""github.com/aws/amazon-ecs-agent/agent/resources/cgroup""
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ioutilwrapper""
+ 	""github.com/cihub/seelog""
+ 	""github.com/containerd/cgroups""
++	specs ""github.com/opencontainers/runtime-spec/specs-go""
+ 	""github.com/pkg/errors""
+ )
+ ",Is this a new dependency? Does this require a dep update?,Why is this being removed?
+7194,"@@ -62,6 +62,8 @@ bool Print(T val, Type type, int /*indent*/, Type * /*union_type*/,
+
+   if (type.base_type == BASE_TYPE_BOOL) {
+     text += val != 0 ? ""true"" : ""false"";
++  } else if (opts.generate_hexfloat_in_json && (type.base_type == BASE_TYPE_FLOAT || type.base_type == BASE_TYPE_DOUBLE)) {
++    text += FloatToStringtStringHex(val);
+   } else {
+     text += NumToString(val);
+   }",> opts.generate_hexfloat_in_json && **IsFloat**(type.base_type),Should probably check `opts.generate_hexfloat_in_json`
+7195,"@@ -7,4 +7,5 @@ package archer
+ type Manifest interface {
+ 	Marshal() ([]byte, error)
+ 	DockerfilePath() string
++	AppName() string
+ }","As an alternative to this, we could also create a new method, like `Common() *AppManifest` This way we don't have to add a new method to the interface everytime we add a new field to the `AppManifest`. This is a nit though so it's up to you.","If this is only used in the tests, should we move it to a"
+7196,"@@ -28,6 +28,7 @@ script_deps = {
+         ""urwid>=1.1"",
+         ""lxml>=3.3.6"",
+         ""Pillow>=2.3.0"",
++        ""harparser"",
+     },
+     ""mitmdump"": set()
+ }","As long as we have this feature as an inline script, I'm inclined to remove the dependency here. I'd suggest that we just try to import harparser and pytz and throw an error instructing the user to install the dependencies (catch for `ImportError`). In the long term, we probably want to include that in the mitmproxy core, but we first want to introduce a clean extension interface before that's going to happen. As soon as said interface is there, porting the inline script and adding the dependency again should be a breeze.",perhaps we should be more specific here and say `lxml>=1.2.6`?
+7197,"@@ -0,0 +1,4 @@
++// set the base folder of this project
++global.basefolder = `${__dirname}`
++require (""rechoir"").prepare(require('interpret').extensions, './.gulp/gulpfile.iced');
++require ('./.gulp/gulpfile.iced')",makes it work nice with vscode. all logic is now in `.gulp/*.iced` files,Can you explain why this is needed? I am not familiar with it.
+7198,"@@ -27,7 +27,7 @@ public interface SearchContext {
+    * @return A list of all {@link WebElement}s, or an empty list if nothing matches
+    * @see org.openqa.selenium.By
+    */
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",should a similar change be done for findElement?,"Unrelated to this PR, but shouldn't this return a `List<WebEle"
+7199,"@@ -2745,7 +2745,7 @@ TEST (node, local_votes_cache)
+ 	{
+ 		ASSERT_NO_ERROR (system.poll (node.aggregator.max_delay));
+ 	}
+-	ASSERT_TIMELY (3s, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes) == 3);
++	ASSERT_TIMELY (3s, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes)+node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_cached_late_votes) == 3);
+ 	ASSERT_FALSE (node.history.votes (send1->root (), send1->hash ()).empty ());
+ 	ASSERT_FALSE (node.history.votes (send2->root (), send2->hash ()).empty ());
+ 	ASSERT_FALSE (node.history.votes (send3->root (), send3->hash ()).empty ());",`+` -> ` + ` I guess. Same below,"`stats.count (nano::stat::type::requests, nano::stat::detail::"
+7200,"@@ -109,9 +109,8 @@ function TransactionBuilder(opts) {
+   this.lockTime = opts.lockTime || 0;
+   this.spendUnconfirmed = opts.spendUnconfirmed || false;
+
+-  if (opts.fee || opts.feeSat) {
+-    this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
+-  }
++  this.givenFeeSat = typeof(opts.fee) !== 'undefined' ? opts.fee * util.COIN : opts.feeSat;
++
+   this.remainderOut = opts.remainderOut;
+   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
+ ","`typeof` is not a function - its an operator, and the standard way to use it is as `typeof foo !== ...` (i.e. no parenthesis). Also, I would personally use `opts.fee != null` instead (with a non-strict comparison, which also identifies `undefined` values because `null == undefined`).",why not `opts.fee * util.COIN` ?
+7201,"@@ -855,6 +855,7 @@ class ReaderTest < Minitest::Test
+       end
+
+       test 'unreadable file referenced by include directive is replaced by warning' do
++        next if windows? # JRuby on Windows runs this even with the conditional on the block
+         include_file = File.join DIRNAME, 'fixtures', 'chapter-a.adoc'
+         FileUtils.chmod 0000, include_file
+         input = <<~'EOS'",Is there a reason why you're not using Rspec `skip`? It allows to specify message and makes it clearly visible in test results which tests were skipped.,I'm not sure if this is the best
+7202,"@@ -36,6 +36,10 @@ type ClusterSyncStatus struct {
+ 	// Conditions is a list of conditions associated with syncing to the cluster.
+ 	// +optional
+ 	Conditions []ClusterSyncCondition `json:""conditions,omitempty""`
++
++	// FirstSyncSetsSuccessTime is the time we first successfully applied all (selector)syncsets to a cluster.
++	// +optional
++	FirstSyncSetsSuccessTime *metav1.Time `json:""firstSyncSetsSuccessTime,omitempty""`
+ }
+
+ // SyncStatus is the status of applying a specific SyncSet or SelectorSyncSet to the cluster.","how about ""all matching SyncSets and SelectorSyncSets""",This field should be added to th
+7203,"@@ -331,7 +331,7 @@ void Storage::PopulateLayout(DataLayout &layout)
+
+     // load geometries sizes
+     {
+-        io::FileReader reader(config.geometries_path, io::FileReader::HasNoFingerprint);
++        io::FileReader reader(config.geometries_path, io::FileReader::VerifyFingerprint);
+
+         const auto number_of_geometries_indices = reader.ReadVectorSize<unsigned>();
+         layout.SetBlockSize<unsigned>(DataLayout::GEOMETRIES_INDEX, number_of_geometries_indices);","What is the logic behind `ReadVectorSize` reading `CountElement64`, then skipping `T` (in this case `unsigned`)? Naming doesn't cover what's actually happening here. Ideally I'd also take this through a `files` layer, any input as to how?",Why not just have the reader cal
+7204,"@@ -24,6 +24,7 @@ import org.apache.solr.common.params.CommonParams;
+ import org.apache.solr.core.CoreContainer;
+ import org.apache.solr.core.SolrCore;
+
++import javax.servlet.ServletException;
+ import javax.servlet.http.HttpServletRequest;
+ import javax.servlet.http.HttpServletResponse;
+ ",This looks like an unused import to me?,Shouldn't this be `import org.apache.http.HttpServletResponse;`?
+7205,"@@ -231,13 +231,13 @@ func taskListInfoFromBlob(b []byte, proto string) (*sqlblobs.TaskListInfo, error
+ 	return result, thriftRWDecode(b, proto, result)
+ }
+
+-func transferTaskInfoToBlob(info *sqlblobs.TransferTaskInfo) (p.DataBlob, error) {
+-	return thriftRWEncode(info)
++func TransferTaskInfoToBlob(info *persistenceblobs.TransferTaskInfo) (p.DataBlob, error) {
++	return protoRWEncode(info)
+ }
+
+-func transferTaskInfoFromBlob(b []byte, proto string) (*sqlblobs.TransferTaskInfo, error) {
+-	result := &sqlblobs.TransferTaskInfo{}
+-	return result, thriftRWDecode(b, proto, result)
++func TransferTaskInfoFromBlob(b []byte, proto string) (*persistenceblobs.TransferTaskInfo, error) {
++	result := &persistenceblobs.TransferTaskInfo{}
++	return result, protoRWDecode(b, proto, result)
+ }
+
+ func TimerTaskInfoToBlob(info *persistenceblobs.TimerTaskInfo) (p.DataBlob, error) {","`RW` means read/write. Why do we have it here, as part of a func name?",Why did we remove the thriftRWEncode?
+7206,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...,This should not be part of this PR
+7207,"@@ -1051,7 +1051,11 @@ static ssize_t expect_preface(h2o_http2_conn_t *conn, const uint8_t *src, size_t
+     }
+
+     { /* send SETTINGS and connection-level WINDOW_UPDATE */
+-        h2o_iovec_t vec = h2o_buffer_reserve(&conn->_write.buf, SERVER_PREFACE.len);
++        h2o_iovec_t vec = h2o_buffer_try_reserve(&conn->_write.buf, SERVER_PREFACE.len);
++        if (vec.base == NULL) {
++            *err_desc = ""failed to allocate memory"";
++            return H2O_HTTP2_ERROR_PROTOCOL_CLOSE_IMMEDIATELY;
++        }
+         memcpy(vec.base, SERVER_PREFACE.base, SERVER_PREFACE.len);
+         conn->_write.buf->size += SERVER_PREFACE.len;
+         if (conn->http2_origin_frame) {",I think you missed this.,shouldn't this be `H2O_HTTP2_ERROR_PROTOCOL_CLOSE_IMMEDIATELY` ?
+7208,"@@ -145,6 +145,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             return _requestStream.ReadAsync(buffer, offset, count, cancellationToken);
+         }
+
++#if NETCOREAPP2_1
++        public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)
++        {
++            return _requestStream.ReadAsync(destination, cancellationToken);
++        }
++#endif
++
+         public override Task CopyToAsync(Stream destination, int bufferSize, CancellationToken cancellationToken)
+         {
+             return _requestStream.CopyToAsync(destination, bufferSize, cancellationToken);",List all of the current TFMs so we know if this gets outdated. E.g. this breaks if we add 2.2.,"Similarly here, I would just make `CancellationToken` the same as above. We don't really need to special-case `default` here."
+7209,"@@ -811,6 +811,12 @@ func (s *VolumeServer) mergeVolumeSpecs(vol *api.VolumeSpec, req *api.VolumeSpec
+ 		spec.ExportSpec = vol.GetExportSpec()
+ 	}
+
++	// Xattr
++	if req.GetXattr() >= 0 {
++		spec.Xattr = req.GetXattr()
++	} else {
++		spec.Xattr = vol.GetXattr()
++	}
+ 	return spec
+ }
+ ","here, you want to use req.GetXattrOpt() referring to the in line 514 of api.proto. This will be nil if not provided. See the example above on line 801 on this file",can this be `req.GetXattr() > 0`?
+7210,"@@ -952,7 +952,14 @@ public class LocalPSMP extends PlaybackServiceMediaPlayer {
+                 // Load next episode if previous episode was in the queue and if there
+                 // is an episode in the queue left.
+                 // Start playback immediately if continuous playback is enabled
+-                nextMedia = callback.getNextInQueue(currentMedia);
++
++                // Repeat episode implementation
++                if (UserPreferences.repeatEpisode() && !wasSkipped) {
++                    nextMedia = currentMedia;
++                    nextMedia.setPosition(0);
++                } else {
++                    nextMedia = callback.getNextInQueue(currentMedia);
++                }
+
+                 boolean playNextEpisode = isPlaying &&
+                         nextMedia != null &&","I think this should be done outside LocalPSMP, but in `getNextInQueue`. The reason is that I want to reduce the dependence of the media players on the preferences and database. Also, it will then probably work on Chromecast.",I would like to see a unit test for this to ensure we are not breaking anything.
+7211,"@@ -143,7 +143,9 @@ struct _hiprtcProgram {
+     {
+         using namespace std;
+
+-        name = hip_impl::demangle(name.c_str());
++        char* demangled = hip_impl::demangle(name.c_str());
++        name.assign(demangled == nullptr ? """" : demangled);
++        free(demangled);
+
+         if (name.empty()) return name;
+ ",Please remove it or remove all `std::` namespace prefixes.,This should be moved to the common header.
+7212,"@@ -0,0 +1,17 @@
++// Copyright (C) 2019-2020 Algorand, Inc.
++// This file is part of go-algorand
++//
++// go-algorand is free software: you can redistribute it and/or modify
++// it under the terms of the GNU Affero General Public License as
++// published by the Free Software Foundation, either version 3 of the
++// License, or (at your option) any later version.
++//
++// go-algorand is distributed in the hope that it will be useful,
++// but WITHOUT ANY WARRANTY; without even the implied warranty of
++// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++// GNU Affero General Public License for more details.
++//
++// You should have received a copy of the GNU Affero General Public License
++// along with go-algorand.  If not, see <https://www.gnu.org/licenses/>.
++
++package nodecontrol",wait! I'm confused - is that an empty file ?!,The license header on this file is wrong.
+7213,"@@ -19,14 +19,14 @@ var phrasingElements = ['A', 'EM', 'STRONG', 'SMALL', 'MARK', 'ABBR', 'DFN', 'I'
+  * @param {HTMLElement} element The HTMLElement
+  * @return {HTMLElement} The label element, or null if none is found
+  */
+-function findLabel({ actualNode }) {
++function findLabel(virtualNode) {
+ 	let label;
+-	if (actualNode.id) {
++	if (virtualNode.actualNode.id) {
+ 		label = dom.findElmsInContext({
+-			elm: 'label', attr: 'for', value: actualNode.id, context: actualNode
++			elm: 'label', attr: 'for', value: virtualNode.actualNode.id, context: virtualNode.actualNode
+ 		})[0];
+ 	} else {
+-		label = dom.findUp(actualNode, 'label');
++		label = dom.findUpVirtual(virtualNode, 'label');
+ 	}
+ 	return axe.utils.getNodeFromTree(axe._tree[0], label);
+ }",These should all call `findUpVirtual`.,`findUpVirtual` will return `null` if non
+7214,"@@ -105,7 +105,7 @@ class HierarchicHTTPRequest(HTTPRequest):
+             file_dict[""path""] = path
+
+             mime = mimetypes.guess_type(file_dict[""path""])[0] or ""application/octet-stream""
+-            file_dict.get('mime-type', mime)
++            file_dict[""mime-type""] = mime
+         self.content_encoding = self.config.get('content-encoding', None)
+
+ ","This changes the behavior. Original behavior was ""set if not set"", while new is ""just set"".","`file_dict.get('mime-type', mime)` is the"
+7215,"@@ -110,7 +110,7 @@ public final class DefaultBearerTokenResolver implements BearerTokenResolver {
+ 				throw new OAuth2AuthenticationException(error);
+ 			}
+
+-			return matcher.group(""token"");
++			return authorization.substring(7);
+ 		}
+ 		return null;
+ 	}",Let's keep using the regular expression to make sure that the token is well-formed. I think the regular expression should be altered instead of doing a substring.,Can you explain this change?
+7216,"@@ -26,10 +26,10 @@ public final class Array<T> implements Kind1<Array<?>, T>, IndexedSeq<T>, Serial
+
+     private static final Array<?> EMPTY = new Array<>(new Object[0]);
+
+-    private final Object[] back;
++    private final Object[] delegate;
+
+-    private Array(Object[] back) {
+-        this.back = back;
++    private Array(Object[] delegate) {
++        this.delegate = delegate;
+     }
+
+     static <T> Array<T> wrap(Object[] array) {","All the operations are delegated to this entity, hence the rename. `back` can have too many meanings.",I think this should be `delegate = new Object[0];`
+7217,"@@ -561,16 +561,9 @@ module Beaker
+
+       block_on host do |host|
+         skip_msg = host.skip_set_env?
+-        if skip_msg.nil?
+-          env = construct_env(host, opts)
+-          logger.debug(""setting local environment on #{host.name}"")
+-          if host['platform'] =~ /windows/ and host.is_cygwin?
+-            env['CYGWIN'] = 'nodosfilewarning'
+-          end
+-          host.ssh_permit_user_environment
+-          host.ssh_set_user_environment(env)
+-        else
+-          logger.debug(skip_msg)
++        unless skip_msg.nil?
++            logger.debug( skip_msg )
++            next
+         end
+
+         if skip_msg.nil?","@trevor-vaughan it looks like the spec failures are caused by the fact that although it was a great idea to put the guard clause here first & get the error case out of the way, the main code path has been erased when I assume it should be just below the guard clause.",Won't this block forever if `skip_msg` is `nil`? W
+7218,"@@ -22,6 +22,7 @@ import (
+ 	""github.com/algorand/go-algorand/config""
+ 	""github.com/algorand/go-algorand/data/basics""
+ 	""github.com/algorand/go-algorand/logging""
++	""github.com/algorand/go-algorand/protocol""
+ )
+
+ var filterTimeout = 2 * config.Protocol.SmallLambda",Could you delete this constant?,why is this moved?
+7219,"@@ -2,6 +2,7 @@
+ // The .NET Foundation licenses this file to you under the MIT license.
+ // See the LICENSE file in the project root for more information.
+
++using BenchmarkDotNet.Disassemblers;
+ using BenchmarkDotNet.Exporters;
+ using BenchmarkDotNet.Loggers;
+ using BenchmarkDotNet.Parameters;",looks like this snuck in from your other change?,Do we need this?
+7220,"@@ -10,11 +10,6 @@ module Ncr
+   BUILDING_NUMBERS = YAML.load_file(""#{Rails.root}/config/data/ncr/building_numbers.yml"")
+
+   class WorkOrder < ActiveRecord::Base
+-      NCR_BA61_TIER1_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA61_TIER1_BUDGET_MAILBOX'] || 'communicart.budget.approver+ba61@gmail.com'
+-      NCR_BA61_TIER2_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA61_TIER2_BUDGET_MAILBOX'] || 'communicart.ofm.approver@gmail.com'
+-      NCR_BA80_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA80_BUDGET_MAILBOX'] || 'communicart.budget.approver+ba80@gmail.com'
+-      OOL_BA80_BUDGET_APPROVER_MAILBOX = ENV['NCR_OOL_BA80_BUDGET_MAILBOX'] || 'communicart.budget.approver+ool_ba80@gmail.com'
+-
+     # must define before include PurchaseCardMixin
+     def self.purchase_amount_column_name
+       :amount","These env vars are not set in any CF environment, on purpose, because we are moving away from using env vars to store role-based information and instead using the database. So in a CF environment, the wrong emails get used (the defaults, rather than what is in the db).",Line is too long. [83/80]
+7221,"@@ -1,4 +1,4 @@
+-<%# locals: { question, answer, readonly, locking } %>
++<%# locals: { template, question, answer, readonly, locking } %>
+ <!--
+   This partial creates a form for each type of question. The local variables are: plan, answer, question, readonly
+ -->","this partial is used also for previewing a template, did you test if still works?",I took the liberty to cha
+7222,"@@ -22,6 +22,19 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+
++var (
++	appInitAppTypePrompt     = ""Which type of "" + color.Emphasize(""infrastructure pattern"") + "" best represents your application?""
++	appInitAppTypeHelpPrompt = `Your application's architecture. Most applications need additional AWS resources to run.
++To help setup the infrastructure resources, select what ""kind"" or ""type"" of application you want to build.`
++
++	fmtAppInitAppNamePrompt     = ""What do you want to "" + color.Emphasize(""name"") + "" this %s?""
++	fmtAppInitAppNameHelpPrompt = `The name will uniquely identify this application within your %s project.
++Deployed resources (such as your service, logs) will contain this app's name and be tagged with it.`
++
++	fmtAppInitDockerfilePrompt  = ""Which Dockerfile would you like to use for %s app?""
++	appInitDockerfileHelpPrompt = ""Dockerfile to use for building your application's container image.""
++)
++
+ const (
+ 	fmtAddAppToProjectStart    = ""Creating ECR repositories for application %s.""
+ 	fmtAddAppToProjectFailed   = ""Failed to create ECR repositories for application %s.""",Would it be better to put like `Which Dockerfile would you like to use for %s?`,fmtAppInitDockerfileHelpP
+7223,"@@ -3636,8 +3636,8 @@ Model.hydrate = function(obj) {
+  * @see response http://docs.mongodb.org/v2.6/reference/command/update/#output
+  * @param {Object} filter
+  * @param {Object} doc
+- * @param {Object} [options] optional see [`Query.prototype.setOptions()`](http://mongoosejs.com/docs/api.html#query_Query-setOptions)
+- * @param {Boolean|String} [options.strict] overwrites the schema's [strict mode option](http://mongoosejs.com/docs/guide.html#strict)
++ * @param {Object} [options] optional see [`Query.prototype.setOptions()`](/api.html#query_Query-setOptions)
++ * @param {Boolean|String} [options.strict] overwrites the schema's [strict mode option](/docs/guide.html#strict)
+  * @param {Boolean} [options.upsert=false] if true, and no documents found, insert a new document
+  * @param {Object} [options.writeConcern=null] sets the [write concern](https://docs.mongodb.com/manual/reference/write-concern/) for replica sets. Overrides the [schema-level write concern](/docs/guide.html#writeConcern)
+  * @param {Boolean} [options.omitUndefined=false] If true, delete any properties whose value is `undefined` when casting an update. In other words, if this is set, Mongoose will delete `baz` from the update in `Model.updateOne({}, { foo: 'bar', baz: undefined })` before sending the update to the server.","You mistakenly removed `/docs` here, please add it",Why was this line removed
+7224,"@@ -48,8 +48,9 @@ public interface FileAppender<D> extends Closeable {
+   long length();
+
+   /**
+-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
++   * @return a list of offsets for file blocks, if applicable, null otherwise. When available, this
+    * information is used for planning scan tasks whose boundaries are determined by these offsets.
++   * It is important that the returned list is sorted in ascending order.
+    * Only valid after the file is closed.
+    */
+   default List<Long> splitOffsets() {","I missed this earlier, but why does this say ""file blocks""? This should probably be ""recommended split locations"".",It is important that the returned list is sorted in ascending order. It is also important that the returned list is sorted in ascending order.
+7225,"@@ -33,10 +33,10 @@ import (
+ // AlertsServer implements api.OpenStorageAlertsServer.
+ // In order to use this server implementation just have
+ // AlertsServer pointer properly instantiated with a valid
+-// alerts.Reader.
++// alerts.FilterDeleter.
+ type AlertsServer struct {
+-	// Reader holds pointer to alerts Reader
+-	Reader alerts.Reader
++	// FilterDeleter holds pointer to alerts FilterDeleter
++	FilterDeleter alerts.FilterDeleter
+ }
+
+ func getOpts(opts []*api.SdkAlertsOption) []alerts.Option {",Please change this to non-exported.,`AlertsServer` should be renamed to `FilterDeleter`.
+7226,"@@ -4649,10 +4649,7 @@ stats_get_snapshot(dr_stats_t *drstats)
+     if (!GLOBAL_STATS_ON())
+         return false;
+     CLIENT_ASSERT(drstats != NULL, ""Expected non-null value for parameter drstats."");
+-    /* We are at V1 of the structure, and we can't return less than the one
+-     * field. We need to remove this assert when we add more fields.
+-     */
+-    CLIENT_ASSERT(drstats->size >= sizeof(dr_stats_t), ""Invalid drstats->size value."");
+     drstats->basic_block_count = GLOBAL_STAT(num_bbs);
++    drstats->peak_num_threads = GLOBAL_STAT(peak_num_threads);
+     return true;
+ }",This is ignoring compatibility: it needs to check the size to ensure this field exists in the client.,"I wouldn't remove all the asserts. In this case, we're just asserting that the size is >= sizeof(drstats_t), in all the places where we're usi"
+7227,"@@ -96,10 +96,11 @@ public class RoundChangePayloadValidator {
+       return false;
+     }
+
+-    if (certificate.getPreparePayloads().size() < minimumPrepareMessages) {
++    if (certificate.getPreparePayloads().stream().map(SignedData::getAuthor).distinct().count()
++        < minimumPrepareMessages) {
+       LOG.info(
+-          ""Invalid RoundChange message, insufficient Prepare messages exist to justify ""
+-              + ""prepare certificate."");
++          ""Invalid RoundChange message, insufficient uniquely authored Prepare messages exist to ""
++              + "" justify  prepare certificate."");
+       return false;
+     }
+ ",Do all the prepare authors also need to be unique? Or is it enough the we have minimumPrepareMessages. I guess I'm wondering if need a hasDuplicateAuthors check like in the RoundChangeCertificateValidator.,"Might be worth extracting this duplicated code into a method on CertificateProcessor, as it seems to be repeated many times."
+7228,"@@ -4,12 +4,17 @@ package stdlib
+
+ import (
+ 	_ ""github.com/influxdata/flux/stdlib/csv""
++	_ ""github.com/influxdata/flux/stdlib/date""
+ 	_ ""github.com/influxdata/flux/stdlib/generate""
+ 	_ ""github.com/influxdata/flux/stdlib/http""
+ 	_ ""github.com/influxdata/flux/stdlib/influxdata/influxdb""
+ 	_ ""github.com/influxdata/flux/stdlib/influxdata/influxdb/v1""
+ 	_ ""github.com/influxdata/flux/stdlib/kafka""
+ 	_ ""github.com/influxdata/flux/stdlib/math""
++	_ ""github.com/influxdata/flux/stdlib/mqtt""
++	_ ""github.com/influxdata/flux/stdlib/promql""
++	_ ""github.com/influxdata/flux/stdlib/regexp""
++	_ ""github.com/influxdata/flux/stdlib/runtime""
+ 	_ ""github.com/influxdata/flux/stdlib/socket""
+ 	_ ""github.com/influxdata/flux/stdlib/sql""
+ 	_ ""github.com/influxdata/flux/stdlib/strings""","we had some situations where we merged some promql bits then took them out. i'm not sure what's going on here, but unless your code actually needs promql (probably not?) let's remove this line.",These should be in the `influxdata/flux` package now.
+7229,"@@ -32,9 +32,9 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend
+     {
+         $termsAndConditions = $this->getReference(ArticleDataFixture::ARTICLE_TERMS_AND_CONDITIONS_1);
+         $privacyPolicy = $this->getReference(ArticleDataFixture::ARTICLE_PRIVACY_POLICY_1);
+-        /* @var $termsAndConditions \Shopsys\FrameworkBundle\Model\Article\Article */
++        /* @var $termsAndConditions \Shopsys\ShopBundle\Model\Article\Article */
+         $cookies = $this->getReference(ArticleDataFixture::ARTICLE_COOKIES_1);
+-        /* @var $cookies \Shopsys\FrameworkBundle\Model\Article\Article */
++        /* @var $cookies \Shopsys\ShopBundle\Model\Article\Article */
+
+         $personalDataDisplaySiteContent = 'By entering an email below, you can view your personal information that we register in our online store.
+         An email with a link will be sent to you after entering your email address, to verify your identity. ","Annotations in this hunk should follow PhpDoc style (above the occurrence, type first)",Same as above I would avoid using `\` imports if poss
+7230,"@@ -100,7 +100,7 @@ public class Wildcard implements Type {
+         } else if (type == BoundType.EXTENDS) {
+             return ""? extends "" + boundedType.describe();
+         } else {
+-            throw new UnsupportedOperationException();
++            throw new UnsupportedOperationException(String.format(""%s is not supported"", type));
+         }
+     }
+ ","This is an improvement - thanks! Could we rephrase slightly to not use the phrase ""is not supported"" -- instead stating _WHAT_ isn't valid please? e.g. maybe `String.format(""Unsupported BoundType provided: %s"" type)` or something like that.","""not supported"" feels a bit like a syntax error. What"
+7231,"@@ -30,7 +30,7 @@ type linuxWatcher struct {
+ 	gid       uint32
+ 	pid       int32
+ 	mtx       sync.Mutex
+-	procfh    *os.File
++	procfh    int
+ 	starttime string
+ 	uid       uint32
+ }",nit: `procfd` seems more appropriate now?,Shouldn't this be uint32?
+7232,"@@ -1045,6 +1045,10 @@ def access_put(owner, package_name, user):
+             ""Only the package owner can grant access""
+         )
+
++    django_headers = {
++        AUTHORIZATION_HEADER: g.auth_header
++        }
++
+     package = (
+         Package.query
+         .with_for_update()",Let's not call it django. Maybe `auth_provider_headers`? `auth_headers`?,Why does this need to be added here?
+7233,"@@ -252,7 +252,8 @@ func (s *Server) isClientAuthorized(c *client) bool {
+ 	tlsMap := s.opts.TLSMap
+ 	s.optsMu.RUnlock()
+
+-	// Check custom auth first, then jwts, then nkeys, then multiple users, then token, then single user/pass.
++	// Check custom auth first, then jwts, then nkeys, then
++	// multiple users, then token, then single user/pass.
+ 	if customClientAuthentication != nil {
+ 		return customClientAuthentication.Check(c)
+ 	}",Should we mention TLS map here?,"Is this a ""bug"" before this change?"
+7234,"@@ -25,9 +25,12 @@
+ package net.runelite.client.plugins.playerindicators;
+
+ import java.awt.Color;
++
++import net.runelite.api.ClanMemberRank;
+ import net.runelite.client.config.Config;
+ import net.runelite.client.config.ConfigGroup;
+ import net.runelite.client.config.ConfigItem;
++import net.runelite.client.config.Range;
+
+ @ConfigGroup(""playerindicators"")
+ public interface PlayerIndicatorsConfig extends Config",remove this empty line pl0x,wrong import order
+7235,"@@ -34,4 +34,10 @@ class NcrDispatcher < LinearDispatcher
+       end
+     }
+   end
++
++  def on_approver_removal(proposal, approvers)
++    approvers.each{|approver|
++      CommunicartMailer.notification_for_subscriber(approver.email_address,proposal,""removed"").deliver_now
++    }
++  end
+ end",Why not have this in the `Dispatcher`? Doesn't seem like NCR-specific functionality.,Space missing after comma.<br>Line i
+7236,"@@ -26,6 +26,11 @@ import (
+ )
+
+ func CreateTestKV(t *testing.T) kv.RwDB {
++	s, _, _ := CreateTestSentry(t)
++	return s.DB
++}
++
++func CreateTestSentry(t *testing.T) (*stages.MockSentry, *core.ChainPack, []*core.ChainPack) {
+ 	// Configure and generate a sample block chain
+ 	var (
+ 		key, _   = crypto.HexToECDSA(""b71c71a67e1177ad4e901695e1b4b9ee17ae16c6668d313eac2f96dbcda3f291"")","If you need only test db, use `memdb.NewTestDB(t)`",Please drop this one too.
+7237,"@@ -533,7 +533,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+                             await ProduceEnd();
+
+                             // ForZeroContentLength does not complete the reader nor the writer
+-                            if (!messageBody.IsEmpty && _keepAlive)
++                            if (!messageBody.IsEmpty)
+                             {
+                                 // Finish reading the request body in case the app did not.
+                                 await messageBody.ConsumeAsync();",I'm not sure I like setting the IsEmpty property true for upgraded connections since it feels a middle misleading. Maybe we can leave the ForUpgrade class as is and change this condition to `if (!messageBody.IsEmpty && !messageBody.RequestUpgrade)` to make things more explicit.,Do we not need the `_keep
+7238,"@@ -141,7 +141,7 @@ ActiveRecord::Schema.define(version: 20151123235600) do
+     t.integer  ""client_data_id""
+     t.string   ""client_data_type"", limit: 255
+     t.integer  ""requester_id""
+-    t.string   ""public_id""
++    t.string   ""public_id"",        limit: 255
+   end
+
+   add_index ""proposals"", [""client_data_id"", ""client_data_type""], name: ""index_proposals_on_client_data_id_and_client_data_type"", using: :btree",git checkout since this is unrelated to this PR? (running migrations also changes this for me -- not sure why it keeps going back and forth,Unnecessary spacing detec
+7239,"@@ -154,7 +154,7 @@ class _TLSSignature(_GenericTLSSessionInheritance):
+     #XXX 'sig_alg' should be set in __init__ depending on the context.
+     """"""
+     name = ""TLS Digital Signature""
+-    fields_desc = [SigAndHashAlgField(""sig_alg"", 0x0401, _tls_hash_sig),
++    fields_desc = [SigAndHashAlgField(""sig_alg"", 0x0804, _tls_hash_sig),
+                    SigLenField(""sig_len"", None, fmt=""!H"",
+                                length_of=""sig_val""),
+                    SigValField(""sig_val"", None,",Is this change needed?,Did this really need to b
+7240,"@@ -1321,7 +1321,7 @@ void MolPickler::_pickleAtom(std::ostream &ss, const Atom *atom) {
+     streamWrite(ss, ENDQUERY);
+   }
+   if (getAtomMapNumber(atom, tmpInt)) {
+-    if (tmpInt < 128) {
++    if (tmpInt >= 0 && tmpInt < 128) {
+       tmpChar = static_cast<char>(tmpInt % 128);
+       streamWrite(ss, ATOM_MAPNUMBER, tmpChar);
+     } else {",Isn't the % 128 redundant here?,Shouldn't this be `||` instead of `&&`?
+7241,"@@ -34,7 +34,9 @@ func TestCmdMarshalProto(t *testing.T) {
+  ""sticky"": false,
+  ""group_enforced"": false,
+  ""compressed"": false,
+- ""cascaded"": false
++ ""cascaded"": false,
++ ""loopdev"": false,
++ ""ramdisk"": false
+ }`,
+ 		data,
+ 	)","Are you testing that the values are always false? I think you should test for setting values to true or false, right? Who is going to take action with these values?",So this defaults to `true`? I don't see
+7242,"@@ -35,6 +35,9 @@ extern const struct batch_queue_module batch_queue_wq;
+ extern const struct batch_queue_module batch_queue_mesos;
+ extern const struct batch_queue_module batch_queue_k8s;
+ extern const struct batch_queue_module batch_queue_dryrun;
++#ifdef MPI
++extern const struct batch_queue_module batch_queue_mpi;
++#endif
+
+ static struct batch_queue_module batch_queue_unknown = {
+ 	BATCH_QUEUE_TYPE_UNKNOWN, ""unknown"",",Please change MPI to CCTOOLS_WITH_MPI,It seems like there is a lot of overlap
+7243,"@@ -16,6 +16,11 @@
+
+ #include ""oneapi/dal/algo/decision_forest/common.hpp""
+ #include ""oneapi/dal/algo/decision_forest/detail/model_impl.hpp""
++#include ""oneapi/dal/exceptions.hpp""
++
++#define DAL_CHECK_DOMAIN_COND(cond, description) \
++    if (!(cond))                                 \
++        throw domain_error(description);
+
+ namespace oneapi::dal::decision_forest {
+ ",Why you can't use function here?,this should be defined in `oneapi/dal/e
+7244,"@@ -0,0 +1,16 @@
++// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package ssm
++
++//go:generate go run ../../scripts/generate/mockgen.go github.com/aws/aws-sdk-go/service/ssm/ssmiface SSMAPI mocks/ssmiface_mocks.go",We should scope this down to only the methods we use.,Please move this mock to `aws/internal/service/ssm/mock.go`
+7245,"@@ -800,7 +800,7 @@ public final class HashSet<T> implements Set<T>, Serializable {
+
+     @Override
+     public String toString() {
+-        return mkString("", "", ""HashSet("", "")"");
++        return mkString(""HashSet("", "", "", "")"");
+     }
+
+     private static <T> HashArrayMappedTrie<T, T> addAll(HashArrayMappedTrie<T, T> initial,","Oh, thanks for catching - I thought I've catched all after changing `mkString(infix, prefix, suffix)` to `mkString(prefix, infix, suffix)`.","Did you mean to leave the `"", ""` there?"
+7246,"@@ -33,6 +33,14 @@ const (
+ 	// Issued indicates that a CertificateRequest has been completed, and that
+ 	// the `status.certificate` field is set.
+ 	CertificateRequestReasonIssued = ""Issued""
++
++	// Approved indicates that a CertificateRequest has been approved by the
++	// approver, and the CertificateRequest is ready for signing.
++	CertificateRequestReasonApproved = ""Approved""
++
++	// Denied indicates that a CertificateRequest has been denied by the
++	// approver, and the CertificateRequest will be never be signed.
++	CertificateRequestReasonDenied = ""Denied""
+ )
+
+ // +genclient","Suggestion: `.. the CertificateRequest is ready for signing` - could we perhaps word this differently? I understand that in this case it will be the associated X.509 certificate that can now be signed, so maybe `the certificate is ready for signing` ? (Same with `CertificateRequestReasonDenied`).",I don't think we need this since we already have approval i
+7247,"@@ -54,6 +54,10 @@ export default function PropertySelect() {
+ 		}
+ 	}, [ propertyID, selectProperty ] );
+
++	if ( ! accountID ) {
++		return null;
++	}
++
+ 	if ( isLoading ) {
+ 		return <ProgressBar small />;
+ 	}",We should use `! isValidAccountID( accountID )` for the `accountID` checks.,Is there any way to provide a test for this?
+7248,"@@ -6,7 +6,9 @@ require 'bolt/error'
+ module Bolt
+   class Target
+     attr_reader :uri, :options
+-    attr_writer :inventory
++    # CODEREVIEW: this feels wrong. The altertative is threading inventory through the
++    # executor to the RemoteTransport
++    attr_accessor :inventory
+
+     PRINT_OPTS ||= %w[host user port protocol].freeze
+ ",That alternative does seem better. Did you want to try to do it in this PR? It makes sense to me that the inventory would always be available before creating the executor.,"This feels wrong to me, it seems to me that `inventory` should be a `persisted?` method, so that the `persisted?` method can be called without knowing the `persisted?` state. The `persisted?` method on `RemoteTransport` can return `false` to indicate that the `persisted?` is expected to return `true` or `false`."
+7249,"@@ -545,8 +545,12 @@ module Beaker
+           on host, ""apt-get install -y hiera=#{opts[:hiera_version]}-1puppetlabs1""
+         end
+
+-        puppet_pkg = opts[:version] ? ""puppet=#{opts[:version]}-1puppetlabs1"" : 'puppet'
+-        on host, ""apt-get install -y #{puppet_pkg}""
++        if opts[:version]
++          on host, ""apt-get install -y puppet-common=#{opts[:version]}-1puppetlabs1""
++          on host, ""apt-get install -y puppet=#{opts[:version]}-1puppetlabs1""
++        else
++          on host, 'apt-get install -y puppet'
++        end
+       end
+
+       # Installs Puppet and dependencies from msi",Missing the `-y` argument which all other `apt-get install` commands have.,Metrics/LineLength: Line is too long. [90/80]
+7250,"@@ -1295,7 +1295,8 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+     auto subpass_desc = &pPipeline->rp_state->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass];
+     if (pPipeline->graphicsPipelineCI.subpass >= pPipeline->rp_state->createInfo.subpassCount) {
+         skip |= LogError(device, ""VUID-VkGraphicsPipelineCreateInfo-subpass-00759"",
+-                         ""Invalid Pipeline CreateInfo[%u] State: Subpass index %u is out of range for this renderpass (0..%u)."",
++                         ""Invalid Pipeline CreateInfo[%"" PRIu32
++                         ""] State: Subpass index %u is out of range for this renderpass (0..%u)."",
+                          pipelineIndex, pPipeline->graphicsPipelineCI.subpass, pPipeline->rp_state->createInfo.subpassCount - 1);
+         subpass_desc = nullptr;
+     }","So I think we are going to settle on the ""concise and elegant"" `PRI` macros as they are the safest option for now. Even though they make my eyes bleed a little...","There's no ""PRIu32"" somewhere in the code. Also what is the ""0..0"" here?"
+7251,"@@ -112,7 +112,7 @@ func (r *Replacer) ReplaceFunc(input string, f ReplacementFunc) (string, error)
+ func (r *Replacer) replace(input, empty string,
+ 	treatUnknownAsEmpty, errOnEmpty, errOnUnknown bool,
+ 	f ReplacementFunc) (string, error) {
+-	if !strings.Contains(input, string(phOpen)) {
++	if !strings.Contains(input, string(phOpen)) && !strings.Contains(input, string(phClose)) {
+ 		return input, nil
+ 	}
+ ","Interesting, was this needed for a test case to pass? I figured if there is no opening brace, there is definitely no placeholder -- we don't even have to check for a closing one.","The `string(phClose)` here was causing the tests to fail, so I'm not sure what the right thing to do is."
+7252,"@@ -122,8 +122,10 @@ ChainLoop:
+ 			return []explorer.Transfer{}, err
+ 		}
+
+-		for i := len(blk.Transfers) - 1; i >= 0; i-- {
+-			if showCoinBase || !blk.Transfers[i].IsCoinbase() {
++		transfers, _, _ := action.ClassifyActions(blk.Actions)
++
++		for i := len(transfers) - 1; i >= 0; i-- {
++			if showCoinBase || !transfers[i].IsCoinbase() {
+ 				transferCount++
+ 			}
+ ",I think we want to provide getAction API instead,why this error ignored?
+7253,"@@ -117,12 +117,7 @@ class SynthDriver(SynthDriver):
+
+ 	@classmethod
+ 	def check(cls):
+-		if not hasattr(sys, ""frozen""):
+-			# #3793: Source copies don't report the correct version on Windows 10 because Python isn't manifested for higher versions.
+-			# We want this driver to work for source copies on Windows 10, so just return True here.
+-			# If this isn't in fact Windows 10, it will fail when constructed, which is okay.
+-			return True
+-		# For binary copies, only present this as an available synth if this is Windows 10.
++		# Only present this as an available synth if this is Windows 10.
+ 		return winVersion.winVersion.major >= 10
+
+ 	def _get_supportsProsodyOptions(self):","There is also `winVersion.isWin10`. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here.",Do we know why this did
+7254,"@@ -37,6 +37,7 @@ RSpec.configure do |config|
+   config.use_transactional_fixtures = false
+   config.use_instantiated_fixtures  = false
+   config.fixture_path = ""#{::Rails.root}/spec/fixtures""
++  config.fail_fast = true
+
+   config.include Paperclip::Shoulda::Matchers
+   config.include EmailSpec::Helpers",This doesn't seem like it should be part of this pull request.,This seems like it will
+7255,"@@ -4,6 +4,7 @@ class ProductsController < ApplicationController
+
+   def show
+     @product = Product.find(params[:id])
++    @offering = @product
+     @viewable_subscription = ViewableSubscription.new(current_user, subscription_product)
+
+     if signed_in? && @product.purchase_for(current_user)",Is the idea that `@product` (and `@workshop` for `workshops_controller`) would eventually go away here?,This is not needed. I s
+7256,"@@ -0,0 +1,8 @@
++package headerdownload
++
++var bscMainnetPreverifiedHashes = []string{
++	""0d21840abff46b96c84b2ac9e10e4f5cdaeb5693cb665db62a2f3b02d2d57b5b"",
++	""04055304e432294a65ff31069c4d3092ff8b58f009cdb50eba5351e0332ad0f6"",
++}
++
++const bscMainnetPreverifiedHeight uint64 = 1","We should add those only once we have successfully synced to the BSC main net, we have a utility to generate those. Please remove for now",why is this in the mainnet package?
+7257,"@@ -376,7 +376,7 @@ def test_set_env_from_file(config_instance):
+
+
+ def test_set_env_from_file_returns_original_env_when_env_file_not_found(
+-    config_instance
++    config_instance,
+ ):
+     env = config.set_env_from_file({}, 'file-not-found')
+ ",And how is that related?,Don't remove trailing commas.
+7258,"@@ -55,7 +55,8 @@ func AdminAddOrUpdateRemoteCluster(c *cli.Context) {
+ 	defer cancel()
+
+ 	_, err := adminClient.AddOrUpdateRemoteCluster(ctx, &adminservice.AddOrUpdateRemoteClusterRequest{
+-		FrontendAddress: getRequiredOption(c, FlagFrontendAddressWithAlias),
++		FrontendAddress:               c.String(FlagFrontendAddressWithAlias),
++		EnableRemoteClusterConnection: c.BoolT(FlagConnectionEnableAlias),
+ 	})
+ 	if err != nil {
+ 		ErrorAndExit(""Operation AddOrUpdateRemoteCluster failed."", err)",this should be required,Could we use `c.Bool(FlagConnection
+7259,"@@ -18,6 +18,7 @@ import com.google.api.codegen.SnippetSetRunner;
+ import com.google.auto.value.AutoValue;
+ import java.util.List;
+ import javax.annotation.Nullable;
++import javax.validation.constraints.Null;
+
+ @AutoValue
+ public abstract class DynamicLangXApiView implements ViewModel {",This appears to be unused,Is this import necessary?
+7260,"@@ -63,6 +63,19 @@ public class SnapshotUtil {
+     return ancestorIds(table.currentSnapshot(), table::snapshot);
+   }
+
++  /**
++   * Traverses the history of the table's state and finds the oldest Snapshot.
++   * @return null if the table is empty, else the oldest Snapshot.
++   */
++  public static Snapshot oldestSnapshot(Table table) {
++    Snapshot current = table.currentSnapshot();
++    while (current != null && current.parentId() != null) {
++      current = table.snapshot(current.parentId());
++    }
++
++    return current;
++  }
++
+   /**
+    * Returns list of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
+    * <p>","I think that ""table's state"" isn't clear enough. How about ""history of the table's current snapshot"" like the one below?",I was wondering if this should be called `findOldestSnapshot` or `findMostRecentSnapshot` or something like that.
+7261,"@@ -457,3 +457,17 @@ instr_is_exclusive_store(instr_t *instr)
+     }
+     return false;
+ }
++
++DR_API
++bool
++instr_is_scatter(instr_t *instr)
++{
++    return false;
++}
++
++DR_API
++bool
++instr_is_gather(instr_t *instr)
++{
++    return false;
++}",This looks like a bug: pretty sure there are scatter-gather instructions on AArch64. Ditto below.,this should be `instr_is_scatter`
+7262,"@@ -55,9 +55,10 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // sharing this transport.
+ func (t *Transport) NewInbound(addr string, opts ...InboundOption) *Inbound {
+ 	i := &Inbound{
+-		once:   sync.Once(),
+-		addr:   addr,
+-		tracer: t.tracer,
++		once:      sync.Once(),
++		addr:      addr,
++		tracer:    t.tracer,
++		transport: t,
+ 	}
+ 	for _, opt := range opts {
+ 		opt(i)","No need to change this: id love if we changed as a team to unkeyed fields, it ends up catching a lot more at compile time, at minimal cost",can we rename `once` to `transmitOnce` to avoid ambiguity?
+7263,"@@ -105,6 +105,11 @@ func (m LBFargateManifest) DockerfilePath() string {
+ 	return m.Image.Build
+ }
+
++// AppName returns the name of the application
++func (m LBFargateManifest) AppName() string {
++	return m.Name
++}
++
+ // EnvConf returns the application configuration with environment overrides.
+ // If the environment passed in does not have any overrides then we return the default values.
+ func (m *LBFargateManifest) EnvConf(envName string) LBFargateConfig {",Should this be in the parent struct? `AppManifest` since it's embedded to `LBFargateManifest` it'll get the method as well.,I don't see how this is used.
+7264,"@@ -18,7 +18,12 @@
+ package openvpn
+
+ import (
++	""bufio""
++	""bytes""
+ 	""errors""
++	log ""github.com/cihub/seelog""
++	""io""
++	""net/textproto""
+ 	""os/exec""
+ 	""strconv""
+ 	""syscall""","""Openvpn check"" we could move this to separate prefix.",Nit: can you remove the extra lines between this and the other files?
+7265,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests,I think we should close the connection in the finally block. If the r
+7266,"@@ -42,8 +42,6 @@ void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
+             } else {
+                 this->pushResultCode(this->to(code), partId);
+             }
+-            this->onFinished();
+-            return;
+         }
+     });
+ ",We don't return now?,why is this removed?
+7267,"@@ -18,7 +18,7 @@ module Travis
+         end
+
+         def install
+-          uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install'
++          uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install', retry: true
+         end
+
+         def script","This might end up not doing exactly what we want (the retry only picks up the `go get`, not the `go build`, due to the `&&`).",Line is too long. [86/80]
+7268,"@@ -1,4 +1,4 @@
+-// <copyright file=""ConsoleExporterOptions.cs"" company=""OpenTelemetry Authors"">
++// <copyright file=""ConsoleExporterOptions.cs"" company=""OpenTelemetry Authors"">
+ // Copyright The OpenTelemetry Authors
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");",Is there a BOM change?,Is there any reason for this change?
+7269,"@@ -142,8 +142,6 @@ public final class Const {
+
+   public static final String REGISTRY_SERVICE_NAME = ""SERVICECENTER"";
+
+-  public static final String REGISTRY_VERSION = ""3.0.0"";
+-
+   public static final String APP_SERVICE_SEPARATOR = "":"";
+
+   public static final String PATH_CHECKSESSION = ""checksession"";",It's not a good practise to delete the public static constant.,shouldn't this be just removed?
+7270,"@@ -467,13 +467,7 @@ func (eval *BlockEvaluator) transaction(txn transactions.SignedTxn, ad transacti
+ 			return TransactionInLedgerError{txn.ID()}
+ 		}
+
+-		// Well-formed on its own?
+-		err = txn.Txn.WellFormed(spec, eval.proto)
+-		if err != nil {
+-			return fmt.Errorf(""transaction %v: malformed: %v"", txn.ID(), err)
+-		}
+-
+-		// Properly signed?
++		// Well-formed and signed properly?
+ 		if eval.txcache == nil || !eval.txcache.Verified(txn) {
+ 			err = verify.TxnPool(&txn, spec, eval.proto, eval.verificationPool)
+ 			if err != nil {",I deleted this because `WellFormed` is immediately called by `verify.TxnPool` below. Can someone please double check this for me since it's... pretty important,Why remove this check? If we don't n
+7271,"@@ -70,6 +70,7 @@ setup(
+         ""kaitaistruct>=0.7,<0.9"",
+         ""ldap3>=2.5,<2.6"",
+         ""passlib>=1.6.5, <1.8"",
++        ""ply>=3.4, <3.12"",
+         ""pyasn1>=0.3.1,<0.5"",
+         ""pyOpenSSL>=17.5,<18.1"",
+         ""pyparsing>=2.1.3, <2.3"",","Did you actually test this with ply 3.4? That release is pretty old (2011), so I think we can bump this to at least 3.6 (2015) or even 3.10 (2017)...","I don't think we should have this, b"
+7272,"@@ -130,6 +130,12 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe
+
+ 	r.includeGlobalPullSecret(hLog, h, instance, hiveDeployment)
+
++	if instance.Spec.MaintenanceMode != nil && *instance.Spec.MaintenanceMode {
++		hLog.Warn(""maintenanceMode enabled in HiveConfig, setting hive-controllers replicas to 0"")
++		replicas := int32(0)
++		hiveDeployment.Spec.Replicas = &replicas
++	}
++
+ 	result, err := h.ApplyRuntimeObject(hiveDeployment, scheme.Scheme)
+ 	if err != nil {
+ 		hLog.WithError(err).Error(""error applying deployment"")",This can be simplified somewhat to `pointer.Int32Ptr(0)`. But it is not necessary.,I don't see this change in the PR. Did you mean to commit this?
+7273,"@@ -226,9 +226,7 @@ static bool checkBondStereo(const MCSBondCompareParameters& p,
+   Bond::BondStereo bs1 = b1->getStereo();
+   Bond::BondStereo bs2 = b2->getStereo();
+   if (b1->getBondType() == Bond::DOUBLE && b2->getBondType() == Bond::DOUBLE) {
+-    if ((bs1 == Bond::STEREOZ || bs1 == Bond::STEREOE) &&
+-        !(bs2 == Bond::STEREOZ || bs2 == Bond::STEREOE))
+-      return false;
++    if (bs1 > Bond::STEREOANY && !(bs2 > Bond::STEREOANY)) return false;
+   }
+   return true;
+ }",Clever but perhaps confusing.,this is not correct. `if (bs1 > Bond::STEREOANY && !(bs2 > Bond
+7274,"@@ -360,10 +360,14 @@ func (r *ReconcileSyncSetInstance) syncDeletedSyncSetInstance(ssi *hivev1.SyncSe
+
+ 	ssiLog.Info(""deleting syncset resources on target cluster"")
+ 	err = r.deleteSyncSetResources(ssi, dynamicClient, ssiLog)
+-	if err == nil {
+-		return reconcile.Result{}, r.removeSyncSetInstanceFinalizer(ssi, ssiLog)
++	if err != nil {
++		return reconcile.Result{}, err
++	}
++	err = r.deleteSyncSetSecretReferences(ssi, dynamicClient, ssiLog)
++	if err != nil {
++		return reconcile.Result{}, err
+ 	}
+-	return reconcile.Result{}, err
++	return reconcile.Result{}, r.removeSyncSetInstanceFinalizer(ssi, ssiLog)
+ }
+
+ func (r *ReconcileSyncSetInstance) applySyncSet(ssi *hivev1.SyncSetInstance, spec *hivev1.SyncSetCommonSpec, dynamicClient dynamic.Interface, h Applier, kubeConfig []byte, ssiLog log.FieldLogger) error {",@abutcher Is it a safe assumption that secrets are the only objects that need to get attached to syncsets?,why should we delete the secret references when the syncset is
+7275,"@@ -1605,7 +1605,8 @@ func (o *consumer) needAck(sseq uint64) bool {
+ 		state, err := o.store.State()
+ 		if err != nil || state == nil {
+ 			o.mu.RUnlock()
+-			return false
++			// Fall back to what we track internally for now.
++			return sseq > o.asflr
+ 		}
+ 		asflr, osseq = state.AckFloor.Stream, o.sseq
+ 		pending = state.Pending",Should you capture o.asflr before releasing consumer's lock?,@brycemcanally you mind explaining why this change is needed?
+7276,"@@ -51,6 +51,10 @@ public class WinePrefixContainerWineToolsTab extends Tab {
+         final VBox toolsPane = new VBox();
+         final Text title = new TextWithStyle(tr(""Wine tools""), TITLE_CSS_CLASS);
+
++        if (engineTools == null) {
++            return;
++        }
++
+         toolsPane.getStyleClass().add(CONFIGURATION_PANE_CSS_CLASS);
+         toolsPane.getChildren().add(title);
+ ","Just asking: Should this happen, that null is passed? If this is the case I think we should think about passing an `Optional` object to the method.",This is the only real change in this file. The rest of the changes are related to API changes.
+7277,"@@ -10,6 +10,17 @@ class HomeController < ApplicationController
+   def me
+   end
+
++  def edit_me
++    first_name = params[:first_name]
++    last_name = params[:last_name]
++    user = current_user
++    user.first_name = first_name
++    user.last_name = last_name
++    user.save!
++    flash[:success] = ""Your profile is updated!""
++    redirect_to :me
++  end
++
+   def error
+     raise ""test exception""
+   end","what about making a `ProfilesController` or `UserProfilesController` and having this be a `show` action instead? That would be more Railsy (although that can be considered a compliment or a dis, depending on who you are :hamburger: )","Do we want this to raise an exception? If so, is there a reason we can't just use `raise` here"
+7278,"@@ -2378,7 +2378,11 @@ void PostCallRecordCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *
+     }
+
+     layer_data *device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
+-    device_data->enabled_features.core = *enabled_features_found;
++    if (nullptr == enabled_features_found) {
++        device_data->enabled_features.core = {};
++    } else {
++        device_data->enabled_features.core = *enabled_features_found;
++    }
+
+     uint32_t count;
+     instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr);",I'd move the empty assignment and non-null case into the if check directly above (adding an else clause as needed),"This doesn't look right. If enabled_features_found is null, we don't want to clear the enabled"
+7279,"@@ -215,6 +215,8 @@ class Preference extends Model
+             'zh-tw' => [Lang::get('system::lang.locale.zh-tw'), 'flag-tw'],
+             'nb-no' => [Lang::get('system::lang.locale.nb-no'), 'flag-no'],
+             'el' => [Lang::get('system::lang.locale.el'), 'flag-gr'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++
+         ];
+
+         $locales = Config::get('app.localeOptions', $localeOptions);",Please remove this extra line of whitespace,Please update `index.php` as well.
+7280,"@@ -83,14 +83,15 @@ class ProductSearchExportWithFilterRepository
+     /**
+      * @param int $domainId
+      * @param string $locale
+-     * @param int $startFrom
++     * @param int $lastProcessedId
+      * @param int $batchSize
+      * @return array
+      */
+-    public function getProductsData(int $domainId, string $locale, int $startFrom, int $batchSize): array
++    public function getProductsData(int $domainId, string $locale, int $lastProcessedId, int $batchSize): array
+     {
+         $queryBuilder = $this->createQueryBuilder($domainId)
+-            ->setFirstResult($startFrom)
++            ->andWhere('p.id > :lastProcessedId')
++            ->setParameter('lastProcessedId', $lastProcessedId)
+             ->setMaxResults($batchSize);
+
+         $query = $queryBuilder->getQuery();","maybe it's time to rename `ProductSearchExportWithFilter` to something better, what do you think?","IMO, `int` and `int` are not the right type for these. A `lastProcessedId` should be an `int` with a default value."
+7281,"@@ -49,11 +49,11 @@ func (agent *ecsAgent) appendTaskEIACapabilities(capabilities []*ecs.Attribute)
+ }
+
+ func (agent *ecsAgent) appendFirelensFluentdCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+-	return capabilities
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentd)
+ }
+
+ func (agent *ecsAgent) appendFirelensFluentbitCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+-	return capabilities
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentbit)
+ }
+
+ func (agent *ecsAgent) appendEFSCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {","Instead of adding new code here - can you move these methods to agent_capability.go, so the same is used for unix and windows as well. this will need removal of these methods from agent_capability_unix.go as well.","This is more of a question, but why do we need both `appendFirelensFluentdCapabilities` and `appendFirelensFluentbi"
+7282,"@@ -648,7 +648,7 @@ def log(package):
+             str(entry.get('tags', [])), str(entry.get('versions', []))))
+     _print_table(table)
+
+-def push(package, is_public=False, is_team=False, reupload=False):
++def push(package, hash=None, is_public=False, is_team=False, reupload=False):
+     """"""
+     Push a Quilt data package to the server
+     """"""","Make it the last parameter, just in case someone uses the API with non-keyword args.",We need to add the docstring for `hash`.
+7283,"@@ -1,15 +1,15 @@
+-class GithubRemovalJob < Struct.new(:github_team, :username)
++class GithubRemovalJob < Struct.new(:repository, :username)
+   include ErrorReporting
+
+   PRIORITY = 1
+
+-  def self.enqueue(github_team, username)
+-    Delayed::Job.enqueue(new(github_team, username))
++  def self.enqueue(repository, username)
++    Delayed::Job.enqueue(new(repository, username))
+   end
+
+   def perform
+     begin
+-      github_client.remove_team_member(github_team, username)
++      github_client.remove_collaborator(repository, username)
+     rescue Octokit::NotFound, Net::HTTPBadResponse => e
+       Airbrake.notify(e)
+     end",Don't extend an instance initialized by `Struct.new`.,Line is too long. [99/80]
+7284,"@@ -4771,6 +4771,11 @@ static void tdes(pmix_server_trkr_t *t)
+     if (NULL != t->info) {
+         PMIX_INFO_FREE(t->info, t->ninfo);
+     }
++    pmix_nspace_caddy_t *nm, *nm_next;
++    PMIX_LIST_FOREACH_SAFE(nm, nm_next, &t->nslist, pmix_nspace_caddy_t) {
++        pmix_list_remove_item (&t->nslist, &nm->super);
++        PMIX_RELEASE(nm);
++    }
+     PMIX_DESTRUCT(&t->nslist);
+ }
+ PMIX_CLASS_INSTANCE(pmix_server_trkr_t,","Just wondering - would it make more sense to simply replace `PMIX_DESTRUCT(&t->nslist)` with `PMIX_LIST_DESTRUCT(&t->nslist)` here, and then add `PMIX_RELEASE(p->jobbkt)` to the `pmix_nspace_caddy_t` destructor on line 154 of src/include/pmix_globals.c? Seems to me like we always want to have these things removed/destructed.",Check if the refcount is zero before dereferencing it.
+7285,"@@ -5,7 +5,13 @@
+ package net.sourceforge.pmd.lang.vf;
+
+ import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
++import net.sourceforge.pmd.lang.apex.rule.ApexXPathRule;
+
+ public class RuleSetFactoryTest extends AbstractRuleSetFactoryTest {
+-    // no additional tests
++    public RuleSetFactoryTest() {
++        super();
++        // Copied from net.sourceforge.pmd.lang.apex.RuleSetFactoryTest
++        // Apex rules are found in the classpath because this module has a dependency on pmd-apex
++        validXPathClassNames.add(ApexXPathRule.class.getName());
++    }
+ }","I think, we should fix/improve AbstractRuleSetFactoryTest. I guess, both apex and visualforce rules are now tested, which is unnecessary.",Apex rules are found in the classpath because this mod
+7286,"@@ -111,6 +111,14 @@ class BackendController extends ControllerBase
+         self::extendableExtendCallback($callback);
+     }
+
++    /**
++     * @inheritDoc
++     */
++    public function callAction($method, $parameters)
++    {
++        return parent::callAction($method, array_values($parameters));
++    }
++
+     /**
+      * Pass unhandled URLs to the CMS Controller, if it exists
+      *",In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or `call_user_func_array()` etc.,Is there a reason why you didn't use `self::callAction
+7287,"@@ -7,8 +7,10 @@ package javaslang.collection;
+
+ import javaslang.Function2;
+ import javaslang.Tuple2;
++import javaslang.control.Try;
+ import org.junit.Test;
+
++import java.lang.reflect.Field;
+ import java.util.List;
+ import java.util.Random;
+ import java.util.concurrent.ThreadLocalRandom;",easily possible to get that information without exposing internal information,Should be able to remove this unused import now.
+7288,"@@ -65,7 +65,13 @@ module Beaker
+           found_env_vars[:answers][key] = value if key.to_s =~ /q_/
+         end
+         found_env_vars[:consoleport] &&= found_env_vars[:consoleport].to_i
+-        found_env_vars[:type] = found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes' ? 'pe' : nil
++        if found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes'
++          found_env_vars[:type] = 'pe'
++        elsif found_env_vars[:is_pe] == 'false' || found_env_vars[:is_pe] == 'no'
++          found_env_vars[:type] = 'foss'
++        else
++          found_env_vars[:type] = nil
++        end
+         found_env_vars[:pe_version_file_win] = found_env_vars[:pe_version_file]
+         found_env_vars[:answers].delete_if {|key, value| value.nil? or value.empty? }
+         found_env_vars.delete_if {|key, value| value.nil? or value.empty? }","Why do we need tristate logic (pe, foss, nil)?",Use a guard clause instead of wrapping the code inside a conditional expression.
+7289,"@@ -19,13 +19,13 @@ import (
+
+ func TestBlocksAfterFlagTimeout(t *testing.T) {
+
+-	mu := sync.Mutex{}
++	mux := sync.Mutex{}
+ 	blocked := make(map[string]time.Duration)
+
+ 	mock := mockBlockLister(func(a swarm.Address, d time.Duration, r string) error {
+-		mu.Lock()
++		mux.Lock()
+ 		blocked[a.ByteString()] = d
+-		mu.Unlock()
++		mux.Unlock()
+
+ 		return nil
+ 	})",this change needs to be reverted to what is on `master`,Another `sync.Mutex` that could be used here.
+7290,"@@ -1076,9 +1076,14 @@ Blockly.WorkspaceSvg.prototype.deleteVariableById = function(id) {
+  * @package
+  */
+ Blockly.WorkspaceSvg.prototype.createVariable = function(name, opt_type, opt_id) {
++  var variableInMap = (this.getVariable(name) != null);
+   var newVar = Blockly.WorkspaceSvg.superClass_.createVariable.call(this, name,
+     opt_type, opt_id);
+-  this.refreshToolboxSelection_();
++  // For performance reaons, only refresh the the toolbox for new variables.
++  // Variables that already exist should already be there.
++  if (!variableInMap) {
++    this.refreshToolboxSelection_();
++  }
+   return newVar;
+ };
+ ",Do you still need to call the superclass `createVariable` if you've already determined that the variable exists?,"Nit: ""should"" => ""should""."
+7291,"@@ -281,7 +281,10 @@ type EachByPackResult struct {
+ }
+
+ // EachByPack returns a channel that yields all blobs known to the index
+-// grouped by packID but ignoring blobs with a packID in packPlacklist.
++// grouped by packID but ignoring blobs with a packID in packPlacklist for
++// finalized indexes.
++// This filtering is used when rebuilding the index where we need to ignore packs
++// from the finalized index which have been re-read into a non-finalized index.
+ // When the  context is cancelled, the background goroutine
+ // terminates. This blocks any modification of the index.
+ func (idx *Index) EachByPack(ctx context.Context, packBlacklist restic.IDSet) <-chan EachByPackResult {","Ignoring the pack entry from an existing entry but using the new entry from a non-finalized index, is subtle enough that it needs explaining.",> This filtering is used when rebuilding the index where we need to ignore packs
+7292,"@@ -236,9 +236,12 @@ uint32_t Spells::getInstantSpellCount(const Player* player) const
+
+ InstantSpell* Spells::getInstantSpellById(uint32_t spellId)
+ {
+-	auto it = std::next(instants.begin(), std::min<uint32_t>(spellId, instants.size()));
+-	if (it != instants.end()) {
+-		return it->second;
++	uint32_t count = 0;
++	for (const auto& it : instants) {
++		if (count == spellId) {
++			return it.second;
++		}
++		++count;
+ 	}
+ 	return nullptr;
+ }","This is a revert, is it really an issue?",Here you can just use `for (auto it : instants)`
+7293,"@@ -26,8 +26,7 @@ namespace OpenTelemetry.Trace
+     using OpenTelemetry.Trace.Export;
+     using OpenTelemetry.Trace.Internal;
+
+-    /// <inheritdoc/>
+-    public class SpanBuilder : ISpanBuilder
++    /*public class SpanBuilder
+     {
+         private readonly SpanProcessor spanProcessor;
+         private readonly TracerConfiguration tracerConfiguration;",can we delete this file altogether?,Can we remove this?
+7294,"@@ -59,7 +59,9 @@ func InitCoverage(name string) {
+ 	}
+
+ 	// Set up the unit test framework with the required arguments to activate test coverage.
+-	flag.CommandLine.Parse([]string{""-test.coverprofile"", tempCoveragePath()})
++	if err := flag.CommandLine.Parse([]string{""-test.coverprofile"", tempCoveragePath()}); err != nil {
++		panic(err)
++	}
+
+ 	// Begin periodic logging
+ 	go wait.Forever(FlushCoverage, flushInterval)",Suggestion: log some additional info here so we know where we are i.e 'Failed to prepare coverage framework..',"Could we do `assert.NoError(t, err)` instead?"
+7295,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace
++{
++    internal static class TracerConstants
++    {
++        public const string Language = ""dotnet"";
++    }
++}","There didn't seem to be any good place to put constants that are .NET Tracer-specific, so I created this internal static class. If there's a better place, let me know.","Just a thought, what do you think about calling "
+7296,"@@ -0,0 +1,19 @@
++package config
++
++import (
++	""github.com/kubeedge/beehive/pkg/common/config""
++	""github.com/kubeedge/beehive/pkg/common/log""
++	""github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants""
++)
++
++// UpdateDeviceStatusBuffer is the size of channel which save update device status message from edge
++var UpdateDeviceStatusBuffer int
++
++func init() {
++	if psb, err := config.CONFIG.GetValue(""devicecontroller.update-device-status-buffer"").ToInt(); err != nil {
++		UpdateDeviceStatusBuffer = constants.DefaultUpdateDeviceStatusBuffer
++	} else {
++		UpdateDeviceStatusBuffer = psb
++	}
++	log.LOGGER.Infof(""update device status buffer: %d"", UpdateDeviceStatusBuffer)
++}",Log message should be started with upper-case word.,"I would suggest to set it to a constant, e.g. `DefaultUpdateDeviceStatusBuffer`."
+7297,"@@ -126,7 +126,7 @@ namespace NLog.Targets
+         /// Gets or sets the layout that renders event ID.
+         /// </summary>
+         /// <docgen category='Event Log Options' order='10' />
+-        public Layout EventId { get; set; }
++        public Layout<int> EventId { get; set; }
+
+         /// <summary>
+         /// Gets or sets the layout that renders event Category.",changes for example usage in this class,why the change here?
+7298,"@@ -1,4 +1,4 @@
+-define(['browser', 'css!./emby-collapse', 'registerElement', 'emby-button'], function (browser) {
++define(['browser', 'css!elements/emby-collapse/emby-collapse', 'registerElement', 'emby-button'], function (browser) {
+     'use strict';
+
+     var EmbyButtonPrototype = Object.create(HTMLDivElement.prototype);","I know frameworks that support current directory when loading dependencies, is this a limitation of the requirejs loader or can we fix it somehow?","This is a pretty subtle change in behavior, but I don't think it's necessary. Di"
+7299,"@@ -164,6 +164,10 @@ func (a *FakeWebAPI) AddApplication(ctx context.Context, req *webservice.AddAppl
+ 	return &webservice.AddApplicationResponse{}, nil
+ }
+
++func (a *FakeWebAPI) EnableApplication(ctx context.Context, req *webservice.EnableApplicationRequest) (*webservice.EnableApplicationResponse, error) {
++	return &webservice.EnableApplicationResponse{}, nil
++}
++
+ func (a *FakeWebAPI) DisableApplication(ctx context.Context, req *webservice.DisableApplicationRequest) (*webservice.DisableApplicationResponse, error) {
+ 	return &webservice.DisableApplicationResponse{}, nil
+ }",`ctx` is unused in EnableApplication,"FakeWebAPI already has a mock `EnableApplication`, so no need to pass it in."
+7300,"@@ -139,6 +139,8 @@ static const char* generate_multi_dot_name(ast_t* ast, ast_t** def_found) {
+
+     default:
+     {
++      if (def == NULL)
++        return stringtab("""");
+       pony_assert(0);
+     }
+   }","@jemc , this is one change needed in `generate_multi_dot_name`. I believe this * will do no harm to working pony code: The new code was added in a place where it is throwing an assert. So no working code will get affected. * is in sync with the rest of the method: if the parent ast node has null `data`, we are supposed to return empty string. That is possible when we have expressions wrapped in braces.",Shouldn't this be `pony_assert(0);` ?
+7301,"@@ -88,6 +88,7 @@ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+ import static org.apache.solr.common.params.CommonParams.SORT;
++import static org.apache.solr.common.params.QueryElevationParams.ONLY_ELEVATED_REPRESENTATIVE;
+
+ /**
+ ",Should not be a static import.,I think there is a typo here: `onlyEL
+7302,"@@ -288,13 +288,13 @@ func (client *APIECSClient) getCustomAttributes() []*ecs.Attribute {
+
+ func (client *APIECSClient) SubmitTaskStateChange(change api.TaskStateChange) error {
+ 	// Submit attachment state change
+-	if change.Attachments != nil {
++	if change.Attachment != nil {
+ 		var attachments []*ecs.AttachmentStateChange
+
+-		eniStatus := change.Attachments.Status.String()
++		eniStatus := change.Attachment.Status.String()
+ 		attachments = []*ecs.AttachmentStateChange{
+ 			{
+-				AttachmentArn: &change.Attachments.AttachmentArn,
++				AttachmentArn: &change.Attachment.AttachmentARN,
+ 				Status:        &eniStatus,
+ 			},
+ 		}",should we be using `aws.String` here? it seems there are a few other spots we could use `aws.String` in the `if change.Attachment != nil { ...` block.,This could be `change.Attachments.Sta
+7303,"@@ -66,7 +66,9 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
+
+ 		return {
+ 			isAdSenseLinked: select( MODULES_ANALYTICS ).getAdsenseLinked(),
+-			analyticsMainURL: select( MODULES_ANALYTICS ).getServiceURL(),
++			analyticsMainURL: select( MODULES_ANALYTICS ).getServiceReportURL( 'content-publisher-overview', {
++				'_u.date00': startDate, '_u.date01': endDate,
++			} ),
+ 			data: select( MODULES_ANALYTICS ).getReport( args ),
+ 			error: select( MODULES_ANALYTICS ).getErrorForSelector( 'getReport', [ args ] ),
+ 			loading: ! select( MODULES_ANALYTICS ).hasFinishedResolution( 'getReport', [ args ] ),","We can't pass raw dates like this because they need to be formatted as `YYYYMMDD` as noted in the IB. We added the `generateDateRangeArgs` utilities to handle this for us, as well as abstracting the relationship between arg name and specific dates which is not obvious just by looking at it. Let's update it to use `generateDateRangeArgs( { startDate, endDate } )` instead   Use care to make sure we're sourcing the utility from Analytics utils though since AdSense has its own version by the same name, which is different.",do we need to escape these?
+7304,"@@ -313,6 +313,8 @@ class worker(Config):
+     no_install_shutdown_handler = BoolParameter(default=False,
+                                                 description='If true, the SIGUSR1 shutdown handler will'
+                                                 'NOT be install on the worker')
++    save_summary_data = BoolParameter(default=True, description='If true, save data required for '
++                                      'execution summary')
+
+
+ class KeepAliveThread(threading.Thread):",`default=True` shouldn't be used for BoolParameters iirc.,"""If true, save data required for execution summary"" sounds a bit clumsy. What do you mean by ""If true, save data required for execution""?"
+7305,"@@ -35,6 +35,10 @@ func parsePrettyFormatLog(repo *Repository, logByts []byte) (*list.List, error)
+ }
+
+ func RefEndName(refStr string) string {
++	if strings.HasPrefix(refStr, ""refs/heads/"") {
++		return strings.TrimPrefix(refStr, ""refs/heads/"")
++	}
++
+ 	index := strings.LastIndex(refStr, ""/"")
+ 	if index != -1 {
+ 		return refStr[index+1:]",It would be better to use `return refStr[12:]`. or `11`... I have problem with counting..,I think we should trim the end of `refs/heads/` if we're not using it as a end name. I don't think there's any harm in trimming it if it
+7306,"@@ -211,9 +211,7 @@ func ruleHash(state *core.BuildState, target *core.BuildTarget, runtime bool) []
+ 	for _, licence := range target.Licences {
+ 		h.Write([]byte(licence))
+ 	}
+-	for _, output := range target.TestOutputs {
+-		h.Write([]byte(output))
+-	}
++
+ 	for _, output := range target.OptionalOutputs {
+ 		h.Write([]byte(output))
+ 	}",Pretty sure these should only contribute to the runtime hash.,This was removed because it isn't necessary.
+7307,"@@ -1,4 +1,4 @@
+-<div id=""ncr-layout"">
++<div id=""gsa18f-layout"">
+   <table class=""w-container main-container"" width='800'>
+     <tr>
+       <td>","Just verifying: this change doesn't break the 18f layout, right?",Can we change this to `ncr-layout` please?
+7308,"@@ -120,14 +120,6 @@ func (c call) endStats(elapsed time.Duration, err error, isApplicationError bool
+ 			counter.Inc()
+ 		}
+ 		return
+-	case yarpcerrors.CodeOK:
+-		// If we got ""CodeOK"" it really means that this is not a yarpcError, in
+-		// which case this is another level of ""unknown"" error.
+-		c.edge.serverErrLatencies.Observe(elapsed)
+-		if counter, err := c.edge.serverFailures.Get(""unknown_internal_yarpc""); err == nil {
+-			counter.Inc()
+-		}
+-		return
+ 	}
+ 	// If this code is executed we've hit an error code outside the usual error
+ 	// code range, so we'll just log the string representation of that code.","we should keep this counter using the ""isYarpcError"" api",I don't understand why this is deleted?
+7309,"@@ -28,16 +28,16 @@ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.StructLike;
+ import org.apache.iceberg.relocated.com.google.common.base.Objects;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+ import org.apache.iceberg.types.Types;
+ import org.apache.iceberg.types.Types.StructType;
++import org.apache.iceberg.util.CaseInsensitiveMap;
+
+ public class GenericRecord implements Record, StructLike {
+   private static final LoadingCache<StructType, Map<String, Integer>> NAME_MAP_CACHE =
+       Caffeine.newBuilder()
+       .weakKeys()
+       .build(struct -> {
+-        Map<String, Integer> idToPos = Maps.newHashMap();
++        Map<String, Integer> idToPos = new CaseInsensitiveMap<>();
+         List<Types.NestedField> fields = struct.fields();
+         for (int i = 0; i < fields.size(); i += 1) {
+           idToPos.put(fields.get(i).name(), i);","Could we just use case insensitive strings as keys instead of creating a new map implementation? e.g. simply using a treemap with a comparator `Map<String, Integer> idToPos = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);` could work I think",Could we have a test for this as well?
+7310,"@@ -67,7 +67,14 @@ namespace OpenTelemetry.Context
+         /// <returns>The slot previously registered.</returns>
+         public static RuntimeContextSlot<T> GetSlot<T>(string name)
+         {
+-            return (RuntimeContextSlot<T>)Slots[name];
++            if (Slots.TryGetValue(name, out var slot) && slot is RuntimeContextSlot<T> expectedSlot)
++            {
++                return expectedSlot;
++            }
++            else
++            {
++                return null;
++            }
+         }
+
+         /*",I think this should be a throw. Or the method should be TryGetSlot?,Would it make sense to assert that the
+7311,"@@ -3991,7 +3991,15 @@ int LuaScriptInterface::luaGameLoadMap(lua_State* L)
+ {
+ 	// Game.loadMap(path)
+ 	const std::string& path = getString(L, 1);
+-	g_dispatcher.addTask(createTask(std::bind(&Game::loadMap, &g_game, path)));
++	g_dispatcher.addTask(createTask( [path]() {
++		try {
++			g_game.loadMap(path);
++		} catch (const std::exception& e) {
++			// FIXME: Should only catch some exceptions
++			std::cout << ""[Error - LuaScriptInterface::luaGameLoadMap] Failed to load map: ""
++				<< e.what() << std::endl;
++		}
++	}));
+ 	return 0;
+ }
+ ","We don't usually put spaces between ( and [, and I think `path` should be passed by reference.",e.what -> e.what
+7312,"@@ -419,12 +419,11 @@ int Zone::SaveTempItem(uint32 merchantid, uint32 npcid, uint32 item, int32 charg
+ 				if (!ml.origslot) {
+ 					ml.origslot = ml.slot;
+ 				}
+-
+-				if (charges > 0) {
++				bool IsStackable = database.GetItem(item)->Stackable;
++				if ((IsStackable && charges > 0) || (!IsStackable && sold)) {
+ 					database.SaveMerchantTemp(npcid, ml.origslot, item, ml.charges);
+ 					tmp_merlist.push_back(ml);
+-				}
+-				else {
++				} else {
+ 					database.DeleteMerchantTemp(npcid, ml.origslot);
+ 				}
+ 			}",Make sure to `snake_case` locally scoped variable names in the future,The `sold` parameter is now unused and can be removed.
+7313,"@@ -56,6 +56,7 @@ type LogsConfig struct {
+ // RoutingRule holds the path to route requests to the service.
+ type RoutingRule struct {
+ 	Path string `yaml:""path""`
++	HealthCheckPath string `yaml:""healthcheck""`
+ }
+
+ // AutoScalingConfig is the configuration to scale the service with target tracking scaling policies.",Maybe we should use underscores like `health_check` - what do you think?,"The yaml here is ""path"" instead of ""healthcheck"""
+7314,"@@ -139,6 +139,12 @@ func (v *volumeAPIOpsV1alpha1) read(volumeName string) (*v1alpha1.CASVolume, err
+ 		vol.Namespace = hdrNS
+ 	}
+
++	// use sc name from header if present
++	scName := v.req.Header.Get(string(v1alpha1.StorageClassKey))
++	if scName != """" {
++		vol.Annotations[string(v1alpha1.StorageClassKey)] = scName
++	}
++
+ 	vOps, err := volume.NewVolumeOperation(vol)
+ 	if err != nil {
+ 		return nil, CodedError(400, err.Error())",Do a TrimSpace before setting.,is there a reason we can't use `v1.StorageClassKey` as
+7315,"@@ -41,6 +41,9 @@ type ENI struct {
+
+ 	// PrivateDNSName is the dns name assigned by the vpc to this eni
+ 	PrivateDNSName string `json:"",omitempty""`
++	// SubnetGatewayIPV4Address is the address to the subnet gateway for
++	// the eni
++	SubnetGatewayIPV4Address string `json:"",omitempty""`
+ }
+
+ // GetIPV4Addresses returns a list of ipv4 addresses allocated to the ENI","Are the fields in this struct grouped by IP address family or by function? There are separate fields for IPv4Addresses and IPv6Addresses, but a single field for DomainNameServers. Should this new field be named SubnetGatewayAddress with type array consisting of both IPv4 and IPv6 gateways?",Does this need to be a pointer since it is optional?
+7316,"@@ -38,7 +38,7 @@ class LinkTest < ActiveSupport::TestCase
+       new_link.revive_or_create
+     end
+
+-    deleted_link = Link.find(link)
++    deleted_link = Link.where(id: link.id).first
+     deleted_link.title.must_equal new_title
+     deleted_link.link_category_id.must_equal Link::CATEGORIES[:Forums]
+   end",.find(id) is being deprecated to Rails 5.,Prefer `find_by` over `where...first`.<br>Line is too long. [82/80]
+7317,"@@ -4,6 +4,9 @@ import datetime
+ from itertools import product
+
+ import iris
++from iris.coords import DimCoord
++from iris.cube import CubeList
++from iris.experimental.equalise_cubes import equalise_attributes
+ from iris.util import guess_coord_axis
+
+ import numpy as np",Will be good to have the iris interface moved to geoviews. Could this be done for 1.10.6?,This line needs to be removed.
+7318,"@@ -152,7 +152,10 @@ func (cs *ClientServerImpl) Connect() error {
+ 	request, _ := http.NewRequest(""GET"", parsedURL.String(), nil)
+
+ 	// Sign the request; we'll send its headers via the websocket client which includes the signature
+-	utils.SignHTTPRequest(request, cs.AgentConfig.AWSRegion, ServiceName, cs.CredentialProvider, nil)
++	err = utils.SignHTTPRequest(request, cs.AgentConfig.AWSRegion, ServiceName, cs.CredentialProvider, nil)
++	if err != nil {
++		return err
++	}
+
+ 	timeoutDialer := &net.Dialer{Timeout: wsConnectTimeout}
+ 	tlsConfig := &tls.Config{ServerName: parsedURL.Host, InsecureSkipVerify: cs.AgentConfig.AcceptInsecureCert}",does this get wrapped in the calling method?,This should just be `return err`
+7319,"@@ -195,6 +195,8 @@ class DictAuth(unittest.TestCase):
+             subprocess.check_output(
+                 store_cmd, encoding=""utf-8"", errors=""ignore"")
+
++    # TODO: This test should not test case-insensivity, only the successful
++    # group authorization. The permission tests should do that.
+     def test_group_auth(self):
+         """"""
+         Test for case insensitive group comparison at authorization.","Do we still need this test case? If your new test cases test this, then we can remove it.",Nit: the permission tests should do more than just testing the case
+7320,"@@ -641,6 +641,15 @@ class Plan < ActiveRecord::Base
+     User.joins(:roles).where('roles.plan_id = ? AND roles.access IN (?)', self.id, vals).first
+   end
+
++  ##
++  # returns the shared roles of a plan, excluding the creator
++  def shared
++    role_values = Role.access_values_for(:commenter)
++                      .concat(Role.access_values_for(:editor))
++                      .concat(Role.access_values_for(:administrator)).uniq! - Role.access_values_for(:creator)
++    Role.where(plan: self, access: role_values)
++  end
++
+   ##
+   # the owner and co-owners of the project
+   #","If you want to express ""any role that is not creator"" you could use the following statement: Role.where(plan: self).where(Role.not_creator_condition).any? which would be less verbose and a bit more efficient if it is used for Yes/No shared?",Redundant `self` detected.
+7321,"@@ -188,14 +188,12 @@ func migrateJSONFile(from, to string) (bool, error) {
+ 		if len(chain) == 0 {
+ 			return nil, nil
+ 		}
+-		// The chain is in one of three states:
++		// The chain is in one of two states:
+ 		// 1) single self-signed cert
+-		// 2) single upstream-signed cert, implying upstream_bundle=false
+-		// 3) an upstream-signed cert followed by any intermediates and a root
++		// 2) an upstream-signed cert followed by any intermediates and a root
+ 		//
+-		// The ca should only be considered an ""intermediate"" in case #3, so a
+-		// check for more than one cert should be sufficient for that. However
+-		// we don't want the the root in the chain anymore, so remove it.
++		// In the case where the CA is an intermediate, we don't want to store
++		// the root, so remove it.
+ 		certificate := chain[0].Raw
+ 		var upstreamChain [][]byte
+ 		if len(chain) > 1 {",Do we need any update on the test side?,"The CA is an intermediate,"
+7322,"@@ -4663,6 +4663,10 @@ func (fbo *folderBranchOps) notifyOneOpLocked(ctx context.Context,
+ 			return nil
+ 		}
+ 	}
++	// Cancel any block prefetches for unreferenced blocks.
++	for _, ptr := range op.Unrefs() {
++		fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)
++	}
+
+ 	fbo.observers.batchChanges(ctx, changes)
+ 	return nil",There's a few `return nil` cases above this -- we should probably move this above the big switch.,I think we need to also ca
+7323,"@@ -33,6 +33,19 @@ func (tile TransactionInLedgerError) Error() string {
+ 	return fmt.Sprintf(""transaction already in ledger: %v"", tile.Txid)
+ }
+
++// LeaseInLedgerError is returned when a transaction cannot be added because it has a lease that already being used in the relavant rounds
++type LeaseInLedgerError struct {
++	txid  transactions.Txid
++	lease txlease
++}
++
++// Error implements the error interface for the LeaseInLedgerError stuct
++func (lile LeaseInLedgerError) Error() string {
++	// format the lease as address.
++	addr := basics.Address(lile.lease.lease)
++	return fmt.Sprintf(""transaction %v using an overlapping lease %s"", lile.txid, addr.String())
++}
++
+ // BlockInLedgerError is returned when a block cannot be added because it has already been done
+ type BlockInLedgerError struct {
+ 	LastRound basics.Round",`lile *LeaseInLedgerError` to reduce copying?,This is only used in test.
+7324,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent,would it make sense to move this to `/se/grid/newsessionqueuer/queue`?
+7325,"@@ -35,9 +35,9 @@ namespace Microsoft.VisualStudio.TestPlatform.Utilities.Helpers
+         }
+
+         /// <inheritdoc/>
+-        public Stream GetStream(string filePath, FileMode mode)
++        public Stream GetStream(string filePath, FileMode mode, FileAccess access = FileAccess.ReadWrite)
+         {
+-            return new FileStream(filePath, mode);
++            return new FileStream(filePath, mode, access);
+         }
+
+         /// <inheritdoc/>","We don't have a requirement anywhere in Test Platform for GetStream() with write access. It is ok to directly change `return new FileStream(filePath, mode, FileAccess.Read)`.",API Change : The `FileAccess` enum value for GetStream(string filePath
+7326,"@@ -22,12 +22,17 @@
+ import os
+ import os.path
+ import textwrap
++import string
++import functools
++import operator
+
+ import attr
+ import yaml
+ import pytest
+ import bs4
+
++import qutebrowser.browser.hints
++
+
+ def collect_tests():
+     basedir = os.path.dirname(__file__)",FWIW `from qutebrowser.browser import hints` is okay - it's just things like `from qutebrowser.browser.hints import HintManager` I try to avoid.,`from functools import partial`?
+7327,"@@ -11,7 +11,12 @@
+ namespace HFG;
+
+ use HFG\Core\Builder\Header as HeaderBuilder;
++
++$transparent_header_class = '';
++if ( get_theme_mod( 'neve_transparent_header', false ) ) {
++	$transparent_header_class = ' neve-tansparent-header';
++}
+ ?>
+-<div id=""header-grid""  class=""<?php echo esc_attr( get_builder( HeaderBuilder::BUILDER_NAME )->get_property( 'panel' ) ); ?> site-header"">
++<div id=""header-grid""  class=""<?php echo esc_attr( get_builder( HeaderBuilder::BUILDER_NAME )->get_property( 'panel' ) ) . esc_attr( $transparent_header_class ); ?> site-header"">
+ 	<?php render_builder( HeaderBuilder::BUILDER_NAME ); ?>
+ </div>","@preda-bogdan let's use a filter for the header classes, something like, hfg_header_classes where we hook this logic, in neve pro",Doesn't `$transparent_header_class` have to be defined here as well?
+7328,"@@ -21,7 +21,7 @@ import (
+ 	""time""
+
+ 	""github.com/containernetworking/plugins/pkg/ip""
+-	""k8s.io/api/core/v1""
++	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/labels""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+ 	""k8s.io/client-go/informers""",Out of curiosity.. is there a rule to determine the package name as prevDirectory+currentDirectory.,`corev1` is the preferred name of this alias.
+7329,"@@ -53,7 +53,9 @@ get_xmm_vals(priv_mcontext_t *mc)
+ #ifdef X86
+     if (preserve_xmm_caller_saved()) {
+         ASSERT(proc_has_feature(FEATURE_SSE));
+-        if (YMM_ENABLED())
++        if (ZMM_ENABLED())
++            get_zmm_caller_saved(&mc->simd[0]);
++        else if (YMM_ENABLED())
+             get_ymm_caller_saved(&mc->simd[0]);
+         else
+             get_xmm_caller_saved(&mc->simd[0]);",It seems this needs to check the lazy cxt switching flag. It is used on the initial thread for early injection and in other places where the lazy switch should apply.,Why do you need an `else if` here?
+7330,"@@ -21,9 +21,10 @@ import { isValidPropertyID } from './validation';
+ /**
+  * Parses the bits of a valid property ID into an object of its components.
+  *
++ * See: https://support.google.com/analytics/answer/7372977.
++ *
+  * @since 1.8.0
+  *
+- * @see {@link https://support.google.com/analytics/answer/7372977}
+  * @param {string} propertyID Property ID to parse.
+  * @return {(Object|undefined)} Object of property ID components if valid, otherwise false.
+  */",Why not use the JSdoc annotation as it did before?,nit: `{@link ...}`
+7331,"@@ -108,7 +108,11 @@ public class ParseUtil {
+     String version = packageImplementationVersion;
+     String edition = ProcessEngineDetails.EDITION_COMMUNITY;
+
+-    if (version != null && version.contains(""-ee"")) {
++    if (version == null){
++      version = ProductPropertiesUtil.getProductVersion();
++    }
++
++    if (version.contains(""-ee"")) {
+       edition = ProcessEngineDetails.EDITION_ENTERPRISE;
+       if (trimSuffixEE) {
+         version = version.replace(""-ee"", """"); // trim `-ee` suffix",Why don't we drop the packageImplementationVersion in general? That way the version will be fetch all that time only from the properties file and it will be consistent.,This could be replaced by `version = ProductP
+7332,"@@ -1076,6 +1076,9 @@ class CppGenerator : public BaseGenerator {
+       code_ += ""  };"";
+     }
+
++    // Found fields with union type.
++    std::vector<const FieldDef*> union_fields;
++
+     // Generate the accessors.
+     for (auto it = struct_def.fields.vec.begin();
+          it != struct_def.fields.vec.end(); ++it) {","Please use the style of the rest of the code, a space between the type and `*`",Use a vector instead of a vector here. (The order of elements in the vector is not guaranteed.)
+7333,"@@ -25,6 +25,8 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+
+         private MockProcessManager mockProcessManager;
+
++
++
+         [TestInitialize]
+         public void TestInit()
+         {",nit: remove extra blank lines.,Nit: extra new line
+7334,"@@ -39,6 +39,7 @@ const (
+ 	appEnvOptionNone      = ""None (run in default VPC)""
+ 	defaultDockerfilePath = ""Dockerfile""
+ 	imageTagLatest        = ""latest""
++	taskGroupNameDefault  = ""copilot-task""
+ )
+
+ const (",nit: What do you think of `copilot-task-group`?,"The `taskGroupNameDefault` is already defined in `apimodel.go`, do we need this new one?"
+7335,"@@ -156,6 +156,7 @@ export function setProperty(dom, name, value, oldValue, isSvg) {
+  */
+ function eventProxy(e) {
+ 	this._listeners[e.type + false](options.event ? options.event(e) : e);
++	if (e.type === 'input' || e.type === 'change') this.value = this._prevValue || '';
+ }
+
+ function eventProxyCapture(e) {",We should check whether or not the input node has a value since we can just have an onChange on an uncontrolled component as well.,This won't work. `this._prevValue` will be null if `e.type === 'input'`
+7336,"@@ -13,7 +13,7 @@ how the API has changed as well as the range of API versions supported by this b
+ """"""
+
+ CURRENT = (buildVersion.version_year, buildVersion.version_major, buildVersion.version_minor)
+-BACK_COMPAT_TO = (2019, 3, 0)
++BACK_COMPAT_TO = (2021, 1, 0)
+ """"""
+ As BACK_COMPAT_TO is incremented, the changed / removed parts / or reasoning should be added below.
+ EG: (x, y, z): Large changes to speech.py",I think there should be some reasoning below this line about the version updating.,"Should this be (2021, 1, 0)?"
+7337,"@@ -371,6 +371,17 @@ static int on_body(h2o_http1client_t *client, const char *errstr)
+     return 0;
+ }
+
++static char compress_hint_to_enum(const char *val, size_t len)
++{
++    if (!strncasecmp(""ON"", val, len)) {
++        return H2O_COMPRESS_HINT_ENABLE;
++    }
++    if (!strncasecmp(""OFF"", val, len)) {
++        return H2O_COMPRESS_HINT_DISABLE;
++    }
++    return H2O_COMPRESS_HINT_AUTO;
++}
++
+ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *errstr, int minor_version, int status,
+                                        h2o_iovec_t msg, h2o_http1client_header_t *headers, size_t num_headers)
+ {","Please use `h2o_lcstris` instead of `strncasecmp` so that the comparison would be a complete match (instead of a prefix match; current code would yield true if [val,len] is [""O"", 1]) and that it would be locale-independent.",`s/on/off/` ? no need for up
+7338,"@@ -333,7 +333,13 @@ var _ fbmHelper = (*folderBranchOps)(nil)
+ // newFolderBranchOps constructs a new folderBranchOps object.
+ func newFolderBranchOps(config Config, fb FolderBranch,
+ 	bType branchType) *folderBranchOps {
+-	nodeCache := newNodeCacheStandard(fb)
++	var nodeCache NodeCache
++	if config.Mode() != InitMinimal {
++		nodeCache = newNodeCacheStandard(fb)
++	} else {
++		// If we're in minimal mode, let the block cache remain nil to
++		// ensure that the user doesn't try any data reads or writes.
++	}
+
+ 	// make logger
+ 	branchSuffix := """"",I prefer if possible for `if`/`else` statements to have the positive case first.,This is the only place where
+7339,"@@ -33,9 +33,18 @@ from scapy.base_classes import BasePacketList
+ ## Tools ##
+ ###########
+
++def issubtype(x, t):
++    """"""issubtype(C, B) -> bool
++
++    Return whether C is a class and if it is a subclass of class B.
++    When using a tuple as the second argument issubtype(X, (A, B, ...)),
++    is a shortcut for issubtype(X, A) or issubtype(X, B) or ... (etc.).
++    """"""
++    return isinstance(x, type) and issubclass(x, t)
++
+ def get_temp_file(keep=False, autoext=""""):
+     """"""Create a temporary file and return its name. When keep is False,
+-the file is deleted when scapy exits.
++    the file is deleted when scapy exits.
+
+     """"""
+     fname = tempfile.NamedTemporaryFile(prefix=""scapy"", suffix=autoext,",Docstring would be nice,I think this should be `issu
+7340,"@@ -23,6 +23,7 @@ import org.gradle.api.provider.ListProperty;
+ public class BaselineErrorProneExtension {
+     private static final ImmutableList<String> DEFAULT_PATCH_CHECKS = ImmutableList.of(
+             // Baseline checks
++            ""CatchBlockLogException"",
+             ""ExecutorSubmitRunnableFutureIgnored"",
+             ""LambdaMethodReference"",
+             ""OptionalOrElseMethodInvocation"",",Low risk to fix this by default because existing baseline consumers pass this check. We don't attempt to fix checks that have been opted out of.,is this an accidental change?
+7341,"@@ -77,7 +77,16 @@ void OpenMPTargetInternal::impl_finalize() {
+     Kokkos::kokkos_free<Kokkos::Experimental::OpenMPTargetSpace>(
+         space.m_uniquetoken_ptr);
+ }
+-void OpenMPTargetInternal::impl_initialize() { m_is_initialized = true; }
++void OpenMPTargetInternal::impl_initialize() {
++  m_is_initialized = true;
++
++  // FIXME_OPENMPTARGET:  Only fix the number of teams for NVIDIA architectures.
++#if defined(KOKKOS_ARCH_VOLTA70) || defined(KOKKOS_ARCH_PASCAL60)
++#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300)
++  omp_set_num_teams(512);
++#endif
++#endif
++}
+ int OpenMPTargetInternal::impl_is_initialized() {
+   return m_is_initialized ? 1 : 0;
+ }","What about `VOLTA72`, `TURING75`, `AMPERE80` and `AMPERE86`? We only want to set the number of teams for these two architectures or for all the architectures newer than Maxwell?",Why not just set the number o
+7342,"@@ -1,7 +1,7 @@
+ # model settings
+ model = dict(
+     type='FasterRCNN',
+-    pretrained='modelzoo://resnet50',
++    pretrained='torchvision://resnet50',
+     backbone=dict(
+         type='ResNet',
+         depth=50,","Since we have specified `load_from`, `pretrained` can be left None.",torchvision is the default he
+7343,"@@ -71,6 +71,9 @@ func logParse(c *caddy.Controller) ([]*Rule, error) {
+ 				},
+ 				Format: DefaultLogFormat,
+ 			})
++		} else if len(args) > 3 {
++			// Maxiumum number of args in log directive is 3.
++			return nil, c.ArgErr()
+ 		} else {
+ 			// Path scope, output file, and maybe a format specified
+ ",I prefer to translate these `else if` into `switch` for more readability.,"""Maxiumum number of args in l"
+7344,"@@ -3,12 +3,13 @@ class Api::V1::StatusesController < ApiController
+
+   def create
+     exercise.statuses.create!(user: resource_owner, state: params[:state])
++    exercise.update_trails_state_for(resource_owner)
+     render nothing: true
+   end
+
+   private
+
+   def exercise
+-    Exercise.find_by!(uuid: params[:exercise_uuid])
++    @exercise ||= Exercise.find_by!(uuid: params[:exercise_uuid])
+   end
+ end",This can also be a local variable in `create`.,"This should be after the `create!` action, so if the `state` param is set, it won't be updated."
+7345,"@@ -1273,6 +1273,19 @@ func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err e
+ 			}
+ 		}
+
++		// Create/Remove git-daemon-export-ok for git-daemon...
++		daemonExportFile := strings.Join([]string{repo.RepoPath(), `git-daemon-export-ok`}, ""/"")
++		if repo.IsPrivate {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			os.Remove(daemonExportFile)
++		} else {
++			// NOTE: Gogs only cares to check errors so we don't get other errors by closing a file that isn't open...
++			f, err := os.Create(daemonExportFile)
++			if err == nil {
++				f.Close()
++			}
++		}
++
+ 		forkRepos, err := getRepositoriesByForkID(e, repo.ID)
+ 		if err != nil {
+ 			return fmt.Errorf(""getRepositoriesByForkID: %v"", err)",Why not use `path.Join`?,I think we should check for errors here - can we just pass the error down to `os.Remove`?
+7346,"@@ -7,4 +7,8 @@ if ( typeof global.googlesitekit === 'undefined' ) {
+ 	global.googlesitekit = {};
+ }
+
+-global.googlesitekit.api = API;
++if ( typeof global.googlesitekit.api === 'undefined' ) {
++	global.googlesitekit.api = API;
++}
++
++export * from 'assets/js/googlesitekit/api';",Why not `export default API` instead? This ensures we export the same that we export on the global.,"I'm not sure if this is the best way to do this, but I'm not sure if there's a better way."
+7347,"@@ -552,7 +552,7 @@ def imread(filename, pixel_type=None, fallback_only=False):
+         increase_dimension=False
+         kwargs={'FileName':filename}
+     if pixel_type:
+-        imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.ReadMode)
++        imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode)
+         if not imageIO:
+             raise RuntimeError(""No ImageIO is registered to handle the given file."")
+         imageIO.SetFileName(io_filename)",This is a good change I think. It greatly helps reduce name conflicts.,Are you planning to change `itk.ImageIOFactory.ReadMode` to `itk.ImageIOFactory.FileModeType_Re
+7348,"@@ -46,6 +46,12 @@ type jetStreamCluster struct {
+ 	consumerResults *subscription
+ }
+
++// Used to guide placement of streams in clustered JetStream.
++type Placement struct {
++	Cluster string   `json:""cluster""`
++	Tags    []string `json:""tags,omitempty""`
++}
++
+ // Define types of the entry.
+ type entryOp uint8
+ ","cluster not having omitempty, does this imply that cluster is required? seems empty is valid so just checking",Would it make sense to have this in the `pkg/stream/placement` package?
+7349,"@@ -758,3 +758,19 @@ func (c *Container) ShouldCreateWithSSMSecret() bool {
+ 	}
+ 	return false
+ }
++
++// MergeEnvironmentVariables appends additional envVarName:envVarValue pairs to
++// the the container's enviornment values structure
++func (c *Container) MergeEnvironmentVariables(secrets map[string]string) {
++	c.lock.Lock()
++	defer c.lock.Unlock()
++
++	// don't assume that the environment variable map has been initialized by others
++	if c.Environment == nil {
++		c.Environment = make(map[string]string)
++	}
++
++	for k, v := range secrets {
++		c.Environment[k] = v
++	}
++}","@aws/aws-ecs-agent, @yumex93: how concerned should we be about user provided envvar names clobbering existing envvars? i'm not convinced we should be doing additional validation here.","You don't need this check, right?"
+7350,"@@ -0,0 +1,14 @@
++'use strict';
++
++function defineAspects(operation, aspects) {
++  aspects = new Set(aspects);
++  Object.defineProperty(operation, 'aspects', {
++    value: aspects,
++    writable: false
++  });
++  return aspects;
++}
++
++module.exports = {
++  defineAspects
++};","nit: aspects are defined in `OperationBase`, should `defineAspects` live there as well?",missing space before `Object.defineProperty`
+7351,"@@ -5,12 +5,15 @@ from collections import OrderedDict
+
+ from kinto.core.permission import PermissionBase
+ from kinto.core.storage.postgresql.client import create_from_config
++from kinto.core.storage.postgresql.migrator import Migrator
+
+
+ logger = logging.getLogger(__name__)
+
++HERE = os.path.abspath(os.path.dirname(__file__))
+
+-class Permission(PermissionBase):
++
++class Permission(PermissionBase, Migrator):
+     """"""Permission backend using PostgreSQL.
+
+     Enable in configuration::",Why the `os.path.abspath`? `os.path.dirname` should always give a valid directory path.,"We don't need to import `Migrator` here, because `PermissionBase` is al"
+7352,"@@ -143,4 +143,8 @@ public class ControllerConfiguration {
+                 settingsConfiguration.settingsManager()
+         );
+     }
++
++    public String getWineEnginesPath() {
++        return this.wineEnginesPath;
++    }
+ }",I think we should not consider special engine types on this level. I would prefer to build the specific engine path based on `application.user.engines` later on.,I don't see where this is used.
+7353,"@@ -78,6 +78,12 @@ bool IndexPolicyMaker::buildPolicy() {
+         if (exist == scanItems_.end()) {
+             break;
+         }
++        // Stop build policy when last operator is range scan,
++        // And other fields will use expression filtering.
++        auto it = scanItems_.rbegin()->second;
++        if (it.endBound_.rel_ != RelationType::kEQRel) {
++            break;
++        }
+     }
+     // re-check operatorList_.
+     // if operatorList_ is not empty, that means there are still fields to filter",Is `rbegin` correct? We can't make sure that the last index column is the `rbegin` of `scanItems`.,I think you want to check `it.e
+7354,"@@ -108,6 +108,8 @@ func main() {
+ 		glog.Fatalln(""EVM Network ID is not set, call config.New() first"")
+ 	}
+
++	config.SetChainID(cfg.Chain.ID)
++
+ 	cfg.Genesis = genesisCfg
+ 	cfgToLog := cfg
+ 	cfgToLog.Chain.ProducerPrivKey = """"","check it is != 0, just like `EVMNetworkID` above",chain ID is already set in chai
+7355,"@@ -186,6 +186,8 @@ namespace OpenTelemetry
+             this.shutdownDrainTarget = this.circularBuffer.AddedCount;
+             this.shutdownTrigger.Set();
+
++            OpenTelemetrySdkEventSource.Log.DroppedExportProcessorItems(nameof(BatchExportProcessor<T>), typeof(T).Name, this.exporter.GetType().Name, this.droppedCount);
++
+             if (timeoutMilliseconds == Timeout.Infinite)
+             {
+                 this.exporterThread.Join();","if you just do ""this.GetType().Name"" and ""this.exporter.GetType().Name"", we get what we need.",Can you add a brief description
+7356,"@@ -26,16 +26,13 @@
+  */
+ package com.salesforce.androidsdk.rest;
+
+-import com.salesforce.androidsdk.R;
+-import com.salesforce.androidsdk.app.SalesforceSDKManager;
+
+ /**
+  * This is where all the API version info lives. This allows us to change one
+  * line here and affect all our api calls.
+  */
+ public class ApiVersionStrings {
+-    public static final String VERSION_NUMBER = SalesforceSDKManager.getInstance().
+-    		getAppContext().getResources().getString(R.string.api_version);
++    public static final String VERSION_NUMBER = ""v29.0"";
+     public static final String API_PREFIX = ""/services/data/"";
+     public static final String BASE_PATH = API_PREFIX + VERSION_NUMBER;
+     public static final String BASE_CHATTER_PATH = BASE_PATH + ""/chatter/"";","That's the code that would prevent any SalesforceSDKTest from running. At class loading time, SalesforceSDKManager.getInstance() would throw a RuntimeException because init() had never been called.",This should be a constant
+7357,"@@ -34,4 +34,6 @@ public interface DefinitionConst {
+   String VERSION_RULE_LATEST = ""latest"";
+
+   String VERSION_RULE_ALL = ""0.0.0+"";
++
++  String DEFAULT_REVISION = ""0"";
+ }","there is no ""DEFAULT_REVISION"" logic, no need to define this.",why is this needed?
+7358,"@@ -289,6 +289,9 @@ public class SalesforceSDKManager {
+                 loginOptions = new LoginOptions(url, getPasscodeHash(), config.getOauthRedirectURI(),
+                         config.getRemoteAccessConsumerKey(), config.getOauthScopes(), null, jwt);
+             }
++        } else {
++            loginOptions.setJwt(jwt);
++            loginOptions.setUrl(url);
+         }
+         return loginOptions;
+     }","so this is to fix a scenario where the app is first launched normally, then background and foreground through the link, we are not updating loginOption",Can you explain why this
+7359,"@@ -322,6 +322,14 @@ class Application extends BaseApplication {
+ 		});
+ 	}
+
++	checkLayout(layout) {
++		if (layout === 'viewer') {
++			this.focusElement_('noteTextViewer');
++		} else {
++			this.focusElement_('noteBody');
++		}
++	}
++
+ 	async updateMenu(screen) {
+ 		if (this.lastMenuScreen_ === screen) return;
+ ","It doesn't seem like the right way to implement this, because you add a new element that doesn't really exist (noteTextViewer). Instead you should modify the command handler `if (command.name === 'focusElement' && command.target === 'noteBody') {` in NoteText.jsx. Then focus either the editor or the viewer depending on what's currently visible.",There's no need for this
+7360,"@@ -21,7 +21,12 @@ package org.apache.iceberg.avro;
+
+ import com.google.common.base.Preconditions;
+ import com.google.common.collect.Lists;
++
++import java.util.HashSet;
++import java.util.LinkedList;
+ import java.util.List;
++import java.util.Set;
++
+ import org.apache.avro.LogicalType;
+ import org.apache.avro.LogicalTypes;
+ import org.apache.avro.Schema;",We don't add blank lines in imports.,Why are these imports needed?
+7361,"@@ -1,7 +1,7 @@
+ # -*- coding: UTF-8 -*-
+ #addonHandler.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2012-2018 Rui Batista, NV Access Limited, Noelia Ruiz Martínez, Joseph Lee, Babbage B.V.
++#Copyright (C) 2012-2019 Rui Batista, NV Access Limited, Noelia Ruiz Martínez, Joseph Lee, Babbage B.V.
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",Please add your name to the copyright list.,2019 in this file
+7362,"@@ -243,6 +243,11 @@ func (r *replacer) getSubstitution(key string) string {
+ 	case ""{path_escaped}"":
+ 		u, _ := r.request.Context().Value(OriginalURLCtxKey).(url.URL)
+ 		return url.QueryEscape(u.Path)
++	case ""{request_id}"":
++		reqid, _ := r.request.Context().Value(RequestIDCtxKey).(string)
++		if reqid != """" {
++			return reqid
++		}
+ 	case ""{rewrite_path}"":
+ 		return r.request.URL.Path
+ 	case ""{rewrite_path_escaped}"":","You can elide the `if` check for empty string, because if it's not a value that is set, the string will be empty anyway.","If the ID is empty, what's th"
+7363,"@@ -1,8 +1,8 @@
+ /*global countlyVue, CV, countlyCommon, Promise, moment*/
+ (function(countlyPushNotification) {
+
+-    var messagesSentLabel = CV.i18n('push-notification.time-chart-serie-messages-sent');
+-    var actionsPerformedLabel = CV.i18n('push-notification.time-chart-serie-actions-performed');
++    var messagesSentLabel = CV.i18n('push-notification.messages-sent-serie-name');
++    var actionsPerformedLabel = CV.i18n('push-notification.actions-performed-serie-name');
+
+     var StatusFinderHelper = {
+         STATUS_SHIFT_OPERATOR_ENUM: {",Different i18n keys. By mistake or on purpose?,I know it's not part of the s
+7364,"@@ -59,3 +59,18 @@ type SecretKeySelector struct {
+ const (
+ 	TLSCAKey = ""ca.crt""
+ )
++
++// Describes how the ACME challenge self check behaves when it fails.
++type ACMESelfCheckFailurePolicy string
++
++const (
++	// The default failure policy. This policy will cause the request to be
++	// sent to the certificate provider ONLY if the ACME challenge self check
++	// succeeds. The request is retried continuously and the `Certificate` will
++	// remain `Pending` indefinitely.
++	ACMESelfCheckFailurePolicyRetryForever ACMESelfCheckFailurePolicy = ""RetryForever""
++
++	// This policy will cause the ACME challenge self check response to be
++	// ignored and the request will always be sent to the certificate provider.
++	ACMESelfCheckFailurePolicyIgnore ACMESelfCheckFailurePolicy = ""Ignore""
++)","Given the description for this is `// Describes how the ACME challenge self check behaves when it fails.`, perhaps `RetryForever` is better terminology here as when the check fails, we don't just wait, we retry periodically.","""indefinitely"" -> ""indefinitely"""
+7365,"@@ -187,14 +187,14 @@ _ostree_gpg_verifier_check_signature (OstreeGpgVerifier  *self,
+           gpg_error = gpgme_data_new_from_fd (&kdata, fd);
+           if (gpg_error != GPG_ERR_NO_ERROR)
+             {
+-              ot_gpgme_error_to_gio_error (gpg_error, error);
++              ot_gpgme_throw (gpg_error, error, ""Loading data from fd %i"", fd);
+               goto out;
+             }
+
+           gpg_error = gpgme_op_import (result->context, kdata);
+           if (gpg_error != GPG_ERR_NO_ERROR)
+             {
+-              ot_gpgme_error_to_gio_error (gpg_error, error);
++              ot_gpgme_throw (gpg_error, error, ""import"");
+               goto out;
+             }
+         }",Nit: let's add a more descriptive prefix in line with the other ones? E.g. `Unable to import key` ?,Change from `ot_gpgme_error_to_g
+7366,"@@ -13,6 +13,7 @@ describe Bolt::SSH do
+   let(:user) { ENV['BOLT_SSH_USER'] || ""vagrant"" }
+   let(:password) { ENV['BOLT_SSH_PASSWORD'] || ""vagrant"" }
+   let(:port) { ENV['BOLT_SSH_PORT'] || 2224 }
++  let(:key) { ENV['BOLT_SSH_KEY'] || Dir["".vagrant/**/private_key""] }
+   let(:command) { ""pwd"" }
+   let(:ssh) { Bolt::SSH.new(hostname, port, user, password) }
+   let(:insecure) { { config: Bolt::Config.new(insecure: true) } }",This looks like it will pass an array as `:key` in the default case. That doesn't reflect how this will actually work in practice.,Rather than hard-coding a direct
+7367,"@@ -0,0 +1,11 @@
++#if NETFRAMEWORK
++namespace Datadog.Trace.IntegrationTests
++{
++    public static class Program
++    {
++        public static void Main()
++        {
++        }
++    }
++}
++#endif",Do we need this?,Would it make sense to add a sho
+7368,"@@ -282,6 +282,11 @@ func (b *ofFlowBuilder) MatchConjID(value uint32) FlowBuilder {
+ 	return b
+ }
+
++func (b *ofFlowBuilder) MatchPriority(priority uint16) FlowBuilder {
++	b.Match.Priority = priority
++	return b
++}
++
+ // MatchProtocol adds match condition for matching protocol type.
+ func (b *ofFlowBuilder) MatchProtocol(protocol Protocol) FlowBuilder {
+ 	switch protocol {","I am a bit confused about this function. If it is used to set priority, we actually use function ""Table.BuildFlow(priority uint16)"" to set the value. If it is used to parse the priority value, I think adding a property(if you don't want to consume Match.Priority directly) to cache it and consume that property should be simpler than using string regex.",I would suggest to have a `MatchPrioritySet` method in `pkg/util/flow_builder.go` for this sort of change.
+7369,"@@ -68,7 +68,7 @@ func main() {
+ }
+
+ // addUnresolvedPackage adds an unresolved node to the graph representing the
+-// packged described in the PackgetVer structure. Returns an error if the node
++// packaged described in the PackgetVer structure. Returns an error if the node
+ // could not be created.
+ func addUnresolvedPackage(g *pkggraph.PkgGraph, pkgVer *pkgjson.PackageVer) (newRunNode *pkggraph.PkgNode, err error) {
+ 	logger.Log.Debugf(""Adding unresolved %s"", pkgVer)","In this case we probably meant ""package"".","Nit: I would spell out ""packaged"""
+7370,"@@ -0,0 +1,19 @@
++const fs = require('fs');
++const { promisify } = require('util');
++const { dirname: getDirName } = require('path');
++const makeDir = require('make-dir');
++const writeFile = promisify(fs.writeFile);
++
++/**
++ * Create file with given contents at specified location
++ * @method createFile
++ * @param {String} path file path, inclusive of file name
++ * @param {String} content contents of the file
++ * @returns {Promise}
++ */
++const createFile = (path, content) =>
++	makeDir(getDirName(path)).then(() => writeFile(path, content));
++
++module.exports = {
++	createFile
++};",Just export `createFile` directly.,You don't need `createFile` here. `fs.writeFile` already creates a new file.
+7371,"@@ -175,6 +175,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Docker.ResultsTimeout = cli.Duration(20 * time.Second)
+ 	config.Docker.RemoveTimeout = cli.Duration(20 * time.Second)
+ 	config.Go.GoTool = ""go""
++	config.Go.BuildIdTool = ""//tools/go_buildid_replacer""
+ 	config.Go.CgoCCTool = ""gcc""
+ 	config.Go.GoPath = ""$TMP_DIR:$TMP_DIR/src:$TMP_DIR/$PKG_DIR:$TMP_DIR/third_party/go:$TMP_DIR/third_party/""
+ 	config.Python.PipTool = ""pip3""",This probably needs to get shipped with plz; you shouldn't have to redefine it within the user's repo. It should use `defaultPath` like the other things up the top of the file.,@jsoriano is it possible to change the default from `//tools/go_buildid_replacer` to `//tools/go_buildid_r
+7372,"@@ -4,7 +4,7 @@ var run = function() {
+   var WalletKey = bitcore.WalletKey;
+   var Builder = bitcore.TransactionBuilder;
+   var opts = {
+-    network: networks.testnet
++    network: networks['btc'].testnet
+   };
+
+   console.log('## Network: ' + opts.network.name);",interface for bitcoin should not change if possible. i.e: networks.testnet should return networks['btc'].testnet,are you sure this is enough? have you tested with multiple testnet?
+7373,"@@ -12,6 +12,7 @@ import (
+ 	""fmt""
+ 	""math/big""
+ 	""syscall""
++	""io/ioutil""
+
+ 	""github.com/golang/protobuf/proto""
+ 	""github.com/spf13/cobra""",File is not `gofmt`-ed with `-s` (from `gofmt`),This import should go at the top with the other standard library im
+7374,"@@ -929,3 +929,17 @@ void wlr_surface_send_leave(struct wlr_surface *surface,
+ 		}
+ 	}
+ }
++
++static inline int64_t timespec_to_msec(const struct timespec *a) {
++	return (int64_t)a->tv_sec * 1000 + a->tv_nsec / 1000000;
++}
++
++void wlr_surface_send_frame_done(struct wlr_surface *surface,
++		const struct timespec *when) {
++	struct wlr_frame_callback *cb, *cnext;
++	wl_list_for_each_safe(cb, cnext, &surface->current->frame_callback_list,
++			link) {
++		wl_callback_send_done(cb->resource, timespec_to_msec(when));
++		wl_resource_destroy(cb->resource);
++	}
++}",We have this functions in a couple of places. It should probably live in util or something.,This can be replaced with `wl_callback_send_frame_done(cb->resource
+7375,"@@ -53,6 +53,7 @@ module Mongoid
+                 # The associated object will be replaced by the below update if non-nil, so only
+                 # run the callbacks and state-changing code by passing persist: false in that case.
+                 _target.destroy(persist: !replacement) if persistable?
++                _target.new_record = true
+               end
+               unbind_one
+               return nil unless replacement",maybe this should be inside the destroy?,"If this is the only place where we set `_target.new_record`, should"
+7376,"@@ -106,10 +106,17 @@ class RPN(BaseDetector):
+             list[np.ndarray]: proposals
+         """"""
+         x = self.extract_feat(img)
++        # get origin input shape to onnx dynamic input shape
++        import torch
++        if torch.onnx.is_in_onnx_export():
++            img_shape = torch._shape_as_tensor(img)[2:]
++            img_metas[0]['img_shape_for_onnx'] = img_shape
+         proposal_list = self.rpn_head.simple_test_rpn(x, img_metas)
+         if rescale:
+             for proposals, meta in zip(proposal_list, img_metas):
+                 proposals[:, :4] /= proposals.new_tensor(meta['scale_factor'])
++        if torch.onnx.is_in_onnx_export():
++            return proposal_list
+
+         return [proposal.cpu().numpy() for proposal in proposal_list]
+ ",Do not import torch in the test function because it will import torch every test iteration and will slow down the testing speed.,what is the purpose of this line?
+7377,"@@ -69,11 +69,16 @@ func (s *Service) InstanceByTags(machine *actuators.MachineScope) (*v1alpha1.Ins
+ }
+
+ // InstanceIfExists returns the existing instance or nothing if it doesn't exist.
+-func (s *Service) InstanceIfExists(id string) (*v1alpha1.Instance, error) {
+-	klog.V(2).Infof(""Looking for instance %q"", id)
++func (s *Service) InstanceIfExists(id *string) (*v1alpha1.Instance, error) {
++	if id == nil {
++		klog.Error(""Instance does not have an instance id"")
++		return nil, nil
++	}
++
++	klog.V(2).Infof(""Looking for instance %q"", *id)
+
+ 	input := &ec2.DescribeInstancesInput{
+-		InstanceIds: []*string{aws.String(id)},
++		InstanceIds: []*string{id},
+ 		Filters: []*ec2.Filter{
+ 			filter.EC2.VPC(s.scope.VPC().ID),
+ 			filter.EC2.InstanceStates(ec2.InstanceStateNamePending, ec2.InstanceStateNameRunning),","I think we want to return an error here, not nil.",Why do we want to return an error
+7378,"@@ -38,6 +38,7 @@ describe( 'core/user userInfo', () => {
+ 			picture: 'https://path/to/image',
+ 		},
+ 		verified: true,
++		userInputState: 'complete',
+ 	};
+
+ 	let registry;","Nitpicking, but I think it would be more accurate to use an actually supported value, i.e. `completed`.",What is this for? I assume it's t
+7379,"@@ -0,0 +1,17 @@
++class OhAdmin::JobsController < ApplicationController
++  before_action :admin_session_required
++  before_action :find_project
++  layout 'admin'
++  helper JobApiHelper
++
++  def index
++    @response = JSON.parse(ApiJob.new(@project.id, params[:page]).get)
++  end
++
++  private
++
++  def find_project
++    @project = Project.find_by_vanity_url(params[:project_id])
++    raise ParamRecordNotFound if @project.nil?
++  end
++end","How about renaming the `ApiJob` class to `JobApi`. As per rails convention, get method is to get a single object, not a collection, can we change that to `fetch`/`where`. It would be great if we can move the `get` method to a class method.",Style/ClassAndModuleChildren: Use
+7380,"@@ -427,12 +427,14 @@ func TestCreateBlockchain(t *testing.T) {
+ 	require.NoError(registry.Register(account.ProtocolID, acc))
+ 	rp := rolldpos.NewProtocol(cfg.Genesis.NumCandidateDelegates, cfg.Genesis.NumDelegates, cfg.Genesis.NumSubEpochs)
+ 	require.NoError(registry.Register(rolldpos.ProtocolID, rp))
+-	bc := NewBlockchain(cfg, nil, InMemStateFactoryOption(), InMemDaoOption(), RegistryOption(&registry))
++	sf, err := factory.NewFactory(cfg, factory.InMemTrieOption())
++	require.NoError(err)
++	bc := NewBlockchain(cfg, nil, sf, InMemDaoOption(), RegistryOption(&registry))
+ 	bc.Validator().AddActionEnvelopeValidators(protocol.NewGenericValidator(bc))
+ 	exec := execution.NewProtocol(bc, hu)
+ 	require.NoError(registry.Register(execution.ProtocolID, exec))
+ 	bc.Validator().AddActionValidators(acc, exec)
+-	bc.GetFactory().AddActionHandlers(acc, exec)
++	sf.AddActionHandlers(acc, exec)
+ 	require.NoError(bc.Start(ctx))
+ 	require.NotNil(bc)
+ 	height := bc.TipHeight()",assignments should only be cuddled with other assignments (from `wsl`),why do we need this change?
+7381,"@@ -54,3 +54,11 @@ func (c *Cache) Delete(key interface{}) error {
+ 	c.values.Delete(key)
+ 	return nil
+ }
++
++func (c *Cache) GetAll() ([]interface{}, error) {
++	return nil, cache.ErrUnimplemented
++}
++
++func (c *Cache) PutHash(k interface{}, v interface{}) error {
++	return cache.ErrUnimplemented
++}",`k` is unused in PutHash,why is this needed?
+7382,"@@ -39,7 +39,7 @@ interface StatementsSource extends FileSource
+
+     public function isStatic(): bool;
+
+-    public function getSource(): ?StatementsSource;
++    public function getSource(): StatementsSource;
+
+     public function getCodebase() : Codebase;
+ ","None of the child return null here, plus it was creating an incoherence between interfaces.","semantic change, should be "
+7383,"@@ -1076,7 +1076,7 @@ pony_ctx_t* ponyint_sched_init(uint32_t threads, bool noyield, bool nopin,
+
+   // If minimum thread count is > thread count, cap it at thread count
+   if(min_threads > threads)
+-    min_threads = threads;
++    min_threads = threads; // this becomes the equivalent of --ponynoscale
+
+   // convert to cycles for use with ponyint_cpu_tick()
+   // 1 second = 2000000000 cycles (approx.)",Should we remove this entirely now then?,`--ponynoscale` is a bit co
+7384,"@@ -0,0 +1,17 @@
++package monitor
++
++import (
++	""github.com/weaveworks/weave/net/address""
++)
++
++// Monitor is an interface for tracking changes in ring allocations.
++type Monitor interface {
++	// HandleUpdate is called whenever an address ring gets updated.
++	//
++	// prevRanges corresponds to ranges which were owned by a peer before
++	// a change in the ring, while currRanges to the ones which are currently
++	// owned by the peer.
++	HandleUpdate(prevRanges, currRanges []address.Range) error
++	// String returns a user-friendly name of the monitor.
++	String() string
++}",That is way too generic a name.,what is this interface for?
+7385,"@@ -49,4 +49,11 @@ describe('duplicate-id', function () {
+ 		assert.isTrue(checks['duplicate-id'].evaluate.call(checkContext, node));
+ 	});
+
++	it('should allow overwrote ids', function () {
++		fixture.innerHTML = '<form data-testelm=""1"" id=""target""><input name=""id""></form>';
++		var node = fixture.querySelector('[data-testelm=""1""]');
++
++		assert.isTrue(checks['duplicate-id'].evaluate.call(checkContext, node));
++	});
++
+ });",This might be overkill for test code...but as stewards of accessibility it would be appropriate to have a label in the fixture.,This test fails without the
+7386,"@@ -232,7 +232,16 @@ TEST_F(VkBestPracticesLayerTest, CmdClearAttachmentTest) {
+     ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
+
+     m_commandBuffer->begin();
+-    m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo);
++
++    auto* secondary_full_clear = new VkCommandBufferObj(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
++    auto* secondary_small_clear = new VkCommandBufferObj(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
++    VkCommandBufferBeginInfo begin_info = { VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO };
++    begin_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT |
++                       VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT;
++    VkCommandBufferInheritanceInfo inherit_info = { VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO };
++    begin_info.pInheritanceInfo = &inherit_info;
++    inherit_info.subpass = 0;
++    inherit_info.renderPass = m_renderPassBeginInfo.renderPass;
+
+     // Main thing we care about for this test is that the VkImage obj we're
+     // clearing matches Color Attachment of FB","Are these allocations necessary, or can these be instantiated normally (i.e., `VkCommandBufferObj secondary_full_clear(...)`). If the allocations _are_ necessar, I'd vote for using something like `std::unique_ptr` and then remove the associated `delete`s.",All of these `secondary_*`
+7387,"@@ -43,6 +43,8 @@ public class InternalForTests {
+
+   public static void clear(ElasticsearchHttpStorage es) throws IOException {
+     es.clear();
++    // clear servicespan cache in order to prevent tests breaking
++    ((ElasticsearchHttpSpanConsumer)es.asyncSpanConsumer()).resetIndexToServiceSpansCache();
+   }
+
+   public static void flushOnWrites(ElasticsearchHttpStorage.Builder builder) {",es.clear should call this,Should we call this method
+7388,"@@ -54,6 +54,10 @@ class TPTest(unittest.TestCase):
+   def tearDown(self):
+     shutil.rmtree(self._tmpDir)
+
++
++  def testInitDefaultTP(self):
++    self.assertTrue(isinstance(TP(), TP))
++
+
+   def testCheckpointLearned(self):
+     # Create a model and give it some inputs to learn.",please remove. this is true by the definition of the Python language,"why not `assertIsInstance(TP(), TP)`?"
+7389,"@@ -1239,6 +1239,8 @@ KEY_DATA = collections.OrderedDict([
+         ('stop', ['<Ctrl-s>']),
+         ('print', ['<Ctrl-Alt-p>']),
+         ('open qute:settings', ['Ss']),
++        ('select-follow', ['<Return>']),
++        ('select-follow -t', ['<Ctrl-Return>']),
+     ])),
+
+     ('insert', collections.OrderedDict([","Hmm, I wonder if binding `<Return>` is a good idea... this means it wouldn't be passed to webpages anymore, which makes me wonder how many people rely on that... I guess trying it is the only way to find out :wink:",Shouldn't this be `<Ctrl-F`?
+7390,"@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
+ func icmpPkt(src, dst string) packet {
+ 	return packetWithPorts(1, src+"":0"", dst+"":0"")
+ }
++func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
++	return packet{
++		protocol: 1,
++		srcAddr:  src,
++		srcPort:  0,
++		dstAddr:  dst,
++		dstPort:  (icmpCode << 8) | (icmpType),
++	}
++}
+
+ var polProgramTests = []polProgramTest{
+ 	// Tests of actions and flow control.
+-
+ 	{
+ 		PolicyName: ""no tiers"",
+ 		DroppedPackets: []packet{",Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain,It would be better to use the constan
+7391,"@@ -300,6 +300,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+
+         protected FrameResponseHeaders FrameResponseHeaders { get; } = new FrameResponseHeaders();
+
++        public TimeSpan RequestBodyTimeout { get; set; }
++
++        public double RequestBodyMinimumDataRate { get; set; }
++
++        public TimeSpan RequestBodyMinimumDataRateGracePeriod { get; set; }
++
+         public void InitializeStreams(MessageBody messageBody)
+         {
+             if (_frameStreams == null)",nit: Probably should renamed to `InitializeBody`,Why are we using `double` instead of
+7392,"@@ -11,13 +11,15 @@ export default Component.extend({
+
+     open: false,
+
+-    navMenuIcon: computed('config.blogUrl', function () {
+-        let url = `${this.get('config.blogUrl')}/favicon.png`;
++    navMenuIcon: computed('config.blogUrl', 'settings.icon', function () {
++        let blogIcon = this.get('settings.icon') ? this.get('settings.icon') : 'favicon.ico';
++        let url = `${this.get('config.blogUrl')}/${blogIcon}`;
+
+         return htmlSafe(`background-image: url(${url})`);
+     }),
+
+     config: injectService(),
++    settings: injectService(),
+     session: injectService(),
+     ghostPaths: injectService(),
+     feature: injectService(),",is `settings.icon` always null/undefined when there's no icon or does is it get set to a blank string? It might be worth wrapping it in an `isBlank()` anyway,Why not use the `favicon.ico` directly here as well?
+7393,"@@ -90,8 +90,9 @@ var Module = fx.Options(
+ 	fx.Provide(MetadataManagerProvider),
+ 	fx.Provide(NamespaceCacheProvider),
+ 	fx.Provide(serialization.NewSerializer),
+-	fx.Provide(ArchiverProviderProvider),
+ 	fx.Provide(ArchivalMetadataProvider),
++	fx.Provide(ArchiverProviderProvider),
++	fx.Invoke(RegisterBootstrapContainer),
+ 	fx.Provide(PersistenceBeanProvider),
+ 	fx.Provide(MembershipFactoryProvider),
+ 	fx.Provide(MembershipMonitorProvider),","put invoke to the end of the list, and other module at beginning of the list (line 86)",Does this need to be public?
+7394,"@@ -166,7 +166,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
+-	db.logger.Infof(""db capacity: %v"", db.capacity)
++	db.logger.Infof(""database capacity: %d chunks, %d bytes, %.2f megabytes."", db.capacity, db.capacity*swarm.ChunkSize, float64(db.capacity*swarm.ChunkSize)*9.5367431640625e-7)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","I think that bytes is too precise. Can we just calculate the approximate value in appropriate units? Something like MB, GB depending on the value, `db capacity: 5000000 chunks (approximately 20GB)` .",It's better to use `zdb.Config.DBCapacity` here.
+7395,"@@ -0,0 +1,4 @@
++let label = node.getAttribute('alt');
++let text = node.textContent;
++
++return (!!label && axe.commons.text.sanitize(label).trim() !== '' && axe.commons.text.sanitize(text).trim() !== '');","This check shouldn't look at the content, you're already doing this with `none-empty-text`. I also think this check should be renamed to `none-empty-alt` or something like it. There is nothing specific to applets in this check to warrant putting `applet` in the check ID.",no need for the `!!`
+7396,"@@ -31,9 +31,11 @@ class TaxCreationForm extends BaseForm
+
+     protected $taxEngine = null;
+
+-    public function __construct(Request $request, $type = ""form"", $data = array(), $options = array(), TaxEngine $taxEngine = null)
++    public function __construct(Request $request, $type = ""form"", $data = array(), $options = array())
+     {
+-        $this->taxEngine = $taxEngine;
++        $this->taxEngine = $options[""tax_engine""];
++
++        unset($options[""tax_engine""]);
+
+         parent::__construct($request, $type, $data, $options);
+     }",Why did you change the signature of this method ? You can break BC doing that,What is the purpose of this line?
+7397,"@@ -49,6 +49,12 @@ func Run(ctx context.Context, cfg *config.Node) error {
+ 	}
+
+ 	template := configToml
++
++	if cfg.ConfigTemplate != """" {
++		fileBytes, _ := ioutil.ReadFile(cfg.ConfigTemplate)
++		template = string(fileBytes[:])
++	}
++
+ 	if !cfg.NoFlannel {
+ 		template += configCNIToml
+ 	}",can you catch the error here please and return err if it can't read the template,I'm not sure what the best way to
+7398,"@@ -58,6 +58,7 @@ public class MainController {
+         appsController.setOnAppLoaded(() -> {
+             enginesController.loadEngines();
+             containersController.loadContainers();
++            libraryController.updateLibrary();
+         });
+
+         appsController.loadApps();",Is this method called at another location too? I'm just asking because you didn't remove another call to `updateLibrary`,I am not sure if this is the righ
+7399,"@@ -14,7 +14,7 @@ class PublicPagePolicy < ApplicationPolicy
+   end
+
+   def template_export?
+-    @object.is_default || @object.org.funder?
++    @object.present? && ( @object.is_default || @object.org.funder? ) && @object.published
+   end
+
+   def plan_export?",Not necessary but you should be able to add a `?` on `is_default?` and `published?`,Favor modifier unless usage when
+7400,"@@ -87,7 +87,7 @@ public class ProtoCodecBenchmarks {
+
+   @Benchmark
+   public List<Span> bytebuffer_zipkinDecoder() {
+-    return SpanBytesDecoder.PROTO3.decodeList(ByteBufUtil.getBytes(encodedBuf));
++    return SpanBytesDecoder.PROTO3.decodeList(encodedBuf.nioBuffer());
+   }
+
+   @Benchmark",here is us decoding directly the bytebuffer in benchmarks,"`ByteBufUtil.getBytes(encodedBuf)` creates a new `ByteBuf` with the same size as the original buffer, so you don't need to include the copy of the buffer."
+7401,"@@ -39,7 +39,16 @@ namespace Datadog.Trace.Logging
+             }
+             else
+             {
+-                SetDefaultValues();
++                // Do not set default values because the Tracer (and this event
++                // subscriber) may be initialized at a time when it is not safe
++                // to add properties to the MDC of the underlying logging framework.
++                //
++                // This previously caused a SerializationException when the Tracer
++                //  was initialized in the Asp.Net HttpModule startup, the default
++                // values were added to the underlying log4net framework, and,
++                // upon handling a new request, Asp.Net tried to copy the type
++                // log4net.Util.PropertiesDictionary from one AppDomain to another
++                // even though the type did not implement MarshalObjectByRef
+                 _scopeManager.SpanActivated += MapOnSpanActivated;
+                 _scopeManager.TraceEnded += MapOnTraceEnded;
+             }","When the Tracer is first created AND `DD_LOGS_INJECTION=true`, this is invoked and causes the issues described.",Are we sure there won't be any side-effects to copying the properties from one AppDomain to another?
+7402,"@@ -44,7 +44,7 @@ public class JsonRpcErrorConverter {
+       case GAS_PRICE_TOO_LOW:
+         return JsonRpcError.GAS_PRICE_TOO_LOW;
+       case PRIVACY_GROUP_DOES_NOT_EXIST:
+-        return JsonRpcError.PRIVACY_GROUP_DOES_NOT_EXIST;
++        return JsonRpcError.OFFCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST;
+
+       default:
+         return JsonRpcError.INVALID_PARAMS;","NIT: If we are renaming the JsonRpcError, should we also rename this enum value to be consistent?",OFFCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST -> OFFCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST
+7403,"@@ -572,7 +572,8 @@ type FunctionExpression struct {
+ 	Defaults   *ObjectExpression
+ 	Block      *Block
+
+-	typ MonoType
++	typ        MonoType
++	Vectorized Expression
+ }
+
+ func (*FunctionExpression) NodeType() string { return ""FunctionExpression"" }","This could be made into a function expression, yes?",Could you add an example here that returns a vectorized expression?
+7404,"@@ -9,5 +9,5 @@ void release_assert_internal (bool check, const char * check_expr, const char *
+ 	}
+
+ 	std::cerr << ""Assertion ("" << check_expr << "") failed "" << file << "":"" << line << std::endl;
+-	abort();
++	abort ();
+ }","Oops, I missed this initially.","These are unrelated, but part of me wonders if they should be in another PR."
+7405,"@@ -243,6 +243,12 @@ class TestLambdaBaseFeatures(unittest.TestCase):
+         lambda_client.delete_function(FunctionName=lambda_name)
+
+     def test_add_lambda_permission(self):
++        function_name = 'lambda_func-{}'.format(short_uid())
++        testutil.create_lambda_function(
++            handler_file=TEST_LAMBDA_ECHO_FILE,
++            func_name=function_name,
++            runtime=LAMBDA_RUNTIME_PYTHON36
++        )
+         iam_client = aws_stack.connect_to_service('iam')
+         lambda_client = aws_stack.connect_to_service('lambda')
+ ",Can we add an assertion here the policy actually contains both statements created above?,"Nit: We should use `testutil.create_lambda_function(function_name, handler_f"
+7406,"@@ -59,7 +59,13 @@ DEFINE_bool(enable_partitioned_index_filter, false, ""True for partitioned index
+ DEFINE_string(rocksdb_compression,
+               ""snappy"",
+               ""Compression algorithm used by RocksDB, ""
+-              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2"");
++              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress"");
++
++DEFINE_string(rocksdb_bottommost_compression,
++              ""disable"",
++              ""Specify the bottommost level compression algorithm""
++              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress,disable"");
++
+ DEFINE_string(rocksdb_compression_per_level,
+               """",
+               ""Specify per level compression algorithm, """,a space after comma?,Why did you choose a name for this option? Couldn't this be simply `rocksdb_
+7407,"@@ -70,6 +70,11 @@ public final class CorrectForClockSkew {
+     if (skew != null) {
+       // the current span's skew may be a different endpoint than skewFromParent, adjust again.
+       node.value(adjustTimestamps(node.value(), skew));
++    } else {
++      if (skewFromParent != null && isLocalSpan(node.value())) {
++        //Propagate skewFromParent to local spans
++         skew = skewFromParent;
++      }
+     }
+     // propagate skew to any children
+     for (Node<Span> child : node.children()) {",nit formatting here and below,Why do we need this special case? Shouldn't the local span be constrained to
+7408,"@@ -5,9 +5,9 @@ import (
+
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/spiffe/spire/pkg/common/util""
+-	""github.com/spiffe/spire/proto/spire/api/registration""
+-	""github.com/spiffe/spire/proto/spire/common""
+-	mock_registration ""github.com/spiffe/spire/test/mock/proto/api/registration""
++	""github.com/spiffe/spire/proto/spire/api/server/entry/v1""
++	""github.com/spiffe/spire/proto/spire/types""
++	mock_entry ""github.com/spiffe/spire/test/mock/proto/api/entry""
+ 	""github.com/stretchr/testify/suite""
+ )
+ ","I think that there is a general consensus of trying to avoid this kind of mocks in the new tests that we write. I would suggest to have tests using fake service implementations. In this case, we can have a fake entry service. Examples of how tests have been written this way are the tests for the `spire-server agent` and `spire-server bundle` commands. It would be great if we can have that kind of testing here also. What do you think?",rename mock_entry to mock_entry
+7409,"@@ -38,6 +38,6 @@ func (p *Provider) Type() string {
+ 	return ProviderType
+ }
+
+-func (p *Provider) RunQuery(ctx context.Context, query string) (bool, error) {
+-	return false, nil
++func (p *Provider) RunQuery(ctx context.Context, query string) (bool, string, error) {
++	return false, """", nil
+ }",`ctx` is unused in RunQuery,This should probably return a (
+7410,"@@ -276,12 +276,14 @@ def get_report_path_hash(report):
+     """""" Returns path hash for the given bug path.
+
+     This can be used to filter deduplications of multiple reports.
++
++    report type should be codechecker_common.Report
+     """"""
+     report_path_hash = ''
+     events = [i for i in report.bug_path if i.get('kind') == 'event']
+-
+     for event in events:
+-        file_name = os.path.basename(report.files[event['location']['file']])
++        file_name = \
++            os.path.basename(report.files.get(event['location']['file']))
+         line = str(event['location']['line']) if 'location' in event else 0
+         col = str(event['location']['col']) if 'location' in event else 0
+ ",Couldn't we use type hints to express this?,This change seems unrelated. Ca
+7411,"@@ -57,12 +57,12 @@ define(['connectionManager', 'serverNotifications', 'events', 'globalize', 'emby
+
+     function setState(button, likes, isFavorite, updateAttribute) {
+
+-        var icon = button.querySelector('i');
++        var icon = button.querySelector('.material-icons');
+
+         if (isFavorite) {
+
+             if (icon) {
+-                icon.innerHTML = 'favorite';
++                icon.classList.add('favorite');
+                 icon.classList.add('ratingbutton-icon-withrating');
+             }
+ ",why you do `.classList.add()` here but `.replace()` in other places?,The `innerHTML` was causing the
+7412,"@@ -98,9 +98,14 @@ Then 'I see the section price is ""$price""' do |price|
+ end
+
+ Then 'I see that one of the teachers is ""$teacher_name""' do |teacher_name|
++  sleep 10
+   page.should have_css("".teachers"", text: teacher_name)
+ end
+
++Then 'I should see that ""$teacher_name"" is teaching both sections' do |teacher_name|
++  page.should have_selector('h4', text: ""Joe Teacher"", count: 1)
++end
++
+ Then %{I see ""$teacher_name""'s avatar} do |teacher_name|
+   teacher = Teacher.find_by_name!(teacher_name)
+   page.should have_css(""img[src^='https://secure.gravatar.com/avatar/#{teacher.gravatar_hash}']"")",What is this sleep here for?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+7413,"@@ -478,4 +478,19 @@ describe('AutoRowSize', () => {
+
+     expect(rowHeight(spec().$container, -1)).toBe(75);
+   });
++
++  it('should properly count height', () => {
++    const hot = handsontable({
++      data: [['Tomek', 'Tomek\nTomek', 'Romek\nRomek']],
++      rowHeaders: true,
++      colHeaders: true,
++      autoRowSize: true,
++    });
++    // const cloneLeftHider = spec().$container.find('.ht_clone_left .wtHider')[0];
++    const $rowsHeaders = spec().$container.find('.ht_clone_left tbody tr th');
++    const plugin = hot.getPlugin('autoRowSize');
++
++    expect($rowsHeaders.height()).toEqual(42);
++    expect(plugin.heights[0]).toEqual(43);
++  });
+ });","I think that this test doesn't cover this bug correctly. When I attached the older version of the handsontable to this test it passes, should fail. Can you check that?",Can you add an empty line after this?
+7414,"@@ -186,6 +186,16 @@ type tlfJournal struct {
+ 	mdJournal    *mdJournal
+ 	disabled     bool
+ 	lastFlushErr error
++	// The cache of unflushed paths.  If `unflushedReady` is not nil,
++	// then any callers must wait for it to be closed before accessing
++	// `unflushedPaths`.  `unflushedReady` only transitions
++	// nil->non-nil->nil at most one time during the lifetime of the
++	// journal. If `unflushedPaths` is non-nil, then `chainsPopulator`
++	// must also be non-nil.  These three fields are protected by
++	// `journalLock`.
++	unflushedPaths  map[MetadataRevision]map[string]bool
++	unflushedReady  chan struct{}
++	chainsPopulator chainsPathPopulator
+
+ 	bwDelegate tlfJournalBWDelegate
+ }",Maybe this should just be passed in on construction time,Does it still make sense to keep `unflushedPaths` and just `chainsPathPopulator` as field
+7415,"@@ -367,6 +367,11 @@ struct wlr_backend *wlr_backend_autocreate(struct wl_display *display) {
+
+ 	struct wlr_backend *primary_drm =
+ 		attempt_drm_backend(display, backend, multi->session);
++
++	// discard the returned pointer - the monitor should destroy itself
++	// when the multi-backend is destroyed
++	wlr_drm_backend_monitor_create(backend, primary_drm, multi->session);
++
+ 	if (!primary_drm) {
+ 		wlr_log(WLR_ERROR, ""Failed to open any DRM device"");
+ 		wlr_backend_destroy(libinput);",We should create the monitor after the `if (!primary_drm)` check.,"The name `primary_drm` is confusing, it's actually a reference to the `primary_drm` in th"
+7416,"@@ -85,6 +85,7 @@ def whitelist_generator():
+     yield 'qutebrowser.utils.log.QtWarningFilter.filter'
+     yield 'logging.LogRecord.log_color'
+     yield 'qutebrowser.browser.pdfjs.is_available'
++    yield 'qutebrowser.browser.tab.TabData._initializing'
+     # vulture doesn't notice the hasattr() and thus thinks netrc_used is unused
+     # in NetworkManager.on_authentication_required
+     yield 'PyQt5.QtNetwork.QNetworkReply.netrc_used'",Can be removed now that slots are used,typo: `TabData` -> `TabData`
+7417,"@@ -216,7 +216,7 @@ describe 'AccountsController' do
+   describe 'edit' do
+     it 'must respond with not_found when account does not exist' do
+       get :edit, id: :anything
+-      must_respond_with :not_found
++      must_respond_with :unauthorized
+     end
+
+     it 'must respond with success' do",The description should match the test,Since this spec is testing t
+7418,"@@ -165,12 +165,9 @@ static void xwayland_finish_display(struct wlr_xwayland *wlr_xwayland) {
+
+ 	unlink_display_sockets(wlr_xwayland->display);
+ 	wlr_xwayland->display = -1;
+-	unsetenv(""DISPLAY"");
++	wlr_xwayland->display_name[0] = '\0';
+ }
+
+-static bool xwayland_start_display(struct wlr_xwayland *wlr_xwayland,
+-	struct wl_display *wl_display);
+-
+ static bool xwayland_start_server(struct wlr_xwayland *wlr_xwayland);
+ static bool xwayland_start_server_lazy(struct wlr_xwayland *wlr_xwayland);
+ ",rootston needs to unset this now,"This function is now unused,"
+7419,"@@ -35,7 +35,7 @@ func newBlockBuffer(bufferSize, intervalSize uint64) *blockBuffer {
+ 	}
+ }
+
+-func (b *blockBuffer) Delete(height uint64) []*peerBlock {
++func (b *blockBuffer) Pop(height uint64) []*peerBlock {
+ 	b.mu.Lock()
+ 	defer b.mu.Unlock()
+ 	queue, ok := b.blockQueues[height]",why do you rename this function?,What is the difference betwe
+7420,"@@ -30,12 +30,10 @@ module MailerHelper
+   end
+
+   def step_status_icon(step)
+-    if step.status == ""actionable""
+-      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + "".png""
+-    elsif step.status == ""pending""
+-      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + ""-pending.png""
+-    elsif step.status == ""completed""
++    if step.status == ""completed""
+       ""emails/numbers/icon-completed.png""
++    else
++      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + ""-pending.png""
+     end
+   end
+ ",since we are no longer using these numbered icons can we remove them from source control?,Use safe navigation (&.) instead of checking if an object exists before calling the method.
+7421,"@@ -182,6 +182,8 @@ public class VertxRestDispatcher extends AbstractVertxHttpDispatcher {
+
+     RestProducerInvocation restProducerInvocation = new RestProducerInvocation();
+     context.put(RestConst.REST_PRODUCER_INVOCATION, restProducerInvocation);
++    restProducerInvocation.setAfterCreateInvocationHandler(
++        invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));
+     restProducerInvocation.invoke(transport, requestEx, responseEx, httpServerFilters);
+   }
+ }","both edge and normal need to set this, so set it to be default action?",This doesn't seem right. Why is it set after creating the context?
+7422,"@@ -391,9 +391,13 @@ namespace Microsoft.DotNet.Build.Tasks
+
+         private static void WriteProject(JObject projectRoot, string projectJsonPath)
+         {
+-            string projectJson = JsonConvert.SerializeObject(projectRoot, Formatting.Indented);
+-            Directory.CreateDirectory(Path.GetDirectoryName(projectJsonPath));
+-            File.WriteAllText(projectJsonPath, projectJson + Environment.NewLine);
++            string projectJson = JsonConvert.SerializeObject(projectRoot, Formatting.Indented) + Environment.NewLine;
++
++            if (!File.Exists(projectJsonPath) || !projectJson.Equals(File.ReadAllText(projectJsonPath)))
++            {
++                Directory.CreateDirectory(Path.GetDirectoryName(projectJsonPath));
++                File.WriteAllText(projectJsonPath, projectJson);
++            }
+         }
+
+         /* JProperties are encapsulated with ""['"" and ""']"" to assist with matching Paths which",Is doing a straight string compare of the files the right way to determine this? I guess if you expect to be the only one writing this file it could work but it does seem like it might be a large string compare and if we are doing this hundreds of times that might cause some memory issues.,Would it make sense to check `!File.Exists(projectJsonPath)` before calling `WriteAllText`?
+7423,"@@ -431,7 +431,7 @@ static void set_client_priority() {
+ #ifdef __linux__
+     char buf[1024];
+     snprintf(buf, sizeof(buf), ""ionice -c 3 -p %d"", getpid());
+-    system(buf);
++    if (!system(buf)) {}
+ #endif
+ }
+ ",What's the purpose of this change? It basically changes nothing until we want to put smth between curly braces,This should probably be: `if (!system(buf)) {`
+7424,"@@ -186,6 +186,9 @@ static void handle_device_removed(struct wlr_libinput_backend *backend,
+ 	}
+ 	struct wlr_input_device *dev, *tmp_dev;
+ 	wl_list_for_each_safe(dev, tmp_dev, wlr_devices, link) {
++		if (dev->type == WLR_INPUT_DEVICE_TABLET_TOOL) {
++			wlr_libinput_tablet_tool_destroy(dev);
++		}
+ 		wlr_input_device_destroy(dev);
+ 	}
+ 	for (size_t i = 0; i < backend->wlr_device_lists.length; i++) {","Hmm, why is this needed? `wlr_input_device_destroy` should destroy the tablet tool.","Tablet tool shouldn't be able to be removed from the wlr_input_device_lists, it should be able to be removed from the wlr_devices."
+7425,"@@ -62,6 +62,12 @@ public class DiscoApiModel implements ApiModel {
+     return interfaceModels;
+   }
+
++  @Override
++  public Iterable<? extends TypeModel> getAdditionalTypes() {
++    // TODO: is this supported?
++    return ImmutableList.of();
++  }
++
+   @Override
+   public InterfaceModel getInterface(String interfaceName) {
+     for (InterfaceModel interfaceModel : getInterfaces()) {",I think it's better to throw `UnsupportedOperationException`,Why not throw an UnsupportedOperationException?
+7426,"@@ -124,6 +124,14 @@ function createElement(...args) {
+ 			delete props.defaultValue;
+ 		}
+
++		if (Array.isArray(props.value) && props.multiple && type==='select') {
++			props.children.forEach((child) => {
++				if (props.value.includes(child.props.value)) {
++					child.props.selected = true;
++				}
++			});
++			delete props.value;
++		}
+ 		handleElementVNode(vnode, props);
+ 	}
+ ",`props.children` is not always guaranteed to be an array. When only one child is passed this will break. We can use `toChildArray()` to turn it into an array :tada:,@wassgha Can you please review this change since you originally added this code?
+7427,"@@ -26,7 +26,8 @@ buildStyle = os.environ['BUILD_STYLE']
+
+ # Build the configure command.
+ configureCmd = os.path.join(buildSystemDir, 'contrib', 'configure.py')
+-configureCmd += ' --mode=%s' % buildStyle
++# configureCmd += ' --mode=%s' % buildStyle
++configureCmd += ' --mode=release'
+ configureCmd += ' --builddir=%s' % buildDir
+
+ print 'Running command:', configureCmd",Please just remove this line. We have the git history if we want the old version.,Just remove? We want to release things at least for this release.
+7428,"@@ -49,9 +49,11 @@ public class ScriptTaskGraalJsTest extends AbstractScriptTaskTest {
+   private static final String GRAALJS = ""graal.js"";
+
+   protected ScriptEngineResolver defaultScriptEngineResolver;
++  protected boolean spinEnabled = false;
+
+   @Before
+   public void setup() {
++    spinEnabled = processEngineConfiguration.getEnvScriptResolvers().stream().anyMatch(resolver -> resolver.getClass().getSimpleName().equals(""SpinScriptEnvResolver""));
+     defaultScriptEngineResolver = processEngineConfiguration.getScriptEngineResolver();
+     processEngineConfiguration.setConfigureScriptEngineHostAccess(configureHostAccess);
+     processEngineConfiguration.setEnableScriptEngineLoadExternalResources(enableExternalResources);","Can we put some of the code on a new line to make it more readable. The max line length was 120 now, right?",please use a constant for the name
+7429,"@@ -56,3 +56,19 @@ func Example() {
+ 	cfg := snapshot.Value.(MyConfig)
+ 	_ = cfg
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	// This example watches a variable based on a file-based blob.Bucket with JSON.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""etcd://myvarname?client=my.etcd.server:9999"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}",Remove the handling here as well.,nit: should this be called `Exampl
+7430,"@@ -113,7 +113,7 @@ namespace OpenTelemetry.Trace
+         /// <inheritdoc/>
+         public override void OnEnd(Activity activity)
+         {
+-            if (this.queue.TryAdd(activity))
++            if (this.queue.TryAdd(activity, maxSpinCount: 50000))
+             {
+                 if (this.queue.Count >= this.maxExportBatchSize)
+                 {",Do we want to make this configurable?,Does it make sense to have a const
+7431,"@@ -159,6 +159,17 @@ public final class Require {
+     return number;
+   }
+
++  public static double positive(String argName, double number, String message) {
++    if (number <= 0) {
++      if (message == null) {
++        throw new IllegalArgumentException(argName + "" must be greater than 0"");
++      } else {
++        throw new IllegalArgumentException(message);
++      }
++    }
++    return number;
++  }
++
+   public static int positive(String argName, Integer number) {
+     return positive(argName, number, null);
+   }","Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly.","Should this be `positive(argName, "
+7432,"@@ -71,4 +71,17 @@ ActiveAdmin.register Proposal do
+     flash[:alert] = ""Completed!""
+     redirect_to admin_proposal_path(resource)
+   end
++
++  csv do
++    proposal_attributes = %w(id status created_at updated_at client_data_type public_id visit_id)
++    proposal_attributes.each do |proposal_attr|
++      column(proposal_attr.to_sym) { |proposal| proposal.attributes[proposal_attr] }
++    end
++    column(:requester) { |proposal| proposal.requester.display_name }
++    client_data_attributes = %w(expense_type vendor not_to_exceed building_number emergency rwa_number work_order_code project_title description direct_pay cl_number function_code soc_code ncr_organization_id)
++    client_data_attributes.each do |data_attr|
++      column(data_attr.to_sym) { |proposal| proposal.client_data.attributes[data_attr] }
++    end
++    column(:approving_offical_name) { |proposal| User.find(proposal.client_data.approving_official_id).display_name }
++  end
+ end","Is this going to break things for 18F proposals, or will these fields just be ignored?",Line is too long. [100/80]
+7433,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those,
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?,should be `{@link Keys#SHI
+7434,"@@ -35,6 +35,12 @@ type AWSClusterProviderConfig struct {
+
+ 	// SSHKeyName is the name of the ssh key to attach to the bastion host.
+ 	SSHKeyName string `json:""sshKeyName,omitempty""`
++
++	// CACertificate is a PEM encoded CA Certificate for the control plane nodes.
++	CACertificate []byte `json:""caCertificate,omitempty""`
++
++	// CAPrivateKey is a PEM encoded PKCS1 CA PrivateKey for the control plane nodes.
++	CAPrivateKey []byte `json:""caKey,omitemptuy""`
+ }
+
+ // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object",What's the reason for moving this to config from status?,Does this need to be added
+7435,"@@ -48,7 +48,7 @@ class GenericSuppressHandler(suppress_handler.SuppressHandler):
+     def store_suppress_bug_id(self, bug_id, file_name, comment):
+
+         if self.suppress_file is None:
+-            return False
++            return True
+
+         ret = suppress_file_handler.write_to_suppress_file(self.suppress_file,
+                                                            bug_id,",Shouldn't we re validate/update the in memory suppress data here?,"Hmm, is this change relate"
+7436,"@@ -68,7 +68,7 @@ func TestPaymentChannelLs(t *testing.T) {
+ 	t.Run(""Works with default payer"", func(t *testing.T) {
+ 		t.Parallel()
+
+-		payer, err := address.NewFromString(fixtures.TestAddresses[0])
++		payer, err := address.NewFromString(fixtures.TestAddresses[2])
+ 		require.NoError(err)
+ 		target, err := address.NewFromString(fixtures.TestAddresses[1])
+ 		require.NoError(err)",curious why the renumbering is required here and elsewhere?,Might wanna update this test to use the non-default payer?
+7437,"@@ -426,9 +426,12 @@ func validateClusterPlatform(path *field.Path, platform hivev1.Platform) field.E
+ 	if aws := platform.AWS; aws != nil {
+ 		numberOfPlatforms++
+ 		awsPath := path.Child(""aws"")
+-		if aws.CredentialsSecretRef.Name == """" {
++		if aws.CredentialsSecretRef.Name == """" && aws.CredentialsAssumeRole == nil {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""credentialsSecretRef"", ""name""), ""must specify secrets for AWS access""))
+ 		}
++		if aws.CredentialsAssumeRole != nil && aws.CredentialsSecretRef.Name != """" {
++			allErrs = append(allErrs, field.Required(awsPath.Child(""credentialsAssumeRole""), ""cannot specify assume role when credentials secret is provided""))
++		}
+ 		if aws.Region == """" {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""region""), ""must specify AWS region""))
+ 		}",s/must specify secrets/must specify secrets or Role info/,Does it make sense to error out if both `aws.CredentialsSe
+7438,"@@ -63,8 +63,8 @@ C2::Application.routes.draw do
+   end
+
+   mount Peek::Railtie => ""/peek""
++  mount Blazer::Engine, at: ""blazer""
+   if Rails.env.development?
+     mount LetterOpenerWeb::Engine => ""letter_opener""
+-    mount Blazer::Engine, at: ""blazer""
+   end
+ end","let's leave this as a dev-only feature, and copy prod db to local env when needed. that keeps blazer security issues to a minimum.",should we remove this from `locales/routes.rb` too?
+7439,"@@ -22,7 +22,7 @@ namespace OpenTelemetry.Trace.Samplers
+     public sealed class AlwaysOffActivitySampler : ActivitySampler
+     {
+         /// <inheritdoc />
+-        public override string Description { get; } = nameof(AlwaysOffActivitySampler);
++        public override string Description { get; } = ""AlwaysOffSampler"";
+
+         /// <inheritdoc />
+         public override SamplingResult ShouldSample(in ActivitySamplingParameters samplingParameters)","We'll be renaming ActivitySampler to Sampler anyway, so this change will be non-required. Prefer to avoid changes here to avoid merge conflict with my PR doing the rename.",I don't think we should change the name of this class anym
+7440,"@@ -278,7 +278,10 @@ func mutateHeadersByRules(headers, rules http.Header, repl httpserver.Replacer)
+ 		} else if strings.HasPrefix(ruleField, ""-"") {
+ 			headers.Del(strings.TrimPrefix(ruleField, ""-""))
+ 		} else if len(ruleValues) > 0 {
+-			headers.Set(ruleField, repl.Replace(ruleValues[len(ruleValues)-1]))
++			var replacement = repl.Replace(ruleValues[len(ruleValues)-1])
++			if len(replacement) > 0 {
++				headers.Set(ruleField, replacement)
++			}
+ 		}
+ 	}
+ }","This applies only in the ""set"" headers case, but what about ""adding"" a header (field prefixed with `+`)?",Does this handle a case where `len(ruleValues) == 0`?
+7441,"@@ -13,6 +13,7 @@ package net.sourceforge.pmd;
+  * @version $Revision$, $Date$
+  * @since August 30, 2002
+  */
++@Deprecated
+ public class PMDException extends Exception {
+     private static final long serialVersionUID = 6938647389367956874L;
+ ","I'm not sure we should deprecate this. I kinda like the idea, that we would provide all exceptions (if we throw any) with a common super type. Of course, the exception should be not a checked exception like this one, but rather a runtime exception. We maybe need additionally an internal exception that we would convert into such a public API exception. But that's out of scope of this PR - that's the question of exception handling.",What's the reasoning behind deprecating this class?
+7442,"@@ -41,6 +41,11 @@ class TabDeletedError(Exception):
+     """"""Exception raised when _tab_index is called for a deleted tab.""""""
+
+
++class MarkNotSetError(Exception):
++
++    """"""Exception raised when _tab_index is called for a deleted tab.""""""
++
++
+ class TabbedBrowser(tabwidget.TabWidget):
+
+     """"""A TabWidget with QWebViews inside.",You'll need to adjust the docstring :wink:,Please don't extend the base exception class. In this
+7443,"@@ -81,7 +81,8 @@ void ReaderProxy::start(const ReaderProxyData& reader_attributes)
+         reader_attributes.guid(),
+         reader_attributes.remote_locators().unicast,
+         reader_attributes.remote_locators().multicast,
+-        reader_attributes.m_expectsInlineQos);
++        reader_attributes.m_expectsInlineQos,
++        /*reader_attributes.guid().is_on_same_process_as(writer_->getGuid()*/false);
+
+     is_active_ = true;
+     reader_attributes_ = reader_attributes;",Add a TODO explaining why this is being done,Remove this line.
+7444,"@@ -26,7 +26,8 @@
+
+ goog.provide('Blockly.VariableMap');
+
+-goog.require('Blockly.VariableModel');
++goog.require('Blockly.Events.VarDelete');
++goog.require('Blockly.Events.VarRename');
+
+ /**
+  * Class for a variable map.  This contains a dictionary data structure with",This file still uses Blockly.VariableModel...,Consider calling these `VarMap` and `VarRename`.
+7445,"@@ -129,8 +129,10 @@ type ManagedRemoteAccess struct {
+ 	SSHKeyName *string `json:""sshKeyName,omitempty""`
+
+ 	// SourceSecurityGroups specifies which security groups are allowed access
+-	// An empty array opens port 22 to the public internet
+ 	SourceSecurityGroups []string `json:""sourceSecurityGroups,omitempty""`
++
++	// Public specifies whether to open port 22 to the public internet
++	Public bool `json:""public,omitempty""`
+ }
+
+ // AWSManagedMachinePoolStatus defines the observed state of AWSManagedMachinePool","Small nit, in the PR description its `publicAccess` but here its `public`. Guessing the preferred naming is public?",why not use `SourceSecurityGroups` instead of `P
+7446,"@@ -106,10 +106,11 @@ func (c *Variable) Close() error {
+ // Decode is a function type for unmarshaling/decoding bytes into given object.
+ type Decode func([]byte, interface{}) error
+
+-// Decoder is a helper for decoding bytes into a particular Go type object.  The Variable objects
+-// produced by a particular driver.Watcher should always contain the same type for Variable.Value
+-// field.  A driver.Watcher can use/construct a Decoder object with an associated type (Type) and
+-// decoding function (Func) for decoding retrieved bytes into Variable.Value.
++// Decoder is a helper for decoding bytes into a particular Go type object. The
++// Variable objects produced by a particular driver.Watcher should always
++// contain the same type for Variable.Value field. A driver.Watcher can
++// use/construct a Decoder object with an associated type (Type) and decoding
++// function (Func) for decoding retrieved bytes into Variable.Value.
+ type Decoder struct {
+ 	Type reflect.Type
+ 	// Func is a Decode function.","Maybe `driver.Watcher` -> provider (2x)? This is the concrete type, this user doesn't really know anything about the driver.",Is there a linter rule that disallows type refer
+7447,"@@ -21,12 +21,10 @@ import java.io.IOException;
+
+ import org.apache.lucene.codecs.DocValuesConsumer;
+ import org.apache.lucene.search.DocIdSetIterator;
+-import org.apache.lucene.search.SortField;
+
+-abstract class DocValuesWriter {
+-  abstract void finish(int numDoc);
++abstract class DocValuesWriter<T> {
+   abstract void flush(SegmentWriteState state, Sorter.DocMap sortMap, DocValuesConsumer consumer) throws IOException;
+-  abstract Sorter.DocComparator getDocComparator(int numDoc, SortField sortField) throws IOException;
++  abstract T getDocValues();
+   abstract DocIdSetIterator getDocIdSet();
+
+ }",can we remove this since `getDocValues` already returns an iterator? (we might need to do `T extends DocIdSetIterator` above),can you remove the `<T>` here and below?
+7448,"@@ -0,0 +1,8 @@
++class String
++  def fix_encoding_if_invalid!
++    unless self.valid_encoding?
++      self.encode!('utf-8', 'binary', invalid: :replace, undef: :replace)
++    end
++    self
++  end
++end",Don't check this in. This is already implemented in core_extensions/ruby/string.rb,Style/RedundantSelf: Redundant self detected.
+7449,"@@ -277,7 +277,7 @@ Block.prototype._getHash = function() {
+
+ var idProperty = {
+   configurable: false,
+-  writeable: false,
++  enumerable: true,
+   /**
+    * @returns {string} - The big endian hash buffer of the header
+    */","This is used for both `id`, and `hash` we may not want these both to be enumerable.",@dvoytenko is `configurable` still necessary?
+7450,"@@ -641,9 +641,16 @@ module RSpec
+         formatter_loader.default_formatter = value
+       end
+
+-      # @private
++      # @api public
++      #
++      # Returns a duplicate of the formatters currently loaded in
++      # the `FormatterLoader` for introspection.
++      #
++      # Note as this is a duplicate, any mutations will be disregarded.
++      #
++      # @return [Array] the formatters currently loaded
+       def formatters
+-        formatter_loader.formatters
++        formatter_loader.formatters.dup
+       end
+
+       # @private",Is this necessary? I would expect YARD to treat it as public anyway... (Don't hold off merging on this...I'm mostly just curious).,Layout/EmptyLinesAroundClassBody: Extra empty
+7451,"@@ -578,6 +578,7 @@ func (e *MutableStateImpl) GetActivityScheduledEvent(
+ 		e.executionState.RunId,
+ 		ai.ScheduledEventBatchId,
+ 		ai.ScheduleId,
++		ai.Version,
+ 		currentBranchToken,
+ 	)
+ 	if err != nil {",@wxing1292 to double check this is the right version to use?,"I assume this was for testing, right?"
+7452,"@@ -70,4 +70,12 @@ class TIntRange extends TInt
+     {
+         return $this->min_bound !== null && $this->min_bound > 0;
+     }
++
++    public function contains(int $i): bool
++    {
++        return
++            ($this->min_bound === null && $this->max_bound === null) ||
++            ($this->min_bound === null && $this->max_bound >= $i) ||
++            ($this->max_bound === null && $this->min_bound <= $i);
++    }
+ }",Shouldn't there be another case for when both min and max are specified?,When would this not be true? Shouldn't it be false by default?
+7453,"@@ -1,5 +1,5 @@
+ ## This file is part of Invenio.
+-## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 CERN.
++## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","Don't miss this one `2: I102 copyright year is outdated, expected 2014 but got 2013`. Thanks",Copyright date should not be changed from the original unless
+7454,"@@ -112,8 +112,9 @@ size_t Cord::appendTo(std::string& str) const {
+     }
+
+     // Last block
+-    str.append(tail_, blockPt_);
+-
++    if (tail_) {
++        str.append(tail_, blockPt_);
++    }
+     return len_;
+ }
+ ",the tail_ maybe nullptr?,"Wouldn't this introduce a bug? `str.append(tail_, blockPt_)` w"
+7455,"@@ -92,7 +92,7 @@ func (c *Controller) reviewAdmission(ctx context.Context, req *admv1beta1.Admiss
+ 		if err := json.Unmarshal(req.Object.Raw, pod); err != nil {
+ 			return errs.New(""unable to unmarshal %s/%s object: %v"", req.Kind.Version, req.Kind.Kind, err)
+ 		}
+-		return c.createPodEntry(ctx, pod)
++		return c.syncPodEntry(ctx, pod)
+ 	case admv1beta1.Delete:
+ 		return c.deletePodEntry(ctx, req.Namespace, req.Name)
+ 	default:","The PR description mentions that `The controller code is extended to react to ""add"" events`, but I don't see any additional cases added here beyond the existing Create and Delete... is there something I'm missing?",What's the difference between `createPodEntry` and `syncPodEnt
+7456,"@@ -26,7 +26,7 @@ module Blacklight
+   ##
+   # An OpenStruct that responds to common Hash methods
+   class OpenStructWithHashAccess < OpenStruct
+-    delegate :keys, :each, :map, :has_key?, :empty?, :delete, :length, :reject!, :select!, :include, :fetch, :to_json, :as_json, :to => :to_h
++    delegate :keys, :each, :map, :has_key?, :include?, :empty?, :length, :delete, :delete_if, :keep_if, :clear, :reject!, :select!, :replace, :fetch, :to_json, :as_json, to: :to_h
+
+     if ::RUBY_VERSION < '2.0'
+       def []=(key, value)",Does it matter that #include changed to #include? ? I think the change makes sense since it aligns with the method name on Hash but unsure if anything called #include that would break with the change.,Line is too long. [106/80]
+7457,"@@ -92,7 +92,7 @@ const (
+
+ 	// minimumTaskCleanupWaitDuration specifies the minimum duration to wait before cleaning up
+ 	// a task's container. This is used to enforce sane values for the config.TaskCleanupWaitDuration field.
+-	minimumTaskCleanupWaitDuration = 1 * time.Minute
++	minimumTaskCleanupWaitDuration = time.Second
+
+ 	// minimumImagePullInactivityTimeout specifies the minimum amount of time for that an image can be
+ 	// 'stuck' in the pull / unpack step. Very small values are unsafe and lead to high failure rate.","LGTM, curious though why exactly this is in place, and are there any possible issues from not waiting long enough?",Why this change? This seem
+7458,"@@ -104,7 +104,7 @@ module Beaker
+       #cleanup phase
+       rescue => e
+         #cleanup on error
+-        if @options[:preserve_hosts].to_s =~ /(never)/
++        if @options[:preserve_hosts].to_s =~ /(?:never)|(?:onpass)/
+           @logger.notify ""Cleanup: cleaning up after failed run""
+           if @network_manager
+             @network_manager.cleanup",?: is unnecessary because we already force preserve_hosts to be a string with to_s.,Style/StringLiterals: Pref
+7459,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent,would it make sense to mov
+7460,"@@ -106,8 +106,8 @@ describe('debug with suspense', () => {
+
+ 				return loader.then(() => {
+ 					rerender();
+-					expect(console.warn).to.be.calledTwice;
+-					expect(warnings[1].includes('MyLazyLoaded')).to.equal(true);
++					expect(console.warn).to.be.calledThrice;
++					expect(warnings[2].includes('MyLazyLoaded')).to.equal(true);
+ 					expect(serializeHtml(scratch)).to.equal('<div>Hi there</div>');
+ 				});
+ 			});","Since lazy is re-rendered when mounting the fallback, these checks get triggered an additional time.",Is this related to the rest of this PR?
+7461,"@@ -173,6 +173,10 @@ class AbstractWebElement(collections.abc.MutableMapping):
+         except KeyError:
+             return False
+
++    def is_content_editable_prop(self) -> bool:
++        """"""Get the value of this element's isContentEditable property.""""""
++        raise NotImplementedError
++
+     def _is_editable_object(self) -> bool:
+         """"""Check if an object-element is editable.""""""
+         if 'type' not in self:","There is a `is_content_editable()` method just above this, what's the difference?",Is there a use case where this would no
+7462,"@@ -86,7 +86,7 @@ type PrometheusList struct {
+ type PrometheusSpec struct {
+ 	// PodMetadata configures Labels and Annotations which are propagated to the prometheus pods.
+ 	PodMetadata *EmbeddedObjectMetadata `json:""podMetadata,omitempty""`
+-	// ServiceMonitors to be selected for target discovery. *Deprecated:* if
++	// ServiceMonitors to be selected for target discovery. *Warning:* if
+ 	// neither this nor podMonitorSelector are specified, configuration is
+ 	// unmanaged.
+ 	ServiceMonitorSelector *metav1.LabelSelector `json:""serviceMonitorSelector,omitempty""`","Hmm, I'm not sure this is exactly what we want to get across. The behavior of leaving both values unset allowing the entire config to be managed is what is indeed deprecated. It's just that not the entire field is deprecated, just that one behavior.",Why are we dropping the `Deprecated` an
+7463,"@@ -146,10 +146,17 @@ static void complete_cb (struct bulk_exec *exec, void *arg)
+ static void output_cb (struct bulk_exec *exec, flux_subprocess_t *p,
+                        const char *stream,
+                        const char *data,
+-                       int data_len,
++                       int len,
+                        void *arg)
+ {
+     struct jobinfo *job = arg;
++    const char *cmd = flux_cmd_arg (flux_subprocess_get_cmd (p), 0);
++    jobinfo_log_output (job,
++                        flux_subprocess_rank (p),
++                        basename (cmd),
++                        stream,
++                        data,
++                        len);
+     flux_log (job->h, LOG_INFO, ""%ju: %d: %s: %s"",
+                       (uintmax_t) job->id,
+                       flux_subprocess_rank (p),","Given the slightly vague discussion in basename(3) about POSIX basename (modifies arg) vs GNU (doesn't), I always assumed it was advisable to pass a string copy However, I guess you'd get a ""discarding const"" warning promoted to error by our build system here if you were getting the POSIX implementation. Hah! Cool, I probably can go remove some memory copies in other parts of the code where those conditions exist.",This doesn't seem right to me. Why do y
+7464,"@@ -81,12 +81,12 @@ public class MetricManagerTest {
+   @Test
+   public void managerEmitterHandlingTest() throws Exception {
+     this.emitter.purgeAllData();
+-    final Date from = DateTime.now().minusMinutes(1).toDate();
++    final Date from = DateTime.now().minusMinutes(10).toDate();
+     this.metric.notifyManager();
+
+     this.emitterWrapper.countDownLatch.await(10L, TimeUnit.SECONDS);
+
+-    final Date to = DateTime.now().plusMinutes(1).toDate();
++    final Date to = DateTime.now().plusMinutes(10).toDate();
+     final List<InMemoryHistoryNode> nodes = this.emitter.getMetrics(""FakeMetric"", from, to, false);
+
+     assertEquals(""Failed to report metric"", 1, nodes.size());","Do you know somehow that this was the culprit? Even 1 minute is a lot, so I would expect the bug to lie somewhere else.",Why don't we have a shorter timeout?
+7465,"@@ -146,7 +146,9 @@ void ActiveHostsMan::cleanExpiredHosts() {
+         LOG(INFO) << ""set "" << data.size() << "" expired hosts to offline in meta rocksdb"";
+         kvstore_->asyncMultiPut(kDefaultSpaceId, kDefaultPartId, std::move(data),
+                                 [] (kvstore::ResultCode code) {
+-            CHECK_EQ(code, kvstore::ResultCode::SUCCEEDED);
++            if (code != kvstore::ResultCode::SUCCEEDED) {
++                LOG(WARNING) << ""put failed, ret "" << static_cast<int32_t>(code);
++            }
+         });
+     }
+ }",what to do if some failed? just logging?,This should be a LOG(WARNING) since
+7466,"@@ -16,6 +16,19 @@ module Faker
+         fetch('quote.famous_last_words')
+       end
+
++      ##
++      # Produces a quote from Deep Thoughts by Jack Handey.
++      #
++      # @return [String]
++      #
++      # @example
++      #   Faker::Quote.deep_thoughts # => ""I hope life isn't a big joke, because I don't get it.""
++      #
++      # @faker.version next
++      def deep_thoughts
++        fetch('quote.deep_thoughts')
++      end
++
+       ##
+       # Produces a quote from Matz.
+       #",since these thoughts are all Jack Handey's the generator should probably be called `jack_handey` to reflect that.,Should be `Dependabot::Quote.deep_th
+7467,"@@ -288,6 +288,8 @@ type Container struct {
+
+ 	Environment map[string]*string `locationName:""environment"" type:""map""`
+
++	EnvironmentFiles []*EnvironmentFile `locationName:""environmentFiles"" type:""list""`
++
+ 	Essential *bool `locationName:""essential"" type:""boolean""`
+
+ 	FirelensConfiguration *FirelensConfiguration `locationName:""firelensConfiguration"" type:""structure""`",this file is autogenerated. you should edit `model/api/api-2.json` and then go generate this file. otherwise the next people generating api.go will remove the changes you added here,Can you please change this to *[]str
+7468,"@@ -0,0 +1,8 @@
++class ProgressBarsController < ApplicationController
++
++  def show
++    _trail = Trail.find(params[:trail_id])
++    @trail = TrailWithProgress.new(_trail, user: current_user)
++    render layout: false
++  end
++end",Extra empty line detected at class body beginning.,Extra empty line detected at class body beginning.
+7469,"@@ -934,7 +934,9 @@ public class ExecutorManager extends EventHandler implements
+   @Override
+   public String submitExecutableFlow(ExecutableFlow exflow, String userId)
+     throws ExecutorManagerException {
+-    synchronized (exflow) {
++
++    String exFlowKey = exflow.getProjectName() + ""."" + exflow.getId() + "".submitFlow"";
++    synchronized (exFlowKey.intern()) {
+       String flowId = exflow.getFlowId();
+
+       logger.info(""Submitting execution flow "" + flowId + "" by "" + userId);",This is smart but hacky! I would probably prefer an alternate solution that would be more obvious to read/understand.,"Shouldn't this be exflow.getProjectName() + ""."" + "
+7470,"@@ -115,7 +115,7 @@ type Client interface {
+ 	S3StreamingGet(ctx context.Context, region string, bucket string, key string) (io.ReadCloser, error)
+
+ 	DescribeTable(ctx context.Context, region string, tableName string) (*dynamodbv1.Table, error)
+-	UpdateTableCapacity(ctx context.Context, region string, tableName string, targetIndexRcu int64, targetIndexWcu int64) error
++	UpdateTableCapacity(ctx context.Context, region string, tableName string, targetTableRcu int64, targetTableWcu int64) (*dynamodbv1.Status, error)
+
+ 	Regions() []string
+ }",i would not return a pointer for status here which is an int,"Can we keep this as `indexRcu int64, targetIndexWc"
+7471,"@@ -67,6 +67,10 @@ exclude = [""AuthalicMatrixCoefficients"",
+            ""vnl_file_matrix"",
+            ""vnl_file_vector"",
+            ""vnl_fortran_copy"",
++           ""CosineWindowFunction"",
++           ""HammingWindowFunction"",
++           ""LanczosWindowFunction"",
++           ""WelchWindowFunction"",
+            ]
+
+ total = 0","Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now).",why do we need to add these?
+7472,"@@ -89,6 +89,7 @@ class Uppy {
+         enterTextToSearch: 'Enter text to search for images',
+         backToSearch: 'Back to Search',
+         emptyFolderAdded: 'No files were added from empty folder',
++        folderAlreadyAdded: 'The folder was already added',
+         folderAdded: {
+           0: 'Added %{smart_count} file from %{folder}',
+           1: 'Added %{smart_count} files from %{folder}',",Should we specify the name of the folder?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+7473,"@@ -14,7 +14,7 @@ from rdkit import RDConfig, rdBase
+ from rdkit import DataStructs
+ from rdkit import Chem
+ import rdkit.Chem.rdDepictor
+-from rdkit.Chem import rdqueries
++from rdkit.Chem import rdqueries, rdmolops
+
+ from rdkit import __version__
+ ","it's not wrong, but you don't technical need `rdmolops` here since it's imported as part of `Chem`",Please remove this line. It's not used anymore.
+7474,"@@ -534,6 +534,7 @@ class InfluxListenStore(ListenStore):
+
+             pxz.stdin.close()
+
++        pxz.wait()
+         self.log.info('ListenBrainz listen dump done!')
+         self.log.info('Dump present at %s!', archive_path)
+         return archive_path","I think the absence of this might have been the cause of the dump file corruption. We didn't wait for the pxz command to exit, leading to a race condition between the cp and this, leading to corrupted files in some places. I came across this because the hashes created and printed were different from the hashes of the actual files in dev also.","ohh, I see that you are doing this. Is there any way to do this without waiting?"
+7475,"@@ -27,7 +27,7 @@ type blockchainConfig struct {
+ }
+
+ type LoggingConfig struct {
+-	Level logging.Level `required:""true"" default:""debug""`
++	Level *logging.Level `required:""true"" default:""info""`
+ }
+
+ func NewConfig(path string) (*Config, error) {",Out of the scope.,@deads2k i'm not sure if this should be default to info or not?
+7476,"@@ -1,11 +1,11 @@
+ describe('ColumnSorting', () => {
+-  var id = 'testContainer';
++  const id = 'testContainer';
+
+   beforeEach(function() {
+     this.$container = $(`<div id=""${id}"" style=""overflow: auto; width: 300px; height: 200px;""></div>`).appendTo('body');
+
+-    this.sortByColumn = function(columnIndex) {
+-      var element = this.$container.find(`th span.columnSorting:eq(${columnIndex})`);
++    this.sort = function(columnIndex) {
++      const element = this.$container.find(`th span.columnSorting:eq(${columnIndex})`);
+
+       element.simulate('mousedown');
+       element.simulate('mouseup');",Maybe `sortByColumnHeader` would be more precise? The plugin has a method with the same name and it could be confusing.,`this.sortByColumn =` -> `this.sort`
+7477,"@@ -36,7 +36,8 @@ export function diffChildren(
+ 	oldDom,
+ 	isHydrating
+ ) {
+-	let i, j, oldVNode, childVNode, newDom, firstChildDom, refs;
++	let i, j, oldVNode, childVNode, newDom, firstChildDom;
++	let refs = [];
+
+ 	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
+ 	// as EMPTY_OBJ._children should be `undefined`.",@developit I vaguely remember you mentioning something about some JS engines having an escape analysis feature that makes objects (and arrays?) locally declared that never leave the function essentially free from a GC perspective or something. Do you think we could benefit from that here? Or should we leave this as it is?,Why is this change necessary?
+7478,"@@ -1252,6 +1252,8 @@ func invertOpForLocalNotifications(oldOp op) (newOp op, err error) {
+ 		}
+ 	case *GCOp:
+ 		newOp = op
++	case *resolutionOp:
++		newOp = op
+ 	}
+
+ 	// Now reverse all the block updates.  Don't bother with bare Refs",Remind me why this is needed?,"As far as I can tell, the only diffe"
+7479,"@@ -64,6 +64,14 @@ public final class ConstantScoreQuery extends Query {
+     return super.rewrite(reader);
+   }
+
++  @Override
++  public void visit(QueryVisitor visitor) {
++    QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.FILTER, this);
++    if (v != null) {
++      query.visit(v);
++    }
++  }
++
+   /** We return this as our {@link BulkScorer} so that if the CSQ
+    *  wraps a query with its own optimized top-level
+    *  scorer (e.g. BooleanScorer) we can use that","same as above, can this be null now?",I don't think we need this filter at
+7480,"@@ -319,8 +319,8 @@ public class SparkOrcWriter implements OrcValueWriter<InternalRow> {
+         // make sure the child is big enough
+         cv.child.ensureSize(cv.childCount, true);
+         // Add each element
+-        for (int e = 0; e < cv.lengths[rowId]; ++e) {
+-          children.addValue((int) (e + cv.offsets[rowId]), e, value, cv.child);
++        for (long e = 0; e < cv.lengths[rowId]; ++e) {
++          children.addValue((int) (e + cv.offsets[rowId]), (int) e, value, cv.child);
+         }
+       }
+     }",This doesn't make sense to me. Should `cv.lengths` be an integer array instead of longs? It looks like they should always be integers since the values are assigned from `ArrayData#numElements()`. That's very likely an int.,why not `long`?
+7481,"@@ -1920,7 +1920,18 @@ namespace pwiz.Skyline.Model.Results
+                 }
+                 else if (id.StartsWith(MsDataFileImpl.PREFIX_PRECURSOR))
+                 {
+-                    precursor = double.Parse(id.Substring(MsDataFileImpl.PREFIX_TOTAL.Length), CultureInfo.InvariantCulture);
++                    var str = id.Substring(MsDataFileImpl.PREFIX_PRECURSOR.Length);
++                    if (!double.TryParse(str, NumberStyles.Float, CultureInfo.InvariantCulture, out precursor))
++                    {
++                        if (str.StartsWith(@""Q1=""))
++                        {
++                            str = str.Substring(3);
++                            var tail = str.IndexOf(' ');
++                            if (tail > 0)
++                                str = str.Substring(0, tail);
++                        }
++                        precursor = double.Parse(str, CultureInfo.InvariantCulture);
++                    }
+                     product = precursor;
+                 }
+                 else if (id.StartsWith(MsDataFileImpl.PREFIX_SINGLE))",str.Substring(3).Split(' ')[0] would also work and is more concise.,Looks like this
+7482,"@@ -198,7 +198,8 @@ void nano::node::keepalive (std::string const & address_a, uint16_t port_a, bool
+ 			{
+ 				auto endpoint (nano::map_endpoint_to_v6 (i->endpoint ()));
+ 				node_l->send_keepalive (endpoint);
+-				if (preconfigured_peer_a)
++				// Force insert only for local preconfigured peers
++				if (preconfigured_peer_a && node_l->config.allow_local_peers && node_l->peers.not_a_peer (endpoint, false))
+ 				{
+ 					node_l->peers.insert (endpoint, nano::protocol_version, true);
+ 				}",Did you mean to negate the not_a_peer check?,Shouldn't this
+7483,"@@ -1,6 +1,6 @@
+ /*
+  * DBeaver - Universal Database Manager
+- * Copyright (C) 2010-2021 DBeaver Corp and others
++ * Copyright (C) 2010-2017 Serge Rider (serge@jkiss.org)
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.",Copyright (C) 2010-2021 DBeaver Corp and others,I don't think y
+7484,"@@ -22,9 +22,8 @@
+ We use this to be able to highlight parts of the text.
+ """"""
+
+-import re
+ import html
+-
++import re
+ from PyQt5.QtWidgets import QStyle, QStyleOptionViewItem, QStyledItemDelegate
+ from PyQt5.QtCore import QRectF, QSize, Qt
+ from PyQt5.QtGui import (QIcon, QPalette, QTextDocument, QTextOption,",This seems like an unrelated change,"The `html` import is no longer used in this file, it can be removed."
+7485,"@@ -48,6 +48,10 @@ func (l *linuxStandardInit) Init() error {
+ 	runtime.LockOSThread()
+ 	defer runtime.UnlockOSThread()
+ 	if !l.config.Config.NoNewKeyring {
++		if err := label.SetKeyLabel(l.config.ProcessLabel); err != nil {
++			return err
++		}
++		defer label.SetKeyLabel("""")
+ 		ringname, keepperms, newperms := l.getSessionRingParams()
+
+ 		// Do not inherit the parent's session keyring.",Just to double-check -- are you sure this needs to be done *before* we create a new session? (Is `SetKeyLabel` setting what the label will be for all future keys or the label for the current key?),Is there a reason we're not using `l.config.ProcessLabel` directly?
+7486,"@@ -47,6 +47,19 @@ using LocatorSelectorEntry = fastrtps::rtps::LocatorSelectorEntry;
+ using LocatorSelector = fastrtps::rtps::LocatorSelector;
+ using PortParameters = fastrtps::rtps::PortParameters;
+
++namespace eprosima {
++namespace fastdds {
++namespace rtps {
++
++static constexpr SharedMemTransportDescriptor::OverflowPolicy shm_default_overflow_policy =
++            SharedMemTransportDescriptor::OverflowPolicy::DISCARD;
++
++
++} // namespace rtps
++} // namespace fastdds
++} // namespace eprosima
++
++
+ TransportInterface* SharedMemTransportDescriptor::create_transport() const
+ {
+     return new SharedMemTransport(*this);",I thought we were removing the FAIL policy altogether....,Why does the default overflow policy not exist in the header?
+7487,"@@ -14,7 +14,7 @@
+
+ def txt2tags_actionFunc(target,source,env):
+ 	import txt2tags
+-	txt2tags.exec_command_line([str(source[0])])
++	txt2tags.exec_command_line([""--outfile"", str(source[0])[:-3] + ""html"", str(source[0])])
+
+ def exists(env):
+ 	try:",Could you elaborate on why you made this change?,You probably want to make this into a constant so it doesn't get rec
+7488,"@@ -374,6 +374,9 @@ TEST(Scanner, Basic) {
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\110 \"""", TokenType::STRING, ""\\H ""),
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\\110 \"""", TokenType::STRING, ""\\\\110 ""),
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\\\110 \"""", TokenType::STRING, ""\\\\H ""),
++
++
++        CHECK_SEMANTIC_VALUE(""\""己所不欲，勿施于人\"""", TokenType::STRING, ""己所不欲，勿施于人""),
+     };
+ #undef CHECK_SEMANTIC_TYPE
+ #undef CHECK_SEMANTIC_VALUE","before the fix, does this sentence make service crash? My point is can you re-produce the problem. I'm not sure the bug is due to non-asiic code",I don't think this should be in a test file.
+7489,"@@ -86,7 +86,7 @@ func repoAssignment() macaron.Handler {
+ // Contexter middleware already checks token for user sign in process.
+ func reqToken() macaron.Handler {
+ 	return func(c *context.Context) {
+-		if !c.IsLogged {
++		if true != c.Data[""IsApiToken""] {
+ 			c.Error(401)
+ 			return
+ 		}","This comparison looks a bit strange, we should first check existence of key ""IsApiToken"" and then check if it is equal to true. ~~Besdies, s/IsApiToken/IsAuthedByToken/~~",`IsApiToken` is only set when `IsApiToken` i
+7490,"@@ -568,10 +568,12 @@ func (r *ReconcileClusterSync) applySyncSets(
+ 			ObservedGeneration: syncSet.AsMetaObject().GetGeneration(),
+ 			Result:             hiveintv1alpha1.SuccessSyncSetResult,
+ 		}
+-		if syncSet.GetSpec().ResourceApplyMode == hivev1.SyncResourceApplyMode {
++		applyMode := syncSet.GetSpec().ResourceApplyMode
++		if applyMode == hivev1.SyncResourceApplyMode {
+ 			newSyncStatus.ResourcesToDelete = resourcesApplied
+ 		}
+-		if syncSet.GetSpec().ResourceApplyMode == hivev1.UpsertResourceApplyMode && len(oldSyncStatus.ResourcesToDelete) > 0 {
++		// applyMode defaults to UpsertResourceApplyMode
++		if (applyMode == hivev1.UpsertResourceApplyMode || applyMode == """") && len(oldSyncStatus.ResourcesToDelete) > 0 {
+ 			logger.Infof(""resource apply mode is %v but there are resources to delete in clustersync status"", hivev1.UpsertResourceApplyMode)
+ 			oldSyncStatus.ResourcesToDelete = nil
+ 		}","This might be working as is, but I'm a bit thrown by the || and then && and how things get evaluated. Testing real quick on the go playground, true || false && false seems to either evaluate the && first, or start on the right side. Anyhow could you group with braces, it looks to me like it should be ( a || b) && c in this case?",Why should we default to `UpsertResourceAppl
+7491,"@@ -0,0 +1,17 @@
++// Copyright (c) 2020 IoTeX Foundation
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package main
++
++import (
++	""github.com/iotexproject/iotex-core/ioctl/cmd""
++	""github.com/iotexproject/iotex-core/ioctl/cmd/account""
++)
++
++func main() {
++	account.CryptoSm2 = true
++	cmd.Execute()
++}",add an entry in makefile to generate binary with diff name?,You don't need this line here.
+7492,"@@ -115,6 +115,10 @@ func validatePagerDutyConfigs(configs []monitoringv1alpha1.PagerDutyConfig) erro
+ 		if conf.RoutingKey == nil && conf.ServiceKey == nil {
+ 			return errors.New(""one of 'routingKey' or 'serviceKey' is required"")
+ 		}
++
++		if err := conf.HTTPConfig.Validate(); err != nil {
++			return err
++		}
+ 	}
+ 	return nil
+ }",hmm so we didn't validate the HTTP config for all receivers?,Shouldn't we check that `conf.HTTPConfig != nil` before validating it?
+7493,"@@ -49,5 +49,14 @@ namespace OpenTelemetry.Context.Propagation
+         /// <param name=""getter"">Function that will return string value of a key with the specified name.</param>
+         /// <returns>Span context from it's text representation.</returns>
+         SpanContext Extract<T>(T carrier, Func<T, string, IEnumerable<string>> getter);
++
++        /// <summary>
++        /// Tests if an activity context has been injected into a carrier.
++        /// </summary>
++        /// <typeparam name=""T"">Type of object to extract context from. Typically HttpRequest or similar.</typeparam>
++        /// <param name=""carrier"">Object to extract context from. Instance of this object will be passed to the getter.</param>
++        /// <param name=""getter"">Function that will return string value of a key with the specified name.</param>
++        /// <returns><see langword=""true"" /> if the carrier has been injected with an activity context.</returns>
++        bool IsInjected<T>(T carrier, Func<T, string, IEnumerable<string>> getter);
+     }
+ }","ITextFormatActivity had this, can I add to have the same effect?","If you're seeing this pattern in a few places, I'd suggest moving it t"
+7494,"@@ -20,8 +20,11 @@ import (
+ 	""sync""
+ 	""time""
+
++	""github.com/aws/amazon-ecs-agent/agent/containerresource""
++	""github.com/aws/amazon-ecs-agent/agent/containerresource/containerstatus""
++
+ 	apicontainerstatus ""github.com/aws/amazon-ecs-agent/agent/api/container/status""
+-	apierrors ""github.com/aws/amazon-ecs-agent/agent/api/errors""
++	apierrors ""github.com/aws/amazon-ecs-agent/agent/apierrors""
+ 	""github.com/aws/amazon-ecs-agent/agent/credentials""
+ 	resourcestatus ""github.com/aws/amazon-ecs-agent/agent/taskresource/status""
+ ",not blocking: can we remove extra lines here?,Should we call it `apiclientstatus`?
+7495,"@@ -44,7 +44,7 @@ var PrivateKey = function PrivateKey(data, network, compressed) {
+   };
+
+   // detect type of data
+-  if (!data){
++  if (typeof(data) === 'undefined' || data === 'random'){
+     info.bn = PrivateKey._getRandomBN();
+   } else if (data instanceof BN) {
+     info.bn = data;",This just feels weird... can we use some kind of constant here? something like: `if (_.isUndefined(data) || data === PrivateKey.Random)`,Why not `typeof data === 'object'`?
+7496,"@@ -61,9 +61,12 @@ class ProjectorCompilerPass implements CompilerPassInterface
+             }
+
+             $parameters = $method->getParameters();
+-            $eventClass = (string) $parameters[0]->getType();
+
+-            $definition->addMethodCall('add', [new Reference($serviceId), $eventClass]);
++            $class = $parameters[0]->getClass();
++            if ($class) {
++                $eventClass = $class->getName();
++                $definition->addMethodCall('add', [new Reference($serviceId), $eventClass]);
++            }
+         }
+     }
+ }",if does not have a class I guess the exception should be thrown because we cannot recognize the type based on it?,Why did you have to change this line?
+7497,"@@ -262,12 +262,18 @@ public final class DiscoveryMethodModel implements MethodModel {
+   }
+
+   private DiscoveryField createFieldMaskField() {
++    // TODO(andrealin): Change this to a Set instead of a List.
+     return DiscoveryField.create(
+         StandardSchemaGenerator.createListSchema(
+             StandardSchemaGenerator.createStringSchema(
+                 """", SurfaceNamer.Cardinality.NOT_REPEATED, true),
+             DiscoveryMethodTransformer.FIELDMASK_STRING,
+-            true),
++            true,
++            ""The fields that should be serialized (empty values will be serialized). ""
++                + ""If the containing message object has a non-null fieldmask, ""
++                + ""then all the fields in the field mask (and only those fields in the field mask) ""
++                + ""will be serialized. If the containing object does not have a fieldmask, then ""
++                + ""only non-empty fields will be serialized. ""),
+         null);
+   }
+ ",LOL: use your GitHub username?,Missing period at the end of sentence
+7498,"@@ -116,6 +116,16 @@ public class Key implements Comparable<Key> {
+     return toRawKey(Arrays.copyOf(value, value.length + 1));
+   }
+
++  /**
++   * nextPrefix key will be key with next available rid. For example, if the current key is
++   * prefix_rid, after calling this method, the return value should be prefix_rid+1
++   *
++   * @return a new key current rid+1.
++   */
++  public Key nextPrefix() {
++    return toRawKey(prefixNext(value));
++  }
++
+   /**
+    * The prefixNext key for bytes domain
+    *",any tests for nextPrefix() ?,typo: r instead of current rid
+7499,"@@ -482,7 +482,7 @@ public class PrettyPrintVisitor implements VoidVisitor<Void> {
+         printMemberAnnotations(n.getAnnotations(), arg);
+         printModifiers(n.getModifiers());
+         if (!n.getVariables().isEmpty()) {
+-            n.getMaximumCommonType().accept(this, arg);
++            n.getMaximumCommonType().ifPresent(t -> t.accept(this, arg));
+         }
+
+         printer.print("" "");","In general I'm saying ""if there is no common type I'm just going to skip some stuff and fail silently.""",If the maximum common type is not spe
+7500,"@@ -19,10 +19,10 @@ package v1alpha1
+ import (
+ 	""context""
+
++	""github.com/google/knative-gcp/pkg/logging""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/equality""
+ 	""knative.dev/eventing/pkg/apis/messaging""
+-	""knative.dev/eventing/pkg/logging""
+ 	""knative.dev/pkg/apis""
+
+ 	""github.com/google/knative-gcp/pkg/apis/configs/gcpauth""","did we move the eventing logging here? Probably the eventing logging was removing and they are now using the pkg logging in eventing. If that is the case, we should do the same here",Is this import still needed?
+7501,"@@ -50,8 +50,7 @@ type Filter func(*http.Request) bool
+ // the mux are wrapped with WithRouteTag. A Handler will add various attributes
+ // to the span using the core.Keys defined in this package.
+ type Handler struct {
+-	operation string
+-	handler   http.Handler
++	handler http.Handler
+
+ 	tracer           trace.Tracer
+ 	props            propagation.Propagators","I think that `Handler` should preserve the `operation` member and the span formatter should receive the operation name string as a parameter too, otherwise the `operation` parameter in the `NewHandler` function becomes useless if we pass a custom span formatter. Also, shouldn't it be called `spanNameFormatter`?",Why did you change this? It
+7502,"@@ -67,7 +67,7 @@ class HSRPmd5(Packet):
+         ByteEnumField(""algo"", 0, {1: ""MD5""}),
+         ByteField(""padding"", 0x00),
+         XShortField(""flags"", 0x00),
+-        IPField(""sourceip"", None),
++        IPField(""sourceip"", ""127.0.0.1""),
+         XIntField(""keyid"", 0x00),
+         StrFixedLenField(""authdigest"", ""\00"" * 16, 16)]
+ ","Can you merge #466? That would make the current `None` default value working and more relevant that `""127.0.0.1""`.",Any reason why this is hardc
+7503,"@@ -96,14 +96,15 @@ func (v *Validator) Validate(searchAttributes *commonpb.SearchAttributes, namesp
+ 	}
+
+ 	for saName, saPayload := range searchAttributes.GetIndexedFields() {
+-		if IsReservedField(saName) {
+-			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is Temporal reserved field name"", saName))
++		if !typeMap.IsDefined(saName) {
++			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is not a valid search attribute name"", saName))
+ 		}
+
+-		saType, err := typeMap.GetType(saName)
++		saType, err := typeMap.getType(saName, customCategory|predefinedCategory)
+ 		if err != nil {
+-			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is not a valid search attribute name"", saName))
++			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s attribute can't be set in SearchAttributes: reserved field name"", saName))
+ 		}
++
+ 		_, err = DecodeValue(saPayload, saType)
+ 		if err != nil {
+ 			var invalidValue interface{}",is reserved filed name the only possible reason this could fail?,The above check is doing the
+7504,"@@ -169,6 +169,10 @@ func defaultLogPath(ctx Context) string {
+
+ // DefaultInitParams returns default init params
+ func DefaultInitParams(ctx Context) InitParams {
++	journalEnv := os.Getenv(""KBFS_ENABLE_JOURNAL"")
++	if journalEnv == """" {
++		journalEnv = ""true""
++	}
+ 	return InitParams{
+ 		Debug:            BoolForString(os.Getenv(""KBFS_DEBUG"")),
+ 		BServerAddr:      defaultBServer(ctx),",Would a KBFS_DISABLE_JOURNAL make more sense?,Let's default to the value of `KBFS_ENABLE_JOURNAL`.
+7505,"@@ -40,6 +40,8 @@ void DropSpaceExecutor::execute() {
+         if (*spaceName_ == ectx()->rctx()->session()->spaceName()) {
+             ectx()->rctx()->session()->setSpace("""", -1);
+         }
++        ectx()->addWarningMsg(""Data will be deleted completely after restarting the services"");
++
+         doFinish(Executor::ProcessControl::kNext);
+     };
+ ",BTW. What's the message meaning?...,The problem was that this function will be called af
+7506,"@@ -289,4 +289,15 @@ describe Mongoid::Extensions::Object do
+       end
+     end
+   end
++
++  describe ""#numeric?"" do
++
++    let(:object) do
++      Object.new
++    end
++
++    it ""returns false"" do
++      expect(object.numeric?).to eq(false)
++    end
++  end
+ end",this should say false,Prefer single-quoted strings when you don't need str
+7507,"@@ -1,3 +1,4 @@
++//go:build unit
+ // +build unit
+
+ // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.",for my understanding - are this line and the next line both necessary? they seem to contain duplicate information. same for the other test files,Did you mean to commit this file?
+7508,"@@ -102,6 +102,13 @@ def _get_search_url(txt):
+         engine = 'DEFAULT'
+     template = config.val.url.searchengines[engine]
+     url = qurl_from_user_input(template.format(urllib.parse.quote(term)))
++
++    if config.val.url.open_base_url and \
++            term in config.val.url.searchengines.keys():
++        url = qurl_from_user_input(config.val.url.searchengines[term])
++        url.setPath(None)
++        url.setFragment(None)
++        url.setQuery(None)
+     qtutils.ensure_valid(url)
+     return url
+ ","No need for the `.keys()`, iterating over a dictionary gives you its keys (and thus you can also do `key in some_dict`). With that, it also fits on one line :wink:",The `open_base_url` check here can be simplified to just: `if config.val.url.open_base_url and config.val.url.searchengines[term]:`
+7509,"@@ -24,14 +24,6 @@ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {
+
+-IPLocator::IPLocator()
+-{
+-}
+-
+-IPLocator::~IPLocator()
+-{
+-}
+-
+ // Factory
+ void IPLocator::createLocator(
+         int32_t kindin,","If we want to avoid the user calling constructor and destructor, we should add `= delete` to their declarations. If we just want to avoid writing the default behavior, we should add `= default` to the declarations. I'm more in favor of the second option to avoid an API break.",Why was this removed?
+7510,"@@ -269,12 +269,12 @@ class GrapheneObjectStoreOperationResult(graphene.ObjectType):
+         return _to_metadata_entries(self.metadata_entries)  # pylint: disable=no-member
+
+
+-class GrapheneMaterialization(graphene.ObjectType):
++class GrapheneMaterializationOrObservation(graphene.ObjectType):
+     assetKey = graphene.Field(GrapheneAssetKey)
+
+     class Meta:
+         interfaces = (GrapheneDisplayableEvent,)
+-        name = ""Materialization""
++        name = ""MaterializationOrObservation""
+
+     def resolve_metadataEntries(self, _graphene_info):
+         from ...implementation.events import _to_metadata_entries",My preference here is to keep a stricter hierarchy. We should have a mixin or something that is an AssetEvent that Observation and Materialization can both inherit from. That way we can check the type in the frontend if we need to.,I'm not sure if it should be called `MaterializationOrObservation` - maybe it should be `MaterializationOrObservation`?
+7511,"@@ -212,7 +212,7 @@ class SpatialPoolerTest(unittest.TestCase):
+
+     # Get only the active column indices
+     spOutput = [i for i, v in enumerate(activeArray) if v != 0]
+-    self.assertEqual(spOutput, expectedOutput)
++    self.assertEqual(sorted(spOutput), expectedOutput)
+
+
+   def testStripNeverLearned(self):",Can also cast them as `set`s and compare them.,"I'm sort of surprised that the tests didn't pick up the ordering here, but I guess this is sort of the best part of the PR."
+7512,"@@ -0,0 +1 @@
++package trigger",Still TODO I guess?,This seems to be missing
+7513,"@@ -37,8 +37,6 @@
+ #include <fastdds/rtps/builtin/BuiltinProtocols.h>
+ #include <fastdds/rtps/builtin/liveliness/WLP.h>
+
+-#include <functional>
+-
+ using namespace eprosima::fastrtps;
+ using namespace ::rtps;
+ using namespace std::chrono;",Another cleanup. There are two additional `using namespace std::chrono;` under this one. Should also remove std::chrono:: from the full file. Please do this on a single commit.,Why did you remove the f
+7514,"@@ -501,7 +501,7 @@ public final class JavaParserMetaModel {
+         enclosedExprMetaModel.getDeclaredPropertyMetaModels().add(enclosedExprMetaModel.innerPropertyMetaModel);
+         fieldAccessExprMetaModel.namePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""name"", com.github.javaparser.ast.expr.SimpleName.class, Optional.of(simpleNameMetaModel), false, false, false, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.namePropertyMetaModel);
+-        fieldAccessExprMetaModel.scopePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""scope"", com.github.javaparser.ast.expr.Expression.class, Optional.of(expressionMetaModel), true, false, false, false, false);
++        fieldAccessExprMetaModel.scopePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""scope"", com.github.javaparser.ast.expr.Expression.class, Optional.of(expressionMetaModel), false, false, false, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.scopePropertyMetaModel);
+         fieldAccessExprMetaModel.typeArgumentsPropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""typeArguments"", com.github.javaparser.ast.type.Type.class, Optional.of(typeMetaModel), true, false, true, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.typeArgumentsPropertyMetaModel);","Looking at this list of boolean flags I wonder if we should create enums for all of these options, so that the code becomes much more readable",why is this needed?
+7515,"@@ -29,8 +29,11 @@
+ #include <fastrtps/qos/QosPolicies.h>
+ #include <fastrtps/utils/TimeConversion.h>
+
++#include <rtps/builtin/data/ProxyHashTables.hpp>
++
+ #include <mutex>
+ #include <chrono>
++#include <unordered_set>
+
+ using namespace eprosima::fastrtps;
+ ",Is this necessary?,Please move this include
+7516,"@@ -0,0 +1,15 @@
++namespace Microsoft.Azure.Cosmos.CosmosElements
++{
++    internal abstract class CosmosElement
++    {
++        protected CosmosElement(CosmosElementType cosmosItemType)
++        {
++            this.Type = cosmosItemType;
++        }
++
++        public CosmosElementType Type
++        {
++            get;
++        }
++    }
++}",How about this NS inside query NS?,This should be an abstract class
+7517,"@@ -53,7 +53,7 @@ func LoadOrCreateAccount(sm protocol.StateManager, encodedAddr string) (*state.A
+ }
+
+ // LoadAccount loads an account state
+-func LoadAccount(sm protocol.StateManager, addrHash hash.Hash160) (*state.Account, error) {
++func LoadAccount(sm protocol.StateReader, addrHash hash.Hash160) (*state.Account, error) {
+ 	var account state.Account
+ 	if err := sm.State(addrHash, &account); err != nil {
+ 		if errors.Cause(err) == state.ErrStateNotExist {","in line 79, sm also can be stateReader",Why did you rename the `LoadAcco
+7518,"@@ -876,6 +876,13 @@ int32_t MetaClient::partsNum(GraphSpaceID spaceId) {
+     return it->second->partsAlloc_.size();
+ }
+
++std::unordered_map<HostAddr, std::vector<PartitionID>>
++MetaClient::partsBySpace(GraphSpaceID spaceId) {
++    folly::RWSpinLock::ReadHolder holder(localCacheLock_);
++    auto it = localCache_.find(spaceId);
++    CHECK(it != localCache_.end());
++    return it->second->partsOnHost_;
++}
+
+ folly::Future<StatusOr<TagID>>
+ MetaClient::createTagSchema(GraphSpaceID spaceId, std::string name, nebula::cpp2::Schema schema) {","maybe can not return a map directly, it will be modified by inner thread.",Shouldn't this return a `[0]` in
+7519,"@@ -299,7 +299,7 @@ class Diff(unittest.TestCase):
+                                                     cmp_data)
+         # Unesolved core checkers.
+         test_res = {'core.NullDereference': 4, 'core.DivideZero': 3}
+-        self.assertDictEqual(diff_res, test_res)
++        self.assertDictContainsSubset(test_res, diff_res)
+
+     def test_get_diff_checker_counts_all_unresolved(self):
+         """"""","What is the actual change here, why is this test change needed? Now the diff will send back more data?",There is no difference between `
+7520,"@@ -89,6 +89,17 @@ int RGroupDecomposition::add(const ROMol &inmol) {
+   const bool addCoords = true;
+   MolOps::addHs(mol, explicitOnly, addCoords);
+
++  // mark any wildcards in input molecule:
++  for (auto &atom : mol.atoms()) {
++    if (atom->getAtomicNum() == 0) {
++      atom->setIsotope(1000U);
++      // clean any existing R group numbers
++      atom->setAtomMapNum(0);
++      if (atom->hasProp(common_properties::_MolFileRLabel)) {
++        atom->clearProp(common_properties::_MolFileRLabel);
++      }
++    }
++  }
+   int core_idx = 0;
+   const RCore *rcore = nullptr;
+   std::vector<MatchVectType> tmatches;",Might be better to use a tag here. I for one have used 1000 isotopes as a tag in the past...,any reason to not just do `atom->setIsotope(0);`
+7521,"@@ -128,11 +128,11 @@ func TestSetName(t *testing.T) {
+ 	}
+ }
+
+-func TestRecordingIsOff(t *testing.T) {
++func TestRecordingIsOn(t *testing.T) {
+ 	tp, _ := NewProvider()
+ 	_, span := tp.Tracer(""Recording off"").Start(context.Background(), ""StartSpan"")
+ 	defer span.End()
+-	if span.IsRecording() == true {
++	if span.IsRecording() == false {
+ 		t.Error(""new span is recording events"")
+ 	}
+ }","This tests seems it was broken from the start :joy:. It ""worked"" because the old sample chance was small enough that this have always be off. Thanks for fixing this. Could you also change the strings on this test? `""Recording off""` and `""new span is recording events""`",Maybe rename this test to `TestRecordingIsOff` o
+7522,"@@ -44,6 +44,14 @@ public final class PmdParametersParseResult {
+         return !isError() && result.isHelp();
+     }
+
++    /**
++     * Returns whether parsing just requested the {@code --version} text.
++     * In this case no configuration is produced.
++     */
++    public boolean isVersion() {
++        return !isError() && result.isVersion();
++    }
++
+     /**
+      * Returns the error if parsing failed. Parsing may fail if required
+      * parameters are not provided, or if some parameters don't pass validation.","This is not actually the case, you need to modify `toConfiguration` below to prevent a configuration from being produced",Can we change this to `return result.isVersion()
+7523,"@@ -88,7 +88,7 @@ func (a *attestor) loadSVID(ctx context.Context) (*x509.Certificate, *ecdsa.Priv
+
+ 	svid := a.readSVIDFromDisk()
+ 	if len(fResp.PrivateKey) > 0 && svid == nil {
+-		a.c.Log.Warn(""Private key recovered, but no SVID found"")
++		a.c.Log.Debug(""Private key recovered, but no SVID found"")
+ 	}
+
+ 	var keyData []byte",I'm worried about we hide some important log here,Any reason why this should be a Debug?
+7524,"@@ -625,7 +625,7 @@ def start_workers(actions_map, actions, context, analyzer_config_map,
+                            callback=lambda results: worker_result_handler(
+                                results, metadata, output_path,
+                                context.analyzer_binaries)
+-                           ).get(float('inf'))
++                           ).get(31557600)
+
+             pool.close()
+         except Exception:","Python 3 will throw an exception for inf, but not providing a timeout will result in no timeout exception.",why do you change this?
+7525,"@@ -45,6 +45,18 @@ func (s *server) setupRouting() {
+ 		""POST"": http.HandlerFunc(s.chunkUploadHandler),
+ 	})
+
++	router.Handle(""/bzz-tag/name/{name}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getANewTag),
++	})
++
++	router.Handle(""/bzz-tag/addr/{addr}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getTagInfoUsingAddress),
++	})
++
++	router.Handle(""/bzz-tag/uuid/{uuid}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getTagInfoUsingUUid),
++	})
++
+ 	s.Handler = web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""api access""),
+ 		handlers.CompressHandler,","As this method changes the state, it should be `POST`. Also, maybe to rename it to `createTag`?",I think we need to add
+7526,"@@ -24,6 +24,6 @@ func (e *Executor) ensureTrafficSplit(ctx context.Context) model.StageStatus {
+ 	return model.StageStatus_STAGE_SUCCESS
+ }
+
+-func (e *Executor) rollbackTraffic(ctx context.Context) model.StageStatus {
+-	return model.StageStatus_STAGE_SUCCESS
++func (e *Executor) rollbackTraffic(ctx context.Context) error {
++	return nil
+ }",`ctx` is unused in rollbackTraffic,Shouldn't this be `fals
+7527,"@@ -0,0 +1,12 @@
++
++using System;
++
++namespace SarifViewer
++{
++    internal sealed partial class Guids
++    {
++        public const string guidVSPackageString = ""b97edb99-282e-444c-8f53-7de237f2ec5e"";
++
++        public static Guid guidVSPackage = new Guid(guidVSPackageString);
++    }
++}",Roslyn conventions have const in PascalCase.,Would it make sense to
+7528,"@@ -112,7 +112,7 @@ public class ZookeeperStatusHandler extends RequestHandlerBase {
+           .map(h -> h.resolveClientPortAddress() + "":"" + h.clientPort)
+           .sorted().collect(Collectors.toList());
+       List<String> dynamicHosts = zkDynamicConfig.getServers().stream()
+-          .map(h -> h.resolveClientPortAddress() + "":"" + h.clientPort)
++          .map(h -> h.resolveClientPortAddress() + "":"" + (h.clientPort != null ? h.clientPort : ""2181""))
+           .sorted().collect(Collectors.toList());
+       if (!connStringHosts.containsAll(dynamicHosts)) {
+         errors.add(""Your ZK connection string ("" + connStringHosts.size() + "" hosts) is different from the "" +","This is not bullet proof if e.g. user has `clientPort=1234` in `zoo.cfg` and in zkHost connection string. Then we'll add a warning that dynamic config differs from zkHost, which is not entirely true since we just lack the port part. We have no way from client to read the `clientPort` from server except from connecting to the server with 4LW *ont the clientPort* which is a chicken and egg. This hack will make the comparison work for default port, which is a compromise.",In which case `h.clientPort` is null?
+7529,"@@ -1,8 +1,8 @@
+ #if MESSAGEPACK_2_1
+ using System;
+ using Datadog.Trace.ExtensionMethods;
+-using MessagePack;
+-using MessagePack.Formatters;
++using Datadog.Trace.Vendors.MessagePack;
++using Datadog.Trace.Vendors.MessagePack.Formatters;
+
+ namespace Datadog.Trace.Agent.MessagePack
+ {",We can probably delete this entire file. It's not used now and we'll (probably) write a custom serializer before we ever switch to MessagePack 2.1.,I don't think we need this `using` st
+7530,"@@ -174,8 +174,11 @@ class ConfigV1(Config):
+                 'limit': 'all',
+                 'playbook': 'playbook.yml',
+                 'raw_ssh_args': [
+-                    '-o UserKnownHostsFile=/dev/null', '-o IdentitiesOnly=yes',
+-                    '-o ControlMaster=auto', '-o ControlPersist=60s'
++                    '-o UserKnownHostsFile=/dev/null',
++                    '-o IdentitiesOnly=yes',
++                    '-o ControlMaster=auto',
++                    '-o ControlPersist=60s',
++                    '-o IdentitiesOnly=yes',
+                 ],
+                 'tags': False,
+                 'timeout': 30,",Aren't you duplicating this option?,did you mean to change this to spaces
+7531,"@@ -440,6 +440,17 @@ func (a *Analyzer) IsBuildFile(uri lsp.DocumentURI) bool {
+ 	return a.State.Config.IsABuildFile(base)
+ }
+
++// IsBuildDefFile takes a uri path and check if it's a valid .build_defs file
++func (a *Analyzer) IsBuildDefFile(uri lsp.DocumentURI) bool {
++	filepath, err := GetPathFromURL(uri, ""file"")
++	if err != nil {
++		return false
++	}
++
++	base := path.Base(filepath)
++	return strings.HasSuffix(base, "".build_defs"")
++}
++
+ // e.g. src type:list, required:false
+ func getArgString(argument asp.Argument) string {
+ 	argType := strings.Join(argument.Type, ""|"")",I'm not sure we should be doing this based on the extension? Calling them `.build_defs` is just a convention,Do we need this? I don't think we hav
+7532,"@@ -30,7 +30,6 @@ def unsupported_property(property_name, deprecated=False, reason=""""):
+ class _MissingPandasLikeIndex(object):
+
+     # Properties
+-    T = unsupported_property('T')
+     nbytes = unsupported_property('nbytes')
+     shape = unsupported_property('shape')
+ ",Should remove in `_MissingPandasLikeMultiIndex:` too,"I'm not sure about this change, `T` is not used in this scope."
+7533,"@@ -107,6 +107,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Defaults to false.
+ 	// +optional
+ 	CrossZoneLoadBalancing bool `json:""crossZoneLoadBalancing,omitempty""`
++
++	// Subnets specifies the subnets that should be used by the load balancer
++	// +optional
++	Subnets Subnets `json:""subnets,omitempty""`
+ }
+
+ // AWSClusterStatus defines the observed state of AWSCluster","We should scope this down to the bits that we're actually using, otherwise the API is going to be problematic, as it includes references to NAT gateways and public and/or private subnets. Copying the types to be more local to the task in hand is fine.",Does it make sense to mention the cross-zoneLoadBalancing flag
+7534,"@@ -45,6 +45,12 @@ type AWSDNSZoneSpec struct {
+ 	// to these tags,the DNS Zone controller will set a hive.openhsift.io/hostedzone tag
+ 	// identifying the HostedZone record that it belongs to.
+ 	AdditionalTags []AWSResourceTag `json:""additionalTags,omitempty""`
++
++	// Region is the AWS region to use for route53 operations.
++	// This defaults to us-east-1.
++	// For AWS China, use cn-northwest-1.
++	// +optional
++	Region string `json:""region,omitempty""`
+ }
+
+ // AWSResourceTag represents a tag that is applied to an AWS cloud resource",Is it is a hard requirement for this field to be 'cn-northwest-1' when wanting to interact with AWS China? It appears that putting in 'cn-north-1' would also result in using the alternative API endpoint (with the region overridden to use 'cn-northwest-1' for the created AWS client).,Does it make sense to change the default region to `us-east-1`
+7535,"@@ -812,7 +812,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+             Assert.IsType<Http2StreamErrorException>(thrownEx.InnerException);
+         }
+
+-        [Fact]
++        [Fact(Skip=""Flaky test #2799"")]
+         public async Task ContentLength_Received_MultipleDataFramesOverSize_Reset()
+         {
+             IOException thrownEx = null;",Stephen already fixed this one. Only the OverSize test is flaky now right?,Did you mean to leave this in?
+7536,"@@ -0,0 +1,6 @@
++<%= @activity %>
++
++<%= t(""mailer.proposal_link_text"",
++      proposal_url: proposal_url(@proposal)) %>
++
++<%= t(""mailer.footer"", feedback_url: feedback_url) %>","if the `activity_mailer` has a layout, should we include the footer in that? Realize there may also be conflicts with work @rememberlenny is working on...",Align the parameters of a method call if they span more than one line.
+7537,"@@ -16,6 +16,12 @@ require 'ruby_smb'
+ ENV['RACK_ENV'] = 'test'
+ $LOAD_PATH.unshift File.join(__dir__, 'lib')
+
++# Disables internationalized strings, which shouldn't be needed for tests.
++# This gets around an issue where Puppet::Environment and GettextSetup in
++# r10k are fighting over the same text domain within the FastGettext domain.
++# https://github.com/voxpupuli/ra10ke/issues/39
++Puppet[:disable_i18n] = true
++
+ RSpec.shared_context 'reset puppet settings' do
+   after :each do
+     # reset puppet settings so that they can be initialized again","This makes me nervous, mostly because I don't know very much about it. Will users run into the gettext error in the wild? I can't reproduce it locally, but it's hard to be 100% sure. Is disabling gettext in Pal an option?","This seems like a weird thing to do. If I understand correctly, this m"
+7538,"@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
+   public void unassignExecutor(int executionId) throws ExecutorManagerException {
+     executionExecutorMapping.remove(executionId);
+   }
++
++  @Override
++  public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
++      throws ExecutorManagerException {
++    return new ArrayList<>();
++  }
+ }",Is Java smart enough to know the generic type here? Never knew this.,Why not just return `Collections.emptyList()` ?
+7539,"@@ -71,7 +71,7 @@ public class BackupRepositoryFactory {
+     PluginInfo repo = Objects.requireNonNull(backupRepoPluginByName.get(name),
+         ""Could not find a backup repository with name "" + name);
+
+-    BackupRepository result = loader.newInstance(repo.className, BackupRepository.class);
++    BackupRepository result = loader.newInstance(repo, BackupRepository.class);
+     result.init(repo.initArgs);
+     return result;
+   }",no thought given to reload,Should be `className` instead of `ClassName`
+7540,"@@ -291,8 +291,17 @@ public abstract class ScheduledReporter implements Closeable, Reporter {
+         return shutdownExecutorOnStop;
+     }
+
+-    protected Set<MetricAttribute> getDisabledMetricAttributes() {
+-        return disabledMetricAttributes;
++    /**
++     * Check if Attribute disabled to be logged
++     * @param attribute metric attribute
++     * @return True if attribute is configured to be disabled
++     */
++    protected boolean isMetricAttributeDisabled(MetricAttribute attribute) {
++        if(disabledMetricAttributes != null && disabledMetricAttributes.contains(attribute)) {
++            return true;
++        }
++
++        return false;
+     }
+
+     private String calculateRateUnit(TimeUnit unit) {","Please, don't remove the `getDisabledMetricAttributes` method. All changes must be backward-compatible.","If the attribute is null, should we just return `false`?"
+7541,"@@ -195,7 +195,11 @@ function prepareDatabaseForSuite(suite, context) {
+     .admin()
+     .command({ killAllSessions: [] })
+     .catch(err => {
+-      if (err.message.match(/no such (cmd|command)/) || err.code === 11601) {
++      if (
++        err.message.match(/no such (cmd|command)/) ||
++        err.message.match(/Failed to kill on some hosts/) ||
++        err.code === 11601
++      ) {
+         return;
+       }
+ ",Is this left over from debugging?,can we call this `killOnAnyHosts` or something like that
+7542,"@@ -86,7 +86,7 @@ before(function(_done) {
+         }
+
+         this.configuration = new TestConfiguration(parsedURI, context);
+-        done();
++        client.close(done);
+       });
+     });
+   });",I've fallen for this before myself :) We _do_ call `close` inside of `done` on L65,this should be `this.client = client;`
+7543,"@@ -269,7 +269,9 @@ func (f *Fs) connect(ctx context.Context) (project *uplink.Project, err error) {
+ 	fs.Debugf(f, ""connecting..."")
+ 	defer fs.Debugf(f, ""connected: %+v"", err)
+
+-	cfg := uplink.Config{}
++	cfg := uplink.Config{
++		UserAgent: ""rclone"",
++	}
+
+ 	project, err = cfg.OpenProject(ctx, f.access)
+ 	if err != nil {","That looks fine! You could use `""rclone/""+fs.Version` too if you wanted. BTW does tardigrade use http under the hood? If you were using rclone's http Client then you'd get a User-Agent and you'd also get support for `-vv --dump bodies` and other nice things.",Do we need to set the user agent here? Why is it not set
+7544,"@@ -260,6 +260,10 @@ class FreeAnchorRetinaHead(RetinaHead):
+             Tensor: Negative bag loss in shape (num_img, num_anchors, num_classes).
+         """"""  # noqa: E501, W605
+         prob = cls_prob * (1 - box_prob)
+-        negative_bag_loss = prob**self.gamma * F.binary_cross_entropy(
+-            prob, torch.zeros_like(prob), reduction='none')
+-        return (1 - self.alpha) * negative_bag_loss
++        neg_prob = 1 - prob
++        # There are some cases when neg_prob = 0.
++        # This will cause the neg_prob.log() to be inf without clamp.
++        neg_prob = torch.clamp(neg_prob, min=1e-12)
++        negative_bag_loss = -prob**self.gamma * neg_prob.log()
++        negative_bag_loss = (1 - self.alpha) * negative_bag_loss
++        return negative_bag_loss","Adding one line `prob = prob.clamp(min=EPS, max=1-EPS)` already works.",The `min=1e-12` should be `1e-13`.
+7545,"@@ -118,7 +118,15 @@ namespace NLog.Targets.Wrappers
+         /// <param name=""overflowAction"">The action to be taken when the queue overflows.</param>
+         public AsyncTargetWrapper(Target wrappedTarget, int queueLimit, AsyncTargetWrapperOverflowAction overflowAction)
+         {
+-            RequestQueue = new AsyncRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#if NETSTANDARD2_0
++            // NetStandard20 includes many optimizations for ConcurrentQueue:
++            //  - See: https://blogs.msdn.microsoft.com/dotnet/2017/06/07/performance-improvements-in-net-core/
++            // Net40 ConcurrencyQueue can seem to leak, because it doesn't clear properly on dequeue
++            //  - See: https://blogs.msdn.microsoft.com/pfxteam/2012/05/08/concurrentqueuet-holding-on-to-a-few-dequeued-elements/
++            _requestQueue = new ConcurrentRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#else
++            _requestQueue = new AsyncRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#endif
+             TimeToSleepBetweenBatches = 50;
+             BatchSize = 200;
+             FullBatchSizeWriteLimit = 5;","another option would be to create a `CreateRequestQueue(bool lockingQeueue)`, and set it only in `InitializeTarget`, isn't? The would prefer having the creation and ""business"" rules for the creation in one region, I think `InitializeTarget` would be the best place.",I think it would be better to use
+7546,"@@ -805,7 +805,7 @@ static void subsurface_handle_place_above(struct wl_client *client,
+ 	}
+
+ 	wl_list_remove(&subsurface->parent_pending_link);
+-	wl_list_insert(sibling->parent_pending_link.prev,
++	wl_list_insert(&sibling->parent_pending_link,
+ 		&subsurface->parent_pending_link);
+
+ 	subsurface->reordered = true;","Wait, I think the `subsurface_handle_place_above` code was correct before. `place_above` means ""place it above in rendering order"" right?",wl_list_insert() can return a NULL
+7547,"@@ -4,9 +4,10 @@ public class Test {
+     /**
+      * Docstring that looks like a list:
+      *
+-     * <p>1. hey 2. there
++     * 1. hey
++     * 2. there
+      *
+-     * <p>with blank line.
++     * with blank line.
+      */
+     Void test() {
+         /*",why did this change?,Change from `<p>` to `<p>`
+7548,"@@ -15,12 +15,13 @@ import (
+ )
+
+ func TestBareRootMetadataVersionV3(t *testing.T) {
+-	tlfID := tlf.FakeID(1, false)
++	tlfID := tlf.FakeID(1, tlf.Private)
+
+ 	// All V3 objects should have SegregatedKeyBundlesVer.
+
+ 	uid := keybase1.MakeTestUID(1)
+-	bh, err := tlf.MakeHandle([]keybase1.UID{uid}, nil, nil, nil, nil)
++	bh, err := tlf.MakeHandle(
++		[]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, nil, nil, nil)
+ 	require.NoError(t, err)
+
+ 	rmd, err := MakeInitialBareRootMetadataV3(tlfID, bh)",Do you think we should have some tests here for `tlf.SingleTeam` too?,Can you do `keybase1.MakeUserOrTeam(uid.AsUserOrTeam())` instead?
+7549,"@@ -1,6 +1,8 @@
+ package table
+
+-import ""github.com/influxdata/flux""
++import (
++	""github.com/influxdata/flux""
++)
+
+ // Copy returns a buffered copy of the table and consumes the
+ // input table. If the input table is already buffered, it ""consumes""",No problem with this but might as well revert this file since nothing else changed.,Did you mean to include this change?
+7550,"@@ -14,18 +14,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         /// </summary>
+         public static void Register()
+         {
+-            Tracer.Instance = new Tracer(
+-                settings: null,
+-                agentWriter: null,
+-                sampler: null,
+-                scopeManager: new AspNetScopeManager(),
+-                statsd: null);
+-
+-            if (Tracer.Instance.Settings.IsIntegrationEnabled(AspNetHttpModule.IntegrationName))
+-            {
+-                // only register http module if integration is enabled
+-                HttpApplication.RegisterModule(typeof(AspNetHttpModule));
+-            }
++            HttpApplication.RegisterModule(typeof(AspNetHttpModule));
+         }
+     }
+ }","In my changes, I did not create a new `AspNetScopeManager`. I'm not familiar with it enough to know if this is a valid change or not",Can we pass `Instrumenter` to `RegisterModule` directly?
+7551,"@@ -0,0 +1,3 @@
++export default message => {
++  throw new Error(message);
++};","Not cool with this. I think we talked about it in past. This is a side effect. If we want to introduce the side effect in our functions like `inRange` (which I am for) the side effect (error) should originate in that function and not in some internal `throwError` function. Every stacktract will start at line `2` of `trowError.js`. Been there, done that and falled back to throwing the error from the place where it should be thrown.",This is a sort of thing that we would want to avoid right now. I
+7552,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+
+   @Override",We don't need this additional method.,`name` could be null I think
+7553,"@@ -44,11 +44,10 @@ public class DelegatingOAuth2UserServiceTests {
+ 	}
+
+ 	@Test(expected = IllegalArgumentException.class)
+-	@SuppressWarnings(""unchecked"")
+ 	public void loadUserWhenUserRequestIsNullThenThrowIllegalArgumentException() {
+ 		DelegatingOAuth2UserService<OAuth2UserRequest, OAuth2User> delegatingUserService =
+ 			new DelegatingOAuth2UserService<>(
+-				Arrays.asList(mock(OAuth2UserService.class), mock(OAuth2UserService.class)));
++				Arrays.asList(mock(DefaultOAuth2UserService.class), mock(DefaultOAuth2UserService.class)));
+ 		delegatingUserService.loadUser(null);
+ 	}
+ ",The purpose of this test is to ensure that the `OAuth2UserRequest` passed into `loadUser` is **not** null else throw `IllegalArgumentException`. Changing the `List` of `OAuth2UserService` mocks to `DefaultOAuth2UserService` doesn't really apply to what is being tested here. Please revert this. Thank you.,OAuth2UserService is mocked
+7554,"@@ -124,7 +124,7 @@ func NewProtocol(
+ 	getkickoutList GetKickoutList,
+ 	getUnproductiveDelegate GetUnproductiveDelegate,
+ 	electionCommittee committee.Committee,
+-	stakingV2 *staking.Protocol,
++	stakingProto *staking.Protocol,
+ 	getBlockTimeFunc GetBlockTime,
+ 	productivity Productivity,
+ 	getBlockHash evm.GetBlockHash,",nit: rename to nativeStk? proto might lead to think protobuf,why is the stakingV2 not nee
+7555,"@@ -28,6 +28,9 @@ import org.apache.solr.common.util.StrUtils;
+ public interface ShardParams {
+   /** the shards to use (distributed configuration) */
+   String SHARDS = ""shards"";
++
++  /** UUID of the query */
++  String QUERY_ID = ""queryID"";
+
+   /** per-shard start and rows */
+   String SHARDS_ROWS = ""shards.rows"";",Why not `queryUUID` (and reference the same constant as in other places)?,This should probably be name
+7556,"@@ -36,9 +36,9 @@ import (
+ )
+
+ const (
+-	invalidTrustDomainAttestedNode = ""An attested node with trust domain '%v' has been detected, "" +
++	invalidTrustDomainAttestedNode = ""an attested node with trust domain '%v' has been detected, "" +
+ 		""which does not match the configured trust domain of '%v'. Agents may need to be reconfigured to use new trust domain""
+-	invalidTrustDomainRegistrationEntry = ""A registration entry with trust domain '%v' has been detected, "" +
++	invalidTrustDomainRegistrationEntry = ""a registration entry with trust domain '%v' has been detected, "" +
+ 		""which does not match the configured trust domain of '%v'. If you want to change the trust domain, "" +
+ 		""please delete all existing registration entries""
+ 	invalidSpiffeIDRegistrationEntry = ""registration entry with id %v is malformed because invalid SPIFFE ID: %v""","This is also used to log, of which our convention is leading uppercase...","it might make sense to reword this as ""has been configured to use new trust domain"""
+7557,"@@ -131,7 +131,7 @@ class ReusedSQLTestCase(unittest.TestCase, SQLTestUtils):
+         # Please see databricks/koalas/conftest.py.
+         pass
+
+-    def assertPandasEqual(self, left, right):
++    def assertPandasEqual(self, left, right, less_precise=False):
+         if isinstance(left, pd.DataFrame) and isinstance(right, pd.DataFrame):
+             try:
+                 pd.util.testing.assert_frame_equal(",What about we just name it `check_exact`?,Please rename `more_precise` to `precise`.
+7558,"@@ -205,9 +205,10 @@ public abstract class SpanStoreTest {
+   }
+
+   @Test
+-  public void getAllServiceNames() {
++  public void getAllServiceNames_mergesAnnotation_andBinaryAnnotation() {
++    // creates a span with mutual exclusive endpoints in binary annotations and annotations
+     BinaryAnnotation yak = BinaryAnnotation.address(""sa"", Endpoint.create(""yak"", 127 << 24 | 1));
+-    accept(span1.toBuilder().addBinaryAnnotation(yak).build(), span4);
++    accept(span1.toBuilder().binaryAnnotations(asList(yak)).build());
+
+     // should be in order
+     assertThat(store().getServiceNames()).containsExactly(""service"", ""yak"");","before, a binary annotation had the same service name as a regular annotation, masking the bug where we weren't querying the latter",You could also make this a method that takes a `List<BinaryAnnotation>`.
+7559,"@@ -1,4 +1,6 @@
+ class Exercise < ActiveRecord::Base
++  AVERAGE_COMPLETION_TIME_IN_MINUTES = 7
++
+   has_many :statuses, as: :completeable, dependent: :destroy
+   has_one :trail, through: :step, as: :completeables
+   has_one :step, dependent: :destroy, as: :completeable",Where does the `7` come from?,Avoid the use of the case equality operator ===.
+7560,"@@ -48,7 +48,7 @@ export default function CountrySelect() {
+ 				timezone: countriesByCode[ newCountryCode ].defaultTimeZoneId,
+ 			} );
+ 		}
+-	}, [ setValues ] );
++	}, [ setValues, value ] );
+
+ 	return (
+ 		<Select",I don't know how we haven't got bugs from some of these! As here this would have had a stale `value`,Do we need to pass `value` to the `select` component here? Or can we just use `value` here?
+7561,"@@ -199,6 +199,9 @@ public class SparkCatalog extends BaseCatalog {
+           setSnapshotId = set;
+         } else if (""cherry-pick-snapshot-id"".equalsIgnoreCase(set.property())) {
+           pickSnapshotId = set;
++        } else if (""sort-order"".equalsIgnoreCase(set.property())) {
++          throw new UnsupportedOperationException(""'sort-order' is a reserved table property. Please use the command "" +
++                  ""'ALTER TABLE ... WRITE ORDERED BY' to specify it."");
+         } else {
+           propertyChanges.add(set);
+         }","One nit here I forgot about this before but we usually structure error messages as ""Cannot X because Y. Then the recommendation goes here"" I would also recommend not using ""it"" in the message since it the pronoun is a bit ambiguous. ""to specify write sort-order"" may be clearer",I don't think we need to mention the command in the exception message. It might just be tha
+7562,"@@ -26,7 +26,8 @@ import {
+ } from '../../../../../tests/js/utils';
+ import * as CacheModule from '../../../googlesitekit/api/cache';
+ import { STORE_NAME } from './constants';
+-import initialState, {
++import {
++	initialState,
+ 	FEATURE_TOUR_COOLDOWN_SECONDS,
+ 	FEATURE_TOUR_LAST_DISMISSED_AT,
+ } from './feature-tours';",I'm surprised this worked at all! It was importing the default export but `eslint-plugin-import` warned me `warning Using exported name 'initialState' as identifier for default export import/no-named-as-default`,Why did you change this?
+7563,"@@ -1,10 +1,9 @@
+ class VideoTutorial < Product
+-  has_many :teachers, dependent: :destroy
+-  has_many :users, through: :teachers
++  validates :description, :tagline, presence: true
+
+-  # Validations
+-  validates :description, presence: true
+-  validates :tagline, presence: true
++  def teachers
++    Teacher.joins(:video).merge(videos)
++  end
+
+   def collection?
+     published_videos.count > 1",This was used in `app/views/video_tutorials/_video_tutorial_details.html.erb` how are we handling that now?,"I'm not sure if this relation is the best option here, but if it works, I'm open to suggest"
+7564,"@@ -8,8 +8,9 @@ var (
+ 	newlineTabRE           = regexp.MustCompile(`\n\t`)
+ 	certificateTimeErrorRE = regexp.MustCompile(`: current time \S+ is after \S+`)
+ 	// aws
+-	awsRequestIDRE   = regexp.MustCompile(`(, )*(?i)(request id: )(?:[-[:xdigit:]]+)`)
+-	awsNotAuthorized = regexp.MustCompile(`(User: arn:aws:sts::)\S+(:assumed-role/[^/]+/)\S+( is not authorized to perform: \S+ on resource: arn:aws:iam::)[^:]+(:\S+)`)
++	awsRequestIDRE    = regexp.MustCompile(`(, )*(?i)(request id: )(?:[-[:xdigit:]]+)`)
++	awsNotAuthorized  = regexp.MustCompile(`(User: arn:aws:sts::)\S+(:assumed-role/[^/]+/)\S+( is not authorized to perform: \S+ on resource: arn:aws:iam::)[^:]+(:\S+)`)
++	awsEncodedMessage = regexp.MustCompile(`(Encoded authorization failure message: )\S+(,)`)
+ 	// azure
+ 	azureErrorDescriptionRE = regexp.MustCompile(`\""error_description\"":\""(.*?)\\r\\n`)
+ )","Is `\S+` really the right thing? Anybody know what kind of encoding this is? Perhaps if we know it doesn't have commas, we can just use `[^,]+`. Also, parens around the comma are unnecessary, since we're not using the capture group.",Please remove the `(` and `)`.
+7565,"@@ -1,10 +1,8 @@
+ tests = [
++  (""python"", ""UnitTestDocTests.py"", {}),
+   (""python"", ""UnitTestcBitVect.py"", {}),
+   (""python"", ""UnitTestBitEnsemble.py"", {}),
+   (""python"", ""UnitTestTopNContainer.py"", {}),
+-  (""python"", ""BitUtils.py"", {}),
+-  (""python"", ""VectCollection.py"", {}),
+-  (""python"", ""LazySignature.py"", {}),
+ ]
+ longTests = []
+ ",This block of changes looks like you removed tests without replacing them anywhere. Did I miss something?,These tests were only showing
+7566,"@@ -360,7 +360,10 @@ struct atom_wrapper {
+         .def(""GetPropNames"", &Atom::getPropList, (python::arg(""self"")),
+              ""Returns a list of the properties set on the Atom.\n\n"")
+
+-        .def(""GetPropsAsDict"", GetPropsAsDict<Atom>, (python::arg(""self"")),
++        .def(""GetPropsAsDict"", GetPropsAsDict<Atom>, (python::arg(""self""),
++                                                      python::arg(""includePrivate"") = true,
++                                                      python::arg(""includeComputed"") = true
++                                                      ),
+              ""Returns a dictionary of the properties set on the Atom.\n""
+              "" n.b. some properties cannot be converted to python types.\n"")
+         ",n.b. private and computed values are now exposed to the API. They were hidden/not exposed before.,"Maybe leave out `python::arg("""
+7567,"@@ -285,6 +285,13 @@ class WebElementWrapper(collections.abc.MutableMapping):
+         tag = self._elem.tagName().lower()
+         return self.get('role', None) in roles or tag in ('input', 'textarea')
+
++    def remove_target(self):
++        """"""Remove target from link""""""
++        if self._elem.tagName().lower() == 'a':
++            self._elem.removeAttribute('target')
++        elif self.parent().tagName().lower() == 'a':
++            self.parent().removeAttribute('target')
++
+     def debug_text(self):
+         """"""Get a text based on an element suitable for debug output.""""""
+         self._check_vanished()",Nitpick: Please add a period after `link` :wink:,tagName.lower() == 'a' should
+7568,"@@ -67,5 +67,8 @@ func (hs *HandlerStub) Start() {
+ 		klog.Errorf(""New upstream controller failed with error: %v"", err)
+ 		return
+ 	}
+-	upstream.Start()
++	if err := upstream.Start(); err != nil {
++		klog.Errorf(""Failed to start upstream with error: %v"", err)
++		return
++	}
+ }","we got no chance that `err` is not nil here, need to revisit how `NewUpstreamController` is defined.","If the upstream is stopped, what does this error surface to the end user?"
+7569,"@@ -247,7 +247,8 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+         .put(GET_LOG, post(""/session/:sessionId/log""))
+         .put(GET_AVAILABLE_LOG_TYPES, get(""/session/:sessionId/log/types""))
+
+-        .put(STATUS, get(""/status""));
++        .put(STATUS, get(""/status""))
++        .put(HEAP_SNAPSHOT, get(""/session/:sessionId/chromium/heap_snapshot""));
+
+         nameToUrl = builder.build();
+   }","Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?",I would suggest to rename `heap_snapshot` to `heap_snapshot_url` to make
+7570,"@@ -348,6 +348,12 @@ module RSpec::Core
+     end
+
+     describe ""#its"" do
++
++      it ""should issue deprecation warning"" do
++        expect_deprecation_with_call_site(__FILE__, __LINE__+1, '""its"" method')
++        RSpec::Core::ExampleGroup.its(nil) {}
++      end
++
+       subject do
+         Class.new do
+           def initialize","It'd be nice to assert the right deprecation is being raised, just add a third argument of `/""its"" method/`",Prefer single-quoted strings when you don't need string interpolation or
+7571,"@@ -87,6 +87,8 @@ public class TableProperties {
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+
++  public static final String LOCATION_PROVIDER_IMPL = ""write.location-provider.impl"";
++
+   public static final String OBJECT_STORE_PATH = ""write.object-storage.path"";
+
+   // This only applies to files written after this property is set. Files previously written aren't",Do we want to add this to the docs?,Should this have a `.impl` suffix?
+7572,"@@ -46,7 +46,7 @@ func AssertGRPCStatus(tb testing.TB, err error, code codes.Code, message string)
+ 	st := status.Convert(err)
+
+ 	ok := true
+-	if !assert.Equal(tb, code, st.Code(), ""GRPC status code does not match"") {
++	if !assert.Equal(tb, code.String(), st.Code().String(), ""GRPC status code does not match"") {
+ 		ok = false
+ 	}
+ 	if !assert.Equal(tb, message, st.Message(), ""GRPC status message does not match"") {",This isn't really related but makes debugging test failures much easier since you see the string representation of the code instead of the integer value.,why we need `.String()` here?
+7573,"@@ -130,6 +130,18 @@ bool ValueObjectVariable::UpdateValue() {
+   m_error.Clear();
+
+   Variable *variable = m_variable_sp.get();
++  // Check if the type has size 0. If so, there is nothing to update.
++  CompilerType var_type(GetCompilerTypeImpl());
++  if (var_type.IsValid()) {
++    ExecutionContext exe_ctx(GetExecutionContextRef());
++    llvm::Optional<uint64_t> size =
++      var_type.GetByteSize(exe_ctx.GetBestExecutionContextScope());
++    if (size && *size == 0) {
++      m_value.SetCompilerType(var_type);
++      return m_error.Success();
++    }
++  }
++
+   DWARFExpression &expr = variable->LocationExpression();
+
+   if (variable->GetLocationIsConstantValueData()) {",Because of this new early exit.,"This check is not needed, bec"
+7574,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?,Is there a reason why you cha
+7575,"@@ -150,12 +150,16 @@ public abstract class PrivacyApiGroupJsonRpcMethods extends ApiGroupJsonRpcMetho
+
+   private JsonRpcMethod createPrivacyMethod(
+       final PrivacyParameters privacyParameters, final JsonRpcMethod rpcMethod) {
+-    if (rpcMethod.getName().equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
++    final String methodName = rpcMethod.getName();
++    if (methodName.equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
++      return rpcMethod;
++    } else if (methodName.equals(RpcMethod.PRIV_DISTRIBUTE_RAW_TRANSACTION.getMethodName())
++        && privacyParameters.getGoQuorumPrivacyParameters().isPresent()) {
+       return rpcMethod;
+     } else if (privacyParameters.isEnabled() && privacyParameters.isMultiTenancyEnabled()) {
+       return new MultiTenancyRpcMethodDecorator(rpcMethod);
+     } else if (!privacyParameters.isEnabled()) {
+-      return new DisabledPrivacyRpcMethod(rpcMethod.getName());
++      return new DisabledPrivacyRpcMethod(methodName);
+     } else {
+       return rpcMethod;
+     }",can this be removed now?,How about extracting this log
+7576,"@@ -213,8 +213,11 @@ static pmix_status_t initialize_server_base(pmix_server_module_t *module)
+     }
+
+     /* for now, just setup the v1.1 series rendezvous point
+-     * we use the pid to reduce collisions */
+-    if (0 > asprintf(&pmix_pid, ""%s/pmix-%d"", tdir, mypid)) {
++     * - use userid to avoid situation where user with other UID but same PID
++     *   has created the usock and terminate abnormally and we have no way to
++     *   remove the file
++     * - use the pid to reduce collisions */
++    if (0 > asprintf(&pmix_pid, ""%s/pmix-%d.%d"", tdir, getuid(), mypid)) {
+         return PMIX_ERR_NOMEM;
+     }
+ ",This is going to create a problem - we are already encountering issues with the length of the usock pathname on recent Linux kernels as the temp directory base has moved down to the var directory under a name created by a hash. So adding another field to it is going to add to the problem.,It's not obvious to me why `asprintf()` is needed here. `asprintf()` can be used to replace arguments.
+7577,"@@ -31,3 +31,13 @@ type ApplicationGetter interface {
+ type ApplicationCreator interface {
+ 	CreateApplication(app *Application) error
+ }
++
++const (
++	// AppCfnTemplateNameFormat is the base output file name when `app package`
++	// is called. This is also used to render the pipeline CFN template.
++	AppCfnTemplateNameFormat = ""%s.stack.yml""
++	// AppCfnTemplateConfigurationNameFormat is the base output configuration
++	// file name when `app package` is called. It's also used to render the
++	// pipeline CFN template.
++	AppCfnTemplateConfigurationNameFormat = ""%s-%s.params.json""
++)",What do you think about moving this to the `cloudformation` pkg?,There's no need to change this since it's not used by the creator anymore.
+7578,"@@ -63,6 +63,11 @@ abstract class BaseProvider implements MediaProviderInterface
+      */
+     protected $name;
+
++    /**
++     * @var array
++     */
++    protected $clones = [];
++
+     /**
+      * @param string             $name
+      * @param Filesystem         $filesystem",Please make this private by default,"`$clones` seems to be an array, why not just use an empty array?"
+7579,"@@ -16,6 +16,12 @@
+  */
+ package org.camunda.bpm.engine.impl.util.xml;
+
++import org.camunda.bpm.engine.impl.ProcessEngineLogger;
++import org.camunda.bpm.engine.impl.cfg.ProcessEngineConfigurationImpl;
++import org.camunda.bpm.engine.impl.context.Context;
++import org.camunda.bpm.engine.impl.util.EngineUtilLogger;
++
++import javax.xml.XMLConstants;
+ import javax.xml.parsers.SAXParser;
+ import javax.xml.parsers.SAXParserFactory;
+ ","We can add `@Override` annotations to all of the implementations of this method. I think this is a best practice for us, but it would be nicer in any case.",remove unused imports
+7580,"@@ -7,5 +7,11 @@ type Resolver interface {
+
+ // Detector allows detecting location by current ip
+ type Detector interface {
+-	DetectCountry() (string, error)
++	DetectLocation() (Location, error)
++}
++
++// Cache allows caching location
++type Cache interface {
++	Get() (Location, error)
++	RefreshAndGet() (Location, error)
+ }","Most of uses of `RefreshAndGet` seems to be made only for `Refresh` part, result is ignored. We can simplify this method to assigning single responsibility to it - just `Refresh()`.",why is this in the public interface?
+7581,"@@ -137,7 +137,10 @@ class OptionsManagerMixIn:
+
+     def add_optik_option(self, provider, optikcontainer, opt, optdict):
+         args, optdict = self.optik_option(provider, opt, optdict)
+-        option = optikcontainer.add_option(*args, **optdict)
++        try:
++            option = optikcontainer.add_option(*args, **optdict)
++        except optparse.OptionConflictError:
++            return
+         self._all_options[opt] = provider
+         self._maxlevel = max(self._maxlevel, option.level or 0)
+ ","@Pierre-Sassoulas Are we sure this doesn't create problems? Without it for some reason we get an error on `accept-no-param-docs` being a duplicate error. I couldn't figure out why it did this. This solves the issue and passes the tests, but I wonder if this creates other issues..",should we log something here?
+7582,"@@ -169,7 +169,17 @@ func (c *linuxContainer) OCIState() (*specs.State, error) {
+ }
+
+ func (c *linuxContainer) Processes() ([]int, error) {
+-	pids, err := c.cgroupManager.GetAllPids()
++	var pids []int
++	status, err := c.currentStatus()
++	if err != nil {
++		return pids, err
++	}
++	// for systemd cgroup, the unit's cgroup path will be auto removed if container's all processes exited
++	if status == Stopped && !c.cgroupManager.Exists() {
++		return pids, nil
++	}
++
++	pids, err = c.cgroupManager.GetAllPids()
+ 	if err != nil {
+ 		return nil, newSystemErrorWithCause(err, ""getting all container pids from cgroups"")
+ 	}","Does it make sense to check for ""Created"" here as well? Or should it return an error in such case?",Why is this check needed? If the con
+7583,"@@ -93,7 +93,7 @@ public abstract class BaseMetastoreCatalog implements Catalog {
+     String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
+     Map<String, String> tableProperties = properties != null ? properties : Maps.newHashMap();
+     TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
+-    return Transactions.createTableTransaction(ops, metadata);
++    return Transactions.createTableTransaction(identifier.name(), ops, metadata);
+   }
+
+   @Override",Did you mean to use `identifier.toString` here as well?,This is a bug fix. Please open a sep
+7584,"@@ -1,6 +1,6 @@
+-require 'spec_helper'
++require ""rails_helper""
+
+-describe Api::V1::UsersController, '#show' do
++describe Api::V1::UsersController, ""#show"", type: :controller do
+   it 'returns a 401 when users are not authenticated' do
+     get :show
+     expect(response.code).to eq ""401""",interesting! didn't realize this was needed in RSpec 3,Block has too many lines. [33/25]
+7585,"@@ -27,7 +27,7 @@ from databricks.koalas.base import _wrap_accessor_pandas, _wrap_accessor_spark
+
+ class DatetimeMethods(object):
+     """"""Date/Time methods for Koalas Series""""""
+-    def __init__(self, series: ks.Series):
++    def __init__(self, series: 'ks.Series'):
+         if not isinstance(series.spark_type, (DateType, TimestampType)):
+             raise ValueError(
+                 ""Cannot call DatetimeMethods on type {}""",This is to avoid circular reference,Why do we need to change the type
+7586,"@@ -93,6 +93,9 @@ class MPLRenderer(Renderer):
+              'nbagg':   (NbAggJupyterComm, None),
+              'mpld3':   (JupyterComm, mpld3_msg_handler)}
+
++    # Whether in a notebook context
++    _notebook = False
++
+     def __call__(self, obj, fmt='auto'):
+         """"""
+         Render the supplied HoloViews component or MPLPlot instance","As the bokeh renderer also has a ``load_nb`` classmethod (and notebooks are explicitly mentioned in that method name), I would consider making ``_notebook`` into a constant ``notebook_context`` class parameter. The docstring can say it is set to True if the ``load_nb`` classmethod has been called.",Maybe this should be called `no_n
+7587,"@@ -2,7 +2,6 @@
+
+ const CommandOperation = require('./command');
+ const handleCallback = require('../utils').handleCallback;
+-const MongoError = require('../core').MongoError;
+
+ class DropCollectionOperation extends CommandOperation {
+   constructor(db, command, options) {","Where is the actual command generated here? Shouldn't this be taking in `constructor(db, collectionName, options)` and then constructing the command off of that?",MongoError is no longer used in t
+7588,"@@ -55,7 +55,8 @@
+ int
+ memquery_library_bounds_by_iterator(const char *name, app_pc *start /*IN/OUT*/,
+                                     app_pc *end /*OUT*/, char *fullpath /*OPTIONAL OUT*/,
+-                                    size_t path_size)
++                                    size_t path_size, char *filename,
++                                    size_t filename_size)
+ {
+     int count = 0;
+     bool found_library = false;",Mirror the `OPTIONAL OUT` of fullpath,"I don't think filename_size is needed here. If filename is NULL, just use sizeof(filename) instead of sizeof(filename_size)"
+7589,"@@ -94,13 +94,16 @@ const ConsensusV17 = ConsensusVersion(
+ 	""https://github.com/algorandfoundation/specs/tree/5615adc36bad610c7f165fa2967f4ecfa75125f0"",
+ )
+
++// ConsensusVNext stand-in for protocol with LogicSig and TEAL v1
++const ConsensusVNext = ConsensusVersion(""NEXT!"")
++
+ // !!! ********************* !!!
+ // !!! *** Please update ConsensusCurrentVersion when adding new protocol versions *** !!!
+ // !!! ********************* !!!
+
+ // ConsensusCurrentVersion is the latest version and should be used
+ // when a specific version is not provided.
+-const ConsensusCurrentVersion = ConsensusV17
++const ConsensusCurrentVersion = ConsensusVNext
+
+ // ConsensusTest0 is a version of ConsensusV0 used for testing
+ // (it has different approved upgrade paths).","Please merge with master and replace with with ""future"" version.",Do we really need this? Can we just use ConsensusCurrentVersion directly?
+7590,"@@ -55,7 +55,6 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			let cxType = newType.contextType;
+ 			let provider = cxType && context[cxType._id];
+ 			let cctx = cxType != null ? (provider ? provider.props.value : cxType._defaultValue) : context;
+-
+ 			// Get component and set it to `c`
+ 			if (oldVNode._component) {
+ 				c = newVNode._component = oldVNode._component;",Nit: Change is not needed for this PR :slightly_smiling_face:,Please don't remove trailing whitespace
+7591,"@@ -11,6 +11,15 @@ module CloudFoundry
+     end
+   end
+
++  def self.app_url
++    if self.is_environment?
++      # (arbitrarily) use the shortest assigned route, if there are multiple
++      self.vcap_data['application_uris'].min_by(&:length)
++    else
++      nil
++    end
++  end
++
+   # returns `true` if this app is running in Cloud Foundry
+   def self.is_environment?
+     !!self.raw_vcap_data",if we are returning `nil` from an `else` I think we can just remove the `else` (and this method will still return `nil`),I'm not sure if this is the correct way to check if this is an environment. `self.vcap_data['application_uris'].min_by(&:le
+7592,"@@ -9,7 +9,7 @@ using System.Threading.Tasks;
+ namespace System.Threading.Tests
+ {
+     [BenchmarkCategory(Categories.CoreFX)]
+-    public class TimerPerfTest
++    public class Perf_Timer
+     {
+         private readonly Timer[] _timers = new Timer[1_000_000];
+         private readonly Task[] _tasks = new Task[Environment.ProcessorCount];","side note: this change is ok as of today because we have not exported the results for this new type to BenchView yet. After we to that the namespace, type name and method name should not be changed (they create a benchmark ID which is used in BenchView).",Would you mind adding a summary to this and the other Perf_Timer classes?
+7593,"@@ -294,7 +294,15 @@ namespace pwiz.Skyline.Model.Lib.Midas
+             _spectra = null;
+             if (FilePath == null)
+                 return false;
+-            var info = new FileInfo(FilePath);
++            FileInfo info;
++            try
++            {
++                info = new FileInfo(FilePath);
++            }
++            catch
++            {
++                return false;
++            }
+             if (!info.Exists || info.Length == 0)
+                 return false;
+ ","How exactly are you expecting the user to see issues with their Midas library? It seems like all error information is being swallowed and not clearly reported to the user. Even if the eventual result is to report that loading the file failed, it seems like the exception, in this case, might have more information about why.",@mjkkirschner @QilongTang @stephentoub do you know if there is a better w
+7594,"@@ -105,6 +105,10 @@ func (wsc *WebSocketClient) UnInit() {
+
+ //Send sends the message as JSON object through the connection
+ func (wsc *WebSocketClient) Send(message model.Message) error {
++	err := wsc.connection.SetWriteDeadline(time.Now().Add(wsc.config.WriteDeadline))
++	if err != nil {
++		return err
++	}
+ 	return wsc.connection.WriteMessageAsync(&message)
+ }
+ ","Looks good, but seems `ReadMessage` hadn't used this Deadline in Underlying `WSConnection`?","We should set the write deadline when we call Send. As an alternative, we"
+7595,"@@ -89,6 +89,8 @@ public class Constants {
+   // The flow exec id for a flow trigger instance unable to trigger a flow yet
+   public static final int FAILED_EXEC_ID = -2;
+
++  // Name of the file which keeps project directory size
++  public static final String PROJECT_DIR_SIZE_FILE_NAME = ""_azkaban_project_dir_size_in_bytes_"";
+
+   public static class ConfigurationKeys {
+ ","Make it ""___*"" three underscores to make it even less likely to have a collision? I assume it will be hard to change the file name once this change is deployed...",I think the name `_azkaban_project_dir_size_in_bytes` should be `_azkaban
+7596,"@@ -432,7 +432,7 @@ public class RecoveryStrategy implements Runnable, Closeable {
+   /**
+    * @return true if we have reached max attempts or should stop recovering for some other reason
+    */
+-  private boolean waitBetweenRecoveries(String coreName) {
++  final private boolean waitBetweenRecoveries(String coreName) {
+     // lets pause for a moment and we need to try again...
+     // TODO: we don't want to retry for some problems?
+     // Or do a fall off retry...",We don't need this anymore after #2151,this method does not look like it is being used anywhere
+7597,"@@ -48,7 +48,7 @@ namespace NLog.LayoutRenderers
+     [AppDomainFixedOutput]
+     [ThreadAgnostic]
+     [ThreadSafe]
+-    public class MachineNameLayoutRenderer : LayoutRenderer, IStringValueRenderer
++    public class MachineNameLayoutRenderer : LayoutRenderer
+     {
+         internal string MachineName { get; private set; }
+ ",this is this removed? I don't understand in the context of this PR,Can you remove `IStringValueRenderer` as well? It's not
+7598,"@@ -107,6 +107,9 @@ def getmacbyip6(ip6, chainCC=0):
+     (chainCC parameter value ends up being passed to sending function
+      used to perform the resolution, if needed)
+     """"""
++
++    if isinstance(ip6,Net6):
++        ip6 = iter(ip6).next()
+
+     if in6_ismaddr(ip6): # Multicast
+         mac = in6_getnsmac(inet_pton(socket.AF_INET6, ip6))","`isinstance(ip6, Net6)` instead","why not just `if not isinstance(ip6, net6):` ?"
+7599,"@@ -359,10 +359,12 @@ ResultCode NebulaStore::get(GraphSpaceID spaceId,
+ }
+
+
+-ResultCode NebulaStore::multiGet(GraphSpaceID spaceId,
+-                                 PartitionID partId,
+-                                 const std::vector<std::string>& keys,
+-                                 std::vector<std::string>* values) {
++ErrorOr<ResultCode, std::vector<Status>> NebulaStore::multiGet(
++        GraphSpaceID spaceId,
++        PartitionID partId,
++        const std::vector<std::string>& keys,
++        std::vector<std::string>* values,
++        bool returnPartly) {
+     auto ret = part(spaceId, partId);
+     if (!ok(ret)) {
+         return error(ret);","Do we really need the param here? If only partial results returned, we could return ResultCode::PARTIAL_RESULTS;",You don't need the `returnPartly` parameter here. It's t
+7600,"@@ -330,7 +330,12 @@ func moveOutputs(state *core.BuildState, target *core.BuildTarget) ([]string, bo
+ 	tmpDir := target.TmpDir()
+ 	outDir := target.OutDir()
+ 	for _, output := range target.Outputs() {
+-		tmpOutput := path.Join(tmpDir, output)
++		var tmpOutput string
++		if output == target.Label.PackageName {
++			tmpOutput = path.Join(tmpDir, fmt.Sprintf(core.TmpOutputFormat, output))
++		} else {
++			tmpOutput = path.Join(tmpDir, output)
++		}
+ 		realOutput := path.Join(outDir, output)
+ 		if !core.PathExists(tmpOutput) {
+ 			return nil, true, fmt.Errorf(""Rule %s failed to create output %s"", target.Label, tmpOutput)",this logic seems duplicated from the other new function. I think it should probably be a member function on `BuildTarget`,"I think you want to use `path.Join(tmpDir, output)` here."
+7601,"@@ -51,14 +51,13 @@ func TestPatricia(t *testing.T) {
+ 	stream, err := b.serialize()
+ 	assert.Nil(err)
+ 	assert.NotNil(stream)
+-	assert.Equal(byte(1), stream[0])
+ 	b1 := branch{}
+ 	err = b1.deserialize(stream)
+ 	assert.Nil(err)
+ 	assert.Equal(0, bytes.Compare(root, b1.Path[0]))
+ 	assert.Equal(0, bytes.Compare(hash1, b1.Path[2]))
+ 	assert.Equal(0, bytes.Compare(hash2, b1.Path[11]))
+-	assert.Equal(430, len(stream))
++	assert.Equal(114, len(stream))
+
+ 	e := leaf{0, nil, nil}
+ 	e.Path = []byte{2, 3, 5, 7}",size reduce to 1/4 of using Gob,"Note that this is a change in behavior here. Previously, "
+7602,"@@ -15,13 +15,14 @@ type Writer struct {
+ func NewWriter(w io.Writer, h hash.Hash) *Writer {
+ 	return &Writer{
+ 		h: h,
+-		w: io.MultiWriter(w, h),
++		w: w,
+ 	}
+ }
+
+ // Write wraps the write method of the underlying writer and also hashes all data.
+ func (h *Writer) Write(p []byte) (int, error) {
+ 	n, err := h.w.Write(p)
++	h.h.Write(p[:n])
+ 	return n, err
+ }
+ ",The Hash interface states that a call to `Write()` never returns an error. Does this also apply to the number of written bytes?,why is this change necessary?
+7603,"@@ -5,7 +5,7 @@ module Travis
+     module Appliances
+       class DisableSshRoaming < Base
+         def apply
+-          sh.if ""$(sw_vers -productVersion | cut -d . -f 2) -lt 12"" do
++          sh.if %(""$(sw_vers -productVersion 2>/dev/null | cut -d . -f 2)"" -lt 12) do
+             sh.cmd %(mkdir -p $HOME/.ssh)
+             sh.cmd %(chmod 0700 $HOME/.ssh)
+             sh.cmd %(touch $HOME/.ssh/config)","In my tests, I found that `[[ """" -lt 12 ]]` evaluates to true, but `[[ -lt 12 ]]` is an error, which is why the subshell is wrapped in `""`.",@Spaceman1984 why did you change this to `dev/null`?
+7604,"@@ -369,6 +369,11 @@ FactoryGirl.define do
+     association :watchable, factory: :product
+     title
+     wistia_id '1194803'
++    published_on Time.zone.today
++
++    trait :unpublished do
++      published_on nil
++    end
+   end
+
+   factory :oauth_access_token do","I don't see a validation on `published_on`, we generally shouldn't specify it in the base factory unless the model would be invalid without the model. Is there a different way we can handle this?",We can remove this trait and use `Time.zone.today` everywhere.
+7605,"@@ -115,7 +115,7 @@ public final class ConstantScoreQuery extends Query {
+       return new ConstantScoreWeight(this, boost) {
+         @Override
+         public BulkScorer bulkScorer(LeafReaderContext context) throws IOException {
+-          if (scoreMode == ScoreMode.TOP_SCORES) {
++          if (scoreMode == ScoreMode.TOP_SCORES || scoreMode == ScoreMode.TOP_DOCS || scoreMode == ScoreMode.TOP_DOCS_WITH_SCORES) {
+             return super.bulkScorer(context);
+           }
+           final BulkScorer innerScorer = innerWeight.bulkScorer(context);",maybe add a `isExhaustive()` method on the enum to avoid these large conditions?,Why do we need to check for `ScoreMode.TOP_DOCS` here?
+7606,"@@ -15,11 +15,13 @@ import (
+ )
+
+ const (
+-	defaultCaFile   = ""ca.pem""
+-	defaultKeyFile  = ""key.pem""
+-	defaultCertFile = ""cert.pem""
+-	dockerSock      = ""/var/run/docker.sock""
+-	dockerSockUnix  = ""unix://"" + dockerSock
++	defaultCaFile               = ""ca.pem""
++	defaultKeyFile              = ""key.pem""
++	defaultCertFile             = ""cert.pem""
++	dockerSock                  = ""/var/run/docker.sock""
++	dockerSockUnix              = ""unix://"" + dockerSock
++	substitutionPatternName     = ""pattern""
++	substitutionReplacementName = ""replacement""
+ )
+
+ var (","so those regexps were wrong previously? e.g. they would match `/v\/foo`? If so, raise a bug and fix on the 1.0 branch.",Why are these constants defined here? They look unrelated.
+7607,"@@ -1417,6 +1417,9 @@ class MultiBackend extends AbstractBase implements \Laminas\Log\LoggerAwareInter
+         bool $stripPrefixes = true,
+         bool $addPrefixes = true
+     ) {
++        if (empty($params) && null === $source) {
++            return null;
++        }
+         if (null === $source) {
+             $source = $this->getSourceForMethod($method, $params);
+         }","I think with MultiBackend we could have a slightly different logic: return true if there are no configured login targets ( = getLoginDrivers returns an empty array). MultiBackend could also check all configured login targets for loginIsHidden support and verify that at least one of the configured login targets allows login, but I wouldn't go that far without a use case. In a related note, I'm not quite sure if loginIsHidden works with ChoiceAuth at all, but that's a different issue.",Can you change this to `if ($params === null) {`?
+7608,"@@ -25,11 +25,13 @@ using namespace LAMMPS_NS;
+ Reader::Reader(LAMMPS *lmp) : Pointers(lmp)
+ {
+   fp = nullptr;
++  binary = false;
++  compressed = false;
+ }
+
+ /* ----------------------------------------------------------------------
+    try to open given file
+-   generic version for ASCII files that may be compressed
++   generic version for ASCII files that may be compressed or native binary dumps
+ ------------------------------------------------------------------------- */
+
+ void Reader::open_file(const std::string &file)",Should we add error info for not supporting the compressed binary?,I'm confused. Why do we have to set `binary` and `compressed` here?
+7609,"@@ -62,6 +62,8 @@ var (
+ 	// defaulting fails.
+ 	defaultBackoffDelay  = ""PT1S""
+ 	defaultBackoffPolicy = eventingduckv1beta1.BackoffPolicyExponential
++	// clusterRegionGetter is a function that can get the cluster region
++	clusterRegionGetter = utils.NewClusterRegionGetter()
+ )
+
+ // Reconciler implements controller.Reconciler for Trigger resources.",I suggest injecting this into the reconciler. For this and the others. Have Wire generate it and push it into the controller creation.,How about using a pointer instead?
+7610,"@@ -25,6 +25,11 @@ namespace Nethermind.Core.Json
+ {
+     public class EthereumJsonSerializer : IJsonSerializer
+     {
++        public EthereumJsonSerializer()
++        {
++            _serializer = JsonSerializer.Create(_settings);
++        }
++
+         public static IList<JsonConverter> BasicConverters { get; } = new List<JsonConverter>
+         {
+             new AddressConverter(),",Can't we just make _serializer static? We use same settings every time. I would also put those fields on top of the class for readability.,"This ctor is unnecessary, already created by `JsonSettings` propert"
+7611,"@@ -321,6 +321,7 @@ class HttpLayer(base.Layer):
+
+         try:
+             if websockets.check_handshake(request.headers) and websockets.check_client_version(request.headers):
++                f.metadata['websocket'] = True
+                 # We only support RFC6455 with WebSocket version 13
+                 # allow inline scripts to manipulate the client handshake
+                 self.channel.ask(""websocket_handshake"", f)",Can't we just use `metadata['websocket_flow']` to identify handshake flows and not add another attribute?,I wonder if this should be configurable by the plugin?
+7612,"@@ -81,7 +81,7 @@ module RSpec
+
+           def output_formatted(str)
+             return str unless str.lines.count > 1
+-            separator = ""#{'-' * 80}""
++            separator = '-' * 80
+             ""#{separator}\n#{str.chomp}\n#{separator}""
+           end
+ ",Funny that we were wrapping this with string interpolation before...,"I think we should just delete `separator` instead of replacing it with `""""`."
+7613,"@@ -0,0 +1,6 @@
++import Controller from '@ember/controller';
++import {alias} from '@ember/object/computed';
++
++export default Controller.extend({
++    guid: alias('model')
++});","I had an eslint error saying I must ""alias"" my model - so I copied this from controllers/site.js",Is this used anywhere?
+7614,"@@ -124,9 +124,9 @@ namespace OpenTelemetry.Metrics
+
+         internal bool InstrumentDisposed { get; set; }
+
+-        public BatchMetricPoint GetMetricPoints()
++        public MetricPointsAccessor GetMetricPointsAccessor()
+         {
+-            return this.aggStore.GetMetricPoints();
++            return this.aggStore.GetMetricPointsAccessor();
+         }
+
+         internal void UpdateLong(long value, ReadOnlySpan<KeyValuePair<string, object>> tags)",unsure if the methodname can still be `GetMetricPoints()` as before...,This is a breaking change. Can we keep the old method and add a new one with
+7615,"@@ -233,6 +233,7 @@ class ViolationAccess(object):
+                 violation.get('full_name', ''),
+                 violation.get('resource_data', ''),
+                 violation.get('violation_data', ''),
++                violation.get('rule_name', '')
+             )
+
+             violation = Violation(","This file contains the functional changes, the rest is for testing.","shouldn't `violation.get('rule_name', '')` be `violation.get('full_name', ''"
+7616,"@@ -22,6 +22,7 @@ package http_test
+
+ import (
+ 	""fmt""
++	""io""
+ 	""log""
+ 	nethttp ""net/http""
+ 	""os""","I know you didn't do this, but there's no need for the `nethttp` alias and it was confusing to me - just remove it and s/nethttp/http/ everywhere (it's fine that the package here is http itself, I do the same thing in transport/grpc)",You forgot to import `io`
+7617,"@@ -1335,6 +1335,12 @@ public class SmartStoreTest extends SmartStoreTestCase {
+ 			JSONObject soupElt = new JSONObject(""{'key':'abcd"" + i + ""', 'value':'va"" + i + ""', 'otherValue':'ova"" + i + ""'}"");
+ 			store.create(TEST_SOUP, soupElt);
+ 		}
++
++		// With WAL enabled we must force a WAL checkpoint if we want the actual DB file to reflect the new content:
++		store.getDatabase()
++				.query(""PRAGMA wal_checkpoint(FULL);"")
++				.moveToNext();
++
+         Assert.assertTrue(""Database should be larger now"", store.getDatabaseSize() > initialSize);
+ 	}
+ ","I felt that this was the most non-invasive way to fix the test, but this does expose some raw DB queries and knowledge about how SQLite works which may be a code smell. The alternative to getting this to pass is to perform enough writes to trigger a checkpoint, but that threshold is determined in the config stage and this test may not be able to know what that page threshold is set to. This could lead to inconsistent test runs which is why I elected to force the checkpoint regardless of the page threshold.",Is it possible to have a
+7618,"@@ -14,7 +14,7 @@
+
+ namespace LightGBM {
+
+-const std::string kModelVersion = ""v2"";
++const std::string kModelVersion = ""v3"";
+
+ std::string GBDT::DumpModel(int start_iteration, int num_iteration) const {
+   std::stringstream str_buf;",Is new model format backward compatible with current v2?,what is the `3` in this m
+7619,"@@ -17,6 +17,14 @@ describe 'User creation when logging in with Oauth to view a protected page' do
+     expect(new_user.last_name).to eq(""Jetsonian"")
+   end
+
++  it ""sends welcome email to a new user"" do
++    deliveries.clear
++    expect { get '/auth/myusa/callback' }.to change { deliveries.length }.from(0).to(1)
++    welcome_mail = deliveries.first
++    expect(welcome_mail.subject).to eq(""[TEST] Welcome to C2!"")
++    deliveries.clear
++  end
++
+   it ""absence of first/last name does not throw error"" do
+     user = StructUser.new('somebody@example.com', nil, nil)
+     setup_mock_auth(:myusa, user)",should we perhaps write a spec that ensures we don't send a welcome email to a user on login when the user is not new?,Prefer single-quoted stri
+7620,"@@ -83,6 +83,10 @@ type Config struct {
+ 	// other than containers managed by ECS
+ 	ReservedMemory uint16
+
++	// ContainerTimeout specifies the amount time before a SIGKILL is issued to
++	// containers managed by ECS
++	DockerStopTimeoutSeconds uint64
++
+ 	// AvailableLoggingDrivers specifies the logging drivers available for use
+ 	// with Docker.  If not set, it defaults to [""json-file""].
+ 	AvailableLoggingDrivers []dockerclient.LoggingDriver",I think my preference would be to have the type be a `time.Duration` and use `time.ParseDuration` for parsing.,Should this be a `time.Duration` and not a `uint64`?
+7621,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+
+ import com.google.common.base.Predicate;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.,Is this import necessary?
+7622,"@@ -41,7 +41,7 @@ class Yamllint(base.Base):
+     .. code-block:: yaml
+
+         verifier:
+-          name: goss
++          name: ...
+           lint:
+             name: yamllint
+             options:",We should really leave a TODO or something or else we will forget them ...,did you mean to delete this?
+7623,"@@ -61,7 +61,7 @@ def define_pandas_source_test_solid():
+     return dm.define_dagstermill_solid(
+         name='pandas_source_test',
+         notebook_path=nb_test_path('pandas_source_test'),
+-        inputs=[InputDefinition(name='df', dagster_type=DataFrame)],
++        inputs=[InputDefinition(name='df', runtime_type=DataFrame)],
+         outputs=[OutputDefinition(DataFrame)],
+     )
+ ","This exposes what a bad name `dagster_type` was, but is it crazy to want this to just be `type` -- do we gain usability by being super-explicit that this is a `runtime_type`? If so, would it make sense to rename the `config_field` to be `config_type`?",Is there a reason to remove the dagster_type here?
+7624,"@@ -803,6 +803,16 @@ Tries to force this object to take the focus.
+ 		""""""
+ 		speech.speakObject(self,reason=controlTypes.REASON_FOCUS)
+
++	def _get_isSelectionAnchoredAtStart(self):
++		""""""Determine if the selection is anchored at the start.
++		If the selection is anchored at the end or there is no information this is C{False}.
++		@return: C{True} if the selection is anchored at the start else C{False}
++		@rtype: bool
++		""""""
++		if hasattr(self, '_isSelectionAnchoredAtStart'):
++			return self._isSelectionAnchoredAtStart
++		return False
++
+ 	def _reportErrorInPreviousWord(self):
+ 		try:
+ 			# self might be a descendant of the text control; e.g. Symphony.",It might help here if you give a brief explanation of what you mean with a selection being anchored at the start.,Shouldn't we check for `self._isSelectionAnchoredAtStart` here as well?
+7625,"@@ -7,12 +7,14 @@
+ package transfer
+
+ import (
++	""fmt""
+ 	""math/big""
+
+ 	""github.com/pkg/errors""
+
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/iotxaddress""
++	""github.com/iotexproject/iotex-core/pkg/hash""
+ 	""github.com/iotexproject/iotex-core/state""
+ )
+ ",move cachedStates to handle function,Please remove this empty line.
+7626,"@@ -130,7 +130,7 @@ public class GlobalSettings {
+         s.put(""hideSpecialAccounts"", Settings.versions(
+                 new V(1, new BooleanSetting(false))
+             ));
+-        s.put(""keyguardPrivacy"", Settings.versions(
++        s.put(""privacyMode"", Settings.versions(
+                 new V(1, new BooleanSetting(false))
+             ));
+         s.put(""language"", Settings.versions(","I don't think this can just be renamed; it's saying that privacyMode is a BooleanSetting, which it's not.",privacyMode -> keyguardPrivacy
+7627,"@@ -595,7 +595,7 @@ public class SharedCoreConcurrencyTest extends SolrCloudSharedStoreTestCase {
+       public void recordState(String collectionName, String shardName, String coreName, SharedCoreStage stage) {
+         super.recordState(collectionName, shardName, coreName, stage);
+         ConcurrentLinkedQueue<String> coreConcurrencyStages = coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());
+-        coreConcurrencyStages.add(Thread.currentThread().getId() + ""."" + stage.name());
++        coreConcurrencyStages.add(Thread.currentThread().getName() + ""."" + stage.name());
+       }
+     };
+     setupTestSharedConcurrencyControllerForNode(concurrencyController, solrProcess);",what was the reason for this change?,Wouldn't it be better to use `Stage.name().equals(Thread.currentThread(
+7628,"@@ -1,14 +1,8 @@
+ using System;
+-using System.Collections.Concurrent;
+-using System.Collections.Generic;
+ using System.Configuration;
+-using System.Linq;
+-using System.Text;
+-using System.Web;
+-
+-[assembly: System.Security.SecurityCritical]
+-[assembly: System.Security.AllowPartiallyTrustedCallers]
+
++// [assembly: System.Security.SecurityCritical]
++// [assembly: System.Security.AllowPartiallyTrustedCallers]
+ namespace Datadog.Trace.ClrProfiler
+ {
+     /// <summary>","Minor, but these two nullable and the logic around them could be replaced by a Lazy<Bool>.",Why delete these namespaces?
+7629,"@@ -1,12 +1,17 @@
+ package main
+
+ import (
++	""os""
++	""strconv""
+ 	""sync/atomic""
+ 	""syscall""
+ 	""time""
+
+-	""github.com/weaveworks/go-checkpoint""
++	checkpoint ""github.com/weaveworks/go-checkpoint""
+ 	weave ""github.com/weaveworks/weave/router""
++	api ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/client-go/kubernetes""
++	""k8s.io/client-go/rest""
+ )
+
+ var checker *checkpoint.Checker","I think I would just pass in `len(peers)`, on the principle of minimum information.",I'd prefer to see this as a
+7630,"@@ -84,6 +84,9 @@ public class TableProperties {
+   public static final String PARQUET_BATCH_SIZE = ""read.parquet.vectorization.batch-size"";
+   public static final int PARQUET_BATCH_SIZE_DEFAULT = 5000;
+
++  public static final String PARQUET_IN_LIMIT = ""read.parquet.in-predicate-limit"";
++  public static final int PARQUET_IN_LIMIT_DEFAULT = 200;
++
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ ","Spark's default value is 10 but it also rewrites IN as OR/EQUALS. We can do better that this because of the way we evaluate IN predicates. On datasets we tested this, we saw performance improvements on IN predicates with up to 200 elements (on sorted column). We may increase the default value a bit but I am very reluctant to make it more than 300 since our jobs were 20% slower with IN predicates that contained 300 elements. That being said, the optimal value still depends on a particular query and table.",Do we also need to configure
+7631,"@@ -20,6 +20,7 @@ package org.springframework.security.oauth2.core.oidc.endpoint;
+  * and used by the authorization endpoint and token endpoint.
+  *
+  * @author Joe Grandja
++ * @author Mark Heckler
+  * @since 5.0
+  * @see <a target=""_blank"" href=""https://openid.net/specs/openid-connect-core-1_0.html#OAuthParametersRegistry"">18.2 OAuth Parameters Registration</a>
+  */",Please update copyright year.,pls. remove author tag.
+7632,"@@ -289,9 +289,13 @@ int Extractor::run(ScriptingEnvironment &scripting_environment)
+
+         WriteEdgeBasedGraph(config.edge_graph_output_path, max_edge_id, edge_based_edge_list);
+
+-        util::SimpleLogger().Write()
+-            << ""Expansion  : "" << (number_of_node_based_nodes / TIMER_SEC(expansion))
+-            << "" nodes/sec and "" << ((max_edge_id + 1) / TIMER_SEC(expansion)) << "" edges/sec"";
++        const auto nodes_per_second =
++            static_cast<std::uint64_t>(number_of_node_based_nodes / TIMER_SEC(expansion));
++        const auto edges_per_second =
++            static_cast<std::uint64_t>((max_edge_id + 1) / TIMER_SEC(expansion));
++
++        util::SimpleLogger().Write() << ""Expansion: "" << nodes_per_second << "" nodes/sec and ""
++                                     << edges_per_second << "" edges/sec"";
+         util::SimpleLogger().Write() << ""To prepare the data for routing, run: ""
+                                      << ""./osrm-contract "" << config.output_file_name << std::endl;
+     }","Same here, could just be `std::setprecision`.",Should this be `std::size_t`?
+7633,"@@ -2290,14 +2290,6 @@ func (fbo *folderBranchOps) getConvID(
+
+ func (fbo *folderBranchOps) sendEditNotifications(
+ 	ctx context.Context, rmd ImmutableRootMetadata, body string) error {
+-	// For now only write out the notifications if we're in test mode,
+-	// just in case we decide to change the notification format before
+-	// we launch.  TODO: turn this on for admins once we can test it
+-	// on staging.
+-	if !fbo.config.Mode().IsTestMode() {
+-		return nil
+-	}
+-
+ 	handle := rmd.GetTlfHandle()
+ 	convID, err := fbo.getConvID(ctx, handle)
+ 	if err != nil {","Do we still want the ""admins"" gate?",Don't we still need this TODO
+7634,"@@ -1,8 +1,11 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
+ # This code example demonstrates how to upload multiple items
+-# to a bucket in Amazon S3.
++# to a bucket in Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3-ruby-example-upload-multiple-items]
+
+ # Prerequisites:
+ #  - An existing Amazon S3 bucket.",Simple Storage **Service**,Trailing whitespace detected.
+7635,"@@ -172,4 +172,11 @@ type Config struct {
+
+ 	// Configures telemetry.
+ 	Metrics MetricsConfig
++
++	// DisableAutoObservabilityMiddleware is used to stop the dispatcher from
++	// automatically attaching observability middleware to all inbounds and
++	// outbounds.  It is the assumption that if if this option is disabled the
++	// observability middleware is being inserted in the Inbound/Outbound
++	// Middleware.
++	DisableAutoObservabilityMiddleware bool
+ }",nit: `it is assumed`,"""inbounds and outbounds"" -> """
+7636,"@@ -23,6 +23,7 @@
+ #include <stdint.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <stdbool.h>
+ #include ""h2o.h""
+ #include ""h2o/http2.h""
+ #include ""h2o/http2_internal.h""","I would appreciate it if you could refrain from using `stdbool.h`. We allow the header files of H2O to be included from C++ (which means that `bool` might be a C++ type), and therefore my preference is to not use `bool` in our code (but instead use `int` or `char` for the purpose) to avoid confusion.",Is this needed?
+7637,"@@ -843,6 +843,9 @@ class RelationController extends ControllerBehavior
+             }
+
+             $widget = $this->makeWidget('Backend\Widgets\Lists', $config);
++            $widget->setSearchOptions([
++                'scope' => $this->getConfig('manage[searchScope]')
++            ]);
+
+             /*
+              * Apply defined constraints",@danielbidala What happens if `searchScope` is not defined in `config_relation.yaml` ?,`getConfig('man
+7638,"@@ -57,14 +57,17 @@ func serviceLoggedIn(ctx context.Context, config Config, session SessionInfo,
+ 			""%+v"", err)
+ 	}
+
++	// Launch auth refreshes in the background, in case we are
++	// currently disconnected from one of these servers.
+ 	mdServer := config.MDServer()
+ 	if mdServer != nil {
+-		mdServer.RefreshAuthToken(ctx)
++		go mdServer.RefreshAuthToken(context.Background())
+ 	}
+ 	bServer := config.BlockServer()
+ 	if bServer != nil {
+-		bServer.RefreshAuthToken(ctx)
++		go bServer.RefreshAuthToken(context.Background())
+ 	}
++
+ 	config.KBFSOps().RefreshCachedFavorites(ctx)
+ 	config.KBFSOps().PushStatusChange()
+ 	return wg",Do we want maybe a 1min timeout?,This is the mai
+7639,"@@ -48,11 +48,11 @@ func BasicAuthDecode(encoded string) (user string, name string, err error) {
+ 		return user, name, err
+ 	}
+
+-	a := strings.Split(string(s), "":"")
+-	if len(a) == 2 {
+-		user, name = a[0], a[1]
+-	} else {
++	a := strings.SplitN(string(s), "":"", 2)
++	if len(a) != 2 {
+ 		err = errors.New(""decode failed"")
++	} else {
++		user, name = a[0], a[1]
+ 	}
+ 	return user, name, err
+ }","I guess code never reaches this line, you can remove `else` block and just `return a[0], a[1]`. Also, probably rename `a` to `auth` as well.",nit: do you min
+7640,"@@ -43,7 +43,7 @@ class SerializableByteBufferMap implements Map<Integer, ByteBuffer>, Serializabl
+     return new SerializableByteBufferMap(map);
+   }
+
+-  public SerializableByteBufferMap() {
++  SerializableByteBufferMap() {
+     this.wrapped = Maps.newLinkedHashMap();
+   }
+ ",Doesn't this no-arg constructor need to be public for serialization to work?,Also not sure why this was made public.
+7641,"@@ -20,7 +20,7 @@ return [
+     'alpha_dash'           => 'Hierdie veld mag slegs letters, syfers, strepies en onderstrepe bevat.',
+     'alpha_num'            => 'Hierdie veld mag slegs letters en syfers bevat.',
+     'array'                => 'Hierdie veld moet \'n array wees.',
+-    'attached'             => 'This field is already attached.',
++    'attached'             => 'Hierdie gebied is reeds aangeheg.',
+     'before'               => 'Dit moet \'n datum voor :date wees.',
+     'before_or_equal'      => 'Dit moet \'n datum gelyk of voor :date wees.',
+     'between'              => [","Just use the word ""veld"" instead of ""gebied"" here",Prefer double-quoted strings unless you
+7642,"@@ -22,6 +22,7 @@ import android.util.Log;
+ import android.webkit.URLUtil;
+
+ import org.apache.commons.io.FileUtils;
++import org.shredzone.flattr4j.model.User;
+ import org.xml.sax.SAXException;
+
+ import java.io.File;",This change (import org.shredzone.flatter4j.model.User;) does not seem relevant to this fix / commit.,Are you sure this import is needed?
+7643,"@@ -63,6 +63,7 @@ var (
+ 	noCleanup            = app.Flag(""no-cleanup"", ""Whether or not to delete the chroot folder after the build is done"").Bool()
+ 	noCache              = app.Flag(""no-cache"", ""Disables using prebuilt cached packages."").Bool()
+ 	stopOnFailure        = app.Flag(""stop-on-failure"", ""Stop on failed build"").Bool()
++	hydratedBuild        = app.Flag(""hydrated-build"", ""Build individual packages with Hydrated RPMs"").String()
+
+ 	validBuildAgentFlags = []string{buildagents.TestAgentFlag, buildagents.ChrootAgentFlag}
+ 	buildAgent           = app.Flag(""build-agent"", ""Type of build agent to build packages with."").PlaceHolder(exe.PlaceHolderize(validBuildAgentFlags)).Required().Enum(validBuildAgentFlags...)",This should be a Bool() rather than a String(). (See the other PR for an example),"nit: ""Build individual packages with Hy"
+7644,"@@ -243,7 +243,7 @@ rules:
+         """"""Test that a bucket's rule can guarantee the maximum_retention if its
+         action is 'Delete' and the only condition is an age(<= maximum_retention)""""""
+         rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
+-        self.assertEqual(1, len(rules_engine.rule_book.resource_rules_map))
++        self.assertTrue(1 <= len(rules_engine.rule_book.resource_rules_map))
+
+         data_creater = frsd.FakeBucketDataCreater('fake_bucket', frsd.PROJECT1)
+         data_creater.AddLifecycleDict(action=""Delete"", age=365)",This should be a failure if we don't get the exact number of expected rules. You can use a constant if you don't want to update several lines any time you update the test rule strings.,why did this change?
+7645,"@@ -38,14 +38,14 @@ namespace Nethermind.Blockchain.Synchronization
+             _syncPeerPool = syncPeerPool ?? throw new ArgumentNullException(nameof(syncPeerPool));
+             _syncConfig = syncConfig ?? throw new ArgumentNullException(nameof(syncConfig));
+             _logger = logManager.GetClassLogger() ?? throw new ArgumentNullException(nameof(logManager));
+-
++
+             Current = SyncMode.NotStarted;
+         }
+
+         public SyncMode Current { get; private set; }
+
+         public bool IsParallel => Current == SyncMode.FastBlocks || Current == SyncMode.StateNodes;
+-
++
+         public void Update()
+         {
+             if (_syncPeerPool.PeerCount == 0)","We need to switch from BeamSync to FullSync when we download all the needed headers, blocks, receipts and state",Can you revert this
+7646,"@@ -61,15 +61,15 @@ thrift_protocol_set_property (GObject *object, guint property_id,
+   switch (property_id)
+   {
+     case PROP_THRIFT_PROTOCOL_TRANSPORT:
+-      protocol->transport = g_value_get_object (value);
++      protocol->transport = g_value_dup_object (value);
+       break;
+   }
+ }
+
+
+ gint32
+-thrift_protocol_write_message_begin (ThriftProtocol *protocol,
+-                                     const gchar *name,
++thrift_protocol_write_message_begin (ThriftProtocol *protocol,
++                                     const gchar *name,
+                                      const ThriftMessageType message_type,
+                                      const gint32 seqid, GError **error)
+ {",Why you duplicate it? The underlaying transport should live as long as the multiplexed one. And must be destroyed after protocol is destroyed. Duplicating the transport may lead to object references hold and maybe memory freeing problems. I think this property must hold a reference to it and not a copy. The copy can lead to memory freeing problems.,I don't understand w
+7647,"@@ -97,6 +97,7 @@ func (in *{{.Type}}) GetChaos() *ChaosInstance {
+ 		Kind:      Kind{{.Type}},
+ 		StartTime: in.CreationTimestamp.Time,
+ 		Action:    """",
++		Status:    string(in.Status.ChaosStatus.Experiment.Phase),
+ 		UID:       string(in.UID),
+ 	}
+ ",`in.Status.Experiment.Phase`. we can omit `ChaosStatus`,Doesn't have to be a
+7648,"@@ -1,9 +1,12 @@
+ package cmd
+
+ import (
++	""bytes""
+ 	""testing""
+
+ 	""encoding/json""
++	oexec ""os/exec""
++	""time""
+
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""",Just curious... why the alias here?,How about using `ddevctl` for this instead of `os/exec`?
+7649,"@@ -28,6 +28,7 @@
+         /// </summary>
+         private void InitializeComponent()
+         {
++            System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(DetectionToolbarProperties));
+             this.btnCancel = new System.Windows.Forms.Button();
+             this.btnOk = new System.Windows.Forms.Button();
+             this.label1 = new System.Windows.Forms.Label();",Seems like this should conflict with changes I made during merging of the 20.2 RESX file translation,I think we should be able to remove the `InitializeCompo
+7650,"@@ -11,6 +11,8 @@
+ #include ""graph/planner/plan/Query.h""
+ #include ""graph/util/ExpressionUtils.h""
+
++DEFINE_bool(enable_opt_collapse_project_rule, true, """");
++
+ using nebula::graph::PlanNode;
+ using nebula::graph::QueryContext;
+ ",Why disable this rule?,why is this needed?
+7651,"@@ -124,6 +124,6 @@ class ExternalEditor(QObject):
+         self._proc.error.connect(self.on_proc_error)
+         editor = config.get('general', 'editor')
+         executable = editor[0]
+-        args = [self._filename if arg == '{}' else arg for arg in editor[1:]]
++        args = [arg.replace('{}', self._filename) if '{}' in arg else arg for arg in editor[1:]]
+         log.procs.debug(""Calling \""{}\"" with args {}"".format(executable, args))
+         self._proc.start(executable, args)","I think you don't need the `... if '{}' in arg else arg` part - if the arg doesn't contain `{}`, `arg.replace('{}', ...)` will return the unchanged string anyways.",I don't think this is correct. It will replace all occur
+7652,"@@ -21,9 +21,11 @@ from google.cloud.security.common.util import log_util
+ from google.cloud.security.common.data_access import errors as dao_errors
+ from google.cloud.security.inventory import errors as inventory_errors
+ from google.cloud.security.inventory.pipelines import base_pipeline
++import threading
+
+
+ LOGGER = log_util.get_logger(__name__)
++GROUP_CHUNK_SIZE = 20
+
+
+ class LoadGroupMembersPipeline(base_pipeline.BasePipeline):",nit: Should we make this an attribute of the LoadGroupMembersPIpeline class?,is this a constant somewhere?
+7653,"@@ -479,6 +479,8 @@ public class JDBCConnection implements ObjectStoreConnection {
+             + ""JOIN principal ON principal.principal_id=principal_group_member.principal_id ""
+             + ""JOIN domain ON domain.domain_id=principal_group.domain_id ""
+             + ""WHERE principal_group_member.last_notified_time=? AND principal_group_member.server=?;"";
++    private static final String SQL_UPDATE_PRINCIPAL = ""UPDATE principal SET system_suspended=? WHERE principal_id=?;"";
++    private static final String SQL_GET_PRINCIPAL = ""SELECT name FROM principal WHERE system_suspended=?;"";
+
+     private static final String CACHE_DOMAIN    = ""d:"";
+     private static final String CACHE_ROLE      = ""r:"";",need to update this command to use the name field instead of principal_id,How about: `UPDATE principal
+7654,"@@ -51,7 +51,7 @@ public class PrivGetTransactionCount extends PrivacyApiMethod {
+     final Address address = requestContext.getRequiredParameter(0, Address.class);
+     final String privacyGroupId = requestContext.getRequiredParameter(1, String.class);
+
+-    final long nonce = privateTransactionHandler.getSenderNonce(address, privacyGroupId);
++    final long nonce = privateTransactionHandler.determineNonce(address, privacyGroupId);
+     return new JsonRpcSuccessResponse(requestContext.getRequest().getId(), Quantity.create(nonce));
+   }
+ }",nit: I can't help but think the privateTransactionHandler should be a base-class member ... every Priv Json RPC seems to need it...,Could this cause a problem if
+7655,"@@ -230,12 +230,8 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
+                 .setOnPreferenceChangeListener(
+                         (preference, newValue) -> {
+                             Intent i = new Intent(activity, MainActivity.class);
+-                            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
+-                                i.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK
+-                                        | Intent.FLAG_ACTIVITY_NEW_TASK);
+-                            } else {
+-                                i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+-                            }
++                            i.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK
++                                    | Intent.FLAG_ACTIVITY_NEW_TASK);
+                             activity.finish();
+                             activity.startActivity(i);
+                             return true;","Why does this start the main activity and not the preferences? With `overridePendingTransition(0, 0)`, this could instantly switch the theme without the user being disrupted",This is the only change I'm n
+7656,"@@ -117,6 +117,10 @@ public class DistributorStatus {
+       return up;
+     }
+
++    public boolean isDocker() {
++      return up;
++    }
++
+     public int getMaxSessionCount() {
+       return maxSessionCount;
+     }",Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?,Why is this needed?
+7657,"@@ -15,7 +15,7 @@ VERSION = ""2015-06-15""
+ # prerequisite: setuptools
+ # http://pypi.python.org/pypi/setuptools
+
+-REQUIRES = [""msrest>=0.1.0"", ""msrestazure>=0.1.0""]
++REQUIRES = [""msrest>=0.2.0"", ""msrestazure>=0.2.1""]
+
+ setup(
+     name=NAME,",It appears as though whoever checked in python changes didn't re-run regenerate:expected. I am modifying these files as a result of running that after a sync and build.,The latest version
+7658,"@@ -329,4 +329,13 @@ public abstract class FlatteningConfig {
+     paramList.forEach(p -> paramsAsString.append(p.getSimpleName()).append("", ""));
+     return paramsAsString.toString();
+   }
++
++  /** Return if the flattening config contains a parameter that is a resource name. */
++  public static boolean hasAnyResourceNameParameter(FlatteningConfig flatteningGroup) {
++    return flatteningGroup
++        .getFlattenedFieldConfigs()
++        .values()
++        .stream()
++        .anyMatch(FieldConfig::useResourceNameType);
++  }
+ }",This was copied from JavaMethodViewGenerator; only the `public static` method modifiers were added.,I would expect a me
+7659,"@@ -327,6 +327,18 @@ public class Transaction implements org.hyperledger.besu.plugin.data.Transaction
+     return Optional.ofNullable(maxFeePerGas);
+   }
+
++  public long getEffectivePriorityFeePerGas(final Optional<Long> maybeBaseFee) {
++    return maybeBaseFee
++        .filter(__ -> getType().supports1559FeeMarket())
++        .map(
++            baseFee ->
++                Math.max(
++                    0,
++                    Math.min(
++                        getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(),
++                        getMaxFeePerGas().get().getAsBigInteger().longValue() - baseFee)))
++        .orElseGet(() -> getGasPrice().getValue().longValue());
++  }
+   /**
+    * Returns the transaction gas limit.
+    *",this is going to throw for frontier transactions post-london,This is the wrong c
+7660,"@@ -389,8 +389,6 @@ class PropelInitService
+                 $theliaDatabaseConnection->useDebug(true);
+             }
+         } catch (\Throwable $th) {
+-            Tlog::getInstance()->error(""Failed to initialize Propel : "" . $th->getMessage());
+-
+             throw $th;
+         } finally {
+             // Release cache generation lock",The catch clause is not needed. The finally clause alone is enough.,Why did you remove this?
+7661,"@@ -117,6 +117,10 @@ public class DistributorStatus {
+       return up;
+     }
+
++    public boolean isDocker() {
++      return up;
++    }
++
+     public int getMaxSessionCount() {
+       return maxSessionCount;
+     }",Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?,Why is this needed?
+7662,"@@ -99,7 +99,7 @@ SRVR_STMT_HDL::SRVR_STMT_HDL(long inDialogueId)
+     moduleName[0] = '\0';
+     inputDescName[0] = '\0';
+     outputDescName[0] = '\0';
+-    isClosed = TRUE;
++    isClosed = FALSE;
+     IPD = NULL;
+     IRD = NULL;
+     useDefaultDesc = FALSE;",Changing the default value for isClosed from TRUE to FALSE can have other repercussions. We might miss throwing error. Can you please confirm this change.,Why change isClosed to f
+7663,"@@ -286,11 +286,13 @@ func (payloadHandler *payloadRequestHandler) handleUnrecognizedTask(task *ecsacs
+ 	}
+
+ 	// Only need to stop the task; it brings down the containers too.
+-	payloadHandler.taskHandler.AddTaskEvent(api.TaskStateChange{
++	te := api.TaskStateChange{
+ 		TaskArn: *task.Arn,
+ 		Status:  api.TaskStopped,
+ 		Reason:  UnrecognizedTaskError{err}.Error(),
+-	}, payloadHandler.ecsClient)
++	}
++
++	payloadHandler.taskHandler.AddStateChangeEvent(te, payloadHandler.ecsClient)
+ }
+
+ // clearAcks drains the ack request channel",Please use more meaningful names than `te`here and in other places.,Nit: can we call this `t
+7664,"@@ -33,8 +33,9 @@ type Catalog interface {
+ 	// the generic Plugin type
+ 	Plugins() []*ManagedPlugin
+
+-	// Finds plugin metadata
+-	Find(Plugin) *ManagedPlugin
++	// ConfigFor finds the plugin configuration for the supplied plugin. nil
++	// is returned if the plugin is not managed by the catalog.
++	ConfigFor(interface{}) *PluginConfig
+ }
+
+ type Config struct {","Perhaps this would be more idiomatic as `ConfigFor(interface{}) (*PluginConfig, bool)`?",This is a breaking change. I don't think we can do this in a minor release.
+7665,"@@ -3,9 +3,10 @@ from requests.models import Request
+ from localstack.utils.common import to_str
+ from localstack.services.generic_proxy import ProxyListener
+
++AWS_JSON_CONTENT_TYPE = 'application/x-amz-json-1.1'
+
+-class ProxyListenerCloudWatchLogs(ProxyListener):
+
++class ProxyListenerCloudWatchLogs(ProxyListener):
+     def forward_request(self, method, path, data, headers):
+         if method == 'POST' and path == '/':
+             if 'nextToken' in to_str(data or ''):",nit: We could import `APPLICATION_AMZ_JSON_1_1` from `constants.py` here.,"Instead of hardcoding the content type, can we use the constants AWS_JSON_C"
+7666,"@@ -0,0 +1,15 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MS-PL license.
++// See the LICENSE file in the project root for more information.
++
++using System;
++using System.Threading.Tasks;
++
++namespace MvvmCross.Base
++{
++    public interface IMvxMainThreadAsyncDispatcher
++    {
++        Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);
++        Task ExecuteOnMainThreadAsync(Func<Task> action, bool maskExceptions = true);
++    }
++}",Should this not inherit from IMvxMainThreadDispatcher?,This file needs to be renamed.
+7667,"@@ -19,18 +19,13 @@ import (
+
+ type roundCalculator struct {
+ 	chain                  ChainManager
+-	blockInterval          time.Duration
+ 	timeBasedRotation      bool
+ 	rp                     *rolldpos.Protocol
+ 	candidatesByHeightFunc CandidatesByHeightFunc
+ 	beringHeight           uint64
+ }
+
+-func (c *roundCalculator) BlockInterval() time.Duration {
+-	return c.blockInterval
+-}
+-
+-func (c *roundCalculator) UpdateRound(round *roundCtx, height uint64, now time.Time, toleratedOvertime time.Duration) (*roundCtx, error) {
++func (c *roundCalculator) UpdateRound(round *roundCtx, height uint64, blockInterval time.Duration, now time.Time, toleratedOvertime time.Duration) (*roundCtx, error) {
+ 	epochNum := round.EpochNum()
+ 	epochStartHeight := round.EpochStartHeight()
+ 	delegates := round.Delegates()",line is 167 characters (from `lll`),why is this removed?
+7668,"@@ -13,6 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
++using System.Collections.Generic;
+ using System.Diagnostics;
+ using OpenTelemetry;
+ using OpenTelemetry.Resources;",nit: consider adding a blank line between L15 and L16.,Why is this needed?
+7669,"@@ -445,10 +445,11 @@ void Storage::PopulateLayout(DataLayout &layout)
+     {
+         io::FileReader maneuver_overrides_file(config.GetPath("".osrm.maneuver_overrides""),
+                                                io::FileReader::VerifyFingerprint);
+-        const auto number_of_overrides = maneuver_overrides_file.ReadElementCount64();
++        const auto number_of_overrides =
++            maneuver_overrides_file.ReadVectorSize<extractor::StorageManeuverOverride>();
+         layout.SetBlockSize<extractor::StorageManeuverOverride>(DataLayout::MANEUVER_OVERRIDES,
+                                                                 number_of_overrides);
+-        const auto number_of_nodes = maneuver_overrides_file.ReadElementCount64();
++        const auto number_of_nodes = maneuver_overrides_file.ReadVectorSize<NodeID>();
+         layout.SetBlockSize<NodeID>(DataLayout::MANEUVER_OVERRIDE_NODE_SEQUENCES, number_of_nodes);
+     }
+ ",This is another bug fix: Without skipping the bytes of the vector this would read garbage data.,Why is this not `Re
+7670,"@@ -353,10 +353,12 @@ func (bc *blockchain) startExistingBlockchain(recoveryHeight uint64) error {
+ 	}
+ 	ws, err := bc.sf.NewWorkingSet()
+ 	if err != nil {
+-		return errors.Wrap(err, ""Failed to obtain working set from state factory"")
++		return errors.Wrap(err, ""failed to obtain working set from state factory"")
+ 	}
+ 	// If restarting factory from fresh db, first create creator's state
+ 	if startHeight == 0 {
++		actions := loadGenesisData(bc.config)
++		Gen.CreatorPubKey = actions.Creation.PubKey
+ 		if _, err := ws.LoadOrCreateAccountState(Gen.CreatorAddr(bc.ChainID()), Gen.TotalSupply); err != nil {
+ 			return err
+ 		}",why need this? i don't see Gen.CreatorPubKey being used?,Why you overwrite t
+7671,"@@ -147,6 +147,8 @@ OpenStreetMap::Application.routes.draw do
+   get ""/help"" => ""site#help""
+   get ""/about/:about_locale"" => ""site#about""
+   get ""/about"" => ""site#about""
++  get ""/communities"" => ""site#communities""
++  get ""/communities/:communities_locale"" => ""site#communities""
+   get ""/history"" => ""changesets#index""
+   get ""/history/feed"" => ""changesets#feed"", :defaults => { :format => :atom }
+   get ""/history/comments/feed"" => ""changeset_comments#index"", :as => :changesets_comments_feed, :defaults => { :format => ""rss"" }","As previously mentioned, best to drop this locale override. It's not something we only provide in exceptional circumstances. Moreover, it doesn't work for this PR anyway, while massively increasing the code complexity!",Prefer single-quote
+7672,"@@ -24,5 +24,16 @@ var (
+ 		  ""openebs.io/version"": ""{{.}}""
+ 	   }
+ 	}
++ }`
++	// VersionDetailsPatch is generic template for version details patch
++	VersionDetailsPatch = `{
++	""metadata"": {
++	   ""labels"": {
++		  ""openebs.io/version"": ""{{.}}""
++	   }
++	},
++	""versionDetails"": {
++		""desired"": ""{{.}}""
++	}
+  }`
+ )",is this supposed to be `Desired`?,Why the need for this patch if we have it as a template?
+7673,"@@ -1903,9 +1903,6 @@ public class TestPointQueries extends LuceneTestCase {
+       upperBound[i] = value[i] + random().nextInt(1);
+     }
+     Query query = IntPoint.newRangeQuery(""point"", lowerBound, upperBound);
+-    Weight weight = searcher.createWeight(query, ScoreMode.COMPLETE_NO_SCORES, 1);
+-    Scorer scorer = weight.scorer(searcher.getIndexReader().leaves().get(0));
+-    assertEquals(DocIdSetIterator.all(1).getClass(), scorer.iterator().getClass());
+
+     // When not all documents in the query have a value, the optimization is not applicable
+     reader.close();",The iterator is not wrapped when the score mode is set to `COMPLETE_NO_SCORES` so you don't need to change this assertion anymore ?,why is the score removed?
+7674,"@@ -9,7 +9,8 @@ def render_template(template, destination, **kwargs):
+     template = os.path.join(HERE, template)
+
+     folder = os.path.dirname(destination)
+-    os.makedirs(folder)
++    if os.path.exists(folder) == False:
++            os.makedirs(folder)
+
+     with codecs.open(template, 'r', encoding='utf-8') as f:
+         raw_template = f.read()",Is there too much spaces there? (should be 4 I think),`os.makedirs` doesn't handle the case where the folder a
+7675,"@@ -57,6 +57,8 @@ public class KieClient {
+
+   private static final int LONG_POLLING_WAIT_TIME_IN_SECONDS = 30;
+
++  private static String revision = ""0"";
++
+   private static final KieConfig KIE_CONFIG = KieConfig.INSTANCE;
+
+   private final int refreshInterval = KIE_CONFIG.getRefreshInterval();","IS_FIRST_PULL revision is better to use instance property, not static. When KieClient has only one instance, instance property is better. When KieClient has many instances(not possible), static is not good eitheir.",Can we have this as an enum?
+7676,"@@ -1,4 +1,5 @@
+ <?php
+ return [
+     'extends' => 'bootstrap3',
++    'mixins' => ['fontawesome5_icon_mixin'],
+ ];",This needs to be removed since we removed the mixin.,It should be called `fontawesome5_icon_mixin`.
+7677,"@@ -219,8 +219,7 @@ RaftPart::RaftPart(ClusterID clusterId,
+         , ioThreadPool_{pool}
+         , bgWorkers_{workers}
+         , executor_(executor)
+-        , snapshot_(snapshotMan)
+-        , weight_(1) {
++        , snapshot_(snapshotMan) {
+     FileBasedWalPolicy policy;
+     policy.ttl = FLAGS_wal_ttl;
+     policy.fileSize = FLAGS_wal_file_size;",Can `weight_` be deleted?,remove the extra `weight_(1)` here.
+7678,"@@ -50,6 +50,17 @@ class EasyAdminExtension extends Extension
+         }
+
+         $this->ensureBackwardCompatibility($container);
++
++        if ($container->hasParameter('locale')) {
++            $container->getDefinition('easyadmin.configuration.design_config_pass')
++                ->replaceArgument(1, $container->getParameter('locale'));
++        }
++
++        $configPasses = $container->findTaggedServiceIds('easyadmin.config_pass');
++        $definition = $container->getDefinition('easyadmin.config.manager');
++        foreach ($configPasses as $id => $tags) {
++            $definition->addMethodCall('addConfigPass', array(new Reference($id)));
++        }
+     }
+
+     /**","This is fine, but by Symfony convention this part is responsability of the compiler pass class, i.e `DependencyInjection\Compiler\?`",Shouldn't we add the `locale` parameter to the
+7679,"@@ -9,6 +9,18 @@ module Unix::File
+     execute(""mktemp -td #{name}.XXXXXX"")
+   end
+
++  # Create a temporary directory owned by the Puppet user.
++  #
++  # @param name [String] The name of the directory.  It will be suffixed with a
++  #   unique identifier to avoid conflicts.
++  # @return [String] The path to the temporary directory.
++  def puppet_tmpdir(name)
++    dir = tmpdir(name)
++    user = execute(""puppet master --configprint user"")
++    execute(""chown #{user} #{dir}"")
++    dir
++  end
++
+   def path_split(paths)
+     paths.split(':')
+   end",The host object already has a nice way of querying configprint. Try `puppet('master')['user']`,Do we want to ensure the user has the right pe
+7680,"@@ -20,6 +20,7 @@ from mitmproxy.addons import stickycookie
+ from mitmproxy.addons import streambodies
+ from mitmproxy.addons import save
+ from mitmproxy.addons import upstream_auth
++from mitmproxy.addons import upload
+
+
+ def default_addons():","Let's call this `share` and not `upload` - the user wants to share their flows, uploading is just the implementation of that. :)","The `upstream_auth` no longer used in the `save` function, so I can remove it."
+7681,"@@ -6,8 +6,9 @@
+
+ import wx
+ import gui
++import config
+
+-class SpeechViewerFrame(wx.MiniFrame):
++class SpeechViewerFrame(wx.Dialog):
+
+ 	def __init__(self):
+ 		super(SpeechViewerFrame, self).__init__(gui.mainFrame, wx.ID_ANY, _(""NVDA Speech Viewer""), style=wx.CAPTION | wx.RESIZE_BORDER | wx.STAY_ON_TOP)","It would be better to keep focus on the main text control. But to get around the fact that Dialogs focus their first child on show, even when not active, something like Dialog.isActive should be chcked when appending text, rather than whether the text control has focus.",why is this necessary?
+7682,"@@ -1205,6 +1205,7 @@ end_and_emit_trace(dcontext_t *dcontext, fragment_t *cur_f)
+         target = opnd_get_pc(instr_get_target(last));
+         md->emitted_size -= local_exit_stub_size(dcontext, target, md->trace_flags);
+     }
++    IF_AARCH64(md->emitted_size += fixup_indirect_trace_exit(dcontext, trace));
+
+     if (DYNAMO_OPTION(speculate_last_exit)
+ #ifdef HASHTABLE_STATISTICS",So is this invoked every time we extend the trace?,Shouldn't this be `if (DYNAMO_OPTION(speculate_last_exit))` instead?
+7683,"@@ -55,11 +55,16 @@ constexpr int64_t kMaxTimestamp = std::numeric_limits<int64_t>::max() / 10000000
+         return Status::Error(""Invalid second number `%ld'."", kv.second.getInt());
+       }
+       dt.sec = kv.second.getInt();
++    } else if (kv.first == ""millisecond"") {
++      if (kv.second.getInt() < 0 || kv.second.getInt() > 999) {
++        return Status::Error(""Invalid millisecond number `%ld'."", kv.second.getInt());
++      }
++      dt.microsec += kv.second.getInt() * 1000;
+     } else if (kv.first == ""microsecond"") {
+-      if (kv.second.getInt() < 0 || kv.second.getInt() > 999999) {
++      if (kv.second.getInt() < 0 || kv.second.getInt() > 999) {
+         return Status::Error(""Invalid microsecond number `%ld'."", kv.second.getInt());
+       }
+-      dt.microsec = kv.second.getInt();
++      dt.microsec += kv.second.getInt();
+     } else {
+       return Status::Error(""Invlaid parameter `%s'."", kv.first.c_str());
+     }",Why not use switch here?,"I don't think this is correct, if you expect 999 seconds, you will get an erro"
+7684,"@@ -37,6 +37,7 @@ type Route struct {
+ 	Method      string
+ 	Path        string
+ 	HandlerFunc HandlerFunc
++	AuthFree    bool // routes that has the AuthFree set to true doesn't require authentication
+ }
+
+ // Routes contains all routes",I think `NoAuth` is a better name,"I think this needs to be `AuthFree bool` instead of `AuthFree`. The `bool` type is `bool`, but the `authfree` type is `bool`."
+7685,"@@ -214,6 +214,13 @@ func (es *{{ $esapi.Name }}) waitStreamPartClose() {
+ 			es.inputWriter = inputWriter
+ 	}
+
++	func (es *{{ $esapi.Name }}) closeInputWriter(r *request.Request) {
++		err := es.inputWriter.Close()
++		if err != nil {
++			r.Error = awserr.New(eventstreamapi.InputWriterCloseErrorCode, err.Error(), r.Error)
++		}
++	}
++
+ 	// Send writes the event to the stream blocking until the event is written.
+ 	// Returns an error if the event was not written.
+ 	//",This does create a minor bifurcation in how closing the InputWriter is done in success vs failure cases. Is there anyway to merge this with the success exit path? This is something that seems like it would be better as a function closure instead of method on the `$esapi.Name` type. Can the `es.Close` not be used instead of this method?,Why not just return the error? `r.Error = eventstreamapi.InputWriterCloseErrorCode`
+7686,"@@ -132,7 +132,6 @@ class RootContext(object):
+
+
+ class Log(object):
+-
+     def __init__(self, msg, level=""info""):
+         self.msg = msg
+         self.level = level",Please keep this blank line. PEP8 says: > Method definitions inside a class are surrounded by a single blank line.,why is this being moved?
+7687,"@@ -6,7 +6,7 @@
+       <%= link_to(t(:'blacklight.search.per_page.button_label', :count => current_per_page), ""#"") %> <span class=""caret""></span>
+       <ul>
+         <%- blacklight_config.per_page.each do |count| %>
+-          <li><%= link_to(t(:'blacklight.search.per_page.label', :count => count).html_safe, url_for(params_for_search(:per_page => count))) %></li>
++          <li><%= link_to(t(:'blacklight.search.per_page.label', :count => count).html_safe, params_for_search(params.merge(:per_page => count))) %></li>
+         <%- end -%>
+       </ul>
+     </li>",You are not passing in a `:params` key here.,Use the new hash syntax `params_for_search(params[:per_page => count])`
+7688,"@@ -79,6 +79,7 @@ func (i *Initializer) prepareHostNetwork() error {
+ // prepareOVSBridge adds local port and uplink to ovs bridge.
+ // This function will delete OVS bridge and HNS network created by antrea on failure.
+ func (i *Initializer) prepareOVSBridge() error {
++	klog.Info(""preparing ovs bridge ..."")
+ 	hnsNetwork, err := hcsshim.GetHNSNetworkByName(util.LocalHNSNetwork)
+ 	defer func() {
+ 		// prepareOVSBridge only works on windows platform. The operation has a chance to fail on the first time agent","Probably change ""ovs"" to ""OVS"".","ditto, should this be `Infof`?"
+7689,"@@ -87,7 +87,9 @@ abstract class BaseMediaAdmin extends AbstractAdmin
+             $this->getRequest()->query->set('provider', $provider);
+         }
+
+-        $categoryId = $this->getRequest()->get('category');
++        $uniqueId = $this->getRequest()->get('uniqid');
++        $formParams =  $this->getRequest()->get($uniqueId);
++        $categoryId = $formParams && array_key_exists('category', $formParams) ? $formParams['category'] : $this->getRequest()->get('category');
+
+         if (null !== $this->categoryManager && !$categoryId) {
+             $categoryId = $this->categoryManager->getRootCategory($context)->getId();",Please linebreak this,Does the `uniqid` request para
+7690,"@@ -21,7 +21,7 @@ namespace Nethermind.Blockchain.Data
+ {
+     public class EmptyLocalDataSource<T> : ILocalDataSource<T>
+     {
+-        public T Data { get; } = default;
+-        public event EventHandler Changed;
++        public T? Data { get; }
++        public event EventHandler? Changed;
+     }
+ }","`= default` is implied here, so having it is redundant. Is it a stylistic choice to include it, or just an oversight?",Should this be marked as nulla
+7691,"@@ -226,7 +226,7 @@ type wsPipelineReader interface {
+ 	wsPipelineManifestReader
+ }
+
+-type wsProjectManager interface {
++type wsAppManager interface {
+ 	Create(projectName string) error
+ 	Summary() (*workspace.Summary, error)
+ }",Maybe it's time to fix the param name for this interface?,I think it would be nice to ex
+7692,"@@ -232,9 +232,6 @@ type (
+ 		CancelRequestId                        string
+ 		StickyTaskQueue                        string
+ 		StickyScheduleToStartTimeout           *time.Duration
+-		ClientLibraryVersion                   string
+-		ClientFeatureVersion                   string
+-		ClientImpl                             string
+ 		AutoResetPoints                        *workflowpb.ResetPoints
+ 		Memo                                   map[string]*commonpb.Payload
+ 		SearchAttributes                       map[string]*commonpb.Payload","Why are we removing it? Looks like useful info. Obviously, field names should change.",why delete these?
+7693,"@@ -49,12 +49,18 @@ namespace NLog.LayoutRenderers
+         private const int MaxInitialRenderBufferLength = 16384;
+         private int _maxRenderedLength;
+         private bool _isInitialized;
++        private IValueFormatter _valueFormatter;
+
+         /// <summary>
+         /// Gets the logging configuration this target is part of.
+         /// </summary>
+         protected LoggingConfiguration LoggingConfiguration { get; private set; }
+
++        /// <summary>
++        /// Value formatter
++        /// </summary>
++        protected IValueFormatter ValueFormatter => _valueFormatter ?? (_valueFormatter = Resolve<IValueFormatter>());
++
+         /// <summary>
+         /// Returns a <see cref=""System.String""/> that represents this instance.
+         /// </summary>",Missing fallback to MessageTemplates.ValueFormatter.Instance,Can't we just hav
+7694,"@@ -1193,7 +1193,7 @@ class _Frame(object):
+
+     # TODO: by argument only support the grouping name and as_index only for now. Documentation
+     # should be updated when it's supported.
+-    def groupby(self, by, as_index: bool = True):
++    def groupby(self, by, axis=0, as_index: bool = True):
+         """"""
+         Group DataFrame or Series using a Series of columns.
+ ","The parameter in the docstring should be fixed too. Actually, why don't you try to implement the other axis? It wouldn't be impossible to do if we use pandas UDF from a cursory look. We have enough time before the next release currently.",is this a public
+7695,"@@ -16,11 +16,13 @@ package patch
+
+ import (
+ 	""context""
++	""fmt""
+ 	""os""
+ 	""time""
+
+-	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/cloud.google.com/go/osconfig/apiv1alpha1""
+-	osconfigpb ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/google.golang.org/genproto/googleapis/cloud/osconfig/v1alpha1""
++	""cloud.google.com/go/compute/metadata""
++	osconfig ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/cloud.google.com/go/osconfig/apiv1alpha1""
++	api ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/google.golang.org/genproto/googleapis/cloud/osconfig/v1alpha1""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/config""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/logger""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/tasker""",This also runs a patch if its in the middle of one.,nit: remove the e
+7696,"@@ -248,7 +248,7 @@ func (task *Task) UpdateMountPoints(cont *Container, vols map[string]string) {
+ // there was no change
+ // Invariant: task known status is the minimum of container known status
+ func (task *Task) updateTaskKnownStatus() (newStatus TaskStatus) {
+-	seelog.Debug(""Updating task: %s"", task.String())
++	seelog.Debugf(""Updating task: %s"", task.String())
+
+ 	// Set to a large 'impossible' status that can't be the min
+ 	earliestStatus := ContainerZombie",Could we rename this method to `updateKnownStatus` ?,Did you mean to leave this in?
+7697,"@@ -76,6 +76,12 @@ namespace Datadog.Trace
+                                 Tracer.Sampler?.GetSamplingPriority(RootSpan);
+                         }
+                     }
++
++                    // set the origin tag to the root span of each trace/subtrace
++                    if (span.Context.Origin != null)
++                    {
++                        span.SetTag(Tags.Origin, span.Context.Origin);
++                    }
+                 }
+
+                 _spans.Add(span);","Maybe it would make sense to move that to DecorateRootSpan? Currently it only has Azure stuff, but given the name of the method I feel like it would be semantically appropriate",when do we expect this to be n
+7698,"@@ -5,13 +5,14 @@ import (
+ 	""sync""
+
+ 	""github.com/pkg/errors""
+-	coreapi ""k8s.io/api/core/v1""
+-	extnapi ""k8s.io/api/extensions/v1beta1""
+-	networkingv1 ""k8s.io/api/networking/v1""
+-
+ 	""github.com/weaveworks/weave/common""
+ 	""github.com/weaveworks/weave/net/ipset""
+ 	""github.com/weaveworks/weave/npc/iptables""
++	coreapi ""k8s.io/api/core/v1""
++	extnapi ""k8s.io/api/extensions/v1beta1""
++	networkingv1 ""k8s.io/api/networking/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/client-go/kubernetes""
+ )
+
+ type NetworkPolicyController interface {",nit: these imports were in a separate group to ones from this repo,metav1 should go at the end of
+7699,"@@ -22,4 +22,12 @@ public enum DispatchMethod {
+   public static boolean isPollMethodEnabled(String dispatchMethod) {
+     return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.POLL;
+   }
++
++  public static boolean isPushMethodEnabled(String dispatchMethod) {
++    return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.PUSH;
++  }
++
++  public static boolean isPushContainerizedMethodEnabled(String dispatchMethod) {
++    return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.PUSH_CONTAINERIZED;
++  }
+ }",Is it possible to rename the methods to `isXXXMethod` to keep the usage by the caller generic? The caller could use the result of these methods to verify whether a feature is enabled or to validate an input value for example.,What about pushContainerizedMe
+7700,"@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
+ exports.rmDir = function(path) {
+   return new promise.Promise(function(fulfill, reject) {
+     var numAttempts = 0;
++    var maxAttempts = 5;
++    var attemptTimeout = 250;
+     attemptRm();
+     function attemptRm() {
+       numAttempts += 1;
+       rimraf(path, function(err) {
+         if (err) {
+-          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+-            attemptRm();
++          if (err.code === 'ENOTEMPTY' && numAttempts <= maxAttempts) {
++            setTimeout(attemptRm, attemptTimeout);
+             return;
+           }
+           reject(err);",Don't penalize everyone with 250ms delay b/c some machines have problems.,Let's use `ENOTEMPTY` as the default.
+7701,"@@ -130,7 +130,11 @@ public final class UserUtils {
+             // Match!
+             // reparse the config file
+             log.info(""Modification detected, reloading config file "" + filename);
+-            configFileMap.get(filename).parseConfigFile();
++            try {
++              configFileMap.get(filename).parseConfigFile();
++            } catch (Exception e) {
++              log.error(""Failed parsing config file after update: "" + filename, e);
++            }
+             break;
+           }
+         }","This try-catch should be here so that watcher thread doesn't just exit in case of an exception. This change alone would probably be enough to fix the error as well, assuming that there's another `ENTRY_MODIFY` event when the file write is finalized. But of course not a perfect fix because it doesn't protect against possibly reading a non-empty but only partially written file?",Can you at least log the exception at
+7702,"@@ -417,6 +417,9 @@ func (s *Server) sendInternalMsg(sub, rply string, si *ServerInfo, msg interface
+
+ // Locked version of checking if events system running. Also checks server.
+ func (s *Server) eventsRunning() bool {
++	if s == nil {
++		return false
++	}
+ 	s.mu.Lock()
+ 	er := s.running && s.eventsEnabled()
+ 	s.mu.Unlock()",Weird that we have to check for `s == nil` here.. I would instead have fixed the call stack to find out when this gets invoked with a nil server.,Is this change necessary? I don't see
+7703,"@@ -228,7 +228,7 @@ export default Controller.extend({
+         if (erroredEmails.length > 0) {
+             invitationsString = erroredEmails.length > 1 ? ' invitations: ' : ' invitation: ';
+             message = `Failed to send ${erroredEmails.length} ${invitationsString}`;
+-            message += erroredEmails.join(', ');
++            message += Ember.Handlebars.Utils.escapeExpression(erroredEmails.join(', '));
+             message += '. Please check your email configuration, see <a href=\'https://docs.ghost.org/docs/mail-config\' target=\'_blank\'>https://docs.ghost.org/v1.0.0/docs/mail-config</a> for instructions';
+
+             message = htmlSafe(message);",The `import` statement for `Ember` is missing in this file.,This helper method is already being u
+7704,"@@ -90,7 +90,7 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			let s = c._nextState || c.state;
+ 			if (newType.getDerivedStateFromProps!=null) {
+ 				oldState = assign({}, c.state);
+-				if (s===c.state) s = assign({}, s);
++				if (s===c.state) s = c._nextState = assign({}, s);
+ 				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
+ 			}
+ ",Awesome :tada: I'd love to have a test case for this so that we don't regress on this feature in any future refactorings :+1:,How is this change related to this PR?
+7705,"@@ -28,7 +28,7 @@ class SeriesDateTimeTest(ReusedSQLTestCase, SQLTestUtils):
+
+     @property
+     def pdf1(self):
+-        date1 = pd.Series(pd.date_range('2012-1-1 12:00:00', periods=3, freq='M'))
++        date1 = pd.Series(pd.date_range('2012-1-1 12:45:31', periods=3, freq='M'))
+         date2 = pd.Series(pd.date_range('2013-3-11 21:45:00', periods=3, freq='W'))
+         return pd.DataFrame(dict(start_date=date1, end_date=date2))
+ ",For testing some of the rounding functions,should we change the freq to 'MS' ?
+7706,"@@ -56,6 +56,10 @@ class CurrencyDataFixture extends AbstractReferenceFixture
+          * @see \Shopsys\FrameworkBundle\Migrations\Version20180603135342
+          */
+         $currencyCzk = $this->currencyFacade->getById(1);
++        $currencyData = $this->currencyDataFactory->createFromCurrency($currencyCzk);
++        $currencyData->minFractionDigits = Currency::DEFAULT_MIN_FRACTION_DIGITS;
++        $currencyData->roundingType = Currency::ROUNDING_TYPE_INTEGER;
++        $currencyCzk = $this->currencyFacade->edit($currencyCzk->getId(), $currencyData);
+         $this->addReference(self::CURRENCY_CZK, $currencyCzk);
+
+         if (count($this->domain->getAll()) > 1) {",This should be present in UPGRADE notes. Also on currently running projects you should suggest users to update these settings.,I don't think that this is needed - it
+7707,"@@ -1053,10 +1053,9 @@ func (bdl *backpressureDiskLimiter) reserveBytes(
+ 	if count < 0 {
+ 		return count, nil
+ 	}
+-	// We calculate the total free bytes by adding the reported free bytes and
+-	// the non-`tracker` used bytes.
+-	tracker.updateFree(freeBytes + bdl.overallByteTracker.used -
+-		tracker.usedResources())
++	// TODO: verify there's not any other kind of bytes we care about
++	// subtracting too.
++	tracker.updateFree(freeBytes)
+
+ 	count = tracker.tryReserve(blockBytes)
+ 	if count < 0 {","Are you sure you want to do this? This will affect the working set block cache too, such that it'll now be tracking global free space. It throws off the fraction calculation.",The TODO seems to indicate that this i
+7708,"@@ -44,6 +44,7 @@ bool CompoundReaderListener::hasReaderAttached(){
+ 	return false;
+ }
+ ReaderListener* CompoundReaderListener::getAttachedListener(){
++	std::lock_guard<std::mutex> lock(attached_listener_mutex);
+ 	if(attached_listener != nullptr)
+ 		return attached_listener;
+ 	return nullptr;",Why would the read access need to be mutexed? The caller might still get a wrong answer since the value might change immediately after the mutex is unlocked before the caller receives the value.,There is `std::atomic_load` that could lock the lock.
+7709,"@@ -631,6 +631,16 @@ class TabbedBrowser(tabwidget.TabWidget):
+         if config.val.tabs.tabs_are_windows:
+             self.window().setWindowIcon(icon)
+
++    @pyqtSlot(usertypes.KeyMode)
++    def on_mode_entered(self, mode):
++        """"""Save input mode when tabs.mode_on_change = restore.""""""
++        input_modes = [usertypes.KeyMode.insert, usertypes.KeyMode.passthrough]
++        if (mode in input_modes and
++                config.val.tabs.mode_on_change == 'restore'):
++            tab = self.currentWidget()
++            if tab and tab is not None:
++                tab.data.input_mode = mode
++
+     @pyqtSlot(usertypes.KeyMode)
+     def on_mode_left(self, mode):
+         """"""Give focus to current tab if command mode was left.""""""",This fits on one line without the parentheses :wink:,This function doesn't seem to be used anywhere.
+7710,"@@ -64,7 +64,7 @@ public class TestCloudRecovery extends SolrCloudTestCase {
+
+   @Before
+   public void beforeTest() throws Exception {
+-    configureCluster(2)
++    configureCluster(4)
+         .addConfig(""config"", TEST_PATH().resolve(""configsets"").resolve(""cloud-minimal"").resolve(""conf""))
+         .configure();
+ ",Looks like `TestCloudRecovery` changes are unrelated?,why is this needed?
+7711,"@@ -10,16 +10,14 @@ declare(strict_types = 1);
+ namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute;
+
+ use Doctrine\DBAL\Connection;
++use Doctrine\DBAL\DBALException;
+ use Ergonode\Attribute\Domain\Event\Attribute\AttributeHintChangedEvent;
+ use Ergonode\Core\Domain\Entity\AbstractId;
+-use Ergonode\EventSourcing\Infrastructure\DomainEventInterface;
+-use Ergonode\EventSourcing\Infrastructure\Exception\UnsupportedEventException;
+-use Ergonode\EventSourcing\Infrastructure\Projector\DomainEventProjectorInterface;
+ use Ramsey\Uuid\Uuid;
+
+ /**
+  */
+-class AttributeHintChangedEventProjector implements DomainEventProjectorInterface
++class AttributeHintChangedEventProjector
+ {
+     private const TABLE = 'value_translation';
+ ",Try to separate it to different methods. Invoke is huge :),Why did you remove this interface?
+7712,"@@ -16,7 +16,7 @@
+           </thead>
+           <tbody>
+             <% scope.each do |plan| %>
+-              <tr>
++              <tr id=""<%= dom_id(plan) %>"">
+                 <td>
+                   <%= link_to ""#{plan.title.length > 60 ? ""#{plan.title[0..59]} ..."" : plan.title}"",
+                       plan_path(plan) %>",Looks like another spot that would benefit from `truncate`,Should we use a `<%= dom_id(plan)` helper here?
+7713,"@@ -272,7 +272,7 @@ static mrb_value build_constants(mrb_state *mrb, const char *server_name, size_t
+             mrb_ary_set(mrb, ary, i, lit);
+         }
+         for (; i != H2O_MAX_TOKENS * 2; ++i) {
+-            const h2o_token_t *token = h2o__tokens + i - H2O_MAX_TOKENS;
++            const h2o_token_t *token = h2o__tokens + (i - H2O_MAX_TOKENS);
+             mrb_value lit = mrb_nil_value();
+             if (token == H2O_TOKEN_CONTENT_TYPE) {
+                 lit = mrb_str_new_lit(mrb, ""CONTENT_TYPE"");","This change is not related to what this PR wanted to fix, but undefined behavior sanitizer warns without this parenthesis because `h2o__tokens + i` overflows.",The parenthesis around `i - H2O_MAX_TOKENS` is
+7714,"@@ -223,7 +223,7 @@ class DocstringParameterChecker(BaseChecker):
+
+         # skip functions that match the 'no-docstring-rgx' config option
+         no_docstring_rgx = get_global_option(self, ""no-docstring-rgx"")
+-        if no_docstring_rgx and re.match(no_docstring_rgx, node.name):
++        if no_docstring_rgx.pattern and re.match(no_docstring_rgx, node.name):
+             return
+
+         # skip functions smaller than 'docstring-min-length'","This is actually incorrect and should be the other way around. Going to fix this tomorrow. If `no_docstring_rgx == re.compile("""")` no function should be checked, since every function matches the pattern. If `no_docstring_rgx == re.compile(""^$"")` all functions should be checked.",This will need to check that the `docstring-min
+7715,"@@ -95,7 +95,7 @@ def get_spotify_oauth():
+     """"""
+     client_id = current_app.config['SPOTIFY_CLIENT_ID']
+     client_secret = current_app.config['SPOTIFY_CLIENT_SECRET']
+-    scope = 'user-read-recently-played'
++    scope = 'user-read-recently-played user-read-currently-playing'
+     redirect_url = current_app.config['SPOTIFY_CALLBACK_URL']
+     return spotipy.oauth2.SpotifyOAuth(client_id, client_secret, redirect_uri=redirect_url, scope=scope)
+ ",Should this be in a config file?,I think we should change this to `user-read-cur
+7716,"@@ -3,13 +3,15 @@ const {
+   eachAsync,
+   executeLegacyOperation,
+   makeInterruptibleAsyncInterval,
+-  BufferPool
++  BufferPool,
++  shuffle
+ } = require('../../src/utils');
+ const { expect } = require('chai');
+ const sinon = require('sinon');
++const { MongoRuntimeError } = require('../../src/error');
+
+-describe('utils', function () {
+-  context('eachAsync', function () {
++describe('driver utils', function () {
++  context('eachAsync function', function () {
+     it('should callback with an error', function (done) {
+       eachAsync(
+         [{ error: false }, { error: true }],","purely preference, but have you considered using parentheses to indicate that a method is being tested? e.g., `describe('eachAsync()')`","We don't need to shuffle any more, right?"
+7717,"@@ -449,9 +449,10 @@ ResultCode RocksEngine::createCheckpoint(const std::string& name) {
+     auto checkpointPath = folly::stringPrintf(""%s/checkpoints/%s/data"",
+                                               dataPath_.c_str(), name.c_str());
+     LOG(INFO) << ""Target checkpoint path : "" << checkpointPath;
+-    if (fs::FileUtils::exist(checkpointPath)) {
+-        LOG(ERROR) << ""The snapshot file already exists: "" << checkpointPath;
+-        return ResultCode::ERR_CHECKPOINT_ERROR;
++    if (fs::FileUtils::exist(checkpointPath) &&
++        !fs::FileUtils::remove(checkpointPath.data(), true)) {
++            LOG(ERROR) << ""Remove exist dir failed of checkpoint : "" << checkpointPath;
++            return ResultCode::ERR_IO_ERROR;
+     }
+
+     auto parent = checkpointPath.substr(0, checkpointPath.rfind('/'));",Why not return success?,Would this be better as `!fs::FileUtils::
+7718,"@@ -3,12 +3,19 @@ namespace Psalm\Report;
+
+ use Psalm\Config;
+ use Psalm\Internal\Analyzer\DataFlowNodeData;
++use Psalm\Internal\Analyzer\IssueData;
+ use Psalm\Report;
+
++use function get_cfg_var;
++use function ini_get;
++use function strtr;
+ use function substr;
+
+ class ConsoleReport extends Report
+ {
++    /** @var string|null */
++    private $linkFormat;
++
+     public function create(): string
+     {
+         $output = '';",Please use snake_case for properties to keep it consistent with the rest of the codebase.,Should be `string|null`
+7719,"@@ -304,7 +304,9 @@ func New(ctx context.Context, signer beecrypto.Signer, networkID uint64, overlay
+ 		}
+
+ 		s.metrics.HandledStreamCount.Inc()
+-		s.logger.Infof(""successfully connected to peer (inbound) %s"", i.BzzAddress.ShortString())
++		s.logger.Debugf(""successfully connected to peer (inbound) %s"", i.BzzAddress.ShortString())
++		s.logger.Infof(""successfully connected to peer (inbound)"")
++
+ 	})
+
+ 	h.Network().SetConnHandler(func(_ network.Conn) {",i don't understand why we need this change. what information is this providing when running in less than Debug loglevel? I prefer to revert this,why make this change?
+7720,"@@ -170,6 +170,9 @@ public class ExecutionFlowDaoTest {
+     final List<ExecutableFlow> flows = this.executionFlowDao
+         .fetchRecentlyFinishedFlows(RECENTLY_FINISHED_LIFETIME);
+     assertThat(flows.size()).isEqualTo(0);
++
++    //Restore the clock
++    DateTimeUtils.setCurrentMillisOffset(0);
+   }
+
+   @Test","Oh, so this test leaks DateTimeUtils offset? It would be safer to place the reset in an `@After` method to not cause side effects even if the test case fails.",why is this needed?
+7721,"@@ -28,14 +28,6 @@ import { Grid, Cell, Row } from '../../../../../material-components';
+ import Pagination from './Pagination';
+
+ export default function Footer( { tab, footerText } ) {
+-	if ( ! footerText ) {
+-		return (
+-			<div className=""googlesitekit-idea-hub__footer"">
+-				<Pagination tab={ tab } />
+-			</div>
+-		);
+-	}
+-
+ 	return (
+ 		<Grid className=""googlesitekit-idea-hub__footer"">
+ 			<Row>","Kind of a nit-pick, but is there no way to solve this while still not rendering an empty div if `footerText` is empty? We could still use the `Row` to maintain the same layout but then only render the `Cell` for the pagination - I think it's possible to use specific classes to horizontally offset?",Why did we remove t
+7722,"@@ -23,12 +23,14 @@ import java.util.Objects;
+ public class DomainChangeMessage {
+
+     // Represent the changed object type
+-    enum ObjectType {
++    public enum ObjectType {
+         DOMAIN,
+-        ROLE,
++        ROLE,
++        GROUP,
+         POLICY,
+-        SERVICE,
+-        ENTITY
++        SERVICE,
++        ENTITY,
++        TEMPLATE
+     }
+
+     private String domainName;","Template is also not an object type so I don't expect to notify on templates. Instead when applying templates, we'll be updating roles/policies/services/groups.",I am not sure if we
+7723,"@@ -93,7 +93,8 @@ class iloc(Accessor):
+         rows, cols = index
+         if rows is Ellipsis:
+             rows = slice(None)
+-        data = dataset.interface.iloc(dataset.dataset, (rows, cols))
++
++        data = dataset.interface.iloc(dataset, (rows, cols))
+         kdims = dataset.kdims
+         vdims = dataset.vdims
+         if np.isscalar(data):",Had to fix this to get my tests passing (should have been a new PR sorry).,please update the d
+7724,"@@ -91,6 +91,11 @@ type VaultIssuer struct {
+ 	Server string `json:""server""`
+ 	// Vault URL path to the certificate role
+ 	Path string `json:""path""`
++	// Base64 encoded CA bundle to validate Vault server certificate. Only used
++	// if the Server URL is using HTTPS protocol. This parameter is ignored for
++	// plain HTTP protocol connection. If not set the system root certificates
++	// are used to validate the TLS connection.
++	CABundle []byte `json:""caBundle""`
+ }
+
+ // Vault authentication  can be configured:","Small nit, and sorry for not spotting sooner.. this should have `omitempty` on it, else when marshalling nil values into json, it will be `caBundle: null` which trips up some JSON parsers",Can this just be a string? Should we make it a required field?
+7725,"@@ -1030,6 +1030,9 @@ class GenericLayoutPlot(GenericCompositePlot):
+     displays the elements in a cartesian grid in scanline order.
+     """"""
+
++    transpose = param.Boolean(default=False, doc=""""""
++        Whether to transpose the layout when plotting"""""")
++
+     def __init__(self, layout, **params):
+         if not isinstance(layout, (NdLayout, Layout)):
+             raise ValueError(""GenericLayoutPlot only accepts Layout objects."")","Would be good to say the normal behavior is scanline order (left to right, top to bottom) and that transposing makes it work top to bottom and left to right.",Might as well make this `True` by default and default to `Fals
+7726,"@@ -326,6 +326,17 @@ Photos folder"" option in your google drive settings. You can then copy
+ or move the photos locally and use the date the image was taken
+ (created) set as the modification date.`,
+ 			Advanced: true,
++		}, {
++			Name:    ""use_shared_date"",
++			Default: false,
++			Help: `Use date file was shared instead of modified date.
++
++Note that, as with ""--drive-use-created-date"", this flag may have
++unexpected consequences when uploading/downloading files.
++
++If both this flag and ""--drive-use-created-date"" are set, the created
++date is used.`,
++			Advanced: true,
+ 		}, {
+ 			Name:     ""list_chunk"",
+ 			Default:  1000,",Perhaps note here that `--drive-use-created-date` takes precedence if both set?,nit: change to `--drive-use-shared-date`
+7727,"@@ -128,7 +128,7 @@ class DynamicRoIHead(StandardRoIHead):
+         bbox_results.update(loss_bbox=loss_bbox)
+         return bbox_results
+
+-    def update_hyperparameters(self):
++    def update_hyperparameters(self, eps=1e-15):
+         """"""Update hyperparameters like IoU thresholds for assigner and beta for
+         SmoothL1 loss based on the training statistics.
+ ",Use EPS=1e-15 as that in atss_head or FCOS head.,what is the difference between 1e-15 and 1e-16?
+7728,"@@ -40,7 +40,7 @@ func TestBlobSaver(t *testing.T) {
+
+ 	tmb, ctx := tomb.WithContext(ctx)
+ 	saver := &saveFail{
+-		idx: repository.NewIndex(),
++		idx: repository.NewMasterIndex(),
+ 	}
+
+ 	b := NewBlobSaver(ctx, tmb, saver, uint(runtime.NumCPU()))",Is there a need to replace the Index with a MasterIndex?,why is this the problem?
+7729,"@@ -389,6 +389,7 @@ func TestExecCommandAgent(t *testing.T) {
+
+ 	verifyExecCmdAgentExpectedMounts(t, ctx, client, testTaskId, cid, testContainerName, testExecCmdHostBinDir)
+ 	pidA := verifyMockExecCommandAgentIsRunning(t, client, cid)
++	verifyExecAgentRunningStateChange(t, taskEngine)
+ 	seelog.Infof(""Verified mock ExecCommandAgent is running (pidA=%s)"", pidA)
+ 	killMockExecCommandAgent(t, client, cid, pidA)
+ 	seelog.Infof(""kill signal sent to ExecCommandAgent (pidA=%s)"", pidA)",are we adding stop state change in a different PR?,This is the only place w
+7730,"@@ -23,9 +23,9 @@ class PlansController < ApplicationController
+     # Get all of the available funders and non-funder orgs
+     @funders = Org.funder
+                   .joins(:templates)
+-                  .where(templates: { published: true }).uniq.sort(&:name)
++                  .where(templates: { published: true }).uniq.sort_by(&:name)
+     @orgs = (Org.organisation + Org.institution + Org.managing_orgs).flatten
+-                                                                    .uniq.sort(&:name)
++                                                                    .uniq.sort_by(&:name)
+
+     # Get the current user's org
+     @default_org = current_user.org if @orgs.include?(current_user.org)",How much difference is there between sort and sort_by ?,`uniq.sort_by` is the sa
+7731,"@@ -231,6 +231,7 @@ STATIC int opae_plugin_mgr_initialize_all(void)
+ 	int res;
+ 	opae_api_adapter_table *aptr;
+ 	int errors = 0;
++	int count = 0;
+
+ 	for (aptr = adapter_list; aptr; aptr = aptr->next) {
+ ",count doesn't seem to be used. Let's remove it.,Why not just use `++coun
+7732,"@@ -18,7 +18,11 @@ module Mongoid
+       #
+       # @since 4.0.0
+       def cache_table
+-        Thread.current[""[mongoid]:query_cache""] ||= {}
++        if defined?(Mongo::QueryCache)
++          Mongo::QueryCache.cache_table
++        else
++          Thread.current[""[mongoid]:query_cache""] ||= {}
++        end
+       end
+
+       # Clear the query cache.",Mongo is a hard dependency for Mongoid. Why do we need an if-statement to if it's defined? We should always use Mongo::QueryCache,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+7733,"@@ -0,0 +1,6 @@
++class AddFunderAndOrgToPlans < ActiveRecord::Migration
++  def change
++    add_reference :plans, :org, foreign_key: true
++    add_column :plans, :funder_id, :integer, index: true
++  end
++end","Does this point out at a ROR funder id? If so, could we get rid of the `funder_name` field on the plan and just use the `name` of the funder with id `funder_id`?",Rails/InverseOf: Specify an :inverse_of option.
+7734,"@@ -3,8 +3,12 @@ var assert = require('assert');
+ var fs = require('fs');
+
+ var flatbuffers = require('../js/flatbuffers').flatbuffers;
++global.flatbuffers = flatbuffers;
++
+ var MyGame = require(process.argv[2]).MyGame;
+
++var isTsTest = process.env.FB_TS_TEST ? true : false;
++
+ function main() {
+
+   // First, let's test reading a FlatBuffer generated by C++ code:","Use !! to cast to bool, rather than the ternary bool antipattern.",why not use process.env.FB_TS_TEST ?
+7735,"@@ -145,7 +145,7 @@ func (cmd CmdSnapshots) Execute(args []string) error {
+ 		tab.Rows = append(tab.Rows, []interface{}{sn.ID()[:plen/2], sn.Time.Format(TimeFormat), sn.Hostname, sn.Paths[0]})
+
+ 		if len(sn.Paths) > 1 {
+-			for _, path := range sn.Paths {
++			for _, path := range sn.Paths[1:] {
+ 				tab.Rows = append(tab.Rows, []interface{}{"""", """", """", path})
+ 			}
+ 		}",why is it in the list twice to begin with?,"I'm not sure if there's a better way to do this, but I'm open to suggestions."
+7736,"@@ -890,6 +890,10 @@ void Player::sendPing()
+ 			return;
+ 		}
+
++		if (pzLocked) {
++			return;
++		}
++
+ 		if (!g_creatureEvents->playerLogout(this)) {
+ 			return;
+ 		}",This way you will **never** be kicked while monsters are around you.,no need to check for pzLocked as it's not used anywhere
+7737,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,This import seems unused and should be removed.
+7738,"@@ -110,5 +110,5 @@ export default function ModulesList( { moduleSlugs } ) {
+ }
+
+ ModulesList.propTypes = {
+-	moduleSlug: PropTypes.arrayOf( PropTypes.string ).isRequired,
++	moduleSlugs: PropTypes.arrayOf( PropTypes.string ).isRequired,
+ };","This just fixes an unrelated prop type error, correct?",Is this a typo?
+7739,"@@ -1022,7 +1022,7 @@ func (fbo *folderBlockOps) updateWithDirtyEntriesLocked(ctx context.Context,
+ 	}
+
+ 	// Remove cached removals from the copy.
+-	for k := range dirCacheEntry.adds {
++	for k := range dirCacheEntry.dels {
+ 		_, ok := dblock.Children[k]
+ 		if !ok {
+ 			continue",This was a bug in KBFS-2071 -- oops.,Why did you swap `adds` and `dels`?
+7740,"@@ -82,9 +82,18 @@ type PaymentChannel struct {
+ 	// payer and payee upon initialization or extension
+ 	AgreedEol *types.BlockHeight `json:""agreed_eol""`
+
++	// Conditions are the set of conditions for redeeming or closing the payment
++	// channel
++	Conditions *types.Predicate `json:""conditions""`
++
+ 	// Eol is the actual expiration for the payment channel which can differ from
+ 	// AgreedEol when the payment channel is in dispute
+ 	Eol *types.BlockHeight `json:""eol""`
++
++	// Redeemed is a flag indicating whether or not Redeem has been called on the
++	// payment channel yet. This is necessary because AmountRedeemed can still be
++	// zero in the event of a zero-value voucher
++	Redeemed bool `json:""redeemed""`
+ }
+
+ // Actor provides a mechanism for off chain payments.",// Condition is a condition for ... Condition,This is not correct. AmountRedeemed can be zero value.
+7741,"@@ -207,6 +207,16 @@ describe ""National Capital Region proposals"" do
+       expect(current_path).to eq(""/proposals/#{work_order.proposal.id}"")
+     end
+
++    it ""does not resave unchanged requests"" do
++      visit ""/ncr/work_orders/#{work_order.id}/edit""
++      click_on 'Submit for approval'
++      visit ""/ncr/work_orders/#{work_order.id}/edit""
++      click_on 'Submit for approval'
++
++      expect(current_path).to eq(""/proposals/#{work_order.proposal.id}"")
++      expect(page).to have_content(""No changes were made to the request"")
++    end
++
+     it ""has a disabled field if first approval is done"" do
+       visit ""/ncr/work_orders/#{work_order.id}/edit""
+       expect(find(""[name=approver_email]"")[""disabled""]).to be_nil","Might be good to test that no emails were sent out, either. You should be able to use `deliveries` for this",Prefer single-quoted strings when you don't need strin
+7742,"@@ -80,7 +80,7 @@ public class Connection implements Closeable {
+       serialized.put(""sessionId"", sessionId);
+     }
+
+-    LOG.info(JSON.toJson(serialized.build()));
++    LOG.finest(JSON.toJson(serialized.build()));
+     socket.sendText(JSON.toJson(serialized.build()));
+
+     if (!command.getSendsResponse() ) {",Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier.,This is the only log message in this file that needs t
+7743,"@@ -17,6 +17,11 @@ namespace UpdateVendors
+ //------------------------------------------------------------------------------
+ "";
+
++        private static readonly List<string> FilesToSkip = new List<string>()
++        {
++            @""\Serilog\Events\LogEventLevel.cs"",
++        };
++
+         private static readonly string DownloadDirectory = Path.Combine(Environment.CurrentDirectory, ""downloads"");
+         private static string _vendorProjectDirectory;
+ ",Is this new list being consumed yet?,This is a little bit odd - why do we need this at all?
+7744,"@@ -18,18 +18,14 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""io""
+-	weakrand ""math/rand""
+ 	""net""
+ 	""net/http""
+ 	""strconv""
+-	""time""
+
+ 	""github.com/caddyserver/caddy/v2""
+ )
+
+ func init() {
+-	weakrand.Seed(time.Now().UnixNano())
+-
+ 	caddy.RegisterModule(tlsPlaceholderWrapper{})
+ }
+ ",moved to `errors.go` which is the only places `math/rand` is used in this package,why was this removed?
+7745,"@@ -3,8 +3,8 @@
+ namespace Shopsys\FrameworkBundle\Component\Error;
+
+ use AppKernel;
+-use Shopsys\Environment;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
++use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
+ use Shopsys\FrameworkBundle\Component\Router\DomainRouterFactory;
+ use Symfony\Component\Filesystem\Filesystem;
+ use Symfony\Component\HttpFoundation\Request;","This use is wrong, corrent is: `Shopsys\FrameworkBundle\Component\Environment` It is the same in classes below",It doesn't make sense
+7746,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression.",Why don't you use `fi
+7747,"@@ -323,11 +323,6 @@ func updateContainerMetadata(metadata *dockerapi.DockerContainerMetadata, contai
+ 		container.SetLabels(metadata.Labels)
+ 	}
+
+-	// Update Volume
+-	if metadata.Volumes != nil {
+-		task.UpdateMountPoints(container, metadata.Volumes)
+-	}
+-
+ 	// Set Exitcode if it's not set
+ 	if metadata.ExitCode != nil {
+ 		container.SetKnownExitCode(metadata.ExitCode)","For my understanding, why was this removed?",Why was this removed?
+7748,"@@ -36,14 +36,13 @@ namespace Nethermind.Runner
+         protected override (CommandLineApplication, Func<IConfigProvider>, Func<string>) BuildCommandLineApp()
+         {
+             string pluginsDirectory = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""plugins"");
+-            Console.WriteLine($""Loading plugins from: {pluginsDirectory}"");
+             if (Directory.Exists(pluginsDirectory))
+             {
+                 var plugins = Directory.GetFiles(pluginsDirectory, ""*.dll"");
+                 foreach (string plugin in plugins)
+                 {
+-                    Console.WriteLine($""Loading plugin {plugin} from {pluginsDirectory}"");
+                     string pluginName = plugin.Contains(""/"") ? plugin.Split(""/"").Last() : plugin.Split(""\\"").Last();
++                    Console.WriteLine($""Loading plugin: {pluginName}"");
+                     AssemblyLoadContext.Default.LoadFromAssemblyPath(plugin);
+                 }
+             }",the whole idea was to display information on the plugin directory in case it was missing - need to add if...else... and display the plugin dir if it is configured (non empty) but cannot be found,Did you mean to remove this?
+7749,"@@ -154,6 +154,11 @@ public class LoginActivity extends BaseActivity implements CustomTabActivityHelp
+             loginView.requestFocus();
+             return;
+         }
++        if (TextUtils.isEmpty(password)) {
++            Toast.makeText(this, getString(R.string.error_field_required), Toast.LENGTH_SHORT).show();
++            passwordView.requestFocus();
++            return;
++        }
+         if (!(password.length() >= 6)) {
+             passwordView.setError(getString(R.string.error_invalid_password));
+             passwordView.requestFocus();","Can you please set this as an error on the password view, rather than a toast, just to make sure that it is kept consistent. Check out a couple of lines below.",I think this text could be u
+7750,"@@ -114,7 +114,7 @@ func consumerConnectFlow(t *testing.T, tequilapi *tequilapi_client.Client, consu
+ 	})
+ 	assert.NoError(t, err)
+
+-	connectionStatus, err = tequilapi.Connect(consumerID, proposal.ProviderID, endpoints.ConnectOptions{true})
++	connectionStatus, err = tequilapi.Connect(consumerID, proposal.ProviderID, ""openvpn"", endpoints.ConnectOptions{true})
+ 	assert.NoError(t, err)
+
+ 	err = waitForCondition(func() (bool, error) {",Shouldn't we pass here a proposal too?,"I would suggest to move ""ope"
+7751,"@@ -85,5 +85,11 @@ def test_dupe_solid_repo_definition():
+         },
+     )
+
+-    with pytest.raises(DagsterInvalidDefinitionError):
++    with pytest.raises(DagsterInvalidDefinitionError) as exc_info:
+         repo.get_all_pipelines()
++
++    assert str(exc_info.value) == (
++        'You have defined two solids named ""same"" in repository ""error_repo"". '
++        'Solid names must be unique within a repository. The solid has been defined '
++        'in pipeline ""first"" and it has been defined again in pipeline ""second.""'
++    )","im not a huge fan of exact text match in these tests, not sure what a good solution is that solves the same problem","What do you mean by ""Solid n"
+7752,"@@ -182,6 +182,13 @@ func (s *server) setupRouting() {
+ 		})),
+ 	)
+
++	handle(""/stamps/topup/{id}/{amount}"", web.ChainHandlers(
++		s.gatewayModeForbidEndpointHandler,
++		web.FinalHandler(jsonhttp.MethodHandler{
++			""PATCH"": http.HandlerFunc(s.postageTopUpHandler),
++		})),
++	)
++
+ 	handle(""/stewardship/{address}"", jsonhttp.MethodHandler{
+ 		""PUT"": web.ChainHandlers(
+ 			s.gatewayModeForbidEndpointHandler,",this should _not_ be in the api. all postage APIs have moved to the debugAPI,"Ah, ok, I didn't know you could do that. It's great!"
+7753,"@@ -51,9 +51,13 @@ def _path_hash(path, transform, kwargs):
+     return digest_string(srcinfo)
+
+ def _is_internal_node(node):
+-    # at least one of an internal nodes children are dicts
+-    # some (group args) may not be dicts
+-    return any(isinstance(x, dict) for x in itervalues(node))
++    return not _is_leaf_node(node)
++
++def _is_leaf_node(node):
++    """"""
++    A leaf node either has no children or defines a `file` key
++    """"""
++    return not node or node.get(RESERVED['file'])
+
+ def _pythonize_name(name):
+     safename = re.sub('[^A-Za-z0-9]+', '_', name).strip('_')","Including both functions seems like overkill for this PR since only _is_internal_node is ever used. Keep them if you think they'll both be used in the future, but if not, the code will be easier to read if you collapse the logic into a single function.",A leaf node has no children or does not have a `file
+7754,"@@ -41,7 +41,7 @@ func GenerateTestCertificate(path string, certFileName string, keyFileName strin
+ 		SerialNumber:          big.NewInt(1234),
+ 		Subject: pkix.Name{
+ 			Country:      []string{""test""},
+-			Organization: []string{""testor""},
++			Organization: []string{""tester""},
+ 		},
+ 		DNSNames:    []string{""localhost""},
+ 		NotBefore:   time.Now(),",It seems that the two words mean the same thing.,"Maybe ""tester"" is a better name than ""testor""?"
+7755,"@@ -271,13 +271,13 @@ void RaftPart::start(std::vector<HostAddr>&& peers, bool asLearner) {
+
+     lastLogId_ = wal_->lastLogId();
+     lastLogTerm_ = wal_->lastLogTerm();
++    term_ = proposedTerm_ = lastLogTerm_;
+
+     // Set the quorum number
+     quorum_ = (peers.size() + 1) / 2;
+
+     auto logIdAndTerm = lastCommittedLogId();
+     committedLogId_ = logIdAndTerm.first;
+-    term_ = proposedTerm_ = logIdAndTerm.second;
+
+     if (lastLogId_ < committedLogId_) {
+         LOG(INFO) << idStr_ << ""Reset lastLogId "" << lastLogId_","Do we need to set lastLogTerm_ to committedLogTerm when `lastLogId_ < committedLogId_`, on line 286",Why do we need to assign `lastLogTerm_` here? Is it
+7756,"@@ -160,7 +160,8 @@ public class TestAllDictionaries extends LuceneTestCase {
+           try {
+             Dictionary dic = loadDictionary(aff);
+             totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
+-            totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
++            totalWords.addAndGet(
++                RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes));
+             System.out.println(aff + ""\t"" + memoryUsageSummary(dic));
+           } catch (Throwable e) {
+             failures.add(aff);","About ~7% memory usage increase on average, at most 512KB",I think this should be `totalWords.addAndGet(wordHash -> RamUsageTester.sizeOf(wordHash))`
+7757,"@@ -32,6 +32,11 @@ type Response struct {
+ type ResponseWriter interface {
+ 	io.Writer
+
++	// Options for the request/response that this ResponseWriter is attached to.
++	Options() Options
++	// TODO(abg) Options should not be attached to the ResponseWriter. Instead
++	// they should be part of the Handle interface.
++
+ 	// AddHeaders adds the given headers to the response. If called, this MUST
+ 	// be called before any invocation of Write().
+ 	//",Was this too big of a pain to do now?,Perhaps add a note here that Options should be part of the Handle interface.
+7758,"@@ -41,10 +41,10 @@ static train_result call_daal_kernel(const context_cpu& ctx,
+     const int64_t component_count = desc.get_component_count();
+
+     auto arr_data = row_accessor<const Float>{ data }.pull();
+-    array<Float> arr_eigvec{ column_count * component_count };
+-    array<Float> arr_eigval{ 1 * component_count };
+-    array<Float> arr_means{ 1 * component_count };
+-    array<Float> arr_vars{ 1 * component_count };
++    auto arr_eigvec = array<Float>::zeros(column_count * component_count);
++    auto arr_eigval = array<Float>::zeros(1 * component_count);
++    auto arr_means = array<Float>::zeros(1 * component_count);
++    auto arr_vars = array<Float>::zeros(1 * component_count);
+
+     // TODO: read-only access performed with deep copy of data since daal numeric tables are mutable.
+     // Need to create special immutable homogen table on daal interop side",Why need to spend time for initializing of array? when will we rewrite the contents anyway? This can take a lot of time in some algorithms. Especially if the filling is in sequential mode.,These changes are unrelated to the PR.
+7759,"@@ -0,0 +1,5 @@
++class AddResourcesToWorkshops < ActiveRecord::Migration
++  def change
++    add_column :workshops, :resources, :text, null: false, default: ''
++  end
++end","Can this be `null:false, default: ''` to avoid the nil vs blank issue?",Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolatio
+7760,"@@ -0,0 +1,19 @@
++# frozen_string_literal: true
++
++test_name ""Set root/Administrator password to a known value"" do
++  extend Beaker::HostPrebuiltSteps
++
++  hosts.each do |host|
++    case host['platform']
++    when /windows/
++      on host, ""passwd #{ENV['WINRM_USER']}"", stdin: ENV['WINRM_PASSWORD']
++    when /osx/
++      # Our VMs default to PermitRootLogin prohibit-password
++      on host, 'echo ""PermitRootLogin yes"" >> /etc/ssh/sshd_config' if ENV['SSH_USER'] == 'root'
++      on host, ""dscl . -passwd /Users/#{ENV['SSH_USER']}"", stdin: ENV['SSH_PASSWORD']
++    else
++      # Some platforms support --stdin, but repeating it seems to work everywhere
++      on host, ""passwd #{ENV['SSH_USER']}"", stdin: ""#{ENV['SSH_PASSWORD']}\n#{ENV['SSH_PASSWORD']}""
++    end
++  end
++end",Had to add this to get macOS to work.,Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+7761,"@@ -0,0 +1,13 @@
++package azkaban.container;
++
++import org.junit.Rule;
++import org.junit.rules.TemporaryFolder;
++
++
++public class FlowContainerTestBase {
++
++  @Rule
++  public TemporaryFolder temporaryFolder = new TemporaryFolder();
++
++
++}",What is the usage of this class?,Why not `new TemporaryFolder()`?
+7762,"@@ -144,7 +144,7 @@ public class DataFilesTable extends BaseMetadataTable {
+     @Override
+     public CloseableIterable<StructLike> rows() {
+       return CloseableIterable.transform(
+-          ManifestFiles.read(manifest, io).project(schema),
++          ManifestFiles.read(manifest, io, null, null).project(schema),
+           file -> (GenericDataFile) file);
+     }
+ ","Could we keep the original signatures as well, so we do not have to rewrite the method calls everywhere and add `null, null`? I think this could greatly reduce the changes needed in this patch",do we have a test case that would have failed before?
+7763,"@@ -706,6 +706,7 @@ func (tds *TrieDbState) updateTrieRoots(forward bool) ([]common.Hash, error) {
+ 				if len(v) > 0 {
+ 					//fmt.Printf(""Update storage trie addrHash %x, keyHash %x: %x\n"", addrHash, keyHash, v)
+ 					if forward {
++						_ = ClearTombstonesForNewStorage(tds.db, cKey)
+ 						tds.t.Update(cKey, v)
+ 					} else {
+ 						// If rewinding, it might not be possible to execute storage item update.",Ideally this error should not be swallowed (can do in the next PR),What is the error ignored here?
+7764,"@@ -212,9 +212,10 @@ def config():
+     global _registry_url
+     _registry_url = None
+
+-def _update_auth(team, refresh_token):
++def _update_auth(team, refresh_token, timeout=None):
+     response = requests.post(""%s/api/token"" % get_registry_url(team), data=dict(
+-        refresh_token=refresh_token
++        refresh_token=refresh_token,
++        timeout=timeout
+     ))
+
+     if response.status_code != requests.codes.ok:",Wait a minute... You're passing it as a POST parameter. There's no way that can work.,"can we give it a default value, so we don't have to pass `timeout` everywhere?"
+7765,"@@ -259,6 +259,7 @@ func (w *Workflow) cleanup() {
+ 			w.LogWorkflowInfo(""Error returned from cleanup hook: %s"", err)
+ 		}
+ 	}
++	w.LogWorkflowInfo(""Workflow %q finished clean up."", w.Name)
+ }
+
+ func (w *Workflow) genName(n string) string {","minor: to be consistent with other logs, either use ""cleaning up"" (preferred) or ""cleanup"".",Maybe add w.Name() to the log message?
+7766,"@@ -23,6 +23,7 @@ PG_ASYNC_LISTEN_COMMIT = False
+ # Redis
+ REDIS_HOST = ""redis""
+ REDIS_PORT = 6379
++REDIS_NAMESPACE = ""listenbrainz""
+
+ # Influx DB (main listen store)
+ INFLUX_HOST    = ""influx""",Adding the config changes to the consul config template `consul_config.py.ctmpl` would be helpful too.,Maybe rename to `REDIS_ROOT`?
+7767,"@@ -56,7 +56,7 @@ import org.hibernate.validator.constraints.NotEmpty;
+ public class Dataverse extends DvObjectContainer {
+
+     public enum DataverseType {
+-        RESEARCHERS, RESEARCH_PROJECTS, JOURNALS, ORGANIZATIONS_INSTITUTIONS, TEACHING_COURSES, UNCATEGORIZED
++        RESEARCHERS, RESEARCH_PROJECTS, JOURNALS, ORGANIZATIONS_INSTITUTIONS, TEACHING_COURSES, UNCATEGORIZED, LABORATORY, RESEARCH_GROUP
+     };
+
+     private static final long serialVersionUID = 1L;",While we're at it should we add Department? See Dataverse Category: Add Department #2829,You should add the `RESEARCH_GROUP` type here as well.
+7768,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.,"Unused method argument - username. If it's necessary, use _ or _username as an argument name to indicate that it won't be used."
+7769,"@@ -22,13 +22,14 @@ function detachedClone(vnode) {
+ 	if (vnode) {
+ 		vnode = assign({}, vnode);
+ 		vnode._component = null;
++		vnode._original = vnode;
+ 		vnode._children = vnode._children && vnode._children.map(detachedClone);
+ 	}
+ 	return vnode;
+ }
+
+ // having custom inheritance instead of a class here saves a lot of bytes
+-export function Suspense(props) {
++export function Suspense() {
+ 	// we do not call super here to golf some bytes...
+ 	this._pendingSuspensionCount = 0;
+ 	this._suspenders = null;",TODO: check whether this is needed or not,I think we should be able to remove `_original` if we are not using it.
+7770,"@@ -48,8 +48,12 @@ type Config struct {
+ 	Aliases  map[string]string `yaml:""aliases""`
+ }
+
+-// ReadConfig represents the current config read from local
+-var ReadConfig Config
++var (
++	// ReadConfig represents the current config read from local
++	ReadConfig Config
++	// IsInsecure represents the connect option of grpc dial
++	IsInsecure bool
++)
+
+ func init() {
+ 	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl/default""",`ReadConfig` is a global variable (from `gochecknoglobals`),Can we just make this `grpc.DialOptions` for consistency?
+7771,"@@ -12,6 +12,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ //
++//go:build !cgo
+ // +build !cgo
+
+ package ptrace",This is duplicated with `+build !cgo`?,Why is this line needed?
+7772,"@@ -34,7 +34,7 @@ module Selenium
+           driver.manage.timeouts.implicit_wait = 6
+
+           driver.find_element(id: 'adder').click
+-          driver.find_element(id: 'box0')
++          expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError)
+         end
+
+         it 'should still fail to find an element with implicit waits enabled' do",This should just be `.not_to raise_error` otherwise it potentially hides errors,`not_to raise_error` is the same as `not_to raise_error(WebDriver::Error::NoSuchElementError)`
+7773,"@@ -164,13 +164,17 @@ class DataFrame(_Frame):
+         else:
+             self._metadata = metadata
+
+-    def _reduce_for_stat_function(self, sfun):
++    def _reduce_for_stat_function(self, sfun, numeric_only=False):
+         """"""
+         Applies sfun to each column and returns a pd.Series where the number of rows equal the
+         number of columns.
+
+-        :param sfun: either an 1-arg function that takes a Column and returns a Column, or
++        Parameters
++        ----------
++        sfun : either an 1-arg function that takes a Column and returns a Column, or
+         a 2-arg function that takes a Column and its DataType and returns a Column.
++        numeric_only : boolean, default False
++            If True, sfun is applied on numeric columns (including booleans) only.
+         """"""
+         from inspect import signature
+         exprs = []",Line 175 needs to be indented so that it's under `sfun`.,I think you need to add `numeric_only` to the docstring.
+7774,"@@ -21,12 +21,16 @@ namespace Nethermind.Blockchain.Filters.Topics
+ {
+     public class AnyTopic : TopicExpression
+     {
+-        public static readonly AnyTopic Instance = new();
++        public static readonly AnyTopic Instance = new();
++
++        private AnyTopic() { }
+
+         public override bool Accepts(Keccak topic) => true;
+         public override bool Accepts(ref KeccakStructRef topic) => true;
+
+         public override bool Matches(Bloom bloom) => true;
+         public override bool Matches(ref BloomStructRef bloom) => true;
++
++        public override string ToString() => ""null"";
+     }
+ }",It looks strange a bit. What is the reason?,"Does this make any sense? Why is it ""null""?"
+7775,"@@ -9,13 +9,17 @@ import java.nio.file.Path;
+ import java.nio.file.PathMatcher;
+ import java.util.Optional;
+
+-import static com.github.javaparser.StaticJavaParser.parse;
++import static com.github.javaparser.StaticJavaParser.parse;import org.apache.log4j.Logger;
++
+
+ /**
+  * A strategy for discovering the structure of a project.
+  * Implementations could read a pom.xml, a Gradle build file, a makefile...
+  */
+-public interface CollectionStrategy {
++public interface CollectionStrategy {
++    protected static Logger LOG = Logger.getLogger(CollectionStrategy.class.getName());
++
++
+
+     ProjectRoot collect(Path path);
+ ",Is this one of those `LexicalPreservingPrinter` issues?,I don't think the log message should be protected.
+7776,"@@ -61,6 +61,12 @@ func prettify(v reflect.Value, indent int, buf *bytes.Buffer) {
+
+ 		buf.WriteString(""\n"" + strings.Repeat("" "", indent) + ""}"")
+ 	case reflect.Slice:
++		strtype := v.Type().String()
++		if strtype == ""[]uint8"" {
++			buf.WriteString(""<binary>"")
++			break
++		}
++
+ 		nl, id, id2 := """", """", """"
+ 		if v.Len() > 3 {
+ 			nl, id, id2 = ""\n"", strings.Repeat("" "", indent), strings.Repeat("" "", indent+2)",Can we also add the length of the slice here? Some like `<binary> len %d`,"This is a pretty subtle change in behavior. If you have a slice of `uint8[1]` and `uint8[1]` you'll get `[nil]` and `[0]` in the result. This will cause a panic. I think what you should do here is to convert the slice to a `[]byte` and then `if v.Type().String() != ""[]uint8""`."
+7777,"@@ -7,6 +7,8 @@
+ package block
+
+ import (
++	""github.com/iotexproject/iotex-core/pkg/log""
++	""go.uber.org/zap""
+ 	""google.golang.org/protobuf/proto""
+
+ 	""github.com/iotexproject/iotex-proto/golang/iotextypes""","move this line together to after line 16, group internal packages together",Please remove this new line.
+7778,"@@ -0,0 +1,12 @@
++class CreateFeedbacks < ActiveRecord::Migration
++  def change
++    create_table :feedbacks do |t|
++      t.integer :rating
++      t.integer :more_info
++      t.string :uuid
++      t.string :project_name
++
++      t.timestamps null: false
++    end
++  end
++end",How about using a reference(project_id) instead of project name,you could also add a foreign key to the `feedbacks` table like we do for the other tables
+7779,"@@ -133,12 +133,14 @@ var (
+ 		Explorer: Explorer{
+ 			Enabled:                 false,
+ 			IsTest:                  false,
++			UseRDS:					 false,
+ 			Port:                    14004,
+ 			TpsWindow:               10,
+ 			MaxTransferPayloadBytes: 1024,
+ 		},
+ 		Indexer: Indexer{
+ 			Enabled: false,
++			NodeAddr: """",
+ 		},
+ 		System: System{
+ 			HeartbeatInterval: 10 * time.Second,",File is not `gofmt`-ed with `-s`,"This is the node address, not the node address."
+7780,"@@ -235,6 +235,10 @@ public class FileDownloadServiceBean implements java.io.Serializable {
+                 dataFile = guestbookResponse.getDataFile();
+             }
+         }
++        //For tools to get the dataset and datasetversion ids, we need a full DataFile object (not a findCheapAndEasy() copy)
++        if(dataFile.getFileMetadata()==null) {
++            dataFile=datafileService.find(dataFile.getId());
++        }
+         ExternalToolHandler externalToolHandler = new ExternalToolHandler(externalTool, dataFile, apiToken);
+         // Back when we only had TwoRavens, the downloadType was always ""Explore"". Now we persist the name of the tool (i.e. ""TwoRavens"", ""Data Explorer"", etc.)
+         guestbookResponse.setDownloadtype(externalTool.getDisplayName());","@qqmyers this looks fine but have you seen any performance issue here? If so, we could right some helper method like doesExternalToolNeedDataset(externalTool). But if there's trivial performance impact, not worth it.",Please add a space between `dataFile` and `=`
+7781,"@@ -37,6 +37,8 @@
+ #define STATICBOXVERTICALSPACER 10
+ #define DAYOFWEEKBORDERSIZE 10
+
++bool usingLocalPrefs;
++
+ ///////////////////////////////////////////////////////////////////////////
+
+ // NOTE: On MS Windows with wxWidgets 3.0, controls inside a wxStaticBox ",Make this a member variable instead (move to header inside `class` and rename to `m_bUsingLocalPrefs`).,maybe add a `usingLocalPrefs = false;` at the
+7782,"@@ -110,7 +110,7 @@ describe('Transactions (spec)', function() {
+         afterEach(() => cleanupAfterSuite(testContext));
+
+         testSuite.tests.forEach(testData => {
+-          const maybeSkipIt = testData.skipReason ? it.skip : it;
++          const maybeSkipIt = testData.skipReason || testSuite.name === 'pin-mongos' ? it.skip : it;
+           maybeSkipIt(testData.description, function() {
+             let testPromise = Promise.resolve();
+ ","Generally I'd say we should factor this out into something more extensible (check an array of potentially skipped tests, for examples), but since we're likely to remove this soon for scheduled work I think this is fine. What do you think @daprahamian?",why is this needed?
+7783,"@@ -18,7 +18,7 @@ THE SOFTWARE.
+ */
+
+ /* HIT_START
+- * BUILD: %t %s ../../test_common.cpp NVCC_OPTIONS -std=c++11
++ * BUILD: %t %s ../../test_common.cpp NVCC_OPTIONS -std=c++11 EXCLUDE_HIP_PLATFORM clang
+  * TEST: %t
+  * HIT_END
+  */",Why are we skipping these tests? they should be passing in HIP-Clang.,I'm not sure if exclusion_hip_platform.cpp re
+7784,"@@ -279,9 +279,14 @@ class RandString(RandField):
+     def __mul__(self, n):
+         return self._fix()*n
+
+-class RandBin(RandString):
++class RandBin(RandString, object):
+     def __init__(self, size=None):
+-        RandString.__init__(self, size, """".join(map(chr, range(256))))
++        super(RandBin, self).__init__(size=size, chars=b"""".join(chb(c) for c in range(256)))
++    def _fix(self):
++        s = b""""
++        for _ in range(self.size):
++            s += chb(random.choice(self.chars))
++        return s
+
+
+ class RandTermString(RandString):","I think a ""string"" in Scapy's spirit (if such a thing exists) is actually a `bytes` object in Python 3 (see `Str*Field`s). So maybe `RandString._fix()` should return a `bytes` object. What do you think?",would `s = chb(self.chars) for _ in range(self.size)` work also?
+7785,"@@ -12,6 +12,8 @@
+
+ const path = require('path')
+ const fs = require('fs')
++const jsdom = require(""jsdom"");
++const { JSDOM } = jsdom;
+
+ const srcDir = path.resolve(path.join(__dirname, '..', 'src'))
+ ","This can be combined to 1 line, just tested, seems to work.",This should just be `require('./build-system/jsdom')`
+7786,"@@ -1404,6 +1404,16 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+         throw new IllegalStateException(
+             ""GoQuorum compatibility mode (enabled) can only be used if genesis file has 'isQuorum' flag set to true."");
+       }
++      genesisConfigOptions
++          .getChainId()
++          .ifPresent(chainId -> ensureGoQuorumCompatibilityModeNotUsedOnMainnet(chainId));
++    }
++  }
++
++  private void ensureGoQuorumCompatibilityModeNotUsedOnMainnet(final BigInteger chainId) {
++    if (chainId.equals(EthNetworkConfig.MAINNET_NETWORK_ID)) {
++      throw new IllegalStateException(
++          ""GoQuorum compatibility mode (enabled) cannot be used on Mainnet."");
+     }
+   }
+ ",what needs to happen if it is not present?,I'm wondering if this check should be more specific to the mainn
+7787,"@@ -88,6 +88,11 @@ func (e *deployExecutor) Execute(sig executor.StopSignal) model.StageStatus {
+ 		return model.StageStatus_STAGE_FAILURE
+ 	}
+
++	chartRepoName := e.deployCfg.Input.HelmChart.Repository
++	if chartRepoName != """" {
++		e.deployCfg.Input.HelmChart.Insecure = ds.DeploymentConfig.PipedSpec.IsInsecureChartRepository(chartRepoName)
++	}
++
+ 	e.provider = provider.NewProvider(e.Deployment.ApplicationName, ds.AppDir, ds.RepoDir, e.Deployment.GitPath.ConfigFilename, e.deployCfg.Input, e.Logger)
+ 	e.Logger.Info(""start executing kubernetes stage"",
+ 		zap.String(""stage-name"", e.Stage.Name),","`DeploymentConfig` is only for deployment configuration not Piped configuration so `ds.DeploymentConfig.PipedSpec` is always nil. Instead of that, you can have Piped config with `e.PipedConfig` because it is placing inside `executor.Input`.",Can we move this logic into the `NewController` so that it is on
+7788,"@@ -1,6 +1,12 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to set the access control list (ACL) on an
++# object in an Amazon Simple Storage Solution (Amazon S3) bucket for the given owner.
++
++# snippet-start:[s3.s3_set_bucket_object_acls.rb]
++
+ require 'aws-sdk-s3'
+
+ # Sets the access control list (ACL) on an object in an Amazon S3",Simple Storage **Service**,Trailing whitespace detected.
+7789,"@@ -35,8 +35,13 @@ namespace OpenTelemetry.Instrumentation.AspNet
+         });
+
+         /// <summary>
+-        /// Gets or sets a hook to exclude calls based on domain or other per-request criterion.
++        /// Gets or sets a Filter function to filter instrumentation for requests on a per request basis.
++        /// The functions gets the HttpContext, and should return a boolean.
++        /// If functions returns true, the request is collected.
++        /// If functions returns false, the request is filtered out.
++        /// If filter throws exception, then this is considered as no filter being configured.
++        /// and requested is collected.
+         /// </summary>
+-        internal Predicate<HttpContext> RequestFilter { get; set; }
++        public Func<HttpContext, bool> Filter { get; set; }
+     }
+ }",This line doesn't seem to be right?,"Since this is a lambda, you s"
+7790,"@@ -271,6 +271,7 @@ func (c *CVCController) createVolumeOperation(cvc *apis.CStorVolumeClaim) (*apis
+ 	// update the cstorvolume reference, phase as ""Bound"" and desired
+ 	// capacity
+ 	cvc.Spec.CStorVolumeRef = volumeRef
++	cvc.Spec.Policy = volumePolicy.Spec
+ 	cvc.Status.Phase = apis.CStorVolumeClaimPhaseBound
+ 	cvc.Status.Capacity = cvc.Spec.Capacity
+ ",this need to be moved up after getting policy..,why do we need to set the pol
+7791,"@@ -1363,7 +1363,7 @@ data:
+     # GCP Specific
+     - name: GCPInvalidProjectID
+       searchRegexStrings:
+-      - ""platform\.gcp\.project.* invalid project ID""
++      - ""platform.gcp.project.* invalid project ID""
+       installFailingReason: GCPInvalidProjectID
+       installFailingMessage: Invalid GCP project ID
+     - name: GCPInstanceTypeNotFound",I'm curious - is there a way to test these?,Did you mean to also update t
+7792,"@@ -59,10 +59,10 @@ public class MetadataTableUtils {
+   }
+
+   public static Table createMetadataTableInstance(TableOperations originTableOps,
++                                                  String catalogName,
+                                                   TableIdentifier originTableIdentifier,
+                                                   MetadataTableType type) {
+-    return createMetadataTableInstance(originTableOps,
+-        BaseMetastoreCatalog.fullTableName(type.name(), originTableIdentifier),
+-        type);
++    String fullTableName = BaseMetastoreCatalog.fullTableName(catalogName, originTableIdentifier);
++    return createMetadataTableInstance(originTableOps, fullTableName, type);
+   }
+ }","This was broken before as the name of the metadata table started with its type, not catalog.",I think this should be catalogName not catalogName
+7793,"@@ -173,6 +173,7 @@ func (di *Dependencies) Bootstrap(nodeOptions node.Options) error {
+ 	nats_discovery.Bootstrap()
+
+ 	log.Infof(""Starting Mysterium Node (%s)"", metadata.VersionAsString())
++	log.Infof(""Build information (%s)"", metadata.BuildAsString())
+
+ 	if err := nodeOptions.Directories.Check(); err != nil {
+ 		return err","Maybe remake `VersionAsString()` function, so that that we would have build info in all places",Will this be shown to the end user?
+7794,"@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
+   close();
+ }
+
++bool TSSLSocket::hasPendingDataToRead() {
++  if (!isOpen()) {
++    return false;
++  }
++  initializeHandshake();
++  if (!checkHandshake())
++    throw TSSLException(""SSL_peek: Handshake is not completed"");
++  // data may be available in SSL buffers (note: SSL_pending does not have a failure mode)
++  return TSocket::hasPendingDataToRead() || SSL_pending(ssl_) > 0;
++}
++
+ void TSSLSocket::init() {
+   handshakeCompleted_ = false;
+   readRetryCount_ = 0;",This should probably say something other than SSL_peek?,Wouldn't this be more appropriate as a check for `
+7795,"@@ -1,7 +1,7 @@
+ /**
+- * Search Console module initialization.
++ * Search console module initialization.
+  *
+- * Site Kit by Google, Copyright 2019 Google LLC
++ * Site Kit by Google, Copyright 2020 Google LLC
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.","Nitpicking, but this should be capitalized since it's a product name :)",Could you revert the changes to this file as well?
+7796,"@@ -94,6 +94,16 @@ type TransactionMisc struct {
+ 	from atomic.Value
+ }
+
++type RawTransactions [][]byte
++
++func (t RawTransactions) Len() int {
++	return len(t)
++}
++
++func (t RawTransactions) EncodeIndex(i int, w *bytes.Buffer) {
++	w.Write(t[i])
++}
++
+ func (tm TransactionMisc) Time() time.Time {
+ 	return tm.time
+ }",Why do we need RawTransactions?,Make this a `map[int]struct{}` for efficiency.
+7797,"@@ -37,6 +37,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ 	""github.com/iotexproject/iotex-core/protogen/iotextypes""
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ )
+
+ var (",File is not `gofmt`-ed with `-s` (from `gofmt`),Could you move that line down with the other I
+7798,"@@ -632,7 +632,14 @@ public class NSClientService extends Service {
+                                         if (sgv.getMills() > latestDateInReceivedData)
+                                             latestDateInReceivedData = sgv.getMills();
+                                 }
+-                                BroadcastSgvs.handleNewSgv(sgvs, MainApp.instance().getApplicationContext(), isDelta);
++                                // Was that sgv more than 15 mins ago ?
++                                boolean moreThan15MinAgo = false;
++                                if((System.currentTimeMillis()-latestDateInReceivedData)/(60 * 1000L) < 15L )
++                                    moreThan15MinAgo = true;
++                                if(Notification.isAlarmForStaleData() && moreThan15MinAgo){
++                                    MainApp.bus().post(new EventDismissNotification(Notification.NSALARM));
++                                }
++                                BroadcastSgvs.handleNewSgv(sgvs, MainApp.instance().getApplicationContext(), isDelta);
+                             }
+                             MainApp.bus().post(new EventNSClientNewLog(""LAST"", DateUtil.dateAndTimeString(latestDateInReceivedData)));
+                         } catch (JSONException e) {",should not be this lessThan15MinAgo ?,I'm not sure if this is the right way to check
+7799,"@@ -1192,6 +1192,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+
+                 return RequestLineStatus.Done;
+             }
++            catch (DecodingException)
++            {
++                RejectRequest(RequestRejectionReason.NonAsciiOrNullCharactersInRequestLine,
++                    Log.IsEnabled(LogLevel.Information) ? start.GetAsciiStringEscaped(end, MaxInvalidRequestLineChars) : string.Empty);
++                // won't run but compiler complains
++                return RequestLineStatus.Done;
++            }
+             finally
+             {
+                 input.ConsumingComplete(consumed, end);",Would it work if we changed the return type of 'RejectRequest*' methods to Exception and instead did `throw RejectRequest(...` ?,"I think this is a bit too specific, can we not"
+7800,"@@ -387,7 +387,7 @@ import browser from './browser';
+             videoAudioCodecs.push('mp2');
+         }
+
+-        let supportsDts = browser.tizen || browser.web0s || options.supportsDts || videoTestElement.canPlayType('video/mp4; codecs=""dts-""').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=""dts+""').replace(/no/, '');
++        let supportsDts = browser.tizen || videoTestElement.canPlayType('video/mp4; codecs=""dts-""').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=""dts+""').replace(/no/, '');
+
+         // DTS audio not supported in 2018 models (Tizen 4.0)
+         if (browser.tizenVersion >= 4) {","It is not a ""perfect"" test, but: webOS 1.2 emulator says `probably`. webOS 3 emulator says \``. webOS 4 emulator says \``. Why did you remove `options.supportsDts`?",This is the only real change in this file. the rest of the changes are from this PR.
+7801,"@@ -152,6 +152,8 @@ hipError_t ihipEnablePeerAccess(hipCtx_t peerCtx, unsigned int flags) {
+ //---
+ hipError_t hipMemcpyPeer(void* dst, hipCtx_t dstCtx, const void* src, hipCtx_t srcCtx,
+                          size_t sizeBytes) {
++    if(dstCtx == srcCtx) return hipErrorInvalidValue;
++
+     HIP_INIT_API(NONE, dst, dstCtx, src, srcCtx, sizeBytes);
+
+     // TODO - move to ihip memory copy implementaion.",This check should be after the HIP_INIT_API to ensure HIP tracing & lazy init works correctly. Also return should be wrapped in ihipLogStatus() so that logging works correctly.,Shouldn't this be `if (dstCtx == srcCtx) return hipErrorInvalidValue;`?
+7802,"@@ -54,7 +54,14 @@ class ReIndexTask extends AbstractTask
+      *
+      * @var array
+      */
+-    protected $indexingConfigurationsToReIndex = array();
++    protected $indexingConfigurationsToReIndex = [];
++
++    /**
++     * Clear Index for selected sites and record types
++     *
++     * @var boolean
++     */
++    protected $clearSearchIndex = false;
+
+
+     /**",Can't use short array syntax for the 3.1 release branch.,Shouldn't this be set to true by default?
+7803,"@@ -2103,7 +2103,8 @@ static pmix_status_t server_switchyard(pmix_peer_t *peer, uint32_t tag,
+         PMIX_ERROR_LOG(rc);
+         return rc;
+     }
+-    pmix_output_verbose(2, pmix_globals.debug_output,
++   // pmix_output_verbose(2, pmix_globals.debug_output,
++                        pmix_output(0,
+                         ""recvd pmix cmd %d from %s:%u"",
+                         cmd, peer->info->pname.nspace, peer->info->pname.rank);
+ ",@rhc54 Is this intentional or for debug purposes?,"why not directly use pmix_output(2, ...) here ?"
+7804,"@@ -12,7 +12,14 @@ def includeme(config):
+     # Activate end-points.
+     config.scan('kinto.plugins.history.views')
+
++    # If StatsD is enabled, monitor execution time of listener.
++    if config.registry.statsd:
++        key = 'listeners.history'
++        listener = config.registry.statsd.timer(key)(on_resource_changed)
++    else:
++        listener = on_resource_changed
++
+     # Listen to every resources (except history)
+-    config.add_subscriber(on_resource_changed, ResourceChanged,
++    config.add_subscriber(listener, ResourceChanged,
+                           for_resources=('bucket', 'group',
+                                          'collection', 'record'))","Maybe it should be `plugins.history` here instead of `listeners.X`, since we use those for listeners configured via `.ini` files?","Is there a reason for capturing `on_resource_changed` here, but not `resource_changed`?"
+7805,"@@ -6,6 +6,10 @@ module TeamPlansHelper
+     end
+   end
+
++  def team_page?
++    @team_page.present?
++  end
++
+   private
+
+   def team_plan_quantity_select_attributes(plan)","Hmm, I also don't have a better idea here. As a small thing, could you make this `@team_page.present?` or similar to make the intent slightly more clear?",Maybe rename this to `team_page?`
+7806,"@@ -45,7 +45,12 @@ public class DecrypterInputStream extends InputStream implements WatchableStream
+
+     public DecrypterInputStream(FileInputStream inputStream, String encryptionKey)
+             throws GeneralSecurityException, IOException {
++        // First byte should be iv length
+         int ivLength = inputStream.read();
++        if (ivLength != 16 && ivLength != 32) {
++            throw new IOException(""Can't decrypt file: incorrect iv length found in file: "" + ivLength);
++        }
++        // Next bytes should be iv
+         byte[] iv = new byte[ivLength];
+         inputStream.read(iv);
+         Cipher cipher = Encryptor.getDecryptingCipher(encryptionKey, iv);",Without that check it would fail later (probably in the getDecryptingCipher method) but the error could be hard to make sense of.,"If the file does not contain the correct length, the exception message will not be corr"
+7807,"@@ -379,6 +379,13 @@ module Beaker
+       return result
+     end
+
++    def do_take_snapshot snapshot_name
++      self[:hypervisor].take_snapshot(name, snapshot_name)
++    end
++
++    def do_restore_snapshot snapshot_name
++      self[:hypervisor].restore_snapshot(name, snapshot_name)
++    end
+   end
+
+   [ 'windows', 'unix', 'aix', 'mac' ].each do |lib|",I don't think that this belongs in the host code. A host is pretty much unaware of what hypervisor is running it and I don't want them to be so coupled to their hypervisor.,would it make sense to call this do_take_snapshot_name to match the other do_* methods?
+7808,"@@ -23,5 +23,6 @@ import setuptools
+ setuptools.setup(
+     packages=setuptools.find_packages(),
+     pbr=True,
+-    setup_requires=['pbr']
++    setup_requires=['pbr', 'setuptools>=12']
++    # setuptools due https://github.com/ansible/molecule/issues/1859
+ )",I'm here to tell you that this doesn't make sense because of the way it works. `setuptools.setup()` installs this only for setup-time and then discards those. But the problem is that it will not pick up a newer version because the older version is already in runtime and module cannot substitute itself. The proper place for adding build deps nowadays is `pyproject.toml`->`[build-system]`->`requires'.,Might as well remove this whole `setup_requires` thing completely.
+7809,"@@ -34,7 +34,7 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ )
+
+-type fakeManager struct {
++type fakeConnectionManager struct {
+ 	onConnectReturn      error
+ 	onDisconnectReturn   error
+ 	onStatusReturn       connection.Status",fakeConnectionManager -> mockConnectionManager. We probably should not use the `fake` anymore.,struct field fakeConnectionManager should be fakeConnectionManager
+7810,"@@ -364,6 +364,7 @@ class JUnitTester(AbstractTestRunner):
+         self.base_class_path = [self.selenium_server_jar_path, self.junit_path, self.junit_listener_path,
+                                 self.hamcrest_path, self.json_jar_path]
+         self.base_class_path.extend(self.scenario.get(""additional-classpath"", []))
++        self.base_class_path=[os.path.abspath(x) for x in self.base_class_path]
+
+     def prepare(self):
+         """"""","Code style. Btw, it's weird Codacy didn't catch that.","`self.base_class_path.extend(self.scenario.get(""additional-classpa"
+7811,"@@ -72,6 +72,14 @@ func (m *EthAddress) UnmarshalYAML(unmarshal func(interface{}) error) error {
+ 	return nil
+ }
+
++func (m *EthAddress) IsZero() bool {
++	return NewBigInt(m.Unwrap().Big()).IsZero()
++}
++
++func NewEthAddress(addr common.Address) *EthAddress {
++	return &EthAddress{Address: addr.Bytes()}
++}
++
+ func (m *DataSize) Unwrap() datasize.ByteSize {
+ 	return datasize.NewByteSize(m.Bytes)
+ }",no need in BigInt just m.Unwrap().Big().Bitlen() == 0,Why not just have a `NewEthAddress(addr common.Address)`?
+7812,"@@ -197,7 +197,7 @@ func (ctx *conjMatchFlowContext) installOrUpdateFlow(actions []*conjunctiveActio
+ 		// Build the Openflow entry. actions here should not be empty for either add or update case.
+ 		flow := ctx.client.conjunctiveMatchFlow(ctx.tableID, ctx.matchKey, ctx.matchValue, actions...)
+
+-		if err := flow.Add(); err != nil {
++		if err := ctx.client.flowOperations.Add(flow); err != nil {
+ 			return err
+ 		}
+ 		ctx.flow = flow",I assume you want to change NetworkPolicy to use bundles in a separate PR later?,Should we use `ctx.flowOperations.Add(flow)` instead?
+7813,"@@ -77,7 +77,7 @@ MARKER_FILE_LIGHT_VERSION = ""%s/.light-version"" % dirs.static_libs
+ IMAGE_NAME_SFN_LOCAL = ""amazon/aws-stepfunctions-local""
+ ARTIFACTS_REPO = ""https://github.com/localstack/localstack-artifacts""
+ SFN_PATCH_URL_PREFIX = (
+-    f""{ARTIFACTS_REPO}/raw/047cc6dcd2e31f5ff3ec52d293c61b875f606958/stepfunctions-local-patch""
++    f""{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunctions-local-patch""
+ )
+ SFN_PATCH_CLASS1 = ""com/amazonaws/stepfunctions/local/runtime/Config.class""
+ SFN_PATCH_CLASS2 = (","nit: We could parameterize the commit hash, as it's used in multiple places.",Could we update this to be `SFN_PATCH_CLASS1` and `SF
+7814,"@@ -2,6 +2,7 @@
+ // Licensed under the MIT License. See License.txt in the project root for license information.
+
+ var Constants = require('./constants');
++var _ = require('underscore');
+
+ /**
+ * Checks if a parsed URL is HTTPS","move this above the ""Constants"" as this is 3rd party ones",we don't use underscore in our code base. Please remo
+7815,"@@ -12,10 +12,16 @@ class AuthenticationPoliciesTest(BaseWebTest, unittest.TestCase):
+
+     def test_basic_auth_is_accepted_by_default(self):
+         self.app.get(self.collection_url, headers=self.headers, status=200)
++        # Check that the capability is exposed on the homepage.
++        resp = self.app.get('/')
++        assert 'basicauth' in resp.json['capabilities']
+
+     def test_basic_auth_is_accepted_if_enabled_in_settings(self):
+         app = self.make_app({'multiauth.policies': 'basicauth'})
+         app.get(self.collection_url, headers=self.headers, status=200)
++        # Check that the capability is exposed on the homepage.
++        resp = self.app.get('/')
++        assert 'basicauth' in resp.json['capabilities']
+
+     def test_basic_auth_is_declined_if_disabled_in_settings(self):
+         app = self.make_app({",`assert not in`,Can we check that `response.status` is 400 instead?
+7816,"@@ -310,13 +310,15 @@ func (engine *DockerTaskEngine) monitorExecAgentRunning(ctx context.Context,
+ 	// to finish monitoring.
+ 	// This is inspired from containers streaming stats from Docker.
+ 	time.Sleep(retry.AddJitter(time.Nanosecond, engine.monitorExecAgentsInterval/2))
+-	_, err = engine.execCmdMgr.RestartAgentIfStopped(ctx, engine.client, task, c, dockerID)
++	status, err := engine.execCmdMgr.RestartAgentIfStopped(ctx, engine.client, task, c, dockerID)
+ 	if err != nil {
+ 		seelog.Errorf(""Task engine [%s]: Failed to restart ExecCommandAgent Process for container [%s]: %v"", task.Arn, dockerID, err)
++		mTask.emitContainerEvent(mTask.Task, c, """")
+ 	}
+-	// whether we restarted or failed to restart, we'll want to emit a state change event
+-	// redundant state change events like RUNNING->RUNNING are allowed
+-	mTask.emitContainerEvent(mTask.Task, c, """")
++	if status == execcmd.Restarted {
++		mTask.emitContainerEvent(mTask.Task, c, """")
++	}
++
+ }
+
+ // MustInit blocks and retries until an engine can be initialized.","just curious, why was this modified?",We should only emit a state change event if the task is in RUNNING->RUNNING state. There's no need to emit a container event if the task is in RUNNING
+7817,"@@ -1302,6 +1302,7 @@ void ComTdbExeUtilFastDelete::displayContents(Space * space,
+ ComTdbExeUtilHiveTruncate::ComTdbExeUtilHiveTruncate(
+      char * tableName,
+      ULng32 tableNameLen,
++     char * hiveTableName,
+      char * tableLocation,
+      char * partnLocation,
+      char * hostName,",I'm curious why the table name is bound at compile time? Is it just to save the table create/drop overhead in a prepare-once-execute-many situation?,Can you just pass a `char *` instead of a `char *`?
+7818,"@@ -58,10 +58,6 @@ public class ProcessJob extends AbstractProcessJob {
+   public ProcessJob(final String jobId, final Props sysProps,
+       final Props jobProps, final Logger log) {
+     super(jobId, sysProps, jobProps, log);
+-
+-    // this is in line with what other job types (hadoopJava, spark, pig, hive)
+-    // is doing
+-    jobProps.put(CommonJobProperties.JOB_ID, jobId);
+   }
+
+   @Override","quick question, isn't ProcessJob used by all job types? Then why is JOB_ID not found?",@vinothchandar this was part of the problem that `ProcessJob` did not have the `jobId` in its props.
+7819,"@@ -264,6 +264,15 @@ public class AccountSettings {
+         s.put(""trashFolderSelection"", Settings.versions(
+                 new V(54, new EnumSetting<>(SpecialFolderSelection.class, SpecialFolderSelection.AUTOMATIC))
+         ));
++        s.put(""resize_image_enabled"", Settings.versions(
++                new V(55, new BooleanSetting(Account.DEFAULT_RESIZE_IMAGE_ENABLED))
++        ));
++        s.put(""resize_image_circumference"", Settings.versions(
++                new V(55, new StringSetting(Integer.toString(Account.DEFAULT_RESIZE_IMAGE_CIRCUMFERENCE)))
++        ));
++        s.put(""resize_image_quality"", Settings.versions(
++                new V(55, new StringSetting(Integer.toString(Account.DEFAULT_RESIZE_IMAGE_QUALITY)))
++        ));
+         // note that there is no setting for openPgpProvider, because this will have to be set up together
+         // with the actual provider after import anyways.
+ ",looks like you forgot to actually increase the version,no `new BooleanSetting(Account.DEFAULT_RESIZE_IMAGE_ENABLED)` ?
+7820,"@@ -43,5 +43,13 @@ namespace OpenTelemetry.Instrumentation.AspNet
+         /// The type of this object depends on the event, which is given by the above parameter.</para>
+         /// </remarks>
+         public Action<Activity, string, object> Enrich { get; set; }
++
++        /// <summary>
++        /// Gets or sets a value indicating whether to record http server attributes or not.
++        /// </summary>
++        /// <remarks>
++        /// https://github.com/open-telemetry/opentelemetry-specification/blob/a2758014f408f64ff84728918d671ee3fdab2225/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions.
++        /// </remarks>
++        public bool RecordHttpServerAttributes { get; set; }
+     }
+ }",I think it might be helpful if we add `Default value: False.` on the end of the summary.,"Is this a property that we want to be able to toggle? Would it make sense to make this an enum property, and make it a property of the object?"
+7821,"@@ -80,7 +80,7 @@ module.exports = function(realmConstructor) {
+             // result in sync rejecting the writes. `_waitForDownload` ensures that the session is kept
+             // alive until our callback has returned, which prevents it from being torn down and recreated
+             // when we close the schemaless Realm and open it with the correct schema.
+-            if (!config.sync.fullSynchronization && config.schema === undefined) {
++            if (config.sync.fullSynchronized !== undefined && !config.sync.fullSynchronization && config.schema === undefined) {
+                 throw new Error('Query-based sync requires a schema.');
+             }
+             let syncSession;",I think the check should be `config.sync.fullSynchronization === false` - otherwise this will get triggered even when full sync is `true`.,"`config.sync.fullSynchronized` has a default of `false`, so this check can be simplified to `!config.sync.fullSynchronized`"
+7822,"@@ -924,8 +924,11 @@ func (a *WebAPI) GenerateApplicationSealedSecret(ctx context.Context, req *webse
+ 		return nil, err
+ 	}
+
+-	sse := piped.SealedSecretEncryption
+-	if sse == nil {
++	se := piped.SecretEncryption
++	if se == nil {
++		se = piped.SealedSecretEncryption
++	}
++	if se == nil {
+ 		return nil, status.Error(codes.FailedPrecondition, ""The piped does not contain the encryption configuration"")
+ 	}
+ ",this blown my mind  ,"Same as above, I think this error message should be updated"
+7823,"@@ -335,6 +335,10 @@ type MayaAPIServiceOutputLabel string
+ const (
+ 	ReplicaStatusAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/replica-status""
+
++	//ReplicaContainerStatus MayaAPIServiceOutputLabel = ""vsm.openebs.io/replica-cont-status""
++
++	ControllerContainerStatus MayaAPIServiceOutputLabel = ""vsm.openebs.io/container-status""
++
+ 	ControllerStatusAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/controller-status""
+
+ 	TargetPortalsAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/targetportals""",this should be controller-container-status,Please remove this line.
+7824,"@@ -16,10 +16,12 @@
+
+ package azkaban.scheduler;
+
++import azkaban.utils.Utils;
+ import java.util.ArrayList;
+ import java.util.HashMap;
+ import java.util.List;
+ import java.util.Map;
++import java.util.Date;
+
+ import org.joda.time.DateTime;
+ import org.joda.time.DateTimeZone;",Sort import. You can use IDE's organize import feature.,Seems like an unused import.
+7825,"@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver;
+ import org.openqa.selenium.WebElement;
+
+ import java.io.IOException;
++import java.io.UncheckedIOException;
+ import java.net.URL;
+ import java.nio.charset.StandardCharsets;
+ import java.util.ArrayList;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,Need to remove this unused i
+7826,"@@ -16,6 +16,7 @@ import (
+ )
+
+ func TestMiningPledgeSector(t *testing.T) {
++	t.Skip(""Unskip when we have implemented production drand component and local drand network for functional tests"")
+ 	tf.FunctionalTest(t)
+
+ 	ctx, cancel := context.WithCancel(context.Background())",This PR is off to a rough start. :),I think we should implement
+7827,"@@ -380,7 +380,7 @@ function normalizeProxyConfiguration(config) {
+     }
+   } else if ('pac' === config.proxyType) {
+     if (config.proxyAutoconfigUrl && !config.pacUrl) {
+-      config.pacUrl = config.proxyAutoconfigUrl;
++      config.proxyAutoconfigUrl = config.proxyAutoconfigUrl;
+     }
+   }
+   return config;","Actually, it looks like the entire `normalizeProxyConfiguration` function isn't needed anymore",pacUrl condition is removed
+7828,"@@ -32,6 +32,8 @@
+   </div>
+ </div>
+
+-<ul id='breadcrumb-nav'>
+-  <li><%= link_to ""Back to main portal"", carts_path %></li>
+-</ul>
++<%- unless excluded_portal_link %>
++  <ul id='breadcrumb-nav'>
++    <li><%= link_to ""Back to main portal"", carts_path %></li>
++  </ul>
++<%- end %>",How about `unless current_path == carts_path`?,Can you explain why this is needed?
+7829,"@@ -63,7 +63,7 @@
+ # Copyright (c) 2021 Lorena B <46202743+lorena-b@users.noreply.github.com>
+ # Copyright (c) 2021 David Liu <david@cs.toronto.edu>
+ # Copyright (c) 2021 Andreas Finkler <andi.finkler@gmail.com>
+-# Copyright (c) 2021 Or Bahari <orbahari@mail.tau.ac.il>
++# Copyright (c) 2021-2022 Or Bahari <or.ba402@gmail.com>
+
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE",You need to modify the copyrite aliases so it's done automatically.,Please don't update existing copyri
+7830,"@@ -174,6 +174,13 @@ function createElement(...args) {
+
+ 	let type = vnode.type, props = vnode.props;
+ 	if (typeof type!='function') {
++		Object.keys(props).forEach(key => {
++			if (/^on(Ani|Tra)/.test(key)) {
++				props[key.toLowerCase()] = props[key];
++				delete props[key];
++			}
++		});
++
+ 		if (props.defaultValue) {
+ 			if (!props.value && props.value!==0) {
+ 				props.value = props.defaultValue;",Quick question: Is this true for all `onAnimation*` and all `onTransition*` events?,Do we need to `toLowerCase` on `pro
+7831,"@@ -59,6 +59,8 @@ function Address(data, network, type) {
+     info = Address._transformPublicKey(data);
+   } else if (data.constructor && (data.constructor.name && data.constructor.name === 'Script')) {
+     info = Address._transformScript(data);
++  } else if (data instanceof Address) {
++    return data;
+   } else if (typeof(data) === 'string') {
+     info = Address._transformString(data, network, type);
+   } else {","Should sending an address into address error? Since the call isn't needed, and could be fixed easily.",Is this correct? Why would we want
+7832,"@@ -26,6 +26,7 @@ import java.util.List;
+ import java.util.Map;
+ import java.util.TreeMap;
+
++import org.apache.log4j.MDC;
+ import org.apache.lucene.index.MultiTerms;
+ import org.apache.lucene.index.Terms;
+ import org.apache.lucene.index.TermsEnum;",This is the wrong MDC; see MDCLoggingContext which imports `org.slf4j.MDC`,wrong import order
+7833,"@@ -127,6 +127,9 @@ public interface HistoricDetailQuery extends Query<HistoricDetailQuery, Historic
+   /** Only select historic details that have occurred after the given date (inclusive). */
+   HistoricDetailQuery occurredAfter(Date date);
+
++  /** Only select historic details that were set during the process start. */
++  HistoricDetailQuery initial();
++
+   /**
+    * Order by tenant id (needs to be followed by {@link #asc()} or {@link #desc()}).
+    * Note that the ordering of historic details without tenant id is database-specific.",Maybe we can clarify a bit what that means.,why not set it at
+7834,"@@ -94,7 +94,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+                 {
+                     tcs2.SetResult(task2.Result);
+                 }
+-            }, tcs);
++            }, tcs, cancellationToken);
+             return tcs.Task;
+         }
+ ",This entire method can be deleted; it isn't used and it isn't an override of Stream.,cancellationToken
+7835,"@@ -50,6 +50,8 @@ import org.apache.iceberg.util.Pair;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
++import static org.apache.iceberg.MetadataTableUtils.createMetadataTableInstance;
++
+ /**
+  * Implementation of Iceberg tables that uses the Hadoop FileSystem
+  * to store metadata and manifests.",We avoid static method imports. Can you call `MetadataTableUtils.createMetadataTableInstance` instead?,Why is this change
+7836,"@@ -254,6 +254,7 @@ class PACFetcher(QObject):
+     def __eq__(self, other):
+         # pylint: disable=protected-access
+         return self._pac_url == other._pac_url
++        # pylint: enable=protected-access
+
+     def __repr__(self):
+         return utils.get_repr(self, url=self._pac_url, constructor=True)","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",This is needed because `self._pac_url` is a `str` and not an `int`.
+7837,"@@ -37,7 +37,13 @@ class Purchase < ActiveRecord::Base
+     to: :purchaseable,
+     prefix: :purchaseable,
+     allow_nil: true
+-  delegate :fulfilled_with_github?, :subscription?, :terms, to: :purchaseable
++  delegate(
++    :fulfilled_with_github?,
++    :includes_mentor?,
++    :subscription?,
++    :terms,
++    to: :purchaseable
++  )
+
+   def self.within_range(start_time, end_time)
+     paid.where(""created_at >= ? and created_at <= ?"", start_time, end_time)",I'm actually surprised this is valid Ruby. I thought you'd need either `delegate(...)` or `delegate \ ...`.,Indent the first parameter one step more than the start of the prev
+7838,"@@ -99,7 +99,7 @@ public class TestHelpers {
+         if (checkArrowValidityVector) {
+           ColumnVector columnVector = batch.column(i);
+           ValueVector arrowVector = ((IcebergArrowColumnVector) columnVector).vectorAccessor().getVector();
+-          Assert.assertEquals(""Nullability doesn't match"", expectedValue == null, arrowVector.isNull(rowId));
++          Assert.assertFalse(""Nullability doesn't match"", expectedValue == null ^ arrowVector.isNull(rowId));
+         }
+       }
+     }",Why change this?,I don't understand why this change is needed.
+7839,"@@ -537,6 +537,12 @@ module.exports = class XHRUpload extends Plugin {
+     const files = fileIDs.map((fileID) => this.uppy.getFile(fileID))
+
+     if (this.opts.bundle) {
++      // if bundle: true, we don’t support remote uploads
++      const isSomeFileRemote = files.some(file => file.isRemote)
++      if (isSomeFileRemote) {
++        throw new Error('Can’t bundle remote files when bundle: true is set')
++      }
++
+       return this.uploadBundle(files)
+     }
+ ",Maybe change it to `'Can't UPLOAD remote files when bundle: true is set'`?,"I think this should be done in the upload method, where the upload "
+7840,"@@ -217,7 +217,14 @@ namespace OpenTelemetry
+
+                 if (this.circularBuffer.Count > 0)
+                 {
+-                    this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize));
++                    try
++                    {
++                        this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize));
++                    }
++                    catch (Exception ex)
++                    {
++                        OpenTelemetrySdkEventSource.Log.SpanProcessorException(nameof(this.OnExport), ex);
++                    }
+
+                     this.dataExportedNotification.Set();
+                     this.dataExportedNotification.Reset();",Do we need to drop the remaining items from the batch? Otherwise we might end up with a dead loop. Add @CodeBlanch for awareness.,Do we want to log the full exception here as well?
+7841,"@@ -292,6 +292,19 @@ func setupMiners(st state.Tree, sm vm.StorageMap, keys []*types.KeyInfo, miners
+ 				return nil, err
+ 			}
+ 		}
++		if m.NumCommittedSectors > 0 {
++			// Now submit a dummy PoSt right away to trigger power updates.
++			// Don't worry, bootstrap miner actors don't need to verify
++			// that the PoSt is well formed.
++			poStProof := make([]byte, types.OnePoStProofPartition.ProofLen())
++			if _, err := pnrg.Read(poStProof[:]); err != nil {
++				return nil, err
++			}
++			_, err = applyMessageDirect(ctx, st, sm, addr, maddr, types.NewAttoFILFromFIL(0), ""submitPoSt"", []types.PoStProof{poStProof}, types.EmptyIntSet())
++			if err != nil {
++				return nil, err
++			}
++		}
+ 	}
+
+ 	return minfos, nil",Because power is now added during `submitPoSt` this is needed for setting power in the genesis block. Again let me know if this bootstrapping solution is flawed.,Why don't we want to validate that the PoSt is in
+7842,"@@ -40,6 +40,10 @@ return [
+     'session_gc' => ['int'],
+     'timezone_identifiers_list' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'?string'],
+     'unpack' => ['array', 'format'=>'string', 'string'=>'string', 'offset='=>'int'],
++    'ReflectionFunction::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionFunctionAbstract::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionMethod::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionParameter::getType' => ['?ReflectionNamedType']
+ ],
+ 'old' => [
+     'DateTimeZone::listIdentifiers' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'string'],","To be consistent, these should go at the top between `DateTimeZone::listIdentifiers` and `SQLite3::createFunction`.",I don't think that should be a public method. It s
+7843,"@@ -165,4 +165,13 @@ public abstract class Directory implements Closeable {
+    * @throws AlreadyClosedException if this Directory is closed
+    */
+   protected void ensureOpen() throws AlreadyClosedException {}
++
++  /**
++   * Implementations can override this if they are capable of reporting modification time
++   * of a file in seconds since the epoch.
++   */
++  public long fileModified(String name) throws IOException {
++    throw new UnsupportedOperationException();
++  }
++
+ }",I think we should avoid changing any lucene classes for the moment - fileModified() can probably stay where it is?,Should this be part of the public API? I don't see
+7844,"@@ -1174,7 +1174,7 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+                 extendedBolusView.setText(extendedBolusText);
+             }
+             if (extendedBolusText.equals(""""))
+-                extendedBolusView.setVisibility(View.INVISIBLE);
++                extendedBolusView.setVisibility(View.GONE);
+             else
+                 extendedBolusView.setVisibility(View.VISIBLE);
+         }","GONE breaks formating of "":"". or is it fixed below?","In the commit message, ""Invisible"" was replaced with ""GONE"""
+7845,"@@ -20,6 +20,9 @@ public class ASTResource extends ASTFormalParameter {
+     public Object jjtAccept(JavaParserVisitor visitor, Object data) {
+         return visitor.visit(this, data);
+     }
++
++    // TODO Should we deprecate all methods from ASTFormalParameter?
++
+ }
+ /*
+  * JavaCC - OriginalChecksum=92734fc70bba91fd9422150dbf87d5c4 (do not edit this",What do you mean with this? Won't the deprecation be inherited?,"Yeah, I think I agree with this change. The _accept()_ meth"
+7846,"@@ -90,6 +90,8 @@ std::string FlatCompiler::GetUsageString(const char* program_name) const {
+       ""  --cpp-ptr-type T   Set object API pointer type (default std::unique_ptr)\n""
+       ""  --cpp-str-type T   Set object API string type (default std::string)\n""
+       ""                     T::c_str() and T::length() must be supported\n""
++      ""  --object-prefix    Customise class prefix for C++ object-based API.\n""
++      ""  --object-suffix    Customise class suffix for C++ object-based API. Default value is \""T\""\n""
+       ""  --no-js-exports    Removes Node.js style export lines in JS.\n""
+       ""  --goog-js-export   Uses goog.exports* for closure compiler exporting in JS.\n""
+       ""  --go-namespace     Generate the overrided namespace in Golang.\n""","line between "" and "" should be <80 chars.","The default suffix is ""T"", not ""T""."
+7847,"@@ -7,7 +7,6 @@ module Travis
+     class Script
+       class Ruby < Script
+         DEFAULTS = {
+-          rvm:     'default',
+           gemfile: 'Gemfile'
+         }
+ ",What will happen if neither `rvm` nor `ruby` is present in the .travis.yml?,"I think we can remove `DEFAULTS` now, since it's no longer "
+7848,"@@ -71,8 +71,7 @@ class HCI_ACL_Hdr(Packet):
+     def post_build(self, p, pay):
+         p += pay
+         if self.len is None:
+-            l = len(p)-4
+-            p = p[:2]+chr(l&0xff)+chr((l>>8)&0xff)+p[4:]
++            p = p[:2] + struct.pack(""<H"", len(pay)) + p[4:]
+         return p
+
+ ",@p-l- Hey it seems that this was len-4 ?!,Any reason not to use `chr(..)`?
+7849,"@@ -23,12 +23,14 @@ import AdBlockerWarning from './ad-blocker-warning';
+ import { render } from '../../../../../tests/js/test-utils';
+ import { STORE_NAME } from '../datastore/constants';
+
+-const setupAdBlockerRegistry = async ( registry ) => {
+-	await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );
++const setupAdBlockerRegistry = ( registry ) => {
++	registry.dispatch( STORE_NAME ).receiveSettings( {} );
++	registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );
+ };
+
+-const setupNoAdBlockerRegistry = async ( registry ) => {
+-	await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( false );
++const setupNoAdBlockerRegistry = ( registry ) => {
++	registry.dispatch( STORE_NAME ).receiveSettings( {} );
++	registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( false );
+ };
+
+ describe( 'AdBlockerWarning', () => {","This is something I added which resolved a few large errors in the output, although not related to the refactor here I don't think.",What does this change do?
+7850,"@@ -200,7 +200,6 @@ public class ExternalPlayerFragment extends Fragment {
+                 .into(imgvCover);
+
+         if (controller != null && controller.isPlayingVideoLocally()) {
+-            butPlay.setVisibility(View.GONE);
+             ((MainActivity) getActivity()).getBottomSheet().setLocked(true);
+             ((MainActivity) getActivity()).getBottomSheet().setState(BottomSheetBehavior.STATE_COLLAPSED);
+         } else {",i have removed this line because whenever a video is played in AntennaPod this line was making play button invisible,Please remove `.setVisibility(Vi
+7851,"@@ -0,0 +1,10 @@
++package org.apache.servicecomb.foundation.vertx;
++
++import org.junit.Test;
++
++public class MyTest {
++  @Test
++  public void myTest() {
++    System.out.println(System.getProperty(""java.io.tmpdir""));
++  }
++}",remove temporary code,I think this should be removed?
+7852,"@@ -154,4 +154,11 @@ public interface BlockHeader {
+    * @return The Keccak 256-bit hash of this header.
+    */
+   Hash getBlockHash();
++
++  /**
++   * The BASEFEE of this header.
++   *
++   * @return TheBASEFEE of this header.
++   */
++  Long getBaseFee();
+ }","* Should be tagged `@Unstable` * Should be a default method, returning `null` * Also, perhaps `Optional<Long>` instead of just `Long`? Always empty when the BASEFEE isn't relevant? If so the default is `Optional.empty()`",Please remove this. It's not necessary.
+7853,"@@ -30,6 +30,7 @@ import { STORE_NAME as CORE_SITE } from '../datastore/site/constants';
+ import { STORE_NAME as CORE_USER } from '../datastore/user/constants';
+
+ const MODULE_SLUG = 'test-slug';
++const TEST_STORE_NAME = 'test/' + MODULE_SLUG;
+
+ describe( 'createInfoStore store', () => {
+ 	let registry;","Minor detail, but let's use the interpolated template string syntax instead.",Am wondering if we can drop the `MODULE
+7854,"@@ -53,6 +53,11 @@ type TimeChaosSpec struct {
+ 	// TimeOffset defines the delta time of injected program
+ 	TimeOffset TimeOffset `json:""timeOffset""`
+
++	// ClockIds defines all affected clock id
++	// All available options are [""CLOCK_REALTIME"",""CLOCK_MONOTONIC"",""CLOCK_PROCESS_CPUTIME_ID"",""CLOCK_THREAD_CPUTIME_ID"",""CLOCK_MONOTONIC_RAW"",""CLOCK_REALTIME_COARSE"",""CLOCK_MONOTONIC_COARSE"",""CLOCK_BOOTTIME"",""CLOCK_REALTIME_ALARM"",""CLOCK_BOOTTIME_ALARM""]
++	// Default value is [""CLOCK_REALTIME""]
++	ClockIds []string `json:""clockIds,omitempty""`
++
+ 	// Duration represents the duration of the chaos action
+ 	Duration *string `json:""duration""`
+ ","this line is so long, split it to multi lines.",Can you add a space after the comma so
+7855,"@@ -2865,7 +2865,7 @@ void AdjustValidatorOptions(const DeviceExtensions &device_extensions, const Dev
+     if (device_extensions.vk_khr_uniform_buffer_standard_layout && enabled_features.core12.uniformBufferStandardLayout == VK_TRUE) {
+         options.SetUniformBufferStandardLayout(true);
+     }
+-    if (device_extensions.vk_ext_scalar_block_layout && enabled_features.core12.scalarBlockLayout == VK_TRUE) {
++    if (device_extensions.vk_ext_scalar_block_layout || enabled_features.core12.scalarBlockLayout == VK_TRUE) {
+         options.SetScalarBlockLayout(true);
+     }
+     if (device_extensions.vk_khr_workgroup_memory_explicit_layout &&","Looks like this might be one of those ""promoted features"" where you can enable it by _either_ enabling the extension _or_ enabling the feature bit. If that is the case, I think this needs to be: `(device_extensions.vk_ext_scalar_block_layout == kEnabledByCreateinfo) || (enabled_features.core12.scalarBlockLayout == VK_TRUE)`.",Shouldn't this be `options.SetScalarBlo
+7856,"@@ -52,6 +52,10 @@ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint16_t>;
+ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint32_t>;
+ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint64_t>;
+
++#if defined(__APPLE__)
++template struct ONEDAL_EXPORT integer_overflow_ops<std::size_t>;
++#endif
++
+ } // namespace v1
+
+ namespace v2 {","Why should we define it for v1? This is preserved only for backward compatibility, all further modifications must be done in the latest vX",Why is this needed? Isn't it simpler to just make `integer_overflow_ops` public in app.h?
+7857,"@@ -229,12 +229,8 @@ class DaskInterface(PandasInterface):
+         return columns.data.compute()
+
+     @classmethod
+-    def length(cls, dataset):
+-        """"""
+-        Length of dask dataframe is unknown, always return 1
+-        for performance, use shape to compute dataframe shape.
+-        """"""
+-        return 1
++    def nonzero(cls, dataset):
++        return True
+
+
+ ","This is a definite improvement! Hardcoding nonzero is vastly better than hardcoding length. Even so, is there no way to determine the actual value of nonzero in a way that doesn't load the entire dataset?",What's the reasoning behind this change?
+7858,"@@ -94,6 +94,13 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation
+             return hostTagValue;
+         }
+
++        /// <summary>
++        /// Gets the OpenTelemetry standard uri tag value for a span based on its request <see cref=""Uri""/>.
++        /// </summary>
++        /// <param name=""uri""><see cref=""Uri""/>.</param>
++        /// <returns>Span uri value.</returns>
++        public static string GetUriTagValueFromRequestUri(Uri uri) => string.Concat(uri.Scheme, Uri.SchemeDelimiter, uri.Authority, uri.PathAndQuery, uri.Fragment);
++
+         private static string ConvertMethodToOperationName(string method) => $""HTTP {method}"";
+
+         private static string ConvertHttpMethodToOperationName(HttpMethod method) => $""HTTP {method}"";","do we have a way to avoid the string concats, if there is no username/password in the Uri? if (uri has UsernameInfo) { do what is done in this PR. } else { existing behavior. }",Should we rename this to `GetUriTagValue` then?
+7859,"@@ -1862,6 +1862,7 @@ static void cb_stackdriver_flush(const void *data, size_t bytes,
+     else {
+         /* The request was issued successfully, validate the 'error' field */
+         flb_plg_debug(ctx->ins, ""HTTP Status=%i"", c->resp.status);
++        flb_plg_debug(ctx->ins, ""HTTP data=%s"", c->resp.data);
+         if (c->resp.status == 200) {
+             ret_code = FLB_OK;
+         }","do not print the payload since it might be corrupted, you can get the data with _debug.http.response_payload configuration property",(style) line over 80 characters
+7860,"@@ -33,6 +33,7 @@ var _ = Describe(""addons flow"", func() {
+
+ 		It(""app init creates an copilot directory"", func() {
+ 			Expect(""./copilot"").Should(BeADirectory())
++			Expect(""./copilot/.workspace"").Should(BeAnExistingFile())
+ 		})
+
+ 		It(""app ls includes new app"", func() {","maybe ""app init creates an copilot directory and a workspace file""? since you validate for the file as well.","Can we change this to `Expect(""./copilot/.workspace"").Should(BeAnExistingFile())`?"
+7861,"@@ -7,10 +7,9 @@ class Topic < ActiveRecord::Base
+     options.has_many :products, source_type: 'Product'
+     options.has_many :topics, source_type: 'Topic'
+     options.has_many :videos, source_type: 'Video'
++    options.has_many :trails, source_type: 'Trail'
+   end
+
+-  has_many :trails
+-
+   validates :name, presence: true
+   validates :slug, presence: true, uniqueness: true
+ ",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Useless assignment to variable - `trail`.<br>Line is too long. [81/80]
+7862,"@@ -1,6 +1,6 @@
+ <?php
+
+-namespace Sabre\Event;
++namespace Amp;
+
+ /**
+  * @template TReturn",Nit: Could rename this file from SabreEvent.php now that it's not for Sabre,Can you change this to `Sabre`?
+7863,"@@ -39,4 +39,9 @@ func Start() {
+ func Stop() {
+ 	tch.Stop()
+ 	yarpc.Stop()
++	http.Stop()
++	apachethrift.Stop()
+ }
++
++// TODO(abg): We should probably use defers to ensure things that started up
++// successfully are stopped before we exit.",I believe this `Stop` function _is_ called with deferred.,So what is the motivation for not using defers?
+7864,"@@ -28,13 +28,11 @@ import { __ } from '@wordpress/i18n';
+ import API from 'googlesitekit-api';
+ import Data from 'googlesitekit-data';
+ import { STORE_NAME } from './constants';
+-import { parseAccountID } from '../util';
+ import { createFetchStore } from '../../../googlesitekit/data/create-fetch-store';
+
+ const fetchGetURLChannelsStore = createFetchStore( {
+ 	baseName: 'getURLChannels',
+-	controlCallback: ( { clientID } ) => {
+-		const accountID = parseAccountID( clientID );
++	controlCallback: ( { accountID, clientID } ) => {
+ 		if ( undefined === accountID ) {
+ 			// Mirror the API response that would happen for an invalid client ID.
+ 			return new Promise( () => {","This entire clause should now be removed. It was only relevant if `accountID` couldn't be parsed from `clientID`, which is now no longer needed.",You can remove `undefined` check from `parseAccountID`.
+7865,"@@ -77,10 +77,12 @@ extlinks = {
+ }
+
+ intersphinx_mapping = {
+-    'ansible': ('https://docs.ansible.com/ansible/devel/', None),
++    'ansible': ('https://docs.ansible.com/ansible/latest/', None),
+     'pip': ('https://pip.pypa.io/en/latest/', None),
+     'python': ('https://docs.python.org/3', None),
+     'python2': ('https://docs.python.org/2', None),
++    'testinfra': ('https://testinfra.readthedocs.io/en/latest/', None),
++    'yamllint': ('http://yamllint.readthedocs.io/en/latest/', None),
+ }
+
+ # The version info for the project you're documenting, acts as replacement for","FTR: Unlike commonly known practice, `latest` in Ansible docs corresponds to the stable version, not to the latest state of the main Git branch. Is this your intention? Just checking...",I think this is missing `docs.ansible.org/en/latest`
+7866,"@@ -5207,6 +5207,18 @@ const NAType *Translate::synthesizeType()
+          err4106arg = SQLCHARSETSTRING_UTF8;
+        break;
+
++     case GBK_TO_UTF8:
++       if (translateSource->getCharSet() == CharInfo::GBK || translateSource->getCharSet() == CharInfo::UnknownCharSet )
++         charsetTarget = CharInfo::UTF8;
++       else
++       {
++            if( CmpCommon::getDefaultString(HIVE_FILE_CHARSET) ==  CmpCommon::getDefaultString(HIVE_DEFAULT_CHARSET) )
++              err4106arg = SQLCHARSETCODE_GB2312;
++            else
++             charsetTarget = CharInfo::UTF8;
++       }
++       break;
++
+      case ISO88591_TO_UTF8:
+        if (translateSource->getCharSet() == CharInfo::ISO88591)
+        {",Why do we have || CharInfo::UnknownCharSet here? I do not see it it in neighbouring statements. This is just for my understanding.,Why is this second space needed?
+7867,"@@ -180,6 +180,7 @@ namespace NLog.Targets
+         /// <docgen category='Web Service Options' order='10' />
+         public string XmlRootNamespace { get; set; }
+
++        private readonly Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>> _pendingRequests = new Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>>();
+
+         /// <summary>
+         /// Calls the target method. Must be implemented in concrete classes.",isn't `HttpWebRequest` an expensive key value?,Why are we making this field readonly?
+7868,"@@ -148,6 +148,14 @@ class Proposal < ActiveRecord::Base
+     observations.find_by(user: user)
+   end
+
++  def eligible_observers
++    if observations.count > 0
++      User.where(client_slug: client).where('id not in (?)', observations.pluck('user_id'))
++    else
++      User.where(client_slug: client)
++    end
++  end
++
+   def add_observer(email_or_user, adder=nil, reason=nil)
+     user = find_user(email_or_user)
+ ",couldn't we run this query whether there are observations or not?,Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+7869,"@@ -125,12 +125,12 @@ class CmdlineTest(unittest.TestCase):
+
+     @mock.patch(""logging.getLogger"")
+     def test_cmdline_other_task(self, logger):
+-        luigi.run(['--local-scheduler', '--no-lock', 'SomeTask', '--n', '1000'])
++        luigi.run(['SomeTask', '--local-scheduler', '--no-lock', '--n', '1000'])
+         self.assertEqual(dict(MockTarget.fs.get_all_data()), {'/tmp/test_1000': b'done'})
+
+     @mock.patch(""logging.getLogger"")
+     def test_cmdline_ambiguous_class(self, logger):
+-        self.assertRaises(Exception, luigi.run, ['--local-scheduler', '--no-lock', 'AmbiguousClass'])
++        self.assertRaises(Exception, luigi.run, ['AmbiguousClass', '--local-scheduler', '--no-lock'])
+
+     @mock.patch(""logging.getLogger"")
+     @mock.patch(""logging.StreamHandler"")",This shouldn't be needed to change right?,Why was this changed?
+7870,"@@ -18,14 +18,14 @@ module.exports = {
+             ""port"": 8080
+         }
+     },
+-    ""files"": [ ""examples/cdn/*""],
++    ""files"": [ ""examples/bundle/*""],
+     ""index"": ""index.html"",
+     ""watchOptions"": {},
+     ""server"": true,
+     ""proxy"": false,
+     ""port"": 3000,
+     ""middleware"": false,
+-    ""serveStatic"": [""examples/cdn""],
++    ""serveStatic"": [""examples/bundle""],
+     ""ghostMode"": {
+         ""clicks"": true,
+         ""scroll"": true,","This seemed broken to me. Why would browserify only check the (previously `cdn`, now) `bundle` example? And even so, the path is incorrect here. Fixing this is unrelated so should not go into this PR I feel. But when we fix this in master, perhaps that solves the reload issues that you experienced @hedgerh?",This should have been `examples/cdn` before.
+7871,"@@ -11,13 +11,12 @@ namespace Datadog.Trace.AppSec.Waf.NativeBindings
+     [StructLayout(LayoutKind.Sequential)]
+     internal struct DdwafResultStruct
+     {
+-        [Obsolete(""This member will be removed from then ddwaf library by a future PR"")]
+-        public DDWAF_RET_CODE Action;
++        public bool Timeout;
++
++        public int PerfTotalRuntime;
+
+         public IntPtr Data;
+
+         public IntPtr PerfData;
+-
+-        public int PerfTotalRuntime;
+     }
+ }","Same question, do we have potential version-conflict crashing scenarios here?",PerfTotalRuntime is not used anymore and should be removed.
+7872,"@@ -89,6 +89,18 @@ int RGroupDecomposition::add(const ROMol &inmol) {
+   const bool addCoords = true;
+   MolOps::addHs(mol, explicitOnly, addCoords);
+
++  // mark any wildcards in input molecule:
++  for (auto &atom : mol.atoms()) {
++    if (atom->getAtomicNum() == 0) {
++      atom->setProp(""INPUT_DUMMY"", true);
++      // clean any existing R group numbers
++      atom->setIsotope(0);
++      atom->setAtomMapNum(0);
++      if (atom->hasProp(common_properties::_MolFileRLabel)) {
++        atom->clearProp(common_properties::_MolFileRLabel);
++      }
++    }
++  }
+   int core_idx = 0;
+   const RCore *rcore = nullptr;
+   std::vector<MatchVectType> tmatches;","Definitely not required, but it would be better if you had a constexpr for `""INPUT_DUMMY""`",use setAtomMapNum instead of clearing here
+7873,"@@ -1831,11 +1831,7 @@ namespace NLog.Targets
+ #endif
+                 try
+                 {
+-                    archiveFile = this.GetArchiveFileName(fileName, ev, upcomingWriteSize);
+-                    if (!string.IsNullOrEmpty(archiveFile))
+-                    {
+-                        this.DoAutoArchive(archiveFile, ev);
+-                    }
++                    this.DoAutoArchive(archiveFile, ev);
+                 }
+                 finally
+                 {","It seems ok. Because already created a file name at line 1815 and already checked if it is null or empty at line 1816. If file name is null, then already this line will not executed.",why is this no longer required?
+7874,"@@ -71,8 +71,9 @@ public interface GenesisConfigOptions {
+
+   OptionalLong getLondonBlockNumber();
+
+-  // TODO EIP-1559 change for the actual fork name when known
+-  OptionalLong getAleutBlockNumber();
++  OptionalLong getArrowGlacierBlockNumber();
++
++  OptionalLong getBaseFeePerGas();
+
+   OptionalLong getEIP1559BlockNumber();
+ ",Can all the BaseFeePerGas methods that are added be removed? It's not needed for the bomb and not referenced anywhere else in this PR.,What is the actual fork name? Is it the fo
+7875,"@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
+ 	if docrootRelPath != """" {
+ 		app.Docroot = docrootRelPath
+ 		if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
+-			util.Failed(""The docroot provided (%v) does not exist"", docrootRelPath)
++			output.UserOut.Warnf(""Warning: the provided docroot at %s does not currently exist."", docrootRelPath)
+ 		}
+ 	} else if !cmd.Flags().Changed(""docroot"") {
+ 		app.Docroot = ddevapp.DiscoverDefaultDocroot(app)",util.Warning()? Easier to say.,Why not output a warning? Is there a way t
+7876,"@@ -64,8 +64,6 @@ type (
+ 		rootHash  hash.Hash32B
+ 		toRoot    *list.List // stores the path from root to diverging node
+ 		bucket    string     // bucket name to store the nodes
+-		clpsK     []byte     // path if the node can collapse after deleting an entry
+-		clpsV     []byte     // value if the node can collapse after deleting an entry
+ 		numEntry  uint64     // number of entries added to the trie
+ 		numBranch uint64
+ 		numExt    uint64",these 2 no longer needed after refactor,why are these removed?
+7877,"@@ -63,6 +63,8 @@ const (
+ 	SpecExportOptionsEmpty   = ""empty_export_options""
+ 	SpecMountOptions         = ""mount_options""
+ 	SpecCSIMountOptions      = ""csi_mount_options""
++	SpecCSIRawBlock			 = ""fadirectRawBlock""
++	SpecCSIFsType			 = ""fsType""
+ 	SpecSharedv4MountOptions = ""sharedv4_mount_options""
+ 	SpecProxyProtocolS3      = ""s3""
+ 	SpecProxyProtocolPXD     = ""pxd""","most spec options appear to be snake case - `fa_direct_raw_block`, let's stick to that convention",did you mean to add `f
+7878,"@@ -4,7 +4,6 @@ var globby = require('globby');
+ var WebDriver = require('selenium-webdriver');
+ var chrome = require('selenium-webdriver/chrome');
+ var chromedriver = require('chromedriver');
+-var isCI = require('is-ci');
+
+ var args = process.argv.slice(2);
+ ",Looks like we can then drop this dependency.,Why is this removed?
+7879,"@@ -667,6 +667,10 @@ class FlowMaster(controller.Master):
+             self.add_event(""Script error:\n"" + str(e), ""error"")
+         self.scripts.remove(script_obj)
+
++    def reload_scripts(self):
++        for s in self.scripts[:]:
++            s.load()
++
+     def load_script(self, command):
+         """"""
+             Loads a script. Returns an error description if something went","3) Subscribe to the script change signal in `FlowMaster.__init__`. The event handler should call `self.masterq.put((""script_change"", script))`. 4) Add a `handle_script_change` function, that once called, takes the script object and calls `script.reload()`.",A bit unrelated to thi
+7880,"@@ -287,4 +287,13 @@ public class EmailMessage {
+
+     return this;
+   }
++
++  public String getBody() {
++    return _body.toString();
++  }
++
++  public String getSubject() {
++    return _subject;
++  }
++
+ }","This method is for unit testing only, right? How about making it package private? This way the readers would know that this is not a public API outside this package and would reduce the search space.",Why not use `getBody()` and `getSubject()`?
+7881,"@@ -0,0 +1 @@
++package project",accidental? i guess it's the same as any other boilerplate,Changes in this file don't belong to this P
+7882,"@@ -1,7 +1,10 @@
++from concurrent.futures import ThreadPoolExecutor, TimeoutError
+ from pyramid.security import NO_PERMISSION_REQUIRED
+
++from kinto import logger
+ from kinto.core import Service
+
++
+ heartbeat = Service(name=""heartbeat"", path='/__heartbeat__',
+                     description=""Server health"")
+ ","shadowing the builtin, let's use function or func or callable_",Do we need the `logger` import if we don't
+7883,"@@ -0,0 +1,8 @@
++# pylint: disable=missing-docstring,expression-not-assigned,too-few-public-methods,pointless-statement
++
++class Unhashable(object):
++    __hash__ = list.__hash__
++
++{}[[]] # [unhashable-dict-key]
++{}[{}] # [unhashable-dict-key]
++{}[Unhashable()] # [unhashable-dict-key]","Can you add some good examples, for instance integers, strings and whatnot?",The `__hash__` is not a valid expression. `
+7884,"@@ -1,3 +1,17 @@
++// Copyright © 2017-2019 The OpenEBS Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
+ package command
+
+ import (","Can we just have 2017 here @kmova if possible, as i seen in other projects as well( kubernetes etc..), they mentioned only the year when the file has been created.",Can you add a doc string about what this is?
+7885,"@@ -460,8 +460,7 @@ std::vector<DPFSubstring> DebugPrintf::ParseFormatString(const std::string forma
+
+ std::string DebugPrintf::FindFormatString(std::vector<unsigned int> pgm, uint32_t string_id) {
+     std::string format_string;
+-    SHADER_MODULE_STATE shader;
+-    shader.words = pgm;
++    SHADER_MODULE_STATE shader(pgm);
+     if (shader.words.size() > 0) {
+         for (const auto &insn : shader) {
+             if (insn.opcode() == spv::OpString) {","@Tony-LunarG I just realized that this differs from the previous behavior in that spirv-opt will run on the byte code if there are any ""group decorations."" If this is a problem, I can add an additional constructor to keep the pre-existing behavior.",May as well make this `constexpr` while you'
+7886,"@@ -86,9 +86,9 @@ public class ParquetMetrics implements Serializable {
+           Types.NestedField field = fileSchema.asStruct().field(fieldId);
+           if (field != null && stats.hasNonNullValue()) {
+             updateMin(lowerBounds, fieldId,
+-                fromParquetPrimitive(field.type(), stats.genericGetMin()));
++              fromParquetPrimitive(field.type(), column.getPrimitiveType(), stats.genericGetMin()));
+             updateMax(upperBounds, fieldId,
+-                fromParquetPrimitive(field.type(), stats.genericGetMax()));
++              fromParquetPrimitive(field.type(), column.getPrimitiveType(), stats.genericGetMax()));
+           }
+         }
+       }",Nit: continuation lines should be indented 4 spaces from the start of the statement.,Shouldn't we use `fromParquetPrimitive` here
+7887,"@@ -487,6 +487,7 @@ int sysfs_finalize(void)
+ 		sysfs_region_destroy(&_regions[i]);
+ 	}
+ 	_sysfs_region_count = 0;
++	_sysfs_format_ptr = NULL;
+ 	return FPGA_OK;
+ }
+ ",Are these protected by any kind of lock?,Why is this required? Looks like a memory le
+7888,"@@ -66,6 +66,7 @@ class FirewallRule(object):
+         self.resource_id = kwargs.get('id')
+         self.create_time = kwargs.get('firewall_rule_create_time')
+         self.name = kwargs.get('firewall_rule_name')
++        self.hierarchical_name = kwargs.get('firewall_rule_hierarchical_name')
+         self.kind = kwargs.get('firewall_rule_kind')
+         self.network = kwargs.get('firewall_rule_network')
+         self._priority = kwargs.get('firewall_rule_priority')","This should probably default to a string, as get_resource_ancestors is causing the tests to fail due to the rsplit on a None hierarchical_name.",`self.hierarchical_name = kwargs.get('firewall_rule_hierarchical_name') or self.name`
+7889,"@@ -170,6 +170,7 @@ type ACMEChallengeSolverHTTP01Ingress struct {
+
+ 	// The ingress class to use when creating Ingress resources to solve ACME
+ 	// challenges that use this challenge solver.
++	// A reference by name to a Kubernetes [IngressClass](https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-class) object
+ 	// Only one of 'class' or 'name' may be specified.
+ 	Class *string
+ ","I prefer not to have markdown here, while it is nice for the site this is also shown for `kubectl explain` where this will look weird",Could you add a note that `IngressClass` can be set using `Spec.IngressClass`?
+7890,"@@ -26,7 +26,7 @@ describe('monitoring', function () {
+     mockServer.setMessageHandler(request => {
+       const doc = request.document;
+       if (doc.ismaster || doc.hello) {
+-        request.reply(Object.assign({}, mock.DEFAULT_ISMASTER));
++        request.reply(Object.assign({}, mock.DEFAULT_ISMASTER_36));
+       } else if (doc.endSessions) {
+         request.reply({ ok: 1 });
+       }",@durran Was this change intended to be included in this PR?,This looks unrelated to this PR?
+7891,"@@ -110,7 +110,7 @@ namespace pwiz.SkylineTestFunctional
+                 Assert.AreEqual(z, key.Charge);
+                 Assert.AreEqual(adduct, key.Adduct);
+                 Assert.AreEqual(caffeineInChiKey, key.Target.ToString());
+-                var viewLibPepInfo = new ViewLibraryPepInfo(key);
++                var viewLibPepInfo = new ViewLibraryPepInfo(key, null);
+                 Assert.AreEqual(key, viewLibPepInfo.Key);
+                 var smallMolInfo = viewLibPepInfo.GetSmallMoleculeLibraryAttributes();
+                 Assert.AreEqual(moleculeName, smallMolInfo.MoleculeName);","Feels like this could have a default null value to remove the need for this explicit ""null"" use.",@aparajit-pratap these are test changes that are unrelated to PR.
+7892,"@@ -145,12 +145,12 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error {
+
+ 	fs, err := s.createFilestore(ctx, cfg, t.Logger)
+ 	if err != nil {
+-		t.Logger.Error(""failed creating firestore"", zap.Error(err))
++		t.Logger.Error(""failed creating filestore"", zap.Error(err))
+ 		return err
+ 	}
+ 	defer func() {
+ 		if err := fs.Close(); err != nil {
+-			t.Logger.Error(""failed closing firestore client"", zap.Error(err))
++			t.Logger.Error(""failed closing filestore client"", zap.Error(err))
+ 		}
+ 	}()
+ ","""failed to create ...""",Let's rename it to `createFilestoreClient`?
+7893,"@@ -69,7 +69,7 @@ func PodCreator(fakeKubeClient kubernetes.Interface, podName string) {
+ 		}
+ 		_, err := fakeKubeClient.CoreV1().Pods(""openebs"").Create(podObjet)
+ 		if err != nil {
+-			glog.Errorf(""Fake pod object could not be created:"", err)
++			glog.Error(""Fake pod object could not be created:"", err)
+ 		}
+ 	}
+ }","No formatting directives, `glog.Error` will do just fine.","This is an error, not an error. Is this int"
+7894,"@@ -34,7 +34,7 @@ module Selenium
+           driver.manage.timeouts.implicit_wait = 6
+
+           driver.find_element(id: 'adder').click
+-          driver.find_element(id: 'box0')
++          expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError)
+         end
+
+         it 'should still fail to find an element with implicit waits enabled' do",This should just be `.not_to raise_error` otherwise it potentially hides errors,`not_to raise_error` is the same as `not_to
+7895,"@@ -442,7 +442,18 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			log.WithError(err).Error(""Failed to connect to Typha. Retrying..."")
++			startTime := time.Now()
++			for err != nil && time.Since(startTime) < 30*time.Second {
++				// Set Ready to false and Live to true when unable to connect to typha
++				healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Debug(""Retrying to start Typha"")
++				time.Sleep(1 * time.Second)
++			}
++			if err != nil {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()",Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.,Shouldn't this be `time.Sleep(1 * time.Seco
+7896,"@@ -10,17 +10,14 @@ declare(strict_types = 1);
+ namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute;
+
+ use Doctrine\DBAL\Connection;
++use Doctrine\DBAL\DBALException;
+ use Ergonode\Attribute\Domain\Event\Attribute\AttributeCreatedEvent;
+-use Ergonode\Core\Domain\Entity\AbstractId;
+-use Ergonode\EventSourcing\Infrastructure\DomainEventInterface;
+-use Ergonode\EventSourcing\Infrastructure\Exception\UnsupportedEventException;
+-use Ergonode\EventSourcing\Infrastructure\Projector\DomainEventProjectorInterface;
+ use JMS\Serializer\SerializerInterface;
+ use Ramsey\Uuid\Uuid;
+
+ /**
+  */
+-class AttributeCreatedEventProjector implements DomainEventProjectorInterface
++class AttributeCreatedEventProjector
+ {
+     private const TABLE = 'attribute';
+     private const TABLE_PARAMETER = 'attribute_parameter';",Separate it to different methods :D Invoke method look's like old fashion portal class :D,The `DomainEventProjectorInterface` implements the `DomainEventProjectorInterface` interface. Not sure why this was removed.
+7897,"@@ -11,11 +11,7 @@ import 'emby-button';
+         elem.classList.remove('hide');
+         elem.classList.add('expanded');
+         elem.style.height = 'auto';
+-        const height = elem.offsetHeight + 'px';
+-        elem.style.height = '0';
+-
+-        // trigger reflow
+-        const newHeight = elem.offsetHeight;
++        var height = elem.offsetHeight + 'px';
+         elem.style.height = height;
+
+         setTimeout(function () {",Collapse/expand animation of filter is broken - not smooth.,Any reason why this is not using `const`?
+7898,"@@ -16,16 +16,10 @@ module Travis
+           install_sdk_components(config[:android][:components]) unless config[:android][:components].empty?
+         end
+
+-        def install
+-          self.if   '-f gradlew',      './gradlew assemble', fold: 'install', retry: true
+-          self.elif '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
+-          self.elif '-f pom.xml',      'mvn install -DskipTests=true -B', fold: 'install', retry: true # Otherwise mvn install will run tests which. Suggestion from Charles Nutter. MK.
+-        end
+-
+         def script
+           self.if   '-f gradlew',      './gradlew check connectedCheck'
+           self.elif '-f build.gradle', 'gradle check connectedCheck'
+-          self.elif '-f pom.xml',      'mvn test -B'
++          self.elif '-f pom.xml',      'mvn install -B'
+           self.else                    'ant debug installt test'
+         end
+ ",so during the `script` stage we run `mvn install`?,Layout/ExtraSpacing: Unnecessary spacing detected.<br>Layout/RedundantSelf: Redundant self detected.
+7899,"@@ -19,6 +19,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
++	""github.com/iotexproject/iotex-core/state/factory""
+ )
+
+ // protocolID is the protocol ID",we may need to move CandidateNamespace to this protocol as it is only used here.,Iotex needs to be reviewed.
+7900,"@@ -230,7 +230,12 @@ public class ExecutionControllerUtils {
+           continue;
+           // case UNKNOWN:
+         case READY:
+-          node.setStatus(Status.KILLING);
++          // if flow status is EXECUTION_STOPPED due to e.g. pod failure, set sub node to KILLED
++          if (exFlow.getStatus()==Status.EXECUTION_STOPPED) {
++            node.setStatus(Status.KILLED);
++          } else {
++            node.setStatus(Status.KILLING);
++          }
+           break;
+         default:
+           node.setStatus(Status.FAILED);","Just to confirm, this will take care of all the nodes in graph. right?","Shouldn't this be ""if (exFlow.getStatus() == Status.EXECUTION_STOPPED)"" ?"
+7901,"@@ -175,10 +175,16 @@ namespace TestPlatform.CrossPlatEngine.UnitTests.Hosting
+         public void GetTestHostProcessStartInfoShouldIncludeConnectionInfo()
+         {
+             var connectionInfo = new TestRunnerConnectionInfo { Port = 123 };
++            var parentProcessId = 101;
++
++            mockProcessHelper.Setup(ph => ph.GetCurrentProcessId()).Returns(parentProcessId);
+
+             var startInfo = this.dotnetHostManager.GetTestHostProcessStartInfo(this.testSource, null, connectionInfo);
+
+             StringAssert.Contains(startInfo.Arguments, ""--port "" + connectionInfo.Port);
++
++            StringAssert.Contains(startInfo.Arguments, string.Format(""{0} {1}"",  Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Constants.ParentProcessIdOption, parentProcessId));
++
+         }
+
+         [TestMethod]","nit: remove this line. All ""arrange"" may be in one code block.","Why not just use `string.Format(""{0} {1}"", ...)`"
+7902,"@@ -14,10 +14,17 @@ import (
+
+ 	""runtime""
+
++	""bytes""
+ 	""restic/debug""
+ 	""restic/fs""
+ )
+
++// Xattr is a tuple storing the xattr name and value.
++type Xattr struct {
++	XattrName  string `json:""xattrname""`
++	XattrValue []byte `json:""xattrvalue""`
++}
++
+ // Node is a file, directory or other item in a backup.
+ type Node struct {
+ 	Name       string      `json:""name""`","This name is not a good fit, what about `ExtendedAttribute`? Or even just `Attribute`?",struct field Xattr should be Xattr
+7903,"@@ -0,0 +1,18 @@
++#include ""test_assert.h""
++
++int testing_fails = 0;
++
++void TestFail(const char *expval, const char *val, const char *exp,
++              const char *file, int line) {
++  TEST_OUTPUT_LINE(""VALUE: \""%s\"""", expval);
++  TEST_OUTPUT_LINE(""EXPECTED: \""%s\"""", val);
++  TEST_OUTPUT_LINE(""TEST FAILED: %s:%d, %s"", file, line, exp);
++  assert(0);
++  testing_fails++;
++}
++
++void TestEqStr(const char *expval, const char *val, const char *exp,
++               const char *file, int line) {
++  if (strcmp(expval, val) != 0) { TestFail(expval, val, exp, file, line); }
++}
++","lets keep our ""testing framework"" header only if possible. since there is an `assert(0)` in there, it is intended to halt on the first test failure.","This is the same as `TestFail(const char *exp, const char *val, const cha"
+7904,"@@ -26,9 +26,8 @@ import (
+
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""
+-	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
++	""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/action/protocol/rolldpos""
+-	""github.com/iotexproject/iotex-core/action/protocol/vote""
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""",File is not `goimports`-ed (from `goimports`),"Just for my understanding, why is this part of this PR?"
+7905,"@@ -104,7 +104,6 @@ public class TableMigrationUtil {
+                 .withMetrics(metrics)
+                 .withPartitionPath(partitionKey)
+                 .build();
+-
+           }).collect(Collectors.toList());
+     } catch (IOException e) {
+       throw new RuntimeException(""Unable to list files in partition: "" + partitionUri, e);",I was saving this white-space for my retirement :nit:,nit: undo this change
+7906,"@@ -133,6 +133,10 @@ module Blacklight::Controller
+     def discard_flash_if_xhr
+       flash.discard if request.xhr?
+     end
++    deprecation_deprecate discard_flash_if_xhr: ""Discarding flash messages on XHR requests is deprecated.
++      If you wish to continue this behavior, add this method to your ApplicationController with an
++      after_action :discard_flash_if_xhr filter. To disable this behavior now and remove this warning, add
++      a skip_after_action :discard_flash_if_xhr to your ApplicationController.""
+
+     ##
+     #","What if you don't want to continue with the behavior, but you just want the deprecation to go away? Should we add `skip_after_action :discard_flash_if_xhr`?","""Discarding flash messages on XHR requests is deprecate"
+7907,"@@ -309,7 +309,7 @@ func (ws *workingSet) validateNonce(blk *block.Block) error {
+ 	}
+ 	// Verify each account's Nonce
+ 	for srcAddr, receivedNonces := range accountNonceMap {
+-		confirmedState, err := accountutil.AccountState(ws, srcAddr)
++		confirmedState, err := accountutil.AccountStateByHash160(ws, srcAddr)
+ 		if err != nil {
+ 			return errors.Wrapf(err, ""failed to get the confirmed nonce of address %s"", srcAddr)
+ 		}",change `accountNonceMap` to map[address.Address][]uint64,Could you please rename `accountutil.AccountStateByHash
+7908,"@@ -38,6 +38,7 @@ public class GapicCodeGeneratorTest extends GapicTestBase2 {
+           .put(MainGapicProviderFactory.NODEJS, MainGapicProviderFactory.NODEJS)
+           .put(MainGapicProviderFactory.NODEJS_DOC, MainGapicProviderFactory.NODEJS)
+           .put(MainGapicProviderFactory.CSHARP, MainGapicProviderFactory.CSHARP)
++          .put(MainGapicProviderFactory.CLIENT_CONFIG, ""clientconfig"")
+           .build();
+
+   private final String apiName;","The `CLIENT_CONFIG` is ""client_config"" with underscore, so we can't reuse it in the second arg.",why is this hardcoded?
+7909,"@@ -62,6 +62,19 @@ func serviceLoggedIn(ctx context.Context, config Config, name string,
+ 		}
+ 	}
+
++	if adminFeatureList[session.UID] {
++		log.CDebugf(ctx, ""Enabling a dir op batch size of %d"",
++			bgFlushDirOpBatchSizeDefault)
++		// NOTE: This overrides any command-line parameter.  It only
++		// matters until we un-feature-flag this, I think it's ok for
++		// now.
++		config.SetBGFlushDirOpBatchSize(bgFlushDirOpBatchSizeDefault)
++	} else {
++		// TODO: let non-admins have a non-1 batch size once admins
++		// test it enough.
++		config.SetBGFlushDirOpBatchSize(1)
++	}
++
+ 	config.MDServer().RefreshAuthToken(ctx)
+ 	config.BlockServer().RefreshAuthToken(ctx)
+ 	config.KBFSOps().RefreshCachedFavorites(ctx)",Does this mean all admins get the default batch size (which is 20) no matter the value of `-sync-batch-size`? It seems the command line flag doesn't do anything then does it?,s/dir/dir op batch siz
+7910,"@@ -35,8 +35,11 @@ class CurlDownloader implements DownloaderInterface
+      *
+      * @throws DownloaderException
+      */
+-    public function download(string $url, array $headers = []): string
++    public function download(string $url, array $headers = [], array $acceptedContentTypes = null): string
+     {
++        if (null !== $acceptedContentTypes) {
++            throw new DownloaderException('CurlDownloader not supported param `acceptedHeaderTypes`');
++        }
+         $ch = curl_init();
+         curl_setopt($ch, CURLOPT_HEADER, 0);
+         curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);",Set default value as empty array instead of null,Isn't it supposed to b
+7911,"@@ -121,6 +121,10 @@ mainLoop:
+ 				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no link index."")
+ 				continue
+ 			}
++			if routeUpd.Dst == nil {
++				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no destination"")
++				continue
++			}
+
+ 			idx := routeUpd.LinkIndex
+ 			oldUpds := updatesByIfaceIdx[idx]",Would be good to UT this case,Shouldn't we do someth
+7912,"@@ -40,7 +40,7 @@ namespace Ethereum.Blockchain.Test
+             {
+                 string expectedTypeName = ExpectedTypeName(directory);
+                 Type type = types.SingleOrDefault(t => string.Equals(t.Name, expectedTypeName, StringComparison.InvariantCultureIgnoreCase));
+-                if(type == null && directory != ""stEWASMTests"" && directory != ""runtimes"")
++                if(type == null && directory != ""stEWASMTests"" && directory != ""Specs"" && directory != ""runtimes"")
+                 {
+                     if (new DirectoryInfo(directory).GetFiles().Any(f => f.Name.Contains("".resources."")))
+                     {",this was updated after linking the latest ethereum/tests after a submodules recursive update,Should we do this for `.pkg` and `.tests` directories as well? I don't think we do that for `.pkg`.
+7913,"@@ -13,6 +13,7 @@ import { Fragment } from './create-element';
+ export function Component(props, context) {
+ 	this.props = props;
+ 	this.context = context;
++	this.__data = {};
+ }
+
+ /**","Todo: find a way to only do this in one spot, ideally with defaults for the stuff we use","Shouldn't it be `function Component(props, context) {`?"
+7914,"@@ -21,14 +21,19 @@ package org.apache.iceberg.parquet;
+
+ import java.io.File;
+ import java.io.IOException;
++import java.util.Map;
++
+ import org.apache.avro.generic.GenericData;
+ import org.apache.iceberg.Metrics;
+ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.TestMetrics;
+ import org.apache.iceberg.io.InputFile;
++import org.apache.parquet.hadoop.ParquetFileReader;
+ import org.junit.Rule;
+ import org.junit.rules.TemporaryFolder;
+
++import static org.apache.iceberg.Files.localInput;
++
+ /**
+  * Test Metrics for Parquet.
+  */","Imports should not have blank lines. Sorry there isn't a checkstyle rule running for this yet, we still need to update the build for this one.",nit: this import should be below the others
+7915,"@@ -3096,6 +3096,8 @@ class Booster(object):
+         """"""Evaluate training or validation data.""""""
+         if data_idx >= self.__num_dataset:
+             raise ValueError(""Data_idx should be smaller than number of dataset"")
++        if callable(feval):
++            feval = [feval]
+         self.__get_eval_info()
+         ret = []
+         if self.__num_inner_eval > 0:",Please move this to L3115 to group the code logically - all code for `feval` in one place.,"feval can be a dict or a list, not a callable"
+7916,"@@ -103,7 +103,7 @@ import org.apache.tuweni.bytes.Bytes;
+ import org.apache.tuweni.bytes.Bytes32;
+
+ /** Provides EVMs supporting the appropriate operations for mainnet hard forks. */
+-abstract class MainnetEvmRegistries {
++public abstract class MainnetEvmRegistries {
+
+   static EVM frontier(final GasCalculator gasCalculator) {
+     final OperationRegistry registry = new OperationRegistry();",This was done to wrap the operation so it could be spied upon during testing. Likely needs to be undone once an alternative test is discovered.,Why is this change required?
+7917,"@@ -1062,7 +1062,7 @@ func nextReqFromMsg(msg []byte) (time.Time, int, bool, error) {
+ 		if err := json.Unmarshal(msg, &cr); err != nil {
+ 			return time.Time{}, -1, false, err
+ 		}
+-		return cr.Expires, cr.Batch, cr.NoWait, nil
++		return time.Now().Add(time.Duration(cr.Expires) * time.Millisecond), cr.Batch, cr.NoWait, nil
+ 	}
+ 	// Naked batch size here for backward compatibility.
+ 	bs := 1",I feel we need to impose a lower limit here maybe? What about a max and default for when none is set?,`time.Now()` can be replaced
+7918,"@@ -245,7 +245,15 @@ func (cds *contentDirectoryService) Handle(action string, argsXML []byte, r *htt
+ 				""UpdateID"":       cds.updateIDString(),
+ 			}, nil
+ 		case ""BrowseMetadata"":
+-			result, err := xml.Marshal(obj)
++			node, err := cds.vfs.Stat(obj.Path)
++			if err != nil {
++				return nil, err
++			}
++			upnpObject, err := cds.cdsObjectToUpnpavObject(obj, node, host)
++			if err != nil {
++				return nil, err
++			}
++			result, err := xml.Marshal(upnpObject)
+ 			if err != nil {
+ 				return nil, err
+ 			}",ineffectual assignment to `err` (from `ineffassign`),Can we move the `cdsObjectTo
+7919,"@@ -37,8 +37,8 @@ type Replacer interface {
+ // they will be used to overwrite other replacements
+ // if there is a name conflict.
+ type replacer struct {
+-	replacements       map[string]string
+-	customReplacements map[string]string
++	replacements       map[string]func() string
++	customReplacements map[string]func() string
+ 	emptyValue         string
+ 	responseRecorder   *ResponseRecorder
+ }","Ahhh... this makes sense. Does using functions to defer evaluation of these values have anything to do with #916 (where the `Host: {host}` was 'cached' between different hostnames)? If not, could you help me understand what this change does?",Does this need to be public?
+7920,"@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
+     ownEventBase_ = false;
+   }
+
+-  if (listenSocket_ >= 0) {
++  if (listenSocket_ >= 0 && listenSocket_ != THRIFT_INVALID_SOCKET) {
+     if (0 != ::THRIFT_CLOSESOCKET(listenSocket_)) {
+       GlobalOutput.perror(""TNonblockingIOThread listenSocket_ close(): "", THRIFT_GET_SOCKET_ERROR);
+     }",Perhaps the only test needed is to see if the socket is not an invalid socket? Is the >= 0 test necessary at this point?,Shouldn't this be an error if listenSocket_ is invalid?
+7921,"@@ -20,7 +20,16 @@
+   </div>
+
+   <% if current_user.subscription && current_user.stripe_customer %>
+-    <%= render 'credit_card_form' %>
++    <div class='text-box'>
++      <%= semantic_form_for current_user.subscription, url: subscription_path(current_user.subscription) do |form| %>
++        <%= form.inputs ""Your Subscription Billing Info"", id: 'billing-information' do %>
++          <%= render 'shared/credit_card_form' %>
++        <% end %>
++        <%= form.actions do %>
++          <%= form.action :submit, label: 'Update Your Card' %>
++        <% end %>
++      <% end %>
++    </div>
+   <% end %>
+ </div>
+ ",Could this line use `url: current_user.subscription`?,"I wonder, why not using the `<%= form_for(current_user."
+7922,"@@ -477,7 +477,7 @@ class Context
+             $quoted_remove_var_id = preg_quote($remove_var_id);
+
+             foreach ($clause->possibilities as $var_id => $_) {
+-                if (preg_match('/' . $quoted_remove_var_id . '[\]\[\-]/', $var_id)) {
++                if (preg_match('/' . preg_quote($quoted_remove_var_id, '/') . '[\]\[\-]/', $var_id)) {
+                     break 2;
+                 }
+             }",I was seeing `Warning: preg_match(): Unknown modifier 'a' in /path/to/project/vendor/vimeo/psalm/src/Psalm/Context.php on line 480` here,"You can use `preg_quote($quoted_remove_var_id, '/')` in"
+7923,"@@ -1,10 +1,18 @@
+ package com.github.javaparser.ast.stmt;
+
++import com.github.javaparser.JavaParser;
++import com.github.javaparser.ParserConfiguration;
++import com.github.javaparser.StaticJavaParser;
+ import com.github.javaparser.ast.expr.Expression;
+ import com.github.javaparser.ast.expr.MethodCallExpr;
+ import com.github.javaparser.ast.expr.NameExpr;
++import com.github.javaparser.printer.lexicalpreservation.LexicalPreservingPrinter;
+ import org.junit.jupiter.api.Test;
+
++import static com.github.javaparser.StaticJavaParser.parse;
++import static com.github.javaparser.utils.TestUtils.assertEqualsNoEol;
++import static com.github.javaparser.utils.Utils.EOL;
++
+ class BlockStmtTest {
+     @Test
+     void issue748AddingIdenticalStatementsDoesParentingRight() {",The changes in this file are not necessary.,are these imports needed?
+7924,"@@ -1,6 +1,7 @@
+ package manager
+
+ import (
++	""github.com/kubeedge/kubeedge/pkg/apiserverlite/util""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/watch""
+ 	""k8s.io/klog/v2""",run `make lint` to fix,wrong import order
+7925,"@@ -0,0 +1,7 @@
++from dagster import execute_pipeline
++from docs_snippets.guides.dagster.reexecution.pipeline.unreliable_pipeline import unreliable_pipeline
++
++
++def test_pipeline_compiles_and_executes():
++    result = execute_pipeline(unreliable_pipeline)
++    assert result","we will need `assert result.success` instead. result will always be not null because it returns an execution result including several metadata - when the execution fails, it'd return an execution result whose `success` attribute is false.",Do we need this te
+7926,"@@ -52,6 +52,8 @@ type CStorVolumeReplica struct {
+ type CStorVolumeReplicaSpec struct {
+ 	TargetIP string `json:""targetIP""`
+ 	Capacity string `json:""capacity""`
++	// ZvolWorkers represents number of threads that executes client IOs
++	ZvolWorkers string `json:""zvolWorkers""`
+ }
+
+ // CStorVolumeReplicaPhase is to hold result of action.",Can we mention how can one determine the best value given an infrastructure? Does it default to any value?,does this need to
+7927,"@@ -1,4 +1,6 @@
+-<?php namespace Backend\Widgets;
++<?php
++
++namespace Backend\Widgets;
+
+ use Lang;
+ use Backend\Classes\WidgetBase;","Leave this formatting the way it was please, that's the standard across all of October's files.",Please don't chang
+7928,"@@ -7,7 +7,7 @@ import (
+ 	""strings""
+
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+-	""github.com/opencontainers/runc/libcontainer/selinux""
++	selinux ""github.com/opencontainers/selinux/go-selinux""
+ )
+
+ type Validator interface {","@runcom says there is no need to use `selinux` here. `selinux` ""github.com/opencontainers/selinux/go-selinux"" The code should work fine without it.",Isn't `libcontainer/selinux/go-selinux` the preferred package name?
+7929,"@@ -20,8 +20,8 @@ CREATE_PROJECT_TABLE = """"""
+         `project_number` bigint(20) NOT NULL,
+         `project_id` varchar(255) NOT NULL,
+         `project_name` varchar(255) DEFAULT NULL,
+-        `lifecycle_state` enum('ACTIVE','DELETE_REQUESTED',
+-            'DELETE_IN_PROGRESS','DELETED') DEFAULT NULL,
++        `lifecycle_state` enum('LIFECYCLE_STATE_UNSPECIFIED','ACTIVE',
++            'DELETE_REQUESTED','DELETED') NOT NULL,
+         `parent_type` varchar(255) DEFAULT NULL,
+         `parent_id` varchar(255) DEFAULT NULL,
+         `raw_project` json DEFAULT NULL,",nit: It might be worth defining these elsewhere as a python-type?,Could you explain why this change is needed?
+7930,"@@ -151,6 +151,9 @@ public class Constants {
+      *    implies save latest 3 versions saved in storage.
+      **/
+     public static final String AZKABAN_STORAGE_ARTIFACT_MAX_RETENTION = ""azkaban.storage.artifact.max.retention"";
++
++    // enable Quartz Scheduler if true.
++    public static final String ENABLE_QUARTZ= ""enable.quartz"";
+   }
+
+   public static class FlowProperties {",prefix it with azkaban. Maybe azkaban.server.schedule.enable_quartz?,We should use the `AZKABAN_QUARTZ_SCHEDULER` constant instead.
+7931,"@@ -145,6 +145,13 @@ module Bolt
+             end
+           rescue Bolt::Error => e
+             e
++          rescue Puppet::DataBinding::LookupError => e
++            if /Undefined variable/.match(e.message)
++              message = ""Interpolations are not supported in lookups outside of an apply block: #{e.message}""
++              PALError.new(message)
++            else
++              PALError.from_preformatted_error(e)
++            end
+           rescue Puppet::PreformattedError => e
+             PALError.from_preformatted_error(e)
+           rescue StandardError => e",It'd be nice if we also caught `Unknown variable $trusted / $server_facts / $settings::` here - while I highly doubt anyone is using them (and if they are they're surely misusing them) it'd be crazy-making to have a working plan suddenly start failing with no clue as to why.,Can we also include the variable name in the message?
+7932,"@@ -967,6 +967,11 @@ type serviceInfo struct {
+ 	onlyNodeLocalEndpoints   bool
+ }
+
++// TopologyKeys is part of ServicePort interface.
++func (info *serviceInfo) TopologyKeys() []string {
++	panic(""NOT IMPLEMENTED"")
++}
++
+ // String is part of ServicePort interface.
+ func (info *serviceInfo) String() string {
+ 	return fmt.Sprintf(""%s:%d/%s"", info.clusterIP, info.port, info.protocol)",Probably need to understand/implement this one now.,Why is this not implemented?
+7933,"@@ -91,8 +91,13 @@ public class JdbcDependencyManager {
+       while (rs.next()) {
+         // Columns are (starting at index 1): file_name, file_sha1, validation_status
+         Dependency d = hashAndFileNameToDep.remove(rs.getString(1) + rs.getString(2));
+-        FileValidationStatus v = FileValidationStatus.valueOf(rs.getInt(3));
+-        depValidationStatuses.put(d, v);
++
++        // HashMap.remove will return null if the key is not found, hence check for it before
++        // adding to depValidationStatuses.
++        if (d != null) {
++          FileValidationStatus v = FileValidationStatus.valueOf(rs.getInt(3));
++          depValidationStatuses.put(d, v);
++        }
+       }
+
+       // All remaining dependencies in the hashToDep map should be marked as being NEW (because they weren't",It will be better to add contains check for key in hashAndFileNameToDep instead of null check over here. All of these should be inside that contains if case.,Can `v` be `null` if `d == n
+7934,"@@ -300,8 +300,18 @@ module Beaker
+           new_conf
+         end
+
++        # Restarts the named puppet service
++        #
++        # @param [Host] host Host the service runs on
++        # @param [String] service Name of the service to restart
++        # @param [Fixnum] curl_retries Number of times to retry the restart command
++        # @param [Fixnum] port Port to check status at
++        #
++        # @return [Result] Result of last status check
+         # @!visibility private
+-        def bounce_service host, service, curl_retries = 120
++        def bounce_service host, service, curl_retries = nil, port = nil
++          curl_retries = 120 if curl_retries.nil?
++          port = options[:puppetserver_port] if port.nil?
+           if host.graceful_restarts?
+             apachectl_path = host.is_pe? ? ""#{host['puppetsbindir']}/apache2ctl"" : 'apache2ctl'
+             host.exec(Command.new(""#{apachectl_path} graceful""))","perhaps these magic numbers could go into a Defaults module somewhere? 8140 implies the default is for puppet server. i guess that's somewhat reasonable. but if we're trying to decouple beaker from puppet, maybe this should be 80?",The default value for `curl_
+7935,"@@ -7595,6 +7595,13 @@ dr_prepopulate_cache(app_pc *tags, size_t tags_count)
+     return true;
+ }
+
++DR_API
++uint64
++dr_stats_get_built_blocks_count() {
++  return GLOBAL_STAT(num_bbs);
++}
++
++
+ /***************************************************************************
+  * PERSISTENCE
+  */",style violation: { on own line,I think this should be stati
+7936,"@@ -421,6 +421,10 @@ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *er
+                 goto AddHeaderDuped;
+             } else if (token == H2O_TOKEN_LINK) {
+                 h2o_push_path_in_link_header(req, headers[i].value, headers[i].value_len);
++            } else if (token == H2O_TOKEN_X_COMPRESS) {
++                req->compression_hint =
++                    h2o_strtosize(headers[i].value, headers[i].value_len) ? H2O_COMPRESS_HINT_ENABLE : H2O_COMPRESS_HINT_DISABLE;
++                goto Skip;
+             }
+         /* default behaviour, transfer the header downstream */
+         AddHeaderDuped:","Could we accept caseless strings (e.g. `off`, `on`, `auto`) instead of numbers to indicate the mode? Of course, we should use an enum internally (as we already do).",`H2O_COMPRESS_HINT_ENABLE` and `H2O_COMPRESS_HINT_DISABLE` are not implemented for `H2O_COMPRESS_HINT_ENABLE` and `H2O_COMPRESS_HINT_DISABLE`
+7937,"@@ -28,7 +28,8 @@ const Topic = ""/fil/msgs""
+ // Abstracts over a store of blockchain state.
+ type chainState interface {
+ 	GetHead() types.SortedCidSet
+-	GetTipSetAndState(tsKey types.SortedCidSet) (*chain.TipSetAndState, error)
++	GetTipSet(tsKey types.SortedCidSet) (*types.TipSet, error)
++	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ }
+
+ // BlockClock defines a interface to a struct that can give the current block height.","The sender doesn't use `GetTipSet`, so please remove it from this interface.",Why are we changing the interface here? Could we leave it as it was before?
+7938,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.,why not static import?
+7939,"@@ -92,9 +92,9 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl {
+   public static final String DEFAULT_NSCD_SOCKET_HOST_PATH = ""/var/run/nscd/socket"";
+   public static final String HOST_PATH_TYPE = ""Socket"";
+   public static final String DEFAULT_NSCD_SOCKET_VOLUME_MOUNT_PATH = ""/var/run/nscd/socket"";
+-  public static final String DEFAULT_SECRET_NAME = ""azkaban-private-properties"";
++  public static final String DEFAULT_SECRET_NAME = ""azkaban-k8s-secret"";
+   public static final String DEFAULT_SECRET_VOLUME = DEFAULT_SECRET_NAME;
+-  public static final String DEFAULT_SECRET_MOUNTPATH = ""/var/azkaban/private/conf"";
++  public static final String DEFAULT_SECRET_MOUNTPATH = ""/var/azkaban/private"";
+
+
+   private final String namespace;",These configurations are currently overwritten in the props we provide in our config files. They need to be overridden there as well after you make this change.,Can we change the variable name to `azkaban-private-secrets`?
+7940,"@@ -54,7 +54,12 @@ func PopulateMissingParameters(project *string, zone *string, region *string,
+
+ 	scratchBucketRegion := """"
+ 	if *scratchBucketGcsPath == """" {
+-		scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project)
++		fallbackZone := *zone
++		if fallbackZone == """" && mgce.OnGCE() {
++			// try to get zone which Cloud Build is running in, ignoring error
++			fallbackZone, _ = mgce.Zone()
++		}
++		scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project, fallbackZone)
+ 		scratchBucketRegion = sbr
+ 		if err != nil {
+ 			return err",Why is error ignored here?,Why ignore the error?
+7941,"@@ -20,6 +20,8 @@ const (
+ 	PartitionFlagGrub PartitionFlag = ""grub""
+ 	// PartitionFlagBiosGrub indicates this is a bios grub boot partition
+ 	PartitionFlagBiosGrub PartitionFlag = ""bios_grub""
++	// PartitionFlagBiosGrubLegacy indicates this is a bios grub boot partition. Needed to preserve legacy config behavior.
++	PartitionFlagBiosGrubLegacy PartitionFlag = ""bios-grub""
+ 	// PartitionFlagBoot indicates this is a boot partition
+ 	PartitionFlagBoot PartitionFlag = ""boot""
+ 	// PartitionFlagDeviceMapperRoot indicates this partition will be used for a device mapper root device",">PartitionFlagBiosGrubLegacy PartitionFlag = ""bios-grub"" [](start = 1, length = 55) I presume this is to fix a breaking change...and it's too late to fix the breaking change (since it already escaped into the world?)",does this need to be
+7942,"@@ -159,7 +159,7 @@ public class ScanSummary {
+       removeTimeFilters(filters, Expressions.rewriteNot(scan.filter()));
+       Expression rowFilter = joinFilters(filters);
+
+-      Iterable<ManifestFile> manifests = table.currentSnapshot().manifests();
++      Iterable<ManifestFile> manifests = table.currentSnapshot().dataManifests();
+
+       boolean filterByTimestamp = !timeFilters.isEmpty();
+       Set<Long> snapshotsInTimeRange = Sets.newHashSet();",Is this explicitly ignoring the effect of deleted rows on partition metrics or is it just that you are short circuiting any delete files (as we can't use them anyways),What's the difference
+7943,"@@ -149,6 +149,12 @@ namespace Microsoft.DotNet.Execute
+         private string BuildParametersForCommand(Dictionary<string, string> commandParameters, string toolName)
+         {
+             string commandSetting = string.Empty;
++
++            if (Tools.ContainsKey(toolName))
++            {
++                commandSetting = Tools[toolName].osSpecific[Os][""defaultParameters""];
++            }
++
+             foreach (KeyValuePair<string, string> parameters in commandParameters)
+             {
+                 if (!parameters.Key.Equals(""toolName"") && !string.IsNullOrEmpty(parameters.Value))","I would also check whether or not this ""defaultParameters"" is null or empty to allow for people to omit it from the config file.",You can use `TryGetVa
+7944,"@@ -170,5 +170,5 @@ func (event *Event) IsToEdge() bool {
+
+ // GetContent dumps the content to string
+ func (event *Event) GetContent() string {
+-	return fmt.Sprintf(""%v"", event.Content)
++	return fmt.Sprintf(""%s"", event.Content)
+ }","I think event.Content is of type interface{}, so we may need %v here?","Does `%v` work here, or does `%s` not work?"
+7945,"@@ -17,10 +17,12 @@
+ # along with Invenio; if not, write to the Free Software Foundation, Inc.,
+ # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+
++""""""Legacy BibEdit.""""""
++
+ import warnings
+
+-from invenio.utils.deprecation import RemovedInInvenio22Warning
++from invenio.utils.deprecation import RemovedInInvenio23Warning
+
+-warnings.warn(""BibEdit will be removed in 2.2. Please check ""
++warnings.warn(""Legacy BibEdit will be removed in 2.3. Please check ""
+               ""'invenio.modules.editor' module."",
+-              RemovedInInvenio22Warning)
++              RemovedInInvenio23Warning)",Note: `editor` depends on legacy `BibEdit`,Since you removed the check for `RemovedInI
+7946,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,Is this function used anywhere? Can we remo
+7947,"@@ -2608,3 +2608,16 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
+         self.assertRaises(
+             ValueError, lambda: kdf.groupby([(""B"", ""class""), (""A"", ""name"")]).get_group(""mammal"")
+         )
++
++    def test_median(self):
++        kdf = ks.DataFrame(
++            {
++                ""a"": [1.0, 1.0, 1.0, 1.0, 2.0, 2.0, 2.0, 3.0, 3.0, 3.0],
++                ""b"": [2.0, 3.0, 1.0, 4.0, 6.0, 9.0, 8.0, 10.0, 7.0, 5.0],
++                ""c"": [3.0, 5.0, 2.0, 5.0, 1.0, 2.0, 6.0, 4.0, 3.0, 6.0],
++            },
++            columns=[""a"", ""b"", ""c""],
++            index=[7, 2, 4, 1, 3, 4, 9, 10, 5, 6],
++        )
++        with self.assertRaisesRegex(ValueError, ""accuracy must be an integer; however""):
++            kdf.groupby(""a"").median(accuracy=""a"")",I'm wondering if a positive test case is needed here? Then we might compare the result DataFrame with a pre-created Koalas DataFrame.,Can you test for other values too (like `0.
+7948,"@@ -328,9 +328,9 @@ public interface Value<T> extends Iterable<T> {
+     }
+
+     /**
+-     * Checks, this {@code Value} is empty, i.e. if the underlying value is absent.
++     * Checks whether this {@code Value} is empty, i.e. if the underlying value is absent.
+      *
+-     * @return false, if no underlying value is present, true otherwise.
++     * @return true, if no underlying value is present, false otherwise.
+      */
+     boolean isEmpty();
+ ",I think it was reversed,"I think this should say ""returns true if the underlying value is absent."""
+7949,"@@ -12,14 +12,10 @@ public class ASTJspDirective extends AbstractJspNode {
+      */
+     private String name;
+
+-    public ASTJspDirective(int id) {
++    ASTJspDirective(int id) {
+         super(id);
+     }
+
+-    public ASTJspDirective(JspParser p, int id) {
+-        super(p, id);
+-    }
+-
+     /**
+      * @return Returns the name.
+      */","The setter ""setName"" can be package-private as well",Why is this deleted?
+7950,"@@ -30,7 +30,7 @@ void AdamSolver<Dtype>::ComputeUpdateValue(int param_id, Dtype rate) {
+   Blob<Dtype>* val_v = this->history_[param_id + update_history_offset].get();
+   Blob<Dtype>* val_t = this->temp_[param_id].get();
+
+-  const int t = this->iter_  + 1;
++  const int t = this->iter_ + 1;
+   const Dtype correction = std::sqrt(Dtype(1) - pow(beta2, t)) /
+       (Dtype(1.) - pow(beta1, t));
+   const int N = net_params[param_id]->count();","Not sure if this is intentional or snuck in through find/replace; while this is a correct style fix (and is welcome in another PR), it should not be done here so that the commit maintains a logical changeset.",This looks like an unrelated change that got pulled in?
+7951,"@@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
+   BOOST_CHECK_NO_THROW(buf2.write((const uint8_t*)""bar"", 3));
+ }
+
++#ifndef _WIN32
++// We can't allocate 1 GB of memory in 32-bit environments.
++BOOST_AUTO_TEST_CASE(test_over_two_gb) {
++  TMemoryBuffer buf;
++  std::vector<uint8_t> small_buff(1);
++  std::vector<uint8_t> one_gb(1073741824);
++
++  buf.write(&small_buff[0], small_buff.size());
++  buf.write(&one_gb[0], one_gb.size());
++  BOOST_CHECK_THROW(buf.write(&one_gb[0], one_gb.size()), TTransportException);
++}
++#endif
++
+ BOOST_AUTO_TEST_SUITE_END()","This makes me wonder if the TBufferTransport should have a size limit that is configurable, with a default of INT32_MAX, and then the test can make a smaller one like 4KB, and write 4KB and then one byte more, instead of using up 2GB of memory.",This should be `BOOST_AUTO_TEST_SUITE_END` since this is a Windows-specif
+7952,"@@ -255,6 +255,8 @@ public class ApiMethodTransformer {
+     methodViewBuilder.stubName(namer.getStubName(context.getTargetInterface()));
+     methodViewBuilder.settingsGetterName(namer.getSettingsFunctionName(context.getMethod()));
+     methodViewBuilder.callableName(context.getNamer().getCallableName(context.getMethod()));
++    methodViewBuilder.isRequestStreaming(context.getMethod().getRequestStreaming());
++    methodViewBuilder.isResponseStreaming(context.getMethod().getResponseStreaming());
+   }
+
+   private void setListMethodFields(","If you use an enum for the streaming type, you wouldn't need to add each boolean as a separate attribute.","Do we really need to check this? What if the method was made with requestStreaming=false, responseStreaming=true?"
+7953,"@@ -98,6 +98,7 @@ from invenio.utils.serializers import serialize_via_marshal, \
+     deserialize_via_marshal
+
+ from sqlalchemy.exc import DatabaseError
++from MySQLdb import IntegrityError
+
+ from .engine_utils import get_index_id_from_index_name
+ ",can you check if you can use `sqlalchemy.exc.IntegrityError` instead?,I don't think this is used?
+7954,"@@ -144,7 +144,7 @@ void JobManager::scheduleThread() {
+
+ // @return: true if all task dispatched, else false
+ bool JobManager::runJobInternal(const JobDescription& jobDesc, JbOp op) {
+-  std::lock_guard<std::mutex> lk(muJobFinished_);
++  std::lock_guard<std::recursive_mutex> lk(muJobFinished_);
+   std::unique_ptr<JobExecutor> je =
+       JobExecutorFactory::createJobExecutor(jobDesc, kvStore_, adminClient_);
+   JobExecutor* jobExec = je.get();",Why we need to use recursive_mutex here?,What's the point of using `std::recursive_mutex` if you're not using `std::lock_guard`?
+7955,"@@ -68,8 +68,7 @@ var _ = framework.CertManagerDescribe(""ACME Certificate (HTTP01)"", func() {
+ 	validations := f.Helper().ValidationSetForUnsupportedFeatureSet(unsupportedFeatures)
+
+ 	BeforeEach(func() {
+-		acmeIssuer := util.NewCertManagerACMEIssuer(issuerName, f.Config.Addons.ACMEServer.URL, testingACMEEmail, testingACMEPrivateKey)
+-		acmeIssuer.Spec.ACME.Solvers = []cmacme.ACMEChallengeSolver{
++		solvers := []cmacme.ACMEChallengeSolver{
+ 			{
+ 				HTTP01: &cmacme.ACMEChallengeSolverHTTP01{
+ 					Ingress: &cmacme.ACMEChallengeSolverHTTP01Ingress{","am I correct these changes are related to: > I have removed a bunch of legacy functions for issuer generation ... if so, I can see why that's a valuable change but this is already a pretty huge PR and these changes to use `gen` here feel quite distant from the goal of this specific PR; they should maybe be in their own PR, to make everything easier to review? or have I missed how these changes are linked to this PR?",Can we rename this to `acmeChallengeSolver`?
+7956,"@@ -19,8 +19,10 @@ package org.openqa.selenium.grid.graphql;
+
+ import com.google.common.base.Suppliers;
+ import com.google.common.collect.ImmutableList;
++
+ import org.openqa.selenium.grid.data.DistributorStatus;
+ import org.openqa.selenium.grid.distributor.Distributor;
++import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.internal.Require;
+
+ import java.net.URI;",I think that this is an unused import,Remove extra empty line.
+7957,"@@ -328,7 +328,7 @@ public class DdiExportUtil {
+
+     private static void writeVersionStatement(XMLStreamWriter xmlw, DatasetVersionDTO datasetVersionDTO) throws XMLStreamException{
+         xmlw.writeStartElement(""verStmt"");
+-        writeAttribute(xmlw,""source"",""DVN"");
++        writeAttribute(xmlw,""source"",""producer"");
+         xmlw.writeStartElement(""version"");
+         writeAttribute(xmlw,""date"", datasetVersionDTO.getReleaseTime().substring(0, 10));
+         writeAttribute(xmlw,""type"", datasetVersionDTO.getVersionState().toString()); ","The string ""DVN_3_0"" appears in `if (!SOURCE_DVN_3_0.equals(xmlr.getAttributeValue(null, ""source""))) {` in ImportDDIServiceBean. It's not an exact match so I don't *think* this will break dataset import from DDI but I thought I'd at least mention it.",Why did you change this
+7958,"@@ -361,6 +361,15 @@ func (s *svc) CompareCommits(ctx context.Context, ref *RemoteRef, compareSHA str
+ 	}, nil
+ }
+
++func (s *svc) ListCommitsViaComparison(ctx context.Context, ref *RemoteRef, compareSHA string) ([]*githubv3.RepositoryCommit, error) {
++	comp, _, err := s.rest.Repositories.CompareCommits(ctx, ref.RepoOwner, ref.RepoName, compareSHA, ref.Ref)
++	if err != nil {
++		return nil, fmt.Errorf(""could not get commits from comparison for %s and %s. %+v"", ref.Ref, compareSHA, err)
++	}
++
++	return comp.Commits, nil
++}
++
+ type Commit struct {
+ 	Files     []*githubv3.CommitFile
+ 	Message   string","Can you add docstring to this? Also, this might be a nit but I think `CompareCommits` or `CommitRange` might be a better name. What do you think?",I think we should return
+7959,"@@ -33,6 +33,11 @@ import (
+
+ func (current *PullSubscription) Validate(ctx context.Context) *apis.FieldError {
+ 	errs := current.Spec.Validate(ctx).ViaField(""spec"")
++
++	if apis.IsInUpdate(ctx) {
++		original := apis.GetBaseline(ctx).(*PullSubscription)
++		errs = errs.Also(current.CheckImmutableFields(ctx, original))
++	}
+ 	return duck.ValidateAutoscalingAnnotations(ctx, current.Annotations, errs)
+ }
+ ","were all these ones missed in the previous PR so you are adding them now? the sources v1 and some of this? Is that right? If so, can you update the PR title",I don't think we need th
+7960,"@@ -124,7 +124,10 @@ public final class SegmentInfos implements Cloneable, Iterable<SegmentCommitInfo
+   public static final int VERSION_72 = 8;
+   /** The version that recorded softDelCount */
+   public static final int VERSION_74 = 9;
+-  static final int VERSION_CURRENT = VERSION_74;
++  /** The version that recorded nextWriteDocValuesGen */
++  public static final int VERSION_77 = 10;
++
++  static final int VERSION_CURRENT = VERSION_77;
+
+   /** Used to name new segments. */
+   public long counter;",hmm should this be `VERSION_81` instead?,this should be put in `nextWriteDocValuesGen`
+7961,"@@ -50,7 +50,9 @@ const (
+ 	pendingDeltasFlushThreshold = 128
+ 	// trieRebuildAccountChunkSize defines the number of accounts that would get read at a single chunk
+ 	// before added to the trie during trie construction
+-	trieRebuildAccountChunkSize = 512
++	trieRebuildAccountChunkSize = 16384
++	// trieRebuildCommitFrequency defines the number of accounts that would get added before we call evict to commit the changes and adjust the memory cache.
++	trieRebuildCommitFrequency = 65536
+ 	// trieAccumulatedChangesFlush defines the number of pending changes that would be applied to the merkle trie before
+ 	// we attempt to commit them to disk while writing a batch of rounds balances to disk.
+ 	trieAccumulatedChangesFlush = 256",What is the reason for increasing this?,Do we still need these values if they're only
+7962,"@@ -153,7 +153,9 @@ module.exports = class Transloadit extends Plugin {
+     // Add Assembly-specific Tus endpoint.
+     const tus = {
+       ...file.tus,
+-      endpoint: status.tus_url
++      endpoint: status.tus_url,
++      // Include X-Request-ID headers for better debugging.
++      addRequestId: true
+     }
+
+     // Set Companion location. We only add this, if 'file' has the attribute","is there any reason we are not adding this to companion as well?   There are no CORS concerns there, so adding probably shouldn't be a problem, no? **One question about the requestId;** Are the request Ids unique to each tus-js-client request, or are they unique to an upload instance instead?","I'm not sure if this is a good idea, since if"
+7963,"@@ -76,6 +76,8 @@ public final class CsrfConfigurer<H extends HttpSecurityBuilder<H>> extends Abst
+     private CsrfTokenRepository csrfTokenRepository = new HttpSessionCsrfTokenRepository();
+     private RequestMatcher requireCsrfProtectionMatcher = CsrfFilter.DEFAULT_CSRF_MATCHER;
+     private List<RequestMatcher> ignoredCsrfProtectionMatchers = new ArrayList<RequestMatcher>();
++	private String cookieName;
++	private String cookiePath;
+
+     /**
+      * Creates a new instance",The formatting is a little off here.,is this cookie path ever used for anything?
+7964,"@@ -263,7 +263,7 @@ public class TestCustomFunctions extends LuceneTestCase {
+     PrintWriter pw = new PrintWriter(sw);
+     expected.printStackTrace(pw);
+     pw.flush();
+-    assertTrue(sw.toString().contains(""JavascriptCompiler$CompiledExpression.evaluate("" + source + "")""));
++    assertTrue(sw.toString(), sw.toString().contains(""JavascriptCompiler$CompiledExpression.evaluate("" + source + "")""));
+   }
+
+   /** test that namespaces work with custom expressions. */",Perhaps we should import assertj for tests. These assertions are so much cleaner with assertj. Don't know whether hamcrest equivalent exist (maybe it does).,This test is failing on travis. It seems like the stacktrace is being printed twice.
+7965,"@@ -2449,16 +2449,9 @@ void ProtocolGame::sendAddCreature(const Creature* creature, const Position& pos
+ 		sendMagicEffect(pos, CONST_ME_TELEPORT);
+ 	}
+
+-	sendInventoryItem(CONST_SLOT_HEAD, player->getInventoryItem(CONST_SLOT_HEAD));
+-	sendInventoryItem(CONST_SLOT_NECKLACE, player->getInventoryItem(CONST_SLOT_NECKLACE));
+-	sendInventoryItem(CONST_SLOT_BACKPACK, player->getInventoryItem(CONST_SLOT_BACKPACK));
+-	sendInventoryItem(CONST_SLOT_ARMOR, player->getInventoryItem(CONST_SLOT_ARMOR));
+-	sendInventoryItem(CONST_SLOT_RIGHT, player->getInventoryItem(CONST_SLOT_RIGHT));
+-	sendInventoryItem(CONST_SLOT_LEFT, player->getInventoryItem(CONST_SLOT_LEFT));
+-	sendInventoryItem(CONST_SLOT_LEGS, player->getInventoryItem(CONST_SLOT_LEGS));
+-	sendInventoryItem(CONST_SLOT_FEET, player->getInventoryItem(CONST_SLOT_FEET));
+-	sendInventoryItem(CONST_SLOT_RING, player->getInventoryItem(CONST_SLOT_RING));
+-	sendInventoryItem(CONST_SLOT_AMMO, player->getInventoryItem(CONST_SLOT_AMMO));
++	for (int i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) {
++		sendInventoryItem((slots_t)i, player->getInventoryItem((slots_t)i));
++	}
+
+ 	sendStats();
+ 	sendSkills();",You should use C++-type casts instead.,Refactor repeated use of this array.
+7966,"@@ -865,7 +865,12 @@ func (d *cassandraPersistence) UpdateShard(
+ }
+ func (d *cassandraPersistence) CreateWorkflowExecution(
+ 	request *p.InternalCreateWorkflowExecutionRequest,
+-) (*p.CreateWorkflowExecutionResponse, error) {
++) (*p.InternalCreateWorkflowExecutionResponse, error) {
++	for _, req := range request.NewWorkflowNewEvents {
++		if err := d.AppendHistoryNodes(req); err != nil {
++			return nil, err
++		}
++	}
+
+ 	batch := d.session.NewBatch(gocql.LoggedBatch)
+ ",Looks like each AppendHistoryNodes is its own transaction - what happens if `len(request.NewWorkflowNewEvents) == 5` but we only succeed in writing 3 of them? Will the system be able to pick up from there later? I'm _guessing_ the answer is related to the `ON CONFLICT` and `INSERT IGNORE` changes below? What does Cassandra do?,Would it make sense to do this before returning?
+7967,"@@ -107,7 +107,12 @@ func (s *SVIDStoreService) deleteSVID(ctx context.Context, log logrus.FieldLogge
+ 		return false
+ 	}
+
+-	log = log.WithField(telemetry.SVIDStore, storeName)
++	log = log.WithFields(logrus.Fields{
++		telemetry.SVIDStore: storeName,
++		telemetry.Entry:     entry.EntryId,
++		telemetry.SPIFFEID:  entry.SpiffeId,
++	})
++
+ 	svidStore, ok := s.cat.GetSVIDStoreNamed(storeName)
+ 	if !ok {
+ 		log.Error(""Error deleting SVID: SVIDStore not found"")",why are you replacing log here? it is defined above and contains EntryID and SPIFFEID,"I would be tempted to put all of these into a single function, e.g. `log.WithFields("
+7968,"@@ -34,11 +34,17 @@ type Command struct {
+ 	vpnServerFactory func(sessionManager session.Manager, serviceLocation dto_discovery.Location,
+ 		providerID identity.Identity, callback state.Callback) *openvpn.Server
+
+-	vpnServer *openvpn.Server
++	vpnServer          *openvpn.Server
++	openvpnBinaryCheck func() error
+ }
+
+ // Start starts server - does not block
+ func (cmd *Command) Start() (err error) {
++	err = cmd.openvpnBinaryCheck()
++	if err != nil {
++		return err
++	}
++
+ 	providerID, err := cmd.identityLoader()
+ 	if err != nil {
+ 		return err",Why not `checkOpenvpn` as in client command?,`openvpnBinaryCheck` is a very generic name. It might be better to name it `openvpnBinaryCheckFactory` or something.
+7969,"@@ -1,6 +1,11 @@
+ /*global mocha, console */
+ (function() {
+ 	'use strict';
++
++	if (!mocha || !mocha.reporter || !mocha.reporter('base')) {
++		return;
++	}
++
+ 	var Base = mocha.reporter('base')._reporter;
+ 	mocha.reporter(function(runner) {
+ 		Base.call(this, runner);",> Note: Non-headless tests (that run on selenium-webdriver) need to wire up to mocha reporter to collect all the results and report them. (See `test-webdriver.js`). But for other tests this can be skipped.,Another option is to do `mocha.reporter('base')` instead of `mocha.reporter('base')`
+7970,"@@ -241,8 +241,8 @@ class Pathoc(tcp.TCPClient):
+
+     def http_connect(self, connect_to):
+         self.wfile.write(
+-            'CONNECT %s:%s HTTP/1.1\r\n' % tuple(connect_to) +
+-            '\r\n'
++            b'CONNECT %s:%d HTTP/1.1\r\n' % (connect_to[0].encode(), connect_to[1]) +
++            b'\r\n'
+         )
+         self.wfile.flush()
+         try:",I think we should apply IDNA encoding for the host here.,Why converting it to bytes works here? Shouldn't we be using `force_bytes`?
+7971,"@@ -10127,8 +10127,10 @@ void Client::Handle_OP_PetCommands(const EQApplicationPacket *app)
+
+ 		mypet->SayString(this, Chat::PetResponse, PET_GETLOST_STRING);
+ 		mypet->CastToNPC()->Depop();
++		this->Save(1);
+
+ 		//Oddly, the client (Titanium) will still allow ""/pet get lost"" command despite me adding the code below. If someone can figure that out, you can uncomment this code and use it.
++		// on live since aa merging to companions discipline /pet get lost is available without any aa requirement.
+ 		/*
+ 		if((mypet->GetPetType() == petAnimation && GetAA(aaAnimationEmpathy) >= 2) || mypet->GetPetType() != petAnimation) {
+ 		mypet->SayString(PET_GETLOST_STRING);",No need to use `this->` here,please remove the save
+7972,"@@ -151,6 +151,7 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c
+ 		statusModified = true
+ 	}
+
++	completed = controllerutils.FindClusterDeploymentCondition(conditions, hivev1.ClusterInstallCompletedClusterDeploymentCondition)
+ 	if completed.Status == corev1.ConditionTrue { // the cluster install is complete
+ 		cd.Spec.Installed = true
+ 		cd.Status.InstalledTimestamp = &completed.LastTransitionTime","I can't quite tell, is there a reason why we're finding this condition again when it was done a few lines above? Or was this a mistaken paste?",What's the reason for this change?
+7973,"@@ -22,7 +22,7 @@
+ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ // THE SOFTWARE.
+
+-//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination namespaceCache_mock.go
++//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination cache_mock.go
+
+ package namespace
+ ","doh. My fault, sorry.",why did you change this?
+7974,"@@ -80,3 +80,11 @@ func conditionIsProvider1(provider market.ServiceProposal) bool {
+ func conditionIsStreaming(provider market.ServiceProposal) bool {
+ 	return provider.ServiceType == ""streaming""
+ }
++
++func fieldID(proposal market.ServiceProposal) interface{} {
++	return proposal.ID
++}
++
++func fieldProviderID(proposal market.ServiceProposal) interface{} {
++	return proposal.ProviderID
++}",Why do we returning `interface{}` here? Don't we have a predefined type for `ID`?,There is a field named `id` in `ma
+7975,"@@ -34,9 +34,12 @@ import MiniChart from 'GoogleComponents/mini-chart';
+  */
+ import { trafficSourcesReportDataDefaults } from '../util';
+
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component, Fragment } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component, Fragment } from '@wordpress/element';
+
+ class AnalyticsDashboardWidgetTopAcquisitionSources extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies,Nit: In this case we don't need to
+7976,"@@ -8,6 +8,8 @@ import (
+ 	""context""
+ 	""flag""
+ 	""fmt""
++	""github.com/rclone/rclone/fs/config/provider/goconfig""
++	""github.com/rclone/rclone/fs/config/provider/viper""
+ 	""io""
+ 	""io/ioutil""
+ 	""log""",File is not `goimports`-ed (from `goimports`),import mess :-)
+7977,"@@ -96,6 +96,11 @@ class InteropServiceHelper {
+ 	}
+
+ 	static async defaultFilename(noteIds, fileExtension) {
++		// Use of == here is because noteIds is potentiall undefined
++		if (noteIds == null) {
++			return '';
++		}
++
+ 		const note = await Note.load(noteIds[0]);
+ 		// In a rare case the passed not will be null, use the id for filename
+ 		if (note === null) {",Not sure why you want to make the distinction between null and undefined? And also `null == undefined` anyway so I think you could simply have `!noteIds` here.,typo: `potentia
+7978,"@@ -21,6 +21,15 @@
+ package http
+
+ const (
++	// ApplicationHeaderPrefix is the prefix added to application headers over
++	// the wire.
++	ApplicationHeaderPrefix = ""Rpc-Header-""
++
++	// ContextHeaderPrefix is the prefix added to context headers over the wire.
++	ContextHeaderPrefix = ""Context-""
++
++	// TODO(abg): Allow customizing header prefixes
++
+ 	// CallerHeader is the HTTP header used to indiate the service doing the calling
+ 	CallerHeader = ""Rpc-Caller""
+ ",Almost makes me wonder if this should default to Rpc-Context so everything defaults under Rpc-,Should this TOD
+7979,"@@ -26,7 +26,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""
+-	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
++	""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/action/protocol/execution/evm""
+ 	""github.com/iotexproject/iotex-core/action/protocol/poll""
+ 	""github.com/iotexproject/iotex-core/action/protocol/rewarding""",File is not `goimports`-ed (from `goimports`),Iotexproject/io
+7980,"@@ -317,8 +317,16 @@ func (mset *Stream) AddConsumer(config *ConsumerConfig) (*Consumer, error) {
+ 		}
+ 	}
+
+-	// Check for any limits.
+-	if mset.config.MaxConsumers > 0 && len(mset.consumers) >= mset.config.MaxConsumers {
++	// Check for any limits, if the config for the consumer sets a limit we check against that
++	// but if not we use the value from account limits, if account limits is more restrictive
++	// than stream config we prefer the account limits to handle cases where account limits are
++	// updated during the lifecycle of the stream
++	maxc := mset.config.MaxConsumers
++	if mset.config.MaxConsumers <= 0 || mset.jsa.limits.MaxConsumers < mset.config.MaxConsumers {
++		maxc = mset.jsa.limits.MaxConsumers
++	}
++
++	if maxc > 0 && len(mset.consumers) >= maxc {
+ 		mset.mu.Unlock()
+ 		return nil, fmt.Errorf(""maximum consumers limit reached"")
+ 	}",would these require any account lock here?,What happens if `maxc` is lower than `mset.config.MaxConsumers` ?
+7981,"@@ -142,7 +142,7 @@ class RemoteConnection(object):
+         :Returns:
+         Timeout value in seconds for all http requests made to the Remote Connection
+         """"""
+-        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout
++        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT else cls._timeout
+
+     @classmethod
+     def set_timeout(cls, timeout):",The else doesn't return anything?,How is this change related?
+7982,"@@ -112,6 +112,7 @@ function TransactionBuilder(opts) {
+   if (opts.fee || opts.feeSat) {
+     this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
+   }
++  if (opts.fee == 0 || opts.feeSat == 0) this.givenFeeSat = 0;
+   this.remainderOut = opts.remainderOut;
+   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
+ ",if (typeof (opts.fee) !== 'undefined' || typeof (opts.feeSat) !=='undefined') {,Shouldn't this be this.givenFeeSat = opts.fee ? opts.fee * util.C
+7983,"@@ -38,7 +38,13 @@ type Device struct {
+ }
+
+ func (d *Device) CgroupString() string {
+-	return fmt.Sprintf(""%c %s:%s %s"", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), d.Permissions)
++	var p string
++	if d.Permissions == """" {
++		p = ""rwm"" // empty permissions is invalid... causes a write invalid argument error upon saving to cgroups
++	} else {
++		p = d.Permissions
++	}
++	return fmt.Sprintf(""%c %s:%s %s"", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), p)
+ }
+
+ func (d *Device) Mkdev() int {",I not sure we need to change this method's logic. Isn't no perms and invalid config?,"Not sure what the right thing to do here is, but if `d.Permission"
+7984,"@@ -23,7 +23,7 @@ const (
+ 	protocolName    = ""hive""
+ 	protocolVersion = ""1.0.0""
+ 	peersStreamName = ""peers""
+-	messageTimeout  = 5 * time.Second // maximum allowed time for a message to be read or written.
++	messageTimeout  = 1 * time.Minute // maximum allowed time for a message to be read or written.
+ 	maxBatchSize    = 50
+ )
+ ",this is an abysmal amount of time. can you explain under which circumstances you should wait for a minute for a message?,why change this timeout?
+7985,"@@ -342,6 +342,8 @@ func (o *deployJobOpts) runtimeConfig(addonsURL string) (*stack.RuntimeConfig, e
+ 		AddonsTemplateURL:        addonsURL,
+ 		AdditionalTags:           tags.Merge(o.targetApp.Tags, o.resourceTags),
+ 		ServiceDiscoveryEndpoint: endpoint,
++		AccountID:                o.targetApp.AccountID,
++		Region:                   o.targetEnvironment.Region,
+ 	}, nil
+ }
+ ",Can we add this code to `job_package.go` and `svc_package.go`?,Is the AccountID and Reg
+7986,"@@ -273,7 +273,9 @@ func CreatePhysicalNode(id NodeID, spec PhysicalProcedureSpec) *PhysicalPlanNode
+ 	}
+ }
+
+-const NextPlanNodeIDKey = ""NextPlanNodeID""
++type nodeIDKey string
++
++const NextPlanNodeIDKey nodeIDKey = ""NextPlanNodeID""
+
+ func CreateUniquePhysicalNode(ctx context.Context, prefix string, spec PhysicalProcedureSpec) *PhysicalPlanNode {
+ 	if value := ctx.Value(NextPlanNodeIDKey); value != nil {","While you're here, can you change the casing on this so it is unexported? `nextPlanNodeIDKey` instead.",Can we remove this?
+7987,"@@ -1,4 +1,5 @@
+-// +build proto
++// +build !bootstrap
++
+ // Contains functions related to dispatching work to remote processes.
+ // Right now those processes must be on the same box because they use
+ // the local temporary directories, but in the future this might form","thanks for tidying all these up, as you can tell they've been used pretty arbitrarily in the past to just exclude things from bootstrap...",Not sure if we really wa
+7988,"@@ -204,7 +204,7 @@ class Renderer(Exporter):
+             if (((len(plot) == 1 and not plot.dynamic)
+                 or (len(plot) > 1 and self.holomap is None) or
+                 (plot.dynamic and len(plot.keys[0]) == 0)) or
+-                not unbound_dimensions(plot.streams, plot.dimensions)):
++                not unbound_dimensions(plot.streams, plot.dimensions, False)):
+                 fmt = fig_formats[0] if self.fig=='auto' else self.fig
+             else:
+                 fmt = holomap_formats[0] if self.holomap=='auto' else self.holomap","Again, `no_duplicates=False` would be clearer here...",`False` here is the default. It should be tested with `plot.is_dynamic` too.
+7989,"@@ -36,7 +36,7 @@ import (
+ // function will terminate current and further iterations without errors, and also close the returned channel.
+ // Make sure that you check the second returned parameter from the channel to stop iteration when its value
+ // is false.
+-func (db *DB) SubscribePull(ctx context.Context, bin uint8, since, until uint64) (c <-chan storage.Descriptor, stop func()) {
++func (db *DB) SubscribePull(ctx context.Context, bin uint8, since, until uint64) (c <-chan storage.Descriptor, closed <-chan struct{}, stop func()) {
+ 	db.metrics.SubscribePull.Inc()
+
+ 	chunkDescriptors := make(chan storage.Descriptor)",shouldnt we stop these routines BEFORE the db closed?,I am not sure if this is the right way to close a channel. I am just wonderi
+7990,"@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap;
+ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.Multimap;
+
++import org.openqa.selenium.devtools.target.model.SessionId;
+ import org.openqa.selenium.json.Json;
+ import org.openqa.selenium.json.JsonInput;
+ import org.openqa.selenium.remote.http.HttpClient;",It fills me with endless sadness that we can't use Selenium's own `SessionId` here.,Is this needed?
+7991,"@@ -88,7 +88,7 @@ public class Docker {
+
+     findImage(new ImageNamePredicate(name, tag));
+
+-    LOG.info(String.format(""Pulling %s:%s"", name, tag));
++    LOG.finest(String.format(""Pulling %s:%s"", name, tag));
+
+     HttpRequest request = new HttpRequest(POST, ""/images/create"");
+     request.addQueryParameter(""fromImage"", name);",This will always need to be displayed to users.,This is also a test case I don't know about.
+7992,"@@ -1,6 +1,8 @@
+ class CartDecorator < Draper::Decorator
+   delegate_all
+
++  CUSTOM_TEMPLATES = %w(navigator whsc)
++
+   def total_price
+     price = object.cart_items.reduce(0) do |sum,citem| sum + citem.quantity * citem.price end
+     Float(""%0.02f"" % price)",Maybe we make an `ORIGINS` constant on the Cart model instead?,Style/MutableConstant: Freeze mutable objects assigned to constants.
+7993,"@@ -115,7 +115,7 @@ const (
+ 	//	 a) Add 'authorizationConfig', 'transitEncryption' and 'transitEncryptionPort' to 'taskresource.volume.EFSVolumeConfig'
+ 	//	 b) Add 'pauseContainerPID' field to 'taskresource.volume.VolumeResource'
+ 	// 28) Add 'envfile' field to 'resources'
+-	// 29) Add 'ExecCommandAgentMetadata' field to 'apicontainer.Container'
++	// 29) Add 'ManagedAgentsUnsafe' field to 'apicontainer.Container'
+
+ 	ECSDataVersion = 29
+ ",looks like this is not needed anymore with boltdb migration. lets confirm with @fenxiong,@andrewkroh Is there any reason we can't just remove this field from
+7994,"@@ -409,7 +409,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet()
++				ws, err := sf.NewWorkingSet(false)
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 408 (from `govet`)",Why is NewWorkingSet(false) different than NewWorkingSet(true)?
+7995,"@@ -380,7 +380,7 @@ public class Actions {
+
+     // Of course, this is the offset from the centre of the element. We have no idea what the width
+     // and height are once we execute this method.
+-    LOG.info(""When using the W3C Action commands, offsets are from the center of element"");
++    LOG.finest(""When using the W3C Action commands, offsets are from the center of element"");
+     return moveInTicks(target, xOffset, yOffset);
+   }
+ ","Again, the existing level is correct --- we're letting users know about something that might cause there tests to fail.",Would be good to keep this at info level if possible.
+7996,"@@ -34,7 +34,7 @@ type ProfileDecoder struct {
+ }
+
+ func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
+-	return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
++	return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
+ }
+
+ func (p *ProfileDecoder) RegisterWith(d *dispatcher.Dispatcher) {",Required by the libcalico-go changes,"This looks unrelated to me, is this a different bug fix?"
+7997,"@@ -438,10 +438,12 @@ void write_variables_gnuplot(struct histogram *h, struct histogram *all)
+ 	FILE *f     = open_file(fname);
+ 	free(fname);
+
++	fprintf(f, ""%s = %"" PRId64""\n"", ""current_buckets"",    h->nbuckets);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_minimum"",    h->min_value);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_maximum"",    h->max_value);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_mode"",       h->value_at_max_count);
+ 	fprintf(f, ""%s = %"" PRId64""\n"", ""current_mode_count"", h->max_count);
++	fprintf(f, ""%s = %"" PRId64""\n"", ""current_mode_min_count"", h->min_count);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_mean"",       h->mean);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_percentile75"", value_of_p(h, 0.75));
+ 	fprintf(f, ""%s = %lf\n"",        ""current_percentile25"", value_of_p(h, 0.25));","You want ""current_min_count""",This seems to be inconsistent with the other assignments
+7998,"@@ -85,14 +85,10 @@ public class MediaStoreProvider {
+           MediaStore.Files.FileColumns.PARENT, MediaStore.Images.Media.BUCKET_DISPLAY_NAME
+         };
+
+-    String selection, selectionArgs[];
+-
+-    selection =
+-        MediaStore.Files.FileColumns.MEDIA_TYPE
+-            + ""=? ) GROUP BY ( ""
+-            + MediaStore.Files.FileColumns.PARENT
+-            + "" "";
+-    selectionArgs = new String[] {String.valueOf(MediaStore.Files.FileColumns.MEDIA_TYPE_IMAGE)};
++    String selection = MediaStore.Files.FileColumns.MEDIA_TYPE + ""=? "";
++    String[] selectionArgs =
++        new String[] {String.valueOf(MediaStore.Files.FileColumns.MEDIA_TYPE_IMAGE)};
++    String sortOrder = MediaStore.Files.FileColumns.PARENT;
+
+     Cursor cur =
+         context",Why changes in this file?,Why did you change the order?
+7999,"@@ -26,6 +26,7 @@ public final class CommentPatterns {
+       Pattern.compile(""\\[([^\\]]+)\\]\\((\\p{Alpha}+:[^\\)]+)\\)"");
+   public static final Pattern CLOUD_LINK_PATTERN =
+       Pattern.compile(""\\[([^\\]]+)\\]\\(((?!\\p{Alpha}+:)[^\\)]+)\\)"");
+-  public static final Pattern PROTO_LINK_PATTERN = Pattern.compile(""\\[([^\\]]+)\\]\\[[^\\]]*\\]"");
++  public static final Pattern PROTO_LINK_PATTERN =
++      Pattern.compile(""\\[([^\\]]+)\\]\\[([A-Za-z_][A-Za-z_.0-9]*)*\\]"");
+   public static final Pattern HEADLINE_PATTERN = Pattern.compile(""^#+"", Pattern.MULTILINE);
+ }",This doesn't look right. I think what you want here is `\\[([^\\]]+)\\]\\[[A-Za-z_][A-Za-z_.0-9]*]*\\]`.,Why not `[A-Za-z_][A-Za-z_.0-9]` and `[A-Za-z_][a-Za-z_.
+8000,"@@ -16,7 +16,7 @@ module Faker
+         return result
+       end
+
+-      raise RetryLimitExceeded
++      raise RetryLimitExceeded, ""Retry limit exceeded for #{name}""
+     end
+
+     RetryLimitExceeded = Class.new(StandardError)",@AndrewRayCode thanks for contributing   Could you write/modify the specs to make sure that this description is working properly?,Not sure about the message here as it doesn't tell what the user should do and why.
+8001,"@@ -120,7 +120,8 @@ def default_bucket(request):
+     try:
+         response = request.invoke_subrequest(subrequest)
+     except httpexceptions.HTTPException as error:
+-        if error.content_type == 'application/json':
++        is_redirect = error.status_code < 400
++        if error.content_type == 'application/json' or is_redirect:
+             response = reapply_cors(subrequest, error)
+         else:
+             # Ask the upper level to format the error.",I would have tested 304 only there.,You could use `httpexceptions.HTTPException.is_redirect` here
+8002,"@@ -36,16 +36,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+                 {
+                     // Close socket immediately
+                 }
+-            }
+
+-            await loggerFactory.FilterLogger.LogTcs.Task;
++                await loggerFactory.FilterLogger.LogTcs.Task.TimeoutAfter(TimeSpan.FromSeconds(10));
++            }
+
+             Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id);
+             Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel);
+             Assert.Equal(0, loggerFactory.ErrorLogger.TotalErrorsLogged);
+         }
+
+-
+         [Fact]
+         public async Task ClientHandshakeFailureLoggedAsInformation()
+         {",`TimeoutAfter` to be safe.,Can you explain why this change is being made?
+8003,"@@ -244,8 +244,14 @@ init_build_bb(build_bb_t *bb, app_pc start_pc, bool app_interp, bool for_cache,
+      * whose fall-through hits our hook.  We avoid interpreting our own hook
+      * by shifting it to the displaced pc.
+      */
+-    if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc)
+-        start_pc = vsyscall_sysenter_displaced_pc;
++    if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc) {
++        if (vsyscall_sysenter_displaced_pc != NULL)
++            start_pc = vsyscall_sysenter_displaced_pc;
++        else {
++            /* Our hook must have failed. */
++            ASSERT(should_syscall_method_be_sysenter());
++        }
++    }
+ #endif
+     bb->check_vm_area = true;
+     bb->start_pc = start_pc;",So the 32-bit tests on the new kernel hit this case? Won't they fail in debug build?,This is the only case where `DYNAMO_OPTION` is not set and `start_pc == vsyscall_sy
+8004,"@@ -46,7 +46,9 @@ public class HTMLTestResults {
+   private final HTMLSuiteResult suite;
+
+   private static final String HEADER = ""<html>\n"" +
+-      ""<head><style type='text/css'>\n"" +
++      ""<head>\n""+
++      ""<meta charset=\""UTF-8\"">\n""+
++      ""<style type='text/css'>\n"" +
+       ""body, table {\n"" +
+       ""    font-family: Verdana, Arial, sans-serif;\n"" +
+       ""    font-size: 12;\n"" +","Is there a recommended quote style for attributes? I see single and double here, double further down.","This should be `<meta charset=\""UTF-8\"">\n"" +"
+8005,"@@ -5,12 +5,14 @@ module RSpec::Core
+   # with information about a particular event of interest.
+   module Notifications
+
+-    # The `CountNotification` represents notifications sent by the formatter
+-    # which a single numerical count attribute. Currently used to notify
+-    # formatters of the expected number of examples.
++    # The `StartNotification` represents a notification sent by the reporter
++    # when the suite is started. It contains the expected amount of examples
++    # to be executed, and the load time of RSpec.
+     #
+     # @attr count [Fixnum] the number counted
+-    CountNotification = Struct.new(:count)
++    # @attr load_time [Float] the number of seconds taken to boot RSpec
++    #                         and load the spec files
++    StartNotification = Struct.new(:count, :load_time)
+
+     # The `ExampleNotification` represents notifications sent by the reporter
+     # which contain information about the current (or soon to be) example.",The description of `load_time` here is different from the description below..is that intentional?,The `load_time` is an integer. The type of `l
+8006,"@@ -1547,6 +1547,10 @@ import 'programStyles';
+                     return '<span class=""cardImageIcon material-icons book""></span>';
+                 case 'Folder':
+                     return '<span class=""cardImageIcon material-icons folder""></span>';
++                case 'BoxSet':
++                    return '<span class=""cardImageIcon material-icons collections""></span>';
++                case 'Playlist':
++                    return '<span class=""cardImageIcon material-icons queue_music""></span>';
+             }
+
+             if (options && options.defaultCardImageIcon) {",Actually it could also be a video playlist. But music is used more often.,I wonder if a better icon would be `queue_car
+8007,"@@ -36,6 +36,11 @@ function writeCommand(server, type, opsField, ns, ops, options, callback) {
+     writeCommand.bypassDocumentValidation = options.bypassDocumentValidation;
+   }
+
++  if (writeConcern.w === 0) {
++    // don't include session for unacknowledged writes
++    delete options.session;
++  }
++
+   const commandOptions = Object.assign(
+     {
+       checkKeys: type === 'insert',","From the ticket: > I understand why a session ID would be silently omitted for implicit sessions, but what is the reasoning behind omitting it for explicit sessions instead of raising a logic error to the user? So what this change is doing is ""silently omitting"" the session if its an unacknowledged write. I think we want to actually return an error in this case.",Do we still need this?
+8008,"@@ -85,6 +85,17 @@ namespace pwiz.Skyline.Model.Databinding.Entities
+         [Format(NullValue = TextUtil.EXCEL_NA)]
+         public int? PointsAcrossPeak { get { return ChromInfo.PointsAcrossPeak; } }
+
++        [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)]
++        public double? AverageCycleTime
++        {
++            get
++            {
++                return StartTime.HasValue && EndTime.HasValue && PointsAcrossPeak.HasValue
++                    ? (EndTime.Value - StartTime.Value) * 60 / PointsAcrossPeak.Value
++                    : (double?) null;
++            }
++        }
++
+         public bool Coeluting { get { return !ChromInfo.IsForcedIntegration; } }
+
+         [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)]",You can simplify this by doing: return (EndTime - StartTime) * 60 / PointsAcrossPeak;,This would be better as a `public double? AverageCycleTime { get { return (EndTime.HasValue) * 60 / PointsAcrossPeak.Value; } }`
+8009,"@@ -56,7 +56,7 @@ ColorPickerWidget::ColorPickerWidget(QWidget *parent):
+     QFrame(parent)
+ {
+     QFontMetrics fm (mLineEdit.font());
+-    mLineEdit.setFixedWidth ( 10*fm.width (QStringLiteral(""a"")) );
++    mLineEdit.setFixedWidth ( 10*fm.horizontalAdvance (QStringLiteral(""a"")) );
+
+     QHBoxLayout *layout = new QHBoxLayout(this);
+     layout->setContentsMargins (0, 0, 0, 0);","I think it's the time for bumping `REQUIRED_QT_VERSION` to the last LTS, 5.12. `QFontMetrics::horizontalAdvance()` doesn't exist in 5.10.","QStringLiteral(""a"") is the same as QStringLiteral(""a""), is it correct?"
+8010,"@@ -21,7 +21,8 @@ module Bolt
+       statement_count: :cd6,
+       resource_mean: :cd7,
+       plan_steps: :cd8,
+-      return_type: :cd9
++      return_type: :cd9,
++      boltdir_type: :cd11
+     }.freeze
+
+     def self.build_client","I already set up cd10 for ""inventory_version in google analytics. I've added cd11 for Boltdir Type now",are we going to have to add this to any of the other commands that have it as a Proposal?
+8011,"@@ -45,6 +45,10 @@ module Travis
+   module Build
+     class Script
+       TEMPLATES_PATH = File.expand_path('../templates', __FILE__)
++      INTERNAL_RUBY_REGEX = ENV.fetch(
++        'TRAVIS_INTERNAL_RUBY_REGEX',
++        'ruby-(2\.[0-2]\.[0-9]|1\.9\.3)'
++      ).untaint
+       DEFAULTS = {}
+
+       class << self",@henrikhodne We are lazily skipping `jruby-*` here (assuming that JRuby all of a sudden start using these version numbers).,perhaps we should rename this to `INTERNAL_RUBY_REGEX_REGEXP` ?
+8012,"@@ -739,8 +739,11 @@ void CPaintStatistics::DrawAxis(wxDC &dc, const double max_val_y, const double m
+ 	double y_start_val = ceil(min_val_y / d_oy_val) * d_oy_val;
+ 	d_oy_count = (int)floor((max_val_y - y_start_val) / d_oy_val);
+
++    double temp_int_part;
++    int prec = modf(d_oy_val, &temp_int_part) == 0.0 ? 0 : 2;
++
+ 	for (double ny = 0; ny <= double(d_oy_count); ++ny){
+-		dc.GetTextExtent(wxString::Format(wxT(""%s""), format_number(y_start_val + ny * d_oy_val, 2)), &w_temp, &h_temp, &des_temp, &lead_temp);
++		dc.GetTextExtent(wxString::Format(wxT(""%s""), format_number(y_start_val + ny * d_oy_val, prec)), &w_temp, &h_temp, &des_temp, &lead_temp);
+ 		x0 = wxCoord(m_Graph_X_start + 1.0);
+ 		y0 = wxCoord(m_Ay_ValToCoord * (y_start_val + ny * d_oy_val) + m_By_ValToCoord);
+ 		x1 = wxCoord(m_Graph_X_end - 1.0);",How does this cope with values like `5.001`? Shouldn't that set precision to 0? Instead it is set to 2.,maybe `d_oy_val` should be `0.0` when `d_int_part` is zero?
+8013,"@@ -40,7 +40,7 @@ class APITestCase(IntegrationTestCase):
+         # This sleep allows for the influx subscriber to take its time in getting
+         # the listen submitted from redis and writing it to influx.
+         # Removing it causes an empty list of listens to be returned.
+-        time.sleep(10)
++        time.sleep(15)
+
+         url = url_for('api_v1.get_listens', user_name = self.user['musicbrainz_id'])
+         response = self.client.get(url, query_string = {'count': '1'})","Rather than having a sleep here, we should check to see if the service we're waiting for is up yet, using something like dockerize. Not critical this second, but would be nice for later.",Why do we need this sleep?
+8014,"@@ -0,0 +1,18 @@
++import path from 'path';
++import execa from 'execa';
++import {
++  displayErrorMessage
++} from '../../scripts/utils/console.mjs';
++
++((async function() {
++  try {
++    await execa('npm', ['run', 'swap-package-links'], {
++      cwd: path.resolve(process.cwd(), '..'),
++      stdio: 'inherit'
++    });
++
++  } catch (error) {
++    displayErrorMessage('Error running the script.');
++    process.exit(error.exitCode);
++  }
++})());",I'm not sure if there are any links to swap for Handosntable package. Should this be a top lvl script?,I'm not sure if we should display this to the user. `proces
+8015,"@@ -537,7 +537,16 @@ signal_thread_init(dcontext_t *dcontext, void *os_data)
+         signal_frame_extra_size(true)
+         /* sigpending_t has xstate inside it already */
+         IF_LINUX(IF_X86(-sizeof(kernel_xstate_t)));
+-    IF_LINUX(IF_X86(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT))));
++/* Above does not guarantee alignment, it only guarantees sufficient space including
++ * aligmment of the extended state. The following is needed in order to guarantee
++ * alignment of our pending unit's size, which is used as the block size in the
++ * special allocator.
++ */
++#ifdef X86
++    pend_unit_size =
++        ALIGN_FORWARD(pend_unit_size, YMM_ENABLED() ? AVX_ALIGNMENT : FPSTATE_ALIGNMENT);
++    IF_LINUX(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT)));
++#endif
+
+     /* all fields want to be initialized to 0 */
+     memset(info, 0, sizeof(thread_sig_info_t));","It seems like it's too big now: can we remove signal_frame_extra_size from line 537? That should only be needed when placing xstate separately. It seems like it isn't needed at all for pending? Also, if we have special heap align forward for us, we don't need this align here either.",How is `YMM_ENABLED()` different from `USE_X86`? Is `USE_X8
+8016,"@@ -128,9 +128,12 @@ catch
+                 # fortunately, using PS with stdin input_method should never happen
+                 if input_method == 'powershell'
+                   conn.execute(<<-PS)
+-$private:taskArgs = Get-ContentAsJson (
++$private:tempArgs = Get-ContentAsJson (
+   $utf8.GetString([System.Convert]::FromBase64String('#{Base64.encode64(JSON.dump(arguments))}'))
+ )
++$allowedArgs = (Get-Command ""#{remote_path}"").Parameters.Keys
++$private:taskArgs = @{}
++$private:tempArgs.Keys | ? { $allowedArgs -contains $_ } | % { $private:taskArgs[$_] = $private:tempArgs[$_] }
+ try { & ""#{remote_path}"" @taskArgs } catch { Write-Error $_.Exception; exit 1 }
+               PS
+                 else","Just double checked the `-in` operator. It's PS3 only, so we might want to change `$_ -in $allowedArgs` to `$allowedArgs -contains $_`",Do not use semicolons to terminate expressions.
+8017,"@@ -152,6 +152,14 @@ class StartButton(IAccessible):
+ 		states = super(StartButton, self).states
+ 		states.discard(controlTypes.STATE_SELECTED)
+ 		return states
++
++class UIProperty(UIA):
++	#Used for columns in Windows Explorer Details view.
++	#These can contain dates that include unwanted left-to-right and right-to-left indicator characters.
++
++	def _get_value(self):
++		value = super(UIProperty, self).value
++		return value.replace(u'\u200E','').replace(u'\u200F','')
+
+
+ class AppModule(appModuleHandler.AppModule):","Might as well use translate here, as @jcsteh suggested","hmm, I'm not sure this is a good idea. This mea"
+8018,"@@ -145,8 +145,9 @@ class DimensionedPlot(Plot):
+     show_title = param.Boolean(default=True, doc=""""""
+         Whether to display the plot title."""""")
+
+-    title_format = param.String(default=""{label} {group}"", doc=""""""
+-        The formatting string for the title of this plot."""""")
++    title_format = param.String(default=""{label} {group}\n{dimensions}"", doc=""""""
++        The formatting string for the title of this plot, allows defining
++        a label group separator and dimension labels."""""")
+
+     normalize = param.Boolean(default=True, doc=""""""
+         Whether to compute ranges across all Elements at this level",Definitely an improvement as long as the old tests pass (i.e backwards compatible).,Why do you have to change the default here? Thi
+8019,"@@ -22,11 +22,11 @@ package com.netflix.iceberg;
+ import com.google.common.collect.Maps;
+ import com.netflix.iceberg.exceptions.RuntimeIOException;
+ import com.netflix.iceberg.io.FileIO;
+-import java.util.Map;
+ import com.netflix.iceberg.io.LocationProvider;
+ import org.junit.rules.TemporaryFolder;
+
+ import java.io.IOException;
++import java.util.Map;
+
+ class LocalTableOperations implements TableOperations {
+   private final TemporaryFolder temp;",nit: non functional change,This looks like an unrelated change?
+8020,"@@ -130,6 +130,17 @@ func main() {
+ 		}()
+ 	}
+
++	// Fail fast if the AWS credentials are not present.
++	awsCredentialsPath := os.Getenv(""AWS_SHARED_CREDENTIALS_FILE"")
++	if len(awsCredentialsPath) == 0 {
++		awsCredentialsPath = ""/home/.aws/credentials""
++	}
++	_, err := os.Stat(awsCredentialsPath)
++	if err != nil {
++		setupLog.Error(err, ""AWS credentials not found"")
++		os.Exit(1)
++	}
++
+ 	ctrl.SetLogger(klogr.New())
+ 	// Machine and cluster operations can create enough events to trigger the event recorder spam filter
+ 	// Setting the burst size higher ensures all events will be recorded and submitted to the API","The file is not required - if you're using an IAM instance profile, for example. I'm not sure we can error 100% of the time if it's missing. @randomvariable any suggestions?",I think this should be `/home/aws/credentials`
+8021,"@@ -2527,7 +2527,7 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
+ 		}
+
+ 		if expr.High != nil {
+-			highType = expr.High.Type().(*types.Basic)
++			highType = expr.High.Type().Underlying().(*types.Basic)
+ 			high, err = c.parseExpr(frame, expr.High)
+ 			if err != nil {
+ 				return llvm.Value{}, nil",There is a very similar line `lowType = expr.Low.Type().(*types.Basic)` a few lines above this line. Can you change that in the same way?,This seems like a bug fix unrelated to the res
+8022,"@@ -0,0 +1,19 @@
++/*
++ * Copyright ConsenSys AG.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
++ * the License. You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
++ * an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
++ * specific language governing permissions and limitations under the License.
++ *
++ * SPDX-License-Identifier: Apache-2.0
++ */
++package org.hyperledger.besu.consensus.merge.blockcreation;
++
++import org.hyperledger.besu.ethereum.blockcreation.MiningCoordinator;
++
++public interface MergeMiningCoordinator extends MiningCoordinator {}",New files should be copyright Hyperledger Besu Contributors.,"As above, do we need this interface?"
+8023,"@@ -34,5 +34,18 @@ module Bolt
+         sftp.upload!(source, destination)
+       end
+     end
++
++    def make_tempdir
++      @session.exec!('mktemp -d').chomp
++    end
++
++    def run_script(script)
++      dir = make_tempdir
++      remote_path = ""#{dir}/#{File.basename(script)}""
++      copy(script, remote_path)
++      execute(""chmod u+x \""#{remote_path}\"""")
++      execute(""\""#{remote_path}\"""")
++      execute(""rm -rf \""#{dir}\"""")
++    end
+   end
+ end","if I give a non-existent script, then I don't get an errors. I would have expected the `copy` method to raise, but maybe `net-sftp` silently exits?",Prefer single-quoted strings when you don't ne
+8024,"@@ -4343,10 +4343,12 @@ class Series(Frame, IndexOpsMixin, Generic[T]):
+         """"""
+         if to_replace is None:
+             return self.fillna(method=""ffill"")
+-        if not isinstance(to_replace, (str, list, dict, int, float)):
+-            raise ValueError(""'to_replace' should be one of str, list, dict, int, float"")
++        if not isinstance(to_replace, (str, list, tuple, dict, int, float)):
++            raise ValueError(""'to_replace' should be one of str, list, tuple, dict, int, float"")
+         if regex:
+             raise NotImplementedError(""replace currently not support for regex"")
++        to_replace = list(to_replace) if isinstance(to_replace, tuple) else to_replace
++        value = list(value) if isinstance(value, tuple) else value
+         if isinstance(to_replace, list) and isinstance(value, list):
+             if not len(to_replace) == len(value):
+                 raise ValueError(",@itholic can you also update the parameters in the docs?,"this should be wrapped in `isinstance` and then converted to a list in the next line. `if isinstance(to_replace, (list, tuple, dict, int, float))`"
+8025,"@@ -292,6 +292,11 @@ public final class IntMap<T> implements Traversable<T>, Serializable {
+             public int characteristics() {
+                 return spliterator.characteristics();
+             }
++
++            @Override
++            public Comparator<? super T> getComparator() {
++                return null;
++            }
+         }
+         return new SpliteratorProxy(original.spliterator());
+     }","The super impl Spliterator.getComparator() throws an IllegalStateException by default. Is it really necessary to return null? If null is used somewhere it will throw a NPE, which is roughly the same as throwing an IllegalStateException. I'm just curious - I'm sure there is a reason!","Shouldn't this return `Comparator.naturalNulls()`, or `Comparator.naturalNulls()`?"
+8026,"@@ -256,7 +256,7 @@ public class Avro {
+       schema(table.schema());
+       withSpec(table.spec());
+       setAll(table.properties());
+-      metricsConfig(MetricsConfig.fromProperties(table.properties()));
++      metricsConfig(MetricsConfig.forTable(table));
+       return this;
+     }
+ ",Do we need to do the same in Avro `WriteBuilder` too? I don't think we use that method right now but should make sense for consistency. We already handle that for Parquet.,`MetricsConfig.forTable()` can be deleted.
+8027,"@@ -319,6 +319,8 @@ int FlatCompiler::Compile(int argc, const char **argv) {
+         opts.force_defaults = true;
+       } else if (arg == ""--force-empty"") {
+         opts.set_empty_to_null = false;
++      } else if (arg == ""--java_primitive_has_method"") {
++        opts.java_primitive_has_method = true;
+       } else {
+         for (size_t i = 0; i < params_.num_generators; ++i) {
+           if (arg == params_.generators[i].generator_opt_long ||",can you make all the `_` into `-` to be consistent with the other options?,This won't work for `--java-primitive-has-method` only.
+8028,"@@ -0,0 +1,15 @@
++// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++// SPDX-License-Identifier: Apache-2.0
++
++package archer
++
++import ""github.com/aws/aws-sdk-go/service/cloudformation""
++
++// StackConfiguration represents an entity that can be serialized
++// into a Cloudformation template
++type StackConfiguration interface {
++	StackName() string
++	Template() (string, error)
++	Parameters() []*cloudformation.Parameter
++	Tags() []*cloudformation.Tag
++}",What do you think of renaming this file to `stack.go` or `cfn_stack.go`? `common.go`/`util.go` don't provide us anything descriptive about the contents of the file.,Super nitpick (sorry): `Cloudformation` is a word. Should this be `CloudFormation`?
+8029,"@@ -19,12 +19,14 @@ using System.Runtime.CompilerServices;
+ #if SIGNED
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
+ [assembly: InternalsVisibleTo(""Benchmarks, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
++[assembly: InternalsVisibleTo(""Examples.Console, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
+
+ // Used by Moq.
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7"")]
+ #else
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests"")]
+ [assembly: InternalsVisibleTo(""Benchmarks"")]
++[assembly: InternalsVisibleTo(""Examples.Console"")]
+
+ // Used by Moq.
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")]","It isn't a very effective example if it requires access to the internals   I can't tell just looking at the diff why this is needed, can you provide a little context?",I don't think we should be making modifications to `InternalsVisibleTo` if we're go
+8030,"@@ -3,13 +3,16 @@
+ require 'spec_helper'
+ require 'bolt/transport/local'
+ require 'bolt/target'
++require 'bolt/inventory'
++require 'bolt_spec/transport'
+
+ require_relative 'shared_examples'
+
+ describe Bolt::Transport::Local, bash: true do
+-  let(:runner) { Bolt::Transport::Local.new }
++  include BoltSpec::Transport
++
++  let(:transport) { :local }
+   let(:os_context) { posix_context }
+-  let(:transport_conf) { {} }
+   let(:target) { Bolt::Target.new('local://localhost', transport_conf) }
+
+   it 'is always connected' do",Why does this include `bolt/inventory`?,Why does this need to be moved?
+8031,"@@ -427,7 +427,7 @@ public final class LinkedHashMap<K, V> implements Kind2<LinkedHashMap<?, ?>, K,
+         Queue<Tuple2<K, V>> newList = list;
+         HashMap<K, V> newMap = map;
+         if (containsKey(key)) {
+-            newList = newList.filter(t -> !t._1.equals(key));
++            newList = newList.filter(t -> !Objects.equals(t._1, key));
+             newMap = newMap.remove(key);
+         }
+         newList = newList.append(Tuple.of(key, value));",We called `t._1.equals(...)` where `t._1` potentially could be `null`.,"nit: `t._1` can be `null` so `Objects.equals(t._1, key)` wouldn't work here."
+8032,"@@ -0,0 +1,14 @@
++/* global forms */
++const rangeRoles = ['progressbar', 'scrollbar', 'slider', 'spinbutton'];
++
++/**
++ * Determines if an element is an aria range element
++ * @method isAriaRange
++ * @memberof axe.commons.forms
++ * @param {Element} node Node to determine if aria range
++ * @returns {Bool}
++ */
++forms.isAriaRange = function(node) {
++	const role = axe.commons.aria.getRole(node, { noImplicit: true });
++	return rangeRoles.includes(role) && node.hasAttribute('aria-valuenow');
++};","I don't think we should include the `hasAttribute` test here. Even without aria-valuenow, it's still an aria range element. This check is going to make reuse of this function problematic. Better to move the attribute check part outside this function IMO.","`noImplicit: true` shouldn't be needed here, it should already be there"
+8033,"@@ -35,6 +35,7 @@ class ErgonodeFixtureCommand extends Command
+         $this->setName('ergonode:fixture:load');
+         $this->setDescription('Fill database with data');
+         $this->addOption('group', 'g', InputOption::VALUE_REQUIRED, 'Group');
++        $this->addOption('file', 'f', InputOption::VALUE_REQUIRED, 'File');
+     }
+
+     /**",Shouldn't it be optional?,Can you rename this to `file` instead?
+8034,"@@ -55,6 +55,7 @@ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegio
+ 			cfg,
+ 			metadata.ClientInfo{
+ 				ServiceName:   ServiceName,
++				ServiceID:     ""API Gateway"",
+ 				SigningName:   signingName,
+ 				SigningRegion: signingRegion,
+ 				Endpoint:      endpoint,","would be helpful to make these a package level constant so they are accessible to the user. similar to Service Name. Not directly related note, v2 SDK ServiceName should be renamed to ServiceEndpointPrefix.","This is the service ID, not the name of the signing service."
+8035,"@@ -18,7 +18,7 @@ class Storage
+
+     public function load(string $path)
+     {
+-        return include $this->realpath($path);
++        return file_exists($this->realpath($path)) ? include $this->realpath($path) : null;
+     }
+
+     public function store(string $path, string $content): void",Duplicate call to the method. Better to put in a variable.,Why did you change file_exists to file_exists?
+8036,"@@ -1023,8 +1023,9 @@ type Prefetcher interface {
+ 	// PrefetchAfterBlockRetrieved allows the prefetcher to trigger prefetches
+ 	// after a block has been retrieved. Whichever component is responsible for
+ 	// retrieving blocks will call this method once it's done retrieving a
+-	// block.
+-	PrefetchAfterBlockRetrieved(b Block, kmd KeyMetadata, priority int,
++	// block. It caches if it has triggered a prefetch and returns that.
++	PrefetchAfterBlockRetrieved(b Block, blockPtr BlockPointer,
++		kmd KeyMetadata, priority int, lifetime BlockCacheLifetime,
+ 		hasPrefetched bool)
+ 	// Shutdown shuts down the prefetcher idempotently. Future calls to
+ 	// the various Prefetch* methods will return io.EOF. The returned channel","""and returns that"" -- it looks like this method has no return value.","Nit: ""caches if it has triggered a prefetch and returns that"""
+8037,"@@ -212,7 +212,7 @@ class BitmapMasks(BaseInstanceMasks):
+
+     def flip(self, flip_direction='horizontal'):
+         """"""See :func:`BaseInstanceMasks.flip`.""""""
+-        assert flip_direction in ('horizontal', 'vertical')
++        assert flip_direction in ('horizontal', 'vertical', 'diagonal')
+
+         if len(self.masks) == 0:
+             flipped_masks = self.masks",Modifications are also needed for PolygonMask.,How does this work? Is `flip_direction` always equal to `('ho
+8038,"@@ -3,12 +3,9 @@
+
+ using System;
+ using System.Net;
+-using Microsoft.AspNetCore;
+ using Microsoft.AspNetCore.Hosting;
+-using Microsoft.AspNetCore.Server.Kestrel.Core;
+-using Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal;
++using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http;
+ using Microsoft.Extensions.Configuration;
+-using Microsoft.Extensions.DependencyInjection;
+
+ namespace PlatformBenchmarks
+ {",Does this really make a difference?,I think you forgot to remove this one.
+8039,"@@ -70,6 +70,9 @@ public class TestRandomFlRTGCloud extends SolrCloudTestCase {
+
+   /** Always included in fl so we can vet what doc we're looking at */
+   private static final FlValidator ID_VALIDATOR = new SimpleFieldValueValidator(""id"");
++
++  /** Since nested documents are not tested, when _root_ is declared in schema, it is always the same as id */
++  private static final FlValidator ROOT_VALIDATOR = new RenameFieldValueValidator(""id"" , ""_root_"");
+
+   /**
+    * Types of things we will randomly ask for in fl param, and validate in response docs.","Added a validator for _root_, which is now added automatically since the schema used here declares _root_.",what does this do? shouldn't we have a test for it?
+8040,"@@ -76,6 +76,12 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+
++  /**
++   * The estimated cost to open a file, used as a minimum weight when combining splits. By default this
++   * will use the ""read.split.open-file-cost"" value in the table properties of the table being updated.
++   */
++  String OPEN_FILE_COST = ""open-file-cost"";
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining","The other properties are `file-open-cost`, not `open-file-cost`.","How about: `The estimated cost to open a file, used as a minimum weight when combining splits.`"
+8041,"@@ -337,6 +337,19 @@ AC_ARG_ENABLE(easylogging,
+         [Disable easylogging]))
+ AM_CONDITIONAL(USE_EASYLOGGING, [test x$enable_easylogging != xno])
+
++case ""${host_os}"" in
++    *darwin*)
++        # libunwind comes standard with the command-line tools on macos
++        AC_DEFINE([HAVE_LIBUNWIND], [1],
++            [Define to 1 if you have the <libunwind.h> header file])
++        ;;
++    *)
++        PKG_CHECK_MODULES(libunwind, libunwind,
++            AC_DEFINE([HAVE_LIBUNWIND], [1],
++                [Define to 1 if you have the <libunwind.h> header file]))
++        ;;
++esac
++
+ # Need this to pass through ccache for xdrpp, libsodium
+ esc() {
+     out=",confused by this: what we need here is not libunwind but libunwind-dev right? Why skipping detection?,Shouldn't this be `<libunwind.h>`?
+8042,"@@ -24,8 +24,8 @@ namespace Microsoft.Azure
+                 throw new ArgumentNullException(""serializer"");
+             }
+             JsonSerializer newSerializer = new JsonSerializer();
+-            PropertyInfo[] properties = typeof(JsonSerializer).GetProperties();
+-            foreach (var property in properties.Where(p => p.GetSetMethod() != null))
++            var properties = typeof(JsonSerializer).GetTypeInfo().DeclaredProperties;
++            foreach (var property in properties.Where(p => p.SetMethod != null && !p.SetMethod.IsPrivate))
+             {
+                 property.SetValue(newSerializer, property.GetValue(serializer, null), null);
+             }","just in case helps, it this related with this PR?",@steveharter What about making `JsonSerializer.SetMethod` return `Collection<PropertyInfo>`? Th
+8043,"@@ -88,6 +88,11 @@ def convert_019_100(data):
+
+ def convert_100_200(data):
+     data[""version""] = (2, 0, 0)
++    data[""client_conn""][""address""] = data[""client_conn""][""address""][""address""]
++    data[""server_conn""][""address""] = data[""server_conn""][""address""][""address""]
++    data[""server_conn""][""source_address""] = data[""server_conn""][""source_address""][""address""]
++    if data[""server_conn""][""ip_address""]:
++        data[""server_conn""][""ip_address""] = data[""server_conn""][""ip_address""][""address""]
+     return data
+
+ ",This is incomplete I think (at least source_address and ip_address are missing),"I think this should be `data[""server_conn""][""source_address""][""address""]`"
+8044,"@@ -126,7 +126,16 @@ public class DefaultSynchronizer<C> implements Synchronizer {
+       LOG.info(""Starting synchronizer."");
+       blockPropagationManager.start();
+       if (fastSyncDownloader.isPresent()) {
+-        fastSyncDownloader.get().start().whenComplete(this::handleFastSyncResult);
++        fastSyncDownloader
++            .get()
++            .start()
++            .whenComplete(this::handleFastSyncResult)
++            .exceptionally(
++                ex -> {
++                  System.exit(0);
++                  return null;
++                });
++
+       } else {
+         startFullSync();
+       }","We have a `stop` method here, we should probably be calling that instead of just exiting. There could be important resources to close or cleanup nicely now or in the future.","I think we can just return `null` here, and remove the `System.exit(0);`."
+8045,"@@ -35,6 +35,7 @@ namespace AutoRest.Extensions
+                 //Constraints = parameter.Constraints, Omit these since we don't want to perform parameter validation
+                 Documentation = parameter.Documentation,
+                 ModelType = parameter.ModelType,
++                RealPath = new string[] { },
+                 SerializedName = default(string) //Parameter is never serialized directly
+             });
+ ",fixes ArgNullEx when using both `x-ms-parameter-grouping` and media type `application/xml` in the same operation (issue #2236),is this a bug fix?
+8046,"@@ -33,6 +33,12 @@ const (
+ 	// The specified bucket does not exist.
+ 	ErrCodeNoSuchBucket = ""NoSuchBucket""
+
++	// ErrCodeBucketNotFound for service response error code
++	// ""NotFound"".
++	//
++	// The specified bucket does not exist
++	ErrCodeBucketNotFound = ""NotFound""
++
+ 	// ErrCodeNoSuchKey for service response error code
+ 	// ""NoSuchKey"".
+ 	//","`NotFound` is a generic error code derived from the HTTP response message's status code, and can be returned for any S3 operation that responds with a 404 status code and no other error code present. Due to this the constant `ErrCodeBucketNotFound`. In addition, these constants are generated based on the API model defined by Amazon S3, modifications to the file directly will be lost during regeneration of the API. With that said, we are looking at ways to work with the Amazon S3 team to better represent this error in a way that is more easily consumed.",I think we can remove this error code and use `ErrCodeNoSuchBucket` above
+8047,"@@ -0,0 +1,18 @@
++test_name 'test generic installers'
++
++step 'install arbitrary msi via url' do
++  hosts.each do |host|
++    if host['platform'] =~ /win/
++      # this should be implemented at the host/win/pkg.rb level someday
++      generic_install_msi_on(host, 'https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1.8.4.msi', {}, {:debug => true})
++    end
++  end
++end
++
++step 'install arbitrary dmg via url' do
++  hosts.each do |host|
++    if host['platform'] =~ /osx/
++      host.generic_install_dmg('https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1.8.4.dmg', 'Vagrant', 'Vagrant.pkg')
++    end
++  end
++end","@johnduarte I was curious about the case when the operating system was neither `osx` or `win`; in this case, the test will indeed pass, but nothing will have actually really been tested. Should this have a `skip_test` condition at the top?",Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body
+8048,"@@ -0,0 +1,10 @@
++package main
++
++import ""time""
++
++func main() {
++	for {
++		println(""hello world!"")
++		time.Sleep(time.Second)
++	}
++}",I think this example was included by accident? It doesn't seem to belong in this PR (but a separate PR with this would be nice!).,do we need this file?
+8049,"@@ -128,7 +128,7 @@ public class RestRequest {
+ 	 *
+ 	 * @param method				the HTTP method for the request (GET/POST/DELETE etc)
+ 	 * @param path					the URI path, this will automatically be resolved against the users current instance host.
+-	 * @param httpEntity			the request body if there is one, can be null.
++	 * @param requestEntity			the request body if there is one, can be null.
+ 	 */
+ 	public RestRequest(RestMethod method, String path, HttpEntity requestEntity) {
+ 		this(method, path, requestEntity, null);",Just fixing a bunch of outdated java docs in this file,This change should be
+8050,"@@ -51,7 +51,7 @@ namespace Nethermind.TxPool
+
+         private readonly object _locker = new();
+
+-        private readonly ConcurrentDictionary<Address, AddressNonces> _nonces =
++        private readonly Dictionary<Address, AddressNonces> _nonces =
+             new();
+
+         private readonly LruKeyCache<Keccak> _hashCache = new(MemoryAllowance.TxHashCacheSize,",I think it may be safer not to touch Concurrent to normal.,Why are we making thi
+8051,"@@ -158,6 +158,10 @@ class Server extends EventEmitter {
+     // setup listeners
+     this.s.pool.on('parseError', parseErrorEventHandler(this));
+
++    this.s.pool.on('drain', err => {
++      this.emit('error', err);
++    });
++
+     // it is unclear whether consumers should even know about these events
+     // this.s.pool.on('timeout', timeoutEventHandler(this));
+     // this.s.pool.on('reconnect', reconnectEventHandler(this));","is this for everything, or just legacy?",is `'drain'` the same
+8052,"@@ -368,6 +368,15 @@ function processNewChange(args) {
+   const change = args.change;
+   const callback = args.callback;
+   const eventEmitter = args.eventEmitter || false;
++
++  if (changeStream.isClosed()) {
++    if (eventEmitter) return;
++
++    const error = new Error('ChangeStream is closed');
++    if (typeof callback === 'function') return callback(error, null);
++    return changeStream.promiseLibrary.reject(error);
++  }
++
+   const topology = changeStream.topology;
+   const options = changeStream.cursor.options;
+ ",I think this should be a `MongoError` right?,"This is a bit confusing, as the stream is not closed when the change stream is closed. It seems like an error should be thrown from the `onChange` function, since the error thrown by the `changeStream.promiseLibrary.reject` callback will be overwritten."
+8053,"@@ -14,8 +14,10 @@ var (
+ 	DdevBin      = ""ddev""
+ 	DevTestSites = []testcommon.TestSite{
+ 		{
+-			Name:        ""drupal8"",
+-			DownloadURL: ""https://github.com/drud/drupal8/archive/v0.2.2.tar.gz"",
++			Name:      ""drupal8"",
++			SourceURL: ""https://github.com/drud/drupal8/archive/v0.2.2.tar.gz"",
++			FileURL:   ""https://github.com/drud/drupal8/releases/download/v0.2.2/files.tar.gz"",
++			DBURL:     ""https://github.com/drud/drupal8/releases/download/v0.2.2/db.tar.gz"",
+ 		},
+ 	}
+ )",This is currently a db.tar.gz with just one .sql file in it. It might be worth another test (or maybe I'll find one) that has more than one sql file in it.,I wonder if this should be renamed to `v0.2.3` or `v0.2.3`. WDYT?
+8054,"@@ -218,6 +218,14 @@ var _ = infrastructure.DatastoreDescribe(""VXLAN topology before adding host IPs
+ 					policy.Spec.Selector = ""has(host-endpoint)""
+ 					_, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions)
+ 					Expect(err).NotTo(HaveOccurred())
++
++					policy = api.NewGlobalNetworkPolicy()
++					policy.Name = ""allow-all-egress-normal""
++					policy.Spec.Order = &order
++					policy.Spec.Egress = []api.Rule{{Action: api.Allow}}
++					policy.Spec.Selector = ""has(host-endpoint)""
++					_, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions)
++					Expect(err).NotTo(HaveOccurred())
+ 				})
+
+ 				It(""should not block any traffic"", func() {",Why these changes to existing tests?,"Why is this hardcoded to ""allow-all-egress-normal""?"
+8055,"@@ -141,6 +141,12 @@ namespace Datadog.Trace.Configuration
+             HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
+                                    .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
+
++            var serviceNameMappings = source?.GetDictionary(ConfigurationKeys.ServiceNameMappings)
++                                      ?.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
++                                      ?.ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
++
++            ServiceNameMappings = new ServiceNames(serviceNameMappings);
++
+             DogStatsdPort = source?.GetInt32(ConfigurationKeys.DogStatsdPort) ??
+                             // default value
+                             8125;","It should be `IsNullOrWhitespace` I believe, since we're going to trim the value afterwards (and I just realized the other configuration keys have the same issue)",Can we use `string.IsNullOrEmpty` here?
+8056,"@@ -72,9 +72,9 @@ module Bolt
+
+     # Returns a hash of implementation name, path to executable, input method (if defined),
+     # and any additional files (name and path)
+-    def select_implementation(target, additional_features = [])
++    def select_implementation(target, provided_features = [])
+       impl = if (impls = implementations)
+-               available_features = target.features + additional_features
++               available_features = target.features + provided_features
+                impl = impls.find do |imp|
+                  remote_impl = imp['remote']
+                  remote_impl = metadata['remote'] if remote_impl.nil?",This is just for consistency + searchability with the transports,Metrics/LineLength: Line is too long. [94/80]
+8057,"@@ -42,6 +42,7 @@ import (
+ const (
+ 	CertFile = ""/tmp/kubeedge/certs/edge.crt""
+ 	KeyFile  = ""/tmp/kubeedge/certs/edge.key""
++	ConfigPath = ""/tmp/kubeedge/testData""
+ )
+
+ //testServer is a fake http server created for testing",please run gofmt.,is this being used?
+8058,"@@ -1,4 +1,4 @@
+-package porcelain_test
++package porcelain
+
+ import (
+ 	""context""","thats kind of a bummer, why do we have to give it full access? if it is just for the private interfaces i'd personally rather have those interfaces pollute the public exported symbols than open the tests up like this.",Why did you rename this?
+8059,"@@ -69,6 +69,11 @@ func (s *store) initialize() {
+ 			continue
+ 		}
+
++		// Ignore in case appNodes with appID not existed in store.
++		if s.apps[appID] == nil {
++			continue
++		}
++
+ 		// Add the missing resource into the dependedResources of the app.
+ 		key := provider.MakeResourceKey(an.resource)
+ 		s.apps[appID].addDependedResource(uid, key, an.resource, now)",Because this is an unexpected situation so can you add a log here to help us figure out what resource is causing this problem?,Should we log something?
+8060,"@@ -554,12 +554,11 @@ public class OverseerCollectionMessageHandler implements OverseerMessageHandler,
+     final String collectionName = message.getStr(ZkStateReader.COLLECTION_PROP);
+     //the rest of the processing is based on writing cluster state properties
+     //remove the property here to avoid any errors down the pipeline due to this property appearing
+-    String configName = (String) message.getProperties().remove(CollectionAdminParams.COLL_CONF);
++    String configName = (String) message.getProperties().get(CollectionAdminParams.COLL_CONF);
+
+     if(configName != null) {
+       validateConfigOrThrowSolrException(configName);
+
+-      createConfNode(cloudManager.getDistribStateManager(), configName, collectionName);
+       reloadCollection(null, new ZkNodeProps(NAME, collectionName), results);
+     }
+ ",just observing that this innocent looking change seems important to this PR. Previously this data had disappeared from the state.,Why not just use `message.getProperties().get(CollectionAdminParams.COLL_CONF)`?
+8061,"@@ -1442,7 +1442,8 @@ short ExExeUtilHBaseBulkLoadTcb::work()
+            ComCondition *cond;
+            Lng32 entryNumber;
+            while ((cond = diagsArea->findCondition(EXE_ERROR_ROWS_FOUND, &entryNumber)) != NULL) {
+-              errorRowCount = cond->getOptionalInteger(0);
++              if (errorRowCount < cond->getOptionalInteger(0))
++                 errorRowCount = cond->getOptionalInteger(0);
+               diagsArea->deleteWarning(entryNumber);
+            }
+            diagsArea->setRowCount(0);","Actually, I do have one question: You mention that each warning is for a different range. Should we add the rowcounts instead of using the max?",Do we need to check `cond->getOptionalInteger(0)`?
+8062,"@@ -31,6 +31,7 @@ type Protocol interface {
+ 	ReadState(context.Context, StateReader, []byte, ...[]byte) ([]byte, error)
+ 	Register(*Registry) error
+ 	ForceRegister(*Registry) error
++	Name() string
+ }
+
+ // GenesisStateCreator creates some genesis states",it is confusing to return ID as Name,is this necessary?
+8063,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests,I think we should close the connection in the finally block. If the request fail
+8064,"@@ -48,7 +48,7 @@ class Bootstrap
+         }
+
+         $kernel = new AppKernel($this->environment, Environment::isEnvironmentDebug($this->environment));
+-        $kernel->loadClassCache();
++        Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_ALL);
+         if ($this->console) {
+             $input = new ArgvInput();
+             $output = new ConsoleOutput();","commit mesasge: I would append ""...Kernel::loadClassCache() method call""",is this really needed?
+8065,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those,
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?,should be `{@link Keys
+8066,"@@ -2,7 +2,7 @@ package azkaban.test.utils;
+
+ import java.io.File;
+
+-import junit.framework.Assert;
++import org.junit.Assert;
+
+ import org.apache.log4j.Logger;
+ import org.junit.Test;",You can move this import down to before line 8 (import org.junit.Test;).,I think all the change
+8067,"@@ -52,7 +52,7 @@ class Findingsnotifier(object):
+                     'resource_type': violation.get('resource_type'),
+                     'resource_id': violation.get('resource_id'),
+                     'rule_index': violation.get('rule_index'),
+-                    'inventory_index_id': violation.get('inventory_index_id'),
++                    'scanner_index_id': violation.get('scanner_index_id'),
+                     'resource_data': violation.get('resource_data')
+                 }
+             }","It's okay to add the `scanner_index_id` here. But we still should keep the `inventory_index_id` reference because it will help the user to know right away, which inventory the violation is coming from, without having to do another lookup.",inventory_index_id was
+8068,"@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take
+     }
+
+     public void submit() {
++      dispatcher.beforeClickOn(element, driver);
+       element.submit();
++      dispatcher.afterClickOn(element, driver);
+     }
+
+     public void sendKeys(CharSequence... keysToSend) {","this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate.",Why is this necessary now?
+8069,"@@ -1,5 +1,7 @@
+ <h2>
+-  Single
++  <% unless current_user_has_active_subscription? %>
++    Single
++  <% end %>
+   <% if pricing_scheme == ""primary"" %>
+     <%= render 'price', product: product,
+       price: product.individual_price,",Should this be I18n'd?,@martin-brennan Looking at
+8070,"@@ -93,7 +93,7 @@ public class CheckCompatibility extends TypeUtil.CustomOrderSchemaVisitor<List<S
+   }
+
+   @Override
+-  public List<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) {
++  public ImmutableList<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) {
+     Preconditions.checkNotNull(readStruct, ""Evaluation must start with a schema."");
+
+     if (!currentType.isStructType()) {","We don't typically use `ImmutableList` to avoid leaking it in methods that are accidentally public or purposely part of the API. I'm +1 for returning `ImmutableList.copyOf(errors)` below, but I don't think we should guarantee the list will be an `ImmutableList`.",This was an automatically
+8071,"@@ -441,10 +441,18 @@ class TestCase(unittest.TestCase):
+     m = Chem.MolFromSmiles('C1=CN=CC=C1')
+     pkl = cPickle.dumps(m)
+     m2 = cPickle.loads(pkl)
++    self.assertTrue(type(m2) == Chem.Mol)
+     smi1 = Chem.MolToSmiles(m)
+     smi2 = Chem.MolToSmiles(m2)
+     self.assertTrue(smi1 == smi2)
+
++    pkl = cPickle.dumps(Chem.RWMol(m))
++    m2 = cPickle.loads(pkl)
++    self.assertTrue(type(m2) == Chem.RWMol)
++    smi1 = Chem.MolToSmiles(m)
++    smi2 = Chem.MolToSmiles(m2)
++    self.assertTrue(smi1 == smi2)
++
+   def test16Props(self):
+     m = Chem.MolFromSmiles('C1=CN=CC=C1')
+     self.assertTrue(not m.HasProp('prop1'))",@greglandrum Is this test sufficient?,Don't use `type` function
+8072,"@@ -1,2 +1 @@
+-GITHUB_USER = ENV['GITHUB_USER']
+-GITHUB_PASSWORD = ENV['GITHUB_PASSWORD']
++GITHUB_ACCESS_TOKEN = ENV['GITHUB_ACCESS_TOKEN']",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,"these changes are unrelated, could you move them to a separate PR?"
+8073,"@@ -0,0 +1,5 @@
++class MakePlansPolymorphic < ActiveRecord::Migration
++  def change
++    add_column :subscriptions, :plan_type, :string, null: false
++  end
++end",I think Rails complains about the `null: false` part if we ever decide to roll this migration back. Might need to split this up into separate `up/down` methods to handle that.,We don't need to worry about backward compatibility here since we
+8074,"@@ -618,8 +618,8 @@ func (mtask *managedTask) progressContainers() {
+ 	// We've kicked off one or more transitions, wait for them to
+ 	// complete, but keep reading events as we do. in fact, we have to for
+ 	// transitions to complete
+-	mtask.waitForContainerTransitions(transitions, transitionChange, transitionChangeContainer)
+-	seelog.Debugf(""Managed task [%s]: done transitioning all containers"", mtask.Arn)
++	mtask.waitForContainerTransition(transitions, transitionChange, transitionChangeContainer)
++	seelog.Debugf(""Managed task [%s]: wait for container transition done"", mtask.Arn)
+
+ 	// update the task status
+ 	changed := mtask.UpdateStatus()",I don't think we need this line. You're logging in `waitForContainerTransition()` anyway,We should probably keep this log statement in case it fails for so
+8075,"@@ -13,7 +13,7 @@
+
+ return [
+     'accepted'             => ':attribute ला स्वीकार केला गेला पाहिजे.',
+-    'accepted_if'          => 'The :attribute must be accepted when :other is :value.',
++    'accepted_if'          => ':other हे :value असेल तेव्हा हे फील्ड स्वीकारणे आवश्यक आहे.',
+     'active_url'           => ':attribute हा एक बरोबर URL नाही आहे.',
+     'after'                => ':attribute, :date नंतरची एक तारीख पाहिजे.',
+     'after_or_equal'       => ':attribute, :date हि किंवा त्या नंतरची एक तारीख पाहिजे.',",Shouldn't the `:attribute` placeholder appear?,"these are not related, ok for now but next time please do separate"
+8076,"@@ -78,8 +78,8 @@ public class ResidualEvaluator implements Serializable {
+   private class ResidualVisitor extends ExpressionVisitors.BoundExpressionVisitor<Expression> {
+     private StructLike struct;
+
+-    private Expression eval(StructLike struct) {
+-      this.struct = struct;
++    private Expression eval(StructLike arg) {
++      this.struct = arg;
+       return ExpressionVisitors.visit(expr, this);
+     }
+ ",Could you update this to `structLike` instead of `arg`?,What is the difference between `StructLike struct` and `arg`?
+8077,"@@ -0,0 +1,14 @@
++// +build darwin linux,!baremetal freebsd,!baremetal
++
++// +build gc.conservative gc.leaking
++
++package runtime
++
++const heapSize = 1 * 1024 * 1024 // 1MB to start
++
++var heapStart, heapEnd uintptr
++
++func preinit() {
++	heapStart = uintptr(malloc(heapSize))
++	heapEnd = heapStart + heapSize
++}","I only now spot this `freebsd,!baremetal` in the code, which doesn't make a lot of sense. The fact that there is `linux,!baremetal` is because baremetal targets pretend to be linux/arm to get the standard library to compile. Such a `!baremetal` exclusion is not necessary for FreeBSD. But this is not something that needs fixing in this PR.",I'm not sure I like this heap size. It's rather unusual. Can
+8078,"@@ -455,7 +455,7 @@ get_unpacked_unlinked_content (OstreeRepo       *repo,
+                                GError          **error)
+ {
+   gboolean ret = FALSE;
+-  g_autofree char *tmpname = g_strdup (""tmpostree-deltaobj-XXXXXX"");
++  g_autofree char *tmpname = g_strdup (""/var/tmp/tmpostree-deltaobj-XXXXXX"");
+   glnx_fd_close int fd = -1;
+   g_autoptr(GBytes) ret_content = NULL;
+   g_autoptr(GInputStream) istream = NULL;","Ugh, we were using cwd? =(",This won't work on Windows. But I don't know if it really wor
+8079,"@@ -21,7 +21,6 @@ struct screencopy_damage {
+ 	struct pixman_region32 damage;
+ 	struct wl_listener output_precommit;
+ 	struct wl_listener output_destroy;
+-	uint32_t last_commit_seq;
+ };
+
+ static const struct zwlr_screencopy_frame_v1_interface frame_impl;",This can probably be removed?,It looks like this variable was unused. Can it be removed fro
+8080,"@@ -89,8 +89,9 @@ void FetchExecutor::setupResponse(cpp2::ExecutionResponse &resp) {
+ }
+
+ void FetchExecutor::onEmptyInputs() {
++    auto outputs = std::make_unique<InterimResult>(std::move(resultColNames_));
+     if (onResult_) {
+-        onResult_(nullptr);
++        onResult_(std::move(outputs));
+     } else if (resp_ == nullptr) {
+         resp_ = std::make_unique<cpp2::ExecutionResponse>();
+     }",put this sentence in `if (onResult_) { }`,"If `onResult_` is guaranteed to be non-null, then `if (resp_ == nullptr)` needs to be checked."
+8081,"@@ -235,11 +235,16 @@ echo ""echo '{export_forseti_vars}' >> /etc/profile.d/forseti_environment.sh"" | s
+ gsutil cp gs://{scanner_bucket}/configs/forseti_conf_server.yaml {forseti_server_conf}
+ gsutil cp -r gs://{scanner_bucket}/rules {forseti_home}/
+
++# Download the Newest Config Validator constraints from GCS
++rm -rf /home/ubuntu/config_validator_constraints
++gsutil cp -r gs://{scanner_bucket}/config_validator_constraints /home/ubuntu/
++
+ # Start Forseti service depends on vars defined above.
+ bash ./install/gcp/scripts/initialize_forseti_services.sh
+
+ echo ""Starting services.""
+ systemctl start cloudsqlproxy
++systemctl start config-validator
+ sleep 5
+
+ echo ""Attempting to update database schema, if necessary.""",Will this always be started up as default? Is there any impact to the VM in terms of load and memory usage?,"Not sure if we need to do this since we are running systemctl directly now, `systemctl stop` m"
+8082,"@@ -374,7 +374,7 @@ class CommandLine
+         /// parsable types (values are comma separated without space).
+         ///
+         /// Qualifiers that are defined BEFORE any parameter sets apply to ALL parameter sets.  qualifiers that
+-        /// are defined AFTER a parameter set will apply only the the parameter set that preceeds them.
++        /// are defined AFTER a parameter set will apply only the the parameter set that precedes them.
+         ///
+         /// See code:#DefiningParametersAndQualifiers
+         /// See code:#Overview",Thanks for fixing the typo's but given that this is a fork of the other commandline.cs file they will still exist there :( Part of the reason forks suck.,typo: precedes -> that precedes
+8083,"@@ -141,8 +141,14 @@ import datetime
+ import itertools
+ import logging
+ import luigi
+-import sqlalchemy
+ import os
++import warnings
++
++try:
++    import sqlalchemy
++except ImportError:
++    # Don't fail on import because we want the documentation to be generated
++    warnings.warn(""sqlalchemy could not be imported, db_task_history will not work"", warnings.ImportWarning, stacklevel=3)
+
+
+ class SQLAlchemyTarget(luigi.Target):",This doesn't seem related to docs? :),How about `warnings.warn` instead?
+8084,"@@ -233,7 +233,7 @@ public class K9 extends Application {
+     private static boolean hideSpecialAccounts = false;
+     private static boolean autofitWidth;
+     private static boolean quietTimeEnabled = false;
+-    private static boolean notificationDuringQuietTimeEnabled = true;
++    private static boolean notificationDuringQuietTimeDisabled = true;
+     private static String quietTimeStarts = null;
+     private static String quietTimeEnds = null;
+     private static String attachmentDefaultPath = """";","Having a negative in the variable/method name makes the code harder to read. Also, you inverted the logic but didn't invert the default value. I suggest sticking to the original name.",Please rename to `notificationDuringQuietTimeEnabled`
+8085,"@@ -66,8 +66,8 @@ namespace NLog.Targets
+         /// Always use <see cref=""Trace.WriteLine(string)""/> independent of <see cref=""LogLevel""/>
+         /// </summary>
+         /// <docgen category='Output Options' order='100' />
+-        [DefaultValue(false)]
+-        public bool RawWrite { get; set; }
++        [DefaultValue(true)]
++        public bool ForceTraceWriteLine { get; set; } = true;
+
+         /// <summary>
+         /// Forward <see cref=""LogLevel.Fatal"" /> to <see cref=""Trace.Fail(string)"" /> (Instead of <see cref=""Trace.TraceError(string)"" />)",Think you need to keep `RawWrite` around as obsolete until NLog6 (Property that just assigns `ForceTraceWriteLine`),"This is a breaking change, I don't think we should ma"
+8086,"@@ -45,6 +45,9 @@ proc_init_arch(void)
+     num_simd_registers = MCXT_NUM_SIMD_SLOTS;
+     num_opmask_registers = MCXT_NUM_OPMASK_SLOTS;
+
++    set_cache_line_size_using_ctr_el0(/* dcache_line_size= */ &cache_line_size,
++                                      /* icache_line_size= */ NULL);
++
+     /* FIXME i#1569: NYI */
+ }
+ ",I would expect this to be named *get* not *set*: it's a query; it's not setting some persistent state.,<!--new_thread; commit:7bf9d2048e8d568ee9280629db3917
+8087,"@@ -2,7 +2,7 @@ import os
+ from typing import Dict, List
+
+ from dagster import SensorDefinition
+-from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext
++from dagster.core.definitions.pipeline_definition_sensor import PipelineFailureSensorContext
+ from dagster_slack import make_slack_on_pipeline_failure_sensor
+ from hacker_news_assets.utils.slack_message import build_slack_message_blocks
+ ",maybe should rename this to be `run_status_sensor_definition.py`,Would it make sense to rename this file as well?
+8088,"@@ -0,0 +1,19 @@
++/*
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *     http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.apache.iceberg.spark;
++
++public class SparkWriteOptions {
++    public static final String FANOUT_ENABLED = ""fanout-enabled"";
++}",Do we want to add the other write options in this PR or keep the refactor separate?,"Let's change this to SparkWriteOptions.FANOUT_ENABLED = ""fanout-enabled"""
+8089,"@@ -68,7 +68,17 @@ def refresh_user_token(spotify_user):
+         user (domain.spotify.Spotify): the same user with updated tokens
+     """"""
+     auth = get_spotify_oauth()
+-    new_token = auth.refresh_access_token(spotify_user.refresh_token)
++
++    retries = 5
++    new_token = None
++    while retries > 0:
++        new_token = auth.refresh_access_token(spotify_user.refresh_token)
++        if new_token is not None:
++            break
++        retries -= 1
++    if new_token is None:
++        raise SpotifyAPIError('Could not refresh API Token for Spotify user')
++
+     access_token = new_token['access_token']
+     refresh_token = new_token['refresh_token']
+     expires_at = new_token['expires_at']",either make this a config or a constant we can define at the top. Burying this in the code is no good.,Looks like you have an indentation issue here.
+8090,"@@ -73,6 +73,13 @@ def multi_error(y_true, y_pred):
+ def multi_logloss(y_true, y_pred):
+     return np.mean([-math.log(y_pred[i][y]) for i, y in enumerate(y_true)])
+
++def custom_recall(y_true, y_pred):
++    return 'custom_recall', recall_score(y_true, y_pred > 0.5), True
++
++
++def custom_precision(y_true, y_pred):
++    return 'custom_precision', precision_score(y_true, y_pred > 0.5), True
++
+
+ class TestSklearn(unittest.TestCase):
+ ",Same about new metrics. Can we avoid adding them?,"please remove this, as it is not needed"
+8091,"@@ -40,6 +40,15 @@ def run():
+     group.add_argument('--cloudsql-region',
+                        help='The Cloud SQL region')
+
++    network = parser.add_argument_group(title='network')
++    network.add_argument('--network-host-project-id',
++                         help='The project id that is hosting the network '
++                              'resources.')
++    network.add_argument('--vpc-name',
++                         help='The VPC name where Forseti VM will run.')
++    network.add_argument('--subnet-name',
++                         help='The subnetwork name where Forseti VM will run.')
++
+     email_params = parser.add_argument_group(title='email')
+     email_params.add_argument('--sendgrid-api-key',
+                               help='Sendgrid API key')","I know this is a port from the previous PR, but I am wondering if we can take the chance to improve the naming? `--vpc-host-project-id` ?",why not add `--network-id` as well?
+8092,"@@ -228,7 +228,7 @@ describe('Formulas general', () => {
+       afterChange,
+     });
+
+-    hot.getSourceData()[1][1] = 20;
++    hot.setSourceDataAtCell(1, 1, 20);
+     hot.getPlugin('formulas').recalculateFull();
+     hot.render();
+ ","The test description says it's ""by reference"". We should change the description",Is there a reason to use `setSourceDataAtCell` instead of `getSourceData`?
+8093,"@@ -16,9 +16,15 @@ namespace AutoRest.Core.Validation
+         {
+         }
+
++        /// <summary>
++        /// Id of the Rule.
++        /// </summary>
+         public virtual string Id => ""!!! implement me and make me abstract !!!"";
+
+-        public ValidationCategory ValidationCategory => ((ValidationCategory)0); // !!! implement me and make me abstract !!!
++        /// <summary>
++        /// Violation category of the Rule.
++        /// </summary>
++        public virtual ValidationCategory ValidationCategory => ((ValidationCategory)0); // !!! implement me and make me abstract !!!
+
+         /// <summary>
+         /// The template message for this Rule. ",A C# newbie question here: would it make sense to declare Id as an abstract property so any subclass Must have its own Id?,This is an example of a difficult change. Please don't make changes in the
+8094,"@@ -47,6 +47,11 @@ func (r *Repository) Proposals(filter *proposal.Filter) ([]market.ServiceProposa
+ 	return []market.ServiceProposal{}, nil
+ }
+
++// Countries returns proposals per country matching the filter.
++func (r *Repository) Countries(filter *proposal.Filter) (map[string]int, error) {
++	return nil, nil
++}
++
+ // Start begins proposals synchronization to storage.
+ func (r *Repository) Start() error {
+ 	return nil",just looks like you should return an **empty map** with nil error,Do we really need this function? I don't see it being used anywhere.
+8095,"@@ -103,11 +103,18 @@ func main() {
+ 	reloadURL := app.Flag(""reload-url"", ""reload URL to trigger Prometheus reload on"").
+ 		Default(""http://127.0.0.1:9090/-/reload"").URL()
+
++	version.RegisterIntoKingpinFlags(app)
++
+ 	if _, err := app.Parse(os.Args[1:]); err != nil {
+ 		fmt.Fprintln(os.Stderr, err)
+ 		os.Exit(2)
+ 	}
+
++	if version.ShouldPrintVersion() {
++		version.Print(os.Stdout, ""prometheus-config-reloader"")
++		os.Exit(0)
++	}
++
+ 	logger := log.NewLogfmtLogger(log.NewSyncWriter(os.Stdout))
+
+ 	if *logFormat == logFormatJson {",could you also update the starting log at L146?,This should be moved into the `if err != nil {` block above.
+8096,"@@ -312,6 +312,16 @@ func isUnitExists(err error) bool {
+ 	return false
+ }
+
++// isDbusClosed returns true if the error is that connection closed.
++func isDbusClosed(err error) bool {
++	if err != nil {
++		if dbusError, ok := err.(dbus.Error); ok {
++			return strings.Contains(dbusError.Name, ""connection closed by user"")
++		}
++	}
++	return false
++}
++
+ func startUnit(dbusConnection *systemdDbus.Conn, unitName string, properties []systemdDbus.Property) error {
+ 	statusChan := make(chan string, 1)
+ 	if _, err := dbusConnection.StartTransientUnit(unitName, ""replace"", properties, statusChan); err == nil {",Also this probably should be `error.As()` or something like it.,"Since this is only used in the tests, should it live in `pkg/cmd/server/systemd`?"
+8097,"@@ -219,7 +219,9 @@ webdriver.CommandName = {
+   GET_SESSION_LOGS: 'getSessionLogs',
+
+   // Non-standard commands used by the standalone Selenium server.
+-  UPLOAD_FILE: 'uploadFile'
++  UPLOAD_FILE: 'uploadFile',
++
++  GET_CANVAS_URL: 'getCanvasUrl'
+ };
+
+ ",This is Safari specific and should be defined somewhere in the `safaridriver` namespace,Rename to `GET_CANVAS_URL`
+8098,"@@ -49,6 +49,13 @@ main(int argc, char *argv[])
+       exit (EXIT_SUCCESS);
+   }
+
++  /* We conflict with the magic ostree-mount-deployment-var file for ostree-prepare-root */
++  { struct stat stbuf;
++    if (fstatat (AT_FDCWD, ""/run/ostree-mount-deployment-var"", &stbuf, 0) == 0)
++      exit (EXIT_SUCCESS);
++  }
++
++
+   if (argc > 1 && argc != 4)
+     errx (EXIT_FAILURE, ""This program takes three or no arguments"");
+ ","Let's maybe be nice and `unlinkat()` here in the interest of having `/run` be less littered. Or in addition/alternatively, make the file `/run/ostree/initramfs-mount-var` since we already made `/run/ostree/` for the deployment staging bits.",(style) space prohibited before that close parenthesis ')'
+8099,"@@ -21,6 +21,7 @@
+
+ #include ""teleport.h""
+ #include ""game.h""
++#include <boost/format.hpp>
+
+ extern Game g_game;
+ ",Not sure if this doesn't require explicitly adding this library to cmake.,Please be consistent with the style of the rest of the code base.
+8100,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,Is this function used anywhere? Can we remove it?
+8101,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,Path.toString() is not guaranteed to return the s
+8102,"@@ -77,9 +77,10 @@ module Beaker
+     # @option opts [Beaker::Logger] :logger A {Beaker::Logger} object
+     def validate_host host, opts
+       logger = opts[:logger]
++      # Additional Packages to be determined at runtime
++      additional_pkgs = Array.new
+       if opts[:collect_perf_data]
+-        UNIX_PACKAGES << ""sysstat"" if !UNIX_PACKAGES.include? ""sysstat""
+-        SLES_PACKAGES << ""sysstat"" if !SLES_PACKAGES.include? ""sysstat""
++        additional_pkgs << ""sysstat"" if !additional_pkgs.include? ""sysstat""
+       end
+       block_on host do |host|
+         case",This `if` statement can be merged with the above `if opts[:collect_perf_data]`.,This would be better with `opts[:collect_perf_dat
+8103,"@@ -110,6 +110,8 @@ func (d Document) Get(fp []string) (interface{}, error) {
+ }
+
+ func (d Document) structField(name string) (reflect.Value, error) {
++	// We do case-insensitive match here to cover the MongoDB's lowercaseFields
++	// option.
+ 	f := d.fields.MatchFold(name)
+ 	if f == nil {
+ 		return reflect.Value{}, gcerr.Newf(gcerr.NotFound, nil, ""field %q not found in struct type %s"", name, d.s.Type())","But won't we do case-insensitive matching for all the drivers? For example, we will get the revision field case-insensitively. Let's make this case-sensitive. I think the way the mongo driver works, by lowercasing field names, will be OK with that.",We don't do case-insensitive match here to cover
+8104,"@@ -5,7 +5,10 @@
+
+ <div class=""text-box-wrapper"">
+   <div class=""text-box"">
+-    <h2><%= @product.tagline %></h2>
++    <hgroup class=""product-title"">
++      <h2><%= @product.tagline %></h2>
++      <h3 class=""workshop-type"">Online Workshop</h3>
++    </hgroup>
+
+     <%== @product.description %>
+   </div>","I believe this should be on `workshops/show` now, not `products/show`",The `<h3>` is not required here.
+8105,"@@ -16,6 +16,7 @@ func TestDetectorDetectCountry(t *testing.T) {
+ 		{""95.85.39.36"", ""NL"", """"},
+ 		{""127.0.0.1"", """", """"},
+ 		{""8.8.8.8.8"", """", ""failed to parse IP""},
++		{""185.243.112.225"", """", """"},
+ 		{""asd"", """", ""failed to parse IP""},
+ 	}
+ ","If we return error when we are unable to found country in database, using country detector would be much easier - if error was not returned, that means country was returned :) This doesn't have to be solved in this PR, but since you're adding such case, we can add a `TODO` just to track this :)",I don't know if this is a valid
+8106,"@@ -24,7 +24,12 @@ namespace Datadog.Trace.ClrProfiler.Managed.Loader
+             var corlib461Version = new Version(corlib461FileVersionString);
+             var tracerFrameworkDirectory = corlibVersion < corlib461Version ? ""net45"" : ""net461"";
+
+-            var tracerHomeDirectory = Environment.GetEnvironmentVariable(""DD_DOTNET_TRACER_HOME"") ?? string.Empty;
++            var tracerHomeDirectory = Environment.GetEnvironmentVariable(""DD_DOTNET_TRACER_HOME"");
++            if (string.IsNullOrWhiteSpace(tracerHomeDirectory))
++            {
++                tracerHomeDirectory = Path.GetDirectoryName(Environment.GetEnvironmentVariable(""DD_INTEGRATIONS"")) ?? string.Empty;
++            }
++
+             return Path.Combine(tracerHomeDirectory, tracerFrameworkDirectory);
+         }
+ ",.NET Framework: Fallback to `DD_INTEGRATIONS` if `DD_DOTNET_TRACER_HOME` was not set.,Why are we checking for the pres
+8107,"@@ -111,7 +111,8 @@ def _read_request_line(line: bytes) -> Tuple[str, int, bytes, bytes, bytes, byte
+                 raise ValueError
+         else:
+             scheme, rest = target.split(b""://"", maxsplit=1)
+-            authority, path_ = rest.split(b""/"", maxsplit=1)
++            authority, *paths_ = rest.split(b""/"", maxsplit=1)
++            path_ = paths_[0] if paths_ else b""""
+             path = b""/"" + path_
+             host, port = url.parse_authority(authority, check=True)
+             port = port or url.default_port(scheme)","Can you use `authority, _, path = rest.partition(b""/"")` here? That should make stuff a bit cleaner.",nit: `if paths_` is a bit cleare
+8108,"@@ -75,6 +75,10 @@ module RSpec::Core
+           options[:order] = ""rand:#{seed}""
+         end
+
++        parser.on('--stress-test LIMIT', Float, 'Repeatedly run randomly selected examples for LIMIT seconds.') do |o|
++          options[:stress_test] = o.to_f
++        end
++
+         parser.on('-d', '--debugger', 'Enable debugging.') do |o|
+           options[:debug] = true
+         end",I don't think this needs to be a float if its a number of seconds... :),Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+8109,"@@ -38,7 +38,7 @@ interface FieldProcessor
+     /**
+      * process method
+      *
+-     * @param array Array of values, an array because of multivalued fields
++     * @param array $values of values, an array because of multivalued fields
+      * @return array Modified array of values
+      */
+     public function process(array $values);","Please add ""Array"" back, right now it's not a proper sentence.",`array $values of values`
+8110,"@@ -509,7 +509,9 @@ public class QueryElevationComponent extends SearchComponent implements SolrCore
+       rb.setQuery(new BoostQuery(elevation.includeQuery, 0f));
+     } else {
+       BooleanQuery.Builder queryBuilder = new BooleanQuery.Builder();
+-      queryBuilder.add(rb.getQuery(), BooleanClause.Occur.SHOULD);
++      BooleanClause.Occur queryOccurrence = params.getBool(QueryElevationParams.ELEVATE_ONLY_DOCS_MATCHING_QUERY, false) ?
++              BooleanClause.Occur.SHOULD : BooleanClause.Occur.MUST;
++      queryBuilder.add(rb.getQuery(), queryOccurrence);
+       queryBuilder.add(new BoostQuery(elevation.includeQuery, 0f), BooleanClause.Occur.SHOULD);
+       if (elevation.excludeQueries != null) {
+         if (params.getBool(QueryElevationParams.MARK_EXCLUDES, false)) {",@tkaessmann when I ran tests I saw this line has a bug. It inverts the SHOULD and MUST. Hopefully I fixed it and merged it without the bug.,nit: this ternary operator should be on a new line.
+8111,"@@ -301,7 +301,7 @@ func initTelemetry(genesis bookkeeping.Genesis, log logging.Logger, dataDirector
+ 				}
+
+ 				// If the telemetry URI is not set, periodically check SRV records for new telemetry URI
+-				if log.GetTelemetryURI() == """" {
++				if telemetryConfig.Enable && log.GetTelemetryURI() == """" {
+ 					network.StartTelemetryURIUpdateService(time.Minute, cfg, genesis.Network, log, abort)
+ 				}
+ ","There may be another bug, it looks like we're already in a `if telemetryConfig.Enable` block at this point, maybe that block should be unnested?",wouldn't this check be unnecessary if `telemetryConfig.Enable` is true?
+8112,"@@ -944,7 +944,9 @@ class Request(Message):
+
+     def _set_multipart_form(self, value):
+         self.content = multipart.encode(self.headers, value)
+-        self.headers[""content-type""] = ""multipart/form-data""
++        if ""content-type"" not in self.headers:
++            # Don't overwrite header if it already exists or it will destroy the boundary value
++            self.headers[""content-type""] = ""multipart/form-data""
+
+     @property
+     def multipart_form(self) -> multidict.MultiDictView[bytes, bytes]:","This... looks like it plainly didn't work before? Good catch. I would suggest we change the logic here to 1. Check if `self.headers[""content_type""].startswith(""multipart/form-data"")`, and if that's not the case, add a content-type header with a random (?) boundary. The point here is that if someone assigns to `.multipart_form = ` in their addon, the header should be updated accordingly if the request was not multipart before. 2. *After* that, call `self.content = multipart.encode(self.headers, value)` (as we do right now)","Shouldn't this be `if ""content-type"" not in self.headers:`?"
+8113,"@@ -86,9 +86,14 @@ func TestSignBlock(t *testing.T) {
+
+ func TestWrongNonce(t *testing.T) {
+ 	cfg := config.Default
++
++	require := require.New(t)
++	registry := protocol.Registry{}
++	require.NoError(registry.Register(account.ProtocolID, account.NewProtocol()))
++
+ 	ctx := protocol.WithValidateActionsCtx(
+ 		context.Background(),
+-		protocol.ValidateActionsCtx{Genesis: cfg.Genesis},
++		protocol.ValidateActionsCtx{Genesis: cfg.Genesis, Registry: &registry},
+ 	)
+ 	testTrieFile, _ := ioutil.TempFile(os.TempDir(), ""trie"")
+ 	testTriePath := testTrieFile.Name()",importShadow: shadow of imported from 'github.com/stretchr/testify/require' package 'require' (from `gocritic`),Nit: no need to specify the registry here.
+8114,"@@ -1963,9 +1963,8 @@ get_ibl_routine_type_ex(dcontext_t *dcontext, cache_pc target, ibl_type_t *type
+
+     /* a decent compiler should inline these nested loops */
+     /* iterate in order <linked, unlinked> */
+-    for (link_state = IBL_LINKED;
+-         /* keep in mind we need a signed comparison when going downwards */
+-         (int)link_state >= (int)IBL_UNLINKED; link_state-- ) {
++    link_state = IBL_LINKED;
++    while (true) {
+         /* it is OK to compare to IBL_BB_PRIVATE even when !SHARED_FRAGMENTS_ENABLED() */
+         for (source_fragment_type = IBL_SOURCE_TYPE_START;
+              source_fragment_type < IBL_SOURCE_TYPE_END;",Wouldn't it be enough to change the condition in the for loop to `link_state != IBL_UNLINKED`?,(style) code indent should use tabs where possible (style)
+8115,"@@ -31,7 +31,10 @@
+
+ #include <glib/gi18n.h>
+
++static gboolean opt_verify;
++
+ static GOptionEntry options[] = {
++  { ""verify"", 'V', 0, G_OPTION_ARG_NONE, &opt_verify, ""Print the commit verification status"", NULL },
+   { NULL }
+ };
+ ","I'm not familiar with signed setups, but this does not seem to offer a way to choose between GPG and signapi verification. Are they usually either both enabled or both disabled? Would this be better suited as a verb with flags for different methods?",I wonder if we should have an option to only print the veri
+8116,"@@ -951,7 +951,7 @@ func (dao *blockDAO) getBlockValue(blockNS string, h hash.Hash256) ([]byte, erro
+ 		if err != nil {
+ 			return nil, err
+ 		}
+-		value, err = db.Get(blockNS, h[:])
++		value, _ = db.Get(blockNS, h[:])
+ 	}
+ 	return value, err
+ }",assignments should only be cuddled with other assignments (from `wsl`),This seems unrelated to the rest of the PR.
+8117,"@@ -11,6 +11,7 @@ C2::Application.routes.draw do
+   post ""/feedback"" => ""feedback#create""
+
+   match ""/auth/:provider/callback"" => ""auth#oauth_callback"", via: [:get]
++  get ""/auth/failure"" => ""auth#failure""
+   post ""/logout"" => ""auth#logout""
+
+   resources :help, only: [:index, :show]",would it make sense to mock oauth in a way that we direct a user to this endpoint on login (in a test)?,Why not follow the convention above and use
+8118,"@@ -5,13 +5,14 @@ define([""events"", ""globalize"", ""dom"", ""datetime"", ""userSettings"", ""serverNotific
+         var html = """";
+         html += '<div class=""listItem listItem-border"">';
+         var color = ""Error"" == entry.Severity || ""Fatal"" == entry.Severity || ""Warn"" == entry.Severity ? ""#cc0000"" : ""#00a4dc"";
++        var icon = ""Error"" == entry.Severity || ""Fatal"" == entry.Severity || ""Warn"" == entry.Severity ? ""notification_important"" : ""notifications"";
+         if (entry.UserId && entry.UserPrimaryImageTag) {
+             html += '<i class=""listItemIcon md-icon"" style=""width:2em!important;height:2em!important;padding:0;color:transparent;background-color:' + color + "";background-image:url('"" + apiClient.getUserImageUrl(entry.UserId, {
+                 type: ""Primary"",
+                 tag: entry.UserPrimaryImageTag,
+                 height: 40
+             }) + ""');background-repeat:no-repeat;background-position:center center;background-size: cover;\"">dvr</i>""
+-        } else html += '<i class=""listItemIcon md-icon"" style=""background-color:' + color + '"">dvr</i>';
++        } else html += '<i class=""listItemIcon md-icon"" style=""background-color:' + color + '"">' + icon + '</i>';
+         html += '<div class=""listItemBody three-line"">', html += '<div class=""listItemBodyText"">', html += entry.Name, html += ""</div>"", html += '<div class=""listItemBodyText secondary"">';
+         var date = datetime.parseISO8601Date(entry.Date, !0);
+         return html += datetime.toLocaleString(date).toLowerCase(), html += ""</div>"", html += '<div class=""listItemBodyText secondary listItemBodyText-nowrap"">', html += entry.ShortOverview || """", html += ""</div>"", html += ""</div>"", entry.Overview && (html += '<button type=""button"" is=""paper-icon-button-light"" class=""btnEntryInfo"" data-id=""' + entry.Id + '"" title=""' + globalize.translate(""Info"") + '""><i class=""md-icon"">info</i></button>'), html += ""</div>""","Since these two lines use the same logic, it may be cleaner to use an `if` statement rather than duplicating it.",where is this icon coming from?
+8119,"@@ -3,7 +3,6 @@
+ namespace Shopsys\ShopBundle\Controller\Front;
+
+ use Exception;
+-use Shopsys\FrameworkBundle\Component\Controller\FrontBaseController;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
+ use Shopsys\FrameworkBundle\Component\Error\ErrorPagesFacade;
+ use Shopsys\FrameworkBundle\Component\Error\ExceptionController;",unnecessary blank line,Why did you remove this controller? It is n
+8120,"@@ -38,6 +38,12 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 2, ""_pos"", Types.LongType.get(), ""Ordinal position of a row in the source data file"");
+   public static final NestedField IS_DELETED = NestedField.required(
+       Integer.MAX_VALUE - 3, ""_deleted"", Types.BooleanType.get(), ""Whether the row has been deleted"");
++  public static final NestedField SPEC_ID = NestedField.required(
++      Integer.MAX_VALUE - 4, ""_spec_id"", Types.IntegerType.get(), ""Spec ID to which a row belongs to"");
++  // the partition column type is not static and depends on all specs in the table
++  public static final int PARTITION_COLUMN_ID = Integer.MAX_VALUE - 5;
++  public static final String PARTITION_COLUMN_NAME = ""_partition"";
++  public static final String PARTITION_COLUMN_DOC = ""Partition to which a row belongs to"";
+
+   // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+   public static final NestedField DELETE_FILE_PATH = NestedField.required(","Nit: no need for ""to"" at the end of the doc because it already uses ""to which"".",why does this need to be Integer.MAX_VALUE?
+8121,"@@ -0,0 +1,6 @@
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT License. See License.txt in the project root for license information.
++
++[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA1021:AvoidOutParameters"", MessageId = ""2#"", Scope = ""member"", Target = ""Microsoft.Rest.TransientFaultHandling.ShouldRetryHandler.#Invoke(System.Int32,System.Exception,System.TimeSpan&)"")]
++[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA2210:AssembliesShouldHaveValidStrongNames"", Justification=""We do give it strong name and sign it when build in CI server and verify it"")]
++","I would just say ""Signed before publishing.""",do we still need the message id here?
+8122,"@@ -21,13 +21,14 @@
+
+ #include <gtest/gtest.h>
+
+-#include <fastrtps/transport/UDPv4Transport.h>
+-#include ""../cpp/rtps/transport/shared_mem/test_SharedMemTransportDescriptor.h""
++#include <rtps/transport/shared_mem/test_SharedMemTransportDescriptor.h>
++#include <rtps/transport/UDPv4Transport.h>
+
+ using namespace eprosima::fastrtps;
+
+ using SharedMemTransportDescriptor = eprosima::fastdds::rtps::SharedMemTransportDescriptor;
+ using test_SharedMemTransportDescriptor = eprosima::fastdds::rtps::test_SharedMemTransportDescriptor;
++using UDPv4Transport = eprosima::fastdds::rtps::UDPv4Transport;
+
+ TEST(SHM, TransportPubSub)
+ {",We can just include the public UDPv4TransportDescriptor header here ...,Why do we need this?
+8123,"@@ -196,6 +196,9 @@ class BlazeMeterUploader(Reporter, AggregatorListener, MonitoringListener, Singl
+             self._session = Session(self._user, {'id': sess_id})
+             self._session['userId'] = self.parameters.get(""user-id"", None)
+             self._session['testId'] = self.parameters.get(""test-id"", None)
++            data_address = self.settings.get(""data-address"", None)
++            if data_address:
++                self._session['data-address'] = data_address
+             self._test = Test(self._user, {'id': self._session['testId']})
+             exc = TaurusConfigError(""Need signature for session"")
+             self._session.data_signature = self.parameters.get(""signature"", exc)",Why do we need this change?,"If this data-address has a default value, t"
+8124,"@@ -172,11 +172,15 @@ func (t *Tag) Done(s State) bool {
+ 	return err == nil && n == total
+ }
+
+-// DoneSplit sets total count to SPLIT count and sets the associated swarm hash for this tag
+-// is meant to be called when splitter finishes for input streams of unknown size
++// DoneSplit adds the total with the split count and updated the total.
++// This is useful when you use the same tag for a file and its manifest upload
++// Also the Address is updated with the last called address, so the assumption
++// is that the manifest creation will be called last and this will have the root
++// hash of the manifest
+ func (t *Tag) DoneSplit(address swarm.Address) int64 {
+-	total := atomic.LoadInt64(&t.Split)
+-	atomic.StoreInt64(&t.Total, total)
++	split := atomic.LoadInt64(&t.Split)
++	total := atomic.LoadInt64(&t.Total)
++	atomic.StoreInt64(&t.Total, total+split)
+ 	t.Address = address
+ 	return total
+ }","These three atomic functions done separately are not atomic. There is a possibility of data race, as nothing is guarding Total in between lines 182 and 183. Total got on line 182 may be changed before new value is stored on line 183 by some other goroutine resulting an incorrect value. Mutex should be used.","Just noticed this: `storeInt64(&t.Total, total+split)` is an int64, whereas `storeInt64(&t.Total, total+split)` is an int64. Could we just use `storeInt64(&t.Total, total)` ?"
+8125,"@@ -392,7 +392,7 @@ namespace Nethermind.BeaconNode.Tests.EpochProcessing
+             foreach (var checkpoint in checkpoints)
+             {
+                 var startSlot = beaconChainUtility.ComputeStartSlotOfEpoch(checkpoint.Epoch);
+-                var slotIndex = startSlot % timeParameters.SlotsPerHistoricalRoot;
++                Slot slotIndex = (Slot)(startSlot % timeParameters.SlotsPerHistoricalRoot);
+                 state.SetBlockRoot(slotIndex, checkpoint.Root);
+             }
+         }",Is this because you don't have % on your version of Slot? I don't really care either way.,Why do we need to change this?
+8126,"@@ -212,9 +212,14 @@
+           return {
+             pre: function ($scope, $elm, $attrs, uiGridCtrl) {
+               if ( uiGridCtrl.grid.options.enableExpandableRowHeader !== false ) {
+-                var expandableRowHeaderColDef = {name: 'expandableButtons', displayName: '', enableColumnResizing: false, width: 40};
+-                expandableRowHeaderColDef.cellTemplate = $templateCache.get('ui-grid/expandableRowHeader');
+-                uiGridCtrl.grid.addRowHeaderColumn(expandableRowHeaderColDef);
++                var defaultExpandableRowHeaderColDef = {
++                    name: 'expandableButtons',
++                    width: 40,
++                    cellTemplate: $templateCache.get('ui-grid/expandableRowHeader')
++                  },
++                  userInjectedExpandableRowHeaderColDef = $scope.gridOptions.expandableRowHeaderColDef || {},
++                  finalExpandableRowHeaderColDef = angular.extend({}, defaultExpandableRowHeaderColDef, userInjectedExpandableRowHeaderColDef);
++                uiGridCtrl.grid.addRowHeaderColumn(finalExpandableRowHeaderColDef);
+               }
+               uiGridExpandableService.initializeGrid(uiGridCtrl.grid);
+             },",Please use var declaration for variables you are declaring. I could not find one for userInjectedExpandableRowHeaderColDef and finalExpandableRowHeaderColDef. Also code styling in the if block needs to be corrected.,can you use `extend` here too?
+8127,"@@ -158,12 +158,10 @@ NABoolean TMUDFDllInteraction::describeParamsAndMaxOutputs(
+                                   dummyUser,
+                                      cachedLibName, cachedLibPath))
+         {
+-           NAString cachedFullName = cachedLibPath+""/""+cachedLibName;
+            char errString[200];
+            NAString errNAString;
+-           sprintf(errString , ""Error %d creating directory :"",errno);
++           sprintf(errString , ""Error %d creating directory : %s"", err, cachedLibPath.data());
+            errNAString = errString;
+-           errNAString += cachedFullName;
+            *CmpCommon::diags() <<  DgSqlCode(-4316)
+                                   << DgString0(( char *)errNAString.data());
+            bindWA->setErrStatus();","If cachedLibPath > 200 bytes, it will overflow errString.",(style) line over 80 characters
+8128,"@@ -202,6 +202,10 @@ const ariaRoles = {
+     allowedAttrs: ['aria-expanded'],
+     superclassRole: ['landmark']
+   },
++  generic: {
++    type: 'structure',
++    prohibitedAttrs: ['aria-label', 'aria-labelledby']
++  },
+   grid: {
+     type: 'composite',
+     requiredOwned: ['rowgroup', 'row'],","Talked this through with a few more folks. I think it would be better to flag prohibited attributes for review, instead of outright failing them. ARIA labels are used fairly liberally. We don't really know if they are actually needed whenever they are used.","This is new, but I don't think we need to add `aria-labelledby`."
+8129,"@@ -565,8 +565,11 @@ func (pool *TxPool) validateTx(tx *types.Transaction, local bool) error {
+ 	}
+ 	// Transactor should have enough funds to cover the costs
+ 	// cost == V + GP * GL
+-	if pool.currentState.GetBalance(from).Cmp(tx.Cost()) < 0 {
+-		return ErrInsufficientFunds
++	if !rcfg.UsingOVM {
++		// This check is done in SyncService.verifyFee
++		if pool.currentState.GetBalance(from).Cmp(tx.Cost()) < 0 {
++			return ErrInsufficientFunds
++		}
+ 	}
+ 	// Ensure the transaction has more gas than the basic tx fee.
+ 	intrGas, err := IntrinsicGas(tx.Data(), tx.To() == nil, true, pool.istanbul)",Let's keep it to avoid the diff,Would it be better to just check for OVM in `pool.verifyFee`?
+8130,"@@ -63,7 +63,8 @@ public class SparkTable implements org.apache.spark.sql.connector.catalog.Table,
+
+   private static final Logger LOG = LoggerFactory.getLogger(SparkTable.class);
+
+-  private static final Set<String> RESERVED_PROPERTIES = Sets.newHashSet(""provider"", ""format"", ""current-snapshot-id"");
++  private static final Set<String> RESERVED_PROPERTIES =
++      Sets.newHashSet(""provider"", ""format"", ""current-snapshot-id"", ""location"");
+   private static final Set<TableCapability> CAPABILITIES = ImmutableSet.of(
+       TableCapability.BATCH_READ,
+       TableCapability.BATCH_WRITE,","nit: not directly related to this PR, but shall we use `ImmutableSet` for consistency?",I think it would be better to make a constant in `SparkTable` th
+8131,"@@ -109,10 +109,10 @@ module Blacklight
+     # @return [Blacklight::Solr::Response] the solr response object
+     def to_hash
+       return @params unless params_need_update?
+-      @params = processed_parameters.
+-                  reverse_merge(@reverse_merged_params).
+-                  merge(@merged_params).
+-                  tap { clear_changes }
++      @params = processed_parameters
++                  .reverse_merge(@reverse_merged_params)
++                  .merge(@merged_params)
++                  .tap { clear_changes }
+     end
+
+     alias_method :query, :to_hash","Layout/DotPosition: Place the . on the previous line, together with the method call receiver.",Align .tap with .reverse_merge on line 298.
+8132,"@@ -628,7 +628,10 @@ public class ClientManager {
+                     Log.w(""AccMgrAuthTokenProvider:fetchNewAuthToken"", ""accountManager.getAuthToken returned null bundle"");
+                 } else {
+                     newAuthToken = bundle.getString(AccountManager.KEY_AUTHTOKEN);
+-                    newInstanceUrl = bundle.getString(AuthenticatorService.KEY_INSTANCE_URL);
++                    final String encryptedInstanceUrl = bundle.getString(AuthenticatorService.KEY_INSTANCE_URL);
++                    if (encryptedInstanceUrl != null) {
++                        newInstanceUrl = SalesforceSDKManager.decryptWithPasscode(encryptedInstanceUrl, SalesforceSDKManager.getInstance().getPasscodeHash());
++                    }
+                     Intent broadcastIntent;
+                     if (newAuthToken == null) {
+                         if (clientManager.revokedTokenShouldLogout) {","We send the `instanceUrl` encrypted, but never bothered to decrypt it. I guess it was working because we never did any org split testing where the `instanceUrl` actually changes.","Can we get the passcode from the bundle directly, so that we don't need to decrypt it again?"
+8133,"@@ -43,6 +43,12 @@ public class BftBlockHeaderFunctions implements BlockHeaderFunctions {
+         bftExtraDataCodec);
+   }
+
++  public static BlockHeaderFunctions forCmsSignature(final BftExtraDataCodec bftExtraDataCodec) {
++    return new BftBlockHeaderFunctions(
++        h -> new BftBlockHashing(bftExtraDataCodec).calculateHashOfBftBlockForCmsSignature(h),
++        bftExtraDataCodec);
++  }
++
+   @Override
+   public Hash hash(final BlockHeader header) {
+     return hashFunction.apply(header);",Can this be moved to QbftBlockHeaderFunctions class as it is only used for qbft,why does the block header function need to calculate the hash of bft block ?
+8134,"@@ -95,14 +95,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver
+             }
+         }
+
+-        public IList<string> Tags
+-        {
+-            get
+-            {
+-                throw new NotImplementedException();
+-            }
+-        }
+-
+         public void Analyze(TestAnalysisContext context)
+         {
+             if (_exceptionCondition == ExceptionCondition.InvokingAnalyze)",`Tags` now comes from the `PropertyBagHolder` base class.,I'm not sure why you had this in the first place. Can you explain what this `Tags` property
+8135,"@@ -61,7 +61,7 @@ class TextPlot(ElementPlot):
+                 data[k].extend(eld)
+         return data, elmapping, style
+
+-    def get_extents(self, element, ranges=None):
++    def get_extents(self, element, ranges=None, range_type='combined'):
+         return None, None, None, None
+
+ ","I'm not sure where this should go, but one of the `get_extents` methods should mention that `range_type` can be `'data'` or `'combined'` (are there others?). I found out those are the two expected values by searching the code...",Could you add a docstring here to explain what range_type is?
+8136,"@@ -25,14 +25,13 @@ import java.util.List;
+ import java.util.Locale;
+ import java.util.Map;
+ import java.util.TreeMap;
+-import java.util.logging.Logger;
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
+ import zipkin2.codec.SpanBytesDecoder;
+ import zipkin2.codec.SpanBytesEncoder;
+ import zipkin2.internal.Nullable;
+ import zipkin2.internal.Platform;
+
+-import static java.lang.String.format;
+-import static java.util.logging.Level.FINEST;
+ import static zipkin2.internal.HexCodec.HEX_DIGITS;
+
+ /**",please revert all of this stuff in core.. I'll take another pass after. cheers and thanks for the help!,This factory seems to be an unused import now
+8137,"@@ -50,6 +50,7 @@ public class TestCreateTableAsSelect extends SparkCatalogTestBase {
+   @After
+   public void removeTables() {
+     sql(""DROP TABLE IF EXISTS %s"", tableName);
++    sql(""DROP TABLE IF EXISTS %s"", sourceName);
+   }
+
+   @Test",Why was this needed?,What does `sourceName` do? Why do we need to
+8138,"@@ -179,8 +179,8 @@ func (brq *blockRetrievalQueue) Request(ctx context.Context, priority int, kmd K
+ 				brq.config.BlockCache().GetWithPrefetch(ptr)
+ 			if err == nil && cachedBlock != nil {
+ 				block.Set(cachedBlock, brq.config.codec())
+-				brq.triggerPrefetchAfterBlockRetrieved(
+-					cachedBlock, kmd, priority, hasPrefetched)
++				brq.Prefetcher().PrefetchAfterBlockRetrieved(
++					cachedBlock, ptr, kmd, priority, lifetime, hasPrefetched)
+ 				ch <- nil
+ 				return ch
+ 			}","I see that CI found a couple test hangs, maybe your `TogglePrefetcher` change below wasn't enough and this still needs to be a `go` invocation for some reason?",This only works if `cachedBlock == nil`?
+8139,"@@ -125,7 +125,7 @@ class DomainInfoCommand extends Command
+
+         $propertyExtractor = new ReflectionExtractor();
+         $io->writeln('You can access these properties:');
+-        $io->listing($propertyExtractor->getProperties($domainConfig));
++        $io->listing($propertyExtractor->getProperties(get_class($domainConfig)));
+     }
+
+     /**",I do not understand this change,"this is wrong, it should be `get_class($prope"
+8140,"@@ -5398,6 +5398,9 @@ type InputService24TestShapeInputService24TestCaseOperation1Input struct {
+
+ 	Header1 *string `location:""header"" type:""string""`
+
++	// By default keys received from the service api response will be formatted
++	// using net/http.CanonicalHeaderKey.
++	// Set aws.Config.LowerCaseHeaderMaps to `true` to lower case keys.
+ 	HeaderMap map[string]*string `location:""headers"" locationName:""header-map-"" type:""map""`
+ }
+ ",It would be helpful to clarify this is only for unmarshaling a response. not marshaling a request.,Nit: In the future we may want to introduce a `map[string]struct{}` for this instead of the `map[string]*string`.
+8141,"@@ -109,7 +109,7 @@ describe('nested-interactive virtual-rule', function() {
+
+     var results = axe.runVirtualRule('nested-interactive', node);
+
+-    assert.lengthOf(results.passes, 0);
++    assert.lengthOf(results.passes, 1);
+     assert.lengthOf(results.violations, 1);
+     assert.lengthOf(results.incomplete, 0);
+   });","I have no explanation for why this test wasn't erroring before... There are two applicable nodes in this tree, one passes, the other fails.",Shouldn't one of these be a `.length` instead?
+8142,"@@ -26,7 +26,7 @@
+
+ #ifdef HAVE_CONFIG_H
+ #include <config.h>
+-#endif // HAVE_CONFIG_H
++#endif // HAVE_CONFIG_Hrm
+
+ #include <glob.h>
+ #include <stdio.h>","Remove the ""rm"" from the end of ""HAVE_CONFIG_H""",@lgirdwood is `config.h` included in this file?
+8143,"@@ -15,3 +15,11 @@ func (p *FakeProver) CalculatePoSt(ctx context.Context, start, end *types.BlockH
+ 		Proofs: []types.PoStProof{[]byte(""test proof"")},
+ 	}, nil
+ }
++
++// TrivialTestSlasher is a storage fault slasher that does nothing
++type TrivialTestSlasher struct{}
++
++// Slash is a required function for storageFaultSlasher interfaces and is intended to do nothing.
++func (ts *TrivialTestSlasher) Slash(context.Context, *types.BlockHeight) error {
++	return nil
++}",Non-Blocking: This might be too trivial. It doesn't allow us to test that it's being callled.,why do we need a wrapper?
+8144,"@@ -278,6 +278,8 @@ switch (datatype)
+   case REC_INT_FRACTION: return extFormat? (char *)""INTERVAL FRACTION"":(char *)""REC_INT_FRACTION"";
+   case REC_BLOB: return extFormat? (char *)""BLOB"":(char *)""REC_BLOB"";
+   case REC_CLOB: return extFormat? (char *)""CLOB"":(char *)""REC_CLOB"";
++  case REC_BOOLEAN: return extFormat ? (char *)""BOOLEAN"" : (char *)""BOOLEAN"";
++
+   // When you add new datatype in /common/dfs2rec.h, don't
+   // forget add new case here. Otherwise, showplan won't display it.
+   default: return extFormat? (char *)""UNKNOWN"":(char *)""add datatype in getDatatypeAsString()"";","Not sure why the ternary expressions are used here, since the true and false results are the same.",(style) line over 80 characters
+8145,"@@ -263,7 +263,7 @@ func getTranslationFunc(driverName string) (func() translationFunc, error) {
+ 	switch driverName {
+ 	case ""sqlite3"":
+ 		return SqliteColumnTranslateFunc, nil
+-	case ""postgres"", ""sqlmock"":
++	case ""postgres"", ""sqlmock"", ""vertica"", ""vertigo"":
+ 		return PostgresColumnTranslateFunc, nil
+ 	case ""mysql"":
+ 		return MysqlColumnTranslateFunc, nil",Is `vertigo` another name for Vertica databases?,How is this related to vic-mach
+8146,"@@ -236,6 +236,7 @@ class HintActions:
+                utils.supports_selection())
+
+         urlstr = url.toString(QUrl.FullyEncoded | QUrl.RemovePassword)
++        urlstr = urlstr.lstrip('mailto:')
+         utils.set_clipboard(urlstr, selection=sel)
+
+         msg = ""Yanked URL to {}: {}"".format(","That doesn't do the right thing - it strips any of the characters m, a, i, l, t, o and :. It'd probably be cleaner to do this before converting the URL to a string.",Shouldn't this be urlstr = url.
+8147,"@@ -98,12 +98,14 @@ cliUtils.makeCommandArgs = function(cmd, argv) {
+ 		}
+ 	}
+
++
+ 	const args = yargParser(argv, {
+ 		boolean: booleanFlags,
+ 		alias: aliases,
+ 		string: ['_'],
+ 	});
+
++
+ 	for (let i = 1; i < cmdUsage['_'].length; i++) {
+ 		const a = cliUtils.parseCommandArg(cmdUsage['_'][i]);
+ 		if (a.required && !args['_'][i]) throw new Error(_('Missing required argument: %s', a.name));",Why the white space changes?,can we revert changes to this f
+8148,"@@ -0,0 +1,8 @@
++class LicenseMailerPreview < ActionMailer::Preview
++  def fullfillment_error
++    user = User.new(name: 'John Doe')
++    repository = Repository.first
++
++    LicenseMailer.fulfillment_error(repository, user)
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Style/ClassAndModuleChildren: Use nested module/class definitions instead of compact style.
+8149,"@@ -235,12 +235,11 @@ func (zone *ZoneDb) DomainLookupInaddr(inaddr string) (res []ZoneRecord, err err
+ func (zone *ZoneDb) startUpdatingName(name string) {
+ 	if zone.refreshInterval > 0 {
+ 		zone.mx.Lock()
+-		defer zone.mx.Unlock()
+-
+ 		// check if we should enqueue a refresh request for this name
+ 		n := zone.getNameSet(defaultRemoteIdent).getName(name, true)
++		now := zone.clock.Now()
++		zone.mx.Unlock() // Don't hold the lock while talking to the SchedQueue
+ 		if n.lastRefreshTime.IsZero() {
+-			now := zone.clock.Now()
+ 			n.lastRefreshTime = now
+
+ 			Debug.Printf(""[zonedb] Creating new immediate refresh request for '%s'"", name)","This is now outside the mutex, so could race.",what's the purpose of this line?
+8150,"@@ -43,11 +43,7 @@ import org.apache.lucene.index.SortedSetDocValues;
+ import org.apache.lucene.index.TermsEnum;
+ import org.apache.lucene.search.DocIdSetIterator;
+ import org.apache.lucene.search.SortedSetSelector;
+-import org.apache.lucene.store.ByteBuffersDataOutput;
+-import org.apache.lucene.store.ByteBuffersIndexOutput;
+-import org.apache.lucene.store.ChecksumIndexInput;
+-import org.apache.lucene.store.IOContext;
+-import org.apache.lucene.store.IndexOutput;
++import org.apache.lucene.store.*;
+ import org.apache.lucene.util.ArrayUtil;
+ import org.apache.lucene.util.BytesRef;
+ import org.apache.lucene.util.BytesRefBuilder;",hmmm did this pass spotless check? I don't think we typically use wildcard imports,Please revert `*` imports.
+8151,"@@ -222,8 +222,8 @@ func (j journalMDOps) getRangeFromJournal(
+ 	return irmds, nil
+ }
+
+-func (j journalMDOps) GetForHandle(
+-	ctx context.Context, handle *TlfHandle, mStatus MergeStatus) (
++func (j journalMDOps) GetForHandle(ctx context.Context, handle *TlfHandle,
++	mStatus MergeStatus, lockBeforeLock *keybase1.LockID) (
+ 	tlfID tlf.ID, rmd ImmutableRootMetadata, err error) {
+ 	// TODO: Ideally, *TlfHandle would have a nicer String() function.
+ 	j.jServer.log.LazyTrace(ctx, ""jMDOps: GetForHandle %+v %s"", handle, mStatus)",`lockBeforeLock` -> `lockBeforeGet` (here and everywhere below).,Does this need to be a `*keybase1.LockID`?
+8152,"@@ -12,7 +12,7 @@ import java.util.List;
+ import org.junit.Test;
+
+ import net.sourceforge.pmd.PMD;
+-import net.sourceforge.pmd.lang.java.ast.JavaParserConstants;
++import net.sourceforge.pmd.lang.java.ast.JavaTokenKinds;
+
+ public class JavaTokensTokenizerTest {
+ ","Do we need to internalize net.sourceforge.pmd.lang.java.ast.JavaParserConstants on master, so that we can rename it?",nit: unused import
+8153,"@@ -36,7 +36,7 @@ namespace Nethermind.Vault
+             {1, new Guid(""deca2436-21ba-4ff5-b225-ad1b0b2f5c59"")},
+             {3, new Guid(""66d44f30-9092-4182-a3c4-bc02736d6ae5"")},
+             {4, new Guid(""07102258-5e49-480e-86af-6d0c3260827d"")},
+-            {5, new Guid(""1b16996e-3595-4985-816c-043345d22f"")},
++            //{5, new Guid(""1b16996e-3595-4985-816c-043345d22f"")},
+             {42, new Guid(""8d31bf48-df6b-4a71-9d7c-3cb291111e27"")}
+         };
+ ","The GUID here was incorrect, because of that, Vault plugin loading was failing. Should I change to any correct GUID, or it has some special meaning?",why did you change
+8154,"@@ -84,9 +84,6 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests
+             // giving some breezing room for the End callback to complete
+             await Task.Delay(TimeSpan.FromSeconds(1));
+
+-            // Invokes the TestExporter which will invoke ProcessExport
+-            metricReader.Collect();
+-
+             this.meterProvider.Dispose();
+
+             var requestMetrics = metricItems","just confirming: if we remove explicit Collect(), then we are relying on the provider dispose... which has a hard-coded 5000 msec to finish flushing. On the other hand, if we keep explicit Collect(), we can pass an explicit timeout to it. (we were not doing it now and was relying on Infinite timeout). Net effect of this change in test code: Previously we would wait indefinitely for Collect() to be over. With this PR, we hope Collect() will be over in 5 secs. If we ever need more than 5 sec, we need to bring back Collect(maxTimeInMilliSecs..).",Why are we removin
+8155,"@@ -22,4 +22,16 @@ public class Constants {
+ 	public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";
+ 	public static final String DEFAULT_CONF_PATH = ""conf"";
+ 	public static final String AZKABAN_EXECUTOR_PORT_FILENAME = ""executor.port"";
++
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_GLOBAL_DISABLE = ""azkaban.logging.kafka.globalDisable"";
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_BROKERLIST = ""azkaban.logging.kafka.brokerList"";
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_TOPIC = ""azkaban.logging.kafka.topic"";
++
++  public static final String AZKABAN_FLOW_PROJECT_NAME = ""azkaban.flow.projectname"";
++  public static final String AZKABAN_FLOW_FLOW_ID = ""azkaban.flow.flowid"";
++  public static final String AZKABAN_FLOW_SUBMIT_USER = ""azkaban.flow.submituser"";
++  public static final String AZKABAN_FLOW_EXEC_ID = ""azkaban.flow.execid"";
++  public static final String AZKABAN_FLOW_PROJECT_VERSION = ""azkaban.flow.projectversion"";
++
++  public static final String AZKABAN_JOB_LOGGING_KAFKA_ENABLE = ""azkaban.job.logging.kafka.enable"";
+ }",What do you think of a name like azkaban.server.logging.kafka.brokerList? This way the name signals that this is a server config.,I would suggest to
+8156,"@@ -449,6 +449,12 @@ namespace NLog.Targets
+             get
+             {
+ #if SupportsMutex
++
++                if (!PlatformDetector.SupportsSharableMutex)
++                {
++                    return _concurrentWrites ?? false;  // Better user experience for mobile platforms
++                }
++
+                 return _concurrentWrites ?? true;
+ #else
+                 return _concurrentWrites ?? false;  // Better user experience for mobile platforms",Maybe change into `return _concurrentWrites ?? PlatformDetector.SupportsSharableMutex` ?,"Just curious, what's the difference between _concurrentWrites and !PlatformDetector.SupportsSharableMutex?"
+8157,"@@ -63,7 +63,8 @@ public class CircleStyleFinalizerTests {
+
+         finalizer.createCircleReport();
+
+-        String report = Resources.toString(targetFile.toURI().toURL(), StandardCharsets.UTF_8);
++        String report = Resources.toString(targetFile.toURI().toURL(), StandardCharsets.UTF_8)
++                .replaceAll(""\\p{Blank}*(?=<)"", """");
+         String expectedReport = Resources.toString(
+                 testFile(""two-namecheck-failures-checkstyle-report.xml""), StandardCharsets.UTF_8);
+ ",indentation of resulting file is different between 11 and 8 where 8 doesn't indent lines and 11 does,Is there a better way to do this?
+8158,"@@ -82,13 +82,14 @@ func (u *unaryTransportHandler) Handle(ctx context.Context, req *Request, reqBuf
+ 	}
+
+ 	if appErr != nil {
+-		// TODO: This is a bit odd; we set the error in response AND return it.
+-		// However, to preserve the current behavior of YARPC, this is
+-		// necessary. This is most likely where the error details will be added,
+-		// so we expect this to change.
++		encodedError, err := codec.EncodeError(appErr)
++		if err != nil {
++			return res, nil, err
++		}
++
+ 		errorInfo := yarpcerror.ExtractInfo(appErr)
+ 		res.ApplicationErrorInfo = &errorInfo
+-		return res, encodedBody, appErr
++		return res, encodedError, nil
+ 	}
+
+ 	return res, encodedBody, nil",Do we still need to return the `Response` here?,"We are encoding the error here again, isn't it?"
+8159,"@@ -18,3 +18,4 @@ if (global.document) {
+   }));
+   document.execCommand = jest.fn();
+ }
++global.VERDACCIO_API_URL = 'http://localhost/-/verdaccio/'",Here `global.VERDACCIO_API_URL` I'd use something different as `global.TEST_VERDACCIO_API_URL` then when you search by `VERDACCIO_API_URL` we don't confuse with `window.VERDACCIO_API_URL`,Could you explain why this is needed?
+8160,"@@ -57,6 +57,13 @@ public class DiscoveryFragmentGeneratorTool {
+             .hasArg()
+             .argName(""OUTPUT-DIRECTORY"")
+             .build());
++    options.addOption(
++        Option.builder()
++            .longOpt(""auth_url"")
++            .desc(""A comma delimited map of language to auth instructions URL."")
++            .hasArg()
++            .argName(""AUTH-URL"")
++            .build());
+
+     CommandLine cl = (new DefaultParser()).parse(options, args);
+     if (cl.hasOption(""help"")) {","This is totally fine, but consider whether in the future a YAML input format would be better. If so, we can plan for it.","Add `.longOpt(""auth_url"")` for consistency with the other options."
+8161,"@@ -277,6 +277,14 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+
++        /// <summary>
++        /// Configuration key for the semantic convention to be used.
++        /// The Tracer uses it to define operation names, span tags, statuses etc.
++        /// Default is <c>""Default""</c>.
++        /// <seealso cref=""TracerSettings.Convention""/>
++        /// </summary>
++        public const string Convention = ""DD_CONVENTION"";
++
+         /// <summary>
+         /// Configuration key for setting the API key, used by the Agent.
+         /// This key is here for troubleshooting purposes.",This should be `DD_TRACE_CONVENTION` to follow our ... conventions.,can we just call it `DD_CONVENTION` for consistency?
+8162,"@@ -241,8 +241,7 @@ Status VariablePropertyExpression::prepare() {
+
+
+ OptVariantType EdgeTypeExpression::eval(Getters &getters) const {
+-    UNUSED(getters);
+-    return *alias_;
++    return getters.getAliasProp(*alias_, *prop_);
+ }
+
+ Status EdgeTypeExpression::prepare() {",Be careful memory leaks. memory leaks occur when getters.getAliasProp == nullptr . right?,Could this just `return *alias_`?
+8163,"@@ -281,6 +281,7 @@ type readCache struct {
+
+ 	// This is for routes and gateways to have their own L1 as well that is account aware.
+ 	pacache map[string]*perAccountCache
++	losc    int64 // last orphan subs check
+
+ 	// This is for when we deliver messages across a route. We use this structure
+ 	// to make sure to only send one message and properly scope to queues as needed.",Why not just a time.Time?,Why was this added?
+8164,"@@ -213,7 +213,7 @@ class DefaultFormatBundle:
+                 continue
+             results[key] = DC(to_tensor(results[key]))
+         if 'gt_masks' in results:
+-            results['gt_masks'] = DC(results['gt_masks'], cpu_only=True)
++            results['gt_masks'] = DC(to_tensor(results['gt_masks']), cpu_only=True)
+         if 'gt_semantic_seg' in results:
+             results['gt_semantic_seg'] = DC(
+                 to_tensor(results['gt_semantic_seg'][None, ...]), stack=True)",Please do not submit a commit that is not part of this PR.,"`DC(to_tensor(results['gt_masks'], cpu_only=True))`"
+8165,"@@ -410,11 +410,11 @@ func (d *HandlerImpl) UpdateDomain(
+
+ 	if updateRequest.UpdatedInfo != nil {
+ 		updatedInfo := updateRequest.UpdatedInfo
+-		if updatedInfo.Description != nil {
++		if updatedInfo.GetDescription() != """" {
+ 			configurationChanged = true
+ 			info.Description = updatedInfo.GetDescription()
+ 		}
+-		if updatedInfo.OwnerEmail != nil {
++		if updatedInfo.GetOwnerEmail() != """" {
+ 			configurationChanged = true
+ 			info.OwnerEmail = updatedInfo.GetOwnerEmail()
+ 		}","This is small braking change: there is no way to clear description any more. If value is empty string, description will not be updated at all. It will affect existing Thrift endpoints also.",@deads2k @jsoriano is description always non-nil?
+8166,"@@ -16,5 +16,8 @@ func DNS01Record(domain, value string) (string, string, int) {
+ 	if err == nil && r.Rcode == dns.RcodeSuccess {
+ 		fqdn = updateDomainWithCName(r, fqdn)
+ 	}
+-	return fqdn, value, 60
++	if err != nil {
++		return """", """", 0, err
++	}
++	return fqdn, value, 60, nil
+ }",Can you open a separate PR with this patch? It seems valuable outside the context of this PR!,"I think this should be `return """", """", 0, err` to m"
+8167,"@@ -52,6 +52,9 @@ func (s *server) setupRouting() {
+ 	router.Handle(""/peers/{address}"", jsonhttp.MethodHandler{
+ 		""DELETE"": http.HandlerFunc(s.peerDisconnectHandler),
+ 	})
++	router.Handle(""/chunk/{address}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.hasChunkHandler),
++	})
+
+ 	baseRouter.Handle(""/"", web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""debug api access""),","I would suggest to have plurals in the api `""/chunks/{address}""`",why do we have to implement this?
+8168,"@@ -1365,6 +1365,7 @@ namespace pwiz.Skyline.Model
+             ALL_LABEL_SUBSTITUTIONS = ImmutableList.ValueOf(new[]
+         {
+             Tuple.Create(LabelAtoms.C13, BioMassCalc.C, BioMassCalc.C13),
++            Tuple.Create(LabelAtoms.C14, BioMassCalc.C, BioMassCalc.C14),
+             Tuple.Create(LabelAtoms.N15, BioMassCalc.N, BioMassCalc.N15),
+             Tuple.Create(LabelAtoms.O18, BioMassCalc.O, BioMassCalc.O18),
+             Tuple.Create(LabelAtoms.H2, BioMassCalc.H, BioMassCalc.H2),","Let's just not do this. We don't have LabelAtoms.O17 here. This is just a short-cut to avoid needing to write out a more verbose function like: 5O"" - 5O i.e. Add 5 x 17O atoms to replace 5 x 16O atoms. This was the original implementation in Skyline before I added the checkboxes to denote simply labeling all atoms in the amino acid.",should this be C13?
+8169,"@@ -56,7 +56,7 @@ def bootstrap_accept_mini(field, **kwargs):
+                          name=""submitButton"",
+                          type=""submit"",
+                          value=field.label.text,
+-                         onclick=""mini_approval('Accept', event, %s);"" % (objectid,),)
++                         onclick=""approval.mini_approval('Accept', event, %s);"" % (objectid,),)
+     return HTMLString(u''.join(html))
+
+ ","1:D100: Docstring missing 23:D400: First line should end with '.', not 'p' 23:D200: One-line docstring should not occupy 3 lines 36:D400: First line should end with '.', not 'n' 36:D200: One-line docstring should not occupy 3 lines 48:D400: First line should end with '.', not 'p' 48:D200: One-line docstring should not occupy 3 lines 63:D400: First line should end with '.', not 'p' 63:D200: One-line docstring should not occupy 3 lines 76:D400: First line should end with '.', not 'p' 76:D200: One-line docstring should not occupy 3 lines",This method doesn't
+8170,"@@ -73,6 +73,10 @@ class CarouselLoop extends Image
+     {
+         /** @var \Carousel\Model\Carousel $carousel */
+         foreach ($loopResult->getResultDataCollection() as $carousel) {
++            if (!file_exists($carousel->getUploadDir() . DS . $carousel->getFile())) {
++                continue;
++            }
++
+             $loopResultRow = new LoopResultRow($carousel);
+
+             $event = new ImageEvent();",Adding a warning or an error in the Thelia log would be a nice idea.,Don't you need to c
+8171,"@@ -26,6 +26,8 @@ var CONNECTED = 'connected';
+ var DESTROYING = 'destroying';
+ var DESTROYED = 'destroyed';
+
++const CONNECTION_EVENTS = ['error', 'close', 'timeout', 'parseError', 'connect', 'message'];
++
+ var _id = 0;
+
+ /**",nit: `Set` (and swap `forEach`s for `for (const i of CONNECTION_EVENTS)`),Where is this used?
+8172,"@@ -4,7 +4,7 @@ using System.Collections.Generic;
+ using System.Linq;
+ using System.Reflection;
+ using System.Reflection.Emit;
+-using System.Runtime.InteropServices;
++using Datadog.Trace.ClrProfiler.ExtensionMethods;
+ using Datadog.Trace.ClrProfiler.Helpers;
+ using Datadog.Trace.Configuration;
+ using Datadog.Trace.Logging;",nit: Is this `using` statement still needed?,I don't think we should remove this one.
+8173,"@@ -26,7 +26,7 @@ func (endpoint *identitiesApi) List(writer http.ResponseWriter, request *http.Re
+ 	idsSerializable := make([]identityDto, len(idArry))
+ 	for i, id := range idArry {
+ 		idsSerializable[i] = identityDto{
+-			Id: string(id),
++			Id: string(id.Id),
+ 		}
+ 	}
+ ",Dont need to cast `string` -> `string`,why not using `map[string]string`?
+8174,"@@ -35,6 +35,11 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	s.Addressbook.Put(address, addr)
++	if err := s.TopologyDriver.AddPeer(r.Context(), address); err != nil {
++		s.Logger.Debugf(""debug api: topologyDriver.AddPeer %s: %v"", addr, err)
++	}
++
+ 	jsonhttp.OK(w, peerConnectResponse{
+ 		Address: address.String(),
+ 	})",why doesn't the API return an error in this case?,why do we need to put it into the contex
+8175,"@@ -583,3 +583,18 @@ class InvalidInstanceMetadataError(Exception):
+     def __init__(self, msg):
+         final_msg = msg + '\n' + self.MSG
+         super(InvalidInstanceMetadataError, self).__init__(final_msg)
++
++
++class BaseEndpointResolverError(Exception):
++    """"""Base error for endpoint resolving errors.
++
++    Should never be raised directly, but clients can catch
++    this exception if they want to generically handle any errors
++    during the endpoint resolution process.
++
++    """"""
++
++
++class NoRegionError(BaseEndpointResolverError):
++    """"""No region was specified.""""""
++    fmt = 'You must specify a region.'",Not sure how particularly useful these exceptions are. Seem to be exceptions required in copying and pasting the EndpointResolver over. I wonder if it makes sense to move these out of ``exceptions.py``,What is the difference between `BaseEndp
+8176,"@@ -203,9 +203,6 @@ class Proposal < ActiveRecord::Base
+     end
+   end
+
+-
+-  ## delegated methods ##
+-
+   def public_identifier
+     self.delegate_with_default(:public_identifier) { ""##{self.id}"" }
+   end",Can we re-add this? I think that grouping is useful (though would be open to putting them in a mixin or something).,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+8177,"@@ -319,7 +319,7 @@ public class PartitionSpec implements Serializable {
+     private final Schema schema;
+     private final List<PartitionField> fields = Lists.newArrayList();
+     private final Set<String> partitionNames = Sets.newHashSet();
+-    private Map<Integer, PartitionField> timeFields = Maps.newHashMap();
++    private Map<String, PartitionField> partitionFields = Maps.newHashMap();
+     private int specId = 0;
+     private final AtomicInteger lastAssignedFieldId = new AtomicInteger(PARTITION_DATA_ID_START - 1);
+ ","Overall LGTM, one nit is that I think `partitionFields` here would be good to be renamed so that it's easy to tell it's just for collision detection. Also I wonder if we want to do this check for other transformations too (e.g. bucket, and record numBuckets in the string), so that we might be able to combine `fields` and `partitionFields` into potentially something like a LinkedHashMap?",nit: why not rename to `partitionFields`?
+8178,"@@ -34,6 +34,8 @@ class Config(object):
+                               datetime.datetime.now().strftime('%Y%m%d%H%M%S'))
+         self.identifier = None
+         self.force_no_cloudshell = bool(kwargs.get('no_cloudshell'))
++        self.service_account_key_path = kwargs.get(
++            'service_account_key_path') or None
+         self.config_filename = (kwargs.get('config') or
+                                 'forseti-setup-{}.cfg'.format(
+                                     self.datetimestamp))","Don't need the `or None` here as the flag will already default to None. Also, `some_dict.get('foo')` will also default to `None`.",is there a reason you chose `or None` vs `or None` here?
+8179,"@@ -68,6 +68,7 @@ storiesOf( 'Settings', module )
+ 		options: {
+ 			delay: 3000, // Wait for tabs to animate.
+ 		},
++		padding: 0,
+ 	} )
+ 	.add( 'Connected Services', () => {
+ 		const setupRegistry = ( registry ) => {","Please, use the default padding here.",Wouldn't it be better to use `useStyle` here?
+8180,"@@ -3,11 +3,12 @@
+ const Aspect = require('./operation').Aspect;
+ const OperationBase = require('./operation').OperationBase;
+ const resolveReadPreference = require('../utils').resolveReadPreference;
++const serverLacksFeature = require('../utils').serverLacksFeature;
+ const ReadConcern = require('../read_concern');
+ const WriteConcern = require('../write_concern');
+ const maxWireVersion = require('../core/utils').maxWireVersion;
+ const commandSupportsReadConcern = require('../core/sessions').commandSupportsReadConcern;
+-const MongoError = require('../error').MongoError;
++const MongoError = require('../core').MongoError;
+
+ const SUPPORTS_WRITE_CONCERN_AND_COLLATION = 5;
+ ",let's actually use the direct include: `require('../core/error').MongoError;`,Is `serverLacksFeature` used anywhere?
+8181,"@@ -227,6 +227,16 @@ def data(readonly=False):
+              ""How to open links in an existing instance if a new one is ""
+              ""launched.""),
+
++            ('new-instance-open-target.window',
++             SettingValue(typ.String(
++                 valid_values=typ.ValidValues(
++                     ('last-opened', ""Open new tabs in the last""
++                     ""opened window.""),
++                     ('last-focused', ""Open new tabs in the most""
++                     ""recently focused window."")
++                 )), 'last-focused'),
++             ""Which window to choose when opening links as new tabs.""),
++
+             ('log-javascript-console',
+              SettingValue(typ.String(
+                  valid_values=typ.ValidValues(","You're missing a space before the `""` here and below, but I'll fix it up when merging.",I think we should default to `None` he
+8182,"@@ -119,6 +119,11 @@ void testBookmarks(ROMol m) {
+   m.clearBondBookmark(777);
+ }
+
++void dump(STR_VECT &p) {
++  std::cerr << ""----------------------------------"" << std::endl;
++  for(size_t i=0;i<p.size();++i)
++    std::cerr << p[i] << std::endl;
++}
+ void testMolProps() {
+   BOOST_LOG(rdInfoLog)
+       << ""-----------------------\n Testing Mol Property Caches"" << std::endl;",remove this debugging code?,"Shouldn't this be `std::cerr << ""-----"
+8183,"@@ -22,14 +22,14 @@ class ParallelPostingsArray {
+   final static int BYTES_PER_POSTING = 3 * Integer.BYTES;
+
+   final int size;
+-  final int[] textStarts;
+-  final int[] intStarts;
+-  final int[] byteStarts;
++  final int[] textStarts; // maps term ID to the terms text start in the bytesHash
++  final int[] addressOffset; // maps term ID to current stream address
++  final int[] byteStarts; // maps term ID to stream start offset in the byte pool
+
+   ParallelPostingsArray(final int size) {
+     this.size = size;
+     textStarts = new int[size];
+-    intStarts = new int[size];
++    addressOffset = new int[size];
+     byteStarts = new int[size];
+   }
+ ",s/`terms text`/`terms's text`,Maps term ID to the terms text start i
+8184,"@@ -23,6 +23,7 @@ module.exports = class Form extends Plugin {
+       resultName: 'uppyResult',
+       getMetaFromForm: true,
+       addResultToForm: true,
++      replaceResultInFormWithNew: true,
+       submitOnSuccess: false,
+       triggerUploadOnSubmit: false
+     }",":bike: :derelict_house: , but maybe the default option should be `multipleResults: false` or `combineMultipleResults: false`? i feel like `replaceResultInFormWithNew` is very verbose but also doesn't immediately clarify what it's for.",Could you please rename this option to `replaceResultInForm`? Thanks!
+8185,"@@ -1,15 +1,16 @@
+ require ""rails_helper""
+
+-feature 'Visitor signs up for a subscription' do
++feature ""Visitor signs up for a subscription"" do
+   background do
+     create_plan
+   end
+
+-  scenario 'visitor signs up by navigating from landing page' do
++  scenario ""visitor signs up by navigating from landing page"", js: true do
+     create(:trail, :published)
+
+     visit root_path
+-    click_link ""Sign Up Now!""
++    click_link I18n.t(""subscriptions.new.sign_up_cta"")
++    show_email_and_username_form
+     fill_out_account_creation_form
+     fill_out_credit_card_form_with_valid_credit_card
+ ",Line is too long. [87/80],Are these feature changes supposed to be part of this PR?
+8186,"@@ -2,10 +2,8 @@
+ #  Copyright (C) 2006 Greg Landrum
+ #  This file is part of RDKit and covered by $RDBASE/license.txt
+ #
+-
+-
+-import argparse
+ import sys
++import argparse
+
+ from rdkit import Chem
+ from rdkit import Geometry",Are you using an automated tool for sorting the imports?,why did you change these lines?
+8187,"@@ -41,11 +41,11 @@ class ApiClient(object):
+     __metaclass__ = abc.ABCMeta
+
+     @abc.abstractmethod
+-    def fetch_bigquery_dataset_policy(self, project_id, dataset_id):
++    def fetch_bigquery_dataset_policy(self, project_number, dataset_id):
+         """"""Dataset policy Iterator for a dataset from gcp API call.
+
+         Args:
+-            project_id (str): id of the project to query.
++            project_number (str): id of the project to query.
+             dataset_id (str): id of the dataset to query.
+         """"""
+ ","If this is `project_number` now, can we also update the `id` the description?",dataset_id is already part of the args list
+8188,"@@ -132,6 +132,7 @@ func (s *receiveStream) readImpl(p []byte) (bool /*stream completed */, int, err
+ 				}
+ 				if deadlineTimer == nil {
+ 					deadlineTimer = utils.NewTimer()
++					defer deadlineTimer.Stop()
+ 				}
+ 				deadlineTimer.Reset(deadline)
+ 			}","* This will defer until the function returns. Are you sure this won't happen multiple times. * Alternatively, why is the deadline timer not defined outside the outer loop? * More generally, why are we looping in the first place instead of reading one frame and returning?",Looking at the code it seems like we also need to check for a `nil` deadline.
+8189,"@@ -36,10 +36,10 @@ namespace Datadog.Trace.Agent.Transports
+             _request.Headers.Add(name, value);
+         }
+
+-        public async Task<IApiResponse> PostAsync(ArraySegment<byte> traces)
++        public async Task<IApiResponse> PostAsync(ArraySegment<byte> traces, string contentType)
+         {
+             _request.Method = ""POST"";
+-            _request.ContentType = ""application/msgpack"";
++            _request.ContentType = contentType;
+             using (var requestStream = await _request.GetRequestStreamAsync().ConfigureAwait(false))
+             {
+                 await requestStream.WriteAsync(traces.Array, traces.Offset, traces.Count).ConfigureAwait(false);",Should we rename the traces parameter now that this isn't just traces?,"This should be `_request.ContentType = ""application/msgpack"";`"
+8190,"@@ -28,14 +28,14 @@ static void atomic_begin(struct wlr_drm_crtc *crtc, struct atomic *atom) {
+ 	atom->failed = false;
+ }
+
+-static bool atomic_end(int drm_fd, struct atomic *atom) {
++static bool atomic_end(int drm_fd, uint32_t flags, struct atomic *atom) {
+ 	if (atom->failed) {
+ 		return false;
+ 	}
+
+-	uint32_t flags = DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_NONBLOCK;
++	flags |= DRM_MODE_ATOMIC_TEST_ONLY;
+ 	if (drmModeAtomicCommit(drm_fd, atom->req, flags, NULL)) {
+-		wlr_log_errno(WLR_ERROR, ""Atomic test failed"");
++		wlr_log_errno(WLR_DEBUG, ""Atomic test failed"");
+ 		drmModeAtomicSetCursor(atom->req, atom->cursor);
+ 		return false;
+ 	}",I don't think it makes sense to have both `TEST_ONLY` and `NONBLOCK`. We should probably leave `NONBLOCK` out.,"Not related to this PR, but this function is called atom_close() which may re"
+8191,"@@ -109,7 +109,10 @@ static void touch_point_handle_surface_destroy(struct wl_listener *listener,
+ 		void *data) {
+ 	struct wlr_touch_point *point =
+ 		wl_container_of(listener, point, surface_destroy);
+-	touch_point_destroy(point);
++	// Touch point itself is destroyed on up event
++	point->surface = NULL;
++	wl_list_remove(&point->surface_destroy.link);
++	wl_list_init(&point->surface_destroy.link);
+ }
+
+ static struct wlr_touch_point *touch_point_create(",Need to remove the surface destroy listener (and `wl_list_init` it so that `touch_point_destroy` still works),The `wlr_touch_point_destroy()` function calls `wl_list_init()` on the `surfa
+8192,"@@ -31,7 +31,8 @@ class ResearchProjectsController < ApplicationController
+
+   def fetch_projects
+     Rails.cache.fetch([""research_projects"", funder_type], expires_in: expiry) do
+-      Thread.new { ExternalApis::OpenAireService.search(funder: funder_type) }.value
++      #Thread.new { ExternalApis::OpenAireService.search(funder: funder_type) }.value
++      ExternalApis::OpenAireService.search(funder: funder_type)
+     end
+   end
+ ",create ticket to investigate this,Missing space after #.
+8193,"@@ -90,7 +90,7 @@ typedef struct
+   struct sockaddr_storage addr;
+ } ipaddress_t;
+
+-static socklen_t address_length(ipaddress_t* ipaddr)
++PONY_API socklen_t address_length(ipaddress_t* ipaddr)
+ {
+   switch(ipaddr->addr.ss_family)
+   {","If we want to expose this for FFI use in the standard library, it needs to get either a `pony_` or `ponyint_` prefix to its name, for cleanliness of the function namespace. `pony_` means it is a public API meant for use by third party code, whereas `ponyint_` means it is internal. Unless there is a good reason to make it public, we should prefer to keep it internal because public functions require us to treat any changes to them as breaking changes in Pony. So, this function should end up named `ponyint_address_length`, or something else with that prefix.",This shouldn't be chan
+8194,"@@ -17,6 +17,8 @@ const (
+ 	OptionsWaitBeforeDelete = ""WAIT_BEFORE_DELETE""
+ 	// OptionsRedirectDetach Redirect detach to the node where volume is attached
+ 	OptionsRedirectDetach = ""REDIRECT_DETACH""
++	// OptionsDeviceFuseMount name of fuse mount device
++	OptionsDeviceFuseMount = ""DEV_FUSE_MOUNT""
+ )
+
+ func IsBoolOptionSet(options map[string]string, key string) bool {","Fuse for shared volumes is a px specific implementation. libopenstorage doesn't know about it, right? So should this be called DeviceVirtualMount (or something similar) instead?",Can we have a more des
+8195,"@@ -24,6 +24,13 @@ namespace Datadog.Trace.ClrProfiler
+
+         public ushort TargetSignatureTypesLength;
+
++        [MarshalAs(UnmanagedType.U1)]
++        public bool UseTargetMethodArgumentsToLoad;
++
++        public IntPtr TargetMethodArgumentsToLoad;
++
++        public ushort TargetMethodArgumentsToLoadLength;
++
+         public ushort TargetMinimumMajor;
+
+         public ushort TargetMinimumMinor;",`bool` vs `BOOL` in native side :),Shouldn't this be `uin
+8196,"@@ -17,6 +17,7 @@ const chromiumRebaseL10n = require('../lib/chromiumRebaseL10n')
+ const createDist = require('../lib/createDist')
+ const upload = require('../lib/upload')
+ const test = require('../lib/test')
++const lint = require('../lib/lint')
+
+ program
+   .version(process.env.npm_package_version)",I think maybe you moved it to util but this is still around and it should get it from util instead.,Can we use `require('./lib/lint')` instead of the full `lint` require?
+8197,"@@ -0,0 +1,16 @@
++class RepositoriesController < ApplicationController
++  def index
++    @catalog = Catalog.new
++  end
++
++  def show
++    repository = Repository.friendly.find(params[:id])
++    @offering = Offering.new(repository, current_user)
++
++    if @offering.user_has_license?
++      redirect_to repository.github_url
++    else
++      render template: ""products/show""
++    end
++  end
++end",Do we need to test the redirection?,Can we name this something more descriptive? Maybe `find_by_id`?
+8198,"@@ -372,12 +372,12 @@ public class EpisodesApplyActionFragment extends Fragment {
+     }
+
+     private void markedCheckedPlayed() {
+-        DBWriter.markItemPlayed(getActivity(), FeedItem.PLAYED, checkedIds.toArray());
++        DBWriter.markItemPlayed(FeedItem.PLAYED, checkedIds.toArray());
+         close();
+     }
+
+     private void markedCheckedUnplayed() {
+-        DBWriter.markItemPlayed(getActivity(), FeedItem.UNPLAYED, checkedIds.toArray());
++        DBWriter.markItemPlayed(FeedItem.UNPLAYED, checkedIds.toArray());
+         close();
+     }
+ ","Tsts, that's why... activity leak about to happen","I think this was the only place where we got this from, so I just remo"
+8199,"@@ -3160,6 +3160,9 @@ func (s *Server) startGWReplyMapExpiration() {
+ 				}
+ 			case cttl := <-s.gwrm.ch:
+ 				ttl = cttl
++				if !t.Stop() {
++					<-t.C
++				}
+ 				t.Reset(ttl)
+ 			case <-s.quitCh:
+ 				return",You should do a select here IMO just to be safe so we do not block forever.,"If the reader returns an error, the reset will block until the channel"
+8200,"@@ -119,7 +119,7 @@ type Node struct {
+ 	// Incoming messages for block mining.
+ 	MsgPool *core.MessagePool
+ 	// Messages sent and not yet mined.
+-	Outbox *core.MessageQueue
++	MsgQueue *core.MessageQueue
+
+ 	Wallet *wallet.Wallet
+ ",I'll replace this with the actual outbox object soon.,Why didn't you use `msgQueue`?
+8201,"@@ -218,6 +218,9 @@ class AnnotationTest extends TestCase
+      */
+     public function providerValidCodeParse(): iterable
+     {
++        $codebase = $this->project_analyzer->getCodebase();
++        $codebase->reportUnusedVariables();
++
+         return [
+             'nopType' => [
+                 '<?php","Providers are called *before* `setUp()`, so I don't think you can access properties here.",@wachterjohannes Is this somet
+8202,"@@ -11,7 +11,7 @@ namespace Xunit
+     /// Apply this attribute to your test method to specify an active issue.
+     /// </summary>
+     [TraitDiscoverer(""Xunit.NetCore.Extensions.ActiveIssueDiscoverer"", ""Xunit.NetCore.Extensions"")]
+-    [AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
++    [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = true)]
+     public class ActiveIssueAttribute : Attribute, ITraitAttribute
+     {
+         public ActiveIssueAttribute(int issueNumber, TestPlatforms platforms) { }",While this allows it to be applied does it correctly cause the entire class to be skipped?,The attribute is called `Activ
+8203,"@@ -143,6 +143,11 @@ def main():
+     if args.seed is not None:
+         logger.info(f'Set random seed to {args.seed}, '
+                     f'deterministic: {args.deterministic}')
++
++        # import torch.distributed as dist
++        # rank = dist.get_rank()
++        # args.seed = args.seed + rank
++
+         set_random_seed(args.seed, deterministic=args.deterministic)
+     cfg.seed = args.seed
+     meta['seed'] = args.seed",clean unnecessary modification.,This is the wrong place for th
+8204,"@@ -44,8 +44,8 @@ describe('createElement(jsx)', () => {
+ 	});
+
+ 	it('should set VNode#key property', () => {
+-		expect(<div />).to.have.property('key').that.is.undefined;
+-		expect(<div a=""a"" />).to.have.property('key').that.is.undefined;
++		expect(<div />).to.have.property('key').that.is.empty;
++		expect(<div a=""a"" />).to.have.property('key').that.is.empty;
+ 		expect(<div key=""1"" />).to.have.property('key', '1');
+ 	});
+ ",I think these assertions want to be `.to.not.exist` which would pass for `null` or `undefined`,The warning here was that the `expect(<div />).to.have.property('key')` was undefined.
+8205,"@@ -24,11 +24,9 @@ import (
+ )
+
+ func ExampleOpenKeeper() {
+-	// This example is used in https://gocloud.dev/howto/secrets/#vault-ctor
+-
+-	// import _ ""gocloud.dev/secrets/hashivault""
+-
+-	// Variables set up elsewhere:
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/secrets/hashivault""
++	// PRAGMA(gocloud.dev): Skip until next blank line.
+ 	ctx := context.Background()
+
+ 	// Get a client to use with the Vault API.",Don't think you need this since this is not a URL example.,You can do `gocloud.dev/secrets/hashivault` directly in here.
+8206,"@@ -43,6 +43,14 @@ class TestFakerNumber < Test::Unit::TestCase
+     assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
+   end
+
++  def test_decimal_within
++    assert @tester.decimal_within(l_digits: 1, r_digits: 1, range: 0..1).to_s.match(/[0-1]{1}\.[0-1]{1}/)
++    assert @tester.decimal_within(l_digits: 1).to_s.match(/[0-9]{1}\.[0-9]{2}/)
++    assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
++    assert @tester.decimal_within(l_digits: 3, r_digits: 3, range: 1..100).to_s.match(/[0-9]*\.[0-9]*/)
++    assert @tester.decimal_within(l_digits: 3, r_digits: 3, range: 1..1000).to_s.match(/[0-9]*\.[0-9]*/)
++  end
++
+   def test_digit
+     assert @tester.digit.to_s.match(/[0-9]{1}/)
+     assert((1..1000).collect { |_i| @tester.digit == 9 }.include?(true))","Maybe a test to check if the generated value is within the boundaries would be nice, what do you think?",is it worth having one test that checks that `decimal_within` matches what is expected
+8207,"@@ -12,7 +12,7 @@ namespace AutoRest.Core.Utilities
+     {
+         public void WriteFile(string path, string contents)
+         {
+-            File.WriteAllText(path, contents, Encoding.UTF8);
++            File.WriteAllText(path, contents, new UTF8Encoding(false, true));
+         }
+
+         /// <summary>",Suppresses UTF-8 BOM in outputs,Why are we enabling UTF8 here?
+8208,"@@ -65,10 +65,10 @@ type Config struct {
+ 	Inbounds  Inbounds
+ 	Outbounds Outbounds
+
+-	// Filter and Interceptor that will be applied to all outgoing and incoming
+-	// requests respectively.
+-	Filter      transport.Filter
+-	Interceptor transport.Interceptor
++	// Inbound and Outbound Middleware that will be applied to all outgoing and
++	// incoming requests respectively.
++	InboundMiddleware  InboundMiddleware
++	OutboundMiddleware OutboundMiddleware
+
+ 	Tracer opentracing.Tracer
+ }","order wrong for ""outgoing and incoming""",Would it make sense to rename `InboundMiddleware` to `InboundMiddlewareMiddleware` for clarity?
+8209,"@@ -43,6 +43,7 @@ public class MemoryCircuitBreaker extends CircuitBreaker {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+   private static final MemoryMXBean MEMORY_MX_BEAN = ManagementFactory.getMemoryMXBean();
+
++  private boolean isMemoryCircuitBreakerEnabled;
+   private final long heapMemoryThreshold;
+
+   // Assumption -- the value of these parameters will be set correctly before invoking getDebugInfo()","We know it's a boolean and it's in the MemoryCircuitBreaker, why not simply call it `enabled` (like many other Solr plugins do)?",This field is not initialized in the constructor (see `setMemoryCircuitBreakerEnabled()`)
+8210,"@@ -0,0 +1,5 @@
++class AddIncludesTeamToIndividualPlans < ActiveRecord::Migration
++  def change
++    add_column :individual_plans, :includes_team, :boolean, default: false
++  end
++end","Should team be a ""feature"" that can be ""included"" or a type? In code it seems to me that a `team` flag makes sense.",Line is too long. [91/90]
+8211,"@@ -172,6 +172,9 @@ type OutputInfo struct {
+ }
+
+ func (i *InputParams) updateParams(p *string) {
++	logParamsMutex.Lock()
++	defer logParamsMutex.Unlock()
++
+ 	if p == nil {
+ 		return
+ 	}",Why is this called update params when it's updating project info? Should p called project?,don't need this mutex.
+8212,"@@ -44,7 +44,8 @@ const (
+ 	// below are templates for history_tree table
+ 	addHistoryTreeQuery = `INSERT INTO history_tree (` +
+ 		`shard_id, tree_id, branch_id, data, data_encoding) ` +
+-		`VALUES (:shard_id, :tree_id, :branch_id, :data, :data_encoding) `
++		`VALUES (:shard_id, :tree_id, :branch_id, :data, :data_encoding) ` +
++		`ON DUPLICATE KEY UPDATE data=VALUES(data), data_encoding=VALUES(data_encoding)`
+
+ 	getHistoryTreeQuery = `SELECT branch_id, data, data_encoding FROM history_tree WHERE shard_id = ? AND tree_id = ? `
+ ",`upsertHistoryTreeQuery` is a better name for this query now. Is it ok to change history?,It's better to separate history_tree and repo_tree to have the same structure. Each tree has its own history_tree table. Each tree_tree should have its own history_tree table.
+8213,"@@ -33,8 +33,12 @@ namespace Nethermind.Core
+             }
+             string date = DateTime.Now.ToString(""yyyyMMdd"");
+             string gitTag = File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-hash"")) ? File.ReadAllText(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-hash"")).Trim().Replace(""g"", """") : string.Empty;
+-
+-            Description = $""Nethermind/v{gitTag}-{date}/{RuntimeInformation.OSArchitecture}-{osDescription}/{RuntimeInformation.FrameworkDescription.Trim().Replace("".NET "", """").Replace("" "", """")}"";
++            string gitBranch = File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-branch"")) ? File.ReadAllText(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-branch"")).Trim().Replace(""/"", ""-"") : string.Empty;
++            if (gitBranch != ""master"")
++            {
++                gitTag = gitTag.Insert(5, ""b"");
++            }
++            Description = $""Nethermind/v{gitTag}-{date}/{gitBranch}/{RuntimeInformation.OSArchitecture}-{osDescription}/{RuntimeInformation.FrameworkDescription.Trim().Replace("".NET "", """").Replace("" "", """")}"";
+         }
+
+         public static string Version { get; }",b did not mean branch - it meant the next version - so probably better to be able to release from a tag on the branch so we can create a hotfix branch of the 1.4.1 tag and tag it 1.4.1b and then version is picked as 1.4.1b,Why do we need this? Is `git-tag` always going to be the same as `date`?
+8214,"@@ -9,7 +9,6 @@
+  *  Created on: Jul 26, 2017
+  *      Author: William F Godoy godoywf@ornl.gov
+  */
+-#include <mpi.h>
+
+ #include <ios>       //std::ios_base::failure
+ #include <iostream>  //std::cout","Keep the mpi.h include, just move it to after adios2.h and guard with the ifdef. Otherwise everything else looks good.",Please don't remove the linefeed here.
+8215,"@@ -72,8 +72,12 @@ type Config struct {
+ 	// bind mounts are writtable.
+ 	Readonlyfs bool `json:""readonlyfs""`
+
+-	// Privatefs will mount the container's rootfs as private where mount points from the parent will not propogate
+-	Privatefs bool `json:""privatefs""`
++	// RootfsMountMode is the rootfs mount propagation mode.
++	// On linux it is one of the followings:
++	// ""private"": rootfs is mounted as MS_PRIVATE
++	// ""shared"": rootfs is mounted as MS_SHARED
++	// ""slave"": rootfs is mounted as MS_SLAVE
++	RootfsMountMode PropagationMode `json:""root_mount_mode""`
+
+ 	// Mounts specify additional source and destination paths that will be mounted inside the container's
+ 	// rootfs and mount namespace if specified",Shouldn't this be something like `rootmountmode` to fit the pattern of the other fields' serialized representations?,Can we drop `Privatefs` from this struct now that it's part of the public API?
+8216,"@@ -747,9 +747,7 @@ void Cuda::impl_initialize(const Cuda::SelectDevice config,
+                            size_t /*num_instances*/) {
+   Impl::CudaInternal::singleton().initialize(config.cuda_device_id, 0);
+
+-#if defined(KOKKOS_ENABLE_PROFILING)
+   Kokkos::Profiling::initialize();
+-#endif
+ }
+
+ std::vector<unsigned> Cuda::detect_device_arch() {",Why were we initializing here in the first place?,Is there a specific reason for removing this?
+8217,"@@ -0,0 +1,7 @@
++namespace MvvmCross.Core.Platform.LogProviders
++{
++    internal sealed class NullLogProvider : MvxBaseLogProvider
++    {
++        protected override Logger GetLogger(string name) => new Logger((logLevel, messageFunc, exception, formatParameters) => true);
++    }
++}","This should be removed, and instead set the logger to None.",nit: can we rename this to `NullLogProvider`
+8218,"@@ -49,7 +49,7 @@ function UndoRedo(instance) {
+       return;
+     }
+
+-    var originalData = plugin.instance.getSourceDataArray();
++    var originalData = plugin.instance.getSourceData();
+
+     index = (originalData.length + index) % originalData.length;
+ ",Storing a reference to source data isn't the best choice. Maybe you can find a different way (without storing the reference) to save removed data?,Does this change behavior? I'm guessing it do
+8219,"@@ -7761,7 +7761,7 @@ void UDR::processData(UDRInvocationInfo &info,
+  *
+  *  This method is called in debug Trafodion builds when certain
+  *  flags are set in the UDR_DEBUG_FLAGS CQD (CONTROL QUERY DEFAULT).
+- *  See https://wiki.trafodion.org/wiki/index.php/Tutorial:_The_object-oriented_UDF_interface#Debugging_UDF_code
++ *  See https://cwiki.apache.org/confluence/display/TRAFODION/Tutorial%3A+The+object-oriented+UDF+interface#Tutorial:Theobject-orientedUDFinterface-DebuggingUDFcode
+  *  for details.
+  *
+  *  The default implementation prints out the process id and then",Is the tutorial going to move to the new Trafodion website or will it stay on the Confluence wiki? (Check with Gunnar.),"Nitpicking: ""the"" should be ""the""."
+8220,"@@ -55,10 +55,8 @@ func FromStatus(st *status.Status) error {
+ 		switch errDetails := errDetails.(type) {
+ 		case *errordetails.ShardOwnershipLostFailure:
+ 			return newShardOwnershipLost(st, errDetails)
+-		case *errordetails.RetryTaskFailure:
+-			return newRetryTask(st, errDetails)
+ 		case *errordetails.RetryTaskV2Failure:
+-			return newRetryTaskV2(st, errDetails)
++			return convertRetryReplication(st, errDetails)
+ 		}
+ 	}
+ ",maybe call it `fromRetryTaskV2Failure`,RetryTaskFailure is now handled in convertRetryReplication.
+8221,"@@ -16,11 +16,13 @@ package com.google.api.codegen.transformer.php;
+
+ import com.google.api.codegen.InterfaceView;
+ import com.google.api.codegen.config.FieldConfig;
++import com.google.api.codegen.config.FlatteningConfig;
+ import com.google.api.codegen.config.GapicProductConfig;
+ import com.google.api.codegen.config.GrpcStreamingConfig.GrpcStreamingType;
+ import com.google.api.codegen.metacode.InitCodeContext;
+ import com.google.api.codegen.metacode.InitCodeContext.InitCodeOutputType;
+ import com.google.api.codegen.php.PhpGapicCodePathMapper;
++import com.google.api.codegen.transformer.DynamicLangApiMethodTransformer;
+ import com.google.api.codegen.transformer.FileHeaderTransformer;
+ import com.google.api.codegen.transformer.GapicInterfaceContext;
+ import com.google.api.codegen.transformer.GapicMethodContext;","The diff for this class is difficult to walk through because I reorganized it to be much more clear. There are improvements throughout, but the most important are in the new `createSmokeTest.*` methods.",I think all these import changes are unused now
+8222,"@@ -164,6 +164,12 @@ class BaseDetector(BaseModule, metaclass=ABCMeta):
+         should be double nested (i.e.  List[Tensor], List[List[dict]]), with
+         the outer list indicating test time augmentations.
+         """"""
++        img_norm_cfg = kwargs.get('img_norm_cfg', None)
++        if img_norm_cfg:
++            mean = torch.tensor(img_norm_cfg['mean'])[None, ..., None, None]
++            std = torch.tensor(img_norm_cfg['std'])[None, ..., None, None]
++            img = (img - mean) / std
++
+         if torch.onnx.is_in_onnx_export():
+             assert len(img_metas) == 1
+             return self.onnx_export(img[0], img_metas[0])",We suggest keeping this logic in lines between 173-175 to restrict its influence.,"If `img_norm_cfg` is not None, then `mean` and `std` will b"
+8223,"@@ -88,7 +88,7 @@ class GridView
+      * @param string $name
+      * @param array $parameters
+      * @param bool $echo
+-     * @return string|null
++     * @return string|null|void
+      */
+     public function renderBlock($name, array $parameters = [], $echo = true)
+     {",why not ? maybe another phpstan plugin,should be `string|null`
+8224,"@@ -37,14 +37,16 @@ namespace Nethermind.JsonRpc.Modules.Trace
+         private readonly ITracer _tracer;
+         private readonly IBlockFinder _blockFinder;
+         private readonly TransactionDecoder _txDecoder = new TransactionDecoder();
+-        private readonly CancellationToken _cancellationToken;
++        private readonly IJsonRpcConfig _jsonRpcConfig;
++        private readonly TimeSpan _cancellationTokenTimeout;
+
+-        public TraceModule(IReceiptFinder receiptFinder, ITracer tracer, IBlockFinder blockFinder, CancellationToken cancellationToken = default(CancellationToken))
++        public TraceModule(IReceiptFinder receiptFinder, ITracer tracer, IBlockFinder blockFinder, IJsonRpcConfig jsonRpcConfig)
+         {
+-            _cancellationToken = cancellationToken;
+             _receiptFinder = receiptFinder ?? throw new ArgumentNullException(nameof(receiptFinder));
+             _tracer = tracer ?? throw new ArgumentNullException(nameof(tracer));
+             _blockFinder = blockFinder ?? throw new ArgumentNullException(nameof(blockFinder));
++            _jsonRpcConfig = jsonRpcConfig ?? throw new ArgumentNullException(nameof(jsonRpcConfig));
++            _cancellationTokenTimeout = TimeSpan.FromMilliseconds(_jsonRpcConfig.TracerTimeout);
+         }
+
+         private static ParityTraceTypes GetParityTypes(string[] types)",That was a really bad CR from me before if I did not spot it.,this can be removed if we make `JsonRpcConfig` a constructor parameter
+8225,"@@ -203,7 +203,15 @@ EOF
+ echo ""$FORSETI_ENV"" > $USER_HOME/forseti_env.sh
+
+ USER=ubuntu
+-(echo ""{run_frequency} $FORSETI_HOME/setup/gcp/scripts/run_forseti.sh"") | crontab -u $USER -
++
++# Use flock to prevent rerun of the same cron job when the previous job is still running.
++# If the lock file does not exist under the tmp directory, it will create the file and put a lock on top of the file.
++# When the previous cron job is not finished and the new one is trying to run, it will attempt to acquire the lock
++# to the lock file and fail because the file is already locked by the previous process.
++# The -n flag in flock will fail the process right away when the process is not able to acquire the lock so we won't
++# queue up the jobs.
++
++(echo ""{run_frequency} /usr/bin/flock -n /tmp/forseti_cron_runner.lock $FORSETI_HOME/setup/gcp/scripts/run_forseti.sh"") | crontab -u $USER -
+ echo ""Added the run_forseti.sh to crontab under user $USER""
+
+ echo ""Execution of startup script finished""","Does this resolve the scenario when the user-triggered forseti process is running, and it would be killed by the cron job restarting the server?","`/usr/bin/forseti_cron_runner.lock` should be enough, no?"
+8226,"@@ -157,7 +157,6 @@ func (ops *OpStream) Intc(constIndex uint) {
+ 	} else {
+ 		ops.trace(""intc %d %d"", constIndex, ops.intc[constIndex])
+ 	}
+-	ops.tpush(StackUint64)
+ }
+
+ // Uint writes opcodes for loading a uint literal",Does this happen somewhere else now?,Is there a test we can write for this?
+8227,"@@ -749,7 +749,8 @@ import browser from './browser';
+         }
+
+         // Support H264 Level 52 (Tizen 5.0) - app only
+-        if (browser.tizenVersion >= 5 && window.NativeShell) {
++        if ((browser.tizenVersion >= 5 && window.NativeShell) ||
++            videoTestElement.canPlayType('video/mp4; codecs=""avc1.640834""').replace(/no/, '')) {
+             maxH264Level = 52;
+         }
+ ","Remove trailing space at this line, amend the commit, and then force-push.","I don't think this is correct, `canPlayType` is supposed to return fal"
+8228,"@@ -21,6 +21,8 @@ import (
+ 	""testing""
+ 	""time""
+
++	""go.opentelemetry.io/api/trace""
++
+ 	""google.golang.org/grpc/codes""
+
+ 	""go.opentelemetry.io/api/core""","This should be grouped together with the import of ""go.opentelemetry.io/{api/core,sdk/export}"" below.",Can you move this to the bottom with the rest of the standard library imports?
+8229,"@@ -66,10 +66,14 @@ REQUIREMENTS_MAP = {
+         {'module_name': 'instance_network_interface_scanner',
+          'class_name': 'InstanceNetworkInterfaceScanner',
+          'rules_filename': 'instance_network_interface_rules.yaml'},
++    'ke_scanner':
++        {'module_name': 'ke_scanner',
++         'class_name': 'KeScanner',
++         'rules_filename': 'ke_rules.yaml'},
+     'ke_version_scanner':
+         {'module_name': 'ke_version_scanner',
+          'class_name': 'KeVersionScanner',
+-         'rules_filename': 'ke_rules.yaml'},
++         'rules_filename': 'ke_version_rules.yaml'},
+     'log_sink':
+         {'module_name': 'log_sink_scanner',
+          'class_name': 'LogSinkScanner',","What's the impact to people upgrading to the new version? If they don't change their file names, they'll suddenly be broken. While I agree that your naming makes more intuitive sense, I think we need to maintain backwards compatibility. Please choose a new rules file name for the new scanner and keep ke_rules.yaml for the existing version scanner.",The module name should be `ke_scanner`.
+8230,"@@ -698,7 +698,7 @@ class InternalFrame(object):
+         index_spark_columns = self.index_spark_columns
+         return index_spark_columns + [
+             spark_column
+-            for label, spark_column in zip(self.column_labels, self.data_spark_columns)
++            for spark_column in self.data_spark_columns
+             if all(not spark_column._jc.equals(scol._jc) for scol in index_spark_columns)
+         ]
+ ","Shall we add some docstrings clearly to describe when to use which clearly? For example, `spark_frame` now should always be used via `df._internal.applied.spark_frame` for Spark DataFrame APIs that internally creates new query execution plan with the different output length. For expressions and/or functions, `df._internal.spark_frame` should be used together with Spark column instances, in order to avoid the operations on different DataFrames.",Is it necessary to change `index_spark_columns` to a list comprehension?
+8231,"@@ -54,8 +54,8 @@ class DataFrame(_Frame):
+         Dict can contain Series, arrays, constants, or list-like objects
+         If data is a dict, argument order is maintained for Python 3.6
+         and later.
+-        Note that if `data` is a Pandas DataFrame other arguments are ignored.
+-        If data is a Spark DataFrame, all other arguments except `index` is ignored.
++        Note that if `data` is a Pandas DataFrame, other arguments should not be used
++        If `data` is a Spark DataFrame, all other arguments except `index` should not be used.
+     index : Index or array-like
+         Index to use for resulting frame. Will default to RangeIndex if
+         no indexing information part of input data and no index provided",nit: `.` at the end of line?,I think it should be `other arguments except index is ignored.`
+8232,"@@ -2012,7 +2012,16 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
+
+     private void updateFooterView() {
+         if (!mSearch.isManualSearch() && mCurrentFolder != null && mAccount != null) {
+-            if (mCurrentFolder.loading) {
++            int msg=100;
++            try {
++                msg=mCurrentFolder.folder.getMessageCount();
++            } catch (MessagingException e) {
++                e.printStackTrace();
++            }
++            if (msg==0){
++                updateFooter(mContext.getString(R.string.no_email));
++            }
++            else if (mCurrentFolder.loading) {
+                 updateFooter(mContext.getString(R.string.status_loading_more));
+             } else if (!mCurrentFolder.moreMessages) {
+                 updateFooter(null);","I'm not sure I agree that this should take priority over ""Loading"".",Can you change this to `else if (mCurrentFolder.loading) {`?
+8233,"@@ -237,8 +237,6 @@ class PySparkTask(SparkSubmitTask):
+
+     # Path to the pyspark program passed to spark-submit
+     app = os.path.join(os.path.dirname(__file__), 'pyspark_runner.py')
+-    # Python only supports the client deploy mode, force it
+-    deploy_mode = ""client""
+
+     @property
+     def name(self):",Was this an intentional deletion? Why not just allow overwrite of `deploy_mode`?,"If you remove this, you can still run the test with `pyspark"
+8234,"@@ -168,7 +168,16 @@ func (c *CStorVolumeReplicaController) syncHandler(
+ 	// Synchronize cstor volume total allocated and
+ 	// used capacity fields on CVR object.
+ 	// Any kind of sync activity should be done from here.
+-	c.syncCvr(cvrGot)
++	err = c.syncCvr(cvrGot)
++	if err != nil {
++		c.recorder.Event(
++			cvrGot,
++			corev1.EventTypeWarning,
++			""SyncFailed"",
++			fmt.Sprintf(""failed to sync CVR error: %s"", err.Error()),
++		)
++		return nil
++	}
+
+ 	_, err = c.clientset.
+ 		OpenebsV1alpha1().",better to call it as syncCVRStatus.. just syncCVR is very confusing,Should we also record an event if there is an error syncing
+8235,"@@ -29,11 +29,14 @@ var (
+ 	errAppDeleteCancelled = errors.New(""app delete cancelled - no changes made"")
+ )
+
+-type deleteAppOpts struct {
+-	// Flags or arguments that are user inputs.
++type deleteAppVars struct {
+ 	*GlobalOpts
+ 	SkipConfirmation bool
+ 	AppName          string
++}
++
++type deleteAppOpts struct {
++	deleteAppVars
+
+ 	// Interfaces to dependencies.
+ 	projectService   projectService",should we make this not a pointer? so that when we embed the struct a copy is made instead of modifying the original object.,"Not necessarily for this PR, but is there a reason for this "
+8236,"@@ -99,9 +99,9 @@ class BaseWebTest(object):
+     def get_app_settings(self, additional_settings=None):
+         settings = DEFAULT_SETTINGS.copy()
+
+-        settings['storage_backend'] = 'kinto.core.storage.redis'
+-        settings['cache_backend'] = 'kinto.core.cache.redis'
+-        settings['permission_backend'] = 'kinto.core.permission.redis'
++        settings['storage_backend'] = 'kinto_redis.storage'
++        settings['cache_backend'] = 'kinto_redis.cache'
++        settings['permission_backend'] = 'kinto_redis.permission'
+
+         settings['project_name'] = 'myapp'
+         settings['project_version'] = '0.0.1'",Does this mean that `kinto_redis` is required to run tests?,Can we move these settings to the `kinto_redis` package?
+8237,"@@ -475,7 +475,7 @@ function mergeBatchResults(batch, bulkResult, err, result) {
+   if (Array.isArray(result.writeErrors)) {
+     for (let i = 0; i < result.writeErrors.length; i++) {
+       const writeError = {
+-        index: batch.originalZeroIndex + result.writeErrors[i].index,
++        index: batch.originalIndexes[i],
+         code: result.writeErrors[i].code,
+         errmsg: result.writeErrors[i].errmsg,
+         op: batch.operations[result.writeErrors[i].index]",will this ensure the indexes for ordered writes as well?,why do we have an error index of 0 if the writeErrors ar
+8238,"@@ -28,7 +28,11 @@ from nupic.support.lockattributes import LockAttributesMixin
+ import functools
+
+ basicTypes = ['Byte', 'Int16', 'UInt16', 'Int32', 'UInt32', 'Int64', 'UInt64',
+-              'Real32', 'Real64', 'Handle']
++              'Real32', 'Real64', 'Handle', 'Bool']
++
++arrayTypes = ['ByteArray', 'Int16Array', 'UInt16Array', 'Int32Array',
++              'UInt32Array', 'Int64Array', 'UInt64Array', 'Real32Array',
++              'Real64Array', 'BoolArray']
+
+ pyRegions = (
+     (""nupic.regions.AnomalyRegion"", ""AnomalyRegion""),",Put `BoolArray` first?,do we need to add `Bool` type?
+8239,"@@ -0,0 +1,3 @@
++window.appMode = 'standalone';
++
++import('./site');",I believe this whole file can be deleted now.,Do we need to import this file?
+8240,"@@ -34,6 +34,17 @@ var (
+ 		Usage: ""Port for listening incoming api requests"",
+ 		Value: 4050,
+ 	}
++
++	promiseCurrencyFlag = cli.StringFlag{
++		Name:  ""promise.currency"",
++		Usage: ""Type of currency that will be used for issuing promises"",
++		Value: ""MYST"",
++	}
++	promiseAmountFlag = cli.IntFlag{
++		Name:  ""promise.amount"",
++		Usage: ""Amount of money that will be used for issuing a single promise"",
++		Value: 100,
++	}
+ )
+
+ // RegisterFlagsNode function register node flags to flag list","We should specify format for a user. I.e: Integer, 1000 == 1 MYST",perhaps change the name to `promise.amount` to be consistent with the other flags?
+8241,"@@ -132,6 +132,12 @@ func runControllers(ctx context.Context, config *Config) error {
+ 		}
+ 	}
+
++	for _, controller := range config.Controllers {
++		if err := controller(ctx, sc); err != nil {
++			return errors.Wrap(err, ""controller"")
++		}
++	}
++
+ 	if err := sc.Start(ctx); err != nil {
+ 		return err
+ 	}","Does the errors returned from these controllers indicate which controller threw the error? If not, there might be some value in making the ""CustomControllers"" type a `map[string]func(ctx context.Context, sc *server.Context) error` with the name of the controller as the key and include the key in this error string. This would apply for below as well.","This should probably be `errors.Wrapf(err, ""controller"")`"
+8242,"@@ -2204,8 +2204,13 @@ CheckedError Parser::DoParse(const char *source,
+       }
+       uoffset_t toff;
+       ECHECK(ParseTable(*root_struct_def_, nullptr, &toff));
+-      builder_.Finish(Offset<Table>(toff),
+-                file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      if (opts.prefix_size) {
++        builder_.FinishSizePrefixed(Offset<Table>(toff),
++                  file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      } else {
++        builder_.Finish(Offset<Table>(toff),
++                  file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      }
+     } else if (IsIdent(""enum"")) {
+       ECHECK(ParseEnum(false, nullptr));
+     } else if (IsIdent(""union"")) {",maybe at least pull the file identifier arg out of the if?,This could just be `if (prefix_size_ && !opts.prefix_size_) {`.
+8243,"@@ -1028,17 +1028,13 @@ class CommandDispatcher:
+             raise cmdexc.CommandError(""Can't move tab to position {}!"".format(
+                 new_idx + 1))
+
+-        tab = self._current_widget()
+         cur_idx = self._current_index()
+-        icon = self._tabbed_browser.tabIcon(cur_idx)
+-        label = self._tabbed_browser.page_title(cur_idx)
+         cmdutils.check_overflow(cur_idx, 'int')
+         cmdutils.check_overflow(new_idx, 'int')
+         self._tabbed_browser.setUpdatesEnabled(False)
+         try:
+             color = self._tabbed_browser.tab_indicator_color(cur_idx)
+-            self._tabbed_browser.removeTab(cur_idx)
+-            self._tabbed_browser.insertTab(new_idx, tab, icon, label)
++            self._tabbed_browser.tabBar().moveTab(cur_idx, new_idx)
+             self._set_current_index(new_idx)
+             self._tabbed_browser.set_tab_indicator_color(new_idx, color)
+         finally:","You can most likely remove that (and the try/finally) too, as we shouldn't have any flickering from removing/inserting tabs anymore now.",Is there a reason to use `tabBar()` instead of `self._tabbed_browser`?
+8244,"@@ -19,12 +19,15 @@ const localHooks = {
+    *
+    * @param {String} key Hook name.
+    * @param {Function} callback Hook callback
++   * @return {Object}
+    */
+   addLocalHook(key, callback) {
+     if (!this._localHooks[key]) {
+       this._localHooks[key] = [];
+     }
+     this._localHooks[key].push(callback);
++
++    return this;
+   },
+
+   /**",Could you add `s` to `@return`?,How about: `@param {String} key Hook name`
+8245,"@@ -57,11 +57,10 @@ module Selenium
+               is_relative = Regexp.last_match(1).strip == '1'
+             when /^Path=(.+)$/
+               path = Regexp.last_match(1).strip
++              p = path_for(name, is_relative, path)
++              @profile_paths[name] = p if p
+             end
+           end
+-
+-          p = path_for(name, is_relative, path)
+-          @profile_paths[name] = p if p
+         end
+
+         def path_for(name, is_relative, path)",Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?,Metrics/LineLength: Line is too long. [123
+8246,"@@ -290,9 +290,16 @@ func (at *addrTable) getAddrTable(key string) *serviceTable {
+ // filterResourceType implement filter. Proxy cares ""Service"" and ""ServiceList"" type
+ func filterResourceType(msg model.Message) []v1.Service {
+ 	svcs := make([]v1.Service, 0)
+-	content, ok := msg.Content.([]byte)
+-	if !ok {
+-		return svcs
++	var content []byte
++	var err error
++	switch msg.Content.(type) {
++	case []byte:
++		content = msg.GetContent().([]byte)
++	default:
++		content, err = json.Marshal(msg.GetContent())
++		if err != nil {
++			klog.Errorf(""marshal message to edgemesh failed, err: %v"", err)
++		}
+ 	}
+ 	switch getReourceType(msg.GetResource()) {
+ 	case constants.ResourceTypeService:",Will cause any bugs without this change? I've seen this code block(L293-302) many times... ;-),@deads2k @mfojtik shouldn't we return svcs
+8247,"@@ -82,6 +82,11 @@ namespace NLog
+         /// </summary>
+         public LogFactory Factory { get; private set; }
+
++        /// <summary>
++        /// Properties added with <see cref=""WithProperty""/> or <see cref=""SetProperty""/>
++        /// </summary>
++        public IDictionary<string, object> Properties => _contextProperties ?? new Dictionary<string, object>();
++
+         /// <summary>
+         /// Gets a value indicating whether logging is enabled for the specified level.
+         /// </summary>",You are opening a door to race-condition-hell by returning an unprotected dictionary. I recommend that you return `IReadOnlyDictionary` that only works on the platforms where it is known.,Does this need to be public?
+8248,"@@ -4367,7 +4367,7 @@ describe('Cursor', function() {
+     }
+   );
+
+-  it('should return a promise when no callback supplied to forEach method', function(done) {
++  it.skip('should return a promise when no callback supplied to forEach method', function(done) {
+     const configuration = this.configuration;
+     const client = configuration.newClient({ w: 1 }, { poolSize: 1, auto_reconnect: false });
+ ",also seems we should not skip this test,Can we add a TODO linked to #11102?
+8249,"@@ -31,14 +31,17 @@ import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+
+ class BaseFileScanTask implements FileScanTask {
+   private final DataFile file;
++  private final DeleteFile[] deletes;
+   private final String schemaString;
+   private final String specString;
+   private final ResidualEvaluator residuals;
+
+   private transient PartitionSpec spec = null;
+
+-  BaseFileScanTask(DataFile file, String schemaString, String specString, ResidualEvaluator residuals) {
++  BaseFileScanTask(DataFile file, DeleteFile[] deletes, String schemaString, String specString,
++                   ResidualEvaluator residuals) {
+     this.file = file;
++    this.deletes = deletes != null ? deletes : new DeleteFile[0];
+     this.schemaString = schemaString;
+     this.specString = specString;
+     this.residuals = residuals;","This is mostly for my understanding: is `DeleteFile[] deletes` a mandatory builder param now for file scan tasks? If not, from a v1 / v2 compatibility standpoint would it make sense to add an overloaded constructor?",I think this can be simplified to:
+8250,"@@ -123,6 +123,16 @@ public class ExecutionFlowDao {
+     }
+   }
+
++  public List<Pair<ExecutionReference, ExecutableFlow>> fetchAgedQueuedFlows(final Duration minAge)
++      throws ExecutorManagerException {
++    try {
++      return this.dbOperator.query(FetchAgedQueuedExecutableFlows.FETCH_FLOWS_QUEUED_FOR_LONG_TIME,
++          new FetchQueuedExecutableFlows(), System.currentTimeMillis() - minAge.toMillis());
++    } catch (final SQLException e) {
++      throw new ExecutorManagerException(""Error fetching active flows"", e);
++    }
++  }
++
+   /**
+    * fetch flow execution history with specified {@code projectId}, {@code flowId} and flow start
+    * time >= {@code startTime}","Can the error message reflect the purpose of the query more closely? Something like ""Error fetching executions queued for a long time""",I think this should be fetchedFlows
+8251,"@@ -60,7 +60,7 @@ func (c *CreateInstances) validate(w *Workflow) error {
+ 		}
+
+ 		// Startup script checking.
+-		if !sourceExists(ci.StartupScript) {
++		if ci.StartupScript != """" && !w.sourceExists(ci.StartupScript) {
+ 			return fmt.Errorf(""cannot create instance: file not found: %s"", ci.StartupScript)
+ 		}
+ ",Are you making it so startup script HAS to be in sources?,"StartupScript could be """" here."
+8252,"@@ -128,7 +128,9 @@ void l2_weight_regularization::start_evaluation() {
+       if (vals.Participating()
+           && vals.GetLocalDevice() == El::Device::GPU
+           && vals.RedundantRank() == i % vals.RedundantSize()) {
+-        if (vals.LDim() == vals.LocalHeight()) {
++        if (vals.LocalWidth() < 1 || vals.LocalHeight() < 1) {
++        } else if (vals.LocalWidth() == 1
++                   || vals.LDim() == vals.LocalHeight()) {
+           cublas::dot(handle,
+                       vals.LocalHeight() * vals.LocalWidth(),
+                       vals.LockedBuffer(), 1,",Might be more clear to just have one if statement?,why do these need to be mutually exclusive?
+8253,"@@ -87,7 +87,7 @@ class SparkReader:
+         try:
+             response_handler(response)
+         except Exception as e:
+-            current_app.logger.error('Error in the response handler: %s, data: %s %'
++            current_app.logger.error('Error in the response handler: %s, data: %s' %
+                                      (str(e), json.dumps(response, indent=4)), exc_info=True)
+             return
+ ","remember that logger methods will do string interpolation automatically anyway, so you should be able to do `logger.error('message %s', var, exc_info=True)`",The fact that `exc_info` is defined above a
+8254,"@@ -350,6 +350,7 @@ private:
+   void render_sync_handler_failed_default_exception_branch(t_function *tfunc);
+   void render_sync_handler_send_exception_response(t_function *tfunc, const string &err_var);
+   void render_service_call_structs(t_service* tservice);
++  void render_args_struct(t_function* tfunc);
+   void render_result_value_struct(t_function* tfunc);
+
+   string handler_successful_return_struct(t_function* tfunc);",Perhaps rename to `render_service_args_struct`?,"This should probably be t_function* tfunc, "
+8255,"@@ -11,8 +11,8 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/cborutil""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/chain""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/consensus""
++	crypto2 ""github.com/filecoin-project/go-filecoin/internal/pkg/crypto""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/repo""
+-	""github.com/filecoin-project/go-filecoin/internal/pkg/types""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/wallet""
+ )
+ ",clean the name,Why is this needed?
+8256,"@@ -70,6 +70,13 @@ func (a BrokerMetricAssertion) Assert(client *monitoring.MetricClient) error {
+ 		if err != nil {
+ 			return fmt.Errorf(""metric has invalid response code label: %v"", ts.GetMetric())
+ 		}
++
++		// Workarounds to reduce test flakiness caused by sender pod retry sending events (which will cause unexpected response code).
++		// We should remove it after https://github.com/google/knative-gcp/issues/1058 lands
++		if code == http.StatusForbidden || code == http.StatusServiceUnavailable || code == http.StatusInternalServerError {
++			continue
++		}
++
+ 		if code != http.StatusAccepted {
+ 			return fmt.Errorf(""metric has unexpected response code: %v"", ts.GetMetric())
+ 		}",I think we would expect StatusNotFound instead of StatusForbidden?,"Do we want to log something about it, or is it just too noisy?"
+8257,"@@ -241,9 +241,11 @@ static int rexec_output (flux_subprocess_t *p,
+                          bool eof)
+ {
+     json_t *io = NULL;
++    char rankstr[64];
+     int rv = -1;
+
+-    if (!(io = ioencode (stream, s->rank, data, len, eof))) {
++    snprintf (rankstr, sizeof (rankstr), ""%d"", s->rank);
++    if (!(io = ioencode (stream, rankstr, data, len, eof))) {
+         flux_log_error (s->h, ""%s: ioencode"", __FUNCTION__);
+         goto error;
+     }","Since this is a recurring theme, would it make sense to have an ioencode interface for it like `ioencode_rank()` that takes an integer rank like before?",Need a length check for (s->rank) >= sizeof (rankstr)
+8258,"@@ -192,8 +192,10 @@ func contains(capabilities []string, capability string) bool {
+ // object
+ func (agent *ecsAgent) initializeResourceFields() {
+ 	agent.resourceFields = &taskresource.ResourceFields{
+-		Control: cgroup.New(),
+-		IOUtil:  ioutilwrapper.NewIOUtil(),
++		Control:      cgroup.New(),
++		IOUtil:       ioutilwrapper.NewIOUtil(),
++		Ctx:          agent.ctx,
++		DockerClient: agent.dockerClient,
+ 	}
+ }
+ ",Is it a concern that we initialize these fields irrespective of whether resources like cgroup/volumes are enabled or not?,Why do we need to pass a docker client if we already have a do
+8259,"@@ -109,10 +109,13 @@ func NewDispatcher(cfg Config) Dispatcher {
+
+ // convertOutbounds applys outbound middleware and creates validator outbounds
+ func convertOutbounds(outbounds Outbounds, middleware OutboundMiddleware) Outbounds {
+-	//TODO(apb): ensure we're not given the same underlying outbound for each RPC type
+ 	convertedOutbounds := make(Outbounds, len(outbounds))
+
+ 	for service, outs := range outbounds {
++		if outs.Unary == nil && outs.Oneway == nil {
++			panic(fmt.Sprintf(""no outbound set for service %q in dispatcher"", service))
++		}
++
+ 		var (
+ 			unaryOutbound  transport.UnaryOutbound
+ 			onewayOutbound transport.OnewayOutbound",Wouldn't this be the first panic in yarpc? What do we do for transport validation? Return errors?,Maybe we should add a `panic()` here so it's easier to find in
+8260,"@@ -26,6 +26,7 @@ import (
+ type processor interface {
+ 	process(ctx context.Context) error
+ 	traceLogs() []string
++	cancel(reason string)
+ }
+
+ // processorProvider allows the processor to be determined after the pd has been inflated.",have you envisioned other cancellation reasons?,why not a `context.Context`?
+8261,"@@ -395,8 +395,10 @@ final class SonataMediaExtension extends Extension implements PrependExtensionIn
+     /**
+      * Checks if the classification of media is enabled.
+      *
+-     * @param array<string, class-string> $bundles
+-     * @param array<string, mixed>        $config
++     * @param array<string, string> $bundles
++     * @param array<string, mixed>  $config
++     *
++     * @phpstan-param array<string, class-string> $bundles
+      */
+     private function isClassificationEnabled(array $bundles, array $config): bool
+     {","For the record, class-string is now suported by PHPStorm. Don't know if it's worth moving it to `@phpstan-param` then.",`@phpstan-param array<string
+8262,"@@ -2085,7 +2085,10 @@ class CommandDispatcher:
+                 raise cmdexc.CommandError(str(e))
+
+         widget = self._current_widget()
+-        widget.run_js_async(js_code, callback=jseval_cb, world=world)
++        try:
++            widget.run_js_async(js_code, callback=jseval_cb, world=world)
++        except OverflowError:
++            raise cmdexc.CommandError(""World Id not in valid range"")
+
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+     def fake_key(self, keystring, global_=False):","This prevents negative IDs, but it doesn't check for too large IDs. You should probably just do the same check you do for `QWebengineScript` here as well.",Shouldn't this be in `cmdexc
+8263,"@@ -18,6 +18,7 @@ const (
+ 	// Command specific flags.
+ 	dockerFileFlag        = ""dockerfile""
+ 	imageTagFlag          = ""tag""
++	awsTagsFlag           = ""tags""
+ 	stackOutputDirFlag    = ""output-dir""
+ 	limitFlag             = ""limit""
+ 	followFlag            = ""follow""",This might be very confusing. Maybe `resource-tags`? I,I'm a little confused by the
+8264,"@@ -283,6 +283,7 @@ class DeformConvPack(DeformConv):
+             kernel_size=self.kernel_size,
+             stride=_pair(self.stride),
+             padding=_pair(self.padding),
++            dilation=self.dilation,
+             bias=True)
+         self.init_offset()
+ ",We may use `_pair` to wrap `dilation`.,does self.dilation still work if self.dilation is None?
+8265,"@@ -286,15 +286,9 @@ func createLibcontainerConfig(cgroupName string, spec *specs.LinuxSpec) (*config
+ 		return nil, err
+ 	}
+ 	config.Cgroups = c
+-	if config.Readonlyfs {
+-		setReadonly(config)
+-		config.MaskPaths = []string{
+-			""/proc/kcore"",
+-		}
+-		config.ReadonlyPaths = []string{
+-			""/proc/sys"", ""/proc/sysrq-trigger"", ""/proc/irq"", ""/proc/bus"",
+-		}
+-	}
++	// set extra path masking for libcontainer for the various unsafe places in proc
++	config.MaskPaths = maskedPaths
++	config.ReadonlyPaths = readonlyPaths
+ 	seccomp, err := setupSeccomp(&spec.Linux.Seccomp)
+ 	if err != nil {
+ 		return nil, err",what's with `setReadonly`? Why we deleted it totally?,@smarterclayton do we need to set `ReadonlyPaths` here
+8266,"@@ -121,12 +121,7 @@ CXXToken * cxxTagSetTypeField(
+ {
+ 	CXX_DEBUG_ASSERT(tag && pTypeStart && pTypeEnd,""Non null parameters are expected"");
+
+-	const char * szTypeRef0;
+-
+-	// ""typename"" is debatable since it's not really
+-	// allowed by C++ for unqualified types. However I haven't been able
+-	// to come up with something better... so ""typename"" it is for now.
+-	static const char * szTypename = ""typename"";
++	const char * szTypeRef0 = NULL;
+
+ 	if(pTypeStart != pTypeEnd)
+ 	{","Currently I think this is not acceptable. I think the value should be chosen by the author of the parser. (Personally ""type"" is better than ""typename"".)",(Pre-existing) I'm not sure this should be a static con
+8267,"@@ -13,6 +13,7 @@
+
+ package machine
+
++// should not need to import the ec2 sdk here
+ import (
+ 	""fmt""
+ ",Is this excessive?,I believe this is the only import from `ec2` package. I
+8268,"@@ -251,7 +251,7 @@ main(int argc, char *argv[])
+        * sysroot, we still need a writable /etc.  And to avoid race conditions
+        * we ensure it's writable in the initramfs, before we switchroot at all.
+        */
+-      if (mount (""/etc"", ""/etc"", NULL, MS_BIND, NULL) < 0)
++      if (mount (""etc"", ""etc"", NULL, MS_BIND, NULL) < 0)
+         err (EXIT_FAILURE, ""failed to make /etc a bind mount"");
+       /* Pass on the fact that we discovered a readonly sysroot to ostree-remount.service */
+       int fd = open (_OSTREE_SYSROOT_READONLY_STAMP, O_WRONLY | O_CREAT | O_CLOEXEC, 0644);","Ohhhh I see, this change was previously having *no effect* - I had thought you meant we were doing something like bind mounting the initramfs' `/etc` as the real `/etc` but we'd clearly notice if that happened, we'd be missing all sorts of config files etc.","Is this change intentional, or did it sneak into the commit?"
+8269,"@@ -133,6 +133,15 @@ abstract class SnapshotProducer<ThisT> implements SnapshotUpdate<ThisT> {
+    */
+   protected abstract String operation();
+
++  /**
++   * A Long that write sequenceNumber in manifest-list file.
++   *
++   * @return a string operation
++   */
++  protected Long sequenceNumber() {
++    return null;
++  }
++
+   /**
+    * Validate the current metadata.
+    * <p>","I think this needs a more specific name, like `sequenceNumberOverride`",should be `long` to be consistent with the rest of the API
+8270,"@@ -39,7 +39,8 @@ module Blacklight
+     when /::/
+       connection_config[:adapter].constantize
+     else
+-      Blacklight.const_get(""#{connection_config[:adapter]}/Repository"".classify)
++      raise ""The value for :adapter was not found in the blacklight.yml config"" unless connection_config.key? :adapter
++      Blacklight.const_get(""#{connection_config.fetch(:adapter)}/Repository"".classify)
+     end
+   end
+ ",Ought we just raise an exception if the adapter isn't defined?,Line is too long. [81/80]
+8271,"@@ -5,7 +5,6 @@ var stsLegacyGlobalRegions = map[string]struct{}{
+ 	""ap-south-1"":     {},
+ 	""ap-southeast-1"": {},
+ 	""ap-southeast-2"": {},
+-	""aws-global"":     {},
+ 	""ca-central-1"":   {},
+ 	""eu-central-1"":   {},
+ 	""eu-north-1"":     {},","Should this have been removed? We still set the region to ""aws-global"" in v3model.go#L115",Can you mention this removal in the changelog?
+8272,"@@ -335,14 +335,15 @@ def setup_logging(config):
+                 errno=errors.ERRORS.INVALID_PARAMETERS,
+                 message='Invalid URL path.')
+
++        qs = dict(errors.request_GET(request))
+         request.log_context(agent=request.headers.get('User-Agent'),
+                             path=request_path,
+                             method=request.method,
+-                            querystring=dict(errors.request_GET(request)),
++                            querystring=(qs if len(qs) else None),
+                             lang=request.headers.get('Accept-Language'),
+                             uid=None,
+                             authn_type=None,
+-                            errno=None)
++                            errno=0)
+
+     config.add_subscriber(on_new_request, NewRequest)
+ ","You could shorten this to `qs or None`. But why not just build a dict of parameters we want to include and only add `querystring` if there's something here, similar to the way you do in the error view?",is there a reason we don't use `errors.request_get(request)` anymore?
+8273,"@@ -31,15 +31,9 @@ func (c *client) acquireTopologyCacheLock(ctx context.Context) {
+ 	}
+ 	defer conn.Close()
+
+-	go func() {
+-		<-ctx.Done()
+-		ticker.Stop()
+-		c.unlockAdvisoryLock(context.Background(), conn, advisoryLockId)
+-	}()
+-
+ 	// Infinitely try to acquire the advisory lock
+ 	// Once the lock is acquired we start caching, this is a blocking operation
+-	for ; true; <-ticker.C {
++	for {
+ 		c.log.Info(""trying to acquire advisory lock"")
+
+ 		// TODO: We could in the future spread the load of the topology caching","sorry if I'm missing it somewhere else in the code, but do you need to create a `ticker := time.NewTicker`?","This is a blocking operation, so we need to do the unlock."
+8274,"@@ -44,7 +44,11 @@ import (
+ func TestNew(t *testing.T) {
+ 	ctx, _ := SetupFakeContext(t)
+
+-	c := NewController(ctx, configmap.NewStaticWatcher(
++	dataresidencySs := &dataresidency.StoreSingleton{}
++
++	ctor := NewConstructor(dataresidencySs)
++
++	c := ctor(ctx, configmap.NewStaticWatcher(
+ 		&corev1.ConfigMap{
+ 			ObjectMeta: metav1.ObjectMeta{
+ 				Name:      logging.ConfigMapName(),","Inline this, as we don't use it again.",The idea is to create a mock store. Would it make sense to create a m
+8275,"@@ -39,7 +39,9 @@ exclude = [""ForwardFFTImageFilter"",
+            ""templated_class"",
+            ""HalfHermitianToRealInverseFFTImageFilter"",
+            ""RealToHalfHermitianForwardFFTImageFilter"",
+-           ""CustomColormapFunction""]
++           ""CustomColormapFunction"",
++           ""ScanlineFilterCommon""  # Segfault
++           ]
+
+ wrongName = 0
+ totalName = 0",I think the instantiation of the new objects i.New() and T.New() need to be done in a function to have local variable and reduce the amount of memory used.,Is there any way we can do this without the `# Segfault`?
+8276,"@@ -40,6 +40,8 @@ namespace pwiz.Skyline.Model.Hibernate
+         public const string Mz = ""0.####"";
+         public const string SamplingTime = ""0.00"";
+         public const string OneOverK0 = ""0.####"";
++
++        public const string IonMobility = ""0.#####"";
+         // ReSharper restore LocalizableElement
+     }
+ }",This is probably more digits than needed - perhaps rename OneOverK0 to IonMobility instead,Please revert this. The rest of the constants are written in alphabetical order.
+8277,"@@ -25,5 +25,8 @@ public enum ApiMethodType {
+   CallableMethod,
+   // PHP
+   OptionalArrayMethod,
+-  PagedOptionalArrayMethod
++  PagedOptionalArrayMethod,
++  // C#
++  FlattenedMethodAsyncCallSettings,
++  FlattenedMethodAsyncCancellationToken,
+ }","End with 'Method', so: - FlattenedAsyncCallSettingsMethod - FlattenedAsyncCancellationTokenMethod",@stephentoub why is this token here?
+8278,"@@ -22,6 +22,7 @@ import (
+
+ 	cloudkms ""cloud.google.com/go/kms/apiv1""
+ 	""gocloud.dev/gcp""
++	""gocloud.dev/internal/secrets""
+ 	""google.golang.org/api/option""
+ 	kmspb ""google.golang.org/genproto/googleapis/cloud/kms/v1""
+ )",`localsecrets` should be updated in the same way.,Can you move this up with the other clouds?
+8279,"@@ -94,13 +94,18 @@ const ConsensusV17 = ConsensusVersion(
+ 	""https://github.com/algorandfoundation/specs/tree/5615adc36bad610c7f165fa2967f4ecfa75125f0"",
+ )
+
++// ConsensusV18 adds the ability to issue a transaction that marks an account non-participating
++const ConsensusV18 = ConsensusVersion(
++	""---->!!!TODO!!!<----"",
++)
++
+ // !!! ********************* !!!
+ // !!! *** Please update ConsensusCurrentVersion when adding new protocol versions *** !!!
+ // !!! ********************* !!!
+
+ // ConsensusCurrentVersion is the latest version and should be used
+ // when a specific version is not provided.
+-const ConsensusCurrentVersion = ConsensusV17
++const ConsensusCurrentVersion = ConsensusV18
+
+ // ConsensusTest0 is a version of ConsensusV0 used for testing
+ // (it has different approved upgrade paths).",We'll want to PR a spec change into github.com/algorandfoundation/specs. (Side note: It might or might not make sense to combine this protocol upgrade with Tsachi's protocol upgrade for fixing the reward rate calculation.),is there a proof-of-mechanism for adding a new protocol version?
+8280,"@@ -30,7 +30,7 @@ func (w *DefaultWorker) Generate(
+ 	nullBlockCount abi.ChainEpoch,
+ 	posts []block.PoStProof,
+ 	drandEntries []*drand.Entry,
+-) Output {
++) (*block.Block, []*types.SignedMessage, []*types.SignedMessage, error) {
+
+ 	generateTimer := time.Now()
+ 	defer func() {","Use `FullBlock`, it comes from the same package.",Does it make sense to return pointers here? Maybe we could return a struct instead?
+8281,"@@ -1,9 +1,13 @@
++import abc
+ import json
+ import logging
+ import time
+ from concurrent.futures import ThreadPoolExecutor
++from typing import Collection, Dict, Optional
+
+ import requests
++from flask import Request
++from readerwriterlock import rwlock
+
+ from localstack import config
+ from localstack.utils.bootstrap import canonicalize_api_names","do we plan to use anything else than flask for making HTTP requests inside localstack? if so, it maybe makes sense not to strongly couple to flask for now, and just leave the type of the `request` function parameters open for now.",nit: can we use `from flask_app import lock` instead?
+8282,"@@ -143,9 +143,17 @@ func (verifyContentLanguage) ErrorCheck(b *blob.Bucket, err error) error {
+ }
+
+ func (verifyContentLanguage) BeforeWrite(as func(interface{}) bool) error {
++	var objp **storage.ObjectHandle
++	if !as(&objp) {
++		return errors.New(""Writer.As failed to get ObjectHandle"")
++	}
++	// Replace the ObjectHandle with a new one that adds Conditions
++	// (this condition will always be true).
++	*objp = (*objp).If(storage.Conditions{DoesNotExist: true})
++
+ 	var sw *storage.Writer
+ 	if !as(&sw) {
+-		return errors.New(""Writer.As failed"")
++		return errors.New(""Writer.As failed to get Writer"")
+ 	}
+ 	sw.ContentLanguage = language
+ 	return nil","I think we should make this a separate test case: it seems like making the precondition fail is the test case that would ensure that this escape hatch worked. Otherwise, if it's always true, then it would be the same as if the escape hatch didn't modify the outgoing request.",What do you think about making `Writer.As failed to get ObjectHandle` return an err
+8283,"@@ -62,6 +62,13 @@ func (s *Server) Start(ctx context.Context) error {
+ 		return errors.Wrap(err, ""error when subscribe to block"")
+ 	}
+
++	// sync genesis block
++	genesisBlk, err := s.bc.GetBlockByHeight(0)
++	if err != nil {
++		return errors.Wrap(err, ""error when get genesis block"")
++	}
++	s.idx.BuildIndex(genesisBlk)
++
+ 	go func() {
+ 		for {
+ 			select {",Error return value of `s.idx.BuildIndex` is not checked,no need to build index every time. bc.GetBlockByHeight(0) is just fine.
+8284,"@@ -36,6 +36,8 @@ def gen_classes():
+             pass
+         elif member is configtypes.MappingType:
+             pass
++        elif member in [configtypes.List, configtypes.LengthList]:
++            pass
+         elif member is configtypes.FormatString:
+             yield functools.partial(member, fields=['a', 'b'])
+         elif issubclass(member, configtypes.BaseType):",What's the reason for excluding those from the fuzzing here? You probably could just add some inner type via `functools.partial` like below with `FormatString`.,It's probably better to use `collections.Sequence` here instead of `list` and `lengthList`.
+8285,"@@ -3,6 +3,6 @@ require 'spec_helper'
+ describe Api::V1::UsersController, '#show' do
+   it 'returns a 401 when users are not authenticated' do
+     get :show
+-    response.code.should eq '401'
++    expect(response.code).to eq '401'
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Metrics/LineLength: Line is too long. [90/80]
+8286,"@@ -14,7 +14,7 @@ import (
+ )
+
+ func killContainer(container libcontainer.Container) error {
+-	container.Signal(syscall.SIGKILL, false)
++	_ = container.Signal(syscall.SIGKILL, false)
+ 	for i := 0; i < 100; i++ {
+ 		time.Sleep(100 * time.Millisecond)
+ 		if err := container.Signal(syscall.Signal(0), false); err != nil {",Its this golint or govet stuff?,Are we sure there is no error returned here?
+8287,"@@ -232,10 +232,9 @@ insert(hash_table_t table, app_pc addr, cbr_state_t state)
+ static void
+ at_taken(app_pc src, app_pc targ)
+ {
+-    dr_mcontext_t mcontext = {
+-        sizeof(mcontext),
+-        DR_MC_ALL,
+-    };
++    dr_mcontext_t mcontext;
++    mcontext.size = sizeof(mcontext);
++    mcontext.flags = DR_MC_ALL;
+     void *drcontext = dr_get_current_drcontext();
+
+     /*","These are good cleanups: I didn't realize there were so many like this in the samples and tests. But given that there are quite of few of these mcontext changes I would separate these into their own PR (no need for an issue: iX branch) since they are logically distinct. Cleaner history, simpler revert paths, etc.",Is it necessary to set the mcontext.size and flags at the same time? Shouldn't they be the
+8288,"@@ -0,0 +1,18 @@
++// Copyright (c) Six Labors.
++// Licensed under the Apache License, Version 2.0.
++
++using BenchmarkDotNet.Attributes;
++
++using SixLabors.ImageSharp.PixelFormats;
++
++namespace SixLabors.ImageSharp.Benchmarks
++{
++    public class ColorEquality
++    {
++        [Benchmark(Description = ""ImageSharp Color Equals"")]
++        public bool ColorEqual()
++        {
++            return new Rgba32(128, 128, 128, 128).Equals(new Rgba32(128, 128, 128, 128));
++        }
++    }
++}","  This is just a random struct equality, no value here.",Should this benchmark be named `ImageSharp Color Equals`?
+8289,"@@ -180,6 +180,7 @@ type Config struct {
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail""`
+
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
++	NatPortRange       numorstring.Port   `config:""portrange;;local""`
+
+ 	UsageReportingEnabled          bool          `config:""bool;true""`
+ 	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`",Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only,why is this needed?
+8290,"@@ -8,8 +8,12 @@ except ImportError:
+ import numpy as np
+ import param
+
+-from ..dimension import redim
+-from ..util import unique_iterator
++from ..dimension import redim, Dimension, process_dimensions
++from ..element import Element
++from ..ndmapping import OrderedDict
++from ..spaces import HoloMap, DynamicMap
++from ..util import (basestring, dimension_range as d_range, get_param_values,
++                    isfinite, process_ellipses, unique_iterator, wrap_tuple)
+ from .interface import Interface, iloc, ndloc
+ from .array import ArrayInterface
+ from .dictionary import DictInterface","I had some weird issues when importing ``from .. import util`` getting the wrong utilities, hence I did this.",Please combine these two imports with one of the above
+8291,"@@ -1,8 +1,8 @@
+-#NVDAObjects/WinConsole.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
+-#Copyright (C) 2007-2019 NV Access Limited, Bill Dengler
++# NVDAObjects/WinConsole.py
++# A part of NonVisual Desktop Access (NVDA)
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
++# Copyright (C) 2007-2020 NV Access Limited, Bill Dengler
+
+ import winConsoleHandler
+ from . import Window",Please remove this line.,@jennfshr Does this look correct? Shouldn't the `.py` fil
+8292,"@@ -324,7 +324,8 @@ module Beaker
+           # exit codes at the host level and then raising...
+           # is it necessary to break execution??
+           if options[:accept_all_exit_codes] && options[:acceptable_exit_codes]
+-            @logger.warn "":accept_all_exit_codes & :acceptable_exit_codes set. :accept_all_exit_codes overrides, but they shouldn't both be set at once""
++            @logger.warn "":accept_all_exit_codes & :acceptable_exit_codes set. :acceptable_exit_codes overrides, but they shouldn't both be set at once""
++            options[:accept_all_exit_codes] = false
+           end
+           if !options[:accept_all_exit_codes] && !result.exit_code_in?(Array(options[:acceptable_exit_codes] || [0, nil]))
+             raise CommandFailure, ""Host '#{self}' exited with #{result.exit_code} running:\n #{cmdline}\nLast #{@options[:trace_limit]} lines of output were:\n#{result.formatted_output(@options[:trace_limit])}""",should this state that we're falling back to `:acceptable_exit_codes`?,Style/ColonMethodCall: Do not use :: for method calls.
+8293,"@@ -87,6 +87,16 @@ def df_type_check(_, value):
+         success=True,
+         metadata_entries=[
+             EventMetadataEntry.text(str(len(value)), 'row_count', 'Number of rows in DataFrame'),
++            EventMetadataEntry.text(str(value.shape), ""shape"", ""The shape of the DataFrame.""),
++            EventMetadataEntry.md(
++                value.dtypes.to_markdown(), ""dtypes"", ""The dtypes within the DataFrame.""
++            ),
++            EventMetadataEntry.md(
++                dataframe.head().to_markdown(), ""head"", ""A preview of the first 5 rows.""
++            ),
++            EventMetadataEntry.md(
++                dataframe.tail().to_markdown(), ""tail"", ""A preview of the last 5 rows.""
++            ),
+             # string cast columns since they may be things like datetime
+             EventMetadataEntry.json({'columns': list(map(str, value.columns))}, 'metadata'),
+         ],",I don't think this works. The dataframe object is encapsulated in the value parameter. This might be the root of the failing checks.,"This description should be part of the `md` tag, not a"
+8294,"@@ -163,7 +163,7 @@ class TopologyDescription {
+     }
+
+     if (topologyType === TopologyType.Unknown) {
+-      if (serverType === ServerType.Standalone) {
++      if (serverType === ServerType.Standalone && this.servers.size !== 1) {
+         serverDescriptions.delete(address);
+       } else {
+         topologyType = topologyTypeForServerType(serverType);",Why was it necessary to add this check against `this.servers.size`?,Why is `this.servers.size !== 1` needed?
+8295,"@@ -61,6 +61,11 @@ std::string getWrongOptionHelp(const engine::api::TableParameters &parameters)
+         help = ""fallback_speed must be > 0"";
+     }
+
++    if (parameters.scale_factor < 0)
++    {
++        help = ""scale_factor must be > 0"";
++    }
++
+     return help;
+ }
+ } // anon. ns",This tests for < 0 but the error message says it must be > 0. The `if` should probably be `<=` to match the message.,"So this defaults to 0, 0.1? Seems like a bug."
+8296,"@@ -25,12 +25,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         {
+             var request = (WebRequest)webRequest;
+
+-            if (!IsTracingEnabled(request))
++            if (!(request is HttpWebRequest) || !IsTracingEnabled(request))
+             {
+                 return request.GetResponse();
+             }
+
+-            string httpMethod = request.Method.ToUpperInvariant();
++            string httpMethod = request.Method?.ToUpperInvariant() ?? ""UNKNOWN"";
+             string integrationName = typeof(WebRequestIntegration).Name.TrimEnd(""Integration"", StringComparison.OrdinalIgnoreCase);
+
+             using (var scope = ScopeFactory.CreateOutboundHttpScope(Tracer.Instance, httpMethod, request.RequestUri, integrationName))","Short circuits when it's something like a WebPackRequest, which we should instrument and test specifically.",When would `HttpWebRequest` not be null?
+8297,"@@ -23,7 +23,7 @@ var (
+
+ func init() {
+ 	flag.BoolVar(&fProd, ""prod"", false, ""disable development mode"")
+-	flag.BoolVar(&fDiskCertCache, ""use-disk-cert-cache-dev"", false, ""cache cert on disk"")
++	flag.BoolVar(&fDiskCertCache, ""use-disk-cert-cache"", false, ""cache cert on disk"")
+ }
+
+ func main() {",Should this be true now by default?,remove `-dev` from flag description?
+8298,"@@ -131,6 +131,7 @@ public class AzkabanExecutorServer {
+     root.addServlet(new ServletHolder(new ExecutorServlet()), ""/executor"");
+     root.addServlet(new ServletHolder(new JMXHttpServlet()), ""/jmx"");
+     root.addServlet(new ServletHolder(new StatsServlet()), ""/stats"");
++    root.addServlet(new ServletHolder(new StatisticsServlet()), ""/stastics"");
+
+     root.setAttribute(ServerConstants.AZKABAN_SERVLET_CONTEXT_KEY, this);
+ ",/DispatcherStatistics ? /statistics is a bit confusing with /stats,Could you please rename to `/statsStasti
+8299,"@@ -605,6 +605,9 @@ def get_lambda_log_events(
+             or ""START"" in raw_message
+             or ""END"" in raw_message
+             or ""REPORT"" in raw_message
++            # necessary until tail is updated in docker images. See this PR:
++            # http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.24-111-g1118f32
++            or ""tail: unrecognized file system type 0x794c7630"" in raw_message
+             or regex_filter
+             and not re.search(regex_filter, raw_message)
+         ):","nit: Wondering if we should simply filter on `""tail: unrecognized file system type""`, or is the type identifier `0x794c7630` always the same?",Didn't we get rid of the `.gitignore` fi
+8300,"@@ -4,12 +4,13 @@ import (
+ 	""encoding/json""
+ 	""fmt""
+
++	""github.com/google/uuid""
+ 	installertypes ""github.com/openshift/installer/pkg/types""
+
+ 	hivev1 ""github.com/openshift/hive/pkg/apis/hive/v1""
+ )
+
+-const fakeMetadataFormatStr = `{""aws"":{""identifier"":[{""kubernetes.io/cluster/fake-infraid"":""owned""},{""openshiftClusterID"":""fake-cluster-id""}],""region"":""us-east-1""},""clusterID"":""fake-cluster-id"",""clusterName"":""%s"",""infraID"":""fake-infra-id""}`
++const fakeMetadataFormatStr = `{""aws"":{""identifier"":[{""kubernetes.io/cluster/fake-infraid"":""owned""},{""openshiftClusterID"":""%s""}],""region"":""us-east-1""},""clusterID"":""%s"",""clusterName"":""%s"",""infraID"":""fake-infra-id""}`
+
+ func fakeLoadAdminPassword(m *InstallManager) (string, error) {
+ 	m.log.Warn(""loading fake admin password"")","I think the goal of using `fake-cluster-id` was to make it sure clear that this is a fake cluster, replacing this with UUID only now makes these clusters look very similar to real ones which can cause problems.. any reason why we didn't go for the original recommendation from slack thread of `fake-cluster-UUID` @twiest",Can we also fix the indentation here? Just so it lines up correctly.
+8301,"@@ -1719,3 +1719,19 @@ def get_node_first_ancestor_of_type(
+         if isinstance(ancestor, ancestor_type):
+             return ancestor
+     return None
++
++
++def get_node_first_ancestor_of_type_and_its_child(
++    node: nodes.NodeNG, ancestor_type: Union[Type[T_Node], Tuple[Type[T_Node]]]
++) -> Tuple[Optional[T_Node], Optional[T_Node]]:
++    """"""Modified version of get_node_first_ancestor_of_type to also return the
++    descendant visited directly before reaching the sought ancestor. Useful
++    for extracting whether a statement is guarded by a try, except, or finally
++    when searching for a TryFinally ancestor.
++    """"""
++    last_ancestor = node
++    for ancestor in node.node_ancestors():
++        if isinstance(ancestor, ancestor_type):
++            return (ancestor, last_ancestor)
++        last_ancestor = ancestor
++    return None, None","I need to spruce up my `mypy` knowledge but I think this is incorrect. Using `T_Node` twice makes it so that both should be the same type. I think this would be better: `Tuple[Optional[T_Node], Optional[nodes.NodeNG ]]`. It might even better to do: `Union[Tuple[None, None]. Tuple[T_Node, nodes.NodeNG ]]` as that shows that `None` should always pair with `None`",Can you update this docstring to mention that `try` and `finally` ar
+8302,"@@ -438,10 +438,13 @@ func runTest(t *testing.T, test testT) {
+ 	}
+
+ 	controller := certificaterequests.New(apiutil.IssuerCA, ca)
+-	controller.Register(test.builder.Context)
++	_, _, err := controller.Register(test.builder.Context)
++	if err != nil {
++		t.Errorf(""controller.Register failed (%s)"", err.Error())
++	}
+ 	test.builder.Start()
+
+-	err := controller.Sync(context.Background(), test.certificateRequest)
++	err = controller.Sync(context.Background(), test.certificateRequest)
+ 	if err != nil && !test.expectedErr {
+ 		t.Errorf(""expected to not get an error, but got: %v"", err)
+ 	}",Nit: below on line 449 we use `%v` to print an error - perhaps would be nice to do it in the same way in both places (but probably not that important). Similar in other places in this PR.,"Hmm, this seems unrelated to the rest of the PR?"
+8303,"@@ -169,6 +169,8 @@ class Flow(stateobject.StateObject):
+             self.reply.take()
+         self.reply.kill(force=True)
+         self.reply.commit()
++        self.live = False
++        master.addons(""kill"", self)
+
+     def intercept(self, master):
+         """"""","I'm not against adding a kill event, but we need to do it properly, please. That means listing it in events.py, adding docs for it, and so forth.","This is the wrong place for this, it should be in the kill method, n"
+8304,"@@ -2083,9 +2083,15 @@ class CppGenerator : public BaseGenerator {
+         if (!field.deprecated) {
+           code_.SetValue(""FIELD_NAME"", Name(field));
+           if (field.value.type.base_type == BASE_TYPE_STRING) {
+-            code_ +=
+-                ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
+-                ""_fbb.CreateString({{FIELD_NAME}}) : 0;"";
++            if (!field.native_shared) {
++              code_ +=
++                  ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
++                  ""_fbb.CreateString({{FIELD_NAME}}) : 0;"";
++            } else {
++              code_ +=
++                  ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
++                  ""_fbb.CreateSharedString({{FIELD_NAME}}) : 0;"";
++            }
+           } else if (field.value.type.base_type == BASE_TYPE_VECTOR) {
+             code_ += ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? \\"";
+             const auto vtype = field.value.type.VectorType();",this line can be lifted outside of the if-then? In fact only CreateString / CreateSharedString needs to be inside of it.,Should we have a unit test for this?
+8305,"@@ -386,8 +386,8 @@ public class EpisodesApplyActionFragment extends Fragment implements Toolbar.OnM
+             mListView.setItemChecked(i, checked);
+         }
+         refreshToolbarState();
+-        toolbar.setTitle(getResources().getQuantityString(R.plurals.num_selected_label,
+-                checkedIds.size(), checkedIds.size()));
++//        toolbar.setTitle(getResources().getQuantityString(R.plurals.num_selected_label,
++//                checkedIds.size(), checkedIds.size()));
+     }
+
+     private void queueChecked() {",I think the `EpisodesApplyActionFragment` is unused now. So please delete it :),Can we remove the code if we don't n
+8306,"@@ -863,7 +863,7 @@ module Bolt
+       end
+       define('--log-level LEVEL',
+              ""Set the log level for the console. Available options are"",
+-             ""debug, info, notice, warn, error, fatal, any."") do |level|
++             ""trace, debug, info, warn, error, fatal, any."") do |level|
+         @options[:log] = { 'console' => { 'level' => level } }
+       end
+       define('--plugin PLUGIN', 'Select the plugin to use') do |plug|","It seems like we should leave `notice` here since it can be configured in Bolt config files, and that's what sets the console config for messages from Puppet. For example, this will break plans that call `notice()` in their apply blocks.",This was a typo. `trace` is the defa
+8307,"@@ -31,6 +31,7 @@ public enum CommonMetrics {
+
+   private Meter dbConnectionMeter;
+   private Meter flowFailMeter;
++  private Meter OOMwaitingJobMeter;
+   private AtomicLong dbConnectionTime = new AtomicLong(0L);
+
+   private MetricRegistry registry;",This metrics is only exposed in executors. Should it be defined in azkaban.execapp.ExecMetrics instead?,Please annotate `@Nullable`.
+8308,"@@ -64,3 +64,14 @@ export function getEffectiveMaxDate ({ maxDate, includeDates }) {
+     return maxDate
+   }
+ }
++
++export function parseDate (value, { dateFormat, locale }) {
++  const m = moment(value, dateFormat, locale || moment.locale(), true)
++  return m.isValid() ? m : null
++}
++
++export function safeDateFormat (date, { dateFormat, locale }) {
++  return date && date.clone()
++    .locale(locale || moment.locale())
++    .format(Array.isArray(dateFormat) ? dateFormat[0] : dateFormat) || ''
++}","I originally factored out these functions from date_input. Currently, they are only used in datepicker, but they seemed more general purpose. If you decide we should keep the current date_input API (in case anyone is using it directly), then I think it makes sense to factor these out in order to be able to maintain consistency, but otherwise they could be inlined into datepicker.jsx if you prefer.",Shouldn't this return a `Date` instance rather than a string ?
+8309,"@@ -204,9 +204,10 @@ func (r *mutableStateTaskGeneratorImpl) generateDelayedWorkflowTasks(
+ 	switch startAttr.GetInitiator() {
+ 	case enumspb.CONTINUE_AS_NEW_INITIATOR_RETRY:
+ 		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_RETRY
+-	case enumspb.CONTINUE_AS_NEW_INITIATOR_CRON_SCHEDULE,
+-		enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW:
++	case enumspb.CONTINUE_AS_NEW_INITIATOR_CRON_SCHEDULE, enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW:
+ 		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_CRON
++	case enumspb.CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED:
++		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_UNSPECIFIED
+ 	default:
+ 		return serviceerror.NewInternal(fmt.Sprintf(""unknown initiator: %v"", startAttr.GetInitiator()))
+ 	}",I think this should never happen and should return an error also. Having `WorkflowBackoffTimerTask` with `UNSPECIFIED` type looks weird.,do we need to set the back off type in the switch?
+8310,"@@ -9,7 +9,7 @@ import 'webcomponents';
+     function onKeyDown(e) {
+         // Don't submit form on enter
+         // Real (non-emulator) Tizen does nothing on Space
+-        if (e.keyCode === 13 || e.keyCode === 32) {
++        if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) {
+             e.preventDefault();
+
+             if (!this.checked) {",Add `browser` import,The `&& browser.tizen` isn't needed here because the `onKeyDow
+8311,"@@ -0,0 +1,18 @@
++// Copyright 2018 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++package config
++
++import (
++	""crypto/sha256""
++	""encoding/hex""
++)
++
++// GenerateSHA256PasswordHash generates a sha256 hashed password hash from
++// plaintextPassword in the form of ""sha256:<hash>"". This is what should go
++// into the config file.
++func GenerateSHA256PasswordHash(plaintextPassword string) string {
++	hash := sha256.Sum256([]byte(plaintextPassword))
++	return ""sha256:"" + hex.EncodeToString(hash[:])
++}","Would it be good practice to add a nonce in here (that's also stored in the config), so it's harder to tell when passwords are being reused?",why do we need a new function? why not just use the existing f
+8312,"@@ -40,4 +40,8 @@ public interface TelemetryRestService {
+   @Produces(MediaType.APPLICATION_JSON)
+   TelemetryConfigurationDto getTelemetryConfiguration();
+
++  @GET
++  @Path(""/data"")
++  @Produces(MediaType.APPLICATION_JSON)
++  Object getTelemetryData();
+ }","For consistency, the return type could be `TelemetryDataDto` here. This would be more consistent with the other REST API interfaces. From a functional perspective, the current code is perfectly fine though.",we should use `MediaType.TEXT_HTML` here instead of `APPLICATION_JSON`
+8313,"@@ -133,7 +133,7 @@ PySGDSolver::PySGDSolver(const string& param_file) {
+   // as in PyNet, (as a convenience, not a guarantee), create a Python
+   // exception if param_file can't be opened
+   CheckFile(param_file);
+-  solver_.reset(new SGDSolver<float>(param_file));
++  solver_ = boost::make_shared<SolvingDriver<float> >(param_file);
+   // we need to explicitly store the net wrapper, rather than constructing
+   // it on the fly, so that it can hold references to Python objects
+   net_.reset(new PyNet(solver_->net()));",I've never seen this `boost::make_shared`...why use it instead of `reset`?,Use make_shared instead of make_shared since it doesn't share the same
+8314,"@@ -273,6 +273,11 @@ public abstract class AbstractExecutorManagerAdapter extends EventHandler implem
+     }
+   }
+
++  @Override
++  public DispatchMethod getDispatchMethod(final ExecutableFlow flow) {
++    return getDispatchMethod();
++  }
++
+   protected String uploadExecutableFlow(
+       final ExecutableFlow exflow, final String userId, final String flowId,
+       String message) throws ExecutorManagerException {",Wasn't this added as a part of different PR already?,Shouldn't it be `@Restricted(ProtectedExternally.class)` here?
+8315,"@@ -8,7 +8,7 @@ class UrlListData
+     public const FIELD_SLUG = 'slug';
+
+     /**
+-     * @var \Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\FriendlyUrl[]
++     * @var \Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\FriendlyUrl[][]
+      */
+     public $toDelete;
+ ","hmmmmm, should not be in constructor in this case `$this->toDelete = [[]];` ??? maybe not",Why did you change this to `[]`?
+8316,"@@ -114,8 +114,11 @@ def toggle_routing_control_state(routing_control_arn, cluster_endpoints):
+     update_state = 'Off' if state == 'On' else 'On'
+     print(f""Setting control state to '{update_state}'."")
+     response = update_routing_control_state(routing_control_arn, cluster_endpoints, update_state)
+-    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
++    status = response.get('ResponseMetadata', {}).get('HTTPStatusCode', 'Unknown')
++    if status == 200:
+         print('Success!')
++    else:
++        print(f'Something went wrong. Status: {status}.')
+     print('-'*88)
+ # snippet-end:[python.example_code.route53-recovery-cluster.Scenario_SetControlState]
+ ","We can just update it to be as follows: `if response: print(""Success"") else: print(""Error"")`",i'm not sure if we should default to returning a status code from a response like this
+8317,"@@ -119,6 +119,7 @@ type Helper struct {
+ 	matcherDefs  map[string]caddy.ModuleMap
+ 	parentBlock  caddyfile.ServerBlock
+ 	groupCounter counter
++	state        map[string]interface{}
+ }
+
+ // Option gets the option keyed by name.",Maybe this should be exported so (external/third-party) plugins can also use it.,Why did you change this?
+8318,"@@ -38,17 +38,9 @@ func (service *servicePFCtl) Add(rule RuleForwarding) {
+ }
+
+ func (service *servicePFCtl) Start() error {
+-	err := service.ipForward.Enable()
+-	if err != nil {
+-		return err
+-	}
+-
++	service.ipForward.Enable()
+ 	service.clearStaleRules()
+-	err = service.enableRules()
+-	if err != nil {
+-		return err
+-	}
+-	return nil
++	return service.enableRules()
+ }
+
+ func (service *servicePFCtl) Stop() {",Warning logging whould be exactly here in high logic. So that everybody understands why we swallow errors,I think this would be clearer with a return statement like `return service.enableRules
+8319,"@@ -46,6 +46,7 @@ namespace Nethermind.JsonRpc.WebSockets
+             string clientName,
+             ISocketHandler handler,
+             RpcEndpoint endpointType,
++            JsonRpcUrl? url,
+             IJsonRpcProcessor jsonRpcProcessor,
+             IJsonRpcService jsonRpcService,
+             IJsonRpcLocalStats jsonRpcLocalStats,","if its optional, move it to last item an use JsonRpcUrl? url = null",Why does it need to be nullable? Should it be `string? url`?
+8320,"@@ -58,6 +58,14 @@ class User < ActiveRecord::Base
+     user
+   end
+
++  def client_model
++    Proposal.client_model_for(self)
++  end
++
++  def client_model_slug
++    client_model.to_s.underscore.tr(""/"", ""_"")
++  end
++
+   def add_role(role_name)
+     role = Role.find_or_create_by!(name: role_name)
+     user_roles.find_or_create_by!(role: role)",how is this different from the `client_slug` method already available on a `user` ?,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+8321,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...,This should not be part of this PR
+8322,"@@ -49,11 +49,14 @@ module Travis
+             fi
+           ),
+           redirect_io: %(
+-            exec > >(
+-              %{curl}
+-              %{exports}
+-              ruby ~/filter.rb %{args}
+-            ) 2>&1
++            if [[ -z ""$TRAVIS_FILTERED"" ]]; then
++              export TRAVIS_FILTERED=1
++              exec 9>&1 1>(
++                %{curl}
++                %{exports}
++                ruby ~/filter.rb %{args}
++              ) 2>&1
++            fi
+           )
+         }
+ ",I believe this env var won't be set anywhere. Do we need this condition?,Do we need to make this conditional on $TRAVIS_FILTERED? Seems like we only need to do this for one branch.
+8323,"@@ -14,7 +14,7 @@ function getWindowLocationSearch(win) {
+     return search || '';
+ }
+
+-function getParameterByName(name, url) {
++window.getParameterByName = function (name, url) {
+     'use strict';
+
+     name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');",why add function explicitly?,Let's move this function to the top of the file.
+8324,"@@ -92,7 +92,8 @@ func newLevel() *level {
+
+ // New will create a default sublist
+ func NewSublist() *Sublist {
+-	return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)}
++	//	return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)}
++	return &Sublist{root: newLevel()}
+ }
+
+ // Insert adds a subscription into the sublist","Is that intentional? If you don't create the cache here, it will never be created therefore used.",Just delete this line.
+8325,"@@ -136,4 +136,15 @@ func TestStream(t *testing.T) {
+ 		require.Greater(t, streamer.fetchCount, 1, ""expected more than one call to Fetch within timeout"")
+ 		require.Greater(t, streamer.notifyCount, 1, ""expected more than one call to Notify within timeout"")
+ 	})
++
++	t.Run(""nextFetchDate works correctly to grab times before the timeout."", func(t *testing.T) {
++		for r := 0; r < 1000; r++ {
++			now := time.Now()
++			a := nextFetchDate(now, 0)
++			require.True(t, a.Before(now.Add(4*time.Second)), ""require that the given date for 0 retries is less than 4s in the future"")
++			b := nextFetchDate(now, 10)
++			require.True(t, b.Before(now.Add(32*time.Second)), ""require that the given date for 10 retries is never more than the max interval"")
++		}
++
++	})
+ }",I think we can now remove this test case since we can ensure that multiple calls to `Fetch` will double the interval on each call,[nit] It would be nice
+8326,"@@ -64,7 +64,7 @@ type (
+ )
+
+ const (
+-	reservedTaskListPrefix = ""/__cadence_sys/""
++	reservedTaskListPrefix = ""/__temporal_sys/""
+ )
+
+ func newDecisionAttrValidator(",Not part of this PR but this const seems to be defined in multiple places. Needs to be extracted somewhere.,I think you need to ch
+8327,"@@ -2,6 +2,7 @@ package volume
+
+ import (
+ 	""fmt""
++
+ 	""github.com/libopenstorage/openstorage/api""
+ 	""github.com/libopenstorage/openstorage/api/client""
+ 	""github.com/libopenstorage/openstorage/volume""",Remove this file from the PR,Please remove this lin
+8328,"@@ -55,6 +55,11 @@ namespace Nethermind.Core.Specs
+             {
+                 return Byzantium.Instance;
+             }
++
++            if (blockNumber < IstanbulBlockNumber)
++            {
++                return Istanbul.Instance;
++            }
+
+             return ConstantinopleFix.Instance;
+         }","need to add it for ropsten, rinkeby, goerli as well",Is there a reason why Istanbul isn't just using the `BlockNumber` property?
+8329,"@@ -109,7 +109,7 @@ func (v *VolumeProperty) Execute() ([]byte, error) {
+ 		return nil, err
+ 	}
+ 	// execute command here
+-	return exec.Command(bin.ZFS, v.Command).CombinedOutput()
++	return exec.Command(bin.BASH, ""-c"", v.Command).CombinedOutput()
+ }
+
+ // Build returns the VolumeProperty object generated by builder",G204: Subprocess launching should be audited (from `gosec`),does this return the value of `-c` in case of an error?
+8330,"@@ -49,11 +49,11 @@ import org.apache.orc.storage.ql.exec.vector.MapColumnVector;
+ import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
+ import org.apache.orc.storage.serde2.io.HiveDecimalWritable;
+
+-class FlinkOrcReaders {
++public class FlinkOrcReaders {
+   private FlinkOrcReaders() {
+   }
+
+-  static OrcValueReader<StringData> strings() {
++  public static OrcValueReader<StringData> strings() {
+     return StringReader.INSTANCE;
+   }
+ ","curious why only making these 3 public. what about other package scope methods like `times`, `timestamps`, `array`?",I think it would be better to expose the reader directly instead of introdu
+8331,"@@ -0,0 +1,15 @@
++<?php
++
++return [
++    /*
++    |--------------------------------------------------------------------------
++    | Exclusion list
++    |--------------------------------------------------------------------------
++    |
++    | This is a list of exclusions for words or phrases where the original
++    | form of the word has the same spelling in a given language.
++    |
++    */
++
++    'Email',
++];","The Email field is not translated into Russian, and into any other. It's kind of a ""standard"" word. Therefore, we may face the fact that you have to create files with exceptions for all languages. @caouecs, what do you say?",This should be `Exclusion list`
+8332,"@@ -32,6 +32,9 @@ int main (int argc, char * const * argv)
+ 		(""disable_unchecked_drop"", ""Disables drop of unchecked table at startup"")
+ 		(""fast_bootstrap"", ""Increase bootstrap speed for high end nodes with higher limits"")
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
++		(""block_processor_batch_size"",boost::program_options::value<std::size_t> (), ""Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time), 256k for fast_bootstrap"")
++		(""block_processor_full_size"",boost::program_options::value<std::size_t> (), ""Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536, 1 million for fast_bootstrap"")
++		(""block_processor_verification_size"",boost::program_options::value<std::size_t> (), ""Increase batch signature verification size in block processor, default 0 (2048 * signature checker threads + 1), unlimited for fast_bootstrap"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
+ 		(""debug_dump_online_weight"", ""Dump online_weights table"")",Should it say `default 0` here? looks a bit confusing. Also following BODMAS we should put: `2048 * (signature checker threads + 1)`,"I think the name `block_processor_batch_size` is too generic, maybe something like `block_processor_max_queue_size` ?"
+8333,"@@ -16,6 +16,7 @@
+
+ from __future__ import print_function
+ import os
++import ruamel.yaml
+
+ import constants
+ import utils","Add a newline. We group by 1: standard library, 2: 3rd party library, 3: application library",Please remove this import (which is now unused)
+8334,"@@ -83,7 +83,9 @@ func (p *Provider) Type() string {
+ 	return ProviderType
+ }
+
+-func (p *Provider) RunQuery(ctx context.Context, query string, queryRange metrics.QueryRange, evaluator metrics.Evaluator) (bool, string, error) {
++// Evaluate queries the range query endpoint and checks if values in all data points are within the expected range.
++// For the range query endpoint, see: https://prometheus.io/docs/prometheus/latest/querying/api/#range-queries
++func (p *Provider) Evaluate(ctx context.Context, query string, queryRange metrics.QueryRange, evaluator metrics.Evaluator) (bool, string, error) {
+ 	if err := queryRange.Validate(); err != nil {
+ 		return false, """", err
+ 	}",So `queryRange.Step` will be ignored?,"nit: make the return type `(executed bool, string, error)` instead of `bool, string, error`."
+8335,"@@ -24,13 +24,13 @@
+
+ // making the defines very clear, these represent the host architecture - aka
+ // the arch on which this code is running
+-#if defined(_X86_)
++#if defined(HOST_X86)
+ #define _HOST_X86_
+-#elif defined(_AMD64_)
++#elif defined(HOST_AMD64)
+ #define _HOST_AMD64_
+-#elif defined(_ARM_)
++#elif defined(HOST_ARM)
+ #define _HOST_ARM_
+-#elif defined(_ARM64_)
++#elif defined(HOST_ARM64)
+ #define _HOST_ARM64_
+ #endif
+ ",It would be nice to replace these _HOST_* defines with HOST_*.,These host defines are definitely wrong. Host_X86_ is the architecture of the machine on which the code is running. H
+8336,"@@ -299,5 +299,9 @@ func doList(dir string, out io.Writer, arg, indent string) error {
+ // scrub removes dynamic content from recorded files.
+ func scrub(rootDir string, b []byte) []byte {
+ 	const scrubbedRootDir = ""[ROOTDIR]""
+-	return bytes.ReplaceAll(b, []byte(rootDir), []byte(scrubbedRootDir))
++	rootDirWithSeparator := rootDir + string(filepath.Separator)
++	scrubbedRootDirWithSeparator := scrubbedRootDir + string(filepath.Separator)
++	b = bytes.Replace(b, []byte(rootDirWithSeparator), []byte(scrubbedRootDirWithSeparator), -1)
++	b = bytes.Replace(b, []byte(rootDir), []byte(scrubbedRootDir), -1)
++	return b
+ }","The problem here was that the record file started with something like `/tmp/whatever/myproj` and was scrubbed to `[ROOTDIR]/myproj`, but the `/` is a `\` on Windows.",Why not just append `[ROOTDIR]` to `rootDir`?
+8337,"@@ -33,10 +33,13 @@
+
+ #include <rtps/builtin/data/ProxyHashTables.hpp>
+
++#include ""../../../fastdds/core/policy/ParameterList.hpp""
++
+ #include <mutex>
+ #include <chrono>
+
+ using namespace eprosima::fastrtps;
++using ParameterList = eprosima::fastdds::dds::ParameterList;
+
+ namespace eprosima {
+ namespace fastrtps {",Don't use relative paths. src directory is already on the include search path,Why do you need ParameterList.hpp?
+8338,"@@ -177,8 +177,12 @@ type BuildTarget struct {
+ 	// Tools that this rule will use, ie. other rules that it may use at build time which are not
+ 	// copied into its source directory.
+ 	Tools []BuildInput
++	// Like tools but available to the test_cmd instead
++	TestTools []BuildInput
+ 	// Named tools, similar to named sources.
+ 	namedTools map[string][]BuildInput `name:""tools""`
++	// Named test tools, similar to named sources.
++	namedTestTools map[string][]BuildInput `name:""test_tools""`
+ 	// Target-specific environment passthroughs.
+ 	PassEnv *[]string `name:""pass_env""`
+ 	// Target-specific unsafe environment passthroughs.",if we're introducing this now can we make this private?,Maybe call this `TestTools` instead?
+8339,"@@ -103,6 +103,17 @@ namespace pwiz.Skyline.Model.Results
+             if (_totalSteps == 0)
+                 return measured;
+
++            // Before we do anything else, make sure the raw files are present
++            foreach (var f in fileInfos)
++            {
++                if (!ScanProvider.FileExists(_documentFilePath, f.FilePath))
++                {
++                    throw new FileNotFoundException(TextUtil.LineSeparate(Resources.IonMobilityFinder_ProcessMSLevel_Failed_using_results_to_populate_ion_mobility_library_,
++                    string.Format(Resources.ScanProvider_GetScans_The_data_file__0__could_not_be_found__either_at_its_original_location_or_in_the_document_or_document_parent_folder_,
++                        f.FilePath)));
++                }
++            }
++
+             using (_msDataFileScanHelper = new MsDataFileScanHelper(SetScans, HandleLoadScanException, true))
+             {
+                 //",Something is wrong with the indentation here.,nit: `__0__` => `__0__`
+8340,"@@ -18,12 +18,13 @@ package importtestsuites
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/compute""
+ 	""log""
+ 	""regexp""
++	""strings""
+ 	""sync""
+
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/path""
+-	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/compute""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/test_suites""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/e2e_test_utils/junitxml""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/e2e_test_utils/test_config""",This should go to the external imports group below,Is this import still needed?
+8341,"@@ -36,6 +36,7 @@ func NewInstaller(dc dynamic.Interface, config map[string]string, paths ...strin
+ 	}
+
+ 	for i, p := range paths {
++		log.Println(""processing yaml folder"", p)
+ 		paths[i] = ParseTemplates(p, config)
+ 	}
+ 	path := strings.Join(paths, "","")",Intended to be checked in?,nit: remove? If you want to
+8342,"@@ -307,7 +307,10 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+
+       // Currently nothing to do but print a warning
+       LOGGER.warn(""There are schemas only existing in service center: {}, which means there are interfaces changed. ""
+-          + ""It's recommended to increment microservice version before deploying."", scSchemaMap.keySet());
++              + ""It's recommended to increment microservice version before deploying."",
++          scSchemaMap.keySet());
++      LOGGER.warn(""ATTENTION: The schemas in new version are less than the old version, ""
++          + ""which may cause compatibility problems."");
+     }
+   }
+ ","I think this warning message is the same as above one. Anyway, it's fine to keep it.",I don't think we should be p
+8343,"@@ -46,7 +46,7 @@ namespace Nethermind.Logging
+
+             if (NLog.LogManager.Configuration?.AllTargets.SingleOrDefault(t => t.Name == ""file"") is FileTarget target)
+             {
+-                target.FileName = !Path.IsPathFullyQualified(fileName) ? Path.Combine(""logs"", fileName) : fileName;
++                target.FileName = !Path.IsPathFullyQualified(fileName) ? Path.Combine(logsDir, fileName) : fileName;
+             }
+
+             /* NOTE: minor perf gain - not planning to switch logging levels while app is running */","This is done few times, replace with some well named method",@stephentoub what is the rea
+8344,"@@ -101,14 +101,14 @@ public class CodeGeneratorTool {
+
+   private static int generate(
+       String descriptorSet,
+-      String[] apiConfigs,
++      String[] configs,
+       String[] generatorConfigs,
+       String packageConfig,
+       String outputDirectory,
+       String[] enabledArtifacts) {
+     ToolOptions options = ToolOptions.create();
+     options.set(ToolOptions.DESCRIPTOR_SET, descriptorSet);
+-    options.set(ToolOptions.CONFIG_FILES, Lists.newArrayList(apiConfigs));
++    options.set(ToolOptions.CONFIG_FILES, Lists.newArrayList(configs));
+     options.set(CodeGeneratorApi.OUTPUT_FILE, outputDirectory);
+     options.set(CodeGeneratorApi.GENERATOR_CONFIG_FILES, Lists.newArrayList(generatorConfigs));
+     options.set(CodeGeneratorApi.PACKAGE_CONFIG_FILE, packageConfig);","`configs` isn't very descriptive, especially when there are other config-ish things like `generatorConfigs`.",I think we should rename the method to something more meaningful. Maybe just `generateConfig`?
+8345,"@@ -192,7 +192,12 @@ class TestGatlingExecutor(BZTestCase):
+                               }]},
+                              {""url"": ""/"",
+                               ""think-time"": 2,
+-                              ""follow-redirects"": True}]
++                              ""follow-redirects"": True},
++                             {""url"": ""/reserve.php"",
++                              ""method"": ""POST"",
++                              ""body"": u""Body Content 2"",
++                              }
++                             ]
+             }
+         })
+         self.obj.prepare()",In my point we have to check conversion with specific (non-ASCII) characters in unicode string.,The correct URL here is `/reserve.php?method=POST&body=Body Content 2`
+8346,"@@ -1,6 +1,7 @@
+ tests = [
+-  (""python"", ""EmbedLib.py"", {}),
++  #   (""python"", ""EmbedLib.py"", {}),
+   (""python"", ""UnitTestEmbed.py"", {}),
++  (""python"", ""UnitTestExcludedVolume.py"", {}),
+   (""python"", ""UnitTestPharmacophore.py"", {}),
+ ]
+ ","Given that file still contains doctests (and should still contain doctests), they should be run. Please turn this back on.",why did you remove this?
+8347,"@@ -70,6 +70,7 @@ public class SignUtils {
+     private static final String ATTR_CONTENTS = ""contents"";
+     private static final String ATTR_CERT_DNS_DOMAIN = ""certDnsDomain"";
+     private static final String ATTR_AUDIT_ENABLED = ""auditEnabled"";
++    private static final String ATTR_SELF_SERVE = ""selfserve"";
+
+     private static Struct asStruct(DomainPolicies domainPolicies) {
+         // all of our fields are in canonical order based",we should keep the camel case format - selfServe,I don't think we should be adding `selfserve` as a new attribute in `DomainPolicies`.
+8348,"@@ -17,14 +17,15 @@ package patch
+ import (
+ 	""time""
+
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/compute""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/utils""
+-	""google.golang.org/api/compute/v1""
++	api ""google.golang.org/api/compute/v1""
+ )
+
+ type patchTestSetup struct {
+ 	testName      string
+ 	image         string
+-	startup       *compute.MetadataItems
++	metadata      []*api.MetadataItems
+ 	assertTimeout time.Duration
+ 	machineType   string
+ }",consider the alias `compute` in case this ever references other apis.,Did you mean to rename this to `metadataItems`?
+8349,"@@ -392,3 +392,7 @@ func (m *manager) GetFreezerState() (configs.FreezerState, error) {
+ 	}
+ 	return freezer.(*FreezerGroup).GetState(dir)
+ }
++
++func (m *manager) Exists() bool {
++	return cgroups.PathExists(m.paths[""devices""])
++}","It probably doesn't matter in practice, but we're not supposed to access a map without holding a lock. This is why I have suggested using `m.Path(""devices"")` earlier -- it takes a lock before accessing m.paths. Alternatively, you can leave this code as is but add taking a lock (same as `Path()`).","Shouldn't you check that `m.paths[""devices""]` i"
+8350,"@@ -33,6 +33,8 @@ let baseModuleStore = Modules.createModuleStore( 'tagmanager', {
+ 		'internalAMPContainerID',
+ 		'useSnippet',
+ 		'ownerID',
++		'gaAMPPropertyID',
++		'gaPropertyID',
+ 	],
+ 	submitChanges,
+ 	validateCanSubmitChanges,","Since `ga` is an acronym here, we should rename the generated actions and selectors to adhere to our naming conventions as it will no longer be capitalized properly. See below for how this is already done for the amp container ID settings. We should add `GA` to our list of checked acronyms as well in `packages/eslint-plugin/rules/acronym-case.js`.",Do we need a separate `gaPropertyID`?
+8351,"@@ -88,12 +88,11 @@ class TransloaditAssembly extends Emitter {
+
+     socket.on('assembly_upload_finished', (file) => {
+       this.emit('upload', file)
+-      this._fetchStatus({ diff: false })
++      this.status.uploads.push(file)
+     })
+
+     socket.on('assembly_uploading_finished', () => {
+       this.emit('executing')
+-      this._fetchStatus({ diff: false })
+     })
+
+     socket.on('assembly_upload_meta_data_extracted', () => {","uploading_finished and upload_meta_data_extracted can fire very quickly after another, and there is not much difference in the Assembly status that's useful to us. I kept only the Assembly fetch after metadata is extracted, which ensures that we'll have all the correct `uploads.*.meta` properties on the client side.",Did you mean to remove the diff handling from `
+8352,"@@ -53,7 +53,10 @@ func (m *manager) getControllers() error {
+
+ 	file := filepath.Join(m.dirPath, ""cgroup.controllers"")
+ 	data, err := ioutil.ReadFile(file)
+-	if err != nil && !m.rootless {
++	if err != nil {
++		if m.rootless && m.config.Path == """" {
++			return nil
++		}
+ 		return err
+ 	}
+ 	fields := strings.Fields(string(data))","Does it make sense to keep trying to read the file every time the function is called, or should we maybe use `sync.Once()` here?","Unrelated to this PR, but shouldn't we check for `!m.rootless && m.config.Path == """"` as well?"
+8353,"@@ -59,6 +59,7 @@ type Bee struct {
+
+ type Options struct {
+ 	DataDir            string
++	DbCapacity         uint64
+ 	Password           string
+ 	APIAddr            string
+ 	DebugAPIAddr       string",`DbCapacity` -> `DBCapacity`,"`DbCapacity` is a `uint64` and not a `string`, so `int64` is fine here."
+8354,"@@ -56,8 +56,10 @@ namespace Nethermind.Network.Test
+         [TestCase(0, ""0xa3f5ab08"", 1_561_651L, ""Unsynced"")]
+         [TestCase(1_561_650L, ""0xa3f5ab08"", 1_561_651L, ""Last Constantinople block"")]
+         [TestCase(1_561_651L, ""0xc25efa5c"", 4_460_644L, ""First Istanbul block"")]
+-        [TestCase(4_460_644L, ""0x757a1c47"", 0L, ""First Berlin block"")]
+-        [TestCase(6_000_000L, ""0x757a1c47"", 0L, ""Future Berlin block"")]
++        [TestCase(4_460_644L, ""0x757a1c47"", 5_062_605, ""First Berlin block"")]
++        [TestCase(4_600_000L, ""0x757a1c47"", 5_062_605, ""Future Berlin block"")]
++        [TestCase(5_062_605L, ""0xB8C6299D"", 0L, ""First London block"")]
++        [TestCase(5_979_794L, ""0xB8C6299D"", 0L, ""Future London block"")]
+         public void Fork_id_and_hash_as_expected_on_goerli(long head, string forkHashHex, long next, string description)
+         {
+             Test(head, KnownHashes.GoerliGenesis, forkHashHex, next, description, GoerliSpecProvider.Instance, ""goerli.json"");",For Berlin I confirmed all the fork hashes with the Geth team. Would you do the same with Martin? He responded quickly the last time.,Why are these tests changed?
+8355,"@@ -63,6 +63,19 @@ func Wireguard() error {
+ 	return sh.RunV(cmdParts[0], cmdParts[1:]...)
+ }
+
++// SOCKS5 builds and starts SOCKS5 service with terms accepted
++func SOCKS5() error {
++	if err := sh.RunV(""bin/build""); err != nil {
++		return err
++	}
++	cmd := ""build/myst/myst service --agreed-terms-and-conditions socks5""
++	if runtime.GOOS == ""darwin"" {
++		cmd = ""sudo "" + cmd
++	}
++	cmdParts := strings.Split(cmd, "" "")
++	return sh.RunV(cmdParts[0], cmdParts[1:]...)
++}
++
+ // CLI builds and runs myst CLI
+ func CLI() error {
+ 	if err := sh.RunV(""bin/build""); err != nil {",Does `sudo` required for `darwin` only? Don't we need it for `linux` too?,"Should this be `socks5` (to be consistent with `myst`, not `socks5`) or `mysts`?"
+8356,"@@ -11,11 +11,17 @@ import (
+ 	""text/tabwriter""
+
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/cloudformation""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/resourcegroups""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/session""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store""
+ 	sess ""github.com/aws/aws-sdk-go/aws/session""
+ )
+
++const (
++	cloudformationResourceType = ""AWS::CloudFormation::Stack""
++)
++
+ type EnvDescription struct {
+ 	Environment  *archer.Environment   `json:""environment""`
+ 	Applications []*archer.Application `json:""applications""`",Can you add description to this exported struct?,Let's just call it `CloudFormation::Stack`
+8357,"@@ -68,13 +68,14 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		state = component.state,
+ 		context = component.context,
+ 		previousProps = component.prevProps || props,
+-		previousState = component.prevState || state,
++		previousState = extend({}, component.prevState || state),
+ 		previousContext = component.prevContext || context,
+ 		isUpdate = component.base,
+ 		nextBase = component.nextBase,
+ 		initialBase = isUpdate || nextBase,
+ 		initialChildComponent = component._component,
+ 		skip = false,
++		snapshot = previousContext,
+ 		rendered, inst, cbase;
+
+ 	if (component.constructor.getDerivedStateFromProps) {","Although this is needed for `getSnapshotBeforeUpdate` this also fixes a bug with `componentDidUpdate`. During rendering, the `state` variable is mutated. This has the consequence, that `previousState` would never hold the previous state, but the most current one.",Shouldn't this be `component.prevState ||
+8358,"@@ -15,6 +15,7 @@ package ec2
+
+ import (
+ 	""github.com/aws/aws-sdk-go/service/ec2/ec2iface""
++	""github.com/aws/aws-sdk-go/service/elb/elbiface""
+ )
+
+ // Service holds a collection of interfaces.",Should this maybe directly start with ELBv2 aka NLBs or ALBs?,Nit: can you move this down with the other
+8359,"@@ -59,6 +59,11 @@ describe( 'Tag Manager module setup', () => {
+ 				request.respond( {
+ 					status: 200,
+ 				} );
++			} else if ( request.url().match( 'google-site-kit/v1/core/site/data/notifications' ) ) {
++				request.respond( {
++					status: 200,
++					body: JSON.stringify( [] ),
++				} );
+ 			} else if ( request.url().match( 'modules/tagmanager/data/live-container-version' ) ) {
+ 				// Return a live container version without GA.
+ 				request.respond( { status: 200, body: JSON.stringify( liveContainerVersionFixture ) } );",This was the request that was often causing the test to fail as an unexpected API failure (or at least one of them   ).,We need a test case for this as well
+8360,"@@ -0,0 +1,13 @@
++class NetworkError extends Error {
++  constructor (error = null, xhr = null) {
++    super(error.message)
++
++    this.isNetworkError = true
++    this.originalRequest = xhr
++
++    const message = error.message + '. This looks like a network error, the endpoint might be blocked by an ISP or a firewall'
++    this.message = message
++  }
++}
++
++module.exports = NetworkError","I understand why `xhr = null`, but I think adding `error = null` implies that this method should work even if we don't pass the `error` argument. Should we remove it?","If we don't have a `NetworkError` class, do we need to subclass it? Can't we just use `Error`?"
+8361,"@@ -73,7 +73,8 @@ public abstract class GapicMethodConfig extends MethodConfig {
+       Method method,
+       ProtoMethodModel methodModel,
+       RetryCodesConfig retryCodesConfig,
+-      ImmutableSet<String> retryParamsConfigNames) {
++      ImmutableSet<String> retryParamsConfigNames,
++      GrpcGapicRetryMapping retryMapping) {
+
+     GrpcStreamingConfig grpcStreaming = null;
+     if (isGrpcStreamingMethod(methodModel)) {","It is not your code, and it is used like this all over the place in gapic generator, but the general rule is we should prefer using the least specific class/interface in the hierarchy, which still satisfies our requirements. Here, unless we really need anything specific from `ImmutableSet`, please use `Set` (less specific type) instead.",I think we can remove `GrpcGapicRetryMapping` and just pass `GrpcStreamingConfig` directly.
+8362,"@@ -162,9 +162,18 @@ struct flb_elasticsearch *flb_es_conf_create(struct flb_output_instance *ins,
+             }
+             ctx->aws_region = (char *) tmp;
+
++            tmp = flb_output_get_property(""aws_sts_endpoint"", ins);
++            if (!tmp) {
++                flb_error(""[out_es] aws_sts_endpoint not set"");
++                flb_es_conf_destroy(ctx);
++                return NULL;
++            }
++            ctx->aws_sts_endpoint = (char *) tmp;
++
+             ctx->aws_provider = flb_standard_chain_provider_create(config,
+                                                                    &ctx->aws_tls,
+                                                                    ctx->aws_region,
++                                                                   ctx->aws_sts_endpoint,
+                                                                    NULL,
+                                                                    flb_aws_client_generator());
+             if (!ctx->aws_provider) {","Sorry... I just realized... since we use sts_endpoint in the EKS Provider, this error message is no longer true. Role_arn is not required.","Just curious, do we need to free this?"
+8363,"@@ -206,6 +206,18 @@ public interface Tree<T> extends Traversable<T>, Serializable {
+         return io.vavr.collection.Collections.fill(n, s, empty(), Tree::of);
+     }
+
++    /**
++     * Returns a Tree containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Tree
++     * @param n       The number of elements in the Tree
++     * @param element The element
++     * @return A Tree of size {@code n}, where each element is the given {@code element}.
++     */
++    static <T> Tree<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element, empty(), Tree::of);
++    }
++
+     /**
+      * Recursively builds a non-empty {@code Tree}, starting with the given {@code seed} value and proceeding in depth-first order.
+      * <p>","(...), where each element ~are~ **is the** given {\@code element}.",The return type should be `Tree<T>`.
+8364,"@@ -73,6 +73,7 @@ abstract class BaseFile<F>
+   private long[] splitOffsets = null;
+   private int[] equalityIds = null;
+   private byte[] keyMetadata = null;
++  private Integer sortOrderId;
+
+   // cached schema
+   private transient Schema avroSchema = null;","I think this can be an int because we have a default that is always valid, `0`.",Why is this an `Integer` and not a `boolean`?
+8365,"@@ -141,6 +141,17 @@ describe Section do
+     end
+   end
+
++  describe '.upcoming?' do
++    it 'knows if it has happened yet' do
++      next_week = Section.new(starts_on: 1.week.from_now)
++      last_week = Section.new(starts_on: 1.week.ago)
++      today = Section.new(starts_on: Date.today)
++      expect(today).to be_upcoming
++      expect(next_week).to be_upcoming
++      expect(last_week).not_to be_upcoming
++    end
++  end
++
+   describe '#fulfillment_method' do
+     it 'returns in-person if the workshop is an in-person one' do
+       in_person_workshop = create(:workshop, online: false)",I think you can use `build_stubbed` here for the same results but with more speed.,Don't use parentheses around a method call.
+8366,"@@ -491,6 +491,11 @@ class JMX(object):
+         if hold or (rampup and not iterations):
+             scheduler = True
+
++        if isinstance(rampup, numeric_types) and isinstance(hold, numeric_types):
++            duration = hold + rampup
++        else:
++            duration = 0
++
+         trg = etree.Element(""ThreadGroup"", guiclass=""ThreadGroupGui"",
+                             testclass=""ThreadGroup"", testname=testname)
+         if on_error is not None:",what if one of them is property and one is not?,what about `if hold is not None`?
+8367,"@@ -277,6 +277,8 @@ module.exports = class Dashboard extends Plugin {
+         name: file.name,
+         type: file.type,
+         data: blob
++      }).catch(() => {
++        // Ignore
+       })
+     })
+   }",> UI plugins swallow rejection errors so they don't end up in the console with no way to fix But it will still catch upstream in `addFile` and restrictions to show the informer?..  ,Do we want to log something here?
+8368,"@@ -378,11 +378,12 @@ const executeOperation = (topology, operation, args, options) => {
+
+   // The driver sessions spec mandates that we implicitly create sessions for operations
+   // that are not explicitly provided with a session.
+-  let session, opOptions;
++  let session, opOptions, owner;
+   if (!options.skipSessions && topology.hasSessionSupport()) {
+     opOptions = args[args.length - 2];
+     if (opOptions == null || opOptions.session == null) {
+-      session = topology.startSession();
++      owner = {};
++      session = topology.startSession({ owner });
+       const optionsIndex = args.length - 2;
+       args[optionsIndex] = Object.assign({}, args[optionsIndex], { session: session });
+     } else if (opOptions.session && opOptions.session.hasEnded) {",can't this just be left undefined/null?,Can we just pass the options object directly to `startSession` instead of introducing a new field?
+8369,"@@ -64,8 +64,8 @@ module EsSpecHelper
+   def es_execute_with_retries(retries = 3, &block)
+     begin
+       retries -= 1
+-      response = block.call
+-    rescue SearchUnavailable => _error
++      block.call
++    rescue SearchUnavailable => error
+       if retries > 0
+         retry
+       else",changed bc we are using the `error` var below,can we add `rescue SearchUnavailable => error` to the retry block?
+8370,"@@ -172,13 +172,7 @@ class TestKnowledgeRestfulAPI(APITestCase):
+             user_id=1,
+         )
+
+-        answer = get_answer.json
+-
+-        expected_result = dict(
+-            status=404,
+-        )
+-
+-        assert answer['status'] == expected_result['status']
++        assert get_answer.status_code == 404
+
+     def test_get_knwkb_mappings(self):
+         """"""Test the return of list of mappings.""""""",Is there a reason why this is change is in the same commit?,"`get_answer` is returning an answer object, so I think we should be checking that the content of `"
+8371,"@@ -77,7 +77,7 @@ func (r *repo) GetClonedBranch() string {
+
+ // Copy does copying the repository to the given destination.
+ func (r *repo) Copy(dest string) (Repo, error) {
+-	cmd := exec.Command(""cp"", ""-rf"", r.dir, dest)
++	cmd := copyCommand(r.dir, dest)
+ 	out, err := cmd.CombinedOutput()
+ 	if err != nil {
+ 		return nil, formatCommandError(err, out)","@nghialv btw, perhaps was this method originally created for copying the repo root to the given `dest` as a subdirectory?",Why did you move the source command to a separate function?
+8372,"@@ -205,7 +205,7 @@ namespace pwiz.Skyline.Model.Lib
+         // ReSharper disable LocalizableElement
+         private bool LoadLibraryFromDatabase(ILoadMonitor loader)
+         {
+-            var status = new ProgressStatus(
++            IProgressStatus status = new ProgressStatus(
+                 string.Format(Resources.ChromatogramLibrary_LoadLibraryFromDatabase_Reading_precursors_from__0_,
+                     Name));
+             try",Just curious - why not var?,"Nit: as above, change the variable name to `progressStatus`."
+8373,"@@ -26,6 +26,9 @@ import {
+ 	clearWebStorage,
+ } from './util/standalone';
+
++// Load image for the parent menu item.
++import '../images/logo-g_white_small.png';
++
+ if ( 'toplevel_page_googlesitekit-dashboard' !== global.pagenow && 'site-kit_page_googlesitekit-splash' !== global.pagenow && 'admin_page_googlesitekit-splash' !== global.pagenow && global.localStorage ) {
+ 	// The total notifications count should always rely on local storage
+ 	// directly for external availability.",Why would we import this here and not use it? Is there a side-effect of this import?,Can we put this import at the top of the file?
+8374,"@@ -281,8 +281,10 @@ module RSpec::Core
+     # @attr pending_examples [Array<RSpec::Core::Example>] the pending examples
+     # @attr load_time [Float] the number of seconds taken to boot RSpec
+     #                         and load the spec files
++    # @attr errors [Integer] the number of errors that have occurred processing
++    #                        the spec suite
+     SummaryNotification = Struct.new(:duration, :examples, :failed_examples,
+-                                     :pending_examples, :load_time)
++                                     :pending_examples, :load_time, :errors)
+     class SummaryNotification
+       # @api
+       # @return [Fixnum] the number of examples run",The name `errors` is a bit mis-leading -- usually I'd expect a field called `errors` to be an array of errors but here it's just a count. And it's not a count of _all_ errors -- it's a count only of some errors.,"is ""the number of errors that have occurred processing"" a bi"
+8375,"@@ -24,7 +24,6 @@ class AppKernel extends Kernel
+             new JMS\TranslationBundle\JMSTranslationBundle(),
+             new Presta\SitemapBundle\PrestaSitemapBundle(),
+             new Prezent\Doctrine\TranslatableBundle\PrezentDoctrineTranslatableBundle(),
+-            new RaulFraile\Bundle\LadybugBundle\RaulFraileLadybugBundle(),
+             new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
+             new Shopsys\FormTypesBundle\ShopsysFormTypesBundle(),
+             new ShopSys\MigrationBundle\ShopSysMigrationBundle(),",there was no usage of the bundle in the framework? everything works exactly the same after the removal?,Can you also remove the `RaulFraileLadybugBundle` ?
+8376,"@@ -327,6 +327,14 @@ var _ = infrastructure.DatastoreDescribe(""_BPF-SAFE_ IPIP topology before adding
+ 		BeforeEach(func() {
+ 			ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
+ 			defer cancel()
++			if bpfEnabled {
++				infra.RemoveNodeAddresses(felixes[0])
++			} else {
++				for _, f := range felixes {
++					infra.RemoveNodeAddresses(f)
++				}
++			}
++
+ 			listOptions := options.ListOptions{}
+ 			if bpfEnabled {
+ 				listOptions.Name = felixes[0].Hostname",Why this difference?,BeforeEach should be called with a context timeout.
+8377,"@@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
+         if (retcode == SQL_ERROR)
+         {
+             ERROR_DESC_def *p_buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
++            char             errNumStr[128];
++            sprintf(errNumStr, ""%d"", p_buffer->sqlcode);
+             strncpy(RequestError, p_buffer->errorText, sizeof(RequestError) - 1);
+
+             SendEventMsg(MSG_SQL_ERROR,","Surround code issue. RequestError may not be null terminated when the RequestError size is less than the length of the string in p_buffer->errorText. Also, this can cause core dump due to segment violation if length of errorText is less than the size of RequestBuffer.","I think this should be `strncpy(RequestError, p_buf"
+8378,"@@ -43,6 +43,11 @@ const (
+ 	AccountTrieRootKey = ""accountTrieRoot""
+ )
+
++var (
++	// AccountMaxVersionPrefix is for account history
++	AccountMaxVersionPrefix = []byte(""vp."")
++)
++
+ type (
+ 	// Factory defines an interface for managing states
+ 	Factory interface {",`AccountMaxVersionPrefix` is a global variable (from `gochecknoglobals`),"If this is only used in the tests, suggest moving i"
+8379,"@@ -32,7 +32,6 @@ import (
+
+ 	apicommon ""go.temporal.io/api/common/v1""
+ 	""go.temporal.io/api/enums/v1""
+-	apinamespace ""go.temporal.io/api/namespace/v1""
+ 	apireplication ""go.temporal.io/api/replication/v1""
+ 	""go.temporal.io/api/serviceerror""
+ 	""go.temporal.io/api/workflowservice/v1""","I see it is not part of this PR but I somehow overlooked it before. Can you use same import aliases as we use everywhere in the project: `apicommon` -> `commonpb` `apireplication` -> `replicationpb` `""go.temporal.io/api/enums/v1""` -> `enumspb ""go.temporal.io/api/enums/v1""`",Can you explain why this is removed?
+8380,"@@ -235,7 +235,7 @@ class Storage(StorageBase, MigratorMixin):
+                     error_msg = (
+                         ""Cannot initialize empty resource timestamp "" ""when running in readonly.""
+                     )
+-                    raise exceptions.BackendError(message=error_msg)
++                    raise exceptions.ReadonlyError(message=error_msg)
+                 obj = row
+             else:
+                 create_result = conn.execute(",Nit: Maybe merge these into one string while you are here?,"Could you please update the error message to be ""Cannot initialize empty resource timestamp "" rather than ""Cannot initialize empty resource timestamp"""
+8381,"@@ -0,0 +1,15 @@
++package runtime
++
++// noret is a placeholder that can be used to indicate that an async function is not going to directly return here
++func noret() {}
++
++func getParentHandle() *task {
++	panic(""NOPE"")
++}
++
++func fakeCoroutine(dst **task) {
++	*dst = getCoroutine()
++	for {
++		yield()
++	}
++}",Why make a new file for this? I think keeping everything related to the scheduler in a single file increases readability. Especially when there is no API-boundary in between. Functions like `getCoroutine` and `yield` also live in the normal scheduler files so it doesn't seem consistent.,"The `noret` function is only used in tests, so we can delete it."
+8382,"@@ -132,9 +132,10 @@ func (c *endpointManagerCallbacks) InvokeRemoveWorkload(old *proto.WorkloadEndpo
+ // that fail are left in the pending state so they can be retried later.
+ type endpointManager struct {
+ 	// Config.
+-	ipVersion              uint8
+-	wlIfacesRegexp         *regexp.Regexp
+-	kubeIPVSSupportEnabled bool
++	ipVersion                 uint8
++	wlIfacesRegexp            *regexp.Regexp
++	kubeIPVSSupportEnabled    bool
++	ifaceConfigurationEnabled bool
+
+ 	// Our dependencies.
+ 	rawTable     iptablesTable","tiniest of nits: why would you abbreviate ""interface"" but not ""configuration"" ?",struct field wlIfacesRegexp should be wlIfacesRegexp
+8383,"@@ -19,9 +19,6 @@ namespace Samples.HttpMessageHandler
+
+         private static string Url;
+
+-#if NETFRAMEWORK
+-        [LoaderOptimization(LoaderOptimization.MultiDomainHost)]
+-#endif
+         public static void Main(string[] args)
+         {
+             bool tracingDisabled = args.Any(arg => arg.Equals(""TracingDisabled"", StringComparison.OrdinalIgnoreCase));",Removing since all of the domain-neutral testing will be done in the new `Samples.MultiDomainHost.Runner` app,I think you can just remove this whole method now.
+8384,"@@ -50,6 +50,8 @@ def getpcmd(pid):
+                 spid, scmd = line.strip().split(' ', 1)
+                 if int(spid) == int(pid):
+                     return scmd
++    # Fallback instead of None, for e.g. Cygwin where -o is an ""unknown option"" for the ps command:
++    return '[PROCESS_WITH_PID={}]'.format(pid)
+
+
+ def get_info(pid_dir, my_pid=None):",is there a better way to detect this rather than just always assuming it's cygwin if everything else fails? i think you can check `if sys.platform == 'cygwin'`,"This is the only one that worries me. I agree that returning `None` is the right thing to do, but I'm not sure it is the right thing to do, and I don't think that it matters much either way."
+8385,"@@ -410,6 +410,10 @@ def _build_internal(package, path, dry_run, env):
+             try:
+                 _clone_git_repo(url, branch, tmpdir)
+                 build_from_path(package, tmpdir, dry_run=dry_run, env=env)
++            except yaml.scanner.ScannerError as ex:
++                message_parts = str(ex).split('\n')
++                message_parts.insert(0, ""Syntax error while reading {!r}"".format(path))
++                raise CommandException('\n  '.join(message_parts))
+             except Exception as exc:
+                 msg = ""attempting git clone raised exception: {exc}""
+                 raise CommandException(msg.format(exc=exc))",duplicate code - can you move into build_from_path() ?,This is going to fail if there are two spaces between the colon and the error message.
+8386,"@@ -9,3 +9,6 @@ def toto(): #pylint: disable=C0102,R1711
+ # +1: [missing-function-docstring]
+ def test_enabled_by_id_msg(): #pylint: enable=C0111
+     pass
++
++def baz(): #pylint: disable=blacklisted-name
++    return 1",  very important test as we want to make sure the old name still work.,The `blacklisted-name` rule can probably be removed.
+8387,"@@ -1191,5 +1191,5 @@ This code is executed if a gain focus event is received by this object.
+ 		Fetches the number of descendants currently selected.
+ 		For performance, this method will only count up to the given maxCount number, and if there is one more above that, then sys.maxint is returned stating that many items are selected.
+ 		""""""
+-		return 0
++		return 1
+ ",I think returning 1 should some how be moved in to specific support for LibreOffice..,Why did you choose to return 1 here instead of 0?
+8388,"@@ -85,6 +85,8 @@ byte *app_sysenter_instr_addr = NULL;
+ static bool sysenter_hook_failed = false;
+ #endif
+
++bool d_r_avx512_code_in_use = false;
++
+ /* static functions forward references */
+ static byte *
+ emit_ibl_routines(dcontext_t *dcontext, generated_code_t *code, byte *pc,",Should be inside `ifdef X86` I would think (or moved to ... I guess arch/x86/emit_utils.c),(style) do not initialise statics to false
+8389,"@@ -10,12 +10,14 @@ import (
+
+ // LocationCache cache the map of node, pod, configmap, secret
+ type LocationCache struct {
+-	//edgeNodes is a list of valid edge nodes
+-	edgeNodes []string
++	// EdgeNodes is a list of valid edge nodes
++	EdgeNodes []string
+ 	// configMapNode is a map, key is namespace/configMapName, value is nodeName
+ 	configMapNode sync.Map
+ 	// secretNode is a map, key is namespace/secretName, value is nodeName
+ 	secretNode sync.Map
++	// Services is an array of services
++	Services []v1.Service
+ }
+
+ // PodConfigMapsAndSecrets return configmaps and secrets used by pod","Using sync.Map(key: nodename; value: state) instead of this ""EdgeNodes"" string slice here would be much better. Reasons: 1. Using sync.Map makes the time complexity of function UpdateEdgeNode and IsEdgeNode O(1), while using string slice with for loop makes it O(n). 2. Later we could be checking node state whether it's ""ready"" or still ""not ready"" by directly comparing ""value"" of sync.Map and doing the node state updating.",don't we have a list of services?
+8390,"@@ -20,6 +20,10 @@ namespace AutoRest.Go
+
+     public const string ReadOnlyConstraint = ""ReadOnly"";
+
++    private static readonly Regex IsApiVersionPattern = new Regex(@""^api[^a-zA-Z0-9_]?version"", RegexOptions.IgnoreCase);
++
++    private static readonly Regex UnwrapAnchorTagsPattern = new Regex(""([^<>]*)<a\\s*.*\\shref\\s*=\\s*[\'\""]([^\'\""]*)[\'\""][^>]*>(.*)</a>"");
++
+     private static readonly Regex WordSplitPattern = new Regex(@""(\p{Lu}\p{Ll}+)"");
+
+     private static Dictionary<string, string> plural = new Dictionary<string, string>()","nit, does it make sense to get this variables outside the func where they are used?",Regex is case-insensitive. Please use `Reg
+8391,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-show-subscriptions.rb demonstrates how to list subscriptions to the Amazon Simple Notification Services (SNS) topic using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",to **an** Amazon... Simple Notification **Service** (singular),Style/PercentLiteralDelimiters: %q-literal
+8392,"@@ -297,10 +297,13 @@ func TestOpenTopicFromURL(t *testing.T) {
+
+ 	ctx := context.Background()
+ 	for _, test := range tests {
+-		_, err := pubsub.OpenTopic(ctx, test.URL)
++		top, err := pubsub.OpenTopic(ctx, test.URL)
+ 		if (err != nil) != test.WantErr {
+ 			t.Errorf(""%s: got error %v, want error %v"", test.URL, err, test.WantErr)
+ 		}
++		if top != nil {
++			top.Shutdown(ctx)
++		}
+ 	}
+ }
+ ","Nit: is ""top"" a short name we use frequently? Seems a bit mysterious, and saves only 2 chars.",Can you just do this in a `defer top.Shutdown(ctx)` right after the for loop? Then you can do `defer top.Shutdown(ctx)` at the end of the for loop.
+8393,"@@ -52,7 +52,9 @@ import (
+ // R represents row type in executions table, valid values are:
+ // R = {Shard = 1, Execution = 2, Transfer = 3, Timer = 4, Replication = 5}
+ const (
+-	cassandraProtoVersion = 4
++	// ProtoVersion is the protocol version used to communicate with Cassandra cluster
++	ProtoVersion = 4
++
+ 	defaultSessionTimeout = 10 * time.Second
+ 	// Special Namespaces related constants
+ 	emptyNamespaceID = ""10000000-0000-f000-f000-000000000000""",This name is really confusing. May be just remove this const completely and hardcode `4` where it is used?,How about making it public? And changing it in the doc?
+8394,"@@ -558,12 +558,6 @@ module RSpec::Core
+       context ""with single pattern"" do
+         before { config.pattern = ""**/*_foo.rb"" }
+
+-        it ""loads files following pattern"" do
+-          file = File.expand_path(File.dirname(__FILE__) + ""/resources/a_foo.rb"")
+-          assign_files_or_directories_to_run file
+-          expect(config.files_to_run).to include(file)
+-        end
+-
+         it ""loads files in directories following pattern"" do
+           dir = File.expand_path(File.dirname(__FILE__) + ""/resources"")
+           assign_files_or_directories_to_run dir",Why did you remove this spec?,This test was failing because `config.files_to_run` was not being assigned to `config.files_to_run` before.
+8395,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?,"VENDOR_COMMAND_PREFIX is now unused, I don't think it should be removed."
+8396,"@@ -33,6 +33,12 @@ class Config(object):
+                               datetime.datetime.now().strftime('%Y%m%d%H%M%S'))
+         self.identifier = None
+         self.force_no_cloudshell = bool(kwargs.get('no_cloudshell'))
++        self.project_id = kwargs.get('project_id') or None
++        if kwargs.get('composite_root_resources'):
++            tmpcrr = kwargs.get('composite_root_resources')
++            self.composite_root_resources = tmpcrr.split(',')
++        else:
++            self.composite_root_resources = []
+         self.service_account_key_file = kwargs.get('service_account_key_file')
+         self.vpc_host_project_id = kwargs.get('vpc_host_project_id')
+         self.vpc_host_network = kwargs.get('vpc_host_network') or 'default'",".get will return None if there is no project_id key, so the or None part is redundant",tmpcrr -> temporary_composite_root_resources
+8397,"@@ -22,11 +22,16 @@ namespace OpenTelemetry.Metrics
+ {
+     public struct MetricPoint
+     {
++        internal DateTimeOffset StartTime;
++        internal DateTimeOffset EndTime;
++
+         private readonly AggregationType aggType;
+         private readonly HistogramBuckets histogramBuckets;
+         private long longVal;
++        private long longValue;
+         private long lastLongSum;
+         private double doubleVal;
++        private double doubleValue;
+         private double lastDoubleSum;
+
+         internal MetricPoint(",Do they need to be `internal`?,These two fields need to be readonly since t
+8398,"@@ -176,7 +176,7 @@ func (b *PinnedMap) Iter(f MapIter) error {
+ 	args := cmd[1:]
+
+ 	printCommand(prog, args...)
+-	output, err := exec.Command(prog, args...).CombinedOutput()
++	output, err := exec.Command(prog, args...).Output()
+ 	if err != nil {
+ 		return errors.Errorf(""failed to dump in map (%s): %s\n%s"", b.versionedFilename(), err, output)
+ 	}","Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`","unrelated to this PR, but should we just rem"
+8399,"@@ -175,8 +175,8 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
+   {""cuMemcpy"",                                             {""hipMemcpy_"",                                              """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy2D due to different signatures
+-  {""cuMemcpy2D"",                                           {""hipMemcpy2D_"",                                            """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+-  {""cuMemcpy2D_v2"",                                        {""hipMemcpy2D_"",                                            """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemcpy2D"",                                           {""hipMemcpyParam2D"",                                        """", CONV_MEMORY, API_DRIVER}},
++  {""cuMemcpy2D_v2"",                                        {""hipMemcpyParam2D"",                                        """", CONV_MEMORY, API_DRIVER}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy2DAsync due to different signatures
+   {""cuMemcpy2DAsync"",                                      {""hipMemcpy2DAsync_"",                                       """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},",Is there any official CUDA API called cuMemcpy2D_v2?,would be nice to have a test case for this
+8400,"@@ -0,0 +1,7 @@
++package azkaban.imagemgmt.utils;
++
++public interface ImageMgmtConstants {
++  public static final String IMAGE_TYPE = ""imageType"";
++  public static final String IMAGE_VERSION = ""imageVersion"";
++
++}",Can you please move this interface as class in common Constants file in az-core module?,"This is not used anywhere, is it?"
+8401,"@@ -43,12 +43,15 @@ TEST(ProcessUtils, isPidAvailable) {
+     }
+     {
+         // pid file which contains pid of current process
+-        auto pidFile = ""/tmp/maybe-non-existing-dir/process_test.pid"";
++        auto pidFile = folly::stringPrintf(""/tmp/non-existing-dir-%d/process_test.pid"", ::getpid());
++        SCOPE_EXIT {
++            ::unlink(pidFile.c_str());
++            ::rmdir(fs::FileUtils::dirname(pidFile.c_str()).c_str());
++        };
+         auto status = ProcessUtils::makePidFile(pidFile);
+         ASSERT_TRUE(status.ok()) << status;
+         status = ProcessUtils::isPidAvailable(pidFile);
+         ASSERT_FALSE(status.ok());
+-        ::unlink(pidFile);
+     }
+     {
+         // pid file not exist",Why not TempDir?,If the process fails to create th
+8402,"@@ -0,0 +1,16 @@
++using System;
++using MvvmCross.Binding.BindingContext;
++using MvvmCross.Core.ViewModels;
++using MvvmCross.Core.Views;
++
++namespace MvvmCross.Forms.Views
++{
++    public interface IMvxElement : IMvxView, IMvxBindingContextOwner
++    {
++    }
++
++    public interface IMvxElement<TViewModel>
++        : IMvxElement, IMvxView<TViewModel> where TViewModel : class, IMvxViewModel
++    {
++    }
++}","IMvxFormsView -> IMvxElement is a breaking change, isn't it?",@JeremyKuhne @mjkkirschner When T
+8403,"@@ -33,6 +33,7 @@ import yaml
+ from molecule import config
+ from molecule import state
+ from molecule import utilities
++from molecule import ansible_galaxy_install
+ from molecule.provisioners import baseprovisioner
+ from molecule.provisioners import dockerprovisioner
+ from molecule.provisioners import openstackprovisioner",This should be imported alphabetically.,Please add a blank line after thi
+8404,"@@ -11,7 +11,7 @@ use Shopsys\FrameworkBundle\Component\Grid\Ordering\OrderableEntityInterface;
+ use Shopsys\FrameworkBundle\Component\Money\Money;
+ use Shopsys\FrameworkBundle\Model\Localization\AbstractTranslatableEntity;
+ use Shopsys\FrameworkBundle\Model\Payment\Payment;
+-use Shopsys\FrameworkBundle\Model\Pricing\Currency\Currency;
++use Shopsys\FrameworkBundle\Model\Pricing\Price;
+ use Shopsys\FrameworkBundle\Model\Transport\Exception\TransportDomainNotFoundException;
+
+ /**",Please apply same changes as for Payment,I would rename it to `Pricing\Price\Price` everywhere.
+8405,"@@ -55,9 +55,13 @@ import { Cell, Grid, Row } from '../material-components';
+ import PageHeader from './PageHeader';
+ import Layout from './layout/Layout';
+ import { CORE_WIDGETS } from '../googlesitekit/widgets/datastore/constants';
++import { useHasScrolledEffect } from '../hooks/useHasScrolledEffect';
++import ScrollEffect from './ScrollEffect';
+ const { useSelect } = Data;
+
+ function DashboardEntityApp() {
++	useHasScrolledEffect();
++
+ 	const currentEntityURL = useSelect( ( select ) =>
+ 		select( CORE_SITE ).getCurrentEntityURL()
+ 	);","This should only be used in the `ScrollEffect` component, as you have in the `DashboardMainApp` below  ",Please alphabetize these.
+8406,"@@ -269,6 +269,8 @@ def api(require_login=True, schema=None, enabled=True,
+                               is_admin=user.is_admin,
+                               is_active=user.is_active)
+
++                g.token_str = token
++
+                 if not g.auth.is_active:
+                     raise ApiException(
+                         requests.codes.forbidden,","I'd call it `g.auth_token`, just to make it more clear",Why do we need this change?
+8407,"@@ -2,6 +2,9 @@ package protocol
+
+ import ""time""
+
++// DesiredReceiveBufferSize is the kernel UDP receive buffer size that we'd like to use.
++const DesiredReceiveBufferSize = (1 << 20) * 2 // 2 MB
++
+ // MaxPacketSizeIPv4 is the maximum packet size that we use for sending IPv4 packets.
+ const MaxPacketSizeIPv4 = 1252
+ ","Not sure if this is what we really need, we might need to adjust this constant after more extensive benchmarking.",Why do we need to hardcode this?
+8408,"@@ -183,7 +183,10 @@ func RegisterRoutes(m *macaron.Macaron) {
+ 				m.Patch(""/hooks/:id:int"", bind(api.EditHookOption{}), repo.EditHook)
+ 				m.Get(""/raw/*"", middleware.RepoRef(), repo.GetRawFile)
+ 				m.Get(""/archive/*"", repo.GetArchive)
+-
++				m.Group(""/branches"", func() {
++					m.Get("""",repo.ListBranches)
++					m.Get(""/:id"",repo.GetBranch)
++				})
+ 				m.Group(""/keys"", func() {
+ 					m.Combo("""").Get(repo.ListDeployKeys).
+ 						Post(bind(api.CreateKeyOption{}), repo.CreateDeployKey)",Shouldn't we use `:branchname` here? Or just `:branch`?,why not group `/branches` too?
+8409,"@@ -930,7 +930,7 @@ class RandUUID(RandField):
+ # Automatic timestamp
+
+
+-class AutoTime(VolatileValue):
++class AutoTime(RandNum):
+     def __init__(self, base=None):
+         if base is None:
+             self.diff = 0",`AutoTime` is a number but calling `int()` would make it crash. Tested through the docs,`RandNum` is `VolatileValue` i
+8410,"@@ -333,7 +333,16 @@ namespace OpenTelemetry.Trace
+                         new EvictingQueue<KeyValuePair<string, object>>(this.tracerConfiguration.MaxNumberOfAttributes);
+                 }
+
+-                this.attributes.Add(new KeyValuePair<string, object>(key ?? string.Empty, sanitizedValue));
++                var attribute = this.attributes.FirstOrDefault(a => a.Key == (key ?? string.Empty));
++                var newAttribute = new KeyValuePair<string, object>(key ?? string.Empty, sanitizedValue);
++                if (attribute.Equals(default(KeyValuePair<string, object>)))
++                {
++                    this.attributes.Add(newAttribute);
++                }
++                else
++                {
++                    this.attributes.Replace(attribute, newAttribute);
++                }
+             }
+         }
+ ","@eddynaka Looks like the same block more or less 4 times, should we have a helper method? private void AddOrReplaceAttribute or something?","This is a bit odd, `a.Key == ("
+8411,"@@ -381,7 +381,8 @@ public class JettySolrRunner {
+         dispatchFilter = root.getServletHandler().newFilterHolder(Source.EMBEDDED);
+         dispatchFilter.setHeldClass(SolrDispatchFilter.class);
+         dispatchFilter.setInitParameter(""excludePatterns"", excludePatterns);
+-        root.addFilter(dispatchFilter, ""*"", EnumSet.of(DispatcherType.REQUEST));
++        // Map dispatchFilter in same path as in web.xml
++        root.addFilter(dispatchFilter, ""/*"", EnumSet.of(DispatcherType.REQUEST));
+
+         synchronized (JettySolrRunner.this) {
+           waitOnSolr = true;",Please do the same for the DebugFilter a few lines above.,The dispatchFilter in same pat
+8412,"@@ -0,0 +1,2 @@
++export * from './act';
++export * from './setupRerender';","Minor nit: Just inline both functions here. No need to make a file per function (that's a popular approach for some projects though, just not for us :) ).",Do we need this? Can't it just be exported?
+8413,"@@ -28,6 +28,18 @@ namespace Datadog.Trace.Configuration
+         {
+         }
+
++        /// <summary>
++        /// Initializes a new instance of the <see cref=""TracerSettings""/> class with default values,
++        /// or using the default sources. Calling <c>new TracerSettings(true)</c> is equivalent to
++        /// calling <c>TracerSettings.FromDefaultSources()</c>
++        /// </summary>
++        /// <param name=""useDefaultSources"">If <c>true</c>, creates a <see cref=""TracerSettings""/> populated from
++        /// the default sources such as environment variables etc. If <c>false</c>, uses the default values.</param>
++        public TracerSettings(bool useDefaultSources)
++            : this(useDefaultSources ? CreateDefaultConfigurationSource() : null)
++        {
++        }
++
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""TracerSettings""/> class
+         /// using the specified <see cref=""IConfigurationSource""/> to initialize values.","There are several uses of the word ""default"" in here, perhaps it can be reworded slightly?","Can you make this `<see cref="" TracerSettin"
+8414,"@@ -50,7 +50,7 @@ class MediaType extends AbstractType
+             'new_on_update' => $options['new_on_update'],
+         )));
+
+-        $builder->addEventListener(FormEvents::BIND, function (FormEvent $event) {
++        $builder->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) {
+             if ($event->getForm()->has('unlink') && $event->getForm()->get('unlink')->getData()) {
+                 $event->setData(null);
+             }",`function (` is correct. A space must be there. Please run `make cs` to have correct coding style.,Why did you change this?
+8415,"@@ -18,7 +18,7 @@ function pageNoDuplicateEvaluate(node, options, virtualNode) {
+   cache.set(key, true);
+
+   let elms = querySelectorAllFilter(axe._tree[0], options.selector, elm =>
+-    isVisible(elm.actualNode)
++    isVisible(elm.actualNode, true)
+   );
+
+   // Filter elements that, within certain contexts, don't map their role.","I think this is now going to fail the scenario where there is a `main` with aria-hidden=""true"". I don't think that should fail.",Doesn't this mean that elements that are no
+8416,"@@ -83,7 +83,7 @@ func NewSublist() *Sublist {
+ // Insert adds a subscription into the sublist
+ func (s *Sublist) Insert(sub *subscription) error {
+ 	// copy the subject since we hold this and this might be part of a large byte slice.
+-	subject := string(append([]byte(nil), sub.subject...))
++	subject := string(sub.subject)
+ 	tsa := [32]string{}
+ 	tokens := tsa[:0]
+ 	start := 0","Is this specifically that if we capture the cast in another variable, even if it passes escape analysis, that the runtime will copy?",Why was this change made?
+8417,"@@ -108,6 +108,10 @@ type EKSConfig struct {
+ 	// Fargate controls the configuration of the AWS IAM role for
+ 	// used by EKS managed machine pools.
+ 	Fargate *AWSIAMRoleSpec `json:""fargate,omitempty""`
++	// KMSAliasPrefix is prefix to use to restrict permission to KMS keys to only those that have an alias
++	// name that is prefixed by this.
++	// Defaults to cluster-api-provider-aws-*
++	KMSAliasPrefix string `json:""kmsAliasPrefix,omitempty""`
+ }
+
+ // EventBridgeConfig represents configuration for enabling experimental feature to consume",Should this be optional for existing configs to work?,Should this be `aws-kms`
+8418,"@@ -119,12 +119,14 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount uint64) er
+ 		}
+ 		return ErrUnknownBeneficary
+ 	}
+-	err = s.chequebook.Issue(ctx, beneficiary, big.NewInt(int64(amount)), func(signedCheque *chequebook.SignedCheque) error {
++	balance, err := s.chequebook.Issue(ctx, beneficiary, big.NewInt(int64(amount)), func(signedCheque *chequebook.SignedCheque) error {
+ 		return s.proto.EmitCheque(ctx, peer, signedCheque)
+ 	})
+ 	if err != nil {
+ 		return err
+ 	}
++
++	s.metrics.AvailableBalance.Set(float64(balance.Int64()))
+ 	s.metrics.TotalSent.Add(float64(amount))
+ 	return nil
+ }","note that `balance` does not necessarily fit into `int64`, especially with the new bzz token. so you might want to avoid the `int64` conversion step using `big.NewFloat(0).SetInt(balance).Float64()`.",why not use `s.metrics.Av
+8419,"@@ -96,7 +96,12 @@ int main(int argc, const char *argv[]) {
+       flatbuffers::IDLOptions::kPhp,
+       ""Generate PHP files for tables/structs"",
+       flatbuffers::GeneralMakeRule },
+-    };
++   { flatbuffers::GenerateJsonSchema, ""-S"", ""--jsonschema"", ""JsonSchema"", true,
++      nullptr,
++      flatbuffers::IDLOptions::kJsonSchema,
++      ""Generate Json schema"",
++      flatbuffers::GeneralMakeRule },
++  };
+
+   flatbuffers::FlatCompiler::InitParams params;
+   params.generators = generators;",lets leave out the `-S` ?,Is this the same thing as
+8420,"@@ -112,4 +112,9 @@ public class CommonRenderingUtil {
+   public static int toInt(String value) {
+     return Integer.valueOf(value);
+   }
++
++  /** Returns the lowercase version of the given text */
++  public static String lowercase(String value) {
++    return value.toLowerCase();
++  }
+ }",Is this method needed?,Do we need a null check on `value`?
+8421,"@@ -127,6 +127,7 @@ void PoolingLayer<Dtype>::Reshape(const vector<Blob<Dtype>*>& bottom,
+ template <typename Dtype>
+ void PoolingLayer<Dtype>::Forward_cpu(const vector<Blob<Dtype>*>& bottom,
+       const vector<Blob<Dtype>*>& top) {
++  PoolingParameter pool_param = this->layer_param_.pooling_param();
+   const Dtype* bottom_data = bottom[0]->cpu_data();
+   Dtype* top_data = top[0]->mutable_cpu_data();
+   const int top_count = top[0]->count();","How about, instead of reading the param every time, just add a class member variable to hold the value of the flag, and just set it once during `LayerSetUp`?",Can't you move this declaration up
+8422,"@@ -99,7 +99,7 @@ func (e *ECS) Service(clusterName, serviceName string) (*Service, error) {
+ 	return nil, fmt.Errorf(""cannot find service %s"", serviceName)
+ }
+
+-// ServiceTasks calls ECS API and returns ECS tasks running by a service.
++// ServiceTasks calls ECS API and returns ECS tasks desired to be running by a service.
+ func (e *ECS) ServiceTasks(cluster, service string) ([]*Task, error) {
+ 	return e.listTasks(cluster, withService(service))
+ }",Does this mean it's only returning tasks associated with the primary deployment? or something else,Perhaps we should call this `Servic
+8423,"@@ -1101,6 +1101,11 @@ func TestRequestNoConnection(t *testing.T) {
+ 		t.Fatal(""expect error, but got none"")
+ 	}
+
++	t.Log(err)
++	awsError := err.(awserr.Error)
++	origError := awsError.OrigErr()
++	t.Logf(""Orig Error: %#v of type %T"", origError, origError)
++
+ 	if e, a := 10, r.RetryCount; e != a {
+ 		t.Errorf(""expect %v retry count, got %v"", e, a)
+ 	}","nit, would be good to include prefix for this log statement.",We should also check that the error
+8424,"@@ -57,4 +57,12 @@ describe('aria-required-attr', function () {
+ 		axe.commons.aria.requiredAttr = orig;
+ 	});
+
++	describe('options', function () {
++		it('should require provided attribute names', function () {
++			fixture.innerHTML = '<div role=""slider"" id=""target""></div>';
++			var target = fixture.children[0];
++			assert.isFalse(checks['aria-required-attr'].evaluate.call(checkContext, target, ['aria-valuemax', 'aria-bats']));
++			assert.deepEqual(checkContext._data, ['aria-valuenow', 'aria-valuemax', 'aria-valuemin', 'aria-bats']);
++		});
++	});
+ });","Same here, you should use a made up role. May I suggest `role=""McCheddarton""`? :)","You can use `expect(checkContext._data).to.have.keys('aria-valuemax', 'aria-valuemin', 'aria-valuenow')` instead :)"
+8425,"@@ -372,7 +372,9 @@ class SparkWrite {
+       }
+
+       Expression conflictDetectionFilter = conflictDetectionFilter();
+-      overwriteFiles.validateNoConflictingAppends(conflictDetectionFilter);
++      overwriteFiles.conflictDetectionFilter(conflictDetectionFilter);
++      overwriteFiles.validateNoConflictingData();
++      overwriteFiles.validateNoConflictingDeletes();
+
+       String commitMsg = String.format(
+           ""overwrite of %d data files with %d new data files, scanSnapshotId: %d, conflictDetectionFilter: %s"",","@aokolnychyi, shouldn't this check whether the operation is a delete? If this is invoked by `DELETE FROM` then we don't need to validate conflicting deletes.","I don't think we should change the existing callers of this method, as this is a breaking change. I don't think we "
+8426,"@@ -11,8 +11,9 @@ import (
+ 	""reflect""
+ 	""sync""
+
+-	""github.com/keybase/kbfs/kbfscodec""
+ 	""golang.org/x/net/context""
++
++	""github.com/keybase/kbfs/kbfscodec""
+ )
+
+ const (","Any reason to split up this import block? I think most files have them together in one block, right?",did you mean to delete this line?
+8427,"@@ -109,6 +109,18 @@ namespace Datadog.Trace.AppSec
+
+         internal SecuritySettings Settings => _settings;
+
++        private static void TagSpan(Span span)
++        {
++            // we should only tag service entry span, the first span opened for a
++            // service. For WAF it's safe to assume we always have service entry spans
++            // we'll need to revisit this for RASP.
++            if (span != null)
++            {
++                span.SetMetric(Tags.AppSecEnabled, 1.0);
++                span.SetTag(Tags.RuntimeFamily, TracerConstants.Language);
++            }
++        }
++
+         /// <summary>
+         /// Frees resouces
+         /// </summary>",`Tags.AppSecEnabled` should probably move to `Metrics.AppSecEnabled` I guess?,Can you set this to `null` as well?
+8428,"@@ -35,6 +35,9 @@ class atomic_file(AtomicLocalFile):
+     Also cleans up the temp file if close is not invoked
+     """"""
+
++    def __init__(self, path, mode):
++        super(AtomicLocalFile, self).__init__(path, mode)
++
+     def move_to_final_destination(self):
+         os.rename(self.tmp_path, self.path)
+ ","What happens if you remove this? Can't you still initialize this atomic_file class, since it's just AtomicLocalFile with an additional method (move_to_final_destination)?","`self.path = os.path.join(self.path, ...)`"
+8429,"@@ -34,7 +34,6 @@
+     <h2><div class='icon partners'></div><%= t "".partners_title"" %></h2>
+     <p><%= t 'layouts.partners_html',
+              :ucl => link_to(t('layouts.partners_ucl'), ""https://www.ucl.ac.uk""),
+-             :ic => link_to(t('layouts.partners_ic'), ""https://www.imperial.ac.uk/""),
+              :bytemark => link_to(t('layouts.partners_bytemark'), ""https://www.bytemark.co.uk""),
+              :partners => link_to(t('layouts.partners_partners'), ""https://hardware.openstreetmap.org/thanks/"") %>
+     </p>",As previously discussed in #1944 it's not safe to remove IC like this as it will break every language that still has a `%{ic}` marker in the translation.,Shouldn't this also be changed to `imperia
+8430,"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+
++	rules = append(rules, Rule{
++		Match: Match().ProtocolNum(ProtoUDP).
++			DestPorts(uint16(r.Config.VXLANPort)).
++			VXLANVNI(uint32(r.Config.VXLANVNI)),
++		Action:  DropAction{},
++		Comment: ""Drop VXLAN encapped packets originating in pods"",
++	})
++	rules = append(rules, Rule{
++		Match:   Match().ProtocolNum(ProtoIPIP),
++		Action:  DropAction{},
++		Comment: ""Drop IPinIP encapped packets originating in pods"",
++	})
++
+ 	if len(policyNames) > 0 {
+ 		// Clear the ""pass"" mark.  If a policy sets that mark, we'll skip the rest of the policies and
+ 		// continue processing the profiles, if there are any.","I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?",Since most of these rules are going to be
+8431,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,Does this need to be added to the dashboar
+8432,"@@ -79,7 +79,7 @@ module Faker
+         digits = Faker::Number.leading_zero_number(9) until digits&.match(/(\d)((?!\1)\d)+/)
+         first_digit = brazilian_citizen_number_checksum_digit(digits)
+         second_digit = brazilian_citizen_number_checksum_digit(digits + first_digit)
+-        [digits, first_digit, second_digit].join
++        ""#{digits.gsub(/(\d{3})(?=\d)/, '\1.')}-#{first_digit}#{second_digit}""
+       end
+
+       private",What about adding an optional parameter that allows users to choose whether they want to use the format or not?,"This regex doesn't seem to match what you're passing to `gsub` here. Also, you don't need to escape double dashes."
+8433,"@@ -35,8 +35,8 @@ func TestChainHead(t *testing.T) {
+
+ func TestChainLs(t *testing.T) {
+ 	tf.IntegrationTest(t)
+-	ctx := context.Background()
+ 	t.Skip(""DRAGONS: fake post for integration test"")
++	ctx := context.Background()
+
+ 	t.Run(""chain ls with json encoding returns the whole chain as json"", func(t *testing.T) {
+ 		builder := test.NewNodeBuilder(t)",Lint didn't like this context being before the skip,why was this removed?
+8434,"@@ -0,0 +1,18 @@
++package tequilapi
++
++import ""net/http""
++
++type corsHandler struct {
++	originalHandler http.Handler
++}
++
++func (wrapper corsHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
++	resp.Header().Set(""Access-Control-Allow-Origin"", ""*"")
++	resp.Header().Set(""Access-Control-Allow-Methods"", ""POST, GET, OPTIONS, PUT, DELETE"")
++	wrapper.originalHandler.ServeHTTP(resp, req)
++}
++
++//ApplyCors wraps original handler by adding cors headers to response BEFORE original ServeHTTP method is called
++func ApplyCors(original http.Handler) http.Handler {
++	return corsHandler{original}
++}",so now basically anybody could drink my tequila? currently electron dev-env runs on `http://localhost:9080`,Wouldn't it be better to use `http.DefaultHandler` for this?
+8435,"@@ -259,7 +259,7 @@ bool Plugin::loadLib(ILXQtPanelPluginLibrary const * pluginLib)
+     mPlugin = pluginLib->instance(startupInfo);
+     if (!mPlugin)
+     {
+-        qWarning() << QString(""Can't load plugin \""%1\"". Plugin can't build ILXQtPanelPlugin."").arg(mPluginLoader->fileName());
++        qWarning() << QString(""Can't load plugin \""%1\"". Plugin can't build ILXQtPanelPlugin."").arg(mDesktopFile.id());
+         return false;
+     }
+ ","`mPluginLoader` is nullptr in static plugins, which causes segmentation faults",Why not use the `fileName()` function of the `Plugin` class here?
+8436,"@@ -1,12 +1,8 @@
+ package org.phoenicis.javafx.views.mainwindow.ui;
+
+-import javafx.event.ActionEvent;
+-import javafx.event.EventHandler;
+-import org.phoenicis.javafx.views.common.ThemeManager;
+-
+ import javafx.beans.property.StringProperty;
+-import javafx.scene.control.TextField;
+ import javafx.scene.control.Button;
++import javafx.scene.control.TextField;
+ import javafx.scene.layout.AnchorPane;
+
+ import java.util.function.Consumer;",Better use `Optional<Consumer<String>> onSearch` here.,Why did you remove the event listener?
+8437,"@@ -16,7 +16,6 @@ BOOST_AUTO_TEST_CASE(rfc4648_test_vectors)
+ {
+     using namespace osrm::engine;
+
+-    BOOST_CHECK_EQUAL(encodeBase64(""""), """");
+     BOOST_CHECK_EQUAL(encodeBase64(""f""), ""Zg=="");
+     BOOST_CHECK_EQUAL(encodeBase64(""fo""), ""Zm8="");
+     BOOST_CHECK_EQUAL(encodeBase64(""foo""), ""Zm9v"");",this is asserted as invalid input,Why was this removed?
+8438,"@@ -10,12 +10,15 @@ import (
+ 	""time""
+
+ 	""github.com/thought-machine/please/src/core""
++	""github.com/thought-machine/please/src/parse""
+ )
+
+ // Print produces a Python call which would (hopefully) regenerate the same build rule if run.
+ // This is of course not ideal since they were almost certainly created as a java_library
+ // or some similar wrapper rule, but we've lost that information by now.
+-func Print(graph *core.BuildGraph, targets []core.BuildLabel, fields, labels []string) {
++func Print(state *core.BuildState, targets []core.BuildLabel, fields, labels []string) {
++	graph := state.Graph
++	order := parse.NewAspParser(state).BuildRuleArgOrder()
+ 	for _, target := range targets {
+ 		t := graph.TargetOrDie(target)
+ 		if len(labels) > 0 {",Why do you need to create a new parser? Can't you just use `state.Parser` to answer this question?,"Ah, this is what I was thinking about "
+8439,"@@ -155,5 +155,10 @@ namespace Nethermind.Core
+             HashNumberDiffAndTx,
+             Short
+         }
++
++        public virtual Block CreateBlockForProcessing(BlockHeader header) =>
++            new(header, Transactions, Ommers);
++
++        public virtual IEnumerable<Transaction> GetTransactions() => Transactions;
+     }
+ }","remove processing references from Nethermind.Core where possible, keep clean",Why do we have `GetTransactions` metho
+8440,"@@ -0,0 +1,7 @@
++package com.fsck.k9.mail.internet;
++
++public class UnsupportedContentTransferEncodingException extends Exception {
++    public UnsupportedContentTransferEncodingException(String encoding) {
++        super(""Unsupported encoding: ""+encoding);
++    }
++}",Why not make this a subclass of `MessagingException` so we don't need to change all `throws` clause?,Just a question about this: What is the use case for this new class?
+8441,"@@ -22,6 +22,8 @@ import qrcode
+ import traceback
+ from hashlib import sha256
+ from decimal import Decimal
++import binascii
++from .drbg.hmac_drbg import DRBG
+
+ from PyQt5.QtPrintSupport import QPrinter
+ ","it should instead be `from .hmac_drbg import DRBG` also, please put it at the bottom of the imports (PEP 8 order), so near line 36","The changes in this file aren't related to this PR, so I would leave"
+8442,"@@ -138,12 +138,13 @@ class SchemaUpdate implements UpdateSchema {
+       parentId = parentField.fieldId();
+       Preconditions.checkArgument(!deletes.contains(parentId),
+           ""Cannot add to a column that will be deleted: %s"", parent);
+-      Preconditions.checkArgument(schema.findField(parent + ""."" + name) == null,
+-          ""Cannot add column, name already exists: %s.%s"", parent, name);
++      Preconditions.checkArgument(schema.findField(parent + ""."" + name) == null ||
++                      deletes.contains(schema.findField(parent + ""."" + name).fieldId()),
++          ""Cannot add column, name already exists and is not being deleted: %s.%s"", parent, name);
+       fullName = schema.findColumnName(parentId) + ""."" + name;
+     } else {
+-      Preconditions.checkArgument(schema.findField(name) == null,
+-          ""Cannot add column, name already exists: %s"", name);
++      Preconditions.checkArgument(schema.findField(name) == null || deletes.contains(schema.findField(name).fieldId()),
++          ""Cannot add column, name already exists and is not being deleted: %s"", name);
+       fullName = name;
+     }
+ ",Nit: indentation is 2 indents (4 spaces) from the previous line.,`s/and is not being deleted/not being deleted/`
+8443,"@@ -224,7 +224,7 @@ func (c *Config) RenderComposeYAML() (string, error) {
+ 		// path.Join is desired over filepath.Join here,
+ 		// as we always want a unix-style path for the mount.
+ 		""docroot"":     path.Join(""../"", c.Docroot),
+-		""plugin"":      c.Platform,
++		""plugin"":      ""ddev"",
+ 		""appType"":     c.AppType,
+ 		""mailhogport"": appports.GetPort(""mailhog""),
+ 		""dbaport"":     appports.GetPort(""dba""),",I don't understand why this is changing to a hard-coded string.,Should we just default to ddev if it's not set?
+8444,"@@ -24,7 +24,7 @@ import (
+ // Devnet is a FAST lib environment that is meant to be used
+ // when working with kittyhawk devnets run by the Filecoin development team.
+ type Devnet struct {
+-	network  string
++	network  DevnetConfig
+ 	location string
+
+ 	log logging.EventLogger",nit: perhaps calling this `config` would be more clear?,why does this need to change?
+8445,"@@ -110,7 +110,7 @@ de_DE.strings = {
+     '1': '+%{smart_count} Dateien hochladen',
+     '2': '+%{smart_count} Dateien hochladen',
+   },
+-  uploading: 'Uploading',
++  uploading: 'Lade hoch',
+   uploadingXFiles: {
+     '0': '%{smart_count} Datei wird hochgeladen',
+     '1': '%{smart_count} Dateien werden hochgeladen',",I would rather recommend using 'Wird hochgeladen' since the imperative form of 'Lade hoch' confuses me whether this is an action I need to do or whether it's an action that Uppy is currently doing. Just my two cents.,What do you think about `Lade
+8446,"@@ -30,6 +30,8 @@ const (
+ 	defaultDataDir  = "".""
+ 	defaultLogLevel = ""INFO""
+ 	defaultUmask    = 0077
++
++	minimumUmask = 0027
+ )
+
+ // RunConfig represents the available configurables for file",Hmm I would have expected this to go away? What role does it play now that we have a minimum?,Can you make this `defaultUma
+8447,"@@ -3,12 +3,6 @@
+ const MongoNetworkError = require('./core').MongoNetworkError;
+ const mongoErrorContextSymbol = require('./core').mongoErrorContextSymbol;
+
+-const GET_MORE_NON_RESUMABLE_CODES = new Set([
+-  136, // CappedPositionLost
+-  237, // CursorKilled
+-  11601 // Interrupted
+-]);
+-
+ // From spec@https://github.com/mongodb/specifications/blob/f93d78191f3db2898a59013a7ed5650352ef6da8/source/change-streams/change-streams.rst#resumable-error
+ const GET_MORE_RESUMABLE_CODES = new Set([
+   6, // HostUnreachable","if we are removing this, is it useful to have the `isGetMoreError` message below? If that's not required, can we also remove the `mongoErrorContextSymbol` outright?",Is there a specific reason fo
+8448,"@@ -59,11 +59,7 @@ public:
+     void helper_block_for_at_least_entries(
+             uint32_t amount)
+     {
+-        std::unique_lock<std::mutex> lck(*xml_mutex_);
+-        mock_consumer->cv().wait(lck, [this, amount]
+-                {
+-                    return mock_consumer->ConsumedEntriesSize_nts() >= amount;
+-                });
++        mock_consumer->wait_for_at_least_entries(amount);
+     }
+
+     eprosima::fastdds::dds::MockConsumer* mock_consumer;",I think this mutex is only used here. Remove it.,Is it safe to remove the lock?
+8449,"@@ -181,7 +181,16 @@ public class IndexSearcher {
+   }
+
+   /** Runs searches for each segment separately, using the
+-   *  provided Executor. NOTE:
++   *  provided Executor. The passed in Executor will also be
++   *  used by LRUQueryCache (if enabled) to perform asynchronous
++   *  query caching.
++   *  If a task is rejected by the host Executor, the failed task
++   *  will then be executed on the caller thread. This is done to
++   *  ensure that a query succeeds, albeit with a higher latency.
++   *  If a user wishes to modify the said behaviour, they can either
++   *  handle the exception in the provided Executor, or override
++   *  the said method in a custom extension of IndexSearcher.
++   *  NOTE:
+    *  if you are using {@link NIOFSDirectory}, do not use
+    *  the shutdownNow method of ExecutorService as this uses
+    *  Thread.interrupt under-the-hood which can silently",it's unclear to me which method you are recommending overriding?,"add ""< p\>"" before ""If a user "
+8450,"@@ -511,7 +511,7 @@ class StringFormatChecker(BaseChecker):
+
+         check_args = False
+         # Consider ""{[0]} {[1]}"" as num_args.
+-        num_args += sum(1 for field in named_fields if field == """")
++        num_args += sum(1 for field in named_fields if not field)
+         if named_fields:
+             for field in named_fields:
+                 if field and field not in named_arguments:","This make me think that if the typing of a variable is inconsistent it could cause problem. For example here, if `field == 0`, the behavior is not exactly the same. A `0` and is implicitelty false. Well it works because summing 0 is neutral, but what if it was a multiplication ?",Could field be `None` here due
+8451,"@@ -4,12 +4,13 @@ import (
+ 	""bytes""
+ 	""errors""
+ 	""fmt""
+-	""github.com/libopenstorage/openstorage/api""
+-	""github.com/libopenstorage/openstorage/api/client""
+-	""github.com/libopenstorage/openstorage/volume""
+ 	""io""
+ 	""io/ioutil""
+ 	""strconv""
++
++	""github.com/libopenstorage/openstorage/api""
++	""github.com/libopenstorage/openstorage/api/client""
++	""github.com/libopenstorage/openstorage/volume""
+ )
+
+ const (",Remove this file from the PR,"usually, we don't have empty l"
+8452,"@@ -35,9 +35,9 @@ namespace Nethermind.Precompiles.Benchmark
+             // BenchmarkRunner.Run<Bn256MulBenchmark>();
+             // BenchmarkRunner.Run<Bn256PairingBenchmark>();
+             BenchmarkRunner.Run<ModExp2565Benchmark>();
+-            BenchmarkRunner.Run<ModExpBenchmark>();
++            // BenchmarkRunner.Run<ModExpBenchmark>();
+             Console.ReadLine();
+         }
+ #endif
+     }
+-}
++}",I cannot find the changes / results of the eip2565 benchmark,Please remove this file.
+8453,"@@ -151,7 +151,7 @@ const withData = (
+ 				'googlesitekit.moduleDataReset',
+ 				'googlesitekit.moduleDataResetHandler',
+ 				() => {
+-					this.setState( { data: false } );
++					this.setState( { data: false, zeroData: false } );
+ 				}
+ 			);
+ ","@tofumatt now that I see this in context, we're now resetting 2/3 of the keys in the `NewComponent` state - the other being `error`. It seems that `error` should probably also be reset - essentially resetting all of the component state when the date range changes. What do you think? cc: @felixarntz @adamsilverstein",The `zeroData` prop isn'
+8454,"@@ -32,7 +32,11 @@ namespace OpenTelemetry.Trace.Export
+
+         public override Task ShutdownAsync(CancellationToken cancellationToken)
+         {
++#if NET452
++            return Task.FromResult(0);
++#else
+             return Task.CompletedTask;
++#endif
+         }
+     }
+ }",This one and the ones below are for shutdowns but if it appears in some method called frequently during the lifetime of the process it should be cached in a static.,Shouldn't we just return
+8455,"@@ -5540,7 +5540,9 @@ describe('Model', function() {
+
+         return co(function*() {
+           const createdUser = yield User.create({ name: 'Hafez' });
+-          let threw = false;
++
++          let err;
++
+           try {
+             yield User.bulkWrite([{
+               updateOne: {","Better to just do `const err = yield User.bulkWrite(ops).then(() => null, err => err);` so you don't need to write out the whole `try/catch` block.",`user` is only used once
+8456,"@@ -453,7 +453,7 @@ func evmErrToErrStatusCode(evmErr error, g genesis.Blockchain, height uint64) (e
+ // intrinsicGas returns the intrinsic gas of an execution
+ func intrinsicGas(data []byte) (uint64, error) {
+ 	dataSize := uint64(len(data))
+-	if action.ExecutionDataGas == 0 || (math.MaxInt64-action.ExecutionBaseIntrinsicGas)/action.ExecutionDataGas < dataSize {
++	if (math.MaxInt64-action.ExecutionBaseIntrinsicGas)/action.ExecutionDataGas < dataSize {
+ 		return 0, action.ErrInsufficientFunds
+ 	}
+ ",`action.ExecutionDataGas = 100`,Why remove `== 0`?
+8457,"@@ -124,6 +124,9 @@ class GalleryControllerTest extends TestCase
+         $this->assertSame([$media], $gController->getGalleryMediasAction(1));
+     }
+
++    /**
++     * @group legacy
++     */
+     public function testPostGalleryMediaGalleryhasmediaAction()
+     {
+         $media = $this->createMock(MediaInterface::class);",@supersmile2009 please review. Is it right to mark this as legacy? Are we testing the legacy path here? Are there tests for the non-legacy path?,think this should
+8458,"@@ -112,11 +112,14 @@ func (c *Controller) getSpcResource(key string) (*apis.StoragePoolClaim, error)
+ 		// The SPC resource may no longer exist, in which case we stop
+ 		// processing.
+ 		if errors.IsNotFound(err) {
++
+ 			runtime.HandleError(fmt.Errorf(""spcGot '%s' in work queue no longer exists"", key))
+-			return nil, err
+ 		}
+-
+-		return nil, err
++		// No need to return error to caller as we still want to fire the delete handler
++		// using the spc key(name)
++		// If error is returned the caller function will return without calling the spcEventHandler
++		// function that invokes business logic for pool deletion
++		return nil,nil
+ 	}
+ 	return spcGot, nil
+ }",getSpcResource should not be bothered about deletion. Can we have `separation of concerns` for this logic?,Nit: space after `
+8459,"@@ -4596,11 +4596,11 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         >>> merged.sort_values(by=['lkey', 'value_x', 'rkey', 'value_y'])
+           lkey  value_x rkey  value_y
+         0  bar        2  bar        6
+-        1  baz        3  baz        7
+-        2  foo        1  foo        5
+-        3  foo        1  foo        8
+-        4  foo        5  foo        5
+-        5  foo        5  foo        8
++        5  baz        3  baz        7
++        1  foo        1  foo        5
++        2  foo        1  foo        8
++        3  foo        5  foo        5
++        4  foo        5  foo        8
+
+         >>> left_kdf = ks.DataFrame({'A': [1, 2]})
+         >>> right_kdf = ks.DataFrame({'B': ['x', 'y']}, index=[1, 2])",This is actually matched with pandas's result since the output is sorted.,This is unrelated
+8460,"@@ -37,12 +37,12 @@ var ConfigCmd = &cobra.Command{
+
+ // Config defines the config schema
+ type Config struct {
+-	Endpoint   string            `yaml:""endpoint""""`
+-	WalletList map[string]string `yaml:""walletList""`
++	Endpoint    string            `yaml:""endpoint""""`
++	AccountList map[string]string `yaml:""walletList""`
+ }
+
+ func init() {
+-	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl""
++	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl/default""
+ 	if err := os.MkdirAll(ConfigDir, 0700); err != nil {
+ 		fmt.Println(err.Error())
+ 		os.Exit(1)","struct field tag `yaml:""endpoint""""` not compatible with reflect.StructTag.Get: key:""value"" pairs not separated by spaces (from `govet`)","wondering if we should use path.Join here instead of joining paths with ""/""?"
+8461,"@@ -41,6 +41,8 @@ TopicImpl::TopicImpl(
+     , qos_(&qos == &TOPIC_QOS_DEFAULT ? participant_->get_default_topic_qos() : qos)
+     , listener_(listen)
+     , user_topic_(nullptr)
++    , handle_()
++    , num_refs_(0u)
+ {
+ }
+ ",This is not necessary. Topic inherits from DomainEntity which already has instance_handle_,"`num_refs_(0)` is a default value, so this doesn't need to be explicitly set"
+8462,"@@ -31,7 +31,7 @@ func TestICMPPortUnreachable(t *testing.T) {
+ 	_, ipv4, _, _, pktBytes, err := testPacketUDPDefault()
+ 	Expect(err).NotTo(HaveOccurred())
+
+-	runBpfUnitTest(t, ""icmp_port_unreachable.c"", func(bpfrun bpfProgRunFn) {
++	runBpfUnitTest(t, ""icmp_port_unreachable.c"", false, func(bpfrun bpfProgRunFn) {
+ 		res, err := bpfrun(pktBytes)
+ 		Expect(err).NotTo(HaveOccurred())
+ 		Expect(res.Retval).To(Equal(0))","Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes.",It would be better to use a constant for the name of the test.
+8463,"@@ -68,8 +68,8 @@ func (c *cstorSnapshotCommand) validateOptions() error {
+ 	return nil
+ }
+
+-// getSnapshotObj returns a filled object of CASSnapshot
+-func (c *cstorSnapshotCommand) getSnapshotObj() *apis.CASSnapshot {
++// casSnapshot returns a filled object of CASSnapshot
++func (c *cstorSnapshotCommand) casSnapshot() *apis.CASSnapshot {
+ 	volName, _ := c.Data[""volname""].(string)
+ 	snapName, _ := c.Data[""snapname""].(string)
+ 	return &apis.CASSnapshot{",All the code that reference to this function must also be changed.,Is this the same as `getSnapshotObj`?
+8464,"@@ -49,4 +49,12 @@ public interface UserManager {
+   public Role getRole(String roleName);
+
+   public boolean validateProxyUser(String proxyUser, User realUser);
++
++  /**
++   * @param username e.g. user alias
++   * @param groupName e.g. name of hadoop headless group / LDAP group
++   * @return Returns true if the user belongs to a group. This is used when verifying user
++   * permission by checking its group membership
++   */
++  public boolean validateUserGroupMembership(String username, String groupName);
+ }",How is this new interface different from existing `validateProxyUser` method? If I understand correctly the `proxyUser` parameter is essentially a group and the method should verify if `realUser` belongs to it.,description should be updated to say that it is used when verifying user permission by checking its group membership
+8465,"@@ -38,6 +38,7 @@ using Nethermind.Store;
+ using Nethermind.Store.Bloom;
+ using Nethermind.TxPool;
+ using NUnit.Framework;
++using BlockTree = Nethermind.Blockchain.BlockTree;
+
+ namespace Nethermind.JsonRpc.Test.Modules.Trace
+ {",Do we have namespace conflicts?,Why do we need this?
+8466,"@@ -224,7 +224,7 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error {
+ 		if s.useFakeResponse {
+ 			service = api.NewFakeWebAPI()
+ 		} else {
+-			service = api.NewWebAPI(ds, sls, alss, cmds, cfg.ProjectMap(), encryptDecrypter, t.Logger)
++			service = api.NewWebAPI(ctx, ds, sls, alss, cmds, cfg.ProjectMap(), encryptDecrypter, cfg.Cache.TTLDuration(), t.Logger)
+ 		}
+ 		opts := []rpc.Option{
+ 			rpc.WithPort(s.webAPIPort),","We have several groups of caches so I think we should not use this shared configuration value for all of them. Instead of that, each cache group should have a separate configuration field, and the added `validation cache` should have its own field too. But this point, they can be fixed by `24h`.",What is the purpose of this change?
+8467,"@@ -26,12 +26,12 @@ class Replicate implements AdapterInterface, MetadataSupporter
+     /**
+      * @var AdapterInterface
+      */
+-    protected $master;
++    protected $primary;
+
+     /**
+      * @var AdapterInterface
+      */
+-    protected $slave;
++    protected $secondary;
+
+     /**
+      * @var LoggerInterface","This is a BC break for extending classes, it can't be done on 3.x",I think this should be `secondary` rather than `primary`. Another alternative would be to use the `primary` plural i
+8468,"@@ -950,10 +950,13 @@ class Key(object):
+             if isinstance(md5, bytes):
+                 md5 = md5.decode('utf-8')
+
+-            if self.etag != '""%s""' % md5:
+-                raise provider.storage_data_error(
+-                    'ETag from S3 did not match computed MD5. '
+-                    '%s vs. %s' % (self.etag, self.md5))
++            # If you use customer-provided encryption keys, the ETag value that Amazon S3 returns in the response will not be the MD5 of the object.
++            server_side_encryption_customer_algorithm = response.getheader('x-amz-server-side-encryption-customer-algorithm', None)
++            if server_side_encryption_customer_algorithm is None:
++                if self.etag != '""%s""' % md5:
++                    raise provider.storage_data_error(
++                        'ETag from S3 did not match computed MD5. '
++                        '%s vs. %s' % (self.etag, self.md5))
+
+             return True
+ ","Line length (PEP8, should be 80 chars max)",I think this should be called `_server_side_encryption_algorithm` (or something similar) instead of `server_side_encryption_customer_algorithm` :)
+8469,"@@ -42,6 +42,8 @@ public abstract class MessageBuilder {
+     private final Context context;
+     private final MessageIdGenerator messageIdGenerator;
+     private final BoundaryGenerator boundaryGenerator;
++    private static final String highPriorityTag = ""X-Priority"";
++    private static final String xPriorityContent =""priority_high"";
+
+
+     private String subject;","this is duplicate now. I suggest moving it into `MimeHeader`, we already have a bunch of other headers there",`highPriority` and `xPriority` seem to do the same thing. Would it be better to have a single one?
+8470,"@@ -551,11 +551,15 @@ func checkPassword(password string) (string, error) {
+ 	if !utf8.ValidString(password) {
+ 		return """", errors.New(""password contains invalid utf8 characters"")
+ 	}
+-	// Remove leading+trailing whitespace
+-	password = strings.TrimSpace(password)
++	// Check for leading/trailing whitespace
++	trimmedPassword := strings.TrimSpace(password)
++	// Warn user if password has leading+trailing whitespace
++	if len(password) != len(trimmedPassword) {
++		fmt.Fprintln(os.Stderr, ""Your password contains leading/trailing whitespace - in previous versions of rclone this was stripped"")
++	}
+ 	// Normalize to reduce weird variations.
+ 	password = norm.NFKC.String(password)
+-	if len(password) == 0 {
++	if len(password) == 0 || len(trimmedPassword) == 0 {
+ 		return """", errors.New(""no characters in password"")
+ 	}
+ 	return password, nil","Can you expand the warning slightly ""Your password contains leading/trailing whitespace - in previous versions of rclone this was stripped"" Just so users know they might have to type their password without a leading space.",Can we just check for `len(trimmedPassword) > 0`?
+8471,"@@ -596,7 +596,7 @@ namespace pwiz.Skyline
+                             var message = TextUtil.SpaceSeparate(
+                                 Resources.SkylineWindow_FindIrtDatabase_The_database_file_specified_could_not_be_opened,
+                                 e.Message);
+-                            MessageBox.Show(message);
++                            MessageDlg.Show(this, message);
+                         }
+                     }
+                     else","I think ""this"" should be ""parent"".",Why do we have to invoke `Show` manually here and then call `Dlg.Show`?
+8472,"@@ -331,6 +331,8 @@ ostree_async_progress_set (OstreeAsyncProgress *self,
+   if (self->dead)
+     goto out;
+
++  changed = FALSE;
++
+   va_start (ap, self);
+
+   for (key = va_arg (ap, const char *), format_string = va_arg (ap, const char *);",Why not init this at variable decl time instead?,There should be a `goto out` above here to free the memory that was freed.
+8473,"@@ -25,6 +25,11 @@ const (
+ 	ProjectIDEnvKey = ""PROJECT_ID""
+ )
+
++// ProjectIDEnvConfig is a struct to parse Project id from env var
++type ProjectIDEnvConfig struct {
++	ProjectID string `envconfig:""PROJECT_ID""`
++}
++
+ // ProjectID returns the project ID for a particular resource.
+ func ProjectID(project string, client metadataClient.Client) (string, error) {
+ 	// If project is set, then return that one.",Do we still need this if we're doing everything through `envconfig`?,"Just curious, why is this defined as a struct instead of just being a poin"
+8474,"@@ -22,6 +22,8 @@ type OptionsNetwork struct {
+ 	Testnet  bool
+ 	Localnet bool
+
++	IdentityCheck bool
++
+ 	DiscoveryAPIAddress string
+ 	BrokerAddress       string
+ ",I would like these options to have `experiment` prefix or suffix. Because we will be deleting them later,why is this flag needed?
+8475,"@@ -88,7 +88,11 @@
+       <%= f.label :additional_info, 'Please include any additional information you feel we need to correctly execute the purchase' %>
+       <%= f.text_area :additional_info, class: 'form-control' %>
+     </div>
+-    <%= f.submit class: 'form-button' %>
++    <% unless ENV['DISABLE_SANDBOX_WARNING'] == 'true' %>
++      <%= f.submit value: 'Submit test request for approval', class: 'form-button' %>
++    <% else %>
++      <%= f.submit class: 'form-button' %>
++    <% end %>
+     <% if @model_instance.persisted? %>
+       <%= link_to 'Discard Changes', proposal_url(@model_instance.proposal) %>
+     <% end %>","Since we have the same logic in both forms, can we make a shared partial/helper for it?",Use a `unless` instead of an `if` here.
+8476,"@@ -69,10 +69,12 @@ func NewSalesman(opts ...Option) (*Salesman, error) {
+ 	if err := o.Validate(); err != nil {
+ 		return nil, err
+ 	}
++	marketAddr := blockchain.MarketAddr().Hex()
++	askPlansKey := marketAddr + ""/ask_plans""
+
+ 	s := &Salesman{
+ 		options:         o,
+-		askPlanStorage:  state.NewKeyedStorage(""ask_plans"", o.storage),
++		askPlanStorage:  state.NewKeyedStorage(askPlansKey, o.storage),
+ 		askPlanCGroups:  map[string]cgroups.CGroup{},
+ 		deals:           map[string]*sonm.Deal{},
+ 		orders:          map[string]*sonm.Order{},",Why to introduce this intermediate variable?,Please use the function you created here instead of hardcoding the address.
+8477,"@@ -43,6 +43,9 @@ class webhdfs(luigi.Config):
+                               description='Port for webhdfs')
+     user = luigi.Parameter(default='', description='Defaults to $USER envvar',
+                            config_path=dict(section='hdfs', name='user'))
++    client_type = luigi.Parameter(default='insecure',
++                                  description='Type of client to use. One of insecure, kerberos or token')
++    token = luigi.Parameter(default='', description='Hadoop delegation token, only used when client_type=""token""')
+
+
+ class WebHdfsClient(hdfs_abstract_client.HdfsFileSystem):",Maybe use ChoiceParameter?,"I would say this should default to None, as that's what kerberos is default"
+8478,"@@ -2,11 +2,12 @@ class ProposalsController < ApplicationController
+   include TokenAuth
+
+   before_filter :authenticate_user!, except: :approve
+-  before_filter ->{authorize self.proposal}, only: :show
++  before_filter ->{authorize self.proposal}, only: [:show, :cancel, :cancel_form]
+   before_filter :needs_token_on_get, only: :approve
+   before_filter :validate_access, only: :approve
+   helper_method :display_status
+   add_template_helper ProposalsHelper
++  rescue_from Pundit::NotAuthorizedError, with: :auth_errors
+
+   def show
+     @proposal = self.proposal.decorate","Not positive is this is needed, given the `TokenAuth` include",I don't think we need to include `cancel_form` here. It's not used by the v
+8479,"@@ -50,3 +50,13 @@ class ErrorDescriptionDict(TypedDict):
+ CheckerStats = Dict[
+     str, Union[int, ""Counter[str]"", List, Dict[str, Union[int, str, Dict[str, int]]]]
+ ]
++
++
++# Tuple with information about the location of a to-be-displayed message
++class MessageLocationTuple(NamedTuple):
++    abspath: str
++    path: str
++    module: str
++    obj: str
++    line: int
++    column: int",Why not use a docstring for it?,Would be nice to have location information in here as well. E.g. `message_l
+8480,"@@ -3672,4 +3672,17 @@ public class BesuCommandTest extends CommandTestAbstract {
+     assertThat(commandErrorOutput.toString())
+         .contains(""Invalid value for option"", ""--Xws-timeout-seconds"", ""abc"", ""is not a long"");
+   }
++
++  @Test
++  public void assertThatDuplicatePortSpecifiedFails() {
++    parseCommand(""--p2p-port=9"", ""--rpc-http-port=10"", ""--rpc-ws-port=10"");
++    assertThat(commandErrorOutput.toString())
++        .contains(""Port number '10' has been specified multiple times."");
++  }
++
++  @Test
++  public void assertThatDuplicatePortZeroSucceeds() {
++    parseCommand(""--p2p-port=0"", ""--rpc-http-port=0"", ""--rpc-ws-port=0"");
++    assertThat(commandErrorOutput.toString()).isEmpty();
++  }
+ }","Two more tests - no ports specified and every possible port specified - p2pPort, graphQLHttpPort, rpcHttpPort, rpcWsPort, metricsPort, metricsPushPort, stratumPort",Does it make sense to have a test that verifies that the --rpc-ws-port=0 has been specified multiple times?
+8481,"@@ -9,6 +9,7 @@
+ # Copyright (c) 2019-2020 Pierre Sassoulas <pierre.sassoulas@gmail.com>
+ # Copyright (c) 2019 Ashley Whetter <ashley@awhetter.co.uk>
+ # Copyright (c) 2019 Taewon D. Kim <kimt33@mcmaster.ca>
++# Copyright (c) 2020 Eli Fine <ejfine@gmail.com>
+
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ # For details: https://github.com/PyCQA/pylint/blob/master/COPYING","Don't worry about that next time, it's automated :)",Copyright date should not be changed from the original unless the file has been completely replaced
+8482,"@@ -172,6 +172,7 @@ def pytest_configure(config):
+     # pylint: disable=unused-variable
+     if config.webengine:
+         import PyQt5.QtWebEngineWidgets
++    # pylint: enable=unused-variable
+
+
+ @pytest.fixture(scope='session', autouse=True)","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.","@stephenroller this variable is unused, right?"
+8483,"@@ -103,10 +103,11 @@ const (
+ 	fluentTagDockerFirelensV2Format = ""%s.%s""
+
+ 	// Environment variables are needed for firelens
+-	fluentNetworkHost      = ""FLUENT_HOST""
+-	fluentNetworkPort      = ""FLUENT_PORT""
+-	FluentNetworkPortValue = ""24224""
+-	FluentAWSVPCHostValue  = ""127.0.0.1""
++	fluentNetworkHost        = ""FLUENT_HOST""
++	fluentNetworkPort        = ""FLUENT_PORT""
++	FluentNetworkPortValue   = ""24224""
++	AWSVPCHostValue          = ""127.0.0.1""
++	opentelemetryNetworkHost = ""OPEN_TELEMETRY_HOST""
+
+ 	defaultMonitorExecAgentsInterval = 15 * time.Minute
+ ",Are these values expected to change over time? Why not inject these values in ECS backend instead of agent doing it?,"Nit: I would prefer `opentelemetryNetworkHost = ""OPEN_TELEMETRY_HOST""`."
+8484,"@@ -31,6 +31,17 @@ func run(app *cli.Context, cfg *cmds.Server) error {
+ 		return err
+ 	}
+
++	nodeName := app.String(""node-name"")
++	if nodeName == """" {
++		h, err := os.Hostname()
++		if err != nil {
++			return err
++		}
++		nodeName = h
++	}
++
++	os.Setenv(""NODE_NAME"", nodeName)
++
+ 	var serverConfig server.Config
+ 	serverConfig.DisableAgent = true
+ 	serverConfig.ControlConfig.DataDir = dataDir","as best i can tell, you are setting this here in order to make it available in `(e *ETCD) Snapshot(ctx context.Context, config *config.Control) error`. It feels wrong to pass state like this through an env var. Could you instead add a `nodeName` property to the ETCD struct?","if we have to set the environment variable multiple times, can we make it a field of the server struct?"
+8485,"@@ -38,6 +38,8 @@ var skipTests = map[string]string{
+ 	""covariance_missing_column_2"": ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""drop_before_rename"":          ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""drop_referenced"":             ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
++	""drop_non_existent"":           ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
++	""keep_non_existent"":           ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""yield"":                       ""yield requires special test case (https://github.com/influxdata/flux/issues/535)"",
+ }
+ ","These seem to support the new test framework below, but the `.in.csv` files are still committed.",Do we need to also keep `drop_non_existent` and `keep_non_existent`?
+8486,"@@ -227,8 +227,11 @@ namespace Nethermind.Blockchain.Receipts
+
+             for (int i = 0; i < txReceipts.Length; i++)
+             {
+-                var txHash = block.Transactions[i].Hash;
+-                _transactionDb.Set(txHash, block.Hash.Bytes);
++                if (txReceipts[i].Removed == false)
++                {
++                    var txHash = block.Transactions[i].Hash;
++                    _transactionDb.Set(txHash, block.Hash.Bytes);
++                }
+             }
+
+             if (blockNumber < MigratedBlockNumber)","!txReceipts[i].Removed and We can check it for first item outside of for loop, we don't expect mixed batches","If we remove the tx from the database, this will lead to a leaked transaction. The transaction will be "
+8487,"@@ -40,7 +40,7 @@ const (
+ 	prodEnvFlag           = ""prod""
+ 	deployFlag            = ""deploy""
+ 	resourcesFlag         = ""resources""
+-	githubURLFlag         = ""github-url""
++	repoURLFlag           = ""url""
+ 	githubAccessTokenFlag = ""github-access-token""
+ 	gitBranchFlag         = ""git-branch""
+ 	envsFlag              = ""environments""","We can't unfortunately change any of our old flags :( it'd be a breaking change. Instead, we can keep both `githubURLFlag` and `repoURLFlag` and make the description of `githubURLFlagDescription` as ""(Deprecated) Use --url instead. GitHub respository URL for your service."" It would be even better if we can make `githubURLFlag` as hidden but keep in the command. This way old commands will still work with `--github-url` but it won't appear anymore in the help menu.","minor nit, but i think the variable name should be more clear, e.g. `repoURLFlag`"
+8488,"@@ -61,7 +61,10 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction
+
+       return result
+     end
++
+     # Could not find plan
+-    raise ArgumentError, ""Function #{self.class.name}(): Unknown plan: '#{plan_name}'""
++    raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
++      Puppet::Pops::Issues.issue(:UNKNOWN_PLAN) { Bolt::Error.unknown_plan(plan_name) }
++    )
+   end
+ end",This provides file and line number if applicable.,This looks like the wrong error message.
+8489,"@@ -10,6 +10,7 @@ import math
+ from matplotlib import pyplot as plt
+ import os
+ import pandas as pd
++import numpy as np
+ import random
+ import re
+ import shutil",This is already imported. Please check the file.,numpy import should be before numpy.
+8490,"@@ -1676,6 +1676,11 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
+                 if (aSelection.isActionAvailable(action)) {
+                     aSelection.execute(action);
+                 }
++                if (GeckoSession.SelectionActionDelegate.ACTION_COPY.equals(action) &&
++                        aSelection.isActionAvailable(GeckoSession.SelectionActionDelegate.ACTION_UNSELECT)) {
++                    // Don't keep the text selected after it's copied.
++                    aSelection.execute(GeckoSession.SelectionActionDelegate.ACTION_UNSELECT);
++                }
+             }
+
+             @Override","One thing we can do in a follow up is use the shorthand calls, so You can just call `aSelection.unselect()` instead of calling the more verbose `execute()`. The fact that you have to check if the action is available sort of sucks though.",Why not just `aSelection.execute(action)
+8491,"@@ -519,10 +519,10 @@ func (st *ServerType) serversFromPairings(
+ 					for _, h := range hosts {
+ 						if h == defaultSNI {
+ 							hosts = append(hosts, """")
+-							cp.DefaultSNI = defaultSNI
+ 							break
+ 						}
+ 					}
++					cp.DefaultSNI = defaultSNI
+
+ 					// TODO: are matchers needed if every hostname of the resulting config is matched?
+ 					if len(hosts) > 0 {",I don't think adding this value to _every_ connection policy is needed or useful... why is this necessary?,Why is this change necessary?
+8492,"@@ -10,7 +10,11 @@ declare(strict_types=1);
+ namespace Ergonode\Product\Infrastructure\Provider\Strategy;
+
+ use Ergonode\Attribute\Domain\Entity\AbstractAttribute;
+-use Ergonode\Attribute\Infrastructure\Provider\AttributeValueConstraintStrategyInterface;
++use Ergonode\Attribute\Infrastructure\Provider\ContextAwareAttributeValueConstraintStrategyInterface;
++use Ergonode\EventSourcing\Infrastructure\Manager\EventStoreManagerInterface;
++use Ergonode\Product\Application\Validator\NotTheSameProduct;
++use Ergonode\Product\Domain\Entity\AbstractProduct;
++use Ergonode\SharedKernel\Domain\AggregateId;
+ use Symfony\Component\Validator\Constraint;
+ use Symfony\Component\Validator\Constraints\Collection;
+ use Ergonode\Product\Application\Validator\ProductExists;",adding this constrain for null AggreagateId is redundant,We don't use an alias `AggregateId` here.
+8493,"@@ -103,7 +103,12 @@ func Dashboard(ctx *middleware.Context) {
+ 	feeds := make([]*models.Action, 0, len(actions))
+ 	for _, act := range actions {
+ 		if act.IsPrivate {
+-			if has, _ := models.HasAccess(ctx.User, &models.Repository{Id: act.RepoId, IsPrivate: true}, models.ACCESS_MODE_READ); !has {
++			repo := &models.Repository{Id: act.RepoId, IsPrivate: true}
++			// This prevents having to retrieve the repository for each action
++			if act.RepoUserName == ctx.User.LowerName {
++				repo.OwnerId = ctx.User.Id
++			}
++			if has, _ := models.HasAccess(ctx.User, repo, models.ACCESS_MODE_READ); !has {
+ 				continue
+ 			}
+ 		}",Why when current user is owner but still check access? Should we use `else if` here?,Shouldn't this be `ctx.User.Name`?
+8494,"@@ -4,12 +4,18 @@ import (
+ 	""errors""
+ 	""fmt""
+ 	""strings""
++	""time""
+
+ 	docker ""github.com/fsouza/go-dockerclient""
+
+ 	. ""github.com/weaveworks/weave/common""
+ )
+
++const (
++	InitialInterval = 1 * time.Second
++	MaxInterval     = 60 * time.Second
++)
++
+ // An observer for container events
+ type ContainerObserver interface {
+ 	ContainerStarted(ident string)",60 seems high. 10? 20?,We should have these in docker/constants.
+8495,"@@ -755,8 +755,8 @@ def server_init_start(args):
+
+     # Create the main database link from the arguments passed over the
+     # command line.
+-    default_product_path = os.path.join(args.config_directory,
+-                                        'Default.sqlite')
++    cfg_dir = os.path.abspath(args.config_directory)
++    default_product_path = os.path.join(cfg_dir, 'Default.sqlite')
+     create_default_product = 'sqlite' in args and \
+                              not os.path.exists(default_product_path)
+ ",I think this is not the best way to handle this problem. This way every relative path will be converted to absolute path. What if the user would like to move his config directory to a different directory?,This line is an unrelated change. Please
+8496,"@@ -169,6 +169,10 @@ type NetworkSpec struct {
+ 	// Subnets configuration.
+ 	// +optional
+ 	Subnets Subnets `json:""subnets,omitempty""`
++
++	// ControlPlaneLoadBalancerScheme (defaults to Internet-facing)
++	// +optional
++	ControlPlaneLoadBalancerScheme ClassicELBScheme `json:""controlPlaneLoadBalancerScheme,omitempty""""`
+ }
+
+ // APIEndpoint represents a reachable Kubernetes API endpoint.",Let's make this a pointer given that's optional,why do we need to specify the default?
+8497,"@@ -4,6 +4,7 @@
+  * Module dependencies.
+  */
+
++var CircularJSON = require('circular-json');
+ var Stream = require('stream').Stream;
+ var utils = require('./utils');
+ var helpers = require('./queryhelpers');",Why is CircularJSON imported here? It is never used in this file.,Why do we need this?
+8498,"@@ -80,7 +80,11 @@ namespace AutoRest.Swagger
+             {
+                 // Look for semantic errors and warnings in the document.
+                 var validator = new RecursiveObjectValidator(PropertyNameResolver.JsonName);
+-                foreach (var validationEx in validator.GetValidationExceptions(ServiceDefinition.FilePath, ServiceDefinition))
++                foreach (var validationEx in validator.GetValidationExceptions(ServiceDefinition.FilePath, ServiceDefinition, new ServiceDefinitionMetadata
++                {   // LEGACY MODE! set defaults for the metadata, the validator doesn't care from this codepath
++                    OpenApiDocumentType = ServiceDefinitionDocumentType.Default,
++                    MergeState = ServiceDefinitionMergeState.After
++                }))
+                 {
+                     Logger.Instance.Log(validationEx);
+                 }",Should be ARM,why is this needed?
+8499,"@@ -86,10 +86,10 @@ func openBucket(dir string, _ *Options) (driver.Bucket, error) {
+ 	dir = filepath.Clean(dir)
+ 	info, err := os.Stat(dir)
+ 	if err != nil {
+-		return nil, fmt.Errorf(""open file bucket: %v"", err)
++		return nil, err
+ 	}
+ 	if !info.IsDir() {
+-		return nil, fmt.Errorf(""open file bucket: %s is not a directory"", dir)
++		return nil, fmt.Errorf(""%s is not a directory"", dir)
+ 	}
+ 	return &bucket{dir}, nil
+ }","I don't see how removing ""open file bucket"" helps your purpose.",We should include the dir in the error
+8500,"@@ -47,7 +47,7 @@ class SolrVersionStatus extends AbstractSolrStatus
+      *
+      * @var string
+      */
+-    const REQUIRED_SOLR_VERSION = '6.3.0';
++    const REQUIRED_SOLR_VERSION = '6.6.2';
+
+     /**
+      * Compiles a version check against each configured Solr server.",Solr dependency was downgraded?,I think this should be 6.6.1
+8501,"@@ -38,6 +38,7 @@ module C2
+     config.autoload_paths << Rails.root.join('app', 'mailers', 'concerns')
+     config.autoload_paths << Rails.root.join('app', 'policies', 'concerns')
+     config.autoload_paths << Rails.root.join('lib')
++    config.autoload_paths << Rails.root.join(""lib"", ""services"")
+
+     config.assets.precompile << 'communicarts_mailer.css'
+ ",or should we just autoload everything in `lib` ?,Prefer single-quoted strings
+8502,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,`caps` could be `null`
+8503,"@@ -533,6 +533,7 @@ CREATE_VIOLATIONS_TABLE = """"""
+         `violation_type` enum('UNSPECIFIED',
+                               'ADDED','REMOVED',
+                               'BIGQUERY_VIOLATION',
++                              'BLACKLIST_VIOLATION',
+                               'BUCKET_VIOLATION',
+                               'CLOUD_SQL_VIOLATION',
+                               'FIREWALL_BLACKLIST_VIOLATION',",create_tables isn't used in 2.0 (should probably be deleted?),Flake is complaining about t
+8504,"@@ -29,6 +29,7 @@ namespace OpenTelemetry.Exporter
+         internal Func<DateTimeOffset> GetUtcNowDateTimeOffset = () => DateTimeOffset.UtcNow;
+
+         private int scrapeResponseCacheDurationMilliseconds = 10 * 1000;
++        private IReadOnlyCollection<string> httpListenerPrefixes = new string[] { ""http://*:80/"" };
+
+ #if NETCOREAPP3_1_OR_GREATER
+         /// <summary>","Now I start to wonder, do we want to have `80` as the default or `9090` (or depending on whether we are exposing it via `PrometheusExporterMiddleware` vs. `PrometheusExporterHttpServer`)?",Any reason not to make this a `IReadOnlyCollection<string>`? We're still on the safe side here.
+8505,"@@ -980,7 +980,9 @@ TEST(Parser, UserOperation) {
+     {
+         GQLParser parser;
+         std::string query = ""CREATE USER IF NOT EXISTS user1 WITH PASSWORD \""aaa\"" , ""
+-                            ""FIRSTNAME \""a\"", LASTNAME \""a\"", EMAIL \""a\"", PHONE \""111\"""";
++                            ""ACCOUNT LOCK, MAX_QUERIES_PER_HOUR 1, ""
++                            ""MAX_UPDATES_PER_HOUR 2, MAX_CONNECTIONS_PER_HOUR 3, ""
++                            ""MAX_USER_CONNECTIONS 4"";
+         auto result = parser.parse(query);
+         ASSERT_TRUE(result.ok()) << result.status();
+         auto& sentence = result.value();",try an illegal case. and the result is syntax error.,"This should be MAX_QUERIES_PER_HOUR 1, MAX_UPDATES_PER_HOUR 2."
+8506,"@@ -23,6 +23,7 @@ void MemoryDataLayer<Dtype>::DataLayerSetUp(const vector<Blob<Dtype>*>& bottom,
+   added_label_.Reshape(batch_size_, 1, 1, 1);
+   data_ = NULL;
+   labels_ = NULL;
++  needs_reshape_ = false;
+   added_data_.cpu_data();
+   added_label_.cpu_data();
+ }",Initialize `needs_reshape_` with true and call `Reshape` method,Does this need to be `true`? Or `false` for `needs_reshape_`?
+8507,"@@ -936,7 +936,10 @@ EOM
+       # @private
+       RANDOM_ORDERING = lambda do |list|
+         Kernel.srand RSpec.configuration.seed
+-        ordering = list.sort_by { Kernel.rand(list.size) }
++        orders = list.map {|x| !(x.respond_to?(:order)) || x.order.nil? || x.order == :random ? Kernel.rand(list.size) : 1}
++        zipped = list.zip(orders)
++
++        ordering = zipped.sort_by { |x| x[1] }.map { |x| x.first }
+         Kernel.srand # reset random generation
+         ordering
+       end","This is a _very_ complicated line. I'm not a fan of ternaries to begin with (although, I allow them in very simple situations), but this ternary has compound conditionals and would really need to be broken up. That said: if I'm reading this right, it sounds like this logic can make it where this lambda (which is called `RANDOM_ORDERING`) can make it not random and basically do the opposite of what it says. In general, it's good to avoid making methods or lambdas do the opposite of what they say.",`list.map { |x| x[1] }.map { |x| x[1] }` is simpler.
+8508,"@@ -52,7 +52,8 @@ if (TYPO3_MODE == 'BE') {
+         '',
+         [
+             // An array holding the controller-action-combinations that are accessible
+-            'Administration' => 'index,setSite,setCore,noSiteAvailable'
++            'Administration' => 'index,setSite,setCore,noSiteAvailable',
++            'Backend\\Web\\Info\\ApacheSolrDocument' => 'index'
+         ],
+         [
+             'access' => 'admin',",We should remove this,@daniel-sassenhagen This is the backend-action-combinations that are accessible. The backend-action-combinations that are accessible by this controller-action-combinations should be converted to the backend-action-combinations that are accessible by this controller.
+8509,"@@ -205,6 +205,8 @@ type Config struct {
+ 	sourceToRawConfig map[Source]map[string]string
+ 	rawValues         map[string]string
+ 	Err               error
++
++	IptablesNATOutgoingInterfaceFilter string `config:""string;""`
+ }
+
+ type ProtoPort struct {","We should validate this, I think. To add a validator: - change `string` to, say `iface-pattern` - add a new `case ""iface-pattern""` to the `switch` in the `loadParams()` function: - in that `case`, you should be able to use a RegexpPattern like the one for `iface-list`. However, you'll need a different regexp. I think this regexp should work: `^[a-zA-Z0-9:._+-]{1,15}$` i.e. 1-15 characters consisting of alphanumerics, colon, dot, underscore, hyphen and plus.",struct field IptablesNATOutgoingInterfaceFilter should be IptablesNATOutgoingInterfaceFilter
+8510,"@@ -59,6 +59,10 @@ func TestBalance(t *testing.T) {
+ 	require.Nil(err)
+ 	// Balance should == 30 now
+ 	require.Equal(0, state.Balance.Cmp(big.NewInt(30)))
++
++    // Sub 40 to the balance
++    err = state.SubBalance(big.NewInt(40))
++    require.Equal(err, ErrNotEnoughBalance)
+ }
+
+ func TestClone(t *testing.T) {",File is not `goimports`-ed with -local github.com/iotexproject/iotex-core (from `goimports`),Where is this subtraction coming from?
+8511,"@@ -53,6 +53,11 @@ public class FlinkOrcWriter implements OrcRowWriter<RowData> {
+     writer.writeRow(row, output);
+   }
+
++  @Override
++  public List<OrcValueWriter<?>> writers() {
++    return this.writer.writers();
++  }
++
+   @Override
+   public Stream<FieldMetrics<?>> metrics() {
+     return writer.metrics();",Nit: Here we don't need the extra `this` in iceberg because we usually use the `this` to distinguish whether it is a member variable or local variable when assigning value.,why is this needed?
+8512,"@@ -71,7 +71,7 @@ public class AuthorizationLoggingTest {
+     engineRule.getManagementService().toggleTelemetry(true);
+
+     // then
+-    String message = ""ENGINE-03029 Required admin authenticated group or user."";
++    String message = ""ENGINE-16002 Exception while closing command context: ENGINE-03110 Required admin authenticated group or user or any of the following permissions:"";
+     List<ILoggingEvent> filteredLog = loggingRule.getFilteredLog(CONTEXT_LOGGER, message);
+
+     assertThat(filteredLog.size()).isEqualTo(1);","Why do we have that extra ""ENGINE-16002 Exception while closing command context:"" now? Is that done intentionally by us or where does that now come from?",is there a constant for the name of the exception?
+8513,"@@ -4,10 +4,15 @@ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ import org.slf4j.Marker;
+
++import java.util.Collections;
+ import java.util.Map.Entry;
++import java.util.Set;
+ import java.util.SortedMap;
+ import java.util.concurrent.ScheduledExecutorService;
+ import java.util.concurrent.TimeUnit;
++import java.util.function.Supplier;
++
++import static com.codahale.metrics.MetricAttribute.*;
+
+ /**
+  * A reporter class for logging metrics values to a SLF4J {@link Logger} periodically, similar to","Please don't use star imports, in the codebase we tend to use direct imports.","No asterisk imports at all, please."
+8514,"@@ -1,8 +1,10 @@
++import {CREDENTIALS} from ""../config.func"";
++
+ module.exports = function(server) {
+
+     test('who am I?', () => {
+       return server.whoami().then(function (username) {
+-        expect(username).toMatch('test');
++        expect(username).toMatch(CREDENTIALS.user);
+       });
+     });
+ ",Filename can be `config.functional`,Doesn't this have to be a `const` as well?
+8515,"@@ -44,11 +44,19 @@ nano::block_processor::block_processor (nano::node & node_a, nano::write_databas
+ 			this->condition.notify_all ();
+ 		}
+ 	};
++	thread = std::thread ([this] () {
++		nano::thread_role::set (nano::thread_role::name::block_processing);
++		this->process_blocks ();
++	});
+ }
+
+ nano::block_processor::~block_processor ()
+ {
+ 	stop ();
++	if (thread.joinable ())
++	{
++		thread.join ();
++	}
+ }
+
+ void nano::block_processor::stop ()",Should the thread join be done in the stop function maybe? I am simply wondering and sharing my thoughts. This is my thinking: * The join used to be done in the stop function of node class and now it has moved in the destructor. * The class state_block_signature_verification joins its thread at the stop function too.,"joinable is the wrong role here, should be `thread"
+8516,"@@ -22,3 +22,8 @@ var WalletCmd = &cobra.Command{
+ 		fmt.Println(""Print: "" + strings.Join(args, "" ""))
+ 	},
+ }
++
++func init() {
++	WalletCmd.AddCommand(walletCreateCmd)
++	WalletCmd.AddCommand(walletListCmd)
++}",don't use `init` function (from `gochecknoinits`),WalletCmd should be removed.
+8517,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-enable-resource.rb demonstrates how to enable an Amazon Simple Notification Services (SNS) resource using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - MY_TOPIC_ARN",Simple Notification **Service** (singular),`sns-ruby-example-enable-res
+8518,"@@ -15,6 +15,7 @@ DEFINE_int64(int64_test, 10, ""Test flag for int64 type"");
+ DEFINE_bool(bool_test, false, ""Test flag for bool type"");
+ DEFINE_double(double_test, 3.14159, ""Test flag for double type"");
+ DEFINE_string(string_test, ""Hello World"", ""Test flag for string type"");
++DEFINE_uint32(crash_test, 1024, ""The flag could not be read"");
+
+ namespace nebula {
+ ","You are fixing the crash problem, and you have fixed it, so it won't crash anymore. So `crash_test` is not a proper name.",Is this a typo? It should be
+8519,"@@ -68,8 +68,12 @@ public class SampleNamer extends NameFormatterDelegator {
+     return localVarName(Name.lowerCamel(""request""));
+   }
+
+-  /** Returns the variable name of the request body. */
+   public String getRequestBodyVarName() {
++    return getRequestBodyVarName("""");
++  }
++
++  /** Returns the variable name of the request body. */
++  public String getRequestBodyVarName(String requestBodyTypeName) {
+     return localVarName(Name.lowerCamel(""requestBody""));
+   }
+ ","If this default doesn't depend on the argument, shouldn't it be delegated as the default for the no-arg version instead?","What does ""requestBodyTypeNa"
+8520,"@@ -84,7 +84,7 @@ def read_api_key_safe():
+
+
+ def _get_config_file(path):
+-    get_or_create_file(path)
++    get_or_create_file(path, permissions=0o600)
+     return path
+
+ ","I did not use the new save_config_file method in here, because I am not sure whether this whole logic is still necessary? There is an TODO about it there as well.","Same as above, why did you choose to set default permissions?"
+8521,"@@ -22,7 +22,7 @@ define(['dom', 'appRouter', 'connectionManager'], function (dom, appRouter, conn
+                     return void appRouter.showItem(items[0]);
+                 }
+
+-                var url = 'itemdetails.html?id=' + itemId + '&serverId=' + serverId;
++                var url = 'details?id=' + itemId + '&serverId=' + serverId;
+                 Dashboard.navigate(url);
+             });
+             e.stopPropagation();",Why was this changed?,This could be `details?id=`
+8522,"@@ -98,6 +98,8 @@ class IoUBalancedNegSampler(RandomSampler):
+                 floor_set = set()
+                 iou_sampling_set = set(
+                     np.where(max_overlaps > self.floor_thr)[0])
++                # for sampling interval calculation
++                self.floor_thr == 0
+
+             floor_neg_inds = list(floor_set & neg_set)
+             iou_sampling_neg_inds = list(iou_sampling_set & neg_set)","I think you meant, self.floor_thr = 0",Why do you need this? Why not just do self.floor_thr = 0?
+8523,"@@ -14,13 +14,12 @@ import (
+
+ 	""github.com/99designs/gqlgen/graphql""
+ 	""github.com/99designs/gqlgen/graphql/introspection""
++	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
++	""github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model""
+ 	gqlparser ""github.com/vektah/gqlparser/v2""
+ 	""github.com/vektah/gqlparser/v2/ast""
+-	v1 ""k8s.io/api/core/v1""
++	""k8s.io/api/core/v1""
+ 	v11 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+-
+-	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+-	""github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model""
+ )
+
+ // region    ************************** generated!.gotpl **************************",Can you revert these changes?,"`v1alpha1` is no longer used, so you can remove it from the p"
+8524,"@@ -18,10 +18,13 @@
+
+ 'use strict';
+
+-import React, {
++import React from 'react';
++
++import {
+     Component,
+     Navigator,
+-    StatusBarIOS,
++    Platform,
++    StatusBar,
+     Text,
+     TouchableOpacity,
+     View,",Do we need to change this?,Please don't change these imports. It's up to you.
+8525,"@@ -104,14 +104,12 @@ func setKernelMemory(path string, kernelMemoryLimit uint64) error {
+ }
+
+ func setMemoryAndSwap(path string, cgroup *configs.Cgroup) error {
+-	ulimited := -1
+-
+-	// If the memory update is set to uint64(-1) we should also
+-	// set swap to uint64(-1), it means unlimited memory.
+-	if cgroup.Resources.Memory == uint64(ulimited) {
++	// If the memory update is set to MemoryUnlimited we should also
++	// set swap to MemoryUnlimited.
++	if cgroup.Resources.Memory == configs.MemoryUnlimited {
+ 		// Only set swap if it's enbled in kernel
+ 		if cgroups.PathExists(filepath.Join(path, cgroupMemorySwapLimit)) {
+-			cgroup.Resources.MemorySwap = uint64(ulimited)
++			cgroup.Resources.MemorySwap = uint64(configs.MemoryUnlimited)
+ 		}
+ 	}
+ ","With this commit, `MemoryUnlimited` is defined as a `unit64`, so I think you can drop the redundant cast from this line (and the later lines which also have `uint64(configs.MemoryUnlimited)`.",Should we error out if less than `configs.MemoryUn
+8526,"@@ -7,6 +7,8 @@ function DashboardContentTitle (props) {
+ }
+
+ function PanelTopBar (props) {
++  const notOverFileLimit = props.maxNumberOfFiles !== props.totalFileCount
++
+   return (
+     <div class=""uppy-DashboardContent-bar"">
+       <button class=""uppy-DashboardContent-back""",`props.totalFileCount < props.maxNumberOfFiles` makes the intent a bit more clear I think. And a check to see if maxNumberOfFiles even exists?,"It's not a big deal, but would you mind adding a s"
+8527,"@@ -12,7 +12,8 @@ import (
+
+ // Flags
+ var (
+-	epochNum uint64
++	epochNum  uint64
++	nextEpoch bool
+ )
+
+ // NodeCmd represents the node command",`epochNum` is a global variable (from `gochecknoglobals`),why is this a `bool` and not an `int`?
+8528,"@@ -1083,6 +1083,8 @@ angular.module('ui.grid')
+       } else {
+         // otherwise, manually search the oldRows to see if we can find this row
+         newRow = self.getRow(newEntity, oldRows);
++      } else {
++          newRow.entity = newEntity;
+       }
+
+       // if we didn't find the row, it must be new, so create it",This needs to be fixed before we can accept the PR,Shouldn't this be: `newRow.entity = newEntity;`
+8529,"@@ -14,6 +14,11 @@ constexpr double bootstrap_minimum_termination_time_sec = 30.0;
+ constexpr unsigned bootstrap_max_new_connections = 10;
+ constexpr unsigned bulk_push_cost_limit = 200;
+
++size_t constexpr nano::frontier_req::size;
++size_t constexpr nano::bulk_pull_blocks::size;
++size_t constexpr nano::bulk_pull_account::size;
++size_t constexpr nano::frontier_req_client::size_frontier;
++
+ nano::socket::socket (std::shared_ptr<nano::node> node_a) :
+ socket_m (node_a->io_ctx),
+ cutoff (std::numeric_limits<uint64_t>::max ()),",Are these forward declarations needed if we `#include <node/common.hpp>` which includes the definition ?,What is the `nano::socket::socket` constant? If
+8530,"@@ -76,7 +76,7 @@ func (m *Message) Bytes() []byte {
+ }
+
+ func (m *Message) String() string {
+-	return fmt.Sprintf(""MESSAGE: connectid %v MessageType %s"", m.ConnectID, m.MessageType)
++	return fmt.Sprintf(""MESSAGE: ConnectID %v MessageType %s"", m.ConnectID, m.MessageType)
+ }
+
+ func ReadMessageFromTunnel(r io.Reader) (*Message, error) {",can you use either `connectID` or `ConnectID` i would preffer `connectID`,"I know this isn't your change, but can you get "
+8531,"@@ -112,6 +112,11 @@ class Shopware6ChannelFormModel
+      */
+     public array $customField = [];
+
++    /**
++     * @var array|null
++     */
++    public ?array $crossSelling = [];
++
+     public function __construct(Shopware6Channel $channel = null)
+     {
+         if ($channel) {",It seems like it cannot be null?,"I think you could just remove this property, it"
+8532,"@@ -19,6 +19,7 @@ package azkaban.executor;
+ public class ExecutionReference {
+   private final int execId;
+   private Executor executor;
++  //Todo jamiesjc: deprecate updateTime in ExecutionReference class gradually.
+   private long updateTime;
+   private long nextCheckTime = -1;
+   private int numErrors = 0;",should we consider add deprecated annotation here?,please file a github issue for this or create a github issue
+8533,"@@ -27,8 +27,8 @@ import (
+ 	""golang.org/x/net/context""
+ )
+
+-type createUserFn func(t testing.TB, ith int, config *libkbfs.ConfigLocal,
+-	opTimeout time.Duration) *fsUser
++type createUserFn func(t testing.TB, ith int, name libkb.NormalizedUsername,
++	config *libkbfs.ConfigLocal, opTimeout time.Duration) *fsUser
+
+ type fsEngine struct {
+ 	name       string",Why can't the implementor get the username from the config?,would it be better to just pass a `*libkb.User` here rather
+8534,"@@ -87,7 +87,7 @@ func NewParams(raCtx protocol.RunActionsCtx, execution *action.Execution, stateD
+ 		BlockNumber: new(big.Int).SetUint64(raCtx.BlockHeight),
+ 		Time:        new(big.Int).SetInt64(raCtx.BlockTimeStamp),
+ 		Difficulty:  new(big.Int).SetUint64(uint64(50)),
+-		GasLimit:    raCtx.ActionGasLimit,
++		GasLimit:    execution.GasLimit(),
+ 		GasPrice:    execution.GasPrice(),
+ 	}
+ ",@CoderZhi Please confirm if this change makes sense,why is this no longer a var?
+8535,"@@ -127,6 +127,7 @@ public enum JsonRpcError {
+   PMT_FAILED_INTRINSIC_GAS_EXCEEDS_LIMIT(
+       -50100,
+       ""Private Marker Transaction failed due to intrinsic gas exeeding the limit. Gas limit used from the Private Transaction.""),
++  PRIVATE_SUBSCRIPTION_MULTI_TENANCY_ERROR(-50100, ""foo.""),
+
+   CANT_CONNECT_TO_LOCAL_PEER(-32100, ""Cannot add local node as peer.""),
+ ",Do you think you can come up with a better message? :-) It looks like this is not used anywhere. So maybe just delete the line.,"this error code is wrong, please use the same one as others"
+8536,"@@ -1065,11 +1065,7 @@ public interface Traversable<T> extends Foldable<T>, Value<T> {
+     @Override
+     default T reduceLeft(BiFunction<? super T, ? super T, ? extends T> op) {
+         Objects.requireNonNull(op, ""op is null"");
+-        if (isEmpty()) {
+-            throw new NoSuchElementException(""reduceLeft on Nil"");
+-        } else {
+-            return tail().foldLeft(head(), op);
+-        }
++        return iterator().reduceLeft(op);
+     }
+
+     /**",`tail()` is an expensive operation for certain collections,"I believe this is not the root cause of the issue, since it is a `default`. The rest LGTM"
+8537,"@@ -86,7 +86,8 @@ var rubyMappings = {
+   'http_infrastructure':['../../../TestServer/swagger/httpInfrastructure.json','HttpInfrastructureModule'],
+   'required_optional':['../../../TestServer/swagger/required-optional.json','RequiredOptionalModule'],
+   'report':['../../../TestServer/swagger/report.json','ReportModule'],
+-  'model_flattening':['../../../TestServer/swagger/model-flattening.json', 'ModelFlatteningModule'],
++  'model_flattening':['../../../TestServer/swagger/model-flattening.json', 'ModelFlatteningModule'],
++  'parameter_grouping':['../../../TestServer/swagger/azure-parameter-grouping.json', 'ParameterGroupingModule'],
+ };
+
+ var defaultAzureMappings = {",do we need to add this one in this PR?,add a space between the key name and the value
+8538,"@@ -223,7 +223,6 @@ namespace Nethermind.State.Test.Runner
+
+         public void ReportGasUpdateForVmTrace(long refund, long gasAvailable)
+         {
+-            throw new NotImplementedException();
+         }
+
+         public void ReportRefundForVmTrace(long refund, long gasAvailable)",where is a test for it?,Can you please explain why this is removed?
+8539,"@@ -46,7 +46,7 @@ class Page extends CmsCompoundObject
+      */
+     public $rules = [
+         'title' => 'required',
+-        'url'   => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i']
++        'url' => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i']
+     ];
+
+     /**",Why has this spacing been adjusted?,The `^` and `$` are redundant.
+8540,"@@ -90,10 +90,15 @@ class PipelineBuilder(object):
+                 raise api_errors.ApiInitializationError(e)
+
+             api_version = self.api_map.get(api_name).get('version')
+-            if api_version is None:
+-                api = api_class()
+-            else:
+-                api = api_class(version=api_version)
++            try:
++                if api_version is None:
++                    api = api_class()
++                else:
++                    api = api_class(version=api_version)
++            except api_errors.ApiExecutionError as e:
++                LOGGER.error('Failed to execute API %s, v=%s',
++                             api_class_name, api_version)
++                raise api_errors.ApiInitializationError(e)
+
+             self.initialized_api_map[api_name] = api
+ ","Sorry to do this, since you're touching this file can you resolve the pylint doc messages above?",you can log the exception with `exc_info=True` if you want
+8541,"@@ -81,7 +81,7 @@ class BigQueryWriter(object):
+             }
+             bq_data.append({
+                 'json': row,
+-                'insertId': ""%s-%s"" % (listen['user_name'], listen['listened_at'])
++                'insertId': ""%s-%s-%s"" % (listen['user_name'], listen['listened_at'], listen['recording_msid'])
+             })
+
+         body = { 'rows' : bq_data }","@alastair, because the `insertId` for two listens with different metadata and same ts was the same, only one of them would get written into BQ. A question is what would be the ideal way to write tests for stuff like this, so that this doesn't break again?",E501 line too long (124 > 120 characters)
+8542,"@@ -1883,7 +1883,7 @@ UDS_RDBI.dataIdentifiers[0x4080] = ""AirbagLock_NEU""
+ UDS_RDBI.dataIdentifiers[0x4140] = ""BodyComConfig""
+ UDS_RDBI.dataIdentifiers[0x4ab4] = ""Betriebsstundenzaehler""
+ UDS_RDBI.dataIdentifiers[0x5fc2] = ""WDBI_DME_ABGLEICH_PROG_REQ""
+-UDS_RDBI.dataIdentifiers[0xd114] = ""Gesamtweg-Streckenzähler Offset""
++UDS_RDBI.dataIdentifiers[0xd114] = ""Gesamtweg-Streckenzaehler Offset""
+ UDS_RDBI.dataIdentifiers[0xd387] = ""STATUS_DIEBSTAHLSCHUTZ""
+ UDS_RDBI.dataIdentifiers[0xdb9c] = ""InitStatusEngineAngle""
+ UDS_RDBI.dataIdentifiers[0xEFE9] = ""WakeupRegistry""",Wondering where this breaks btw (although pretty understandable),I'm guessing this was a typo?
+8543,"@@ -64,6 +64,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy {
+       Dataset<Row> scanDF = cloneSession.read().format(""iceberg"")
+           .option(SparkReadOptions.FILE_SCAN_TASK_SET_ID, groupID)
+           .option(SparkReadOptions.SPLIT_SIZE, splitSize(inputFileSize(filesToRewrite)))
++          .option(SparkReadOptions.LOOKBACK, 10)
+           .option(SparkReadOptions.FILE_OPEN_COST, ""0"")
+           .load(table.name());
+ ",is this needed? 10 is already the default,Why does it differ from DEFAULT_LOOKBACK?
+8544,"@@ -35,9 +35,13 @@ class TextPlot(ElementPlot):
+             data = dict(x=[element.x], y=[element.y])
+         self._categorize_data(data, ('x', 'y'), element.dimensions())
+         data['text'] = [element.text]
+-        style['text_align'] = element.halign
++        if 'text_align' not in style:
++            style['text_align'] = element.halign
+         baseline = 'middle' if element.valign == 'center' else element.valign
+-        style['text_baseline'] = baseline
++        if 'text_baseline' not in style:
++            style['text_baseline'] = baseline
++        if 'text_font_size' not in style:
++            style['text_font_size'] = '%dPt' % element.fontsize
+         if 'color' in style:
+             style['text_color'] = style.pop('color')
+         return (data, mapping, style)",One day we can try to allow the user to specify font sizes in something other than points. For now this is fine though...,I don't think this is the right place for this if-statement. Maybe it should move to `_categorize_data`?
+8545,"@@ -29,7 +29,13 @@ namespace rtps {
+
+
+ WriterProxyData::WriterProxyData()
++#if HAVE_SECURITY
++    : security_attributes_(0)
++    , plugin_security_attributes_(0)
++    , m_userDefinedId(0)
++#else
+     : m_userDefinedId(0)
++#endif
+     , m_typeMaxSerialized(0)
+     , m_isAlive(true)
+     , m_topicKind(NO_KEY)",duplicated in both block of preprocessor condition. Can you join in one?,Do we have to set m_userDefinedId(0) here?
+8546,"@@ -50,9 +50,10 @@ function getXPathArray(node, path) {
+ 		var element = {};
+ 		element.str = node.nodeName.toLowerCase();
+ 		// add the id and the count so we can construct robust versions of the xpath
+-		if(node.getAttribute && node.getAttribute('id') &&
+-			node.ownerDocument.querySelectorAll('#' + axe.utils.escapeSelector(node.id)).length === 1) {
+-
++		if(
++			node.getAttribute && node.getAttribute('id') &&
++			node.ownerDocument.querySelectorAll('#' + axe.utils.escapeSelector(node.getAttribute('id'))).length === 1
++		) {
+ 			element.id = node.getAttribute('id');
+ 		}
+ 		if(count > 1) {",Can we put the first part of the expression inline with the `if(` for consistency's sake?,can you change this to: `if(node.getAttribute('id')) {`
+8547,"@@ -26,9 +26,15 @@ import ""github.com/yarpc/yarpc-go/transport""
+ type CallReqMeta interface {
+ 	Procedure(string) CallReqMeta
+ 	Headers(Headers) CallReqMeta
++	ShardKey(string) CallReqMeta
++	RoutingKey(string) CallReqMeta
++	RoutingDelegate(string) CallReqMeta
+
+ 	GetProcedure() string
+ 	GetHeaders() Headers
++	GetShardKey() string
++	GetRoutingKey() string
++	GetRoutingDelegate() string
+ }
+
+ // ReqMeta contains information about an incoming YARPC request.",Do servers have no need of accessing this information?,These methods should be moved to `route` package.
+8548,"@@ -51,7 +51,7 @@
+     // @vue/component
+     var commonFormattersMixin = {
+         methods: {
+-            formatTimeAgo: countlyCommon.formatTimeAgo,
++            formatTimeAgo: countlyCommon.formatTimeAgoText,
+             formatNumber: countlyCommon.formatNumber,
+             getShortNumber: countlyCommon.getShortNumber
+         }","It feels like this will break some stuff, but let it break. We need ""text"" version anyway.",It's weird to have a method named `formatTimeAgo` that's not a method called `formatTimeAgoText`. Maybe name it `formatTimeAgoText` (and similarly in other places)?
+8549,"@@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc &leftTable,
+     ItemExpr *leftExpr  = leftTable.getValueId(i).getItemExpr();
+     ItemExpr *rightExpr = rightTable.getValueId(i).getItemExpr();
+     BiRelat *compare = new (bindWA->wHeap())
+-      BiRelat(ITM_EQUAL, leftExpr, rightExpr);
++      BiRelat(ITM_EQUAL, leftExpr, rightExpr, TRUE);
+     if (predicate)
+       predicate = new (bindWA->wHeap()) BiLogic(ITM_AND, predicate, compare);
+     else","Here are two things I wonder: First, would it make sense to replace the TRUE here with ""leftExpr->getValueId().getType().supportsSQLnull() && rightExpr->getValueId().getType().supportsSQLnull()"". I'm not sure we have optimizations elsewhere that set the ""special nulls"" semantics back to FALSE if one of the operands it not nullable. Second, I wonder whether we have bugs elsewhere in the code that may not check for the ""special nulls"" semantics. For example, hash and merge joins probably can't use such predicates as equi-join predicates - one of the reasons for the optimization above. When I look at method ItemExpr::isAnEquiJoinPredicate() in core/sql/optimizer/OptItemExpr.cpp, I don't see a check for that. You have an example with a NULL value that is working, so hopefully this is not an issue, but I'm not sure how and why it works.","> NULL [](start = 42, length = 5) nit: `NULL` is not a valid value for this ?"
+8550,"@@ -267,7 +267,8 @@ T *LookupTableByName(const SymbolTable<T> &table, const std::string &name,
+   TD(StringConstant, 257, ""string constant"") \
+   TD(IntegerConstant, 258, ""integer constant"") \
+   TD(FloatConstant, 259, ""float constant"") \
+-  TD(Identifier, 260, ""identifier"")
++  TD(NumericConstant, 260, ""nan, inf or function name (signed)"") \
++  TD(Identifier, 261, ""identifier"")
+ #ifdef __GNUC__
+ __extension__  // Stop GCC complaining about trailing comma with -Wpendantic.
+ #endif",This will cause someone writing a schema field like `inf:string` to get a pretty confusing error? If they intended to use `inf` as short for `information` or whatever :) Might it be better to keep it as `Identifier` and explicitly recognize the few identifiers we care about only when parsing values (not while parsing field names)?,"Any reason why this is 260, and not 260+?"
+8551,"@@ -46,7 +46,7 @@ export function generateRandomHexString(length: number = 8) {
+
+ export function signPayload(payload: JWTPayload, secret: string, options: JWTSignOptions) {
+   return jwt.sign(payload, secret, {
+-    notBefore: '1000', // Make sure the time will not rollback :)
++    notBefore: '1', // Make sure the time will not rollback :)
+     ...options,
+   });
+ }",Mmm .... this affect #168 I'll need to research the collateral damage,why was this changed?
+8552,"@@ -268,7 +268,7 @@ func checkSrvRecord(dnsBootstrap string) {
+
+ func doDeleteDNS(network string, noPrompt bool, excludePattern string) bool {
+
+-	if network == """" || network == ""testnet"" || network == ""devnet"" || network == ""mainnet"" {
++	if network == """" || network == ""testnet"" || network == ""devnet"" || network == ""mainnet"" || network == ""beta"" {
+ 		fmt.Fprintf(os.Stderr, ""Deletion of network '%s' using this tool is not allowed\n"", network)
+ 		return false
+ 	}",nit: refactor into a const map lookup.,"Will this work if `network == ""beta""`?"
+8553,"@@ -26,7 +26,7 @@ namespace MvvmCross.Forms.Droid.Views
+         {
+             BindingContext = new MvxAndroidBindingContext(this, this);
+             this.AddEventListeners();
+-            _resourceAssembly = Assembly.GetCallingAssembly();
++            _resourceAssembly = this.GetType().Assembly;
+         }
+
+         public object DataContext",I don't think this is going to work. We need to get the actual assembly of the app project. @johnnywebb thoughts?,Is this a bug fix? Shouldn't it be `Ge
+8554,"@@ -306,7 +306,7 @@ def get_kbr_keys(kb_name, searchkey="""", searchvalue="""", searchtype='s'):
+                                              searchvalue, searchtype)
+
+ def get_kbr_values(kb_name, searchkey="""", searchvalue="""", searchtype='s',
+-                   use_memoise=False):
++                   use_memoize=False):
+     """"""
+     Return a tuple of values from key-value mapping kb.
+ ",@MSusik be careful about changing existing API. I think in this case you shouldn't rename the argument.,"I know you didn't write this, but do y"
+8555,"@@ -176,8 +176,8 @@ int produce_message(struct flb_time *tm, msgpack_object *map,
+                 /* Add extracted topic on the fly to topiclist */
+                 if (ctx->dynamic_topic) {
+                     /* Only if default topic is set and this topicname is not set for this message */
+-                    if (strncmp(topic->name, flb_kafka_topic_default(ctx)->name, val.via.str.size) == 0 &&
+-                        (strncmp(topic->name, val.via.str.ptr, val.via.str.size) != 0) ) {
++                    if (strcmp(topic->name, flb_kafka_topic_default(ctx)->name) == 0 &&
++                        (strcmp(topic->name, val.via.str.ptr) != 0) ) {
+                         if (strstr(val.via.str.ptr, "","")) {
+                             /* Don't allow commas in kafkatopic name */
+                             flb_warn(""',' not allowed in dynamic_kafka topic names"");",This is bad. It is not a NULL-terminated string here.,Isn't `val.via.str.ptr` guaranteed to
+8556,"@@ -48,9 +48,10 @@ class UserIpReader
+     protected $server;
+
+     /**
+-     * Should we respect the X-Forwarded-For header?
++     * Configuration specifying allowed HTTP headers containing IPs (false for none).
++     * See [Proxy] allow_forwarded_ips setting in config.ini for more details.
+      *
+-     * @var bool
++     * @var string|bool
+      */
+     protected $allowForwardedIps;
+ ",This probably should be @param string|false.,It should be `string`.
+8557,"@@ -195,7 +195,7 @@ public class SmartSqlTest extends SmartStoreTestCase {
+ 	 */
+ 	public void testSmartQueryReturningOneRowWithTwoIntegers() throws JSONException {
+ 		loadData();
+-		JSONArray result = store.query(QuerySpec.buildSmartQuerySpec(""select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr, {employees} as e where e.{employees:lastName} = 'Thompson'"", 1), 0);
++		JSONArray result = store.query(QuerySpec.buildSmartQuerySpec(""select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr, {employees} as e where e.{employees:lastName} = 'Thompson' and mgr.{employees:employeeId} = e.{employees:managerId}"", 1), 0);
+ 		assertSameJSONArray(""Wrong result"", new JSONArray(""[[200000,120000]]""), result);
+ 	}
+ 	",Unrelated test fix. Already in cordova34 branch.,Since there are multip
+8558,"@@ -87,10 +87,6 @@ func (sc *stakingCommand) CreatePostSystemActions(ctx context.Context, sr protoc
+ }
+
+ func (sc *stakingCommand) Handle(ctx context.Context, act action.Action, sm protocol.StateManager) (*action.Receipt, error) {
+-	// no height here,  v1 v2 has the same validate method, so directly use common one
+-	if err := validate(ctx, sm, sc, act); err != nil {
+-		return nil, err
+-	}
+ 	if sc.useV2(ctx, sm) {
+ 		return sc.stakingV2.Handle(ctx, act, sm)
+ 	}",validate() will be called by either V1 or V2,this validation has mo
+8559,"@@ -100,6 +100,13 @@ class CppGenerator : public BaseGenerator {
+
+     assert(!cur_name_space_);
+
++    code_ += ""#if defined(_MSC_VER)"";
++    code_ += ""#define NOEXCEPT"";
++    code_ += ""#else"";
++    code_ += ""#define NOEXCEPT noexcept"";
++    code_ += ""#endif"";
++    code_ += """";
++
+     // Generate forward declarations for all structs/tables, since they may
+     // have circular references.
+     for (auto it = parser_.structs_.vec.begin();","rather than generate code for this every time, stick it in `flatbuffers.h` (and call it `FLATBUFFERS_NOEXCEPT` to avoid clashes).",This would be cleaner
+8560,"@@ -14,7 +14,9 @@ import (
+ // GetBlockByNumber see https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getblockbynumber
+ // see internal/ethapi.PublicBlockChainAPI.GetBlockByNumber
+ func (api *APIImpl) GetBlockByNumber(ctx context.Context, number rpc.BlockNumber, fullTx bool) (map[string]interface{}, error) {
+-	tx, err := api.dbReader.Begin(ctx)
++	// TODO the next line used to be ""tx, err := api.dbReader.Begin(ctx)"" When it changed, there was concern that it would have
++	// negative impact on performance. Revisit performance of using this type of database transaction
++	tx, err := api.db.Begin(ctx, nil, false)
+ 	if err != nil {
+ 		return nil, err
+ 	}","@AskAlexSharov @tjayrush , I'm still feeling uncomfortable with this change: - because it works by accident. For example in next lines `tx` object used as: `ReadBlockByNumber(tx)`. If you go inside `ReadBlockByNumber` you can find `!errors.Is(err, ethdb.ErrKeyNotFound)` - but ethdb.Tx doesn't return this error - and it satisfy `DatabaseReader` by accident - (I faced this problem last week - when passed Tx to place which expected Db - and I promised to change tx API - rename Get to GetOne or even remove the method). - we can merge this PR if it doesn't break things and solve problem of localDb use of RPCDaemon. But I will make PR now which will allow open Read tx by TxDb/ObjectDb - and will ask you to use it. Then will take a look how hard to change LmdbTx to not satisfy rawdb.DatabaseReader interface.","If you look at the code below, you'll see that there was an error before the transaction was created. If you look at the Begin call, you'll see that there was an error before the transaction creation."
+8561,"@@ -159,3 +159,4 @@ def createTemporalAnomaly(recordParams, spatialParams=_SP_PARAMS,
+   temporalPoolerRegion.setParameter(""anomalyMode"", True)
+
+   return network
++  ",I think this means the file doesn't have a newline character at the end.,why is this needed?
+8562,"@@ -469,6 +469,15 @@ fpga_result fpgaPerfCounterGet(fpga_token token, fpga_perf_counter *fpga_perf)
+
+ 	memset(fpga_perf, 0, sizeof(fpga_perf_counter));
+
++	//check if its being run as root or not
++	uid_t uid = getuid();
++	if (uid != 0) {
++		fpga_perf->previlege = false;
++		return FPGA_OK;
++	} else {
++		fpga_perf->previlege = true;
++	}
++
+ 	ret = get_fpga_sbdf(token, &segment, &bus, &device, &function);
+ 	if (ret != FPGA_OK) {
+ 		OPAE_ERR(""Failed to get sbdf"");","Hi Ramya, rather than checking here in the perf counter library, we should add the privilege check in the host_exerciser app.",Why is this check needed?
+8563,"@@ -20,7 +20,9 @@ class TrackedObject:
+ 	""""""
+
+ 	def __del__(self):
+-		notifyObjectDeletion(self)
++		# notifyObjectDeletion could be None if Python is shutting down.
++		if notifyObjectDeletion:
++			notifyObjectDeletion(self)
+
+
+ _collectionThreadID = 0",Could you elaborate on this some more? Has this behavior changed with Python 3.8?,"Shouldn't we check in here whether the python is shutting down, and only call `notifyObjectDeletion` if it's not `None`?"
+8564,"@@ -89,7 +89,10 @@ const logReqMsg = `DEBUG: Request %s/%s Details:
+
+ func logRequest(r *request.Request) {
+ 	logBody := r.Config.LogLevel.Matches(aws.LogDebugWithHTTPBody)
+-	dumpedBody, _ := httputil.DumpRequestOut(r.HTTPRequest, logBody)
++	dumpedBody, err := httputil.DumpRequestOut(r.HTTPRequest, logBody)
++	if err != nil {
++		r.Config.Logger.Log(fmt.Sprintf(""Error dumping request: %s"", err))
++	}
+
+ 	if logBody {
+ 		// Reset the request body because dumpRequest will re-wrap the r.HTTPRequest's","Do we want to continue on logging the `dumpedBody`, if an error was thrown? It is probably an empty string. This would make the log after this one pretty much useless.",DumpRequestOut doesn't need to do anything with the error so can just use `r.Config.Logger.Logf` here.
+8565,"@@ -1,6 +1,7 @@
+ <fieldset class=""annotation_fields"" id=""<%= unique_dom_id(f.object, ""fields"") %>"">
+   <div class=""form-group col-md-10"">
+-    <%= f.label(:type, f.object.type.humanize, class: ""control-label"") %>
++    <% lbl = f.object.type.humanize.downcase == 'example answer' ? _('Example answer') : _('Guidance') %>
++    <%= f.label(:type, lbl, class: ""control-label"") %>
+     <div data-toggle=""tooltip"" title=""<%= tooltip_for_annotation_text(f.object) %>"">
+       <em class=""sr-only""><%= tooltip_for_annotation_text(f.object) %></em>
+       <%= f.text_area(:text, class: 'question',",the text here is derived from the object type and not getting properly handled by get text,Rename `lbl` to `label` (since it is the same as `f.object.humanize`).
+8566,"@@ -27,10 +27,13 @@ const (
+ var (
+ 	// runtimeMode tells which mode antctl is running against.
+ 	runtimeMode string
++	inPod       bool
+ )
+
+ func init() {
+-	if strings.HasPrefix(os.Getenv(""POD_NAME""), ""antrea-agent"") {
++	podName, found := os.LookupEnv(""POD_NAME"")
++	inPod = found && (strings.HasPrefix(podName, ""antrea-agent"") || strings.HasPrefix(podName, ""antrea-controller""))
++	if strings.HasPrefix(podName, ""antrea-agent"") {
+ 		runtimeMode = ModeAgent
+ 	} else {
+ 		runtimeMode = ModeController",This will make other pods that run antctl will also connect its localhost? Maybe only do it when it's in antrea-agent and antrea-controller,"If `inPod` is false, should we set it to `true`?"
+8567,"@@ -168,9 +168,6 @@ define([""jQuery"", ""globalize"", ""scripts/taskbutton"", ""dom"", ""libraryMenu"", ""layo
+         }), menuItems.push({
+             name: ""Xml TV"",
+             id: ""xmltv""
+-        }), menuItems.push({
+-            name: globalize.translate(""ButtonOther""),
+-            id: ""other""
+         }), require([""actionsheet""], function(actionsheet) {
+             actionsheet.show({
+                 items: menuItems,","The corresponding action for this key needs to be removed as well, along with any unused translations.",Why was this removed?
+8568,"@@ -48,15 +48,15 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
+
+             var requestProxy = request.DuckCast<ISendMessageBatchRequest>();
+
+-            var scope = AwsSqsCommon.CreateScope(Tracer.Instance, Operation, out AwsSqsTags tags);
++            var scope = AwsSqsCommon.CreateScope(Tracer.InternalInstance, Operation, out AwsSqsTags tags);
+             tags.QueueUrl = requestProxy.QueueUrl;
+
+-            if (scope?.Span?.Context != null && requestProxy.Entries.Count > 0)
++            if (scope?.Span.Context is SpanContext spanContext && requestProxy.Entries.Count > 0)
+             {
+                 for (int i = 0; i < requestProxy.Entries.Count; i++)
+                 {
+                     var entry = requestProxy.Entries[i].DuckCast<IContainsMessageAttributes>();
+-                    ContextPropagation.InjectHeadersIntoMessage<TSendMessageBatchRequest>(entry, scope?.Span?.Context);
++                    ContextPropagation.InjectHeadersIntoMessage<TSendMessageBatchRequest>(entry, spanContext);
+                 }
+             }
+ ","Can't Span cannot be null anymore? I assume it was a useless check as there are discrepencies within integrations, but as you explicitly removed this one, I was wondering",Why this change? `requestProxy.Entries` is a `SpanContext`.
+8569,"@@ -210,7 +210,7 @@ namespace Nethermind.JsonRpc.Modules.Trace
+
+             Block block = blockSearch.Object;
+
+-            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace | ParityTraceTypes.Rewards);
++            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace);
+             return ResultWrapper<ParityTxTraceFromStore[]>.Success(ParityTxTraceFromStore.FromTxTrace(txTrace));
+         }
+ ","hmmm, ok, this is interesting -> Lukasz definitely uses rewards traces",Was this a bug?
+8570,"@@ -78,6 +78,9 @@ public class TableProperties {
+   public static final String SPLIT_OPEN_FILE_COST = ""read.split.open-file-cost"";
+   public static final long SPLIT_OPEN_FILE_COST_DEFAULT = 4 * 1024 * 1024; // 4MB
+
++  public static final String SPLIT_BY_PARTITION = ""read.split.by-partition"";
++  public static final boolean SPLIT_BY_PARTITION_DEFAULT = false;
++
+   public static final String PARQUET_VECTORIZATION_ENABLED = ""read.parquet.vectorization.enabled"";
+   public static final boolean PARQUET_VECTORIZATION_ENABLED_DEFAULT = false;
+ ",Why do we need this flag? can this be detected if the table is bucketed/partitioned and enabled/disabled automatically? Is this for backwards compatibility?,"Is there a reason why you chose to name this property as ""r"
+8571,"@@ -188,7 +188,7 @@ bool is_name_type(const char* name)
+ {
+   if(*name == '$')
+     name++;
+-
++
+   if(*name == '_')
+     name++;
+ ",can you revert changes to this file.,<msg><msg><msg><msg><msg><msg><msg><msg><msg><msg><msg>Reve
+8572,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+
++// Package soc provides the single-owner chunk implemenation
++// and validator.
+ package soc
+
+ import (",suggestion to add: An soc is a chunks whose address is derived of (...),typo: `soc` -> `soc`
+8573,"@@ -110,6 +110,8 @@ export const API_ERROR = {
+   DEPRECATED_BASIC_HEADER: 'basic authentication is deprecated, please use JWT instead',
+   BAD_FORMAT_USER_GROUP: 'user groups is different than an array',
+   RESOURCE_UNAVAILABLE: 'resource unavailable',
++  USERNAME_PASSWORD_REQUIRED: 'username and password is required',
++  USERNAME_ALREADY_REGISTERED: 'username is already registered',
+ };
+
+ export const APP_ERROR = {","It doesn't make sense. if we are going to have the profile page where the user can change the password and he / she is already logged in ... I do not need to register a new username. only: new password..confirm new password..something similar...and ""USERNAME_ALREADY_REGISTERED"" only if I have a register page..are we going to have? We need to talk about it.",Can we please call t
+8574,"@@ -747,14 +747,14 @@ namespace Nethermind.State
+             _needsStateRootUpdate = false;
+         }
+
+-        public void CommitTree()
++        public void CommitTree(long blockNumber)
+         {
+             if (_needsStateRootUpdate)
+             {
+                 RecalculateStateRoot();
+             }
+
+-            _tree.Commit();
++            _tree.Commit(blockNumber);
+         }
+     }
+ }",not a great fan of this change - maybe worth splitting into CommitTree() and CloseBlock(long blockNumber)?,What's the benefit o
+8575,"@@ -65,7 +65,9 @@ namespace Microsoft.AspNetCore.Connections
+
+         public CancellationToken ConnectionClosed { get; set; }
+
+-        public virtual void Abort()
++        public void Abort() => Abort(abortReason: null);
++
++        public virtual void Abort(ConnectionAbortedException abortReason)
+         {
+             ThreadPool.QueueUserWorkItem(cts => ((CancellationTokenSource)cts).Cancel(), _connectionClosedTokenSource);
+         }","Ugh, if we're going to make a breaking change, I'd like this to be moved to ConnectionContext.",What's the differenc
+8576,"@@ -1286,6 +1286,12 @@ func NewFs(path string) (Fs, error) {
+ 	if err != nil {
+ 		return nil, err
+ 	}
++	// TODO: Fix import for rc
++	// f, err := fsInfo.NewFs(configName, fsPath, config)
++	// if err != nil && f.reload != nil {
++	// 	rc.AddOptionReload(f.name, &f.opt, f.reload)
++	// }
++	// return f, err
+ 	return fsInfo.NewFs(configName, fsPath, config)
+ }
+ ","I was planning to add it as a common option, but there is a cyclic import for the rc & fs libs. Thoughts on avoiding it or should I remove this for now?",please just delete the code.
+8577,"@@ -65,6 +65,10 @@ namespace SynchronizeVersions
+                 ""src/Datadog.Trace/Datadog.Trace.csproj"",
+                 NugetVersionReplace);
+
++            SynchronizeVersion(
++                ""/deploy/Nuget/Datadog.Trace.nuspec"",
++                NugetVersionReplace);
++
+             Console.WriteLine($""Completed synchronizing versions to {VersionString()}"");
+         }
+ ","I think this entry can be removed now, right?",Why do we need synchronizing
+8578,"@@ -230,6 +230,18 @@ class Key(object):
+         else:
+             self.encrypted = None
+
++    def handle_storage_class_header(self, resp):
++        provider = self.bucket.connection.provider
++        if provider.storage_class_header:
++            self._storage_class = resp.getheader(
++                provider.storage_class_header, None)
++            if (self._storage_class is None and
++                provider.get_provider_name() == 'aws'):
++                # S3 docs for HEAD object requests say S3 will return this
++                # header for all objects except Standard storage class objects.
++                self._storage_class = 'STANDARD'
++
++
+     def handle_version_headers(self, resp, force=False):
+         provider = self.bucket.connection.provider
+         # If the Key object already has a version_id attribute value, it","I don't understand why you want to populate the storage class in this case, if the S3 docs say they won't populate the header in this case?",Thanks @annatisch ! Do you k
+8579,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities",`timeouts` -> `timeouts`
+8580,"@@ -14,8 +14,11 @@ import (
+ //
+ // The request will not be signed, and will not use your AWS credentials.
+ //
+-// A ""NotFound"" error code will be returned if the bucket does not exist in
+-// the AWS partition the regionHint belongs to.
++// A ""NotFound"" error code will be returned if the bucket does not exist in the
++// AWS partition the regionHint belongs to. If the regionHint parameter is an
++// empty string GetBucketRegion will fallback to the ConfigProvider's region
++// config. If no region is specified, hint or ConfigProvider, an error will
++// be returned.
+ //
+ // For example to get the region of a bucket which exists in ""eu-central-1""
+ // you could provide a region hint of ""us-west-2"".",Should the last sentence be `If no region was found` rather than `specified`?,"If the region hint is empty, GetBucketRegion will fallback to the ConfigProvider's region. If no region is specified, an error will be returned."
+8581,"@@ -217,9 +217,16 @@ public class CoxPlugin extends Plugin
+ 			{
+ 				for (Player player : client.getPlayers())
+ 				{
+-					if (player.getName().equals(tpMatcher.group(1)))
++					final String rawPlayerName = player.getName();
++
++					if (rawPlayerName != null)
+ 					{
+-						victims.add(new Victim(player, Victim.Type.TELEPORT));
++						final String fixedPlayerName = Text.sanitize(rawPlayerName);
++
++						if (fixedPlayerName.equals(tpMatcher.group(1)))
++						{
++							victims.add(new Victim(player, Victim.Type.TELEPORT));
++						}
+ 					}
+ 				}
+ 			}","Text.sanitize just removes images from names, for instance, the hardcore ironman symbol when someone talks. A better option would be text.standardize, or text.toJagexName",why not use `Text.sanitize` here?
+8582,"@@ -81,3 +81,13 @@ func (a *Application) IsOutOfSync() bool {
+ func IsApplicationConfigFile(filename string) bool {
+ 	return filename == DefaultApplicationConfigFilename || strings.HasSuffix(filename, applicationConfigFileExtention)
+ }
++
++func ToApplicationKind(kind string) (ApplicationKind, bool) {
++	upper := strings.ToUpper(string(kind))
++	k := strings.TrimSuffix(upper, ""APP"")
++	appKind, ok := ApplicationKind_value[k]
++	if !ok {
++		return -1, false
++	}
++	return ApplicationKind(appKind), true
++}",How about `ApplicationKindFromConfigKind`? And I think this function should be better in the config package. The reason is `config` package can import and refer things from the model package but not vice versa.,When would `ok` not be true?
+8583,"@@ -101,9 +101,14 @@ const (
+ // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob.
+ type Options struct {
+ 	// Credential represents the authorizer for SignedURL.
+-	// Required to use SignedURL.
++	// Required to use SignedURL. If you're using MSI for authentication, this will
++	// attempt to be loaded lazily the first time you call SignedURL
+ 	Credential azblob.StorageAccountCredential
+
++	// CredentialExpiration is when the current MSI-obtained signing credential
++	// expires so that we can refresh it on demand
++	CredentialExpiration time.Time
++
+ 	// SASToken can be provided along with anonymous credentials to use
+ 	// delegated privileges.
+ 	// See https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1#shared-access-signature-parameters.","Nit: missing closing ""."".",Typo: `might` -> `provided`
+8584,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked",Is there a test that checks whether a button is disabled?
+8585,"@@ -123,9 +123,9 @@ func CreatePipeline(pipelineName string, provider Provider, stageNames []string)
+ 	}, nil
+ }
+
+-// Marshal serializes the pipeline manifest object into byte array that
++// MarshalBinary serializes the pipeline manifest object into byte array that
+ // represents the pipeline.yml document.
+-func (m *PipelineManifest) Marshal() ([]byte, error) {
++func (m *PipelineManifest) MarshalBinary() ([]byte, error) {
+ 	box := templates.Box()
+ 	content, err := box.FindString(""cicd/pipeline.yml"")
+ 	if err != nil {",Same here. Should this be pipeline YAML file? Like `MarshalPipelineManifest`,Why did you change this?
+8586,"@@ -213,6 +213,9 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) {
+ 	}
+ 	i.Stop()
+
++	// Execute instantiation events
++	EmitEvent(InstanceStartupEvent, newInst)
++
+ 	log.Println(""[INFO] Reloading complete"")
+
+ 	return newInst, nil",I will add this to my PR  ,I think this should be at the Info level. If the instance
+8587,"@@ -19,4 +19,8 @@ class RolePolicy < ApplicationPolicy
+   def destroy?
+     @role.plan.owned_by?(@user.id)
+   end
++
++  def archive?
++    @role.user_id = @user.id
++  end
+ end",Again not 100% sold on the name,Use safe navigation (&.) instead of checking if an object
+8588,"@@ -226,8 +226,9 @@ func runWeb(ctx *cli.Context) error {
+ 	m.Group(""/user/settings"", func() {
+ 		m.Get("""", user.Settings)
+ 		m.Post("""", bindIgnErr(auth.UpdateProfileForm{}), user.SettingsPost)
+-		m.Post(""/avatar"", binding.MultipartForm(auth.UploadAvatarForm{}), user.SettingsAvatar)
++		m.Post(""/avatar"", binding.MultipartForm(auth.AvatarForm{}), user.SettingsAvatarPost)
+ 		m.Post(""/avatar/delete"", user.SettingsDeleteAvatar)
++		m.Get(""/avatar"", user.SettingsAvatar)
+ 		m.Combo(""/email"").Get(user.SettingsEmails).
+ 			Post(bindIgnErr(auth.AddEmailForm{}), user.SettingsEmailPost)
+ 		m.Post(""/email/delete"", user.DeleteEmail)",Use `m.Combo` for `Get` and `Post` methods.,"What's the difference between `m.Get(""/avatar"", user.SettingsAvatarPost)` and `user.SettingsAvatarPost`?"
+8589,"@@ -446,6 +446,13 @@ class DownloadItem(QObject):
+             # The file already exists, so ask the user if it should be
+             # overwritten.
+             self._ask_overwrite_question()
++        # FIFO, device node, etc. Don't even try.
++        elif (os.path.exists(self._filename) and not
++                os.path.isdir(self._filename)):
++            self.cancel(False)
++            message.error(self._win_id, ""The file {} already exists, and is a ""
++                                        ""special file. Aborting."".format(
++                                         self._filename))
+         else:
+             self._create_fileobj()
+ ","Is there a reason you're not using `self._die(""The file {} ..."")` here?","`self.cancel(False)` should be moved up one line, before the `message.error` call"
+8590,"@@ -13,7 +13,7 @@ import (
+
+ // LocalDevExecCmd allows users to execute arbitrary bash commands within a container.
+ var LocalDevExecCmd = &cobra.Command{
+-	Use:   ""exec [app_name] [environment_name] '[cmd]'"",
++	Use:   ""exec '[cmd]'"",
+ 	Short: ""run a command in an app container."",
+ 	Long:  `Execs into container and runs bash commands.`,
+ 	Run: func(cmd *cobra.Command, args []string) {","I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But ""Run a command in an app container"" doesn't do it for me :)",Shouldn't we keep the examples that include `app_name` and `environment_name`?
+8591,"@@ -8,6 +8,10 @@ import (
+ 	. ""github.com/weaveworks/weave/common""
+ )
+
++var (
++	weaveWaitEntrypoint = []string{""/home/weavewait/weavewait""}
++)
++
+ func callWeave(args ...string) ([]byte, error) {
+ 	args = append([]string{""--local""}, args...)
+ 	Debug.Print(""Calling weave"", args)",shouldn't this be a const?,"I think this would be clearer with `weaveWaitEntrypoint = ""/home/weavewait/weavewait/""`"
+8592,"@@ -135,10 +135,7 @@ class MongoDBMochaReporter extends mocha.reporters.Spec {
+         timestamp = timestamp ? timestamp.toISOString().split('.')[0] : '';
+
+         output.testSuites.push({
+-          package:
+-            suite.file.includes('functional') || suite.file.includes('integration')
+-              ? 'Functional'
+-              : 'Unit',
++          package: suite.file.includes('integration') ? 'Functional' : 'Unit',
+           id,
+           name: className,
+           timestamp,","This is a bit of a throwaway field in the xunit output, it doesn't impact anything on EVG, should we just name it `integration` now?",`functional` or `integration`?
+8593,"@@ -29,6 +29,6 @@ import java.lang.annotation.Target;
+ @Documented
+ @Retention(SOURCE)
+ @Target(TYPE)
+-public @interface SolrSingleThreaded {
++public @interface SolrThreadUnsafe {
+
+ }",Please change the name of the file too.,I wonder if it wouldn't be bet
+8594,"@@ -286,7 +286,7 @@ func inject(args []string) string {
+
+ func init() {
+ 	flag := injectCmd.Flags()
+-	flag.StringVar(&injectCfg.configPath, ""injector-config-path"", ""./tools/actioninjector/gentsfaddrs.yaml"", ""path of config file of genesis transfer addresses"")
++	flag.StringVar(&injectCfg.configPath, ""injector-config-path"", ""./tools/actioninjector.v2/gentsfaddrs.yaml"", ""path of config file of genesis transfer addresses"")
+ 	flag.StringVar(&injectCfg.serverAddr, ""addr"", ""127.0.0.1:14004"", ""target ip:port for grpc connection"")
+ 	flag.Uint64Var(&injectCfg.transferGasLimit, ""transfer-gas-limit"", 20000, ""transfer gas limit"")
+ 	flag.Int64Var(&injectCfg.rawTransferGasPrice, ""transfer-gas-price"", 10, ""transfer gas price"")",line is 161 characters (from `lll`),Shouldn't this still be v2?
+8595,"@@ -195,8 +195,10 @@ module Bolt
+       @outputter.stop_spin
+
+       # Automatically generate types after installing modules
+-      @outputter.print_action_step(""Generating type references"")
+-      @pal.generate_types(cache: true)
++      if ok
++        @outputter.print_action_step(""Generating type references"")
++        @pal.generate_types(cache: true)
++      end
+
+       @outputter.print_puppetfile_result(ok, path, moduledir)
+ ",When is this false?,Style/StringLiterals: Prefer s
+8596,"@@ -540,7 +540,6 @@ Dispose()
+         [InlineData(""${counter}"", DbType.Int16, (short)1)]
+         [InlineData(""${counter}"", DbType.Int32, 1)]
+         [InlineData(""${counter}"", DbType.Int64, (long)1)]
+-        [InlineData(""${counter}"", DbType.Int16, (short)1)]
+         [InlineData(""${counter:norawvalue=true}"", DbType.Int16, (short)1)] //fallback
+         [InlineData(""${counter}"", DbType.VarNumeric, 1, true)]
+         [InlineData(""${counter}"", DbType.AnsiString, ""1"")]",note: also here ;),Why remove this?
+8597,"@@ -145,6 +145,10 @@ public class TemporaryFilesystem {
+   }
+
+   public boolean deleteBaseDir() {
+-    return baseDir.delete();
++    boolean wasDeleted = baseDir.delete();
++    if (wasDeleted) {
++      Runtime.getRuntime().removeShutdownHook(shutdownHook);
++    }
++    return wasDeleted;
+   }
+ }","I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways.",Rather than doin
+8598,"@@ -38,10 +38,15 @@ const kytheExtractionConfigFile = "".kythe-extraction-config""
+ // Repo is a container of input/output parameters for doing extraction on remote
+ // repositories.
+ type Repo struct {
+-	// Clone extracts a copy of the repo to the specified output Directory.
+-	Clone func(ctx context.Context, outputDir string) error
++	// Either GitRepo or LocalRepo should be set, not both.
++	// A remote git repo, e.g. https://github.com/google/kythe.
++	Git string
++	// A local copy of a repository.
++	Local string
++
+ 	// Where to write from an extraction.
+ 	OutputPath string
++
+ 	// An optional path to a file containing a
+ 	// kythe.proto.ExtractionConfiguration encoded as JSON that details how
+ 	// to perform extraction. If this is unset, the extractor will first try","nit: blank between, for consistency.",Should we call t
+8599,"@@ -21,8 +21,10 @@ import java.util.regex.Matcher;
+ /** Utility class for formatting source comments to follow RDoc style. */
+ public class RDocCommentFixer {
+
+-  /** Returns a Sphinx-formatted comment string. */
++  /** Returns a RDoc-formatted comment string. */
+   public static String rdocify(String comment) {
++    // escape '$' in the comment first
++    comment = comment.replaceAll(""\\$"", ""\\\\\\$"");
+     comment = CommentPatterns.BACK_QUOTE_PATTERN.matcher(comment).replaceAll(""+"");
+     comment = rdocifyProtoMarkdownLinks(comment);
+     comment = rdocifyCloudMarkdownLinks(comment);",ditto for RDoc or YARD link,I think we shoul
+8600,"@@ -173,7 +173,7 @@ public class DefaultConditionRunner implements ConditionRunner {
+     }
+
+     protected void log(String message) {
+-      logger.info(new Date() + "" - "" + message);
++      logger.finest(new Date() + "" - "" + message);
+     }
+
+   }",This method is designed to allow the condition runner to tell users something interesting. The current `INFO` log level is correct.,This is the only real change in this file. The rest of the changes are just minor cleanups that I missed.
+8601,"@@ -36,7 +36,7 @@ type Info struct {
+ 	SSLRequired       bool     `json:""ssl_required""` // DEPRECATED: ssl json used for older clients
+ 	TLSRequired       bool     `json:""tls_required""`
+ 	TLSVerify         bool     `json:""tls_verify""`
+-	MaxPayload        int      `json:""max_payload""`
++	MaxPayload        int64    `json:""max_payload""`
+ 	IP                string   `json:""ip,omitempty""`
+ 	ClientConnectURLs []string `json:""connect_urls,omitempty""` // Contains URLs a client can connect to.
+ ","Again, would not change that.",why change this?
+8602,"@@ -98,4 +98,16 @@ public enum Status {
+       return false;
+     }
+   }
++
++  public static boolean isStatusFailed(Status status) {
++    switch (status) {
++      case FAILED:
++      case KILLED:
++      case CANCELLED:
++      case FAILED_FINISHING:
++        return true;
++      default:
++        return false;
++    }
++  }
+ }",Is canceled considered failed?,Can we make this into an enum ?
+8603,"@@ -300,7 +300,7 @@ func TestBrowseJson(t *testing.T) {
+ 		req.Header.Set(""Accept"", ""application/json"")
+ 		rec := httptest.NewRecorder()
+
+-		code, err := b.ServeHTTP(rec, req)
++		code, _ := b.ServeHTTP(rec, req)
+
+ 		if code != http.StatusOK {
+ 			t.Fatalf(""In test %d: Wrong status, expected %d, got %d"", i, http.StatusOK, code)",These ineffectual assignment changes intrigue me. Our CI tests have been checking for these for months; how come the tests haven't been failing? How did you catch these?,Shouldn't we also check the error here?
+8604,"@@ -103,10 +103,15 @@ func TestMintX509CA(t *testing.T) {
+ 			wrapper := Wrap(upstreamCA)
+
+ 			// Request Mint to wrapper
+-			resp, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
++			stream, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
+ 				Csr:          testCase.csr,
+ 				PreferredTtl: testCase.preferredTTL,
+ 			})
++			// Stream returned, and no error expected
++			require.NoError(t, err)
++			require.NotNil(t, stream)
++
++			resp, err := stream.Recv()
+
+ 			// if test case expect an error validates it has expected code and message
+ 			if testCase.err != """" {",We should add an additional call to Recv() somewhere after here that we assert returns io.EOF.,"If the request fails, the error will still be reported and the test will fail. Is this what you were thinking of?"
+8605,"@@ -35,7 +35,8 @@ func setupJournalBlockServerTest(t *testing.T) (
+ 	// Clean up the config if the rest of the setup fails.
+ 	defer func() {
+ 		if !setupSucceeded {
+-			CheckConfigAndShutdown(t, config)
++			ctx := context.Background()
++			CheckConfigAndShutdown(ctx, t, config)
+ 		}
+ 	}()
+ ","Why not return a `ctx` from `setupJournalBlockServerTest` and use it everywhere, like in the other test files? And maybe put a test timeout on it while you're at it? (Same for the other journal test files below.)","[nit] I would prefer if we used `context.Background()` instead of `context.Background()`, unless there's a really"
+8606,"@@ -33,7 +33,17 @@
+
+
+ // ObjectTracker undestroyed objects validation function
+-bool ObjectLifetimes::ReportUndestroyedObjects(VkDevice device, const std::string& error_code) {
++bool ObjectLifetimes::ReportUndestroyedInstanceObjects(VkInstance instance, const std::string& error_code) {
++    bool skip = false;
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeSurfaceKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeSwapchainKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDisplayKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDisplayModeKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDebugReportCallbackEXT, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDebugUtilsMessengerEXT, error_code);
++    return skip;
++}
++bool ObjectLifetimes::ReportUndestroyedDeviceObjects(VkDevice device, const std::string& error_code) {
+     bool skip = false;
+     skip |= DeviceReportUndestroyedObjects(device, kVulkanObjectTypeCommandBuffer, error_code);
+     skip |= DeviceReportUndestroyedObjects(device, kVulkanObjectTypeSemaphore, error_code);",Do we need HeadlessSurface and DisplayPlaneSurface here too?,What's the difference between this function and `ReportUndestroyedObjects`?
+8607,"@@ -473,7 +473,7 @@ describe('GridFS Stream', function () {
+                     // Fail if user tries to abort an aborted stream
+                     uploadStream.abort().then(null, function (error) {
+                       expect(error.toString()).to.equal(
+-                        'MongoDriverError: Cannot call abort() on a stream twice'
++                        'MongoGridFSStreamError: Cannot call abort() on a stream twice'
+                       );
+                       client.close(done);
+                     });",Would it be appropriate for this to be a `MongoStreamClosedError`?,Shouldn't this be `mongodb3fsStreamError`?
+8608,"@@ -26,11 +26,13 @@ import (
+ 	""github.com/golang/glog""
+ 	""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/internalclientset""
++	snapclient ""github.com/openebs/maya/pkg/client/generated/openebs.io/snapshot/v1/clientset/internalclientset""
+ 	""k8s.io/api/admission/v1beta1""
+ 	admissionregistrationv1beta1 ""k8s.io/api/admissionregistration/v1beta1""
+ 	v1 ""k8s.io/api/apps/v1""
+ 	corev1 ""k8s.io/api/core/v1""
+
++	""k8s.io/apimachinery/pkg/api/resource""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/serializer""",Can you raise new issue that talks about refactoring webhook code. It should follow `idiomatic maya` patterns.,"For this file and the rest, I don't think we need `clientset` anymore. Let's remove it."
+8609,"@@ -0,0 +1,9 @@
++using Datadog.Trace.Interfaces;
++
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface ISpanDecorator
++    {
++        void Decorate(ISpan span);
++    }
++}","(Probably repeating myself) Instead of `Datadog.Trace.Interfaces`, should we move this and several other files into a `Datadog.Trace.Decorators` namespace instead?",I'm a little confused by the name. Decorate is not Decorate but just Decorate.
+8610,"@@ -1,6 +1,7 @@
+ # -*- encoding : utf-8 -*-
+ require 'kaminari'
+ require 'rsolr'
++require 'deprecation'
+ module Blacklight
+
+   autoload :Configurable, 'blacklight/configurable'","Should we generate `gem ""rsolr""` into the application Gemfile?",shouldn't this be `require 'rsim'`?
+8611,"@@ -130,6 +130,8 @@ static struct optparse_option attach_opts[] =  {
+     { .name = ""label-io"", .key = 'l', .has_arg = 0,
+       .usage = ""Label output by rank"",
+     },
++    { .name = ""verbose"", .key = 'v', .has_arg = 0,
++      .usage = ""Increase verbosity"" },
+     { .name = ""quiet"", .key = 'q', .has_arg = 0,
+       .usage = ""Suppress warnings written to stderr from flux-job"",
+     },","commit message, ""currently ignored""? (-ed)","nitpick: ""Increase verbosity"" -> ""Increase verbosity"""
+8612,"@@ -37,6 +37,12 @@ module Selenium
+         def bridge_class
+           Bridge
+         end
++
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
+       end # Driver
+     end # Firefox
+   end # WebDriver",Same here. and all others.,Use 2 (not 0) spaces for indenting an expression spanning multiple lines.
+8613,"@@ -25,14 +25,16 @@ namespace Nethermind.Blockchain
+     public class OneTimeChainProcessor : IBlockchainProcessor
+     {
+         private readonly IBlockchainProcessor _processor;
++        private readonly IBlockchainProcessor _mainChainProcessor;
+         private readonly IReadOnlyDbProvider _readOnlyDbProvider;
+
+         private object _lock = new object();
+
+-        public OneTimeChainProcessor(IReadOnlyDbProvider readOnlyDbProvider, IBlockchainProcessor processor)
++        public OneTimeChainProcessor(IReadOnlyDbProvider readOnlyDbProvider, IBlockchainProcessor processor, IBlockchainProcessor mainChainProcessor = null)
+         {
+             _readOnlyDbProvider = readOnlyDbProvider ?? throw new ArgumentNullException(nameof(readOnlyDbProvider));
+             _processor = processor ?? throw new ArgumentNullException(nameof(processor));
++            _mainChainProcessor = mainChainProcessor;
+         }
+
+         public void Start()",can we pass some simple interface instead of a full additional processor? (an imterface with these two events only),Why do you need a separate object for this? The one time chain processor
+8614,"@@ -107,6 +107,8 @@ insert_exit_stub_other_flags(dcontext_t *dcontext, fragment_t *f,
+     /* FIXME i#1575: coarse-grain NYI on ARM */
+     ASSERT_NOT_IMPLEMENTED(!TEST(FRAG_COARSE_GRAIN, f->flags));
+     if (LINKSTUB_DIRECT(l_flags)) {
++        /* We put a NOP here for future linking. */
++        *pc++ = 0xd503201f;
+         /* stp x0, x1, [x(stolen), #(offs)] */
+         *pc++ = (0xa9000000 | 0 | 1 << 10 | (dr_reg_stolen - DR_REG_X0) << 5 |
+                  TLS_REG0_SLOT >> 3 << 15);",Use a named constant,It would be better to use `0xd4fffffff` instead of `0xd503201f`
+8615,"@@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+
+             var stop = Assert.Single(events, e => e.EventName == ""ConnectionStop"");
+             Assert.All(new[] { ""connectionId"" }, p => Assert.Contains(p, stop.PayloadNames));
+-            Assert.Same(KestrelEventSource.Log, stop.EventSource);
++            Assert.Same(KestrelEventSource.Log, stop?.EventSource);
+         }
+
+         private string GetProperty(EventWrittenEventArgs data, string propName)",The `?` is unnecessary since `Assert.Single` will fail if it can't find the stop event.,"Should we also assert that `e.EventName == ""ConnectionStop""`?"
+8616,"@@ -29,6 +29,12 @@ import org.apache.iceberg.StructLike;
+  * Implementations must be {@link Serializable} because instances will be serialized to tasks.
+  */
+ public interface LocationProvider extends Serializable {
++
++  /**
++   * Return a fully-qualified data location.
++   */
++  String dataLocation();
++
+   /**
+    * Return a fully-qualified data file location for the given filename.
+    *",What about providers that don't have a reliable location? Do they return null?,What's the difference between this and `dataLocation()`?
+8617,"@@ -14,9 +14,14 @@
+ // limitations under the License.
+ // </copyright>
+
++using System;
++
+ namespace OpenTelemetry.Metrics
+ {
+     public abstract class MetricProcessor : BaseProcessor<MetricItem>
+     {
++        // GetMetric or GetMemoryState or GetAggregatedMetrics..
++        // ...or some other names
++        public abstract void SetGetMetricFunction(Func<MetricItem> getMetrics);
+     }
+ }","I might not be thinking about things right, but would it make sense for a MetricProcessor to have a handle on the ParentProvider kinda like how we do for traces? That way instead of calling `SetGetMetricFunction(this.Collect)` in the MeterProviderSdk you'd have a handle on the provider to call `Collect` directly.",Shouldn't this be part of the base class?
+8618,"@@ -30,7 +30,8 @@ def check_dynamodb(expect_shutdown=False, print_error=False):
+         # wait for backend port to be opened
+         wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path=""/"", expect_success=False, sleep_time=1)
+         # check DynamoDB
+-        out = aws_stack.connect_to_service(""dynamodb"").list_tables()
++        endpoint_url = f""http://127.0.0.1:{PORT_DYNAMODB_BACKEND}""
++        out = aws_stack.connect_to_service(""dynamodb"", endpoint_url=endpoint_url).list_tables()
+     except Exception as e:
+         if print_error:
+             LOGGER.error(""DynamoDB health check failed: %s %s"" % (e, traceback.format_exc()))","nit: If we want to squeeze out a few more milliseconds from the startup, we may actually be able to remove this line (`wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path=""/"", ...` should already be sufficient to ensure that the service is up and responding to HTTP requests). Thoughts?",Would `http://{PORT_DYNAMODB_BACKEND}/` work too?
+8619,"@@ -4880,7 +4880,7 @@ os_normalized_sysnum(int num_raw, instr_t *gateway, dcontext_t *dcontext)
+         }
+     }
+ #    ifdef X64
+-    if (num_raw >> 24 == 0x2)
++    if (num_raw & SYSCALL_NUM_MARKER_BSD)
+         return (int)(num_raw & 0xffffff); /* Drop BSD bit */
+     else
+         num = (int)num_raw; /* Keep Mach and Machdep bits */",Convention is to use TEST,Is this still relevant with the rest of the changes? If
+8620,"@@ -38,9 +38,9 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
+   """"""
+
+
+-  @unittest.skip(""There are slight differences between implementations that""
+-                 ""prevent this from passing still. See ""
+-                 ""https://github.com/numenta/nupic/issues/2980"")
++  # @unittest.skip(""There are slight differences between implementations that""
++  #                ""prevent this from passing still. See ""
++  #                ""https://github.com/numenta/nupic/issues/2980"")
+   def testTMPyCpp(self):
+     """"""
+     Test compatibility between C++ and Python TM implementation.",Just in case: remember to remove this.,"If you remove the skip, does it mean that you can't run `./test/unittest/unittest.py`?"
+8621,"@@ -61,7 +61,7 @@ public class EIP1559 {
+       final BigInteger target = BigInteger.valueOf(targetGasUsed);
+       final BigInteger denominator = BigInteger.valueOf(feeMarket.getBasefeeMaxChangeDenominator());
+       feeDelta = pBaseFee.multiply(gDelta).divide(target).divide(denominator).longValue();
+-      baseFee = parentBaseFee - feeDelta;
++      baseFee = max(parentBaseFee - feeDelta, 0);
+     }
+     LOG.trace(
+         ""block #{} parentBaseFee: {} parentGasUsed: {} parentGasTarget: {} baseFee: {}"",",I am not certain if this should be 0 or 7 here. I think a basefee under 7 is pathological,Could you explain why this change is needed?
+8622,"@@ -20,6 +20,12 @@ vm[] = {
+ 	.0002908882086657216,
+ 	.0000048481368110953599
+ };
++/* byte sequence for Degree Sign U+00B0 in UTF-8. */
++	static constexpr char
++DEG_SIGN1 = '\xc2';
++	static constexpr char
++DEG_SIGN2 = '\xb0';
++
+ 	double
+ dmstor(const char *is, char **rs) {
+ 	return dmstor_ctx( pj_get_default_ctx(), is, rs );",it would be better to move the declaration of the variable with its initialization at line 68,Isn't UTF-8 correct here? There's no sign U+00B0 in UTF-8. The same sign U+00B0 should
+8623,"@@ -12,6 +12,7 @@
+
+  defined in: Hall and Kier JCICS _35_ 1039-1045 (1995)  Table 1
+ """"""
++import sys
+ from rdkit import Chem
+
+ _rawD = [",I don't think this is required.,Did you mean to add this import here?
+8624,"@@ -48,7 +48,7 @@ func TestSyncServiceContextUpdated(t *testing.T) {
+ 	}
+
+ 	// run the update context call once
+-	err := service.updateContext()
++	err := service.updateEthContext()
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}",This rename should also ideally be in a separate PR.,can we updateEthContext as well?
+8625,"@@ -86,11 +86,14 @@ public final class HttpCall<V> extends Call.Base<V> {
+       if (t != null) {
+         callback.onError(t);
+       } else {
++        V value = null;
+         try {
+-          callback.onSuccess(parseResponse(response, bodyConverter));
+-        } catch (IOException e) {
+-          callback.onError(e);
++          value = parseResponse(response, bodyConverter);
++        } catch (Throwable t1) {
++          propagateIfFatal(t1);
++          callback.onError(t1);
+         }
++        if (value != null) callback.onSuccess(value);
+       }
+       return null;
+     });","Think this needs to go right below line 91. `parseResponse` can return `null` (line 133), which will cause this future to never complete.",`t1` can be `null` here right?
+8626,"@@ -46,8 +46,8 @@ import java.util.List;
+ public class HttpCommandProcessor implements CommandProcessor {
+
+   private String pathToServlet;
+-  private String browserStartCommand;
+-  private String browserURL;
++  private final String browserStartCommand;
++  private final String browserURL;
+   private String sessionId;
+   private String extensionJs;
+   private String rcServerLocation;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,`final` should be at the end of
+8627,"@@ -520,8 +520,7 @@ public class AzkabanWebServer extends AzkabanServer {
+       startWebMetrics();
+     }
+
+-    if(this.props.containsKey(ConfigurationKeys.ENABLE_QUARTZ) && this.props.getBoolean(ConfigurationKeys
+-        .ENABLE_QUARTZ)) {
++    if (this.props.getBoolean(ConfigurationKeys.ENABLE_QUARTZ, false)) {
+       this.quartzScheduler.start();
+     }
+ ","Yeah, why not use this method instead of checking with `containsKey`?",The default value of the `Config
+8628,"@@ -39,9 +39,9 @@ for i in range(loop_num):
+     torch.cuda.synchronize()
+     time_backward += timer.since_last_check()
+     bar.update()
+-print('\nCARAFE time forward: {} ms/iter | time backward: {} ms/iter'.format(
+-    (time_forward + 1e-3) * 1e3 / loop_num,
+-    (time_backward + 1e-3) * 1e3 / loop_num))
++print(f'\nCARAFE time forward: {(time_forward + 1e-3) * 1e3 / loop_num} '
++      f'ms/iter | time backward: {(time_backward + 1e-3) * 1e3 / loop_num}'
++      ' ms/iter')
+
+ time_naive_forward = 0
+ time_naive_backward = 0",Compute `(time_forward + 1e-3) * 1e3 / loop_num` ahead.,hmm can we use f-strings now?
+8629,"@@ -74,18 +74,13 @@ namespace NLog.Internal
+                     throw;
+                 }
+
+-                if (LogManager.ThrowExceptions)
+-                {
+-                    throw;
+-                }
+-
+                 ReportExceptionInHandler(ex);
+             }
+         }
+
+         private static void ReportExceptionInHandler(Exception exception)
+         {
+-            InternalLogger.Error(""Exception in asynchronous handler {0}"", exception);
++            InternalLogger.Error(exception, ""Exception in asynchronous handler."");
+         }
+     }
+ }","Mh... `MustBeRethrown()` above already logs `ex`, so `ex` will be logged here for the second time. I think this line must be moved to before `MustBeRethrown()`.",LogManager.ThrowExceptions is
+8630,"@@ -29,11 +29,13 @@ import java.util.Map;
+  */
+ public class CommonDiscoveryProvider implements DiscoveryProvider {
+   private final DiscoveryContext context;
+-  private final SnippetSetRunner<Method> snippetSetRunner;
++  private final SnippetSetRunner.Generator<Method> snippetSetRunner;
+   private final String snippetFileName;
+
+   public CommonDiscoveryProvider(
+-      DiscoveryContext context, SnippetSetRunner<Method> snippetSetRunner, String snippetFileName) {
++      DiscoveryContext context,
++      SnippetSetRunner.Generator<Method> snippetSetRunner,
++      String snippetFileName) {
+     this.context = context;
+     this.snippetSetRunner = snippetSetRunner;
+     this.snippetFileName = snippetFileName;","Since this never changes, why not pass it into the constructor instead?",Nit: I think the parameters s
+8631,"@@ -48,10 +48,10 @@ namespace Nethermind.Synchronization.BeamSync
+
+         private readonly ISyncModeSelector _syncModeSelector;
+
+-        private readonly Func<bool> _writeThrough;
+-
+         private ILogger _logger;
+
++        private IDb _targetDbForSaves;
++
+         public BeamSyncDb(IDb stateDb, IDb tempDb, ISyncModeSelector syncModeSelector, ILogManager logManager)
+             : base(logManager)
+         {",this is critical to avoid state root saving from beam,I think this should be named:
+8632,"@@ -231,7 +231,8 @@ class AnchorHead(nn.Module):
+         # map up to original set of anchors
+         if unmap_outputs:
+             num_total_anchors = flat_anchors.size(0)
+-            labels = unmap(labels, num_total_anchors, inside_flags)
++            labels = unmap(labels, num_total_anchors, inside_flags,
++                           self.num_classes)  # fill bg label
+             label_weights = unmap(label_weights, num_total_anchors,
+                                   inside_flags)
+             bbox_targets = unmap(bbox_targets, num_total_anchors, inside_flags)","To make it more clear, `fill=self.num_classes`.",I think there is a bug here. It should be `labels[0]` instead of `self.num_classes`
+8633,"@@ -78,6 +78,11 @@ type Message struct {
+ 	AfterSend func(asFunc func(interface{}) bool) error
+ }
+
++// Implement batcher item for byte sized based batching
++func (m *Message) ByteSize() int {
++	return len(m.Body)
++}
++
+ // Topic publishes messages.
+ // Drivers may optionally also implement io.Closer; Close will be called
+ // when the pubsub.Topic is Shutdown.","Nit: ""ByteSize estimates the size in bytes of the message for the purpose of restricting batch sizes.""","Perhaps this needs a different name, like `ByteSizeForMessage`."
+8634,"@@ -61,9 +61,11 @@ namespace SampleApp
+
+                     // The following section should be used to demo sockets
+                     //options.ListenUnixSocket(""/tmp/kestrel-test.sock"");
+-
++                })
++                .UseLibuv(options =>
++                {
+                     // Uncomment the following line to change the default number of libuv threads for all endpoints.
+-                    //options.ThreadCount = 4;
++                    options.ThreadCount = 4;
+                 })
+                 .UseContentRoot(Directory.GetCurrentDirectory())
+                 .UseStartup<Startup>()",It's weird to have this on the same level as kestrel. This needs to move to options.,Can we just make this `options.ThreadCount = 1`?
+8635,"@@ -476,7 +476,11 @@ module.exports = class Webcam extends Plugin {
+   }
+
+   getVideo () {
+-    const mimeType = this.recordingChunks[0].type
++    // Sometimes in iOS Safari, Blobs (especially the first Blob in the recordingChunks Array)
++    // have empty 'type' attributes (e.g. '') so we need to find a Blob that has a defined 'type'
++    // attribute in order to determine the correct MIME type.
++    const mimeType = this.recordingChunks.find(blob => blob.type?.length > 0).type
++
+     const fileExtension = getFileTypeExtension(mimeType)
+
+     if (!fileExtension) {",is it safe for us to use the `blob.type?.length` optional chaining with IE11 support? @goto-bus-stop,Why not use `this.recordingChunks.every(blob => blob.type?.length > 0)`?
+8636,"@@ -125,13 +125,14 @@ class User < ActiveRecord::Base
+   # @param new_organisation_id [Integer] the id for an organisation
+   # @return [String] the empty string as a causality of setting api_token
+   def org_id=(new_org_id)
++    puts ""$$$$ new_org_id: #{new_org_id}""
+     unless self.can_change_org? || new_org_id.nil? || self.org.nil? || (new_org_id.to_s == self.org.id.to_s)
+       # rip all permissions from the user
+       self.perms.delete_all
+     end
+     # set the user's new organisation
+     super(new_org_id)
+-    self.save!
++    # self.save!
+     # rip api permissions from the user
+     self.remove_token!
+   end",remove this debug statement,Do we need this?
+8637,"@@ -2357,7 +2357,12 @@ bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer com
+
+     VkImageAspectFlags legal_aspect_flags =
+         VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
+-    if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
++    // YCbCr is core after 1.1
++    if (api_version >= VK_API_VERSION_1_1) {
++        legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT);
++    }
++    // If physical device does not support 1.1, check for YCbCr extension support
++    else if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
+         legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
+     }
+ ","This should not be needed. 1) all 1.1 promoted extensions are marked as enabled when a 1.1 device is created (which happens iff both physical device support and apiVersion are set to 1.1) 2) The KHR and non-KHR versions of the bits are aliases of each other, so no different set is required.",Doesn't this nee
+8638,"@@ -656,7 +656,11 @@ static void makeflow_node_complete(struct dag *d, struct dag_node *n, struct bat
+
+ 	struct list *outputs = makeflow_generate_output_files(n, wrapper, monitor);
+
+-	if(info->exited_normally && info->exit_code == 0) {
++
++	if(getenv(""CCTOOLS_LOOP_DEV_FULL"")) {
++		job_failed = 1;
++	}
++	else if(info->exited_normally && info->exit_code == 0) {
+ 		list_first_item(outputs);
+ 		while((f = list_next_item(outputs))) {
+ 			if(!makeflow_node_check_file_was_created(n, f))","I can see why you did it this way, but let's not get into the habit of passing information back via an environment variable. Add an element to `batch_job_info` instead, which is where we send back detailed info about jobs.",This seems to be
+8639,"@@ -438,7 +438,11 @@ function diffElementNodes(
+ 			if (
+ 				'value' in newProps &&
+ 				(i = newProps.value) !== undefined &&
+-				i !== dom.value
++				// #2756 For the <progress>-element the initial value is 0,
++				// despite the attribute not being present. When the attribute
++				// is missing the progress bar is treated as indeterminate.
++				// To fix that we'll always update it when it is 0 for progress elements
++				(i !== dom.value || (newVNode.type === 'progress' && !i))
+ 			) {
+ 				setProperty(dom, 'value', i, oldProps.value, false);
+ 			}","Turns out my previous fix of doing `!dom.hasAttribute('value')` is not a good one as it leads to all input values always being updated. The new fix only updates it, despite `dom.value === props.value` when the value is `0` for progress elements.",It's not clear t
+8640,"@@ -3,6 +3,7 @@
+ #include <cmath>
+ #include <cstdio>
+ #include <ctime>
++#include <vector>
+
+ #include ""caffe/common.hpp""
+ #include ""caffe/util/rng.hpp""",Why is this being added here? Is this relevant to these changes?,These includes don't seem necessary.
+8641,"@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
+           getClass().getClassLoader())
+           .asSubclass(Routable.class);
+       Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
+-      LOG.info(""Bound legacy RC support"");
++      LOG.finest(""Bound legacy RC support"");
+       return constructor.newInstance(sessions);
+     } catch (ReflectiveOperationException e) {
+       // Do nothing.",This informational message is important to users. Please leave.,We should keep this at info as this
+8642,"@@ -0,0 +1,4 @@
++All unapproved FY15 credit card funding requests are being cancelled.
++If the need still exists, please submit a new FY16 funding request.
++
++<%= url_for(controller: 'proposals', action: 'show', id: @proposal.id) %>",why isn't rubocop failing for single quotes?,I'm not sure if this is a good idea
+8643,"@@ -36,14 +36,10 @@ class StatusAttributeDataSetQueryBuilder extends AbstractAttributeDataSetBuilder
+     {
+         $query->addSelect(sprintf(
+             '(
+-                SELECT value FROM product_value pv
+-                JOIN value_translation vt ON vt.value_id = pv.value_id
+-                WHERE pv.attribute_id = \'%s\'
+-                AND pv.product_id = p.id
+-                AND vt.language IS NULL
++                SELECT status_id FROM product_workflow_status pws
++                WHERE pws.product_id = p.id
+                 LIMIT 1
+             ) AS ""%s""',
+-            $attribute->getId()->getValue(),
+             $key
+         ));
+     }",Is `WHERE` should `Language` param ?,revert this line
+8644,"@@ -46,6 +46,7 @@ namespace oneapi::dal::basic_statistics::backend {
+ namespace de = dal::detail;
+ namespace be = dal::backend;
+ namespace pr = dal::backend::primitives;
++namespace ps = oneapi::dal::preview::spmd;
+
+ using alloc = sycl::usm::alloc;
+ ","ps - first letter from preview, when we move it into public it will not be relevant. my suggestion is spmd or ds(distributed)",Can we move this to `preview.cpp`?
+8645,"@@ -1757,7 +1757,18 @@ class Frame(object, metaclass=ABCMeta):
+         2  6  30   30
+         3  7  40   50
+         """"""
+-        return self._apply_series_op(lambda kser: kser._with_new_scol(F.abs(kser.spark.column)))
++
++        def abs(kser):
++            if isinstance(kser.spark.data_type, BooleanType):
++                return kser
++            elif isinstance(kser.spark.data_type, NumericType):
++                return kser.spark.transform(F.abs)
++            else:
++                raise TypeError(
++                    ""bad operand type for abs(): {}"".format(kser.spark.data_type.simpleString())
++                )
++
++        return self._apply_series_op(abs)
+
+     # TODO: by argument only support the grouping name and as_index only for now. Documentation
+     # should be updated when it's supported.","Hm, should we show pandas' dtype instead of Spark data type?",Why we need this function?
+8646,"@@ -23,10 +23,13 @@ namespace OpenTelemetry.Metrics
+     {
+         /*
+         Type:
+-            0x10: Sum
+-            0x20: Gauge
+-            0x30: Histogram
+-            0x40: Summary (reserved)
++            0x10 0b00010000: Sum
++            0x20 0b00100000: Gauge
++            0x40 0b01000000: Histogram
++            0x50 0b01010000: HistogramWithBuckets
++            0x60 0b01100000: HistogramWithMinMax
++            0x70 0b01110000: HistogramWithMinMaxAndBuckets
++            0x80 0b10000000: Summary (reserved)
+
+         Point kind:
+             0x04: I1 (signed 1-byte integer)","@reyang when exponentialhistogram arrives, we won't have any bits left for it.. unless we take Summary or make this 16 bits instead of current 8 bytes",HistogramWithMinMaxAndBuckets seem
+8647,"@@ -2,6 +2,8 @@
+
+ class PdoStatement {
+     /**
++     * @psalm-taint-sink text $class
++     *
+      * @template T
+      * @param class-string<T> $class
+      * @return false|T",This change is not tested.. I guess this is how these taint-annotations work..?,this should also be added to `@psa
+8648,"@@ -485,6 +485,14 @@ class ConfigOverrider(object):
+
+         dest.dump()
+
++    def __apply_mult_override(self, obj, key, replace_value):
++        for k, v in obj.items():
++            if isinstance(v, dict):
++                obj[k] = self.__apply_mult_override(v, key, replace_value)
++        if key in obj:
++            obj[key] = replace_value
++        return obj
++
+     def __apply_single_override(self, dest, name, value):
+         """"""
+         Apply single override",Fails if obj is list. Please fix!,<!--new_thread; commit:3e95b6995f0b88a53930c30459c8d81e6692219; resolved:0--> I think it would be better to return the original object without modifying the original.
+8649,"@@ -28,5 +28,16 @@ class TestInstanceStatusResponseParsing(unittest.TestCase):
+         self.assertEqual(all_statuses.next_token, 'page-2')
+
+
++    def test_include_all_instances(self):
++        ec2 = EC2Connection(aws_access_key_id='aws_access_key_id',
++                            aws_secret_access_key='aws_secret_access_key')
++        mock_response = mock.Mock()
++        mock_response.read.return_value = INSTANCE_STATUS_RESPONSE
++        mock_response.status = 200
++        ec2.make_request = mock.Mock(return_value=mock_response)
++        all_statuses = ec2.get_all_instance_status(include_all_instances=True)
++        self.assertEqual(all_statuses.next_token, 'page-2')
++
++
+ if __name__ == '__main__':
+     unittest.main()",Could you add an assertion to make sure the `IncludeAllInstances` parameter is actually set and passed to the request?,"`self.assertEqual(all_statuses.next_token, 'page-2')`?"
+8650,"@@ -79,7 +79,8 @@ def __get_analyzer_version(context, analyzer_config_map):
+         version = [analyzer_bin, u' --version']
+         try:
+             output = subprocess.check_output(shlex.split(' '.join(version)),
+-                                             env=check_env)
++                                             env=check_env,
++                                             universal_newlines=True)
+             versions[analyzer_bin] = output
+         except (subprocess.CalledProcessError, OSError) as oerr:
+             LOG.warning(""Failed to get analyzer version: %s"",","The name of this argument is not too intuitive. The point is, these kind of subprocess calls will return `str`s in Python2 and 'byte`s in Python3. It would be a lot of work to make CodeChecker handle both `str` and `byte` everywhere. Using the `universal_newlines` argument, we can force Python3 to return text rather then bytes.",Why is it necessary to set `universal_newlines` to True?
+8651,"@@ -63,7 +63,7 @@ func toProtoDomainReplicationConfiguration(in *shared.DomainReplicationConfigura
+ 	}
+ 	return &common.DomainReplicationConfiguration{
+ 		ActiveClusterName: in.GetActiveClusterName(),
+-		Clusters:          toProtoClusterReplicationConfigurations(in.Clusters),
++		Clusters:          toProtoClusterReplicationConfigurations(in.GetClusters()),
+ 	}
+ }
+ ",These `Get`s are just cosmetic changes for consistency.,rename to `ToProtoClusterReplicationConfigurations`
+8652,"@@ -55,13 +55,7 @@ def test_read_yaml(tmpdir):
+     assert parsed_string == parsed_path_obj
+
+
+-def test_yaml_has_comments(tmpdir):
+-    no_comments_yaml = """"""blah: foo\nfizz: boop""""""
+-
+-    assert not util.yaml_has_comments(util.read_yaml(no_comments_yaml))
+-    assert util.yaml_has_comments(util.read_yaml(TEST_YAML))
+-
+-
++@pytest.mark.skip(reason=""Broken due to yaml safe load"")
+ def test_read_yaml_exec_flaw(capfd):
+     # We don't execute anything remote, but someone could give a bad build.yml..
+     util.read_yaml(""""""!!python/object/apply:os.system\nargs: ['echo arbitrary code execution!']"""""")","We should never skip unit tests, but instead fix them. Look at `pytest.raises` for cases where we expect an exception.","If this is broken, could we file a bug so that we can re-enable this test?"
+8653,"@@ -79,11 +79,15 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
+         {
+             Log.LogMessage(MessageImportance.Low, $""START pushing items to feed"");
+-            Random rnd = new Random();
+
+-            try
++            if (!items.Any())
+             {
++                Log.LogMessage(""No items to push found in the items list."");
++                return true;
++            }
+
++            try
++            {
+                 bool result = await PushAsync(items.ToList(), allowOverwrite);
+                 return result;
+             }",Do we need to call ToList here?,It would be nice if these were ordered in the same order they were passed
+8654,"@@ -5,5 +5,8 @@ class EpisodesController < ApplicationController
+
+   def show
+     @episode = Episode.find(params[:id])
++    if topic = @episode.topics.first
++      @products = topic.products.ordered
++    end
+   end
+ end","I think this can be moved into the model, at the very least, but I also think you might be able to do a has many through.",Style/GuardClause: Use a guard clause instead of wrapping the code inside
+8655,"@@ -785,7 +785,7 @@ public interface Tree<T> extends Traversable<T> {
+             if (tree.isLeaf()) {
+                 return value;
+             } else {
+-                return String.format(""(%s %s)"", value, tree.getChildren().map(Node::toLispString).mkString("" ""));
++                return ""("" + value + "" "" + (tree.getChildren().map(Node::toLispString).mkString("" "")) + "")"";
+             }
+         }
+ ",could you please separate computations from string concatenation?,I think this should be `String.format`.
+8656,"@@ -216,8 +216,8 @@ namespace Microsoft.Rest.Generator.Tests
+
+             var type = clientModel.ModelTypes.First();
+
+-            Assert.Equal(""code"", type.Properties[0].Name);
+-            Assert.Equal(""message"", type.Properties[1].Name);
++            Assert.Equal(""errorCode"", type.Properties[0].Name);
++            Assert.Equal(""errorMessage"", type.Properties[1].Name);
+             Assert.Equal(""parentError"", type.Properties[2].Name);
+         }
+ ",@NiklasGustafsson - I had to make these changes for the x-ms-client-name extension tests for java and python. The tests were expecting wire format instead of the client name. Hence modified them appropriately. Let me know what you think ?,why are these changing?
+8657,"@@ -59,6 +59,13 @@ static int on_req(h2o_handler_t *_self, h2o_req_t *req)
+         authority = &self->upstream.authority;
+     }
+
++    /* rewrite headers */
++    if (self->config.header_cmds.size != 0) {
++        h2o_headers_command_t *cmd;
++        for (cmd = self->config.header_cmds.entries; cmd->cmd != H2O_HEADERS_CMD_NULL; ++cmd)
++            h2o_rewrite_headers(&req->pool, &req->headers, cmd);
++    }
++
+     /* request reprocess */
+     h2o_reprocess_request(req, req->method, scheme, *authority,
+                           h2o_build_destination(req, self->upstream.path.base, self->upstream.path.len, 0), overrides, 0);","Could we just set the list of header modification commands to `req->overrides` and apply them only when the request is sent upstream in lib/core/proxy.c? The reason I ask is because an upstream server (accessed using the modified headers) might return 399. In such case, the request would be delegated to the next handler. I think that the headers of the original request should be passed to the next handler, since per my understanding the intended behavior of `proxy.header.*` is to modify the headers passed to the upstream server only.",(style) code indent sho
+8658,"@@ -214,6 +214,12 @@ type Table struct {
+ 	// to top-level chains.
+ 	insertMode string
+
++	// Record when we did our most recent updates and refreshes of the table.  We use these to
++	// calculate the next time we should force a refresh.
++	lastUpdateTime  time.Time
++	lastRefreshTime time.Time
++	refreshInterval time.Duration
++
+ 	logCxt *log.Entry
+
+ 	gaugeNumChains        prometheus.Gauge","Can we rename 'refresh' to 'read' and 'update' to 'write'? Until I had read more of the code below, I couldn't tell the difference between 'update' and 'refresh'.",What is the difference
+8659,"@@ -76,7 +76,7 @@ export default class VerdaccioProcess implements IServerProcess {
+     });
+
+     this.childFork.on('error', (err) => {
+-      console.log('error process', err);
++      // console.log('error process', err);
+       reject([err, this]);
+     });
+ ",can we remove it ?,please remove this
+8660,"@@ -228,4 +228,17 @@ NAString ComConvertTrafNameToNativeName(
+   return convertedName;
+ }
+
++NABoolean ComTrafReservedColName(
++     const NAString &colName)
++{
++
++  if ((colName == TRAF_SALT_COLNAME) ||
++      (colName == TRAF_SYSKEY_COLNAME))
++    return TRUE;
+
++  if ((memcmp(colName.data(), TRAF_DIVISION_COLNAME_PREFIX, strlen(TRAF_DIVISION_COLNAME_PREFIX)) == 0) &&
++      (colName.data()[colName.length()-1] == '_'))
++    return TRUE;
++
++  return FALSE;
++}","I take it that by the time we get here, colName has already been case-shifted to upper case?",Please use `strtok()` instead of `memcmp()`
+8661,"@@ -126,11 +126,14 @@ func ResponseHeaders(h *map[string]string) CallOption {
+ 	return CallOption{func(o *OutboundCall) { o.responseHeaders = h }}
+ }
+
+-// TODO(abg): Example tests to document the different options
+-
+-// WithHeader adds a new header to the request.
++// WithHeader adds a new header to the request. Header keys are case
++// insensitive.
++//
++// 	_, err := client.GetValue(ctx, reqBody, yarpc.WithHeader(""Token"", ""10""))
++// 	// ==> {""token"": ""10""}
+ //
+-// 	resBody, err := client.GetValue(ctx, reqBody, yarpc.WithHeader(""Token"", ""10""))
++// If multiple entries have the same normalized header name, newer entries
++// override older ones.
+ func WithHeader(k, v string) CallOption {
+ 	return CallOption{func(o *OutboundCall) {
+ 		o.headers = append(o.headers, keyValuePair{k: k, v: v})",Super clear desc - thx.,"Shouldn't this be ""If multiple entries have"
+8662,"@@ -3551,7 +3551,11 @@ void SwiftASTContext::LoadModule(swift::ModuleDecl *swift_module,
+         all_dlopen_errors.GetData());
+   };
+
+-  swift_module->collectLinkLibraries(addLinkLibrary);
++  swift_module->forAllVisibleModules(
++      {}, [&](swift::ModuleDecl::ImportedModule import) {
++        import.second->collectLinkLibraries(addLinkLibrary);
++        return true;
++      });
+   error = current_error;
+ }
+ ","Ahh the correct fix is to call `collectLinkLibraries` on the SourceFile being compiled, not the module. Sorry for our mistake!",nitpick: no need for `&` here
+8663,"@@ -64,6 +64,7 @@ func TestConfigDefault(t *testing.T) {
+ 		""Default TaskMetadataSteadyStateRate is set incorrectly"")
+ 	assert.Equal(t, DefaultTaskMetadataBurstRate, cfg.TaskMetadataBurstRate,
+ 		""Default TaskMetadataBurstRate is set incorrectly"")
++	assert.False(t, cfg.SharedVolumeMatchFullConfig, ""Default SharedVolumeMatchFullConfig set incorrectly"")
+ }
+
+ // TestConfigFromFile tests the configuration can be read from file",Can you also modify the `TestEnvironmentConfig` in `config_test.go` to cover this?,this is an unrelated change
+8664,"@@ -120,8 +120,12 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
+             }
+             restClient.sendAsync(request, new RestClient.AsyncRequestCallback() {
+
++                // TODO: Remove onSuccess for 9.0 Release.
+                 @Override
+-                public void onSuccess(RestRequest request, RestResponse response) {
++                public void onSuccess(RestRequest request, RestResponse response) {}
++
++                @Override
++                public void onResponse(RestRequest request, RestResponse response) {
+                     try {
+                         // Not a 2xx status
+                         if (!response.isSuccess()) {","There's no point ""deprecating"" this interface method (the customer still has to implement the new callback that we have introduced which makes it a breaking change). I'd make an exception and simply rename it to `onResponse`.","This is not related to this PR, but why do we not also use `onResponse` in the `AsyncRequestCallback`?"
+8665,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,"This should not be finest, it just logs a warning. If you want to look at the source of the warning, y"
+8666,"@@ -40,6 +40,8 @@ THE SOFTWARE.
+ #include ""hip_hcc_internal.h""
+ #include ""trace_helper.h""
+
++//TODO Add support for multiple modules
++static std::unordered_map<std::string, uintptr_t> coGlobals;
+ //TODO Use Pool APIs from HCC to get memory regions.
+
+ #include <cassert>",I know this is not new here but we need to remove this global or protect access from multiple threads.,@jackhorton Is this `coGlobals` for the module list? I don't see it used anywhere.
+8667,"@@ -30,13 +30,13 @@ namespace OpenTelemetry.Trace
+         /// Enables HttpClient and HttpWebRequest instrumentation.
+         /// </summary>
+         /// <param name=""builder""><see cref=""TracerProviderBuilder""/> being configured.</param>
+-        /// <param name=""configureHttpClientInstrumentationOptions"">HttpClient configuration options.</param>
+         /// <param name=""configureHttpWebRequestInstrumentationOptions"">HttpWebRequest configuration options.</param>
++        /// <param name=""configureHttpClientInstrumentationOptions"">HttpClient configuration options.</param>
+         /// <returns>The instance of <see cref=""TracerProviderBuilder""/> to chain the calls.</returns>
+         public static TracerProviderBuilder AddHttpClientInstrumentation(
+             this TracerProviderBuilder builder,
+-            Action<HttpClientInstrumentationOptions> configureHttpClientInstrumentationOptions = null,
+-            Action<HttpWebRequestInstrumentationOptions> configureHttpWebRequestInstrumentationOptions = null)
++            Action<HttpWebRequestInstrumentationOptions> configureHttpWebRequestInstrumentationOptions = null,
++            Action<HttpClientInstrumentationOptions> configureHttpClientInstrumentationOptions = null)
+ #else
+         /// <summary>
+         /// Enables HttpClient instrumentation.","Doesn't seem any less confusing or error-prone to me. IMO the solution is to not use ""object"" in the enrich callback signatures. Type safety/compile-time checking is our friend!",Why do we need to change from `HttpClientInstrumentationOptions` to `HttpClientOptions`?
+8668,"@@ -19,6 +19,9 @@ module Travis
+         def export
+           super
+           sh.export 'TRAVIS_GO_VERSION', go_version, echo: false
++          sh.if '-z $GOMAXPROCS' do
++            sh.export 'GOMAXPROCS', '2', echo: true
++          end
+         end
+
+         def prepare",I think this should be `GOMAXPROCS=$(nproc 2>/dev/null || echo 2)`,What is the `-z` for?
+8669,"@@ -175,8 +175,9 @@ func (ctx *rollDPoSCtx) validateProposeBlock(blk Block, expectedProposer string)
+ 		errorLog.Msg(""error when validating the block signature"")
+ 		return false
+ 	}
+-	if producer == ctx.addr.RawAddress {
+-		// If the block is self proposed, skip validation
++	// TODO: in long term, block in process and after process should be represented differently
++	if producer == ctx.addr.RawAddress && block.WorkingSet != nil {
++		// If the block is self proposed and working set is not nil (meaning not obtained from wire), skip validation
+ 		return true
+ 	}
+ 	containCoinbase := true",Can we log if this actually happens.,If the proposed block
+8670,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression.",Why don't you use `fi
+8671,"@@ -1,8 +1,10 @@
+ /* eslint-disable no-restricted-globals */
+ /* global __STORYBOOK_CLIENT_API__ */
++
+ /**
+  * External dependencies
+  */
++import lodash from 'lodash';
+ import React from 'react';
+ import { addDecorator, configure } from '@storybook/react';
+ ",It looks like the import format was only changed from one-per-line to all on one line here. Can we keep it as it was so it's easier to see what changed? It's also more consistent with how we format multiple imports in other components.,Nit: `from 'lodash'`
+8672,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?,Is there a reason why you changed from `Selenium::WebDriver::OSSBridge` to `Selenium::WebDriver::W3CBridge`?
+8673,"@@ -5,12 +5,16 @@ import android.content.SharedPreferences;
+ import android.graphics.Color;
+ import android.os.StrictMode;
+ import android.preference.PreferenceManager;
++import android.util.Log;
+
++import org.json.JSONException;
++import org.json.JSONObject;
+ import org.mozilla.geckoview.GeckoSessionSettings;
+ import org.mozilla.telemetry.TelemetryHolder;
+ import org.mozilla.vrbrowser.BuildConfig;
+ import org.mozilla.vrbrowser.R;
+ import org.mozilla.vrbrowser.telemetry.TelemetryWrapper;
++import org.mozilla.vrbrowser.ui.widgets.WidgetPlacement;
+ import org.mozilla.vrbrowser.utils.DeviceType;
+ import org.mozilla.vrbrowser.utils.LocaleUtils;
+ import org.mozilla.vrbrowser.utils.StringUtils;",Looks like `org.json.*` can be removed?,"Not used, remove"
+8674,"@@ -890,7 +890,9 @@ public enum WidgetInfo
+ 	SECOND_TRADING_WITH_MY_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_MY_ITEMS),
+ 	SECOND_TRADING_WITH_THEIR_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_THEIR_ITEMS),
+
+-	GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIMER_GROUP_ID, WidgetID.GauntletTimer.CONTAINER);
++	GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIMER_GROUP_ID, WidgetID.GauntletTimer.CONTAINER),
++	GAUNTLET_MAP(WidgetID.GAUNTLET_MAP_GROUP_ID, WidgetID.GauntletMap.CONTAINER),
++	;
+
+ 	private final int groupId;
+ 	private final int childId;",remove the extra comma and newline,"I think this is a mistake, it should be `GAUNTLET_MAP_GROUP_ID`"
+8675,"@@ -1,3 +1,5 @@
++<% @page_title = t('blacklight.saved_searches.page_title', :application_name => application_name) %>
++
+ <div id=""content"" class=""col-md-9"">
+
+ <h1 class='page-heading'><%= t('blacklight.saved_searches.title') %></h1>",Can we try to use Ruby 1.9-style hashes?,Please use the new hash syntax `application_name: application_name`
+8676,"@@ -120,6 +120,17 @@ func RegisterHandlerDirective(dir string, setupFunc UnmarshalHandlerFunc) {
+ 	})
+ }
+
++// RegisterGlobalOption registers a unique global option opt with
++// an associated unmarshaling (setup) function. When the global
++// option opt is encountered in a Caddyfile, setupFunc will be
++// called to unmarshal its tokens.
++func RegisterGlobalOption(opt string, setupFunc UnmarshalGlobalFunc) {
++	if _, ok := registeredGlobalOptions[opt]; ok {
++		panic(""global option "" + opt + "" already registered"")
++	}
++	registeredGlobalOptions[opt] = setupFunc
++}
++
+ // Helper is a type which helps setup a value from
+ // Caddyfile tokens.
+ type Helper struct {","Terminology question - these are called ""global options"" in the code, but the parallel non-global versions of these are called ""directives""... Should this be `RegisterGlobalDirective`? Or does that have different semantics?","Could we make this simpler? RegisterGlobalOption is supposed to be idempotent, so there's no reason to panic here."
+8677,"@@ -244,7 +244,7 @@ def isTypingProtected():
+ @rtype: boolean
+ """"""
+ 	focusObject=getFocusObject()
+-	if focusObject and (controlTypes.STATE_PROTECTED in focusObject.states or focusObject.role==controlTypes.ROLE_PASSWORDEDIT):
++	if focusObject and focusObject.isProtected:
+ 		return True
+ 	else:
+ 		return False","I do not care much, but you could as well just return bool(focusObject and focusObject.isProtected) here and avoid the if check? I know, really trivial.","This is wrong: if focusObject is not protected, we can't assume that it's a protected control."
+8678,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked",Is there a test that checks whether a button is disabled?
+8679,"@@ -50,7 +50,7 @@ public class GoLanguageProvider {
+
+   @SuppressWarnings(""unchecked"")
+   public <Element> GeneratedResult generate(
+-      Element element, SnippetDescriptor snippetDescriptor, GoGapicContext context) {
++      Element element, SnippetDescriptor snippetDescriptor, Object context) {
+     GoSnippetSet<Element> snippets =
+         SnippetSet.createSnippetInterface(
+             GoSnippetSet.class,","Do DiscoveryContext and GoGapicContext have a more specific common ancestor than Object? If so, let's use that.","I don't understand the purpose of this change, is there a reason you chose this way?"
+8680,"@@ -119,7 +119,7 @@ module Beaker
+           :timeout              => 300,
+           :fail_mode            => 'slow',
+           :timesync             => false,
+-          :disable_iptables     => true,
++          :disable_iptables     => false,
+           :repo_proxy           => false,
+           :package_proxy        => false,
+           :add_el_extras        => false,",is this the intended behavior now?,This seems to be the only place where :disable_iptables is used.
+8681,"@@ -27,6 +27,5 @@ public class TestDutchIJ extends StemmerTestBase {
+   public void testStemming() {
+     assertStemsTo(""ijs"", ""ijs"");
+     assertStemsTo(""IJs"", ""ijs"");
+-    assertStemsTo(""Ijs"");
+   }
+ }","Hunspell/C++ stems that a bit differently from Lucene, but in a controversial way, so I removed the check instead of changing the expectation",What's the reasoning behind this change?
+8682,"@@ -172,7 +172,7 @@ func (o *opt) close() {
+ func (o *opt) runInitOnce() {
+ 	o.initOnce.Do(func() {
+ 		o.clock = &libkbfs.TestClock{}
+-		o.clock.Set(time.Unix(0, 0))
++		o.clock.Set(time.Unix(1, 0))
+ 		o.users = o.engine.InitTest(o.ver, o.blockSize,
+ 			o.blockChangeSize, o.batchSize, o.bwKBps, o.timeout, o.usernames,
+ 			o.teams, o.implicitTeams, o.clock, o.journal)",I'm curious why this is needed?,Does this need to be set at all?
+8683,"@@ -742,7 +742,7 @@ void Combat::doCombat(Creature* caster, Creature* target) const
+ 			}
+ 			*/
+
+-			if (caster && params.distanceEffect != CONST_ANI_NONE) {
++			if (caster && target && params.distanceEffect != CONST_ANI_NONE) {
+ 				addDistanceEffect(caster, caster->getPosition(), target->getPosition(), params.distanceEffect);
+ 			}
+ 		}","I do not see how that changes anything, as the target is operated on many times before that line?",May as well change this to `target->getPosition()`.
+8684,"@@ -513,7 +513,7 @@ $(document).ready(function() {
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-geo"", url: ""#/analytics/geo"", text: ""sidebar.analytics.geo"", priority: 30});
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-sessions"", url: ""#/analytics/sessions"", text: ""sidebar.analytics.session"", priority: 20});
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-users"", url: ""#/analytics/users"", text: ""sidebar.analytics.users"", priority: 10});
+-        app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-loyalty"", url: ""#/analytics/loyalty"", text: ""sidebar.analytics.user-loyalty"", priority: 15});
++        app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-loyalty"", url: ""#/analytics/loyalty"", text: ""sidebar.analytics.visitor-loyalty"", priority: 15});
+     }
+
+     app.addAppSwitchCallback(function(appId) {",Same user/visitor thing.,"I don't think we should change the priority in this app. It will break existing setups, so we should keep it to 15."
+8685,"@@ -167,6 +167,13 @@ exit /B %errorlevel%
+             reg_query_command = %Q(reg query ""#{reg_key}"" /v ""RememberedPuppetAgentStartupMode"" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
+             on host, Command.new(reg_query_command, [], { :cmdexe => true })
+
++            # (PA-620) environment.bat should be run before any cmd.exe shell command
++            # in order to properly set up environment variables
++            auto_run_key = ""HKLM\\SOFTWARE\\Microsoft\\Command Processor\AutoRun""
++            # TODO What's the best way to get the actual path to the script, respecting arch differences?
++            environment_script = ""C:\\Program Files\\Puppet Labs\\Puppet\bin\\environment.bat""
++            reg_add_command = %Q(reg add ""#{auto_run_key}"" /v ""PuppetEnvironment"" /d ""#{environment_script}"")
++
+             # emit the misc/versions.txt file which contains component versions for
+             # puppet, facter, hiera, pxp-agent, packaging and vendored Ruby
+             [",This is not the correct path on all hosts. How can I correctly determine whether I will need to look in `Program Files` or `Program Files (x86)` for the script?,I'm not sure if this is the best way to get the path to the executable. It seems to be that the `HKLM\SOFTWARE\Micr
+8686,"@@ -73,8 +73,15 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+
+             this.maxFlushIntervalTimer.Elapsed += async (sender, args) =>
+             {
+-                await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
+-            };
++                try
++                {
++                    await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
++                }
++                catch (Exception ex)
++                {
++                    JaegerExporterEventSource.Log.FailedToSend(ex);
++                }
++            };
+         }
+
+         public Process Process { get; internal set; }","I think it would be better to move this try/catch block inside of the `FlushAsyncInternal` function as there are a few of places that can call it, eg event timer (here), AppendAsync, FlushAsync and CloseAsync.",Would it make sense to propagate the exception directly to the `FlushAsyncAsyncInternal` method?
+8687,"@@ -79,6 +79,7 @@ final class IndexingChain implements Accountable {
+
+   // Holds fields seen in each document
+   private PerField[] fields = new PerField[1];
++  private PerField[] docFields = new PerField[10];
+   private final InfoStream infoStream;
+   private final ByteBlockPool.Allocator byteBlockAllocator;
+   private final LiveIndexWriterConfig indexWriterConfig;",should we set a smaller initial size to make sure that we exercise the growing logic in our tests?,Our coding style is to call `new PerField[1]` instead of `new PerField[10]`
+8688,"@@ -230,3 +230,9 @@ def test_sum():
+     assert str(dt.sum(f[:])) == str(f[:].sum())
+     DT = dt.Frame(A=range(1, 10))
+     assert_equals(DT[:, f.A.sum()], DT[:, dt.sum(f.A)])
++
++def test_max():
++    assert str(dt.max(f.A)) == str(f.A.max())
++    assert str(dt.max(f[:])) == str(f[:].max())
++    DT = dt.Frame(A=range(1, 10))
++    assert_equals(DT[:, f.A.max()], DT[:, dt.max(f.A)])","Let's add a new line at the end of this file, so that the last line becomes a valid line of code.",Might as well make this `dt.max(f.A) == dt.max(f.A)` and avoid the `str()` calls.
+8689,"@@ -3131,7 +3131,7 @@ Offset<reflection::Field> FieldDef::Serialize(FlatBufferBuilder *builder,
+ }
+
+ bool FieldDef::Deserialize(Parser &parser, const reflection::Field *field) {
+-  name = parser.UnqualifiedName(field->name()->str());
++  name = field->name()->str();
+   defined_namespace = parser.current_namespace_;
+   if (!value.type.Deserialize(parser, field->type()))
+     return false;",Why was this removed?,Is this unrelated?
+8690,"@@ -20,5 +20,12 @@ namespace Microsoft.CodeAnalysis.Sarif.SarifValidator
+             HelpText = ""Path of the SARIF file to validate"",
+             Required = true)]
+         public string InstanceFilePath { get; set; }
++
++        [Option(
++            'l',
++            ""log-file-path"",
++            HelpText = ""Path to SARIF log file containing the results of the validation"",
++            Default = ""sarif.log"")]
++        public string LogFilePath { get; set; }
+     }
+ }","I would prefer that this tool follow the driver framework conventions, which use OutputFilePath as an argument, take a look at AnalyzeCommandBase. You can propose changes to that if you'd like, but binskim, sqlskim, this tool should all conform (in the interests of building an eco-system with consistent command-line interface)",why is this optional?
+8691,"@@ -308,6 +308,18 @@ public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements Linear
+         return io.vavr.collection.Collections.fill(n, s, empty(), Queue::of);
+     }
+
++    /**
++     * Returns a Queue containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Queue
++     * @param n       The number of elements in the Queue
++     * @param element The element
++     * @return An Queue of size {@code n}, where each element is the given {@code element}.
++     */
++    public static <T> Queue<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element, empty(), Queue::of);
++    }
++
+     public static Queue<Character> range(char from, char toExclusive) {
+         return ofAll(Iterator.range(from, toExclusive));
+     }","(...), where each element ~are~ **is the** given {@code element}.",What is the difference between `fillObject` and `fill()`?
+8692,"@@ -57,7 +57,7 @@ namespace Examples.AspNetCore
+             switch (exporter)
+             {
+                 case ""jaeger"":
+-                    services.AddOpenTelemetryTracerProvider((builder) => builder
++                    services.AddOpenTelemetryTracing((builder) => builder
+                         .AddAspNetCoreInstrumentation()
+                         .AddHttpClientInstrumentation()
+                         .AddJaegerExporter(jaegerOptions =>",What if `AddOpenTelemetryTracing` is called multiple times?,I wonder if we want to rename `AddOpenTelemetryTracerProvider` to `AddOpenTelemetryTracing`
+8693,"@@ -16,9 +16,10 @@ FileBasedWalIterator::FileBasedWalIterator(
+     std::shared_ptr<FileBasedWal> wal,
+     LogID startId,
+     LogID lastId)
+-        : wal_(std::move(wal))
++        : wal_(wal)
+         , currId_(startId) {
+-    if (lastId >= 0) {
++    holder_ = std::make_unique<folly::RWSpinLock::ReadHolder>(wal_->rollbackLock_);
++    if (lastId >= 0 && lastId <= wal_->lastLogId()) {
+         lastId_ = lastId;
+     } else {
+         lastId_ = wal_->lastLogId();","Why is the condition of ""lastId <= wal _-> lastLogId() "" added here?",Use a range check for `lastId >= 0`.
+8694,"@@ -13,3 +13,9 @@
+ // limitations under the License.
+
+ package model
++
++import ""path""
++
++func MakeEnvironmentURL(baseURL, environmentID string) string {
++	return path.Join(baseURL, ""settings"", ""environment"")
++}",`environmentID` is unused in MakeEnvironmentURL,This is only used in the tests now. Can we move it in the models package?
+8695,"@@ -1700,10 +1700,14 @@ public class LFMainActivity extends SharedMediaActivity {
+         }
+     }
+
+-    private void checkNoSearchResults(String result){
+-        textView.setText(getString(R.string.null_search_result) + "" "" + '""' + result + '""' );
+-        textView.setTextColor(getTextColor());
+-        textView.setVisibility(View.VISIBLE);
++    private void checkNoSearchResults(String result,int length){
++        if (length>0) {
++            textView.setText(getString(R.string.null_search_result) + "" "" + '""' + result + '""');
++            textView.setTextColor(getTextColor());
++            textView.setVisibility(View.VISIBLE);
++        }
++        else
++            textView.setVisibility(View.INVISIBLE);
+     }
+
+     //region MENU",Just hide the textview,Might be a good idea to add `@NonNull` to this method
+8696,"@@ -54,7 +54,14 @@ type SessionDto struct {
+ 	Config json.RawMessage `json:""config""`
+ }
+
++// PaymentVersion represents the different payment versions we have
++type PaymentVersion string
++
++// PaymentVersionV2 represents the new pingpong version
++const PaymentVersionV2 PaymentVersion = ""v2""
++
+ // ConsumerInfo represents the consumer related information
+ type ConsumerInfo struct {
+ 	IssuerID identity.Identity `json:""issuerID""`
++	Supports PaymentVersion    `json:""supports""`
+ }","'Supports'? Very uninformative naming inside protocol. Why not just paymentVersion, or just recognise supported payment version from generic protocol version supported by the client.",Let's call it `pingpongVersion` since we're in here already.
+8697,"@@ -162,7 +162,11 @@ func (s *DiskSuite) TestExplicitBundleAndVerify() {
+ 	csr, pubKey, err := util.NewCSRTemplate(validSpiffeID)
+ 	require.NoError(err)
+
+-	resp, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
++	stream, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
++	require.NoError(err)
++	require.NotNil(stream)
++
++	resp, err := stream.Recv()
+ 	require.NoError(err)
+ 	require.NotNil(resp)
+ ",We should add an additional call to Recv() somewhere after here that we assert returns io.EOF.,Should we drop the error from `stream.Recv()` if `err != nil
+8698,"@@ -16,10 +16,13 @@
+
+ package azkaban.database;
+
++import static azkaban.ServiceProvider.SERVICE_PROVIDER;
++
+ import azkaban.metrics.CommonMetrics;
+ import azkaban.utils.Props;
+ import java.io.IOException;
+ import java.sql.Connection;
++import javax.inject.Inject;
+ import org.apache.commons.dbutils.DbUtils;
+ import org.apache.commons.dbutils.QueryRunner;
+ ",What is this used for?,Why not `import azkaban.ServiceProvider;`?
+8699,"@@ -7,9 +7,8 @@ package net.sourceforge.pmd.lang.java.ast;
+
+ import java.util.List;
+
+-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
++public class ASTAnnotationTypeDeclaration extends ASTAnyTypeDeclaration {
+
+-    private JavaQualifiedName qualifiedName;
+
+     public ASTAnnotationTypeDeclaration(int id) {
+         super(id);",this is a breaking API change. Do we really need to do it in 6.2.0? Can't we just deprecate the methods?,Is it safe to remove this? I do not see any reason to keep t
+8700,"@@ -123,6 +123,12 @@ public class DatabaseHelper extends DaoMaster.OpenHelper {
+                     }
+                 }
+                 break;
++            case 10:
++                AllergenDao.dropTable(db, true);
++                AllergenDao.createTable(db, true);
++                AllergenNameDao.dropTable(db, true);
++                AllergenNameDao.createTable(db, true);
++                break;
+         }
+     }
+ ",Is dropping the **Allergen table** necessary? Can't we just add the two new columns to the existing table using a raw query?,"This looks like a lot of code, can it be extracted?"
+8701,"@@ -13,11 +13,11 @@ feature ""Subscriber views completed trails"" do
+
+     within "".completed-trails"" do
+       expect(page).to have_content(just_finished_trail.name)
+-      expect(page).to have_no_content(incomplete_trail.name)
++      expect(page).not_to have_content(incomplete_trail.name)
+     end
+
+     within "".incomplete-trails"" do
+-      expect(page).to have_no_content(just_finished_trail.name)
++      expect(page).not_to have_content(just_finished_trail.name)
+       expect(page).to have_content(incomplete_trail.name)
+     end
+ ",I'm confused why the expectations here would have inverted? Seems unrelated to topic stuff. Can you clarify?,We should be able to remove the `not_to have_conten
+8702,"@@ -127,12 +127,13 @@ std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) {
+ std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId,
+                                             EdgeType edgeType,
+                                             int64_t version) {
++    int64_t storageVer = std::numeric_limits<int64_t>::max() - version;
+     std::string key;
+     key.reserve(128);
+     key.append(kEdgesTable.data(), kEdgesTable.size());
+     key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
+     key.append(reinterpret_cast<const char*>(&edgeType), sizeof(edgeType));
+-    key.append(reinterpret_cast<const char*>(&version), sizeof(version));
++    key.append(reinterpret_cast<const char*>(&storageVer), sizeof(storageVer));
+     return key;
+ }
+ ",I am very sorry that I neglected to resolve the conflict and did not fully unit test edge,Is this related to this PR?
+8703,"@@ -25,13 +25,14 @@ import org.apache.iceberg.catalog.TableIdentifier;
+ import org.apache.iceberg.exceptions.AlreadyExistsException;
+ import org.apache.iceberg.exceptions.CommitFailedException;
+ import org.apache.iceberg.exceptions.NoSuchTableException;
++import org.apache.iceberg.io.CloseableGroup;
+ import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+
+-public abstract class BaseMetastoreCatalog implements Catalog {
++public abstract class BaseMetastoreCatalog extends CloseableGroup implements Catalog {
+   private static final Logger LOG = LoggerFactory.getLogger(BaseMetastoreCatalog.class);
+
+   @Override","I think closeable should be handled by the concrete impl of a catalog and not by the base class, I don't think all catalogs must implement closeable by design. This should be done via composition rather than inheritance. Additionally, I don't know what the effect of this change is on other catalogs so this feels a bit on the risky side.",would you elaborate why you need this?
+8704,"@@ -9,11 +9,13 @@ void ConvolutionLayer<Dtype>::compute_output_shape() {
+   const int* kernel_shape_data = this->kernel_shape_.cpu_data();
+   const int* stride_data = this->stride_.cpu_data();
+   const int* pad_data = this->pad_.cpu_data();
++  const int* dilation_data = this->dilation_.cpu_data();
+   this->output_shape_.clear();
+   for (int i = 0; i < this->num_spatial_axes_; ++i) {
+     // i + 1 to skip channel axis
+     const int input_dim = this->input_shape(i + 1);
+-    const int output_dim = (input_dim + 2 * pad_data[i] - kernel_shape_data[i])
++    const int kernel_extent = dilation_data[i] * (kernel_shape_data[i] - 1) + 1;
++    const int output_dim = (input_dim + 2 * pad_data[i] - kernel_extent)
+         / stride_data[i] + 1;
+     this->output_shape_.push_back(output_dim);
+   }",Should this be `const`?,Does this need to use `this->dilation_.cpu_data()`?
+8705,"@@ -6,7 +6,7 @@ namespace Benchmarks.Trace
+     {
+         private static void Main(string[] args)
+         {
+-            BenchmarkRunner.Run<SpanBenchmark>();
++            BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+         }
+     }
+ }",Can we also add the Exporters here by using `DefaultConfig.AddExporter(...)`? At least the Datadog exporter that can't be configured from the command line...,@aparajit-pratap should this be using `BenchmarkRun
+8706,"@@ -77,7 +77,7 @@ int main(int argc, char *argv[]) {
+
+     // When using checkpoint states, skip training as those could be the result
+     // of checkpointing by steps.
+-    if (!opts->has_string(""ckpt_dir"")){
++    if (!opts->has_string(""no_model1_train"")){
+       model_1->train( pb_model.num_epochs() );
+     }
+     // Evaluate model 1 unless it is set to skip","@JaeseungYeom I believe you had set this in a previous commit to, by default, not train model1 when loading from ckpt. Would it work for you to have this as a command line option `--no_model1_train` instead of the default behavior?",This doesn't look right. There's no `no_model1_trai
+8707,"@@ -86,6 +86,11 @@ namespace Microsoft.Rest.Generator.Ruby.TemplateModels
+                 return ""Array<Integer>"";
+             }
+
++            if (type == PrimaryType.TimeSpan)
++            {
++                return ""Duration""; //TODO: Is this a real Ruby type...?
++            }
++
+             if (compositeType != null)
+             {
+                 return compositeType.Name;","@devigned, please clarify",Why is this a real Ruby type?
+8708,"@@ -19,6 +19,7 @@ import (
+ 	""reflect""
+ 	""testing""
+ 	""time""
++	""github.com/jmcvetta/randutil""
+ )
+
+ func TestConcurrentCommand_UnmarshalJSON(t *testing.T) {",File is not `gofmt`-ed with `-s` (from `gofmt`),I don't think this line should be here.
+8709,"@@ -127,7 +127,7 @@ def GenerateConfig(context):
+                 'items': [{
+                     'key': 'startup-script',
+                     'value': """"""#!/bin/bash
+-sudo apt-get install -y unzip
++sudo apt-get install -y unzip git
+ sudo apt-get install -y libmysqlclient-dev
+ sudo apt-get install -y python-pip python-dev
+ ",Should we break this up into a separate line?,why is this necessary?
+8710,"@@ -57,6 +57,7 @@ var _ = Describe(""conformance tests"", func() {
+ 	Measure(specName, func(b Benchmarker) {
+
+ 		name := fmt.Sprintf(""cluster-%s"", util.RandomString(6))
++		setEnvVar(""USE_CI_ARTIFACTS"", ""true"", false)
+ 		kubernetesVersion := e2eConfig.GetVariable(KubernetesVersion)
+ 		flavor := clusterctl.DefaultFlavor
+ 		if useCIArtifacts {","Why the override on the env variable, wouldn't we want to use the value set from Prow?",Setting the environment variable here i
+8711,"@@ -0,0 +1,13 @@
++widget :projected_monthly_revenue do
++  key ""74b333b94cd772ee15be863e646f8ca1e535f1c6""
++  type ""number_and_secondary""
++  data do
++    {
++      value:
++        IndividualPlan.prime_basic.projected_monthly_revenue +
++        IndividualPlan.prime_workshops.projected_monthly_revenue +
++        IndividualPlan.prime_with_mentoring.projected_monthly_revenue +
++        TeamPlan.instance.projected_monthly_revenue
++    }
++  end
++end","I don't see anything here that excludes people on a Team plan from from the revenue report. I see that TeamPlans are counted below, but the individual subscribers on the plan would still be included.",what's the meaning of this widget?
+8712,"@@ -1078,11 +1078,8 @@ public final class Vector<T> implements IndexedSeq<T>, Serializable {
+
+     @Override
+     public Vector<T> subSequence(int beginIndex, int endIndex) {
+-        if ((beginIndex >= 0) && (beginIndex <= endIndex) && (endIndex <= length())) {
+-            return slice(beginIndex, endIndex);
+-        } else {
+-            throw new IndexOutOfBoundsException(""subSequence("" + beginIndex + "", "" + endIndex + "") on Vector of size "" + length());
+-        }
++        Collections.subSequenceRangeCheck(beginIndex, endIndex, length());
++        return slice(beginIndex, endIndex);
+     }
+
+     @Override",I know that we do not pull the last bit of performance out of the JVM but it is more robust and removes redundant code.,Why not just have a check for `endIndex <= 0`?
+8713,"@@ -130,6 +130,11 @@ public abstract class ScheduledReporter implements Closeable, Reporter {
+                                 ScheduledExecutorService executor,
+                                 boolean shutdownExecutorOnStop,
+                                 Set<MetricAttribute> disabledMetricAttributes) {
++
++        if (registry == null) {
++            throw new IllegalArgumentException(""MetricRegistry must not be null !!!"");
++        }
++
+         this.registry = registry;
+         this.filter = filter;
+         this.executor = executor == null ? createDefaultExecutor(name) : executor;","I'd make this a `throw new NullPointerException(""registry == null"");` instead",Why this check?
+8714,"@@ -163,10 +163,12 @@ type Config struct {
+ 	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;tcp:22,udp:68;die-on-fail""`
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;tcp:2379,tcp:2380,tcp:4001,tcp:7001,udp:53,udp:67;die-on-fail""`
+
+-	UsageReportingEnabled bool   `config:""bool;true""`
+-	ClusterGUID           string `config:""string;baddecaf""`
+-	ClusterType           string `config:""string;""`
+-	CalicoVersion         string `config:""string;""`
++	UsageReportingEnabled          bool          `config:""bool;true""`
++	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`
++	UsageReportingIntervalSecs     time.Duration `config:""seconds;86400""`
++	ClusterGUID                    string        `config:""string;baddecaf""`
++	ClusterType                    string        `config:""string;""`
++	CalicoVersion                  string        `config:""string;""`
+
+ 	DebugMemoryProfilePath          string        `config:""file;;""`
+ 	DebugDisableLogDropping         bool          `config:""bool;false""`",Does adding things here require us also to extend the FelixConfiguration resource in libcalico-go?,I wonder if we can't just use `time.Duration`
+8715,"@@ -31,7 +31,11 @@ import (
+ 	""github.com/pkg/errors""
+ )
+
+-const currentCNISpec = ""0.3.1""
++const (
++	currentCNISpec = ""0.3.1""
++	currentCNIVersion = ""2018.08.0""
++	CNIGitHash = ""a134a973585b560439ed25ec3857e4789bfeb89f""
++)
+
+ // CNIClient defines the method of setting/cleaning up container namespace
+ type CNIClient interface {",does this need to be public?,@jackfrancis looks like this should be in `spe
+8716,"@@ -15,6 +15,7 @@
+ from . import encode
+ from . import number_types as N
+
++FILEIDENTIFIER_LENGTH = 4
+
+ class Table(object):
+     """"""Table wraps a byte slice and provides read access to its data.",Please import this from a pre-existing definition.,This constant is already defined in `bokeh.constants`
+8717,"@@ -0,0 +1,18 @@
++class WebOptions:
++    def load(self, loader):
++        loader.add_option(
++            ""web_open_browser"", bool, True,
++            ""Start a browser.""
++        )
++        loader.add_option(
++            ""web_debug"", bool, False,
++            ""Mitmweb debugging.""
++        )
++        loader.add_option(
++            ""web_port"", int, 8081,
++            ""Mitmweb port.""
++        )
++        loader.add_option(
++            ""web_iface"", str, ""127.0.0.1"",
++            ""Mitmweb interface.""
++        )",File name does not represent class name... if we ever cared for such things?,This should be `True` because the default is `False`
+8718,"@@ -39,7 +39,7 @@ Rails.application.routes.draw do
+       get :languages
+       get :commits_by_project_chart
+       get :commits_by_language_chart
+-      post :make_spammer
++      post :label_as_spammer
+       get 'edit_privacy'   => 'privacy#edit',   as: :edit_account_privacy
+       put 'update_privacy' => 'privacy#update', as: :account_privacy
+     end","I don't mind the `make_spammer` route name. It seems to more clearly convey that the state of the account will change. The ""label as"" route name seems less definitive, as if one is simply adding something to the account -- a new label -- instead of changing the status of the account.",Line is too long. [98/80]
+8719,"@@ -46,7 +46,8 @@ var loggingCmd = &cobra.Command{
+ 	Long:  `Enable/disable and configure Algorand remote logging`,
+ 	Args:  validateNoPosArgsFn,
+ 	Run: func(cmd *cobra.Command, _ []string) {
+-		cfg, err := logging.EnsureTelemetryConfig(nil, """")
++		dataDir := ensureSingleDataDir()
++		cfg, err := logging.EnsureTelemetryConfig(&dataDir, """")
+
+ 		// If error loading config, can't disable / no need to disable
+ 		if err != nil {","This exits if `-d` not specified which isn't exactly what we want, right?",What happens if the data dir does not exist? Will the
+8720,"@@ -313,3 +313,10 @@ def sizeof_fmt(num, suffix='B'):
+             return ""%3.1f%s%s"" % (num, unit, suffix)
+         num /= 1024.0
+     return ""%.1f%s%s"" % (num, 'Yi', suffix)
++
++
++def escape_like(string, escape_char='*'):
++    """"""Escape the string parameter used in SQL LIKE expressions.""""""
++    return string.replace(escape_char, escape_char * 2) \
++                 .replace('%', escape_char + '%') \
++                 .replace('_', escape_char + '_')",So a `*` becomes `**`? How does this affect the query? If I have `csordas*marton` as filter and I have `csordas*marton` and `csordasFOOBARmarton` as run names in the database I get only the first as result?,"I'm not sure what the best way to do this is, but this is a great way to make sure I understand what this does."
+8721,"@@ -191,11 +191,14 @@ InterimResult::buildIndex(const std::string &vidColumn) const {
+         auto name = schema->getFieldName(i);
+         if (vidColumn == name) {
+             VLOG(1) << ""col name: "" << vidColumn << "", col index: "" << i;
+-            if (schema->getFieldType(i).type != SupportedType::VID) {
++            if (schema->getFieldType(i).type != SupportedType::INT &&
++                schema->getFieldType(i).type != SupportedType::VID &&
++                schema->getFieldType(i).type != SupportedType::TIMESTAMP) {
+                 return Status::Error(
+-                        ""Build internal index for input data failed. ""
+-                        ""The specific vid column `%s' is not type of VID, column index: %ul."",
+-                        vidColumn.c_str(), i);
++                    ""Build internal index for input data failed. ""
++                    ""The specific vid column `%s' is not type of VID, INT or TIMESTAMP, ""
++                    ""column index: %u."",
++                    vidColumn.c_str(), i);
+             }
+             vidIndex = i;
+         }","I want to know in which situation you need to traverse from ""Timestamp"" data.....",How is this related to this PR?
+8722,"@@ -687,7 +687,11 @@ func (ctx *signingCtx) buildBodyDigest() error {
+ 			if !aws.IsReaderSeekable(ctx.Body) {
+ 				return fmt.Errorf(""cannot use unseekable request body %T, for signed request with body"", ctx.Body)
+ 			}
+-			hash = hex.EncodeToString(makeSha256Reader(ctx.Body))
++			hasBytes, err := makeSha256Reader(ctx.Body)
++			if err != nil {
++				return err
++			}
++			hash = hex.EncodeToString(hasBytes)
+ 		}
+
+ 		if includeSHA256Header {",nit: hasBytes should be hashBytes,"This should probably be `errors.Wrapf(err, ""cannot create sha256 hash for signed request body %T"", ctx.Body)`"
+8723,"@@ -171,6 +171,15 @@ def perform_analysis(args, skip_handler, context, actions, metadata):
+         config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
+             ReturnValueCollector.checker_analyze)
+
++    # Statistics collector checkers must be explicitly disabled
++    # as they trash the output.
++    if ""clangsa"" in analyzers:
++        config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
++            SpecialReturnValueCollector.checker_collect, False)
++
++        config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
++            ReturnValueCollector.checker_collect, False)
++
+     # Save some metadata information.
+     versions = __get_analyzer_version(context, config_map)
+     metadata['versions'].update(versions)",If I enable the clangsa analyzer with the `--stats` flag the checkers will be disabled even if they were enabled previously. I think we should check here if stats was enabled. `if 'stats_enabled' in args and args.stats_enabled` we should leave them enabled.,I don't think we need to disable the checker on every iteration of the analyzer. It's safe to disable it only w
+8724,"@@ -1041,6 +1041,9 @@ func DoEstimateGas(ctx context.Context, b Backend, args CallArgs, blockNrOrHash
+
+ 	// 3. calculate the fee and normalize by the default gas price
+ 	fee := core.CalculateRollupFee(*args.Data, uint64(gasUsed), dataPrice, executionPrice).Uint64() / defaultGasPrice
++	if fee < 21000 {
++		fee = 21000
++	}
+ 	return (hexutil.Uint64)(fee), nil
+ }
+ ",Note that we probably should set the default gasPrice to `0.1 gwei` considering our minimum gas limit has to be 21k. At 21k the minimum fee would end up being `0.000021 ETH` which is just a little too high,why not 0?
+8725,"@@ -132,7 +132,9 @@ func validateTrustedOperators(o *Options) error {
+ 		if o.TrustedKeys == nil {
+ 			o.TrustedKeys = make([]string, 0, 4)
+ 		}
+-		o.TrustedKeys = append(o.TrustedKeys, opc.Issuer)
++		if !opc.StrictSigningKeyUsage {
++			o.TrustedKeys = append(o.TrustedKeys, opc.Subject)
++		}
+ 		o.TrustedKeys = append(o.TrustedKeys, opc.SigningKeys...)
+ 	}
+ 	for _, key := range o.TrustedKeys {","So during a config reload, this function is invoked, but prior to that the o.TrustedKeys slice is set to nil, so this code would work. However, I am wondering what happens to s.trustedKeys, I am not sure this is handled at all. (same with the new map you are adding). I am not sure if this is supposed to be supported with a config reload, but just wondering if this is not putting things into a bad state.",why are we
+8726,"@@ -64,15 +64,12 @@ func SecurityHandler(authenticators map[string]auth.Authenticator, next http.Han
+ 	}
+
+ 	return func(w http.ResponseWriter, r *http.Request) {
+-
+ 		tokenHeader := r.Header.Get(""Authorization"")
+ 		tokens := strings.Split(tokenHeader, "" "")
+
+ 		if len(tokens) < 2 {
+ 			w.WriteHeader(http.StatusUnauthorized)
+-			json.NewEncoder(w).Encode(&api.ClusterResponse{
+-				Error: fmt.Sprintf(""Access denied, token is malformed""),
+-			})
++			fmt.Fprintf(w, ""Access denied token is empty"")
+ 			return
+ 		}
+ 		token := tokens[1]","I think the logic should be to check for token len of 0 then check for token len of less than 2. The way the logic is now, it is hard to determine if it is empty or malformed.",Why did yo
+8727,"@@ -267,6 +267,15 @@ void wlr_output_set_subpixel(struct wlr_output *output,
+ 	wlr_output_schedule_done(output);
+ }
+
++void wlr_output_set_format(struct wlr_output *output,
++		enum wl_shm_format format) {
++	if (output->format == format) {
++		return;
++	}
++
++	output->format = format;
++}
++
+ void wlr_output_set_description(struct wlr_output *output, const char *desc) {
+ 	if (output->description != NULL && desc != NULL &&
+ 			strcmp(output->description, desc) == 0) {",Nothing would change here even if this `if` statement were removed.,We should
+8728,"@@ -38,10 +38,11 @@ assert_pyspark_version()
+ from databricks.koalas.frame import DataFrame
+ from databricks.koalas.indexes import Index, MultiIndex
+ from databricks.koalas.series import Series
+-from databricks.koalas.typedef import Col, pandas_wraps
++from databricks.koalas.typedef import pandas_wraps
++from databricks.koalas.sql import sql
+
+ __all__ = ['read_csv', 'read_parquet', 'to_datetime', 'from_pandas',
+-           'get_dummies', 'DataFrame', 'Series', 'Index', 'MultiIndex', 'Col', 'pandas_wraps',
++           'get_dummies', 'DataFrame', 'Series', 'Index', 'MultiIndex', 'pandas_wraps',
+            'sql', 'range', 'concat', 'melt']
+
+ ",`sql` module is imported later.,can we call this `pd_wraps` ?
+8729,"@@ -69,6 +69,15 @@ class GARPNHead(RPNTestMixin, GuidedAnchorHead):
+                            cfg,
+                            rescale=False):
+         cfg = self.test_cfg if cfg is None else cfg
++
++        # refactor the nms cfg
++        # this is used for avoid breaking change
++        if 'nms' not in cfg:
++            cfg.nms = dict(type='nms', iou_threshold=cfg.nms_thr)
++            cfg.max_per_img = cfg.max_num
++
++        assert cfg.nms.get('type', 'nms') == 'nms', 'GARPNHead only support ' \
++            'naive nms.'
+         mlvl_proposals = []
+         for idx in range(len(cls_scores)):
+             rpn_cls_score = cls_scores[idx]","I think it's strange, whether `assert cfg.nms.type == 'nms'` would be better.",This is temporary and will be
+8730,"@@ -33,14 +33,7 @@ import globalize from '../scripts/globalize';
+             });
+
+             options.buttons = items;
+-
+-            return dialog.show(options).then(function (result) {
+-                if (result === 'ok') {
+-                    return Promise.resolve();
+-                }
+-
+-                return Promise.reject();
+-            });
++            return dialog.show(options);
+         }
+
+         return Promise.resolve();","Doing a quick search, it looks like there are other places that would be handling this promise rejection. How did you confirm this is not needed?",Is this safe? What happens if
+8731,"@@ -68,7 +68,7 @@ func TestCreateContract(t *testing.T) {
+ 	_, err = accountutil.LoadOrCreateAccount(sm, addr.String())
+ 	require.NoError(err)
+ 	hu := config.NewHeightUpgrade(&cfg.Genesis)
+-	stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hash.ZeroHash256)
++	stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hu.IsPost(config.Fairbank, 0), hash.ZeroHash256)
+ 	contract := addr.Bytes()
+ 	var evmContract common.Address
+ 	copy(evmContract[:], contract[:])",let's use greenland in the unit tests as well,@LeoHChen I was wondering wha
+8732,"@@ -48,8 +48,10 @@ def reportPassThrough(treeInterceptor,onlyIfChanged=True):
+ 			nvwave.playWaveFile(sound)
+ 		else:
+ 			if treeInterceptor.passThrough:
++				# Translators: The mode to interact with controls in documents
+ 				ui.message(_(""Focus mode""))
+ 			else:
++				# Translators: The mode that presents text in a flat representation that can be navigated with the cursor keys like in a text document
+ 				ui.message(_(""Browse mode""))
+ 		reportPassThrough.last = treeInterceptor.passThrough
+ reportPassThrough.last = False",Please split this into two lines,`The mode that presents text in a flat representation that can be navigated with the cursor keys like in a text document`
+8733,"@@ -77,6 +77,12 @@ namespace MvvmCross.Platform.Tvos.Views
+
+         public virtual bool ShowChildView(UIViewController viewController)
+         {
++            if (SelectedIndex > 5) // when more menu item is currently visible, selected index has value higher than 5
++            {
++                MoreNavigationController.PushViewController(viewController, true);
++                return true;
++            }
++
+             var navigationController = SelectedViewController as UINavigationController;
+
+             // if the current selected ViewController is not a NavigationController, then a child cannot be shown",Is there any variable available instead of hardcoding 5?,What does the 5 come from?
+8734,"@@ -385,9 +385,7 @@ public class LoginActivity extends AccountAuthenticatorActivity
+
+ 	@Override
+ 	protected void onActivityResult(int requestCode, int resultCode, Intent data) {
+-		if (requestCode == PasscodeManager.PASSCODE_REQUEST_CODE && resultCode == Activity.RESULT_OK) {
+-			webviewHelper.onNewPasscode();
+-		} else if (requestCode == SPRequestHandler.IDP_REQUEST_CODE) {
++		if (requestCode == SPRequestHandler.IDP_REQUEST_CODE) {
+             spRequestHandler.handleIDPResponse(resultCode, data);
+         } else {
+ 	        super.onActivityResult(requestCode, resultCode, data);",The onNewPasscode method was taking care of creating the user account. Now the user account will already have been created.,"I don't understand why this change is being made - the passcode manager calls `onNewPasscode` if it's a passcode request,"
+8735,"@@ -29,7 +29,8 @@ import (
+ )
+
+ const (
+-	MaxChainNameLength = 28
++	MaxChainNameLength       = 28
++	defaultPostWriteInterval = 50 * time.Millisecond
+ )
+
+ var (","This is really a minimum, isn't it, so `minPostWriteInterval` perhaps? IIUC it never gets used as a default, because the default IptablesPostWriteCheckInterval is 1s, which is larger than this.",Would it be better to use `time.Minute` instead of `50*time.Millisecond`?
+8736,"@@ -1,11 +1,9 @@
+ <ul class=""bookmarkTools nav nav-pills"">
+-  <li class=""cite"">
+-    <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
+-  </li>
+-
+-  <li class=""email"">
+-    <%= link_to t('blacklight.tools.email'), email_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), :class=>""btn btn-default"", :id => ""emailLink"", :data => {:ajax_modal => ""trigger""} %>
+-  </li>
++  <% BookmarksController.document_actions.each do |action| %>
++    <li class=""#{action}"">
++      <%= link_to t(""blacklight.tools.#{action}""), self.send(""#{action}_bookmarks_path""), {:id => ""#{action}Link"", :name => action, :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
++    </li>
++  <% end %>
+
+   <%= render_marc_tools %>
+ </ul>",I wonder if you can use the controller's context instead of using it explicitly?,Can we use the `find_by` helper here?
+8737,"@@ -94,6 +94,7 @@ func (e *Executor) ensureCanaryClean(ctx context.Context) model.StageStatus {
+
+ 	resources := strings.Split(value, "","")
+ 	if err := e.removeCanaryResources(ctx, resources); err != nil {
++		e.LogPersister.AppendErrorf(""Unable to remove canary resources: %v"", err)
+ 		return model.StageStatus_STAGE_FAILURE
+ 	}
+ 	return model.StageStatus_STAGE_SUCCESS",Can you add this log for `baseline` too?,I would log the error at a higher lev
+8738,"@@ -148,6 +148,10 @@ Blockly.Msg.CANNOT_DELETE_VARIABLE_PROCEDURE = 'Can\'t delete the variable ""%1""
+ /// dropdown choice - Delete the currently selected variable.
+ Blockly.Msg.DELETE_VARIABLE = 'Delete the ""%1"" variable';
+
++// Broadcast Message creation
++/// dropdown choice - Create a new message.
++Blockly.Msg.NEW_MESSAGE = 'New message...';
++
+ // Colour Blocks.
+ /// url - Information about colour.
+ Blockly.Msg.COLOUR_PICKER_HELPURL = 'https://en.wikipedia.org/wiki/Color';","Let's call this ""NEW_BROADCAST_MESSAGE"". Msg.NEW_MESSAGE will be confusing down the line.",Is this the same as the `Broadcast` c
+8739,"@@ -128,11 +128,17 @@ type Container struct {
+ 	// is handled properly so that the state storage continues to work.
+ 	KnownStatusUnsafe ContainerStatus `json:""KnownStatus""`
+
++	// TransitionDependenciesMap is a map of the dependent container status to other
++	// dependencies that must be satisfied in order for this container to transition.
++	TransitionDependenciesMap map[ContainerStatus]TransitionDependencySet
++
+ 	// TransitionDependencySet is a set of dependencies that must be satisfied
+ 	// in order for this container to transition.  Each transition dependency
+ 	// specifies a resource upon which the transition is dependent, a status
+ 	// that depends on the resource, and the state of the dependency that
+ 	// satisfies.
++	// Deprecated: Use TransitionDependenciesMap instead. TransitionDependencySet is
++	// retained for compatibility with old state files.
+ 	TransitionDependencySet TransitionDependencySet `json:""TransitionDependencySet""`
+
+ 	// SteadyStateDependencies is a list of containers that must be in ""steady state"" before","A better way to do this (in your future PR) would be to: 1. get rid of `TransitionDependencySet` altogether 2. tag `TransitionDependenciesMap` as `""TransitionDependencySet""` in JSON 3. update the JSON marshaler to deal with `""TransitionDependencySet""` tag. If it's a map, no big deal. Else, construct the `TransitionDependenciesMap` map. Doing that would mean that we don't need to have duplicate code, names for this.",Why is this not just a `map[Container
+8740,"@@ -81,10 +81,10 @@ def file_list_to_folder(df: pd.DataFrame, limit: int, offset: int) -> dict:
+             axis=1
+         ).to_dict(orient='records')
+         objects = folder[~folder.logical_key.str.contains('/')].to_dict(orient='records')
+-        returned_results = len(prefixes) + len(objects)
+-    except AttributeError as err:
+-        # Pandas will raise an attribute error if the DataFrame has
+-        # no rows with a non-null logical_key. We expect that case if
++
++    except (AttributeError, KeyError) as err:
++        # Pandas will raise an AttributeError or KeyError if the DataFrame
++        # has no rows with a non-null logical_key. We expect that case if
+         # either: (1) the package is empty (has zero package entries)
+         # or, (2) zero package entries match the prefix filter. The
+         # choice to allow this to raise the exception instead of","It's very error-prone to have so large `try` clause with such non-specific exceptions handled. Consider rewriting it with either of these: 1. Check that expected columns are present in `DataFrame` (`{'physical_key', 'logical_key', 'size'}.issubset(df.columns)`). 2. Normalizing output of query by using `COALESCE()` (or normalizing `DataFrame` itself?). Also it looks like a row with package metadata isn't used here, so might make sense to filter out it with `WHERE logical_key IS NOT MISSING`.",Nice catch with `KeyError`!
+8741,"@@ -116,6 +116,7 @@ var (
+ 		MirrorQueueLength      int
+ 		PullRequestQueueLength int
+ 		PreferredLicenses      []string
++		DisableHttpGit         bool
+
+ 		// Repository editor settings
+ 		Editor struct {",Change to `DisableHTTPGit`,Why not make it a pointer s
+8742,"@@ -71,10 +71,9 @@ class UserMailer < ActionMailer::Base
+   end
+
+   def feedback_notification(recipient, plan, requestor)
+-    return unless @user.org.present? && recipient.active?
++    return unless recipient.active?
+
+     @user = requestor
+-    @org = @user.org
+     @plan = plan
+     @recipient = recipient
+ ",org was not used in the mail content,Use a guard clause instead
+8743,"@@ -128,6 +128,9 @@ export default Service.extend({
+         return this.lazyLoader.loadStyle('dark', 'assets/ghost-dark.css', true).then(() => {
+             $('link[title=dark]').prop('disabled', !nightShift);
+             $('link[title=light]').prop('disabled', nightShift);
++        }).catch((err) => {
++            $('link[title=dark]').prop('disabled', true);
++            $('link[title=light]').prop('disabled', false);
+         });
+     }
+ });","Is this gonna cause a lint issue, because of unused var? Maybe we should log it out?",Don't we need to call `remo
+8744,"@@ -321,7 +321,11 @@ module Beaker
+     def hack_etc_hosts hosts, opts
+       etc_hosts = ""127.0.0.1\tlocalhost localhost.localdomain\n""
+       hosts.each do |host|
+-        etc_hosts += ""#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n""
++        if host['hypervisor'] == 'docker'
++          etc_hosts += ""#{host['docker_container'].json[""NetworkSettings""][""IPAddress""]}\t#{host.name}\n""
++        else
++          etc_hosts += ""#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n""
++        end
+       end
+       hosts.each do |host|
+         set_etc_hosts(host, etc_hosts)","My understanding is that this will always be set to the actual containers IP, and never to the `DOCKER_HOST` IP if that env_var is set.",Shouldn't it be `||` instead of `||`?
+8745,"@@ -49,11 +49,14 @@ function ResetButton( { children } ) {
+ 	 * the navigate call starting, we will just set a debounce to keep the spinner for 3 seconds.
+ 	 */
+ 	const debouncedSetInProgress = useDebounce( setInProgress, 3000 );
+-	const mediatedSetInProgress = ( bool ) => bool ? setInProgress( true ) : debouncedSetInProgress( false );
++	const mediatedSetInProgress = useCallback(
++		( bool ) => bool ? setInProgress( true ) : debouncedSetInProgress( false ),
++		[ debouncedSetInProgress ]
++	);
+
+ 	useEffect( () => {
+ 		mediatedSetInProgress( isDoingReset || isNavigatingToPostResetURL );
+-	}, [ isDoingReset, isNavigatingToPostResetURL ] );
++	}, [ isDoingReset, isNavigatingToPostResetURL, mediatedSetInProgress ] );
+
+ 	useEffect( () => {
+ 		const handleCloseModal = ( event ) => {",this dependency to a callback also has to be a callback (eslint now warns us),Should we use debouncedSetInProgress
+8746,"@@ -95,7 +95,7 @@ func (c *CStorPoolController) reconcile(key string) error {
+ 	return c.updateStatus(csp)
+ }
+
+-func (c *CStorPoolController) destroy(csp *apis.NewTestCStorPool) error {
++func (c *CStorPoolController) destroy(csp *apis.CStorPoolInstance) error {
+ 	var phase apis.CStorPoolPhase
+
+ 	// DeletePool is to delete cstor zpool.",directory name as well needs change..,why not the `*apis.CStorPoolInstance`
+8747,"@@ -348,7 +348,8 @@ class PluginManager
+     public function findByIdentifier($identifier)
+     {
+         if (!isset($this->plugins[$identifier])) {
+-            $identifier = $this->normalizeIdentifier($identifier);
++            $code = $this->getIdentifier($identifier);
++            $identifier = $this->normalizeIdentifier($code);
+         }
+
+         if (!isset($this->plugins[$identifier])) {",Why is the getIdentifier() call required here?,Why did you change this?
+8748,"@@ -92,7 +92,11 @@ std::string MakeCamel(const std::string &in, bool first) {
+ }
+
+ void Parser::Message(const std::string &msg) {
++#ifndef FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
+   error_ = file_being_parsed_.length() ? AbsolutePath(file_being_parsed_) : """";
++#else // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
++  error_ = file_being_parsed_.length() ? file_being_parsed_ : """";
++#endif // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
+   // clang-format off
+   #ifdef _WIN32
+     error_ += ""("" + NumToString(line_) + "")"";  // MSVC alike",Looks more appropriate to stick this in `AbsolutePath`.. actually that already has `FLATBUFFERS_NO_ABSOLUTE_PATH_RESOLUTION`,There's an #ifdef in this file that could be replaced with this one.
+8749,"@@ -1,4 +1,8 @@
+-const html = require('yo-yo')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl
+
+ module.exports = (props) => {
+   const input = html`",this might interfere when we have multiple dashboards. maybe ActionBrowseTagline needs to be a Component so we can store the reference to the element on it.,use `toas` instead of `h`
+8750,"@@ -376,8 +376,15 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock.
+ 	context kbfsblock.Context) (
+ 	buf []byte, serverHalf kbfscrypto.BlockCryptKeyServerHalf, err error) {
+ 	ctx = rpc.WithFireNow(ctx)
++	var res keybase1.GetBlockRes
+ 	b.log.LazyTrace(ctx, ""BServer: Get %s"", id)
++
++	// Once the block has been retrieved, cache it.
+ 	defer func() {
++		// But don't cache it if it's archived data.
++		if res.Status == keybase1.BlockStatus_ARCHIVED {
++			return
++		}
+ 		b.log.LazyTrace(ctx, ""BServer: Get %s done (err=%v)"", id, err)
+ 		if err != nil {
+ 			b.deferLog.CWarningf(",Should this be inside the `else` below and right after `CDebugf` so that we still get the logs?,Would it be safer to just cache it in the case where it's not archiv
+8751,"@@ -540,4 +540,5 @@ var errorCodeMap = map[string]gcerrors.ErrorCode{
+ 	dyn.ErrCodeTransactionCanceledException:             gcerr.FailedPrecondition,
+ 	dyn.ErrCodeTransactionInProgressException:           gcerr.InvalidArgument,
+ 	dyn.ErrCodeIdempotentParameterMismatchException:     gcerr.InvalidArgument,
++	""ValidationException"":                               gcerr.InvalidArgument,
+ }",Weird they don't expose the type for dynamo and this seems a pretty common error.,"This is a pretty generic error. Can we make it a bit more specific, "
+8752,"@@ -33,10 +33,11 @@ namespace OpenTelemetry.Trace.Configuration
+         /// Enables OpenTelemetry.
+         /// </summary>
+         /// <param name=""configureOpenTelemetryBuilder"">Function that configures OpenTelemetryBuilder.</param>
++        /// <returns><see cref=""IDisposable""/> to be disposed on application shutdown.</returns>
+         /// <remarks>
+         /// Basic implementation only. Most logic from TracerBuilder will be ported here.
+         /// </remarks>
+-        public static void EnableOpenTelemetry(Action<OpenTelemetryBuilder> configureOpenTelemetryBuilder)
++        public static IDisposable EnableOpenTelemetry(Action<OpenTelemetryBuilder> configureOpenTelemetryBuilder)
+         {
+             var openTelemetryBuilder = new OpenTelemetryBuilder();
+             configureOpenTelemetryBuilder(openTelemetryBuilder);",@cijothomas I couldn't make the unit tests work without a way to destroy the ActivityListener we create internally so I return it as an IDisposable here. But we'll also need to also stop any ActivityProcessors/ActivityExporters on application shutdown right?,I'm not sure if returning an `IDisposable` is the right thing to do here. It feels like it should be an `IDisposable` type and not `Action<OpenTelemetryBuilder>`
+8753,"@@ -592,7 +592,7 @@ class Commands:
+
+     @command('wp')
+     async def payto(self, destination, amount, fee=None, feerate=None, from_addr=None, from_coins=None, change_addr=None,
+-                    nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, wallet: Abstract_Wallet = None):
++                    nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, addtransaction=True, wallet: Abstract_Wallet = None):
+         """"""Create a transaction. """"""
+         self.nocheck = nocheck
+         tx_fee = satoshis(fee)","The default should be ""False"", as ""True"" would be a significant change in behaviour.",why do we have this `addtransaction` parameter ?
+8754,"@@ -161,8 +161,16 @@ class Package(object):
+
+         # Serialize DataFrame to chosen format
+         if enumformat is PackageFormat.HDF5:
+-            with pd.HDFStore(storepath, mode='w') as store:
+-                store[self.DF_NAME] = df
++            # HACK: Force the use of old pickle to ensure Python 2/3 compatibility.
++            from pandas.compat import cPickle
++            old_protocol = cPickle.HIGHEST_PROTOCOL
++            try:
++                cPickle.HIGHEST_PROTOCOL = 2
++                with pd.HDFStore(storepath, mode='w') as store:
++                    store[self.DF_NAME] = df
++            finally:
++                cPickle.HIGHEST_PROTOCOL = old_protocol
++
+         elif enumformat is PackageFormat.PARQUET:
+             # switch parquet lib
+             parqlib = self.get_parquet_lib()","since goal is to restore old_protocol, shouldn't we get it from pandas if possible? e.g. this will break if their source code changes.","How about: `with pd.HDFStore(storepath, mode='w') as store:`"
+8755,"@@ -299,7 +299,7 @@ class ErrorBaseline
+                     ""\n"" .
+                     '  php-version=""' .
+                     ""\n    "" .
+-                    implode(""\n    "", explode('&#10;&#9;', $matches[2])) .
++                    str_replace('&#10;&#9;', ""\n    "", $matches[2]).
+                     ""\n"" .
+                     '  ""' .
+                     ""\n"" .",This should consume less resources because str_replace don't need to assign arrays with all the values,"`implode(""\n"", explode('&#10;&#9;', $matches[2]))` is the same as `implode(""\n"", $matches[2]))` and is the same as `str_replace('&#10;&#9;', $matches[2])`"
+8756,"@@ -240,6 +240,10 @@ static bool check_arg_types(pass_opt_t* opt, ast_t* params, ast_t* positional,
+     {
+       errorframe_t frame = NULL;
+       ast_error_frame(&frame, arg, ""argument not a subtype of parameter"");
++      ast_error_frame(&frame, arg, ""argument type is %s"",
++                      ast_print_type(a_type));
++      ast_error_frame(&frame, arg, ""parameter type is %s"",
++                      ast_print_type(p_type));
+       errorframe_append(&frame, &info);
+
+       if (ast_childcount(arg) > 1)","It would be better to pass `param` as the second argument here, so that the parameter declaration is printed alongside the type. Same thing for the changes in `ffi.c` and `lambda.c`.",This should probably be using `ast_error_<e36>` instead of `ast_print_type`.
+8757,"@@ -27,6 +27,7 @@ import org.joda.time.DateTime;
+
+ import azkaban.utils.JSONUtils;
+
++
+ public class Trigger {
+
+   private static Logger logger = Logger.getLogger(Trigger.class);","Do we need to set the members to final like submitTime, submitUser ...? They are only used by getter method.",Please remove unnecessary change.
+8758,"@@ -13,7 +13,7 @@ class MediaLibraryItem extends SystemMediaLibraryItem
+ {
+     public function __construct()
+     {
+-        traceLog('Class Cms\Classes\MediaLibraryItem has been deprecated, use System\Classes\MediaLibraryItem instead.');
++        traceLog('Class ' . __CLASS__ . ' has been deprecated, use ' . SystemMediaLibraryItem::class . ' instead.');
+         parent::__construct(...func_get_args());
+     }
+ }","That makes this error message incorrect; if someone has extended Cms\Classes\MediaLibraryItem, then this error message will read ""Class My\Classes\CustomMediaLibraryItem has been deprecated"".","`__CLASS__` will always be the class name, don't you have to use `__CLASS__`"
+8759,"@@ -97,6 +97,6 @@ class Factory implements \Zend\ServiceManager\FactoryInterface
+         $config = $sm->get('VuFind\Config')->get('config');
+
+         // Create service:
+-        return new \VuFind\Mailer\Mailer($this->getTransport($config));
++        return new \VuFind\Mailer\Mailer($this->getTransport($config), $config);
+     }
+ }","Is it worth injecting the whole configuration object for just one setting? Would it be more generic to pass an $options array with the override_from in it? I'm not completely opposed to passing $config, but since we've avoided it so far, it seems like it would be cleaner to maintain that separation. Simply adding a getOptions method to the factory would make this a lot more readable.",How is this different from what was there before?
+8760,"@@ -44,3 +44,14 @@ const (
+ 	SDA_PIN = 26
+ 	SCL_PIN = 27
+ )
++
++// SPI pins
++const (
++	SPI0_SCK_PIN  = 25
++	SPI0_MOSI_PIN = 23
++	SPI0_MISO_PIN = 24
++
++	SPI1_SCK_PIN  = 2
++	SPI1_MOSI_PIN = 3
++	SPI1_MISO_PIN = 4
++)","Just curious: where do these pin numbers come from? I see you took the SPI0 pin numbers from the Arduino board layout which is good, but I can't find such a relation for `SPI1`.",Would `SPI1_MASTER_PIN` be better?
+8761,"@@ -450,10 +450,14 @@ public final class MethodTypeResolution {
+         Class<?> contextClass = context.getType();
+
+         // search the class
+-        for (Method method : contextClass.getDeclaredMethods()) {
+-            if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) {
+-                result.add(getTypeDefOfMethod(context, method, typeArguments));
++        try {
++            for (Method method : contextClass.getDeclaredMethods()) {
++                if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) {
++                    result.add(getTypeDefOfMethod(context, method, typeArguments));
++                }
+             }
++        } catch (final LinkageError ignored) {
++            // TODO : This is an incomplete classpath, report the missing class
+         }
+
+         // search it's supertype","Isn't that already too late? I'd expect, that the LinkageError occurs the first time, we have the class instance (the classloader tried to load the class) - or do we get a partially linked class back, and we get the exception when retrieving the methods?",Looks like this TODO can be remove
+8762,"@@ -31,7 +31,7 @@ import (
+ const (
+ 	supportedVersion  = 0
+ 	maxVersion        = 254
+-	traceparentHeader = ""traceparent""
++	TraceparentHeader = ""Traceparent""
+ )
+
+ type httpTraceContextPropagator struct{}",nit:s/Traceparent/traceparent/ - As per the spec header name is all lowercase.,I think these two constants should
+8763,"@@ -484,3 +484,16 @@ type ErrDockerfileNotFound struct {
+ func (e *ErrDockerfileNotFound) Error() string {
+ 	return fmt.Sprintf(""no Dockerfiles found within %s or a sub-directory level below"", e.dir)
+ }
++
++// RelPath returns the path relative to the current working directory.
++func RelPath(fullPath string) (string, error) {
++	wkdir, err := os.Getwd()
++	if err != nil {
++		return """", fmt.Errorf(""get working directory: %w"", err)
++	}
++	path, err := filepath.Rel(wkdir, fullPath)
++	if err != nil {
++		return """", fmt.Errorf(""get relative path of file: %w"", err)
++	}
++	return path, nil
++}",We need to have unit tests for it since it is now a public function. Also I'm not a fan for making this movement since `relPath` doesn't consume any info in this pkg.,Why not just use `filepath.Rel`?
+8764,"@@ -5,16 +5,11 @@
+  */
+ package edu.harvard.iq.dataverse.datasetutility;
+
+-import edu.harvard.iq.dataverse.DataFile;
++import edu.harvard.iq.dataverse.*;
+ import edu.harvard.iq.dataverse.DataFile.ChecksumType;
+-import edu.harvard.iq.dataverse.DataFileServiceBean;
+-import edu.harvard.iq.dataverse.Dataset;
+-import edu.harvard.iq.dataverse.DatasetServiceBean;
+-import edu.harvard.iq.dataverse.DatasetVersion;
+-import edu.harvard.iq.dataverse.EjbDataverseEngine;
+-import edu.harvard.iq.dataverse.FileMetadata;
+-import edu.harvard.iq.dataverse.PermissionServiceBean;
++import edu.harvard.iq.dataverse.api.Files;
+ import edu.harvard.iq.dataverse.api.Util;
++import edu.harvard.iq.dataverse.authorization.users.AuthenticatedUser;
+ import edu.harvard.iq.dataverse.authorization.users.User;
+ import edu.harvard.iq.dataverse.engine.command.Command;
+ import edu.harvard.iq.dataverse.engine.command.DataverseRequest;","We generally avoid wildcard imports. If you feel like changing it back, great. Otherwise, no big deal.",Please don't use star imports.
+8765,"@@ -51,7 +51,7 @@
+ // 	dispatcher := yarpc.NewDispatcher(yarpc.Config{
+ // 		Name: ""myservice"",
+ // 		Outbounds: yarpc.OUtbounds{
+-// 			{Unary: myserviceOutbound},
++// 			""outboundservice"": {Unary: myserviceOutbound},
+ // 		},
+ // 	})
+ //",We also have a typo on the line above! OUt or Out?,Should be `outboundservice`.
+8766,"@@ -7,5 +7,7 @@
+ <%= @step.action_name %>
+ <%= generate_approve_url(@step) %>
+
+-<%= t(""mailer.step_mailer.proposal_notification.cta"") %>
+-<%= proposal_url(@proposal, anchor: ""comments"") %>
++<%= t(""mailer.view_request_cta"") %>
++<%= proposal_url(@proposal) %>
++
++<%= t(""mailer.footer"", feedback_url: feedback_url) %>",OH! These are text.... (Ignore above),Since we're changing this anyw
+8767,"@@ -98,7 +98,6 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+   private List<Expression> filterExpressions = null;
+   private Filter[] pushedFilters = NO_FILTERS;
+   private final boolean localityPreferred;
+-  private final int batchSize;
+   private final boolean readTimestampWithoutZone;
+
+   // lazy variables",How was this set before? Was it just ignored?,Why remove this?
+8768,"@@ -0,0 +1,12 @@
++class CreditCardsController < ApplicationController
++  def update
++    customer = Stripe::Customer.retrieve(current_user.stripe_customer_id)
++    customer.card = params['stripe_token']
++    begin
++      customer.save
++      redirect_to my_account_path, notice: I18n.t('subscriptions.flashes.update.success')
++    rescue Stripe::CardError => error
++      redirect_to my_account_path, notice: error.message
++    end
++  end
++end",Should we `save!` here?,Why not just add the `stripe_token` to the `before_action` block?
+8769,"@@ -284,7 +284,7 @@ void TServerSocket::listen() {
+   hints.ai_family = PF_UNSPEC;
+   hints.ai_socktype = SOCK_STREAM;
+   hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
+-  sprintf(port, ""%d"", port_);
++  snprintf(port, sizeof(""65535""), ""%d"", port_);
+
+   // If address is not specified use wildcard address (NULL)
+   TGetAddrInfoWrapper info(address_.empty() ? NULL : &address_[0], port, &hints);",sizeof(port) seems ever-so-slightly clearer.,"Suggest using `strlcpy(port, ""65535"", sizeof(port_));`"
+8770,"@@ -116,6 +116,12 @@ type Rule struct {
+ 	// conjunction with NetworkPolicySpec/ClusterNetworkPolicySpec.AppliedTo.
+ 	// +optional
+ 	AppliedTo []NetworkPolicyPeer `json:""appliedTo,omitempty""`
++	// SourceGroups is a list of ClusterGroup names which must be set as the
++	// source for this rule.
++	SourceGroups []string `json:""sourceGroups,omitempty""`
++	// DestinationGroups is a list of ClusterGroup names which must be set as the
++	// destination for this rule.
++	DestinationGroups []string `json:""destinationGroups,omitempty""`
+ }
+
+ // NetworkPolicyPeer describes the grouping selector of workloads.",Not sure if this has been discussed. I wonder why SourceGroups and DestinationGroups are not in From and To NetworkPolicyPeer as NetworkPolicyPeer already describes the source/destination of the traffic.,Is there an advantage to using `map[string]struct{}` instead of `
+8771,"@@ -151,6 +151,19 @@ class Completer(QObject):
+             except KeyError:
+                 # No completion model for this section/option.
+                 model = None
++        elif completion == usertypes.Completion.keybinding:
++            # look for --mode to provide mode-specific binding completions
++            # since flags are ignored by most completers, we need to re-parse
++            parts, cursor_part = self._filter_cmdline_parts(self.split(),
++                                                            cursor_part,
++                                                            ignore_flags=False)
++            if parts[cursor_part - 1].startswith(""--mode=""):
++                mode = parts[cursor_part - 1][7:]  # strip --mode=
++                key = parts[cursor_part]
++            else:
++                mode = 'normal'
++                key = parts[cursor_part - 1]
++            model = instances.get(completion)[mode][key]
+         else:
+             model = instances.get(completion)
+ ",This doesn't account for `:bind --mode caret ...` (i.e. `--mode caret` instead of `--mode=caret`; both work). Do you see an easy way to make that work?,Should we ignore `--strict-syntax` too?
+8772,"@@ -41,7 +41,8 @@ var (
+ 	errorPriority = map[reflect.Type]int{
+ 		reflect.TypeOf(&p.ShardOwnershipLostError{}):             0,
+ 		reflect.TypeOf(&p.CurrentWorkflowConditionFailedError{}): 1,
+-		reflect.TypeOf(&p.ConditionFailedError{}):                2,
++		reflect.TypeOf(&p.WorkflowConditionFailedError{}):        2,
++		reflect.TypeOf(&p.ConditionFailedError{}):                3,
+ 	}
+
+ 	errorDefaultPriority = math.MaxInt64",Is this map used for durable state anywhere? If so we probably want to keep ConditionFailedError as 2,Hopefully we can remove `ShardOwnershipLostError` completely.
+8773,"@@ -25,6 +25,7 @@ type roundTripperOpts struct {
+ }
+
+ var dialAddr = quic.DialAddr
++var methodHEAD = ""HEAD""
+
+ // client is a HTTP2 client doing QUIC requests
+ type client struct {",You can use `http.MethodHead` here.,"I'm wondering if we should have a more generic method name, l"
+8774,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.session.remote;
++
++public class SessionTest {
++
++}",And another empty test. Please remove until there's content.,no need for this test class as there is no assertion in it.
+8775,"@@ -2,9 +2,9 @@ define([""localassetmanager""], function(localassetmanager) {
+     ""use strict"";
+
+     function processDownloadStatus(apiClient, serverInfo, options) {
+-        return console.log(""[mediasync] Begin processDownloadStatus""), localassetmanager.resyncTransfers().then(function() {
++        return console.debug(""mediasync: begin processDownloadStatus""), localassetmanager.resyncTransfers().then(function() {
+             return localassetmanager.getServerItems(serverInfo.Id).then(function(items) {
+-                console.log(""[mediasync] Begin processDownloadStatus getServerItems completed"");
++                console.debug(""mediasync: begin processDownloadStatus getServerItems completed"");
+                 var p = Promise.resolve(),
+                     cnt = 0;
+                 return items.filter(function(item) {","You really didn't need to do any of these, we need to remove the API client from source eventually anyway.","Is this related to this PR? If not, I would remove it."
+8776,"@@ -58,6 +58,9 @@ import org.tikv.kvproto.Pdpb.TsoResponse;
+
+ public class PDClient extends AbstractGRPCClient<PDBlockingStub, PDStub>
+     implements ReadOnlyPDClient {
++
++  private TiSession session;
++
+   private RequestHeader header;
+   private TsoRequest tsoReq;
+   private volatile LeaderWrapper leaderWrapper;",seems pretty strange here because TiSession contains PDClient.,"session is not a field, please remove it"
+8777,"@@ -73,4 +73,11 @@ class NotesControllerTest < ActionDispatch::IntegrationTest
+     assert_response :success
+     assert_select ""table.note_list tr"", :count => 11
+   end
++
++  def test_empty_page
++    user = create(:user)
++    get user_notes_path(:display_name => user.display_name)
++    assert_response :success
++    assert_select ""h4"", :html => ""No notes""
++  end
+ end",I created a test method for this scenario. Would you normally split it out like that or bundle this into one of the existing test methods? I'm more accustomed to creating lots of separate `it` blocks in nested `context` blocks in rspec,Align the parameters of a method call if
+8778,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent,would it make sense to move this to `/se
+8779,"@@ -5463,6 +5463,13 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable,
+     throw new IllegalArgumentException(""number of documents in the index cannot exceed "" + actualMaxDocs + "" (current document count is "" + pendingNumDocs.get() + ""; added numDocs is "" + addedNumDocs + "")"");
+   }
+
++  /**
++   * Returns the number of documents in the index including documents are being added (i.e., reserved).
++   */
++  public long getPendingNumDocs() {
++    return pendingNumDocs.get();
++  }
++
+   /** Returns the highest <a href=""#sequence_number"">sequence number</a> across
+    *  all completed operations, or 0 if no operations have finished yet.  Still
+    *  in-flight operations (in other threads) are not counted until they finish.",Maybe add `@lucene.experimental`? We are exposing (slightly) internal details about `IndexWriter` so maybe we need to reserve the right to change this API in the future ...,We don't need a new line here :)
+8780,"@@ -676,7 +676,10 @@ module Beaker
+         def sleep_until_puppetdb_started(host, nonssl_port = nil, ssl_port = nil)
+           nonssl_port = options[:puppetdb_port_nonssl] if nonssl_port.nil?
+           ssl_port = options[:puppetdb_port_ssl] if ssl_port.nil?
+-          curl_with_retries(""start puppetdb"", host, ""http://localhost:#{nonssl_port}"", 0, 120)
++          endpoint = 'status/v1/services/puppetdb-status'
++          retry_on(host,
++                   ""curl -m 1 http://localhost:#{nonssl_port}/#{endpoint} | grep '\""state\"":\""running\""'"",
++                   {:max_retries => 120})
+           curl_with_retries(""start puppetdb (ssl)"",
+                             host, ""https://#{host.node_name}:#{ssl_port}"", [35, 60])
+         end","@johnduarte I know this isn't part of your code change, but it seems to me that this `curl_with_retries` is not necessary. If the `retry_on` host command is successful, isn't puppetdb ostensibly listening to the ssl port as well? What do you think about removing that `curl_with_retries` after the `retry_on`?",I think you can just do `curl -m 1 http://localhost:#{nonssl_port}/| grep 'state'`
+8781,"@@ -17,13 +17,15 @@ package labelindex
+ import (
+ 	log ""github.com/Sirupsen/logrus""
+
++	""github.com/projectcalico/felix/set""
+ 	""github.com/projectcalico/libcalico-go/lib/selector""
++	""github.com/projectcalico/libcalico-go/lib/selector/parser""
+ )
+
+ type Index interface {
+ 	UpdateSelector(id interface{}, sel selector.Selector)
+ 	DeleteSelector(id interface{})
+-	UpdateLabels(id interface{}, labels map[string]string)
++	UpdateLabels(id interface{}, labels parser.Labels)
+ 	DeleteLabels(id interface{})
+ }
+ ","Does an empty struct really take less storage than a bool? I guess it must be, or else you wouldn't have changed this, but I'm curious about the detail.",Can you add a godoc for this function?
+8782,"@@ -259,6 +259,12 @@ class EditableTextWithoutAutoSelectDetection(EditableText):
+ 	This should be used when an object does not notify of selection changes.
+ 	""""""
+
++	def waitForAndSpeakSelectionChange(self, oldTextInfo):
++		api.processPendingEvents(processEventQueue=False)
++		newInfo=self.makeTextInfo(textInfos.POSITION_SELECTION)
++		speech.speakSelectionChange(oldTextInfo,newInfo)
++		braille.handler.handleCaretMove(self)
++
+ 	def script_caret_changeSelection(self,gesture):
+ 		try:
+ 			oldInfo=self.makeTextInfo(textInfos.POSITION_SELECTION)","nit: This should perhaps be called `waitForAndReportSelectionChange`, as it affects braille as well, not just speech.",Is there any way to use this instead of `processPendingEvents`?
+8783,"@@ -127,10 +127,14 @@ class ProxyListenerSNS(ProxyListener):
+
+             elif req_action == 'CreateTopic':
+                 topic_arn = aws_stack.sns_topic_arn(req_data['Name'][0])
+-                self._extract_tags(topic_arn, req_data)
++                tag_error_response = self._extract_tags(topic_arn, req_data, True)
++                # in case if there is an error it returns an error , other wise it will continue as expected.
++                if not tag_error_response:
++                    return make_error(code=400, code_string='InvalidParameter',
++                                  message='Topic already exists with different tags')
+
+             elif req_action == 'TagResource':
+-                self._extract_tags(topic_arn, req_data)
++                self._extract_tags(topic_arn, req_data, False)
+                 return make_response(req_action)
+
+             elif req_action == 'UntagResource':","nit: I suggest that we rename `tag_error_response` to `tag_resource_success`, as later in line 132 we're returning an error if this value is *not* truthy.",In case there is an error it will continue as expected.
+8784,"@@ -0,0 +1,15 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Shopsys\ShopBundle\Controller\Styleguide;
++
++use Shopsys\ShopBundle\Controller\Front\FrontBaseController;
++
++class StyleguideController extends FrontBaseController
++{
++    public function styleguideAction()
++    {
++        return $this->render('@ShopsysShop/Styleguide/styleguide.html.twig');
++    }
++}",I am missing return typehint,"You don't need the `@ShopsysShop` prefix here, as it is defined in the `AdminController`"
+8785,"@@ -0,0 +1,8 @@
++_base_ = [
++    'retinanet_pvt-t_fpn_1x_coco.py',
++]
++model = dict(
++    backbone=dict(
++        num_layers=[3, 4, 6, 3],
++        init_cfg=dict(checkpoint='https://github.com/whai362/PVT/'
++                      'releases/download/v2/pvt_small.pth')))",_base_ = 'retinanet_pvt-t_fpn_1x_coco.py',why did you move this file to `tests/models/test_pvt.pth`?
+8786,"@@ -394,11 +394,12 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+     private class SwapJWTForAccessTokenTask extends BaseFinishAuthFlowTask<LoginOptions> {
+
+         @Override
+-        protected TokenEndpointResponse performRequest(LoginOptions options) {
++        protected TokenEndpointResponse performRequest(LoginOptions options) throws Exception {
+             try {
+                 return OAuth2.swapJWTForTokens(HttpAccess.DEFAULT, new URI(options.loginUrl), options.jwt);
+             } catch (Exception e) {
+-                Log.w(""OAuth.SwapJWT"", e);
++                onAuthFlowError(""jwt_oauth_error"", e.getLocalizedMessage());
++                callback.finish();
+             }
+             return null;
+         }","We should remove `throws Exception` here, since we're catching it anyway and triggering `onAuthFlowError`.",I wonder if it would make sense to log the exception at the very least so it is easier t
+8787,"@@ -0,0 +1,18 @@
++package ps
++
++import ""gx/ipfs/QmepvmmYNM6q4RaUiwEikQFhgMFHXg2PLhx2E9iaRd3jmS/go-libp2p-pubsub""
++
++// Publisher publishes to pubsub topics
++type Publisher struct {
++	pubsub *pubsub.PubSub
++}
++
++// NewPublisher builds a new publisher
++func NewPublisher(sub *pubsub.PubSub) *Publisher {
++	return &Publisher{pubsub: sub}
++}
++
++// Publish publishes to a pubsub topic
++func (s *Publisher) Publish(topic string, data []byte) error {
++	return s.pubsub.Publish(topic, data)
++}","a super thin wrapper like this makes me think we should consider not having it, instead just defining in the plumbing.api the publisher and subscriber interfaces we expect a ps dependency passed in to support and then to pass calls directly to that thing rather than through this wrapper",I don't see where this is used?
+8788,"@@ -93,7 +93,7 @@ public class Docker {
+       throw new WebDriverException(""Unable to pull container: "" + name);
+     }
+
+-    LOG.info(String.format(""Pull of %s:%s complete"", name, tag));
++    LOG.fine(String.format(""Pull of %s:%s complete"", name, tag));
+
+     return findImage(new ImageNamePredicate(name, tag))
+         .orElseThrow(() -> new DockerException(",Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.,"Why did you change this to `fine`? It's not a big deal, but I think it's more consistent."
+8789,"@@ -67,10 +67,12 @@ setup(
+         ""configargparse>=0.10, <0.11"",
+         ""construct>=2.5.2, <2.6"",
+         ""cryptography>=1.3, <1.5"",
++        ""cssutils>=1.0.1, <1.1"",
+         ""Flask>=0.10.1, <0.12"",
+         ""h2>=2.4.0, <3"",
+         ""html2text>=2016.1.8, <=2016.5.29"",
+         ""hyperframe>=4.0.1, <5"",
++        ""jsbeautifier>=1.6.3""
+         ""lxml>=3.5.0, <=3.6.0"",  # no wheels for 3.6.1 yet.
+         ""Pillow>=3.2, <3.4"",
+         ""passlib>=1.6.5, <1.7"",",We should set a 1.7 upper bound for this as well. :smiley:,Is there a reason to have both `pybeautifier` and `cssutils`?
+8790,"@@ -39,11 +39,14 @@ import Spinner from 'GoogleComponents/spinner';
+ import SettingsOverlay from 'GoogleComponents/settings/settings-overlay';
+ import GenericError from 'GoogleComponents/notifications/generic-error';
+
+-const { Component, Fragment } = wp.element;
+-const { __, sprintf } = wp.i18n;
+-const { filter, map } = lodash;
+-const { applyFilters } = wp.hooks;
+-const { withFilters } = wp.components;
++/**
++ * WordPress dependencies
++ */
++import { Component, Fragment } from '@wordpress/element';
++import { __, sprintf } from '@wordpress/i18n';
++import { filter, map } from 'lodash';
++import { applyFilters } from '@wordpress/hooks';
++import { withFilters } from '@wordpress/components';
+
+ /**
+  * A single module. Keeps track of its own active state and settings.",Lodash mixed in with WordPress dependencies,Is this import necessary? We don't use it in this file.
+8791,"@@ -22,10 +22,10 @@ class StripeEvents
+     if subscription = Subscription.find_by(stripe_id: stripe_subscription.id)
+       subscription
+     else
+-      Airbrake.notify_or_ignore(
++      Honeybadger.notify(
+         error_message: ""No subscription found for #{stripe_subscription.id}"",
+         error_class: ""StripeEvents"",
+-        parameters: @event.to_hash
++        context: @event.to_hash,
+       )
+       nil
+     end",Put a comma after the last parameter of a multiline method call.,what is the difference between `parameters: @event.to_hash` and `context: @event.context`
+8792,"@@ -0,0 +1,11 @@
++describe ""User can manage their own profile"" do
++  it ""allows editing of name"" do
++    user = create(:user)
++    login_as(user)
++    visit ""/me""
++    fill_in :first_name, with: ""Some""
++    fill_in :last_name, with: ""Body""
++    click_button ""Update profile""
++    expect(page).to have_content(""Welcome, Some Body <#{user.email_address}>"")
++  end
++end",perhaps we should test that users cannot edit the profiles of others?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+8793,"@@ -43,7 +43,7 @@ class TestMasterSecretLogger(tservers.ServerTestBase):
+
+             tls.log_master_secret.close()
+             with open(logfile, ""rb"") as f:
+-                assert f.read().count(b""CLIENT_RANDOM"") >= 2
++                assert f.read().count(b""SERVER_HANDSHAKE_TRAFFIC_SECRET"") >= 2
+
+         tls.log_master_secret = _logfun
+ ",Does this mean the content changed with the new pyopenssl version? Is Wireshark already compatible with this new format?,I don't think the `CLIENT_RANDOM` is used anymore.
+8794,"@@ -618,7 +618,7 @@ func TestCachedBatch(t *testing.T) {
+ }
+
+ func TestSTXCachedBatch(t *testing.T) {
+-	ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))})
++	ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))}, config.Default.DB)
+ 	testCachedBatch(ws, t, true)
+ }
+ ",line is 147 characters (from `lll`),"`db.NewMemKVStore()` creates a new DB, so you need to create a new one."
+8795,"@@ -65,6 +65,7 @@ confspec = ConfigObj(StringIO(
+ 	#possible log levels are DEBUG, IO, DEBUGWARNING, INFO
+ 	loggingLevel = string(default=""INFO"")
+ 	showWelcomeDialogAtStartup = boolean(default=true)
++	showSpeechViewerAtStartup = boolean(default=false)
+
+ # Speech settings
+ [speech]","Perhaps move this option into a separate speechViewer section, as we are planning to also save position information as well.",Can you remove this? We already have a default setting below
+8796,"@@ -22,4 +22,9 @@ interface SegmentProductsQueryInterface
+      * @return array
+      */
+     public function getProductsByType(SegmentId $segmentId, string $type): array;
++
++    /**
++     * @return array
++     */
++    public function getAllEditedProducts(SegmentId $segmentId, ?\DateTime $dateTime = null): array;
+ }",This is not a segment responsibility this query should be in exporter-File module,I would call this `getAllEditedProducts` instead of `getAllEditedProducts`.
+8797,"@@ -174,6 +174,8 @@ class ClangTidy(analyzer_base.SourceAnalyzer):
+
+             analyzer_cmd.append(self.source_file)
+
++            analyzer_cmd.extend(['--export-fixes', result_handler.fixit_file])
++
+             analyzer_cmd.append(""--"")
+
+             analyzer_cmd.append('-Qunused-arguments')",Did you measure the performance with and without this option. Do we want to export fixits even if the `clang-apply-replacements` tool is not available in the user's PATH?,This should be moved to a new analyzer (analyzer_cmd.append('--export-fixes
+8798,"@@ -19,12 +19,12 @@ package v1alpha1
+ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1""
+ 	""github.com/pkg/errors""
+-	""k8s.io/apimachinery/pkg/apis/meta/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+
+ // Get is spc client implementation to get disk.
+ func (s *SpcObjectClient) Get(name string) (*Disk, error) {
+-	spcDiskList := s.Spc.Spec.Disks.DiskList
++	spcDiskList := s.Spc.Spec.BlockDevices.BlockDeviceList
+ 	var diskName string
+ 	for _, disk := range spcDiskList {
+ 		if name == disk {",What if we do not change this file ? Are we using this `pkg/disk/v1alpha1` elsewhere for block device requirement?,I think this import should be moved up to the top with the other `pkg/util`
+8799,"@@ -27,7 +27,7 @@ module Bolt
+         non_interactive: true
+       }
+
+-      options[:port] = @port if @port
++      options[:port] = port if port
+       options[:password] = @password if @password
+       options[:keys] = @key if @key
+       options[:verify_host_key] = if @insecure",regarding dropping the port/host/uri methods on Nod: this would `options[:port] = target.port if target.port`,The options[:port] = @port if @port is defined.
+8800,"@@ -4,9 +4,10 @@ import java.io.File;
+ import java.io.IOException;
+
+ public class FileTypeDetection {
+-
+-    public static String determineFileType(File file) throws IOException {
+-        return FileUtil.determineFileType(file, file.getName());
++    // Question: why do we need this utility? - as opposed to just calling the
++    // static method in FileUtil directly? - L.A.
++    public static String determineFileType(File file, String fileName) throws IOException {
++        return FileUtil.determineFileType(file, fileName);
+     }
+
+ }","good question - I vote we just remove, up to you if you want to handle in this PR though. (as it would require changing the places you call it; maybe moving the test? Though my guess is if we don't now, we never will.",Why don't we call `FileUtil.determineFileType` directly in `L.a`?
+8801,"@@ -15,6 +15,10 @@ module Travis
+           super << ""--gemfile-"" << config[:gemfile].to_s
+         end
+
++        def use_directory_cache?
++          super or data.cache?(:bundler)
++        end
++
+         def setup
+           super
+           setup_bundler",This is so that if we turn on bundler caching globally it still won't affect python etc. Same inheritance logic as for the cache slug.,this is probably the right place to call `use_directory_cache?` c
+8802,"@@ -58,7 +58,8 @@ namespace Nethermind.Synchronization.Peers
+         public bool CanBeAllocated(AllocationContexts contexts)
+         {
+             return !IsAsleep(contexts) &&
+-                   !IsAllocated(contexts);
++                   !IsAllocated(contexts) &&
++                   this.SupportsAllocation(contexts);
+         }
+
+         [MethodImpl(MethodImplOptions.Synchronized)]",[You can ignore it] Maybe a better method name would be IsSupported or HasSupportForAllocation?,This method name is a bit confusing since it says `CanBeAllocated
+8803,"@@ -32,7 +32,7 @@ def escape_and_globify(pattern_string):
+         pattern_string (str): The pattern string of which to make a regex.
+
+     Returns:
+-        str: The pattern string, escaped except for the ""*"", which is
++        str: The pattern string, escaped except for the ""\*"", which is
+             transformed into "".+"" (match on one or more characters).
+     """"""
+     if pattern_string is None:","Why is this changed to `\*`? The behavior of the code on line 42, shows that `*` is what's handled?",Is this line end with a period or not?
+8804,"@@ -117,6 +117,16 @@ module.exports = BaseTest.extend({
+         TestCase.assertEqual(Realm.defaultPath, newPath, ""defaultPath should have been updated"");
+     },
+
++    testRealmSchemaVersion: function() {
++        TestCase.assertEqual(Realm.schemaVersion(Realm.defaultPath), 0xFFFFFFFFFFFFFFFF);
++
++        var realm = new Realm({schema: []});
++        TestCase.assertEqual(Realm.schemaVersion(Realm.defaultPath), 0);
++
++        realm = new Realm({schema: [], schemaVersion: 2, path: 'another.realm'});
++        TestCase.assertEqual(Realm.schemaVersion('another.realm'), 2);
++    },
++
+     testRealmCreate: function() {
+         var realm = new Realm({schema: [schemas.IntPrimary, schemas.AllTypes, schemas.TestObject]});
+ ",I think this should either return `-1` or throw. I think my vote is on the former.,What is this test doing? Is it just asserting the version of the Realm that it should be the same as what it is before?
+8805,"@@ -54,6 +54,7 @@ DEFAULT_SETTINGS = {
+         'kinto.core.events.setup_transaction_hook',
+     ),
+     'event_listeners': '',
++    'heartbeat_timeout_seconds': 5,
+     'logging_renderer': 'kinto.core.logs.ClassicLogRenderer',
+     'newrelic_config': None,
+     'newrelic_env': 'dev',","I am confused, I've read 2, 3 and 5 seconds in various places",Should this be kinto.core.events.Heartbeat_timeout_seconds?
+8806,"@@ -91,7 +91,14 @@ func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error)
+ 			fcgiBackend.SetSendTimeout(rule.SendTimeout)
+
+ 			var resp *http.Response
+-			contentLength, _ := strconv.Atoi(r.Header.Get(""Content-Length""))
++
++			var contentLength int64
++			// if ContentLength is already set
++			if r.ContentLength > 0 {
++				contentLength = r.ContentLength
++			} else {
++				contentLength, _ = strconv.ParseInt(r.Header.Get(""Content-Length""), 10, 64)
++			}
+ 			switch r.Method {
+ 			case ""HEAD"":
+ 				resp, err = fcgiBackend.Head(env)",Any particular reason you chose int64 instead of int? This requires adding type conversions throughout the code below.,`if r.ContentLength > 0 { contentLength = r.ContentLength }`
+8807,"@@ -280,14 +280,16 @@ class CommandTest(QuiltTestCase):
+
+         mock_input.return_value = old_refresh_token
+
+-        with pytest.raises(command.CommandException, match='Invalid team name'):
++        with pytest.raises(command.CommandException,
++                match='The team you specified is not a valid team.'):
+             command.login('fo!o')
+
+         mock_open.assert_not_called()
+         mock_login_with_token.assert_not_called()
+
+     def test_login_with_token_invalid_team(self):
+-        with pytest.raises(command.CommandException, match='Invalid team name'):
++        with pytest.raises(command.CommandException,
++                match='The team you specified is not a valid team.'):
+             command.login_with_token('123', 'fo!o')
+
+     @patch('quilt.tools.command._save_auth')",this string should really be a local constant. it's repeated below.,Maybe it would make sense to test the `None` case as well?
+8808,"@@ -194,6 +194,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+                 int i => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: Convert.ToInt64(i)),
+                 long l => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: l),
+                 float f => new JaegerTag(attribute.Key, JaegerTagType.DOUBLE, vDouble: Convert.ToDouble(f)),
++                short sh => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: Convert.ToInt64(sh)),
+                 double d => new JaegerTag(attribute.Key, JaegerTagType.DOUBLE, vDouble: d),
+                 bool b => new JaegerTag(attribute.Key, JaegerTagType.BOOL, vBool: b),
+                 _ => new JaegerTag(attribute.Key, JaegerTagType.STRING, vStr: attribute.Value.ToString()),","Number types are hard  . Should we be considering byte/sbyte? What about unsigned variants that would otherwise fit in a signed 64 bit integer like UInt16, UInt32?","Please don't create a new `JaegerTag` instance just for this. Instead, create a new `JaegerTag` instance in the serializer and pass it along to the `JaegerTag` constructor. This way, you don't have to create a new `JaegerTag` instance every time."
+8809,"@@ -170,7 +170,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [MemberData(nameof(HostHeaderData))]
+         public void ValidHostHeadersParsed(string host)
+         {
+-            Assert.True(HttpUtilities.IsValidHostHeader(host));
++            HttpUtilities.ValidateHostHeader(host);
++            Assert.True(true);
+         }
+
+         public static TheoryData<string> HostHeaderInvalidData",`Assert.True(true)`...   xunit used to have Assert.DoesNotThrow  ,You can remove the `Assert.True(true);` line above as well.
+8810,"@@ -3,8 +3,9 @@ if ENV[""S3_BUCKET_NAME""] && ENV[""S3_ACCESS_KEY_ID""] && ENV[""S3_SECRET_ACCESS_KEY
+     bucket: ENV[""S3_BUCKET_NAME""],
+     s3_credentials: {
+       access_key_id: ENV[""S3_ACCESS_KEY_ID""],
+-      secret_access_key: ENV[""S3_SECRET_ACCESS_KEY""]
++      secret_access_key: ENV[""S3_SECRET_ACCESS_KEY""],
+     },
++    s3_region: ""us-east-1"",
+     s3_permissions: :private,
+     storage: :s3,
+   )",should this be an env var like the other `S3_*` values?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+8811,"@@ -9,3 +9,12 @@ export function assign(obj, props) {
+ 	for (let i in props) obj[i] = props[i];
+ 	return /** @type {O & P} */ (obj);
+ }
++
++/**
++ * Remove a child node from its parent if attached.
++ * @param {Node} node The node to remove
++ */
++export function removeNode(node) {
++	let parentNode = node.parentNode;
++	if (parentNode) parentNode.removeChild(node);
++}","If you do go this route, I think it would be worth adding a note here that IE 11 is the only reason why we're not using the more obvious `node.remove()`.",Can we call this `removeChildren`?
+8812,"@@ -26,7 +26,7 @@ class RecommendationChecker(checkers.BaseChecker):
+             ""consider-iterating-dictionary"",
+             ""Emitted when the keys of a dictionary are iterated through the .keys() ""
+             ""method. It is enough to just iterate through the dictionary itself, as ""
+-            'in ""for key in dictionary"".',
++            'in ""for key in dictionary"" or ""if key in dictionary"".',
+         ),
+         ""C0206"": (
+             ""Consider iterating with .items()"",",The added text doesn't really match why it's possible. Maybe it would be better to name that as a separate case for this checker? (e.g. dict lookup is quicker than list comparison),Is this a change in behavior here? Previously we were iterating through the values in the dictionary. Now we don't.
+8813,"@@ -63,7 +63,7 @@ class Image implements EntityFileUploadInterface
+     protected $position;
+
+     /**
+-     * @var \Datetime
++     * @var \DateTime
+      *
+      * @ORM\Column(type=""datetime"")
+      */",just whether we are not missing some doctrine extension because above this attribute is nullable position and it shows int instead of int|null but maybe for lvl2 it is OK,Why did you change all of these to \DateTime instead of \DateTimeOffset ?
+8814,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,`caps` could be `null`
+8815,"@@ -1030,7 +1030,7 @@ bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, con
+                                      ""vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have ""
+                                      ""either VkImageDrmFormatModifierListCreateInfoEXT or ""
+                                      ""VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain"");
+-                } else if (drm_format_mod_list != nullptr) {
++                } else if (drm_format_mod_explict != nullptr) {
+                     image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
+                 } else if (drm_format_mod_list != nullptr) {
+                     for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {",":grimacing: yikes, thanks for catching this!",I don't understand why `drm_format_mod_list` is not a `std::vector<uint32_t>`
+8816,"@@ -0,0 +1,10 @@
++using System;
++using MvvmCross.Droid.Support.V7.RecyclerView.Model;
++
++namespace MvvmCross.Droid.Support.V7.RecyclerView
++{
++    public interface IMvxRecyclerAdapterBindableHolder
++    {
++        event Action<MvxViewHolderBindedEventArgs> MvxViewHolderBinded;
++    }
++}",`Binded` is weird. I think it needs to be something with `Bound` in it (and drop the `Mvx` bit) like `ViewHolderBound` or something.,Can we rename this to `MvvmRecyclerAdapter`?
+8817,"@@ -84,8 +84,8 @@ func importPoolBuilder(cStorPool *apis.CStorPool, cachefileFlag bool) []string {
+ }
+
+ // CreatePool creates a new cStor pool.
+-func CreatePool(cStorPool *apis.CStorPool) error {
+-	createAttr := createPoolBuilder(cStorPool)
++func CreatePool(cStorPool *apis.CStorPool, diskList []string) error {
++	createAttr := createPoolBuilder(cStorPool, diskList)
+ 	glog.V(4).Info(""createAttr : "", createAttr)
+
+ 	stdoutStderr, err := RunnerVar.RunCombinedOutput(PoolOperator, createAttr...)",can we have String() and GoString() implementation of `apis.CStorPool` struct to pretty print it.,why are we passing a slice of strings here?
+8818,"@@ -914,6 +914,10 @@ CheckedError Parser::ParseTable(const StructDef &struct_def, std::string *value,
+   size_t fieldn = 0;
+   auto err = ParseTableDelimiters(fieldn, &struct_def,
+                                   [&](const std::string &name) -> CheckedError {
++    if (name == ""$schema"") {
++      NEXT(); // Ignore this field.
++      return NoError();
++    }
+     auto field = struct_def.fields.Lookup(name);
+     if (!field) {
+       if (!opts.skip_unexpected_fields_in_json) {","Like I said, please replace by `EXPECT(kTokenString)`",`if ($schema) {`
+8819,"@@ -32,6 +32,7 @@ import org.apache.commons.logging.Log;
+ import org.apache.commons.logging.LogFactory;
+
+ import org.springframework.security.authentication.AuthenticationCredentialsNotFoundException;
++import org.springframework.security.authentication.AuthenticationDetailsSource;
+ import org.springframework.security.authentication.AuthenticationManager;
+ import org.springframework.security.authentication.AuthenticationTrustResolver;
+ import org.springframework.security.authentication.AuthenticationTrustResolverImpl;",Will you please update the copyright message to `2021` for classes that you modify?,Unused import - will fix during merge.
+8820,"@@ -301,6 +301,8 @@
+                 getSelectedRows: function () {
+                   return service.getSelectedRows(grid).map(function (gridRow) {
+                     return gridRow.entity;
++                  }).filter(function (entity) {
++                    return entity.hasOwnProperty('$$hashKey');
+                   });
+                 },
+                 /**","Is there a better way to filter these other than relying on the hashKey. I few like this might now be trustworthy in the long run. If angular ever removes this property, this feature would be broken.",this shouldn't be here
+8821,"@@ -2012,7 +2012,11 @@ os_tls_thread_exit(local_state_t *local_state)
+
+     /* We already set TLS to &uninit_tls in os_thread_exit() */
+
+-    if (dynamo_exited && !last_thread_tls_exited) {
++    /* Do not set last_thread_tls_exited if a client_thread is exiting.
++     * If set, get_thread_private_dcontext() returns NULL, which may cause
++     * other thread fault on using dcontext.
++     */
++    if (dynamo_exited && dynamo_exited_synched && !last_thread_tls_exited) {
+         last_thread_tls_exited = true;
+         first_thread_tls_initialized = false; /* for possible re-attach */
+     }",No need to check dynamo_exited,This is the actual fix
+8822,"@@ -47,8 +47,11 @@ func (c *Config) SetDevice(deviceName string) {
+ 	c.setParam(""dev"", deviceName)
+ }
+
+-func (c *Config) SetTlsCertificate(caFile, certFile, certKeyFile string) {
++func (c *Config) SetTlsCACertificate(caFile string) {
+ 	c.AddOptions(OptionFile(""ca"", caFile))
++}
++
++func (c *Config) SetTlsPrivatePubKeys(certFile string, certKeyFile string) {
+ 	c.AddOptions(OptionFile(""cert"", certFile))
+ 	c.AddOptions(OptionFile(""key"", certKeyFile))
+ }",from linter: >method SetTlsCACertificate should be SetTLSCACertificate,did you mean to change
+8823,"@@ -519,11 +519,11 @@ public abstract class SpanStoreTest {
+
+     Span trace2 = Span.builder().traceId(2).name(""get"").id(2)
+         .timestamp((today + 2) * 1000)
+-        .addAnnotation(Annotation.create((today + 1) * 1000, CLIENT_SEND, APP_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, SERVER_RECV, WEB_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, SERVER_SEND, WEB_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, CLIENT_RECV, APP_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, ""app"", APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, CLIENT_SEND, APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, SERVER_RECV, WEB_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, SERVER_SEND, WEB_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, CLIENT_RECV, APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, ""app"", APP_ENDPOINT))
+         .addBinaryAnnotation(BinaryAnnotation.create(""local"", ""app"", APP_ENDPOINT))
+         .addBinaryAnnotation(BinaryAnnotation.create(""app-b"", ""app"", APP_ENDPOINT))
+         .build();",this data had incorrectly aligned timestamps (which wasn't the point of the test),Can you explain why th
+8824,"@@ -280,6 +280,16 @@ func (w *Workflow) populateStep(ctx context.Context, s *Step) error {
+ 	return step.populate(ctx, s)
+ }
+
++func getUser() string {
++	if cu, err := user.Current(); err == nil {
++		return cu.Username
++	}
++	if hn, err := os.Hostname(); err == nil {
++		return hn
++	}
++	return ""unknown""
++}
++
+ func (w *Workflow) populate(ctx context.Context) error {
+ 	var err error
+ 	if w.ComputeClient == nil {","Since this is workflow agnostic, should we put this in common?",This should be done in the controller so that we don't have to repeat the code in every single place.
+8825,"@@ -54,6 +54,13 @@ class SourceAnalyzer(object):
+         """"""
+         raise NotImplementedError(""Subclasses should implement this!"")
+
++    @classmethod
++    def version_compatible(cls, configured_binary, environ):
++        """"""
++        Checker the version compatibility of the given analyzer binary.
++        """"""
++        raise NotImplementedError(""Subclasses should implement this!"")
++
+     @classmethod
+     def construct_config_handler(cls, args, context):
+         """""" Should return a subclass of AnalyzerConfigHandler.""""""",using the `@abstractmethod` decorator wouldn't be better?,Why can't we just call it `version`? It's kind of vague.
+8826,"@@ -21,7 +21,7 @@ final class BooleanConfigurator implements FieldConfiguratorInterface
+     public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $context): void
+     {
+         $isRenderedAsSwitch = true === $field->getCustomOption(BooleanField::OPTION_RENDER_AS_SWITCH);
+-        if ($isRenderedAsSwitch && false !== strpos($field->getProperty(), '.')) {
++        if ($isRenderedAsSwitch && $this->isNestedProperty($field) && false === $this->isBoolean($field)) {
+             throw new \InvalidArgumentException(sprintf('The ""%s"" property cannot be rendered as a switch because it belongs to an associated entity instead of to the entity itself. Render the property as a normal boolean field.', $field->getProperty()));
+         }
+ ",This was crashing the app during EDIT on boolean Doctrine Embedded properties,@wachterjohannes Can you have a look at this? It seems to me that if we have a property that is not a
+8827,"@@ -45,7 +45,7 @@
+
+ #include ""board_common.h""
+
+-#define DFL_SYSFS_SEC_GLOB ""*dfl*/*spi*/*spi*/*spi*/**/security/""
++#define DFL_SYSFS_SEC_GLOB ""*dfl*/**/security/""
+ #define DFL_SYSFS_SEC_USER_FLASH_COUNT         DFL_SYSFS_SEC_GLOB ""*flash_count""
+ #define DFL_SYSFS_SEC_BMC_CANCEL               DFL_SYSFS_SEC_GLOB ""bmc_canceled_csks""
+ #define DFL_SYSFS_SEC_BMC_ROOT                 DFL_SYSFS_SEC_GLOB ""bmc_root_entry_hash""",Will this be backwards compatible with the previous path?,Please don't make unrelated changes like this. It's hard to see what actually changed.
+8828,"@@ -29,6 +29,11 @@ namespace OpenTelemetry.Trace
+         /// </summary>
+         ISpan CurrentSpan { get; }
+
++        /// <summary>
++        /// Gets the current scope from the context.
++        /// </summary>
++        IScope CurrentScope { get; }
++
+         /// <summary>
+         /// Gets the <see cref=""IBinaryFormat""/> for this implementation.
+         /// </summary>",what is potential use for current scope? It seems you'd only want it to stop it. But if you get current scope you never know if it's yours to stop - i.e. this is not safe or correct to stop current scope. So I wonder should we even try to expose it?,Shouldn't this be nullable?
+8829,"@@ -76,7 +76,9 @@ describe( 'User Input Settings', () => {
+ 			'enter keywords',
+ 			async () => {
+ 				await expect( page ).toClick( '.googlesitekit-user-input__buttons--next' );
+-				await expect( page ).toFill( '#searchTerms-keyword-0', 'One,Two,Three,' );
++				await expect( page ).toFill( '#searchTerms-keyword-0', 'One' );
++				await expect( page ).toFill( '#searchTerms-keyword-1', 'Two' );
++				await expect( page ).toFill( '#searchTerms-keyword-2', 'Three' );
+ 			},
+ 		);
+ ",I think this is likely the only additional change needed on the original PR.,We can skip the `await` now
+8830,"@@ -5,10 +5,12 @@ import android.content.SharedPreferences;
+ import android.content.res.Configuration;
+ import android.util.AttributeSet;
+ import android.view.View;
++
+ import androidx.appcompat.view.ContextThemeWrapper;
+ import androidx.recyclerview.widget.DividerItemDecoration;
+ import androidx.recyclerview.widget.LinearLayoutManager;
+ import androidx.recyclerview.widget.RecyclerView;
++
+ import de.danoeh.antennapod.R;
+ import io.reactivex.annotations.Nullable;
+ ",Please revert changes to unrelated file,nit: Unnecessary new line
+8831,"@@ -0,0 +1,14 @@
++package azkaban.execapp.fake;
++
++import org.mortbay.jetty.Connector;
++import org.mortbay.jetty.Server;
++import org.mortbay.jetty.bio.SocketConnector;
++
++public class FakeServer extends Server {
++
++  @Override
++  public Connector[] getConnectors() {
++    return new Connector[]{new SocketConnector()};
++  }
++
++}",Can test use a Mockito mock instance instead?,Why do we need this connect
+8832,"@@ -47,12 +47,13 @@ import java.lang.reflect.Method;
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+         severity = BugPattern.SeverityLevel.WARNING,
+-        summary = ""InvocationHandlers which delegate to another object must catch and unwrap ""
+-                + ""InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown ""
+-                + ""each time the delegate throws an exception.\n""
+-                + ""This check is intended to be advisory. It's fine to ""
+-                + ""@SuppressWarnings(\""InvocationHandlerDelegation\"") in certain cases, ""
+-                + ""but is usually not recommended."")
++        summary =
++                ""InvocationHandlers which delegate to another object must catch and unwrap ""
++                        + ""InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown ""
++                        + ""each time the delegate throws an exception.\n""
++                        + ""This check is intended to be advisory. It's fine to ""
++                        + ""@SuppressWarnings(\""InvocationHandlerDelegation\"") in certain cases, ""
++                        + ""but is usually not recommended."")
+ public final class InvocationHandlerDelegation extends BugChecker implements BugChecker.MethodInvocationTreeMatcher {
+
+     private static final Matcher<MethodTree> INVOCATION_HANDLER = Matchers.anyOf(",Bit of a shame about these multi-line strings in annotation parameters - they're not a deal breaker but just make the diff noisier,The parenthesis should be on the next line.
+8833,"@@ -61,6 +61,11 @@ namespace Microsoft.Rest.Generator.NodeJS
+             }
+         }
+
++        public List<T> ConvertIEnumerableToList<T>(IEnumerable<T> enumerable)
++        {
++            return new List<T>(enumerable);
++        }
++
+         public bool IsPolymorphic
+         {
+             get",we can remove this one as this is not used any more,Does this need to be public?
+8834,"@@ -90,7 +90,6 @@ public abstract class LongRunningConfig {
+   private static LongRunningConfig createLongRunningConfigFromProtoFile(
+       Method method, DiagCollector diagCollector, ProtoParser protoParser) {
+
+-    boolean error = false;
+     Model model = method.getModel();
+     OperationTypes operationTypes = protoParser.getLongRunningOperation(method);
+     if (operationTypes == null",we don't really need an extra error flag,"If this method returns null, what's the poi"
+8835,"@@ -21,11 +21,15 @@ import com.google.common.collect.ImmutableList;
+ import java.io.File;
+ import java.util.AbstractList;
+ import java.util.List;
++import java.util.Optional;
+ import java.util.stream.Collectors;
+-import net.ltgt.gradle.errorprone.ErrorPronePlugin;
++import net.ltgt.gradle.errorprone.javacplugin.CheckSeverity;
++import net.ltgt.gradle.errorprone.javacplugin.ErrorProneJavacPluginPlugin;
++import net.ltgt.gradle.errorprone.javacplugin.ErrorProneOptions;
+ import org.gradle.api.Plugin;
+ import org.gradle.api.Project;
+ import org.gradle.api.file.FileCollection;
++import org.gradle.api.plugins.ExtensionAware;
+ import org.gradle.api.plugins.JavaPluginConvention;
+ import org.gradle.api.tasks.compile.JavaCompile;
+ import org.gradle.api.tasks.javadoc.Javadoc;",any chance you could just fix the processors plugin?,Change it to `javax.validation.constraints.
+8836,"@@ -22,7 +22,8 @@ model = dict(
+         basesize_ratio_range=(0.15, 0.9),
+         anchor_ratios=([2], [2, 3], [2, 3], [2, 3], [2], [2]),
+         target_means=(.0, .0, .0, .0),
+-        target_stds=(0.1, 0.1, 0.2, 0.2)))
++        target_stds=(0.1, 0.1, 0.2, 0.2),
++        use_depthwise=False))
+ cudnn_benchmark = True
+ train_cfg = dict(
+     assigner=dict(",We may keep this config unchanged since `use_depthwise=True` by default.,Do all the copies of target_stds need use_depthwise?
+8837,"@@ -566,6 +566,15 @@ privload_process_imports(privmod_t *mod)
+                     privload_locate_and_load(name, mod, false /*client dir=>true*/);
+                 if (impmod == NULL)
+                     return false;
++                if (strstr(name, ""libpthread"") == name) {
++                    /* i#956: A private libpthread is not fully supported, but many
++                     * libraries import some utilities from it and do not use
++                     * threading.  We load it and just do not guarantee things will
++                     * work if thread-related routines are called.
++                     */
++                    SYSLOG_INTERNAL_WARNING(
++                        ""private libpthread.so loaded but not fully supported"");
++                }
+                 /* i#852: identify all libs that import from DR as client libs.
+                  * XXX: this code seems stale as libdynamorio.so is already loaded
+                  * (xref #3850).",Maybe add i#956 in this log as well.,Should this be a fatal error instead of a warning?
+8838,"@@ -438,6 +438,11 @@ void Player::updateInventoryWeight()
+ 			inventoryWeight += item->getWeight();
+ 		}
+ 	}
++
++	StoreInbox* storeInbox = getStoreInbox();
++	if (storeInbox) {
++		inventoryWeight += storeInbox->getWeight();
++	}
+ }
+
+ void Player::addSkillAdvance(skills_t skill, uint64_t count)",if (StoreInbox* storeInbox = getStoreInbox()) {,"please reword the function name, it's not obvious wh"
+8839,"@@ -459,9 +459,14 @@ API.prototype._import = function(cb) {
+   });
+ };
+
++
++API.prototype.importAllFromMnemonic = function(words, opts, cb) {
++}
++
+ /**
+  * Import from Mnemonics (language autodetected)
+  * Can throw an error if mnemonic is invalid
++ * Will try compilant and non-compliantDerivation
+  *
+  * @param {String} BIP39 words
+  * @param {Object} opts","what is this, is it going to be used later?",I think this would be better named `importAllFromMne
+8840,"@@ -66,8 +66,7 @@ module Beaker
+       name = host.name
+       Dir.stub( :chdir ).and_yield()
+
+-      out = double( 'stdout' )
+-      out.stub( :read ).and_return(""Host #{host.name}
++      vagrant.should_receive(:`).and_return(""Host #{host.name}
+     HostName 127.0.0.1
+     User vagrant
+     Port 2222","@anodelman test failure is probably due to this, needs to be fixed to `(""Host #{host.name}"")`",Do we need to stub `vagrant.should_receive(:stdout)`?
+8841,"@@ -75,10 +75,10 @@
+
+
+
+-<div class=""cart-comments-container"">
+-  <div id=""cart-comments"">
+-    <h3>Comments on this purchase request</h3>
+-    <%- if @show_comments %>
++<%- if @include_comments_files %>
++  <div class=""cart-comments-container proposal-submodel-container"">
++    <div id=""cart-comments"">
++      <h3>Comments on this purchase request</h3>
+       <%= form_for [cart, Comment.new] do |f| %>
+         <%= f.text_area :comment_text, rows: 5 %>
+ ","I'm not sure that we need this anymore, but that can be a separate discussion.",It doesn't look like this variable is used anywhere.
+8842,"@@ -34,10 +34,14 @@ public interface HttpClient {
+    * @throws IOException if an I/O error occurs.
+    */
+   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
+-
++
+   /**
+-   * Creates HttpClient instances.
+-   */
++	* Closes the connections associated with this client.
++	*
++	* @throws  IOException  if an I/O error occurs.
++	*/
++  void close() throws IOException;
++
+   interface Factory {
+
+     /**",The formatting seems different from the rest of the code,NIT: unnecessary change.
+8843,"@@ -709,6 +709,9 @@ func (cg *ConfigGenerator) generateProbeConfig(
+ 	if m.Spec.ProberSpec.Scheme != """" {
+ 		cfg = append(cfg, yaml.MapItem{Key: ""scheme"", Value: m.Spec.ProberSpec.Scheme})
+ 	}
++	if m.Spec.ProberSpec.ProxyURL != """" {
++		cfg = append(cfg, yaml.MapItem{Key: ""proxy_url"", Value: m.Spec.ProberSpec.ProxyURL})
++	}
+
+ 	if m.Spec.Module != """" {
+ 		cfg = append(cfg, yaml.MapItem{Key: ""params"", Value: yaml.MapSlice{",Could we have a unit test for this?,I wonder if `ProxyURL` shouldn't be part of `ProberSp
+8844,"@@ -477,9 +477,11 @@ func (c *temporalImpl) startHistory(
+ 			}
+ 		}
+
++		stoppedCh := make(chan struct{})
+ 		var historyService *history.Service
+ 		app := fx.New(
+-			fx.Supply(params),
++			fx.Supply(params,
++				stoppedCh),
+ 			history.Module,
+ 			fx.Populate(&historyService))
+ 		err = app.Err()",nit: put params in new line,Nit: `stoppedCh` could be local to the `app` definition so that it's not reused for subsequent calls.
+8845,"@@ -100,13 +100,15 @@ export default function DateRangeSelector() {
+ 					'mdc-button--dropdown',
+ 					'googlesitekit-header__dropdown',
+ 					'googlesitekit-header__date-range-selector-menu',
++					'googlesitekit-border-radius-round--phone',
++					'googlesitekit-button-icon--phone',
+ 					{
+ 						'googlesitekit-header__date-range-selector-menu--has-unified-dashboard': unifiedDashboardEnabled,
+ 					}
+ 				) }
+ 				text
+ 				onClick={ handleMenu }
+-				icon={ <DateRangeIcon width=""18"" height=""20"" /> }
++				icon={ <DateRangeIcon width=""20"" height=""20"" /> }
+ 				aria-haspopup=""menu""
+ 				aria-expanded={ menuOpen }
+ 				aria-controls=""date-range-selector-menu""",The button for the date range selector has incorrect width since it has `padding-right: 8px` which sets the width to: `44px`. Can you review to make the button `36px` on small screens as per the AC?,"Why did you change the icon from ""18"" to ""18""?"
+8846,"@@ -2836,8 +2836,13 @@ client_process_bb(dcontext_t *dcontext, build_bb_t *bb)
+ #    ifdef X86
+         if (!d_r_is_avx512_code_in_use()) {
+             if (ZMM_ENABLED()) {
+-                if (instr_may_write_zmm_register(inst))
++                if (instr_may_write_zmm_register(inst)) {
++                    LOG(THREAD, LOG_INTERP, 2, ""Detected AVX-512 code in use\n"");
++                    SELF_UNPROTECT_DATASEC(DATASEC_RARELY_PROT);
+                     d_r_set_avx512_code_in_use(true);
++                    proc_set_num_simd_saved(MCXT_NUM_SIMD_SLOTS);
++                    SELF_PROTECT_DATASEC(DATASEC_RARELY_PROT);
++                }
+             }
+         }
+ #    endif",This should be inside the set routine IMHO: matches the others; all callers need it; simplifies code here.,(style) line over 80 characters
+8847,"@@ -106,6 +106,8 @@ public class TwoPhaseCommitter {
+   /** unit is second */
+   private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3000;
+
++  private static final long MAX_RETRY_LEVEL = 3;
++
+   private static final Logger LOG = LoggerFactory.getLogger(TwoPhaseCommitter.class);
+
+   private TxnKVClient kvClient;",MAX_RETRY_TIMES makes much more sense.,Can we make this configurable?
+8848,"@@ -56,6 +56,7 @@ type testContext struct {
+ 	fakeStatsKeeper       *fakeSessionStatsKeeper
+ 	fakeDialog            *fakeDialog
+ 	fakePromiseIssuer     *fakePromiseIssuer
++	fakeStorage           *fakeStorage
+ 	sync.RWMutex
+ }
+ ","`saveSession` allows easier mocking - just save function which You need, instead full interface",why do we need this?
+8849,"@@ -211,7 +211,8 @@ class Bucket(object):
+                 raise self.connection.provider.storage_response_error(
+                     response.status, response.reason, '')
+
+-    def list(self, prefix='', delimiter='', marker='', headers=None):
++    def list(self, prefix='', delimiter='', marker='', headers=None,
++             encoding_type=None):
+         """"""
+         List key objects within a bucket.  This returns an instance of an
+         BucketListResultSet that automatically handles all of the result",No docs for the new param here?,I think this should
+8850,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright ConsenSys AG.
++ * Copyright Contributors to Hyperledger Besu.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
+  * the License. You may obtain a copy of the License at",This file is unrelated to the aims of this PR. Please remove. If it is needed to demonstrate Sonar Deltas then it has been proven and can be removed.,Could you revert the
+8851,"@@ -42,5 +42,12 @@ namespace OpenTelemetry.Trace.Export
+         /// <param name=""cancellationToken"">Cancellation token.</param>
+         /// <returns>Returns <see cref=""Task""/>.</returns>
+         public abstract Task ShutdownAsync(CancellationToken cancellationToken);
++
++        /// <summary>
++        /// Flushes all activity objects that have been queued for processing.
++        /// </summary>
++        /// <param name=""cancellationToken"">Cancellation token.</param>
++        /// <returns>Returns <see cref=""Task""/>.</returns>
++        public abstract Task ForceFlushAsync(CancellationToken cancellationToken);
+     }
+ }","minor: `Export all ended spans to the configured Exporter that have not yet been exported.` - This is the spec description. Lets use something on that line. ""queue"" is not necessarily present for all processor.",Let's call this `For
+8852,"@@ -683,6 +683,8 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
+ 		ActionDigest:    digest,
+ 		SkipCacheLookup: skipCacheLookup,
+ 	}, updateProgress)
++	log.Debug(""completed ExecuteAndWaitProgress() for %v"", target.Label)
++
+ 	if err != nil {
+ 		// Handle timing issues if we try to resume an execution as it fails. If we get a
+ 		// ""not found"" we might find that it's already been completed and we can't resume.",is this deliberate? or testing?,"Do we want this on `Info` level, or should it be `Debug`?"
+8853,"@@ -24,7 +24,7 @@ namespace OpenTelemetry
+ {
+     public class CompositeProcessor<T> : BaseProcessor<T>
+     {
+-        private DoublyLinkedListNode head;
++        private readonly DoublyLinkedListNode head;
+         private DoublyLinkedListNode tail;
+         private bool disposed;
+ ","I want to get more perspectives regarding this one. Making it `readonly` makes me feel that we're assuming the head should never change, and my worry is that other code might assume it (e.g. they might cache the value and assume it will never change). While this is true for now, I guess in the future we might want to support something like `PrependProcessor(processor)` or `InsertProcessor(index, processor)`.",Is there a reason for making this readonly?
+8854,"@@ -65,7 +65,7 @@ public class TestIndexSortSortedNumericDocValuesRangeQuery extends LuceneTestCas
+         iw.deleteDocuments(LongPoint.newRangeQuery(""idx"", 0L, 10L));
+       }
+       final IndexReader reader = iw.getReader();
+-      final IndexSearcher searcher = newSearcher(reader, false);
++      final IndexSearcher searcher = newSearcher(reader);
+       iw.close();
+
+       for (int i = 0; i < 100; ++i) {","This isn't critical for test coverage, but it seemed off that we had disabled wrapping the reader.",Might want to rename this variable to `indexSearcher`
+8855,"@@ -21,9 +21,9 @@ _descList = []
+
+ def _setupDescriptors(namespace):
+   global _descList, descList
+-  from rdkit.Chem import GraphDescriptors, MolSurf, Lipinski, Fragments, Crippen
++  from rdkit.Chem import GraphDescriptors, MolSurf, Lipinski, Fragments, Crippen, Descriptors3D
+   from rdkit.Chem.EState import EState_VSA
+-  mods = [GraphDescriptors, MolSurf, EState_VSA, Lipinski, Crippen, Fragments]
++  mods = [GraphDescriptors, MolSurf, EState_VSA, Lipinski, Crippen,Descriptors3D, Fragments]
+
+   otherMods = [Chem]
+ ",Please remove Descriptors3D from this file. We just did this in master.,How do you feel about moving this to a new function in `_
+8856,"@@ -15,12 +15,17 @@ namespace storage {
+
+ StorageClient::StorageClient(std::shared_ptr<folly::IOThreadPoolExecutor> threadPool)
+         : ioThreadPool_(threadPool) {
+-    client_ = std::make_unique<meta::MetaClient>();
+-    client_->init();
+     clientsMan_
+         = std::make_unique<thrift::ThriftClientManager<storage::cpp2::StorageServiceAsyncClient>>();
+ }
+
++
++void StorageClient::init(meta::MetaClient *client) {
++    CHECK(client);
++    client_ = client;
++}
++
++
+ folly::SemiFuture<StorageRpcResponse<cpp2::ExecResponse>> StorageClient::addVertices(
+         GraphSpaceID space,
+         std::vector<cpp2::Vertex> vertices,","You could pass the MetaClient instance in ctor, and create a new instance if nullptr.",Do we really need this `init` function? It is only called from `start()` and `stop()` anyway.
+8857,"@@ -264,7 +264,11 @@ func subincludeTarget(s *scope, l core.BuildLabel) *core.BuildTarget {
+ 		s.NAssert(s.contextPkg.Target(l.Name) == nil, ""Target :%s is not defined in this package; it has to be defined before the subinclude() call"", l.Name)
+ 	}
+ 	s.NAssert(l.IsAllTargets() || l.IsAllSubpackages(), ""Can't pass :all or /... to subinclude()"")
++	// Temporarily release the parallelism limiter; this is important to keep us from deadlocking
++	// all available parser threads (easy to happen if they're all waiting on a single target which now can't start)
++	<-s.interpreter.limiter
+ 	t := s.state.WaitForBuiltTarget(l, pkgLabel)
++	s.interpreter.limiter <- struct{}{}
+ 	// This is not quite right, if you subinclude from another subinclude we can basically
+ 	// lose track of it later on. It's hard to know what better to do at this point though.
+ 	s.contextPkg.RegisterSubinclude(l)",What does this do? Seems like a poor mans mutex/semaphore?,why do we want to block on this?
+8858,"@@ -45,5 +45,5 @@ type ResponseWriter interface {
+ 	// SetApplicationError specifies that this response contains an
+ 	// application error. If called, this MUST be called before any invocation
+ 	// of Write().
+-	SetApplicationError()
++	SetApplicationError(err error)
+ }","This is a breaking change, and cannot be made. We have committed to this API for v1.",The `err` parameter is unused here. Should we remove it?
+8859,"@@ -136,16 +136,14 @@ class StatementsAnalyzer extends SourceAnalyzer implements StatementsSource
+      * Checks an array of statements for validity
+      *
+      * @param  array<PhpParser\Node\Stmt>   $stmts
+-     * @param  Context|null                                     $global_context
+-     * @param  bool                                             $root_scope
+      *
+      * @return null|false
+      */
+     public function analyze(
+         array $stmts,
+         Context $context,
+-        Context $global_context = null,
+-        $root_scope = false
++        ?Context $global_context = null,
++        bool $root_scope = false
+     ) {
+         if (!$stmts) {
+             return;",Can also drop corresponding types from docblock here,`?Context` should also be `?Context`.
+8860,"@@ -105,7 +105,7 @@ public class RequestHandler implements Comparable<RequestHandler> {
+   public void process() {
+     switch (request.getRequestType()) {
+       case START_SESSION:
+-        log.info(""Got a request to create a new session: ""
++        log.finest(""Got a request to create a new session: ""
+                  + new DesiredCapabilities(request.getDesiredCapabilities()));
+         try {
+           registry.addNewSessionRequest(this);",This change is unhelpful to users.,"This is the log message from an API call, so it should not be fined."
+8861,"@@ -59,6 +59,8 @@ public struct Vec3 : IFlatbufferObject
+   }
+   public static Offset<MyGame.Example.Vec3> Pack(FlatBufferBuilder builder, Vec3T _o) {
+     if (_o == null) return default(Offset<MyGame.Example.Vec3>);
++    var _test3_a = _o.Test3.A;
++    var _test3_b = _o.Test3.B;
+     return CreateVec3(
+       builder,
+       _o.X,",why is this variable introduced? Please stick `_o.Test3.A` directly in the call below.,"Forgive me my stupid question, but how does `_o.Test3` relate to `_t"
+8862,"@@ -88,7 +88,7 @@ module.exports.app = (options = {}) => {
+   app.get('/:providerName/logout', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.logout)
+   app.get('/:providerName/authorized', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.authorized)
+   app.get('/:providerName/list/:id?', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.list)
+-  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.get)
++  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.get)
+   app.get('/:providerName/thumbnail/:id', middlewares.hasSessionAndProvider, middlewares.cookieAuthToken, middlewares.verifyToken, controllers.thumbnail)
+
+   app.param('providerName', providerManager.getProviderMiddleware(providers))",do you mind sharing what is the reason for this change?,The fact that `middles.gentleVerifyToken` doesn't exist is a good pr
+8863,"@@ -27,11 +27,11 @@ class ProposalsController < ApplicationController
+     @pending_data = listing.pending
+     @pending_review_data = listing.pending_review
+     @completed_data = listing.completed.alter_query { |rel| rel.limit(@closed_proposal_limit) }
+-    @canceled_data = listing.canceled
++    @canceled_data = listing.canceled.alter_query { |rel| rel.limit(@closed_proposal_limit) }
+   end
+
+   def archive
+-    @proposals_data = listing.closed
++    redirect_to query_proposals_path(text: ""status:completed"")
+   end
+
+   def cancel_form",thoughts on putting `alter_query { |rel| rel.limit(@closed_proposal_limit) }` in a method that we can call here? That way we can have a test for this logic without needing a controller spec.,Why the change here?
+8864,"@@ -31,7 +31,12 @@ module Api
+       response.last_modified = node.timestamp
+
+       if node.visible
+-        render :xml => node.to_xml.to_s
++        @node = node
++
++        # Render the result
++        respond_to do |format|
++          format.xml
++        end
+       else
+         head :gone
+       end",Perhaps `@node` throughout,Use the new Ruby 1.9 hash syntax.
+8865,"@@ -195,8 +195,14 @@ module Beaker
+             @cmd_options[:validate] = bool
+           end
+
+-          opts.on '--collect-perf-data', 'Use sysstat on linux hosts to collect performance and load data' do
+-            @cmd_options[:collect_perf_data] = true
++          opts.on '--collect-perf-data [MODE]',
++                  'Collect SUT performance and load data',
++                  'Possible values:',
++                  'aggressive (poll every minute)',
++                  'normal (poll every 10 minutes)',
++                  'none (do not collect perf data)',
++                  '(default: normal)' do |mode|
++            @cmd_options[:collect_perf_data] = mode || 'normal'
+           end
+
+           opts.on('--version', 'Report currently running version of beaker' ) do",Shouldn't this default be 'normal' ?,We have several options here: - `
+8866,"@@ -131,7 +131,7 @@ class TelemetryEntry(
+     namedtuple(
+         ""TelemetryEntry"",
+         ""action client_time elapsed_time event_id instance_id pipeline_name_hash ""
+-        ""num_pipelines_in_repo repo_hash python_version metadata version dagster_version os_desc os_platform"",
++        ""num_pipelines_in_repo num_schedules_in_repo num_sensors_in_repo repo_hash python_version metadata version dagster_version os_desc os_platform"",
+     )
+ ):
+     """"""",nit: type this,I am not sure why this is called
+8867,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";
++  String STOP_CASTING = ""stopCasting"";
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`,These API endpoints are not suppo
+8868,"@@ -234,7 +234,8 @@ func CheckIfBDBelongsToNode(nodeName string) Validate {
+ func (bd *BlockDevice) CheckIfBDBelongsToNode(nodeName string) error {
+ 	if !bd.IsBelongToNode(nodeName) {
+ 		return errors.Errorf(
+-			""block device doesn't belongs to node %s"",
++			""block device %s doesn't belongs to node %s"",
++			bd.Object.Name,
+ 			bd.Object.Spec.NodeAttributes.NodeName,
+ 		)
+ 	}",lets print nodeName that got passed also,Does `%s` work with `json.Marshal`?
+8869,"@@ -38,6 +38,9 @@ try:
+ except NameError:
+     pass
+
++if sys.version > '3':
++    long = int
++
+
+ class WebElement(object):
+     """"""Represents a DOM element.",Should be `if sys.version_info[0] > 2:`,Don't forget to add `import sys` to
+8870,"@@ -1254,6 +1254,7 @@ int main(int argc, char *argv[])
+
+ 	random_init();
+ 	debug_config(argv[0]);
++	debug_config_file_size(string_metric_parse(""0""));//to set debug file size to ""don't delete anything""
+
+ 	s = getenv(""MAKEFLOW_BATCH_QUEUE_TYPE"");
+ 	if(s) {","Is there any need to pass this through `string_metric_parse`? I believe you can either create an off_t or just pass 0, with no need to added a string conversion into the mix.","string_metric_parse(""0"") is a strin"
+8871,"@@ -888,6 +888,17 @@ class WebDriver(BaseWebDriver):
+         """"""
+         self.execute(Command.MINIMIZE_WINDOW)
+
++    def print_page(self, print_option_arg = None):
++        """"""
++        Takes PDF of the current page.
++        The driver makes a best effort to return a PDF based on the provided parameters.
++        """"""
++        options = {}
++        if print_option_arg:
++            options = print_option_arg.print_options
++
++        return self.execute(Command.PRINT_PAGE, options)['value']
++
+     @property
+     def switch_to(self):
+         """"""",Let's not use a form of hungarian notation in naming our variables,You can just use `self.execute` ins
+8872,"@@ -527,8 +527,13 @@ static void handle_incoming_request(struct st_h2o_http1_conn_t *conn)
+             send_bad_request(conn, ""line folding of header fields is not supported"");
+             return;
+         }
++
++        H2O_PROBE_CONN(RECEIVE_REQUEST_HEADERS, &conn->super, conn->_req_index, &conn->req.input.method, &conn->req.input.authority,
++                       &conn->req.input.path, conn->req.version, conn->req.headers.entries, conn->req.headers.size);
++
+         H2O_PROBE(RECEIVE_REQUEST_HEADERS, &conn->super, conn->_req_index, &conn->req.input.method, &conn->req.input.authority,
+                   &conn->req.input.path, conn->req.version, conn->req.headers.entries, conn->req.headers.size);
++
+         if (entity_body_header_index != -1) {
+             conn->req.timestamps.request_body_begin_at = h2o_gettimeofday(conn->super.ctx->loop);
+             if (expect.base != NULL) {",Seems like we are calling the probe twice?,This seems to be a duplicate of L2O_PROBE_CONN().
+8873,"@@ -13,7 +13,7 @@ import (
+
+ // LocalDevExecCmd allows users to execute arbitrary bash commands within a container.
+ var LocalDevExecCmd = &cobra.Command{
+-	Use:   ""exec [app_name] [environment_name] '[cmd]'"",
++	Use:   ""exec '[cmd]'"",
+ 	Short: ""run a command in an app container."",
+ 	Long:  `Execs into container and runs bash commands.`,
+ 	Run: func(cmd *cobra.Command, args []string) {","I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But ""Run a command in an app container"" doesn't do it for me :)",Shouldn't we keep the examples that include `app_
+8874,"@@ -118,7 +118,7 @@ func CreateOrUpdateService(ctx context.Context, sclient clientv1.ServiceInterfac
+ 		}
+ 	} else {
+ 		svc.ResourceVersion = service.ResourceVersion
+-		svc.Spec.IPFamily = service.Spec.IPFamily
++		svc.Spec.IPFamilies = service.Spec.IPFamilies
+ 		svc.SetOwnerReferences(mergeOwnerReferences(service.GetOwnerReferences(), svc.GetOwnerReferences()))
+ 		_, err := sclient.Update(ctx, svc, metav1.UpdateOptions{})
+ 		if err != nil && !apierrors.IsNotFound(err) {","Have not tested this yet, lets see if tests complain, but I suspect it should be as easy as this  ",would it make sense to use the `pkg/api/v1/core/v
+8875,"@@ -42,6 +42,10 @@ SPARK_INDEX_NAME_FORMAT = ""__index_level_{}__"".format
+ # A pattern to check if the name of a Spark column is a Koalas index name or not.
+ SPARK_INDEX_NAME_PATTERN = re.compile(r""__index_level_[0-9]+__"")
+
++NATURAL_ORDER_COLUMN_NAME = '__natural_order__'
++
++HIDDEN_COLUMNS = set([NATURAL_ORDER_COLUMN_NAME])
++
+ IndexMap = Tuple[str, Optional[Tuple[str, ...]]]
+
+ ",no big deal but we don't we just use a list to keep the order? I don't think it's likely to have a duplicated columns if that was the concern.,How about `__natural_order__` -> `__natural_order
+8876,"@@ -1,5 +1,5 @@
+ /**
+- * core/modules data store
++ * Modules data store
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for all similar cases below.",This file should be renamed `data_store.go` and the associated data_store_test.go
+8877,"@@ -34,6 +34,7 @@ const ContainerdConfigTemplate = `
+
+ {{- if .NodeConfig.AgentConfig.Snapshotter }}
+ [plugins.cri.containerd]
++  disable_snapshot_annotations = true
+   snapshotter = ""{{ .NodeConfig.AgentConfig.Snapshotter }}""
+ {{end}}
+ ",where is this coming from?,Can you explain why this is required?
+8878,"@@ -0,0 +1,11 @@
++class MoveScreencastsIntoProducts < ActiveRecord::Migration
++  def up
++    say_with_time ""Converting screencasts into video_tutorials"" do
++      update ""UPDATE products SET type = 'VideoTutorial' WHERE type = 'Screencast'""
++    end
++  end
++
++  def down
++    raise ActiveRecord::IrreversibleMigration
++  end
++end","We can also drop `plans.includes_screencasts`, right?",Final newline missing.
+8879,"@@ -374,6 +374,11 @@ class ECPrivkey(ECPubkey):
+             sigdecode = get_r_and_s_from_sig_string
+         private_key = _MySigningKey.from_secret_exponent(self.secret_scalar, curve=SECP256k1)
+         sig = private_key.sign_digest_deterministic(data, hashfunc=hashlib.sha256, sigencode=sigencode)
++        counter = 0
++        while ord(sig[0]) > 127: # grind for low R value https://github.com/bitcoin/bitcoin/pull/13666
++            counter += 1
++            extra_entropy = bfh(""%064x"" % counter)[::-1]
++            sig = private_key.sign_digest_deterministic(data, hashfunc=hashlib.sha256, sigencode=sigencode, extra_entropy=extra_entropy)
+         public_key = private_key.get_verifying_key()
+         if not public_key.verify_digest(sig, data, sigdecode=sigdecode):
+             raise Exception('Sanity check verifying our own signature failed.')","wouldn't `int.to_bytes(counter, 32, 'little')` be equivalent, clearer and faster?",Wouldn't it be simpler to do `sig[0]`?
+8880,"@@ -60,6 +60,11 @@ func (a *API) CreatePayments(ctx context.Context, config CreatePaymentsParams) (
+ 	return CreatePayments(ctx, a, config)
+ }
+
++// ValidateStoragePaymentCondition validates that the given condition is a payment condition and has the right values
++func (a *API) ValidateStoragePaymentCondition(ctx context.Context, condition *types.Predicate, minerAddr address.Address, commP types.CommP, pieceSize *types.BytesAmount) error {
++	return ValidateStoragePaymentCondition(ctx, condition, minerAddr, commP, pieceSize)
++}
++
+ // DealGet returns a single deal matching a given cid or an error
+ func (a *API) DealGet(ctx context.Context, proposalCid cid.Cid) (*storagedeal.Deal, error) {
+ 	return DealGet(ctx, a, proposalCid)","I don't see why this is in porcelain since it's just a free function, with no dependency on plumbing or the `a` receiver. I think it should be moved to `protocol/storage`. It's exposed unnecessarily widely here.",Where are the `ValidateStoragePaymentCondition` used?
+8881,"@@ -130,6 +130,11 @@ def create_messages(data, entity: str, stats_range: str, from_ts: int, to_ts: in
+     """"""
+     for entry in data:
+         _dict = entry.asDict(recursive=True)
++
++        # Clip the recordings to top 1000 so that we don't drop messages
++        if entity == ""recordings"":
++            _dict[entity] = _dict[entity][:1000]
++
+         try:
+             model = UserEntityStatMessage(**{
+                 'musicbrainz_id': _dict['user_name'],",Could we only do this for all time? Because that's what is causing problems rn?,why do you want to remove it from here?
+8882,"@@ -369,7 +369,7 @@ class _FlowType(_BaseFlowType):
+
+     def parse(self, manager: ""CommandManager"", t: type, s: str) -> flow.Flow:
+         try:
+-            flows = manager.execute(""view.flows.resolve %s"" % (s))
++            flows = manager.execute(""view.flows.resolve '%s'"" % (s))
+         except exceptions.CommandError as e:
+             raise exceptions.TypeError(str(e)) from e
+         if len(flows) != 1:","This looks better than before, but we'll now likely run into issues with `'` characters in the spec. Maybe we can just use `manager.call_strings` instead?","I think this is actually more correct, it should be `"
+8883,"@@ -131,6 +131,12 @@ public class SparkReadConf {
+         .parse();
+   }
+
++  public Long splitSizeOption() {
++    return confParser.longConf()
++        .option(SparkReadOptions.SPLIT_SIZE)
++        .parseOptional();
++  }
++
+   public long splitSize() {
+     return confParser.longConf()
+         .option(SparkReadOptions.SPLIT_SIZE)","Should this replace `splitSize` instead of adding a parallel call? The `SparkReadConf` is not yet released, so we can change it still.",can you change this to `splitSizeOption`
+8884,"@@ -71,7 +71,18 @@ class LocalFileSystem(FileSystem):
+                 return
+
+         if parents:
+-            os.makedirs(path)
++            # for Python 2 compatibility
++            try:
++                FileNotExistsError
++            except NameError:
++                FileNotExistsError = OSError
++
++            try:
++                os.makedirs(path)
++            except FileNotExistsError as err:
++                # somebody already created the path
++                if err.errno != errno.EEXIST:
++                    raise
+         else:
+             if not os.path.exists(os.path.dirname(path)):
+                 raise MissingParentDirectory()","To reduce complexity, please use OSError on Python3 as well.",`FileNotFound` is better than `FileNotExistsError`
+8885,"@@ -209,3 +209,10 @@ def follow_selected(tab_obj: apitypes.Tab, *, tab: bool = False) -> None:
+         tab_obj.caret.follow_selected(tab=tab)
+     except apitypes.WebTabError as e:
+         raise cmdutils.CommandError(str(e))
++
++
++@cmdutils.register()
++@cmdutils.argument('tab', value=cmdutils.Value.cur_tab)
++def reverse_selection(tab: apitypes.Tab) -> None:
++    """"""Toggle caret selection mode.""""""
++    tab.caret.reverse_selection()",That seems wrong.,Optional: This is a great use case for a method th
+8886,"@@ -55,6 +55,7 @@ public class ConfirmEmailPage implements java.io.Serializable {
+             if (confirmEmailData != null) {
+                 user = confirmEmailData.getAuthenticatedUser();
+                 session.setUser(user);
++                session.configureSessionTimeout(); // TODO: is this needed here? (it can't hurt, but still)
+                 JsfHelper.addSuccessMessage(BundleUtil.getStringFromBundle(""confirmEmail.details.success""));
+                 return ""/dataverse.xhtml?faces-redirect=true"";
+             }","Yes, this is needed here. This is a builtin user who just reset their password.",Yeah... I can't think of anything better right now
+8887,"@@ -396,13 +396,12 @@ class HDF5PackageStore(PackageStore):
+         """"""
+         self._find_path_write()
+         buildfile = name.lstrip('/').replace('/', '.')
+-        storepath = os.path.join(self._pkg_dir, buildfile)
++        storepath = self._object_path('.' + buildfile)
+         with pd.HDFStore(storepath, mode=self._mode) as store:
+             store[self.DF_NAME] = df
+         filehash = digest_file(storepath)
+         self._add_to_contents(buildfile, filehash, ext, path, target)
+-        objpath = os.path.join(self._pkg_dir, self.OBJ_DIR, filehash)
+-        os.rename(storepath, objpath)
++        os.rename(storepath, self._object_path(filehash))
+
+     @classmethod
+     def ls_packages(cls, pkg_dir):","This seems to move the storage of temporary files to the CWD. Is that right? I don't think we should do that. If the process gets interrupted, we should try our best to clean up, but if even that fails, it'd be nice if the mess was left in a different directory. Maybe we should have a directory explicitly for builds?",Should we use `.format(buildfile)` here? Or is thi
+8888,"@@ -67,6 +67,10 @@ type Config struct {
+ 	// If not set, it uses all versions available.
+ 	// Warning: This API should not be considered stable and will change soon.
+ 	Versions []protocol.VersionNumber
++	// Ask the server to truncate the connection ID sent in the Public Header.
++	// This saves 8 bytes in the Public Header in every packet. However, if the IP address of the server changes, the connection cannot be migrated.
++	// Currently only valid for the client.
++	RequestConnectionIDTruncation bool
+ }
+
+ // A Listener for incoming QUIC connections","Please explain why a user would enable this (space savings), and the requirements for this option to be safe.",Why is this only true for the client?
+8889,"@@ -43,12 +43,16 @@ export default function ContainerSelect( {
+ 	value,
+ 	...props
+ } ) {
+-	const accounts = useSelect( ( select ) => select( STORE_NAME ).getAccounts() );
++	const { accounts, hasResolvedAccounts } = useSelect( ( select ) => ( {
++		accounts: select( STORE_NAME ).getAccounts(),
++		hasResolvedAccounts: select( STORE_NAME ).hasFinishedResolution( 'getAccounts' ),
++	} ) );
++
+ 	const accountID = useSelect( ( select ) => select( STORE_NAME ).getAccountID() );
+ 	const hasExistingTag = useSelect( ( select ) => select( STORE_NAME ).hasExistingTag() );
+-	const isLoadingContainers = useSelect( ( select ) => select( STORE_NAME ).isDoingGetContainers( accountID ) );
++	const hasResolvedContainers = useSelect( ( select ) => select( STORE_NAME ).hasFinishedResolution( 'getContainers', [ accountID ] ) );
+
+-	if ( accounts === undefined || containers === undefined || isLoadingContainers ) {
++	if ( accounts === undefined || ! hasResolvedAccounts || containers === undefined || ! hasResolvedContainers ) {
+ 		return <ProgressBar small />;
+ 	}
+ ",I think the `undefined` checks still need to be removed from here.,"In my opinion, this should be `undefi"
+8890,"@@ -158,6 +158,13 @@ class KubernetesJobTask(luigi.Task):
+         """"""
+         return self.kubernetes_config.max_retrials
+
++    @property
++    def backoff_limit(self):
++        """"""
++        Maximum number of retries before considering the job as failed.
++        """"""
++        return 6
++
+     @property
+     def delete_on_success(self):
+         """"""",Is there any particular reason to have 6?  ,Is there a reason why this is hardcod
+8891,"@@ -122,8 +122,11 @@ func (s *Space) biggestFreeRange(r address.Range) (biggest address.Range) {
+ 	biggestSize := address.Count(0)
+ 	s.walkFree(r, func(chunk address.Range) bool {
+ 		if size := chunk.Size(); size >= biggestSize {
+-			biggest = chunk
+-			biggestSize = size
++			chunk = chunk.BiggestPow2AlignedRange()
++			if size = chunk.Size(); size >= biggestSize {
++				biggest = chunk
++				biggestSize = size
++			}
+ 		}
+ 		return false
+ 	})","The biggest chunk does not guarantee that it contains the biggest CIDR-aligned range. If we don't care too much about a few CPU cycles being wasted, then I'd suggest to merge the if-statements.",what happens if `size < biggestSize`
+8892,"@@ -81,6 +81,16 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) dErr {
+ 	}
+ 	substitute(reflect.ValueOf(i.Workflow).Elem(), strings.NewReplacer(replacements...))
+
++	// We do this here, and not in validate, as embedded startup scripts could
++	// have what we think are daisy variables.
++	if err := i.Workflow.validateVarsSubbed(); err != nil {
++		return err
++	}
++
++	if err := i.Workflow.substituteSourceVars(reflect.ValueOf(i.Workflow).Elem()); err != nil {
++		return err
++	}
++
+ 	i.Workflow.populateLogger(ctx)
+
+ 	for name, st := range i.Workflow.Steps {","instead of doing the if err := __; err != nil { return err } thing, you can do errs = addErrs(errs, ___). If you want.",is this something we can put in a `validate` function?
+8893,"@@ -4,8 +4,15 @@
+ package cli
+
+ import (
++	""errors""
++	""fmt""
++
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/ssm""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/color""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/log""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/prompt""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/workspace""
+ 	""github.com/spf13/cobra""
+ )",nit: Is this error message accurate?,let's move these to the `term` package
+8894,"@@ -4269,7 +4269,7 @@ import_one_object_direct (OstreeRepo    *dest_repo,
+         G_IN_SET (src_repo->mode, OSTREE_REPO_MODE_BARE, OSTREE_REPO_MODE_BARE_USER);
+       if (src_is_bare_or_bare_user && !OSTREE_OBJECT_TYPE_IS_META(objtype))
+         {
+-          if (src_repo == OSTREE_REPO_MODE_BARE)
++          if (src_repo->mode == OSTREE_REPO_MODE_BARE)
+             {
+               g_autoptr(GVariant) xattrs = NULL;
+               if (!glnx_fd_get_all_xattrs (src_fd, &xattrs,","Ouch! :man_facepalming: And of course, this worked for me because that evaluated to false when I was testing the bare-user path.",`OSTREE_REPO_MODE_BARE` should be `OSTREE_REPO_MODE_BA
+8895,"@@ -380,7 +380,10 @@ func (c *FCGIClient) Request(p map[string]string, req io.Reader) (resp *http.Res
+ 		if err != nil {
+ 			return
+ 		}
+-		resp.Status = statusParts[1]
++		if (len(statusParts) > 0) {
++			resp.Status = statusParts[1]
++		}
++
+ 	} else {
+ 		resp.StatusCode = http.StatusOK
+ 	}",Parentheses aren't needed here. `if len(statusParts) > 0 {` will suffice.,Can you explain why this change is needed?
+8896,"@@ -44,9 +44,10 @@ const serverName = ""yarpc-test""
+
+ // TT is the gauntlets table test struct
+ type TT struct {
+-	Service  string // thrift service name; defaults to ThriftTest
+-	Function string // name of the Go function on the client
+-	Oneway   bool   // if the function is a oneway function
++	Service       string   // thrift service name; defaults to ThriftTest
++	Function      string   // name of the Go function on the client
++	Oneway        bool     // if the function is a oneway function
++	SkipOnServers []string // if the test needs to be skipped on particular server
+
+ 	Details string        // optional extra details about what this test does
+ 	Give    []interface{} // arguments besides context",// the test is skipped on given servers because it will fail.,Do we need this at all? Can we just have it be `SkipOnServers bool`?
+8897,"@@ -220,8 +220,7 @@ describe 'OrganizationsController' do
+
+     it 'should return unauthorized if api key is invalid' do
+       get :index, format: :xml, api_key: 'dummy_id'
+-
+-      must_respond_with :unauthorized
++      must_respond_with :bad_request
+     end
+   end
+ ","The name of the test should be updated to ""it 'should return bad_request if api key is invalid""",Style/StringLiterals: Prefer single-quoted strings when you don't ne
+8898,"@@ -806,6 +806,12 @@ class _HyperSearchRunner(object):
+
+     # pull out best Model from jobs table
+     jobInfo = _clientJobsDB().jobInfo(hyperSearchJob.getJobID())
++
++    # Try to return a decent error message if the job was cancelled for some
++    # reason.
++    if jobInfo.cancel is 1:
++      raise Exception(jobInfo.workerCompletionMsg)
++
+     try:
+       results = json.loads(jobInfo.results)
+     except Exception, e:",Use `==` in this case instead of `is`.,"can we make this a general Exception like ""Job was cancelled"" or ""Jo"
+8899,"@@ -53,6 +53,7 @@ type CStorPoolAttr struct {
+ 	OverProvisioning bool   `json:""overProvisioning""` //true or false
+ }
+
++// CStorPoolPhase is a CStorPool phase.
+ type CStorPoolPhase string
+
+ // Status written onto CStorPool and CStorVolumeReplica objects.",Please put it like this: `CStorPoolPhase is a typed string for phase field of CStorPool`,This doesn't appear to be used anywhere.
+8900,"@@ -222,13 +222,15 @@ class Order extends BaseAction implements EventSubscriberInterface
+             $pse = $cartItem->getProductSaleElements();
+
+             /* check still in stock */
+-            if ($cartItem->getQuantity() > $pse->getQuantity()) {
++            if ($cartItem->getQuantity() > $pse->getQuantity() && true === ConfigQuery::checkAvailableStock()) {
+                 throw new TheliaProcessException(""Not enough stock"", TheliaProcessException::CART_ITEM_NOT_ENOUGH_STOCK, $cartItem);
+             }
+
+             /* decrease stock */
++            $newStock = $pse->getQuantity() - $cartItem->getQuantity();
++            if($newStock < 0) $newStock = 0; //Forbid negative stock
+             $pse->setQuantity(
+-                    $pse->getQuantity() - $cartItem->getQuantity()
++                    $newStock
+             );
+             $pse->save($con);
+ ",variable must be in camelCase => $newStock,Why not just `$newStock = $pse->getQuantity() - $cartItem->getQuantity();`?
+8901,"@@ -73,7 +73,7 @@ func setActionFlags(cmds ...*cobra.Command) {
+
+ func sendAction(elp action.Envelope) string {
+ 	fmt.Printf(""Enter password #%s:\n"", signer)
+-	bytePassword, err := terminal.ReadPassword(syscall.Stdin)
++	bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))
+ 	if err != nil {
+ 		log.L().Error(""fail to get password"", zap.Error(err))
+ 		return err.Error()",unnecessary conversion (from `unconvert`),`Stdin` is a `bytes.Buffer`
+8902,"@@ -345,6 +345,18 @@ final class BitMappedTrie<T> implements Serializable {
+         return index;
+     }
+
++    Object[] toArray() {
++        final Object[] results = new Object[length];
++        visit((index, leaf, start, end) -> {
++            final int copied = end - start;
++            for (int i = start; i < end; i++) {
++                results[index + i] = type.getAt(leaf, i);
++            }
++            return index + copied;
++        });
++        return results;
++    }
++
+     int length() { return length; }
+ }
+ ","... is probably automatically vectorized, since it has the same speed as `System.arraycopy`",I think you could just return `results.copy(type.getAt(leaf))`
+8903,"@@ -15,9 +15,19 @@
+
+ package engine
+
++import (
++	""github.com/aws/amazon-ecs-agent/agent/resources/cgroup""
++	""github.com/cihub/seelog""
++	""github.com/pkg/errors""
++)
++
++// control is used to manipulate cgroups and ease testing
++var control cgroup.Control
++
+ // SetupPlatformResources sets up platform level resources
+ func (mtask *managedTask) SetupPlatformResources() error {
+ 	if mtask.Task.CgroupEnabled() {
++		setControl(cgroup.New())
+ 		return mtask.setupCgroup()
+ 	}
+ 	return nil","Is there anyway to get rid of the global variable, if it is specific for each task, can you add it to the `mtask` struct?",could we move this into `pkg/resources/cgroup.go`?
+8904,"@@ -77,12 +77,12 @@ func TestDeserializeFromFlatBuffer(t *testing.T) {
+ 		{
+ 			name:     ""simple unary expr"",
+ 			fbFn:     getUnaryOpFlatBuffer,
+-			polyType: `forall [] float`,
++			polyType: `float`,
+ 		},
+ 		{
+ 			name:     ""function expression"",
+ 			fbFn:     getFnExprFlatBuffer,
+-			polyType: `forall [t0, t1] (a: t0, <-b: t1, ?c: int) -> int`,
++			polyType: `(a: A, <-b: B, ?c: int) => int`,
+ 		},
+ 	}
+ ","Surprised to see this old syntax here, but not _that_ surprised.",Why the change here? Was this a bug?
+8905,"@@ -164,9 +164,16 @@ abstract class AbstractQueue<T, Q extends AbstractQueue<T, Q>> implements Traver
+         return Collections.removeAll((Q) this, elements);
+     }
+
+-    @SuppressWarnings(""unchecked"")
++    @Deprecated
+     public Q removeAll(Predicate<? super T> predicate) {
+-        return Collections.removeAll((Q) this, predicate);
++        Objects.requireNonNull(predicate, ""predicate is null"");
++        return reject(predicate);
++    }
++
++    @SuppressWarnings(""unchecked"")
++    @Override
++    public Q reject(Predicate<? super T> predicate) {
++        return Collections.reject((Q) this, predicate);
+     }
+
+     @Override",It is good to mark it! Maybe we can remove the method for Vavr 1.0.0 - but for now it can stay as-is. Thx!,Could you please add a `@Deprecated`
+8906,"@@ -15,11 +15,12 @@
+ package pool
+
+ import (
++	""errors""
+ 	""sync""
+-	""time""
+
+ 	""github.com/golang/glog""
+-	""github.com/openebs/maya/pkg/util""
++	col ""github.com/openebs/maya/cmd/maya-exporter/app/collector""
++	types ""github.com/openebs/maya/pkg/exec""
+ 	zpool ""github.com/openebs/maya/pkg/zpool/v1alpha1""
+ 	""github.com/prometheus/client_golang/prometheus""
+ )","exported func New returns unexported type *pool.pool, which can be annoying to use",nit: remove the newline here
+8907,"@@ -17,7 +17,7 @@ module BoltSpec
+
+     # Nothing on the executor is 'public'
+     class MockExecutor
+-      attr_reader :noop, :error_message, :in_parallel
++      attr_reader :noop, :error_message, :in_parallel, :transports
+       attr_accessor :run_as, :transport_features, :execute_any_plan
+
+       def initialize(modulepath)","Sorry, I feel like I'm missing something - where does this get called?",Why is this necessary? I don't see w
+8908,"@@ -423,12 +423,9 @@ func (e *edged) syncNodeStatus() {
+ 			klog.Errorf(""Register node failed: %v"", err)
+ 			return
+ 		}
+-		if err := e.updateNodeStatus(); err != nil {
+-			klog.Errorf(""Unable to update node status: %v"", err)
+-		}
+-	} else {
+-		if err := e.updateNodeStatus(); err != nil {
+-			klog.Errorf(""Unable to update node status: %v"", err)
+-		}
++	}
++
++	if err := e.updateNodeStatus(); err != nil {
++		klog.Errorf(""Unable to update node status: %v"", err)
+ 	}
+ }","@guihecheng Thanks for the fixing! Actually this is not the dup codes, when we first registerNode, then update the nodestatus immediately, or the node will keep not ready for 10s. And do you have other ways to refactor it?",why did you remove the else here?
+8909,"@@ -14,6 +14,7 @@
+
+ #include ""SystemInfo.hpp""
+
++#include <sys/stat.h>
+ #ifdef _WIN32
+ #include <windows.h>
+ #else","How portable is this? (e.g., Windows). I'm relaunching tests of windows because they failed for other reasons.",Please add a license header here.
+8910,"@@ -7498,10 +7498,13 @@ static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_stat
+     cb_state->hasDrawCmd = true;
+
+     // Add descriptor image/CIS layouts to CB layout map
+-    auto &desc_sets = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets;
+-    for (auto &desc : desc_sets) {
+-        if (desc) {
+-            desc->UpdateDSImageLayoutState(cb_state);
++    PIPELINE_STATE *pPipe = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state;
++
++    for (const auto &set_binding_pair : pPipe->active_slots) {
++        uint32_t setIndex = set_binding_pair.first;
++        auto &desc_set = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets[setIndex];
++        if (desc_set) {
++            desc_set->UpdateDSImageLayoutState(cb_state);
+         }
+     }
+ }","What this does is narrow down what we are saying the descriptor set is requiring. This is a good thing, but doesn't go far enough, we are still potentially setting unused bindings to either a required state or an invalid one. set_binding_pair.second is a map of the binding/requirements from the bound shaders... and instead of marking all bindings, looking at that will mark only the used ones. Will open a new PR",The name `desc_sets` is a bit mis
+8911,"@@ -1038,11 +1038,10 @@ func (core *coreService) BlockMetas(start uint64, count uint64) ([]*iotextypes.B
+
+ 	var (
+ 		tipHeight = core.bc.TipHeight()
+-		res       []*iotextypes.BlockMeta
++		res       = make([]*iotextypes.BlockMeta, 0)
+ 	)
+ 	if start > tipHeight {
+-		log.L().Debug(""err in BlockMetas()"", zap.Error(status.Error(codes.InvalidArgument, ""start height should not exceed tip height"")))
+-		return nil, nil
++		return nil, status.Error(codes.NotFound, ""start height should not exceed tip height"")
+ 	}
+ 	for height := start; height <= tipHeight && count > 0; height++ {
+ 		blockMeta, err := core.getBlockMetaByHeight(height)","should use `codes.InvalidArgument`, same as above line 1033 and 1036",Why remove this log?
+8912,"@@ -51,7 +51,7 @@ func getAgentVersions() []DockerVersion {
+ 	return append(getWindowsReplaceableVersions(), MinDockerAPIWindows)
+ }
+
+-// getDefaultVersion returns agent's default version of the Docker API
++// GetDefaultVersion returns agent's default version of the Docker API
+ func getDefaultVersion() DockerVersion {
+ 	return MinDockerAPIWindows
+ }",Please revert this file.,Why do we need this change?
+8913,"@@ -18,10 +18,13 @@
+ //
+ // URLs
+ //
+-// For pubsub.OpenTopic/Subscription URLs, azurepubsub registers for the scheme
+-// ""azuresb"". The Service Bus Connection String defaults to the environment
+-// variable ""SERVICEBUS_CONNECTION_STRING"". For details on the format of the
+-// URL, see URLOpener.
++// For pubsub.OpenTopic and pubsub.OpenSubscription, azurepubsub registers
++// for the scheme ""azuresb"".
++// The default URL opener will use a Service Bus Connection String based on
++// the environment variable ""SERVICEBUS_CONNECTION_STRING"".
++// To customize the URL opener, or for more details on the URL format,
++// see URLOpener.
++// See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
+ // As
+ //","Probably in another PR, I think the package should be renamed to `servicebus` to be consistent.",Is this a typo? ` opener`?
+8914,"@@ -557,7 +557,7 @@ namespace AutoRest.Core.Properties {
+         }
+
+         /// <summary>
+-        ///   Looks up a localized string similar to A swagger must have security definitions and must adhere to the specific structure..
++        ///   Looks up a localized string similar to Every swagger/configuration must have a security definitions section and it must adhere to the structure described in: https://github.com/Azure/autorest/tree/master/docs/developer/validation-rules/security-definitions-structure-validation.md.
+         /// </summary>
+         public static string SecurityDefinitionsStructureValidation {
+             get {",curious: are we planning to add link to each of the rules in the message?,How is this different from
+8915,"@@ -248,6 +248,11 @@ func (exp *MockExplorer) GetDeposits(subChainID int64, offset int64, limit int64
+ 	return nil, nil
+ }
+
++// SettleDeposit settles deposit on sub-chain
++func (exp *MockExplorer) SettleDeposit(req explorer.SettleDepositRequest) (res explorer.SettleDepositResponse, err error) {
++	return explorer.SettleDepositResponse{}, nil
++}
++
+ func randInt64() int64 {
+ 	rand.Seed(time.Now().UnixNano())
+ 	amount := int64(0)",line is 123 characters,Why do we need this?
+8916,"@@ -69,7 +69,7 @@ class AuthorizationService extends AbstractAuthenticationService
+      * whether a user is authenticated.
+      *
+      * @see \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::checkAuthentication()
+-     * @param array Array of user data
++     * @param array $user of user data
+      * @return int Returns 200 to grant access for the page indexer.
+      */
+     public function authUser($user)",same here; `@param array $user Array of user data`,Should be `array of user data`
+8917,"@@ -21,7 +21,7 @@ func TestString(t *testing.T) {
+ 					b.Append(""a"")
+ 				}
+ 			},
+-			sz: 256,
++			sz: 0,
+ 			want: []interface{}{
+ 				""a"", ""a"", ""a"", ""a"", ""a"",
+ 				""a"", ""a"", ""a"", ""a"", ""a"",","A quick read of this test indicates that we're changing the behavior of this api, and so the test needs updating. Is that right?",unrelated to the bugfix @pgavl
+8918,"@@ -5,13 +5,13 @@
+ using System;
+ using Android.Content;
+ using Android.Runtime;
+-using Android.Support.V7.Widget;
++using AndroidX.RecyclerView.Widget;
+ using Java.Lang;
+ using MvvmCross.Logging;
+
+-namespace MvvmCross.Droid.Support.V7.RecyclerView
++namespace MvvmCross.DroidX.RecyclerView
+ {
+-    [Register(""mvvmcross.droid.support.v7.recyclerview.MvxGuardedLinearLayoutManager"")]
++    [Register(""mvvmcross.DroidX.recyclerview.MvxGuardedLinearLayoutManager"")]
+     public class MvxGuardedLinearLayoutManager : LinearLayoutManager
+     {
+         public MvxGuardedLinearLayoutManager(Context context) : base(context)",Register needs lowercasing,Can you revert these removals
+8919,"@@ -134,6 +134,9 @@ public class Constants {
+   public static final String EXECUTION_SOURCE_SCHEDULED = ""schedule"";
+   public static final String EXECUTION_SOURCE_EVENT = ""event"";
+
++  // Should validate proxy user
++  public static final boolean DEFAULT_VALIDATE_PROXY_USER = false;
++
+   public static class ConfigurationKeys {
+
+     public static final String AZKABAN_CLUSTER_NAME = ""azkaban.cluster.name"";",This should belong to FlowContainer class.,Please make this static final.
+8920,"@@ -412,7 +412,10 @@ class NVDAHighlighter(providerBase.VisionEnhancementProvider):
+ 		window = self.window = self.customWindowClass(self)
+ 		self.timer = winUser.WinTimer(window.handle, 0, self._refreshInterval, None)
+ 		msg = MSG()
+-		while winUser.getMessage(byref(msg), None, 0, 0):
++		# Python 3.8 note, Change this to use an Assignment expression to catch a return value of -1.
++		# See the remarks section of
++		# https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getmessage
++		while winUser.getMessage(byref(msg), None, 0, 0) > 0:
+ 			winUser.user32.TranslateMessage(byref(msg))
+ 			winUser.user32.DispatchMessageW(byref(msg))
+ 		if vision._isDebug():","I think there is a chance that on disable/enable cycling, referring to `self.window` is problematic. In the `__init__` method `self.window` is set to None. If `__init__` gets called before `_run` exits the `while` loop then we wont call `self.window.destroy()`. Can you use non-instance variables after this point? I don't think `self.timer` is used outside this function, if so, then I'd prefer it also be a local variable.",I'm not sure why this change is included in this PR? Doesn't seem related to this PR.
+8921,"@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
+ 	// Set up tests and give ourselves a working directory.
+ 	assert := asrt.New(t)
+
++	noninteractive := ""DRUD_NONINTERACTIVE""
++	// nolint: errcheck
++	defer os.Setenv(noninteractive, os.Getenv(noninteractive))
++	err := os.Unsetenv(noninteractive)
++	assert.NoError(err)
++
+ 	testMatrix := map[string][]string{
+ 		""drupal6phpversion"": {AppTypeDrupal6, PHP56},
+ 		""drupal7phpversion"": {AppTypeDrupal7, PHP71},","I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?",This should probably be `assert.NoError(err)`
+8922,"@@ -56,9 +56,15 @@ public class TableProperties {
+   public static final String PARQUET_COMPRESSION = ""write.parquet.compression-codec"";
+   public static final String PARQUET_COMPRESSION_DEFAULT = ""gzip"";
+
++  public static final String PARQUET_WRITE_MODE = ""write.parquet.write-mode"";
++  public static final String PARQUET_WRITE_MODE_DEFAULT = ""overwrite"";
++
+   public static final String AVRO_COMPRESSION = ""write.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";
+
++  public static final String AVRO_WRITE_MODE = ""write.avro.write-mode"";
++  public static final String AVRO_WRITE_MODE_DEFAULT = ""overwrite"";
++
+   public static final String SPLIT_SIZE = ""read.split.target-size"";
+   public static final long SPLIT_SIZE_DEFAULT = 134217728; // 128 MB
+ ","  nice, having the ""overwrite"" default makes this change backwards compatible, right?",Shouldn't this be `write.parquet.write-mode-default` ?
+8923,"@@ -108,7 +108,7 @@ public class DefaultReactiveOAuth2UserService implements ReactiveOAuth2UserServi
+ 					authenticationMethod);
+ 			// @formatter:off
+ 			Mono<Map<String, Object>> userAttributes = requestHeadersSpec.retrieve()
+-					.onStatus((s) -> s != HttpStatus.OK, (response) ->
++					.onStatus((s) -> !s.is2xxSuccessful(), (response) ->
+ 						parse(response)
+ 							.map((userInfoErrorResponse) -> {
+ 								String description = userInfoErrorResponse.getErrorObject().getDescription();","It doesn't make sense to accept all 2xx status code. For example, `203 Non-Authoritative Information` or `205 Reset Content`, etc.","Hey @pawel-kaczmarczyk , `ResponseStatus.SC_NOT_OK` was the correct status code to ch"
+8924,"@@ -385,16 +385,8 @@ class SplitOp implements CoreAdminHandler.CoreAdminOp {
+
+       // compare to current prefix bucket and see if this new term shares the same prefix
+       if (term != null && term.length >= currPrefix.length && currPrefix.length > 0) {
+-        int i = 0;
+-        for (; i < currPrefix.length; i++) {
+-          if (currPrefix.bytes[i] != term.bytes[term.offset + i]) {
+-            break;
+-          }
+-        }
+-
+-        if (i == currPrefix.length) {
+-          // prefix was the same (common-case fast path)
+-          // int count = termsEnum.docFreq();
++        BytesRef termPrefix = new BytesRef(term.bytes, term.offset, currPrefix.length);
++        if (termPrefix.bytesEquals(currPrefix)) {
+           bucketCount++;  // use 1 since we are dealing with unique ids
+           continue;
+         }",Found a better choice here that doesn't involve object creation: StringHelper.startsWith(),Thanks for cleaning up the code so we can use `BytesRef` directly here as well.
+8925,"@@ -250,8 +250,15 @@ func (s *nodeServer) attest(
+ 	attestedData *common.AttestedData, attestedBefore bool) (
+ 	response *nodeattestor.AttestResponse, err error) {
+
+-	// TODO: Pick the right node attestor [#222]
+-	nodeAttestor := s.catalog.NodeAttestors()[0]
++	// Pick the right node attestor
++	var nodeAttestor nodeattestor.NodeAttestor
++	for _, a := range s.catalog.NodeAttestors() {
++		mp := s.catalog.Find(a)
++		if mp.Config.PluginName == attestedData.Type {
++			nodeAttestor = a
++			break
++		}
++	}
+
+ 	attestRequest := &nodeattestor.AttestRequest{
+ 		AttestedData:   attestedData,",Shouldn't we consider the situation where it doesn't find a plugin?,nit: `nodeAttestor` can be `nil` if there are no nodes at all
+8926,"@@ -24,7 +24,12 @@ namespace oneapi::dal::csv {
+ template <>
+ class detail::v1::read_args_impl<table> : public base {
+ public:
+-    read_args_impl() {}
++    read_args_impl(preview::read_mode mode = preview::read_mode::table) : mode(mode) {
++        if (mode != preview::read_mode::table)
++            throw invalid_argument(dal::detail::error_messages::unsupported_read_mode());
++    }
++
++    preview::read_mode mode;
+ };
+
+ namespace v1 {",Do not understand why this needed for table. All new classes defined in the `preview` namespace.,Why not just switch to `preview::read_mode::table` here?
+8927,"@@ -17,6 +17,8 @@
+ package com.yahoo.athenz.common.server.notification;
+
+ public final class NotificationServiceConstants {
++    public static final String NOTIFICATION_PROP_SERVICE_FACTORY_CLASS = ""athenz.zms.notification_service_factory_class"";
++
+     public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL           = ""MEMBERSHIP_APPROVAL"";
+     public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL_REMINDER  = ""MEMBERSHIP_APPROVAL_REMINDER"";
+     public static final String NOTIFICATION_TYPE_PRINCIPAL_EXPIRY_REMINDER     = ""PRINCIPAL_EXPIRY_REMINDER"";",Kept the same property value even though it is now in Common to avoid breaking existing clients.,missing license header
+8928,"@@ -52,7 +52,7 @@ public class InclusiveMetricsEvaluator {
+     return visitors.get();
+   }
+
+-  InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
++  public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
+     this(schema, unbound, true);
+   }
+ ",TODO: this is temporary until we figure out case sensitivity for metrics evaluators.,Does this need to be public? It doesn't seem to be used in this PR.
+8929,"@@ -503,9 +503,10 @@ func (node *Node) Start(ctx context.Context) error {
+ 		// TODO it is possible the syncer interface should be modified to
+ 		// make use of the additional context not used here (from addr + height).
+ 		// To keep things simple for now this info is not used.
+-		err := node.Syncer.HandleNewBlocks(context.Background(), cids)
++		cidSet := types.NewSortedCidSet(cids...)
++		err := node.Syncer.HandleNewTipset(context.Background(), cidSet)
+ 		if err != nil {
+-			log.Infof(""error handling blocks: %s"", types.NewSortedCidSet(cids...).String())
++			log.Infof(""error handling blocks: %s"", cidSet.String())
+ 		}
+ 	}
+ 	node.HelloSvc = hello.New(node.Host(), node.ChainReader.GenesisCid(), syncCallBack, node.ChainReader.Head, node.Repo.Config().Net, flags.Commit)",can we just kill this TODO?,why is this change needed?
+8930,"@@ -33,7 +33,7 @@ func TestDAGGet(t *testing.T) {
+ 		dag := NewDAG(dserv)
+
+ 		_, err := dag.GetNode(ctx, ""awful"")
+-		assert.EqualError(t, err, ""invalid 'ipfs ref' path"")
++		assert.EqualError(t, err, ""invalid path \""awful\"": selected encoding not supported"")
+ 	})
+
+ 	t.Run(""ILPD node not found results in error"", func(t *testing.T) {",This appears to be a change in error handling due to a dag upgrade.,I think you should do `'awful: selected encoding not supported'` he
+8931,"@@ -246,7 +246,9 @@ module Beaker
+           end
+
+           it 'calls beaker-hostgenerator to get hosts information' do
+-            parser.instance_variable_set( :@options, {} )
++            parser.instance_variable_set( :@options, {
++              :hosts_file => 'notafile.yml'
++            } )
+             allow( Beaker::Options::HostsFileParser ).to receive(
+               :parse_hosts_file
+             ).and_raise( Errno::ENOENT )",These changes look like a hosts file _must_ be provided?,Use the new Ruby 1.9 hash syntax.
+8932,"@@ -92,8 +92,9 @@ int FixPythonInvoke::setmask()
+ void FixPythonInvoke::end_of_step()
+ {
+   PyUtils::GIL lock;
++  char fmt[] = ""O"";
+
+-  PyObject * result = PyObject_CallFunction((PyObject*)pFunc, ""O"", (PyObject*)lmpPtr);
++  PyObject * result = PyObject_CallFunction((PyObject*)pFunc, fmt, (PyObject*)lmpPtr);
+
+   if (!result) {
+     PyUtils::Print_Errors();","@akohlmey Just make it a cast like the others. I dislike it either way, but that's the price we pay for Python 2 support.",This could be a `char *`
+8933,"@@ -68,6 +68,7 @@ program
+   .option('--disable_brave_extension', 'disable loading the Brave extension')
+   .option('--disable_pdfjs_extension', 'disable loading the PDFJS extension')
+   .option('--enable_brave_update', 'enable brave update')
++  .option('--channel <target_chanel>', 'target channel to start', /^(beta|dev|nightly|release)$/i, 'release')
+   .arguments('[build_config]')
+   .action(start)
+ ",I wonder if the default here should be nightly? I won't block on that though just a question for a follow up.,"Same here, change to `--"
+8934,"@@ -181,7 +181,7 @@ namespace TestRunner
+             Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException);
+             Application.ThreadException += ThreadExceptionEventHandler;
+
+-            Console.OutputEncoding = Encoding.UTF8;  // So we can send Japanese to SkylineTester, which monitors our stdout
++            //Console.OutputEncoding = Encoding.UTF8;  // So we can send Japanese to SkylineTester, which monitors our stdout
+
+             // Parse command line args and initialize default values.
+             const string commandLineOptions =",Also not for merge to master.,You can probably remove
+8935,"@@ -201,6 +201,10 @@ class ScheduleDefinition:
+             raise DagsterInvalidDefinitionError(
+                 f""Found invalid cron schedule '{self._cron_schedule}' for schedule '{name}''.""
+             )
++        if len(self._cron_schedule.split("" "")) != 5:
++            raise DagsterInvalidDefinitionError(
++                f""Found non-standard cron schedule '{self._cron_schedule}' for schedule '{name}''.""
++            )
+
+         if job is not None:
+             self._target: Union[DirectTarget, RepoRelativeTarget] = DirectTarget(job)","nit `non-standard` might be a bit subjective - maybe ""Cron schedule {blah} is in an unrecognized format. Dagster cron strings must consist of five characters separated by a single space chacater"".","what is the ""standard"" c"
+8936,"@@ -163,7 +163,6 @@ public class ServerPickerActivityTest {
+             openCustomEditDialog();
+         }
+         setText(com.salesforce.androidsdk.R.id.sf__picker_custom_label, label);
+-        clickView(com.salesforce.androidsdk.R.id.sf__picker_custom_url);
+         setText(com.salesforce.androidsdk.R.id.sf__picker_custom_url, url);
+     }
+ ",ARM emulator gets tripped up on the copy/paste menu when tapping the text. Tapping on the text field isn't necessary for setting text.,Why did you remove this?
+8937,"@@ -68,11 +68,12 @@ public class SpellChecker {
+     }
+
+     char[] wordChars = word.toCharArray();
+-    if (dictionary.isForbiddenWord(wordChars, wordChars.length)) {
+-      return false;
++    Boolean simpleResult = checkSimpleWord(wordChars, wordChars.length, null);
++    if (simpleResult != null) {
++      return simpleResult;
+     }
+
+-    if (checkWord(wordChars, wordChars.length, null)) {
++    if (checkCompounds(wordChars, wordChars.length, null)) {
+       return true;
+     }
+ ",extra word lookup removed,Typo: `checkSimpleWord`
+8938,"@@ -520,6 +520,12 @@ webdriver.WebDriver.prototype.call = function(fn, opt_scope, var_args) {
+  * Schedules a command to wait for a condition to hold, as defined by some
+  * user supplied function. If any errors occur while evaluating the wait, they
+  * will be allowed to propagate.
++ *
++ * <p>In the event a condition returns a Promise, the polling loop will wait
++ * for it to be resolved and use the resolved value for evaluating whether the
++ * condition has been satisfied. The resolution time for a promise is factored
++ * into whether a wait has timed out.
++ *
+  * @param {function():boolean} fn The function to evaluate as a wait condition.
+  * @param {number} timeout How long to wait for the condition to be true.
+  * @param {string=} opt_message An optional message to use if the wait times",Will you link to {!webdriver.promise.Promise} here?,missing empty line
+8939,"@@ -45,6 +45,7 @@ Workshops::Application.routes.draw do
+     resources :licenses, only: [:create]
+   end
+   get '/products/:id/purchases/:lookup' => redirect(""/purchases/%{lookup}"")
++  get '/purchases/:lookup' => 'pages#show', id: 'purchase-show'
+
+   resources :books, only: :show, controller: 'products' do
+     resources :licenses, only: [:create]",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I think the URL should b
+8940,"@@ -96,11 +96,10 @@ public class DataService extends IntentService {
+                 ObjectivesPlugin.bgIsAvailableInNS = true;
+                 ObjectivesPlugin.saveProgress();
+             } else if (isNSProfile && Intents.ACTION_NEW_PROFILE.equals(action)){
+-                // always handle Profili if NSProfile is enabled without looking at nsUploadOnly
++                // always handle Profile if NSProfile is enabled without looking at nsUploadOnly
+                 handleNewDataFromNSClient(intent);
+             } else if (!nsUploadOnly &&
+-                    (Intents.ACTION_NEW_PROFILE.equals(action) ||
+-                            Intents.ACTION_NEW_TREATMENT.equals(action) ||
++                    (Intents.ACTION_NEW_TREATMENT.equals(action) ||
+                             Intents.ACTION_CHANGED_TREATMENT.equals(action) ||
+                             Intents.ACTION_REMOVED_TREATMENT.equals(action) ||
+                             Intents.ACTION_NEW_STATUS.equals(action) ||",@AdrianLxM finally found some your bug too :),Is there any reason to remove the profile check here?
+8941,"@@ -1543,7 +1543,9 @@ void cvdescriptorset::ImageSamplerDescriptor::UpdateDrawState(layer_data *dev_da
+     if (iv_state) {
+         core_validation::AddCommandBufferBindingImageView(dev_data, cb_node, iv_state);
+     }
+-    SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
++    if (image_view_) {
++        SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
++    }
+ }
+
+ cvdescriptorset::ImageDescriptor::ImageDescriptor(const VkDescriptorType type)",This crashed in an app using descriptor_indexing with some unbound descriptors.,Does this need to be a `const` check for `image_view_
+8942,"@@ -39,14 +39,15 @@ MODULES_TO_CHECK = [
+ MODULES_NAMES = [m[1] for m in MODULES_TO_CHECK]
+
+
+-@pytest.mark.primer_stdlib
++@pytest.mark.primer
+ @pytest.mark.parametrize(
+     (""test_module_location"", ""test_module_name""), MODULES_TO_CHECK, ids=MODULES_NAMES
+ )
+-def test_lib_module_no_crash(
++def test_primer_stdlib_no_crash(
+     test_module_location: str, test_module_name: str, capsys: CaptureFixture
+ ) -> None:
+     """"""Test that pylint does not produces any crashes or fatal errors on stdlib modules""""""
++    __tracebackhide__ = True  # pylint: disable=unused-variable
+     os.chdir(test_module_location)
+     with _patch_stdout(io.StringIO()):
+         try:",I think we might want to keep these marks separate? Then we can create a new `workflow` file with 3 jobs: 1) Prime stdlib 2) Prime batch 1 of external 2) Prime batch 2 of external,The reason why this is changing is because it's also
+8943,"@@ -263,6 +263,13 @@ namespace MvvmCross.Droid.Support.V4
+ 			{
+ 				((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.Clear();
+ 				((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.PutAll(bundle);
++
++                var childViewModelCache = Mvx.GetSingleton<IMvxChildViewModelCache>();
++                if (childViewModelCache.Exists(fragInfo.CachedFragment.ViewModel.GetType()))
++                {
++                    fragInfo.CachedFragment.ViewModel = childViewModelCache.Get(fragInfo.CachedFragment.ViewModel.GetType());
++                    childViewModelCache.Remove(fragInfo.CachedFragment.ViewModel.GetType());
++                }
+ 			}
+ 			else
+ 			{",Throw `fragInfo.CachedFragment.ViewModel.GetType()` into a variable so it's not evaluated each time.,This is going to cause a race condition where `childV
+8944,"@@ -189,7 +189,7 @@ class User < ActiveRecord::Base
+   end
+
+   def preferred_languages
+-    @preferred_languages ||= Locale.list(languages)
++    Locale.list(languages)
+   end
+
+   def nearby(radius = NEARBY_RADIUS, num = NEARBY_USERS)",Rather than just getting rid of the memoization maybe we should use an `after_save` filter to set it to `nil` so that it will be recomputed on next read?,"Removed memoization because this is a before filter, so it's always called"
+8945,"@@ -0,0 +1,3 @@
++export default function remove(el) {
++	el.parentNode && el.parentNode.removeChild(el);
++}",JS abstraction leaks so this should be `if (el.parentNode !== null) { el.parentNode.removeChild(el) }` @developit  ,I'm a bit confused by this. Why do you need to check for `el.parentNode`?
+8946,"@@ -30,6 +30,15 @@ type LedgerUSB struct {
+ 	hiddev *hid.Device
+ }
+
++// LedgerUSBError is a wrapper around the two-byte error code that the Ledger
++// protocol returns.
++type LedgerUSBError uint16
++
++// Error satisfies builtin interface `error`
++func (err LedgerUSBError) Error() string {
++	return fmt.Sprintf(""unexpected status %x"", err)
++}
++
+ // Protocol reference:
+ // https://github.com/LedgerHQ/blue-loader-python/blob/master/ledgerblue/comm.py (see HIDDongleHIDAPI)
+ // https://github.com/LedgerHQ/blue-loader-python/blob/master/ledgerblue/ledgerWrapper.py (see wrapCommandAPDU)",nit: change it to `Exchange: unexpected status 0x%x` so that we'll know where this issue came from as well as making it easier to decode.,Would it make sense to move this into `ledger.go`?
+8947,"@@ -23,13 +23,7 @@ func CstorVolumeArtifactsFor070() (list ArtifactList) {
+ 	return
+ }
+
+-// cstorVolumeYamlsFor070 returns all the yamls related to cstor volume in a
+-// string format
+-//
+-// NOTE:
+-//  This is an implementation of MultiYamlFetcher
+-func cstorVolumeYamlsFor070() string {
+-	return `
++const cstorRunTask = `
+ ---
+ apiVersion: openebs.io/v1alpha1
+ kind: CASTemplate",Name of constant is not appropriate. Name of constant should make use of version no. as suffix. The constant can be a typed string versus a string.,@smarterclayton do you want to change this to use the template template?
+8948,"@@ -51,6 +51,7 @@ module Bolt
+           command_options = []
+           # Need to be interactive if redirecting STDIN
+           command_options << '--interactive' unless options[:stdin].nil?
++          command_options << '--tty' if options[:tty]
+           command_options.concat(envs) unless envs.empty?
+           command_options << container_id
+           command_options.concat(command)",@glennsarti you want to validate this on Windows? IIRC this won't work,Do we need this here? I thought `--tty` was enough for this to be able to use `--interactive`?
+8949,"@@ -45,8 +45,11 @@ public class ZipkinElasticsearchHttpStorageAutoConfiguration {
+   ElasticsearchHttpStorage.Builder esHttpBuilder(
+       ZipkinElasticsearchHttpStorageProperties elasticsearch,
+       @Qualifier(""zipkinElasticsearchHttp"") OkHttpClient client,
+-      @Value(""${zipkin.storage.strict-trace-id:true}"") boolean strictTraceId) {
+-    return elasticsearch.toBuilder(client).strictTraceId(strictTraceId);
++      @Value(""${zipkin.storage.strict-trace-id:true}"") boolean strictTraceId,
++      @Value(""${zipkin.query.lookback:86400000}"") int namesLookback) {
++    return elasticsearch.toBuilder(client)
++        .strictTraceId(strictTraceId)
++        .namesLookback(namesLookback);
+   }
+
+   /** cheap check to see if we are likely to include urls */",ps I'm ok to add this as a elasticsearch property instead. ex zipkin.storage.elasticsearch.names-lookback (we have similar things in cassandra),`namesLookback` is only available in the `zipkin.query.lookback` namespace. So I think it shou
+8950,"@@ -69,12 +69,12 @@ class Search implements IWebSearch {
+   }
+
+   /**
+-   * Force a reindex.
++   * Force a re-index.
+    */
+   reindex() {
+     let self = this;
+-    this.storage.getLocalDatabase(function(err, packages) {
+-      if (err) throw err; // that function shouldn't produce any
++    this.storage.getLocalDatabase(function(error, packages) {
++      if (error) throw error; // that function shouldn't produce any
+       let i = packages.length;
+       while (i--) {
+         self.add(packages[i]);",Curly brackets here `{ (breakLine) xx (breakLine)}`,Shouldn't this be `if (error) throw error;`?
+8951,"@@ -450,6 +450,11 @@ window.ConfigurationsView = countlyView.extend({
+                     return false;
+                 }
+
++                if($(this).val() === countlyGlobal[""member""].username){
++                    $("".username-check"").remove();
++                    return false;
++                }
++
+                 $(this).next("".required"").remove();
+
+                 var existSpan = $(""<span class='username-check red-text' data-localize='management-users.username.exists'>"").html(jQuery.i18n.map[""management-users.username.exists""]),","Can you check this case Assuming you have a dashboard with 2 users, test1 and test2 Currently logged in user is test1. You should not be able to change it to test2. You open dev console and paste in `countlyGlobal[""member""].username = ""test2"";` then you enter value test2 in the input and it is allowed and form would be submitted. Would server side validation deal with such case?",`return false` is redundant here ;)
+8952,"@@ -46,13 +46,14 @@ public class DataSourceFactory {
+     static final long MAX_TTL_CONN_MS = TimeUnit.MILLISECONDS.convert(10L, TimeUnit.MINUTES);
+     static final String MYSQL_VALIDATION_QUERY = ""/* ping */ SELECT 1"";
+
++    static final String DRIVER_CLASS_NAME = ""athenz.db.driver.class"";
+     public static PoolableDataSource create(String url, Properties mysqlConnectionProperties) {
+
+         String driver = null;
+         try {
+             if (url.indexOf("":mysql:"") > 0) {
+
+-                driver = ""com.mysql.jdbc.Driver"";
++                driver = System.getProperty(DRIVER_CLASS_NAME, ""com.mysql.jdbc.Driver"");
+                 Class.forName(driver);
+
+                 ConnectionFactory connectionFactory =","since we're changing this class, let's fix the default class name as well. it should be com.mysql.cj.jdbc.Driver","Do not hardcode the name of the driver class, use the name of the class in `PoolableDataSource` constructor instead. Better to have a more descriptive name."
+8953,"@@ -3,4 +3,13 @@ class Role < ActiveRecord::Base
+   has_many :proposals, through: :proposal_roles
+   has_many :user_roles
+   has_many :users, through: :user_roles
++
++  # Safely ensure that the system roles in `config/initializers/01_c2.rb`
++  # exist in the database. Rails will run this code when it loads the
++  # `Role` class at bootup.
++  def self.ensure_system_roles_exist
++    SYSTEM_ROLES.each { |r| Role.find_or_create_by!(name: r) }
++  end
++
++  ensure_system_roles_exist if connection.table_exists? ""roles""
+ end","At load time, we ensure the config'd objects exist.",This method is no longer needed after the changes in `config/initializers/01_c2.rb`
+8954,"@@ -153,6 +153,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+                         {
+                             throw new InvalidOperationException($""HTTPS endpoints can only be configured using {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}()."");
+                         }
++                        else if (!parsedAddress.Scheme.Equals(""http"", StringComparison.OrdinalIgnoreCase))
++                        {
++                            throw new InvalidOperationException($""Unrecognized scheme in server address '{address}'. Only 'http://' is supported."");
++                        }
+
+                         if (!string.IsNullOrEmpty(parsedAddress.PathBase))
+                         {",Is there a test for this case?,Do we have a test for this somewhere?
+8955,"@@ -0,0 +1,14 @@
++<section class=""topic"">
++  <header>
++    <p class=""topic-headline""><%= show.name %></p>
++  </header>
++
++  <%= render partial: ""products/videos/video"", collection: show.latest_videos %>
++
++  <figure class=""card see-more"">
++    <%= link_to show do %>
++      <h4><%= pluralize show.videos.count, ""more #{show.name} episode"" %></h4>
++      <p>View All</p>
++    <% end %>
++  </figure>
++</section>",This copy doesn't match what I had in my mockup. I think it's better to call them episodes.,You should be able to use `show.latest_videos` here (and in the other places too)
+8956,"@@ -135,7 +135,11 @@ func (s *server) startService() common.Daemon {
+ 	servicePortMap := make(map[string]int)
+ 	for roleName, svcCfg := range s.cfg.Services {
+ 		serviceName := getServiceName(roleName)
+-		servicePortMap[serviceName] = svcCfg.RPC.Port
++		if serviceName == common.FrontendServiceName || serviceName == common.MatchingServiceName {
++			servicePortMap[serviceName] = svcCfg.RPC.GRPCPort
++		} else {
++			servicePortMap[serviceName] = svcCfg.RPC.Port
++		}
+ 	}
+
+ 	params.MembershipFactory, err = s.cfg.Ringpop.NewFactory(",For some reason it worked for frontend even before this change.,This seems like a weird logic. Why do we want both a service port and a grpc port?
+8957,"@@ -666,7 +666,10 @@ TEST (block_store, large_iteration)
+ 	{
+ 		auto transaction (store.tx_begin (true));
+ 		nano::account account;
+-		nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
++		{
++			std::lock_guard<std::mutex> lk (nano::random_pool_mutex);
++			nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
++		}
+ 		accounts1.insert (account);
+ 		store.account_put (transaction, account, nano::account_info ());
+ 	}",Can we encapsulate this in a function so if we want to change it against we don't have to change all call sites?,"If you're using std::lock_guard, why not create a new one?"
+8958,"@@ -470,8 +470,8 @@ void nano::bulk_pull_client::received_block (boost::system::error_code const & e
+ 				connection->start_time = std::chrono::steady_clock::now ();
+ 			}
+ 			connection->attempt->total_blocks++;
+-			total_blocks++;
+ 			bool stop_pull (connection->attempt->process_block (block, known_account, total_blocks, block_expected));
++			total_blocks++;
+ 			if (!stop_pull && !connection->hard_stop.load ())
+ 			{
+ 				/* Process block in lazy pull if not stopped","Maybe a good opportunity to do a related improvement: The parameter `total_blocks` in `bootstrap_attempt::process_block` shadows a field with the same name, so maybe rename the parameter to `total_blocks_a` The parameter and field are incremented at the same time, but the field is used by `populate_connections` as well, so I assume they mean different things. Other than that, LGTM","There is one more place where you can fix this issue. In fact, the original code w"
+8959,"@@ -9,6 +9,8 @@
+
+ DEFINE_int32(default_parts_num, 100, ""The default number of parts when a space is created"");
+ DEFINE_int32(default_replica_factor, 1, ""The default replica factor when a space is created"");
++DEFINE_int32(default_space_sum, 100, ""The default number of space can be created"");
++DEFINE_int32(default_max_replica_factor, 1, ""The default max replica factor that a space can take"");
+
+ namespace nebula {
+ namespace meta {",Please revise the naming of these two flags. _**default**_ is the value we take when user doesn't provide. You could infer from the fact how `default_parts_num` are used.,"""The default number of space can be created"""
+8960,"@@ -24,12 +24,13 @@ import java.util.Map;
+ import java.util.Set;
+ import java.util.TreeSet;
+
+-public class ImportTypeTransformer {
++public class ImportTypeTransformer implements ImportGenerator {
+   private enum ImportFileType {
+     SERVICE_FILE,
+     PROTO_FILE
+   }
+
++  @Override
+   public List<ImportTypeView> generateImports(Map<String, TypeAlias> imports) {
+     List<ImportTypeView> generatedImports = new ArrayList<>();
+     for (String key : imports.keySet()) {","I don't think we should have separate ""transformer"" and ""generator"" terms. I would suggest renaming this existing class `ImportTypeTransformer` to `StandardImportTypeTransformer` and renaming the interface `ImportGenerator` to `ImportTypeTransformer`.",I thought we were going to remove java.util.TreeSet?
+8961,"@@ -1,4 +1,4 @@
+ export { default as getContainers } from './get-containers';
+ export { default as isValidAccountID } from './is-valid-account-id';
+ export { default as isValidContainerID } from './is-valid-container-id';
+-export { default as tagMatchers } from './tag-matchers';
++export { default as tagMatchers } from './tagMatchers';","I believe `tag-matchers` is the proper form for this filename. Only components should use pascal case, I believe everything else should continue to use kabob-case.",@wanderingstan   Did we export this as `tagMatchers`
+8962,"@@ -19,6 +19,7 @@ package pubsub
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1""
+
+ 	pubsubsourcev1alpha1 ""github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1""
+ 	pubsubsourceclientset ""github.com/google/knative-gcp/pkg/client/clientset/versioned""","same here, move this one down",Can you move this to the top with the rest of the 3r
+8963,"@@ -112,6 +112,7 @@ class OrderDataFixture extends AbstractReferenceFixture implements DependentFixt
+         $orderData->domainId = Domain::FIRST_DOMAIN_ID;
+         $orderData->currency = $this->getReference(CurrencyDataFixture::CURRENCY_CZK);
+         $orderData->createdAt = $this->faker->dateTimeBetween('-1 week', 'now');
++        $orderData->createdAsAdministrator = $this->getReference(AdministratorDataFixture::ADMINISTRATOR);
+         $this->createOrder(
+             $orderData,
+             [","Some could be created as superadmin instead, to add more special cases. Also, the reason behind this change should be described in the commit msg and the PR description.",Why don't you use `createdAsAdministrator` here?
+8964,"@@ -28,6 +28,7 @@ from pyspark.sql import functions as F
+ from pyspark.sql.types import FloatType, DoubleType, LongType, StructType, TimestampType, \
+     to_arrow_type
+
++from databricks import koalas as ks
+ from databricks.koalas.dask.utils import derived_from
+ from databricks.koalas.frame import DataFrame
+ from databricks.koalas.generic import _Frame, max_display_count",Is this required?,Let's not name this `ks`. It's confusing since this is not related to koalas.
+8965,"@@ -483,9 +483,10 @@ func start(c *cli.Context) error {
+ 			Cluster:       cm,
+ 			StoragePolicy: sp,
+ 			Security: &sdk.SecurityConfig{
+-				Role:           rm,
+-				Tls:            tlsConfig,
+-				Authenticators: authenticators,
++				Role:                         rm,
++				Tls:                          tlsConfig,
++				Authenticators:               authenticators,
++				PublicVolumeCreationDisabled: !c.Bool(""public-volume-create-allowed""),
+ 			},
+ 		})
+ 		if err != nil {","`--public-volume-create-allowed=true` and set the default to `true`, then use `!c.Bool('...')`",This is the default. Why do we need this?
+8966,"@@ -867,7 +867,9 @@ static int handle_goaway_frame(h2o_http2_conn_t *conn, h2o_http2_frame_t *frame,
+     if ((ret = h2o_http2_decode_goaway_payload(&payload, frame, err_desc)) != 0)
+         return ret;
+
+-    /* nothing to do, since we do not open new streams by ourselves */
++    /* stop opening new push streams hereafter */
++    conn->push_stream_ids.max_open = INT32_MAX;
++
+     return 0;
+ }
+ ","Could we use `0x7ffffffe` instead, since `INT32_MAX` is an ID of a _pull_ stream? Other than that the PR seems ready for merge. Thank you for working on the fix.","I don't understand this change. If you stop the push streams hereafter, do yo"
+8967,"@@ -86,11 +86,11 @@ module Beaker
+         execute_rake_task(""beaker_quickstart:gen_hosts[vmpooler]"")
+       end
+
+-      # Print a message to the console and exit with 0
++      # Print a message to the console and exit with 1
+       # @param [String] msg the message to print
+-      def self.exit_with(msg)
++      def self.exit_with(msg, exit_code=1)
+         puts msg
+-        exit(0)
++        exit(exit_code)
+       end
+
+       # Call the quick start task for the specified hypervisor",Might as well add a docstring for the new `exit_code` parameter too.,"Very minor but `exit_with(msg, exit_code=0)` might be clearer than `exit(0)`"
+8968,"@@ -77,8 +77,8 @@ public class LocalNewSessionQueuer extends NewSessionQueuer {
+   }
+
+   @Override
+-  public Optional<HttpRequest> remove() {
+-    return sessionRequests.poll();
++  public Optional<HttpRequest> remove(RequestId id) {
++    return sessionRequests.poll(id);
+   }
+
+   @Override",`poll` and `remove` have different meanings.,What's the difference between `poll` and `remove`?
+8969,"@@ -111,6 +111,15 @@ public class TableProperties {
+   public static final String DELETE_AVRO_COMPRESSION = ""write.delete.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";
+
++  public static final String PARQUET_BLOOM_FILTER_ENABLED = ""write.parquet.bloom-filter-enabled"";
++  public static final boolean PARQUET_BLOOM_FILTER_ENABLED_DEFAULT = false;
++
++  public static final String PARQUET_BLOOM_FILTER_EXPECTED_NDV = ""write.parquet.bloom-filter-expected-ndv"";
++  public static final long PARQUET_BLOOM_FILTER_EXPECTED_NDV_DEFAULT = -1L;
++
++  public static final String PARQUET_BLOOM_FILTER_MAX_BYTES = ""write.parquet.bloom-filter-max-bytes"";
++  public static final int PARQUET_BLOOM_FILTER_MAX_BYTES_DEFAULT = 1024 * 1024;
++
+   public static final String SPLIT_SIZE = ""read.split.target-size"";
+   public static final long SPLIT_SIZE_DEFAULT = 134217728; // 128 MB
+ ",What's the perf impact of writing bloom filer? Does it make sense to enable it by default if the perf impact is minor? Would be nice to include benchmarks?,Should this default to -1L?
+8970,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (IAM) role.]
++//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (AWS IAM) role.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),Shouldn't this be `aws-identity`?
+8971,"@@ -162,13 +162,13 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
+   {""cuMemAlloc"",                                           {""hipMalloc"",                                               """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAlloc_v2"",                                        {""hipMalloc"",                                               """", CONV_MEMORY, API_DRIVER}},
+   // cudaHostAlloc
+-  {""cuMemAllocHost"",                                       {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemAllocHost"",                                       {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAllocHost_v2"",                                    {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // cudaMallocManaged
+   {""cuMemAllocManaged"",                                    {""hipMemAllocManaged"",                                      """", CONV_MEMORY, API_DRIVER}},
+   // no analogue
+   // NOTE: Not equal to cudaMallocPitch due to different signatures
+-  {""cuMemAllocPitch"",                                      {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemAllocPitch"",                                      {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAllocPitch_v2"",                                   {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy due to different signatures",Remove `HIP_UNSUPPORTED` - it is an alias,Is there any reason why the API_DRIVER value is em
+8972,"@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
+   public void unassignExecutor(int executionId) throws ExecutorManagerException {
+     executionExecutorMapping.remove(executionId);
+   }
++
++  @Override
++  public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
++      throws ExecutorManagerException {
++    return null;
++  }
+ }",i think we should return an empty list instead of null here.,why not an empty list?
+8973,"@@ -104,10 +104,14 @@ public class UserPreferences {
+     public static final String PREF_ENABLE_AUTODL_WIFI_FILTER = ""prefEnableAutoDownloadWifiFilter"";
+     private static final String PREF_AUTODL_SELECTED_NETWORKS = ""prefAutodownloadSelectedNetworks"";
+     private static final String PREF_PROXY_TYPE = ""prefProxyType"";
+-    private static final String PREF_PROXY_HOST = ""prefProxyHost"";
+-    private static final String PREF_PROXY_PORT = ""prefProxyPort"";
+-    private static final String PREF_PROXY_USER = ""prefProxyUser"";
+-    private static final String PREF_PROXY_PASSWORD = ""prefProxyPassword"";
++    private static final String PREF_HTTP_PROXY_HOST = ""prefHttpProxyHost"";
++    private static final String PREF_HTTP_PROXY_PORT = ""prefHttpProxyPort"";
++    private static final String PREF_HTTP_PROXY_USER = ""prefHttpProxyUser"";
++    private static final String PREF_HTTP_PROXY_PASSWORD = ""prefHttpProxyPassword"";
++    private static final String PREF_SOCKS_PROXY_HOST = ""prefSocksProxyHost"";
++    private static final String PREF_SOCKS_PROXY_PORT = ""prefSocksProxyPort"";
++    private static final String PREF_SOCKS_PROXY_USER = ""prefSocksProxyUser"";
++    private static final String PREF_SOCKS_PROXY_PASSWORD = ""prefSocksProxyPassword"";
+
+     // Services
+     private static final String PREF_GPODNET_NOTIFICATIONS = ""pref_gpodnet_notifications"";","Is it really necessary to store them in a new setting? I think it should be enough to store the credentials in `ProxyConfig.direct()`. Then AntennaPod does not need to store multiple different proxy settings. Also, it will not change existing users' settings (currently the proxy settings would be lost on upgrade).",Shouldn't this be `pre
+8974,"@@ -2115,10 +2115,15 @@ namespace pwiz.Skyline.Model
+         public static double GetCollisionEnergy(SrmSettings settings, PeptideDocNode nodePep,
+             TransitionGroupDocNode nodeGroup, TransitionDocNode nodeTran, CollisionEnergyRegression regression, int step)
+         {
+-            var ce = nodeTran==null // If we're only given a precursor, use the explicit CE of its children if they all agree
+-                ? (nodeGroup.Children.Any() && nodeGroup.Children.All( node => ((TransitionDocNode)node).ExplicitValues.CollisionEnergy == ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy)
+-                    ? ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy : null)
+-                : nodeTran.ExplicitValues.CollisionEnergy;
++            // Collision Energy explicitly declared at the transition level is taken to be the correct value.
++            // If that is not present, explicitly declared value at the precursor level is used.
++            // If that is not present, the CE is calculated using the provided regression if any.
++            var ce = nodeTran == null ?
++                // If we're only given a precursor, use the explicit CE of its children if they all agree, else use precursor explicit CE
++                (nodeGroup.Children.Select(node => ((TransitionDocNode)node).ExplicitValues.CollisionEnergy).Distinct().Count() == 1 ?
++                    ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy : null) ?? nodeGroup.ExplicitValues.CollisionEnergy :
++                // Otherwise use explicit precursor CE if no explicit transition CE given
++                nodeTran.ExplicitValues.CollisionEnergy ?? nodeGroup.ExplicitValues.CollisionEnergy;
+             if (regression != null)
+             {
+                 if (!ce.HasValue)","This is a mess. Can it be broken out as a separate function using ifs and return statements, which would also make it more debuggable.",Use .Any instead of .C
+8975,"@@ -1457,8 +1457,16 @@ class GenericCompositePlot(DimensionedPlot):
+
+         key_map = dict(zip([d.name for d in self.dimensions], key))
+         for path, item in self.layout.items():
+-            frame = item.map(lambda x: get_plot_frame(x, key_map, cached=cached),
+-                             ['DynamicMap', 'HoloMap'])
++            clone = item.map(lambda x: x)
++
++            # Ensure that DynamicMaps in the cloned frame have
++            # identical callback inputs to allow memoization to work
++            for it1, it2 in zip(item.traverse(lambda x: x), clone.traverse(lambda x: x)):
++                if isinstance(it1, DynamicMap):
++                    with util.disable_constant(it2.callback):
++                        it2.callback.inputs = it1.callback.inputs
++            frame = clone.map(lambda x: get_plot_frame(x, key_map, cached=cached),
++                              [DynamicMap, HoloMap], clone=False)
+             if frame is not None:
+                 layout_frame[path] = frame
+         traverse_setter(self, '_force', False)",This stuff is a bit ugly and should probably become a utility. The main problem is that ``.map`` is being abused a bit.,I'm wondering if `util
+8976,"@@ -1128,6 +1128,9 @@ class ShareableResource(UserResource):
+         filters = super(ShareableResource, self)._extract_filters(queryparams)
+
+         ids = self.context.shared_ids
++        if getattr(self.context, ""forced_empty_list"", False):
++            ids = ['UNKNOWN']
++
+         if ids:
+             filter_by_id = Filter(self.model.id_field, ids, COMPARISON.IN)
+             filters.insert(0, filter_by_id)",Maybe there is a better way here so that we don't even bother triggering a storage query since we want an empty list here.,"Any reason not to just do `self.context.get(""forced_empty_list"", False)`?"
+8977,"@@ -0,0 +1,16 @@
++package aws
++
++import (
++	""context""
++
++	""github.com/aws/aws-sdk-go-v2/service/iam""
++)
++
++func (c *client) SimulateCustomPolicy(ctx context.Context, region string, customPolicySimulatorParams *iam.SimulateCustomPolicyInput) (*iam.SimulateCustomPolicyOutput, error) {
++	rc, err := c.getRegionalClient(region)
++	if err != nil {
++		return nil, err
++	}
++
++	return rc.iam.SimulateCustomPolicy(ctx, customPolicySimulatorParams)
++}","just curious, `region` is not used in the AWS IAM client, afaik. But I see this is a general field for clutch clients, is it just ignored internally?","I know this isn't new code, but it might be worth moving this method to t"
+8978,"@@ -7,7 +7,7 @@
+  * ""License""); you may not use this file except in compliance
+  * with the License. You may obtain a copy of the License at
+  *
+- *   http://www.apache.org/licenses/LICENSE-2.0
++ * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing,
+  * software distributed under the License is distributed on an",Why are we doing that change?,Didn't actually change this :)
+8979,"@@ -220,7 +220,7 @@ public class ErrorHandler {
+
+   private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
+
+-    if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
++    if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
+       // Not enough information for us to try to rebuild an error.
+       return null;
+     }",Why && changed to || ?,The containsKey() check can be replaced with just rawErrorData.containsKe
+8980,"@@ -196,6 +196,15 @@ def _unpickle(filepath, serializer):
+         raise ValueError(f'Unrecognized serializer type: {serializer}')
+
+
++def collection_to_single_partition(collection):
++    """"""Merge the parts of a Dask collection into a single partition.""""""
++    if collection is None:
++        return
++    if isinstance(collection, da.Array):
++        return collection.rechunk(*collection.shape)
++    return collection.repartition(npartitions=1)
++
++
+ @pytest.mark.parametrize('output', data_output)
+ @pytest.mark.parametrize('centers', data_centers)
+ def test_classifier(output, centers, client, listen_port):","can you please change this to `_collection_to_single_partition()`, like we've done for alll other helper methods defined in this module?",Why do we need to return a single partition here?
+8981,"@@ -24,6 +24,7 @@ namespace Thelia\Core;
+ use Propel\Runtime\Connection\ConnectionManagerSingle;
+ use Propel\Runtime\Connection\ConnectionWrapper;
+ use Propel\Runtime\Propel;
++use Propel\Runtime\ServiceContainer\StandardServiceContainer;
+ use Symfony\Component\Config\FileLocator;
+ use Symfony\Component\Config\Loader\LoaderInterface;
+ use Symfony\Component\Debug\Debug;","This class is never used, don't import it.",Can you rename this to `ServiceContainerInterface
+8982,"@@ -41,6 +41,10 @@ namespace Datadog.Trace.DiagnosticListeners
+
+         void IObserver<KeyValuePair<string, object>>.OnNext(KeyValuePair<string, object> value)
+         {
++#if DEBUG
++            // In debug mode we allow exceptions to be catch in the test suite
++            OnNext(value.Key, value.Value);
++#else
+             try
+             {
+                 OnNext(value.Key, value.Value);","Missing a `return`. Either way, I think it's better to add a `#if DEBUG throw;` in the catch block instead (so we keep the log in debug mode)",Nit: should this be in a try catch instead?
+8983,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.,Unused method argument - username. If it's necess
+8984,"@@ -104,6 +104,9 @@ namespace NLog.Config
+         /// </summary>
+         public IList<LoggingRule> LoggingRules { get; private set; }
+
++        internal List<LoggingRule> GetLoggingRulesThreadSafe() {  lock (LoggingRules) return LoggingRules.ToList(); }
++        private void AddLoggingRulesThreadSafe(LoggingRule rule) { lock (LoggingRules) LoggingRules.Add(rule); }
++
+         /// <summary>
+         /// Gets or sets the default culture info to use as <see cref=""LogEventInfo.FormatProvider""/>.
+         /// </summary>",I think we could replace this (well the backing field) with `BlockingCollection` when we drop NET35?,why the lock?
+8985,"@@ -928,6 +928,15 @@ class GroupBy(object):
+                 pser_or_pdf = pdf.groupby(input_groupnames)[name].apply(func)
+             else:
+                 pser_or_pdf = pdf.groupby(input_groupnames).apply(func)
++                keys = set(input_groupnames)
++                should_drop_columns = (
++                    isinstance(pser_or_pdf, pd.DataFrame)
++                    and keys.issubset(set(pser_or_pdf.index.names))
++                    and keys.issubset(set(pser_or_pdf.columns))
++                )
++                if should_drop_columns:
++                    pser_or_pdf = pser_or_pdf.drop(input_groupnames, axis=1)
++
+             kser_or_kdf = ks.from_pandas(pser_or_pdf)
+             if len(pdf) <= limit:
+                 return kser_or_kdf","Can you show before/after output in the PR description? From a cursory look, seems like it will just drop the duplicated column which isn't consistent with pandas' results.",It would be g
+8986,"@@ -33,6 +33,14 @@ module Bolt
+         @rest = data.reject { |k, _| %w[name nodes config groups].include? k }
+       end
+
++      def check_deprecated_config(context, name, config)
++        if config && config['transports']
++          msg = ""#{context} #{name} contains invalid config option 'transports', see "" \
++                ""https://puppet.com/docs/bolt/0.x/inventory_file.html for the updated format""
++          raise ValidationError.new(msg, @name)
++        end
++      end
++
+       def validate(used_names = Set.new, node_names = Set.new, depth = 0)
+         raise ValidationError.new(""Group does not have a name"", nil) unless @name
+         if used_names.include?(@name)",Added validation that `config: transports` isn't used @adreyer @katelopresti Curious what you think about having Bolt link directly to the docs site.,We should add
+8987,"@@ -99,6 +99,7 @@ class AbstractSettings:
+     _FONT_SIZES = {}  # type: typing.Dict[str, typing.Any]
+     _FONT_FAMILIES = {}  # type: typing.Dict[str, typing.Any]
+     _FONT_TO_QFONT = {}  # type: typing.Dict[typing.Any, QFont.StyleHint]
++    _UnknownUrlSchemePolicy = {}  # type: typing.Dict[str, typing.Any]
+
+     def __init__(self, settings: typing.Any) -> None:
+         self._settings = settings",This probably isn't needed anymore now?,Shouldn't thi
+8988,"@@ -3,9 +3,9 @@ import { h } from './h';
+
+ /**
+  * Clones the given VNode, optionally adding attributes/props and replacing its children.
+- * @param {VNode} vnode		The virtual DOM element to clone
+- * @param {Object} props	Attributes/props to add when cloning
+- * @param {VNode} rest		Any additional arguments will be used as replacement children.
++ * @param {import('./vnode').VNode} vnode The virtual DOM element to clone
++ * @param {object} props Attributes/props to add when cloning
++ * @param {Array<import('./vnode').VNode>} [rest] Any additional arguments will be used as replacement children.
+  */
+ export function cloneElement(vnode, props) {
+ 	return h(",Would it be easier to kick this import to the top of the file? It'll get stripped out anyway.,`import('./vnode')` can be removed since it is already imported.
+8989,"@@ -236,7 +236,8 @@ public class MultiTenancyPrivacyController implements PrivacyController {
+     }
+   }
+
+-  private void verifyPrivacyGroupContainsEnclavePublicKey(
++  @Override
++  public void verifyPrivacyGroupContainsEnclavePublicKey(
+       final String privacyGroupId, final String enclavePublicKey) {
+     final PrivacyGroup privacyGroup = enclave.retrievePrivacyGroup(privacyGroupId);
+     if (!privacyGroup.getMembers().contains(enclavePublicKey)) {",are you sure that the privacyGroup cannot be null?,This should be `@Override`
+8990,"@@ -120,7 +120,7 @@ def GenerateDepictionMatching2DStructure(mol, reference, confId=-1, referencePat
+     if not referenceMatch:
+       raise ValueError(""Reference does not map to itself"")
+   else:
+-    referenceMatch = range(reference.GetNumAtoms(onlyExplicit=True))
++    referenceMatch = list(range(reference.GetNumAtoms(onlyExplicit=True)))
+   if referencePattern:
+     match = mol.GetSubstructMatch(referencePattern)
+   else:",Wrapped with list,List comprehension would be better here
+8991,"@@ -0,0 +1,10 @@
++package stats
++
++// DivideFloat64 returns the value of value divided by base.
++// divide by zero case handled before calling.
++func DivideFloat64(value float64, base float64) (float64, bool) {
++	if base == 0 {
++		return 0, false
++	}
++	return (value / base), true
++}",Please move this to `pkg/stats/v1alpha1`,There is no need for this to be a function? It is only used once
+8992,"@@ -1,12 +1,13 @@
+ class GithubUser
++  URL_FORMAT = /\A[^\/]+\Z/
+   include ActiveModel::Model
+
+   attr_accessor :url, :bypass_url_validation
+   attr_reader :repositories, :module_name, :password
+   alias_method :username, :url
+
+-  validates :url, format: { with: /\A[^\/]+\Z/, message: I18n.t('invalid_github_username') }
+-  validate :username_must_exist
++  validates :url, format: { with: URL_FORMAT, message: I18n.t('invalid_github_username') }
++  validate :username_must_exist, if: -> { url.match(URL_FORMAT) }
+
+   def attributes
+     { url: username, type: self.class.name }",a small nit pick ...this can go into `lib/patterns.rb` ?,Layout/SpaceInLambdaLiteral: Do not use spaces between -> and opening brace in lambda literals
+8993,"@@ -27,7 +27,7 @@ import * as fixtures from '../datastore/__fixtures__';
+ import fetchMock from 'fetch-mock';
+
+ // TODO: update the active class.
+-const activeClass = 'googlesitekit-cta-link--danger';
++const activeClass = 'mdc-tab--active';
+ const url = fixtures.pagespeedMobile.loadingExperience.id;
+ const setupRegistry = ( { dispatch } ) => {
+ 	dispatch( STORE_NAME ).receiveGetReport( fixtures.pagespeedMobile, { url, strategy: STRATEGY_MOBILE } );",The above TODO is no longer necessary I believe  ,Could you update this to `mdc-tab--active` so that we can use `mdc-tab-active` in the template
+8994,"@@ -345,7 +345,7 @@ func getPoolLivenessProbe() *corev1.Probe {
+ 	probe := &corev1.Probe{
+ 		Handler: corev1.Handler{
+ 			Exec: &corev1.ExecAction{
+-				Command: []string{""/bin/sh"", ""-c"", ""zfs set io.openebs:livenesstimestamp=\""$(date)\"" cstor-$OPENEBS_IO_POOL_NAME""},
++				Command: []string{""/bin/sh"", ""-c"", ""zfs set io.openebs:livenesstimestamp=\""$(date +%s)\"" cstor-$OPENEBS_IO_POOL_NAME""},
+ 			},
+ 		},
+ 		FailureThreshold:    3,",Why is this change required ?,prefer `fmt.Sprintf` to be consistent with the rest of the `fmt` package
+8995,"@@ -0,0 +1,16 @@
++package summary
++
++import (
++	""bytes""
++
++	""github.com/russross/blackfriday""
++)
++
++func Markdown(input []byte, wordcount int) []byte {
++	words := bytes.Fields(blackfriday.Markdown(input, Renderer{}, 0))
++	if wordcount > len(words) {
++		wordcount = len(words)
++	}
++
++	return bytes.Join(words[0:wordcount], []byte{' '})
++}",This really is an excerpt. ;-),Can we make it so that we don't have to calculate the number of words on each call?
+8996,"@@ -164,7 +164,7 @@ func (m *mock) IsWithinDepth(addr swarm.Address) bool {
+ 	if m.isWithinFunc != nil {
+ 		return m.isWithinFunc(addr)
+ 	}
+-	return false
++	return true
+ }
+
+ func (m *mock) EachNeighbor(f topology.EachPeerFunc) error {","@acud The reason why the default is now `true` is because the chunk must be in the neighborhood of the storer peer with this change. The majority of the tests expect a valid receipt so the closest peers in the tests must be in the neighborhood. As of writing this, there is only one test that expects a peer to be out of depth.",why change this?
+8997,"@@ -44,6 +44,7 @@ import (
+ 	""go.temporal.io/server/common/log/tag""
+ 	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/mysql""      // needed to load mysql plugin
+ 	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql"" // needed to load postgresql plugin
++	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/sqlite""     // needed to load sqlite plugin
+ 	""go.temporal.io/server/temporal""
+ )
+ ","This is what breaks the build. Apparently w/o this line, `sqlite` package is not even compiled. With this line it gets compiled but compilation fails because we don't use CGO for our production Linux builds and > ***Important: because this is a `CGO` enabled package you are required to set the environment variable `CGO_ENABLED=1` and have a `gcc` compile present within your path.***",I guess this is
+8998,"@@ -58,7 +58,7 @@ test_get_size()
+     }
+
+     // Check sizes of FP/SIMD regs.
+-    for (uint i = 0; i < NUM_SIMD_SLOTS; i++) {
++    for (int i = 0; i < proc_num_simd_saved(); i++) {
+         ASSERT(reg_get_size((reg_id_t)DR_REG_H0 + i) == OPSZ_2);
+         ASSERT(reg_get_size((reg_id_t)DR_REG_S0 + i) == OPSZ_4);
+         ASSERT(reg_get_size((reg_id_t)DR_REG_D0 + i) == OPSZ_8);",This should be all slots,Don't use the un
+8999,"@@ -66,7 +66,7 @@ public final class RegistryUtils {
+     serviceRegistry.run();
+   }
+
+-  public static void destory() {
++  public static void destroy() {
+     serviceRegistry.destroy();
+   }
+ ",Need to add deprecated annotation and call the new fixed method to avoid the API broken issue.,Is this method s
+9000,"@@ -36,8 +36,7 @@ public class GleanMetricsService {
+         } else {
+             GleanMetricsService.stop();
+         }
+-        Configuration config = new Configuration(Configuration.DEFAULT_TELEMETRY_ENDPOINT,
+-                                                 BuildConfig.BUILD_TYPE);
++        Configuration config = new Configuration();
+         Glean.INSTANCE.initialize(aContext, config);
+     }
+ ","This was just fixed in mozilla-mobile/android-components#4892. @pocmo is cutting a new Android Components 19 dot release today, so you'll be able to jump to the new version and restore the build type.",Why did you remove this build type parameter here?
+9001,"@@ -131,6 +131,7 @@ func (r *genericInjectReconciler) Reconcile(req ctrl.Request) (ctrl.Result, erro
+ 	if err := r.Client.Get(ctx, req.NamespacedName, target.AsObject()); err != nil {
+ 		if dropNotFound(err) == nil {
+ 			// don't requeue on deletions, which yield a non-found object
++			log.V(logf.TraceLevel).Info(""not found"", ""err"", err)
+ 			return ctrl.Result{}, nil
+ 		}
+ 		log.Error(err, ""unable to fetch target object to inject into"")","Leaving this log line because it helped me to diagnose that the reconciler client was using a different cache than the event sources, so not always seeing the injectable that triggered the reconcile.",would be nice to make this `debug` level.
+9002,"@@ -4867,7 +4867,10 @@ func (mset *stream) processCatchupMsg(msg []byte) (uint64, error) {
+ 		return 0, errors.New(""bad catchup msg"")
+ 	}
+
++	mset.mu.RLock()
+ 	st := mset.cfg.Storage
++	mset.mu.RUnlock()
++
+ 	if mset.js.limitsExceeded(st) || mset.jsa.limitsExceeded(st) {
+ 		return 0, NewJSInsufficientResourcesError()
+ 	}",Do we need also to protect access to `mset.js` and `mset.jsa` or even `mset.store` down below? (not sure if those are immutable or not).,"Unrelated to this PR, but it seems like we could a"
+9003,"@@ -579,6 +579,7 @@ func (k *KeybaseServiceBase) ResolveImplicitTeamByID(
+ func (k *KeybaseServiceBase) checkForRevokedVerifyingKey(
+ 	ctx context.Context, currUserInfo UserInfo, kid keybase1.KID) (
+ 	newUserInfo UserInfo, exists bool, err error) {
++	newUserInfo = currUserInfo
+ 	for key, info := range currUserInfo.RevokedVerifyingKeys {
+ 		if !key.KID().Equal(kid) {
+ 			continue",I'd rather you do this under `if info.filledInMerkle {` since that's the only place it's relevant.,This is unnecessary.
+9004,"@@ -344,13 +344,8 @@ public class RecoveryStrategy implements Runnable, Closeable {
+                                                                                             // though
+       try {
+         CloudDescriptor cloudDesc = this.coreDescriptor.getCloudDescriptor();
+-        ZkNodeProps leaderprops = zkStateReader.getLeaderRetry(
+-            cloudDesc.getCollectionName(), cloudDesc.getShardId());
+-        final String leaderBaseUrl = leaderprops.getStr(ZkStateReader.BASE_URL_PROP);
+-        final String leaderCoreName = leaderprops.getStr(ZkStateReader.CORE_NAME_PROP);
+-
+-        String leaderUrl = ZkCoreNodeProps.getCoreUrl(leaderBaseUrl, leaderCoreName);
+-
++        ZkNodeProps leaderprops = zkStateReader.getLeaderRetry(cloudDesc.getCollectionName(), cloudDesc.getShardId());
++        String leaderUrl = ZkCoreNodeProps.getCoreUrl(leaderprops);
+         String ourUrl = ZkCoreNodeProps.getCoreUrl(baseUrl, coreName);
+
+         boolean isLeader = leaderUrl.equals(ourUrl); // TODO: We can probably delete most of this code if we say this",*NULL_DEREFERENCE:* object `leaderUrl` last assigned on line 348 could be null and is dereferenced at line 351.,Can you elaborate why we need to change the base URL and core name?
+9005,"@@ -38,9 +38,13 @@ class PlansController < ApplicationController
+   def create
+     @plan = Plan.new
+     authorize @plan
+-
++
+     @plan.principal_investigator = current_user.surname.blank? ? nil : ""#{current_user.firstname} #{current_user.surname}""
+-    @plan.data_contact = current_user.email
++    @plan.principal_investigator_email = current_user.email
++
++    orcid = current_user.identifier_for(IdentifierScheme.find_by(name: 'orcid'))
++    @plan.principal_investigator_identifier = orcid.identifier unless orcid.nil?
++
+     @plan.funder_name = plan_params[:funder_name]
+
+     @plan.visibility = (plan_params['visibility'].blank? ? Rails.application.config.default_plan_visibility :","Since the IdentifierScheme's don't change without us making additional code changes, perhaps this should be added as a constant as we previously did with Perms?",Metrics/LineLength: Line is too long. [81/80]
+9006,"@@ -14,6 +14,7 @@
+ # limitations under the License.
+ #
+
++import os
+ import functools
+ import shutil
+ import sys",nit: We can revert this now.,Can you add a newline after this?
+9007,"@@ -5,9 +5,19 @@ import android.view.ContextMenu;
+ import android.view.MenuInflater;
+ import android.view.View;
+ import android.view.ViewGroup;
++
+ import androidx.annotation.NonNull;
+ import androidx.annotation.Nullable;
+ import androidx.recyclerview.widget.RecyclerView;
++
++import org.apache.commons.lang3.ArrayUtils;
++
++import java.lang.ref.WeakReference;
++import java.util.ArrayList;
++import java.util.HashSet;
++import java.util.List;
++import java.util.Set;
++
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.activity.MainActivity;
+ import de.danoeh.antennapod.core.feed.FeedItem;","Oh, that's the reason why you have two different data structures here. Does the order of the `selectedItems` list matter? If not, I think it would be more clear if both would be a Set.",I don't think there should be a new line here
+9008,"@@ -2034,6 +2034,7 @@ void LuaScriptInterface::registerFunctions()
+ 	registerClass(""Container"", ""Item"", LuaScriptInterface::luaContainerCreate);
+ 	registerMetaMethod(""Container"", ""__eq"", LuaScriptInterface::luaUserdataCompare);
+
++	registerMethod(""Container"", ""getContentDescription"", LuaScriptInterface::luaContainerGetContentDescription);
+ 	registerMethod(""Container"", ""getSize"", LuaScriptInterface::luaContainerGetSize);
+ 	registerMethod(""Container"", ""getCapacity"", LuaScriptInterface::luaContainerGetCapacity);
+ 	registerMethod(""Container"", ""getEmptySlots"", LuaScriptInterface::luaContainerGetEmptySlots);","Should be named getDescription, since the other description functions are named that.","`getContentDescription` is not a method in `Container` class, right? Could you please add it as a separate method?"
+9009,"@@ -62,7 +62,9 @@ public class PlatformActivity extends VRActivity implements RenderInterface, CVC
+         if (ControllerClient.isControllerServiceExisted(this)) {
+             mControllerManager = new CVControllerManager(this);
+             mControllerManager.setListener(this);
+-            mType = 1;
++            mType = 1; // Neo2
++            // Enable high res
++            PicovrSDK.SetEyeBufferSize(1920, 1920);
+         } else {
+             mHbManager = new HbManager(this);
+             mHbManager.InitServices();",Don't we want to do this for g2 4k also?,Is this temporary buffer size being used by the PicovrSDK?
+9010,"@@ -4,6 +4,8 @@ const time = require('./time').default;
+ const Logger = require('./Logger').default;
+ const { _ } = require('./locale');
+ const urlUtils = require('./urlUtils.js');
++const str2ab = require('string-to-arraybuffer');
++const Buffer = require('buffer').Buffer;
+
+ class OneDriveApi {
+ 	// `isPublic` is to tell OneDrive whether the application is a ""public"" one (Mobile and desktop","I would prefer if we don't add this package as it's unsupported, and I expect not necessary. Node buffer supports many formats - is it not possible to use one of its helper functions to load the content?",You can use `const str2ab = require('string-to-arraybuffer');` without the require.
+9011,"@@ -205,6 +205,12 @@ type Table struct {
+ 	// to what we calculate from chainToContents.
+ 	chainToDataplaneHashes map[string][]string
+
++	// chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
++	chainsToFullRules map[string][]string
++
++	// hashToFullRules contains a mapping of rule hashes to the full rules.
++	hashToFullRules map[string]string
++
+ 	// hashCommentPrefix holds the prefix that we prepend to our rule-tracking hashes.
+ 	hashCommentPrefix string
+ 	// hashCommentRegexp matches the rule-tracking comment, capturing the rule hash.","I don't think this is used any more, please remove.","Perhaps this should be called `chainToFullRules`, since it maps to full rules."
+9012,"@@ -219,7 +219,11 @@ def List(inner_type):
+             super(_List, self).__init__(
+                 key='List.{inner_type}'.format(inner_type=inner_type.key),
+                 name=None,
+-                description='List of {inner_type}'.format(inner_type=inner_type.name),
++                description=(
++                    'List of {inner_type}'.format(inner_type=inner_type.name)
++                    if inner_type.name is not None
++                    else 'List of config values'
++                ),
+                 type_attributes=ConfigTypeAttributes(is_builtin=True),
+                 inner_type=inner_type,
+             )","actually use type_name=print_config_type_to_string(self, with_lines=False) to populate this",There is no need to use `if inner_type.name is not None` here. The result will be the default value ('').
+9013,"@@ -71,6 +71,13 @@ class Import extends QueueWorkerBase implements ContainerFactoryPluginInterface
+       foreach ($results as $result) {
+         $queued = $this->processResult($result, $data, $queued);
+       }
++
++      // Delete local resource file.
++      if ($this->container->get('config.factory')->get('datastore.settings')->get('delete_local_resource')) {
++        $uuid = ""{$identifier}_{$version}"";
++        $this->container->get('file_system')->deleteRecursive(""public://resources/{$uuid}"");
++      }
++
+     }
+     catch (\Exception $e) {
+       $this->log(RfcLogLevel::ERROR,","We should be using dependency injection here, instead of fetching the config factory at the last minute from the container. That would allow us to more easily overwrite the ""delete_local_resource"" setting in tests.",Wouldn't it be better to use `configFactory` rather than `configFactory`?
+9014,"@@ -21,8 +21,12 @@ import com.codahale.metrics.health.HealthCheckRegistry;
+ import com.codahale.metrics.json.HealthCheckModule;
+ import com.fasterxml.jackson.databind.ObjectMapper;
+ import com.fasterxml.jackson.databind.ObjectWriter;
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
+
+ public class HealthCheckServlet extends HttpServlet {
++    private static final Logger LOG = LoggerFactory.getLogger(HealthCheckServlet.class);
++
+     public static abstract class ContextListener implements ServletContextListener {
+         /**
+          * @return the {@link HealthCheckRegistry} to inject into the servlet context.","everywhere else in the project, `LOGGER` is used",This is not used.
+9015,"@@ -10,7 +10,7 @@ OSM = {
+   MAX_REQUEST_AREA:        <%= Settings.max_request_area.to_json %>,
+   SERVER_PROTOCOL:         <%= Settings.server_protocol.to_json %>,
+   SERVER_URL:              <%= Settings.server_url.to_json %>,
+-  API_VERSION:             <%= Settings.api_version.to_json %>,
++  API_VERSION:             <%= Settings.api_versions.min_by(&:to_f).to_json %>,
+   STATUS:                  <%= Settings.status.to_json %>,
+   MAX_NOTE_REQUEST_AREA:   <%= Settings.max_note_request_area.to_json %>,
+   OVERPASS_URL:            <%= Settings.overpass_url.to_json %>,","Why is this value set to ""min_by"", and what are the implications of it? Does `&:to_f` play nice with semver (e.g. 1.2.0)?",Does the `.to_json` not include `Settings.api_versions.min_by(&:to_f)`?
+9016,"@@ -0,0 +1,9 @@
++/**
++ * Setup configuration for Jest
++ * This file includes gloabl settings for the JEST environment.
++ */
++import 'raf/polyfill';
++import { configure } from 'enzyme';
++import Adapter from 'enzyme-adapter-react-16';
++
++configure({ adapter: new Adapter() });",typo --> gloabl,This file doesn't need to be here.
+9017,"@@ -356,6 +356,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 	c := context.WithValue(r.Context(), OriginalURLCtxKey, urlCopy)
+ 	r = r.WithContext(c)
+
++	// Setup a replacer for the request that keeps track of placeholder
++	// values across plugins.
++	replacer := NewReplacer(r, nil, """")
++	c = context.WithValue(r.Context(), ReplacerCtxKey, replacer)
++	r = r.WithContext(c)
++
+ 	w.Header().Set(""Server"", caddy.AppName)
+
+ 	status, _ := s.serveHTTP(w, r)","Wanted to double-check: does the `log` middleware still set its own ""empty"" value (should default to `-` at least for the default log format)?",Is there a reason to create a new
+9018,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()),I don't think this is correct. It'
+9019,"@@ -14,12 +14,13 @@ module Bolt
+
+       def print_head; end
+
+-      def initialize(color, verbose, trace, stream = $stdout)
++      def initialize(color, verbose, trace, spin, stream = $stdout)
+         super
+         # Plans and without_default_logging() calls can both be nested, so we
+         # track each of them with a ""stack"" consisting of an integer.
+         @plan_depth = 0
+         @disable_depth = 0
++        @pinwheel = %w[- \\ | /]
+       end
+
+       def colorize(color, string)","Is this going to be configurable? If not, it should just be removed for now.",I don't see where `$spin` is being
+9020,"@@ -23,6 +23,13 @@ See :ref:`Parameter` for more info on how to define parameters.
+ import abc
+ import datetime
+ import warnings
++import json
++from json import JSONEncoder
++from collections import OrderedDict
++import collections
++import operator
++import functools
++
+ try:
+     from ConfigParser import NoOptionError, NoSectionError
+ except ImportError:","Maybe just one import line - `from collections import OrderedDict, Mapping` ?",The first line of this file has a trailing whitespace. It should be removed.
+9021,"@@ -37,8 +37,8 @@ public class NonRuleWithAllPropertyTypes extends AbstractRule {
+     public static final StringMultiProperty MULTI_STR = new StringMultiProperty(""multiStr"", ""Multiple string values"",
+                                                                                 new String[] {""hello"", ""world""}, 5.0f, '|');
+     public static final PropertyDescriptor<Integer> SINGLE_INT = PropertyFactory.intProperty(""singleInt"").desc(""Single integer value"").require(inRange(1, 10)).defaultValue(8).build();
+-    public static final IntegerMultiProperty MULTI_INT = new IntegerMultiProperty(""multiInt"", ""Multiple integer values"",
+-                                                                                  0, 10, new Integer[] {1, 2, 3, 4}, 5.0f);
++    public static final PropertyDescriptor<List<Integer>> MULTI_INT = PropertyFactory.intListProperty(""multiInt"").desc(""Multiple integer values"").requireEach(inRange(0, 10)).defaultValues(1, 2, 3, 4).build();
++
+     public static final LongProperty SINGLE_LONG = new LongProperty(""singleLong"", ""Single long value"", 1L, 10L, 8L,
+                                                                     3.0f);
+     public static final LongMultiProperty MULTI_LONG = new LongMultiProperty(""multiLong"", ""Multiple long values"", 0L,","Btw this class probably doesn't belong in PMD. It says it's there to test UIs, but arguably UIs can use their own test fixtures, and this in in src/test so probably not even shipped anywhere.",Is this change because of the refactoring above?
+9022,"@@ -50,6 +50,8 @@ describe( 'AMPContainerSelect', () => {
+ 		registry.dispatch( STORE_NAME ).setAccountID( accountID );
+ 		registry.dispatch( STORE_NAME ).receiveGetAccounts( [ account ] );
+ 		registry.dispatch( STORE_NAME ).receiveGetContainers( [ ...webContainers, ...ampContainers ], { accountID } );
++		registry.dispatch( STORE_NAME ).finishResolution( 'getAccounts', [] );
++		registry.dispatch( STORE_NAME ).finishResolution( 'getContainers', [ accountID ] );
+
+ 		const { getAllByRole } = render( <AMPContainerSelect />, { registry } );
+ ",Maybe we can group each `finishResolution` call with the corresponding `receiveGet...` call? That would make the connection more clear when reading the code.,@jridgewell would it make sense to finish the resolution in a separate compo
+9023,"@@ -109,9 +109,9 @@ class ServerConnectionMixin(object):
+                         self.disconnect()
+     """"""
+
+-    def __init__(self, server_address=None):
++    def __init__(self, server_address=None, source_address=None):
+         super(ServerConnectionMixin, self).__init__()
+-        self.server_conn = ServerConnection(server_address)
++        self.server_conn = ServerConnection(server_address, source_address)
+         self.__check_self_connect()
+
+     def __check_self_connect(self):",Can we take this out of the constructor here and just use the config value? (This would also make the other proxy mode cases obsolete),Can you add a docstring for `source_address`?
+9024,"@@ -1350,9 +1350,14 @@ class RustGenerator : public BaseGenerator {
+         code_ +=
+             ""    if self.{{FIELD_TYPE_FIELD_NAME}}_type() == ""
+             ""{{U_ELEMENT_ENUM_TYPE}} {"";
+-        code_ +=
+-            ""      self.{{FIELD_NAME}}().map(|u| ""
+-            ""{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        if (!field.required) {
++          code_ +=
++              ""      self.{{FIELD_NAME}}().map(|u| ""
++              ""{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        } else {
++          code_ += ""      let u = self.{{FIELD_NAME}}();"";
++          code_ += ""      Some({{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        }
+         code_ += ""    } else {"";
+         code_ += ""      None"";
+         code_ += ""    }"";",Please flip the conditional to be `if (field.required) { ... }`.,Does this need a space after it?
+9025,"@@ -11,7 +11,10 @@ describe 'User creation when logging in with Oauth to view a protected page' do
+       get '/auth/myusa/callback'
+     }.to change { User.count }.by(1)
+
+-    expect(User.last.email_address).to eq('george-test@example.com')
++    new_user = User.last
++    expect(new_user.email_address).to eq('george-test@example.com')
++    expect(new_user.first_name).to eq(""Georgie"")
++    expect(new_user.last_name).to eq(""Jetsonian"")
+   end
+
+   it 'does not create a user if the current user already exists' do",should we create a fixture without first name and last name and have a spec like this one that uses it to make sure nothing errors out when they are not present?,Prefer single-quoted strings whe
+9026,"@@ -35,4 +35,9 @@ interface PythonSnippetSet<Element> {
+    * Generates the result module with a set of accumulated imports.
+    */
+   Doc generateModule(Element element, Doc body, Iterable<String> imports);
++
++  /**
++   * Generate the example snippet for the code documentation.
++   */
++  Doc generateMethodSampleCode(PythonDocConfig config);
+ }",It seems odd to require all Python snippets to have this method when it's not relevant for messages.snip or the discovery snippets. (I see that we're already doing something similar with generateModule/generateBody where some of the implementations are empty. This also seems strange to me.),nit: let's rename this to genera
+9027,"@@ -122,6 +122,7 @@ public class PrivateTransactionSimulator {
+             publicWorldState.updater(),
+             disposablePrivateState.updater(),
+             header,
++            Hash.ZERO, // PMT hash is not needed as this private transaction doesn't exist
+             transaction,
+             protocolSpec.getMiningBeneficiaryCalculator().calculateBeneficiary(header),
+             new DebugOperationTracer(TraceOptions.DEFAULT),","What about this: ""// Corresponding PMT does not exist.""",why does the wallet hash need to
+9028,"@@ -626,6 +626,8 @@ class OptionsManagerMixIn(object):
+             config_file = self.config_file
+         if config_file is not None:
+             config_file = os.path.expanduser(config_file)
++            if not os.path.exists(config_file):
++                raise IOError(""The config file {:s} doesn't exist!"".format(config_file))
+
+         use_config_file = config_file and os.path.exists(config_file)
+         if use_config_file:",You don't need af ormat specified here.,`os.path.exists(config_file)` is equivalent to `if not os.path.exists(config_file):`
+9029,"@@ -12,6 +12,8 @@ import (
+ 	""time""
+
+ 	""github.com/nats-io/go-nats""
++	""strings""
++	""sync""
+ )
+
+ func TestRouteConfig(t *testing.T) {",Nitpick: import ordering,Can you add gitea copyright header to this file?
+9030,"@@ -38,7 +38,7 @@ namespace Nethermind.Blockchain
+
+         public ReadOnlyChain(ReadOnlyBlockTree readOnlyTree,
+             IBlockValidator blockValidator,
+-            IRewardCalculator rewardCalculator,
++            Func<ITransactionProcessor, IRewardCalculator> rewardCalculatorFactory,
+             ISpecProvider specProvider,
+             IReadOnlyDbProvider dbProvider,
+             IBlockDataRecoveryStep recoveryStep,","code smell here, a function that create a reward calculator from transaction processor?",nitpick: Can we call this `rewardCalculatorFactory` instead of `rewardCalculatorFact
+9031,"@@ -48,7 +48,7 @@ var authScopes = []string{
+ 	""https://www.googleapis.com/auth/cloud-platform"",
+ }
+
+-// Client is a runtimevarManager client.
++// A Client constructs runtime variables using the Runtime Configurator API.
+ type Client struct {
+ 	conn *grpc.ClientConn
+ 	// The gRPC API client.",I don't think the `A` is idomatic is it?,"nit: ""A Client constructs runtime variables using the Runtime Configurator API."""
+9032,"@@ -67,4 +67,12 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files reachable from given metadata location.
++   */
++  default RemoveReachableFiles removeReachableFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement "" +
++        RemoveReachableFiles.class.toString());
++  }
+ }",nit: the others use the method name in the api and not the class name of the api,I think we should call this something other than `RemoveReachableFiles`. `RemoveReachableFiles` is not really an action.
+9033,"@@ -1939,6 +1939,9 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
+   //  - Some passes may create new functions, but only the functions defined in
+   //    the lldb repl line should be serialized.
+   if (swift_ast_ctx->UseSerialization()) {
++    // Run all the passes before differentiation before we serialize.
++    runSILMandatoryOptPreDiffPasses(*sil_module);
++    // Serialize the module now.
+     auto expr_module_dir = swift_ast_ctx->GetReplExprModulesDir();
+     assert(expr_module_dir != nullptr);
+     llvm::SmallString<256> filename(expr_module_dir);",Does it work to run all the sil diagnostic passes before we serialize? That would be more consistent with what the normal compiler does in `FrontendTool.cpp : performCompileStepsPostSILGen()`,Why do we need to run all the passes before we serialize? There's nothing in the module that would change the pass after
+9034,"@@ -4,6 +4,7 @@ Given '""$teacher_name"" is teaching the section from ""$section_start"" to ""$sectio
+   section = Section.find_by_starts_on_and_ends_on!(start_date, end_date)
+   teacher = Teacher.find_by_name!(teacher_name)
+   create(:section_teacher, section: section, teacher: teacher)
++  p section.teachers
+ end
+
+ Given 'I create the following section for ""$course_name"":' do |course_name, section_data|",You left in a puts.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+9035,"@@ -59,6 +59,11 @@ public abstract class CachingCollector extends FilterCollector {
+     @Override
+     public final float score() { return score; }
+
++    @Override
++    public float smoothingScore(int docId) throws IOException {
++      return 0;
++    }
++
+     @Override
+     public int docID() {
+       return doc;","Hmm, should we also cache the `smoothingScore` for this hit? Or, if we will keep it at returning `0`, couldn't we remove this impl and inherit the default from `Scorable`?",can we throw an exception on this method instead?
+9036,"@@ -51,7 +51,7 @@ module.exports = function (grunt, options) {
+     baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site', 'update-bower-json', 'gh-pages:bower', 'npm-publish'];
+   }
+   else {
+-    baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site'];
++    baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release'];
+   }
+
+   return baseTasks;",I removed that from here because I am hoping that will stop the random unwanted updates to the website with unstable versions.,Why was this removed?
+9037,"@@ -11,7 +11,9 @@ import (
+ // State is the status of a process.
+ type State rune
+
+-const ( // Only values for Linux 3.14 and later are listed here
++// Process state values.
++// Only values for Linux 3.14 and later are listed here.
++const (
+ 	Dead        State = 'X'
+ 	DiskSleep   State = 'D'
+ 	Running     State = 'R'",Nit: missing period.,Nit: I would use the
+9038,"@@ -1,10 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how deny uploads of unencrypted objects to an Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.ruby.s3_add_bucket_ssekms_encryption_policy]
++
+ require 'aws-sdk-s3'
+
+-# Denies uploads of unencrypted objects to an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - The Amazon S3 bucket to deny uploading unencrypted objects.",how **to** deny Simple Storage **Service**,Missing space around
+9039,"@@ -5,7 +5,7 @@ setResolver(resolver);
+
+ /* jshint ignore:start */
+ mocha.setup({
+-    timeout: 15000,
++    timeout: 25000,
+     slow: 500
+ });
+ /* jshint ignore:end */",Were you having trouble with timeouts in general acceptance tests or only the editor test? It's possible to set timeouts on a per-test basis by using `this.timeout(25000)` within the `it()` function. I'd like to drop the global timeout in the future if possible rather than increase it - in some circumstances a failing test can have a knock-on effect which makes all later tests timeout so Travis can get hung up for a long time if no one notices and cancels the build.,Can we reduce the tim
+9040,"@@ -246,6 +246,11 @@ def _setSystemConfig(fromPath):
+ 		if curSourceDir==fromPath:
+ 			curDestDir=toPath
+ 		else:
++			if os.path.relpath(curSourceDir,fromPath) == ""addons"":
++				import addonHandler
++				subDirs[:] = [addon.name for addon in addonHandler.getRunningAddons()]
++			else:
++				subDirs[:] = subDirs
+ 			curDestDir=os.path.join(toPath,os.path.relpath(curSourceDir,fromPath))
+ 		if not os.path.isdir(curDestDir):
+ 			os.makedirs(curDestDir)",I don't think this is necessary.,don't you need to `import addonHandler` at the top of the file?
+9041,"@@ -1025,15 +1025,13 @@ func (vd *volAPI) snapEnumerate(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	snaps := make([]*api.Volume, len(resp.GetVolumeSnapshotIds()))
+-	for i, s := range resp.GetVolumeSnapshotIds() {
++	snaps := make([]*api.Volume, 0)
++	for _, s := range resp.GetVolumeSnapshotIds() {
+ 		vol, err := volumes.Inspect(ctx, &api.SdkVolumeInspectRequest{VolumeId: s})
+ 		if err != nil {
+-			e := fmt.Errorf(""Failed to inspect volumeID: %s"", err.Error())
+-			vd.sendError(vd.name, method, w, e.Error(), http.StatusBadRequest)
+-			return
++			continue
+ 		}
+-		snaps[i] = vol.GetVolume()
++		snaps = append(snaps, vol.GetVolume())
+ 	}
+ 	json.NewEncoder(w).Encode(snaps)
+ }","Instead of blindly ignoring all errors, this should just ignore the volume not found error.",Is there any chance that the returned error will be non-nil her
+9042,"@@ -135,11 +135,9 @@ public class ParquetReader<T> extends CloseableGroup implements CloseableIterabl
+         throw new RuntimeIOException(e);
+       }
+
+-      long rowPosition = rowGroupsStartRowPos[nextRowGroup];
++      model.setPageSource(pages, rowGroupsStartRowPos == null ? 0 : rowGroupsStartRowPos[nextRowGroup]);
+       nextRowGroupStart += pages.getRowCount();
+       nextRowGroup += 1;
+-
+-      model.setPageSource(pages, rowPosition);
+     }
+
+     @Override",The `rowPosition` will be ignored if the position column is not projected.,this should probably be `+= 1` rather than `+1` right?
+9043,"@@ -215,6 +215,16 @@ spec:
+               protocol: TCP
+             - containerPort: 3232
+               protocol: TCP
++            livenessProbe:
++              exec:
++                command:
++                - /bin/sh
++                - -c
++                - zfs set io.openebs:livenesstimestap='$(date)' cstor-$OPENEBS_IO_CSTOR_ID
++              failureThreshold: 3
++              initialDelaySeconds: 300
++              periodSeconds: 10
++              timeoutSeconds: 30
+             securityContext:
+               privileged: true
+             volumeMounts:","Is there a possibility of a clash between periodSeconds and timeoutSeconds? For instance, the current probe is not yet timed-out and the next one has started.",How about we add this to `README.md` and `README.md#L3`?
+9044,"@@ -38,12 +38,11 @@ public class BesuCommandCustomFactory implements CommandLine.IFactory {
+       return (T) new VersionProvider(pluginVersionsProvider);
+     }
+
+-    final Constructor<T> constructor = cls.getDeclaredConstructor();
+     try {
++      final Constructor<T> constructor = cls.getDeclaredConstructor();
+       return constructor.newInstance();
+     } catch (Exception e) {
+-      constructor.setAccessible(true);
+-      return constructor.newInstance();
++      return CommandLine.defaultFactory().create(cls);
+     }
+   }
+ }",This logic is already been performed in `CommandLine.defaultFactory().create(cls)` ... whats the point of repeating it here?,Any reason to not use `CommandFactory.create(cls)` directly?
+9045,"@@ -410,7 +410,7 @@ class ManualColumnMove extends BasePlugin {
+    * @private
+    */
+   updateColumnsMapper() {
+-    let countCols = this.hot.countSourceCols();
++    let countCols = Math.max(this.hot.countCols(), this.hot.countSourceCols());
+     let columnsMapperLen = this.columnsMapper._arrayMap.length;
+
+     if (columnsMapperLen === 0) {",Please change from `let` to `const` here and above. Setting value to `this.hot.countSourceCols()` should be enought probably.,why not just use `this.hot.countCols()` ?
+9046,"@@ -796,7 +796,10 @@ int flb_upstream_conn_timeouts(struct mk_list *list)
+                  * waiting for I/O will receive the notification and trigger
+                  * the error to it caller.
+                  */
+-                shutdown(u_conn->fd, SHUT_RDWR);
++                if (u_conn->fd != -1) {
++                    shutdown(u_conn->fd, SHUT_RDWR);
++                }
++
+                 u_conn->net_error = ETIMEDOUT;
+                 prepare_destroy_conn(u_conn);
+             }","Somewhat nitpick: I see the `!=` pattern mentioned in the fluent-bit style guide, but imo, it would be safer to check that a fd is non-negative with ` > -1` or `>= 0`","I see what you're trying to do here, but I don't understand "
+9047,"@@ -0,0 +1,17 @@
++class CreatePgSearchDocuments < ActiveRecord::Migration
++  def self.up
++    say_with_time(""Creating table for pg_search multisearch"") do
++      create_table :pg_search_documents do |t|
++        t.text :content
++        t.belongs_to :searchable, :polymorphic => true, :index => true
++        t.timestamps null: false
++      end
++    end
++  end
++
++  def self.down
++    say_with_time(""Dropping table for pg_search multisearch"") do
++      drop_table :pg_search_documents
++    end
++  end
++end",Use the new Ruby 1.9 hash syntax.,Use the new Ruby 1.9 hash syntax.
+9048,"@@ -25,6 +25,8 @@ import (
+ 	""github.com/gogits/gogs/modules/bindata""
+ 	""github.com/gogits/gogs/modules/log""
+ 	""github.com/gogits/gogs/modules/user""
++
++	""strk.kbt.io/projects/go/libravatar""
+ )
+
+ type Scheme string",Please host to a GitHub repo.,nit: move to bottom :trollface:
+9049,"@@ -197,6 +197,12 @@ func (s *server) doneSplit(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
+-	tag.DoneSplit(tagr.Address)
++	_, err = tag.DoneSplit(tagr.Address)
++	if err != nil {
++		s.Logger.Debugf(""done split: %v"", err)
++		s.Logger.Error(""done split: %v"", err)
++		jsonhttp.InternalServerError(w, nil)
++		return
++	}
+ 	jsonhttp.OK(w, ""ok"")
+ }","The Error log message should not expose internals. The message should be something like this `""done split failed for address %v"", tagr.Address`. Also, the Debugf would be more informative with the address in the message.","So s.Logger.Error(""done split: "
+9050,"@@ -13,11 +13,15 @@
+
+ package args
+
+-import ""flag""
++import (
++	""flag""
++)
+
+ const (
+ 	versionUsage             = ""Print the agent version information and exit""
+-	logLevelUsage            = ""Loglevel: [<crit>|<error>|<warn>|<info>|<debug>]""
++	logLevelUsage            = ""Loglevel overrides loglevel-driver and loglevel-on-instance and sets the same level for both on-instance and driver logging: [<crit>|<error>|<warn>|<info>|<debug>]""
++	driverLogLevelUsage      = ""Loglevel for docker logging driver: [<crit>|<error>|<warn>|<info>|<debug>]""
++	instanceLogLevelUsage    = ""Loglevel for Agent on-instance log file: [<none>|<crit>|<error>|<warn>|<info>|<debug>]""
+ 	ecsAttributesUsage       = ""Print the Agent's ECS Attributes based on its environment""
+ 	acceptInsecureCertUsage  = ""Disable SSL certificate verification. We do not recommend setting this option""
+ 	licenseUsage             = ""Print the LICENSE and NOTICE files and exit""","can we rename `fileLogLevelUsage` to be more generic like `instanceLogLevelUsage`? Same goes for other var below like fileLogLevelFlagName, FileLogLevel.",Shouldn't this be `instanceLogL
+9051,"@@ -169,11 +169,8 @@ define([""loading"", ""layoutManager"", ""userSettings"", ""events"", ""libraryBrowser"",
+                     valueChangeEvent: ""click""
+                 });
+
+-                if (layoutManager.desktop || layoutManager.mobile) {
+-                    alphaPickerElement.classList.add(""alphabetPicker-right"");
+-                    itemsContainer.classList.remove(""padded-left-withalphapicker"");
+-                    itemsContainer.classList.add(""padded-right-withalphapicker"");
+-                }
++                alphaPickerElement.classList.add(""alphaPicker-fixed-right"");
++                itemsContainer.classList.add(""padded-right-withalphapicker"");
+             }
+
+             var btnFilter = tabContent.querySelector("".btnFilter"");",Does this one not need the `tabContent` object used in the other files?,Is `alphaPicker-fixed-right` no
+9052,"@@ -102,6 +102,16 @@ type ClassicELB struct {
+ 	Tags map[string]string `json:""tags,omitempty""`
+ }
+
++// IsUnmanaged returns true if the Classic ELB is unmanaged.
++func (b *ClassicELB) IsUnmanaged(clusterName string) bool {
++	return b.Name != """" && !Tags(b.Tags).HasOwned(clusterName)
++}
++
++// IsManaged returns true if Classic ELB is managed.
++func (b *ClassicELB) IsManaged(clusterName string) bool {
++	return !b.IsUnmanaged(clusterName)
++}
++
+ // ClassicELBAttributes defines extra attributes associated with a classic load balancer.
+ type ClassicELBAttributes struct {
+ 	// IdleTimeout is time that the connection is allowed to be idle (no data",Our use of the terms `managed` and `unmanaged` in CAPA is interesting. I think we should probably update the docs (as part of a separate PR) to explain that we are referring to whether its CAPA managed infra. As opposed to meaning AWS managed service.,Could you add a doc string about what `is unmanaged` means?
+9053,"@@ -246,7 +246,7 @@ def record_listens(request, data):
+
+     lookup = defaultdict(dict)
+     for key, value in data.items():
+-        if key == ""sk"" or key == ""token"" or key == ""api_key"" or key == ""method"":
++        if key == ""sk"" or key == ""token"" or key == ""api_key"" or key == ""method"" or key == ""api_sig"":
+             continue
+         matches = re.match('(.*)\[(\d+)\]', key)
+         if matches:",Looks like all of these can be put into a list.,why is it not possible to have a key that is not in the API
+9054,"@@ -38,6 +38,8 @@ func CanonicalizeHeaderKey(k string) string {
+ type Headers struct {
+ 	// This representation allows us to make zero-value valid
+ 	items map[string]string
++	// map from canonicalized key to original key
++	keyMapping map[string]string
+ }
+
+ // NewHeaders builds a new Headers object.","nit: ""*mapping"" for a map is unnecessary. Consider calling this `originalNames` or similar.",I think we should make this a `map[string]interface{}` to m
+9055,"@@ -171,11 +171,11 @@ class ProfilesDialog(wx.Dialog):
+ 		index = self.profileList.Selection
+ 		if gui.messageBox(
+ 			# Translators: The confirmation prompt displayed when the user requests to delete a configuration profile.
+-			_(""Are you sure you want to delete this profile? This cannot be undone.""),
++			_(""This profile will be permanently deleted, this action cannot be undone.""),
+ 			# Translators: The title of the confirmation dialog for deletion of a configuration profile.
+ 			_(""Confirm Deletion""),
+-			wx.YES | wx.NO | wx.ICON_QUESTION, self
+-		) == wx.NO:
++			wx.OK | wx.CANCEL | wx.ICON_QUESTION, self
++		) != wx.OK:
+ 			return
+ 		name = self.profileNames[index]
+ 		try:","Please split this into two sentences; i.e. ""This profile will be permanently deleted. This action cannot be undone.""","nitpick: ""This profile will be permanently deleted"""
+9056,"@@ -173,9 +173,10 @@ public class OpenAPSAMAPlugin extends PluginBase implements APSInterface {
+
+         startPart = new Date();
+         if (MainApp.getConstraintChecker().isAutosensModeEnabled().value()) {
+-            lastAutosensResult = IobCobCalculatorPlugin.getPlugin().detectSensitivityWithLock(IobCobCalculatorPlugin.getPlugin().oldestDataAvailable(), System.currentTimeMillis());
++            lastAutosensResult = IobCobCalculatorPlugin.getPlugin().getLastAutosensDataSynchronized(""OpenAPSPlugin"").autosensResult;
+         } else {
+             lastAutosensResult = new AutosensResult();
++            lastAutosensResult.sensResult = ""autosens disabled"";
+         }
+         Profiler.log(log, ""detectSensitivityandCarbAbsorption()"", startPart);
+         Profiler.log(log, ""AMA data gathering"", start);",NPE here and in other APS plugins,"Wouldn't it be better to set `lastAutosensResult.sensResult = ""autosens disabled""` in the else block?"
+9057,"@@ -142,6 +142,9 @@ func getMsgKey(obj interface{}) (string, error) {
+ 		resourceType, _ := edgemessagelayer.GetResourceType(*msg)
+ 		resourceNamespace, _ := edgemessagelayer.GetNamespace(*msg)
+ 		resourceName, _ := edgemessagelayer.GetResourceName(*msg)
++		if msg.Router.Source == modules.DynamicControllerModuleName {
++			return strings.Join([]string{resourceType, resourceNamespace, resourceName, msg.Router.Source}, ""/""), nil
++		}
+ 		return strings.Join([]string{resourceType, resourceNamespace, resourceName}, ""/""), nil
+ 	}
+ ","Thanks for the fixing, and could you please provide more details for this bug? Because we have the deduplication mechanism in cloudhub, so it will has no problem.",This seems like a good candidate for a unit test.
+9058,"@@ -52,6 +52,10 @@ public class ViewSettings extends MainWindowView {
+     private static final String CAPTION_TITLE_CSS_CLASS = ""captionTitle"";
+     private static final String CONFIGURATION_PANE_CSS_CLASS = ""containerConfigurationPane"";
+     private static final String TITLE_CSS_CLASS = ""title"";
++    private String applicationName;
++    private String applicationVersion;
++    private String applicationGitRevision;
++    private String applicationBuildTimestamp;
+     private final ObservableList<String> repositories = FXCollections.observableArrayList();
+     private ComboBox<Theme> themes;
+     private Consumer<Settings> onSave;",These could be final,Shouldn't these be static constants?
+9059,"@@ -103,7 +103,7 @@ public abstract class AbstractRestInvocation {
+     @SuppressWarnings(""unchecked"")
+     Map<String, String> cseContext =
+         JsonUtils.readValue(strCseContext.getBytes(StandardCharsets.UTF_8), Map.class);
+-    invocation.setContext(cseContext);
++    invocation.addContext(cseContext);
+   }
+
+   public String getContext(String key) {","highway have the same problem we can add a new method in invocation: mergeContext 1.if new context have more items, then addAll to new context, and replace old context 2.if new context have less items, then allAll to old context directly.",was this a bug?
+9060,"@@ -637,12 +637,15 @@ namespace GenFacades
+
+             private static void TraceDuplicateSeedTypeError(string docId, IReadOnlyList<INamedTypeDefinition> seedTypes)
+             {
+-                Trace.TraceError(""The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the following arguments to choose the preferred seed type:"", docId);
++                var sb = new StringBuilder();
++                sb.AppendFormat(""The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the following arguments to choose the preferred seed type:"", docId);
+
+                 foreach (INamedTypeDefinition type in seedTypes)
+                 {
+-                    Trace.TraceError(""  /preferSeedType:{0}={1}"", docId.Substring(""T:"".Length), type.GetAssembly().Name.Value);
++                    sb.AppendFormat(""  /preferSeedType:{0}={1}"", docId.Substring(""T:"".Length), type.GetAssembly().Name.Value);
+                 }
++
++                Trace.TraceError(sb.ToString());
+             }
+
+             private void AddTypeForward(Assembly assembly, INamedTypeDefinition seedType)",Created a single error so it's not interleaved in log,This can just be `StringBuilder`.
+9061,"@@ -94,11 +94,9 @@ describe('exportFile', () => {
+
+       const result = plugin._createBlob(formatter);
+
+-      if (!Handsontable.helper.isIE9()) {
+-        expect(formatter.export).toHaveBeenCalled();
+-        expect(result.size).toBe(7);
+-        expect(result.type).toBe('foo;charset=iso-8859-1');
+-      }
++      expect(formatter.export).toHaveBeenCalled();
++      expect(result.size).toBe(7);
++      expect(result.type).toBe('foo;charset=iso-8859-1');
+     });
+   });
+ });",`isIE9` was reverted. Shouldn't this condition be reverted as well?,Shouldn't this be using `expect(f
+9062,"@@ -504,14 +504,14 @@ int LuaScriptInterface::luaErrorHandler(lua_State* L)
+ 	return 1;
+ }
+
+-bool LuaScriptInterface::callFunction(int params)
++bool LuaScriptInterface::callFunction(int params, bool defaultReturn /* = false */)
+ {
+ 	bool result = false;
+ 	int size = lua_gettop(luaState);
+ 	if (protectedCall(luaState, params, 1) != 0) {
+ 		LuaScriptInterface::reportError(nullptr, LuaScriptInterface::getString(luaState, -1));
+ 	} else {
+-		result = LuaScriptInterface::getBoolean(luaState, -1);
++		result = LuaScriptInterface::getBoolean(luaState, -1, defaultReturn);
+ 	}
+
+ 	lua_pop(luaState, 1);","Sorry if I'm being too pedantic here, but wouldn't it be nice to have standard parameter name? Like using `defaultValue` everywhere.",`const bool defaultReturn = false
+9063,"@@ -119,9 +119,14 @@ func defaultBServer(ctx Context) string {
+ 	case libkb.DevelRunMode:
+ 		return memoryAddr
+ 	case libkb.StagingRunMode:
+-		return ""bserver-0.dev.keybase.io:443""
++		return `
++			bserver-0.dev.keybase.io:443,bserver-1.dev.keybase.io:443;
++			bserver.dev.keybase.io:443`
+ 	case libkb.ProductionRunMode:
+-		return ""bserver.kbfs.keybase.io:443""
++		return `
++			bserver-0.kbfs.keybaseapi.com:443,bserver-1.kbfs.keybaseapi.com:443;
++			bserver-0.kbfs.keybase.io:443,bserver-1.kbfs.keybase.io:443;
++			bserver.kbfs.keybase.io:443`
+ 	default:
+ 		return """"
+ 	}","Remind me again: what's the point of having new clients connect to both -0 and -1? If we ever have to blackhole -0, we'd have to blackhole -1 at the same time, right? What is supposed to be the difference between the two? Is it just that someday we might want to have two ELBs, and this will help load balance between them?",is this a bug?
+9064,"@@ -1792,8 +1792,8 @@ func (s *Server) createClient(conn net.Conn) *client {
+
+ 	// Do final client initialization
+
+-	// Set the First Ping timer.
+-	s.setFirstPingTimer(c)
++	// Set the Ping timer. Will be reset once connect was received.
++	c.setPingTimer()
+
+ 	// Spin up the read loop.
+ 	s.startGoRoutine(func() { c.readLoop() })",Why not go back to `c.setPingTimer()` here instead so you don't need the new boolean in setFirstPingTimer().,How about `setFirstPingTimer`?
+9065,"@@ -1,4 +1,4 @@
+-/*
++/*
+  * Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
+  *                  MacCoss Lab, Department of Genome Sciences, UW
+  *",We should figure out why so many of these files have an invisible change on the first line: Are we writing out some sort of byte order mark?,revert this file
+9066,"@@ -1,19 +1,3 @@
+-/*
+-Copyright 2018 The Kubernetes Authors.
+-
+-Licensed under the Apache License, Version 2.0 (the ""License"");
+-you may not use this file except in compliance with the License.
+-You may obtain a copy of the License at
+-
+-    http://www.apache.org/licenses/LICENSE-2.0
+-
+-Unless required by applicable law or agreed to in writing, software
+-distributed under the License is distributed on an ""AS IS"" BASIS,
+-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-See the License for the specific language governing permissions and
+-limitations under the License.
+-*/
+-
+ package resource
+
+ import (",Was this our code @csrwng,Delete the file
+9067,"@@ -24,6 +24,7 @@ module Travis
+             end
+             sh.echo ""Build id: #{Shellwords.escape(data.build[:id])}""
+             sh.echo ""Job id: #{Shellwords.escape(data.job[:id])}""
++            sh.echo ""Runtime kernel version: #{`uname -r`.strip}""
+           end
+
+           def show_travis_build_version",I think you need `.untaint` here.,Do we need to call `strip` her
+9068,"@@ -227,7 +227,10 @@ module Bolt
+           raise Bolt::ValidationError, ""The project '#{name}' will not be loaded. The project name conflicts ""\
+             ""with a built-in Bolt module of the same name.""
+         end
+-      else
++      elsif name.nil? &&
++            (File.directory?(plans_path) ||
++            File.directory?(@path + 'tasks') ||
++            File.directory?(@path + 'files'))
+         message = ""No project name is specified in bolt-project.yaml. Project-level content will not be available.""
+         @logs << { warn: message }
+       end","Why are we including the `files/` directory in this check? I know `tasks/` and `plans/` make sense, since you can reference content in those directories from the CLI, but I don't think you can for `files/` (unless I'm missing a command).",Align the operands of an expression in an assignment spanning multiple lines.
+9069,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+
+ import com.google.common.collect.Maps;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.,Is this import needed?
+9070,"@@ -72,6 +72,11 @@ const (
+ // A valid Certificate requires at least one of a CommonName, DNSName, or
+ // URISAN to be valid.
+ type CertificateSpec struct {
++	// Full X509 name specification (https://golang.org/pkg/crypto/x509/pkix/#Name).
++	// If specified, overrides any other name elements below.
++	// +optional
++	X509Name *X509DistinguishedName `json:""x509Name,omitempty""`
++
+ 	// CommonName is a common name to be used on the Certificate.
+ 	// The CommonName should have a length of 64 characters or fewer to avoid
+ 	// generating invalid CSRs.","Can we rename this field to `Subject`? Looking around, it seems like 'subject' is the standard terminology for this stanza  ",`X509Name` is a `string` so `X509DistinguishedName` is `string`.
+9071,"@@ -15,7 +15,7 @@ was persisted in the address book and the node has been restarted).
+
+ So the information has been changed, and potentially upon disconnection,
+ the depth can travel to a shallower depth in result.
+-If a peer gets added through AddPeer, this does not necessarily infer
++If a peer gets added through AddPeers , this does not necessarily infer
+ an immediate depth change, since the peer might end up in the backlog for
+ a long time until we actually need to connect to her.
+ ",Remove additional whitespace.,It looks like there's an extra space after `this does not necessarily infer`.
+9072,"@@ -171,6 +171,16 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
+ 		http.SetCookie(w, cookie)
+ 	}
+
++	if cookies := md.HeaderMD.Get(""Set-Cookie-Refresh-Token""); len(cookies) > 0 {
++		cookie := &http.Cookie{
++			Name:     ""refreshToken"",
++			Value:    cookies[0],
++			Path:     ""/v1/authn/login"",
++			HttpOnly: true, // Client cannot access refresh token, it is sent by browser only if login is attempted.
++		}
++		http.SetCookie(w, cookie)
++	}
++
+ 	// Redirect if it's the browser (non-XHR).
+ 	redirects := md.HeaderMD.Get(""Location"")
+ 	if len(redirects) > 0 && isBrowser(requestHeadersFromResponseWriter(w)) {",We should add `Secure` as well,I think this should be `HttpOnly: true`
+9073,"@@ -12,7 +12,7 @@ import (
+ // TestIntegration runs integration tests against the remote
+ func TestIntegration(t *testing.T) {
+ 	fstests.Run(t, &fstests.Opt{
+-		RemoteName: ""TestWebdavNexcloud:"",
++		RemoteName: ""TestWebdavNextcloud:"",
+ 		NilObject:  (*webdav.Object)(nil),
+ 	})
+ }",I presume this isn't a big deal,What's the difference between this and
+9074,"@@ -2974,7 +2974,8 @@ raw_mem_alloc(size_t size, uint prot, void *addr, dr_alloc_flags_t flags)
+             : (TEST(DR_ALLOC_COMMIT_ONLY, flags) ? RAW_ALLOC_COMMIT_ONLY : 0);
+ #    endif
+         if (IF_WINDOWS(TEST(DR_ALLOC_COMMIT_ONLY, flags) &&) addr != NULL &&
+-            !app_memory_pre_alloc(get_thread_private_dcontext(), addr, size, prot, false))
++            !app_memory_pre_alloc(get_thread_private_dcontext(), addr, size, prot, false,
++                                  true /*update*/, false /*!image*/))
+             p = NULL;
+         else
+             p = os_raw_mem_alloc(addr, size, prot, os_flags, &error_code);","Maybe {}, even though no multi-line body?",(style) line over 80 characters
+9075,"@@ -39,6 +39,16 @@ describe CommunicartMailer do
+       mail.from.should == ['reply@communicart-stub.com']
+     end
+
++   it 'renders the navigator template' do
++      cart.setProp('origin','navigator')
++      cart.stub(:approval_group).and_return(approval_group)
++      approval_group.stub(:approvers).and_return([approver])
++      approver.stub(:approver_comment).and_return([])
++# This is very fragile, it is based on a particular term coming from the navigator teplate.
++# If the template changes, this test will break --- I know of no other way of tesitng this.
++      expect(mail.body.encoded).to match('NAVIGATOR')
++    end
++
+     context 'attaching a csv of the cart activity' do
+       it 'generates csv attachments for an approved cart' do
+         cart.stub(:approval_group).and_return(approval_group)",We can try something like this: response.should render_template(:partial => 'partial_name'),Line is too long. [97/80]
+9076,"@@ -514,6 +514,10 @@ IDRETRY=4
+ IDCANCEL=3
+
+ def MessageBox(hwnd, text, caption, type):
++	if hasattr(text, 'decode'):
++		text = text.decode('mbcs')
++	if caption and hasattr(caption, 'decode'):
++		caption = caption.decode('mbcs')
+ 	res = user32.MessageBoxW(hwnd, text, caption, type)
+ 	if res == 0:
+ 		raise WinError()","Please use `isinstance(text, bytes)` instead. Otherwise, this will lead to unnecessary decoding on python 2 unicode strings.",Is this still needed?
+9077,"@@ -3068,7 +3068,7 @@ void SwiftLanguageRuntime::FindFunctionPointersInCall(
+                   ExecutionContext exe_ctx;
+                   frame.CalculateExecutionContext(exe_ctx);
+                   error = argument_values.GetValueAtIndex(0)->GetValueAsData(
+-                      &exe_ctx, data, 0, NULL);
++                      &exe_ctx, data, NULL);
+                   lldb::offset_t offset = 0;
+                   lldb::addr_t fn_ptr_addr = data.GetPointer(&offset);
+                   Address fn_ptr_address;",This one is unrelated to the GetSymbolVendor removal ... the API to GetValueAsData was changed.,"The name ""GetValueAsD"
+9078,"@@ -45,6 +45,7 @@ func TestMarshalUnmarshalJSON(t *testing.T) {
+ 		desiredStatusUnsafe:   resourcestatus.ResourceCreated,
+ 		knownStatusUnsafe:     resourcestatus.ResourceCreated,
+ 		appliedStatusUnsafe:   resourcestatus.ResourceCreated,
++		networkMode:           bridgeNetworkMode,
+ 	}
+
+ 	bytes, err := json.Marshal(firelensResIn)",can you assert the value of this field below similar to other fields?,Does it make sense to
+9079,"@@ -11,6 +11,7 @@ package net.sourceforge.pmd.lang.java.ast;
+  * <pre class=""grammar"">
+  *
+  * PrimaryExpression ::= {@linkplain ASTLiteral Literal}
++ *                     | {@link ASTClassLiteral ClassLiteral}
+  *                     | {@linkplain ASTMethodCall MethodCall}
+  *                     | {@linkplain ASTFieldAccess FieldAccess}
+  *                     | {@linkplain ASTConstructorCall ConstructorCall}","I'll change that to ""linkplain"" for consistency :)",Shouldn't this be `cl
+9080,"@@ -196,7 +196,12 @@ class RouteFactory(object):
+                                                 self.resource_name,
+                                                 **matchdict)
+                 if object_id == '*':
+-                    object_uri = object_uri.replace('%2A', '*')
++                    # Express the object_uri pattern with precision
++                    # XXX: we could get the model.id_generator pattern, but
++                    # since the backend replace * by .* we can't.
++                    # See Kinto/kinto#970
++                    id_pattern = ""[a-zA-Z0-9_-]+""
++                    object_uri = object_uri.replace('%2A', id_pattern)
+             except KeyError:
+                 # Maybe the resource has no single record endpoint.
+                 # We consider that object URIs in permissions backend will","This is fix. But since the history resource was relying on the bug to work, I had to do some changes regarding the history entries (eg. explicit declare that the permissions inherit from bucket)",Is there a way to test this?
+9081,"@@ -142,6 +142,11 @@ public class DocsStreamer implements Iterator<SolrDocument> {
+     return docIterator.hasNext();
+   }
+
++  // called at the end of the stream
++  public void finish(){
++    if (transformer != null) transformer.finish();
++  }
++
+   public SolrDocument next() {
+     int id = docIterator.nextDoc();
+     idx++;","can't we leverage Closeable here and get some sugar&warns? Also, line 89 still calls setContext() .. is it right? or I'm missing something?",Please move this method to t
+9082,"@@ -52,7 +52,7 @@ func TestPing(t *testing.T) {
+ 	// ping
+ 	peerID := ""124""
+ 	greetings := []string{""hey"", ""there"", ""fella""}
+-	rtt, err := client.Ping(context.Background(), peerID, greetings...)
++	rtt, err := client.Ping(context.Background(), []byte(peerID), greetings...)
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}","Use explicit swarm.Address when defining peerID, by using NewAddress, and remove conversion here.",why these changes?
+9083,"@@ -30,9 +30,13 @@ const (
+ 	rootMountPoint = ""/""
+ 	rootUser       = ""root""
+
++	// RpmDependenciesDirectory is the directory which contains RPM database. It is not required for images that do not contain RPM.
++	RpmDependenciesDirectory = ""/var/lib/rpm""
++
+ 	// /boot directory should be only accesible by root. The directories need the execute bit as well.
+ 	bootDirectoryFileMode = 0600
+ 	bootDirectoryDirMode  = 0700
++	shadowFile            = ""/etc/shadow""
+ )
+
+ // PackageList represents the list of packages to install into an image","`RpmDependenciesDirectory` should start with a lowercase character so it's not exported outside of this package, it looks like its only referenced in this file.",Can you explain why /etc/rpm
+9084,"@@ -25,9 +25,13 @@ class BasicBlock(nn.Module):
+                  conv_cfg=None,
+                  norm_cfg=dict(type='BN'),
+                  dcn=None,
++                 rfp_inplanes=None,
++                 sac=None,
+                  plugins=None):
+         super(BasicBlock, self).__init__()
+         assert dcn is None, 'Not implemented yet.'
++        assert rfp_inplanes is None, 'Not implemented yet.'
++        assert sac is None, 'Not implemented yet.'
+         assert plugins is None, 'Not implemented yet.'
+
+         self.norm1_name, norm1 = build_norm_layer(norm_cfg, planes, postfix=1)","If we make a new backbone class, we don't need to support `BasicBlock`",do we need to add these to the docstring?
+9085,"@@ -359,11 +359,6 @@ configRetry:
+
+ 	// Start up the dataplane driver.  This may be the internal go-based driver or an external
+ 	// one.
+-	if configParams.BPFEnabled && !bpf.SyscallSupport() {
+-		log.Error(""BPFEnabled is set but BPF mode is not supported on this platform.  Continuing with BPF disabled."")
+-		configParams.BPFEnabled = false
+-	}
+-
+ 	var dpDriver dp.DataplaneDriver
+ 	var dpDriverCmd *exec.Cmd
+ ",This was an out-of-date dupe of the check on line 335,We should still throw an error when BPF i
+9086,"@@ -44,7 +44,6 @@ window.PluginsView = countlyView.extend({
+
+             this.dtable = $('#plugins-table').dataTable($.extend({}, $.fn.dataTable.defaults, {
+                 ""aaData"": pluginsData,
+-                ""bPaginate"": false,
+                 ""aoColumns"": [
+                     { ""mData"": function (row, type) { if (row.enabled) { return jQuery.i18n.map[row.code + "".plugin-title""] || jQuery.i18n.map[row.code + "".title""] || row.title; } else return row.title }, ""sType"": ""string"", ""sTitle"": jQuery.i18n.map[""plugins.name""] },
+                     {",Let's put this back,I don't think this is needed any more
+9087,"@@ -122,9 +122,9 @@ bool Mailbox::sendItem(Item* item) const
+ 		}
+ 	} else {
+ 		Player tmpPlayer(nullptr);
+-		if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
++		//if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
+ 			return false;
+-		}
++		//}
+
+ 		if (g_game.internalMoveItem(item->getParent(), tmpPlayer.getInbox(), INDEX_WHEREEVER,
+ 		                            item, item->getItemCount(), nullptr, FLAG_NOLIMIT) == RET_NOERROR) {",Things like these should have been addressed before submitting a pull request.,please remove this too
+9088,"@@ -77,7 +77,7 @@ public class ITZipkinMetrics {
+
+     // ensure we don't track prometheus, UI requests in prometheus
+     assertThat(scrape())
+-      .doesNotContain(""prometheus"")
++      .doesNotContain(""prometheus_notifications"")
+       .doesNotContain(""uri=\""/zipkin"")
+       .doesNotContain(""uri=\""/\"""");
+   }",This one as well. Any better suggestion please?,Why do we want to track metrics and UI requests here?
+9089,"@@ -267,6 +267,11 @@ func (s *Server) internalSendLoop(wg *sync.WaitGroup) {
+ 			c.pa.reply = []byte(pm.rply)
+ 			c.mu.Unlock()
+
++			if c.trace {
++				c.traceInOp(fmt.Sprintf(
++					""PUB %s %s %d"", c.pa.subject, c.pa.reply, c.pa.size), nil)
++			}
++
+ 			// Add in NL
+ 			b = append(b, _CRLF_...)
+ 			c.processInboundClientMsg(b)","wonder if we should collect c.trace, c.pa.subject, etc.. while under the lock to prevent data races.. or simply move the tracing under the lock.",Do we want to log the time here or in the operation i
+9090,"@@ -182,7 +182,7 @@ PJ_XY pj_fwd(PJ_LP lp, PJ *P) {
+
+     last_errno = proj_errno_reset(P);
+
+-    if (!P->skip_fwd_prepare)
++    if (!P->skip_fwd_prepare && 0 != strcmp(P->short_name, ""s2""))
+         coo = fwd_prepare (P, coo);
+     if (HUGE_VAL==coo.v[0] || HUGE_VAL==coo.v[1])
+         return proj_coord_error ().xy;","Why is this hack needed ? Ideally, we shouldn't need that.","`!P->skip_fwd_prepare && 0 != strcmp(P->short_name, """
+9091,"@@ -0,0 +1,19 @@
++package plugin
++
++type Status struct {
++	DriverName     string
++	MeshDriverName string `json:""MeshDriverName,omitempty""`
++	Version        int
++}
++
++func NewStatus(address, meshAddress string, isPluginV2 bool) *Status {
++	status := &Status{
++		DriverName:     pluginNameFromAddress(address),
++		MeshDriverName: pluginNameFromAddress(meshAddress),
++		Version:        1,
++	}
++	if isPluginV2 {
++		status.Version = 2
++	}
++	return status
++}","Minor/Nitpick: replace `1` with a constant, esp. as used in `prog/weaver/http.go` in `{{if eq .Plugin.Version 1}}`",Could we use `v1.Status` here?
+9092,"@@ -13,5 +13,5 @@ namespace Datadog.Trace.Configuration
+         {
+             return Environment.GetEnvironmentVariable(key);
+         }
+-    }
++   }
+ }","nit: Looks like the whitespace got thrown off, can you fix this?",Revert this file?
+9093,"@@ -5593,7 +5593,13 @@ namespace pwiz.Skyline.Properties {
+                 return ResourceManager.GetString(""CommandLine_ImportAnnotations_Error__Failed_while_reading_annotations_"", resourceCulture);
+             }
+         }
+-
++
++        public static string CommandLine_ImportPeakBoundaries_Error__Failed_while_importing_boundaries_ {
++            get {
++                return ResourceManager.GetString(""CommandLine_ImportPeakBoundaries_Error__Failed_while_importing_boundaries_"", resourceCulture);
++            }
++        }
++
+         /// <summary>
+         ///   Looks up a localized string similar to Error: The replicate {0} already exists in the given document and the --import-append option is not specified.  The replicate will not be added to the document..
+         /// </summary>",Redo this by adding a string literal and then pressing F6 to have Resharper move it to Properties\Resources.resx which will also create this property.,nit: for consiste
+9094,"@@ -0,0 +1,11 @@
++// +build !windows
++// Copyright 2012-2017 Apcera Inc. All rights reserved.
++
++package server
++
++// Run starts the NATS server. This wrapper function allows Windows to add a
++// hook for running NATS as a service.
++func Run(server *Server) error {
++	server.Start()
++	return nil
++}","Unless a log file has been specified, IMO you should set the server option to enable syslog (windows event log) here, or someplace along the service start code path. We shouldn't really rely on users to specify that when creating the service.",I wonder if this
+9095,"@@ -86,8 +86,8 @@ public class TestFlinkCatalogTable extends FlinkCatalogTestBase {
+             Types.NestedField.optional(1, ""strV"", Types.StringType.get())));
+     Assert.assertEquals(
+         Arrays.asList(
+-            TableColumn.of(""id"", DataTypes.BIGINT()),
+-            TableColumn.of(""strV"", DataTypes.STRING())),
++            TableColumn.physical(""id"", DataTypes.BIGINT()),
++            TableColumn.physical(""strV"", DataTypes.STRING())),
+         getTableEnv().from(""tl"").getSchema().getTableColumns());
+     Assert.assertTrue(getTableEnv().getCatalog(catalogName).get().tableExists(ObjectPath.fromString(""db.tl"")));
+   }","It's strange here, because I saw the `TableColumn` is marked as `PublicEvolving`, but after released flink 1.12.0 it did not have any Interface compatibility guarantee. At least, it should marked as `deprecated`, and keep it a major release.",minor: I wonder i
+9096,"@@ -104,7 +104,7 @@ public abstract class ConnectionPageAbstract extends DialogPage implements IData
+
+         if (!site.isNew() && !site.getDriver().isEmbedded()) {
+             Link netConfigLink = new Link(panel, SWT.NONE);
+-            netConfigLink.setText(""<a>Network settings (SSH, SSL, Proxy, ...)</a>"");
++            netConfigLink.setText(""<a>"" + CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link + ""</a>"");
+             netConfigLink.addSelectionListener(new SelectionAdapter() {
+                 @Override
+                 public void widgetSelected(SelectionEvent e) {","I'm not sure regarding this approach, for me the whole text including anchors should go to resources like ` netConfigLink.setText(CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link); ` You shouldn't concatenate translated values inside the code. If you need some params, please use NLS.bind()",Probably a stupid question but why not use `<a href>` instead of `<a href>`?
+9097,"@@ -78,6 +78,7 @@ func (c *connectionFlowController) GetWindowUpdate() protocol.ByteCount {
+ func (c *connectionFlowController) EnsureMinimumWindowSize(inc protocol.ByteCount) {
+ 	c.mutex.Lock()
+ 	if inc > c.receiveWindowSize {
++		c.logger.Debugf(""Increasing receive flow control window for the connection to %d kB, in response to stream flow control window increase"", c.receiveWindowSize/(1<<10))
+ 		c.receiveWindowSize = utils.MinByteCount(inc, c.maxReceiveWindowSize)
+ 		c.startNewAutoTuningEpoch()
+ 	}",How often do we expect this to trigger? Should we maybe put it behind an if logger.Debug()?,"This log line is a bit cryptic. How about: ""Increasing receive flow control "
+9098,"@@ -126,12 +126,12 @@ func Snapshot(volname string, snapname string, labels map[string]string) (string
+ 		return """", err
+ 	}
+
+-	volume, err := GetVolume(controller.address)
++	volume, err := GetVolume(controller.Address)
+ 	if err != nil {
+ 		return """", err
+ 	}
+
+-	url := controller.address + ""/volumes/"" + volume.Id + ""?action=snapshot""
++	url := controller.Address + ""/volumes/"" + volume.Id + ""?action=snapshot""
+
+ 	fmt.Println(""Url is:"", url)
+ ","How was the name `controller` arrived? Can you get a consensus for the name controller ? This may be OK for jiva. However, c-stor does not have a concept called `controller`.",@liggitt I don't know if this is correct. @liggitt is there a better way to
+9099,"@@ -151,6 +151,16 @@ func (v *ConfigValidator) sysctl(config *configs.Config) error {
+ 				return fmt.Errorf(""sysctl %q is not allowed in the hosts network namespace"", s)
+ 			}
+ 		}
++		if config.Namespaces.Contains(configs.NEWUTS) {
++			switch s {
++			case ""kernel.domainname"":
++				// This is namespaced and there's no explicit OCI field for it.
++				continue
++			case ""kernel.hostname"":
++				// This is namespaced but there's a conflicting (dedicated) OCI field for it.
++				return fmt.Errorf(""sysctl %q is not allowed as it conflicts with the OCI %q field"", s, ""hostname"")
++			}
++		}
+ 		return fmt.Errorf(""sysctl %q is not in a separate kernel namespace"", s)
+ 	}
+ ",i dont think we need to explicitly single out `kernel.domainname` here since its not a TODO for OCI either right ?,"Would it make sense to move this into a `const` at the top of the file, and "
+9100,"@@ -66,7 +66,7 @@ static void on_setup_ostream(h2o_filter_t *_self, h2o_req_t *req, h2o_ostream_t
+     if (!req->res.mime_attr->is_compressible)
+         goto Next;
+     /* 100 is a rough estimate */
+-    if (req->res.content_length <= 100)
++    if (req->res.content_length <= self->args.min_size)
+         goto Next;
+     /* skip if failed to gather the list of compressible types */
+     if ((compressible_types = h2o_get_compressible_types(&req->headers)) == 0)",Should we better change the operator to `<` since the variable defines the minimum size that gets compressed?,"@danimtb I don't understand how this works. If the size of the buffer is smaller than the min size, then I don't think this will do the right thing."
+9101,"@@ -233,6 +233,14 @@ public class StreamTest extends AbstractLinearSeqTest {
+         assertThat(actual).isEqualTo(3);
+     }
+
++    // -- append
++
++    @Test
++    public void shouldAppendMillionTimes() {
++        final int bigNum = 1_000_000;
++        assertThat(Stream.range(0, bigNum).foldLeft(Stream.empty(), Stream::append).length()).isEqualTo(bigNum);
++    }
++
+     // -- combinations
+
+     @Test",I'm really impressed by the AppendElements addition! Very cool! :-),This test should be in `shouldAppendMillionTimes`
+9102,"@@ -230,7 +230,7 @@ public class GridLauncherV3 {
+     }
+
+     configureLogging(common.getLog(), common.getDebug());
+-    log.info(version());
++    log.finest(version());
+     return true;
+   }
+ ",This change means that users can't easily see which version of the selenium server they're using. This is `info` level information.,This is the only real change in this file. The rest of the changes are from `info`.
+9103,"@@ -41,6 +41,8 @@ from qutebrowser.misc import editor, guiprocess
+ from qutebrowser.completion.models import urlmodel, miscmodels
+ from qutebrowser.mainwindow import mainwindow
+
++# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-69904
++MAX_WORLD_ID = 256 if qtutils.version_check('5.11.2') else 11
+
+ class CommandDispatcher:
+ ",This should be in qtutils and imported to here and the other place instead of declaring it twice.,How about `QTBUG_69904`?
+9104,"@@ -73,6 +73,15 @@ func (l *Logger) FetchCert(ctx context.Context, url string, bundle bool) ([][]by
+ 	return l.baseCl.FetchCert(ctx, url, bundle)
+ }
+
++func (l *Logger) FetchCertAlternatives(ctx context.Context, url string, bundle bool) ([][][]byte, error) {
++	l.log.V(logf.TraceLevel).Info(""Calling FetchCertAlternatives"")
++
++	ctx, cancel := context.WithTimeout(ctx, timeout)
++	defer cancel()
++
++	return l.baseCl.FetchCertAlternatives(ctx, url, bundle)
++}
++
+ func (l *Logger) WaitOrder(ctx context.Context, url string) (*acme.Order, error) {
+ 	l.log.V(logf.TraceLevel).Info(""Calling WaitOrder"")
+ ","Seems a bit weird to add a timeout in ""logging"" middleware, but I see that that is done elsewhere, so fine.","If the caller passed a timeout, this function will never get called. Is that what we want?"
+9105,"@@ -25,7 +25,7 @@ export default AbstractIndexRoute.extend(ModalHelper, UserSession, {
+   actions: {
+     deleteItem(item) {
+       let i18n = this.get('i18n');
+-      let message = i18n.t('admin.customForms.messages.deleteForm');
++      let message = i18n.t('messages.delete_singular', { name: 'form' });
+       let model = Ember.Object.create({
+         itemToDelete: item
+       });",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,Shouldn't the name be `deleteForm`?
+9106,"@@ -556,6 +556,13 @@ class Uppy {
+       files: updatedFiles
+     })
+
++    // If nothing is uploading anymore, and if nothing has uploaded yet - allow new uploads!
++    if (Object.keys(updatedFiles).length === 0) {
++      this.setState({
++        allowNewUpload: true
++      })
++    }
++
+     removeUploads.forEach((uploadID) => {
+       this._removeUpload(uploadID)
+     })","Could we combine this with the `setState` call above, so we don't have to call it twice?",Would it make sense to instead set `allowNewUpload: true` when the array is empty? That wa
+9107,"@@ -31,10 +31,10 @@ class String
+   end
+
+   def fix_encoding_if_invalid!
+-    unless valid_encoding?
+-      encode!('utf-8', 'binary', invalid: :replace, undef: :replace)
+-    end
+-    force_encoding('utf-8')
++    # All new strings claim to be 8-bit ASCII in the DB, but are really saved as UTF-8...
++    force_encoding('utf-8') unless encoding == 'UTF-8'
++    # ...but old strings are a hodge-podge of encodings, so replace any unrecognizable characters with unknowns.
++    encode!('utf-8', invalid: :replace, undef: :replace) unless valid_encoding?
+     self
+   end
+ ","That part that still leaves me mystified is how the String class, when populated with a value from the SQL_ASCII encoded database is set to ""UTF-8"" encoding. Since the database is SQL_ASCII, each byte in the string stored in the database is considered one character. Ruby, however, is using UTF-8, which is writing a series of one-byte code points that are only meaningful when considered in the correct encoding. When Ruby passes a string to Postgresql, the code points are essentially ""flattened"" into bytes as they are written to the DB. When Rails (through Ruby) asks for a string from the DB, where does the information about the encoding come from?",I'm not sure that this is the right fix. What if we just put the `encode!` call in the `un
+9108,"@@ -233,13 +233,14 @@ func PrecreatedDaoOption(dao *blockDAO) Option {
+ 	}
+ }
+
+-// BoltDBDaoOption sets blockchain's dao with BoltDB from config.Chain.ChainDBPath
++// BoltDBDaoOption sets blockchain's dao with BoltDB from config.Chain.ChainDBPath and cfg.DB.IndexDBPath
+ func BoltDBDaoOption() Option {
+ 	return func(bc *blockchain, cfg config.Config) error {
+ 		cfg.DB.DbPath = cfg.Chain.ChainDBPath // TODO: remove this after moving TrieDBPath from cfg.Chain to cfg.DB
+ 		_, gateway := cfg.Plugins[config.GatewayPlugin]
+ 		bc.dao = newBlockDAO(
+-			db.NewBoltDB(cfg.DB),
++			db.NewBoltDB(cfg.DB, cfg.DB.DbPath),
++			db.NewBoltDB(cfg.DB, cfg.DB.IndexDBPath),
+ 			gateway && !cfg.Chain.EnableAsyncIndexWrite,
+ 			cfg.Chain.CompressBlock,
+ 			cfg.Chain.MaxCacheSize,",Is it a doable way and does it make sense.,BoltDB already has a chaindb path and this does not need to be added again.
+9109,"@@ -95,7 +95,10 @@ def verify_limit_range(limit):
+     max_query_limit = constants.MAX_QUERY_SIZE
+     if limit > max_query_limit:
+         LOG.warning('Query limit %d was larger than max query limit %d, '
+-                    'setting limit to %d', limit, max_query_limit, max)
++                    'setting limit to %d',
++                    limit,
++                    max_query_limit,
++                    max_query_limit)
+         limit = max_query_limit
+     return limit
+ ","max was wrong here. As its buitlt-in, not a number, and a TypeError was thrown.",So now there is no guarantee that `limit` will be > `max_query_limit`?
+9110,"@@ -1,3 +1,5 @@
++#! /usr/bin/env python
++
+ # MIT License
+
+ # Copyright (c) 2018 Jose Amores","This change is not needed, please revert it.",Don't forget to remove this file when you make a PR
+9111,"@@ -40,7 +40,9 @@ def train(params, train_set, num_boost_round=100,
+         Customized objective function.
+     feval : callable or None, optional (default=None)
+         Customized evaluation function.
++        Should accept two parameters: preds, train_data.
+         Note: should return (eval_name, eval_result, is_higher_better) or list of such tuples.
++        To ignore the default metric in params, set it to the string ``""None""``
+     init_model : string or None, optional (default=None)
+         Filename of LightGBM model or Booster instance used for continue training.
+     feature_name : list of strings or 'auto', optional (default=""auto"")","@ClimbsRocks Please add that it could be a string. `feval : callable, string or None, optional (default=None)`",@matt-gardner How's this?
+9112,"@@ -1,7 +1,7 @@
+ # frozen_string_literal: true
+
+ module Faker
+-  class Sports
++  class Sports < Base
+     class Basketball < Base
+       class << self
+         ##","now that I have started using, I realized, I could have named my new class singular `Sport` and not having to make this change. let me know, I will update",Metrics/LineLength: Line is too long. [87/80]
+9113,"@@ -23,7 +23,7 @@ func GetApps() map[string][]App {
+ 	apps := make(map[string][]App)
+ 	for platformType := range PluginMap {
+ 		labels := map[string]string{
+-			""com.ddev.platform"":          platformType,
++			""com.ddev.platform"":          ""ddev"",
+ 			""com.docker.compose.service"": ""web"",
+ 		}
+ 		sites, err := dockerutil.FindContainersByLabels(labels)",Not sure why this is changing to a hard-coded string.,"Should we make this `""com.ddev.platform""` not"
+9114,"@@ -453,6 +453,15 @@ class FlowContentView(RequestHandler):
+         ))
+
+
++class Commands(RequestHandler):
++    def post(self):
++        result = self.master.commands.execute(self.json[""command""])
++        if result is None:
++            self.write({""result"": """"})
++            return
++        self.write({""result"": str(result)})
++
++
+ class Events(RequestHandler):
+     def get(self):
+         self.write([logentry_to_json(e) for e in self.master.events.data])","Is there a reason why we `str` the result? It would be nice to eventually support more datatypes here, so we want to generally aim for arbitrary JSON.","I think you should use `self.json[""result""]` "
+9115,"@@ -29,7 +29,7 @@ import java.util.Iterator;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.Set;
+-import org.apache.commons.lang.SerializationUtils;
++import org.apache.commons.lang3.SerializationUtils;
+ import org.apache.hadoop.io.Writable;
+ import org.apache.hadoop.mapreduce.InputFormat;
+ import org.apache.hadoop.mapreduce.InputSplit;",Why did we update the to this api?,"I think this is a mistake, the import should "
+9116,"@@ -164,4 +164,17 @@ public class Preferences {
+     public SharedPreferences getPreferences() {
+         return mStorage;
+     }
++
++    public static <T extends Enum<T>> T getEnumStringPref(SharedPreferences prefs, String key, T defaultEnum) {
++        String stringPref = prefs.getString(key, defaultEnum.name());
++        try {
++            return Enum.valueOf(defaultEnum.getDeclaringClass(), stringPref);
++        } catch (Exception ex) {
++            Log.w(K9.LOG_TAG, ""Unable to convert preference key ["" + key +
++                    ""] value ["" + stringPref + ""] to enum of type "" + defaultEnum.getDeclaringClass(), ex);
++
++            return defaultEnum;
++        }
++    }
++
+ }",should probably just catch `IllegalArgumentException` here,I think it should be `Log.w` instead of `Log.w`
+9117,"@@ -38,7 +38,9 @@ type truncateFunc func(t Time, d Duration) Time
+ func (w *Window) getTruncateFunc(d Duration) (truncateFunc, error) {
+ 	switch months, nsecs := d.Months(), d.Nanoseconds(); {
+ 	case months != 0 && nsecs != 0:
+-		return nil, errors.New(codes.Invalid, ""duration used as an interval cannot mix month and nanosecond units"")
++		const docURL = ""https://v2.docs.influxdata.com/v2.0/reference/flux/stdlib/built-in/transformations/window/#calendar-months-and-years""
++		return nil, errors.New(codes.Invalid, ""duration used as an interval cannot mix month and nanosecond units"").
++			WithDocURL(docURL)
+ 	case months != 0:
+ 		return truncateByMonths, nil
+ 	case nsecs != 0:",What does this error message mean?,Is it valid to use a URL that ends with a `/`?
+9118,"@@ -864,7 +864,7 @@ def get_utf8_value(value):
+         return value
+
+     if not isinstance(value, six.string_types):
+-        value = six.text_type(value)
++        value = six.text_type(value).encode('utf-8')
+
+     if isinstance(value, six.text_type):
+         value = value.encode('utf-8')","I don't think this change is necessary. If we cast `value` to type `six.text_type`, then the next if statement should evaluate to True and do the encoding for us.",Could you explain why this change is needed?
+9119,"@@ -54,6 +54,11 @@ class CartItem < ActiveRecord::Base
+             )
+           end
+         end
++      else
++        self.cart_item_traits.build(
++          name: trait[0],
++          value: handle_trait_values_for(trait)
++        )
+       end
+     end
+   end",Can we move this into a method(s)?,Useless assignment to variable - `item`.
+9120,"@@ -22,3 +22,13 @@ func uitoa(val uint) string {
+ 	buf[i] = byte(val + '0')
+ 	return string(buf[i:])
+ }
++
++// clen returns the index of the first NULL byte in n or len(n) if n contains no NULL byte.
++func clen(n []byte) int {
++	for i := 0; i < len(n); i++ {
++		if n[i] == 0 {
++			return i
++		}
++	}
++	return len(n)
++}",You could perhaps call this `strlen` (although I don't particularly care about the name as it is an implementation detail).,nit: `if n[i] == 0 { return 0 }`
+9121,"@@ -15,13 +15,8 @@ public class Regula
+ {
+     public const int Iterations = 4000000;
+
+-    public static volatile object VolatileObject;
+-
+     [MethodImpl(MethodImplOptions.NoInlining)]
+-    private static void Escape(object obj)
+-    {
+-        VolatileObject = obj;
+-    }
++    private static void Escape(object _) { }
+
+     [Benchmark(Description = nameof(Regula))]
+     public bool Test()",should we have a common `Escape()` method that can be used everywhere?,why did you make this public?
+9122,"@@ -228,7 +228,6 @@ export function diff(
+  */
+ export function commitRoot(commitQueue, root) {
+ 	if (options._commit) options._commit(root, commitQueue);
+-
+ 	commitQueue.some(c => {
+ 		try {
+ 			commitQueue = c._renderCallbacks;",The whitespace removal above here is probably unintentional :slightly_smiling_face:,Looks like there's some whitespa
+9123,"@@ -90,14 +90,14 @@ func newServer(cfg config.Config, testing bool) (*Server, error) {
+ func (s *Server) Start(ctx context.Context) error {
+ 	cctx, cancel := context.WithCancel(context.Background())
+ 	s.subModuleCancel = cancel
+-	if err := s.p2pAgent.Start(cctx); err != nil {
+-		return errors.Wrap(err, ""error when starting P2P agent"")
+-	}
+ 	for _, cs := range s.chainservices {
+ 		if err := cs.Start(cctx); err != nil {
+ 			return errors.Wrap(err, ""error when starting blockchain"")
+ 		}
+ 	}
++	if err := s.p2pAgent.Start(cctx); err != nil {
++		return errors.Wrap(err, ""error when starting P2P agent"")
++	}
+ 	if err := s.dispatcher.Start(cctx); err != nil {
+ 		return errors.Wrap(err, ""error when starting dispatcher"")
+ 	}",should we start p2p even after dispatcher? b/c dispatcher handles msg from p2p,Was this broken before?
+9124,"@@ -101,13 +101,13 @@ func TestHandleInterfaceEmptySuccess(t *testing.T) {
+ 	handler := jsonHandler{reader: ifaceEmptyReader{}, handler: reflect.ValueOf(h)}
+
+ 	reqBuf := yarpc.NewBufferString(`[""a"", ""b"", ""c""]`)
+-	_, _, err := handler.Handle(context.Background(), &yarpc.Request{
++	_, respBuf, err := handler.Handle(context.Background(), &yarpc.Request{
+ 		Procedure: ""foo"",
+ 		Encoding:  ""json"",
+ 	}, reqBuf)
+
+ 	require.NoError(t, err)
+-	assert.JSONEq(t, `[""a"", ""b"", ""c""]`, reqBuf.String())
++	assert.JSONEq(t, `[""a"", ""b"", ""c""]`, respBuf.String())
+ }
+
+ func TestHandleSuccessWithResponseHeaders(t *testing.T) {",Did we decide once and for all to use req/resp throughout spring?,If the variable name was `respBuf` it would be more clear that it will be a `bytes.Buffer` and not a `string`.
+9125,"@@ -8,8 +8,13 @@ describe ""videos/_access_callout"" do
+
+         render_callout video, signed_out: true
+
+-        expect(rendered).to have_css "".access-callout.auth-to-access""
+-        expect(rendered).to have_auth_to_access_link_for(video)
++        expect(rendered).to have_content(
++          I18n.t(""videos.show.auth_to_access_callout_text"")
++        )
++        expect(rendered).to have_link(
++          I18n.t(""videos.show.auth_to_access_button_text""),
++          href: video_auth_to_access_path(video),
++        )
+       end
+     end
+ ",Put a comma after the last parameter of a multiline method call.,There are a couple of missing `have_content` calls in the test suite
+9126,"@@ -71,8 +71,18 @@ func populateScratchBucketGcsPath(scratchBucketGcsPath *string, zone string, mgc
+ 		if err != nil {
+ 			return """", daisy.Errf(""invalid scratch bucket GCS path %v"", scratchBucketGcsPath)
+ 		}
++
+ 		if !scratchBucketCreator.IsBucketInProject(*project, scratchBucketName) {
+-			return """", daisy.Errf(""Scratch bucket `%v` is not in project `%v`"", scratchBucketName, *project)
++			err := storageClient.DeleteGcsPath(*scratchBucketGcsPath)
++			var deletionResults string
++			if err == nil {
++				deletionResults = fmt.Sprintf(""The resources in %q have been deleted."", *scratchBucketGcsPath)
++			} else {
++				deletionResults = fmt.Sprintf(""Failed to delete resources in %q. Check with the owner of %q for more information"",
++					*scratchBucketGcsPath, scratchBucketName)
++			}
++			return """", daisy.Errf(""Scratch bucket %q is not in project %q. %s"",
++				scratchBucketName, *project, deletionResults)
+ 		}
+
+ 		scratchBucketAttrs, err := storageClient.GetBucketAttrs(scratchBucketName)","This will delete the whole bucket, which could have unforseen consequences in normal use cases. We should be deleting args.SourceFile instead.","If there is an error here that already exists, do we want to delete it?"
+9127,"@@ -721,5 +721,9 @@ public class Constants {
+     // Constant to allow test version to be passed as flow parameter. Passing test version will be
+     // allowed for Azkaban ADMIN role only
+     public static final String FLOW_PARAM_ALLOW_IMAGE_TEST_VERSION = ""allow.image.test.version"";
++
++    //
++    public static final String FLOW_PARAM_ALLOW_RESTART_ON_EXECUTION_STOPPED = ""allow""
++        + "".restart.on.execution.stopped"";
+   }
+ }",Lets move the whole string to next line for better readability,Can you remove this line?
+9128,"@@ -104,7 +104,7 @@ app.controller('CalendarListController', ['$scope', '$rootScope', '$window', 'Ha
+ 						$scope.subscription.newSubscriptionLocked = false;
+ 					})
+ 					.catch(function() {
+-						OC.Notification.showTemporary(t('calendar', 'Error saving WebCal-calendar'));
++						OC.Notification.showTemporary(t('calendar', 'Could not save WebCal-calendar'));
+ 						$scope.subscription.newSubscriptionLocked = false;
+ 					});
+ 			}).catch(function(reason) {",Please change this back to `Error saving WebCal-calendar` (and `Error saving WebCal-calendar` only),I think a better error message here would be something like `Could not save webCal-calendar.js`
+9129,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?,"VENDOR_COMMAND_PREFIX is now unused, I don't think it should be removed."
+9130,"@@ -3,14 +3,18 @@ using Datadog.Trace.Logging;
+ using Datadog.Trace.Logging.LogProviders;
+ using NLog;
+ using NLog.Config;
++using NLog.Layouts;
+ using NLog.Targets;
+ using Xunit;
+
+ namespace Datadog.Trace.Tests.Logging
+ {
+     [Collection(nameof(Datadog.Trace.Tests.Logging))]
++    [TestCaseOrderer(""Datadog.Trace.TestHelpers.AlphabeticalOrderer"", ""Datadog.Trace.TestHelpers"")]
+     public class NLogLogProviderTests
+     {
++        private const string ExpectedStringFormat = ""\""{0}\"": \""{1}\"""";
++
+         private readonly ILogProvider _logProvider;
+         private readonly ILog _logger;
+         private readonly MemoryTarget _target;","Not ideal, but I used a test case orderer so I could avoid a bug that occurs when running two tracer's sequentially with different DD_LOGS_INJECTION settings.",How is this different from what's in the original?
+9131,"@@ -129,6 +129,13 @@ func (p *Packer) Size() uint {
+ 	return p.bytes
+ }
+
++// HeaderFull returns true if the pack header is at maximum capacity.
++func (p *Packer) HeaderFull() bool {
++	p.m.Lock()
++	defer p.m.Unlock()
++	return EntrySize+crypto.Extension+(uint(headerLengthSize)*uint(len(p.blobs)-1)) <= uint(maxHeaderSize)
++}
++
+ // Count returns the number of blobs in this packer.
+ func (p *Packer) Count() int {
+ 	p.m.Lock()","I think the condition should be ` uint(headerLengthSize) + crypto.Extension + (len(p.blobs)+1)*uint(EntrySize) > uint(maxHeaderSize)` `headerLengthSize` is only the length field. But the pack header also includes the blob type and its ID. And the result of the check, currently seems to be inverted.",Some of the tests in `packer_test.go` seem to fail if `maxHeaderSize` is more than `headerLengt
+9132,"@@ -19,7 +19,6 @@ namespace Nethermind.Mev.Test
+ {
+     public enum SelectorType
+     {
+-        V1,
+         V2,
+     }
+ }",Remove selector if only 1 version is supported,Was this a bug?
+9133,"@@ -1188,7 +1188,7 @@ class Application extends BaseApplication {
+ 		const selectedNoteIds = state.selectedNoteIds;
+ 		const note = selectedNoteIds.length === 1 ? await Note.load(selectedNoteIds[0]) : null;
+
+-		for (const itemId of ['copy', 'paste', 'cut', 'selectAll', 'bold', 'italic', 'link', 'code', 'insertDateTime', 'commandStartExternalEditing', 'showLocalSearch']) {
++		for (const itemId of ['paste', 'cut', 'bold', 'italic', 'link', 'code', 'insertDateTime']) {
+ 			const menuItem = Menu.getApplicationMenu().getMenuItemById(`edit:${itemId}`);
+ 			if (!menuItem) continue;
+ 			const isHtmlNote = !!note && note.markup_language === MarkupToHtml.MARKUP_LANGUAGE_HTML;",Why did you remove more than the asked command?,Please don't re
+9134,"@@ -320,11 +320,15 @@ func (s *session) handlePacketImpl(p *receivedPacket) error {
+ 		s.largestRcvdPacketNumber,
+ 		hdr.PacketNumber,
+ 	)
+-	if utils.Debug() {
+-		utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, time.Now().Format(""15:04:05.000""))
+-	}
+
+ 	packet, err := s.unpacker.Unpack(hdr.Raw, hdr, data)
++	if utils.Debug() {
++		if err != nil {
++			utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, time.Now().Format(""15:04:05.000""))
++		} else {
++			utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x, %s @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, packet.encryptionLevel, time.Now().Format(""15:04:05.000""))
++		}
++	}
+ 	// if the decryption failed, this might be a packet sent by an attacker
+ 	// don't update the remote address
+ 	if quicErr, ok := err.(*qerr.QuicError); ok && quicErr.ErrorCode == qerr.DecryptionFailure {","I just realized that we are logging time now - we shouldn't do that here, that's the logger's job. I've opened a new issue for that #444.",Would it make s
+9135,"@@ -44,13 +44,13 @@ const char *MolHolderBaseDoc =
+     ""The API is quite simple: \n""
+     ""  AddMol(mol) -> adds a molecule to the molecule holder, returns index of ""
+     ""molecule\n""
+-    ""  GetMol(idx) -> return the molecule at index idx\n"";
++    ""  GetMol(idx,sanitize=True) -> return the molecule at index idx\n"";
+
+ const char *MolHolderDoc =
+     ""Holds raw in-memory molecules\n""
+     ""  AddMol(mol) -> adds a molecule to the molecule holder, returns index of ""
+     ""molecule\n""
+-    ""  GetMol(idx) -> return the molecule at index idx\n"";
++    ""  GetMol(idx,sanitize=True) -> return the molecule at index idx\n"";
+
+ const char *CachedMolHolderDoc =
+     ""Holds molecules in their binary representation.\n""",why is the `sanitize=True` here in the docs?,Maybe this shou
+9136,"@@ -9,6 +9,9 @@ class Approval < ActiveRecord::Base
+   end
+
+   belongs_to :proposal
++  belongs_to :user
++  has_many :delegations, through: :user, source: :outgoing_delegates
++  has_many :delegates, through: :delegations, source: :assignee
+   acts_as_list scope: :proposal
+
+   belongs_to :parent, class_name: 'Approval'","Didn't end up using this, but I think it's useful anyway.",Why not `has_many :reactions`?
+9137,"@@ -121,7 +121,16 @@ namespace Microsoft.DotNet.Build.Tasks
+                 // Every test project comes with 4 of them, so not producing a warning here.
+                 else if (!string.IsNullOrEmpty(relativePath))
+                 {
+-                    copyCommands.AppendLine($""call :copyandcheck \""%PACKAGE_DIR%\\{relativePath}\"" \""%EXECUTION_DIR%\\{Path.GetFileName(relativePath)}\"" ||  exit /b -1"");
++                    bool? preserveSubDirectories = dependency.GetMetadata(""PreserveSubDirectories"")?.Equals(""true"", StringComparison.OrdinalIgnoreCase);
++                    string filePath = Path.GetFileName(relativePath);
++                    if (preserveSubDirectories == true)
++                    {
++                        //This is to remove the first two directories on the path which will always be the dependency followed by the version used
++                        int indexOfSubDirectories = relativePath.IndexOf(""\\"", relativePath.IndexOf(""\\"")+1);
++                        filePath = relativePath.Substring(indexOfSubDirectories);
++                        copyCommands.AppendLine($""call :makedir \""%EXECUTION_DIR%{Path.GetDirectoryName(filePath)}\"" ||  exit /b -1"");
++                    }
++                    copyCommands.AppendLine($""call :copyandcheck \""%PACKAGE_DIR%\\{relativePath}\"" \""%EXECUTION_DIR%\\{filePath}\"" ||  exit /b -1"");
+                 }
+             }
+             cmdExecutionTemplate = cmdExecutionTemplate.Replace(""[[CopyFilesCommands]]"", copyCommands.ToString());",I'm pretty sure there's already a metadata item that contains what you're calculating here (PackageRelativePath)?,You should use `String#IndexOf
+9138,"@@ -79,6 +79,15 @@ module ProjectsHelper
+     end
+   end
+
++  def browse_security_button(project)
++    css_class = project.uuid.blank? ? 'disabled' : 'btn-primary'
++    project_name = CGI.escape(project.name)
++    url = ENV['OH_SECURITY_URL'] + ""/#{project_name}/#{project.uuid}?project_id=#{project.id}""
++    haml_tag :a, href: url, class: ""btn #{css_class}"", target: '_blank' do
++      concat t('projects.browse_security')
++    end
++  end
++
+   private
+
+   def project_twitter_description_analysis(project, analysis)",We want to show this button only when there is a page for us to connect to. There is no reason to put the Browse Security Info button on the page at all unless we've identified the UUID from the KB.,Layout/EmptyLinesAroundClassBo
+9139,"@@ -42,10 +42,14 @@
+ #include ""res/windowsicon.xpm""
+ #include ""res/macosicon.xpm""
+ #include ""res/linuxicon.xpm""
++#include ""res/androidicon.xpm""
+ #include ""res/freebsdicon.xpm""
++#include ""res/linuxarmicon2.xpm""
+ #include ""res/atiicon.xpm""
++#include ""res/amdicon2.xpm""
+ #include ""res/nvidiaicon.xpm""
+-#include ""res/androidicon.xpm""
++#include ""res/nvidiaicon2.xpm""
++#include ""res/intelgpuicon2.xpm""
+ #include ""res/virtualboxicon.xpm""
+ #include ""res/blankicon.xpm""
+ ",Why `2` in this and others?,How is this related to the res
+9140,"@@ -118,6 +118,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting
+             var testHostProcessName = (this.architecture == Architecture.X86) ? X86TestHostProcessName : X64TestHostProcessName;
+             var currentWorkingDirectory = Path.GetDirectoryName(typeof(DefaultTestHostManager).GetTypeInfo().Assembly.Location);
+             var argumentsString = "" "" + Constants.PortOption + "" "" + connectionInfo.Port;
++            argumentsString += "" "" + Constants.ParentProcessIdOption + "" "" + processHelper.GetCurrentProcessId();
+
+             var testhostProcessPath = Path.Combine(currentWorkingDirectory, testHostProcessName);
+ ","This may cause a new allocation, please consider merging the concat in above line. Same applies to change in dotnethostmanager.",I don't think you need to add `processHelper.GetCurrentProcessId()` here. It should already be added by `ProcessHelper.GetCurrentProcessId()`
+9141,"@@ -490,6 +490,16 @@ given file (report RP0402 must not be disabled)'}
+                 importedname = node.modname
+             else:
+                 importedname = node.names[0][0].split('.')[0]
++        if isinstance(node, astroid.ImportFrom) and \
++                node.as_string().startswith('from .'):
++            # We need the impotedname with first point to detect local package
++            # Example of node:
++            #  'from .my_package1 import MyClass1'
++            #  the output should be '.my_package1' instead of 'my_package1'
++            # Example of node:
++            #  'from . import my_package2'
++            #  the output should be '.my_package2' instead of '{pyfile}'
++            importedname = '.' + importedname
+         self._imports_stack.append((node, importedname))
+
+     @staticmethod","Alternatively (and better) would be to look for the .level attribute of the node. If it's bigger or equal to 1, than that is a relative import. So ""from . import x"" should have level 1, while ""from .. import z"" should have level 2 and so on. The same should happen for ""from .c import z"".","This is a bit confusing. If you are saying ""we need the impotedname with first point to detect local package"" you are saying ""we need the imp"
+9142,"@@ -25,4 +25,14 @@ public abstract class AbstractASTXPathHandler implements XPathHandler {
+     public void initialize(IndependentContext context, Language language, Class<?> functionsClass) {
+         context.declareNamespace(""pmd-"" + language.getTerseName(), ""java:"" + functionsClass.getName());
+     }
++
++    @Override
++    public void initialize() {
++        // override if needed
++    }
++
++    @Override
++    public void initialize(IndependentContext context) {
++        // override if needed
++    }
+ }","Btw. this API must definitely change with PMD 7 - we are exposing here a implementation detail (that we use Saxon). And it happens, that the way, how custom functions are registered, changed with Saxon 9.5... which makes the need for a implementation agnostic API relevant...",missing annotation on `@Override`
+9143,"@@ -44,6 +44,8 @@ type GenericDeploymentSpec struct {
+ 	Timeout Duration `json:""timeout,omitempty"" default:""6h""`
+ 	// List of encrypted secrets and targets that should be decoded before using.
+ 	Encryption *SecretEncryption `json:""encryption""`
++	// Notification to be sent to users via Slack or email
++	Notification *Notification `json:""notification""`
+ }
+
+ type DeploymentPlanner struct {",nit: `Additional configuration used while sending notification to external services.`,doesn't this need a `omitempty` too?
+9144,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",Should this be `nameOrHandle`?
+9145,"@@ -247,7 +247,7 @@ describe 'LinksControllerTest' do
+
+     get :new, project_id: project.url_name, category_id: category_id
+     assigns(:category_name).must_equal 'Homepage'
+-    assigns(:link).title.must_equal :Homepage
++    assigns(:link).title.must_equal 'Homepage'
+   end
+
+   it 'load_category_and_title_for_new_download_link' do",This should have failed before.,Line is too long. [98/80]
+9146,"@@ -0,0 +1,19 @@
++package paymentchannel
++
++import (
++	""github.com/filecoin-project/go-address""
++	""github.com/filecoin-project/specs-actors/actors/builtin/paych""
++)
++
++// ChannelInfo is the primary payment channel record
++type ChannelInfo struct {
++	Owner    address.Address // Payout (From) address for this channel, has ability to sign and send funds
++	State    *paych.State
++	Vouchers []*VoucherInfo // All vouchers submitted for this channel
++}
++
++// Voucher Info is a record of a voucher submitted for a payment channel
++type VoucherInfo struct {
++	Voucher *paych.SignedVoucher
++	Proof   []byte
++}",the paymentchannel dir is where the paymentchannel manager will live. it will store the types below.,Is it necessary to export thes
+9147,"@@ -219,7 +219,9 @@ webdriver.CommandName = {
+   GET_SESSION_LOGS: 'getSessionLogs',
+
+   // Non-standard commands used by the standalone Selenium server.
+-  UPLOAD_FILE: 'uploadFile'
++  UPLOAD_FILE: 'uploadFile',
++
++  GET_CANVAS_URL: 'getCanvasUrl'
+ };
+
+ ",This is Safari specific and should be defined somewhere in the `safaridriver` namespace,Rename to `GET_CANVAS_URL`
+9148,"@@ -58,13 +58,13 @@ func TestNewRound(t *testing.T) {
+ 	require := require.New(t)
+ 	bc, roll := makeChain(t)
+ 	rc := &roundCalculator{bc, true, roll, bc.CandidatesByHeight, 0}
+-	proposer, err := rc.calculateProposer(5, 1, []string{""1"", ""2"", ""3"", ""4"", ""5""})
++	_, err := rc.calculateProposer(5, 1, []string{""1"", ""2"", ""3"", ""4"", ""5""})
+ 	require.Error(err)
+ 	var validDelegates [24]string
+ 	for i := 0; i < 24; i++ {
+ 		validDelegates[i] = identityset.Address(i).String()
+ 	}
+-	proposer, err = rc.calculateProposer(5, 1, validDelegates[:])
++	proposer, err := rc.calculateProposer(5, 1, validDelegates[:])
+ 	require.NoError(err)
+ 	require.Equal(validDelegates[6], proposer)
+ ",assignments should only be cuddled with other assignments (from `wsl`),Shouldn't we check for the error here?
+9149,"@@ -641,12 +641,13 @@ Blockly.genUid.soup_ = '!#%()*+,-./:;=?@[]^_`{|}~' +
+  * Measure some text using a canvas in-memory.
+  * @param {string} fontSize E.g., '10pt'
+  * @param {string} fontFamily E.g., 'Arial'
++ * @param {string} fontWeight E.g., '600'
+  * @param {string} text The actual text to measure
+  * @return {number} Width of the text in px.
+  */
+-Blockly.measureText = function(fontSize, fontFamily, text) {
++Blockly.measureText = function(fontSize, fontFamily, fontWeight, text) {
+   var canvas = document.createElement('canvas');
+   var context = canvas.getContext('2d');
+-  context.font = fontSize + fontFamily;
++  context.font = fontWeight + ' ' + fontSize + ' ' + fontFamily;
+   return context.measureText(text).width;
+ };","prefer changing the signature by adding params to the end, not the middle, I think.",I think this should be `fontSize + ' '
+9150,"@@ -301,6 +301,15 @@ func makeStatefulSetService(p *monitoringv1.Prometheus, config Config) *v1.Servi
+ 			},
+ 		},
+ 	}
++
++	if p.Spec.Thanos != nil {
++		svc.Spec.Ports = append(svc.Spec.Ports, v1.ServicePort{
++			Name:       ""grpc"",
++			Port:       10901,
++			TargetPort: intstr.FromString(""grpc""),
++		})
++	}
++
+ 	return svc
+ }
+ ",I guess we aim for hardcoded port for Prometheus operated ports right?,Is there a test we can write for this?
+9151,"@@ -602,8 +602,10 @@ class FormatChecker(BaseTokenChecker):
+             isinstance(node.parent, nodes.TryFinally) and node in node.parent.finalbody
+         ):
+             prev_line = node.parent.body[0].tolineno + 1
++        elif isinstance(node.parent, nodes.Module):
++            prev_line = 0
+         else:
+-            prev_line = node.parent.statement().fromlineno
++            prev_line = node.parent.statement(future=True).fromlineno
+         line = node.fromlineno
+         assert line, node
+         if prev_line == line and self._visited_lines.get(line) != 2:",This is the same effect as doing `node.parent.fromlineno` but avoids the `StatementMissing` exception from calling `statement`.,"Ah sorry for nit-picking, but can you "
+9152,"@@ -165,12 +165,15 @@ def request_candidate_sets(days, top, similar):
+ @cli.command(name='request_recommendations')
+ @click.option(""--top"", type=int, default=200, help=""Generate given number of top artist recommendations"")
+ @click.option(""--similar"", type=int, default=200, help=""Generate given number of similar artist recommendations"")
+-def request_recommendations(top, similar):
++@click.option(""--mb_id"", callback=parse_list, default=[], multiple=True, help=""Generate recommendations for given users"" \
++              "" Generate recommendation for all users by default."")
++def request_recommendations(top, similar, mb_id):
+     """""" Send the cluster a request to generate recommendations.
+     """"""
+     params = {
+         'recommendation_top_artist_limit': top,
+         'recommendation_similar_artist_limit': similar,
++        'musicbrainz_id': mb_id
+     }
+     send_request_to_spark_cluster(_prepare_query_message('cf_recording.recommendations.recommend', params=params))
+ ","I think user-ids might be better; also note that options should use - and not _ to separate words. Also, how are more than one id specified? comma seperated? I think the usage statement should indicate this.",Please update the help message with the new parameter
+9153,"@@ -117,14 +117,7 @@ func nanosecondsToTicks(ns int64) timeUnit {
+
+ // sleepTicks should sleep for specific number of microseconds.
+ func sleepTicks(d timeUnit) {
+-	for d != 0 {
+-		ticks()            // update timestamp
+-		ticks := uint32(d) // current scaling only supports 100 usec to 6553 msec
+-		if !timerSleep(ticks) {
+-			return
+-		}
+-		d -= timeUnit(ticks)
+-	}
++	timerSleep(uint32(d))
+ }
+
+ // number of ticks (microseconds) since start.",This code is necessary. It makes sure that you can sleep for longer durations than the timer supports.,The original code is correct. It only does a single c
+9154,"@@ -96,7 +96,7 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> {
+    * @param executorService an executor service to parallelize tasks to delete manifests and data files
+    * @return this for method chaining
+    */
+-  ExpireSnapshots executeWith(ExecutorService executorService);
++  ExpireSnapshots executeDeleteWith(ExecutorService executorService);
+
+   /**
+    * Allows expiration of snapshots without any cleanup of underlying manifest or data files.",Can we add the new name in parallel and deprecate this name? We should be careful about changes to the public API and give people at least a release to switch over before removing public methods.,Why is this necessary?
+9155,"@@ -32,8 +32,10 @@ bool wlr_backend_start(struct wlr_backend *backend) {
+ }
+
+ void wlr_backend_destroy(struct wlr_backend *backend) {
+-	if (backend->impl->destroy) {
++	if (backend->impl && backend->impl->destroy) {
+ 		backend->impl->destroy(backend);
++	} else {
++		free(backend);
+ 	}
+ }
+ ",If you're going to start testing that impl itself is not NULL you should probably be doing it everywhere.,Why not just `free(backend)`? We really need to imple
+9156,"@@ -159,7 +159,7 @@ func ParseFromStructuredObject(s interface{}) (Manifest, error) {
+ 	}, nil
+ }
+
+-func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string) ([]Manifest, error) {
++func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string, configFileName string) ([]Manifest, error) {
+ 	// If no name was specified we have to walk the app directory to collect the manifest list.
+ 	if len(names) == 0 {
+ 		err := filepath.Walk(dir, func(path string, f os.FileInfo, err error) error {",`ctx` is unused in LoadPlainYAMLManifests,"`configFileName` is unused now, right? Please remove?"
+9157,"@@ -87,7 +87,7 @@ public class BlockHeaderBuilder {
+   }
+
+   public static BlockHeaderBuilder fromBuilder(final BlockHeaderBuilder fromBuilder) {
+-    BlockHeaderBuilder toBuilder =
++    final BlockHeaderBuilder toBuilder =
+         create()
+             .parentHash(fromBuilder.parentHash)
+             .ommersHash(fromBuilder.ommersHash)",why is this called toBuilder when the method is called fromBuilder? (I realise you did not change this...),Since you're in here anyway: Why not `BlockHeaderBuil
+9158,"@@ -40,4 +40,10 @@ public class FlinkConfigOptions {
+           .intType()
+           .defaultValue(100)
+           .withDescription(""Sets max infer parallelism for source operator."");
++
++  public static final ConfigOption<Integer> SOURCE_READER_FETCH_BATCH_SIZE = ConfigOptions
++      .key(""source.iceberg.reader.fetch-batch-size"")
++      .intType()
++      .defaultValue(2048)
++      .withDescription(""The target batch size for split reader fetch."");
+ }",nit: seems rather large.,why do we default to2048 here?
+9159,"@@ -119,7 +119,7 @@ def get_listens(user_name):
+     latest_listen = db_conn.fetch_listens(
+         user_name,
+         limit=1,
+-        to_ts=max_ts,
++        to_ts=int(time.time()),
+     )
+     latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 else 0
+ ",I think it'd make sense to only calculate time.time() once (it's also used if max_ts and min_ts aren't set),Should we leave `max_ts` as it was before?
+9160,"@@ -53,6 +53,8 @@ public abstract class TestCaseView {
+
+   public abstract GrpcStreamingType grpcStreamingType();
+
++  public abstract String grpcStubTypeName();
++
+   public abstract String mockGrpcStubTypeName();
+
+   public abstract String createStubFunctionName();",Use existing `grpcStubCallString` instead,Remove this line.
+9161,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace
++{
++    internal static class TraceConstants
++    {
++        public const ulong MaxTraceId = 9_223_372_036_854_775_807; // 2^63-1
++    }
++}","In a recent PR, Bob added a `TracerConstants` class. Do you think this makes sense to put in that class instead so that we can consolidate?",Should this be in
+9162,"@@ -73,6 +73,10 @@ type Service struct {
+ 	auth            BlockAuthenticator
+ 	parallelBlocks  uint64
+ 	deadlineTimeout time.Duration
++	// catchpointWriting defines whether we've ran into a state where the ledger is currently busy writing the
++	// catchpoint file. If so, we want to pospone all the catchup process until the catchpoint file writing is complete,
++	// and resume from there without stopping the catchup timer.
++	catchpointWriting bool
+
+ 	// The channel gets closed when the initial sync is complete. This allows for other services to avoid
+ 	// the overhead of starting prematurely (before this node is caught-up and can validate messages for example).","I want to propose couple of different names for catchpointWriting: syncInterruptedWaitingCatchpointWriting syncWaitingForCatchpointWriting catchpointWriting is lacking context, and I found it difficult to understand the logic without this context.","nit: ""the ledger "
+9163,"@@ -92,7 +92,7 @@ class InventoryImporter(object):
+
+         Args:
+             session (object): Database session.
+-            model (str): Model name to create.
++            model (Model): Model name to create.
+             dao (object): Data Access Object from dao.py
+             service_config (ServiceConfig): Service configuration.
+             inventory_id (str): Inventory id to import from","Do you still need the `name` in the arg description, if this is not `str` type anymore.?",why did you chang
+9164,"@@ -42,15 +42,5 @@ def allreduce_grads(params, coalesce=True, bucket_size_mb=-1):
+
+
+ class DistOptimizerHook(OptimizerHook):
+-
+-    def __init__(self, grad_clip=None, coalesce=True, bucket_size_mb=-1):
+-        self.grad_clip = grad_clip
+-        self.coalesce = coalesce
+-        self.bucket_size_mb = bucket_size_mb
+-
+-    def after_train_iter(self, runner):
+-        runner.optimizer.zero_grad()
+-        runner.outputs['loss'].backward()
+-        if self.grad_clip is not None:
+-            self.clip_grads(runner.model.parameters())
+-        runner.optimizer.step()
++    """"""Deprecated optimizer hook for distributed training""""""
++    pass",We may raise a warning.,Can we just delete this class?
+9165,"@@ -2,8 +2,10 @@ import AbstractModel from 'hospitalrun/models/abstract';
+ import DS from 'ember-data';
+
+ export default AbstractModel.extend({
+-  patient: DS.belongsTo('patient'),
++  // Attributes
+   name: DS.attr('string'),
+   icd9CMCode: DS.attr('string'),
+-  icd10Code: DS.attr('string')
++  icd10Code: DS.attr('string'),
++  // Associations
++  patient: DS.belongsTo('patient'),
+ });",Trailing comma caused the eslint test to fail,"please remove this, thanks!"
+9166,"@@ -0,0 +1,6 @@
++from werkzeug.utils import import_string
++
++from .config import CFG_RELATIONSHIPS_NODE_ENGINE, CFG_RELATIONSHIPS_EDGE_ENGINE
++
++Node = import_string(CFG_RELATIONSHIPS_NODE_ENGINE)
++Edge = import_string(CFG_RELATIONSHIPS_EDGE_ENGINE)","I think you should use `app.config`. In the usual case, the config file is not overwritten, there is additional config file outside of the source of `Invenio`.",I would prefer we don't import
+9167,"@@ -86,6 +86,16 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat
+ 				new TrustedIssuerJwtAuthenticationManagerResolver(
+ 						Collections.unmodifiableCollection(trustedIssuers)::contains));
+ 	}
++
++	/**
++     * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided
++     * parameters
++     * @param trustedIssuer a predicate to determine whether the issuer should be trusted or not
++     */
++    public JwtIssuerAuthenticationManagerResolver(Predicate<String> trustedIssuer) {
++        this.authenticationManager = new ResolvingAuthenticationManager(
++                new TrustedIssuerJwtAuthenticationManagerResolver(trustedIssuer));
++    }
+
+ 	/**
+ 	 * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided",Will you please update the copyright message to now include `2021`?,`trustedIssuer` -> `trustedIss
+9168,"@@ -38,8 +38,8 @@ void test_rw(const Offsets &offsets, const Data &data)
+
+     for (std::size_t index = 0; index < offsets.size() - 1; ++index)
+     {
+-        typename IndexedData::ResultType expected_result(&data[offsets[index]],
+-                                                         &data[offsets[index + 1]]);
++        typename IndexedData::ResultType expected_result(data.begin() + offsets[index],
++                                                         data.begin() + offsets[index + 1]);
+         BOOST_CHECK_EQUAL(expected_result, indexed_data.at(index));
+     }
+ }",Potential subscript out of range.,This is much easier to read than the previous code (which surprised me).
+9169,"@@ -185,7 +185,6 @@ func (ps *peerSelector) PeerDownloadDurationToRank(peer network.Peer, blockDownl
+ 	default: // i.e. peerRankInitialFourthPriority
+ 		return downloadDurationToRank(blockDownloadDuration, lowBlockDownloadThreshold, highBlockDownloadThreshold, peerRank3LowBlockTime, peerRank3HighBlockTime)
+
+-
+ 	}
+ }
+ ","please undo this change. you didn't really meant to make it, right ?",why remove this line?
+9170,"@@ -0,0 +1,13 @@
++import initStoryshots from '@storybook/addon-storyshots';
++import { puppeteerTest } from '@storybook/addon-storyshots-puppeteer';
++import path from 'path';
++
++initStoryshots( {
++	suite: 'Puppeteer storyshots',
++	test: puppeteerTest( {
++		// eslint-disable-next-line sitekit/acronym-case
++		storybookUrl: `file://${ path.resolve( __dirname, '../dist' ) }`,
++		setupTimeout: 5000,
++		testTimeout: 5000,
++	} ),
++} );",To check! are these millseconds or seconds :thinking: The docs aren't clear,Does this need to be in a `initStoryshots` function? It looks like it co
+9171,"@@ -508,6 +508,7 @@ func (u *multiuploader) upload(firstBuf io.ReadSeeker) (*UploadOutput, error) {
+
+ 	// Read and queue the rest of the parts
+ 	for u.geterr() == nil {
++		num++
+ 		// This upload exceeded maximum number of supported parts, error now.
+ 		if num > int64(u.ctx.MaxUploadParts) || num > int64(MaxUploadParts) {
+ 			var msg string",Why was this moved?,Need to increment `num` in the `if` below.
+9172,"@@ -15,6 +15,10 @@ limitations under the License.
+ */
+ package v1alpha1
+
++type CStorPoolExpansion interface{}
++
++type CStorVolumeReplicaExpansion interface{}
++
+ type StoragePoolExpansion interface{}
+
+ type StoragePoolClaimExpansion interface{}",What are these object with suffix Expansion?,Do we need this expansion? Could we just use `StoragePoolClaimExpansion`?
+9173,"@@ -831,6 +831,13 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       arity = ""1"")
+   private final Wei txFeeCap = DEFAULT_RPC_TX_FEE_CAP;
+
++  @Option(
++      names = {""--rpc-allow-unprotected-txs""},
++      description =
++          ""Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"",
++      arity = ""1"")
++  private final Boolean unprotectedTransactionsAllowed = false;
++
+   @Option(
+       names = {""--min-block-occupancy-ratio""},
+       description = ""Minimum occupancy ratio for a mined block (default: ${DEFAULT-VALUE})"",","This breaks backwards compatibility, so it will have to wait for the next quarterly release of the default is to deny. I would recommend adding the flag with the default to allow and then at the next quarterly release rc cycle flip the flag to deny.","instead of creating a new flag, shall we use the existing `--rpc-allow-un"
+9174,"@@ -57,12 +57,12 @@
+ // league_size) is not limited by physical constraints. Its a pure logical
+ // number.
+
+-typedef Kokkos::TeamPolicy<> team_policy;
+-typedef team_policy::member_type team_member;
++using team_policy = Kokkos::TeamPolicy<>;
++using team_member = team_policy::member_type;
+
+ // Define a functor which can be launched using the TeamPolicy
+ struct hello_world {
+-  typedef int value_type;  // Specify value type for reduction target, sum
++  using value_type = int;  // Specify value type for reduction target, sum
+
+   // This is a reduction operator which now takes as first argument the
+   // TeamPolicy member_type. Every member of the team contributes to the",I'm kind of surprised this doesn't require `typename`?,These `typedef`s don't exist anymore?
+9175,"@@ -38,8 +38,7 @@ GLIB_TESTS
+
+ AC_CHECK_HEADER([sys/xattr.h],,[AC_MSG_ERROR([You must have sys/xattr.h from glibc])])
+
+-AC_CHECK_PROGS(YACC, 'bison -y', :)
+-AS_IF([test ""$YACC"" = :], [AC_MSG_ERROR([bison not found but required])])
++AS_IF([test ""$YACC"" != ""bison -y""], [AC_MSG_ERROR([bison not found but required])])
+
+ PKG_PROG_PKG_CONFIG
+ ","I think this will break the case (you can try even with /usr/bin/bison as value): `YACC=""/path/to/bison -y"" ./configure` I wonder if we should use AC_PROG_YACC at all or simply use AC_CHECK_PROGS since we want to use bison and not another yacc",I'm not sure this change is what we want. The problem here is that `PKG_P
+9176,"@@ -66,8 +66,14 @@ namespace Nethermind.KeyStore.Config
+         [ConfigItem(Description = ""Plain private key to be used in test scenarios"")]
+         string TestNodeKey { get; set; }
+
+-        [ConfigItem(Description = ""Account to be used by the block author / coinbase"")]
++        [ConfigItem(Description = ""Account to be used by the block author / coinbase, to be loaded from keystore"")]
+         string BlockAuthorAccount { get; set; }
++
++        [ConfigItem(Description = ""Account to be used by the node for network communication (enode), to be loaded from keystore"")]
++        string EnodeAccount { get; set; }
++
++        [ConfigItem(Description = ""Path to key file to be used by the node for network communication (enode)"")]
++        string EnodeKeyFile { get; set; }
+
+         [ConfigItem(Description = ""Passwords to use to unlock accounts from the UnlockAccounts configuration item. Only used when no PasswordFiles provided."", DefaultValue = ""System.String[]"")]
+         string[] Passwords { get; set; }",can we explain to users in the docs what happens if they leave the field blank?,"`Account to be used by the node for network communication (enode)` => `Account to be used by the node for network communication (enode), to be loaded from keystore`"
+9177,"@@ -442,10 +442,10 @@ class EC2Connection(AWSQueryConnection):
+                              [('item', Reservation)], verb='POST')
+
+     def run_instances(self, image_id, min_count=1, max_count=1,
+-                      key_name=None, security_groups=None,
+-                      user_data=None, addressing_type=None,
+-                      instance_type='m1.small', placement=None,
+-                      kernel_id=None, ramdisk_id=None,
++                      key_name=None, security_group_ids=None,
++                      security_groups=None, user_data=None,
++                      addressing_type=None, instance_type='m1.small',
++                      placement=None, kernel_id=None, ramdisk_id=None,
+                       monitoring_enabled=False, subnet_id=None,
+                       block_device_map=None,
+                       disable_api_termination=False,",We try not to change the function footprints unless absolutely necessary. Why is it necessary to have both secuirty_group_ids and security_groups?,why make this change?
+9178,"@@ -105,7 +105,7 @@ public class JavaSourceFolderProvider implements SourceFolderProvider {
+     if (Strings.isNullOrEmpty(relativePath)) {
+       return parentPackagePrefix;
+     }
+-    relativePath = relativePath.replaceAll(File.separator, ""."");
++    relativePath = relativePath.replace(File.separator, ""."");
+     return Strings.isNullOrEmpty(parentPackagePrefix)
+         ? relativePath
+         : parentPackagePrefix + ""."" + relativePath;","Thanks! We're already replacing File.separatorChar with '/' in the call to FileUtil#toCanonicalPath above, so the correct fix here should be: `relativePath.replace('/', '.')` I'll make the change upstream.",Revert changes to this file.
+9179,"@@ -2,8 +2,8 @@
+
+ namespace Shopsys\FrameworkBundle\Model\Product\Exception;
+
+-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
++use Symfony\Component\HttpKernel\Exception\GoneHttpException;
+
+-class ProductNotFoundException extends NotFoundHttpException implements ProductException
++class ProductNotFoundException extends GoneHttpException implements ProductException
+ {
+ }","It could be nice to be explicit about this change in upgrade notes, what do you think?",This should be `GoneHttpException`
+9180,"@@ -27,7 +27,7 @@ function logout (req, res, next) {
+       }
+
+       delete companion.providerTokens[providerName]
+-      tokenService.removeFromCookies(res, companion.options, companion.provider.authProviderName)
++      tokenService.removeFromCookies(res, companion.options, companion.provider.authProvider)
+       cleanSession()
+       res.json(Object.assign({ ok: true }, data))
+     })",spotted a bug.,Shouldn't the same be done for the `companion.provider.authProvider` variable?
+9181,"@@ -148,7 +148,7 @@ public class SmartStoreFullTextSearchSpeedTest extends SmartStoreTestCase {
+     private double queryData(Type textFieldType, int rowsPerAnimal, int matchingRowsPerAnimal) throws JSONException {
+         long totalQueryTime = 0;
+         for (String animal : ANIMALS) {
+-            String prefix = String.format(""%07d"", (int) Math.random()*matchingRowsPerAnimal);
++            String prefix = String.format(""%07d"", (int) (Math.random()*(rowsPerAnimal/matchingRowsPerAnimal)));
+             String stringToMatch = prefix + animal;
+
+             QuerySpec querySpec = textFieldType == Type.full_text",We were always using 0000000 prefix,Why not just `Math.random(rowsPerAnimal / matchingRowsPerAnimal)` ?
+9182,"@@ -306,7 +306,9 @@ void signalHandler(int sig) {
+             }
+             {
+                 auto gJobMgr = nebula::meta::JobManager::getInstance();
+-                gJobMgr->shutDown();
++                if (gJobMgr) {
++                    gJobMgr->shutDown();
++                }
+             }
+             if (gKVStore) {
+                 gKVStore->stop();",Here we also need to determine if gJobMgr has called the init function.,Why not just move it to the `teardown` function?
+9183,"@@ -0,0 +1,18 @@
++module Mongoid
++  module Matcher
++
++    # @api private
++    module All
++      module_function def matches?(exists, value, condition)
++        condition.any? && condition.all? do |c|
++          case c
++          when ::Regexp, BSON::Regexp::Raw
++            Regex.matches_array_or_scalar?(value, c)
++          else
++            EqImpl.matches?(true, value, c, '$all')
++          end
++        end
++      end
++    end
++  end
++end","Out of curiosity, why is `condition.any?` also necessary here?","end at 11, 8 is not aligned with case at 7, 16."
+9184,"@@ -12,14 +12,16 @@ namespace meta {
+
+ std::unordered_map<GraphSpaceID, std::shared_ptr<HostManager>> HostManager::hostManagers_;
+
+-
+ // static
+ std::shared_ptr<const HostManager> HostManager::get(GraphSpaceID space) {
+     auto it = hostManagers_.find(space);
+     if (it != hostManagers_.end()) {
+         return it->second;
+     } else {
+-        return std::shared_ptr<const HostManager>();
++        auto* hmPtr = new HostManager(space);
++        std::shared_ptr<HostManager> hm(hmPtr);
++        hostManagers_.emplace(space, hm);
++        return hm;
+     }
+ }
+ ","Always use `std::make_shared` whenever possible, it will save you one memory allocation.",Use `find_if` instead of `emplace` here. Aren't you going to miss the case where there is no `HostManager`?
+9185,"@@ -30,7 +30,7 @@ var DBATag = ""v0.2.0""
+ var RouterImage = ""drud/nginx-proxy"" // Note that this is overridden by make
+
+ // RouterTag defines the tag used for the router.
+-var RouterTag = ""v0.3.0"" // Note that this is overridden by make
++var RouterTag = ""router-expose"" // Note that this is overridden by make
+
+ // COMMIT is the actual committish, supplied by make
+ var COMMIT = ""COMMIT should be overridden""",Update to real tag before pull.,Is this tag actually used by make? I don't see it being used in this PR.
+9186,"@@ -73,7 +73,7 @@ public class ITZipkinHealth {
+
+     // ensure we don't track health in prometheus
+     assertThat(scrape())
+-      .doesNotContain(""health"");
++      .doesNotContain(""health_check"");
+   }
+
+   String scrape() throws InterruptedException {",Is there any better string that only exposed by prometheus? We have changed the meter tags to contain method and service name. For example `scrape()` contains `method=getHealth` and `service=server.internal.health.ITzipkinHealth` which made this test failed.  ,"The `health` key doesn't exist in the `metricbeat.json` file, is this intentional?"
+9187,"@@ -33,7 +33,7 @@ namespace Datadog.Trace.Vendors.Serilog.Core
+     /// be disposed to flush any events buffered within it. Most application
+     /// code should depend on <see cref=""ILogger""/>, not this class.
+     /// </summary>
+-    internal sealed class Logger : ILogger, ILogEventSink, IDisposable
++    internal sealed class Logger : ILogger, ILogEventSink, IDisposable, ICoreLogger
+     {
+         static readonly object[] NoPropertyValues = new object[0];
+ ",Adding ICoreLogger here lets us pull this into Core as a strategy,Why can't we use ILogEventSink instead?
+9188,"@@ -38,7 +38,7 @@ type UsageStats struct {
+
+ // ContainerMetadata contains meta-data information for a container.
+ type ContainerMetadata struct {
+-	DockerID string `json:""-""`
++	DockerID string
+ }
+
+ // StatsContainer abstracts methods to gather and aggregate utilization data for a container.",why did you change this?,Does this need to be public?
+9189,"@@ -138,9 +138,15 @@ module RSpec::Core
+       # @param colorizer [#wrap] An object to colorize the message_lines by
+       # @return [Array(String)] The example failure message colorized
+       def colorized_message_lines(colorizer = ::RSpec::Core::Formatters::ConsoleCodes)
+-        message_lines.map do |line|
+-          colorizer.wrap line, RSpec.configuration.failure_color
+-        end
++        message_lines
++          .map do |line|
++            colorizer.wrap line, :failure
++          end
++          .tap do |lines|
++            unless exception_class_name =~ /RSpec/
++              lines[1] = colorizer.wrap(exception_class_name, :failure) + "":""
++            end
++          end
+       end
+
+       # Returns the failures formatted backtrace.",This is invalid syntax on 1.8.,Layout/TrailingWhitespace: T
+9190,"@@ -408,10 +408,10 @@ M  END
+     rxn = rdChemReactions.ReactionFromSmarts('[C:1]1[O:2][N:3]1>>[C:1][O:2].[N:3]')
+     r1 = rxn.GetReactantTemplate(0)
+     sma = Chem.MolToSmarts(r1)
+-    self.assertEqual(sma, '[C:1]1-,:[O:2]-,:[N:3]-,:1')
++    self.assertEqual(sma, '[C:1]1[O:2][N:3]1')
+     p1 = rxn.GetProductTemplate(0)
+     sma = Chem.MolToSmarts(p1)
+-    self.assertEqual(sma, '[C:1]-,:[O:2]')
++    self.assertEqual(sma, '[C:1][O:2]')
+
+     p2 = rxn.GetProductTemplate(1)
+     sma = Chem.MolToSmarts(p2)","This isn't part of the PR, but I can't find in the smarts definition that ""[C][C]"" == ""[C]-,:[C]"" There is a line saying essentially not to specify undefined items (but that's a bracket versus non bracket thing).",Why did this change?
+9191,"@@ -77,14 +77,14 @@ var (
+
+ // UnsignedMessage is an exchange of information between two actors modeled
+ // as a function call.
+-// Messages are the equivalent of transactions in Ethereum.
+ type UnsignedMessage struct {
++	_    struct{}        `cbor:"",toarray""`
+ 	To   address.Address `json:""to""`
+ 	From address.Address `json:""from""`
+ 	// When receiving a message from a user account the nonce in
+ 	// the message must match the expected nonce in the from actor.
+ 	// This prevents replay attacks.
+-	CallSeqNum Uint64 `json:""callSeqNum""`
++	CallSeqNum uint64 `json:""callSeqNum""`
+
+ 	Value AttoFIL `json:""value""`
+ ",Is this required for tuple encoding? This is confusing.,Why remove this? Is it not n
+9192,"@@ -112,6 +112,7 @@ public class FlowRunnerManager implements EventListener,
+   private final ExecutorLoader executorLoader;
+   private final ProjectLoader projectLoader;
+   private final JobTypeManager jobtypeManager;
++  private final FlowPreparer flowPreparer;
+
+   private final Props azkabanProps;
+   private final File executionDirectory;",Does it need to be a member variable? It is currently only used in one method.,Can we remove the `jobtypeManager`? It's not used anymore.
+9193,"@@ -37,7 +37,7 @@ function showNewJoinGroupSelection (button, user, apiClient) {
+         console.debug('No item is currently playing.');
+     }
+
+-    apiClient.sendSyncPlayCommand(sessionId, 'ListGroups').then(function (response) {
++    apiClient.sendSyncPlayCommand('ListGroups').then(function (response) {
+         response.json().then(function (groups) {
+             var menuItems = groups.map(function (group) {
+                 return {",@MrTimscampi doesn't this need an update to apiclient?..,The `sessionId` parameter is not used in this function.
+9194,"@@ -472,7 +472,7 @@ static const byte xop_a_extra[256] = {
+  */
+ int
+ decode_sizeof(dcontext_t *dcontext, byte *start_pc,
+-              int *num_prefixes _IF_X64(uint *rip_rel_pos))
++              int *num_prefixes _IF_X86_64(uint *rip_rel_pos))
+ {
+     byte *pc = start_pc;
+     uint opc = (uint)*pc;",This is a nop: prob best for history to not change the line,"Likewise, I don't think we need to make this change."
+9195,"@@ -21,7 +21,8 @@ type TrivialTestSlasher struct {
+ 	SendCalls uint64
+ }
+
+-// Slash is a required function for storageFaultSlasher interfaces and is intended to do nothing.
++// Slash is a required function for storageFaultSlasher interfaces and does nothing but track
++// how many times it's called.
+ func (ts *TrivialTestSlasher) Slash(context.Context, *types.BlockHeight) error {
+ 	ts.SendCalls++
+ 	return nil",Can you delete this whole file now?,why do we need this change?
+9196,"@@ -24,6 +24,7 @@ type ReturnedContract struct {
+ 	Erc721Token blockchain.Erc721Token
+ 	ArrDelete   blockchain.ArrayDelete
+ 	ArrString   blockchain.ArrayString
++	ArrPassing  blockchain.ArrayPassing
+ }
+
+ // StartContracts deploys and starts fp token smart contract and stable token smart contract,erc721 token smart contract","can you combine this passing test, code, solidity binary into existing ArrDelete? the function is much similar, pushing int value into an array, and delete one item in the array",Could you change this to arrPassing ?
+9197,"@@ -340,10 +340,10 @@ public class QueueFragment extends Fragment {
+                         SortOrder sortOrder = UserPreferences.getQueueKeepSortedOrder();
+                         DBWriter.reorderQueue(sortOrder, true);
+                         if (recyclerAdapter != null) {
+-                            recyclerAdapter.setLocked(true);
++                            recyclerAdapter.setKeepSorted(true);
+                         }
+                     } else if (recyclerAdapter != null) {
+-                        recyclerAdapter.setLocked(UserPreferences.isQueueLocked());
++                        recyclerAdapter.setKeepSorted(UserPreferences.isQueueKeepSorted());
+                     }
+                     getActivity().invalidateOptionsMenu();
+                     return true;","I think that could lead to problems when setting it to not sorted again. In that case, it will not be reset. What about using one single method for the adapter (`setDragDropEnabled`)?",`UserPreferences.isQueueKeepSorted()`
+9198,"@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
+ 		return """", err
+ 	}
+
+-	if app.SiteStatus() != ""running"" {
+-		return """", errors.New(""app not running locally. Try `ddev start`"")
++	if app.SiteStatus() != platform.SiteRunning {
++		return """", errors.New(""App not running locally. Try `ddev start`"")
+ 	}
+
+ 	db, err := app.FindContainerByType(""db"")","I'd say the error should be an error, not instructions to the user. So error would be something like ""site should be running and is not""","Note that errors.New(""app not running"
+9199,"@@ -60,11 +60,12 @@ const (
+ 	// 9) Add 'ipToTask' map to state file
+ 	// 10) Add 'healthCheckType' field in 'apicontainer.Container'
+ 	// 11)
+-	//  a) Add 'PrivateDNSName' field to 'api.ENI'
+-	//  b)Remove `AppliedStatus` field form 'apicontainer.Container'
++	//   a) Add 'PrivateDNSName' field to 'api.ENI'
++	//   b)Remove `AppliedStatus` field form 'apicontainer.Container'
+ 	// 12) Deprecate 'TransitionDependencySet' and add new 'TransitionDependenciesMap' in 'apicontainer.Container'
+ 	// 13) Add 'resources' field to 'api.task.task'
+-	ECSDataVersion = 13
++	// 14) Add 'V3EndpointID' field to 'Container' struct
++	ECSDataVersion = 14
+
+ 	// ecsDataFile specifies the filename in the ECS_DATADIR
+ 	ecsDataFile = ""ecs_agent_data.json""","Are you sure `v3EndpointIDToContainerName` and `v3EndpointIDToTask` are saved in the state file, can you verify that?",Please add this to `ecs.yml` as well.
+9200,"@@ -23,6 +23,8 @@ type KeyExchangeFunction func() crypto.KeyExchange
+
+ // The CryptoSetupServer handles all things crypto for the Session
+ type cryptoSetupServer struct {
++	mutex sync.RWMutex
++
+ 	connID               protocol.ConnectionID
+ 	remoteAddr           net.Addr
+ 	scfg                 *ServerConfig","This mutex is never used. Should it be, if users can now make calls into the crypto setup?",Make this a `map[string]struct{}` and a `map[string]struct{}` for clarity.
+9201,"@@ -25,6 +25,9 @@ module Beaker
+             host.exec(Command.new(""w32tm /config /manualpeerlist:#{NTPSERVER} /syncfromflags:manual /update""))
+             host.exec(Command.new(""w32tm /resync""))
+             @logger.notify ""NTP date succeeded on #{host}""
++          elsif host['platform'].include? 'sles'
++            host.exec(Command.new(""sntp #{NTPSERVER}""))
++            @logger.notify ""NTP date succeeded on #{host}""
+           else
+             success=false
+             try = 0","Check here for sles-, and i'd prefer a regex since I don't know what an 'include' is going to do exactly. :)",this should be moved into the else branch of the if
+9202,"@@ -65,7 +65,11 @@ class QR_Window(QWidget):
+         amount_text = ''
+         if amount:
+             if currency:
+-                self.amount = Decimal(amount) / self.exchanger.exchange(1, currency) if currency else amount
++                exch = self.exchanger.exchange(1, currency)
++                if exch == None:
++                    self.amount = Decimal('0.0')
++                else:
++                    self.amount = Decimal(amount) / exch if currency else amount
+             else:
+                 self.amount = Decimal(amount)
+             self.amount = self.amount.quantize(Decimal('1.0000'))",Should this be `None` instead?,Wouldn't it be better to check `if exch is None`?
+9203,"@@ -171,7 +171,14 @@ public final class ConfigUtil {
+       }
+
+       String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(""."") + 1);
+-      source.addProperty(cseKey, source.getProperty(key));
++      if (!source.containsKey(cseKey)) {
++        source.addProperty(cseKey, source.getProperty(key));
++      } else {
++        LOGGER
++            .warn(
++                ""Key {} with an ambiguous item {} exists, please use the same prefix or will get unexpected merged value."",
++                key, cseKey);
++      }
+     }
+   }
+ ","Not sure if the warning message is enough for this time, if the configuration is wrong, java-chassis may need to stop working instead of sending out the warning message to let the admin know about it. BTW, we may need a default override policy here.",why not use source.containsKey instead?
+9204,"@@ -7,7 +7,7 @@ import (
+
+ func MustParse(args []string) []string {
+ 	parser := &Parser{
+-		After:         []string{""server"", ""agent"", ""etcd-snapshot""},
++		After:         []string{""server"", ""agent"", ""etcd-snapshot"", ""save"", ""delete"", ""list"", ""prune""},
+ 		FlagNames:     []string{""--config"", ""-c""},
+ 		EnvName:       version.ProgramUpper + ""_CONFIG_FILE"",
+ 		DefaultConfig: ""/etc/rancher/"" + version.Program + ""/config.yaml"",","I see this getting unwieldy as we add more commands with subcommands. Can we perhaps enhance it to handle subcommands properly? Perhaps something like `""etcd-snapshot:1""` which would indicate that the etcd-snapshot command may have 1 subcommand after it, and if the 1 next argument after it doesn't start with `--` then the args should be appended after that subcommand.",Why do we need to do this?
+9205,"@@ -249,13 +249,13 @@ public class ExecutionController extends EventHandler implements ExecutorManager
+   }
+
+   /**
+-   * Get all active (running, non-dispatched) flows from database. {@inheritDoc}
++   * Get all running (unfinished) flows from database. {@inheritDoc}
+    */
+   @Override
+   public List<ExecutableFlow> getRunningFlows() {
+     final ArrayList<ExecutableFlow> flows = new ArrayList<>();
+     try {
+-      getActiveFlowHelper(flows, this.executorLoader.fetchUnfinishedFlows().values());
++      getFlowsHelper(flows, this.executorLoader.fetchUnfinishedFlows().values());
+     } catch (final ExecutorManagerException e) {
+       this.logger.error(""Failed to get running flows."", e);
+     }",why returning a string instead of a list?,This name change seems unr
+9206,"@@ -3,11 +3,13 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+
++using Datadog.Trace.Configuration;
++
+ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AdoNet.Npgsql
+ {
+     internal static class NpgsqlConstants
+     {
+-        public const string SqlCommandIntegrationName = ""NpgsqlCommand"";
++        public const string SqlCommandIntegrationName = nameof(IntegrationIds.AdoNet);
+
+         internal struct NpgsqlClientData : IAdoNetClientData
+         {",Was there a reason for changing all these integration names?   Are they actually used for anything besides information in logs?,I wonder if we should make
+9207,"@@ -422,6 +422,10 @@ public class FieldInfos implements Iterable<FieldInfo> {
+       }
+     }
+
++    synchronized Set<String> getFieldNames() {
++      return Set.copyOf(nameToNumber.keySet());
++    }
++
+     synchronized void clear() {
+       numberToName.clear();
+       nameToNumber.clear();",we should not resurrect this method that we just removed,`return ImmutableSet.copyO
+9208,"@@ -837,7 +837,18 @@ class WebDriver(object):
+             del png
+         return True
+
+-    save_screenshot = get_screenshot_as_file
++    def save_screenshot(self, filename):
++        """"""
++        Gets the screenshot of the current window. Returns False if there is
++           any IOError, else returns True. Use full paths in your filename.
++
++        :Args:
++         - filename: The full path you wish to save your screenshot to.
++
++        :Usage:
++            driver.save_screenshot('/Screenshots/foo.png')
++        """"""
++        return self.get_screenshot_as_file(self, filename)
+
+     def get_screenshot_as_png(self):
+         """"""",This needs to be just return self.get_screenshot_as_file(filename),would it make sense to add `:param str filename: The full path to the file` to match the rest of the docs?
+9209,"@@ -0,0 +1,6 @@
++function isNetworkError (xhr) {
++  if (!xhr) return
++  return (xhr.readyState !== 0 && xhr.readyState !== 4) || xhr.status === 0
++}
++
++module.exports = isNetworkError",Shouldn't this return false here?,can you explain why we need this?
+9210,"@@ -92,6 +92,9 @@ type Config struct {
+ 	// Path to a directory containing the container's root filesystem.
+ 	Rootfs string `json:""rootfs""`
+
++	// Umask is the umask to use inside of the container.
++	Umask *uint32 `json:""umask""`
++
+ 	// Readonlyfs will remount the container's rootfs as readonly where only externally mounted
+ 	// bind mounts are writtable.
+ 	Readonlyfs bool `json:""readonlyfs""`",Should have json tag,Can we change this to `Umask is the umask to use inside of the container`?
+9211,"@@ -180,7 +180,7 @@ static const char *const PORT_ERROR[PORT_ERROR_COUNT] = {
+ /*
+  * errors command configuration, set during parse_args()
+  */
+-static struct errors_config {
++STATIC struct errors_config {
+ 	bool clear;
+ 	int force_count;
+ 	enum verbs_index which;",Is this needed after all? Looks like the struct was re-defined inside the test file.,This doesn't look like it's in the right place. Probably better to move it to the top of the file.
+9212,"@@ -67,4 +67,11 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files referenced by given metadata location.
++   */
++  default RemoveReachableFiles removeFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement removeFiles"");
++  }
+ }",I think the name of the method should match the name of the action: `removeReachableFiles`.,I would say : _Remove all the files referenced by given metadataLocation._
+9213,"@@ -106,6 +106,7 @@ echo ""
+     <ul>
+         <li><a href=\""manage_apps.php\"">Manage applications</a></li>
+         <li><a href=\""manage_app_versions.php\"">Manage application versions</a></li>
++        <li><a href=\""manage_consent_types.php\"">Manage Consent types</a></li>
+         <li> Manage jobs
+         <ul>
+             <li><a href=\""cancel_wu_form.php\"">Cancel jobs by ID</a>",can you make the C in Consent lower case to match the other ones in this list?,"Shouldn't it be ""consent type""?"
+9214,"@@ -16,6 +16,7 @@ import (
+ 	""sync""
+ 	""testing""
+
++	""github.com/iotexproject/iotex-core/action/protocol/poll""
+ 	""github.com/stretchr/testify/require""
+
+ 	""github.com/iotexproject/iotex-core/action""",fix the group,I think this import is no longer needed.
+9215,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,`caps` could be `null`
+9216,"@@ -47,7 +47,7 @@ func BenchmarkServiceFetchBlocks(b *testing.B) {
+
+ 	// Create a network and block service
+ 	net := &httpTestPeerSource{}
+-	ls := rpcs.MakeBlockService(config.GetDefaultLocal(), remote, net, ""test genesisID"")
++	ls := rpcs.MakeBlockService(logging.Base(), config.GetDefaultLocal(), remote, net, ""test genesisID"")
+ 	nodeA := basicRPCNode{}
+ 	nodeA.RegisterHTTPHandler(rpcs.BlockServiceBlockPath, ls)
+ 	nodeA.start()",we have `logging.TestingLog()` that should be used for that purpose.,why use this here?
+9217,"@@ -2372,7 +2372,7 @@ int mg_url_decode(const char *src, int src_len, char *dst,
+ #define HEXTOI(x) (isdigit(x) ? x - '0' : x - 'W')
+
+   for (i = j = 0; i < src_len && j < dst_len - 1; i++, j++) {
+-    if (src[i] == '%' && i < src_len - 2 &&
++    if (i < src_len - 2 && src[i] == '%' &&
+         isxdigit(* (const unsigned char *) (src + i + 1)) &&
+         isxdigit(* (const unsigned char *) (src + i + 2))) {
+       a = tolower(* (const unsigned char *) (src + i + 1));",This is also a question of style. src[i] will always be valid because of check if 'for' statement,Shouldn't this be:
+9218,"@@ -398,7 +398,7 @@ func killKubeEdgeBinary(proc string) error {
+
+ //isKubeEdgeProcessRunning checks if the given process is running or not
+ func isKubeEdgeProcessRunning(proc string) (bool, error) {
+-	procRunning := fmt.Sprintf(""pidof %s 2&>1"", proc)
++	procRunning := fmt.Sprintf(""pidof %s 2>&1"", proc)
+ 	cmd := NewCommand(procRunning)
+
+ 	err := cmd.Exec()",Why change it?,I don't think this
+9219,"@@ -11,7 +11,7 @@ import {
+   textStyle,
+   colorStyle,
+   borders,
+-} from '../src'
++} from '../src/index'
+
+ const theme = {
+   colors: {",nb: this change is unnecessary,Can we just import
+9220,"@@ -120,6 +120,7 @@ type Object struct {
+ 	size        int64     // size of the object
+ 	modTime     time.Time // modification time of the object
+ 	id          string    // ID of the object
++	publicLink  string    // Public Link for the object
+ 	sha1        string    // SHA-1 of the object content
+ }
+ ",Is the publicLink mostly empty? I'm just wondering how much this will bloat memory usage as sometimes rclone has millions of Object~s in memory.,"Can we call this `link` instead of `publicLink`? ""public"" is a too generic term."
+9221,"@@ -65,6 +65,11 @@ type OrderSpec struct {
+ 	// validation process.
+ 	// This field must match the corresponding field on the DER encoded CSR.
+ 	DNSNames []string
++
++	// IPAddresses is a list of IP addresses that should be included as part of the Order
++	// validation process.
++	// This field must match the corresponding field on the DER encoded CSR.
++	IPAddresses []string `json:""ipAddresses,omitempty""`
+ }
+
+ type OrderStatus struct {","I don't think the Internal API types need the json annotations. They are never serialised, right?","Is there a possibility for someone to use this field in the future? If so, we sh"
+9222,"@@ -45,6 +45,7 @@ type apiClient interface {
+ 	GetApplicationMostRecentDeployment(ctx context.Context, req *pipedservice.GetApplicationMostRecentDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.GetApplicationMostRecentDeploymentResponse, error)
+ 	CreateDeployment(ctx context.Context, in *pipedservice.CreateDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.CreateDeploymentResponse, error)
+ 	ReportApplicationMostRecentDeployment(ctx context.Context, req *pipedservice.ReportApplicationMostRecentDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.ReportApplicationMostRecentDeploymentResponse, error)
++	ReportDeploymentCompleted(ctx context.Context, req *pipedservice.ReportDeploymentCompletedRequest, opts ...grpc.CallOption) (*pipedservice.ReportDeploymentCompletedResponse, error)
+ }
+
+ type gitClient interface {",Maybe this was added incidentally. We don't need this function in the interface.,I'm a little confused by the name `ReportDeploymentCompleted`. When I see `Repor
+9223,"@@ -18,8 +18,15 @@ func To(fs http.FileSystem, r *http.Request, to string, replacer httpserver.Repl
+
+ 	// try each rewrite paths
+ 	t := """"
++	query := """"
+ 	for _, v := range tos {
+-		t = path.Clean(replacer.Replace(v))
++		t = replacer.Replace(v)
++		tparts := strings.Split(t, ""?"")
++		t = path.Clean(tparts[0])
++
++		if len(tparts) > 1 {
++			query = tparts[1]
++		}
+
+ 		// add trailing slash for directories, if present
+ 		if strings.HasSuffix(v, ""/"") && !strings.HasSuffix(t, ""/"") {",Is this a safe/reliable way to split the URL?,Can we do something like `t = path.Clean(tparts[0])` instead of splitting on the
+9224,"@@ -350,6 +350,7 @@ public class JdbcProjectLoader extends AbstractJdbcLoader implements
+   public void uploadProjectFile(Project project, int version, String filetype,
+       String filename, File localFile, String uploader)
+       throws ProjectManagerException {
++    long startMs = System.currentTimeMillis();
+     logger.info(""Uploading to "" + project.getName() + "" version:"" + version
+         + "" file:"" + filename);
+     Connection connection = getConnection();",do we also need to profile the time to getConnection()?,Don't do this. Just use the `System.currentTimeMillis()` in the next line.
+9225,"@@ -34,6 +34,12 @@ def flow_to_json(flow: mitmproxy.flow.Flow) -> dict:
+         ""type"": flow.type,
+         ""modified"": flow.modified(),
+     }
++    # .alpn_proto_negotiated is bytes, we need to decode that.
++    for conn in ""client_conn"", ""server_conn"":
++        if f[conn][""alpn_proto_negotiated""] is None:
++            continue
++        f[conn][""alpn_proto_negotiated""] = \
++            f[conn][""alpn_proto_negotiated""].decode(errors=""backslashreplace"")
+     if flow.error:
+         f[""error""] = flow.error.get_state()
+ ",Should we move the decode part directly to the actual first-use of this? Or how does this affect if the value gets decoded and we need to get the bytes back later?,Could you elaborate on why we need backslashreplace here?
+9226,"@@ -78,6 +78,16 @@ $config = [
+                     ]
+                 ]
+             ],
++            'legacy-holds' => [
++                'type' => 'Laminas\Router\Http\Literal',
++                'options' => [
++                    'route'    => '/MyResearch/Holds',
++                    'defaults' => [
++                        'controller' => 'Holds',
++                        'action'     => 'List',
++                    ]
++                ]
++            ],
+             'legacy-summonrecord' => [
+                 'type' => 'Laminas\Router\Http\Literal',
+                 'options' => [","How would you feel about continuing to point this at the MyResearchController's holdsAction, but instead changing that action to force a redirect to the new holds-list route? That way, people will get sent to the new URL instead of having two different URLs that do the same thing.",Is this route necessary? I don't think it should be a route.
+9227,"@@ -1196,6 +1196,14 @@ func (c *client) markConnAsClosed(reason ClosedState, skipFlush bool) bool {
+ 	if skipFlush {
+ 		c.flags.set(skipFlushOnClose)
+ 	}
++	// Be consistent with the creation: for routes and gateways,
++	// we use Noticef on create, so use that too for delete.
++	if c.kind == ROUTER || c.kind == GATEWAY {
++		c.Noticef(""%s connection closed: %v"", c.typeString(), reason.String())
++	} else { // Client and Leaf Node connections.
++		c.Debugf(""%s connection closed: %v"", c.typeString(), reason.String())
++	}
++
+ 	// Save off the connection if its a client or leafnode.
+ 	if c.kind == CLIENT || c.kind == LEAF {
+ 		if nc := c.nc; nc != nil && c.srv != nil {",I think if yo use %s then you do not need reason.String() and can just do reason.,"noticef is deprecated in go, use `c.logf`"
+9228,"@@ -156,9 +156,9 @@ func WorkflowEndingRunID(endingRunID string) Tag {
+ 	return newStringTag(""wf-ending-run-id"", endingRunID)
+ }
+
+-// WorkflowDecisionTimeoutSeconds returns tag for WorkflowDecisionTimeoutSeconds
+-func WorkflowDecisionTimeoutSeconds(s int32) Tag {
+-	return newInt32(""wf-decision-timeout"", s)
++// WorkflowTaskTimeoutSeconds returns tag for WorkflowTaskTimeoutSeconds
++func WorkflowTaskTimeoutSeconds(s int32) Tag {
++	return newInt32(""wf-workflow-task-timeout"", s)
+ }
+
+ // QueryID returns tag for QueryID","Having ""wf"" prefix doesn't make sense anymore. Please remove.",Do we still need this function now?
+9229,"@@ -5,15 +5,15 @@ import {
+ 	teardown,
+ 	getMixedArray,
+ 	mixedArrayHTML,
+-	serializeHtml
++	serializeHtml,
++	sortAttributes,
++	spyAll
+ } from '../_util/helpers';
+ import { div, span, p } from '../_util/dom';
+
+ /** @jsx createElement */
+ const h = createElement;
+
+-let spyAll = obj => Object.keys(obj).forEach(key => sinon.spy(obj, key));
+-
+ function getAttributes(node) {
+ 	let attrs = {};
+ 	if (node.attributes) {",Removed this copy of the `spyAll` function and replaced it with the same function declared in `helpers.js`. Same for `sortAttributes` below,is there a reason to use `sortAttri
+9230,"@@ -90,9 +90,9 @@ public class KubernetesContainerizedImpl extends EventHandler implements Contain
+   public static final String DEFAULT_POD_NAME_PREFIX = ""fc-dep"";
+   public static final String DEFAULT_SERVICE_NAME_PREFIX = ""fc-svc"";
+   public static final String DEFAULT_CLUSTER_NAME = ""azkaban"";
+-  public static final String CPU_LIMIT = ""4"";
++  public static final String DEFAULT_MAX_CPU = ""0"";
++  public static final String DEFAULT_MAX_MEMORY = ""0Gi"";
+   public static final String DEFAULT_CPU_REQUEST = ""1"";
+-  public static final String MEMORY_LIMIT = ""64Gi"";
+   public static final String DEFAULT_MEMORY_REQUEST = ""2Gi"";
+   public static final String MAPPING = ""Mapping"";
+   public static final String SERVICE_API_VERSION_2 = ""ambassador/v2"";",Default max cpu should be 8 and memory 64GB,Why are we changing the default cpu
+9231,"@@ -156,6 +156,11 @@ class _MissingPandasLikeSeries(object):
+     real = unsupported_property(
+         'real',
+         reason=""If you want to collect your data as an NumPy array, use 'to_numpy()' instead."")
++    nbytes = unsupported_property(
++        'nbytes',
++        reason=""'nbytes' requires to compute whole dataset. You can calculate manually it, ""
++               ""with its 'itemsize', by explicitly executing its count. Use Spark's web UI ""
++               ""to monitor disk and memory usage of your application in general."")
+
+     # Functions we won't support.
+     memory_usage = common.memory_usage(unsupported_function)","@itholic, can you remove `nbytes = unsupported_property('nbytes')` at `_MissingPandasLikeSeries`?",I think we should say something lik
+9232,"@@ -101,9 +101,8 @@ func TestEnvironmentConfig(t *testing.T) {
+ 	assert.True(t, conf.TaskIAMRoleEnabled, ""Wrong value for TaskIAMRoleEnabled"")
+ 	assert.True(t, conf.TaskIAMRoleEnabledForNetworkHost, ""Wrong value for TaskIAMRoleEnabledForNetworkHost"")
+ 	assert.True(t, conf.ImageCleanupDisabled, ""Wrong value for ImageCleanupDisabled"")
+-	assert.True(t, conf.TaskCPUMemLimit, ""Wrong value for TaskCPUMemLimit"")
+-	assert.True(t, conf.TaskENIEnabled, ""Wrong value for TaskNetwork"")
+
++	assert.True(t, conf.TaskENIEnabled, ""Wrong value for TaskNetwork"")
+ 	assert.Equal(t, (30 * time.Minute), conf.MinimumImageDeletionAge)
+ 	assert.Equal(t, (2 * time.Hour), conf.ImageCleanupInterval)
+ 	assert.Equal(t, 2, conf.NumImagesToDeletePerCycle)",What happened to the assertion on `conf.TaskCPUMemLimit`?,Did you mean to delete this?
+9233,"@@ -5,10 +5,13 @@ import { render } from './render';
+ import { rerender } from './render-queue';
+ import options from './options';
+
++const createRef = Object;
++
+ export default {
+ 	h,
+ 	createElement,
+ 	cloneElement,
++	createRef,
+ 	Component,
+ 	render,
+ 	rerender,",Just curious: Is using `Object` faster than a literal `{}`?,This should probably be move
+9234,"@@ -59,6 +59,14 @@ func ValidateCertificateForACMEIssuer(crt *v1alpha1.CertificateSpec, issuer *v1a
+ 		el = append(el, field.Invalid(specPath.Child(""organization""), crt.Organization, ""ACME does not support setting the organization name""))
+ 	}
+
++	if crt.Duration.Duration != 0 {
++		el = append(el, field.Invalid(specPath.Child(""duration""), crt.Duration, ""ACME does not support certificate durations""))
++	}
++
++	if crt.RenewBefore.Duration != 0 {
++		el = append(el, field.Invalid(specPath.Child(""renewBefore""), crt.RenewBefore, ""ACME does not support certificate renewal times""))
++	}
++
+ 	return el
+ }
+ ","How come we don't allow this to be configured with the ACME issuer? Happy to leave this as-is for now if there's a lot more consideration that needs to be made, but it seems like we could/should be able to allow this?",Shouldn't this be `specPath.
+9235,"@@ -208,7 +208,6 @@ type HTTPHealthCheckOpts struct {
+
+ // NetworkLoadBalancerListener holds configuration that's need for a Network Load Balancer listener.
+ type NetworkLoadBalancerListener struct {
+-	Port            string
+ 	Protocol        string
+ 	TargetContainer string
+ 	TargetPort      string",Should we remove the `Aliases` field as well?,Why is this port removed?
+9236,"@@ -88,6 +88,8 @@ public class VoiceSearchWidget extends UIWidget implements WidgetManagerDelegate
+
+         mMozillaSpeechService = MozillaSpeechService.getInstance();
+         mMozillaSpeechService.setProductTag(""fxr"");
++        mMozillaSpeechService.storeSamples(false);
++        mMozillaSpeechService.storeTranscriptions(false);
+
+         mVoiceSearchText1 = findViewById(R.id.voiceSearchText1);
+         mVoiceSearchText2 = findViewById(R.id.voiceSearchText2);",what's the effect of turning these two off? is there an issue on file for context?,This component doesn't seem to have anything to do with the rest of the changes. It should be removed
+9237,"@@ -35,9 +35,10 @@ type CLITestType string
+
+ // List all test types here
+ const (
+-	Wrapper                   CLITestType = ""1 wrapper""
+-	GcloudProdWrapperLatest   CLITestType = ""2 gcloud-prod wrapper-latest""
+-	GcloudLatestWrapperLatest CLITestType = ""3 gcloud-latest wrapper-latest""
++	Wrapper                       CLITestType = ""1 wrapper""
++	GcloudBetaProdWrapperLatest   CLITestType = ""2 gcloud-beta-prod wrapper-latest""
++	GcloudBetaLatestWrapperLatest CLITestType = ""3 gcloud-beta-latest wrapper-latest""
++	GcloudGaLatestWrapperRelease  CLITestType = ""4 gcloud-ga-latest wrapper-release""
+ )
+
+ var (","The format like gcloud-beta-prod is a bit hard to understand. Maybe find a a more clear way to describe it,",Wanted to make sure this is the same as `GcloudGaLatestWrapperRelease`
+9238,"@@ -20,7 +20,7 @@ namespace OpenTelemetry.Tags
+     /// <summary>
+     /// Collection of tags representing the tags context.
+     /// </summary>
+-    public interface ITagContext : IEnumerable<Tag>
++    public interface ITagContext : IEnumerable<DistributedContextEntry>
+     {
+     }
+ }",Are we renaming this too in a follow up PR?,Can you also change the interface from `Tag` to `DistributedContextEntry`?
+9239,"@@ -179,7 +179,8 @@ class Preference extends Model
+     public function getLocaleOptions()
+     {
+         $localeOptions = [
+-            'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++		    'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
+             'cs' => [Lang::get('system::lang.locale.cs'), 'flag-cz'],
+             'da' => [Lang::get('system::lang.locale.da'), 'flag-dk'],
+             'en' => [Lang::get('system::lang.locale.en'), 'flag-us'],",The indentation on this is off by one space to the left,Please fix the indentation of these two lines.
+9240,"@@ -52,7 +52,9 @@ static VkImageSubresourceRange RangeFromLayers(const VkImageSubresourceLayers &s
+ static VkImageSubresourceRange MakeImageFullRange(const VkImageCreateInfo &create_info) {
+     const auto format = create_info.format;
+     VkImageSubresourceRange init_range{0, 0, VK_REMAINING_MIP_LEVELS, 0, VK_REMAINING_ARRAY_LAYERS};
+-    if (FormatIsColor(format) || FormatIsMultiplane(format)) {
++    const VkExternalFormatANDROID *pExternalFormatANDROID = lvl_find_in_chain<VkExternalFormatANDROID>(&create_info);
++    bool isExternalFormatConversion = (pExternalFormatANDROID != nullptr && pExternalFormatANDROID->externalFormat != 0);
++    if (FormatIsColor(format) || FormatIsMultiplane(format) || isExternalFormatConversion) {
+         init_range.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;  // Normalization will expand this for multiplane
+     } else {
+         init_range.aspectMask =","I guess nothing is wrong with this approach, but more curious if you didn't just go `|| (format != VK_FORMAT_UNDEFINED)) {` As if there ever was another external format system added in Vulkan it would need to be manually added here",">isExternalFormatConversion [](start = 15, length = 18) can we rename this to isExternalFormatConversionCompatible?"
+9241,"@@ -22,7 +22,8 @@
+ package com.github.javaparser.resolution.types;
+
+ import java.util.*;
+-import java.util.stream.Collectors;
++
++import static java.util.stream.Collectors.joining;
+
+ /**
+  * A union type is defined in java as list of types separates by pipes.",Is order really irrelevant here?,I don't believe this import is required.
+9242,"@@ -15,11 +15,14 @@ import android.net.Uri;
+ import android.provider.MediaStore;
+ import android.speech.RecognizerIntent;
+ import android.support.annotation.NonNull;
++import android.support.design.widget.Snackbar;
+ import android.util.Base64;
+ import android.view.View;
+ import android.webkit.MimeTypeMap;
++import android.widget.Toast;
+
+ import org.fossasia.phimpme.R;
++import org.fossasia.phimpme.accounts.AccountActivity;
+ import org.fossasia.phimpme.data.local.AccountDatabase;
+
+ import java.io.ByteArrayOutputStream;",I think this import will be unused now. If it is unused remove it.,This import seems unused and should be removed
+9243,"@@ -37,6 +37,13 @@ type MutationItem struct {
+ 	value []byte
+ }
+
++func NewBatch(kv RwKV) StatelessRwTx {
++	return &mutation{
++		db:   NewObjectDatabase(kv),
++		puts: btree.New(32),
++	}
++}
++
+ func (mi *MutationItem) Less(than btree.Item) bool {
+ 	i := than.(*MutationItem)
+ 	c := strings.Compare(mi.table, i.table)",Let's change to tx,"Just curious, why do we need a `mutation` now?"
+9244,"@@ -55,6 +55,12 @@ const (
+ 	// By default, this will be the block type given to all blocks
+ 	// that aren't explicitly some other type.
+ 	defaultBlockTypeDefault = keybase1.BlockType_DATA
++
++	// By default, allow 10% of the free bytes on disk to be used in the disk block cache.
++	defaultDiskBlockCacheFraction = 0.10
++
++	// By default, allow 15% of the free bytes on disk to be used in the sync block cache.
++	defaultSyncBlockCacheFraction = 0.10
+ )
+
+ // ConfigLocal implements the Config interface using purely local","Looks like I was wrong about the sync cache size being 15% before. There seems to be some reporting bug related to my use of the sync cache, that makes the limit different from the working set cache limit. For now, I say we keep this at `0.10` (change the param default too), and we can change it later if needed.",Can we make this configurable? Or do we need to hard code it?
+9245,"@@ -151,7 +151,7 @@ func sentryNotSetupWarning() {
+ // from the last saved version. If it is, prompt to request anon ddev usage stats
+ // and update the info.
+ func checkDdevVersionAndOptInSentry() error {
+-	if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false {
++	if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false && os.Getenv(""DDEV_NO_SENTRY"") == """" {
+ 		allowStats := util.Confirm(""It looks like you have a new ddev release.\nMay we send anonymous ddev usage statistics and errors?\nTo know what we will see please take a look at\nhttps://ddev.readthedocs.io/en/latest/users/cli-usage/#opt-in-usage-information\nPermission to beam up?"")
+ 		if allowStats {
+ 			globalconfig.DdevGlobalConfig.InstrumentationOptIn = true","I think it'd be a good idea to define the environment variable name as a constant in values.go because it's hard-coded in several places, but that's a small point.",Should we also check that DDEV_NO_SENTRY is set?
+9246,"@@ -0,0 +1,6 @@
++class AddIndexesToClassifications < ActiveRecord::Migration
++  def change
++    add_index :classifications, :topic_id
++    add_index :classifications, [:classifiable_id, :classifiable_type]
++  end
++end",Style/SymbolArray: Use %i or %I for an array of symbols.,"Just curious, do we need an index on `topic_id` and `classifi"
+9247,"@@ -133,6 +133,13 @@ func TestComposeCmd(t *testing.T) {
+ 	assert.Error(err)
+ }
+
++func TestCheckCompose(t *testing.T) {
++	assert := asrt.New(t)
++
++	err := CheckDockerCompose()
++	assert.NoError(err)
++}
++
+ func TestGetAppContainers(t *testing.T) {
+ 	assert := asrt.New(t)
+ 	sites, err := GetAppContainers(""dockertest"")","Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions.",This should probably be called `TestCheckDockerCompose` for t
+9248,"@@ -116,6 +116,10 @@ public abstract class AbstractOAuth2AuthenticationProvider implements Authentica
+         final OAuthRequest request = new OAuthRequest(Verb.GET, userEndpoint, service);
+         request.addHeader(""Authorization"", ""Bearer "" + accessToken.getAccessToken());
+         request.setCharset(""UTF-8"");
++
++        // Microsoft
++        request.addHeader(""Accept"", ""application/json"");
++
+
+         final Response response = request.send();
+         int responseCode = response.getCode();",I'm slightly concerned about this because doesn't ORCID use XML instead of JSON?,Shouldn't this be `application/octet-stream`?
+9249,"@@ -17,7 +17,11 @@ def is_new_user_stats_batch():
+     So, we check the database and see if the difference between the last time stats were updated
+     and right now is greater than 12 hours.
+     """"""
+-    return datetime.now(timezone.utc) - db_stats.get_timestamp_for_last_user_stats_update() > timedelta(hours=TIME_TO_CONSIDER_STATS_AS_OLD)
++    last_update_ts = db_stats.get_timestamp_for_last_user_stats_update()
++    if(last_update_ts is None):
++        last_update_ts = datetime.min.replace(tzinfo=timezone.utc) # use min datetime value if last_update_ts is None
++
++    return datetime.now(timezone.utc) - last_update_ts > timedelta(hours=TIME_TO_CONSIDER_STATS_AS_OLD)
+
+
+ def notify_user_stats_update():",brackets around if conditions isn't really pythonic.,`last_update_ts = db_stats.get_timestamp_for_
+9250,"@@ -396,9 +396,6 @@ func (h *Impl) Stop() {
+ 	h.namespaceCache.Stop()
+ 	h.membershipMonitor.Stop()
+ 	h.ringpopChannel.Close()
+-	if err := h.grpcListener.Close(); err != nil {
+-		h.logger.WithTags(tag.Error(err)).Error(""failed to close gRPC listener"")
+-	}
+ 	h.runtimeMetricsReporter.Stop()
+ 	h.persistenceBean.Close()
+ 	h.visibilityMgr.Close()","It turn out that when we close server it closed underlying listener itself, so this line always generated and error.",Why was this removed?
+9251,"@@ -38,13 +38,13 @@ function createObjects(user) {
+             error: err => console.log(err)
+         },
+         schema: [{
+-            name: 'Dog',
+-            primaryKey: '_id',
++            name: ""Dog"",
++            primaryKey: ""_id"",
+             properties: {
+-              _id: 'objectId?',
+-              breed: 'string?',
+-              name: 'string',
+-              realm_id: 'string?',
++              _id: ""objectId?"",
++              breed: ""string?"",
++              name: ""string"",
++              realm_id: ""string?"",
+             }
+         }]
+     };",Looks like this is for debugging? Maybe just remove.,"can we change this to `realm_id: ""string""` ?"
+9252,"@@ -187,7 +187,10 @@ module Mongoid
+     #
+     # @since 1.0.0
+     def exists?
+-      context.count > 0
++      Mongoid.unit_of_work(disable: :current) do
++        # Don't use count here since Mongo does not use counted b-tree indexes
++        !context.dup.criteria.only(:_id).limit(1).entries.first.nil?
++      end
+     end
+
+     # Extract a single id from the provided criteria. Could be in an $and",Same here - this code is duplicated. I think we can just remove the `exists?` method completely from `Criteria` and it should delegate to the context.,I don't feel strongly about this one but it feels like this is the wrong place to put this code. I'm not sure that we need to use it here since it's only used once in the controller.
+9253,"@@ -150,8 +150,14 @@ void SYCLInternal::initialize(const sycl::queue& q) {
+
+     m_maxShmemPerBlock =
+         d.template get_info<sycl::info::device::local_mem_size>();
+-    m_indirectKernelMem.reset(*m_queue, m_instance_id);
++
+     m_indirectReducerMem.reset(*m_queue, m_instance_id);
++    for (auto& usm_mem : m_indirectKernelMem) {
++      usm_mem.reset(*m_queue, m_instance_id);
++      // TODO 0x1440= 5184, arbitrary, larger than largest encountered kernel.
++      usm_mem.reserve(0x1440);
++    }
++
+   } else {
+     std::ostringstream msg;
+     msg << ""Kokkos::Experimental::SYCL::initialize(...) FAILED"";",I'm not quite sure that we preallocate memory. Do you have a good reason for that?,"What is this for? If you don't have any other memory on `m_indirectKernelMem`, does it need to be reset again?"
+9254,"@@ -731,6 +731,17 @@ func (s *Server) checkAuth(c *client) bool {
+ 	}
+ }
+
++// Check that number of clients is below Max connection setting.
++func (s *Server) checkMaxConn(c *client) bool {
++	if c.typ == CLIENT {
++		s.mu.Lock()
++		ok := len(s.clients) <= s.opts.MaxConn
++		s.mu.Unlock()
++		return ok
++	}
++	return true
++}
++
+ // Remove a client or route from our internal accounting.
+ func (s *Server) removeClient(c *client) {
+ 	var rID string","If we have added to s.clients, we could just do the following since if its a route will be ok I think. s.mu.Lock() defer s.mu.Unlock() return len(s.clients) <+ s.opts.MaxConn",Do we need this lock?
+9255,"@@ -53,7 +53,10 @@ void BalanceTask::invoke() {
+             LOG(INFO) << taskIdStr_ << ""Ask the src to give up the leadership."";
+             SAVE_STATE();
+             if (srcLived_) {
+-                client_->transLeader(spaceId_, partId_, src_).thenValue([this](auto&& resp) {
++                // For balance task of single replica, the target leader is src_ itself
++                HostAddr targetLeader = singleReplica_ ? src_ : kRandomPeer;
++                client_->transLeader(spaceId_, partId_, src_, targetLeader)
++                    .thenValue([this](auto&& resp) {
+                     if (!resp.ok()) {
+                         LOG(INFO) << taskIdStr_ << ""Transfer leader failed, status "" << resp;
+                         if (resp == nebula::Status::PartNotFound()) {","if the targetLeader is src_ itself, it is really need call transLeader function?",This is the same as `src_` above. I think you want to use `src_` here.
+9256,"@@ -85,6 +85,7 @@ public class CSharpSurfaceNamer extends SurfaceNamer {
+
+   @Override
+   public String getAndSavePagedResponseTypeName(
++      Method method,
+       FeatureConfig featureConfig,
+       ModelTypeTable typeTable,
+       TypeRef inputType,",Can we remove this featureConfig since you removed in L98 (assuming it is not used else where),why did you change this to a method? This looks like a breaking change.
+9257,"@@ -11,6 +11,7 @@ using Newtonsoft.Json;
+
+ using Xunit;
+ using System.Collections.Generic;
++using System.Linq;
+
+ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+ {",namespaces in this file need a sorting,nit: remove extra line
+9258,"@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
+ 		c.VXLANMTU = hostMTU - vxlanMTUOverhead
+ 	}
+ 	if c.Wireguard.MTU == 0 {
+-		if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == ""WorkloadIPs"" {
++		if c.Wireguard.EncryptHostTraffic {
+ 			// The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes,
+ 			// see https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-tcpip-performance-tuning#azure-and-vm-mtu
+ 			// for details.",This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS.,Does this change belong in this PR?
+9259,"@@ -36,8 +36,14 @@ class FastTemporalMemory(TemporalMemory):
+   """"""
+
+   def __init__(self, *args, **kwargs):
++    maxSegmentsPerCell = kwargs.get(""maxSegmentsPerCell"") or 255
++    maxSynapsesPerSegment = kwargs.get(""maxSynapsesPerSegment"") or 255
++
+     super(FastTemporalMemory, self).__init__(*args, **kwargs)
+-    self.connections = Connections(self.numberOfCells())
++    self.connections = Connections(
++      self.numberOfCells(),
++      maxSegmentsPerCell=maxSegmentsPerCell,
++      maxSynapsesPerSegment=maxSynapsesPerSegment)
+
+
+   def burstColumns(self,",`get` has an optional second parameter that is the default if the key isn't found.,"why not set `self.connections = Connections(self.numberOfCells(), maxSe"
+9260,"@@ -63,6 +63,7 @@ if (LDAP_HOST && $ldap_auth) {
+     if (!$passwd_hash) {
+         echo ""<account_out>\n"";
+         echo ""   <success/>\n"";
++        echo ""<id>$user->id</id>\n"";
+         echo ""</account_out>\n"";
+         exit();
+     }",Please also indent the new response line as was done to the existing line above.,I'm not sure why `$user->id` isn't just `$user->id`?
+9261,"@@ -3403,6 +3403,13 @@ void Client::Handle_OP_AutoFire(const EQApplicationPacket *app)
+ 		DumpPacket(app);
+ 		return;
+ 	}
++
++	if (this->GetTarget() == this) {
++		this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++		auto_fire = false;
++		return;
++	}
++
+ 	bool *af = (bool*)app->pBuffer;
+ 	auto_fire = *af;
+ 	auto_attack = false;",Shouldn't need this-> here.,brace on wrong line
+9262,"@@ -2717,7 +2717,7 @@ bool Game::internalStartTrade(Player* player, Player* tradePartner, Item* tradeI
+ 	player->sendTradeItemRequest(player->getName(), tradeItem, true);
+
+ 	if (tradePartner->tradeState == TRADE_NONE) {
+-		tradePartner->sendTextMessage(MESSAGE_EVENT_ADVANCE, fmt::format(""{:s} wants to trade with you."", player->getName()));
++		tradePartner->sendTextMessage(MESSAGE_TRADE, fmt::format(""{:s} wants to trade with you."", player->getName()));
+ 		tradePartner->tradeState = TRADE_ACKNOWLEDGE;
+ 		tradePartner->tradePartner = player;
+ 	} else {","I believe this is incorrect, if I'm not wrong, MESSAGE_TRADE should be used when buying/selling items from NPC's",What does `MESSAGE_TRADE` mean? Which part does it m
+9263,"@@ -728,6 +728,8 @@ namespace pwiz.Skyline
+                     return _listGraphPeakArea.FirstOrDefault(g => g.Type == type) ?? CreateGraphPeakArea(type);
+                 else if (split[1] == typeof(MassErrorGraphController).Name)
+                     return _listGraphMassError.FirstOrDefault(g => g.Type == type) ?? CreateGraphMassError(type);
++                else if (split[1] == typeof(DetectionsGraphController).Name)
++                    return _listGraphDetections.FirstOrDefault(g => g.Type == type) ?? CreateGraphDetections(type);
+                 else
+                     return null;
+             }","Better if you give split[0], split[1], and split[2] descriptive names than using them this much through so many lines of code.",We also need to handle the case of `_listGraphDetect
+9264,"@@ -41,8 +41,6 @@ export const getSetupIncompleteComponent = ( module, inGrid = false, fullWidth =
+ 	return ctaWrapper( cta, inGrid, fullWidth, createGrid );
+ };
+
+-export default getSetupIncompleteComponent;
+-
+ /**
+  * Creates a CTA component when module needs to be activated. Different wrapper HTML is needed depending on where the CTA gets output, which is determined by the inGrid, fullWidth, and createGrid parameters.
+  *",I know we're deleting this soon but I thought I'd fix it anyway :smile:,Why was this removed?
+9265,"@@ -58,9 +58,9 @@ public final class Slf4jConstantLogMessage extends BugChecker implements MethodI
+
+         List<? extends ExpressionTree> args = tree.getArguments();
+         ExpressionTree messageArg = ASTHelpers.isCastable(
+-                ASTHelpers.getType(tree.getArguments().get(0)),
+-                state.getTypeFromString(""org.slf4j.Marker""),
+-                state)
++                        ASTHelpers.getType(tree.getArguments().get(0)),
++                        state.getTypeFromString(""org.slf4j.Marker""),
++                        state)
+                 ? args.get(1)
+                 : args.get(0);
+ ","I like this, makes it clearer what scope the continuation is in",Please don't make unr
+9266,"@@ -367,12 +367,12 @@ describe('MergeCells', () => {
+       keyDownUp('tab');
+       keyDownUp('enter');
+
+-      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('top-left-corner!');
++      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('A1');
+
+       keyDownUp('tab');
+       keyDownUp('enter');
+
+-      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('top-left-corner!');
++      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('B1');
+     });
+
+     it('should select the cell in the top-left corner of the merged cell, when navigating down using the SHIFT + ENTER key on the' +",These test checks if the value of the merged cells is correct. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire mergeCells.e2e.js file.,Was this change inten
+9267,"@@ -598,3 +598,14 @@ func encodeAccounts(s *changeset.ChangeSet) ([]byte, error) {
+ }
+
+ // ---- Copy-Paste of code to decode ChangeSets: End -----
++
++var clearHashedChangesets = Migration{
++	Name: ""clear_hashed_changesets"",
++	Up: func(db ethdb.Database, tmpdir string, progress []byte, OnLoadCommit etl.LoadCommitHandler) error {
++		if err := db.(ethdb.BucketsMigrator).ClearBuckets(dbutils.AccountChangeSetBucket, dbutils.StorageChangeSetBucket); err != nil {
++			return err
++		}
++
++		return OnLoadCommit(db, nil, true)
++	},
++}","Don't need to clear them - because nobody have data there, also can don't delete buckets - just leave them, new nodes will not have them if remove bucket from buckets.go",Should this also have
+9268,"@@ -0,0 +1,17 @@
++/* Copyright 2016 Google Inc
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *      http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package com.google.api.codegen.viewmodel;
++
++public interface ApiMethodView {}","Similarly, this has only one implementing class",Should this be an interface instead of a bare class?
+9269,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?,Do we also want to set `Content-Encoding` header to
+9270,"@@ -268,7 +268,7 @@ class StubsGenerator
+     /**
+      * @return PhpParser\Node\Identifier|PhpParser\Node\Name|PhpParser\Node\NullableType|null
+      */
+-    public static function getParserTypeFromPsalmType(Type\Union $type)
++    public static function getParserTypeFromPsalmType(Type\Union $type): ?PhpParser\NodeAbstract
+     {
+         $nullable = $type->isNullable();
+ ",I must have forgotten that one in previous PR,Same as above we can from bc not add new typehints.
+9271,"@@ -1,10 +1,8 @@
+ require ""test_helper""
+
+ class DiaryCommentTest < ActiveSupport::TestCase
+-  api_fixtures
+-  fixtures :diary_comments
+-
+   def test_diary_comment_count
+-    assert_equal 4, DiaryComment.count
++    comment = create(:diary_comment)
++    assert_includes DiaryComment.all, comment
+   end
+ end",This test name doesn't really reflect what the test does any more... Then again I'm not really sure what it is testing now - is it actually just testing that FactoryGirl can create records? or does that itself funnel through the rails code so that we're testing rails can create records?,This is no longer needed so I removed it from the ha
+9272,"@@ -1423,8 +1423,12 @@ func (m *executor) putCStorVolumeReplica() (err error) {
+
+ // putUpgradeResult will put an upgrade result as defined in the task
+ func (m *executor) putUpgradeResult() (err error) {
++	raw, err := template.AsTemplatedBytes(""UpgradeResult"", m.Runtask.Spec.Task, m.Values)
++	if err != nil {
++		return
++	}
+ 	uresult, err := upgraderesult.
+-		BuilderForRuntask(""UpgradeResult"", m.Runtask.Spec.Task, m.Values).
++		BuilderForTemplateObject(raw).
+ 		Build()
+ 	if err != nil {
+ 		return",Can this be `BuilderForYAMLObject`,Would it make sense to make this a `pkg/template/template.go`?
+9273,"@@ -42,12 +42,14 @@ cpp_test = pytest.mark.skipif(not hasattr(core, ""test_coverage""),
+ #-------------------------------------------------------------------------------
+
+ def test_multiprocessing_threadpool():
++    import atexit
+     # Verify that threads work properly after forking (#1758)
+     import multiprocessing as mp
+     from datatable.internal import get_thread_ids
+     parent_threads = get_thread_ids()
+     n = 4
+     pool = mp.Pool(processes=n)
++    atexit.register(pool.close)
+     child_threads = pool.starmap(get_thread_ids, [()] * n, chunksize=1)
+     assert len(child_threads) == n
+     for chthreads in child_threads:",better use `with mp.Pool(...) as pool:` here,Does it work if I put `atexit.register(pool.close)` at the top
+9274,"@@ -48,8 +48,12 @@ public class Pids extends AbstractApiBean {
+         String baseUrl = systemConfig.getDataCiteRestApiUrlString();
+         String username = System.getProperty(""doi.username"");
+         String password = System.getProperty(""doi.password"");
+-        JsonObjectBuilder result = PidUtil.queryDoi(persistentId, baseUrl, username, password);
+-        return ok(result);
++        try {
++            JsonObjectBuilder result = PidUtil.queryDoi(persistentId, baseUrl, username, password);
++            return ok(result);
++        } catch (Exception ex) {
++            return error(Response.Status.BAD_REQUEST, ex.getLocalizedMessage());
++        }
+     }
+
+     @GET","Since this is a config problem, BAD_REQUEST is probably not the right response.",Should we log the full exception here as well?
+9275,"@@ -479,6 +479,11 @@ func (o *Options) ProcessConfigFile(configFile string) error {
+ 				errors = append(errors, err)
+ 				continue
+ 			}
++			if dur < 30*time.Second {
++				err := &configErr{tk, fmt.Sprintf(""invalid lame_duck_duration of %v, minimum is 30 seconds"", dur)}
++				errors = append(errors, err)
++				continue
++			}
+ 			o.LameDuckDuration = dur
+ 		case ""trusted"":
+ 			switch v.(type) {","We could probably do 1 sec if we have time, and hence exit early if we have small number of clients. So LB = 60 sec. Grace = 10secs. So 50Sec window, if NumClients < 50, Close 1 every second. Then exit when NumClients == 0.",You can check `dur < 30 * time.Second` just to be sure.
+9276,"@@ -75,7 +75,7 @@ def combine_frames(this, *args, how=""full""):
+         # If the same named index is found, that's used.
+         for this_column, this_name in this_index_map:
+             for that_col, that_name in that_index_map:
+-                if this_name == that_name:
++                if (this_column == that_col) and (this_name == that_name):
+                     # We should merge the Spark columns into one
+                     # to mimic pandas' behavior.
+                     this_scol = this._internal.scol_for(this_column)",can you rename `that_col` to `that_column`?,Why the change?
+9277,"@@ -19,7 +19,9 @@
+ /**
+  * Internal dependencies
+  */
+-import Widgets from './googlesitekit/widgets';
++import { Widget } from './googlesitekit/widgets';
++
++const Widgets = { componenets: Widget };
+
+ if ( typeof global.googlesitekit === 'undefined' ) {
+ 	global.googlesitekit = {};","This is not correct, it will override everything else that is currently in `Widgets`. This file shouldn't be modified at all, we should be adding `components.Widget` in `assets/js/googlesitekit/widgets/index.js`, where the rest of that object is defined. Oh, and there's a typo here :)",I wonder if the
+9278,"@@ -152,6 +152,14 @@ void BalanceTask::invoke() {
+                 if (!resp.ok()) {
+                     LOG(INFO) << taskIdStr_ << ""Update meta failed, status "" << resp;
+                     ret_ = Result::FAILED;
++                } else if (kv_ != nullptr) {
++                    if (LastUpdateTimeMan::update(kv_, time::WallClock::fastNowInMilliSec()) !=
++                            kvstore::ResultCode::SUCCEEDED) {
++                        LOG(INFO) << taskIdStr_ << ""Update meta failed"";
++                        ret_ = Result::FAILED;
++                    } else {
++                        status_ = Status::REMOVE_PART_ON_SRC;
++                    }
+                 } else {
+                     status_ = Status::REMOVE_PART_ON_SRC;
+                 }",Each task finished will result in the meta info updated?,Why is this in
+9279,"@@ -88,7 +88,7 @@ class PageSpeedInsightsSetup extends Component {
+
+ 	handleAPIKeyChange( e ) {
+ 		this.setState( {
+-			apikey: e.currentTarget.value,
++			apikey: e.currentTarget.value.replace( /\s/g, '' ),
+ 			disabled: 0 === e.currentTarget.value.length,
+ 		} );
+ 	}","Quick follow-up @aaemnnosttv, why this and not `.trim()`?",Is there a reas
+9280,"@@ -1,3 +1,4 @@
++/* eslint-disable sitekit/camelcase-acronyms */
+ /**
+  * Profile Select component tests.
+  *","I don't think we should have file-wide exceptions for this rule, let's annotate the individual instances.",I think we should rename this file to be generic.
+9281,"@@ -101,6 +101,8 @@ public class MailServiceBean implements java.io.Serializable {
+     private Session session;
+
+     public boolean sendSystemEmail(String to, String subject, String messageText) {
++        if (true) return true;
++
+         boolean sent = false;
+         String body = messageText + ResourceBundle.getBundle(""Bundle"").getString(""notification.email.closing"");
+         logger.fine(""Sending email to "" + to + "". Subject: <<<"" + subject + "">>>. Body: "" + body);","@raprasad you plan to take this ""if true"" out, right?",Remove the `if (true)` and `return true;`
+9282,"@@ -496,11 +496,13 @@ class ConsoleMaster(flow.FlowMaster):
+         self.eventlog = not self.eventlog
+         self.view_flowlist()
+
+-    def _readflow(self, path):
+-        path = os.path.expanduser(path)
++    def _readflow(self, paths):
+         try:
+-            f = file(path, ""rb"")
+-            flows = list(flow.FlowReader(f).stream())
++            flows = []
++            for path in paths:
++                path = os.path.expanduser(path)
++                f = file(path, ""rb"")
++                flows.extend(list(flow.FlowReader(f).stream()))
+         except (IOError, flow.FlowReadError), v:
+             return True, v.strerror
+         return False, flows","Could you adjust this to `with open(path, ""rb""):` here and below? We should make sure that we close all files.",This should probably be `list(flow.FlowReader(f).
+9283,"@@ -7,6 +7,8 @@ package libkbfs
+ import (
+ 	""testing""
+
++	""golang.org/x/net/context""
++
+ 	""github.com/keybase/kbfs/kbfshash""
+ 	""github.com/keybase/kbfs/tlf""
+ )",Does this need its own import block or can it be combined with the imports below as in most other files?,can we remove this?
+9284,"@@ -34,6 +34,12 @@ _registered_options = {
+     # For example, this value determines whether the repr() for a dataframe prints out fully or
+     # just a truncated repr.
+     ""display.max_rows"": 1000,  # TODO: None should support unlimited.
++
++    # This determines whether or not to operate between two different dataframs.
++    # For example, 'combine_frames' function internally performs a join operation which can be
++    # expensive in general.
++    # So, if `compute.ops_on_diff_frames` variable is not True, that method throws an exception.
++    ""compute.ops_on_diff_frames"": True,
+ }  # type: Dict[str, Any]
+
+ ",It defaults to `false`.,Maybe add a `TODO: None should support unlimited.`?
+9285,"@@ -7,8 +7,12 @@ type corsHandler struct {
+ }
+
+ func (wrapper corsHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
+-	resp.Header().Set(""Access-Control-Allow-Origin"", ""*"")
+-	resp.Header().Set(""Access-Control-Allow-Methods"", ""POST, GET, OPTIONS, PUT, DELETE"")
++	if isPreflightCorsRequest(req) {
++		applyPreflightCorsResponse(resp)
++		return
++	}
++
++	allowAllCorsActions(resp)
+ 	wrapper.originalHandler.ServeHTTP(resp, req)
+ }
+ ","Why conditional check is done? As i understand, later both `applyPreflightCorsResponse()` and `allowAllCorsActions()` does the same",Could you explain why we need to set `Access-Contro
+9286,"@@ -142,6 +142,9 @@ func (mh *MessageHandle) OnRegister(connection conn.Connection) {
+
+ 	if _, ok := mh.KeepaliveChannel[nodeID]; !ok {
+ 		mh.KeepaliveChannel[nodeID] = make(chan struct{}, 1)
++	} else {
++		klog.Warningf(""Node %v/%v has not yet exit, OnRegister failed"", projectID, nodeID)
++		return
+ 	}
+
+ 	io := &hubio.JSONIO{Connection: connection}",has not yet exit?,I don't think we should be returning here. If the n
+9287,"@@ -247,6 +247,11 @@ _rt_hemuother_per_user_known = {
+
+ class RadioTap(Packet):
+     name = ""RadioTap dummy""
++    deprecated_fields = {
++        ""Channel"": ""ChannelFrequency"",  # 2.4.3
++        ""ChannelFlags2"": ""ChannelPlusFlags"",  # 2.4.3
++        ""ChannelNumber"": ""ChannelPlusNumber""  # 2.4.3
++    }
+     fields_desc = [
+         ByteField('version', 0),
+         ByteField('pad', 0),",I wonder if the version should be part of the deprecation API. It might ease our future selves while debugging issues =),Does the `ChannelPlusFlags` need to be added to the
+9288,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,"This should not be finest, it just logs a warning. If you want to look at the source of the warning, you can use `logger.isDebugEnabled()` instead."
+9289,"@@ -183,10 +183,11 @@ namespace Microsoft.Sarif.Viewer
+                 HelpLink = rule?.HelpUri?.ToString()
+             };
+
+-            IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotationsFromStacks(result.Stacks);
++            IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotatedCodeLocationsFromStacks(result.Stacks);
++            IEnumerable<IEnumerable<AnnotatedCodeLocation>> codeFlowLocations = CreateAnnotatedCodeLocationsFromCodeFlows(result.CodeFlows);
+
+             CreateAnnotatedCodeLocationCollections(stackLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+-            CreateAnnotatedCodeLocationCollections(result.CodeFlows, AnnotatedCodeLocationKind.CodeFlow, sarifError);
++            CreateAnnotatedCodeLocationCollections(codeFlowLocations, AnnotatedCodeLocationKind.CodeFlow, sarifError);
+             CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+
+             if (region != null)",This is just a rename...,We should be able to remove `CreateAnnotatedCodeLocationCollections` here now.
+9290,"@@ -33,7 +33,10 @@ func GetLengthLimitedID(fixedPrefix, suffix string, maxLength int) string {
+ 		// start with the character that we use to denote a shortened string, which could
+ 		// result in a clash.  Hash the value and truncate...
+ 		hasher := sha256.New()
+-		hasher.Write([]byte(suffix))
++		_, err := hasher.Write([]byte(suffix))
++		if err != nil {
++			return """"
++		}
+ 		hash := base64.RawURLEncoding.EncodeToString(hasher.Sum(nil))
+ 		charsLeftForHash := maxLength - 1 - prefixLen
+ 		return fixedPrefix + shortenedPrefix + hash[0:charsLeftForHash]","Should probably panic here. I think hashers are contracted not to return errors (and returning """" doesn't handle the error)",The error needs to be logged.
+9291,"@@ -13,7 +13,7 @@ import (
+ // Address is the interface that defines methods to manage Filecoin addresses and wallets.
+ type Address interface {
+ 	Addrs() Addrs
+-	Import(ctx context.Context, f files.Directory) ([]address.Address, error)
++	Import(ctx context.Context, f files.File) ([]address.Address, error)
+ 	Export(ctx context.Context, addrs []address.Address) ([]*types.KeyInfo, error)
+ }
+ ",Aside: this is a confusing name for an interface that contains multiple addresses.,Shouldn't this be `f files.File`?
+9292,"@@ -47,10 +47,8 @@ module Bolt
+       state = node_result['state']
+       result = node_result['result']
+
+-      result_output = Bolt::Node::ResultOutput.new
+-      result_output.stdout << result.to_json
+       if state == 'finished'
+-        Bolt::Node::Success.new(result.to_json, result_output)
++        exit_code = 0
+       else
+         # Try to extract the exit_code from _error
+         begin",We expect to use Bolt::CommandResult for scripts as well?,With the changes to `Bolt::Node::Success#new` we can probably get rid of `Bolt::Node::Success::new` too.
+9293,"@@ -386,7 +386,9 @@ module RSpec
+         user_metadata = Metadata.build_hash_from(args)
+
+         @metadata = Metadata::ExampleGroupHash.create(
+-          superclass_metadata, user_metadata, description, *args, &example_group_block
++          superclass_metadata, user_metadata,
++          superclass.method(:next_runnable_index_for),
++          description, *args, &example_group_block
+         )
+
+         hooks.register_globals(self, RSpec.configuration.hooks)",same thing as above inre commas and args?,"I don't think this will work, since `next_runnable_index_for` is not a private method."
+9294,"@@ -224,6 +224,9 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""query/useCircuitBreakers"", false);
++    memoryCircuitBreakerThreshold = getInt(""query/memoryCircuitBreakerThreshold"", 100);
+
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ",Should we validate that this is between 0 and 100?,This should be `query/memoryCircuitBreakerThreshold`
+9295,"@@ -332,7 +332,7 @@ func (c *cliApp) help() {
+
+ // quit stops cli and client commands and exits application
+ func (c *cliApp) quit() {
+-	stop := utils.SoftKiller(c.Kill)
++	stop := utils.HardKiller(c.Kill)
+ 	stop()
+ }
+ ",`HardKiller` doing `os.Exit()` without proper shutting down other dependencies. I think there should be a better approach for this.,should we use `c.Gatherer` here?
+9296,"@@ -136,16 +136,12 @@ const struct wlr_gles2_pixel_format *get_gles2_format_from_gl(
+ 	return NULL;
+ }
+
+-const uint32_t *get_gles2_shm_formats(const struct wlr_gles2_renderer *renderer,
+-		size_t *len) {
+-	static uint32_t shm_formats[sizeof(formats) / sizeof(formats[0])];
+-	size_t j = 0;
++void init_gles2_data_ptr_formats(struct wlr_gles2_renderer *renderer) {
+ 	for (size_t i = 0; i < sizeof(formats) / sizeof(formats[0]); i++) {
+ 		if (!is_gles2_pixel_format_supported(renderer, &formats[i])) {
+ 			continue;
+ 		}
+-		shm_formats[j++] = formats[i].drm_format;
++		wlr_drm_format_set_add(&renderer->data_ptr_texture_formats,
++			formats[i].drm_format, DRM_FORMAT_MOD_LINEAR);
+ 	}
+-	*len = j;
+-	return shm_formats;
+ }",Why isnt the return value checked?,"Looks like this function is only used in one place, can it be private?"
+9297,"@@ -28,12 +28,15 @@ package util
+
+ import (
+ 	""fmt""
+-	""k8s.io/apimachinery/pkg/util/json""
+ 	""strings""
++
++	""k8s.io/apimachinery/pkg/util/json""
+ )
+
+ // GetNestedField returns a nested field from the provided map
+ func GetNestedField(obj map[string]interface{}, fields ...string) interface{} {
++	fmt.Println(""obj"", obj)
++	fmt.Println(""fields"", fields)
+ 	var val interface{} = obj
+ 	for _, field := range fields {
+ 		if _, ok := val.(map[string]interface{}); !ok {",remove this debug,Did you mean to include these logging statements?
+9298,"@@ -286,10 +286,13 @@ auto data_type_layer<TensorDataType>::get_local_error_signals(int parent_index)
+ // Accessing matrices corresponding to parent/child layer
+ template <typename TensorDataType>
+ auto data_type_layer<TensorDataType>::get_activations(const Layer& child) const -> const BaseDistMat& {
+-  const int child_index = (std::find(m_child_layers.begin(),
+-                                     m_child_layers.end(),
+-                                     &child)
+-                           - m_child_layers.begin());
++  if(m_child_layers.empty()) {
++    LBANN_ERROR(""This layer has no children"");
++  }
++  const int child_index = std::distance(m_child_layers.begin(),
++                                        std::find(m_child_layers.begin(),
++                                                  m_child_layers.end(),
++                                                  &child));
+   if (child_index >= get_num_children()) {
+     std::stringstream err;
+     err << ""attempted to get activation tensor of ""","This should change to a call to `Layer::find_layer_index`, which should be renamed to `find_child_layer_index` and it should return a `size_t` (technically the `difference_type` for whatever iterators are going to be used).",this -> `if (m_child_layers.empty()) {`
+9299,"@@ -114,7 +114,7 @@ class py2exe(build_exe.py2exe):
+
+ 	def build_manifest(self, target, template):
+ 		mfest, rid = build_exe.py2exe.build_manifest(self, target, template)
+-		if getattr(target, ""script"", None) == ""nvda.pyw"":
++		if getattr(target, ""script"", """").endswith("".pyw""):
+ 			# This is one of the main application executables.
+ 			mfest = mfest[:mfest.rindex(""</assembly>"")]
+ 			mfest += MAIN_MANIFEST_EXTRA + ""</assembly>""",what is this change about?,Should we use `os.path.endswith` instead?
+9300,"@@ -161,8 +161,6 @@ class Testinfra(Verifier):
+             cmd=[""pytest"", *util.dict2args(options), *self._tests, *args],
+             cwd=self._config.scenario.directory,
+             env=self.env,
+-            stdout=LOG.out,
+-            stderr=LOG.error,
+         )
+         # print(self._testinfra_command.cmd)
+ ",Why did we leave the `stderr` param in this case while we removed it from other bake methods?,These stdout/stderr should be dropped. The `--stdout`/`--stderr` flags are deprecated.
+9301,"@@ -30,6 +30,13 @@ func VerifyTrustDomainMemberID(td spiffeid.TrustDomain, id spiffeid.ID) error {
+ 	return nil
+ }
+
++func VerifySameTrustDomain(td spiffeid.TrustDomain, id spiffeid.ID) error {
++	if !id.MemberOf(td) {
++		return fmt.Errorf(""%q is not a member of trust domain %q"", id, td)
++	}
++	return nil
++}
++
+ func TrustDomainAgentIDFromProto(td spiffeid.TrustDomain, protoID *types.SPIFFEID) (spiffeid.ID, error) {
+ 	id, err := idFromProto(protoID)
+ 	if err != nil {",This seems to only be used by the server/ca package.... maybe this can live there instead of being lumped into these API implementation helpers?,This function doesn't do anything. You don't seem to be calling it anywhere.
+9302,"@@ -1035,6 +1035,15 @@ func TestProvisionContainerResourcesSetPausePIDInVolumeResources(t *testing.T) {
+ 		}, nil),
+ 		mockCNIClient.EXPECT().SetupNS(gomock.Any(), gomock.Any(), gomock.Any()).Return(nsResult, nil),
+ 	)
++	// These mock calls would be made only for Windows.
++	dockerClient.EXPECT().CreateContainerExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(
++		&types.IDResponse{ID: containerID}, nil).MinTimes(0).MaxTimes(1)
++	dockerClient.EXPECT().StartContainerExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).
++		MinTimes(0).MaxTimes(1)
++	dockerClient.EXPECT().InspectContainerExec(gomock.Any(), gomock.Any(), gomock.Any()).Return(&types.ContainerExecInspect{
++		ExitCode: 0,
++		Running:  false,
++	}, nil).MinTimes(0).MaxTimes(1)
+
+ 	require.Nil(t, taskEngine.(*DockerTaskEngine).provisionContainerResources(testTask, pauseContainer).Error)
+ 	assert.Equal(t, strconv.Itoa(containerPid), volRes.GetPauseContainerPID())","hmm.. this is Hacky, the test will succeed in Windows even if you remove the calls to these, right?",Is it possible that these calls would be made only for Windows?
+9303,"@@ -1,4 +1,9 @@
+-test_name 'Install beaker and checkout branch if necessary' do
++ruby_version, ruby_source = ENV['RUBY_VER'], ""job parameter""
++unless ruby_version
++  ruby_version = ""2.3.1""
++  ruby_source = ""default""
++end
++test_name 'Install and configure Ruby #{ruby_version} (from #{ruby_source}) on the SUT' do
+
+   step 'Download the beaker git repo' do
+    on default, 'git clone https://github.com/puppetlabs/beaker.git /opt/beaker/'",should this block be in the file `05_install_ruby.rb`?,did you mean to change this to default to 2.3.1?
+9304,"@@ -167,7 +167,9 @@ func withDisconnectedClient(t *testing.T, recorder *Recorder, f func(raw.Client)
+ 				Unary: http.NewOutbound(""http://localhost:65535""),
+ 			},
+ 		},
+-		Filter: recorder,
++		Filters: yarpc.Filters{
++			UnaryFilter: recorder,
++		},
+ 	})
+ 	require.NoError(t, clientDisp.Start())
+ 	defer clientDisp.Stop()","To match outbounds, let's just call this `Unary: recorder`, `Oneway: ...`.",Does this have any side-effects on the other tests?
+9305,"@@ -49,7 +49,7 @@ def stripControlChars(string):
+
+ def compactHash(string):
+   hash = md5()
+-  hash.update(string)
++  hash.update(string.encode('unicode_escape'))
+   return hash.hexdigest()
+
+ ",`string.encode('utf-8')` is more common but I guess this is mostly cosmetic :),Should this be `force_text`? Or was this done to ma
+9306,"@@ -23,6 +23,6 @@ func NewLoggingHandler(handler http.Handler) LoggingHandler {
+ }
+
+ func (lh LoggingHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+-	log.Info(""Handling http request"", ""method"", r.Method, ""from"", r.RemoteAddr, ""uri"", r.RequestURI)
++	log.Info(""Handling http request"", ""method"", r.Method, ""from"", r.RemoteAddr)
+ 	lh.h.ServeHTTP(w, r)
+ }","Consider logging `r.Url.Path`? Either way, ship it!","why remove ""uri"" here?"
+9307,"@@ -54,14 +54,16 @@ type Context struct {
+ // Group data are omitted because they are committed to in the
+ // transaction and its ID.
+ type Params struct {
+-	CurrSpecAddrs transactions.SpecialAddresses
+-	CurrProto     protocol.ConsensusVersion
++	CurrSpecAddrs  transactions.SpecialAddresses
++	CurrProto      protocol.ConsensusVersion
++	MinTealVersion uint64
+ }
+
+ // PrepareContexts prepares verification contexts for a transaction
+ // group.
+ func PrepareContexts(group []transactions.SignedTxn, contextHdr bookkeeping.BlockHeader) []Context {
+ 	ctxs := make([]Context, len(group))
++	minTealVersion := logic.ComputeMinTealVersion(group)
+ 	for i := range group {
+ 		spec := transactions.SpecialAddresses{
+ 			FeeSink:     contextHdr.FeeSink,",this probably should be done lazely only if logic/app call txn in the group. Or even done in LogicSigSanityCheck?,Why do we need this at all?
+9308,"@@ -1639,6 +1639,10 @@ func (e *mutableStateBuilder) addWorkflowExecutionStartedEventForContinueAsNew(
+ 		SearchAttributes:         attributes.SearchAttributes,
+ 	}
+
++	if attributes.GetInitiator() == enumspb.CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED {
++		attributes.Initiator = enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW
++	}
++
+ 	req := &historyservice.StartWorkflowExecutionRequest{
+ 		NamespaceId:              e.namespaceEntry.GetInfo().Id,
+ 		StartRequest:             createRequest,",Please move this to `common/enums/defaults.go`.,Why do we need this? Shouldn't the initiator be set to WORKFLOW by default?
+9309,"@@ -2,6 +2,7 @@
+ import time
+ import json
+ import re
++import listenbrainz.db.user as db_user
+ from collections import defaultdict
+ from yattag import Doc
+ import yattag","In general, if you find unalphabetized imports, you should alphabetize them. Fine for now though.",nit: unused import
+9310,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,Is this function used anywhere? Can we remove it?
+9311,"@@ -49,7 +49,12 @@ namespace pwiz.Skyline.Model
+             SLens = explicitSLens;
+             ConeVoltage = explicitConeVoltage;
+             DeclusteringPotential = explicitDeclusteringPotential;
+-            CompensationVoltage = explicitCompensationVoltage;
++            if (explicitCompensationVoltage.HasValue &&
++                (explicitIonMobilityUnits != MsDataFileImpl.eIonMobilityUnits.compensation_V ||
++                 !Equals(explicitIonMobility, explicitCompensationVoltage)))
++            {
++                CompensationVoltage = explicitCompensationVoltage;
++            }
+         }
+
+         public ExplicitTransitionGroupValues(ExplicitTransitionGroupValues other)","Is this if statement here necessary? It looks like this is the same logic that is taken care of in the setter for the property ""CompensationVoltage"".",explicitIonMobility == null || explicitIonMobilityUnits == MsDataFileImpl.e
+9312,"@@ -68,6 +68,14 @@ def bulk_send(elastic, list_):
+         raise_on_exception=False
+     )
+
++def key_to_parts(key):
++    """"""make a string for fulltext indexing of file name""""""
++    base, ext = os.path.splitext(key)
++    key_parts = base.split(""/"")
++    key_parts.append(ext[1:])
++
++    return f""{key} {' '.join(key_parts)}""
++
+ class DocumentQueue:
+     """"""transient in-memory queue for documents to be indexed""""""
+     def __init__(self, context):",Eliminate this function; handled by mappings and analyzer,This should probably be in `bokeh/util/index.py` since it's used in multiple places.
+9313,"@@ -249,7 +249,14 @@ class JSTree extends AbstractBase
+                     'recordID' => '__record_id__'
+                 ]
+             ];
+-            $cache[$route] = $this->router->fromRoute($route, $params, $options);
++            $routeName = $route;
++            $datasource = $this->getDataSource();
++            if ($route === 'collection') {
++                $routeName = $datasource->getCollectionRoute();
++            } elseif ($route === 'record') {
++                $routeName = $datasource->getRecordRoute();
++            }
++            $cache[$route] = $this->router->fromRoute($routeName, $params, $options);
+         }
+         return str_replace('__record_id__', urlencode($id), $cache[$route]);
+     }","I wonder if this new logic would actually fit better as a support method, both for readability and overriding... e.g. <pre> protected function getRouteNameFromDataSource($route) { if ($route === 'collection') { return $this->getDataSource()->getCollectionRoute(); } elseif ($route === 'record') { return $this->getDataSource()->getRecordRoute(); } return $route; } </pre> That's extremely nitpicky, and you can feel free to leave this as-is if you prefer... but that feels marginally better to me.",Why not just do this in the `fromRoute` call?
+9314,"@@ -35,13 +35,13 @@ public class BaseSuite {
+   public static ExternalResource testEnvironment = new ExternalResource() {
+     @Override
+     protected void before() {
+-      log.info(""Preparing test environment"");
++      log.finest(""Preparing test environment"");
+       GlobalTestEnvironment.get(SeleniumTestEnvironment.class);
+       System.setProperty(""webdriver.remote.shorten_log_messages"", ""true"");
+     }
+     @Override
+     protected void after() {
+-      log.info(""Cleaning test environment"");
++      log.finest(""Cleaning test environment"");
+       TestEnvironment environment = GlobalTestEnvironment.get();
+       if (environment != null) {
+         environment.stop();",This is in test code: understanding what we're doing is important in this context.,Why this change? Is it related to this PR?
+9315,"@@ -16,7 +16,7 @@ import (
+ 	""github.com/tinygo-org/tinygo/ir""
+ 	""github.com/tinygo-org/tinygo/loader""
+ 	""golang.org/x/tools/go/ssa""
+-	""tinygo.org/x/go-llvm""
++	llvm ""tinygo.org/x/go-llvm""
+ )
+
+ func init() {","This change (and a few similar ones below) are not related to rpi3 support, and should be removed.",Let's rename this package to `go-llvm` please.
+9316,"@@ -382,7 +382,7 @@ class KoalasBoxPlot(BoxPlot):
+         showcaps=None,
+         showbox=None,
+         showfliers=None,
+-        **kwargs
++        **kwargs,
+     ):
+         # Missing arguments default to rcParams.
+         if whis is None:","Hmm, why did we come to need the `,` at the end?",No need to change this :)
+9317,"@@ -13,7 +13,8 @@ module.exports = function selectPopulatedFields(query) {
+     var userProvidedFields = query._userProvidedFields || {};
+     if (query.selectedInclusively()) {
+       for (i = 0; i < paths.length; ++i) {
+-        if (!isPathInFields(userProvidedFields, paths[i])) {
++        var hasPath = query._fields[paths[i]];
++        if (!isPathInFields(userProvidedFields, paths[i]) && hasPath) {
+           query.select(paths[i]);
+         }
+       }","I'm suspicious of this. For one thing, `query._fields[paths[i]]` may be `0`, `false`, etc. so checking for falsy will catch both cases where both the field isn't in the projection and if the field is explicitly excluded from the projection. For another, I'm not so sure that #6546 is a bug. Let's discuss that more.",Does this mean that if yo
+9318,"@@ -32,6 +32,8 @@ type Parser struct {
+ 	interpreter *interpreter
+ 	// Stashed set of source code for builtin rules.
+ 	builtins map[string][]byte
++
++	statements []*Statement
+ }
+
+ // NewParser creates a new parser instance. One is normally sufficient for a process lifetime.",What is this? I'm a bit unclear why the parser would have a list of statements in it.,How about renaming `state
+9319,"@@ -29,6 +29,14 @@ var (
+ 			""name"",
+ 		}, nil,
+ 	)
++	descPrometheusEnforcedSampleLimit = prometheus.NewDesc(
++		""prometheus_operator_enforced_sample_limit"",
++		""Global limit on the number of scraped samples per scrape target."",
++		[]string{
++			""namespace"",
++			""name"",
++		}, nil,
++	)
+ )
+
+ type prometheusCollector struct {","I believe this is Prometheus name, wonder if this is descriptive enough of a label name? @nrchakradhar @simonpasquier wdyt?",What is the expected form
+9320,"@@ -213,6 +213,11 @@ type Config struct {
+ 	IpInIpMtu        int    `config:""int;1440;non-zero""`
+ 	IpInIpTunnelAddr net.IP `config:""ipv4;""`
+
++	// Knobs provided to explicitly control whether we add rules to drop encap traffic
++	// from workloads. We always add them unless explicitly disabled.
++	DropVXLANPacketsFromWorkloads bool `config:""bool;true""`
++	DropIPIPPacketsFromWorkloads  bool `config:""bool;true""`
++
+ 	AWSSrcDstCheck string `config:""oneof(DoNothing,Enable,Disable);DoNothing;non-zero""`
+
+ 	ReportingIntervalSecs time.Duration `config:""seconds;30""`",Are most of our other fields default-zero-value? Would `AllowVXLANPacketsFromWorkloads` be a better formulation of this? I think it would make it easier for golang users of the API (default value matches the type zero-value),We should probably have some sort of default value for this setting so that users can turn it off if they want to.
+9321,"@@ -35,7 +35,7 @@ namespace Nethermind.TxPool
+         void AddPeer(ITxPoolPeer peer);
+         void RemovePeer(PublicKey nodeId);
+         AddTxResult AddTransaction(Transaction tx, TxHandlingOptions handlingOptions);
+-        void RemoveTransaction(Keccak hash, long blockNumber);
++        void RemoveTransaction(Keccak hash, long blockNumber, bool removeSmallerNonces);
+         bool TryGetPendingTransaction(Keccak hash, out Transaction transaction);
+         UInt256 ReserveOwnTransactionNonce(Address address);
+         event EventHandler<TxEventArgs> NewDiscovered;","void RemoveTransactions(Address sander, long removeBelowThisNonce) and separate these two calls","Would it not make sense to add a new interface such as `RemoveTransaction(Keccak hash, long blockNumber, bool remo"
+9322,"@@ -4365,6 +4365,8 @@ func TestJetStreamSnapshotsAPI(t *testing.T) {
+ 	// Now connect through a cluster server and make sure we can get things to work this way as well.
+ 	nc2 := clientConnectToServer(t, ls)
+ 	defer nc2.Close()
++	// Wait a bit for interest to propagate.
++	time.Sleep(100 * time.Millisecond)
+
+ 	snapshot = snapshot[:0]
+ ","Not sure which interest you are looking for to propagate here, but keep in mind that we have helpers (maybe not in /test package?) to check/wait for interest on a literal on a server for a given account.",Can you explain why this is necessary? It seems like it would be a good thing to do.
+9323,"@@ -140,6 +140,7 @@ func execProcess(context *cli.Context) (int, error) {
+ 		detach:          detach,
+ 		pidFile:         context.String(""pid-file""),
+ 		action:          CT_ACT_RUN,
++		init:            false,
+ 	}
+ 	return r.run(p)
+ }",nit: should not need this.,"The default should be `true`, no?"
+9324,"@@ -89,6 +89,8 @@ public class Constants {
+   // The flow exec id for a flow trigger instance unable to trigger a flow yet
+   public static final int FAILED_EXEC_ID = -2;
+
++  // Name of the file which keeps project directory size
++  public static final String PROJECT_DIR_SIZE_FILE_NAME = ""___azkaban_project_dir_size_in_bytes___"";
+
+   public static class ConfigurationKeys {
+ ","Since this constant is an implementation detail rather than a user-facing API, is it better to define it in a place where it is used?","I am not sure how the name `_azkaban_project_dir_size_in_bytes` is used, can you clarify?"
+9325,"@@ -1007,6 +1007,8 @@ class ListParameter(Parameter):
+         :param str x: the value to parse.
+         :return: the parsed value.
+         """"""
++        if isinstance(x, list):
++            x = json.dumps(x)
+         return list(json.loads(x, object_pairs_hook=FrozenOrderedDict))
+
+     def serialize(self, x):",It would be nice if we have some docs explaining this. Core luigi should avoid having hard to understand code.,is it always a list? do we need to check for it?
+9326,"@@ -43,6 +43,11 @@ public abstract class StemmerTestBase extends LuceneTestCase {
+
+   static void init(boolean ignoreCase, String affix, String... dictionaries)
+       throws IOException, ParseException {
++    stemmer = new Stemmer(loadDictionary(ignoreCase, affix, dictionaries));
++  }
++
++  static Dictionary loadDictionary(boolean ignoreCase, String affix, String... dictionaries)
++      throws IOException, ParseException {
+     if (dictionaries.length == 0) {
+       throw new IllegalArgumentException(""there must be at least one dictionary"");
+     }",extract a method to call from a test,The Stemmer should be initialized in the constructor and not static.
+9327,"@@ -184,6 +184,8 @@ public class CoreContainer {
+   private volatile ExecutorService coreContainerWorkExecutor = ExecutorUtil.newMDCAwareCachedThreadPool(
+       new DefaultSolrThreadFactory(""coreContainerWorkExecutor""));
+
++  final private ExecutorService collectorExecutor;
++
+   private final OrderedExecutor replayUpdatesExecutor;
+
+   protected volatile LogWatcher logging = null;",nitpick: regular order is private than final.,Why not use a single thread executor here?
+9328,"@@ -145,6 +145,11 @@ class DocstringParameterChecker(BaseChecker):
+             ""useless-type-doc"",
+             ""Please remove the ignored parameter type documentation."",
+         ),
++        ""W9021"": (
++            'Missing any documentation in ""%s""',
++            ""missing-any-param-doc"",
++            ""Please add parameter and/or type documentation."",
++        ),
+     }
+
+     options = (","We could add an old names here, the ideal would be to not force to disable missing-any-param when the old one was already disabled. But they are not really equivalent so maybe you were right to not add it.",I don't think this is the right place to put this message. It should be at the end of the message.
+9329,"@@ -8,11 +8,13 @@
+                 public const string BenchF = ""BenchF"";
+                 public const string BenchI = ""BenchI"";
+             public const string Inlining = ""Inlining"";
+-            public const string SIMD = ""SIMD"";
+-            public const string Span = ""Span"";
+             public const string V8 = ""V8"";
+             public const string Perflab = ""Perflab"";
+
+         public const string CoreFX = ""CoreFX"";
++
++        public const string LINQ = ""LINQ"";
++        public const string SIMD = ""SIMD"";
++        public const string Span = ""Span"";
+     }
+ }",">public const string LINQ = ""LINQ""; [](start = 8, length = 34) Are there duplicated benchmarks here? #Closed",Revert this change
+9330,"@@ -129,14 +129,16 @@ module Beaker
+         end
+       end
+
+-      def do_install hosts, version, path, pre_30, options = {}
++      def do_install hosts, options = {}
+         #convenience methods for installation
+         ########################################################
+-        def installer_cmd(host, version, installer)
++        def installer_cmd(host, options)
+           if host['platform'] =~ /windows/
++            version = options[:pe_ver_win] || host['pe_ver_win']
+             ""cd #{host['working_dir']} && msiexec.exe /qn /i puppet-enterprise-#{version}.msi""
+           else
+-            ""cd #{host['working_dir']}/#{host['dist']} && ./#{installer}""
++            version = options[:pe_ver] || host['pe_ver']
++            ""cd #{host['working_dir']}/#{host['dist']} && ./#{options[:installer]}""
+           end
+         end
+         def link_exists?(link)",Probably worth taking the opportunity to add yardocs to this method now. Esp. curious about what the options hash accepts.,should this be `host['platform']`?
+9331,"@@ -271,6 +271,12 @@ static void roots_cursor_press_button(struct roots_cursor *cursor,
+ 			break;
+ 		case WLR_BUTTON_PRESSED:
+ 			roots_seat_set_focus(seat, view);
++			if (surface && !view) {
++				struct wlr_layer_surface *layer = surface->role_data;
++				if (layer->current.keyboard_interactive) {
++					roots_seat_set_focus_layer(seat, layer);
++				}
++			}
+ 			break;
+ 		}
+ 	}","This is Very Meh . We want to get rid of `role_data`, and it's an internal field.","I see that `view` is only used in the `roots_seat_set_focus_layer` function, so I'm wondering if t"
+9332,"@@ -97,6 +97,11 @@ class Database {
+ 		return this.tryCall('selectOne', sql, params);
+ 	}
+
++	async loadExtension(path) {
++		const result = await this.driver()['loadExtension'](path);
++		return result;
++	}
++
+ 	async selectAll(sql, params = null) {
+ 		return this.tryCall('selectAll', sql, params);
+ 	}",`await this.driver().loadExtension(path);` should work,"This shouldn't be needed, the driver should be able to call `selectOne` directly."
+9333,"@@ -98,12 +98,12 @@ func TestAddDepRescan(t *testing.T) {
+ 	target1.AddDependency(buildLabel(""//package1:target4""))
+
+ 	// Fake test: calling this now should have no effect because rescan is not true.
+-	state.QueueTarget(buildLabel(""//package1:target1""), core.OriginalTarget, false, false)
++	state.QueueTarget(buildLabel(""//package1:target1""), core.OriginalTarget, false)
+ 	assertPendingParses(t, state)
+ 	assertPendingBuilds(t, state) // Note that the earlier call to assertPendingBuilds cleared it.
+
+ 	// Now running this should activate it
+-	rescanDeps(state, map[*core.BuildTarget]struct{}{target1: {}})
++	// rescanDeps(state, map[*core.BuildTarget]struct{}{target1: {}})
+ 	time.Sleep(time.Millisecond * 100)
+
+ 	assertPendingBuilds(t, state, ""//package1:target4"")",Is any of this needed anymore?,"If this is no longer needed, can we just remove it?"
+9334,"@@ -26,6 +26,16 @@
+ #include ""ostree-repo-private.h""
+ #include ""otutil.h""
+
++/* See ostree-repo.c for a bit more info about these ABI checks */
++#if __SIZEOF_POINTER__ == 8 && __SIZEOF_LONG__ == 8 && __SIZEOF_INT__ == 4
++G_STATIC_ASSERT(sizeof(OstreeDiffDirsOptions) ==
++                sizeof(int) * 2 +
++                sizeof(gpointer) +
++                sizeof(int) * (7+6) +
++                sizeof(int) +  /* hole */
++                sizeof(gpointer) * 7);
++#endif
++
+ static gboolean
+ get_file_checksum (OstreeDiffFlags  flags,
+                    GFile *f,",Can you add a mention here and in `ostree-repo.c` that the holes were found with `pahole`?,"`OstreeDiffDirsOptions` is `OstreeDiffDirsOptions`, not `OstreeDiffDirsOptions`."
+9335,"@@ -78,7 +78,17 @@ module Blacklight::SolrHelper
+   # Returns a two-element array (aka duple) with first the solr response object,
+   # and second an array of SolrDocuments representing the response.docs
+   def get_search_results(user_params = params || {}, extra_controller_params = {})
+-    solr_response = query_solr(user_params, extra_controller_params)
++    Deprecation.warn(self, ""get_search_results is deprecated and will be removed in blacklight-6.0. Use `search_results' instead"")
++    search_results(user_params, extra_controller_params, solr_search_params_logic)
++  end
++
++  # a solr query method
++  # @param [Hash,HashWithIndifferentAccess] user_params ({}) the user provided parameters (e.g. query, facets, sort, etc)
++  # @param [Hash,HashWithIndifferentAccess] extra_controller_params ({}) extra parameters to add to the search
++  # @param [List<Symbol] processor_chain a list of filter methods to run
++  # @return [Blacklight::SolrResponse] the solr response object
++  def search_results(user_params, extra_controller_params, solr_search_parms_logic)
++    solr_response = query_solr(user_params, extra_controller_params, solr_search_params_logic)
+
+     case
+     when (solr_response.grouped? && grouped_key_for_results)","While we're changing this, I wonder if we can do away with `extra_controller_params`.. Maybe a new type of `solr_search_params_logic` that appends the attributes?",Is it possible to keep this method as is and instead add a `default_action` in th
+9336,"@@ -564,6 +564,8 @@ module Beaker
+
+           yield self if block_given?
+
++        rescue Beaker::DSL::Assertions, Minitest::Assertion => early_assertion
++          fail_test(early_assertion)
+         rescue Exception => early_exception
+           original_exception = RuntimeError.new(""PuppetAcceptance::DSL::Helpers.with_puppet_running_on failed (check backtrace for location) because: #{early_exception}\n#{early_exception.backtrace.join(""\n"")}\n"")
+           raise(original_exception)","I believe that you only need to rescue Beaker::DSL::Assertions, as they include Minitest::Assertions.",I don't think we should be doing this here. The issue is that we are catching `Exception`s and catching `Exception`s is the wrong approach. The right fix here is to catch `Exception`s and raise the correct exception.
+9337,"@@ -372,6 +372,7 @@ namespace OpenTelemetry.Trace
+         private void RunGetRequestedDataAlwaysOffSampler(Activity activity)
+         {
+             activity.IsAllDataRequested = false;
++            activity.ActivityTraceFlags &= ActivityTraceFlags.None;
+         }
+
+         private void RunGetRequestedDataOtherSampler(Activity activity)",Do we need `&=` or `=` is sufficient?,"Do we really want to remove the trace flag here? I'm not sure what the best way to do it is, but I'm not sure what the right answer is."
+9338,"@@ -161,8 +161,8 @@ $settings['trusted_host_patterns'] = ['.*'];
+ $settings['class_loader_auto_detect'] = FALSE;
+
+ // This specifies the default configuration sync directory.
+-if (empty($config_directories[CONFIG_SYNC_DIRECTORY])) {
+-  $config_directories[CONFIG_SYNC_DIRECTORY] = '{{ joinPath $config.SitePath $config.SyncDir }}';
++if (empty($settings['config_sync_directory'])) {
++  $settings['config_sync_directory'] = '{{ joinPath $config.SitePath $config.SyncDir }}';
+ }
+ `
+ )",Let's keep both of these here. It should work on most any version of Drupal 8 then true?,I guess this should be `settings['config_sync_directory'] = '{{ joinPath $config.SyncDir }}';`
+9339,"@@ -699,7 +699,7 @@ namespace OpenTelemetry.Trace.Test
+         private void AssertApproxSameTimestamp(DateTime one, DateTime two)
+         {
+             var timeShift = Math.Abs((one - two).TotalMilliseconds);
+-            Assert.InRange(timeShift, double.Epsilon, 10);
++            Assert.InRange(timeShift, double.Epsilon, 20);
+         }
+     }
+ }",@lmolkova This ok? I'm getting random failures from the build checks that don't happen locally from a few non-deterministic time related comparisons.,Why is this 20? Shouldn't that be 60?
+9340,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright ConsenSys AG.
++ * Copyright Hyperledger Besu Contributors.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
+  * the License. You may obtain a copy of the License at",Q: are we supposed to change this for files that already exist?,Could you revert the change to the copyright?
+9341,"@@ -477,7 +477,7 @@ def initialize_unbounded(obj, dimensions, key):
+     """"""
+     select = dict(zip([d.name for d in dimensions], key))
+     try:
+-        obj.select([DynamicMap], **select)
++        obj.select(selection_specs=[DynamicMap], **select)
+     except KeyError:
+         pass
+ ","I count only four times where `selection_specs` had to be specified as a keyword instead of by position! If that is how often it was used that positional argument in our own codebase, I am pretty certain users barely used it (if at all).",Could you explain why this change is needed?
+9342,"@@ -24,5 +24,10 @@ describe HashDiffDecorator do
+       output = HashDiffDecorator.html_for(['~', 'foo', '', 'bar'])
+       expect(output).to eq(""<code>foo</code> was changed from <code>[empty]</code> to <code>&quot;bar&quot;</code>"")
+     end
++
++    it ""renders numeric events"" do
++      output = HashDiffDecorator.html_for(['~', 'a_number', 456, 123])
++      expect(output).to eq(""<code>a_number</code> was changed from <code>456.00</code> to <code>123.00</code>"")
++    end
+   end
+ end",is this test for the case above? seems to cover a numeric rather than empty val?,I think this should be `expect(output).to inc
+9343,"@@ -245,6 +245,9 @@ class FlowHandler(RequestHandler):
+                         request.port = int(v)
+                     elif k == ""headers"":
+                         request.headers.set_state(v)
++                    elif k == ""content"":
++                        print(v)
++                        response.content = str(v)
+                     else:
+                         print(""Warning: Unknown update {}.{}: {}"".format(a, k, v))
+ ","I like the general idea, but this will break: - JSON is not binary-safe, so anything binary will break this. - JSON is super slow for multiple-MB things - We want to have drag-and-drop upload - the easiest way to implement this is FormData upload, so we should have a multipart/formdata endpoint. Can we put to /flow/content?",I think this is a leftover statement.
+9344,"@@ -121,6 +121,7 @@ bool    dr_preinjected = false;
+ static bool dynamo_exiting = false;
+ #endif
+ bool    dynamo_exited = false;
++bool    dynamo_exited_synched = false;
+ bool    dynamo_exited_and_cleaned = false;
+ #ifdef DEBUG
+ bool    dynamo_exited_log_and_stats = false;",_and_synched seems to be more consistent w/ exited_and_cleaned,Please rename this to `dynamo_exited_synched`.
+9345,"@@ -13,6 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
++#if NETCOREAPP3_1
+ using Moq;
+ using Newtonsoft.Json;
+ using OpenTelemetry.Trace;",nit: in case of whole file `ifdef` it may be helpful to have `_netcore31` suffix it in the name of the file as well.,Why the `NETCOREAPP3_1` ifdef rather than just
+9346,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+
+   @Override",should use Number instead of Long,I don't think this is the right place to do th
+9347,"@@ -10,7 +10,8 @@ class CartDecorator < Draper::Decorator
+   end
+
+   def approvals_by_status
+-    object.approvals.order(
++    # Override default scope
++    object.approvals.reorder(
+       # http://stackoverflow.com/a/6332081/358804
+       <<-SQL
+         CASE approvals.status",Had no idea that method existed!,Prefer double-quoted strings unless you need s
+9348,"@@ -38,6 +38,7 @@ class TestTabWidget:
+         qtbot.addWidget(w)
+         monkeypatch.setattr(tabwidget.objects, 'backend',
+                             usertypes.Backend.QtWebKit)
++        monkeypatch.setattr(w.tabBar(), 'width', w.width)
+         return w
+
+     @pytest.fixture","I wonder if we shouldn't just do `w.show()` here, which causes Qt to correctly calculate the sizes.","`monkeypatch.setattr(w.tabBar(), 'width', w.width)` should work here too."
+9349,"@@ -24,12 +24,14 @@ class SparkDataFrameS3StoragePlugin(TypeStoragePlugin):  # pylint: disable=no-in
+     @classmethod
+     def set_object(cls, object_store, obj, _context, _runtime_type, paths):
+         target_path = object_store.key_for_paths(paths)
+-        obj.write.parquet('s3a://' + target_path)
++        obj.write.parquet('s3a://' + object_store.bucket + '/' + target_path)
+         return target_path
+
+     @classmethod
+     def get_object(cls, object_store, context, _runtime_type, paths):
+-        return context.resources.spark.read.parquet('s3a://' + object_store.key_for_paths(paths))
++        return context.resources.spark.read.parquet(
++            's3a://' + object_store.bucket + '/' + object_store.key_for_paths(paths)
++        )
+
+
+ class SparkDataFrameFilesystemStoragePlugin(TypeStoragePlugin):  # pylint: disable=no-init",may be nice to have helper method to generate s3 paths rather than the minor code dup,is it `s3a://'` or `s3a://` ?
+9350,"@@ -169,11 +169,15 @@ export default Controller.extend(ValidationEngine, {
+     _oauthSetup() {
+         let blogTitle = this.get('blogTitle');
+         let config = this.get('config');
++        let promises = [];
++
++        promises.pushObject(this.get('settings').fetch());
++        promises.pushObject(this.get('config').fetchPrivate());
+
+         this.get('hasValidated').addObjects(['blogTitle', 'session']);
+
+         return this.validate().then(() => {
+-            return this.get('settings').fetch()
++            return RSVP.all(promises)
+                 .then((settings) => {
+                     settings.set('title', blogTitle);
+ ","This isn't needed here, we still run `this._afterAuthentication` which loads settings & config - the reason the settings fetch is here is to make sure we have all the settings before saving the blog title rather than fetching everything once auth has completed. Probably moot anyway as the oauth code will be removed shortly  ",why not use `this.settings.fetch()` directly?
+9351,"@@ -397,7 +397,7 @@ func assertConfigsCompatible(cfg1, cfg2 *Config) error {
+ 	if c1.ClientAuth != c2.ClientAuth {
+ 		return fmt.Errorf(""client authentication policy mismatch"")
+ 	}
+-	if c1.ClientAuth != tls.NoClientCert && c2.ClientAuth != tls.NoClientCert && c1.ClientCAs != c2.ClientCAs {
++	if c1.ClientAuth != tls.NoClientCert && c2.ClientAuth != tls.NoClientCert && !StringSliceEqual(cfg1.ClientCerts, cfg2.ClientCerts) {
+ 		// Two hosts defined on the same listener are not compatible if they
+ 		// have ClientAuth enabled, because there's no guarantee beyond the
+ 		// hostname which config will be used (because SNI only has server name).",This line is getting a little long; let's move the conditions to at least two lines (maybe three).,Why not just compare `c2.ClientAuth != tls.NoClientCert`?
+9352,"@@ -37,6 +37,10 @@
+
+ #include <fastdds/dds/log/Log.hpp>
+
++#include ""../../../../fastdds/core/policy/ParameterList.hpp""
++
++using ParameterList = eprosima::fastdds::dds::ParameterList;
++
+ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {",Don't use relative paths. src directory is already on the include search path,Why do you need this? ParameterList is already present in eprosima
+9353,"@@ -2,7 +2,7 @@ class Api::V1::CompletionsController < ApiController
+   before_action :doorkeeper_authorize!, if: lambda { !signed_in? }
+
+   def index
+-    respond_with current_resource_owner.completions.only_trail_object_ids
++    respond_with completions: current_resource_owner.completions.only_trail_object_ids
+   end
+
+   def create",Line is too long. [86/80],Metrics/LineLength: Line is too long. [82/80]
+9354,"@@ -4,6 +4,11 @@ describe 'TwitterDigits' do
+   let(:service_provider_url) { Faker::Internet.url }
+   let(:credentials) { ""oauth_consumer_key=#{ Faker::Internet.password }"" }
+
++  before do
++    original_twitter_digits_path = File.expand_path('../../../../app/lib/twitter_digits.rb', __FILE__)
++    load original_twitter_digits_path
++  end
++
+   it 'must return the id_str when response is 200' do
+     id_str = Faker::Internet.password
+     response = stub(code: '200', body: { id_str: id_str }.to_json)","We have to navigate up four directories to come down three? I see it, but it's kinda icky. Is something like `load Rails.root + 'app/lib/twitter_digits.rb'` out of fashion nowadays?","if we're just loading the file, do we still need the `before` bloc"
+9355,"@@ -208,6 +208,10 @@ int main(int argc, char *argv[]) {
+
+    res = fpgaDmaOpen(afc_h, &dma_h);
+    ON_ERR_GOTO(res, out_dma_close, ""fpgaDmaOpen"");
++   if(!dma_h) {
++      res = FPGA_EXCEPTION;
++      ON_ERR_GOTO(res, out_dma_close, ""Invaid DMA Handle"");
++   }
+
+    if(use_ase)
+       count = ASE_TEST_BUF_SIZE;",Empty space at end.,can this be `return FPGA_EXCEPTION;` instead?
+9356,"@@ -215,6 +215,7 @@ module Bolt
+     def with_bolt_executor(executor, inventory, pdb_client = nil, applicator = nil, &block)
+       setup
+       opts = {
++        bolt_project: @project,
+         bolt_executor: executor,
+         bolt_inventory: inventory,
+         bolt_pdb_client: pdb_client,",I think similar to line 176 here we'll want to call `detect_project_conflict` after overriding this.,"Same as above, do we need to pass in `@project` here? I don't see where it is used."
+9357,"@@ -1,7 +1,8 @@
+ const fs = require('fs')
+ const path = require('path')
+ const chalk = require('chalk')
+-const { exec } = require('child_process')
++const { spawn } = require('child_process')
++const readline = require('readline')
+ const YAML = require('js-yaml')
+ const { promisify } = require('util')
+ const gzipSize = require('gzip-size')",How about `const { promises: fs } = require('fs')` and then replacing `fs.promises.` with `fs.`?,This should be `const { exec } = require('child_process')`
+9358,"@@ -129,13 +129,9 @@ func getGithubData(ctx context.Context, url string) ([]byte, error) {
+ 		return nil, fmt.Errorf(""unexpected status %v (%v) returned"", res.StatusCode, res.Status)
+ 	}
+
+-	buf, err := ioutil.ReadAll(res.Body)
+-	if err != nil {
+-		_ = res.Body.Close()
+-		return nil, err
+-	}
++	defer res.Body.Close()
+
+-	err = res.Body.Close()
++	buf, err := ioutil.ReadAll(res.Body)
+ 	if err != nil {
+ 		return nil, err
+ 	}","This ignores errors closing the body. Not likely to happen, but no reason to take the risk either.",Shouldn't we close `res` here?
+9359,"@@ -73,7 +73,7 @@ public abstract class FlinkTestBase extends AbstractTestBase {
+   }
+
+   protected static TableResult exec(TableEnvironment env, String query, Object... args) {
+-    return env.executeSql(String.format(query, args));
++    return env.executeSql(args.length > 0 ? String.format(query, args) : query);
+   }
+
+   protected TableResult exec(String query, Object... args) {",Why was this change needed?,Should we log if there are arguments?
+9360,"@@ -259,6 +259,8 @@ namespace pwiz.Skyline
+             (c, p) => c.LockmassNegative = p.ValueDouble);
+         public static readonly Argument ARG_IMPORT_LOCKMASS_TOLERANCE = new DocArgument(@""import-lockmass-tolerance"", NUM_VALUE,
+             (c, p) => c.LockmassTolerance = p.ValueDouble);
++        public static readonly Argument ARG_IMPORT_PEAK_BOUNDARIES = new DocArgument(@""import-peak-boundaries"", PATH_TO_FILE,
++            (c, p) => c.ImportPeakBoundaries = p.ValueFullPath);
+
+         private static readonly ArgumentGroup GROUP_IMPORT = new ArgumentGroup(() => CommandArgUsage.CommandArgs_GROUP_IMPORT_Importing_results_replicates, false,
+             ARG_IMPORT_FILE, ARG_IMPORT_REPLICATE_NAME, ARG_IMPORT_OPTIMIZING, ARG_IMPORT_APPEND, ARG_IMPORT_ALL,",Needs a description added to CommandArgsUsage.resx,is this a valid change to existing code?
+9361,"@@ -153,7 +153,7 @@ public class DownloadServiceNotification {
+                 iconId = R.drawable.ic_notification_sync_error;
+                 intent = ClientConfig.downloadServiceCallbacks.getReportNotificationContentIntent(context);
+                 id = R.id.notification_download_report;
+-                content = String.format(context.getString(R.string.download_report_content), successfulDownloads, failedDownloads);
++                content = context.getResources().getQuantityString(R.plurals.download_report_content, successfulDownloads, successfulDownloads, failedDownloads);
+             }
+
+             NotificationCompat.Builder builder = new NotificationCompat.Builder(context, channelId);",The line is a bit too long. That's why the test currently fails. Please break it into two lines.,Could you please rename `successDownload
+9362,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,`caps` could be `null`
+9363,"@@ -1,4 +1,6 @@
+ module Ncr
++  START_OF_NEW_6X_APPROVAL_POLICY = Time.zone.local(2016, 7, 5, 0, 0, 0)
++
+   class ApprovalManager
+     def initialize(work_order)
+       @work_order = work_order",Can this just be a feature flag to check if it's on? This will give us flexibility on launch date (which could be turned on July 1st) and allow us to easily revert back in case the policy is reverted.,Do not use parentheses for method calls
+9364,"@@ -44,4 +44,5 @@ func (p Pin) Low() {
+
+ type ADC struct {
+ 	Pin Pin
++	Bus uint8
+ }","Due to this change, src/examples/adc needs to be modified",Does this need to be public?
+9365,"@@ -19,6 +19,12 @@ import (
+ 	""unsafe""
+ )
+
++// singlePointer wraps an unsafe.Pointer and supports basic
++// load(), store(), clear(), and swapNil() operations.
++type singlePtr struct {
++	ptr unsafe.Pointer
++}
++
+ func (l *sortedLabels) Len() int {
+ 	return len(*l)
+ }",`s/singlePointer/singlePtr` or please rename the type to `singlePointer`.,The name `singlePtr` is conf
+9366,"@@ -577,7 +577,8 @@ bool nano::node_config::upgrade_json (unsigned version_a, nano::jsonconfig & jso
+ 		}
+ 		case 17:
+ 		{
+-			json.put (""vote_generator_delay"", vote_generator_delay.count ()); // Update value
++			json.put (""active_elections_size"", 10000); // Update value
++			json.put (""vote_generator_delay"", 100); // Update value
+ 			json.put (""backup_before_upgrade"", backup_before_upgrade);
+ 			json.put (""work_watcher_period"", work_watcher_period.count ());
+ 		}",Do we need it? If right now it's toml,Why is 100 different from 10
+9367,"@@ -22,6 +22,16 @@ options._catchError = function(error, newVNode, oldVNode) {
+ 	oldCatchError(error, newVNode, oldVNode);
+ };
+
++const oldUnmount = options.unmount;
++options.unmount = function(vnode) {
++	/** @type {import('./internal').Component} */
++	const component = vnode._component;
++	if (component && component._onResolve) {
++		component._onResolve();
++	}
++	if (oldUnmount) oldUnmount(vnode);
++};
++
+ function detachedClone(vnode, detachedParent, parentDom) {
+ 	if (vnode) {
+ 		if (vnode._component && vnode._component.__hooks) {","You are never calling oldUnmount, this could lead to a plugin chain failing.",Should we use `options.unmou
+9368,"@@ -119,7 +119,9 @@ public class MetaUtils {
+         name = ""Table"" + tid;
+       }
+       return new TiTableInfo(
+-          tid, CIStr.newCIStr(name), """", """", pkHandle, columns, indices, """", 0, 0, 0, 0);
++          tid, CIStr.newCIStr(name), """", """", pkHandle, columns,
++          indices, """", 0, 0, 0
++          , 0, null);
+     }
+   }
+ ",What does setting partitionInfo to null mean exactly?,Please use a named constant instead of `null`.
+9369,"@@ -225,6 +225,18 @@ class BokehPlot(DimensionedPlot):
+                     source.data.update(converted_data)
+                 else:
+                     source.stream(data, stream.length)
++            return
++
++        # Determine if the CDS.data requires a full update or simply needs
++        # to be updated, this is done by determining whether newly added
++        # or not updated columns have the same length
++        new_length = [len(v) for v in data.values() if isinstance(v, (list, np.ndarray))]
++        length = [len(v) for v in source.data.values() if isinstance(v, (list, np.ndarray))]
++        not_updated = [k for k in source.data if k not in data]
++        new = [k for k in data if k not in source.data]
++        if ((not_updated and new_length and any(len(source.data[n]) != new_length[0] for n in not_updated))
++            or (new and length and any(len(data[n]) != length[0] for n in new))):
++            source.data = data
+         else:
+             source.data.update(data)
+ ",Not sure you need the initial ``not_updated`` as ``any([])`` evaluates to false.,@Eric89GXL @mluessi do we need to check `new`
+9370,"@@ -0,0 +1,13 @@
++class AddPublishedAtToVideos < ActiveRecord::Migration
++  def up
++    add_column :videos, :published_at, :datetime
++    execute <<-SQL
++      UPDATE videos
++      SET published_at = created_at
++    SQL
++  end
++
++  def down
++    remove_column :videos, :published_at
++  end
++end","Since this migration hasn't been merged to master yet, what do you think about just squashing these two into the migration you really want?",I don't think we need to add a whole new colum
+9371,"@@ -0,0 +1 @@
++BetterErrors.editor = :subl if defined? BetterErrors",This doesn't apply to all developers,Why does this need to be added?
+9372,"@@ -52,13 +52,16 @@ class SonataMediaExtension extends Extension
+         $loader->load('gaufrette.xml');
+         $loader->load('validators.xml');
+         $loader->load('serializer.xml');
+-        $loader->load('api_form.xml');
+-
++
+         $bundles = $container->getParameter('kernel.bundles');
+
+         if ('doctrine_orm' == $config['db_driver'] && isset($bundles['FOSRestBundle']) && isset($bundles['NelmioApiDocBundle'])) {
+             $loader->load('api_controllers.xml');
+         }
++
++        if (isset($bundles['JMSSerializerBundle'])) {
++            $loader->load('api_form.xml');
++        }
+
+         if (isset($bundles['SonataNotificationBundle'])) {
+             $loader->load('consumer.xml');",I think `serializer.xml` can be moved into condition below too,Shouldn't it be `api_form.xml` as well?
+9373,"@@ -21,6 +21,9 @@ namespace Benchmarks
+     {
+         public static void Main(string[] args)
+         {
++            // examples to run from command line:
++            // navigate to opentelemetry-dotnet\src\benchmarks directory and run the following
++            // dotnet run --framework netcoreapp3.1 --configuration Release --filter *OpenTelemetrySdkBenchmarksActivity*
+             BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+         }
+     }",Probably put this in a simple README.md file?,Do we want this to be configurable?
+9374,"@@ -0,0 +1,18 @@
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT License. See License.txt in the project root for license information.
++
++using System;
++using System.Collections.Generic;
++using System.Linq;
++using System.Threading.Tasks;
++
++namespace AutoRest.Core.Validation
++{
++    [Flags]
++    public enum ValidationCategory
++    {
++        RPCViolation    = 1 << 0,
++        OneAPIViolation = 1 << 1,
++        SDKViolation    = 1 << 2,
++    }
++}","Super Cool bitwise   Minor: Most likely you don't need `System.Collections.Generic`, `System.Linq` & `System.Threading.Tasks`",@johnsimons do we want these to be part
+9375,"@@ -20,7 +20,7 @@ public class DefaultMicroserviceClassLoaderFactory implements MicroserviceClassL
+   public static final MicroserviceClassLoaderFactory INSTANCE = new DefaultMicroserviceClassLoaderFactory();
+
+   @Override
+-  public ClassLoader create(String microserviceName, String version) {
++  public ClassLoader create(String appId, String microserviceName, String version) {
+     return Thread.currentThread().getContextClassLoader();
+   }
+ }","If we just return the TCC, maybe we need to update the method name for it.",can we make this `appId` parameter opti
+9376,"@@ -111,8 +111,7 @@ namespace AutoRest.Extensions
+             if (methodList.Count == 1)
+             {
+                 Method method = methodList.Single();
+-                return string.Format(CultureInfo.InvariantCulture, ""Additional parameters for the {0} operation."",
+-                    createOperationDisplayString(method.MethodGroup.Name.ToPascalCase(), method.Name));
++                return string.Format(CultureInfo.InvariantCulture, ""Additional parameters for {0} operation."", method.Name);
+             }
+             else if (methodList.Count <= 4)
+             {","For consistency, shouldn't this use `SwaggerModeler.GetMethodNameFromOperationId(method.Name)` as above? I'd just reuse `""Additional parameters for "" + SwaggerModeler.GetMethodNameFromOperationId(method.Name) + "" operation.""` here, `string.Format` with `CultureInfo` is complete nonsense here anyways.",Is this change intentional? It looks like the result is the same on both places.
+9377,"@@ -32,7 +32,7 @@ TEST(LivelinessQos, Liveliness_Automatic_Reliable)
+     // Liveliness lease duration and announcement period
+     uint32_t liveliness_ms = 200;
+     Duration_t liveliness_s(liveliness_ms * 1e-3);
+-    Duration_t announcement_period(liveliness_ms * 1e-3 * 0.5);
++    Duration_t announcement_period(liveliness_ms * 1e-3 * 0.01);
+
+     reader.reliability(RELIABLE_RELIABILITY_QOS)
+             .liveliness_kind(AUTOMATIC_LIVELINESS_QOS)","As this is just a backport, I guess it is fine to leave these timings, although they are not enough to make tests stable.","I'm not sure why you changed the announcement period from 0.5 to 1e-3, seems lik"
+9378,"@@ -70,8 +70,8 @@ func New(p client.ConfigProvider, cfgs ...*aws.Config) *ECS {
+
+ // newClient creates, initializes and returns a new service client instance.
+ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegion, signingName string) *ECS {
+-	if signingName == """" {
+-		signingName = ServiceName
++	if len(signingName) == 0 {
++		signingName = ""ecs""
+ 	}
+ 	svc := &ECS{
+ 		Client: client.New(",Why this way?,"If we use `ecs` as the default signing name, we can remove this check."
+9379,"@@ -38,10 +38,7 @@ const (
+ func setupEnvironment(t *testing.T) string {
+ 	t.Helper()
+ 	// TODO(shahms): ExtractCompilations should take an output path.
+-	output := os.Getenv(""TEST_TMPDIR"")
+-	if output == """" {
+-		t.Skip(""Skipping test due to incompatible environment (missing TEST_TMPDIR)"")
+-	}
++	output := t.TempDir()
+ 	if err := os.Setenv(""KYTHE_OUTPUT_DIRECTORY"", output); err != nil {
+ 		t.Fatalf(""Error setting KYTHE_OUTPUT_DIRECTORY: %v"", err)
+ 	}",Changing this because otherwise the second run of testExtractCompilationsEndToEndWithDatabase will try to overwrite a generated file and fail. Maybe there's a better way?,"If this is no longer required, can we remove it?"
+9380,"@@ -90,6 +90,9 @@ public final class HttpUtils {
+    * @return the encoded path param
+    */
+   public static String encodePathParam(String pathParam) {
++    if (pathParam.indexOf(';') != -1) {
++      pathParam = pathParam.substring(0, pathParam.indexOf(';'));
++    }
+     return UrlEscapers.urlPathSegmentEscaper().escape(pathParam);
+   }
+ ",This modification is not correct. Suggections: 1. upgread guava to 30.0-jre will fix this issue,Is this a bug? Shouldn't it be fixed in a separate PR?
+9381,"@@ -17,8 +17,8 @@ type syscalls struct {
+ var _ specsruntime.Syscalls = (*syscalls)(nil)
+
+ // VerifySignature implements Syscalls.
+-func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) bool {
+-	return crypto.IsValidSignature(plaintext, signer, signature)
++func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) error {
++	return crypto.ValidateSignature(plaintext, signer, signature)
+ }
+
+ // HashBlake2b implements Syscalls.",All changes to signature code stem from here. The syscalls interfaces expects VerifySignature to return an error. I performed the change here and bubbled it up through the rest of the code - mostly mechanical.,Shouldn't this return error now?
+9382,"@@ -77,15 +77,12 @@ public final class InMemoryStorage extends StorageComponent implements SpanStore
+     int maxSpanCount = 500000;
+     List<String> autocompleteKeys = Collections.emptyList();
+
+-    /** {@inheritDoc} */
+-    @Override
+-    public Builder strictTraceId(boolean strictTraceId) {
++    @Override public Builder strictTraceId(boolean strictTraceId) {
+       this.strictTraceId = strictTraceId;
+       return this;
+     }
+
+-    @Override
+-    public Builder searchEnabled(boolean searchEnabled) {
++    @Override public Builder searchEnabled(boolean searchEnabled) {
+       this.searchEnabled = searchEnabled;
+       return this;
+     }","This strategy seems good. Just wondering do you think this is a good time to move stuff out of core? For example, I guess storage, since it's for use by server and not client, doesn't need to be Java 6?",what does this change have to do with this PR?
+9383,"@@ -283,7 +283,8 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+       return new Stats(0L, 0L);
+     }
+
+-    if (filterExpressions == null || filterExpressions == Expressions.alwaysTrue()) {
++    // estimate stats using snapshot summary only for partitioned tables (metadata tables are unpartitioned)
++    if (table.spec().fields().size() > 0 && filterExpression() == Expressions.alwaysTrue()) {
+       long totalRecords = PropertyUtil.propertyAsLong(table.currentSnapshot().summary(),
+           SnapshotSummary.TOTAL_RECORDS_PROP, Long.MAX_VALUE);
+       return new Stats(SparkSchemaUtil.estimateSize(lazyType(), totalRecords), totalRecords);",We had a wrong predicate before: we compared a list to an expression.,should this be `!= 0`?
+9384,"@@ -21,6 +21,13 @@ func Test_acl_decode(t *testing.T) {
+ 			},
+ 			want: ""user::rw-\nuser:0:rwx\nuser:65534:rwx\ngroup::rwx\nmask::rwx\nother::r--\n"",
+ 		},
++		{
++			name: ""decode group"",
++			args: args{
++				xattr: []byte{2, 0, 0, 0, 8, 0, 1, 0, 254, 255, 0, 0},
++			},
++			want: ""group:65534:--x\n"",
++		},
+ 		{
+ 			name: ""decode fail"",
+ 			args: args{","Name copy-pasted from above. ""empty""?","decode group should be exactly the same as user, right?"
+9385,"@@ -98,7 +98,7 @@ class Bottle2neck(_Bottleneck):
+         self.stage_type = stage_type
+         self.scales = scales
+         self.width = width
+-        delattr(self, 'conv2')
++        # delattr(self, 'conv2')
+         delattr(self, self.norm2_name)
+
+     def forward(self, x):",May I ask why change this?,Revert changes to this file?
+9386,"@@ -23,15 +23,7 @@ namespace Datadog.Trace.Agent.MessagePack
+                 len++;
+             }
+
+-            if (value.Tags != null)
+-            {
+-                len++;
+-            }
+-
+-            if (value.Metrics != null)
+-            {
+-                len++;
+-            }
++            len += 2; // Tags and metrics
+
+             int originalOffset = offset;
+ ","Does this mean we now always include the dictionaries even if they're empty? If so, we should make sure that this doesn't break the Agent (even older versions). It's possible that it doesn't handle empty dictionaries well.",@tarekgh I'm not sure if this change is OK or not. @joh
+9387,"@@ -29,6 +29,9 @@ namespace Nethermind.Blockchain
+         [ConfigItem(Description = ""If set to 'true' then the Fast Sync (eth/63) synchronization algorithm will be used."", DefaultValue = ""false"")]
+         bool FastSync { get; set; }
+
++        [ConfigItem(Description = ""Relevant only if 'FastSync' is 'true'. If set to value, then it will set a minimum height threshold limit up to witch Full Sync will stay on when chain will be behind network."", DefaultValue = ""null"")]
++        long? FastSyncCatchUpHeightDelta { get; set; }
++
+         [ConfigItem(Description = ""If set to 'true' then in the Fast Sync mode blocks will be first downloaded from the provided PivotNumber downwards. This allows for parallelization of requests with many sync peers and with no need to worry about syncing a valid branch (syncing downwards to 0). You need to enter the pivot block number, hash and total difficulty from a trusted source (you can use etherscan and confirm with other sources if you wan to change it)."", DefaultValue = ""false"")]
+         bool FastBlocks { get; set; }
+         ",The description and name is unclear. Typo in 'which'.,I don't think we should add a property for this. We sho
+9388,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.,"Unused method argument - username. If it's necessary, use _ or _username as an argument name to indicate that it won't be used."
+9389,"@@ -74,6 +74,12 @@ proc_num_simd_saved(void)
+     return num_simd_saved;
+ }
+
++void
++proc_set_num_simd_saved(int num)
++{
++    num_simd_saved = num;
++}
++
+ DR_API
+ int
+ proc_num_simd_registers(void)","> i#1312 AVX-512 support: Add code cache to/from context switching. s|to/from|| (redundant and mildly confusing (called ""enter"" and ""return"" in code)).",Does this really need to be public?
+9390,"@@ -521,10 +521,10 @@ void dag_to_cyto(struct dag *d, int condense_display, int change_size)
+ 	fprintf(cytograph, ""\t<att name = \""layoutAlgorithm\"" value = \""Grid Layout\"" type = \""string\"" cy:hidden = \""1\""/>\n"");
+
+ 	if(change_size) {
+-		hash_table_firstkey(d->completed_files);
+-		while(hash_table_nextkey(d->completed_files, &label, (void **) &name)) {
+-			stat(label, &st);
+-			average += ((double) st.st_size) / ((double) hash_table_size(d->completed_files));
++		hash_table_firstkey(d->files);
++		while(hash_table_nextkey(d->files, &name, (void **) &f) && dag_file_exists(f)) {
++			stat(name, &st);
++			average += ((double) st.st_size) / ((double) d->completed_files);
+ 		}
+ 	}
+ ","This stat may fail, right? I think dag_file_exists does not actually check the file is there.","Can't this just be `hash_table_nextkey(d->files, &name, &st)`?"
+9391,"@@ -16,7 +16,11 @@ describe('Options Validation', function() {
+     });
+
+     const testObject = { a: 1 };
+-    const validatedObject = objectValidator(testObject, { validationLevel: testValidationLevel });
++    const validatedObject = objectValidator(
++      testObject,
++      {},
++      { validationLevel: testValidationLevel }
++    );
+
+     expect(validatedObject).to.deep.equal({ a: 1 });
+     expect(validatedObject).to.be.frozen;","I think we can make a safe assumption that if only two values are passed in then you have `(optionsToValidate, optionsForValidation)`, if its three then you have `(optionsToValidate, overrideOptions, optionsForValidation)`",Is this part of your PR or is it unrelated?
+9392,"@@ -141,12 +141,14 @@ func runExperimentalBeamPipeline(ctx context.Context) error {
+ 	entries := beamio.ReadEntries(s, *entriesFile)
+ 	k := pipeline.FromEntries(s, entries)
+ 	shards := 8 // TODO(schroederc): better determine number of shards
++	edgeSets, edgePages := k.Edges()
+ 	xrefSets, xrefPages := k.CrossReferences()
+ 	beamio.WriteLevelDB(s, *tablePath, shards,
+ 		k.CorpusRoots(),
+ 		k.Directories(),
+ 		k.Decorations(),
+ 		xrefSets, xrefPages,
++		edgeSets, edgePages,
+ 	)
+ 	return beamx.Run(ctx, p)
+ }","If there are more items to add to what's being written out here, please add a TODO.","edgeSets, edgePages = k.Edges()"
+9393,"@@ -106,8 +106,12 @@ class SuperSocket(six.with_metaclass(_SuperSocket_metaclass)):
+                         pkt = pkt[:12] + tag + pkt[12:]
+                 elif cmsg_lvl == socket.SOL_SOCKET and \
+                         cmsg_type == SO_TIMESTAMPNS:
+-                    tmp = struct.unpack(""iiii"", cmsg_data)
+-                    timestamp = tmp[0] + tmp[2] * 1e-9
++                    length = len(cmsg_data)
++                    if length == 16:  # __kernel_timespec
++                        tmp = struct.unpack(""ll"", cmsg_data)
++                    elif length == 8:  # timespec
++                        tmp = struct.unpack(""ii"", cmsg_data)
++                    timestamp = tmp[0] + tmp[1] * 1e-9
+             return pkt, sa_ll, timestamp
+
+     def recv_raw(self, x=MTU):",Can you add an `else:` case to handle an invalid length? That will prevent weird errors.,looks like there's some whitesp
+9394,"@@ -9,14 +9,10 @@ public class ASTAttribute extends AbstractJspNode {
+
+     private String name;
+
+-    public ASTAttribute(int id) {
++    ASTAttribute(int id) {
+         super(id);
+     }
+
+-    public ASTAttribute(JspParser p, int id) {
+-        super(p, id);
+-    }
+-
+     /**
+      * @return Returns the name.
+      */",* We need to deprecate/internalize first on master. * We should directly make the AST node final now * The setter `setName()` can be package-private.,Why is this no longer needed?
+9395,"@@ -137,12 +137,6 @@ public class InitCodeTransformer {
+       // Remove the request object for flattened method
+       orderedItems.remove(orderedItems.size() - 1);
+     }
+-    for (InitCodeNode param :
+-        sampleFuncParams(
+-            root, initCodeContext.sampleArgStrings(), initCodeContext.sampleParamConfigMap())) {
+-      List<InitCodeNode> paramInits = param.listInInitializationOrder();
+-      orderedItems.removeAll(paramInits);
+-    }
+     return orderedItems;
+   }
+ ",Where did this functionality move to?,What is the difference between
+9396,"@@ -68,6 +68,19 @@ public class TiDBJDBCClient implements AutoCloseable {
+     }
+   }
+
++  // SPLIT TABLE table_name [INDEX index_name] BETWEEN (lower_value) AND (upper_value) REGIONS
++  // region_num
++  public boolean splitTableRegion(
++      String dbName, String tblName, long minVal, long maxVal, long regionNum) throws SQLException {
++    try (Statement tidbStmt = connection.createStatement()) {
++      String sql =
++          String.format(
++              ""split table %s.%s between (%d) and (%d) regions %d"",
++              dbName, tblName, minVal, maxVal, regionNum);
++      return tidbStmt.execute(sql);
++    }
++  }
++
+   public boolean isClosed() throws SQLException {
+     return connection.isClosed();
+   }",maybe should firstly check whether current tidb support `split table region`?,How about `splitTableRegions`?
+9397,"@@ -27,7 +27,8 @@ import { Fragment } from '@wordpress/element';
+ import Data from 'googlesitekit-data';
+ import Logo from './Logo';
+ import UserMenu from './UserMenu';
+-import ErrorNotification from '../components/notifications/error-notification';
++import LegacyErrorNotification from './legacy-notifications/error-notification';
++import ErrorNotification from './notifications/ErrorNotifications';
+ import { STORE_NAME as CORE_USER } from '../googlesitekit/datastore/user/constants';
+ const { useSelect } = Data;
+ ",Please use the same (plural) name for the new component since it renders multiple notifications.,Why did you change the import
+9398,"@@ -466,6 +466,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
+ 				}
+ 				if attemptsCount <= uint64(cs.config.CatchupBlockDownloadRetryAttempts) {
+ 					// try again.
++					cs.log.Infof(""Failed to download block %d. %v"", topBlock.Round()-basics.Round(blocksFetched), err)
+ 					continue
+ 				}
+ 				return cs.abort(fmt.Errorf(""processStageBlocksDownload failed after multiple blocks download attempts""))",Perhaps show attempt x of y in message ie: Failed to download block %d (attempt %d of %d). %v,I don't think this log line is
+9399,"@@ -94,8 +94,7 @@ public class PrivateTransactionHandler {
+     }
+   }
+
+-  public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction)
+-      throws Exception {
++  public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction) {
+     if (privateTransaction.getPrivacyGroupId().isPresent()) {
+       return BytesValues.asBase64String(privateTransaction.getPrivacyGroupId().get());
+     }",why did you took `Exception` out? Is this method only throwing runtime exceptions?,We shouldn't remove the `throw
+9400,"@@ -1,9 +1,7 @@
+ # coding: utf-8
+ """"""Comparison of `binary` and `xentropy` objectives.
+-
+ BLUF: The `xentropy` objective does logistic regression and generalizes
+ to the case where labels are probabilistic (i.e. numbers between 0 and 1).
+-
+ Details: Both `binary` and `xentropy` minimize the log loss and use
+ `boost_from_average = TRUE` by default. Possibly the only difference
+ between them with default settings is that `binary` may achieve a slight",please revert all of these unrelated whitespace changes,Please don't remove or remove these blank lines.
+9401,"@@ -0,0 +1,15 @@
++package com.fsck.k9.mail;
++
++/**
++ * Enumeration of the different possible encryption protocol that can be used.
++ */
++public enum EncryptionType {
++
++    NONE,
++
++    INLINE,
++
++    PGP_MIME,
++
++    S_MIME
++}",PGP_INLINE is clearer IMHO,Is there a reason to use enums here instead of p
+9402,"@@ -16,6 +16,8 @@ import (
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/require""
+
++	""context""
++
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/action""
+ 	""github.com/iotexproject/iotex-core/config""",Please group imports,did you mean to include this in this PR?
+9403,"@@ -102,7 +102,7 @@ public class TestHiveMetastore {
+         .transportFactory(new TTransportFactory())
+         .protocolFactory(new TBinaryProtocol.Factory())
+         .minWorkerThreads(3)
+-        .maxWorkerThreads(5);
++        .maxWorkerThreads(10);
+
+     return new TThreadPoolServer(args);
+   }",Would it make sense to expose this as a config option in `TestHiveMetastore`? A small number of worker threads helped us to catch a few connection leaks early on.,is this related to this PR?
+9404,"@@ -10,9 +10,12 @@ void im2col_cpu(const Dtype* data_im, const int channels,
+     const int height, const int width, const int kernel_h, const int kernel_w,
+     const int pad_h, const int pad_w,
+     const int stride_h, const int stride_w,
++    const int dilation_h, const int dilation_w,
+     Dtype* data_col) {
+-  const int height_col = (height + 2 * pad_h - kernel_h) / stride_h + 1;
+-  const int width_col = (width + 2 * pad_w - kernel_w) / stride_w + 1;
++  const int height_col = (height + 2 * pad_h -
++      (dilation_h * (kernel_h - 1)  + 1)) / stride_h + 1;
++  const int width_col = (width + 2 * pad_w -
++      (dilation_w * (kernel_w - 1)  + 1)) / stride_w + 1;
+   const int channels_col = channels * kernel_h * kernel_w;
+   for (int c_col = 0; c_col < channels_col; ++c_col) {
+     int w_offset = c_col % kernel_w;",Let's fix the extra spaces above.,Looks like stride_w is always 2.
+9405,"@@ -27,7 +27,7 @@ public interface SearchContext {
+    * @return A list of all {@link WebElement}s, or an empty list if nothing matches
+    * @see org.openqa.selenium.By
+    */
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+
+
+   /**",should a similar change be done for findElement?,"Unrelated to this PR, but should"
+9406,"@@ -15,11 +15,17 @@ import (
+
+ var _ keystore.Service = (*Service)(nil)
+
++// Service is the memory-based keystore.Service implementation.
++//
++// Keys are stored in the in-memory map, where the key is the name of the
++// private key, and value is structure where actual private key and password are
++// stored.
+ type Service struct {
+ 	m  map[string]key
+ 	mu sync.Mutex
+ }
+
++// New creates new memory-based keystore.Service implementation.
+ func New() *Service {
+ 	return &Service{
+ 		m: make(map[string]key),","// Keys are stored in an in-memory map, where the key is the name of the // private key, and the value is the structure where the actual private key and the password are // stored.",Consider making this a `map[stri
+9407,"@@ -59,6 +59,9 @@ var _ = duck.VerifyType(&PullSubscription{}, &duckv1.Conditions{})
+
+ // PullSubscriptionSpec defines the desired state of the PullSubscription.
+ type PullSubscriptionSpec struct {
++	// This brings in CloudEventOverrides and Sink.
++	duckv1.SourceSpec
++
+ 	// Secret is the credential to use to create and poll the PullSubscription
+ 	// Subscription. The value of the secret entry must be a service account
+ 	// key in the JSON format (see https://cloud.google.com/iam/docs/creating-managing-service-account-keys).",I think this needs a json inline tag here,SourceSpec has been added in v1b
+9408,"@@ -510,7 +510,7 @@ string t_erl_generator::render_member_type(t_field * field) {
+   } else if (type->is_struct() || type->is_xception()) {
+     return ""#"" + uncapitalize(type->get_name()) + ""{}"";
+   } else if (type->is_map()) {
+-    return ""dict()"";
++    return ""dict:dict()"";
+   } else if (type->is_set()) {
+     return ""set()"";
+   } else if (type->is_list()) {","Hi @cjimison good point but doesn't this break the compatibility with Erlang/OTP prior to 17.0? I think this could be done over an conditional macro defined in the rebar.config: `{erl_opts, [ {platform_define, ""^R"", pre17} ]}` and some additions with `-ifdef(pre17). ... -else. ... -endif.`","Not sure what this is doing but if the type is a dict, the string should be `dict:dict`"
+9409,"@@ -210,7 +210,7 @@ func (pl *List) removeFromUnavailablePeers(p peer.Peer) {
+
+ // Choose selects the next available peer in the round robin
+ func (pl *List) Choose(ctx context.Context, req *transport.Request) (peer.Peer, func(error), error) {
+-	if !pl.IsRunning() {
++	if err := pl.once.WaitForStart(ctx); err != nil {
+ 		return nil, nil, peer.ErrPeerListNotStarted(""RoundRobinList"")
+ 	}
+ ",should we change/wrap the error?,why do we need to wait for the round robin to start before we start the round robin?
+9410,"@@ -109,12 +109,12 @@ final class DeFramer extends ByteToMessageDecoder {
+         try {
+           peerInfo = HelloMessage.readFrom(message).getPeerInfo();
+         } catch (final RLPException e) {
+-          LOG.debug(""Received invalid HELLO message"", e);
++          LOG.warn(""Received invalid HELLO message, set log level to TRACE for message body"", e);
+           connectFuture.completeExceptionally(e);
+           ctx.close();
+           return;
+         }
+-        LOG.debug(""Received HELLO message: {}"", peerInfo);
++        LOG.trace(""Received HELLO message: {}"", peerInfo);
+         if (peerInfo.getVersion() >= 5) {
+           LOG.trace(""Enable compression for p2pVersion: {}"", peerInfo.getVersion());
+           framer.enableCompression();",Are we sure that passing this log in warning does not risk spamming the logs of a node running on the mainnet or on ropsten etc ? Do we often receive invalid messages of this type ?,Set log level to TRACE here too.
+9411,"@@ -397,10 +397,7 @@ class Parser
+     # check for option to find list item text only
+     # if skipped a line, assume a list continuation was
+     # used and block content is acceptable
+-    if (text_only = options[:text]) && skipped > 0
+-      options.delete(:text)
+-      text_only = false
+-    end
++    text_only = is_text_only(options, skipped)
+
+     parse_metadata = options.fetch(:parse_metadata, true)
+     #parse_sections = options.fetch(:parse_sections, false)",I'd like to avoid a method call here atm since this is an extremely hot line in the code.,Style/UnneededInterpolation: Prefer to_s over string interpolation.
+9412,"@@ -421,8 +421,7 @@ def parse_input(vds):
+
+ def parse_witness(vds):
+     n = vds.read_compact_size()
+-    for i in range(n):
+-        x = vds.read_bytes(vds.read_compact_size())
++    return list(vds.read_bytes(vds.read_compact_size()).encode('hex') for i in xrange(n))
+
+ def parse_output(vds, i):
+     d = {}",Is this a bugfix?,"I think we should convert whole block to bytes before passing it to `read_bytes`. If we do that, we will get an error if the block is too long."
+9413,"@@ -35,7 +35,6 @@ namespace Microsoft.DotNet.Build.Tasks
+                 GlobalPackagesFolder = PackagesDir,
+
+                 Sources = new List<string>(),
+-                FallbackSources = new List<string>(),
+                 CacheContext = new SourceCacheContext(),
+                 RequestProviders = new List<IRestoreRequestProvider>
+                 {",Is this a relevant change?,Should this maybe be `new ArrayList<string>()`?
+9414,"@@ -62,9 +62,9 @@ public final class JUnit5RuleUsage extends BugChecker implements BugChecker.Clas
+     }
+
+     static Matcher<ClassTree> hasVariable(Matcher<VariableTree> matcher) {
+-        return (classTree, state) -> classTree.getMembers().stream()
+-                .filter(tree -> tree instanceof VariableTree)
+-                .anyMatch(tree -> matcher.matches((VariableTree) tree, state));
++        return (classTree, state) ->
++                classTree.getMembers().stream().filter(tree -> tree instanceof VariableTree).anyMatch(tree ->
++                        matcher.matches((VariableTree) tree, state));
+     }
+
+     static Matcher<VariableTree> hasAnnotationOnVariable(String annotation) {",@dansanduleac what do you think of this one? dots were aligned and no longer are  ,Please don't make unrelated changes in your PR.
+9415,"@@ -738,10 +738,6 @@ function deleteAllAppData(appId, fromAppDelete, params, app) {
+             }, deleteEvents);
+         }
+     });
+-
+-    if (fromAppDelete) {
+-        common.db.collection('graph_notes').remove({'_id': common.db.ObjectID(appId)}, function() {});
+-    }
+ }
+
+ /**",Why we dont delete app specific notes when app is deleted?,why is this removed?
+9416,"@@ -113,9 +113,17 @@ public class ConfigBuilderPlugin extends PluginBase {
+         pluginList = MainApp.getPluginsList();
+         upgradeSettings();
+         loadSettings();
++        setAlwaysEnabledPluginsEnabled();
+         MainApp.bus().post(new EventAppInitialized());
+     }
+
++    private void setAlwaysEnabledPluginsEnabled() {
++        for (PluginBase plugin : pluginList) {
++            if (plugin.pluginDescription.alwaysEnabled) plugin.setPluginEnabled(plugin.getType(), true);
++        }
++        storeSettings(""setAlwaysEnabledPluginsEnabled"");
++    }
++
+     public void storeSettings(String from) {
+         if (pluginList != null) {
+             if (Config.logPrefsChange)","The _OverviewPlugin_ is forcefully enabled without the option to disable it, using _PluginDescription.alwaysEnabled_. That should also work for this plugin?","This should be stored in the settings file, not in the settings table."
+9417,"@@ -220,6 +220,8 @@ public class SearchFields {
+      * i.e. ""Unpublished"", ""Draft"" (multivalued)
+      */
+     public static final String PUBLICATION_STATUS = ""publicationStatus"";
++
++    public static final String EXTERNAL_STATUS = ""externalStatus"";
+     /**
+      * @todo reconcile different with Solr schema.xml where type is Long rather
+      * than String.",Can you facet on this new externalStatus Solr field?,Why is this not in Saleor 2.0? Wouldn't be better to have it in one of
+9418,"@@ -132,11 +132,14 @@ module Blacklight
+     end
+
+     def filters
+-      @filters ||= blacklight_config.facet_fields.each_value.map do |value|
+-        f = filter(value)
+-
+-        f if f.any?
+-      end.compact
++      @filters ||= blacklight_config.facet_fields.each_value.reduce([]) do |acc, value|
++        if value.pivot
++          acc + value.pivot.map { |v| value.class.new(key: v) }
++                     .map { |f| filter(f) }.select(&:any?)
++        else
++          acc + Array(filter(value)).select(&:any?)
++        end
++      end
+     end
+
+     def filter(field_key_or_field)","I wonder if it would it make sense to push the pivot facet handling down into `FilterField` (or maybe a subclass, `PivotFilterField`?)?",`Array(filter(value))` is the same as `Array(filter(value)).map(&:any?
+9419,"@@ -47,7 +47,12 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction
+       end
+
+       begin
+-        result = func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true)
++        func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true)
++        # If the plan returns using a return statement then we never get here.
++        # We only get here if the plan finishes without executing any return
++        # statement and since we don't want to leak any implicit return value
++        # from the plan we simply set the result to nil here.
++        result = nil
+       rescue Puppet::PreformattedError => err
+         if named_args['_catch_errors'] && err.cause.is_a?(Bolt::Error)
+           result = err.cause.to_puppet_error",Ah I see what you were saying about making it harder to validate types. We'll have to catch the return for that.,"Ah, sorry this is my bad. The plan calls `call_by_name_with_scope` alr"
+9420,"@@ -86,6 +86,7 @@ public abstract class BaseActivity extends AppCompatActivity implements BottomNa
+                         .setTarget(nav_cam)
+                         .setDismissText(getResources().getString(R.string.ok_button))
+                         .setContentText(getResources().getString(R.string.camera_button))
++                        .hideOnTouchOutside()
+                         .build()
+         );
+ ",Try using using `.setDismissOnTouch(true)` instead,Move this to the `setTarget()` method
+9421,"@@ -122,6 +122,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+                 }
+                 catch (Exception ex)
+                 {
++                    if (scope != null)
++                    {
++                        // some fields aren't set till after execution, so populate anything missing
++                        UpdateSpan(controllerContext, scope.Span);
++                    }
++
+                     scope?.Span.SetException(ex);
+                     throw;
+                 }","Zach, is `UpdateSpan` of concern too? I see that it is called from `ExecuteAsyncInternal`.",This is a change in behavior. Previou
+9422,"@@ -26,7 +26,9 @@ import org.apache.iceberg.types.Type;
+ import org.apache.iceberg.types.Types;
+ import org.apache.orc.TypeDescription;
+
+-public class TypeConversion {
++public final class TypeConversion {
++
++  private TypeConversion() {}
+
+   /**
+    * Convert a given Iceberg schema to ORC.",Nit: its scope can be reduced to package default,do we still need this?
+9423,"@@ -15,5 +15,7 @@ namespace Microsoft.AspNetCore.Protocols.Features
+         PipeScheduler InputWriterScheduler { get; }
+
+         PipeScheduler OutputReaderScheduler { get; }
++
++        PipeScheduler ApplicationScheduler { get; set; }
+     }
+ }",Why is this get;set;?,Why is this a property? I don't see i
+9424,"@@ -77,6 +77,9 @@ bool StatefulReader::matched_writer_add(RemoteWriterAttributes& wdata)
+
+     getRTPSParticipant()->createSenderResources(wdata.endpoint.remoteLocatorList, false);
+
++
++    wdata.endpoint.unicastLocatorList =
++        mp_RTPSParticipant->network_factory().ShrinkLocatorLists({wdata.endpoint.unicastLocatorList});
+     WriterProxy* wp = new WriterProxy(wdata, this);
+
+     wp->mp_initialAcknack->restart_timer();",Should we also create sender resources for unicast locators? Should we make a similar change on StatelessReader?,Can you do this only for RTPS senders?
+9425,"@@ -130,7 +130,7 @@ namespace Datadog.Trace.RuntimeMetrics
+                 // Catching error UnauthorizedAccessException: Access to the registry key 'Global' is denied.
+                 // The 'Global' part seems consistent across localizations
+
+-                Log.Error(ex, ""The process does not have sufficient permissions to read performance counters. Please refer to https://docs.datadoghq.com/tracing/runtime_metrics/dotnet/#additional-permissions-for-iis to learn how to grant those permissions."");
++                Log.Error(ex, ""The process does not have sufficient permissions to read performance counters. Please refer to https://dtdg.co/net-runtime-metrics to learn how to grant those permissions."");
+                 throw;
+             }
+             catch (Exception ex)",Can we use `dotnet` instead of `net`?,Why is this being changed?
+9426,"@@ -372,6 +372,13 @@ namespace Datadog.Trace
+             return StartSpan(operationName, tags: null, parent, serviceName, startTime, ignoreActiveScope, spanId: null);
+         }
+
++        /// <summary>
++        /// Forces the tracer to immediately flush pending traces and send them to the agent.
++        /// To be called when the appdomain or the process is about to be killed in a non-graceful way.
++        /// </summary>
++        /// <returns>Task used to track the async flush operation</returns>
++        public Task ForceFlush() => FlushAsync();
++
+         /// <summary>
+         /// Writes the specified <see cref=""Span""/> collection to the agent writer.
+         /// </summary>",Should this be `ForceFlushAsync`? Given we have the `async` suffix elsewhere.,How does this interact with `StartSpan
+9427,"@@ -48,8 +48,8 @@ class TestJMeterExecutor(BZTestCase):
+         self.obj = get_jmeter()
+
+     def tearDown(self):
+-        if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx):
+-            os.remove(self.obj.modified_jmx)
++        # if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx):
++        #     os.remove(self.obj.modified_jmx)
+         super(TestJMeterExecutor, self).tearDown()
+
+     def configure(self, config):",Is this change intentional?,I think this can be removed.
+9428,"@@ -55,10 +55,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+
+             if (nativeOffset != -1)
+             {
+-                stackFrame.Properties = new Dictionary<string, string>
+-                {
+-                    { ""NativeOffset"", nativeOffset.ToString(CultureInfo.InvariantCulture) }
+-                };
++                stackFrame.SetProperty(""NativeOffset"", nativeOffset.ToString(CultureInfo.InvariantCulture));
+             }
+
+             return stackFrame;",This could be an integer property if we supported explicitly setting non-string-valued properties.,">SetProperty [](start = 15, length = 12) why do we need to set the property here?"
+9429,"@@ -14,8 +14,7 @@ use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
+ class RouteCsrfProtector implements EventSubscriberInterface
+ {
+     public const CSRF_TOKEN_REQUEST_PARAMETER = 'routeCsrfToken';
+-    /** @access protected */
+-    const CSRF_TOKEN_ID_PREFIX = 'route_';
++    public const CSRF_TOKEN_ID_PREFIX = 'route_';
+
+     /**
+      * @var \Doctrine\Common\Annotations\Reader",this is not consistent with the previous annotation - is it because of the usage in `Admin\Content\Category\list.html.twig` twig template? Should not it be at least mentioned in the commit message? :slightly_smiling_face:,Does this really need to be protected?
+9430,"@@ -149,6 +149,7 @@ func ReadSecretFromStdin() (string, error) {
+ 			case <-routineTerminate:
+ 				return
+ 			default:
++				return
+ 			}
+ 		}
+ 	}()",why add `return` here?,nit: is there a reason we need this return here?
+9431,"@@ -82,7 +82,9 @@ namespace Nethermind.Network.Test.Discovery
+             Assert.AreEqual(message.DestinationAddress, deserializedMessage.DestinationAddress);
+             Assert.AreEqual(message.SourceAddress, deserializedMessage.SourceAddress);
+             Assert.AreEqual(message.Version, deserializedMessage.Version);
+-            Assert.IsNotNull(deserializedMessage.Mdc);
++
++            // check MDC correctness
++            Assert.IsNotNull(Bytes.FromHexString(""0xf8c61953f3b94a91aefe611e61dd74fe26aa5c969d9f29b7e063e6169171a772""));
+         }
+
+         [Test]",put this hash in variable,Should this have a `using` to ensure it is removed in the future?
+9432,"@@ -5,11 +5,8 @@
+ package libkbfs
+
+ import (
+-	""bytes""
+-	""errors""
+ 	""testing""
+
+-	""github.com/keybase/client/go/libkb""
+ 	""github.com/keybase/client/go/logger""
+ 	""github.com/keybase/client/go/protocol/keybase1""
+ 	""github.com/keybase/go-framed-msgpack-rpc/rpc""",Why not use `kbfsblock.ZeroRefNonce`?,delete this file?
+9433,"@@ -26,7 +26,7 @@ class EarlyStopException(Exception):
+
+ # Callback environment used by callbacks
+ CallbackEnv = collections.namedtuple(
+-    ""LightGBMCallbackEnv"",
++    ""CallbackEnv"",
+     [""model"",
+      ""params"",
+      ""iteration"",",what mypy warning does this address? I'm confused by this change.,Why did you chang
+9434,"@@ -3751,6 +3751,18 @@ void Player::addAttacked(const Player* attacked)
+ 	attackedSet.insert(attacked->guid);
+ }
+
++void Player::removeAttacked(const Player* attacked)
++{
++	if (!attacked || attacked == this) {
++		return;
++	}
++
++	auto it = attackedSet.find(attacked->guid);
++	if (it != attackedSet.end()) {
++		attackedSet.erase(it);
++	}
++}
++
+ void Player::clearAttacked()
+ {
+ 	attackedSet.clear();",Note that `hasAttacked` that is called before this function already performs this check. You probably don't need to check `hasAttacked` then.,I think this shou
+9435,"@@ -0,0 +1,10 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!@salesforce/design-system-react/components/carousel/__examples__/default.jsx'),
++];
++
++module.exports = siteStories;","Unfortunately, the site example only has access to imports from `components/index.js` that means that you can't import the items file `carousel-items.js`. You can import that file in all the other storybook files though.",@saleor/design-sy
+9436,"@@ -79,7 +79,7 @@ setup(
+             'locale/*/LC_MESSAGES/electrum.mo',
+         ]
+     },
+-    scripts=['electrum'],
++    scripts=['electrum', 'privkey2electrum'],
+     data_files=data_files,
+     description=""Lightweight Bitcoin Wallet"",
+     author=""Thomas Voegtlin"",",Leave this out and move the script to the scripts folder.,Are we sure there is no other way to generate this script?
+9437,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",Should this be `nameOrHandle`?
+9438,"@@ -0,0 +1,17 @@
++using System.Collections.Generic;
++using System.IO.Pipelines;
++using System.Threading.Tasks;
++using Microsoft.AspNetCore.Http.Features;
++
++namespace Microsoft.AspNetCore.Connections
++{
++    public interface IConnection
++    {
++        IDuplexPipe Transport { get; }
++        IFeatureCollection Features { get; }
++
++        Task StartAsync();
++        Task StartAsync(TransferFormat transferFormat);
++        Task DisposeAsync();
++    }
++}",TransferFormat.Text in general purpose connection interface? :/,Is there a reason we need an IConnection interface? Can't
+9439,"@@ -36,10 +36,17 @@ module Selenium
+       SOCKET_LOCK_TIMEOUT = 45
+       STOP_TIMEOUT        = 20
+
++      @executable = nil
++      @missing = ''
++
++      class << self
++        attr_accessor :executable, :missing_text
++      end
++
+       attr_accessor :host
+
+       def initialize(executable_path, port, *extra_args)
+-        @executable_path = executable_path
++        @executable_path = binary_path(executable_path)
+         @host            = Platform.localhost
+         @port            = Integer(port)
+         @extra_args      = extra_args",Is this `@missing_text` ?,How would you feel about renaming `executable_path` to `ex
+9440,"@@ -485,6 +485,12 @@ func (c *client) processRouteInfo(info *Info) {
+ 		if !s.getOpts().Cluster.NoAdvertise {
+ 			s.addClientConnectURLsAndSendINFOToClients(info.ClientConnectURLs)
+ 		}
++
++		// This will allow us to determine the initial RTT without having to
++		// wait for first timer based PING.
++		c.mu.Lock()
++		c.sendPing()
++		c.mu.Unlock()
+ 	} else {
+ 		c.Debugf(""Detected duplicate remote route %q"", info.ID)
+ 		c.closeConnection(DuplicateRoute)",This work for both sides?,why a new lock for this?
+9441,"@@ -32,9 +32,12 @@ import {
+ 	isDataZeroSearchConsole,
+ } from '../dashboard/util';
+
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+
+ class DashboardWidgetPopularKeywordsTable extends Component {
+ 	static renderLayout( component ) {",`lodash` shouldn't be grouped under WordPress dependencies,Nit: Imports should be a
+9442,"@@ -117,6 +117,13 @@ class ComputeTest(unittest_utils.ForsetiTestCase):
+         with self.assertRaises(expected_exception):
+             list(self.gce_api_client.get_firewall_rules(self.project_id))
+
++
++    def test_get_global_operations(self):
++        """"""Test get_global_operations""""""
++        http_mocks.mock_http_response(fake_compute.GLOBAL_OPERATIONS_RESPONSE)
++        results = self.gce_api_client.get_global_operations(
++            self.project_id, operation_id='operation-1234')
++
+     def test_get_quota(self):
+         """"""Test get quota.""""""
+         http_mocks.mock_http_response(fake_compute.GET_PROJECT_RESPONSE)",Include the standard parameterized error tests as well.,Do you need to call `lis
+9443,"@@ -242,6 +242,16 @@ func runWeb(ctx *cli.Context) {
+ 					m.Patch(""/hooks/:id:int"", bind(api.EditHookOption{}), v1.EditRepoHook)
+ 					m.Get(""/raw/*"", middleware.RepoRef(), v1.GetRepoRawFile)
+ 					m.Get(""/archive/*"", v1.GetRepoArchive)
++					m.Post(""/forks"", v1.ForkRepo)
++
++					m.Get(""/commits/:commitId"", middleware.RepoRef(), v1.CommitById)
++					m.Get(""/commits/current"", middleware.RepoRef(), v1.CurrentCommit)
++
++					m.Group(""/releases"", func() {
++						m.Combo("""").Get(v1.ListReleases).
++							Post(bindIgnErr(api.CreateReleaseOption{}), v1.CreateRelease)
++						m.Get(""/:release"", v1.ReleaseByName)
++					}, middleware.RepoRef())
+ 				}, middleware.ApiRepoAssignment(), middleware.ApiReqToken())
+ 			})
+ ",All lowercase in route rule.,"`m.Group(""/releases"", fu"
+9444,"@@ -61,8 +61,16 @@ export const actions = {
+
+ 			const { dispatch } = yield Data.commonActions.getRegistry();
+ 			yield actions.receiveAccounts( response.accounts );
+-			dispatch( STORE_NAME ).receiveProperties( response.properties );
+-			dispatch( STORE_NAME ).receiveProfiles( response.profiles );
++
++			if ( response.properties.length && response.properties[ 0 ] && response.properties[ 0 ].accountId ) {
++				const accountID = response.properties[ 0 ].accountId;
++				dispatch( STORE_NAME ).receiveProperties( response.properties, { accountID } );
++			}
++
++			if ( response.properties.length && response.properties[ 0 ] && response.properties[ 0 ].id ) {
++				const propertyID = response.properties[ 0 ].id;
++				dispatch( STORE_NAME ).receiveProfiles( response.profiles, { propertyID } );
++			}
+
+ 			if ( response.matchedProperty ) {
+ 				dispatch( STORE_NAME ).receiveMatchedProperty( response.matchedProperty );","I'd suggest we use `response.profiles[ 0 ].webPropertyId` here instead, to make sure it's based on the profiles retrieved. The value _should_ be the same, but I think it's a bit more accurate like that.",This could be a one-liner
+9445,"@@ -314,8 +314,8 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+             bgGraph.setOnLongClickListener(new View.OnLongClickListener() {
+                 @Override
+                 public boolean onLongClick(View v) {
+-                    rangeToDisplay += 6;
+-                    rangeToDisplay = rangeToDisplay > 24 ? 6 : rangeToDisplay;
++                    rangeToDisplay += 3;
++                    rangeToDisplay = rangeToDisplay > 24 ? 3 : rangeToDisplay;
+                     SP.putInt(R.string.key_rangetodisplay, rangeToDisplay);
+                     updateGUI(""rangeChange"");
+                     return false;","This doesn't change the default of 6h, but will increase the displayed timeframe by 3h for each long press, before wrapping around to 3h. This requires 7 long-presses - quiet a journey ...",Could you explain why thi
+9446,"@@ -91,6 +91,7 @@ type nodeChainReader interface {
+ 	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ 	HeadEvents() *ps.PubSub
+ 	Load(context.Context) error
++	SetHead(context.Context, types.TipSet) error
+ 	Stop()
+ }
+ ",We still need to figure out a way to get rid of this write method. Is this still necessary?,Is there a reason we don'
+9447,"@@ -265,6 +265,11 @@ class KNNClassifierTest(unittest.TestCase):
+
+     self.assertEquals(classifier.getNumPartitionIds(), 3)
+
++    # Check that the full set of partition ids is what we expect
++    self.assertItemsEqual(classifier.getPartitionIdPerPattern(),
++                          [433, 213, np.inf, 433, 413])
++    self.assertItemsEqual(classifier.getPartitionIdList(),[433, 413, 213])
++
+     # Remove two rows - all indices shift down
+     self.assertEquals(classifier._removeRows([0,2]), 2)
+     self.assertItemsEqual(classifier.getPatternIndicesWithPartitionId(433),","`assertItemsEqual` compares the sequences after sorting them, is that intended?",please also check that th
+9448,"@@ -170,8 +170,8 @@ module Selenium
+
+           def macosx_path
+             path = ""/Applications/Firefox.app/Contents/MacOS/firefox-bin""
+-            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(path)
+-            path = Platform.find_binary(""firefox-bin"") unless File.exist?(path)
++            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(File.expand_path(path))
++            path = Platform.find_binary(""firefox-bin"") unless File.exist?(File.expand_path?(path))
+
+             path
+           end",I don't think this one needs to be changed since the only previous path is already an absolute one.,"@jjaffeux, @jjaffeux, @zachmargolis, can you explain why this change is needed?"
+9449,"@@ -13,8 +13,14 @@ namespace AutoRest.Swagger.Model.Utilities
+ {
+     public static class ValidationUtilities
+     {
+-        private static readonly string XmsPageable = ""x-ms-pageable"";
++        private const string XmsPageable = ""x-ms-pageable"";
+         private static readonly Regex TrackedResRegEx = new Regex(@"".+/Resource$"", RegexOptions.IgnoreCase);
++        private const string AzureHostSignature = ""management.azure.com"";
++
++        // if x-ms-parameterized-host extension is used or if the host is anything of the form management.azure, assume this to be an ARMServiceDefinition
++        // TODO: refine this definition for azure data plain also check x-ms-parameterized-host in detail to ensure this is ARM
++        public static bool IsARMServiceDefinition(ServiceDefinition serviceDefinition) =>
++            serviceDefinition.Extensions.ContainsKey(""x-ms-parameterized-host"") || serviceDefinition.Host?.EqualsIgnoreCase(AzureHostSignature) == true;
+
+         public static bool IsTrackedResource(Schema schema, Dictionary<string, Schema> definitions)
+         {",what's the goal of this?,Should this be `serviceDefinition.Host.EqualsIgnoreCase(AzureHostSignature)`?
+9450,"@@ -49,6 +49,8 @@ type Node struct {
+
+ 	// CborStore is a temporary interface for interacting with IPLD objects.
+ 	CborStore *hamt.CborIpldStore
++
++	pool *core.MessagePool
+ }
+
+ // Config is a helper to aid in the construction of a filecoin node.",why is this here? We already have a message pool in the node.,Why not use a pointer here?
+9451,"@@ -1107,7 +1107,7 @@ func (s *activityReplicatorSuite) TestSyncActivity_ActivityRunning() {
+ 	var versionHistories *persistence.VersionHistories
+ 	s.mockMutableState.EXPECT().GetVersionHistories().Return(versionHistories).AnyTimes()
+ 	s.mockMutableState.EXPECT().GetReplicationState().Return(&persistence.ReplicationState{}).AnyTimes()
+-	s.mockMutableState.EXPECT().GetWorkflowStateStatus().Return(enumsgenpb.WORKFLOW_EXECUTION_STATE_RUNNING, enumspb.WORKFLOW_EXECUTION_STATUS_UNSPECIFIED).AnyTimes()
++	s.mockMutableState.EXPECT().GetWorkflowStateStatus().Return(enumsgenpb.WORKFLOW_EXECUTION_STATE_RUNNING, enumspb.WORKFLOW_EXECUTION_STATUS_COMPLETED).AnyTimes()
+ 	s.mockNamespaceCache.EXPECT().GetNamespaceByID(namespaceID).Return(
+ 		cache.NewGlobalNamespaceCacheEntryForTest(
+ 			&persistenceblobs.NamespaceInfo{Id: namespaceID, Name: namespace},",Another mess after all renames and enum conversions. Doesn't break anything though.,why are we changing the mock state here?
+9452,"@@ -17,7 +17,8 @@ class PluginSetup(unittest.TestCase):
+     def test_a_statsd_timer_is_used_for_history_if_configured(self):
+         settings = {
+             ""statsd_url"": ""udp://127.0.0.1:8125"",
+-            ""includes"": ""kinto.plugins.history""
++            ""includes"": ""kinto.plugins.history"",
++            ""storage_strict_json"": True
+         }
+         config = testing.setUp(settings=settings)
+         with mock.patch('kinto.core.statsd.Client.timer') as mocked:",I don't think it's necessary to change this for the history plugin tests?,Do we need to set `storage_strict_json` in this test?
+9453,"@@ -328,8 +328,8 @@ bool TCPv4Transport::compare_locator_ip_and_port(
+ void TCPv4Transport::fill_local_ip(
+         Locator& loc) const
+ {
+-    IPLocator::setIPv4(loc, ""127.0.0.1"");
+     loc.kind = LOCATOR_KIND_TCPv4;
++    IPLocator::setIPv4(loc, ""127.0.0.1"");
+ }
+
+ ip::tcp::endpoint TCPv4Transport::generate_endpoint(","In general, I suggest using the `kind()` getter inhereted from `TransportInterface`",Shouldn't this be `loc.kind = LOCATOR_KIND_TCPV4`?
+9454,"@@ -48,8 +48,6 @@ namespace NLog.Layouts
+     /// </remarks>
+     [Layout(""Log4JXmlEventLayout"")]
+     [ThreadAgnostic]
+-    [ThreadSafe]
+-    [AppDomainFixedOutput]
+     public class Log4JXmlEventLayout : Layout, IIncludeContext
+     {
+         /// <summary>",Is the removal of `[AppDomainFixedOutput]` on purpose? (looks like a copy-paste...euh..remove error),Do we have a strong reason to turn off `AppDomainFixe
+9455,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (IAM) users.]
++//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (AWS IAM) users.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I think we should leave the `snippet-sourcedescriptio
+9456,"@@ -163,6 +163,7 @@ type APIV1POSTTransactionSignRequest struct {
+ 	WalletHandleToken string `json:""wallet_handle_token""`
+ 	// swagger:strfmt byte
+ 	Transaction    []byte `json:""transaction""`
++	PublicKey      crypto.PublicKey `json:""public_key""`
+ 	WalletPassword string `json:""wallet_password""`
+ }
+ ",gofmt everything pls,why do we need this?
+9457,"@@ -243,6 +243,8 @@ type PodIOChaosStatus struct {
+ }
+
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+
+ // PodIOChaosList contains a list of PodIOChaos
+ type PodIOChaosList struct {","ditto, We do not need add this feature for PodXXXChaos",@liggitt I'm not sur
+9458,"@@ -38,8 +38,9 @@ public class SampleNamer extends NameFormatterDelegator {
+   /**
+    * Returns the variable name of the service.
+    */
+-  public String getServiceVarName(String apiTypeName) {
+-    return localVarName(Name.lowerCamel(Name.upperCamel(apiTypeName).toLowerCamel(), ""service""));
++  public String getServiceVarName(String lowerCamelApiTypeName) {
++    return localVarName(
++        Name.lowerCamel(Name.lowerCamel(lowerCamelApiTypeName).toLowerCamel(), ""service""));
+   }
+
+   /**","There is a simpler way to do this: 1. Don't bother with the whole lowerCamelApiTypeName in SampleConfig 2. Use this code: `return localVarName(Name.upperCamel(apiTypeName, ""Service""));` Basically, each of the static creation methods of Name just need to have their arguments all be in the same casing, so you would just pass the upper camel string ""Service"" here.",is this still needed
+9459,"@@ -28,7 +28,7 @@ using EdgeData = util::NodeBasedDynamicGraph::EdgeData;
+
+ bool requiresAnnouncement(const EdgeData &from, const EdgeData &to)
+ {
+-    return !from.IsCompatibleTo(to);
++    return !from.CanCombineWith(to);
+ }
+
+ TurnAnalysis::TurnAnalysis(const util::NodeBasedDynamicGraph &node_based_graph,",Can you explain this change to me?,What's the differenc
+9460,"@@ -19,7 +19,7 @@ const (
+ 	OpenEBSArtifacts  ArtifactSource = ""../artifacts/openebs-ci.yaml""
+ 	CStorPVCArtifacts ArtifactSource = ""../artifacts/cstor-pvc.yaml""
+ 	JivaPVCArtifacts  ArtifactSource = ""../artifacts/jiva-pvc.yaml""
+-	SingleReplicaSC   ArtifactSource = ""../artifacts/single-replica.yaml""
++	SingleReplicaSC   ArtifactSource = ""../artifacts/storageclass-1r.yaml""
+ 	CVRArtifact       ArtifactSource = ""../artifacts/cvr-schema.yaml""
+ 	CRArtifact        ArtifactSource = ""../artifacts/cr-schema.yaml""
+ )",let us rename the artifact to `storageclass-single-replica.yaml`,Do we need to update `SingleReplicaSC` to `storageclass-1r.yaml`?
+9461,"@@ -5,7 +5,7 @@ using System;
+ using System.Runtime.CompilerServices;
+ using System.Runtime.InteropServices;
+
+-namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Networking
++namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking
+ {
+     public class LibuvFunctions
+     {","Nit: I should have done this before, but rename the file to LibuvFunctions.cs. Make sure no other files are misnamed.",File is called `LibuvInternal.Networking.cs` and the class `Libuv
+9462,"@@ -100,6 +100,7 @@ public class JavaBinCodec implements PushWriter {
+           MAP_ENTRY_ITER = 17,
+           ENUM_FIELD_VALUE = 18,
+           MAP_ENTRY = 19,
++          UUID = 20, // This is reserved to be used only in LogCodec
+           // types that combine tag + length (or other info) in a single byte
+           TAG_AND_LEN = (byte) (1 << 5),
+           STR = (byte) (1 << 5),",We should not add new types unless absolutely required. I'm not sure `UUID` is requires a new type,Can we delete this?
+9463,"@@ -461,3 +461,14 @@ class JUnitMirrorsManager(MirrorsManager):
+             links.append(default_link)
+         self.log.debug('Total mirrors: %d', len(links))
+         return links
++
++
++class JavaEnv(object):
++    def get_additional_classpath(self):
++        pass
++
++    def get_cp_from_files(self):
++        pass
++
++    def get_files_from_cp(self):
++        pass","If only Gatling uses it, can we skip introducing new entity for now? Looks like overkill...","@cicdw I'm not sure if there is a better way to handle this, but "
+9464,"@@ -54,6 +54,14 @@ type VersionsResponse struct {
+ 	Versions []string `json:""versions""`
+ }
+
++// Response to `GET /versions`
++// swagger:response VersionsResponse
++type versionsResponse struct {
++	//Versions Response
++	//in:body
++	Body *VersionsResponse
++}
++
+ // APIV1GETWalletsResponse is the response to `GET /v1/wallets`
+ // friendly:ListWalletsResponse
+ type APIV1GETWalletsResponse struct {",rename -> info ?,why not rename it to versionsResponse ?
+9465,"@@ -135,6 +135,10 @@ class scheduler(Config):
+
+     prune_on_get_work = parameter.BoolParameter(default=False)
+
++    upstream_status_when_all = parameter.BoolParameter(default=False,
++                                                       config_path=dict(section='scheduler',
++                                                                        name='upstream-status-when-all'))
++
+
+ class Failures(object):
+     """"""","Remove the `config_path=dict(...)`, that is automatic!",This should be named `upstream_status`
+9466,"@@ -23,9 +23,11 @@ function cleanupPlugins(resolve, reject) {
+     });
+   });
+
+-  axe.utils.toArray(document.querySelectorAll('frame, iframe')).forEach(function (frame) {
++  var flattenedTree = axe.utils.getFlattenedTree(document.body)
++
++  axe.utils.querySelectorAll(flattenedTree, 'iframe, frame').forEach(function (node) {
+     q.defer(function (res, rej) {
+-      return axe.utils.sendCommandToFrame(frame, {
++      return axe.utils.sendCommandToFrame(node.actualNode, {
+         command: 'cleanup-plugin'
+       }, res, rej);
+     });","I had to create a new flattened tree to support this functionality. The only other place in which a flattened tree is created is during the audit itself. Since `axe.cleanup` can be called at any arbitrary time, we can't reuse the same tree.",`flattenedTree` is undefined in this ca
+9467,"@@ -52,9 +52,15 @@ public final class ConfigUtil {
+
+   private static final String MICROSERVICE_CONFIG_LOADER_KEY = ""cse-microservice-config-loader"";
+
++  private static ConfigModel model = new ConfigModel();
++
+   private ConfigUtil() {
+   }
+
++  public static void addConfigs(Map<String, Object> config) {
++    model.setConfig(config);
++  }
++
+   public static Object getProperty(String key) {
+     Object config = DynamicPropertyFactory.getBackingConfigurationSource();
+     return getProperty(config, key);","As this method is just set the internal cofigModel, it's better to use setConfigs instead of addConfigs.","this method is not needed, the `setConf"
+9468,"@@ -44,7 +44,13 @@ const (
+ // Timelimits for docker operations enforced above docker
+ const (
+ 	// ListContainersTimeout is the timeout for the ListContainers API.
+-	ListContainersTimeout   = 10 * time.Minute
++	ListContainersTimeout = 10 * time.Minute
++	// LoadImageTimeout is the timeout for the LoadImage API. It's set
++	// to much lower value than pullImageTimeout as it involves loading
++	// image from either a file or STDIN
++	// calls involved.
++	// TODO: Benchmark and re-evaluate this value
++	LoadImageTimeout        = 10 * time.Minute
+ 	pullImageTimeout        = 2 * time.Hour
+ 	createContainerTimeout  = 4 * time.Minute
+ 	startContainerTimeout   = 3 * time.Minute",Is this line needed?,Do we need to set this to a much lower value? Maybe 2m?
+9469,"@@ -20,6 +20,8 @@ import (
+ 	""context""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
++	""github.com/google/knative-gcp/pkg/apis/events/v1beta1""
+ 	""net/url""
+ 	""os""
+ 	""time""",nit: import formatter,@mfojtik trying this to get away from v1alpha1
+9470,"@@ -118,9 +118,18 @@ namespace AutoRest.Swagger
+                 headerType = null;
+             }
+
++
+             // Response format
+             List<Stack<IModelType>> typesList = BuildResponses(method, headerType);
+
++            // if each of the responses have explicitly set their nullable property to false, we will have to consider it
++            bool isNonNullableReturnType = true;
++            _operation.Responses.Keys.ForEach(key =>
++            {
++                isNonNullableReturnType = isNonNullableReturnType && !(_operation.Responses[key].Extensions?.Get<bool>(""x-nullable"") ?? true);
++            });
++            method.IsXNullableReturnType = !(isNonNullableReturnType);
++
+             method.ReturnType = BuildMethodReturnType(typesList, headerType);
+             if (method.Responses.Count == 0)
+             {",can you use LINQ's `All` instead? Should be a side-effects free one liner with that.,This will be slow if we add a response for every method
+9471,"@@ -24,7 +24,9 @@
+ #include <inttypes.h>
+ #include <netdb.h>
+ #include <netinet/in.h>
++#ifndef __ANDROID__
+ #include <spawn.h>
++#endif
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <sys/socket.h>","Could you please remove `#include <spawn.h>` as a whole and see what happens? I believe that this is no longer needed; it was necessary when we called `posix_spawnp` directly, but now we use `h2o_spawnp`.",Shouldn't this be `#ifdef __ANDROID__ || defined __ANDR
+9472,"@@ -94,10 +94,16 @@ func (in *fakeTwoPhaseChaos) GetStatus() *v1alpha1.ChaosStatus {
+ 	return &in.Status
+ }
+
++// IsDeleted returns whether this resource has been deleted
+ func (in *fakeTwoPhaseChaos) IsDeleted() bool {
+ 	return in.Deleted
+ }
+
++// IsPaused returns whether this resource is paused
++func (in *fakeTwoPhaseChaos) IsPaused() bool {
++	return false
++}
++
+ func (r fakeReconciler) Object() reconciler.InnerObject {
+ 	return &fakeTwoPhaseChaos{}
+ }",`whether this resource is paused` to `whether this resource has been paused` ? To keep same doc style.,This is unused and can be removed.
+9473,"@@ -36,4 +36,11 @@ public interface PermissionManager {
+   public boolean hasPermission(final String imageTypeName, final String userId, final Type type)
+       throws ImageMgmtException;
+
++  /**
++   * Checks if the user has permission to manage high priority flows.
++   * @param userId
++   * @return
++   * @throws ImageMgmtException
++   */
++  public boolean hasPermission(final String userId) throws ImageMgmtException;
+ }",This method is validating permission for hp flow. Can you please rename this method to convey the same?,"Minor typo here, should be `imageT"
+9474,"@@ -102,9 +102,7 @@ class MongoNetworkError extends MongoError {
+     super(message);
+     this.name = 'MongoNetworkError';
+
+-    if (options && options.beforeHandshake === true) {
+-      this[kBeforeHandshake] = true;
+-    }
++    this[kBeforeHandshake] = !!(options && options.beforeHandshake === true);
+   }
+ }
+ ","Just to confirm, do we actually want to explicitly set the `kBeforeHandshake` symbol on all network errors regardless of whether the options/property is passed in?",Why is `beforeHandshake` not nulla
+9475,"@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) {
+ 	r.dirtyIfaces.Add(ifaceName)
+ }
+
++func (r *RouteTable) QueueResync() {
++	r.logCxt.Info(""Queueing a resync."")
++	r.inSync = false
++}
++
+ func (r *RouteTable) Apply() error {
+ 	if !r.inSync {
+ 		links, err := r.dataplane.LinkList()",How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.,What's the purpose of this?
+9476,"@@ -172,9 +172,12 @@ func (g *gen) frame() []byte {
+ 		}
+ 		sort.Strings(imps)
+ 		for _, path := range imps {
+-			// TODO(light): Omit the local package identifier if it matches
+-			// the package name.
+-			fmt.Fprintf(&buf, ""\t%s %q\n"", g.imports[path], path)
++			// Omit the local package identifier if it matches the package name.
++			if g.imports[path] == path {
++				fmt.Fprintf(&buf, ""\t%q\n"", path)
++			} else {
++				fmt.Fprintf(&buf, ""\t%s %q\n"", g.imports[path], path)
++			}
+ 		}
+ 		buf.WriteString("")\n\n"")
+ 	}","While this is commonly correct, the more reliable check is to get the package's identifier from the type checker and check those for equality. The information should be there, just another matter of plumbing it.",Why is this change needed?
+9477,"@@ -168,6 +168,9 @@ def to_full_resource_name(full_parent_name, resource_type_name):
+     Returns:
+         str: full_resource_name of the child
+     """"""
++    # Strip out the fake composite root parent from the full resource name.
++    if full_parent_name == 'composite_root/root/':
++        return '{}/'.format(resource_type_name)
+
+     return '{}{}/'.format(full_parent_name, resource_type_name)
+ ","Just to clarify, should this be 'composite_root/root/' or 'composite_root/'?","Sorry, I didn't catch this"
+9478,"@@ -288,5 +288,6 @@ func (psb *PubSubBase) DeletePubSub(ctx context.Context, pubsubable duck.PubSuba
+ 		return fmt.Errorf(""failed to delete PullSubscription: %w"", err)
+ 	}
+ 	status.SinkURI = nil
++	status.SubscriptionID = """"
+ 	return nil
+ }",Any reason not to move it to after line 281? These are all pubsub related fields IIUC.,Why was this added?
+9479,"@@ -3,7 +3,7 @@ import { both, gt } from 'ramda';
+ import isNumber from './isNumber';
+
+ /**
+- * Checks if value is a negative `Number` primitive or object.
++ * Checks if value is a negative `Number` primitive or object. Zero is not considered negative.
+  *
+  * @func isNegative
+  * @memberOf RA",Checks if value is a negative `Number` primitive or object. Zero is considered neither positive nor negative.,"TBH, I don't like this cha"
+9480,"@@ -285,6 +285,11 @@ func (h Handler) buildEnv(r *http.Request, rule Rule, fpath string) (map[string]
+ 	// Retrieve name of remote user that was set by some downstream middleware such as basicauth.
+ 	remoteUser, _ := r.Context().Value(httpserver.RemoteUserCtxKey).(string)
+
++	requestScheme := ""http""
++	if r.TLS != nil {
++		requestScheme = ""https""
++	}
++
+ 	// Some variables are unused but cleared explicitly to prevent
+ 	// the parent environment from interfering.
+ 	env = map[string]string{","Just a nit, but remove the empty line here. :)",@smarterclayton should this be `http` or `https`?
+9481,"@@ -385,6 +385,16 @@ func (p *Package) addFiles(cu *apb.CompilationUnit, root, base string, names []s
+ 			Corpus: p.ext.DefaultCorpus,
+ 			Path:   trimmed,
+ 		}
++
++		if p.ext.Rules != nil {
++			v2, ok := p.ext.Rules.Apply(trimmed)
++			if ok {
++				vn.Corpus = v2.Corpus
++				vn.Root = v2.Root
++				vn.Path = v2.Path
++			}
++		}
++
+ 		if vn.Corpus == """" {
+ 			// If no default corpus is specified, use the package's corpus for each of
+ 			// its files.  The package corpus is based on the rules in",A `GoPackageInfo` details message should be added to the `CompilationUnit_FileInput` to ensure the import path remains the same.,"I think this should be `v2.Corpus, v2.Root, vn.Pa"
+9482,"@@ -1,10 +1,10 @@
+ package com.fsck.k9.activity;
+
+-import android.app.ListActivity;
+ import android.os.Bundle;
+ import android.view.KeyEvent;
+ import android.view.MotionEvent;
+ import android.widget.AdapterView;
++import android.widget.ListAdapter;
+ import android.widget.ListView;
+
+ import com.fsck.k9.K9;",Please don't create new fields with the `m` prefix. I'd rather mix than introduce more of these.,Could you revert/rebase this file?
+9483,"@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
+
+     useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    cpuCircuitBreakerEnabled = getBool(""circuitBreaker/cpuCircuitBreakerEnabled"", false);
++    memoryCircuitBreakerEnabled = getBool(""circuitBreaker/memoryCircuitBreakerEnabled"", false);
+     memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 95);
+
+-    validateMemoryBreakerThreshold();
++    cpuCircuitBreakerThreshold = getInt(""circuitBreaker/cpuCircuitBreakerThreshold"", 95);
++
++    validateCircuitBreakerThresholds();
+
+     filterCacheConfig = CacheConfig.getConfig(this, ""query/filterCache"");
+     queryResultCacheConfig = CacheConfig.getConfig(this, ""query/queryResultCache"");",Can we please simplify these names? they are awfully verbose and repeating the parts that are already unique and obvious.,"This should be a global setting, not a global set"
+9484,"@@ -241,7 +241,7 @@ public class RecipientPresenter implements PermissionPingCallback {
+             boolean alreadyVisible = recipientMvpView.isBccVisible();
+             boolean singleBccRecipientFromAccount =
+                     bccRecipients.length == 1 && bccRecipients[0].toString().equals(bccAddress);
+-            recipientMvpView.setBccVisibility(alreadyVisible || singleBccRecipientFromAccount);
++            recipientMvpView.setBccVisibility(alreadyVisible || !singleBccRecipientFromAccount);
+             updateRecipientExpanderVisibility();
+         }
+     }","Flipped the logic here, was this actually wrong before?",@Arthur-Milchior This change will cause the recipients list to be updated even if there are no recipients. It will cause the recipients list to be updated even if there are no recipients.
+9485,"@@ -336,7 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
+-	bool nat_lvl1_drop = 0;
++	int res = 0;
+
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.",I think (a) should be initialized to `NAT_FE_LOOKUP_ALLOW` and (b) it should be probably the first thing in `calico_v4_nat_lookup2`,This variable is unused now. Please remove it.
+9486,"@@ -36,7 +36,7 @@ public class TestManyPointsInOldIndex extends LuceneTestCase {
+ //
+ // Compile:
+ //   1) temporarily remove 'extends LuceneTestCase' above (else java doesn't see our static void main)
+-//   2) ant compile-test
++//   2) gradlew testClasses
+ //
+ // Run:
+ //   1) java -cp ../build/backward-codecs/classes/test:../build/core/classes/java org.apache.lucene.index.TestManyPointsInOldIndex","I'd look as to what this class actually does... seems weird. Classpath below (under ""run"") is wrong for gradle.",Nit: could you change this to `ant compile-test`?
+9487,"@@ -17,6 +17,7 @@
+ package algod
+
+ import (
++	""github.com/algorand/go-algorand/data/basics""
+ 	""path/filepath""
+ 	""testing""
+ ",Group w/ algorand imports,Please remove this extra line
+9488,"@@ -28,12 +28,14 @@ package com.salesforce.androidsdk.store;
+
+ import java.util.ArrayList;
+ import java.util.List;
++import java.util.Locale;
+
+ import net.sqlcipher.database.SQLiteDatabase;
+
+ import org.json.JSONException;
+ import org.json.JSONObject;
+
++import android.annotation.SuppressLint;
+ import android.content.Context;
+ import android.test.InstrumentationTestCase;
+ import android.util.Log;",I don't think this import is being used.,Could you revert unintended changes to the file?
+9489,"@@ -5,7 +5,7 @@ const AnyKind = ""*** any procedure kind ***""
+ // Pattern represents an operator tree pattern
+ // It can match itself against a query plan
+ type Pattern interface {
+-	Root() ProcedureKind
++	Roots() []ProcedureKind
+ 	Match(Node) bool
+ }
+ ",This is an interesting way to do this. I like it. An alternative way to implement a multiple kind pattern was to have this return `AnyKind` and then have match perform an actual check to see if it matches.,What is the purpose of this change?
+9490,"@@ -373,8 +373,9 @@ class SonataMediaExtension extends Extension implements PrependExtensionInterfac
+         }
+
+         if ($container->hasDefinition('sonata.media.cdn.fallback') && isset($config['cdn']['fallback'])) {
++            // NEXT_MAJOR: Do not fallback to master
+             $container->getDefinition('sonata.media.cdn.fallback')
+-                ->replaceArgument(0, new Reference($config['cdn']['fallback']['master']))
++                ->replaceArgument(0, new Reference($config['cdn']['fallback']['primary'] ?? $config['cdn']['fallback']['master']))
+                 ->replaceArgument(1, new Reference($config['cdn']['fallback']['fallback']));
+         } else {
+             $container->removeDefinition('sonata.media.cdn.fallback');",You did not check this code,"Isn't this supposed to be `->replaceArgument(0, "
+9491,"@@ -31,6 +31,10 @@ func EncodeValues(vals []*Value) ([]byte, error) {
+ // DecodeValues decodes an array of abi values from the given buffer, using the
+ // provided type information.
+ func DecodeValues(data []byte, types []Type) ([]*Value, error) {
++	if len(types) > 0 && len(data) == 0 {
++		return nil, fmt.Errorf(""expected %d parameters, but got 0"", len(types))
++	}
++
+ 	if len(data) == 0 {
+ 		return nil, nil
+ 	}","This was necessary due to a bug uncovered in testing. If an actor method which requires params is called without any params at all, not returning an error here causes a panic.",Could this just be `if len(types) > 0 {`?
+9492,"@@ -738,6 +738,7 @@ const htmlElms = {
+       'dialog',
+       'document',
+       'feed',
++			'group',
+       'log',
+       'main',
+       'marquee',","Thanks for the pr. Would you be able to edit the file to use spaces rather than tabs? Normally we have prettier run on commit, but I guess file patches don't do that.",What is this used for?
+9493,"@@ -111,7 +111,6 @@ public class TestHiveClientPool {
+             ""Another meta exception"", () -> clients.run(client -> client.getTables(""default"", ""t"")));
+   }
+
+-  @Test
+   public void testConnectionFailureRestoreForMetaException() throws Exception {
+     HiveMetaStoreClient hmsClient = newClient();
+ ",Is it intentional that we removed this annotation?,please don't remove th
+9494,"@@ -42,6 +42,18 @@ namespace AutoRest.Swagger.Validation
+         /// </summary>
+         public override Category Severity => Category.Warning;
+
++        /// <summary>
++        /// What kind of open api document type this rule should be applied to
++        /// </summary>
++        public override ServiceDefinitionDocumentType ServiceDefinitionDocumentType => ServiceDefinitionDocumentType.ARM;
++
++        /// <summary>
++        /// When to apply the validation rule, before or after it has been merged as a part of
++        /// its merged document as specified in the corresponding '.md' file
++        /// By default consider all rules to be applied for After only
++        /// </summary>
++        public override ServiceDefinitionDocumentState ValidationRuleMergeState => ServiceDefinitionDocumentState.Individual;
++
+         public override IEnumerable<ValidationMessage> GetValidationMessages(Dictionary<string, Schema> definitions, RuleContext context)
+         {
+             var violatingModels = definitions.Where(defPair=>defPair.Value.Properties?.Values.Any(schema => schema.Enum != null)??false);",should be general?,shouldn't this be part
+9495,"@@ -153,7 +153,7 @@ namespace Nethermind.Blockchain
+         private void LoadBestKnown()
+         {
+             long headNumber = Head?.Number ?? _syncConfig.PivotNumberParsed;
+-            long left = Math.Max(_syncConfig.PivotNumberParsed, headNumber);
++            long left = Math.Max(LowestInsertedHeader?.Number ?? 0, headNumber);
+             long right = headNumber + BestKnownSearchLimit;
+
+             bool LevelExists(long blockNumber)","if lowest inserted header is non null non zero then pivot should be higher and a better best known on the left. maybe Head?.Number ?? Math.Max(Pivot, LowestInsertedHeader))?",Why not just set it to
+9496,"@@ -0,0 +1,14 @@
++package azkaban.execapp.fake;
++
++import azkaban.execapp.AzkabanExecutorServer;
++import azkaban.execapp.jmx.JmxJobMBeanManager;
++import azkaban.utils.Props;
++
++public class FakeApp extends AzkabanExecutorServer {
++
++  public FakeApp() throws Exception {
++    super(new Props(), null, null, new FakeServer(), null);
++    JmxJobMBeanManager.getInstance().initialize(new Props());
++  }
++
++}",Is a FakeApp class needed? Can test use a Mockito mock instance instead?,Seems this can be removed?
+9497,"@@ -1020,7 +1020,8 @@ VariableSP SymbolFilePDB::ParseVariableForPDBData(
+
+   var_sp = std::make_shared<Variable>(
+       var_uid, var_name.c_str(), mangled_cstr, type_sp, scope, context_scope,
+-      ranges, &decl, location, is_external, is_artificial, is_static_member);
++      ranges, &decl, location, is_external, is_artificial, is_static_member,
++      is_constant);
+   var_sp->SetLocationIsConstantValueData(is_constant);
+
+   m_variables.insert(std::make_pair(var_uid, var_sp));",We should make this an enum.,Could this be done in a wa
+9498,"@@ -15,7 +15,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+         private const string TestRuleId = ""TST0001"";
+         private const string TestFormatSpecifier = ""testFormatSpecifier"";
+         private const string TestAnalysisTarget = @""C:\dir\file"";
+-        private static readonly string DisplayedTarget = TestAnalysisTarget.Replace('\\', '/');
+
+         private static readonly RuleDescriptor TestRule = new RuleDescriptor(
+             TestRuleId,","@lgolding, note I fixed the forward slashes that appeared in the VS output (which was certainly not by design).",I think you need to use `P
+9499,"@@ -724,7 +724,7 @@ class ElementPlot(BokehPlot, GenericElementPlot):
+         else:
+             self.handles['xaxis'] = plot.xaxis[0]
+             self.handles['x_range'] = plot.x_range
+-            self.handles['y_axis'] = plot.yaxis[0]
++            self.handles['yaxis'] = plot.yaxis[0]
+             self.handles['y_range'] = plot.y_range
+         self.handles['plot'] = plot
+ ",Minor unrelated fix that snuck in.,Why did you change this?
+9500,"@@ -36,8 +36,8 @@ import com.salesforce.androidsdk.smartstore.store.QuerySpec;
+ import com.salesforce.androidsdk.smartstore.store.QuerySpec.QueryType;
+ import com.salesforce.androidsdk.smartstore.store.SmartStore;
+ import com.salesforce.androidsdk.smartstore.store.SmartStore.SmartStoreException;
+-import com.salesforce.androidsdk.smartstore.store.StoreCursor;
+ import com.salesforce.androidsdk.smartstore.store.SoupSpec;
++import com.salesforce.androidsdk.smartstore.store.StoreCursor;
+ import com.salesforce.androidsdk.smartstore.ui.SmartStoreInspectorActivity;
+
+ import net.sqlcipher.database.SQLiteDatabase;",Took the opportunity to fix the import ordering.,Please avoid un-needed changes in this file.
+9501,"@@ -130,9 +130,13 @@ class XRDCalculator(AbstractDiffractionPatternCalculator):
+         """"""
+         if isinstance(wavelength, float):
+             self.wavelength = wavelength
+-        else:
++        elif isinstance(wavelength, int):
++            self.wavelength = float(wavelength)
++        elif isinstance(wavelength, str):
+             self.radiation = wavelength
+             self.wavelength = WAVELENGTHS[wavelength]
++        else:
++            raise TypeError(""'wavelength' must be either of: float, int or str"")
+         self.symprec = symprec
+         self.debye_waller_factors = debye_waller_factors or {}
+ ",I think int and float can be handled in one if statement. The subsequent calculations don't really care whether it si a float or an int.,Shouldn't we check for float here?
+9502,"@@ -134,14 +134,14 @@ func TestDelayedCancellationEnabled(t *testing.T) {
+ 	t.Parallel()
+
+ 	ctx, cancel := makeContextWithDelayedCancellation(t)
+-	EnableDelayedCancellationWithGracePeriod(ctx, 15*time.Millisecond)
++	EnableDelayedCancellationWithGracePeriod(ctx, 50*time.Millisecond)
+
+ 	cancel()
+
+ 	select {
+ 	case <-ctx.Done():
+ 		t.Fatalf(""Cancellation is not delayed"")
+-	case <-time.After(10 * time.Millisecond):
++	case <-time.After(20 * time.Millisecond):
+ 	}
+
+ 	<-ctx.Done()",Can we keep this at 10 to reduce the probability of a flake? Or are you afraid this would be too likely to give a false positive if delayed cancellation is every actually broken?,What's the reasoning for changing this?
+9503,"@@ -15,9 +15,14 @@
+ package gcsblob
+
+ import (
++	""context""
++	""fmt""
++	""net/http""
+ 	""strings""
+ 	""testing""
+
++	""github.com/google/go-x-cloud/gcp""
++
+ 	""google.golang.org/api/googleapi""
+ )
+ ",nit: add a blank line under this.,Can you move this up with the other gcp impo
+9504,"@@ -67,6 +67,7 @@ var (
+ 	bytecodeFlag = flag.NewStringVarP(""bytecode"", ""b"", """", ""set the byte code"")
+ 	yesFlag      = flag.BoolVarP(""assume-yes"", ""y"", false, ""answer yes for all confirmations"")
+ 	passwordFlag = flag.NewStringVarP(""password"", ""P"", """", ""input password for account"")
++	chainIDFlag  = flag.NewUint64VarP(""chainID"", """", 0, ""set chainID for action"")
+ )
+
+ // ActionCmd represents the action command",no need to add this flag query the endpoint set-up to determine the chainID,Please add examples for all the flags and what their value should be.
+9505,"@@ -0,0 +1,9 @@
++if (node.querySelector('input[type=""submit""], img[type=""submit""], button[type=""submit""]')) {
++  return true;
++}
++
++if (!node.querySelectorAll(':not(textarea)').length) {
++  return false;
++}
++
++return undefined;","Here is a few scenario - What if there is a submit button with in a form, but is always disabled?",This name isn't very descriptive. Maybe something like `isValidImage`
+9506,"@@ -1498,6 +1498,7 @@ const instr_info_t * const op_instr[] =
+ #define Wed TYPE_W, OPSZ_16_vex32_evex64
+ #define Vex TYPE_V, OPSZ_16_vex32_evex64
+ #define Wex TYPE_W, OPSZ_16_vex32_evex64
++#define Weh_x TYPE_W, OPSZ_half_16_vex32_evex64
+
+ /* my own codes
+  * size m = 32 or 16 bit depending on addr size attribute",wrong code: should be `Wh_e`,typedef should be avoided
+9507,"@@ -582,10 +582,11 @@ static void makeLabelTag (vString *const label)
+
+ static lineType getLineType (void)
+ {
+-	vString *label = vStringNew ();
++	static vString *label = NULL;
+ 	int column = 0;
+ 	lineType type = LTYPE_UNDETERMINED;
+
++	label = vStringNewOrClear (label);
+ 	do  /* read in first 6 ""margin"" characters */
+ 	{
+ 		int c = getcFromInputFile ();","This leads to a small ""leak"" (mostly theoretical only though), if we don't want it this could be created in `initialize()` and destroyed in `finalize()`.","This function is not used at all, so the changes in this file can be "
+9508,"@@ -25,6 +25,8 @@ import (
+ )
+
+ const (
++	// BuildIDOSEnv is the os env name to get build id
++	BuildIDOSEnv           = ""BUILD_ID""
+ 	translateFailedPrefix  = ""TranslateFailed""
+ 	privacyInfoReplacement = ""[Privacy Info]""
+ )","BuildIDOSEnvVarName or similar, otherwise it sounds it's actually holding actual value of env var",this should go in `lib/portlayer/constants.go` and should be moved to `lib/portlayer/constants.go`
+9509,"@@ -103,7 +103,7 @@ class SparkReader:
+         """"""
+
+         with self.app.app_context():
+-
++            current_app.logger.info('Spark consumer has started!')
+             while True:
+                 self.init_rabbitmq_connection()
+                 self.incoming_ch = utils.create_channel_to_consume(","I like this standard ""container has started"" message. Should we have a ""container exited because FOO"" message as well?",Do you want this to be `INFO` or `DEBUG`?
+9510,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+
+ import com.google.common.collect.Maps;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.,Is this import needed?
+9511,"@@ -0,0 +1,19 @@
++const { useHandsontable } = require('./use-handsontable');
++const { getDependencies } = require('./dependencies');
++const { register } = require('./register');
++
++if (module) {
++  module.exports = {
++    useHandsontable,
++    instanceRegister: register,
++    getDependencies,
++    applyToWindow: () => {
++      /* eslint-disable no-restricted-globals */
++      if ((typeof window !== 'undefined')) {
++        window.useHandsontable = useHandsontable;
++        window.instanceRegister = register;
++      }
++      /* eslint-enable no-restricted-globals */
++    }
++  };
++}","We have Vue application at our disposal, and have examples container implemented as component. Shouldn't helpers be imported instead being global? Not the best practice in Vue app I guess",The `toWindow` function can't be defined in the global scope. It needs to be added to `window.expo
+9512,"@@ -1221,3 +1221,14 @@ type NoMergedMDError struct {
+ func (e NoMergedMDError) Error() string {
+ 	return fmt.Sprintf(""No MD yet for TLF %s"", e.tlf)
+ }
++
++// DiskCacheClosedError indicates that the disk cache has been
++// closed, and thus isn't accepting any more operations.
++type DiskCacheClosedError struct {
++	op string
++}
++
++// Error implements the error interface for DiskCacheClosedError.
++func (e DiskCacheClosedError) Error() string {
++	return fmt.Sprintf(""Error performing %s operation: the disk cache is closed."", e.op)
++}",No trailing punctuation in the error message.,"Why not use `ErrDiskCacheClosed` here instead of `Error`? `Error` sounds like an error, not something that is expected to happen."
+9513,"@@ -447,5 +447,6 @@ public class Notifier
+ 			}
+ 		}
+ 		clip.start();
++		clip.close();
+ 	}
+ }",tested? seems like it could break,Any reason why this is not a `Closer`?
+9514,"@@ -77,9 +77,10 @@ public final class IndexUpgrader {
+   public static void main(String[] args) throws IOException {
+     parseArgs(args).upgrade();
+   }
+-
++
++  /** Parse arguments. */
+   @SuppressForbidden(reason = ""System.out required: command line tool"")
+-  static IndexUpgrader parseArgs(String[] args) throws IOException {
++  public static IndexUpgrader parseArgs(String[] args) throws IOException {
+     String path = null;
+     boolean deletePriorCommits = false;
+     InfoStream out = null;",This have to be public because the renamed o.a.l.backward_index.TestBackwardsCompatibility refers this.,This seems unrelated to the rest of the PR?
+9515,"@@ -286,7 +286,7 @@ func TestApplicationsUpgradeOverGossip(t *testing.T) {
+ 	fixture.SetupNoStart(t, filepath.Join(""nettemplates"", ""TwoNodes100SecondTestUnupgradedProtocol.json""))
+
+ 	// for the primary node, we want to have a different consensus which always enables applications.
+-	primaryNodeUnupgradedProtocol := consensus[consensusTestFastUpgrade(protocol.ConsensusFuture)]
++	primaryNodeUnupgradedProtocol := consensus[consensusTestFastUpgrade(protocol.ConsensusCurrentVersion)]
+ 	primaryNodeUnupgradedProtocol.ApprovedUpgrades = make(map[protocol.ConsensusVersion]uint64)
+ 	primaryNodeUnupgradedProtocol.ApprovedUpgrades[consensusTestFastUpgrade(protocol.ConsensusFuture)] = 0
+ 	consensus[consensusTestUnupgradedProtocol] = primaryNodeUnupgradedProtocol","unrelated to your change, but I don't think that this is correct anymore. We also seen to remove application support from `primaryNodeUnupgradedProtocol` for the test to be correct.",why we need to change this?
+9516,"@@ -440,6 +440,19 @@ func mergeConfigSrcs(cfg, userCfg *aws.Config, envCfg envConfig, sharedCfg share
+ 			cfg.Credentials = credentials.NewStaticCredentialsFromCreds(
+ 				envCfg.Creds,
+ 			)
++
++		} else if len(envCfg.WebIdentityTokenFilePath) > 0 {
++			// handles assume role via OIDC token. This should happen before any other
++			// assume role call.
++			sessionName := envCfg.IAMRoleSessionName
++			if len(sessionName) == 0 {
++				sessionName = sharedCfg.AssumeRole.RoleSessionName
++			}
++
++			cfg.Credentials = stscreds.NewWebIdentityCredentials(&Session{
++				Config:   cfg,
++				Handlers: handlers.Copy(),
++			}, envCfg.WebIdentityRoleARN, sessionName, envCfg.WebIdentityTokenFilePath)
+ 		} else if envCfg.EnableSharedConfig && len(sharedCfg.AssumeRole.RoleARN) > 0 && sharedCfg.AssumeRoleSource != nil {
+ 			cfgCp := *cfg
+ 			cfgCp.Credentials = credentials.NewStaticCredentialsFromCreds(","Should this also validate that the RoleArn env var is provided, or just let the creds fail?",This will overwrite the `WebIdentityTokenFilePath`. I think we want to only set it if `EnableSharedConfig` is true.
+9517,"@@ -20,10 +20,12 @@
+
+ package transport
+
++import ""github.com/opentracing/opentracing-go""
++
+ // Deps is the interface of any object useful for passing injected
+ // dependencies into inbound and outbound transports.
+ type Deps interface {
+-	// Tracer() opentracing.Tracer
++	Tracer() opentracing.Tracer
+ }
+
+ // NoDeps is a no-op implementation of Deps","fwiw, in tchannel-go I've implemented a similar method on TChannel that either returns a Tracer instance it was initialized with, or returns `opentracing.GlobalTracer()`, which by default happens to return a singleton instance of `NoopTracer`. In Go the use of global variables is not frowned upon as say in Java, so this pattern allows minimal work to enable tracing in a service, one just needs to store a real tracer in the global variable, e.g. via `opentracing.InitGlobalTracer(someTracerImpl)`, while the instances of TChannel do not need to be explicitly given any tracer since they will default to that global.",Why is this not part of the interface?
+9518,"@@ -135,6 +135,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         self.assertEqual(kidx.name, ""renamed"")
+         self.assert_eq(kidx, pidx)
+
++        expected_error_message = ""Series.name must be a hashable type""
++        with self.assertRaisesRegex(TypeError, expected_error_message):
++            kser.name = [""0"", ""1""]
++
+     def test_rename_method(self):
+         # Series name
+         pser = pd.Series([1, 2, 3, 4, 5, 6, 7], name=""x"")","Shall we also add `ks.Series([1, 2, 3], name=[""0"", ""1""])`?",Can you add a check to ensure that `name` is `None`?
+9519,"@@ -45,7 +45,7 @@ public class PermissioningJsonRpcRequestFactory {
+
+   Request<?, AddNodeResponse> addNodesToWhitelist(final List<URI> enodeList) {
+     return new Request<>(
+-        ""perm_addNodesToWhitelist"",
++        ""perm_addNodesToAllowlist"",
+         Collections.singletonList(enodeList),
+         web3jService,
+         AddNodeResponse.class);",Can this be updated?,"The parameter name is not ""allowlist"" but ""nodes"""
+9520,"@@ -89,14 +89,7 @@ final class AddProviderCompilerPass implements CompilerPassInterface
+                 $definition = $container->getDefinition($id);
+
+                 foreach ($context['formats'] as $format => $formatConfig) {
+-                    $formatConfig['quality'] = $formatConfig['quality'] ?? 80;
+-                    $formatConfig['format'] = $formatConfig['format'] ?? 'jpg';
+-                    $formatConfig['height'] = $formatConfig['height'] ?? null;
+-                    $formatConfig['constraint'] = $formatConfig['constraint'] ?? true;
+-                    $formatConfig['resizer'] = $formatConfig['resizer'] ?? false;
+-
+-                    $formatName = sprintf('%s_%s', $name, $format);
+-                    $definition->addMethodCall('addFormat', [$formatName, $formatConfig]);
++                    $definition->addMethodCall('addFormat', [sprintf('%s_%s', $name, $format), $formatConfig]);
+                 }
+             }
+         }","this change is to avoid duplication on the defaults. They are already on the Configuration class. (Also I removed the false default, because the admin format does not have it). This is also produces the rest of the diff, changes from false to null.",Why did you remove the `formatConfig['width'] ?? null` part?
+9521,"@@ -46,6 +46,8 @@ func (pc *podConfigurator) connectInterfaceToOVSAsync(ifConfig *interfacestore.I
+ 	go func() {
+ 		klog.Infof(""Waiting for interface %s to be created"", hostIfAlias)
+ 		err := wait.PollImmediate(time.Second, 60*time.Second, func() (bool, error) {
++			containerAccess.lockContainer(containerID)
++			defer containerAccess.unlockContainer(containerID)
+ 			curEp, ok := pc.ifConfigurator.getEndpoint(ovsPortName)
+ 			if !ok {
+ 				return true, fmt.Errorf(""failed to find HNSEndpoint %s"", ovsPortName)","What does it protect from? If it's subsequent CNI calls, won't containerID be different from the first one? or it's different in containerd? we use `getInfraContainer` to get the lock identity in CNIAdd. And this reminds me what if the first CNI call and the subquent ones run into connectInterfaceToOVSAsync, will duplicate ports being created or it has been handled?",How is this related to the rest of the PR?
+9522,"@@ -0,0 +1,19 @@
++<?php
++
++namespace Shopsys\FrameworkBundle\Model\Advert\Exception;
++
++use Exception;
++
++class AdvertPositionNotKnownException extends Exception implements AdvertException
++{
++    public function __construct(string $positionName, array $knownPositionsNames, Exception $previous = null)
++    {
++        $message = sprintf(
++            'Unknown advert position name ""%s"". Known names are %s.',
++            $positionName,
++            implode('"", ""', $knownPositionsNames)
++        );
++
++        parent::__construct($message, 0, $previous);
++    }
++}","In Exceptions' constructors, we always add a optional last parameter `Exception $previous = null`. In the past, this was (still is?) a part of the coding standards.",Why not `AdvertPositionNotKnownException`?
+9523,"@@ -90,6 +90,15 @@ const connectionActivityMonitorInterval = time.Minute * 3
+ // we discard the connection.
+ const maxPeerInactivityDuration = time.Minute * 5
+
++// maxMessageQueueDuration is the maximum amount of time a message is allowed to be waiting
++// in the various queues before being sent. Once that deadline has reached, sending the message
++// is pointless, as it's too stale to be of any value
++const maxMessageQueueDuration = time.Second * 25
++
++// slowWritingPeerMonitorInterval is the interval at which we peek on the connected peers to
++// verify that their current outgoing message is not being blocked for too long.
++const slowWritingPeerMonitorInterval = time.Second * 5
++
+ var networkIncomingConnections = metrics.MakeGauge(metrics.NetworkIncomingConnections)
+ var networkOutgoingConnections = metrics.MakeGauge(metrics.NetworkOutgoingConnections)
+ ","I think more idiomatic (and consistent with elsewhere in our code base, and more natural to read as ""25 seconds"") is `25 * time.Second`",can we use a config value other than this?
+9524,"@@ -127,6 +127,7 @@ func NewDecoder(opts ...func(*Decoder)) *Decoder {
+ 	d := &Decoder{
+ 		MarshalOptions: MarshalOptions{
+ 			SupportJSONTags: true,
++			SupportYAMLTags: true,
+ 		},
+ 	}
+ 	for _, o := range opts {","Enabling `YAML` by default would be a breaking change in behavior for some applications if the struct's used by that application already include YAML tags, but their application has been (un)marshaling DynamoDB Attributes based on the struct name.",Can we remove the `SupportJSONTags` option now?
+9525,"@@ -131,7 +131,7 @@ public class DriverCommandExecutor extends HttpCommandExecutor implements Closea
+         Thread.currentThread().interrupt();
+         throw new WebDriverException(""Timed out waiting for driver server to stop."", e);
+       } finally {
+-        executorService.shutdownNow();
++        executorService.shutdown();
+       }
+
+     } else {","For the command executor, which in turn, uses the HTTP client to talk to the WebDriver, the client might have high-timeout values set, so the shutdown can take a long time if we wait for it to complete, especially if multiple-long running threads are there. I think it might be a good idea in general to couple the shutdown() with `awaitTermination()` with a timeout, if the ongoing tasks do not complete within that timeout then call `shutdownNow()`. What do you think?",`executorService.shutdown();` already exists in
+9526,"@@ -38,7 +38,7 @@ public abstract class HiveMetastoreTest {
+   @BeforeClass
+   public static void startMetastore() throws Exception {
+     HiveMetastoreTest.metastore = new TestHiveMetastore();
+-    metastore.start();
++    metastore.start(new HiveConf(HiveMetastoreTest.class));
+     HiveMetastoreTest.hiveConf = metastore.hiveConf();
+     HiveMetastoreTest.metastoreClient = new HiveMetaStoreClient(hiveConf);
+     String dbPath = metastore.getDatabasePath(DB_NAME);",Is this change needed? `start()` is still defined and uses `HiveMetastoreTest.class`. The only difference is that this doesn't pass a `Configuration` and the parameterless `start` passes `new Configuration()`.,Can we just explicitly call `metastore.start(ne
+9527,"@@ -27,6 +27,7 @@ type stakingCommand struct {
+ 	stakingV1   Protocol
+ 	stakingV2   *staking.Protocol
+ 	candIndexer *CandidateIndexer
++	sr          protocol.StateReader
+ }
+
+ // NewStakingCommand creates a staking command center to manage staking committee and new native staking",I think it is weird to store sr in protocol struct,Please remove this if it will not be used.
+9528,"@@ -7308,6 +7308,16 @@ NATable * NATableDB::get(const ExtendedQualName* key, BindWA* bindWA, NABoolean
+      }
+   }
+
++  // the reload cqd will be set during aqr after compiletime and runtime
++  // timestamp mismatch is detected.
++  // If set, reload hive metadata.
++  if ((cachedNATable->isHiveTable()) &&
++      (CmpCommon::getDefault(HIVE_DATA_MOD_CHECK) == DF_ON) &&
++      (CmpCommon::getDefault(TRAF_RELOAD_NATABLE_CACHE) == DF_ON))
++    {
++      removeEntry = TRUE;
++    }
++
+   //Found in cache.  If that's all the caller wanted, return now.
+   if ( !removeEntry && findInCacheOnly )
+      return cachedNATable;",Will this cause a reload _all_ NATable information? It's too bad we don't have some way to limit the reload to just the tables that have a metadata mismatch.,`removeEntry` should be set to `TRUE` whenever `updateCache` is called.
+9529,"@@ -111,6 +111,7 @@ var opDocList = []stringString{
+ 	{""app_global_del"", ""delete key A from a global state of the current application""},
+ 	{""asset_holding_get"", ""read from account specified by Txn.Accounts[A] and asset B holding field X (imm arg) => {0 or 1 (top), value}""},
+ 	{""asset_params_get"", ""read from asset Txn.ForeignAssets[A] params field X (imm arg) => {0 or 1 (top), value}""},
++	{""assert"", ""immediately fail unless value X is not zero""},
+ }
+
+ var opDocByName map[string]string",'fail unless X is a non-zero number' it will also fail if X is a byte string,"""immediately fail unless value X is not zero"" sounds a bit weird."
+9530,"@@ -1447,10 +1447,13 @@ class ElementPlot(BokehPlot, GenericElementPlot):
+         """"""
+         Resets RangeXY streams if norm option is set to framewise
+         """"""
+-        if self.overlaid:
++        # Temporarily reverts this fix (see https://github.com/holoviz/holoviews/issues/4396)
++        # This fix caused PlotSize change events to rerender
++        # rasterized/datashaded with the full extents which was wrong
++        if self.overlaid or True:
+             return
+         for el, callbacks in self.traverse(lambda x: (x.current_frame, x.callbacks)):
+-            if el is None:
++            if el is None:W
+                 continue
+             for callback in callbacks:
+                 norm = self.lookup_options(el, 'norm').options",SyntaxError I think,How about `if not self.overlaid:`?
+9531,"@@ -5012,6 +5012,9 @@ TEST_F(VkLayerTest, ValidateGeometryNV) {
+         vkCreateAccelerationStructureNV(m_device->handle(), &as_create_info, nullptr, &as);
+         m_errorMonitor->VerifyFound();
+     }
++#if 0
++    // XXX Subtest disabled because this is the wrong VUID.
++    // No VUIDs currently exist to require memory is bound (spec bug).
+     // Invalid vertex buffer - no memory bound.
+     {
+         VkGeometryNV geometry = valid_geometry_triangles;",I've filed an internal spec issue to add these missing VUs.,This is the same as #endif // No VUIDs currently exist to require memor
+9532,"@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver;
+ import org.openqa.selenium.WebElement;
+
+ import java.io.IOException;
++import java.io.UncheckedIOException;
+ import java.net.URL;
+ import java.nio.charset.StandardCharsets;
+ import java.util.ArrayList;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,Need to remove this unused import.
+9533,"@@ -24,16 +24,11 @@ import java.math.BigInteger;
+ import java.nio.ByteBuffer;
+ import java.time.Instant;
+ import java.time.ZoneOffset;
++import java.util.Arrays;
+ import java.util.List;
+ import java.util.Map;
+-import org.apache.flink.table.data.ArrayData;
+-import org.apache.flink.table.data.DecimalData;
+-import org.apache.flink.table.data.GenericRowData;
+-import org.apache.flink.table.data.MapData;
+-import org.apache.flink.table.data.RawValueData;
+-import org.apache.flink.table.data.RowData;
+-import org.apache.flink.table.data.StringData;
+-import org.apache.flink.table.data.TimestampData;
++
++import org.apache.flink.table.data.*;
+ import org.apache.iceberg.MetadataColumns;
+ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.parquet.ParquetValueReader;","In iceberg, we usually don't use `*` to import package, it's more clear to import the specify package one by one.",We usually don't do wildcard impor
+9534,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+
+ import com.google.common.collect.Maps;
+
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.,Is this import needed?
+9535,"@@ -18,7 +18,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure
+             // There's no reason to stop timing the write after the connection is closed.
+             var oneBufferSize = maxResponseBufferSize.Value;
+             var maxBufferedBytes = oneBufferSize < long.MaxValue / 2 ? oneBufferSize * 2 : long.MaxValue;
+-            timeoutControl.StartTimingWrite(minDataRate, maxBufferedBytes);
++            timeoutControl.BytesWritten(minDataRate, maxBufferedBytes);
++            timeoutControl.StartTimingWrite();
+         }
+     }
+ }","Since we now keep track of all bytes written, and extend the write timeout as needed, it's tempting to no longer add 2 times the max buffer size to the bytes written accounting for the connection drain timeout. As we've discussed before, this add several minutes to the timeout with the default 240 bytes/sec rate limit. I'm thinking instead this line changes to `timeoutControl.BytesWritten(minDataRate, 1);` to add a grace period to the drain if necessary. What do you think @Tratcher?",Wouldn't it be better to call `Sta
+9536,"@@ -0,0 +1,18 @@
++const formPropsSet = new Set([
++	'form',
++	'formAction',
++	'formEncType',
++	'formMethod',
++	'formNoValidate',
++	'formTarget',
++]);
++
++export default function getFormProps(props) {
++	return Object.keys(props).reduce((prev, key) => {
++		if (formPropsSet.has(key)) {
++			// eslint-disable-next-line no-param-reassign
++			prev[key] = props[key];
++		}
++		return prev;
++	}, {});
++}",Good call. Makes we wonder if we should do this with the ARIA props.,"I think you can just return `props[key]` here. The `Object.keys` will return null if key is not present, so you don't need the `if`."
+9537,"@@ -24,9 +24,7 @@ import java.io.InputStream;
+ import java.io.InputStreamReader;
+ import java.io.Reader;
+ import java.nio.charset.Charset;
+-import java.sql.Connection;
+-import java.sql.DatabaseMetaData;
+-import java.sql.SQLException;
++import java.sql.*;
+ import java.text.ParseException;
+ import java.util.ArrayList;
+ import java.util.Calendar;",Please do not use wildcard imports.,nit: I think our guidelines prefer explicit imports
+9538,"@@ -386,6 +386,7 @@ struct wlr_surface *wlr_surface_create(struct wl_resource *res,
+ 		wl_resource_post_no_memory(res);
+ 		return NULL;
+ 	}
++	wlr_log(L_DEBUG, ""New wlr_surface %p (res %p)"", surface, res);
+ 	surface->renderer = renderer;
+ 	surface->texture = wlr_render_texture_create(renderer);
+ 	surface->resource = res;","Not sure about these added logs, as said in the commit message it's probably not something we want all the time, but it helped me debug a bit.",The `wl_resource_post_no_memory` call below is likely to be removed.
+9539,"@@ -487,8 +487,6 @@ class Comparison(ComparisonInterface):
+         paths2 = el2.split()
+         if len(paths1) != len(paths2):
+             raise cls.failureException(""%s objects do not have a matching number of paths."" % msg)
+-        for p1, p2 in zip(paths1, paths2):
+-            cls.compare_dataset(p1, p2, '%s data' % msg)
+
+     @classmethod
+     def compare_contours(cls, el1, el2, msg='Contours'):",Should there be an equivalent check or is it ok to remove this comparison?,why did you remove this?
+9540,"@@ -57,7 +57,7 @@ def run_migrations_online():
+
+     # this callback is used to prevent an auto-migration from being generated
+     # when there are no changes to the schema
+-    # reference: http://alembic.readthedocs.org/en/latest/cookbook.html
++    # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html
+     def process_revision_directives(context, revision, directives):
+         if getattr(config.cmd_opts, 'autogenerate', False):
+             script = directives[0]","sorry, why this change?",can we revert the change here?
+9541,"@@ -82,7 +82,7 @@ public abstract class AnalysisRequestHandlerBase extends RequestHandlerBase {
+    *
+    * @throws Exception When analysis fails.
+    */
+-  protected abstract NamedList doAnalysis(SolrQueryRequest req) throws Exception;
++  protected abstract NamedList<?> doAnalysis(SolrQueryRequest req) throws Exception;
+
+   /**
+    * Analyzes the given value using the given Analyzer.","I think best practice is to use `NamedList<Object>` as the return type, and `NamedList<?>` as the argument type in methods, but I can't find a reference for it right now.",Shouldn't this be `Optional<Na
+9542,"@@ -23,7 +23,9 @@ use Thelia\Core\Template\Element\PropelSearchLoopInterface;
+ use Thelia\Core\Template\Loop\Argument\Argument;
+ use Thelia\Core\Template\Loop\Argument\ArgumentCollection;
+ use Thelia\Coupon\Type\CouponInterface;
++use Thelia\Model\Base\CouponModule;
+ use Thelia\Model\Coupon as MCoupon;
++use Thelia\Model\CouponCountry;
+ use Thelia\Model\CouponQuery;
+ use Thelia\Model\Map\CouponTableMap;
+ use Thelia\Type\EnumListType;","Be careful, the base model is imported here !",The `use` statement should be
+9543,"@@ -60,7 +60,7 @@ func RootCommand() (*cobra.Command, *Flags) {
+ 	rootCmd.PersistentFlags().IntVar(&cfg.HttpPort, ""http.port"", node.DefaultHTTPPort, ""HTTP-RPC server listening port"")
+ 	rootCmd.PersistentFlags().StringSliceVar(&cfg.HttpCORSDomain, ""http.corsdomain"", []string{}, ""Comma separated list of domains from which to accept cross origin requests (browser enforced)"")
+ 	rootCmd.PersistentFlags().StringSliceVar(&cfg.HttpVirtualHost, ""http.vhosts"", node.DefaultConfig.HTTPVirtualHosts, ""Comma separated list of virtual hostnames from which to accept requests (server enforced). Accepts '*' wildcard."")
+-	rootCmd.PersistentFlags().StringSliceVar(&cfg.API, ""http.api"", []string{""eth""}, ""API's offered over the HTTP-RPC interface"")
++	rootCmd.PersistentFlags().StringSliceVar(&cfg.API, ""http.api"", []string{""eth"", ""tg""}, ""API's offered over the HTTP-RPC interface"")
+ 	rootCmd.PersistentFlags().Uint64Var(&cfg.Gascap, ""rpc.gascap"", 0, ""Sets a cap on gas that can be used in eth_call/estimateGas"")
+ 	rootCmd.PersistentFlags().Uint64Var(&cfg.MaxTraces, ""trace.maxtraces"", 200, ""Sets a limit on traces that can be returned in trace_filter"")
+ 	rootCmd.PersistentFlags().StringVar(&cfg.TraceType, ""trace.type"", ""parity"", ""Specify the type of tracing [geth|parity*] (experimental)"")","Do we want to make this part of the default? Probably not. In fact, the default should probably be eth, web3 and net (which are the standard namespaces on other nodes).",Happy to see the trailing `tg`
+9544,"@@ -1,4 +1,8 @@
+ class Clump < ActiveRecord::Base
+   belongs_to :code_set
+   belongs_to :slave
++
++  def path
++    slave.path_from_code_set_id(code_set_id)
++  end
+ end",What is the plan when we deploy the Crawler VM project and eliminate the Clump model?,"Unused method argument - code_set_id. If it's necessary, use _ or _id as an argument name to indicate that it won't be used."
+9545,"@@ -28,10 +28,6 @@ type MultiClusterConfig struct {
+ 	metav1.TypeMeta `json:"",inline""`
+ 	// ControllerManagerConfigurationSpec returns the contfigurations for controllers
+ 	config.ControllerManagerConfigurationSpec `json:"",inline""`
+-	// Leader is a role of ClusterSet member cluster
+-	Leader bool `json:""leader,omitempty""`
+-	// Member is a role of ClusterSet member cluster
+-	Member bool `json:""member,omitempty""`
+ }
+
+ func init() {","these two are customized config fields, if we don't need them any more, we probably can use default ControllerManagerConfiguration","these were in the wrong order, the json tag should be `omitempty`"
+9546,"@@ -39,7 +39,12 @@ var (
+ 	defaultExecutablePathProvider executablePathProvider = os.Executable
+ 	defaultCommandArgsProvider    commandArgsProvider    = func() []string { return os.Args }
+ 	defaultOwnerProvider          ownerProvider          = user.Current
+-	defaultRuntimeNameProvider    runtimeNameProvider    = func() string { return runtime.Compiler }
++	defaultRuntimeNameProvider    runtimeNameProvider    = func() string {
++		if runtime.Compiler == ""gc"" {
++			return ""go""
++		}
++		return runtime.Compiler
++	}
+ 	defaultRuntimeVersionProvider runtimeVersionProvider = runtime.Version
+ 	defaultRuntimeOSProvider      runtimeOSProvider      = func() string { return runtime.GOOS }
+ 	defaultRuntimeArchProvider    runtimeArchProvider    = func() string { return runtime.GOARCH }","I don't think we should be pulling the runtime name from the Compiler. There are two compiler frontends, but both of them compile the same source to generate the ""go"" runtime. I think until there is a request from an alternative implementation (the embedded world **might** have a different runtime), it's fine to hardcode this as ""go""","I don't quite understand why this is necessary. If the runtime doesn't support gc, why is this necessary?"
+9547,"@@ -932,6 +932,10 @@ Model.find = function find (conditions, fields, options, callback) {
+     options = null;
+   }
+
++  if (this.schema.discriminatorMapping && fields) {
++    fields = fields + ' ' + this.schema.options.discriminatorKey;
++  }
++
+   // get the raw mongodb collection object
+   var mq = new Query({}, options, this, this.collection);
+   mq.select(fields);",fields may be an object.,"I think this should be done in the constructor, even when `discriminatorMapping` is not defined."
+9548,"@@ -4,12 +4,12 @@ import (
+ 	""bufio""
+ 	""encoding/json""
+ 	""fmt""
+-	""io/ioutil""
+ 	""log""
+ 	""net/http""
+ 	""net/url""
+ 	""strings""
+ 	""sync""
++	""time""
+
+ 	""github.com/hashicorp/hcl""
+ 	""github.com/spiffe/spire/proto/agent/workloadattestor""",i'm not confident these are the right defaults... anybody have input?,Go imports should be sorted lexicographically
+9549,"@@ -80,7 +80,7 @@ type CasPool struct {
+ 	Namespace string
+
+ 	// DiskList is the list of disks over which a storagepool will be provisioned
+-	DiskList []string
++	DiskList []DiskGroup
+
+ 	// PoolType is the type of pool to be provisioned e.g. striped or mirrored
+ 	PoolType string",DiskGroupList can be better name,This is a breaking change and needs to be add
+9550,"@@ -229,7 +229,7 @@ func customErrorHandler(ctx context.Context, mux *runtime.ServeMux, m runtime.Ma
+ 	runtime.DefaultHTTPErrorHandler(ctx, mux, m, w, req, err)
+ }
+
+-func New(unaryInterceptors []grpc.UnaryServerInterceptor, assets http.FileSystem, gatewayCfg *gatewayv1.GatewayOptions) (*Mux, error) {
++func New(unaryInterceptors []grpc.UnaryServerInterceptor, assets http.FileSystem, gatewayCfg *gatewayv1.GatewayOptions, metricsHandler http.Handler) (*Mux, error) {
+ 	secureCookies := true
+ 	if gatewayCfg.SecureCookies != nil {
+ 		secureCookies = gatewayCfg.SecureCookies.Value",nit: lets leave gateway options at the end of the func signature.,I don't see `metricsHandler` being used. Do y
+9551,"@@ -527,7 +527,7 @@ public class PDKClient {
+         SharedPreferences sharedPref = _context.getSharedPreferences(PDK_SHARED_PREF_FILE_KEY, Context.MODE_PRIVATE);
+         SharedPreferences.Editor editor = sharedPref.edit();
+         editor.putString(PDK_SHARED_PREF_TOKEN_KEY, accessToken);
+-        editor.commit();
++        editor.apply();
+     }
+
+     private static String restoreAccessToken() {","It will be better to use `commit()` on a separate thread, apart from the UI thread. The reason is `commit()` is synchronous while `apply()` is asynchronous. So in case it might not perform actions immediately as expected.","AFAICT this will always be committed, so you "
+9552,"@@ -123,10 +123,10 @@ func (q *queryImpl) validateTerminationState(
+ 		queryResult := terminationState.queryResult
+ 		validAnswered := queryResult.GetResultType().Equals(shared.QueryResultTypeAnswered) &&
+ 			queryResult.Answer != nil &&
+-			queryResult.ErrorMessage == nil
++			(queryResult.ErrorMessage == nil || *queryResult.ErrorMessage == """")
+ 		validFailed := queryResult.GetResultType().Equals(shared.QueryResultTypeFailed) &&
+ 			queryResult.Answer == nil &&
+-			queryResult.ErrorMessage != nil
++			(queryResult.ErrorMessage != nil && *queryResult.ErrorMessage != """")
+ 		if !validAnswered && !validFailed {
+ 			return errTerminationStateInvalid
+ 		}",Took me almost 4 hours to find this.,Why do we need this?
+9553,"@@ -8,9 +8,9 @@ from .concat_dataset import ConcatDataset
+ from .repeat_dataset import RepeatDataset
+ from .extra_aug import ExtraAugmentation
+
++
+ __all__ = [
+     'CustomDataset', 'XMLDataset', 'CocoDataset', 'VOCDataset', 'GroupSampler',
+     'DistributedGroupSampler', 'build_dataloader', 'to_tensor', 'random_scale',
+     'show_ann', 'get_dataset', 'ConcatDataset', 'RepeatDataset',
+-    'ExtraAugmentation'
+-]
++    'ExtraAugmentation']",There should be only a single blank line between imports and `__all__`.,Please remove this e
+9554,"@@ -194,7 +194,7 @@ public class TestCloudPseudoReturnFields extends SolrCloudTestCase {
+       SolrDocumentList docs = assertSearch(params(""q"", ""*:*"", ""rows"", ""10"", ""fl"",fl));
+       // shouldn't matter what doc we pick...
+       for (SolrDocument doc : docs) {
+-        assertEquals(fl + "" => "" + doc, 4, doc.size());
++        assertEquals(fl + "" => "" + doc, 5, doc.size());
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""id"") instanceof String);
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""val_i"") instanceof Integer);
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""subject"") instanceof String);",Doc size increased by 1 since _root_ is also returned by queries.,@julienlancelot @sns
+9555,"@@ -822,8 +822,14 @@ def color_intervals(colors, levels, clip=None, N=255):
+         clmin, clmax = clip
+         lidx = int(round(N*((clmin-cmin)/interval)))
+         uidx = int(round(N*((cmax-clmax)/interval)))
+-        cmap = cmap[lidx:N-uidx]
+-    return cmap
++        uidx = N-uidx
++        if lidx == uidx:
++            uidx = lidx+1
++        cmap = cmap[lidx:uidx]
++        if clmin == clmax:
++            idx = np.argmin(np.abs(np.array(levels)-clmin))
++            clip = levels[idx: idx+2] if len(levels) > idx+2 else levels[idx-1: idx+1]
++    return cmap, clip
+
+
+ def dim_axis_label(dimensions, separator=', '):",Now the return value has changed (or at least now includes `clip`) it might be worth updating the docstring...,shouldn't this be `i
+9556,"@@ -411,7 +411,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet()
++				ws, err := sf.NewWorkingSet(nil)
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 410 (from `govet`)",You could pass in a context of the current workspace instead of `nil`.
+9557,"@@ -82,7 +82,13 @@ class Flashmessages extends AbstractHelper
+                 $this->fm->getMessages($ns), $this->fm->getCurrentMessages($ns)
+             );
+             foreach (array_unique($messages, SORT_REGULAR) as $msg) {
+-                $html .= '<div class=""' . $this->getClassForNamespace($ns) . '"">';
++                $html .= '<div class=""' . $this->getClassForNamespace($ns) . '""';
++                if (isset($msg['dataset'])) {
++                    foreach ($msg['dataset'] as $attr => $value) {
++                        $html .= ' data-' . $attr . '=""' . $value . '""';
++                    }
++                }
++                $html .= '>';
+                 // Advanced form:
+                 if (is_array($msg)) {
+                     // Use a different translate helper depending on whether",Should we be escaping $attr and/or $value here? Seems like htmlspecialchars() might be in order to be on the safe side.,The `as $attr` parameter is not used in this `if` statement.
+9558,"@@ -40,6 +40,7 @@ module Travis
+           def clone_args
+             args = ""--depth=#{depth}""
+             args << "" --branch=#{branch}"" unless data.ref
++	    args << "" #{quiet_o}""
+             args
+           end
+ ","why not remove the need for the `quiet_o` method and just add it similar to how the `--branch` is added? also, looks like the indenting is a little off",Wouldn't it be better to do this in `clone_args`?
+9559,"@@ -96,8 +96,9 @@ public class FlowContainer {
+   private static final String CONF_DIR = ""conf"";
+   private static final String JOB_THREAD_COUNT = ""flow.num.job.threads"";
+   private static final String DEFAULT_LOG_CHUNK_SIZE = ""5MB"";
++  private static final String FLOW_EXECUTION_ID = ""FLOW_EXECUTION_ID"";
++  private static final String VERSION_SET_ID = ""VERSION_SET_ID"";
+   private static final int DEFAULT_LOG_NUM_FILES = 4;
+-  private static final int EXEC_ID_INDEX = 0;
+   private static final int DEFAULT_JOB_TREAD_COUNT = 10;
+   private static final boolean DEFAULT_USE_IN_MEMORY_KEYSTORE = false;
+   // Should validate proxy user",These variables are already created in constants. Please reuse those.,This should be flow-specific and not part of the flow-specific configu
+9560,"@@ -156,6 +156,10 @@ class Key(object):
+         if self.resp == None:
+             self.mode = 'r'
+
++            if self.version_id:
++                query_args = query_args or []
++                query_args.append('versionId=%s' % self.version_id)
++
+             provider = self.bucket.connection.provider
+             self.resp = self.bucket.connection.make_request(
+                 'GET', self.bucket.name, self.name, headers,","query_args is a string, not a list. Therefore you cannot call append to it. Also, line 986-989 of key.py already have code that is appending the versionId query parameter.","Hmm, looks like we are relying on `self.version_id` rather than `self.bucket.version_id`?"
+9561,"@@ -548,12 +548,12 @@ func (f *Fs) newObjectWithInfo(ctx context.Context, remote string, info *api.Fil
+ 	if info != nil {
+ 		err := o.decodeMetaData(info)
+ 		if err != nil {
+-			return nil, err
++			return o, err
+ 		}
+ 	} else {
+ 		err := o.readMetaData(ctx) // reads info and headers, returning an error
+ 		if err != nil {
+-			return nil, err
++			return o, err
+ 		}
+ 	}
+ 	return o, nil",I think this change and the one below will break the integration tests which expect a `nil` object if `NewObject` fails.,"@brycemcanally shouldn't this be `return o, nil`?"
+9562,"@@ -1,6 +1,7 @@
+ # frozen_string_literal: true
+
+ require 'hocon'
++require 'bolt/error'
+
+ class TransportConfig
+   attr_accessor :host, :port, :ssl_cert, :ssl_key, :ssl_ca_cert, :ssl_cipher_suites,",Looks like this isn't used in this file?,I am surprised you don't use `hocon` here.
+9563,"@@ -327,7 +327,10 @@ class PandasLikeSeries(_Frame):
+             sum = df_dropna._spark_count()
+             df = df._spark_withColumn('count', F._spark_col('count') / F._spark_lit(sum))
+
+-        return _col(df.set_index([self.name]))
++        hidden_name = 'index' if self.name != 'index' else 'level_0'
++        df.columns = [hidden_name, self.name]
++        df._metadata = Metadata(column_fields=[self.name], index_info=[(hidden_name, None)])
++        return _col(df)
+
+     @property
+     def _pandas_anchor(self) -> DataFrame:",why hidden name? How about `index_name`?,"Also should be `(self.name, self.level_0)`"
+9564,"@@ -367,6 +367,9 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
+   char cursorId[8];
+   HdfsFileInfo *hdfo = NULL;
+   Lng32 openType = 0;
++  int hiveScanMode = 0;
++
++  hiveScanMode = CmpCommon::getDefaultLong(HIVE_SCAN_SPECIAL_MODE);
+
+   while (!qparent_.down->isEmpty())
+     {","Usually, CQDs are not accessed directly in executor operators directly. It should be passed as a flag in the TDB. It is possible that the query is compiled in a different process, then this CQD setting won't be available in the executor layer.",Does this need to be a `long`? Wouldn't `int` be simpler?
+9565,"@@ -477,9 +477,9 @@ func ShardID(shardID int32) ZapTag {
+ 	return NewInt32(""shard-id"", shardID)
+ }
+
+-// ShardItem returns tag for ShardItem
+-func ShardItem(shardItem interface{}) ZapTag {
+-	return NewAnyTag(""shard-item"", shardItem)
++// ShardContext returns tag for shard.Context
++func ShardContext(shard interface{}) ZapTag {
++	return NewAnyTag(""shard-context"", shard)
+ }
+
+ // ShardTime returns tag for ShardTime","This tag was broken, the value write to log was the memory address. Please verify that this actually write out meaningful content in log.",should this be `shard-context`?
+9566,"@@ -0,0 +1,9 @@
++""""""Checks import position rule with pep-0008""""""
++# pylint: disable=unused-import,relative-import,ungrouped-imports,import-error,no-name-in-module,relative-beyond-top-level,undefined-variable
++
++__author__ = 'some author'
++__email__ = 'some.author@some_email'
++__copyright__ = 'Some copyright'
++
++
++import sys",Why do you have to disable all of these checks?,Do we need this file?
+9567,"@@ -1639,6 +1639,7 @@ class CommandDispatcher:
+         """"""
+         try:
+             elem.set_value(text)
++            mainwindow.raise_window(objreg.last_focused_window())
+         except webelem.OrphanedError as e:
+             message.error('Edited element vanished')
+         except webelem.Error as e:","Just a note to myself: After merging this, I should edit the line after this one to use `message.error`, as raising a `CommandError` from here seems wrong!",what happens if the edited element has no active window?
+9568,"@@ -1010,8 +1010,6 @@ GLOBAL_LABEL(FUNCNAME:)
+         mov      TEST_REG2_ASM, 1
+         /* xax statelessly restored here. */
+         mov      TEST_REG2_ASM, 2
+-        /* xax is dead, so initial aflags spill should not use slot. */
+-        mov      REG_XAX, 0
+         jmp      test28_done
+      test28_done:
+         /* Fail if aflags were not restored correctly. */","In this test, we want xax to be dead, so that aflags are not spilled to a slot.",Is it safe to remove this? It looks like it's only used in one test.
+9569,"@@ -54,7 +54,9 @@ type Options struct {
+
+ func newOptions() *Options {
+ 	return &Options{
+-		config: new(AgentConfig),
++		config: &AgentConfig{
++			EnablePrometheusMetrics: true,
++		},
+ 	}
+ }
+ ","I remember there were some misleading code about this but forgot to correct them. Although we initialize `config` here, it was discarded in `complete`, so I guess setting the default value here doesn't take effect. We should change L139-L140 as well to use the initialized `config`. So do antrea-controller.","The `enablePrometheusMetrics` is already defaulting to `true`, so th"
+9570,"@@ -364,4 +364,13 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
+       output.string.should =~ /, 100.0% of total time\):/
+     end
+   end
++
++  describe ""custom_colors"" do
++    before { RSpec.configuration.stub(:color_enabled?) { true } }
++    it ""uses the custom success color"" do
++      RSpec.configuration.stub(:success_color).and_return(:cyan)
++      formatter.dump_summary(0,1,0,0)
++      output.string.should include(""\e[36m"")
++    end
++  end
+ end","Stubbin a value object (like `RSpec.configuration`) is a bit of a code smell, I think. You can just set `color_enabled` and `success_color` through the configuration APIs provided by `RSpec::Configuration` -- no need to stub. The `sandboxed` thing in `spec_helper.rb` takes care of preventing changes to the configuration object in one example from leaking into other examples.",Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block
+9571,"@@ -624,9 +624,14 @@ API.prototype.getBalanceFromPrivateKey = function(privateKey, coin, cb) {
+   var B = Bitcore_[coin];
+
+   var privateKey = new B.PrivateKey(privateKey);
+-  var address = privateKey.publicKey.toAddress();
++
++  var address = privateKey.publicKey.toAddress().toString();
++  if (coin == 'bch') {
++    address = privateKey.publicKey.toAddress().toCashAddress().replace('bitcoincash:', '');
++  }
++
+   self.getUtxos({
+-    addresses: coin == 'bch' ? address.toLegacyAddress() : address.toString(),
++    addresses: address,
+   }, function(err, utxos) {
+     if (err) return cb(err);
+     return cb(null, _.sumBy(utxos, 'satoshis'));",you can use `toString(true)` that will work for BTC and remove the prefix for BCH.,"hmm, why do you need to do this for bch?"
+9572,"@@ -652,9 +652,10 @@ class TabbedBrowser(tabwidget.TabWidget):
+
+         log.modes.debug(""Current tab changed, focusing {!r}"".format(tab))
+         tab.setFocus()
+-        for mode in [usertypes.KeyMode.hint, usertypes.KeyMode.insert,
+-                     usertypes.KeyMode.caret, usertypes.KeyMode.passthrough]:
+-            modeman.leave(self._win_id, mode, 'tab changed', maybe=True)
++        if not config.val.tabs.persist_mode_on_change:
++            for mode in [usertypes.KeyMode.hint, usertypes.KeyMode.insert,
++                         usertypes.KeyMode.caret, usertypes.KeyMode.passthrough]:
++                modeman.leave(self._win_id, mode, 'tab changed', maybe=True)
+         if self._now_focused is not None:
+             objreg.register('last-focused-tab', self._now_focused, update=True,
+                             scope='window', window=self._win_id)",This line is too long now - please break it after the comma.,Does this need a try/except?
+9573,"@@ -67,6 +67,7 @@ type StreamerDisconnecter interface {
+ type Stream interface {
+ 	io.ReadWriter
+ 	io.Closer
++	ResponseHeaders() Headers
+ 	Headers() Headers
+ 	FullClose() error
+ 	Reset() error","I find this addition to the interface a bit contentious. I think it would be cleaner to just return the response headers together with the new stream on `NewStream`. I.e. change the method signature for `NewStream` to be: `NewStream(ctx context.Context, overlay swarm.Address, headers p2p.Headers, protocolName, protocolVersion, streamName string) (p2p.Stream, p2p.Headers, error)`. I'd like to hear what other think. cc @zelig @janos",Does this interface really n
+9574,"@@ -222,6 +222,12 @@ class CartFacade
+
+         if ($cart !== null) {
+             $this->cartWatcherFacade->checkCartModifications($cart);
++
++            if ($cart->isEmpty()) {
++                $this->deleteCart($cart);
++
++                return null;
++            }
+         }
+
+         return $cart;","i hope there is some magic where isEmpty or some cron can strip all non listable products from cart, but since we have the situation tested it should be OK and also we'll see during tests",Shouldn't we do a `null` che
+9575,"@@ -127,7 +127,7 @@ public class HiveIcebergFilterFactory {
+       case FLOAT:
+         return leaf.getLiteral();
+       case DATE:
+-        return daysFromTimestamp((Timestamp) leaf.getLiteral());
++        return daysFromDate((Date) leaf.getLiteral());
+       case TIMESTAMP:
+         return microsFromTimestamp((Timestamp) LITERAL_FIELD.get(leaf));
+       case DECIMAL:",I think we should check the type returned by `getLiteral` and handle that here. Then we won't need separate code for different versions.,I'm not sure if this is a se
+9576,"@@ -131,13 +131,13 @@ func (s *HandlerTestSuite) TestFetchX509SVID() {
+ func (s *HandlerTestSuite) TestSendResponse() {
+ 	emptyUpdate := new(cache.WorkloadUpdate)
+ 	s.stream.EXPECT().Send(gomock.Any()).Times(0)
+-	err := s.h.sendResponse(emptyUpdate, s.stream)
++	err := s.h.sendX509SVIDResponse(emptyUpdate, s.stream)
+ 	s.Assert().Error(err)
+
+-	resp, err := s.h.composeResponse(s.workloadUpdate())
++	resp, err := s.h.composeX509SVIDResponse(s.workloadUpdate())
+ 	s.Require().NoError(err)
+ 	s.stream.EXPECT().Send(resp)
+-	err = s.h.sendResponse(s.workloadUpdate(), s.stream)
++	err = s.h.sendX509SVIDResponse(s.workloadUpdate(), s.stream)
+ 	s.Assert().NoError(err)
+ }
+ ",Tests for JWT handler functionality?,[nit] Could be `s.h.sendX509SVIDResponse(s.workloadUpdate())`
+9577,"@@ -548,9 +548,6 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
+                         ""POST / HTTP/1.1"",
+                         ""Content-Length: 3"",
+                         """",
+-                        ""101POST / HTTP/1.1"",
+-                        ""Content-Length: 3"",
+-                        """",
+                         ""204POST / HTTP/1.1"",
+                         ""Content-Length: 3"",
+                         """",","It's weird to set a 101 response and complete without writing anything, but this is still a valid test case right?",Why did you change this?
+9578,"@@ -207,6 +207,19 @@ class DefaultBucketViewTest(FormattedErrorMixin, BaseWebTest,
+             self.assertEqual(resp.body, response.body)
+
+
++class HelloViewTest(BaseWebTest, unittest.TestCase):
++
++    def test_returns_bucket_id_and_url_if_authenticated(self):
++        response = self.app.get('/', headers=self.headers)
++        self.assertEqual(response.json['user']['bucket'],
++                         '23bb0efc-e80d-829e-6757-79d41e16640f')
++
++    def test_flush_capability_if_enabled(self):
++        resp = self.app.get('/')
++        capabilities = resp.json['capabilities']
++        self.assertIn('default_bucket', capabilities)
++
++
+ class ReadonlyDefaultBucket(BaseWebTest, unittest.TestCase):
+
+     def get_app_settings(self, extras=None):",Should we move that information in the capability itself?,Can you also assert something about `response.status` and `re
+9579,"@@ -18,6 +18,9 @@ class StatisticsElement(Chart):
+
+     __abstract = True
+
++    # Ensure Interface does not add an index
++    _auto_indexable_1d = False
++
+     def __init__(self, data, kdims=None, vdims=None, **params):
+         if isinstance(data, Element):
+             params.update(get_param_values(data))",Is this needed?,It does not add an index. It does not add an index.
+9580,"@@ -163,7 +163,7 @@ func (r *ReconcileRemoteClusterIngress) Reconcile(request reconcile.Request) (re
+ 	// can't proceed if the secret(s) referred to doesn't exist
+ 	certBundleSecrets, err := r.getIngressSecrets(rContext)
+ 	if err != nil {
+-		rContext.logger.WithError(err).Error(""will need to retry until able to find all certBundle secrets"")
++		rContext.logger.Warningf(""will need to retry until able to find all certBundle secrets : %v"", err)
+ 		conditionErr := r.setIngressCertificateNotFoundCondition(rContext, true, err.Error())
+ 		if conditionErr != nil {
+ 			rContext.logger.WithError(conditionErr).Error(""unable to set IngressCertNotFound condition"")",This log should not be an error as it communicates that we need to retry till we get the cert information for remote ingress controller.,Why was this changed?
+9581,"@@ -130,6 +130,8 @@ namespace Nethermind.Blockchain
+         BlockHeader[] FindHeaders(Keccak hash, int numberOfBlocks, int skip, bool reverse);
+
+         void DeleteInvalidBlock(Block invalidBlock);
++
++        void Flush();
+
+         event EventHandler<BlockEventArgs> NewBestSuggestedBlock;
+         event EventHandler<BlockEventArgs> BlockAddedToMain;","BlockTree alredy has a polluted API, this one seems very internal",why do we need to add
+9582,"@@ -123,6 +123,7 @@ describe ""BoltSpec::Run"", ssh: true do
+
+     describe 'apply_manifest' do
+       it 'should apply a manifest file' do
++        bolt_inventory['features'] = ['puppet-agent']
+         with_tempfile_containing('manifest', ""notify { 'hello world': }"", '.pp') do |manifest|
+           results = apply_manifest(manifest.path, 'ssh')
+           results.each do |result|","Sorry, I realize my line numbers were probably off after you deleted your variables! I meant for this to go in the `before(:all) do` and `after(:all) do` blocks.",this looks like it sh
+9583,"@@ -195,7 +195,9 @@ public class ToParentBlockJoinQuery extends Query {
+           return null;
+         }
+       }
+-      return MatchesUtils.MATCH_WITH_NO_TERMS;
++
++      // TODO: which fields should be here?
++      return MatchesUtils.matchWithNoTerms(getQuery());
+     }
+   }
+ ",This bit I wasn't really sure about.,It does look like `ge
+9584,"@@ -87,6 +87,7 @@ function buildRules(grunt, options, commons, callback) {
+ 		var tags = options.tags ? options.tags.split(/\s*,\s*/) : [];
+ 		var rules = result.rules;
+ 		var checks = result.checks;
++		parseChecks(checks);
+
+ 		// Translate checks
+ 		if (locale && locale.checks) {","From the code, a check's metatdata was only added to `axe._load` if a rule used it. Since `role-none` and `role-presentation` were no longer used in any rule, their metadata was never added. This caused any translation file that passed translations for those checks to fail `axe.configure` with > ""Locale provided for unknown check: ""role-none"""" To fix I added this line to parse all checks regardless of if a rule uses it or not.","You could move `parseChecks` outside of the `if`, since it is only used once."
+9585,"@@ -740,7 +740,7 @@ class Package:
+             gc.enable()
+         return pkg
+
+-    def set_dir(self, lkey, path=None, meta=None):
++    def set_dir(self, lkey, path=None, meta=None, update_policy=""incoming""):
+         """"""
+         Adds all files from `path` to the package.
+ ","We should raise `ValueError` if `update_policy not in ['existing', 'incoming']`. (or `in Enum.__members__` or however we want to express legal values)","This should be a tuple, not a list. Also, should the default be ""outgoing""?"
+9586,"@@ -42,10 +42,11 @@ namespace MvvmCross.iOS.Platform
+             _applicationDelegate = applicationDelegate;
+         }
+
+-        protected MvxIosSetup(IMvxApplicationDelegate applicationDelegate, IMvxIosViewPresenter presenter)
++        protected MvxIosSetup(IMvxApplicationDelegate applicationDelegate, UIWindow window, IMvxIosViewPresenter presenter) : this (applicationDelegate, window)
+         {
+-            _presenter = presenter;
++            _window = window;
+             _applicationDelegate = applicationDelegate;
++            _presenter = presenter;
+         }
+
+         protected UIWindow Window => _window;","`_applicationDelegate` and `_window` are already set in the call for `: this (applicationDelegate, window)`, no need to assigning them again here",We can probably get rid of _applicationDelegate and just pass _window instead
+9587,"@@ -9,7 +9,7 @@ export function createContext(defaultValue) {
+ 		_id: '__cC' + i++,
+ 		_defaultValue: defaultValue,
+ 		Consumer(props, context) {
+-			return props.children(context);
++			return props.children(props.selector(context));
+ 		},
+ 		Provider(props) {
+ 			if (!this.getChildContext) {",We might not have a selector prop in the consumer,is this selector needed? we call `children` on the `props` object right?
+9588,"@@ -386,7 +386,7 @@ namespace Nethermind.Blockchain.Processing
+                     break;
+                 }
+
+-                bool isFastSyncTransition = _blockTree.Head?.Header == _blockTree.Genesis && toBeProcessed.Number > 1;
++                bool isFastSyncTransition = (_blockTree.Head?.IsGenesis ?? false) && toBeProcessed.Number > 1;
+                 if (!isFastSyncTransition)
+                 {
+                     if (_logger.IsTrace) _logger.Trace($""Finding parent of {toBeProcessed.ToString(Block.Format.Short)}"");",IMO == true is more readable than ?? false,why not rename `isFastSyncTransition` to `isGenesis`?
+9589,"@@ -3,7 +3,7 @@ const test = require('./shared').assert,
+   setupDatabase = require('./shared').setupDatabase,
+   Script = require('vm'),
+   expect = require('chai').expect,
+-  normalizedFunctionString = require('bson/lib/bson/parser/utils').normalizedFunctionString,
++  normalizedFunctionString = require('bson/lib/parser/utils').normalizedFunctionString,
+   Buffer = require('safe-buffer').Buffer;
+
+ const {",feel free when editing sections like this to introduce modern features like object destructuring.,whats with the whitespace changes in this file?
+9590,"@@ -1,3 +1,4 @@
++# coding: utf-8
+ # Copyright (c) 2006-2015 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
+ # Copyright (c) 2012-2014 Google, Inc.
+ # Copyright (c) 2014-2016 Claudiu Popa <pcmanticore@gmail.com>",I think the correct pragma is `# -*- coding: utf-8 -*-,"It's preferable to use the default encoding, which UT"
+9591,"@@ -58,6 +58,9 @@ from scapy.layers.inet import TCP
+ from scapy.packet import Raw
+ from scapy.packet import Packet, bind_layers
+
++from . import iec104, iec104_fields, iec104_information_elements, \
++    iec104_information_objects  # noqa: F401
++
+ IEC_104_IANA_PORT = 2404
+
+ # direction - from the central station to the substation","This fixes some import errors, due to the fact that this file has the same name than its module.",I'm not sure if this import is needed. I think `from
+9592,"@@ -21,8 +21,9 @@ type Folder struct {
+ 	fs   *FS
+ 	list *FolderList
+
+-	handleMu sync.RWMutex
+-	h        *libkbfs.TlfHandle
++	handleMu       sync.RWMutex
++	h              *libkbfs.TlfHandle
++	hPreferredName string
+
+ 	folderBranchMu sync.Mutex
+ 	folderBranch   libkbfs.FolderBranch","I think we need to clear this out on logout, and update it on login, right?",do you still need to mutex here?
+9593,"@@ -43,6 +43,8 @@ gboolean
+ ot_util_filename_validate (const char *name,
+                            GError    **error)
+ {
++  if (name == NULL)
++    return glnx_throw (error, ""Invalid NULL filename"");
+   if (strcmp (name, ""."") == 0)
+     return glnx_throw (error, ""Invalid self-referential filename '.'"");
+   if (strcmp (name, "".."") == 0)","I think normally we'd make this a precondition (using e.g. `g_return_val_if_fail`), but meh, this works too!",This looks like a false positive
+9594,"@@ -34,5 +34,5 @@ public final class Const {
+
+     public static final String SRC_MICROSERVICE = ""x-cse-src-microservice"";
+
+-    public static final String DEST_MICROSERVICE = ""x-cse-dest-microservice"";
++    public static final String TARGET_MICROSERVICE = ""x-cse-target-microservice"";
+ }",Is this header used by other outside service?,Where is this being used?
+9595,"@@ -89,10 +89,3 @@ class TestZipFolder(BZTestCase):
+         result_tree = set(filename[len(destination):] for filename in get_files_recursive(destination))
+         original_tree = set(filename[len(source):] for filename in get_files_recursive(source))
+         self.assertEqual(result_tree, original_tree)
+-
+-    def test_no_work_prov(self):
+-        obj = Unpacker()
+-        obj.engine = EngineEmul()
+-        obj.engine.config[Provisioning.PROV] = 'cloud'
+-        obj.parameters.merge({Unpacker.FILES: ['notexists.zip']})
+-        obj.prepare()",that's fine by me to have simple test for provisioning check,This test was no longer relevant
+9596,"@@ -83,7 +83,7 @@ public class TriggerBasedScheduleLoader implements ScheduleLoader {
+     ConditionChecker checker =
+         new BasicTimeChecker(""BasicTimeChecker_1"", s.getFirstSchedTime(),
+             s.getTimezone(), s.isRecurring(), s.skipPastOccurrences(),
+-            s.getPeriod());
++            s.getPeriod(), s.getCronExpression());
+     checkers.put(checker.getId(), checker);
+     String expr = checker.getId() + "".eval()"";
+     Condition cond = new Condition(checkers, expr);",These two methods seem to be identical except the names. Any idea why two methods are needed?,I may be wrong but I think it should be s.getCronExpression() instead of s.getPeriod()
+9597,"@@ -0,0 +1,14 @@
++#!/usr/bin/env python
++
++
++import sys
++import os
++sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)), "".."", ""..""))
++from influxdb import InfluxDBClient
++import config
++
++try:
++    i = InfluxDBClient(host=config.INFLUX_HOST, port=config.INFLUX_PORT, database=config.INFLUX_TEST_DB)
++    i.create_database(config.INFLUX_TEST_DB)
++except Exception as e:
++    print(""Creating influx DB failed: "", e)",I don't see much difference between this and `create_db` module. How about having a function with a `database` argument?,nit: don't need the `import sys`
+9598,"@@ -183,7 +183,7 @@ class AnalyticsDashboardWidget extends Component {
+ 							</div>
+ 							{ /* Data issue: on error display a notification. On missing data: display a CTA. */ }
+ 							{ ! receivingData && (
+-								error ? getDataErrorComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), true, true, true )
++								error ? getDataErrorComponent( 'analytics', _x( 'Analytics', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), true, true, true )
+ 							) }
+ 							<div className={ classnames(
+ 								'mdc-layout-grid__cell',","See above, no need to pass the module name.",Please split the logic into multiple lines.
+9599,"@@ -316,7 +316,7 @@ class LGBMModel(_LGBMModelBase):
+         group : array-like or None, optional (default=None)
+             Group data of training data.
+         eval_set : list or None, optional (default=None)
+-            A list of (X, y) tuple pairs to use as a validation sets.
++            A list of (X, y) tuple pairs to use as a validation set.
+         eval_names : list of strings or None, optional (default=None)
+             Names of eval_set.
+         eval_sample_weight : list of arrays or None, optional (default=None)","LightGBM supports multiple validation sets, so please leave `sets`.",This still doesn't sound right. You don't have to change the order of the arguments he
+9600,"@@ -19,13 +19,14 @@ package org.openqa.selenium.remote;
+
+ import com.google.common.collect.ImmutableMap;
+
++import org.openqa.selenium.DeviceRotation;
+ import org.openqa.selenium.Rotatable;
+ import org.openqa.selenium.ScreenOrientation;
+
+ import java.lang.reflect.Method;
+
+ public class AddRotatable implements AugmenterProvider {
+-
++
+   public Class<?> getDescribedInterface() {
+     return Rotatable.class;
+   }","you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)","no empty line, please."
+9601,"@@ -1955,15 +1955,7 @@ context 'Substitutions' do
+       end
+
+       test 'should passthrough math macro inside another passthrough' do
+-        input = 'the text `asciimath:[x = y]` should be passed through as +literal+ text'
+-        para = block_from_string input, attributes: { 'compat-mode' => '' }
+-        assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+-
+-        input = 'the text [x-]`asciimath:[x = y]` should be passed through as `literal` text'
+-        para = block_from_string input
+-        assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+-
+-        input = 'the text `+asciimath:[x = y]+` should be passed through as `literal` text'
++        input = 'the text `++asciimath:[x = y]++` should be passed through as `literal` text'
+         para = block_from_string input
+         assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+       end",What is this obscure syntax anyway? o.O,@azdavis can you pleas
+9602,"@@ -756,6 +756,10 @@ class SPRegion(PyRegion):
+     return spec
+
+
++  def getAlgorithm(self):
++    return self._sfdr
++
++
+   def getParameter(self, parameterName, index=-1):
+     """"""
+       Get the value of a NodeSpec parameter. Most parameters are handled","I think we should have one for the CLA Classifier, and KNNClassifier as well. And how about RecordSensor?",Does this need to be p
+9603,"@@ -0,0 +1,9 @@
++package com.fsck.k9.fragment;
++import android.database.Cursor;
++import android.view.ContextMenu;
++/**
++ Created by Kamil Rajtar on 05.11.17. */
++
++public interface ICursorContextMenuSupplier{
++	void getCursorMenu(ContextMenu menu,Cursor cursor);
++}",Missing new line.,typo: `ICursorContextM
+9604,"@@ -17,6 +17,9 @@ const populateModelSymbol = require('../symbols').populateModelSymbol;
+ const schemaMixedSymbol = require('../../schema/symbols').schemaMixedSymbol;
+
+ module.exports = function getModelsMapForPopulate(model, docs, options) {
++  if (model.schema.base.options.strictPopulate == false && options.strictPopulate == null) {
++    options.strictPopulate = model.schema.base.options.strictPopulate;
++  }
+   let doc;
+   const len = docs.length;
+   const map = [];","`model.schema.base.options.strictPopulate != null`. Why hardcoding false? Also, `model.base.options` should work and be shorter. Finally, any way to move this up to the `populate()` function in `model.js` that calls `getModelsMapForPopulate()` and shallow clone the object before modifying? A bit random to modify this option here.",`options.strictPopulate == false` -> `options.strictPopulate == null`
+9605,"@@ -35,10 +35,10 @@ namespace Nethermind.Core.Test
+             ISpecProvider specProvider = new CustomSpecProvider((0, releaseSpec));
+
+             BlockValidator blockValidator = new BlockValidator(txValidator, AlwaysValidHeaderValidator.Instance, AlwaysValidOmmersValidator.Instance, specProvider, LimboLogs.Instance);
+-            bool noiseRemoved = blockValidator.ValidateSuggestedBlock(Build.A.Block.TestObject);
++            bool noiseRemoved = blockValidator.ValidateSuggestedBlock(Builders.Build.A.Block.TestObject);
+             Assert.True(noiseRemoved);
+
+-            bool result = blockValidator.ValidateSuggestedBlock(Build.A.Block.WithOmmers(Build.A.BlockHeader.TestObject).TestObject);
++            bool result = blockValidator.ValidateSuggestedBlock(Builders.Build.A.Block.WithOmmers(Builders.Build.A.BlockHeader.TestObject).TestObject);
+             Assert.False(result);
+         }
+     }",We now have Prepare.A/Build.A/Builders.Build.A - what are the differences?,Why isn't this using `Build.A.Block.TestObject`?
+9606,"@@ -51,6 +51,12 @@ module Asciidoctor
+       append_newline ? %(#{str}#{LF}) : str
+     end
+
++    def preserve_backslash str
++      str = str.
++        gsub(/\\/, '\\e')
++      str
++    end
++
+     def skip_with_warning node, name = nil
+       warn %(asciidoctor: WARNING: converter missing for #{name || node.node_name} node in manpage backend)
+       nil","Could you reduce this to one line and change the first argument to a single quoted backslash string? Perhaps we can add this as an option named `:preserve_backslash` to the manify method. That way, we don't need an extra method in the first two cases. Obviously, we still need it for the inline case.","What exactly does this do? Is there a test for this, or is this just "
+9607,"@@ -49,10 +49,10 @@ var _ = Context(""with initialized Felix, etcd datastore, 3 workloads"", func() {
+ 		defaultProfile := api.NewProfile()
+ 		defaultProfile.Name = ""default""
+ 		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.EgressRules = []api.Rule{{Action: ""allow""}}
++		defaultProfile.Spec.EgressRules = []api.Rule{{Action: api.Allow}}
+ 		defaultProfile.Spec.IngressRules = []api.Rule{{
+-			Action: ""allow"",
+-			Source: api.EntityRule{Tag: ""default""},
++			Action: api.Allow,
++			Source: api.EntityRule{Selector: ""default == ''""},
+ 		}}
+ 		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+ 		Expect(err).NotTo(HaveOccurred())",`has(default)` i think is the preferred way of doing this,Why was this necessary?
+9608,"@@ -235,7 +235,7 @@ public class BaseRewriteManifests extends SnapshotProducer<RewriteManifests> imp
+               keptManifests.add(manifest);
+             } else {
+               rewrittenManifests.add(manifest);
+-              try (ManifestReader reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
++              try (ManifestReader<DataFile> reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
+                   .select(Arrays.asList(""*""))) {
+                 reader.liveEntries().forEach(
+                     entry -> appendEntry(entry, clusterByFunc.apply(entry.file()), manifest.partitionSpecId())",Does this mean we can only do rewrites if there are no `DeleteFile`'s?,"`ManifestFiles.read` can return a `File` (not a `DataFile`), so you don't need to wrap it with the `ManifestReader`."
+9609,"@@ -96,10 +96,12 @@ class InstallTest(QuiltTestCase):
+         """"""
+         table_data, table_hash = self.make_table_data()
+         file_data, file_hash = self.make_file_data()
+-        contents, contents_hash = self.make_contents(table=table_hash, file=file_hash)
++        contents, contents_hash = self.make_contents(table=table_hash,
++                                                     file=file_hash)
+
+         self._mock_tag('foo/bar', 'latest', contents_hash, team='qux')
+-        self._mock_package('foo/bar', contents_hash, '', contents, [table_hash, file_hash], team='qux')
++        self._mock_package('foo/bar', contents_hash, '',
++                           contents, [table_hash, file_hash], team='qux')
+         self._mock_s3(table_hash, table_data)
+         self._mock_s3(file_hash, file_data)
+ ","Actually, these are fine; we're using 110 as the max line length. (it's also set in the .pylintrc)","Might as well get rid of all the unnecessary `""""""` changes in this PR."
+9610,"@@ -17,6 +17,7 @@ package main
+ import (
+ 	. ""github.com/onsi/ginkgo""
+ 	. ""github.com/onsi/gomega""
++
+ 	""github.com/projectcalico/felix/k8sfv/leastsquares""
+ )
+ ","No issue here, but what tool are you running to put these imports into the preferred organization? I have configuration to run `goimports` whenever I save a file, but it appears that that is not quite sufficient.",No need for newline here
+9611,"@@ -131,6 +131,7 @@ public class DTAFileReaderSpi extends TabularDataFileReaderSpi{
+
+     @Override
+     public boolean canDecodeInput(BufferedInputStream stream) throws IOException {
++    	//who closes this stream?
+         if (stream ==null){
+             throw new IllegalArgumentException(""stream == null!"");
+         }",guessing this method could/should close it but I didn't see where it was getting called.,Why not close this stream in `canDecodeInput`?
+9612,"@@ -50,11 +50,13 @@ public class ExecutableFlow extends ExecutableFlowBase {
+   public static final String AZKABANFLOWVERSION_PARAM = ""azkabanFlowVersion"";
+   public static final String IS_LOCKED_PARAM = ""isLocked"";
+   public static final String FLOW_LOCK_ERROR_MESSAGE_PARAM = ""flowLockErrorMessage"";
++  public static final String EXECUTION_SOURCE = ""execution_source"";
+
+   private final HashSet<String> proxyUsers = new HashSet<>();
+   private int executionId = -1;
+   private int scheduleId = -1;
+   private int projectId;
++  private String executionSource;
+   private String projectName;
+   private String lastModifiedUser;
+   private int version;",Could you please use `camelCase` in the property name to follow the naming convention used in the rest of the properties?,should this be an enum?
+9613,"@@ -12,7 +12,7 @@ import (
+ )
+
+ const (
+-	fmtErrPublicSubnetsFromEnv  = ""get public subnet IDs from environment %s: %w""
++	fmtErrPublicSubnetsFromEnv  = ""get public subnet IDs from environment %s: %w ""
+ 	fmtErrSecurityGroupsFromEnv = ""get security groups from environment %s: %w""
+
+ 	envSecurityGroupCFNLogicalIDTagKey   = ""aws:cloudformation:logical-id""",Can we revert this change? looks like an extra space was added at the end  ,Is there a reason for t
+9614,"@@ -222,6 +222,9 @@ public class RubyPackageMetadataTransformer implements ModelToViewTransformer {
+                 productConfig, ImportSectionView.newBuilder().build(), surfaceNamer))
+         .hasSmokeTests(hasSmokeTests)
+         .versionPath(surfaceNamer.getVersionIndexFileImportName())
++        .versionNamespace(
++            surfaceNamer.getNamespace(
++                new InterfaceView().getElementIterable(model).iterator().next()))
+         .build();
+   }
+ ","This just grabs any one of the proto services defined in the API, right? What happens when there are multiple (like with PubSub)?",I'm not sure if this is
+9615,"@@ -40,7 +40,9 @@ def define_violation(model_name, dbengine):
+     """"""
+
+     base = declarative_base()
+-    violations_tablename = '{}_violations'.format(model_name)
++    # pylint: disable=too-many-format-args
++    violations_tablename = 'violations'.format(model_name)
++    # pylint: enable=too-many-format-args
+
+     class Violation(base):
+         """"""Row entry for a violation.""""""",Remove the pylint disable and remove the .format() from the string. The tablename is just 'violations',Please create a new iss
+9616,"@@ -8,6 +8,16 @@ class Trail < ActiveRecord::Base
+
+   friendly_id :name, use: [:slugged, :finders]
+
++  # Override setters so it preserves the ordering
++  def exercise_ids=(new_exercise_ids)
++    super
++    new_exercise_ids = new_exercise_ids.reject(&:blank?).map(&:to_i)
++
++    new_exercise_ids.each_with_index do |exercise_id, index|
++      steps.where(exercise_id: exercise_id).update_all(position: index + 1)
++    end
++  end
++
+   def steps_remaining_for(user)
+     ExerciseWithProgressQuery.
+       new(user: user, exercises: exercises).",Will this implementation allow you to add new exercises to the trail?,"This is a nitpick, but would you mind changing the name of this method to `update_exercise_ids`? The `index` doesn't seem to be a very descriptive name."
+9617,"@@ -76,9 +76,17 @@ func trapSignalsPosix() {
+ 					caddyfileToUse = newCaddyfile
+ 				}
+
++				// Backup old event hooks
++				oldEventHooks := cloneEventHooks()
++
++				// Purge the old event hooks
++				purgeEventHooks()
++
+ 				// Kick off the restart; our work is done
+ 				_, err = inst.Restart(caddyfileToUse)
+ 				if err != nil {
++					eventHooks = oldEventHooks
++
+ 					log.Printf(""[ERROR] SIGUSR1: %v"", err)
+ 				}
+ ","Actually there is race condition here, because pointer assignment isn't atomic on some platform. But this is a rare case we should hit, we can just let it go for now. Maybe this is one of the TODO list.",I think the name `oldEventHooks` is a bit misleading. I thought the old naming was more like `eventHooks` and the new naming is `oldOldEventHooks`.
+9618,"@@ -181,6 +181,10 @@ void lbann::distributed_io_buffer::calculate_num_iterations_per_epoch(int num_mo
+     max_mini_batch_size = data_reader->get_num_data();
+   }
+
++  bool partitioned = data_reader->is_partitioned();
++  //@todo ""if (partitioned)"" conditionals below assume one processor per model;
++  //      this needs to be revisited for cases with multiple cpus per model
++
+   /// Check to make sure that there is enough data for all of the parallel readers
+   int num_parallel_readers_per_model = compute_max_num_parallel_readers(data_reader->get_num_data(), max_mini_batch_size, m_requested_max_num_parallel_readers);
+   data_reader->set_num_parallel_readers(num_parallel_readers_per_model);",We should check somewhere here and in the partitioned_io_buffer that the max_mini_batch_size is properly computed for each model and that it is not aggregate (sum) for all models. The global/max_mini_batch_size should be as specified by the user in the prototext/cmd line.,"Is there a reason this needs to be revisited? As far as I can tell, it doesn't seem like a parallel reader should have a processor per model."
+9619,"@@ -132,7 +132,7 @@ const Capability = {
+    * Defines how the driver should handle unexpected alerts. The value should
+    * be one of ""accept"", ""dismiss"", or ""ignore"".
+    */
+-  UNEXPECTED_ALERT_BEHAVIOR: 'unexpectedAlertBehavior',
++  UNEXPECTED_ALERT_BEHAVIOUR: 'unexpectedAlertBehaviour',
+
+   /** Defines the browser version. */
+   VERSION: 'version'","you can change the string value, but not the code constant",Need to update this to match the new enum
+9620,"@@ -27,10 +27,10 @@ func TestBech32(t *testing.T) {
+ 		{""split1checkupstagehandshakeupstreamerranterredcaperred2y9e2w"", false},                   // invalid checksum
+ 		{""s lit1checkupstagehandshakeupstreamerranterredcaperredp8hs2p"", false},                   // invalid character (space) in hrp
+ 		{""spl"" + string(127) + ""t1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false}, // invalid character (DEL) in hrp
+-		{""split1cheo2y9e2w"", false}, // invalid character (o) in data part
+-		{""split1a2y9w"", false},      // too short data part
+-		{""1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false}, // empty hrp
+-		{""li1dgmt3"", false}, // Too short checksum
++		{""split1cheo2y9e2w"", false},                                                               // invalid character (o) in data part
++		{""split1a2y9w"", false},                                                                    // too short data part
++		{""1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false},                        // empty hrp
++		{""li1dgmt3"", false},                                                                       // Too short checksum
+ 		{""11qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqsqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8247j"", false}, // overall max length exceeded
+ 	}
+ ",File is not `goimports`-ed,How about `invalid character (o)`?
+9621,"@@ -36,6 +36,6 @@ public class AzkabanExecServerModule extends AbstractModule {
+     bind(AzkabanExecutorServer.class).in(Scopes.SINGLETON);
+     bind(TriggerManager.class).in(Scopes.SINGLETON);
+     bind(FlowRunnerManager.class).in(Scopes.SINGLETON);
+-
++    // TODO: add ExecMetrics when guicy
+   }
+ }",Is this Todo necessary?,Why is this part of this PR?
+9622,"@@ -108,10 +108,7 @@ class ErrorHandler(object):
+                         message = value[""value""]
+                         if not isinstance(message, basestring):
+                             value = message
+-                            try:
+-                                message = message['message']
+-                            except TypeError:
+-                                message = None
++                            message = message.get('message', None)
+                     else:
+                         message = value.get('message', None)
+                 except ValueError:",I would recommend to leave out `None` because None is already the default.,`None` is already the default valu
+9623,"@@ -97,6 +97,10 @@ const (
+
+ 	taskIDFlag    = ""task-id""
+ 	containerFlag = ""container""
++
++	valuesFlag        = ""values""
++	overwriteFlag     = ""overwrite""
++	inputFilePathFlag = ""cli-input-yaml""
+ )
+
+ // Short flag names.","I may have missed previous discussion on this; apologies if that's the case. What do you think about just `input-yaml`, without the `cli-`?",nit: name it `cli-input-yaml`
+9624,"@@ -57,13 +57,14 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal
+
+         public async Task StartAsync(IConnectionHandler connectionHandler)
+         {
++            Exception error = null;
+             try
+             {
+                 connectionHandler.OnConnection(this);
+
+                 // Spawn send and receive logic
+                 Task receiveTask = DoReceive();
+-                Task sendTask = DoSend();
++                Task<Exception> sendTask = DoSend();
+
+                 // If the sending task completes then close the receive
+                 // We don't need to do this in the other direction because the kestrel",Nit: rename to sendError.,Why did you change this from Task to Task? I don't see why it's needed
+9625,"@@ -7,6 +7,10 @@ Makes functions in .tools.command accessible directly from quilt.
+ # None: CLI params have not yet been parsed to determine mode.
+ _DEV_MODE = None
+
++# Suppress numpy warnings for Python 2.7
++import warnings
++warnings.filterwarnings(""ignore"", message=""numpy.dtype size changed"")
++
+
+ # Normally a try: except: block on or in main() would be better and simpler,
+ # but we load a bunch of external modules that take a lot of time, during which",`pylint` wants to know why this `import` isn't at the top of the file; and it's kinda right,Can you move this import to the top of the file?
+9626,"@@ -0,0 +1,19 @@
++package de.danoeh.antennapod.core.feed;
++
++public class FeedUrlNotFoundException extends RuntimeException {
++    private final String artistName;
++    private final String trackName;
++
++    public FeedUrlNotFoundException(String url, String trackName) {
++        this.artistName = url;
++        this.trackName = trackName;
++    }
++
++    public String getArtistName() {
++        return artistName;
++    }
++
++    public String getTrackName() {
++        return trackName;
++    }
++}","To me, using a `RuntimeException` for this feels a bit weird. I would just extend `Exception`, or maybe even `IoException`. Could you also please overwrite the `getMessage` function to return something like `""Result does not specify a feed url""`?",Shouldn't this be `FeedUrlNotFoundException`?
+9627,"@@ -88,7 +88,8 @@ func convertStorage(ctx context.Context, msg *cepubsub.Message, sendMode ModeTyp
+ 		}
+ 	}
+ 	event.SetDataContentType(*cloudevents.StringOfApplicationJSON())
+-	event.SetData(msg.Data)
++	event.Data = msg.Data
++	event.DataEncoded = true
+ 	// Attributes are extensions.
+ 	if msg.Attributes != nil && len(msg.Attributes) > 0 {
+ 		for k, v := range msg.Attributes {",what was the issue here? why did you have to directly set?,Is there a reason we don't need to call `SetData`?
+9628,"@@ -226,10 +226,8 @@ func (c *Command) proposals() {
+ 	for _, proposal := range proposals {
+ 		country := proposal.ServiceDefinition.LocationOriginate.Country
+ 		var countryString string
+-		if country != nil {
+-			countryString = *country
+-		} else {
+-			countryString = ""Unknown""
++		if len(country) == 0 {
++			country = ""Unknown""
+ 		}
+ 		msg := fmt.Sprintf(""- provider id: %v, proposal id: %v, country: %v"", proposal.ProviderID, proposal.ID, countryString)
+ 		info(msg)",I'm confusied - Isn't `countryString` left empty if `len(country)` != 0?,"if len(country) > 0 { country = ""Unknown"" } else { country = ""Unknown"" }"
+9629,"@@ -53,7 +53,7 @@ DesktopSwitch::DesktopSwitch(const ILXQtPanelPluginStartupInfo &startupInfo) :
+     mLabelType(static_cast<DesktopSwitchButton::LabelType>(-1))
+ {
+     m_buttons = new QButtonGroup(this);
+-    connect (m_pSignalMapper, SIGNAL(mapped(int)), this, SLOT(setDesktop(int)));
++    connect (m_pSignalMapper, QOverload<int>::of(&QSignalMapper::mapped), this, &DesktopSwitch::setDesktop);
+
+     mLayout = new LXQt::GridLayout(&mWidget);
+     mWidget.setLayout(mLayout);","Would you please update this by using `#if (QT_VERSION >= QT_VERSION_CHECK(5,15,0))` and `QSignalMapper::mappedInt` for Qt >= 5.15?",Is there a specific reason to use QOverload<int>::of(m_pSignalMapper::ma
+9630,"@@ -262,6 +262,8 @@ func PopulateInstallRoot(installChroot *safechroot.Chroot, packagesToInstall []s
+ 		filesystemPkg = ""filesystem""
+ 	)
+
++	defer stopGPGAgent(installChroot)
++
+ 	ReportAction(""Initializing RPM Database"")
+
+ 	installRoot := filepath.Join(rootMountPoint, installChroot.RootDir())","This type of change opens a question on how we can cleanly shutdown or prevent all running agents so we do not run the risk of an agent holding kernel mountpoints, which can cause unsafe unmount/chroot exit. Will open a github issue to track this. This specific change itself is fine. It is a pointed change specifically for stopping the offending agent.",What does this do? Doesn't seem to be doing anything?
+9631,"@@ -3,6 +3,8 @@
+
+ package io.protostuff.runtime.model;
+
++import com.google.protobuf.CodedOutputStream;
++
+ public final class ModelProtobuf {
+   private ModelProtobuf() {
+   }","this file is model generated by protobuf, just for compatible test it's better not change it.",this file has nothing to do with this PR.
+9632,"@@ -8,8 +8,8 @@ class Analytics
+     @user = user
+   end
+
+-  def track_cancelled
+-    track(event: ""Cancelled"", properties: {})
++  def track_cancelled(reason)
++    track(event: ""Cancelled"", properties: { reason: reason })
+   end
+
+   def track_updated","It turns out we can send the reason as the property to Segment on the event. Then we can do whatever we want with it. In this case, I think we'll fire a web hook to Zapier which will add a note or message on the user in Intercom.","I'm not sure if this is the best way to pass a reason to `track_cancelled` -- if we want to add a reason to `track_cancelled`, what do you think about adding a `_reason` key in the `properties` hash?"
+9633,"@@ -0,0 +1,17 @@
++class PromotedCatalog
++  def initialize(catalog)
++    @catalog = catalog
++  end
++
++  def method_missing(message, *arguments)
++    catalog.send(message, *arguments).promoted
++  end
++
++  def respond_to_missing?(message, include_all = false)
++    catalog.send(:respond_to?, message, include_all)
++  end
++
++  private
++
++  attr_reader :catalog
++end",This class is very similar to `Catalog`. Is there a way to have this class compose a `Catalog` instance or extract a common class which they can both compose?,Why not `attr_reader :catalog`?
+9634,"@@ -164,9 +164,7 @@ TEST(""pull as device usm from host-allocated homogen table"") {
+         row_accessor<const float>{ data } //
+             .pull(q, { 1, 3 }, sycl::usm::alloc::device);
+
+-    const auto data_arr_host =
+-        la::matrix<float>::wrap(q, data_arr_device.get_data(), { row_count, column_count })
+-            .to_host();
++    const auto data_arr_host = la::matrix<float>::wrap(data_arr_device).to_host();
+     const float* data_arr_host_ptr = data_arr_host.get_data();
+
+     REQUIRE(data_arr_host_ptr[0] == 3.0f);",Why did you decide to drop the `queue` from parameters of `wrap` function? The agreement was that all functions for DPC++ case that accept non-host-accessible memory shall accept the queue directly.,"There's no need to pass the `row_count` and `column_count` explicitly to `wrap()`, they're not used anywhere."
+9635,"@@ -340,6 +340,11 @@ module RSpec
+       # @return [Symbol]
+       add_setting :detail_color
+
++      # @macro add_setting
++      # Hyperlink failed examples (default: `false`).
++      # @return [Boolean]
++      add_setting :hyperlink
++
+       # @macro add_setting
+       # Don't print filter info i.e. ""Run options: include {:focus=>true}""
+       # (default `false`).","I think this is a bad name, as its not clear what it does by name alone. If we merge this it should be something like `use_links_to_files_in_output` and should take either a custom scheme like `rspec` or default to `file`","Can you update this to use `add_setting :hyperlink, default: false`?"
+9636,"@@ -65,6 +65,7 @@ public final class BaselineErrorProne implements Plugin<Project> {
+                                 .configure(ErrorProneOptions.class, errorProneOptions -> {
+                                     errorProneOptions.check(""Slf4jLogsafeArgs"", CheckSeverity.OFF);
+                                     errorProneOptions.check(""PreferSafeLoggableExceptions"", CheckSeverity.OFF);
++                                    errorProneOptions.check(""Slf4jConstantLogMessage"", CheckSeverity.OFF);
+                                 }));
+             });
+ ","Arguably this is actually still valuable for perf, maybe it should just be a warning?",We should also have a test case for slf4jConstantLogMessage
+9637,"@@ -35,6 +35,14 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+
++	s.Addressbook.Put(address, addr)
++	if err := s.TopologyDriver.AddPeer(address); err != nil {
++		s.Logger.Debugf(""debug api: topologyDriver.AddPeer %s: %v"", addr, err)
++		s.Logger.Errorf(""unable to connect to peer %s"", addr)
++		jsonhttp.InternalServerError(w, err)
++		return
++	}
++
+ 	jsonhttp.OK(w, peerConnectResponse{
+ 		Address: address.String(),
+ 	})",didn't way say that the topology driver will actually insert the entries to the address book?,why don't you return the error?
+9638,"@@ -24,11 +24,13 @@ import { removeNode } from '../util';
+  * Fragments that have siblings. In most cases, it starts out as `oldChildren[0]._dom`.
+  */
+ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context, isSvg, excessDomChildren, mounts, ancestorComponent, oldDom) {
+-	let childVNode, i, j, p, index, oldVNode, newDom,
++	let childVNode, i, j, oldVNode, newDom,
+ 		nextDom, sibDom, focus;
+
+ 	let newChildren = newParentVNode._children || toChildArray(newParentVNode.props.children, newParentVNode._children=[], coerceToVNode, true);
+-	let oldChildren = oldParentVNode!=null && oldParentVNode!=EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR;
++	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
++	// as EMPTY_OBJ._children should be `undefined`.
++	let oldChildren = oldParentVNode!=null && oldParentVNode._children || EMPTY_ARR;
+
+ 	let oldChildrenLength = oldChildren.length;
+ ",This seems safe to me. My guess is the original checks were a combination of before + after `oldParentVNode` became reliably a `(vnode | null)`.,this is not a compression of oldParentVNode._children?
+9639,"@@ -148,6 +148,10 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --conform FILE         Specify a schema the following schemas should be\n""
+     ""                         an evolution of. Gives errors if not.\n""
+     ""  --conform-includes     Include path for the schema given with --conform PATH\n""
++    ""  --filename-suffix      The suffix appended to the generated file names.\n""
++    ""                         Default is '_generated'.\n""
++    ""  --filename-ext         The extension appended to the generated file names.\n""
++    ""                         Default is language-specific (e.g., '.h' for C++)\n""
+     ""  --include-prefix       Prefix this path to any generated include statements.\n""
+     ""    PATH\n""
+     ""  --keep-prefix          Keep original prefix of schema include statement.\n""",also in the `.md` please.,Shouldn't this be `-generated` instead of `-generated`?
+9640,"@@ -7,7 +7,9 @@ module Unix::Pkg
+   end
+
+   def install_package name
+-    if self['platform'] =~ /(fedora)|(centos)|(el)/
++    if self['platform'] =~ /(el-4)|(redhat-4)/
++      @logger.debug(""Package installation not supported on rhel4"")
++    elsif self['platform'] =~ /(fedora)|(centos)|(el)|(redhat)/
+       execute(""yum -y install #{name}"")
+     elsif self['platform'] =~ /(ubuntu)|(debian)/
+       execute(""apt-get update"")",RHEL is an acronym and is usually all caps. Why are you adding a redhat regex matcher?,nitpick: can we use `@logger.debug` instead?
+9641,"@@ -193,16 +193,6 @@ public class VectorizedColumnIterator extends BaseColumnIterator {
+     }
+   }
+
+-  public class FixedWidthTypeBinaryBatchReader extends BatchReader {
+-    @Override
+-    protected int nextBatchOf(
+-        final FieldVector vector, final int expectedBatchSize, final int numValsInVector, final int typeWidth,
+-        NullabilityHolder holder) {
+-      return vectorizedPageIterator.fixedWidthBinaryPageReader().nextBatch(vector, expectedBatchSize, numValsInVector,
+-          typeWidth, holder);
+-    }
+-  }
+-
+   public class BooleanBatchReader extends BatchReader {
+     @Override
+     protected int nextBatchOf(",Maybe I am daft but it looks like you removed fixed width readers but I don't see where you added any readers?,Also remove the unused `typeWidth` parameter
+9642,"@@ -16,6 +16,14 @@ import (
+
+ const DefaultManifestType = ManifestMantarayContentType
+
++const (
++	RootPath                      = ""/""
++	WebsiteIndexDocumentSuffixKey = ""website-index-document""
++	WebsiteErrorDocumentPathKey   = ""website-error-document""
++	EntryMetadataContentTypeKey   = ""Content-Type""
++	EntryMetadataFilenameKey      = ""Filename""
++)
++
+ var (
+ 	// ErrNotFound is returned when an Entry is not found in the manifest.
+ 	ErrNotFound = errors.New(""manifest: not found"")","@acud The reason I moved these here is because I need them in the traversal tests. The traversal package doesn't need this. I don't see any particular reason why any package apart from api would need this. api package imports traversal, so I cannot import api in traversal pkg. Also if these change in future, the traversal tests need to change. So maybe enough reason to move these here? That way both packages can access these as they both depend on manifest",All these constants should be moved to `inte
+9643,"@@ -560,6 +560,7 @@ class AbstractTab(QWidget):
+         self._mouse_event_filter = mouse.MouseEventFilter(
+             self, widget_class=self.WIDGET_CLASS, parent=self)
+         self.backend = None
++        self.pin = False
+
+         # FIXME:qtwebengine  Should this be public api via self.hints?
+         #                    Also, should we get it out of objreg?","I'd prefer this to be called `pinned` - also it should probably be in the `TabData` class instead, which is accessible as the `.data` attribute of the `BrowserTab` object - otherwise, `BrowserTab` would have a lot of quite ""random"" attributes :wink:","For consistency, this should probably be `se"
+9644,"@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
+   private ChromeDriverCommand() {}
+
+   static final String LAUNCH_APP = ""launchApp"";
++  static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
++      = ""sendCommandForDownloadChromeHeadLess"";
++
+ }","Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way.",Minor quibble: should this be `sendCommandForDownloadChromeHeadLess`?
+9645,"@@ -1,6 +1,9 @@
+-/*global Audit, runRules, cleanupPlugins */
++/*global Audit */
+ /*eslint indent: 0*/
+-function runCommand(data, keepalive, callback) {
++import cleanupPlugins from './cleanup-plugins';
++import runRules from './run-rules';
++
++const runCommand = (data, keepalive, callback) => {
+ 	'use strict';
+ 	var resolve = callback;
+ 	var reject = function(err) {",Why not import audit as well?,Should we add `eslint indent: 0` to these?
+9646,"@@ -92,7 +92,9 @@ class CategoryDataFixture extends AbstractReferenceFixture
+                 . '(black-and-white), or in color, and in two or three dimensions',
+             ]
+         );
+-        $categoryData->parent = $this->getReference(self::CATEGORY_ELECTRONICS);
++        /** @var \Shopsys\ShopBundle\Model\Category\Category $categoryElectronics */
++        $categoryElectronics = $this->getReference(self::CATEGORY_ELECTRONICS);
++        $categoryData->parent = $categoryElectronics;
+         $this->createCategory($categoryData, self::CATEGORY_TV);
+
+         $categoryData->name = [","OK, i think there will be more of those...",Why don't you use the `createCategory` method directly?
+9647,"@@ -12,6 +12,6 @@ return [
+     |
+     */
+
+-    'failed'   => 'These credentials do not match our records.',
+-    'throttle' => 'Too many login attempts. Please try again in :seconds seconds.',
++    'failed'   => 'Овие акредитиви не се совпаѓаат со нашите записи.',
++    'throttle' => 'Премногу обиди за најавување. Обидете се повторно за :seconds секунди.',
+ ];","Can you add : 'password' => 'The provided password is incorrect.', ?","Unfortunately, the locale file has been updated to the English versio"
+9648,"@@ -18,6 +18,7 @@ from logHandler import log
+
+ from comtypes.gen.UIAutomationClient import *
+
++
+ #Some new win8 UIA constants that could be missing
+ UIA_StyleIdAttributeId=40034
+ UIA_AnnotationAnnotationTypeIdPropertyId=30113",Extraneous blank line.,nit: do you need the extra newline here?
+9649,"@@ -30,7 +30,7 @@ function ariaOwns(nodes, role) {
+ 		if (nodes[index] === null) {
+ 			continue;
+ 		}
+-		let virtualTree = axe.utils.getNodeFromTree(axe._tree[0], nodes[index]);
++		let virtualTree = axe.utils.getNodeFromTree(nodes[index]);
+ 		if (owns(nodes[index], virtualTree, role, true)) {
+ 			return true;
+ 		}","nitpick: use `const virtualTree`, I know it was `let` earlier.","`getNodeFromTree` can return `null`, so "
+9650,"@@ -464,7 +464,10 @@ func (j *mdJournal) convertToBranch(
+ 		brmd.SetUnmerged()
+ 		brmd.SetBranchID(bid)
+
+-		// Delete the old ""merged"" version from the cache.
++		// Delete the old ""merged"" version from the cache.  We aren't
++		// equipped here to cache the new version, but it will
++		// eventually get passed via an mdFlushListener to somewhere
++		// that will cache it.
+ 		mdcache.Delete(tlfID, ibrmd.RevisionNumber(), NullBranchID)
+
+ 		// Re-sign the writer metadata.","Actually, I think it might be easier to do it here. Rough outline: 1. Save a list of the md cache keys and new brmd while looping. 2. After the loop, for each entry: 2a. Look up the old cache entry. If it doesn't exist, continue. 2b. Otherwise, make a deep copy of it, and replace its brmd with the newly-generated one. 2c. Delete the old cache entry, put the new cache entry. What do you think? The problem with the current approach is that the gap between dropping the old version and putting the new version is large enough that when we put the new version, we may be kicking out hotter cache entries. In this case, we'd be doing so to a lesser extent. Ideally, we'd be able to replace the entry in the MDCache LRU without changing the LRU info.",Was there a reason why we were not just
+9651,"@@ -253,6 +253,12 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine
+             }
+
+             source = source.Trim();
++
++            if(!FileHelper.IsRootedPath(source))
++            {
++                source = FileHelper.CombinePath(source);
++            }
++
+             if (!FileHelper.Exists(source))
+             {
+                 throw new CommandLineException(",We need tests for this,Add a space between the if and the paren
+9652,"@@ -47,11 +47,11 @@ func initProvider() func() {
+ 	// `localhost:30080` address. Otherwise, replace `localhost` with the
+ 	// address of your cluster. If you run the app inside k8s, then you can
+ 	// probably connect directly to the service through dns
+-	exp, err := otlp.NewExporter(
+-		otlp.WithInsecure(),
++	config := otlp.NewConnectionConfig(otlp.WithInsecure(),
+ 		otlp.WithAddress(""localhost:30080""),
+ 		otlp.WithGRPCDialOption(grpc.WithBlock()), // useful for testing
+ 	)
++	exp, err := otlp.NewExporter(config, config)
+ 	handleErr(err, ""failed to create exporter"")
+
+ 	bsp := sdktrace.NewBatchSpanProcessor(exp)",NewExporter takes in two arguments: a configuration for the metrics connection and one for the traces,Why does this need to be different than `otlp.WithInsecure()`?
+9653,"@@ -241,6 +241,15 @@ import connectionManager from 'connectionManager';
+         navigator.mediaSession.setActionHandler('seekforward', function () {
+             execute('fastForward');
+         });
++
++        /* eslint-disable-next-line compat/compat */
++        navigator.mediaSession.setActionHandler('seekto', function (object) {
++            let item = playbackManager.getPlayerState(playbackManager.getCurrentPlayer()).NowPlayingItem;
++            // Convert to ms
++            let duration = parseInt(item.RunTimeTicks ? (item.RunTimeTicks / 10000) : 0);
++            let wantedTime = object.seekTime * 1000;
++            playbackManager.seekPercent(wantedTime / duration * 100, currentPlayer);
++        });
+     }
+
+     events.on(playbackManager, 'playerchange', function () {",Why not use currentPlayer instead of playbackManager.getCurrentPlayer()?,This could just be `playbackManager.getCurrentPlayer().RunTime
+9654,"@@ -15,7 +15,8 @@ class UsersController < Clearance::UsersController
+   def create_user_from_params
+     params.require(:user).permit(
+       :email, :password, :name, :github_username, :bio, :organization,
+-      :address1, :address2, :city, :state, :zip_code, :country
++      :address1, :address2, :city, :state, :zip_code, :country,
++      :unsubscribed_from_emails
+     )
+   end
+ ","Avoid comma after the last parameter of a method call, unless each item is on its own line.",I wonder if we should just call this `:unsubscribed_from_email
+9655,"@@ -52,7 +52,12 @@ type Config struct {
+
+ 	// DataDir is the directory data is saved to in order to preserve state
+ 	// across agent restarts. It is only used if ""Checkpoint"" is true as well.
++	// It is also used to keep the metadata of containers managed by the agent
++	// regardless of whether ""Checkpoint"" is set.
+ 	DataDir string
++	// DataDirOnHost is the directory in the instance from which we mount
++	// DataDir to the ecs-agent container and to agent managed containers
++	DataDirOnHost string
+ 	// Checkpoint configures whether data should be periodically to a checkpoint
+ 	// file, in DataDir, such that on instance or agent restarts it will resume
+ 	// as the same ContainerInstance. It defaults to false.",You should remove the outdated sentence.,What happens when Checkpoint is set to true? Wouldn't this sti
+9656,"@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+             ""com.fsck.k9.activity.MessageCompose.quotedTextFormat"";
+     private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = ""numAttachmentsLoading"";
+     private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = ""waitingForAttachments"";
+-
++    private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmptySubject"";
+     private static final String LOADER_ARG_ATTACHMENT = ""attachment"";
+
+     private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = ""waitingForAttachment"";",Please restore the empty line after the group of `STATE_*` constants. This visual separation makes the code easier to read.,Why is this not part of the STATE_KEY?
+9657,"@@ -213,9 +213,10 @@ module.exports = class GoldenRetriever extends Plugin {
+       this.IndexedDBStore.delete(fileID)
+     })
+
+-    this.core.on('core:success', (fileIDs) => {
++    this.core.on('core:complete', ({ successful }) => {
++      const fileIDs = successful.map((file) => file.id)
+       this.deleteBlobs(fileIDs).then(() => {
+-        this.core.log(`[GoldenRetriever] removed ${fileIDs.length} files that finished uploading`)
++        this.core.log(`RestoreFiles: removed ${successful.length} files that finished uploading`)
+       })
+     })
+ ","Unsure why this is `RestoreFiles` now vs `GoldenRetriever`, thought we deprecated the first?",Maybe we should rename `fileIDs` to `f
+9658,"@@ -436,6 +436,10 @@ namespace pwiz.Skyline.Controls.Graphs
+         {
+             // Match each file status with a progress control.
+             bool first = true;
++            var width = flowFileStatus.Width - 2 -
++                        (flowFileStatus.VerticalScroll.Visible
++                            ? SystemInformation.VerticalScrollBarWidth
++                            : 0);
+             foreach (var loadingStatus in status.ProgressList)
+             {
+                 var filePath = loadingStatus.FilePath;",Not sure what this is. Bad merge?,@QilongTang @sm6srw seems we are adjus
+9659,"@@ -171,7 +171,7 @@ func (v *veth) create(n *network, nspid int) (err error) {
+ 			netlink.LinkDel(veth)
+ 		}
+ 	}()
+-	if err := v.attach(&n.Network); err != nil {
++	if err = v.attach(&n.Network); err != nil {
+ 		return err
+ 	}
+ 	child, err := netlink.LinkByName(n.TempVethPeerName)","I'm confused, what did this actually fix? Is there a reason we are setting `err` in the parent scope to `nil` in this round-about way?",You could simplify this to `if v.attac
+9660,"@@ -1103,6 +1103,10 @@ func TestApplyEnv_Image_HealthCheck(t *testing.T) {
+ 	}
+ }
+
++func TestApplyEnv_Platform(t *testing.T) {
++	// TODO: Add test for platform in the next PR
++}
++
+ func TestApplyEnv_Entrypoint(t *testing.T) {
+ 	testCases := map[string]struct {
+ 		inSvc  func(svc *LoadBalancedWebService)",Can we remove this   ?,What is the plan? Add a TODO?
+9661,"@@ -0,0 +1,7 @@
++class NewLanguageConfirmationsController < ApplicationController
++  def index
++    redirect_to welcome_to_upcase_path(
++      confirmation: true, language_selected: params[:language],
++    ), notice: ""Thanks for signing up. We will be in touch!""
++  end
++end",Put a comma after the last parameter of a multiline method call.,I wonder if we should use a d
+9662,"@@ -48,12 +48,13 @@ func TestBlockDAO(t *testing.T) {
+ 		tsf3, err := testutil.SignedTransfer(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+
+-		// create testing votes
+-		vote1, err := testutil.SignedVote(testaddress.Addrinfo[""alfa""].String(), testaddress.Keyinfo[""alfa""].PriKey, 1, 100000, big.NewInt(10))
++		tsf4, err := testutil.SignedTransfer(testaddress.Addrinfo[""alfa""].String(), testaddress.Keyinfo[""alfa""].PriKey, 2, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+-		vote2, err := testutil.SignedVote(testaddress.Addrinfo[""bravo""].String(), testaddress.Keyinfo[""bravo""].PriKey, 1, 100000, big.NewInt(10))
++
++		tsf5, err := testutil.SignedTransfer(testaddress.Addrinfo[""bravo""].String(), testaddress.Keyinfo[""bravo""].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+-		vote3, err := testutil.SignedVote(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 1, 100000, big.NewInt(10))
++
++		tsf6, err := testutil.SignedTransfer(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 4, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+
+ 		// create testing executions",line is 195 characters (from `lll`),The action gas limit is set t
+9663,"@@ -29,8 +29,11 @@ import (
+ 	""github.com/pkg/errors""
+ 	k8serror ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	klabels ""k8s.io/apimachinery/pkg/labels""
++	""k8s.io/apimachinery/pkg/types""
+ 	""k8s.io/apimachinery/pkg/util/runtime""
+ 	""k8s.io/client-go/tools/cache""
++	""k8s.io/kubernetes/pkg/util/slice""
+ )
+
+ var (","could not import k8s.io/kubernetes/pkg/util/slice (invalid package name: """") (from `typecheck`)",you don't seem to be using th
+9664,"@@ -29,4 +29,4 @@ describeComponent(
+             expect(component._state).to.equal('inDOM');
+         });
+     }
+-);
++);",@disordinary would you be able to configure your editor to use the `.editorconfig` file so that we can avoid final newline changes?,Please revert this change.
+9665,"@@ -80,12 +80,9 @@ module.exports = function(realmConstructor, context) {
+     const { DefaultNetworkTransport } = require('realm-network-transport');
+     realmConstructor._networkTransport = new DefaultNetworkTransport();
+
+-    Object.defineProperty(realmConstructor.Object.prototype, ""toJSON"", {
+-        value: function () {
+-            const result = {}
+-            Object.keys(this).forEach(p => result[p] = this[p]);
+-            Object.keys(Object.getPrototypeOf(this)).forEach(p => result[p] = this[p]);
+-            return result;
++    Object.defineProperty(realmConstructor.Collection.prototype, ""toJSON"", {
++        value: function (_, cache = new Map()) {
++            return this.map((item, index) => item.toJSON ? item.toJSON(index.toString(), cache) : item);
+         },
+
+         writable: true,",I really think we should not use this style where unused arguments are named with underscore. While this eases the person writing the function it does it at an expense of readability and debugging. So next person who needs to actually use this argument will need to check the spec and rename this to `obj` and then use it or if he is debugging it he will is not able to watch for a meaningful variable name and will need to inspect `_` which is weird and uncomfortable. We have not used this style anywhere in the code while I agree its very tempting to use it :),why do we need the `.toStr
+9666,"@@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[])
+     // setup log4cxx
+     QRLogger::initLog4cxx(QRLogger::QRL_LOB);
+     // initialize lob globals
+-    lobGlobals = new ExLobGlobals();
++    lobGlobals = new ExLobGlobals(NULL);
+     if (lobGlobals == NULL)
+       return -1;
+ ","Thanks for avoiding the default value for the param. But, I think sending heap as NULL might make this program to fail. Have you tested this program? If you have tested this program already, then this PR is ready to be merged.",Please don't pass `NULL` h
+9667,"@@ -0,0 +1,18 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MS-PL license.
++// See the LICENSE file in the project root for more information.
++
++using MvvmCross.Presenters.Attributes;
++using Windows.UI.Xaml.Controls;
++
++namespace MvvmCross.Platforms.Uap.Presenters.Attributes
++{
++    public sealed class MvxModalViewPresentationAttribute : MvxBasePresentationAttribute
++    {
++        public MvxModalViewPresentationAttribute()
++        {
++        }
++
++        public ContentDialogPlacement Placement { get; set; }
++    }
++}",Don't make it sealed,Is there a reason why this
+9668,"@@ -278,6 +278,8 @@ func (a *Account) shallowCopy() *Account {
+ 	}
+ 	// JetStream
+ 	na.jsLimits = a.jsLimits
++	// Server config account limits.
++	na.limits = a.limits
+
+ 	return na
+ }",Did we miss that for jwt before?,"These new limits are not used anywhere, right?"
+9669,"@@ -44,10 +44,10 @@ const (
+
+ // UART1 on the Trinket M0.
+ var (
+-	UART1 = UART{Bus: sam.SERCOM1_USART,
++	UART1 = UART{
+ 		Buffer: NewRingBuffer(),
+-		Mode:   PinSERCOM,
+-		IRQVal: sam.IRQ_SERCOM1,
++		Bus:    sam.SERCOM0_USART,
++		SERCOM: 0,
+ 	}
+ )
+ ","It appears that using SERCOM1 was a bug: the only SERCOM that is supported on the TX/RX pins is SERCOM0. Previous UART support wouldn't have worked on the Trinket M0 TX/RX pins anyway (`PA06`/`PA07`). This PR fixes that, and should thereby add support for UART on the Trinket M0.",Am wondering why `UART1` is replaced with `UAR
+9670,"@@ -179,7 +179,8 @@ class Preference extends Model
+     public function getLocaleOptions()
+     {
+         $localeOptions = [
+-            'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++						'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
+             'cs' => [Lang::get('system::lang.locale.cs'), 'flag-cz'],
+             'da' => [Lang::get('system::lang.locale.da'), 'flag-dk'],
+             'en' => [Lang::get('system::lang.locale.en'), 'flag-us'],","Spaces for indentation, not tabs",Please fix the indentation of these two lines.
+9671,"@@ -117,15 +117,11 @@ cvdescriptorset::DescriptorSetLayoutDef::DescriptorSetLayoutDef(const VkDescript
+     assert(bindings_.size() == binding_count_);
+     assert(binding_flags_.size() == binding_count_);
+     uint32_t global_index = 0;
+-    binding_to_global_index_range_map_.reserve(binding_count_);
+-    // Vector order is finalized so create maps of bindings to descriptors and descriptors to indices
++    global_index_range_.reserve(binding_count_);
++    // Vector order is finalized so build vectors of descriptors and dynamic offsets by binding index
+     for (uint32_t i = 0; i < binding_count_; ++i) {
+-        auto binding_num = bindings_[i].binding;
+         auto final_index = global_index + bindings_[i].descriptorCount;
+-        binding_to_global_index_range_map_[binding_num] = IndexRange(global_index, final_index);
+-        if (final_index != global_index) {
+-            global_start_to_index_map_[global_index] = i;
+-        }
++        global_index_range_.emplace_back(global_index, final_index);
+         global_index = final_index;
+     }
+ ","doing this as a binding map was insane, but with the ConstBindingIterator to hide the binding->index gunk and avoid the hashes during access it sticks out.",Wouldn't this still keep the entry in `binding
+9672,"@@ -27,6 +27,8 @@ TEST_EVENT_PATTERN = {
+     'Detail': [EVENT_DETAIL]
+ }
+
++TEST_EVENT_PATTERN_1 = {'detail': {'EventType': ['0', '1']}}
++
+
+ class EventsTest(unittest.TestCase):
+     def setUp(self):","nitpick: I'd rather move this into the test method directly (we should avoid variables at the root scope if they are not reused in multiple places). (not critical, though - shouldn't hold back the merge..)",why the _1?
+9673,"@@ -212,7 +212,12 @@ namespace TestPerf // Note: tests in the ""TestPerf"" namespace only run when the
+             {
+                 RunUI(() => importPeptideSearchDlg.ClickNextButtonNoCheck());
+             }
+-            // Modifications are already set up, so that page should get skipped.
++            // Skip Match Modifications page.
++            RunUI(() =>
++            {
++                AssertEx.IsTrue(importPeptideSearchDlg.CurrentPage == ImportPeptideSearchDlg.Pages.match_modifications_page);
++                AssertEx.IsTrue(importPeptideSearchDlg.ClickNextButton());
++            });
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.PrecursorCharges = new []{2,3,4,5});
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.PrecursorMassAnalyzer = FullScanMassAnalyzerType.tof);
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.IonMobilityFiltering.IsUseSpectralLibraryIonMobilities = useDriftTimes);","You should do: AssertEx.AreEqual(importPeptideSearchDlg.CurrentPage, ImportPeptideSearchDlg.Pages.match_modifications_page);",Please don'
+9674,"@@ -145,7 +145,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+       String schemaId = entry.getKey();
+       String content = entry.getValue();
+       GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas);
+-      boolean exists = existSchema != null;
++      boolean exists = existSchema != null && existSchema.getSummary() != null;
+       LOGGER.info(""schemaId [{}] exists {}"", schemaId, exists);
+       if (!exists) {
+         if (!srClient.registerSchema(microservice.getServiceId(), schemaId, content)) {","SC support batch register schemas we should swtich to new api be careful that maybe will send too big request, need to split to multi request by max size of limit.",Can existSc
+9675,"@@ -25,8 +25,8 @@ func NewConfig(options *compileopts.Options) (*compileopts.Config, error) {
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""could not read version from GOROOT (%v): %v"", goroot, err)
+ 	}
+-	if major != 1 || minor < 11 || minor > 14 {
+-		return nil, fmt.Errorf(""requires go version 1.11, 1.12, 1.13, or 1.14, got go%d.%d"", major, minor)
++	if major != 1 || minor < 11 || minor > 15 {
++		return nil, fmt.Errorf(""requires go version 1.11, 1.12, 1.13, 1.14, or 1.15, got go%d.%d"", major, minor)
+ 	}
+ 	clangHeaderPath := getClangHeaderPath(goenv.Get(""TINYGOROOT""))
+ 	return &compileopts.Config{","At this point, maybe it would make more sense to write this as a range rather than listing specific versions?",Does this m
+9676,"@@ -255,6 +255,11 @@ func (p Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
+ 			return http.StatusRequestEntityTooLarge, backendErr
+ 		}
+
++		// TODO: write an 499 HTTP status as constant in someplace (and also change in proxy_test.go on line: expectedStatus, expectErr := 499, context.Canceled)
++		if backendErr == context.Canceled {
++			return 499, backendErr
++		}
++
+ 		// failover; remember this failure for some time if
+ 		// request failure counting is enabled
+ 		timeout := host.FailTimeout",I guess we can start by putting the `const StatusContextCancelled = 499` at the bottom of this file,write an error status constant in some place ...
+9677,"@@ -100,6 +100,7 @@ func TestPaymentChannelVoucher(t *testing.T) {
+ 			types.NewChannelID(5),
+ 			types.NewAttoFILFromFIL(10),
+ 			types.NewBlockHeight(0),
++			nil,
+ 		)
+ 		require.NoError(err)
+ 		assert.Equal(expectedVoucher.Channel, voucher.Channel)",Blocking: populate a non-empty value and check it below.,Why was this added?
+9678,"@@ -194,7 +194,14 @@ public class Permission {
+     // Users with this permission can upload projects when the property ""lockdown.upload.projects""
+     // is turned on
+     UPLOADPROJECTS(0x0008000),
+-    ADMIN(0x8000000);
++    ADMIN(0x8000000),
++    // Permissions for image management APIs.
++    CREATE(0x0000100),
++    GET(0x0000200),
++    UPDATE(0x0000300),
++    DELETE(0x0000400),
++    IMAGE_TYPE_ADD_MEMBER(0x0000500),
++    IMAGE_TYPE_DELETE_MEMBER(0x0000600);
+
+     private final int numVal;
+ ",What is this number value for? How is it used?,What's the point of these new permissions? What'
+9679,"@@ -192,6 +192,11 @@ describe Travis::Build::Script::R, :sexp do
+                            assert: true, echo: true, retry: true, timing: true]
+     end
+
++    it 'does BiocCheck if requested' do
++      data[:config][:bioc_check] = true
++      should include_sexp [:cmd, /.*BiocCheck.*/,
++                           assert: true, echo: true, timing: true]
++
+     it 'does install bioc with bioc_packages' do
+       data[:config][:bioc_packages] = ['GenomicFeatures']
+       should include_sexp [:cmd, /.*biocLite.*/,",This needs an end keyword,do we need an option to turn this off?
+9680,"@@ -0,0 +1,17 @@
++// <copyright file=""DependencyTelemetryData.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Telemetry
++{
++    /// <summary>
++    /// Using a record as used as dictionary key so getting equality comparison for free
++    /// </summary>
++    internal record DependencyTelemetryData
++    {
++        public string Name { get; set; }
++
++        public string Version { get; set; }
++    }
++}",I think this is the first record type in Datadog.Trace!  ,why do we need to record it as a dictionary key?
+9681,"@@ -737,10 +737,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             {
+                 return Task.CompletedTask;
+             }
+-            else
+-            {
+-                return FireOnCompletedAwaited(onCompleted);
+-            }
++            return FireOnCompletedAwaited(onCompleted);
+         }
+
+         private async Task FireOnCompletedAwaited(Stack<KeyValuePair<Func<object, Task>, object>> onCompleted)",Nit: missing newline above.,Why did you change this?
+9682,"@@ -76,6 +76,13 @@ func StartKubeProxy(k8s kubernetes.Interface, hostname string,
+ 	}
+
+ 	go func() {
++		// Before we start, scan for all finished / timed out connections to
++		// free up the conntrack table asap as it may take time to sync up the
++		// proxy and kick off the first full cleaner scan.
++		lc := conntrack.NewLivenessScanner(kp.conntrackTimeouts, kp.dsrEnabled)
++		connScan := conntrack.NewScanner(kp.ctMap, lc.ScanEntry)
++		connScan.Scan()
++
+ 		err := kp.start()
+ 		if err != nil {
+ 			log.WithError(err).Panic(""kube-proxy failed to start"")","Since it's a one-off, worth putting an info log before and after.","Same as above, can you make `kp.dsrEnabled` into"
+9683,"@@ -140,8 +140,10 @@ app.controller('CalController', ['$scope', 'Calendar', 'CalendarService', 'VEven
+ 				$scope.$apply();
+ 			});
+ 		} else {
+-			$scope.calendarsPromise = CalendarService.getPublicCalendar(constants.publicSharingToken).then(function(calendar) {
+-				$scope.calendars = [calendar];
++			constants.publicSharingToken.split(""."").forEach( (token) => {
++				$scope.calendarsPromise = CalendarService.getPublicCalendar(token).then(function(calendar) {
++					$scope.calendars.push(calendar);
++			});
+ 				is.loading = false;
+ 				// TODO - scope.apply should not be necessary here
+ 				$scope.$apply();","I'm sorry, but the indentation is still wrong. This should be indented by one tab.","There is no need to load the calendar again, sin"
+9684,"@@ -360,6 +360,18 @@ class DataFrame(_Frame):
+         self._sdf = sdf
+         self._metadata = self._metadata.copy(column_fields=names)
+
++    @property
++    def dtypes(self):
++        """"""Return the dtypes in the DataFrame.
++
++        This returns a Series with the data type of each column. The result's index is the original
++        DataFrame's columns. Columns with mixed types are stored with the object dtype.
++
++        :return: :class:`pd.Series` The data type of each column.
++        """"""
++        return pd.Series([self[col].dtype for col in self._metadata.column_fields],
++                         index=self._metadata.column_fields)
++
+     @derived_from(pd.DataFrame, ua_args=['axis', 'level', 'numeric_only'])
+     def count(self):
+         return self._sdf.count()",can we add an example?,Can we just use `pd.Series(self._metadata.column_fields)`?
+9685,"@@ -156,6 +156,13 @@ func identifyUID(ctx context.Context, nug normalizedUsernameGetter,
+ func identifyUser(ctx context.Context, nug normalizedUsernameGetter,
+ 	identifier identifier, username libkb.NormalizedUsername,
+ 	uid keybase1.UID, isPublic bool) error {
++
++	// check to see if identify should be skipped altogether
++	ei := getExtendedIdentify(ctx)
++	if ei.behavior == keybase1.TLFIdentifyBehavior_CHAT_SKIP {
++		return nil
++	}
++
+ 	var reason string
+ 	if isPublic {
+ 		reason = ""You accessed a public folder.""",We usually avoid blank lines at the start of functions.,Shouldn't this be `if ei.behavior == keybase1.TLFIdentifyB
+9686,"@@ -0,0 +1,18 @@
++<?php
++
++declare(strict_types=1);
++
++/*
++ * This file is part of the Sonata Project package.
++ *
++ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
++ *
++ * For the full copyright and license information, please view the LICENSE
++ * file that was distributed with this source code.
++ */
++
++use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
++
++return static function (ContainerConfigurator $containerConfigurator): void {
++    $containerConfigurator->services();
++};",I dont think this line is needed,Can't we inject the ContainerConfigurator directly instead
+9687,"@@ -22,7 +22,12 @@ const (
+ // requests w.r.t a single Volume.
+ func (s *HTTPServer) volumeSpecificRequest(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
+ 	// check the feature gate & switch if enabled
+-	if util.CASTemplateFeatureGate() {
++	feature, err := util.CASTemplateFeatureGate()
++	if err != nil {
++		// exit if invalid value
++		glog.Fatalf(""invalid feature gate value for %s only boolean values allowed"", util.CASTemplateFeatureGateENVK)
++	}
++	if feature {
+ 		return s.volumeV1alpha1SpecificRequest(resp, req)
+ 	}
+ ",We should not panic here !!! We return error i.e. 500 http code,"If the default gate isn't enabled, what does this env var "
+9688,"@@ -1305,8 +1305,16 @@ nano:       use nanosecond-precision (requires libpcap >= 1.5.0)
+             else:
+                 pkt = pkt.__iter__()
+             for p in pkt:
++
+                 if not self.header_present:
+                     self._write_header(p)
++
++                if self.linktype != conf.l2types.get(type(p), None):
++                    warning(""Inconsistent linktypes detected!""
++                            "" The resulting PCAP file might contain""
++                            "" invalid packets.""
++                            )
++
+                 self._write_packet(p)
+
+     def _write_packet(self, packet, sec=None, usec=None, caplen=None,","To avoid useless calls to `conf.l2types.get()` we could have a `set()` of types that are OK in this PCAP files. We could check if `p.__class__ not in self.l2_types_seen` first, only run this code block in that case, and add `self.l2_types_seen.add(p.__class__)`. I'm not sure if I'm clear here... let me know what you think.",Should this be a `ConfigurationError` instead of a warning?
+9689,"@@ -129,6 +129,11 @@ public class Constants {
+   // Used (or should be used) wherever a string representation of UTF_8 charset is needed:
+   public static final String UTF_8 = java.nio.charset.StandardCharsets.UTF_8.toString();
+
++  // Specifies the source(adhoc, scheduled, flow_trigger) from where flow execution is triggered
++  public static final String EXECUTION_SOURCE_ADHOC = ""adhoc"";
++  public static final String EXECUTION_SOURCE_SCHEDULED = ""scheduled"";
++  public static final String EXECUTION_SOURCE_FLOW_TRIGGER = ""flow_trigger"";
++
+   public static class ConfigurationKeys {
+
+     public static final String AZKABAN_GLOBAL_PROPERTIES_EXT_PATH = ""executor.global.properties"";","Shouldn't ""source"" be a noun? How about? -EXECUTION_SOURCE_USER -EXECUTION_SOURCE_SCHEDULE -EXECUTION_SOURCE_EVENT (because it's an event based trigger mechanism)",I think we should use `FLOW_TRIGGER` instead of `FLOW_TRIGG
+9690,"@@ -1,6 +1,6 @@
+ _base_ = [
+     '../_base_/models/mask_rcnn_r50_fpn.py',
+-    '../_base_/datasets/coco_instance.py',
++    '../_base_/datasets/lvis_v1_instance.py',
+     '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py'
+ ]
+ model = dict(",Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.,why is this changed?
+9691,"@@ -24,6 +24,8 @@ describe('th-has-data-cells', function () {
+ 			'<table>' +
+ 			'  <tr> <th>hi</th> <td>hello</td> </tr>' +
+ 			'  <tr> <th>hi</th> <td>hello</td> </tr>' +
++			'  <tr> <td>hello</td> <th>hi</th> </tr>' +
++			'  <tr> <td>hello</td> <th>hi</th> </tr>' +
+ 			'</table>';
+
+ 		var node = fixture.querySelector('table');","Last time I checked, this technique did not work on all major screen reader - browser combinations. What screen readers have you tested?",Don't you need to add `<th>hi</th>` to the end of `<td>hi</
+9692,"@@ -180,6 +180,8 @@ namespace Datadog.Trace.Configuration
+
+             TraceBatchInterval = source?.GetInt32(ConfigurationKeys.SerializationBatchInterval)
+                         ?? 100;
++
++            AspnetRouteTemplateResourceNamesEnabled = IsFeatureFlagEnabled(ConfigurationKeys.FeatureFlags.AspnetRouteTemplateResourceNamesEnabled);
+         }
+
+         /// <summary>","Most tracer settings can be set in several ways: environment variables, `app.config`/`web.config` file, or in a json file (`~/datadog.json` by default). Most exceptions to this rule are settings in native code (where we use env vars only). Currently, `DD_TRACE_ASPNET_ROUTE_TEMPLATE_RESOURCE_NAMES_ENABLED` will only work as an env var. Was this limitation intentional?",I think this should be outside the `if` statement and not inside the `if` statement.
+9693,"@@ -218,4 +218,10 @@ type Config struct {
+
+ 	// TaskMetadataBurstRate specifies the burst rate throttle for the task metadata endpoint
+ 	TaskMetadataBurstRate int
++
++	// NoIID when set to true, specifies that the agent should not register the instance
++	// with instance identity document. This is required in order to accomodate scenarios in
++	// which ECS agent tries to register the instance where the instance id document is
++	// not available or needed
++	NoIID bool
+ }","Would ""DisableIID"" be a better name? For example, we used DisableMetrics, ImageCleanupDisabled, ... etc. for other similar fields.",Can you add a `TODO` so that we remember to remove this once the agent is done?
+9694,"@@ -3908,7 +3908,7 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb)
+             BBPRINT(bb, 3, ""reached end pc "" PFX "", stopping\n"", bb->stop_pc);
+             break;
+         }
+-        if (total_instrs > DYNAMO_OPTION(max_bb_instrs)) {
++        if (total_instrs == DYNAMO_OPTION(max_bb_instrs) - 1) {
+             /* this could be an enormous basic block, or it could
+              * be some degenerate infinite-loop case like a call
+              * to a function that calls exit() and then calls itself,","So this is a swing of 2: but I think we only need to reduce by 1? The artificial jump added on truncation is not passed to clients: it's like other mangling added later. So if `-max_bb_instrs 4` means 4 app instrs passed to clients, we'd want ==, not ==-1, right? Plus, if we did want -1 and to stop at 3 instead of 4, this is not sufficient: the inner loop above currently has `total_instrs <= cur_max_bb_instrs`.",This should be total_instrs > DYNAMO_OPTION(max_bb_instrs)
+9695,"@@ -362,7 +362,7 @@ LmExprResult CreateLmOutputExpr(const NAType &formalType,
+ // specified type t to be converted to/from C strings. The only
+ // SQL types that do not need to be converted to C strings are:
+ //
+-//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION
++//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION, BOOLEAN
+ //
+ // because these types map to Java primitive types:
+ //","Does Tinyint belong to this set of types? I suppose the answer is No, but thought it safer to check.",Shouldn't `BOOLEAN` be added here too?
+9696,"@@ -1110,6 +1110,17 @@ Blockly.WorkspaceSvg.prototype.isDeleteArea = function(e) {
+   return Blockly.DELETE_AREA_NONE;
+ };
+
++/**
++ * Is the mouse event outside the blocks UI, to the right of the workspace?
++ * @param {!Event} e Mouse move event.
++ * @return {boolean} True if event is outside the blocks UI.
++ */
++Blockly.WorkspaceSvg.prototype.isOutside = function(e) {
++  var mousePoint = Blockly.utils.mouseToSvg(e, this.getParentSvg(),
++      this.getInverseScreenCTM());
++  return this.getParentSvg().width.baseVal.value < mousePoint.x;
++};
++
+ /**
+  * Handle a mouse-down on SVG drawing surface.
+  * @param {!Event} e Mouse down event.","I'm a bit leery of this implementation, because it assumes that the only ""outside"" is to the right side. Note that Blockly assumes that there's nothing useful to the ""outside"" of the toolbox, based on the configuration of the workspace, so it's not like we're doing the right thing either. I think this will break in RTL. If you keep the editor in the same place but inject with RTL, everything you're looking for will be in the delete area. If the editor and stage swap places, this will just be looking on the wrong side.",Please use the `Blockly.WorkspaceSvg` class instead.
+9697,"@@ -180,6 +180,7 @@ type Config struct {
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail""`
+
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
++	NatPortRange       numorstring.Port   `config:""portrange;;local""`
+
+ 	UsageReportingEnabled          bool          `config:""bool;true""`
+ 	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`",Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only,why is this needed?
+9698,"@@ -2322,7 +2322,7 @@ bool DiscoveryDataBase::from_json(
+             }
+
+             // Add Participant
+-            auto wit = writers_.insert(std::make_pair(guid_aux, dei));
++            writers_.insert(std::make_pair(guid_aux, dei));
+
+             // Extra configurations for writers
+             // Add writer to writers_by_topic. This will create the topic if necessary","That's a tricky one, as the variable is indeed used in line 2346, which is a `logInfo` message that is not compiled unless `INTERNAL_DEBUG` is set or `CMAKE_BUILD_TYPE` is set to `Debug`. Our CI builds with `INTERNAL_DEBUG` to verify that all `logInfo` are correct, and thus we don't get the warning. The best is probably to remove the iterator (as you did), as well as the part of the log that uses it.",Does this get called again? It looks like it would h
+9699,"@@ -600,7 +600,7 @@ class L3PacketSocket(L2Socket):
+         # type: (Packet) -> int
+         iff = x.route()[0]
+         if iff is None:
+-            iff = conf.iface
++            iff = network_name(conf.iface)
+         sdto = (iff, self.type)
+         self.outs.bind(sdto)
+         sn = self.outs.getsockname()",I suspect L2Socket needs a similar change (line 502) for the case where `iface` is None (line 479),This should be `network_name(conf.iface)` for consis
+9700,"@@ -0,0 +1,3 @@
++ActiveAdmin.register LicensePermission do
++  permit_params :name, :description, :icon
++end",Was this all that was needed to add CRUD operations for the LicensePermission model? :-),I _think_ this permission should be `:manage_license`
+9701,"@@ -465,7 +465,7 @@ def installAddon(parentWindow, addonPath):
+
+ 	prevAddon = None
+ 	for addon in addonHandler.getAvailableAddons():
+-		if not addon.isPendingRemove and bundle.name==addon.manifest['name']:
++		if not addon.isPendingRemove and bundle.name.lower()==addon.manifest['name'].lower():
+ 			prevAddon=addon
+ 			break
+ 	if prevAddon:",Did you look for other locations that compare name? I expected there to be more.,"hmm, can't you do `addon.manifest.lower()` instead?"
+9702,"@@ -47,6 +47,9 @@ public final class BaselineTesting implements Plugin<Project> {
+                         .findAny()
+                         .ifPresent(ignored -> enableJUnit5ForAllTestTasks(project));
+             });
++
++            // Never cache test tasks, until we work out the correct inputs for ETE / integration tests
++            project.getTasks().withType(Test.class).configureEach(test -> test.getOutputs().cacheIf(task -> false));
+         });
+     }
+ ",There were some requests internally to allow users to opt out of this behaviour. We could expose a property that allows people to toggle ti,This is the only place where we have access to the pr
+9703,"@@ -300,10 +300,11 @@ public class TestIndexWriterDelete extends LuceneTestCase {
+     modifier.close();
+     dir.close();
+   }
+-
++
+   public void testDeleteAllNoDeadLock() throws IOException, InterruptedException {
+     Directory dir = newDirectory();
+-    final RandomIndexWriter modifier = new RandomIndexWriter(random(), dir);
++    final RandomIndexWriter modifier = new RandomIndexWriter(random(), dir,
++        newIndexWriterConfig().setMergePolicy(new MockRandomMergePolicy(random())));
+     int numThreads = atLeast(2);
+     Thread[] threads = new Thread[numThreads];
+     final CountDownLatch latch = new CountDownLatch(1);",Nice -- this forced `merge-on-getReader/commit` to be used more often in this test?,You can just use `new MockRandomMergePolicy(random())
+9704,"@@ -221,6 +221,9 @@ type ConsensusParams struct {
+
+ 	// sum of estimated op cost must be less than this
+ 	LogicSigMaxCost uint64
++
++	// a precision for assets
++	SupportAssetsPrecision bool
+ }
+
+ // Consensus tracks the protocol-level settings for different versions of the","Instead of a `bool`, can we just call this `MaxAssetDecimals` and have it be a `uint8`/`uint16`/`uint32` whose value is 0 before the upgrade and 19 after (2**64 - 1 is 20 decimal digits)? We'll need to set a maximum value anyway, and that way there's only one new proto variable instead of two.",Please add a doc string explaining what this is
+9705,"@@ -145,7 +145,10 @@ final class EntityRepository implements EntityRepositoryInterface
+
+             if ($sortFieldIsDoctrineAssociation) {
+                 $sortFieldParts = explode('.', $sortProperty, 2);
+-                $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
++                // check if join has been added once before.
++                if (!\in_array($sortFieldParts[0], $aliases)) {
++                    $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
++                }
+
+                 if (1 === \count($sortFieldParts)) {
+                     $queryBuilder->addOrderBy('entity.'.$sortProperty, $sortOrder);",where `$aliases` is defined ? @javiereguiluz,"This check should be moved to the `if` below, b"
+9706,"@@ -66,12 +66,9 @@ func (h *Handler) FetchJWTSVID(ctx context.Context, req *workload.JWTSVIDRequest
+ 	var spiffeIDs []string
+ 	identities := h.Manager.MatchingIdentities(selectors)
+ 	if len(identities) == 0 {
+-		telemetry_common.AddRegistered(counter, false)
+ 		return nil, status.Errorf(codes.PermissionDenied, ""no identity issued"")
+ 	}
+
+-	telemetry_common.AddRegistered(counter, true)
+-
+ 	for _, identity := range identities {
+ 		if req.SpiffeId != """" && identity.Entry.SpiffeId != req.SpiffeId {
+ 			continue",what is the justification for the removal of the registered label? it doesn't seem to have high cardinality nor is it redundant. Seems useful to shed insight into understand situations where workloads aren't registered....,"If we're removing telemetry, shouldn't we also "
+9707,"@@ -1835,3 +1835,7 @@ func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDepl
+ 		DeploymentChain: dc,
+ 	}, nil
+ }
++
++func (a *WebAPI) ListEvents(ctx context.Context, req *webservice.ListEventsRequest) (*webservice.ListEventsResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""Not implemented"")
++}",`ctx` is unused in ListEvents,"Error returns an error, why don't we return it?"
+9708,"@@ -101,6 +101,14 @@ public class SmartStoreTest extends SmartStoreTestCase {
+         Assert.assertTrue(""ENABLE_JSON1 flag not found in compile options"", compileOptions.contains(""ENABLE_JSON1""));
+ 	}
+
++	/**
++	 * Checking sqlcipher version
++	 */
++	@Test
++	public void testSQLCipherVersion() {
++		Assert.assertEquals(""Wrong sqlcipher version"", ""4.0.1 community"", store.getSQLCipherVersion());
++	}
++
+ 	/**
+ 	 * Method to check soup blob with one stored by db. Can be overridden to check external storage if necessary.
+ 	 */",We've had that test on iOS for years.,nit: Please rename this test to `testSQLCipherVersionCheck`
+9709,"@@ -37,7 +37,7 @@ namespace BenchmarkDotNet.Extensions
+                     .DontEnforcePowerPlan(); // make sure BDN does not try to enforce High Performance power plan on Windows
+
+                 // See https://github.com/dotnet/roslyn/issues/42393
+-                job = job.WithArguments(new Argument[] { new MsBuildArgument(""/p:DebugType=portable"") });
++                job = job.WithArguments(new Argument[] { new MsBuildArgument(""/p:DebugType=portable""), new MsBuildArgument(""-bl:benchmarkdotnet.binlog"") });
+             }
+
+             var config = ManualConfig.CreateEmpty()",This is for creating binlog file for building bdn generated template project. I feel that it's may be helpful in general for bdn diagnostic purpose.,Please don't use `MsBuildArgument` here. It's an extension
+9710,"@@ -359,6 +359,18 @@ class QuteProc(testprocess.Process):
+         else:
+             self.send_cmd(':open ' + url)
+
++    def open_url(self, url, *, new_tab=False, new_window=False):
++        """"""Open the given url in qutebrowser.""""""
++        if new_tab and new_window:
++            raise ValueError(""new_tab and new_window given!"")
++
++        if new_tab:
++            self.send_cmd(':open -t ' + url)
++        elif new_window:
++            self.send_cmd(':open -w ' + url)
++        else:
++            self.send_cmd(':open ' + url)
++
+     def mark_expected(self, category=None, loglevel=None, message=None):
+         """"""Mark a given logging message as expected.""""""
+         line = self.wait_for(category=category, loglevel=loglevel,",Can you adjust `open_path` to simply call `path_to_url` and then `open_url` instead of duplicating the code?,"How about `open_tab` instead of `new_tab`? To me, `new_wind"
+9711,"@@ -24,10 +24,10 @@ import (
+ var logGraphsyncFetcher = logging.Logger(""net.graphsync_fetcher"")
+
+ const (
+-	// Timeout for a single graphsync request (which may be for many blocks).
+-	// We might prefer this timeout to scale with the number of blocks expected in the fetch,
+-	// when that number is large.
+-	requestTimeout = 60 * time.Second
++	// Timeout for a single graphsync request getting ""stuck""
++	// -- if no more responses are received for a period greater than this,
++	// we will assume the request has hung-up and cancel it
++	unresponsiveTimeout = 10 * time.Second
+ )
+
+ // Fetcher defines an interface that may be used to fetch data from the network.",I'm curious -- do we have information on the upper bound of the delay we would expect with high probability from a peer with no network issues? My intuition is that we want to set this as low as we can reasonably get away with before we start killing productive connections. My uninformed intuition is also that 10 seconds is probably higher than we need and I'd love to know if this is wrong and 10 seconds is already pushing the limit.,"`s/hung-up/hung-up/`, there is no hung-up notification in t"
+9712,"@@ -44,7 +44,7 @@ public class SarOperation extends AbstractFixedCostOperation {
+     } else {
+       final int shiftAmountInt = shiftAmount.toInt();
+
+-      if (shiftAmountInt >= 256) {
++      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
+         frame.pushStackItem(negativeNumber ? ALL_BITS : UInt256.ZERO);
+       } else {
+         // first perform standard shift right.",what happens if it's == 0,"Not related to this PR, but why are we converting `ALL_BITS` to `UInt256` here?"
+9713,"@@ -27,10 +27,6 @@ module Bolt
+           if @config['interpreters']
+             @config['interpreters'] = normalize_interpreters(@config['interpreters'])
+           end
+-
+-          if Bolt::Util.windows? && @config['run-as']
+-            raise Bolt::ValidationError, ""run-as is not supported when using PowerShell""
+-          end
+         end
+       end
+     end","We could potentially log a message here instead that indicates the transport does not support `run-as` on Windows and will be ignored, just in case users expect it to and are surprised. Since it would _always_ be logged when using `--run-as` on Windows, even when the transport isn't being used, it would probably want to be either at debug or trace level.",This validation is now handled by the `Bolt::Util` class.
+9714,"@@ -4,7 +4,7 @@ import (
+ 	neturl ""net/url""
+ 	""strings""
+
+-	""github.com/bonitoo-io/go-sql-bigquery""
++	bigquery ""github.com/bonitoo-io/go-sql-bigquery""
+ 	""github.com/go-sql-driver/mysql""
+ 	""github.com/influxdata/flux/codes""
+ 	""github.com/influxdata/flux/dependencies/url""",Did we need this alias? Or is it just a holdout from development?,Why was this necessary?
+9715,"@@ -72,7 +72,7 @@ class EditTest < ActiveSupport::TestCase
+     p.update_attributes(organization_id: org.id)
+     edit = PropertyEdit.where(target: p, key: 'organization_id').first
+     edit.project_id.must_equal p.id
+-    edit.organization_id.must_equal org.id
++    edit.value.must_equal org.id.to_s
+   end
+
+   it 'test_that_nothing_gets_filled_in_automatically_for_license_edits' do",This should have failed before.,"I'm not sure how `updated_at` is going to work now, but we need to make sure th"
+9716,"@@ -56,7 +56,8 @@ namespace Datadog.Trace.Vendors.Serilog.Sinks.File
+                 ""(?<"" + PeriodMatchGroup + "">\\d{"" + _periodFormat.Length + ""})"" +
+                 ""(?<"" + SequenceNumberMatchGroup + "">_[0-9]{3,}){0,1}"" +
+                 Regex.Escape(_filenameSuffix) +
+-                ""$"");
++                ""$"",
++                RegexOptions.Compiled);
+
+             DirectorySearchPattern = $""{_filenamePrefix}*{_filenameSuffix}"";
+         }","Slower construction, faster matching. I wonder if this will be noticeable in the relenv?",@QilongTang @stephentoub why did you have to change this?
+9717,"@@ -61,6 +61,9 @@ void ThroughputPublisher::DataPubListener::onPublicationMatched(
+     if (info.status == MATCHED_MATCHING)
+     {
+         ++throughput_publisher_.data_discovery_count_;
++        std::cout << C_RED << ""Pub: DATA Pub Matched ""
++            << throughput_publisher_.data_discovery_count_ << ""/"" << throughput_publisher_.subscribers_
++            << C_DEF << std::endl;
+     }
+     else
+     {","I think that if `data_discovery_count_ > static_cast<int>(throughput_publisher_.subscribers_)`, then we should not proceed, since we have discovered some unexpected subscriber that can affect the test results. I'd change the comparison to `==` and have and `else if` contemplating the `>` case",This is a debug line that can be removed.
+9718,"@@ -51,6 +51,7 @@
+ #include <iomanip>
+ #include <stdexcept>
+ #include <impl/Kokkos_Error.hpp>
++#include <Cuda/Kokkos_Cuda_Error.hpp>
+
+ //----------------------------------------------------------------------------
+ //----------------------------------------------------------------------------",Remove that include,Please add `#include <impl/Kokkos_Error.hpp>` to this fil
+9719,"@@ -130,6 +130,7 @@ class EasyAdminFormType extends AbstractType
+         return function (Options $options, $value) {
+             return array_replace(array(
+                 'id' => sprintf('%s-%s-form', $options['view'], strtolower($options['entity'])),
++                'class' => sprintf('%s-form', $options['view']),
+             ), $value);
+         };
+     }","IMO this should be defined in the form theme instead. This class should always be there. If the user configured additional css classes, it should be appended instead of replacing the `{view}-form` css class.",Shouldn't this be `strtolower($options['entity'])` to be
+9720,"@@ -36,6 +36,7 @@ import com.salesforce.androidsdk.auth.OAuth2.TokenEndpointResponse;
+ import com.salesforce.androidsdk.rest.RestClient.AuthTokenProvider;
+ import com.salesforce.androidsdk.rest.RestClient.ClientInfo;
+ import com.salesforce.androidsdk.rest.RestRequest.RestMethod;
++import com.salesforce.androidsdk.util.JSONObjectHelper;
+
+ import org.json.JSONArray;
+ import org.json.JSONException;",These tests actually go to the server.,Is this used?
+9721,"@@ -147,6 +147,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+         {
+             var onStartingCalled = false;
+             var onCompletedCalled = false;
++            var onCompleted = Task.Run(() => onCompletedCalled = true);
+
+             var hostBuilder = TransportSelector.GetWebHostBuilder()
+                 .UseKestrel()",This test modification isn't correct. This task could run immediately and you wouldn't be able to tell if OnCompleted was called or not.,Should this b
+9722,"@@ -20,11 +20,13 @@ export function setComponentProps(component, props, opts, context, mountAll) {
+ 	if ((component.__ref = props.ref)) delete props.ref;
+ 	if ((component.__key = props.key)) delete props.key;
+
+-	if (!component.base || mountAll) {
+-		if (component.componentWillMount) component.componentWillMount();
+-	}
+-	else if (component.componentWillReceiveProps) {
+-		component.componentWillReceiveProps(props, context);
++	if (typeof component.constructor.getDerivedStateFromProps === 'undefined') {
++		if (!component.base || mountAll) {
++			if (component.componentWillMount) component.componentWillMount();
++		}
++		else if (component.componentWillReceiveProps) {
++			component.componentWillReceiveProps(props, context);
++		}
+ 	}
+
+ 	if (context && context!==component.context) {",I'd be open to loosening this check if it can help offset the size.,Why not use t
+9723,"@@ -2017,6 +2017,9 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         Apply a function that takes pandas DataFrame and outputs pandas DataFrame. The pandas
+         DataFrame given to the function is of a batch used internally.
+
++        See also `Transform and apply a function
++        <https://koalas.readthedocs.io/en/stable/user_guide/transform_apply.html>`_.
++
+         .. note:: the `func` is unable to access to the whole input frame. Koalas internally
+             splits the input series into multiple batches and calls `func` with each batch multiple
+             times. Therefore, operations such as global aggregations are impossible. See the example","I'm wondering which we should use, stable or latest?",I would add a
+9724,"@@ -25,7 +25,8 @@ public abstract class BftExtraDataCodec {
+   protected enum EncodingType {
+     ALL,
+     EXCLUDE_COMMIT_SEALS,
+-    EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER
++    EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER,
++    EXCLUDE_CMS // TODO-lucas How can we achieve this w/o changing the BftExtraDataCodec base class
+   }
+
+   private static final Logger LOG = LogManager.getLogger();",possibly extending EncodingType enum?,What is this? How can I achieve this?
+9725,"@@ -26,6 +26,18 @@ describe ""Selenium::WebDriver::TargetLocator"" do
+     end
+   end
+
++  it ""should switch to parent frame"" do
++    driver.navigate.to url_for(""iframes.html"")
++
++    iframe = driver.find_element(:tag_name => ""iframe"")
++    driver.switch_to.frame(iframe)
++
++    driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)
++
++    driver.switch_to.parent_frame
++    driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element)
++  end
++
+   # switching by name not yet supported by safari
+   not_compliant_on :browser => [:ie, :iphone, :safari] do
+     it ""should switch to a window and back when given a block"" do",I tested it only in Firefox (`./go //rb:firefox-test`),"`driver.find_element(:name, 'login')."
+9726,"@@ -27,7 +27,7 @@ using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process;
+
+ namespace OpenTelemetry.Exporter.Jaeger
+ {
+-    public class JaegerExporter : BaseExporter<Activity>
++    public class JaegerExporter : BaseExporter<Activity>, IProviderContainer<TracerProvider>
+     {
+         private readonly int maxPayloadSizeInBytes;
+         private readonly TProtocolFactory protocolFactory;","can we do this in the baseexporter itself? So that exporters just access this.Provider.Resource, and baseexporters take care of populating Provider?",Can you make this `IProviderContainer
+9727,"@@ -156,7 +156,9 @@ module.exports = function(grunt) {
+                     'frontend/express/public/core/session-frequency/javascripts/countly.models.js',
+                     'frontend/express/public/core/session-frequency/javascripts/countly.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.models.js',
+-                    'frontend/express/public/core/events/javascripts/countly.views.js'
++                    'frontend/express/public/core/events/javascripts/countly.views.js',
++                    'frontend/express/public/core/events/javascripts/countly.events.models.js',
++                    'frontend/express/public/core/events/javascripts/countly.events.views.js'
+                 ],
+                 dest: 'frontend/express/public/javascripts/min/countly.lib.concat.js'
+             }",what is the difference between `/core/events/javascripts/countly.views.js` and `/core/events/javascripts/countly.events.views.js`,Is this necessary? I don't see any ne
+9728,"@@ -16,6 +16,10 @@ axe.a11yCheck = function (context, options, callback) {
+ 		options = {};
+ 	}
+
++	if (!('iframes' in options)) {
++		options.iframes = true;
++	}
++
+ 	var audit = axe._audit;
+ 	if (!audit) {
+ 		throw new Error('No audit configured');",We should make sure this is also supported by `axe.run`. Perhaps moving it into run-rules would cover both API methods more easily?,You don't need the explicit `in` check here. The compiler will optimise this away anyway.
+9729,"@@ -46,9 +46,9 @@ class MemoryBasedStorage(StorageBase):
+     def set_record_timestamp(self, collection_id, parent_id, record,
+                              modified_field=DEFAULT_MODIFIED_FIELD,
+                              last_modified=None):
+-        timestamp = self._bump_timestamp(collection_id, parent_id, record,
+-                                         modified_field,
+-                                         last_modified=last_modified)
++        timestamp = self._bump_and_store_timestamp(collection_id, parent_id, record,
++                                                   modified_field,
++                                                   last_modified=last_modified)
+         record[modified_field] = timestamp
+         return record
+ ","If the `MemoryBasedStorage` relies on a `self._bump_and_store_timestamp()`, then every child class will have to implement it. So it should not be prefixed with `_`. And should raise `NotImplementedError` etc. :)",Indentation for _bump_and_store_timestamp :)
+9730,"@@ -8,7 +8,6 @@ using System.Collections.Generic;
+
+ namespace System.Diagnostics
+ {
+-    [MemoryDiagnoser]
+     [BenchmarkCategory(Categories.Libraries)]
+     public class Perf_Activity
+     {",why removed the MemoryDiagnoser attribute?,Do we have benchmarks for perf devices that don't have a `MemoryDiagnoser`?
+9731,"@@ -3939,7 +3939,16 @@ function getModelsMapForPopulate(model, docs, options) {
+       foreignField = foreignField.call(doc);
+     }
+
+-    const ret = convertTo_id(utils.getValue(localField, doc));
++    const localFieldPath = modelSchema.paths[localField];
++    const localFieldGetters = localFieldPath ? localFieldPath.getters : [];
++    let ret;
++
++    if (localFieldGetters.length) {
++      ret = localFieldGetters[0].call(doc, doc[localField]);
++    } else {
++      ret = convertTo_id(utils.getValue(localField, doc));
++    }
++
+     const id = String(utils.getValue(foreignField, doc));
+     options._docs[id] = Array.isArray(ret) ? ret.slice() : ret;
+ ","Why do this instead of `localFieldPath.applyGetters(doc[localField], doc)` ?",Do we need to check for `null` here?
+9732,"@@ -186,15 +186,6 @@ SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if match count is negative"") {
+         invalid_argument);
+ }
+
+-SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if match count is positive"") {
+-    REQUIRE_THROWS_AS(
+-        (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_type>(
+-            false,
+-            isomorphism_kind::induced,
+-            1)),
+-        unimplemented);
+-}
+-
+ // SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if semantic match is true"") {
+ //     REQUIRE_THROWS_AS(
+ //         (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_type>(",Just for a check. Do you really want to delete this?,"This test is now useless, because `check_subgraph_isomorphism` already throws if the count is positive."
+9733,"@@ -10,8 +10,10 @@ import (
+ 	""context""
+ 	""os""
+
++	""github.com/golang/protobuf/proto""
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
++	""github.com/iotexproject/iotex-core/blockchain/action""
+ 	""github.com/iotexproject/iotex-core/blocksync""
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/consensus""",github.com/golang/protobuf/proto group in next group,Shall we remove this?
+9734,"@@ -64,6 +64,7 @@ var rootSubcmdsDaemon = map[string]*cmds.Command{
+ 	""mining"":    miningCmd,
+ 	""mpool"":     mpoolCmd,
+ 	""orderbook"": orderbookCmd,
++	""paych"":     paymentChannelCmd,
+ 	""ping"":      pingCmd,
+ 	""show"":      showCmd,
+ 	""swarm"":     swarmCmd,",Nit: what about just `pay`? Is there some other subcommand that would conflict with?,Can you add this to `help.md` as well?
+9735,"@@ -55,8 +55,13 @@ public class Scalars {
+           if (!(input instanceof StringValue)) {
+             throw new CoercingParseLiteralException(""Value is not any Address : '"" + input + ""'"");
+           }
++          String inputValue = ((StringValue) input).getValue();
++          if (!inputValue.startsWith(""0x"")) {
++            throw new CoercingParseLiteralException(
++                ""Address value '"" + inputValue + ""' is not prefixed with 0x"");
++          }
+           try {
+-            return Address.fromHexStringStrict(((StringValue) input).getValue());
++            return Address.fromHexStringStrict(inputValue);
+           } catch (final IllegalArgumentException e) {
+             throw new CoercingParseLiteralException(""Value is not any Address : '"" + input + ""'"");
+           }","Just for the sake of keeping things logically co-located, I'd like to see this functionality in `Quantity.java` which has a lot of utility methods related to this. Maybe a `static` method like `Quantity.isValid(String string)`?",Does this need a `CoercingParseLiteralException` as well?
+9736,"@@ -72,7 +72,7 @@ public abstract class FlinkTestBase extends AbstractTestBase {
+     return tEnv;
+   }
+
+-  List<Object[]> sql(String query, Object... args) {
++  public List<Object[]> sql(String query, Object... args) {
+     TableResult tableResult = getTableEnv().executeSql(String.format(query, args));
+     tableResult.getJobClient().ifPresent(c -> {
+       try {",How about use `protected` ?,why the change to access and static?
+9737,"@@ -32,6 +32,12 @@ func (ih *IntermediateHashes) WillUnloadBranchNode(prefixAsNibbles []byte, nodeH
+ 	if len(prefixAsNibbles) == 0 || len(prefixAsNibbles)%2 == 1 {
+ 		return
+ 	}
++
++	// special case. Store Account.Root for long time
++	if len(prefixAsNibbles) == common.HashLength*2 {
++		return
++	}
++
+ 	InsertCounter.Inc(1)
+
+ 	buf := pool.GetBuffer(keyBufferSize)",Should it not be `common.HashLength*2 + common.IncarnationLength` ?,This case should only happen for mul
+9738,"@@ -422,7 +422,8 @@ public class FlowRunner extends EventHandler implements Runnable {
+
+       // If a job is seen as failed or killed due to failing SLA, then we set the parent flow to
+       // FAILED_FINISHING
+-      if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node.isKilledBySLA())) {
++      if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node
++          .isKilledBySLA())) {
+         // The job cannot be retried or has run out of retry attempts. We will
+         // fail the job and its flow now.
+         if (!retryJobIfPossible(node)) {",those change are done by save plugin.,This looks unrelated to the rest of
+9739,"@@ -37,7 +37,9 @@ public class MimeHeader {
+     };
+
+     protected ArrayList<Field> mFields = new ArrayList<Field>();
+-    private String mCharset = null;
++
++    // use UTF-8 as standard to prevent NullPointerExceptions
++    private String mCharset = ""UTF-8"";
+
+     public void clear() {
+         mFields.clear();",There were problems with NullPointerException and with german Umlauts in message titles (I know they're not allowed in the specifiation but they caused my K-9-Inbox to not work at all) I don't know if this is related to PGP/Mime,Shouldn't this default to `StandardC
+9740,"@@ -0,0 +1,11 @@
++// <copyright file=""IEvent.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Abstractions
++{
++    internal interface IEvent
++    {
++    }
++}",This is an appsec concept right? Should it live in the Appsec namespace?,why not make this an interface instead?
+9741,"@@ -11,11 +11,10 @@ func main() {
+ 	machine.I2C0.Configure(machine.I2CConfig{})
+
+ 	// Init BlinkM
+-	machine.I2C0.WriteTo(0x09, []byte(""o""))
++	machine.I2C0.WriteRegister(0x09, 'o', nil)
+
+ 	version := []byte{0, 0}
+-	machine.I2C0.WriteTo(0x09, []byte(""Z""))
+-	machine.I2C0.ReadFrom(0x09, version)
++	machine.I2C0.ReadRegister(0x09, 'Z', version)
+ 	println(""Firmware version:"", string(version[0]), string(version[1]))
+
+ 	count := 0","I'd personally recommend having the demo check for error, unless it's worthless.",`version` needs to be declared at the t
+9742,"@@ -582,7 +582,7 @@ public class DistributorTest {
+         );
+
+         Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession();
+-        LOG.info(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
++        LOG.finer(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
+
+         boolean inFirefoxNodes = firefoxNodes.stream().anyMatch(node -> node.getUri().equals(firefoxSession.getUri()));
+         boolean inChromeNodes = chromeNodes.stream().anyMatch(node -> node.getUri().equals(chromeSession.getUri()));","Since this is in a test, I imagine that the choice of `info` level was deliberate.",This should be removed.
+9743,"@@ -1,10 +1,10 @@
+ const Plugin = require('../../core/Plugin')
+ const Translator = require('../../core/Translator')
+ const dragDrop = require('drag-drop')
+-const Dashboard = require('./Dashboard')
++const DashboardUI = require('./Dashboard')
+ const StatusBar = require('../StatusBar')
+ const Informer = require('../Informer')
+-const { findAllDOMElements } = require('../../core/Utils')
++const { findAllDOMElements, toArray } = require('../../core/Utils')
+ const prettyBytes = require('prettier-bytes')
+ const { defaultTabIcon } = require('./icons')
+ ",good call swapping these names! makes more sense this way i think,`toArray` is not supported in IE11. Use
+9744,"@@ -13,8 +13,12 @@ import options from './options';
+  */
+ export function render(vnode, parentDom, replaceNode) {
+ 	if (options._root) options._root(vnode, parentDom);
+-	let oldVNode = replaceNode && replaceNode._children || parentDom._children;
+
++	let oldVNode = replaceNode && replaceNode._children || parentDom._children;
++	let isHydrating = false;
++	if (replaceNode === null) {
++		isHydrating = true;
++	}
+ 	vnode = createElement(Fragment, null, [vnode]);
+
+ 	let mounts = [];",Maybe leaving this out will save some bytes as in let `let isHydrating = replaceNode === null`,"Let's call this `isHydratingVNode`, since it's a boolean."
+9745,"@@ -298,6 +298,10 @@ class RustGenerator : public BaseGenerator {
+
+     assert(!cur_name_space_);
+
++    // Generate imports for the global scope in case no namespace is used
++    // in the schema file.
++    GenNamespaceImports(0);
++
+     // Generate all code in their namespaces, once, because Rust does not
+     // permit re-opening modules.
+     //","Let's manually create one extra whitespace line here (code_ += """")","I'd suggest moving this into a separate function, e.g. `G"
+9746,"@@ -138,6 +138,17 @@ func (bp *BucketPool) Count() uint64 {
+ 	return bp.total.count
+ }
+
++// Construct returns a copy of the bucket pool
++func (bp *BucketPool) Construct(enableSMStorage bool) *BucketPool {
++	pool := BucketPool{}
++	pool.enableSMStorage = enableSMStorage
++	pool.total = &totalAmount{
++		amount: new(big.Int).Set(bp.total.amount),
++		count:  bp.total.count,
++	}
++	return &pool
++}
++
+ // SyncPool sync the data from state manager
+ func (bp *BucketPool) SyncPool(sm protocol.StateManager) error {
+ 	if bp.enableSMStorage {",nit: copy or clone,Why do we need to copy here?
+9747,"@@ -182,3 +182,14 @@ func (d Document) Decode(dec Decoder) error {
+ 	}
+ 	return decodeStruct(d.s, dec)
+ }
++
++// RevisionOn returns whether or not we should write a revision value when we
++// write a document. It could be either a map or a struct with a revision key or
++// field named after revField.
++func (d Document) RevisionOn(revField string) bool {
++	if d.m != nil {
++		_, ok := d.m[revField]
++		return ok
++	}
++	return d.fields.MatchFold(revField) != nil
++}","I think this can be called `HasField`, because that's what it's doing. It really is independent of revision.",Is this used anywhere?
+9748,"@@ -16,7 +16,10 @@ import java.math.BigDecimal;
+ import java.time.Year;
+ import java.util.function.Predicate;
+
+-import static javaslang.API.*;
++import static javaslang.API.$;
++import static javaslang.API.Case;
++import static javaslang.API.Match;
++import static javaslang.API.run;
+ import static javaslang.MatchTest_DeveloperPatterns.Developer;
+ import static javaslang.Patterns.*;
+ import static javaslang.Predicates.*;",Is this to avoid collisions?,We don't use wildcard imports. Please revert this change.
+9749,"@@ -79,7 +79,7 @@ func MakeTransactionPool(ledger *ledger.Ledger, cfg config.Local) *TransactionPo
+ 		expiredTxCount:  make(map[basics.Round]int),
+ 		ledger:          ledger,
+ 		statusCache:     makeStatusCache(cfg.TxPoolSize),
+-		logStats:        cfg.EnableAssembleStats,
++		logStats:        cfg.EnableProcessBlockStats,
+ 		expFeeFactor:    cfg.TxPoolExponentialIncreaseFactor,
+ 		txPoolMaxSize:   cfg.TxPoolSize,
+ 	}","nit: a better name for this variable would be enableLogStats, but it's beyond the scope of your change.","I think this is the wrong place for this, it should be `E"
+9750,"@@ -256,7 +256,6 @@ class CheckerTestCase(object):
+ # Init
+ test_reporter = TestReporter()
+ linter = PyLinter(pylint.config.Configuration())
+-linter.set_reporter(test_reporter)
+ linter.config.persistent = 0
+ checkers.initialize(PluginRegistry(linter))
+ ","Because linters don't handle reports now, this was breaking the setup for _all_ tests. I deleted it so I could run my tests, but I didn't check the impact on other tests as many tests are failing at the moment.","`pylint` automatically detects `set_reporter`, so this re"
+9751,"@@ -138,6 +138,12 @@ func main() {
+ 		updateCommand,
+ 	}
+ 	app.Before = func(context *cli.Context) error {
++
++		// do nothing if logrus was already initialized in init.go
++		if logrus.StandardLogger().Out != logrus.New().Out {
++			return nil
++		}
++
+ 		if context.GlobalBool(""debug"") {
+ 			logrus.SetLevel(logrus.DebugLevel)
+ 		}",I'm not really a fan of this -- why not set up logging for `init` here (or setting a global flag) rather than doing it this way?,Do nothing if logrus was already initialized in init.go?
+9752,"@@ -1,4 +1,14 @@
+-/* global axe */
++/**
++ * Namespace `axe.imports` which holds required external dependencies
++ *
++ * @namespace imports
++ * @memberof axe
++ */
++export { default as axios } from 'axios';
++export { CssSelectorParser } from 'css-selector-parser';
++export { default as doT } from '@deque/dot';
++export { default as emojiRegexText } from 'emoji-regex';
++export { default as memoizee } from 'memoizee';
+
+ /**
+  * Note:",This is my favorite part of this PR. Being able to `import` 3rd party tools will hugely improve our workflows. :heart:,You don't need a new line here.
+9753,"@@ -0,0 +1,19 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.multithreading;
++
++import java.security.MessageDigest;
++
++/**
++ * Using a MessageDigest which is static can cause
++ * unexpected results when used in a multi-threaded environment. This rule will
++ * find static MessageDigest which are used in an unsynchronized manner.
++ */
++public class UnsynchronizedStaticMessageDigestRule extends UnsynchronizedStaticFormatterRule {
++
++    public UnsynchronizedStaticMessageDigestRule() {
++        super(MessageDigest.class);
++    }
++}","having this extend `UnsynchronizedStaticFormatterRule` seems semantically incorrect even if it works  we should probably refactor `UnsynchronizedStaticFormatterRule` into a `UnsynchronizedStaticAccessRule` which can be configured through properties to track unsynchronized static access to any given types (with proper defaults to include `Formatter` and `MessageDigest`). This will also scale better as new types are suggested to have a thread-safe access enforced. The `UnsynchronizedStaticFormatterRule` can be marked as deprecated at the ruleset level, point to the new implementation, overriding the property defaults to keep just looking for `Formatter`. Moreover, the `THREAD_SAFE_FORMATTER` static should probably be replaced with a property of thread-safe classes to ignore, once again with proper defaults.",I don't think we need this rule
+9754,"@@ -126,6 +126,8 @@ namespace Nethermind.Synchronization.ParallelSync
+         }
+
+         public long FindBestHeader() => _blockTree.BestSuggestedHeader?.Number ?? 0;
++
++        public Keccak FindBestHeaderHash() => _blockTree.BestSuggestedHeader?.Hash ?? Keccak.Zero;
+
+         public long FindBestFullBlock() => Math.Min(FindBestHeader(), _blockTree.BestSuggestedBody?.Number ?? 0); // avoiding any potential concurrency issue
+ ",Keccak.Zero should not be used to mean null,Wouldn't it be better to return
+9755,"@@ -40,5 +40,12 @@ namespace OpenTelemetry.Metrics.Tests
+                     new object[] { ""my_metric2"" },
+                     new object[] { new string('m', 63) },
+            };
++
++        public static IEnumerable<object[]> InvalidHistogramBounds
++           => new List<object[]>
++           {
++                    new object[] { new double[] { 0, 0 } },
++                    new object[] { new double[] { 1, 0 } },
++           };
+     }
+ }",perhaps add a couple more edge cases.,why is this a list?
+9756,"@@ -4,11 +4,15 @@ package Example
+
+ import ""strconv""
+
++/// Composite components of Monster color.
+ type Color byte
+
+ const (
+ 	ColorRed   Color = 1
++	/// \brief color Green
++	/// Green is bit_flag with value (1u << 1)
+ 	ColorGreen Color = 2
++	/// \brief color Blue (1u << 3)
+ 	ColorBlue  Color = 8
+ )
+ ","Is this blank line needed, or typo?","This is a bit confusing. What is ""bit_flag with value""?"
+9757,"@@ -122,12 +122,6 @@ func (p *blockPrefetcher) run() {
+ func (p *blockPrefetcher) request(priority int, kmd KeyMetadata,
+ 	ptr BlockPointer, block Block, entryName string,
+ 	doneCh, errCh chan<- struct{}) error {
+-	if _, err := p.config.BlockCache().Get(ptr); err == nil {
+-		return nil
+-	}
+-	if err := checkDataVersion(p.config, path{}, ptr); err != nil {
+-		return err
+-	}
+ 	select {
+ 	case p.progressCh <- prefetchRequest{
+ 		priority, kmd, ptr, block, doneCh, errCh}:",This was a major PitA to find: it was causing some huge goroutine leaks and unfinished prefetches.,why remove this?
+9758,"@@ -84,10 +84,8 @@ module Mongoid #:nodoc
+       #
+       # @since 2.1.8
+       def prohibited_methods
+-        @prohibited_methods ||= MODULES.inject([]) do |methods, mod|
+-          methods.tap do |mets|
+-            mets << mod.instance_methods.map{ |m| m.to_sym }
+-          end
++        @prohibited_methods ||= MODULES.map do |mod|
++          mod.instance_methods.map{ |m| m.to_sym }
+         end.flatten
+       end
+     end",you can use Enum#flat_map here.,Rails/DynamicFindFindBy: Use find_by instead of dynamic
+9759,"@@ -155,6 +155,7 @@ public class AbstractVmNode extends AbstractNode implements VmNode {
+      */
+     @Deprecated
+     public void dump(final String prefix, final boolean recurse, final Writer writer) {
++        @SuppressWarnings(""PMD.CloseResource"")
+         final PrintWriter printWriter = writer instanceof PrintWriter ? (PrintWriter) writer : new PrintWriter(writer);
+         printWriter.println(toString(prefix));
+         if (children != null && recurse) {","Same potential FP: The stream is provided from outside (here as a method parameter), so we should not be responsible here to close it, should we?","Similarly, I'm not sure why `writer` is a `PrintWriter`"
+9760,"@@ -26,11 +26,12 @@ Upcase::Application.configure do
+   config.log_level = :info
+   config.log_formatter = ::Logger::Formatter.new
+
+-  config.middleware.use \
+-    Rack::SslEnforcer,
+-    hsts: false,
+-    strict: true,
+-    redirect_to: ""https://#{ENV[""APP_DOMAIN""]}""
++  config.force_ssl = true
++  config.middleware.insert_before(
++    ActionDispatch::SSL,
++    Rack::CanonicalHost,
++    ENV.fetch(""APP_DOMAIN""),
++  )
+
+   config.action_mailer.delivery_method = :smtp
+   config.action_mailer.smtp_settings = MAIL_SETTINGS",Put a comma after the last parameter of a multiline method call.,My only suggestion would be to use `Rack::CanonicalHost` here instead of hardcoding `APP_DOMAIN`.
+9761,"@@ -67,10 +67,8 @@ public class VerbsManager {
+                 output -> {
+                     final Value verbClass = (Value) output;
+
+-                    final Verb verb = verbClass.newInstance().as(Verb.class);
+-
+                     try {
+-                        verb.install(container);
++                        verbClass.invokeMember(""install"", container);
+                     } catch (ScriptException se) {
+                         errorCallback.accept(se);
+                     }",It seems like this is the only way to access javascript `static` methods from Java.,nit: Why not directly call `install` on the `verbClass` instead of making it a method?
+9762,"@@ -4,8 +4,6 @@
+  * A temporary workaround to ensure the same version of React
+  * is always used across multiple entrypoints.
+  *
+- * @private
+- *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");",Why was this removed here?,Why did you change the visibility?
+9763,"@@ -4,12 +4,6 @@
+
+ package pslice
+
+-import ""github.com/ethersphere/bee/pkg/swarm""
+-
+-func PSlicePeers(p *PSlice) []swarm.Address {
+-	return p.peers
+-}
+-
+ func PSliceBins(p *PSlice) []uint {
+ 	return p.bins
+ }","i am aware that you did not add these, but might i ask why we need these one-liner funcs instead of just exporting the struct fields in the first place?",why remove this?
+9764,"@@ -296,7 +296,7 @@ abstract class BaseTableScan implements TableScan {
+       }
+       requiredFieldIds.addAll(selectedIds);
+
+-      return TypeUtil.select(schema, requiredFieldIds);
++      return TypeUtil.project(schema, requiredFieldIds);
+
+     } else if (context.projectedSchema() != null) {
+       return context.projectedSchema();",I agree with this because it is the opposite of `GetProjectedIds` used above.,What's the difference between `select` and `project` here? Why not just use `project`?
+9765,"@@ -632,7 +632,7 @@ class InstanceAttribute(dict):
+                    'disableApiTermination',
+                    'instanceInitiatedShutdownBehavior',
+                    'rootDeviceName', 'blockDeviceMapping', 'sourceDestCheck',
+-                   'groupSet']
++                   'groupSet', 'productCodes', 'ebsOptimized',]
+
+     def __init__(self, parent=None):
+         dict.__init__(self)",add 'sriovNetSupport' also to this list,Should we create a module level constant for this?
+9766,"@@ -61,7 +61,9 @@ public class Preferences {
+         }
+         if ((newAccount != null) && newAccount.getAccountNumber() != -1) {
+             accounts.put(newAccount.getUuid(), newAccount);
+-            accountsInOrder.add(newAccount);
++            if (!accountsInOrder.contains(newAccount)) {
++                accountsInOrder.add(newAccount);
++            }
+             newAccount = null;
+         }
+     }",Code style issue: `if` body is not wrapped in braces.,Any reason why this is not a `Lists.contains()`?
+9767,"@@ -81,9 +81,8 @@ public class ItunesSearchFragment extends Fragment {
+         if (result != null && result.size() > 0) {
+             gridView.setVisibility(View.VISIBLE);
+             txtvEmpty.setVisibility(View.GONE);
+-            for (Podcast p : result) {
+-                adapter.add(p);
+-            }
++
++            adapter.addAll(result);
+             adapter.notifyDataSetInvalidated();
+         } else {
+             gridView.setVisibility(View.GONE);",Call requires API level 11 (we are on 10),The problem here with the old code is that `addAll` will iterate over each element of
+9768,"@@ -97,7 +97,7 @@ namespace Nethermind.AuRa.Test.Contract
+                 var gasLimitContract = new BlockGasLimitContract(new AbiEncoder(), blockGasLimitContractTransition.Value, blockGasLimitContractTransition.Key,
+                     new ReadOnlyTxProcessingEnv(
+                         DbProvider,
+-                        new TrieStore(DbProvider.StateDb, LimboLogs.Instance),
++                        new TrieStore(DbProvider.StateDb, LimboLogs.Instance).AsReadOnly(DbProvider.StateDb),
+                         BlockTree, SpecProvider, LimboLogs.Instance));
+
+                 GasLimitOverrideCache = new AuRaContractGasLimitOverride.Cache();",do we need to pass the DB if it is the same,What is the benefit of this change? Is there a significant performance impact?
+9769,"@@ -300,6 +300,14 @@ func (ccs *crChains) addOp(ptr BlockPointer, op op) error {
+ }
+
+ func (ccs *crChains) makeChainForOp(op op) error {
++	// Ignore gc ops -- their unref semantics differ from the other
++	// ops.  Note that this only matters for old gcOps: new gcOps
++	// only unref the block ID, and not the whole pointer, so they
++	// wouldn't confuse chain creation.
++	if _, isGCOp := op.(*gcOp); isGCOp {
++		return nil
++	}
++
+ 	// First set the pointers for all updates, and track what's been
+ 	// created and destroyed.
+ 	for _, update := range op.AllUpdates() {",Might be a good idea to rename the variable so it doesn't shadow the type.,"Hmm... if we can't do better than this, maybe we should log an error and retur"
+9770,"@@ -14,7 +14,13 @@ class Tag extends BaseItem {
+ 	}
+
+ 	static async noteIds(tagId) {
+-		const rows = await this.db().selectAll('SELECT note_id FROM note_tags WHERE tag_id = ?', [tagId]);
++		// Get NoteIds of that are tagged with current tag or its descendants
++		const rows = await this.db().selectAll(`WITH RECURSIVE
++												parent_of(id, child_id) AS
++												(SELECT id, id FROM tags where id=?
++												UNION ALL
++												SELECT parent_of.id, tags2.id FROM parent_of JOIN tags AS tags2 ON parent_of.child_id=tags2.parent_id)
++												SELECT note_id FROM note_tags WHERE tag_id IN (SELECT child_id from parent_of)`, [tagId]);
+ 		const output = [];
+ 		for (let i = 0; i < rows.length; i++) {
+ 			output.push(rows[i].note_id);",Again I'd prefer if this is done in JavaScript rather than in SQL.,I think we need to filter tags by tag_id in `WHERE tags2.id IS NULL`
+9771,"@@ -1848,7 +1848,7 @@ function fullyResolveKeys(obj) {
+  * If there are no listeners registered with the flow, the error will be
+  * rethrown to the global error handler.
+  *
+- * Refer to the {@link ./promise} module documentation fora  detailed
++ * Refer to the {@link ./promise} module documentation for a  detailed
+  * explanation of how the ControlFlow coordinates task execution.
+  *
+  * @final",there is still `2` spaces after `a` here.. :P,unnecessary whitespace change
+9772,"@@ -25,6 +25,17 @@ import (
+
+ const defaultMountFlags = syscall.MS_NOEXEC | syscall.MS_NOSUID | syscall.MS_NODEV
+
++// setupDev returns true if /dev needs to be set up.
++func needsSetupDev(config *configs.Config) (bool, error) {
++	setupDev := true
++	for _, m := range config.Mounts {
++		if m.Device == ""bind"" && m.Destination == ""/dev"" {
++			setupDev = false
++		}
++	}
++	return setupDev, nil
++}
++
+ // setupRootfs sets up the devices, mount points, and filesystems for use inside a
+ // new mount namespace.
+ func setupRootfs(config *configs.Config, console *linuxConsole, pipe io.ReadWriter) (err error) {","What we did in docker before, when working directly with libcontainer, is check if the source is `/dev` and the destination has a `/dev/` prefix. This implementation is probably ok. If someone is mounting their own `/dev` I would expect it to be pre-configured and not need the extra check for if it's the host's `/dev`. (that said, I've not tested yet, just reading through the code)",It probably makes sense to move this to `pkg/util/mount` since it's used in both `mount.go` and `lib/mount.go`.
+9773,"@@ -501,6 +501,10 @@ type Configuration struct {
+ 	PleaseLocation string
+ 	// buildEnvStored is a cached form of BuildEnv.
+ 	buildEnvStored *storedBuildEnv
++
++	FeatureFlags struct {
++		JavaBinaryExecutableByDefault bool `help:""Makes java_binary rules self executable by default. Target release version 16."" var:""FF_JAVA_SELF_EXEC""`
++	}
+ }
+
+ // An Alias represents aliases in the config.","you should add some help on the struct too so that `plz halp featureflags` has a bit of explanation. Might be worth mentioning that these generally won't remain around very long relative to other config options (i.e. they're typically enabling ""preview"" features for the next major).",I think we should drop this flag altogether. We don't want people to depend on this by default.
+9774,"@@ -302,7 +302,7 @@ func newSessionManagerFactory(
+ 	nodeOptions node.Options,
+ ) session.ManagerFactory {
+ 	return func(dialog communication.Dialog) *session.Manager {
+-		providerBalanceTrackerFactory := func(consumer, provider, issuer identity.Identity) (session.BalanceTracker, error) {
++		providerBalanceTrackerFactory := func(consumer, receiver, issuer identity.Identity) (session.BalanceTracker, error) {
+ 			// if the flag ain't set, just return a noop balance tracker
+ 			if !nodeOptions.ExperimentPayments {
+ 				return payments_noop.NewSessionBalance(), nil","Maybe `consumerID, receiverID, issuerID`, at least it's a convension in overal repo",receiver is the name of this function.
+9775,"@@ -14,6 +14,12 @@
+
+ // Package s3blob provides an implementation of blob using S3.
+ //
++// For blob.Open URLs, s3blob registers for the ""s3"" protocol.
++// The URL's Host is used as the bucket name.
++// The following query options are supported:
++// - region: The AWS region for requests.
++// Example URL: blob.Open(""s3://mybucket?region=us-east-1"")
++//
+ // It exposes the following types for As:
+ // Bucket: *s3.S3
+ // ListObject: s3.Object for objects, s3.CommonPrefix for ""directories"".",Where does the auth go?,Should we support `s3://mybucket?region=us-east-1` also?
+9776,"@@ -119,7 +119,10 @@ func ClassifyActions(actions []SealedEnvelope) ([]*Transfer, []*Execution) {
+ }
+
+ func calculateIntrinsicGas(baseIntrinsicGas uint64, payloadGas uint64, payloadSize uint64) (uint64, error) {
+-	if payloadGas == 0 || (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize {
++	if payloadGas == 0 {
++		return 0, ErrUnderpriced
++	}
++	if (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize {
+ 		return 0, ErrInsufficientFunds
+ 	}
+ 	return payloadSize*payloadGas + baseIntrinsicGas, nil","0 < minimum gas price, `ErrUnderpriced` is more proper","payloadGas is a uint64, so it should just be uint64"
+9777,"@@ -12,7 +12,7 @@ from sqlalchemy import func
+ from . import app, db
+ from .const import (VALID_EMAIL_RE, VALID_USERNAME_RE, blacklisted_name,
+                     ACTIVATE_SALT, PASSWORD_RESET_SALT, MAX_LINK_AGE,
+-                    CODE_EXP_MINUTES)
++                    CODE_EXP_MINUTES, TOKEN_EXP_DEFAULT)
+ from .mail import (send_activation_email, send_reset_email, send_new_user_email,
+                    send_welcome_email)
+ from .models import ActivationToken, Code, PasswordResetToken, Token, User",these should be alphabetized,I would also rename `TOKEN_EXP_DEFAULT` to `HUBIT_E
+9778,"@@ -72,7 +72,7 @@ public class VectorizedDictionaryEncodedParquetValuesReader extends BaseVectoriz
+   }
+
+   void readBatchOfDictionaryEncodedLongs(FieldVector vector, int startOffset, int numValuesToRead, Dictionary dict,
+-                                         NullabilityHolder nullabilityHolder) {
++                                         NullabilityHolder nullabilityHolder, int typeWidth) {
+     int left = numValuesToRead;
+     int idx = startOffset;
+     while (left > 0) {","These changes look concerning. It looks like the old offset (only index) must not have been correct. If so, there are places where `getDataBuffer().setLong(...)` and similar methods are called but aren't updated like these. Are those cases bugs as well?",Could you remove the `typeWidth` parameter from thi
+9779,"@@ -164,7 +164,7 @@ type Counters struct {
+
+ // flush writes the current state of in memory counters into the given db.
+ func (cs *Counters) flush(db *shed.DB, batch *leveldb.Batch) error {
+-	if cs.dirty.Load() > 1 {
++	if cs.dirty.Load() < 3 {
+ 		return nil
+ 	}
+ 	cs.dirty.CAS(3, 2)",the CAS call here is now wrong since dirty will never be 3 anymore. it might be useful to sweep through the entire usage of this field to see that everything is correct,Why did this change?
+9780,"@@ -18,7 +18,11 @@ use Symfony\Component\Validator\Constraints\NotBlank;
+ use Symfony\Component\Validator\Constraints\NotEqualTo;
+ use Symfony\Component\Validator\ExecutionContextInterface;
+ use Thelia\Core\Translation\Translator;
++use Thelia\Model\Base\CountryQuery;
+ use Thelia\Model\Base\LangQuery;
++use Thelia\Model\Base\ModuleQuery;
++use Thelia\Model\Module;
++use Thelia\Module\BaseModule;
+
+ /**
+  * Allow to build a form Coupon",Base model is imported here,Shouldn't these be `use` statements?
+9781,"@@ -16,6 +16,7 @@
+  */
+ package org.apache.servicecomb.serviceregistry.task;
+
++import org.apache.servicecomb.foundation.common.event.EventManager;
+ import org.apache.servicecomb.serviceregistry.RegistryUtils;
+ import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
+ import org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;",import but not used,This import does not appear to be us
+9782,"@@ -193,7 +193,7 @@ public final class VectorizedParquetDefinitionLevelReader extends BaseVectorized
+         case RLE:
+           if (currentValue == maxDefLevel) {
+             dictionaryEncodedValuesReader.readBatchOfDictionaryEncodedLongs(vector,
+-                idx, numValues, dict, nullabilityHolder);
++                idx, numValues, dict, nullabilityHolder, typeWidth);
+           } else {
+             setNulls(nullabilityHolder, idx, numValues, validityBuffer);
+           }",What about the call in `case PACKED` just below? Does that also need to use the `typeWidth`?,@Scottmitch why do you pass `typeWid
+9783,"@@ -8,13 +8,14 @@ import (
+ 	""errors""
+
+ 	""github.com/ethersphere/bee/pkg/collection""
++	""github.com/ethersphere/bee/pkg/encryption""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ )
+
+ var (
+ 	_                           = collection.Entry(&Entry{})
+ 	serializedDataSize          = swarm.SectionSize * 2
+-	encryptedSerializedDataSize = swarm.EncryptedReferenceSize * 2
++	encryptedSerializedDataSize = encryption.ReferenceSize * 2
+ )
+
+ // Entry provides addition of metadata to a data reference.",not sure i like this change. The encryption package does not need to know about references,Could we move this to `pkg/encryptio
+9784,"@@ -280,6 +280,7 @@ ifneq ($(MAKECMDGOALS),clean)
+   ifeq ($(llvm_version),3.9.1)
+   else ifeq ($(llvm_version),5.0.2)
+   else ifeq ($(llvm_version),6.0.1)
++  else ifeq ($(llvm_version),7.0.0) # this is what is shipped with ubuntu bionic llvm-7 package right now
+   else ifeq ($(llvm_version),7.0.1)
+   else
+     $(warning WARNING: Unsupported LLVM version: $(llvm_version))","This shouldn't be added. It's not supported. It's not event the default. If we are going to support this, we need to have CI for it.",shouldn't this be 7.0.1?
+9785,"@@ -6,6 +6,5 @@ type API interface {
+ 	Client() Client
+ 	Daemon() Daemon
+ 	Ping() Ping
+-	RetrievalClient() RetrievalClient
+ 	Swarm() Swarm
+ }",omg only four left!!!!,@efiop I'm not sure if t
+9786,"@@ -214,6 +214,12 @@ func (c *Client) InstallParticipationKeys(inputfile string) (part account.Partic
+ 		return
+ 	}
+
++	proto, ok := config.Consensus[protocol.ConsensusCurrentVersion]
++	if !ok {
++		err = fmt.Errorf(""Unknown consensus protocol %s"", protocol.ConsensusCurrentVersion)
++		return
++	}
++
+ 	// After successful install, remove the input copy of the
+ 	// partkey so that old keys cannot be recovered after they
+ 	// are used by algod.  We try to delete the data inside","I'm not really sure how this would happen. once the binary is already compiled, the config.Consensus should already have the entry for protocol.ConsensusCurrentVersion.","no need to return here, "
+9787,"@@ -160,7 +160,7 @@ class LuigiTestCase(unittest.TestCase):
+         temp = CmdlineParser._instance
+         try:
+             CmdlineParser._instance = None
+-            run_exit_status = luigi.run(['--local-scheduler', '--no-lock'] + args)
++            run_exit_status = luigi.run(args + ['--local-scheduler', '--no-lock'])
+         finally:
+             CmdlineParser._instance = temp
+         return run_exit_status",Is there a reason for the order swap here?,was this broken before?
+9788,"@@ -241,8 +241,9 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting
+                 }
+             }
+
+-            EqtTrace.Error(""Unable to find path for dotnet host"");
+-            return dotnetExeName;
++            string errorMessage = String.Format(Resources.NoDotnetDotExeFileExist, dotnetExeName);
++            EqtTrace.Error(errorMessage);
++            throw new FileNotFoundException(errorMessage);
+         }
+
+         private string GetTestHostPath(string runtimeConfigDevPath, string depsFilePath, string sourceDirectory)",Where will this exception get caught ?,I'm not sure how I feel about this being logged as an error. What do you think about just logging the error before the call to `GetTestHostPath`?
+9789,"@@ -49,9 +49,10 @@ var mainEtherAccPass = ""localaccount""
+ type CliWallet struct {
+ 	txOpts           *bind.TransactOpts
+ 	Owner            common.Address
+-	backend          *ethclient.Client
++	Backend          *ethclient.Client
+ 	identityRegistry registry.IdentityRegistryTransactorSession
+ 	tokens           mysttoken.MystTokenTransactorSession
++	KS               *keystore.KeyStore
+ }
+
+ // RegisterIdentity registers identity with given data on behalf of user",Why this field is made public?,"not sure if this is the right place for this, maybe `keystore`?"
+9790,"@@ -35,16 +35,16 @@
+ #include ""proj_internal.h""
+ #include ""proj_internal.h""
+
+-static int is_nodata(float value)
++static int is_nodata(float value, double vmultiplier)
+ {
+     /* nodata?  */
+     /* GTX official nodata value if  -88.88880f, but some grids also */
+     /* use other  big values for nodata (e.g naptrans2008.gtx has */
+     /* nodata values like -2147479936), so test them too */
+-    return value > 1000 || value < -1000 || value == -88.88880f;
++    return value * vmultiplier > 1000 || value * vmultiplier < -1000 || value == -88.88880f;
+ }
+
+-static double read_vgrid_value( PJ *defn, PJ_LP input, int *gridlist_count_p, PJ_GRIDINFO **tables, struct CTABLE *ct) {
++static double read_vgrid_value( PJ *defn, PJ_LP input, double vmultiplier, int *gridlist_count_p, PJ_GRIDINFO **tables, struct CTABLE *ct) {
+     int  itable = 0;
+     double value = HUGE_VAL;
+     double grid_x, grid_y;",Is the `vmultiplier` only used here for checking if a grid value is nodata?,"for readability, better to use `static inline double read_vgrid_value(const PJ_VALUE value, double vmultiplier)`"
+9791,"@@ -239,7 +239,7 @@ func signTestCert(key crypto.Signer) *x509.Certificate {
+ 		SerialNumber:          serialNumber,
+ 		SignatureAlgorithm:    x509.SHA256WithRSA,
+ 		Subject: pkix.Name{
+-			Organization: []string{defaultOrganization},
++			Organization: []string{""cert-manager""},
+ 			CommonName:   commonName,
+ 		},
+ 		NotBefore: time.Now(),","Is this deliberate? If so, why?",What was the reason for this change?
+9792,"@@ -5,7 +5,7 @@ from mitmproxy import exceptions
+ from mitmproxy.net import tls as net_tls
+ from mitmproxy.proxy.protocol import base
+
+-# taken from https://testssl.sh/openssl-rfc.mappping.html
++# taken from https://testssl.sh/openssl-rfc.mapping.html
+ CIPHER_ID_NAME_MAP = {
+     0x00: 'NULL-MD5',
+     0x01: 'NULL-MD5',",both URL works. I corrected it anyway.,Was this change intended?
+9793,"@@ -43,12 +43,14 @@ import java.util.Collection;
+  * @since 5.0
+  */
+ public class PrePostAdviceReactiveMethodInterceptor implements MethodInterceptor {
+-	private Authentication anonymous = new AnonymousAuthenticationToken(""key"", ""anonymous"",
+-		AuthorityUtils.createAuthorityList(""ROLE_ANONYMOUS""));
++	private final Authentication anonymous = new AnonymousAuthenticationToken(""key"", ""anonymous"",
++			AuthorityUtils.createAuthorityList(""ROLE_ANONYMOUS""));
+
+ 	private final MethodSecurityMetadataSource attributeSource;
+
+-	private final PreInvocationAuthorizationAdvice preInvocationAdvice;
++	private PreInvocationAuthorizationAdvice preInvocationAdvice;
++
++	private PreInvocationAuthorizationReactiveAdvice preInvocationReactiveAdvice;
+
+ 	private final PostInvocationAuthorizationAdvice postAdvice;
+ ","Rather than have another member and and if/else statement, if the user passes in `PreInvocationAuthorizationAdvice` it could be adapted to match `PreInvocationAuthorizationReactiveAdvice`",`PrePostAdviceReactiveMet
+9794,"@@ -210,8 +210,7 @@ class Sync {
+     /**
+      * A callback passed to `Realm.App.Sync.setLogger` when instrumenting the Realm Sync client with a custom logger.
+      * @callback Realm.App.Sync~logCallback
+-     * @param {number} level The level of the log entry between 0 and 8 inclusively.
+-     * Use this as an index into `['all', 'trace', 'debug', 'detail', 'info', 'warn', 'error', 'fatal', 'off']` to get the name of the level.
++     * @param {string} level The level of the log which can be ['all', 'trace', 'debug', 'detail', 'info', 'warn', 'error', 'fatal', 'off'].
+      * @param {string} message The message of the log entry.
+      */
+ ",The callback get the log level as a number.,This should be a `number`
+9795,"@@ -71,6 +71,7 @@ setup(
+         ""hyperframe>=5.0, <6"",
+         ""jsbeautifier>=1.6.3, <1.7"",
+         ""kaitaistruct>=0.7, <0.8"",
++        ""ldap3>=2.2.0, <2.2.1"",
+         ""passlib>=1.6.5, <1.8"",
+         ""pyasn1>=0.1.9, <0.3"",
+         ""pyOpenSSL>=16.0, <17.1"",",Is there any issue with 2.2.3? If not this should be `<2.3`.  ,I don't think we should h
+9796,"@@ -1595,7 +1595,3 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         # Only support for MultiIndex
+         kser = ks.Series([10, -2, 4, 7])
+         self.assertRaises(ValueError, lambda: kser.unstack())
+-
+-    def test_item(self):
+-        kser = ks.Series([10, 20])
+-        self.assertRaises(ValueError, lambda: kser.item())",Shall we keep this test?,Was this deleted accidentally?
+9797,"@@ -102,12 +102,15 @@ class Tx_Solr_Backend_IndexingConfigurationSelectorField {
+ 	/**
+ 	 * Renders a field to select which indexing configurations to initialize.
+ 	 *
+-	 * Uses TCEforms.
++	 * Uses \TYPO3\CMS\Backend\Form\FormEngine.
+ 	 *
+ 	 *  @return string Markup for the select field
+ 	 */
+ 	public function render() {
+-		$tceForm = t3lib_div::makeInstance('t3lib_TCEforms');
++		$selectFieldRenderer = $formEngine = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Backend\\Form\\FormEngine');
++		if (class_exists('TYPO3\\CMS\Backend\\Form\\Element\\SelectElement')) {
++			$selectFieldRenderer = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\Backend\\Form\\Element\\SelectElement', $formEngine);
++		}
+
+ 			// transform selected values into the format used by TCEforms
+ 		$selectedValues = array();","When would this be the case? / When would SelectElement not be available? Is this change compatible with 6.2? (I'd like to roll a release that works with 6.2+ first, before moving on to 7.x)",Why didn't you use the `use` s
+9798,"@@ -257,6 +257,10 @@ public abstract class DataType implements Serializable {
+         + ((long) (readBuffer[7] & 255) << 56));
+   }
+
++  public boolean isSameCatalog(DataType other) {
++    return false;
++  }
++
+   // all data should be read in little endian.
+   public TiChunkColumnVector decodeChunkColumn(CodecDataInput cdi) {
+     int numRows = readIntLittleEndian(cdi);",how about rename to shouldNarrowDataTypeTo?,why is this needed?
+9799,"@@ -33,6 +33,9 @@ from .util import bokeh_version
+
+ Store.renderers['bokeh'] = BokehRenderer.instance()
+
++if len(Store.renderers) == 1:
++    Store.current_backend = 'bokeh'
++
+ associations = {Overlay: OverlayPlot,
+                 NdOverlay: OverlayPlot,
+                 GridSpace: GridPlot,",Why not check that the one available renderer is 'bokeh'?,Shouldn't this be handled by `
+9800,"@@ -28,3 +28,6 @@ var ErrIncomplete = errors.New(""incomplete config"")
+
+ // ErrNotReady is the error when a broker is not ready.
+ var ErrNotReady = errors.New(""not ready"")
++
++// ErrOverflow is the error when a broker ingress is sending too many requests to PubSub.
++var ErrOverflow = errors.New(""bundler reached buffered byte limit"")",Can you import `bundler.ErrOverflow` rather than redefine it here?,Do we want this to be public?
+9801,"@@ -305,7 +305,7 @@ public abstract class FlatteningConfig {
+       }
+
+       ResourceNameTreatment resourceNameTreatment = ResourceNameTreatment.NONE;
+-      String resourceNameType = protoParser.getResourceType(parameterField.getProtoField());
++      String resourceNameType = protoParser.getResourceReference(parameterField.getProtoField());
+       if (!Strings.isNullOrEmpty(resourceNameType)) {
+         resourceNameTreatment = ResourceNameTreatment.STATIC_TYPES;
+       }",This is just a renaming of the function getResourceType() to getResourceReference(),this looks like a typo. Shoul
+9802,"@@ -106,7 +106,7 @@ module Beaker
+       ip = ''
+       if File.file?(@vagrant_file) #we should have a vagrant file available to us for reading
+         f = File.read(@vagrant_file)
+-        m = /#{hostname}.*?ip:\s*('|"")\s*([^'""]+)('|"")/m.match(f)
++        m = /'#{hostname}'.*?ip:\s*('|"")\s*([^'""]+)('|"")/m.match(f)
+         if m
+           ip = m[2]
+           @logger.debug(""Determined existing vagrant box #{hostname} ip to be: #{ip} "")","Seems like this might need to allow for `""`s to be used here?",Won't this regex fail if `f`
+9803,"@@ -295,8 +295,8 @@ CombatSpell::~CombatSpell()
+
+ bool CombatSpell::loadScriptCombat()
+ {
+-	combat = g_luaEnvironment.getCombatObject(g_luaEnvironment.lastCombatId);
+-	return combat != nullptr;
++	Combat_ptr combatPtr = g_luaEnvironment.getCombatObject(g_luaEnvironment.lastCombatId);
++	return combatPtr != nullptr;
+ }
+
+ bool CombatSpell::castSpell(Creature* creature)","here you assigning it to a local variable, in the original code it assigned to combat(CombatSpell member). Not sure if CombatSpell needs to use a shared_ptr since currently it does not and it works ""good"".",combatPtr != nullptr
+9804,"@@ -1,7 +1,5 @@
+ <section id=""terms"">
+   <dl>
+-    <dt><p>How often is this video tutorial offered?</p></dt>
+-    <dd><p>This online video tutorial starts as soon as you register.</p></dd>
+     <dt><p>What if I'm not happy?</p></dt>
+     <dd><p>If you&rsquo;re not happy, just let us know within 30 days and we&rsquo;ll refund your money. It&rsquo;s as simple as that.</p></dd>
+   </dl>","Should we also remove this? This applies to subscriptions in general, but it seems sort of weird in the context of products now.",Looks like there's an extra closing div here.
+9805,"@@ -27,7 +27,6 @@ from dagster.core.errors import DagsterExecutionInterruptedError, DagsterInvaria
+ from dagster.seven import IS_WINDOWS, multiprocessing
+ from dagster.seven.abc import Mapping
+
+-from .alert import make_email_on_pipeline_failure_sensor, make_email_on_run_failure_sensor
+ from .merger import merge_dicts
+ from .yaml_utils import load_yaml_from_glob_list, load_yaml_from_globs, load_yaml_from_path
+ ","I think we should keep these, o.w. our examples will be wrong (where we're importing from `dagster.utils`). Also, we might break folks who've imported following our docs.",Perhaps we should move `make_email_on_pipelin
+9806,"@@ -24,7 +24,7 @@ namespace OpenTelemetry.Trace
+     /// <summary>
+     /// Build TracerProvider with Resource, Sampler, Processors and Instrumentation.
+     /// </summary>
+-    internal class TracerProviderBuilderSdk : TracerProviderBuilder
++    public class TracerProviderBuilderSdk : TracerProviderBuilder
+     {
+         private readonly List<InstrumentationFactory> instrumentationFactories = new List<InstrumentationFactory>();
+         private readonly List<BaseProcessor<Activity>> processors = new List<BaseProcessor<Activity>>();",This is good and something that I think opens a lot of possibilities. I think what would be even better is to change up `TracerProviderSdk` to take factories for the processors just like it already does for the instrumentations. Should probably use use a factory for the sampler. If we made those 2 changes then we could actually split this all up into the config and the build phase and we could use the factory methods in the hosting version to call into the IServiceProvider to get those instances.,Can you make `TracerProviderBuilderSdk` publi
+9807,"@@ -48,9 +48,14 @@ func (t *Table) Normalize() {
+ 			if len(t.Data) > 0 {
+ 				t.KeyValues[j] = t.Data[0][idx]
+ 			}
+-			v := values.New(t.KeyValues[j])
+-			if v.Type() == semantic.Invalid {
+-				panic(fmt.Errorf(""invalid value: %s"", t.KeyValues[j]))
++			var v values.Value
++			if t.KeyValues[j] == nil {
++				v = values.NewNull(flux.SemanticType(t.ColMeta[idx].Type))
++			} else {
++				v = values.New(t.KeyValues[j])
++				if v.Type() == semantic.Invalid {
++					panic(fmt.Errorf(""invalid value: %s"", t.KeyValues[j]))
++				}
+ 			}
+ 			vs[j] = v
+ 		}",Is there a way to make it so `values.New(nil)` works instead of adding a new function?,would be nice to have a test case for this
+9808,"@@ -85,7 +85,11 @@ class ApiMediaType extends AbstractType
+      */
+     public function getParent()
+     {
+-        return 'sonata_media_api_form_doctrine_media';
++        // NEXT_MAJOR: Return 'Sonata\MediaBundle\Form\Type\ApiDoctrineMediaType'
++        // (when requirement of Symfony is >= 2.8)
++        return method_exists('Symfony\Component\Form\AbstractType', 'getBlockPrefix')
++            ? 'Sonata\MediaBundle\Form\Type\ApiDoctrineMediaType'
++            : 'sonata_media_api_form_doctrine_media';
+     }
+
+     /**",> when requirement of Symfony **will be** >= 2.8 Same for others.,Doesn't that belong to the 2.7 branch?
+9809,"@@ -104,7 +104,8 @@ PROJECT_IAM_ROLES_SERVER = [
+     'roles/storage.objectViewer',
+     'roles/storage.objectCreator',
+     'roles/cloudsql.client',
+-    'roles/logging.logWriter'
++    'roles/logging.logWriter',
++    'roles/iam.serviceAccountTokenCreator'
+ ]
+
+ PROJECT_IAM_ROLES_CLIENT = [",I'd like to see if this can just be set on the service account instead of the project. Using the SVC_ACCT_ROLES (which should otherwise be deleted as I don't think anything else is using it.),We need to remove the logWriter from h
+9810,"@@ -7,6 +7,7 @@ import android.content.Intent;
+ import android.content.SharedPreferences;
+ import android.content.res.Configuration;
+ import android.database.DataSetObserver;
++import android.graphics.Color;
+ import android.os.Build;
+ import android.os.Bundle;
+ import android.os.Handler;",Please remove the unused imports :),can you revert unrelated changes?
+9811,"@@ -82,11 +82,11 @@ ActiveRecord::Schema.define(version: 20140723160957) do
+   end
+
+   create_table ""comments"", force: true do |t|
++    t.text     ""comment_text""
+     t.datetime ""created_at""
+     t.datetime ""updated_at""
+-    t.string   ""commentable_type""
+     t.integer  ""commentable_id""
+-    t.text     ""comment_text""
++    t.string   ""commentable_type""
+   end
+
+   create_table ""properties"", force: true do |t|","Were these local edits? There doesn't appear to be a change here. If so, let's remove this from the commit.",Put these back in alphabetical order.
+9812,"@@ -3,8 +3,13 @@ package server
+ import (
+ 	""crypto/ecdsa""
+ 	""crypto/x509""
++	""github.com/spiffe/spire/pkg/common/profiling""
+ 	""net""
++	""net/http""
++	_ ""net/http/pprof""
+ 	""net/url""
++	""runtime""
++	""strconv""
+ 	""sync""
+ 	""syscall""
+ ",nit: this should be further down w/ the rest of the github imports,Please put this in a separate import block.
+9813,"@@ -2,7 +2,7 @@ Hi <%= @user.first_name %>,
+
+ This is a reminder that your Learn <%= @subscription.plan_name %> subscription
+ will be automatically renewed on <%= l @subscription.next_payment_on %> for the
+-amount of <%= number_to_currency(@subscription.next_payment_amount) %>.
++amount of <%= number_to_currency(@subscription.next_payment_amount / 100) %>.
+
+ If you need to make any changes, you can do so by accessing your account page at
+ <%= my_account_url %>","I don't know if this is something we should address now, but we have a cents_to_dollars private method in both `SubscriptionCoupon` and `Invoice`.",I don't think you want to do that if the am
+9814,"@@ -1619,7 +1619,9 @@ void ihipPrintKernelLaunch(const char* kernelName, const grid_launch_parm* lp,
+ // Allows runtime to track some information about the stream.
+ hipStream_t ihipPreLaunchKernel(hipStream_t stream, dim3 grid, dim3 block, grid_launch_parm* lp,
+                                 const char* kernelNameStr, bool lockAcquired) {
+-    stream = ihipSyncAndResolveStream(stream, lockAcquired);
++    if (stream == nullptr || stream != stream->getCtx()->_defaultStream){
++        stream = ihipSyncAndResolveStream(stream, lockAcquired);
++    }
+     lp->grid_dim.x = grid.x;
+     lp->grid_dim.y = grid.y;
+     lp->grid_dim.z = grid.z;",Formatting here and all below: missing space before open bracket for the compound statement.,space before {
+9815,"@@ -44,7 +44,6 @@ import org.junit.After;
+ import org.junit.Before;
+ import org.junit.BeforeClass;
+ import org.junit.Test;
+-import org.mortbay.util.ajax.JSON;
+
+ import static org.apache.solr.security.JWTAuthPlugin.JWTAuthenticationResponse.AuthCode.AUTZ_HEADER_PROBLEM;
+ import static org.apache.solr.security.JWTAuthPlugin.JWTAuthenticationResponse.AuthCode.NO_AUTZ_HEADER;",Avoid using old mortbay utilities for converting JSON. Uses existing Solr Utils to convert from JSON string.,This import should not be removed.
+9816,"@@ -0,0 +1,19 @@
++'use strict';
++
++const CommandOperationV2 = require('./command_v2');
++const defineAspects = require('./operation').defineAspects;
++const Aspect = require('./operation').Aspect;
++
++class CommandDirect extends CommandOperationV2 {
++  constructor(parent, command, options) {
++    super(parent, options);
++    this.command = command;
++  }
++  execute(server, callback) {
++    const command = this.command;
++    this.executeCommand(server, command, callback);
++  }
++}
++defineAspects(CommandDirect, [Aspect.EXECUTE_WITH_SELECTION]);
++
++module.exports = CommandDirect;","I actually think this wrapping is great, but let's call it `RunCommandOperation`?",The name `CommandDirect` looks weird to me. How about `CommandCommand`?
+9817,"@@ -122,11 +122,15 @@ func errorsParse(c *caddy.Controller) (*ErrorHandler, error) {
+ 				}
+ 				f.Close()
+
+-				whatInt, err := strconv.Atoi(what)
+-				if err != nil {
+-					return hadBlock, c.Err(""Expecting a numeric status code, got '"" + what + ""'"")
++				if what == ""*"" {
++					handler.GenericErrorPage = where
++				} else {
++					whatInt, err := strconv.Atoi(what)
++					if err != nil {
++						return hadBlock, c.Err(""Expecting a numeric status code or '*', got '"" + what + ""'"")
++					}
++					handler.ErrorPages[whatInt] = where
+ 				}
+-				handler.ErrorPages[whatInt] = where
+ 			}
+ 		}
+ 		return hadBlock, nil",Maybe it is better to add checking for status code duplications? It can prevent some stupid copy-paste user errors.,"I don't understand this change, I don't think that it's correct. You ar"
+9818,"@@ -5,14 +5,14 @@ describe Invoice do
+     invoices = Invoice.
+       find_all_by_stripe_customer_id(FakeStripe::CUSTOMER_ID)
+
+-    invoices.length.should eq 1
+-    invoices.first.stripe_invoice_id.should eq 'in_1s4JSgbcUaElzU'
++    expect(invoices.length).to eq 1
++    expect(invoices.first.stripe_invoice_id).to eq 'in_1s4JSgbcUaElzU'
+   end
+
+   it 'does not find invoices with a blank customer' do
+-    Invoice.find_all_by_stripe_customer_id(' ').length.should eq 0
+-    Invoice.find_all_by_stripe_customer_id('').length.should eq 0
+-    Invoice.find_all_by_stripe_customer_id(nil).length.should eq 0
++    expect(Invoice.find_all_by_stripe_customer_id(' ').length).to eq 0
++    expect(Invoice.find_all_by_stripe_customer_id('').length).to eq 0
++    expect(Invoice.find_all_by_stripe_customer_id(nil).length).to eq 0
+   end
+
+   describe 'invoice fields' do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [101/80]
+9819,"@@ -1823,6 +1823,9 @@ mangle_return(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+         IF_X64(ASSERT_TRUNCATE(val, int, opnd_get_immed_int(instr_get_src(instr, 0))));
+         /* addl sizeof_param_area, %xsp
+          * except that clobbers the flags, so we use lea */
++        /* XXX i#3307: unimplemented, we can only support simple mangling cases in
++         * mangling epilogue.
++         */
+         PRE(ilist, next_instr,
+             INSTR_CREATE_lea(dcontext, opnd_create_reg(REG_XSP),
+                              opnd_create_base_disp(REG_XSP, REG_NULL, 0, val, OPSZ_lea)));",This lea should match instr_check_xsp_mangling and be undone. I don't think i#3307 applies here.,Is this supposed to be committed?
+9820,"@@ -87,6 +87,11 @@ type Store struct {
+ 	tipIndex *TipIndex
+ }
+
++type ipldStateThing interface {
++	Get(ctx context.Context, c cid.Cid, out interface{}) error
++	Put(ctx context.Context, v interface{}) (cid.Cid, error)
++}
++
+ // NewStore constructs a new default store.
+ func NewStore(ds repo.Datastore, cst state.IpldStore, stl state.TreeLoader, genesisCid cid.Cid) *Store {
+ 	return &Store{","I like the idea of this being an interface as it makes the test setup a bit easier, thoughts?",Is this used anywhere?
+9821,"@@ -608,7 +608,8 @@ class ColdcardPlugin(HW_PluginBase):
+             pubkey_deriv_info = wallet.get_public_keys_with_deriv_info(address)
+             pubkey_hexes = sorted([pk.hex() for pk in list(pubkey_deriv_info)])
+             xfp_paths = []
+-            for pubkey in pubkey_deriv_info:
++            for pubkey_hex in pubkey_hexes:
++                pubkey = bytes.fromhex(pubkey_hex)
+                 ks, der_suffix = pubkey_deriv_info[pubkey]
+                 fp_bytes, der_full = ks.get_fp_and_derivation_to_be_used_in_partial_tx(der_suffix, only_der_suffix=False)
+                 xfp_int = xfp_int_from_xfp_bytes(fp_bytes)",Nit: I believe the electrum convention is to use `bfh` instead of `bytes.fromhex`. Great catch on this bug!,why are you using byte
+9822,"@@ -1910,7 +1910,10 @@ def _getPredictedField(options):
+       predictedFieldInfo = info
+       break
+
+-  assert predictedFieldInfo
++  if predictedFieldInfo is None:
++    raise Exception(
++      ""Predicted field '%s' does not exist in included fields."" % predictedField
++    )
+   predictedFieldType = predictedFieldInfo['fieldType']
+
+   return predictedField, predictedFieldType",Use a more granular error type. I would recommend `ValueError` in this case.,I think you can remove
+9823,"@@ -2699,6 +2699,9 @@ void Game::playerRequestTrade(uint32_t playerId, const Position& pos, uint8_t st
+ 		player->sendTextMessage(MSG_INFO_DESCR, ""You can not trade more than 100 items."");
+ 		return;
+ 	}
++	if (!g_events->eventPlayerOnTradeRequest(player,tradePartner,tradeItem)) {
++		return;
++	}
+
+ 	internalStartTrade(player, tradePartner, tradeItem);
+ }","A space after each argument, and an empty line above this if-statement.",Please move this to th
+9824,"@@ -27,8 +27,8 @@ export function memo(c, comparer) {
+ 		this.shouldComponentUpdate = shouldUpdate;
+ 		return createElement(c, props);
+ 	}
+-	Memoed.prototype.isReactComponent = true;
+ 	Memoed.displayName = 'Memo(' + (c.displayName || c.name) + ')';
++	Memoed.prototype.isReactComponent = true;
+ 	Memoed._forwarded = true;
+ 	return Memoed;
+ }","Things like this make me wonder whether we should ship a ""development"" and a ""production"" version. I remember the discussions about making things more complex bundling wise but couldn't we omit this line in a ""production"" or ""minimal"" variant of our build? That would save us some bytes here and there. Or are we somehow able to move this line to debug? I though about monkey patching the exported function but that only works in CJS and not ESM AFAIK.",Not needed anymore?
+9825,"@@ -6,6 +6,8 @@ namespace Datadog.Trace
+
+         Scope Activate(Span span, bool finishOnClose);
+
++        void AddScopeListener(IScopeListener listener);
++
+         void Close(Scope scope);
+     }
+ }",Maybe rename to `RegisterListener` or `RegisterSubscriber`?,Could we make this
+9826,"@@ -34,7 +34,8 @@ export function diffChildren(
+ 	oldDom,
+ 	isHydrating
+ ) {
+-	let i, j, oldVNode, newDom, sibDom, firstChildDom, refs;
++	let i, j, oldVNode, newDom, sibDom, firstChildDom;
++	let refs = [];
+
+ 	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
+ 	// as EMPTY_OBJ._children should be `undefined`.","My one concern here is that we are adding a new array allocation for each depth of the tree which could add some non-trivial GC churn. Perhaps this would be okay if we think that refs are used through a tree commonly enough such that they'll get allocated anyway but I'm not sure refs are *that* often used. Every app has a couple, but probably not at every level of their app :/ So maybe the extra bytes are worth it in this case? Though I have no data to back up my hypothesis so I could way off lol.",Why is this change
+9827,"@@ -45,7 +45,7 @@ class TestDeterminism < Test::Unit::TestCase
+
+   def subclasses
+     Faker.constants.delete_if do |subclass|
+-      %i[Base Bank Books Cat Char Base58 ChileRut Config Creature Date Dog DragonBall Dota ElderScrolls Fallout Games GamesHalfLife HeroesOfTheStorm Internet JapaneseMedia LeagueOfLegends Movies Myst Overwatch OnePiece Pokemon SwordArtOnline TvShows Time VERSION Witcher WorldOfWarcraft Zelda].include?(subclass)
++      %i[Base Bank Books Cat Char Base58 ChileRut CLI Config Creature Date Dog DragonBall Dota ElderScrolls Fallout Games GamesHalfLife HeroesOfTheStorm Internet JapaneseMedia LeagueOfLegends Movies Myst Overwatch OnePiece Pokemon SwordArtOnline TvShows Time VERSION Witcher WorldOfWarcraft Zelda].include?(subclass)
+     end.sort
+   end
+ ",We should get rid of this big array and think about a better way to check this.,this is not needed
+9828,"@@ -67,6 +67,11 @@ namespace MvvmCross.Droid.Shared.Presenter
+             var serializedRequest = Serializer.Serializer.SerializeObject(request);
+             bundle.PutString(ViewModelRequestBundleKey, serializedRequest);
+
++            if (request is MvxViewModelInstanceRequest)
++            {
++                Mvx.Resolve<IMvxChildViewModelCache>().Cache(((MvxViewModelInstanceRequest)request).ViewModelInstance);
++            }
++
+             if (!_fragmentHostRegistrationSettings.IsActualHostValid(request.ViewModelType))
+             {
+                 Type newFragmentHostViewModelType =",Should we cache the result of `Mvx.Resolve<IMvxChildViewModelCache>()` to avoid a lookup each time?,"Hi @aosyatnik, I'm not sure if this is a good idea to cache `MvxChildViewModelCache` here. Would you agree?"
+9829,"@@ -89,7 +89,10 @@ class RequestConsumer:
+                     self.connect_to_rabbitmq()
+                     self.init_rabbitmq_channels()
+
+-        avg_size_of_message //= num_of_messages
++        try:
++            avg_size_of_message //= num_of_messages
++        except ZeroDivisionError:
++            current_app.logger.warn(""No messages calculated"", exc_info=True)
+
+         current_app.logger.info(""Done!"")
+         current_app.logger.info(""Number of messages sent: {}"".format(num_of_messages))","If you get to this line avg_size_of_message is an undefined value, yet you use it below. You you should set this value to something in the exception block.",What do you think about making `num_of_messages` a kwarg for `__call__` that defaults to `1` if no messages
+9830,"@@ -0,0 +1,10 @@
++package mux
++
++import (
++	""net/http""
++	""net/http/pprof""
++)
++
++func pprofHandlers(httpMux *http.ServeMux) {
++	httpMux.HandleFunc(""/debug/pprof/"", pprof.Index)
++}","let's just fold this inline in mux.go, no need for the indirection to this new file",This could probably live in `/debug`?
+9831,"@@ -31,6 +31,7 @@ import com.github.javaparser.ast.nodeTypes.NodeWithTokenRange;
+ import com.github.javaparser.ast.observer.AstObserver;
+ import com.github.javaparser.ast.observer.ObservableProperty;
+ import com.github.javaparser.ast.observer.PropagatingAstObserver;
++import com.github.javaparser.ast.stmt.BlockStmt;
+ import com.github.javaparser.ast.visitor.CloneVisitor;
+ import com.github.javaparser.ast.visitor.EqualsVisitor;
+ import com.github.javaparser.ast.visitor.HashCodeVisitor;","This bit confused me just now as I was reading through -- turns out this is due to the `{@link}` on line 316. Reading up on this, the alternative seems to be to state the fully qualified name instead. Happy to edit if requested as I don't have a strong view either way (perhaps a small leaning towards keeping the import).",why not `import com.github.javaparser.ast.stmt.BlockStmt;` ?
+9832,"@@ -159,6 +159,18 @@ public class CPPTokenizerTest {
+         tokenizer.tokenize(code, new Tokens());
+     }
+
++    @Test
++    public void testDigitSeparators() {
++        final String code = ""auto integer_literal = 1'000'000;"" + PMD.EOL
++                + ""auto floating_point_literal = 0.000'015'3;"" + PMD.EOL
++                + ""auto hex_literal = 0x0F00'abcd'6f3d;"" + PMD.EOL
++                + ""auto silly_example = 1'0'0'000'00;"";
++        Tokens tokens = parse(code);
++        System.out.println(tokens.getTokens());
++        assertTrue(TokenEntry.getEOF() != tokens.getTokens().get(0));
++        assertEquals(21, tokens.size());
++    }
++
+     private Tokens parse(String snippet) {
+         try {
+             return parse(snippet, false, new Tokens());",There's a unnecessary System.out.,"This test should go away, it isn't related to the `Tokens` class."
+9833,"@@ -532,6 +532,15 @@ func (c *client) InstallGatewayFlows() error {
+ 	// Add flow to ensure the liveness check packet could be forwarded correctly.
+ 	flows = append(flows, c.localProbeFlow(gatewayIPs, cookie.Default)...)
+ 	flows = append(flows, c.ctRewriteDstMACFlows(gatewayConfig.MAC, cookie.Default)...)
++	if c.enableProxy {
++		flows = append(flows, c.arpNodePortVirtualResponderFlow())
++		if gatewayConfig.IPv6 != nil {
++			flows = append(flows, c.serviceGatewayFlow(true))
++		}
++		if gatewayConfig.IPv4 != nil {
++			flows = append(flows, c.serviceGatewayFlow(false))
++		}
++	}
+ 	// In NoEncap , no traffic from tunnel port
+ 	if c.encapMode.SupportsEncap() {
+ 		flows = append(flows, c.l3FwdFlowToGateway(gatewayIPs, gatewayConfig.MAC, cookie.Default)...)",Should we add the flows only when NodePort is enabled?,can we make this a flag on the config?
+9834,"@@ -2,12 +2,12 @@ AC_PREREQ([2.63])
+ dnl To do a release: follow the instructions to update libostree-released.sym from
+ dnl libostree-devel.sym, update the checksum in test-symbols.sh, set is_release_build=yes
+ dnl below. Then make another post-release commit to bump the version and set
+-dnl is_release_build=no
++dnl is_release_build=yes
+ dnl Seed the release notes with `git-shortlog-with-prs <previous-release>..`. Then use
+ dnl `git-evtag` to create the tag and push it. Finally, create a GitHub release and attach
+ dnl the tarball from `make dist`.
+ m4_define([year_version], [2020])
+-m4_define([release_version], [2])
++m4_define([release_version], [3])
+ m4_define([package_version], [year_version.release_version])
+ AC_INIT([libostree], [package_version], [walters@verbum.org])
+ is_release_build=no",ITYM to flip this one...,"As far as I can tell, there is no way for a release tag to be tag"
+9835,"@@ -7,7 +7,9 @@ module.exports = {
+   },
+   extends: [
+     'airbnb',
+-    'plugin:@typescript-eslint/recommended',
++    ""eslint:recommended"",
++    ""plugin:@typescript-eslint/eslint-recommended"",
++    ""plugin:@typescript-eslint/recommended"",
+     'prettier',
+     'prettier/@typescript-eslint',
+     'plugin:prettier/recommended',",What's the difference between typescript-eslint/eslint-recommended and typescript-eslint/recommended? I really can't get it.,Why are these lines changed in this PR?
+9836,"@@ -223,6 +223,14 @@ type Config struct {
+ 	// If the timeout is exceeded, the connection is closed.
+ 	// If this value is zero, the timeout is set to 30 seconds.
+ 	IdleTimeout time.Duration
++	// AttackTimeout is the maximum duration that may pass after a suspicious packet is
++	// received without any incoming network activity, used for experimental mitigation
++	// against injection attacks. If the timeout is exceeded, the connection is closed.
++	// This timeout should be longer than any reasonable round trip time, but excessively
++	// long timeouts will delay reporting of rejected connections.
++	// If this value is zero, the default mitigation behavior will be used (currently off).
++	// If this value is negative, mitigation will be disabled.
++	AttackTimeout time.Duration
+ 	// AcceptToken determines if a Token is accepted.
+ 	// It is called with token = nil if the client didn't send a token.
+ 	// If not set, a default verification function is used:","Thinking: Maybe it would be more useful to define this in terms of RTTs. That would also make it easier to switch this to a bool, since we could then pick a reasonable default value. Unless of course an attacker could influence our RTT estimate. Is that the case?",mitigation -> attack (?)
+9837,"@@ -1,4 +1,3 @@
+-//  Copyright 2019 Google Inc. All Rights Reserved.
+ //
+ //  Licensed under the Apache License, Version 2.0 (the ""License"");
+ //  you may not use this file except in compliance with the License.",Why is this line deleted?,Don't change the copyrig
+9838,"@@ -115,9 +115,9 @@ void nano::active_transactions::request_confirm (std::unique_lock<std::mutex> &
+ 	std::deque<std::shared_ptr<nano::block>> rebroadcast_bundle;
+ 	std::deque<std::pair<std::shared_ptr<nano::block>, std::shared_ptr<std::vector<std::shared_ptr<nano::transport::channel>>>>> confirm_req_bundle;
+
+-	// Confirm frontiers when there aren't many confirmations already pending
++	// Confirm frontiers when there aren't many confirmations already pending and node finished initial boostrap
+ 	lock_a.unlock ();
+-	if (node.pending_confirmation_height.size () < confirmed_frontiers_max_pending_cut_off)
++	if (node.pending_confirmation_height.size () < confirmed_frontiers_max_pending_cut_off && node.store.block_count (transaction).sum () >= node.ledger.bootstrap_weight_max_blocks)
+ 	{
+ 		confirm_frontiers (transaction);
+ 	}",minor type `boostrap`,The check for `node.pend
+9839,"@@ -20,9 +20,12 @@
+ package com.netflix.iceberg;
+
+ import com.google.common.base.Objects;
++import com.google.common.collect.Lists;
+ import com.netflix.iceberg.expressions.Expression;
+ import com.netflix.iceberg.expressions.ResidualEvaluator;
+
++import java.util.Iterator;
++
+ class BaseFileScanTask implements FileScanTask {
+   private final DataFile file;
+   private final String schemaString;",Nit: please don't separate imports into groups.,You may want to consider
+9840,"@@ -31,7 +31,10 @@ public class ApplicationSidebarToggleGroupSkin extends
+         final ToggleButton allCategoryButton = createSidebarToggleButton(tr(""All""));
+
+         allCategoryButton.setId(""allButton"");
+-        allCategoryButton.setOnAction(event -> getControl().getOnAllCategorySelection().run());
++        allCategoryButton.setOnAction(event -> {
++            getControl().setSelectedElement(null);
++            getControl().getOnAllCategorySelection().run();
++        });
+
+         return Optional.of(allCategoryButton);
+     }",Thinking if it would be nice to have something like `setNothingSelected`.,This is the only one that makes sense to me. Why `setSelectedElement` and not `setControl`?
+9841,"@@ -141,7 +141,7 @@ func (f *FileCertificateSource) updateCertificateFromDisk() error {
+ 		f.Log.V(logf.DebugLevel).Info(""key and certificate on disk have not changed"")
+ 		return nil
+ 	}
+-	f.Log.Info(""detected private key or certificate data on disk has changed. reloading certificate"")
++	f.Log.V(logf.DebugLevel).Info(""detected private key or certificate data on disk has changed. reloading certificate"")
+
+ 	cert, err := tls.X509KeyPair(certData, keyData)
+ 	if err != nil {","I think this is a useful InfoLevel message. In production, if webhook client connections suddenly start failing due to change of serving cert, you'd want to see this information in the logs.",It would be nice if we didn't have this in the first place. Would that be a problem?
+9842,"@@ -28,7 +28,7 @@ void AddTagProcessor::process(const cpp2::AddTagReq& req) {
+     auto version = time::TimeUtils::nowInMSeconds();
+     TagID tagId = autoIncrementId();
+     data.emplace_back(MetaUtils::indexKey(EntryType::TAG, req.get_tag_name()),
+-                      std::string(reinterpret_cast<const char*>(&tagId), sizeof(tagId)));
++                      folly::to<std::string>(tagId));
+     LOG(INFO) << ""Add Tag "" << req.get_tag_name() << "", tagId "" << tagId;
+     data.emplace_back(MetaUtils::schemaTagKey(req.get_space_id(), tagId, version),
+                       MetaUtils::schemaTagVal(req.get_tag_name(), req.get_schema()));","Generally, if cast from int to char*, you could cast directly. Because no errors should happen.",Consider using `std::move` instead of `folly::to_string`?
+9843,"@@ -26,5 +26,12 @@ public class ServerInternals {
+   public static final String AZKABAN_EXECUTOR_PORT_FILENAME = ""executor.port"";
+
+   public static final String AZKABAN_SERVLET_CONTEXT_KEY = ""azkaban_app"";
+-
++
++
++  // Memory check retry interval when OOM in ms
++  public static final long MEMORY_CHECK_INTERVAL = 1000*60*10;
++
++  // Max number of memory check retry
++  public static final int MEMORY_CHECK_RETRY_LIMIT = 100;
++
+ }","Is 10 min too long? What do you think about 1 minute? Unless there are many jobs in this state, I don't expect the CPU overhead to be too high.",Please use spaces instead of tabs for code style.
+9844,"@@ -28,10 +28,10 @@ type BackendServiceConfig struct {
+ 	ImageConfig      ImageWithPortAndHealthcheck `yaml:""image,flow""`
+ 	ImageOverride    `yaml:"",inline""`
+ 	TaskConfig       `yaml:"",inline""`
+-	*Logging         `yaml:""logging,flow""`
++	Logging          `yaml:""logging,flow""`
+ 	Sidecars         map[string]*SidecarConfig `yaml:""sidecars""`
+-	Network          *NetworkConfig            `yaml:""network""`
+-	Publish          *PublishConfig            `yaml:""publish""`
++	Network          NetworkConfig             `yaml:""network""`
++	Publish          PublishConfig             `yaml:""publish""`
+ 	TaskDefOverrides []OverrideRule            `yaml:""taskdef_overrides""`
+ }
+ ",can you remind me why we keep the pointer if it's a `map[string]<PStruct>`? are there other scenarios where the pointer is kept?,[nit] Can you remove the extra whitespace?
+9845,"@@ -61,8 +61,9 @@ public class RewriteDataFilesAction extends BaseRewriteDataFilesAction<RewriteDa
+     return this;
+   }
+
+-  public void maxParallelism(int parallelism) {
++  public RewriteDataFilesAction maxParallelism(int parallelism) {
+     Preconditions.checkArgument(parallelism > 0, ""Invalid max parallelism %d"", parallelism);
+     this.maxParallelism = parallelism;
++    return this;
+   }
+ }",Would it make sense to also add `setMaxParallelism` in addition to this to match the Flink API?,nit: No need for this `return this;`
+9846,"@@ -1,4 +1,13 @@
+ import ModalComponent from 'ghost-admin/components/modal-base';
++import {inject as service} from '@ember/service';
+
+ export default ModalComponent.extend({
++    billing: service(),
++
++    actions: {
++        closeModal() {
++            this._super(arguments);
++            this.billing.closeBillingWindow();
++        }
++    }
+ });",Not needed for actions. `_super(...arguments)` is only needed when you're extending from a base class and want to run the logic in the base class before your own logic,`this.billing.closeBillingWindow();` should
+9847,"@@ -104,7 +104,14 @@ Suspense.prototype._childDidSuspend = function(promise, suspendingComponent) {
+ 		}
+ 	};
+
+-	if (!c._pendingSuspensionCount++) {
++	/**
++	 * We do not set `suspended: true` during hydration because we want the actual markup
++	 * to remain on screen and hydrate it when the suspense actually gets resolved.
++	 * While in non-hydration cases the usual fallback -> component flow would occour.
++	 */
++	const vnode = c._vnode;
++	const wasHydrating = vnode && vnode._hydrating === true;
++	if (!wasHydrating && !c._pendingSuspensionCount++) {
+ 		c.setState({ _suspended: (c._detachOnNextRender = c._vnode._children[0]) });
+ 	}
+ 	promise.then(onResolved, onResolved);","I still need to run this code to verify my understanding, but my first reading through makes me think this may need to be `suspendingComponent._vnode` since we set `vnode._hydrating` on the vnode that threw the error (diff/index.js:275), not on `Suspense._vnode` (though we could in Suspense's `_catchError` implementation at the top of this file).",Typo: should be `suspended`.
+9848,"@@ -372,8 +372,14 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
+         path = None
+
+     if check_exists:
+-        if path is not None and os.path.exists(path):
+-            log.url.debug(""URL is a local file"")
++        if path is not None:
++            # If the path contains characters that the locale cannot handle,
++            # then we consider it as non-existent.
++            try:
++                if os.path.exists(path):
++                    log.url.debug(""URL is a local file"")
++            except UnicodeEncodeError:
++                path = None
+         else:
+             path = None
+ ","I think it's a good idea to log this as debug, the same way the other branch gets logged.",Should this be `except UnicodeEncodeError:`?
+9849,"@@ -73,7 +73,7 @@ class TestJSONLD(AnnotationTestCase):
+                 ""comment"": 1}
+         a = API.add_annotation(model='annotation_note', **data)
+
+-        # JSONAlchemy issue with overwritting fields
++        # JSONAlchemy issue with overwriting fields
+         self.assert_(len(a.validate()) == 0)
+
+         ld = a.get_jsonld(""oaf"",",1:D100: Docstring missing 35:D101: Docstring missing 37:D102: Docstring missing 42:D101: Docstring missing 44:D102: Docstring missing 57:D102: Docstring missing 66:D101: Docstring missing 69:D102: Docstring missing,I think this is an accidental change?
+9850,"@@ -20,6 +20,10 @@ import (
+ 	""context""
+ )
+
++const (
++	systemGuestRoleName = ""system.guest""
++)
++
+ var (
+ 	systemTokenInst TokenGenerator = &noauth{}
+ ","keeping this as an unexported constant, as importing the role pkg creates a cyclic dependency.",Why is this hardcoded? What's the security i
+9851,"@@ -349,9 +349,12 @@ func (c *collection) newPut(a *driver.Action, opts *driver.RunActionsOptions) (*
+ 		// It doesn't make sense to generate a random sort key.
+ 		return nil, fmt.Errorf(""missing sort key %q"", c.sortKey)
+ 	}
+-	rev := driver.UniqueString()
+-	if av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {
+-		return nil, err
++	var rev string
++	if a.Doc.RevisionOn(c.RevisionField()) {
++		rev = driver.UniqueString()
++		if av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {
++			return nil, err
++		}
+ 	}
+ 	dput := &dyn.Put{
+ 		TableName: &c.table,",Why `c.RevisionField()` here but `c.opts.RevisionField` just below?,"For the sake of consistency, this should be "
+9852,"@@ -139,7 +139,6 @@ type Context struct {
+ 	OriginalTargetReached bool
+ 	OvmExecutionManager   dump.OvmDumpAccount
+ 	OvmStateManager       dump.OvmDumpAccount
+-	OvmMockAccount        dump.OvmDumpAccount
+ 	OvmSafetyChecker      dump.OvmDumpAccount
+ }
+ ",nit: this file diff seems unrelated and probably should have been a separate PR,Do we need the `OvmMockAccount` any more?
+9853,"@@ -38,7 +38,7 @@ extern ""C"" {
+   void latte(int *, int *, double *, int *, int *,
+              double *, double *, double *, double *,
+              double *, double *, double *, int*,
+-             double *, double *, double *, double * );
++             double *, double *, double *, double *, bool *);
+ }
+
+ #define INVOKED_PERATOM 8","@sjplimp just checked this API in the latte repository master branch (which is what Install.py downloads) and this still does not provide the 18th argument. We cannot merge this pull request until this is available. i would also suggest to implement a second binding, a function called latte_abiversion() returning an int with an ABI version number (starting with 1). This way, it can be tested, whether the ABI expected by the LAMMPS interface and provided by the library is compatible *before* calling the `latte()` function and risking a segmentation fault.",Remove the bool * parameter. This is not
+9854,"@@ -214,7 +214,10 @@ namespace Nethermind.JsonRpc.Modules.Eth
+             }
+
+             Account account = _stateReader.GetAccount(header.StateRoot, address);
+-            return Task.FromResult(ResultWrapper<UInt256?>.Success(account?.Nonce ?? 0));
++            UInt256 nonce = account?.Nonce ?? 0;
++            _logger.Warn($""{address} nonce is {nonce}"");
++
++            return Task.FromResult(ResultWrapper<UInt256?>.Success(nonce));
+         }
+
+         public ResultWrapper<UInt256?> eth_getBlockTransactionCountByHash(Keccak blockHash)",Is this from debugging?,Why the log message here?
+9855,"@@ -51,12 +51,17 @@ class NodeTest extends TestCase
+
+     /**
+      */
+-    public function testAddChildren():void
++    public function testAddChildren(): void
+     {
++        $categoryId2 = new CategoryId('cde02652-70ce-484e-bc9d-3bf61391522d');
++
+         /** @var Node|MockObject $children */
+-        $children = $this->createMock(Node::class);
++        $children = new Node($categoryId2);
+         $node = new Node($this->categoryId);
++        $this->assertFalse($node->hasChildren($categoryId2));
+         $node->addChildren($children);
+         $this->assertEquals($children, $node->getChildrens()[0]);
++        $this->assertFalse($node->hasSuccessor($this->categoryId));
++        $this->assertTrue($node->hasChildren($categoryId2));
+     }
+ }",Its betet use MockedObject,`$this->assertTrue` instead of `assertFal
+9856,"@@ -840,8 +840,12 @@ type DiskBlockCache interface {
+ 	// Put puts a block to the disk cache.
+ 	Put(ctx context.Context, tlfID tlf.ID, blockID kbfsblock.ID, buf []byte,
+ 		serverHalf kbfscrypto.BlockCryptKeyServerHalf) error
+-	// DeleteByTLF deletes some blocks from the disk cache.
+-	DeleteByTLF(ctx context.Context, tlfID tlf.ID, blockIDs []kbfsblock.ID) (numRemoved int, sizeRemoved int64, err error)
++	// Delete deletes some blocks from the disk cache.
++	Delete(ctx context.Context, blockIDs []kbfsblock.ID) (numRemoved int,
++		sizeRemoved int64, err error)
++	// UpdateMetadata updates the metadata for the given block, including
++	// setting the LRU time to now.
++	UpdateMetadata(ctx context.Context, blockID kbfsblock.ID) error
+ 	// Size returns the size in bytes of the disk cache.
+ 	Size() int64
+ 	// Shutdown cleanly shuts down the disk block cache.","""including""? Since it doesn't take any parameters, I'm not sure how it can update anything else...",So `DeleteByTLF` wasn't used?
+9857,"@@ -674,7 +674,7 @@ namespace AutoRest.Core.Properties {
+         }
+
+         /// <summary>
+-        ///   Looks up a localized string similar to Non-HTTPS/HTTP schemes have limited support.
++        ///   Looks up a localized string similar to Azure Resource Management only supports HTTPS scheme..
+         /// </summary>
+         public static string SupportedSchemesWarningMessage {
+             get {",nit: I'm assuming you have verified this is what the error message should read like,"@scalablecory, is this suppos"
+9858,"@@ -850,4 +850,4 @@ def main(argv):
+     return glob_result
+
+ if __name__ == ""__main__"":
+-    exit(main(sys.argv[1:]))
++    sys.exit(main(sys.argv[1:]))",Why do you need that? (real question),`import sys` at the top of th
+9859,"@@ -1788,7 +1788,7 @@ static void skipCppTemplateParameterList (void)
+ 				}
+ 			}
+ 			else if(CollectingSignature)
+-				vStringPut (Signature, x);
++				vStringPut (Signature, c);
+ 		}
+ 		else if (c == '>')
+ 		{",If I understand the patch correctly the `else` is no longer required.,I think this should be `else
+9860,"@@ -11,14 +11,14 @@ import (
+
+ var (
+ 	dealsSearchCount  uint64
+-	addToBlacklist    bool
++	blacklistTypeStr  string
+ 	crNewDurationFlag string
+ 	crNewPriceFlag    string
+ )
+
+ func init() {
+ 	dealListCmd.PersistentFlags().Uint64Var(&dealsSearchCount, ""limit"", 10, ""Deals count to show"")
+-	dealCloseCmd.PersistentFlags().BoolVar(&addToBlacklist, ""blacklist"", false, ""Add counterparty to blacklist"")
++	dealCloseCmd.PersistentFlags().StringVar(&blacklistTypeStr, ""blacklist"", ""none"", ""Whom to add to blacklist (worker, master or neither)"")
+ 	changeRequestCreateCmd.PersistentFlags().StringVar(&crNewDurationFlag, ""new-duration"", """", ""Propose new duration for a deal"")
+ 	changeRequestCreateCmd.PersistentFlags().StringVar(&crNewPriceFlag, ""new-price"", """", ""Propose new price for a deal"")
+ ",Properly describe valid flag values here: `neither` should be replaced with `none` as they parsed below.,"I would suggest to call it ""none"" instead of ""none"" - that way it's more obvious what ""none"" means."
+9861,"@@ -379,7 +379,16 @@ public class AzkabanExecutorServer {
+           logger.info((""Exception when logging top memory consumers""), e);
+         }
+
+-        logger.info(""Shutting down..."");
++        String host = app.getHost();
++        int port = app.getPort();
++        try {
++          logger.info(String.format(""Removing executor(host: %s, port: %s) entry from database..."", host, port));
++          app.getExecutorLoader().removeExecutor(host, port);
++        } catch (ExecutorManagerException ex) {
++          logger.error(String.format(""Exception when removing executor(host: %s, port: %s)"", host, port), ex);
++        }
++
++        logger.info(""Shutting down executor..."");
+         try {
+           app.shutdownNow();
+         } catch (Exception e) {",Can we escalate this to `warn`. It is a major event.,Should we catch a more specific exception here? What would be the impact if we don't catch it?
+9862,"@@ -86,6 +86,8 @@ var (
+ 	_                            = stateOffDstPort
+ 	stateOffPostNATDstPort int16 = 24
+ 	stateOffIPProto        int16 = 26
++	stateOffICMPType       int16 = 22
++	stateOffICMPCode       int16 = 23
+
+ 	// Compile-time check that IPSetEntrySize hasn't changed; if it changes, the code will need to change.
+ 	_ = [1]struct{}{{}}[20-ipsets.IPSetEntrySize]",Please move these up to line 86 so the numbers are in order.,"For consistency with the rest of the structs, please use `int16` and `int32`."
+9863,"@@ -0,0 +1,16 @@
++from ..builder import DETECTORS
++from .single_stage import SingleStageDetector
++
++
++@DETECTORS.register_module()
++class NASFCOS(SingleStageDetector):
++
++    def __init__(self,
++                 backbone,
++                 neck,
++                 bbox_head,
++                 train_cfg=None,
++                 test_cfg=None,
++                 pretrained=None):
++        super(NASFCOS, self).__init__(backbone, neck, bbox_head, train_cfg,
++                                      test_cfg, pretrained)",Add a docstring to contain the paper link.,Can you add a docstring to this class?
+9864,"@@ -170,7 +170,11 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(stri
+ 		for i, path := range config.ExtraFiles() {
+ 			abspath := filepath.Join(root, path)
+ 			outpath := filepath.Join(dir, ""extra-""+strconv.Itoa(i)+""-""+filepath.Base(path)+"".o"")
+-			err := runCCompiler(config.Target.Compiler, append(config.CFlags(), ""-c"", ""-o"", outpath, abspath)...)
++			targ:=config.Target.Triple
++			if targ!="""" {
++				targ=""--target=""+config.Target.Triple
++			}
++			err := runCCompiler(config.Target.Compiler, append(config.CFlags(), ""-c"", targ,""-o"", outpath, abspath)...)
+ 			if err != nil {
+ 				return &commandError{""failed to build"", path, err}
+ 			}","Instead of adding the `--target` flag here, the `Target` struct should be set up correctly. Assuming this is for the Raspberry Pi 3, adding it to the `cflags` key of the JSON file should be enough (if not, you can print `config.CFlags()` here to check whether `--target` is already included).",This line needs to be split off into two lines to make it easier to read.
+9865,"@@ -280,7 +280,9 @@ func (s *Service) BatchCreateFederatedBundle(ctx context.Context, req *bundlev1.
+ 		r := s.createFederatedBundle(ctx, b, req.OutputMask)
+ 		results = append(results, r)
+
+-		rpccontext.AuditRPCWithTypesStatus(ctx, r.Status, fieldsFromBundleProto(b, nil))
++		if _, ok := rpccontext.AuditLog(ctx); ok {
++			rpccontext.AuditRPCWithTypesStatus(ctx, r.Status, fieldsFromBundleProto(b, nil))
++		}
+ 	}
+
+ 	return &bundlev1.BatchCreateFederatedBundleResponse{",The changes in this file look unnecessary since `rpccontext.AuditRPCWithTypesStatus()` already does this check. Was there a reason you needed to add them?,"Does this need to be inside the `if _, ok := ...` block?"
+9866,"@@ -0,0 +1,9 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package batchstore
++
++const StateKey = stateKey
++
++var BatchKey = batchKey",you could probably use `const` for both?,what is this used for?
+9867,"@@ -0,0 +1,9 @@
++import { isDataTable } from '../commons/table';
++import { isFocusable } from '../commons/dom';
++
++// TODO: es-modules add tests. No way to access this on the `axe` object
++function dataTableMatches(node) {
++	return !isDataTable(node) && !isFocusable(node);
++}
++
++export default dataTableMatches;","This looks like an ""ES Module"" to me. I do not understand this TODO.",Do you still need this?
+9868,"@@ -103,8 +103,8 @@ public class RowDataRewriter implements Serializable {
+     OutputFileFactory fileFactory = new OutputFileFactory(
+         spec, format, locations, io.value(), encryptionManager.value(), partitionId, taskId);
+
+-    TaskWriter<InternalRow> writer;
+-    if (spec.fields().isEmpty()) {
++    final TaskWriter<InternalRow> writer;
++    if (spec.isUnpartitioned()) {
+       writer = new UnpartitionedWriter<>(spec, format, appenderFactory, fileFactory, io.value(),
+           Long.MAX_VALUE);
+     } else if (PropertyUtil.propertyAsBoolean(properties,","Iceberg doesn't use `final` because it is unlikely that this actually helps. In Java 8, final detection is quite good, which is why non-final variables can be used in closures and lambdas. And final doesn't produce different byte code so it can't do much to help at runtime.",nit: unpartitionedWriters -> unpartitionedWriters
+9869,"@@ -7391,7 +7391,7 @@ int LuaScriptInterface::luaPlayerGetIp(lua_State* L)
+ 	// player:getIp()
+ 	Player* player = getUserdata<Player>(L, 1);
+ 	if (player) {
+-		lua_pushnumber(L, player->getIP());
++		lua_pushstring(L, player->getIP().to_string().c_str());
+ 	} else {
+ 		lua_pushnil(L);
+ 	}",There's `pushString` to use with C++ strings.,"`player::getIP()` can return a NULL, so you don't"
+9870,"@@ -306,6 +306,13 @@ var _ = infrastructure.DatastoreDescribe(""service loop prevention; with 2 nodes""
+ 			cfg.Spec.ServiceLoopPrevention = ""Disabled""
+ 		})
+
++		// Expect to see empty cali-cidr-block chains.  (Allowing time for a Felix
++		// restart.)  This ensures that the cali-cidr-block chain has been cleared
++		// before we try a test ping.
++		for _, felix := range felixes {
++			Eventually(getCIDRBlockRules(felix, ""iptables-save""), ""8s"", ""0.5s"").Should(BeEmpty())
++		}
++
+ 		By(""test that we DO get a routing loop"")
+ 		// (In order to test that the tryRoutingLoop setup is genuine.)
+ 		tryRoutingLoop(true)",qq: Should this include the iptables6-save sim. to the inverse checks above?,@smarterclayton do we need to change this to `0.5
+9871,"@@ -622,7 +622,11 @@ bool RTPSParticipantImpl::create_writer(
+
+     std::lock_guard<std::recursive_mutex> guard(*mp_mutex);
+     m_allWriterList.push_back(SWriter);
+-    if (!is_builtin)
++    if (is_builtin)
++    {
++        async_thread().wake_up(SWriter);
++    }
++    else
+     {
+         m_userWriterList.push_back(SWriter);
+     }",What about async user writers? We could be checking `param.mode == ASYNCHRONOUS_WRITER`,Is this thread safe when `is_builtin` is true?
+9872,"@@ -84,7 +84,7 @@ public class UseUtilityClassRule extends AbstractLombokAwareRule {
+     private boolean isOkUsingLombok(ASTClassOrInterfaceDeclaration parent) {
+         // check if there's a lombok no arg private constructor, if so skip the rest of the rules
+         if (hasClassLombokAnnotation()) {
+-            ASTAnnotation annotation = getLombokAnnotation(parent, ""NoArgsConstructor"");
++            ASTAnnotation annotation = parent.getAnnotation(""lombok.NoArgsConstructor"");
+
+             if (annotation != null) {
+ ","this double check for lombok annotation + specific lombok annotation seems pointless, just keep the second (specific) check. Moreover, since we have a property with ignored annotations... why don't we use it? a user may setup the property and it will be ignored here. Also, this class should probably not extend `AbstractLombokAwareRule` anymore. We have a configurable set of annotations that suppress the warning, defaulting to ALL lombok annotations, yet we only check for `lombok.NoArgsConstructor`... Maybe directly extending `AbstractIgnoredAnnotRule` and settig the default property to `lombok.NoArgsConstructor`? Or, to avoid a breaking API change, keep extending it, but override the default. For 7.0.0 we can change the class hierarchy.",Do you think it would make sense to extract this string into a constant?
+9873,"@@ -67,9 +67,11 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // route requests through YARPC. The http.Handler returned by this function
+ // may delegate requests to the provided YARPC handler to route them through
+ // YARPC.
++// If more than one Interception is provided, they will be invoked in the same
++// order as they are passed in.
+ func Interceptor(interceptor func(yarpcHandler http.Handler) http.Handler) InboundOption {
+ 	return func(i *Inbound) {
+-		i.interceptor = interceptor
++		i.interceptors = append(i.interceptors, interceptor)
+ 	}
+ }
+ ","nit: the ordering may be misunderstood, as ""invoked in the same order"" could suggest the passed-in functions are called in-order, but the actual wrapping is LIFO. Some other ways to describe it (don't think any of these are ideal, but maybe it will help you come up with something better), * the handled returned by the first interceptor is executed first * interceptors are applied outside-in (don't like the terms outside/in though) * interceptors are applied in LIFO order, leading to an earlier interceptor's handler being executed before latter interceptor handlers","If only one interceptor is provided, wouldn't it be invoked in the same "
+9874,"@@ -101,6 +101,8 @@ import org.w3c.dom.NodeList;
+ import org.xml.sax.InputSource;
+ import org.xml.sax.SAXException;
+
++import static org.apache.solr.common.params.QueryElevationParams.ELEVATE_DOCS_WITHOUT_MATCHING_Q;
++
+ /**
+  * A component to elevate some documents to the top of the result set.
+  *",We should not use a static import to be consistent with other existing use of the QueryElevationParams.,I think this import is no longer needed.
+9875,"@@ -277,7 +277,7 @@ void *ap6_thread(void *thread_context)
+ 	uint32_t num_matches = 0;
+
+ 	struct bitstream_info null_gbs_info ;
+-	memset(&null_gbs_info, 0, sizeof(null_gbs_info));
++	memset_s(&null_gbs_info, sizeof(null_gbs_info), 0);
+
+ 	ON_GOTO(c->config->num_null_gbs == 0, out_exit, ""no NULL bitstreams registered."");
+ ",No need to check return value?,"This should be memset_s(null_gbs_info, 0, sizeof(null_gbs_info));"
+9876,"@@ -42,6 +42,11 @@ from typing import (Any, Callable, IO, Iterator, Optional, Sequence, Tuple, Type
+ from PyQt5.QtCore import QUrl, QVersionNumber
+ from PyQt5.QtGui import QClipboard, QDesktopServices
+ from PyQt5.QtWidgets import QApplication
++# We cannot use the stdlib version on 3.7-3.8 because we need the files() API.
++if sys.version_info >= (3, 9):
++    import importlib.resources as importlib_resources
++else:
++    import importlib_resources
+ import pkg_resources
+ import yaml
+ try:","~~Feel free to ignore that one, I'll fix things up when regenerating the `requirements.txt`.~~ As for the one below, this smells like a pylint bug...","I don't think this is the right way to go about it. The version check here should be `if not os.environ.get(""MICROSOFT_VERSION):`"
+9877,"@@ -279,6 +279,7 @@ func (fa *flowAggregator) InitCollectingProcess() error {
+ 			IsEncrypted:   false,
+ 		}
+ 	}
++	cpInput.NumExtraElements = len(antreaSourceStatsElementList) + len(antreaDestinationStatsElementList) + len(antreaLabelsElementList)
+ 	var err error
+ 	fa.collectingProcess, err = ipfix.NewIPFIXCollectingProcess(cpInput)
+ 	return err",it's a bit strange that this doesn't match `aggregationElements` which is what I would expect. I guess I am not familiar enough with go-ipfix.,`+` should be on the previous line.
+9878,"@@ -35,11 +35,13 @@
+ #include ""instr.h""
+
+ static int num_simd_saved;
++static int num_simd_saved_abs;
+
+ void
+ proc_init_arch(void)
+ {
+     num_simd_saved = MCXT_NUM_SIMD_SLOTS;
++    num_simd_saved_abs = MCXT_NUM_SIMD_SLOTS;
+
+     /* FIXME i#1569: NYI */
+ }",Same thing: `num_simd_registers`. Ditto below.,Does this need to be `static`? It looks like this is only used as a local variable.
+9879,"@@ -47,7 +47,7 @@ DEPENDENCY_LINKS = [
+ ]
+
+ setup(name='kinto',
+-      version='2.2.0.dev0',
++      version='2.2.1',
+       description='Kinto Web Service - Store, Sync, Share, and Self-Host.',
+       long_description=README + ""\n\n"" + CHANGELOG + ""\n\n"" + CONTRIBUTORS,
+       license='Apache License (2.0)',",Should be 2.1.1,I don't think this should be in this PR
+9880,"@@ -7,14 +7,16 @@ from localstack.utils.common import to_str, short_uid
+ TEST_BUCKET_NAME_WITH_NOTIFICATIONS = 'test_bucket_notif_1'
+ TEST_QUEUE_NAME_FOR_S3 = 'test_queue'
+ TEST_TOPIC_NAME = 'test_topic_name_for_sqs'
++TEST_S3_TOPIC_NAME = 'test_topic_name_for_s3_to_sns_to_sqs'
+ TEST_QUEUE_NAME_FOR_SNS = 'test_queue_for_sns'
+
+
+-def receive_assert_delete(queue_url, assertions, sqs_client=None):
++def receive_assert_delete(queue_url, assertions, sqs_client=None, required_subject=None):
+     if not sqs_client:
+         sqs_client = aws_stack.connect_to_service('sqs')
+
+     response = sqs_client.receive_message(QueueUrl=queue_url)
++
+     messages = [json.loads(to_str(m['Body'])) for m in response['Messages']]
+     testutil.assert_objects(assertions, messages)
+     for message in response['Messages']:",nitpick: `required_subject` doesn't seem to be used here,"Looks like a typo here, should be `required_subject`"
+9881,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,no need for this change
+9882,"@@ -871,6 +871,14 @@ class UIA(Window):
+ 					states.add(controlTypes.STATE_CHECKED)
+ 		return states
+
++	def _get_presentationType(self):
++		presentationType=super(UIA,self).presentationType
++		# UIA NVDAObjects can only be considered content if UI Automation considers them both a control and content.
++		if presentationType==self.presType_content and not (self.UIAElement.cachedIsContentElement and self.UIAElement.cachedIsControlElement):
++			presentationType=self.presType_layout
++		return presentationType
++
++
+ 	def correctAPIForRelation(self, obj, relation=None):
+ 		if obj and self.windowHandle != obj.windowHandle and not obj.UIAElement.cachedNativeWindowHandle:
+ 			# The target element is not the root element for the window, so don't change API class; i.e. always use UIA.",Extraneous blank line.,`self.UIAElement.cachedIsContentElement` and `self.U
+9883,"@@ -20,7 +20,8 @@ from codechecker_lib.analyzers import analyzer_clangsa
+ from codechecker_lib.analyzers import config_handler_clang_tidy
+ from codechecker_lib.analyzers import config_handler_clangsa
+ from codechecker_lib.analyzers import result_handler_clang_tidy
+-from codechecker_lib.analyzers import result_handler_clangsa
++from codechecker_lib.analyzers import result_handler_plist_to_db
++from codechecker_lib.analyzers import result_handler_plist_to_stdout
+
+ LOG = LoggerFactory.get_new_logger('ANALYZER TYPES')
+ ",Is this the same import as in the line 20?,Please rename `result_handler_clangsa` to `result_ha
+9884,"@@ -5,6 +5,7 @@ class Template < ActiveRecord::Base
+   validates_with TemplateLinksValidator
+
+   before_validation :set_defaults
++  after_update :reconcile_published, if: Proc.new { |template| template.published? && template.version.present? && template.version > 0 }
+
+   # Stores links as an JSON object: { funder: [{""link"":""www.example.com"",""text"":""foo""}, ...], sample_plan: [{""link"":""www.example.com"",""text"":""foo""}, ...]}
+   # The links is validated against custom validator allocated at validators/template_links_validator.rb",why those additional checks after published? template.version should always be present and greater than zero,Layout/LineLength: Line is too long. [122/120]
+9885,"@@ -61,6 +61,16 @@ type ExternalEntityReference struct {
+ 	Namespace string `json:""namespace,omitempty"" protobuf:""bytes,2,opt,name=namespace""`
+ }
+
++// EntityReference represents a reference to either a Pod or an ExternalEntity.
++// TODO: replace Pod and ExternalEntity in GroupMember to embed EntityReference
++//  when controlplane version is bumped?
++type EntityReference struct {
++	// Pod maintains the reference to the Pod.
++	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,1,opt,name=pod""`
++	// ExternalEntity maintains the reference to the ExternalEntity.
++	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,2,opt,name=externalEntity""`
++}
++
+ // GroupMember represents resource member to be populated in Groups.
+ // This supersedes GroupMemberPod, and will eventually replace it.
+ type GroupMember struct {",I did not see this is used in the controlplane API? Is it for internal use only? Then no need to define it here?,I don't see how this can be used outside of th
+9886,"@@ -138,7 +138,7 @@ void printDeviceProp(int deviceId) {
+     cout << setw(w1) << ""arch.hasSurfaceFuncs: "" << props.arch.hasSurfaceFuncs << endl;
+     cout << setw(w1) << ""arch.has3dGrid: "" << props.arch.has3dGrid << endl;
+     cout << setw(w1) << ""arch.hasDynamicParallelism: "" << props.arch.hasDynamicParallelism << endl;
+-    cout << setw(w1) << ""gcnArch: "" << props.gcnArch << endl;
++    cout << setw(w1) << ""gcnArchName: "" << props.gcnArchName << endl;
+     cout << setw(w1) << ""isIntegrated: "" << props.integrated << endl;
+     cout << setw(w1) << ""maxTexture1D: "" << props.maxTexture1D << endl;
+     cout << setw(w1) << ""maxTexture2D.width: "" << props.maxTexture2D[0] << endl;",Should we also add a line to print gcnArch?,"On a second thought, it would be nice if you c"
+9887,"@@ -87,6 +87,7 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
+         .replace('<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML""', '<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML"" flattenhtml=""true""')
+         .replace(pageVisibility, bravePageVisibility + pageVisibility)
+         .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
++        .replace(/Automatically sends usage statistics and crash reports to Brave/g, 'Automatically sends crash reports to Brave')
+         .replace(/The Chromium Authors/g, 'Brave Software Inc')
+         .replace(/Google Chrome/g, 'Brave')
+         .replace(/Chromium/g, 'Brave')","I merged already so need another PR, but I think this needs to be at the bottom.",nit: remove the space after `/g`
+9888,"@@ -150,6 +150,7 @@ bool ConfigManager::load()
+ 	boolean[ONLINE_OFFLINE_CHARLIST] = getGlobalBoolean(L, ""showOnlineStatusInCharlist"", false);
+ 	boolean[YELL_ALLOW_PREMIUM] = getGlobalBoolean(L, ""yellAlwaysAllowPremium"", false);
+ 	boolean[FORCE_MONSTERTYPE_LOAD] = getGlobalBoolean(L, ""forceMonsterTypesOnLoad"", true);
++	boolean[HOUSE_OWNED_BY_ACCOUNT] = getGlobalBoolean(L, ""houseOwnedByAccount "", false);
+
+ 	string[DEFAULT_PRIORITY] = getGlobalString(L, ""defaultPriority"", ""high"");
+ 	string[SERVER_NAME] = getGlobalString(L, ""serverName"", """");",space in key string?,This should be `HONY_OWNED_BY_ACCOUNT` for consistency.
+9889,"@@ -48,9 +48,13 @@ func (b *ProcessBuilder) Build() *ManagedProcess {
+ 	if len(b.nsOptions) > 0 {
+ 		args = append([]string{""--"", cmd}, args...)
+ 		for _, option := range b.nsOptions {
+-			args = append([]string{""-"" + nsArgMap[option.Typ] + option.Path}, args...)
++			args = append([]string{""-"" + nsArgMap[option.Typ], option.Path}, args...)
+ 		}
+-		cmd = ""nsenter""
++
++		if b.localMnt {
++			args = append([]string{""-l""}, args...)
++		}
++		cmd = nsexecPath
+ 	}
+
+ 	if b.pause {",The commends of this function should be updated,"`b.localMnt` is set to true if `b.nsOptions` is set, bu"
+9890,"@@ -48,6 +48,7 @@ class AnchorHead(nn.Module):
+                      type='DeltaXYWHBBoxCoder',
+                      target_means=(.0, .0, .0, .0),
+                      target_stds=(1.0, 1.0, 1.0, 1.0)),
++                 reg_decoded_bbox=False,
+                  background_label=None,
+                  loss_cls=dict(
+                      type='CrossEntropyLoss',",The docstring is outdated.,reg_decoded_bbox is not a valid input here.
+9891,"@@ -7,6 +7,9 @@ namespace Datadog.Trace
+     /// </summary>
+     public static class CorrelationIdentifier
+     {
++        internal static readonly string ServiceKey = ""dd.service"";
++        internal static readonly string VersionKey = ""dd.version"";
++        internal static readonly string EnvKey = ""dd.env"";
+         internal static readonly string TraceIdKey = ""dd.trace_id"";
+         internal static readonly string SpanIdKey = ""dd.span_id"";
+ ",Could rename to `ServiceVersionKey` for consistency with the suggestion to rename the TracerSetting.,Why are we not using the existing constants?
+9892,"@@ -826,6 +826,12 @@ def install(package, hash=None, version=None, tag=None, force=False):
+     store = PackageStore()
+     existing_pkg = store.get_package(owner, pkg)
+
++    if existing_pkg is not None and not force:
++        print(""{owner}/{pkg} already installed."".format(owner=owner, pkg=pkg))
++        overwrite = input(""Overwrite? (y/n) "")
++        if overwrite.lower() != 'y':
++            return
++
+     if version is not None:
+         response = session.get(
+             ""{url}/api/version/{owner}/{pkg}/{version}"".format(",I seem to recall a UI issue with this... @akarve I think you didn't like this for some reason...,Please use `output_json` instead of `input`
+9893,"@@ -84,7 +84,7 @@ class MediaBlockService extends BaseBlockService
+     /**
+      * {@inheritdoc}
+      */
+-    public function getDefaultSettings(OptionsResolverInterface $resolver)
++    public function setDefaultSettings(OptionsResolverInterface $resolver)
+     {
+         $resolver->setDefaults(array(
+             'media'    => false,",The `MediaBlockService` commit must be remove,Why did you change this? It does not look l
+9894,"@@ -239,11 +239,17 @@ rules:
+     maximum_retention: 365
+
+ """"""
++
++    def test_number_of_rules(self):
++        """"""The number of rules should be exactly the same as the length of SUPPORTED_RETENTION_RES_TYPES.""""""
++        rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
++        self.assertTrue(len(rre.SUPPORTED_RETENTION_RES_TYPES) == len(rules_engine.rule_book.resource_rules_map))
++
++
+     def test_only_max_normal_delete(self):
+         """"""Test that a bucket's rule can guarantee the maximum_retention if its
+         action is 'Delete' and the only condition is an age(<= maximum_retention)""""""
+         rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
+-        self.assertEqual(1, len(rules_engine.rule_book.resource_rules_map))
+
+         data_creater = frsd.FakeBucketDataCreater('fake_bucket', frsd.PROJECT1)
+         data_creater.AddLifecycleDict(action=""Delete"", age=365)","Use a literal constant here, and use `assertEqual`, e.g. `self.assertEqual(2, len(...))` You should also check that the number of rules is correct, i.e. 1 rule for buckets, 0 rules for tables.",Does it make sense to keep this assert stat
+9895,"@@ -15,8 +15,8 @@
+  * will expire before some files can be uploaded.
+  *
+  * The long-term solution to this problem is to change the upload pipeline so that files
+- * can be sent to the next step individually. That requires a breakig change, so it is
+- * planned for Uppy v2.
++ * can be sent to the next step individually. That requires a breaking change, so it is
++ * planned for Uppy v4.
+  *
+  * In the mean time, this plugin is stuck with a hackier approach: the necessary parts
+  * of the XHRUpload implementation were copied into this plugin, as the MiniXHRUpload",@Murderlon Should it just say `some future version`?,Can you add a `.` at the end of the sentenc
+9896,"@@ -122,12 +122,14 @@ func (c *Controller) syncCSPC(cspcGot *apis.CStorPoolCluster) error {
+ 		return nil
+ 	}
+
+-	cspcGot, err := c.populateVersion(cspcGot)
++	cspcObj := cspcGot
++	cspcObj, err := c.populateVersion(cspcObj)
+ 	if err != nil {
+ 		klog.Errorf(""failed to add versionDetails to CSPC %s:%s"", cspcGot.Name, err.Error())
+ 		return nil
+ 	}
+
++	cspcGot = cspcObj
+ 	pc, err := c.NewPoolConfig(cspcGot, openebsNameSpace)
+ 	if err != nil {
+ 		message := fmt.Sprintf(""Could not sync CSPC : failed to get pool config: {%s}"", err.Error())","change looks good.. but, better to make populateVersion to return same object in the case of error.. that avoids lot of complex logic and probable issues","@deads2k sorry for the delay in reviewing, but shouldn't this be inside the `if cspcGot != nil` block?"
+9897,"@@ -1358,6 +1358,10 @@ func (exp *Service) GetBlockOrActionByHash(hashStr string) (explorer.GetBlkOrAct
+ 		return explorer.GetBlkOrActResponse{Execution: &exe}, nil
+ 	}
+
++	if exe, err := exp.getAddressDetails(hashStr); err == nil {
++		return explorer.GetBlkOrActResponse{Address: &exe}, nil
++	}
++
+ 	return explorer.GetBlkOrActResponse{}, nil
+ }
+ ",invalid operation: exp (variable of type *Service) has no field or method getAddressDetails (from `typecheck`),I think this should be check for an error instead of just logging and returning a response.
+9898,"@@ -4479,7 +4479,8 @@ func TestKBFSOpsBackgroundFlush(t *testing.T) {
+
+ 	// start the background flusher
+ 	ops := getOps(config, rootNode.GetFolderBranch().Tlf)
+-	go ops.backgroundFlusher(1 * time.Millisecond)
++	config.SetBGFlushPeriod(1 * time.Millisecond)
++	go ops.backgroundFlusher()
+
+ 	// Make sure we get the notification
+ 	select {","Probably overkill, but maybe we should be using a fake clock here. I won't push on whatever you decide though.",why do we set it every time?
+9899,"@@ -690,7 +690,7 @@ func TestKBFSOpsConcurBlockSyncTruncate(t *testing.T) {
+
+ 	wg.Wait()
+
+-	// Do this in the main goroutine since t isn't goroutine safe,
++	// Do this in the main goroutine since it isn't goroutine safe,
+ 	// and do this after wg.Wait() since we only know it's set
+ 	// after the goroutine exits.
+ 	if syncErr != nil {","If you feel like it, may as well apply all the suggestions below to this test too.",s/it isn't goroutine safe/it is not goroutine safe/ ?
+9900,"@@ -94,9 +94,18 @@ public class LatLonShape {
+     return new Field[] {new LatLonTriangle(fieldName, lat, lon, lat, lon, lat, lon)};
+   }
+
++  /** create a query to find all indexed shapes that comply the {@link QueryRelation} with the provided point
++   **/
++  public static Query newPointQuery(String field, QueryRelation queryRelation, double lat, double lon) {
++    return new LatLonShapePointQuery(field, queryRelation, lat, lon);
++  }
++
+   /** create a query to find all polygons that intersect a defined bounding box
+    **/
+   public static Query newBoxQuery(String field, QueryRelation queryRelation, double minLatitude, double maxLatitude, double minLongitude, double maxLongitude) {
++    if (minLatitude == maxLatitude && minLongitude == maxLongitude) {
++      return newPointQuery(field, queryRelation, minLatitude, minLongitude);
++    }
+     return new LatLonShapeBoundingBoxQuery(field, queryRelation, minLatitude, maxLatitude, minLongitude, maxLongitude);
+   }
+ ",do we really need a relation or can we just assume INTERSECTS?,"I would not add this new method, instead add it to the existing `LatLonShapeQuery` class"
+9901,"@@ -16,7 +16,7 @@ import net.sourceforge.pmd.lang.java.oom.api.MetricVersion;
+  *
+  * @author Clément Fournier
+  */
+-public final class ParameterizedMetricKey {
++/* default */ final class ParameterizedMetricKey {
+
+     private static final Map<Integer, ParameterizedMetricKey> POOL = new HashMap<>();
+ ",Is this a `MetricKey` ?,Is this class still needed?
+9902,"@@ -49,6 +49,9 @@ public class Constants {
+   public static final int DEFAULT_SSL_PORT_NUMBER = 8443;
+   public static final int DEFAULT_JETTY_MAX_THREAD_COUNT = 20;
+
++  // One Schedule's default End Time: 01/01/2050, 00:00:00, UTC
++  public static final long DEFAULT_SCHEDULE_END_EPOCH_TIME = 2524608000000L;
++
+   public static class ConfigurationKeys {
+     // These properties are configurable through azkaban.properties
+ ",what's your rationale to pick up this date?,I think the default should be in `TimeUnit.SECONDS.toMillis(24)`
+9903,"@@ -11,6 +11,7 @@ import (
+ 	""strings""
+
+ 	""github.com/opencontainers/runc/libcontainer/cgroups""
++	""github.com/opencontainers/runc/libcontainer/cgroups/fscommon""
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ )
+ ","NIT: I'd have preferred that the new package be called ""utils"", but that's not a big deal.",Is this import needed?
+9904,"@@ -1,6 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+
++# Purpose
++# This code example demonstrates how to set the default encryption state for an
++# Amazon Simple Storage Solution (Amazon S3) bucket using server-side encryption (SSE)
++# with an AWS KMS customer master key (CMK).
++
++# snippet-start:[s3.ruby.s3_add_default_sse_encryption]
++
+ require 'aws-sdk-s3'
+
+ # Sets the default encryption state for an Amazon S3 bucket using",Simple Storage **Service**,Line is too long. [88/80]
+9905,"@@ -201,12 +201,15 @@ class GarbageCollector extends AbstractDataHandlerListener implements SingletonI
+         $indexQueueItems = $this->getIndexQueue()->getItems($table, $uid);
+         foreach ($indexQueueItems as $indexQueueItem) {
+             $site = $indexQueueItem->getSite();
++            $solrConfiguration = $site->getSolrConfiguration();
+
+             // a site can have multiple connections (cores / languages)
+             $solrConnections = $connectionManager->getConnectionsBySite($site);
+             foreach ($solrConnections as $solr) {
+                 $solr->deleteByQuery('type:' . $table . ' AND uid:' . intval($uid));
+-                $solr->commit(false, false, false);
++                if ($solrConfiguration->getEnableCommits()) {
++                    $solr->commit(false, false, false);
++                }
+             }
+         }
+     }","I think, retrieving the setting could also be done outside the loop. What do you think?",Can you move that line ou
+9906,"@@ -257,6 +257,7 @@ public class TransactionPool implements BlockAddedObserver {
+               transaction.getGasLimit(), chainHeadBlockHeader.getGasLimit()));
+     }
+
++    // TODO: this is where we would use the private state to do the validation against
+     return protocolContext
+         .getWorldStateArchive()
+         .get(chainHeadBlockHeader.getStateRoot())",This TODO isn't related to this change. We should remove it.,please file an issue for
+9907,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,This should not be finest
+9908,"@@ -1689,7 +1689,14 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+                         and subscript == subscript.parent.target
+                     ):
+                         # Ignore this subscript if it is the target of an assignment
+-                        continue
++                        if subscript.as_string() == subscript.parent.value.as_string():
++                            # Fire error as d[k] += d[k] has an unnecessary index lookup
++                            self.add_message(
++                                ""unnecessary-dict-index-lookup"",
++                                node=subscript,
++                                args=(node.target.elts[1].as_string()),
++                            )
++                        return  # Early termination; after reassignment dict index lookup will be necessary
+
+                     # Case where .items is assigned to k,v (i.e., for k, v in d.items())
+                     if isinstance(value, astroid.Name):","I'm not really sure this is worth it. Keep in mind that every special case we add has the potential to introduce new errors and complicates the code further. For common cases that is acceptable, but in this instance I don't think it's beneficial.",I think this should be `d[k]` instead of `d[k]`
+9909,"@@ -62,6 +62,11 @@ func (c *showCommand) Run(ctx context.Context, env *common_cli.Env, serverClient
+ 		return err
+ 	}
+
++	if agent.Selectors != nil {
++		for _, s := range agent.Selectors {
++			env.Printf(""Selectors     : %s:%s\n"", s.Type, s.Value)
++		}
++	}
+ 	return nil
+ }
+ ","nit: this `if` isn't necessary since we immediately follow it up with a range over the slice, which works fine with a `nil` slice.",is this meant to be here?
+9910,"@@ -3160,9 +3160,15 @@ void Game::playerChangeOutfit(uint32_t playerId, Outfit_t outfit)
+ 	}
+
+ 	Player* player = getPlayerByID(playerId);
++
+ 	if (!player) {
+ 		return;
+ 	}
++
++	const Outfit* playerOutfit = Outfits::getInstance()->getOutfitByLookType(player->getSex(), outfit.lookType);
++	if (!playerOutfit) {
++		outfit.lookMount = 0;
++	}
+
+ 	if (outfit.lookMount != 0) {
+ 		Mount* mount = mounts.getMountByClientID(outfit.lookMount);",Remove this line please.,shouldn't this be `outfit.lookMount = 0`?
+9911,"@@ -144,6 +144,7 @@ public class ZMSImpl implements Authorizer, KeyStore, ZMSHandler {
+     protected int domainNameMaxLen;
+     protected AuthorizedServices serverAuthorizedServices = null;
+     protected SolutionTemplates serverSolutionTemplates = null;
++    protected Map<String, Integer> eligibleTemplatesForAutoUpdate = null;
+     protected Map<String, String> serverPublicKeyMap = null;
+     protected boolean readOnlyMode = false;
+     protected boolean validateUserRoleMembers = false;",why is this is class field? it should be something local within the auto apply template method since we only need this once to process templates and never use again.,"Could be simplified to: `protected Map<String, "
+9912,"@@ -39,14 +39,14 @@ module.exports = function(grunt) {
+
+       const { diff: rolesTable, notes: rolesFootnotes } = getDiff(
+         roles,
+-        axe.commons.aria.lookupTable.role,
++        axe.utils.getStandards().ariaRoles,
+         listType
+       );
+
+       const ariaQueryAriaAttributes = getAriaQueryAttributes();
+       const { diff: attributesTable, notes: attributesFootnotes } = getDiff(
+         ariaQueryAriaAttributes,
+-        axe.commons.aria.lookupTable.attributes,
++        axe.utils.getStandards().ariaAttrs,
+         listType
+       );
+       const attributesTableMarkdown = mdTable([",I agree with Stephen it's better to invoke getStandards() only once.,"`ariaRoles` property is available in `custom-element.js` but not in `custom-element.js`. Unfortunately, `ariaAttrs` property is available in `custom-element.js` but not in `custom-element.js`. Unfortunately, `ariaAttrs` property is available in `custom-element.js`, but in `aria-describes` and `aria-describes` are not available in `custom-element.js`."
+9913,"@@ -198,7 +198,7 @@ class GridInterface(DictInterface):
+
+
+     @classmethod
+-    def canonicalize(cls, dataset, data, coord_dims=None):
++    def canonicalize(cls, dataset, data, coord_dims=None, irregular_dims=[]):
+         """"""
+         Canonicalize takes an array of values as input and
+         reorients and transposes it to match the canonical","After discussing what ``irregular_dims`` really is, we agreed that we need a better name that makes it clearer that this is more of an xarray concept of irregular dimensions than a holoviews one.","I think irregular_dims should be an optional argument, defaulting to [] will work for now"
+9914,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users.",Did you mean to leave this at info?
+9915,"@@ -222,11 +222,16 @@ th svg {
+ }
+
+ td {
++	white-space: nowrap;
+ 	font-size: 14px;
+ }
+
+ td:first-child {
+-	width: 50%;
++	width: 100%;
++}
++
++td:nth-child(2) {
++	padding: 0 20px 0 20px;
+ }
+
+ th:last-child,",this makes sure there is some padding space around the size column,Can we do this in a different pull request and then submit this PR?
+9916,"@@ -47,6 +47,7 @@ extern ""C"" {
+ #include ""Util/InputFileUtil.h""
+ #include ""Util/GraphLoader.h""
+ #include ""Util/StringUtil.h""
++#include ""Util/LuaUtil.h""
+
+ using namespace std;
+ ",Put these includes in alphabetical order,revert this please
+9917,"@@ -246,7 +246,12 @@ class JAB(Window):
+ 				continue
+ 			keyList=[]
+ 			# We assume alt  if there are no modifiers at all and its not a menu item as this is clearly a nmonic
+-			if (binding.modifiers&JABHandler.ACCESSIBLE_ALT_KEYSTROKE) or (not binding.modifiers and self.role!=controlTypes.ROLE_MENUITEM):
++			altModifier = binding.modifiers&JABHandler.ACCESSIBLE_ALT_KEYSTROKE
++			if not altModifier:
++				if not binding.modifiers and self.role!=controlTypes.ROLE_MENUITEM:
++					parent=self.parent
++					altModifier=isinstance(parent,JAB) and parent.role==controlTypes.ROLE_MENUBAR
++			if altModifier:
+ 				keyList.append(keyLabels.localizedKeyLabels['alt'])
+ 			if binding.modifiers&JABHandler.ACCESSIBLE_CONTROL_KEYSTROKE:
+ 				keyList.append(keyLabels.localizedKeyLabels['control'])",Can this just be an else?,Since controls are
+9918,"@@ -7,6 +7,7 @@ import torch.nn as nn
+ from mmcv.utils import print_log
+
+ from mmdet.core import auto_fp16
++from mmdet.utils import get_root_logger
+
+
+ class BaseDetector(nn.Module, metaclass=ABCMeta):",Merge this line with Line7,why import `get_ro
+9919,"@@ -19,7 +19,7 @@ module GeocoderHelper
+     html << result[:suffix] if result[:suffix]
+
+     if result[:type] and result[:id]
+-      html << content_tag(:small, :class => [""deemphasize"", ""search_details""]) do
++      html << content_tag(:small, :class => [""deemphasize"", ""search_details"", ""clearfix""]) do
+         link_to(t(""browse.#{result[:type]}_history.view_details""), :controller => :browse, :action => result[:type], :id => result[:id])
+       end
+     end",`clearfix` is needed to stop the `float:right` content overflowing the list item container.,Style/HashSyntax:
+9920,"@@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
+
+ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+ {
+-    [ParameterizedJobConfig(typeof(CoreConfig))]
++    [AspNetCoreBenchmark]
+     public class StringUtilitiesBenchmark
+     {
+         private const int Iterations = 500_000;",Can this be put on the assembly?,Why are we no longer using `ParameterizedJobConfig`?
+9921,"@@ -124,7 +124,8 @@ public class HealthCheckServlet extends HttpServlet {
+         if (results.isEmpty()) {
+             resp.setStatus(HttpServletResponse.SC_NOT_IMPLEMENTED);
+         } else {
+-            if (isAllHealthy(results)) {
++            final boolean alwaysOk = Boolean.parseBoolean(req.getParameter(""alwaysOk""));
++            if (alwaysOk || isAllHealthy(results)) {
+                 resp.setStatus(HttpServletResponse.SC_OK);
+             } else {
+                 resp.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);",Could we rename the parameter to `overrideStatusCode`? The name `alwaysOk` implies that the health check result would be always healthy.  ,"`req.getParameter()` is enough, you don't need the i"
+9922,"@@ -37,5 +37,9 @@ func (c *clusterApi) Routes() []*Route {
+ 		{verb: ""GET"", path: clusterSecretPath(""/defaultsecretkey"", cluster.APIVersion), fn: c.getDefaultSecretKey},
+ 		{verb: ""PUT"", path: clusterSecretPath(""/defaultsecretkey"", cluster.APIVersion), fn: c.setDefaultSecretKey},
+ 		{verb: ""POST"", path: clusterSecretPath(""/login"", cluster.APIVersion), fn: c.secretsLogin},
++		{verb: ""GET"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.listSchedPolicy},
++		{verb: ""POST"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.createSchedPolicy},
++		{verb: ""PUT"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.updateSchedPolicy},
++		{verb: ""DELETE"", path: clusterPath(""/schedpolicy/{name}"", cluster.APIVersion), fn: c.deleteSchedPolicy},
+ 	}
+ }","""/schedpolicy"" is repeated, i would make it a constant and use it here and cluster client.go",I think the `/schedpolicy` path should be changed to
+9923,"@@ -0,0 +1,14 @@
++module RSpec::Core::Ordering
++  class RandomOrdering
++    def order(items, configuration = RSpec.configuration)
++      Kernel.srand configuration.seed
++      ordering = items.shuffle
++      Kernel.srand # reset random generation
++      ordering
++    end
++
++    def built_in?
++      true
++    end
++  end
++end","Having a second `configuration` arg seems kinda odd to me as an interface. It looks like you're just using it as a form of dependency injection for the tests, right? Part of what makes it seem weird is that it's leaked into all the other orderers where they don't use `configuration` at all. Instead, what do you think about accepting the configuration in `initialize` (and having it default to `RSpec.configuration` in the same way)? To me, the config feels like a bit of state the instance should hold onto rather than being given each time `order` is called. It also means the other orderers wouldn't need to take the odd second argument. Thoughts?",Is this used anywhere?
+9924,"@@ -248,8 +248,9 @@ class AddonsDialog(
+ 		self.getAddonsButton = generalActions.addButton(self, label=_(""&Get add-ons...""))
+ 		self.getAddonsButton.Bind(wx.EVT_BUTTON, self.onGetAddonsClick)
+ 		# Translators: The label for a button in Add-ons Manager dialog to install an add-on.
+-		self.addButton = generalActions.addButton(self, label=_(""&Install...""))
+-		self.addButton.Bind(wx.EVT_BUTTON, self.onAddClick)
++		if not globalVars.appArgs.secure:
++			self.addButton = generalActions.addButton(self, label=_(""&Install...""))
++			self.addButton.Bind(wx.EVT_BUTTON, self.onAddClick)
+ 		# Translators: The label of a button in the Add-ons Manager to open the list of incompatible add-ons.
+ 		self.incompatAddonsButton = generalActions.addButton(self, label=_(""&View incompatible add-ons...""))
+ 		self.incompatAddonsButton.Bind(wx.EVT_BUTTON, self.onIncompatAddonsShowClick)",This button should also be disabled when in secure mode since it opens a web browser from which you can easily do a lot of insecure stuff.,I don't really understand why we need to have this special case. Can't the label just be empty?
+9925,"@@ -221,4 +221,11 @@ public interface Table {
+    * @return a {@link LocationProvider} to provide locations for new data files
+    */
+   LocationProvider locationProvider();
++
++  /**
++   * Create a new {@link ExpireTableMetadata expire API} to manage table metadata files in this table and commit.
++   *
++   * @return a new {@link ExpireTableMetadata}
++   */
++  ExpireTableMetadata expireTableMetadata();
+ }",Should this be done as part of `expireSnapshots`? I'd like to avoid adding a lot of operations to `Table` because it is already a large API.,This is a breaking API change. It may be breaking for anyone who is relying on this.
+9926,"@@ -0,0 +1,18 @@
++package libp2p
++
++import (
++	""github.com/libp2p/go-libp2p-core/helpers""
++	""github.com/libp2p/go-libp2p-core/network""
++)
++
++type Stream struct {
++	network.Stream
++}
++
++func (s *Stream) FullClose() error {
++	return helpers.FullClose(s)
++}
++
++func NewStream(stream network.Stream) *Stream {
++	return &Stream{Stream: stream}
++}",I do not think that this type (and its constructor) have to be exported.,why is this exported?
+9927,"@@ -55,7 +55,10 @@ func (r *receiptLog) SetData(data []byte) {
+ 	r.data = data
+ }
+
+-func (r *receiptLog) Build(ctx context.Context, err error) *action.Log {
++func (r *receiptLog) Build(ctx context.Context, err error, skipLogOnErr bool) *action.Log {
++	if err != nil && skipLogOnErr {
++		return nil
++	}
+ 	blkCtx := protocol.MustGetBlockCtx(ctx)
+ 	actionCtx := protocol.MustGetActionCtx(ctx)
+ ","why add this? don't think it's correct? for instance, it returns ErrCandidateNotExist (not critical), in this case we should return a receipt with corresponding status","if err is nil, why do we even need to log?"
+9928,"@@ -0,0 +1,6 @@
++package caddytls
++
++import ""github.com/xenolf/lego/acme""
++
++// ChallengeProvider type to be used in Caddy plugins over acme.ChallengeProvider directly, to avoid https://github.com/mattfarina/golang-broken-vendor
++type ChallengeProvider acme.ChallengeProvider","Instead of creating a new file, put this in tls.go, like right after or before DNSProviderConstructor is defined.",Why not the `ChallengeProvider` interface?
+9929,"@@ -62,7 +62,8 @@ app.controller('AttendeeController', function($scope, AutoCompletionService) {
+ 					'role': 'REQ-PARTICIPANT',
+ 					'rsvp': 'TRUE',
+ 					'partstat': 'NEEDS-ACTION',
+-					'cutype': 'INDIVIDUAL'
++					'cutype': 'INDIVIDUAL',
++					'language': OC.getLocale() // Use current user's timezone as a default value
+ 				}
+ 			});
+ 		}","Instead of OC.getLocale() for the default value the default should be the value of the user value 'core' 'lang'. When loading the page this can be added to the parameters by retrieving $this->config->getUserValue($user->getUID(), 'core', 'lang'); in viewcontroller.php.","This is the default timezone, not the curr"
+9930,"@@ -42,7 +42,7 @@ namespace interface1
+  * \param[in] id   Identifier of the result
+  * \return         Result that corresponds to the given identifier
+  */
+-classifier::quality_metric::binary_confusion_matrix::ResultPtr ResultCollection::getResult(QualityMetricId id) const
++classifier::quality_metric::binary_confusion_matrix::ResultPtr daal::algorithms::adaboost::quality_metric_set::interface1::ResultCollection::getResult(daal::algorithms::adaboost::quality_metric_set::QualityMetricId id) const
+ {
+     return staticPointerCast<classifier::quality_metric::binary_confusion_matrix::Result, SerializationIface>((*this)[(size_t)id]);
+ }",Why interface1 ? It should be in inner so.,There are a few more instances of the inte
+9931,"@@ -32,6 +32,16 @@ class User(UserMixin):
+             login_id=user['login_id'],
+         )
+
++    def to_dict(self):
++        return {
++            ""id"": self.id,
++            ""created"": self.created,
++            ""musicbrainz_id"": self.musicbrainz_id,
++            ""auth_token"": self.auth_token,
++            ""gdpr_agreed"": self.gdpr_agreed,
++            ""login_id"": self.login_id
++        }
++
+ @login_manager.user_loader
+ def load_user(user_login_id):
+     try:","Ideally, I'd have converted dicts to object but this way was less changes so this way for now.",Can we make it a `@property` instead? Then
+9932,"@@ -4061,8 +4061,17 @@ void t_c_glib_generator::generate_deserialize_field(ostream& out,
+       throw ""compiler error: no C reader for base type "" + t_base_type::t_base_name(tbase) + name;
+     }
+     out << "", error)) < 0)"" << endl;
+-    out << indent() << ""  return "" << error_ret << "";"" << endl << indent() << ""xfer += ret;""
+-        << endl;
++    if ((tbase != t_base_type::TYPE_STRING) && allocate) {
++      scope_up(out);
++      out << indent() << ""g_free (&"" << name << "");"" << endl;
++      out << indent() << ""return "" << error_ret << "";"" << endl;
++      scope_down(out);
++      out << indent() << ""xfer += ret;"" << endl;
++    }
++    else{
++      out << indent() << ""  return "" << error_ret << "";"" << endl << indent() << ""xfer += ret;""
++         << endl;
++    }
+
+     // load the byte array with the data
+     if (tbase == t_base_type::TYPE_STRING && type->is_binary()) {",Why is that test different to line 4022 (allocate is not tested there)? Shouldn't that be consistent?,Doesn't this need a scope_up too?
+9933,"@@ -472,7 +472,15 @@ ExWorkProcRetcode ExHbaseAccessInsertSQTcb::work()
+ 	  {
+ 	    rc = applyPred(scanExpr());
+ 	    if (rc == 1) // expr is true or no expr
+-	      step_ = CREATE_MUTATIONS;
++	      {
++		 rc = evalInsDelPreCondExpr();
++		 if (rc == -1)
++		   step_ = HANDLE_ERROR;
++		 else if (rc == 0)
++		   step_ = INSERT_CLOSE;
++		 else
++		   step_ = CREATE_MUTATIONS;
++	      }
+ 	    else if (rc == 0) // expr is false
+ 	      step_ = INSERT_CLOSE;
+ 	    else // error","Should we consider move this expression evaluation to SETUP_INSERT step since it evaluates from queue entry. Also, this expression is not evaluated in ExHbaseAccessVsbbUpsertTcb.",Nit: All of this could be a singl
+9934,"@@ -143,7 +143,8 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation
+             {
+                 Name = activity.DisplayName,
+
+-                Kind = (OtlpTrace.Span.Types.SpanKind)(activity.Kind + 1), // TODO: there is an offset of 1 on the enum.
++                // There is an offset of 1 on the Otlp enum.
++                Kind = (OtlpTrace.Span.Types.SpanKind)(activity.Kind + 1),
+
+                 TraceId = ByteStringCtorFunc(traceIdBytes),
+                 SpanId = ByteStringCtorFunc(spanIdBytes),",Don't see any more TODOs here..,Did you mean to delete this TODO?
+9935,"@@ -190,6 +190,13 @@ func (task *Task) DockerConfig(container *Container) (*docker.Config, *DockerCli
+ }
+
+ func (task *Task) dockerConfig(container *Container) (*docker.Config, *DockerClientConfigError) {
++	// Detect the name for S3 images
++	dockerImage := container.Image
++	if strings.HasPrefix(dockerImage, ""s3://"") {
++		slice := strings.Split(dockerImage, ""/"")
++		dockerImage = slice[len(slice)-1]
++	}
++
+ 	dockerVolumes, err := task.dockerConfigVolumes(container)
+ 	if err != nil {
+ 		return nil, &DockerClientConfigError{err.Error()}",Can you extract this out to a constant?,if there is more than one s3 imag
+9936,"@@ -452,12 +452,12 @@ def main(args):
+                 quiet_build=args.quiet_build,
+                 logfile=logfile
+             )
+-
+-            log_module = __load_module(""log"")
+             __update_if_key_exists(args, log_args, ""verbose"")
+
++            log_module = __load_module(""log"")
+             LOG.debug(""Calling LOG with args:"")
+             LOG.debug(log_args)
++
+             log_module.main(log_args)
+         elif 'logfile' in args:
+             logfile = args.logfile","any testcase for saargs, and tidyargs argument processing?",Why is this deleted?
+9937,"@@ -18,6 +18,7 @@ namespace Microsoft.Cci.Writers.CSharp
+         private bool _forCompilation;
+         private bool _forCompilationIncludeGlobalprefix;
+         private bool _forCompilationThrowPlatformNotSupported;
++        private string _platformNotSupportedExceptionMessage;
+         private bool _includeFakeAttributes;
+
+         public CSDeclarationWriter(ISyntaxWriter writer)",@ericstj do you think it is worth combining these two? With the presence of the message meaning it is enabled?,I think we can remov
+9938,"@@ -271,8 +271,8 @@ func (s *ec2Ops) DeviceMappings() (map[string]string, error) {
+ 		if d.DeviceName != nil && d.Ebs != nil && d.Ebs.VolumeId != nil {
+ 			devName := *d.DeviceName
+ 			// Per AWS docs EC instances have the root mounted at
+-			// /dev/sda1, this label should be skipped
+-			if devName == ""/dev/sda1"" {
++			// /dev/sda1, /dev/xvda this label should be skipped
++			if devName == ""/dev/sda1"" || devName == ""/dev/xvda"" {
+ 				continue
+ 			}
+ 			// AWS EBS volumes get mapped from /dev/sdN -->/dev/xvdN",why not use instance.RootDeviceName ?,Does it make sense t
+9939,"@@ -14,6 +14,7 @@
+
+ #include <ios>      //std::ios_base::failure
+ #include <iostream> //std::cout
++#include <fstream>  //std::ifstream
+ #include <mpi.h>
+ #include <stdexcept> //std::invalid_argument std::exception
+ #include <vector>","not needed, ADIOS2 also needs to check for subfiles. ADIOS2 tries to remove dependency on serial `fstream`.",Is fstream really ne
+9940,"@@ -50,6 +50,12 @@ class DatabaseDriverReactNative {
+ 		});
+ 	}
+
++	loadExtension(path) {
++		return new Promise(() => {
++			throw new Error(`No extension support for ${path} in react-native-sqlite-storage`);
++		});
++	}
++
+ 	exec(sql, params = null) {
+ 		return new Promise((resolve, reject) => {
+ 			this.db_.executeSql(",no need to wrap in new Promise - you can simply throw the exception,How about `No extension supported for ${path} in react-native-sqlite-storage`
+9941,"@@ -2438,3 +2438,17 @@ func getOCSPStatus(s tls.ConnectionState) (*ocsp.Response, error) {
+ 	}
+ 	return resp, nil
+ }
++
++func TestOCSPManualConfig(t *testing.T) {
++	o := DefaultTestOptions
++	o.HTTPHost = ""127.0.0.1""
++	o.HTTPSPort = -1
++	o.TLSConfig = &tls.Config{ServerName: ""localhost""}
++	cert, err := tls.LoadX509KeyPair(""configs/certs/server-cert.pem"", ""configs/certs/server-key.pem"")
++	if err != nil {
++		t.Fatalf(""Got error reading certificates: %s"", err)
++	}
++	o.TLSConfig.Certificates = []tls.Certificate{cert}
++	s := RunServer(&o)
++	s.Shutdown()
++}","Isn't this testing an implicit config, not a manual config?",Could you please move this function to `pkg/server/ocsp`?
+9942,"@@ -205,6 +205,12 @@ type Table struct {
+ 	// to what we calculate from chainToContents.
+ 	chainToDataplaneHashes map[string][]string
+
++	// chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
++	chainsToFullRules map[string][]string
++
++	// hashToFullRules contains a mapping of rule hashes to the full rules.
++	hashToFullRules map[string]string
++
+ 	// hashCommentPrefix holds the prefix that we prepend to our rule-tracking hashes.
+ 	hashCommentPrefix string
+ 	// hashCommentRegexp matches the rule-tracking comment, capturing the rule hash.","I don't think this is used any more, please remove.","Perhaps this should be called `chainToFullRules`, since it maps to full rules"
+9943,"@@ -42,9 +42,11 @@ func NewManager(mysteriumClient server.Client, dialogEstablisherFactory DialogEs
+ 	}
+ }
+
+-func (manager *connectionManager) Connect(id identity.Identity, nodeKey string) error {
++func (manager *connectionManager) Connect(myId identity.Identity, nodeKey string) error {
+ 	manager.status = statusConnecting()
+
++	providerId := identity.FromAddress(nodeKey)
++
+ 	proposals, err := manager.mysteriumClient.FindProposals(nodeKey)
+ 	if err != nil {
+ 		manager.status = statusError(err)",shouldn't we name abbreviations up-cased? `myId` -> `myID`?,What's the difference between `id` and `myId` here?
+9944,"@@ -287,7 +287,10 @@ export function recollectNodeTree(node, unmountOnly) {
+ 	else {
+ 		// If the node's VNode had a ref function, invoke it with null here.
+ 		// (this is part of the React spec, and smart for unsetting references)
+-		if (node[ATTR_KEY]!=null) applyRef(node[ATTR_KEY].ref, null);
++		if (node[ATTR_KEY]!=null) {
++			applyRef(node[ATTR_KEY].ref, null);
++			delete node[ATTR_KEY].ref;
++		}
+
+ 		if (unmountOnly===false || node[ATTR_KEY]==null) {
+ 			removeNode(node);","This just always calls refs. I think we need to either hoist ref invocation back out of `setProperty()` (it used to happen during rendering), or wait for component recycling to go away.",please add a space between the if and the delete
+9945,"@@ -618,7 +618,10 @@ func runTest(t *testing.T, test testT) {
+ 	defer test.builder.Stop()
+
+ 	c := &controller{}
+-	c.Register(test.builder.Context)
++	_, _, err := c.Register(test.builder.Context)
++	if err != nil {
++		t.Errorf(""Error registering the controller: %v"", err)
++	}
+ 	c.accountRegistry = &accountstest.FakeRegistry{
+ 		GetClientFunc: func(_ string) (acmecl.Interface, error) {
+ 			return test.acmeClient, nil",Oof. I may have missed this while reviewing #3805,How about using `assert.NoError()` here?
+9946,"@@ -3,8 +3,12 @@
+ // caffe::Caffe functions so that one could easily call it from matlab.
+ // Note that for matlab, we will simply use float as the data type.
+
+-#include <string>
+-#include <vector>
++// these need to be included after boost on OS X
++#include <string>  // NOLINT(build/include_order)
++#include <vector>  // NOLINT(build/include_order)
++#include <fstream>  // NOLINT
++#include <stdexcept>
++
+
+ #include ""mex.h""
+ ",why the NOLINTs here? please just alphabetize the headers (should be easier than adding NOLINTs) unless there's a good reason not to...,Is there a reason why you didn't use `std::vecto
+9947,"@@ -0,0 +1,5 @@
++export default function() {
++	return <div />;
++}
++
++export const ReactComponent = () => <div />;",Should we maybe return `<svg />` instead?,Do you need this? Can't you just do `<div />`?
+9948,"@@ -11,6 +11,7 @@ const Cats = require('../lib/status-cats');
+ const Storage = require('../lib/storage');
+ const _ = require('lodash');
+ const cors = require('cors');
++const load_plugins = require('../lib/plugin-loader').load_plugins;
+
+ module.exports = function(config_hash) {
+   // Config",Please use camelCase in new code,Can you call this `load_plugins`?
+9949,"@@ -14,5 +14,6 @@ return [
+ 	'selectLocale'  => 'Select one of the supported languages',
+ 	'contact'		=> 'Contact',
+ 	'contact-us'	=> 'Contact Us',
++    'places'        => 'Places',
+
+ ];","Looks like the whitespace is off here. Not sure if there's a space or two too many or if there is an issue with tabs vs. spaces, but you probably want to fix this :)",Why is this here?
+9950,"@@ -17,7 +17,12 @@
+ ## along with Invenio; if not, write to the Free Software Foundation, Inc.,
+ ## 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+
+-""""""Base bundles.""""""
++""""""Base bundles.
++
++.. note:: `bootstrap.js` bundle must be loaded after jQuery UI to avoid conflicts.
++    You can use `noConflict()` if you need to access functions
++    of jQuery UI covered by `bootstrap.js`.
++""""""
+
+ from invenio.ext.assets import Bundle
+ ",This was just my laziness and I didn't copy the first line. Just remove it together with one empty line. Thanks,I don't think this note is necess
+9951,"@@ -9,8 +9,8 @@ use Shopsys\FrameworkBundle\Model\Pricing\Vat\Vat;
+ use Shopsys\FrameworkBundle\Model\Pricing\Vat\VatData;
+ use Shopsys\FrameworkBundle\Model\Product\Availability\Availability;
+ use Shopsys\FrameworkBundle\Model\Product\Availability\AvailabilityData;
+-use Shopsys\FrameworkBundle\Model\Product\Product;
+-use Shopsys\FrameworkBundle\Model\Product\ProductDataFactory;
++use Shopsys\FrameworkBundle\Model\Product\ProductDataFactoryInterface;
++use Shopsys\ShopBundle\Model\Product\Product;
+ use Tests\ShopBundle\Test\DatabaseTestCase;
+
+ class CartItemTest extends DatabaseTestCase",Why did you decide to change CartItemTest but you didnt change QueryBuilderWithRowManipulatorDataSourceTest?,Why was this changed? It is a tes
+9952,"@@ -425,7 +425,15 @@ func (k *KeybaseServiceBase) LoadUserPlusKeys(ctx context.Context,
+ 	uid keybase1.UID, pollForKID keybase1.KID) (UserInfo, error) {
+ 	cachedUserInfo := k.getCachedUserInfo(uid)
+ 	if cachedUserInfo.Name != libkb.NormalizedUsername("""") {
+-		return cachedUserInfo, nil
++		if pollForKID == keybase1.KID("""") {
++			return cachedUserInfo, nil
++		}
++		// Skip the cache if pollForKID isn't present.
++		for _, key := range cachedUserInfo.VerifyingKeys {
++			if key.KID().Equal(pollForKID) {
++				return cachedUserInfo, nil
++			}
++		}
+ 	}
+
+ 	arg := keybase1.LoadUserPlusKeysArg{Uid: uid, PollForKID: pollForKID}","This was sort of a pre-existing bug -- we should be busting our local cache if the key isn't present. However, `KBPKIClient.HasVerifyingKey` already took care of it on that path. This way is better though.","@patrickxb why does this skip the cache if `pollForKID == """"`?"
+9953,"@@ -1,5 +1,6 @@
+ // Code generated by private/model/cli/gen-api/main.go. DO NOT EDIT.
+
++//go:build go1.15 && integration
+ // +build go1.15,integration
+
+ package cloudfront_test",Should this tag addition for generated files be handled explicitly in `private/model/cli/gen-api/main.go`,why is this build needed?
+9954,"@@ -4753,6 +4753,11 @@ public class MessagingController implements Runnable {
+      */
+     private void notifyAccount(Context context, Account account,
+             LocalMessage message, int previousUnreadMessageCount) {
++    	// if it's quiet time and notifications are disabled, then we shouldn't show a notification
++        if (K9.isQuietTime() && K9.getQuietTimeNotificationEnabled()) {
++            return;
++        }
++
+         final NotificationData data = getNotificationData(account, previousUnreadMessageCount);
+         synchronized (data) {
+             notifyAccountWithDataLocked(context, account, message, data);",You want to return if it's quiet time and notifications during quiet time are **not** enabled. So this is either a logic error or it's bad naming of the setting/field/method.,"Since this is called for every message, we can just check if `"
+9955,"@@ -28,14 +28,11 @@ Workshops::Application.configure do
+   config.log_level = :info
+   config.log_formatter = ::Logger::Formatter.new
+
+-  HOST = 'learn.thoughtbot.com'
+-  config.action_mailer.default_url_options = {host: HOST}
+-
+   config.middleware.use Rack::SslEnforcer,
+     hsts: false,
+     except: %r{^/podcast},
+     strict: true,
+-    redirect_to: ""https://#{HOST}""
++    redirect_to: ""https://#{ENV['APP_DOMAIN']}""
+
+   config.action_mailer.delivery_method = :smtp
+   config.action_mailer.smtp_settings = MAIL_SETTINGS",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,This is probably one of the most frustrating changes I have ma
+9956,"@@ -144,7 +144,12 @@ module Travis
+       def source_ssh?
+         return false if prefer_https?
+         repo_private? && !installation? or
+-          repo_private? && custom_ssh_key?
++          repo_private? && custom_ssh_key? or
++            force_private? && !installation?
++      end
++
++      def force_private?
++        source_host.exclude? 'github.com'
+       end
+
+       def source_host","cool, here (L146 && L148) maybe (repo_private? || force_private?) && !installation? to prevent double call of installation?",What do you think about adding a new method `repo_private?` and `force_private?` to the existing method `repo_private?` and `custom_ssh_key?` and deprecating the existing method `force_private?`?
+9957,"@@ -33,7 +33,7 @@ provide a working environment for development.`,
+ func appStart() {
+ 	app, err := platform.GetActiveApp("""")
+ 	if err != nil {
+-		util.Failed(""Failed to start: %s"", err)
++		util.Failed(""Failed to GetActiveApp err: %v"", err)
+ 	}
+
+ 	fmt.Printf(""Starting environment for %s...\n"", app.GetName())","this error carries a bit more meaning for us, but less meaning for users. we also lose the context of what command produced the failure. I'd prefer to keep the original error message. If we need better identification of GetActiveApp errors, maybe we could address that in the error messages it returns?",Did you mean to leave this change in?
+9958,"@@ -97,7 +97,7 @@ const (
+ const sendRouteSubsInGoRoutineThreshold = 1024 * 1024 // 1MB
+
+ // Warning when user configures cluster TLS insecure
+-const clusterTLSInsecureWarning = ""TLS Hostname verification disabled, system will not verify identity of the solicited route""
++const clusterTLSInsecureWarning = ""TLS certificate chain and hostname of solicited routes will not be verified, do not use in production!""
+
+ // Can be changed for tests
+ var routeConnectDelay = DEFAULT_ROUTE_CONNECT",Same: DO NOT USE IN PRODUCTION. Yes we should shout ;),"I am not sure about this message. What do you think about it? We don't need to know anything about this warning, it's just a bit confusing."
+9959,"@@ -134,7 +134,7 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+             await clientThrottle.WaitAsync();
+             string leaseId = string.Empty;
+             //this defines the lease for 15 seconds (max is 60) and 3000 milliseconds between requests
+-            AzureBlobLease blobLease = new AzureBlobLease(feed.AccountName, feed.AccountKey, string.Empty, feed.ContainerName, uploadPath, Log, ""15"", ""3000"");
++            AzureBlobLease blobLease = new AzureBlobLease(feed.AccountName, feed.AccountKey, string.Empty, feed.ContainerName, uploadPath, Log, ""15"", ""5000"");
+
+             bool isLeaseRequired = allowOverwrite && await feed.CheckIfBlobExists(uploadPath);
+ ","This change may be hiding more errors, if we continue to see more.",Can we make this magic number a constant?
+9960,"@@ -246,13 +246,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+
+         object IFeatureCollection.this[Type key]
+         {
+-            get => FastFeatureGet(key);
++            get => FastFeatureGet(key) ?? ConnectionFeatures?[key];
+             set => FastFeatureSet(key, value);
+         }
+
+         TFeature IFeatureCollection.Get<TFeature>()
+         {
+-            return (TFeature)FastFeatureGet(typeof(TFeature));
++            return (TFeature)(FastFeatureGet(typeof(TFeature)) ?? ConnectionFeatures?[typeof(TFeature)]);
+         }
+
+         void IFeatureCollection.Set<TFeature>(TFeature instance)",Beware of exposing the underlying features directly. Any mutable fields should be reset per request.,"Not sure about this one. `ConnectionFeatures[key]` returns `null` if the key doesn't exist, and `FastFeatureGet` throws an exception if the key doesn't exist. Should this be `?(TFeature)`?"
+9961,"@@ -144,12 +144,18 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		if (initialBase && base!==initialBase && inst!==initialChildComponent) {
+ 			let baseParent = initialBase.parentNode;
+ 			if (baseParent && base!==baseParent) {
+-				baseParent.replaceChild(base, initialBase);
+
+ 				if (!toUnmount) {
++					baseParent.replaceChild(base, initialBase);
+ 					initialBase._component = null;
+ 					recollectNodeTree(initialBase, false);
+ 				}
++				// @TODO Formerly the initialBase was always replaced by the base
++				//		 but somehow all tests passes also if its only called at not unmounting.
++				//       These else condition was the original fix.
++				// else {
++				// 	baseParent.insertBefore(base, initialBase);
++				// }
+ 			}
+ 		}
+ ","This is probably more nuanced than I can feasibly check in a PR review, haha. Was the issue here that `replaceChild()` removes `initialBase` from the DOM before `recollectNodeTree()` invokes `componentWillUnmount()` on the owning component?","The initialBase was always replaced by the base. This is another reason why the test was passing at not unmounting, so nothing to do here."
+9962,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked",Is there a test that checks whether a button is disabled?
+9963,"@@ -86,4 +86,8 @@ public class DataWriter<T> implements Closeable {
+     Preconditions.checkState(dataFile != null, ""Cannot create data file from unclosed writer"");
+     return dataFile;
+   }
++
++  public FileAppender<T> appender() {
++    return appender;
++  }
+ }",Do we need to expose it? It looks like it is only used in tests and only to obtain the final metrics. I think you can get the same by using `DataFile#lowerBounds` and `DataFile#upperBounds`. It seems `DataWriter` already exposes `toDataFile` that you can use.,Why `public FileAppender<T> appender()` and not just `public FileAppender<T>()`?
+9964,"@@ -868,7 +868,7 @@ describe(""date_utils"", function() {
+     });
+
+     it(""should return the 4 2021 year week"", () => {
+-      const date = new Date(""2021-01-18"");
++      const date = new Date(""2021-01-19"");
+       assert(getWeek(date) === 3);
+     });
+ ",the test was failing likely due to locale issue. had to increment the date by 1 to make it pass,Let's leave this one as it was. It's easy to change in the future if we need to.
+9965,"@@ -935,15 +935,8 @@ bool Levitate(const InstantSpell*, Creature* creature, const std::string& param)
+ bool InstantSpell::loadFunction(const pugi::xml_attribute& attr)
+ {
+ 	const char* functionName = attr.as_string();
+-	if (strcasecmp(functionName, ""levitate"") == 0) {
+-		function = Levitate;
+-	} else {
+-		std::cout << ""[Warning - InstantSpell::loadFunction] Function \"""" << functionName << ""\"" does not exist."" << std::endl;
+-		return false;
+-	}
+-
+-	scripted = false;
+-	return true;
++	std::cout << ""[Warning - InstantSpell::loadFunction] Function \"""" << functionName << ""\"" does not exist."" << std::endl;
++	return false;
+ }
+
+ bool InstantSpell::playerCastInstant(Player* player, std::string& param)",The changes below here can also be undone.,I don't think you should remove this function. It's used in the script.
+9966,"@@ -1,13 +1,14 @@
+ package channelq
+
+ import (
++	""context""
+ 	""fmt""
+ 	""strings""
+ 	""sync""
+
+ 	""k8s.io/klog""
+
+-	""github.com/kubeedge/beehive/pkg/core/context""
++	beehiveContext ""github.com/kubeedge/beehive/pkg/core/context""
+ 	""github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/common/model""
+ )
+ ","Instead of importing context besides beehivecontext, I'd suggest include golang context functionalities into beehivecontext. To keep channelq only rely on beehive.",remove this empty line
+9967,"@@ -88,6 +88,9 @@ public class AddProductNutritionFactsData {
+         PREFIX_NUTRIMENT_LONG_NAME + ""vitamin-k"",
+         PREFIX_NUTRIMENT_LONG_NAME + ""zinc""));
+
++    private AddProductNutritionFactsData() {
++    }
++
+     static String getCompleteEntryName(CustomValidatingEditTextView editText) {
+         return PREFIX_NUTRIMENT_LONG_NAME + editText.getEntryName();
+     }",I'm not sure about this one. Are you sure we don't need to initialize this fragment anywhere else?,This could be inlined.
+9968,"@@ -644,6 +644,7 @@ public class LocalInsightPlugin extends PluginBase implements PumpInterface, Con
+                 result.comment = ExceptionTranslator.getString(e);
+             }
+         } else if (detailedBolusInfo.carbs > 0) {
++            TreatmentsPlugin.getPlugin().addToHistoryTreatment(detailedBolusInfo, true);
+             result.success = true;
+             result.enacted = true;
+         }","You didn't set a source here, so it will probably fail.",Should we pass the detailedBolusInfo here?
+9969,"@@ -52,7 +52,7 @@ func TestHandlerSucces(t *testing.T) {
+ 	headers.Set(BaggageHeaderPrefix+""BAR"", ""baz"")
+
+ 	rpcHandler := transporttest.NewMockHandler(mockCtrl)
+-	httpHandler := handler{rpcHandler}
++	httpHandler := handler{rpcHandler, transport.NoDeps}
+
+ 	rpcHandler.EXPECT().Handle(
+ 		transporttest.NewContextMatcher(t,",Might be easier to just do `handler{Handler: rpcHandler}` since zero-value of `Deps` is now valid.,Why was this change necessary?
+9970,"@@ -15,6 +15,10 @@ module Faker
+       def quote
+         fetch('movie.quote')
+       end
++
++      def title
++        fetch('movie.title')
++      end
+     end
+   end
+ end",Could you please add docs for this method?,Why was this changed?
+9971,"@@ -132,9 +132,16 @@ public abstract class AbstractApexNode<T extends AstNode> extends AbstractNode i
+
+     @Override
+     public String toString() {
++        return getXPathNodeName();
++    }
++
++
++    @Override
++    public final String getXPathNodeName() {
+         return this.getClass().getSimpleName().replaceFirst(""^AST"", """");
+     }
+
++
+     public String getLocation() {
+         if (hasRealLoc()) {
+             return String.valueOf(node.getLoc());",we should probably `@Deprecated` this implementation to be removed in PMD 7.0.0,Why is this needed?
+9972,"@@ -242,7 +242,11 @@ module Bolt
+         end
+
+         def shell
+-          @shell ||= Bolt::Shell::Bash.new(target, self)
++          @shell ||= if target.options['login-shell'] == 'powershell'
++                       Bolt::Shell::Powershell.new(target, self)
++                     else
++                       Bolt::Shell::Bash.new(target, self)
++                     end
+         end
+
+         # This is used by the Bash shell to decide whether to `cd` before","I wonder if 'unix' makes more sense for this now? I was thinking of putting up a 'cleanup' PR - I think I missed a few ""remote"" var names in the first PR, and want to reassess unifying the transport classes that just define `with_connection`. Renaming this could be part of that.","@benhalpern is there a reason why you didn't use `Bolt::Shell::Powershell.new(target, self)`?"
+9973,"@@ -52,8 +52,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+         {
+             const string source = ""<results> <cppcheck version=\""12.34\"" /> <errors>   </errors> </results>"";
+             const string expected = @""{
+-  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0-beta.5"""",
+-  """"version"""": """"1.0.0-beta.5"""",
++  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0"""",
++  """"version"""": """"1.0.0"""",
+   """"runs"""": [
+     {
+       """"tool"""": {",Do something similar to what was done in JsonTests (can you derive from JsonTests?),@sandyhouse The tests are failing because of the `schemastore.org/sarif-1.0.0` version.
+9974,"@@ -15,4 +15,4 @@
+ #
+
+ # https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages
+-__path__ = __import__('pkgutil').extend_path(__path__, __name__)
++__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore","Yes, not much we can do here.","Same as above, I think we should avoid this `# type: ignore`."
+9975,"@@ -24,16 +24,16 @@ import (
+ 	""strings""
+ 	""time""
+
+-	""go.uber.org/zap""
++	_ ""knative.dev/pkg/metrics/testing""
+
+ 	cev2 ""github.com/cloudevents/sdk-go/v2""
+-
+ 	""github.com/cloudevents/sdk-go/v2/binding""
+ 	""github.com/cloudevents/sdk-go/v2/binding/transformer""
+ 	""github.com/cloudevents/sdk-go/v2/protocol""
+ 	""github.com/cloudevents/sdk-go/v2/protocol/http""
+ 	""github.com/google/knative-gcp/pkg/metrics""
+ 	""github.com/google/wire""
++	""go.uber.org/zap""
+ 	""knative.dev/eventing/pkg/kncloudevents""
+ 	""knative.dev/eventing/pkg/logging""
+ )",Why do we need this?,does this import really need to be moved here?
+9976,"@@ -0,0 +1,17 @@
++var bitcore = require('../bitcore');
++var Address = bitcore.Address;
++var bitcoreUtil = bitcore.util;
++var Script = bitcore.Script;
++var network = bitcore.networks.livenet;
++
++
++var script = ''; // write down your script here
++var s = Script.fromHumanReadable(script);
++var hash = bitcoreUtil.sha256ripe160(s.getBuffer());
++var version = network.addressScript;
++
++var addr = new Address(version, hash);
++var addrStr = addr.as('base58');
++
++// This outputs the ""address"" of thescript
++console.log(addrStr);",Would prefer to see an actual script here.,"Please remove this, it's unnecessary."
+9977,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,Path.toString() is not guaranteed to
+9978,"@@ -12,5 +12,4 @@ __all__ = [
+     'CustomDataset', 'XMLDataset', 'CocoDataset', 'VOCDataset', 'GroupSampler',
+     'DistributedGroupSampler', 'build_dataloader', 'to_tensor', 'random_scale',
+     'show_ann', 'get_dataset', 'ConcatDataset', 'RepeatDataset',
+-    'ExtraAugmentation'
+-]
++    'ExtraAugmentation']",This change is unnecessary.,Please don't remove trailing whitespa
+9979,"@@ -61,7 +61,11 @@ public final class MiniatureListWidget<E> extends ScrollPane {
+         this.mappedElements = new MappedList<Element<E>, E>(items, value -> {
+             Element newElement = converter.apply(value);
+
+-            newElement.setOnMouseClicked(event -> setOnMouseClicked.accept(newElement, event));
++            newElement.setOnMouseClicked(event -> {
++                unselectAll();
++                setOnMouseClicked.accept(newElement, event);
++                select(newElement);
++            });
+
+             return newElement;
+         });","Just as a note: Is it possible that the select css class is the same as the hover one? If this is true we should choose a different style for the selection css class, to make it more clear to the user I think.",Shouldn't we call `select()` in `setO
+9980,"@@ -106,6 +106,11 @@ type ControllerOptions struct {
+ 	EnablePprof bool
+
+ 	DNS01CheckRetryPeriod time.Duration
++
++	// Annotations copied Certificate -> CertificateRequest,
++	// CertificateRequest -> Order. Slice of string literals that are
++	// treated as prefixes for annotation keys.
++	CopiedAnnotations []string
+ }
+
+ const (","What about Secrets, are we not also trying to cover those?",Can we make this a `map[string]struct{}` for clarity?
+9981,"@@ -37,7 +37,7 @@
+ #include <jansson.h>
+
+ #include ""src/common/libutil/log.h""
+-#include ""src/common/libkvs/jansson_dirent.h""
++#include ""src/common/libkvs/treeobj.h""
+
+ #include ""commit.h""
+ #include ""kvs_util.h""",(commit messge): how about > update internal commit API for RFC 11,Please do not include this header. It is only needed
+9982,"@@ -27,7 +27,7 @@ var eventErrorStates = []string{
+ }
+
+ var waiters = []request.WaiterOption{
+-	request.WithWaiterDelay(request.ConstantWaiterDelay(3 * time.Second)), // Poll for cfn updates every 3 seconds.
++	request.WithWaiterDelay(request.ConstantWaiterDelay(5 * time.Second)), // How long to wait in between poll cfn for updates.
+ 	request.WithWaiterMaxAttempts(1800),                                   // Wait for at most 90 mins for any cfn action.
+ }
+ ","This will now wait for 2.5 hours, not 90 minutes, if the waiter delay is 5s",What's the differences between `5s` and `3s` on the s
+9983,"@@ -14,6 +14,7 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS ""AS IS"" AND
+ const EventUtil = {
+
+   trapEvent(event){
++    if(!event) return
+     event.preventDefault();
+     event.stopPropagation();
+     if(event.nativeEvent && event.nativeEvent.preventDefault){",See this error on console too so I don't think it's just test simulation. For some reason event doesn't show up sometimes,@jridgewell is this change intentional?
+9984,"@@ -44,7 +44,7 @@ func main() {
+ 		cmds.NewCRICTL(externalCLIAction(""crictl"", dataDir)),
+ 		cmds.NewCtrCommand(externalCLIAction(""ctr"", dataDir)),
+ 		cmds.NewCheckConfigCommand(externalCLIAction(""check-config"", dataDir)),
+-		cmds.NewEtcdSnapshotCommand(etcdsnapshotCommand, cmds.NewEtcdSnapshotSubcommands(etcdsnapshotCommand)),
++		cmds.NewEtcdSnapshotCommand(etcdsnapshotCommand, cmds.NewEtcdSnapshotSubcommands(etcdsnapshotCommand, etcdsnapshotCommand)),
+ 	}
+
+ 	if err := app.Run(os.Args); err != nil {",We're passing the same thing twice?,nit: can we move this command to `etcdsnapshot` command?
+9985,"@@ -245,7 +245,8 @@ func TestCreateInstance(t *testing.T) {
+ 				},
+ 				Spec: clusterv1.MachineSpec{
+ 					Bootstrap: clusterv1.Bootstrap{
+-						Data: pointer.StringPtr(""user-data""),
++						// echo ""user-data"" | base64
++						Data: pointer.StringPtr(""dXNlci1kYXRhCg==""),
+ 					},
+ 				},
+ 			},",Shouldn't the value in Bootstrap.Data be just a plain string?,"wouldn't it be better to set this as `user-data "" | base"
+9986,"@@ -209,7 +209,9 @@ namespace Datadog.Trace.AppSec
+         private void Report(ITransport transport, Span span, WafMatch[] results, bool blocked)
+         {
+             span.SetTag(Tags.AppSecEvent, ""true"");
+-            span.SetTraceSamplingPriority(SamplingPriority.UserKeep);
++            var samplingPirority = _settings.KeepTraces
++                ? SamplingPriority.UserKeep : SamplingPriority.AutoReject;
++            span.SetTraceSamplingPriority(samplingPirority);
+
+             LogMatchesIfDebugEnabled(results, blocked);
+ ","@robertpi Isn't this changing the sampling priority when `KeepTraces==false`? The sampling priority could be `AutoReject` or `AutoKeep`, based on the sampling decision (or the user may have specified something else). Seems like we shouldn't be changing it in this case?",Should we set it to AutoReject when KeepTraces is enable
+9987,"@@ -17,6 +17,11 @@ const (
+ 	DefaultCADir        = ""/etc/kubeedge/ca""
+ 	DefaultCertDir      = ""/etc/kubeedge/certs""
+
++	DefaultCAURL   = ""/ca.crt""
++	DefaultCertURL = ""/edge.crt""
++
++	DefaultCloudCoreReadyCheckURL = ""/readyz""
++
+ 	DefaultStreamCAFile   = ""/etc/kubeedge/ca/streamCA.crt""
+ 	DefaultStreamCertFile = ""/etc/kubeedge/certs/stream.crt""
+ 	DefaultStreamKeyFile  = ""/etc/kubeedge/certs/stream.key""",The const can also be used in cloud/pkg/cloudhub/servers/httpserver/server.go L46-47?,@tnozicka shouldn't this be /kubeedge/ca/edge.crt ?
+9988,"@@ -82,7 +82,7 @@ Blockly.Procedures.allProcedureMutations = function(root) {
+   var blocks = root.getAllBlocks();
+   var mutations = [];
+   for (var i = 0; i < blocks.length; i++) {
+-    if (blocks[i].type === 'procedures_prototype') {
++    if (blocks[i].type == 'procedures_prototype') {
+       var mutation = blocks[i].mutationToDom();
+       if (mutation) {
+         mutations.push(mutation);",Use a constant for `procedures_prototype`.,can we please use `===` for strict equality?
+9989,"@@ -12,7 +12,7 @@ def bad_percent(arg):
+
+ def good_percent(arg):
+     '''Instead of passing multiple arguments, format the message'''
+-    raise KeyError('Bad key: %r' % arg)
++    raise KeyError(f'Bad key: {arg!r}')
+
+ def bad_multiarg(name, value):
+     '''Raising a formatted string and multiple additional arguments'''",This file should probably not be touched as the formatting of the string seems to be a test in itself ?,This should probably be `{arg!r}` but feel f
+9990,"@@ -276,8 +276,11 @@ is_sys_kill(dcontext_t *dcontext, byte *pc, byte *xsp, siginfo_t *info);
+ int
+ sigaction_syscall(int sig, kernel_sigaction_t *act, kernel_sigaction_t *oact)
+ {
+-#if defined(X64) && !defined(VMX86_SERVER) && defined(LINUX)
++#if !defined(VMX86_SERVER) && defined(LINUX)
+     /* PR 305020: must have SA_RESTORER for x64 */
++    /* Must have SA_RESTORER to handle vsyscall32 being disabled
++       (see https://github.com/DynamoRIO/dynamorio/issues/2812)
++    */
+     if (act != NULL && !TEST(SA_RESTORER, act->flags)) {
+         act->flags |= SA_RESTORER;
+         act->restorer = (void (*)(void)) dynamorio_sigreturn;",style nit: missing leading '*',Is it possible to disable it for ARM64?
+9991,"@@ -184,7 +184,7 @@ public class PrivateTransactionProcessor {
+       messageFrameStack.addFirst(initialFrame);
+
+       while (!messageFrameStack.isEmpty()) {
+-        process(messageFrameStack.peekFirst(), operationTracer);
++        process(messageFrameStack.peekFirst(), OperationTracer.NO_TRACING);
+       }
+
+       if (initialFrame.getState() == MessageFrame.State.COMPLETED_SUCCESS) {",The operationTracer is passed into the processTransaction() method. We should probably pass the no tracing in one in from where it is called.,@Scottmitch why not `OperationTracer.NO_TRAC
+9992,"@@ -125,13 +125,10 @@ const (
+
+ // SPI on the Arduino Nano 33.
+ var (
+-	SPI0 = SPI{Bus: sam.SERCOM0_SPI,
+-		SCK:     SPI0_SCK_PIN,
+-		MOSI:    SPI0_MOSI_PIN,
+-		MISO:    SPI0_MISO_PIN,
+-		DOpad:   spiTXPad2SCK3,
+-		DIpad:   sercomRXPad0,
+-		PinMode: PinSERCOM}
++	SPI0 = SPI{
++		Bus:    sam.SERCOM0_SPI,
++		SERCOM: 0,
++	}
+ )
+
+ // I2S pins","I believe this line was an error, it should have been `sercomRXPad1` to be consistent with the pin numbers. Resolving this ambiguity by following the pin numbers.","Would it make sense to have a named constant for this one, so it's easier to change in the future?"
+9993,"@@ -0,0 +1,12 @@
++<div>
++  <p>
++    Hello,<br/>
++    The request, <%= @proposal.name %> (<%= @proposal.public_id %>), has been cancelled.
++  </p>
++</div>
++
++<p>
++  <strong>
++    <%= link_to ""View This Request"", proposal_url(@proposal), {target: 'C2'} %>
++  </strong>
++</p>","May be useful to have the reason here, though clearly not pressing.","Shouldn't this be ""cancelled""?"
+9994,"@@ -136,7 +136,7 @@ class GridInterface(DictInterface):
+                                 'of arrays must match. %s found that arrays '
+                                 'along the %s dimension do not match.' %
+                                 (cls.__name__, vdim.name))
+-            stack = np.stack if any(is_dask(arr) for arr in arrays) else dask_array_module().stack
++            stack = dask_array_module().stack if any(is_dask(arr) for arr in arrays) else np.stack
+             new_data[vdim.name] = stack(arrays, -1)
+         return new_data
+ ",These were inverted before,What's the motivation for this change?
+9995,"@@ -4227,6 +4227,11 @@ public class DBService {
+         return null;
+     }
+
++    public Map<String, DomainRoleMember> getReviewMembers() {
++        // Currently unimplemented
++        return new HashMap<>();
++    }
++
+     public void processExpiredPendingMembers(int pendingRoleMemberLifespan, final String monitorIdentity) {
+
+         final String auditRef = ""Expired - auto reject"";",DB is implemented in PR 951,Why not return an empty map instead?
+9996,"@@ -15,6 +15,16 @@ import (
+ 	""github.com/prometheus/client_golang/prometheus""
+ )
+
++const (
++	bytesToGB = 1073741824
++	bytesToMB = 1048567
++	micSec    = 1000000
++	bytesToKB = 1024
++	minwidth  = 0
++	maxwidth  = 0
++	padding   = 3
++)
++
+ // A gauge is a metric that represents a single numerical value that can
+ // arbitrarily go up and down.
+ ","move all constants to `pkg/util/constants.go`, these constants had been used in `volume_stats.go` file too. So better to import them.",Can these be moved to prometheus so they don't need to be duplicated?
+9997,"@@ -1,8 +1,8 @@
+ #appModules/winword.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2017 NV Access Limited, Manish Agrawal, Derek Riemer, Babbage B.V.
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# Copyright (C) 2006-2020 NV Access Limited, Manish Agrawal, Derek Riemer, Babbage B.V.
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+
+ import ctypes
+ import time",Could you revisit the full header and add appropriate spaces after the hashes?,Please don't change these copyrights.
+9998,"@@ -102,6 +102,11 @@ class CodeEditor extends FormWidgetBase
+      */
+     public $showPrintMargin = false;
+
++    /**
++     * @var string Hint to show above the code editor
++     */
++    public $codeHint = '';
++
+     //
+     // Object properties
+     //",This should either be `hint` that takes a string to render inside of the partial container or probably better you should just render a separate hint field above the code field in the same tab.,`@var string Hint to show above the code editor.`
+9999,"@@ -4330,7 +4330,7 @@ func TestJetStreamCrossAccountMirrorsAndSources(t *testing.T) {
+ 		t.Fatalf(""Did not receive correct response: %+v"", scResp.Error)
+ 	}
+
+-	checkFor(t, 2*time.Second, 100*time.Millisecond, func() error {
++	checkFor(t, 4*time.Second, 100*time.Millisecond, func() error {
+ 		si, err := js2.StreamInfo(""MY_SOURCE_TEST"")
+ 		if err != nil {
+ 			t.Fatalf(""Could not retrieve stream info"")",this was flapping,why did this need to change?
+10000,"@@ -185,6 +185,7 @@ namespace MvvmCross.Platforms.Ios.Views
+             }
+             else
+             {
++                keyboardFrame.Height -= scrollView.SafeAreaInsets.Bottom;
+                 scrollView.CenterView(activeView, keyboardFrame);
+             }
+         }",Please add a check to see if SafeAreaInsets is available. It isn't on all iOS versions.,The `SafeAreaInsets.Bottom` is used to move the active view to the bottom of the active scroll area.
+10001,"@@ -77,7 +77,7 @@ class RolesController < ApplicationController
+       # rubocop:disable LineLength
+       render json: {
+         code: 1,
+-        msg: _(""Successfully changed the permissions for #{@role.user.email}. They have been notified via email."")
++        msg: _(""Successfully changed the permissions for %{email}. They have been notified via email."") % { email: @role.user.email }
+       }
+       # rubocop:enable LineLength
+     else",interpolation here was causing the translation to not get picked up,"Shouldn't these be `_(""Successfully changed permissions for %{email} they have been notified via ema"
+10002,"@@ -69,8 +69,13 @@ StatelessWriter::StatelessWriter(
+
+ StatelessWriter::~StatelessWriter()
+ {
+-    AsyncWriterThread::removeWriter(*this);
+     logInfo(RTPS_WRITER,""StatelessWriter destructor"";);
++
++    mp_RTPSParticipant->async_thread().unregister_writer(this);
++
++    // After unregistering writer from AsyncWriterThread, delete all flow_controllers because they register the writer in
++    // the AsyncWriterThread.
++    flow_controllers_.clear();
+ }
+
+ void StatelessWriter::get_builtin_guid()",We don't need to disable the flow controller here as in `StatefulWriter`s destructor?,Doesn't this need to be inside the thread? Wouldn't `mp_RTPSParticipant->async_thread().unregister_w
+10003,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low.",why are we making this change to create_no_window?
+10004,"@@ -313,11 +313,17 @@ func (r *DefaultRuleRenderer) filterOutputChain() *Chain {
+ 	// That decision is based on pragmatism; it's generally very useful to be able to contact
+ 	// any local workload from the host and policing the traffic doesn't really protect
+ 	// against host compromise.  If a host is compromised, then the rules could be removed!
++	// However, we do apply policy to workload ingress traffic if it belongs to an IPVS connection.
+ 	for _, prefix := range r.WorkloadIfacePrefixes {
+-		// If the packet is going to a worklaod endpoint, RETURN.
++		// If the packet is going to a workload endpoint, apply workload ingress policy if traffic
++		// belongs to an IPVS connection and return at the end.
+ 		log.WithField(""ifacePrefix"", prefix).Debug(""Adding workload match rules"")
+ 		ifaceMatch := prefix + ""+""
+ 		rules = append(rules,
++			Rule{
++				Match:  Match().OutInterface(ifaceMatch).IPVSConnection(),
++				Action: JumpAction{Target: ChainToWorkloadDispatch},
++			},
+ 			Rule{
+ 				Match:  Match().OutInterface(ifaceMatch),
+ 				Action: ReturnAction{},","I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?",Do we need this rule? I don't think it is relevant for this change.
+10005,"@@ -60,3 +60,11 @@ func isABuildFile(name string, config *core.Configuration) bool {
+ 	}
+ 	return false
+ }
++
++// Max is an incredibly complicated function, which is presumably why it didn't make it into the Go stdlib
++func Max(x, y int) int {
++	if x < y {
++		return y
++	}
++	return x
++}",There's one for floats but not for ints. The float implementation is non-trivial though which I guess is the argument there.,I think the linter will complain about the lack of a line break her
+10006,"@@ -51,6 +51,9 @@ const (
+ 	// 6. QueryWorkflow
+ 	// please also reference selectedAPIsForwardingRedirectionPolicyWhitelistedAPIs
+ 	DCRedirectionPolicySelectedAPIsForwarding = ""selected-apis-forwarding""
++
++	// DCRedirectionPolicyAllAPIsForwarding means forwarding all APIs based on namespace active cluster
++	DCRedirectionPolicyAllAPIsForwarding = ""all-apis-forwarding""
+ )
+
+ type (","If we have a redirection policy for Selected API forwarding, why isn't ""redirect all"" just a special case where they are all Selected?",why is this in pkg/api/types.go?
+10007,"@@ -130,6 +130,8 @@ const (
+ 	FrameworkTally = ""tally""
+ 	// FrameworkOpentelemetry OpenTelemetry framework id
+ 	FrameworkOpentelemetry = ""opentelemetry""
++	// FrameworkCustom Custom framework id
++	FrameworkCustom = ""custom""
+ )
+
+ // tally sanitizer options that satisfy both Prometheus and M3 restrictions.",I wouldn't add this. Just completely ignore config if custom reporter is not `nil` in server options.,framework id should be `framework-custom`
+10008,"@@ -159,10 +159,19 @@ int main(int argc, char *argv[]) {
+
+     auto ioThreadPool = std::make_shared<folly::IOThreadPoolExecutor>(FLAGS_num_io_threads);
+
++    std::string clusteridFile =
++        folly::stringPrintf(""%s/%s"", paths[0].c_str(), ""/storage.cluster.id"");
++    auto clusterMan
++        = std::make_unique<nebula::meta::ClusterManager>("""", clusteridFile);
++    if (!clusterMan->loadClusterId()) {
++        LOG(INFO) << ""storaged misses clusterId"";
++    }
++
+     // Meta client
+     auto metaClient = std::make_unique<nebula::meta::MetaClient>(ioThreadPool,
+                                                                  std::move(metaAddrsRet.value()),
+                                                                  localhost,
++                                                                 clusterMan.get(),
+                                                                  true);
+     if (!metaClient->waitForMetadReady()) {
+         LOG(ERROR) << ""waitForMetadReady error!"";",What's the meaning about the code?,Please use `unique_ptr` to avoid any possible shadowing.
+10009,"@@ -172,7 +172,7 @@ public class WebViewLocalServer {
+       return null;
+     }
+
+-    if (isLocalFile(loadingUrl) || (bridge.getConfig().getString(""server.url"") == null && !bridge.getAppAllowNavigationMask().matches(loadingUrl.getHost()))) {
++    if (isLocalFile(loadingUrl) || loadingUrl.getHost().contains(bridge.getHost()) || (bridge.getServerUrl() == null && !bridge.getAppAllowNavigationMask().matches(loadingUrl.getHost()))) {
+       Logger.debug(""Handling local request: "" + request.getUrl().toString());
+       return handleLocalRequest(request, handler);
+     } else {","Would this incorrectly trigger if `loadingUrl.getHost() = ""something.app""` and `bridge.getHost() = ""app""`?","Is the extra `.getConfig().getString(""server.url"")` need"
+10010,"@@ -23,7 +23,11 @@ class AnchorHead(BaseDenseHead, BBoxTestMixin):
+         anchor_generator (dict): Config dict for anchor generator
+         bbox_coder (dict): Config of bounding box coder.
+         reg_decoded_bbox (bool): If true, the regression loss would be
+-            applied on decoded bounding boxes. Default: False
++            applied directly on decoded bounding boxes, meaning both the
++            predicted boxes and regression targets are with absolute
++            coordinates format. Default False. Note generally it should be
++            set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`
++            in the bbox head.
+         loss_cls (dict): Config of classification loss.
+         loss_bbox (dict): Config of localization loss.
+         train_cfg (dict): Training config of anchor head.",Note generally it -> It,Maybe add that `reg_decoded_bbox` is set to `True` when
+10011,"@@ -81,8 +81,7 @@ public abstract class ConfigSetService {
+               ) ? false: true;
+
+       SolrConfig solrConfig = createSolrConfig(dcore, coreLoader, trusted);
+-      IndexSchema indexSchema = createIndexSchema(dcore, solrConfig, false);
+-      return new ConfigSet(configSetName(dcore), solrConfig, force -> indexSchema, properties, trusted);
++      return new ConfigSet(configSetName(dcore), solrConfig, force -> createIndexSchema(dcore, solrConfig, force), properties, trusted);
+     } catch (Exception e) {
+       throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
+           ""Could not load conf for core "" + dcore.getName() +",Does this mean that every call to `configSet.getIndexSchema()` will create a new schema object (if shared schema is not enabled)?,I think we can remove this method altogether and just ca
+10012,"@@ -1,12 +1,11 @@
+ /*
+- * Licensed to the Apache Software Foundation (ASF) under one or more
+- * contributor license agreements.  See the NOTICE file distributed with
+- * this work for additional information regarding copyright ownership.
+- * The ASF licenses this file to You under the Apache License, Version 2.0
+- * (the ""License""); you may not use this file except in compliance with
+- * the License.  You may obtain a copy of the License at
++ * Copyright 2017 Huawei Technologies Co., Ltd
+  *
+- *     http://www.apache.org/licenses/LICENSE-2.0
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an ""AS IS"" BASIS,",License header should use the Apache one.,why change the copyright year?
+10013,"@@ -107,6 +107,8 @@ func (globber *Globber) Glob(rootPath string, includes, excludes []string, inclu
+ 		matches, err := globber.glob(rootPath, include, excludes, includeHidden, includeSymlinks)
+ 		if err != nil {
+ 			panic(fmt.Errorf(""error globbing files with %v: %v"", include, err))
++		} else if len(matches) == 0 {
++			panic(fmt.Errorf(""No matches found for this glob""))
+ 		}
+ 		// Remove the root path from the returned files and add them to the output
+ 		for _, filename := range matches {","I think this makes more sense to be applied within the parser code where we evaluate the `glob` builtin? This function looks generic in the sense of where it can be used, and perhaps no matches is fine in other cases?",nit: `No matches found for thi
+10014,"@@ -226,6 +226,14 @@ func NewConfig(ec2client ec2.EC2MetadataClient) (*Config, error) {
+ 	}
+ 	config := &envConfig
+
++	if config.OnPrem.Enabled() {
++		if config.AWSRegion == """" {
++			return nil, errors.New(""AWS_DEFAULT_REGION has to be set when running on-premises"")
++		}
++		// Use fake ec2 metadata client if on prem config is set.
++		ec2client = ec2.NewBlackholeEC2MetadataClient()
++	}
++
+ 	if config.complete() {
+ 		// No need to do file / network IO
+ 		return config, nil",should we validate that AWSRegion has also been set here so that we don't get into the if-block that relies on the ec2 metadata client below?,I am wondering if we should mo
+10015,"@@ -89,11 +89,13 @@ class ThriftRequestHandler():
+                  checker_md_docs,
+                  checker_md_docs_map,
+                  suppress_handler,
+-                 db_version_info):
++                 db_version_info,
++                 version):
+
+         self.__checker_md_docs = checker_md_docs
+         self.__checker_doc_map = checker_md_docs_map
+         self.__suppress_handler = suppress_handler
++        self.__version = version
+         self.__session = session
+
+     def __queryReport(self, reportId):",maybe naming `version` to `package_version` or something similar can be more descriptive,Do you need to pass `version`
+10016,"@@ -235,7 +235,7 @@ class MessageTypeToType extends ParquetTypeVisitor<Type> {
+     return current;
+   }
+
+-  private int getId(org.apache.parquet.schema.Type type) {
++  protected int getId(org.apache.parquet.schema.Type type) {
+     org.apache.parquet.schema.Type.ID id = type.getId();
+     if (id != null) {
+       return id.intValue();",Why was this changed?,Why the change to `protected`?
+10017,"@@ -1,3 +1,4 @@
++//go:build !arm64
+ // +build !arm64
+
+ package nodeps","Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these",Is this line needed?
+10018,"@@ -1,10 +1,10 @@
+ module OrgAdmin
+   class PlansController < ApplicationController
+-    after_action :verify_authorized
+-
++    # GET org_admin/plans
+     def index
+-      authorize Plan
+-
++      # Test auth directly and throw Pundit error sincePundit is unaware of namespacing
++      raise Pundit::NotAuthorizedError unless current_user.present? && current_user.can_org_admin?
++
+       vals = Role.access_values_for(:reviewer)
+       @feedback_plans = Plan.joins(:roles).where('roles.user_id = ? and roles.access IN (?)', current_user.id, vals)
+       @plans = current_user.org.plans","Pundit is unaware of namespacing, however you can still create the class under policies/org_admin/plans_policy.rb. That means, the condition for the unless can be reused in other places too. You would call the policy as OrgAdmin::PlansPolicy.new(current_user).index? after that unless",**suggestion (non-blocking):**
+10019,"@@ -203,6 +203,13 @@ public class PMD {
+             return 0;
+         }
+
++        // Log warning only once, if not explicitly disabled
++        if (!configuration.isIgnoreIncrementalAnalysis() && LOG.isLoggable(Level.WARNING)) {
++            final String version = PMDVersion.isUnknown() || PMDVersion.isSnapshot() ? ""latest"" : ""pmd-"" + PMDVersion.VERSION;
++            LOG.warning(""This analysis could be faster, please consider using Incremental Analysis: ""
++                                + ""https://pmd.github.io/"" + version + ""/pmd_userdocs_getting_started.html#incremental-analysis"");
++        }
++
+         Set<Language> languages = getApplicableLanguages(configuration, ruleSets);
+         List<DataSource> files = getApplicableFiles(configuration, languages);
+ ",this warning shouldn't be produced if we configured a cache either,I think we should move this lo
+10020,"@@ -16,6 +16,7 @@ describe('examples(change-stream):', function() {
+     client = await this.configuration.newClient().connect();
+     db = client.db(this.configuration.db);
+
++    await db.createCollection('inventory');
+     await db.collection('inventory').deleteMany({});
+   });
+ ",what if the collection is already there?,why is this needed?
+10021,"@@ -24,8 +24,7 @@ import java.io.OutputStream;
+ import java.util.Base64;
+
+ /**
+- * Defines the output type for a screenshot. See org.openqa.selenium.Screenshot for usage and
+- * examples.
++ * Defines the output type for a screenshot.
+  *
+  * @see TakesScreenshot
+  * @param <T> Type for the screenshot output.",instead of removing can you reference org.openqa.selenium.TakesScreenshot ?,Why did you remove
+10022,"@@ -644,4 +644,6 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem
+             }
+         }
+     }
++
++
+ }",Please revert unrelated changes,Please revert unrel
+10023,"@@ -1224,6 +1224,11 @@ var AppRouter = Backbone.Router.extend({
+             path: [countlyGlobal.cdn + 'localization/min/'],
+             mode: 'map',
+             callback: function() {
++                if (countlyGlobal.company) {
++                    for (var key in jQuery.i18n.map) {
++                        jQuery.i18n.map[key] = jQuery.i18n.map[key].replace(""Countly"", countlyGlobal.company);
++                    }
++                }
+                 self.origLang = JSON.stringify(jQuery.i18n.map);
+             }
+         });","As far as I know, this will replace only first occurance of Countly, not others, if there are more than one Countly word in localized string",I think this is a l
+10024,"@@ -111,9 +111,9 @@ public class LocalRepository implements Repository {
+
+                     if (StringUtils.isBlank(jsonTypeDTO.getId())) {
+                         if (!StringUtils.isBlank(jsonTypeDTO.getName())) {
+-                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9]"", """"));
++                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9_]"", """"));
+                         } else {
+-                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9]"", """"));
++                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9_]"", """"));
+                         }
+                     }
+ ","I suggest, that we move the regex (`[^a-zA-Z0-9_]`) to a separate constant field, because we're using it in multiple places and I think it's quite prone to misspellings.",why this change? is it related to the issue?
+10025,"@@ -1,7 +1,7 @@
+ import logging
+ import time
+ from collections import OrderedDict, defaultdict
+-from typing import Iterable, Optional
++from typing import Dict, Iterable, List, Optional, Union
+
+ from dagster import check
+ from dagster.core.definitions.events import AssetKey","Feel free to disregard, but I've been trying to use `Mapping` and `Sequence` instead of `Dict` and `List` when possible, because they communicate that the type is immutable, and also are covariant.",This is getting too big. We should split thi
+10026,"@@ -27,6 +27,9 @@ import (
+ 	""testing""
+ 	""time""
+
++	""github.com/nats-io/jwt/v2""
++	""github.com/nats-io/nkeys""
++
+ 	""github.com/nats-io/nats.go""
+ )
+ ",No need for blank line here. This block will then be reordered alphabatically.,Can we put this in alphabetical order?
+10027,"@@ -5,9 +5,14 @@ import (
+ 	""fmt""
+
+ 	k8s ""k8s.io/client-go/kubernetes""
++	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/clientcmd""
+ )
+
++const (
++	localCluster = ""local""
++)
++
+ type ClientsetManager interface {
+ 	Clientsets() map[string]ContextClientset
+ 	GetK8sClientset(clientset, cluster, namespace string) (ContextClientset, error)",let's call it `in-cluster` instead of `local`. less chance of confusion.,Maybe rename to `localClusterPrefix` to indi
+10028,"@@ -95,6 +95,8 @@ class Product extends BaseAction implements EventSubscriberInterface
+             $con->beginTransaction();
+
+             try {
++                $prev_ref = $product->getRef();
++
+                 $product
+                     ->setDispatcher($event->getDispatcher())
+                     ->setRef($event->getRef())",Please use camelCase instead of underscore_case,`$prev_ref` is not used anywhere.
+10029,"@@ -87,7 +87,8 @@ def get_contents(bucket, key, ext, *, etag, version_id, s3_client, size):
+                 s3_client=s3_client,
+                 version_id=version_id
+             )
+-            content = extract_parquet(get_bytes(obj[""Body""], compression), as_html=False)[0]
++            body, info = extract_parquet(get_bytes(obj[""Body""], compression), as_html=False)
++            content = trim_to_bytes(f""{str(info)}\n{body}"", ELASTIC_LIMIT_BYTES)
+         else:
+             content = get_plain_text(
+                 bucket,","Ideally, we'd fold the schema into an expanded system_meta, but this is a good first step.",Nit: `body` will always be a byte
+10030,"@@ -95,6 +95,7 @@ public class TableMetadataParser {
+   static final String SNAPSHOT_ID = ""snapshot-id"";
+   static final String TIMESTAMP_MS = ""timestamp-ms"";
+   static final String SNAPSHOT_LOG = ""snapshot-log"";
++  static final String FIELDS = ""fields"";
+
+   public static void overwrite(TableMetadata metadata, OutputFile outputFile) {
+     internalWrite(metadata, outputFile, true);",Is this used?,"Let's rename this to ""snapshot-fi"
+10031,"@@ -16,7 +16,7 @@
+
+ using System;
+ using System.Diagnostics;
+-#if NET45 || NET46
++#if NET452 || NET46
+ using System.Diagnostics.CodeAnalysis;
+ using System.Threading;
+ #endif",Should we use `#if NETFRAMEWORK` for consistency with the other projects?,What's the reason for this change
+10032,"@@ -46,7 +46,12 @@ type DecodedContainerRecord struct {
+
+ func (d *ContianerRecordDecoder) DecodeContainerRecord(ctx context.Context, record *v1alpha1.Record) (decoded DecodedContainerRecord, err error) {
+ 	var pod v1.Pod
+-	podId, containerName := controller.ParseNamespacedNameContainer(record.Id)
++	podId, containerName, err := controller.ParseNamespacedNameContainer(record.Id)
++	if err != nil {
++		// TODO: organize the error in a better way
++		err = NewFailToFindContainer(pod.Namespace, pod.Name, containerName, err)
++		return
++	}
+ 	err = d.Client.Get(ctx, podId, &pod)
+ 	if err != nil {
+ 		// TODO: organize the error in a better way","If it parses failed, both of the `containerName` and `podId` should be the empty strings, it's non-sense to define this error, I suggest just return it.",Is this an error that should be reported to the user?
+10033,"@@ -61,17 +61,6 @@ export default Service.extend({
+         }
+     },
+
+-    sendTestRequest(testApplicationId) {
+-        let url = `${API_URL}/photos/random`;
+-        let headers = {};
+-
+-        headers.Authorization = `Client-ID ${testApplicationId}`;
+-        headers['Accept-Version'] = API_VERSION;
+-
+-        return fetch(url, {headers})
+-            .then((response) => this._checkStatus(response));
+-    },
+-
+     actions: {
+         updateSearch(term) {
+             if (term === this.get('searchTerm')) {","line 26 can be removed i think > applicationId: or('config.unsplashAPI.applicationId', 'settings.unsplash.applicationId'),",`sendTestRequest` was only used in one place so I jus
+10034,"@@ -340,9 +340,9 @@ void Config::CheckParamConflict() {
+     Log::Warning(""CUDA currently requires double precision calculations."");
+     gpu_use_dp = true;
+   }
+-  // linear tree learner must be serial type and cpu device
++  // linear tree learner must be serial type and run on cpu device
+   if (linear_tree) {
+-    if (device_type == std::string(""gpu"")) {
++    if (device_type != std::string(""cpu"")) {
+       device_type = ""cpu"";
+       Log::Warning(""Linear tree learner only works with CPU."");
+     }",To generalize for possible future new enum options.,Maybe add a `Log::Warning` that the learner only work
+10035,"@@ -877,6 +877,9 @@ def main(argv):
+             from scapy.arch.windows import route_add_loopback
+             route_add_loopback()
+
++        # Add SCAPY_ROOT_DIR environment variable, used for tests
++        os.environ['SCAPY_ROOT_DIR'] = os.environ.get(""PWD"", os.getcwd())
++
+     except getopt.GetoptError as msg:
+         print(""ERROR:"", msg, file=sys.stderr)
+         raise SystemExit",Shall we remove this variable at the end of UTScapy execution?,"I'm not sure if this is really necessary, but I think"
+10036,"@@ -29,6 +29,10 @@ public class ProtoModels {
+
+   /** Gets the interfaces for the apis in the service config. */
+   public static List<Interface> getInterfaces(Model model) {
++    if (model.getServiceConfig().getApisCount() == 0) {
++      // A valid service config was not given.
++      return model.getSymbolTable().getInterfaces().asList();
++    }
+     return model
+         .getServiceConfig()
+         .getApisList()",What is this checking for? Why is returning the list of interfaces the correct behaviour in this case?,"instead of doing this, maybe we can have a method `getServiceConfig()` that returns an empty list if there are no service config? that way we can avoid the code duplication"
+10037,"@@ -20,6 +20,9 @@ namespace Nethermind.Blockchain
+ {
+     public interface ISyncConfig : IConfig
+     {
++        [ConfigItem(Description = ""HMB Sync."", DefaultValue = ""false"")]
++        bool HmbSync { get; set; }
++
+         [ConfigItem(Description = ""If set to 'true' then the Fast Sync (eth/63) synchronization algorithm will be used."", DefaultValue = ""false"")]
+         bool FastSync { get; set; }
+         ",Please name it correctly as Beam ;),why do we need a separate config for HmbSync? Shouldn't it just be a sync setting?
+10038,"@@ -184,9 +184,9 @@ func shouldRetryWithWait(tripper http.RoundTripper, err error, multiplier int) b
+ 	apiErr, ok := err.(*googleapi.Error)
+ 	var retry bool
+ 	switch {
+-	case !ok && tkValid:
+-		// Not a googleapi.Error and the token is still valid.
+-		return false
++	case !ok:
++		// Not a googleapi.Error. Likely a transport error.
++		retry = true
+ 	case apiErr.Code >= 500 && apiErr.Code <= 599:
+ 		retry = true
+ 	case apiErr.Code >= 429:","After chatting with Andrew, we think it's better to look for this particular error string that is causing issues (""connection reset by peer"") instead of blindly retrying on any error we don't know about.",we don't want to retry in case of an API error?
+10039,"@@ -25,14 +25,14 @@ namespace AutoRest.Swagger.Validation.Core
+         /// <summary>
+         /// What kind of open api document type this rule should be applied to
+         /// </summary>
+-        public virtual ServiceDefinitionDocumentType ServiceDefinitionDocumentType => ServiceDefinitionDocumentType.ARM;
++        public abstract ServiceDefinitionDocumentType ServiceDefinitionDocumentType { get; }
+
+         /// <summary>
+         /// When to apply the validation rule, before or after it has been merged as a part of
+         /// its merged document as specified in the corresponding '.md' file
+         /// By default consider all rules to be applied for After only
+         /// </summary>
+-        public virtual ServiceDefinitionDocumentState ValidationRuleMergeState => ServiceDefinitionDocumentState.Composed;
++        public abstract ServiceDefinitionDocumentState ValidationRuleMergeState { get; }
+
+         /// <summary>
+         /// Violation category of the Rule.",any reason to not have defaults here like you had before? (ARM)?,"This is a breaking change. I don't think anyone is using this property in the final version, so I think keeping this virtual would be fine."
+10040,"@@ -1,4 +1,3 @@
+-<% page_info = paginate_params(@response) %>
+ <%= tag :meta, :name => ""totalResults"", :content => @response.total %>
+-<%= tag :meta, :name => ""startIndex"", :content => (page_info.current_page == 1 ? 1 : @response.start ) %>
+-<%= tag :meta, :name => ""itemsPerPage"", :content => page_info.limit_value %>
++<%= tag :meta, :name => ""startIndex"", :content => @response.start %>
++<%= tag :meta, :name => ""itemsPerPage"", :content => @response.limit_value %>","This is a change. The old code was just wrong before, but now here (and one other machine-readable place) we expose the start index as 0 for the first item.","I think you can delete the `paginate_params` method entirely, it's not used anywhere else."
+10041,"@@ -178,11 +178,11 @@ namespace RDKit {
+     };
+   } // end of SLNParse namespace
+
+-  RWMol *SLNToMol(std::string sln,bool sanitize,int debugParse){
++  RWMol *SLNToMol(const std::string &sln,bool sanitize,int debugParse){
+     // FIX: figure out how to reset lexer state
+     yysln_debug = debugParse;
+     // strip any leading/trailing whitespace:
+-    boost::trim_if(sln,boost::is_any_of("" \t\r\n""));
++    //boost::trim_if(sln,boost::is_any_of("" \t\r\n""));
+
+     RWMol *res = SLNParse::toMol(sln,false,debugParse);
+     if(res){","This changes the behavior of the parser, right? Any particular reason to do this aside from the fact that you have to since the function takes a const?",remove this line ?
+10042,"@@ -17,5 +17,16 @@ function Portal(props) {
+  * @param {import('./internal').PreactElement} container The DOM node to continue rendering in to.
+  */
+ export function createPortal(vnode, container) {
++	// Note: We can't use Fragment here because a component that returned a Portal
++	// (e.g. `const App = () => createPortal(...)`) wouldn't work. Our diff
++	// collapses Fragments without keys that are returned directly from components
++	// into just an array and sets that as the children array of the component.
++	//
++	// We also can't use keyed Fragments here cuz it might lead to weird edge
++	// cases when toggling between two sibling portals if we use a shared keyed or
++	// lead to unnecessary re-mounts if trying to generate a new key on each call.
++	//
++	// So the simplest solution seems to be just to use an unique type for Portal
++	// to skip the Fragment collapsing logic when diffing components
+ 	return createElement(Portal, { _parentDom: container }, vnode);
+ }","Given how simple the Portal implementation is, I wonder if we should move it core... Though we'd have to export it which would be more bytes we can't crawl back...",Small nit: I don't think we need this note anymore since `createPortal` doesn't return a `
+10043,"@@ -348,6 +348,7 @@ Schema.prototype.clone = function() {
+   s.callQueue = this.callQueue.map(function(f) { return f; });
+   s.methods = utils.clone(this.methods);
+   s.statics = utils.clone(this.statics);
++  s.s.hooks = utils.clone(this.s.hooks);
+   return s;
+ };
+ ",The more correct way of doing this is `this.s.hooks.clone()` but either way works. Thanks for finding this :+1:,"The `s.s.hooks` is an array, not a string."
+10044,"@@ -123,14 +123,13 @@ func (b *ClusterNetworkPolicySpecBuilder) GetAppliedToPeer(podSelector map[strin
+ func (b *ClusterNetworkPolicySpecBuilder) AddIngress(protoc v1.Protocol,
+ 	port *int32, portName *string, endPort *int32, cidr *string,
+ 	podSelector map[string]string, nsSelector map[string]string,
+-	podSelectorMatchExp []metav1.LabelSelectorRequirement, nsSelectorMatchExp []metav1.LabelSelectorRequirement, selfNS bool,
++	podSelectorMatchExp []metav1.LabelSelectorRequirement, nsSelectorMatchExp []metav1.LabelSelectorRequirement, selfNS string,
+ 	ruleAppliedToSpecs []ACNPAppliedToSpec, action crdv1alpha1.RuleAction, ruleClusterGroup, name string) *ClusterNetworkPolicySpecBuilder {
+
+ 	var pSel *metav1.LabelSelector
+ 	var nSel *metav1.LabelSelector
+ 	var ns *crdv1alpha1.PeerNamespaces
+ 	var appliedTos []crdv1alpha1.NetworkPolicyPeer
+-	matchSelf := crdv1alpha1.NamespaceMatchSelf
+
+ 	if b.Spec.Ingress == nil {
+ 		b.Spec.Ingress = []crdv1alpha1.Rule{}",Can we update bool to an enum instead of a string? This helps future extensibility,Why is the check removed?
+10045,"@@ -8,6 +8,13 @@ module Ncr
+
+   EXPENSE_TYPES = %w(BA60 BA61 BA80)
+   BUILDING_NUMBERS = YAML.load_file(""#{Rails.root}/config/data/ncr/building_numbers.yml"")
++  FY16 = Time.zone.parse('2015-10-01')
++  if Time.zone.now > FY16
++    MAX_AMOUNT = 3500.0
++  else
++    MAX_AMOUNT = 3000.0
++  end
++  MIN_AMOUNT = 0.0
+
+   class WorkOrder < ActiveRecord::Base
+     include ValueHelper","Should we share, since this is also being used with gsa18f?",Style/StringLiterals: Pre
+10046,"@@ -1835,7 +1835,7 @@ window.CrashgroupView = countlyView.extend({
+         // `d` is the original data object for the row
+         var str = '';
+         if (data) {
+-            str += '<div class=""datatablesubrow"">' +
++            str += '<div id=""crash-data-subrow"" class=""datatablesubrow"">' +
+                    '<div class=""error_menu"">' +
+                     '<div class=""error-details-menu"" data-id=""' + data._id + '"">' +
+                         '<a class=""right icon-button cly-button-menu-trigger""></a>' +","There can be multiple subrows, so it is not a good idea to use `id` there, as id should identify single unique element. Instead you could just add the id of whole table or of whole crash plugin view","Ah, I wish I could use a "
+10047,"@@ -284,7 +284,6 @@ class TestAnalyze(unittest.TestCase):
+         # We expect a failure archive to be in the failed directory.
+         failed_files = os.listdir(failed_dir)
+         self.assertEquals(len(failed_files), 1)
+-        self.assertIn(""failure.c"", failed_files[0])
+
+         fail_zip = os.path.join(failed_dir, failed_files[0])
+ ",Why was this assert removed? Shouldn't we check if the file is in the zip?,why did you remove this?
+10048,"@@ -149,13 +149,17 @@ func (cb *ControllerBuilder) Build() (*Controller, error) {
+ 	return cb.Controller, nil
+ }
+
+-// addSpc is the add event handler for spc.
++// addSpc is the add event handler for spc
+ func (c *Controller) addSpc(obj interface{}) {
+ 	spc, ok := obj.(*apis.StoragePoolClaim)
+ 	if !ok {
+ 		runtime.HandleError(fmt.Errorf(""Couldn't get spc object %#v"", obj))
+ 		return
+ 	}
++	if spc.Labels[string(apis.OpenEBSUpgradeKey)] == ""true"" {
++		glog.Infof(""spc %s is not reconciled reason upgrade value: %s"", spc.Name, spc.Labels[string(apis.OpenEBSUpgradeKey)])
++		return
++	}
+ 	glog.V(4).Infof(""Queuing SPC %s for add event"", spc.Name)
+ 	c.enqueueSpc(spc)
+ }","This logic should be handled at informer handle functions i.e. AddFunc, UpdateFunc, DeleteFunc","also need to check if `spc.Labels[string(OpenEBSUpgradeKey)] != ""true""`"
+10049,"@@ -39,3 +39,15 @@ type PSList struct {
+ func (c *PSList) Len() int {
+ 	return len(c.items)
+ }
++
++// IsStripePoolSpec returns true if pool spec is stripe pool or else it will
++// return false
++func IsStripePoolSpec(poolSpec *apisv1alpha1.PoolSpec) bool {
++	if len(poolSpec.RaidGroups[0].Type) != 0 {
++		if apisv1alpha1.PoolType(poolSpec.RaidGroups[0].Type) == apisv1alpha1.PoolStriped {
++			return true
++		}
++		return false
++	}
++	return apisv1alpha1.PoolType(poolSpec.PoolConfig.DefaultRaidGroupType) == apisv1alpha1.PoolStriped
++}",S1008: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (from `gosimple`),Is it safe to assume that `RaidGroups[0]` will always be empty?
+10050,"@@ -22,9 +22,15 @@ import (
+ )
+
+ func TestProcessIssueEvent(t *testing.T) {
++	const (
++		defaultTitle = ""foo: bar""
++	)
++
+ 	tests := []struct {
+ 		description string
+ 		action      string
++		title           string // defaults to defaultTitle
++		prevTitle string
+ 		labels      []string
+ 		want        *issueEdits
+ 	}{","Just to remove branching, use `defaultTitle` explicitly in the test cases. (Is this gofmt'd?)",The changes in this file seem unrelated to the PR.
+10051,"@@ -64,7 +64,7 @@ public class CSharpGapicSnippetsTransformer implements ModelToViewTransformer<Pr
+   private final StaticLangApiMethodTransformer apiMethodTransformer =
+       new CSharpApiMethodTransformer();
+   private final CSharpCommonTransformer csharpCommonTransformer = new CSharpCommonTransformer();
+-  private final SampleTransformer sampleTransformer = new SampleTransformer(SampleType.IN_CODE);
++  private final SampleTransformer sampleTransformer = SampleTransformer.create(SampleType.IN_CODE);
+   private final InitCodeTransformer initCodeTransformer = new InitCodeTransformer();
+
+   public CSharpGapicSnippetsTransformer(GapicCodePathMapper pathMapper) {",I don't think you use this variable anywhere. (You call `SampleTransformer.newBuilder()` below),Could you remove this and just use `new SampleTransformer(SampleType.IN
+10052,"@@ -54,6 +54,18 @@ char *chirp_wrap_whoami(const char *hostname, time_t stoptime)
+ 	return xxstrdup(id);
+ }
+
++char *chirp_wrap_hash(const char *hostname, const char *path, const char *algorithm, time_t stoptime) {
++	int result;
++	unsigned char digest[CHIRP_DIGEST_MAX];
++
++	result = chirp_reli_hash(hostname, path, algorithm, digest, stoptime);
++
++	if(result < 0)
++		return NULL;
++
++	return xxstrdup( (char *) digest);
++}
++
+ int64_t chirp_wrap_job_create (const char *host, const char *json, time_t stoptime)
+ {
+ 	chirp_jobid_t id;",The digest is in binary and variable size (the digest size is result if > 0). So we can't use xxstrdup.,this should probably be xxstrdup((char *) digest);
+10053,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+
+   @Override",We don't need this additional method.,`name` could be null I think
+10054,"@@ -44,4 +44,5 @@ type ClientConfig interface {
+ 	// have already been started.
+ 	GetUnaryOutbound() UnaryOutbound
+ 	GetOnewayOutbound() OnewayOutbound
++	GetStreamOutbound() StreamOutbound
+ }","We can't do this. Adding a method to an interface is a breaking change. This was an oversight on our part when we converted ClientConfig from a struct to an interface. OutboundConfig was introduced to fix this, the idea being that we should use OutboundConfig everywhere instead of ClientConfig. In case of Dispatcher, we want to use the OutboundConfig and MustOutboundConfig methods instead of ClientConfig, and for streaming, the client needs to attempt to upcast a ClientConfig to OutboundConfig and error out if that's not possible.","It seems that we don't need `StreamOutbound` here,"
+10055,"@@ -32,7 +32,9 @@ namespace domain {
+ DomainParticipant::DomainParticipant(
+         uint32_t did)
+     : dds::core::Reference<detail::DomainParticipant>(
+-        eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->create_participant(did))
++        eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->create_participant(
++                did,
++                eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->get_default_participant_qos()))
+ {
+ }
+ ",Why not using the constant `PARTICIPANT_QOS_DEFAULT` here?,The reason this is getting the default participant
+10056,"@@ -29,7 +29,8 @@ from pkg_resources import resource_stream
+ def getScalarMetricWithTimeOfDayAnomalyParams(metricData,
+                                               minVal=None,
+                                               maxVal=None,
+-                                              minResolution=None):
++                                              minResolution=None,
++                                              tmImplementation = ""cpp""):
+   """"""
+     Return a dict that can be used to create an anomaly model via OPF's
+     ModelFactory.","Shouldn't this be `tm_cpp` to match `temporalImp`? (There are multiple CPP implementations, so 'cpp' is ambiguous.)","The `tmImplementation` is just a string, right? Does it need to be a string, or does it have to be a string?"
+10057,"@@ -30,7 +30,18 @@ module RSpec
+       # @param line [String] current code line
+       # @return [String] relative path to line
+       def self.relative_path(line)
+-        line = line.sub(File.expand_path("".""), ""."")
++        # Matches strings either at the beginning of the input or prefixed with a whitespace,
++        # containing the current path, either postfixed with the separator, or at the end of the string.
++        # Match groups are the character before and the character after the string if any.
++        #
++        # http://rubular.com/r/fT0gmX6VJX
++        # http://rubular.com/r/duOrD4i3wb
++        # http://rubular.com/r/sbAMHFrOx1
++        #
++
++        regex = /(\A|\s)#{File.expand_path('.')}(#{File::SEPARATOR}|\s|\Z)/
++
++        line = line.sub(regex, ""\\1.\\2"")
+         line = line.sub(/\A([^:]+:\d+)$/, '\\1')
+         return nil if line == '-e:1'
+         line",Need to remove this empty line for rubocop to be happy.,Line is too long. [111/80]
+10058,"@@ -63,9 +63,9 @@ func newController(objects ...runtime.Object) (*fake.Clientset, *networkPolicyCo
+ 	addressGroupStore := store.NewAddressGroupStore()
+ 	internalNetworkPolicyStore := store.NewNetworkPolicyStore()
+ 	npController := NewNetworkPolicyController(client, informerFactory.Core().V1().Pods(), informerFactory.Core().V1().Namespaces(), informerFactory.Networking().V1().NetworkPolicies(), addressGroupStore, appliedToGroupStore, internalNetworkPolicyStore)
+-	npController.podListerSynced = alwaysReady
+-	npController.namespaceListerSynced = alwaysReady
+-	npController.networkPolicyListerSynced = alwaysReady
++	//npController.podListerSynced = alwaysReady
++	//npController.namespaceListerSynced = alwaysReady
++	//npController.networkPolicyListerSynced = alwaysReady
+ 	return client, &networkPolicyController{
+ 		npController,
+ 		informerFactory.Core().V1().Pods().Informer().GetStore(),","just checking: do we need to remove this because otherwise the `List` operations may not return the entire set of Pods / Namespaces? do you know why we used `alwaysReady` in the first place, I can't remember?",Why are these not needed?
+10059,"@@ -439,10 +439,14 @@ function createTopology(mongoClient, topologyType, options, callback) {
+     }
+
+     const MongoClient = loadClient();
+-    const connectionString =
+-      os.platform() === 'win32'
+-        ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
+-        : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    let connectionString;
++    if (mongoClient.s.options.autoEncryption.cryptdConnectionString != null) {
++      connectionString = mongoClient.s.options.autoEncryption.cryptdConnectionString;
++    } else if (os.platform() === 'win32') {
++      connectionString = 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000';
++    } else {
++      connectionString = 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    }
+
+     const mongocryptdClient = new MongoClient(connectionString, { useUnifiedTopology: true });
+     mongocryptdClient.connect(err => {",maybe we can replace `mongoClient.s.options.autoEncryption.cryptdConnectionString` with `options.autoEncryption.cryptdConnectionString`?,Can you move the `mongo://localhost:27020/serverSelectionTimeoutMS` to a constant so we can change it easily
+10060,"@@ -3719,9 +3719,11 @@ dr_create_client_thread(void (*func)(void *param), void *arg)
+ #        endif
+     LOG(THREAD, LOG_ALL, 1, ""dr_create_client_thread xsp="" PFX "" dstack="" PFX ""\n"", xsp,
+         get_clone_record_dstack(crec));
++    os_clone_pre(dcontext);
+     thread_id_t newpid =
+         dynamorio_clone(flags, xsp, NULL, IF_X86_ELSE(IF_X64_ELSE(NULL, &desc), NULL),
+                         NULL, client_thread_run);
++    os_clone_post(dcontext);
+     /* i#501 switch to app's tls before creating client thread */
+     if (IF_CLIENT_INTERFACE_ELSE(INTERNAL_OPTION(private_loader), false))
+         os_switch_lib_tls(dcontext, false /*to dr*/);","But we're already doing os_switch_lib_tls to app a few lines above, so there is now redundancy we should alleviate.",Shouldn't we also call `os_clone_post()` in case of error ?
+10061,"@@ -52,10 +52,11 @@ namespace Datadog.Trace
+         /// <param name=""parent"">The parent context.</param>
+         /// <param name=""traceContext"">The trace context.</param>
+         /// <param name=""serviceName"">The service name to propagate to child spans.</param>
+-        internal SpanContext(ISpanContext parent, ITraceContext traceContext, string serviceName)
++        /// <param name=""spanId"">The propagated span id.</param>
++        internal SpanContext(ISpanContext parent, ITraceContext traceContext, string serviceName, ulong? spanId = null)
+             : this(parent?.TraceId, serviceName)
+         {
+-            SpanId = SpanIdGenerator.ThreadInstance.CreateNew();
++            SpanId = spanId ?? SpanIdGenerator.ThreadInstance.CreateNew();
+             Parent = parent;
+             TraceContext = traceContext;
+             if (parent is SpanContext spanContext)",Under what circumstance would we have a span id already? Is this for testing purposes?,"This is a breaking change, we need to keep the old method s"
+10062,"@@ -2986,7 +2986,8 @@ static bool PreCallValidateQueueSubmit(layer_data *dev_data, VkQueue queue, uint
+                     skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT,
+                                     HandleToUint64(semaphore), kVUID_Core_DrawState_QueueForwardProgress,
+                                     ""Queue 0x%"" PRIx64 "" is signaling semaphore 0x%"" PRIx64
+-                                    "" that has already been signaled but not waited on by queue 0x%"" PRIx64 ""."",
++                                    "" that was previously signaled by queue 0x%"" PRIx64
++                                    "" but has not since been waited on by any queue."",
+                                     HandleToUint64(queue), HandleToUint64(semaphore), HandleToUint64(pSemaphore->signaler.first));
+                 } else {
+                     unsignaled_semaphores.erase(semaphore);","The original text can be read to say ""not waited on by queue ..."" meaing that the second queue was supposed to have *waited* for the signal... which is especially confusing when it's the same queue that has signalled the semaphore *twice* without a wait.","Perhaps ""has already been signaled on by a queue 0x%"" PRIx6"
+10063,"@@ -136,8 +136,8 @@ func (le *LookupEngine) Lookup(ctx context.Context, a types.Address) (peer.ID, e
+ 	case out := <-ch:
+ 		return out.(peer.ID), nil
+ 	case <-time.After(time.Second * 10):
+-		return """", fmt.Errorf(""timed out waiting for response"")
++		return """", fmt.Errorf(""lookup timed out waiting for response"")
+ 	case <-ctx.Done():
+-		return """", fmt.Errorf(""context cancled"")
++		return """", fmt.Errorf(""lookup failed: context cancled"")
+ 	}
+ }",just clarifying the error messages a bit.,looks like a typo :)
+10064,"@@ -0,0 +1,18 @@
++// <copyright file=""TelemetryRequestTypes.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Telemetry
++{
++    internal static class TelemetryRequestTypes
++    {
++        public const string AppStarted = ""app-started"";
++        public const string AppDependenciesLoaded = ""app-dependencies-loaded"";
++        public const string AppIntegrationsChanged = ""app-integrations-change"";
++        public const string AppHeartbeat = ""app-heartbeat"";
++        public const string AppClosing = ""app-closing"";
++
++        public const string GenerateMetrics = ""generate-metrics"";
++    }
++}",Have those (and other data like conf...) shared across tracers?,Should we make all of these public?
+10065,"@@ -0,0 +1,17 @@
++// +build !windows
++
++// Copyright 2020 Antrea Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
++package lib",could we add this file only when we need one?,Should this be `// +build !windows`
+10066,"@@ -37,4 +37,7 @@ type Context struct {
+ 	// ACMEHTTP01SolverImage is the image to use for solving ACME HTTP01
+ 	// challenges
+ 	ACMEHTTP01SolverImage string
++	// acmeDNS01ResolvConfFile is an optional custom resolv.conf file for
++	// solve ACME DNS01 challenges
++	ACMEDNS01ResolvConfFile string
+ }",This may not even be needed.,`ACMEDNS01ResolvConfFile` -> `ACMED
+10067,"@@ -70,6 +70,12 @@ var KnownFields = map[string]bool{
+ 	""Test.Flakiness"": true,
+ 	""Test.Results"":   true, // Recall that unsuccessful test results aren't cached...
+
++	// Debug fields don't contribute to any hash
++	""Debug"":            true,
++	""Debug.Command"":    true,
++	""Debug.tools"":      true,
++	""Debug.namedTools"": true,
++
+ 	// These only contribute to the runtime hash, not at build time.
+ 	""Data"":              true,
+ 	""namedData"":         true,",Capitalisation seems inconsistent here?,Just for my own understanding: what
+10068,"@@ -1,7 +1,11 @@
+-namespace Nevermind.Core
++using System;
++
++namespace Nevermind.Core
+ {
+     public interface ILogger
+     {
+         void Log(string text);
++        void Debug(string text);
++        void Error(string text, Exception ex = null);
+     }
+ }",maybe better Error(string text) and Error(Exception ex) separately?,Why is this necessary?
+10069,"@@ -58,7 +58,7 @@ func matchingTools(config *core.Configuration, prefix string) map[string]string
+ 		""jarcat"":      config.Java.JarCatTool,
+ 		""javacworker"": config.Java.JavacWorker,
+ 		""junitrunner"": config.Java.JUnitRunner,
+-		""langserver"":  path.Join(config.Please.Location, ""build_langserver""),
++		""lps"":  	   path.Join(config.Please.Location, ""build_langserver""),
+ 		""maven"":       config.Java.PleaseMavenTool,
+ 		""pex"":         config.Python.PexTool,
+ 	}","can you leave the old one in too please? at least for now, otherwise anyone using it now will break.",I wonder if `langserve
+10070,"@@ -3501,6 +3501,10 @@ void Player::onAttackedCreature(Creature* target)
+ {
+ 	Creature::onAttackedCreature(target);
+
++	if (target && target->getZone() == ZONE_PVP) {
++		return;
++	}
++
+ 	if (target == this) {
+ 		addInFightTicks();
+ 		return;","Trailing tab, remove it in another PR.",why not use `if (targe
+10071,"@@ -156,6 +156,9 @@ func (w *taskWriter) allocTaskIDs(count int) ([]int64, error) {
+ 		if w.taskIDBlock.start > w.taskIDBlock.end {
+ 			// we ran out of current allocation block
+ 			newBlock, err := w.tlMgr.allocTaskIDBlock(w.taskIDBlock.end)
++			if err != nil && w.tlMgr.errShouldUnload(err) {
++				w.tlMgr.signalFatalProblem(w.tlMgr.taskQueueID)
++			}
+ 			if err != nil {
+ 				return nil, err
+ 			}",what about merging the error checking logic to within `errShouldUnload`?,signalFatalProblem() i
+10072,"@@ -0,0 +1,6 @@
++class ArticlesController < ApplicationController
++  def index
++    @topic = Topic.find_by_slug(params[:id])
++    @articles = @topic.articles.by_published
++  end
++end",Probably want Topic.find_by_slug! to handle bogus topics. The next line will try to load articles off of nil otherwise.,I think this controller should be named `TopicController`. It's not only for the `ArticlesController` but also the `SearchController`.
+10073,"@@ -34,6 +34,11 @@ public:
+     static constexpr std::int64_t column_count = 2;
+     static constexpr std::int64_t element_count = row_count * column_count;
+
++    bool not_available_on_device() {
++        constexpr bool is_svd = std::is_same_v<Method, pca::method::svd>;
++        return get_policy().is_gpu() && is_svd;
++    }
++
+     auto get_descriptor() const {
+         return pca::descriptor<float, Method, pca::task::dim_reduction>{};
+     }",Should it really be done on test side?,Could this be refactored to use `std::is_same_v` in the future?
+10074,"@@ -350,7 +350,8 @@ func (mtask *managedTask) steadyState() bool {
+ 	}
+ }
+
+-// cleanupCredentials removes credentials for a stopped task
++// cleanupCredentials removes credentials for a stopped task (execution credentials are removed in cleanupTask
++// due to its potential usage in the later phase of the task cleanup such as sending logs)
+ func (mtask *managedTask) cleanupCredentials() {
+ 	taskCredentialsID := mtask.GetCredentialsID()
+ 	if taskCredentialsID != """" {","Can we elaborate on why? I'm guessing because we need the execution role to call FE stopTask during `cleanupTask`, but would be good if we make it clear here.",This function is called in `task.go` and `task.go` (just like `cleanupCredentials` in `task.go`). Should we move this to `task.go`?
+10075,"@@ -62,6 +62,10 @@ func newAgentCommand() *cobra.Command {
+ 			if err := opts.validate(args); err != nil {
+ 				klog.Fatalf(""Failed to validate: %v"", err)
+ 			}
++			// Not passing args again as they are already validated and are not used in flow exporter config
++			if err := opts.validateFlowExporterConfig(); err != nil {
++				klog.Fatalf(""Failed to validate flow exporter config: %v"", err)
++			}
+ 			if err := run(opts); err != nil {
+ 				klog.Fatalf(""Error running agent: %v"", err)
+ 			}",is there a reason why this is not called from inside `validate`?,This is the only place where `validateFlowExporterConfig` is called. I'm wondering if we should rename it to something like `validateF
+10076,"@@ -46,7 +46,12 @@ type clientServer struct {
+ // New returns a client/server to bidirectionally communicate with the backend.
+ // The returned struct should have both 'Connect' and 'Serve' called upon it
+ // before being used.
+-func New(url string, cfg *config.Config, credentialProvider *credentials.Credentials, statsEngine stats.Engine, publishMetricsInterval time.Duration) wsclient.ClientServer {
++func New(url string,
++	cfg *config.Config,
++	credentialProvider *credentials.Credentials,
++	statsEngine stats.Engine,
++	publishMetricsInterval time.Duration,
++	rwTimeout time.Duration) wsclient.ClientServer {
+ 	cs := &clientServer{
+ 		statsEngine:            statsEngine,
+ 		publishTicker:          nil,",:+1: I much prefer this style for functions with more than a few arguments.,"Minor naming nit: Would `rwTimeout` be more descriptive? Since it's a timeout, how about `publishTimeout`?"
+10077,"@@ -762,8 +762,7 @@ class CommandLine
+                     }
+                 }
+             }
+-
+-            if (hasQualifiers)
++            else if (hasQualifiers)
+             {
+                 sb.AppendLine().Append(""  Actions:"").AppendLine();
+ ","Are these mutually exclusive options (parameters vs qualifiers)? If parameters aren't supported, may want to consider throwing an exception for ""hasParameters"". If parameters and qualifiers are both legit options, then maybe change this to `if (hasQualifiers) { ... } if(!hasQualifiers && !hasParameters)`",This looks like an unrelated bug fix. Looks like it was fixed by a previous PR.
+10078,"@@ -43,7 +43,6 @@ public class InvocationStartProcessingEventListener implements EventListener {
+     if (InvocationType.PRODUCER.equals(event.getInvocationType())) {
+       ProducerInvocationMonitor monitor = registryMonitor.getProducerInvocationMonitor(event.getOperationName());
+       monitor.getWaitInQueue().increment(-1);
+-      monitor.getLifeTimeInQueue().update(event.getInQueueNanoTime());
+     }
+   }
+ }",Why did you remove this line?,Not sure why this was removed. I think the original code was wrong here.
+10079,"@@ -80,6 +80,7 @@ MSG(object_does_not_provide_read_access_to_columns,
+ MSG(object_does_not_provide_write_access_to_columns,
+     ""Given object does not provide write access to columns"")
+ MSG(unsupported_conversion_types, ""Unsupported conversion types"")
++MSG(invalid_indices, ""Invalid indices"")
+
+ /* Ranges */
+ MSG(invalid_range_of_rows, ""Invalid range of rows"")",Very unclear error message. Remember that these are messages that your users see. Please be more specific,"If the user doesn't provide access to the index, should this message say that the index is invalid?"
+10080,"@@ -39,6 +39,12 @@ const (
+ 	DisablePublicIP         = ""DISABLED""
+ 	PublicSubnetsPlacement  = ""PublicSubnets""
+ 	PrivateSubnetsPlacement = ""PrivateSubnets""
++
++	// RuntimePlatform configuration.
++	linuxOS = ""LINUX""
++	// windowsCoreOS = ""WINDOWS_SERVER_2019_CORE""
++	// windowsFullOS = ""WINDOWS_SERVER_2019_FULL""
++	x86Arch = ""X86_64""
+ )
+
+ // Constants for ARN options.",Can we add these when we need them  ,These should probably live in the `runtime_linux.go` and `runtime_linux.go` files.
+10081,"@@ -460,12 +460,13 @@ class EDS extends DefaultRecord
+      */
+     public function getPrimaryAuthors()
+     {
+-        return array_unique(
+-            $this->extractEbscoDataFromRecordInfo(
+-                'BibRecord/BibRelationships/HasContributorRelationships/*/'
++        $authors = $this->extractEbscoDataFromRecordInfo(
++            'BibRecord/BibRelationships/HasContributorRelationships/*/'
+                 . 'PersonEntity/Name/NameFull'
+-            )
+         );
++        return array_unique(array_filter($authors, function ($a) {
++            return !empty($a);
++        }));
+     }
+
+     /**","I believe you can simplify this to simply `return array_unique(array_filter($authors));` -- the default behavior of array_filter is to filter out empty elements, so the callback should not be required in this situation. Do you mind giving it a try and updating the PR if it works?",This can be simplified to `!empty($authors)`
+10082,"@@ -305,6 +305,10 @@ class UIAHandler(COMObject):
+ 			return
+ 		import NVDAObjects.UIA
+ 		obj=NVDAObjects.UIA.UIA(UIAElement=sender)
++		if not obj:
++			# Sometimes notification events can be fired on a UIAElement that has no windowHandle and does not connect through parents back to the desktop.
++			# There is nothing we can do with these.
++			return
+ 		eventHandler.queueEvent(""UIA_notification"",obj, notificationKind=NotificationKind, notificationProcessing=NotificationProcessing, displayString=displayString, activityId=activityId)
+
+ 	def _isUIAWindowHelper(self,hwnd):",Would it make sense to log a debug warning here?,@dcbw I'm not sure this is the best way to check if an object has no windowHandle.
+10083,"@@ -35,14 +35,6 @@ var loginCmd = &cobra.Command{
+ 				os.Exit(1)
+ 			}
+
+-			if err := ks.SetDefault(addr); err != nil {
+-				cmd.Printf(""Given address is not present into keystore.\r\nAvailable addresses:\r\n"")
+-				for _, addr := range ks.List() {
+-					cmd.Println(addr.Address.Hex())
+-				}
+-				return
+-			}
+-
+ 			// ask for password for default key
+ 			pass, err := accounts.NewInteractivePassPhraser().GetPassPhrase()
+ 			if err != nil {","""in the keystore"", but nevermind",why remove this?
+10084,"@@ -337,7 +337,7 @@ void nano::network::republish_vote (std::shared_ptr<nano::vote> vote_a)
+ void nano::network::broadcast_confirm_req (std::shared_ptr<nano::block> block_a)
+ {
+ 	auto list (std::make_shared<std::vector<nano::peer_information>> (node.peers.representatives (std::numeric_limits<size_t>::max ())));
+-	if (list->empty () || node.peers.total_weight () < node.config.online_weight_minimum.number ())
++	if (list->empty () || node.peers.total_weight () < node.delta ())
+ 	{
+ 		// broadcast request to all peers
+ 		list = std::make_shared<std::vector<nano::peer_information>> (node.peers.list_vector (100));",This should be done in a separate PR.,Could you please rename `delta` to `number`?
+10085,"@@ -138,8 +138,9 @@ public class DropPartyPlugin extends Plugin
+ 			{
+ 				continue;
+ 			}
+-			if (Text.standardize(player.getName()).equalsIgnoreCase(playerName))
++			if (player.getName().equalsIgnoreCase(playerName))
+ 			{
++				log.error(""found running player"");
+ 				runningPlayer = player;
+ 				break;
+ 			}",Rather than this maybe `Text.sanitize` would be better here,Please use `Text.equalsIgnoreCase`.
+10086,"@@ -82,7 +82,7 @@ public class NeighborsMsgSerializer : DiscoveryMsgSerializerBase, IMessageSerial
+             }
+
+             ReadOnlySpan<byte> id = ctx.DecodeByteArraySpan();
+-            return new Node(new PublicKey(id), address);
++            return new Node(new PublicKey(id), address, false);
+         });
+     }
+ }",lot of places setting default 'false' to static value - noise in PR,I don't think we should be changing this
+10087,"@@ -361,11 +361,19 @@ class Image extends BaseI18nLoop implements PropelSearchLoopInterface
+                 // Dispatch image processing event
+                 $this->dispatcher->dispatch(TheliaEvents::IMAGE_PROCESS, $event);
+
++                $originalImageSize = getimagesize($sourceFilePath);
++
++                $imageSize = getimagesize($event->getCacheFilepath());
++
+                 $loopResultRow
+                     ->set(""IMAGE_URL"", $event->getFileUrl())
+                     ->set(""ORIGINAL_IMAGE_URL"", $event->getOriginalFileUrl())
+                     ->set(""IMAGE_PATH"", $event->getCacheFilepath())
+                     ->set(""PROCESSING_ERROR"", false)
++                    ->set(""IMAGE_WIDH"", $imageSize[0])
++                    ->set(""IMAGE_HEIGHT"", $imageSize[1])
++                    ->set(""ORIGINAL_IMAGE_WIDH"", $originalImageSize[0])
++                    ->set(""ORIGINAL_IMAGE_HEIGHT"", $originalImageSize[1])
+                 ;
+             } catch (\Exception $ex) {
+                 // Ignore the result and log an error",I think you should use `$event->getOriginalFileUrl()` instead of `$sourceFilePath` here.,@danrot @wachterjohannes Is there a reason w
+10088,"@@ -99,6 +99,7 @@ def run(inventory_index_id,
+     # pylint: disable=too-many-locals
+     global_configs = service_config.get_global_config()
+     notifier_configs = service_config.get_notifier_config()
++    api_quota_configs = notifier_configs.get('api_quota')
+
+     with service_config.scoped_session() as session:
+         if scanner_index_id:","nit: It's a matter of taste, but it would be tighter if this is called `api_quota`.","Can we do a `get_notifier_config` here instead, so we don't have to pull in `api_quota_configs`?"
+10089,"@@ -16,9 +16,10 @@ package org.hyperledger.besu.ethereum.mainnet.precompiles;
+
+ import static org.assertj.core.api.Assertions.assertThat;
+
+-import org.hyperledger.besu.ethereum.core.Gas;
+-import org.hyperledger.besu.ethereum.vm.GasCalculator;
+-import org.hyperledger.besu.ethereum.vm.MessageFrame;
++import org.hyperledger.besu.evm.Gas;
++import org.hyperledger.besu.evm.frame.MessageFrame;
++import org.hyperledger.besu.evm.gascalculator.GasCalculator;
++import org.hyperledger.besu.evm.precompile.AltBN128PairingPrecompiledContract;
+
+ import org.apache.tuweni.bytes.Bytes;
+ import org.junit.Test;",I noticed in all of these we now have to import the PrecompiledContract under testing. Could also rename the package these are in s/precompiles/precompile to keep them in the same package as they are elsewhere.,altBN128PairingPrecompiledContract -> altBN128PairingPrecompiledContract ?
+10090,"@@ -288,7 +288,7 @@ class SnakebiteHdfsClient(HdfsClient):
+             client_kwargs = dict(filter(lambda (k, v): v is not None and v != '',  {
+                 'hadoop_version': self.config.getint(""hdfs"", ""client_version"", None),
+                 'effective_user': self.config.get(""hdfs"", ""effective_user"", None)
+-            }.items()))
++            }.iteritems()))
+             if self.config.getboolean(""hdfs"", ""snakebite_autoconfig"", False):
+                 """"""
+                 This is fully backwards compatible with the vanilla Client and can be used for a non HA cluster as well.",doubt this matters...,"`client_kwargs[""effective_user""] = self.config.get(""hdfs"", ""effective_user"", None)` would work t"
+10091,"@@ -36,6 +36,7 @@ from scapy.automaton import *
+ from scapy.autorun import *
+
+ from scapy.main import *
++from scapy.consts import *
+
+ from scapy.layers.all import *
+ ","Gets updated versions of `LOOPBACK_INTERFACE`, `LOOPBACK_NAME` when importing scapy.",why is this import needed?
+10092,"@@ -372,7 +372,7 @@ public class SparkTableUtil {
+     try {
+       PartitionSpec spec = SparkSchemaUtil.specForTable(spark, sourceTableIdentWithDB.unquotedString());
+
+-      if (spec == PartitionSpec.unpartitioned()) {
++      if (Objects.equal(spec, PartitionSpec.unpartitioned())) {
+         importUnpartitionedSparkTable(spark, sourceTableIdentWithDB, targetTable);
+       } else {
+         List<SparkPartition> sourceTablePartitions = getPartitions(spark, sourceTableIdent);","checking for ref. equality is probably fine here, but it takes a reader longer to navigate the code and figure out whether ref equality is really wanted here vs just using `equals()`",should we use `Objects.equal` here?
+10093,"@@ -60,12 +60,14 @@ type (
+ 		matchingClient           matchingservice.MatchingServiceClient
+ 		config                   *configs.Config
+ 		searchAttributesProvider searchattribute.Provider
++		workflowDeleteManager    workflow.DeleteManager
+ 	}
+ )
+
+ func newTransferQueueTaskExecutorBase(
+ 	shard shard.Context,
+ 	historyEngine *historyEngineImpl,
++	workflowDeleteManager workflow.DeleteManager,
+ 	logger log.Logger,
+ 	metricsClient metrics.Client,
+ 	config *configs.Config,",looks like it's not used? Do we plan to use it in the future?,Why is the delete manager not a par
+10094,"@@ -34,8 +34,8 @@ import (
+ )
+
+ type (
+-	// Config supports common options that apply to statsd exporters.
+-	Config struct {
++	// Options supports common options that apply to statsd exporters.
++	Options struct {
+ 		// URL describes the destination for exporting statsd data.
+ 		// e.g., udp://host:port
+ 		//       tcp://host:port","I think this is an unrelated remark. I thought we had moved toward the practice of using ""Config"" as the structure name, and Option as a functional argument (`func(*Config)`), and Options as a `[]Option`. See api/trace `StartConfig` and `StartOption`, for example. That's why I prefer this struct be called Config.",Perhaps it is better to call this `
+10095,"@@ -2,7 +2,8 @@ import random
+ import string
+
+ from kinto.core.storage import generators, exceptions
+-from pyramid import httpexceptions
++from pyramid.httpexceptions import (HTTPNotFound)
++from kinto.core.errors import http_error, ERRORS
+
+
+ class NameGenerator(generators.Generator):",nitpick: superfluous parenthesis,"Use 2 spaces for indentation, not 4"
+10096,"@@ -219,6 +219,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         private static void DecorateSpan(Span span, GraphQLTags tags)
+         {
+             span.Type = SpanTypes.GraphQL;
++            span.SetMetric(Tags.Measured, 1);
+         }
+
+         private static Scope CreateScopeFromValidate(object document)","If, for a given integration, the tag/measure is always set, it should be added to the strongly-typed tags (here for instance, in GraphQLTags). This way, the underlying dictionary is allocated only in the rare case where users add custom tags",Not sure if `Measured` tag is the best name here but I couldn't think of a better one.
+10097,"@@ -243,12 +243,12 @@ func ExecuteContract(
+ 	if err := stateDB.CommitContracts(); err != nil {
+ 		return nil, nil, errors.Wrap(err, ""failed to commit contracts to underlying db"")
+ 	}
+-	stateDB.clear()
+ 	receipt.AddLogs(stateDB.Logs()...).AddTransactionLogs(depositLog, burnLog)
+ 	if receipt.Status == uint64(iotextypes.ReceiptStatus_Success) ||
+ 		featureCtx.AddOutOfGasToTransactionLog && receipt.Status == uint64(iotextypes.ReceiptStatus_ErrCodeStoreOutOfGas) {
+ 		receipt.AddTransactionLogs(stateDB.TransactionLogs()...)
+ 	}
++	stateDB.clear()
+
+ 	if featureCtx.SetRevertMessageToReceipt && receipt.Status == uint64(iotextypes.ReceiptStatus_ErrExecutionReverted) && retval != nil && bytes.Equal(retval[:4], revertSelector) {
+ 		// in case of the execution revert error, parse the retVal and add to receipt",The position change of this line may be a hard fork.,This is the only real change in this file. the rest of the changes are from this PR.
+10098,"@@ -541,12 +541,7 @@ void Items::buildInventoryList()
+
+ void Items::parseItemNode(const pugi::xml_node& itemNode, uint16_t id)
+ {
+-	if (id > 30000 && id < 30100) {
+-		id -= 30000;
+-
+-		if (id >= items.size()) {
+-			items.resize(id + 1);
+-		}
++	if (id > 0 && id < 100) {
+ 		ItemType& iType = items[id];
+ 		iType.id = id;
+ 	}",id is unsigned  ,What is the reason for this change?
+10099,"@@ -13,6 +13,7 @@ Puppet::Functions.create_function(:run_command) do
+   # @param options A hash of additional options.
+   # @option options [Boolean] _catch_errors Whether to catch raised errors.
+   # @option options [String] _run_as User to run as using privilege escalation.
++  # @option options [Hash] _env_vars Map of environment variables to set
+   # @return A list of results, one entry per target.
+   # @example Run a command on targets
+   #   run_command('hostname', $targets, '_catch_errors' => true)",It looks like Puppet doesn't provide type validation for options and we don't provide it ourselves as part of the function. Is that something we'd want to do at some point?,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpol
+10100,"@@ -26,7 +26,8 @@ import org.apache.iceberg.io.CloseableIterable;
+ class StaticTableScan extends BaseTableScan {
+   private final Function<StaticTableScan, DataTask> buildTask;
+
+-  StaticTableScan(TableOperations ops, Table table, Schema schema, Function<StaticTableScan, DataTask> buildTask) {
++  StaticTableScan(TableOperations ops, Table table, Schema schema,
++                  Function<StaticTableScan, DataTask> buildTask) {
+     super(ops, table, schema);
+     this.buildTask = buildTask;
+   }",Looks like this didn't need to change.,nit: I don't think this change is required
+10101,"@@ -595,6 +595,10 @@ class PyLinter(config.OptionsManagerMixIn,
+             for msg_id in self._checker_messages('python3'):
+                 if msg_id.startswith('E'):
+                     self.enable(msg_id)
++            config_parser = self.cfgfile_parser
++            if config_parser.has_option('MESSAGES CONTROL', 'disable'):
++                value = config_parser.get('MESSAGES CONTROL', 'disable')
++                self.global_set_option('disable', value)
+         else:
+             self.disable('python3')
+         self.set_option('reports', False)",I don't understand why this is here and what's the intention with it? Can you elaborate what's the reasoning behind this change?,I think you can just use `self.set_option(
+10102,"@@ -25,13 +25,13 @@ package sqlplugin
+ import ""database/sql""
+
+ type (
+-	// historyShard is the SQL persistence interface for history shards
+-	historyShard interface {
++	// HistoryShard is the SQL persistence interface for history shards
++	HistoryShard interface {
+ 		InsertIntoShards(rows *ShardsRow) (sql.Result, error)
+ 		UpdateShards(row *ShardsRow) (sql.Result, error)
+ 		SelectFromShards(filter *ShardsFilter) (*ShardsRow, error)
+-		ReadLockShards(filter *ShardsFilter) (int, error)
+-		WriteLockShards(filter *ShardsFilter) (int, error)
++		ReadLockShards(filter *ShardsFilter) (int64, error)
++		WriteLockShards(filter *ShardsFilter) (int64, error)
+ 	}
+
+ 	// historyEvent is the SQL persistence interface for history nodes and history trees",I think @sergeybykov converted (wanted to convert) all `shardID` to `int32` from `int64`. Please check with him.,What's the rational behind this change?
+10103,"@@ -2289,7 +2289,8 @@ void ProtocolGame::sendCreatureHealth(const Creature* creature)
+ 	if (creature->isHealthHidden()) {
+ 		msg.addByte(0x00);
+ 	} else {
+-		msg.addByte(std::ceil((static_cast<double>(creature->getHealth()) / std::max<int32_t>(creature->getMaxHealth(), 1)) * 100));
++		int32_t maxHealth = std::max(creature->getMaxHealth(), 1);
++		msg.addByte(std::ceil((static_cast<double>(std::min(creature->getHealth(), maxHealth)) / maxHealth) * 100));
+ 	}
+ 	writeToOutputBuffer(msg);
+ }",This will only fix client side (so showing it in-game) server still gonna hold invalid values I guess?,Why don't you use `std::max` here?
+10104,"@@ -287,6 +287,18 @@ class Dataset(Element):
+         class to each underlying element.
+         """"""
+         if isinstance(data, DynamicMap):
++            class_name = cls.__name__
++            repr_kdims = 'kdims=%r' % kdims if kdims else None
++            repr_vdims = 'vdims=%r' % vdims if vdims else None
++            repr_kwargs = (', '.join('%s=%r' % (k,v) for k,v in kwargs.items())
++                           if kwargs else None)
++            extras = ', '.join([el for el in [repr_kdims, repr_vdims, repr_kwargs]
++                               if el is not None])
++            extras = ', ' + extras if extras else ''
++            apply_args= 'hv.{class_name}{extras}'.format(class_name=class_name,
++                                                         extras=extras)
++            msg = ""Cannot construct a {class_name} from the supplied object of type DynamicMap. Implicitly creating a DynamicMap of {class_name} objects, but instead please explicitly call .apply({apply_args}) on the supplied DynamicMap.""
++            cls.warning(cls, msg.format(class_name=class_name, apply_args=apply_args))
+             return data.apply(cls, per_element=True, kdims=kdims, vdims=vdims, **kwargs)
+         else:
+             return super(Dataset, cls).__new__(cls)",Shouldn't this be `cls.param.warning`?,Please use `repr` instead of `+` here.
+10105,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)","If we no longer need `chromeOptions`, "
+10106,"@@ -107,9 +107,14 @@ class ServerConnectionMixin:
+         """"""
+         address = self.server_conn.address
+         if address:
++            forbidden_hosts = [""localhost"", ""127.0.0.1"", ""::1""]
++
++            if self.config.options.listen_host:
++                forbidden_hosts.append(self.config.options.listen_host)
++
+             self_connect = (
+                 address[1] == self.config.options.listen_port and
+-                address[0] in (""localhost"", ""127.0.0.1"", ""::1"")
++                address[0] in forbidden_hosts
+             )
+             if self_connect:
+                 raise exceptions.ProtocolException(","Could we not just always include `self.config.options.listen_host`? If that is empty, the `address[0]` check should also never be true.","Maybe use `address.startswith(""localho"
+10107,"@@ -102,8 +102,8 @@ public class DataFilesTable extends BaseMetadataTable {
+     }
+
+     @Override
+-    protected long targetSplitSize(TableOperations ops) {
+-      return ops.current().propertyAsLong(
++    public long targetSplitSize() {
++      return tableOps().current().propertyAsLong(
+           TableProperties.METADATA_SPLIT_SIZE, TableProperties.METADATA_SPLIT_SIZE_DEFAULT);
+     }
+ ",Why not just access `ops` directly like before?,nit: can you remove this blank line?
+10108,"@@ -389,17 +389,13 @@ void Creature::onRemoveTileItem(const Tile* tile, const Position& pos, const Ite
+ 	}
+ }
+
+-void Creature::onCreatureAppear(Creature* creature, bool isLogin)
++void Creature::onCreatureAppear(Creature* creature, bool)
+ {
+ 	if (creature == this) {
+ 		if (useCacheMap()) {
+ 			isMapLoaded = true;
+ 			updateMapCache();
+ 		}
+-
+-		if (isLogin) {
+-			setLastPosition(getPosition());
+-		}
+ 	} else if (isMapLoaded) {
+ 		if (creature->getPosition().z == getPosition().z) {
+ 			updateTileCache(creature->getTile(), creature->getPosition());",Is there even a need to keep the bool?,why remove this?
+10109,"@@ -42,7 +42,7 @@ class HotgymRegressionTest(unittest.TestCase):
+
+   def testHotgymRegression(self):
+     experimentDir = os.path.join(
+-      os.path.dirname(__file__).partition(""tests/integration/nupic/opf"")[0],
++      os.path.dirname(__file__).partition(os.path.normpath(""tests/integration/nupic/opf""))[0],
+       ""examples"", ""opf"", ""experiments"", ""multistep"", ""hotgym"")
+
+     resultsDir = os.path.join(experimentDir, ""inference"")",wrap to stay under 80 characters,I am not sure wh
+10110,"@@ -67,6 +67,7 @@ shared_ptr<Layer<Dtype> > GetConvolutionLayer(
+ #endif
+   } else {
+     LOG(FATAL) << ""Layer "" << param.name() << "" has unknown engine."";
++    throw;  // Avoids missing return warning
+   }
+ }
+ ","`return NULL` is more clear than `throw` at least in my reading, and consistent with #3362.",Please add a mor
+10111,"@@ -87,8 +87,6 @@ class LocustIOExecutor(ScenarioExecutor, WidgetProvider, FileLister, HavingInsta
+
+         wrapper = os.path.join(get_full_path(__file__, step_up=2), ""resources"", ""locustio-taurus-wrapper.py"")
+
+-        self.env.add_path({""PYTHONPATH"": self.engine.artifacts_dir})
+-        self.env.add_path({""PYTHONPATH"": os.getcwd()})
+         self.env.set({""LOCUST_DURATION"": dehumanize_time(load.duration)})
+
+         self.log_file = self.engine.create_artifact(""locust"", "".log"")","Both of these are important. Without it, locust won't find my libraries in the cloud.",you really want
+10112,"@@ -87,7 +87,7 @@ func (o *listSvcOpts) Execute() error {
+ 		return fmt.Errorf(""get application: %w"", err)
+ 	}
+
+-	svcs, err := o.store.ListServices(o.appName)
++	svcs, err := o.store.ListWorkloads(o.appName)
+ 	if err != nil {
+ 		return err
+ 	}",This should remain as `ListServices`,Shouldn't we also rename `ListServices` ?
+10113,"@@ -0,0 +1,2 @@
++package v2
++","If no tests, remove this file.",Can you remove this file?
+10114,"@@ -116,7 +116,7 @@ cp bin/protoc /usr/local/bin/protoc
+     if SHOULD_INVENTORY_GROUPS:
+         GROUPS_DOMAIN_SUPER_ADMIN_EMAIL = context.properties[
+             'groups-domain-super-admin-email']
+-        GROUPS_SERVICE_ACCOUNT_KEY_FILE = context.properties[
++        GSUITE_SERVICE_ACCOUNT_KEY_FILE = context.properties[
+             'groups-service-account-key-file']
+
+         # TODO: remove this in a future version",This will require changes to the docs. I suggest searching the gh-pages branch for the previous variable name.,TODO: remove this in a future version
+10115,"@@ -249,7 +249,7 @@ class RemoteHandler(logging.Handler):
+
+ 	def __init__(self):
+ 		#Load nvdaHelperRemote.dll but with an altered search path so it can pick up other dlls in lib
+-		path=os.path.abspath(os.path.join(u""lib"",buildVersion.version,u""nvdaHelperRemote.dll""))
++		path = os.path.join(globalVars.appDir, ""lib"", buildVersion.version, ""nvdaHelperRemote.dll"")
+ 		h=ctypes.windll.kernel32.LoadLibraryExW(path,0,LOAD_WITH_ALTERED_SEARCH_PATH)
+ 		if not h:
+ 			raise OSError(""Could not load %s""%path) ",`RemoteHandler` is used in nvda_slave and slave does not have access to `globalVars` currently. Perhaps `globalVars.appDir` should be set to `None` in `globalVarrs by default and set to NVDA directory when they're imported for the first time.,I'm not sure this is correct. When `build
+10116,"@@ -12,10 +12,11 @@ type MetricsConfig struct {
+ }
+
+ type FileConfig struct {
+-	Prometheus *PrometheusConfig `hcl:""Prometheus""`
+-	DogStatsd  []DogStatsdConfig `hcl:""DogStatsd""`
+-	Statsd     []StatsdConfig    `hcl:""Statsd""`
+-	M3         []M3Config        `hcl:""M3""`
++	Prometheus   *PrometheusConfig `hcl:""Prometheus""`
++	DogStatsd    []DogStatsdConfig `hcl:""DogStatsd""`
++	Statsd       []StatsdConfig    `hcl:""Statsd""`
++	M3           []M3Config        `hcl:""M3""`
++	DisableInMem bool              `hcl:""DisableInMem""`
+ }
+
+ type DogStatsdConfig struct {","In case there is more configuration to be added to the ""inmem"" metrics later (however unlikely that is), we may want to play it safe and create an `InMemConfig` struct and include the disabled flag there. This also gives the config symmetry across the plugins.",Is there a reason we can't have this on the `FileConfig` directly?
+10117,"@@ -35,6 +35,16 @@ describe ProposalSearch do
+     end
+
+     context Gsa18f::Procurement do
++      around(:each) do |example|
++        ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'
++        ENV['GSA18F_PURCHASER_EMAIL'] = 'test_purchaser@some-dot-gov.gov'
++        example.run
++
++        ENV['GSA18F_APPROVER_EMAIL'] = nil
++        ENV['GSA18F_PURCHASER_EMAIL'] = nil
++      end
++
++
+       [:product_name_and_description, :justification, :additional_info].each do |attr_name|
+         it ""returns the Proposal when searching by the ##{attr_name}"" do
+           procurement = FactoryGirl.create(:gsa18f_procurement, attr_name => 'foo')",I'll need to pull this out of here since we're sharing this in other tests. Same for `procurement_spec.rb`,Prefer single-quoted strings when you don't need string interpolat
+10118,"@@ -6,7 +6,7 @@ class ObservationsController < ApplicationController
+
+   def create
+     obs = @proposal.add_observer(observer_email, current_user, params[:observation][:reason])
+-    flash[:success] = ""#{obs.user.full_name} has been added as an observer""
++    prep_create_response_msg(obs)
+     redirect_to proposal_path(@proposal)
+   end
+ ","what about `observer` as a var name here (and below) rather than `obs` ? -- would be clearer, imo!",Line is too long. [81/80]
+10119,"@@ -110,7 +110,7 @@ class ErrorHandler(object):
+                             value = message
+                             try:
+                                 message = message['message']
+-                            except TypeError:
++                            except KeyError:
+                                 message = None
+                     else:
+                         message = value.get('message', None)",could you change this to instead of being a `try.. except` be `message = message.get('message')`,`TypeError` is more specific than `KeyError`
+10120,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities
+ {
+     using System;",Add space between License and nameapace,Please revert all the changes to this file.
+10121,"@@ -0,0 +1,15 @@
++class ProfileController < ApplicationController
++  def show
++  end
++
++  def update
++    first_name = params[:first_name]
++    last_name = params[:last_name]
++    user = current_user
++    user.first_name = first_name
++    user.last_name = last_name
++    user.save!
++    flash[:success] = ""Your profile is updated!""
++    redirect_to :me
++  end
++end",should we have a `before_filter` for auth here?,Do we want to show a success message? If no
+10122,"@@ -575,6 +575,17 @@ func (r *AWSMachineReconciler) reconcileLBAttachment(machineScope *scope.Machine
+ 	// In order to prevent sending request to a ""not-ready"" control plane machines, it is required to remove the machine
+ 	// from the ELB as soon as the machine gets deleted or when the machine is in a not running state.
+ 	if !machineScope.AWSMachine.DeletionTimestamp.IsZero() || !machineScope.InstanceIsRunning() {
++		registered, err := elbsvc.InstanceIsRegisteredWithAPIServerELB(i)
++		if err != nil {
++			r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""FailedDetachControlPlaneELB"",
++				""Failed to deregister control plane instance %q from load balancer: failed to determine registration status: %v"", i.ID, err)
++			return errors.Wrapf(err, ""could not deregister control plane instance %q from load balancer - error determining registration status"", i.ID)
++		}
++		if !registered {
++			// Already deregistered - nothing more to do
++			return nil
++		}
++
+ 		if err := elbsvc.DeregisterInstanceFromAPIServerELB(i); err != nil {
+ 			r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""FailedDetachControlPlaneELB"",
+ 				""Failed to deregister control plane instance %q from load balancer: %v"", i.ID, err)","@vincepri I know we discussed moving this up and only calling it once, but I didn't (quickly) see an easy way to generate the right event based on the appropriate action (attach vs detach). Happy to move it around if you have suggestions.","Instead of introducing a new event, can we "
+10123,"@@ -0,0 +1,15 @@
++class TsearchHooks
++  def after_save(record)
++    record.class.where(id: record).update_all(
++      ""vector = #{ vector(record) }, popularity_factor = #{ record.searchable_factor }"")
++  end
++
++  def vector(record)
++    weighted_sql = []
++    record.searchable_vector.each do |weight, attr_value|
++      attr_value.gsub!(/['?\\:]/, ' ')
++      weighted_sql << ""setweight(to_tsvector(coalesce('#{attr_value}')), '#{weight.upcase}')""
++    end
++    weighted_sql.join(' ||')
++  end
++end",Can we use record.update here?,Omit parentheses for method calls with no a
+10124,"@@ -243,7 +243,7 @@ func (rw *responseWriter) Close() error {
+ 			retErr = appendError(retErr, fmt.Errorf(""SetApplicationError() failed: %v"", err))
+ 		}
+ 	}
+-	retErr = appendError(retErr, writeHeaders(rw.format, rw.headers, rw.response.Arg2Writer))
++	retErr = appendError(retErr, writeHeaders(rw.format, rw.headers.Items(), rw.response.Arg2Writer))
+
+ 	// Arg3Writer must be opened and closed regardless of if there is data
+ 	// However, if there is a system error, we do not want to do this",Shouldn't the exact case option matter here?,`rw.headers.Items()` returns a `common.MapStr` and not a `common.MapStr`
+10125,"@@ -184,7 +184,7 @@ def Derived(parent_cls):
+             n = luigi.IntParameter()
+             # ...
+
+-        class MyTask(luigi.uti.Derived(AnotherTask)):
++        class MyTask(luigi.util.Derived(AnotherTask)):
+             def requires(self):
+                return self.parent_obj
+             def run(self):","Errr, why haven't we noticed this until now?",You may want to revert this change.
+10126,"@@ -456,7 +456,11 @@ public final class Lucene50PostingsFormat extends PostingsFormat {
+   @Override
+   public FieldsConsumer fieldsConsumer(SegmentWriteState state) throws IOException {
+     PostingsWriterBase postingsWriter = new Lucene50PostingsWriter(state);
+-    state.segmentInfo.putAttribute(MODE_KEY, fstLoadMode.name());
++    final String previous = state.segmentInfo.putAttribute(MODE_KEY, fstLoadMode.name());
++    if (previous != null && previous.equals(fstLoadMode.name()) == false) {
++      throw new IllegalStateException(""found existing value for "" + MODE_KEY + "" for segment: "" + state.segmentInfo.name +
++          ""old="" + previous + "", new="" + fstLoadMode.name());
++    }
+     boolean success = false;
+     try {
+       FieldsConsumer ret = new BlockTreeTermsWriter(state, ","It's a little spooky that this method throws exception if you try to set the attribute to a different value than it was set before, but then does leave the new value set in the attributes?",Consider using Preconditions.checkNotNull instead.
+10127,"@@ -48,7 +48,7 @@ public class PodDBAdapter {
+
+     private static final String TAG = ""PodDBAdapter"";
+     public static final String DATABASE_NAME = ""Antennapod.db"";
+-    public static final int VERSION = 1090000;
++    public static final int VERSION = 1091000;
+
+     /**
+      * Maximum number of arguments for IN-operator.",Please only increment by 1.,how did this version get updated?
+10128,"@@ -348,7 +348,7 @@ namespace Microsoft.Rest.Generator.Java
+             else if (primaryType == PrimaryType.TimeSpan ||
+                 primaryType.Name == ""Period"")
+             {
+-                return ""java.time.Period"";
++                return ""org.joda.time.Period"";
+             }
+             else
+             {","Sorry I might have missed some context, but what's the reason you choose `Period` over `Duration` or `Interval`? (Thumbs up for using `org.joda.time` instead!)",Why did you change to `org.joda.time.Period`?
+10129,"@@ -2359,6 +2359,19 @@ DefaultSettings.prototype = {
+    */
+   preventOverflow: false,
+
++  /**
++   * Prevents wheel event on overlays for doing default action.
++   *
++   * @type {Boolean}
++   * @default false
++   *
++   * @example
++   * ```js
++   * preventWheel: false,
++   * ```
++   */
++  preventWheel: false,
++
+   /**
+    * @description
+    * Enables the functionality of the {@link BindRowsWithHeaders} plugin which allows binding the table rows with their headers.",Please check if is it possible to mark it as private. What's more please add this to the TypeScript definition file.,You also need to add this to the `@example`.
+10130,"@@ -28,6 +28,10 @@ static std::string GeneratedFileName(const std::string &path,
+   return path + file_name + ""_generated.h"";
+ }
+
++char ToUpper(char c) {
++  return static_cast<char>(::toupper(c));
++}
++
+ namespace cpp {
+ class CppGenerator : public BaseGenerator {
+  public:",Maybe move this to `util.h` ?,I think this should be defined as `static con
+10131,"@@ -4,7 +4,8 @@
+
+ package Example
+
+-import ""github.com/google/flatbuffers/go""
++#include ""flatbuffers/grpc.h""
++
+
+ import (
+   context ""golang.org/x/net/context""",oops. this won't work will it,did you mean to include this in this PR?
+10132,"@@ -208,12 +208,16 @@ func (extra ExtraMetadataV3) IsReaderKeyBundleNew() bool {
+ // must be done separately.
+ func MakeInitialRootMetadataV3(tlfID tlf.ID, h tlf.Handle) (
+ 	*RootMetadataV3, error) {
+-	if tlfID.Type() != h.Type() {
++	switch {
++	case h.TypeForKeying() == tlf.TeamKeying && tlfID.Type() != tlf.SingleTeam:
++		fallthrough
++	case h.TypeForKeying() != tlf.TeamKeying && tlfID.Type() != h.Type():
+ 		return nil, errors.New(""TlfID and TlfHandle disagree on TLF type"")
++	default:
+ 	}
+
+ 	var writers []keybase1.UserOrTeamID
+-	if tlfID.Type() != tlf.Private {
++	if h.TypeForKeying() != tlf.PrivateKeying {
+ 		writers = make([]keybase1.UserOrTeamID, len(h.Writers))
+ 		copy(writers, h.Writers)
+ 	}",@strib I assumed this is what you meant; but let me know if I'm wrong!,Why aren't we checking for `h.TypeForKeying() == tlf.SingleTeam` here?
+10133,"@@ -106,7 +106,7 @@ func (wh *WorkflowNilCheckHandler) DeprecateNamespace(ctx context.Context, reque
+
+ // StartWorkflowExecution starts a new long running workflow instance.  It will create the instance with
+ // 'WorkflowExecutionStarted' event in history and also schedule the first WorkflowTask for the worker to make the
+-// first decision for this instance.  It will return 'WorkflowExecutionAlreadyStartedError', if an instance already
++// first command for this instance.  It will return 'WorkflowExecutionAlreadyStartedError', if an instance already
+ // exists with same workflowId.
+ func (wh *WorkflowNilCheckHandler) StartWorkflowExecution(ctx context.Context, request *workflowservice.StartWorkflowExecutionRequest) (_ *workflowservice.StartWorkflowExecutionResponse, retError error) {
+ 	resp, err := wh.parentHandler.StartWorkflowExecution(ctx, request)",I believe the error has changed,Nit: 'It will return 'WorkflowExecutionAlreadyStartedError'...'
+10134,"@@ -41,6 +41,16 @@ module Blacklight
+       self.class.new(params || ActionController::Parameters.new, blacklight_config, controller)
+     end
+
++    ##
++    # Check if the query has any constraints defined (a query, facet, etc)
++    #
++    # @return [Boolean]
++    # rubocop:disable Style/PredicateName
++    def has_constraints?
++      params[:q].present? || params[:f].present?
++    end
++    # rubocop:enable Style/PredicateName
++
+     ##
+     # Extension point for downstream applications
+     # to provide more interesting routing to",Lint/UnneededDisable: Unnecessary disabling of Naming/PredicateName.,I think this should be `params[:q].present? || params[:f].present?`. O
+10135,"@@ -58,6 +58,8 @@ describe ProposalsController do
+       end
+
+       it 'should redirect random users' do
++        skip ""flaky spec""
++
+         proposal = FactoryGirl.create(:proposal)
+         get :show, id: proposal.id
+         expect(response).to redirect_to(proposals_path)",Should this be removed now?,Prefer single-quoted strings when you don't need string interpolation
+10136,"@@ -25,6 +25,8 @@ public abstract class MockGrpcMethodView {
+
+   public abstract String responseTypeName();
+
++  public abstract String streamHandle();
++
+   public abstract GrpcStreamingType grpcStreamingType();
+
+   public static Builder newBuilder() {",streamHandle sounds vague to me. Can you be more specific?,Add `@Experimental` annotation.
+10137,"@@ -736,7 +736,8 @@ Cursor.prototype._initializeCursor = function(callback) {
+       return;
+     }
+
+-    server.command(cursor.ns, cursor.cmd, cursor.options, queryCallback);
++    const commandOptions = Object.assign({}, cursor.options, cursor.cursorState);
++    server.command(cursor.ns, cursor.cmd, commandOptions, queryCallback);
+   });
+ };
+ ",Does everything on cursorState belong in the command options?,Is this still necessary? What i
+10138,"@@ -559,7 +559,7 @@ func (m *MatchNot) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
+ 	for d.Next() {
+ 		var mp matcherPair
+ 		matcherMap := make(map[string]RequestMatcher)
+-		for d.NextBlock(0) {
++		for d.NextArg() || d.NextBlock(0) {
+ 			matcherName := d.Val()
+ 			mod, err := caddy.GetModule(""http.matchers."" + matcherName)
+ 			if err != nil {","This is clever, but I do admit I think it's kinda weird. We can go with it for now and fix it later if people complain.",I think this would be clearer w
+10139,"@@ -31,7 +31,9 @@ import (
+ )
+
+ var (
+-	gsRegex = regexp.MustCompile(`^gs://([a-z0-9][-_.a-z0-9]*)/(.+)$`)
++	bucket = `([a-z0-9][-_.a-z0-9]*)`
++	bucketRegex = regexp.MustCompile(fmt.Sprintf(`^gs://%s/?$`, bucket))
++	gsRegex = regexp.MustCompile(fmt.Sprintf(`^gs://%s/(.+)$`, bucket))
+ )
+
+ // StorageClient implements domain.StorageClientInterface. It implements main Storage functions","the variable names are not entirely clear. ""bucket"" is essentially the regex that follows gcs naming pattern, right? if so, it should be changed to bucketregex. and then bucketregex, gsregex should be changed to something more specific to what pattern the regex is supposed to match.",Can we use `fmt.Sprintf` for th
+10140,"@@ -26,8 +26,8 @@ import com.google.common.collect.Lists;
+ import java.util.List;
+
+ /** Responsible for producing package meta-data related views for Java GAPIC clients */
+-public class JavaGapicPackageTransformer extends JavaPackageTransformer
+-    implements ModelToViewTransformer {
++public class JavaGapicPackageTransformer<T extends ApiModel> extends JavaPackageTransformer
++    implements ModelToViewTransformer<T> {
+   private final PackageMetadataConfig packageConfig;
+
+   public JavaGapicPackageTransformer(PackageMetadataConfig packageConfig) {",I think `ApiModelT` would be clearer than `T`,Shouldn't it extend `ApiModel`?
+10141,"@@ -1,6 +1,5 @@
+-// $Id$
+ //
+-//  Copyright (C) 2004-2008 Greg Landrum and Rational Discovery LLC
++//  Copyright (C) 2004-2016 Greg Landrum and Rational Discovery LLC
+ //
+ //   @@ All Rights Reserved @@
+ //  This file is part of the RDKit.",Shouldn't this be 2019?,why did you change this file?
+10142,"@@ -30,6 +30,8 @@ public enum Status {
+   SUCCEEDED(50),
+   KILLING(55),
+   KILLED(60),
++  // POD_FAILED refers to a failed containerized flow due to pod failure
++  POD_FAILED(65),
+   FAILED(70),
+   FAILED_FINISHING(80),
+   SKIPPED(90),","We should consider giving this state a more generic name which could be used for flows in similar state in non-containerized Azkban. For instance in the event of a bare-metal executor crashing we could the switch any flows assigned to that executor to this state. Something like `EXECUTE_INFRA_FAILED`, better alternatives should be possible though.",This seems like a really generi
+10143,"@@ -4,8 +4,12 @@ var bad = [],
+
+ virtualNode.children.forEach(({ actualNode }) => {
+ 	var nodeName = actualNode.nodeName.toUpperCase();
+-	if (actualNode.nodeType === 1 && nodeName !== 'DT' && nodeName !== 'DD' && permitted.indexOf(nodeName) === -1) {
+-		bad.push(actualNode);
++
++	if (actualNode.nodeType === 1 && permitted.indexOf(nodeName) === -1) {
++		var role = (actualNode.getAttribute('role') || '').toLowerCase();
++		if ((nodeName !== 'DT' && nodeName !== 'DD') || role) {
++			bad.push(actualNode);
++		}
+ 	} else if (actualNode.nodeType === 3 && actualNode.nodeValue.trim() !== '') {
+ 		hasNonEmptyTextNode = true;
+ 	}","This should allow `role=definition` and `role=term`, possibly also `role=list`?",Do we need to also check for `r
+10144,"@@ -511,6 +511,19 @@ public class Spark3Util {
+             TableProperties.PARQUET_BATCH_SIZE, TableProperties.PARQUET_BATCH_SIZE_DEFAULT));
+   }
+
++  public static Boolean propertyAsBoolean(CaseInsensitiveStringMap options, String property, Boolean defaultValue) {
++    if (defaultValue != null) {
++      return options.getBoolean(property, defaultValue);
++    }
++
++    String value = options.get(property);
++    if (value != null) {
++      return Boolean.parseBoolean(value);
++    }
++
++    return null;
++  }
++
+   public static Long propertyAsLong(CaseInsensitiveStringMap options, String property, Long defaultValue) {
+     if (defaultValue != null) {
+       return options.getLong(property, defaultValue);",Should this use `boolean` instead of `Boolean`?,What's the benefit of this new method?
+10145,"@@ -135,7 +135,6 @@ namespace OpenTelemetry.Exporter.Zipkin.Tests
+         [Theory]
+         [InlineData(true, false, false)]
+         [InlineData(false, false, false)]
+-        [InlineData(false, true, false)]
+         [InlineData(false, false, true)]
+         [InlineData(false, false, false, StatusCode.Ok)]
+         [InlineData(false, false, false, StatusCode.Ok, null, true)]","Currently in our Zipkin tests, only one passed parameter would instantiate a Resource and checks for its tags populating. I left the If(UseTestResource) clause in the code in case we would like to return to the old resource tag checking, but if it makes more sense I can remove that parameter entirely.",Was this change intentional? Was it in
+10146,"@@ -944,6 +944,11 @@ public class ZkStateReader implements SolrCloseable {
+     return null;
+   }
+
++  public boolean isNodeLive(String node) {
++    return liveNodes.contains(node);
++
++  }
++
+   /**
+    * Get shard leader properties, with retry if none exist.
+    */","While this is potentially convenient it seems off topic for the PR/Issue. Also if it is kept, in the realm of taste/style I tend to not use get/set/is for things that are not properties of the object. maybe hasLiveNode(String node) thus someone using it might write `if (zkReader.hasLiveNode(""foo"")) ...` which reads quite nicely.",do we need this method?
+10147,"@@ -10,11 +10,13 @@ import (
+ )
+
+ var (
+-	svidPath    = path.Join(ProjectRoot(), ""test/fixture/certs/svid.pem"")
+-	svidKeyPath = path.Join(ProjectRoot(), ""test/fixture/certs/svid_key.pem"")
+-	caPath      = path.Join(ProjectRoot(), ""test/fixture/certs/ca.pem"")
+-	caKeyPath   = path.Join(ProjectRoot(), ""test/fixture/certs/ca_key.pem"")
+-	bundlePath  = path.Join(ProjectRoot(), ""test/fixture/certs/bundle.der"")
++	svidPath     = path.Join(ProjectRoot(), ""test/fixture/certs/svid.pem"")
++	svidKeyPath  = path.Join(ProjectRoot(), ""test/fixture/certs/svid_key.pem"")
++	caPath       = path.Join(ProjectRoot(), ""test/fixture/certs/ca.pem"")
++	caKeyPath    = path.Join(ProjectRoot(), ""test/fixture/certs/ca_key.pem"")
++	bundlePath   = path.Join(ProjectRoot(), ""test/fixture/certs/bundle.der"")
++	blogCsrPath  = path.Join(ProjectRoot(), ""test/fixture/certs/blog_csr.pem"")
++	blogSvidPath = path.Join(ProjectRoot(), ""test/fixture/certs/blog_cert.pem"")
+ )
+
+ // LoadCAFixture reads, parses, and returns the pre-defined CA fixture and key",What's the difference between blogSvid and the SVID above? Looks like the functions that use these aren't being called currently - can they be removed?,Do we need this in `initCAFixture` as
+10148,"@@ -67,7 +67,7 @@ namespace Nethermind.Serialization.Json
+                 return (long) reader.Value;
+             }
+
+-            string s = (string) reader.Value;
++            string s = reader.Value?.ToString();
+             if (s == ""0x0"")
+             {
+                 return BigInteger.Zero;",can you add numbers with this change? the CLI is a javascript engine and it can worh number - java adds strings vi concatenation,This is a bug fix. Please split into separate PR.
+10149,"@@ -116,6 +116,8 @@ class OrderDirective
+                 // Note the `lower()` in the `addOrderBy()`. It is essential to sorting the
+                 // results correctly. See also https://github.com/bolt/core/issues/1190
+                 // again: lower breaks postgresql jsonb compatibility, first cast as txt
++                // cast as TEXT or CHAR, depending on SQL support. See Bolt\Doctrine\Query\Cast.php
++                // and https://github.com/bolt/core/issues/2241
+                 $query
+                     ->getQueryBuilder()
+                     ->addOrderBy('lower(CAST(' . $translationsAlias . '.value as TEXT))', $direction);","Shouldn't this `TEXT` also be dependent on the platform, then?",The `addOrderBy` method also needs to be updated
+10150,"@@ -17,6 +17,15 @@ type Typer interface {
+ 	Type() semantic.MonoType
+ }
+
++// ITableObject serves as sort of a ""marker trait"" to allow us to check if a
++// value is a TableObject without having to import TableObject which would be a
++// cyclical import.
++// Identical purpose to the interface in the interpreter package, but sadly we
++// can't import it here because of yet another potential cycle.
++type ITableObject interface {
++	TableObject()
++}
++
+ type Value interface {
+ 	Typer
+ 	IsNull() bool","Can we name this `TableObject`? I'm not a big fan of the `I` prefix for interfaces and that's not really used in Go. Is it also possible to have the method be unexported? I don't know if that's possible. If it's not, this is good. If it is possible, I'd prefer this method to be unexported.",Would it be better to use this interface in the i
+10151,"@@ -31,11 +31,15 @@
+     #include <stdlib.h> // malloc and free
+     #include <tbb/tbb.h>
+     #include <tbb/spin_mutex.h>
+-    #include ""tbb/scalable_allocator.h""
++    #include <tbb/scalable_allocator.h>
+     #include <tbb/global_control.h>
+     #include <tbb/task_arena.h>
+     #include ""services/daal_atomic_int.h""
+
++    #if defined(TBB_INTERFACE_VERSION) && TBB_INTERFACE_VERSION >= 12002
++        #include <tbb/task.h>
++    #endif
++
+ using namespace daal::services;
+ #else
+     #include ""src/externals/service_service.h""","If tbb.h is included, there is no big sense to include other TBB headers.",why check for 12002?
+10152,"@@ -915,12 +915,9 @@ def uses_path_addressing(headers):
+ def get_bucket_name(path, headers):
+     parsed = urlparse.urlparse(path)
+
+-    # try pick the bucket_name from the path
+-    bucket_name = parsed.path.split('/')[1]
+-
+-    # is the hostname not starting with a bucket name?
+-    if uses_path_addressing(headers):
+-        return normalize_bucket_name(bucket_name)
++    # matches the common endpoints like
++    #     - '<bucket_name>.s3.<region>.*'
++    localstack_pattern = re.compile(r'^(.+)\.s3[.\-][a-z]{2}-[a-z]+-[0-9]{1,}.*')
+
+     # matches the common endpoints like
+     #     - '<bucket_name>.s3.<region>.amazonaws.com'",Let's use the same `S3_HOSTNAME_PATTERN` as above here.,Can we move this regex out of this function and into this place where it's used?
+10153,"@@ -215,6 +215,7 @@ function parseConnectionString(url, options) {
+     let r = parser.parse(f('mongodb://%s', hosts[i].trim()));
+     if (r.path && r.path.indexOf('.sock') !== -1) continue;
+     if (r.path && r.path.indexOf(':') !== -1) {
++      console.log(""R: "",r)
+       // Not connecting to a socket so check for an extra slash in the hostname.
+       // Using String#split as perf is better than match.
+       if (r.path.split('/').length > 1 && r.path.indexOf('::') === -1) {",This shouldn't be here.,Looks like this debug code should be removed.
+10154,"@@ -24,11 +24,16 @@ module ValueHelper
+   end
+
+   def property_to_s(val)
+-    # assume all decimals are currency
+-    if decimal?(val)
++    if decimal?(val) # assume all decimals are currency
+       number_to_currency(val)
++    elsif val.is_a?(ActiveSupport::TimeWithZone)
++      I18n.l(val, format: :date)
++    elsif val == true
++      ""Yes""
++    elsif val == false
++      ""No""
+     else
+-      val.to_s
++      val
+     end
+   end
+ end",A `case` statement may be simpler here.,Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+10155,"@@ -1081,10 +1081,15 @@ public class JDBCConnection implements ObjectStoreConnection {
+             throw notFoundError(caller, ZMSConsts.OBJECT_DOMAIN, domainName);
+         }
+         int curTagCount = getDomainTagsCount(domainId);
+-        int remainingTagsToInsert = domainTagsLimit - curTagCount;
++        int newTagCount = calculateTagCount(tags);
++        if (curTagCount + newTagCount > domainTagsLimit) {
++            throw ZMSUtils.quotaLimitError(""domain tag quota exceeded - limit: ""
++                + domainTagsLimit + "", current tags count: "" + curTagCount + "", new tags count: "" + newTagCount, caller);
++        }
++
+         boolean res = true;
+         for (Map.Entry<String, StringList> e : tags.entrySet()) {
+-            for (int i = 0; i < e.getValue().getList().size() && remainingTagsToInsert-- > 0; i++) {
++            for (int i = 0; i < e.getValue().getList().size(); i++) {
+                 String tagValue = e.getValue().getList().get(i);
+                 try (PreparedStatement ps = con.prepareStatement(SQL_INSERT_DOMAIN_TAG)) {
+                     ps.setInt(1, domainId);",why are we adding the current tag count to new tag count ?,"The current tags count and new tags count should be the same, right?"
+10156,"@@ -12,7 +12,7 @@ func (c *ServerConfig) SetServerMode(port int, network, netmask string) {
+
+ func (c *ServerConfig) SetTLSServer() {
+ 	c.setFlag(""tls-server"")
+-	c.AddOptions(OptionFile(""dh"", ""none""))
++	c.AddOptions(OptionFile(""dh"", ""none"", ""none""))
+ }
+
+ func (c *ServerConfig) SetProtocol(protocol string) {","Are you writing ""none"" to file content? no good",Do we have a test case that confirms that `none` does not exist?
+10157,"@@ -21,10 +21,10 @@ class SnippetWidget extends BaseWidget
+         string $target = Target::NOWHERE,
+         string $zone = RequestZone::NOWHERE
+     ) {
+-        $this->template = $snippet;
+-        $this->name = $name;
+-        $this->target = $target;
+-        $this->zone = $zone;
++        $this->setTemplate($snippet);
++        $this->setName($name);
++        $this->setTargets([$target]);
++        $this->setZone($zone);
+     }
+
+     protected function run(array $params = []): ?string",Should we allow `string|string[]` here?,"`$this->setTargets([$target], []);` or `$this->setTargets([$targ"
+10158,"@@ -546,7 +546,17 @@ module.exports = class Dashboard extends Plugin {
+     })
+
+     // 4. Add all dropped files
+-    getDroppedFiles(event.dataTransfer)
++    let executedDropErrorOnce = false
++    const logDropError = (error) => {
++      this.uppy.log(error.message, 'error')
++
++      // In practice all drop errors are most likely the same, so let's just show one to avoid overwhelming the user
++      if (!executedDropErrorOnce) {
++        this.uppy.info(error.message, 'error')
++        executedDropErrorOnce = true
++      }
++    }
++    getDroppedFiles(event.dataTransfer, { logDropError })
+       .then((files) => {
+         if (files.length > 0) {
+           this.uppy.log('[Dashboard] Files were dropped')","Is there a reason for logging `error.message` specifically, maybe log the whole error object?","This would be a good place to use a real function, e.g. `logDrop"
+10159,"@@ -42,7 +42,9 @@ namespace OpenTelemetry.Trace
+             var aspnetOptions = new AspNetInstrumentationOptions();
+             configureAspNetInstrumentationOptions?.Invoke(aspnetOptions);
+
+-            builder.AddDiagnosticSourceInstrumentation((activitySource) => new AspNetInstrumentation(activitySource, aspnetOptions));
++            builder.AddInstrumentation(() => new AspNetInstrumentation(aspnetOptions));
++            builder.AddSource(typeof(AspNetInstrumentation).Assembly.GetName().Name);
++            builder.AddLegacyActivityOperationName(""Microsoft.AspNet.HttpReqIn"");
+
+             return builder;
+         }",Why is this needed?,What do you think about using `nameof` instead of hard-coding `M
+10160,"@@ -404,6 +404,14 @@ func (proxy *Proxy) ContainerStarted(ident string) {
+ 	proxy.notifyWaiters(ident, err)
+ }
+
++func (proxy *Proxy) ContainerConnected(ident string) {
++	err := proxy.attach(ident)
++	// if err != nil {
++	// TODO: Not sure what is needed here.
++	// }
++	proxy.notifyWaiters(ident, err)
++}
++
+ func containerShouldAttach(container *docker.Container) bool {
+ 	return len(container.Config.Entrypoint) > 0 && container.Config.Entrypoint[0] == weaveWaitEntrypoint[0]
+ }","Nothing. We only expect container-connected events when going via the plugin, not the proxy.",I think I agree with @fdawg4l's suggestion here. I would like to see a test that attempts to connect to a docker container that has already been attached.
+10161,"@@ -11,6 +11,8 @@ import { mount } from './diff/mount';
+ import { patch } from './diff/patch';
+ import { createInternal } from './tree';
+
++let rootId = 0;
++
+ /**
+  *
+  * @param {import('./internal').PreactElement} parentDom The DOM element to","We might want to introduce some randomness here in case there are multiple completely separate Preact installations running, i.e. 2 widgets as those will be two roots with a resetting `_domDepth`",Nit: I would call this `rootId`
+10162,"@@ -488,7 +488,7 @@ func TestPushChunkToNextClosest(t *testing.T) {
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}
+-	if ta2.Get(tags.StateSent) != 2 {
++	if ta2.Get(tags.StateSent) != 1 {
+ 		t.Fatalf(""tags error"")
+ 	}
+ ",this seems a bit wrong no? why is this change needed?,Why did this change?
+10163,"@@ -145,7 +145,7 @@ Transaction.prototype._validateFees = function() {
+     return 'Fee is more than ' + Transaction.FEE_SECURITY_MARGIN + ' times the suggested amount';
+   }
+   if (this._getUnspentValue() < this._estimateFee() / Transaction.FEE_SECURITY_MARGIN) {
+-    return 'Fee is less than ' + Transaction.FEE_SECURITY_MARGIN + ' times the suggested amount';
++    return 'Fee is ' + Transaction.FEE_SECURITY_MARGIN + ' times less than the suggested amount';
+   }
+ };
+ ",Still confusing. Why don't we return something like `'Fee too low: expected X but found Y'`?,"Shouldn't it be ""is less than"" instead of ""less than""?"
+10164,"@@ -81,14 +81,16 @@ type ProviderModeConfig struct {
+ type ConsumerConfig struct {
+ 	PublicKey string `json:""PublicKey""`
+ 	// IP is needed when provider is behind NAT. In such case provider parses this IP and tries to ping consumer.
+-	IP string `json:""IP,omitempty""`
++	IP    string `json:""IP,omitempty""`
++	Ports []int  `json:""Ports""`
+ }
+
+ // ServiceConfig represent a Wireguard service provider configuration that will be passed to the consumer for establishing a connection.
+ type ServiceConfig struct {
+ 	// LocalPort and RemotePort are needed for NAT hole punching only.
+-	LocalPort  int `json:""-""`
+-	RemotePort int `json:""-""`
++	LocalPort  int   `json:""-""`
++	RemotePort int   `json:""-""`
++	Ports      []int `json:""Ports""`
+
+ 	Provider struct {
+ 		PublicKey string","Should be from lowercase `json:""ports""` the same is defined in MarshalJSON",What is the purpose of this change?
+10165,"@@ -3,7 +3,7 @@
+
+ # Purpose:
+ # sns-ruby-example-create-subscription.rb demonstrates how to create an Amazon Simple Notification Services (SNS) subscription using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+
+ # Inputs:
+ # - REGION",Simple Notification **Service** (singular),Line is too long. [84/80]
+10166,"@@ -32,7 +32,9 @@ public class NashornScriptInterpreter implements ScriptInterpreter {
+
+     @Override
+     public void runScript(String scriptContent, Consumer<Exception> errorCallback) {
+-        nashornEngineFactory.createEngine().eval(scriptContent, errorCallback);
++        final NashornEngine engine = nashornEngineFactory.createEngine();
++        engine.eval(""var tr = Packages.org.phoenicis.configuration.localisation.Localisation.tr;"", errorCallback);
++        engine.eval(scriptContent, errorCallback);
+     }
+
+     @Override",This code should be executed in NashornEngineFactory,Would it make sense to move this to
+10167,"@@ -53,6 +53,7 @@ type Tags struct {
+
+ // NewTags creates a tags object
+ func NewTags(stateStore storage.StateStorer, logger logging.Logger) *Tags {
++	rand.Seed(time.Now().UnixNano())
+ 	return &Tags{
+ 		tags:       &sync.Map{},
+ 		stateStore: stateStore,","this is not so great as it sets the global rand seed. in tests that invoke this method multiple times for whatever reason, the global seed would be overridden every time the constructor would be called and the instances would have a different seed after every constructor call. it would be better to just pass a new source here as a parameter and do the same within the test. it should simplify things and clean this up",Why do we need this?
+10168,"@@ -831,6 +831,14 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       arity = ""1"")
+   private final Wei txFeeCap = DEFAULT_RPC_TX_FEE_CAP;
+
++  @Option(
++      names = {""--rpc-require-chainid-in-txs""},
++      description =
++          ""Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"",
++      arity = ""1"")
++  // TODO: set default to false for next major release
++  private final Boolean unprotectedTransactionsAllowed = true;
++
+   @Option(
+       names = {""--min-block-occupancy-ratio""},
+       description = ""Minimum occupancy ratio for a mined block (default: ${DEFAULT-VALUE})"",","This looks inverted to me: if `--rpc-require-chainid-in-txs=true`, then shouldn't `unprotectedTransactionsAllowed == false`? Suggest changing this variable to `requireTxReplayProtection` or similar. I think the flag name could be clearer as well, maybe: `--require-tx-replay-protection`.","""Allow for unprotected transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"""
diff --git a/data/msg-test.hf_pred.csv b/data/msg-test.hf_pred.csv
new file mode 100644
index 0000000..63f1186
--- /dev/null
+++ b/data/msg-test.hf_pred.csv
@@ -0,0 +1,122419 @@
+,code,target,prediction
+0,"@@ -53,7 +53,7 @@ public class ProtocGapicPluginGeneratorTest {
+                 model.getFiles().stream().map(ProtoFile::getProto).collect(Collectors.toList()))
+             // Only the file to generate a client for (don't generate dependencies)
+             .addFileToGenerate(""multiple_services.proto"")
+-            .setParameter(""language=java"")
++            .setParameter(""language=java,transport=grpc"")
+             .build();
+ 
+     CodeGeneratorResponse response = ProtocGeneratorMain.generate(codeGeneratorRequest);",can we also test for `transport=rest`?,Why do we need this change?
+1,"@@ -182,7 +182,9 @@ abstract class AbstractSolrBackendFactory implements FactoryInterface
+      */
+     protected function createBackend(Connector $connector)
+     {
++        $config = $this->config->get($this->mainConfig);
+         $backend = new $this->backendClass($connector);
++        $backend->setPageSize($config->Index->record_batch_size);
+         $backend->setQueryBuilder($this->createQueryBuilder());
+         $backend->setSimilarBuilder($this->createSimilarBuilder());
+         if ($this->logger) {","If record_batch_size is not set in config.ini, this code will trigger a notice about an undefined value. I would suggest either wrapping the setPageSize() call in an `if (!empty(...)) {` check, or else providing a default value in the set call (i.e. `$config->Index->record_batch_size ?? 100`).",Why do we need to set this 
+2,"@@ -1,6 +1,6 @@
+ <script type=""text/javascript"">
+   window.analytics||(window.analytics=[]),window.analytics.methods=[""identify"",""track"",""trackLink"",""trackForm"",""trackClick"",""trackSubmit"",""page"",""pageview"",""ab"",""alias"",""ready"",""group"",""on"",""once"",""off""],window.analytics.factory=function(t){return function(){var a=Array.prototype.slice.call(arguments);return a.unshift(t),window.analytics.push(a),window.analytics}};for(var i=0;i<window.analytics.methods.length;i++){var method=window.analytics.methods[i];window.analytics[method]=window.analytics.factory(method)}window.analytics.load=function(t){var a=document.createElement(""script"");a.type=""text/javascript"",a.async=!0,a.src=(""https:""===document.location.protocol?""https://"":""http://"")+""d2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/""+t+""/analytics.min.js"";var n=document.getElementsByTagName(""script"")[0];n.parentNode.insertBefore(a,n)},window.analytics.SNIPPET_VERSION=""2.0.8"",
+-  window.analytics.load(""2nexpdgku3"");
++  window.analytics.load(<%= ENV['SEGMENT_KEY']%>);
+   window.analytics.page();
+ </script>
+ ","I didn't realize we were hardcoding this, thanks for moving it to an env value.",I don't think you need this
+3,"@@ -99,7 +99,7 @@ module.exports = function fileItem (props) {
+         }
+       </h4>
+       <div class=""UppyDashboardItem-status"">
+-        ${file.data.size && html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
++        ${isNaN(file.data.size) ? '' : html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
+         ${file.source && html`<div class=""UppyDashboardItem-sourceIcon"">
+             ${acquirers.map(acquirer => {
+               if (acquirer.id === file.source) return html`<span title=""${props.i18n('fileSource')}: ${acquirer.name}"">${acquirer.icon()}</span>`","We are trying to support IE 10-11, so we'll need a polyfill for this one, I think.",Why is this change needed?
+4,"@@ -38,6 +38,9 @@ const { useSelect, useDispatch } = Data;
+ function ResetButton( { children } ) {
+ 	const postResetURL = useSelect( ( select ) => select( CORE_SITE ).getAdminURL( 'googlesitekit-splash', { notification: 'reset_success' } ) );
+ 
++	const isNavigating = useSelect( ( select ) => select( CORE_LOCATION ).isNavigating() );
++	const navigatingURL = useSelect( ( select ) => select( CORE_LOCATION ).getNavigateURL() );
++
+ 	const [ dialogActive, setDialogActive ] = useState( false );
+ 
+ 	useEffect( () => {",It looks like there's a new `isNavigatingTo( url )` selector for this very purpose so let's use this here instead. This way we just need to use the one selector rather than two. Let's assign that to a similar-named variable here (e.g. `isNavigatingToPostResetURL`) rather than the prop it's used with.,Why do we need the `isNavigating` selector?
+5,"@@ -29,8 +29,8 @@
+ 
+ namespace lbann {
+ 
+-void im2col(const Mat& im,
+-            Mat& col,
++void im2col(const AbsMat& im,
++            AbsMat& col,
+             const int num_channels,
+             const int im_num_dims,
+             const int * im_dims,",I think im2col should only accommodate CPUMat.,Why not `const AbsMat&`?
+6,"@@ -24,6 +24,8 @@ from google.cloud.forseti.notifier.notifiers import cscc_notifier
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+ from google.cloud.forseti.services.inventory.storage import DataAccess
+ from google.cloud.forseti.services.scanner import dao as scanner_dao
++from google.cloud.forseti.common.util.email.email_factory import EmailFactory
++from google.cloud.forseti.notifier.notifiers import email_violations
+ # pylint: enable=line-too-long
+ 
+ ",alpha sort the imports,nit: import order
+7,"@@ -1067,7 +1067,7 @@ fpga_result mmio_error(struct RASCommandLine *rasCmdLine)
+ 	if ( rasCmdLine->function >0 )
+ 		function = rasCmdLine->bus;
+ 
+-	snprintf(sysfs_path, sizeof(sysfs_path),
++	snprintf_s_iiii(sysfs_path, sizeof(sysfs_path),
+ 			DEVICEID_PATH,0,bus,device,function);
+ 
+ 	result = sysfs_read_u64(sysfs_path, &value);",Can you explain why is this necessary? Is `snprintf()` with four integer arguments unsafe?,please use `snprintf_s_iiii`
+8,"@@ -219,7 +219,19 @@ def internal_keyDownEvent(vkCode,scanCode,extended,injected):
+ 			for k in range(256):
+ 				keyStates[k]=ctypes.windll.user32.GetKeyState(k)
+ 			charBuf=ctypes.create_unicode_buffer(5)
++			# First try getting the keyboard layout from the thread with the focus (input thread)
+ 			hkl=ctypes.windll.user32.GetKeyboardLayout(focus.windowThreadID)
++			if not hkl:
++				log.debug(""Failed to fetch keyboard layout from focus, trying layout from last detected change"")
++				# Some threads, such as for Windows consoles
++				# Do not allow getKeyboardLayout to work.
++				# Therefore, use the cached keyboard layout from the last inputLangChange detected by NVDA
++				# on the foreground object.
++				hkl = getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)
++				if not hkl:
++					log.debug(""No layout cached, falling back to layout of NVDA main thread"")
++					# As a last resort, use the keyboard layout of NVDA's main thread.
++					hkl = ctypes.windll.user32.GetKeyboardLayout(core.mainThreadId)
+ 			# In previous Windows builds, calling ToUnicodeEx would destroy keyboard buffer state and therefore cause the app to not produce the right WM_CHAR message.
+ 			# However, ToUnicodeEx now can take a new flag of 0x4, which stops it from destroying keyboard state, thus allowing us to safely call it here.
+ 			res=ctypes.windll.user32.ToUnicodeEx(vkCode,scanCode,keyStates,charBuf,len(charBuf),0x4,hkl)",How likely would it be that the keyboard layout for the NVDA main thread differs from the keyboard layout of the currently focused app?,"I think it would be better to use `getattr(api.getForegroundObject(), '_lastDetectedKeyboardLayoutChange', 0)` here."
+9,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++    
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`),Why do we need this?
+10,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below,`keys.then(keys => keys.join(''))`
+11,"@@ -39,6 +39,7 @@ func (p *Provisioner) ProvisionHostPath(opts pvController.VolumeOptions, volumeC
+ 	name := opts.PVName
+ 	stgType := volumeConfig.GetStorageType()
+ 	saName := getOpenEBSServiceAccountName()
++	shared := volumeConfig.GetSharedMountValue()
+ 
+ 	path, err := volumeConfig.GetPath()
+ 	if err != nil {","n_: It is a good practice to name the variable to indicate what they contain. In this case since `shared` is supposed to have boolean, calling it: `isShared` can help in the readability of the code.",Why do we need this?
+12,"@@ -85,7 +85,10 @@ export class ManualColumnFreeze extends BasePlugin {
+   }
+ 
+   /**
+-   * Freezes the given column (add it to fixed columns).
++   * Freezes the specified column (i.e. adds it to fixed columns).
++   *
++   * `freezeColumn()` doesn't re-render the table,
++   * so you need to call the `render()` method afterward.
+    *
+    * @param {number} column Visual column index.
+    */",I suppose it's a false-positive error. Maybe there is a way to configure the `eslint-*` package to accept `i.e. .... lower case` syntax  ,I don't think you need to call `render()` here.
+13,"@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace
+         private void RunGetRequestedDataOtherSampler(Activity activity)
+         {
+             ActivityContext parentContext;
+-            if (string.IsNullOrEmpty(activity.ParentId))
++            if (string.IsNullOrEmpty(activity.ParentId) || activity.ParentSpanId.ToHexString().Equals(""0000000000000000""))
+             {
+                 parentContext = default;
+             }","this maynot be a perf issue, if ToHexString() is not actually allocating a string, but returns the caches string value. to be confirmed.",Why do we need this?
+14,"@@ -114,11 +114,16 @@ func (w *watcher) run(ctx context.Context, provider imageprovider.Provider, inte
+ 				updates = append(updates, u...)
+ 			}
+ 			if len(updates) == 0 {
+-				w.logger.Info(""no image to be updated"")
++				w.logger.Info(""no image to be updated"",
++					zap.String(""image-provider"", provider.Name()),
++				)
+ 				continue
+ 			}
+ 			if err := update(updates); err != nil {
+-				w.logger.Error(""failed to update image"", zap.Error(err))
++				w.logger.Error(""failed to update image"", zap.String(""image-provider"",
++					provider.Name()),
++					zap.Error(err),
++				)
+ 				continue
+ 			}
+ 		}","`zap.String(""image-provider"", provider.Name())` should be in a same line.",I think this should be `image-provider-name`
+15,"@@ -1,8 +1,6 @@
+ /*exported DqElement */
+ 
+ function truncate(str, maxLength) {
+-	'use strict';
+-
+ 	maxLength = maxLength || 300;
+ 
+ 	if (str.length > maxLength) {",Why this deletion?,Why was this removed?
+16,"@@ -419,7 +419,10 @@ class S3KeyTest(unittest.TestCase):
+         remote_metadata = check._get_remote_metadata()
+ 
+         # TODO: investigate whether encoding ' ' as '%20' makes sense
+-        self.assertEqual(check.cache_control, 'public,%20max-age=500')
++        self.assertIn(
++            check.cache_control,
++            ('public,%20max-age=500', 'public, max-age=500')
++        )
+         self.assertEqual(remote_metadata['cache-control'], 'public,%20max-age=500')
+         self.assertEqual(check.get_metadata('test-plus'), 'A plus (+)')
+         self.assertEqual(check.content_disposition, 'filename=Sch%C3%B6ne%20Zeit.txt')",This change looks unrelated to the CL description?,"I think this should be `('public,%20max-age=500', 'public, max-age=500')`"
+17,"@@ -18,7 +18,7 @@ class DedupTest : public QueryTestBase {
+   void SetUp() override { QueryTestBase::SetUp(); }
+ };
+ 
+-#define DEDUP_RESUTL_CHECK(inputName, outputName, sentence, expected)                   \
++#define DEDUP_RESULT_CHECK(inputName, outputName, sentence, expected)                   \
+   do {                                                                                  \
+     qctx_->symTable()->newVariable(outputName);                                         \
+     auto yieldSentence = getYieldSentence(sentence, qctx_.get());                       \",I'm not certain that `res`+`utl` isn't a thing.,Why did you change this?
+18,"@@ -182,6 +182,7 @@ public class FetchActiveFlowDao {
+             + "" LEFT JOIN ""
+             + "" executors et ON ex.executor_id = et.id""
+             + "" WHERE ex.status NOT IN (""
++            + Status.EXECUTION_STOPPED.getNumVal() + "", ""
+             + Status.SUCCEEDED.getNumVal() + "", ""
+             + Status.KILLED.getNumVal() + "", ""
+             + Status.FAILED.getNumVal() + "")"";","This method can cause bugs. Why don't you use list of finalize statuses and then use join by comma and that will give you correct value. Use Apache Commons Lang library List<Integer> list = Arrays.asList(1,2,3,4,5,6,7); String str = org.apache.commons.lang.StringUtils.join(list, "",""); You can use it at multiple places shown in this diff.",I don't think this is correct. The status of the executor should be `STOP
+19,"@@ -23,7 +23,10 @@ void wlr_input_device_init(struct wlr_input_device *dev,
+ }
+ 
+ void wlr_input_device_destroy(struct wlr_input_device *dev) {
+-	if (!dev) return;
++	if (!dev) {
++		return;
++	}
++	
+ 	if (dev->_device) {
+ 		switch (dev->type) {
+ 		case WLR_INPUT_DEVICE_KEYBOARD:",Merge with next condition,Why is this change needed?
+20,"@@ -348,6 +348,7 @@ type appResourcesGetter interface {
+ 
+ type taskDeployer interface {
+ 	DeployTask(input *deploy.CreateTaskResourcesInput, opts ...cloudformation.StackOption) error
++	DeleteTask(task deploy.TaskStackInfo) error
+ }
+ 
+ type taskRunner interface {",Maybe add it when it is used.,Why do we need this?
+21,"@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
+     {'name': 'cloudsql_acl', 'enabled': False},
+     {'name': 'iam_policy', 'enabled': True}
+ ]}
++
++NONEXIST_ENABLED = {'scanners': [
++    {'name': 'bigquery', 'enabled': False},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': False},
++    {'name': 'non_exist_scanner', 'enabled': True}
++]}
++
++ALL_EXIST = {'scanners': [
++    {'name': 'bigquery', 'enabled': True},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': True},
++    {'name': 'iam_policy', 'enabled': True}
++]}",More clear naming: NONEXISTENT_ENABLED,I think this should 
+22,"@@ -282,10 +282,10 @@ public class TypeUtil {
+ 
+     switch (from.typeId()) {
+       case INTEGER:
+-        return to == Types.LongType.get();
++        return to.equals(Types.LongType.get());
+ 
+       case FLOAT:
+-        return to == Types.DoubleType.get();
++        return to.equals(Types.DoubleType.get());
+ 
+       case DECIMAL:
+         Types.DecimalType fromDecimal = (Types.DecimalType) from;",why is this change necessary?,Why do we need this 
+23,"@@ -178,9 +178,8 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter {
+ 
+   @Override
+   public String getFullNameFor(TypeModel type) {
+-    // TODO(andrealin): Remove this hack when null response types are implemented.
+-    if (type == null) {
+-      return ""nullFullName"";
++    if (type.isEmptyType()) {
++      return ""java.lang.Void"";
+     }
+     if (type instanceof DiscoveryRequestType) {
+       Method method = ((DiscoveryRequestType) type).parentMethod().getDiscoMethod();",make a SchemaTypeNameConverter.getTypeNameForEmptyType() and call that here.,Why is this change n
+24,"@@ -26,7 +26,10 @@ class TinyMCELanguage extends AbstractSmartyPlugin
+ 
+     public function __construct(Request $request)
+     {
+-        $this->locale = $request->getSession()->getLang()->getLocale();
++        if($request->getSession() != null)
++            $this->locale = $request->getSession()->getLang()->getLocale();
++        else
++            $this->locale = Lang::getDefaultLanguage()->getLocale();
+     }
+ 
+     public function guessTinyMCELanguage($params, \Smarty_Internal_Template $template)",Use braces on your conditional structures please,Please use braces even for one-liners.
+25,"@@ -16,6 +16,7 @@
+ 
+ DECLARE_string(u);
+ DECLARE_string(p);
++DEFINE_bool(enable_history, false, ""Whether to force saving the command history"");
+ 
+ namespace nebula {
+ namespace graph {","Great God, I have a question. This "".nebula_history"" file is used to save history commands. Is there a file size limit? When the file is large, does it take a long time to start initialization (loadHistory)? How did you think about this? Thx.","DEFINE_bool(save_history, false, ""Whet"
+26,"@@ -1004,8 +1004,9 @@ static void parseRecord (tokenInfo *const token)
+ 	 */
+ 	if (!isType (token, TOKEN_OPEN_PAREN))
+ 		readToken (token);
++	if (!isType (token, TOKEN_OPEN_PAREN))
++		return;
+ 
+-	Assert (isType (token, TOKEN_OPEN_PAREN));
+ 	do
+ 	{
+ 		if (isType (token, TOKEN_COMMA) ||",Isn't this the same check as two lines above?,Why did you remove this?
+27,"@@ -18,8 +18,11 @@ from mitmproxy import io
+ from mitmproxy import log
+ from mitmproxy import version
+ from mitmproxy import optmanager
++from mitmproxy import options
+ import mitmproxy.tools.web.master # noqa
+ 
++CONFIG_PATH = os.path.join(options.CA_DIR, 'config.yaml')
++
+ 
+ def flow_to_json(flow: mitmproxy.flow.Flow) -> dict:
+     """"""","Don't redefine, just import the existing one in `cmdline.py`. :)",Why do we need this?
+28,"@@ -92,7 +92,8 @@ module Mongoid
+       #
+       # @since 2.0.0.rc.7
+       def process_attribute(name, value)
+-        if store_as = aliased_fields.invert[name.to_s]
++        responds = respond_to?(""#{name}="")
++        if !responds && store_as = aliased_fields.invert[name.to_s]
+           name = store_as
+         end
+         responds = respond_to?(""#{name}="")","why not call `respond_to?(""#{name}="")` from the `if` line?",I think this should be `if respond_to?...`
+29,"@@ -215,7 +215,8 @@ public final class BlazeCidrLauncher extends CidrLauncher {
+         workingDir = workspaceRootDirectory;
+       }
+ 
+-      GeneralCommandLine commandLine = new GeneralCommandLine(runner.executableToDebug.getPath());
++      GeneralCommandLine commandLine = new GeneralCommandLine(runner.executableToDebug.getPath())
++          .withWorkDirectory(workingDir);
+ 
+       commandLine.addParameters(handlerState.getExeFlagsState().getFlagsForExternalProcesses());
+       commandLine.addParameters(handlerState.getTestArgs());",This was properly set above as `<target>.runfiles/<workspace_name>` (with a fallback to workspace root dir) but never used past this line.,Why is this change needed?
+30,"@@ -0,0 +1,13 @@
++using System;
++using System.Collections.Generic;
++using System.Linq;
++using System.Text;
++using System.Threading.Tasks;
++using MvvmCross.Core.Views;
++
++namespace MvvmCross.Uwp.Attributes
++{
++    public class MvxPagePresentationAttribute : MvxBasePresentationAttribute
++    {
++    }
++}",Are all these namespaces required for this attribute?,Is this needed?
+31,"@@ -53,9 +53,12 @@ module Beaker
+           result.stdout << std_out
+           result.stderr << std_err
+           result.exit_code = status.exitstatus
++          @logger.info(result.stdout)
++          @logger.info(result.stderr)
+         end
+       rescue => e
+         result.stderr << e.inspect
++        @logger.info(result.stderr)
+         result.exit_code = 1
+       end
+ ","Given this may be used and printed in other ways, isn't `debug` more appropriate?",Should this be `@logger.debug`?
+32,"@@ -540,3 +540,7 @@ func (s *blockDiskStore) remove(id kbfsblock.ID) error {
+ 	}
+ 	return err
+ }
++
++func (s blockDiskStore) clear() error {
++	return ioutil.RemoveAll(s.dir)
++}",Looks like this is unused? Did you mean to call it when clearing the block journal?,Why do we need this?
+33,"@@ -117,8 +117,10 @@ public class ExecutorManager extends EventHandler implements
+ 
+   public ExecutorManager(Props props, ExecutorLoader loader,
+       Map<String, Alerter> alters) throws ExecutorManagerException {
++    alerters = alters;
+     azkProps = props;
+     this.executorLoader = loader;
++
+     this.setupExecutors();
+     this.loadRunningFlows();
+ ",why named alters? how about this.alerts = alerts?,Why do we need this?
+34,"@@ -1549,7 +1549,7 @@ func (js *jetStream) processStreamLeaderChange(mset *stream, isLeader bool) {
+ 		resp.Error = jsError(err)
+ 		s.sendAPIErrResponse(client, acc, subject, reply, _EMPTY_, s.jsonResponse(&resp))
+ 	} else {
+-		resp.StreamInfo = &StreamInfo{Created: mset.createdTime(), State: mset.state(), Config: mset.config(), Cluster: js.clusterInfo(mset.raftGroup())}
++		resp.StreamInfo = &StreamInfo{Created: mset.createdTime(), State: mset.state(), Config: mset.config(), Cluster: js.clusterInfo(mset.raftGroup()), Sources: mset.sourcesInfo(), Mirror: mset.mirrorInfo()}
+ 		s.sendAPIResponse(client, acc, subject, reply, _EMPTY_, s.jsonResponse(&resp))
+ 		if node := mset.raftNode(); node != nil {
+ 			mset.sendCreateAdvisory()",not sure if this has to be here or not tbh,Why do we need to ad
+35,"@@ -72,7 +72,12 @@ func newHarnessUsingAutodelete(ctx context.Context, t *testing.T) (drivertest.Ha
+ }
+ 
+ func (h *harness) CreateTopic(ctx context.Context, testName string) (dt driver.Topic, cleanup func(), err error) {
++	// Keep the topic entity name under 50 characters as per Azure limits.
++	// See https://docs.microsoft.com/en-us/azure/service-bus-messaging/service-bus-quotas
+ 	topicName := fmt.Sprintf(""%s-topic-%d"", sanitize(testName), atomic.AddUint32(&h.numTopics, 1))
++	if len(topicName) > 50 {
++		topicName = topicName[:50]
++	}
+ 
+ 	createTopic(ctx, topicName, h.ns, nil)
+ ","There's a better fix for this in #1741, which should replace this.",Why do we need this?
+36,"@@ -63,7 +63,7 @@ func (s *StreamMock) Close() error {
+ func TestHandshake(t *testing.T) {
+ 	logger := logging.New(ioutil.Discard, 0)
+ 	info := Info{
+-		Address:   ""node1"",
++		Address:   []byte(""node1""),
+ 		NetworkID: 0,
+ 		Light:     false,
+ 	}","Use swarm.Address not []byte as type, and construct it from actual byteslice or use swarm.NewAddress if it is constructed from hex-encoded string.",Why this change?
+37,"@@ -80,8 +80,9 @@ func TestFSRepoInit(t *testing.T) {
+ 
+ 	dir, err := ioutil.TempDir("""", """")
+ 	assert.NoError(t, err)
+-
+-	defer os.RemoveAll(dir)
++	defer func() {
++		require.NoError(t, os.RemoveAll(dir))
++	}()
+ 
+ 	t.Log(""init FSRepo"")
+ 	assert.NoError(t, InitFSRepo(dir, config.NewDefaultConfig()))","It would be worth factoring this out to a function, but you don't have to do that here.",Why is this need
+38,"@@ -0,0 +1,15 @@
++package com.fsck.k9.message.html;
++
++/**
++ * General framework to handle uris when parsing. Allows different handling depending on the scheme identifier.
++ */
++public interface UriParser {
++    /**
++     * Parse and linkify scheme specific uri beginning from given position. The result will be written to given buffer.
++     * @param text String to parse uri from.
++     * @param startPos Position where uri starts (first letter of scheme).
++     * @param outputBuffer Buffer where linkified variant of uri is written to.
++     * @return Index where parsed uri ends (first non-uri letter). Should be startPos or smaller if no valid uri was found.
++     */
++    int linkifyUri(String text, int startPos, StringBuffer outputBuffer);
++}",There's no need for `final` in interfaces.,Why do we need t
+39,"@@ -101,6 +101,9 @@ namespace Datadog.Trace.OpenTracing
+                 case DatadogTags.ServiceName:
+                     Span.ServiceName = value;
+                     return this;
++                case DatadogTags.ServiceVersion:
++                    Span.SetTag(Tags.Version, value);
++                    return this;
+             }
+ 
+             if (key == global::OpenTracing.Tag.Tags.Error.Key)",Isn't this case handled as a custom tag in `Span.SetTag()` below? This switch is only for special tags that actually set `Span` properties.,I think this sho
+40,"@@ -681,7 +681,6 @@ class Quitter:
+     @cmdutils.argument('session', completion=miscmodels.session)
+     def quit(self, save=False, session=None):
+         """"""Quit qutebrowser.
+-
+         Args:
+             save: When given, save the open windows even if auto_save.session
+                   is turned off.",This shouldn't be changed.,Why did you remove this?
+41,"@@ -1,5 +1,5 @@
+ ## This file is part of Invenio.
+-## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 CERN.
++## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","This one is important `2: I102 copyright year is outdated, expected 2014 but got 2012`","## Copyright (C) 2004, 2"
+42,"@@ -32,6 +32,8 @@ import java.util.Map;
+ import java.util.Optional;
+ import java.util.Set;
+ import java.util.concurrent.TimeoutException;
++import java.util.function.BiConsumer;
++import java.util.function.Consumer;
+ 
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;","Are these imports needed (BiConsumer and Consumer)? If they are unused imports, then precommit will fail.",Why is this needed?
+43,"@@ -0,0 +1,10 @@
++class TraceDestroyerJob < ApplicationJob
++  queue_as :default
++
++  def perform(trace)
++    trace.destroy
++  rescue StandardError => ex
++    logger.info ex.to_s
++    ex.backtrace.each { |l| logger.info l }
++  end
++end",Why are we catching and logging exceptions? By doing that we make it look like the job has succeeded and it will be removed from the queue - if we didn't do that then it would stay queued...,Should this be `logger.e
+44,"@@ -90,14 +90,11 @@ class CartController extends FrontBaseController
+      */
+     public function indexAction(Request $request)
+     {
+-        $cart = $this->cartFacade->getCartOfCurrentCustomer();
+-
+-        if ($cart->isEmpty()) {
+-            $this->cartFacade->cleanAdditionalData();
+-        }
++        $cart = $this->cartFacade->findCartOfCurrentCustomer();
++        $cartItems = $cart === null ? [] : $cart->getItems();
+ 
+         $cartFormData = ['quantities' => []];
+-        foreach ($cart->getItems() as $cartItem) {
++        foreach ($cartItems as $cartItem) {
+             $cartFormData['quantities'][$cartItem->getId()] = $cartItem->getQuantity();
+         }
+ ","If there are `@param` tags in docblock, there should be `@return` tag also. (applies for a whole file)",`$cart === null` is not needed.
+45,"@@ -34,7 +34,8 @@ public enum BesuMetricCategory implements MetricCategory {
+   PRUNER(""pruner""),
+   RPC(""rpc""),
+   SYNCHRONIZER(""synchronizer""),
+-  TRANSACTION_POOL(""transaction_pool"");
++  TRANSACTION_POOL(""transaction_pool""),
++  VALIDATORS(""validators"");
+ 
+   private static final Optional<String> BESU_PREFIX = Optional.of(""besu_"");
+   public static final Set<MetricCategory> DEFAULT_METRIC_CATEGORIES;",Is the concept of validators exclusive to IBFT2? I wonder if this category should be more explicitly linked to IBFT2.,Why do we need this?
+46,"@@ -14,9 +14,7 @@
+  */
+ package org.hyperledger.besu.tests.acceptance.dsl.account;
+ 
+-import org.hyperledger.besu.crypto.SECP256K1.KeyPair;
+-import org.hyperledger.besu.crypto.SECP256K1.PrivateKey;
+-import org.hyperledger.besu.crypto.SECP256K1.PublicKey;
++import org.hyperledger.besu.crypto.*;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.Hash;
+ import org.hyperledger.besu.tests.acceptance.dsl.blockchain.Amount;",Spotless is configured to reject star imports. Please replace with explicit imports.,Please don't use star imports.
+47,"@@ -115,6 +115,8 @@ void SYCLInternal::initialize(const sycl::device& d) {
+ 
+     m_maxThreadsPerSM =
+         d.template get_info<sycl::info::device::max_work_group_size>();
++    m_maxShmemPerBlock =
++        d.template get_info<sycl::info::device::local_mem_size>();
+     m_indirectKernelMem.reset(*m_queue);
+     m_indirectReducerMem.reset(*m_queue);
+   } else {",Remind me why you are using CUDA vocabulary when naming these variables.,Why do we need this?
+48,"@@ -898,6 +898,16 @@ public final class DBReader {
+         }
+         final LongIntMap feedCounters = adapter.getFeedCounters(feedIds);
+ 
++        int feedFilter = UserPreferences.getFeedFilter();
++        if (feedFilter == UserPreferences.FEED_FILTER_COUNTER_ZERO) {
++            for (int i = 0; i < feeds.size(); i++) {
++                if (feedCounters.get(feeds.get(i).getId()) <= 0) {
++                    feedCounters.delete(feeds.get(i).getId());
++                    feeds.remove(i);
++                }
++            }
++        }
++
+         Comparator<Feed> comparator;
+         int feedOrder = UserPreferences.getFeedOrder();
+         if (feedOrder == UserPreferences.FEED_ORDER_COUNTER) {",Please turn the iteration order around (instead of `0...size` to `size...0`). The reason is that this sometimes skips indices when removing an item. You can therefore end up with feeds that have counter 0 and are still displayed.,Shouldn't this be `feeds.remove(i)`?
+49,"@@ -620,7 +620,7 @@ def execute_reentrant_pipeline(pipeline, typed_environment, throw_on_error, reen
+ def get_subset_pipeline(pipeline, solid_subset):
+     check.inst_param(pipeline, 'pipeline', PipelineDefinition)
+     check.opt_list_param(solid_subset, 'solid_subset', of_type=str)
+-    return pipeline if solid_subset is None else build_sub_pipeline(pipeline, solid_subset)
++    return pipeline if not solid_subset else build_sub_pipeline(pipeline, solid_subset)
+ 
+ 
+ def create_typed_environment(pipeline, environment=None):",this is a behavior change. solid_subset=[] represents an empty pipeline where as solid_subset=None is the full pipeline,Why this change?
+50,"@@ -318,8 +318,7 @@ Licensed under the MIT License. See License.txt in the project root for license
+             {
+                 foreach (var unmatchedSetting in CustomSettings.Keys)
+                 {
+-                    Logger.LogError(new ArgumentException(unmatchedSetting),
+-                        Resources.ParameterIsNotValid, unmatchedSetting);
++                    Logger.LogWarning(Resources.ParameterIsNotValid, unmatchedSetting);
+                 }
+             }
+             ErrorManager.ThrowErrors();","this is a breaking change, any specific reason you want to do this?",Why did you remove the ArgumentExcep
+51,"@@ -91,6 +91,8 @@ type nodeChainReader interface {
+ 	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ 	HeadEvents() *ps.PubSub
+ 	Load(context.Context) error
++	PutTipSetAndState(context.Context, *chain.TipSetAndState) error
++	SetHead(context.Context, types.TipSet) error
+ 	Stop()
+ }
+ ","Blocking: we still want read write separation. Node functions should absolutely not write to the chain store and the interface should reflect that. Only the syncer should have this capability in production code. It should be no problem to keep casting chainForTest to a read-write interface, or doing other function decomposition and automatic casting tricks.",Why do we need this?
+52,"@@ -22,7 +22,8 @@ const (
+ 	minimalPrefetchWorkerQueueSize       int = 1
+ 	testBlockRetrievalWorkerQueueSize    int = 5
+ 	testPrefetchWorkerQueueSize          int = 1
+-	defaultOnDemandRequestPriority       int = 100
++	defaultOnDemandRequestPriority       int = 1<<30 - 1
++	lowestTriggerPrefetchPriority        int = 1
+ 	// Channel buffer size can be big because we use the empty struct.
+ 	workerQueueSize int = 1<<31 - 1
+ )",The PR description says the lowest on-demand request priority is `2^30`. Why the `-1` here?,Why do we need this?
+53,"@@ -609,6 +609,14 @@ bool Game::removeCreature(Creature* creature, bool isLogout/* = true*/)
+ 	return true;
+ }
+ 
++void Game::executeDeath(uint32_t creatureId)
++{
++	Creature* creature = getCreatureByID(creatureId);
++	if (creature && !creature->isRemoved() && creature->getHealth() < 1) {
++		creature->onDeath();
++	}
++}
++
+ void Game::playerMoveThing(uint32_t playerId, const Position& fromPos,
+                            uint16_t spriteId, uint8_t fromStackPos, const Position& toPos, uint8_t count)
+ {",checking health again? I think it is not necessary.,you should check if 
+54,"@@ -442,7 +442,18 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			log.WithError(err).Error(""Failed to connect to Typha. Retrying..."")
++			startTime := time.Now()
++			for err != nil && time.Since(startTime) < 30*time.Second {
++				// Set Ready to false and Live to true when unable to connect to typha
++				healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Debug(""Retrying to start Typha"")
++				time.Sleep(1 * time.Second)
++			}
++			if err != nil {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()",Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.,Should this be `time
+55,"@@ -0,0 +1,18 @@
++'use strict';
++
++const assert = require('assert');
++
++class ProvidedPromise {
++  set Promise(lib) {
++    assert.ok(typeof lib === 'function', `mongodb.Promise must be a function, got ${lib}`);
++    this._promise = lib;
++  }
++  get Promise() {
++    return this._promise;
++  }
++}
++
++const provided = new ProvidedPromise();
++provided.Promise = global.Promise;
++
++module.exports = provided;","to reiterate my point above, this class is not the actual provided Promise, but rather something a user can provide a Promise to/with. I think a name like `PromiseProvider` is more appropriate.",Why is this needed?
+56,"@@ -738,6 +738,12 @@ func addDep(s *scope, args []pyObject) pyObject {
+ 	dep := core.ParseBuildLabelContext(string(args[1].(pyString)), s.pkg)
+ 	exported := args[2].IsTruthy()
+ 	target.AddMaybeExportedDependency(dep, exported, false, false)
++	// Queue this dependency if it'll be needed.
++	if target.State() > core.Inactive {
++		err := s.state.QueueTarget(dep, target.Label, true, false)
++		s.Assert(err == nil, ""%s"", err)
++	}
++	// TODO(peterebden): Do we even need the following any more?
+ 	s.pkg.MarkTargetModified(target)
+ 	return None
+ }","I guess we can only call this from a post-build function, but we might need to check that this target is to be built? I guess target A depends on B which has a post build. We `plz build :B` which adds C as a dep of A. Won't we queue C to be built even though it only needs to build if A needs to be built? That's kinda why I approached this the way I did. I trust you've thought about this but would be good to understand this a bit better.","I don't think this is the right place to do this. If the target is already in the inactive state, we should not queue it again."
+57,"@@ -123,7 +123,7 @@ def sndrcv(pks, pkt, timeout = None, inter = 0, verbose=None, chainCC=0, retry=0
+                                 if remaintime <= 0:
+                                     break
+                             r = None
+-                            if arch.FREEBSD or arch.DARWIN:
++                            if not (pks.__class__.__name__ == 'StreamSocket') and (arch.FREEBSD or arch.DARWIN):
+                                 inp, out, err = select(inmask,[],[], 0.05)
+                                 if len(inp) == 0 or pks in inp:
+                                     r = pks.nonblock_recv()",You should use `isinstance()` instead of comparing the class name to a string.,`pks.__class__.__name__ != 'StreamSocket'`
+58,"@@ -15,6 +15,11 @@ axe.utils.isHidden = function isHidden(el, recursed) {
+ 		return false;
+ 	}
+ 
++	// do not exclude `video` or `audio` el's
++	if ([`VIDEO`, `AUDIO`].includes(el.nodeName.toUpperCase())) {
++		return false;
++	}
++
+ 	// 11 === Node.DOCUMENT_FRAGMENT_NODE
+ 	if (el.nodeType === 11) {
+ 		el = el.host; // grab the host Node",Why should audio and video elements always return `false` for `isHidden`?,Why do we need to exclude `VIDEO`?
+59,"@@ -27,7 +27,7 @@ namespace Playground.Core
+ 
+             Mvx.IoCProvider.RegisterSingleton<IMvxTextProvider>(new TextProviderBuilder().TextProvider);
+ 
+-            RegisterAppStart<RootViewModel>();
++            // RegisterAppStart<RootViewModel>();
+         }
+ 
+         /// <summary>",This obviously won't work for all the other platforms.,Is this intentional?
+60,"@@ -15,7 +15,7 @@ public class ManipulationTest extends BasicJBehaveTest {
+ 
+     @Override
+     public InjectableStepsFactory stepsFactory() {
+-        Map<String, Object> state = new HashMap<String, Object>();
++        Map<String, Object> state = new HashMap<>();
+ 
+         return new InstanceStepsFactory(configuration(),
+                 new SharedSteps(state),",Isn't he diamond operator Java7+?,Why this change?
+61,"@@ -159,6 +159,17 @@ public final class Require {
+     return number;
+   }
+ 
++  public static double positive(String argName, double number, String message) {
++    if (number <= 0) {
++      if (message == null) {
++        throw new IllegalArgumentException(argName + "" must be greater than 0"");
++      } else {
++        throw new IllegalArgumentException(message);
++      }
++    }
++    return number;
++  }
++
+   public static int positive(String argName, Integer number) {
+     return positive(argName, number, null);
+   }","Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly.",I think it would
+62,"@@ -474,7 +474,7 @@ func (rule removeCount) Name() string {
+ func (rule removeCount) Pattern() plan.Pattern {
+ 	return plan.Pat(universe.CountKind, plan.Any())
+ }
+-func (rule removeCount) Rewrite(ctx context.Context, node plan.Node) (plan.Node, bool, error) {
++func (rule removeCount) Rewrite(ctx context.Context, node plan.Node, nextNodeId *int) (plan.Node, bool, error) {
+ 	return node.Predecessors()[0], true, nil
+ }
+ ","This pattern, where we add a new parameter without using it, often indicates to me that we've got a leaky interface or abstraction. I see this pattern _a lot_ in this patch, so wondering you have thoughts about it.",Why do we need t
+63,"@@ -164,10 +164,13 @@ func WriteWordpressConfig(wordpressConfig *WordpressConfig, filePath string) err
+ 		return err
+ 	}
+ 
+-	// Ensure target directory is writable.
++	// Ensure target directory exists and is writeable
+ 	dir := filepath.Dir(filePath)
+-	err = os.Chmod(dir, 0755)
+-	if err != nil {
++	if err = os.Chmod(dir, 0755); os.IsNotExist(err) {
++		if err = os.MkdirAll(dir, 0755); err != nil {
++			return err
++		}
++	} else if err != nil {
+ 		return err
+ 	}
+ ",This seems like an improved pattern :),Why do we need t
+64,"@@ -127,16 +127,16 @@ class UserController < ApplicationController
+         # valid OpenID and one the user has control over before saving
+         # it as a password equivalent for the user.
+         session[:new_user_settings] = params
+-        openid_verify(params[:user][:openid_url], @user)
++        federated_verify(params[:user][:openid_url], @user)
+       else
+         update_user(@user, params)
+       end
+-    elsif using_open_id?
++    elsif using_federated_login?
+       # The redirect from the OpenID provider reenters here
+       # again and we need to pass the parameters through to
+       # the open_id_authentication function
+       settings = session.delete(:new_user_settings)
+-      openid_verify(nil, @user) do |user|
++      federated_verify(nil, @user) do |user|
+         update_user(user, settings)
+       end
+     end","`open_id_authentication` is no longer the name of the function, and it's not OpenID specific",Style/IfUnlessModifier: Favor modifier when having a single-line body. Another good alternative is the usage of control flow &&/||.
+65,"@@ -243,10 +243,10 @@ void rai_qt::accounts::refresh_wallet_balance ()
+ 		balance = balance + (this->wallet.node.ledger.account_balance (transaction, key));
+ 		pending = pending + (this->wallet.node.ledger.account_pending (transaction, key));
+ 	}
+-	auto final_text (std::string (""Wallet balance (XRB): "") + wallet.format_balance (balance));
++	auto final_text (std::string (""Balance: "") + wallet.format_balance (balance));
+ 	if (!pending.is_zero ())
+ 	{
+-		final_text += ""\nWallet pending: "" + wallet.format_balance (pending);
++		final_text += ""\nPending: "" + wallet.format_balance (pending);
+ 	}
+ 	wallet_balance_label->setText (QString (final_text.c_str ()));
+ 	this->wallet.node.alarm.add (std::chrono::system_clock::now () + std::chrono::seconds (60), [this]() {",This didn't require corresponding changes to the test case(s)?,Why did you remove the `(XRB)`?
+66,"@@ -509,6 +509,7 @@ type TaskConfig struct {
+ 	Count          Count                `yaml:""count""`
+ 	ExecuteCommand ExecuteCommand       `yaml:""exec""`
+ 	Variables      map[string]string    `yaml:""variables""`
++	EnvFile        string               `yaml:""env_file""`
+ 	Secrets        map[string]string    `yaml:""secrets""`
+ 	Storage        Storage              `yaml:""storage""`
+ }","A question! I think `string` totally works, but what do you think of `*string` for consistency?",Why do we need this?
+67,"@@ -25,6 +25,12 @@ import (
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+ 
++const (
++	AnnotationClusterInfrastructureReady = ""aws.cluster.sigs.k8s.io/infrastructure-ready""
++	AnnotationControlPlaneReady          = ""aws.cluster.sigs.k8s.io/control-plane-ready""
++	ValueReady                           = ""true""
++)
++
+ // AWSResourceReference is a reference to a specific AWS resource by ID, ARN, or filters.
+ // Only one of ID, ARN or Filters may be specified. Specifying more than one will result in
+ // a validation error.",Should this be: `aws.infrastructure.cluster.sigs.k8s.io` instead?,I think this should be `aws.cluster.infrastructure-ready`
+68,"@@ -142,7 +142,7 @@ void PairLubricate::compute(int eflag, int vflag)
+     Ef[2][2] = h_rate[2]/domain->zprd;
+     Ef[0][1] = Ef[1][0] = 0.5 * h_rate[5]/domain->yprd;
+     Ef[0][2] = Ef[2][0] = 0.5 * h_rate[4]/domain->zprd;
+-    Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->zprd;
++    Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->xprd;
+ 
+     // copy updated velocity/omega/angmom to the ghost particles
+     // no need to do this if not shearing since comm->ghost_velocity is set",Not clear on why this change is correct.,Ef[1][2] = Ef[2][1] = 0.5 * h_rate[3]/domain->yprd;
+69,"@@ -193,5 +193,10 @@ public final class ByteBuffersIndexInput extends IndexInput implements RandomAcc
+     if (in == null) {
+       throw new AlreadyClosedException(""Already closed."");
+     }
+-  }  
++  }
++
++  @Override
++  public boolean isMMapped() {
++    return true;
++  }
+ }","Hi Simon. Whether this should return true depends on what byte buffers are used? The same applies to ByteBufferIndexInput, actually... I don't think you can generally tell whether the ByteBuffers the input operates on come from a mmap call or from somewhere else (even direct buffers don't have to be a result of mmap).",Why is this needed?
+70,"@@ -54,6 +54,7 @@ storiesOf( 'PageSpeed Insights Module/Settings', module )
+ 		decorators: [
+ 			withRegistry,
+ 		],
++		padding: 0,
+ 	} )
+ 	.add( 'View, open with all settings', ( args, { registry } ) => {
+ 		return <Settings isOpen={ true } registry={ registry } />;",All stories in this file also need to have the default padding.,Why do we need this?
+71,"@@ -804,8 +804,10 @@ static void subsurface_handle_place_above(struct wl_client *client,
+ 		return;
+ 	}
+ 
++	assert(sibling->parent == subsurface->parent);
++
+ 	wl_list_remove(&subsurface->parent_pending_link);
+-	wl_list_insert(&sibling->parent_pending_link,
++	wl_list_insert(sibling->parent_pending_link.prev,
+ 		&subsurface->parent_pending_link);
+ 
+ 	subsurface->reordered = true;","I don't think these asserts are necessary, because `subsurface_find_sibling` already searches in the parent. Or am I missing something?",Why is this needed?
+72,"@@ -0,0 +1,15 @@
++class Episode < ActiveRecord::Base
++  attr_accessible :title, :duration, :file, :description, :published_on, :notes,
++    :old_url, :file_size
++
++  validates_presence_of :title, :duration, :file, :file_size, :description,
++    :published_on
++
++  def self.published
++    where(""published_on <= ?"", Date.today).order('published_on desc')
++  end
++
++  def full_title
++    ""Episode #{id}: #{title}""
++  end
++end",Should this be `number` instead of `id`?,Extra empty line detected at class body beginning.
+73,"@@ -1569,12 +1569,11 @@ NATable *BindWA::getNATable(CorrName& corrName,
+       ((QualifiedName&)(table->getTableName())).setIsVolatile(TRUE);
+     }
+       
+-  // For now, do not allow access through the Trafodion external name created for
+-  // the HIVE object unless the inDDL flag is set.  inDDL is set for drop 
+-  // table and SHOWDDL statements.  
+-  // TDB - may want to merge the Trafodion version with the HIVE version.
+-  // TDB - similar operation may be needed for external HBase tables
+-  if ((table) && (table->isExternalTable() && (! bindWA->inDDL())))
++  // For now, don't allow access through the Trafodion external name created for
++  // native HIVE or HBASE objects unless the allowExternalTables flag is set.  
++  // allowExternalTables is set for drop table and SHOWDDL statements.  
++  // TDB - may want to merge the Trafodion version with the native version.
++  if ((table) && (table->isExternalTable() && (! bindWA->allowExternalTables())))
+     {
+       *CmpCommon::diags() << DgSqlCode(-4258)
+                           << DgTableName(table->getTableName().getQualifiedNameAsAnsiString());","I have forgotten why we thought this restriction is necessary. A user registers a Hive/HBase table with us but is not able to use the table with the registered name in DML. Will UPDATE STATs will be on the original name too (and update stats code will find out registered name and use it for Table_uid?). This was the registration concept is almost like an internal implementation idea, at some point could even be done by some utility program for all existing Hive/hBase tables, and the user need not be aware of it? I am struggling with a user would want to register a table, if they cannot use it by that name.",I think this should be `! bindWA->allowExternalTab
+74,"@@ -40,6 +40,18 @@
+ 
+ struct ase_cfg_t *cfg;
+ 
++int app2sim_alloc_rx;		// app2sim mesaage queue in RX mode
++int sim2app_alloc_tx;		// sim2app mesaage queue in TX mode
++int app2sim_mmioreq_rx;		// MMIO Request path
++int sim2app_mmiorsp_tx;		// MMIO Response path
++int app2sim_umsg_rx;		// UMSG    message queue in RX mode
++int app2sim_portctrl_req_rx;	// Port Control messages in Rx mode
++int app2sim_dealloc_rx;
++int sim2app_dealloc_tx;
++int sim2app_portctrl_rsp_tx;
++int sim2app_intr_request_tx;
++int intr_event_fds[MAX_USR_INTRS];
++
+ int glbl_test_cmplt_cnt;   // Keeps the number of session_deinits received
+ 
+ volatile int sockserver_kill;",Should most of these non-globals be static?,Why do we need this?
+75,"@@ -14,6 +14,14 @@ class TestFakerName < Test::Unit::TestCase
+     assert @tester.name_with_middle.match(/(\w+\.? ?){3,4}/)
+   end
+ 
++  def test_first_name
++    assert @tester.first_name.match(/(\w+\.? ?){3,4}/)
++  end
++
++  def test_last_name
++    assert @tester.last_name.match(/(\w+\.? ?){3,4}/)
++  end
++
+   def test_prefix
+     assert @tester.prefix.match(/[A-Z][a-z]+\.?/)
+   end",Please do not approve PRs without tests!!!!,I think you can use `assert_match` here.
+76,"@@ -48,7 +48,7 @@ class WebEngineView(QWebEngineView):
+         else:
+             profile = webenginesettings.default_profile
+         page = WebEnginePage(theme_color=theme_color, profile=profile,
+-                             parent=self)
++                             parent=self, win_id=win_id)
+         self.setPage(page)
+ 
+     def shutdown(self):",Now that you handle this in `webenginetab.py` you can undo all the changes in this file.,I don't think you need to pass `win_id` here.
+77,"@@ -30,7 +30,11 @@ import org.springframework.context.annotation.AnnotationConfigApplicationContext
+ public class JavaFXApplication extends Application {
+ 
+     public static void main(String[] args) {
+-        Application.launch(JavaFXApplication.class);
++        try {
++            Application.launch(JavaFXApplication.class);
++        } catch (Exception e) {
++            e.printStackTrace();
++        }
+     }
+ 
+     @Override",I think we should log the exception to a log file instead of printing it. The current behavior (not catching the exception) should lead to an automatic print of the exception to the terminal/console.,Why is this needed?
+78,"@@ -57,7 +57,7 @@ func (r *Helper) Apply(obj []byte) (ApplyResult, error) {
+ 	if err != nil {
+ 		r.logger.WithError(err).
+ 			WithField(""stdout"", ioStreams.Out.(*bytes.Buffer).String()).
+-			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Error(""running the apply command failed"")
++			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Warn(""running the apply command failed"")
+ 		return """", err
+ 	}
+ 	return changeTracker.GetResult(), nil","These changes to the resource helpers have some more far-reaching implications as they also affect calls made in hive-operator, I believe. It's probably OK still, though. Ideally, the resource helper would not be the one doing the logging, since it cannot know the severity, but that is well beyond something that we should tackle for this PR. I would rather have the hive-operator log warnings than have the syncsetinstance controller log errors.",Why is this change necessary?
+79,"@@ -167,7 +167,7 @@ class ExportCategoryTableMap extends TableMap
+      */
+     public function buildRelations()
+     {
+-        $this->addRelation('Export', '\\Thelia\\Model\\Export', RelationMap::ONE_TO_MANY, array('id' => 'export_category_id', ), 'CASCADE', 'RESTRICT', 'Exports');
++        $this->addRelation('Export', '\\Thelia\\Model\\Export', RelationMap::ONE_TO_MANY, array('id' => 'export_category_id', ), null, null, 'Exports');
+         $this->addRelation('ExportCategoryI18n', '\\Thelia\\Model\\ExportCategoryI18n', RelationMap::ONE_TO_MANY, array('id' => 'id', ), 'CASCADE', null, 'ExportCategoryI18ns');
+     } // buildRelations()
+ ",do you really want to change the behavior on foreign key ?,Why did you remove the RESTRICT relation?
+80,"@@ -183,7 +183,8 @@ void event_batch_destroy (struct event_batch *batch)
+         if (batch->f)
+             (void)flux_future_wait_for (batch->f, -1);
+         if (batch->state_trans) {
+-            event_publish_state (batch->event, batch->state_trans);
++            if (json_array_size (batch->state_trans) > 0)
++                event_publish_state (batch->event, batch->state_trans);
+             json_decref (batch->state_trans);
+         }
+         if (batch->responses) {",Looks like my bad. Thanks for fixing!,`if (json_array_size (batch->state_trans))`
+81,"@@ -82,6 +82,7 @@ class Command:
+         no_cmd_split: If true, ';;' to split sub-commands is ignored.
+         backend: Which backend the command works with (or None if it works with
+                  both)
++        no_replace_variables: Whether or not to replace variables like {url}
+         _qute_args: The saved data from @cmdutils.argument
+         _needs_js: Whether the command needs javascript enabled
+         _modes: The modes the command can be executed in.","I think ""Don't replace variables ..."" would be cleaner.",I think this should be `False` by default.
+82,"@@ -82,8 +82,7 @@ class MPLPlot(DimensionedPlot):
+     sublabel_size = param.Number(default=18, doc=""""""
+          Size of optional subfigure label."""""")
+ 
+-    projection = param.ObjectSelector(default=None,
+-                                      objects=['3d', 'polar', None], doc=""""""
++    projection = param.Parameter(default=None, doc=""""""
+         The projection of the plot axis, default of None is equivalent to
+         2D plot, '3d' and 'polar' are also supported."""""")
+ ",Do you validate the possible strings? I've not read the code below but we should make sure if a string is supplied it is validate...,I don't think we should remove this.
+83,"@@ -40,13 +40,11 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
+ 	for i, dataDiskInfo := range dataDiskInfos {
+ 		dataDiskIndex := i + 1
+ 		dataDiskFilePath := dataDiskInfo.FilePath
+-		diskNames = append(
+-			diskNames,
+-			fmt.Sprintf(""%v-data-disk-%v"", w.Vars[""instance_name""].Value, dataDiskIndex))
++		diskNames = append(diskNames, generateDataDiskName(w.Vars[""instance_name""].Value, dataDiskIndex))
+ 
+ 		setupDataDiskStepName := fmt.Sprintf(""setup-data-disk-%v"", dataDiskIndex)
+-		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v"", dataDiskIndex)
+-		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%v-%v"", dataDiskIndex, w.Vars[""instance_name""].Value)
++		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v-%v"", dataDiskIndex, w.ID())
++		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%v-%v"", dataDiskIndex, w.ID())
+ 
+ 		setupDataDiskStep := daisy.NewStepDefaultTimeout(setupDataDiskStepName, w)
+ 		setupDataDiskStep.CreateDisks = &daisy.CreateDisks{",I'd recommend using generateDataDiskName here as well -- might as well benefit from the safety that it gives to protect yourself from future changes to w.ID().,Why not use `w.ID()` here?
+84,"@@ -29,6 +29,11 @@ import java.util.Map;
+  * @param <F> the concrete Java class of a ContentFile instance.
+  */
+ public interface ContentFile<F> {
++  /**
++   * Returns the ordinal position of the file in a manifest, or null if it was not read from a manifest.
++   */
++  Long pos();
++
+   /**
+    * Returns id of the partition spec used for partition metadata.
+    */",qq: do we want to include anything in the name to indicate that it is a position in the manifest?,I don't think we need this method. We can just call `pos()` directly.
+85,"@@ -969,8 +969,11 @@ public class VRBrowserActivity extends PlatformActivity implements WidgetManager
+         GleanMetricsService.stopImmersive();
+         Handler handler = new Handler(Looper.getMainLooper());
+         handler.postDelayed(() -> {
+-            mWindows.resumeCompositor();
+-            Log.d(LOGTAG, ""Compositor Resumed"");
++            if (!mWindows.isPaused()) {
++                Log.d(LOGTAG, ""Compositor resume begin"");
++                mWindows.resumeCompositor();
++                Log.d(LOGTAG, ""Compositor resume end"");
++            }
+         }, 20);
+     }
+ ",These logs should probably use the `LOGTAG`,Shouldn't this be `if (mWindows.isPaused())`?
+86,"@@ -28,10 +28,10 @@ import (
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/services/wireguard""
+ 	""github.com/mysteriumnetwork/node/services/wireguard/key""
+-	""github.com/mysteriumnetwork/wireguard-go/device""
+-	""github.com/mysteriumnetwork/wireguard-go/tun""
+ 	""github.com/pkg/errors""
+ 	""github.com/rs/zerolog/log""
++	""golang.zx2c4.com/wireguard/device""
++	""golang.zx2c4.com/wireguard/tun""
+ )
+ 
+ const (","From this, it was clear, that we are using our version of wireguard-go. And now it looks like we are using original packages which is confusing.",nit: remove empty line
+87,"@@ -43,7 +43,7 @@ namespace Nethermind.JsonRpc
+         
+         public static ResultWrapper<T> Fail(Exception e)
+         {
+-            return new() { Result = Result.Fail(e.ToString()), ErrorCode = ErrorCodes.InternalError};
++            return new() { Result = Result.Fail(e.Message), ErrorCode = ErrorCodes.InternalError};
+         }
+ 
+         public static ResultWrapper<T> Fail(string error, int errorCode, T outputData)",Any particular reason for this? This potentially will make harder to investigate users issues,">e.Message [](start = 58, length = 10) why not e.Message?"
+88,"@@ -999,7 +999,8 @@ Blockly.BlockSvg.prototype.updatePreviews = function(closestConnection,
+   // grayed-out blocks instead of highlighting the connection; for compatibility
+   // with Web Blockly the name ""highlightedConnection"" will still be used.
+   if (Blockly.highlightedConnection_ &&
+-      Blockly.highlightedConnection_ != closestConnection) {
++      (Blockly.highlightedConnection_ != closestConnection ||
++       Blockly.localConnection_ != localConnection)) {
+     if (Blockly.insertionMarker_ && Blockly.insertionMarkerConnection_) {
+       Blockly.BlockSvg.disconnectInsertionMarker();
+     }",Do you also need to check if Blockly.localConnection_ is non-null?,Why do we need to check for localConnection here?
+89,"@@ -1,5 +1,6 @@
+ module RSpec
+   module Core
++    # Internal container for global non-configuration data
+     class World
+ 
+       include RSpec::Core::Hooks","Not really a container, and it's not just about non-config data, not sure of a better description, @myronmarston ?",# Internal container for global configuration dat
+90,"@@ -3,6 +3,8 @@ const { basename } = require('./path-utils');
+ const shim = require('./shim').default;
+ const JoplinError = require('./JoplinError').default;
+ const { Buffer } = require('buffer');
++const { Readable } = require('stream').Readable;
++const { GetObjectCommand, ListObjectsV2Command, HeadObjectCommand, PutObjectCommand, DeleteObjectCommand, DeleteObjectsCommand } = require(""@aws-sdk/client-s3"");
+ 
+ const S3_MAX_DELETES = 1000;
+ ","The desktop app will load this fine. on iOS I get `TypeError: undefined is not an object (evaluating '_$$_REQUIRE(_dependencyMap[8], ""stream"").Readable.Readable')` if I change it to `const Readable = require('stream').Readable;` or `const { Readable } = require('stream');` I get undefined errors from the stream on iOS: `[TypeError: stream.on is not a function. (In 'stream.on(""data"", function (chunk) { return chunks.push(chunk); })', 'stream.on' is undefined)]` What am I missing?",const { Buffer } = require('buffer');
+91,"@@ -93,7 +93,9 @@ func (m *MockStorer) Put(ctx context.Context, mode storage.ModePut, chs ...swarm
+ 			po := swarm.Proximity(ch.Address().Bytes(), m.baseAddress)
+ 			m.bins[po]++
+ 		}
+-		m.store[ch.Address().String()] = ch.Data()
++		b := make([]byte, len(ch.Data()))
++		copy(b, ch.Data())
++		m.store[ch.Address().String()] = b
+ 		m.modePut[ch.Address().String()] = mode
+ 
+ 		// pin chunks if needed","this is needed since the chunk feeder shares memory across calls to the pipeline. this is in order to avoid multiple allocations. this change mimics the behavior of shed and localstore, and copies the data from the call into the in-memory store",Why do we need this copy?
+92,"@@ -42,6 +42,10 @@ import (
+ 	""go.uber.org/yarpc/yarpcerrors""
+ )
+ 
++func init() {
++	opentracing.SetGlobalTracer(nil)
++}
++
+ func TestHandlerSuccess(t *testing.T) {
+ 	mockCtrl := gomock.NewController(t)
+ 	defer mockCtrl.Finish()",wut. We can do this at the beginning of tests if we want right? Why are we depending on init?,Why is this needed?
+93,"@@ -1403,9 +1403,12 @@ func (c *client) processConnect(arg []byte) error {
+ 				c.mu.Lock()
+ 				acc := c.acc
+ 				c.mu.Unlock()
++				srv.mu.Lock()
+ 				if acc != nil && acc != srv.gacc {
++					srv.mu.Unlock()
+ 					return ErrTooManyAccountConnections
+ 				}
++				srv.mu.Unlock()
+ 			}
+ 			c.authViolation()
+ 			return ErrAuthentication",Same trick here IMO.,Why do we need to l
+94,"@@ -108,10 +108,11 @@ module Selenium
+ 
+         def initialize(source, duration, x, y, element: nil, origin: nil)
+           super(source)
++
+           @duration = duration * 1000
+           @x_offset = x
+           @y_offset = y
+-          @origin = element || origin
++          @origin = origin || POINTER
+         end
+ 
+         def type",Should be `@origin = element || origin || POINTER`,Why did you change 
+95,"@@ -50,11 +50,14 @@ func NewUpgradeCStorSPCJob() *cobra.Command {
+ 		Long:    cstorSPCUpgradeCmdHelpText,
+ 		Example: `upgrade cstor-spc --spc-name <spc-name>`,
+ 		Run: func(cmd *cobra.Command, args []string) {
++			util.CheckErr(options.RunCStorSPCUpgradeChecks(cmd, args), util.Fatal)
+ 			options.resourceKind = ""storagePoolClaim""
+-			util.CheckErr(options.RunPreFlightChecks(cmd), util.Fatal)
+-			util.CheckErr(options.RunCStorSPCUpgradeChecks(cmd), util.Fatal)
+-			util.CheckErr(options.InitializeDefaults(cmd), util.Fatal)
+-			util.CheckErr(options.RunCStorSPCUpgrade(cmd), util.Fatal)
++			if options.cstorSPC.spcName != """" {
++				singleCstorSPCUpgrade(cmd)
++			}
++			if len(args) != 0 {
++				bulkCstorSPCUpgrade(cmd, args)
++			}
+ 		},
+ 	}
+ ",this example needs a fix?,Why do we need to c
+96,"@@ -248,9 +248,9 @@ static void close(struct roots_view *view) {
+ 	struct wlr_xdg_surface *surface = view->xdg_surface;
+ 	struct wlr_xdg_popup *popup = NULL;
+ 	wl_list_for_each(popup, &surface->popups, link) {
+-		wlr_xdg_surface_send_close(popup->base);
++		wlr_xdg_popup_destroy(popup->base);
+ 	}
+-	wlr_xdg_surface_send_close(surface);
++	wlr_xdg_toplevel_send_close(surface);
+ }
+ 
+ static void destroy(struct roots_view *view) {",Is it safe to assume this surface is a toplevel?,Shouldn't this be `wlr_xdg_toplevel_destroy`?
+97,"@@ -225,6 +225,16 @@ projCtx pj_ctx_alloc()
+     return new (std::nothrow) projCtx_t(*pj_get_default_ctx());
+ }
+ 
++/************************************************************************/
++/*                            pj_ctx_clone()                            */
++/************************************************************************/
++
++projCtx pj_ctx_clone( projCtx ctx )
++
++{
++    return new (std::nothrow) projCtx_t(*ctx);
++}
++
+ /************************************************************************/
+ /*                            pj_ctx_free()                             */
+ /************************************************************************/",we don't need that function,Why is this needed?
+98,"@@ -72,6 +72,13 @@ public enum Platform {
+     }
+   },
+ 
++  WIN10(""windows 10"", ""win10"") {
++    @Override
++    public Platform family() {
++      return WINDOWS;
++    }
++  },
++
+   MAC(""mac"", ""darwin"", ""os x"") {},
+ 
+   SNOW_LEOPARD(""snow leopard"", ""os x 10.6"") {","we'll also have to think about adding ""Windows Server 2014"" or whatever they come up with later.","This should be `MAC(""mac"", ""darwin"", ""os x"")`"
+99,"@@ -35,6 +35,9 @@ public interface ExecutorLoader {
+   Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchActiveFlows()
+       throws ExecutorManagerException;
+ 
++  Pair<ExecutionReference, ExecutableFlow> fetchActiveFlowByExecId(int execId)
++      throws ExecutorManagerException;
++
+   List<ExecutableFlow> fetchFlowHistory(int skip, int num)
+       throws ExecutorManagerException;
+ ",curious do we have an API to fetch an inactive flow?,`fetchActiveFlowsByExecId` -> `fetchActiveFlo
+100,"@@ -116,10 +116,6 @@ function upgradeToVNodes(arr, offset) {
+ 		if (Array.isArray(obj)) {
+ 			upgradeToVNodes(obj);
+ 		}
+-		else if (obj && typeof obj==='object' && !isValidElement(obj) && ((obj.props && obj.type) || obj.text!=null)) {
+-			if (obj.text) continue;
+-			arr[i] = createElement(obj.type, obj.props, obj.props.children);
+-		}
+ 	}
+ }
+ ",This branch is not needed anymore because every `vnode` that passes through `h` in compat or core will have the `$$typeof`-property now .,Why was this removed?
+101,"@@ -0,0 +1,16 @@
++const { getComposedParent } = axe.commons.dom;
++
++function shouldMatchElement(el) {
++	if (!el) {
++		return true;
++	}
++	const ariaHiddenValue = el.getAttribute('aria-hidden')
++		? el.getAttribute('aria-hidden')
++		: null;
++	if (ariaHiddenValue === null) {
++		return shouldMatchElement(getComposedParent(el));
++	}
++	return false;
++}
++
++return shouldMatchElement(getComposedParent(node));",Did you mean to use `hasAttribute`? You shouldn't. This does not improve performance and it messes with the readability.,I don't think we need
+102,"@@ -37,13 +37,14 @@ import pytest
+ import py.path  # pylint: disable=no-name-in-module
+ 
+ import helpers.stubs as stubsmod
++from helpers.utils import CallbackChecker
+ from qutebrowser.config import config, configdata, configtypes, configexc
+ from qutebrowser.utils import objreg, standarddir
+ from qutebrowser.browser.webkit import cookies
+ from qutebrowser.misc import savemanager, sql
+ from qutebrowser.keyinput import modeman
+ 
+-from PyQt5.QtCore import pyqtSignal, QEvent, QSize, Qt, QObject
++from PyQt5.QtCore import QEvent, QSize, Qt
+ from PyQt5.QtGui import QKeyEvent
+ from PyQt5.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout
+ from PyQt5.QtNetwork import QNetworkCookieJar",Please import modules and not classes (except for Qt stuff).,Why this change?
+103,"@@ -20,6 +20,11 @@ public class DummyJavaNode extends AbstractJavaNode {
+         super(id);
+     }
+ 
++    @Override
++    public void setImage(String image) {
++        super.setImage(image);
++    }
++
+     @Override
+     public Object jjtAccept(JavaParserVisitor visitor, Object data) {
+         return data;","Hm... why do we have a ""DummyJavaNode"" in src/main? Looks like, this should have gone into src/test....",Why is this needed?
+104,"@@ -14,6 +14,7 @@ See the License for the specific language governing permissions and
+ limitations under the License.
+ */
+ 
++// Package v1alpha1
+ package v1alpha1
+ 
+ // CasKey is used for all cas specific annotation keys",This seems meaningless. If we cannot add any info let us remove this.,/* Package v1alpha1
+105,"@@ -493,6 +493,14 @@ func (c *Container) GetLabels() map[string]string {
+ 	return c.labels
+ }
+ 
++// GetPorts gets the ports for a container
++func (c *Container) GetPorts() []PortBinding {
++	c.lock.RLock()
++	defer c.lock.RUnlock()
++
++	return c.Ports
++}
++
+ // HealthStatusShouldBeReported returns true if the health check is defined in
+ // the task definition
+ func (c *Container) HealthStatusShouldBeReported() bool {",Can you rename `Ports` to `PortsUnsafe`?,Why do we need this
+106,"@@ -0,0 +1,10 @@
++module ReturnToHelper
++  def make_return_to(name, path)
++    sig = OpenSSL::HMAC.digest(
++      OpenSSL::Digest::SHA256.new,
++      Rails.application.secrets.secret_key_base,
++      name + ""$"" + path
++    )
++    {name: name, path: path, sig: Base64.urlsafe_encode64(sig)}
++  end
++end",This feels like it could be moved out to your first gem!,Layout/EmptyLinesAr
+107,"@@ -44,7 +44,7 @@ public abstract class NewSessionQueue implements HasReadyState {
+ 
+   public abstract boolean offerFirst(HttpRequest request, RequestId requestId);
+ 
+-  public abstract Optional<HttpRequest> poll();
++  public abstract Optional<HttpRequest> poll(RequestId requestId);
+ 
+   public abstract int clear();
+ ","The expected behaviour for `poll` would be to match what `Deque` does, which is: > Retrieves and removes the head of the queue represented by this deque As such, you shouldn't need the `RequestId` here.",Why is this change 
+108,"@@ -7,4 +7,17 @@
+ axe.utils.toArray = function (thing) {
+ 	'use strict';
+ 	return Array.prototype.slice.call(thing);
+-};
++};
++
++
++/**
++ * Creates an array without duplicate values from 2 array inputs
++ * @param  {Array} arr1 First array
++ * @param  {Array} arr2 Second array
++ * @return {Array}
++ */
++axe.utils.uniqueArray = (arr1, arr2) => {
++  return arr1.concat(arr2).filter((elem, pos, arr) => {
++    return arr.indexOf(elem) === pos;
++  });
++};","This is super minor, but it'd be nice if this iterated over an arbitrary number of array inputs.",`uniqueArray` -> `uniqueArray`
+109,"@@ -1676,9 +1676,10 @@ _tmain(int argc, TCHAR *targv[])
+     }
+ # ifdef UNIX
+     /* i#1676: detect whether under gdb */
+-    _snprintf(buf, BUFFER_SIZE_ELEMENTS(buf), ""/proc/%d/exe"", getppid());
+-    NULL_TERMINATE_BUFFER(buf);
+-    i = readlink(buf, buf, BUFFER_SIZE_ELEMENTS(buf));
++    char path_buf[MAXIMUM_PATH];
++    _snprintf(path_buf, BUFFER_SIZE_ELEMENTS(path_buf), ""/proc/%d/exe"", getppid());
++    NULL_TERMINATE_BUFFER(path_buf);
++    i = readlink(path_buf, buf, BUFFER_SIZE_ELEMENTS(buf));
+     if (i > 0) {
+         if (i < BUFFER_SIZE_ELEMENTS(buf))
+             buf[i] = '\0';","What is the problem here? The commit message has strange wording ""readlink is defined with restrict pointers"": do you mean ""restricted""? Is that a well-defined language term? I'm not sure what it means.",This should be `MAXIMUM_PATH +
+110,"@@ -17,6 +17,7 @@ package com.google.api.codegen.util.ruby;
+ import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.util.NameFormatter;
+ import com.google.api.codegen.util.NamePath;
++import com.google.common.collect.ImmutableSet;
+ 
+ /**
+  * The NameFormatter for Ruby.",Why are we not wrapping here?,Why is this needed?
+111,"@@ -2,12 +2,10 @@
+ 
+ namespace Shopsys\FrameworkBundle\Model\Product\Filter;
+ 
+-use Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter;
+-
+ class ParameterFilterData
+ {
+     /**
+-     * @var \Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter
++     * @var \Shopsys\FrameworkBundle\Model\Product\Parameter\Parameter|null
+      */
+     public $parameter;
+ ","I though that all data objects are being unified in the fashion where all default values are initialized in constructor, are not they?",Why removing the typehint?
+112,"@@ -22,16 +22,16 @@ var sourceHashes = map[string]string{
+ 	""libflux/flux-core/src/ast/flatbuffers/mod.rs"":                                                ""00c75dc1da14487953a4a017616fb8a237fe3da437c876f1328532dd7906f015"",
+ 	""libflux/flux-core/src/ast/flatbuffers/monotype.rs"":                                           ""4e82aae8e7edb8e230302241fe702ece9ae84fc708003c24709c2ea944cfaae8"",
+ 	""libflux/flux-core/src/ast/flatbuffers/tests.rs"":                                              ""ea85b78049f0c3d79daedcf9e171ccb00d0a596d1a643aa218590c99e6b160bc"",
+-	""libflux/flux-core/src/ast/mod.rs"":                                                            ""676e22d24cd7a97525688ed391a980d08b4bee40c5b5067d187f3ae6d66210ca"",
++	""libflux/flux-core/src/ast/mod.rs"":                                                            ""29b25b75a01cf1e1ac2b52d99b91986cec32011dc55af1ffd7f145838fce858d"",
+ 	""libflux/flux-core/src/ast/tests.rs"":                                                          ""bc7f77d569d8bbd4b9d00653f48bacd47eed46f53024dce836d3c8bbb6a80555"",
+ 	""libflux/flux-core/src/ast/walk/mod.rs"":                                                       ""e8a03023d7426bcf6dfdb1a61ac3263f5cf9194a595a1584dff7c899d06562f1"",
+ 	""libflux/flux-core/src/ast/walk/tests.rs"":                                                     ""f7b2d7dd5643bb795a86c04b6979b136b0de46b52b213caff094aed6d204a05d"",
+ 	""libflux/flux-core/src/formatter/mod.rs"":                                                      ""945736a4ad87adb6a3f359b6f2da6e5492b3cb0efd282e277303e2acae137763"",
+ 	""libflux/flux-core/src/formatter/tests.rs"":                                                    ""b0a10998a65fc4b54a8f68b3a0ed186d8548ba3d7638f911eb188d2ce485206f"",
+ 	""libflux/flux-core/src/lib.rs"":                                                                ""d19b7054e07f234c107d457030a0031374c123fe14a84a5b8e35537d138bac7a"",
+-	""libflux/flux-core/src/parser/mod.rs"":                                                         ""e3f11fe29f47271b5c04accc2d7efa35e1dc62c6de036bf0cc0cccda5e4742e8"",
++	""libflux/flux-core/src/parser/mod.rs"":                                                         ""daf24b2c439f4c7a6f138e2b25064a205aee73bb6cffc898df22dd0c962ca5df"",
+ 	""libflux/flux-core/src/parser/strconv.rs"":                                                     ""748c82f6efc2eafaafb872db5b4185ce29aafa8f03ba02c4b84f4a9614e832d2"",
+-	""libflux/flux-core/src/parser/tests.rs"":                                                       ""e3a7c9222f90323a7ea9b319bd84f96f66c6f115af6d199a0da332c894713ae4"",
++	""libflux/flux-core/src/parser/tests.rs"":                                                       ""43a1e5d3de85d76da2107544e417f583a1f66c20910286285b9645a309c42425"",
+ 	""libflux/flux-core/src/scanner/mod.rs"":                                                        ""2e15c9e0a73d0936d2eaeec030b636786db6dbe7aab673045de3a3e815c49f8a"",
+ 	""libflux/flux-core/src/scanner/scanner.rl"":                                                    ""530c062363b66daded3c521af44111b99ffee0eeb2a12ccffa8b8f349002d852"",
+ 	""libflux/flux-core/src/scanner/scanner_generated.rs"":                                          ""d65dcc216ccbb88d8f2e261a994ba2789075e434cb7a0f5e39e390bee2821e5b"",",Does this file actually need to be committed to git? Having to run `make generate` is rather tedious on each PR and it conflicts easily.,Why did this change?
+113,"@@ -440,18 +440,6 @@ func parseConfig(loc location.Location, opts options.Options) (interface{}, erro
+ 			cfg.ProjectID = os.Getenv(""GOOGLE_PROJECT_ID"")
+ 		}
+ 
+-		if cfg.JSONKeyPath == """" {
+-			if path := os.Getenv(""GOOGLE_APPLICATION_CREDENTIALS""); path != """" {
+-				// Check read access
+-				if _, err := ioutil.ReadFile(path); err != nil {
+-					return nil, errors.Fatalf(""Failed to read google credential from file %v: %v"", path, err)
+-				}
+-				cfg.JSONKeyPath = path
+-			} else {
+-				return nil, errors.Fatal(""No credential file path is set"")
+-			}
+-		}
+-
+ 		if err := opts.Apply(loc.Scheme, &cfg); err != nil {
+ 			return nil, err
+ 		}","We don't need this anymore, as Google's library handles various auth mechanisms for us. We'll be less explicit about why we're failing but we gain support for several authentication methods- swings and roundabouts!",Why is this being re
+114,"@@ -1,11 +1,12 @@
+ package plugin
+ 
+ type Config struct {
+-	SocketPath string        `yaml:""path""`
+-	Volumes    VolumesConfig `yaml:""volume""`
++	SocketDir string                       `yaml:""socket_dir"" default:""/run/docker/plugins""`
++	Volumes   VolumesConfig                `yaml:""volume""`
++	GPUs      map[string]map[string]string `yaml:""GPUs""`
+ }
+ 
+ type VolumesConfig struct {
+-	Root    string
++	Root    string `yaml:""root"" default:""/var/lib/docker-volumes""`
+ 	Volumes map[string]map[string]string
+ }",No need to speficy attribute here. Moreover in yaml it is default to use lowercase names.,Why do we need this?
+115,"@@ -8,10 +8,12 @@ using System;
+ using System.Collections.Generic;
+ using System.Globalization;
+ using System.IO;
++using System.Linq;
+ using System.Net;
+ using System.Net.Http;
+ using System.Text;
+ using System.Threading;
++using System.Threading.Tasks;
+ using Task = System.Threading.Tasks.Task;
+ 
+ namespace Microsoft.DotNet.Build.CloudTestTasks",In general I'm a trying to understand the reason behind this PR. Looks like if a blob (name) already exists we check if the contents are identical? In what scenarios this is not the case? When we want to publish a package/asset that has changed but still we want to use the same version?,Why is this needed?
+116,"@@ -151,7 +151,9 @@ class BlacklistRuleBook(bre.BaseRuleBook):
+             lists: first one is IP addresses,
+             second one is network blocks
+         """"""
+-        data = urllib2.urlopen(url).read()
++        req = urllib2.build_opener()
++        req.addheaders = [('User-Agent', 'Forseti blacklist rules engine agent')]
++        data = req.open(url).read()
+         ip_addresses = re.findall(r'^[0-9]+(?:\.[0-9]+){3}$', data, re.M)
+         netblocks = re.findall(r'^[0-9]+(?:\.[0-9]+){0,3}/[0-9]{1,2}$',
+                                data, re.M)","Can rename `req` to be `opener`, since that is the object, and it wraps `req` internally?",I think this should be `urllib2.build_opener(headers=...)`
+117,"@@ -1405,6 +1405,8 @@ def getFormatFieldSpeech(attrs,attrsCache=None,formatConfig=None,unit=None,extra
+ 		linePrefix=attrs.get(""line-prefix"")
+ 		if linePrefix:
+ 			textList.append(linePrefix)
++	breakpoint=attrs.get(""breakpoint"")
++	if breakpoint: textList.append(breakpoint)
+ 	if attrsCache is not None:
+ 		attrsCache.clear()
+ 		attrsCache.update(attrs)","@MichaelDCurran, thoughts on adding a breakpoint format field attribute? It seems almost app specific, but I guess it does seem odd abusing line-prefix. Is there any more generic concept here?",missing whitespace around operator
+118,"@@ -539,7 +539,10 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            return self.size, self.location
+ 
+     @property
+     def screenshot_as_base64(self):",This would return a tuple of two dictionaries. You need to combine them and return a dictionary,I don't think this is the right way to do it. I think it s
+119,"@@ -7,10 +7,14 @@ import (
+ 	""errors""
+ 	""fmt""
+ 
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/manifest""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/secretsmanager""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/ssm""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/color""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/log""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/prompt""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/workspace""
+ 
+ 	""github.com/spf13/cobra""
+ )","What do you think of moving the example to the help text of the prompt? and the prompt itself can be ""What is your application's GitHub repository URL?""",nit: remove empty line
+120,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+ 
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,This should be `1593493828L`
+121,"@@ -266,7 +266,7 @@ bool parse_it(Iterator &first, Iterator last, RDKit::RWMol &mol) {
+       } else {
+         if (!parse_atom_labels(first, last, mol)) return false;
+       }
+-    } else if ((first + 9) < last &&
++    } else if (std::distance(first, last) > 9 &&
+                std::string(first, first + 9) == ""atomProp:"") {
+       first += 9;
+       if (!parse_atom_props(first, last, mol)) return false;",Nice use of std::distance. I'm a bit worried about first += 9 though.,"`std::distance(first, last)`"
+122,"@@ -578,8 +578,9 @@ func (c *Operator) syncNodeEndpoints(ctx context.Context) error {
+ 		ObjectMeta: metav1.ObjectMeta{
+ 			Name: c.kubeletObjectName,
+ 			Labels: c.config.Labels.Merge(map[string]string{
+-				""k8s-app"":                ""kubelet"",
+-				""app.kubernetes.io/name"": ""kubelet"",
++				""k8s-app"":                   ""kubelet"",
++				""app.kubernetes.io/name"":    ""kubelet"",
++				""app.kubernetes.io/part-of"": ""prometheus-operator"",
+ 			}),
+ 		},
+ 		Subsets: []v1.EndpointSubset{","Shouldn't this be `app.kubernetes.io/managed-by` as prometheus-operator manages this resource, but this resource isn't a part of prometheus-operator?",Why is this part of this PR?
+123,"@@ -41,8 +41,9 @@ namespace Datadog.Trace.ClrProfiler
+ 
+                 if (parent != null &&
+                     parent.Type == SpanTypes.Http &&
+-                    parent.GetTag(Tags.HttpMethod).Equals(httpMethod, StringComparison.OrdinalIgnoreCase) &&
+-                    parent.GetTag(Tags.HttpUrl).Equals(UriHelpers.CleanUri(requestUri, removeScheme: false, tryRemoveIds: false), StringComparison.OrdinalIgnoreCase))
++                    parent.GetTag(Tags.InstrumentationName) != null &&
++                    httpMethod.Equals(parent.GetTag(Tags.HttpMethod), StringComparison.OrdinalIgnoreCase) &&
++                    UriHelpers.CleanUri(requestUri, removeScheme: false, tryRemoveIds: false).Equals(parent.GetTag(Tags.HttpUrl), StringComparison.OrdinalIgnoreCase))
+                 {
+                     // we are already instrumenting this,
+                     // don't instrument nested methods that belong to the same stacktrace","As long as we're being extra-vigilant about NREs, should we check that `httpMethod` and `requestUri` are not null?",Why do we need this check?
+124,"@@ -19,6 +19,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/node""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/update""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/version""
++	xrc20 ""github.com/iotexproject/iotex-core/cli/ioctl/cmd/xrc20""
+ )
+ 
+ // RootCmd represents the base command when called without any subcommands",No need to have `xrc20` alias,Why do we need this alias?
+125,"@@ -172,6 +172,19 @@ def define_environment_cls(pipeline_def):
+     )
+ 
+ 
++def context_cls_inst(pipeline_def):
++    check.inst_param(pipeline_def, 'pipeline_def', PipelineDefinition)
++    pipeline_name = camelcase(pipeline_def.name)
++    return SystemNamedDict(
++        name='{pipeline_name}.Context'.format(pipeline_name=pipeline_name),
++        fields={
++            'context': define_maybe_optional_selector_field(
++                define_context_context_cls(pipeline_name, pipeline_def.context_definitions)
++            )
++        },
++    ).inst()
++
++
+ def define_expectations_config_cls(name):
+     check.str_param(name, 'name')
+ ",the naming convention I'm been adopting if `_type` for instances of these classes. So maybe `context_config_type` is a better name for this fn,Why do we need this?
+126,"@@ -54,6 +54,7 @@ public class BlockMiner<C, M extends AbstractBlockCreator<C>> implements Runnabl
+   private final ProtocolSchedule<C> protocolSchedule;
+   private final Subscribers<MinedBlockObserver> observers;
+   private final AbstractBlockScheduler scheduler;
++  private Boolean gpuMining = false;
+ 
+   public BlockMiner(
+       final Function<BlockHeader, M> blockCreatorFactory,","Don't call it GPU mining, call it `externalMining`, here and throughout.",Why do we need this?
+127,"@@ -252,6 +252,15 @@ return [
+     | folder - a folder prefix for storing all generated files inside.
+     | path   - the public path relative to the application base URL,
+     |          or you can specify a full URL path.
++    |
++    | For the 'media' resource you can also specify:
++    |
++    | imageMaxWidth     - Resize all media manager image uploads to be
++    |                     within this with (in pixels, 0 = ignore)
++    | imageMaxHeight    - Resize all media manager image uploads to be
++    |                     within this height (in pixels, 0 = ignore)
++    | imageQuality      - Set this quality to all media manager image uploads
++    |                     (1-100)
+     */
+ 
+     'storage' => [","`within this with` typo, should be `within this width`",This should be `(1-100)`.
+128,"@@ -22,10 +22,12 @@ import (
+ )
+ 
+ // Prometheus defines a Prometheus deployment.
++// +k8s:openapi-gen=true
+ type Prometheus struct {
+ 	metav1.TypeMeta `json:"",inline""`
+ 	// Standard object’s metadata. More info:
+ 	// https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#metadata
++	// +k8s:openapi-gen=false
+ 	metav1.ObjectMeta `json:""metadata,omitempty""`
+ 	// Specification of the desired behavior of the Prometheus cluster. More info:
+ 	// https://github.com/kubernetes/community/blob/master/contributors/devel/api-conventions.md#spec-and-status",how come this is false?,Why is this needed?
+129,"@@ -24,6 +24,19 @@ function node_require(module) {
+     return require(module);
+ }
+ 
++function typeOf(obj) {
++    return ({}).toString.call(obj).match(/\s(\w+)/)[1].toLowerCase();
++}
++
++function checkTypes(args, types) {
++    args = [].slice.call(args);
++    for (var i = 0; i < types.length; ++i) {
++        if (typeOf(args[i]) !== types[i]) {
++            throw new TypeError('param ' + i + ' must be of type ' + types[i]);
++        }
++    }
++}
++
+ const performFetch = typeof fetch === 'undefined' ? node_require('node-fetch') : fetch;
+ 
+ const url_parse = require('url-parse');",How about `Object.prototype.toString`? Or using the `typeof` operator?,Why do we need this
+130,"@@ -83,6 +83,7 @@ type ReporterKBPKI struct {
+ 	notifySyncBuffer chan *keybase1.FSPathSyncStatus
+ 	suppressCh       chan time.Duration
+ 	canceler         func()
++	ctx              context.Context
+ }
+ 
+ // NewReporterKBPKI creates a new ReporterKBPKI.","I know @jzila suggested this, but I disagree: you're really not supposed to save a context in a struct. Can you get by with just saving the `Done()` channel instead? The `ctx` should continue to be passed around explicitly.",Why do we need this
+131,"@@ -12,12 +12,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Networking
+         {
+             IsWindows = PlatformApis.IsWindows;
+ 
+-            var isDarwinMono =
+-#if DNX451
+-                IsWindows ? false : PlatformApis.IsDarwin;
+-#else
+-                false;
+-#endif
++            var isDarwinMono = !IsWindows && PlatformApis.IsDarwin;
+ 
+             if (isDarwinMono)
+             {",This check isn't right though.,Why was this remove
+132,"@@ -96,6 +96,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+     return missingDefaultServiceAddress() || missingDefaultServiceScopes();
+   }
+ 
++  public abstract String codeGenVersion();
++
+   @Override
+   public String resourceRoot() {
+     return SnippetSetRunner.SNIPPET_RESOURCE_ROOT;","maybe `toolkitVersion` instead? It doesn't necessarily have to be called that in the generated code, but in the view model classes, I think it makes it clearer that it is the version of toolkit itself.",public abstract boolean missingDefaultServiceAddress() {
+133,"@@ -230,15 +230,13 @@ module.exports = class XHRUpload extends Plugin {
+           const body = opts.getResponseData(xhr.responseText, xhr)
+           const uploadURL = body[opts.responseUrlFieldName]
+ 
+-          const response = {
++          const uploadResp = {
+             status: ev.target.status,
+             body,
+             uploadURL
+           }
+ 
+-          this.uppy.setFileState(file.id, { response })
+-
+-          this.uppy.emit('upload-success', file, body, uploadURL)
++          this.uppy.emit('upload-success', file, uploadResp)
+ 
+           if (uploadURL) {
+             this.uppy.log(`Download ${file.name} from ${file.uploadURL}`)","the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now ",`uploadResp` -> `uploadResponse`
+134,"@@ -134,7 +134,7 @@ func (s *stream) Read(p []byte) (int, error) {
+ 			} else {
+ 				select {
+ 				case <-s.readChan:
+-				case <-time.After(deadline.Sub(time.Now())):
++				case <-time.After(time.Until(deadline)):
+ 				}
+ 			}
+ 			s.mutex.Lock()",This isn't really easy to read.,I think this should be `time.Since(deadline)`
+135,"@@ -123,7 +123,7 @@ func (c *CStorVolumeReplicaController) cVREventHandler(operation common.QueueOpe
+ 
+ 		err := volumereplica.DeleteVolume(fullVolName)
+ 		if err != nil {
+-			glog.Errorf(""Error in deleting volume %q: %s"", cVR.ObjectMeta.Name,err)
++			glog.Errorf(""Error in deleting volume %q: %s"", cVR.ObjectMeta.Name, err)
+ 			c.recorder.Event(cVR, corev1.EventTypeWarning, string(common.FailureDestroy), string(common.MessageResourceFailDestroy))
+ 			return string(apis.CVRStatusDeletionFailed), err
+ 		}",This line changed due to go formatting. Format was not there earlier.,"nit: space after `,`"
+136,"@@ -28,13 +28,13 @@ type staticUpstream struct {
+ 		Path     string
+ 		Interval time.Duration
+ 	}
++	Without string
+ }
+ 
+ // NewStaticUpstreams parses the configuration input and sets up
+ // static upstreams for the proxy middleware.
+ func NewStaticUpstreams(c parse.Dispenser) ([]Upstream, error) {
+ 	var upstreams []Upstream
+-
+ 	for c.Next() {
+ 		upstream := &staticUpstream{
+ 			from:        """",","The name ""Without"" in code is a little nebulous. Maybe something more descriptive like TrimPrefix or StripPrefix or WithoutPathPrefix or something like that. (Thoughts?)",Why is this removed?
+137,"@@ -254,6 +254,12 @@ public class MoveIT {
+         linkDataset.then().assertThat()
+                 .statusCode(OK.getStatusCode());
+ 
++        // A dataset cannot be linked to the same dataverse again.
++        Response tryToLinkAgain = UtilIT.linkDataset(datasetPid, dataverse2Alias, superuserApiToken);
++        tryToLinkAgain.prettyPrint();
++        tryToLinkAgain.then().assertThat()
++                .statusCode(FORBIDDEN.getStatusCode());
++
+         Response getLinksBefore = UtilIT.getDatasetLinks(datasetPid, superuserApiToken);
+         getLinksBefore.prettyPrint();
+         getLinksBefore.then().assertThat()","is this test in the move tests? I see what you mean then - it works, but I wonder if we won't lose track that it's being tested here.",I think we should al
+138,"@@ -368,5 +368,8 @@ type Instance struct {
+ 	EBSOptimized *bool `json:""ebsOptimized""`
+ 
+ 	// The tags associated with the instance.
+-	Tags map[string]string `json:""tag""`
++	Tags map[string]string `json:""tags""`
++
++	// The security groups associated with the instance.
++	SecurityGroups map[string]string `json:""securityGroups""`
+ }","I'm not sure if this wanted to be `json:""tags""` (which I'd set in my PR) or `json:""tag""` that someone elses PR had set. Given that the rest of the fields had their JSON field name set to the same as the struct field name, I opted for `tags`.",Why is this a pointe
+139,"@@ -47,6 +47,11 @@ module Ncr
+       message: ""must be three letters or numbers""
+     }, allow_blank: true
+ 
++    scope :for_fiscal_year, lambda { |year|
++      range = self.class.range_for_fiscal_year(year)
++      where(created_at: range[:start_time]...range[:end_time])
++    }
++
+     def self.all_system_approver_emails
+       [
+         self.ba61_tier1_budget_mailbox,","since the logic here and in `Proposal` is exactly the same, do you think it makes sense for us to include it elsewhere? I am not opposed to duplicated code when it makes sense, but the reason I first identified this was that I was looking for code in NCR::WorkOrder that was not specific to Work Orders. Seems like fiscal year logic might be helpful for reporting for other clients. In that case, we'd want this scope on those client data classes as well. Might be wrong to include this in the FiscalYear mixin, but it does seem like it should be outside of Proposal and WorkOrder. Does that make sense?",Use 2 (not 1) spaces
+140,"@@ -42,6 +42,11 @@ class InfluxWriterSubscriber(object):
+         self.time = 0
+ 
+ 
++    def on_connection_closed(self, connection, reply_code, reply_text):
++        self.log.info('RabbitMQ connection got closed!')
++        self.connection.add_timeout(5, self.connect_to_rabbitmq)
++
++
+     @staticmethod
+     def static_callback(ch, method, properties, body, obj):
+         return obj.callback(ch, method, properties, body)",there is no static method as a go between -- how does this work?,This should be `self.connection.close()`
+141,"@@ -0,0 +1,8 @@
++# frozen_string_literal: true
++# encoding: utf-8
++
++class StringifiedSymbol
++  include Mongoid::Document
++  store_in collection: ""stringified_symbols"", client: :other
++  field :stringified_symbol, type: StringifiedSymbol
++end",Can you please change the name of this class to be something else?,I think this should be `:stringified_sym
+142,"@@ -403,7 +403,7 @@ size_t h2o_strstr(const char *haysack, size_t haysack_len, const char *needle, s
+ }
+ 
+ /* note: returns a zero-width match as well */
+-const char *h2o_next_token(h2o_iovec_t *iter, int separator, size_t *element_len, h2o_iovec_t *value)
++const char *h2o_next_token(h2o_iovec_t *iter, int separator, size_t *element_len, h2o_iovec_t *value, int coma_separator)
+ {
+     const char *cur = iter->base, *end = iter->base + iter->len, *token_start, *token_end;
+ ","I think we might prefer generalizing the interface rather than creating an exception. Current design of `h2o_next_token` assumes the input to be a comma-separated list, and allows the caller to specify a different separator when parsing a nested list. As I understand, what we are trying to attain in this PR is to have a way of parsing a flat list of semicolon-separated list. Assuming that is the case, I think it would be better to change the API of the function to accept two separators (i.e. inner and outer), where for our existing use-cases `outer` would be `,`.",coma_separator is not used.
+143,"@@ -43,8 +43,8 @@ namespace Nethermind.Blockchain
+     {
+         private const long LowestInsertedBodyNumberDbEntryAddress = 0; 
+         private const int CacheSize = 64;
+-        private readonly ICache<Keccak, Block> _blockCache = new LruCacheWithRecycling<Keccak, Block>(CacheSize, CacheSize, ""blocks"");
+-        private readonly ICache<Keccak, BlockHeader> _headerCache = new LruCacheWithRecycling<Keccak, BlockHeader>(CacheSize, CacheSize, ""headers"");
++        private readonly ICache<Keccak, Block> _blockCache = new LruCache<Keccak, Block>(CacheSize, CacheSize, ""blocks"");
++        private readonly ICache<Keccak, BlockHeader> _headerCache = new LruCache<Keccak, BlockHeader>(CacheSize, CacheSize, ""headers"");
+ 
+         private const int BestKnownSearchLimit = 256_000_000;
+ ",why not recycling? I Lru cache now recycling?,Why did you change this?
+144,"@@ -69,7 +69,7 @@ func (consumer *createConsumer) Consume(requestPtr interface{}) (response interf
+ 	issuerID := consumer.peerID
+ 	if request.ConsumerInfo != nil {
+ 		issuerID = request.ConsumerInfo.IssuerID
+-		if request.ConsumerInfo.PaymentVersion == PaymentVersionV2 {
++		if request.ConsumerInfo.PaymentVersion == PaymentVersionV3 {
+ 			indicateNewVersion = true
+ 		}
+ 	} else {",Why it is now called `PaymentVersionV3`?,Why do we need to change this?
+145,"@@ -165,7 +165,7 @@ func (dc *DownstreamController) syncSecret() {
+ 			}
+ 
+ 			nodes := dc.lc.SecretNodes(secret.Namespace, secret.Name)
+-			klog.Infof(""there are %d nodes need to sync secret, operation: %s"", len(nodes), e.Type)
++			klog.V(4).Infof(""there are %d nodes need to sync secret, operation: %s"", len(nodes), e.Type)
+ 			for _, n := range nodes {
+ 				msg := model.NewMessage("""")
+ 				msg.SetResourceVersion(secret.ResourceVersion)",changed for debug purpose?,Why is this V(4)?
+146,"@@ -46,6 +46,13 @@ namespace OpenTelemetry
+         /// <inheritdoc />
+         public abstract override void OnEnd(T data);
+ 
++        internal override void SetParentProvider(BaseProvider parentProvider)
++        {
++            base.SetParentProvider(parentProvider);
++
++            this.exporter.ParentProvider = parentProvider;
++        }
++
+         /// <inheritdoc />
+         protected override bool OnShutdown(int timeoutMilliseconds)
+         {",@cijothomas I needed a way to set the Exporter.ParentProvider when the Processor's gets set. Internal to SDK though.,Why is this needed?
+147,"@@ -31,9 +31,13 @@ inline extractor::RoadClassification roadClass(const ConnectedRoad &road,
+     return graph.GetEdgeData(road.eid).flags.road_classification;
+ }
+ 
+-inline bool isRampClass(EdgeID eid, const util::NodeBasedDynamicGraph &node_based_graph)
++inline bool isRampClass(EdgeID eid,
++                        const util::NodeBasedDynamicGraph &node_based_graph,
++                        bool from_motorway = true)
+ {
+-    return node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass();
++    return node_based_graph.GetEdgeData(eid).flags.road_classification.IsRampClass() ||
++           (from_motorway &&
++            node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass());
+ }
+ 
+ } // namespace",Talking through this scenario with @srividyacb and she's wondering if there should also be a check of `(from_trunk && node_based_graph.GetEdgeData(eid).flags.road_classification.IsLinkClass())` as highways with trunk classifications can also have this scenario.,nit: `from_motorway` -> `from_
+148,"@@ -13,7 +13,7 @@ module Beaker
+           :q_verify_packages => ENV['q_verify_packages'] || 'y',
+           :q_puppet_symlinks_install => 'y',
+           :q_puppetagent_certname => host,
+-          :q_puppetagent_server => master,
++          :q_puppetagent_server => master_certname,
+ 
+           # Disable database, console, and master by default
+           # This will be overridden by other blocks being merged in.",where does `master_certname` come from?,I think this should be `master_certname || host`
+149,"@@ -1,5 +1,7 @@
+ from .resnet import ResNet, make_res_layer
+ from .resnext import ResNeXt
+ from .ssd_vgg import SSDVGG
++from .hrnet import HRNet
+ 
+-__all__ = ['ResNet', 'make_res_layer', 'ResNeXt', 'SSDVGG']
++__all__ = ['ResNet', 'make_res_layer', 'ResNeXt', 'SSDVGG',
++           'HRNet']",The line breaking is unnecessary.,Why do we need this?
+150,"@@ -28,7 +28,7 @@ void DatasetLoader::SetHeader(const char* filename) {
+     // get column names
+     if (io_config_.has_header) {
+       std::string first_line = text_reader.first_line();
+-      feature_names_ = Common::Split(first_line.c_str(), ""\t ,"");
++      feature_names_ = Common::Split(first_line.c_str(), ""\t,"");
+     }
+ 
+     // load label idx first",why not enable split by space here ?,Why this change?
+151,"@@ -1076,7 +1076,8 @@ fpga_result mmio_error(struct RASCommandLine *rasCmdLine)
+ 		return result;
+ 	}
+ 
+-	if(value != FPGA_INTEGRATED_DEVICEID) {
++	if( (value != FPGA_INTEGRATED_DEVICEID) ||
++		(value != FPGA_DISCRETE_DEVICEID) ) {
+ 		FPGA_ERR(""Failed  to read Device id"");
+ 		return FPGA_NOT_SUPPORTED;
+ 	}",Shouldn't the operator be && ?,Shouldn't this be `!=`?
+152,"@@ -161,6 +161,17 @@ module Beaker
+       FileUtils.rm_rf(@vagrant_path)
+     end
+ 
++    #snapshotting depends on https://github.com/scalefactory/vagrant-multiprovider-snap
++    def take_snapshot(host,snapshot_name)
++      @logger.debug ""Creating snapshot of #{host}""
++      vagrant_cmd(""snap take #{host} --name=#{snapshot_name}"")
++    end
++
++    def restore_snapshot(host,snapshot_name)
++      @logger.debug ""Restoring snapshot of #{host}""
++      vagrant_cmd(""snap rollback #{host} --name=#{snapshot_name}"")
++    end
++
+     def vagrant_cmd(args)
+       Dir.chdir(@vagrant_path) do
+         exit_status = 1",My best guess is that you want to use host.name in these parts to get the name of the host ?,This should be `@logger.debug`
+153,"@@ -270,13 +270,6 @@ func (n *Node) UnmarshalBinary(data []byte) error {
+ 
+ 		n.entry = append([]byte{}, data[nodeHeaderSize:nodeHeaderSize+refBytesSize]...)
+ 		offset := nodeHeaderSize + refBytesSize // skip entry
+-		// Currently we don't persist the root nodeType when we marshal the manifest, as a result
+-		// the root nodeType information is lost on Unmarshal. This causes issues when we want to
+-		// perform a path 'Walk' on the root. If there is more than 1 fork, the root node type
+-		// is an edge, so we will deduce this information from index byte array
+-		if !bytes.Equal(data[offset:offset+32], make([]byte, 32)) {
+-			n.nodeType = nodeTypeEdge
+-		}
+ 		n.forks = make(map[byte]*fork)
+ 		bb := &bitsForBytes{}
+ 		bb.fromBytes(data[offset:])","IMO this edge case handling could remain here, just instead of overwriting the `n.nodeType`, the `makeEdgeType` method of `n` should be called, so `n.nodeType = nodeTypeEdge` -> `n.makeEdge()`",Why is this removed?
+154,"@@ -205,9 +205,10 @@ public class DownloadService extends Service {
+         Log.d(TAG, ""Service shutting down"");
+         isRunning = false;
+ 
++        boolean showAutoDownloadReport = UserPreferences.showAutoDownloadReport();
+         if (ClientConfig.downloadServiceCallbacks.shouldCreateReport()
+-                && UserPreferences.showDownloadReport()) {
+-            notificationManager.updateReport(reportQueue);
++                && (UserPreferences.showDownloadReport() || showAutoDownloadReport)) {
++            notificationManager.updateReport(reportQueue, showAutoDownloadReport);
+             reportQueue.clear();
+         }
+ ","Just wondering... The two kinds of notifications are now quite different (Channel, text, maybe even icon). Would it make sense to extract the auto download notification to a new class instead of handling everything in the existing `notificationManager`? I have not checked if this will lead to a lot of code duplication, though.",Shouldn't this be `!showAutoDo
+155,"@@ -140,3 +140,11 @@ func (c *Call) RoutingDelegate() string {
+ 	}
+ 	return c.ic.req.RoutingDelegate
+ }
++
++// Features returns the RequestFeatures for this request.
++func (c *Call) Features() transport.RequestFeatures {
++	if c == nil {
++		return transport.RequestFeatures{}
++	}
++	return c.ic.req.Features
++}",Do we need to put this on the Call? We only need the API communication between the Encoding and the Transports which is currently done through the Transport.Request. The Call is used by users right?,I don't think this is needed.
+156,"@@ -1202,3 +1202,15 @@ L:
+ 	}
+ 	return filtered
+ }
++
++func (a *WebAPI) GenerateAPIKey(ctx context.Context, req *webservice.GenerateAPIKeyRequest) (*webservice.GenerateAPIKeyResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *WebAPI) DisableAPIKey(ctx context.Context, req *webservice.DisableAPIKeyRequest) (*webservice.DisableAPIKeyResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *WebAPI) ListAPIKeys(ctx context.Context, req *webservice.ListAPIKeysRequest) (*webservice.ListAPIKeysResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}",`ctx` is unused in GenerateAPIKey,Why is this not implemented?
+157,"@@ -75,6 +75,7 @@ type (
+ func NewBlockDAO(indexers []BlockIndexer, cfg config.DB) BlockDAO {
+ 	blkStore, err := filedao.NewFileDAO(cfg)
+ 	if err != nil {
++		log.L().Fatal(err.Error(), zap.Any(""cfg"", cfg))
+ 		return nil
+ 	}
+ 	return createBlockDAO(blkStore, indexers, cfg)",Can you judge the type of error?,I think this should be `log.
+158,"@@ -204,7 +204,7 @@ class GridInterface(DictInterface):
+         if edges and not isedges:
+             data = cls._infer_interval_breaks(data)
+         elif not edges and isedges:
+-            data = np.convolve(data, [0.5, 0.5], 'valid')
++            data = data[:-1] + np.diff(data)/2.
+         return data
+ 
+ ",Much simpler than a weird and confusing ``convolve`` call!,I don't think this is correc
+159,"@@ -739,8 +739,8 @@ describe('suspense', () => {
+ 				expect(scratch.innerHTML).to.eql(
+ 					`<div>Hello first 2</div><div>Hello second 2</div>`
+ 				);
+-				expect(Suspender1.prototype.render).to.have.been.calledThrice;
+-				expect(Suspender2.prototype.render).to.have.been.calledThrice;
++				expect(Suspender1.prototype.render).to.have.been.calledTwice;
++				expect(Suspender2.prototype.render).to.have.been.calledTwice;
+ 			});
+ 		});
+ 	});","Huh, this seems weird to me... Surely the suspenders render was called again in order to get the new `<div>Hello second 2</div>` output... Imma take a peak at these tests to understand what's going on",Why did this change?
+160,"@@ -80,6 +80,10 @@ class ApplicationController < ActionController::Base
+   def failed_destroy_error(obj, obj_name)
+     ""#{_('Could not delete the %{o}.') % {o: obj_name}} #{errors_to_s(obj)}""
+   end
++  
++  def success_message(obj_name, action)
++    ""#{_('Successfully %{action} your %{object}.') % {object: obj_name, action: action}}""
++  end
+ 
+   private
+     # Override rails default render action to look for a branded version of a","Since this is just a helper function to create text, perhaps this could live in a helper? I noticed that we have a few other error/message creators in the application controller as well, but I think this type of function should be re-factored to be part of a helper.",Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+161,"@@ -92,7 +92,7 @@ evaluation=10.0 - ((float(5 * error + warning + refactor + convention) / stateme
+ 
+ # Template used to display messages. This is a python new-style format string
+ # used to format the message information. See doc for all details
+-#msg-template=
++msg-template=[{msg_id}] {path}:{line:3d}:{column}: {msg}
+ 
+ 
+ [SPELLING]","Will this mess up parsing the messages by other editors? (vscode, vim ...)",I'm not sure if this is the best way to format the message. I think it would b
+162,"@@ -1,4 +1,3 @@
+-# Set up gems listed in the Gemfile.
+-ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../../Gemfile', __FILE__)
++ENV['BUNDLE_GEMFILE'] ||= File.expand_path('../Gemfile', __dir__)
+ 
+-require 'bundler/setup' if File.exists?(ENV['BUNDLE_GEMFILE'])
++require 'bundler/setup' # Set up gems listed in the Gemfile.",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I think this should be `require 'bundler/setup'`
+163,"@@ -28,8 +28,13 @@ namespace Microsoft.AspNet.Server.Kestrel.Filter
+             _filteredStream = filteredStream;
+             _socketInputStream = new SocketInputStream(SocketInput);
+ 
+-            _filteredStream.CopyToAsync(_socketInputStream).ContinueWith((task, state) =>
++            var block = memory.Lease();
++            // Use pooled block for copy
++            _filteredStream.CopyToAsync(_socketInputStream, block).ContinueWith((task, state) =>
+             {
++                var returnedBlock = task.Result;
++                returnedBlock.Pool?.Return(returnedBlock);
++
+                 ((FilteredStreamAdapter)state).OnStreamClose(task);
+             }, this);
+         }",Why can the pool be null?,Why do we need to use a pool here?
+164,"@@ -74,6 +74,15 @@ class ToggleButton(ia2Web.Ia2Web):
+ 		return states
+ 
+ 
++class PresentationalList(ia2Web.Ia2Web):
++	"""""" Ensures that lists like UL, DL and OL always have the readonly state.""""""
++
++	def _get_states(self):
++		states = super().states
++		states.add(controlTypes.STATE_READONLY)
++		return states
++
++
+ def findExtraOverlayClasses(obj, clsList):
+ 	""""""Determine the most appropriate class(es) for Chromium objects.
+ 	This works similarly to L{NVDAObjects.NVDAObject.findOverlayClasses} except that it never calls any other findOverlayClasses method.","It might be good to have a note here: > work-around for issue #7562 allowing us to differentiate presentational lists from interactive lists (such as of size greater 1 and ARIA list boxes). In firefox, this is possible by the presence of a read-only state, even in content editable.",Why is this needed?
+165,"@@ -66,16 +66,16 @@ import java.util.Set;
+  * the current node) may be queried.
+  *
+  */
+-class DigraphNode implements Cloneable, Serializable {
++class DigraphNode<E> implements Cloneable, Serializable {
+ 
+     /** The data associated with this node. */
+-    protected Object data;
++    protected E data;
+ 
+     /**
+      * A <code>Set</code> of neighboring nodes pointed to by this
+      * node.
+      */
+-    protected Set outNodes = new HashSet();
++    protected Set<DigraphNode<E>> outNodes = new HashSet<>();
+ 
+     /** The in-degree of the node. */
+     protected int inDegree = 0;",This set of changes is the one part of this that I'm not completely sure is valid. Can someone look over this to make sure I got the E's right?,Why do we need this
+166,"@@ -282,8 +282,12 @@ void nano::bootstrap_attempt_legacy::request_push (nano::unique_lock<std::mutex>
+ void nano::bootstrap_attempt_legacy::add_frontier (nano::pull_info const & pull_a)
+ {
+ 	nano::pull_info pull (pull_a);
+-	nano::lock_guard<std::mutex> lock (mutex);
+-	frontier_pulls.push_back (pull);
++	// Prevent incorrent or malicious pulls with frontier 0 insertion
++	if (!pull.head.is_zero ())
++	{
++		nano::lock_guard<std::mutex> lock (mutex);
++		frontier_pulls.push_back (pull);
++	}
+ }
+ 
+ void nano::bootstrap_attempt_legacy::add_bulk_push_target (nano::block_hash const & head, nano::block_hash const & end)",There doesn't seem to be a reason to copy this here.,`if (pull.head.is_z
+167,"@@ -1774,6 +1774,7 @@ std::string h2o_raw_tracer::bpf_text() {
+ 
+ #include <linux/sched.h>
+ #include <linux/limits.h>
++#include ""include/h2o/ebpf.h""
+ 
+ #define STR_LEN 64
+ ","We've avoided including h2o headers in BPF programs because it's a runtime dependency. However, IIRC, this is because h2olog was maintained in the separate repository so that h2olog did not know where h2o was installed. Now h2olog can use `H2O_ROOT`, we should add it to BCC's `cflags` in order to include h2o headers in BPF programs.","#include ""h2o/ebpf."
+168,"@@ -170,6 +170,10 @@ type ThanosRulerSpec struct {
+ 	// Note: Currently only the CAFile, CertFile, and KeyFile fields are supported.
+ 	// Maps to the '--grpc-server-tls-*' CLI args.
+ 	GRPCServerTLSConfig *TLSConfig `json:""grpcServerTlsConfig,omitempty""`
++	// The external Query URL the Thanos Ruler will set in the 'Source' field
++	// of all alerts.
++	// Maps to the '--alert.query-url' CLI arg.
++	AlertQueryURL string `json:""alertQueryUrl,omitempty""`
+ }
+ 
+ // ThanosRulerStatus is the most recent observed status of the ThanosRuler. Read-only. Not",I think the docstring here should include the CLI arg `--alert.query-url` just to make it clear to users which setting this uses.,I'm not sure if this is the right place to put this. I think it would be better to put it in the `alerts` package.
+169,"@@ -224,9 +224,7 @@ func (m *ipipManager) CompleteDeferredWork() error {
+ 		for _, ip := range m.activeHostnameToIP {
+ 			members = append(members, ip)
+ 		}
+-		for _, ip := range m.externalNodeCIDRs {
+-			members = append(members, ip)
+-		}
++		members = append(members, m.externalNodeCIDRs...)
+ 		m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, members)
+ 		m.ipSetInSync = true
+ 	}",Same change just above?,Why this change?
+170,"@@ -511,4 +511,14 @@ describe('services_SearchEngine', function() {
+ 		expect((await engine.search('""- [ ]""', { searchType: SearchEngine.SEARCH_TYPE_BASIC })).length).toBe(1);
+ 		expect((await engine.search('""[ ]""', { searchType: SearchEngine.SEARCH_TYPE_BASIC })).length).toBe(2);
+ 	}));
++
++	it('should not mistake cyrillic ""l"" for latin ""n""', asyncTest(async () => {
++		const n1 = await Note.save({ title: 'latin n', body: 'n' });
++		const n2 = await Note.save({ title: 'cyrillic l', body: 'л' });
++
++		await engine.syncTables();
++
++		expect((await engine.search('n')).length).toBe(1);
++		expect((await engine.search('л')).length).toBe(1);
++	}));
+ });","Could you check the result content rather than just the number of search results please? For example with this test if the search engine suddenly starts returning ""latin n"" for both queries, we won't know about it.",I think you can use `toBe(2)` here.
+171,"@@ -47,9 +47,10 @@ const (
+ 
+ 	otherDomainID = ""spiffe://otherdomain.test""
+ 
+-	serverID   = ""spiffe://example.org/spire/server""
+-	agentID    = ""spiffe://example.org/spire/agent/test/id""
+-	workloadID = ""spiffe://example.org/workload""
++	serverID    = ""spiffe://example.org/spire/server""
++	agentID     = ""spiffe://example.org/spire/agent/test/id""
++	agentlessID = ""spiffe://example.org/test/id""
++	workloadID  = ""spiffe://example.org/workload""
+ 
+ 	// used to cancel stream operations on test failure instead of blocking the
+ 	// full go test timeout period (i.e. 10 minutes)",nit: I think that `workloadID` should suffice for this test... that's what we'd be issuing anyways,I think this should be `spiffe://otherdomain.test`
+172,"@@ -1,4 +1,4 @@
+-require 'spec_helper'
++require 'rails_helper'
+ 
+ feature 'Admin manages mentors' do
+   scenario 'creating a new mentor' do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+173,"@@ -204,11 +204,7 @@ public class ClassTypeResolver extends JavaParserVisitorAdapter {
+             if (className != null) {
+                 populateClassName(node, className);
+             }
+-        } catch (ClassNotFoundException e) {
+-            if (LOG.isLoggable(Level.FINE)) {
+-                LOG.log(Level.FINE, ""Could not find class "" + className + "", due to: "" + e);
+-            }
+-        } catch (NoClassDefFoundError e) {
++        } catch (ClassNotFoundException | NoClassDefFoundError e) {
+             if (LOG.isLoggable(Level.FINE)) {
+                 LOG.log(Level.FINE, ""Could not find class "" + className + "", due to: "" + e);
+             }",We should have a rule to detect identical catch branches,Why is this change needed?
+174,"@@ -28,10 +28,6 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+ 
+         public bool PublishFlatContainer { get; set; }
+ 
+-        public int RetryAttempts { get; set; } = 5;
+-
+-        public int RetryDelayInSeconds { get; set; } = 30;
+-
+         public int MaxClients { get; set; } = 8;
+ 
+         public bool SkipCreateContainer { get; set; } = false;",remove these from the targets file.,Why are we removing these?
+175,"@@ -11,14 +11,13 @@ import (
+ 	""time""
+ 
+ 	""github.com/ethersphere/bee/pkg/addressbook""
++	""github.com/ethersphere/bee/pkg/bzz""
+ 	""github.com/ethersphere/bee/pkg/hive/pb""
+ 	""github.com/ethersphere/bee/pkg/logging""
+ 	""github.com/ethersphere/bee/pkg/p2p""
+ 	""github.com/ethersphere/bee/pkg/p2p/protobuf""
+ 	""github.com/ethersphere/bee/pkg/storage""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+-
+-	ma ""github.com/multiformats/go-multiaddr""
+ )
+ 
+ const (","now that we have the signature in the hive messages, it might be that this must be drastically reduced, since there are limits on the protobuf reader/writers i believe",Please remove this empty line.
+176,"@@ -35,11 +35,12 @@ NAMESPACE_PACKAGES = [
+ REQUIRED_PACKAGES = [
+     # Installation related.
+     'anytree==2.4.3',
+-    'google-api-python-client==1.7.7',
+-    'google-auth==1.6.2',
++    'google-api-python-client==1.7.10',
++    'google-auth==1.6.3',
+     'google-auth-httplib2==0.0.3',
+     'Jinja2==2.10.1',
+     'jmespath==0.9.3',
++    'mailjet-rest==1.3.3',
+     'netaddr==0.7.19',
+     'pyyaml==4.2b4',
+     'python-graph-core==1.8.2',","I recommend that we move this to be optional, as other users might not need it. Can you look at `OPTIONAL_PACKAGES` section, around line 68?",I don't think we need this anymore.
+177,"@@ -8,10 +8,7 @@ package javaslang.control;
+ import javaslang.Serializables;
+ import org.junit.Test;
+ 
+-import java.util.Iterator;
+-import java.util.NoSuchElementException;
+-import java.util.Objects;
+-import java.util.Optional;
++import java.util.*;
+ 
+ import static org.assertj.core.api.Assertions.assertThat;
+ ",I usually set idea to never use wildcard import such as `import java.util.*;` Now i use setting from javaslang standard.,Please don't use wildcard imports.
+178,"@@ -29,7 +29,9 @@ module Beaker
+         v_file << ""    v.vm.box = '#{host['box']}'\n""
+         v_file << ""    v.vm.box_url = '#{host['box_url']}'\n"" unless host['box_url'].nil?
+         v_file << ""    v.vm.base_mac = '#{randmac}'\n""
+-        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
++        host['ips'].each do |ip|
++          v_file << ""    v.vm.network :private_network, ip: \""#{ip.to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
++        end
+ 
+         if host['disk_path']
+           v_file << ""    v.vm.provider :virtualbox do |vb|\n""",Where is host['ips'] coming from?,I think this should be `host['ips']
+179,"@@ -3,14 +3,7 @@
+ 
+ package userns
+ 
+-import (
+-	""strings""
+-
+-	""github.com/opencontainers/runc/libcontainer/user""
+-)
+-
+-func FuzzUIDMap(data []byte) int {
+-	uidmap, _ := user.ParseIDMap(strings.NewReader(string(data)))
+-	_ = uidMapInUserNS(uidmap)
++func FuzzUIDMap(uidmap []byte) int {
++	_ = uidMapInUserNS(string(uidmap))
+ 	return 1
+ }",oh! missed a `:` here; let me fix that; also can get rid of the intermediate variable,Why is this file being removed?
+180,"@@ -1,6 +1,8 @@
+ describe ""Display status text"" do
+   let(:proposal) { FactoryGirl.create(:proposal, :with_parallel_approvers) }
+   before do
++    proposal.approvers.first.update(first_name: ""Uniquely"", last_name: ""Named"")
++    proposal.approvers.second.update(first_name: ""Onlyof"", last_name: ""Itskind"")
+     login_as(proposal.requester)
+   end
+ ",Is this necessary?,I'm not sure if this is the best way to do this. I'm not sure what the best way to do this is.
+181,"@@ -1,8 +1,16 @@
+-import React from 'react';
++import React, {Component} from 'react';
+ import 'element-theme-default';
+ import {i18n} from 'element-react';
+ import locale from 'element-react/src/locale/lang/en';
+ 
++import storage from './utils/storage';
++import logo from './utils/logo';
++import {makeLogin, isTokenExpire} from './utils/login';
++
++import Header from './components/Header';
++import Footer from './components/Footer';
++import LoginModal from './components/Login';
++
+ i18n.use(locale);
+ 
+ import Route from './router';",I'd create a different method for each render section.,Why do we need this?
+182,"@@ -23,6 +23,8 @@ public class EstimateGasOperationTracer implements OperationTracer {
+ 
+   private Gas sStoreStipendNeeded = Gas.ZERO;
+ 
++  private boolean isReverted = false;
++
+   @Override
+   public void traceExecution(
+       final MessageFrame frame, final OperationTracer.ExecuteOperation executeOperation) {",Instead of storing the revert flag in the tracer is it possible to use org.hyperledger.besu.ethereum.mainnet.TransactionProcessor.Result#getRevertReason? (via org.hyperledger.besu.ethereum.transaction.TransactionSimulatorResult#getResult)? If a TX reverts without a reason do we get an empty revert reason or a revert reason with zero bytes?,Why is this needed?
+183,"@@ -71,7 +71,7 @@ public class TestSparkOrcReader extends AvroDataTest {
+ 
+     try (CloseableIterable<InternalRow> reader = ORC.read(Files.localInput(testFile))
+         .project(schema)
+-        .createReaderFunc(SparkOrcReader::new)
++        .createReaderFunc(readOrcSchema -> new SparkOrcReader(schema, readOrcSchema))
+         .build()) {
+       final Iterator<InternalRow> actualRows = reader.iterator();
+       final Iterator<InternalRow> expectedRows = expected.iterator();",I think this should test with and without container reuse if that is implemented in this PR. Probably just make this test parameterized.,`SparkOrcReader` -> `SparkOrcReader`
+184,"@@ -100,6 +100,10 @@ abstract class BaseFile<F>
+           found = true;
+           fromProjectionPos[i] = j;
+         }
++        if (fields.get(i).fieldId() == ManifestFile.SPEC_ID.fieldId()) {
++          found = true;
++          fromProjectionPos[i] = 14;
++        }
+       }
+ 
+       if (!found) {",These modifications allow BaseFile to translate into a SparkRow with the specID as a column,Why is this needed?
+185,"@@ -519,7 +519,7 @@ function resolveReadPreference(parent, options) {
+     throw new Error('No readPreference was provided or inherited.');
+   }
+ 
+-  return readPreference;
++  return typeof readPreference === 'string' ? new ReadPreference(readPreference) : readPreference;
+ }
+ 
+ /**",is this something we've been missing this whole time?,Why not just `retur
+186,"@@ -25,6 +25,7 @@ import (
+ const (
+ 	defaultWaitApprovalTimeout  = Duration(6 * time.Hour)
+ 	defaultAnalysisQueryTimeout = Duration(30 * time.Second)
++	allEvents                   = ""*""
+ )
+ 
+ type GenericDeploymentSpec struct {",nit: this is a package-wide constant so better to narrow the scope like `allEventsSign`.,Why is this a<msg>I
+187,"@@ -111,6 +111,15 @@ def generate_thrift_files(thrift_files_dir, env, silent=True):
+         LOG.error('Failed to generate viewer server files')
+         return ret
+ 
++    auth_thrift = os.path.join(thrift_files_dir, 'authentication.thrift')
++    auth_thrift = 'authentication.thrift'
++    auth_cmd = ['thrift', '-r', '-I', '.',
++                '--gen', 'py', auth_thrift]
++    ret = run_cmd(auth_cmd, thrift_files_dir, env, silent=silent)
++    if ret:
++        LOG.error('Failed to generate authentication interface files')
++        return ret
++
+ 
+ # -------------------------------------------------------------------
+ def generate_documentation(doc_root, env, silent=True):",There seems to be some repetition. Does a local function make this code shorter overall?,Why do we need this
+188,"@@ -298,6 +298,7 @@ function diffElementNodes(
+ 	}
+ 
+ 	if (dom == null) {
++		isHydrating = false;
+ 		if (newVNode.type === null) {
+ 			return document.createTextNode(newProps);
+ 		}",Might be cheaper to reuse the `null` assignment of line 313 and set `isHydrating` to null instead WDYT?,Why do we need this?
+189,"@@ -22,7 +22,6 @@ import java.util.List;
+ 
+ @AutoValue
+ public abstract class TestCaseView {
+-
+   public abstract String clientMethodName();
+ 
+   public abstract InitCodeView initCode();",Revert this blank line,Why was this removed
+190,"@@ -50,8 +50,8 @@ public class MoveReplicaHDFSTest extends MoveReplicaTest {
+       HdfsTestUtil.teardownClass(dfsCluster);
+     } finally {
+       dfsCluster = null;
+-      System.setProperty(""solr.hdfs.blockcache.blocksperbank"", ""512"");
+-      System.setProperty(""tests.hdfs.numdatanodes"", ""1"");
++      System.clearProperty(""solr.hdfs.blockcache.blocksperbank"");
++      System.clearProperty(""tests.hdfs.numdatanodes"");
+     }
+   }
+ ",This was introduced recently for the Hadoop 3 upgrade. Copy/paste error but definitely causing some of the new test failures.,Why did you remove t
+191,"@@ -2,6 +2,7 @@ class ProposalsController < ApplicationController
+   include TokenAuth
+ 
+   skip_before_action :authenticate_user!, only: [:approve]
++  before_action :check_disabled_client
+   # TODO use Policy for all actions
+   before_action ->{authorize proposal}, only: [:show, :cancel, :cancel_form, :history]
+   before_action :needs_token_on_get, only: :approve",I think we should only need to do this for `:approve` since we are using `authenticate_user!` for all other actions and that checks for disabled client,Why do we need this?
+192,"@@ -56,9 +56,10 @@ class DefaultBucketViewTest(BaseWebTest, unittest.TestCase):
+         self.app.get(self.collection_url, headers=self.headers)
+ 
+     def test_querystring_parameters_are_taken_into_account(self):
+-        self.app.get(self.collection_url + '/records?_since=invalid',
+-                     headers=self.headers,
+-                     status=400)
++        resp = self.app.get(self.collection_url + '/records?_since=invalid',
++                            headers=self.headers,
++                            status=400)
++        self.assertIn('Content-Length', resp.headers)
+ 
+     def test_option_is_possible_without_authentication_for_default(self):
+         headers = 'authorization,content-type'",I wonder if we should create new tests for header checks; here for instance we're mixing querystring and headers. Thoughts?,I think this should be `resp.status_code`
+193,"@@ -42,7 +42,7 @@ module Bolt
+         path = File.join(libexec, 'custom_facts.rb')
+         file = { 'name' => 'custom_facts.rb', 'path' => path }
+         metadata = { 'supports_noop' => true, 'input_method' => 'stdin' }
+-        Bolt::Task.new(name: 'custom_facts', files: [file], metadata: metadata)
++        Bolt::Task.new(name: 'apply_helpers::custom_facts', files: [file], metadata: metadata)
+       end
+     end
+ ","We should be able to add sensitive by hard-coding the parameters, same as you put into the metadata in apply_helpers.",This should be `apply_helpers::custom_fac
+194,"@@ -0,0 +1,11 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Shopsys\ShopBundle\Model\Order\Item;
++
++use Shopsys\FrameworkBundle\Model\Order\Item\OrderItemFactory as BaseOrderItemFactory;
++
++class OrderItemFactory extends BaseOrderItemFactory
++{
++}",Why do you think that it is necessary to create this class?,Missing license header.
+195,"@@ -18,8 +18,8 @@ type Hash struct {
+ //
+ // See http://docs.aws.amazon.com/amazonglacier/latest/dev/checksum-calculations.html for more information.
+ func ComputeHashes(r io.ReadSeeker) Hash {
+-	r.Seek(0, 0)       // Read the whole stream
+-	defer r.Seek(0, 0) // Rewind stream at end
++	start, _ := r.Seek(0, 1)  // Read the whole stream
++	defer r.Seek(start, 0) // Rewind stream at end
+ 
+ 	buf := make([]byte, bufsize)
+ 	hashes := [][]byte{}",replacing the `1` with `io.SeekCurrent` may be good here,Why is this change needed?
+196,"@@ -0,0 +1,15 @@
++package main
++
++import (
++	""time""
++
++	""gopkg.in/square/go-jose.v2""
++)
++
++type JWKSSource interface {
++	// FetchJWKS returns the key set and modified time.
++	FetchKeySet() (*jose.JSONWebKeySet, time.Time, bool)
++
++	// Close closes the source.
++	Close() error
++}",nit: perhaps this file would be better named `jwks_source.go` ?,Why do we need this interface?
+197,"@@ -153,6 +153,9 @@ public class Constants {
+   // Overridable plugin load properties
+   public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = ""azkaban.plugin.load.override.props"";
+ 
++  // File containing param override configs
++  public static final String PARAM_OVERRIDE_FILE = ""param_override.properties"";
++
+   // Azkaban event reporter constants
+   public static class EventReporterConstants {
+ ",It will be helpful to specify the intended priority as well for the properties within this file.,This should be `azkaban.plugin
+198,"@@ -23,6 +23,8 @@ import (
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/osinfo""
+ )
+ 
++type RunFunc func(*exec.Cmd) ([]byte, error)
++
+ var (
+ 	// AptExists indicates whether apt is installed.
+ 	AptExists bool","Make this private and update all the public functions to not take this argument. The variable you set below should also be private, then in the tests instead of passing the variable in to the function just update the variable. We don't want to expose the testing implementation in the public api if it can be avoided.",Why is this exported?
+199,"@@ -1956,7 +1956,7 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		""OFF""),
+   DDkwd__(HIVE_DEFAULT_CHARSET,            (char *)SQLCHARSETSTRING_UTF8),
+   DD_____(HIVE_DEFAULT_SCHEMA,                  ""HIVE""),
+   DD_____(HIVE_FILE_CHARSET,                    """"),
+-  DD_____(HIVE_FILE_NAME,     ""/hive/tpcds/customer/customer.dat"" ),
++  DD_____(HIVE_FILE_NAME,     ""/user/trafodion/hive/tpcds/customer/customer.dat"" ),
+   DD_____(HIVE_HDFS_STATS_LOG_FILE,             """"),
+   DDui___(HIVE_INSERT_ERROR_MODE,               ""1""),
+   DDint__(HIVE_LIB_HDFS_PORT_OVERRIDE,          ""-1""),",Do you now why is it a specific table name is used as a default?,Why is this change needed?
+200,"@@ -414,8 +414,8 @@ namespace Microsoft.DotNet.Build.Tasks
+                     return Environment.GetEnvironmentVariable(""TMPDIR"");
+                 else if (DirExists(Environment.GetEnvironmentVariable(""TMP"")))
+                     return Environment.GetEnvironmentVariable(""TMP"");
+-                else if (DirExists(""/home/DDITAdministrator/myagent/_work/_temp""))
+-                    return ""/home/DDITAdministrator/myagent/_work/_temp"";
++                else if (DirExists(Path.Combine(Environment.GetEnvironmentVariable(""HOME""), ""myagent/_work/_temp"")))
++                    return Path.Combine(Environment.GetEnvironmentVariable(""HOME""), ""myagent/_work/_temp"");
+                 else
+                 {
+                     Log.LogMessage(""No TEMP dir found."");","If all you're doing is checking for the existence of a directory as your ""temp"" directory, why does it matter what OS you're on?","Shouldn't this be `Path.Combine(Path.GetTempPath(), ""myagent/_work/_temp"")`?"
+201,"@@ -60,10 +60,11 @@
+ package server
+ 
+ import (
+-	""fmt""
++	v2 ""github.com/algorand/go-algorand/daemon/algod/api/server/v2""
++	""github.com/algorand/go-algorand/daemon/algod/api/server/v2/generated""
+ 	""net/http""
+ 
+-	""github.com/gorilla/mux""
++	""github.com/labstack/echo/v4""
+ 
+ 	""github.com/algorand/go-algorand/daemon/algod/api/server/common""
+ 	""github.com/algorand/go-algorand/daemon/algod/api/server/lib""",nit- would be cleaner to import it once,I think this should be `v4`
+202,"@@ -159,6 +159,14 @@ class GenericProxyHandler(BaseHTTPRequestHandler):
+             # allow pre-flight CORS headers by default
+             if 'Access-Control-Allow-Origin' not in response.headers:
+                 self.send_header('Access-Control-Allow-Origin', '*')
++            if 'Access-Control-Allow-Headers' not in response.headers:
++                self.send_header('Access-Control-Allow-Headers', ','.join([
++                    'authorization',
++                    'x-amz-content-sha256',
++                    'x-amz-date',
++                    'x-amz-security-token',
++                    'x-amz-user-agent'
++                ])
+ 
+             self.end_headers()
+             if len(response.content):",Looks like there is a closing parenthesis `)` missing here.,I don't think this is necessary.
+203,"@@ -1684,8 +1684,8 @@ void PairTlsph::coeff(int narg, char **arg) {
+                 } // end energy release rate failure criterion
+ 
+                 else {
+-                        sprintf(str, ""unknown *KEYWORD: %s"", arg[ioffset]);
+-                        error->all(FLERR, str);
++                  snprintf(str,128,""unknown *KEYWORD: %s"", arg[ioffset]);
++                  error->all(FLERR, str);
+                 }
+ 
+         }",this one bothers me. There are many places where this one is written to for an error message and just a single callsite is changed.,Why 128? Why not 128?
+204,"@@ -706,6 +706,7 @@ func TestKBFSOpsGetBaseDirChildrenCacheSuccess(t *testing.T) {
+ 	ops := getOps(config, id)
+ 	n := nodeFromPath(t, ops, p)
+ 
++	config.mockMdserv.EXPECT().FastForwardBackoff().AnyTimes()
+ 	children, err := config.KBFSOps().GetDirChildren(ctx, n)
+ 	if err != nil {
+ 		t.Errorf(""Got error on getdir: %+v"", err)","You can put this in `kbfsOpsInit()` in you want, so we don't have to call it in every test.",Why is this needed?
+205,"@@ -528,8 +528,10 @@ drx_insert_counter_update(void *drcontext, instrlist_t *ilist, instr_t *where,
+         }
+     }
+ #elif defined(AARCHXX)
++#    ifdef ARM_32
+     /* FIXME i#1551: implement 64-bit counter support */
+-    ASSERT(!is_64, ""DRX_COUNTER_64BIT is not implemented"");
++    ASSERT(!is_64, ""DRX_COUNTER_64BIT is not implemented for ARM_32"");
++#    endif /* ARM_32 */
+ 
+     if (use_drreg) {
+         if (drreg_reserve_register(drcontext, ilist, where, NULL, &reg1) !=","`ARM_32` is what clients define as an input to DR, and is not always defined internally: we use just `ARM` to mean AArch32.",This should be `#el
+206,"@@ -38,8 +38,11 @@ import javax.annotation.Nullable;
+ /** A field declaration wrapper around a Discovery Schema. */
+ public class DiscoveryField implements FieldModel, TypeModel {
+   private final List<DiscoveryField> properties;
++  // Dereferenced schema for use rendering type names and determining properties, type, and format.
+   private final Schema schema;
+-  private final Schema originalSchema; // Not dereferenced schema.
++
++  // Not dereferenced schema; used in rendering this FieldModel's parameter name.
++  private final Schema originalSchema;
+   private final DiscoApiModel apiModel;
+ 
+   /* Create a FieldModel object from a non-null Schema object, and internally dereference the input schema. */",s/for use/to use for/,I'm not sure if thi
+207,"@@ -60,7 +60,7 @@ class UserCreatedEventProjector
+                 'language' => $event->getLanguage()->getCode(),
+                 'password' => $event->getPassword()->getValue(),
+                 'is_active' => $event->isActive(),
+-                'avatar_id' => $event->getAvatarId() ? $event->getAvatarId()->getValue() : null,
++                'avatar_filename' => $event->getAvatarFilename() ? $event->getAvatarFilename()->getValue() : null,
+             ],
+             [
+                 'is_active' => \PDO::PARAM_BOOL,",` $event->getAvatarFilename()` this function return `string` or `null`. In this place ` $event->getAvatarFilename()->getValue()` return `Fatal error `,This should be `ava
+208,"@@ -34,7 +34,7 @@ import (
+ 
+ var (
+ 	// ErrPersistenceLimitExceeded is the error indicating QPS limit reached.
+-	ErrPersistenceLimitExceeded = serviceerror.NewResourceExhausted(""Persistence Max QPS Reached."")
++	ErrPersistenceLimitExceeded = serviceerror.NewUnavailable(""Persistence Max QPS Reached."")
+ )
+ 
+ type (",why not creating a new error type for server's own resource limit exceed error and do conversion within rpc interceptor?,Why is this change needed?
+209,"@@ -27,13 +27,10 @@ namespace OpenTelemetry.Instrumentation.AspNet
+     public class AspNetInstrumentationOptions
+     {
+         /// <summary>
+-        /// Gets or sets <see cref=""TextMapPropagator""/> for context propagation. Default value: <see cref=""CompositeTextMapPropagator""/> with <see cref=""TraceContextPropagator""/> &amp; <see cref=""BaggagePropagator""/>.
++        /// Gets or sets <see cref=""TextMapPropagator""/> for context propagation.
++        /// By default, <see cref=""Propagators.DefaultTextMapPropagator"" /> will be used.
+         /// </summary>
+-        public TextMapPropagator Propagator { get; set; } = new CompositeTextMapPropagator(new TextMapPropagator[]
+-        {
+-            new TraceContextPropagator(),
+-            new BaggagePropagator(),
+-        });
++        public TextMapPropagator Propagator { get; set; } = Propagators.DefaultTextMapPropagator;
+ 
+         /// <summary>
+         /// Gets or sets a Filter function to filter instrumentation for requests on a per request basis.","Could be a timing thing here. When options are created they'll copy the ref for the current default propagator. If user sets through SDK the global propagator after that, it won't be reflected. Could leave it null here and then when it is used in instrumentation do `options.Propagator ?? Propagators.DefaultTextMapPropagator`. It would be a slight perf hit but it makes it hot-swappable.",I'm not sure if this is th
+210,"@@ -158,7 +158,6 @@ public class TransactionSimulator {
+         callParams.getFrom() != null ? callParams.getFrom() : DEFAULT_FROM;
+ 
+     BlockHeader blockHeaderToProcess = header;
+-
+     if (transactionValidationParams.isAllowExceedingBalance()) {
+       updater.getOrCreate(senderAddress).getMutable().setBalance(Wei.of(UInt256.MAX_VALUE));
+       if (header.getBaseFee().isPresent()) {",Unrelated file. Please remove from PR.,Why is this removed?
+211,"@@ -2663,6 +2663,7 @@ static work_queue_msg_code_t process_http_request( struct work_queue *q, struct
+ 	} else {
+ 	        // Other requests get raw JSON data.
+ 		send_worker_msg(q,w,""Content-type: text/plain\n\n"");
++		send_worker_msg(q,w,""Access-Control-Allow-Origin: *\n\n"");
+ 		process_queue_status(q, w, &path[1], stoptime );
+ 	}
+ ",Careful: you only want two newlines after the final header message. (That indicates the end of headers and the start of data.),// Other requests get raw 
+212,"@@ -9,6 +9,9 @@ def request(flow):
+     flow.request.headers.pop('If-Modified-Since', None)
+     flow.request.headers.pop('Cache-Control', None)
+ 
++    # do not force https redirection
++    flow.request.headers.pop('Upgrade-Insecure-Requests', None)
++
+     # proxy connections to SSL-enabled hosts
+     if flow.request.pretty_host in secure_hosts:
+         flow.request.scheme = 'https'","This will not work on Python 3 (to which we are transitioning) because `.content` is bytes, not a str. Can you make the pattern a bytes object as well (like so: `b""pattern""`)?",I don't think this is needed.
+213,"@@ -85,7 +85,7 @@ const ariaRoles = {
+ 	},
+ 	combobox: {
+ 		type: 'composite',
+-		requiredOwned: ['textbox', 'listbox', 'tree', 'grid', 'dialog'],
++		requiredOwned: ['listbox', 'tree', 'grid', 'dialog', 'textbox'],
+ 		requiredAttrs: ['aria-expanded'],
+ 		// Note: because aria-controls is not well supported we will not
+ 		// make it a required attribute even though it is required in the","This was to allow the tests to pass when the order of the required was different. Silly, but we don't have an easy way to check for ""equal but order doesn't matter"" in chai.",Why did you change this?
+214,"@@ -16546,6 +16546,18 @@ RelInternalSP::costMethod() const
+ } // RelInternalSP::costMethod()
+ //<pb>
+ 
++CostMethod *
++HbaseDelete::costMethod() const
++{
++  if (CmpCommon::getDefault(HBASE_DELETE_COSTING) == DF_OFF)
++    return RelExpr::costMethod();  // returns cost 1 cost object
++
++  static THREAD_P CostMethodHbaseDelete *m = NULL;
++  if (m == NULL)
++    m = new (GetCliGlobals()->exCollHeap()) CostMethodHbaseDelete();
++  return m;
++} // HbaseDelete::costMethod()
++
+ PhysicalProperty*
+ HbaseDelete::synthPhysicalProperty(const Context* myContext,
+                                    const Lng32     planNumber,","maybe say ""returns the default cost method that returns an object of cost 1"".",Why do we need this?
+215,"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+ 
++	rules = append(rules, Rule{
++		Match: Match().ProtocolNum(ProtoUDP).
++			DestPorts(uint16(r.Config.VXLANPort)).
++			VXLANVNI(uint32(r.Config.VXLANVNI)),
++		Action:  DropAction{},
++		Comment: ""Drop VXLAN encapped packets originating in pods"",
++	})
++	rules = append(rules, Rule{
++		Match:   Match().ProtocolNum(ProtoIPIP),
++		Action:  DropAction{},
++		Comment: ""Drop IPinIP encapped packets originating in pods"",
++	})
++
+ 	if len(policyNames) > 0 {
+ 		// Clear the ""pass"" mark.  If a policy sets that mark, we'll skip the rest of the policies and
+ 		// continue processing the profiles, if there are any.","I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?",I don't think we want to drop
+216,"@@ -125,7 +125,9 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
+                     try {
+                         // Not a 2xx status
+                         if (!response.isSuccess()) {
+-                            callbackContext.error(response.asString());
++                            JSONObject errorObj = new JSONObject();
++                            errorObj.putOpt(""response"", response.fullResponseAsJSONObject());
++                            callbackContext.error(errorObj.toString());
+                         }
+                         // Binary response
+                         else if (returnBinary) {","Use `response.asJsonObject()` instead. Also, use `put()` instead of `putOpt()`, `null` as a value is fine.",Why not use `response.asJSONObject()`?
+217,"@@ -113,7 +113,7 @@ describe('PasswordEditor', () => {
+     const editorHolder = $('.handsontableInputHolder');
+     const editor = editorHolder.find('.handsontableInput');
+ 
+-    expect(parseInt(editorHolder.css('z-index'), 10)).toBeGreaterThan(0);
++    expect(editorHolder.is(':visible')).toBe(true);
+ 
+     editor.val('Edgar');
+ ",Are you sure? We've changed it during an introduction of the IME support.,Why did you change this?
+218,"@@ -46,7 +46,7 @@ class QueryBuilder
+             $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
+         }
+ 
+-        if (!empty($dqlFilter)) {
++        if (null !== $dqlFilter) {
+             $queryBuilder->andWhere($dqlFilter);
+         }
+ ","I think here we want the use of `empty()` to take care of empty strings. If you put `dql_filter: ''` in your YAML config ... this will add `->andWhere('')` and it will fail, right?",`if (null !== $dqlFilter)`
+219,"@@ -170,14 +170,12 @@ func (p *Agent) Start(ctx context.Context) error {
+ 			p2pMsgLatency.WithLabelValues(""broadcast"", strconv.Itoa(int(broadcast.MsgType)), status).Observe(float64(latency))
+ 		}()
+ 		if err = proto.Unmarshal(data, &broadcast); err != nil {
+-			err = errors.Wrap(err, ""error when marshaling broadcast message"")
+-			return
++			return errors.Wrap(err, ""error when marshaling broadcast message"")
+ 		}
+ 		// Skip the broadcast message if it's from the node itself
+ 		rawmsg, ok := p2p.GetBroadcastMsg(ctx)
+ 		if !ok {
+-			err = errors.New(""error when asserting broadcast msg context"")
+-			return
++			return errors.New(""error when asserting broadcast msg context"")
+ 		}
+ 		peerID = rawmsg.GetFrom().Pretty()
+ 		if p.host.HostIdentity() == peerID {","this is golang's named return, err is defined, `return` is equivalent to `return err` the current code has no problem",Why not just `return err`?
+220,"@@ -202,7 +202,7 @@ ostree_gpg_verify_result_get_all (OstreeGpgVerifyResult *result,
+  * ostree_gpg_verify_result_describe:
+  * @result: an #OstreeGpgVerifyResult
+  * @signature_index: which signature to describe
+- * @output_buffer: a #GString to hold the description
++ * @output_buffer: (out): a #GString to hold the description
+  * @line_prefix: (allow-none): optional line prefix string
+  * @flags: flags to adjust the description format
+  *","I don't think this is right; in Rust terms it's like a `&mut String`, in Java `StringBuilder` - it's not a return value from the function which is what `(out)` is for.",I think this should be `@output_buffer: a #GString`
+221,"@@ -7,9 +7,9 @@ from ..registry import LOSSES
+ 
+ def _expand_binary_labels(labels, label_weights, label_channels):
+     bin_labels = labels.new_full((labels.size(0), label_channels), 0)
+-    inds = torch.nonzero(labels >= 1).squeeze()
++    inds = torch.nonzero((labels >= 0) & (labels < label_channels)).squeeze()
+     if inds.numel() > 0:
+-        bin_labels[inds, labels[inds] - 1] = 1
++        bin_labels[inds, labels[inds]] = 1
+     bin_label_weights = label_weights.view(-1, 1).expand(
+         label_weights.size(0), label_channels)
+     return bin_labels, bin_label_weights","If the label is not binary, should we rename this function?",Why did you change this?
+222,"@@ -421,10 +421,12 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister):
+         :param file_list:
+         :return: etree
+         """"""
++        cur_path = r""${__BeanShell(import org.apache.jmeter.services.FileServer; FileServer.getFileServer()"" \
++                   r"".getBaseDir();)}${__BeanShell(File.separator,)}""
+         for file_path in file_list:
+             file_path_elements = jmx.xpath('//stringProp[text()=""%s""]' % file_path)
+             for file_path_element in file_path_elements:
+-                file_path_element.text = os.path.basename(file_path)
++                file_path_element.text = cur_path + os.path.basename(file_path)
+ 
+     def __get_resource_files_from_jmx(self, jmx):
+         """"""",This is very-very bad idea because of its performance impact,Why do we need this change?
+223,"@@ -6,6 +6,7 @@ import (
+ 	""database/sql""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/sonm-io/core/proto""
+ 	""math/big""
+ 	""net""
+ 	""sync""",WHY U NOT SORT IMPORTS?,Please remove this empty line.
+224,"@@ -0,0 +1,11 @@
++module SignInRequestHelpers
++  def sign_in_as(user)
++    post(
++      ""/session"",
++      session: {
++        email: user.email,
++        password: user.password,
++      },
++    )
++  end
++end",Put a comma after the last item of a multiline hash.,Style/TrailingCommaInHashLiteral: Avoid comma after the last item of a hash.
+225,"@@ -12,7 +12,7 @@ __version__ = param.Version(release=(1,7,0), fpath=__file__,
+                             commit=""$Format:%h$"", reponame='holoviews')
+ 
+ from .core import archive                                # noqa (API import)
+-from .core.dimension import OrderedDict, Dimension       # noqa (API import)
++from .core.dimension import OrderedDict, Dimension, Dimensioned       # noqa (API import)
+ from .core.boundingregion import BoundingBox             # noqa (API import)
+ from .core.options import (Options, Store, Cycle,        # noqa (API import)
+                            Palette, StoreOptions)",How come we need ``Dimensioned`` in the top-level namespace?,Why is this needed?
+226,"@@ -75,9 +75,9 @@ import net.runelite.client.util.Text;
+ import net.runelite.client.util.WildcardMatcher;
+ 
+ @PluginDescriptor(
+-	name = ""NPC Indicators"",
+-	description = ""Highlight NPCs on-screen and/or on the minimap"",
+-	tags = {""highlight"", ""minimap"", ""npcs"", ""overlay"", ""respawn"", ""tags""}
++		name = ""NPC Indicators"",
++		description = ""Highlight NPCs on-screen and/or on the minimap"",
++		tags = {""highlight"", ""minimap"", ""npcs"", ""overlay"", ""respawn"", ""tags""}
+ )
+ @Slf4j
+ @Singleton",excess whitespace through plugin.,Why this change?
+227,"@@ -138,7 +138,7 @@ void EdgeBasedGraphFactory::InsertEdgeBasedNode(const NodeID node_u, const NodeI
+     NodeID current_edge_source_coordinate_id = node_u;
+ 
+     // traverse arrays from start and end respectively
+-    for (const auto i : util::irange(0UL, geometry_size))
++    for (const auto i : util::irange(std::size_t{ 0 }, geometry_size))
+     {
+         BOOST_ASSERT(current_edge_source_coordinate_id ==
+                      m_compressed_edge_container.GetBucketReference(",What is the problem here? I feel we used this in a lot of places.,`std::size_t{ 0 }` -> `size_t`
+228,"@@ -109,8 +109,7 @@ class RPN(BaseDetector):
+             for proposals, meta in zip(proposal_list, img_metas):
+                 proposals[:, :4] /= proposals.new_tensor(meta['scale_factor'])
+ 
+-        # TODO: remove this restriction
+-        return proposal_list[0].cpu().numpy()
++        return [proposal.cpu().numpy() for proposal in proposal_list]
+ 
+     def aug_test(self, imgs, img_metas, rescale=False):
+         """"""Test function with test time augmentation.",Update the docstring.,Why did you remove this restriction?
+229,"@@ -7,10 +7,11 @@
+ package api
+ 
+ import (
+-	""errors""
+ 	""testing""
+ 	""time""
+ 
++	""github.com/pkg/errors""
++
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/stretchr/testify/require""
+ ","delete the empty line ""github.com/pkg/errors"" should be grouped with other third party packages same for the rest",nit: remove empty line
+230,"@@ -155,7 +155,7 @@ public class RemoteWebDriver implements WebDriver, JavascriptExecutor,
+   }
+ 
+   private void init(Capabilities capabilities) {
+-    capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;
++    this.capabilities = capabilities == null ? new ImmutableCapabilities() : capabilities;
+ 
+     logger.addHandler(LoggingHandler.getInstance());
+ ",Assigning capabilities to the field here is not the best idea. Semantically this field contains the capabilities returned by the browser after session start. So here we sould better amend capabilities and return them from `init` method to pass later to `startSession` method (that will assign the capabilities returned by the browser to the field).,Why do we need this change?
+231,"@@ -110,8 +110,6 @@ module RSpec::Core
+       end
+     end
+ 
+-    alias_method :abort, :finish
+-
+     def stop
+       @duration = (RSpec::Core::Time.now - @start).to_f if @start
+       notify :stop","Is this a breaking change, or is the API private?",Why did you remove this?
+232,"@@ -0,0 +1,4 @@
++import pandas as pd
++
++test_data = pd.read_json(""./dumps/courseData.json"");
++test_data = {k: val.groupby('pk')['fields'].apply(list).apply(lambda x: x[0]).to_dict() for k, val in test_data.groupby(""model"")};",I don't think we need this dependency in this project right now,Why do we need this file?
+233,"@@ -30,8 +30,9 @@ const (
+ 	// FanoutName is the name used for the fanout container.
+ 	FanoutName = ""fanout""
+ 	// RetryName is the name used for the retry container.
+-	RetryName          = ""retry""
+-	BrokerCellLabelKey = ""brokerCell""
++	RetryName             = ""retry""
++	BrokerCellLabelKey    = ""brokerCell""
++	BrokerSystemNamespace = ""cloud-run-events""
+ )
+ 
+ var (",I don't think this is necessary since `CommonLabels` is a public func and every component name is also public constant.,Why do we need this?
+234,"@@ -155,14 +155,15 @@ module Bolt
+                          ""`task.py`) and the extension is case sensitive. When a target's name is `localhost`, ""\
+                          ""Ruby tasks run with the Bolt Ruby interpreter by default."",
+             additionalProperties: {
+-              type: String,
++              type: [String, Array],
+               _plugin: false
+             },
+             propertyNames: {
+               pattern: ""^.?[a-zA-Z0-9]+$""
+             },
+             _plugin: true,
+-            _example: { ""rb"" => ""/usr/bin/ruby"" }
++            _example: { ""rb"" => [""/usr/bin/ruby"", ""-r"", ""puppet""],
++                        "".py"" => ""/usr/bin/python3"" }
+           },
+           ""job-poll-interval"" => {
+             type: Integer,",The `_example` field should be updated to include an interpreter with an array value.,I don't think we need the
+235,"@@ -532,12 +532,14 @@ var supportedKeyTypes = map[string]acme.KeyType{
+ 
+ // Map of supported protocols.
+ // HTTP/2 only supports TLS 1.2 and higher.
+-var supportedProtocols = map[string]uint16{
++var SupportedProtocols = map[string]uint16{
+ 	""tls1.0"": tls.VersionTLS10,
+ 	""tls1.1"": tls.VersionTLS11,
+ 	""tls1.2"": tls.VersionTLS12,
+ }
+ 
++// NOTE: if updating the above map, also update sslProtocolToStringMap in caddyhttp/fastcgi/fastcgi.go
++
+ // Map of supported ciphers, used only for parsing config.
+ //
+ // Note that, at time of writing, HTTP/2 blacklists 276 cipher suites,",Put this in the godoc of SupportedProtocols instead. Preferably we would just use one map though. Why not just use this one?,I don't think this is the
+236,"@@ -59,13 +59,12 @@ func (container *CronContainer) StopStatsCron() {
+ }
+ 
+ // newCronContainer creates a CronContainer object.
+-func newCronContainer(dockerID *string, name *string, dockerGraphPath string) *CronContainer {
++func newCronContainer(dockerID *string, dockerGraphPath string) *CronContainer {
+ 	statePath := filepath.Join(dockerGraphPath, DockerExecDriverPath, *dockerID)
+ 
+ 	container := &CronContainer{
+ 		containerMetadata: &ContainerMetadata{
+ 			DockerID: dockerID,
+-			Name:     name,
+ 		},
+ 		statePath: statePath,
+ 	}","I'd feel a little safer if the first argument were a string, not a *string unless there's a particular reason for making it a pointer.",Why did you remove the name?
+237,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+ 
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,import static org.junit.Asse
+238,"@@ -19,7 +19,10 @@ package org.openqa.selenium.grid.graphql;
+ 
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
++import org.openqa.selenium.SessionNotCreatedException;
+ import org.openqa.selenium.grid.distributor.Distributor;
++import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.internal.Require;
+ 
+ import java.net.URI;",You can safely revert changes to this file.,This import is unused.
+239,"@@ -127,7 +127,6 @@ class AnchorHead(nn.Module):
+ 
+     def loss_single(self, cls_score, bbox_pred, labels, label_weights,
+                     bbox_targets, bbox_weights, num_total_samples, cfg):
+-        # classification loss
+         labels = labels.reshape(-1)
+         label_weights = label_weights.reshape(-1)
+         cls_score = cls_score.permute(0, 2, 3, 1).reshape(",This deletion is unnecessary.,Why did you remove this?
+240,"@@ -302,7 +302,10 @@ class Notification extends Component {
+ 								mdc-layout-grid__cell
+ 								mdc-layout-grid__cell--span-1
+ 							"">
+-								<img className=""googlesitekit-publisher-win__small-image"" alt="""" src={ smallImage } />
++								{
++									typeof smallImage === 'string'
++										? <img className=""googlesitekit-publisher-win__small-image"" alt="""" src={ smallImage } /> : smallImage
++								}
+ 							</div>
+ 						}
+ ","I'm not a huge fan of this overloading of the prop; accepting very different types of arguments for props like this can be confusing, and wasn't part of the IB. I understand wanting to import the SVG directly, but the IB suggests using `${global._googlesitekitLegacyData.admin.assetsRoot}${userInputSuccessImage}` as the `src`/`smallImage` value here. It'd be great to refactor this to accept components directly in the future, but let's do that all-at-once rather than this hybrid approach that makes the API less clear.",Why is this change needed?
+241,"@@ -21,10 +21,7 @@ import java.io.InputStream;
+ import java.io.StringWriter;
+ import java.lang.invoke.MethodHandles;
+ import java.nio.charset.StandardCharsets;
+-import java.util.Collections;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
+ import java.util.concurrent.TimeUnit;
+ 
+ import org.apache.solr.cloud.ZkController;","I've had this happen recently with IntelliJ, was this intentional?",Please don't use wildcard 
+242,"@@ -22,9 +22,10 @@
+ #include <string.h>
+ #include <string>
+ #include <vector>
+-#include <map>
++#include <unordered_map>
+ #include ""vulkan/vulkan.h""
+ #include ""vk_format_utils.h""
++#include ""hash_util.h""
+ 
+ struct VULKAN_FORMAT_INFO {
+     size_t size;",Order(1) vs Order(logN) -- not sure it's measurable at the ~200 element size of the table. All of the published comparisons start at ~1000 elements.,Why is this needed?
+243,"@@ -33,6 +33,7 @@ import (
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/ip""
+ 	""github.com/mysteriumnetwork/node/core/location""
++	location_factory ""github.com/mysteriumnetwork/node/core/location/factory""
+ 	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/mysteriumnetwork/node/core/port""
+ 	""github.com/mysteriumnetwork/node/core/service""",I don't know about this aliasing and 'factory'. Previous version was rather straightforward: `location.CreateLocationResolver`. Perhaps `location.CreateResolver` would be even better? What do we actually gain here from moving DI to a separate sub-package?,Why do we need this alias?
+244,"@@ -47,6 +47,14 @@ void Engine::SetCallBack(std::function<void(const void *, std::string,
+ {
+ }
+ 
++static void engineThrowUp(const std::string &engineType,
++                          const std::string &func)
++{
++    throw std::invalid_argument(
++        ""ERROR: Engine bass class "" + func + ""() called. "" + engineType +
++        "" child class is not implementing this function\n"");
++}
++
+ // should these functions throw an exception?
+ void Engine::Write(Variable<char> & /*variable*/, const char * /*values*/) {}
+ void Engine::Write(Variable<unsigned char> & /*variable*/,",Use `UpperCamelCase` for function names,I think it would be better to throw an exception instead of throwing an exception.
+245,"@@ -232,9 +232,12 @@ SchemaDate.prototype.cast = function(value) {
+ 
+   if (value instanceof Number || typeof value === 'number') {
+     date = new Date(value);
++  } else if (typeof value === 'string' && !isNaN(Number(value)) && (Number(value) >= 275761 || Number(value) < 0)) {
++    // string representation of milliseconds take this path
++    date = new Date(Number(value));
+   } else if (typeof value.valueOf === 'function') {
+-    // support for moment.js. This is also the path strings will take because strings
+-    // have a `valueOf()`
++    // support for moment.js. This is also the path string representation of years
++    // will take because strings have a `valueOf()`
+     date = new Date(value.valueOf());
+   } else {
+     // fallback","I'm not 100% sold on this idea but I like it in general. Nice compromise between using the 'Date' constructor where possible and falling back to the pre #5880 behavior when it makes sense. However, instead of `Number(value) < 0`, let's do `Number(value) < MIN_YEAR` because `new Date('-2017')` is perfectly valid in JS and I don't want to break the date behavior.","I don't think this is the right place for this check. If the value is a string, it"
+246,"@@ -138,8 +138,7 @@ public abstract class BaseHttpClusterStateProvider implements ClusterStateProvid
+     Set<String> liveNodes = new HashSet((List<String>)(cluster.get(""live_nodes"")));
+     this.liveNodes = liveNodes;
+     liveNodesTimestamp = System.nanoTime();
+-    //TODO SOLR-11877 we don't know the znode path; CLUSTER_STATE is probably wrong leading to bad stateFormat
+-    ClusterState cs = ClusterState.load(znodeVersion, collectionsMap, liveNodes, ZkStateReader.CLUSTER_STATE);
++    ClusterState cs = ClusterState.createFromData(znodeVersion, collectionsMap, liveNodes);
+     if (clusterProperties != null) {
+       Map<String, Object> properties = (Map<String, Object>) cluster.get(""properties"");
+       if (properties != null) {",Remember to close SOLR-11877 after this,Why do we need this change?
+247,"@@ -1124,7 +1124,7 @@ void Identifier::_exportToJSON(JSONFormatter *formatter) const {
+ //! @cond Doxygen_Suppress
+ static bool isIgnoredChar(char ch) {
+     return ch == ' ' || ch == '_' || ch == '-' || ch == '/' || ch == '(' ||
+-           ch == ')' || ch == '.' || ch == '&' || ch == ',';
++           ch == ')' || ch == '.' || ch == '&';
+ }
+ //! @endcond
+ ",this change should be reverted,Why did you change this?
+248,"@@ -186,9 +186,15 @@ type mockedIdentityRegistry struct {
+ 	anyIdentityRegistered bool
+ }
+ 
++// IsRegistered mock
+ func (mir *mockedIdentityRegistry) IsRegistered(address common.Address) (bool, error) {
+ 	return mir.anyIdentityRegistered, nil
+ }
+ 
++// WaitForRegistrationEvent mock
++func (mir *mockedIdentityRegistry) WaitForRegistrationEvent(providerAddress common.Address, registeredEvent chan int, stopLoop chan int) {
++
++}
++
+ //check that we implemented mocked registry correctly
+ var _ registry.IdentityRegistry = &mockedIdentityRegistry{}","This function signature is a bit complicated, some parameters are IN type (stopLoop which is modified from outside), others are OUT (registeredEvent channel which is modified inside function) I suggest the following signature -> SubscribeToRegistrationEvent(identityAddress) returns registeredEvent chan of type (RegisteredEvent not int), Unsubscribe func(), error (in case of any error). That way caller can always cance subscription if needed and check for any errors. Also - unsubscribe function hides any internal details how subscribtion is really implemented",nit: remove empty line
+249,"@@ -45,7 +45,7 @@ const options = {
+         query: ['src/**/*.png', 'src/**/*.jpg', 'src/**/*.gif', 'src/**/*.svg']
+     },
+     copy: {
+-        query: ['src/**/*.json', 'src/**/*.ico']
++        query: ['src/**/*.json', 'src/**/*.ico', 'src/**/*.wav']
+     },
+     injectBundle: {
+         query: 'src/index.html'","`.wav`?! cannot we use something slightly more modern and compressed instead? :) I dunno, like `.mp3` or `.aac` or `.ogg`...",Why is this change nee
+250,"@@ -1602,6 +1602,17 @@ luaA_client_swap(lua_State *L)
+         *ref_swap = c;
+ 
+         luaA_class_emit_signal(L, &client_class, ""list"", 0);
++
++        luaA_object_push(L, swap);
++        lua_pushboolean(L, true);
++        luaA_object_emit_signal(L, -4, ""swapped"", 2);
++        lua_pop(L, 2);
++
++        luaA_object_push(L, swap);
++        luaA_object_push(L, c);
++        lua_pushboolean(L, false);
++        luaA_object_emit_signal(L, -3, ""swapped"", 2);
++        lua_pop(L, 3);
+     }
+ 
+     return 0;",Wouldn't a single signal call be enough? (without the boolean even),I think this should be
+251,"@@ -17,6 +17,11 @@
+       <br/>
+       <%= note_event(@note.status, @note.closed_at, @note_comments.last.author) %>
+     <% end %>
++    <% if current_user && current_user != @note.author %>
++      <%= link_to new_report_url(reportable_id: @note.id, reportable_type: @note.class.name), :title => t('browse.note.report') do %>
++          &nbsp;&#9872;
++      <% end %>
++    <% end %>
+   </div>
+ 
+   <% if @note_comments.find { |comment| comment.author.nil? } -%>","I suspect that this whole block, which is going to be repeated a number of times, should probably be in a helper. I guess it would need to be given the object and the title and could probably figure out everything else from that?",I think this should be
+252,"@@ -218,6 +218,9 @@ class Document < AbstractBlock
+   # Public: Get the Reader associated with this document
+   attr_reader :reader
+ 
++  # Public: Get/Set the PathResolver instance used to resolve paths in this Document.
++  attr_reader :path_resolver
++
+   # Public: Get the Converter associated with this document
+   attr_reader :converter
+ ",Should we expose this attribute in the Asciidoctor.js API ?,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
+253,"@@ -147,7 +147,7 @@ public interface Multimap<K, V> extends Traversable<Tuple2<K, V>>, Function1<K,
+ 
+     @Override
+     default boolean contains(Tuple2<K, V> element) {
+-        return get(element._1).map(v -> Objects.equals(v, element._2)).getOrElse(false);
++        return get(element._1).map(v -> v.contains(element._2)).getOrElse(false);
+     }
+ 
+     /**",I think contains on `Multimap` was broken - it should return true if one of the values is associated with the key? It that right,"`Objects.equals(v, element._2)` is equivalent to `v.equals(element._2)`."
+254,"@@ -57,6 +57,7 @@ public class TiConfiguration implements Serializable {
+   private static final int DEF_KV_CLIENT_CONCURRENCY = 10;
+   private static final List<TiStoreType> DEF_ISOLATION_READ_ENGINES =
+       ImmutableList.of(TiStoreType.TiKV, TiStoreType.TiFlash);
++  private static final int DEF_PREWRITE_CONCURRENCY = 20;
+ 
+   private int timeout = DEF_TIMEOUT;
+   private TimeUnit timeoutUnit = DEF_TIMEOUT_UNIT;",delete this line,I think it's better to use `DEFAULT_PREWRITE_CONCURRENCY`.
+255,"@@ -43,6 +43,7 @@ module Test
+ 
+   def self.setup_models
+     conn = ClientRequest.connection
++    return if conn.table_exists? ""test_client_requests""
+     conn.create_table(:test_client_requests, force: true) do |t|
+       t.decimal  :amount
+       t.string   :project_title",Presumably we no longer need `force: true` here.,Line is too long. [81/80]
+256,"@@ -339,6 +339,12 @@ hipError_t hipHostAlloc(void** ptr, size_t sizeBytes, unsigned int flags) {
+ // width in bytes
+ hipError_t ihipMallocPitch(void** ptr, size_t* pitch, size_t width, size_t height, size_t depth) {
+     hipError_t hip_status = hipSuccess;
++	if(ptr==NULL || ptr==0)
++	{
++	hip_status=hipErrorInvalidValue;
++	return hip_status;
++	}
++	
+     // hardcoded 128 bytes
+     *pitch = ((((int)width - 1) / 128) + 1) * 128;
+     const size_t sizeBytes = (*pitch) * height;",HIP runtime is compiled using a C++ compiler. So comparison to both NULL as well as 0 does not make sense. Just comparing to NULL is sufficient.,Please use spaces around the `==`.
+257,"@@ -0,0 +1,10 @@
++<%= t(""mailer.welcome_mailer.welcome_notification.header"") %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para1"") %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para2"", help_url: help_url('') ) %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.para3"", feedback_url: feedback_url ) %>
++
++<%= t(""mailer.welcome_mailer.welcome_notification.signature"") %>
++",these urls are still in `a` tags so we should probably include these links separately for a non-HTML version,I'm not sure if this is the best w
+258,"@@ -507,8 +507,18 @@ func (s *Server) configureAccounts() error {
+ 	if opts.SystemAccount != _EMPTY_ {
+ 		// Lock may be acquired in lookupAccount, so release to call lookupAccount.
+ 		s.mu.Unlock()
+-		_, err := s.lookupAccount(opts.SystemAccount)
++		acc, err := s.lookupAccount(opts.SystemAccount)
+ 		s.mu.Lock()
++		if err == nil && s.sys != nil && acc != s.sys.account {
++			// sys.account.clients (including internal client)/respmap/etc... are transferred separately
++			s.sys.account = acc
++			s.mu.Unlock()
++			// acquires server lock separately
++			s.addSystemAccountExports(acc)
++			// can't hold the lock as go routine reading it may be waiting for lock as well
++			s.sys.resetCh <- struct{}{}
++			s.mu.Lock()
++		}
+ 		if err != nil {
+ 			return fmt.Errorf(""error resolving system account: %v"", err)
+ 		}","That's fine though, meaning that you can send to this channel under the server lock. The internalSendLoop will pick up the change when the server lock is released (if loop is blocked trying to grab the server lock). Even the way you do it here (releasing the lock, sending, then reacquiring) does not guarantee that the internalSendLoop will have time to refresh in that interval.",Why do we need to lock here?
+259,"@@ -47,6 +47,7 @@ public interface CapabilityType {
+   String ELEMENT_SCROLL_BEHAVIOR = ""elementScrollBehavior"";
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
++  String ENABLE_DOWNLOADING = ""chromium:enableDownloading"";
+ 
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ",The name `enableDownloading` implies this is a boolean capability. How about `downloadDir`?,I think this should be `chromium:d
+260,"@@ -28,10 +28,9 @@ public interface ValidatorManager {
+   Map<String, ValidationReport> validate(Project project, File projectDir);
+ 
+   /**
+-   * The ValidatorManager should have a default validator which checks for the most essential
+-   * components of a project. The ValidatorManager should always load the default validator. This
+-   * method returns the default validator of this ValidatorManager.
++   * ValidatorManager will not have any default validator.
+    */
++  @Deprecated
+   ProjectValidator getDefaultValidator();
+ 
+   /**",Found one internal team is using this method. Will coordinate with them about the migration solution.,Why is this deprecated?
+261,"@@ -230,6 +230,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+ 
++        /// <summary>
++        /// Configuration key for the application's server http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpServerErrorCodes""/>
++        public const string HttpServerErrorCodes = ""DD_HTTP_SERVER_ERROR_STATUSES"";
++
++        /// <summary>
++        /// Configuration key for the application's client http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpClientErrorCodes""/>
++        public const string HttpClientErrorCodes = ""DD_HTTP_CLIENT_ERROR_STATUSES"";
++
+         /// <summary>
+         /// String format patterns used to match integration-specific configuration keys.
+         /// </summary>",The field `HttpServerErrorCodes` should be called `HttpServerErrorStatuses`,Should this be `DD_HTTP
+262,"@@ -35,6 +35,12 @@ MAXIMUM_LOOP_COUNT = 600
+ DEFAULT_BUCKET_FMT_V1 = 'gs://{}-data-{}'
+ DEFAULT_BUCKET_FMT_V2 = 'gs://{}-{}-data-{}'
+ 
++FORSETI_V1_RULE_FILES = [
++    'bigquery_rules.yaml', 'blacklist_rules.yaml', 'bucket_rules.yaml',
++    'cloudsql_rules.yaml', 'firewall_rules.yaml', 'forwarding_rules.yaml',
++    'group_rules.yaml', 'iam_rules.yaml', 'iap_rules.yaml', 'ke_rules.yaml',
++    'instance_network_interface_rules.yaml']
++
+ GCLOUD_MIN_VERSION = (180, 0, 0)
+ GCLOUD_VERSION_REGEX = r'Google Cloud SDK (.*)'
+ GCLOUD_ALPHA_REGEX = r'alpha.*'","Can you please make each of these in a separate line. It will be easier to keep them sorted, and add/remove.",Why do we need this?
+263,"@@ -170,10 +170,14 @@ public class ConfigSetsHandler extends RequestHandlerBase implements PermissionN
+ 
+     boolean overwritesExisting = zkClient.exists(configPathInZk, true);
+ 
+-    if (overwritesExisting && !req.getParams().getBool(ConfigSetParams.OVERWRITE, false)) {
+-      throw new SolrException(ErrorCode.BAD_REQUEST,
+-          ""The configuration "" + configSetName + "" already exists in zookeeper"");
+-    }
++    // Get upload parameters
++    String singleFilePath = req.getParams().get(ConfigSetParams.FILE_PATH, """");
++    boolean allowOverwrite = req.getParams().getBool(ConfigSetParams.OVERWRITE, false);
++    // Cleanup is not allowed while using singleFilePath upload
++    boolean cleanup = singleFilePath.isEmpty() && req.getParams().getBool(ConfigSetParams.CLEANUP, false);
++
++    // Create a node for the configuration in zookeeper
++    createBaseZnode(zkClient, overwritesExisting, isTrusted(req, coreContainer.getAuthenticationPlugin()), cleanup, configPathInZk);
+ 
+     Iterator<ContentStream> contentStreamsIterator = req.getContentStreams().iterator();
+ ","should we error instead of silently ignoring the `cleanup` param? it defaults to `false`, so someone must have explicitly set it to `true`",Why do we need to check
+264,"@@ -191,7 +191,7 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
+ 	if len(archive.File) == 0 {
+ 		return nil, errors.New(""archive is empty"")
+ 	} else if fi := archive.File[0].FileInfo(); !fi.IsDir() {
+-		return nil, errors.New(""archive root is not a directory"")
++		return nil, fmt.Errorf(""archive root directory missing: expected a 'root' directory but got %v"", archive.File[0].Name)
+ 	}
+ 	root := archive.File[0].Name
+ 	pref, err := unitPrefix(root, archive.File)","There is no specific requirement that the root be called `root`, just that there is a single root directory and that it be the first entry in the zip.","This should be `errors.Errorf(""archive root directory missing: expected a 'root' directory but got %q"", archive.File[0].Name)`"
+265,"@@ -1,6 +1,9 @@
+ <% unless ENV['DISABLE_SANDBOX_WARNING'] == 'true' %>
+   <%= render partial: 'shared/sandbox_warning' %>
+ <% end %>
++<% if !current_page?(me_path) && current_user && current_user.requires_profile_attention? %>
++  <%= render partial: ""shared/user_profile_warning"" %>
++<% end %>
+ <header>
+   <div class='container'>
+     <div id='header-identity'>",perhaps we should encapsulate this logic in a helper method w a test?,"I don't think we need the `current_page?(me_path)` check here, since `current_user` will always be defined."
+266,"@@ -0,0 +1,7 @@
++[ 'options_hash', 'defaults', 'command_line_parser', 'pe_version_scraper', 'parser' ].each do |file|
++  begin
++    require ""beaker/options/#{file}""
++  rescue LoadError
++    require File.expand_path(File.join(File.dirname(__FILE__), 'options', file))
++  end
++end",Now that we're only using this repo as a Gem you shouldn't need to `require` an expanded local file path like below.,Why do we need this?
+267,"@@ -53,7 +53,8 @@ enum Timestamps implements Transform<Long, Integer> {
+     OffsetDateTime timestamp = Instant
+         .ofEpochSecond(timestampMicros / 1_000_000)
+         .atOffset(ZoneOffset.UTC);
+-    return (int) granularity.between(EPOCH, timestamp);
++    Integer year = Long.valueOf(granularity.between(EPOCH, timestamp)).intValue();
++    return year;
+   }
+ 
+   @Override","This isn't necessarily a year. It may be months, days, or hours. Can we return `intValue()` directly instead?",I think this should be `Long.valueOf(granularity).intValue();`
+268,"@@ -351,8 +351,6 @@ func (mtask *managedTask) waitEvent(stopWaiting <-chan struct{}) bool {
+ 		mtask.handleDesiredStatusChange(acsTransition.desiredStatus, acsTransition.seqnum)
+ 		return false
+ 	case dockerChange := <-mtask.dockerMessages:
+-		seelog.Infof(""Managed task [%s]: got container [%s (Runtime ID: %s)] event: [%s]"",
+-			mtask.Arn, dockerChange.container.Name, dockerChange.container.GetRuntimeID(), dockerChange.event.Status.String())
+ 		mtask.handleContainerChange(dockerChange)
+ 		return false
+ 	case resChange := <-mtask.resourceStateChangeEvent:",this is redundant because it gets logged immediately on entering the handleContainerChange function,Why is this removed?
+269,"@@ -126,7 +126,7 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ 	var approvers []string
+ 
+ 	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+-		if v.Event == ""DEPLOYMENT_WAIT_APPROVAL"" {
++		if e := ""EVENT_"" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {
+ 			approvers = v.Slack
+ 		}
+ 	}",`ds.GenericDeploymentConfig.DeploymentNotification` in L128 is nullable.,I don't think we nee
+270,"@@ -42,4 +42,8 @@ public class CliqueMiningTracker {
+   public boolean blockCreatedLocally(final BlockHeader header) {
+     return CliqueHelpers.getProposerOfBlock(header).equals(localAddress);
+   }
++
++  public ProtocolContext getProtocolContext() {
++    return protocolContext;
++  }
+ }",this shouldn't be exposed here - this class isn't a carriage for this - its used internally to determine if/how we can mine.,Why do we need this?
+271,"@@ -265,13 +265,11 @@ public class FirefoxDriver extends RemoteWebDriver
+ 
+   @Override
+   public String installExtension(Path path) {
+-    Require.nonNull(""Path"", path);
+     return extensions.installExtension(path);
+   }
+ 
+   @Override
+   public void uninstallExtension(String extensionId) {
+-    Require.nonNull(""Extension ID"", extensionId);
+     extensions.uninstallExtension(extensionId);
+   }
+ ","It's fine to leave these checks in. It'll make the exception come from `FirefoxDriver`, and that's probably clearer to a user.",Why is this removed?
+272,"@@ -60,8 +60,9 @@ RSpec.configure do |config|
+   # Add modules for helpers
+   config.include ControllerSpecHelper, type: :controller
+   config.include RequestSpecHelper, type: :request
+-  [:feature, :request].each do |type|
++  [:feature, :request, :model].each do |type|
+     config.include IntegrationSpecHelper, type: type
++    config.include EnvironmentSpecHelper, type: type
+   end
+   config.include FeatureSpecHelper, type: :feature
+ ","We don't want to include the `IntegrationSpecHelper` for models...mind moving this line out of the loop to be `config.include EnvironmentSpecHelper, type: :model`?",Style/SymbolArray: Use %i or %I for an array of symbols.
+273,"@@ -25,6 +25,9 @@ func TestWriteDrupalConfig(t *testing.T) {
+ 	err = WriteDrupalConfig(drupalConfig, file.Name())
+ 	assert.NoError(t, err)
+ 
++	os.Chmod(dir, 0755)
++	os.Chmod(file.Name(), 0666)
++
+ 	err = os.RemoveAll(dir)
+ 	assert.NoError(t, err)
+ }",Please check the return on these.,Why is this needed?
+274,"@@ -279,10 +279,14 @@ class Storage {
+       if (uplink == null) {
+         uplink = new Proxy({
+           url: file.url,
++          cache: true,
+           _autogenerated: true,
+         }, self.config);
+       }
+-      let savestream = self.local.add_tarball(name, filename);
++      let savestream = null;
++      if (uplink.config.cache) {
++        savestream = self.local.add_tarball(name, filename);
++      }
+       let on_open = function() {
+         // prevent it from being called twice
+         on_open = function() {};",Do we need `==` for true?,Why is this needed?
+275,"@@ -17,7 +17,7 @@ class BaseEMAHook(Hook):
+         momentum (float): The momentum used for updating ema parameter.
+             Ema's parameter are updated with the formula:
+            `ema_param = (1-momentum) * ema_param + momentum * cur_param`.
+-            Defaults to 0.0002.
++            Defaults to 0.0001.
+         skip_buffers (bool): Whether to skip the model buffers, such as
+             batchnorm running stats (running_mean, running_var), it does not
+             perform the ema operation. Default to False.",Changing the default value may cause BC-breaking. Suggest changing this value in config.,Why did you change this?
+276,"@@ -325,7 +325,7 @@ class SimpleConfig(Logger):
+         slider_pos = max(slider_pos, 0)
+         slider_pos = min(slider_pos, len(FEE_ETA_TARGETS))
+         if slider_pos < len(FEE_ETA_TARGETS):
+-            num_blocks = FEE_ETA_TARGETS[slider_pos]
++            num_blocks = FEE_ETA_TARGETS[int(slider_pos)]
+             fee = self.eta_target_to_fee(num_blocks)
+         else:
+             fee = self.eta_target_to_fee(1)",how does that happen?,Why not `int(slider_pos)`?
+277,"@@ -31,9 +31,9 @@
+ #
+ from __future__ import print_function
+ 
+-import unittest
++import unittest, doctest
+ import os,sys
+-
++from rdkit.six import exec_
+ from rdkit.six.moves import cPickle
+ 
+ from rdkit import rdBase",This is gross/clever. :-),Why did you change this?
+278,"@@ -1,6 +1,6 @@
+ require File.expand_path(File.dirname(__FILE__) + '/test_helper.rb')
+ 
+-class TestZhCnLocale < Test::Unit::TestCase
++class TestZhLocale < Test::Unit::TestCase
+   def setup
+     Faker::Config.locale = 'zh-CN'
+   end",Take a look at the name of this file. Definitely copy and  ,Style/ClassAndModuleChildr
+279,"@@ -163,12 +163,15 @@ func NewVolumeInfo(URL string, volname string, namespace string) (volInfo *Volum
+ 		if resp.StatusCode == 500 {
+ 			fmt.Printf(""Volume: %s not found at namespace: %q\n"", volname, namespace)
+ 			err = util.InternalServerError
++			return
+ 		} else if resp.StatusCode == 503 {
+ 			fmt.Printf(""maya apiservice not reachable at %q\n"", mapiserver.GetURL())
+ 			err = util.ServerUnavailable
++			return
+ 		} else if resp.StatusCode == 404 {
+ 			fmt.Printf(""Volume: %s not found at namespace: %q error: %s\n"", volname, namespace, http.StatusText(resp.StatusCode))
+ 			err = util.PageNotFound
++			return
+ 		}
+ 		fmt.Printf(""Received an error from maya apiservice: statuscode: %d"", resp.StatusCode)
+ 		err = fmt.Errorf(""Received an error from maya apiservice: statuscode: %d"", resp.StatusCode)",Can you check with @mahebbar how to work this error. Should be different from 404.,Shouldn't this be `return 
+280,"@@ -46,7 +46,7 @@ setup(
+         'spark': ['pyspark>=2.4.0'],
+         'mlflow': ['mlflow>=1.0'],
+     },
+-    python_requires='>=3.5,<3.8',
++    python_requires='>=3.5',
+     install_requires=[
+         'pandas>=0.23.2',
+         'pyarrow>=0.10',",Do we still need the upper bound `<3.9`?,This should be `>=3.8`
+281,"@@ -229,7 +229,10 @@ function getPathsToCheck($f_paths): ?array
+             /** @var string */
+             $input_path = $input_paths[$i];
+ 
+-            if (realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm')
++            if (
++                realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalm')
++                || realpath($input_path) === realpath(dirname(__DIR__, 3) . DIRECTORY_SEPARATOR . 'bin' . DIRECTORY_SEPARATOR . 'psalter')
++                || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalm')
+                 || realpath($input_path) === realpath(dirname(__DIR__) . DIRECTORY_SEPARATOR . 'psalter')
+                 || realpath($input_path) === realpath(Phar::running(false))
+             ) {",Does this mean `vendor/bin/psalm` is not a symlink (or whatever equivalent Windows has for symlinks) on Windows?,I don't think this is 
+282,"@@ -1,4 +1,4 @@
+-package aws_test
++package aws
+ 
+ import (
+ 	""fmt""","@lpabon having a separate package name `aws_test` allows to test the package as if the tester was an external package. If the test package name is the same as the package being tested, the test package can also use methods and variables not exposed to the eventual user.",Why did you change thi
+283,"@@ -54,8 +54,6 @@ func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter
+ 	instruments := map[string]data{
+ 		""test-int64-counter"":         {sdkapi.CounterInstrumentKind, number.Int64Kind, 1},
+ 		""test-float64-counter"":       {sdkapi.CounterInstrumentKind, number.Float64Kind, 1},
+-		""test-int64-histogram"":       {sdkapi.HistogramInstrumentKind, number.Int64Kind, 2},
+-		""test-float64-histogram"":     {sdkapi.HistogramInstrumentKind, number.Float64Kind, 2},
+ 		""test-int64-gaugeobserver"":   {sdkapi.GaugeObserverInstrumentKind, number.Int64Kind, 3},
+ 		""test-float64-gaugeobserver"": {sdkapi.GaugeObserverInstrumentKind, number.Float64Kind, 3},
+ 	}","The exporter should still be able to test these histogram instrument kinds, right? Is there another reason to remove these?",Why are these removed?
+284,"@@ -274,6 +274,13 @@ func (eval *BlockEvaluator) Round() basics.Round {
+ 	return eval.block.Round()
+ }
+ 
++// ResetTxnBytes resets the number of bytes tracked by the BlockEvaluator to
++// zero.  This is a specialized operation used by the transaction pool to
++// simulate the effect of putting pending transactions in multiple blocks.
++func (eval *BlockEvaluator) ResetTxnBytes(validateTxnBytes bool) {
++	eval.totalTxBytes = 0
++}
++
+ // Transaction tentatively adds a new transaction as part of this block evaluation.
+ // If the transaction cannot be added to the block without violating some constraints,
+ // an error is returned and the block evaluator state is unchanged.",should this increment eval.Round somehow?,Why do we need this?
+285,"@@ -91,7 +91,7 @@ class Blacklight::Solr::Response < ActiveSupport::HashWithIndifferentAccess
+         value.each { |v| force_to_utf8(v) }
+       when String
+         if value.encoding != Encoding::UTF_8
+-          Rails.logger.warn ""Found a non utf-8 value in Blacklight::Solr::Response. \""#{value}\"" Encoding is #{value.encoding}""
++          Blacklight.logger.warn ""Found a non utf-8 value in Blacklight::Solr::Response. \""#{value}\"" Encoding is #{value.encoding}""
+           value.dup.force_encoding('UTF-8')
+         else
+           value",Although this change looks good. Maybe there are other inconsistent cases too?,Line is too long. [8
+286,"@@ -21,7 +21,7 @@ module ApplicationHelper
+     '/auth/github'
+   end
+ 
+-  def format_resources(resources)
++  def format_markdown(resources)
+     BlueCloth.new(resources).to_html.html_safe
+   end
+ ",This is a way better method name.,Layout/EmptyLinesAro
+287,"@@ -1,7 +1,5 @@
+ class NewLanguageConfirmationsController < ApplicationController
+   def index
+-    redirect_to welcome_to_upcase_path(
+-      confirmation: true, language_selected: params[:language],
+-    ), notice: ""Thanks for signing up. We will be in touch!""
++    redirect_to root_path, notice: t(""marketing.show.language_flash"")
+   end
+ end",Prefer single-quoted strings when you don't need string interpolation or special symbols.,I think this should 
+288,"@@ -1,3 +1,5 @@
++options = Array.isArray(options) ? options : [];
++
+ var invalid = [];
+ 
+ var attr, attrName, allowed,","I was wondering if this should allow per role specification, instead of (or in addition to) a generic ""allowed everywhere"". So you could do: `{ separator: ['aria-valuenow', 'aria-valuemin', 'aria-valuemax'] }`. You could still allow the array, and you could add a wildcard option for the ""generic"" case you've got now: `{ '*': ['always-allowed'] }`.",I don't think we need this line.
+289,"@@ -942,7 +942,8 @@ SQLVarChar::SQLVarChar(Lng32 maxLen,
+ 	       FALSE, allowSQLnull, isUpShifted, isCaseInsensitive,
+ 	       TRUE, cs, co, ce,
+ 	       encoding, vcIndLen),
+-      clientDataType_(collHeap())  // Get heap from NABasicObject. Can't allocate on stack.
++      clientDataType_(collHeap()),  // Get heap from NABasicObject. Can't allocate on stack.
++      wasHiveString_(FALSE)
+ {}
+ #pragma warn(1506)  // warning elimination
+ ",I'm confused by the name. The string was a Hive string but it isn't any longer? Why should we care? (I imagine I'll find the answer later... there is some different semantic that we want downstream...),Why do we need this?
+290,"@@ -31,12 +31,7 @@ import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.grid.sessionmap.local.LocalSessionMap;
+ import org.openqa.selenium.netty.server.NettyServer;
+ import org.openqa.selenium.remote.SessionId;
+-import org.openqa.selenium.remote.http.HttpClient;
+-import org.openqa.selenium.remote.http.HttpHandler;
+-import org.openqa.selenium.remote.http.HttpRequest;
+-import org.openqa.selenium.remote.http.HttpResponse;
+-import org.openqa.selenium.remote.http.TextMessage;
+-import org.openqa.selenium.remote.http.WebSocket;
++import org.openqa.selenium.remote.http.*;
+ import org.openqa.selenium.remote.tracing.DefaultTestTracer;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ ",Could you please leave the explicit imports?,Don't use wildcard imports.
+291,"@@ -23,7 +23,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/hash""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+-	""github.com/iotexproject/iotex-core/proto""
++	iproto ""github.com/iotexproject/iotex-core/proto""
+ 	""github.com/iotexproject/iotex-core/state/factory""
+ )
+ ",Why need alias?,I don't think this change is nec
+292,"@@ -148,6 +148,10 @@ func (c testTLFJournalConfig) teamMembershipChecker() kbfsmd.TeamMembershipCheck
+ 	return nil
+ }
+ 
++func (c testTLFJournalConfig) tlfIDGetter() tlfIDGetter {
++	return nil
++}
++
+ func (c testTLFJournalConfig) diskLimitTimeout() time.Duration {
+ 	return c.dlTimeout
+ }","Shouldn't this be a `libfs.nullIDGetter` (exported, of course)?",I don't think this is needed.
+293,"@@ -156,6 +156,9 @@ const (
+ 	tealsignTooManyArg    = ""--set-lsig-arg-idx too large, maximum of %d arguments""
+ 	tealsignInfoWroteSig  = ""Wrote signature for %s to LSig.Args[%d]""
+ 
++	tealLogicSigSize = ""%s: logicsig program size too large: %d > %d""
++	tealAppSize      = ""%s: app program size too large: %d > %d""
++
+ 	// Wallet
+ 	infoRecoveryPrompt           = ""Please type your recovery mnemonic below, and hit return when you are done: ""
+ 	infoChoosePasswordPrompt     = ""Please choose a password for wallet '%s': """,I dislike the messages.go pattern; the strings are only used once and make more sense in context. The other two added reportErrorf() calls in clerk.go have inline strings.,`logicsig` -> `logicsig`
+294,"@@ -118,9 +118,6 @@ Status FetchVerticesExecutor::prepareTags() {
+             if (!tagIdStatus.ok()) {
+                 return tagIdStatus.status();
+             }
+-            auto tagId = tagIdStatus.value();
+-            tagNames_.push_back(tagName);
+-            tagIds_.push_back(tagId);
+             auto result = tagNameSet_.emplace(tagName);
+             if (!result.second) {
+                 return Status::Error(folly::sformat(""tag({}) was dup"", tagName));",Seems we don't need it anymore.,Why is this removed?
+295,"@@ -54,7 +54,7 @@ class Guidance < ActiveRecord::Base
+   validates :published, inclusion: { message: INCLUSION_MESSAGE,
+                                      in: BOOLEAN_VALUES}
+ 
+-  validates :themes, presence: { message: PRESENCE_MESSAGE }
++  validates :themes, presence: { message: PRESENCE_MESSAGE }, if: :published?
+ 
+   # Retrieves every guidance associated to an org
+   scope :by_org, -> (org) {",This might cause problems with the weird way we publish Guidance and Groups in the UI. We will have to make sure that UAT is thorough.,I don't think we need the `if
+296,"@@ -75,7 +75,7 @@ func NewRawExporter(config Config) (*Exporter, error) {
+ // 	defer pipeline.Stop()
+ // 	... Done
+ func InstallNewPipeline(config Config) (*push.Controller, error) {
+-	controller, err := NewExportPipeline(config)
++	controller, err := NewExportPipeline(config, time.Hour)
+ 	if err != nil {
+ 		return controller, err
+ 	}","this default needs to be on order 1 minute, I'm not sure why we defaulted to 1 hour below...",Why do we need this?
+297,"@@ -92,6 +92,15 @@ func (ACMEIssuer) CaddyModule() caddy.ModuleInfo {
+ func (iss *ACMEIssuer) Provision(ctx caddy.Context) error {
+ 	iss.logger = ctx.Logger(iss)
+ 
++	// expand email address, if non-empty
++	if iss.Email != """" {
++		email, err := caddy.NewReplacer().ReplaceOrErr(iss.Email, true, true)
++		if err != nil {
++			return fmt.Errorf(""expanding email address '%s': %v"", iss.Email, err)
++		}
++		iss.Email = email
++	}
++
+ 	// DNS providers
+ 	if iss.Challenges != nil && iss.Challenges.DNS != nil && iss.Challenges.DNS.ProviderRaw != nil {
+ 		val, err := ctx.LoadModule(iss.Challenges.DNS, ""ProviderRaw"")","I figure to make `{env.*}` work, right? I can't think of any other placeholder that makes sense here",Why do we need to do
+298,"@@ -29,7 +29,9 @@ TestEnv::~TestEnv() {
+ void TestEnv::SetUp() {
+     FLAGS_load_data_interval_secs = 1;
+     // Create metaServer
+-    metaServer_ = nebula::meta::TestUtils::mockMetaServer(0, metaRootPath_.path());
++    metaServer_ = nebula::meta::TestUtils::mockMetaServer(
++                                                    network::NetworkUtils::getAvailablePort(),
++                                                    metaRootPath_.path());
+     FLAGS_meta_server_addrs = folly::stringPrintf(""127.0.0.1:%d"", metaServerPort());
+ 
+     // Create storageServer",Why change the port from 0 to getAvailablePort()?,Why is this change n
+299,"@@ -691,9 +691,9 @@ class TestSeleniumScriptGeneration(SeleniumTestCase):
+             content = fds.read()
+ 
+         target_lines = [
+-            ""var_loc_keys=self.loc_mng.get_locator([{'name':'btn1',}])self.driver.find_element""
++            ""var_loc_keys=self.loc_mng.get_locator([{'name':'btn1',}],30.0)self.driver.find_element""
+             ""(var_loc_keys[0],var_loc_keys[1]).click()"",
+-            ""var_loc_keys=self.loc_mng.get_locator([{'id':'Id_123',}])self.driver.find_element""
++            ""var_loc_keys=self.loc_mng.get_locator([{'id':'Id_123',}],30.0)self.driver.find_element""
+             ""(var_loc_keys[0],var_loc_keys[1]).clear()"",
+             ""self.driver.find_element(var_loc_keys[0],var_loc_keys[1]).send_keys('London')""
+         ]","For me would be great don't repeat timeout sending in every get_locator call. Looks like it should be sent into LocatorsManager init. And possibly it should me non mandatory, something like that: `def __init__ (self, locators, timeout=60):`",missing whitespace a
+300,"@@ -30,8 +30,9 @@ func NewGlobalOpts() *GlobalOpts {
+ 	bindProjectName()
+ 
+ 	return &GlobalOpts{
+-		projectName: viper.GetString(projectFlag),
+-		prompt:      prompt.New(),
++		// Leave the projectName as empty in case it's overwritten by a global flag.
++		// See https://github.com/aws/amazon-ecs-cli-v2/issues/570#issuecomment-569133741
++		prompt: prompt.New(),
+ 	}
+ }
+ ","I feel like since now we don't initiate the `opts.projectName` with `opts.ProjectName()`, which means `opts.projectName` and `opts.ProjectName()` they don't necessarily equal to each other, we need to also substitute all usage of `opts.ProjectName()` within `Ask()`, `Validate()`, and `Execute()` to `opts.projectName`. Otherwise if `-p` is set, `opts.ProjectName()` will get expired.",Why do we need this change?
+301,"@@ -531,7 +531,7 @@ namespace Nethermind.Core.Extensions
+         [DebuggerStepThrough]
+         public static string ByteArrayToHexViaLookup32Safe(byte[] bytes, bool withZeroX)
+         {
+-            if (bytes.Length == 0)
++            if (bytes?.Length == 0 || bytes == null)
+             {
+                 return withZeroX ? ""0x"" : """";
+             }",why do we thinkg that an empty string is ok to return from this method? I think the null should never be passed in here in the first place,Why is this null check need
+302,"@@ -142,15 +142,12 @@ axe.utils.getNodeFromTree = function(vNode, node) {
+ 		return vNode;
+ 	}
+ 	vNode.children.forEach(candidate => {
+-		var retVal;
+-
+-		if (candidate.actualNode === node) {
++		if (found) {
++			return;
++		} else if (candidate.actualNode === node) {
+ 			found = candidate;
+ 		} else {
+-			retVal = axe.utils.getNodeFromTree(candidate, node);
+-			if (retVal) {
+-				found = retVal;
+-			}
++			found = axe.utils.getNodeFromTree(candidate, node);
+ 		}
+ 	});
+ 	return found;",nit: can remove this `else` since we return from the condition above.,Why did you remove this?
+303,"@@ -39,11 +39,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             _flushCompleted = OnFlushCompleted;
+         }
+ 
+-        public void Write(ArraySegment<byte> buffer, bool chunk = false)
+-        {
+-            WriteAsync(buffer, default(CancellationToken), chunk).GetAwaiter().GetResult();
+-        }
+-
+         public Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken))
+         {
+             if (cancellationToken.IsCancellationRequested)",You missed `Write<T>(...)`! I'm kidding ofc.,Why is this being removed?
+304,"@@ -5,7 +5,7 @@ class SubscriptionUpcomingInvoiceUpdater
+ 
+   def process
+     @subscriptions.each do |subscription|
+-      if subscription.stripe_customer_id
++      if subscription.stripe_customer_id.present?
+         upcoming_invoice = upcoming_invoice_for(subscription.stripe_customer_id)
+         update_next_payment_information(subscription, upcoming_invoice)
+       end",Was there a customer who had this set to an empty string?,Use next to skip iteration.
+305,"@@ -13,6 +13,14 @@ module Ncr
+       approver_email_address(final_approver)
+     end
+ 
++    def status_aware_approver_email_address
++      if proposal.approved?
++        final_approver_email_address
++      else
++        current_approver_email_address
++      end
++    end
++
+     private
+ 
+     def approver_email_address(approver)","I know we have the `reporter` spec below, but what about a unit test for this to explain reasoning behind logic? If I were going to update this decorator, I would assume it wasn't covered by tests because there is no unit test.",Why do we need this method?
+306,"@@ -34,4 +34,6 @@ public interface RestClientRequest {
+   void addForm(String name, Object value);
+ 
+   Buffer getBodyBuffer() throws Exception;
++
++  void attach(String name, String filename);
+ }","it's better to be : void attach(String name, Part part);",Why do we need this method?
+307,"@@ -77,7 +77,8 @@ public abstract class BasePageIterator {
+   protected abstract void initDefinitionLevelsReader(DataPageV1 dataPageV1, ColumnDescriptor descriptor,
+                                                      ByteBufferInputStream in, int count) throws IOException;
+ 
+-  protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2, ColumnDescriptor descriptor);
++  protected abstract void initDefinitionLevelsReader(DataPageV2 dataPageV2, ColumnDescriptor descriptor)
++          throws IOException;
+ 
+   public int currentPageCount() {
+     return triplesCount;","I didn't see where the IOException can get thrown, is this just to match the V1 reader?",Why is this change needed?
+308,"@@ -418,7 +418,7 @@ unsigned int compute2DCoordsMimicDistMat(
+     RDKit::ROMol &mol, const DOUBLE_SMART_PTR *dmat, bool canonOrient,
+     bool clearConfs, double weightDistMat, unsigned int nFlipsPerSample,
+     unsigned int nSamples, int sampleSeed, bool permuteDeg4Nodes,
+-    bool forceRDKit) {
++    bool /* forceRDKit */) {
+   // storage for pieces of a molecule/s that are embedded in 2D
+   std::list<EmbeddedFrag> efrags;
+   computeInitialCoords(mol, nullptr, efrags);",We normally suppress this warning with `RDUSED_PARAM(forceRDKit)`,Why did you remove the forceRDKit parameter?
+309,"@@ -473,12 +473,11 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
+ 		return nullptr;
+ 	}
+ 
+-	for (const auto& it : players) {
+-		if (guid == it.second->getGUID()) {
+-			return it.second;
+-		}
++	auto it = mappedPlayerGuids.find(guid);
++	if (it == mappedPlayerGuids.end()) {
++		return nullptr;
+ 	}
+-	return nullptr;
++	return it->second;
+ }
+ 
+ ReturnValue Game::getPlayerByNameWildcard(const std::string& s, Player*& player)","What if `Game::getPlayerByNameWildcard` had not been called before. It would not find a player, wouldn't it?",I'm not sure if this is the best way to do t
+310,"@@ -129,7 +129,7 @@ public class ApplicationsSidebar extends Sidebar {
+         this.testingCheck = new SidebarCheckBox(tr(""Testing""));
+         this.testingCheck.selectedProperty().bindBidirectional(filter.containTestingApplicationsProperty());
+ 
+-        this.requiresPatchCheck = new SidebarCheckBox(tr(""Requires patch""));
++        this.requiresPatchCheck = new SidebarCheckBox(tr(""Patch Required""));
+         this.requiresPatchCheck.selectedProperty().bindBidirectional(filter.containRequiresPatchApplicationsProperty());
+ 
+         this.commercialCheck = new SidebarCheckBox(tr(""Commercial""));","Why upper case ""R""?","""Patch Required"" -> ""Patch Required"""
+311,"@@ -107,3 +107,19 @@ func relativeDockerfilePath(ws copilotDirGetter, dockerfilePath string) (string,
+ 	}
+ 	return relDfPath, nil
+ }
++
++// dfBuildRequired returns if the container image should be built from local Dockerfile.
++func dfBuildRequired(svc interface{}) (bool, error) {
++	type manifest interface {
++		BuildRequired() (bool, error)
++	}
++	mf, ok := svc.(manifest)
++	if !ok {
++		return false, fmt.Errorf(""service does not have required methods BuildRequired()"")
++	}
++	required, err := mf.BuildRequired()
++	if err != nil {
++		return false, fmt.Errorf(""check if service requires building from local Dockerfile: %w"", err)
++	}
++	return required, nil
++}","Does this need to return an error or could it return `false, nil`?",I don't think this is the right error messag
+312,"@@ -94,7 +94,7 @@ public abstract class Analyzer implements Closeable {
+    * Create a new Analyzer, reusing the same set of components per-thread
+    * across calls to {@link #tokenStream(String, Reader)}. 
+    */
+-  public Analyzer() {
++  protected Analyzer() {
+     this(GLOBAL_REUSE_STRATEGY);
+   }
+ ",Can you not change those scopes in public API classes? This applies here and in other places -- protected changed to package-scope for source is not really an API-compatible change.,Why is this needed?
+313,"@@ -85,7 +85,7 @@ class TranslationsController extends BaseAdminController
+                 'item_to_translate'             => $item_to_translate,
+                 'item_name'                     => $item_name,
+                 'module_part'                   => $module_part,
+-                'view_missing_traductions_only' => $this->getRequest()->get('view_missing_traductions_only', 1),
++                'view_missing_traductions_only' => $this->getRequest()->get('view_missing_traductions_only'),
+                 'max_input_vars_warning'        => false,
+         );
+ ","this parameter is only used in POST, please use `getRequest()->request->get('...');` Thanks",Why did you remove 
+314,"@@ -29,8 +29,8 @@ export default function(config: Config, auth: IAuth, storage: IStorageHandler) {
+   // this might be too harsh, so ask if it causes trouble
+   // $FlowFixMe
+   app.param('package', validatePackage);
++  app.param('filename', validatePackage);
+   // $FlowFixMe
+-  app.param('filename', validateName);
+   app.param('tag', validateName);
+   app.param('version', validateName);
+   app.param('revision', validateName);",Problem number 1: Scoped packages would have a `/` character here. Changing this to `validatePackage` resolves the 403.,Why did you change 
+315,"@@ -639,7 +639,11 @@ class LabelledData(param.Parameterized):
+             for k, v in self.items():
+                 new_val = v.map(map_fn, specs, clone)
+                 if new_val is not None:
+-                    deep_mapped[k] = new_val
++                    # Ensure key validation doesn't cause errors
++                    try:
++                        deep_mapped[k] = new_val
++                    except KeyError:
++                        pass
+             if applies: deep_mapped = map_fn(deep_mapped)
+             return deep_mapped
+         else:",I don't quite get why there would be key errors: ``deep_mapped`` is a clone of ``self`` and ``k`` comes from ``self.items()`` so why would the key ever be rejected?,I don't think this 
+316,"@@ -427,6 +427,15 @@ func (te *transactorEndpoint) Withdraw(c *gin.Context) {
+ 	}
+ 
+ 	chainID := config.GetInt64(config.FlagChainID)
++	if req.ChainID != 0 {
++		if _, ok := registry.Chains()[req.ChainID]; !ok {
++			utils.SendError(resp, errors.New(""Unsupported chain""), http.StatusBadRequest)
++			return
++		}
++
++		chainID = req.ChainID
++	}
++
+ 	err = te.promiseSettler.Withdraw(chainID, identity.FromAddress(req.ProviderID), common.HexToAddress(req.HermesID), common.HexToAddress(req.Beneficiary))
+ 	if err != nil {
+ 		utils.SendError(resp, err, http.StatusInternalServerError)","this chain ID determines only from which chain to withdraw, therefore your changes do not accomplish what you want them to accomplish. You'll need changes to `func (aps *hermesPromiseSettler) Withdraw(chainID int64, providerID identity.Identity, hermesID, beneficiary common.Address) error`. The method probably has to include two chain ids: to and from. Currently, the method internally uses: `aps.config.L1ChainID` -> the chain to withdraw to `chainID` -> the chainID that was passed as the chain that the withdrawal is originating from.",Shouldn't this be an error?
+317,"@@ -57,7 +57,11 @@ func (TraceContext) Inject(ctx context.Context, supplier propagation.HTTPSupplie
+ }
+ 
+ func (tc TraceContext) Extract(ctx context.Context, supplier propagation.HTTPSupplier) context.Context {
+-	return ContextWithRemoteSpanContext(ctx, tc.extract(supplier))
++	sc := tc.extract(supplier)
++	if !sc.IsValid() {
++		return ctx
++	}
++	return ContextWithRemoteSpanContext(ctx, sc)
+ }
+ 
+ func (TraceContext) extract(supplier propagation.HTTPSupplier) core.SpanContext {","If instead we had `TraceContext.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?",Why do we need this?
+318,"@@ -22,8 +22,8 @@
+ #include ""depotchest.h""
+ #include ""tools.h""
+ 
+-DepotChest::DepotChest(uint16_t type) :
+-	Container(type), maxDepotItems(2000) {}
++DepotChest::DepotChest(uint16_t type, bool paginated /*= true*/) :
++	Container(type, items[type].maxItems, true, paginated), maxDepotItems(2000) {}
+ 
+ ReturnValue DepotChest::queryAdd(int32_t index, const Thing& thing, uint32_t count,
+ 		uint32_t flags, Creature* actor/* = nullptr*/) const",here shouldn't we use `depotFreeLimit`?,`paginated` should be `fals
+319,"@@ -0,0 +1,3 @@
++# A secret token used to encrypt user_id's in the Bookmarks#export callback URL
++# functionality, for example in Refworks export of Bookmarks. 
++Rails.application.config.blacklight_export_secret_token = '<%= SecureRandom.hex(64) %>'",Could we use the Rails application's secret token instead? Do we actually need our own here?,Layout/TrailingBlankLines: 
+320,"@@ -80,6 +80,10 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
+ 
+         self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.b, as_index=False))
+ 
++        self.assertRaises(ValueError, lambda: kdf.groupby('a', axis=1))
++        self.assertRaises(ValueError, lambda: kdf.groupby('a', 'b'))
++        self.assertRaises(TypeError, lambda: kdf.a.groupby(kdf.a, kdf.b))
++
+         # we can't use column name/names as a parameter `by` for `SeriesGroupBy`.
+         self.assertRaises(KeyError, lambda: kdf.a.groupby(by='a'))
+         self.assertRaises(KeyError, lambda: kdf.a.groupby(by=['a', 'b']))",so should be fixed here also,Why is this a TypeError?
+321,"@@ -6478,8 +6478,13 @@ dr_get_mcontext_priv(dcontext_t *dcontext, dr_mcontext_t *dmc, priv_mcontext_t *
+          * when most old clients have been converted, remove this (we'll
+          * still return false)
+          */
+-        CLIENT_ASSERT(dmc->size == sizeof(dr_mcontext_t),
+-                      ""dr_mcontext_t.size field not set properly"");
++        CLIENT_ASSERT(
++            dmc->size == sizeof(dr_mcontext_t) ||
++                /* Opmask storage has been added for AVX-512 (xref i#1312).
++                 * An older client's mcontext may be filled in w/o the new structure.
++                 */
++                dmc->size == sizeof(dr_mcontext_t) - sizeof(dr_opmask_t),
++            ""dr_mcontext_t.size field not set properly"");
+         CLIENT_ASSERT(dmc->flags != 0 && (dmc->flags & ~(DR_MC_ALL)) == 0,
+                       ""dr_mcontext_t.flags field not set properly"");
+     } else",I would just remove this assert as it's going to get un-maintainable with a long list of valid sizes. Ditto below.,I don't think this is th
+322,"@@ -28,6 +28,7 @@ func DefaultConfig() Config {
+ 		ReservedPorts:               []uint16{SSHPort, DockerReservedPort, DockerReservedSSLPort, AgentIntrospectionPort, AgentCredentialsPort},
+ 		ReservedPortsUDP:            []uint16{},
+ 		DataDir:                     ""/data/"",
++		HostDataDir:                 ""/var/lib/ecs/"",
+ 		DisableMetrics:              false,
+ 		ReservedMemory:              0,
+ 		AvailableLoggingDrivers:     []dockerclient.LoggingDriver{dockerclient.JSONFileDriver},",`HostDataDir` is misleading. Can we rename it to something more relevant ? The constant should also be moved up and reused as necessary.,Why do we need this?
+323,"@@ -37,6 +37,9 @@ const (
+ 	defaultMTUGRE             = 1462
+ 	defaultMTUSTT             = 1500
+ 	defaultMTU                = 1500
++	// IPsec ESP can add a maximum of 38 bytes to the packet including the ESP
++	// header and trailer.
++	ipsecESPOverhead = 38
+ )
+ 
+ type Options struct {",I still feel like we are double-counting the outer IP header here (once in `defaultMTUGRE` and once in `ipsecESPOverhead`) but I'm not that familiar with IPsec.,I think this should be `
+324,"@@ -14,11 +14,15 @@
+ // limitations under the License.
+ // </copyright>
+ 
+-#nullable enable
++using System;
++using System.Collections.Generic;
++using System.Diagnostics.Metrics;
+ 
+ namespace OpenTelemetry.Metrics
+ {
+     public abstract class MeasurementProcessor : BaseProcessor<MeasurementItem>
+     {
++        public abstract void OnEnd<T>(MeasurementItem measurementItem, ref DateTimeOffset dt, ref T value, ref ReadOnlySpan<KeyValuePair<string, object>> tags)
++            where T : struct;
+     }
+ }","Not sure what benefit we gain by extending BaseProcessor here, as this seems to be defining a new OnEnd method. Could we modify MeasurementItem to have all the things, and then MeasurementProcessor can be simply extending BaseProcessor<MeasurementItem> (not blocking. just noting some observations in the PR :) )",Why did you remove nullable enable?
+325,"@@ -3,6 +3,13 @@ package cmd
+ import (
+ 	""bufio""
+ 	""fmt""
++	""io/ioutil""
++	""os""
++	""path""
++	""path/filepath""
++	""runtime""
++	""strings""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.,nit: remove empty line
+326,"@@ -51,7 +51,8 @@ type Options struct {
+ 	DefaultSamplingPolicy trace.Sampler
+ }
+ 
+-// New creates a new server. New(nil) is the same as new(Server).
++// New creates a new server. New(nil) is the same as new(Server). Note: A
++// configured Requestlogger will not log HealthChecks.
+ func New(opts *Options) *Server {
+ 	srv := new(Server)
+ 	if opts != nil {",This seems like a more appropriate message under `ListenAndServe`. WDYT?,I don't think we need to mention He
+327,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?,Why was this removed?
+328,"@@ -360,7 +360,16 @@ class AdminController extends Controller
+         }
+ 
+         $searchableFields = $this->entity['search']['fields'];
+-        $paginator = $this->findBy($this->entity['class'], $this->request->query->get('query'), $searchableFields, $this->request->query->get('page', 1), $this->config['list']['max_results'], $this->request->query->get('sortField'), $this->request->query->get('sortDirection'), $this->entity['search']['dql_filter']);
++        $paginator = $this->findBy(
++            $this->entity['class'],
++            $this->request->query->get('query'),
++            $searchableFields,
++            $this->request->query->get('page', 1),
++            $this->config['list']['max_results'],
++            isset($this->entity['search']['sort']['field']) ? $this->entity['search']['sort']['field'] : $this->request->query->get('sortField'),
++            isset($this->entity['search']['sort']['direction']) ? $this->entity['search']['sort']['direction'] : $this->request->query->get('sortDirection'),
++            $this->entity['search']['dql_filter']
++        );
+         $fields = $this->entity['list']['fields'];
+ 
+         $this->dispatch(EasyAdminEvents::POST_SEARCH, array(",We should start thinking of an object that encapsulates this information :) we might need more arguments in the future.,`$this->entity['search']['sort']['field'] ?? $this->request->query->get('sortField')`
+329,"@@ -4652,10 +4652,12 @@ TEST_F(VkLayerTest, RenderPassBarrierConflicts) {
+     img_barrier.subresourceRange.levelCount = 1;
+     // Mis-match src stage mask
+     m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-srcStageMask-01173"");
++    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-dstStageMask-01174"");
+     vkCmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_HOST_BIT, VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT,
+                          VK_DEPENDENCY_BY_REGION_BIT, 0, nullptr, 0, nullptr, 1, &img_barrier);
+     m_errorMonitor->VerifyFound();
+     // Now mis-match dst stage mask
++    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-srcStageMask-01173"");
+     m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdPipelineBarrier-dstStageMask-01174"");
+     vkCmdPipelineBarrier(m_commandBuffer->handle(), VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT, VK_PIPELINE_STAGE_HOST_BIT,
+                          VK_DEPENDENCY_BY_REGION_BIT, 0, nullptr, 0, nullptr, 1, &img_barrier);","Given that we are (conceptually) searching across multiple self-dependencies, all we can say is that we didn't have a self dependency in which *both* source and dest masks were correct. Since the spec doesn't imagine this case, the valid usage statement assume we can differentiate only wrong source from only wrong dest within a *single* self-dependency -- which we can't across multiple (at least not meaningfully)... so we always return both the source/dest VUID's if we can't find a self-dependency in with *both* are correct.",Why did you add these two lines?
+330,"@@ -52,11 +52,11 @@ public class EthMiningTest {
+   public void shouldReturnTrueWhenMiningCoordinatorExistsAndRunning() {
+     final JsonRpcRequest request = requestWithParams();
+     final JsonRpcResponse expectedResponse = new JsonRpcSuccessResponse(request.getId(), true);
+-    when(miningCoordinator.isRunning()).thenReturn(true);
++    when(miningCoordinator.isMining()).thenReturn(true);
+ 
+     final JsonRpcResponse actualResponse = method.response(request);
+     assertThat(actualResponse).isEqualToComparingFieldByField(expectedResponse);
+-    verify(miningCoordinator).isRunning();
++    verify(miningCoordinator).isMining();
+     verifyNoMoreInteractions(miningCoordinator);
+   }
+ ",rename? MiningCoordinator always exists,Why do we need this change?
+331,"@@ -8,7 +8,8 @@
+ var ip = {},
+     net = require('net'),
+     extIP = require('external-ip'),
+-    plugins = require('../../../plugins/pluginManager.js');
++    plugins = require('../../../plugins/pluginManager.js'),
++    offlineMode = plugins.getConfig(""api"").offline_mode;
+ 
+ /**
+  * Function to get the hostname/ip address/url to access dashboard","Here would be the same case you don't need to call `loadConfigs`, but you would need to reread configs using `getConfig` on each getHost function call, not once per file.",nit: space after `=`
+332,"@@ -486,6 +486,8 @@ func (d *Dir) Cleanup(ctx context.Context, fi *dokan.FileInfo) {
+ 	defer func() { d.folder.reportErr(ctx, libkbfs.WriteMode, err) }()
+ 
+ 	if fi != nil && fi.IsDeleteOnClose() && d.parent != nil {
++		d.folder.fs.renameAndDeletionLock.Lock()
++		defer d.folder.fs.renameAndDeletionLock.Unlock()
+ 		d.folder.fs.log.CDebugf(ctx, ""Removing (Delete) dir in cleanup %s"", d.name)
+ 
+ 		err = d.folder.fs.config.KBFSOps().RemoveDir(ctx, d.parent, d.name)","Unlocking with defer means that this lock is still held curing the call to forgetNode(), below, which I see attempts to acquire `f.mu`, which looks dangerous to me.",Why do we need this lock?
+333,"@@ -56,7 +56,7 @@ func Test_Mine(t *testing.T) {
+ 	baseBlock := &block.Block{Height: 2, StateRoot: stateRoot, Tickets: []block.Ticket{{VRFProof: []byte{0}}}}
+ 	tipSet := th.RequireNewTipSet(t, baseBlock)
+ 
+-	st, pool, addrs, cst, bs := sharedSetup(t, mockSignerVal)
++	st, pool, addrs, _, bs := sharedSetup(t, mockSignerVal)
+ 	getStateTree := func(c context.Context, ts block.TipSet) (state.Tree, error) {
+ 		return st, nil
+ 	}",Does anyone still use the cst out of this method? If not consider deleting,ineffectual assignment to
+334,"@@ -9,6 +9,7 @@ get(
+     ""/getting-started-with-ios-development?utm_source=podcast""
+   )
+ )
++get ""/videos/vim-for-rails-developers"" => redirect(""https://www.youtube.com/watch?v=9J2OjH8Ao_A"")
+ get ""/humans-present/oss"" => redirect( ""https://www.youtube.com/watch?v=VMBhumlUP-A"")
+ get ""/ios-on-rails"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+ get ""/ios-on-rails-beta"" => redirect(""https://gumroad.com/l/ios-on-rails"")",Line is too long. [97/80],"get ""/videos/vim-for-rail"
+335,"@@ -1,12 +1,14 @@
+ """""" Testing for data_transfer.py """"""
+ 
+ ### Python imports
++from io import BytesIO
+ import pathlib
+ 
+ from unittest import mock
+ 
+ ### Third-party imports
+ from botocore.stub import ANY
++from botocore.exceptions import ReadTimeoutError
+ import pandas as pd
+ import pytest
+ ",This seems unused.,I don't think we need thi
+336,"@@ -184,8 +184,8 @@ func GetOSInterface() types.OSTypeInstaller {
+ 	case CentOSType:
+ 		return &CentOS{}
+ 	default:
++		panic(""unsupport os-release"")
+ 	}
+-	return nil
+ }
+ 
+ //IsKubeEdgeController identifies if the node is having edge controller and k8s api-server already running.","@luguanglong , Thanks for the fix, can you re-phrase it to sound better something like ""This OS version is currently un-supported by keadm""",I don't think we should panic here.
+337,"@@ -53,6 +53,10 @@ from rdkit.Chem.Draw import rdMolDraw2D
+ from rdkit.Chem import rdDepictor
+ from rdkit.Chem import rdMolDescriptors as rdMD
+ 
++def _CleanFpInfoAttr_(mol):
++  if hasattr(mol, '_fpInfo'):
++    delattr(mol, '_fpInfo')
++
+ 
+ def GetAtomicWeightsForFingerprint(refMol, probeMol, fpFunction, metric=DataStructs.DiceSimilarity):
+   """"""",should probably be called `_DeleteFpInfoAttr` because it removes it. Cleaning gives the impression it is still there. I would also move this to the end of the function `GetAtomicWeightsForFingerprint`.,Why is this needed?
+338,"@@ -7101,6 +7101,13 @@ bool CoreChecks::PreCallValidateCmdBindDescriptorSets(VkCommandBuffer commandBuf
+                          ""(%zu) when pipeline layout was created"",
+                          firstSet, setCount, pipeline_layout->set_layouts.size());
+     }
++
++    static const std::map<VkPipelineBindPoint, std::string> bindpoint_errors = {
++        std::make_pair(VK_PIPELINE_BIND_POINT_GRAPHICS, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361""),
++        std::make_pair(VK_PIPELINE_BIND_POINT_COMPUTE, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361""),
++        std::make_pair(VK_PIPELINE_BIND_POINT_RAY_TRACING_NV, ""VUID-vkCmdBindDescriptorSets-pipelineBindPoint-00361"")};
++    skip |= ValidatePipelineBindPoint(cb_state, pipelineBindPoint, ""vkCmdBindPipeline()"", bindpoint_errors);
++
+     return skip;
+ }
+ ","nit, can we use `VK_PIPELINE_BIND_POINT_RAY_TRACING_KHR` here (granted it isn't else where, maybe worth fixing here or in separate PR)",nit: I think it would be better to 
+339,"@@ -23,6 +23,6 @@ class Api::V1::ExercisesController < ApiController
+   end
+ 
+   def exercise_parameters
+-    params.require(:exercise).permit(:edit_url, :summary, :title, :url)
++    params.require(:exercise).permit(:edit_url, :summary, :name, :url)
+   end
+ end",This will need to be updated in the upcase-exercises repo as well.,Why is this change needed?
+340,"@@ -21,7 +21,7 @@ class Trail < ActiveRecord::Base
+   def steps_remaining_for(user)
+     ExerciseWithProgressQuery.
+       new(user: user, exercises: exercises).
+-      count { |exercise| exercise.state != Status::REVIEWED }
++      count { |exercise| exercise.state != Status::COMPLETE }
+   end
+ 
+   def self.most_recent_published",Think it's worth extracting this to `Exercise#complete?`?,Why did you change this?
+341,"@@ -87,14 +87,6 @@ class Currency
+         return $this->exchangeRate;
+     }
+ 
+-    /**
+-     * @return string
+-     */
+-    public function getReversedExchangeRate()
+-    {
+-        return 1 / $this->exchangeRate;
+-    }
+-
+     /**
+      * @param string $exchangeRate
+      */",This is still a potentially useful public method - should we remove such methods?,Why did you remove this?
+342,"@@ -40,15 +40,9 @@ public abstract class ApiDefaultsConfig {
+   /** The name of the license of the client library. */
+   public abstract String licenseName();
+ 
+-  protected abstract Map<TargetLanguage, ReleaseLevel> releaseLevel();
+-
+   /** The development status of the client library. Configured per language. */
+-  public ReleaseLevel releaseLevel(TargetLanguage language) {
+-    ReleaseLevel level = releaseLevel().get(language);
+-    if (level == null) {
+-      level = ReleaseLevel.UNSET_RELEASE_LEVEL;
+-    }
+-    return level;
++  public ReleaseLevel releaseLevel() {
++    return ReleaseLevel.ALPHA;
+   }
+ 
+   protected abstract Map<TargetLanguage, VersionBound> generatedNonGAPackageVersionBound();","I don't understand this change, what is happening here?",This is a breaking chang
+343,"@@ -944,7 +944,8 @@ class ExcelCellTextInfo(NVDAObjectTextInfo):
+ 
+ 	def _getFormatFieldAndOffsets(self,offset,formatConfig,calculateOffsets=True):
+ 		formatField=textInfos.FormatField()
+-		if (self.obj.excelCellObject.Application.Version > ""12.0""):
++		version=int(self.obj.excelCellObject.Application.Version.split('.')[0])
++		if version>12:
+ 			cellObj=self.obj.excelCellObject.DisplayFormat
+ 		else:
+ 			cellObj=self.obj.excelCellObject",I think its worth stating this is `versionMajor`,missing whitespace aroun
+344,"@@ -375,3 +375,14 @@ func (nc NodeController) readGenesisJSON(genesisFile string) (genesisLedger book
+ 	err = protocol.DecodeJSON(genesisText, &genesisLedger)
+ 	return
+ }
++
++// SetConsensus applies a new consensus settings which would get deployed before
++// any of the nodes starts
++func (nc NodeController) SetConsensus(consensus config.ConsensusProtocols) error {
++	return config.SaveConfigurableConsensus(nc.algodDataDir, consensus)
++}
++
++// GetConsensus rebuild the consensus version from the data directroy
++func (nc NodeController) GetConsensus() (config.ConsensusProtocols, error) {
++	return config.PreloadConfigurableConsensusProtocols(nc.algodDataDir)
++}",rebuild: say loads and merges,Why do we need this method?
+345,"@@ -20,7 +20,6 @@
+  * External dependencies
+  */
+ import { getDefaultOptions } from 'expect-puppeteer';
+-import { Page, ElementHandle } from 'puppeteer';
+ 
+ /**
+  * Jest matcher for asserting the given instance has tracking loaded or not.",Why was this removed here (also in the other file)? Shouldn't we import them so that the reference in the docs below is interpreted correctly?,Why was this removed?
+346,"@@ -32,13 +32,12 @@ from databricks.koalas.series import Series
+ 
+ 
+ class PySparkTestCase(unittest.TestCase):
+-
+     def setUp(self):
+         self._old_sys_path = list(sys.path)
+         if SparkContext._active_spark_context is not None:
+             SparkContext._active_spark_context.stop()
+         class_name = self.__class__.__name__
+-        self.sc = SparkContext('local[4]', class_name)
++        self.sc = SparkContext(""local[4]"", class_name)
+ 
+     def tearDown(self):
+         self.sc.stop()",I'd prefer to have a blank line between the class declaration and its first member. Is it possible?,Why this change?
+347,"@@ -299,7 +299,7 @@ describe('Mongos SRV Polling', function () {
+         return records.map(r => `${r.name}:${r.port}`);
+       }
+ 
+-      const MONGOS_DEFAULT_ISMASTER = Object.assign({}, mock.DEFAULT_ISMASTER_36, {
++      const MONGOS_LEGACY_HELLO = Object.assign({}, mock.HELLO, {
+         msg: 'isdbgrid'
+       });
+ ",Is it really LEGACY_HELLO if we are using the most up to date HELLO? Perhaps `MONGOS_HELLO` would work here?,This should be `HELLO.DEFAU
+348,"@@ -1922,10 +1922,10 @@ detach_on_permanent_stack(bool internal, bool do_cleanup)
+     DEBUG_DECLARE(bool ok;)
+     DEBUG_DECLARE(int exit_res;)
+     /* synch-all flags: if we fail to suspend a thread (e.g., privilege
+-     * problems) ignore it.  XXX Should we retry instead?
++     * problems) retry it.
+      */
+     /* i#297: we only synch client threads after process exit event. */
+-    uint flags = THREAD_SYNCH_SUSPEND_FAILURE_IGNORE | THREAD_SYNCH_SKIP_CLIENT_THREAD;
++    uint flags = THREAD_SYNCH_SUSPEND_FAILURE_RETRY | THREAD_SYNCH_SKIP_CLIENT_THREAD;
+ 
+     ENTERING_DR();
+ ","I am afraid this is going to cause problems on Windows where it is not uncommon to have injected threads (CTRL_SHUTDOWN, CTRL_LOGOFF, etc.) we have no privileges to suspend -- and thus retrying will just fail again, and with the new ""synchall failure is fatal and should kill the process"" approach it turns what used to work for us on Windows into process death.","I don't think this is correct. If we fail to suspend a thread, we should not retry."
+349,"@@ -45,6 +45,7 @@ program
+   .option('-C <build_dir>', 'build config (out/Debug, out/Release')
+   .option('--target_arch <target_arch>', 'target architecture', 'x64')
+   .option('--mac_signing_identifier <id>', 'The identifier to use for signing')
++  .option('--mac_installer_signing_identifier <id>', 'The identifier to use for signing the installer')
+   .option('--mac_signing_keychain <keychain>', 'The identifier to use for signing', 'login')
+   .option('--debug_build <debug_build>', 'keep debugging symbols')
+   .option('--official_build <official_build>', 'force official build settings')",think it should only be in create_dist,This should be renamed to `--mac_installer_signing_identifier`
+350,"@@ -429,9 +429,14 @@ func (c *NPLController) handleAddUpdatePod(key string, obj interface{}) error {
+ 			podPorts[port] = struct{}{}
+ 			portData := c.portTable.GetEntryByPodIPPort(podIP, int(cport.ContainerPort))
+ 			if portData == nil { // rule does not exist
+-				nodePort, err = c.portTable.AddRule(podIP, port)
+-				if err != nil {
+-					return fmt.Errorf(""failed to add rule for Pod %s: %v"", key, err)
++				if int(cport.HostPort) > 0 {
++					klog.V(4).Infof(""Host Port is defined for Container %s in Pod %s, thus extra NPL port is not allocated"", container.Name, key)
++					nodePort = int(cport.HostPort)
++				} else {
++					nodePort, err = c.portTable.AddRule(podIP, port)
++					if err != nil {
++						return fmt.Errorf(""failed to add rule for Pod %s: %v"", key, err)
++					}
+ 				}
+ 			} else {
+ 				nodePort = portData.NodePort",Do you plan to support Pod spec change? Like hostPort is added/removed later after Pod creation?,Shouldn't this be an error?
+351,"@@ -157,13 +157,14 @@ func (tlf *TLF) GetFileInformation(ctx context.Context, fi *dokan.FileInfo) (st
+ }
+ 
+ // open tries to open a file.
+-func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (dokan.File, bool, error) {
++func (tlf *TLF) open(ctx context.Context, oc *openContext, path []string) (
++	dokan.File, dokan.CreateStatus, error) {
+ 	if len(path) == 0 {
+ 		if err := oc.ReturningDirAllowed(); err != nil {
+-			return nil, true, err
++			return nil, 0, err
+ 		}
+ 		tlf.refcount.Increase()
+-		return tlf, true, nil
++		return tlf, dokan.ExistingDir, nil
+ 	}
+ 
+ 	mode := libkbfs.ReadMode","Is this behavior correct? It used to return `true`, which should map to `dokan.ExistingDir`. Was that previously a bug?","why not just return `dokan.ExistingDir, nil`?"
+352,"@@ -27,7 +27,11 @@ void deleteRegion(const storage::SharedRegionRegister::ShmKey key)
+ 
+ void listRegions()
+ {
+-
++    if (!storage::SharedMonitor<storage::SharedRegionRegister>::exists())
++    {
++        osrm::util::Log() << ""No shared memory regions found. Try running osrm-datastore"";
++        return;
++    }
+     storage::SharedMonitor<storage::SharedRegionRegister> monitor;
+     std::vector<std::string> names;
+     const auto &shared_register = monitor.data();",What about just printing an empty list in this case? That would make the output more predictable.,I think this should be a warning.
+353,"@@ -24,7 +24,6 @@ export default Component.extend({
+ 
+     init() {
+         this._super(...arguments);
+-        this.container = document.querySelector('.gh-editor-container')[0];
+ 
+         let mobiledoc = this.get('value') || BLANK_DOC;
+         let userCards = this.get('cards') || [];","I looked and couldn't find any usage of `container` in any of the editor component files (js or hbs), so I assume this was used once and didn't get removed?",Why was this removed?
+354,"@@ -256,11 +256,11 @@ function roots_request_filter($query_vars) {
+ add_filter('request', 'roots_request_filter');
+ 
+ /**
+- * Tell WordPress to use searchform.php from the templates/ directory
++ * Tell WordPress to use searchform.php from the templates/ directory. Requires WordPress 3.6+
+  */
+-function roots_get_search_form($argument) {
+-  if ($argument === '') {
+-    locate_template('/templates/searchform.php', true, false);
+-  }
++function roots_get_search_form($form) {
++  $form = '';
++  locate_template('/templates/searchform.php', true, false);
++  return $form;
+ }
+ add_filter('get_search_form', 'roots_get_search_form');",I just updated a number of sites using older versions of Roots onto WP 3.6 and this little function change was required. Multiple search bars were displaying when I used the search widget in a widgetized sidebar. Updated the roots_get_search_form as seen in this change resolved it for me!,This should be `return $form;`
+355,"@@ -19,6 +19,7 @@ use Thelia\Condition\ConditionEvaluator;
+ use Thelia\Condition\Implementation\MatchForTotalAmount;
+ use Thelia\Condition\Operators;
+ use Thelia\Coupon\FacadeInterface;
++use Thelia\Coupon\Type\FreeProduct;
+ use Thelia\Model\CartItem;
+ use Thelia\Model\CountryQuery;
+ use Thelia\Model\CurrencyQuery;",Fixes test failed in some cases,Why is this needed?
+356,"@@ -23,9 +23,7 @@ module.exports = [
+   'https://balance-staging.mercury.basicattentiontoken.org/',
+   'https://publishers.basicattentiontoken.org/',
+   'https://publishers-staging.basicattentiontoken.org/',
+-  'https://updates.bravesoftware.com/', // remove this once updates are moved to the prod environment
+-  'https://ads-serve.bravesoftware.com/', // remove this once ads catalog moves to using prod
+-  'https://pdfjs.robwu.nl/logpdfjs', // allowed because it gets canceled in tracking protection
++  'https://updates.bravesoftware.com/',
+   'https://publishers-distro.basicattentiontoken.org/',
+   'https://publishers-staging-distro.basicattentiontoken.org/',
+   'https://p3a.brave.com/',",what's the prod url for this? just curious. @amirsaber,Why are we removing this?
+357,"@@ -153,6 +153,12 @@ public class Constants {
+   // Overridable plugin load properties
+   public static final String AZ_PLUGIN_LOAD_OVERRIDE_PROPS = ""azkaban.plugin.load.override.props"";
+ 
++  // Append JVM args to job commands
++  public static final String AZ_JOB_COMMAND_ARGS = ""azkaban.jvm.cmd.args"";
++
++  // Ignore the above JVM args for jobtypes which have this true.
++  public static final String AZ_JOB_IGNORE_JVM_ARGS = ""ignore.jvm.args"";
++
+   /**
+    * File containing param override configs
+    * For a directory structure, property files in Proj_Dir used to have lower precedence than A.",Can you please change this to azkaban.jobs.java.opts?,Should this be `azkaban.j
+358,"@@ -66,11 +66,10 @@ function AcquisitionPieChart( { data, args, source } ) {
+ 
+ 	let sourceMessage = '';
+ 	if ( source ) {
+-		sourceMessage = sprintf(
+-			/* translators: %1$s: URL to Analytics Module page in Site Kit Admin, %2$s: Analytics (Service Name) */
+-			__( 'Source: <a class=""googlesitekit-cta-link googlesitekit-cta-link--external googlesitekit-cta-link--inherit"" href=""%1$s"">%2$s</a>', 'google-site-kit' ),
++		sourceMessage = __( 'Source:', 'google-site-kit' ) + sprintf(
++			' <a class=""googlesitekit-cta-link googlesitekit-cta-link--external googlesitekit-cta-link--inherit"" href=""%1$s"">%2$s</a>',
+ 			getSiteKitAdminURL( 'googlesitekit-module-analytics' ),
+-			_x( 'Analytics', 'Service name', 'google-site-kit' ),
++			_x( 'Analytics', 'Service name', 'google-site-kit' )
+ 		);
+ 	}
+ ","Here is another concatenation which should be updated. Even though `Source:` and the link are essentially separate, it isn't RTL friendly. This would be another good use for `createInterpolateElement` I think so that we wouldn't need to include all of the classnames in the translation string (or extract them to a placeholder). That would allow us to use the `Link` component as well, rather than using its resulting HTML as a string which will be a pain to maintain if we were to make changes to the base `Link` component.",I think this should be `s
+359,"@@ -26,12 +26,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Infrastructure
+ #endif
+         }
+ 
+-        public static Task<int> GetCancelledZeroTask()
++        public static Task<int> GetCancelledZeroTask(CancellationToken cancellationToken = default(CancellationToken))
+         {
+-            // Task<int>.FromCanceled doesn't return Task<int>
++#if NETSTANDARD1_3
++            return Task.FromCanceled<int>(cancellationToken);
++#else
+             var tcs = new TaskCompletionSource<int>();
+             tcs.TrySetCanceled();
+             return tcs.Task;
++#endif
+         }
+     }
+ }",I would add an overload `GetCancelledZeroTask()` which calls `GetCancelledZeroTask(CancellationToken.None)`. This is cleaner than requiring the caller to pass `default(CancellationToken)` or `CancellationToken.None`.,Why is this needed?
+360,"@@ -295,9 +295,13 @@ void BestPractices::PreCallRecordDestroyImage(VkDevice device, VkImage image, co
+ }
+ 
+ void BestPractices::PreCallRecordDestroySwapchainKHR(VkDevice device, VkSwapchainKHR swapchain, const VkAllocationCallbacks* pAllocator) {
+-    SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
+-    for (auto& image : chain->images) {
+-        ReleaseImageUsageState(image.image_state->image());
++    if (VK_NULL_HANDLE != swapchain) {
++        SWAPCHAIN_NODE* chain = GetSwapchainState(swapchain);
++        for (auto& image : chain->images) {
++            if (image.image_state) {
++                ReleaseImageUsageState(image.image_state->image());
++            }
++        }
+     }
+     ValidationStateTracker::PreCallRecordDestroySwapchainKHR(device, swapchain, pAllocator);
+ }","Would it be equivalent to check if `chain != nullptr` below? Not suggesting a change, just curious.",Shouldn't this be `!=`?
+361,"@@ -1131,9 +1131,10 @@ bool nano::wallet::change_sync (nano::account const & source_a, nano::account co
+ 
+ void nano::wallet::change_async (nano::account const & source_a, nano::account const & representative_a, std::function<void(std::shared_ptr<nano::block>)> const & action_a, uint64_t work_a, bool generate_work_a)
+ {
+-	wallets.node.wallets.queue_wallet_action (nano::wallets::high_priority, shared_from_this (), [source_a, representative_a, action_a, work_a, generate_work_a](nano::wallet & wallet_a) {
++	wallets.node.wallets.queue_wallet_action (nano::wallets::high_priority, shared_from_this (), [this, source_a, representative_a, action_a, work_a, generate_work_a](nano::wallet & wallet_a) {
+ 		auto block (wallet_a.change_action (source_a, representative_a, work_a, generate_work_a));
+ 		action_a (block);
++		this->wallets.queue_work_regeneration (std::chrono::steady_clock::now (), block);
+ 	});
+ }
+ ","Should probably do `auto this_l (shared_from_this ());` and pass/use that instead of `this`. Same a few other places. IOW, replace both `shared_from_this()` and `this` with `this_l`",`this->` is redundant.
+362,"@@ -55,7 +55,8 @@ module.exports = iterateJsdoc(
+ 		) {
+ 			context.report( {
+ 				data: { name: jsdocNode.name },
+-				message: `The first word in a function's description should be a third-person verb (eg ""runs"" not ""run"").`,
++				message:
++					'The first word in a function\'s description should be a third-person verb (eg ""runs"" not ""run"").',
+ 				node: jsdocNode,
+ 			} );
+ 		}","And here. Please, use `'` for apostrophes in changed strings in this file.",I don't think this is c
+363,"@@ -100,7 +100,7 @@ func (gs *GasStation) EstimateGasForAction(actPb *iotextypes.Action) (uint64, er
+ 		if err != nil {
+ 			return 0, err
+ 		}
+-		_, receipt, err := gs.bc.ExecuteContractRead(callerAddr, sc)
++		_, receipt, err := gs.bc.SimulateExecution(callerAddr, sc)
+ 		if err != nil {
+ 			return 0, err
+ 		}",assignments should only be cuddled with other assignments (from `wsl`),Shouldn't this be `Exec
+364,"@@ -504,7 +504,15 @@ func (c *ConfigLocal) MetadataVersion() MetadataVer {
+ 
+ // DataVersion implements the Config interface for ConfigLocal.
+ func (c *ConfigLocal) DataVersion() DataVer {
+-	return 1
++	return FilesWithHolesDataVer
++}
++
++// DefaultNewBlockDataVersion returns the default data version for new blocks.
++func DefaultNewBlockDataVersion(c Config, holes bool) DataVer {
++	if holes {
++		return FilesWithHolesDataVer
++	}
++	return FirstValidDataVer
+ }
+ 
+ // DoBackgroundFlushes implements the Config interface for ConfigLocal.",Please move this to `block_types.go`.,nit: `DefaultNewBlockDataVersion` -> `DefaultNewBlockDataVersion`
+365,"@@ -40,9 +40,6 @@ namespace NLog.Layouts
+     /// JSON attribute.
+     /// </summary>
+     [NLogConfigurationItem]
+-    [ThreadAgnostic]
+-    [ThreadSafe]
+-    [AppDomainFixedOutput]
+     public class JsonAttribute
+     {
+         /// <summary>",So this is not needed anymore for all attributes?,Why is this being removed?
+366,"@@ -46,13 +46,13 @@ namespace OpenTelemetry.Extensions.Hosting.Implementation
+             }
+         }
+ 
+-        [Event(1, Message = ""Failed to initialize: '{0}'. OpenTelemetry will not work."", Level = EventLevel.Error)]
++        [Event(1, Message = ""An exception occured while adding OpenTelemetry Tracing to ServiceCollection. OpenTelemetry tracing will not work. Exception: '{0}'."", Level = EventLevel.Error)]
+         public void FailedInitialize(string exception)
+         {
+             this.WriteEvent(1, exception);
+         }
+ 
+-        [Event(2, Message = ""Failed to get OpenTelemetrySDK: '{0}'. OpenTelemetry will not work."", Level = EventLevel.Error)]
++        [Event(2, Message = ""An exception occured while retrieving OpenTelemetry Tracer from Service Provider. OpenTelemetry tracing will not work. Exception: '{0}'."", Level = EventLevel.Error)]
+         public void FailedOpenTelemetrySDK(string exception)
+         {
+             this.WriteEvent(2, exception);",Happy to get suggestion for better messaging here. Here's what I intended to convey: Something is wrong - the Exception is a hint to what might be the cause The impact of that - tracing wont work.,I'm not sure if this is the right way to do it. I think it should
+367,"@@ -108,6 +108,11 @@ def start_acm(port=None, asynchronous=False):
+     return start_moto_server('acm', port, name='ACM', asynchronous=asynchronous)
+ 
+ 
++def start_ses(port=None, asynchronous=False, update_listener=None):
++    port = port or config.PORT_SES
++    return start_moto_server('ses', port, name='SES', asynchronous=asynchronous, update_listener=update_listener)
++
++
+ # TODO move to es_starter.py?
+ def start_elasticsearch_service(port=None, asynchronous=False):
+     port = port or config.PORT_ES","I think we can remove this function, right? (duplicate with `ses_starter.py`)",I don't think we need the `update_listener` argument.
+368,"@@ -195,6 +195,10 @@ class PandasLikeSeries(_Frame):
+                     ""Field {} not found, possible values are {}"".format(name, "", "".join(fnames)))
+             return anchor_wrap(self, self._spark_getField(name))
+ 
++    # TODO: automate the process here
++    def alias(self, name):
++        return self.rename(name)
++
+     @property
+     def schema(self):
+         if not hasattr(self, '_pandas_schema') or self._pandas_schema is None:","With this fix, I am not even sure we need to overwrite this function.",Can you add a `TODO` here?
+369,"@@ -311,6 +311,8 @@ class PackageEntry(object):
+ class Package(object):
+     """""" In-memory representation of a package """"""
+ 
++    use_tqdm = os.getenv('QUILT_USE_TQDM').lower() == 'true'
++
+     def __init__(self):
+         self._children = {}
+         self._meta = {'version': 'v0'}",Why not just import this from `data_transfer`? As a rule copying the same code twice is not a good idea. Also: please run `pylint` on all files in this PR.,I think this should be `US
+370,"@@ -99,7 +99,7 @@ module Beaker
+       it ""can correctly combine arguments from different sources"" do
+         FakeFS.deactivate!
+         args = [""-h"", hosts_path, ""--debug"", ""--type"", ""git"", ""--install"", ""PUPPET/1.0,HIERA/hello""]
+-        expect(parser.parse_args(args)).to be === {:hosts_file=>hosts_path, :options_file=>nil, :type=>""git"", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>""/opt/enterprise/dists"", :pe_version_file=>""LATEST"", :pe_version_file_win=>""LATEST-win"", :dot_fog=>""#{home}/.fog"", :ec2_yaml=>""config/image_templates/ec2.yaml"", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[""publickey""], :port=>22, :forward_agent=>true, :keys=>[""#{home}/.ssh/id_rsa""], :user_known_hosts_file=>""#{home}/.ssh/known_hosts""}, :install=>[""git://github.com/puppetlabs/puppet.git#1.0"", ""git://github.com/puppetlabs/hiera.git#hello""], :HOSTS=>{:""pe-ubuntu-lucid""=>{:roles=>[""agent"", ""dashboard"", ""database"", ""master""], :vmname=>""pe-ubuntu-lucid"", :platform=>""ubuntu-10.04-i386"", :snapshot=>""clean-w-keys"", :hypervisor=>""fusion""}, :""pe-centos6""=>{:roles=>[""agent""], :vmname=>""pe-centos6"", :platform=>""el-6-i386"", :hypervisor=>""fusion"", :snapshot=>""clean-w-keys""}}, :nfs_server=>""none"", :puppet_ver=>nil, :facter_ver=>nil, :hiera_ver=>nil, :hiera_puppet_ver=>nil, :helper=>[], :load_path=>[], :tests=>[], :pre_suite=>[], :post_suite=>[], :modules=>[]}
++        expect(parser.parse_args(args)).to be === {:hosts_file=>""/Users/anode/beaker/spec/beaker/options/data/hosts.cfg"", :options_file=>nil, :type=>""git"", :provision=>true, :preserve_hosts=>false, :root_keys=>false, :quiet=>false, :xml=>false, :color=>true, :debug=>true, :dry_run=>false, :fail_mode=>nil, :timesync=>false, :repo_proxy=>false, :add_el_extras=>false, :consoleport=>443, :pe_dir=>""/opt/enterprise/dists"", :pe_version_file=>""LATEST"", :pe_version_file_win=>""LATEST-win"", :dot_fog=>""/Users/anode/.fog"", :ec2_yaml=>""config/image_templates/ec2.yaml"", :ssh=>{:config=>false, :paranoid=>false, :timeout=>300, :auth_methods=>[""publickey""], :port=>22, :forward_agent=>true, :keys=>[""/Users/anode/.ssh/id_rsa""], :user_known_hosts_file=>""/Users/anode/.ssh/known_hosts""}, :install=>[""git://github.com/puppetlabs/puppet.git#1.0"", ""git://github.com/puppetlabs/hiera.git#hello""], :HOSTS=>{:""pe-ubuntu-lucid""=>{:roles=>[""agent"", ""dashboard"", ""database"", ""master""], :vmname=>""pe-ubuntu-lucid"", :platform=>""ubuntu-10.04-i386"", :snapshot=>""clean-w-keys"", :hypervisor=>""fusion""}, :""pe-centos6""=>{:roles=>[""agent""], :vmname=>""pe-centos6"", :platform=>""el-6-i386"", :hypervisor=>""fusion"", :snapshot=>""clean-w-keys""}}, :nfs_server=>""none"", :helper=>[], :load_path=>[], :tests=>[], :pre_suite=>[], :post_suite=>[], :modules=>[]}
+       end
+ 
+       it ""ensures that file-mode is one of fast/stop"" do",You've got an absolute path here referencing your home dir :-).,Why was this removed?
+371,"@@ -526,10 +526,10 @@ public final class JavaParserMetaModel {
+         unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.expressionPropertyMetaModel);
+         unaryExprMetaModel.operatorPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""operator"", com.github.javaparser.ast.expr.UnaryExpr.Operator.class, Optional.empty(), false, false, false, false, false);
+         unaryExprMetaModel.getDeclaredPropertyMetaModels().add(unaryExprMetaModel.operatorPropertyMetaModel);
+-        unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""prefix"", boolean.class, Optional.empty(), false, true, false, false, false);
+-        unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.prefixPropertyMetaModel);
+         unaryExprMetaModel.postfixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""postfix"", boolean.class, Optional.empty(), false, true, false, false, false);
+         unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.postfixPropertyMetaModel);
++        unaryExprMetaModel.prefixPropertyMetaModel = new PropertyMetaModel(unaryExprMetaModel, ""prefix"", boolean.class, Optional.empty(), false, true, false, false, false);
++        unaryExprMetaModel.getDerivedPropertyMetaModels().add(unaryExprMetaModel.prefixPropertyMetaModel);
+         variableDeclarationExprMetaModel.annotationsPropertyMetaModel = new PropertyMetaModel(variableDeclarationExprMetaModel, ""annotations"", com.github.javaparser.ast.expr.AnnotationExpr.class, Optional.of(annotationExprMetaModel), false, false, true, false, false);
+         variableDeclarationExprMetaModel.getDeclaredPropertyMetaModels().add(variableDeclarationExprMetaModel.annotationsPropertyMetaModel);
+         variableDeclarationExprMetaModel.modifiersPropertyMetaModel = new PropertyMetaModel(variableDeclarationExprMetaModel, ""modifiers"", com.github.javaparser.ast.Modifier.class, Optional.empty(), false, false, false, true, false);",Maybe I should do some sorting so that these properties don't keep moving around...,Why did you change this?
+372,"@@ -32,14 +32,6 @@ func TestCheckMountDestFalsePositive(t *testing.T) {
+ 	}
+ }
+ 
+-func TestCheckMountRoot(t *testing.T) {
+-	dest := ""/rootfs""
+-	err := checkMountDestination(""/rootfs"", dest)
+-	if err == nil {
+-		t.Fatal(err)
+-	}
+-}
+-
+ func TestNeedsSetupDev(t *testing.T) {
+ 	config := &configs.Config{
+ 		Mounts: []*configs.Mount{","Can we keep this test anyway, as it's part of the spec?",Why was this test removed?
+373,"@@ -0,0 +1,19 @@
++<?php
++
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See license.txt for license details.
++ */
++
++declare(strict_types = 1);
++
++namespace Ergonode\Mailer;
++
++use Ergonode\Mailer\Application\DependencyInjection\CompilerPass\MailerStrategyInterfaceCompilerPass;
++use Ergonode\SharedKernel\Application\AbstractModule;
++
++/**
++ */
++class ErgonodeMailerBundle extends AbstractModule
++{
++}",Can be removed,Why do we need this?
+374,"@@ -1,5 +1,7 @@
+ <?php namespace System\Controllers;
+ 
++use Config;
++use Request;
+ use Lang;
+ use Flash;
+ use Backend;","It's a minor quibble I know, but I like having the imports ordered by lengt",Why is this needed?
+375,"@@ -216,7 +216,7 @@ public abstract class AbstractRestInvocation {
+       }
+     }
+     responseEx.setStatus(response.getStatusCode(), response.getReasonPhrase());
+-    responseEx.setContentType(produceProcessor.getName());
++    responseEx.setContentType(produceProcessor.getName()+""; charset=utf-8"");
+ 
+     Object body = response.getResult();
+     if (response.isFailed()) {",It's better to get the charset from context or other setting to let the user override it.,Why do we need this change
+376,"@@ -70,7 +70,7 @@ func NewCStorPoolController(
+ 	cStorInformerFactory informers.SharedInformerFactory) *CStorPoolController {
+ 
+ 	// obtain references to shared index informers for the cStorPool resources
+-	cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().NewTestCStorPools()
++	cStorPoolInformer := cStorInformerFactory.Openebs().V1alpha1().CStorPoolInstances()
+ 
+ 	zpool.KubeClient = kubeclientset
+ 	zpool.OpenEBSClient = clientset",this filename as well needs change,Why do we need this change?
+377,"@@ -179,10 +179,11 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
+ // ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
+ // configuration for AWS
+ type ACMEIssuerDNS01ProviderRoute53 struct {
+-	AccessKeyID     string            `json:""accessKeyID""`
+-	SecretAccessKey SecretKeySelector `json:""secretAccessKeySecretRef""`
+-	HostedZoneID    string            `json:""hostedZoneID""`
+-	Region          string            `json:""region""`
++	AccessKeyID        string            `json:""accessKeyID,omitempty""`
++	AccessKeyIDRef     SecretKeySelector `json:""accessKeyIDSecretRef,omitempty""`
++	SecretAccessKeyRef SecretKeySelector `json:""secretAccessKeySecretRef""`
++	HostedZoneID       string            `json:""hostedZoneID""`
++	Region             string            `json:""region""`
+ }
+ 
+ // ACMEIssuerDNS01ProviderAzureDNS is a structure containing the",I think we want to remove `omitempty` here,Why do we need these fields
+378,"@@ -129,6 +129,8 @@ func startContainer(context *cli.Context, spec *specs.LinuxSpec) (int, error) {
+ 	if err != nil {
+ 		return -1, err
+ 	}
++	handler := newSignalHandler(tty)
++	defer handler.Close()
+ 	if err := container.Start(process); err != nil {
+ 		return -1, err
+ 	}",You cannot move this here because it breaks detach. Just call `tty.Close()` before returning the error from start,Why do we need a new handle
+379,"@@ -376,8 +376,7 @@ lookupTables.role = {
+ 			one: ['rowgroup', 'row']
+ 		},
+ 		nameFrom: ['author'],
+-		context: null,
+-		implicit: ['table']
++		context: null
+ 	},
+ 	'gridcell': {
+ 		type: 'widget',",I updated only the implicit roles who needed a update for this new rule to validate.,Why was this removed?
+380,"@@ -7,11 +7,12 @@
+ package pb
+ 
+ import (
++	reflect ""reflect""
++	sync ""sync""
++
+ 	proto ""github.com/golang/protobuf/proto""
+ 	protoreflect ""google.golang.org/protobuf/reflect/protoreflect""
+ 	protoimpl ""google.golang.org/protobuf/runtime/protoimpl""
+-	reflect ""reflect""
+-	sync ""sync""
+ )
+ 
+ const (",> // Code generated by protoc-gen-go. DO NOT EDIT.,Why are these changes needed?
+381,"@@ -46,6 +46,9 @@ var (
+ 		utils.GcloudProdWrapperLatest:   ""gcloud"",
+ 		utils.GcloudLatestWrapperLatest: ""gcloud"",
+ 	}
++	// Apply this as instance metadata if the OS config agent is not
++	// supported for the platform or version being imported.
++	skipOSConfig = map[string]string{""osconfig_not_supported"": ""true""}
+ )
+ 
+ type ovfInstanceImportTestProperties struct {","minor: skipOSConfigMetadata, otherwise, the name sounds like a boolean",I don't think we need this.
+382,"@@ -56,7 +56,9 @@ public class NSRSS20 extends Namespace {
+ 			boolean validType = false;
+ 			boolean validUrl = !TextUtils.isEmpty(url);
+ 
+-			if (type == null) {
++			if(SyndTypeUtils.enclosureTypeValid(type)) {
++				validType = true;
++			} else {
+ 				type = SyndTypeUtils.getMimeTypeFromUrl(url);
+ 			}
+ ","~~I think lines 65-67 should be moved into this else clause after `type = ...` Else, it is a bit confusing why we check the enclose type validity a second time~~ Nevermind, will do some refactoring, myself. But thanks for ""fixing"" this!",This should be `validType = S
+383,"@@ -239,3 +239,16 @@ func (client *Client) Stop() error {
+ 
+ 	return nil
+ }
++
++// GetSessions returns all sessions from history
++func (client *Client) GetSessions() (endpoints.SessionsDTO, error) {
++	response, err := client.http.Get(""sessions"", url.Values{})
++	if err != nil {
++		return endpoints.SessionsDTO{}, err
++	}
++	defer response.Body.Close()
++
++	var sessions endpoints.SessionsDTO
++	err = parseResponseJSON(response, &sessions)
++	return sessions, err
++}",`sessions := endpoints.SessionsDTO{}` and using only `sessions` should be simpler.,I think it would be better to
+384,"@@ -5242,8 +5242,11 @@ master_signal_handler_C(byte *xsp)
+ 
+     /* Ensure we didn't get the app's sigstack into our frame.  On Mac, the kernel
+      * doesn't use the frame's uc_stack, so we limit this to Linux.
++     * The pointers may be different if a thread is on its way to exit, and the app's
++     * sigstack was already restored (i#3369).
+      */
+-    IF_LINUX(ASSERT(dcontext == NULL || dcontext == GLOBAL_DCONTEXT ||
++    IF_LINUX(ASSERT(dcontext == NULL || dcontext->is_exiting ||
++                    dcontext == GLOBAL_DCONTEXT ||
+                     frame->uc.uc_stack.ss_sp ==
+                         ((thread_sig_info_t *)dcontext->signal_field)->sigstack.ss_sp));
+ ",These need to be in the other order to avoid crashing when dcontext == GLOBAL_DCONTEXT (==-1),"I don't think this is correct. If the thread is on its way to exit, and the app's sigstack was already restored (i#3369), the pointers may be different if a thread is on its way to exit, and the app's sigstack was already restored."
+385,"@@ -24,7 +24,8 @@ namespace Http2SampleApp
+                     factory.SetMinimumLevel(LogLevel.Trace);
+                     factory.AddConsole();
+                 })
+-                .UseKestrel((context, options) =>
++                .UseKestrel()
++                .ConfigureKestrel((context, options) =>
+                 {
+                     var basePort = context.Configuration.GetValue<int?>(""BASE_PORT"") ?? 5000;
+ ",Why not change the other samples?,Why is this change needed?
+386,"@@ -10,8 +10,9 @@ table.isHeader = function (cell) {
+ 		return true;
+ 	}
+ 
+-	if (cell.id) {
+-		return !!document.querySelector('[headers~=""' + axe.utils.escapeSelector(cell.id) + '""]');
++	if (cell.getAttribute('id')) {
++    const id = axe.utils.escapeSelector(cell.getAttribute('id'));
++		return !!document.querySelector(`[headers~=""${id}""]`);
+ 	}
+ 
+ 	return false;","Indentation is mixed up here due to spaces/tabs, I'm guessing.",I don't think we need to escape the `id` here.
+387,"@@ -738,9 +738,15 @@ static fpga_result poll_interrupt(fpga_dma_handle dma_h) {
+ 		res = FPGA_EXCEPTION;
+ 	} else {
+ 		uint64_t count = 0;
+-		read(pfd.fd, &count, sizeof(count));
+-		debug_print(""Poll success. Return = %d, count = %d\n"",poll_res, (int)count);
+-		res = FPGA_OK;
++		ssize_t bytes_read = read(pfd.fd, &count, sizeof(count));
++		if(bytes_read <= 0) {
++			fprintf( stderr, ""Error: %s\n"",
++				bytes_read < 0 ? strerror(errno) : ""zero bytes read"");
++			res = FPGA_EXCEPTION;
++		} else {
++			debug_print(""Poll success. Return = %d, count = %d\n"",poll_res, (int)count);
++			res = FPGA_OK;
++		}
+ 	}
+ 
+ out:",Should we provide a little more context in the error message? Maybe throw in something about what operation was being performed?,Shouldn't this be `bytes_read == 0`?
+388,"@@ -138,7 +138,10 @@ class PluginBase extends ServiceProviderBase
+      */
+     public function registerSettings()
+     {
+-        return [];
++		$configuration = $this->getConfigurationFromYaml();
++		if (array_key_exists('settings', $configuration)) {
++			return $configuration['settings'];
++		}
+     }
+ 
+     /**","Project standard is spaces, not tabs. Please fix and then we can merge this.",Why do we need this?
+389,"@@ -1,12 +1,14 @@
+ #include ""dynamic_zone.h""
+-#include ""expedition.h""
+-#include ""expedition_state.h""
++#include ""cliententry.h""
++#include ""clientlist.h""
++#include ""dynamic_zone_manager.h""
+ #include ""worlddb.h""
+ #include ""zonelist.h""
+ #include ""zoneserver.h""
+ #include ""../common/eqemu_logsys.h""
+ #include ""../common/repositories/instance_list_repository.h""
+ 
++extern ClientList client_list;
+ extern ZSList zoneserver_list;
+ 
+ Database& DynamicZone::GetDatabase()",@hgtw is there anything we're worried about with regards to using this cache? Do we want to do staged testing around expeditions before we merge? Curious your thoughts here,Why is this header n
+390,"@@ -226,11 +226,11 @@ public class ManifestReader extends CloseableGroup implements Filterable<Filtere
+ 
+   @Override
+   public Iterator<DataFile> iterator() {
+-    return iterator(alwaysTrue(), fileSchema);
++    return iterator(fileSchema);
+   }
+ 
+   // visible for use by PartialManifest
+-  Iterator<DataFile> iterator(Expression partFilter, Schema fileProjection) {
++  Iterator<DataFile> iterator(Schema fileProjection) {
+     return Iterables.transform(Iterables.filter(
+         entries(fileProjection),
+         entry -> entry.status() != ManifestEntry.Status.DELETED),",The purpose of this was to allow pushing filters into the manifest files if we ever use a format other than Parquet. I think overall this is a good change because we can add it back later. Just wanted to note why the unused argument was there.,Why is this change n
+391,"@@ -24,7 +24,15 @@ module Mongoid
+             # @since 1.0.0
+             def evolve(object)
+               __evolve__(object) do |obj|
+-                obj ? obj.to_s : obj
++                if obj
++                  if obj.is_a?(::BigDecimal) && Mongoid.map_big_decimal_to_decimal128
++                    BSON::Decimal128.new(obj)
++                  elsif obj.is_a?(BSON::Decimal128) && Mongoid.map_big_decimal_to_decimal128
++                    obj
++                  else
++                    obj.to_s
++                  end
++                end
+               end
+             end
+           end",I think BSON::Decimal128 should always be serialized as Decimal128 regardless of config option.,I think this should 
+392,"@@ -1,6 +1,7 @@
+ # frozen_string_literal: true
+ 
+ require 'bolt/application'
++require 'bolt/plan_creator'
+ 
+ require 'bolt_spec/files'
+ ",We should probably just move the `require 'bolt/plan_creator'` in `Bolt::CLI` to `Bolt::Application` so it will already be loaded.,# frozen_string_literal: true
+393,"@@ -34,7 +34,10 @@ namespace Benchmarks
+ 
+         private static IConfig GetConfig(Options options)
+         {
+-            var baseJob = Job.ShortRun; // let's use the Short Run for better first user experience ;)
++            var baseJob = Job.Default
++                .WithWarmupCount(1) // 1 warmup is enough for our purpose
++                .WithMaxTargetIterationCount(20);  // we don't want to run more that 20 iterations
++
+             var jobs = GetJobs(options, baseJob).ToArray();
+ 
+             var config = DefaultConfig.Instance",">20 [](start = 45, length = 2) Can we override this at runtime? Maybe it should be a command line option with default.",I don't think we want to run 
+394,"@@ -47,7 +47,7 @@ class Service(object):
+         self.start_error_message = start_error_message
+         self.log_file = log_file
+         self.env = env or os.environ
+-
++        
+     @property
+     def service_url(self):
+         """"""",can just remove it ?,Why did you change this?
+395,"@@ -654,7 +654,17 @@ func MigrateRepository(u *User, opts MigrateRepoOptions) (*Repository, error) {
+ 		return repo, UpdateRepository(repo, false)
+ 	}
+ 
+-	if err = createUpdateHook(repoPath); err != nil {
++	repo, err = FinishMigrateRepository(repo, repoPath)
++	if err != nil {
++		return repo, err
++	}
++
++	return repo, UpdateRepository(repo, false)
++}
++
++// Finish migrating repository with things that don't need to be done for mirrors.
++func FinishMigrateRepository(repo *Repository, repoPath string) (*Repository, error) {
++	if err := createUpdateHook(repoPath); err != nil {
+ 		return repo, fmt.Errorf(""createUpdateHook: %v"", err)
+ 	}
+ ",Better call it `CleanUpMirrorInfo`?,I'm not sure if this is the r
+396,"@@ -405,6 +405,19 @@ func (node *Node) SetupMining(ctx context.Context) error {
+ 		}
+ 	}
+ 
++	if err := node.StorageMining.Start(ctx); err != nil {
++		fmt.Printf(""error starting storage miner: %s\n"", err)
++	}
++
++	if err := node.StorageProtocol.StorageProvider.Start(ctx); err != nil {
++		fmt.Printf(""error starting storage provider: %s\n"", err)
++	}
++
++	// TODO: Retrieval Market Integration
++	//if err := node.RetrievalProtocol.RetrievalProvider.Start(); err != nil {
++	//	fmt.Printf(""error starting retrieval provider: %s\n"", err)
++	//}
++
+ 	return nil
+ }
+ ",@shannonwells is there still something missing here?,Can we remove this code?
+397,"@@ -149,6 +149,9 @@ MESSAGE
+       # don't accidentally leave the seed encoded.
+       define_reader :seed
+ 
++      # Time limit for stress testing, if any (default: nil).
++      add_setting :stress_test
++
+       # When a block passed to pending fails (as expected), display the failure
+       # without reporting it as a failure (default: false).
+       add_setting :show_failures_in_pending_blocks",This could be more indicative of what it is... e.g... `stresstest_time_limit`,I don't think we need to
+398,"@@ -279,7 +279,6 @@ bool PDPSimple::createPDPEndpoints()
+         delete mp_listener;
+         mp_listener = nullptr;
+         reader_payload_pool_->release_history(reader_pool_cfg, true);
+-        TopicPayloadPoolRegistry::release(reader_payload_pool_);
+         return false;
+     }
+ ",Shouldn't we do a `reader_payload_pool_.reset()` here?,Why is this removed?
+399,"@@ -33,9 +33,9 @@ type Block struct {
+ 	// ElectionProof is the vrf proof giving this block's miner authoring rights
+ 	ElectionProof *crypto.ElectionProof
+ 
+-	// DrandEntries contain the verifiable oracle randomness used to elect
++	// BeaconEntries contain the verifiable oracle randomness used to elect
+ 	// this block's author leader
+-	DrandEntries []*drand.Entry
++	BeaconEntries []*drand.Entry
+ 
+ 	// PoStProofs are the winning post proofs
+ 	PoStProofs []PoStProof `json:""PoStProofs""`",I'd prefer the nomenclature less tightly coupled to DRAND throughout. I played with renaming the `drand` package to `beacon` but it was too much noise in this change.,Why is this a pointer?
+400,"@@ -853,6 +853,11 @@ class DynamicMap(HoloMap):
+                 unbounded_dims.append(str(kdim))
+         return unbounded_dims
+ 
++    @property
++    def current_key(self):
++        """"""Returns the current key value.""""""
++        return getattr(self, '_current_key', None)
++
+     def _stream_parameters(self):
+         return util.stream_parameters(
+             self.streams, no_duplicates=not self.positional_stream_args",I think I would prefer you declare `self._current_key=None` in the constructor and just return `self._current_key`. That way you can prevent anyone from overwriting `current_key` without needing to use `getattr` here.,Why do we need this?
+401,"@@ -22,8 +22,14 @@ const FromCSVKind = ""fromCSV""
+ type FromCSVOpSpec struct {
+ 	CSV  string `json:""csv""`
+ 	File string `json:""file""`
++	Mode string `json:""mode""`
+ }
+ 
++const (
++	annotationMode = ""annotations""
++	rawMode        = ""raw""
++)
++
+ func init() {
+ 	fromCSVSignature := runtime.MustLookupBuiltinType(""csv"", ""from"")
+ 	runtime.RegisterPackageValue(""csv"", ""from"", flux.MustValue(flux.FunctionValue(FromCSVKind, createFromCSVOpSpec, fromCSVSignature)))",I guess I like the name `mode` okay. I can't think of anything better.,nit: `rawMode` is un
+402,"@@ -69,8 +69,12 @@ type Step struct {
+ 	testType stepImpl
+ }
+ 
+-// NewStep creates a Step with given name and timeout  with the specified workflow
++// NewStep creates a Step with given name and timeout  with the specified workflow.
++// If timeout is less or equal to zero, defaultTimeout from the workflow will be used
+ func NewStep(name string, w *Workflow, timeout time.Duration) *Step {
++	if timeout <= 0 {
++		return &Step{name: name, w: w, Timeout: w.DefaultTimeout}
++	}
+ 	return &Step{name: name, w: w, timeout: timeout}
+ }
+ ",I would create a new method (NewStepWithDefaultTimeout?) for this purpose because timeout<=0 looks like a hidden logic,I think this should 
+403,"@@ -71,6 +71,7 @@ func Register(r *gin.RouterGroup, s *Service) {
+ // @Param experimentNamespace query string false ""The namespace of the experiment""
+ // @Param uid query string false ""The UID of the experiment""
+ // @Param kind query string false ""kind"" Enums(PodChaos, IoChaos, NetworkChaos, TimeChaos, KernelChaos, StressChaos)
++// @Param limit query string false ""The max length of events list""
+ // @Success 200 {array} core.Event
+ // @Router /api/events [get]
+ // @Failure 500 {object} utils.APIError",Are these limit changes related?,// @Param limit quer
+404,"@@ -18,12 +18,12 @@ Routing and network interface handling for IPv6.
+ 
+ from __future__ import absolute_import
+ import socket
++import scapy.consts
+ from scapy.config import conf
+ from scapy.utils6 import *
+ from scapy.arch import *
+ from scapy.pton_ntop import *
+ from scapy.error import warning, log_loading
+-from scapy.consts import LOOPBACK_INTERFACE
+ import scapy.modules.six as six
+ 
+ ",Don't you mean `import scapy.consts`?,Why did you remove this?
+405,"@@ -62,3 +62,7 @@ func (e *Executor) ensurePrimaryUpdate(ctx context.Context) model.StageStatus {
+ 	e.LogPersister.AppendSuccess(fmt.Sprintf(""Successfully applied %d primary resources"", len(manifests)))
+ 	return model.StageStatus_STAGE_SUCCESS
+ }
++
++func (e *Executor) rollbackPrimary(ctx context.Context) model.StageStatus {
++	return model.StageStatus_STAGE_SUCCESS
++}",`ctx` is unused in rollbackPrimary,Why do we need this?
+406,"@@ -40,7 +40,7 @@ const (
+ 	// BufferedEventID is the id of the buffered event
+ 	BufferedEventID int64 = -123
+ 	// EmptyEventTaskID is uninitialized id of the task id within event
+-	EmptyEventTaskID int64 = -1234
++	EmptyEventTaskID int64 = 0
+ 	// TransientEventID is the id of the transient event
+ 	TransientEventID int64 = -124
+ 	// FirstBlobPageToken is the page token identifying the first blob for each history archival",This is not what title says.,Why this change?
+407,"@@ -0,0 +1,19 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.autofix;
++
++import net.sourceforge.pmd.lang.ast.Node;
++
++/**
++ * Classes of this interface must be used when it is desired to make one or more operations to the AST.
++ */
++public interface RuleViolationFix {
++
++    /**
++     * Apply one or more operations to a node.
++     * @param node the node in the AST on which to apply operations
++     */
++    void applyFixesToNode(Node node);
++}",a fix applies several fixes? maybe this should simply be `applyToNode`,Why do we need this inte
+408,"@@ -25,11 +25,12 @@ import (
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+ 
++// fakeGetClientset gets the cvr clientset
+ func fakeGetClientset() (clientset *clientset.Clientset, err error) {
+ 	return &client.Clientset{}, nil
+ }
+ 
+-func fakeListfn(cli *clientset.Clientset, namespace string, opts metav1.ListOptions) (*apis.CStorVolumeReplicaList, error) {
++func fakeListOk(cli *clientset.Clientset, namespace string, opts metav1.ListOptions) (*apis.CStorVolumeReplicaList, error) {
+ 	return &apis.CStorVolumeReplicaList{}, nil
+ }
+ ",U1000: func `fakeGetOk` is unused (from `unused`),nit: rename to `fakeGetClientset`
+409,"@@ -18,6 +18,8 @@ import (
+ 	""errors""
+ 	""fmt""
+ 
++	""k8s.io/client-go/util/retry""
++
+ 	""github.com/hashicorp/go-multierror""
+ 	""golang.org/x/sync/errgroup""
+ 	v1 ""k8s.io/api/core/v1""","Because there is a ""k8s.io/client-go/tools/cache"" below, we can sort out all the ""imports"" here.",nit: remove empty line
+410,"@@ -3,7 +3,9 @@
+ package api
+ 
+ import (
++	""github.com/aws/aws-sdk-go/aws""
+ 	""fmt""
++	""encoding/json""
+ 	""reflect""
+ 	""sort""
+ 	""strings""","Nit should be using `goimports` to format the import statements with standard libary imports first, new line, followed by non-standard library imports.",I think this should be `github.co
+411,"@@ -118,8 +118,10 @@ func (o *deletePipelineOpts) Ask() error {
+ 
+ // Execute deletes the secret and pipeline stack.
+ func (o *deletePipelineOpts) Execute() error {
+-	if err := o.deleteSecret(); err != nil {
+-		return err
++	if o.PipelineSecret != """" {
++		if err := o.deleteSecret(); err != nil {
++			return err
++		}
+ 	}
+ 
+ 	if err := o.deleteStack(); err != nil {",Do we not have tests for pipeline delete  ,Why do we need this check?
+412,"@@ -146,6 +146,12 @@ class HdfsClient(hdfs_abstract_client.HdfsFileSystem):
+     def put(self, local_path, destination):
+         self.call_check(load_hadoop_cmd() + ['fs', '-put', local_path, destination])
+ 
++    def append(self, local_path, destination):
++        """"""
++        Requires Hadoop >= 2.3.0
++        """"""
++        call_check(load_hadoop_cmd() + ['fs', '-appendToFile', local_path, destination])
++
+     def get(self, path, local_destination):
+         self.call_check(load_hadoop_cmd() + ['fs', '-get', path, local_destination])
+ ",Good that you mention this constraint in the docstring :),This should be `Requires Hadoop >= 2.3.0`.
+413,"@@ -15,8 +15,13 @@ package workflow
+ 
+ import (
+ 	""encoding/json""
++	""fmt""
+ 	""net/http""
+ 
++	ctrl ""sigs.k8s.io/controller-runtime""
++
++	apierrors ""k8s.io/apimachinery/pkg/api/errors""
++
+ 	""github.com/gin-gonic/gin""
+ 
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""",remove this blank?,Why do we need this?
+414,"@@ -9515,7 +9515,8 @@ FileScan::FileScan(const CorrName& tableName,
+      estRowsAccessed_ (0),
+      mdamFlag_(UNDECIDED),
+      skipRowsToPreventHalloween_(FALSE),
+-     doUseSearchKey_(TRUE)
++     doUseSearchKey_(TRUE),
++     computedNumOfActivePartiions_(-1)
+ {
+   // Set the filescan properties:
+ ","Partitions is misspelled 8 times in this commit, might make sense to fix the spelling for all of those.",Why is this -1?
+415,"@@ -22,9 +22,11 @@
+ import shlex
+ 
+ from PyQt5.QtCore import (pyqtSlot, pyqtSignal, QObject, QProcess,
+-                          QProcessEnvironment)
++                          QProcessEnvironment, QUrl)
+ 
+-from qutebrowser.utils import message, log
++from qutebrowser.utils import message, log, objreg
++
++from qutebrowser.browser import qutescheme
+ 
+ # A mapping of QProcess::ErrorCode's to human-readable strings.
+ ",Please remove this blank line - those are only used to group Python/third-party/qutebrowser imports.,I don't think this import is needed.
+416,"@@ -45,6 +45,8 @@ var ActionCmd = &cobra.Command{
+ 	Args:  cobra.MinimumNArgs(1),
+ }
+ 
++var insecure bool
++
+ func init() {
+ 	ActionCmd.AddCommand(actionHashCmd)
+ 	ActionCmd.AddCommand(actionTransferCmd)",`insecure` is a global variable (from `gochecknoglobals`),Why do we need this?
+417,"@@ -479,6 +479,11 @@ func HTTPBackend(ctx *context.Context, cfg *serviceConfig) http.HandlerFunc {
+ 		for _, route := range routes {
+ 			r.URL.Path = strings.ToLower(r.URL.Path) // blue: In case some repo name has upper case name
+ 			if m := route.reg.FindStringSubmatch(r.URL.Path); m != nil {
++				if setting.Repository.DisableHttpGit {
++					w.WriteHeader(http.StatusForbidden)
++					w.Write([]byte(""Interacting with repositories by HTTP protocol is not allowed""))
++					return
++				}
+ 				if route.method != r.Method {
+ 					if r.Proto == ""HTTP/1.1"" {
+ 						w.WriteHeader(http.StatusMethodNotAllowed)",Same as above (HTTP in upper-case),Why do we need this?
+418,"@@ -206,4 +206,11 @@ class YouTubeProviderTest extends AbstractProviderTest
+         $this->assertSame(100, $properties['player_parameters']['height']);
+         $this->assertSame(100, $properties['player_parameters']['width']);
+     }
++
++    public function testGetReferenceUrl()
++    {
++        $media = new Media();
++        $media->setProviderReference('123456');
++        $this->assertEquals('http://www.youtube.com/watch?v=123456', $this->getProvider()->getReferenceUrl($media));
++    }
+ }",This is getting repetitive  maybe you could introduce an abstract test case with a `getExpectedUrl($providerReference)` method ?,Please use `assertSa
+419,"@@ -0,0 +1,5 @@
++package reflect
++
++func MakeFunc(typ Type, fn func(args []Value) (results []Value)) Value {
++	return Value{}
++}","I do not think returning `Value{}` is correct here. For example, `reflect.MakeFunc(...).Kind()` would return `reflect.Invalid` instead of `reflect.Func`. Therefore, I think this should panic instead.",Why do we need this 
+420,"@@ -73,7 +73,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
+ 	else if (name[0]==='o' && name[1]==='n') {
+ 		let useCapture = name !== (name=name.replace(/Capture$/, ''));
+ 		let nameLower = name.toLowerCase();
+-		name = (nameLower in dom ? nameLower : name).substring(2);
++		name = (nameLower in window ? nameLower : name).substring(2);
+ 
+ 		if (value) {
+ 			if (!oldValue) dom.addEventListener(name, eventProxy, useCapture);",Does this work for Custom Elements? iirc we're lacking test cases for them. /cc @andrewiggins @developit,Why is this change needed?
+421,"@@ -224,9 +224,7 @@ func (m *ipipManager) CompleteDeferredWork() error {
+ 		for _, ip := range m.activeHostnameToIP {
+ 			members = append(members, ip)
+ 		}
+-		for _, ip := range m.externalNodeCIDRs {
+-			members = append(members, ip)
+-		}
++		members = append(members, m.externalNodeCIDRs...)
+ 		m.ipsetsDataplane.AddOrReplaceIPSet(m.ipSetMetadata, members)
+ 		m.ipSetInSync = true
+ 	}",Same change just above?,Why this change?
+422,"@@ -35,7 +35,8 @@
+         // Promise() being missing on some legacy browser, and a funky one
+         // is Promise() present but buggy on WebOS 2
+         window.Promise = undefined;
+-        window.Promise = undefined;
++        /* eslint-disable-next-line no-restricted-globals -- Explicit check on self needed */
++        self.Promise = undefined;
+     }
+ 
+     if (!window.Promise) {",I suppose `apploader.js` isn't used by WebWorkers. So `self` will always be `window` here.,Why is this needed?
+423,"@@ -7,13 +7,7 @@ test_name ""bolt plan run should apply manifest block on remote hosts via ssh"" do
+   extend Acceptance::BoltCommandHelper
+ 
+   ssh_nodes = select_hosts(roles: ['ssh'])
+-  skip_targets = select_hosts(platform: [/debian-8/])
+   targets = ""ssh_nodes""
+-  if skip_targets.any?
+-    ssh_nodes -= skip_targets
+-    targets = ssh_nodes.each_with_object([]) { |node, acc| acc.push(node[:vmhostname]) }.join("","")
+-  end
+-
+   skip_test('no applicable nodes to test on') if ssh_nodes.empty?
+ 
+   dir = bolt.tmpdir('apply_ssh')",Since this var is no longer defined we should remove the `if skip_targets.any?` bit below.,Why is this being removed?
+424,"@@ -170,6 +170,12 @@ def func_arn(function_name):
+     return aws_stack.lambda_function_arn(function_name)
+ 
+ 
++def func_qualifier(function_name, qualifier=None):
++    arn = aws_stack.lambda_function_arn(function_name)
++    if ARN_TO_LAMBDA.get(arn).qualifier_exists(qualifier):
++        return '{}:{}'.format(arn, qualifier)
++
++
+ def check_batch_size_range(source_arn, batch_size=None):
+     batch_size_entry = BATCH_SIZE_RANGES.get(source_arn.split(':')[2].lower())
+     if not batch_size_entry:",I think we should `return arn` as a fallback at the end of this function (otherwise the `['Resource']` entry below could become `None`).,nit: `if ARN_TO_LAMBDA.get(arn).exists(qualifier)`
+425,"@@ -41,6 +41,11 @@ type NATProxy struct {
+ 
+ func (np *NATProxy) consumerHandOff(consumerPort int, remoteConn *net.UDPConn) chan struct{} {
+ 	stop := make(chan struct{})
++	if np.socketProtect == nil {
++		// shutdown pinger session since openvpn client will connect directly (without NATProxy)
++		remoteConn.Close()
++		return stop
++	}
+ 	go np.consumerProxy(consumerPort, remoteConn, stop)
+ 	return stop
+ }","Why session is started at all, if you need to shut it down e.g. DI should launch noopSession",Why do we need to close the connection here?
+426,"@@ -184,7 +184,7 @@ type describer interface {
+ }
+ 
+ type workspaceDeleter interface {
+-	DeleteAll() error
++	DeleteWorkspaceFile() error
+ }
+ 
+ type svcManifestReader interface {",nit: can we rename the interface to `wsFileDeleter`,Why is this change needed?
+427,"@@ -91,10 +91,10 @@ func hashRule(r *rule) string {
+ // It's the struct used by reconciler.
+ type CompletedRule struct {
+ 	*rule
+-	// Source Pods of this rule, can't coexist with ToAddresses.
+-	FromAddresses v1beta1.GroupMemberPodSet
+-	// Destination Pods of this rule, can't coexist with FromAddresses.
+-	ToAddresses v1beta1.GroupMemberPodSet
++	// Source GroupMembers of this rule, can't coexist with ToAddresses.
++	FromAddresses v1beta1.GroupMemberSet
++	// Destination GroupMembers of this rule, can't coexist with FromAddresses.
++	ToAddresses v1beta1.GroupMemberSet
+ 	// Target Pods of this rule.
+ 	Pods v1beta1.GroupMemberPodSet
+ }",Why target cannot be external endpoints?,Shouldn't this be `GroupMembers`?
+428,"@@ -127,4 +127,8 @@ public interface CollectionAdminParams {
+ 
+   /** Option to follow aliases when deciding the target of a collection admin command. */
+   String FOLLOW_ALIASES = ""followAliases"";
++
++  /** Prefix for automatically created config elements. */
++  String AUTO_PREFIX = "".auto_"";
++
+ }","We use a suffix "".AUTOCREATED"" for configsets, maybe we can use the same here?",Why do we need this?
+429,"@@ -27,7 +27,7 @@ namespace Samples
+         {
+             // Enable OpenTelemetry for the source ""MyCompany.MyProduct.MyWebServer""
+             // and use Console exporter
+-            OpenTelemetrySdk.Default.EnableOpenTelemetry(
++            OpenTelemetrySdk.EnableOpenTelemetry(
+                 (builder) => builder.AddActivitySource(""MyCompany.MyProduct.MyWebServer"")
+                 .UseConsoleActivityExporter(opt => opt.DisplayAsJson = options.DisplayAsJson));
+ ",This one won't be disposed. Should be (something like) `using var openTelemetry = OpenTelemetrySdk.EnableOpenTelemetry(` no?,Why did you change t
+430,"@@ -37,7 +37,7 @@ from logHandler import log
+ import UIAUtils
+ from comInterfaces import UIAutomationClient as UIA
+ # F403: unable to detect undefined names
+-from comInterfaces .UIAutomationClient import *  # noqa:  F403
++from comInterfaces.UIAutomationClient import *  # noqa:  F403
+ import textInfos
+ from typing import Dict
+ from queue import Queue",Why this is in the diff?,Why is this needed?
+431,"@@ -136,6 +136,8 @@ type QuiesceDriver interface {
+ type CloudBackupDriver interface {
+ 	// CloudBackupCreate uploads snapshot of a volume to the cloud
+ 	CloudBackupCreate(input *api.CloudBackupCreateRequest) error
++	// CloudBackupGroupCreate creates and then uploads volumegroup snapshots
++	CloudBackupGroupCreate(input *api.CloudBackupGroupCreateRequest) error
+ 	// CloudBackupRestore downloads a cloud backup and restores it to a volume
+ 	CloudBackupRestore(input *api.CloudBackupRestoreRequest) (*api.CloudBackupRestoreResponse, error)
+ 	// CloudBackupEnumerate enumerates the backups for a given cluster/credential/volumeID",How is status determined? When the user calls CloudBackupCreate( src_volume_id ) they can then call CloudBackupStatus( src_volume_id ) Is there something similar for this new API?,I think this should 
+432,"@@ -232,6 +232,15 @@ export function diff(
+ 
+ 		if ((tmp = options.diffed)) tmp(newVNode);
+ 	} catch (e) {
++		// When we are hydrating and have excessDomChildren we don't know the _children this VNode
++		// should receive so it's safer to unmount them. Else on the subsequent error-boundary diff,
++		// we won't know the oldDom and insert an additional node instead of replace the prerendered one. (#2539)
++		if (isHydrating && excessDomChildren != null) {
++			for (tmp = excessDomChildren.length; tmp--; ) {
++				if (excessDomChildren[tmp] != null) removeNode(excessDomChildren[tmp]);
++			}
++		}
++
+ 		newVNode._original = null;
+ 		options._catchError(e, newVNode, oldVNode);
+ 	}",We could pass `excessDomChildren` to `options._catchError` and only do this if an error-boundary catches the error. Not entirely sure if that's better.,"I don't think this is the right place to do this. If we are hydrating and excessDomChildren is null, then we don't know the oldDom and insert an additional node instead of replacing it."
+433,"@@ -464,7 +464,7 @@ class CombineAssets
+      */
+     protected function setHashOnCombinerFilters($hash)
+     {
+-        $allFilters = call_user_func_array('array_merge', $this->getFilters());
++        $allFilters = array_merge(...array_values($this->getFilters()));
+ 
+         foreach ($allFilters as $filter) {
+             if (method_exists($filter, 'setHash')) {",In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or call_user_func_array() etc.,`array_merge(...array_values($this->getFilters()));` should be enough
+434,"@@ -82,6 +82,9 @@ func (b3 B3) Extract(ctx context.Context, supplier propagation.HTTPSupplier) con
+ 	} else {
+ 		sc = b3.extract(supplier)
+ 	}
++	if !sc.IsValid() {
++		return ctx
++	}
+ 	return ContextWithRemoteSpanContext(ctx, sc)
+ }
+ ","If instead we had `B3.extractSingleHeader` and `B3.extract` return a bool value as a second return value, we could avoid the byte array comparison in `TraceID.IsValid`. Did you consider that alternative?",Why do we need this check?
+435,"@@ -56,7 +56,7 @@ return [
+         'choose_file' => 'Datei auswählen',
+         'close' => 'Schließen',
+         'create' => 'Erstellen',
+-        'create_and_add_another' => 'Erstellen und weiter hinzufügen',
++        'create_and_add_another' => 'Erstellen und weitere hinzufügen',
+         'create_and_continue' => 'Erstellen und weiter bearbeiten',
+         'save' => 'Speichern',
+         'save_and_continue' => 'Speichern und weiter bearbeiten',",I think this is more of a semantic difference than a typo - `weiter hinzufgen` is like `continue adding` whereas `weitere hinzufgen` is like `add more`. I think it makes sense to change it though  ,Why did you change this?
+436,"@@ -227,3 +227,12 @@ class RecordsViewTest(BaseWebTest, unittest.TestCase):
+                      MINIMALIST_RECORD,
+                      headers=headers,
+                      status=200)
++
++    def test_records_can_be_created_after_deletion(self):
++        self.app.delete(self.record_url,
++                        headers=self.headers,
++                        status=200)
++        headers = self.headers.copy()
++        headers['If-None-Match'] = '*'
++        self.app.put_json(self.record_url, MINIMALIST_RECORD,
++                          headers=headers, status=201)",nit: 200 is superfluous,I think this should be `If-None-Match`
+437,"@@ -246,7 +246,7 @@ TEST_F(SchemaTest, metaCommunication) {
+     // Test unreserved keyword
+     {
+         cpp2::ExecutionResponse resp;
+-        std::string query = ""CREATE TAG upper(name string, EMAIL string, ""
++        std::string query = ""CREATE TAG upper(name string, email string, ""
+                             ""age int, gender string, row_timestamp timestamp)"";
+         auto code = client->execute(query, resp);
+         ASSERT_EQ(cpp2::ErrorCode::SUCCEEDED, code);",This is testing `unreserved keyword`,Why did you change this?
+438,"@@ -829,6 +829,10 @@ static const MethodMapping projectionMethodMappings[] = {
+ 
+     {PROJ_WKT2_NAME_METHOD_QUADRILATERALIZED_SPHERICAL_CUBE, 0,
+      ""Quadrilateralized_Spherical_Cube"", ""qsc"", nullptr, paramsNatOrigin},
++    
++    {PROJ_WKT2_NAME_METHOD_S2, 0,
++     ""S2"", ""s2"", nullptr, paramsNatOrigin},
++
+ 
+     {PROJ_WKT2_NAME_METHOD_SPHERICAL_CROSS_TRACK_HEIGHT, 0,
+      ""Spherical_Cross_Track_Height"", ""sch"", nullptr, paramsSch},",paramsNatOrigin doesn't include sUVtoST. I would just remove that definition for now,I think this should be named `Spherica
+439,"@@ -71,9 +71,15 @@ func makeKMD() KeyMetadata {
+ 	return emptyKeyMetadata{tlf.FakeID(0, tlf.Private), 1}
+ }
+ 
++func initBlockRetrievalQueueTest(t *testing.T) *blockRetrievalQueue {
++	q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))
++	<-q.TogglePrefetcher(false, nil)
++	return q
++}
++
+ func TestBlockRetrievalQueueBasic(t *testing.T) {
+ 	t.Log(""Add a block retrieval request to the queue and retrieve it."")
+-	q := newBlockRetrievalQueue(0, 0, newTestBlockRetrievalConfig(t, nil, nil))
++	q := initBlockRetrievalQueueTest(t)
+ 	require.NotNil(t, q)
+ 	defer q.Shutdown()
+ ","It feels like the test should be waiting for the prefetcher to shut down, but I don't have a great reason why other than that it might be confusing for debugging if there are still goroutines from old prefetchers lying. But I guess since `TogglePrefetcher(false)` doesn't actually set the prefetcher to nil, the queue shutdown method will still end up waiting for the shutdown to finish. If that sounds right, nevermind me.",nit: `return q` would be clearer.
+440,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[ListAccessKeys.java demonstrates how to list access keys associated with an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[ListAccessKeys.java demonstrates how to list access keys associated with an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I don't think this change is necessary.
+441,"@@ -34,6 +34,7 @@ class LoadProjectsCloudsqlPipeline(base_pipeline.BasePipeline):
+     """"""Pipeline to load project CloudSql data into Inventory.""""""
+ 
+     PROJECTS_RESOURCE_NAME = 'project_iam_policies'
++    RESOURCE_NAME = 'cloudsql'
+     RESOURCE_NAME_INSTANCES = 'cloudsql_instances'
+     RESOURCE_NAME_IPADDRESSES = 'cloudsql_ipaddresses'
+     RESOURCE_NAME_AUTHORIZEDNETWORKS = (  # pylint: disable=invalid-name","As a long term thing, would it make sense to move the resource names as keys under the requirements map?",Why do we need this?
+442,"@@ -57,7 +57,7 @@ function traverseForHeaders(headerType, position, tableGrid) {
+  * @return {Array<HTMLTableCellElement>} Array of headers associated to the table cell
+  */
+ table.getHeaders = function(cell, tableGrid) {
+-	if (cell.hasAttribute('headers')) {
++	if (cell.getAttribute('headers')) {
+ 		return commons.dom.idrefs(cell, 'headers');
+ 	}
+ 	if (!tableGrid) {","That doesn't fix the whole problem. The issue lays in this line right here, not the one above. There are two problems with this line: 1. It finds things that aren't cells in the table 2. if it doesn't find anything, it shouldn't return empty here, but continue down to look for row/ column headers.",Why is this change needed?
+443,"@@ -38,7 +38,9 @@ public class NoUnusedPinCheckTask extends DefaultTask {
+ 
+     @Input
+     public final Set<String> getResolvedArtifacts() {
+-        return BaselineVersions.getResolvedArtifacts(getProject());
++        return getProject().getAllprojects().stream()
++                .flatMap(project -> BaselineVersions.getResolvedArtifacts(project).stream())
++                .collect(Collectors.toSet());
+     }
+ 
+     @InputFile",I am pretty sure that this is infinite recursion as getAllProjects returns the project itself.,I think you can use `getProject().getRe
+444,"@@ -268,6 +268,7 @@ Blockly.Categories = {
+   ""sound"": ""sounds"",
+   ""pen"": ""pen"",
+   ""data"": ""data"",
++  ""dataLists"": ""data-lists"",
+   ""event"": ""events"",
+   ""control"": ""control"",
+   ""sensing"": ""sensing"",","Something I didn't catch before I merged this PR, is the hyphenated constant a problem? E.g. should ""data-lists"" be ""data_lists""? @paulkaplan",I think this should be `data-lists`
+445,"@@ -248,3 +248,7 @@ L2socket: use the provided L2socket
+ 
+ import scapy.sendrecv
+ scapy.sendrecv.sniff = sniff
++
++# If wpcap.dll is not available
++if (not conf.use_winpcapy) and (not conf.use_pcap) and (not conf.use_dnet):
++    from scapy.arch.windows.disable_sendrecv import *",Can you write the test as `if not (conf.use_winpcapy or conf.use_pcap or conf.use_dnet):`,I don't think this is needed.
+446,"@@ -23,6 +23,8 @@ class _Repository:
+         self.description = check.opt_str_param(description, ""description"")
+ 
+     def __call__(self, fn: Callable[[], Any]) -> RepositoryDefinition:
++        from dagster.core.asset_defs import ForeignAsset
++
+         check.callable_param(fn, ""fn"")
+ 
+         if not self.name:",we have to include foreign assets on the repository directly because they don't belong to a job? This seems very awkward... Is this a step towards the job-less assets on the repository? Did you consider having `build_asset_job` take in a set of foreign assets instead? I suppose we would then need to subclass it to be a more special `AssetJobDefinition` that can keep track of them.,Why is this import needed?
+447,"@@ -14,8 +14,7 @@ TempDir::TempDir(const char* pathTemplate, bool deleteOnDestroy)
+         : deleteOnDestroy_(deleteOnDestroy) {
+     auto len = strlen(pathTemplate);
+     std::unique_ptr<char[]> name(new char[len + 1]);
+-    strncpy(name.get(), pathTemplate, len);
+-    name.get()[len] = '\0';
++    strcpy(name.get(), pathTemplate);
+ 
+     VLOG(2) << ""Trying to create the temp directory with pattern \""""
+             << name.get() << ""\"""";","`-Wstringop-truncation` is a new kind of error detector introduced in GCC 8. As for this patch, these are two false-positives though.",Why did you remove this line?
+448,"@@ -36,7 +36,7 @@ const (
+ 
+ // ErrSharedConfigSourceCollision will be returned if a section contains both
+ // source_profile and credential_source
+-var ErrSharedConfigSourceCollision = awserr.New(ErrCodeSharedConfig, ""only source profile or credential source can be specified, not both"", nil)
++var ErrSharedConfigSourceCollision = awserr.New(ErrCodeSharedConfig, ""only one credential type may be specified per profile: source profile, credential source, credential process, web identity token, or sso"", nil)
+ 
+ // ErrSharedConfigECSContainerEnvVarEmpty will be returned if the environment
+ // variables are empty and Environment was set as the credential source","Can we port this error msg to v2 too? This one is better, as it explicitly states what sources are allowed.",// ErrSharedConfigSourceCollision will be returned if a section contains both
+449,"@@ -3,6 +3,7 @@
+ var f = require('util').format;
+ var test = require('./shared').assert;
+ var setupDatabase = require('./shared').setupDatabase;
++const { ReadPreference } = require('../..');
+ const Db = require('../../lib/db');
+ const expect = require('chai').expect;
+ ",The convention so far has been to require directly from the defining file (in this case `../../read_preference') . I think the concern has been mostly about the potential for circular dependency cycles,Why do we need this?
+450,"@@ -10,8 +10,9 @@ from ..registry import PIPELINES
+ @PIPELINES.register_module
+ class LoadImageFromFile(object):
+ 
+-    def __init__(self, to_float32=False):
++    def __init__(self, to_float32=False, color_type='color'):
+         self.to_float32 = to_float32
++        self.color_type = color_type
+ 
+     def __call__(self, results):
+         if results['img_prefix'] is not None:",I suggest expanding dims here to simplify the formatting.,`color_type` should be `None` by default
+451,"@@ -9,7 +9,7 @@ from pyramid.paster import bootstrap
+ 
+ from kinto.config import init
+ 
+-CONFIG_FILE = 'config/kinto.ini'
++CONFIG_FILE = 'kinto/config/kinto.ini'
+ 
+ 
+ def main(args=None):",Why do you need to specify the kinto prefix here?,Why this change?
+452,"@@ -45,7 +45,7 @@ class FPN(nn.Module):
+         >>> self = FPN(in_channels, 11, len(in_channels)).eval()
+         >>> outputs = self.forward(inputs)
+         >>> for i in range(len(outputs)):
+-        ...     print('outputs[{}].shape = {!r}'.format(i, outputs[i].shape))
++        ...     print(f'outputs[{i}].shape = {outputs[i].shape!r}')
+         outputs[0].shape = torch.Size([1, 11, 340, 340])
+         outputs[1].shape = torch.Size([1, 11, 170, 170])
+         outputs[2].shape = torch.Size([1, 11, 84, 84])",The `!r` is unnecessary.,Why did you change this?
+453,"@@ -161,7 +161,7 @@ func (o *lazyCredsOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.
+ 
+ 		isMSIEnvironment := adal.MSIAvailable(ctx, adal.CreateSender())
+ 
+-		if accountKey != """" {
++		if accountKey != """" || sasToken != """" {
+ 			o.opener, o.err = openerFromEnv(accountName, accountKey, sasToken, storageDomain, protocol)
+ 		} else if isMSIEnvironment {
+ 			o.opener, o.err = openerFromMSI(accountName, storageDomain, protocol)",I didn't see existing tests for this `OpenBucketURL`. Not sure if it's easy to do without mocking these `opener` calls.,I don't think we need to
+454,"@@ -21,6 +21,8 @@ namespace AutoRest.Go.TemplateModels
+         // (null or empty if the model is not paged).
+         public string NextLink;
+ 
++        public bool PreparerNeeded;
++
+         public ModelTemplateModel(CompositeType source)
+         {
+             this.LoadFrom(source);",Should we default to `true` ?,Why do we need this?
+455,"@@ -15,6 +15,7 @@ import (
+ 	uconfig ""go.uber.org/config""
+ 
+ 	""github.com/iotexproject/iotex-core/address""
++	""github.com/iotexproject/iotex-core/consensus/fsm""
+ 	""github.com/iotexproject/iotex-core/crypto""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ )",File is not `goimports`-ed (from `goimports`),nit: remove empty line
+456,"@@ -54,11 +54,14 @@ const rules = [
+ 		use: [
+ 			{
+ 				loader: 'babel-loader',
+-				query: {
+-					presets: [ [ '@babel/env', {
+-						useBuiltIns: 'entry',
+-						corejs: 2,
+-					} ], '@babel/preset-react' ],
++				options: {
++					babelrc: false,
++					configFile: false,
++					cacheDirectory: true,
++					presets: [
++						'@wordpress/default',
++						'@babel/preset-react',
++					],
+ 				},
+ 			},
+ 			{","Shouldn't these options also include `@babel/preset-env`? Also I see you set `babelrc` to `false`, could we rely on our existing `.babelrc` file? Feels like some duplicate configuration otherwise.",Why do we need this?
+457,"@@ -1609,7 +1609,7 @@ func (wn *WebsocketNetwork) removePeer(peer *wsPeer, reason disconnectReason) {
+ 	// first logging, then take the lock and do the actual accounting.
+ 	// definitely don't change this to do the logging while holding the lock.
+ 	localAddr, _ := wn.Address()
+-	wn.log.With(""event"", ""Disconnected"").With(""remote"", peer.rootURL).With(""local"", localAddr).Infof(""Peer %v disconnected"", peer.rootURL)
++	wn.log.With(""event"", ""Disconnected"").With(""remote"", peer.rootURL).With(""local"", localAddr).Infof(""Peer %v disconnected: %v"", peer.rootURL, reason)
+ 	peerAddr := peer.OriginAddress()
+ 	// we might be able to get addr out of conn, or it might be closed
+ 	if peerAddr == """" && peer.conn != nil {",Nit: We can use `%s` since `disconnectReason` is a string.,I don't think we nee
+458,"@@ -17,7 +17,8 @@ X_test = df_test.drop(0, axis=1).values
+ 
+ print('Start training...')
+ # train
+-gbm = lgb.LGBMRegressor(objective='regression',
++gbm = lgb.LGBMRegressor(boosting_type='rgf',
++                        objective='regression',
+                         num_leaves=31,
+                         learning_rate=0.05,
+                         n_estimators=20)",I think it's better to create a new example,why is this needed?
+459,"@@ -392,7 +392,7 @@ void ResolveOperation(Action &action, const RENDER_PASS_STATE &rp_state, const V
+ 
+         if (aspect_mask) {
+             action(aspect_string, ""resolve read"", src_at, dst_at, attachment_views[src_at],
+-                   SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_READ, kDepthStencilAttachmentRasterOrder, offset, extent,
++                   SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_READ, kAttachmentRasterOrder, offset, extent,
+                    aspect_mask);
+             action(aspect_string, ""resolve write"", src_at, dst_at, attachment_views[dst_at],
+                    SYNC_COLOR_ATTACHMENT_OUTPUT_COLOR_ATTACHMENT_WRITE, kAttachmentRasterOrder, offset, extent, aspect_mask);","The stages are correct, but the more forgiving `kAttachmentRasterOrder` should be used, based on a review of the spec. That should give the same effect of suppressing the false positive conflict between the DEPTH R/W and resolve. > End-of-subpass multisample resolves are treated as color attachment writes for the purposes of synchronization. This applies to resolve operations for both color and depth/stencil attachments. That is, they are considered to execute in the VK_PIPELINE_STAGE_COLOR_ATTACHMENT_OUTPUT_BIT pipeline stage and their writes are synchronized with VK_ACCESS_COLOR_ATTACHMENT_WRITE_BIT. Synchronization between rendering within a subpass and any resolve operations at the end of the subpass occurs automatically, without need for explicit dependencies or pipeline barriers.",Why did you change t
+460,"@@ -64,7 +64,7 @@ class AcidBasePair(object):
+ #: Administration Substance Registration System Standard Operating Procedure guide.
+ ACID_BASE_PAIRS = (
+     AcidBasePair('-OSO3H', 'OS(=O)(=O)[OH]', 'OS(=O)(=O)[O-]'),
+-    AcidBasePair('–SO3H', '[!O]S(=O)(=O)[OH]', '[!O]S(=O)(=O)[O-]'),
++    AcidBasePair('--SO3H', '[!O]S(=O)(=O)[OH]', '[!O]S(=O)(=O)[O-]'),
+     AcidBasePair('-OSO2H', 'O[SD3](=O)[OH]', 'O[SD3](=O)[O-]'),
+     AcidBasePair('-SO2H', '[!O][SD3](=O)[OH]', '[!O][SD3](=O)[O-]'),
+     AcidBasePair('-OPO3H2', 'OP(=O)([OH])[OH]', 'OP(=O)([OH])[O-]'),","To be consistent, I think it should actually just be a single `-`",Why did you change this?
+461,"@@ -6,6 +6,7 @@ import yaml
+ 
+ from datetime import datetime
+ from listenbrainz.utils import escape, convert_to_unix_timestamp
++from flask import current_app
+ 
+ def flatten_dict(d, seperator='', parent_key=''):
+     """"""",this seems extraneous.,from flask import curren
+462,"@@ -795,7 +795,7 @@ func (s *Suite) Define() {
+ 			By(""Sanity-check the issued Certificate"")
+ 			err = f.Helper().ValidateCertificate(f.Namespace.Name, ""testcert"", validations...)
+ 			Expect(err).NotTo(HaveOccurred())
+-		}, featureset.OnlySAN)
++		}, featureset.OnlySAN, featureset.LongDomainFeatureSet)
+ 
+ 		s.it(f, ""should allow updating an existing certificate with a new DNS Name"", func(issuerRef cmmeta.ObjectReference) {
+ 			testCertificate := &cmapi.Certificate{","Ah, I see here that 'LongDomain' is defined as something that contains a subdomain segment that is `maxLengthOfDomainSegment` long (which I think is 63 characters) - I don't think any public ACME servers/Let's Encrypt's staging environment has a restriction on this?   if it does, and the 'pebble' based ACME server does not, then Pebble needs modifying to also fail in these cases as it aims to replicate the ACME RFC as closely as possible",Why do we need this chan
+463,"@@ -112,12 +112,13 @@ module Travis
+                   'cdbs qpdf texinfo libssh2-1-dev devscripts '\
+                   ""#{optional_apt_pkgs}"", retry: true
+ 
+-                r_filename = ""R-#{r_version}-$(lsb_release -cs).xz""
+-                r_url = ""https://travis-ci.rstudio.org/#{r_filename}""
++                r_filename = ""r-#{r_version}_1_amd64.deb""
++                os_version = ""$(lsb_release -rs | tr -d '.')""
++                r_url = ""https://cdn.rstudio.com/r/ubuntu-#{os_version}/pkgs/#{r_filename}""
+                 sh.cmd ""curl -fLo /tmp/#{r_filename} #{r_url}"", retry: true
+-                sh.cmd ""tar xJf /tmp/#{r_filename} -C ~""
+-                sh.export 'PATH', ""${TRAVIS_HOME}/R-bin/bin:$PATH"", echo: false
+-                sh.export 'LD_LIBRARY_PATH', ""${TRAVIS_HOME}/R-bin/lib:$LD_LIBRARY_PATH"", echo: false
++                sh.cmd ""sudo apt-get install gdebi-core""
++                sh.cmd ""sudo gdebi r-#{r_version}_1_amd64.deb""
++                sh.export 'PATH', ""/opt/R/#{r_version}/bin:$PATH"", echo: false
+                 sh.rm ""/tmp/#{r_filename}""
+ 
+                 sh.cmd ""sudo mkdir -p /usr/local/lib/R/site-library $R_LIBS_USER""",I think you need `-y` here to prevent a user confirmation prompt,I think this should be `
+464,"@@ -100,6 +100,7 @@ bool dynamo_heap_initialized = false;
+ bool dynamo_started = false;
+ bool automatic_startup = false;
+ bool control_all_threads = false;
++bool dynamo_avx512_code_in_use = false;
+ #ifdef WINDOWS
+ bool dr_early_injected = false;
+ int dr_early_injected_location = INJECT_LOCATION_Invalid;","Repeating: I don't think this should be a core-wide global var. This should be isolated to arch/x86 or at least arch/, maybe inside getter/setters as mentioned above.",Why do we need this variable?
+465,"@@ -55,8 +55,11 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister):
+     """"""
+     MIRRORS_SOURCE = ""https://archive.apache.org/dist/jmeter/binaries/""
+     JMETER_DOWNLOAD_LINK = ""https://archive.apache.org/dist/jmeter/binaries/apache-jmeter-{version}.zip""
++    PLUGINS_MANAGER = 'https://repo1.maven.org/maven2/kg/apc/jmeter-plugins-manager/0.8/jmeter-plugins-manager-0.8.jar'
++    CMDRUNNER = 'http://search.maven.org/remotecontent?filepath=kg/apc/cmdrunner/2.0/cmdrunner-2.0.jar'
++    PLUGINS = [""jpgc-casutg"", ""jpgc-dummy"", ""jpgc-ffw"", ""jpgc-fifo"", ""jpgc-functions"",
++               ""jpgc-json"", ""jpgc-perfmon"", ""jpgc-prmctl"", ""jpgc-tst""]
+     JMETER_VER = ""3.0""
+-    PLUGINS_DOWNLOAD_TPL = ""http://jmeter-plugins.org/files/JMeterPlugins-{plugin}-1.4.0.zip""
+     UDP_PORT_NUMBER = None
+ 
+     def __init__(self):","right URL is like in cmdrunner, using search.maven .org",I'm not sure if this is the r
+466,"@@ -32,9 +32,9 @@ namespace OpenTelemetry.Exporter
+ #if NETSTANDARD2_1
+         /// <summary>
+         /// Gets or sets the target to which the exporter is going to send traces or metrics.
+-        /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md.
++        /// The valid syntax is described at https://github.com/grpc/grpc/blob/master/doc/naming.md. The endpoint value should start with http or https.
+         /// </summary>
+-        public Uri Endpoint { get; set; } = new Uri(""http://localhost:4317"");
++        public string Endpoint { get; set; } = ""http://localhost:4317"";
+ #else
+         /// <summary>
+         /// Gets or sets the target to which the exporter is going to send traces or metrics.","The link to valid syntax is not really applicable for NET2_1, right?",Why is this change needed?
+467,"@@ -16,6 +16,13 @@
+ // PubSub. Use OpenTopic to construct a *pubsub.Topic, and/or OpenSubscription
+ // to construct a *pubsub.Subscription.
+ //
++// Escaping
++//
++// Go CDK supports all UTF-8 strings; some strings are escaped (during writes)
++// and unescaped (during reads) to ensure compatibility with the provider:
++//  - Metadata keys: No escaping required.
++//  - Metadata values: No escaping required.
++//
+ // As
+ //
+ // gcspubsub exposes the following types for As:","Shouldn't it be more specific, like ""gcppubsub supports all UTF-8 strings""?",I don't think we need this.
+468,"@@ -59,14 +59,14 @@ public class CdcrReplicationHandlerTest extends BaseCdcrDistributedZkTest {
+   }
+ 
+   /**
+-   * Test the scenario where the slave is killed from the start. The replication
++   * Test the scenario where the secondary is killed from the start. The replication
+    * strategy should fetch all the missing tlog files from the leader.
+    */
+   @Test
+   @ShardsFixed(num = 2)
+   public void testFullReplication() throws Exception {
+-    List<CloudJettyRunner> slaves = this.getShardToSlaveJetty(SOURCE_COLLECTION, SHARD1);
+-    slaves.get(0).jetty.stop();
++    List<CloudJettyRunner> secondaries = this.getShardToSecondaryJetty(SOURCE_COLLECTION, SHARD1);
++    secondaries.get(0).jetty.stop();
+ 
+     for (int i = 0; i < 10; i++) {
+       List<SolrInputDocument> docs = new ArrayList<>();","Everything in this class is SolrCloud-related, not legacy replication",I think it would be better to rename the variable to `secondaries`.
+469,"@@ -1122,15 +1122,8 @@ drbbdup_prepare_redirect(dr_mcontext_t *mcontext, drbbdup_manager_t *manager,
+ {
+     /* Restore flags and scratch reg to their original app values. */
+     if (!manager->are_flags_dead) {
+-        reg_t val;
+-        uint sahf;
+-        reg_t newval = mcontext->xflags;
+-        val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT);
+-        sahf = (val & 0xff00) >> 8;
+-        newval &= ~(EFLAGS_ARITH);
+-        newval |= sahf;
+-        if (TEST(1, val)) /* seto */
+-            newval |= EFLAGS_OF;
++        reg_t val = (reg_t)drbbdup_get_tls_raw_slot_val(DRBBDUP_FLAG_REG_SLOT);
++        reg_t newval = dr_merge_arith_flags(mcontext->xflags, val);
+         mcontext->xflags = newval;
+     }
+     if (!manager->is_scratch_reg_dead) {",Could just assign directly and eliminate the `newval` var.,I think this should be `dr_merge_arith_flags`
+470,"@@ -27,11 +27,13 @@ import (
+ const (
+ 	inProgressLabel            = ""in progress""
+ 	issueTitleComment          = ""Please edit the title of this issue with the name of the affected package, followed by a colon, followed by a short summary of the issue. Example: `blob/gcsblob: not blobby enough`.""
++	pullRequestTitleComment    = ""Please edit the title of this pull request with the name of the affected package, followed by a colon, followed by a short summary of the change. Example: `blob/gcsblob: improve comments`.""
+ 	branchesInForkCloseComment = ""Please create pull requests from your own fork instead of from branches in the main repository. Also, please delete this branch.""
+ )
+ 
+ var (
+-	issueTitleRegexp = regexp.MustCompile(""^[a-z0-9/]+: .*$"")
++	issueTitleRegexp       = regexp.MustCompile(""^[a-z0-9/]+: .*$"")
++	pullRequestTitleRegexp = issueTitleRegexp
+ )
+ 
+ // issueData is information about an issue event.","... with the name of the affected package, or ""all"", followed by a colon,...",I think this should be `pullRequestTitleComment`.
+471,"@@ -48,6 +48,10 @@ namespace PrepareRelease
+                 ""src/Datadog.Trace.ClrProfiler.Managed/Datadog.Trace.ClrProfiler.Managed.csproj"",
+                 NugetVersionReplace);
+ 
++            SynchronizeVersion(
++                ""src/Datadog.Trace.ClrProfiler.Managed.Core/Datadog.Trace.ClrProfiler.Managed.Core.csproj"",
++                NugetVersionReplace);
++
+             SynchronizeVersion(
+                 ""src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt"",
+                 text => FullVersionReplace(text, "".""));",We'll want to remove this one if we make the assembly version constant.,Why do we need this?
+472,"@@ -51,6 +51,7 @@ class Frontend extends Generator {
+ 		$this->setup_blog_colors();
+ 		$this->setup_form_fields_style();
+ 		$this->setup_single_post_style();
++		$this->setup_single_page_style();
+ 	}
+ 
+ 	/**",Can we have a single function here that uses the same subscribers and just changes meta based on context?,Should this be `setup_single_page_style`?
+473,"@@ -513,8 +513,9 @@ hsa_executable_t load_executable(const string& file, hsa_executable_t executable
+     return executable;
+ }
+ 
+-// To force HIP to load the kernels and to setup the function
+-// symbol map on program startup
++// HIP startup kernel loader logic
++// When enabled HIP_STARTUP_LOADER, HIP will load the kernels and setup
++// the function symbol map on program startup
+ class startup_kernel_loader {
+    private:
+     startup_kernel_loader() { functions(); }",where would ` static startup_kernel_loader skl;` be instantiated? if it's not instantiated anywhere should this be removed?,"""HIP will load kernels and setup the func"
+474,"@@ -0,0 +1,14 @@
++const webkitGetAsEntryApi = require('./utils/webkitGetAsEntryApi')
++const getFilesAndDirectoriesApi = require('./utils/getFilesAndDirectoriesApi')
++const fallbackApi = require('./utils/fallbackApi')
++
++module.exports = function getDroppedFiles (dataTransfer, callback) {
++  if (dataTransfer.items[0] && 'webkitGetAsEntry' in dataTransfer.items[0]) {
++    webkitGetAsEntryApi(dataTransfer, callback)
++  } else if ('getFilesAndDirectories' in dataTransfer) {
++    // Doesn't actually work in firefox, maybe in previous versions. webkitGetAsEntryApi() works.
++    getFilesAndDirectoriesApi(dataTransfer, callback)
++  } else {
++    fallbackApi(dataTransfer, callback)
++  }
++}","I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module.",I don't think this is the right place for
+475,"@@ -732,12 +732,6 @@ func (m *Volume) Contains(mid string) bool {
+ // Copy makes a deep copy of VolumeSpec
+ func (s *VolumeSpec) Copy() *VolumeSpec {
+ 	spec := *s
+-	if s.VolumeLabels != nil {
+-		spec.VolumeLabels = make(map[string]string)
+-		for k, v := range s.VolumeLabels {
+-			spec.VolumeLabels[k] = v
+-		}
+-	}
+ 	if s.ReplicaSet != nil {
+ 		spec.ReplicaSet = &ReplicaSet{Nodes: make([]string, len(s.ReplicaSet.Nodes))}
+ 		copy(spec.ReplicaSet.Nodes, s.ReplicaSet.Nodes)",Migrate the spec.Labels to locator.Labels ?,Why is this being removed?
+476,"@@ -250,7 +250,7 @@ func TestS3_EmptyBucket(t *testing.T) {
+ 
+ 			gotErr := service.EmptyBucket(tc.inBucket)
+ 
+-			if gotErr != nil {
++			if tc.wantErr != nil {
+ 				require.EqualError(t, gotErr, tc.wantErr.Error())
+ 			}
+ 		})",The test case already existed but it never tested properly because of the conditional in the test.,"`require.NoError(t, gotErr)` would be better."
+477,"@@ -68,11 +68,9 @@ public class PartitionField implements Serializable {
+     }
+ 
+     PartitionField that = (PartitionField) other;
+-    return (
+-        sourceId == that.sourceId &&
++    return sourceId == that.sourceId &&
+         name.equals(that.name) &&
+-        transform.equals(that.transform)
+-    );
++        transform.equals(that.transform);
+   }
+ 
+   @Override","I'm okay with this, but I don't see a lot of benefit to removing unnecessary parens. If extra parens make something more readable (like this) or clarify order of operations even when matching the default, I would say we should keep them.",Why did you change this?
+478,"@@ -138,7 +138,7 @@ public class IndexSchema {
+ 
+   protected List<SchemaField> fieldsWithDefaultValue = new ArrayList<>();
+   protected Collection<SchemaField> requiredFields = new HashSet<>();
+-  protected volatile DynamicField[] dynamicFields;
++  protected DynamicField[] dynamicFields = new DynamicField[] {};
+   public DynamicField[] getDynamicFields() { return dynamicFields; }
+ 
+   protected Map<String, SchemaField> dynamicFieldCache = new ConcurrentHashMap<>();",@sarowe why was this volatile? It's fishy to see this as the only volatile field.,Why this change?
+479,"@@ -0,0 +1,13 @@
++package org.apache.servicecomb.serviceregistry.task.event;
++
++/**
++ * 一句话功能简述
++ * 功能详细描述
++ * @author m00416667
++ * @version [版本号, ]
++ * @see  [相关类/方法]
++ * @since [产品/模块版本]
++ * Package Name:org.apache.servicecomb.serviceregistry.task.event
++ */
++public class InstanceRegistryFailedEvent {
++}",template is not correct?,Missing license header.
+480,"@@ -0,0 +1,4 @@
++from mmdet.utils import Registry
++
++ASSIGNERS = Registry('assigner')
++SAMPLERS = Registry('sampler')",Rename the registies to `BBOX_ASSIGNERS` and `BBOX_SAMPLERS` to avoid ambiguity. There is also a registry for dataset sampler.,Why do we need this?
+481,"@@ -89,9 +89,7 @@ module Beaker
+     describe ""provisioning and cleanup"" do
+ 
+       before :each do
+-        vagrant.should_receive( :make_vfile ).with( @hosts ).once
+-
+-        vagrant.should_receive( :vagrant_cmd ).with( ""destroy --force"" ).once
++        FakeFS.activate!
+         vagrant.should_receive( :vagrant_cmd ).with( ""up"" ).once
+         @hosts.each do |host|
+           host_prev_name = host['user']","This is no longer stubbed on every test. Perhaps it should be, and should be unstubbed in the single case that it matters.",Why did you remove t
+482,"@@ -188,6 +188,11 @@ module BoltServer
+       [200, GC.stat.to_json]
+     end
+ 
++    get '/admin/status' do
++      stats = Puma.stats
++      [200, stats.is_a?(Hash) ? stats.to_json : stats]
++    end
++
+     get '/500_error' do
+       raise 'Unexpected error'
+     end",This seems much simpler! I'm not sure I follow what you mean by the threading part... Also tests are not liking this constant. Might need a require or to fully qualify this.,I think this should 
+483,"@@ -5902,6 +5902,7 @@ os_forge_exception(app_pc target_pc, dr_exception_type_t type)
+     switch (type) {
+     case ILLEGAL_INSTRUCTION_EXCEPTION: sig = SIGILL; break;
+     case UNREADABLE_MEMORY_EXECUTION_EXCEPTION: sig = SIGSEGV; break;
++    case SINGLE_STEP_EXCEPTION: ASSERT_NOT_IMPLEMENTED(false); /* cf i#2144 */
+     case IN_PAGE_ERROR_EXCEPTION: /* fall-through: Windows only */
+     default: ASSERT_NOT_REACHED(); sig = SIGSEGV; break;
+     }","Convention is ""FIXME: i#2144"" or ""XXX: i#2144""",Why do we need this?
+484,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface IHasHttpMethod
++    {
++        string GetHttpMethod();
++    }
++}",This should probably be a property instead of a method.,Why do we need this interface?
+485,"@@ -159,10 +159,12 @@ spec:
+     status:
+       phase: Init
+     versionDetails:
+-      current: {{ .CAST.version }}
++      status:
++        current: {{ .CAST.version }}
++        dependentsUpgraded: true
++        state: RECONCILED
+       desired: {{ .CAST.version }}
+       autoUpgrade: false
+-      dependentsUpgraded: true
+ ---
+ apiVersion: openebs.io/v1alpha1
+ kind: RunTask","do we need to consider setting the `state` as well? If so, lot of changes might be required, like, setting to 'Reconciling' in upgrade code, setting to 'error' or 'reconciled' in volumeReconciler functions.",Why do we need this?
+486,"@@ -3,7 +3,11 @@ module Blacklight::Solr
+     extend ActiveSupport::Concern
+ 
+     included do
+-      self.default_processor_chain = [:default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr, :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr, :add_sorting_to_solr, :add_group_config_to_solr ]
++      self.default_processor_chain = [
++        :default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr,
++        :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr,
++        :add_sorting_to_solr, :add_group_config_to_solr, :add_facet_paging_to_solr
++      ]
+     end
+ 
+     ####",Line is too long. [82/80],Layout/AlignArray: Align the e
+487,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel
+ {
+     using System;",Add blank line below license header.,Why is this needed?
+488,"@@ -110,9 +110,17 @@ public abstract class BaseMetastoreCatalog implements Catalog {
+       throw new NoSuchTableException(""No such table: "" + identifier);
+     }
+ 
+-    String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
+     Map<String, String> tableProperties = properties != null ? properties : Maps.newHashMap();
+-    TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
++
++    TableMetadata metadata;
++    if (ops.current() != null) {
++      String baseLocation = location != null ? location : ops.current().location();
++      metadata = ops.current().buildReplacement(schema, spec, baseLocation, tableProperties);
++    } else {
++      String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
++      metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
++    }
++
+     if (orCreate) {
+       return Transactions.createOrReplaceTableTransaction(identifier.toString(), ops, metadata);
+     } else {","I'm not clear on whether this really should be the right behavior. Basically we're saying that a replace table will keep the existing location (as opposed to using defaults). I suspect we don't have create or replace with location semantics, but this is making some assumptions that a replacement is somehow the same as the old. If we were to go with id based pathing convention, this wouldn't work. I don't think this is an issue at this point, but it might make sense to push this down to the location provider.",Why do we need to call `defaultWarehouseLocation` here?
+489,"@@ -37,8 +37,10 @@ import (
+ 	executionpb ""go.temporal.io/temporal-proto/execution""
+ 	tasklistpb ""go.temporal.io/temporal-proto/tasklist""
+ 
++	executionproto ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	""github.com/temporalio/temporal/.gen/proto/persistenceblobs""
+ 	replicationgenpb ""github.com/temporalio/temporal/.gen/proto/replication""
++
+ 	""github.com/temporalio/temporal/common""
+ 	""github.com/temporalio/temporal/common/checksum""
+ 	""github.com/temporalio/temporal/common/persistence/serialization""",Just run a global replacement for all `executionproto`.,nit: remove empty line
+490,"@@ -111,7 +111,7 @@ class WebDriver(object):
+ 
+     def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
+                  desired_capabilities=None, browser_profile=None, proxy=None,
+-                 keep_alive=False, file_detector=None):
++                 keep_alive=False, file_detector=None, options=None):
+         """"""
+         Create a new driver that will issue commands using the wire protocol.
+ ",@AutomatedTester @davehunt thoughts on a new keyword argument?,This should be `options=None`
+491,"@@ -49,6 +49,9 @@ fpga_result opae_ioctl(int fd, int request, ...)
+ 		case EINVAL:
+ 			res = FPGA_INVALID_PARAM;
+ 			break;
++		case ENOTSUP:
++			res = FPGA_NOT_SUPPORTED;
++			break;
+ 		default:
+ 			// other errors could be
+ 			// EBADF - fd is bad file descriptor",Should line 47 be OPAE_ERR?,I don't think this is correct. It should be `ENOTSUP`.
+492,"@@ -104,6 +104,8 @@ import (
+ 	""gocloud.dev/pubsub/driver""
+ )
+ 
++var zeroTime time.Time
++
+ // Message contains data to be published.
+ type Message struct {
+ 	// Body contains the content of the message.","Not necessary, just write `time.Time{}`",var zeroTime = time.Now()
+493,"@@ -499,6 +499,11 @@ def data(readonly=False):
+              SettingValue(typ.Bool(), 'true'),
+              ""Whether to show favicons in the tab bar.""),
+ 
++            ('tabbar-size',
++             SettingValue(typ.Int(minval=8), '12'),
++             ""The height of the tabbar in pixels.""
++             ""This also controls the size of the favicons.""),
++
+             ('width',
+              SettingValue(typ.PercOrInt(minperc=0, maxperc=100, minint=1),
+                           '20%'),","As these two strings simply get concatenated for the docs, there's a space missing after the dot here.",I think this should be `t
+494,"@@ -29,6 +29,7 @@ namespace Datadog.Trace.ClrProfiler.CallTarget
+         {
+             if (IntegrationOptions<TIntegration, TTarget>.IsIntegrationEnabled)
+             {
++                IntegrationOptions<TIntegration, TTarget>.RecordTelemetry();
+                 return BeginMethodHandler<TIntegration, TTarget>.Invoke(instance);
+             }
+ ",What about integrations where we don't plug ourselved on OnMethodBegin?,I think we should record 
+495,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+         
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?,I think this should be `v
+496,"@@ -18,12 +18,15 @@ import com.google.api.codegen.SnippetSetRunner;
+ import com.google.api.codegen.viewmodel.FileHeaderView;
+ import com.google.api.codegen.viewmodel.ViewModel;
+ import com.google.api.codegen.viewmodel.testing.MockServiceImplView.Builder;
++import com.google.api.tools.framework.model.Interface;
+ import com.google.auto.value.AutoValue;
+ import java.util.List;
+ 
+ @AutoValue
+ public abstract class GapicSurfaceTestClassView implements ViewModel {
+ 
++  public abstract Interface service();
++
+   public abstract FileHeaderView fileHeader();
+ 
+   public abstract String name();",ViewModel classes should not expose any classes from framework.model.,Why is this needed?
+497,"@@ -135,9 +135,6 @@ def test_single_required_string_field_config_type():
+     assert _validate(_single_required_string_config_dict(), {'string_field': 'value'}) == {
+         'string_field': 'value'
+     }
+-    assert _validate(_single_required_string_config_dict(), {'string_field': None}) == {
+-        'string_field': None
+-    }
+ 
+     with pytest.raises(DagsterEvaluateConfigValueError):
+         _validate(_single_required_string_config_dict(), {})",how would you feel about keeping these tests to be more explicit and having them `assert not _validate...`? or is your view that that is too duplicative of the tests in `test_evaluator.py`?,Why was this remove
+498,"@@ -21,10 +21,11 @@ test_name ""bolt plan run should apply manifest block on remote hosts via winrm""
+     scp_to(bolt, File.join(fixtures, 'example_apply'), ""#{dir}/modules/example_apply"")
+   end
+ 
+-  bolt_command = ""bolt plan run example_apply filepath=#{filepath} nodes=winrm_nodes""
++  bolt_command = ""bolt plan run example_apply filepath=#{filepath}""
+   flags = {
+     '--modulepath' => modulepath(File.join(dir, 'modules')),
+-    '--format' => 'json'
++    '--format' => 'json',
++    '-t' => ""winrm_nodes""
+   }
+ 
+   teardown do","Why do we use the `winrm_nodes` variable here and not the string `""winrm_nodes""` as we were using before?",Why is this needed?
+499,"@@ -1,4 +1,4 @@
+-/* Copyright (c) 2018 vesoft inc. All rights reserved.
++/* Copyright (c) 2019 vesoft inc. All rights reserved.
+  *
+  * This source code is licensed under Apache 2.0 License,
+  * attached with Common Clause Condition 1.0, found in the LICENSES directory.",why update Copyright ?,This file should be
+500,"@@ -7469,7 +7469,14 @@ RelExpr *Scan::bindNode(BindWA *bindWA)
+      bindWA->setErrStatus();
+      return NULL;
+   }
+-
++  if (naTable->hasLobColumn() && isSampleScan())
++    {
++      *CmpCommon::diags() << DgSqlCode(-4322)
++       << DgTableName(
++           naTable->getTableName().getQualifiedNameAsAnsiString());
++     bindWA->setErrStatus();
++     return NULL;
++    }
+   // restricted partitions for HBase table
+   if (naTable->isHbaseTable() &&
+       (naTable->isPartitionNameSpecified() ||",Does this mean we cannot update statistics with sampling on a table with LOB columns?,Shouldn't this be `*CmpCommon::diags()`?
+501,"@@ -47,7 +47,18 @@ namespace NLog.LayoutRenderers.Wrappers
+     [ThreadAgnostic]
+     public sealed class CachedLayoutRendererWrapper : WrapperLayoutRendererBase
+     {
+-        private string cachedValue;
++        /// <summary>
++        /// A value indicating when the cache is cleared.
++        /// </summary>
++        public enum ClearCacheOption 
++        { 
++            /// <summary>Never clear the cache.</summary>
++            Never = 0,
++            /// <summary>Clear the cache whenever the <see cref=""CachedLayoutRendererWrapper""/> is initialized.</summary>
++            OnInitialize = 1
++        }
++
++        private string cachedValue = null;
+ 
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""CachedLayoutRendererWrapper""/> class.","Look good, but I think a `[flags]` enum would be more future proof? Although i'm not sure if a flags-enum is working from the XML config. What do you think?",Why do we need this?
+502,"@@ -1577,6 +1577,16 @@
+       require: '^uiGrid',
+       link: function($scope, $elm, $attrs, uiGridCtrl) {
+         var self = uiGridCtrl.grid;
++        $scope.treeButtonClass = function(row) {
++          if ( ( self.options.showTreeExpandNoChildren && row.treeLevel > -1 ) || ( row.treeNode.children && row.treeNode.children.length > 0 ) ) {
++            if (row.treeNode.state === 'expanded' ) {
++              return 'ui-grid-icon-minus-squared';
++            }
++            if (row.treeNode.state === 'collapsed' ) {
++              return 'ui-grid-icon-plus-squared';
++            }
++          }
++        };
+         $scope.treeButtonClick = function(row, evt) {
+           evt.stopPropagation();
+           uiGridTreeBaseService.toggleRowTreeState(self, row, evt);","Since I believe state will never be anything other than 'expanded' or collapse, you can rewrite this as follows: `return row.treeNode.state === 'expanded' ? 'ui-grid-icon-minus-squared' : 'ui-grid-icon-plus-squared'; `",Why do you need to check for `row.treeLe
+503,"@@ -32,10 +32,6 @@ import org.apache.solr.common.SolrException;
+  * Solr endpoints for SolrCloud collections, and then use the
+  * {@link LBHttp2SolrClient} to issue requests.
+  *
+- * This class assumes the id field for your documents is called
+- * 'id' - if this is not the case, you must set the right name
+- * with {@link #setIdField(String)}.
+- *
+  * @lucene.experimental
+  * @since solr 8.0
+  */","the latter part can go but isn't the first part of this still sound -- that we assume ""id""?",Why is this removed?
+504,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return '\'' + value + '\'';
+ 	} else {
+-		return '""""';
++		return '\'\'';
+ 	}
+ }
+ ",Why is the escaping of @ and $ removed?,Why did you remove the quotes?
+505,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface IHasHttpUrl
++    {
++        string GetRawUrl();
++    }
++}",Nit: `Http` is redundant in this interface's name.,Why do we need this interface?
+506,"@@ -82,6 +82,19 @@ func NewCluster(ctx context.Context, cfg *ClusterConfig, creds credentials.Trans
+ 	if err != nil {
+ 		return nil, nil, err
+ 	}
++
++	exists, err := store.Exists(cfg.SynchronizableEntitiesPrefix)
++	if err != nil {
++		return nil, nil, fmt.Errorf(""failed to check if SynchronizableEntitiesPrefix exists: %s"", err)
++	}
++
++	if !exists {
++		err = store.Put(cfg.SynchronizableEntitiesPrefix, []byte{}, nil)
++		if err != nil {
++			return nil, nil, err
++		}
++	}
++
+ 	endpoints, err := parseEndpoints(cfg)
+ 	if err != nil {
+ 		return nil, nil, err","what if I set SynchronizableEntitiesPrefix to ""a/b/c/d"" in config?",I think this should be `if err
+507,"@@ -83,9 +83,13 @@ func (opts *InitAppOpts) Validate() error {
+ 		}
+ 	}
+ 	if opts.DockerfilePath != """" {
+-		if _, err := listDockerfiles(opts.fs, opts.DockerfilePath); err != nil {
++		isDir, err := afero.IsDir(opts.fs, opts.DockerfilePath)
++		if err != nil {
+ 			return err
+ 		}
++		if isDir {
++			return fmt.Errorf(""dockerfile path expected, got %s"", opts.DockerfilePath)
++		}
+ 	}
+ 	if opts.ProjectName() == """" {
+ 		return errNoProjectInWorkspace","nit: This error message doesn't mention that the path is a directory, maybe ""Dockerfile path is a directory:%s, please provide path to file.""","nit: `expected, got`"
+508,"@@ -26,6 +26,7 @@
+ # Copyright (c) 2020 Anthony <tanant@users.noreply.github.com>
+ # Copyright (c) 2021 Marc Mueller <30130371+cdce8p@users.noreply.github.com>
+ # Copyright (c) 2021 Peter Kolbus <peter.kolbus@garmin.com>
++# Copyright (c) 2021 Daniel van Noord <13665637+DanielNoord@users.noreply.github.com>
+ 
+ 
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html","This is done automatically, you can skip it next time ;)",# Copyright (c) 2021 Daniel van Noord <13665637@users.noreply.github.com>
+509,"@@ -128,6 +128,14 @@ class WebKitElement(webelem.AbstractWebElement):
+             value = javascript.string_escape(value)
+             self._elem.evaluateJavaScript(""this.value='{}'"".format(value))
+ 
++    def dispatch_event(self, event):
++        self._check_vanished()
++        if self._tab.is_deleted():
++            raise webelem.OrphanedError(""Tab containing element vanished"")
++        log.webelem.debug(""Firing event on {!r} via javascript."".format(self))
++        self._elem.evaluateJavaScript(""this.dispatchEvent(new Event('{}'))""
++                                      .format(event))
++
+     def caret_position(self):
+         """"""Get the text caret position for the current element.""""""
+         self._check_vanished()","This is needed in `set_value` because of `:open-editor` (you could open an editor, close the tab, then close the editor). I don't think it makes any sense to have it here?",Why do we need this?
+510,"@@ -53,6 +53,10 @@ type agentConfig struct {
+ 
+ 	ConfigPath string
+ 	Umask      string `hcl:""umask""`
++
++	ProfilingEnabled string `hcl:""profiling_enabled""`
++	ProfilingPort    string `hcl:""profiling_port""`
++	ProfilingFreq    string `hcl:""profiling_freq""`
+ }
+ 
+ type RunCLI struct {","Perhaps we can assume that profiling is enabled if ProfilingPort is set? And/or configure a default port and frequency, so we don't have to set three config vars every time?",Why is this a string?
+511,"@@ -22,6 +22,7 @@ module Beaker
+       #HACK HACK HACK - add checks here to ensure that we have box + box_url
+       #generate the VagrantFile
+       v_file = ""Vagrant.configure(\""2\"") do |c|\n""
++      v_file << ""  c.ssh.forward_agent = true\n"" unless options['forward_ssh_agent'].nil?
+       hosts.each do |host|
+         host['ip'] ||= randip #use the existing ip, otherwise default to a random ip
+         v_file << ""  c.vm.define '#{host.name}' do |v|\n""",This nil check won't correctly handle the case where forward_ssh_agent is set to false - it won't be nil but it should still not be set.,Why is this necessary?
+512,"@@ -521,7 +521,7 @@ func TestVoteTrackerFiltersDuplicateVoteOnce(t *testing.T) {
+ 			inputVotes[i] = helper.MakeValidVoteAcceptedVal(t, i, next, Val1)
+ 			expectedOutputs[i] = thresholdEvent{T: none}
+ 		case i == Num:
+-			inputVotes[i] = voteFilterRequestEvent{RawVote: inputVotes[Num-1].(voteAcceptedEvent).Vote.R}
++			inputVotes[i] = voteFilterRequestEvent{RawVote: inputVotes[Num-1].(voteAcceptedEvent).Vote.R, Proto: protocol.ConsensusCurrentVersion}
+ 			expectedOutputs[i] = filteredStepEvent{T: voteFilteredStep}
+ 		}
+ 	}",We could avoid passing proto since threshold isn't needed.,why do we need to set the proto here?
+513,"@@ -1040,7 +1040,10 @@ func (di *Dependencies) AllowURLAccess(servers ...string) error {
+ 		return err
+ 	}
+ 
+-	if config.GetBool(config.FlagKeepConnectedOnFail) {
++	// Doesn't work as expected because some services share IP address with
++	// each other and with location oracle which is supposed to be routed
++	// through VPN tunnel.
++	if false && config.GetBool(config.FlagKeepConnectedOnFail) {
+ 		if err := router.AllowURLAccess(servers...); err != nil {
+ 			return err
+ 		}","This route excluding needed for reconnect only when one connection is lost and we trying to establish another. I was thinking to make 2 separate flags for killswitch and reconnect enabling. This way we can keep killswitch working, but we don't need these routes excluded.",I'm not sure if this is the right way
+514,"@@ -124,8 +124,8 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+   }
+   CHECK(status.ok()) << status.ToString();
+   db_.reset(db);
+-  partsNum_ = allParts().size();
+   extractorLen_ = sizeof(PartitionID) + vIdLen;
++  partsNum_ = allParts().size();
+   LOG(INFO) << ""open rocksdb on "" << path;
+ 
+   backup();",why can this modification avoid crash?,Why this change?
+515,"@@ -1,8 +1,7 @@
+ module RedirectIfDisabled
+   def redirect_if_disabled
+-    account = current_user
+-    return unless account && account.access.disabled?
+-    request.env[:clearance].sign_out
+-    redirect_to disabled_account_url(account)
++    return unless @account && @account.access.disabled?
++    request.env[:clearance].sign_out if @account.id == current_user.id
++    redirect_to disabled_account_url(@account)
+   end
+ end",This looks good -- signing out the user if the current user is disabled,Why not just `@account.disabled?`?
+516,"@@ -47,13 +47,13 @@ class Selection {
+      */
+     this.selectedByCorner = false;
+     /**
+-     * The collection of the selection layer levels where the whole row was selected using the row header.
++     * The collection of the selection layer levels where the whole row was selected using the row header or the corner header.
+      *
+      * @type {Set.<number>}
+      */
+     this.selectedByRowHeader = new Set();
+     /**
+-     * The collection of the selection layer levels where the whole column was selected using the column header.
++     * The collection of the selection layer levels where the whole column was selected using the column header or the corner header.
+      *
+      * @type {Set.<number>}
+      */",The line exceeds 120 characters.,I think this should be `selectedByColumnHeader`
+517,"@@ -62,6 +62,11 @@ func renderAppDescribe(desc map[string]interface{}) (string, error) {
+ 	ddevapp.RenderAppRow(appTable, desc)
+ 	output = fmt.Sprint(appTable)
+ 
++	output = output + ""\n\nSite Information\n-----------------\n""
++	siteInfo := uitable.New()
++	siteInfo.AddRow(""PHP version:"", desc[""php_version""])
++	output = output + fmt.Sprint(siteInfo)
++
+ 	// Only show extended status for running sites.
+ 	if desc[""status""] == ddevapp.SiteRunning {
+ 		output = output + ""\n\nMySQL Credentials\n-----------------\n""","Let's go ahead and change ""Site"" to ""Project"", since that's the path we've chosen. One less thing to alter in the other issue.",I don't think we need this line.
+518,"@@ -89,7 +89,6 @@ Prints out information about filecoin process and its environment.
+ 			sw.Printf(""\nEnvironment\n"")
+ 			sw.Printf(""FilAPI: \t%s\n"", info.Environment.FilAPI)
+ 			sw.Printf(""FilPath:\t%s\n"", info.Environment.FilPath)
+-			sw.Printf(""GoPath: \t%s\n"", info.Environment.GoPath)
+ 
+ 			// Print Config Info
+ 			sw.Printf(""\nConfig\n"")","I am for this change iff we are sure the information is no longer helpful. I think this could still be valuable for certain scenarios, wbu?","sw.Printf(""GoPath: %s\n"", info.Environment.GoPa"
+519,"@@ -296,11 +296,16 @@ public class ImageRampupManagerImpl implements ImageRampupManager {
+       if (null == flow) {
+         log.info(""Flow object is null, so continue"");
+         final ImageRampup firstImageRampup = imageRampupList.get(0);
++
++        // Find the imageVersion in the Rampup list with maximum rampup percentage.
++        final ImageRampup maxImageRampup = imageRampupList.stream()
++            .max(Comparator.comparing(ImageRampup::getRampupPercentage))
++            .orElseGet(() -> firstImageRampup);
+         imageTypeRampupVersionMap.put(imageTypeName,
+-            this.fetchImageVersion(imageTypeName, firstImageRampup.getImageVersion())
++            this.fetchImageVersion(imageTypeName, maxImageRampup.getImageVersion())
+                 .orElseThrow(() -> new ImageMgmtException(
+                     String.format(""Unable to fetch version %s from image "" + ""versions table."",
+-                        firstImageRampup.getImageVersion()))));
++                        maxImageRampup.getImageVersion()))));
+         continue;
+       }
+       int prevRampupPercentage = 0;",I thought we decided on using the latest active version and not the one which is max ramped up.,I think this should be `maxImageRampup`
+520,"@@ -461,10 +461,13 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
+ 		if err != nil {
+ 			if err == selector.ErrSubnetsNotFound {
+ 				log.Errorf(`No existing public subnets were found in VPC %s. You can either:
+-- Create new public subnets and then import them.
+-- Use the default Copilot environment configuration.`, o.importVPC.ID)
++- %s to interrupt, create new public subnets, then rerun %s and import them.
++- %s to interrupt, then rerun %s and use the default Copilot environment configuration.
++- Proceed without public subnets, knowing that deploying a load-balanced web service in this environment will fail because Load Balancers require at least two public subnets in different Availability Zones.
++`, o.importVPC.ID, color.HighlightUserInput(""ctrl-c""), color.HighlightCode(""copilot env init""), color.HighlightUserInput(""ctrl-c""), color.HighlightCode(""copilot env init""))
++			} else {
++				return fmt.Errorf(""select public subnets: %w"", err)
+ 			}
+-			return fmt.Errorf(""select public subnets: %w"", err)
+ 		}
+ 		o.importVPC.PublicSubnetIDs = publicSubnets
+ 	}",can we update this to a `log.Warningf`?,I don't think we need the else here.
+521,"@@ -105,7 +105,11 @@ def connect_container_to_network(container, network):
+ 
+ 
+ def disconnect_container_from_network(container, network):
+-    subprocess.check_call([""docker"", ""network"", ""disconnect"", network, container])
++    # subprocess.run instead of subprocess.check_call so we don't fail when
++    # trying to disconnect a container from a network that it's not connected to
++    subprocess.run(  # pylint: disable=subprocess-run-check
++        [""docker"", ""network"", ""disconnect"", network, container]
++    )
+ 
+ 
+ def hostnames(network):",can we get something emitted in the logs on non-zero exits to trace back to for problems like this failing on the first invocation?,Why do we need to disable this?
+522,"@@ -20,9 +20,10 @@ namespace storage {
+ TEST(DeleteVertexTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/DeleteVertexTest.XXXXXX"");
+     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
++    auto schemaMan = TestUtils::mockSchemaMan();
+     // Add vertices
+     {
+-        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr);
++        auto* processor = AddVerticesProcessor::instance(kv.get(), schemaMan.get(), nullptr);
+         cpp2::AddVerticesRequest req;
+         req.space_id = 0;
+         req.overwritable = false;",Do we need `schema manager` at here ?,Why is this needed?
+523,"@@ -0,0 +1,19 @@
++package parser
++
++//go:generate cargo build --release
++
++// #cgo LDFLAGS: -L${SRCDIR}/target/release -ldl -Wl,-Bstatic -lflux_parser -Wl,-Bdynamic
++// #include <stdlib.h>
++// void flux_parse_json(const char*);
++import ""C""
++
++import (
++	""unsafe""
++)
++
++func Parse(input string) {
++	cstr := C.CString(input)
++	defer C.free(unsafe.Pointer(cstr))
++
++	C.flux_parse_json(cstr)
++}","This won't work because of the permissions on the directory when this is included as a library. But, we may be able to do this. The key would be wrapping this command with either a script or a go binary that ensures the current directory is writable. If the current directory is not writable, it would attempt to make it writable so that we could write out the produced binary. But I'm not sure if that will influence the hash that gets produced for `go.sum` since I am not sure how that is calculated. Alternatively, we can choose a place in `/usr/local` or choose a location that is writable in the go cache and use that. I'll give that a try since it might be needed for the ARM builds if we choose to only include `x86_64` precompiled binaries in the module.",Why is this needed?
+524,"@@ -153,6 +153,8 @@ func (r *REPL) executeLine(t string) (values.Value, error) {
+ 		return nil, err
+ 	}
+ 
++	r.scope.SetReturn(nil)
++
+ 	if _, err := r.interpreter.Eval(semPkg, r.scope, flux.StdLib()); err != nil {
+ 		return nil, err
+ 	}","Correct me if I'm wrong, but is this necessary? Why not just use the value returned by `interpreter.Eval` and not mess with the scope? `interpreter.Eval` will return any produced side effects. This means TableObjects as well as any value resulting from any expression statements.",Why is this needed?
+525,"@@ -162,12 +162,14 @@ func makeStatefulSetService(p *monitoringv1.Alertmanager, config Config) *v1.Ser
+ 		p.Spec.PortName = defaultPortName
+ 	}
+ 
++	labels := config.Labels.Merge(p.Spec.ServiceMetadata.Labels)
++	labels[""operated-alertmanager""] = ""true""
++
+ 	svc := &v1.Service{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: governingServiceName,
+-			Labels: config.Labels.Merge(map[string]string{
+-				""operated-alertmanager"": ""true"",
+-			}),
++			Name:        governingServiceName,
++			Labels:      labels,
++			Annotations: p.Spec.ServiceMetadata.Annotations,
+ 			OwnerReferences: []metav1.OwnerReference{
+ 				metav1.OwnerReference{
+ 					Name:       p.GetName(),","This service is global per namespace, not per Alertmanager/Prometheus/ThanosRuler instance. So this approach won't work. But maybe I missing out something, can you describe your use case here?",Why do we need this
+526,"@@ -32,6 +32,7 @@ type AttestedNode struct {
+ 	ExpiresAt       time.Time `gorm:""index""`
+ 	NewSerialNumber string
+ 	NewExpiresAt    *time.Time
++	CanReattest     bool `gorm:""default:false""`
+ 
+ 	Selectors []*NodeSelector
+ }","Do we need this default? Since we aren't using a sql.NullBool or *bool, an unset column will be interpreted as `false` already... We don't set a default on our other bool fields (e.g. entry admin and downstream columns).",Why do we need this
+527,"@@ -39,6 +39,18 @@ module ExportsHelper
+     ""<strong>#{prefix}</strong> #{attribution.join(', ')}""
+   end
+ 
++  def download_plan_page_title(plan, phase, hash)
++    # If there is more than one phase show the plan title and phase title
++    return hash[:phases].many? ? ""#{plan.title} - #{phase[:title]}"" : plan.title
++  end
++
++  def display_section?(customization, section, show_custom_sections)
++    display = !customization
++    display ||= customization && !section[:modifiable]
++    display ||= customization && section[:modifiable] && show_custom_sections
++    return display
++  end
++
+   private
+ 
+   def get_margin_value_for_side(side)",thanks for moving these over. makes more sense for them to be in the exports_helper,Layout/EmptyLinesAr
+528,"@@ -29,8 +29,9 @@ from qutebrowser.utils import message
+ from qutebrowser.config import config
+ from qutebrowser.keyinput import keyparser
+ from qutebrowser.utils import usertypes, log, objreg, utils
++from qutebrowser.config.parsers import keyconf
+ 
+-
++ 
+ STARTCHARS = "":/?""
+ LastPress = usertypes.enum('LastPress', ['none', 'filtertext', 'keystring'])
+ ",That import now isn't needed anymore,Why is this import needed?
+529,"@@ -237,6 +237,8 @@ class WebDriver(RemoteWebDriver):
+         Returns identifier of installed addon. This identifier can later
+         be used to uninstall addon.
+ 
++        :param path: Full path to the addon that will be installed.
++
+         :Usage:
+             driver.install_addon('firebug.xpi')
+         """"""",Can you update the `Usage` to be an absolute path as well? Something like `/path/to/firebug.xpi`,This should be `:param str
+530,"@@ -2,17 +2,13 @@
+ // The .NET Foundation licenses this file to you under the MS-PL license.
+ // See the LICENSE file in the project root for more information.
+ 
+-
+-using MvvmCross.Plugins;
+-
+ namespace MvvmCross.Plugin.Accelerometer.Platform.Uap
+ {
+-    public class Plugin
+-        : IMvxPlugin
++    public class Plugin : IMvxPlugin
+     {
+         public void Load()
+         {
+-            Mvx.RegisterSingleton<IMvxAccelerometer>(new MvxWindowsCommonAccelerometer());
++            Mvx.RegisterSingleton<IMvxAccelerometer>(new MvxWindowsAccelerometer());
+         }
+     }
+ }",This class is missing the `MvxPlugin` attribute,Why was this removed?
+531,"@@ -596,6 +596,8 @@ def initialize():
+ 	if mainFrame:
+ 		raise RuntimeError(""GUI already initialized"")
+ 	mainFrame = MainFrame()
++	wxLang = core.getWxLang(languageHandler.getLanguage())
++	mainFrame.SetLayoutDirection(wxLang.LayoutDirection)
+ 	wx.GetApp().SetTopWindow(mainFrame)
+ 	# In wxPython >= 4.1,
+ 	# wx.CallAfter no longer executes callbacks while NVDA's main thread is within apopup menu or message box.",What if `wxLang` is returned `None` from `getWxLang`,Why is this needed?
+532,"@@ -546,9 +546,9 @@ ResultCode NebulaStore::ingest(GraphSpaceID spaceId) {
+             auto files = nebula::fs::FileUtils::listAllFilesInDir(path.c_str(), true, ""*.sst"");
+             for (auto file : files) {
+                 LOG(INFO) << ""Ingesting extra file: "" << file;
+-                auto code = engine->ingest(std::vector<std::string>({file}));
+-                if (code != ResultCode::SUCCEEDED) {
+-                    return code;
++                auto ret_code = engine->ingest(std::vector<std::string>({file}));
++                if (ResultCode::SUCCEEDED != ret_code) {
++                    return ret_code;
+                 }
+             }
+         }",Please don't do changing like this unless it _**really**_ cares. BTW. Please look around to infer our naming conventions.,Why did you change this?
+533,"@@ -35,13 +35,13 @@ public class BaseSuite {
+   public static ExternalResource testEnvironment = new ExternalResource() {
+     @Override
+     protected void before() {
+-      log.info(""Preparing test environment"");
++      log.finest(""Preparing test environment"");
+       GlobalTestEnvironment.get(SeleniumTestEnvironment.class);
+       System.setProperty(""webdriver.remote.shorten_log_messages"", ""true"");
+     }
+     @Override
+     protected void after() {
+-      log.info(""Cleaning test environment"");
++      log.finest(""Cleaning test environment"");
+       TestEnvironment environment = GlobalTestEnvironment.get();
+       if (environment != null) {
+         environment.stop();",This is in test code: understanding what we're doing is important in this context.,Why are we changing thes
+534,"@@ -76,8 +76,8 @@ public class CommandLineUtils {
+    * @param isMainOptionCondition the conditions to test dependent options against. If all
+    *     conditions are true, dependent options will be checked.
+    * @param dependentOptionsNames a list of option names that can't be used if condition is met.
+-   *     Example: if --min-gas-price is in the list and condition is that either --miner-enabled or
+-   *     --goquorum-compatibility-enabled should not be false, we log a warning.
++   *     Example: if --min-gas-price is in the list and condition is that --miner-enabled should not
++   *     be false, we log a warning.
+    */
+   public static void checkMultiOptionDependencies(
+       final Logger logger,",prob should still have an example that has multiple option names even if you have to make it up. Or maybe we don't need this method?,I think this should be `
+535,"@@ -246,9 +246,9 @@ class PlansController < ApplicationController
+     file_name = @plan.title.gsub(/ /, ""_"")
+ 
+     respond_to do |format|
+-      format.html
+-      format.csv  { send_data @exported_plan.as_csv(@sections, @unanswered_question, @question_headings),  filename: ""#{file_name}.csv"" }
+-      format.text { send_data @exported_plan.as_txt(@sections, @unanswered_question, @question_headings, @show_details),  filename: ""#{file_name}.txt"" }
++      format.html { render layout: false }
++      format.csv  { send_data @plan.as_csv(@show_sections_questions),  filename: ""#{file_name}.csv"" }
++      format.text { send_data render_to_string(partial: 'shared/export/plan_txt'), filename: ""#{file_name}.txt"" }
+       format.docx { render docx: 'export', filename: ""#{file_name}.docx"" }
+       format.pdf do
+         render pdf: file_name,","I believe respond_to whitelists the formats passed to the block so if we don't want to display html, we can just remove the line format.html...",Layout/ExtraSpacing: Unn
+536,"@@ -21,7 +21,7 @@ var LocalDevStopCmd = &cobra.Command{
+ 		err = app.Stop()
+ 		if err != nil {
+ 			log.Println(err)
+-			util.Failed(""Failed to stop containers for %s. Run `ddev list` to ensure your site exists."", app.ContainerName())
++			util.Failed(""Failed to stop containers for %s. Run `ddev list` to ensure your site exists. error="", app.ContainerName(), err)
+ 		}
+ 
+ 		util.Success(""Application has been stopped."")","stylistic nitpick: I _feel_ like we've largely shown errors like this as ""error: "" vs. ""error="". IMO colon/space reads better.",Shouldn't this be `err.Error()`?
+537,"@@ -18,11 +18,16 @@
+  */
+ 
+ #include <fastdds/rtps/writer/RTPSWriter.h>
++
++#include <fastdds/dds/log/Log.hpp>
++
+ #include <fastdds/rtps/history/WriterHistory.h>
+ #include <fastdds/rtps/messages/RTPSMessageCreator.h>
+-#include <fastdds/dds/log/Log.hpp>
+-#include <rtps/participant/RTPSParticipantImpl.h>
++
++#include <rtps/history/BasicPayloadPool.hpp>
++#include <rtps/history/CacheChangePool.h>
+ #include <rtps/flowcontrol/FlowController.h>
++#include <rtps/participant/RTPSParticipantImpl.h>
+ 
+ #include <mutex>
+ ",We could put this implementation in `RTPSWriter::create_change_pool` and avoid an extra function.,Why is this header needed?
+538,"@@ -25,6 +25,7 @@
+ package persistencetests
+ 
+ import (
++	""fmt""
+ 	""time""
+ 
+ 	""github.com/pborman/uuid""",should this file ends with _test.go?,Why do we need this?
+539,"@@ -382,7 +382,7 @@ class IPv6(_IPv6GuessPayload, Packet, IPTools):
+ 
+         if conf.checkIPsrc and conf.checkIPaddr and not in6_ismaddr(sd):
+             sd = inet_pton(socket.AF_INET6, sd)
+-            ss = inet_pton(socket.AF_INET6, self.src)
++            ss = inet_pton(socket.AF_INET6, ss)
+             return strxor(sd, ss) + struct.pack(""B"", nh) + self.payload.hashret()  # noqa: E501
+         else:
+             return struct.pack(""B"", nh) + self.payload.hashret()",It's because of this change. `ss` was unused and it made sense in the program. However I haven't read the IPv6 RFC so I'm unsure of what it does,Why this change?
+540,"@@ -483,6 +483,7 @@ class DataManager {
+    */
+   addChildAtIndex(parent, index, element) {
+     let childElement = element;
++    let flattenIndex;
+ 
+     if (!childElement) {
+       childElement = this.mockNode();","""Flatten"" is a verb, so I'd probably go with `flattenedIndex` as a variable name here.",Why do we need this?
+541,"@@ -1,5 +1,19 @@
+ const chalk = require('chalk')
+ 
++const valuesToMask = []
++/**
++ * Adds a list of strings that should be masked by the logger.
++ * This function can only be called once through out the life of the server.
++ * @param {Array} maskables a list of strings to be masked
++ */
++exports.addMaskables = (maskables) => {
++  maskables.forEach((i) => {
++    valuesToMask.push(i)
++  })
++
++  Object.freeze(valuesToMask)
++}
++
+ /**
+  * INFO level log
+  * @param {string} msg the message to log","If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times",I don't think we nee
+542,"@@ -38,7 +38,7 @@ func downloadAndExtractConfigPackage(channel string, targetDir string) (err erro
+ }
+ 
+ func downloadConfigPackage(channelName string, targetDir string) (packageFile string, err error) {
+-	s3, err := s3.MakeS3SessionForDownload()
++	s3, err := s3.MakePublicS3SessionForDownload()
+ 	if err != nil {
+ 		return
+ 	}",Nodecfg should be downloading from a private bucket -- these shouldn't be for public consumption. In general these should be generic and expect environment to provide appropriate credentials and bucket.,why is this public?
+543,"@@ -0,0 +1,17 @@
++# MicrosoftEdge.py
++#A part of NonVisual Desktop Access (NVDA)
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++#Copyright (C) 2018 NV Access Limited, Joseph Lee
++
++""""""appModule for Microsoft Edge main process""""""
++
++import appModuleHandler
++import ui
++
++class AppModule(appModuleHandler.AppModule):
++
++	def event_UIA_notification(self, obj, nextHandler, displayString=None, **kwargs):
++		# #8423: even though content process is focused, notifications are fired by main Edge process.
++		# The base object will simply ignore this, so notifications must be announced here and no more.
++		ui.message(displayString)",Could you please end the file with an empty line?,Why do we need this 
+544,"@@ -76,7 +76,7 @@ public class ProtocolHandshake {
+ 
+         if (result.isPresent()) {
+           Result toReturn = result.get();
+-          LOG.info(String.format(""Detected dialect: %s"", toReturn.dialect));
++          LOG.finest(String.format(""Detected dialect: %s"", toReturn.dialect));
+           return toReturn;
+         }
+       }",This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users.,Why is this change needed?
+545,"@@ -89,7 +89,9 @@ func (v *Var) UnmarshalJSON(b []byte) error {
+ // Workflow is a single Daisy workflow workflow.
+ type Workflow struct {
+ 	// Populated on New() construction.
+-	Cancel chan struct{} `json:""-""`
++	Cancel       chan struct{} `json:""-""`
++	isCanceled   bool
++	isCanceledMx sync.Mutex
+ 
+ 	// Workflow template fields.
+ 	// Workflow name.",Can this be non-exported to avoid direct use? It would be a breaking change but using previous package version would work.,Why do we need this mutex?
+546,"@@ -145,7 +145,11 @@ func (w *watcher) ErrorAs(err error, i interface{}) bool {
+ 	return w.bucket.ErrorAs(err, i)
+ }
+ 
+-// IsNotExist implements driver.IsNotExist.
+-func (*watcher) IsNotExist(err error) bool {
+-	return gcerrors.Code(err) == gcerrors.NotFound
++// ErrorCode implements driver.ErrorCode.
++func (*watcher) ErrorCode(err error) gcerrors.ErrorCode {
++	// err might have come from blob, in which case use its code.
++	if c := gcerrors.Code(err); c != gcerrors.Unknown {
++		return c
++	}
++	return gcerrors.Unknown
+ }","Nit: this is just `return gcerrors.Code(err)`, isn't it?",Why not just return gcerro
+547,"@@ -189,12 +189,7 @@ func (smc *Client) ProposeDeal(ctx context.Context, miner address.Address, data
+ 	// create payment information
+ 	totalCost := price.MulBigInt(big.NewInt(int64(pieceSize * duration)))
+ 	if totalCost.GreaterThan(types.ZeroAttoFIL) {
+-		// The payment setup requires that the payment is mined into a block, currently we
+-		// will wait for at most 5 blocks to be mined before giving up
+-		ctxPaymentSetup, cancel := context.WithTimeout(ctx, 5*smc.api.BlockTime())
+-		defer cancel()
+-
+-		cpResp, err := smc.api.CreatePayments(ctxPaymentSetup, porcelain.CreatePaymentsParams{
++		cpResp, err := smc.api.CreatePayments(ctx, porcelain.CreatePaymentsParams{
+ 			From:            fromAddress,
+ 			To:              minerOwner,
+ 			Value:           totalCost,","I don't know where this came from, but it's not a good idea. This is actually timing out after 5 rounds, not 5 blocks. 5 consecutive null blocks won't be that uncommon. Also when testing with a short block time, this is a very short duration that can contribute to flaky tests.",Why was this removed?
+548,"@@ -47,7 +47,8 @@ def loadState():
+ 	global state
+ 	statePath=os.path.join(globalVars.appArgs.configPath,stateFilename)
+ 	try:
+-		state = cPickle.load(file(statePath, ""r""))
++		with open(statePath, ""r"") as f:
++			state = cPickle.load(f)
+ 		if ""disabledAddons"" not in state:
+ 			state[""disabledAddons""] = set()
+ 		if ""pendingDisableSet"" not in state:","In Python 3 when pickling or unpickling objects, the file needs to be opened as binary so that no text encoding/decoding takes place. So for any open calls around pickle loads or dumps, the mode for reading must be rb and the mode for writing must be wb.",I think this should be `f.read()`
+549,"@@ -2068,7 +2068,7 @@ const processRequest = (params) => {
+                     }
+                     else {
+                         if (params.qstring.event && params.qstring.event.startsWith('[CLY]_group_')) {
+-                            validateRead(params, 'core', countlyApi.data.fetch.fetchMergedEventGroups, params.qstring.method);
++                            validateRead(params, 'core', countlyApi.data.fetch.fetchMergedEventGroups);
+                         }
+                         else {
+                             params.truncateEventValuesList = true;",did you remove **params.qstring.method** intentionally? if so why?,`params.qstring.method` is not us
+550,"@@ -90,6 +90,12 @@ public class TableProperties {
+   public static final String ORC_VECTORIZATION_ENABLED = ""read.orc.vectorization.enabled"";
+   public static final boolean ORC_VECTORIZATION_ENABLED_DEFAULT = false;
+ 
++  public static final String LOCALITY_ENABLED = ""read.locality.enabled"";
++  public static final String LOCALITY_ENABLED_DEFAULT = null;
++
++  public static final String LOCALITY_TASK_INITIALIZE_THREADS = ""read.locality.task.initialize.threads"";
++  public static final int LOCALITY_TASK_INITIALIZE_THREADS_DEFAULT = 1;
++
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ ",What is the current default? Is that inconsistent across uses and that's why this is null?,This should be `read.locality.tas
+551,"@@ -477,6 +477,7 @@ func (cf CloudFormation) getLastDeployedAppConfig(appConfig *stack.AppStackConfi
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""parse previous deployed stackset %w"", err)
+ 	}
++	previouslyDeployedConfig.App = appConfig.Name
+ 	return previouslyDeployedConfig, nil
+ }
+ ",Why did we make this change? How come it wasn't an issue before,Should this be `previouslyDeploye
+552,"@@ -4342,14 +4342,11 @@ TEST_F(VkLayerTest, InvalidDescriptorSet) {
+     // ObjectTracker should catch this.
+     // Create a valid cmd buffer
+     // call vk::CmdBindDescriptorSets w/ false Descriptor Set
++    ASSERT_NO_FATAL_FAILURE(Init());
+ 
+     uint64_t fake_set_handle = 0xbaad6001;
+     VkDescriptorSet bad_set = reinterpret_cast<VkDescriptorSet &>(fake_set_handle);
+ 
+-    m_errorMonitor->SetDesiredFailureMsg(VK_DEBUG_REPORT_ERROR_BIT_EXT, ""VUID-vkCmdBindDescriptorSets-pDescriptorSets-parameter"");
+-
+-    ASSERT_NO_FATAL_FAILURE(Init());
+-
+     VkDescriptorSetLayoutBinding layout_binding = {};
+     layout_binding.binding = 0;
+     layout_binding.descriptorType = VK_DESCRIPTOR_TYPE_UNIFORM_BUFFER;",Can you tighten scope by moving to of these variables? i.e. Move to ~4372?,Why did you remove this?
+553,"@@ -90,7 +90,7 @@ public class RDATAFileReader extends TabularDataFileReader {
+   // RServe static variables
+   private static String RSERVE_HOST = System.getProperty(""dataverse.rserve.host"");
+   private static String RSERVE_USER = System.getProperty(""dataverse.rserve.user"");
+-  private static String RSERVE_PASSWORD = System.getProperty(""dataverse.rserve.pwrd"");
++  private static String RSERVE_PASSWORD = System.getProperty(""dataverse.rserve.password"");
+   private static int RSERVE_PORT;
+   
+   // TODO: ",Nice to see this `dataverse.rserve.password` fix rolled in.,Why did you change this?
+554,"@@ -273,7 +273,7 @@ int parse_args(int argc, char *argv[])
+ 				break;
+ 			endptr = NULL;
+ 			config.target.bus = (int) strtoul(tmp_optarg, &endptr, 0);
+-			if (endptr != tmp_optarg + strlen(tmp_optarg)) {
++			if (endptr != tmp_optarg + strnlen_s(tmp_optarg, sizeof(tmp_optarg))) {
+ 				fprintf(stderr, ""invalid bus: %s\n"", tmp_optarg);
+ 				return -1;
+ 			}","How about the following faster alternative that doesn't need `strlen()` at all: if (*tmp_optarg == '\0' || *endptr != '\0') { fprintf(...) ... This would treat the bus argument as invalid if it's either empty (`tmp_optarg` points to '\0') or invalid (`endptr` points to something other that a '\0'). Actually, the existing code would accept an empty argument and set the bus to `0`, so if (*endptr != '\0') { fprintf(...) ... would be enough. The check for an empty argument doesn't hurt, though.",Shouldn't this be `strnl
+555,"@@ -7,6 +7,7 @@ class FeedbackMailer < ApplicationMailer
+       to: self.class.support_email,
+       subject: 'Feedback submission',
+       from: from,
++      cc: from,
+       body: message
+     )
+   end","I could be missing something here, but the `from` and `cc` are the same. On the test email sent to gatewaycommunicator, these values are different.",Why do we need this chan
+556,"@@ -32,13 +32,12 @@ describe('useEffect', () => {
+ 			return null;
+ 		}
+ 
+-		render(<Comp />, scratch);
+-		render(<Comp />, scratch);
+-
+-		expect(cleanupFunction).to.be.not.called;
+-		expect(callback).to.be.calledOnce;
++		act(() => {
++			render(<Comp />, scratch);
++			render(<Comp />, scratch);
++		});
+ 
+-		render(<Comp />, scratch);
++		act(() => render(<Comp />, scratch));
+ 
+ 		expect(cleanupFunction).to.be.calledOnce;
+ 		expect(callback).to.be.calledTwice;",I'm honestly scared because act is now a hard requirement for useEffect which it wasn't before... This could break some tests :(,Why did you remove this test?
+557,"@@ -632,8 +632,13 @@ void nano::active_transactions::update_difficulty (std::shared_ptr<nano::block>
+ 			{
+ 				node.logger.try_log (boost::str (boost::format (""Block %1% was updated from difficulty %2% to %3%"") % block_a->hash ().to_string () % nano::to_string_hex (existing_election->difficulty) % nano::to_string_hex (difficulty)));
+ 			}
+-			roots.get<tag_root> ().modify (existing_election, [difficulty](nano::conflict_info & info_a) {
++			roots.get<tag_root> ().modify (existing_election, [election = existing_election->election, &block_a, difficulty](nano::conflict_info & info_a) {
+ 				info_a.difficulty = difficulty;
++				election->blocks[block_a->hash ()] = block_a;
++				if (election->status.winner->hash () == block_a->hash ())
++				{
++					election->status.winner = block_a;
++				}
+ 			});
+ 			adjust_difficulty (block_a->hash ());
+ 		}","Could use election from `info_a.election`, or is this deliberate?",`election->status.winner->has
+558,"@@ -95,6 +95,15 @@ class EasyAdminExtension extends AbstractTypeExtension
+     {
+         return LegacyFormHelper::getType('form');
+     }
++
++    /**
++     * {@inheritdoc}
++     */
++    public static function getExtendedTypes()
++    {
++        // needed to avoid a deprecation when using Symfony 4.2
++        return [LegacyFormHelper::getType('form')];
++    }
+ }
+ 
+ class_alias('EasyCorp\Bundle\EasyAdminBundle\Form\Extension\EasyAdminExtension', 'JavierEguiluz\Bundle\EasyAdminBundle\Form\Extension\EasyAdminExtension', false);",looks like this should be `return array(LegacyFormHelper::getType('form'));`,Why do we need this method?
+559,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?,I don't think this is the rig
+560,"@@ -223,10 +223,9 @@ Blockly.ScratchBlocks.VerticalExtensions.SCRATCH_EXTENSION = function() {
+ Blockly.ScratchBlocks.VerticalExtensions.registerAll = function() {
+   var categoryNames =
+       ['control', 'data', 'data_lists', 'sounds', 'motion', 'looks', 'event',
+-      'sensing', 'pen', 'operators', 'more'];
++        'sensing', 'pen', 'operators', 'more'];
+   // Register functions for all category colours.
+-  for (var i = 0; i < categoryNames.length; i++) {
+-    name = categoryNames[i];
++  for (var i = 0, name; name = categoryNames[i]; i++) {
+     Blockly.Extensions.register('colours_' + name,
+         Blockly.ScratchBlocks.VerticalExtensions.colourHelper(name));
+   }",Where was `name` being declared before?,Why did you remove the length check?
+561,"@@ -74,6 +74,18 @@ func (t testHelper) UnavailableDeployment() *appsv1.Deployment {
+ 	return d
+ }
+ 
++func (t testHelper) UnknownDeployment() *appsv1.Deployment {
++	d := &appsv1.Deployment{}
++	d.Name = ""unknown""
++	d.Status.Conditions = []appsv1.DeploymentCondition{
++		{
++			Type:   appsv1.DeploymentAvailable,
++			Status: ""Unknown"",
++		},
++	}
++	return d
++}
++
+ func (t testHelper) ReadyBrokerCellStatus() *BrokerCellStatus {
+ 	bs := &BrokerCellStatus{}
+ 	bs.PropagateIngressAvailability(t.AvailableEndpoints())",nit: use `corev1.ConditionUnknown`,nit: `UnknownDeployment` -> `Unknown
+562,"@@ -997,7 +997,10 @@ Mongoose.prototype.isValidObjectId = function(v) {
+     v = v.toString();
+   }
+ 
+-  if (typeof v === 'string' && (v.length === 12 || v.length === 24)) {
++  if (typeof v === 'string' && v.length === 12) {
++    return true;
++  }
++  if (typeof v === 'string' && v.length === 24 && /^[a-f0-9]*$/.test(v)) {
+     return true;
+   }
+ ","You also need to add a similar check on line 992, there's another place where we check `length === 24`",I think this should be `/^[a-f0-9]*$
+563,"@@ -105,9 +105,14 @@ public class BftBlockCreatorFactory {
+   public Bytes createExtraData(final int round, final BlockHeader parentHeader) {
+     final BftContext bftContext = protocolContext.getConsensusState(BftContext.class);
+     final ValidatorProvider validatorProvider = bftContext.getValidatorProvider();
+-    checkState(validatorProvider.getVoteProvider().isPresent(), ""Bft requires a vote provider"");
++    checkState(
++        validatorProvider.getVoteProviderAfterBlock(parentHeader).isPresent(),
++        ""Bft requires a vote provider"");
+     final Optional<ValidatorVote> proposal =
+-        validatorProvider.getVoteProvider().get().getVoteAfterBlock(parentHeader, localAddress);
++        validatorProvider
++            .getVoteProviderAfterBlock(parentHeader)
++            .get()
++            .getVoteAfterBlock(parentHeader, localAddress);
+ 
+     final List<Address> validators =
+         new ArrayList<>(validatorProvider.getValidatorsAfterBlock(parentHeader));",nit: can extract the voteProvider as a local variable,Why do we need this change?
+564,"@@ -1190,14 +1190,8 @@ public class QueryEqualityTest extends SolrTestCaseJ4 {
+     assertFuncEquals(""gte(foo_i,2)"", ""gte(foo_i,2)"");
+     assertFuncEquals(""eq(foo_i,2)"", ""eq(foo_i,2)"");
+ 
+-    boolean equals = false;
+-    try {
+-      assertFuncEquals(""eq(foo_i,2)"", ""lt(foo_i,2)"");
+-      equals = true;
+-    } catch (AssertionError e) {
+-      //expected
+-    }
+-    assertFalse(equals);
++    expectThrows(AssertionError.class, ""expected error, functions are not equal"",
++        () -> assertFuncEquals(""eq(foo_i,2)"", ""lt(foo_i,2)""));
+   }
+ 
+   public void testChildField() throws Exception {","[0] Not suggesting you change it here, but....kindof weird that there's just not an `assertFuncNotEquals`",Why not use `assertThatThrownBy`?
+565,"@@ -61,3 +61,19 @@ func (bc *Blockchain) GetAccountantFee(accountantAddress common.Address) (uint16
+ 
+ 	return res.Value, err
+ }
++
++// IsRegistered checks wether the given identity is registered or not
++func (bc *Blockchain) IsRegistered(registryAddress, addressToCheck common.Address) (bool, error) {
++	caller, err := bindings.NewRegistryCaller(registryAddress, bc.client)
++	if err != nil {
++		return false, errors.Wrap(err, ""could not create registry caller"")
++	}
++
++	ctx, cancel := context.WithTimeout(context.Background(), bc.bcTimeout)
++	defer cancel()
++
++	res, err := caller.IsRegistered(&bind.CallOpts{
++		Context: ctx,
++	}, addressToCheck)
++	return res, errors.Wrap(err, ""could not check registration status"")
++}",why are we passing 'registryAddress' here? We probably should construct it together with bc. Registry is not something that change?,nit: `IsRegistered checks whether
+566,"@@ -2,7 +2,7 @@ import { pathOr, curry, merge } from 'ramda';
+ 
+ /**
+  * Flattens a property path so that its fields are spread out into the provided object.
+- *
++ * It's like {@link RA.spreadPath|spreadPath}, but preserves object under property path
+  *
+  * @func flattenPath
+  * @memberOf RA",`.` at the end of the sentence,I don't think this is correct. It
+567,"@@ -284,12 +284,16 @@ func (s *Service) checkAndAddPeers(ctx context.Context, peers pb.Peers) {
+ 			ctx, cancel := context.WithTimeout(ctx, pingTimeout)
+ 			defer cancel()
+ 
++			start := time.Now()
++
+ 			// check if the underlay is usable by doing a raw ping using libp2p
+ 			if _, err = s.streamer.Ping(ctx, multiUnderlay); err != nil {
++				s.metrics.PingTime.Observe(float64(time.Since(start).Milliseconds()))
+ 				s.metrics.UnreachablePeers.Inc()
+ 				s.logger.Debugf(""hive: peer %s: underlay %s not reachable"", hex.EncodeToString(newPeer.Overlay), multiUnderlay)
+ 				return
+ 			}
++			s.metrics.PingTime.Observe(float64(time.Since(start).Milliseconds()))
+ 
+ 			bzzAddress := bzz.Address{
+ 				Overlay:     swarm.NewAddress(newPeer.Overlay),",wouldn't it be useful to split this into an error metric for the timing?,I don't think we want to do this.
+568,"@@ -47,4 +47,8 @@ class TestFakerName < Test::Unit::TestCase
+     assert @tester.initials.match(/[A-Z]{3}/)
+     assert @tester.initials(2).match(/[A-Z]{2}/)
+   end
++
++  def test_fictional_character_name
++  assert @tester.fictional_character_name.match(/\w+/)
++  end
+ end","Not sure if this is good enough. Each generator will have it's own unit test anyway. Ideally, I think I'd want to test that each generator in the yml is actually a valid generator...",I think you can use `assert_match` here.
+569,"@@ -1293,6 +1293,8 @@ func newTestCFSM(
+ 				MintNewSecretBlock(gomock.Any(), gomock.Any(), gomock.Any()).Return(secretBlkToMint, nil).AnyTimes()
+ 			blockchain.EXPECT().
+ 				Nonce(gomock.Any()).Return(uint64(0), nil).AnyTimes()
++			blockchain.EXPECT().
++				MintNewBlockWithActionIterator(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(blkToMint, nil).AnyTimes()
+ 			if mockChain == nil {
+ 				candidates := make([]*state.Candidate, 0)
+ 				for _, delegate := range delegates {",line is 138 characters,Why do we need this?
+570,"@@ -75,8 +75,9 @@ type Params struct {
+ 	TraceOpts []ocsql.TraceOption
+ }
+ 
+-// Open opens a Cloud SQL database.
+-func Open(ctx context.Context, certSource proxy.CertSource, params *Params) (*sql.DB, error) {
++// Open opens a Cloud SQL database. The second return value is a Wire cleanup
++// function that calls Close on the returned database.
++func Open(ctx context.Context, certSource proxy.CertSource, params *Params) (*sql.DB, func(), error) {
+ 	// TODO(light): Avoid global registry once https://github.com/go-sql-driver/mysql/issues/771 is fixed.
+ 	dialerCounter.mu.Lock()
+ 	dialerNum := dialerCounter.n",Nit: I would leave `Wire` out of the description; if you use this without wire you can still use it.,Why is this a function and not a functio
+571,"@@ -14,10 +14,14 @@
+  */
+ package com.google.api.codegen.transformer.ruby;
+ 
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",Nit: each field can be on a separate line to make it visually easier to read.,nit: import order
+572,"@@ -336,6 +336,7 @@ def get_analysis_statistics(inputs, limits):
+                     statistics_files.append(compilation_db)
+             elif inp_f in ['compiler_includes.json',
+                            'compiler_target.json',
++                           'compiler_info.json',
+                            'metadata.json']:
+                 analyzer_file = os.path.join(input_path, inp_f)
+                 statistics_files.append(analyzer_file)",Do we still have these files? Shouldn't we remove these?,Why do we need this?
+573,"@@ -22,6 +22,11 @@ import (
+ 	""github.com/jetstack/cert-manager/pkg/apis/certmanager/v1alpha1""
+ )
+ 
++ const (
++ 	// Error reason generated when duration or renewBefore is invalid
++	ErrorDurationInvalid = ""ErrDurationInvalid""
++)
++
+ type Interface interface {
+ 	// Setup initialises the issuer. This may include registering accounts with
+ 	// a service, creating a CA and storing it somewhere, or verifying","A lot of things to do with constants seemed to move since the original commit, so I stuck this here, Is there a better place for it?",I think this should 
+574,"@@ -171,7 +171,9 @@ var (
+ 			RepeatDecayStep:       1,
+ 		},
+ 		Dispatcher: Dispatcher{
+-			EventChanSize: 10000,
++			ActionChanSize:    1000,
++			BlockChanSize:     1000,
++			BlockSyncChanSize: 10,
+ 		},
+ 		API: API{
+ 			UseRDS:    false,","is 10 too small compared to 1000? consider sync chan is unicast only (vs block chan is broadcast + unicast), i would say use 200~400 for BlockSyncChanSize my concern is that this would potentially slowdown sync speed of full-node",Why did you change t
+575,"@@ -297,7 +297,7 @@ module Bolt
+         errors.each do |error|
+           @logger.warn(error.details['original_error'])
+         end
+-        plans
++        plans.reject { |plan| get_plan_info(plan.first)['private'] }
+       end
+     end
+ ",A full parse of the plan here on listing the plans will be expensive from both a computation and IO perspective.,Why do we need to re
+576,"@@ -19,3 +19,9 @@ const (
+ 	BUTTON3 = 15
+ 	BUTTON4 = 16
+ )
++
++// UART pins for NRF52840-DK
++const (
++	UART_TX_PIN = 6
++	UART_RX_PIN = 8
++)","These constants use the `_PIN` suffix, while the other constants don't use it. I'm not sure what is best, but I would prefer to keep this consistent. Do you have an opinion on which it should be (with or without suffix)?",This should be `UART_TX_PIN`
+577,"@@ -1089,6 +1089,13 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+           ""Specifies the static node file containing the static nodes for this node to connect to"")
+   private final Path staticNodesFile = null;
+ 
++  @SuppressWarnings({""FieldCanBeFinal"", ""FieldMayBeFinal""}) // PicoCLI requires non-final Strings.
++  @CommandLine.Option(
++          names = { ""--dns-discovery-url"" },
++          description = ""Specifies the URL to use for DNS discovery""
++  )
++  private String dnsDiscoveryUrl = null;
++
+   private EthNetworkConfig ethNetworkConfig;
+   private JsonRpcConfiguration jsonRpcConfiguration;
+   private GraphQLConfiguration graphQLConfiguration;",Hmm... this feels like discovery should come first. perhaps `--discovery-dns-url`? @NicolasMassart any opinions on this or ideas on who it should be run by?,Why is this not final?
+578,"@@ -1,3 +1,4 @@
++//go:build !ignore_autogenerated
+ // +build !ignore_autogenerated
+ 
+ /*",why is this needed?,// +build !ignore_autogenera
+579,"@@ -23,7 +23,7 @@ DEFAULT_TYPE_ATTRIBUTES = ConfigTypeAttributes()
+ 
+ 
+ class ConfigType(object):
+-    def __init__(self, name=None, type_attributes=DEFAULT_TYPE_ATTRIBUTES, description=None):
++    def __init__(self, key, name, type_attributes=DEFAULT_TYPE_ATTRIBUTES, description=None):
+ 
+         type_obj = type(self)
+         if type_obj in ConfigType.__cache:","I wonder if it'd be possible to autogenerate a key from the name within this function if one is not provided explicitly, rather than having all the callsites pass both the name and key (and usually as the same value)? Might give us a good place to implement a `name->key` function that isn't 1:1.",Why do we need this change?
+580,"@@ -110,6 +110,7 @@ public final class ThriftCodec implements Codec {
+     final Field IPV4 = new Field(TYPE_I32, 1);
+     final Field PORT = new Field(TYPE_I16, 2);
+     final Field SERVICE_NAME = new Field(TYPE_STRING, 3);
++    final Field IPV6 = new Field(TYPE_STRING, 4);
+ 
+     @Override
+     public Endpoint read(ByteBuffer bytes) {",@adriancole I do not see a change in the thrift file. Are there unit tests verifying that this manual serialization is compatible with the native Thrift serialization done by classes generated from `.thrift` IDL file?,Shouldn't this be `TYPE_I16`?
+581,"@@ -506,7 +506,7 @@ Player* Game::getPlayerByGUID(const uint32_t& guid)
+ ReturnValue Game::getPlayerByNameWildcard(const std::string& s, Player*& player)
+ {
+ 	size_t strlen = s.length();
+-	if (strlen == 0 || strlen > 20) {
++	if (strlen == 0 || strlen > PLAYER_NAME_LENGHT) {
+ 		return RETURNVALUE_PLAYERWITHTHISNAMEISNOTONLINE;
+ 	}
+ ","spelling (variable name, all three changes)",This should be `PLAYER_NAME_L
+582,"@@ -411,8 +411,16 @@ type KeybaseService interface {
+ 		[]keybase1.PublicKey, error)
+ 
+ 	// LoadTeamPlusKeys returns a TeamInfo struct for a team with the
+-	// specified TeamID.
+-	LoadTeamPlusKeys(ctx context.Context, tid keybase1.TeamID) (TeamInfo, error)
++	// specified TeamID.  The caller can specify `desiredKeyGen` to
++	// force a server check if that particular key gen isn't yet
++	// known; it may be set to UnspecifiedKeyGen if no server check is
++	// required.  The caller can specify `desiredUID` to force a
++	// server check if that particular UID isn't a member of the team
++	// yet according to local caches; it may be set to """" if no server
++	// check is required.
++	LoadTeamPlusKeys(ctx context.Context, tid keybase1.TeamID,
++		desiredKeyGen KeyGen, desiredUser keybase1.UserVersion,
++		desiredRole keybase1.TeamRole) (TeamInfo, error)
+ 
+ 	// CurrentSession returns a SessionInfo struct with all the
+ 	// information for the current session, or an error otherwise.","I believe you meant ""specify `desiredUID` and `desiredRole`""?",I think this should be `desir
+583,"@@ -16,10 +16,9 @@ package openflow
+ 
+ import (
+ 	""fmt""
++	""github.com/vmware-tanzu/antrea/pkg/apis/networking/v1beta1""
+ 	""net""
+ 
+-	coreV1 ""k8s.io/api/core/v1""
+-	v1 ""k8s.io/api/networking/v1""
+ 	""k8s.io/klog""
+ 
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/types""","Please follow the import style, move it to its similar group",nit: remove empty line
+584,"@@ -63,3 +63,18 @@ func IsUnrecognizedProcedureError(err error) bool {
+ 	_, ok := err.(errors.UnrecognizedProcedureError)
+ 	return ok
+ }
++
++// UnrecognizedEncodingError returns an error for the given request, such that
++// IsUnrecognizedEncodingError can distinguish it from other errors coming out
++// of router.Choose.
++func UnrecognizedEncodingError(req *Request, want []string) error {
++	return errors.RouterUnrecognizedEncodingError(want, string(req.Encoding))
++}
++
++// IsUnrecognizedEncodingError returns true for errors returned by
++// Router.Choose if the router cannot find a handler for the request's
++// encoding.
++func IsUnrecognizedEncodingError(err error) bool {
++	_, ok := err.(errors.UnrecognizedEncodingError)
++	return ok
++}",Do we really need these? This is expanding on an API that we're about to do work on with the error stuff @kriskowal,I think this should be `errors.RouterUnrecognizedEncodingError`
+585,"@@ -146,11 +146,9 @@ public class PasswordValidatorServiceBean implements java.io.Serializable {
+      * @return A List with error messages. Empty when the password is valid.
+      */
+     public List<String> validate(String password, Date passwordModificationTime, boolean isHumanReadable) {
+-//    public List<String> validate(String password, boolean isHumanReadable) {
+ 
+         init();
+-        final PasswordData passwordData = PasswordData.newInstance(password, String.valueOf(passwordModificationTime.getTime()), null);
+-//        final PasswordData passwordData = PasswordData.newInstance(password, ""username"", null);
++        final PasswordData passwordData = new PasswordData(password);
+         final RuleResult result = new RuleResult();
+ 
+         for (PasswordValidator currentUser : validators.values()) {",passwordModificationTime is no longer used - did the change drop a time check that should be restored? Or should the param get dropped from the methods?,Why did you remove the creation of the password data?
+586,"@@ -40,7 +40,7 @@ namespace ScenarioMeasurement
+ 
+                 source.Kernel.ProcessStart += evt =>
+                 {
+-                    if (processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine == commandLine)
++                    if (processName.Equals(evt.ProcessName, StringComparison.OrdinalIgnoreCase) && pids.Contains(evt.ProcessID) && evt.CommandLine.Trim() == commandLine.Trim())
+                     {
+                         if (pid.HasValue)
+                         {","Would it break here without trim? If so, can we do trim in Startup.cs so we don't need to add this code to every parser?",Why are we trimming here?
+587,"@@ -115,7 +115,7 @@ var _ = Describe(""with running container"", func() {
+ 		It(""iptables should succeed in getting the lock after 3s"", func() {
+ 			iptCmd := cmdInContainer(""iptables"", ""-w"", ""3"", ""-A"", ""FORWARD"")
+ 			out, err := iptCmd.CombinedOutput()
+-			Expect(string(out)).To(ContainSubstring(""Another app is currently holding the xtables lock""))
++			log.Printf(""iptables output='%s'"", out)
+ 			Expect(err).NotTo(HaveOccurred())
+ 		})
+ ","Since we're using Logrus, probably best to use `Infof` to avoid confusion (Logrus' Printf behaves differently to the built in one)",Why did you remove this?
+588,"@@ -155,13 +155,14 @@ Blockly.FlyoutButton.prototype.createDom = function() {
+       this.svgGroup_);
+   svgText.textContent = this.text_;
+ 
+-  this.width = svgText.getComputedTextLength() +
+-      2 * Blockly.FlyoutButton.MARGIN;
++  this.width = svgText.getComputedTextLength();
+ 
+   if (!this.isLabel_) {
++    this.width += 2 * Blockly.FlyoutButton.MARGIN;
+     shadow.setAttribute('width', this.width);
+     shadow.setAttribute('height', this.height);
+   }
++
+   rect.setAttribute('width', this.width);
+   rect.setAttribute('height', this.height);
+ ","Hm, this looks like a change that should go upstream as well.",Why is this change needed?
+589,"@@ -1533,16 +1533,6 @@ func (core *coreService) ChainID() uint32 {
+ 	return core.bc.ChainID()
+ }
+ 
+-// GetActionByActionHash returns action by action hash
+-func (core *coreService) ActionByActionHash(h hash.Hash256) (action.SealedEnvelope, error) {
+-	if !core.hasActionIndex || core.indexer == nil {
+-		return action.SealedEnvelope{}, status.Error(codes.NotFound, blockindex.ErrActionIndexNA.Error())
+-	}
+-
+-	selp, _, _, _, err := core.getActionByActionHash(h)
+-	return selp, err
+-}
+-
+ // ReadContractStorage reads contract's storage
+ func (core *coreService) ReadContractStorage(ctx context.Context, addr address.Address, key []byte) ([]byte, error) {
+ 	ctx, err := core.bc.Context(ctx)",let's keep ActionByActionHash and delete getActionByActionHash,Why is this removed?
+590,"@@ -64,4 +64,12 @@ class ProductVisibility
+     {
+         return $this->visible;
+     }
++
++    /**
++     * @return \Shopsys\FrameworkBundle\Model\Pricing\Group\PricingGroup
++     */
++    public function getPricingGroup(): PricingGroup
++    {
++        return $this->pricingGroup;
++    }
+ }",please use return type,Missing return type
+591,"@@ -76,7 +76,7 @@ public class TestEdgeDriver extends RemoteWebDriver implements WebStorage, Locat
+                 .findFirst().orElseThrow(WebDriverException::new);
+ 
+         service = (EdgeDriverService) builder.withVerbose(true).withLogFile(logFile.toFile()).build();
+-        LOG.info(""edgedriver will log to "" + logFile);
++        LOG.fine(""edgedriver will log to "" + logFile);
+         service.start();
+         Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));
+       }",This is deliberately at this level.,Why is this change needed?
+592,"@@ -237,7 +237,7 @@ class UploadWorkerThread(TransferThread):
+             except self._retry_exceptions as e:
+                 log.error(""Exception caught uploading part number %s for ""
+                           ""vault %s, attempt: (%s / %s), filename: %s, ""
+-                          ""exception: %s, msg: %s"",
++                          ""exception: %s as msg: %s"",
+                           work[0], self._vault_name, i + 1, self._num_retries + 1,
+                           self._filename, e.__class__, e)
+                 time.sleep(self._time_between_retries)","I'm going to go ahead and undo this change, I don't think it was intentional.",I don't think this change is necessary.
+593,"@@ -163,7 +163,7 @@ namespace Datadog.AutoInstrumentation.ManagedLoader
+         /// As a result, the target framework moniker and the binary compatibility flags are initialized correctly.
+         /// </summary>
+         /// <remarks>
+-        /// The above logic is further specialised, depending on the kind of the currnent AppDomain and where the app is hosted:
++        /// The above logic is further specialized, depending on the kind of the current AppDomain and where the app is hosted:
+         /// <br />
+         /// * On non-default AD:
+         ///   we do not wait.",> specialised This isn't a typo in my neck of the woods  ,I don't think we should change this.
+594,"@@ -29,6 +29,7 @@ import (
+ 
+ var packages = []string{
+ 	""github.com/google/knative-gcp/test/cmd/target"",
++	""github.com/google/knative-gcp/test/cmd/storageTarget"",
+ }
+ 
+ var packageToImageConfig = map[string]string{}",will change to `storage_target`,nit: can we remove this empty line?
+595,"@@ -38,7 +38,7 @@ class SecurityCenterTest(unittest_utils.ForsetiTestCase):
+         """"""Set up.""""""
+         fake_global_configs = {
+             'securitycenter': {'max_calls': 1, 'period': 1.1}}
+-        cls.securitycenter_beta_api_client = securitycenter.SecurityCenterClient(version='v1beta1')
++        cls.securitycenter = securitycenter.SecurityCenterClient(version='v1')
+         cls.project_id = 111111
+         cls.source_id = 'organizations/111/sources/222'
+ ","This would be better as `cls.securitycenter_client`, to match what is being instantiated.",Why did you change this?
+596,"@@ -34,6 +34,15 @@ import appModules
+ import watchdog
+ import extensionPoints
+ from fileUtils import getFileVersionInfo
++import shlobj
++from functools import wraps
++
++# Path to the native system32 directory.
++nativeSys32: str = shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEM)
++# Path to the syswow64 directory if it exists on the current system.
++Syswow64Sys32: str = shlobj.SHGetFolderPath(None, shlobj.CSIDL.SYSTEMX86)
++# Do we have separate system32 directories for 32 and 64-bit processes?
++hasSeparateSyswow64: bool = nativeSys32 != Syswow64Sys32
+ 
+ #Dictionary of processID:appModule paires used to hold the currently running modules
+ runningTable={}",Could we have this initialization as part of the initialize method?,Why do we need this?
+597,"@@ -15,7 +15,7 @@ export default AbstractEditController.extend({
+   showUpdateButton: true,
+ 
+   database: inject.service(),
+-  editController: inject.controller('patients/edit'),
++  editController: null,
+   filesystem: inject.service(),
+ 
+   photoFileNotSet: computed('model.photoFile', function() {",This line should be removed as editController is not used from this context anymore.,Why is this null?
+598,"@@ -9,11 +9,17 @@ import (
+ 	""github.com/influxdata/flux/plan""
+ )
+ 
++// Transformation represents functions that control of how the execution
++// engine will take in a flux Table, perform the necessary data processing
++// and return an output flux Table
+ type Transformation interface {
+ 	RetractTable(id DatasetID, key flux.GroupKey) error
++	// Process takes in a flux Table, performs data processing on it
++	// and produces an output flux Table
+ 	Process(id DatasetID, tbl flux.Table) error
+ 	UpdateWatermark(id DatasetID, t Time) error
+ 	UpdateProcessingTime(id DatasetID, t Time) error
++	// Finish indicates that the Transformation is complete
+ 	Finish(id DatasetID, err error)
+ }
+ ","This is correct in concept but the method signature doesn't really communicate the same thing. In other words, if the function produces an output table where is it? Its not on the function signature. Can you explain where the output table is created?",nit: `RetractTable r
+599,"@@ -238,9 +238,14 @@ class DetectoRS_ResNet(ResNet):
+                  pretrained=None,
+                  init_cfg=None,
+                  **kwargs):
+-        assert init_cfg is None, 'To prevent abnormal initialization ' \
+-                                 'behavior, init_cfg is not allowed to be set'
+-        self.pretrained = pretrained
++        self.init_cfg = init_cfg
++        if init_cfg is not None:  # init_cfg priority > pretrained
++            self.pretrained = init_cfg['checkpoint']
++        else:
++            if pretrained is not None:
++                self.pretrained = pretrained
++            else:
++                self.pretrained = None
+         self.sac = sac
+         self.stage_with_sac = stage_with_sac
+         self.rfp_inplanes = rfp_inplanes","For insurance, it's best not to take it directly",I don't think this i
+600,"@@ -67,11 +67,11 @@ public abstract class AbstractWebDriverEventListener implements WebDriverEventLi
+     // Do nothing.
+   }
+ 
+-  public void beforeChangeValueOf(WebElement element, WebDriver driver) {
++  public void beforeChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) {
+     // Do nothing.
+   }
+ 
+-  public void afterChangeValueOf(WebElement element, WebDriver driver) {
++  public void afterChangeValueOf(WebElement element, WebDriver driver, CharSequence[] value) {
+     // Do nothing.
+   }
+ ","change 'value' to keysToSend, here and in other references in this commit. 'value' implies the user is getting the value of the element, rather than just the keys we're sending to it.",Why do we need this change?
+601,"@@ -1244,6 +1244,8 @@ func (engine *DockerTaskEngine) provisionContainerResources(task *apitask.Task,
+ 	taskIP := result.IPs[0].Address.IP.String()
+ 	seelog.Infof(""Task engine [%s]: associated with ip address '%s'"", task.Arn, taskIP)
+ 	engine.state.AddTaskIPAddress(taskIP, task.Arn)
++	task.SetLocalIPAddress(taskIP)
++	engine.saveTaskData(task)
+ 	return dockerapi.DockerContainerMetadata{
+ 		DockerID: cniConfig.ContainerID,
+ 	}",is the plan to fully migrate to boltdb and then remove the state save here?,Why do we need this?
+602,"@@ -153,6 +153,8 @@ function themeStyle(theme) {
+ 
+ 		output.colorUrl = '#7B81FF';
+ 
++		output.strongTextColor = 'rgb(220,220,220)';
++
+ 		themeCache_[theme] = output;
+ 		return addExtraStyles(themeCache_[theme]);
+ 	}",This should be `output.colorBright`. Unless I'm missing some reason for adding a new theme variable.,I think this should be `rgb
+603,"@@ -6,6 +6,11 @@
+ 
+ import os
+ 
++version_year=2016
++version_major=3
++version_minor=0
++version_build=0
++
+ def _updateVersionFromVCS():
+ 	""""""Update the version from version control system metadata if possible.
+ 	""""""","nit: I wonder if these should be moved down to where version is defined, just to keep them all in the same place.",I don't think we need this 
+604,"@@ -99,7 +99,7 @@ const LanguageParameters& GetLangParams(IDLOptions::Language lang) {
+       """",
+       """",
+       """",
+-      ""import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\n""
++      ""import java.nio.*;\nimport java.lang.*;\nimport java.util.*;\nimport javax.annotation.*;\n""
+         ""import com.google.flatbuffers.*;\n\n@SuppressWarnings(\""unused\"")\n"",
+       {
+         ""/**"",",Is this supported by every implementation of Java (and Android)? Should it be conditional upon `gen_nullable`?,"""import java.util.*;\nimport javax.annotation.*;\n"","
+605,"@@ -50,8 +50,8 @@ class Phase < ActiveRecord::Base
+   has_many :suffix_sections, -> (phase) {
+     modifiable.where(<<~SQL, phase_id: phase.id, modifiable: false)
+       sections.number > (SELECT MAX(number) FROM sections
+-                           WHERE sections.modifiable = :modifiable)
+-                           AND sections.phase_id = :phase_id
++                           WHERE sections.modifiable = :modifiable
++                           AND sections.phase_id = :phase_id)
+     SQL
+   }, class_name: ""Section""
+ ",@briri Thanks! I just caught this too updating my feature branch,Layout/TrailingWhitespace: Trailing whitespace detec
+606,"@@ -214,8 +214,17 @@ var errorConfigFileNotFound = errors.New(""config file not found"")
+ // automatically decrypt it.
+ func loadConfigFile() (*goconfig.ConfigFile, error) {
+ 	b, err := ioutil.ReadFile(ConfigPath)
++	envpw := os.Getenv(""RCLONE_CONFIG_PASS"")
+ 	if err != nil {
+ 		if os.IsNotExist(err) {
++			if len(configKey) == 0 && envpw != """" {
++				err := setConfigPassword(envpw)
++				if err != nil {
++					fmt.Println(""Using RCLONE_CONFIG_PASS returned:"", err)
++				} else {
++					fs.Debugf(nil, ""Using RCLONE_CONFIG_PASS password."")
++				}
++			}
+ 			return nil, errorConfigFileNotFound
+ 		}
+ 		return nil, err","I think you should move this block (and the `envpw := os.Getenv(""RCLONE_CONFIG_PASS"")`) right to the start of the function, then we can remove the duplicate code below","Should this be `fs.Debugf(nil, ""Using RCLONE_CONFIG_"
+607,"@@ -424,6 +424,17 @@ public class NodeTest {
+     return baseDir;
+   }
+ 
++  //Test that the draining command sets Host status to DRAINING
++  @Test
++  public void drainingNodeStatusDraining() {
++
++  }
++
++  //Test that a draining node doesn't accept new sessions by any means
++  //Test that a draining node continues to run its sessions and accept new WebDriver commands
++  //Test that a node will shut down once all sessions are finished
++  //Test that RemoteNode will post the correct command oto the LocalNode
++
+   private CreateSessionRequest createSessionRequest(Capabilities caps) {
+     return new CreateSessionRequest(
+             ImmutableSet.copyOf(Dialect.values()),",Is this only to set the node to draining?   I think we can do that inside `Before` or something?,nit: space after `//`
+608,"@@ -647,6 +647,11 @@ namespace Datadog.Trace
+             {
+                 try
+                 {
++                    if (AzureAppServices.Metadata.IsRelevant)
++                    {
++                        return AzureAppServices.Metadata.SiteName;
++                    }
++
+                     if (TryLoadAspNetSiteName(out var siteName))
+                     {
+                         return siteName;",This should have been moved up above this inner `try` because the log message in the `catch` block does not apply to this.,Why do we need this?
+609,"@@ -43,12 +43,13 @@ module Bolt
+       Bolt::ResultSet.include_iterable
+     end
+ 
+-    # Create a top-level alias for TargetSpec so that users don't have to
++    # Create a top-level alias for TargetSpec and PlanResult so that users don't have to
+     # namespace it with Boltlib, which is just an implementation detail. This
+-    # allows TargetSpec to feel like a built-in type in bolt, rather than
++    # allows them to feel like a built-in type in bolt, rather than
+     # something has been, no pun intended, ""bolted on"".
+-    def add_target_spec(compiler)
++    def alias_types(compiler)
+       compiler.evaluate_string('type TargetSpec = Boltlib::TargetSpec')
++      compiler.evaluate_string('type PlanResult = Boltlib::PlanResult')
+     end
+ 
+     def full_modulepath(modulepath)",Do we expect people to use PlanResult directly?,I think this should 
+610,"@@ -48,7 +48,8 @@ func NewBackoff() wait.Backoff {
+ 
+ // WaitForWithRetryable repeats a condition check with exponential backoff.
+ func WaitForWithRetryable(backoff wait.Backoff, condition wait.ConditionFunc, retryableErrors ...string) error { //nolint
+-	return wait.ExponentialBackoff(backoff, func() (bool, error) {
++	var actualErr error
++	waitErr := wait.ExponentialBackoff(backoff, func() (bool, error) {
+ 		ok, err := condition()
+ 		if ok {
+ 			// All done!",Maybe we should call this something like `errToReturn`?,`actualErr` is never
+611,"@@ -215,7 +215,8 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+ 
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch {
++	fairBankEpochNum := rp.GetEpochNum(hu.FairbankBlockHeight()) // extend foundation bonus from fairbank to fairbank + 1 year
++	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= fairBankEpochNum && epochNum <= fairBankEpochNum+a.foundationBonusLastEpoch) {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","should calculate numEpochIn1Year = xxx and <= fairBankEpochNum+numEpochIn1Year a.foundationBonusLastEpoch just happens to be equal to 1 year now, but should not count on that",I think this should 
+612,"@@ -350,14 +350,17 @@ const htmlElms = {
+       },
+       usemap: {
+         matches: '[usemap]',
+-        contentTypes: ['interactive', 'embedded', 'phrasing', 'flow']
++        contentTypes: ['interactive', 'embedded', 'flow']
+       },
+       default: {
+         // Note: allow role presentation and none on image with no
+         // alt as a way to prevent axe from flagging the image as
+         // needing an alt
+         allowedRoles: ['presentation', 'none'],
+-        contentTypes: ['embedded', 'phrasing', 'flow']
++        // Note: spec change (do not count as phrasing), because browsers
++        // insert a space between an img's accessible name and other
++        // elements' accessible names
++        contentTypes: ['embedded', 'flow']
+       }
+     },
+     // 5.10 img Element",I wasn't sure if the content type needed to be removed from both the `default` and `usemap` objects - I'm not sure how usemap is used.,"I'm not sure if this is the right way to do this, but I think it would be good to have a test for this."
+613,"@@ -20,11 +20,13 @@
+ """"""
+ Geneve: Generic Network Virtualization Encapsulation
+ 
+-draft-ietf-nvo3-geneve-06
++draft-ietf-nvo3-geneve-16
+ """"""
+ 
++import struct
++
+ from scapy.fields import BitField, XByteField, XShortEnumField, X3BytesField, \
+-    XStrField
++    XStrField, XShortField, StrField, XByteField, FieldLenField, PacketListField
+ from scapy.packet import Packet, bind_layers
+ from scapy.layers.inet import IP, UDP
+ from scapy.layers.inet6 import IPv6","Duplication of line 28 Please refer your tox -e flake8 It seems that XStrField, XShortField, FieldLenField are not used",Why did you change this?
+614,"@@ -630,6 +630,18 @@ class FilenamePrompt(_BasePrompt):
+ 
+         self._to_complete = ''
+ 
++    def _directories_hide_show_model(self, path):
++        """"""Get rid of non-matching directories.""""""
++        try:
++            num_rows = self._file_model.rowCount(self._root_index)
++            for row in range(num_rows):
++                index = self._file_model.index(row, 0, self._file_model.index(path))
++                hidden = self._to_complete not in index.data()
++                self._file_view.setRowHidden(index.row(), index.parent(), hidden)
++        except FileNotFoundError:
++            log.prompt.debug(""Directory doesn't exist, can't \
++                                hide and unhide file prompt folders"")
++
+     @pyqtSlot(str)
+     def _set_fileview_root(self, path, *, tabbed=False):
+         """"""Set the root path for the file display.""""""","I don't really understand the `self._file_model.index(path)` as parent here - you use `self._root_index` for `rowCount` above, so wouldn't the parent here need to be `self._root_index` as well?",Please use `log.warning` instead of `log.prompt.debug`.
+615,"@@ -75,6 +75,8 @@ public class DirectSpellChecker {
+   private float thresholdFrequency = 0f;
+   /** minimum length of a query word to return suggestions */
+   private int minQueryLength = 4;
++  /** maximum length of a query word to return suggestions */
++  private int maxQueryLength = 0;
+   /** value in [0..1] (or absolute number &gt;= 1) representing the maximum
+    *  number of documents (of the total) a query term can appear in to
+    *  be corrected. */",Do we want validation somewhere that max >= min? Or simply treat the max < min case as ignoring max?,I think this should be `int maxQueryLength = 4;`
+616,"@@ -81,7 +81,7 @@ namespace NLog.LayoutRenderers
+         {
+             if (TopFrames == 1)
+             {
+-                // Allows fast rendering of ${when:when='${ndc:topframes=1}' == '':inner=:else=${ndc}|}
++                // Allows fast rendering of ${ndc:topframes=1}
+                 var topFrame = NestedDiagnosticsContext.PeekObject();
+                 if (topFrame != null)
+                     AppendAsString(topFrame, GetFormatProvider(logEvent), builder);",:+1: that's a easier example :),Why is this change needed?
+617,"@@ -117,4 +117,9 @@ interface ProductQueryInterface
+      * @return AttributeId[]
+      */
+     public function findAttributeIdsByProductId(ProductId $productId): array;
++
++    /**
++     * @return array
++     */
++    public function findProductIdsWithBoundAttributeByAttributeId(AggregateId $id): array;
+ }","If an external module decorates this interface, such a change will cause it to generate an error",`findProductIdsWithBoundAt
+618,"@@ -254,7 +254,7 @@ static int jobtap_remove (struct jobtap *jobtap,
+     while (p) {
+         const char *name = jobtap_plugin_name (p);
+         if (all
+-            || (isglob && fnmatch (arg, name, 0) == 0)
++            || (isglob && fnmatch (arg, name, FNM_PERIOD) == 0)
+             || strcmp (arg, name) == 0) {
+             zlistx_detach_cur (jobtap->plugins);
+             flux_plugin_destroy (p);","Oh ha hah, FNM_PERIOD worked out nicely there. Points for co-opting a file system convention.",`FNM_PERIOD` should be `FN
+619,"@@ -7,11 +7,12 @@
+ package action
+ 
+ import (
++	""encoding/hex""
+ 	""fmt""
+-	""math/big""
+-
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""
++	""math/big""
++	""strings""
+ 
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/account""","wrong grouping. As you can tell from the other files, we put system packages in the first group, the 3rd party packages in the second group, and our own packages in the third group.",nit: remove empty line
+620,"@@ -78,8 +78,10 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) {
+ // Validate returns an error if the values provided by flags are invalid.
+ func (o *jobLogsOpts) Validate() error {
+ 	if o.appName != """" {
+-		_, err := o.configStore.GetApplication(o.appName)
+-		if err != nil {
++		if _, err := o.configStore.GetApplication(o.appName); err != nil {
++			return err
++		}
++		if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {
+ 			return err
+ 		}
+ 	}",Is `o.name` always set here?,Shouldn't this be `o.name`?
+621,"@@ -73,7 +73,8 @@ func dependenciesCanBeResolved(target *api.Container, by []*api.Container) bool
+ 	}
+ 
+ 	return verifyStatusResolvable(target, nameMap, neededVolumeContainers, volumeCanResolve) &&
+-		verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve)
++		verifyStatusResolvable(target, nameMap, linksToContainerNames(target.Links), linkCanResolve) &&
++		verifyStatusResolvable(target, nameMap, target.SteadyStateDependencies, onSteadyStateCanResolve)
+ }
+ 
+ // DependenciesAreResolved validates that the `target` container can be","Can this line be removed, as `SteadyStateDependencies` isn't updated anywhere? Also do we need to check the `TransitionDependencySet` here?",Why do we need this check?
+622,"@@ -73,7 +73,7 @@ class User < ActiveRecord::Base
+   end
+ 
+   def eligible_for_annual_upgrade?
+-    plan.present? && plan.has_annual_plan?
++    has_active_subscription? && plan.present? && plan.has_annual_plan?
+   end
+ 
+   def annualized_payment","`plan.present?` and `has_active_subscription?` are equivalent. We can drop this change, while leaving the one on `app/controllers/application_controller.rb`.",I don't think we need the `
+623,"@@ -100,6 +100,7 @@ class Command:
+         if scope != 'global' and instance is None:
+             raise ValueError(""Setting scope without setting instance makes ""
+                              ""no sense!"")
++        # pylint: enable=too-many-locals
+ 
+         self.name = name
+         self.maxsplit = maxsplit","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",Why is this needed?
+624,"@@ -188,7 +188,7 @@ func (c *Operator) bootstrap(ctx context.Context) error {
+ 	}
+ 	c.secrInfs, err = informers.NewInformersForResource(
+ 		informers.NewKubeInformerFactories(
+-			c.config.Namespaces.AllowList,
++			c.config.Namespaces.AlertmanagerConfigAllowList,
+ 			c.config.Namespaces.DenyList,
+ 			c.kclient,
+ 			resyncPeriod,",L171 needs to be modified too?,I think this should be `AlertmanagerConfigDenyList`
+625,"@@ -19,6 +19,16 @@ See the file COPYING for details.
+ #include <stdlib.h>
+ #include <unistd.h>
+ 
++int dag_node_comp(void *item, const void *arg)
++{
++	struct dag_node *d = ((struct dag_node *) item);
++	struct dag_node *e = ((struct dag_node *) arg);
++
++	if(d->nodeid == e->nodeid)
++		return 1;
++	return 0;
++}
++
+ struct dag_node *dag_node_create(struct dag *d, int linenum)
+ {
+ 	struct dag_node *n;","Why do you compare by nodeid? Simply saying d == e should be enough. Unless we have to objects in memory with the same nodeid. If that is so, something went really wrong.",Why is this needed?
+626,"@@ -0,0 +1,18 @@
++_base_ = [
++    '../_base_/models/retinanet_r50_fpn.py',
++    '../_base_/datasets/coco_detection.py',
++    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
++]
++model = dict(
++    type='RetinaNet',
++    backbone=dict(
++        _delete_=True,
++        type='PyramidVisionTransformer',
++        num_layers=[2, 2, 2, 2],
++        init_cfg=dict(
++            type='Pretrained',
++            checkpoint='https://github.com/whai362/PVT/'
++            'releases/download/v2/pvt_tiny.pth')),
++    neck=dict(in_channels=[64, 128, 320, 512]))
++# optimizer
++optimizer = dict(_delete_=True, type='AdamW', lr=0.0001, weight_decay=0.0001)",configs/pvt/retinanet_pvt_t_fpn_1x_coco.py --> configs/pvt/retinanet_pvt-t_fpn_1x_coco.py,why do we need this?
+627,"@@ -20,7 +20,7 @@ type MetadataResponse struct {
+ 
+ type TaskResponse struct {
+ 	Arn           string
+-	DesiredStatus string
++	DesiredStatus string `json:""DesiredStatus,omitempty""`
+ 	KnownStatus   string
+ 	Family        string
+ 	Version       string","Nit, this could be json:"",omitempty""","Is there a reason why we don't use `json:"",inline""`"
+628,"@@ -113,7 +113,12 @@ func tplDirName(s string) string {
+ 	return filepath.Dir(s)
+ }
+ 
+-//BuildArgs returns a docker.BuildArguments object given a ws root directory.
++// BuildRequired returns if the service requires building from the local Dockerfile.
++func (s *LoadBalancedWebService) BuildRequired() (bool, error) {
++	return buildRequired(s.Image.Image)
++}
++
++// BuildArgs returns a docker.BuildArguments object given a ws root directory.
+ func (s *LoadBalancedWebService) BuildArgs(wsRoot string) *DockerBuildArgs {
+ 	return s.Image.BuildConfig(wsRoot)
+ }",It's kinda funny to read `s.Image.Image` I wonder why it resulted to this way. What would it take to refactor to just `s.Image`?,I don't think we need this method.
+629,"@@ -1,4 +1,4 @@
+-// +build integration
++// +build integration,deploy
+ 
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ // SPDX-License-Identifier: Apache-2.0",nit: I like the idea! can we instead change the tag to `integration-remote` to be more specific? I feel like it's possible for us to use the `deploy` build tag for possibly another scenario,This should be `+build integration
+630,"@@ -4701,8 +4701,8 @@ XS(XS_Mob_HasNPCSpecialAtk) {
+ XS(XS_Mob_SendAppearanceEffect); /* prototype to pass -Wmissing-prototypes */
+ XS(XS_Mob_SendAppearanceEffect) {
+ 	dXSARGS;
+-	if (items < 2 || items > 7)
+-		Perl_croak(aTHX_ ""Usage: Mob::SendAppearanceEffect(THIS, int32 param_1, [int32 param_2 = 0], [int32 param_3 = 0], [int32 param_4 = 0], [int32 param_5 = 0], [Client* single_client_to_send_to = null])""); // @categories Script Utility
++	if (items < 2 || items > 17)
++		Perl_croak(aTHX_ ""Usage: Mob::SendAppearanceEffect(THIS, int32 effect1, [int32 effect2 = 0], [int32 effect3 = 0], [int32 effect4 = 0], [int32 effect5 = 0], [Client* single_client_to_send_to = null]), [uint32 slot1 = 1], [uint32 ground1 = 1], [uint32 slot2 = 1], [uint32 ground2 = 1], [uint32 slot3 = 1], [uint32 ground2 = 1], [uint32 slot4 = 1], [uint32 ground4 = 1], [uint32 slot5 = 1], [uint32 ground5 = 1]""); // @categories Script Utility
+ 	{
+ 		Mob *THIS;
+ 		int32 parm1 = (int32) SvIV(ST(1));",Copy and paste error here. Edit: Also missing commas here and in other Perl croaks between some parameters and not others.,Why did you change this?
+631,"@@ -16,11 +16,12 @@
+ 
+ using System.Collections.Generic;
+ using Nethermind.Core;
++using Nethermind.Core.Crypto;
+ 
+ namespace Nethermind.Consensus
+ {
+     public interface IPendingTxSelector
+     {
+-        IEnumerable<Transaction> SelectTransactions(long gasLimit);
++        IEnumerable<Transaction> SelectTransactions(Keccak stateRoot, long gasLimit);
+     }
+ }",stateRoot or maybe ParentHeader would make more sense from API point of view?,Why do we need this interface?
+632,"@@ -151,7 +151,6 @@ public class PlaybackServiceFlavorHelper {
+                 // hardware volume buttons control the local device volume
+                 mediaRouter.setMediaSessionCompat(null);
+                 unregisterWifiBroadcastReceiver();
+-                callback.setupNotification(false, info);
+             }
+         };
+     }",Are you sure that this is no longer needed?,Why was this removed?
+633,"@@ -57,7 +57,11 @@ class BaseTableScan implements TableScan {
+   private static final Logger LOG = LoggerFactory.getLogger(TableScan.class);
+ 
+   private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat(""yyyy-MM-dd HH:mm:ss.SSS"");
+-  private static final List<String> SNAPSHOT_COLUMNS = ImmutableList.of(
++  private static final List<String> SCAN_COLUMNS = ImmutableList.of(
++      ""snapshot_id"", ""file_path"", ""file_ordinal"", ""file_format"", ""block_size_in_bytes"",
++      ""file_size_in_bytes"", ""record_count"", ""partition""
++  );
++  private static final List<String> SCAN_WITH_STATS_COLUMNS = ImmutableList.of(
+       ""snapshot_id"", ""file_path"", ""file_ordinal"", ""file_format"", ""block_size_in_bytes"",
+       ""file_size_in_bytes"", ""record_count"", ""partition"", ""value_counts"", ""null_value_counts"",
+       ""lower_bounds"", ""upper_bounds""","Would it help to use SCAN_COLUMNS as base to build SCAN_WITH_STATS_COLUMNS e.g like so `SCAN_WITHSTATS_COLUMNS = ImmutableList.<String>builder().addAll(SCAN_COLUMNS).add(""value_counts"",....).build()` ?",nit: rename to `SNAPS
+634,"@@ -85,11 +85,19 @@ func (a *PipedAPI) Register(server *grpc.Server) {
+ 
+ // Ping is periodically sent to report its realtime status/stats to control-plane.
+ // The received stats will be pushed to the metrics collector.
++// Note: This service is deprecated, use ReportStat instead.
+ func (a *PipedAPI) Ping(ctx context.Context, req *pipedservice.PingRequest) (*pipedservice.PingResponse, error) {
+ 	return &pipedservice.PingResponse{}, nil
+ 	// return nil, status.Error(codes.Unimplemented, """")
+ }
+ 
++// ReportStat is periodically sent to report its realtime status/stats to control-plane.
++// The received stats will be pushed to the metrics collector.
++func (a *PipedAPI) ReportStat(ctx context.Context, req *pipedservice.ReportStatRequest) (*pipedservice.ReportStatResponse, error) {
++	return &pipedservice.ReportStatResponse{}, nil
++	// return nil, status.Error(codes.Unimplemented, """")
++}
++
+ // ReportPipedMeta is sent by piped while starting up to report its metadata
+ // such as configured cloud providers.
+ func (a *PipedAPI) ReportPipedMeta(ctx context.Context, req *pipedservice.ReportPipedMetaRequest) (*pipedservice.ReportPipedMetaResponse, error) {",`ctx` is unused in ReportStat,Can we remove this?
+635,"@@ -21,12 +21,15 @@
+ #include <fstream>
+ #include <iostream>
+ #include <vector>
++#include <list>
++#include <map>
+ 
+ #include <stdlib.h>
+ #include <sys/stat.h>
+ #include <sys/types.h>
+ #include <sstream>
+ #include <algorithm>
++
+ #include ""t_generator.h""
+ #include ""platform.h""
+ #include ""version.h""",We don't want to add boost as a dependency when building the Thrift compiler. Sorry.,Why is this needed?
+636,"@@ -323,7 +323,8 @@ bool Monsters::deserializeSpell(const pugi::xml_node& node, spellBlock_t& sb, co
+ 			combat->setParam(COMBAT_PARAM_TYPE, COMBAT_HEALING);
+ 			combat->setParam(COMBAT_PARAM_AGGRESSIVE, 0);
+ 		} else if (tmpName == ""speed"") {
+-			int32_t speedChange = 0;
++			int32_t minSpeedChange = 0;
++			int32_t maxSpeedChange = 0;
+ 			int32_t duration = 10000;
+ 
+ 			if ((attr = node.attribute(""duration""))) {",It's not printing the range. Also I think it's useful to print a warning above stating that the minimum change is -1000.,Shouldn't this be `maxSpeedChange`?
+637,"@@ -332,3 +332,15 @@ func (c *clusterClient) SchedPolicyDelete(name string) error {
+ 
+ 	return nil
+ }
++
++// SchedPolicyGet returns schedule policy matching given name.
++func (c *clusterClient) SchedPolicyGet(name string) (*sched.SchedPolicy, error) {
++	policy := new(sched.SchedPolicy)
++	req := c.c.Get().Resource(clusterPath + SchedPath + ""/"" + name)
++
++	if err := req.Do().Unmarshal(policy); err != nil {
++		return nil, err
++	}
++
++	return policy, nil
++}",if name is empty will this become enumerate ? (and cause the unmarshal to fail ?),nit: `SchedPolicyGet returns schedu
+638,"@@ -15,7 +15,7 @@ module ProductsHelper
+     if current_user_has_access_to?(:exercises)
+       link_to url, options, &block
+     else
+-      content_tag ""a"", &block
++      link_to edit_subscription_path, options, &block
+     end
+   end
+ end",How about including a flash message that explains the exercises are only available to subscribers of X plan?,I think this should be `edit_subscr
+639,"@@ -232,6 +232,11 @@ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
+         Enter/Shift+Enter/etc. will cause QLineEdit to think it's finished
+         without command_accept to be called.
+         """"""
++        text = self.text()
++        if text in modeparsers.STARTCHARS and e.key() == Qt.Key_Backspace:
++            modeman.leave(self._win_id, usertypes.KeyMode.command,
++                          'prefix deleted')
++
+         if e.key() == Qt.Key_Return:
+             e.ignore()
+             return",You should also call `e.accept()` and `return` so the key press isn't processed further (as we're leaving insert mode anyways).,Please remove this blank line.
+640,"@@ -0,0 +1,14 @@
++MAIL_SETTINGS = {
++  address: ""smtp.sendgrid.net"",
++  port: ""587"",
++  authentication: :plain,
++  user_name: ENV[""SENDGRID_USERNAME""],
++  password: ENV[""SENDGRID_PASSWORD""],
++  domain: ""heroku.com""
++}
++
++if ENV[""EMAIL_RECIPIENTS""]
++  Mail.register_interceptor(
++    RecipientInterceptor.new(ENV.fetch(""EMAIL_RECIPIENTS"")),
++  )
++end",Freeze mutable objects assigned to constants.,"This should be `ENV[""EMAIL_RECIPIENTS""]`"
+641,"@@ -34,8 +34,11 @@ import {
+ 
+ async function toggleOptIn() {
+ 	await page.waitForSelector( '#googlesitekit-opt-in' );
+-	await expect( page ).toClick( '#googlesitekit-opt-in' );
+-	await page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) );
++	await pageWait();
++	await Promise.all( [
++		page.waitForResponse( ( res ) => res.url().match( 'wp/v2/users/me' ) ),
++		expect( page ).toClick( '#googlesitekit-opt-in' ),
++	] );
+ }
+ 
+ describe( 'management of tracking opt-in/out via settings page', () => {","Hmm, this feels hacky. Maybe good enough if it makes the test more stable, but why is timing even an aspect here, since below it should wait for these two things anyway?",I don't think we need the `pageWait` her
+642,"@@ -144,6 +144,12 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Implementation
+                 {
+                     activity.SetTag(SemanticConventions.AttributeHttpUserAgent, userAgent);
+                 }
++
++                var xForwardedFor = request.Headers[""X-Forwarded-For""].FirstOrDefault();
++                if (!string.IsNullOrEmpty(xForwardedFor))
++                {
++                    activity.SetTag(SemanticConventions.AttributeHttpClientIP, xForwardedFor.Split(',').First().Trim());
++                }
+             }
+         }
+ ","Do we want this on by default, or an opt-in (e.g. via some config while add the instrumentation)? I guess a more general question is - what's the bar for the default vs opt-in tags.",I think this should be `if (xForwardedFo
+643,"@@ -91,7 +91,7 @@ int main(int argc, char *argv[]) {
+     }
+ 
+     LOG(INFO) << ""Starting Graph HTTP Service"";
+-    nebula::WebService::registerHandler(""/graph"", [] {
++    nebula::WebService::registerHandler(""/status"", [] {
+         return new nebula::graph::GraphHttpHandler();
+     });
+     status = nebula::WebService::start();","`status` is just one of the features, named as status is not suitable.",Why do we need this change?
+644,"@@ -296,9 +296,17 @@ public class NavListAdapter extends BaseAdapter
+                 .getSystemService(Context.LAYOUT_INFLATER_SERVICE);
+ 
+         convertView = inflater.inflate(R.layout.nav_section_item, parent, false);
++        TextView feedsFilteredMsg = convertView.findViewById(R.id.nav_feeds_filtered_message);
+ 
+-        convertView.setEnabled(false);
+-        convertView.setOnClickListener(null);
++        if (UserPreferences.getFeedFilter() != UserPreferences.FEED_FILTER_NONE) {
++            convertView.setEnabled(true);
++            feedsFilteredMsg.setText(""{md-info-outline} "" + context.getString(R.string.feed_is_filtered));
++            Iconify.addIcons(feedsFilteredMsg);
++            feedsFilteredMsg.setVisibility(View.VISIBLE);
++        } else {
++            convertView.setEnabled(false);
++            feedsFilteredMsg.setVisibility(View.GONE);
++        }
+ 
+         return convertView;
+     }","There is an option to hide the subscriptions list from the sidebar. If it is hidden, the filter text should not be displayed.",I think it would be better to use `UserPreferences.getFeedFilter().equals(UserPreferences.FEED_FILTER_NONE)` here.
+645,"@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""query/useCircuitBreakers"", false);
++    memoryCircuitBreakerThreshold = getInt(""query/memoryCircuitBreakerThreshold"", 100);
++
++    validateMemoryBreakerThreshold();
+     
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ","I'd like for all of this to be dynamically configurable at some point, but it doesn't have to be in this PR. Can add it to the future SIP or create a separate JIRA for it, as you think would be appropriate.","I think this should be `getInt(""query/memoryCircuitBreakerThreshold"", 100);`"
+646,"@@ -57,8 +57,6 @@ extern Events* g_events;
+ extern Chat* g_chat;
+ extern LuaEnvironment g_luaEnvironment;
+ 
+-using ErrorCode = boost::system::error_code;
+-
+ Signals::Signals(boost::asio::io_service& service) :
+ 	set(service)
+ {",move the constructor to down the `namespace`,Why did you remove this?
+647,"@@ -123,6 +123,10 @@ type ClusterDeploymentStatus struct {
+ 	// Federated is true if the cluster deployment has been federated with the host cluster.
+ 	Federated bool `json:""federated,omitempty""`
+ 
++	// FederatedClusterRef is the reference to the federated cluster resource associated with
++	// this ClusterDeployment
++	FederatedClusterRef *corev1.ObjectReference `json:""federatedClusterRef,omitempty""`
++
+ 	// AdminKubeconfigSecret references the secret containing the admin kubeconfig for this cluster.
+ 	AdminKubeconfigSecret corev1.LocalObjectReference `json:""adminKubeconfigSecret,omitempty""`
+ ",Nit: ending with a '.' looks consistent with the fields around it.,Why is this a pointer?
+648,"@@ -138,7 +138,7 @@ func (s *Service) MintX509SVID(ctx context.Context, req *svidv1.MintX509SVIDRequ
+ }
+ 
+ func (s *Service) MintJWTSVID(ctx context.Context, req *svidv1.MintJWTSVIDRequest) (*svidv1.MintJWTSVIDResponse, error) {
+-	rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(req.Id, req.Audience, req.Ttl))
++	rpccontext.AddRPCAuditFields(ctx, s.fieldsFromJWTSvidParams(ctx, req.Id, req.Audience, req.Ttl))
+ 	jwtsvid, err := s.mintJWTSVID(ctx, req.Id, req.Audience, req.Ttl)
+ 	if err != nil {
+ 		return nil, err","Audit log will not have a warning about they are using a deprecated path, is it something we must care about?",Why do we need this change?
+649,"@@ -23,7 +23,7 @@ namespace Microsoft.Cci.Differs.Rules
+             // If implementation is protected then contract must be protected as well. 
+             if (impl.Visibility == TypeMemberVisibility.Family)
+             {
+-                if (contract.Visibility != TypeMemberVisibility.Family)
++                if (contract.Visibility != TypeMemberVisibility.Family && contract.Visibility != TypeMemberVisibility.FamilyOrAssembly)
+                 {
+                     differences.AddIncompatibleDifference(this,
+                         ""Visibility of member '{0}' is '{1}' in the implementation but '{2}' in the contract."",",I think you also want to update the condition to add ` || impl.Visibility == TypeMemberVisibility.FamilyOrAssembly`.,Why is this change needed?
+650,"@@ -18,7 +18,10 @@ import (
+ )
+ 
+ var (
+-	depositToRewardingFundBaseGas = uint64(10000)
++	// DepositToRewardingFundBaseGas represents the base intrinsic gas for depositToRewardingFund
++	DepositToRewardingFundBaseGas = uint64(10000)
++	// DepositToRewardingFundGasPerByte represents the depositToRewardingFund payload gas per uint
++	DepositToRewardingFundGasPerByte = uint64(100)
+ )
+ 
+ // DepositToRewardingFund is the action to deposit to the rewarding fund",`DepositToRewardingFundBaseGas` is a global variable (from `gochecknoglobals`),Why is this a uint64?
+651,"@@ -3,12 +3,14 @@
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ // SPDX-License-Identifier: Apache-2.0
+ 
+-// Package groups contains the names of command groups
++// Package groups contains the names of command groups.
+ package group
+ 
++// Categories for each top level command in the CLI.
+ const (
+-	GettingStarted = ""Getting Started ✨""
+-	Develop        = ""Develop 🔧""
++	GettingStarted = ""Getting Started 🌱""
++	Develop        = ""Develop ✨""
+ 	Settings       = ""Settings ⚙️""
++	Operational    = ""Operational 🧐""
+ 	Release        = ""Release 🚀""
+ )","What do you think of ""operations""?? Also what do these emojis look like on Linux??",Why do we need to change th
+652,"@@ -0,0 +1,16 @@
++<% content_for :subject_block do %>
++  <h1><%= t('shared.subscription.name') %> for Teams</h1>
++  <h2 class=""tagline"">
++    Sign your team up for <%= t('shared.subscription.name') %> today, and give them the finest Ruby on Rails content and the best expert teachers.
++  </h2>
++<% end %>
++
++<p>Your team gets all of the great benefits of <%= link_to t('shared.subscription.name'), prime_path %>, with convenient monthly group billing, as well as a nice discount. <%= t('shared.subscription.name') %> Teams have a minimum of 5 members, and a 10% discount off the normal price. New members can be added at any time.</p>
++
++<section class=""plans"">
++  <%= render @plans %>
++</section>
++
++<span class=""prime-aside-links"">
++  <%= link_to ""View all the features of #{t('shared.subscription.name')}"", prime_path %>
++</span>","I like the word ""give"" here. Feels like I'm giving a gift to my team.",I think this should be `<%= t('shared.subscription.name') %> for Teams`
+653,"@@ -11,12 +11,16 @@ import numpy as np
+ from sklearn import __version__ as sk_version
+ from sklearn.base import clone
+ from sklearn.datasets import (load_boston, load_breast_cancer, load_digits,
+-                              load_iris, load_svmlight_file)
++                              load_iris, load_linnerud, load_svmlight_file,
++                              make_multilabel_classification)
+ from sklearn.exceptions import SkipTestWarning
+ from sklearn.metrics import log_loss, mean_squared_error
+-from sklearn.model_selection import GridSearchCV, train_test_split
++from sklearn.model_selection import GridSearchCV, RandomizedSearchCV, train_test_split
++from sklearn.multioutput import (MultiOutputClassifier, ClassifierChain, MultiOutputRegressor,
++                                 RegressorChain)
+ from sklearn.utils.estimator_checks import (_yield_all_checks, SkipTest,
+                                             check_parameters_default_constructible)
++from scipy.stats import randint, uniform
+ 
+ 
+ decreasing_generator = itertools.count(0, -1)",Is it possible to use `np.random` module instead?,I don't think we need this import.
+654,"@@ -49,7 +49,7 @@ legend_dimensions = ['label_standoff', 'label_width', 'label_height', 'glyph_wid
+ 
+ class ElementPlot(BokehPlot, GenericElementPlot):
+ 
+-    bgcolor = param.Parameter(default='white', doc=""""""
++    bgcolor = param.Parameter(default=None, allow_None=True, doc=""""""
+         Background color of the plot."""""")
+ 
+     border = param.Number(default=10, doc=""""""","``default=None`` implies ``allow_None`` so ``allow_None`` is superfluous here. As a special case, if allow_None=True (which is true by default if the parameter has a default of None when declared) then a value of None is also allowed.",I don't think we want to allow None here.
+655,"@@ -551,8 +551,8 @@ func genClientCerts(config *config.Control, runtime *config.ControlRuntime) erro
+ 	if _, err = factory(""system:kube-proxy"", nil, runtime.ClientKubeProxyCert, runtime.ClientKubeProxyKey); err != nil {
+ 		return err
+ 	}
+-	// this must be hardcoded to k3s-controller because it's hard coded in the rolebindings.yaml
+-	if _, err = factory(""system:k3s-controller"", nil, runtime.ClientK3sControllerCert, runtime.ClientK3sControllerKey); err != nil {
++	// This user (system:k3s-controller by default) must be bound to a role in rolebindings.yaml or the downstream equivalent
++	if _, err = factory(""system:""+version.Program+""-controller"", nil, runtime.ClientK3sControllerCert, runtime.ClientK3sControllerKey); err != nil {
+ 		return err
+ 	}
+ ",Is there anything in particular that makes setting up the downstream rolebinding(s) to `system:k3s-controller` burdensome or confusing? This changes looks fine to me but it seems a shame to alias an embedded k3s controller. If we are doing this in other places that I am not aware of then we can dismiss this concern out of hand.,Why is this hardcoded to `system:k3s-controller`?
+656,"@@ -21,7 +21,7 @@ import (
+ 	""strings""
+ 	""time""
+ 
+-	acd ""github.com/ncw/go-acd""
++	""github.com/ncw/go-acd""
+ 	""github.com/ncw/rclone/fs""
+ 	""github.com/ncw/rclone/fs/config""
+ 	""github.com/ncw/rclone/fs/config/configmap""",File is not `goimports`-ed (from `goimports`),Why this change?
+657,"@@ -0,0 +1,15 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++namespace Reporting
++{
++    public class Os
++    {
++        public string Locale { get; set; }
++
++        public string Architecture { get; set; }
++
++        public string Name { get; set; }
++    }
++}","nit: all other types in this project have full names, so maybe a better name would be `OperatingSystem`?",Why do we need t
+658,"@@ -16,7 +16,7 @@
+ #include <GraphMol/SmilesParse/SmilesParse.h>
+ #include <GraphMol/FileParsers/FileParsers.h>
+ #include <Geometry/point.h>
+-#include ""MolTransforms.h""
++#include <GraphMol/MolTransforms/MolTransforms.h>
+ 
+ using namespace RDKit;
+ using namespace MolTransforms;",Why is this needed here?,Why did you chan
+659,"@@ -192,7 +192,7 @@ public interface Context {
+                 methodUsage = ((TypeVariableResolutionCapability) methodDeclaration)
+                                       .resolveTypeVariables(this, argumentsTypes);
+             } else {
+-                throw new UnsupportedOperationException();
++                return Optional.empty();
+             }
+ 
+             return Optional.of(methodUsage);","mmm, why a method declaration should not have the TypeVariableResolutionCapability? Is this ok?",Why this change?
+660,"@@ -32,8 +32,8 @@ public class EeaSendRawTransaction extends PrivacySendTransaction {
+ 
+   public EeaSendRawTransaction(
+       final PrivacyParameters privacyParameters,
+-      final PrivateTransactionHandler privateTransactionHandler,
+-      final TransactionPool transactionPool) {
++      final TransactionPool transactionPool,
++      final PrivateTransactionHandler privateTransactionHandler) {
+     super(privacyParameters, privateTransactionHandler, transactionPool);
+   }
+ ",nit: any reason you swapped the ordering?,Please revert this change.
+661,"@@ -4,7 +4,7 @@ define([""jQuery"", ""loading"", ""globalize"", ""dom""], function($, loading, globalize
+     function loadPage(page, config, systemInfo) {
+         Array.prototype.forEach.call(page.querySelectorAll("".chkDecodeCodec""), function(c) {
+             c.checked = -1 !== (config.HardwareDecodingCodecs || []).indexOf(c.getAttribute(""data-codec""))
+-        }), page.querySelector(""#chkHardwareEncoding"").checked = config.EnableHardwareEncoding, $(""#selectVideoDecoder"", page).val(config.HardwareAccelerationType), $(""#selectThreadCount"", page).val(config.EncodingThreadCount), $(""#txtDownMixAudioBoost"", page).val(config.DownMixAudioBoost), page.querySelector("".txtEncoderPath"").value = config.EncoderAppPath || """", $(""#txtTranscodingTempPath"", page).val(config.TranscodingTempPath || """"), $(""#txtVaapiDevice"", page).val(config.VaapiDevice || """"), page.querySelector(""#selectH264Preset"").value = config.H264Preset || """", page.querySelector(""#txtH264Crf"").value = config.H264Crf || """", page.querySelector(""#chkEnableSubtitleExtraction"").checked = config.EnableSubtitleExtraction || !1, page.querySelector(""#selectVideoDecoder"").dispatchEvent(new CustomEvent(""change"", {
++        }), page.querySelector(""#chkHardwareEncoding"").checked = config.EnableHardwareEncoding, $(""#selectVideoDecoder"", page).val(config.HardwareAccelerationType), $(""#selectThreadCount"", page).val(config.EncodingThreadCount), $(""#txtDownMixAudioBoost"", page).val(config.DownMixAudioBoost), page.querySelector("".txtEncoderPath"").value = config.EncoderAppPathDisplay || """", $(""#txtTranscodingTempPath"", page).val(config.TranscodingTempPath || """"), $(""#txtVaapiDevice"", page).val(config.VaapiDevice || """"), page.querySelector(""#selectH264Preset"").value = config.H264Preset || """", page.querySelector(""#txtH264Crf"").value = config.H264Crf || """", page.querySelector(""#chkEnableSubtitleExtraction"").checked = config.EnableSubtitleExtraction || !1, page.querySelector(""#selectVideoDecoder"").dispatchEvent(new CustomEvent(""change"", {
+             bubbles: !0
+         })), loading.hide()
+     }",can you de-uglify at least this line?.. hard to tell what changed...,Why did you change this?
+662,"@@ -354,13 +354,10 @@ type BPFDataplane interface {
+ 	RemoveXDP(ifName string, mode XDPMode) error
+ 	UpdateCIDRMap(ifName string, family IPFamily, ip net.IP, mask int, refCount uint32) error
+ 	UpdateFailsafeMap(proto uint8, port uint16) error
+-	loadXDPRaw(objPath, ifName string, mode XDPMode, mapArgs []string) error
+ 	GetBPFCalicoDir() string
+ 	AttachToSockmap() error
+ 	DetachFromSockmap(mode FindObjectMode) error
+ 	RemoveSockmap(mode FindObjectMode) error
+-	loadBPF(objPath, progPath, progType string, mapArgs []string) error
+-	LoadSockops(objPath string) error
+ 	LoadSockopsWithBytes(objBytes []byte) error
+ 	LoadSockopsAuto() error
+ 	RemoveSockops() error",Please can you merge master in before making these changes. I just reinstated a bunch of BPF UTs. Possible that the UTs use this code.,Why was this removed?
+663,"@@ -66,3 +66,14 @@ class MyCls:
+     @classmethod
+     def get_class_var(cls):
+         return cls.__class_var
++
++
++class Bla:
++    """"""Regression test for issue 4638""""""
++
++    def __init__(self):
++        type(self).__a()
++
++    @classmethod
++    def __a(cls):
++        pass",Do you want to add additional cases for `Bla.__b()` and `self.__c()`? (Just add additional classmethods `__b` and `__c` and the calls to `__init__`),Why is this necessary?
+664,"@@ -462,7 +462,7 @@ def search(collection, p, of, ot, so, rm):
+ 
+     ctx = dict(
+         facets=facets.get_facets_config(collection, qid),
+-        records=len(get_current_user_records_that_can_be_displayed(qid)),
++        records=len(recids),
+         qid=qid, rg=rg,
+         create_nearest_terms_box=lambda: _create_neareset_term_box(argd_orig),
+         easy_search_form=EasySearchForm(csrf_enabled=False),","the recids is never changed after. So, it should contains the exact shown results, whatever are the rights for the user (admin or simple user, restricted collections...)",I think this should be `len(recids.values())`
+665,"@@ -669,7 +669,15 @@ func (b *Bucket) newRangeReader(ctx context.Context, key string, offset, length
+ 
+ // WriteAll is a shortcut for creating a Writer via NewWriter and writing p.
+ func (b *Bucket) WriteAll(ctx context.Context, key string, p []byte, opts *WriterOptions) (err error) {
+-	w, err := b.NewWriter(ctx, key, opts)
++	realOpts := new(WriterOptions)
++	if opts != nil {
++		*realOpts = *opts
++	}
++	if len(realOpts.ContentMD5) == 0 {
++		sum := md5.Sum(p)
++		realOpts.ContentMD5 = sum[:]
++	}
++	w, err := b.NewWriter(ctx, key, realOpts)
+ 	if err != nil {
+ 		return err
+ 	}","Shouldn't the docstring mention that the MD5 checksum of `p` is computed each time and verified? Also, could there be use cases where a caller might not want such a check to happen because, eg, a blob storage solution doesn't provide MD5 verification or uses another hash algorithm such as SHA256?",Why do we need this?
+666,"@@ -143,6 +143,9 @@ def executeEvent(eventName,obj,**kwargs):
+ 	@param kwargs: Additional event parameters as keyword arguments.
+ 	""""""
+ 	try:
++		# Allow NVDAObjects to redirect focus events to another object of their choosing.
++		if eventName==""gainFocus"" and obj.focusRedirect:
++			obj=obj.focusRedirect
+ 		sleepMode=obj.sleepMode
+ 		if eventName==""gainFocus"" and not doPreGainFocus(obj,sleepMode=sleepMode):
+ 			return","focusRedirect is used in the powerpnt appModule. We might have to make sure that this does not break. Having said that, I really like this being handled on the events level!",nit: space after `=`
+667,"@@ -21,6 +21,8 @@ import (
+ 	""encoding/base64""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/config""
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/gcp_clients""
+ 	""io""
+ 	""log""
+ 	""path""",You imports are out of order,nit: remove empty line
+668,"@@ -45,7 +45,7 @@ import org.slf4j.LoggerFactory;
+ public class QuartzScheduler {
+ 
+   //Unless specified, all Quartz jobs's identities comes with the default job name.
+-  private static final String DEFAULT_JOB_NAME = ""job1"";
++  public static final String DEFAULT_JOB_NAME = ""job1"";
+   private static final Logger logger = LoggerFactory.getLogger(QuartzScheduler.class);
+   private Scheduler scheduler = null;
+ ","This should not be called Flow Trigger. FlowTrigger should has its own flowTrigger job name, for instance, ""flowtrigger""",Why did you make this public?
+669,"@@ -0,0 +1,19 @@
++// Copyright (c) 2018 IoTeX
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package sqlite3
++
++import (
++	""github.com/iotexproject/iotex-core/config""
++	""github.com/iotexproject/iotex-core/db""
++	// this is required for sqlite3 usage
++	_ ""github.com/mattn/go-sqlite3""
++)
++
++// NewSQLite3 instantiates an sqlite3
++func NewSQLite3(cfg *config.SQLITE3) db.Store {
++	return db.NewSQLBase(""sqlite3"", cfg.SQLite3File)
++}",File is not `goimports`-ed (from `goimports`),Why is this needed?
+670,"@@ -30,6 +30,10 @@ public partial class Program
+ 
+     public static void Stress(int concurrency = 0)
+     {
++#if DEBUG
++        Console.WriteLine(""***WARNING*** The current build is DEBUG which may affect timing!\n"");
++#endif
++
+         if (concurrency < 0)
+         {
+             throw new ArgumentOutOfRangeException(nameof(concurrency), ""concurrency level should be a non-negative number."");",Why do we need `\n` if we already use `WriteLine`? (and `\n` is not cross platform),Why is this needed?
+671,"@@ -30,12 +30,15 @@ import com.google.common.base.MoreObjects;
+ public class MetricsConfiguration {
+   private static final String DEFAULT_METRICS_HOST = ""127.0.0.1"";
+   public static final int DEFAULT_METRICS_PORT = 9545;
+-
++  private static final String DEFAULT_INSTRUMENTATION_NAME = ""besu"";
++  private static final String DEFAULT_METRICS_PROTOCOL = ""prometheus"";
+   private static final String DEFAULT_METRICS_PUSH_HOST = ""127.0.0.1"";
+   public static final int DEFAULT_METRICS_PUSH_PORT = 9001;
+   public static final Boolean DEFAULT_TIMERS_ENABLED = true;
+ 
+   private final boolean enabled;
++  private final String instrumentationName;
++  private final String protocol;
+   private final int port;
+   private int actualPort;
+   private final String host;","What is instrumentation name used for? I'm not seeing other classes use it, only a getter, constructor, and builder.",Why do we need this?
+672,"@@ -21,8 +21,10 @@ namespace Nethermind.TxPool.Collections
+ {
+     public partial class SortedPool<TKey, TValue, TGroupKey>
+     {
++#pragma warning disable 67
+         public event EventHandler<SortedPoolEventArgs>? Inserted;
+         public event EventHandler<SortedPoolRemovedEventArgs>? Removed;
++#pragma warning restore 67
+ 
+         public class SortedPoolEventArgs
+         {",@kristofgazso could you review these warnings?,Why disable and restore 67?
+673,"@@ -0,0 +1,3 @@
++require(""child_process"");
++
++console.log(""hi"");",will delete this.,
+674,"@@ -104,9 +104,9 @@ module PurchasesHelper
+ 
+   def new_plan_link(plan)
+     link_to(
+-       I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe,
+-       new_individual_plan_purchase_path(plan),
+-       class: 'button'
++      I18n.t('subscriptions.choose_plan_html', plan_name: plan.name).html_safe,
++      new_individual_plan_purchase_path(plan),
++      class: 'button'
+     )
+   end
+ end",~~Indent 2 lines above~~ Disregard. My fault,Prefer double-quoted string
+675,"@@ -366,7 +366,7 @@ public class InitCodeTransformer {
+         default:
+           throw new UnsupportedOperationException(""unexpected entity name type"");
+       }
+-    } else if (initValueConfig.hasFormattingConfig()) {
++    } else if (initValueConfig.hasFormattingConfig() && !item.getType().isRepeated()) {
+       if (context.getFeatureConfig().enableStringFormatFunctions()) {
+         FormattedInitValueView.Builder initValue = FormattedInitValueView.newBuilder();
+ ",What was the bug that this is fixing?,Why is this needed?
+676,"@@ -471,6 +471,9 @@ class RemoteConnection(object):
+             request.add_header('Accept', 'application/json')
+             request.add_header('Content-Type', 'application/json;charset=UTF-8')
+ 
++            base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))
++            request.add_header(""Authorization"", ""Basic %s"" % base64string)
++
+             if password_manager:
+                 opener = url_request.build_opener(url_request.HTTPRedirectHandler(),
+                                                   HttpErrorHandler(),","This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'",Why is this needed?
+677,"@@ -50,7 +50,12 @@ uint32_t lcg_rand() {
+ }
+ void lcg_reset() { lcg_seed = 48271; }
+ 
+-std::string test_data_path = ""tests/"";
++std::string test_data_path =
++#ifdef BAZEL_TEST_DATA_PATH
++    ""../com_github_google_flatbuffers/tests/"";
++#else
++    ""tests/"";
++#endif
+ 
+ // example of how to build up a serialized buffer algorithmically:
+ flatbuffers::DetachedBuffer CreateFlatBufferTest(std::string &buffer) {",Is this always how Bazel does paths? Would it be nicer to do `-DBAZEL_TEST_DATA_PATH=../com_github_google_flatbuffers/tests/` so this string is not hardcoded in the the source?,This should be `#if
+678,"@@ -169,7 +169,9 @@ class ElasticsearchTarget(luigi.Target):
+ 
+         The document id would be sufficient but,
+         for documentation,
+-        we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well.
++        we index the parameters `update_id`, `target_index`, `target_doc_type` and `date` as well.  `date_utc` added
++        so we can be sure to get the actual date and time based upon UTC and not the client date and time based on the
++        client machine.
+         """"""
+         self.create_marker_index()
+         self.es.index(index=self.marker_index, doc_type=self.marker_doc_type,","Not an expert of ES, so not sure of the impact here.",E501 line too long 
+679,"@@ -1665,10 +1665,10 @@ NABoolean ExExeUtilGetMetadataInfoTcb::checkUserPrivs(
+   if (ComUser::isRootUserID())
+     return FALSE;
+ 
+-  // any user granted the DB__ROOTROLE sees everything
+   Int32 numRoles;
+   Int32 *roleList;
+-  if (currContext->getRoleList(numRoles, roleList) == SUCCESS)
++  Int32 *granteeList;
++  if (currContext->getRoleList(numRoles, roleList, granteeList) == SUCCESS)
+   {
+     char authIDAsChar[sizeof(Int32)+10];
+     NAString auths;",Who deletes the memory for the granteeList? (or the roleList for that matter),Shouldn't this be `
+680,"@@ -13,6 +13,11 @@ ws_listener (listener_a), ws (std::move (socket_a)), write_strand (ws.get_execut
+ 
+ nano::websocket::session::~session ()
+ {
++	for (auto & subscription : subscriptions)
++	{
++		ws_listener.decrease_subscription_count (subscription);
++	}
++
+ 	ws_listener.get_node ().logger.try_log (""websocket session ended"");
+ }
+ ",This loop is missing a lock on subscriptions_mutex.,Why do we need this?
+681,"@@ -62,7 +62,9 @@ Workshops::Application.routes.draw do
+   match '/backbone-js-on-rails' => redirect(""/products/1-backbone-js-on-rails"")
+ 
+   match '/rubyist-booster-shot' => ""high_voltage/pages#show"", as: :rubyist_booster_shot, id: ""rubyist-booster-shot""
+-  match 'sign_in'  => 'sessions#new', as: 'sign_in'
++  match '/sign_up' => 'users#new', as: 'sign_up'
++  match '/sign_in' => 'sessions#new', as: 'sign_in'
++  match '/sign_out' => 'sessions#destroy', as: 'sign_out', via: :delete
+ 
+   mount Split::Dashboard, at: 'split'
+ ",shouldn't clearance be setting these up for us?,Unnecessary spacing 
+682,"@@ -46,6 +46,10 @@ type (
+ 	}
+ 
+ 	defaultServiceNameDetector struct{}
++
++	// noOp is a Detector that only provides an empty resource.  Used
++	// to disable automatic detection.
++	noOp struct{}
+ )
+ 
+ var (",Need to update the doc for `TelemetrySDK` and `Host` structs deleting references from removed functions.,Why is this needed?
+683,"@@ -55,12 +55,6 @@ public final class ASTRecordDeclaration extends AbstractAnyTypeDeclaration {
+         return isNested() || isLocal();
+     }
+ 
+-    @Override
+-    public boolean isFinal() {
+-        // A record is implicitly final
+-        return true;
+-    }
+-
+     @Override
+     public boolean isLocal() {
+         return getParent() instanceof ASTBlockStatement;",I think we should keep that here and add a new method `isSyntacticallyFinal` that returns `super.isFinal()` (and can be used in UnnecessaryModifier). Otherwise the contract of `isFinal` is not respected,Why is this removed?
+684,"@@ -2444,6 +2444,11 @@ angular.module('ui.grid')
+           //   to get the full position we need
+           scrollPixels = self.renderContainers.body.prevScrollTop - (topBound - pixelsToSeeRow);
+ 
++          //Since scrollIfNecessary is called multiple times when enableCellEditOnFocus is true we need to make sure the scrollbarWidth and footerHeight is accounted for to not cause a loop.
++          if (gridCol.colDef.enableCellEditOnFocus === true) {
++            scrollPixels = scrollPixels - self.footerHeight - self.scrollbarWidth;
++          }
++
+           scrollEvent.y = getScrollY(scrollPixels, scrollLength, self.renderContainers.body.prevScrolltopPercentage);
+         }
+         // Otherwise if the scroll position we need to see the row is MORE than the bottom boundary, i.e. obscured below the bottom of the self...",Is there a reason why we wouldn't want to check this every time? Why are we only checking for the footer and scroll bar when enableCellEditOnFocus is true?,I'm not sure if this is the best way to do this. I think it would be better to do this in the `getScrollY` function.
+685,"@@ -23,6 +23,7 @@ import com.playonlinux.common.dtos.*;
+ import com.playonlinux.domain.PlayOnLinuxError;
+ import com.playonlinux.injection.Scan;
+ import com.playonlinux.injection.Inject;
++import com.playonlinux.ui.api.InstallerFilter;
+ import com.playonlinux.webservice.RemoteAvailableInstallers;
+ 
+ import java.net.MalformedURLException;",You need to create an API for this class. This class should follow roughly the same dependency structure than RemoteAvailableInstallersPlayOnLinuxImplementation / RemoteAvailableInstallers. Maybe we could use a inner class here?,Why is this needed?
+686,"@@ -42,7 +42,7 @@ const (
+ 	templateCreateWorkflowExecutionClosed = `INSERT INTO executions_visibility (` +
+ 		`namespace_id, workflow_id, run_id, start_time, execution_time, workflow_type_name, close_time, status, history_length, memo, encoding) ` +
+ 		`VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) ` +
+-		`ON DUPLICATE KEY UPDATE start_time = VALUES(start_time), execution_time = VALUES(execution_time), workflow_type_name = VALUES(workflow_type_name), ` +
++		`ON DUPLICATE KEY UPDATE workflow_id = VALUES(workflow_id), start_time = VALUES(start_time), execution_time = VALUES(execution_time), workflow_type_name = VALUES(workflow_type_name), ` +
+ 		`close_time = VALUES(close_time), status = VALUES(status), history_length = VALUES(history_length), memo = VALUES(memo), encoding = VALUES(encoding)`
+ 
+ 	// RunID condition is needed for correct pagination","This should not be a case, right? If `run_id` is the same `workflow_id` can't be changed. Actually surprised that it is not part of a key.",Why do we need to change this?
+687,"@@ -4520,7 +4520,9 @@ RelExpr * GenericUpdate::preCodeGen(Generator * generator,
+     {
+       oltOptInfo().setOltOpt(FALSE);
+       generator->oltOptInfo()->setOltOpt(FALSE);
+-      generator->setAqrEnabled(FALSE);
++      //enabling AQR to take care of the lock conflict error 8558 that
++      // should be retried.
++      //      generator->setAqrEnabled(FALSE);
+       generator->setUpdAbortOnError(TRUE);
+       generator->setUpdSavepointOnError(FALSE);
+     }",How would AQR work for an INSERT/SELECT of one table into another where a LOB column is being copied?,Why is this disabled?
+688,"@@ -6,9 +6,11 @@ import (
+ 	""net""
+ 	""os""
+ 
+-	sds_v2 ""github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2""
++	discovery_v2 ""github.com/envoyproxy/go-control-plane/envoy/service/discovery/v2""
++	secret_v3 ""github.com/envoyproxy/go-control-plane/envoy/service/secret/v3""
+ 	attestor ""github.com/spiffe/spire/pkg/agent/attestor/workload""
+-	""github.com/spiffe/spire/pkg/agent/endpoints/sds""
++	""github.com/spiffe/spire/pkg/agent/endpoints/sds/sdsv2""
++	""github.com/spiffe/spire/pkg/agent/endpoints/sds/sdsv3""
+ 	""github.com/spiffe/spire/pkg/agent/endpoints/workload""
+ 	""github.com/spiffe/spire/pkg/common/peertracker""
+ 	""github.com/spiffe/spire/pkg/common/telemetry""","Since these are ultimately different endpoints, it would be nice if we could move them up one level and nuke the common `sds` directory in order to reduce path stutter",Why do we need this alias?
+689,"@@ -927,7 +927,7 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
+     if (isFunction(beforeChangeResult)) {
+       warn('Your beforeChange callback returns a function. It\'s not supported since Handsontable 0.12.1 (and the returned function will not be executed).');
+ 
+-    } else if (beforeChangeResult === false) {
++    } else if (beforeChangeResult === false || beforeChangeResult.length === 0 || beforeChangeResult[0] === null) {
+       const activeEditor = instance.getActiveEditor();
+ 
+       if (activeEditor) {",Please check also whether `null` occurs in the rest of `beforeChangeResult` array.,`beforeChangeResult === fa
+690,"@@ -22,9 +22,10 @@ package transport
+ 
+ import ""context""
+ 
+-// Filter defines transport-level middleware for Outbounds.
++// UnaryFilter defines transport-level middleware for `UnaryOutbound`s.
++// Note: this is client side.
+ //
+-// Filters MAY
++// UnaryFilter MAY
+ //
+ // - change the context
+ // - change the request","Outdated docs. There is no response, there's an ack.",I don't think we need this
+691,"@@ -27,7 +27,7 @@ your host.`,
+ 		}
+ 		switch status {
+ 		case libcontainer.Created:
+-			return container.Signal(libcontainer.InitContinueSignal)
++			return container.Exec()
+ 		case libcontainer.Stopped:
+ 			return fmt.Errorf(""cannot start a container that has run and stopped"")
+ 		case libcontainer.Running:","I'd rather have the container process remove the FIFO after it unblocks. Then `start` can always `Exec()`, and you can catch the ""FIFO does not exist"" error and translate it to a prettier ""someone must have already started the container"".",I think this should be `co
+692,"@@ -284,7 +284,7 @@ func (svr *Web3Server) getTransactionFromActionInfo(actInfo *iotexapi.ActionInfo
+ 
+ func (svr *Web3Server) getTransactionCreateFromActionInfo(actInfo *iotexapi.ActionInfo) (transactionObject, error) {
+ 	tx, err := svr.getTransactionFromActionInfo(actInfo)
+-	if err != nil {
++	if err != nil || tx == nil {
+ 		return transactionObject{}, err
+ 	}
+ ",can you check if there's other similar cases to add nil-check like this?,Why do we need this change?
+693,"@@ -106,7 +106,10 @@ def dummy_cert(privkey, cacert, commonname, sans, organization):
+     cert.gmtime_adj_notBefore(-3600 * 48)
+     cert.gmtime_adj_notAfter(DEFAULT_EXP_DUMMY_CERT)
+     cert.set_issuer(cacert.get_subject())
+-    if commonname is not None and len(commonname) < 64:
++    is_valid_commonname = (
++        commonname is not None and len(commonname) < 64
++    )
++    if is_valid_commonname:
+         cert.get_subject().CN = commonname
+     if organization is not None:
+         cert.get_subject().O = organization","`<= 64`? I just picked up what you said in #3981 (""the CN field is limited to 64 characters"") but maybe there's something I don't know where the 64th character is needed (trailing dot or whatever?) Also this sounds like something that could be beautifully unit tested. Sorry for bugging you :grin:",I don't think you need the 
+694,"@@ -20,4 +20,10 @@ class License < ActiveRecord::Base
+   def short_name
+     abbreviation.blank? ? nice_name : abbreviation
+   end
++
++  class << self
++    def autocomplete(term)
++      License.select([:nice_name, :id]).where(['lower(nice_name) LIKE ?', ""#{term.downcase}%""]).limit(10)
++    end
++  end
+ end",I understand that this grabs a Licenses objects but what is the autocomplete method used for? What does this do in context of the auto_completes controller?,I'm not sure if this is the
+695,"@@ -480,6 +480,10 @@ public class BlockchainQueries {
+         txs.get(txIndex), header.getNumber(), blockHeaderHash, txIndex);
+   }
+ 
++  public Optional<TransactionLocation> transactionLocationByHash(final Hash transactionHash) {
++    return blockchain.getTransactionLocation(transactionHash);
++  }
++
+   /**
+    * Returns the transaction receipt associated with the given transaction hash.
+    *",I don't really like that way of naming methods based on their arguments. But I can see that the other method names are the same ...,Why do we need this method?
+696,"@@ -180,6 +180,19 @@ public class StringUtil {
+         }
+     }
+     
++    public static String sanitizeFileDirectory(String value){
++        
++        while (value.startsWith(""\\"") || value.startsWith(""/"") || value.startsWith(""-"") || value.startsWith(""."")){
++            value = value.substring(1);
++        }
++        while (value.endsWith(""\\"") || value.endsWith(""/"") || value.endsWith(""-"") || value.endsWith(""."")){
++            value = value.substring(0, value.length() - 1);
++        }
++        
++        return value;
++    }
++    
++    
+     private static SecretKeySpec generateKeyFromString(final String secKey) throws UnsupportedEncodingException, NoSuchAlgorithmException {
+         byte[] key = (secKey).getBytes(""UTF-8"");
+         MessageDigest sha = MessageDigest.getInstance(""SHA-1"");","@sekmiller This method correctly strips the leading and trailing slashes (and also ""."" and ""-""); But I thought the plan was also to replace any multiple slashes between nested folders with a single slash. For example, as implemented now, I can enter ""folder1///folder2"", and it gets saved and displayed like this, with the 3 slashes. I thought we wanted to sanitize it as ""folder1/folder2"".",Why do we need this method?
+697,"@@ -45,7 +45,7 @@
+ 
+ int main()
+ {
+-    int pid;
++    int64_t pid;
+     fprintf(stderr, ""starting\n"");
+ #if defined(AARCH64)
+     asm(""movz x8, "" STRINGIFY(SYS_getpid) "";""",Looks like the X86 inline assembly is not happy with this type. I will update that,This should be `int64_t`.
+698,"@@ -6,6 +6,12 @@
+ 
+     <h2><%= link_to h(diary_entry.title), :action => 'view', :display_name => diary_entry.user.display_name, :id => diary_entry.id %></h2>
+ 
++    <% if @user and diary_entry.user.id != @user.id %>
++           <%= link_to new_issue_url(reportable_id: diary_entry.id, reportable_type: diary_entry.class.name, reported_user_id: diary_entry.user.id,referer: request.fullpath), :title => t('diary_entry.diary_entry.report') do %>
++            &nbsp;&#9872;
++          <% end %>
++    <% end %>
++
+     <small class='deemphasize'>
+       <%= raw(t 'diary_entry.diary_entry.posted_by', :link_user => (link_to h(diary_entry.user.display_name), :controller => 'user', :action => 'view', :display_name => diary_entry.user.display_name), :created => l(diary_entry.created_at, :format => :blog), :language_link => (link_to h(diary_entry.language.name), :controller => 'diary_entry', :action => 'list', :display_name => nil, :language => diary_entry.language_code)) %>
+     </small>","Tabs and a space, again.",I don't think you need the 
+699,"@@ -2441,6 +2441,16 @@ bool QuestManager::istaskappropriate(int task) {
+ 	return false;
+ }
+ 
++std::string QuestManager::gettaskname(uint32 task_id) {
++	QuestManagerCurrentQuestVars();
++
++	if (RuleB(TaskSystem, EnableTaskSystem)) {
++		return taskmanager->GetTaskName(task_id);
++	}
++
++	return std::string();
++}
++
+ void QuestManager::clearspawntimers() {
+ 	if(!zone)
+         return;",Please just enclose if blocks with brackets; this has created issues in the past so I'd prefer we don't use them,Why do we need this functio
+700,"@@ -185,11 +185,7 @@
+ <% if policy(@proposal).can_approve_or_reject? %>
+   <div class=""centered"">
+     <p>
+-      <%= link_to ""Approve"",
+-          approval_response_path(approver_action: 'approve',
+-                                 # @todo: get rid of cart
+-                                 cart_id: @proposal.cart.id, version: @proposal.version
+-                                 ), class: 'form-button' %>
++      <%= link_to ""Approve"", approve_proposal_url(@proposal, version: @proposal.version), class: 'form-button' %>
+     </p>
+   </div>
+ <% end %>","`version` isn't need anymore because it's built into `approve_proposal_url`, yes?",The `approval_response_path` method is no longer used.
+701,"@@ -11,9 +11,10 @@ import struct
+ 
+ from scapy.compat import orb, chb
+ from scapy.config import conf
+-from scapy.data import MTU, DLT_BLUETOOTH_LE_LL
++from scapy.data import MTU, DLT_BLUETOOTH_LE_LL, DLT_BLUETOOTH_LE_LL_WITH_PHDR
+ from scapy.packet import *
+ from scapy.fields import *
++from scapy.layers.dot11 import _dbmField
+ from scapy.layers.ppi import PPI, addPPIType, PPIGenericFldHdr
+ 
+ from scapy.contrib.ppi_geotag import XLEIntField, XLEShortField",Moved to the bottom of the file. `CtrlPDU` sits on `BTLE_DATA` so let's put it after,Why do we need this import?
+702,"@@ -48,6 +48,7 @@ module Blacklight::SolrHelper
+   extend ActiveSupport::Concern
+   include Blacklight::SearchFields
+   include Blacklight::Facet
++  require 'json'
+ 
+   included do
+     if self.respond_to?(:helper_method)","This ends up requiring the `json` gem, right? Is there any way we can do this to be implementation agnostic (e.g. to let me use `yajl-ruby` for performance reasons (or because my app already brings in a JSON library)",Why is this needed?
+703,"@@ -56,8 +56,13 @@ type byteReadCloser struct{ io.ReadCloser }
+ // ReadByte implements the io.ByteReader interface.
+ func (b byteReadCloser) ReadByte() (byte, error) {
+ 	var buf [1]byte
+-	_, err := b.Read(buf[:])
+-	return buf[0], err
++	for {
++		n, err := b.Read(buf[:])
++		if n == 0 && err == nil {
++			continue
++		}
++		return buf[0], err
++	}
+ }
+ 
+ // A compressor builds a Riegeli compressed block.","This seems dangerous. What circumstances lead to the need for a retry? Can that happen more than once? I'm concerned that if we hit the pathological state, this could turn into a CPU spinner. I wonder if we could get the same benefit from just ""trying again"" and failing if it fails the second time.",Why is this needed?
+704,"@@ -20,11 +20,18 @@
+ package org.apache.iceberg;
+ 
+ import java.util.List;
++import java.util.Optional;
+ import org.apache.iceberg.exceptions.ValidationException;
+ import org.apache.iceberg.expressions.Expressions;
++import org.apache.iceberg.util.PartitionSet;
+ 
+ public class BaseReplacePartitions
+     extends MergingSnapshotProducer<ReplacePartitions> implements ReplacePartitions {
++
++  private final PartitionSet deletedPartitions = PartitionSet.create(super.getSpecsById());
++  private Long startingSnapshotId = null;
++  private boolean validateNoConflictingAppends = false;
++
+   BaseReplacePartitions(String tableName, TableOperations ops) {
+     super(tableName, ops);
+     set(SnapshotSummary.REPLACE_PARTITIONS_PROP, ""true"");","If there is a reference to other fields or methods, please do the initialization in the constructor.",Why do we need this?
+705,"@@ -0,0 +1,13 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/base.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/icons.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/avatars.jsx'),
++	require('raw-loader!@salesforce/design-system-react/components/pill/__examples__/bare.jsx'),
++];
++
++module.exports = siteStories;",These should be importing from `pill-container`,I'm not sure if this
+706,"@@ -2593,12 +2593,12 @@ void Game::playerRequestTrade(uint32_t playerId, const Position& pos, uint8_t st
+ 
+ 	Player* tradePartner = getPlayerByID(tradePlayerId);
+ 	if (!tradePartner || tradePartner == player) {
+-		player->sendTextMessage(MESSAGE_INFO_DESCR, ""Sorry, not possible."");
++		player->sendCancelMessage(RETURNVALUE_NOTPOSSIBLE);
+ 		return;
+ 	}
+ 
+ 	if (!Position::areInRange<2, 2, 0>(tradePartner->getPosition(), player->getPosition())) {
+-		player->sendTextMessage(MESSAGE_INFO_DESCR, fmt::format(""{:s} tells you to move closer."", tradePartner->getName()));
++		player->sendCancelMessage(RETURNVALUE_DESTINATIONOUTOFREACH);
+ 		return;
+ 	}
+ ","Why this change? It will now only show on the bottom of the screen as white text, is it correct behaviour?",Shouldn't this be `R
+707,"@@ -46,7 +46,7 @@ module Blacklight
+ 
+       fields = Array.wrap(view_config.title_field) + [configuration.document_model.unique_key]
+       f = fields.lazy.map { |field| field_config(field) }.detect { |field_config| field_presenter(field_config).any? }
+-      field_value(f, except_operations: [Rendering::HelperMethod])
++      f ? field_value(f, except_operations: [Rendering::HelperMethod]) : """"
+     end
+ 
+     def display_type(base_name = nil, default: nil)",Does this need to allocate a string or would a nil value (indicating no header) be a better?,I'm not sure if this
+708,"@@ -13,6 +13,7 @@ import { Fragment } from './create-element';
+ export function Component(props, context) {
+ 	this.props = props;
+ 	this.context = context;
++	// this.constructor // When component is functional component, this is reseted to functional component
+ 	// if (this.state==null) this.state = {};
+ 	// this.state = {};
+ 	// this._dirty = true;",Nit: Past tense of `reset` is also `reset`.,Why do we need this?
+709,"@@ -672,6 +672,12 @@ class Commands:
+         """""" return wallet synchronization status """"""
+         return self.wallet.is_up_to_date()
+ 
++    @command('')
++    def getfee(self):
++        """"""Return current optimal fee per kilobyte, according to
++        config settings (static/dynamic)""""""
++        return self.config.fee_per_kb()
++
+     @command('')
+     def help(self):
+         # for the python console",Shouldn't this use `'n'` instead?,I don't think this i
+710,"@@ -451,10 +451,10 @@ func (t *timerQueueProcessorBase) getTimerTaskType(
+ 	switch taskType {
+ 	case enumsspb.TASK_TYPE_USER_TIMER:
+ 		return ""UserTimer""
+-	case enumsspb.TASK_TYPE_ACTIVITY_TIMEOUT:
+-		return ""ActivityTimeout""
+-	case enumsspb.TASK_TYPE_DECISION_TIMEOUT:
+-		return ""DecisionTimeout""
++	case enumsspb.TASK_TYPE_ACTIVITY_TASK_TIMEOUT:
++		return ""ActivityTaskTimeout""
++	case enumsspb.TASK_TYPE_WORKFLOW_TASK_TIMEOUT:
++		return ""WorkflowTaskTimeout""
+ 	case enumsspb.TASK_TYPE_WORKFLOW_RUN_TIMEOUT:
+ 		return ""WorkflowRunTimeout""
+ 	case enumsspb.TASK_TYPE_DELETE_HISTORY_EVENT:",revert back to 'TASK_TYPE_ACTIVITY_TIMEOUT',Why do we need to ch
+711,"@@ -105,6 +105,9 @@ Engine::Engine(core::Engine *engine) : m_Engine(engine) {}
+     template void Engine::Get<T>(const std::string &, std::vector<T> &,        \
+                                  const Mode);                                  \
+                                                                                \
++    template void Engine::GetBlock<T>(Variable<T>, T **, const Mode);          \
++    template void Engine::GetBlock<T>(const std::string &, T **, const Mode);  \
++                                                                               \
+     template std::map<size_t, std::vector<typename Variable<T>::Info>>         \
+     Engine::AllStepsBlocksInfo(const Variable<T> variable) const;              \
+                                                                                \","Shouldn't we prefer passing a pointer by reference T*&, since these are C++ bindings?",Why do we need this?
+712,"@@ -146,9 +146,15 @@ func (n *NetworkPolicyController) processClusterNetworkPolicy(cnp *secv1alpha1.C
+ 			appliedToGroupNamesForRule = append(appliedToGroupNamesForRule, atGroup)
+ 			appliedToGroupNamesSet.Insert(atGroup)
+ 		}
++		cgExists := len(ingressRule.SourceGroups) > 0
++		iFromPeers := n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists, cgExists)
++		// If ClusterGroups are set in Rule, then create AddressGroups corresponding to the CG and append to From Peers.
++		ag, ipb := n.processRefCGs(ingressRule.SourceGroups)
++		iFromPeers.IPBlocks = append(iFromPeers.IPBlocks, ipb...)
++		iFromPeers.AddressGroups = append(iFromPeers.AddressGroups, ag...)
+ 		rules = append(rules, controlplane.NetworkPolicyRule{
+ 			Direction:       controlplane.DirectionIn,
+-			From:            *n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists),
++			From:            iFromPeers,
+ 			Services:        services,
+ 			Action:          ingressRule.Action,
+ 			Priority:        int32(idx),",nit: Personally I feel that it's cleaner to let `toAntreaPeerForCRD` to take `ingressRule` as a param instead of `ingressRule.From`. It can call `processRefCGs` inside the function and do the ipBlock/AG union within the function itself. It might not be worth the refactor though.,nit: `iFromPeers := &controlplane.NetworkPolicyRule{}`
+713,"@@ -98,6 +98,7 @@ func updateSPCVersion(name string) error {
+ 		return err
+ 	}
+ 	spcObj.VersionDetails.Desired = upgradeVersion
++	spcObj.VersionDetails.Status.State = apis.ReconcilePending
+ 	_, err = client.Update(spcObj)
+ 	if err != nil {
+ 		return err","Pending has been set only for SPC.. why? for other CRs as well, this need to be done.. right?",I don't think this is the right place to set the state
+714,"@@ -61,11 +61,13 @@ class VimeoProvider extends BaseVideoProvider
+         $box = $this->getBoxHelperProperties($media, $format, $options);
+ 
+         $params = array(
+-            'src'         => http_build_query($player_parameters),
+-            'id'          => $player_parameters['js_swf_id'],
+-            'frameborder' => isset($options['frameborder']) ? $options['frameborder'] : 0,
+-            'width'       => $box->getWidth(),
+-            'height'      => $box->getHeight(),
++            'src'               => http_build_query($player_parameters),
++            'id'                => $player_parameters['js_swf_id'],
++            'frameborder'       => isset($options['frameborder']) ? $options['frameborder'] : 0,
++            'width'             => $box->getWidth(),
++            'height'            => $box->getHeight(),
++            'class'             => isset($options['class']) ? $options['class'] : '',
++            'allow_fullscreen'  => isset($options['allowfullscreen']) ? true : false,
+         );
+ 
+         return $params;",would use an empty string here as default and then check for emptiness in the twig template. I dont like mixing types @core23 what do you think?,I don't think you need the ternary here.
+715,"@@ -169,6 +169,8 @@ public class PhpSampleMethodToViewTransformer implements SampleMethodToViewTrans
+     builder.isResourceMap(fieldInfo.type().isMap());
+     builder.pageVarName(
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name()))));
++    builder.pageTokenName(methodInfo.requestPageTokenName());
++    builder.nextPageTokenName(Name.lowerCamel(methodInfo.responsePageTokenName()).toUpperCamel());
+     return builder.build();
+   }
+ }",How come we need case manipulation for the nextPageToken and not for pageToken?,Why do we need to lower case here?
+716,"@@ -2,7 +2,8 @@ C2::Application.routes.draw do
+   ActiveAdmin.routes(self)
+   root :to => 'home#index'
+   get '/error' => 'home#error'
+-  get '/me'    => 'home#me'
++  get '/me'    => 'profile#show'
++  post '/me'   => 'profile#update'
+   get '/feedback' => 'feedback#index'
+   get '/feedback/thanks' => 'feedback#thanks'
+   post '/feedback' => 'feedback#create'",why use these rather than regular named paths?,I think this should be `/me/update`
+717,"@@ -61,6 +61,9 @@ module Bolt
+           { flags: OPTIONS[:global],
+             banner: GROUP_HELP }
+         end
++      when 'guide'
++        { flags: OPTIONS[:global] + %w[format],
++          banner: GUIDE_HELP }
+       when 'plan'
+         case action
+         when 'convert'","Hm, I don't think the extra flags are doing any harm here, but it does seem like `--help` is the only flag you could *actually* use with this command. We might eventually want to separate those out.",I don't think you need to add the `
+718,"@@ -1,3 +1,18 @@
++# This script is responsible to create candidate sets for all users. The generated candidate sets
++# will be given as input to the recommender to assign ratings to the recordings in candidate sets.
++# The general flow is as follows:
++#
++# Last 7 days listens are filtered from mapped_listens_df and is called the mapped_listens_subset_df.
++# Top X artists are fetched for each user from the mapped_listens_subset_df. The top_artist_df is joined
++# with recordings_df to get the dataframe of recordings belonging to the top artists. From this dataframe,
++# recordings listened to by the users in the last 7 days are filtered so that the recommendations don't contain
++# recordings that the user has listened to in the last week. The resultant dataframe is called the top_artists_candidate_set_df.
++#
++# Artists similar to top artists are fetched from the artist_relations_df and the similar_artist_candidate_set_df is generated
++# in a manner similar to the generation of the top artist candidate set.
++#
++# The top artist and similar artist candidate set dataframes are saved to HDFS.
++
+ import os
+ import sys
+ import uuid","We should make this a docstring, so that editors are able to pick it up.",I don't think we need to mention th
+719,"@@ -14,5 +14,13 @@ feature ""User without a subscription views sample video"" do
+     expect(current_path).to eq(video_path(video))
+     expect(page).to have_css(""h1"", text: video.name)
+     expect(page).not_to have_css("".locked-message"")
++    expect_authed_to_access_event_fired_for(video)
++  end
++
++  def expect_authed_to_access_event_fired_for(video)
++    expect(analytics).to have_tracked(""Authed to Access"").with_properties(
++      video_name: video.name,
++      watchable_name: video.watchable_name,
++    )
+   end
+ end",Put a comma after the last parameter of a multiline method call.,I'm not sure if this is the best wa
+720,"@@ -150,10 +150,8 @@ public class SalesforceDroidGapActivity extends CordovaActivity {
+     		webSettings.setDomStorageEnabled(true);
+     		String cachePath = getApplicationContext().getCacheDir().getAbsolutePath();
+     		webSettings.setAppCachePath(cachePath);
+-            webSettings.setAppCacheMaxSize(1024 * 1024 * 8);
+     		webSettings.setAppCacheEnabled(true);
+     		webSettings.setAllowFileAccess(true);
+-            webSettings.setSavePassword(false);
+     		webSettings.setCacheMode(WebSettings.LOAD_DEFAULT);
+     		EventsObservable.get().notifyEvent(EventType.GapWebViewCreateComplete, appView);
+       	}",App cache size is now managed dynamically by the `WebView`. This statement has no effect in the new framework.,Why was this removed?
+721,"@@ -1,4 +1,6 @@
+-var nn = node.nodeName.toLowerCase();
+-return (
+-	node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area')
+-);
++const { nodeName } = virtualNode.props;
++if (['img', 'input', 'area'].includes(nodeName) === false) {
++	return false;
++}
++
++return typeof virtualNode.attr('alt') === 'string';","VirtualNode has a `hasAttr` function, any reason why you're not using it?",Why do we need this c
+722,"@@ -69,7 +69,6 @@ public class HttpAccess {
+      * Initializes HttpAccess. Should be called from the application.
+      */
+     public static void init(Context app) {
+-        assert DEFAULT == null : ""HttpAccess.init should be called once per process"";
+         DEFAULT = new HttpAccess(app, null /* user agent will be calculated at request time */);
+     }
+ ",This now throws when running tests (maybe the move to java 11??). Do we want to keep it?,Why was this removed?
+723,"@@ -45,8 +45,8 @@ func EncodeSha1(str string) string {
+ }
+ 
+ func ShortSha(sha1 string) string {
+-	if len(sha1) == 40 {
+-		return sha1[:10]
++	if len(sha1) > 7 {
++		return sha1[:7]
+ 	}
+ 	return sha1
+ }","We can allow 7-char SHA, does not mean we want to show with 7-char in default, please change to `if len() > 10`, then cut.",Why did you change th
+724,"@@ -66,8 +66,10 @@ en_US.strings = {
+   loading: 'Loading...',
+   logOut: 'Log out',
+   myDevice: 'My Device',
++  noDuplicates: 'Cannot add the duplicate file %{fileName}, it already exists',
+   noFilesFound: 'You have no files or folders here',
+   noInternetConnection: 'No Internet connection',
++  noNewAlreadyUploading: 'Cannot add new files: already uploading',
+   openFolderNamed: 'Open folder %{name}',
+   pause: 'Pause',
+   pauseUpload: 'Pause upload',",this one should also have quotes i guess :),"I think this should be `Cannot add duplicate file %{fileName}, it already exists`"
+725,"@@ -106,12 +106,14 @@ func TestBuilderForYAML(t *testing.T) {
+ 		""Test 2"": {fakeInvalidK8sResource, """", true},
+ 	}
+ 	for name, mock := range tests {
++		name := name // pin it
++		mock := mock // pin it
+ 		t.Run(name, func(t *testing.T) {
+ 			b := BuilderForYaml(mock.resourceYAML)
+ 			if mock.expectError && len(b.errs) == 0 {
+ 				t.Fatalf(""Test %s failed, expected err but got 0"", name)
+-			} else if b.unstruct.object.GetName() != mock.expectedName {
+-				t.Fatalf(""Test %s failed, expected %v but got %v"", name, mock.expectedName, b.unstruct.object.GetName())
++			} else if b.unstruct.Object.GetName() != mock.expectedName {
++				t.Fatalf(""Test %s failed, expected %v but got %v"", name, mock.expectedName, b.unstruct.Object.GetName())
+ 			}
+ 		})
+ 	}",Using the variable on range scope `mock` in function literal (from `scopelint`),why do we need to pin it?
+726,"@@ -1020,7 +1020,7 @@ public class Datasets extends AbstractApiBean {
+             PublishDatasetResult res = execCommand(new PublishDatasetCommand(ds,
+                         createDataverseRequest(user),
+                     isMinor));
+-            return res.isCompleted() ? ok(json(res.getDataset())) : accepted(json(res.getDataset()));
++            return res.isWorkflow() ? accepted(json(res.getDataset())) : ok(json(res.getDataset()));
+             }
+         } catch (WrappedResponse ex) {
+             return ex.getResponse();",does this result in a 200 when the dataset is still inprogress/publishing not yet finalized? Seems like 202 is the right code for that (as it was) and the test should be watching for a 202?,Shouldn't this be `res.isCompleted()`?
+727,"@@ -65,6 +65,7 @@ public class SmartStorePlugin extends ForcePlugin {
+ 	public static final String LIKE_KEY = ""likeKey"";
+ 	public static final String MATCH_KEY = ""matchKey"";
+ 	public static final String SMART_SQL = ""smartSql"";
++	public static final String ORDER_PATH = ""orderPath"";
+ 	public static final String ORDER = ""order"";
+ 	public static final String PAGE_SIZE = ""pageSize"";
+ 	public static final String QUERY_TYPE = ""queryType"";","Previously you could only order by the field you were searching by. But for full-text search, you can search across all indexed fields, and it didn't make sense not to have a sorting. For backward compatibility, the javascript code uses indexPath as the orderPath when no orderPath is provided.",Why do we need this?
+728,"@@ -38,7 +38,7 @@ export function flushMounts() {
+  * Apply differences in a given vnode (and it's deep children) to a real DOM Node.
+  * @param {import('../dom').PreactElement} dom A DOM node to mutate into the shape of a `vnode`
+  * @param {import('../vnode').VNode} vnode A VNode (with descendants forming a tree) representing
+- *  the desired DOM structure
++ *	the desired DOM structure
+  * @param {object} context The current context
+  * @param {boolean} mountAll Whether or not to immediately mount all components
+  * @param {Element} parent ?",VIM didn't like your whitespace.,Why the extra space?
+729,"@@ -3,14 +3,7 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+ 
+-using System;
+-using System.Collections.Generic;
+-using System.IO;
+-using System.Linq;
+-using System.Reflection;
+-using System.Threading;
+-using System.Threading.Tasks;
+-using Datadog.Trace.TestHelpers;
++using Datadog.Trace.ClrProfiler;
+ using Xunit;
+ using Xunit.Abstractions;
+ using Xunit.Sdk;",Are you sure the namespace should change?,Why do we need this?
+730,"@@ -12,7 +12,7 @@ namespace MvvmCross.ViewModels
+ 
+         void Initialize();
+ 
+-        void Startup(object hint);
++        object Startup(object hint);
+ 
+         void Reset();
+     }",@martijn00 I'm not sure why we're keeping the object parameter and return type since this can be done by using MvxApplication<THint> with THint set to object,Why is this change n
+731,"@@ -31,6 +31,7 @@ import com.pingcap.tikv.meta.TiColumnInfo.InternalTypeHolder;
+ // https://dev.mysql.com/doc/refman/8.0/en/time.html
+ 
+ public class TimeType extends DataType {
++  public static final TimeType TIME = new TimeType(MySQLType.TypeDuration);
+   public static final MySQLType[] subTypes = new MySQLType[] {MySQLType.TypeDuration};
+   protected static final long NANOSECOND = 1;
+   protected static final long MICROSECOND = 1000 * NANOSECOND;",why do we create a time type here?,Why is this needed?
+732,"@@ -1,4 +1,4 @@
+-define([""jQuery"", ""datetime"", ""loading"", ""libraryMenu"", ""listViewStyle"", ""paper-icon-button-light""], function ($, datetime, loading, libraryMenu) {
++define([""jQuery"", ""datetime"", ""loading"", ""libraryMenu"", ""css!components/listview/listview"", ""paper-icon-button-light""], function ($, datetime, loading, libraryMenu) {
+     ""use strict"";
+ 
+     function populateRatings(allParentalRatings, page) {",Does this style actually need to get loaded in all of these components?,Why do we need this change?
+733,"@@ -30,6 +30,9 @@ import io.servicecomb.foundation.ssl.SSLCustom;
+ import io.servicecomb.foundation.ssl.SSLOption;
+ import io.servicecomb.foundation.ssl.SSLOptionFactory;
+ import io.servicecomb.foundation.vertx.VertxTLSBuilder;
++import io.servicecomb.transport.rest.vertx.accesslog.AccessLogConfiguration;
++import io.servicecomb.transport.rest.vertx.accesslog.impl.AccessLogHandlerImpl;
++import io.servicecomb.transport.rest.vertx.accesslog.parser.impl.DefaultAccessLogPatternParser;
+ import io.vertx.core.AbstractVerticle;
+ import io.vertx.core.Context;
+ import io.vertx.core.Future;",import but not used so you did not resolve compile warnings?,Why is this needed?
+734,"@@ -865,15 +865,10 @@ BlockType_t Creature::blockHit(Creature* attacker, CombatType_t combatType, int3
+ 		}
+ 
+ 		if (checkArmor) {
+-			int32_t armorValue = getArmor();
+-			if (armorValue > 1) {
+-				double armorFormula = armorValue * 0.475;
+-				int32_t armorReduction = static_cast<int32_t>(std::ceil(armorFormula));
+-				damage -= uniform_random(
+-					armorReduction,
+-					armorReduction + static_cast<int32_t>(std::floor(armorFormula))
+-				);
+-			} else if (armorValue == 1) {
++			int32_t armor = getArmor();
++			if (armor > 3) {
++				damage -= uniform_random(armor / 2, armor - (armor % 2 + 1));
++			} else if (armor > 0) {
+ 				--damage;
+ 			}
+ ",This is so much more concise and beautiful than the previous formula  ,I think this should be `(ar
+735,"@@ -41,9 +41,19 @@ import org.hyperledger.besu.tests.acceptance.dsl.transaction.perm.PermissioningT
+ import org.hyperledger.besu.tests.acceptance.dsl.transaction.privacy.PrivacyTransactions;
+ import org.hyperledger.besu.tests.acceptance.dsl.transaction.web3.Web3Transactions;
+ 
++import java.io.File;
++
++import org.apache.logging.log4j.LogManager;
++import org.apache.logging.log4j.Logger;
++import org.apache.logging.log4j.ThreadContext;
+ import org.junit.After;
++import org.junit.Rule;
++import org.junit.rules.TestName;
++import org.junit.rules.TestWatcher;
++import org.junit.runner.Description;
+ 
+ public class AcceptanceTestBase {
++  protected final Logger LOG = LogManager.getLogger();
+ 
+   protected final Accounts accounts;
+   protected final AccountTransactions accountTransactions;",Is there any reason not to have the `static` modifier for the logger? _(that would be in keeping with the reference being uppercase)_,I don't think this is used.
+736,"@@ -27,11 +27,18 @@ import (
+ // DialogCreator creates new dialog between consumer and provider, using given contact information
+ type DialogCreator func(consumerID, providerID identity.Identity, contact market.Contact) (communication.Dialog, error)
+ 
++// SessionCreationConfig are the parameters that get sent to the provider
++type SessionCreationConfig interface{}
++
++// ConsumerConfig are the parameters used for the initiation of connection
++type ConsumerConfig interface{}
++
+ // Connection represents a connection
+ type Connection interface {
+-	Start() error
++	Start(ConnectOptions) error
+ 	Wait() error
+ 	Stop()
++	GetSessionConfig() (SessionCreationConfig, error)
+ }
+ 
+ // StateChannel is the channel we receive state change events on",It's not about session creation config. It's about passing consumer config parameters to underlying transport - nothing to do with session itself,Why do we need this interface?
+737,"@@ -97,7 +97,7 @@ type ConfigLocal struct {
+ 	kbpki            KBPKI
+ 	renamer          ConflictRenamer
+ 	registry         metrics.Registry
+-	loggerFn         func(prefix string) logger.Logger
++	loggerFn         func(prefix string, overrideEnableDebug bool) logger.Logger
+ 	noBGFlush        bool // logic opposite so the default value is the common setting
+ 	rwpWaitTime      time.Duration
+ 	diskLimiter      DiskLimiter","Why is there an ""enable"" in the param name? Couldn't it just be `overrideDebug`? Here are everywhere else.",I don't think this is needed.
+738,"@@ -1,4 +1,8 @@
+ class VideosController < ApplicationController
++  def index
++    @videos = Video.published.recently_published_first
++  end
++
+   def show
+     @video = Video.find(params[:id])
+     @offering = Offering.new(@video.watchable, current_user)",`published.recently_published_first` reads a little oddly to me. Is this the same thing as `Video.published.ordered`?,Why do we need this?
+739,"@@ -20,7 +20,11 @@ var createIntegrationPreprocessor = function(logger) {
+       // and add the test data to it
+       var htmlpath = file.originalPath.replace(extRegex, '.html');
+       var html = fs.readFileSync(htmlpath, 'utf-8');
+-      var test = JSON.parse(content);
++      try {
++        var test = JSON.parse(content);
++      } catch (e) {
++        throw new Error('Unable to parse content of ' + file.originalPath)
++      }
+       test.content = html;
+ 
+       var result = template.replace('{}; /*tests*/', JSON.stringify(test));",Encountered this because I had a stray comma. Figured I'd tweak it a bit.,Why is this needed?
+740,"@@ -306,6 +306,13 @@ var _ = infrastructure.DatastoreDescribe(""service loop prevention; with 2 nodes""
+ 			cfg.Spec.ServiceLoopPrevention = ""Disabled""
+ 		})
+ 
++		// Expect to see empty cali-cidr-block chains.  (Allowing time for a Felix
++		// restart.)  This ensures that the cali-cidr-block chain has been cleared
++		// before we try a test ping.
++		for _, felix := range felixes {
++			Eventually(getCIDRBlockRules(felix, ""iptables-save""), ""8s"", ""0.5s"").Should(BeEmpty())
++		}
++
+ 		By(""test that we DO get a routing loop"")
+ 		// (In order to test that the tryRoutingLoop setup is genuine.)
+ 		tryRoutingLoop(true)",qq: Should this include the iptables6-save sim. to the inverse checks above?,"I'm not sure if this is the best way to test this, but I'm not sure if there's a better way."
+741,"@@ -195,8 +195,16 @@ func (cfg *Config) Merge(rhs Config) *Config {
+ 
+ 	for i := 0; i < left.NumField(); i++ {
+ 		leftField := left.Field(i)
+-		if utils.ZeroOrNil(leftField.Interface()) {
+-			leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++		switch leftField.Interface().(type) {
++		case BooleanDefaultFalse, BooleanDefaultTrue:
++			str, _ := json.Marshal(reflect.ValueOf(leftField.Interface()).Interface())
++			if string(str) == ""null"" {
++				leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++			}
++		default:
++			if utils.ZeroOrNil(leftField.Interface()) {
++				leftField.Set(reflect.ValueOf(right.Field(i).Interface()))
++			}
+ 		}
+ 	}
+ ",im open to explicitly checking NotSet value here but json logic already handles it so kept it this way.,Why is this needed?
+742,"@@ -27,6 +27,7 @@ extern ""C"" {
+ #include ""ScriptingEnvironment.h""
+ #include ""../typedefs.h""
+ #include ""../Util/OpenMPWrapper.h""
++#include ""../Util/Lua.h""
+ 
+ ScriptingEnvironment::ScriptingEnvironment() {}
+ ScriptingEnvironment::ScriptingEnvironment(const char * fileName) {",The naming of the include file appears to be unlucky.,"#include ""ScriptingEnvironment.h"""
+743,"@@ -1018,7 +1018,8 @@ class BarPlot(BarsMixin, ColorbarPlot, LegendPlot):
+         if self.show_legend and any(len(l) for l in labels) and (sdim or not self.multi_level):
+             leg_spec = self.legend_specs[self.legend_position]
+             if self.legend_cols: leg_spec['ncol'] = self.legend_cols
+-            axis.legend(title=title, **leg_spec)
++            self.legend_opts.update(**leg_spec)
++            axis.legend(title=title, **self.legend_opts)
+ 
+         return bars, xticks, ax_dims
+ ",Bit worried about this. At minimum you should make a copy of the dict here to avoid modifying a user supplied variable.,I think this should be `self.legend_opts = leg_spec`
+744,"@@ -455,6 +455,11 @@ func (r *AWSMachinePoolReconciler) reconcileLaunchTemplate(machinePoolScope *sco
+ 	// userdata, OR we've discovered a new AMI ID.
+ 	if needsUpdate || tagsChanged || *imageID != *launchTemplate.AMI.ID || launchTemplateUserDataHash != bootstrapDataHash {
+ 		machinePoolScope.Info(""creating new version for launch template"", ""existing"", launchTemplate, ""incoming"", machinePoolScope.AWSMachinePool.Spec.AWSLaunchTemplate)
++		// There is a limit to the number of Launch Template Versions.
++		// We ensure that the number of versions does not grow without bound by following a simple rule: For each version we create, we delete one old version.
++		if err := ec2svc.PruneLaunchTemplateVersions(machinePoolScope.AWSMachinePool.Status.LaunchTemplateID); err != nil {
++			return err
++		}
+ 		if err := ec2svc.CreateLaunchTemplateVersion(machinePoolScope, imageID, bootstrapData); err != nil {
+ 			return err
+ 		}","Is it better to create one before pruning? In case creation fails we don't want to delete the previous one. We create a new one, it is tagged as latest, so the previous can be deleted. `CreateLaunchTemplateVersion` returns the version created, how about directly trying to delete the previous version? Assuming the numbering is strictly increasing.",I'm not sure if this is the right place to do this. I think it should be in the `CreateLaunchTemplateVersion` function.
+745,"@@ -27,13 +27,13 @@ class ContainerInformationTab extends Tab {
+ 
+     private final WinePrefixContainerDTO container;
+ 
+-    private Consumer<ContainerDTO> onDeletePrefix;
++    private Consumer<ContainerDTO> onDeleteContainer;
+     private Consumer<ContainerDTO> onOpenFileBrowser;
+ 
+-    ContainerInformationTab(WinePrefixContainerDTO container) {
++    ContainerInformationTab(ContainerDTO container) {
+         super(tr(""Information""));
+ 
+-        this.container = container;
++        this.container = (WinePrefixContainerDTO) container; // TODO: use generic container
+ 
+         this.setClosable(false);
+ ",Do we require the specific implementation information here?,Why do we need this TODO?
+746,"@@ -0,0 +1,13 @@
++class DomainBlacklist < ActiveRecord::Base
++  validates :domain, uniqueness: { case_sensitive: false }
++
++  class << self
++    def email_banned?(email_address)
++      contains?(email_address.split('@').last)
++    end
++
++    def contains?(domain)
++      exists?(['lower(domain) LIKE ?', ""%#{domain.downcase}%""])
++    end
++  end
++end","How about `exists?(['domain ~* ?', domain.downcase])` ?",I don't think you need the `.split('@')` here.
+747,"@@ -729,6 +729,15 @@ func newContextForLongPoll(c *cli.Context) (context.Context, context.CancelFunc)
+ 	return newContextWithTimeout(c, defaultContextTimeoutForLongPoll)
+ }
+ 
++func newContextForBackground(c *cli.Context) (context.Context, context.CancelFunc) {
++	if c.GlobalIsSet(FlagContextTimeout) {
++		timeout := time.Duration(c.GlobalInt(FlagContextTimeout)) * time.Second
++		return rpc.NewContextWithTimeoutAndCLIHeaders(timeout)
++	}
++
++	return rpc.NewContextWithCLIHeaders()
++}
++
+ func newContextWithTimeout(c *cli.Context, timeout time.Duration) (context.Context, context.CancelFunc) {
+ 	if c.GlobalIsSet(FlagContextTimeout) {
+ 		timeout = time.Duration(c.GlobalInt(FlagContextTimeout)) * time.Second",Is this getting used in other places? Can we switch all the places to use the new API you added?,nit: `newContextWithTimeoutAndCLIHeaders` -> `newContext`
+748,"@@ -483,17 +483,6 @@ int HTTP_OP::libcurl_exec(
+     curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, 1L);
+     //curl_easy_setopt(curlEasy, CURLOPT_SSL_VERIFYPEER, FALSE);
+ 
+-    // if the above is nonzero, you need the following:
+-    //
+-#ifndef _WIN32
+-    if (boinc_file_exists(CA_BUNDLE_FILENAME)) {
+-        // call this only if a local copy of ca-bundle.crt exists;
+-        // otherwise, let's hope that it exists in the default place
+-        //
+-        curl_easy_setopt(curlEasy, CURLOPT_CAINFO, CA_BUNDLE_FILENAME);
+-    }
+-#endif
+-
+     // set the user agent as this boinc client & version
+     //
+     curl_easy_setopt(curlEasy, CURLOPT_USERAGENT, g_user_agent_string);","This need to be checked with linux. AFAIK, we have this file in our bin directory that is a link to the system file.",Why is this being removed?
+749,"@@ -1,12 +1,12 @@
+-define(['browser', 'dom', 'layoutManager', 'css!components/viewManager/viewContainer'], function (browser, dom, layoutManager) {
+-    'use strict';
++import 'css!components/viewManager/viewContainer';
++/* eslint-disable indent */
+ 
+     function setControllerClass(view, options) {
+         if (options.controllerFactory) {
+             return Promise.resolve();
+         }
+ 
+-        var controllerUrl = view.getAttribute('data-controller');
++        let controllerUrl = view.getAttribute('data-controller');
+ 
+         if (controllerUrl) {
+             if (controllerUrl.indexOf('__plugin/') === 0) {",Shouldn't we import `default`? I can't get here to test.,Why are we disabling inden
+750,"@@ -99,7 +99,7 @@ class UNIXServerClient(object):
+         self.unix_socket = os.path.join(self.temp_dir, 'luigid.sock')
+ 
+     def run_server(self):
+-        luigi.server.run(unix_socket=unix_socket)
++        luigi.server.run(unix_socket=self.unix_socket)
+ 
+     def scheduler(self):
+         url = ParseResult(","!!!!!!!!!!!!! @graingert, does this mean that tests haven't been running???",Why do we need this change
+751,"@@ -484,11 +484,11 @@ namespace Microsoft.DotNet.Execute
+         public string FormatSetting(string option, string value, string type, string toolName)
+         {
+             string commandOption = null;
+-            if (type.Equals(""passThrough""))
++            if (type != null && type.Equals(""passThrough""))
+             {
+                 commandOption = string.Format("" {0}"", toolName.Equals(""console"") ? """" : value);
+             }
+-            else if (type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }
++            else if (type != null && type.Equals(RunToolSettingValueTypeReservedKeyword)) { /* do nothing */ }
+             else
+             {
+                 Tool toolFormat;","I've already tried the null-coalescing operator here and got a strange error, so did this the old-fashioned way.",Why is this null check nee
+752,"@@ -1,4 +1,11 @@
+ var parent = axe.commons.dom.getComposedParent(node);
+-return (['UL', 'OL'].includes(parent.nodeName.toUpperCase()) ||
+-    (parent.getAttribute('role') || '').toLowerCase() === 'list');
+-  
++
++var parentRole = (parent.getAttribute('role') || '').toLowerCase();
++
++var isListRole = parentRole === 'list';
++
++return (
++	(['UL', 'OL'].includes(parent.nodeName.toUpperCase()) &&
++		(!parentRole || isListRole)) ||
++	isListRole
++);",This doesn't follow our spacing convention. It's also a little hard to read. Can you reformat?,I don't think you need the `|| ''` here.
+753,"@@ -4,10 +4,10 @@
+ package stack
+ 
+ import (
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/template""
+ 	""github.com/aws/aws-sdk-go/service/cloudformation""
++	""github.com/aws/copilot-cli/internal/pkg/template""
+ 
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy""
++	""github.com/aws/copilot-cli/internal/pkg/deploy""
+ )
+ 
+ const pipelineCfnTemplatePath = ""cicd/pipeline_cfn.yml""","The deploy should come before template? EDIT: I see that in other files, we put a separate line and put deploy at the end. What is the reason for this?",nit: this should be grouped with the oth
+754,"@@ -60,7 +60,7 @@ public class Program
+             // turn off the above default. i.e any
+             // instrument which does not match any views
+             // gets dropped.
+-            // .AddView(instrumentName: ""*"", new DropAggregationConfig())
++            // .AddView(instrumentName: ""*"", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })
+             .AddConsoleExporter()
+             .Build();
+ ",Consider making a constant (e.g. `MetricStreamConfiguration.Drop`).,Why is this change needed?
+755,"@@ -18,6 +18,7 @@ try:
+ except ImportError:
+   from rdkit.piddle import piddle
+ import ClusterUtils
++from rdkit.six.moves import xrange
+ 
+ import numpy
+ ",same question: why not just switch this to range too?,from itertools import xrange
+756,"@@ -111,10 +111,10 @@ Variable IO::InquireVariable(const std::string &name)
+     helper::CheckForNullptr(m_IO, ""for variable "" + name +
+                                       "", in call to IO::InquireVariable"");
+ 
+-    const std::string type(m_IO->InquireVariableType(name));
++    const Type type(m_IO->InquireVariableType(name));
+     core::VariableBase *variable = nullptr;
+ 
+-    if (type == ""unknown"")
++    if (type == Type::None)
+     {
+     }
+ #define declare_template_instantiation(T)                                      \","@chuckatkins most places used an empty string for ""no type"", but a few used `""unknown""`. I've converted both cases to `Type::None`. Do you know why there was a distinction before?",Shouldn't this be Type::Unknown?
+757,"@@ -408,7 +408,7 @@ void CUDATreeLearner::copyDenseFeature() {
+     // looking for dword_features_ non-sparse feature-groups
+     if (!train_data_->IsMultiGroup(i)) {
+       dense_feature_group_map_.push_back(i);
+-      auto sizes_in_byte = train_data_->FeatureGroupSizesInByte(i);
++      auto sizes_in_byte = std::min(train_data_->FeatureGroupSizesInByte(i), static_cast<size_t>(num_data_));
+       void* tmp_data = train_data_->FeatureGroupData(i);
+       Log::Debug(""Started copying dense features from CPU to GPU - 2"");
+       CUDASUCCESS_OR_FATAL(cudaMemcpyAsync(&device_features[copied_feature * num_data_], tmp_data, sizes_in_byte, cudaMemcpyHostToDevice, stream_[device_id]));",should we assert for the type for `FeatureGroupData` ? I think it should be 1-Byte type.,Why do we need this change?
+758,"@@ -51,10 +51,10 @@ class TestCube(ComparisonTestCase):
+     def test_dimension_values_vdim(self):
+         cube = Dataset(self.cube, kdims=['longitude', 'latitude'])
+         self.assertEqual(cube.dimension_values('unknown', flat=False),
+-                         np.flipud(np.array([[ 0,  4,  8],
+-                                             [ 1,  5,  9],
+-                                             [ 2,  6, 10],
+-                                             [ 3,  7, 11]], dtype=np.int32).T))
++                         np.array([[ 0,  4,  8],
++                                   [ 1,  5,  9],
++                                   [ 2,  6, 10],
++                                   [ 3,  7, 11]], dtype=np.int32).T)
+ 
+     def test_range_kdim(self):
+         cube = Dataset(self.cube, kdims=['longitude', 'latitude'])",As long as you are sure this is definitely correct now... :-),Why did this change?
+759,"@@ -166,7 +166,7 @@ public class ActionsFragment extends SubscriberFragment implements View.OnClickL
+                             tempBasal.setVisibility(View.GONE);
+                             tempBasalCancel.setVisibility(View.VISIBLE);
+                             final TemporaryBasal activeTemp = MainApp.getConfigBuilder().getTempBasalFromHistory(System.currentTimeMillis());
+-                            tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + ""\n"" + activeTemp.toStringShort());
++                            tempBasalCancel.setText(MainApp.instance().getString(R.string.cancel) + "" "" + activeTemp.toStringShort());
+                         } else {
+                             tempBasal.setVisibility(View.VISIBLE);
+                             tempBasalCancel.setVisibility(View.GONE);",... so that all action buttons have the same height :-),I'm not sure if this is the best
+760,"@@ -21,6 +21,12 @@
+ #include <fastdds/dds/log/Log.hpp>
+ #include <fastdds/dds/log/Colors.hpp>
+ #include <fastrtps/xmlparser/XMLProfileManager.h>
++#include <fastdds/dds/domain/DomainParticipantFactory.hpp>
++#include <fastdds/dds/domain/DomainParticipant.hpp>
++#include <fastdds/dds/publisher/DataWriterListener.hpp>
++#include <fastdds/dds/subscriber/qos/DataReaderQos.hpp>
++#include <fastdds/dds/subscriber/DataReader.hpp>
++#include <fastdds/dds/publisher/DataWriter.hpp>
+ 
+ #include <numeric>
+ #include <cmath>","Use correct, alpha sorted, include order. Correct order means: 1. Header corresponding to this source (i.e. `""LatencyTestPublisher.hpp""`) 2. C system headers 3. C++ system headers 4. Alpha-sorted external libraries headers 5. Alpha-sorted public headers from this project 6. Alpha-sorted private headers",Why is this header needed?
+761,"@@ -58,6 +58,10 @@ type OutboundOption func(*Outbound)
+ 
+ func (OutboundOption) httpOption() {}
+ 
++// RequestFactory allows clients to configure their outgoing http requests. If not set,
++// a default implemenation will use the HostPort to make a POST request with the request body.
++type RequestFactory func(*transport.Request) (*http.Request, error)
++
+ // URLTemplate specifies the URL this outbound makes requests to. For
+ // peer.Chooser-based outbounds, the peer (host:port) spection of the URL may
+ // vary from call to call but the rest will remain unchanged. For single-peer","I hate this name, open to suggestions.",nit: typo in implemenation
+762,"@@ -199,7 +199,13 @@ func (c *Client) locallyCacheResults(target *core.BuildTarget, digest *pb.Digest
+ 	}
+ 	data, _ := proto.Marshal(ar)
+ 	metadata.RemoteAction = data
+-	c.state.Cache.Store(target, c.localCacheKey(digest), nil)
++	// TODO(jpoole): Similar to retrieveTargetMetadataFromCache, it would be cleaner if we could store
++	//               into the cache from an arbitrary reader.
++	if err := build.StoreTargetMetadata(target, metadata); err != nil {
++		log.Warning(""%s"", err)
++		return
++	}
++	c.state.Cache.Store(target, c.localCacheKey(digest), []string{target.TargetBuildMetadataFileName()})
+ }
+ 
+ // retrieveLocalResults retrieves locally cached results for a target if possible.",Does this log line work? We need Warningf or just warning without the format string.,I don't think this is the 
+763,"@@ -62,6 +62,7 @@ func New(checkpointer export.Checkpointer, exporter export.Exporter, opts ...Opt
+ 	impl := sdk.NewAccumulator(
+ 		checkpointer,
+ 		sdk.WithResource(c.Resource),
++		sdk.WithMetricsProcessors(c.MetricsProcessors...),
+ 	)
+ 	return &Controller{
+ 		provider:     registry.NewMeterProvider(impl),",The pull controller would need similar updates.,Why do we need this?
+764,"@@ -1,5 +1,5 @@
+ /**
+- * Copyright 2015-2017 The OpenZipkin Authors
++ * Copyright 2015-2018 The OpenZipkin Authors
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except
+  * in compliance with the License. You may obtain a copy of the License at",ignore this.. just didn't want to litter with a commit update to satisfy license plugin,Why did you change this?
+765,"@@ -807,8 +807,8 @@ module Beaker
+         end
+ 
+         if host['is_cygwin'].nil? or host['is_cygwin'] == true
+-          dest = ""/cygdrive/c/Windows/Temp/#{host['dist']}.msi""
+-          on host, ""curl -O #{dest} #{link}""
++          dest = ""#{host['dist']}.msi""
++          on host, ""curl -O #{link}""
+ 
+           #Because the msi installer doesn't add Puppet to the environment path
+           #Add both potential paths for simplicity",Is this definition needed since it doesn't look like it's being used anywhere?,Why was this changed?
+766,"@@ -35,6 +35,11 @@ module Mongoid
+           class << self
+             delegate :discriminator_key, to: ::Mongoid
+           end
++        end 
++
++        unless fields.has_key?(self.discriminator_key) || descendants.length == 0
++          default_proc = lambda { self.class.name }
++          field(self.discriminator_key, default: default_proc, type: String)
+         end
+       end
+     end",Can this condition be reworded using `if` please?,I'm not sure if this is 
+767,"@@ -135,13 +135,15 @@ Status FetchEdgesExecutor::setupEdgeKeysFromRef() {
+     const InterimResult *inputs;
+     if (sentence_->ref()->isInputExpr()) {
+         inputs = inputs_.get();
+-        if (inputs == nullptr) {
++        if (inputs == nullptr
++                || (inputs != nullptr && !inputs->hasData())) {
+             // we have empty imputs from pipe.
+             return Status::OK();
+         }
+     } else {
+         inputs = ectx()->variableHolder()->get(varname_);
+-        if (inputs == nullptr) {
++        if (inputs == nullptr
++                || (inputs != nullptr && !inputs->hasData())) {
+             return Status::Error(""Variable `%s' not defined"", varname_.c_str());
+         }
+     }","after ||, no need inputs != nullptr",I think this should be `
+768,"@@ -159,7 +159,14 @@ func (s *Source) Owner() (string, error) {
+ // is deloying to and the containerized applications that will be deployed.
+ type PipelineStage struct {
+ 	*AssociatedEnvironment
+-	LocalApplications []string
++	LocalApplications []AppInStage
++}
++
++// AppInStage represents configurations for an app in a pipeline stage
++type AppInStage struct {
++	Name string
++	// the path to the integration test buildspec for this action
++	IntegTestBuildspecPath string
+ }
+ 
+ // AppTemplatePath returns the full path to the application CFN template",Is it just preference or on purpose that using slice of structs instead of slice of pointers?,nit: `IntegTestBuildspecPath` is unused (from `structcheck`)
+769,"@@ -90,7 +90,7 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi
+ 					c.state = c._nextState;
+ 					c._dirty = false;
+ 					c._vnode = newVNode;
+-					newVNode._dom = oldDom!=null ? oldDom!==oldVNode._dom ? oldDom : oldVNode._dom : null;
++					newVNode._dom = oldVNode._dom;
+ 					newVNode._children = oldVNode._children;
+ 					for (tmp = 0; tmp < newVNode._children.length; tmp++) {
+ 						if (newVNode._children[tmp]) newVNode._children[tmp]._parent = newVNode;",This line always confused me   anyway. Good catch!,Why did you remove the null check?
+770,"@@ -130,6 +130,6 @@ func (j journalBlockServer) IsUnflushed(ctx context.Context, tlfID tlf.ID,
+ }
+ 
+ func (j journalBlockServer) Shutdown() {
+-	j.jServer.shutdown()
++	j.jServer.shutdown(context.Background())
+ 	j.BlockServer.Shutdown()
+ }","Should we add `ctx` to `BlockServer.Shutdown()` for this purpose? Would be nice, but I don't care too much.",Why do we need a context here?
+771,"@@ -42,7 +42,7 @@ bool DeadlineQosPolicy::addToCDRMessage(CDRMessage_t* msg)
+     bool valid = CDRMessage::addUInt16(msg, this->Pid);
+     valid &= CDRMessage::addUInt16(msg, this->length);//this->length);
+     valid &= CDRMessage::addInt32(msg,period.seconds);
+-    valid &= CDRMessage::addUInt32(msg,period.fraction);
++    valid &= CDRMessage::addUInt32(msg,period.nanosec);
+     return valid;
+ }
+ ",Duration_t at RTPS level must be serialized using fractions.,Shouldn't this be `addInt32`?
+772,"@@ -28,6 +28,14 @@ import (
+ 	""go.uber.org/yarpc/yarpcerrors""
+ )
+ 
++var msgInboundDispatcherNotRunning = ""peer for service %q is not running""
++
++// NotRunningInboundError builds a YARPC error with code
++// yarpcerrors.CodeUnavailable when the dispatcher is not running.
++func NotRunningInboundError(service string) error {
++	return yarpcerrors.UnavailableErrorf(msgInboundDispatcherNotRunning, service)
++}
++
+ // RequestBodyDecodeError builds a YARPC error with code
+ // yarpcerrors.CodeInvalidArgument that represents a failure to decode
+ // the request body.","""peer"" has its own meaning within YARPC with its own class of objects. This should probably be ""dispatcher"" too?",nit: can we call this `ErrInboundDispatcherNotRunning`?
+773,"@@ -172,9 +172,18 @@ class ClangSA(analyzer_base.SourceAnalyzer):
+                                          '-Xclang', checker_name])
+ 
+             if config.ctu_dir and not self.__disable_ctu:
++                # ctu-clang5 compatibility
+                 analyzer_cmd.extend(['-Xclang', '-analyzer-config',
+                                      '-Xclang',
+-                                     'xtu-dir=' + self.get_xtu_dir()])
++                                     'xtu-dir=' + self.get_ctu_dir()])
++                # ctu-clang6 compatibility (5.0 and 6.0 options work together)
++                analyzer_cmd.extend(['-Xclang', '-analyzer-config',
++                                     '-Xclang',
++                                     'experimental-enable-naive-ctu-analysis'
++                                     '=true',
++                                     '-Xclang', '-analyzer-config',
++                                     '-Xclang',
++                                     'ctu-dir=' + self.get_ctu_dir()])
+                 if config.ctu_has_analyzer_display_ctu_progress:
+                     analyzer_cmd.extend(['-Xclang',
+                                          '-analyzer-display-ctu-progress'])",I do not like this line break before `=true`. Maybe starting the list in the next line would help to reduce the indent? This way we could keep this string together.,I don't think you need to add `-Xclang` here.
+774,"@@ -34,18 +34,10 @@ import (
+ // the default value in Default var.
+ 
+ func init() {
+-	flag.StringVar(&_overwritePath, ""config-path"", """", ""Config path"")
+-	flag.StringVar(&_secretPath, ""secret-path"", """", ""Secret path"")
+-	flag.StringVar(&_subChainPath, ""sub-config-path"", """", ""Sub chain Config path"")
+ 	flag.Var(&_plugins, ""plugin"", ""Plugin of the node"")
+ }
+ 
+ var (
+-	// overwritePath is the path to the config file which overwrite default values
+-	_overwritePath string
+-	// secretPath is the path to the  config file store secret values
+-	_secretPath   string
+-	_subChainPath string
+ 	_plugins      strs
+ 	_evmNetworkID uint32
+ 	loadChainID   sync.Once",_plugins should be removed too,Why are these removed?
+775,"@@ -0,0 +1,5 @@
++let nn = node.nodeName.toLowerCase();
++let validSetup =
++	node.hasAttribute('alt') && (nn === 'img' || nn === 'input' || nn === 'area');
++let validAttrValue = /^\s+$/.test(node.getAttribute('alt'));
++return validSetup && validAttrValue;","The rule selector will not include `<input>` and `<area>` elements. Why not make this a new, separate rule altogether?",Why do we need this?
+776,"@@ -1122,7 +1122,7 @@ class CommandDispatcher:
+         try:
+             userscripts.run_async(tab, cmd, *args, win_id=self._win_id,
+                                   env=env, verbose=verbose)
+-        except userscripts.UnsupportedError as e:
++        except (userscripts.UnsupportedError, userscripts.NotFoundError) as e:
+             raise cmdexc.CommandError(e)
+ 
+     @cmdutils.register(instance='command-dispatcher', scope='window')",@The-Compiler Is this style okay or would you prefer a common userscript exception base?,I don't think this is the right exception to raise here. It should be a `CommandError`.
+777,"@@ -98,7 +98,8 @@ SchemaBuffer.prototype.cast = function (value, doc, init) {
+ 
+     return value;
+   } else if (value instanceof Binary) {
+-    return new MongooseBuffer(value.value(true), [this.path, doc]);
++    var sub_type = value.sub_type || 0x00;
++    return (new MongooseBuffer(value.value(true), [this.path, doc])).toObject(sub_type);
+   }
+ 
+   if (null === value) return value;",we'd need to return a MongooseBuffer here instead of the Binary. lets add the subtype option to the buffer schema type as referenced in #1000 instead.,Why is this needed?
+778,"@@ -1158,7 +1158,6 @@ function updateDocuments(coll, selector, document, options, callback) {
+   if ('function' === typeof options) (callback = options), (options = null);
+   if (options == null) options = {};
+   if (!('function' === typeof callback)) callback = null;
+-
+   // If we are not providing a selector or document throw
+   if (selector == null || typeof selector !== 'object')
+     return callback(toError('selector must be a valid JavaScript object'));",Let's remove this change.,Why was this removed?
+779,"@@ -727,7 +727,7 @@ def processNegativeStates(role, states, reason, negativeStates=None):
+ 	# but only if it is either focused or this is something other than a change event.
+ 	# The condition stops ""not selected"" from being spoken in some broken controls
+ 	# when the state change for the previous focus is issued before the focus change.
+-	if role in (ROLE_LISTITEM, ROLE_TREEVIEWITEM, ROLE_TABLEROW) and STATE_SELECTABLE in states and (reason != REASON_CHANGE or STATE_FOCUSED in states):
++	if role in (ROLE_LISTITEM, ROLE_TREEVIEWITEM, ROLE_TABLEROW,ROLE_TABLECELL,ROLE_TABLECOLUMNHEADER,ROLE_TABLEROWHEADER) and STATE_SELECTABLE in states and (reason != REASON_CHANGE or STATE_FOCUSED in states):
+ 		speakNegatives.add(STATE_SELECTED)
+ 	# Restrict ""not checked"" in a similar way to ""not selected"".
+ 	if (role in (ROLE_CHECKBOX, ROLE_RADIOBUTTON, ROLE_CHECKMENUITEM) or STATE_CHECKABLE in states)  and (STATE_HALFCHECKED not in states) and (reason != REASON_CHANGE or STATE_FOCUSED in states):",Could you split this into multiple lines?,continuation line under-indented for visual indent
+780,"@@ -25,12 +25,17 @@ import { __ } from '@wordpress/i18n';
+ /**
+  * Internal dependencies
+  */
+-import Layout from '../../../components/layout/layout';
++import Data from 'googlesitekit-data';
+ import DashboardModuleHeader from '../../../components/dashboard/dashboard-module-header';
+ import DashboardPageSpeed from '../components/DashboardPageSpeed';
++import { STORE_NAME } from '../../../googlesitekit/datastore/site/constants';
++const { useSelect } = Data;
+ 
+ function DashboardSpeed() {
+-	const description = global.googlesitekit.permaLink ? __( 'How fast this page is.', 'google-site-kit' ) : __( 'How fast your home page is.', 'google-site-kit' );
++	const currentEntityURL = useSelect( ( select ) => select( STORE_NAME ).getCurrentEntityURL() );
++	const description = currentEntityURL
++		? __( 'How fast your page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' )
++		: __( 'How fast your home page loads, how quickly people can interact with your content, and how stable your content is.', 'google-site-kit' );
+ 
+ 	return (
+ 		<Fragment>","This technically works, however it may be safer to use both `getCurrentReferenceURL` and `getCurrentEntityURL` and then make this condition `currentReferenceURL === currentEntityURL`. Currently, this code only works based on the internals of `getCurrentReferenceURL`, so by checking both we would decouple that.",I don't think we need the `currentEntityURL` variable.
+781,"@@ -69,9 +69,9 @@ func (c *WSClient) Connect() (conn.Connection, error) {
+ 	if resp != nil {
+ 		body, errRead := ioutil.ReadAll(resp.Body)
+ 		if errRead == nil {
+-			respMsg = fmt.Sprintf(""response code: %d, response body: %s"", resp.StatusCode, string(body))
++			respMsg = fmt.Sprintf(""Response code: %d, response body: %s"", resp.StatusCode, string(body))
+ 		} else {
+-			respMsg = fmt.Sprintf(""response code: %d"", resp.StatusCode)
++			respMsg = fmt.Sprintf(""Response code: %d"", resp.StatusCode)
+ 		}
+ 		resp.Body.Close()
+ 	}",It does not recommend capitalization,I don't think we need this change.
+782,"@@ -113,6 +113,17 @@ feature 'User creates a subscription' do
+     expect(page).to have_content(I18n.t('subscriptions.flashes.update.success'))
+   end
+ 
++  scenario 'updates Stripe subscription with declining credit card', :js => true do
++    FakeStripe.failure = true
++    sign_in_as_subscriber
++    visit my_account_path
++    submit_declining_credit_card_info
++
++    expect(current_path).to eq my_account_path
++    expect(page).to_not have_content(I18n.t('subscriptions.flashes.update.success'))
++    expect(page).to have_content 'Your credit card was declined'
++  end
++
+   scenario 'does not see option to update billing if not subscribing' do
+     visit my_account_path
+ ","Minor thing, but can you use 1.9 hash syntax for this?",I don't think you need to set `:js => true` here.
+783,"@@ -361,6 +361,7 @@ class LambdaExecutorReuseContainers(LambdaExecutorContainers):
+ 
+                 mount_volume = not config.LAMBDA_REMOTE_DOCKER
+                 lambda_cwd_on_host = Util.get_host_path_for_path_in_docker(lambda_cwd)
++                lambda_cwd_on_host = Util.format_windows_path(lambda_cwd)
+                 mount_volume_str = '-v ""%s"":/var/task' % lambda_cwd_on_host if mount_volume else ''
+ 
+                 # Create and start the container",I tried to follow the code structure already present.,Why do we need this change?
+784,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,nit: `of` -> `from`
+785,"@@ -118,7 +118,7 @@ class ExperimentTestBaseClass(HelperTestCaseBase):
+     global g_myEnv
+     if not g_myEnv:
+       # Setup environment
+-      params = type('obj', (object,), {'installDir' : os.environ['NUPIC']})
++      params = type('obj', (object,), {'installDir' : resource_filename(""nupic"","""")})
+       g_myEnv = MyTestEnvironment(params)
+ 
+ ",Please leave 1 space char between commas here and other places in this PR.,This should be `res
+786,"@@ -100,8 +100,8 @@ bool ThreadsExec::spawn() {
+ 
+   pthread_attr_t attr;
+ 
+-  if (0 == pthread_attr_init(&attr) ||
+-      0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) ||
++  if (0 == pthread_attr_init(&attr) &&
++      0 == pthread_attr_setscope(&attr, PTHREAD_SCOPE_SYSTEM) &&
+       0 == pthread_attr_setdetachstate(&attr, PTHREAD_CREATE_DETACHED)) {
+     pthread_t pt;
+ ",hm is this really &&? Not ||? Was it initially correct if any of these things are not set that it needs to recreated?,Why did you change 
+787,"@@ -149,7 +149,8 @@ public class PackageTool extends SolrCLI.ToolBase {
+                 String version = parsedVersion.second();
+                 boolean noprompt = cli.hasOption('y');
+                 boolean isUpdate = cli.hasOption(""update"") || cli.hasOption('u');
+-                packageManager.deploy(packageName, version, PackageUtils.validateCollections(cli.getOptionValue(""collections"").split("","")), cli.getOptionValues(""param""), isUpdate, noprompt);
++                String collections[] = cli.hasOption(""collections"")? PackageUtils.validateCollections(cli.getOptionValue(""collections"").split("","")): new String[] {};
++                packageManager.deploy(packageName, version, collections, cli.hasOption(""cluster""), cli.getOptionValues(""param""), isUpdate, noprompt);
+                 break;
+               }
+               case ""undeploy"":",Please don't use C-style array declarations. IMO our pre-commit ought to be enhanced to not allow this,Why do we need this
+788,"@@ -259,6 +259,12 @@ bool pmix_value_cmp(pmix_value_t *p, pmix_value_t *p1)
+         case PMIX_STRING:
+             rc = strcmp(p->data.string, p1->data.string);
+             break;
++        case PMIX_COMPRESSED_STRING:
++            if (p->data.bo.size != p1->data.bo.size) {
++                return false;
++            } else {
++                return true;
++            }
+         case PMIX_STATUS:
+             rc = (p->data.status == p1->data.status);
+             break;",@rhc54 This doesn't look like a comprehensive comparison. For `PMIX_STRING` we seem to actually compare the content of the data while here we only compare meta-information which doesn't ensure that values are the same.,I think it would be better to use `p->data.bo.size != p1->data.bo.size`.
+789,"@@ -1601,6 +1601,7 @@ void nano::json_handler::bootstrap ()
+ {
+ 	std::string address_text = request.get<std::string> (""address"");
+ 	std::string port_text = request.get<std::string> (""port"");
++	const bool confirmed_frontiers = request.get<bool> (""confirmed_frontiers"", false);
+ 	boost::system::error_code address_ec;
+ 	auto address (boost::asio::ip::address_v6::from_string (address_text, address_ec));
+ 	if (!address_ec)",I think `bypass_frontier_confirmation` conveys the intention better (default false as well),Shouldn't this be `true` by default?
+790,"@@ -5,12 +5,9 @@ import (
+ 	""fmt""
+ 	""testing""
+ 
+-	""github.com/ipfs/go-cid""
+-	""github.com/ipfs/go-hamt-ipld""
+-	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/assert""
+-	""github.com/stretchr/testify/require""
+ 
++	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/chain""
+ 	""github.com/filecoin-project/go-filecoin/config""
+ 	""github.com/filecoin-project/go-filecoin/core""","This looks like it goes beyond the scope of removing `BlockHeight()`, in the future please do this in a separate commit at a minimum -- separate PR is fine too.",Why are we removing this test?
+791,"@@ -666,9 +666,10 @@ class AbstractAudio(QObject):
+     muted_changed = pyqtSignal(bool)
+     recently_audible_changed = pyqtSignal(bool)
+ 
+-    def __init__(self, parent=None):
++    def __init__(self, tab, parent=None):
+         super().__init__(parent)
+         self._widget = None
++        self._tab = tab
+ 
+     def set_muted(self, muted: bool):
+         """"""Set this tab as muted or not.""""""",You'll also need to adjust `FakeWebTabAudio` in `tests/helpers/stubs.py`.,I think this should be `self._tab = None`
+792,"@@ -1,19 +1,3 @@
+-/*
+-Copyright 2019 The Kubernetes Authors.
+-
+-Licensed under the Apache License, Version 2.0 (the ""License"");
+-you may not use this file except in compliance with the License.
+-You may obtain a copy of the License at
+-
+-    http://www.apache.org/licenses/LICENSE-2.0
+-
+-Unless required by applicable law or agreed to in writing, software
+-distributed under the License is distributed on an ""AS IS"" BASIS,
+-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-See the License for the specific language governing permissions and
+-limitations under the License.
+-*/
+-
+ package helpers
+ 
+ import (",@csrwng what should we do here? This one is from origin.,Why are we removing this file?
+793,"@@ -17,6 +17,7 @@
+ #include <LightGBM/utils/openmp_wrapper.h>
+ #include <LightGBM/utils/random.h>
+ #include <LightGBM/utils/threading.h>
++#include <LightGBM/utils/LocaleContext.h>
+ 
+ #include <string>
+ #include <cstdio>",Follow alphabetical order.,#include <LightGBM/utils/log.h
+794,"@@ -0,0 +1,16 @@
++// <copyright file=""IAutomaticTracer.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.ClrProfiler
++{
++    internal interface IAutomaticTracer : ICommonTracer
++    {
++        object GetDistributedTrace();
++
++        void SetDistributedTrace(object trace);
++
++        void Register(object manualTracer);
++    }
++}","As far as I can tell, these always get and set the context as an `IReadOnlyDictionary<string, string>`. Can we use that here instead of `object` and get rid of the `as IReadOnlyDictionary<string, string>`?",Why do we need this interface?
+795,"@@ -206,7 +206,7 @@ class CompletionItemDelegate(QStyledItemDelegate):
+             else:
+                 self._doc.setPlainText(self._opt.text)
+         else:
+-            self._doc.setHtml('<b>{}</b>'.format(html.escape(self._opt.text)))
++            self._doc.setHtml('{}'.format(html.escape(self._opt.text)))
+ 
+     def _draw_focus_rect(self):
+         """"""Draw the focus rectangle of an ItemViewItem.""""""","As you only have `{}` as the format string (without anything else in it), this is the same as doing `self._doc.setHtml(html.escape(self._opt.text))`",Why did you change this?
+796,"@@ -161,6 +161,8 @@ public class Constants {
+ 
+     // enable Quartz Scheduler if true.
+     public static final String ENABLE_QUARTZ= ""azkaban.server.schedule.enable_quartz"";
++
++    public static final String CUSTOM_CREDENTIAL_NAME = ""azkaban.security.credential"";
+   }
+ 
+   public static class FlowProperties {",Where would this be configured? In azkaban.properties?,Why do we need this?
+797,"@@ -2101,6 +2101,12 @@ Collection.prototype.findOneAndUpdate = function(filter, update, options, callba
+   if (typeof options === 'function') (callback = options), (options = {});
+   options = options || {};
+ 
++  var err = checkForAtomicOperators(update);
++  if (err) {
++    if (typeof callback === 'function') return callback(err);
++    return this.s.promiseLibrary.reject(err);
++  }
++
+   // Basic validation
+   if (filter == null || typeof filter !== 'object')
+     throw toError('filter parameter must be an object');",1. Use `const` instead of `var` here. 2. Move the check to after the `if (update == null || typeof update !== 'object')`.,Shouldn't this be `i
+798,"@@ -29,6 +29,13 @@ struct st_h2o_multithread_queue_t {
+ #if H2O_USE_LIBUV
+     uv_async_t async;
+ #else
++#if defined(__linux__) && LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
++/**
++ * The kernel overhead of an eventfd file descriptor is
++ * much lower than that of a pipe, and only one file descriptor is required
++ */
++#define H2O_ASYNC_NOTIFY_USING_EVENTFD
++#endif
+     struct {
+         int write;
+         h2o_socket_t *read;","Let's assume that on Linux `eventfd` is always available as a wrapper of the eventfd2 system call. It is supported since linux 2.6.27 + glibc 2.9, as well as from the ancient versions of bionic. In other words, it would be fair to argue that the pair would be available on practically all platforms that provide `pipe2`. Therefore switching from using `pipe2` to `eventfd` on linux unconditionally would not cause issues on our users.",Why do we need this?
+799,"@@ -61,6 +61,7 @@ public class DatabaseTransferConsumer implements IDataTransferConsumer<DatabaseC
+         IDataTransferNodePrimary, DBPReferentialIntegrityController {
+     private static final Log log = Log.getLog(DatabaseTransferConsumer.class);
+ 
++    private DBCStatistics statistics = new DBCStatistics();
+     private DatabaseConsumerSettings settings;
+     private DatabaseMappingContainer containerMapping;
+     private ColumnMapping[] columnMappings;",This field could be `final`.,Why do we need this?
+800,"@@ -62,8 +62,14 @@ module Beaker
+     def close
+       begin
+         @ssh.close if @ssh
+-      rescue
+-        @ssh.shutdown!
++      rescue => e
++        @logger.warn ""Attemped ssh.close.  Caught an error: #{e.message}  Attempting ssh.shutdown!...""
++        begin
++          @ssh.shutdown!
++        rescue => e
++          @logger.warn ""Attemped ssh.shutdown!.  Caught an error: #{e.message}. Giving up and destorying ssh.""
++          @ssh = nil
++        end
+       end
+       @ssh = nil
+     end",would be good to have a test for the case when `shutdown!` raises,I think this should be `@logger.error`
+801,"@@ -2747,6 +2747,10 @@ short HbaseInsert::codeGen(Generator *generator)
+ 
+   generator->initTdbFields(hbasescan_tdb);
+ 
++  if (CmpCommon::getDefault(HBASE_ASYNC_OPERATIONS) == DF_ON
++           && t == ComTdbHbaseAccess::INSERT_)
++     hbasescan_tdb->setAsyncOperations(TRUE);
++
+   if (getTableDesc()->getNATable()->isSeabaseTable())
+     {
+       hbasescan_tdb->setSQHbaseTable(TRUE);",Does upsert pass this check also?,Why is this needed?
+802,"@@ -43,6 +43,9 @@ func (r *helper) Patch(name types.NamespacedName, kind, apiVersion string, patch
+ 			WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Warn(""running the patch command failed"")
+ 		return err
+ 	}
++	r.logger.
++		WithField(""stdout"", ioStreams.Out.(*bytes.Buffer).String()).
++		WithField(""stderr"", ioStreams.ErrOut.(*bytes.Buffer).String()).Info(""patch command successful"")
+ 	return nil
+ }
+ ","Apologies reviewers, I did end up pushing another change. I was starting to request SRE-P help to get the apiserver configs from some clusters before and after when I realized I can just log the stdout from the patch command to see if anything was changed or not. Much simpler to verify if my work did or did not make changes to the config during the transition. Also got the spacing issue you mentioned @abhinavdahiya Thanks all.",I think this should be `Warn`
+803,"@@ -23,6 +23,7 @@ import (
+ const (
+ 	kbfsRepoDir         = "".kbfs_git""
+ 	kbfsConfigName      = ""kbfs_config""
++	kbfsConfigNameTemp  = ""._kbfs_config""
+ 	gitSuffixToIgnore   = "".git""
+ 	kbfsDeletedReposDir = "".kbfs_deleted_repos""
+ )",I'm not sure this naming is a good idea; that's the format for macOS xattr metadata files on unsupported filesystems.,I think this should be `.kbfs_config`
+804,"@@ -1,4 +1,4 @@
+-class AddIndexOnSectionIdAndTeacherIdToSectionTeachers < ActiveRecord::Migration
++class AddIndexOnSectionIdAndTeacherIdToSectionTeachers < ActiveRecord::Migration[4.2]
+   def up
+     change_table :section_teachers do |t|
+       t.remove_index :section_id",Metrics/LineLength: Line is too long. [85/80],Line is too long. [81/80]
+805,"@@ -19,12 +19,13 @@
+ 
+ package org.apache.iceberg.flink;
+ 
+-
+ import java.util.List;
+ import org.apache.flink.table.api.SqlParserException;
+ import org.apache.iceberg.AssertHelpers;
+ import org.apache.iceberg.FileFormat;
+ import org.apache.iceberg.catalog.Namespace;
++import org.apache.iceberg.events.Listeners;
++import org.apache.iceberg.events.ScanEvent;
+ import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+ import org.junit.After;
+ import org.junit.Assert;",Please remove these imports. The project's style is to use `Assert.assertEquals` and not import static methods in general. This also caused a lot of unnecessary changes.,nit: remove empty line
+806,"@@ -112,7 +112,10 @@ static int http_post(struct flb_out_http *ctx,
+                         payload_buf, payload_size,
+                         ctx->host, ctx->port,
+                         ctx->proxy, 0);
+-
++    if (!c) {
++        flb_plg_error(ctx->ins, ""[http_client] failed to create HTTP client"");
++        return FLB_RETRY;
++    }
+ 
+     if (c->proxy.host) {
+         flb_plg_debug(ctx->ins, ""[http_client] proxy host: %s port: %i"",","thanks. Note that returning at this point might leak memory from the allocations above, so the PR will need to take care of that too.",Shouldn't this be `return
+807,"@@ -492,10 +492,13 @@ class MainWindow(QWidget):
+     @pyqtSlot(bool)
+     def _on_fullscreen_requested(self, on):
+         if on:
+-            self.state_before_fullscreen = self.windowState()
+-            self.showFullScreen()
++            self.window_state_before_fullscreen = self.windowState()
++            self.config_state_before_fullscreen = config.val.content.desktop_fullscreen
++            if config.val.content.desktop_fullscreen:
++                self.showFullScreen()
+         elif self.isFullScreen():
+-            self.setWindowState(self.state_before_fullscreen)
++            if config.val.content.desktop_fullscreen or self.config_state_before_fullscreen:
++                self.setWindowState(self.window_state_before_fullscreen)
+         log.misc.debug('on: {}, state before fullscreen: {}'.format(
+             on, debug.qflags_key(Qt, self.state_before_fullscreen)))
+ ","If you really want to rename this, you'll also need to adjust the name in `__init__` and in other places it's used (`browser/commands.py`).",`config.val.content.deskt
+808,"@@ -53,6 +53,7 @@ public class MapLayerMetadata implements Serializable {
+     // ForeignKey to DataFile
+     //x@ManyToOne
+     // For now, make this unique:  Each DataFile may only have one map
++    //@OneToOne(cascade = {CascadeType.REMOVE, CascadeType.MERGE, CascadeType.PERSIST}) // TODO: Figure out why this doesn't work.
+     @JoinColumn(nullable=false, unique=true)
+     private DataFile dataFile;
+ ","As discussed at standup, I gave up on this. Calling `DeleteMapLayerMetadataCommand` felt cleaner anyway because there might be other cleanup that needs to happen. @scolapasta and @matthew-a-dunlap plan to discuss this.","// @OneToOne(cascade = {CascadeType.MERGE, CascadeType.PERSIST})"
+809,"@@ -84,5 +84,8 @@ func (a *action) Matches(act coretesting.Action) error {
+ 		return nil
+ 	}
+ 
++	fmt.Printf(""EXP:%+v\n"", objExp.GetObject())
++	fmt.Printf(""ACT:%+v\n"", objExp.GetObject())
++
+ 	return fmt.Errorf(""unexpected difference between actions: %s"", pretty.Diff(objExp.GetObject(), objAct.GetObject()))
+ }","Do we need these changes? If so, can you tidy up the messages? Looks like it might have been your testing/debugging changes  ",Please remove these debug statements.
+810,"@@ -63,6 +63,9 @@ const (
+ 
+ 	// SecretTypeEnv is to show secret type being ENVIRONMENT_VARIABLE
+ 	SecretTypeEnv = ""ENVIRONMENT_VARIABLE""
++
++	// TargetLogDriver is to show secret target being ""LOG_DRIVER"", the default will be ""CONTAINER""
++	SecretTargetLogDriver = ""LOG_DRIVER""
+ )
+ 
+ // DockerConfig represents additional metadata about a container to run. It's",where is the default being set?,I don't think we need this. The default is `CONTAINER`.
+811,"@@ -154,7 +154,7 @@ static void found_package_cb (const char *line,
+ 		vString *name = vStringNew ();
+ 		tagEntryInfo tag;
+ 
+-		vStringNCopyS (name, line + matches[1].start, matches[1].length);
++		vStringNCopyS (name, line + matches[2].start, matches[2].length);
+ 		initTagEntry (&tag, vStringValue (name), RpmSpecKinds + K_PACKAGE);
+ 		tag.extensionFields.scopeIndex = *(int *)userData;
+ 		makeTagEntry (&tag);",these changes should likely be in the next commit instead,Why did you change this?
+812,"@@ -26,9 +26,12 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ )
+ 
++type Foobar struct {
++	Foo string
++}
++
+ // TestFormat ensures the formatter and AddonTransform works as expected.
+ func TestFormat(t *testing.T) {
+-	// TODO: Add table formatter tests after implementing table formatter
+ 	for _, tc := range []struct {
+ 		name            string
+ 		singleton       bool","Since you have defined this struct, I would suggest to replace all exist literal structs by this.",Why do we need this?
+813,"@@ -168,6 +168,7 @@ public class K9 extends Application {
+     private static boolean mAnimations = true;
+ 
+     private static boolean mConfirmDelete = false;
++    private static boolean mConfirmMenuDiscard = true;
+     private static boolean mConfirmDeleteStarred = false;
+     private static boolean mConfirmSpam = false;
+     private static boolean mConfirmDeleteFromNotification = true;",The field name doesn't really capture what this option does. I think `mConfirmDiscardMessage` would be a better choice.,Should this be false
+814,"@@ -192,6 +192,15 @@ class FileProvider extends BaseProvider
+             return;
+         }
+ 
++        // is_file will cause a fatal error if binary content is not a string
++        if (!is_string($media->getBinaryContent())) {
++            throw new \RuntimeException(sprintf(
++                'Invalid data provided for binary content, choose among: string, %s, %s',
++                'Symfony\Component\HttpFoundation\File\File',
++                'Symfony\Component\HttpFoundation\Request'
++            ));
++        }
++
+         // if the binary content is a filename => convert to a valid File
+         if (!is_file($media->getBinaryContent())) {
+             throw new \RuntimeException('The file does not exist : '.$media->getBinaryContent());",what if `$media->getBinaryContent() == Symfony\Component\HttpFoundation\File\File` does `is_string()` return `true`? ping @greg0ire,Should be `!is_strin
+815,"@@ -1065,11 +1065,9 @@ void GenStruct(StructDef &struct_def, std::string *code_ptr) {
+       }
+     }
+   // generate object accessors if is nested_flatbuffer
++  if (field.nested_flatbuffer) {
+   auto nested = field.attributes.Lookup(""nested_flatbuffer"");
+-  if (nested) {
+-    auto nested_qualified_name =
+-      parser_.namespaces_.back()->GetFullyQualifiedName(nested->constant);
+-    auto nested_type = parser_.structs_.Lookup(nested_qualified_name);
++	auto nested_type = nested->type.struct_def;
+     auto nested_type_name = WrapInNameSpace(*nested_type);
+     auto nestedMethodName = MakeCamel(field.name, lang_.first_camel_upper)
+       + ""As"" + nested_type_name;",maybe rather than `bool` make this field a `StructDef *` ?,Nit: `nested_type` -
+816,"@@ -209,6 +209,13 @@ func (fbm *folderBlockManager) enqueueBlocksToDelete(toDelete blocksToDelete) {
+ 	fbm.blocksToDeleteChan <- toDelete
+ }
+ 
++func (fbm *folderBlockManager) enqueueBlocksToDeleteAfterShortDelay(
++	toDelete blocksToDelete) {
++	fbm.blocksToDeleteWaitGroup.Add(1)
++	time.AfterFunc(10*time.Millisecond,
++		func() { fbm.blocksToDeleteChan <- toDelete })
++}
++
+ // enqueueBlocksToDeleteNoWait enqueues blocks to be deleted just like
+ // enqueueBlocksToDelete, except that when fbm.blocksToDeleteChan is full, it
+ // doesn't block, but instead spawns a goroutine to handle the sending.",Shall we maybe put this in a `const` like `backgroundTaskTimeout`?,I don't think you need to add the wait group here.
+817,"@@ -272,6 +272,11 @@ namespace Datadog.Trace.TestHelpers
+                     ctx.Response.OutputStream.Write(buffer, 0, buffer.Length);
+                     ctx.Response.Close();
+                 }
++                catch (InvalidOperationException)
++                {
++                    // this can occur when setting Response.ContentLength64, with the framework claiming that the response has already been submitted
++                    // for now ignore, and we'll see if this introduces downstream issues
++                }
+                 catch (HttpListenerException)
+                 {
+                     // listener was stopped,",CI is complaining about this.,Why do we need this?
+818,"@@ -31,6 +31,14 @@ import java.util.Date;
+  */
+ public class DefaultHistoryRemovalTimeProvider implements HistoryRemovalTimeProvider {
+ 
++  public static Date determineRemovalTime(Date initTime, Integer timeToLive) {
++    Calendar removalTime = Calendar.getInstance();
++    removalTime.setTime(initTime);
++    removalTime.add(Calendar.DATE, timeToLive);
++    
++    return removalTime.getTime();
++  }
++
+   public Date calculateRemovalTime(HistoricProcessInstanceEventEntity historicRootProcessInstance, ProcessDefinition processDefinition) {
+ 
+     Integer historyTimeToLive = processDefinition.getHistoryTimeToLive();",Let's only change a file if it is really necessary. Such a change does not bring much value and makes it harder to find the original commit in which the method was introduced.,Why do we need this method?
+819,"@@ -210,6 +210,14 @@ class ImageExtension extends Twig_Extension
+         $htmlAttributes = $attributes;
+         unset($htmlAttributes['type'], $htmlAttributes['size']);
+ 
++        $useLazyLoading = array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;
++        $isAttributeClassExistsAndNotEmpty = array_key_exists('class', $attributes) && $attributes['class'] !== '';
++        $htmlAttributes['class'] = sprintf(
++            '%s%s',
++            $useLazyLoading ? 'lazy' : '',
++            $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : ''
++        );
++
+         return $this->templating->render('@ShopsysFramework/Common/image.html.twig', [
+             'attr' => $htmlAttributes,
+             'additionalImagesData' => $additionalImagesData,","I would prefer to set up space between classes in format pattern, `%s %s` and then use `trim()` to remove unnecessary whitespaces. This will also solve stripping whitespaces from the beginning and end of a string `$attributes['class']`","`array_key_exists('class', $attributes)` is enough"
+820,"@@ -22,9 +22,13 @@ AdminJobExecutor::AdminJobExecutor(Sentence *sentence,
+ 
+ void AdminJobExecutor::execute() {
+     LOG(INFO) << __func__ << "" enter"";
+-    auto opEnum = toAdminJobOp(sentence_->getType());
++    auto optOpEnum = toAdminJobOp(sentence_->getType());
++    if (!optOpEnum) {
++        LOG(ERROR) << ""unknown setence type["" << sentence_->getType() <<""]"";
++    }
+     auto paras = sentence_->getParas();
+ 
++    auto opEnum = *optOpEnum;
+     if (opNeedsSpace(opEnum)) {
+         auto status = checkIfGraphSpaceChosen();
+         if (!status.ok()) {",when Op is illegal should return here?,nit: `optOpEnum` -> `opType`
+821,"@@ -447,8 +447,6 @@ public class FlowRunnerManager implements EventListener,
+             } catch (IOException e) {
+               logger.error(e);
+             }
+-
+-            installedVersions.remove(versionKey);
+           }
+         }
+       }",don't we need to remove the project version from installedVersions?,Why was this removed?
+822,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+ 
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+ 
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.,Why do we need this?
+823,"@@ -51,7 +51,10 @@ func (s *DaemonServer) FlushIPSets(ctx context.Context, req *pb.IPSetsRequest) (
+ 		ipset := ipset
+ 		s.IPSetLocker.Lock(ipset.Name)
+ 		err := flushIPSet(ctx, req.EnterNS, pid, ipset)
+-		s.IPSetLocker.Unlock(ipset.Name)
++		if err != nil {
++			return nil, err
++		}
++		err = s.IPSetLocker.Unlock(ipset.Name)
+ 		if err != nil {
+ 			return nil, err
+ 		}",This is intended. Pls revert this.,Why is this necessary?
+824,"@@ -68,7 +68,7 @@ interface RedBlackTree<T> extends Iterable<T> {
+ 
+     static <T extends Comparable<? super T>> RedBlackTree<T> ofAll(Iterable<? extends T> values) {
+         Objects.requireNonNull(values, ""values is null"");
+-        return ofAll((Comparator<? super T> & Serializable) T::compareTo, values);
++        return ofAll(Comparators.naturalComparator(), values);
+     }
+ 
+     @SuppressWarnings(""unchecked"")","Something wrong with cast to `(Comparator<> & Serializable)`, need to be investigated",Why is this change necessary?
+825,"@@ -217,15 +217,10 @@ export default class App extends Component {
+ 
+   // eslint-disable-next-line no-unused-vars
+   handleClickSearch = (_, { suggestionValue, method }) => {
+-    const { packages } = this.state;
+     switch(method) {
+       case 'click':
+-        window.location.href = getDetailPageURL(suggestionValue);
+-      break;
+       case 'enter':
+-        this.setState({
+-          filteredPackages: packages.filter(pkg => pkg.label.match(suggestionValue))
+-        });
++        window.location.href = getDetailPageURL(suggestionValue);
+       break;
+     }
+   }","I think we need this. Not sure, I'll test.",Why was this removed?
+826,"@@ -83,7 +83,6 @@ module Beaker
+         host['user'] = 'google_compute'
+ 
+         disable_se_linux(host, @options)
+-        disable_iptables(host, @options)
+         copy_ssh_to_root(host, @options)
+         enable_root_login(host, @options)
+         host['user'] = default_user","I'm going to need to check if google compute requires these steps in this order, or if you can disable iptables after the fact.",Why was this removed?
+827,"@@ -2,6 +2,7 @@
+ // sources:
+ // build/static/charts/traefik-10.3.001.tgz
+ // build/static/charts/traefik-crd-10.3.001.tgz
++//go:build !no_stage
+ // +build !no_stage
+ 
+ package static",Did go change their tags with the new version?,Why is this needed?
+828,"@@ -330,11 +330,15 @@ func (s *Server) newEndpointsServer(ctx context.Context, catalog catalog.Catalog
+ }
+ 
+ func (s *Server) newBundleManager(cat catalog.Catalog, metrics telemetry.Metrics) *bundle_client.Manager {
++	log := s.config.Log.WithField(telemetry.SubsystemName, ""bundle_client"")
+ 	return bundle_client.NewManager(bundle_client.ManagerConfig{
+-		Log:       s.config.Log.WithField(telemetry.SubsystemName, ""bundle_client""),
++		Log:       log,
+ 		Metrics:   metrics,
+ 		DataStore: cat.GetDataStore(),
+-		Source:    bundle_client.TrustDomainConfigMap(s.config.Federation.FederatesWith),
++		Source: bundle_client.MergeTrustDomainConfigSources(
++			bundle_client.TrustDomainConfigMap(s.config.Federation.FederatesWith),
++			bundle_client.DataStoreTrustDomainConfigSource(log, cat.GetDataStore()),
++		),
+ 	})
+ }
+ ","I don't recall what we decided here in terms of which source would get priority. As written, the static configuration will overwrite datastore results.",Why do we need to merge trust domains here?
+829,"@@ -192,7 +192,7 @@ func replaceSequenceLabel(state *core.BuildState, target *core.BuildTarget, labe
+ }
+ 
+ func checkAndReplaceSequence(state *core.BuildState, target, dep *core.BuildTarget, in string, runnable, multiple, dir, outPrefix, hash, test, allOutputs, tool bool) string {
+-	if allOutputs && !multiple && len(dep.Outputs()) != 1 {
++	if allOutputs && !multiple && len(dep.Outputs()) > 1 {
+ 		// Label must have only one output.
+ 		panic(fmt.Sprintf(""Rule %s can't use %s; %s has multiple outputs."", target.Label, in, dep.Label))
+ 	} else if runnable && !dep.IsBinary {",I think it should still panic for when there are no outputs; might be nice to special-case that though so the message is more explicit.,Why this change?
+830,"@@ -110,12 +110,14 @@ public class SolrMetricManager {
+ 
+   public static final int DEFAULT_CLOUD_REPORTER_PERIOD = 60;
+ 
+-  private MetricRegistry.MetricSupplier<Counter> counterSupplier;
+-  private MetricRegistry.MetricSupplier<Meter> meterSupplier;
+-  private MetricRegistry.MetricSupplier<Timer> timerSupplier;
+-  private MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
++  private final MetricsConfig metricsConfig;
++  private final MetricRegistry.MetricSupplier<Counter> counterSupplier;
++  private final MetricRegistry.MetricSupplier<Meter> meterSupplier;
++  private final MetricRegistry.MetricSupplier<Timer> timerSupplier;
++  private final MetricRegistry.MetricSupplier<Histogram> histogramSupplier;
+ 
+   public SolrMetricManager() {
++    metricsConfig = new MetricsConfig.MetricsConfigBuilder().build();
+     counterSupplier = MetricSuppliers.counterSupplier(null, null);
+     meterSupplier = MetricSuppliers.meterSupplier(null, null);
+     timerSupplier = MetricSuppliers.timerSupplier(null, null);",*NULL_DEREFERENCE:* object `null` is dereferenced by call to `meterSupplier(...)` at line 122.,Why is this needed?
+831,"@@ -60,12 +60,7 @@ function _command(server, ns, cmd, options, callback) {
+     finalCmd.$clusterTime = clusterTime;
+   }
+ 
+-  if (
+-    isSharded(server) &&
+-    !shouldUseOpMsg &&
+-    readPreference &&
+-    readPreference.preference !== 'primary'
+-  ) {
++  if (isSharded(server) && !shouldUseOpMsg && readPreference && readPreference.mode !== 'primary') {
+     finalCmd = {
+       $query: finalCmd,
+       $readPreference: readPreference.toJSON()",switch over to .mode,`readPreference && readPreference.mode !== 
+832,"@@ -125,7 +125,7 @@ describe('HiddenColumns', () => {
+       });
+ 
+       it('should return correct visual indexes when columns sequence is non-contiguous ' +
+-         '(force desync between physical and visual indexes)', () => {
++        '(force desync between physical and visual indexes)', () => {
+         const hot = handsontable({
+           data: Handsontable.helper.createSpreadsheetData(1, 10),
+           colHeaders: true,",I guess your IDE did some auto-fixing here  ,Why did you change this?
+833,"@@ -32,6 +32,7 @@ import org.apache.lucene.search.BooleanClause;
+ import org.apache.lucene.search.BooleanQuery;
+ import org.apache.lucene.search.DisjunctionMaxQuery;
+ import org.apache.lucene.search.FuzzyQuery;
++import org.apache.lucene.search.PhraseQuery;
+ import org.apache.lucene.search.TermQuery;
+ 
+ public class TestRamUsageEstimator extends LuceneTestCase {",This is an unused import failing recommit still.,import org.junit.Test;
+834,"@@ -133,8 +133,12 @@ module Beaker
+               #move to the host
+               logger.debug ""Using scp to transfer #{source_path} to #{target_path}""
+               scp_to host, source_path, target_module_dir, {:ignore => ignore_list}
++
+               #rename to the selected module name, if not correct
+               cur_path = File.join(target_module_dir, source_name)
++              if host.is_powershell? #make sure our slashes are correct
++                cur_path = cur_path.gsub(/\//,'\\')
++              end
+               host.mv cur_path, target_path unless cur_path == target_path
+             when 'rsync'
+               logger.debug ""Using rsync to transfer #{source_path} to #{target_path}""","I'm concerned that we're conflating multiple things here. There are 2 things that Beaker should really care about: - Network transport - i.e. `ssh` vs `winrm` - Interpreter - i.e. `bash`, `cmd`, `powershell`, etc The problem is that @cowofevil is running Bitvise SSH, and he assumed we should be setting `is_cygwin: false` in node definitions. But that doesn't really accurately convey what we care about, and since Beaker doesn't appear to track network transport apart from interpreter, we end up in a strange state. `is_cygwin: false` appears to end up setting `is_powershell?` to `true`, which IMHO is not accurate or appropriate. Bitvise templates use `ssh` (like Cygwin), but the interpreter used is `cmd`, not `powershell`.",Why is this needed?
+835,"@@ -52,6 +52,6 @@
+ <%= tinymce :content_css => asset_path('application.css') %>
+ 
+ <!-- alert for the default template-->
+-<div id=""edit_guidance_alert_dialog"" class=""modal"" style=""display:none"">
++<div id=""edit_guidance_alert_dialog"" class=""modal"" role=""dialog"" aria-label=""<%=_(""Missing Fields Alert"")%>"" style=""display:none"">
+   <ul id=""missing_fields_edit_guidance""></ul>
+ </div>",I think this is ok for now. This ties into the larger issue of the site not having a consistent method for relaying form input errors. Please make sure the focus gets set on the close button when the dialog opens.,I don't think you need t
+836,"@@ -44,9 +44,9 @@ const COLUMN_SIZE_MAP_NAME = 'autoColumnSize';
+  * autoColumnSize: {syncLimit: '40%'},
+  * ```
+  *
+- * The plugin uses {@link GhostTable} and {@link SamplesGenerator} for calculations.
+- * First, {@link SamplesGenerator} prepares samples of data with its coordinates.
+- * Next {@link GhostTable} uses coordinates to get cells' renderers and append all to the DOM through DocumentFragment.
++ * The plugin uses GhostTable and SamplesGenerator for calculations.
++ * First, SamplesGenerator prepares samples of data with its coordinates.
++ * Next GhostTable uses coordinates to get cells' renderers and append all to the DOM through DocumentFragment.
+  *
+  * Sampling accepts additional options:
+  * - *samplingRatio* - Defines how many samples for the same length will be used to calculate. Default is `3`.",Should these link be removed?,`{@link GhostTable} and SamplesGenerator`
+837,"@@ -217,11 +217,12 @@ class TabbedBrowser(tabwidget.TabWidget):
+         for tab in self.widgets():
+             self._remove_tab(tab)
+ 
+-    def close_tab(self, tab):
++    def close_tab(self, tab, add_undo=True):
+         """"""Close a tab.
+ 
+         Args:
+             tab: The QWebView to be closed.
++            add_undo: Whether the tab close can be undone.
+         """"""
+         last_close = config.get('tabs', 'last-close')
+         count = self.count()",Please make this a keyword-only argument by adding a `*` argument before `add_undo`.,Why do we need this?
+838,"@@ -201,6 +201,13 @@ var eventStreamWriterTestTmpl = template.Must(
+ 			{{- end }}
+ 		}
+ 
++		var marshalers request.HandlerList
++		marshalers.PushBackNamed({{ $.API.ProtocolPackage }}.BuildHandler)
++		payloadMarshaler := protocol.HandlerPayloadMarshal{
++			Marshalers: marshalers,
++		}
++		_ = payloadMarshaler
++
+ 		eventMsgs := []eventstream.Message{
+ 			{{- range $idx, $event := $.InputStream.Events }}
+ 				{{- template ""set event message"" Map ""idx"" $idx ""parentShape"" $event.Shape ""eventName"" $event.Name }}",didn't quite follow what this code block is doing.,Why do we need this?
+839,"@@ -1071,6 +1071,12 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+         }
+ 
+         function onWindowKeyDown(e) {
++            // FIXME: Conflicts with keyboard navigation
++            // FIXME: Then the keyboard is completely ignored. Need another solution.
++            if (layoutManager.tv) {
++                return void showOsd();
++            }
++
+             if (!currentVisibleMenu && 32 === e.keyCode) {
+                 playbackManager.playPause(currentPlayer);
+                 return void showOsd();","this doesn't sound pretty... I would rather we have a proper navigation for all modes - AFAIK TV remote navigation is very similar to normal keyboard, but maybe it just uses another key codes - those should be extracted in a single file and defined there depending on context then",Why is this needed?
+840,"@@ -205,4 +205,17 @@ function patchDOMElement(dom, newVNode, internal, globalContext, commitQueue) {
+ 			dom.firstChild
+ 		);
+ 	}
++
++	if ('value' in newProps && dom._isControlled) {
++		dom._prevValue = newProps.value;
++
++		if (newProps.value !== dom.value) {
++			setProperty(dom, 'value', i, oldProps.value, 0);
++		}
++	} else if ('checked' in newProps && dom._isControlled) {
++		dom._prevValue = newProps.checked;
++		if (newProps.checked !== dom.checked) {
++			setProperty(dom, 'checked', i, oldProps.checked, 0);
++		}
++	}
+ }","After diffing the children we check whether the value got out of sync, if it did we update it. We also update the `_prevValue` to prepare for the next event hitting our controlled component",Why do we need to check `_isControlled` here?
+841,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
++// Package node provides the glue-code needed in order
++// to start a Bee node.
+ package node
+ 
+ import (","It provides a type called Node which is a fully functional bee client. This package is where the dependencies are injected. It is not just a glue-code, it is concept of node.",// Package node provides the glue-code needed
+842,"@@ -330,6 +330,8 @@ class ConfigManager(QObject):
+     CHANGED_OPTIONS = {
+         ('content', 'cookies-accept'):
+             _get_value_transformer('default', 'no-3rdparty'),
++        ('storage', 'download-directory'):
++            _get_value_transformer('', '%'),
+     }
+ 
+     changed = pyqtSignal(str, str)","I think this will change `''` to `'%'` unconditionally, i.e. there'll be no way to set `''` anymore. This should really only be used for values which make no sense anymore.",I think this should be `'%s'`
+843,"@@ -88,6 +88,13 @@ public interface Table {
+    */
+   Map<Integer, SortOrder> sortOrders();
+ 
++  /**
++   * Return the {@link RowKey row key} for this table.
++   *
++   * @return this table's row key.
++   */
++  RowKey rowKey();
++
+   /**
+    * Return a map of string properties for this table.
+    *",Nit: this table's row key map -> this table's row keys map,nit: `this table's row key`
+844,"@@ -87,7 +87,7 @@ void proj_assign_context( PJ* pj, PJ_CONTEXT *ctx )
+ pj_ctx pj_ctx::createDefault()
+ {
+     pj_ctx ctx;
+-    ctx.debug_level = PJ_LOG_ERROR;
++    ctx.debug_level = PJ_LOG_NONE;
+     ctx.logger = pj_stderr_logger;
+     NS_PROJ::FileManager::fillDefaultNetworkInterface(&ctx);
+ ",this change should be reverted,Why is this change needed?
+845,"@@ -26,8 +26,10 @@ __copyright__ = ""Copyright 2014-2018 Florian Bruhin (The Compiler)""
+ __license__ = ""GPL""
+ __maintainer__ = __author__
+ __email__ = ""mail@qutebrowser.org""
+-__version_info__ = (1, 5, 0)
+-__version__ = '.'.join(str(e) for e in __version_info__)
++__version__ = ""1.5.0""
++__version_info__ = [int(part) for part in __version__.split('.')]
+ __description__ = ""A keyboard-driven, vim-like browser based on PyQt5.""
+ 
+ basedir = os.path.dirname(os.path.realpath(__file__))
++appdata_path = os.path.join(os.path.dirname(basedir), ""misc"",
++                            ""qutebrowser.appdata.xml"")","I'm a bit confused about the `os.path.dirname(basedir)` here - is this just to get to the parent directory? Either way, I think I'd prefer just having this in `update_version.py` as it's not needed in qutebrowser itself.",This should be `os.path.jo
+846,"@@ -750,8 +750,8 @@ func TestConfigCheck(t *testing.T) {
+                 http_port = 8222
+ 				`,
+ 			err:       errors.New(`Duplicate user ""foo"" detected`),
+-			errorLine: 6,
+-			errorPos:  21,
++			errorLine: 5,
++			errorPos:  19,
+ 		},
+ 		{
+ 			name: ""when accounts block imports are not a list"",",Revert this change and see below why...,Why did this change?
+847,"@@ -1,6 +1,6 @@
+ _base_ = [
+     '../_base_/models/cascade_mask_rcnn_r50_fpn.py',
+-    '../_base_/datasets/coco_instance.py',
++    '../_base_/datasets/lvis_v1_instance.py',
+     '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py'
+ ]
+ ",Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.,Why this change?
+848,"@@ -70,7 +70,7 @@ public class NodeOptions {
+       Capabilities caps = info.getCanonicalCapabilities();
+       builders.stream()
+           .filter(builder -> builder.score(caps) > 0)
+-          .peek(builder -> LOG.info(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
++          .peek(builder -> LOG.finest(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
+           .forEach(builder -> {
+             DriverService.Builder freePortBuilder = builder.usingAnyFreePort();
+ ",This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave.,"I think this should be `LOG.finest(""Adding {} times"", info.getMaximumSimultaneousSessions());`"
+849,"@@ -52,6 +52,9 @@ type Alert interface {
+ 	// GetKvdbInstance.
+ 	GetKvdbInstance() kvdb.Kvdb
+ 
++	// RaiseSingleton raises a singleton alert.
++	RaiseSingleton(alert *api.Alert) error
++
+ 	// Raise raises an Alert.
+ 	Raise(alert *api.Alert) error
+ ",This doesn't make sense to me. What does RaiseSingleton mean? To me it sounds like a single object is being.. raised? Not sure.,Why do we need this?
+850,"@@ -45,6 +45,7 @@ public class JavaProcessJobTest {
+   private JavaProcessJob job = null;
+   private Props props = null;
+   private Logger log = Logger.getLogger(JavaProcessJob.class);
++  private AllJobExecutorTests jobExecutorTests = null;
+ 
+   private static String classPaths;
+ ","What's the benefit of having jobExecutorTests as a member variable? What do you think about making the method static? Afterall, it is a stateless method.",This should be `final`.
+851,"@@ -12,6 +12,7 @@ const mdUsageStr = `Usage:
+ 
+ The possible subcommands are:
+   dump		Dump metadata objects
++  check		Check metadata objects and their associated blocks for errors
+ 
+ `
+ ","This looks like it's only downloading things, not really checking their true validity. Especially for the MD object. Should we call `BareRootMetadata.IsValidAndSigned()` in `mdGet`?",`Check metadata blocks for errors`
+852,"@@ -136,6 +136,17 @@ void image_data_reader::load() {
+   select_subset_of_data();
+ }
+ 
++void image_data_reader::setup() {
++  generic_data_reader::setup();
++
++  using InputBuf_T = lbann::cv_image_type<uint8_t>;
++  auto cvMat = cv::Mat(1, get_linearized_data_size(), InputBuf_T::T(1));
++  m_thread_cv_buffer.resize(omp_get_max_threads());
++  for(int tid = 0; tid < omp_get_max_threads(); ++tid) {
++    m_thread_cv_buffer[tid] = cvMat.clone();
++  }
++}
++
+ std::vector<image_data_reader::sample_t> image_data_reader::get_image_list_of_current_mb() const {
+   std::vector<sample_t> ret;
+   ret.reserve(m_mini_batch_size);","Nikoli, I believe that this addresses your concern. One question for you or Jae-Seung is if any allocation from the clone is properly cleaned up when the vector is destroyed. I believe that it should.",`std::vector<std::vector<sample_t>> ret;`
+853,"@@ -48,6 +48,8 @@ const (
+ 	KindLambdaApp Kind = ""LambdaApp""
+ 	// KindCloudRunApp represents deployment configuration for a CloudRun application.
+ 	KindCloudRunApp Kind = ""CloudRunApp""
++	// KindEcsApp represents deployment configuration for an AWS ECS.
++	KindEcsApp Kind = ""EcsApp""
+ 	// KindSealedSecret represents a sealed secret.
+ 	KindSealedSecret Kind = ""SealedSecret""
+ )",should be `ECSApp`  ,Why is this a<msg>I don't think it should
+854,"@@ -539,7 +539,13 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            rect = self.size.copy()
++            rect.update(self.location)
++            return rect
++
+ 
+     @property
+     def screenshot_as_base64(self):",flake8 is going to fail on this having 2 lines,Why do we need this?
+855,"@@ -15,7 +15,6 @@ package podfailure
+ 
+ import (
+ 	""context""
+-	""errors""
+ 	""fmt""
+ 	""time""
+ ",should we make a dir named controllers/scheduler/podchaos,Why did you remove this?
+856,"@@ -50,9 +50,9 @@ import (
+ )
+ 
+ const (
+-	//KeyNode represents the key values used for specifying the Node Affinity
++	//KeyNodeHostname represents the key values used for specifying the Node Affinity
+ 	// based on the hostname
+-	KeyNode = ""kubernetes.io/hostname""
++	KeyNodeHostname = ""kubernetes.io/hostname""
+ )
+ 
+ // NewProvisioner will create a new Provisioner object and initialize",there seems to be one KeyNode in kubernetes.go of PV.. would it make sense to use it?,I think this should be `KeyNodeHostname`
+857,"@@ -22,12 +22,12 @@ import (
+ 	""fmt""
+ 	""time""
+ 
++	""github.com/mysteriumnetwork/node/cmd/commands""
++
+ 	""github.com/mysteriumnetwork/node/cmd/commands/cli/clio""
+ 	""github.com/mysteriumnetwork/node/config""
+-	""github.com/mysteriumnetwork/node/config/urfavecli/clicontext""
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/connection/connectionstate""
+-	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/mysteriumnetwork/node/datasize""
+ 	""github.com/mysteriumnetwork/node/identity/registry""
+ 	""github.com/mysteriumnetwork/node/metadata""",Im gonna be a little annoying here but did you configure your linter correctly? This empty line should not be here. Maybe go to settings and check if `goimports` is enabled?,nit: remove empty line
+858,"@@ -122,6 +122,7 @@ public class EmojiPlugin extends Plugin
+ 			case FRIENDSCHAT:
+ 			case PRIVATECHAT:
+ 			case PRIVATECHATOUT:
++			case MODPRIVATECHAT:
+ 				break;
+ 			default:
+ 				return;",Don't think this belongs in this pr,Why is this needed?
+859,"@@ -206,6 +206,16 @@ func (d *Dispatcher) Inbounds() Inbounds {
+ 	return inbounds
+ }
+ 
++// Outbounds returns a copy of the map of outbounds for this RPC object.
++// The outbounds are already wrapped with middleware
++func (d *Dispatcher) Outbounds() Outbounds {
++	outbounds := make(Outbounds, len(d.outbounds))
++	for k, v := range d.outbounds {
++		outbounds[k] = v
++	}
++	return outbounds
++}
++
+ // ClientConfig provides the configuration needed to talk to the given
+ // service through an outboundKey. This configuration may be directly
+ // passed into encoding-specific RPC clients.","We can assert on the existence of Outbounds through ClientConfig calls right? Since this is only for tests, do we need this function?",nit: `func (d *Dispatcher) Outbounds() O
+860,"@@ -37,14 +37,13 @@ namespace MvvmCross.Core.ViewModels
+ 
+     public interface IMvxViewModel<TParameter> : IMvxViewModel where TParameter : class
+     {
+-        Task Initialize(TParameter parameter);
++        void Declare(TParameter parameter);
+     }
+ 
+     //TODO: Can we keep the IMvxViewModel syntax here? Compiler complains
+     public interface IMvxViewModelResult<TResult> : IMvxViewModel where TResult : class
+     {
+-        void SetClose(TaskCompletionSource<TResult> tcs, CancellationToken cancellationToken);
+-        Task<bool> Close(TResult result);
++        TaskCompletionSource<object> CloseCompletionSource { get; set; }
+     }
+ 
+     public interface IMvxViewModel<TParameter, TResult> : IMvxViewModel<TParameter>, IMvxViewModelResult<TResult> where TParameter : class where TResult : class",@martijn00 so this PR introduces a new ViewModel lifecyle method? It isn't in the PR description/any new docs  ,Why do we need this property? Can't we just use `TaskCompletionSource`?
+861,"@@ -89,6 +89,13 @@ class SingleStageDetector(BaseDetector):
+         Returns:
+             dict[str, Tensor]: A dictionary of loss components.
+         """"""
++        # NOTE the batched image size information may be useful, e.g.
++        # in DETR, this is needed for the construction of masks, which is
++        # then used for the transformer_head.
++        input_img_shape = tuple(img.size()[-2:])
++        for img_meta in img_metas:
++            img_meta['input_img_shape'] = input_img_shape
++
+         x = self.extract_feat(img)
+         losses = self.bbox_head.forward_train(x, img_metas, gt_bboxes,
+                                               gt_labels, gt_bboxes_ignore)",Are these modification duplicate? Or should we move it into base detector.,Why do we need this?
+862,"@@ -35,7 +35,7 @@ public class DirectAcyclicGraphSeed {
+             }
+           });
+ 
+-  public static byte[] dagSeed(final long block) {
++  private static byte[] dagSeed(final long block) {
+     final byte[] seed = new byte[32];
+     if (Long.compareUnsigned(block, EPOCH_LENGTH) >= 0) {
+       final MessageDigest keccak256 = KECCAK_256.get();",Since this is private and single use it should be un-wrapped inside of the two-arg dagSeed method.,Why did you change this to private?
+863,"@@ -160,11 +160,10 @@ abstract class Tx_Solr_PluginBase_PluginBase extends tslib_pibase {
+ 	 * @param array $configuration configuration array as provided by the TYPO3 core
+ 	 */
+ 	protected function initialize($configuration) {
+-		$this->conf = $configuration;
+-
+-		$this->conf = t3lib_div::array_merge_recursive_overrule(
+-			$GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'],
+-			$this->conf
++		$this->conf = $GLOBALS['TSFE']->tmpl->setup['plugin.']['tx_solr.'];
++		\TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule(
++			$this->conf,
++			$configuration
+ 		);
+ 
+ 		$this->pi_setPiVarDefaults();",why the order change? Also for the next chunk. (I understand the result will be the same though),Can we use the full path here?
+864,"@@ -42,7 +42,9 @@ type FuncDef struct {
+ 	// Not part of the grammar. Used to indicate internal targets that can only
+ 	// be called using keyword arguments.
+ 	KeywordsOnly bool
+-	IsPrivate    bool
++	// allowed return types of the FuncDef
++	Returns   []string
++	IsPrivate bool
+ }
+ 
+ // A ForStatement implements the 'for' statement.",I wonder if this should just be a single `string`? We don't have any cases where we return different types and it would make the parser simpler to just read a single identifier.,Why is this needed?
+865,"@@ -125,7 +125,7 @@ abstract class BaseDataReader<T> implements Closeable {
+ 
+   protected InputFile getInputFile(FileScanTask task) {
+     Preconditions.checkArgument(!task.isDataTask(), ""Invalid task type"");
+-    return inputFiles.get(task.file().path().toString());
++    return getInputFile(task.file().path().toString());
+   }
+ 
+   protected InputFile getInputFile(String location) {",I don't think this needs to change. Can you go back to the previous implementation?,`getInputFile(task.
+866,"@@ -32,7 +32,7 @@ from jinja2 import PackageLoader
+ 
+ import molecule.utilities as utilities
+ import molecule.validators as validators
+-from provisioners import Ansible
++from molecule.core import Molecule
+ 
+ 
+ class Commands(object):","Bump it 2 lines higher, 'c' > 'u'.",Why did you change 
+867,"@@ -0,0 +1,11 @@
++/**
++ * Copyright @ 2018-present. All rights reserved by Vesoft Inc.
++ * Author: Fenglin Hou <dutor@vesoft-inc.com>
++ */
++#include ""parser/AstTypes.h""
++
++namespace vesoft {
++
++
++
++}",Please do not add author here,Why is this file ne
+868,"@@ -4,6 +4,7 @@ import (
+ 	""database/sql""
+ 	""encoding/hex""
+ 
++	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/db/rds""","Similarly, we should be able to persist action uniformly","""github.com/pkg/errors"""
+869,"@@ -1,3 +1,8 @@
++#This prevents caching via the browser
++#in testing mode
++module ActionController::ConditionalGet
++    def expires_in(*args) ; end
++end
+ Workshops::Application.configure do
+   # Settings specified here will take precedence over those in config/application.rb
+ ","I think i'd prefer this override to be in the test helper instead, if that's possible?",Extra empty line detect
+870,"@@ -134,6 +134,13 @@ func Untar(source string, dest string, extractionDir string) error {
+ 		case tar.TypeReg:
+ 			fallthrough
+ 		case tar.TypeRegA:
++			// Always ensure the directory is created before trying to move the file.
++			fullPathDir := filepath.Dir(fullPath)
++			err = os.MkdirAll(fullPathDir, 0755)
++			if err != nil {
++				return err
++			}
++
+ 			// For a regular file, create and copy the file.
+ 			exFile, err := os.Create(fullPath)
+ 			if err != nil {",This would be better with context added via wrapping or fmt.errorf(),Why do we need this?
+871,"@@ -0,0 +1,19 @@
++//  Copyright 2020 Google Inc. All Rights Reserved.
++//
++//  Licensed under the Apache License, Version 2.0 (the ""License"");
++//  you may not use this file except in compliance with the License.
++//  You may obtain a copy of the License at
++//
++//      http://www.apache.org/licenses/LICENSE-2.0
++//
++//  Unless required by applicable law or agreed to in writing, software
++//  distributed under the License is distributed on an ""AS IS"" BASIS,
++//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++//  See the License for the specific language governing permissions and
++//  limitations under the License.
++
++// Package assert provides convenience functions that help a method or constructor check whether
++// it was invoked correctly (whether its preconditions have been met).
++//
++// When the assertion fails, a panic occurs, allowing bugs to be found in a fail-fast manner.
++package assert",What's the purpose of this file?,nit: `package assert`?
+872,"@@ -616,12 +616,14 @@ public class PasscodeManager  {
+      */
+     public void setPasscodeLength(Context ctx, int passcodeLength) {
+     	if (passcodeLength > this.passcodeLength) {
+-            if (hasStoredPasscode(ctx)) {
++            if (hasStoredPasscode(ctx) && passcodeLengthKnown) {
+                 this.passcodeChangeRequired = true;
+             }
++
++            this.passcodeLength = passcodeLength;
+     	}
+-        this.passcodeLength = passcodeLength;
+-    	this.passcodeLengthKnown = true;
++
++        this.passcodeLengthKnown = true;
+         storeMobilePolicy(ctx);
+     }
+ ",@bhariharan Why was passcode length requirement allowed to be lowered?,Why do we need this check?
+873,"@@ -6,14 +6,6 @@ import (
+ 	""flag""
+ 	""io/ioutil""
+ 	""log""
+-
+-	""github.com/aws/aws-sdk-go/aws""
+-	""github.com/aws/aws-sdk-go/aws/credentials""
+-	""github.com/aws/aws-sdk-go/aws/session""
+-	""github.com/google/go-cloud/blob""
+-	""github.com/google/go-cloud/blob/gcsblob""
+-	""github.com/google/go-cloud/blob/s3blob""
+-	""github.com/google/go-cloud/gcp""
+ )
+ 
+ const bucketName = ""my-cool-bucket""","This file needs a license header, too. Sorry I didn't catch that earlier.",Why are these removed?
+874,"@@ -289,7 +289,7 @@ func main() {
+ 		}
+ 	}
+ 
+-	err = s.Initialize(cfg, phonebookAddresses)
++	err = s.Initialize(cfg, phonebookAddresses, string(genesisText[:]))
+ 	if err != nil {
+ 		fmt.Fprintln(os.Stderr, err)
+ 		log.Error(err)",probably don't need `[:]` why not reference into `github.com/algorand/go-algorand/daemon/algod/api/server/lib` here and skip bouncing off daemon/algod/server.go ?,`genesisText` can be `nil`
+875,"@@ -86,8 +86,13 @@ public:
+                              const table& y_data,
+                              const table& result_values) {
+         auto reference = compute_reference(scale, shift, x_data, y_data);
++        const table reference_table = dal::detail::homogen_table_builder{}
++                                          .reset(reference.get_array(),
++                                                 reference.get_row_count(),
++                                                 reference.get_column_count())
++                                          .build();
+         const double tol = te::get_tolerance<Float>(3e-4, 1e-9);
+-        const double diff = la::l_inf_norm(reference, la::matrix<double>::wrap(result_values));
++        const double diff = te::abs_error(reference_table, result_values);
+         CHECK(diff < tol);
+     }
+ ",Why reference is converted to table?,Why did you change this?
+876,"@@ -347,6 +347,19 @@ func (s *DataStore) ListRegistrationEntries(ctx context.Context,
+ 	s.mu.Lock()
+ 	defer s.mu.Unlock()
+ 
++	// no pagination allow for this fake, for now it return only one page
++	if req.Pagination != nil {
++		if req.Pagination.Token == 0 {
++			req.Pagination.Token = 1
++		} else {
++			// for now only 1 page is returned
++			return &datastore.ListRegistrationEntriesResponse{
++				Entries:    []*common.RegistrationEntry{},
++				Pagination: req.Pagination,
++			}, nil
++		}
++	}
++
+ 	// add the registration entries to the map
+ 	entriesSet := make(map[string]*common.RegistrationEntry)
+ 	for _, entry := range s.registrationEntries {",should we implement pagination in the fake datastore so the server startup code that paginates entries for trust domain validation can be tested?,I don't think this is the right way to do this. I think we should just return an empty response here.
+877,"@@ -15,6 +15,12 @@ func Compile(scope Scope, f *semantic.FunctionExpression, in semantic.MonoType)
+ 		return nil, errors.Newf(codes.Invalid, ""function input must be an object @ %v"", f.Location())
+ 	}
+ 
++	// If the function is vectorizable, `f.Vectorized` will be populated, and
++	// we should use the FunctionExpression it points to instead of `f`
++	if f.Vectorized != nil {
++		f = f.Vectorized
++	}
++
+ 	// Retrieve the function argument types and create an object type from them.
+ 	fnType := f.TypeOf()
+ 	argN, err := fnType.NumArguments()",What mechanism will be exposed so the caller knows they're using the vectorized version?,nit: `f.Vectorized` can be `nil` here.
+878,"@@ -20,9 +20,9 @@ class TopicsController < ApplicationController
+     @topic = build_new_topic
+     respond_to do |format|
+       if verify_recaptcha(model: @topic) && @topic.save
+-        format.html { redirect_to forum_path(@forum), flash: { success: t('.success') } }
++        format.html { redirect_to forum_path(@forum), notice: t('.success') }
+       else
+-        format.html { redirect_to forum_path(@forum), flash: { error: t('.error') } }
++        format.html { render :new }
+       end
+     end
+   end",Can we remove respond_to block its not required here,Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or specia
+879,"@@ -23,12 +23,13 @@
+ #include ""oneapi/dal/algo/jaccard.hpp""
+ #include ""oneapi/dal/graph/service_functions.hpp""
+ #include ""oneapi/dal/graph/undirected_adjacency_vector_graph.hpp""
+-#include ""oneapi/dal/io/graph_csv_data_source.hpp""
+-#include ""oneapi/dal/io/load_graph.hpp""
++#include ""oneapi/dal/io/csv.hpp""
+ #include ""oneapi/dal/table/homogen.hpp""
+ 
+ namespace dal = oneapi::dal;
+ 
++using namespace dal;
++
+ /// Computes Jaccard similarity coefficients for the graph. The upper triangular
+ /// matrix is processed only as it is symmetic for undirected graph.
+ ///","Do not do that even in example, we demonstrate bad practice",using namespace std;
+880,"@@ -202,7 +202,13 @@ module Beaker
+     #Examine the host system to determine the architecture
+     #@return [Boolean] true if x86_64, false otherwise
+     def determine_if_x86_64
+-      result = exec(Beaker::Command.new(""arch | grep x86_64""), :acceptable_exit_codes => (0...127))
++      if self['is_cygwin'].nil? or self['is_cygwin'] == true
++        command = Beaker::Command.new(""arch | grep x86_64"")
++      else
++        command = Beaker::Command.new(""echo '' | wmic os get osarchitecture | FindStr 64-bit"")
++      end
++
++      result = exec(command, :acceptable_exit_codes => (0...127))
+       result.exit_code == 0
+     end
+ ","Hm, taking a second look over this, this is why we have the object inheritance structure that we do. This could be divided up by having a custom determine_if_x86_64 in the pswindows/exec hosts and then a default method in hosts.rb. That way all the custom ps windows work is in a single location.",This should be `self['is_cygwin'].to_s == 'true'`
+881,"@@ -84,11 +84,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [InlineData(null, new byte[0])]
+         public void EncodesAsAscii(string input, byte[] expected)
+         {
+-            var writerBuffer = _pipe.Writer;
+-            var writer = new BufferWriter<PipeWriter>(writerBuffer);
++            var pipeWriter = _pipe.Writer;
++            var writer = new BufferWriter<PipeWriter>(pipeWriter);
+             writer.WriteAsciiNoValidation(input);
+             writer.Commit();
+-            writerBuffer.FlushAsync().GetAwaiter().GetResult();
++            pipeWriter.FlushAsync().GetAwaiter().GetResult();
++            pipeWriter.Complete();
++
+             var reader = _pipe.Reader.ReadAsync().GetAwaiter().GetResult();
+ 
+             if (expected.Length > 0)",We have to `.Complete` now because of empty/null string test cases.,Why is this necessary?
+882,"@@ -166,7 +166,7 @@ module Beaker
+     def scp_to source, target, options = {}, dry_run = false
+       return if dry_run
+ 
+-      options[:recursive]  = File.directory?(source) if options[:recursive].nil?
++      options[:recursive]  = File.directory?(source)
+       options[:chunk_size] = options[:chunk_size] || 16384
+ 
+       result = Result.new(@hostname, [source, target])",Is there still a way to specify no recursion?,Why remove the nil check?
+883,"@@ -438,6 +438,15 @@ Loop:
+ 	return w, nil
+ }
+ 
++// Tool is used to communicate the tool's name ot the user.
++type Tool struct {
++
++	// HumanReadableName is used for error messages, for example: ""image import"".
++	HumanReadableName string
++	// URISafeName is used programmatically, eg: ""image-import""
++	URISafeName string
++}
++
+ // EnvironmentSettings controls the resources that are used during tool execution.
+ type EnvironmentSettings struct {
+ 	// Location of workflows",How is this name being URI safe and being used programmatically related?,Why do we need this?
+884,"@@ -358,14 +358,14 @@ module.exports = class ProviderView {
+       state = this.plugin.getPluginState()
+       state.selectedFolders[folderId] = { loading: false, files: files }
+       this.plugin.setPluginState({ selectedFolders: folders })
+-      const dashboard = this.plugin.uppy.getPlugin('Dashboard')
++
+       let message
+       if (files.length) {
+-        message = dashboard.i18n('folderAdded', {
++        message = this.plugin.uppy.i18n('folderAdded', {
+           smart_count: files.length, folder: folder.name
+         })
+       } else {
+-        message = dashboard.i18n('emptyFolderAdded')
++        message = this.plugin.uppy.i18n('emptyFolderAdded')
+       }
+       this.plugin.uppy.info(message)
+     }).catch((e) => {","I think we have to keep this as a fallback for now, else it's a small breaking change :(","`this.plugin.uppy.i18n('emptyFolderAdded', { folder: folder.name })`"
+885,"@@ -80,7 +80,7 @@ func TestOpImmediateNote(t *testing.T) {
+ func TestOpDocExtra(t *testing.T) {
+ 	xd := OpDocExtra(""bnz"")
+ 	require.NotEmpty(t, xd)
+-	xd = OpDocExtra(""+"")
++	xd = OpDocExtra(""-"")
+ 	require.Empty(t, xd)
+ }
+ ",nit: shouldn't be part of this PR.,Why this change?
+886,"@@ -83,7 +83,7 @@ describe('Cursor Async Iterator Tests', function() {
+           expect(doc).to.exist;
+           cursor.close();
+         }
+-        throw new Error('expected closing the cursor to break iteration');
++        throw new MongoError('expected closing the cursor to break iteration');
+       } catch (e) {
+         expect(e).to.be.an.instanceOf(MongoError);
+       }","this change looks wrong to me. I think the test is trying to signal that something went wrong by throwing the `Error` here, otherwise the `catch` below will swallow it.",Shouldn't this be `MongoError`?
+887,"@@ -164,6 +164,13 @@ namespace NLog.Internal
+ 
+             if (reusableBuilder != null)
+             {
++                if (!_layout.IsThreadAgnostic)
++                {
++                    string cachedResult;
++                    if (logEvent.TryGetCachedLayoutValue(_layout, out cachedResult))
++                        return cachedResult;
++                }
++
+                 _layout.RenderAppendBuilder(logEvent, reusableBuilder);
+ 
+                 if (_cachedPrevRawFileName != null && _cachedPrevRawFileName.Length == reusableBuilder.Length)","I'm doubting if this should be `if (_layout.IsThreadAgnostic)`, as ThreadAgnostic stuff could be calculated on every thread. (and thus could be lazy). non-ThreadAgnostic should be calculated on the main thread.",Why do we need this?
+888,"@@ -7,14 +7,19 @@ import javafx.scene.control.ToggleGroup;
+ import javafx.scene.layout.HBox;
+ import org.phoenicis.javafx.views.common.widgets.lists.CombinedListWidget;
+ import org.phoenicis.javafx.views.common.widgets.lists.ListWidgetType;
++import org.slf4j.LoggerFactory;
+ 
+ import java.util.Arrays;
+ import java.util.List;
++import java.util.Optional;
++import java.util.function.Consumer;
+ 
+ /**
+  * Created by marc on 15.05.17.
+  */
+ public class LeftListWidgetChooser<E> extends HBox {
++    private final org.slf4j.Logger LOGGER = LoggerFactory.getLogger(LeftListWidgetChooser.class);
++
+     private List<CombinedListWidget<E>> listWidgets;
+ 
+     private ToggleGroup toggleGroup;",Please use only `Logger` instead of `org.slf4j.Logger`,Why is this needed?
+889,"@@ -326,6 +326,10 @@ void nano::block_processor::process_live (nano::transaction const & transaction_
+ 	{
+ 		node.network.flood_block_initial (block_a);
+ 	}
++	else if (!node.flags.disable_block_processor_republishing)
++	{
++		node.network.flood_block (block_a, nano::buffer_drop_policy::no_limiter_drop);
++	}
+ 
+ 	if (node.websocket_server && node.websocket_server->any_subscriber (nano::websocket::topic::new_unconfirmed_block))
+ 	{","Should this be ""no limiter drop"", since this isn't an absolutely essential activity for the stability of the network?",Shouldn't this be `
+890,"@@ -22,8 +22,8 @@ var iam = new AWS.IAM({apiVersion: '2010-05-08'});
+ 
+ iam.deleteAccountAlias({AccountAlias: process.argv[2]}, function(err, data) {
+   if (err) {
+-    console.log(""Error"", err);
++    throw err;
+   } else {
+-    console.log(""Success"", data);
++    console.log('Account alias ' + process.argv[2] + ' deleted.');
+   }
+ });","I updated many of the success messages, because most of these operations don't return data if they succeed. This meant many of the operations would print: `Success null` if the script ran successfully.",Shouldn't this be `
+891,"@@ -45,6 +45,8 @@ def _test_pyx():
+                                       stdout=devnull, stderr=subprocess.STDOUT)
+     except (subprocess.CalledProcessError, OSError):
+         return False
++    except FileNotFoundError as fnfe:
++        return False
+     else:
+         return r == 0
+ ",Could you simply add it to the previous clause ?,`fnfe` is not used.
+892,"@@ -108,13 +108,10 @@ Blockly.Procedures.sortProcedureMutations_ = function(mutations) {
+     var procCodeA = a.getAttribute('proccode');
+     var procCodeB = b.getAttribute('proccode');
+ 
+-    if (procCodeA < procCodeB) {
+-      return -1;
+-    } else if (procCodeA > procCodeB) {
+-      return 1;
+-    } else {
+-      return 0;
+-    }
++    return procCodeA.localeCompare(procCodeB, undefined, {
++      sensitivity: 'base',
++      numeric: true
++    });
+   });
+ 
+   return newMutations;","@joshyrobot, I think you can just use localeCompare with only the first argument and leave the other arguments out (here and all the other lines changed). It seems to do the right thing, and then we don't have to worry about these extra options.",I think this should be `sensitivity: 'base'`
+893,"@@ -239,6 +239,10 @@ public class ExecuteFlowAction implements TriggerAction {
+     }
+     exflow.setExecutionOptions(executionOptions);
+ 
++    if (slaOptions != null && slaOptions.size() > 0) {
++      exflow.setSlaOptions(slaOptions);
++    }
++
+     try {
+       logger.info(""Invoking flow "" + project.getName() + ""."" + flowName);
+       executorManager.submitExecutableFlow(exflow, submitUser);",@chengren311 : where does this logic move to?,Why do we need this?
+894,"@@ -204,6 +204,14 @@ func (s *NodegroupService) reconcileNodegroupIAMRole() error {
+ 	}
+ 
+ 	policies := NodegroupRolePolicies()
++	if len(s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies) > 0 {
++		if !s.scope.AllowAdditionalRoles() {
++			return ErrCannotUseAdditionalRoles
++		}
++
++		policies = append(policies, s.scope.ManagedMachinePool.Spec.RoleAdditionalPolicies...)
++	}
++
+ 	_, err = s.EnsurePoliciesAttached(role, aws.StringSlice(policies))
+ 	if err != nil {
+ 		return errors.Wrapf(err, ""error ensuring policies are attached: %v"", policies)",Can we have a `nil` exception check at `s.scope.ManagedMachinePool`,I think this should be `if len(s.scope.Manag
+895,"@@ -40,16 +40,6 @@ class Options extends \VuFind\Search\Base\Options
+ {
+     use \VuFind\Search\Options\ViewOptionsTrait;
+ 
+-    /**
+-     * Available sort options for facets
+-     *
+-     * @var array
+-     */
+-    protected $facetSortOptions = [
+-        'count' => 'sort_count',
+-        'index' => 'sort_alphabetic'
+-    ];
+-
+     /**
+      * Hierarchical facets
+      *","Rather than deleting this, should you just reformat it so it's the `*` settings, so if nothing is configured in facets.ini, the existing default behavior continues to work?",why did you remove this?
+896,"@@ -31,11 +31,14 @@ class ManagerConfiguration {
+       '#collapsible' => FALSE,
+     ];
+     foreach ($this->datastoreManager->getConfigurableProperties() as $property => $default_value) {
++      $propety_label = str_replace(""_"", "" "", $property);
++      $propety_label = ucfirst($propety_label);
++
+       if ($property == ""delimiter"") {
+         $form['import_options'][""datastore_manager_config_{$property}""] = array(
+           '#type' => 'select',
+           // @codingStandardsIgnoreStart
+-          '#title' => ucfirst(t(""{$property}"")),
++          '#title' => t($propety_label),
+           // @codingStandardsIgnoreEnd
+           '#options' => array(
+             "","" => "","",","wrap, single line","I don't think this is the right way to do this. If you have a property named `delimiter`, you should be able to use `t('delimiter')`"
+897,"@@ -202,6 +202,12 @@ public class JavaContextCommon {
+ 
+     public abstract String getReturnType();
+ 
++    public String getGenericAwareReturnType() {
++      String returnType = getReturnType();
++      if (returnType == null || returnType.isEmpty()) return ""Void"";
++      else return returnType;
++    }
++
+     public abstract ImmutableList<Variable> getParams();
+ 
+     public abstract ImmutableList<Variable> getRequiredParams();",always use brackets for if statements,Why is this needed?
+898,"@@ -34,14 +34,13 @@ namespace Datadog.Trace.ClrProfiler.Integrations.Testing
+         private const string NUnitTestExecutionContextType = ""NUnit.Framework.Internal.TestExecutionContext"";
+ 
+         private static readonly Vendors.Serilog.ILogger Log = DatadogLogging.GetLogger(typeof(NUnitIntegration));
+-        private static readonly FrameworkDescription _runtimeDescription;
++        private static readonly FrameworkDescription RuntimeDescription;
+ 
+         static NUnitIntegration()
+         {
+             // Preload environment variables.
+             CIEnvironmentValues.DecorateSpan(null);
+-
+-            _runtimeDescription = FrameworkDescription.Create();
++            RuntimeDescription = FrameworkDescription.Instance;
+         }
+ 
+         /// <summary>",`NUnitIntegration` doesn't need to cache this anymore.,Why do we need this?
+899,"@@ -210,8 +210,9 @@ EXTS_ACCESS_COUNTS = textwrap.dedent(""""""\
+             eventname,
+             bucket,
+             lower(CASE
+-                WHEN cardinality(parts) > 2 THEN concat(element_at(parts, -2), '.', element_at(parts, -1))
+-                WHEN cardinality(parts) = 2 THEN element_at(parts, -1)
++                WHEN cardinality(parts) > 2 AND lower(element_at(parts, -1)) = 'gz'
++                    THEN concat(element_at(parts, -2), '.', element_at(parts, -1))
++                WHEN cardinality(parts) >= 2 THEN element_at(parts, -1)
+                 ELSE ''
+                 END
+             ) AS ext,",Why did you change it to `>=` here?,Why do we need this?
+900,"@@ -30,8 +30,11 @@ abstract class BaseAction<R> implements Action<R> {
+     String tableName = table().toString();
+     if (tableName.contains(""/"")) {
+       return tableName + ""#"" + type;
+-    } else if (tableName.startsWith(""hadoop."") || tableName.startsWith(""hive."")) {
+-      // HiveCatalog and HadoopCatalog prepend a logical name which we need to drop for Spark 2.4
++    } else if (tableName.startsWith(""hadoop."")) {
++      // Load a path by HadoopCatalog or HadoopTables
++      return table().location() + ""#"" + type;
++    } else if (tableName.startsWith(""hive."")) {
++      // HiveCatalog prepend a logical name which we need to drop for Spark 2.4
+       return tableName.replaceFirst(""(hadoop\\.)|(hive\\.)"", """") + ""."" + type;
+     } else {
+       return tableName + ""."" + type;",Looks like this needs to be updated. There is no need to remove `hadoop.` if Hadoop tables don't use this code path.,Why do we need this change?
+901,"@@ -1,4 +1,5 @@
+ require 'fileutils'
++require 'digest'
+ 
+ module RSpec
+   module Core","This require isn't need anymore, right?",require 'digest'
+902,"@@ -32,6 +32,7 @@ import (
+ 	""github.com/mysteriumnetwork/node/session""
+ 	""github.com/mysteriumnetwork/node/session/balance""
+ 	""github.com/mysteriumnetwork/node/session/promise""
++	""github.com/mysteriumnetwork/payments/crypto""
+ 	""github.com/pkg/errors""
+ )
+ ",a bit weird to see payments crypto package inside connection manager. There probably will be services not having any relation with payments that will use connection manager. Thats why probably ping-ping by itself can be useful without any relation to payments..,nit: remove empty line
+903,"@@ -889,7 +889,7 @@ trait MarcAdvancedTrait
+                 'http://www.loc.gov/standards/marcxml/schema/MARC21slim.xsd',
+                 'http://www.w3.org/2001/XMLSchema-instance'
+             );
+-            $xml->record->addAttribute('type', 'Bibliographic');
++            $xml->record->addAttribute('type', $this->xmlType);
+             return $xml->record->asXML();
+         }
+ ","I like the overall idea here, but I wonder if it would be more clear to define the property in the trait, and then set it in the constructors of the classes using the trait. Alternatively, at a bare minimum, it may be a good idea to add `?? 'Bibliographic'` here, to account for the possibility of the trait being used in a class that does not define the property at all.",Why did you change this?
+904,"@@ -2,6 +2,10 @@ package protocol
+ 
+ import ""time""
+ 
++// NonForwardSecurePacketSizeReduction is the number of bytes a non forward-secure packet has to be smaller than a forward-secure packet
++// This makes sure that those packets can always be retransmitted without splitting the contained StreamFrames
++const NonForwardSecurePacketSizeReduction = 50
++
+ // DefaultMaxCongestionWindow is the default for the max congestion window
+ const DefaultMaxCongestionWindow = 1000
+ ","I would prefer to not have a magic number, but construct this value out of other constants we already have.",nit: `// This makes sure that those packets can always be retransmitted without splitting the contained StreamFrames`
+905,"@@ -101,6 +101,15 @@ def setup_authentication(config):
+     from configuration.
+     """"""
+     config.include('pyramid_multiauth')
++    settings = config.get_settings()
++
++    policies = aslist(settings['multiauth.policies'])
++    if 'basicauth' in policies:
++        config.add_api_capability(
++            ""basicauth"",
++            description=""Very basic authentication sessions. Not for production use."",
++            url=""http://kinto.readthedocs.io/en/stable/api/1.x/authentication.html"",
++        )
+ 
+     # Track policy used, for prefixing user_id and for logging.
+     def on_policy_selected(event):","The limitation is if somebody configure another policy with the same name, but it is an edge case we can ignore I guess.",I don't think this is the right place to put this. It should be in `kinto.readthedocs.io/en/stable`.
+906,"@@ -31,8 +31,8 @@ import (
+ 	_ ""gocloud.dev/secrets/awskms""
+ 	_ ""gocloud.dev/secrets/azurekeyvault""
+ 	_ ""gocloud.dev/secrets/gcpkms""
+-	_ ""gocloud.dev/secrets/hashivault""
+ 	_ ""gocloud.dev/secrets/localsecrets""
++	_ ""gocloud.dev/secrets/vault""
+ )
+ 
+ const helpSuffix = `",? The package is named `hashivault`.,Why did you remove this?
+907,"@@ -240,6 +240,9 @@ static int config_ini_handler(void *user, const char *section, const char *name,
+ 		if (strcmp(name, ""xwayland"") == 0) {
+ 			if (strcasecmp(value, ""true"") == 0) {
+ 				config->xwayland = true;
++			} else if (strcasecmp(value, ""lazy"") == 0) {
++				config->xwayland = true;
++				config->xwayland_lazy = true;
+ 			} else if (strcasecmp(value, ""false"") == 0) {
+ 				config->xwayland = false;
+ 			} else {","I don't think this should enable xwayland, because it's convenient to toggle xwayland just by setting `xwayland` to `false`",Shouldn't this be `config->xwayland_lazy = false;`?
+908,"@@ -28,7 +28,6 @@ import (
+ 	fakeclientset ""k8s.io/client-go/kubernetes/fake""
+ 	certutil ""k8s.io/client-go/util/cert""
+ 	""k8s.io/client-go/util/keyutil""
+-
+ 	fakeaggregatorclientset ""k8s.io/kube-aggregator/pkg/client/clientset_generated/clientset/fake""
+ )
+ ",Remove this line by accident?,Why was this removed?
+909,"@@ -16,12 +16,13 @@
+ 
+ package com.palantir.baseline.plugins;
+ 
++import java.util.Collections;
+ import java.util.Objects;
+ import org.gradle.api.Plugin;
+ import org.gradle.api.Project;
+ import org.gradle.api.artifacts.Dependency;
+-import org.gradle.api.plugins.JavaPluginConvention;
+ import org.gradle.api.tasks.SourceSet;
++import org.gradle.api.tasks.SourceSetContainer;
+ import org.gradle.api.tasks.compile.JavaCompile;
+ 
+ public final class BaselineImmutables implements Plugin<Project> {","Calling `.stream()` on a `DomainObjectCollection` is pretty much always a bug, as it doesn't include objects added later (and encourages people to use afterEvaluate). I wonder if we should make this an error prone check?",nit: `Collections.emp
+910,"@@ -201,7 +201,10 @@ func CreateGitIgnore(targetDir string, ignores ...string) error {
+ 
+ 	if fileutil.FileExists(gitIgnoreFilePath) {
+ 		sigFound, err := fileutil.FgrepStringInFile(gitIgnoreFilePath, DdevFileSignature)
+-		util.CheckErr(err)
++		if err != nil {
++			return err
++		}
++
+ 		// If we sigFound the file and did not find the signature in .ddev/.gitignore, warn about it.
+ 		if !sigFound {
+ 			util.Warning(""User-managed %s will not be managed/overwritten by ddev"", gitIgnoreFilePath)","Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where ""can't happen"" but Things Can Happen.",Why is this change ne
+911,"@@ -275,6 +275,15 @@ func (b *ofFlowBuilder) MatchARPOp(op uint16) FlowBuilder {
+ 	return b
+ }
+ 
++// MatchIPDscp adds match condition for matching DSCP field in the IP header. Note, OVS use TOS to present DSCP, and
++// the field name is shown as ""nw_tos"" with OVS command line, and the value is calculated by shifting the given value
++// left 2 bits.
++func (b *ofFlowBuilder) MatchIPDscp(dscp uint8) FlowBuilder {
++	b.matchers = append(b.matchers, fmt.Sprintf(""nw_tos=%d"", dscp<<2))
++	b.Match.IpDscp = dscp
++	return b
++}
++
+ // MatchConjID adds match condition for matching conj_id.
+ func (b *ofFlowBuilder) MatchConjID(value uint32) FlowBuilder {
+ 	b.matchers = append(b.matchers, fmt.Sprintf(""conj_id=%d"", value))",What is the different between nw_tos and ip_dscp? Only high 6 bits vs low 6 bits and supported version?,I don't think we need
+912,"@@ -329,12 +329,17 @@ extern ""C"" bool isValidMolBlob(char *data, int len) {
+   return res;
+ }
+ 
+-extern ""C"" char *makeMolText(CROMol data, int *len, bool asSmarts) {
++extern ""C"" char *makeMolText(CROMol data, int *len, bool asSmarts,
++                             bool cxSmiles) {
+   ROMol *mol = (ROMol *)data;
+ 
+   try {
+     if (!asSmarts) {
+-      StringData = MolToSmiles(*mol, true);
++      if (!cxSmiles) {
++        StringData = MolToSmiles(*mol);
++      } else {
++        StringData = MolToCXSmiles(*mol);
++      }
+     } else {
+       StringData = MolToSmarts(*mol, false);
+     }",I'm assuming that asSmarts & cxSmiles == asSmarts,Shouldn't this be `MolToCXSmiles`?
+913,"@@ -780,7 +780,9 @@ class LabelledData(param.Parameterized):
+         except:
+             self.warning(""Could not unpickle custom style information."")
+         self.__dict__.update(d)
+-
++        # TODO: super's setstate not called?
++        if ""param"" not in self.__dict__:
++            self.param = type(self.param)(self.__class__, self=self)
+ 
+ 
+ class Dimensioned(LabelledData):",Seems like an oversight but I don't think the super would do anything else in this case unless I'm mistaken.,I don't think this is the right pl
+914,"@@ -30,8 +30,8 @@ namespace Examples.Console
+     internal class InstrumentationWithActivitySource : IDisposable
+     {
+         private const string RequestPath = ""/api/request"";
+-        private SampleServer server = new SampleServer();
+-        private SampleClient client = new SampleClient();
++        private readonly SampleServer server = new SampleServer();
++        private readonly SampleClient client = new SampleClient();
+ 
+         public void Start(ushort port = 19999)
+         {","Curious, do we consider this as pedantic for example code?",Why are these readonly?
+915,"@@ -609,7 +609,7 @@ class AdminController extends Controller
+ 
+         $formType = $this->useLegacyFormComponent() ? 'easyadmin' : 'JavierEguiluz\\Bundle\\EasyAdminBundle\\Form\\Type\\EasyAdminFormType';
+ 
+-        return $this->get('form.factory')->createNamedBuilder('form', $formType, $entity, $formOptions);
++        return $this->get('form.factory')->createNamedBuilder(strtolower($this->entity['name']), $formType, $entity, $formOptions);
+     }
+ 
+     /**","Should we convert the entity name to snake case using `Doctrine\Common\Inflector\Inflector::tableize` or similar ? Should a `snaked_name` or whatever be part of the entity metadata in order to use it for form names, ids, & other html attributes ?",Why is this change needed?
+916,"@@ -12,9 +12,15 @@ func NewClientFake(IP string) Client {
+ 
+ type clientFake struct {
+ 	ip string
++	outboundIp string
+ }
+ 
+-func (client *clientFake) GetIp() (string, error) {
++func (client *clientFake) GetPublicIP() (string, error) {
++	log.Info(IPIFY_API_LOG_PREFIX, ""IP faked: "", client.ip)
++	return client.ip, nil
++}
++
++func (client *clientFake) GetOutboundIP() (string, error) {
+ 	log.Info(IPIFY_API_LOG_PREFIX, ""IP faked: "", client.ip)
+ 	return client.ip, nil
+ }",Should be `client.outboundIp`,I think this should be `outboundIP`
+917,"@@ -31,6 +31,9 @@
+ // THE POSSIBILITY OF SUCH DAMAGE.
+ // 
+ 
++using System.IO;
++using System.Threading.Tasks;
++
+ namespace NLog.UnitTests.LayoutRenderers
+ {
+     using System;",Must these `using` statements not go inside the `namespace` block?,Why is this needed?
+918,"@@ -92,8 +92,8 @@ type fboMutexLevel mutexLevel
+ 
+ const (
+ 	fboMDWriter fboMutexLevel = 1
+-	fboHead                   = 2
+-	fboBlock                  = 3
++	fboHead     fboMutexLevel = 2
++	fboBlock    fboMutexLevel = 3
+ )
+ 
+ func (o fboMutexLevel) String() string {",Why? I thought the previous way was idiomatic. (Same with the `MetadataVer` stuff above.),Why did you change this?
+919,"@@ -12,11 +12,7 @@ define([], function() {
+     }
+ 
+     function uploadContent(connectionManager, server, options) {
+-        return new Promise(function(resolve, reject) {
+-            require([""contentuploader""], function(ContentUploader) {
+-                (new ContentUploader).uploadImages(connectionManager, server).then(resolve, reject)
+-            })
+-        })
++        return new Promise().resolve();
+     }
+ 
+     function syncMedia(connectionManager, server, options) {",shouldn't we `reject` here instead?,Shouldn't this be `Promise.resolve(
+920,"@@ -167,10 +167,12 @@ func printActionProto(action *iotextypes.Action) (string, error) {
+ 	if err != nil {
+ 		return """", output.NewError(output.ConvertError, ""failed to convert bytes into address"", err)
+ 	}
++	//ioctl action should display IOTX unit instead Raul
++	gasPriceUnitIOTX, err := util.StringToIOTX(action.Core.GasPrice)
+ 	result := fmt.Sprintf(""\nversion: %d  "", action.Core.GetVersion()) +
+ 		fmt.Sprintf(""nonce: %d  "", action.Core.GetNonce()) +
+ 		fmt.Sprintf(""gasLimit: %d  "", action.Core.GasLimit) +
+-		fmt.Sprintf(""gasPrice: %s Rau\n"", action.Core.GasPrice) +
++		fmt.Sprintf(""gasPrice: %s IOTX\n"", gasPriceUnitIOTX) +
+ 		fmt.Sprintf(""senderAddress: %s %s\n"", senderAddress.String(),
+ 			Match(senderAddress.String(), ""address""))
+ 	switch {","check err or use gasPriceUnitIOTX, _ := if we are sure action.Core.GasPrice is correct",Why do we need this change?
+921,"@@ -34,7 +34,7 @@ func newHarness(t *testing.T) (drivertest.Harness, error) {
+ 	return &harness{vars: map[string][]byte{}}, nil
+ }
+ 
+-func (h *harness) MakeWatcher(ctx context.Context, name string, decoder *runtimevar.Decoder, wait time.Duration) (driver.Watcher, error) {
++func (h *harness) MakeWatcher(ctx context.Context, name string, decoder *runtimevar.Decoder) (driver.Watcher, error) {
+ 	rawVal, found := h.vars[name]
+ 	if !found {
+ 		// The variable isn't set. Create a Variable that always returns an error.","Just curious, was wait not used at all before?",Why did you remove the wait
+922,"@@ -7,9 +7,10 @@ package manifest
+ import (
+ 	""errors""
+ 	""fmt""
++	""github.com/google/shlex""
+ 	""path/filepath""
+ 	""strconv""
+-	""strings""
++	//""strings""
+ 
+ 	""github.com/aws/aws-sdk-go/aws""
+ 	""gopkg.in/yaml.v3""",nit: can we remove this?,Can we remove this line?
+923,"@@ -44,11 +44,11 @@ public class NotificationStore {
+         }
+     }
+ 
+-    public Notification get(int index) {
++    public synchronized Notification get(int index) {
+         return store.get(index);
+     }
+ 
+-    public void add(Notification n) {
++    public synchronized void add(Notification n) {
+         log.info(""Notification received: "" + n.text);
+         for (int i = 0; i < store.size(); i++) {
+             if (get(i).id == n.id) {",is it not a problem when one synchronized function is called by other?,Why is this synchronized?
+924,"@@ -1,6 +1,7 @@
+ ActiveAdmin.register Account do
+-  permit_params :level
+-  actions :index, :show, :edit
++  permit_params :login, :email, :level, :country_code, :location, :url, :hide_experience, :email_master, :email_posts,
++                :email_kudos, :email_new_followers, :twitter_account, :affiliation_type, :organization_name
++  actions :index, :show, :edit, :update
+ 
+   controller do
+     defaults finder: :fetch_by_login_or_email","We (even as admins) shouldn't override the User Preference settings like `email_master`, `email_posts`, `email_kudos`, `email_new_followers`. These all would be set by the user of their choice. Please do remove these attributes from editing//updating. Thanks!",Style/SymbolArray: Use %i or %I for an array of symbols.
+925,"@@ -20,7 +20,7 @@ return [
+     'alpha_dash'           => 'O campo :attribute deve conter apenas letras, números e traços.',
+     'alpha_num'            => 'O campo :attribute deve conter apenas letras e números .',
+     'array'                => 'O campo :attribute deve conter um array.',
+-    'attached'             => 'This :attribute is already attached.',
++    'attached'             => 'Este :attribute já está ligado.',
+     'before'               => 'O campo :attribute deve conter uma data anterior a :date.',
+     'before_or_equal'      => 'O campo :attribute deve conter uma data inferior ou igual a :date.',
+     'between'              => [","""Este :attribute j est anexado."" sounds better.",I don't think this should be changed.
+926,"@@ -0,0 +1,6 @@
++
++if __name__ == ""__main__"":
++    import doctest
++    import databricks.koalas as ks
++    from databricks.koalas import frame, series
++    doctest.testmod(frame, extraglobs={""ks"": ks})","This line should be repeated for every module that needs testing. One cannot rely on nosetest to automatically discover all the modules. On the bright side, there is no need to change any of the other files.",This file is missing a license header.
+927,"@@ -301,5 +301,3 @@ var failedIssuanceMu sync.RWMutex
+ // If this value is recent, do not make any on-demand certificate requests.
+ var lastIssueTime time.Time
+ var lastIssueTimeMu sync.Mutex
+-
+-var errNoCert = errors.New(""no certificate available"")",This error was unused,// errNoCert is the error returned when there is no cert
+928,"@@ -212,6 +212,11 @@ type (
+ 		PreviousRangeID int64
+ 	}
+ 
++	// CloseShardRequest is used to notify persistence that we're unloading a shard
++	CloseShardRequest struct {
++		ShardID int32
++	}
++
+ 	// AddTasksRequest is used to write new tasks
+ 	AddTasksRequest struct {
+ 		ShardID int32","Personally I wish we didn't have a proto for every single little thing we do. RequestShardAction with an enum for the action type would be a lot cleaner imo, but I'm pretty sure that ship has sailed :) Just kvetching.",Why do we need this?
+929,"@@ -0,0 +1,5 @@
++<% if trail.complete? %>
++  <%= render ""completed_trails/trail"", trail: trail %>
++<% else %>
++  <%= render ""trails/incomplete_trail"", trail: trail %>
++<% end %>",Does this make more sense as `trails/_trail` now?,I think this should 
+930,"@@ -435,6 +435,17 @@ func (agent *ecsAgent) getEC2InstanceID() string {
+ 	return instanceID
+ }
+ 
++// getoutpostARN gets the Outpost ARN from the metadata service
++func (agent *ecsAgent) getoutpostARN() string {
++	outpostARN, err := agent.ec2MetadataClient.OutpostARN()
++	if err != nil {
++		seelog.Warnf(
++			""Unable to obtain Outpost ARN from EC2 Metadata: %v"", err)
++		return """"
++	}
++	return outpostARN
++}
++
+ // newStateManager creates a new state manager object for the task engine.
+ // Rest of the parameters are pointers and it's expected that all of these
+ // will be backfilled when state manager's Load() method is invoked","synced offline. let's move this to `agent_unix.go` to make the IMDS call, since this is not supported in Windows.",Should we return an 
+931,"@@ -12,6 +12,10 @@ class PythonMappings
+     fun.add_mapping(""py_env"", Python::VirtualEnv.new)
+ 
+     fun.add_mapping(""py_docs"", Python::GenerateDocs.new)
++	
++	fun.add_mapping(""py_install"", Python::Install.new)
++	
++	fun.add_mapping(""py_prep"", Python::Prep.new)
+   end
+ end
+ ","Too much indentation here. Should match the lines above, which have four spaces.",I don't think this i
+932,"@@ -15,14 +15,6 @@ BOOST_AUTO_TEST_CASE(test_incompatible_with_mld)
+         osrm::exception);
+ }
+ 
+-BOOST_AUTO_TEST_CASE(test_incompatible_with_corech)
+-{
+-    // Note - CH-only data can't be used with the CoreCH algorithm
+-    BOOST_CHECK_THROW(
+-        getOSRM(OSRM_TEST_DATA_DIR ""/ch/monaco.osrm"", osrm::EngineConfig::Algorithm::CoreCH),
+-        osrm::exception);
+-}
+-
+ BOOST_AUTO_TEST_CASE(test_incompatible_with_ch)
+ {
+     // Can't use the CH algorithm with MLD data",Same here we still need this test to make sure the fallback works.,Why was this test removed?
+933,"@@ -0,0 +1,8 @@
++using System;
++namespace MvvmCross.iOS.Views.Presenters.Attributes
++{
++    public interface IMvxOverridePresentationAttribute
++    {
++        MvxBasePresentationAttribute OverridePresentationAttribute();
++    }
++}",I'm wondering if we can actually base this on a `IMvxPresentationAttribute` instead of the base one.,Please add a license heade
+934,"@@ -430,7 +430,7 @@ export function unmount(vnode, parentVNode, skipRemove) {
+ 			}
+ 		}
+ 
+-		r.base = r._parentDom = null;
++		r.base = r._parentDom = r._vnode = vnode._component = null;
+ 	}
+ 
+ 	if ((r = vnode._children)) {",could we switch to `undefined` here?,Why is this change needed?
+935,"@@ -94,6 +94,7 @@ public class SyncManager {
+         this.smartStore = smartStore;
+         this.restClient = restClient;
+         SyncState.setupSyncsSoupIfNeeded(smartStore);
++        SyncState.cleanupSyncsSoupIfNeeded(smartStore);
+     }
+ 
+     /**",The cleanup call,this.restClient = restClie
+936,"@@ -288,10 +288,11 @@ define(['apphost', 'globalize', 'connectionManager', 'itemHelper', 'appRouter',
+                 icon: 'album'
+             });
+         }
+-
+-        if (options.openArtist !== false && item.ArtistItems && item.ArtistItems.length) {
++        // Show Album Artist by default, as a song can have multiple artists, which specific one would this option refer to?
++        // Although some albums can have multiple artists, it's not as common as songs.
++        if (options.openArtist !== false && item.AlbumArtists && item.AlbumArtists.length) {
+             commands.push({
+-                name: globalize.translate('ViewArtist'),
++                name: globalize.translate('ViewAlbumArtist'),
+                 id: 'artist',
+                 icon: 'person'
+             });","I think ""View artist"" is a bit more standard and expected. Or even ""Go to artist"" to take the Spotify terminology as-is.",Shouldn't this be `item.AlbumArtists.length > 1`?
+937,"@@ -196,6 +196,9 @@ module Bolt
+       # This works on deeply nested data structures composed of Hashes, Arrays, and
+       # and plain-old data types (int, string, etc).
+       def unwrap_sensitive_args(arguments)
++        # Skip this if Puppet isn't loaded
++        return arguments unless defined?(Puppet::Pops::Types::PSensitiveType::Sensitive)
++
+         case arguments
+         when Array
+           # iterate over the array, unwrapping all elements",It might make sense to refactor this later so that we use a Bolt-native type to hide sensitive values.,Why is this needed?
+938,"@@ -30,3 +30,7 @@ from extensive_tm_test_base import ExtensiveTemporalMemoryTest
+ class ExtensiveTemporalMemoryTestCPP(ExtensiveTemporalMemoryTest, unittest.TestCase):
+   def getTMClass(self):
+     return nupic.bindings.algorithms.TemporalMemory
++
++
++if __name__ == ""__main__"":
++  unittest.main()",We were trying to move away from this to force people to always run tests under py.test.,Why is this needed?
+939,"@@ -933,6 +933,8 @@ from selenium.webdriver.common.keys import Keys
+ 
+         browser = self._check_platform()
+ 
++        body.append(self._get_selenium_options())
++
+         if browser == 'firefox':
+             body.extend(self._get_firefox_options() + self._get_firefox_profile() + [self._get_firefox_webdriver()])
+ ",1 - create browser specific options class: - chromeoptions - firefoxoptions - argsoptions,I think this should be `self._get_selenium_option
+940,"@@ -681,7 +681,9 @@ class ProxyListenerS3(ProxyListener):
+ 
+                 # fix content-type: https://github.com/localstack/localstack/issues/618
+                 #                   https://github.com/localstack/localstack/issues/549
+-                if 'text/html' in response.headers.get('Content-Type', ''):
++                #                   https://github.com/localstack/localstack/issues/854
++                if 'text/html' in response.headers.get('Content-Type', '') \
++                        and not response_content_str.startswith('<!doctype html'):
+                     response.headers['Content-Type'] = 'application/xml; charset=utf-8'
+ 
+                 reset_content_length = True",should be a case insensitive match though no? DOCTYPE and doctype are both widely used,Why do we need to check for `<!doctype html`?
+941,"@@ -0,0 +1,15 @@
++class AccountWidgetsController < WidgetsController
++  before_action :set_account
++  before_action :render_gif_image
++  before_action :account_context, only: :index
++
++  def index
++    @widgets = AccountWidget.create_widgets(params[:account_id])
++  end
++
++  private
++
++  def set_account
++    @account = Account.from_param(params[:account_id]).first!
++  end
++end",We must have a `fail ParamNotFound` here for cases where `@account.nil?`.,Why do we need this?
+942,"@@ -144,6 +144,7 @@ namespace Datadog.Trace.Vendors.Newtonsoft.Json.Serialization
+             return property;
+         }
+ 
++#if !NETCOREAPP
+         private bool TryGetValue(string key, out JsonProperty item)
+         {
+             if (Dictionary == null)",How come this change was needed?,Why is this needed?
+943,"@@ -25,3 +25,13 @@ const (
+ 	UART_TX_PIN = 6
+ 	UART_RX_PIN = 8
+ )
++
++// ADC pins
++const (
++	ADC0 = 3
++	ADC1 = 4
++	ADC2 = 28
++	ADC3 = 29
++	ADC4 = 30
++	ADC5 = 31
++)","Why are there only 6 pins here, while below it appears to have 8 ADC inputs? Are pin 2 and 5 used for something else on this board?",This should be `UART_ADC_PIN`
+944,"@@ -224,7 +224,9 @@ func (gsf *GraphSyncFetcher) fetchRemainingTipsets(ctx context.Context, starting
+ // non-recursively
+ func (gsf *GraphSyncFetcher) fetchBlocks(ctx context.Context, cids []cid.Cid, targetPeer peer.ID) error {
+ 	selector := gsf.ssb.ExploreFields(func(efsb selectorbuilder.ExploreFieldsSpecBuilder) {
+-		efsb.Insert(""messages"", gsf.ssb.Matcher())
++		efsb.Insert(""messages"", gsf.ssb.ExploreFields(func(messagesSelector selectorbuilder.ExploreFieldsSpecBuilder) {
++			messagesSelector.Insert(""secpRoot"", gsf.ssb.Matcher())
++		}))
+ 		efsb.Insert(""messageReceipts"", gsf.ssb.Matcher())
+ 	}).Node()
+ 	var wg sync.WaitGroup","I think we need an issue to track that chain sync omits BLS messages, and then to fix and test it!",I think this should be `secpRoot`
+945,"@@ -1,7 +1,7 @@
+ C2::Application.configure do
+   config.action_mailer.preview_path = ""#{Rails.root}/lib/mail_previews""
+   config.action_mailer.register_preview_interceptor :css_inline_styler
+-  config.action_mailer.asset_host = ""http://localhost:5000""
++  config.action_mailer.asset_host = ""http://2c429f18.ngrok.io"" || ""http://localhost:5000""
+   config.action_controller.perform_caching = false
+   config.action_mailer.delivery_method = :letter_opener_web
+   config.active_record.migration_error = :page_load",what is this default about? I am not using ngrok atm so would prefer an env var.,Prefer single-quoted strings when
+946,"@@ -93,6 +93,19 @@ return [
+ 
+     'backendSkin' => 'Backend\Skins\Standard',
+ 
++    /*
++    |--------------------------------------------------------------------------
++    | Determines if logging in backend should run UpdateManager
++    |--------------------------------------------------------------------------
++    |
++    | If value is true it runs UpdateMananger after login in backend.
++    | It's recommended to set this value to 'false' in production enviroments
++    | because it cleares cache on every login in backend.
++    |
++    */
++
++    'runUpdateManagerAfterBackendLogin' => true,
++
+     /*
+     |--------------------------------------------------------------------------
+     | Determines which modules to load","@Samuell1 Might be better to say ""Automatically check for plugin updates on login"".",I'm not sure if this is the best 
+947,"@@ -1,4 +1,6 @@
++using System;
+ using System.Diagnostics;
++using System.Runtime.CompilerServices;
+ 
+ namespace Datadog.Trace.Util
+ {",Thanks for the additional Process helper! Can we also cache the first `Process.GetCurrentProcess()` result in a static field so we don't have to repeatedly call it? It means we would also need to dispose it when the static `_runtimeMetricsWriter` instance is disposed,Why is this needed?
+948,"@@ -73,6 +73,19 @@ func (*mockStatsEngine) GetTaskHealthMetrics() (*ecstcs.HealthMetadata, []*ecstc
+ 	return nil, nil, nil
+ }
+ 
++// TestDisableMetrics tests the StartMetricsSession will return immediately if
++// the metrics was disabled
++func TestDisableMetrics(t *testing.T) {
++	params := TelemetrySessionParams{
++		Cfg: &config.Config{
++			DisableMetrics:           true,
++			DisableDockerHealthCheck: true,
++		},
++	}
++
++	StartMetricsSession(params)
++}
++
+ func TestFormatURL(t *testing.T) {
+ 	endpoint := ""http://127.0.0.0.1/""
+ 	wsurl := formatURL(endpoint, testClusterArn, testInstanceArn)","just wondering what is the result of breaking the logic we test here? it seems that in that case we will just not return immediately, but i'm not sure whether the test will fail?",nit: I think it would be better to use `t.Skip` here
+949,"@@ -198,8 +198,9 @@ func TestInferModulePath(t *testing.T) {
+ 					t.Error(err)
+ 				}
+ 			}()
+-
+-			pctx := newTestProcessContext(dir)
++			srcDir := filepath.Join(dir, ""src"")
++			os.Mkdir(srcDir, 0777)
++			pctx := newTestProcessContext(srcDir)
+ 			gopath, cleanup := tc.testGOPATH(dir)
+ 			defer cleanup()
+ 			pctx.env = []string{gopath}",We should fail the test if this returns `err != nil`.,Why is this needed?
+950,"@@ -140,6 +140,9 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c
+ 	}
+ 
+ 	updated = false
++	// Fun extra variable to keep track of whether we should increment metricProvisionFailedTerminal
++	// later; because we only want to do that if (we change that status and) the status update succeeds.
++	provisionFailedTerminal := false
+ 	conditions, updated = controllerutils.SetClusterDeploymentConditionWithChangeCheck(conditions,
+ 		hivev1.ProvisionStoppedCondition,
+ 		stopped.Status,",What is the drawback of not having this flag as a gating condition to report the metric?,I don't think we need this variable. We can just use
+951,"@@ -22,9 +22,14 @@ import (
+ )
+ 
+ func gracefullyStopProcess(pid int) error {
++	fmt.Printf(""Graceful stop..."")
+ 	err := syscall.Kill(pid, syscall.SIGINT)
+ 	if err != nil {
+ 		return fmt.Errorf(""kill: %v"", err)
+ 	}
+ 	return nil
+ }
++
++func getAppName() string {
++	return filepath.Base(os.Args[0])
++}","`getProcessName()` will be less ambiguous, since Caddy has ""apps"" that it runs internally.",Why do we need this?
+952,"@@ -4741,6 +4741,7 @@ const char * const DMLFormats[] =
+     ""<exec cmd=\""!DumpIL /i %s\"">%s</exec>"",         // DML_IL
+     ""<exec cmd=\""!DumpRCW -cw /d %s\"">%s</exec>"",    // DML_ComWrapperRCW
+     ""<exec cmd=\""!DumpCCW -cw /d %s\"">%s</exec>"",    // DML_ComWrapperCCW
++    ""<exec cmd=\""dps %s L2\"">%s</exec>"",             // DML_TaggedMemory (hardcoded current size to 2 pointer sizes)
+ };
+ 
+ void ConvertToLower(__out_ecount(len) char *buffer, size_t len)","Is there any way to not hardcode this given we know the size in bytes? The public API has the flexibility of being a Span. Should we maybe not do anything printing DML? The runtime allocates the buffer, but it's a ""scratch memory"" area, The delegate gets it passed in and they decide how to use it. Also, how is DML used if the feature is for macOS support?","""<exec cmd=\""dps %s L2\"">%s</exec>"", // DML_TaggedMemory (hardcoded current size to 2 pointer sizes)"
+953,"@@ -64,6 +64,13 @@ nebula::cpp2::ErrorCode ScanEdgeProcessor::checkAndBuildContexts(const cpp2::Sca
+   std::vector<cpp2::EdgeProp> returnProps = {*req.return_columns_ref()};
+   ret = handleEdgeProps(returnProps);
+   buildEdgeColName(returnProps);
++  ret = buildFilter(req, [](const cpp2::ScanEdgeRequest& r) -> const std::string* {
++    if (r.filter_ref().has_value()) {
++      return r.get_filter();
++    } else {
++      return nullptr;
++    }
++  });
+   return ret;
+ }
+ ",How about just override the `buildFilter`? Passing another function here is a little weird.,Why do we need a lambda here? Can't we just return `r.get_filter()`?
+954,"@@ -71,8 +71,9 @@ var (
+ 
+ 	ignoredPackages = app.Flag(""ignored-packages"", ""Space separated list of specs ignoring rebuilds if their dependencies have been updated. Will still build if all of the spec's RPMs have not been built."").String()
+ 
+-	pkgsToBuild   = app.Flag(""packages"", ""Space separated list of top-level packages that should be built. Omit this argument to build all packages."").String()
+-	pkgsToRebuild = app.Flag(""rebuild-packages"", ""Space separated list of base package names packages that should be rebuilt."").String()
++	pkgsToBuild     = app.Flag(""packages"", ""Space separated list of top-level packages that should be built. Omit this argument to build all packages."").String()
++	pkgsToRebuild   = app.Flag(""rebuild-packages"", ""Space separated list of base package names packages that should be rebuilt."").String()
++	rpmHydratedTest = app.Flag(""rpm-hydrated-test"", ""Is this just a TestRPM build with all RPMs hydrated?"").String()
+ 
+ 	logFile  = exe.LogFileFlag(app)
+ 	logLevel = exe.LogLevelFlag(app)","This should just be a `.Bool()` flag I think, we don't encode anything beyond y/n here. See `$(RUN_CHECK)` and `$(STOP_ON_PKG_FAIL)` for examples of how to pass those in.",I think this should be `--rpm-hydrated-test`.
+955,"@@ -2042,6 +2042,7 @@ bool SwiftLanguageRuntime::GetDynamicTypeAndAddress_Promise(
+     address.SetLoadAddress(val_ptr_addr, &m_process->GetTarget());
+     return true;
+   } break;
++  case swift::MetadataKind::Function:
+   case swift::MetadataKind::Optional:
+   case swift::MetadataKind::Struct:
+   case swift::MetadataKind::Tuple: {",Is this needed?,Why is this needed?
+956,"@@ -348,7 +348,7 @@ export default Ember.Controller.extend(BillingCategories, EKMixin,
+       confirmDeleteValue(value) {
+         let i18n = this.get('i18n');
+         let title = i18n.t('admin.lookup.titles.deleteLookupValue');
+-        let message = i18n.t('admin.lookup.messages.deleteLookupValue', { value });
++        let message = i18n.t('messages.delete_singular', { name: value.concat(' value') });
+         this.displayConfirm(title, message, 'deleteValue', Ember.Object.create({
+           valueToDelete: value
+         }));",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,I don't think you need the `.concat` here.
+957,"@@ -18,6 +18,8 @@ package container
+ import (
+ 	""context""
+ 
++	""github.com/chaos-mesh/chaos-mesh/pkg/selector/generic""
++
+ 	""go.uber.org/fx""
+ 	v1 ""k8s.io/api/core/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""",how about moving it under L26,"""github.com/go-test/deep"""
+958,"@@ -0,0 +1,17 @@
++/**
++ * Memoize a function.
++ * @method memoize
++ * @memberof axe.utils
++ * @param {Function} fn Function to memoize
++ * @return {Function}
++ */
++axe._memoizedFns = [];
++axe.utils.memoize = function(fn) {
++	// keep track of each function that is memoized so it can be cleared at
++	// the end of a run. each memoized function has its own cache, so there is
++	// no method to clear all memoized caches. instead, we have to clear each
++	// individual memoized function ourselves.
++	const memoized = axe.imports.memoize(fn);
++	axe._memoizedFns.push(memoized);
++	return memoized;
++};",I think this needs to be tested,I think this should be `axe.imports.memoiz
+959,"@@ -2,6 +2,9 @@ class Trail < ApplicationRecord
+   extend FriendlyId
+ 
+   include PgSearch
++
++  DEFAULT_IMAGE_URL = ""https://images.thoughtbot.com/upcase/trail-title-cards/default.jpg""
++
+   multisearchable against: [:name, :description], if: :published?
+ 
+   validates :name, :description, presence: true",Style/MutableConstant: Freeze mutable objects assigned to constants.,I think this should be `default_image_url`
+960,"@@ -155,16 +155,15 @@ public final class DeflateWithPresetDictCompressionMode extends CompressionMode
+ 
+   private static class DeflateWithPresetDictCompressor extends Compressor {
+ 
+-    final byte[] dictBytes;
+-    final int blockLength;
++    private final int dictLength, blockLength;
+     final Deflater compressor;
+     byte[] compressed;
+     boolean closed;
+ 
+     DeflateWithPresetDictCompressor(int level, int dictLength, int blockLength) {
+-      compressor = new Deflater(level, true);
++      compressor = BugfixDeflater_JDK8252739.createDeflaterInstance(level, true, dictLength);
+       compressed = new byte[64];
+-      this.dictBytes = new byte[dictLength];
++      this.dictLength = dictLength;
+       this.blockLength = blockLength;
+     }
+ ","Just a thought, really. If it's a bug that can be probed for (and it can be - see Adrian's repro) then it could as well be a static initialization of a supplier of Deflater instances; if we probe for a buggy JVM, we return the wrapper. If we don't we return the Deflater. This way on non-affected JVMs nothing happens and if we do use the wrapper, we know the JVM is broken.",nit: `dictLength` -> `dictionaryLength`
+961,"@@ -95,7 +95,7 @@ public class FSTTester<T> {
+     return br;
+   }
+ 
+-  static String getRandomString(Random random) {
++  public static String getRandomString(Random random) {
+     final String term;
+     if (random.nextBoolean()) {
+       term = TestUtil.randomRealisticUnicodeString(random);",Looks like this should be publicly accessible for tests in any modules?,why is this public?
+962,"@@ -19,7 +19,7 @@ if (is_array($env = @include dirname(__DIR__).'/.env.local.php')) {
+     throw new RuntimeException('Please run ""composer require symfony/dotenv"" to load the "".env"" files configuring the application.');
+ } else {
+     $path = dirname(__DIR__).'/.env';
+-    $dotenv = new Dotenv(false);
++    $dotenv = new Dotenv(true);
+ 
+     // load all the .env files
+     if (method_exists($dotenv, 'loadEnv')) {",Allow putenv is necessary to be able to get environment variables with `getenv`?,this should be reverted
+963,"@@ -0,0 +1,17 @@
++#include <iostream>
++#include <conio.h>
++using namespace std;
++
++int main()
++{	
++	int year;
++	cout<<""Enter year to check\n"";
++	cin>>year;
++	if((year%4==0 && year%100!=0) || year%400==0){
++		cout<<""leap year.\n"";
++	}
++	else{
++		cout<<"" Not leap year.\n"";
++	}
++	return 0;
++}",use function to check it. - don't do everything in main,Add a new line at the EOF
+964,"@@ -50,7 +50,7 @@ class BaseRulesEngine(object):
+         self.full_rules_path = rules_file_path.strip()
+         self.snapshot_timestamp = snapshot_timestamp
+ 
+-    def build_rule_book(self):
++    def build_rule_book(self, global_configs):
+         """"""Build RuleBook from the rules definition file.""""""
+         raise NotImplementedError('Implement in a child class.')
+ ",Sorry I'm confused. Why not kwarg this like the others?,`global_configs` is not used.
+965,"@@ -7171,15 +7171,15 @@ const instr_info_t vex_W_extensions[][2] = {
+      * registers are identical.  We don't bother trying to detect that.
+      */
+     {OP_vpgatherdd,0x66389018,""vpgatherdd"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+-    {OP_vpgatherdq,0x66389058,""vpgatherdq"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vpgatherdq,0x66389058,""vpgatherdq"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 67 */
+-    {OP_vpgatherqd,0x66389118,""vpgatherqd"",Vx,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vpgatherqd,0x66389118,""vpgatherqd"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+     {OP_vpgatherqq,0x66389158,""vpgatherqq"",Vx,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 68 */
+     {OP_vgatherdps,0x66389218,""vgatherdps"",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+-    {OP_vgatherdpd,0x66389258,""vgatherdpd"",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vgatherdpd,0x66389258,""vgatherdpd"",Vvd,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 69 */
+-    {OP_vgatherqps,0x66389318,""vgatherqps"",Vvs,Hx,MVd,Hx,xx, mrm|vex|reqp,x,END_LIST},
++    {OP_vgatherqps,0x66389318,""vgatherqps"",Vvs,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+     {OP_vgatherqpd,0x66389358,""vgatherqpd"",Vvd,Hx,MVq,Hx,xx, mrm|vex|reqp,x,END_LIST},
+   }, { /* vex_W_ext 70 */
+     {OP_vpmaskmovd,0x66388c18,""vpmaskmovd"",Vx,xx,Hx,Mx,xx, mrm|vex|reqp|predcx,x,tvexw[71][0]},","First, any changes here should be synchronized with instr_compute_VSIB_index(). Second, the original looks correct to me: the first letter of the opcode name suffix is the index size, while the second is the memory size. So ""vpgatherdq"" is a d-sized index and q-sized memory. The operand size we store for memory accesses is always the memory size, not the address size, and for VSIB we store a single memory element size. It looks like we have no inside-opnd_t storage of the index size: that's done by dispatch on opcode it seems. I have a bunch of notes of discussions on how to handle VSIB: we decided to bail on encoding too much inside the opnd_t I guess.",Why did you change this?
+966,"@@ -118,6 +118,9 @@ class ExternalProgramTask(luigi.Task):
+         file_object.seek(0)
+         return ''.join(map(lambda s: s.decode('utf-8'), file_object.readlines()))
+ 
++    def build_tracking_url(self, logs_output):
++        return logs_output
++
+     def run(self):
+         args = list(map(str, self.program_args()))
+ ",Sorry for going back and forth. Adding docstring here would be very helpful for others to understand the need of this method.,Why do we need this method?
+967,"@@ -121,10 +121,7 @@ bool Creature::canSee(const Position& pos) const
+ 
+ bool Creature::canSeeCreature(const Creature* creature) const
+ {
+-	if (!canSeeInvisibility() && creature->isInvisible()) {
+-		return false;
+-	}
+-	return true;
++	return canSeeInvisibility() && creature->isInvisible();
+ }
+ 
+ void Creature::setSkull(Skulls_t newSkull)",You introduced a bug here.,why did you remove this?
+968,"@@ -261,6 +261,14 @@ namespace Microsoft.DotNet.Build.Tasks.VersionTools
+                 ""true"",
+                 StringComparison.OrdinalIgnoreCase);
+ 
++            string oldValue = step.GetMetadata(""ReplacementSubstituteOld"");
++            string newValue = step.GetMetadata(""ReplacementSubstituteNew"");
++
++            if (!string.IsNullOrEmpty(oldValue) && !string.IsNullOrEmpty(newValue))
++            {
++                updater.ReplacementTransform = v => v.Replace(oldValue, newValue);
++            }
++
+             return updater;
+         }
+ ",Should we log a warning/error if only one is specified and not the other?,">v => v.Replace(oldValue, newValue); [](start = 12, length = 36) I think this should be `v => v.Replace(oldValue, newValue);`"
+969,"@@ -463,4 +463,15 @@ func (c *fakeClient) ReportApplicationLiveStateEvents(ctx context.Context, req *
+ 	return &pipedservice.ReportApplicationLiveStateEventsResponse{}, nil
+ }
+ 
++func (c *fakeClient) GetLatestEvent(ctx context.Context, req *pipedservice.GetLatestEventRequest, opts ...grpc.CallOption) (*pipedservice.GetLatestEventResponse, error) {
++	c.logger.Info(""fake client received GetLatestEvent rpc"", zap.Any(""request"", req))
++	return &pipedservice.GetLatestEventResponse{
++		Event: &model.Event{
++			Id:        ""dev"",
++			Name:      ""dev"",
++			ProjectId: ""dev"",
++		},
++	}, nil
++}
++
+ var _ pipedservice.PipedServiceClient = (*fakeClient)(nil)",`ctx` is unused in GetLatestEvent,Why do we need this?
+970,"@@ -128,6 +128,14 @@ void nano_daemon::daemon::run (boost::filesystem::path const & data_path, nano::
+ 				logger.always_log (boost::format (""Open file descriptors limit is %1%"") % file_descriptor_limit);
+ 			}
+ 
++			// a 0-valued port means for the node 'let the OS decide'; however, for the daemon start up, if
++			// the user hasn't specified a port in the config, we must use the default peering port for the network
++			//
++			if (!config.node.peering_port)
++			{
++				config.node.peering_port = network_params.network.default_node_port;
++			}
++
+ 			auto node (std::make_shared<nano::node> (io_ctx, data_path, config.node, opencl_work, flags));
+ 			if (!node->init_error ())
+ 			{","This looks good to me. Personally, I would have the following for maximum flexibility: * convert peering_port from uint64_t to int. * Set the default value to ""-1"" to specify the value is not set * if the value is -1 then do `config.node.peering_port = network_params.network.default_node_port` That would allow for 0 to mean, select the port number yourself and be more consistent. But I am happy with the change as is, as well.",Shouldn't this be `config.node.default_node_port`?
+971,"@@ -10,7 +10,6 @@ __all__ = [
+ 
+ class ImageTransform(object):
+     """"""Preprocess an image.
+-
+     1. rescale the image to expected size
+     2. normalize the image
+     3. flip the image (if needed)",The blank line between the summary and detailed description is better to be kept.,Why did you remove this?
+972,"@@ -167,6 +167,11 @@ func (a *API) Setup() {
+ 	a.setMetadataEndpointsKey()
+ 	a.writeShapeNames()
+ 	a.resolveReferences()
++
++	if !a.NoRemoveUnusedShapes {
++		a.removeUnusedShapes()
++	}
++
+ 	a.fixStutterNames()
+ 	a.renameExportable()
+ 	a.applyShapeNameAliases()","Curiously, are these indents intended or should they be aligned?",Why is this needed?
+973,"@@ -1130,7 +1130,9 @@ def getControlFieldSpeech(attrs,ancestorAttrs,fieldType,formatConfig=None,extraD
+ 	else:
+ 		tableID = None
+ 
+-	roleText=getSpeechTextForProperties(reason=reason,role=role)
++	roleText=attrs.get('roleText')
++	if not roleText:
++		roleText=getSpeechTextForProperties(reason=reason,role=role)
+ 	stateText=getSpeechTextForProperties(reason=reason,states=states,_role=role)
+ 	keyboardShortcutText=getSpeechTextForProperties(reason=reason,keyboardShortcut=keyboardShortcut) if config.conf[""presentation""][""reportKeyboardShortcuts""] else """"
+ 	ariaCurrentText=getSpeechTextForProperties(reason=reason,current=ariaCurrent)","What if we changed this to this? roleText=attrs.get('roleText', lambda:getSpeechTextForProperties(reason=reason,role=role)) That will prevent the function from ever needing called in the roletext case, and removes that if.",Why do we need this
+974,"@@ -4801,7 +4801,15 @@ master_signal_handler_C(byte *xsp)
+         return;
+     }
+ #endif
+-    dcontext_t *dcontext = get_thread_private_dcontext();
++    /* We avoid using safe_read_tls_magic during detach. This thread may already have
++     * lost its TLS. A safe read may result into a race affecting asynchronous non-alarm
++     * signals (xref i#3535) between delivering the SIGSEGV and restoring the app's signal
++     * handlers. We don't need the thread's private dcontext anymore here at this point.
++     * Note that there is still a small race window if the signal gets delivered after the
++     * detach has finished, i.e. doing_detach is false. This is an issue in particular if
++     * the app has started re-attaching.
++     */
++    dcontext_t *dcontext = doing_detach ? NULL : get_thread_private_dcontext();
+ 
+ #ifdef MACOS
+ #    ifdef X64",This will still result in a safe_read_tls_magic on AMD in tls_thread_preinit().,I don't think this 
+975,"@@ -561,5 +561,4 @@ public class TestJdbcCatalog {
+     String nsString = JdbcUtil.namespaceToString(ns);
+     Assert.assertEquals(ns, JdbcUtil.stringToNamespace(nsString));
+   }
+-
+ }",Can you remove this change?,Why was this remove
+976,"@@ -48,7 +48,7 @@ func ValidateCertificateForACMEIssuer(crt *cmapi.CertificateSpec, issuer *cmapi.
+ 	el := field.ErrorList{}
+ 
+ 	if crt.IsCA {
+-		el = append(el, field.Invalid(specPath.Child(""isCA""), crt.KeyAlgorithm, ""ACME does not support CA certificates""))
++		el = append(el, field.Invalid(specPath.Child(""isCA""), crt.IsCA, ""ACME does not support CA certificates""))
+ 	}
+ 
+ 	if crt.Subject != nil && len(crt.Subject.Organizations) != 0 {","Oh, was that a bug in the validation?","I think this should be `crt.IsCA || crt.KeyAlgorithm != """"`"
+977,"@@ -134,6 +134,10 @@ public class OnlineFeedViewActivity extends AppCompatActivity {
+         } else {
+             Log.d(TAG, ""Activity was started with url "" + feedUrl);
+             setLoadingLayout();
++            //Remove subscribeonandroid.com from feed URL in order to subscribe to the actual feed URL
++            if(feedUrl.contains(""subscribeonandroid.com"")){
++                feedUrl = feedUrl.replaceFirst(""((www.)?(subscribeonandroid.com/))"","""");
++            }
+             if (savedInstanceState == null) {
+                 startFeedDownload(feedUrl, null, null);
+             } else {","Please use the Google java code style. Basically, add more space characters like in the statements below. Next to method arguments and curly braces. This is currently not checked on CI because it is too inconsistent in the code base but I would prefer new code to be consistent.",I don't think you need the `if` statement here.
+978,"@@ -145,10 +145,12 @@ TEST(UpdateEdgeTest, Set_Filter_Yield_Test) {
+     decltype(req.return_columns) tmpColumns;
+     tmpColumns.emplace_back(Expression::encode(val1));
+     tmpColumns.emplace_back(Expression::encode(val2));
+-    std::string name = folly::to<std::string>(3002);
+-    std::string prop = ""tag_3002_col_2"";
+-    auto* sourcePropExp = new SourcePropertyExpression(&name, &prop);
++    delete val1;
++    delete val2;
++    auto* sourcePropExp = new SourcePropertyExpression(
++        new std::string(folly::to<std::string>(3002)), new std::string(""tag_3002_col_2""));
+     tmpColumns.emplace_back(Expression::encode(sourcePropExp));
++    delete sourcePropExp;
+ 
+     req.set_return_columns(std::move(tmpColumns));
+     req.set_insertable(false);","Actually, I don't think we need to create object on heap.",Why do we need to delete these?
+979,"@@ -84,7 +84,7 @@ void GenerateImports(grpc_generator::File *file, grpc_generator::Printer *printe
+ 	}
+ 	printer->Print(""import (\n"");
+ 	printer->Indent();
+-	printer->Print(vars, ""$context$ \""golang.org/x/net/context\""\n"");
++	printer->Print(vars, ""$context$ \""context\""\n"");
+ 	printer->Print(vars, ""$grpc$ \""google.golang.org/grpc\""\n"");
+ 	printer->Outdent();
+ 	printer->Print("")\n\n"");","this is a file we copy from gRPC, sp ideally it be fixed upstream as well..",Why this change?
+980,"@@ -14,7 +14,6 @@
+ package zipkin2.storage.cassandra.v1;
+ 
+ import com.datastax.driver.core.Session;
+-import com.google.common.cache.CacheBuilderSpec;
+ import java.nio.ByteBuffer;
+ import java.util.ArrayList;
+ import java.util.LinkedHashSet;","changes like this, just strangle guava usages to be replaced by DelayLimiter into one place",Why was this removed?
+981,"@@ -27,8 +27,8 @@ const Widget = ( {
+ 	className,
+ 	slug,
+ 	noPadding,
+-	header: Header,
+-	footer: Footer,
++	Header,
++	Footer,
+ } ) => {
+ 	return (
+ 		<div","PropTypes need to be updated accordingly here. Note that the type also needs updating, not just the case. That is, these should both expect a `PropTypes.elementType` now instead of an `element`.",Why did you remove th
+982,"@@ -221,7 +221,7 @@ int get_ctest_gpu(const char* local_rank_str) {
+   }
+ 
+   auto const* comma = std::strchr(resource_str, ',');
+-  if (!comma || strncmp(resource_str, ""id:"", 3)) {
++  if (!comma || strncmp(resource_str, ""id:"", 3) != 0) {
+     std::ostringstream ss;
+     ss << ""Error: invalid value of "" << ctest_resource_group_id_name << "": '""
+        << resource_str << ""'. Raised by Kokkos::Impl::get_ctest_gpu()."";",maybe extra paren around `strncmp(...) != 0`,Why did you change th
+983,"@@ -510,6 +510,8 @@ public class Windows implements TrayListener, TopBarWidget.Delegate, TitleBarWid
+ 
+         TelemetryWrapper.resetOpenedWindowsCount(mRegularWindows.size(), false);
+         TelemetryWrapper.resetOpenedWindowsCount(mPrivateWindows.size(), true);
++        GleanMetricsService.resetOpenedWindowsCount(mRegularWindows.size(), false);
++        GleanMetricsService.resetOpenedWindowsCount(mPrivateWindows.size(), true);
+     }
+ 
+     public boolean isPaused() {",We should call `Windows.onResume `: - When the app is launched for the first time - When the app is resumed after being paused (home button and resume or device goes to sleep) - After a permission prompt is displayed,Do we need to call `r
+984,"@@ -31,7 +31,7 @@ import java.util.function.Function;
+ 
+ import com.google.common.annotations.VisibleForTesting;
+ 
+-public class BftForksSchedule<C extends BftConfigOptions> {
++public class BftForksSchedule<C> {
+ 
+   private final NavigableSet<ForkSpec<C>> forks =
+       new TreeSet<>(",Rename to ForksSchedule? Maybe in separate PR.,Why did you change this?
+985,"@@ -1,11 +1,12 @@
+-import pytest
+ import time
+ from unittest import mock
+ 
++import pytest
++
+ from pyramid import testing
+ 
+-from kinto.core.storage import exceptions
+ from kinto.core.cache import heartbeat
++from kinto.core.storage import exceptions
+ 
+ 
+ class CacheTest:",Why a blank line here?,Why this change?
+986,"@@ -14,6 +14,10 @@ class Subscription < ActiveRecord::Base
+     notifier.send_notifications
+   end
+ 
++  def active?
++    deactivated_on.nil?
++  end
++
+   private
+ 
+   def self.subscriber_emails","I have a sense that this will actually eventually change to check the actual date so that subscriptions can be deactivated in the future. But I mention that here just to keep you in the loop. We should not make that change now, because it's not needed functionality.",Why do we need this meth
+987,"@@ -36,6 +36,10 @@ public class EnvironmentVariableDefaultProvider implements IDefaultValueProvider
+ 
+   @Override
+   public String defaultValue(final ArgSpec argSpec) {
++    if (!argSpec.isOption()) {
++      return null; // skip default for positional params
++    }
++
+     return envVarNames((OptionSpec) argSpec)
+         .map(environment::get)
+         .filter(Objects::nonNull)",What is the reasoning for using the negation of `isOption()` instead of simply using `isPositional()` to identify a positional param?,nit: `return null; // sk
+988,"@@ -1415,7 +1415,13 @@ void ProtocolGame::sendBasicData()
+ 		msg.addByte(0);
+ 		msg.add<uint32_t>(0);
+ 	}
++
+ 	msg.addByte(player->getVocation()->getClientId());
++
++	if (version >= 1100) {
++		msg.addByte(player->getVocation()->getId() != VOCATION_NONE ? 0x01 : 0x00); // prey data
++	}
++
+ 	msg.add<uint16_t>(0xFF); // number of known spells
+ 	for (uint8_t spellId = 0x00; spellId < 0xFF; spellId++) {
+ 		msg.addByte(spellId);",Why would you add those if client version min is set to 1100?,This should be `version >= 1100 && player->getVocation()->getId()`
+989,"@@ -7,12 +7,13 @@
+ package snapshotsync
+ 
+ import (
++	reflect ""reflect""
++	sync ""sync""
++
+ 	proto ""github.com/golang/protobuf/proto""
+ 	protoreflect ""google.golang.org/protobuf/reflect/protoreflect""
+ 	protoimpl ""google.golang.org/protobuf/runtime/protoimpl""
+ 	emptypb ""google.golang.org/protobuf/types/known/emptypb""
+-	reflect ""reflect""
+-	sync ""sync""
+ )
+ 
+ const (","You can delete this, it will now need to live in `gointerfaces` package",Why did you change these?
+990,"@@ -3,7 +3,7 @@
+   <%= render 'previous_next_doc' %>
+ 
+    
+-<% @page_title = t('blacklight.search.show.title', :document_title => document_show_html_title, :application_name => application_name) -%>
++<% @page_title = t('blacklight.search.show.title', :document_title => document_show_html_title, :application_name => application_name).html_safe -%>
+ <% content_for(:head) { render_link_rel_alternates } -%>
+ <%# this should be in a partial -%>
+ ","Okay, I still don't understand why you have to add `html_safe` here, and it still seems like a very bad idea. It will allow html tags in the title, and keep Rails from escaping literal greater-than or less-than chars not intended as HTML tags. It ought to work to just let Rails do HTML-escaing as normal, without any manual `html_safe` or `strip_tags` or whatever. I am not clear on what problem you are trying to solve, why the straightfoward approach does not work.",<% @page_title = @page_title.html_safe -%>
+991,"@@ -1435,6 +1435,8 @@ public class MessageList extends K9Activity implements MessageListFragmentListen
+     public void displayMessageSubject(String subject) {
+         if (mDisplayMode == DisplayMode.MESSAGE_VIEW) {
+             mActionBarSubject.setText(subject);
++        } else {
++            mActionBarSubject.showSubjectInMessageHeader();
+         }
+     }
+ ",What is is subject when it's not the email subject. Why are we having to do this crap? What's calling this with an empty string?,Why do we need this?
+992,"@@ -65,7 +65,7 @@ func NewProvider(opts ...ProviderOption) (*Provider, error) {
+ 		namedTracer: make(map[string]*tracer),
+ 	}
+ 	tp.config.Store(&Config{
+-		DefaultSampler:       ProbabilitySampler(defaultSamplingProbability),
++		DefaultSampler:       AlwaysSample(),
+ 		IDGenerator:          defIDGenerator(),
+ 		MaxAttributesPerSpan: DefaultMaxAttributesPerSpan,
+ 		MaxEventsPerSpan:     DefaultMaxEventsPerSpan,",Could you also remove the `defaultSamplingProbability` constant from `sampling.go`? It seems to became unused with this change.,Why did you change this?
+993,"@@ -63,9 +63,9 @@ func (s *svc) UpdateDeployment(ctx context.Context, clientset, cluster, namespac
+ 	}
+ 
+ 	newDeployment := oldDeployment.DeepCopy()
+-	mergeLabelsAndAnnotations(newDeployment, fields)
++	mergeDeploymentLabelsAndAnnotations(newDeployment, fields)
+ 
+-	patchBytes, err := generateDeploymentStrategicPatch(oldDeployment, newDeployment)
++	patchBytes, err := GenerateStrategicPatch(oldDeployment, newDeployment, appsv1.Deployment{})
+ 	if err != nil {
+ 		return err
+ 	}",can you delete the `generateDeploymentStrategicPatch` function as well?,Why is this empty?
+994,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+ 
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+ 
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...,Why is this change neede
+995,"@@ -50,6 +50,10 @@ StatusOr<OptRule::TransformResult> LimitPushDownRule::transform(
+   const auto proj = static_cast<const Project *>(projGroupNode->node());
+   const auto gn = static_cast<const GetNeighbors *>(gnGroupNode->node());
+ 
++  DCHECK(graph::ExpressionUtils::isEvaluableExpr(limit->countExpr()));
++  if (!graph::ExpressionUtils::isEvaluableExpr(limit->countExpr())) {
++    return TransformResult::noTransform();
++  }
+   int64_t limitRows = limit->offset() + limit->count();
+   if (gn->limit() >= 0 && limitRows >= gn->limit()) {
+     return TransformResult::noTransform();",Don't use DCHECK to debug your code if it's the regular branch you need to handle.,Why do we need this chec
+996,"@@ -46,11 +46,6 @@ public interface AntlrNode extends Node {
+         throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");
+     }
+ 
+-    @Override
+-    default String getImage() {
+-        throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");
+-    }
+-
+     @Override
+     default void setImage(final String image) {
+         throw new UnsupportedOperationException(""Out of scope for antlr current implementations"");",You should return null here instead. Null is an acceptable default value for the image attribute.,Why was this removed?
+997,"@@ -246,9 +246,14 @@ export function useErrorBoundary(cb) {
+ function flushAfterPaintEffects() {
+ 	afterPaintEffects.some(component => {
+ 		if (component._parentDom) {
+-			component.__hooks._pendingEffects.forEach(invokeCleanup);
+-			component.__hooks._pendingEffects.forEach(invokeEffect);
+-			component.__hooks._pendingEffects = [];
++			try {
++				component.__hooks._pendingEffects.forEach(invokeCleanup);
++				component.__hooks._pendingEffects.forEach(invokeEffect);
++				component.__hooks._pendingEffects = [];
++			} catch (e) {
++				options._catchError(e, component._vnode);
++				return true;
++			}
+ 		}
+ 	});
+ 	afterPaintEffects = [];",react bails as well?,Why do we need this?
+998,"@@ -7,7 +7,6 @@ namespace Shopsys\FrameworkBundle\Model\Security;
+ class Roles
+ {
+     public const ROLE_ADMIN = 'ROLE_ADMIN';
+-    public const ROLE_ADMIN_AS_CUSTOMER = 'ROLE_ADMIN_AS_CUSTOMER';
+     public const ROLE_LOGGED_CUSTOMER = 'ROLE_LOGGED_CUSTOMER';
+     public const ROLE_SUPER_ADMIN = 'ROLE_SUPER_ADMIN';
+ ",Can you please tell me why you did this?,Why was this removed?
+999,"@@ -168,9 +168,12 @@ module.exports = class Webcam extends Plugin {
+       this.opts.modes.indexOf('video-only') !== -1 ||
+       this.opts.modes.indexOf('picture') !== -1
+ 
++    const videoConstraints = this.opts.videoConstraints ?? {}
++    videoConstraints.facingMode = this.opts.facingMode
++
+     return {
+       audio: acceptsAudio,
+-      video: acceptsVideo ? { facingMode: this.opts.facingMode } : false
++      video: acceptsVideo ? videoConstraints : false
+     }
+   }
+ ",Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set,Why do we need this c
+1000,"@@ -1,7 +1,10 @@
+ class Video < ActiveRecord::Base
++  extend FriendlyId
++
+   belongs_to :watchable, polymorphic: true
+ 
+   validates :published_on, presence: true
++  validates :slug, presence: true, uniqueness: true
+   validates :title, presence: true
+   validates :watchable_id, presence: true
+   validates :watchable_type, presence: true",There's a good bit of class-level stuff that's repeated in our various product types. Think it's worth extracting a...dare I say it...module?,Shouldn't this be `slug`?
+1001,"@@ -79,7 +79,10 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(Buil
+ 	// keep functions interoperable, pass int64 types as pointers to
+ 	// stack-allocated values.
+ 	// Use -wasm-abi=generic to disable this behaviour.
+-	if config.Options.WasmAbi == ""js"" && strings.HasPrefix(config.Triple(), ""wasm"") {
++	if config.Options.WasmAbi != """" {
++		config.Target.WasmAbi = config.Options.WasmAbi
++	}
++	if config.Target.WasmAbi == ""js"" {
+ 		err := transform.ExternalInt64AsPtr(mod)
+ 		if err != nil {
+ 			return err","Please do not modify the `config.Target` field, it should contain exactly what is extracted from the JSON files. Instead, you can either: * Add a getter to the `config` variable (`*compileopts.Config`), so you can simply call `config.WasmAbi()` to get the value. * Use a local variable instead. The getter would be slightly cleaner, as it matches the pattern of other configurations (`CGO_ENABLED`, `GC`, `NeedsStackObjects`, etc).",Why do we need this chang
+1002,"@@ -159,6 +159,14 @@ func newTestEnv(inboundOptions []InboundOption, outboundOptions []OutboundOption
+ 	testRouter := newTestRouter(procedures)
+ 
+ 	t := NewTransport()
++	if err := t.Start(); err != nil {
++		return nil, err
++	}
++	defer func() {
++		if err != nil {
++			err = multierr.Append(err, t.Stop())
++		}
++	}()
+ 
+ 	listener, err := net.Listen(""tcp"", ""127.0.0.1:0"")
+ 	if err != nil {",The nil check is not necessary for these. Append checks both sides for nil.,Shouldn't this be `multie
+1003,"@@ -62,6 +62,7 @@ func main() {
+ 			trace.WithAttributes(attrs...),
+ 			trace.ChildOf(spanCtx),
+ 		)
++		span.SetAttributes(entries...)
+ 		defer span.End()
+ 
+ 		span.AddEvent(ctx, ""handling this..."")","Shouldn't we instead have the SDK apply these, internally? I.e., I would expect to see the dctx entries included in the span as first-class distributed correlations, not as span attributes.",Why do we need this?
+1004,"@@ -60,5 +60,12 @@ func (t *topologyAPI) GetTopology(ctx context.Context, req *topologyv1.GetTopolo
+ }
+ 
+ func (t *topologyAPI) SearchTopology(ctx context.Context, req *topologyv1.SearchTopologyRequest) (*topologyv1.SearchTopologyResponse, error) {
+-	return nil, errors.New(""not implemented"")
++	resources, err := t.topology.SearchTopology(ctx, req)
++	if err != nil {
++		return nil, err
++	}
++
++	return &topologyv1.SearchTopologyResponse{
++		Resources: resources,
++	}, nil
+ }",nit: rename this in proto and update impl to `Search` to avoid stutter,Why not return an error here?
+1005,"@@ -78,7 +78,8 @@ class SliderController extends AdminBaseController
+             ->from(SliderItem::class, 's')
+             ->where('s.domainId = :selectedDomainId')
+             ->setParameter('selectedDomainId', $this->adminDomainTabsFacade->getSelectedDomainId())
+-            ->orderBy('s.position');
++            ->orderBy('s.position')
++            ->addOrderBy('s.id');
+         $dataSource = new QueryBuilderDataSource($queryBuilder, 's.id');
+ 
+         $grid = $this->gridFactory->create('sliderItemList', $dataSource);",is it necessary to order by id as a second ordering? this will take place only when several new slider items are created without reordering (position is then null). Wouldn't be better to recalculate position after creating a new item? (right now items with null in position behave differently in administration and on frontend),Why is this needed?
+1006,"@@ -18,8 +18,10 @@ import (
+ )
+ 
+ var (
+-	claimFromRewardingFundBaseGas    = uint64(10000)
+-	claimFromRewardingFundGasPerByte = uint64(100)
++	// ClaimFromRewardingFundBaseGas represents the base intrinsic gas for claimFromRewardingFund
++	ClaimFromRewardingFundBaseGas = uint64(10000)
++	// ClaimFromRewardingFundGasPerByte represents the claimFromRewardingFund payload gas per uint
++	ClaimFromRewardingFundGasPerByte = uint64(100)
+ )
+ 
+ // ClaimFromRewardingFund is the action to claim reward from the rewarding fund",`ClaimFromRewardingFundBaseGas` is a global variable (from `gochecknoglobals`),Why is this change needed?
+1007,"@@ -89,9 +89,11 @@ namespace RDKit {
+   }
+   PyObject *GetSubstructMatch(const ROMol &mol, const ROMol &query,bool useChirality=false,
+                             bool useQueryQueryMatches=false){
+-    NOGIL gil;
+     MatchVectType matches;
+-    SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);
++    {
++      NOGIL gil;
++      SubstructMatch(mol,query,matches,true,useChirality,useQueryQueryMatches);
++    }
+     return convertMatches(matches);
+   }
+ ",How about modifying the NOGIL definition so that it only does anything if the thread safety flag (RDK_BUILD_THREADSAFE_SSS) is set?,Why is this needed?
+1008,"@@ -29,6 +29,11 @@ type chainState interface {
+ 	LatestState(ctx context.Context) (state.Tree, error)
+ }
+ 
++// BlockTimer defines a interface to a struct that can give the current block height.
++type BlockTimer interface {
++	BlockHeight() (uint64, error)
++}
++
+ // PublishFunc is a function the Sender calls to publish a message to the network.
+ type PublishFunc func(topic string, data []byte) error
+ ",blockheighter would be more clear,Why do we need this interface?
+1009,"@@ -949,5 +949,15 @@ void OptimizerUtils::copyIndexScanData(const nebula::graph::IndexScan* from,
+   to->setFilter(from->filter() == nullptr ? nullptr : from->filter()->clone());
+ }
+ 
++Status OptimizerUtils::compareAndSwapBound(std::pair<Value, bool>& a, std::pair<Value, bool>& b) {
++  if (a.first > b.first) {
++    std::swap(a, b);
++  } else if (a.first < b.first) {  // do nothing
++  } else if (a.second > b.second) {
++    std::swap(a, b);
++  }
++  return Status::OK();
++}
++
+ }  // namespace graph
+ }  // namespace nebula",This is so weird as a utility function.,why do we need this?
+1010,"@@ -58,7 +58,8 @@ func TestPlanQuery(t *testing.T) {
+ 		return m
+ 	}
+ 
+-	cmpopt := cmp.AllowUnexported(dynamodb.ScanInput{}, dynamodb.QueryInput{}, dynamodb.AttributeValue{})
++	// Ignores the ConsistentRead field from both QueryInput and ScanInput.
++	cmpopt := cmp.FilterPath(func(p cmp.Path) bool { return p.Last().String() == "".ConsistentRead"" }, cmp.Ignore())
+ 
+ 	for _, test := range []struct {
+ 		desc string",Why? What would happen if you did not?,Why is this needed?
+1011,"@@ -752,7 +752,9 @@ public class SmartStore  {
+         String[] pathElements = path.split(""[.]"");
+         Object o = soup;
+         for (String pathElement : pathElements) {
+-            o = ((JSONObject) o).opt(pathElement);
++        	if (o != null) {
++                o = ((JSONObject) o).opt(pathElement);
++        	}
+         }
+         return o;
+     }",Unrelated bugfix for NPE.,Why is this needed?
+1012,"@@ -387,7 +387,7 @@ class AdminController extends Controller
+             throw new \Exception(sprintf('The ""%s"" property is not a switchable toggle.', $propertyName));
+         }
+ 
+-        if (!$propertyMetadata['canBeSet']) {
++        if (!$propertyMetadata['isWritable']) {
+             throw new \Exception(sprintf('It\'s not possible to toggle the value of the ""%s"" boolean property of the ""%s"" entity.', $propertyName, $this->entity['name']));
+         }
+ ",What if some extended the `AdminController` and had a check for the old option name? Could that be a valid use case?,This should be reverted.
+1013,"@@ -524,6 +524,17 @@
+                 dataType: ""json""
+             });
+         },
++        fetchSegmentMap: function() {
++            return CV.$.ajax({
++                type: ""GET"",
++                url: countlyCommon.API_PARTS.data.r + '/data-manager/event-segment',
++                data: {
++                    ""app_id"": countlyCommon.ACTIVE_APP_ID,
++                    ""preventRequestAbort"": true,
++                },
++                dataType: ""json""
++            });
++        },
+         fetchRefreshSelectedEventsData: function(context) {
+             return CV.$.ajax({
+                 type: ""GET"",","This will be only available when data-manager is enabled, is there a fallback in case data manager is disabled?",This should be `countlyC
+1014,"@@ -219,7 +219,7 @@ func (o *deploySvcOpts) generateWorkerServiceRecommendedActions() {
+ 	retrieveEnvVarCode := ""const eventsQueueURI = process.env.COPILOT_QUEUE_URI""
+ 	actionRetrieveEnvVar := fmt.Sprintf(
+ 		`Update %s's code to leverage the injected environment variable ""COPILOT_QUEUE_URI"".
+-In JavaScript you can write %s.`,
++  In JavaScript you can write %s.`,
+ 		o.name,
+ 		color.HighlightCode(retrieveEnvVarCode),
+ 	)",Do you think we want to move the call to `generateWorkerServiceRecommendedActions` inside `RecommandedActions()`?,I think this should be r
+1015,"@@ -3277,7 +3277,7 @@ bool CoreChecks::PreCallValidateGetQueryPoolResults(VkDevice device, VkQueryPool
+                                                     VkQueryResultFlags flags) const {
+     if (disabled.query_validation) return false;
+     bool skip = false;
+-    skip |= ValidateQueryPoolStride(""VUID-vkGetQueryPoolResults-flags-00814"", ""VUID-vkGetQueryPoolResults-flags-00815"", stride,
++    skip |= ValidateQueryPoolStride(""VUID-vkGetQueryPoolResults-flags-02827"", ""VUID-vkGetQueryPoolResults-flags-00815"", stride,
+                                     ""dataSize"", dataSize, flags);
+     skip |= ValidateGetQueryPoolResultsFlags(queryPool, flags);
+     skip |= ValidateGetQueryPoolResultsQueries(queryPool, firstQuery, queryCount);","The VUIDs in this area are not great, but I think `ValidateQueryPoolStride` should probably be skipped if the query pool was created with type `VK_QUERY_TYPE_PERFORMANCE_QUERY`. VUID-02828 might be a better fit, but again, the existing VUIDs step on each other so it requires a bit of interpretation.",Why do we need to change
+1016,"@@ -74,11 +74,12 @@ namespace Nethermind.Store
+             db[key.ToBigEndianByteArrayWithoutLeadingZeros()] = value;
+         }
+         
+-        public static byte[] Get(this IDb db, long key)
+-        {
+-            return db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
+-        }
+-        
++        public static byte[] Get(this IDb db, long key) => db[key.ToBigEndianByteArrayWithoutLeadingZeros()];
++
++        public static byte[] ToDbKey(this long key) => key.ToBigEndianByteArrayWithoutLeadingZeros();
++
++        public static byte[] ToDbKey(this Keccak key) => key.Bytes;
++
+         public static void Delete(this IDb db, long key)
+         {
+             db.Remove(key.ToBigEndianByteArrayWithoutLeadingZeros());",Iguess you should use ToDbKey here,Why is this needed?
+1017,"@@ -179,16 +179,7 @@ func (x *blockIndexer) DeleteTipBlock(blk *block.Block) error {
+ func (x *blockIndexer) Height() (uint64, error) {
+ 	x.mutex.RLock()
+ 	defer x.mutex.RUnlock()
+-
+-	index, err := db.GetCountingIndex(x.kvStore, totalBlocksBucket)
+-	if err != nil {
+-		if errors.Cause(err) == db.ErrBucketNotExist || errors.Cause(err) == db.ErrNotExist {
+-			// counting index does not exist yet
+-			return 0, nil
+-		}
+-		return 0, err
+-	}
+-	return index.Size() - 1, nil
++	return x.tbk.Size() - 1, nil
+ }
+ 
+ // GetBlockHash returns the block hash by height","x.tbk is the ""index"" below, and is done in Start()",Why do we need to l
+1018,"@@ -8,6 +8,7 @@ namespace Datadog.Trace.Util
+     /// </summary>
+     internal static class DomainMetadata
+     {
++        private const string IsAppInsightKey = ""DD_IsAppInsight"";
+         private const string UnknownName = ""unknown"";
+         private static Process _currentProcess;
+         private static bool _processDataPoisoned;","Do we already have a convention for this? If not, would we consider ""DataDog.IsAppInsights"". And then use ""DataDog."" prefix for all this settings, environment variables etc..? Such settings are, essentially, public APIs because they may conflict with customer data. Regardless of that , AppInsights has an s at the end :)",/// <summary>
+1019,"@@ -95,6 +95,16 @@ static int cb_firehose_init(struct flb_output_instance *ins,
+         ctx->time_key_format = DEFAULT_TIME_KEY_FORMAT;
+     }
+ 
++    tmp = flb_output_get_property(""log_key"", ins);
++    if (tmp) {
++        ctx->log_key = tmp;
++    }
++
++    if (ctx->log_key && ctx->time_key) {
++        flb_plg_error(ctx->ins, ""'time_key' and 'log_key' can not be used together"");
++        goto error;
++    }
++
+     tmp = flb_output_get_property(""endpoint"", ins);
+     if (tmp) {
+         ctx->custom_endpoint = FLB_TRUE;",this assignment is not necessary if the offsetof() is used in the configmap,Shouldn't this be `
+1020,"@@ -268,11 +268,6 @@ func (p *Protocol) claimFromAccount(sm protocol.StateManager, addr address.Addre
+ 	balance := big.NewInt(0).Sub(acc.balance, amount)
+ 	if balance.Cmp(big.NewInt(0)) < 0 {
+ 		return errors.New(""no enough available balance"")
+-	} else if balance.Cmp(big.NewInt(0)) == 0 {
+-		// If the account balance is cleared, delete if from the store
+-		if err := p.deleteState(sm, accKey); err != nil {
+-			return err
+-		}
+ 	} else {
+ 		acc.balance = balance
+ 		if err := p.putState(sm, accKey, &acc); err != nil {",I'd rather leave a TODO here at least.,Why was this removed?
+1021,"@@ -115,10 +115,10 @@ class BatchViewTest(BaseWebTest, unittest.TestCase):
+         request = {""path"": ""/mushrooms/""}  # trailing slash
+         body = {""requests"": [request]}
+         resp = self.app.post_json(""/batch"", body, headers=self.headers)
+-        collection = resp.json[""responses""][0]
+-        self.assertEqual(collection[""status""], 200)
+-        self.assertEqual(collection[""path""], ""/v0/mushrooms"")
+-        self.assertEqual(collection[""body""], {""data"": []})
++        objects = resp.json[""responses""][0]
++        self.assertEqual(objects[""status""], 200)
++        self.assertEqual(objects[""path""], ""/v0/mushrooms"")
++        self.assertEqual(objects[""body""], {""data"": []})
+ 
+     def test_body_is_transmitted_during_redirect(self):
+         request = {",Shouldn't this be `resource`?,Why did you change th
+1022,"@@ -37,13 +37,12 @@ namespace {
+ /** CPU implementation of evaluation layer forward prop. */
+ void fp_cpu(lbann_comm& comm,
+             const AbsDistMat& input,
+-            DataType& value,
+-            Al::request& req) {
++            DataType& value) {
+   const auto& local_input = input.LockedMatrix();
+   const auto& local_height = local_input.Height();
+   const auto& local_width = local_input.Width();
+   const auto& mini_batch_size = input.Width();
+-  value = DataType(0);
++  value = 0;
+ #pragma omp parallel for reduction(+:value) collapse(2)
+   for (El::Int col = 0; col < local_width; ++col) {
+     for (El::Int row = 0; row < local_height; ++row) {",Why does this become blocking for the CPU path? Shouldn't it remain independent of the GPU path?,Why this change?
+1023,"@@ -24,7 +24,7 @@ module Travis
+           sh.export 'TRAVIS_RUBY_VERSION', config[:rvm], echo: false if rvm?
+         end
+ 
+-        def setup
++        def configure
+           super
+           setup_rvm if rvm?
+         end",Do we need to change occurences where `setup` was called before?,Why is this necessary
+1024,"@@ -61,6 +61,16 @@ func (a *API) resolveReferences() {
+ 			o.ErrorRefs[i].Shape.IsError = true
+ 		}
+ 	}
++
++	// TODO put this somewhere better
++	for _, s := range a.Shapes {
++		switch s.Type {
++		case ""list"":
++			s.MemberRef.Shape.UsedInList = true
++		case ""map"":
++			s.ValueRef.Shape.UsedInMap = true
++		}
++	}
+ }
+ 
+ // A referenceResolver provides a way to resolve shape references to",Is this TODO still valid? Or are we going to put this somewhere else later?,I'm not sure if this is the right place to put this. I think it should be in a separate file.
+1025,"@@ -15,12 +15,17 @@ def generate_data(test_user_id, user_name, from_ts, num_records):
+     test_data = []
+     artist_msid = str(uuid.uuid4())
+ 
+-    for i in range(num_records):
++    if (from_ts == None):  #check for playing now listens
++        timestamp = None
++    else:
+         from_ts += 1   # Add one second
++        timestamp = datetime.utcfromtimestamp(from_ts)
++
++    for i in range(num_records):
+         item = Listen(
+             user_name=user_name,
+             user_id=test_user_id,
+-            timestamp=datetime.utcfromtimestamp(from_ts),
++            timestamp= timestamp,
+             artist_msid=artist_msid,
+             recording_msid=str(uuid.uuid4()),
+             data={",We generally don't do parantheses in if conditions in Python. :) this could be better written as `if from_ts is None`,I think this should be `if timestamp is None:`
+1026,"@@ -460,9 +460,13 @@ void tm_process_req_requestregioninfo(CTmTxMessage * pp_msg)
+        TM_Txid_legacy lv_transid;
+    } u;
+ 
+-   char tname[2000], ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
++   char tname[2000];
++   tname[299] = '\0';
++/*
++   char ername[50], rname[100], offline[20], regid[200], hostname[200], port[100];
+    tname[299] = '\0', ername[49] = '\0', rname[99] = '\0', offline[19] = '\0';
+    regid[199]= '\0', hostname[199]='\0', port[99]='\0';
++*/
+ 
+    TMTrace(2, (""tm_process_req_requestregioninfo ENTRY.\n""));
+    HashMapArray* map = HbaseTM_process_request_regions_info();",Odd that we'd set just element 299 of a 2000-byte buffer to null. But I see that this is the way it was before.,Why is this needed?
+1027,"@@ -28,3 +28,9 @@ type PeerAdder interface {
+ type ClosestPeerer interface {
+ 	ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
+ }
++
++// ScoreFunc is implemented by components that need to score peers in a different way than XOR distance.
++type ScoreFunc func(peer swarm.Address) (score float32)
++
++// EachPeerFunc is a callback that is called with a peer and its PO
++type EachPeerFunc func(swarm.Address, uint8) (stop, jumpToNext bool, err error)",ScoreFunc is not used in this PR. Maybe to add it later when needed?,Why do we need this?
+1028,"@@ -171,9 +171,9 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
+ 		http.SetCookie(w, cookie)
+ 	}
+ 
+-	if redirects := md.HeaderMD.Get(""Location""); len(redirects) > 0 {
+-		w.Header().Set(""Location"", redirects[0])
+-
++	// Redirect if it's the browser (non-XHR).
++	redirects := md.HeaderMD.Get(""Location"")
++	if len(redirects) > 0 && isBrowser(copyRequestHeadersFromResponseWriter(w)) {
+ 		code := http.StatusFound
+ 		if st := md.HeaderMD.Get(""Location-Status""); len(st) > 0 {
+ 			headerCodeOverride, err := strconv.Atoi(st[0])",super nit: I think this might be easier to read as `requestHeadersFromResponseWriter`,Why do we need to check for the browser here?
+1029,"@@ -4,12 +4,8 @@
+  *  (found in the LICENSE.Apache file in the root directory)
+  */
+ #include <gtest/gtest.h>
+-#include <cstdlib>
+-#include <thread>
+-#include <mutex>
+-#include <atomic>
+-#include ""common/concurrent/Barrier.h""
+-#include ""common/thread/GenericThreadPool.h""
++#include ""concurrent/Barrier.h""
++#include ""thread/GenericThreadPool.h""
+ 
+ namespace vesoft {
+ namespace concurrent {","Need to include ""common/base/Base.h"" in front of this line",Why did you remove these headers?
+1030,"@@ -1,6 +1,5 @@
+ import getRole from '../aria/get-role';
+-import matches from '../matches/matches';
+-import nativeElementType from './native-element-type';
++import getElementSpec from '../standards/get-element-spec';
+ import nativeTextMethods from './native-text-methods';
+ 
+ /**",Changes in this file should go into a separate PR.,This file should be renamed to `get-element-s
+1031,"@@ -243,10 +243,15 @@ public class PhpSurfaceNamer extends SurfaceNamer {
+         if (token.equals(InitFieldConfig.RANDOM_TOKEN)) {
+           stringParts.add(""time()"");
+         } else {
+-          stringParts.add(""\"""" + token + ""\"""");
++          stringParts.add(quoted(token));
+         }
+       }
+     }
+     return Joiner.on("". "").join(stringParts);
+   }
++
++  @Override
++  public String quoted(String text) {
++    return ""\'"" + text + ""\'"";
++  }
+ }",Please ensure that this will not start putting single quotes where double quotes are expected.,Why is this needed?
+1032,"@@ -68,7 +68,7 @@ type Manager struct {
+ }
+ 
+ // ProvideConfig provides the config for consumer
+-func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
++func (manager *Manager) ProvideConfig(publicKey json.RawMessage, pingerPort func(int, int) int) (session.ServiceConfiguration, session.DestroyCallback, error) {
+ 	key := &wg.ConsumerConfig{}
+ 	err := json.Unmarshal(publicKey, key)
+ 	if err != nil {","`ProvideConfig` was changed, looks like it will not compile for windows, and should be changed too.",Why do we need this change?
+1033,"@@ -76,9 +76,8 @@ func Search(ctx *context.APIContext) {
+ 	})
+ }
+ 
+-// https://github.com/gogits/go-gogs-client/wiki/Repositories#list-your-repositories
+-func ListMyRepos(ctx *context.APIContext) {
+-	ownRepos, err := models.GetUserRepositories(ctx.User.ID, true, 1, ctx.User.NumRepos)
++func listUserRepos(ctx *context.APIContext, u *models.User) {
++	ownRepos, err := models.GetUserRepositories(u.ID, true, 1, u.NumRepos)
+ 	if err != nil {
+ 		ctx.Error(500, ""GetRepositories"", err)
+ 		return","This does not look right, you're listing all private repositories..",This should be `ctx.User`
+1034,"@@ -20,4 +20,6 @@ C2::Application.routes.draw do
+   get 'bookmarklet', to: redirect('bookmarklet.html')
+   get ""/498"", :to => ""errors#token_authentication_error""
+ 
++  match ""*path"" => ""application#xss_options_request"", :via => :options
++
+ end",An OPTIONS request should respond from _any_ path? Seems weird to me...,Use the new Ruby 1.9 hash s
+1035,"@@ -40,6 +40,8 @@ class MediaAdmin extends Admin
+             ->add('category', null, array(
+                 'show_filter' => false,
+             ))
++            ->add('width')
++            ->add('height')
+         ;
+ 
+         $providers = array();",you need to add the content type,Why is this needed?
+1036,"@@ -12,6 +12,14 @@ namespace Datadog.Trace
+     {
+         private static Task _traceAgentMonitor;
+         private static Task _dogStatsDMonitor;
++        private static Process _traceAgentProcess;
++        private static Process _dogStatsProcess;
++
++        public static void StopSubProcesses()
++        {
++            SafelyKillProcess(_traceAgentProcess, ""Failed to halt the sub-process trace agent"");
++            SafelyKillProcess(_dogStatsProcess, ""Failed to halt the sub-process stats agent"");
++        }
+ 
+         public static void StartStandaloneAgentProcessesWhenConfigured()
+         {",Do we need to distinguish between these two processes? I'm thinking maybe we can have a list of processes and treat them all equally.,"I think this should be `SafelyKillProcess(_traceAgentMonitor, ""Failed to halt the sub-process trace agent"");`"
+1037,"@@ -61,8 +61,8 @@ callee_info_t default_callee_info;
+ int
+ get_clean_call_switch_stack_size(void)
+ {
+-#ifdef AARCH64
+-    /* Stack size needs to be 16 byte aligned on ARM */
++#if defined(AARCH64) || defined(X64)
++    /* Stack size needs to be 16 byte aligned on ARM and x64. */
+     return ALIGN_FORWARD(sizeof(priv_mcontext_t), 16);
+ #else
+     return sizeof(priv_mcontext_t);","This is used only for out-of-line -- so yes this seems right to do for x64. Inlined is aligned separately at the end of prepare_for_clean_call(). There the ifdef is x86_64 or MACOS -- no ARM, why not? Also, please add || MACOS here to match the inlined.",This should be `#if defined(ARM64) || defined(X64)`
+1038,"@@ -271,7 +271,8 @@ final class MySQLSpanStore implements SpanStore {
+           .selectDistinct(ZIPKIN_SPANS.NAME)
+           .from(ZIPKIN_SPANS)
+           .join(ZIPKIN_ANNOTATIONS)
+-          .on(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
++          .on(ZIPKIN_SPANS.TRACE_ID_HIGH.eq(ZIPKIN_ANNOTATIONS.TRACE_ID_HIGH))
++          .and(ZIPKIN_SPANS.TRACE_ID.eq(ZIPKIN_ANNOTATIONS.TRACE_ID))
+           .and(ZIPKIN_SPANS.ID.eq(ZIPKIN_ANNOTATIONS.SPAN_ID))
+           .where(ZIPKIN_ANNOTATIONS.ENDPOINT_SERVICE_NAME.eq(serviceName))
+           .orderBy(ZIPKIN_SPANS.NAME)",guess I'm wondering if this needs to be refactored to use Schema.joinCondition() or similar?,Why is this needed?
+1039,"@@ -53,6 +53,7 @@ module Beaker
+     class_option :'xml-time-order', :type => :boolean, :group => 'Beaker run'
+     class_option :'debug-errors', :type => :boolean, :group => 'Beaker run'
+     class_option :'exec_manual_tests', :type => :boolean, :group => 'Beaker run'
++    class_option :'test-tag-exclude', :type => :string, :group => 'Beaker run'
+ 
+     # The following are listed as deprecated in beaker --help, but needed now for
+     # feature parity for beaker 3.x.",Does it make sense to restrict this option to `exec` only? You could add it specific to that subcommand using the `method_option`...method. There's an example of it for hosts in the `init` function.,Use the new Ruby 1.9 hash syntax.
+1040,"@@ -143,7 +143,10 @@ namespace OpenTelemetry.Context.Propagation
+                         break;
+                     }
+ 
+-                    if (NameValueHeaderValue.TryParse(pair, out NameValueHeaderValue baggageItem))
++                    var decodedPair = WebUtility.UrlDecode(pair);
++                    var escapedPair = string.Join(""="", decodedPair.Split('=').Select(Uri.EscapeDataString));
++
++                    if (NameValueHeaderValue.TryParse(escapedPair, out NameValueHeaderValue baggageItem))
+                     {
+                         if (string.IsNullOrEmpty(baggageItem.Name) || string.IsNullOrEmpty(baggageItem.Value))
+                         {","This is very expensive (lots of allocations, lots of data copying). Could we do something like check IndexOf('%') and bypass if no hit?",Why do we need to do this?
+1041,"@@ -55,10 +55,17 @@ public class PvPUtil
+ 	public static boolean isAttackable(Client client, Player player)
+ 	{
+ 		int wildernessLevel = 0;
+-		if (!(client.getVar(Varbits.IN_WILDERNESS) == 1 || WorldType.isPvpWorld(client.getWorldType())))
++		if (!(client.getVar(Varbits.IN_WILDERNESS) == 1
++				|| WorldType.isPvpWorld(client.getWorldType())
++				|| client.getWorldType().contains(WorldType.DEADMAN)
++		))
+ 		{
+ 			return false;
+ 		}
++		if (client.getWorldType().contains(WorldType.DEADMAN))
++		{
++			return true;
++		}
+ 		if (WorldType.isPvpWorld(client.getWorldType()))
+ 		{
+ 			if (client.getVar(Varbits.IN_WILDERNESS) != 1)",This should be `WorldType.isDeadmanWorld(client.getWorldType())` to be inline with the other WorldType calls.,This should be `client.get
+1042,"@@ -600,11 +600,11 @@ class SABLRetinaHead(BaseDenseHead, BBoxTestMixin):
+                 bbox_cls_pred.contiguous(),
+                 bbox_reg_pred.contiguous()
+             ]
+-            bboxes, confids = self.bbox_coder.decode(
++            bboxes, confidences = self.bbox_coder.decode(
+                 anchors.contiguous(), bbox_preds, max_shape=img_shape)
+             mlvl_bboxes.append(bboxes)
+             mlvl_scores.append(scores)
+-            mlvl_confids.append(confids)
++            mlvl_confids.append(confidences)
+         mlvl_bboxes = torch.cat(mlvl_bboxes)
+         if rescale:
+             mlvl_bboxes /= mlvl_bboxes.new_tensor(scale_factor)",do we also need to change `mlvl_confid` -> `mlvl_confidences`>,nit: `confidences` -> `con
+1043,"@@ -125,7 +125,8 @@ type Config struct {
+ 	MetadataAddr string `config:""hostname;127.0.0.1;die-on-fail""`
+ 	MetadataPort int    `config:""int(0,65535);8775;die-on-fail""`
+ 
+-	InterfacePrefix string `config:""iface-list;cali;non-zero,die-on-fail""`
++	InterfacePrefix  string `config:""iface-list;cali;non-zero,die-on-fail""`
++	InterfaceExclude string `config:""iface-list;kube-ipvs0""`
+ 
+ 	ChainInsertMode             string `config:""oneof(insert,append);insert;non-zero,die-on-fail""`
+ 	DefaultEndpointToHostAction string `config:""oneof(DROP,RETURN,ACCEPT);DROP;non-zero,die-on-fail""`","I feel slightly that InterfaceExclude is not a clear name - bearing in mind that our config names are, to some extent, an external API. From an external point of view, a clearer name might be IPVSInterfaces. Then it would obviously make sense for the value to be something like 'kube-ipvs0', and it would be a matter of Felix's internal implementation that we choose to exclude those interfaces from our monitoring. Alternatively, if we want to keep this at a level that is more general than just IPVS, perhaps 'UnmonitoredInterfaces'? WDYT?",Why do we need to exclude 
+1044,"@@ -180,7 +180,7 @@ def transform_path(path):
+     path = utils.expand_windows_drive(path)
+     # Drive dependent working directories are not supported, e.g.
+     # E:filename is invalid
+-    if re.match(r'[A-Z]:[^\\]', path, re.IGNORECASE):
++    if re.fullmatch(r'[A-Z]:[^\\]', path, re.IGNORECASE):
+         return None
+     # Paths like COM1, ...
+     # See https://github.com/qutebrowser/qutebrowser/issues/82","This should be `re.search` with a `^` anchor added to the regex, as what we want here is really any path starting with something like `E:`.",Why is this change needed?
+1045,"@@ -108,6 +108,14 @@ func determineResourceHealth(key ResourceKey, obj *unstructured.Unstructured) (s
+ 		return determineClusterRoleHealth(obj)
+ 	case KindClusterRoleBinding:
+ 		return determineClusterRoleBindingHealth(obj)
++	case KindVirtualService:
++		return determineVirtualService(obj)
++	case KindDestinationRule:
++		return determineDestinationRule(obj)
++	case KindGateway:
++		return determineGateway(obj)
++	case KindServiceEntry:
++		return determineServiceEntry(obj)
+ 	default:
+ 		desc = ""Unimplemented or unknown resource""
+ 		return","Since `IsKubernetesBuiltInResource` at L69 returns false due to lack `networking.istio.io/v1alpha3` in `builtInApiVersions` within `pkg/app/piped/cloudprovider/kubernetes/resourcekey.go`, it will never reach this point.",Why do we need this?
+1046,"@@ -40,7 +40,7 @@ import (
+ // themselves.
+ func RunEndToEndTest(ctx context.Context, t *testing.T, exp *otlpmetric.Exporter, mcMetrics Collector) {
+ 	selector := simple.NewWithInexpensiveDistribution()
+-	proc := processor.New(selector, exportmetric.StatelessExportKindSelector())
++	proc := processor.NewFactory(selector, exportmetric.StatelessExportKindSelector())
+ 	cont := controller.New(proc, controller.WithExporter(exp))
+ 	require.NoError(t, cont.Start(ctx))
+ ",Does codecov not run this test? Not sure how else it would not be covered.,Why is this change necessa
+1047,"@@ -30,8 +30,9 @@ func main() {
+ 
+ // rootCmd represents the base command when called without any subcommands
+ var rootCmd = &cobra.Command{
+-	Use:  ""multisend [command]"",
+-	Args: cobra.ExactArgs(1),
++	Use:   ""multisend 'JSON_DATA'"",
++	Short: ""multisend bytecode generator"",
++	Args:  cobra.ExactArgs(1),
+ 	RunE: func(cmd *cobra.Command, args []string) error {
+ 		output, err := multiSend(args)
+ 		if err == nil {",can we add some sample of JSON_DATA format in the usage?,I think this should be `[c
+1048,"@@ -25,13 +25,13 @@ namespace Datadog.Trace.Logging
+             _logProvider = logProvider;
+         }
+ 
+-        public void Initialize(IScopeManager scopeManager, string defaultServiceName, string version, string env)
++        public void Initialize(string defaultServiceName, string version, string env)
+         {
+             _versionProperty = version;
+             _environmentProperty = env;
+             _serviceProperty = defaultServiceName;
+-            _traceIdProperty = CreateTracerProperty(scopeManager, t => t.Active?.Span.TraceId.ToString());
+-            _spanIdProperty = CreateTracerProperty(scopeManager, t => t.Active?.Span.SpanId.ToString());
++            _traceIdProperty = CreateTracerProperty(() => Tracer.Instance.DistributedSpanContext?[HttpHeaderNames.TraceId]);
++            _spanIdProperty = CreateTracerProperty(() => Tracer.Instance.DistributedSpanContext?[HttpHeaderNames.ParentId]);
+         }
+ 
+         public IDisposable Register()",Using `Tracer.Instance` in here is problematic for testing   It will likely cause some other tests to break I think - that's why we started passing in `IScopeManager` EDIT: I see you used `[TracerRestore]` - maybe that'll be enough!,Why do we need this change?
+1049,"@@ -22,7 +22,10 @@ import javax.annotation.Nullable;
+  */
+ @AutoValue
+ public abstract class InitFieldConfig {
++  public static final String projectIdVariableName = ""project_id"";
++
+   private static final String randomValueToken = ""$RANDOM"";
++  private static final String projectIdToken = ""$PROJECT_ID"";
+ 
+   public abstract String fieldPath();
+ ",make all of these `static final` fields UPPER_SNAKE - they are constants.,Why do we need this?
+1050,"@@ -3298,7 +3298,8 @@ int32 Mob::AffectMagicalDamage(int32 damage, uint16 spell_id, const bool iBuffTi
+ 
+ 	// If this is a DoT, use DoT Shielding...
+ 	if (iBuffTic) {
+-		damage -= (damage * itembonuses.DoTShielding / 100);
++		int total_dotshielding = itembonuses.DoTShielding + itembonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT] + aabonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT];
++		damage -= (damage * total_dotshielding / 100);
+ 
+ 		if (spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_PERCENT]) {
+ 			slot = spellbonuses.MitigateDotRune[SBIndex::MITIGATION_RUNE_BUFFSLOT];","No possible chance for weird overflows here, right?",I don't think this is the r
+1051,"@@ -39,9 +39,13 @@ import org.apache.lucene.search.Weight;
+  * @lucene.experimental
+  */
+ public abstract class ValueSourceScorer extends Scorer {
++  // Fixed cost for a single iteration of the TwoPhaseIterator instance
++  private static final int DEF_COST = 5;
++
+   protected final FunctionValues values;
+   private final TwoPhaseIterator twoPhaseIterator;
+   private final DocIdSetIterator disi;
++  private float externallyMutableCost;
+ 
+   protected ValueSourceScorer(Weight weight, LeafReaderContext readerContext, FunctionValues values) {
+     super(weight);",Or we could use a Float object to more clearly show as user-settable via non-null?,I don't think we need this 
+1052,"@@ -107,7 +107,7 @@ namespace Nethermind.Merge.Plugin.Handlers.V1
+             
+             if (headUpdated && shouldUpdateHead)
+             {
+-                _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header);
++                _poSSwitcher.ForkchoiceUpdated(newHeadBlock!.Header, finalizedHeader);
+                 _stateProvider.ResetStateTo(newHeadBlock.StateRoot!);
+                 if (_logger.IsInfo) _logger.Info($""Block {forkchoiceState.HeadBlockHash} was set as head"");
+             }",finalizedHeader should be saved in FinalizationManager when we have FinalizationBlockHash != Keccak.Zero,Shouldn't this be `finalizedHeader`?
+1053,"@@ -48,6 +48,7 @@ func AddDiskImportSteps(w *daisy.Workflow, dataDiskInfos []ovfutils.DiskInfo) {
+ 
+ 		setupDataDiskStepName := fmt.Sprintf(""setup-data-disk-%v"", dataDiskIndex)
+ 		diskImporterDiskName := fmt.Sprintf(""disk-importer-%v"", dataDiskIndex)
++		scratchDiskDiskName := fmt.Sprintf(""disk-importer-scratch-%s-%v"", w.ID(), dataDiskIndex)
+ 
+ 		setupDataDiskStep := daisy.NewStep(setupDataDiskStepName, w, time.Hour)
+ 		setupDataDiskStep.CreateDisks = &daisy.CreateDisks{","Not using ExactName: true would remove the need for manually adding workflow ID as it would be added automatically by Daisy. E.g. 'disk-importer-2-import-ovf-7mn7h' was created from diskImporterDiskName above even though only 'disk-importer-2' was specified. ExactName: true should be used for resources that shouldn't include any temp prefix/suffix, such as disks that will be permanently attached to a created instance. Scratch disk is not one of them.","scratchDiskName := fmt.Sprintf(""disk"
+1054,"@@ -8469,8 +8469,13 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+                 'For argument ""inplace"" expected type bool, received type {}.'
+                 .format(type(inplace).__name__))
+ 
+-        sdf = self._sdf.filter(expr)
+-        internal = self._internal.copy(sdf=sdf)
++        data_columns = [label[0] for label in self._internal.column_labels]
++        sdf = self._sdf.select(self._internal.index_scols
++                               + [scol.alias(col) for scol, col
++                                  in zip(self._internal.column_scols, data_columns)]) \
++            .filter(expr)
++        internal = self._internal.copy(sdf=sdf,
++                                       column_scols=[scol_for(sdf, col) for col in data_columns])
+ 
+         if inplace:
+             self._internal = internal","If we support multi-index column later, we need to rename to fit the pandas' requirement.",I don't think this is the right way 
+1055,"@@ -0,0 +1,11 @@
++package aws
++
++// JSONValue is a representation of a grab bag type that will be marshaled
++// into a json string. This type can be used just like any other map.
++//
++//	Example:
++//	values := JSONValue{
++//		""Foo"": ""Bar"",
++//	}
++//	values[""Baz""] = ""Qux""
++type JSONValue map[string]interface{}","I'm not sure this is really needed. JSONValue type can be used the same as a map as far as operators go, including range. I'd leave this out for now unless there is a strong reason to keep it.",I think this should be `map[string]i
+1056,"@@ -724,6 +724,7 @@ void Container::internalAddThing(uint32_t, Thing* thing)
+ 
+ void Container::startDecaying()
+ {
++	Item::startDecaying();
+ 	for (Item* item : itemlist) {
+ 		item->startDecaying();
+ 	}",sorry for nitpicking but I would love a new line under this line,Why is this needed?
+1057,"@@ -21,5 +21,5 @@ package node
+ type OptionsTransactor struct {
+ 	TransactorEndpointAddress string
+ 	RegistryAddress           string
+-	AccountantID              string
++	ChannelImplementation     string
+ }","ChannelImplementation field naming is not clear, is it some kind of standard? Maybe it can be named ChannelID?",Why is this a strin
+1058,"@@ -67,4 +67,11 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files referenced by given metadata location.
++   */
++  default RemoveFiles removeFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
++  }
+ }",Looks like there is a typo: `expireSnapshots` -> `removeFiles` or whatever name we go with.,I think this should
+1059,"@@ -31,7 +31,7 @@ public abstract class IntraFeedSortDialog {
+ 
+         int idxCurrentSort = -1;
+         for  (int i = 0; i < values.length; i++) {
+-            if (currentSortOrder == values[i]) {
++            if (currentSortOrder == values[i] || currentSortOrder == null) {
+                 idxCurrentSort = i;
+                 break;
+             }",Thanks for looking into this. I think it looks a bit strange to have this check inside the for loop. Wouldn't it also work to initialize `idxCurrentSort` with 0 instead?,Why is this change 
+1060,"@@ -72,6 +72,8 @@ public class Notification {
+     public static final int OMNIPOD_POD_NOT_ATTACHED = 59;
+     public static final int CARBS_REQUIRED = 60;
+     public static final int IMPORTANCE_HIGH = 2;
++    public static final int OMNIPOD_POD_SUSPENDED = 61;
++    public static final int OMNIPOD_POD_ALERTS_UPDATED = 62;
+ 
+     public static final String CATEGORY_ALARM = ""alarm"";
+ ",Just a small ordering thing: Could you please bring `IMPORTANCE_HIGH` to the bottom and maybe even have one line between it and the Notification IDs?,I think this should be `OMNIPOD_POD_ALERTS_UPDATED`
+1061,"@@ -48,7 +48,7 @@ void prepareMolForDrawing(RWMol &mol, bool kekulize, bool addChiralHs,
+   if (kekulize) {
+     try {
+       MolOps::Kekulize(mol, false);  // kekulize, but keep the aromatic flags!
+-    } catch(const RDKit::AtomKekulizeException &e) {
++    } catch (const RDKit::AtomKekulizeException &e) {
+       std::cerr << e.what() << std::endl;
+     }
+   }",Should this be boost logged?,I don't think this is a good idea. If you want to k
+1062,"@@ -57,9 +57,10 @@ def find_notifiers(notifier_name):
+ # pylint: enable=inconsistent-return-statements
+ 
+ 
+-def convert_to_timestamp(violations):
++def convert_to_timestamp(session, violations):
+     """"""Convert violation created_at_datetime to timestamp string.
+     Args:
++        session (object): session object to work on.
+         violations (sqlalchemy_object): List of violations as sqlalchemy
+             row/record object with created_at_datetime.
+     Returns:",What is the reason for doing expunge here? This method is purely for converting the timestamp.,Why do we need this?
+1063,"@@ -86,9 +86,15 @@ class TypeToSchema extends TypeUtil.SchemaVisitor<Schema> {
+     List<Schema.Field> fields = Lists.newArrayListWithExpectedSize(fieldSchemas.size());
+     for (int i = 0; i < structFields.size(); i += 1) {
+       Types.NestedField structField = structFields.get(i);
++      String origFieldName = structField.name();
++      boolean isValid = validAvroName(origFieldName);
++      String fieldName =  isValid ? origFieldName : sanitize(origFieldName);
+       Schema.Field field = new Schema.Field(
+-          structField.name(), fieldSchemas.get(i), null,
++          sanitize(fieldName), fieldSchemas.get(i), null,
+           structField.isOptional() ? JsonProperties.NULL_VALUE : null);
++      if (!isValid) {
++        field.addProp(AvroSchemaUtil.ORIGINAL_FIELD_NAME_PROP, origFieldName);
++      }
+       field.addProp(AvroSchemaUtil.FIELD_ID_PROP, structField.fieldId());
+       fields.add(field);
+     }",This calls sanitize twice if the name isn't valid.,nit: space after `if`
+1064,"@@ -0,0 +1,13 @@
++class Proposal < ActiveRecord::Base
++  has_one :cart
++
++  validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
++  validates :status, presence: true, inclusion: {in: Approval::STATUSES}
++
++  after_initialize :set_default_flow
++
++
++  def set_default_flow
++    self.flow ||= 'parallel'
++  end
++end",Is there an equivalent that'd allow zero or one?,Layout/TrailingBlankLines: Final newline missing.
+1065,"@@ -234,6 +234,13 @@ func (m *taskExecutor) repeatWith() (err error) {
+ 			m.resetK8sClient(resource)
+ 		}
+ 
++		if rwExec.isTaskObjectNameRepeat() {
++			// if repetition is based on task object name itself, then the task's
++			// object name needs to be set
++			m.metaTaskExec.setObjectName(resource)
++			m.objectName = resource
++		}
++
+ 		// set the currently active repeat resource
+ 		util.SetNestedField(m.templateValues, resource, string(v1alpha1.ListItemsTLP), string(v1alpha1.CurrentRepeatResourceLITP))
+ ",Is it possible to update/re-evaluate entire metatask object for every repeat? If we decide/need to use a repeatWith resources in let us say labelSelector(bad example) then we would have to add another logic to update those properties.,Why do we need this?
+1066,"@@ -47,7 +47,7 @@ func accountImport(args []string) string {
+ 	}
+ 	wallet := cfg.Wallet
+ 	fmt.Printf(""#%s: Enter your private key, which will not be exposed on the screen.\n"", name)
+-	privateKeyBytes, err := terminal.ReadPassword(syscall.Stdin)
++	privateKeyBytes, err := terminal.ReadPassword(int(syscall.Stdin))
+ 	if err != nil {
+ 		log.L().Error(""fail to get private key"", zap.Error(err))
+ 		return err.Error()",unnecessary conversion (from `unconvert`),"`ReadPassword` returns an `int`, not a `string`."
+1067,"@@ -30,7 +30,6 @@ int main (int argc, char *argv[])
+     int universe_size;
+     char *kvsname;
+     char *val;
+-    char pmi_fd[16];
+     char pmi_rank[16];
+     char pmi_size[16];
+     int result;",typo in commit message `openening`,why is this removed?
+1068,"@@ -10,7 +10,10 @@
+ 
+ #include <mpi.h>
+ 
+-#include <adios2.h>
++#define ADIOS_HAVE_PHDF5 // so hdf5 related items are loaded in ADIOS_CPP.h
++//#include ""ADIOS_CPP.h""
++#include ""adios2.h""
++#include ""adios2/engine/hdf5/HDF5ReaderP.h""
+ 
+ int main(int argc, char *argv[])
+ {",User-code doesn't see the internal ADIOS headers anymore. This whole include block should just be `#include <adios2.h>`,Why is this needed?
+1069,"@@ -20,7 +20,8 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
+ 
+     def test_buckets_are_global_to_every_users(self):
+         self.app.patch_json(self.record_url,
+-                            {'permissions': {'read': [Authenticated]}},
++                            {'data': {},
++                             'permissions': {'read': [Authenticated]}},
+                             headers=self.headers)
+         self.app.get(self.record_url, headers=get_user_headers('alice'))
+ ",nit: I guess we can omit this (unless you had a reason to specify it),E225 missing whites
+1070,"@@ -74,6 +74,11 @@ func (c *client) isSolicitedLeafNode() bool {
+ 	return c.kind == LEAF && c.leaf.remote != nil
+ }
+ 
++// Returns true if this is a solicited leafnode and is not configured to be treated as a hub.
++func (c *client) isSpokeLeafNode() bool {
++	return c.kind == LEAF && c.leaf.remote != nil && !c.leaf.remote.Hub
++}
++
+ func (c *client) isUnsolicitedLeafNode() bool {
+ 	return c.kind == LEAF && c.leaf.remote == nil
+ }",Why is Hub public?,nit: `isSpokeLeafNo
+1071,"@@ -114,7 +114,6 @@ func (agent *ecsAgent) capabilities() ([]*ecs.Attribute, error) {
+ 	}
+ 
+ 	capabilities = agent.appendTaskENICapabilities(capabilities)
+-	capabilities = agent.appendENITrunkingCapabilities(capabilities)
+ 
+ 	capabilities = agent.appendDockerDependentCapabilities(capabilities, supportedVersions)
+ ",why is this deleted?,Why was this remove
+1072,"@@ -1,5 +1,6 @@
+ <div class=""<%= trail.unstarted? ? ""unstarted"" : ""started"" %>"">
+   <section class=""trail <%= topic_class(trail.topic) %>"">
++    <p class=""prerequisite"">Hey, before you start this...Have you done the <a href="""">Intro to Rails</a> tutorial?</p>
+     <header>
+       <span class=""topic-label""><%= trail.topic.name %></span>
+       <h1><%= link_to trail.name, trail %></h1>",Maybe move that into a partial,"I think this should be `<p class=""prerequisite"">Hey, before you start this...`"
+1073,"@@ -158,10 +158,13 @@ func TestBlockDAO(t *testing.T) {
+ 		require := require.New(t)
+ 
+ 		ctx := context.Background()
+-		dao := NewBlockDAO(kvstore, indexer, false, config.Default.DB)
++		testDBFile, _ := ioutil.TempFile(os.TempDir(), ""db"")
++		cfg := config.Default.DB
++		cfg.DbPath = testDBFile.Name()
++		dao := NewBlockDAO(kvstore, indexer, false, cfg)
+ 		require.NoError(dao.Start(ctx))
+ 		defer func() {
+-			require.NoError(dao.Stop(ctx))
++			dao.Stop(ctx)
+ 		}()
+ 
+ 		// receipts for the 3 blocks",Error return value of `dao.Stop` is not checked (from `errcheck`),Error return value of `dao.Stop` is not checked
+1074,"@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
+ 	if docrootRelPath != """" {
+ 		app.Docroot = docrootRelPath
+ 		if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
+-			util.Failed(""The docroot provided (%v) does not exist"", docrootRelPath)
++			output.UserOut.Warnf(""Warning: the provided docroot at %s does not currently exist."", docrootRelPath)
+ 		}
+ 	} else if !cmd.Flags().Changed(""docroot"") {
+ 		app.Docroot = ddevapp.DiscoverDefaultDocroot(app)",util.Warning()? Easier to say.,I think we should use `util.Failedf` here.
+1075,"@@ -38,6 +38,14 @@ func Trie(tx ethdb.Tx, slowChecks bool, quit <-chan struct{}) {
+ 			if errc != nil {
+ 				panic(errc)
+ 			}
++			select {
++			default:
++			case <-quit:
++				return
++			case <-logEvery.C:
++				log.Info(""trie account integrity"", ""key"", fmt.Sprintf(""%x"", k))
++			}
++
+ 			hasState, hasBranch, hasHash, hashes, _ := trie.UnmarshalTrieNode(v)
+ 			AssertSubset(k, hasBranch, hasState)
+ 			AssertSubset(k, hasHash, hasState)",this default is kinda superfluous (although i see it was already there before PR ),why is this needed?
+1076,"@@ -53,11 +53,7 @@ public class NodeList<N extends Node> implements List<N>, Iterable<N>, HasParent
+     private List<AstObserver> observers = new ArrayList<>();
+ 
+     public NodeList() {
+-        this((Node) null);
+-    }
+-
+-    public NodeList(Node parent) {
+-        setParentNode(parent);
++        parentNode = null;
+     }
+ 
+     public NodeList(Collection<N> n) {",How is this related?,Why was this constructor removed?
+1077,"@@ -3,6 +3,7 @@ class SubscriptionsController < ApplicationController
+ 
+   def new
+     @plans = IndividualPlan.featured.active.ordered
++    @team_plans = TeamPlan.featured.ordered
+   end
+ 
+   def edit","I'm breaking one of the rules here, it feels like the right thing to do. Open to alternative suggestions.",Should this be `@team_plans = Tea
+1078,"@@ -1,8 +1,8 @@
+ shared_examples_for 'disables OpenSSH roaming' do
+   let(:disable_ssh_roaming) { %(echo -e ""Host *\n  UseRoaming no\n"" | cat - $HOME/.ssh/config > $HOME/.ssh/config.tmp && mv $HOME/.ssh/config.tmp $HOME/.ssh/config) }
+-  let(:sexp) { sexp_find(subject, [:if, ""$(sw_vers -productVersion | cut -d . -f 2) -lt 12""]) }
++  let(:sexp) { sexp_find(subject, [:if, %(""$(sw_vers -productVersion 2>/dev/null | cut -d . -f 2)"" -lt 12)]) }
+ 
+   it 'disables OpenSSH roaming' do
+-    sexp.should include_sexp [:cmd, disable_ssh_roaming]
++    expect(sexp).to include_sexp [:cmd, disable_ssh_roaming]
+   end
+ end","The use of `#should` was triggering an rspec depracation warning for me, which is why I switched this to the rspec 3 style.",I think this should be `expect(se
+1079,"@@ -172,7 +172,7 @@ bool ReaderProxy::requested_changes_set(std::vector<SequenceNumber_t>& seqNumSet
+     {
+         auto chit = m_changesForReader.find(ChangeForReader_t(*sit));
+ 
+-        if(chit != m_changesForReader.end() && chit->isValid())
++        if(chit != m_changesForReader.end())
+         {
+             ChangeForReader_t newch(*chit);
+             newch.setStatus(REQUESTED);",Why are you setting the CacheChange as REQUESTED when it is not valid (it was erased from history)?,Why was this removed?
+1080,"@@ -44,9 +44,12 @@ import {
+ 	isDataZeroForReporting,
+ } from '../util';
+ 
+-const { __ } = wp.i18n;
+-const { Component, Fragment } = wp.element;
+-const { isEmpty } = lodash;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { Component, Fragment } from '@wordpress/element';
++import { isEmpty } from 'lodash';
+ 
+ class AnalyticsDashboardWidgetTopLevel extends Component {
+ 	constructor( props ) {",`lodash` shouldn't be grouped under WordPress dependencies,I think this should be `import { isEmpty } from 'lodash';`
+1081,"@@ -69,7 +69,7 @@ class GenericDataFile
+   /**
+    * Used by Avro reflection to instantiate this class when reading manifest files.
+    */
+-  public GenericDataFile(org.apache.avro.Schema avroSchema) {
++  GenericDataFile(org.apache.avro.Schema avroSchema) {
+     this.avroSchema = avroSchema;
+ 
+     Types.StructType schema = AvroSchemaUtil.convert(avroSchema).asNestedType().asStructType();",This needs to be public so that Avro can call it.,Why did you remove the public keyword?
+1082,"@@ -18,18 +18,7 @@
+ /**
+  * External dependencies
+  */
+-import data, { TYPE_CORE } from 'GoogleComponents/data';
+-import SvgIcon from 'GoogleUtil/svg-icon';
+-
+-export * from './storage';
+-
+-const { apiFetch } = wp;
+-const {
+-	addFilter,
+-	applyFilters,
+-} = wp.hooks;
+-
+-const {
++import {
+ 	map,
+ 	isNull,
+ 	isUndefined,",`Google*` shouldn't be under External dependencies - seems like ESlint is not properly recognizing that these are aliases to internal dependencies.,Why are we removing these hooks?
+1083,"@@ -245,6 +245,13 @@ class DataFrame(_Frame):
+             else:
+                 super(DataFrame, self).__init__(_InternalFrame(
+                     data, data_columns=index.data_columns, index_map=index.index_map))
++        elif isinstance(data, ks.Series):
++            assert index is None
++            assert columns is None
++            assert dtype is None
++            assert not copy
++            data = data.to_dataframe()
++            super(DataFrame, self).__init__(data._internal)
+         else:
+             if isinstance(data, pd.DataFrame):
+                 assert index is None",I think he meant the docstring in this constructor. yea we should fix,Why do we need this?
+1084,"@@ -150,7 +150,18 @@ public abstract class BinaryDictionary implements Dictionary {
+         throw new IllegalStateException(""unknown resource scheme "" + resourceScheme);
+     }
+   }
+-  
++
++  public static InputStream getResource(ResourceScheme scheme, String path) throws IOException {
++    switch(scheme) {
++      case CLASSPATH:
++        return getClassResource(path);
++      case FILE:
++        return Files.newInputStream(Paths.get(path));
++      default:
++        throw new IllegalStateException(""unknown resource scheme "" + scheme);
++    }
++  }
++
+   // util, reused by ConnectionCosts and CharacterDefinition
+   public static InputStream getClassResource(Class<?> clazz, String suffix) throws IOException {
+     final InputStream is = clazz.getResourceAsStream(clazz.getSimpleName() + suffix);","so .. this basically follows the pattern from JapaneseTokenizer, I think. .. but somehow I don't see where we defined ResourceScheme? We're not referencing the one in kuromoji, right?",Why do we need this switch?
+1085,"@@ -525,8 +525,11 @@ namespace SkylineNightly
+ 
+         private void DownloadSkylineTester(string skylineTesterZip, RunMode mode)
+         {
+-            // Make sure we can negotiate with HTTPS servers that demand TLS 1.2 (default in dotNet 4.6, but has to be turned on in 4.5)
+-            ServicePointManager.SecurityProtocol |= (SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12);
++            // The current recommendation from MSFT for future-proofing HTTPS https://docs.microsoft.com/en-us/dotnet/framework/network-programming/tls
++            // is don't specify TLS levels at all, let the OS decide. But we worry that this will mess up Win7 and Win8 installs, so we continue to specify explicitly
++            var Tls13 = (SecurityProtocolType)12288; // From decompiled SecurityProtocolType - compiler has no definition for some reason
++            ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls | SecurityProtocolType.Tls11 | SecurityProtocolType.Tls12 | Tls13;
++
+             using (var client = new WebClient())
+             {
+                 client.Credentials = new NetworkCredential(TEAM_CITY_USER_NAME, TEAM_CITY_USER_PASSWORD);",It would probably be better to do: const SecurityProtocolType Tls13 = (SecurityProtocolType)12288,Why do we need to do this?
+1086,"@@ -70,16 +70,6 @@ export default [
+         updated_by: 1,
+         value: ''
+     },
+-    {
+-        id: 12,
+-        key: 'labs',
+-        value: '{""subscribers"":true}',
+-        type: 'blog',
+-        created_at: '2015-01-12T18:29:01.000Z',
+-        created_by: 1,
+-        updated_at: '2015-10-27T17:39:58.288Z',
+-        updated_by: 1
+-    },
+     {
+         id: 13,
+         created_at: '2015-09-11T09:44:30.810Z',","Similar to the above, put this setting back but keep the value as `'{}'`",Why is this being removed?
+1087,"@@ -130,7 +130,7 @@ def refresh_listen_count_aggregate():
+            Assuming today is 2022-01-01 and this function is called for year_offset 1 and
+            year_count 1 then all of 2021 will be refreshed.
+     """"""
+-
++    logger.info(""Starting to refresh continuous aggregates:"")
+     timescale.init_db_connection(config.SQLALCHEMY_TIMESCALE_URI)
+ 
+     end_ts = int(datetime.now().timestamp()) - SECONDS_IN_A_YEAR","As discussed in chat - we should run this function within an app context which means that we'd already have a logger configured, and a connection to timescale set up",Why is this change needed?
+1088,"@@ -33,12 +33,4 @@
+ <div id=""about"" class=""card"">
+   <h2 class='card-header collapsed collapse-toggle' data-toggle=""collapse"" data-target=""#about-content""><a href=""/rails/info/properties"">About your application&rsquo;s environment</a></h2>
+   <div id=""about-content"" class=""card-body collapse""></div>
+-</div>
+-
+-<script>
+-  Blacklight.onLoad(function() {
+-    $('#about .card-header').one('click', function() {
+-      $($(this).data('target')).load($(this).find('a').attr('href'));
+-    });
+-  });
+-</script>
++</div>",I'm curious about why this needed to be removed.,Why was this removed?
+1089,"@@ -17,10 +17,10 @@ from scapy.config import conf
+ from scapy.base_classes import BasePacket,BasePacketList
+ from scapy.utils import do_graph,hexdump,make_table,make_lined_table,make_tex_table,get_temp_file
+ 
+-from scapy.consts import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
++from scapy.extlib import plt, MATPLOTLIB_INLINED, MATPLOTLIB_DEFAULT_PLOT_KARGS
+ from functools import reduce
+ import scapy.modules.six as six
+-from scapy.modules.six.moves import filter, range, zip
++from scapy.modules.six.moves import range, zip
+ 
+ 
+ #############",why did you remove `zip`? It is used!,Why this change?
+1090,"@@ -90,7 +90,7 @@ func (bs *BrokerStatus) MarkTopicUnknown(reason, format string, args ...interfac
+ 	brokerCondSet.Manage(bs).MarkUnknown(BrokerConditionTopic, reason, format, args...)
+ }
+ 
+-func (bs *BrokerStatus) MarkTopicReady() {
++func (bs *BrokerStatus) MarkTopicReady(_ string) {
+ 	brokerCondSet.Manage(bs).MarkTrue(BrokerConditionTopic)
+ }
+ ",Is there any reason that we don't add a similar condition like `ChannelConditionTopic` to the channel?,Why do we need this?
+1091,"@@ -1,4 +1,4 @@
+-<?php namespace TestVendor\Goto;
++<?php namespace TestVendor\_Goto;
+ 
+ use System\Classes\PluginBase;
+ ","before php8 ""goto"" was a reserved word and was not allowed as part of the namespace. Now test checks for validity of plugin namespace according to PSR-4",Why did you change th
+1092,"@@ -85,6 +85,7 @@ func (t *Transport) NewInbound(listener net.Listener, options ...InboundOption)
+ }
+ 
+ // NewSingleOutbound returns a new Outbound for the given adrress.
++// Note: This does not support TLS. See TLS example in doc.go.
+ func (t *Transport) NewSingleOutbound(address string, options ...OutboundOption) *Outbound {
+ 	return newSingleOutbound(t, address, options...)
+ }","nit: I'm not sure it can be addressed in this diff, but it seems odd that NewOutbound supports TLS but NewSingleOutbound does not. As a somewhat naive user I would expect the only difference between these two APIs is how peers are chosen.",// NewSingleOutbound returns a new Outbound for the given adrress.
+1093,"@@ -226,11 +226,17 @@ func (o *Outbound) CallOneway(ctx context.Context, treq *transport.Request) (tra
+ 		return nil, yarpcerrors.InvalidArgumentErrorf(""request for http oneway outbound was nil"")
+ 	}
+ 
+-	_, err := o.call(ctx, treq)
++	// res is used to close the response body to avoid memory/connection leak
++	// even when the response body is empty
++	res, err := o.call(ctx, treq)
+ 	if err != nil {
+ 		return nil, err
+ 	}
+ 
++	if err = res.Body.Close(); err != nil {
++		return nil, yarpcerrors.Newf(yarpcerrors.CodeInternal, err.Error())
++	}
++
+ 	return time.Now(), nil
+ }
+ ",I would advise to enhance the test for the method `CallOneway` - we should have a test very similar to `TestCallSuccess`. We should test: - Success with response (even if it is callOneway) - Success with no response and empty payload - Errors,Why do we close the response body here?
+1094,"@@ -8,7 +8,7 @@ import java.util.regex.Pattern;
+ 
+ public class EmailAddressValidator implements Validator {
+     private static final Pattern EMAIL_ADDRESS_PATTERN = Pattern.compile(
+-          ""[a-zA-Z0-9\\+\\.\\_\\%\\-\\+]{1,256}"" +
++          ""[a-zA-Z0-9\\+\\.\\_\\%\\-]{1,256}"" +
+           ""\\@"" +
+           ""[a-zA-Z0-9][a-zA-Z0-9\\-]{0,64}"" +
+           ""("" +",We're already matching +. Not sure why this changed.,Why is this change needed?
+1095,"@@ -34,6 +34,14 @@ class Configuration implements ConfigurationInterface
+             ->children()
+                 ->scalarNode('db_driver')->isRequired()->end()
+                 ->scalarNode('default_context')->isRequired()->end()
++                ->scalarNode('category_manager')
++                    ->info('if sonata-project/classification exists will set ""sonata.classification.manager.category"" | if you want to define your own category manager you need to implement \Sonata\MediaBundle\Model\CategoryManagerInterface and set the service name here')
++                    ->defaultValue(null)
++                ->end()
++                ->scalarNode('force_disable_category')
++                    ->info('true IF you really want to disable the relation with category')
++                    ->defaultValue(false)
++                ->end()
+             ->end()
+         ;
+ ","Please add line breaks, so the line doesn't exceed 80 chars.",Shouldn't it be `false IF you really want to disable the relation 
+1096,"@@ -29,11 +29,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""AspNetCoreInstrumentation""/> class.
+         /// </summary>
+-        /// <param name=""activitySource"">ActivitySource adapter instance.</param>
+         /// <param name=""options"">Configuration options for ASP.NET Core instrumentation.</param>
+-        public AspNetCoreInstrumentation(ActivitySourceAdapter activitySource, AspNetCoreInstrumentationOptions options)
++        public AspNetCoreInstrumentation(AspNetCoreInstrumentationOptions options)
+         {
+-            this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(new HttpInListener(""Microsoft.AspNetCore"", options, activitySource), null);
++            this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(new HttpInListener(""Microsoft.AspNetCore"", options), null);
+             this.diagnosticSourceSubscriber.Subscribe();
+         }
+ ",I initially thought (inccoreclty) this is a breaking change! The public api analyzer is a gift!,Why did you remove the activity source?
+1097,"@@ -243,7 +243,7 @@ _ostree_delta_compute_similar_objects (OstreeRepo                 *repo,
+ {
+   gboolean ret = FALSE;
+   g_autoptr(GHashTable) ret_modified_regfile_content =
+-    g_hash_table_new_full (g_str_hash, g_str_equal, g_free, (GDestroyNotify)g_ptr_array_unref);
++    g_hash_table_new_full (g_str_hash, g_str_equal, g_free, g_free);
+   g_autoptr(GPtrArray) from_sizes = NULL;
+   g_autoptr(GPtrArray) to_sizes = NULL;
+   guint i, j;",I'm not sure how this one didn't segfault before.,Why did you remove the `(GDestroyNotify
+1098,"@@ -27,6 +27,13 @@ import (
+ )
+ 
+ var _ = Describe(""Endpoints"", func() {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	for _, trueOrFalse := range []bool{true, false} {
+ 		kubeIPVSEnabled := trueOrFalse
+ 		var rrConfigNormalMangleReturn = Config{",Same points as in other test file.,Why do we need these constants?
+1099,"@@ -16,14 +16,7 @@
+  */
+ package org.apache.lucene.analysis.hunspell;
+ 
+-import java.io.BufferedInputStream;
+-import java.io.BufferedOutputStream;
+-import java.io.BufferedReader;
+-import java.io.IOException;
+-import java.io.InputStream;
+-import java.io.InputStreamReader;
+-import java.io.LineNumberReader;
+-import java.io.OutputStream;
++import java.io.*;
+ import java.nio.charset.Charset;
+ import java.nio.charset.CharsetDecoder;
+ import java.nio.charset.CodingErrorAction;","Did you run gradlew tidy? Wildcard imports shouldn't be there, hence the question.",Please don't use wildcard imports.
+1100,"@@ -4,7 +4,11 @@ describe TrailWithProgress do
+   it ""decorates its component"" do
+     user = double(""user"")
+     trail = build_stubbed(:trail)
+-    trail_with_progress = TrailWithProgress.new(trail, user: user)
++    trail_with_progress = TrailWithProgress.new(
++      trail,
++      user: user,
++      status_finder: double(StatusFinder),
++    )
+ 
+     expect(trail_with_progress).to be_a(SimpleDelegator)
+     expect(trail_with_progress.name).to eq(trail.name)",Put a comma after the last parameter of a multiline method call.,I'm not sure if this is the best way to test this.
+1101,"@@ -183,6 +183,11 @@ fpga_result errors_filter(fpga_properties *filter, int argc, char *argv[])
+ 							  FPGA_ACCELERATOR);
+ 			ON_FPGAINFO_ERR_GOTO(
+ 				res, out, ""setting type to FPGA_ACCELERATOR"");
++
++			res = fpgaPropertiesSetInterface(*filter,
++				FPGA_IFC_DFL);
++			ON_FPGAINFO_ERR_GOTO(
++				res, out, ""setting type to FPGA_IFC_DFL"");
+ 			break;
+ 		case VERB_ALL:
+ 		default:",Is this going to restrict the output to *ONLY* ports that are bound to vfio-pci? That's not what we discussed yesterday.,Shouldn't this be `res = fpgaPropertiesSetInterfac
+1102,"@@ -18,6 +18,13 @@ var _ specsruntime.Syscalls = (*syscalls)(nil)
+ 
+ // VerifySignature implements Syscalls.
+ func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) error {
++	// Dragons: this lets all id addresses off the hook -- we need to remove this
++	// once market actor code actually checks proposal signature.  Depending on how
++	// that works we may want to do id address to pubkey address lookup here or we
++	// might defer that to VM
++	if signer.Protocol() == address.ID {
++		return nil
++	}
+ 	return crypto.ValidateSignature(plaintext, signer, signature)
+ }
+ ","Intention is to do the lookup here, I believe (where we can cache it). This would make the call non-pure function though. I'll confirm with lotus. ID addresses are the *only* addresses I expect to actually see here.",Why is this needed?
+1103,"@@ -5,7 +5,7 @@
+ Purpose
+ 
+ Shows how to run an EMRFS command as a job step on an Amazon EMR cluster. This
+-can be used to automate ERMFS commands and is an alternative to connecting through
++can be used to automate EMRFS commands and is an alternative to connecting through
+ SSH to run the commands manually.
+ """"""
+ ",electronic medical record file system (EMRFS),I think this should be `EMRFS`
+1104,"@@ -438,6 +438,7 @@ var directives = []string{
+ 	""mailout"",   // github.com/SchumacherFM/mailout
+ 	""awslambda"", // github.com/coopernurse/caddy-awslambda
+ 	""filter"",    // github.com/echocat/caddy-filter
++	""maxrequestbody"",
+ }
+ 
+ const (","Put this higher in the list, like after ""bind"", since I guess we're considering the max request body size to be kind of a native/fundamental feature, built directly into the vhosts.",I don't think this should be in this PR.
+1105,"@@ -37,13 +37,11 @@ import (
+ )
+ 
+ var (
+-	ErrInvalidOrderType = status.Errorf(codes.InvalidArgument, ""invalid order type"")
+-	ErrAskNotFound      = status.Errorf(codes.NotFound, ""ask not found"")
+-	ErrDeviceNotFound   = status.Errorf(codes.NotFound, ""device not found"")
+-	ErrMinerNotFound    = status.Errorf(codes.NotFound, ""miner not found"")
+-	errDealNotFound     = status.Errorf(codes.NotFound, ""deal not found"")
+-	errTaskNotFound     = status.Errorf(codes.NotFound, ""task not found"")
+-	errImageForbidden   = status.Errorf(codes.PermissionDenied, ""specified image is forbidden to run"")
++	ErrDeviceNotFound = status.Errorf(codes.NotFound, ""device not found"")
++	ErrMinerNotFound  = status.Errorf(codes.NotFound, ""miner not found"")
++	errDealNotFound   = status.Errorf(codes.NotFound, ""deal not found"")
++	errTaskNotFound   = status.Errorf(codes.NotFound, ""task not found"")
++	errImageForbidden = status.Errorf(codes.PermissionDenied, ""specified image is forbidden to run"")
+ 
+ 	hubAPIPrefix = ""/sonm.Hub/""
+ ",oh come on :(,Why did you remove this error?
+1106,"@@ -76,7 +76,7 @@ public class ProtocolHandshake {
+ 
+         if (result.isPresent()) {
+           Result toReturn = result.get();
+-          LOG.info(String.format(""Detected dialect: %s"", toReturn.dialect));
++          LOG.finest(String.format(""Detected dialect: %s"", toReturn.dialect));
+           return toReturn;
+         }
+       }",This is an incorrect change. The dialect spoken is an important part of the handshake and should be communicated to users.,Why is this change needed?
+1107,"@@ -30,6 +30,7 @@ def get_gcloud_info():
+         str: GCP project id
+         str: GCP Authenticated user
+         bool: Whether or not the installer is running in cloudshell
++        bool: Whether or not authenticated user is a service account
+     """"""
+     return_code, out, err = utils.run_command(
+         ['gcloud', 'info', '--format=json'])",Remove as this is not needed anymore.,`bool: Whether or not authenticated user
+1108,"@@ -10,3 +10,11 @@ class Interface:
+ class DoNothing: pass
+ 
+ class DoNothing2: pass
++
++class DoSomething:
++    def __init__(self, a_string: str, optional_int: int = None):
++        self.my_string = a_string
++        self.my_int = optional_int
++
++    def do_it(self, new_int: int) -> int:
++        return self.my_int + new_int",This new class is for checking that #4551 works correctly with PlantUML output too.,Why do we need this class?
+1109,"@@ -168,6 +168,11 @@ func (c *controller) buildCertificates(ctx context.Context, ing *networkingv1bet
+ 					Kind:  issuerKind,
+ 					Group: issuerGroup,
+ 				},
++				Usages: []cmapi.KeyUsage{
++					cmapi.UsageDigitalSignature,
++					cmapi.UsageKeyEncipherment,
++					cmapi.UsageServerAuth, // default for web facing certificates as per https://support.apple.com/en-us/HT210176
++				},
+ 			},
+ 		}
+ ",Will this cause all certificates to be re-issued?,I'm not sure if this is th
+1110,"@@ -215,6 +215,10 @@ fpga_result  enum_max10_metrics_info(struct _fpga_handle *_handle,
+ 		}
+ 		metric_name[strlen(metric_name)-1] = '\0';
+ 
++		if (tmp) {
++			free(tmp);
++		} 
++
+ 		// Metrics typw
+ 		result = read_sensor_sysfs_file(pglob.gl_pathv[i], SENSOR_SYSFS_TYPE, (void **)&tmp, &tot_bytes);
+ 		if (FPGA_OK != result) {",I think tmp is also leaked at the end of this loop if no error cases are encountered.,Why is this needed?
+1111,"@@ -165,13 +165,14 @@ class BuildAvroProjection extends AvroCustomOrderSchemaVisitor<Schema, Schema.Fi
+       try {
+         Schema keyValueSchema = array.getElementType();
+         Schema.Field keyField = keyValueSchema.getFields().get(0);
++        Schema.Field keyProjection = element.get().getField(""key"");
+         Schema.Field valueField = keyValueSchema.getFields().get(1);
+         Schema.Field valueProjection = element.get().getField(""value"");
+ 
+         // element was changed, create a new array
+-        if (valueProjection.schema() != valueField.schema()) {
++        if (keyProjection.schema() != keyField.schema() || valueProjection.schema() != valueField.schema()) {
+           return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(),
+-              AvroSchemaUtil.getFieldId(keyField), keyField.name(), keyField.schema(),
++              AvroSchemaUtil.getFieldId(keyField), keyField.name(), keyProjection.schema(),
+               AvroSchemaUtil.getFieldId(valueField), valueField.name(), valueProjection.schema());
+         } else if (!(array.getLogicalType() instanceof LogicalMap)) {
+           return AvroSchemaUtil.createProjectionMap(keyValueSchema.getFullName(),","The previous version didn't use `keyProjection` because the entire key must be projected. If the key is a struct of multiple columns, then projecting a subset of those columns can easily introduce key collisions that aren't in the original data.",Why do we need this change
+1112,"@@ -26,14 +26,13 @@ void UseExecutor::execute() {
+ 
+     auto spaceName = *sentence_->space();
+     // Check from the cache, if space not exists, schemas also not exist
+-    auto status = ectx()->schemaManager()->checkSpaceExist(spaceName);
+-    if (!status.ok()) {
++    auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);
++    if (spaceId < 0) {
+         DCHECK(onError_);
+         onError_(Status::Error(""Space not found for `%s'"", spaceName.c_str()));
+         return;
+     }
+ 
+-    auto spaceId = ectx()->schemaManager()->toGraphSpaceID(spaceName);
+     session->setSpace(*sentence_->space(), spaceId);
+     FLOG_INFO(""Graph space switched to `%s', space id: %d"", sentence_->space()->c_str(), spaceId);
+ ","Why not use StatusOr ? We can't ensure spaceId is greater than zero, especially when AdHocSchemaManager is used.",Why did you remove this check?
+1113,"@@ -17,11 +17,15 @@ import (
+ 	""context""
+ 	""encoding/json""
+ 	""fmt""
++	""io""
+ 	""os""
+ 	""strings""
++	""time""
+ 
+ 	""github.com/shirou/gopsutil/process""
+ 
++	jrpc ""github.com/ethereum/go-ethereum/rpc""
++
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/bpm""
+ 	pb ""github.com/chaos-mesh/chaos-mesh/pkg/chaosdaemon/pb""",Does it seem we only use that as the json-rpc client? Do we have any other choice? It's a little weird.,Why is this needed?
+1114,"@@ -68,12 +68,13 @@ class ControlField(Field):
+ 			or (role in (controlTypes.ROLE_TABLE, controlTypes.ROLE_TABLECELL, controlTypes.ROLE_TABLEROWHEADER, controlTypes.ROLE_TABLECOLUMNHEADER) and not formatConfig[""reportTables""])
+ 			or (role in (controlTypes.ROLE_LIST, controlTypes.ROLE_LISTITEM) and controlTypes.STATE_READONLY in states and not formatConfig[""reportLists""])
+ 			or (role in (controlTypes.ROLE_FRAME, controlTypes.ROLE_INTERNALFRAME) and not formatConfig[""reportFrames""])
++			or (role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT) and not formatConfig[""reportRevisions""])
+ 		):
+ 			# This is just layout as far as the user is concerned.
+ 			return self.PRESCAT_LAYOUT
+ 
+ 		if (
+-			role in (controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)
++			role in (controlTypes.ROLE_DELETED_CONTENT,controlTypes.ROLE_INSERTED_CONTENT,controlTypes.ROLE_LINK, controlTypes.ROLE_HEADING, controlTypes.ROLE_BUTTON, controlTypes.ROLE_RADIOBUTTON, controlTypes.ROLE_CHECKBOX, controlTypes.ROLE_GRAPHIC, controlTypes.ROLE_CHART, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_TAB, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_SLIDER, controlTypes.ROLE_SPINBUTTON, controlTypes.ROLE_COMBOBOX, controlTypes.ROLE_PROGRESSBAR, controlTypes.ROLE_TOGGLEBUTTON, controlTypes.ROLE_MENUBUTTON, controlTypes.ROLE_TREEVIEW, controlTypes.ROLE_CHECKMENUITEM, controlTypes.ROLE_RADIOMENUITEM)
+ 			or (role == controlTypes.ROLE_EDITABLETEXT and controlTypes.STATE_MULTILINE not in states and (controlTypes.STATE_READONLY not in states or controlTypes.STATE_FOCUSABLE in states))
+ 			or (role == controlTypes.ROLE_LIST and controlTypes.STATE_READONLY not in states)
+ 		):",Could you split this into multiple lines?,E231 missing whitespace after 
+1115,"@@ -19,14 +19,11 @@
+ 
+ package org.apache.iceberg;
+ 
+-import java.util.Collection;
+ import java.util.List;
+ import java.util.Set;
+-import org.apache.iceberg.expressions.Expression;
+ import org.apache.iceberg.io.CloseableIterable;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.relocated.com.google.common.collect.FluentIterable;
+-import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+ import org.apache.iceberg.relocated.com.google.common.collect.Iterables;
+ import org.apache.iceberg.relocated.com.google.common.collect.Lists;
+ import org.apache.iceberg.relocated.com.google.common.collect.Sets;",Doesn't the snapshot ID start off as null? It seems like we don't need to set it here.,Why is this removed?
+1116,"@@ -93,7 +93,7 @@ func (t *V4Trie) Get(cidr V4CIDR) interface{} {
+ }
+ 
+ func (t *V4Trie) LookupPath(buffer []V4TrieEntry, cidr V4CIDR) []V4TrieEntry {
+-	return t.root.lookupPath(buffer, cidr)
++	return t.root.lookupPath(buffer[:0], cidr)
+ }
+ 
+ // LPM does a longest prefix match on the trie","I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?",why is this change needed?
+1117,"@@ -173,7 +173,9 @@ func (c *Expected) validateMining(ctx context.Context,
+ 	parentWeight fbig.Int,
+ 	parentReceiptRoot cid.Cid) error {
+ 
+-	powerTable := NewPowerTableView(c.state.StateView(parentStateRoot))
++	stateView := c.state.StateView(parentStateRoot)
++	sigValidator := NewSignatureValidator(stateView)
++	powerTable := NewPowerTableView(stateView)
+ 
+ 	for i := 0; i < ts.Len(); i++ {
+ 		blk := ts.At(i)",nit: Ideally we would would use this abstraction everywhere we need this translation. I believe it's needed in the mining worker and the storage and market connectors.,Why is this needed?
+1118,"@@ -169,6 +169,13 @@ func (c *CStorPoolController) cStorPoolAddEventHandler(cStorPoolGot *apis.CStorP
+ 					glog.Infof(""Pool %v is online"", string(pool.PoolPrefix)+string(cStorPoolGot.GetUID()))
+ 					c.recorder.Event(cStorPoolGot, corev1.EventTypeNormal, string(common.AlreadyPresent), string(common.MessageResourceAlreadyPresent))
+ 					common.SyncResources.IsImported = true
++					if GetHash(cStorPoolGot) == """" {
++						hash, err := common.CalculateHash(cStorPoolGot.Spec.Disks.DiskList)
++						if err != nil {
++							glog.Errorf(""Failed to update openebs.io/csp-disk-hash value: %v"", err)
++						}
++						UpdateHash(cStorPoolGot, hash)
++					}
+ 					return string(apis.CStorPoolStatusOnline), nil
+ 				}
+ 				glog.Infof(""Pool %v already present"", string(pool.PoolPrefix)+string(cStorPoolGot.GetUID()))",need to fix the error message here,I think it would be good t
+1119,"@@ -17,7 +17,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+         internal const string DEFAULT_POLICY_NAME = ""default"";
+ 
+         public PropertyBagDictionary() : base() { }
+-
++        //CA1026 not fixed
+         public PropertyBagDictionary(
+             PropertyBagDictionary initializer = null,
+             IEqualityComparer<string> comparer = null)",Unsure of how to handle this one.,Why is this needed?
+1120,"@@ -1268,7 +1268,9 @@ public class FlowRunner extends EventHandler<Event> implements Runnable {
+ 
+   public void kill() {
+     synchronized (this.mainSyncObj) {
+-      if (isKilled()) {
++      if (isKilled() || this.flowFinished) {
++        this.logger.info(
++            ""Dropping Kill action as execution "" + this.execId + "" is already finished."");
+         return;
+       }
+       this.logger.info(""Kill has been called on execution "" + this.execId);","Will this.flowFinished verify with every finished state stated in Status.isStatusFinished method? If so, no need to verify isKilled.",Shouldn't this be `this.flowFinished`?
+1121,"@@ -0,0 +1,11 @@
++package common
++
++// DefaultRetrySettings indicates what the ""default"" retry settings
++// are if it is not specified on an Activity or for any unset fields
++// if a policy is explicitly set on a Child Workflow
++type DefaultRetrySettings struct {
++	InitialIntervalInSeconds   int32
++	MaximumIntervalCoefficient float64
++	BackoffCoefficient         float64
++	MaximumAttempts            int32
++}","replace ""Child Workflow"" with ""any workflow""",I don't think we need this file.
+1122,"@@ -426,7 +426,9 @@ footer {
+ 								<span class=""name"">{{html .Name}}</span>
+ 							</a>
+ 						</td>
+-						{{- if .IsDir}}
++						{{- if .IsSymlink }}
++						<td data-order=""-1"">symbolic link</td>
++						{{- else if .IsDir}}
+ 						<td data-order=""-1"">&mdash;</td>
+ 						{{- else}}
+ 						<td data-order=""{{.Size}}"">{{.HumanSize}}</td>","Instead of showing the words ""symbolic link"" under the ""Size"" column, how about we introduce new icons for symbolic link to file and symbolic link to directory?",I don't think this is the right place 
+1123,"@@ -47,9 +47,10 @@ class DateRange implements FilterEncoder, FacetBuilder
+      * Parses the given date range from a GET parameter and returns a Solr
+      * date range filter.
+      *
+-     * @param string $rangeFilter The range filter query string from the query URL
++     * @param string $dateRange
+      * @param array $configuration Facet configuration
+      * @return string Lucene query language filter to be used for querying Solr
++     * @internal param string $rangeFilter The range filter query string from the query URL
+      */
+     public function decodeFilter($dateRange, array $configuration = array())
+     {",Please add back the description of the parameter,why is this internal?
+1124,"@@ -17,7 +17,7 @@ function GraphiteBrowser () {
+   var searchPanel = createSearchPanel();
+   var completerPanel = createCompleterPanel();
+   var treeRoot = treePanel.getRootNode();
+-
++   
+   this.trees = {
+     graphite: treeRoot.findChild('id', 'GraphiteTree'),
+     mygraphs: treeRoot.findChild('id', 'MyGraphsTree'),",Superfluous space inserted.,Unexpected trailing comma comma-dangle
+1125,"@@ -8,7 +8,9 @@
+  * @returns {Object}
+  */
+ dom.urlPropsFromAttribute = function urlPropsFromAttribute(node, attribute) {
+-	const value = node[attribute];
++	const value = !node.ownerSVGElement
++		? node[attribute]
++		: node.getAttribute(attribute);
+ 	if (!value) {
+ 		return undefined;
+ 	}","Didn't fix the problem. `href=""""` for SVG will still result in `undefined` getting returned by this function.",Why is this change necessary?
+1126,"@@ -69,13 +69,13 @@ BOOST_AUTO_TEST_CASE(test_route_same_coordinates_fixture)
+                                                    json::Object{{
+                                                        {""location"", location},
+                                                        {""bearing_before"", 0},
+-                                                       {""bearing_after"", 58},
++                                                       {""bearing_after"", 238},
+                                                        {""type"", ""depart""},
+                                                    }}},
+                                                   {""intersections"",
+                                                    json::Array{{json::Object{
+                                                        {{""location"", location},
+-                                                        {""bearings"", json::Array{{58}}},
++                                                        {""bearings"", json::Array{{238}}},
+                                                         {""entry"", json::Array{{json::True()}}},
+                                                         {""out"", 0}}}}}}}}},
+ ",This seems like a strange change ... I wouldn't think that a change to access tags in the profiles would result in different bearings in this tests?,why did this change?
+1127,"@@ -90,10 +90,10 @@ class AppModule(appModuleHandler.AppModule):
+ 			# Move the review cursor so others can't access its previous position.
+ 			self._oldReviewPos = api.getReviewPosition()
+ 			self._oldReviewObj = self._oldReviewPos.obj
+-			api.setNavigatorObject(eventHandler.lastQueuedFocusObject)
++			api.setNavigatorObject(eventHandler.lastQueuedFocusObject, isFocus=True)
+ 
+ 	def event_appModule_loseFocus(self):
+ 		if not config.conf[""reviewCursor""][""followFocus""]:
+-			api.setReviewPosition(self._oldReviewPos)
++			api.setReviewPosition(self._oldReviewPos, isCaret=False)
+ 			del self._oldReviewPos, self._oldReviewObj
+ 		inputCore.manager._captureFunc = None","As isCaret is False by default, explicitly specifying isCaret=False here is not needed, and is perhaps a little confusing. I'd prefer that anywhere in the codebase that isCaret is only ever specified if it needs to be set to true. Mirroring that of isFocus for setNavigatorObject.",Why is this change needed?
+1128,"@@ -38,7 +38,7 @@ module Selenium
+         port
+       end
+ 
+-      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
++      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL].freeze
+       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+       IGNORED_ERRORS.freeze
+ ",We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it.,Why is this necessary?
+1129,"@@ -368,5 +368,9 @@ func consolidateAutomationPolicies(aps []*caddytls.AutomationPolicy) []*caddytls
+ 		return len(aps[i].Subjects) > len(aps[j].Subjects)
+ 	})
+ 
++	for i := 0; i < len(aps); i++ {
++		sort.Strings(aps[i].Subjects)
++	}
++
+ 	return aps
+ }",Why is this needed?,Why do we need this?
+1130,"@@ -215,6 +215,9 @@ func RegisterRoutes(m *macaron.Macaron) {
+ 		}, reqToken())
+ 
+ 		// Repositories
++		m.Get(""/users/:username/repos"", repo.ListUserRepos)
++		m.Get(""/orgs/:org/repos"", repo.ListOrgRepos)
++
+ 		m.Combo(""/user/repos"", reqToken()).Get(repo.ListMyRepos).
+ 			Post(bind(api.CreateRepoOption{}), repo.Create)
+ 		m.Post(""/org/:org/repos"", reqToken(), bind(api.CreateRepoOption{}), repo.CreateOrgRepo)",Why not put two other routes after this line (221)?,I think this should be
+1131,"@@ -25,9 +25,10 @@ ExecutionEngine::~ExecutionEngine() {
+ 
+ Status ExecutionEngine::init(std::shared_ptr<folly::IOThreadPoolExecutor> ioExecutor) {
+     auto addrs = network::NetworkUtils::toHosts(FLAGS_meta_server_addrs);
+-    if (!addrs.ok()) {
++    if (!addrs.ok() || addrs.value().empty()) {
+         return addrs.status();
+     }
++
+     metaClient_ = std::make_unique<meta::MetaClient>(ioExecutor, std::move(addrs.value()));
+     metaClient_->init();
+ ","If FLAGS_meta_server_addrs is not empty, in which case ""toHosts"" return empty array?",Why do we need this ch
+1132,"@@ -216,6 +216,8 @@ void ResetFactory()
+    */
+   Settings.I2C_clockSpeed = DEFAULT_I2C_CLOCK_SPEED;
+ 
++  Settings.JSONBoolWithQuotes(DEFAULT_JSON_USE_QUOTES);
++
+ #ifdef PLUGIN_DESCR
+   strcpy_P(Settings.Name, PSTR(PLUGIN_DESCR));
+ #endif // ifdef PLUGIN_DESCR","There is a function to output a ""JSONBool"" string. That would be a good start for finding uses. But maybe just have a look at where we decide whether it is a numerical or not, thus wrapping quotes around its value. Then you have it all I guess.",Why is this needed?
+1133,"@@ -90,8 +90,9 @@ class SampledPlot:
+             sampled = data._sdf.sample(fraction=float(self.fraction))
+             return DataFrame(data._internal.copy(sdf=sampled)).to_pandas()
+         elif isinstance(data, Series):
++            scol = data._kdf._internal.data_scols[0]
+             sampled = data._kdf._sdf.sample(fraction=float(self.fraction))
+-            return DataFrame(data._kdf._internal.copy(sdf=sampled)).to_pandas()
++            return DataFrame(data._kdf._internal.copy(sdf=sampled, scol=scol)).to_pandas()
+         else:
+             ValueError(""Only DataFrame and Series are supported for plotting."")
+ ","oops, it should be `data._scol` so that it respects the expression stored in Series. Let me fix it quick.",I think this should
+1134,"@@ -1,6 +1,7 @@
+ <% administrator = Role.new(administrator: true, editor: true, commenter: true) %>
+ <% editor = Role.new(editor: true, commenter: true) %>
+ <% commenter = Role.new(commenter: true) %>
++<% administerable = @plan.administerable_by?(current_user) %>
+ 
+ <h2><%= _('Set plan visibility') %></h2>
+ <p class=""form-control-static""><%= _('Public or organisational visibility is intended for finished plans. You must answer at least %{percentage}%% of the questions to enable these options. Note: test plans are set to private visibility by default.') % { :percentage => Rails.application.config.default_plan_percentage_answered } %></p>",Thanks for moving this up with the rest of the variables. Much tidier :),I think this should
+1135,"@@ -38,6 +38,12 @@ import (
+ // DefaultAccountantFailureCount defines how many times we're allowed to fail to reach accountant in a row before announcing the failure.
+ const DefaultAccountantFailureCount uint64 = 3
+ 
++// DefaultPaymentInfo represents the default payment info for the alpha release
++var DefaultPaymentInfo = dto.PaymentPerTime{
++	Price:    money.NewMoney(0.001, money.CurrencyMyst),
++	Duration: 1 * time.Minute,
++}
++
+ // InvoiceFactoryCreator returns a payment engine factory.
+ func InvoiceFactoryCreator(
+ 	dialog communication.Dialog,",I think `Rate` is a more precise and concise term for `PaymentPerTime`.,Why is this needed?
+1136,"@@ -213,7 +213,7 @@ namespace pwiz.Skyline.Util
+                 {
+                     // No leading + or - : is it because description starts with a label, or because + mode is implied?
+                     var limit = input.IndexOfAny(new[] { '+', '-', ']' });
+-                    if (limit < 0)
++                    if (limit < posNext)
+                     {
+                         return null;
+                     }","I think this should maybe be: var limit = input.IndexOfAny(new[] { '+', '-', ']' }, **posNext**); You pretty much want to ignore any sign that is before the ""M"". But, if there is a sign somewhere before the M, and also after the M, you'd want to be able to find the sign after the M, right?",Why is this change needed?
+1137,"@@ -263,7 +263,12 @@ class OrderController extends BaseFrontController
+ 
+         /* check cart count */
+         $this->checkCartNotEmpty();
+-
++        
++        /* check stock not empty */
++        if(true === ConfigQuery::checkAvailableStock()) {
++          $this->checkStockNotEmpty();
++        }
++        
+         /* check delivery address and module */
+         $this->checkValidDelivery();
+ ","if `checkStockNotEmpty` returns a reponse, you must return it or your script will continue its execution.",please add a space after `
+1138,"@@ -46,7 +46,7 @@ import (
+ 	""github.com/prometheus/common/version""
+ 	""golang.org/x/sync/errgroup""
+ 	v1 ""k8s.io/api/core/v1""
+-	""k8s.io/klog/v2""
++	klogv2 ""k8s.io/klog/v2""
+ )
+ 
+ const (",Any specific reason for this change? klog should work correctly here.,Why is this needed?
+1139,"@@ -243,6 +243,9 @@ class Storage(StorageBase):
+         VALUES (:object_id, :parent_id,
+                 :collection_id, (:data)::JSONB,
+                 from_epoch(:last_modified))
++        ON CONFLICT (id, parent_id, collection_id) DO UPDATE
++        SET data = (:data)::JSONB,
++            last_modified = from_epoch(:last_modified)
+         RETURNING id, as_epoch(last_modified) AS last_modified;
+         """"""
+         placeholders = dict(object_id=record[id_field],",we don't mention `last_modified` here?,Line is too long. [81/80]
+1140,"@@ -1,6 +1,10 @@
+-const html = require('yo-yo')
+ const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl
+ 
+ module.exports = (props) => {
+   const isHidden = Object.keys(props.files).length === 0",same deal about the global state maybe interfering as in ActionBrowseTagline,Why do we need this?
+1141,"@@ -172,5 +172,17 @@ namespace Nethermind.Core.Test.Caching
+ 
+             count.Should().Be(itemsToKeep);
+         }
++
++        [Test]
++        public void Wrong_capacity_number_at_constructor()
++        {
++            int maxCapacity = 0;
++
++            Assert.Throws<ArgumentOutOfRangeException>(() => 
++                {
++                    LruCache<int, int> cache = new LruCache<int, int>(maxCapacity, ""test"");
++                });
++
++        }
+     }
+ }",so sweet to see a test as the first thing,Nit: I think this sh
+1142,"@@ -161,6 +161,12 @@ struct flb_config *flb_config_init()
+     config->http_port    = flb_strdup(FLB_CONFIG_HTTP_PORT);
+ #endif
+ 
++    config->http_proxy = getenv(""HTTP_PROXY"");
++    if (strcmp(config->http_proxy, """")) {
++        /* Proxy should not be set when the `HTTP_PROXY` is set to """" */
++        config->http_proxy = NULL;
++    }
++
+     config->cio          = NULL;
+     config->storage_path = NULL;
+     config->storage_input_plugin = NULL;","usually when HTTP_PROXY="""" (empty), proxy should be disabled. could you set it to NULL when it's empty string?",Shouldn't this be `s
+1143,"@@ -62,6 +62,10 @@ class SimpleResizer implements ResizerInterface
+         if ($settings['height'] == null) {
+             $settings['height'] = (int) ($settings['width'] * $size->getHeight() / $size->getWidth());
+         }
++        
++        if ($settings['width'] == null) {
++            $settings['width'] = (int) ($settings['height'] * $size->getWidth() / $size->getHeight());
++        }
+ 
+         return $this->computeBox($media, $settings);
+     }",Can you throw an exception if width or height are both null,Why is this needed?
+1144,"@@ -26,8 +26,8 @@ import (
+ )
+ 
+ var (
+-	HTTPSchemeHTTP  = HTTPSchemeKey.String(""http"")
+-	HTTPSchemeHTTPS = HTTPSchemeKey.String(""https"")
++	httpSchemeHTTP  = HTTPSchemeKey.String(""http"")
++	httpSchemeHTTPS = HTTPSchemeKey.String(""https"")
+ )
+ 
+ // NetAttributesFromHTTPRequest generates attributes of the net",This is a breaking change. I guess these might have been intentionally exported.,Why is this change needed?
+1145,"@@ -225,6 +225,8 @@ abstract class BaseTableScan implements TableScan {
+     long splitSize;
+     if (options.containsKey(TableProperties.SPLIT_SIZE)) {
+       splitSize = Long.parseLong(options.get(TableProperties.SPLIT_SIZE));
++    } else if (options.containsKey(TableProperties.METADATA_SPLIT_SIZE)) {
++      splitSize = Long.parseLong(options.get(TableProperties.METADATA_SPLIT_SIZE));
+     } else {
+       splitSize = targetSplitSize(ops);
+     }","I don't think this is necessary. When options are used to set the split size in the Spark reader, it uses `TableProperties.SPLIT_SIZE` to pass it here. That should work for metadata tables as well, right? The situation that we need to handle in this PR is setting the default, like you had before. We just want to use a metadata split size so you can set it and not have the same split size used (by default) for both metadata and data scans.",Why do we need this?
+1146,"@@ -267,6 +267,10 @@ const (
+ 	Add Operator = '+'
+ 	// Subtract implements binary - (only works on integers)
+ 	Subtract = '-'
++	// Multiply implements multiplication between two types
++	Multiply = '×'
++	// Divide implements division, currently only between integers
++	Divide = '÷'
+ 	// Modulo implements % (including string interpolation)
+ 	Modulo = '%'
+ 	// LessThan implements <","wait a sec, shouldn't this be `'*'`?",Why do we need this?
+1147,"@@ -127,6 +127,9 @@ func (oi *OVFImporter) buildDaisyVars(bootDiskImageURI string, machineType strin
+ 	varMap[""boot_disk_image_uri""] = bootDiskImageURI
+ 	if oi.params.IsInstanceImport() {
+ 		varMap[""instance_name""] = oi.params.InstanceNames
++		if oi.params.ComputeServiceAccount != """" {
++			varMap[""compute_service_account""] = oi.params.ComputeServiceAccount
++		}
+ 	} else {
+ 		varMap[""machine_image_name""] = oi.params.MachineImageName
+ 	}",It think you'll want the var for GMI import as well: daisy_workflows/ovf_import/create_gmi.wf.json (Unfortunately there's duplication between the two :/ ),Why do we need this?
+1148,"@@ -21,6 +21,7 @@ from selenium.webdriver.remote.remote_connection import RemoteConnection
+ class FirefoxRemoteConnection(RemoteConnection):
+     def __init__(self, remote_server_addr, keep_alive=True):
+         RemoteConnection.__init__(self, remote_server_addr, keep_alive)
++        self._commands[""GET_CONTEXT""] = ('GET', '/session/$sessionId/moz/context')
+ 
+         self._commands[""SET_CONTEXT""] = (""POST"", ""/session/$sessionId/moz/context"")
+         self._commands[""ELEMENT_GET_ANONYMOUS_CHILDREN""] = \",Nit: Group this with the other commands by moving it down one line.,Why is this needed?
+1149,"@@ -512,6 +512,9 @@ public class VectorizedPageIterator extends BasePageIterator {
+         throw new ParquetDecodingException(""could not read page in col "" + desc, e);
+       }
+     } else {
++      if (dataEncoding != Encoding.PLAIN) {
++        throw new UnsupportedOperationException(""Unsupported encoding: "" + dataEncoding);
++      }
+       plainValuesReader = new ValuesAsBytesReader();
+       plainValuesReader.initFromPage(valueCount, in);
+       dictionaryDecodeMode = DictionaryDecodeMode.NONE;","I would like to emphasize that a user can use non-vectorized reads to handle this file so maybe something like ""Cannot perform a vectorized read of ParquetV2 File with encoding %s, disable vectorized reading with $param to read this table/file""",Why do we need this
+1150,"@@ -101,6 +101,10 @@ class RangeBase(luigi.WrapperTask):
+     now = luigi.IntParameter(
+         default=None,
+         description=""set to override current time. In seconds since epoch"")
++    param_name = luigi.Parameter(
++        default=None,
++        description=""parameter name used to pass in parameterized value. Defaults to None, meaning use first positional parameter"",
++        positional=False)
+ 
+     @property
+     def of_cls(self):","Maybe add `positional=False`. It does not need it more than the other parameters, but one must start somewhere.",I don't think this 
+1151,"@@ -9,8 +9,8 @@ const expect = require('chai').expect,
+   MongoError = require('../../../lib/core/error').MongoError,
+   ReadPreference = require('../../../lib/core/topologies/read_preference');
+ 
+-const rsWithPrimaryPath = f('%s/../spec/max-staleness/ReplicaSetWithPrimary', __dirname);
+-const rsWithoutPrimaryPath = f('%s/../spec/max-staleness/ReplicaSetNoPrimary', __dirname);
++const rsWithPrimaryPath = f('%s/../../spec/max-staleness/ReplicaSetWithPrimary', __dirname);
++const rsWithoutPrimaryPath = f('%s/../../spec/max-staleness/ReplicaSetNoPrimary', __dirname);
+ 
+ describe('Max Staleness', function() {
+   describe('ReplicaSet without primary', function() {","Since we're here, can we use a template?",Why this change?
+1152,"@@ -214,3 +214,10 @@ def postgres_db_info_resource(init_context):
+         dialect='postgres',
+         load_table=_do_load,
+     )
++
++
++if __name__ == '__main__':
++    # This is a brutal hack. When the SparkSession is created for the first time there is a lengthy
++    # download process from Maven. This allows us to run python -m airline_demo.resources in the
++    # Dockerfile and avoid a long runtime delay before each containerized solid executes.
++    spark_session_local.resource_fn(None)",saw you're also doing this in `test_types.py`: `spark = _spark_context()['test'].resources['spark'].resource_fn(None)` since `_spark_context()` uses `spark_session_local` won't the above break the tests?,I'm not sure if this is the best way to do this.
+1153,"@@ -49,10 +49,10 @@ var _ = Context(""with initialized Felix, etcd datastore, 3 workloads"", func() {
+ 		defaultProfile := api.NewProfile()
+ 		defaultProfile.Name = ""default""
+ 		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.EgressRules = []api.Rule{{Action: ""allow""}}
++		defaultProfile.Spec.EgressRules = []api.Rule{{Action: api.Allow}}
+ 		defaultProfile.Spec.IngressRules = []api.Rule{{
+-			Action: ""allow"",
+-			Source: api.EntityRule{Tag: ""default""},
++			Action: api.Allow,
++			Source: api.EntityRule{Selector: ""default == ''""},
+ 		}}
+ 		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+ 		Expect(err).NotTo(HaveOccurred())",`has(default)` i think is the preferred way of doing this,Why do we need this change?
+1154,"@@ -35,9 +35,11 @@ class ScalarSpaceEncoderTest(unittest.TestCase):
+   def testScalarSpaceEncoder(self):
+     """"""scalar space encoder""""""
+     # use of forced=True is not recommended, but used in the example for readibility, see scalar.py
+-    sse = ScalarSpaceEncoder(1,1,2,False,2,1,1,None,0,False,""delta"", forced=True)
++    sse = ScalarSpaceEncoder(w=21,minval=1,maxval=2,n=100,radius=1,
++            resolution=1,name=""SP1"",verbosity=0,clipInput=False,space=""delta"")
+     self.assertTrue(sse.isDelta())
+-    sse = ScalarSpaceEncoder(1,1,2,False,2,1,1,None,0,False,""absolute"", forced=True)
++    sse = ScalarSpaceEncoder(w=21,minval=1,maxval=2,n=100,radius=1,
++            resolution=1,name=""sp2"",verbosity=0,clipInput=False,space=""absolute"")
+     self.assertFalse(sse.isDelta())
+ 
+      ",always put a space after a comma,PEP8: space after comma
+1155,"@@ -289,6 +289,10 @@ public class LFMainActivity extends SharedMediaActivity {
+                     mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
+                     editMode = true;
+                 }
++                else
++                {
++                    selectAllPhotosUpToFav(getImagePosition(m.getPath()));
++                }
+             } else selectAllPhotosUpTo(getImagePosition(m.getPath()), mediaAdapter);
+             return true;
+         }","@angmas1 move the else up, next to the closing bracket of the if block. Also, there is no need for the braces as your else statement contains only a single line. Make your if-else block similar to the block in lines 277-280.",Why is this needed?
+1156,"@@ -111,7 +111,7 @@ class WebDriver(object):
+ 
+     def __init__(self, command_executor='http://127.0.0.1:4444/wd/hub',
+                  desired_capabilities=None, browser_profile=None, proxy=None,
+-                 keep_alive=False, file_detector=None):
++                 keep_alive=False, file_detector=None, options=None):
+         """"""
+         Create a new driver that will issue commands using the wire protocol.
+ ",@AutomatedTester @davehunt thoughts on a new keyword argument?,This should be `options=None`
+1157,"@@ -44,7 +44,7 @@ public class NodeStatus {
+   public NodeStatus(
+       NodeId nodeId,
+       URI externalUri,
+-      int maxSessionCount,
++      Integer maxSessionCount,
+       Set<Slot> slots,
+       Availability availability) {
+     this.nodeId = Require.nonNull(""Node id"", nodeId);",This change shouldn't be necessary for this PR. Please remove it.,Why did you change this?
+1158,"@@ -27,7 +27,8 @@ import (
+ )
+ 
+ func testAlertmanagerInstanceNamespacesAllNs(t *testing.T) {
+-	ctx := framework.NewTestCtx(t)
++	testCtx := framework.NewTestCtx(t)
++	ctx := &testCtx
+ 	defer ctx.Cleanup(t)
+ 
+ 	// create 3 namespaces:","This variable is mostly unused, how about we make `NewTestCtx` return a pointer?",Why this change?
+1159,"@@ -7,6 +7,10 @@ import (
+ 	""k8s.io/klog/v2""
+ )
+ 
++const (
++	maxPayloadLen = 32 * 1 << 20 // 32Mi
++)
++
+ type Reader struct {
+ 	reader io.Reader
+ }",What is the basis of this value?,Why do we need this?
+1160,"@@ -28,6 +28,7 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+ 
++#include ""gce_metadata.h""
+ #include ""stackdriver.h""
+ #include ""stackdriver_conf.h""
+ ",Nit: was this extra blank line added intentionally?,"#include ""stackdriver.h"""
+1161,"@@ -5837,6 +5837,12 @@ initialize_exception_record(EXCEPTION_RECORD* rec, app_pc exception_address,
+     case ILLEGAL_INSTRUCTION_EXCEPTION:
+         rec->ExceptionCode = EXCEPTION_ILLEGAL_INSTRUCTION;
+         break;
++    case GUARD_PAGE_EXCEPTION:
++        rec->ExceptionCode = STATUS_GUARD_PAGE_VIOLATION;
++        rec->NumberParameters = 2;
++        rec->ExceptionInformation[0]=EXCEPTION_EXECUTE_FAULT /* execution tried */;
++        rec->ExceptionInformation[1]=(ptr_uint_t)exception_address;
++        break;
+     default:
+         ASSERT_NOT_REACHED();
+     }",nit: inconsistent spacing around =,Shouldn't this be `EXCEP
+1162,"@@ -12,7 +12,6 @@
+ namespace Sonata\MediaBundle\Model;
+ 
+ use Imagine\Image\Box;
+-use Sonata\ClassificationBundle\Model\CategoryInterface;
+ use Symfony\Component\Validator\Context\ExecutionContextInterface;
+ use Symfony\Component\Validator\ExecutionContextInterface as LegacyExecutionContextInterface;
+ ",We still need this import,Why did you remove this?
+1163,"@@ -60,7 +60,7 @@ public class TestBinPackStrategy extends TableTestBase {
+     }
+ 
+     @Override
+-    public Set<DataFile> rewriteFiles(String groupId, List<FileScanTask> filesToRewrite) {
++    public Set<DataFile> rewriteFiles(List<FileScanTask> filesToRewrite) {
+       throw new UnsupportedOperationException();
+     }
+   }","We are pulling this because we removed ""groupID"" state and put it into the strategy implementations",Why did you remove the g
+1164,"@@ -17,8 +17,7 @@
+ #include <CL/sycl.hpp>
+ 
+ #include ""gtest/gtest.h""
+-#define ONEAPI_DAL_DATA_PARALLEL
+-#include ""oneapi/dal/algo/kmeans_init.hpp""
++#include ""oneapi/dal/algo/kmeans_init/compute.hpp""
+ #include ""oneapi/dal/table/homogen.hpp""
+ #include ""oneapi/dal/table/row_accessor.hpp""
+ ",Is this file actually related to PCA?,compute.hpp  kmeans_init
+1165,"@@ -6,7 +6,7 @@ import createEnableTracking from './createEnableTracking';
+ import createTrackEvent from './createTrackEvent';
+ 
+ const DEFAULT_CONFIG = {
+-	isFirstAdmin: false,
++	isOwner: false,
+ 	trackingEnabled: false,
+ 	trackingID: '',
+ 	referenceSiteURL: '',","See above, this should probably remain `isFirstAdmin`.",I think this should be `
+1166,"@@ -499,7 +499,7 @@ type ArrayExpression struct {
+ 
+ 	Elements []Expression
+ 
+-	typ MonoType
++	Type MonoType
+ }
+ 
+ func (*ArrayExpression) NodeType() string { return ""ArrayExpression"" }",Why the change to make it public? The expression interface has the `TypeOf` method?,Why did you change this?
+1167,"@@ -1562,7 +1562,7 @@ namespace NLog.UnitTests.Targets
+         }
+ 
+         [Fact]
+-        public void Single_Archive_File_Rolls_Correctly()
++        public void SingleArchiveFileRollsCorrectly()
+         {
+             var tempPath = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
+             var tempFile = Path.Combine(tempPath, ""file.txt"");","don't mind the snake cases in the test names. If there are in the test cases, it's fine IMO",Why did you change this 
+1168,"@@ -28,6 +28,11 @@ type identityRegistrationDto struct {
+ 	Registered bool `json:""registered""`
+ }
+ 
++type identityUnlockingDto struct {
++	Id         string `json:""id""`
++	Passphrase string `json:""passphrase""`
++}
++
+ type identitiesApi struct {
+ 	idm             identity.IdentityManagerInterface
+ 	mysteriumClient server.Client",`Id` defines REST resource address and should not be in payload,Why do we need this?
+1169,"@@ -20,8 +20,11 @@ def main():
+         nargs='+',
+         default=[100, 300, 1000],
+         help='proposal numbers, only used for recall evaluation')
++    parser.add_argument(
++        '--class_wise', action='store_true', help='whether eval class wise ap')
+     args = parser.parse_args()
+-    coco_eval(args.result, args.types, args.ann, args.max_dets)
++    coco_eval(args.result, args.types, args.ann, args.max_dets,
++              args.class_wise)
+ 
+ 
+ if __name__ == '__main__':",We can omit the underscore and just use `classwise`.,`--class-wise` is a 
+1170,"@@ -77,10 +77,12 @@ class MediaAdminController extends Controller
+         $datagrid->setValue('context', null, $context);
+ 
+         // retrieve the main category for the tree view
+-        $category = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);
++        $rootCategory = $this->container->get('sonata.classification.manager.category')->getRootCategory($context);
++        // This should be safe as the root category has to exist for a given context but I do not like fatal errors
++        $rootCategoryId = !empty($rootCategory) ? $rootCategory->getId() : null;
+ 
+         if (!$filters) {
+-            $datagrid->setValue('category', null, $category);
++            $datagrid->setValue('category', null, $rootCategoryId);
+         }
+         if ($request->get('category')) {
+             $categoryByContext = $this->container->get('sonata.classification.manager.category')->findOneBy(array(",Why not throw an exception instead then?,Why not using `$root
+1171,"@@ -71,8 +71,7 @@ abstract class DataIterator<T> implements CloseableIterator<T> {
+ 
+   InputFile getInputFile(FileScanTask task) {
+     Preconditions.checkArgument(!task.isDataTask(), ""Invalid task type"");
+-
+-    return inputFiles.get(task.file().path().toString());
++    return getInputFile(task.file().path().toString());
+   }
+ 
+   InputFile getInputFile(String location) {",Looks like this doesn't need to change. Can you revert this?,`getInputFile` -> `g
+1172,"@@ -3,6 +3,7 @@ import sys
+ from cliquet.scripts import cliquet
+ from pyramid.scripts import pserve
+ from pyramid.paster import bootstrap
++from config import template
+ 
+ CONFIG_FILE = 'config/kinto.ini'
+ ",please import it like `from kinto.config import template`,This should be `from config import template`
+1173,"@@ -173,7 +173,7 @@ public final class Configuration {
+   }
+ 
+   public boolean isIsolationFilterOpen(String microservice) {
+-    String p = getStringProperty(""false"",
++    String p = getStringProperty(""true"",
+         PROP_ROOT + microservice + ""."" + FILTER_ISOLATION + FILTER_OPEN,
+         PROP_ROOT + FILTER_ISOLATION + FILTER_OPEN);
+     return Boolean.parseBoolean(p);","There are lots of default value changed, not sure if it break the old behavior.",Why did you change this?
+1174,"@@ -10,13 +10,15 @@ import (
+ 	""context""
+ 	""encoding/hex""
+ 	""math/big""
++	""net""
++	""strconv""
+ 
+-	""github.com/golang/protobuf/jsonpb""
+ 	""github.com/golang/protobuf/proto""
+-	peerstore ""github.com/libp2p/go-libp2p-peerstore""
+ 	""github.com/pkg/errors""
+ 	""github.com/prometheus/client_golang/prometheus""
+ 	""go.uber.org/zap""
++	""google.golang.org/grpc""
++	""google.golang.org/grpc/reflection""
+ 
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/actpool""",File is not `goimports`-ed (from `goimports`),nit: remove empty line
+1175,"@@ -29,9 +29,9 @@ namespace Nethermind.Cli.Modules
+         public object[] Peers() => NodeManager.Post<object[]>(""admin_peers"").Result;
+         
+         [CliFunction(""admin"", ""addPeer"")]
+-        public string AddPeer(string enode) => NodeManager.Post<string>(""admin_addPeer"", enode).Result;
++        public string AddPeer(string enode, bool addToStaticNodes = false) => NodeManager.Post<string>(""admin_addPeer"", enode, addToStaticNodes).Result;
+         
+         [CliFunction(""admin"", ""removePeer"")]
+-        public string RemovePeer(string enode) => NodeManager.Post<string>(""admin_removePeer"", enode).Result;
++        public string RemovePeer(string enode, bool addToStaticNodes = false) => NodeManager.Post<string>(""admin_removePeer"", enode, addToStaticNodes).Result;
+     }
+ }",parameter should be called removeFromStaticNodes,`addToStaticNodes` -> `addToStaticNodes`
+1176,"@@ -221,7 +221,9 @@ class RequestContext:
+ ServiceRequestHandler = Callable[[RequestContext, ServiceRequest], Optional[ServiceResponse]]
+ 
+ 
+-def handler(operation: str = None, context: bool = True, expand: bool = True):
++def handler(
++    operation: str = None, context: bool = True, expand: bool = True, override: bool = False
++):
+     """"""
+     Decorator that indicates that the given function is a handler
+     """"""","The handler will have an extra property in the marker to signal the implementation is in the provider, for the cases we want to add functionality, for example, custom implementations not in moto.",I don't think we need the `override` argument here.
+1177,"@@ -14,6 +14,18 @@ class Subscription < ActiveRecord::Base
+     notifier.send_notifications
+   end
+ 
++  def active?
++    deactivated_on.nil?
++  end
++
++  def deactivate
++    update_column(:deactivated_on, Date.today)
++  end
++
++  def activate
++    update_column(:deactivated_on, nil)
++  end
++
+   private
+ 
+   def self.subscriber_emails","Is this method actually being used anywhere? If not, I think we should remove it.",Should this be `deactivated_at`?
+1178,"@@ -400,7 +400,7 @@ namespace AutoRest.Extensions
+                 {
+                     var bodyParameterType = bodyParameter.ModelType as CompositeType;
+                     if (bodyParameterType != null && 
+-                        (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant) <= Settings.Instance.PayloadFlatteningThreshold ||
++                        (bodyParameterType.ComposedProperties.Count(p => !p.IsConstant && !p.IsReadOnly) <= Settings.Instance.PayloadFlatteningThreshold ||
+                          bodyParameter.ShouldBeFlattened()))
+                     {
+                         var parameterTransformation = new ParameterTransformation",Thanks! I somehow lost this between my far too many branchs.,">!p.IsConstant && !p.IsReadOnly [](start = 16, leng"
+1179,"@@ -30,13 +30,14 @@ import socket
+ import sys
+ 
+ from .firefox_binary import FirefoxBinary
++from .options import Options
+ from .remote_connection import FirefoxRemoteConnection
+ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+ from selenium.webdriver.firefox.extension_connection import ExtensionConnection
+ from selenium.webdriver.firefox.firefox_profile import FirefoxProfile
+ from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
+ from .service import Service
+-from .options import Options
++from .webelement import FirefoxWebElement
+ 
+ 
+ class WebDriver(RemoteWebDriver):",i think this should get put into its own file. This could start to grow :),I think this should be `from .webelement import Fir
+1180,"@@ -39,6 +39,13 @@ const (
+ 	// variable containers' config, which will be used by the AWS SDK to fetch
+ 	// credentials.
+ 	awsSDKCredentialsRelativeURIPathEnvironmentVariableName = ""AWS_CONTAINER_CREDENTIALS_RELATIVE_URI""
++	// pauseContainerName is the internal name for the pause container
++	pauseContainerName = ""~internal~ecs~pause""
++	// pauseContainerImage is container image used to create the pause container
++	// TODO: Modify this to amazon/amazon-ecs-pause or something similar
++	pauseContainerImage = ""gcr.io/google_containers/pause:latest""
++	// networkModeNone specifies the string used to define the `none` docker networking mode
++	networkModeNone = ""none""
+ )
+ 
+ // TaskOverrides are the overrides applied to a task",Can you add a TODO for loading the tarball of the pause image into Docker?,I think this should be `~internal~ecs~pause`
+1181,"@@ -259,7 +259,6 @@ public class ProcessJob extends AbstractProcessJob {
+         }
+         throw new RuntimeException(e);
+       } finally {
+-        this.process = null;
+         info(""Process completed ""
+             + (success ? ""successfully"" : ""unsuccessfully"") + "" in ""
+             + ((System.currentTimeMillis() - startMs) / 1000) + "" seconds."");",Is there any value in setting the process to null like this?,Why was this removed?
+1182,"@@ -35,6 +35,14 @@ void SoftmaxWithLossLayer<Dtype>::Reshape(
+     const vector<Blob<Dtype>*>& bottom, const vector<Blob<Dtype>*>& top) {
+   LossLayer<Dtype>::Reshape(bottom, top);
+   softmax_layer_->Reshape(softmax_bottom_vec_, softmax_top_vec_);
++  softmax_axis_ = this->layer_param_.softmax_param().axis();
++  outer_num_ = bottom[0]->count(0, softmax_axis_);
++  inner_num_ = bottom[0]->count(softmax_axis_ + 1);
++  CHECK_EQ(outer_num_ * inner_num_, bottom[1]->count())
++      << ""Number of labels must match number of predictions; ""
++      << ""e.g., if softmax axis == 1 and prediction shape is (N, C, H, W), ""
++      << ""label count (number of labels) must be N*H*W, ""
++      << ""with integer values in {0, 1, ..., C-1}."";
+   if (top.size() >= 2) {
+     // softmax output
+     top[1]->ReshapeLike(*bottom[0]);",This could be a good time to add a check that the prediction and target dimensions (except channel) agree?,"`CHECK_EQ(outer_num_ * inner_num_, bottom[1]"
+1183,"@@ -3920,6 +3920,11 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb)
+             if (!bb_process_interrupt(dcontext, bb))
+                 break;
+         }
++#ifdef AARCH64
++        /* OP_isb, when mangled, has a potential side exit. */
++        else if (instr_get_opcode(bb->instr) == OP_isb)
++            break;
++#endif
+ #if 0/*i#1313, i#1314*/
+         else if (instr_get_opcode(bb->instr) == OP_getsec) {
+             /* XXX i#1313: if we support CPL0 in the future we'll need to","The requirement that OP_isb is bb-final needs to be a rule for clients, just like the rule that syscalls and interrupts must be bb-final: i.e., please add it to the dr_register_bb_event() docs.",Why is this needed?
+1184,"@@ -83,7 +83,7 @@ define([""userSettings""], function (userSettings) {
+ 
+             if (html += '<div class=""listPaging"">', showControls) {
+                 html += '<span style=""vertical-align:middle;"">';
+-                html += (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd + "" of "" + totalRecordCount;
++                html += Globalize.translate(""ListPaging"").replace(""{0}"", (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd).replace(""{1}"", totalRecordCount);
+                 html += ""</span>"";
+             }
+ ",The translate library has a method to replace the variables.,"Hi! I've found a possible matching string that has already been translated **18** times: `translate(""ListPaging"").replace(""{0}"", (totalRecordCount ? startIndex + 1 : 0) + ""-"" + recordsEnd).replace(""{1}"", totalRecordCount);` *ES Score: 7* Help me improve these suggestions: react with :thumbsdown: if the suggestion doesn't make any sense, or with :thumbsup: if it's a particularly good one (even if not implemented)."
+1185,"@@ -155,6 +155,18 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         with self.assertRaisesRegex(TypeError, msg):
+             ds.isin(1)
+ 
++    def test_fillna(self):
++        ps = pd.Series([np.nan, 2, 3, 4, np.nan, 6], name='x')
++        ks = koalas.from_pandas(ps)
++
++        self.assert_eq(ks.fillna(0), ps.fillna(0))
++        self.assert_eq(ks.fillna(0, inplace=True), ps.fillna(0, inplace=True))
++        self.assert_eq(ks.fillna({'x': 0}), ps.fillna({'x': 0}))
++
++        s_nan = pd.Series([0], index=['x'], dtype=int)
++        self.assert_eq(ks.fillna(s_nan),
++                       ps.fillna(s_nan))
++
+     def test_dropna(self):
+         ps = pd.Series([np.nan, 2, 3, 4, np.nan, 6], name='x')
+ ","i don't think this test case is correct. in both cases inpalce=True returns nothing. We need to compare the ks. Also we probably need to make a copy of it. Otherwise you pollute the following ""ks"" because ks has been changed.","can you add a case where `ps.fillna(0, inplace=True)` returns `pd.Series([0], index=['x'], dtype=int)`?"
+1186,"@@ -124,6 +124,7 @@ with outfile.open(""w"") as f, contextlib.redirect_stdout(f):
+             tls.TlsClienthelloHook,
+             tls.TlsStartClientHook,
+             tls.TlsStartServerHook,
++            tls.TlsHandshakeHook,
+         ]
+     )
+ ","Any proposals how to make the naming somehow include the ""completed"" idea of this hook? `TlsHandshakeCompletedHook` or similar? Or using the `...Start/End...` scheme?",Why is this needed?
+1187,"@@ -157,6 +157,7 @@ namespace Nethermind.Blockchain.Synchronization
+ 
+                 if (headersSynced > 0)
+                 {
++                    _blockTree.Flush();
+                     _syncReport.FullSyncBlocksDownloaded.Update(_blockTree.BestSuggestedHeader?.Number ?? 0);
+                     _syncReport.FullSyncBlocksKnown = bestPeer.HeadNumber;
+                 }","it introduces a lot of complexity to the state, can we flush straightaway or create a two level flush store where the questions are read form unflushed data?",Why is this needed?
+1188,"@@ -220,10 +220,10 @@ class JSTree extends AbstractBase
+             if ('collection' === $type && !$this->collectionsEnabled) {
+                 $type = 'record';
+             }
+-            $url = $this->getUrlFromRouteCache($type, $node->id);
++            $url = $this->getUrlFromRouteCache($type, urlencode($node->id));
+             return $type === 'collection'
+                 ? $url . '#tabnav'
+-                : $url . '#tree-' . preg_replace('/\W/', '-', $node->id);
++                : $url . '#tree-' . preg_replace('/\W/', '-', urlencode($node->id));
+         }
+     }
+ ","There are two calls to getUrlFromRouteCache, but you're only urlencoding one of them. Is that intentional? Would it make more sense to do the url-encoding inside the getUrlFromRouteCache function?",Why do we need to encode the id here?
+1189,"@@ -142,7 +142,11 @@ class EditorManager {
+ 
+     if (editorClass) {
+       this.activeEditor = getEditorInstance(editorClass, this.instance);
++      this.activeEditor.row = row; // pre-preparation needed by getEditedCell
++      this.activeEditor.col = col;
+       const td = this.activeEditor.getEditedCell();
++      this.activeEditor.row = null; // restore the un-initialized state
++      this.activeEditor.col = null;
+       this.activeEditor.prepare(row, col, prop, td, originalValue, cellProperties);
+ 
+     } else {",Maybe we can use `this.instance.getCell` with `topMost` flag to get `TD` element?,Why do we need these lines?
+1190,"@@ -280,7 +280,11 @@ func (cs *ChainService) HandleAction(_ context.Context, actPb *iotextypes.Action
+ 	if err := act.LoadProto(actPb); err != nil {
+ 		return err
+ 	}
+-	return cs.actpool.Add(act)
++	err := cs.actpool.Add(act)
++	if err != nil {
++		log.L().Info(err.Error())
++	}
++	return err
+ }
+ 
+ // HandleBlock handles incoming block request.",Change this to Debug Level,Why not return the error here?
+1191,"@@ -521,9 +521,9 @@ namespace NLog.Targets
+             {
+                 _allLayoutsAreThreadSafe = _allLayouts.All(layout => layout.ThreadSafe);
+             }
+-            StackTraceUsage = _allLayouts.DefaultIfEmpty().Max(layout => layout?.StackTraceUsage ?? StackTraceUsage.None);
+-            if (this is IUsesStackTrace usesStackTrace && usesStackTrace.StackTraceUsage > StackTraceUsage)
+-                StackTraceUsage = usesStackTrace.StackTraceUsage;
++            StackTraceUsage = _allLayouts.DefaultIfEmpty().Aggregate(StackTraceUsage.None, (seed,layout) => seed | (layout?.StackTraceUsage ?? StackTraceUsage.None));
++            if (this is IUsesStackTrace usesStackTrace)
++                StackTraceUsage |= usesStackTrace.StackTraceUsage;
+             _scannedForLayouts = true;
+         }
+ ","I refactored the Aggregate, those are hard to read",I'm not sure if this is the right way
+1192,"@@ -290,14 +290,6 @@ describe('region', function() {
+     assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+   });
+ 
+-  it('treats iframe elements as regions', function() {
+-    var checkArgs = checkSetup(
+-      '<iframe id=""target""></iframe><div role=""main"">Content</div>'
+-    );
+-
+-    assert.isTrue(checkEvaluate.apply(checkContext, checkArgs));
+-  });
+-
+   it('returns the outermost element as the error', function() {
+     var checkArgs = checkSetup(
+       '<div id=""target""><p>This is random content.</p></div><div role=""main""><h1 id=""mainheader"" tabindex=""0"">Introduction</h1></div>'","This is now done in the after method, so this test won't pass any more.",Why was this test removed?
+1193,"@@ -152,10 +152,14 @@ class ApplicationController < ActionController::Base
+     # have we identified the user?
+     if @user
+       # check if the user has been banned
+-      if @user.blocks.active.exists?
+-        # NOTE: need slightly more helpful message than this.
++      user_block =  @user.blocks.active.take
++      unless user_block.nil? 
+         set_locale
+-        report_error t(""application.setup_user_auth.blocked""), :forbidden
++        if  @user.blocks.active.take.zero_hour?
++          report_error  t(""application.setup_user_auth.blocked_zero_hour""), :forbidden
++        else
++          report_error t(""application.setup_user_auth.blocked""), :forbidden
++        end
+       end
+ 
+       # if the user hasn't seen the contributor terms then don't",What was the point of creating `user_block` if you're then not going to use it ;-),Unnecessary spacing detect
+1194,"@@ -22,9 +22,6 @@ from decorator import decorator
+ import types
+ import logging
+ 
+-from databricks.koalas.frame import PandasLikeDataFrame
+-from databricks.koalas.series import PandasLikeSeries
+-
+ logger = logging.getLogger('spark')
+ 
+ _TOUCHED_TEST = ""_pandas_updated""","@ueshin, I thought we can remove this entire file. Does that require some more works?",Why are these removed?
+1195,"@@ -39,7 +39,7 @@ def evaluateTokens(requestContext, tokens):
+       return float(tokens.number.scientific[0])
+ 
+   elif tokens.string:
+-    return str(tokens.string)[1:-1]
++    return unicode(tokens.string)[1:-1]
+ 
+   elif tokens.boolean:
+     return tokens.boolean[0] == 'true'",Just `return tokens.string[1:-1]` is enough,Why is this change necessa
+1196,"@@ -0,0 +1,3 @@
++resources :quizzes, only: [:show] do
++  resources :questions, only: [:show]
++end",1 trailing blank lines detected.,"resources :questions, only: [:show] do"
+1197,"@@ -29,7 +29,7 @@ public class LeftButton extends Button {
+         super(name);
+         this.name = name;
+         this.getStyleClass().add(""leftButton"");
+-        this.setPrefWidth(Double.MAX_VALUE);
++        this.setMaxWidth(Double.MAX_VALUE);
+         this.setAlignment(Pos.CENTER_LEFT);
+         this.setPadding(new Insets(2));
+     }",Isn't this the default max width? In any case I would prefer to see these definitions in the css files.,Shouldn't this be `setPrefWidth`?
+1198,"@@ -34,10 +34,11 @@ func redirParse(c *caddy.Controller) ([]Rule, error) {
+ 	cfg := httpserver.GetConfig(c)
+ 
+ 	initRule := func(rule *Rule, defaultCode string, args []string) error {
+-		if cfg.TLS.Enabled {
+-			rule.FromScheme = ""https""
+-		} else {
+-			rule.FromScheme = ""http""
++		rule.FromScheme = func() string {
++			if cfg.TLS.Enabled {
++				return ""https""
++			}
++			return ""http""
+ 		}
+ 
+ 		var (","Is this thread-safe? (If not, and if the solution is to introduce locking, let's reconsider how we do the scheme changing instead...)","Why not just `return ""https""`?"
+1199,"@@ -21,8 +21,8 @@
+ # IN THE SOFTWARE.
+ #-------------------------------------------------------------------------------
+ from datatable.lib._datatable import (
+-	Ftrl,
+ 	aggregate,
++	Ftrl,
+ 	kfold,
+ 	kfold_random,
+ )",Looks like this file has tabs instead of spaces.,Why this change?
+1200,"@@ -649,6 +649,19 @@ func (engine *DockerTaskEngine) deleteTask(task *apitask.Task) {
+ 		}
+ 	}
+ 
++	for _, container := range task.Containers {
++		for _, resource := range container.GetResources() {
++			err := resource.Cleanup()
++			if err != nil {
++				seelog.Warnf(""Task engine [%s]/[%s]: unable to cleanup resource %s: %v"",
++					task.Arn, container.Name, resource.GetName(), err)
++			} else {
++				seelog.Infof(""Task engine [%s]/[%s]: resource %s cleanup complete"",
++					task.Arn, container.Name, resource.GetName())
++			}
++		}
++	}
++
+ 	if execcmd.IsExecEnabledTask(task) {
+ 		// cleanup host exec agent log dirs
+ 		if tID, err := task.GetID(); err != nil {",Hmm should we clean up container resources before task resources here? or the order does not really matter here?,I think it would be good to log the error here.
+1201,"@@ -44,7 +44,6 @@ def temporary_download_dir(quteproc, tmpdir):
+     unwritable.ensure(dir=True)
+     unwritable.chmod(0)
+ 
+-
+ @bdd.given(""I clean old downloads"")
+ def clean_old_downloads(quteproc):
+     quteproc.send_cmd(':download-cancel --all')",Please undo this :wink:,Why was this removed?
+1202,"@@ -25,6 +25,12 @@ class ApiClient < ActiveRecord::Base
+   include DeviseInvitable::Inviter
+   include ValidationMessages
+ 
++  # ================
++  # = Associations =
++  # ================
++
++  has_many :plans
++
+   # If the Client_id or client_secret are nil generate them
+   before_validation :generate_credentials,
+                     if: Proc.new { |c| c.client_id.blank? || c.client_secret.blank? }",thanks for adding this missing association,Layout/TrailingBlankLines: Final newline missin
+1203,"@@ -11,6 +11,11 @@ namespace Microsoft.AspNet.Server.Kestrel.Https
+     public static class HttpsApplicationBuilderExtensions
+     {
+         public static IApplicationBuilder UseKestrelHttps(this IApplicationBuilder app, X509Certificate2 cert)
++        {
++            return app.UseKestrelHttps(new HttpsConnectionFilterOptions { ServerCertificate = cert});
++        }
++
++        public static IApplicationBuilder UseKestrelHttps(this IApplicationBuilder app, HttpsConnectionFilterOptions options)
+         {
+             var serverInfo = app.ServerFeatures.Get<IKestrelServerInformation>();
+ ",Should I remove this in favor of the HttpsConnectionFilterOptions overload?,Why do we need this overload?
+1204,"@@ -109,6 +109,15 @@ class DbalStatusQuery implements StatusQueryInterface
+         return array_values($result);
+     }
+ 
++    public function getMaxIndex(): ?int
++    {
++        return $this->connection->createQueryBuilder()
++            ->select('max(index)')
++            ->from(self::STATUS_TABLE)
++            ->execute()
++            ->fetchOne();
++    }
++
+     private function getQuery(Language $language): QueryBuilder
+     {
+         return $this->connection->createQueryBuilder()","This shode be nullable, there alway sholud be at least one status in system , if not exist that mean data problme",Why do we need this method?
+1205,"@@ -32,6 +32,10 @@ class Auth extends Controller
+     public function __construct()
+     {
+         parent::__construct();
++		
++		// Add JS File to unistall SW to avoid Cookie Cache Issues when Signin, see github issue: #3707
++		$this->addJs('../../../modules/backend/assets/js/auth/unistall-sw.js');
++		
+         $this->layout = 'auth';
+     }
+ ",Spaces not tabs,Why do we need this?
+1206,"@@ -160,6 +160,15 @@ class FsDriverNode extends FsDriverBase {
+ 		}
+ 	}
+ 
++	async readDir(path) {
++		try {
++			// return fs.readdirSync(path, {withFileTypes: true}).map(e => e.name); // From Node v10
++			return fs.readdirSync(path); // For Node v8
++		} catch (error) {
++			throw this.fsErrorToJsError_(error, path);
++		}
++	}
++
+ 	// Always overwrite destination
+ 	async copy(source, dest) {
+ 		try {","To get the files inside a directory, please use `readDirStats()`.",Can we remove this?
+1207,"@@ -34,8 +34,11 @@ const LocalConfigFileName string = "".plzconfig.local""
+ // for a particular machine (eg. build machine with different caching behaviour).
+ const MachineConfigFileName = ""/etc/plzconfig""
+ 
+-const TestContainerDocker = ""docker""
+-const TestContainerNone = ""none""
++const (
++	ContainerImplementationNone   = ""none""
++	ContainerImplementationDocker = ""docker""
++	ContainerImplementationPlz    = ""plz""
++)
+ 
+ func readConfigFile(config *Configuration, filename string) error {
+ 	log.Debug(""Reading config from %s..."", filename)","might be worth to call these `Isolation` instead of containers here and when presented to the user -- docker/rkt , in addition to cgroups and namespaces, also provide image discovery and filesystem preparation; there's also the security context and probably 1-2 other small things",I think this should be `Con
+1208,"@@ -0,0 +1,5 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package batchstore_test","File is empty, consider removing?",This file should be named `batchstore.go`
+1209,"@@ -237,6 +237,16 @@ def _refresh_credentials():
+     return result
+ 
+ 
++def logged_in():
++    """"""
++    Return registry URL if Quilt client is authenticated. Otherwise
++    return `None`.
++    """"""
++    url = get_registry_url()
++    if url in _load_auth():
++        return url
++
++
+ class QuiltProvider(CredentialProvider):
+     METHOD = 'quilt-registry'
+     CANONICAL_NAME = 'QuiltRegistry'","This seems to return the registry_url. The more meaningful URL is the catalog URL, which is the URL the user specifies in `quilt3.login`. The username might also be as useful here if not more useful.",I'm not sure if this is the best way to c
+1210,"@@ -23,8 +23,9 @@ type Config struct {
+ 	L1CrossDomainMessengerAddress common.Address
+ 	L1FeeWalletAddress            common.Address
+ 	AddressManagerOwnerAddress    common.Address
+-	L1ETHGatewayAddress           common.Address
+ 	GasPriceOracleOwnerAddress    common.Address
++	L1StandardBridgeAddress       common.Address
++	GasPriceOracleAddress         common.Address
+ 	// Turns on checking of state for L2 gas price
+ 	EnableL2GasPolling bool
+ 	// Deployment Height of the canonical transaction chain",Was the addition of `GasPriceOracleAddress` here erroneous?,Why is this removed?
+1211,"@@ -121,6 +121,11 @@ module Beaker
+           :project                => 'Beaker',
+           :department             => 'unknown',
+           :created_by             => ENV['USER'] || ENV['USERNAME'] || 'unknown',
++          :host_tags              => {
++                                      :project    => 'Beaker',
++                                      :department => 'unknown',
++                                      :created_by => ENV['USER'] || ENV['USERNAME'] || 'unknown'
++          },
+           :openstack_api_key      => ENV['OS_PASSWORD'],
+           :openstack_username     => ENV['OS_USERNAME'],
+           :openstack_auth_url     => ""#{ENV['OS_AUTH_URL']}/tokens"",","I believe that you are going to have to do some work here to get the env var support for these values to still work correctly, otherwise they will get stored as :department instead of host_tags[:department].",Use the new Ruby 1.9 hash syntax.
+1212,"@@ -149,8 +149,12 @@ public class SessionStore implements
+         if (BuildConfig.DEBUG) {
+             mStoreSubscription = ComponentsAdapter.get().getStore().observeManually(browserState -> {
+                 Log.d(LOGTAG, ""Session status BEGIN"");
+-                browserState.getTabs().forEach(tabSessionState -> Log.d(LOGTAG, ""BrowserStore Session: "" + tabSessionState.getId()));
+-                mSessions.forEach(session -> Log.d(LOGTAG, ""SessionStore Session: "" + session.getId()));
++                for (int i=0; i<browserState.getTabs().size(); i++) {
++                    Log.d(LOGTAG, ""BrowserStore Session: "" + browserState.getTabs().get(i).getId());
++                }
++                for (int i=0; i<mSessions.size(); i++) {
++                    Log.d(LOGTAG, ""SessionStore Session: "" + mSessions.get(i).getId());
++                }
+                 Log.d(LOGTAG, ""Session status END"");
+                 return null;
+             });",How was this causing the exception?,Why are you removing the `forEach` loop?
+1213,"@@ -57,6 +57,12 @@ define(['connectionManager', 'userSettings', 'events'], function (connectionMana
+             currentDateTimeCulture = currentCulture;
+         }
+         ensureTranslations(currentCulture);
++        // FIXME: See GH #1027 and #913. This should be configurable and not strictly based on locale.
++        if (currentCulture == 'zh-tw' || currentCulture == 'zh-hk') {
++            require([""css!jellyfin-noto/css/TC""]);
++        } else {
++            require([""css!jellyfin-noto/css/SC""]);
++        }
+     }
+ 
+     function ensureTranslations(culture) {","I still have issues with it loading Simplified Chinese by default over Japanese, since they also share characters and we're not sure if characters are different or not. As-is, this fixes Traditional Chinese and Simplified Chinese, but we're not sure if it'd still screw up Japanese text or not. I maintain that, in my opinion, Japanese should be the only script of this kind loaded by default (Because of Hiragana and Katakana, that aren't shared with any other script) and either variant of Chinese should be loaded only in their respective case.",Why is this needed?
+1214,"@@ -96,7 +96,7 @@ class MultiTermIntervalsSource extends IntervalsSource {
+ 
+   @Override
+   public void visit(String field, QueryVisitor visitor) {
+-
++    visitor.visitLeaf(new IntervalQuery(field, this));
+   }
+ 
+   @Override",Isn't it better to stub AtomatonQuery and yield it here. IIRC it resolves simplest MTQ highlighting cases as nobrainer.,Why is this needed?
+1215,"@@ -9,11 +9,11 @@ class CancellationAlternative
+   end
+ 
+   def discount_percentage_vs_current_plan_annualized
+-    ((1 - (@discounted_plan.price / (@current_plan.price * 12.0))) * 100).
++    ((1 - (@discounted_plan.price_in_dollars / (@current_plan.price_in_dollars * 12.0))) * 100).
+       round(0)
+   end
+ 
+   def discount_plan_price
+-    @discounted_plan.price
++    @discounted_plan.price_in_dollars
+   end
+ end",Line is too long. [96/80],Line is too long. [81/80]
+1216,"@@ -167,6 +167,9 @@ func (s *Solver) buildDefaultPod(ch *cmacme.Challenge) *corev1.Pod {
+ 			OwnerReferences: []metav1.OwnerReference{*metav1.NewControllerRef(ch, challengeGvk)},
+ 		},
+ 		Spec: corev1.PodSpec{
++			NodeSelector: map[string]string{
++				""kubernetes.io/os"": ""linux"",
++			},
+ 			RestartPolicy: corev1.RestartPolicyOnFailure,
+ 			Containers: []corev1.Container{
+ 				{","My only concern with changing the node selector here is that someone else _could_ have built their own images for other platforms and set them to be used using the flag override on the controller, which in turn this change would break. Perhaps not changing the selector for acmesolver pods makes most sense, and then working on actually having support for Windows? wdyt?",Why do we need this?
+1217,"@@ -24,7 +24,7 @@ import (
+ type Controller string
+ 
+ type Object struct {
+-	Object v1alpha1.InnerObject
++	Object v1alpha1.InnerObjectWithSelector
+ 	Name   string
+ }
+ ","Why do we need interface `InnerObjectWithSelector`, I searched the usage with this field, it seems nowhere use `GetSelectorSpecs()` methods provided by `InnerObjectWithSelector`",Why is this change n
+1218,"@@ -20,8 +20,12 @@ var (
+ 	once    sync.Once
+ )
+ 
+-// GetContext gets global context instance
+-func GetContext(contextType string) *Context {
++func init()  {
++	InitContext(MsgCtxTypeChannel)
++}
++
++// InitContext gets global context instance
++func InitContext(contextType string) {
+ 	once.Do(func() {
+ 		context = &Context{}
+ 		switch contextType {",Do we need this `init` here? We have already called the `InitContext` in `StartModule` directly.,Why do we need this 
+1219,"@@ -619,6 +619,14 @@ class WebDriver(object):
+         else:
+             return self.execute(Command.GET_WINDOW_HANDLES)['value']
+ 
++    def minimize_window(self):
++        """"""
++        Miniimizes the current window that webdriver is using
++        """"""
++        if self.w3c:
++            command = Command.W3C_MINIMIZE_WINDOW
++            self.execute(command, {""windowHandle"": ""current""})
++
+     def maximize_window(self):
+         """"""
+         Maximizes the current window that webdriver is using",This `if` is not necessary,This should be `self
+1220,"@@ -255,6 +255,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 		// (as above, don't diff props during hydration)
+ 		if (!isHydrating) {
+ 			if (('value' in newProps) && newProps.value!==undefined && newProps.value !== dom.value) dom.value = newProps.value==null ? '' : newProps.value;
++			// preact/#1899
++			// We need this value for input masking.
++			dom._lastValue = dom.value;
++
+ 			if (('checked' in newProps) && newProps.checked!==undefined && newProps.checked !== dom.checked) dom.checked = newProps.checked;
+ 		}
+ 	}","should we add a `mangle.json` mapping for this? We could reuse a property name that's only used on component or vnode objects right now, like `__s` (""next state"").",Why do we need this?
+1221,"@@ -717,6 +717,7 @@ module Beaker
+         args << ""--parseonly"" if opts[:parseonly]
+         args << ""--trace"" if opts[:trace]
+         args << ""--parser future"" if opts[:future_parser]
++        args << ""--modulepath #{opts[:modulepath]}"" if opts[:modulepath]
+ 
+         # From puppet help:
+         # ""... an exit code of '2' means there were changes, an exit code of",Please update the yard docs to indicate this new option.,Should this be `--mo
+1222,"@@ -52,6 +52,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Scheme sets the scheme of the load balancer (defaults to Internet-facing)
+ 	// +optional
+ 	Scheme *ClassicELBScheme `json:""scheme,omitempty""`
++
++	// Subnets specifies the subnets that should be used by the load balancer
++	// +optional
++	Subnets Subnets `json:""subnets,omitempty""`
+ }
+ 
+ // AWSClusterStatus defines the observed state of AWSCluster","Can you provide an example in the godoc section on how to use this? From the implementation it looks like the AvailabilityZone field is required for example, otherwise it can fail / error, is that correct?",This should be `Subn
+1223,"@@ -185,7 +185,10 @@ func initDB(db *gorm.DB, dbType string, log hclog.Logger) (err error) {
+ 		return sqlError.Wrap(err)
+ 	}
+ 
+-	if err := tx.Assign(Migration{Version: latestSchemaVersion}).FirstOrCreate(&Migration{}).Error; err != nil {
++	if err := tx.Assign(Migration{
++		Version:     latestSchemaVersion,
++		CodeVersion: codeVersion.String(),
++	}).FirstOrCreate(&Migration{}).Error; err != nil {
+ 		tx.Rollback()
+ 		return sqlError.Wrap(err)
+ 	}",It would be great if this could be captured by a test.,Why do we need this 
+1224,"@@ -441,10 +441,15 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int32, isAdvancedVis
+ 		ESIndexMaxResultWindow:            dc.GetIntProperty(dynamicconfig.FrontendESIndexMaxResultWindow, 10000),
+ 		IndexerConcurrency:                dc.GetIntProperty(dynamicconfig.WorkerIndexerConcurrency, 100),
+ 		ESProcessorNumOfWorkers:           dc.GetIntProperty(dynamicconfig.WorkerESProcessorNumOfWorkers, 1),
+-		ESProcessorBulkActions:            dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 1000),
+-		ESProcessorBulkSize:               dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 2<<24), // 16MB
+-		ESProcessorFlushInterval:          dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 1*time.Second),
+-		ESProcessorAckTimeout:             dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
++		// Should be not greater than NumberOfShards(512)/NumberOfHistoryNodes(4) * VisibilityTaskWorkerCount(10) divided by workflow distribution factor (2 at least).
++		// Otherwise, visibility queue processors won't be able to fill up bulk with documents and bulk will flush due to interval, not number of actions.
++		ESProcessorBulkActions: dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkActions, 100),
++		// 16MB - just a sanity check. With ES document size ~1Kb it should never be reached.
++		ESProcessorBulkSize: dc.GetIntProperty(dynamicconfig.WorkerESProcessorBulkSize, 16*1024*1024),
++		// Under high load bulk processor should flush due to number of BulkActions reached.
++		// Although, under small load it would never be the case and bulk processor will flush every this interval.
++		ESProcessorFlushInterval: dc.GetDurationProperty(dynamicconfig.WorkerESProcessorFlushInterval, 200*time.Millisecond),
++		ESProcessorAckTimeout:    dc.GetDurationProperty(dynamicconfig.WorkerESProcessorAckTimeout, 1*time.Minute),
+ 
+ 		EnableCrossNamespaceCommands: dc.GetBoolProperty(dynamicconfig.EnableCrossNamespaceCommands, true),
+ 	}","1000 -> 100 maybe too much, 200 ish to 500ish maybe a good option",Why do we need to change this?
+1225,"@@ -60,5 +60,5 @@ func (a *ChecksumAddress) UnmarshalText(text []byte) error {
+ // MarshalText implements the encoding.TextMarshaler interface
+ func (a ChecksumAddress) MarshalText() (text []byte, err error) {
+ 	addr := basics.Address(a)
+-	return []byte(addr.GetChecksumAddress().String()), nil
++	return []byte(addr.String()), nil
+ }",Any reason we need to keep this package's `ChecksumAddress` type or can we get rid of it too?,Why is this change needed?
+1226,"@@ -248,7 +248,7 @@ events.on(serverNotifications, 'RestartRequired', function (e, apiClient) {
+         [
+             {
+                 action: 'restart',
+-                title: globalize.translate('ButtonRestart'),
++                title: globalize.translate('HeaderRestart'),
+                 icon: getIconUrl()
+             }
+         ];","Above the one that was picked was the Button* prefix, and here it's the Header* prefix. Maybe the Button prefix is more general.",":ok: This change is safe, we'l"
+1227,"@@ -1250,7 +1250,7 @@ namespace Nethermind.Blockchain
+ 
+         public Keccak HeadHash => Head?.Hash;
+         public Keccak GenesisHash => Genesis?.Hash;
+-        public Keccak PendingHash => BestSuggestedHeader?.Hash;
++        public Keccak PendingHash => Head?.Hash;
+ 
+         public Block FindBlock(Keccak blockHash, BlockTreeLookupOptions options)
+         {","I might prefer changing: public Block FindPendingBlock() => FindBlock(PendingHash, BlockTreeLookupOptions.None); public BlockHeader FindPendingHeader() => FindHeader(PendingHash, BlockTreeLookupOptions.None); in IBlockFinder, what do you think?",Shouldn't this be `BestSuggest
+1228,"@@ -206,6 +206,7 @@ type SyncStatus struct {
+ type SyncSetCommonSpec struct {
+ 	// Resources is the list of objects to sync from RawExtension definitions.
+ 	// +optional
++	// +kubebuilder:pruning:PreserveUnknownFields
+ 	Resources []runtime.RawExtension `json:""resources,omitempty""`
+ 
+ 	// ResourceApplyMode indicates if the Resource apply mode is ""Upsert"" (default) or ""Sync"".",This is necessary due to a bug in 4.7. Follow HIVE-1561 for getting rid of it.,Why do we need to preserve unknown fields?
+1229,"@@ -2,8 +2,10 @@ class Topic < ActiveRecord::Base
+   # Associations
+   has_many :classifications
+   with_options(through: :classifications, source: :classifiable) do |options|
++    options.has_many :exercises, source_type: 'Exercise'
+     options.has_many :products, source_type: 'Product'
+     options.has_many :topics, source_type: 'Topic'
++    options.has_many :videos, source_type: 'Video'
+     options.has_many :workshops, source_type: 'Workshop'
+   end
+   has_one :trail",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I don't think we need to add these to the 
+1230,"@@ -38,7 +38,7 @@
+ #include ""common/xutil.h""
+ #include ""xkb.h""
+ 
+-/* XStringToKeysym() and XKeysymToString */
++/* XStringToKeysym() */
+ #include <X11/Xlib.h>
+ #include <xkbcommon/xkbcommon.h>
+ #include <glib.h>",Some day (tm) I will also get rid of that one. But today is not that day...,Why was this changed?
+1231,"@@ -206,6 +206,17 @@ class CombineAssets
+         // Disable cache always
+         $this->storagePath = null;
+ 
++        // Prefix all assets
++        if($localPath) {
++            if (substr($localPath, -1) !== '/') {
++                $localPath = $localPath.'/';
++            }
++            $assets = array_map(function($asset) use ($localPath) {
++                if (substr($asset, 0, 1) === '@') return $asset;
++                return $localPath.$asset;
++            }, $assets);
++        }
++
+         list($assets, $extension) = $this->prepareAssets($assets);
+ 
+         $rewritePath = File::localToPublic(dirname($destination));",Add a space between if and opening parenthesis please (i.e. `if (`),Expected 1 space after IF keyword; 0 found
+1232,"@@ -827,8 +827,9 @@ class Series(_Frame, IndexOpsMixin, Generic[T]):
+         Name: my_name, dtype: int64
+         """"""
+         if index is None:
+-            return self
+-        scol = self._scol.alias(index)
++            scol = self._scol
++        else:
++            scol = self._scol.alias(index)
+         if kwargs.get('inplace', False):
+             self._internal = self._internal.copy(scol=scol)
+             return self",nit: `rename` instead of `alias`?,Why this change?
+1233,"@@ -113,11 +113,17 @@ func (d *Driver) freeDevices() (string, string, error) {
+ 		return """", """", err
+ 	}
+ 	devPrefix := ""/dev/sd""
++
+ 	for _, dev := range self.BlockDeviceMappings {
+ 		if dev.DeviceName == nil {
+ 			return """", """", fmt.Errorf(""Nil device name"")
+ 		}
+ 		devName := *dev.DeviceName
++
++		// sda1 is reserved for the root device, skip
++		if devName == ""/dev/sda1"" {
++			continue
++		}
+ 		if !strings.HasPrefix(devName, devPrefix) {
+ 			devPrefix = ""/dev/xvd""
+ 			if !strings.HasPrefix(devName, devPrefix) {",Per AWS docs EC instances have the root mounted at /dev/sda1. This label should be skipped.,Why do we need t
+1234,"@@ -92,7 +92,6 @@ func (q *ChannelEventQueue) dispatchMessage() {
+ 		event := model.MessageToEvent(&msg)
+ 		select {
+ 		case rChannel <- event:
+-		default:
+ 		}
+ 	}
+ }","I'm not sure it is a better way to address lose message, if wait here, edge controller cant process message, event from watching api-server will be lost yet, right?",Why was this rem
+1235,"@@ -539,11 +539,12 @@ class EAP_MD5(EAP):
+         ByteEnumField(""code"", 1, eap_codes),
+         ByteField(""id"", 0),
+         FieldLenField(""len"", None, fmt=""H"", length_of=""optional_name"",
+-                      adjust=lambda p, x: x + p.value_size + 6),
++                adjust=lambda p, x: (x + p.value_size + 6) if p.value_size is not None else 6),
+         ByteEnumField(""type"", 4, eap_types),
+-        FieldLenField(""value_size"", 0, fmt=""B"", length_of=""value""),
++        FieldLenField(""value_size"", None, fmt=""B"", length_of=""value""),
+         XStrLenField(""value"", '', length_from=lambda p: p.value_size),
+-        XStrLenField(""optional_name"", '', length_from=lambda p: p.len - p.value_size - 6)
++        XStrLenField(""optional_name"", '',
++                length_from=lambda p: (p.len - p.value_size - 6) if p.len is not None and p.value_size is not None else 0)
+     ]
+ 
+ ","Please keep the correct alignment, it seems broken now (at least in Github). Can you reverse the test (`if p.value_size is None`)? Also, do you want `6` when `p.value_size is None` or `x + 6`? Maybe, in that case, something like `lambda p, x: x + 6 + (0 if p.value_size is None else p.value_size)` would be easier to read. Or even easier: `lambda p, x: x + 6 + (p.value_size or 0)`.",I don't think we
+1236,"@@ -238,6 +238,10 @@ type Container struct {
+ 
+ 	Secrets []*Secret `locationName:""secrets"" type:""list""`
+ 
++	StartTimeout *int64 `locationName:""startTimeout"" type:""integer""`
++
++	StopTimeout *int64 `locationName:""stopTimeout"" type:""integer""`
++
+ 	VolumesFrom []*VolumeFrom `locationName:""volumesFrom"" type:""list""`
+ }
+ ",Can we make sure ECS service treats it as int64 as well?,Why is this a pointer?
+1237,"@@ -178,6 +178,15 @@ class UIProperty(UIA):
+ 			return value
+ 		return value.replace(CHAR_LTR_MARK,'').replace(CHAR_RTL_MARK,'')
+ 
++class ReadOnlyEditBox(IAccessible):
++#Used for read-only edit boxes in a properties window.
++#These can contain dates that include unwanted left-to-right and right-to-left indicator characters.
++
++	def _get_windowText(self):
++		WindowText = super(ReadOnlyEditBox, self).windowText
++		if  WindowText  is not None and controlTypes.STATE_READONLY in self.states:
++			return WindowText.replace(CHAR_LTR_MARK,'').replace(CHAR_RTL_MARK,'')
++		return WindowText
+ 
+ class AppModule(appModuleHandler.AppModule):
+ ","Please follow the naming convention for variables, i.e. `windowText`.",missing whitespace aft
+1238,"@@ -21,8 +21,8 @@ import (
+ 
+ 	yaml ""github.com/ghodss/yaml""
+ 	""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
++	castv1alpha1 ""github.com/openebs/maya/pkg/castemplate/v1alpha1""
+ 	m_k8s_client ""github.com/openebs/maya/pkg/client/k8s""
+-	""github.com/openebs/maya/pkg/engine""
+ 	menv ""github.com/openebs/maya/pkg/env/v1alpha1""
+ 	""github.com/pkg/errors""
+ 	v1_storage ""k8s.io/api/storage/v1""",alias can be `cast`,nit: remove empty line
+1239,"@@ -97,13 +97,14 @@ static h2o_iovec_t events_status_final(void *priv, h2o_globalconf_t *gconf, h2o_
+                        "" \""http2-errors.inadequate-security\"": %"" PRIu64 "", \n""
+                        "" \""http2.read-closed\"": %"" PRIu64 "", \n""
+                        "" \""http2.write-closed\"": %"" PRIu64 "", \n""
+-                       "" \""ssl.errors\"": %"" PRIu64 ""\n"",
++                       "" \""ssl.errors\"": %"" PRIu64 "", \n""
++                       "" \""memory.mmap_errors\"": %"" PRIu64 ""\n"",
+                        H1_AGG_ERR(400), H1_AGG_ERR(403), H1_AGG_ERR(404), H1_AGG_ERR(405), H1_AGG_ERR(416), H1_AGG_ERR(417),
+                        H1_AGG_ERR(500), H1_AGG_ERR(502), H1_AGG_ERR(503), H2_AGG_ERR(PROTOCOL), H2_AGG_ERR(INTERNAL),
+                        H2_AGG_ERR(FLOW_CONTROL), H2_AGG_ERR(SETTINGS_TIMEOUT), H2_AGG_ERR(STREAM_CLOSED), H2_AGG_ERR(FRAME_SIZE),
+                        H2_AGG_ERR(REFUSED_STREAM), H2_AGG_ERR(CANCEL), H2_AGG_ERR(COMPRESSION), H2_AGG_ERR(CONNECT),
+                        H2_AGG_ERR(ENHANCE_YOUR_CALM), H2_AGG_ERR(INADEQUATE_SECURITY), esc->h2_read_closed, esc->h2_write_closed,
+-                       esc->ssl_errors);
++                       esc->ssl_errors, (uint64_t)mmap_errors);
+     pthread_mutex_destroy(&esc->mutex);
+     free(esc);
+     return ret;","Let's use `%zu` instead of casting to `uint64_t` and using `PRIu64`. The alternative is to change the type of `mmap_errors` to `uint64_t`, though I'd prefer not doing that because some 32-bit platforms might not provide atomic operation support for `uint64_t`.",Shouldn't this be `siz
+1240,"@@ -57,7 +57,7 @@ import javax.lang.model.element.Name;
+         name = ""CatchSpecificity"",
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+-        severity = BugPattern.SeverityLevel.SUGGESTION,
++        severity = BugPattern.SeverityLevel.WARNING,
+         summary = ""Prefer more specific error types than Exception and Throwable. When methods are updated to throw new""
+                 + "" checked exceptions they expect callers to handle failure types explicitly. Catching broad""
+                 + "" types defeats the type system. By catching the most specific types possible we leverage""",I recall there being a reason we had this one set only to suggeation. @carterkozak do you remember why? or is my memory getting corrupted?,I think this should be `SUGGESTION`
+1241,"@@ -72,7 +72,7 @@ class CppGenerator : public BaseGenerator {
+     }
+     for (auto it = parser_.included_files_.begin();
+          it != parser_.included_files_.end(); ++it) {
+-      auto noext = flatbuffers::StripExtension(it->first);
++      auto noext = flatbuffers::StripExtension(it->second);
+       auto basename = flatbuffers::StripPath(noext);
+       if (basename != file_name_) {
+         code_ += ""#include \"""" + parser_.opts.include_prefix +",This should now be made into `if (it->second.empty())` ?,Nit: `it->second` can be `const`.
+1242,"@@ -126,13 +126,19 @@ class WebEngineSearch(browsertab.AbstractSearch):
+     def __init__(self, parent=None):
+         super().__init__(parent)
+         self._flags = QWebEnginePage.FindFlags(0)
++        self.num_of_searches = 0
+ 
+     def _find(self, text, flags, callback, caller):
+         """"""Call findText on the widget.""""""
+         self.search_displayed = True
++        self.num_of_searches += 1
+ 
+         def wrapped_callback(found):
+             """"""Wrap the callback to do debug logging.""""""
++            self.num_of_searches -= 1
++            if self.num_of_searches > 0:
++                return
++
+             found_text = 'found' if found else ""didn't find""
+             if flags:
+                 flag_text = 'with flags {}'.format(debug.qflags_key(","Do we need to worry about a race condition on this decrement (@The-Compiler)? I'm not sure how the python callbacks work, so this might not need to be something to worry about.",Please remove this blank line.
+1243,"@@ -100,7 +100,7 @@ func TestMultiplePropagators(t *testing.T) {
+ 	// generates the valid span context out of thin air
+ 	{
+ 		ctx := ootaProp.Extract(bg, ns)
+-		sc := trace.RemoteSpanContextFromContext(ctx)
++		sc := trace.SpanContextFromContext(ctx)
+ 		require.True(t, sc.IsValid(), ""oota prop failed sanity check"")
+ 	}
+ 	// sanity check for real propagators, ensuring that they",Should these assert that the extracted `SpanContext` is remote?,Why is this change needed?
+1244,"@@ -27,6 +27,9 @@ class ApproxMaxIoUAssigner(MaxIoUAssigner):
+             ignoring any bboxes.
+         ignore_wrt_candidates (bool): Whether to compute the iof between
+             `bboxes` and `gt_bboxes_ignore`, or the contrary.
++        match_low_quality (bool): Whether to allow quality matches. This is
++            usually allowed for RPN and single stage detectors, but not allowed
++            in the second stage.
+         gpu_assign_thr (int): The upper bound of the number of GT for GPU
+             assign. When the number of gt is above this threshold, will assign
+             on CPU device. Negative values mean not assign on CPU.",typo: allow low quality matches.,"I don't think we need to mention RPN here, since it's only used for single stage detectors."
+1245,"@@ -49,7 +49,7 @@ func ResolveDataDir(dataDir string) (string, error) {
+ 	return filepath.Join(dataDir, ""server""), err
+ }
+ 
+-func StartServer(ctx context.Context, config *Config) error {
++func StartServer(ctx context.Context, config *Config, cfg *cmds.Server) error {
+ 	if err := setupDataDirAndChdir(&config.ControlConfig); err != nil {
+ 		return err
+ 	}","At some point we need to condense down and refactor our ""configs"" as we have too many in too many places and we're starting to get more illegible code. No change necessary but calling out for future reference.",`cfg` is unused (from `structcheck`)
+1246,"@@ -39,7 +39,8 @@ module Blacklight
+     def options
+       {
+         class: classes,
+-        ""aria-hidden"": (true if aria_hidden)
++        ""aria-hidden"": (true if aria_hidden),
++        ""aria-label"": icon_label
+       }
+     end
+ ",Can we add the `if label` conditional to this please?,Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
+1247,"@@ -40,6 +40,7 @@ setup(
+     packages=['databricks', 'databricks.koalas', 'databricks.koalas.missing'],
+     extras_require={
+         'spark': ['pyspark>=2.4.0'],
++        'mlflow': ['mlflow>=0.2.0'],
+     },
+     python_requires='>=3.5',
+     install_requires=[","@thunterdb, can we increase the minimal version to almost the latest ones? I was thinking people will mostly use the latest version of mlflow",I think this should be `mlflow>=0.3.0`
+1248,"@@ -669,6 +669,8 @@ const REGISTERED_HOOKS = [
+    * @param {CellRange} sourceRange The range values will be filled from.
+    * @param {CellRange} targetRange The range new values will be filled into.
+    * @param {string} direction Declares the direction of the autofill. Possible values: `up`, `down`, `left`, `right`.
++   * @param {boolean} hasFillDataChanged Indicates whether the original fillData has been changed in
++   *                                     the `beforeAutofill` hook.
+    */
+   'afterAutofill',
+ ","If the last argument is going to be removed, why would we add it to the API docs? Shouldn't it be private for internal use?",nit: `in the `beforeAutofill` hook.`
+1249,"@@ -37,13 +37,18 @@ from .execution_context import (
+     SystemPipelineExecutionContext,
+ )
+ 
+-
+ from .errors import DagsterInvariantViolationError
+ 
+ from .events import construct_event_logger
+ 
+ from .execution_plan.create import create_execution_plan_core
+ 
++from .execution_plan.intermediates_manager import (
++    FileSystemIntermediateManager,
++    InMemoryIntermediatesManager,
++    IntermediatesManager,
++)
++
+ from .execution_plan.objects import (
+     ExecutionPlan,
+     ExecutionStepEvent,",`Intermediates` or `Intermediate`,Why do we need this?
+1250,"@@ -95,6 +95,8 @@ class visibility_of(object):
+ 
+ 
+ def _element_if_visible(element, visibility=True):
++    if isinstance(element, str) or isinstance(element, dict):
++           raise StaleElementReferenceException(""Invalid locator"")
+     return element if element.is_displayed() == visibility else False
+ 
+ ",This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.,Why is this needed?
+1251,"@@ -52,8 +52,9 @@ func (c *Cluster) Bootstrap(ctx context.Context, snapshot bool) error {
+ 			// instance of etcd in the event that etcd certificates are unavailable,
+ 			// reading the data, and comparing that to the data on disk, all the while
+ 			// starting normal etcd.
+-			isHTTP := c.config.JoinURL != """" && c.config.Token != """"
+-			if isInitialized && !isHTTP {
++			// isHTTP := c.config.JoinURL != """" && c.config.Token != """"
++			if isInitialized {
++				logrus.Info(""Only reconciling with datastore"")
+ 				tmpDataDir := filepath.Join(c.config.DataDir, ""db"", ""tmp-etcd"")
+ 				os.RemoveAll(tmpDataDir)
+ 				if err := os.Mkdir(tmpDataDir, 0700); err != nil {","If this code isn't needed, it should be removed.",Can we remove this?
+1252,"@@ -145,10 +145,13 @@ func (md *metricsDriver) uploadMetrics(ctx context.Context, protoMetrics []*metr
+ 		if md.metricsClient == nil {
+ 			return errNoClient
+ 		}
+-		_, err := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{
+-			ResourceMetrics: protoMetrics,
+-		})
+-		return err
++		req := func(ctx context.Context) error {
++			_, err := md.metricsClient.Export(ctx, &colmetricpb.ExportMetricsServiceRequest{
++				ResourceMetrics: protoMetrics,
++			})
++			return err
++		}
++		return doRequest(ctx, req, md.connection.cfg.RetrySettings, md.connection.stopCh)
+ 	}()
+ 	if err != nil {
+ 		md.connection.setStateDisconnected(err)",Should the `doRequest` func be a method on the `connection` type instead of passing state from the type?,Why do we need to retry here?
+1253,"@@ -99,8 +99,8 @@ var _ = Describe(""init flow"", func() {
+ 			Expect(len(app.Variables)).To(Equal(5))
+ 			expectedVars := map[string]string{
+ 				""ECS_CLI_APP_NAME"":           appName,
+-				""ECS_CLI_ENVIRONMENT_NAME"":   ""test"",
+-				""ECS_CLI_LB_DNS"":             strings.TrimPrefix(app.Routes[0].URL, ""http://""),
++				""COPILOT_ENVIRONMENT_NAME"":   ""test"",
++				""COPILOT_LB_DNS"":             strings.TrimPrefix(app.Routes[0].URL, ""http://""),
+ 				""ECS_CLI_PROJECT_NAME"":       projectName,
+ 				""ECS_APP_DISCOVERY_ENDPOINT"": fmt.Sprintf(""%s.local"", projectName),
+ 			}",we'll probably tackle these e2e tests at the end,I think this should be `COPIL
+1254,"@@ -0,0 +1,19 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++using BenchmarkDotNet.Attributes;
++using MicroBenchmarks;
++
++namespace System.Net.Tests
++{
++    [BenchmarkCategory(Categories.CoreFX)]
++    public class DnsTests
++    {
++        [Benchmark]
++        public IPHostEntry GetHostEntry() => Dns.GetHostEntry(""34.206.253.53"");
++
++        [Benchmark]
++        public string GetHostName() => Dns.GetHostName();
++    }
++}",what is this address pointing to? what are we measuring here? I want to have a better understanding.,Is there a reason why this is
+1255,"@@ -101,7 +101,8 @@ public class JdbcFlowTriggerInstanceLoaderImpl implements FlowTriggerInstanceLoa
+           + ""project_json, flow_exec_id \n""
+           + ""FROM execution_dependencies JOIN (\n""
+           + ""SELECT trigger_instance_id FROM execution_dependencies WHERE trigger_instance_id not in (\n""
+-          + ""SELECT distinct(trigger_instance_id)  FROM execution_dependencies WHERE dep_status =  0 or dep_status = 4)\n""
++          + ""SELECT distinct(trigger_instance_id)  FROM execution_dependencies WHERE dep_status =""
++          + ""  0 or dep_status = 3)\n""
+           + ""GROUP BY trigger_instance_id\n""
+           + ""ORDER BY  min(starttime) desc limit %s) temp on execution_dependencies""
+           + "".trigger_instance_id in (temp.trigger_instance_id);"";","Would it be better to pass the dependency status as the parameter into the SQL string? In case the enum value is changed in the future, we don't need to change the code here.",Why are we changing this?
+1256,"@@ -1,3 +1,9 @@
++// Copyright 2017 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++// +build windows
++
+ package libdokan
+ 
+ import (",Hah I had `gorename` failing without this too.,Why do we need this file?
+1257,"@@ -597,6 +597,12 @@ namespace Datadog.Trace
+                     writer.WritePropertyName(""appsec_blocking_enabled"");
+                     writer.WriteValue(Security.Instance.Settings.BlockingEnabled);
+ 
++                    writer.WritePropertyName(""rules_file_path"");
++                    writer.WriteValue(Security.Instance.Settings.Rules ?? ""(none)"");
++
++                    writer.WritePropertyName(""libddwaf_version"");
++                    writer.WriteValue(Security.Instance.DdlibWafVersion?.ToString() ?? ""(none)"");
++
+                     writer.WriteEndObject();
+                 }
+ ",maybe prefix these with `appsec_` for consistency?,Why do we need these two 
+1258,"@@ -7,11 +7,19 @@ import (
+ 	""crypto/x509""
+ 	""errors""
+ 	""fmt""
++	""github.com/spiffe/spire/pkg/common/profiling""
++	""net/http""
++	_ ""net/http/pprof""
+ 	""net/url""
+ 	""path""
++	""runtime""
++
++	""strconv""
+ 	""sync""
+ 	""syscall""
+ 
++	_ ""golang.org/x/net/trace""
++
+ 	""github.com/spiffe/spire/pkg/agent/catalog""
+ 	""github.com/spiffe/spire/pkg/agent/endpoints""
+ 	""github.com/spiffe/spire/pkg/agent/manager""",nit: this should be down further with the other github imports,Why is this needed?
+1259,"@@ -560,6 +560,11 @@ def main():
+ 	else:
+ 		log.debug(""initializing updateCheck"")
+ 		updateCheck.initialize()
++	# If running from source, try to disconnect from the console we may have been executed in.
++	# NVDA may reconnect to read it later,
++	# but it is better to assume we are not connected to anything at the start.
++	if ctypes.windll.kernel32.FreeConsole() != 0:
++		log.debug(""Freed from parent console process."")
+ 	log.info(""NVDA initialized"")
+ 	postNvdaStartup.notify()
+ ",Why is this change necessary or related to the rest of the PR?,I don't think this is the
+1260,"@@ -31,7 +31,7 @@ class ConsoleReport extends Report
+             $issue_string .= 'INFO';
+         }
+ 
+-        $issue_reference = $issue_data->link ? ' (see ' . $issue_data->link . ')' : '';
++        $issue_reference = $issue_data->link ? ' - see: ' . $issue_data->link : '';
+ 
+         $issue_string .= ': ' . $issue_data->type
+             . ' - ' . $issue_data->file_name . ':' . $issue_data->line_from . ':' . $issue_data->column_from","Hm, I wonder if the `see:` prefix is even necessary?",Why did you change this?
+1261,"@@ -261,7 +261,13 @@ import 'emby-button';
+ 
+                 minutes = minutes || 1;
+ 
+-                miscInfo.push(`${Math.round(minutes)} mins`);
++                if (item.UserData?.PlaybackPositionTicks) {
++                    let remainingMinutes = (item.RunTimeTicks - item.UserData.PlaybackPositionTicks) / 600000000;
++                    remainingMinutes = remainingMinutes || 1;
++                    miscInfo.push(`${Math.round(minutes)} mins (${Math.round(remainingMinutes)} remaining)`);
++                } else {
++                    miscInfo.push(`${Math.round(minutes)} mins`);
++                }
+             }
+         }
+ ",This should be translated.,I don't think you need t
+1262,"@@ -294,13 +294,15 @@ class Booster {
+   void ResetConfig(const char* parameters) {
+     UNIQUE_LOCK(mutex_)
+     auto param = Config::Str2Map(parameters);
+-    if (param.count(""num_class"")) {
++    Config new_config;
++    new_config.Set(param);
++    if (param.count(""num_class"") && new_config.num_class != config_.num_class) {
+       Log::Fatal(""Cannot change num_class during training"");
+     }
+-    if (param.count(""boosting"")) {
++    if (param.count(""boosting"") && new_config.boosting != config_.boosting) {
+       Log::Fatal(""Cannot change boosting during training"");
+     }
+-    if (param.count(""metric"")) {
++    if (param.count(""metric"") && new_config.metric != config_.metric) {
+       Log::Fatal(""Cannot change metric during training"");
+     }
+     CheckDatasetResetConfig(config_, param);","I originally had this PR only changing the R package, but then ran into this error > Error: [LightGBM] [Fatal] Cannot change metric during training This is thrown even if you aren't actually CHANGING `metric`. I think the change here in `c_api` is closer to the desired behavior, only throwing an error if the parameter is being changed.",nit: `new_config.num_cla
+1263,"@@ -356,9 +356,9 @@ describe 'run_task' do
+ 
+       is_expected.to run.with_params(task_name, hostname, task_params).and_raise_error(
+         Puppet::ParseError,
+-        /Task\ test::params:\n
++        %r{Task\ test::params:\n
+          \s*has\ no\ parameter\ named\ 'foo'\n
+-         \s*has\ no\ parameter\ named\ 'bar'/x
++         \s*has\ no\ parameter\ named\ 'bar'}x
+       )
+     end
+ ","These changes are just to make cli_spec a little more readable for VS Code users, as there's a bug with the Ruby plugin's syntax highlighting when you use multi-line regex literals.",Why is this change neces
+1264,"@@ -1564,7 +1564,7 @@ func (r *ReconcileClusterDeployment) mergePullSecrets(cd *hivev1.ClusterDeployme
+ 	globalPullSecretName := os.Getenv(constants.GlobalPullSecret)
+ 	var globalPullSecret string
+ 	if len(globalPullSecretName) != 0 {
+-		globalPullSecret, err = controllerutils.LoadSecretData(r.Client, globalPullSecretName, constants.HiveNamespace, corev1.DockerConfigJsonKey)
++		globalPullSecret, err = controllerutils.LoadSecretData(r.Client, globalPullSecretName, controllerutils.GetHiveNamespace(), corev1.DockerConfigJsonKey)
+ 		if err != nil {
+ 			return """", errors.Wrap(err, ""global pull secret could not be retrieved"")
+ 		}",Shouldn't the global pull secret by in the namespace of the hive-operator? It is part of the operand.,Why do we need this change?
+1265,"@@ -23,11 +23,13 @@ class TestKinesis(unittest.TestCase):
+ 
+         # create stream and assert 0 consumers
+         client.create_stream(StreamName=stream_name, ShardCount=1)
++        sleep(1)
+         assert_consumers(0)
+ 
+         # create consumer and assert 1 consumer
+         consumer_name = 'cons1'
+         response = client.register_stream_consumer(StreamARN=stream_arn, ConsumerName=consumer_name)
++        sleep(1)
+         self.assertEqual(response['Consumer']['ConsumerName'], consumer_name)
+         # boto3 converts the timestamp to datetime
+         self.assertTrue(isinstance(response['Consumer']['ConsumerCreationTimestamp'], datetime))",kinesis-mock applies KINESIS_LATENCY to RegisterStreamConsumer actions so I added a sleep here.,Why is this needed?
+1266,"@@ -145,13 +145,8 @@ std::unique_ptr<nebula::kvstore::KVStore> initKV(std::vector<nebula::HostAddr> p
+     LOG(ERROR) << ""Meta version is invalid"";
+     return nullptr;
+   } else if (version == nebula::meta::MetaVersion::V1) {
+-    auto ret = nebula::meta::MetaVersionMan::updateMetaV1ToV2(engine);
+-    if (!ret.ok()) {
+-      LOG(ERROR) << ""Update meta from V1 to V2 failed "" << ret;
+-      return nullptr;
+-    }
+-
+-    nebula::meta::MetaVersionMan::setMetaVersionToKV(engine, nebula::meta::MetaVersion::V2);
++    LOG(ERROR) << ""Can't upgrade meta from V1 to V3"";
++    return nullptr;
+   } else if (version == nebula::meta::MetaVersion::V2) {
+     auto ret = nebula::meta::MetaVersionMan::updateMetaV2ToV3(engine);
+     if (!ret.ok()) {",Only V1 or V3 is return from `getMetaVersionFromKV`. So where do we call `updateMetaV2ToV3`?,Why do we need to remove th
+1267,"@@ -26,7 +26,7 @@ func (repo *nodeAttestorRepository) Constraints() catalog.Constraints {
+ }
+ 
+ func (repo *nodeAttestorRepository) Versions() []catalog.Version {
+-	return []catalog.Version{nodeAttestorV0{}}
++	return []catalog.Version{nodeAttestorV1{}}
+ }
+ 
+ func (repo *nodeAttestorRepository) LegacyVersion() (catalog.Version, bool) {","I think that V0 is missing here, which will prevent plugins that haven't been converted to work.",Why do we need to change th
+1268,"@@ -4,6 +4,7 @@ const withBundleAnalyzer = require(""@next/bundle-analyzer"")({
+ })
+ 
+ module.exports = withBundleAnalyzer({
++  // sitemap: () => [{uri: ""/wow"", type: ""pages"", verb: ""get""}],
+   middleware: [
+     sessionMiddleware({
+       unstable_isAuthorized: unstable_simpleRolesIsAuthorized,",Should we remove this?,Can we remove this?
+1269,"@@ -6,12 +6,14 @@ import (
+ 
+ 	""go.uber.org/zap""
+ 
++	""github.com/docker/distribution/reference""
+ 	""github.com/docker/docker/api/types""
+ 	""github.com/docker/docker/api/types/container""
+ 	""github.com/docker/docker/api/types/network""
+ 	""github.com/docker/docker/client""
+ 	""github.com/gliderlabs/ssh""
+ 	log ""github.com/noxiouz/zapctx/ctxlog""
++	""io""
+ )
+ 
+ type containerDescriptor struct {",Put on top of the import.,nit: remove empty l
+1270,"@@ -46,6 +46,7 @@ domReady( () => {
+ 	Modules.registerModule(
+ 		'analytics',
+ 		{
++			name: 'Analytics',
+ 			settingsEditComponent: SettingsEdit,
+ 			settingsViewComponent: SettingsView,
+ 			setupComponent: SetupMain,","See above, this shouldn't be added.",Why do we need this
+1271,"@@ -505,8 +505,8 @@ public enum ItemMapping
+ 	ITEM_ANGUISH_ORNAMENT_KIT(ANGUISH_ORNAMENT_KIT, NECKLACE_OF_ANGUISH_OR),
+ 	ITEM_OCCULT_NECKLACE(OCCULT_NECKLACE, OCCULT_NECKLACE_OR),
+ 	ITEM_OCCULT_ORNAMENT_KIT(OCCULT_ORNAMENT_KIT, OCCULT_NECKLACE_OR),
+-	ITE_AMULET_OF_FURY(AMULET_OF_FURY, AMULET_OF_FURY_OR),
+-	ITE_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR),
++	ITEM_AMULET_OF_FURY(AMULET_OF_FURY, AMULET_OF_FURY_OR),
++	ITEM_FURY_ORNAMENT_KIT(FURY_ORNAMENT_KIT, AMULET_OF_FURY_OR),
+ 
+ 	// Ensouled heads
+ 	ITEM_ENSOULED_GOBLIN_HEAD(ENSOULED_GOBLIN_HEAD_13448, ENSOULED_GOBLIN_HEAD),","This'll likely get fixed upstream, we should let them deal with it.",Why did you change 
+1272,"@@ -93,6 +93,7 @@ type Options struct {
+ 	LightNodeLimit int
+ 	WelcomeMessage string
+ 	Transaction    []byte
++	HostFactory    func(context.Context, ...libp2p.Option) (host.Host, error)
+ }
+ 
+ func New(ctx context.Context, signer beecrypto.Signer, networkID uint64, overlay swarm.Address, addr string, ab addressbook.Putter, storer storage.StateStorer, lightNodes *lightnode.Container, swapBackend handshake.SenderMatcher, logger logging.Logger, tracer *tracing.Tracer, o Options) (*Service, error) {","Somehow, this field does not seems useful for the exposed package api, only for the tests. Would you consider having an unexported field in `hostFactory func(context.Context, ...libp2p.Option) (host.Host, error)` instead to be set only by a new helper function defined in export_test.go. This is just a suggestion, not a hard requirement for the PR approval.",Why do we need this?
+1273,"@@ -111,6 +111,18 @@ class Time {
+ 	sleep(seconds) {
+ 		return this.msleep(seconds * 1000);
+ 	}
++
++
++	goBackInTime(n, timeDuration) {
++		// Note that we are starting from the first ms of the current timeDuration
++		// eg. If we go back by one day we are subtracting (24*60*60*1000) ms from the start ms of today
++		return moment().startOf(timeDuration).subtract(n, timeDuration).format('x');
++	}
++
++	goForwardInTime(n, timeDuration) {
++		return moment().startOf(timeDuration).add(n, timeDuration).format('x');
++	}
++
+ }
+ 
+ const time = new Time();","As a first argument to these function, please pass the date that should go forward/backward. Also please clarify what is ""n"" (possible values, unit) and what is timeDuration (possible values, unit, as from your code it seems to be ""day"", ""hours"", etc. but from your example it seems to be milliseconds).",I think this should 
+1274,"@@ -71,7 +71,11 @@ class AppModule(appModuleHandler.AppModule):
+ 			ui.message(_(""No track playing""))
+ 		return elapsedAndTotalTime
+ 
+-	def script_reportRemainingTime(self,gesture):
++	def script_reportRemainingTime(self, gesture):
++		import config
++		from languageHandler import setLanguage
++		lang = config.conf[""general""][""language""]
++		setLanguage(lang)
+ 		elapsedTime, totalTime = self.getElapsedAndTotalIfPlaying()
+ 		if elapsedTime is None or totalTime is None:
+ 			# Translators: Reported if the remaining time can not be calculated in Foobar2000","Are you sure you really need this code here? that script will be certainly run in NVDA's main thread, and core would have already called setLanguage.",Why do we need this?
+1275,"@@ -276,7 +276,7 @@ var _ = Describe(""Application deployment in edge_core Testing"", func() {
+ 		It(""TC_TEST_APP_DEPLOYMENT_16: Test application deployment with container network configuration as port mapping"", func() {
+ 			//Generate the random string and assign as a UID
+ 			UID = ""deployment-app-"" + edge.GetRandomString(10)
+-			port := []v1.ContainerPort{{HostPort: 10255, ContainerPort: 10255, Protocol: v1.ProtocolTCP, HostIP: ""127.0.0.1""}}
++			port := []v1.ContainerPort{{HostPort: 10256, ContainerPort: 10256, Protocol: v1.ProtocolTCP, HostIP: ""127.0.0.1""}}
+ 			IsAppDeployed := HandleAddAndDeletePods(http.MethodPut, ctx.Cfg.TestManager+AppHandler, UID, []v1.Container{{Name: UID, Image: ctx.Cfg.AppImageUrl[0], Ports: port, ImagePullPolicy: v1.PullIfNotPresent}}, v1.RestartPolicyOnFailure)
+ 			Expect(IsAppDeployed).Should(BeTrue())
+ 			CheckPodRunningState(ctx.Cfg.EdgedEndpoint+AppHandler, UID)",why is this changed ?,Why this change?
+1276,"@@ -182,8 +182,9 @@ func (l *ActionList) Get(doc Document, fps ...FieldPath) *ActionList {
+ // mod ""a.b"": 2, then either Update will fail, or it will succeed with the result
+ // {a: {b: 2}}.
+ //
+-// Update does not modify its doc argument. To obtain the new value of the document,
+-// call Get after calling Update.
++// Update does not modify its doc argument, except to set the new revision. To obtain
++// the new value of the document, call Get after calling Update.
++// TODO(jba): test that doc's revision field is updated.
+ func (l *ActionList) Update(doc Document, mods Mods) *ActionList {
+ 	return l.add(&Action{
+ 		kind: driver.Update,","Should this be ""the new revision value""?",I'm not sure if this is the right place to test this. I think it should be in the `Update` method.
+1277,"@@ -13,7 +13,7 @@
+ 
+ return [
+     'accepted'             => ':attribute må aksepteres.',
+-    'accepted_if'          => 'The :attribute must be accepted when :other is :value.',
++    'accepted_if'          => 'Dette feltet må aksepteres når :other er :value.',
+     'active_url'           => ':attribute er ikke en gyldig URL.',
+     'after'                => ':attribute må være en dato etter :date.',
+     'after_or_equal'       => ':attribute må være en dato etter eller lik :date.',",You have deleted :attribute,Line is too long. [83/80]
+1278,"@@ -1,12 +1,11 @@
+ /*
+- * Licensed to the Apache Software Foundation (ASF) under one or more
+- * contributor license agreements.  See the NOTICE file distributed with
+- * this work for additional information regarding copyright ownership.
+- * The ASF licenses this file to You under the Apache License, Version 2.0
+- * (the ""License""); you may not use this file except in compliance with
+- * the License.  You may obtain a copy of the License at
++ * Copyright 2017 Huawei Technologies Co., Ltd
+  *
+- *     http://www.apache.org/licenses/LICENSE-2.0
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *    http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an ""AS IS"" BASIS,",The license header should be updated to the Apache one.,Why did you remove the ASF copyright?
+1279,"@@ -22,6 +22,10 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+         [Trait(""RunOnWindows"", ""True"")]
+         public void HttpClient()
+         {
++            int expectedSpanCount = EnvironmentHelper.IsCoreClr() ? 2 : 1;
++            const string expectedOperationName = ""http.request"";
++            const string expectedServiceName = ""Samples.HttpMessageHandler-http-client"";
++
+             int agentPort = TcpPortProvider.GetOpenPort();
+             int httpPort = TcpPortProvider.GetOpenPort();
+ ",@zacharycmontoya Is there any way to distinguish a `SocketHttpHandler` from another `HttpMessageHandler` request?,Why do we need this?
+1280,"@@ -883,3 +883,17 @@ instr_is_exclusive_store(instr_t *instr)
+     return (opcode == OP_strex || opcode == OP_strexb || opcode == OP_strexd ||
+             opcode == OP_strexh);
+ }
++
++DR_API
++bool
++instr_is_scatter(instr_t *instr)
++{
++    return false;
++}
++
++DR_API
++bool
++instr_is_gather(instr_t *instr)
++{
++    return false;
++}",Not sure about this one -- did you check somehow?,I don't think this is needed.
+1281,"@@ -157,8 +157,15 @@ module Beaker
+         @options = @options.merge(env_vars)
+ 
+         if @options.is_pe?
+-          @options['pe_ver']           = Beaker::Options::PEVersionScraper.load_pe_version(@options[:pe_dir], @options[:pe_version_file])
+-          @options['pe_ver_win']       = Beaker::Options::PEVersionScraper.load_pe_version(@options[:pe_dir], @options[:pe_version_file_win])
++          @options['HOSTS'].each_key do |name, val| 
++            if @options['HOSTS'][name]['platform'] =~ /windows/ 
++              @options['HOSTS'][name]['pe_ver_win'] = @options['HOSTS'][name]['pe_ver_win'] || Beaker::Options::PEVersionScraper.load_pe_version(
++                                   @options['HOSTS'][name][:pe_dir] || @options[:pe_dir], @options[:pe_version_file_win])
++            else
++              @options['HOSTS'][name]['pe_ver'] = @options['HOSTS'][name]['pe_ver'] || Beaker::Options::PEVersionScraper.load_pe_version(
++                                   @options['HOSTS'][name][:pe_dir] || @options[:pe_dir], @options[:pe_version_file])
++            end
++          end
+         else
+           @options['puppet_ver']       = @options[:puppet]
+           @options['facter_ver']       = @options[:facter]",Is there a good reason to keep this at the `pe_ver_win` name now that it's per-host?,I don't think you need the `|
+1282,"@@ -97,7 +97,9 @@ public class ProductActivity extends BaseActivity {
+         String[] menuTitles = getResources().getStringArray(R.array.nav_drawer_items_product);
+ 
+         ProductFragmentPagerAdapter adapterResult = new ProductFragmentPagerAdapter(getSupportFragmentManager());
+-        adapterResult.addFragment(new SummaryProductFragment(), menuTitles[0]);
++        SummaryProductFragment summaryProductFragment = new SummaryProductFragment();
++
++        adapterResult.addFragment(summaryProductFragment, menuTitles[0]);
+         adapterResult.addFragment(new IngredientsProductFragment(), menuTitles[1]);
+         adapterResult.addFragment(new NutritionProductFragment(), menuTitles[2]);
+         adapterResult.addFragment(new NutritionInfoProductFragment(), menuTitles[3]);","Not in the order of display : Front, Ingredient, Nutrition here (which is the right thing), Actually displayed: Front, Nutrition, Ingredients",Why do we need a new fragment
+1283,"@@ -119,9 +119,6 @@ type StressInstance struct {
+ 	// UID is the instance identifier
+ 	// +optional
+ 	UID string `json:""uid""`
+-	// StartTime specifies when the instance starts
+-	// +optional
+-	StartTime *metav1.Time `json:""startTime""`
+ }
+ 
+ // GetDuration gets the duration of StressChaos",Why delete `StartTime`? This `StartTime` was used to avoid the PID was reused.,Why is this being removed?
+1284,"@@ -489,6 +489,10 @@ module Beaker
+             end
+ 
+           rescue Exception => teardown_exception
++            if !host.is_pe?
++              dump_puppet_log(host)
++            end
++
+             if original_exception
+               logger.error(""Raised during attempt to teardown with_puppet_running_on: #{teardown_exception}\n---\n"")
+               raise original_exception","My concern here, is that if the dump_puppet_log also throws then we will lose the data about the teardown_exception.",Should this be in a `ensure` block?
+1285,"@@ -53,10 +53,11 @@ static infer_result<task::classification> call_daal_kernel(
+ 
+     const std::int64_t dummy_seed = 777;
+     const auto data_use_in_model = daal_knn::doNotUse;
+-    daal_knn::Parameter daal_parameter(desc.get_class_count(),
+-                                       desc.get_neighbor_count(),
+-                                       dummy_seed,
+-                                       data_use_in_model);
++    daal_knn::Parameter daal_parameter(
++        dal::detail::integral_cast<size_t>(desc.get_class_count()),
++        dal::detail::integral_cast<size_t>(desc.get_neighbor_count()),
++        dal::detail::integral_cast<int>(dummy_seed),
++        data_use_in_model);
+ 
+     interop::status_to_exception(interop::call_daal_kernel<Float, daal_knn_kd_tree_kernel_t>(
+         ctx,",Should it be `int64_t`?,Why do we need this cast?
+1286,"@@ -26,10 +26,14 @@ import java.util.concurrent.TimeUnit;
+ 
+ import com.google.common.base.Stopwatch;
+ import org.apache.logging.log4j.Logger;
++import org.apache.tuweni.bytes.Bytes;
++import org.apache.tuweni.concurrent.ExpiringMap;
+ import org.apache.tuweni.units.bigints.UInt256;
+ 
+ public class PoWSolver {
+ 
++  private static final long POW_JOB_TTL = 1000 * 60 * 5; // 5 minutes
++  private static final int MAX_OMMER_DEPTH = 8;
+   private static final Logger LOG = getLogger();
+ 
+   public static class PoWSolverJob {",is this value related to something ?,Why do we need this?
+1287,"@@ -23,6 +23,6 @@ namespace Nethermind.TxPool
+ {
+     public interface ITxSender
+     {
+-        ValueTask<Keccak?> SendTransaction(Transaction tx, TxHandlingOptions txHandlingOptions);
++        ValueTask<(Keccak?, AddTxResult?)> SendTransaction(Transaction tx, TxHandlingOptions txHandlingOptions);
+     }
+ }","Add names to tuple elements ValueTask<(Keccak? Hash, AddTxResult? AddResult)>, should they both be nullable?",Why do we need this change?
+1288,"@@ -136,6 +136,7 @@ public class Name {
+   private String toUnderscore(CaseFormat caseFormat) {
+     List<String> newPieces = new ArrayList<>();
+     for (NamePiece namePiece : namePieces) {
++      namePiece = replaceAcronyms(namePiece);
+       newPieces.add(namePiece.caseFormat.to(caseFormat, namePiece.identifier));
+     }
+     return Joiner.on('_').join(newPieces);",I think it might make more sense to do this in Name.upperCamel; it is the entry point for upper camel strings.,Why is this needed?
+1289,"@@ -53,7 +53,7 @@ public class TypeTest {
+         assertTrue(type.isArrayType());
+         ArrayType arrayType = type.asArrayType();
+         final ArrayType[] s = new ArrayType[1];
+-        type.ifArrayType(t -> s[0] = t);
++        type.ifArrayType(t -> s[0] = (ArrayType)t);
+         assertNotNull(s[0]);
+     }
+ }",Huh? The point is that a cast isn't necessary,Why is this cast ne
+1290,"@@ -35,4 +35,12 @@ const (
+ 	//
+ 	// Default is ""true""
+ 	CreateDefaultStorageConfig menv.ENVKey = ""OPENEBS_IO_CREATE_DEFAULT_STORAGE_CONFIG""
++
++	// InstallCRD is the environment
++	// variable that flags if maya apiserver should install the CRDs
++	// As the installation moves towards helm 3, the responsibility of installing
++	// CRDs can be pushed to helm.
++	//
++	// Default is ""true""
++	InstallCRD menv.ENVKey = ""OPENEBS_IO_INSTALL_CRD""
+ )",can we name it like `InstallV1Alpha1CRDs` ?,I don't think we ne
+1291,"@@ -79,6 +79,7 @@ const (
+ 	deleteAfterAnnotation      = ""hive.openshift.io/delete-after""
+ 	tryInstallOnceAnnotation   = ""hive.openshift.io/try-install-once""
+ 	tryUninstallOnceAnnotation = ""hive.openshift.io/try-uninstall-once""
++	hiveutilCreatedLabel       = ""hive.openshift.io/hiveutil-created""
+ 	cloudAWS                   = ""aws""
+ 	cloudAzure                 = ""azure""
+ 	cloudGCP                   = ""gcp""",I need something to match when creating selectorsyncsets so added this label.,I don't think this 
+1292,"@@ -47,7 +47,9 @@ module RSpec
+         return nil if line == '-e:1'.freeze
+         line
+       rescue SecurityError
++        # :nocov:
+         nil
++        # :nocov:
+       end
+ 
+       # @private","Isn't `nil` the default return value from an empty `rescue` clause? If that's correct, then we could just remove the `nil` line entirely as it doesn't serve a purpose.",Why is this needed?
+1293,"@@ -1,11 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
++# This code example demonstrates how to add a cross-origin resource sharing (CORS)
++# configuration containing a single rule to an Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.s3_ruby_bucket_cors.rb]
++
+ require 'aws-sdk-s3'
+ 
+-# Adds a cross-origin resource sharing (CORS) configuration containing
+-#   a single rule to an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - An Amazon S3 bucket.",Simple Storage **Service**,I think this should
+1294,"@@ -471,6 +471,9 @@ func (r *Repository) LoadIndex(ctx context.Context) error {
+ 		return err
+ 	}
+ 
++	// remove obsolete indexes
++	validIndex.Sub(r.idx.Obsolete())
++
+ 	// remove index files from the cache which have been removed in the repo
+ 	return r.PrepareCache(validIndex)
+ }",Wouldn't that cause the obsolete indexes to be downloaded over and over again? After all these are still stored in the repository.,I'm not sure if thi
+1295,"@@ -0,0 +1,19 @@
++class FeedbackController < ApplicationController
++  # note that index is rendered implicitly as it's just a template
++
++  def create
++    message = []
++    [:bug, :context, :expected, :actually, :comments, :satisfaction, :referral].each do |key|
++      if !params[key].blank?
++        message << ""#{key}: #{params[key]}""
++      end
++    end
++    message = message.join(""\n"")
++    if !message.blank?
++      if current_user
++        message += ""\nuser: #{current_user.email_address}""
++      end
++      CommunicartMailer.feedback(message).deliver
++    end
++  end
++end",We might want to move this logic to a Plain Old Ruby Object down the road. Not a blocker.,I don't think you n
+1296,"@@ -1482,7 +1482,9 @@ Blockly.WorkspaceSvg.prototype.updateToolbox = function(tree) {
+     this.options.languageTree = tree;
+     this.flyout_.show(tree.childNodes);
+   }
+-  this.toolbox_.position();
++  if (this.toolbox_) {
++    this.toolbox_.position();
++  }
+ };
+ 
+ /**","move `this.toolbox_.position();` to just after line 1477. Context: the if statement on line 1472 checks whether this is a toolbox with categories, and if so it populates the toolbox. Positioning the toolbox is a reasonable followup to that, and means you don't need an extra if. You may also need to call `this.flyout_.position()` after line 1483, which is the equivalent for the non-category toolbox.",Why do we need this check?
+1297,"@@ -364,10 +364,10 @@ namespace pwiz.Skyline.EditUI
+                             var peptideDocNode = tuple.Item2;
+                             HashSet<Protein> proteins = new HashSet<Protein>();
+                             var peptideGroupDocNode = PeptideGroupDocNodes.First(g => ReferenceEquals(g.PeptideGroup, peptideGroup));
+-                            List<Protein> proteinsForSequence;
+-                            if (sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out proteinsForSequence))
++                            // ReSharper disable once ConditionIsAlwaysTrueOrFalse
++                            if (peptideGroupDocNode != null)
+                             {
+-                                if (peptideGroupDocNode != null)
++                                if (sequenceProteinsDict.TryGetValue(peptideDocNode.Peptide.Target.Sequence, out var proteinsForSequence))
+                                 {
+                                     foreach (var protein in proteinsForSequence)
+                                     {","Should the function above be .FirstOrDefault() instead? Otherwise, why check for null and tell ReSharper to ignore the fact that it can never be null?",I don't think this is need
+1298,"@@ -17,7 +17,9 @@ var fetch = {},
+     _ = require('underscore'),
+     crypto = require('crypto'),
+     usage = require('./usage.js'),
+-    plugins = require('../../../plugins/pluginManager.js');
++    STATUS_MAP = require('../jobs/job').STATUS_MAP,
++    plugins = require('../../../plugins/pluginManager.js'),
++    countlyDb = plugins.dbConnection();
+ 
+ /**
+ * Prefetch event data, either by provided key or first event in the list and output result to browser","Let's not create new connection, but rather user `common.db` one",Why do we need this?
+1299,"@@ -0,0 +1,11 @@
++module OpenGraphHelper
++  def open_graph_tags
++    tag('meta', property: 'og:image', content: image_url('learn/learn-ralph.png'))
++  end
++
++  private
++
++  def image_url(filename)
++    URI.join(root_url, image_path(filename))
++  end
++end",Can this use asset_path rather than defining an image_url helper?,why do we need this method
+1300,"@@ -0,0 +1,19 @@
++import { always } from 'ramda';
++
++/**
++ * A function that returns empty string.
++ *
++ * @func stubString
++ * @memberOf RA
++ * @since {@link https://char0n.github.io/ramda-adjunct/2.1.0|v2.1.0}
++ * @category Function
++ * @sig ... -> ''
++ * @return {''}
++ * @example
++ *
++ * RA.stubString(); //=> ''
++ * RA.stubString(1, 2, 3); //=> ''
++ */
++const stubString = always('');
++
++export default stubString;",Hindley-Milner signatures don't use literal types. They explusively use types. It's deal with that,This should be `always('')`
+1301,"@@ -61,3 +61,11 @@ type Priority struct {
+ 	PolicyPriority float64
+ 	RulePriority   int32
+ }
++
++// OFPolicyRule groups all configurations that the openflow module needs to install flow for PolicyRule.
++type OFPolicyRule struct {
++	OfID        uint32
++	OfRule      *PolicyRule
++	NpName      string
++	NpNamespace string
++}","Could we just extend PolicyRule with more fields? It was originally designed as the struct required by openflow client, nested structs seem not helping. And for the name of the fields, initialism should be uppercase, OFID and NPName doesn't look good, then maybe FlowID, PolicyName..",Why is this a pointer?
+1302,"@@ -485,9 +485,13 @@ class Functions
+ 
+             // bcmath
+             'bcscale',
+-            
++
+             // json
+             'json_last_error',
++
++            // opcache
++            'opcache_compile_file', 'opcache_get_configuration', 'opcache_get_status',
++            'opcache_invalidate', 'opcache_is_script_cached', 'opcache_reset',
+         ];
+ 
+         if (\in_array(strtolower($function_id), $impure_functions, true)) {","I really dislike this alignment approach, as it makes identifying individual functions quite hard, but I kept consistent with the previous style. Since no sorting was evident, I pushed it to the end of the block. Meanwhile, is this supposed to be tested or meaningfully testable somehow?",I'm not sure if this is the
+1303,"@@ -127,6 +127,10 @@ class StepDelegatingExecutor(Executor):
+                     running_steps[step.key] = step
+ 
+             last_check_step_health_time = pendulum.now(""UTC"")
++
++            # Order of events is important here. During an interation, we call handle_event, then get_steps_to_execute,
++            # then is_complete. get_steps_to_execute updates the state of ActiveExecution, and without it
++            # is_complete can return true when we're just between steps.
+             while not active_execution.is_complete:
+ 
+                 if active_execution.check_for_interrupts():",Could also consider modifying the ActiveExecution...,I don't think this is corre
+1304,"@@ -1522,3 +1522,19 @@ def get_iterating_dictionary_name(
+         return node.iter.as_string()
+ 
+     return None
++
++
++def get_subscript_const_value(node: astroid.Subscript) -> astroid.Const:
++    """"""
++    Returns the value (subscript.slice) of a Subscript node,
++    also supports python <3.9 windows where node.slice might be an Index
++    node
++    """"""
++    value = node.slice
++    if isinstance(value, astroid.Index):
++        value = value.value
++    inferred = safe_infer(value)
++    if not isinstance(inferred, astroid.Const):
++        raise ValueError(""Subscript.slice cannot be inferred as an astroid.Const"")
++
++    return inferred",Does it make sense to change that to a custom error instead of `ValueError`?,I don't think this is the right place for this function. It should be in `astroid.utils`.
+1305,"@@ -259,7 +259,7 @@ func (vm *VM) ApplyTipSetMessages(blocks []interpreter.BlockMessagesInfo, head b
+ 
+ 		// Pay block reward.
+ 		// Dragons: missing final protocol design on if/how to determine the nominal power
+-		rewardMessage := makeBlockRewardMessage(blk.Miner, minerPenaltyTotal, minerGasRewardTotal, blk.TicketCount)
++		rewardMessage := makeBlockRewardMessage(blk.Miner, minerPenaltyTotal, minerGasRewardTotal, 1)
+ 		if _, err := vm.applyImplicitMessage(rewardMessage, rnd); err != nil {
+ 			return nil, err
+ 		}",I guess this will need to change soon.,Why do we need this change?
+1306,"@@ -37,10 +37,9 @@ import (
+ // The header directive goes second so that headers
+ // can be manipulated before doing redirects.
+ var directiveOrder = []string{
++	""map"",
+ 	""root"",
+-
+ 	""header"",
+-
+ 	""redir"",
+ 	""rewrite"",
+ ",Restore this spacing - not sure why it has to be removed?,Why is this being removed?
+1307,"@@ -16,7 +16,10 @@
+ 
+ // clang-format off
+ // Dont't remove `format off`, it prevent reordering of win-includes.
+-#define _POSIX_C_SOURCE 200112L // For stat from stat/stat.h and fseeko() (POSIX extensions).
++
++#  define _XOPEN_SOURCE 700L
++#  define _POSIX_C_SOURCE 200809L
++
+ #ifdef _WIN32
+ #  ifndef WIN32_LEAN_AND_MEAN
+ #    define WIN32_LEAN_AND_MEAN","These defines cause issues in base.h leading to failing android builds. Locale independency is now set in multiple spots, in cmake and in base.h. The base.h uses feature test macros wrong. Feature test macros can be used to indicate that a feature should be made available. They do not guarantee that it is available. On the cmake side this is done by the check symbol macros (similar to what autoconf does). On the android side not. I would suggest removing this from base.h and define locale independent in gradle. It is available since android 21 I believe. Is there a way in gradle to set locale independent only if android api >= 21?",Why is this needed?
+1308,"@@ -504,7 +504,7 @@ SubPlan GoPlanner::mToNStepsPlan(SubPlan& startVidPlan) {
+   }
+ 
+   const auto& projectInput =
+-      (joinInput || joinDst) ? loopBody->outputVar() : sampleLimit->outputVar();
++      (loopBody != getDst) ? loopBody->outputVar() : sampleLimit->outputVar();
+   loopBody = Project::make(qctx, loopBody, goCtx_->yieldExpr);
+   loopBody->setInputVar(projectInput);
+   loopBody->setColNames(std::move(goCtx_->colNames));",Why not delete these codes?,Why is this change needed?
+1309,"@@ -112,7 +112,7 @@ bool StorageServer::start() {
+     metaClient_ = std::make_unique<meta::MetaClient>(ioThreadPool_,
+                                                      metaAddrs_,
+                                                      options);
+-    if (!metaClient_->waitForMetadReady()) {
++    if (!metaClient_->waitForMetadReady(FLAGS_meta_client_retry_times)) {
+         LOG(ERROR) << ""waitForMetadReady error!"";
+         return false;
+     }","If pull message failed after some reties, we should ensure the storaged exit, otherwise it has risk to loss data.",nit: `FLAGS_meta_client_re
+1310,"@@ -7,7 +7,7 @@
+ import pytest
+ import random
+ import datatable as dt
+-from datatable import f, stype, ltype
++from datatable import f, stype, ltype, first, count
+ from tests import list_equals
+ 
+ ",looks like you don't need to import first and count here anymore,`first` and `count` are un
+1311,"@@ -2511,6 +2511,18 @@ func (e *historyEngineImpl) NotifyNewTransferTasks(
+ 	}
+ }
+ 
++func (e *historyEngineImpl) NotifyNewVisibilityTasks(
++	tasks []persistence.Task,
++) {
++
++	if len(tasks) > 0 {
++		// TODO (alex): add visibility processor
++		// task := tasks[0]
++		// clusterName := e.clusterMetadata.ClusterNameForFailoverVersion(task.GetVersion())
++		// e.visibilityProcessor.NotifyNewTask(clusterName, tasks)
++	}
++}
++
+ func (e *historyEngineImpl) NotifyNewReplicationTasks(
+ 	tasks []persistence.Task,
+ ) {","FYI, visibility task processing is local only, meaning pushing something to local ES cluster / local archival endpoint",why do we need this?
+1312,"@@ -36,6 +36,8 @@ import org.springframework.http.HttpMethod;
+ import org.springframework.http.ResponseEntity;
+ import org.springframework.web.client.RestTemplate;
+ 
++import com.netflix.config.DynamicPropertyFactory;
++
+ public class SpringmvcClient {
+   private static RestTemplate templateUrlWithServiceName = new CseRestTemplate();
+ ",This import can be removed.,Why do we need this?
+1313,"@@ -48,6 +48,10 @@ func ParseResource(s string, resParser ResourceParser) (resARN Resource, err err
+ 		return nil, InvalidARNError{ARN: a, Reason: ""service is not supported""}
+ 	}
+ 
++	if strings.HasPrefix(a.Region, ""fips-"") || strings.HasSuffix(a.Region, ""-fips"") {
++		return nil, InvalidARNError{ARN: a, Reason: ""FIPS region not allowed in ARN""}
++	}
++
+ 	if len(a.Resource) == 0 {
+ 		return nil, InvalidARNError{ARN: a, Reason: ""resource not set""}
+ 	}","1. Nit: We can have a general helper to identify if a region is pseudo region. We might already have one somewhere. 2. Does any type of ARN support FIPS? If not, we may just move this check in arn package?",I think this should 
+1314,"@@ -8,10 +8,14 @@ name of the service that is used by Boto 3.
+ This factory is used by the make_stubber fixture found in the set of common fixtures.
+ """"""
+ 
+-from test_tools.s3_stubber import S3Stubber
+ from test_tools.dynamodb_stubber import DynamoStubber
++from test_tools.iam_stubber import IamStubber
++from test_tools.lambda_stubber import LambdaStubber
+ from test_tools.pinpoint_stubber import PinpointStubber
++from test_tools.s3_stubber import S3Stubber
++from test_tools.s3control_stubber import S3ControlStubber
+ from test_tools.sqs_stubber import SqsStubber
++from test_tools.sts_stubber import StsStubber
+ 
+ 
+ class StubberFactoryNotImplemented(Exception):",is this phrase completed in a next line? Or forgot to add... what?,I'm not sure if this
+1315,"@@ -0,0 +1,11 @@
++_base_ = [
++    '../_base_/models/mask_rcnn_r50_fpn.py',
++    '../_base_/datasets/deepfashion.py', '../_base_/schedules/schedule_1x.py',
++    '../_base_/default_runtime.py'
++]
++model = dict(
++    roi_head=dict(
++        bbox_head=dict(num_classes=15), mask_head=dict(num_classes=15)))
++# runtime settings
++total_epochs = 12
++workflow = [('train', 5)]","`('train', 5)` and `('train', 1)` are actually the same.",why do we need this?
+1316,"@@ -205,8 +205,8 @@ func (bt *backpressureTracker) beforeDiskBlockCachePut(blockResources int64) (
+ 	return availableResources
+ }
+ 
+-func (bt *backpressureTracker) getLimitInfo() (used int64, limit int64) {
+-	return bt.used, bt.limit
++func (bt *backpressureTracker) getLimitInfo() (used int64, limit float64) {
++	return bt.used, bt.currLimit()
+ }
+ 
+ type backpressureTrackerStatus struct {",Would it be too complicated to refactor `currLimit` to be an `int64`?,Why do we need this change?
+1317,"@@ -23,6 +23,13 @@ module RSpec
+       def assertions
+         @assertions ||= 0
+       end
++
++      RSPEC_SKIP_IMPLEMENTATION = ::RSpec::Core::Pending.instance_method(:skip)
++      # Minitest::Assertions has it's own `skip`, we need to make sure
++      # RSpec::Core::Pending#skip is used instead.
++      def skip(*args)
++        RSPEC_SKIP_IMPLEMENTATION.bind(self).call(*args)
++      end
+     end
+   end
+ end",Would it be more performant to just `include ::RSpec::Core::Pending` here? /cc @myronmarston,I'm not sure if this is the
+1318,"@@ -92,6 +92,10 @@ type IoChaosSpec struct {
+ // IoChaosStatus defines the observed state of IoChaos
+ type IoChaosStatus struct {
+ 	ChaosStatus `json:"",inline""`
++
++	// Instances always specifies podnetworkchaos generation or empty
++	// +optional
++	Instances map[string]int64 `json:""instances,omitempty""`
+ }
+ 
+ func (obj *IoChaos) GetSelectorSpecs() map[string]interface{} {",Should be podiochaos?,Why is this a pointer?
+1319,"@@ -35,6 +35,10 @@ import api
+ import guiHelper
+ import winVersion
+ 
++# Temporary: #8599: add cp65001 codec
++#            #7105: upgrading to python 3 should fix this issue. See https://bugs.python.org/issue13216
++codecs.register(lambda name: codecs.lookup('utf-8') if name == 'cp65001' else None)
++
+ try:
+ 	import updateCheck
+ except RuntimeError:","Is the `codecs.register(lambda name: None)` gracefully handled by codecs? The lambda is expected to return a tuple of functions (encoder, decoder, stream_reader, stream_writer) (or a CodecInfo object), according to the docs. I've only checked python's built-in help, though.",Why is this needed?
+1320,"@@ -154,6 +154,18 @@ namespace OpenTelemetry.Metrics
+                         {
+                             var metricStreamConfig = metricStreamConfigs[i];
+                             var metricStreamName = metricStreamConfig?.Name ?? instrument.Name;
++
++                            if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName))
++                            {
++                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(
++                                    metricStreamName,
++                                    instrument.Meter.Name,
++                                    ""Metric name is invalid."",
++                                    ""The name must comply with the OpenTelemetry specification."");
++
++                                continue;
++                            }
++
+                             if (this.metricStreamNames.ContainsKey(metricStreamName))
+                             {
+                                 // TODO: Log that instrument is ignored","in this case, it could be either instrument name or the view name, which could be invalid. might be better if we can offer very specific message. (not blocking this, we can add this as a follow up,if needed)",nit: `The name` -> `The name`
+1321,"@@ -1654,9 +1654,10 @@ class TargetLocator {
+    *     when the driver has changed focus to the specified window.
+    */
+   window(nameOrHandle) {
++    let paramName = this.driver_.getExecutor().w3c ? 'handle' : 'name';
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter(paramName, nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ",I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs,Nit: `nameOrHandle` -> `windo
+1322,"@@ -0,0 +1,5 @@
++_base_ = '../cascade_rcnn/cascade_mask_rcnn_r50_fpn_20e_coco.py'
++model = dict(
++    pretrained=  # NOQA
++    'https://shanghuagao.oss-cn-beijing.aliyuncs.com/res2net/res2net101_v1b_26w_4s_mmdetv2-f0a600f9.pth',  # NOQA
++    backbone=dict(type='Res2Net', depth=101, scale=4, base_width=26))",You may put 'open-mmlab://res2net101_v1d_26w_4s' here. MMCV will be updated later.,Why do we need this?
+1323,"@@ -17,3 +17,12 @@
+  */
+ 
+ export const STORE_NAME = 'modules/pagespeed-insights';
++
++// Form ID for PageSpeed widget.
++export const FORM_DASH_WIDGET = 'pagespeedWidget';
++// Report strategies.
++export const STRATEGY_MOBILE = 'mobile';
++export const STRATEGY_DESKTOP = 'desktop';
++// Report data sources.
++export const DATA_SRC_LAB = 'data_lab';
++export const DATA_SRC_FIELD = 'data_field';","May be worth making this more specific, to avoid potential conflicts, maybe `pagespeedDashboardWidget`? Or `webVitalsDashboardWidget`?",I don't think this is used an
+1324,"@@ -151,7 +151,7 @@ module.exports = class AwsS3Multipart extends Plugin {
+       const onError = (err) => {
+         this.uppy.log(err)
+         this.uppy.emit('upload-error', file, err)
+-        err.message = `Failed because: ${err.message}`
++        err.message = `${err.message}`
+ 
+         queuedRequest.done()
+         this.resetUploaderReferences(file.id)",I guess this assignment is now redundant?,`Failed because: ${err.message}` => `Failed because: ${err.message}`
+1325,"@@ -218,7 +218,9 @@ func (s *Server) handleSingleRPC(ctx context.Context, req *RPCReq) *RPCRes {
+ 		return backendRes
+ 	}
+ 
+-	backendRes, err = s.backendGroups[group].Forward(ctx, req)
++	// NOTE: We call into the specific backend here to ensure that the RPCRes is synchronized with the blockNum.
++	var blockNum uint64
++	backendRes, blockNum, err = s.backendGroups[group].Forward(ctx, req)
+ 	if err != nil {
+ 		log.Error(
+ 			""error forwarding RPC request"",",See above note re: blockNum synchronization.,Why do we need to call into the specific backend here?
+1326,"@@ -10,8 +10,10 @@ import (
+ 	""time""
+ 
+ 	""github.com/andres-erbsen/clock""
++	""github.com/cenkalti/backoff/v3""
+ 	observer ""github.com/imkira/go-observer""
+ 	""github.com/spiffe/spire/pkg/agent/client""
++	spire_backoff ""github.com/spiffe/spire/pkg/agent/common/backoff""
+ 	""github.com/spiffe/spire/pkg/agent/manager/cache""
+ 	""github.com/spiffe/spire/pkg/agent/svid""
+ 	""github.com/spiffe/spire/pkg/common/bundleutil""",wonder if we could avoid doing named imports if we type aliased `backoff.Backoff` in the `.../agent/common/backoff` package?,nit: this import should be grouped with the other spiffe imports
+1327,"@@ -44,7 +44,6 @@
+ #include ""disassemble.h""
+ #include ""instr.h""
+ #include ""instr_create.h""
+-
+ #include ""codec.h""
+ 
+ ",Or maybe put into alphabetical order with the other #includes.,Why is this removed?
+1328,"@@ -235,8 +235,11 @@ func watchConfigFile(filename, adapterName string) {
+ 		return false
+ 	}
+ 
++	ticker := time.NewTicker(1 * time.Second)
++	defer ticker.Stop()
++
+ 	// begin poller
+-	for range time.Tick(1 * time.Second) {
++	for range ticker.C {
+ 		// get the file info
+ 		info, err := os.Stat(filename)
+ 		if err != nil {",This runs the entire duration of the program; this change is not needed.,I think this should be `ticker.Stop()`
+1329,"@@ -20,6 +20,10 @@ export class TouchScroll extends BasePlugin {
+     return PLUGIN_PRIORITY;
+   }
+ 
++  static get ALWAYS_UPDATE() {
++    return true;
++  }
++
+   constructor(hotInstance) {
+     super(hotInstance);
+ ","I don't feel well about the `ALWAYS_UPDATE` option   &nbsp; sounds like a workaround. I can imagine that some of the plugins want to observe all options. Maybe, in that case, we can reuse the `CONFIG_KEYS` that would return an empty array for observing all settings and `false` for disabling observing at all? I just thinking aloud - Like `CONFIG_KEYS` sounds reasonable. We could support and maintain it in the future, even after implementing the ""observability"" to the MetaManager then `ALWAYS_UPDATE` ... I don't know :)",Why do we need this?
+1330,"@@ -34,6 +34,11 @@
+  * by asynch interrupt.
+  */
+ 
++/* clang-format off */
++/* XXX: clang-format incorrectly detected a tab difference at ""clang-format on""
++ * below. This is why ""clang-format off"" has been moved outside the ifdef until
++ * bug is fixed.
++ */
+ #ifndef ASM_CODE_ONLY /* C code */
+ #    include ""configure.h""
+ #    ifndef UNIX","A ""tab difference""? As in, there are tab characters somewhere? This disabling of clang-format for all the code here seems like overkill. Are you sure there's not some other solution? I don't really understand the problem though. Do you mean clang-format-diff?",Why is this needed?
+1331,"@@ -31,12 +31,7 @@ import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.grid.sessionmap.local.LocalSessionMap;
+ import org.openqa.selenium.netty.server.NettyServer;
+ import org.openqa.selenium.remote.SessionId;
+-import org.openqa.selenium.remote.http.HttpClient;
+-import org.openqa.selenium.remote.http.HttpHandler;
+-import org.openqa.selenium.remote.http.HttpRequest;
+-import org.openqa.selenium.remote.http.HttpResponse;
+-import org.openqa.selenium.remote.http.TextMessage;
+-import org.openqa.selenium.remote.http.WebSocket;
++import org.openqa.selenium.remote.http.*;
+ import org.openqa.selenium.remote.tracing.DefaultTestTracer;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ ",Could you please leave the explicit imports?,Don't use wildcard imports.
+1332,"@@ -265,6 +265,9 @@ public abstract class GapicInterfaceConfig implements InterfaceConfig {
+     }
+     List<T> methodConfigs = new ArrayList<>();
+     for (MethodConfigProto methodConfigProto : interfaceConfigProto.getMethodsList()) {
++      if (methodConfigMap.get(methodConfigProto.getName()) == null) {
++        continue;
++      }
+       methodConfigs.add(methodConfigMap.get(methodConfigProto.getName()));
+     }
+     return methodConfigs;",Can we check for containsKey here?,Why is this needed?
+1333,"@@ -35,9 +35,14 @@ import (
+ 	""golang.org/x/tools/go/types/typeutil""
+ )
+ 
++const usage = ""usage: wire [gen] [PKG] | wire show [...] | wire check [...]""
++
+ func main() {
+ 	var err error
+ 	switch {
++	case len(os.Args) == 2 && (os.Args[1] == ""help"" || os.Args[1] == ""-h"" || os.Args[1] == ""-help"" || os.Args[1] == ""--help""):
++		fmt.Fprintln(os.Stderr, usage)
++		os.Exit(2)
+ 	case len(os.Args) == 1 || len(os.Args) == 2 && os.Args[1] == ""gen"":
+ 		err = generate(""."")
+ 	case len(os.Args) == 2 && os.Args[1] == ""show"":",Exit successfully. We served the help the user wanted.,I think this should
+1334,"@@ -15,13 +15,13 @@ import (
+ // RepoRoot is the root of the Please repository
+ var RepoRoot string
+ 
+-// initialWorkingDir is the directory we began in. Early on we chdir() to the repo root but for
++// InitialWorkingDir is the directory we began in. Early on we chdir() to the repo root but for
+ // some things we need to remember this.
+-var initialWorkingDir string
++var InitialWorkingDir string
+ 
+-// initialPackage is the initial subdir of the working directory, ie. what package did we start in.
+-// This is similar but not identical to initialWorkingDir.
+-var initialPackage string
++// InitialPackagePath is the initial subdir of the working directory, ie. what package did we start in.
++// This is similar but not identical to InitialWorkingDir.
++var InitialPackagePath string
+ 
+ // usingBazelWorkspace is true if we detected a Bazel WORKSPACE file to find our repo root.
+ var usingBazelWorkspace bool",Had to rename this because `InitialPackage()` already existed.,I don't think we ne
+1335,"@@ -19,4 +19,15 @@ module IntegrationSpecHelper
+       }
+     )
+   end
++
++  def with_18f_procurement_env_variables(setup_vars=nil)
++    old_approver_email = ENV['GSA18F_APPROVER_EMAIL']
++    old_purchaser_email = ENV['GSA18F_PURCHASER_EMAIL']
++
++    ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'
++    ENV['GSA18F_PURCHASER_EMAIL'] = 'test_purchaser@some-dot-gov.gov'
++    yield
++    ENV['GSA18F_APPROVER_EMAIL'] = old_approver_email
++    ENV['GSA18F_PURCHASER_EMAIL'] = old_purchaser_email
++  end
+ end",Can we put this in a different helper?,Layout/EmptyLinesAr
+1336,"@@ -603,6 +603,9 @@ insert_push_all_registers(dcontext_t *dcontext, clean_call_info_t *cci,
+                                   DR_REG_LIST_LENGTH_ARM, DR_REG_LIST_ARM));
+     }
+     dstack_offs += 15 * XSP_SZ;
++
++    /* Make dstack_offs 8-byte algined, as we only accounted for 31 4-byte slots */
++    dstack_offs += XSP_SZ;
+     ASSERT(cci->skip_save_flags    ||
+            cci->num_simd_skip != 0 ||
+            cci->num_regs_skip != 0 ||","I'm not sure where your 31 comes from? I see 15 here and 2 above for pc and flags, for 17 total beyond the SIMD.",Why do we need to account for 31 4-byte slots?
+1337,"@@ -46,4 +46,10 @@ public class Info extends AbstractApiBean {
+     public Response getServer() {
+         return response( req -> ok(systemConfig.getDataverseServer()));
+     }
++    
++    @GET
++    @Path(""apiTermsOfUse"")
++    public Response getTermsOfUse() {
++        return response( req -> ok(systemConfig.getApiTermsOfUse()));
++    }
+ }","If you want, you could change this to `allowCors(response` (like in ""version"", above) to allow Cross-Origin Resource Sharing. I'm sort of wondering what's returned if no API terms of use are set.",Should this be `getTermsOfUse`?
+1338,"@@ -1616,4 +1616,9 @@ public class MessageList extends K9Activity implements MessageListFragmentListen
+             }
+         }
+     }
++
++    @Override
++    public void onConfigurationChanged(Configuration newConfig) {
++        super.onConfigurationChanged(newConfig);
++    }
+ }",Why do we need to override this if all we're doing is passing it up?,Why do we need this?
+1339,"@@ -356,6 +356,9 @@ void CmpSeabaseDDL::createSeabaseTableLike(
+         query += keyClause;
+       }
+ 
++  // send any user CQDs down 
++  Lng32 retCode = sendAllControls(FALSE, FALSE, TRUE);
++
+   ExeCliInterface cliInterface(STMTHEAP, NULL, NULL, 
+   CmpCommon::context()->sqlSession()->getParentQid());
+ ","Just wondering whether it's safe to send all CQDs to the child compiler. As this missing CQD is causing trouble, maybe some other user CQDs that now get sent could also cause the statement to fail? Also, if I have a table with a nullable unique column, should I have to set this CQD to create another table like it, or should the CREATE TABLE LIKE work without the CQD?",Why do we need this line?
+1340,"@@ -1,11 +1,16 @@
+ import os
+ 
++import packaging.version
++import requests
++
+ from ..defines import GCP_CREDS_LOCAL_FILE
+ from ..module_build_spec import ModuleBuildSpec
+ from ..utils import connect_sibling_docker_container, network_buildkite_container
+ from .test_images import publish_test_images, test_image_depends_fn
+ 
+ SCRIPT_PATH = os.path.dirname(os.path.abspath(__file__))
++DAGSTER_FROM_SOURCE = ""current_branch""
++DAGSTER_EARLIEST_RELEASE = ""0.12.4""
+ 
+ 
+ def integration_suite_extra_cmds_fn(version):",EARLIEST_TESTED_RELEASE might be slightly more clear,I think this should be `packaging.version.parse`
+1341,"@@ -81,7 +81,7 @@ MSG_STATE_CONFIDENCE = 2
+ # Allow stopping after the first semicolon/hash encountered,
+ # so that an option can be continued with the reasons
+ # why it is active or disabled.
+-OPTION_RGX = re.compile(r""\s*#.*\bpylint:\s*([^;#]+)[;#]{0,1}"")
++OPTION_RGX = re.compile(r'.*#\s*pylint:\s*([^;#]+)[;#]?.*')
+ 
+ # The line/node distinction does not apply to fatal errors and reports.
+ _SCOPE_EXEMPT = ""FR""","I think replacing `.*` with `\s*` from after the hash makes sense, but not the rest of the changes.",I'm not sure if this is the right way to do this
+1342,"@@ -220,6 +220,8 @@ type NetworkPolicyRule struct {
+ 	// action “nil” defaults to Allow action, which would be the case for rules created for
+ 	// K8s Network Policy.
+ 	Action *secv1alpha1.RuleAction `json:""action,omitempty"" protobuf:""bytes,6,opt,name=action,casttype=github.com/vmware-tanzu/antrea/pkg/apis/security/v1alpha1.RuleAction""`
++	// EnableLogging indicates whether or not to generate logs when rules are matched. Default to false.
++	EnableLogging bool `json:""enableLogging"" protobuf:""varint,7,opt,name=enableLogging""`
+ }
+ 
+ // Protocol defines network protocols supported for things like container ports.",interesting .. did not know varint tag covered bool as well,I don't think we need to add a new field here.
+1343,"@@ -35,6 +35,11 @@ struct st_duration_stats_t {
+     struct gkc_summary *process_time;
+     struct gkc_summary *response_time;
+     struct gkc_summary *total_time;
++
++    /**
++     * average event loop latency per worker thread
++     */
++    H2O_VECTOR(uint64_t) evloop_latency_ms;
+ };
+ 
+ struct st_duration_agg_stats_t {","Could you please elaborate the reason for not using `gkc_summary` like the values above? I ask this, because I assume what we want to collect is a histogram of event loop latency, and we use `gkc_summary` for collecting histograms.",Why do we need this?
+1344,"@@ -187,7 +187,7 @@ Block.prototype.getTransactionHashes = function getTransactionHashes() {
+     return [Block.Values.NULL_HASH];
+   }
+   for (var t = 0; t < this.txs.length; t++) {
+-    hashes.push(this.txs[t].hash());
++    hashes.push(this.txs[t]._getHash());
+   }
+   return hashes;
+ };",getHash should be a public and without an `_` if used here.,Why is this change needed?
+1345,"@@ -71,6 +71,10 @@ func (dv *DefaultBlockValidator) ValidateSemantic(ctx context.Context, child *ty
+ 
+ // ValidateSyntax validates a single block is correctly formed.
+ func (dv *DefaultBlockValidator) ValidateSyntax(ctx context.Context, blk *types.Block) error {
++	// hack validate genesisblock
++	if blk.Height == 0 {
++		return nil
++	}
+ 	now := uint64(dv.Now().Unix())
+ 	if uint64(blk.Timestamp) > now {
+ 		return fmt.Errorf(""block %s with timestamp %d generate in future at time %d"", blk.Cid().String(), blk.Timestamp, now)",Unrelated to these changes -- we will probably want some special handling for genesis block validation.,Why do we need this?
+1346,"@@ -75,6 +75,10 @@ type diskBlockCacheSetter interface {
+ 	MakeDiskBlockCacheIfNotExists() error
+ }
+ 
++type diskBlockCacheFractionSetter interface {
++	SetDiskBlockCacheFraction(float64)
++}
++
+ type clockGetter interface {
+ 	Clock() Clock
+ }","This is probably overkill since we don't actually need to pass this specific interface anywhere, but I don't mind it!",Why do we need this interf
+1347,"@@ -56,6 +56,8 @@ func (d *Driver) AddPeer(ctx context.Context, addr swarm.Address) error {
+ 		d.mtx.Unlock()
+ 		return nil
+ 	}
++
++	d.receivedPeers[addr.ByteString()] = struct{}{}
+ 	d.mtx.Unlock()
+ 
+ 	connectedPeers := d.p2pService.Peers()","@janos I moved this back here, to avoid having multiple add peer calls being handled. I think it's either this or a global lock across the whole function. I think this is a better approach, especially since `hive.Broadcast` is blocking . We can remove the map entry on errors if needed. LMKWYT?",Why do we need this?
+1348,"@@ -0,0 +1,19 @@
++<% if display_response_actions?(cart, current_user) %>
++  <div id='reply-section'>
++    <p>
++      <%= link_to ""Approve"",
++          approval_response_path(approver_action: 'approve',
++                                 cart_id: cart.id,
++                                 scheme: 'https',
++                                 user_id: current_user.id,
++                                 ), class: 'form-button' %>
++
++      <%= link_to ""Reject"",
++          approval_response_path(approver_action: 'reject',
++                                 cart_id: cart.id,
++                                 scheme: 'https',
++                                 user_id: current_user.id,
++                                 ), class: 'reject-link' %>
++    </p>
++  </div>
++<% end %>",Minor: can we put the conditional outside of the partial?,"I think this should be `approve-link`, not `reject-link`."
+1349,"@@ -887,7 +887,8 @@ class AsyncSniffer(object):
+ 
+                 if isinstance(offline, Packet):
+                     tempfile_written, offline = _write_to_pcap([offline])
+-                elif isinstance(offline, list) and \
++                elif (isinstance(offline, list) or
++                        isinstance(offline, PacketList)) and \
+                         all(isinstance(elt, Packet) for elt in offline):
+                     tempfile_written, offline = _write_to_pcap(offline)
+ ",We need to find something more efficient than this. We can probably just check the first element and assume the type list is consistent..,"`isinstance(offline, (list, PacketList))`"
+1350,"@@ -29,6 +29,9 @@ var (
+ executions and is good for jobs which need to run frequently. ""Fixed Schedule""
+ lets you use a predefined or custom cron schedule and is good for less-frequent 
+ jobs or those which require specific execution schedules.`
++
++	fmtJobInitTypeHelp = `A %s is a task which can be programmatically run, either on a schedule or via
++service code in response to events.`
+ )
+ 
+ const (","How "" via service code in response to event.""? I don't think we'll get in the no schedule option to the release. We should probably wait for some customer feedback first to make sure we're addressing different event-triggers the best way","`A %s is a task which can be programmatically run, either"
+1351,"@@ -65,7 +65,6 @@ PER_YIELD = 1024
+ 
+ def generate_model_handle():
+     """"""Generate random model handle.
+-
+     Returns:
+         str: random bytes for handle
+     """"""",Please move unrelated formatting changes to their own PR (same with the resources.py file).,Why is this removed?
+1352,"@@ -2171,6 +2171,7 @@ class CommandDispatcher:
+ 
+         window = self._tabbed_browser.window()
+         if window.isFullScreen():
+-            window.showNormal()
++            window.setWindowState(window._state_before_fullscreen & ~Qt.WindowFullScreen)
+         else:
++            window._state_before_fullscreen = window.windowState()
+             window.showFullScreen()",Make this a public attribute (remove the leading `_`) if you want to access it from the outside.,This should be `window.setWindowState(window.windowState() & ~Qt.WindowFullScreen)`
+1353,"@@ -116,7 +116,7 @@ define(['layoutManager', 'browser', 'actionsheet', 'css!./emby-select', 'registe
+             inputId++;
+         }
+ 
+-        if (!browser.firefox) {
++        if (browser) {
+             this.classList.add('emby-select-withcolor');
+ 
+ 			if (layoutManager.tv) {",this conditional is useless now so it should be removed,Why is this change needed?
+1354,"@@ -262,8 +262,8 @@ void AccessFlatBufferTest(const uint8_t *flatbuf, size_t length,
+   auto vecofstructs = monster->testarrayofsortedstruct();
+   if (vecofstructs) {  // not filled in monster_test.bfbs
+     for (size_t i = 0; i < vecofstructs->size()-1; i++) {
+-      auto left = vecofstructs->Get(i);
+-      auto right = vecofstructs->Get(i+1);
++      auto left = vecofstructs->Get(static_cast<flatbuffers::uoffset_t>(i));
++      auto right = vecofstructs->Get(static_cast<flatbuffers::uoffset_t>(i+1));
+       TEST_EQ(true, (left->KeyCompareLessThan(right)));
+     }
+     TEST_NOTNULL(vecofstructs->LookupByKey(3));","`vecofstructs->size()` already returns a `uoffset_t`. So if you just change the type of `i`, you don't need any casts.",Why is this needed?
+1355,"@@ -197,7 +197,14 @@ public abstract class GapicProductConfig implements ProductConfig {
+     }
+ 
+     // Toggle on/off proto annotations parsing.
+-    ProtoParser protoParser = new ProtoParser(getDefaultLanguageFeatureConfig(language, null));
++    ProtoParser protoParser;
++    // TODO(andrealin): Expose command-line option for toggling proto annotations parsing.
++    if (configProto == null) {
++      // By default, enable proto annotations parsing when no GAPIC config is given.
++      protoParser = new ProtoParser(true);
++    } else {
++      protoParser = new ProtoParser(getDefaultLanguageFeatureConfig(language, null));
++    }
+     if (configProto == null) {
+       configProto = ConfigProto.getDefaultInstance();
+     }","Nit: Maybe merge this with the configProto check on line 208? Don't feel that strongly though, please keep separate if you prefer.",Why do we need this TODO?
+1356,"@@ -138,7 +138,7 @@ describe.skip('Buffering Proxy', function() {
+           if (die) {
+             request.connection.destroy();
+           } else {
+-            if (doc.ismaster) {
++            if (doc.ismaster || doc.hello) {
+               request.reply(primary[currentIsMasterIndex]);
+             } else if (doc.insert) {
+               request.reply({ ok: 1, n: 1 });","I know we already did this in 4.0 so carry on, but I'm facepalming here we should've made an overrided setMessageHandler that sets ismaster to true when hello is present. Esp in 4.0 where we already have some overrides written. We can keep going here and maybe open a ticket to some effect of that solution",I think this should be `doc.hello === true`
+1357,"@@ -7,6 +7,10 @@
+   <%= json_api_link_tag %>
+ <% end %>
+ 
++<% content_for(:skip_links) do -%>
++  <a href=""#documents"" class=""element-invisible element-focusable"" data-turbolinks=""false"">Skip to first result</a>
++<% end %>
++
+ <% content_for(:container_header) do -%>
+   <h1 class=""sr-only top-content-title""><%= t('blacklight.search.header') %></h1>
+ ","I believe we could use `link_to` here (although not super important). Also, we should internationalize this value. I'm not 100% sure what our process is for adding new UI strings these days (e.g. skip the specs that will fail if we add a new key to only one language, use Google Translate to translate the value for us, some other option).",I think this should be `<%= t('blacklight.s
+1358,"@@ -1323,11 +1323,9 @@ VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceDisplayPropertiesKHR(VkPhysicalD
+         instance_data->instance_dispatch_table.GetPhysicalDeviceDisplayPropertiesKHR(physicalDevice, pPropertyCount, pProperties);
+ 
+     lock.lock();
+-    if (result == VK_SUCCESS) {
+-        if (pProperties) {
+-            for (uint32_t i = 0; i < *pPropertyCount; ++i) {
+-                CreateObject(physicalDevice, pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
+-            }
++    if ((result == VK_SUCCESS || result == VK_INCOMPLETE) && pProperties) {
++        for (uint32_t i = 0; i < *pPropertyCount; ++i) {
++            CreateObject(physicalDevice, pProperties[i].display, kVulkanObjectTypeDisplayKHR, nullptr);
+         }
+     }
+     lock.unlock();",This was already in vkGetPhysicalDeviceDisplayProperties2KHR...,I think it would be better to use `if (resu
+1359,"@@ -498,3 +498,7 @@ type tasksStopper interface {
+ type serviceLinkedRoleCreator interface {
+ 	CreateECSServiceLinkedRole() error
+ }
++
++type dockerEngineValidator interface {
++	IsDockerEngineRunning() (string, error)
++}","nit: I'd expect a public method called IsDockerEngineRunning to return a boolean yes/no, not the error message. Can we change either the return value or the name? Something like `CallDockerEngine`",nit: `IsDockerEngineRunning` -> `IsDockerEn
+1360,"@@ -322,12 +322,12 @@ def define_model(model_name, dbengine, model_seed):
+         cai_resource_name = Column(String(4096))
+         cai_resource_type = Column(String(512))
+         full_name = Column(String(2048), nullable=False)
+-        type_name = Column(get_string_by_dialect(dbengine.dialect.name, 512),
++        type_name = Column(get_string_by_dialect(dbengine.dialect.name, 700),
+                            primary_key=True)
+         parent_type_name = Column(
+-            get_string_by_dialect(dbengine.dialect.name, 512),
++            get_string_by_dialect(dbengine.dialect.name, 700),
+             ForeignKey('{}.type_name'.format(resources_tablename)))
+-        name = Column(String(256), nullable=False)
++        name = Column(String(1024), nullable=False)
+         type = Column(String(128), nullable=False)
+         policy_update_counter = Column(Integer, default=0)
+         display_name = Column(String(256), default='')","If i remembered correctly, type_name is '{RESOURCE_TYPE}/{RESOURCE_NAME}', if type_name is 700 max then name cannot exceed that size",Why did you change this?
+1361,"@@ -20,6 +20,13 @@ def GetSizePrefix(buf, offset):
+ 	""""""Extract the size prefix from a buffer.""""""
+ 	return encode.Get(packer.int32, buf, offset)
+ 
++def GetBufferIdentifier(buf, offset, size_prefixed = False):
++        """"""Extract the file_identifier from a buffer""""""
++        offset+=(number_types.UOffsetTFlags.bytewidth if size_prefixed else 0) + number_types.UOffsetTFlags.bytewidth # offset sizeof(root table offset) + sizeof(size prefix) if present   
++        return buf[offset:offset+encode.FILE_IDENTIFIER_LENGTH]
++def BufferHasIdentifier(buf, offset, file_identifier, size_prefixed = False):
++        return GetBufferIdentifier(buf, offset, size_prefixed)==file_identifier
++
+ def RemoveSizePrefix(buf, offset):
+ 	""""""
+ 	Create a slice of a size-prefixed buffer that has","When calling functions with keyword arguments: please provide the arguments as keyword arguments, not positional arguments.",nit: space after `==`
+1362,"@@ -41,7 +41,7 @@ class BasicResBlock(nn.Module):
+             out_channels,
+             kernel_size=1,
+             bias=False,
+-            activation=None,
++            act_cfg=None,
+             conv_cfg=conv_cfg,
+             norm_cfg=norm_cfg)
+ ","We may follow the argument order: conv_cfg, norm_cfg, act_cfg.",act_cfg -> activation_cf
+1363,"@@ -60,6 +60,19 @@ module Selenium
+ 
+         class << self
+           def chrome(opts = {})
++            define_method(:options) { @capabilities[:chrome_options] ||= {} }
++            define_method(""options="") { |value| @capabilities[:chrome_options] = value }
++            define_method(""profile="") do |profile|
++              profile_json = profile.as_json
++              options['args'] ||= []
++              if options['args'].none? { |arg| arg =~ /user-data-dir/ }
++                options['args'] << ""--user-data-dir=#{profile_json[:directory]}""
++              end
++              options['extensions'] = profile_json[:extensions]
++            end
++            alias_method :chrome_options, :options
++            alias_method :chrome_options=, :options=
++
+             new({
+               browser_name: 'chrome',
+               javascript_enabled: true,",`options['binary'] = WebDriver::Chrome.path` if set?,I'm not sure if this is 
+1364,"@@ -5,6 +5,7 @@
+  */
+ 
+ #include <errno.h>
++#include <folly/ssl/Init.h>
+ #include <signal.h>
+ #include <string.h>
+ #include <thrift/lib/cpp2/server/ThriftServer.h>",folly library should be put on the top.,Why is this needed?
+1365,"@@ -35,6 +35,7 @@ let CAMEL_REG = /-?(?=[A-Z])/g;
+ function setProperty(dom, name, value, oldValue, isSvg) {
+ 	let v;
+ 	if (name==='class' || name==='className') name = isSvg ? 'class' : 'className';
++	const ns = isSvg && (name !== (name = name.replace(/^xlink:?/, '')));
+ 
+ 	if (name==='style') {
+ ","Do we have to restrict this to SVG elements? I think setting namespaced attributes on normal dom elements (while not as common) is still valid, so perhaps we can save some bytes by removing the `isSvg` check?",Why is this needed?
+1366,"@@ -134,7 +134,7 @@ class DataProvider {
+    * @returns {boolean}
+    */
+   _isHiddenRow(row) {
+-    return this.hot.hasHook('hiddenRow') && this.hot.runHooks('hiddenRow', row);
++    return this.hot.rowIndexMapper.isHidden(this.hot.toPhysicalRow(row));
+   }
+ 
+   /**",Please add it to the `REMOVED_HOOKS` constant.,Why do we need to c
+1367,"@@ -1,7 +1,9 @@
+ describe('fieldset', function () {
+ 	'use strict';
+ 	var fixture = document.getElementById('fixture');
++	var shadowSupport = axe.testUtils.shadowSupport;
+ 	var fixtureSetup = axe.testUtils.fixtureSetup;
++
+ 	var checkContext = {
+ 		_data: null,
+ 		data: function (d) {","This variable needs `.v1` at the end of it, or the tests below need it. There are some test failures as a result",`shadowSupport` is 
+1368,"@@ -25,6 +25,12 @@ class AccountsController < ApplicationController
+     render json: Chart.new(@account).commits_by_language(params[:scope])
+   end
+ 
++  def label_as_spammer
++    @account = Account.find_by(id: params[:id])
++    Account::Access.new(@account).spam!
++    render template: 'accounts/disabled'
++  end
++
+   private
+ 
+   def account",Is this access protected so that only admins can access this route?,Why do we need this?
+1369,"@@ -328,7 +328,7 @@ void wlr_output_layout_closest_point(struct wlr_output_layout *layout,
+ 		return;
+ 	}
+ 
+-	double min_x = DBL_MAX, min_y = DBL_MAX, min_distance = DBL_MAX;
++	double min_x = 0, min_y = 0, min_distance = DBL_MAX;
+ 	struct wlr_output_layout_output *l_output;
+ 	wl_list_for_each(l_output, &layout->outputs, link) {
+ 		if (reference != NULL && reference != l_output->output) {","What happens if the minimum x coord is > 0? This will incorrectly set it as zero, right?",Why is this needed?
+1370,"@@ -1637,6 +1637,11 @@ func (o *consumer) processNextMsgReq(_ *subscription, c *client, _, reply string
+ 		return
+ 	}
+ 
++	if o.maxp > 0 && batchSize > o.maxp {
++		sendErr(409, ""Exceeded MaxAckPending"")
++		return
++	}
++
+ 	// In case we have to queue up this request.
+ 	wr := waitingRequest{client: c, reply: reply, n: batchSize, noWait: noWait, expires: expires}
+ ",I think you want to look at current pending + batchSize and if that is > o.maxp no?,I think this should 
+1371,"@@ -189,7 +189,7 @@ func (h *Harness) testSpan(tracerFactory func() trace.Tracer) {
+ 			span.AddEventWithTimestamp(context.Background(), time.Now(), ""test event"")
+ 		},
+ 		""#SetStatus"": func(span trace.Span) {
+-			span.SetStatus(codes.Internal, ""internal"")
++			span.SetStatus(codes.Ok, ""internal"")
+ 		},
+ 		""#SetName"": func(span trace.Span) {
+ 			span.SetName(""new name"")",Should this be `codes.Error`? `codes.Internal` was an error status before.,Why is this change n
+1372,"@@ -26,6 +26,11 @@ class AccountsController < ApplicationController
+     @projects, @logos = @account.project_core.used
+     @twitter_detail = TwitterDetail.new(@account)
+     page_context[:page_header] = 'accounts/show/header'
++    respond_to do |format|
++      format.html
++      format.xml
++      format.json
++    end
+   end
+ 
+   def me",I don't think you need these lines.,Extra empty line detected at class body end.
+1373,"@@ -195,7 +195,7 @@ type tlfJournal struct {
+ 	// Invariant: this tlfJournal acquires exactly
+ 	// blockJournal.getStoredBytes() and
+ 	// blockJournal.getStoredFiles() until shutdown.
+-	DiskLimiter DiskLimiter
++	diskLimiter DiskLimiter
+ 
+ 	// All the channels below are used as simple on/off
+ 	// signals. They're buffered for one object, and all sends are","You didn't mean to export this, right?",Nit: I think this should be `diskLimiter`.
+1374,"@@ -3,7 +3,7 @@
+ 
+ # Purpose:
+ # sns-ruby-example-show-topics.rb demonstrates how to list Amazon Simple Notification Services (SNS) topics using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+ 
+ # Inputs:
+ # - REGION",Simple Notification **Service** (singular),I'm not sure if this is the right way to do 
+1375,"@@ -313,6 +313,7 @@ type client struct {
+ 	replayMutex   sync.RWMutex
+ 	nodeConfig    *config.NodeConfig
+ 	networkConfig *config.NetworkConfig
++	egressConfig  *config.EgressConfig
+ 	gatewayOFPort uint32
+ 	// ovsDatapathType is the type of the datapath used by the bridge.
+ 	ovsDatapathType ovsconfig.OVSDatapathType",Do we still need this?,Why is this a pointer?
+1376,"@@ -108,9 +108,6 @@ public abstract class AbstractEeaSendRawTransaction implements JsonRpcMethod {
+         final Transaction privateMarkerTransaction =
+             createPrivateMarkerTransaction(privateTransaction, user);
+ 
+-        LOG.error(""CHEESE"");
+-        LOG.error(privateMarkerTransaction.getHash());
+-
+         return transactionPool
+             .addLocalTransaction(privateMarkerTransaction)
+             .either(",We do have a disconnect between the privateMarkerTransactionFactory.getSender() call and the createPrivateMarkerTransaction() call. When the plugin receives the call to create the PMT it does not know what the sender was returned by the other call. At a minimum we need to pass in the sender to the second call. I would prefer that the plugin does the locking if that is necessary. If you are using random keys you don't have to lock! Besu could signal to the plugin when a PMT was un- or successfully added to the pool using a callback. Callback could be null if this is not needed. The plugin would have to be able to get the nonce for a certain key from besu. What do you think?,Why is this being removed?
+1377,"@@ -217,7 +217,7 @@ import 'css!./imageeditor';
+             reload(context, null, focusContext);
+         }, function () {
+             import('alert').then(({default: alert}) => {
+-                alert(globalize.translate('DefaultErrorMessage'));
++                alert(globalize.translate('MessageDefaultError'));
+             });
+         });
+     }",This is a bit inconsistent with the `ErrorStartHourGreaterThanEnd` in the previous file. Wouldn't `ErrorDefault``fit better here?,I think this should be `Me
+1378,"@@ -35,12 +35,13 @@ import (
+ 	""antrea.io/antrea/pkg/features""
+ )
+ 
+-func skipIfNetworkPolicyStatsDisabled(tb testing.TB, data *TestData) {
+-	skipIfFeatureDisabled(tb, data, features.NetworkPolicyStats, true, true)
++func skipIfNetworkPolicyStatsDisabled(tb testing.TB) {
++	skipIfFeatureDisabled(tb, features.NetworkPolicyStats, true, true)
+ }
+ 
+-func TestNetworkPolicyStats(t *testing.T) {
+-	skipIfNotIPv4Cluster(t)
++// TestNetworkPolicy is the top-level test which contains all subtests for
++// NetworkPolicy related test cases so they can share setup, teardown.
++func TestNetworkPolicy(t *testing.T) {
+ 	skipIfHasWindowsNodes(t)
+ 
+ 	data, err := setupTest(t)",I think it will revert the change @antoninbas did on purpose 05eee251c9c53400277def576f92d614ca234898,Why is this being removed?
+1379,"@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti
+ 	epType := tc.EpTypeHost
+ 	if ifaceName == ""tunl0"" {
+ 		epType = tc.EpTypeTunnel
++	} else if ifaceName == ""wireguard.cali"" {
++		epType = tc.EpTypeWireguard
+ 	}
+ 	ap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)
+ 	ap.HostIP = m.hostIP",nit: a switch perhaps?,Why do we need this?
+1380,"@@ -14,7 +14,7 @@
+     <![endif]-->
+ 
+     <title><%= render_page_title %></title>
+-    <link href=""<%= opensearch_catalog_path(:format => 'xml', :only_path => false) %>"" title=""<%= application_name%>"" type=""application/opensearchdescription+xml"" rel=""search""/>
++    <%= opensearch_description_tag application_name, opensearch_catalog_path(:format => 'xml', :only_path => false) %>
+     <%= favicon_link_tag asset_path('favicon.ico') %>
+     <%= stylesheet_link_tag    ""application"" %>
+     <%= javascript_include_tag ""application"" %>",Would it make sense for `opensearch_description_tag` to have default values for the title and href attributes?,I don't think you need the `<%=` here.
+1381,"@@ -281,7 +281,7 @@ func (j journalMDOps) getRange(
+ 	[]ImmutableRootMetadata, error) {
+ 	// Grab the range from the journal first.
+ 	jirmds, err := j.getRangeFromJournal(ctx, id, bid, mStatus, start, stop)
+-	if err != nil {
++	if err != nil && err != errTLFJournalDisabled {
+ 		return nil, err
+ 	}
+ ",Just noticed this while debugging -- it's unlikely to be causing issues in practice.,Why is this change needed?
+1382,"@@ -75,7 +75,7 @@ describe( 'setting up the Analytics module with no existing account and no exist
+ 		await expect( page ).toClick( '.googlesitekit-analytics__select-country' );
+ 		await expect( page ).toClick( '.mdc-menu-surface--open li', { text: /united kingdom/i } );
+ 
+-		await expect( page ).toMatchElement( 'p', { text: /need to give Site Kit permission to create an Analytics account/i } );
++		await expect( page ).toMatchElement( 'p', { text: /need to give Site Kit permission to create an Analytics account/i, timeout: 750 } );
+ 
+ 		await Promise.all( [
+ 			page.waitForNavigation(), // User is sent directly to OAuth.",That seems unrelated - did that fix a random test failure you noticed while working on this issue?,Why do we need this timeout?
+1383,"@@ -98,8 +98,11 @@ public abstract class BaseMetastoreTableOperations implements TableOperations {
+       LOG.info(""Nothing to commit."");
+       return;
+     }
++    TableMetadata updated = (base != null && base.file() != null) ?
++            metadata.addPreviousMetadata(base.file().location(), base.lastUpdatedMillis()) : metadata;
+ 
+-    doCommit(base, metadata);
++    doCommit(base, updated);
++    deleteRemovedMetadata(updated);
+     requestRefresh();
+   }
+ ","This kind of concern should be handled in the `TableMetadata` update methods. This is similar to `metadata.rollbackTo`, which not only sets the current version, but also updates the table history. I think that all of those methods should add the current object's `file.location()` to the previous metadata location list, if it is non-null. That way, the caller never needs to remember to update it.",Why do we need this check?
+1384,"@@ -82,3 +82,18 @@ def flip_tensor(src_tensor, flip_direction):
+     else:
+         out_tensor = torch.flip(src_tensor, [2, 3])
+     return out_tensor
++
++
++def collect_mlvl_tensor_single(mlvl_tensors, batch_id, detach=True):
++    assert isinstance(mlvl_tensors, (list, tuple))
++    num_levels = len(mlvl_tensors)
++
++    if detach:
++        mlvl_tensor_list = [
++            mlvl_tensors[i][batch_id].detach() for i in range(num_levels)
++        ]
++    else:
++        mlvl_tensor_list = [
++            mlvl_tensors[i][batch_id] for i in range(num_levels)
++        ]
++    return mlvl_tensor_list",We need to know why all the tensors are detached in `get_bboxed`.,"nit: you can use `for batch_id, mlvl_tensor in enumerate(mlvl_tensors)`"
+1385,"@@ -309,3 +309,13 @@ class Foo:
+ 
+     def method(self):
+         print(self.__class__.__ham)
++
++
++class TypeSelfCallInMethod:
++    """"""Regression test for issue 5569""""""
++    @classmethod
++    def b(cls) -> None:
++        cls.__a = ''  # [unused-private-member]
++
++    def a(self):
++        return type(self).__a",Unrelated but shouldn't this raise `attribute-defined-outside-init`?,Can you add a docstring here?
+1386,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+ 
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low.",Why do we need this?
+1387,"@@ -98,8 +98,7 @@ class Phase < ActiveRecord::Base
+   # TODO: Move this to Plan model as `num_answered_questions(phase=nil)`
+   # Returns the number of answered question for the phase.
+   def num_answered_questions(plan)
+-    return 0 if plan.nil?
+-    sections.to_a.sum { |s| s.num_answered_questions(plan) }
++    plan&.num_answered_questions.to_i
+   end
+ 
+   # Returns the number of questions for a phase. Note, this method becomes useful",You just changed my life :) I grew very attached to this safe nav approach when working with Groovy years ago `obj?.method`. Glad to see its now a part of Ruby!,I think this should be `.to_i`
+1388,"@@ -23,9 +23,10 @@
+       <div class=""checkbox"">
+         <%= f.label :published, raw(""#{f.check_box :published, as: :check_boxes, 'data-toggle': 'tooltip', title: _(""Check this box when you are ready for this guidance to appear on user's plans."")} #{_('Published?')}"") %>
+       </div>
+-
+-      <%= f.submit _('Save'), name: ""edit_guidance_submit"", class: ""btn btn-primary"" %>
+-      <%= link_to _('Cancel'), admin_index_guidance_path, class: ""btn btn-primary"", role: 'button' %>
++      <div class=""form-group clear-fix"">
++        <%= f.submit _('Save'), name: ""edit_guidance_submit"", class: ""btn btn-primary"" %>
++        <%= link_to _('Cancel'), admin_index_guidance_path, class: ""btn btn-primary"", role: 'button' %>
++      </div>
+     <%end%>
+   </div>
+ </div>",do you mean 'clearfix' class?,I don't think you need the `clear-fix` class here.
+1389,"@@ -391,6 +391,7 @@ MongoClient.connect = function(url, options, callback) {
+  * Starts a new session on the server
+  *
+  * @param {SessionOptions} [options] optional settings for a driver session
++ * @param {boolean} [options.causalConsistency=true] Enables or disables causal consistency for the session.
+  * @return {ClientSession} the newly established session
+  */
+ MongoClient.prototype.startSession = function(options) {",`causalConsistency` is already defined on `SessionOptions`. We do not need to duplicate it here.,This should be `options.causalConsistency === true
+1390,"@@ -46,9 +46,7 @@ import java.lang.reflect.Method;
+ 
+ import static org.assertj.core.api.AssertionsForClassTypes.assertThatThrownBy;
+ import static org.assertj.core.api.AssertionsForInterfaceTypes.assertThat;
+-import static org.mockito.ArgumentMatchers.any;
+-import static org.mockito.ArgumentMatchers.anyString;
+-import static org.mockito.ArgumentMatchers.eq;
++import static org.mockito.ArgumentMatchers.*;
+ import static org.mockito.Mockito.*;
+ 
+ /**",This should not be included since there are no code changes.,Please avoid wildcard imports.
+1391,"@@ -56,6 +56,18 @@ func askCredentials(c *context.Context, status int, text string) {
+ 
+ func HTTPContexter() macaron.Handler {
+ 	return func(c *context.Context) {
++		if len(setting.HTTP.AccessControlAllowOrigin) > 0 {
++			// Set CORS headers for browser-based git clients
++			c.Resp.Header().Set(""Access-Control-Allow-Origin"", setting.HTTP.AccessControlAllowOrigin)
++			c.Resp.Header().Set(""Access-Control-Allow-Headers"", ""Content-Type, Authorization"")
++
++			// Handle preflight OPTIONS request
++			if c.Req.Method == ""OPTIONS"" {
++				c.Status(http.StatusOK)
++				return
++			}
++		}
++
+ 		ownerName := c.Params("":username"")
+ 		repoName := strings.TrimSuffix(c.Params("":reponame""), "".git"")
+ 		repoName = strings.TrimSuffix(repoName, "".wiki"")","If all we need just response 200, then we could use `c.Status(http.StatusOK)` here.",Why do we need this?
+1392,"@@ -683,6 +683,11 @@ func loadConfigFromDatastore(
+ 		Name:      ""node."" + hostname,
+ 		Namespace: """",
+ 	}, """")
++	n, err := client.Get(ctx, model.ResourceKey{
++		Kind:      apiv2.KindNode,
++		Name:      hostname,
++		Namespace: """",
++	}, """")
+ 	if _, ok := err.(errors2.ErrorResourceDoesNotExist); err != nil && !ok {
+ 		return
+ 	}",Should be checking for error here,Why do we need this?
+1393,"@@ -431,7 +431,7 @@ class Form extends WidgetBase
+             $this->fields = [];
+         }
+ 
+-        $this->allTabs->outside = new FormTabs(FormTabs::SECTION_OUTSIDE, $this->config);
++        $this->allTabs->outside = new FormTabs(FormTabs::SECTION_OUTSIDE, (array)$this->config);
+         $this->addFields($this->fields);
+ 
+         /*",Put a space between `(array)` and `$this` and I'll merge it,`$this->config` is a
+1394,"@@ -0,0 +1,6 @@
++package runtime
++
++// Stack is a stub, not implemented
++func Stack(buf []byte, all bool) int {
++	return 0
++}","You could add this to stack.go, which has similar functions (to avoid yet another small file). None of these are likely to be implemented considering what TinyGo is designed for.",Why do we need this?
+1395,"@@ -0,0 +1,13 @@
++package com.fsck.k9.notification;
++
++
++class NotificationHolder {
++    public final int notificationId;
++    public final NotificationContent content;
++
++
++    public NotificationHolder(int notificationId, NotificationContent content) {
++        this.notificationId = notificationId;
++        this.content = content;
++    }
++}","the class names `NotificationHolder` and `NotificationsHolder` are fairly difficult to quickly tell apart, particularly since they are often used close to each other",Why do we need this 
+1396,"@@ -23,10 +23,7 @@
+  */
+ package net.runelite.client.plugins.freezetimers;
+ 
+-import java.util.ArrayList;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
+ import javax.inject.Singleton;
+ import lombok.extern.slf4j.Slf4j;
+ import net.runelite.api.Actor;",Avoid wildcard imports,Don't use star imports
+1397,"@@ -71,7 +71,7 @@ type (
+ 		GetContractState(hash.PKHash, hash.Hash32B) (hash.Hash32B, error)
+ 		SetContractState(hash.PKHash, hash.Hash32B, hash.Hash32B) error
+ 		// Candidate pool
+-		candidates() (uint64, []*Candidate)
++		Candidates() (uint64, []*Candidate)
+ 		CandidatesByHeight(uint64) ([]*Candidate, error)
+ 	}
+ ",Need to do this to unblock mockgen. The interface method needs to be public to be visible in another package. The right fix is to delete this test only interface method,Why did you change thi
+1398,"@@ -101,6 +101,13 @@ module.exports = function(url, options, callback) {
+         record = record[0].join('');
+         const parsedRecord = qs.parse(record);
+         const items = Object.keys(parsedRecord);
++        if (
++          Object.keys(items)
++            .map(k => k.toLowerCase())
++            .indexOf('loadbalanced') !== -1
++        ) {
++          return callback(new MongoParseError('Load balancer mode requires driver version 4+'));
++        }
+         if (items.some(item => item !== 'authSource' && item !== 'replicaSet')) {
+           return callback(
+             new MongoParseError('Text record must only set `authSource` or `replicaSet`')",same question here as I have on the other file regarding doing this check here vs L112 vs not at all,I think this should be
+1399,"@@ -1,3 +1,5 @@
++// +build !openbsd
++
+ package fuse
+ 
+ import (",Adding `// +build !windows` (as a separate line) will do the same for Windows. So while you are at it we might add it as well.,Why is this needed?
+1400,"@@ -35,7 +35,6 @@ class BZAObject(dict):
+         self.token = None
+         self.log = logging.getLogger(self.__class__.__name__)
+         self.http_session = requests.Session()
+-        self.http_request = self.http_session.request
+ 
+         # copy infrastructure from prototype
+         if isinstance(proto, BZAObject):","this is used as important way of mocking for unit tests, FYI",Why was this removed?
+1401,"@@ -156,6 +156,7 @@ if not config.style_17:
+     options.Points = Options('plot', show_frame=True)
+ 
+ options.Histogram = Options('style', line_color='black', fill_color=Cycle())
++options.Distribution = Options('style', muted_alpha=0.2)
+ options.ErrorBars = Options('style', color='black')
+ options.Spread = Options('style', color=Cycle(), alpha=0.6, line_color='black')
+ options.Bars = Options('style', color=Cycle(), line_color='black', width=0.8)","Sorry, should have been clearer, I meant adding this to the ``Histogram`` options one line above.",I don't think we need
+1402,"@@ -566,7 +566,7 @@ namespace pwiz.SkylineTest
+             // Bad terminus
+             AssertEx.DeserializeError<StaticMod>(""<static_modification name=\""Mod\"" terminus=\""X\"" formula=\""C23N\"" />"");
+             // Bad formula
+-            AssertEx.DeserializeError<StaticMod, ArgumentException>(""<static_modification name=\""Mod\"" aminoacid=\""K\"" formula=\""C23NHe2\"" />"");
++            AssertEx.DeserializeError<StaticMod, ArgumentException>(""<static_modification name=\""Mod\"" aminoacid=\""K\"" formula=\""C23NHx2\"" />"");
+             // Terminal label without amino acid
+             AssertEx.DeserializeError<StaticMod>(""<static_modification name=\""15N\"" terminus=\""C\"" label_13C=\""true\""/>"");
+             // Formula and labeled atoms","Just ignorance on my part, but what is the significance of the change from C23NHe2 to C23NHx2?",Why was this changed?
+1403,"@@ -486,6 +486,12 @@ class histogram(Operation):
+     bin_range = param.NumericTuple(default=None, length=2,  doc=""""""
+       Specifies the range within which to compute the bins."""""")
+ 
++    bins = param.ClassSelector(default=None, class_=(np.ndarray, list), doc=""""""
++      An explicit set of bin edges."""""")
++
++    cumulative = param.Boolean(default=False, doc=""""""
++      Whether to compute the cumulative histogram"""""")
++
+     dimension = param.String(default=None, doc=""""""
+       Along which dimension of the Element to compute the histogram."""""")
+ ",What about tuples or pandas series? Do we want to support lots of different types or force a single type?,I don't think you nee
+1404,"@@ -294,10 +294,6 @@ public class ZkStateReader implements SolrCloseable {
+     log.debug(""Loading collection config from: [{}]"", path);
+ 
+     try {
+-      if (zkClient.exists(path, true) == false) {
+-        log.warn(""No collection found at path {}."", path);
+-        throw new KeeperException.NoNodeException(""No collection found at path: "" + path);
+-      }
+       byte[] data = zkClient.getData(path, null, null, true);
+       if (data == null) {
+         log.warn(""No config data found at path {}."", path);","Small thing, without the check above this will throw a NoNodeException if the path doesn't exist. Maybe this can be wrapped in a try/catch just for the NoNodeException, so that the more user-friendly message used above can be thrown instead: `throw new KeeperException.NoNodeException(""No collection found at path: "" + path);` Just a thought, I'm not even sure it's worth it.",Why is this removed?
+1405,"@@ -17,7 +17,7 @@ class Project < ActiveRecord::Base
+   validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: { case_sensitive: false }
+   validates :description, length: 0..800, allow_nil: true # , if: proc { |p| p.validate_url_name_and_desc == 'true' }
+   validates_each :url, :download_url, allow_blank: true do |record, field, value|
+-    record.errors.add(field, I18n.t(:not_a_valid_url)) unless value.valid_http_url?
++    record.errors.add(field, I18n.t(:not_a_valid_url)) unless value.blank? || value.valid_http_url?
+   end
+   before_validation :clean_strings_and_urls
+   after_save :update_organzation_project_count","I don't know why this worked before, but we should be explicit on not verifying that a blank string (allowed as a way to remove a url/download_url) is a valid url as it is not.",I think this should 
+1406,"@@ -212,8 +212,7 @@ module Bolt
+ 
+         return unless !stdout.empty? && stdout.to_i < 3
+ 
+-        msg = ""Detected PowerShell 2 on controller. PowerShell 2 is deprecated and ""\
+-              ""support will be removed in Bolt 3.0.""
++        msg = ""Detected PowerShell 2 on controller. PowerShell 2 is unsupported.""
+         Bolt::Logger.deprecation_warning(""PowerShell 2 controller"", msg)
+       end
+     end","Do we want to raise an error here instead of warning? Or would it be better to just see if Bolt happens to succeed, and let it fail on it's own if it fails? I'd lean towards raising an error, but that's different from ""removing support"".",I think this should 
+1407,"@@ -44,7 +44,12 @@ module Bolt
+ 
+       # Returns options this transport supports
+       def self.options
+-        raise NotImplementedError, ""self.options() must be implemented by the transport class""
++        raise NotImplementedError,
++              ""self.options() or self.filter_options(unfiltered) must be implemented by the transport class""
++      end
++
++      def self.filter_options(unfiltered)
++        unfiltered.select { |k| options.include?(k) }
+       end
+ 
+       def self.validate(_options)",This is kind of confusing with the other `filter_options`.,I think this should 
+1408,"@@ -160,7 +160,12 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
+ 		return fs.opsByFav[fav]
+ 	}()
+ 	if ops != nil {
+-		return ops.deleteFromFavorites(ctx, fs.favs)
++		err := ops.deleteFromFavorites(ctx, fs.favs)
++		if _, ok := err.(OpsCantHandleFavorite); !ok {
++			return err
++		}
++		// If the ops couldn't handle the delete, fall through to
++		// going directly via Favorites.
+ 	}
+ 
+ 	if isLoggedIn {",Could the `deleteFromFavorites` happen when `head == nil` because it's not initialized yet somehow but not because TLF doesn't exist? I was concerned if this would make it possible in any way to have favorites seemingly deleted on a device while it's not actually happened on server.,I'm not sure if this is the best way to do this. I think it would be better to do this in `deleteFromFavorites` instead.
+1409,"@@ -457,7 +457,7 @@ void CmpSeabaseDDL::dropSeabaseSchema(StmtDDLDropSchema * dropSchemaNode)
+ 
+    bool isVolatile = (memcmp(schName.data(),""VOLATILE_SCHEMA"",strlen(""VOLATILE_SCHEMA"")) == 0);
+    int32_t length = 0;
+-   int32_t rowCount = 0;
++   Int64 rowCount = 0;
+    bool someObjectsCouldNotBeDropped = false;
+    char errorObjs[1010];
+    Queue * objectsQueue = NULL;","It doesn't look like this particular ""rowCount"" variable is used anywhere. I suppose we could delete it. The code change is harmless though.",Shouldn't this be `UInt64`?
+1410,"@@ -380,6 +380,10 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 
+ 	status, _ := s.serveHTTP(w, r)
+ 
++	if status == 204 {
++		w.WriteHeader(http.StatusNoContent)
++	}
++
+ 	// Fallback error response in case error handling wasn't chained in
+ 	if status >= 400 {
+ 		DefaultErrorFunc(w, r, status)","Hmm, probably we should instead write whatever `status` is returned instead of coding a special case.",Why do we need this?
+1411,"@@ -128,6 +128,10 @@ func parsedRuleToProtoRule(in *ParsedRule) *proto.Rule {
+ 		}
+ 	}
+ 
++	if in.HTTPMatch != nil {
++		out.HttpMatch = &proto.HTTPMatch{Methods: in.HTTPMatch.Methods}
++	}
++
+ 	// Fill in the ICMP fields.  We can't follow the pattern and make a
+ 	// convertICMP() function because we can't name the return type of the
+ 	// function (it's private to the protobuf package).","Could using the pointer-to-struct approach here cause confusion later? We've had several problems of that kind in the past. What does it mean if the struct is non-nil but its fields are nil? Is that even allowed? (libcalico-go question) Are there any validation requirements for this new rule addition; should it only be allowed if `Protocol == TCP`, for example?",Why is this needed?
+1412,"@@ -11,6 +11,7 @@ class User < ActiveRecord::Base
+ 
+   has_many :approvals
+   has_many :observations
++  has_many :observers, through: :observers, source: :user
+   has_many :comments
+ 
+   # we do not use rolify gem (e.g.) but declare relationship like any other.",why this recursive relationship definition?,"has_many :users, through: :observers"
+1413,"@@ -40,7 +40,8 @@ type Procedure struct {
+ 	// HandlerSpec specifiying which handler and rpc type.
+ 	HandlerSpec HandlerSpec
+ 
+-	// Encoding of the handler, for introspection.
++	// Encoding of the handler, optional, used for introspection, and used for
++	// routing if present.
+ 	Encoding Encoding
+ 
+ 	// Signature of the handler, for introspection. This should be a snippet of","More sentence, less list please. > Encoding of the handler. This field is optional. We don't need to mention exactly what it's used for because that list can expand (as it has already in this change).","nit: `used for introspection, and us"
+1414,"@@ -66,6 +66,10 @@
+ //   are included because they call NewRangeReader.)
+ // - NewWriter, from creation until the call to Close.
+ //
++// It also collects the following metrics:
++// - gocloud.dev/blob/bytes_read: the total number of bytes read, by provider.
++// - gocloud.dev/blob/bytes_written: the total number of bytes written, by provider.
++//
+ // To enable trace collection in your application, see ""Configure Exporter"" at
+ // https://opencensus.io/quickstart/go/tracing.
+ // To enable metric collection in your application, see ""Exporting stats"" at","Not part of this PR, but should the section above say what the name of the metric is for each method?",I'm not sure if this is the right pl
+1415,"@@ -75,13 +75,13 @@ namespace OpenTelemetry.Exporter
+ 
+                         case MetricType.LongGauge:
+                             {
+-                                // TODOs
++                                valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
+                                 break;
+                             }
+ 
+                         case MetricType.DoubleGauge:
+                             {
+-                                // TODOs
++                                valueDisplay = (metric as IGaugeMetric).LastValue.Value.ToString();
+                                 break;
+                             }
+ ","there are changes that are upcoming to this section. For now, this works (to demo the usage of Gauge), and the changes to this section are coming as separate PRs.",Why do we need this cast?
+1416,"@@ -95,7 +95,7 @@ func (t *Terminal) run(ctx context.Context) {
+ 	for {
+ 		select {
+ 		case <-ctx.Done():
+-			if IsProcessBackground() {
++			if IsProcessBackground(t.fd) {
+ 				// ignore all messages, do nothing, we are in the background process group
+ 				continue
+ 			}",This is equivalent to stdout. Why not just replace stdin with stdout in `IsProcessBackground`?,Why is this change needed?
+1417,"@@ -61,7 +61,10 @@ void DataMan::add_stream(json p_jmsg)
+         man->init(p_jmsg);
+         this->add_next(method, man);
+     }
+-    add_man_to_path(""zfp"", method);
++    if (p_jmsg[""compress_method""] != nullptr)
++    {
++        add_man_to_path(p_jmsg[""compress_method""], method);
++    }
+ }
+ 
+ void DataMan::flush() { flush_next(); }","Rather than test for nullptr, just treat the pointer as a bool, i.e. `if(p_jmsg[""compress_method""])`",This should be `if (p_jmsg
+1418,"@@ -146,6 +146,17 @@ public class LibraryFeaturePanel extends FeaturePanel<LibraryFeaturePanel, Libra
+         // get container
+         // TODO: smarter way using container manager
+         final String executablePath = shortcutCreationDTO.getExecutable().getAbsolutePath();
++        if (!executablePath.startsWith(getContainersPath())) {
++            Platform.runLater(() -> {
++                final ErrorDialog errorDialog = ErrorDialog.builder()
++                        .withMessage(tr(""Creating shortcut to executable outside of a container is not supported""))
++                        .withOwner(getScene().getWindow())
++                        .build();
++
++                errorDialog.showAndWait();
++            });
++            return;
++        }
+         final String pathInContainers = executablePath.replace(getContainersPath(), """");
+         final String[] split = pathInContainers.split(""/"");
+         final String engineContainer = split[0];","Can we move the remaining code of this method to a new method? I don't like the `return;` here, we could try to replace it with an `if ... else ...` syntax. What do you think?",I think it would be better
+1419,"@@ -0,0 +1,14 @@
++from kinto.core.events import ResourceChanged
++
++from .listener import on_resource_changed
++
++
++def includeme(config):
++    config.add_api_capability('quotas',
++                              description='Quotas Management on Buckets.',
++                              url='https://kinto.readthedocs.io')
++
++    # Listen to every resources (except history)
++    config.add_subscriber(on_resource_changed, ResourceChanged,
++                          for_resources=('bucket', 'group',
++                                         'collection', 'record'))",nitpick: _and collections_,This should be `kinto.core
+1420,"@@ -42,6 +42,8 @@ struct rp_generator_t {
+     int is_websocket_handshake;
+     int had_body_error; /* set if an error happened while fetching the body so that we can propagate the error */
+     h2o_timer_t send_headers_timeout;
++    unsigned req_done : 1;
++    unsigned res_done : 1;
+ };
+ 
+ struct rp_ws_upgrade_info_t {",I believe these need to be explicitly initialized in `proxy_send_prepare`,why is this needed?
+1421,"@@ -160,6 +160,7 @@ class TaskProcess(multiprocessing.Process):
+             # Need to have different random seeds if running in separate processes
+             random.seed((os.getpid(), time.time()))
+ 
++        t0 = time.time() # Failed task start time
+         status = FAILED
+         expl = ''
+         missing = []",This is unnecessary. The declaration of `t0` on line 179 is still in scope inside the `except` block.,`t0` is not used.
+1422,"@@ -1,6 +1,15 @@
+ */
+ 
+ 
++/**
++ * The border color when the client is marked.
++ * It has priority over the rest of beautiful border color properties.
++ * Note that only solid colors are supported.
++ * @beautiful beautiful.border_color_marked
++ * @param color
++ * @see request::border
++ */
++
+ /**
+  * The fallback border color when the client is floating.
+  *","The `border_color_`... properties don't support solid colors, not only this one. Maybe `@param solid_color` should be used instead of adding this note to every one of them?",I think this should
+1423,"@@ -0,0 +1,19 @@
++module.exports = {
++  roots: [
++    ""<rootDir>/javascript/grid-ui/src""
++  ],
++  testMatch: [
++    ""<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx""
++  ],
++  transform: {
++    ""^.+\\.(ts|tsx)$"": ""ts-jest""
++  },
++  moduleFileExtensions: [""ts"", ""tsx"", ""js"", ""jsx"", ""json"", ""node""],
++  snapshotSerializers: [""enzyme-to-json/serializer""],
++  setupFilesAfterEnv: [""<rootDir>/setupTests.ts""],
++  testEnvironment: ""jsdom"",
++  moduleNameMapper: {
++    "".+\\.(svg|png|jpg|css)$"": ""identity-obj-proxy"",
++    ""selenium/javascript/grid-ui/(.*)"": ""<rootDir>/$1""
++  }
++}","We don't need this file, we can use the one that is in the grid-ui directory",Why is this needed?
+1424,"@@ -48,6 +48,10 @@ public class BazelIgnoreParser {
+ 
+     try {
+       for (String path : FileOperationProvider.getInstance().readAllLines(bazelIgnoreFile)) {
++        if (!isEmptyLine(path)) {
++          continue;
++        }
++
+         if (path.endsWith(""/"")) {
+           // .bazelignore allows the ""/"" path suffix, but WorkspacePath doesn't.
+           path = path.substring(0, path.length() - 1);",FYI: inlined this method in the internal review.,Why is this needed?
+1425,"@@ -17,10 +17,8 @@ import org.junit.Test;
+ import org.junit.runner.RunWith;
+ 
+ import java.util.ArrayList;
+-import java.util.Arrays;
+ import java.util.Date;
+ import java.util.List;
+-import java.util.concurrent.CountDownLatch;
+ import java.util.concurrent.TimeUnit;
+ 
+ import de.danoeh.antennapod.core.feed.Feed;","Werid, the checksum between this file and the one on branch `develop` is the same not sure why it's showing a diff",Why was this remove
+1426,"@@ -47,7 +47,7 @@ namespace OpenTelemetry.Exporter
+             foreach (var metric in exporter.Metrics)
+             {
+                 var builder = new PrometheusMetricBuilder()
+-                    .WithName(metric.Name)
++                    .WithName(metric.Meter.Name + metric.Name)
+                     .WithDescription(metric.Description);
+ 
+                 switch (metric.MetricType)","Prometheus doesn't have concept of Meter (like OTLP does).. Trying to see if this is a good approach to use the meter name as namespace, to avoid name collisions, when same instrument name is used across multiple instruments, from different Meter.",Shouldn't this be `
+1427,"@@ -78,10 +78,17 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+ 
++        $config = $this->getConfig();
++        $allowConnectingCards = !empty(
++            $config->Catalog
++                ->auth_based_library_cards
++        ) &&
++            ($this->getAuthManager()->getAuthMethod() == 'Shibboleth');
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'allowConnectingCards' => $allowConnectingCards,
+             ]
+         );
+     }","The formatting of this is a bit strange; I'd suggest collapsing this back to a single line, and moving the `&&` to the beginning of the second line to meet the line length restriction.",Why do we need this
+1428,"@@ -1791,7 +1791,7 @@ create_and_initialize_module_data(app_pc start, app_pc end, app_pc entry_point,
+             copy->segments[i].end = os_segments[i].end;
+             copy->segments[i].prot = os_segments[i].prot;
+         }
+-    } else
++    } else if (segments != NULL)
+         memcpy(copy->segments, segments, num_segments*sizeof(module_segment_data_t));
+     copy->timestamp = timestamp;
+ # ifdef MACOS","One or the other should be non-NULL. If segments is NULL, the alloc above will have size zero, which we do not allow (there's no header): it should assert in debug build. So there should be asserts that one is non-NULL at the top, and if there really needs to be some kind of defensive check down here, it should cover the alloc too.",`if (segments != NULL) {`
+1429,"@@ -106,7 +106,11 @@ class User < ActiveRecord::Base
+ 
+   def self.from_oauth_hash(auth_hash)
+     user_data = auth_hash.extra.raw_info.to_hash
+-    self.find_or_create_by(email_address: user_data['email'])
++    user = self.for_email(user_data['email'])
++    if user_data['first_name'].present? && user_data['last_name'].present?
++      user.update_attributes(first_name: user_data['first_name'], last_name: user_data['last_name'])
++    end
++    user
+   end
+ 
+   def role_on(proposal)",I'm surprised rubocop isn't picking up singe quotes?,Why do we need to check f
+1430,"@@ -251,14 +251,7 @@ import (
+ var _ time.Duration
+ var _ strings.Reader
+ var _ aws.Config
+-
+-func parseTime(layout, value string) *time.Time {
+-	t, err := time.Parse(layout, value)
+-	if err != nil {
+-		panic(err)
+-	}
+-	return &t
+-}
++var _, _ = protocol.ParseTime(""unixTimestamp"", ""2016-09-27T15:50Z"")
+ 
+ `))
+ ",Is this line still needed?,Why is this needed?
+1431,"@@ -153,10 +153,8 @@ bool EDPSimple::createSEDPEndpoints()
+         watt.endpoint.multicastLocatorList = this->mp_PDP->getLocalParticipantProxyData()->m_metatrafficMulticastLocatorList;
+         //watt.endpoint.remoteLocatorList = m_discovery.initialPeersList;
+         watt.endpoint.durabilityKind = TRANSIENT_LOCAL;
+-        watt.times.nackResponseDelay.seconds = 0;
+-        watt.times.nackResponseDelay.fraction = 0;
+-        watt.times.initialHeartbeatDelay.seconds = 0;
+-        watt.times.initialHeartbeatDelay.fraction = 0;
++        watt.times.heartbeatPeriod.seconds = 1;
++        watt.times.heartbeatPeriod.fraction = 0;
+         if(mp_RTPSParticipant->getRTPSParticipantAttributes().throughputController.bytesPerPeriod != UINT32_MAX &&
+                 mp_RTPSParticipant->getRTPSParticipantAttributes().throughputController.periodMillisecs != 0)
+             watt.mode = ASYNCHRONOUS_WRITER;","Maybe use specific values for all the watt.times fields? Even better, have a const for it at the top of the file?",Why did you change this?
+1432,"@@ -21,9 +21,10 @@ import inputCore
+ 
+ #: The directory in which liblouis braille tables are located.
+ TABLES_DIR = r""louis\tables""
++PATTERNS_TABLE = os.path.join(TABLES_DIR, ""braille-patterns.cti"")
+ 
+-#: The table file names and information.
+-TABLES = (
++#: The braille table file names and information.
++tables = [
+ 	# (fileName, displayName, supportsInput),
+ 	# Translators: The name of a braille table displayed in the
+ 	# braille settings dialog.","nit: UNICODE_BRAILLE_TABLE or something might be a better name for this. IMO, braille-patterns.cti is a terrible name. This table allows Unicode braille characters to be used anywhere to produce raw dots.","This should be `os.path.join(TABLES_DIR, ""braille-patterns.cti"")`"
+1433,"@@ -104,9 +104,6 @@ type Builder struct {
+ 
+ 	// MachineNetwork is the subnet to use for the cluster's machine network.
+ 	MachineNetwork string
+-
+-	// SkipMachinePoolGeneration is set to skip generating MachinePool objects
+-	SkipMachinePoolGeneration bool
+ }
+ 
+ // Validate ensures that the builder's fields are logically configured and usable to generate the cluster resources.",Why are we removing the option to skip machine pool generation?,Why is this being removed?
+1434,"@@ -0,0 +1,9 @@
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpStartLineHandler
++    {
++        void OnStartLine(HttpMethod method, HttpVersion version, Span<byte> target, Span<byte> path, Span<byte> query, Span<byte> customMethod);
++    }
++}","""Request line"" here too.",Why do we need this?
+1435,"@@ -1292,6 +1292,19 @@ void Corpse::LootItem(Client *client, const EQApplicationPacket *app)
+ 		std::vector<EQ::Any> args;
+ 		args.push_back(inst);
+ 		args.push_back(this);
++		if (RuleB(Zone, UseZoneController)) {
++			if (entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)){
++				if (parse->EventNPC(EVENT_LOOT_ZONE, entity_list.GetNPCByNPCTypeID(ZONE_CONTROLLER_NPC_ID)->CastToNPC(), client, buf, 0, &args) != 0) {
++					lootitem->auto_loot = -1;
++					client->MessageString(Chat::Red, LOOT_NOT_ALLOWED, inst->GetItem()->Name);
++					client->QueuePacket(app);
++					delete inst;
++					return;
++				}
++			}
++		}
++		
++		
+ 		if (parse->EventPlayer(EVENT_LOOT, client, buf, 0, &args) != 0) {
+ 			lootitem->auto_loot = -1;
+ 			client->MessageString(Chat::Red, LOOT_NOT_ALLOWED, inst->GetItem()->Name);",Please remove this.,Why do you need this check?
+1436,"@@ -15,6 +15,7 @@ class Organization::Affiliated < Organization::AccountFacts
+     accounts = @organization.accounts.joins([:person, :positions])
+     accounts = accounts.group('accounts.id, people.kudo_position').order('kudo_position nulls last')
+     accounts.paginate(per_page: limit, page: page)
++    Account.paginate_by_sql(accounts.to_sql, per_page: limit, page: page)
+   end
+ 
+   def projects(page = 1, limit = 10)","Weird bug. Combining those joins and group calls was triggering AREL to generate the sql cache inside of will_paginate before the final call. This is a harmless workaround, but hints that will_paginate might becoming seriously deprecated.","def accounts(page = 1, limit = 10)"
+1437,"@@ -75,6 +75,12 @@ class Analysis < ActiveRecord::Base
+     end.compact.join(' AND ')
+   end
+ 
++  def allowed_tuples
++    [].tap do |tuples|
++      analysis_sloc_sets.each { |analysis_sloc_set| tuples << analysis_sloc_set.allowed_tuples }
++    end.compact.join(' AND ')
++  end
++
+   def angle
+     (Math.atan(hotness_score) * 180 / Math::PI).round(3)
+   end",This can be simplified as discussed before.,Layout/EmptyLinesAroundClassBody: 
+1438,"@@ -1,7 +1,14 @@
+ package execute
+ 
+-import ""github.com/influxdata/flux""
++import (
++	""github.com/influxdata/flux""
++	""github.com/influxdata/flux/execute/table""
++)
+ 
+ func NewProcessMsg(tbl flux.Table) ProcessMsg {
+ 	return &processMsg{table: tbl}
+ }
++
++func NewProcessChunkMsg(chunk table.Chunk) ProcessChunkMsg {
++	return &processChunkMsg{chunk: chunk}
++}",Does `internal` or `test` in the file name actually do anything here? Or is that just to show these functions are only for tests?,Why do we need this?
+1439,"@@ -12,7 +12,7 @@ describe('Transaction deserialization', function() {
+     vectors_valid.forEach(function(vector) {
+       if (vector.length > 1) {
+         var hexa = vector[1];
+-        Transaction(hexa).serialize().should.equal(hexa);
++        Transaction(hexa).serialize(true).should.equal(hexa);
+         index++;
+       }
+     });",does this boolean indicate unsafe serialization?,Why is this change needed?
+1440,"@@ -332,6 +332,13 @@ class Realm {
+      */
+     static deleteFile(config) {}
+ 
++    /**
++     * Copy bundled Realm files to app's default file folder.
++     * This is not implemented for node.js.
++     * @throws {Error} If an I/O error occured or method is not implemented.
++     */
++    static copyBundledRealmFiles() {}
++
+     /**
+      * Get a list of subscriptions. THIS METHOD IS IN BETA AND MAY CHANGE IN FUTURE VERSIONS.
+      * @param {string} name - Optional parameter to query for either a specific name or pattern (using",Maybe rewrite to `Is only implemented for React Native`? (I assume that is the case).,Why do we need this?
+1441,"@@ -246,8 +246,15 @@ public abstract class PageStreamingConfig {
+     if (pageSizeField == null) {
+       // TODO: Conform to design doc spec, once approved, for using non-standard paging fields
+       //       (such as max_results for page_size)
+-      if (language == TargetLanguage.JAVA && transportProtocol == TransportProtocol.HTTP) {
+-        pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++      if (transportProtocol == TransportProtocol.HTTP) {
++        if (language == TargetLanguage.JAVA) {
++          pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++        } else if (language == TargetLanguage.PHP) {
++          FieldModel resourcesField = ProtoPageStreamingTransformer.getResourcesField(methodModel);
++          if (resourcesField != null && !resourcesField.isMap()) {
++            pageSizeField = methodModel.getInputField(pagingParams.getNameForMaxResults());
++          }
++        }
+       }
+     }
+     ProtoField responseTokenField =",Do we not need this in Java because Java *is* handling map responses?,Why do we need to ch
+1442,"@@ -279,6 +279,14 @@ class Task(object):
+                 except BaseException:
+                     logger.exception(""Error in event callback for %r"", event)
+ 
++    @property
++    def accepted_messages(self):
++        """"""
++        Configures which scheduler messages can be received and returns them. When falsy, this tasks
++        does not accept any message. When True, all messages are accepted.
++        """"""
++        return False
++
+     @property
+     def task_module(self):
+         ''' Returns what Python module to import to get access to this class. '''","Maybe ""For configuring which scheduler messages can be received.""?",I don't think this i
+1443,"@@ -141,7 +141,7 @@ class SyncThumbsCommand extends BaseCommand
+             }
+ 
+             //clear entity manager for saving memory
+-            $this->getMediaManager()->getEntityManager()->clear();
++            $this->getMediaManager()->getObjectManager()->clear();
+ 
+             if ($batchesLimit > 0 && $batchCounter == $batchesLimit) {
+                 break;","It will stop working with orm, so this is not a good fix, Try using some method in a common interface",This should be rever
+1444,"@@ -40,7 +40,11 @@ namespace OpenTelemetry.Collector.Dependencies
+         {
+             this.diagnosticSourceSubscriber = new DiagnosticSourceSubscriber(
+                 new Dictionary<string, Func<ITracer, Func<HttpRequestMessage, ISampler>, ListenerHandler>>()
+-                { { ""HttpHandlerDiagnosticListener"", (t, s) => new HttpHandlerDiagnosticListener(t, s) } },
++                {
++                    { ""HttpHandlerDiagnosticListener"", (t, s) => new HttpHandlerDiagnosticListener(t, s) },
++                    { ""Azure.Clients"", (t, s) => new AzureSdkDiagnosticListener(""Azure.Clients"", t, sampler) },
++                    { ""Azure.Pipeline"", (t, s) => new AzureSdkDiagnosticListener(""Azure.Pipeline"", t, sampler) },
++                },
+                 tracer,
+                 x =>
+                 {",`s` is not necessarily the same as `sampler` - sampler could be null and this crazy lambda underneath falls back to something. So please use `s`,Why do we need this?
+1445,"@@ -83,9 +83,14 @@ public class PojoOperationGenerator extends AbstractOperationGenerator {
+     bodyModel = new ModelImpl();
+     bodyModel.setType(ModelImpl.OBJECT);
+     for (ParameterGenerator parameterGenerator : bodyFields) {
+-      SwaggerUtils.addDefinitions(swagger, parameterGenerator.getGenericType());
++      parameterGenerator.setHttpParameterType(HttpParameterType.BODY);
++      scanMethodParameter(parameterGenerator);
++
+       Property property = ModelConverters.getInstance().readAsProperty(parameterGenerator.getGenericType());
++      property.setDescription(parameterGenerator.getGeneratedParameter().getDescription());
+       bodyModel.addProperty(parameterGenerator.getParameterName(), property);
++
++      parameterGenerator.setHttpParameterType(null);
+     }
+     swagger.addDefinition(simpleRef, bodyModel);
+ ",This code is a bit confusing. Should HttpParameterType set to the original one or it is always BODY?,Why is this needed?
+1446,"@@ -741,7 +741,7 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
+ 			return nil, nil, err
+ 		}
+ 		log.Debug(""Completed remote build action for %s"", target)
+-		if err := c.verifyActionResult(target, command, digest, response.Result, false, isTest); err != nil {
++		if err := c.verifyActionResult(target, command, digest, response.Result, c.state.Config.Remote.VerifyOutputs && !isTest, isTest); err != nil {
+ 			return metadata, response.Result, err
+ 		}
+ 		c.locallyCacheResults(target, digest, metadata, response.Result)",Why did this change?,Why is this change n
+1447,"@@ -55,11 +55,14 @@ func (c *client) DescribeTable(ctx context.Context, region string, tableName str
+ 
+ 	globalSecondaryIndexes := getGlobalSecondaryIndexes(result.Table.GlobalSecondaryIndexes)
+ 
++	status := newProtoForTableStatus(result.Table.TableStatus)
++
+ 	ret := &dynamodbv1.Table{
+ 		Name:                   aws.ToString(result.Table.TableName),
+ 		Region:                 region,
+ 		GlobalSecondaryIndexes: globalSecondaryIndexes,
+ 		ProvisionedThroughput:  currentCapacity,
++		Status:                 status,
+ 	}
+ 	return ret, nil
+ }",nit: `status` collides with imported package named `status`,I think this should 
+1448,"@@ -584,6 +584,14 @@ func (l *Ledger) trackerEvalVerified(blk bookkeeping.Block, accUpdatesLedger led
+ 	return eval(context.Background(), accUpdatesLedger, blk, false, nil, nil)
+ }
+ 
++// IsWritingCatchpointFile returns true when a catchpoint file is being generated. The function is used by the catchup service so
++// that the memory pressure could be decreased until the catchpoint file writing is complete.
++func (l *Ledger) IsWritingCatchpointFile() bool {
++	l.trackerMu.RLock()
++	defer l.trackerMu.RUnlock()
++	return l.accts.IsWritingCatchpointFile()
++}
++
+ // A txlease is a transaction (sender, lease) pair which uniquely specifies a
+ // transaction lease.
+ type txlease struct {","""memory pressure could be decreased"" --> ""to avoid memory pressure""",I'm not sure if this is the right place for this function. I think it should be in the `accts` package.
+1449,"@@ -426,8 +426,11 @@ class TestTimescaleListenStore(DatabaseTestCase):
+         self.assertEqual(count + 1, int(cache.get(user_key, decode=False) or 0))
+ 
+     def test_delete_listens(self):
+-        self._create_test_data(self.testuser_name)
+-        listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=self.testuser_name, to_ts=1400000300)
++        uid = random.randint(2000, 1 << 31)
++        testuser = db_user.get_or_create(uid, ""user_%d"" % uid)
++        testuser_name = testuser['musicbrainz_id']
++        self._create_test_data(testuser_name)
++        listens, min_ts, max_ts = self.logstore.fetch_listens(user_name=testuser_name, to_ts=1400000300)
+         self.assertEqual(len(listens), 5)
+         self.assertEqual(listens[0].ts_since_epoch, 1400000200)
+         self.assertEqual(listens[1].ts_since_epoch, 1400000150)",I think it would make sense to fetch the cache values after deleting the listens and making sure they are what we expect.,Why do we need to create a new user?
+1450,"@@ -169,6 +169,11 @@ export class CollapsibleColumns extends BasePlugin {
+         });
+ 
+       } else if (Array.isArray(collapsibleColumns)) {
++
++        this.headerStateManager.mapState(() => {
++          return { collapsible: false };
++        });
++
+         this.headerStateManager.mergeStateWith(collapsibleColumns);
+       }
+     }",I'm thinking about covering this change with the test. Can you do that?,Why do we need this?
+1451,"@@ -41,7 +41,7 @@ var (
+ 
+ // NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
+ type NATProviderPinger interface {
+-	PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
++	PingProvider(ip string, cPorts, pPorts []int, proxyPort int) (*net.UDPConn, error)
+ }
+ 
+ // NATPinger is responsible for pinging nat holes",Not sure if it's a good idea to remove stop channel. If user cancels connection how will you stop pinger?,"nit: `cPorts, pPorts []int, proxyPort int`"
+1452,"@@ -373,7 +373,13 @@ func (dg *dockerGoClient) pullImage(image string, authData *apicontainer.Registr
+ 		return CannotGetDockerClientError{version: dg.version, err: err}
+ 	}
+ 
+-	authConfig, err := dg.getAuthdata(image, authData)
++	sdkAuthConfig, err := dg.getAuthdata(image, authData)
++	authConfig := docker.AuthConfiguration{
++		Username:      sdkAuthConfig.Username,
++		Password:      sdkAuthConfig.Password,
++		Email:         sdkAuthConfig.Email,
++		ServerAddress: sdkAuthConfig.ServerAddress,
++	}
+ 	if err != nil {
+ 		return wrapPullErrorAsNamedError(err)
+ 	}",Could you please add a `TODO` here that we won't need `docker.AuthConfiguration` anymore when we migrate to SDK's pull image?,Why do we need this?
+1453,"@@ -31,6 +31,8 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
+ 
+         public string BlobNamePrefix { get; set; }
+ 
++        public ITaskItem[] BlobNames { get; set; }
++        
+         public override bool Execute()
+         {
+             return ExecuteAsync().GetAwaiter().GetResult();",Is there a scenario were we want to get an arbitrary set of blobs that don't share a common root?,public ITaskItem[] B
+1454,"@@ -22,5 +22,7 @@ describe('Client Side Encryption', function() {
+     return testContext.setup(this.configuration);
+   });
+ 
+-  generateTopologyTests(testSuites, testContext);
++  generateTopologyTests(testSuites, testContext, spec => {
++    return !spec.description.match(/type=regex/);
++  });
+ });",Can you leave a note about why we are skipping regex tests?,Why is this needed?
+1455,"@@ -55,10 +55,15 @@ var initCmd = &cmds.Command{
+ 		if err != nil {
+ 			return err
+ 		}
+-		rep, err := repo.CreateRepo(repoDir, newConfig)
++
++		if err := repo.InitFSRepo(repoDir, newConfig); err != nil {
++			return err
++		}
++		rep, err := repo.OpenFSRepo(repoDir)
+ 		if err != nil {
+ 			return err
+ 		}
++
+ 		// The only error Close can return is that the repo has already been closed
+ 		defer rep.Close() // nolint: errcheck
+ ","This was the only caller of CreateRepo, so I inlined it.",Why do we need to do
+1456,"@@ -109,6 +109,8 @@ type VaultAuth struct {
+ 	TokenSecretRef SecretKeySelector `json:""tokenSecretRef,omitempty""`
+ 	// This Secret contains a AppRole and Secret
+ 	AppRole VaultAppRole `json:""appRole,omitempty""`
++	// Where the authentication path is mounted in Vault.
++	AuthPath string `json:""authPath,omitempty""`
+ }
+ 
+ type VaultAppRole struct {","As this is already a child of `auth`, I think we can shorten this to `path`",Why is this a pointer?
+1457,"@@ -297,6 +297,14 @@ class UIATextInfo(textInfos.TextInfo):
+ 		elif position==textInfos.POSITION_LAST:
+ 			self._rangeObj=self.obj.UIATextPattern.documentRange
+ 			self.collapse(True)
++		elif position in (textInfos.POSITION_FIRSTVISIBLE, textInfos.POSITION_LASTVISIBLE):
++			try:
++				visiRanges = self.obj.UIATextPattern.GetVisibleRanges()
++				element = 0 if position == textInfos.POSITION_FIRSTVISIBLE else visiRanges.length - 1
++				self._rangeObj = visiRanges.GetElement(0)
++			except COMError:
++				# Error: FIRST_VISIBLE position not supported by the UIA text pattern.
++				raise NotImplementedError
+ 		elif position==textInfos.POSITION_ALL or position==self.obj:
+ 			self._rangeObj=self.obj.UIATextPattern.documentRange
+ 		elif isinstance(position,UIA) or isinstance(position,UIAHandler.IUIAutomationElement):","This call should use element, not 0 I think.",`element` is not used
+1458,"@@ -223,6 +223,8 @@ type Options struct {
+ 	ChunkSize                   fs.SizeSuffix        `config:""chunk_size""`
+ 	NoChunk                     bool                 `config:""no_chunk""`
+ 	Enc                         encoder.MultiEncoder `config:""encoding""`
++	FetchUntilEmptyPage         bool                 `config:""fetch_until_empty_page""`
++	PartialPageFetchThreshold   int                  `config:""partial_page_fetch_threshold""`
+ }
+ 
+ // Fs represents a remote swift server",This is missing the definition of `fetch_until_empty_page` - it needs to go in the config section above.,Why do we need this?
+1459,"@@ -170,8 +170,8 @@ module Selenium
+ 
+           def macosx_path
+             path = ""/Applications/Firefox.app/Contents/MacOS/firefox-bin""
+-            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(path)
+-            path = Platform.find_binary(""firefox-bin"") unless File.exist?(path)
++            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(File.expand_path(path))
++            path = Platform.find_binary(""firefox-bin"") unless File.exist?(File.expand_path?(path))
+ 
+             path
+           end",I don't think this one needs to be changed since the only previous path is already an absolute one.,I don't think we need 
+1460,"@@ -200,7 +200,7 @@ public class BaseExpireSnapshotsSparkAction
+   }
+ 
+   private Dataset<Row> buildValidFileDF(TableMetadata metadata) {
+-    Table staticTable = newStaticTable(metadata, this.table.io());
++    Table staticTable = newStaticTable(metadata, this.table.io(), table.locationProvider());
+     return appendTypeString(buildValidDataFileDF(staticTable), DATA_FILE)
+         .union(appendTypeString(buildManifestFileDF(staticTable), MANIFEST))
+         .union(appendTypeString(buildManifestListDF(staticTable), MANIFEST_LIST));",Since we kept the original constructor we might not need this change now.,nit: `this.table.locationProvider()` -> `this.table.locationProvider()`
+1461,"@@ -130,6 +130,7 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+     }
+ 
+     refreshFromMetadataLocation(metadataLocation);
++    LOG.debug(""Refreshed [{}]"", fullName);
+   }
+ 
+   @Override","There is already a log in `BaseMetastoreTableOperations` for this. It has the location, but not the table name. Maybe just add table name to that one.",public void refresh() {
+1462,"@@ -21,6 +21,8 @@ import (
+ 	""net/http""
+ 	""time""
+ 
++	""github.com/pipe-cd/pipe/pkg/filestore/minio""
++
+ 	jwtgo ""github.com/dgrijalva/jwt-go""
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""",This should be in the last group.,"""github.com/golang/glog"""
+1463,"@@ -106,6 +106,7 @@ namespace Datadog.Trace.Agent
+                     {
+                         // stop retrying
+                         Log.Error(exception, ""An error occurred while sending traces to the agent at {0}"", _tracesEndpoint);
++                        _statsd?.Send();
+                         return false;
+                     }
+ ","I believe you should either remove this or rename the PR. You can't change the behavior of the tracer (even to fix a bug) in a PR named ""unit test improvements""",Why do we need this?
+1464,"@@ -0,0 +1,8 @@
++// +k8s:deepcopy-gen=package,register
++// +k8s:conversion-gen=github.com/munnerz/cert-manager/pkg/apis/certmanager
++// +k8s:openapi-gen=true
++// +k8s:defaulter-gen=TypeMeta
++
++// Package v1alpha1 is the v1alpha1 version of the API.
++// +groupName=certmanager.k8s.io
++package v1alpha1","I've gone with this group name, however I'm open to suggestions on alternatives!",Why do we need this?
+1465,"@@ -32,6 +32,7 @@ public class RpcApis {
+   public static final RpcApi TX_POOL = new RpcApi(""TXPOOL"");
+   public static final RpcApi TRACE = new RpcApi(""TRACE"");
+   public static final RpcApi PLUGINS = new RpcApi(""PLUGINS"");
++  public static final RpcApi QUORUM = new RpcApi(""QUORUM"");
+ 
+   public static final List<RpcApi> DEFAULT_JSON_RPC_APIS = Arrays.asList(ETH, NET, WEB3);
+ ",should this be GOQUORUM,Why is this needed?
+1466,"@@ -49,7 +49,7 @@ type (
+ var cpuprofile = flag.String(""cpuprofile"", """", ""write cpu profile to file"")
+ 
+ // Validate for the byzantine node uses the actual block validator and returns the opposite
+-func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B) error {
++func (v *byzVal) Validate(blk *blockchain.Block, tipHeight uint64, tipHash hash.Hash32B, checkCoinbase bool) error {
+ 	//err := v.val.Validate(blk, tipHeight, tipHash)
+ 	//if err != nil {
+ 	//	return nil","I think checkCoinbase is not skipping checking coinbase. Instead, true-> checking num(coinbase tx) = 1, false -> checking num(coinbase tx) = 0.",`checkCoinbase` is n
+1467,"@@ -24,14 +24,13 @@ import (
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/db""
+ 	""github.com/iotexproject/iotex-core/state""
+-	""github.com/iotexproject/iotex-core/state/factory""
+ 	""github.com/iotexproject/iotex-core/test/identityset""
+ 	""github.com/iotexproject/iotex-core/test/mock/mock_chainmanager""
+ 	""github.com/iotexproject/iotex-election/test/mock/mock_committee""
+ 	""github.com/iotexproject/iotex-election/types""
+ )
+ 
+-func initConstruct(t *testing.T) (Protocol, context.Context, factory.WorkingSet, *types.ElectionResult) {
++func initConstruct(t *testing.T) (Protocol, context.Context, protocol.StateManager, *types.ElectionResult) {
+ 	require := require.New(t)
+ 	ctrl := gomock.NewController(t)
+ 	defer ctrl.Finish()","same here, move it out",func `initConstruct`
+1468,"@@ -42,11 +42,17 @@
+ //@HEADER
+ */
+ 
++#ifndef KOKKOS_TOOLS_INDEPENDENT_BUILD
+ #include <Kokkos_Macros.hpp>
+ #include <Kokkos_Tuners.hpp>
++#endif
++
+ #include <impl/Kokkos_Profiling.hpp>
+-#if defined(KOKKOS_ENABLE_LIBDL)
++#include <impl/Kokkos_Profiling_Interface.hpp>
++
++#if defined(KOKKOS_ENABLE_LIBDL) || defined(KOKKOS_TOOLS_INDEPENDENT_BUILD)
+ #include <dlfcn.h>
++#define KOKKOS_TOOLS_ENABLE_LIBDL
+ #endif
+ 
+ #include <algorithm>",Can you elaborate on why you need different behavior depending on Tools being built independently or not?,Why is this needed?
+1469,"@@ -18,7 +18,8 @@ class AnnotationsController < ApplicationController
+     guid_save = guidance.present? ? guidance.save : true
+ 
+     if ex_save && guid_save
+-      redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: _('Information was successfully created.')
++      typ = (!ex_save && !guid_save ? 'example answer and guidance' : (!guid_save ? 'guidance' : 'example answer'))
++      redirect_to admin_show_phase_path(id: @question.section.phase_id, section_id: @question.section_id, question_id: @question.id, edit: 'true'), notice: success_message(typ, _('created'))
+     else
+       @section = @question.section
+       @phase = @section.phase","because of the above if statement will requires both ex_save and guid_save to be true, this code will always return 'example answer'. This should be revised with `example_answer.present?` and `guidance.present?`",Use the return of t
+1470,"@@ -5,6 +5,7 @@ import (
+ 	""testing""
+ 
+ 	""github.com/stretchr/testify/assert""
++	""golang.org/x/net/context""
+ 
+ 	""github.com/sonm-io/core/insonmnia/structs""
+ 	pb ""github.com/sonm-io/core/proto""",why not context from stdlib?,"""github.com/google/"
+1471,"@@ -48,7 +48,7 @@ func GenerateCRC32(
+ 	return Checksum{
+ 		Value:   checksum,
+ 		Version: payloadVersion,
+-		Flavor:  FlavorIEEECRC32OverThriftBinary,
++		Flavor:  FlavorIEEECRC32OverProto3Binary,
+ 	}, nil
+ }
+ ",Just saw this and wasn't able to hold myself from renaming :-).,Why do we need to c
+1472,"@@ -278,9 +278,7 @@ describe('src/Core', () => {
+       plugins: {},
+       totalProgress: 0
+     })
+-    expect(core.plugins.acquirer[0].mocks.uninstall.mock.calls.length).toEqual(
+-      1
+-    )
++    expect(core.plugins[Object.keys(core.plugins)[0]].length).toEqual(0)
+   })
+ 
+   describe('upload hooks', () => {",Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too,Why was this test removed?
+1473,"@@ -109,7 +109,7 @@ module RSpec
+         def warn_if_key_taken(source, key, new_block)
+           return unless existing_block = example_block_for(source, key)
+ 
+-          Kernel.warn <<-WARNING.gsub(/^ +\|/, '')
++          RSpec.warn_with <<-WARNING.gsub(/^ +\|/, '')
+             |WARNING: Shared example group '#{key}' has been previously defined at:
+             |  #{formatted_location existing_block}
+             |...and you are now defining it at:","`warn_with` prefixes the message with `WARNING:`, right? So this will put `WARNING:` twice. It would be good to verify all the warnings look good after this change, given how easy it is to make a simple mistake like this :(.",This should be `RSpec.warn
+1474,"@@ -12,6 +12,19 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/types""
+ )
+ 
++// MessageTimeOut is the number of tipsets we should receive before timing out messages
++const MessageTimeOut = 6
++
++type timedmessage struct {
++	message *types.SignedMessage
++	addedAt uint64
++}
++
++// BlockTimer defines a interface to a struct that can give the current block height.
++type BlockTimer interface {
++	BlockHeight() (uint64, error)
++}
++
+ // MessagePool keeps an unordered, de-duplicated set of Messages and supports removal by CID.
+ // By 'de-duplicated' we mean that insertion of a message by cid that already
+ // exists is a nop. We use a MessagePool to store all messages received by this node","FYI In the message queue I use the term ""stamp"" to refer to the time-like mark associated with each message. It's opaque to the queue/pool and should make no difference if the stamps and age limit were converted to seconds. So this could then become `Stamper` with `CurrentStamp()` method, no reference to ""blocks"" or height etc. The wrapper struct could be `StampedMessage. The interpretation as block height is deferred to the user/constructor that hooks things up, the ""business logic"". This is just an observation, take or ignore as you wish.",Why do we need this?
+1475,"@@ -508,8 +508,13 @@ def remove_xml_preamble(response):
+ # --------------
+ def get_lifecycle(bucket_name):
+     bucket_name = normalize_bucket_name(bucket_name)
++    exists, code, body = is_bucket_available(bucket_name)
++    if not exists:
++        return requests_response(body, status_code=code)
++
+     lifecycle = BUCKET_LIFECYCLE.get(bucket_name)
+     status_code = 200
++
+     if not lifecycle:
+         # TODO: check if bucket actually exists
+         lifecycle = {",Can we remove the `TODO` statement here? (as this is actually fixed in this PR),I don't think we need to c
+1476,"@@ -198,6 +198,7 @@ public class Account implements BaseAccount, StoreConfig {
+     private SortType mSortType;
+     private Map<SortType, Boolean> mSortAscending = new HashMap<SortType, Boolean>();
+     private ShowPictures mShowPictures;
++    private DisplayPreference mDisplayPreference;
+     private boolean mIsSignatureBeforeQuotedText;
+     private Expunge mExpungePolicy = Expunge.EXPUNGE_IMMEDIATELY;
+     private int mMaxPushFolders;",m prefix no longer in code style,Can we rename this to `mDisplayPreference`?
+1477,"@@ -168,6 +168,10 @@ func (kvb *kvStoreWithBuffer) MustDelete(ns string, key []byte) {
+ 	kvb.buffer.Delete(ns, key, ""failed to delete %x in %s"", key, ns)
+ }
+ 
++func (kvb *kvStoreWithBuffer) Filter(ns string, c Condition) ([][]byte, [][]byte, error) {
++	return kvb.store.Filter(ns, c)
++}
++
+ func (kvb *kvStoreWithBuffer) WriteBatch(b batch.KVStoreBatch) (err error) {
+ 	b.Lock()
+ 	defer func() {",need to filter the entities in buffer as well,Why do we need this?
+1478,"@@ -12,6 +12,7 @@ import java.nio.charset.Charset;
+ import java.security.MessageDigest;
+ 
+ public class FastBlurTransformation extends BitmapTransformation {
++    private static final String ID=""de.danoeh.antennapod.core.glide.FastBlurTransformation"";
+ 
+     private static final String TAG = FastBlurTransformation.class.getSimpleName();
+ ",Please add spaces before and after the equals sign,import java.security.MessageDigest;
+1479,"@@ -49,7 +49,7 @@
+ #endif
+ #include ""common/sql.error_event.pb.h""
+ #include ""common/sql.info_event.pb.h""
+-#include ""wrapper/amqpwrapper.h""
++//#include ""wrapper/amqpwrapper.h""
+ #include ""sq_sql_eventids.h""
+ #include ""common/evl_sqlog_eventnum.h""
+ ",This file could also be cleaned up/deleted. But lets do this separately after ensuring all the event logging has been ported to the current logmxevent_traf.cpp file completely.,Please remove this line.
+1480,"@@ -7,12 +7,13 @@ module RSpec::Core::Formatters
+     it 'produces the expected full output' do
+       output = run_example_specs_with_formatter('failures')
+       expect(output).to eq(<<-EOS.gsub(/^\s+\|/, ''))
+-        |./spec/rspec/core/resources/formatter_specs.rb:4:is marked as pending but passes
+-        |./spec/rspec/core/resources/formatter_specs.rb:36:fails
+-        |./spec/rspec/core/resources/formatter_specs.rb:40:fails twice
+-        |./spec/rspec/core/resources/formatter_specs.rb:47:fails with a backtrace that has no file
+-        |./spec/rspec/core/resources/formatter_specs.rb:53:fails with a backtrace containing an erb file
+-        |./spec/rspec/core/resources/formatter_specs.rb:71:raises
++        |./spec/rspec/core/resources/formatter_specs.rb:4:Expected example to fail since it is pending, but it passed.
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:37:expected: 2 got: 1 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:41:expected: 2 got: 1 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:42:expected: 4 got: 3 (compared using ==)
++        |/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:50:foo
++        |/foo.html.erb:1:Exception
++        |./spec/rspec/core/resources/formatter_specs.rb:71:boom
+       EOS
+     end
+   end",":thinking:, the line number here is the line of the example (`example.location`), that's probably why I finally chose to display the example title because it's what can be found on this line, and saying that the error is from there is confusing. But presenting the actual failures is indeed better, so maybe we can get the failure actual line number from the exception backtrace and then output two distinct lines for failures like this one?",I think this should be `/home/roadster/dev/oss/rspec-core/spec/rspec/core/resources/formatter_specs.rb:38:expected: 2 got: 1 (compared using ==)`
+1481,"@@ -35,7 +35,7 @@ class WebDriver(ChromiumDriver):
+     def __init__(self, executable_path=""chromedriver"", port=DEFAULT_PORT,
+                  options=None, service_args=None,
+                  desired_capabilities=None, service_log_path=DEFAULT_SERVICE_LOG_PATH,
+-                 chrome_options=None, service=None, keep_alive=True):
++                 chrome_options=None, service=None, keep_alive=True, create_no_window=False):
+         """"""
+         Creates a new instance of the chrome driver.
+         Starts the service and then creates new instance of chrome driver.",We shouldn't add this as a new `kwarg` here. This should all be done on the options class,Why do we need this?
+1482,"@@ -134,6 +134,7 @@ module Beaker
+           :openstack_keyname      => ENV['OS_KEYNAME'],
+           :openstack_network      => ENV['OS_NETWORK'],
+           :openstack_region       => ENV['OS_REGION'],
++          :openstack_volume_support => ENV['OS_VOL_SUPPORT'] || true,
+           :jenkins_build_url      => nil,
+           :validate               => true,
+           :configure              => true,",Should this be `OS_VOLUME_SUPPORT` to match the symbol key names?,I think this should be `|| false`
+1483,"@@ -38,6 +38,8 @@
+ #include <flux/core.h>
+ #include ""heaptrace.h""
+ 
++static flux_msg_handler_t **handlers = NULL;
++
+ static void start_cb (flux_t *h, flux_msg_handler_t *mh,
+                       const flux_msg_t *msg, void *arg)
+ {","In C, file scope variables are already initialized to 0 so the ""= NULL"" is redundant. Not a big deal.",Why do we need this?
+1484,"@@ -2,7 +2,7 @@
+ 
+ var nodeName = node.nodeName.toUpperCase(),
+ 	nodeType = node.type,
+-	doc = document;
++	doc = axe.commons.dom.getRootNode(node);
+ 
+ if (node.getAttribute('aria-disabled') === 'true' || axe.commons.dom.findUp(node, '[aria-disabled=""true""]')) {
+ 	return false;","on line 40, the `relevantNode` can change and therefore the `doc` might change too for the lookup on line 43. I think this code should be moved to where the `doc` is actually being used",Why not use `axe.commons.dom.getRootNode`?
+1485,"@@ -57,6 +57,7 @@ namespace OpenTelemetry.Internal
+             {
+                 throw new ArgumentOutOfRangeException(
+                     nameof(milliseconds),
++                    milliseconds,
+                     string.Format(CultureInfo.InvariantCulture, ""milliseconds must be between {0} and {1}"", MinMilliseconds, MaxMilliseconds));
+             }
+ ","nit: just to be similar to others, can you change to interpolation?",nit: unnecessary change
+1486,"@@ -111,6 +111,9 @@ type ControllerOptions struct {
+ 	// CertificateRequest -> Order. Slice of string literals that are
+ 	// treated as prefixes for annotation keys.
+ 	CopiedAnnotationPrefixes []string
++
++	//Return full Certchain including root cert for k8s CSRs
++	FullCertChain bool
+ }
+ 
+ const (","Would this make more sense as an option on an Issuer resource (specifically on the CA issuer) rather than as a flag? It's not ideal that we have a flag that _looks_ like it could be 'global' but is actually not IMO. Also, if Istio is reading the CSR object, is it possible for it to read the CA from the CSR itself too and append the two instead? Not sure if we ever decided whether to use annotations for this purpose @JoshVanL?",nit: space after `//`
+1487,"@@ -10,6 +10,7 @@ class TargetType(Enum):
+     PANDAS = 'pandas'
+     FILE = 'file'
+ 
++SERVER_TIME_F = ""%Y-%m-%dT%H:%M:%S""
+ DATEF = '%F'
+ TIMEF = '%T'
+ DTIMEF = '%s %s' % (DATEF, TIMEF)","Because this acts as a coordination point between client and server, it should go in core.py instead of const.py (so eventually the server could use it to guarantee that it delivers dates in the expected format).",I don't think this is used.
+1488,"@@ -212,8 +212,11 @@ func (r *createOrUpdate) Apply(obj *unstructured.Unstructured, subresources ...s
+ 		return
+ 	}
+ 	resource, err = r.options.Getter.Get(obj.GetName(), metav1.GetOptions{})
+-	if err != nil && apierrors.IsNotFound(errors.Cause(err)) {
+-		return r.options.Creator.Create(obj, subresources...)
++	if err != nil {
++		if apierrors.IsNotFound(errors.Cause(err)) {
++			return r.options.Creator.Create(obj, subresources...)
++		}
++		return nil, err
+ 	}
+ 	return r.options.Updater.Update(resource, obj, subresources...)
+ }","expected statement, found 'else' (and 1 more errors)",Why is this change needed?
+1489,"@@ -16,6 +16,17 @@ func FakeID(b byte, public bool) ID {
+ 	return ID{bytes}
+ }
+ 
++// FakeIDRandomOrBust creates a fake public or private TLF ID from the given
++// byte, and fill the rest with empty bytes.
++func FakeIDRandomOrBust(b byte, public bool) ID {
++	id, err := MakeRandomID(public)
++	if err != nil {
++		panic(err)
++	}
++	id.id[0] = b
++	return id
++}
++
+ // FakeIDByte returns the byte used to create a fake TLF ID with
+ // FakeID.
+ func FakeIDByte(id ID) byte {",IMO this doesn't need to be in the `kbfs` repo. And I don't like setting the byte. We can always compare with the randomly generated `TlfID`.,Why panic instead of retur
+1490,"@@ -0,0 +1,7 @@
++package constants
++
++const (
++	DeviceControllerModuleName   = ""devicecontroller""
++	CloudHubControllerModuleName = ""cloudhub""
++	EdgeControllerModuleName     = ""edgecontroller""
++)",What's the difference from ModuleName in `pkg/apis/meta/v1alpha1/types.go`?,I don't think we need this
+1491,"@@ -8,11 +8,12 @@ using System;
+ using System.Collections.Generic;
+ using System.IO;
+ using System.Linq;
+-using System.Reflection.Metadata;
+-using System.Reflection.PortableExecutable;
+ using System.Text;
+ using Newtonsoft.Json.Linq;
+ using Newtonsoft.Json;
++using System.Security.Cryptography;
++using System.Reflection.PortableExecutable;
++using System.Reflection.Metadata;
+ 
+ namespace Microsoft.DotNet.Build.Tasks
+ {",We shouldn't be changing this task as we are trying to break our dependency on it and switch to using the shipped version.,Why is this needed?
+1492,"@@ -737,8 +737,10 @@ analyze_clean_call(dcontext_t *dcontext, clean_call_info_t *cci, instr_t *where,
+      * unless multiple regs are able to be skipped.
+      * XXX: This should probably be in arch-specific clean_call_opt.c.
+      */
++
+     if ((cci->num_simd_skip == 0 /* save all xmms */ &&
+-         cci->num_regs_skip == 0 /* save all regs */ &&
++        /* save all regs except 2, because XSP and XBP are commonly callee saved */
++         cci->num_regs_skip <= 2 &&
+          !cci->skip_save_flags) ||
+         always_out_of_line)
+         cci->out_of_line_swap = true;","Shouldn't we have a low bar for generating out-of-line context switch, i.e., if we need save more than n (3?) simd or m (4) gprs we should go out-of-line? And it should be || instead &&. It seems the bar is still very high after this change.",I don't understand this change. Why is it necessary?
+1493,"@@ -23,6 +23,7 @@ import (
+ 	""go.opentelemetry.io/otel/api/kv""
+ 	""go.opentelemetry.io/otel/api/metric""
+ 	""go.opentelemetry.io/otel/api/metric/registry""
++	""go.opentelemetry.io/otel/sdk/instrumentation""
+ )
+ 
+ // This file contains the forwarding implementation of metric.Provider",Should the API have a dependency on the SDK?,nit: remove empty line
+1494,"@@ -1475,7 +1475,7 @@ describe('Change Streams', function() {
+     }
+   });
+ 
+-  it('should resume piping of Change Streams when a resumable error is encountered', {
++  it.skip('should resume piping of Change Streams when a resumable error is encountered', {
+     metadata: {
+       requires: {
+         generators: true,",Is this a sometimes leaky test?,Why are we skipping this test?
+1495,"@@ -96,7 +96,11 @@ func (v ConstraintGenerator) typeof(n Node) (PolyType, error) {
+ 		ftv := n.ExternType.freeVars(nil)
+ 		subst := make(Substitution, len(ftv))
+ 		for _, tv := range ftv {
+-			subst[tv] = v.cs.f.Fresh()
++			f := v.cs.f.Fresh()
++			for ftv.contains(f) {
++				f = v.cs.f.Fresh()
++			}
++			subst[tv] = f
+ 		}
+ 		t := subst.ApplyType(n.ExternType)
+ 		// Check if this type knows about its kind constraints","It should be possible to create a test case that enter the loop. That would be a good enough test case for me. Have a look at the extern type inference test cases that already exist. Since you can just pick the type variables the extern type use, you should be able to create a conflict that requires this loop to fix.",Why is this needed?
+1496,"@@ -368,6 +368,11 @@ This initializes all modules such as audio, IAccessible, keyboard, mouse, and GU
+ 		wxLang=locale.FindLanguageInfo(lang.split('_')[0])
+ 	if hasattr(sys,'frozen'):
+ 		locale.AddCatalogLookupPathPrefix(os.path.join(os.getcwdu(),""locale""))
++	# #8064: Wx might know the language, but may not actually contain a translation database for that language.
++	# If we try to initialize this language, wx will show a warning dialog.
++	# Therefore treat this situation like wx not knowing the language at all.
++	if not locale.IsAvailable(wxLang.Language):
++		wxLang=None
+ 	if wxLang:
+ 		try:
+ 			locale.Init(wxLang.Language)",It might make sense to log this.,This should be `if wxLang is not None`
+1497,"@@ -340,12 +340,10 @@ module Blacklight
+       # too. These model names should not be `#dup`'ed or we might break ActiveModel::Naming.
+       def deep_copy
+         deep_dup.tap do |copy|
+-          copy.repository_class = self.repository_class
+-          copy.response_model = self.response_model
+-          copy.document_model = self.document_model
+-          copy.document_presenter_class = self.document_presenter_class
+-          copy.search_builder_class = self.search_builder_class
+-          copy.facet_paginator_class = self.facet_paginator_class
++          %w(repository_class response_model document_model document_presenter_class search_builder_class facet_paginator_class).each do |klass|
++            # Don't copy if nil, so as not to prematurely autoload default classes
++            copy.send(""#{klass}="", send(klass)) unless fetch(klass.to_sym, nil).nil?
++          end
+         end
+       end
+       alias_method :inheritable_copy, :deep_copy",Line is too long. [84/80],Style/RedundantSelf: Redundant self de
+1498,"@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+ 
+ 
+ class Options(object):
++    KEY = ""goog:chromeOptions""
+ 
+     def __init__(self):
+         self._binary_location = ''",nice touch since Google likes to change things every now and then.,"I think this should be `KEY = ""goog:ch"
+1499,"@@ -0,0 +1,19 @@
++# Provides a helper utility for loading branding configs.
++module Branding
++
++  module_function
++
++  # Loads branding config from YAML file.
++  #
++  # @param keys [Array<Object>] A list of the keys to return configs for.
++  #
++  # @example Return a value
++  #   Branding.fetch(:settings, :should_work) # => true
++  #   Branding.fetch(:settings, :email) # => 'user@example.com'
++  #   Branding.fetch(:settings, :missing) # => nil
++  # @return [Object] The value of the config
++  def fetch(*keys)
++    keys = keys.map(&:to_sym)
++    Rails.configuration.branding.dig(*keys)
++  end
++end",Thank you this is so much nicer than the old `Rails.configuration.branding['blah']['blah']['blah']` :),I'm not sure if this is the best way t
+1500,"@@ -29,6 +29,7 @@ class ResourceType(object):
+     FOLDER = 'folder'
+     PROJECT = 'project'
+     GROUP = 'group'
++    BACKEND_SERVICE = 'backend_service'
+     FORWARDING_RULE = 'forwarding_rule'
+     BUCKETS_ACL = 'buckets_acl'
+     CLOUDSQL_ACL = 'cloudsql_instances'",nit: Would you mind alpha-sorting this?,Why do we need this?
+1501,"@@ -55,6 +55,8 @@ public class ManifestFiles {
+    * @return a {@link ManifestReader}
+    */
+   public static ManifestReader read(ManifestFile manifest, FileIO io, Map<Integer, PartitionSpec> specsById) {
++    Preconditions.checkArgument(manifest.content() == ManifestContent.DATA,
++        ""Cannot read a delete manifest with a ManifestReader: %s"", manifest);
+     InputFile file = io.newInputFile(manifest.path());
+     InheritableMetadata inheritableMetadata = InheritableMetadataFactory.fromManifest(manifest);
+     return new ManifestReader(file, specsById, inheritableMetadata);","For my understanding, the DATA manifest & DELETE manifest could share the same read / write path so I think we could use the common reader+writer. Is there any other reason that we need to make them separate paths ?",nit: `Preconditions.
+1502,"@@ -4,7 +4,7 @@
+   plan_title = @plan.title
+   user_name = @plan.owner.name
+   helpdesk_email = Rails.configuration.branding[:organisation][:helpdesk_email]
+-  contact_us_url = Rails.configuration.branding[:organisation][:contact_us_url]
++  contact_us = Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url
+   email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
+ %>
+ <% FastGettext.with_locale FastGettext.default_locale do %>",that change should be sufficient for avoiding the override of contact_us_url helper. The one defined at the .yml it is within a hash so no problem should arise.,I think this should 
+1503,"@@ -56,7 +56,7 @@ return [
+         'choose_file' => 'Datei auswählen',
+         'close' => 'Schließen',
+         'create' => 'Erstellen',
+-        'create_and_add_another' => 'Erstellen und weitere hinzufügen',
++        'create_and_add_another' => 'Erstellen und weiteres Element hinzufügen',
+         'create_and_continue' => 'Erstellen und weiter bearbeiten',
+         'save' => 'Speichern',
+         'save_and_continue' => 'Speichern und weiter bearbeiten',","We actually had a discussion about this exactly in #3470, some languages seem to go for one, some for the other  ",I don't think this s
+1504,"@@ -50,6 +50,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+ 
+   public abstract List<LongRunningOperationDetailView> longRunningDescriptors();
+ 
++  public abstract List<GrpcStreamingDetailView> grpcStreamingDescriptors();
++
+   public abstract List<String> methodKeys();
+ 
+   public abstract String clientConfigPath();",Is PHP the first dynamic MVVM language with grpc streaming support?,public abstract List<LongRunningOperationDetailView> longRunningDescriptors();
+1505,"@@ -41,6 +41,7 @@ SmilesMolSupplier::SmilesMolSupplier(const std::string &fileName,
+   if (!tmpStream || (!(*tmpStream)) || (tmpStream->bad())) {
+     std::ostringstream errout;
+     errout << ""Bad input file "" << fileName;
++    if (tmpStream) { delete tmpStream; }
+     throw BadFileException(errout.str());
+   }
+   dp_inStream = static_cast<std::istream *>(tmpStream);",the `if` isn't necessary here; it's safe to call `delete` on `nullptr`,Why is this needed?
+1506,"@@ -156,6 +156,12 @@ ReturnCode_t DataWriter::assert_liveliness()
+     return impl_->assert_liveliness();
+ }
+ 
++bool DataWriter::remove_all_changes(
++        size_t* removed)
++{
++    return impl_->remove_all_changes(removed);
++}
++
+ } // namespace dds
+ } // namespace fastdds
+ } // namespace eprosima",Change if the method's name finally changes to `clear_history` as proposed elsewhere,Why is this needed?
+1507,"@@ -34,9 +34,8 @@ def showHelp(helpId: str):
+ 		noHelpMessage = _(""No help available here."")
+ 		queueHandler.queueFunction(queueHandler.eventQueue, ui.message, noHelpMessage)
+ 		return
+-
+-	import gui
+-	helpFile = gui.getDocFilePath(""userGuide.html"")
++	import documentationUtils
++	helpFile = documentationUtils.getDocFilePath(""userGuide.html"")
+ 	if helpFile is None:
+ 		# Translators: Message shown when trying to display context sensitive help,
+ 		# indicating that	the user guide could not be found.",can this one also be moved to the top of the file?,I think this import should be at the top of the file.
+1508,"@@ -26,6 +26,8 @@ type AppliedToGroup struct {
+ 	metav1.ObjectMeta
+ 	// Pods is a list of Pods selected by this group.
+ 	Pods []GroupMemberPod
++	// GroupMembers is a list of resources selected by this group.
++	GroupMembers []GroupMember
+ }
+ 
+ // PodReference represents a Pod Reference.","So if I understand this correctly the externalEntities should be computed and stored in GroupMember, while current code usage of GroupMemberPod will be migrated to GroupMember later?",Why do we need this?
+1509,"@@ -1,13 +1,9 @@
+-using System;
+-using System.Collections.Generic;
+-
+-namespace Datadog.Tracer
++namespace Datadog.Tracer
+ {
+     public static class Tags
+     {
+-        public const string Service = ""Datadog.Service"";
+-        public const string Resource = ""Datadog.Resource"";
+-        public const string Error = ""Datadog.Error"";
+-        public const string Type = ""Datadog.Type"";
++        public const string ServiceName = ""service.name"";
++        public const string ResourceName = ""resource.name"";
++        public const string SpanType = ""span.type"";
+     }
+ }",Don't we have tests to change after this breaking change? probably we're not using hard coded strings in our tests when we create a `Span`?,Why are these public
+1510,"@@ -19,7 +19,7 @@ REPORT_FREQUENCY = 5000
+ SUBSCRIBER_NAME = ""bq""
+ KEYSPACE_NAME_INCOMING = ""ilisten""
+ KEYSPACE_NAME_UNIQUE = ""ulisten""
+-APP_CREDENTIALS_FILE = ""bigquery-credentials.json""
++APP_CREDENTIALS_FILE = os.environ['GOOGLE_APPLICATION_CREDENTIALS']
+ 
+ # TODO: 
+ #   Big query hardcoded data set ids",will this fail if the env variable doesn't exist? Is this the preferred behaviour?,Why not just use `GO
+1511,"@@ -325,8 +325,9 @@ class SpatialPooler(object):
+ 
+     # Initialize a tiny random tie breaker. This is used to determine winning
+     # columns where the overlaps are identical.
+-    self._tieBreaker = 0.01*numpy.array([self._random.getReal64() for i in
+-                                        xrange(self._numColumns)])
++    self._tieBreaker = numpy.array([0.01 * self._random.getReal64() for i in
++                                      xrange(self._numColumns)],
++                                    dtype=realDType)
+ 
+     # 'self._connectedSynapses' is a similar matrix to 'self._permanences'
+     # (rows represent cortical columns, columns represent input bits) whose",bad line wrap,I think this should 
+1512,"@@ -1245,6 +1245,14 @@ void rai::bootstrap_server::receive_header_action (boost::system::error_code con
+ 					});
+ 					break;
+ 				}
++				case rai::message_type::bulk_pull_blocks:
++				{
++					auto this_l (shared_from_this ());
++					boost::asio::async_read (*socket, boost::asio::buffer (receive_buffer.data () + 8, sizeof (rai::uint256_union) + sizeof (rai::uint256_union) + sizeof (bulk_pull_blocks_mode) + sizeof (uint32_t)), [this_l](boost::system::error_code const & ec, size_t size_a) {
++						this_l->receive_bulk_pull_blocks_action (ec, size_a);
++					});
++					break;
++				}
+ 				case rai::message_type::frontier_req:
+ 				{
+ 					auto this_l (shared_from_this ());",What does the `8` here represent? Can you give it a name?,`sizeof (bulk_pull_blocks_mode) + sizeof (uint32_t)`
+1513,"@@ -0,0 +1,12 @@
++from pymatgen.ext.matproj import MPRester, TaskType
++import os
++material_ids = [""mp-32800"", ""mp-23494""]
++task_types = [TaskType.GGA_OPT, TaskType.GGA_UNIFORM]
++file_patterns = [""vasprun*"", ""OUTCAR*""]
++with MPRester(os.environ[""MP_API_KEY""]) as mpr:
++    meta, urls = mpr.get_download_info(
++        material_ids, task_types=task_types, file_patterns=file_patterns
++    )
++
++print(meta)
++print(urls)","`MPRester(os.environ[""MP_API_KEY""])` can be left simply as `MPRester()` and it will pick up the API key from the environment. What is the purpose of this file otherwise? Is it better suited for `dev_scripts`, or a test?",This file should be removed.
+1514,"@@ -11,7 +11,7 @@
+ #
+ # It's strongly recommended to check this file into your version control system.
+ 
+-ActiveRecord::Schema.define(:version => 20121114193521) do
++ActiveRecord::Schema.define(:version => 20121212214215) do
+ 
+   create_table ""announcements"", :force => true do |t|
+     t.datetime ""created_at"",        :null => false",Looks like there may be more changes to this file than intended?,Use the new Ruby 1.9 hash syntax.
+1515,"@@ -117,7 +117,7 @@ func (eb *eventbus) pubCloudMsgToEdge() {
+ 			body, ok := accessInfo.GetContent().(map[string]interface{})
+ 			if !ok {
+ 				klog.Errorf(""Message is not map type"")
+-				return
++				continue
+ 			}
+ 			message := body[""message""].(map[string]interface{})
+ 			topic := message[""topic""].(string)","when message type is not expected, contine to next loop instead of return to finish infinite loop",Why is this change needed?
+1516,"@@ -2,6 +2,13 @@ package cmd
+ 
+ import (
+ 	""fmt""
++	""os""
++	osexec ""os/exec""
++	""path/filepath""
++	""strings""
++	""testing""
++	""time""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.,nit: this should be grouped with other stdlib imports
+1517,"@@ -84,6 +84,10 @@ func (r *AWSMachine) ValidateUpdate(old runtime.Object) error {
+ 	delete(oldAWSMachineSpec, ""providerID"")
+ 	delete(newAWSMachineSpec, ""providerID"")
+ 
++	// allow changes to instanceID
++	delete(oldAWSMachineSpec, ""instanceID"")
++	delete(newAWSMachineSpec, ""instanceID"")
++
+ 	// allow changes to additionalTags
+ 	delete(oldAWSMachineSpec, ""additionalTags"")
+ 	delete(newAWSMachineSpec, ""additionalTags"")",instanceID should stay the same for a AWSMachine?,Why is this needed?
+1518,"@@ -77,6 +77,7 @@ def _launch_local_catalog():
+     env = dict(REGISTRY_URL=""http://localhost:5000"",
+                S3_PROXY_URL=open_config[""s3Proxy""],
+                ALWAYS_REQUIRE_AUTH=""false"",
++               NO_DOWNLOAD=""false"",
+                CATALOG_MODE=""LOCAL"",
+                SSO_AUTH=""DISABLED"",
+                PASSWORD_AUTH=""ENABLED"",",Since this is a dict don't you want `False` or do we clean that up elsewhere?,Why is this needed?
+1519,"@@ -23,6 +23,7 @@ from luigi.scheduler import DISABLED, DONE, FAILED, CentralPlannerScheduler
+ 
+ luigi.notifications.DEBUG = True
+ WORKER = 'myworker'
++HOST = 'localhost'
+ 
+ 
+ class CentralPlannerTest(unittest.TestCase):",what's the reason you had to add the `host` argument to all `get_work` calls?,Why is this needed?
+1520,"@@ -37,6 +37,13 @@ public class UpdatePermissionRootCommand extends AbstractCommand<Dataverse> {
+ 		}
+ 	}
+ 
++    @Override
++    public boolean onSuccess(CommandContext ctxt, Object r) {  
++        return ctxt.dataverses().index((Dataverse) r,true);
++    }        
++
++
++    //TODO: Review this as this will never be an instance of Dataset, will it?
+     @Override
+     public Map<String, Set<Permission>> getRequiredPermissions() {
+         // for data file check permission on owning dataset",This will never be a dataset so we can simplify the code here,Why is this needed?
+1521,"@@ -89,6 +89,15 @@ public abstract class AbstractBlockProcessor implements BlockProcessor {
+ 
+   private final MiningBeneficiaryCalculator miningBeneficiaryCalculator;
+ 
++  public AbstractBlockProcessor(final AbstractBlockProcessor blockProcessor) {
++    this(
++        blockProcessor.transactionProcessor,
++        blockProcessor.transactionReceiptFactory,
++        blockProcessor.blockReward,
++        blockProcessor.miningBeneficiaryCalculator,
++        blockProcessor.skipZeroBlockRewards);
++  }
++
+   public AbstractBlockProcessor(
+       final TransactionProcessor transactionProcessor,
+       final MainnetBlockProcessor.TransactionReceiptFactory transactionReceiptFactory,",This should be moved into the PrivacyBlockProcessor instead of adding the constructor here.,Why do we need this
+1522,"@@ -38,7 +38,7 @@ import (
+ 	""github.com/pipe-cd/pipe/pkg/crypto""
+ 	""github.com/pipe-cd/pipe/pkg/datastore""
+ 	""github.com/pipe-cd/pipe/pkg/git""
+-	""github.com/pipe-cd/pipe/pkg/insight""
++	insightfilestore ""github.com/pipe-cd/pipe/pkg/insight/insightstore""
+ 	""github.com/pipe-cd/pipe/pkg/model""
+ 	""github.com/pipe-cd/pipe/pkg/redis""
+ 	""github.com/pipe-cd/pipe/pkg/rpc/rpcauth""","nit: Remove ""insightfilestore"". I think ""insightstore"" is good enough and as I see we are using that name at other places too.",Why do we need this
+1523,"@@ -5,8 +5,8 @@ module RSpec::Core::Formatters
+   BisectProgressFormatter = Class.new(remove_const :BisectProgressFormatter) do
+     RSpec::Core::Formatters.register self
+ 
+-    def bisect_round_finished(notification)
+-      return super unless notification.round == 3
++    def bisect_round_started(notification)
++      return super unless @round_count == 3
+ 
+       Process.kill(""INT"", Process.pid)
+       # Process.kill is not a synchronous call, so to ensure the output",It looks like you've removed `bisect_round_finished` but kept `bisect_round_started`. Seems a little odd that they aren't paired. Not sure if there's anything to do about that though...,`@round_count` shou
+1524,"@@ -29,6 +29,8 @@ from qutebrowser.mainwindow.statusbar.percentage import Percentage
+ def percentage(qtbot):
+     """"""Fixture providing a Percentage widget.""""""
+     widget = Percentage()
++    # Force immedate update of percentage widget
++    widget.set_perc.throttle_set(-1)
+     qtbot.add_widget(widget)
+     return widget
+ ","I'm not sure how to fix the lint and mypy warnings on this line. I could just ignore them, but I feel like the linter should know this exists.",Why is this needed?
+1525,"@@ -1,7 +1,7 @@
+ 'use strict';
+ 
+ const Aspect = {
+-  SKIP_SESSION: Symbol('SKIP_SESSION')
++  SKIP_SESSION: 'SKIP_SESSION'
+ };
+ 
+ /**",why remove `Symbol`?,Why this change?
+1526,"@@ -121,7 +121,7 @@ function getPunctuationRegExp() {
+ 	 * Reference: https://en.wikipedia.org/wiki/Supplemental_Punctuation
+ 	 * -> \u2E00-\u2E7F Reference
+ 	 */
+-	return /[\u2000-\u206F\u2E00-\u2E7F\\'!""#$%&()*+,\-.\/:;<=>?@\[\]^_`{|}~]/g;
++	return /[\u2000-\u206F\u2E00-\u2E7F\\'!""#$%&£¢¥§€()*+,\-.\/:;<=>?@\[\]^_`{|}~±]/g;
+ }
+ 
+ /**","Why are currency signs considered punctuation? They technically fall under the BMP range for Currency Symbols `\u20A0-\u20CF` (covered in `getUnicodeNonBmpRegExp`, which is itself a misnomer)",Why is this change 
+1527,"@@ -71,6 +71,7 @@ setup(
+     # Metadata
+     author='Philippe BIONDI',
+     author_email='phil(at)secdev.org',
++    maintainer='Pierre LALET, Guillaume VALADON',
+     description='Scapy: interactive packet manipulation tool',
+     license='GPLv2',
+     url='http://www.secdev.org/projects/scapy',","You have forgotten a coma `,`",Please remove this 
+1528,"@@ -35,7 +35,8 @@ def single_gpu_test(model, data_loader, show=False, out_dir=None):
+                 img_show = mmcv.imresize(img_show, (ori_w, ori_h))
+ 
+                 if out_dir:
+-                    out_file = osp.join(out_dir, img_meta['filename'])
++                    out_file = osp.join(out_dir,
++                                        osp.basename(img_meta['filename']))
+                 else:
+                     out_file = None
+ ","For different datasets, we may want to save the images differently. Sometimes the datasets are categorized into several subfolders, and we want to keep it when saving visualization results, and sometimes we just want to save all images in `out_dir`. An argument may be added to control the behavior.",Why not use `osp.basename`?
+1529,"@@ -788,7 +788,12 @@ public class FlexBuffers {
+                 if (io == other.length) {
+                     // in our buffer we have an additional \0 byte
+                     // but this does not exist in regular Java strings, so we return now
+-                    return c1 - c2;
++                    int cmp = c1 - c2;
++                    if (cmp != 0 || bb.get(ia) == '\0') {
++                        return cmp;
++                    } else {
++                        return 1;
++                    }
+                 }
+             }
+             while (c1 == c2);","if `other` could have a guaranteed `0` byte in it, this whole `if` could be removed, and above you could just add `|| c2 == '\0'` to get the same effect?",I'm not sure if this is the
+1530,"@@ -33,7 +33,11 @@ import org.apache.iceberg.exceptions.AlreadyExistsException;
+ public class CachingCatalog implements Catalog {
+ 
+   public static Catalog wrap(Catalog catalog) {
+-    return new CachingCatalog(catalog);
++    return wrap(catalog, true);
++  }
++
++  public static Catalog wrap(Catalog catalog, Boolean caseSensitive) {
++    return new CachingCatalog(catalog, caseSensitive);
+   }
+ 
+   private final Cache<TableIdentifier, Table> tableCache = Caffeine.newBuilder()",nit: can this be a primitive value?,nit: `CachingCatalog(Catalo
+1531,"@@ -333,9 +333,14 @@ func (b Browse) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
+ 
+ 	// Browsing navigation gets messed up if browsing a directory
+ 	// that doesn't end in ""/"" (which it should, anyway)
+-	if !strings.HasSuffix(r.URL.Path, ""/"") {
+-		staticfiles.RedirectToDir(w, r)
+-		return 0, nil
++	u := r.Context().Value(httpserver.OriginalURLCtxKey).(url.URL)
++	if u.Path == """" {
++		u.Path = ""/""
++	}
++	if u.Path[len(u.Path)-1] != '/' {
++		u.Path += ""/""
++		http.Redirect(w, r, u.String(), http.StatusMovedPermanently)
++		return http.StatusMovedPermanently, nil
+ 	}
+ 
+ 	return b.ServeListing(w, r, requestedFilepath, bc)","This maybe not what we want. If `rewrite` occurred before, `r.URL.Path` contains the result and we should use it. Otherwise `rewrite` middleware will disfunction when combining with `browser`.",I think this should be `str
+1532,"@@ -197,7 +197,7 @@ class Engine(object):
+         # :type exception: BaseException
+         exception = None
+         try:
+-            modules = [self.provisioning, self.aggregator] + self.reporters
++            modules = [self.aggregator, self.provisioning] + self.reporters
+             modules += self.services
+             for module in modules:
+                 try:",Why change this?,I'm not sure if this is the right way to do this. I think it would be better to do this in a separate PR.
+1533,"@@ -5,9 +5,9 @@ declare(strict_types=1);
+ namespace Shopsys\FrameworkBundle\Component\Error;
+ 
+ use Psr\Log\LoggerInterface;
+-use Symfony\Component\HttpKernel\EventListener\ExceptionListener;
++use Symfony\Component\HttpKernel\EventListener\ErrorListener;
+ 
+-class NotLogFakeHttpExceptionsExceptionListener extends ExceptionListener
++class NotLogFakeHttpExceptionsExceptionListener extends ErrorListener
+ {
+     /**
+      * @var \Shopsys\FrameworkBundle\Component\Error\ErrorIdProvider|null",  _nitpick_ Isn't it now actually NotLogFakeHttpExceptions**Error**Listener ?,This should be reverted.
+1534,"@@ -82,6 +82,7 @@ namespace AutoRest.AzureResourceSchema
+                     JsonSchema resourceDefinition = new JsonSchema();
+                     resourceDefinition.JsonType = ""object"";
+ 
++                    resourceDefinition.ResourceType = resourceType;
+                     resourceDefinition.AddProperty(""type"", JsonSchema.CreateStringEnum(resourceType), true);
+                     resourceDefinition.AddProperty(""apiVersion"", JsonSchema.CreateStringEnum(apiVersion), true);
+ ","Why not just look for the ""type"" property instead of creating a ResourceType property?",Why do we need this?
+1535,"@@ -360,7 +360,8 @@ func (bc *blockchain) context(ctx context.Context, tipInfoFlag bool) (context.Co
+ 		protocol.WithBlockchainCtx(
+ 			ctx,
+ 			protocol.BlockchainCtx{
+-				Tip: tip,
++				Tip:     tip,
++				ChainID: config.ChainID(),
+ 			},
+ 		),
+ 		bc.config.Genesis,",should use `bc.config.Blockchain.ChainID`,Shouldn't this be ChainID?
+1536,"@@ -17,13 +17,12 @@ import java.util.Collections;
+ import java.util.List;
+ import org.springframework.boot.context.properties.ConfigurationProperties;
+ import zipkin.storage.elasticsearch.ElasticsearchStorage;
+-import zipkin.storage.elasticsearch.NativeClient;
+ 
+ @ConfigurationProperties(""zipkin.storage.elasticsearch"")
+ public class ZipkinElasticsearchStorageProperties {
+-  /** @see NativeClient.Builder#cluster(String) */
++  /** @see ElasticsearchStorage.Builder#cluster(String) */
+   private String cluster = ""elasticsearch"";
+-  /** @see NativeClient.Builder#hosts(List) */
++  /** @see ElasticsearchStorage.Builder#hosts(List) */
+   private List<String> hosts = Collections.singletonList(""localhost:9300"");
+   /** @see ElasticsearchStorage.Builder#index(String) */
+   private String index = ""zipkin"";",this doesn't need to know about NativeClient,Shouldn't this be `ZipkinElasticsearchStorageProperties`?
+1537,"@@ -233,7 +233,8 @@ class ViolationAccess(object):
+                 violation.get('full_name', ''),
+                 violation.get('resource_data', ''),
+                 violation.get('violation_data', ''),
+-                violation.get('rule_name', '')
++                violation.get('rule_name', ''),
++                violation.get('resource_name', '')
+             )
+ 
+             violation = Violation(","I know we discussed if we should add in the resource_name to the hash, and I actually don't think it's required. The violation hash was recently updated (not released) to include the violated rule, so when the next release goes out, user's findings will get updated. The resource name doesn't hurt to have here, but not required.",Why is this change needed?
+1538,"@@ -14,8 +14,11 @@ static void surface_attach(struct wl_client *client,
+ 		struct wl_resource *resource,
+ 		struct wl_resource *buffer, int32_t sx, int32_t sy) {
+ 	struct wlr_surface *surface = wl_resource_get_user_data(resource);
++	int scale = surface->current.scale;
+ 	surface->pending.invalid |= WLR_SURFACE_INVALID_BUFFER;
+ 	surface->pending.buffer = buffer;
++	surface->texture->height_from_buffer = surface->texture->height / scale;
++	surface->texture->width_from_buffer = surface->texture->width / scale;
+ }
+ 
+ static void surface_damage(struct wl_client *client,","The variable name is also misleading imo. The width from the buffer comes from `wl_shm_buffer_get_width` (or a similar EGL thing), which is what gets encoded into `surface->texture->width`.",Shouldn't this be `scale / sx`?
+1539,"@@ -179,6 +179,8 @@ class Listen(object):
+             'time' : self.ts_since_epoch,
+             'tags' : {
+                 'user_name' : escape(self.user_name),
++                'artist_msid' : self.artist_msid,
++                'recording_msid' : self.recording_msid,
+             },
+             'fields' : {
+                 'artist_name' : self.data['artist_name'],",Why are you using these tags to carry these msids?,I think this should be `self.data['artist_msid']`
+1540,"@@ -439,8 +439,8 @@ int flb_config_set_property(struct flb_config *config,
+                         flb_free(*s_val); /* release before overwriting */
+                     }
+ 
+-                    *s_val = malloc(flb_sds_len(tmp) * sizeof(char));
+-                    strncpy(*s_val, tmp, flb_sds_len(tmp));
++                    *s_val = malloc(flb_sds_len(tmp) * sizeof(char) + 1);
++                    strcpy(*s_val, tmp);
+                     flb_sds_destroy(tmp);
+                     break;
+                 default:",flb_strdup() should do the work here. note: use Fluent Bit memory wrappers,Why do we need this change?
+1541,"@@ -0,0 +1,6 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++//go:generate sh -c ""protoc -I . -I \""$(go list -f '{{ .Dir }}' -m github.com/gogo/protobuf)/protobuf\"" --gogofaster_out=. retrieval.proto""
++package pb",This line should be separated from the package declaration by one line as it is not the package description.,I think we can remove this 
+1542,"@@ -411,7 +411,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet(nil)
++				ws, err := sf.NewWorkingSet()
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 410 (from `govet`)",Why this change?
+1543,"@@ -1,15 +1,14 @@
+ package task_config
+ 
+ import (
++	""strings""
++	""time""
++
++	ds ""github.com/c2h5oh/datasize""
+ 	""github.com/sonm-io/core/insonmnia/structs""
+ 	""github.com/sonm-io/core/proto""
+ )
+ 
+-type DurationConfig struct {
+-	Since string `yaml:""since"" required:""true""`
+-	Until string `yaml:""until"" required:""true""`
+-}
+-
+ type RatingConfig struct {
+ 	Buyer    int64 `yaml:""buyer"" required:""true""`
+ 	Supplier int64 `yaml:""supplier"" required:""true""`",Maybe next time better to make separate PR?,Why is this removed?
+1544,"@@ -254,6 +254,14 @@ class MaskTestMixin(object):
+         ori_shapes = tuple(meta['ori_shape'] for meta in img_metas)
+         scale_factors = tuple(meta['scale_factor'] for meta in img_metas)
+ 
++        if all(det_bbox.shape[0] == 0 for det_bbox in det_bboxes):
++            if torch.onnx.is_in_onnx_export():
++                raise RuntimeError('[ONNX Error] Can not record MaskHead '
++                                   'as it has not been executed this time')
++            segm_results = [[[] for _ in range(self.mask_head.num_classes)]
++                            for _ in range(len(det_bboxes))]
++            return segm_results
++
+         # The length of proposals of different batches may be different.
+         # In order to form a batch, a padding operation is required.
+         if isinstance(det_bboxes, list):","line 316 also handles this case, need to simplify the logic.",Why do we need this check?
+1545,"@@ -122,9 +122,12 @@ type Options struct {
+ }
+ 
+ // openBucket returns a GCS Bucket that communicates using the given HTTP client.
+-func openBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient, opts *Options) (driver.Bucket, error) {
++func openBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient, opts *Options) (*bucket, error) {
+ 	if client == nil {
+-		return nil, errors.New(""OpenBucket requires an HTTP client"")
++		return nil, errors.New(""gcsblob.OpenBucket: client is required"")
++	}
++	if bucketName == """" {
++		return nil, errors.New(""gcsblob.OpenBucket: bucketName is required"")
+ 	}
+ 	c, err := storage.NewClient(ctx, option.WithHTTPClient(&client.Client))
+ 	if err != nil {","We used to have a simple check for bucket and object names, we then decided to remove it and rely on the backend service to check for the name. Is there any reason to add an empty name check now?",nit: `gcsblob.OpenBucket: 
+1546,"@@ -983,7 +983,11 @@ bool RTPSParticipantImpl::sendSync(
+ 
+         for (auto& send_resource : send_resource_list_)
+         {
+-            send_resource->send(msg->buffer, msg->length, destination_loc);
++            // Calculate next timeout.
++            std::chrono::microseconds timeout =
++                std::chrono::duration_cast<std::chrono::microseconds>(max_blocking_time_point - std::chrono::steady_clock::now());
++
++            send_resource->send(msg->buffer, msg->length, destination_loc, timeout);
+         }
+     }
+ ",Line too long,Why not use `std::chrono::
+1547,"@@ -638,6 +638,9 @@ MagicEffectNames magicEffectNames = {
+ 	{""orangeteleport"",	CONST_ME_ORANGETELEPORT},
+ 	{""greyteleport"",	CONST_ME_GREYTELEPORT},
+ 	{""lightblueteleport"",	CONST_ME_LIGHTBLUETELEPORT},
++	{""fatal"", 			CONST_ME_FATAL},
++	{""dodge"", 			CONST_ME_DODGE},
++	{""hourglass"",		CONST_ME_HOURGLASS},
+ };
+ 
+ ShootTypeNames shootTypeNames = {",This isn't aligned though.,Why is this a<msg>I don't 
+1548,"@@ -533,7 +533,8 @@ class PAAHead(ATSSHead):
+         cls_scores. Besides, score voting is used when `` score_voting``
+         is set to True.
+         """"""
+-        assert with_nms, 'PAA only supports ""with_nms=True"" now'
++        assert with_nms, 'PAA only supports ""with_nms=True"" now and it is ' \
++                         'mean PAAHead does not support test-time augmentation'
+         assert len(cls_scores) == len(bbox_preds) == len(mlvl_anchors)
+         batch_size = cls_scores[0].shape[0]
+ ",it is mean -> it means PAAHead does not support test-time augmentation.,I don't think this is correct. The PAAHead does not support test-time augmentation.
+1549,"@@ -119,6 +119,7 @@ from invenio.legacy.bibcatalog.api import BIBCATALOG_SYSTEM
+ from invenio.legacy.bibdocfile.config import CFG_BIBDOCFILE_ICON_SUBFORMAT_RE, \
+     CFG_BIBDOCFILE_DEFAULT_ICON_SUBFORMAT
+ from invenio.utils.hash import md5
++from invenio.legacy.bibdocfile.registry import plugins
+ 
+ import invenio.legacy.template
+ ",@lnielsen-cern thanks. I missed it :(,from invenio.legacy.bibdocfile import registry
+1550,"@@ -97,7 +97,7 @@ const AnalyticsAdSenseDashboardWidgetTopPagesTable = ( { data } ) => {
+ 		chartsEnabled: false,
+ 		links: rows.map( ( row ) => row.dimensions[ 1 ] || '/' ),
+ 		PrimaryLink: withSelect( ( select, { href = '/' } ) => {
+-			const serviceURL = select( STORE_NAME ).getServiceReportURL( 'content-pages', {
++			const serviceURL = select( STORE_NAME ).getServiceReportURL( 'content-drilldown', {
+ 				'explorer-table.plotKeys': '[]',
+ 				'_r.drilldown': `analytics.pagePath:${ href }`,
+ 			} );","@tofumatt, has it been changed intentionally? It doesn't seem to be required in IB, plus we haven't had `content-drilldown` before... If it has been changed intentionally, then should we update the `AnalyticsDashboardWidget` component to be use `content-drilldown` instead of `content-pages` as well?",I think this should be `content-pages-drilldown`
+1551,"@@ -16,6 +16,7 @@
+ 
+ from apiclient import discovery
+ from oauth2client.client import GoogleCredentials
++
+ from retrying import retry
+ 
+ from google.cloud.security.common.gcp_api._supported_apis import SUPPORTED_APIS",nit: don't think an extra line is needed here; as retrying is an installed library and should be grouped with the rest of the installed library.,from google.api_core.retry import Retry
+1552,"@@ -123,6 +123,13 @@ type PrometheusSpec struct {
+ 	// The labels to add to any time series or alerts when communicating with
+ 	// external systems (federation, remote storage, Alertmanager).
+ 	ExternalLabels map[string]string `json:""externalLabels,omitempty""`
++	// Enable access to prometheus web admin API. Defaults to the value of `false`.
++	// WARNING: Enabling the admin APIs enables mutating endpoints, to delete data,
++	// shutdown Prometheus, and more. Enabling this should be done with care and the
++	// user is advised to add additional authentication authorization via a proxy to
++	// ensure only clients authorized to perform these actions can do so.
++	// For more information see https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
++	EnableAdminAPI string `json:""enableAdminAPI,omitempty""`
+ 	// The external URL the Prometheus instances will be available under. This is
+ 	// necessary to generate correct URLs. This is necessary if Prometheus is not
+ 	// served from root of a DNS name.",This should be a bool,I think this should be `omitempty` as well.
+1553,"@@ -5129,12 +5129,12 @@ SwiftASTContext::GetReferentType(const CompilerType &compiler_type) {
+ 
+   if (compiler_type.IsValid() &&
+       llvm::dyn_cast_or_null<SwiftASTContext>(compiler_type.GetTypeSystem())) {
+-    swift::CanType swift_can_type(GetCanonicalSwiftType(compiler_type));
+-    swift::TypeBase *swift_type = swift_can_type.getPointer();
+-    if (swift_type && llvm::isa<swift::WeakStorageType>(swift_type))
++    swift::Type swift_type(GetSwiftType(compiler_type));
++    swift::TypeBase *swift_typebase = swift_type.getPointer();
++    if (swift_type && llvm::isa<swift::WeakStorageType>(swift_typebase))
+       return compiler_type;
+ 
+-    auto ref_type = swift_can_type->getReferenceStorageReferent();
++    auto ref_type = swift_type->getReferenceStorageReferent();
+     return CompilerType(GetASTContext(), ref_type);
+   }
+ ",`if (llvm::dyn_cast_or_null<swift::WeakStorageType>(GetSwiftType(compiler_type).getPointer())` ?,nit: `swift_typebase` -> `typebase`
+1554,"@@ -144,13 +144,13 @@ func (e *deployExecutor) generateCanaryManifests(manifests []provider.Manifest,
+ 
+ 	// Find config map manifests and duplicate them for CANARY variant.
+ 	configMaps := findConfigMapManifests(manifests)
+-	configMaps = duplicateManifests(configMaps, suffix)
+-	canaryManifests = append(canaryManifests, configMaps...)
++	canaryConfigMaps := duplicateManifests(configMaps, suffix)
++	canaryManifests = append(canaryManifests, canaryConfigMaps...)
+ 
+ 	// Find secret manifests and duplicate them for CANARY variant.
+ 	secrets := findSecretManifests(manifests)
+-	secrets = duplicateManifests(secrets, suffix)
+-	canaryManifests = append(canaryManifests, secrets...)
++	canarySecrets := duplicateManifests(secrets, suffix)
++	canaryManifests = append(canaryManifests, canarySecrets...)
+ 
+ 	// Generate new workload manifests for CANARY variant.
+ 	// The generated ones will mount to the new ConfigMaps and Secrets.","The `generateVariantWorkloadManifests` function below relies on the config manifests specified in Git, but it was passed with the newly created canary's manifests where their name was updated.",Why do we need this change?
+1555,"@@ -19,9 +19,10 @@ use Symfony\Component\DependencyInjection\Loader\YamlFileLoader;
+ class ErgonodeAccountExtension extends Extension implements PrependExtensionInterface
+ {
+     /**
++     * @throws \Exception
++     *
+      * @param array $configs
+      *
+-     * @throws \Exception
+      */
+     public function load(array $configs, ContainerBuilder $container): void
+     {",are this docs neccesary ?,Why did you remove this?
+1556,"@@ -46,8 +46,8 @@ import java.util.List;
+ public class HttpCommandProcessor implements CommandProcessor {
+ 
+   private String pathToServlet;
+-  private String browserStartCommand;
+-  private String browserURL;
++  private final String browserStartCommand;
++  private final String browserURL;
+   private String sessionId;
+   private String extensionJs;
+   private String rcServerLocation;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,Why is this final?
+1557,"@@ -13,6 +13,8 @@ void SoftmaxWithLossLayer<Dtype>::LayerSetUp(
+   LossLayer<Dtype>::LayerSetUp(bottom, top);
+   LayerParameter softmax_param(this->layer_param_);
+   softmax_param.set_type(""Softmax"");
++  // no loss weight for the Softmax internal layer.
++  softmax_param.clear_loss_weight();
+   softmax_layer_ = LayerRegistry<Dtype>::CreateLayer(softmax_param);
+   softmax_bottom_vec_.clear();
+   softmax_bottom_vec_.push_back(bottom[0]);","This change suppose to resolve issue #2968. `loss_weight` should be of length 2, the second entry is ignored.",Why do we need thi
+1558,"@@ -242,7 +242,17 @@ var filesToIgnore = map[string]bool{
+ 
+ func ignoreFile(filename string) bool {
+ 	_, base := path.Split(filename)
+-	return filesToIgnore[base] || strings.HasPrefix(base, ""._"")
++	if filesToIgnore[base] || strings.HasPrefix(base, ""._"") {
++		return true
++	}
++	// Treat the files to ignore as prefixes, since if they ever
++	// conflict they'll have the conflict suffix.
++	for prefix := range filesToIgnore {
++		if strings.HasPrefix(base, prefix) {
++			return true
++		}
++	}
++	return false
+ }
+ 
+ // processNotification adds the notification to the recomputer's",Is there an easy way to check for conflict suffix to avoid false positives here?,I don't think this
+1559,"@@ -59,7 +59,7 @@ module Bolt
+         run_opts = {}
+         run_opts[:run_as] = opts['_run_as'] if opts['_run_as']
+         begin
+-          task = apply_prep.get_task(opts['task'], params)
++          task = @context.get_validated_task(opts['task'], params)
+         rescue Bolt::Error => e
+           raise Bolt::Plugin::PluginError::ExecutionError.new(e.message, name, 'puppet_library')
+         end",`apply_prep.run_task` also seems like it can just use `@context.run_task`,I think this shoul
+1560,"@@ -36,6 +36,9 @@ define([""events"", ""layoutManager"", ""inputManager"", ""userSettings"", ""libraryMenu""
+                 showYear: true,
+                 centerText: true
+             });
++
++            // FIXME: Wait for all sections to load
++            autoFocus(page);
+         });
+     }
+ ",do you have any idea on how to fix it?,This should be removed.
+1561,"@@ -159,3 +159,19 @@ class GCSTargetTest(_GCSBaseTestCase, FileSystemTargetTestMixin):
+ 
+     def create_target(self, format=None):
+         return gcs.GCSTarget(bucket_url(self.id()), format=format, client=self.client)
++
++    def test_close_twice(self):
++        # Ensure gcs._DeleteOnCloseFile().close() can be called multiple times
++        tgt = self.create_target()
++
++        with tgt.open('w') as dst:
++            dst.write('data')
++        assert dst.closed
++        dst.close()
++        assert dst.closed
++
++        with tgt.open() as src:
++            assert src.read().strip() == 'data'
++        assert src.closed
++        src.close()
++        assert src.closed","You don't need to fix this (you've done so many iterations). But for next time, you can make this into a docstring so it'll have a nicer descriptive name when the tests are running.",Can you also check that
+1562,"@@ -90,6 +90,15 @@ func (eni *ENIAttachment) StopAckTimer() {
+ 	eni.ackTimer.Stop()
+ }
+ 
++// HasExpired returns true if the ENI attachment object has exceeded the
++// threshold for notifying the backend of the attachment
++func (eni *ENIAttachment) HasExpired() bool {
++	eni.guard.RLock()
++	defer eni.guard.RUnlock()
++
++	return time.Now().After(eni.ExpiresAt)
++}
++
+ // String returns a string representation of the ENI Attachment
+ func (eni *ENIAttachment) String() string {
+ 	eni.guard.RLock()",When does 'expiresAt' change? Do you need this?,I don't think we need t
+1563,"@@ -75,3 +75,15 @@ const Outfit* Outfits::getOutfitByLookType(PlayerSex_t sex, uint16_t lookType) c
+ 	}
+ 	return nullptr;
+ }
++
++const Outfit* Outfits::getOutfitByLookType(uint16_t lookType) const
++{
++	for (uint8_t sex = 0; sex <= 1; sex++) {
++		for (const Outfit& outfit : outfits[sex]) {
++			if (outfit.lookType == lookType) {
++				return &outfit;
++			}
++		}
++	}
++	return nullptr;
++}",There are enums for genders + `PLAYERSEX_LAST`.,This should be `const O
+1564,"@@ -23,9 +23,14 @@ func TestCalculateRollupFee(t *testing.T) {
+ 			data := make([]byte, 0, tt.dataLen)
+ 			fee := CalculateRollupFee(data, tt.gasUsed, big.NewInt(tt.dataPrice), big.NewInt(tt.executionPrice))
+ 
+-			dataFee := uint64((RollupBaseTxSize + len(data)) * int(tt.dataPrice))
++			zeroes, ones := zeroesAndOnes(data)
++			zeroesCost := zeroes * 4
++			onesCost := (96 + ones) * 16
++			dataCost := zeroesCost + onesCost
++			dataFee := int64(dataCost) * tt.dataPrice
++
+ 			executionFee := uint64(tt.executionPrice) * tt.gasUsed
+-			expectedFee := dataFee + executionFee
++			expectedFee := uint64(dataFee) + executionFee
+ 			if fee.Cmp(big.NewInt(int64(expectedFee))) != 0 {
+ 				t.Errorf(""rollup fee check failed: expected %d, got %s"", expectedFee, fee.String())
+ 			}",Should this use the constants as well? Or intentionally covering the fact that the constants may change,Why do we need this change?
+1565,"@@ -58,7 +58,10 @@ class TopNContainer(object):
+     return self.extras
+ 
+   def __len__(self):
+-    return self._size
++    if self._size >= 0:
++      return self._size
++    else:
++      return len(self.best)
+ 
+   def __getitem__(self, which):
+     return self.best[which], self.extras[which]",The case of a negative size (= keep all elements) was not handled in this function.,Why not just `return self.b
+1566,"@@ -70,13 +70,13 @@ var keys = map[Key]string{
+ 	EnableNamespaceNotActiveAutoForwarding: ""system.enableNamespaceNotActiveAutoForwarding"",
+ 	TransactionSizeLimit:                   ""system.transactionSizeLimit"",
+ 	MinRetentionDays:                       ""system.minRetentionDays"",
+-	MaxWorkflowTaskTimeout:                 ""system.maxWorkflowTaskTimeout"",
+ 	DisallowQuery:                          ""system.disallowQuery"",
+ 	EnableBatcher:                          ""worker.enableBatcher"",
+ 	EnableParentClosePolicyWorker:          ""system.enableParentClosePolicyWorker"",
+ 	EnableStickyQuery:                      ""system.enableStickyQuery"",
+ 	EnablePriorityTaskProcessor:            ""system.enablePriorityTaskProcessor"",
+ 	EnableAuthorization:                    ""system.enableAuthorization"",
++	EnableInfiniteTimeout:                  ""system.enableInfiniteTimeout"",
+ 
+ 	// size limit
+ 	BlobSizeLimitError:     ""limit.blobSize.error"",",I think we should keep this dynamic config knob for operations purpose.,Why is this removed?
+1567,"@@ -60,7 +60,6 @@ class TestCharacterOffsets(unittest.TestCase):
+ 		obj = BasicTextProvider(text=u""\U0001f926\U0001f60a\U0001f44d"") # 🤦😊👍
+ 		ti = obj.makeTextInfo(Offsets(5, 5))
+ 		ti.expand(textInfos.UNIT_CHARACTER) # Range at 👍
+-		self.assertEqual(ti.offsets, (4, 6)) # Two offsets
+ 		ti.move(textInfos.UNIT_CHARACTER, -1)
+ 		ti.expand(textInfos.UNIT_CHARACTER) # Range at 😊
+ 		self.assertEqual(ti.offsets, (2, 4)) # Two offsets",Was this intentional? Perhaps this could be replaced with another way to check the offsets?,Why was this removed?
+1568,"@@ -86,6 +86,7 @@ type PipelineManifest struct {
+ 	Version PipelineSchemaMajorVersion `yaml:""version""`
+ 	Source  *Source                    `yaml:""source""`
+ 	Stages  []PipelineStage            `yaml:""stages""`
++	// ArtifactBuckets?
+ }
+ 
+ // Source defines the source of the artifacts to be built and deployed.","the buckets are created via the stackset, customers don't need to provide them",I don't think we need this.
+1569,"@@ -25,7 +25,7 @@ module Blacklight
+     # Execute a search query against solr
+     # @param [Hash] solr query parameters
+     def search params = {}
+-      send_and_receive blacklight_config.solr_path, { qt: blacklight_config.qt }.merge(params)
++      send_and_receive blacklight_config.solr_path, params.merge({ qt: blacklight_config.qt })
+     end
+ 
+     ##",This doesn't have the same behavior as before. Maybe you want `reverse_merge` (and it either just works or we implement it on `Blacklight::Solr::Request`),Space inside { missing.<br>
+1570,"@@ -6,6 +6,7 @@ module Travis
+ 
+         def setup
+           super
++          cmd ""export PATH=/usr/local/ghc/#{ghc_version}/bin/:$PATH""
+           cmd 'cabal update', fold: 'cabal', retry: true
+         end
+ ","This should be ` /$(ghc_find #{config[:ghc]})/ ` instead of ` /#{ghc_version}/ `, I think.",Why do we need this?
+1571,"@@ -374,7 +374,7 @@ define([""appSettings"", ""browser"", ""events"", ""htmlMediaHelper""], function (appSet
+             return -1 !== supportedFeatures.indexOf(command.toLowerCase());
+         },
+         preferVisualCards: browser.android || browser.chrome,
+-        moreIcon: browser.android ? ""dots-vert"" : ""dots-horiz"",
++        moreIcon: browser.android ? ""more_vert"" : ""more_horiz"",
+         getSyncProfile: getSyncProfile,
+         getDefaultLayout: function () {
+             if (window.NativeShell) {",We should deprecate this at some point.,I don't think we should cha
+1572,"@@ -49,7 +49,9 @@ class FCOSHead(nn.Module):
+                      use_sigmoid=True,
+                      loss_weight=1.0),
+                  conv_cfg=None,
+-                 norm_cfg=dict(type='GN', num_groups=32, requires_grad=True)):
++                 norm_cfg=dict(type='GN', num_groups=32, requires_grad=True),
++                 center_sampling=False,
++                 center_sample_radius=1.5):
+         super(FCOSHead, self).__init__()
+ 
+         self.num_classes = num_classes",Move these two arguments before `loss_cls`.,Why do we need this?
+1573,"@@ -93,10 +93,16 @@ func GenerateSelfSignedX509CA(commonName string, extUsage []x509.ExtKeyUsage, ke
+ }
+ 
+ // GenerateServerX509UsingCA generates a TLS serverCert that is self-signed
+-func GenerateServerX509UsingCA(commonName string, ca *tls.Certificate) (*tls.Certificate, *rsa.PrivateKey, error) {
++func GenerateServerX509UsingCAAndSerialNumber(commonName string, serialNumber int64, ca *tls.Certificate) (*tls.Certificate, *rsa.PrivateKey, error) {
+ 	now := time.Now().UTC()
+ 
+-	i := mathrand.Int63n(100000000000000000)
++	var i int64
++	if serialNumber == 0 {
++		i = mathrand.Int63n(100000000000000000)
++	} else {
++		i = serialNumber
++	}
++
+ 	template := &x509.Certificate{
+ 		SerialNumber: big.NewInt(i),
+ 		Subject: pkix.Name{",[Super NIT]: i := serialNumber if i == 0 { i = mathrand.Int63n(...) },Why do we need this 
+1574,"@@ -14,8 +14,8 @@ namespace Microsoft.CodeAnalysis.Sarif.ConvertToSarif
+         public string InputFilePath { get; internal set; }
+ 
+         [Option(
+-            'f',
+-            ""format"",
++            't',
++            ""tool"",
+             HelpText = ""The tool format of the input file."")]
+         public ToolFormat ToolFormat { get; internal set; }
+ ",-f short form here collided with --force. :),">t [](start = 58, le"
+1575,"@@ -12,6 +12,5 @@ describe('preact', () => {
+ 		expect(cloneElement).to.be.a('function');
+ 		expect(createContext).to.be.a('function');
+ 		expect(options).to.exist.and.be.an('object');
+-		// expect(rerender).to.be.a('function');
+ 	});
+ });",I think it is better to describe in the release note that `rerender()` was removed.,Why was this removed
+1576,"@@ -3,5 +3,5 @@ VERSION = ""."".join(str(i) for i in IVERSION)
+ PATHOD = ""pathod "" + VERSION
+ MITMPROXY = ""mitmproxy "" + VERSION
+ 
+-if __name__ == ""__main__"":
++if __name__ == ""__main__"":  # pragma: no cover
+     print(VERSION)","We could also test this easily with `runpy.run_module`, what do you think?",Why is this pragma needed?
+1577,"@@ -388,8 +388,10 @@ func decode(v reflect.Value, d Decoder) error {
+ 		if err != nil {
+ 			return err
+ 		}
+-		v.Set(reflect.ValueOf(val))
+-		return nil
++		if v.Type().AssignableTo(reflect.TypeOf(val)) {
++			v.Set(reflect.ValueOf(val))
++			return nil
++		}
+ 	}
+ 
+ 	// Handle implemented interfaces first.","Is it OK to fall through if it's not assignable? I was kind of surprised when the tests passed. Maybe one of the options below ends up working? For the new tests, this panics because `**not assignable uuid.UUID to []uint8**`. `uuid.UUID` is an array, not a slice.",Why is this needed?
+1578,"@@ -133,7 +133,8 @@ func runAPIAndWait(ctx context.Context, nd *node.Node, config *config.Config, re
+ 		ctx:          context.Background(),
+ 		api:          api,
+ 		porcelainAPI: nd.PorcelainAPI,
+-		blockpAPI:    nd.BlockAPI,
++		blockAPI:     nd.BlockAPI,
++		retrievalAPI: nd.RetrievalAPI,
+ 	}
+ 
+ 	cfg := cmdhttp.NewServerConfig()",I know this is after the fact but imo blockAPI should be blockMiningAPI.,Why is this called retriev
+1579,"@@ -13,7 +13,11 @@ use Ergonode\SharedKernel\Domain\AbstractCode;
+ 
+ class AttributeCode extends AbstractCode
+ {
+-    public const PATTERN = '/^([a-zA-Z0-9_]+)$/';
++    public const NOT_SYSTEM_ATTRIBUTE_PATTERN = '/^(?!'.self::SYSTEM_ATTRIBUTE_PREFIX.')[a-zA-Z0-9_]+$/';
++
++    public const SYSTEM_ATTRIBUTE_PATTERN = '/^'.self::SYSTEM_ATTRIBUTE_PREFIX.'[a-zA-Z0-9_]+$/';
++
++    public const SYSTEM_ATTRIBUTE_PREFIX = 'esa_';
+ 
+     public function __construct(string $value)
+     {",it's just a pattern as it was. SystemAttributeCode should have it's own definition and validate by it,Why do we need this consta
+1580,"@@ -0,0 +1,17 @@
++/* Copyright (c) 2019 vesoft inc. All rights reserved.
++ *
++ * This source code is licensed under Apache 2.0 License,
++ * attached with Common Clause Condition 1.0, found in the LICENSES directory.
++ */
++
++#include ""LookUpEdgeIndexProcessor.h""
++
++namespace nebula {
++namespace storage {
++
++void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
++    UNUSED(req);
++}
++}  // namespace storage
++}  // namespace nebula
++","Similar to the code block when we use prefix, maybe we can unify them to base?",Why do we need this header?
+1581,"@@ -100,6 +100,15 @@ func (in *PodChaos) ValidateScheduler(spec *field.Path) field.ErrorList {
+ 			allErrs = append(allErrs, err...)
+ 		}
+ 		break
++	case PodNotReadyAction:
++		// We choose to ignore the Duration property even user define it
++		if in.Spec.Scheduler == nil {
++			allErrs = append(allErrs, field.Invalid(schedulerField, in.Spec.Scheduler, ValidatePodchaosSchedulerError))
++		} else {
++			_, err := ParseCron(in.Spec.Scheduler.Cron, schedulerField.Child(""cron""))
++			allErrs = append(allErrs, err...)
++		}
++		break
+ 	default:
+ 		err := fmt.Errorf(""podchaos[%s/%s] have unknown action type"", in.Namespace, in.Name)
+ 		log.Error(err, ""Wrong PodChaos Action type"")",I think `Duration` is useful for this action and we shouldn't ignore it.,Why do we need to ignore th
+1582,"@@ -243,13 +243,10 @@ func (s *stream) Write(p []byte) (int, error) {
+ 		s.mutex.Lock()
+ 	}
+ 
+-	if err != nil {
+-		return 0, err
+-	}
+ 	if s.err != nil {
+-		return len(p) - len(s.dataForWriting), s.err
++		err = s.err
+ 	}
+-	return len(p), nil
++	return len(p) - len(s.dataForWriting), err
+ }
+ 
+ func (s *stream) GetWriteOffset() protocol.ByteCount {","Everything below here can be replaced with `return s.err, len(p) - len(s.dataForWriting)`.",I don't understand this cha
+1583,"@@ -84,6 +84,12 @@ namespace Impl {
+ HIPLockArrays g_host_hip_lock_arrays = {nullptr, nullptr, 0};
+ 
+ void initialize_host_hip_lock_arrays() {
++#ifdef KOKKOS_ENABLE_IMPL_DESUL_ATOMICS
++  desul::Impl::init_lock_arrays();
++
++  DESUL_ENSURE_HIP_LOCK_ARRAYS_ON_DEVICE();
++#endif
++
+   if (g_host_hip_lock_arrays.atomic != nullptr) return;
+   HIP_SAFE_CALL(hipMalloc(
+       &g_host_hip_lock_arrays.atomic,","Again, we can also guard `g_host_hip_lock_arrays.atomic`, can't we?",Why do we need this?
+1584,"@@ -69,12 +69,13 @@ class ImportSimpleProductCommandHandler
+             );
+ 
+             if (!empty($attributesToRedispatch)) {
+-                $this->commandBus->dispatch(new ImportProductAttributesValueCommand(
++                $ImportProductAttributesValueCommand = new ImportProductAttributesValueCommand(
+                     $command->getId(),
+                     $command->getImportId(),
+                     $attributesToRedispatch,
+                     $command->getSku()
+-                ));
++                );
++                $this->commandBus->dispatch($ImportProductAttributesValueCommand, true);
+             }
+             $this->repository->markLineAsSuccess($command->getId(), $product->getId());
+         } catch (ImportException $exception) {",Variable name should start from lowercase latter,Shouldn't it be `false` here?
+1585,"@@ -47,12 +47,12 @@ import (
+ // certificate, ca, and private key is stored into the target Secret to
+ // complete Issuing the Certificate.
+ func TestIssuingController(t *testing.T) {
+-	config, stopFn := framework.RunControlPlane(t)
+-	defer stopFn()
+-
+-	ctx, cancel := context.WithTimeout(context.Background(), time.Second*20)
++	ctx, cancel := context.WithTimeout(context.Background(), time.Second*40)
+ 	defer cancel()
+ 
++	config, stopFn := framework.RunControlPlane(t, ctx)
++	defer stopFn()
++
+ 	// Build, instantiate and run the issuing controller.
+ 	kubeClient, factory, cmCl, cmFactory := framework.NewClients(t, config)
+ 	controllerOptions := controllerpkg.CertificateOptions{",Why has this timeout doubled?,Why was this changed?
+1586,"@@ -113,7 +113,7 @@ type Config struct {
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;30""`
+ 	IptablesLockFilePath               string        `config:""file;/run/xtables.lock""`
+-	IptablesLockTimeoutSecs            time.Duration `config:""seconds;30""`
++	IptablesLockTimeoutSecs            time.Duration `config:""seconds;0""`
+ 	IptablesLockProbeIntervalMillis    time.Duration `config:""millis;50""`
+ 	IpsetsRefreshInterval              time.Duration `config:""seconds;10""`
+ 	MaxIpsetSize                       int           `config:""int;1048576;non-zero""`","Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?",Why did you change this?
+1587,"@@ -335,6 +335,13 @@ class WebEngineCaret(browsertab.AbstractCaret):
+         """"""
+         if js_elem is None:
+             return
++        if js_elem == ""focused"":
++            # we had a focused element, not a selected one. Just send <enter>
++            if tab:
++                self._tab.key_press(Qt.Key_Enter, modifier=Qt.ControlModifier)
++            else:
++                self._tab.key_press(Qt.Key_Enter)
++
+         assert isinstance(js_elem, dict), js_elem
+         elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)
+         if tab:","You're missing a `return` here, but I'll add it :smile:",I think this should be `if js
+1588,"@@ -116,7 +116,7 @@ static bool gles2_render_texture_with_matrix(struct wlr_renderer *wlr_renderer,
+ 	struct wlr_gles2_renderer *renderer =
+ 		gles2_get_renderer_in_context(wlr_renderer);
+ 	struct wlr_gles2_texture *texture =
+-		get_gles2_texture_in_context(wlr_texture);
++		gles2_get_texture(wlr_texture);
+ 
+ 	struct wlr_gles2_tex_shader *shader = NULL;
+ 	GLenum target = 0;",Can you try adding back this assertion? I'd like to assert that the texture has been created in the same context as the renderer.,This should be `gles2_get_texture_in_context`
+1589,"@@ -234,7 +234,8 @@ class RouteFactory(object):
+         required_permission = self.method_permissions.get(method)
+ 
+         # For create permission, the object id is the plural endpoint.
+-        collection_path = service.collection_path.format(**request.matchdict)
++        plural_endpoint = service.collection_path.decode('utf-8')
++        collection_path = plural_endpoint.format(**request.matchdict)
+ 
+         # In the case of a ""PUT"", check if the targetted record already
+         # exists, return ""write"" if it does, ""create"" otherwise.",This won't work with Python 3 because it will already be a string. In that case we need to use `decode_header` from utils.,Why do we need to decode here?
+1590,"@@ -28,6 +28,8 @@ module Mongoid
+           raise Errors::InvalidDiscriminatorKeyTarget.new(self, self.superclass)
+         end
+ 
++        self._clear_types if self.respond_to?(:_clear_types)
++
+         if value
+           Mongoid::Fields::Validators::Macro.validate_field_name(self, value)
+           value = value.to_s",Why is the respond_to check here?,Why do we need this?
+1591,"@@ -229,7 +229,7 @@ class FunctionDocblockManipulator
+                 continue;
+             }
+ 
+-            if ($chars[$i] === '\\' || preg_match('/\w/', $char)) {
++            if ($char === '\\' || preg_match('/\w/', $char)) {
+                 if ($this->return_typehint_start === null) {
+                     $this->return_typehint_start = $i + $end_bracket_position + 1;
+                 }","@orklah are you sure it's the same as `$chars[$i]`? It looks like `$i` is changed above, after `$char` assignment.",Why did you remove the array access?
+1592,"@@ -22,7 +22,7 @@ TEST(DeleteVertexTest, SimpleTest) {
+     std::unique_ptr<kvstore::KVStore> kv(TestUtils::initKV(rootPath.path()));
+     // Add vertices
+     {
+-        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr);
++        auto* processor = AddVerticesProcessor::instance(kv.get(), nullptr, nullptr, nullptr);
+         cpp2::AddVerticesRequest req;
+         req.space_id = 0;
+         req.overwritable = false;",I have a question? How do I construct a indexManager for testcase?,Why do we need this change?
+1593,"@@ -73,6 +73,9 @@ int __FPGA_API__ opae_plugin_configure(opae_api_adapter_table *adapter,
+ {
+ 	UNUSED_PARAM(jsonConfig);
+ 
++	if (adapter == NULL || adapter->plugin.dl_handle == NULL)
++		return -1;
++
+ 	adapter->fpgaOpen = dlsym(adapter->plugin.dl_handle, ""xfpga_fpgaOpen"");
+ 	adapter->fpgaClose =
+ 		dlsym(adapter->plugin.dl_handle, ""xfpga_fpgaClose"");",These checks aren't needed. See pluginmgr.c : opae_plugin_mgr_load_dflt_plugins( ).,Shouldn't this be `return 0
+1594,"@@ -554,15 +554,14 @@ class SearchRequest
+ 
+     /**
+      * Method to check if the query string is an empty string
+-     * (also empty string or whitespaces only are handled as empty).
++     * (also whitespaces only are handled as empty).
+      *
+      * When no query string is set (null) the method returns false.
+      * @return bool
+      */
+     public function getRawUserQueryIsEmptyString()
+     {
+-        $path = $this->prefixWithNamespace('q');
+-        $query = $this->argumentsAccessor->get($path, null);
++        $query = $this->getRawUserQuery();
+ 
+         if ($query === null) {
+             return false;",Please take a care about prefixing.,Why did you remove this?
+1595,"@@ -70,6 +70,17 @@ public interface WorldUpdater extends MutableWorldView {
+     return account == null ? createAccount(address) : account;
+   }
+ 
++  /**
++   * Retrieves the provided account for a sender of a transaction if it exists, or creates it if it
++   * doesn't.
++   *
++   * @param address the address of the account.
++   * @return the account {@code address}, or {@code null} if the account does not exist.
++   */
++  default EvmAccount getOrCreateSenderAccount(final Address address) {
++    return getOrCreate(address);
++  }
++
+   /**
+    * Retrieves the provided account, returning a modifiable object (whose updates are accumulated by
+    * this updater).",this line doesn't match what the rest says,I think this should be `get
+1596,"@@ -1,4 +1,4 @@
+-// +build !linux linux,android
++// +build windows linux,android
+ 
+ /*
+  * Copyright (C) 2017 The ""MysteriumNetwork/node"" Authors.","Since it's not working for linux, maybe leave the !linux in there as well?",Why this change?
+1597,"@@ -60,6 +60,9 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) error {
+ 
+ 	// Copy Sources up to parent resolving relative paths as we go.
+ 	for k, v := range i.w.Sources {
++		if v == """" {
++			continue
++		}
+ 		if _, ok := s.w.Sources[k]; ok {
+ 			return fmt.Errorf(""source %q already exists in workflow"", k)
+ 		}","Should we remove the key-value pair entirely? Same for workflows in general. We have a ""sourceExists"" method that checks if a key is there if I remember correctly.",Why is this need
+1598,"@@ -96,7 +96,7 @@ public class ContentSoqlSyncDownTarget extends SoqlSyncDownTarget {
+ 
+     @Override
+     public JSONArray startFetch(SyncManager syncManager, long maxTimeStamp) throws IOException, JSONException {
+-        String queryToRun = maxTimeStamp > 0 ? SoqlSyncDownTarget.addFilterForReSync(getQuery(), maxTimeStamp) : getQuery();
++        String queryToRun = maxTimeStamp > 0 ? SoqlSyncDownTarget.addFilterForReSync(getQuery(), getModificationDateFieldName(), maxTimeStamp) : getQuery();
+         syncManager.getRestClient().sendSync(RestRequest.getRequestForResources(syncManager.apiVersion)); // cheap call to refresh session
+         RestRequest request = buildQueryRequest(syncManager.getRestClient().getAuthToken(), queryToRun);
+         RestResponse response = syncManager.sendSyncWithSmartSyncUserAgent(request);",Unrelated bug fix,I don't think yo
+1599,"@@ -173,15 +173,15 @@ define(['serverNotifications', 'playbackManager', 'events', 'globalize', 'requir
+             };
+ 
+             if (status === 'completed') {
+-                notification.title = globalize.translate('PackageInstallCompleted').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallCompleted', installation.Name + ' ' + installation.Version);
+                 notification.vibrate = true;
+             } else if (status === 'cancelled') {
+-                notification.title = globalize.translate('PackageInstallCancelled').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallCancelled', installation.Name + ' ' + installation.Version);
+             } else if (status === 'failed') {
+-                notification.title = globalize.translate('PackageInstallFailed').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('PackageInstallFailed', installation.Name + ' ' + installation.Version);
+                 notification.vibrate = true;
+             } else if (status === 'progress') {
+-                notification.title = globalize.translate('InstallingPackage').replace('{0}', installation.Name + ' ' + installation.Version);
++                notification.title = globalize.translate('InstallingPackage', installation.Name + ' ' + installation.Version);
+ 
+                 notification.actions =
+                 [",We probably want to let the translation library handle the string replacement for these as well.,:ok: This change
+1600,"@@ -272,8 +272,7 @@ func newAdminMembershipCommands() []cli.Command {
+ 		{
+ 			Name:  ""list_db"",
+ 			Usage: ""List cluster membership items"",
+-			Flags: append(
+-				getDBFlags(),
++			Flags: []cli.Flag{
+ 				cli.StringFlag{
+ 					Name:  FlagHeartbeatedWithin,
+ 					Value: ""15m"",","should combine these 2 list (list_gossip and list_db) into just one list command, and show the discrepancy between the 2 if any.",Why is this being removed?
+1601,"@@ -21,6 +21,11 @@ class ProposalPolicy
+     !@proposal.approved?
+   end
+ 
++  def approve_reject?
++    actionable_approvers = @proposal.currently_awaiting_approvers
++    actionable_approvers.include? @user
++  end
++
+   def edit?
+     self.test_all(:edit?)
+   end",What do you think about prefixing the Policy method names with `can_`?,Extra empty line detected 
+1602,"@@ -29,11 +29,10 @@
+ #include <sys/types.h>
+ #include <sys/stat.h>
+ 
+-/* HTTP Credentials Endpoints have a standard set of JSON Keys */
+-#define AWS_HTTP_RESPONSE_ACCESS_KEY   ""AccessKeyId""
+-#define AWS_HTTP_RESPONSE_SECRET_KEY   ""SecretAccessKey""
+-#define AWS_HTTP_RESPONSE_TOKEN        ""Token""
+-#define AWS_HTTP_RESPONSE_EXPIRATION   ""Expiration""
++#define AWS_CREDENTIAL_RESPONSE_ACCESS_KEY   ""AccessKeyId""
++#define AWS_CREDENTIAL_RESPONSE_SECRET_KEY   ""SecretAccessKey""
++#define AWS_HTTP_RESPONSE_TOKEN              ""Token""
++#define AWS_CREDENTIAL_RESPONSE_EXPIRATION   ""Expiration""
+ 
+ #define ECS_CREDENTIALS_HOST           ""169.254.170.2""
+ #define ECS_CREDENTIALS_HOST_LEN       13","Based on the docs, credential process can return a key `SessionToken`",This should be `AWS_CREDEN
+1603,"@@ -9,8 +9,12 @@ export default Ember.Mixin.create({
+ 
+     if (birthDate) {
+       if (birthDate.getFullYear === undefined) {
+-        birthDate = moment(birthDate, 'l').toDate();
++        birthDate = moment(birthDate, 'LLL').toDate();
+       }
++
++      birthDate.setHours(0, 0, 0, 0);
++      today.setHours(0, 0, 0, 0);
++
+       if (birthDate.getFullYear !== undefined) {
+         years = today.getFullYear() - birthDate.getFullYear();
+         if (today.getMonth() < birthDate.getMonth()",I think this if should be removed (see issue),Why is this needed?
+1604,"@@ -19,6 +19,7 @@ import (
+ 
+ 	log ""github.com/sirupsen/logrus""
+ 
++	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/libcalico-go/lib/set""
+ )
+ ",I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build.,import (
+1605,"@@ -19,6 +19,7 @@
+ # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+ 
+ """"""Generate the html documentation based on the asciidoc files.""""""
++from typing import List, Tuple
+ 
+ import re
+ import os","nitpick: Please move this down to the other imports, as it's a Python stdlib import.",`from ty
+1606,"@@ -13,7 +13,8 @@
+ // limitations under the License.
+ 
+ // Package blob provides an easy and portable way to interact with blobs
+-// within a storage location, hereafter called a ""bucket"".
++// within a storage location, hereafter called a ""bucket"". See
++// https://gocloud.dev/howto/blob/ for getting started guides.
+ //
+ // It supports operations like reading and writing blobs (using standard
+ // interfaces from the io package), deleting blobs, and listing blobs in a","""for getting started guides"" reads a bit weird, like it's missing punctuation. Maybe just ""for a tutorial""?",I don't 
+1607,"@@ -50,9 +50,9 @@ class Formats extends AbstractBase
+      * Constructor
+      *
+      * @param bool $enabled is this tab enabled?
+-     * @param bool $urc     use recaptcha?
++     * @param bool $uc     use captcha?
+      */
+-    public function __construct($enabled = true, $urc = false)
++    public function __construct($enabled = true, $uc = false)
+     {
+         $this->enabled = $enabled;
+     }","This looks like a dead parameter -- maybe a copy and paste error. If it's truly unused, maybe you can open a separate PR to simply delete it, and then it's one less detail to worry about here.",Why did 
+1608,"@@ -42,7 +42,11 @@ func (m *VerticaRowReader) GetNextRow() ([]values.Value, error) {
+ 	row := make([]values.Value, len(m.columns))
+ 	for i, col := range m.columns {
+ 		switch col := col.(type) {
+-		case bool, int, uint, int64, uint64, float64, string:
++		case int:
++			row[i] = values.NewInt(int64(col))
++		case uint:
++			row[i] = values.NewUInt(uint64(col))
++		case bool, int64, uint64, float64, string:
+ 			row[i] = values.New(col)
+ 		case time.Time:
+ 			row[i] = values.NewTime(values.ConvertTime(col))","Nit: Should we add support for `int` and `uint` in the `values.New()` function? That would allow us to to handle all of these types in one case. Maybe there's a good reason why we don't do that already, but I'm not sure what it is.",Why do we need to change this?
+1609,"@@ -14,7 +14,7 @@ import net.sourceforge.pmd.RuleViolation;
+ /**
+  * A {@link RuleViolation} implementation that is immutable, and therefore cache friendly
+  */
+-public final class CachedRuleViolation implements RuleViolation {
++public class CachedRuleViolation implements RuleViolation {
+ 
+     private final CachedRuleMapper mapper;
+ ","if you are not dealing with cache now, please revert these changes. On their own they make little sense",Why did you remove `final`?
+1610,"@@ -56,7 +56,7 @@ public abstract class NodeGenerator extends Generator {
+                     throw new AssertionError(f(""Wanted to regenerate a method with signature %s in %s, but it wasn't there."", callable.getSignature(), containingClassOrInterface.getNameAsString()));
+                 });
+     }
+-
++    
+     private void addMethod(
+             ClassOrInterfaceDeclaration containingClassOrInterface,
+             CallableDeclaration<?> callable,",Wearing my extra-douche-bag hat I would say not spaces on a blank line. Maybe at some point we could have some automated process remove these things. For now I would not bother changing it.,Why did you change this?
+1611,"@@ -0,0 +1,7 @@
++package de.danoeh.antennapod.core.event;
++
++public class ShowRemainTimeUpdateEvent {
++    public ShowRemainTimeUpdateEvent() {
++
++    }
++}","I think it would be better to use an `ItemUpdatedEvent` like for the ""prefer streaming"" preference. We already have a ton of events that need to be handled in all list fragments that just do the same everywhere. I think we could even remove some of the existing events in the future.",Why is this class needed?
+1612,"@@ -0,0 +1,17 @@
++class AddSlugToProducts < ActiveRecord::Migration
++  def change
++    add_column :products, :slug, :string, null: true
++
++    products = select_all(""select id, name from products"")
++    products.each do |product|
++      update(<<-SQL)
++        UPDATE products
++          SET slug='#{product[""name""].parameterize}'
++          WHERE id=#{product[""id""]}
++      SQL
++    end
++
++    change_column_null :products, :slug, false
++    add_index :products, :slug, unique: true
++  end
++end",I think we have to manually write a down for this migration.,I don't think you need to specify `parameterize` here.
+1613,"@@ -454,14 +454,13 @@ class _InternalFrame(object):
+         assert isinstance(sdf, spark.DataFrame)
+ 
+         if index_map is None:
+-            # Here is when Koalas DataFrame is created directly from Spark DataFrame.
+-            assert not any(SPARK_INDEX_NAME_PATTERN.match(name) for name in sdf.schema.names), \
++            assert not any(SPARK_INDEX_NAME_PATTERN.match(name) for name in sdf.columns), \
+                 ""Index columns should not appear in columns of the Spark DataFrame. Avoid "" \
+-                ""index colum names [%s]."" % SPARK_INDEX_NAME_PATTERN
++                ""index column names [%s]."" % SPARK_INDEX_NAME_PATTERN
+ 
+             # Create default index.
+-            index_map = [(SPARK_INDEX_NAME_FORMAT(0), None)]
+-            sdf = _InternalFrame.attach_default_index(sdf)
++            sdf, index_column = _InternalFrame.attach_default_index(sdf)
++            index_map = [(index_column, None)]
+ 
+         if NATURAL_ORDER_COLUMN_NAME not in sdf.columns:
+             sdf = sdf.withColumn(NATURAL_ORDER_COLUMN_NAME, F.monotonically_increasing_id())","I don't think we still need this check, but I'd leave it as an assertion for now.",nit: `SPARK_INDEX_NAME_PATTERN` -> `SPARK_INDEX_NAME_F
+1614,"@@ -203,4 +203,9 @@ class Cart < ActiveRecord::Base
+       0.0
+     end
+   end
++
++  # may be replaced with paper-trail or similar at some point
++  def version
++    self.updated_at.to_i
++  end
+ end","Since this may be the case, wondering if we should call the param `updated_at_i` or something so that we don't run into a problem distinguishing them down the road?",I don't think we need this method.
+1615,"@@ -215,6 +215,10 @@ namespace ScenarioMeasurement
+                 }
+                 TraceEventSession.Merge(files.ToArray(), traceFileName);
+ 
++                if (guiApp)
++                {
++                    appExe = Path.Join(workingDir, appExe);
++                }
+                 string commandLine = $""\""{appExe}\"""";
+                 if (!String.IsNullOrEmpty(appArgs))
+                 {",wondering why we need to join the paths here; seems evt.commandLine only takes whatever appExe is,Why do we need this?
+1616,"@@ -329,8 +329,14 @@ public class ConfigCenterClient {
+ 
+     public void refreshConfig(String configcenter, boolean wait) {
+       CountDownLatch latch = new CountDownLatch(1);
++      String encodeServiceName = """";
++      try {
++        encodeServiceName = URLEncoder.encode(StringUtils.deleteWhitespace(serviceName), ""UTF-8"");
++      } catch (UnsupportedEncodingException e) {
++        LOGGER.error(""encode error: {}"",e.getMessage());
++      }
++      String path = URIConst.ITEMS + ""?dimensionsInfo="" + encodeServiceName;
+       clientMgr.findThreadBindClientPool().runOnContext(client -> {
+-        String path = URIConst.ITEMS + ""?dimensionsInfo="" + StringUtils.deleteWhitespace(serviceName);
+         IpPort ipPort = NetUtils.parseIpPortFromURI(configcenter);
+         HttpClientRequest request = client.get(ipPort.getPort(), ipPort.getHostOrIp(), path, rsp -> {
+           if (rsp.statusCode() == HttpResponseStatus.OK.code()) {","1.not format code 2.failed but still continue? 3.""UTF-8"" can changed to java.nio.charset.StandardCharsets.UTF_8.name()",Why do we need to delete whitespace here?
+1617,"@@ -74,6 +74,7 @@ from typing import Any, Callable, Iterator, List, Optional, Pattern, Tuple
+ import astroid
+ import astroid.exceptions
+ from astroid import bases, nodes
++from astroid.brain import brain_dataclasses
+ 
+ from pylint.checkers import BaseChecker, utils
+ from pylint.checkers.utils import (","I'm wondering if we should add this to a `utils` module in `astroid`. Porting the util to `pylint` doesn't make sense as we would need to duplicate the globals that are being used in the function, but importing from `brain` also feels weird. @Pierre-Sassoulas Do you have an opinion?",from astroid.brain import dataclasses
+1618,"@@ -54,6 +54,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Http
+ 
+                     InitializeHeaders();
+ 
++                    if (_corruptedRequest)
++                    {
++                        await ProduceEnd();
++                        return;
++                    }
++
+                     while (!_requestProcessingStopping && !TakeMessageHeaders(SocketInput, FrameRequestHeaders))
+                     {
+                         if (SocketInput.RemoteIntakeFin)",This seems different than what we do for corrupted request headers. I would like to determine the correct behavior and consolidate this logic.,Why do we need this?
+1619,"@@ -292,7 +292,7 @@ class _RunData(object):
+         direct_access_sources = set()
+         for backend in backend_service.backends:
+             instance_group = self.find_instance_group_by_url(
+-                backend.get('group'))
++                backend.get('resourceGroup'))
+             if not instance_group:
+                 continue
+ ","Please make the change in the CAI inventory, rather than changing the scanner.",Why do we need this change?
+1620,"@@ -6,7 +6,7 @@ package net.sourceforge.pmd.lang.jsp.ast;
+ 
+ import net.sourceforge.pmd.lang.ast.AbstractNode;
+ 
+-public class AbstractJspNode extends AbstractNode implements JspNode {
++public abstract class AbstractJspNode extends AbstractNode implements JspNode {
+ 
+     protected JspParser parser;
+ ","adding this `abstract` is a breaking API change. Even though I agree it makes perfect sense to have it, we can't break this API until PMD 7.0.0. We should revert this particular change. We could make a reminder ticket like we did with #463 for 6.0.0",Why is this needed?
+1621,"@@ -16,6 +16,7 @@ describe IndividualPlan do
+ 
+   it_behaves_like 'a Plan with countable subscriptions'
+   it_behaves_like 'a Plan for public listing'
++  it_behaves_like 'Purchaseable plan'
+ 
+   describe '.active' do
+     it 'only includes active plans' do","This is following the existing convention, but I'm not sure the convention is a good one. I think it would be better to have one shared example group: - It means we don't need to add new example groups twice every time. - If the shared example group looks large, that makes it more obvious that our team models have too much shared behavior. I don't want to do anything about this right now (I'm pretty sure I can wipe out this shared example group when I change team plans), but it's good to keep in mind.",I think this should
+1622,"@@ -304,14 +304,15 @@ size_t network_prefix)
+ bool nano::server_socket::limit_reached_for_incoming_subnetwork_connections (std::shared_ptr<nano::socket> const & new_connection)
+ {
+ 	debug_assert (strand.running_in_this_thread ());
+-	if (node.flags.disable_max_peers_per_subnetwork)
++	if (node.flags.disable_max_peers_per_subnetwork || nano::transport::is_ipv4_or_v4_mapped_address (new_connection->remote.address ()))
+ 	{
+ 		// If the limit is disabled, then it is unreachable.
++		// If the address is IPv4 we don't check for a network limit, since its address space isn't big as IPv6 /64.
+ 		return false;
+ 	}
+ 	auto const counted_connections = socket_functions::count_subnetwork_connections (
+ 	connections_per_address,
+-	nano::transport::mapped_from_v4_or_v6 (new_connection->remote.address ()),
++	new_connection->remote.address ().to_v6 (),
+ 	node.network_params.network.ipv6_subnetwork_prefix_for_limiting);
+ 	return counted_connections >= node.network_params.network.max_peers_per_subnetwork;
+ }",I do not think we need to do a source code change to handle this. We could set the subnetwork to default to /32 (/128 for ipv6 ipv4-mapped),`is_ipv4_or_v4_mapp
+1623,"@@ -41,7 +41,7 @@ gboolean
+ ot_remote_builtin_delete_cookie (int argc, char **argv, GCancellable *cancellable, GError **error)
+ {
+   g_autoptr(OstreeRepo) repo = NULL;
+-  g_autoptr(GOptionContext) context = g_option_context_new (""NAME DOMAIN PATH COOKIE_NAME- Remote one cookie from remote"");
++  g_autoptr(GOptionContext) context = g_option_context_new (""NAME DOMAIN PATH COOKIE_NAME- Remove one cookie from remote"");
+ 
+   if (!ostree_option_context_parse (context, option_entries, &argc, &argv,
+                                     OSTREE_BUILTIN_FLAG_NONE, &repo, cancellable, error))",It looks good overall! The only issue I have is that the description string is now duplicated twice right? Once in the struct and once in the parameter string? Maybe let's pass the struct to the command so that `ostree_option_context_parse` can set it as the summary? Similar to what we do in rpm-ostree.,I think this should
+1624,"@@ -29,7 +29,7 @@ import org.openqa.selenium.remote.service.DriverService;
+  *
+  * @see <a href=""https://chromium.googlesource.com/chromium/src/+/master/chrome/test/chromedriver/client/command_executor.py"">List of ChromeWebdriver commands</a>
+  */
+-class ChromeDriverCommandExecutor extends DriverCommandExecutor {
++public class ChromeDriverCommandExecutor extends DriverCommandExecutor {
+ 
+   private static final ImmutableMap<String, CommandInfo> CHROME_COMMAND_NAME_TO_URL = ImmutableMap.of(
+       ChromeDriverCommand.LAUNCH_APP,",This states very clearly that this is a derivative of Chrome and not Chromium. Do we need to extract an abstract `ChromiumCommandExecutor` and have both Edge and Chrome derive from that?,Why is this public?
+1625,"@@ -84,7 +84,9 @@ public class CompareObjectsWithEqualsRule extends AbstractJavaRule {
+                 ASTReferenceType type1 = ((Node) nd1.getAccessNodeParent())
+                         .getFirstDescendantOfType(ASTReferenceType.class);
+                 // skip, if it is an enum
+-                if (type0.getType() != null && type0.getType().equals(type1.getType()) && type0.getType().isEnum()) {
++                if (type0.getType() != null && type0.getType().equals(type1.getType())
++                    // It may be a custom enum class or an explicit Enum class usage
++                    && (type0.getType().isEnum() || type0.getType() == java.lang.Enum.class)) {
+                     return data;
+                 }
+ ","it seems to me, the issue lies on `isEnum()` itself, returning false for something that is an enum. I'd rather change it there than here.",Why is this change 
+1626,"@@ -49,6 +49,15 @@ class QuteSchemeHandler(schemehandler.SchemeHandler):
+ 
+     """"""Scheme handler for qute: URLs.""""""
+ 
++    handlers = dict()
++
++    @classmethod
++    def addHandler(cls, name):
++        """"""Add a handler to the qute: sheme.""""""
++        def namedecorator(function):
++            cls.handlers[name] = function
++        return namedecorator
++
+     def createRequest(self, _op, request, _outgoing_data):
+         """"""Create a new request.
+ ",Please use `{}` instead of `dict()`,Why is this a class
+1627,"@@ -20,11 +20,12 @@
+  * External dependencies
+  */
+ import PropTypes from 'prop-types';
++import { useInView } from 'react-intersection-observer';
+ 
+ /**
+  * WordPress dependencies
+  */
+-import { useCallback } from '@wordpress/element';
++import { useCallback, useEffect } from '@wordpress/element';
+ import { __ } from '@wordpress/i18n';
+ 
+ /**",I have concerns about using this in more places before #3278 - I'll take a look at that again shortly.,I think this should
+1628,"@@ -37,7 +37,16 @@ func TestConvert(t *testing.T) {
+ 	testLog := newTestLog()
+ 	testLog.Topics = topics
+ 	testLog.NotFixTopicCopyBug = true
+-	receipt := &Receipt{1, 1, hash.ZeroHash256, 1, ""test"", []*Log{testLog}, nil, ""balance not enough""}
++	receipt := &Receipt{
++		Status:             1,
++		BlockHeight:        1,
++		ActionHash:         hash.ZeroHash256,
++		GasConsumed:        1,
++		ContractAddress:    ""test"",
++		TxIndex:            1,
++		logs:               []*Log{testLog},
++		executionRevertMsg: ""balance not enough"",
++	}
+ 
+ 	typeReceipt := receipt.ConvertToReceiptPb()
+ 	require.NotNil(typeReceipt)",new field needs to be asserted,Why do we need this change?
+1629,"@@ -190,6 +190,7 @@ void Host::appendLogsInternal(folly::EventBase* eb,
+             {
+                 std::lock_guard<std::mutex> g(self->lock_);
+                 self->setResponse(r);
++                self->lastLogIdSent_ = self->logIdToSend_;
+             }
+             self->noMoreRequestCV_.notify_all();
+             return;","when send log failed, why update the last sent log id?",Why do we need this?
+1630,"@@ -127,12 +127,12 @@ public final class Tuple0 implements Tuple, Comparable<Tuple0>, Serializable {
+     }
+ 
+     @Override
+-    public <T> Tuple1<T> prepend(T value) {
++    public <T> Tuple1<T> append(T value) {
+        return new Tuple1<>(value);
+     }
+ 
+     @Override
+-    public <T> Tuple1<T> append(T value) {
++    public <T> Tuple1<T> prepend(T value) {
+        return new Tuple1<>(value);
+     }
+ ","what was the problem with the previous order? `prepend` comes conceptually before `append`, i.e. `insert before` should be before `insert after`, I think",Why did you change this?
+1631,"@@ -291,6 +291,8 @@ type BackupInfo struct {
+ 	// Timestamp is the timestamp at which the source volume
+ 	// was backed up to cloud
+ 	Timestamp time.Time
++	// Metadata associated with the backup
++	Metadata map[string]string
+ 	// Status indicates if this backup was successful
+ 	Status string
+ }",Why is this necessary? Could you provide some context?,I think this should be a `m
+1632,"@@ -46,7 +46,9 @@ public class HTMLTestResults {
+   private final HTMLSuiteResult suite;
+ 
+   private static final String HEADER = ""<html>\n"" +
+-      ""<head><style type='text/css'>\n"" +
++      ""<head>\n""+
++      ""<meta charset=\""UTF-8\"">\n""+
++      ""<style type='text/css'>\n"" +
+       ""body, table {\n"" +
+       ""    font-family: Verdana, Arial, sans-serif;\n"" +
+       ""    font-size: 12;\n"" +","Is there a recommended quote style for attributes? I see single and double here, double further down.",Why is this needed?
+1633,"@@ -772,6 +772,17 @@ var _ = Describe(""Session"", func() {
+ 			Expect(mconn.written[0][0] & 0x02).ToNot(BeZero()) // Public Reset
+ 			Expect(sess.runClosed).To(BeClosed())
+ 		})
++
++		It(""unblocks WaitUntilClosed when the run loop exists"", func() {
++			returned := make(chan struct{})
++			go func() {
++				sess.WaitUntilClosed()
++				close(returned)
++			}()
++			Consistently(returned).ShouldNot(BeClosed())
++			sess.Close(nil)
++			Eventually(returned).Should(BeClosed())
++		})
+ 	})
+ 
+ 	Context(""receiving packets"", func() {",Please use an atomic bool.,I think we should a
+1634,"@@ -0,0 +1,19 @@
++namespace Datadog.Trace.ClrProfiler
++{
++    internal static class WebHelpers
++    {
++        public static void DecorateWebSpan(
++            this Span span,
++            string resourceName,
++            string method,
++            string host,
++            string httpUrl)
++        {
++            span.Type = SpanTypes.Web;
++            span.ResourceName = resourceName;
++            span.SetTag(Tags.HttpMethod, method);
++            span.SetTag(Tags.HttpRequestHeadersHost, host);
++            span.SetTag(Tags.HttpUrl, httpUrl);
++        }
++    }
++}",Consider naming this class `SpanExtensions` to follow C# conventions.,I'm not sure if thi
+1635,"@@ -81,11 +81,6 @@ namespace Datadog.Trace.Logging
+             {
+                 // Don't let this exception bubble up as this logger is for debugging and is non-critical
+             }
+-            finally
+-            {
+-                // Log some information to correspond with the app domain
+-                SharedLogger.Information(FrameworkDescription.Create().ToString());
+-            }
+         }
+ 
+         public static ILogger GetLogger(Type classType)","FYI @lucaspimentel and @colin-higgins since you have already approved, I wanted to point out this required change. By fixing `FrameworkDescription` to use the correct logger, it created a cycle between these two static constructors, so I'm removing this log line and delaying it to when it's actually constructed later in the Tracer. Let me know if you find that acceptable or have any suggestions.",Why was this remove
+1636,"@@ -34,6 +34,8 @@ module Beaker
+           Beaker::Fusion
+         when /blimpy/
+           Beaker::Blimper
++        when /ec2/
++          Beaker::AwsSdk
+         when /vcloud/
+           if options['pooling_api']
+             Beaker::VcloudPooled","Ah, so we are going to need to update node/host files for this to work?",I don't think this is needed.
+1637,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+ 
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users.",Why is this change needed?
+1638,"@@ -11,9 +11,15 @@ class ObservationsController < ApplicationController
+   end
+ 
+   def destroy
+-    self.observation.destroy
+-    flash[:success] = ""Deleted Observation""
+-    redirect_to proposal_path(self.observation.proposal_id)
++    proposal = observation.proposal
++    if current_user == observation.user
++      redirect_path = ""/proposals""
++    else
++      redirect_path = proposal_path(proposal)
++    end
++    observation.destroy
++    flash[:success] = ""Deleted Observation for #{proposal.public_id}""
++    redirect_to redirect_path
+   end
+ 
+   protected",used named path (`proposals_path`) instead?,Shouldn't this be `if current
+1639,"@@ -107,7 +107,10 @@ class Sierra extends AbstractBase implements TranslatorAwareInterface
+             . ""FROM sierra_view.bib_view ""
+             . ""LEFT JOIN sierra_view.bib_record_item_record_link ON ""
+             . ""(bib_view.id = bib_record_item_record_link.bib_record_id) ""
+-            . ""WHERE bib_view.record_num = $1;"";
++            . ""INNER JOIN sierra_view.item_view ON ""
++            . ""(bib_record_item_record_link.item_record_id = item_view.id ""
++            . ""WHERE bib_view.record_num = $1 ""
++            . ""AND item_view.is_suppressed = false;"";
+         $record_ids = pg_query_params(
+             $this->db, $get_record_ids_query, [$this->idStrip($id)]
+         );","Am I misreading something, or is there a mismatched parenthesis here? Please let me know whether or not this is cause for concern -- just wanted to be totally sure before merging, since I can't test this from here. Thanks!",Please use `AND` instead of `
+1640,"@@ -256,6 +256,13 @@ func (o *Outbound) call(ctx context.Context, treq *transport.Request) (*transpor
+ 
+ 	span.SetTag(""http.status_code"", response.StatusCode)
+ 
++	// Service name match validation, return yarpcerrors.CodeInternal error if not match
++	if match, resSvcName := checkServiceMatch(treq.Service, response.Header); !match {
++		return nil, transport.UpdateSpanWithErr(span,
++			yarpcerrors.InternalErrorf(""service name sent from the request ""+
++				""does not match the service name received in the response, sent %q, got: %q"", treq.Service, resSvcName))
++	}
++
+ 	tres := &transport.Response{
+ 		Headers:          applicationHeaders.FromHTTPHeaders(response.Header, transport.NewHeaders()),
+ 		Body:             response.Body,",Might we want a hook to allow emitting metrics or logs in the case of a permitted empty service header response (or similar UpdateSpanWithErr on empty service header in response if strict enforcement is desired by the caller)?,"I don't think we need to return an error here. If the service name doesn't match, we should return an error."
+1641,"@@ -63,6 +63,7 @@ class AzureBlobClient(FileSystem):
+             * `token_credential` - A token credential used to authenticate HTTPS requests. The token value should be updated before its expiration.
+         """"""
+         self.options = {""account_name"": account_name, ""account_key"": account_key, ""sas_token"": sas_token}
++        kwargs[""protocol""] = kwargs.get(""protocol"") or ""https""  # Default protocol to https if it's not set
+         self.kwargs = kwargs
+ 
+     @property","if using dict.get, this could just be `kwargs.get('protocol', 'https')`","I don't think this is the right way to do this. If the protocol is not set, we should default to https."
+1642,"@@ -443,6 +443,14 @@ public class SurfaceNamer extends NameFormatterDelegator {
+     return getNotImplementedString(""SurfaceNamer.getAsyncApiMethodExampleName"");
+   }
+ 
++  public String getGrpcStreamingApiMethodName(Method method) {
++    return getApiMethodName(method);
++  }
++
++  public String getGrpcStreamingApiMethodExampleName(Interface interfaze, Method method) {
++    return getGrpcStreamingApiMethodName(method);
++  }
++
+   /**
+    * The name of a variable to hold a value for the given proto message field
+    * (such as a flattened parameter).",Add docs to the new methods here,Why is interfaze needed here?
+1643,"@@ -28,9 +28,11 @@ namespace Nethermind.Trie.Pruning
+             _memoryLimit = memoryLimit;
+         }
+ 
++        public bool Enabled => true;
++
+         public bool ShouldPrune(in long currentMemory)
+         {
+             return currentMemory >= _memoryLimit;
+         }
+     }
+-}
++}",what does it mean enabled?,Why do we need this?
+1644,"@@ -128,7 +128,7 @@ public class SmartStore  {
+     public static synchronized void changeKey(SQLiteDatabase db, String oldKey, String newKey) {
+     	synchronized(db) {
+ 	        if (newKey != null && !newKey.trim().equals("""")) {
+-	            db.execSQL(""PRAGMA rekey = '"" + newKey + ""'"");
++	            db.query(""PRAGMA rekey = '"" + newKey + ""'"");
+ 	            DBOpenHelper.reEncryptAllFiles(db, oldKey, newKey);
+ 	        }
+     	}","Getting an error when calling with db.execSQL (in sqlcipher 4.3.0, pragma returns ok).",Why this change?
+1645,"@@ -83,11 +83,11 @@ func retrieveFeeds(ctx *middleware.Context, ctxUserID, userID, offset int64, isP
+ }
+ 
+ func Dashboard(ctx *middleware.Context) {
+-	ctx.Data[""Title""] = ctx.Tr(""dashboard"")
++  ctxUser := getDashboardContextUser(ctx)
++	ctx.Data[""Title""] = ctxUser.DisplayName() + "" "" + ctx.Tr(""dashboard"")
+ 	ctx.Data[""PageIsDashboard""] = true
+ 	ctx.Data[""PageIsNews""] = true
+ 
+-	ctxUser := getDashboardContextUser(ctx)
+ 	if ctx.Written() {
+ 		return
+ 	}","Maybe we could remove `"" "" + ctx.Tr(""dashboard"")` completely?",Shouldn't this b
+1646,"@@ -1,13 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-# SPDX - License - Identifier: Apache - 2.0
++# SPDX-License-Identifier: Apache-2.0
++
++# Purpose
++# This code demonstrates how to copy an object from one Amazon Simple Storage Solution (Amazon S3) bucket to another,
++# changing the object's server-side encryption state during the copy operation.
+ 
+ # snippet-start:[s3.ruby.copy_object_encrypt_copy.rb]
+ require 'aws-sdk-s3'
+ 
+-# Copies an object from one Amazon S3 bucket to another,
+-#   changing the object's server-side encryption state during 
+-#   the copy operation.
+-#
+ # Prerequisites:
+ #
+ # - A bucket containing an object to be copied.",Simple Storage **Service**,I'm not sure if 
+1647,"@@ -42,6 +42,15 @@ type jsonHandler struct {
+ 	handler reflect.Value
+ }
+ 
++type jsonHandler2 struct {
++	handler reflect.Value
++}
++
++func (h jsonHandler2) Handle(ctx context.Context, reqBody interface{}) (interface{}, error) {
++	results := h.handler.Call([]reflect.Value{reflect.ValueOf(ctx), reflect.ValueOf(reqBody)})
++	return results[0].Interface(), results[1].Interface().(error)
++}
++
+ func (h jsonHandler) Handle(ctx context.Context, req *yarpc.Request, reqBuf *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
+ 	if err := yarpcencoding.ExpectEncodings(req, Encoding); err != nil {
+ 		return nil, nil, err",Let's add some assertions here to ensure we don't panic. Length of results. Conditionally cast second result to error.,Why do we need t
+1648,"@@ -23,8 +23,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+         // Matches the default LimitRequestFields in Apache httpd.
+         private int _maxRequestHeaderCount = 100;
+ 
+-        // Matches the default http.sys connection timeout.
+-        private TimeSpan _connectionTimeout = TimeSpan.FromMinutes(2);
++        // Matches the default http.sys connectionTimeout.
++        private TimeSpan _keepAliveTimeout = TimeSpan.FromMinutes(2);
++
++        private TimeSpan _requestHeadersTimeout = TimeSpan.FromSeconds(30);
+ 
+         /// <summary>
+         /// Gets or sets the maximum size of the response buffer before write",Where did we take this default from?,Should this be configurable?
+1649,"@@ -122,6 +122,8 @@ const baseSelectors = {
+ 	 * @param {Object}         options                     Options for generating the report.
+ 	 * @param {string}         options.startDate           Required, unless dateRange is provided. Start date to query report data for as YYYY-mm-dd.
+ 	 * @param {string}         options.endDate             Required, unless dateRange is provided. End date to query report data for as YYYY-mm-dd.
++	 * @param {string}         [options.compareStartDate]  Optional. Start date to compare report data for as YYYY-mm-dd.
++	 * @param {string}         [options.compareEndDate]    Optional. End date to compare report data for as YYYY-mm-dd.
+ 	 * @param {string}         options.dateRange           Required, alternative to startDate and endDate. A date range string such as 'last-28-days'.
+ 	 * @param {boolean}        [options.compareDateRanges] Optional. Only relevant with dateRange. Default false.
+ 	 * @param {boolean}        [options.multiDateRange]    Optional. Only relevant with dateRange. Default false.",Let's move these down to be after all required arguments rather than in between.,I don't think we need to add
+1650,"@@ -90,6 +90,10 @@ namespace FlatBuffers
+             _objectStart = 0;
+             _numVtables = 0;
+             _vectorNumElems = 0;
++            if (_sharedStringMap != null)
++            {
++                _sharedStringMap.Clear();
++            }
+         }
+ 
+         /// <summary>","Should we just null the Map and let the GC handle the memory? Clearing just removes items, but not capacity, so this would leave some memory on the table.",Why is this needed?
+1651,"@@ -107,7 +107,8 @@ func (i *Inbound) start() error {
+ 		return errRouterNotSet
+ 	}
+ 
+-	handler := newHandler(i)
++	handler := newHandler(i, i.t.options.logger)
++	// handler := &handler{i: i, logger: i.t.options.logger}
+ 
+ 	server := grpc.NewServer(
+ 		grpc.CustomCodec(customCodec{}),",did you mean to delete this line?,Remove this line?
+1652,"@@ -420,6 +420,10 @@ public class DatasetField implements Serializable {
+         } else if (template != null) {
+             return template.getDataverse();
+         } else {
++
++            System.out.print(""getDataverseException: "" + this.datasetFieldType.getDisplayName());
++            System.out.print(""getDataverseException Compound: "" + this.getCompoundDisplayValue());
++            System.out.print(""getDataverseException Regular: "" + this.getDisplayValue());
+             throw new IllegalStateException(""DatasetField is in an illegal state: no dataset version, compound value, or template is set as its parent."");
+         }
+     }",Should we use logger instead?,This should be removed.
+1653,"@@ -5,7 +5,7 @@ describe AnalyticsHelper do
+     it ""is true when ENV['ANALYTICS'] is present"" do
+       ENV['ANALYTICS'] = 'anything'
+ 
+-      expect(analytics?).to be_true
++      expect(analytics?).to be true
+ 
+       ENV['ANALYTICS'] = nil
+     end",I think it would be preferred to do `expect(helper).to be_analytics`,I think this should be 
+1654,"@@ -10089,7 +10089,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+ 
+         if key is None:
+             raise KeyError(""none key"")
+-        if isinstance(key, (str, tuple, list)):
++        if isinstance(key, (str, tuple, list, pd.Index)):
+             return self.loc[:, key]
+         elif isinstance(key, slice):
+             if any(type(n) == int or None for n in [key.start, key.stop]):","Actually, I think it's okay to just change to `if isinstance(key, (str)) or is_list_like(key):` and `key = list(key) if is_list_like(key) else key` for simplicity for now.",I think this should be 
+1655,"@@ -183,7 +183,7 @@ func (s *resetorSuite) TestResetWorkflowExecution_NoReplication() {
+ 	currRunID := uuid.New().String()
+ 	we := commonpb.WorkflowExecution{
+ 		WorkflowId: wid,
+-		RunId:      forkRunID,
++		RunId:      """",
+ 	}
+ 	request.ResetRequest = &workflowservice.ResetWorkflowExecutionRequest{
+ 		Namespace:                 ""testNamespace"",","If there any other tests, I would make it optional there also.",Why is this change need
+1656,"@@ -54,6 +54,7 @@ Workshops::Application.routes.draw do
+   end
+ 
+   match '/watch' => 'high_voltage/pages#show', as: :watch, id: 'watch'
++  match '/my-accounts' => 'high_voltage/pages#show', as: :watch, id: 'my-accounts'
+ 
+   match '/directions' => ""high_voltage/pages#show"", as: :directions, id: ""directions""
+   match '/group-training' => ""high_voltage/pages#show"", as: :group_training, id: ""group-training""","This can be removed too, right?",I think this should be `/my-account`
+1657,"@@ -248,7 +248,7 @@ public class SettingsExporter {
+ 
+ 
+         // Write outgoing server settings
+-        ServerSettings outgoing = Transport.decodeTransportUri(account.getTransportUri());
++        ServerSettings outgoing = Transport.decodeTransportUri(account.getTransportUri(0));
+         serializer.startTag(null, OUTGOING_SERVER_ELEMENT);
+         serializer.attribute(null, TYPE_ATTRIBUTE, outgoing.type);
+ ","If you're going to allow people to specify multiple SMTP servers, you should also properly export/import them.",Why do we need this change?
+1658,"@@ -28,5 +28,14 @@ namespace Datadog.Trace.RuntimeMetrics
+         public const string CpuUserTime = ""runtime.dotnet.cpu.user"";
+         public const string CpuSystemTime = ""runtime.dotnet.cpu.system"";
+         public const string CpuPercentage = ""runtime.dotnet.cpu.percent"";
++
++        public const string CurrentRequests = ""runtime.dotnet.aspnetcore.requests.current"";
++        public const string FailedRequests = ""runtime.dotnet.aspnetcore.requests.failed"";
++        public const string TotalRequests = ""runtime.dotnet.aspnetcore.requests.total"";
++        public const string RequestQueueLength = ""runtime.dotnet.aspnetcore.requests.queue_length"";
++
++        public const string CurrentConnections = ""runtime.dotnet.aspnetcore.connections.current"";
++        public const string ConnectionQueueLength = ""runtime.dotnet.aspnetcore.connections.queue_length"";
++        public const string TotalConnections = ""runtime.dotnet.aspnetcore.connections.total"";
+     }
+ }",nit: Can we prefix these variables with `AspNetCore`?,I think these should be `runtime.dot
+1659,"@@ -47,12 +47,18 @@ describe ""transpiling YAML plans"" do
+   }
+   PLAN
+ 
+-  it 'transpiles a yaml plan' do
++  it 'transpiles a YAML plan from a path' do
+     expect {
+       run_cli(%W[plan convert #{plan_path}])
+     }.to output(output_plan).to_stdout
+   end
+ 
++  it 'transpiles a YAML plan from a plan name' do
++    expect {
++      run_cli(%W[plan convert yaml::conversion -m #{modulepath}])
++    }.to output(output_plan).to_stdout
++  end
++
+   it 'plan show output is the same for the original plan and converted plan', ssh: true do
+     Dir.mktmpdir do |tmpdir|
+       FileUtils.mkdir_p(File.join(tmpdir, 'plans'))",Can this also include a quick test for transpiling by name?,I think this should be `yaml::conver
+1660,"@@ -59,10 +59,11 @@ func (client *clientRest) NodeRegister(proposal dto_discovery.ServiceProposal) (
+ 	return
+ }
+ 
+-func (client *clientRest) NodeSendStats(nodeKey string, sessionList []dto.SessionStatsDeprecated) (err error) {
++func (client *clientRest) NodeSendStats(nodeKey string) (err error) {
+ 	response, err := client.doPostRequest(""node_send_stats"", dto.NodeStatsRequest{
+-		NodeKey:  nodeKey,
+-		Sessions: sessionList,
++		NodeKey: nodeKey,
++		// TODO: remove this struct in favor of `SessionStats`
++		Sessions: []dto.SessionStats{},
+ 	})
+ 	if err == nil {
+ 		defer response.Body.Close()",This TODO can be removed,Why do we need to remove this?
+1661,"@@ -5,13 +5,13 @@ using UIKit;
+ 
+ namespace MvvmCross.iOS.Support.Presenters
+ {
+-	public interface IMvxTabBarViewController
+-	{
+-		void ShowTabView(UIViewController viewController, bool wrapInNavigationController, string tabTitle, string tabIconName);
++    public interface IMvxTabBarViewController
++    {
++        void ShowTabView(UIViewController viewController, bool wrapInNavigationController, string tabTitle, string tabIconName, string tabAccessibilityIdentifier);
+ 
+-		bool ShowChildView(UIViewController viewController);
++        bool ShowChildView(UIViewController viewController);
+ 
+-		bool CloseChildViewModel(IMvxViewModel viewModel);
+-	}
++        bool CloseChildViewModel(IMvxViewModel viewModel);
++    }
+ }
+ ",can we make tabAccessibilityIdentifier = null as default?,"This is a breaking change, ple"
+1662,"@@ -80,8 +80,9 @@ func initProvider() func() {
+ 	pusher.Start()
+ 
+ 	return func() {
+-		bsp.Shutdown() // shutdown the processor
+-		handleErr(exp.Shutdown(context.Background()), ""failed to stop exporter"")
++		ctx := context.Background()
++		_ = bsp.Shutdown(ctx) // shutdown the processor
++		handleErr(exp.Shutdown(ctx), ""failed to stop exporter"")
+ 		pusher.Stop() // pushes any last exports to the receiver
+ 	}
+ }",Should we print this error?,Why is this necessary?
+1663,"@@ -31,7 +31,7 @@ def multiclass_nms(multi_bboxes,
+         tuple: (bboxes, labels, indices (optional)), tensors of shape (k, 5),
+             (k), and (k). Labels are 0-based.
+     """"""
+-    num_classes = multi_scores.size(1) - 1
++    num_classes = int(multi_scores.size(1) - 1)
+     # exclude background category
+     if multi_bboxes.shape[1] > 4:
+         bboxes = multi_bboxes.view(multi_scores.size(0), -1, 4)",For which reason do we need to convert this to int here?,I think this should be `int(mu
+1664,"@@ -19,7 +19,7 @@ func setFreezer(dirPath string, state configs.FreezerState) error {
+ 		// freeze the container (since without the freezer cgroup, that's a
+ 		// no-op).
+ 		if state == configs.Undefined || state == configs.Thawed {
+-			err = nil
++			return nil
+ 		}
+ 		return errors.Wrap(err, ""freezer not supported"")
+ 	}","FWIW, wondering if the error is interesting here (I actually arrived at this code initially to change `supportsFreezer()` to return a `bool`","I think this should be `return errors.New(""freezer not supported"")`"
+1665,"@@ -1,8 +1 @@
+-<h1><%= plan.title %></h1> 
+-
+-<% if plan.visibility == 'is_test' %>
+-  <div class=""roadmap-info-box"">
+-    <i class=""fa fa-exclamation-circle"" aria-hidden=""true""></i>
+-    <span><%= _('This is a') %> <strong><%= _('test plan') %></strong>.</span>
+-  </div>
+-<% end %>
++<h1><%= plan.title %></h1> ",Does this still need to be a partial? is the intention down the line to move back towards a conditionally different title?,Why is this being removed?
+1666,"@@ -107,13 +107,12 @@ func TestEnvAdd_Execute(t *testing.T) {
+ 				prog:          mockSpinner,
+ 			},
+ 			expectedEnv: archer.Environment{
+-				Name:    ""env"",
+-				Project: ""project"",
+-				//TODO update these to real values
+-				AccountID:          ""1234"",
+-				Region:             ""1234"",
+-				Prod:               true,
+-				PublicLoadBalancer: true,
++				Name:        ""env"",
++				Project:     ""project"",
++				AccountID:   ""1234"",
++				Region:      ""1234"",
++				RegistryURL: ""902697171733.dkr.ecr.eu-west-3.amazonaws.com/project/env"",
++				Prod:        true,
+ 			},
+ 			mocking: func() {
+ 				gomock.InOrder(",seems like `RegistryURL` is missing? Same for a few other places that create `archer.Environment` below.,Why did you remove this test case?
+1667,"@@ -14,7 +14,9 @@
+ 
+ import abc
+ import logging
++import datetime
+ import parameter
++import target
+ import warnings
+ import traceback
+ import pyparsing as pp",Are these imports needed?,I don't think we need this import.
+1668,"@@ -139,6 +139,13 @@ describe('text.formControlValue', function() {
+ 				axe.utils
+ 					.querySelectorAll(axe._tree[0], '#fixture input')
+ 					.forEach(function(target) {
++						// Safari and IE11 do not support the color input type
++						// and thus treat them as text inputs. ignore fallback
++						// inputs
++						if (target.actualNode.type === 'text') {
++							return;
++						}
++
+ 						assert.equal(
+ 							nativeTextboxValue(target),
+ 							'',","I think you can remove the `(isIE11 ? it.skip : it)(` above, if you're going to skip the test this way.",I don't think this is the right way to do this.
+1669,"@@ -96,11 +96,12 @@ public class CopyOneFile implements Closeable {
+         // Paranoia: make sure the primary node is not smoking crack, by somehow sending us an already corrupted file whose checksum (in its
+         // footer) disagrees with reality:
+         long actualChecksumIn = in.readLong();
+-        if (actualChecksumIn != checksum) {
++        // CheckSum is written in Big Endian so we need to reverse bytes
++        if (actualChecksumIn != Long.reverseBytes(checksum)) {
+           dest.message(""file "" + tmpName + "": checksum claimed by primary disagrees with the file's footer: claimed checksum="" + checksum + "" vs actual="" + actualChecksumIn);
+           throw new IOException(""file "" + name + "": checksum mismatch after file copy"");
+         }
+-        out.writeLong(checksum);
++        out.writeLong(actualChecksumIn);
+         bytesCopied += Long.BYTES;
+         close();
+ ",IMO we should instead fix the above call to do `long actualChecksumIn = Long.reverseBytes(in.readLong());` to get the actual checksum value? This way the below error message would also be correct?,Why do we need to reverse bytes here?
+1670,"@@ -512,6 +512,13 @@ func prune(opts PruneOptions, gopts GlobalOptions, repo restic.Repository, usedB
+ 		DeleteFiles(gopts, repo, removePacksFirst, restic.PackFile)
+ 	}
+ 
++	// delete obsolete index files (index files that have already been superseded)
++	obsoleteIndexes := (repo.Index()).(*repository.MasterIndex).Obsolete()
++	if len(obsoleteIndexes) != 0 {
++		Verbosef(""deleting unused index files...\n"")
++		DeleteFiles(gopts, repo, obsoleteIndexes, restic.IndexFile)
++	}
++
+ 	if len(repackPacks) != 0 {
+ 		Verbosef(""repacking packs\n"")
+ 		bar := newProgressMax(!gopts.Quiet, uint64(len(repackPacks)), ""packs repacked"")",I think we also need something similar for `rebuild-index`?,I think this should be `if len(obsoleteIndexes)
+1671,"@@ -20,12 +20,14 @@ import (
+ 	""github.com/spiffe/spire/pkg/common/telemetry""
+ 	""github.com/spiffe/spire/pkg/common/util""
+ 	""github.com/spiffe/spire/pkg/server""
++	bundleClient ""github.com/spiffe/spire/pkg/server/bundle/client""
+ )
+ 
+ const (
+-	defaultConfigPath = ""conf/server/server.conf""
+-	defaultSocketPath = ""/tmp/spire-registration.sock""
+-	defaultLogLevel   = ""INFO""
++	defaultConfigPath         = ""conf/server/server.conf""
++	defaultSocketPath         = ""/tmp/spire-registration.sock""
++	defaultLogLevel           = ""INFO""
++	defaultBundleEndpointPort = 443
+ )
+ 
+ // runConfig represents available configurables for file and CLI options",I think convention is snake case for import naming?,nit: can we call this `defaultBundlePort`?
+1672,"@@ -303,7 +303,13 @@ public class TiDAGRequest implements Serializable {
+         // double read case
+         if (!hasPk) {
+           // add handle column
+-          indexScanBuilder.addColumns(handleColumn);
++          if (!tableInfo.isCommonHandle()) {
++            indexScanBuilder.addColumns(handleColumn);
++          } else {
++            for (TiIndexColumn col : tableInfo.getPrimaryKey().getIndexColumns()) {
++              indexScanBuilder.addColumns(tableInfo.getColumn(col.getName()).toProto(tableInfo));
++            }
++          }
+           ++colCount;
+           addRequiredIndexDataType();
+         }",i think haspk is false?,Why do we need to add columns for common handle?
+1673,"@@ -113,6 +113,7 @@ var opts struct {
+ 		FailingTestsOk  bool         `long:""failing_tests_ok"" hidden:""true"" description:""Exit with status 0 even if tests fail (nonzero only if catastrophe happens)""`
+ 		NumRuns         int          `long:""num_runs"" short:""n"" description:""Number of times to run each test target.""`
+ 		TestResultsFile cli.Filepath `long:""test_results_file"" default:""plz-out/log/test_results.xml"" description:""File to write combined test results to.""`
++		SurefireDir     cli.Filepath `long:""surefir_dir"" default:""plz-out/surefire-reports"" description:""Directory to copy XML test results to.""`
+ 		ShowOutput      bool         `short:""s"" long:""show_output"" description:""Always show output of tests, even on success.""`
+ 		Debug           bool         `short:""d"" long:""debug"" description:""Allows starting an interactive debugger on test failure. Does not work with all test types (currently only python/pytest, C and C++). Implies -c dbg unless otherwise set.""`
+ 		Failed          bool         `short:""f"" long:""failed"" description:""Runs just the test cases that failed from the immediately previous run.""`",you should add this to the cover command too (but let's have a more general convo about whether it's a flag or config option),This should be `plz-out/surefire-reports`
+1674,"@@ -104,7 +104,7 @@ func (s *historyArchiverSuite) SetupTest() {
+ 	s.Assertions = require.New(s.T())
+ 	s.container = &archiver.HistoryBootstrapContainer{
+ 		Logger:        log.NewNoopLogger(),
+-		MetricsClient: metrics.NewClient(scope, metrics.HistoryArchiverScope),
++		MetricsClient: metrics.NewClient(&metrics.ClientConfig{}, scope, metrics.HistoryArchiverScope),
+ 	}
+ 
+ 	s.controller = gomock.NewController(s.T())","instead of passing in pointer to empty struct, we should make it optional and support passing nil and use default cfg if it is nil.",why do we need this?
+1675,"@@ -101,7 +101,7 @@ class HashableJSON(json.JSONEncoder):
+         elif isinstance(obj, np.ndarray):
+             return obj.tolist()
+         if pd and isinstance(obj, (pd.Series, pd.DataFrame)):
+-            return repr(sorted(list(obj.to_dict().items())))
++            return obj.to_csv().encode('utf-8')
+         elif isinstance(obj, self.string_hashable):
+             return str(obj)
+         elif isinstance(obj, self.repr_hashable):","A fair bit faster, although still not great, hence also adding a hashkey.",Why is this change needed?
+1676,"@@ -0,0 +1,17 @@
++<div class=""started"">
++  <section class=""trail"">
++    <header>
++      <h1><%= trail.name %></h1>
++      <span class=""numerical-progress"">
++        <%= pluralize(
++          trail.steps_remaining_for(current_user),
++          ""step""
++        ) %> remaining
++      </span>
++    </header>
++
++    <section class=""progress"">
++      <%= render partial: ""trails/exercise"", collection: trail.exercises %>
++    </section>
++  </section>
++</div>","If we're going to leave this in here, how about we at least pull it into partial?",I think this should be `<%= trail.steps_remaining_for(current_user) %>`
+1677,"@@ -75,7 +75,7 @@ func TestCtlInstall(t *testing.T) {
+ 			testApiServer, cleanup := install_framework.NewTestInstallApiServer(t)
+ 			defer cleanup()
+ 
+-			ctx, cancel := context.WithTimeout(context.TODO(), time.Second*20)
++			ctx, cancel := context.WithTimeout(context.Background(), time.Second*40)
+ 			defer cancel()
+ 
+ 			if test.prerun {","This `context` is used correctly, there is nothing left TO DO.",Why was this changed?
+1678,"@@ -230,12 +230,9 @@ function countDocuments(coll, query, options, callback) {
+   delete options.limit;
+   delete options.skip;
+ 
+-  coll.aggregate(pipeline, options, (err, result) => {
++  coll.aggregate(pipeline, options).toArray((err, docs) => {
+     if (err) return handleCallback(callback, err);
+-    result.toArray((err, docs) => {
+-      if (err) return handleCallback(err);
+-      handleCallback(callback, null, docs.length ? docs[0].n : 0);
+-    });
++    handleCallback(callback, null, docs.length ? docs[0].n : 0);
+   });
+ }
+ ",If `docs` is an empty array there will be an error,Why did you remove the `err` check?
+1679,"@@ -150,7 +150,8 @@ func (u *staticUpstream) From() string {
+ 
+ func (u *staticUpstream) NewHost(host string) (*UpstreamHost, error) {
+ 	if !strings.HasPrefix(host, ""http"") &&
+-		!strings.HasPrefix(host, ""unix:"") {
++		!strings.HasPrefix(host, ""unix:"") &&
++		!strings.HasPrefix(host, ""quic:"") {
+ 		host = ""http://"" + host
+ 	}
+ 	uh := &UpstreamHost{","Is it really necessary to have the user specify this, or can the reverse proxy infer QUIC from the upstream's Alt-Svc headers?",Why is this change needed?
+1680,"@@ -55,7 +55,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2
+             get
+             {
+                 var dataset = new TheoryData<H2SpecTestCase>();
+-                var toSkip = new[] { ""http2/5.1/8"" };
++                var toSkip = new string[] { /*""http2/5.1/8""*/ };
+ 
+                 foreach (var testcase in H2SpecCommands.EnumerateTestCases())
+                 {",just remove the entire variable.,Why is this change needed?
+1681,"@@ -202,7 +202,10 @@ Available options are:
+       end
+       define('--modulepath MODULES',
+              ""List of directories containing modules, separated by '#{File::PATH_SEPARATOR}'"") do |modulepath|
+-        @options[:modulepath] = modulepath.split(File::PATH_SEPARATOR)
++        # When specified from the CLI, modulepath entries are relative to pwd
++        @options[:modulepath] = modulepath.split(File::PATH_SEPARATOR).map do |moduledir|
++          File.expand_path(moduledir)
++        end
+       end
+       define('--boltdir FILEPATH',
+              'Specify what Boltdir to load config from (default: autodiscovered from current working dir)') do |path|",Maybe we should put that in the option description?,This should be `File.expan
+1682,"@@ -211,8 +211,8 @@ public class BesuNodeConfigurationBuilder {
+     return this;
+   }
+ 
+-  public BesuNodeConfigurationBuilder keyFilePath(final String keyFilePath) {
+-    this.keyFilePath = Optional.of(keyFilePath);
++  public BesuNodeConfigurationBuilder keyFilePath(final Optional<String> keyFilePath) {
++    this.keyFilePath = keyFilePath;
+     return this;
+   }
+ ",Why do we need to make this optional? Isn't the idea of the builder that if you don't need this value you just don't call the `keyFilePath ` method?,Why is this change needed?
+1683,"@@ -125,7 +125,7 @@ public class Parquet {
+     public WriteBuilder forTable(Table table) {
+       schema(table.schema());
+       setAll(table.properties());
+-      metricsConfig(MetricsConfig.fromProperties(table.properties()));
++      metricsConfig(MetricsConfig.forTable(table));
+       return this;
+     }
+ ",Shall we do the same for ORC and Avro?,Why do we need to change t
+1684,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+ {
+ #if NET46",Should be a space between line,Why is this needed?
+1685,"@@ -6,7 +6,14 @@
+ 
+         public static byte[] GeneratePrivateKey()
+         {
+-            byte[] bytes = new byte[32];
++            var bytes = new byte[32];
++            SecureRandom.GetBytes(bytes);
++            return bytes;
++        }
++
++        public static byte[] GenerateRandomBytes(int lenght)
++        {
++            var bytes = new byte[lenght];
+             SecureRandom.GetBytes(bytes);
+             return bytes;
+         }","if not behind interface then equally we can use SecureRandom.GetBytes directly, otherwise let us push it behind ISecureRandom so we can test with this class wherever used",nit: typo `lenght`
+1686,"@@ -1,4 +1,4 @@
+-<figure class=""video_tutorial card"">
++<figure class=""video_tutorial tile"">
+   <%= link_to video_tutorial, title: ""The #{video_tutorial.name} online video tutorial details"" do %>
+     <h5>Video Tutorial</h5>
+     <%= image_tag(video_tutorial.product_image.url) %>","Probably will undo this change for now, as I'm just targeting Weekly Iteration in this PR.",This should be `vid
+1687,"@@ -53,8 +53,6 @@
+ 
+ static size_t expectedNumberOfContextVariables;
+ static int64_t expectedContextVariableValue;
+-static std::unordered_map<size_t, Kokkos::Tools::Experimental::SetOrRange>
+-    candidate_value_map;
+ 
+ int main() {
+   Kokkos::initialize();",Unused parameter warning? How comes we did not catch that before? In any case please open another PR for this.,Why was this remove
+1688,"@@ -60,9 +60,12 @@ def average_precision(recalls, precisions, mode='area'):
+ def tpfp_imagenet(det_bboxes,
+                   gt_bboxes,
+                   gt_bboxes_ignore=None,
++                  gt_bboxes_group_of=None,
+                   default_iou_thr=0.5,
++                  ioa_thr=None,
+                   area_ranges=None,
+-                  use_legacy_coordinate=False):
++                  use_legacy_coordinate=False,
++                  use_group_of=False):
+     """"""Check if detected bboxes are true positive or false positive.
+ 
+     Args:",I recommend move all openimage related logic to a new function,I don't think we need to add these new arguments.
+1689,"@@ -12,6 +12,8 @@ const (
+ 
+ type Cgroup struct {
+ 	Name string `json:""name""`
++	// indicates that this is an externally passed, fully created cgroup
++	ExternalCgroup bool `json:""external_cgroup""`
+ 
+ 	// name of parent cgroup or slice
+ 	Parent string `json:""parent""`","We shouldn't have a bool for this. If there is a path passed, then we use it. Resource may or may not be empty.",I don't think we need to add this field to the `C
+1690,"@@ -0,0 +1,16 @@
++<ul class=""teachers"">
++  <li>
++    <%= teacher_gravatar section_teacher.teacher, 92 %>
++    <h2>
++      <span>
++        <%= t '.header',
++              city: section_teacher.section.city,
++              count: @section_teachers.size %>
++      </span>
++      <%= section_teacher.teacher.name %>
++    </h2>
++    <section class=""bio"">
++      <%= raw textilize(section_teacher.teacher.bio) %>
++    </section>
++  </li>
++</ul>",I like how you used the count on the translate call to handle this.,This should be `<%= raw textilize(section_teacher
+1691,"@@ -139,11 +139,13 @@ class QueryBuilder implements QueryBuilderInterface
+             $finalQuery->setString($this->getNormalizedQueryString($query));
+         }
+         $string = $finalQuery->getString() ?: '*:*';
+-
+         // Highlighting is enabled if we have a field list set.
+         $highlight = !empty($this->fieldsToHighlight);
+ 
+         if ($handler = $this->getSearchHandler($finalQuery->getHandler(), $string)) {
++            if ($handler->hasDismax()) {
++                $string = $handler->prepareDismaxQueryString($string);
++            }
+             if (!$handler->hasExtendedDismax()
+                 && $this->getLuceneHelper()->containsAdvancedLuceneSyntax($string)
+             ) {","Do we need to do this from the outside, or is there a spot in the handler code where we can do this automatically? (I haven't studied it closely yet... just wondering if you've already thought it through or if it's worth taking a closer look).",Shouldn't this be `prepareDismaxQueryString`?
+1692,"@@ -0,0 +1,9 @@
++package com.fsck.k9;
++
++import java.util.*;
++
++public class SputnikTest {
++    public void sputnikTest() {
++        return;
++    }
++}",[Checkstyle] INFO: Using the '._' form of import should be avoided - java.util._.,Missing license header.
+1693,"@@ -42,6 +42,9 @@ class BaseWebTest(object):
+ 
+     def get_app_settings(self, additional_settings=None):
+         settings = cliquet_support.DEFAULT_SETTINGS.copy()
++        settings['cliquet.cache_backend'] = 'cliquet.cache.memory'
++        settings['cliquet.storage_backend'] = 'cliquet.storage.memory'
++        settings['cliquet.permission_backend'] = 'cliquet.permission.redis'
+         settings['cliquet.project_name'] = 'cloud storage'
+         settings['cliquet.project_docs'] = 'https://kinto.rtfd.org/'
+         settings['multiauth.authorization_policy'] = (","So, why everything is in memory but the permission backend?",Why is this needed?
+1694,"@@ -283,8 +283,9 @@ public class UiSetupWizardImplementation implements SetupWizard {
+      */
+     @Override
+     public String browse(String textToShow, String directory, List<String> allowedExtensions) {
++        final List<String> copiedAllowedExtensions = allowedExtensions != null ? List.copyOf(allowedExtensions) : null;
+         return messageSender.runAndWait(
+-                message -> setupUi.showBrowseStep(message, textToShow, new File(directory), allowedExtensions));
++                message -> setupUi.showBrowseStep(message, textToShow, new File(directory), copiedAllowedExtensions));
+     }
+ 
+     /**",Are you sure it should be null and not an empty List?,`copiedAllowedExtension
+1695,"@@ -22,10 +22,12 @@ namespace Microsoft.DotNet.Build.Tasks
+         // Additional Dependencies to add to the project.json. May Optionally contain a version.
+         // Will Override dependencies present in the project if there is a conflict.
+         // AdditionalDependencies required metadata:  Name, Version
+-
+         [Required]
+         public ITaskItem[] AdditionalDependencies { get; set; }
+ 
++        // Framework section which the additional dependencies apply to.  Empty is the default dependencies section.
++        public string[] Frameworks { get; set; }
++
+         public string BuildNumberOverrideStructureRegex { get; set; }
+ 
+         // Permit overriding package versions found in project.json with custom build number version.","Unfortunately I think the assumption of ""empty"" means the default dependency section is not correct. For a project.json file the default dependencies section is a shared section between all the different target frameworks and our TargetGroup being empty may map to many different target frameworks so they aren't really equated.",This is a breaking chan
+1696,"@@ -121,8 +121,8 @@ namespace Microsoft.AspNet.Server.KestrelTests
+             IDictionary<string, StringValues> headers = new FrameRequestHeaders();
+             var kv1 = new KeyValuePair<string, StringValues>(""host"", new[] { ""localhost"" });
+             var kv2 = new KeyValuePair<string, StringValues>(""custom"", new[] { ""value"" });
+-            var kv1b = new KeyValuePair<string, StringValues>(""host"", new[] { ""localhost"" });
+-            var kv2b = new KeyValuePair<string, StringValues>(""custom"", new[] { ""value"" });
++            var kv1b = new KeyValuePair<string, StringValues>(""host"", new[] { ""not-localhost"" });
++            var kv2b = new KeyValuePair<string, StringValues>(""custom"", new[] { ""not-value"" });
+ 
+             Assert.False(headers.ContainsKey(""host""));
+             Assert.False(headers.ContainsKey(""custom""));",This test was verifying the wrong thing.,Why is this change needed?
+1697,"@@ -9,7 +9,7 @@ const build = (buildConfig = config.defaultBuildConfig, options) => {
+     util.updateBranding()
+   }
+ 
+-  util.buildMuon()
++  util.buildMuon('brave')
+ }
+ 
+ module.exports = build",pls pr a name change fro muon here too separately.,Why is this needed?
+1698,"@@ -198,7 +198,11 @@ func (opts *InitAppOpts) deployEnv() error {
+ 
+ 			return err
+ 		}
++		if err := opts.envStore.CreateEnvironment(&env); err != nil {
++			opts.spinner.Stop(""Error!"")
+ 
++			return err
++		}
+ 		opts.spinner.Stop(""Done!"")
+ 	}
+ 	return nil","nit: we can use `defer opts.spinner.Stop(""Error!"")` after l.180 to make it slightly neater",Shouldn't this be `return 
+1699,"@@ -7367,6 +7367,7 @@ check_thread_vm_area(dcontext_t *dcontext, app_pc pc, app_pc tag, void **vmlist,
+             read_lock(&executable_areas->lock);
+         ok = lookup_addr(executable_areas, pc, &area);
+         if (ok && TEST(VM_DELAY_READONLY, area->vm_flags)) {
++            bool is_allocated_mem;
+             /* need to mark region read only for consistency
+              * need to upgrade to write lock, have to release lock first
+              * then recheck conditions after grabbing hotp + write lock */",This is declared in the wrong block,This variable is not used.
+1700,"@@ -57,6 +57,10 @@ func (ctx *ChannelContext) Cleanup(module string) {
+ 
+ // Send send msg to a module. Todo: do not stuck
+ func (ctx *ChannelContext) Send(module string, message model.Message) {
++	// check if msg is sync
++	if message.Header.Sync {
++		klog.Warningf(""Get a sync-msg when use beehive.Send(),msg.Header:{%v},msg.Route:{%v}"",message.Header,message.Router)
++	}
+ 	// avoid exception because of channel colsing
+ 	// TODO: need reconstruction
+ 	defer func() {","In fact it would be useful for debug, i prefer combine them into one debug level log.",I don't think this is the right place to log this warning. I think it should be in the `Send` method.
+1701,"@@ -24,7 +24,9 @@ var alertDefine = {
+ 	crash: {
+ 		target: [
+ 			{ value: 'Total crashes', name: 'Total crashes' },
+-			{ value: 'New crash occurence', name: 'New crash occurence' }
++			{ value: 'New crash occurence', name: 'New crash occurence' },
++			{ value: 'None fatal crash per session', name: 'None fatal crash per session' },
++			{ value: 'Fatal crash per session', name: 'Fatal crash per session' },
+ 		],
+ 		condition: [
+ 			{ value: 'increased by at least', name: 'increased by at least' },","We would need to localize them eventually too, just FYI",I don't think this should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>
+1702,"@@ -70,7 +70,7 @@ void sequential_model::write_proto(lbann_data::Model* proto) {
+   model::write_proto(proto);
+   //Add layers
+   if (m_comm->am_world_master()) {
+-    proto->set_name(name());
++    proto->set_name(type());
+     for(size_t l = 0; l < m_layers.size(); l++) {
+       auto layer_proto = proto->add_layer();
+       m_layers[l]->write_proto(layer_proto);",It looks like the proto code needs to change the function name from set_name to set_type to be consistent.,Why is this change needed?
+1703,"@@ -0,0 +1,16 @@
++// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package factory
++
++//go:generate go run ../../../scripts/generate/mockgen.go github.com/aws/amazon-ecs-agent/agent/ssm/factory SSMClientCreator mocks/factory_mocks.go",I think we can avoid using this pattern for this use case.,Can we remove this file?
+1704,"@@ -25,7 +25,9 @@
+ #include <pthread.h>
+ #include <pwd.h>
+ #include <signal.h>
++#ifndef __ANDROID__
+ #include <spawn.h>
++#endif
+ #include <stdint.h>
+ #include <stdlib.h>
+ #include <string.h>",Could you please change this to `#ifndef __linux__`? That's when we use our own implementation instead of `posix_spawnp`.,Why is this needed?
+1705,"@@ -139,9 +139,10 @@ public class NodeStatus {
+     return slots.stream().anyMatch(slot -> slot.getSession() == null);
+   }
+ 
++  // Check if the Node's max session limit is not exceeded and has a free slot that supports the capability.
+   public boolean hasCapacity(Capabilities caps) {
+-    return slots.stream()
+-      .anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps));
++    return slots.stream().filter(slot -> slot.getSession() != null).count() < maxSessionCount
++           && slots.stream().anyMatch(slot -> slot.getSession() == null && slot.isSupporting(caps));
+   }
+ 
+   public int getMaxSessionCount() {",Nit: put the `&&` on the previous line so that a reader knows that there's more to the statement at a casual glance.,I think it would be
+1706,"@@ -49,6 +49,19 @@ func (t RootType) String() string {
+ 	}
+ }
+ 
++func tlfTypeToPath(t tlf.Type) string {
++	switch t {
++	case tlf.Private:
++		return string(libkbfs.PrivatePathType)
++	case tlf.Public:
++		return string(libkbfs.PublicPathType)
++	case tlf.SingleTeam:
++		return string(libkbfs.SingleTeamPathType)
++	default:
++		return ""<unknown TLF type>""
++	}
++}
++
+ // Debug tag ID for an individual FS in keybase pages.
+ const ctxOpID = ""KBP""
+ ","Technically the ""right"" variables to use would be the ones in `libgit/autogit_node_wrappers.go"", which define how the tlf types map to subdirs for autogit specifically. (They would have to be exported.) But this is fine too I guess, just a little dirtier.",I don't think you n
+1707,"@@ -27,6 +27,18 @@ class CommunicartMailer < ActionMailer::Base
+     )
+   end
+ 
++  def notification_for_approver_removed(to_email, approval, alert_partial=nil)
++    @approval = approval
++    @alert_partial = alert_partial
++    proposal = approval.proposal
++    send_proposal_email(
++      from_email: user_email_with_name(proposal.requester),
++      to_email: to_email,
++      proposal: proposal,
++      template_name: 'proposal_notification_email'
++    )
++  end
++
+   def proposal_observer_email(to_email, proposal)
+     # TODO have the from_email be whomever triggered this notification
+     send_proposal_email(",Should there be a template or something associated with this email? Right now it's identical to `notification_for_approver`,Extra empty line de
+1708,"@@ -67,8 +67,9 @@ class SliderController extends AdminBaseController
+      */
+     public function listAction()
+     {
+-        $queryBuilder = $this->getDoctrine()->getManager()->createQueryBuilder();
+-        $queryBuilder
++        /** @var \Doctrine\ORM\EntityManager $em */
++        $em = $this->getDoctrine()->getManager();
++        $queryBuilder = $em->createQueryBuilder()
+             ->select('s')
+             ->from(SliderItem::class, 's')
+             ->where('s.domainId = :selectedDomainId')",i hope there is some extension in phpstan for this,You can use `$this->em` directly.
+1709,"@@ -1025,6 +1025,7 @@ public class Dictionary {
+     assert morphSep > 0;
+     assert morphSep > flagSep;
+     int sep = flagSep < 0 ? morphSep : flagSep;
++    if (sep == 0) return 0;
+ 
+     CharSequence toWrite;
+     String beforeSep = line.substring(0, sep);","We don't store empty dictionary entries anymore: they bring no benefits, only trouble.",I don't think this is correct. It
+1710,"@@ -625,6 +625,15 @@ class CppGenerator : public BaseGenerator {
+     return false;
+   }
+ 
++  bool VectorElementUserFacing(const Type& type) const {
++    // Normally, in non-Object-API, we use the non-user-facing type when
++    // emitting the Vector element type, however in the case of enums
++    // we want to avoid that when using scoped-enums.
++    return opts_.g_cpp_std >= cpp::CPP_STD_17 &&
++           opts_.scoped_enums &&
++           IsEnum(type);
++  }
++
+   void GenComment(const std::vector<std::string> &dc, const char *prefix = """") {
+     std::string text;
+     ::flatbuffers::GenComment(dc, &text, nullptr, prefix);",Optional: This function is C++ specific and could be declared as `static`.,I'm not sure if this is the right
+1711,"@@ -831,13 +831,15 @@ public class ZMSClient implements Closeable {
+      *
+      * @param domainName name of the domain
+      * @param members    include all members for group roles as well
++     * @param tagKey     query all roles with given tag name
++     * @param tagValue  query all roles with given tag key and value
+      * @return list of roles
+      * @throws ZMSClientException in case of failure
+      */
+-    public Roles getRoles(String domainName, Boolean members) {
++    public Roles getRoles(String domainName, Boolean members, String tagKey, String tagValue) {
+         updatePrincipal();
+         try {
+-            return client.getRoles(domainName, members);
++            return client.getRoles(domainName, members, tagKey, tagValue);
+         } catch (ResourceException ex) {
+             throw new ZMSClientException(ex.getCode(), ex.getData());
+         } catch (Exception ex) {","we can't remove functions as that would introduce backward compatibility issues in our java client. So we should also have a function with the original arguments: ` public Roles getRoles(String domainName, Boolean members) { return getRoles(domainName, members, null, null); } ` For the Go client we don't have a wrapper so no option but to update your client code as necessary, but for java we have the wrapper thus we always maintain backward compatibility",I don't think we need to pass in 
+1712,"@@ -32,5 +32,12 @@ ADDITIONAL
+     def warn_deprecation(message)
+       warn message
+     end
++
++    # @private
++    #
++    # Used internally to send deprecation warnings to io
++    def warn(message)
++      RSpec.configuration.deprecation_io.puts(message)
++    end
+   end
+ end",I'd recommend keeping this in `warn_deprecation` and not adding an override of `warn`.,Should this be `RSpec.deprecation_io.warn`?
+1713,"@@ -0,0 +1,10 @@
++// Startup script for Phusion Passenger that uses next.js cli
++// Run `blitz build` before starting
++const path = require('path')
++
++const blitzPath = path.join(__dirname, 'node_modules', 'next', 'dist', 'bin', 'next');
++
++process.argv.length = 1;
++process.argv.push(blitzPath, 'start');
++
++require(blitzPath);",I think we should use a `blitz` bin instead,I think this should be `next.js`
+1714,"@@ -101,7 +101,10 @@ class DictInterface(Interface):
+ 
+     @classmethod
+     def validate(cls, dataset):
+-        dimensions = dataset.dimensions(label='name')
++        if dataset._virtual_vdims:
++            dimensions = dataset.dimensions('key', label='name')
++        else:
++            dimensions = dataset.dimensions(label='name')
+         not_found = [d for d in dimensions if d not in dataset.data]
+         if not_found:
+             raise DataError('Following columns specified as dimensions '","Why not make the ``derived_vdims`` flag (or similar, ``validate_vdims`` maybe?) an explicit argument to ``validate``?",I don't think this is the right way to do t
+1715,"@@ -155,6 +155,16 @@ func (s *VolumeServer) create(
+ 				err.Error())
+ 		}
+ 
++		if spec.IsPureVolume() {
++			id, err = s.driver(ctx).Create(locator, source, spec)
++			if err != nil {
++				return """", status.Errorf(
++					codes.Internal,
++					""Failed to create snapshot for Pure FA volume: %v"",
++					err.Error())
++			}
++			return id, nil
++		}
+ 		// Check ownership
+ 		// Snapshots just need read access
+ 		if !parent.IsPermitted(ctx, api.Ownership_Read) {",was it not possible to do this at the filter or porx driver layer? We typically try to avoid driver-specific things in the SDK layer,I'm not sure if this is the right error to 
+1716,"@@ -1,3 +1,19 @@
++/*
++ * Copyright 2012 LinkedIn Corp.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License""); you may not
++ * use this file except in compliance with the License. You may obtain a copy of
++ * the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS, WITHOUT
++ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
++ * License for the specific language governing permissions and limitations under
++ * the License.
++ */
++
+ package azkaban.user;
+ 
+ /**",please update the year. it can be setup in intellij template.,Why do we need this?
+1717,"@@ -144,6 +144,16 @@ public class PreventTokenLoggingTests {
+         passSlf4j(""log.trace(message);"");
+     }
+ 
++    @Test
++    public void testSlf4jTraceNullMessageNoArgs() {
++        passSlf4j(""log.trace(null);"");
++    }
++
++    @Test
++    public void testSlf4jTraceNullArg() {
++        passSlf4j(""log.trace(message, arg1, null);"");
++    }
++
+     @Test
+     public void testSlf4jDebug() {
+         passSlf4j(""log.debug(message, arg1);"");",what's the use-case for this?,Can you add a case f
+1718,"@@ -1281,6 +1281,9 @@ class _Frame(object):
+             raise ValueError(""Grouper for '{}' not 1-dimensional"".format(type(by)))
+         if not len(by):
+             raise ValueError('No group keys passed!')
++        if not isinstance(as_index, bool):
++            raise TypeError('as_index must be an boolean; however, '
++                            'got [%s]' % type(as_index))
+         if isinstance(df_or_s, DataFrame):
+             df = df_or_s  # type: DataFrame
+             col_by = [_resolve_col(df, col_or_s) for col_or_s in by]",nit: `as_index must be an boolean` -> `as_index must be a boolean`,I don't think this i
+1719,"@@ -26,5 +26,7 @@ interface BaseModuleInterface
+ 
+     public function postDeactivation(ConnectionInterface $con = null);
+ 
++    public function update($currentVersion, $newVersion, ConnectionInterface $con = null);
++
+     public function destroy(ConnectionInterface $con = null, $deleteModuleData = false);
+ }",What is the goal of that method ? And what are `$currentVersion` and `$newVersion` ? Are they Thelia or Module version ? :),Why do we need this?
+1720,"@@ -34,6 +34,8 @@ function assertServerError (res) {
+ }
+ 
+ module.exports = class AwsS3Multipart extends Plugin {
++  static VERSION = require('../package.json').version
++
+   constructor (uppy, opts) {
+     super(uppy, opts)
+     this.type = 'uploader'","Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?",Why do we need this?
+1721,"@@ -270,7 +270,7 @@ public class OAuthWebviewHelper {
+      * @return login url
+      */
+     protected String getLoginUrl() {
+-    	return SalesforceSDKManager.getInstance().getLoginServerManager().getSelectedLoginServer().url;
++    	return SalesforceSDKManager.getInstance().getLoginServerManager().getSelectedLoginServer().url.trim();
+     }
+ 
+     /**",Fix for URISyntaxException.,Why do we need this 
+1722,"@@ -121,6 +121,10 @@ mainLoop:
+ 				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no link index."")
+ 				continue
+ 			}
++			if routeUpd.Dst == nil {
++				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no destination"")
++				continue
++			}
+ 
+ 			idx := routeUpd.LinkIndex
+ 			oldUpds := updatesByIfaceIdx[idx]",Would be good to UT this case,Why do we need this?
+1723,"@@ -44,6 +44,8 @@ module.exports = {
+     'arrow-body-style': ['warn', 'as-needed'],
+     'no-param-reassign': ['error', { props: false }],
+     'import/prefer-default-export': 'off',
++    'import/no-extraneous-dependencies': 'off',
++    'import/no-unresolved': 'off',
+     'no-console': 'off',
+     'eol-last': ['error', 'always'],
+     'no-debugger': 'error',",Why we need to add this?,Why is this needed?
+1724,"@@ -1,6 +1,6 @@
+-require 'spec_helper'
++require 'rails_helper'
+ 
+-describe Api::V1::CompletionsController, '#show' do
++describe Api::V1::CompletionsController, '#show', type: :controller do
+   it 'returns a 401 when users are not authenticated' do
+     get :index
+     expect(response.code).to eq ""401""",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+1725,"@@ -2259,11 +2259,12 @@ type JSInfo struct {
+ 	Disabled bool            `json:""disabled,omitempty""`
+ 	Config   JetStreamConfig `json:""config,omitempty""`
+ 	JetStreamStats
+-	StreamCnt    int          `json:""total_streams,omitempty""`
+-	ConsumerCnt  int          `json:""total_consumers,omitempty""`
+-	MessageCnt   uint64       `json:""total_messages,omitempty""`
+-	MessageBytes uint64       `json:""total_message_bytes,omitempty""`
+-	Meta         *ClusterInfo `json:""meta_cluster,omitempty""`
++	APICalls  int64        `json:""current_api_calls""`
++	Streams   int          `json:""total_streams,omitempty""`
++	Consumers int          `json:""total_consumers,omitempty""`
++	Messages  uint64       `json:""total_messages,omitempty""`
++	Bytes     uint64       `json:""total_message_bytes,omitempty""`
++	Meta      *ClusterInfo `json:""meta_cluster,omitempty""`
+ 	// aggregate raft info
+ 	AccountDetails []*AccountDetail `json:""account_details,omitempty""`
+ }",This is ok to change since I believe that these were added just in main and not in public release.,I think this should be `CurrentApiCalls`
+1726,"@@ -26,7 +26,7 @@ import (
+ )
+ 
+ func MakeAuditLogsOrDie(client *Client,
+-	auditlogsName, methodName, project, resourceName, serviceName, targetName string,
++	auditlogsName, methodName, project, resourceName, serviceName, targetName, pubsubServiceAccount string,
+ 	so ...kngcptesting.CloudAuditLogsSourceOption,
+ ) {
+ 	so = append(so, kngcptesting.WithCloudAuditLogsSourceServiceName(serviceName))","Not needed in this PR, just want to make sure people think about this (maybe make an issue)? This is a lot of strings in a row. It will be hard/impossible for someone reading the code to see that everything is in the correct position. I recommend creating a struct instead of passing seven strings in a row. A similar problem exists on most of the `MakeFoo(...)` style methods in this change.",nit: `pubsubServiceAccount` -> `pubsubServiceAccount`
+1727,"@@ -197,6 +197,16 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+             {
+                 _issueLogJsonWriter.CloseResults();
+ 
++                if (_run.ConfigurationNotifications != null)
++                {
++                    _issueLogJsonWriter.WriteConfigurationNotifications(_run.ConfigurationNotifications);
++                }
++
++                if (_run.ToolNotifications != null)
++                {
++                    _issueLogJsonWriter.WriteToolNotifications(_run.ToolNotifications);
++                }
++
+                 if (_run?.Invocation?.StartTime != new DateTime())
+                 {
+                     _run.Invocation.EndTime = DateTime.UtcNow;",_jaw drops_ I would have sworn I wrote those lines. Good catch.,Should this be `_run?.Invocation?.EndTime`?
+1728,"@@ -3,6 +3,7 @@
+ 
+ // Clean up after resolve / reject
+ function cleanup() {
++	axe._memoizedFns.forEach(fn => fn.clear());
+ 	axe._cache.clear();
+ 	axe._tree = undefined;
+ 	axe._selectorData = undefined;",This needs to be tested.,Why do we need to do this?
+1729,"@@ -1019,4 +1019,18 @@ describe Mongoid::Relations::Embedded::One do
+       end
+     end
+   end
++
++  context ""when parent validation of child is set to false"" do
++
++    let(:building) do
++      building = Building.create
++      building.building_address = BuildingAddress.new
++      building.save
++      building.reload
++    end
++
++    it ""parent successfully embeds an invalid child"" do
++      expect(building.building_address).to be_a(BuildingAddress)
++    end
++  end
+ end",I believe you're missing the comparison after 'be',I don't think this test is
+1730,"@@ -94,12 +94,15 @@ func (s *KVStoreForTrie) Put(key []byte, value []byte) error {
+ func (s *KVStoreForTrie) Get(key []byte) ([]byte, error) {
+ 	trieKeystoreMtc.WithLabelValues(""get"").Inc()
+ 	v, err := s.cb.Get(s.bucket, key)
+-	if err != nil {
+-		if v, err = s.dao.Get(s.bucket, key); err != nil {
+-			return nil, errors.Wrapf(err, ""failed to get key %x"", key)
++	if errors.Cause(err) == ErrNotExist {
++		if v, err = s.dao.Get(s.bucket, key); errors.Cause(err) == ErrNotExist {
++			return nil, errors.Wrapf(ErrNotExist, ""failed to get key %x"", key)
+ 		}
+ 		// TODO: put it back to cache
+ 	}
++	if errors.Cause(err) == ErrAlreadyDeleted {
++		return nil, errors.Wrapf(ErrNotExist, ""failed to get key %x"", key)
++	}
+ 	return v, err
+ }
+ ",move 103~105 to in front of 97?,Why not use `errors.Cause(
+1731,"@@ -2,6 +2,9 @@
+ package com.fsck.k9.helper;
+ 
+ 
++import java.io.File;
++import java.io.FileOutputStream;
++import java.io.IOException;
+ import java.util.ArrayList;
+ import java.util.List;
+ import java.util.regex.Matcher;",Lots of unnecessary imports left in this file.,Why do we need this file?
+1732,"@@ -805,8 +805,9 @@ bool CoreChecks::ValidateDescriptorSetBindingData(const CMD_BUFFER_STATE *cb_nod
+         for (uint32_t i = index_range.start; i < index_range.end; ++i, ++array_idx) {
+             uint32_t index = i - index_range.start;
+             const auto *descriptor = descriptor_set->GetDescriptorFromGlobalIndex(i);
++            const auto descriptor_class = descriptor->GetClass();
+ 
+-            if (descriptor->GetClass() == DescriptorClass::InlineUniform) {
++            if (descriptor_class == DescriptorClass::InlineUniform) {
+                 // Can't validate the descriptor because it may not have been updated.
+                 continue;
+             } else if (!descriptor->updated) {",Does this actually produce different code?,Why is this change needed?
+1733,"@@ -0,0 +1,7 @@
++if (node.getAttribute('onFocus') === 'this.blur()') {
++  return false;
++}
++if (node.getAttribute('onFocus').indexOf('this.blur()') > -1) {
++  return undefined;
++}
++return true;",This should account for whitespace. Simply putting `.trim()` on the attribute value should do.,I don't think this is need
+1734,"@@ -105,6 +105,9 @@ func newVXLANManager(
+ 		blackHoleProto = dpConfig.DeviceRouteProtocol
+ 	}
+ 
++	noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
++	bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
++
+ 	brt := routetable.New(
+ 		[]string{routetable.InterfaceNone},
+ 		4,",I don't think we need these. Simpler just to put `routetable.TargetType...` inline below.,I don't think we need this
+1735,"@@ -176,6 +176,11 @@ def get_port_from_custom_rules(method, path, data, headers):
+             # assume that this is an S3 POST request with form parameters or multipart form in the body
+             return config.PORT_S3
+ 
++    if stripped and '/' in stripped:
++        if method == 'PUT':
++            # assume that this is an S3 PUT bucket object request with URL path `/<bucket>/object`
++            return config.PORT_S3
++
+     # detect S3 requests sent from aws-cli using --no-sign-request option
+     if 'aws-cli/' in headers.get('User-Agent', ''):
+         return config.PORT_S3",Nested if statement. You can merge both statements nested together to create one,I don't think this is the 
+1736,"@@ -45,6 +45,15 @@ public abstract class AbstractTest {
+         return System.getProperty(""java.version"").startsWith(""9."");
+     }
+ 
++    protected boolean isJava10() {
++        return System.getProperty(""java.version"").startsWith(""10."");
++    }
++
++    protected boolean isJavaVersionAbove9() {
++        String jdkVersion = System.getProperty(""java.version"");
++        return Integer.parseInt(jdkVersion.substring(0,jdkVersion.indexOf('.'))) >= 9;
++    }
++
+     protected boolean isJava8() {
+         return System.getProperty(""java.version"").startsWith(""1.8."");
+     }","Nitpick: add a space after the comma. Also, we should consider that the format of the version could change in the future so we could get something that is not a parsable integer.",I think this should be `isJava10`
+1737,"@@ -31,7 +31,7 @@ TEST(Load, SSTLoad) {
+     EXPECT_EQ(ResultCode::SUCCESSED, engine->ingest(files));
+ 
+     std::string result;
+-    EXPECT_EQ(ResultCode::SUCCESSED, engine->get(""key"", result));
++    EXPECT_EQ(ResultCode::SUCCESSED, engine->get(""key"", &result));
+     EXPECT_EQ(result, ""value"");
+ }
+ }   // namespace kvstore","For your reference in future, I sugguest to use the `ASSERT_*` family.",Why this change?
+1738,"@@ -68,6 +68,7 @@
+ #include ""modify.h""
+ #include ""universe.h""
+ #include ""variable.h""
++#include ""fmt/format.h""
+ 
+ #include <cstring>
+ ","no need to import `fmt/format.h` here since the `KimInit` class is derived from `Pointers`. Any class derived from `Pointers` can assumed that `lmptype.h`, `mpi.h`, `cstddef`, `cstdio`, `string`, `utils.h` and `fmt/format.h` are already included through `pointers.h`.",Why is this needed?
+1739,"@@ -17,7 +17,10 @@ limitations under the License.
+ package v1alpha1
+ 
+ import (
++	""os""
++
+ 	""github.com/pkg/errors""
++	""k8s.io/apimachinery/pkg/types""
+ 
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/upgrade/v1alpha1""
+ 	cast ""github.com/openebs/maya/pkg/castemplate/v1alpha1""",Can we have prefix of `OPENEBS_IO` e.g.: `OPENEBS_IO_INSTANCE_NAME`,nit: remove empty line
+1740,"@@ -1059,8 +1059,14 @@ func (fbo *folderBranchOps) GetTLFCryptKeys(ctx context.Context,
+ func (fbo *folderBranchOps) GetOrCreateRootNode(
+ 	ctx context.Context, h *TlfHandle, branch BranchName) (
+ 	node Node, ei EntryInfo, err error) {
+-	err = errors.New(""GetOrCreateRootNode is not supported by "" +
+-		""folderBranchOps"")
++	err = errors.New(""GetOrCreateRootNode is not supported by folderBranchOps"")
++	return
++}
++
++func (fbo *folderBranchOps) GetRootNode(
++	ctx context.Context, h *TlfHandle, branch BranchName) (
++	node Node, ei EntryInfo, err error) {
++	err = errors.New(""GetRootNode is not supported by folderBranchOps"")
+ 	return
+ }
+ ",Might as well fix these bare returns by making them `return errors.New(...` directly.,Why do we need this function?
+1741,"@@ -66,7 +66,7 @@ public class Benchmarks {
+           .sender(Address.ZERO)
+           .value(Wei.ZERO)
+           .apparentValue(Wei.ZERO)
+-          .code(new Code(Bytes.EMPTY))
++          .code(new Code(Bytes.EMPTY, org.hyperledger.besu.datatypes.Hash.EMPTY))
+           .depth(1)
+           .completer(__ -> {})
+           .address(Address.ZERO)",we can use import here,I think this should be `org.h
+1742,"@@ -35,8 +35,6 @@ func EchoBehavior(addr string) Result {
+ 		ctx,
+ 		// TODO get Service from client
+ 		&json.Request{
+-			Caller:    ""client"",
+-			Service:   ""yarpc-test"",
+ 			Procedure: ""echo"",
+ 			Body:      &server.EchoRequest{Token: token},
+ 			TTL:       3 * time.Second,",thx for removing these,Why is this removed?
+1743,"@@ -55,7 +55,11 @@ public final class XmlReportFailuresSupplier implements FailuresSupplier {
+     @Override
+     public List<Failure> getFailures() throws IOException {
+         File sourceReport = reporting.getReports().findByName(""xml"").getDestination();
+-        return XmlUtils.parseXml(reportHandler, new FileInputStream(sourceReport)).failures();
++        try {
++            return XmlUtils.parseXml(reportHandler, new FileInputStream(sourceReport)).failures();
++        } catch (Exception e) {
++            throw new RuntimeException(String.format(""Failed to parse failures XML: %s"", sourceReport), e);
++        }
+     }
+ 
+     @Override","I snuck this one in as well as checkstyle crashing (on files from resources) caused an unfinished xml to be written, and it wasn't obvious where that XML was",Why do we need this?
+1744,"@@ -542,6 +542,7 @@ func TestCreateInstanceValidateMachineType(t *testing.T) {
+ 		shouldErr bool
+ 	}{
+ 		{""good case"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/%s"", testProject, testZone, testMachineType), false},
++		{""good case2"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/%s"", testProject, testZone, testMachineType), false},
+ 		{""bad machine type case"", fmt.Sprintf(""projects/%s/zones/%s/machineTypes/bad-mt"", testProject, testZone), true},
+ 		{""bad project case"", fmt.Sprintf(""projects/p2/zones/%s/machineTypes/%s"", testZone, testMachineType), true},
+ 		{""bad zone case"", fmt.Sprintf(""projects/%s/zones/z2/machineTypes/%s"", testProject, testMachineType), true},","How is this different than ""good case""?",Why is this case2?
+1745,"@@ -33,7 +33,7 @@ const (
+ 
+ // Client is wrapper of ECS client.
+ type Client interface {
+-	ServiceExists(ctx context.Context, clusterName string, services []string) (bool, error)
++	ServiceExists(ctx context.Context, clusterName string, services string) (bool, error)
+ 	CreateService(ctx context.Context, service types.Service) (*types.Service, error)
+ 	UpdateService(ctx context.Context, service types.Service) (*types.Service, error)
+ 	RegisterTaskDefinition(ctx context.Context, taskDefinition types.TaskDefinition) (*types.TaskDefinition, error)",the last parameter name should be `serviceName` as is in the implementation  ,Why do we need thi
+1746,"@@ -178,7 +178,7 @@ public class PrettyPrintVisitorTest {
+     @Test
+     public void multilineJavadocGetsFormatted() {
+         CompilationUnit cu = new CompilationUnit();
+-        cu.addClass(""X"").addMethod(""abc"").setJavadocComment("" line1\n   line2 *\n * line3"");
++        cu.addClass(""X"").addMethod(""abc"").setJavadocComment(""line1\n   line2 *\n * line3"");
+ 
+         assertEqualsNoEol(""public class X {\n"" +
+                 ""\n"" +","@ftomassetti - okay, this is a little meh.",Why this change?
+1747,"@@ -11,7 +11,8 @@ import (
+ 
+ // Portable analogs of some common system call errors.
+ var (
+-	ErrUnsupported = errors.New(""operation not supported"")
++	errUnsupported = errors.New(""operation not supported"")
++	notImplemented = errors.New(""os: not implemented"")
+ )
+ 
+ // Stdin, Stdout, and Stderr are open Files pointing to the standard input,","Note, changed initial capitalisation of this for consistency. Can do it the other way around too if that'd be better. :wink:",I think this shoul
+1748,"@@ -11,7 +11,7 @@ if (typeof define === 'function' && define.amd) {
+ 	});
+ }
+ if (typeof module === 'object' && module.exports && typeof axeFunction.toString === 'function') {
+-    axe.source = '(' + axeFunction.toString() + ')(this, this.document);';
++    axe.source = '(' + axeFunction.toString() + ')(typeof window === ""object"" ? window : this);';
+     module.exports = axe;
+ }
+ if (typeof window.getComputedStyle === 'function') {","hey, aren't we supposed to be passing in two parameters here?","`typeof window === ""object"" ? window : this`"
+1749,"@@ -18,6 +18,7 @@ bitcore.encoding.BufferWriter = require('./lib/encoding/bufferwriter');
+ bitcore.encoding.Varint = require('./lib/encoding/varint');
+ 
+ // main bitcoin library
++bitcore.Unit = require('./lib/unit');
+ bitcore.Address = require('./lib/address');
+ bitcore.BIP32 = require('./lib/bip32');
+ bitcore.Block = require('./lib/block');",please keep alphabetical ordering :),Why is this needed?
+1750,"@@ -43,11 +43,14 @@ import org.openqa.selenium.remote.internal.CircularOutputStream;
+ 
+ import java.io.File;
+ import java.io.IOException;
++import java.io.InputStream;
+ import java.io.InputStreamReader;
++import java.io.OutputStream;
+ import java.io.PrintWriter;
+ import java.io.Reader;
+ import java.net.ConnectException;
+ import java.net.Socket;
++import java.nio.charset.StandardCharsets;
+ import java.util.List;
+ import java.util.Map;
+ ",Selenium must compile against Java 6. Revert this line.,Why is this needed?
+1751,"@@ -147,7 +147,7 @@ func (r *Reconciler) reconcilePullSubscription(ctx context.Context, source *v1al
+ 			logging.FromContext(ctx).Desugar().Error(""Failed to get PullSubscription"", zap.Error(err))
+ 			return nil, fmt.Errorf(""failed to get PullSubscription: %w"", err)
+ 		}
+-		newPS := resources.MakePullSubscription(source.Namespace, source.Name, &source.Spec.PubSubSpec, source, source.Spec.Topic, r.receiveAdapterName, resourceGroup)
++		newPS := resources.MakePullSubscription(source.Namespace, source.Name, &source.Spec.PubSubSpec, source, source.Spec.Topic, r.receiveAdapterName, """", resourceGroup)
+ 		logging.FromContext(ctx).Desugar().Debug(""Creating PullSubscription"", zap.Any(""ps"", newPS))
+ 		ps, err = r.RunClientSet.PubsubV1alpha1().PullSubscriptions(newPS.Namespace).Create(newPS)
+ 		if err != nil {","what is that `""""`, the adapterType? can you add `"""" /* adapterType */`... in other places as well... might be cleaner if it's a pointer or some varargs at the end but don't have any strong preference..",Why is the empty string here?
+1752,"@@ -2003,7 +2003,8 @@ Document.prototype.$__dirty = function() {
+   // gh-2558: if we had to set a default and the value is not undefined,
+   // we have to save as well
+   all = all.concat(this.$__.activePaths.map('default', function(path) {
+-    if (path === '_id' || !_this.getValue(path)) {
++    var pType = typeof _this.getValue(path);
++    if (path === '_id' || (!_this.getValue(path) && pType !== 'boolean')) {
+       return;
+     }
+     return {","This check is a little odd, and will still mess up with empty strings `''` because empty string is falsy. Can we change this to `|| _this.getValue(path) == null`?",Why is this change needed?
+1753,"@@ -0,0 +1,13 @@
++/**
++ * Note:
++ * Check
++ * - if element is focusable
++ * - if element is in focus order via `tabindex`
++ */
++const isFocusable = virtualNode.isFocusable;
++
++let tabIndex = virtualNode.actualNode.getAttribute('tabindex');
++tabIndex =
++	tabIndex && !isNaN(parseInt(tabIndex, 10)) ? parseInt(tabIndex) : null;
++
++return tabIndex ? isFocusable && tabIndex >= 0 : isFocusable;",Just a minor suggestion: If you `parseInt` when you access the attribute then you shouldn't have to do it twice in the ternary.,I don't think we need to c
+1754,"@@ -241,6 +241,7 @@ describe ""BoltServer::TransportApp"" do
+                                    password: target[:password],
+                                    port: target[:port]
+                                  })
++      body[:target]['host-key-check'] = false if transport == 'ssh'
+ 
+       post(path, JSON.generate(body), 'CONTENT_TYPE' => 'text/json')
+     end","This change in particular is strange. I'm not sure why it would now be necessary. The previous default would've been true, and the default behavior without a new net-ssh version should be unchanged.",body[:target]['host-key-ch
+1755,"@@ -25,7 +25,7 @@ class BatchActionFormModel
+     /**
+      * @Assert\Type(""boolean"")
+      */
+-    public bool $autoEndOnErrors = true;
++    public ?bool $autoEndOnErrors = true;
+ 
+     /**
+      * @Assert\Valid()",Why is that? Should be redundant as the default value exists.,should be `bool`
+1756,"@@ -252,6 +252,7 @@ type Config struct {
+ 	DebugSimulateCalcGraphHangAfter time.Duration `config:""seconds;0""`
+ 	DebugSimulateDataplaneHangAfter time.Duration `config:""seconds;0""`
+ 	DebugPanicAfter                 time.Duration `config:""seconds;0""`
++	DebugSimulateDataRace           bool          `config:""bool;false""`
+ 
+ 	// Configure where Felix gets its routing information.
+ 	// - workloadIPs: use workload endpoints to construct routes.","Are all fields beginning with ""Debug"" automatically `;local` ? (I guess so, but just checking.)",Why do we need this?
+1757,"@@ -115,6 +115,13 @@ public interface Table {
+    */
+   UpdateSchema updateSchema();
+ 
++  /**
++   * Create a new {@link UpdateNameMapping} to update name mapping of this table and commit the change.
++   *
++   * @return a new {@link UpdateNameMapping}
++   */
++  UpdateNameMapping updateNameMapping();
++
+   /**
+    * Create a new {@link UpdateProperties} to update table properties and commit the changes.
+    *","While I think it makes sense to update the mapping programmatically, I don't see much value in exposing it as part of the table API. We want to keep the Table API small, so if we can handle this by using a separate API that consumes and produces JSON, then that is preferred. Also, we may have more than one mapping in the future, so keeping this decoupled also helps out for those use cases. For now, let's build a utility class to perform these updates. We can always add this to the public API later if we choose to.",Why do we need this 
+1758,"@@ -540,7 +540,7 @@ static Int64 SikGcInterval = -1;
+ void SsmpGlobals::work()
+ {
+ 
+-  getIpcEnv()->getAllConnections()->waitOnAll(getStatsMergeTimeout());
++  getIpcEnv()->getAllConnections()->waitOnAll(0);
+   finishPendingSscpMessages();
+ 
+   // Cleanup IpcEnvironment","We would want ssmp to wake up every 3 seconds if there are no other requests to it and do some cleanup tasks. So, it is not clear why do you want to set this to 0.",Why this change?
+1759,"@@ -252,6 +252,13 @@ func Compile(pkgName string, machine llvm.TargetMachine, config *compileopts.Con
+ 
+ 	c.loadASTComments(lprogram)
+ 
++	// Forcibly preload special types.
++	runtimePkg := c.ir.Program.ImportedPackage(""runtime"")
++	c.getLLVMType(runtimePkg.Type(""_interface"").Type())
++	c.getLLVMType(runtimePkg.Type(""_string"").Type())
++	c.getLLVMType(runtimePkg.Type(""hashmap"").Type())
++	c.getLLVMType(runtimePkg.Type(""channel"").Type())
++
+ 	// Declare runtime types.
+ 	// TODO: lazily create runtime types in getLLVMRuntimeType when they are
+ 	// needed. Eventually this will be required anyway, when packages are",Is this really necessary? I would expect these types to be included with the loop below.,Why do we need to pr
+1760,"@@ -41,8 +41,17 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+ 
+             traceId.CopyTo(bytes);
+ 
+-            this.High = BitConverter.ToInt64(bytes, 0);
+-            this.Low = BitConverter.ToInt64(bytes, 8);
++            if (BitConverter.IsLittleEndian)
++            {
++                Array.Reverse(bytes);
++                this.High = BitConverter.ToInt64(bytes, 8);
++                this.Low = BitConverter.ToInt64(bytes, 0);
++            }
++            else
++            {
++                this.High = BitConverter.ToInt64(bytes, 0);
++                this.Low = BitConverter.ToInt64(bytes, 8);
++            }
+         }
+ 
+         public long High { get; set; }",You could do span<byte> and it's magic of typecast to int for better efficiency,Why do we need to reverse?
+1761,"@@ -87,8 +87,9 @@ Object.keys(rulesGroupByDocumentFragment).forEach(key => {
+ 				return;
+ 			}
+ 
+-			// check if transform style exists
+-			const transformStyleValue = cssRule.style.transform || false;
++			// check if transform style exists (don't forget vendor prefixes)
++			const transformStyleValue =
++				cssRule.style.transform || cssRule.style.webkitTransform || false;
+ 			// transformStyleValue -> is the value applied to property
+ 			// eg: ""rotate(-90deg)""
+ 			if (!transformStyleValue) {","Looks like you've covered `-webkit-transform`, but what about `-ms-transform`?",Why do we need this change
+1762,"@@ -241,15 +241,10 @@ namespace MvvmCross.Droid.Support.V7.RecyclerView
+ 
+         protected virtual void OnItemsSourceCollectionChanged(object sender, NotifyCollectionChangedEventArgs e)
+         {
+-            if (Looper.MainLooper == Looper.MyLooper())
+-            {
+-                NotifyDataSetChanged(e);
+-            }
+-            else
+-            {
+-                var h = new Handler(Looper.MainLooper);
+-                h.Post(() => NotifyDataSetChanged(e));
+-            }
++            if (Looper.MainLooper != Looper.MyLooper())
++                MvxBindingLog.Error(""All collection changes "");
++
++            NotifyDataSetChanged(e);
+         }
+ 
+         public virtual void NotifyDataSetChanged(NotifyCollectionChangedEventArgs e)",Is there something missing from the message here?,Why did you remove this ha
+1763,"@@ -48,3 +48,14 @@ from luigi import event
+ from luigi.event import Event
+ 
+ from .tools import range  # just makes the tool classes available from command line
++
++
++__all__ = [
++    'task', 'Task', 'Config', 'ExternalTask', 'WrapperTask', 'namespace',
++    'target', 'Target', 'File', 'LocalTarget', 'rpc', 'RemoteScheduler',
++    'RPCError', 'parameter', 'Parameter', 'DateParameter', 'MonthParameter',
++    'YearParameter', 'DateHourParameter', 'DateMinuteParameter', 'range',
++    'DateIntervalParameter', 'TimeDeltaParameter', 'IntParameter',
++    'FloatParameter', 'BooleanParameter', 'BoolParameter', 'TaskParameter',
++    'configuration', 'interface', 'file', 'run', 'build', 'event', 'Event'
++]","Hmm, what does this syntax mean?",I don't think we need to a
+1764,"@@ -98,7 +98,12 @@ func (r *nDCActivityReplicatorImpl) SyncActivity(
+ 		RunId:      request.RunId,
+ 	}
+ 
+-	context, release, err := r.historyCache.getOrCreateWorkflowExecution(ctx, namespaceID, execution)
++	context, release, err := r.historyCache.getOrCreateWorkflowExecution(
++		ctx,
++		namespaceID,
++		execution,
++		callerTypeAPI,
++	)
+ 	if err != nil {
+ 		// for get workflow execution context, with valid run id
+ 		// err will not be of type EntityNotExistsError",should this be callerTypeTask?,I think you can remove this line.
+1765,"@@ -56,6 +56,10 @@ class PlanPolicy < ApplicationPolicy
+     @plan.administerable_by?(@user.id)
+   end
+ 
++  def set_test?
++    @plan.administerable_by?(@user.id)
++  end
++
+ # TODO: These routes are no lonmger used
+ =begin
+   def section_answers?","Currently update is set as @plan.editable_by?(@user.id) Which one is the correct behavior? I can see a case for only owners/co-owners to be able to set visibility, test status, and other plan details",Extra empty line detected at clas
+1766,"@@ -47,8 +47,7 @@ namespace Nethermind.Blockchain
+         private readonly LruCache<Keccak, BlockHeader> _headerCache = new LruCache<Keccak, BlockHeader>(CacheSize);
+         private readonly LruCache<long, ChainLevelInfo> _blockInfoCache = new LruCache<long, ChainLevelInfo>(CacheSize);
+ 
+-        private const int MaxQueueSize = 10_000_000;
+-
++        private const int BestKnownSearchLimit = 256_000_000;
+         public const int DbLoadBatchSize = 4000;
+ 
+         private long _currentDbLoadBatchEnd;","Maybe make it configurable? Or store the actual level index in DB, making this binary search obsolete?",Why did you change this?
+1767,"@@ -66,6 +66,7 @@ public class HiveTableBaseTest extends HiveMetastoreTest {
+     tableLocation.getFileSystem(hiveConf).delete(tableLocation, true);
+     catalog.dropTable(TABLE_IDENTIFIER, false /* metadata only, location was already deleted */);
+   }
++
+   private static String getTableBasePath(String tableName) {
+     String databasePath = metastore.getDatabasePath(DB_NAME);
+     return Paths.get(databasePath, tableName).toAbsolutePath().toString();",Nit: this file doesn't need to change. Can you revert this to avoid git conflicts?,nit: remove empty line
+1768,"@@ -66,7 +66,7 @@ function HelpMenu( { children } ) {
+ 
+ 	const handleMenuSelected = useCallback( () => {
+ 		toggleMenu( false );
+-	} );
++	}, [] );
+ 
+ 	return (
+ 		<div className=""googlesitekit-dropdown-menu googlesitekit-dropdown-menu__icon-menu googlesitekit-help-menu mdc-menu-surface--anchor"">","There's no reason for this to be a callback now technically but as per our tech decision, we want all handlers to use `useCallback` now",Why is this change needed?
+1769,"@@ -33,6 +33,7 @@ const (
+ 	BalanceRecord     HashID = ""BR""
+ 	Credential        HashID = ""CR""
+ 	Genesis           HashID = ""GE""
++	Logic             HashID = ""LO""
+ 	Message           HashID = ""MX""
+ 	NetPrioResponse   HashID = ""NPR""
+ 	OneTimeSigKey1    HashID = ""OT1""","This isn't strictly part of this PR, but could you move `multiSigString` from `crypto/multisig.go` into this list of `HashID` values? Now that we have other things being hashed into addresses (specifically, these new logic addresses), it's important that the hash input for multisig addrs is domain-separated from logic addresses.",Why do we need this?
+1770,"@@ -0,0 +1,8 @@
++from django.test import TestCase
++from graphite.worker_pool.pool import stop_pool
++
++
++class BaseTestCase(TestCase):
++
++  def tearDown(self):
++    stop_pool()","nit: you could have named it just ""TestCase"" (if django's TestCase was imported differently)",Why is this needed?
+1771,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+ 
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+ 
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.,Why do we need this?
+1772,"@@ -42,7 +42,6 @@ std::string lldb_private::formatters::swift::SwiftOptionalSummaryProvider::
+ // retrieve the value of the Some case..
+ static PointerOrSP
+ ExtractSomeIfAny(ValueObject *optional,
+-                 lldb::DynamicValueType dynamic_value = lldb::eNoDynamicValues,
+                  bool synthetic_value = false) {
+   if (!optional)
+     return nullptr;","All the callers of `ExtractSomeIfAny`, always pass `true` to `synthetic_value`. Can we get rid of the extra argument?",Why was this removed?
+1773,"@@ -109,7 +109,8 @@ def main():
+     logger.info('Environment info:\n' + dash_line + env_info + '\n' +
+                 dash_line)
+     meta['env_info'] = env_info
+-
++    meta['config_dict'] = dict(cfg)
++    meta['config_file'] = args.config
+     # log some basic info
+     logger.info(f'Distributed training: {distributed}')
+     logger.info(f'Config:\n{cfg.pretty_text}')",Better to use the absolute path.,why do we need this?
+1774,"@@ -45,8 +45,8 @@ const (
+ 	// VoucherInterval defines how many block pass before creating a new voucher
+ 	VoucherInterval = 1000
+ 
+-	// ChannelExpiryBuffer defines how long the channel remains open past the last voucher
+-	ChannelExpiryBuffer = 2000
++	// ChannelExpiryInterval defines how long the channel remains open past the last voucher
++	ChannelExpiryInterval = 2000
+ 
+ 	// CreateChannelGasPrice is the gas price of the message used to create the payment channel
+ 	CreateChannelGasPrice = 0","this is 16 hours, is that enough?",Why did you change th
+1775,"@@ -0,0 +1,16 @@
++package tracing
++
++import (
++	""context""
++
++	""go.opencensus.io/trace""
++)
++
++// AddErrorEndSpan will end `span` and adds `err` to `span` iff err is not nil.
++// This is a helper method to cut down on boiler plate.
++func AddErrorEndSpan(ctx context.Context, span *trace.Span, err *error) {
++	if *err != nil {
++		span.AddAttributes(trace.StringAttribute(""error"", (*err).Error()))
++	}
++	span.End()
++}",  removing boilerplate. You could also add a `StartSpan` with varargs to inline string attributes.,I think this should b
+1776,"@@ -71,9 +71,10 @@ func (b *EthAPIBackend) GetEthContext() (uint64, uint64) {
+ 	return bn, ts
+ }
+ 
+-func (b *EthAPIBackend) GetRollupContext() (uint64, uint64) {
++func (b *EthAPIBackend) GetRollupContext() (uint64, uint64, uint64) {
+ 	i := uint64(0)
+ 	q := uint64(0)
++	v := uint64(0)
+ 	index := b.eth.syncService.GetLatestIndex()
+ 	if index != nil {
+ 		i = *index",Can you replace these single letter variables with full names?,`v` is not used?
+1777,"@@ -1,13 +1,16 @@
+ // Copyright (c) .NET Foundation. All rights reserved.
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+ 
++using System;
+ using System.IO;
++using Microsoft.AspNet.Http.Features;
+ 
+ namespace Microsoft.AspNet.Server.Kestrel.Filter
+ {
+     public class ConnectionFilterContext
+     {
+         public ServerAddress Address { get; set; }
+-        public Stream Connection { get; set;  }
++        public Stream Connection { get; set; }
++        public Action<IFeatureCollection> PrepareRequest { get; set; }
+     }
+ }","At first I wasn't sure, but now I think I'm sold on making PrepareRequest an action over adding a state object to the context.",Why do we need t
+1778,"@@ -679,9 +679,9 @@ class Upgrade
+         // Eliminate obsolete config override settings:
+         unset($newConfig['Extra_Config']);
+ 
+-        // Update generator if it is default value:
++        // Update generator if it contains a version number:
+         if (isset($newConfig['Site']['generator'])
+-            && $newConfig['Site']['generator'] == 'VuFind ' . $this->from
++            && preg_match('/^VuFind (\d+\.?)+$/', $newConfig['Site']['generator'])
+         ) {
+             $newConfig['Site']['generator'] = 'VuFind ' . $this->to;
+         }","Would it be too greedy to preg_replace `VuFind (\d+\.?)+` with `'VuFind ' . $this->to` anywhere in the string? This would update something like 'Finna (VuFind 7.1.0)' as well. Just a thought, please disregard if you'd like to keep it as is.",I think this sho
+1779,"@@ -91,7 +91,7 @@ public abstract class ManagedResourceStorage {
+       zkClient = ((ZkSolrResourceLoader)resourceLoader).getZkController().getZkClient();
+       try {
+         zkConfigName = ((ZkSolrResourceLoader)resourceLoader).getZkController().
+-            getZkStateReader().readConfigName(collection);
++            getZkStateReader().getClusterState().getCollection(collection).getConfigName();
+       } catch (Exception e) {
+         log.error(""Failed to get config name due to"", e);
+         throw new SolrException(ErrorCode.SERVER_ERROR,","BTW for brevity, you can remove `getZkStateReader().` here and elsewhere since ZkController has a convenience method for the cluster state.",Why do we need t
+1780,"@@ -191,7 +191,10 @@ public class FindFiles {
+       Snapshot snapshot = snapshotId != null ?
+           ops.current().snapshot(snapshotId) : ops.current().currentSnapshot();
+ 
+-      CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, snapshot.manifests())
++      // snapshot could be null when the table just gets created
++      Iterable<ManifestFile> manifests = (snapshot != null) ? snapshot.manifests() : CloseableIterable.empty();
++
++      CloseableIterable<ManifestEntry> entries = new ManifestGroup(ops, manifests)
+           .filterData(rowFilter)
+           .filterFiles(fileFilter)
+           .filterPartitions(partitionFilter)","If there are no manifests, then entries should be `CloseableIterable.empty()`, not the manifest iterable. That doesn't need to be closeable.",nit: `manifests` -> `manifests`
+1781,"@@ -0,0 +1,11 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.codestyle;
++
++import net.sourceforge.pmd.testframework.PmdRuleTst;
++
++public class ArrayInitializationVerbosenessRuleTest extends PmdRuleTst {
++  // no additional unit tests
++}",this class should be named `ArrayInitializationVerbosenessTest` to work,This file is missing the licens
+1782,"@@ -338,9 +338,17 @@ module Bolt
+ 
+     private def update_logs(logs)
+       logs.each_with_object({}) do |(key, val), acc|
+-        next unless val.is_a?(Hash)
++        # Remove any disabled logs
++        next if val == 'disable'
+ 
+         name = normalize_log(key)
++
++        # But otherwise it has to be a Hash
++        unless val.is_a?(Hash)
++          raise Bolt::ValidationError,
++                ""config of log #{name} must be a Hash, received #{val.class} #{val.inspect}""
++        end
++
+         acc[name] = val.slice('append', 'level')
+                        .transform_keys(&:to_sym)
+ ",Do we want to allow users to disable `console` as well? The schema currently says that it only permits a hash for `console`.,I'm not sure if this is the bes
+1783,"@@ -44,6 +44,7 @@ func TestAddrsNewAndList(t *testing.T) {
+ 
+ func TestWalletBalance(t *testing.T) {
+ 	tf.IntegrationTest(t)
++	t.Skip(""not working"")
+ 	ctx := context.Background()
+ 
+ 	builder := test.NewNodeBuilder(t)",It would be very helpful to describe succinctly either inline or by linking to an issue going into depth why each test is not working. If we merge like this your knowledge of what is going on is lost and other people in the code need to do a ton of reading before understanding when/how/if we should unskip.,Why is this skipped?
+1784,"@@ -85,9 +85,13 @@ export default function LegacyAdSenseDashboardWidgetOverview( props ) {
+ 			}
+ 		}
+ 	}, [
+-		currentDataLoaded && previousDataLoaded, // All reports are fetched.
+-		!! currentError || !! previousError, // Whether there is an error or not.
+-		JSON.stringify( currentRangeData ),
++		currentDataLoaded,
++		currentError,
++		currentRangeData,
++		handleDataError,
++		handleDataSuccess,
++		previousDataLoaded,
++		previousError,
+ 	] );
+ 
+ 	if ( ! currentDataLoaded || ! previousDataLoaded ) {",As this is a `useEffect` this could be a cause for concern! Note that `useEffect` re-runs when a dependency changes **not** when a dependency is truthy (the previous code does look a bit like it's expecting that),I don't think we need the `!!` anymore.
+1785,"@@ -47,12 +47,13 @@
+ 
+ namespace lbann {
+ 
+-lbann_comm* initialize(int& argc, char**& argv, int seed) {
++world_comm_ptr initialize(int& argc, char**& argv, int seed) {
+   // Initialize Elemental.
+   El::Initialize(argc, argv);
+   // Create a new comm object.
+   // Initial creation with every process in one model.
+-  auto* comm = new lbann_comm(0);
++  auto comm = world_comm_ptr{new lbann_comm(0), &lbann::finalize };
++
+ #if defined(LBANN_TOPO_AWARE)
+   // Determine the number of NUMA nodes present.
+   hwloc_topology_t topo;",Should we be doing this with `make_unique` or something?,Why is this needed?
+1786,"@@ -35,9 +35,11 @@ class ProposalMailer < ApplicationMailer
+     )
+   end
+ 
+-  def proposal_updated_no_action_required(user, proposal, modifier = nil)
++  def proposal_updated_no_action_required(user = User.last, proposal = Proposal.last, modifier = nil)
+     @proposal = proposal.decorate
+     @modifier = modifier || NullUser.new
++    # Example ideal data to consume
++    @changes = [{verb: 'modified', result: 'this to that'},{verb: 'added', result: 'that'},{verb: 'modified', result: 'this to that'}]
+     assign_threading_headers(@proposal)
+ 
+     mail(","we don't want to set default values for this. Since it is the actual email, we want to make sure we are always passing in the `user` and `proposal` . we have a default value of `nil` for modifier because sometimes will update a proposal via `rails console` in which case there will be no recorded modifier.",Layout/SpaceAfterComma: Space missing a
+1787,"@@ -14,9 +14,10 @@ import (
+ 	""strconv""
+ 	""strings""
+ 
++	""go/parser""
++
+ 	""github.com/aykevl/go-llvm""
+ 	""github.com/aykevl/tinygo/ir""
+-	""go/parser""
+ 	""golang.org/x/tools/go/loader""
+ 	""golang.org/x/tools/go/ssa""
+ )","Yes this import was in the wrong place, but should ideally be in the first list of imports (among `go/build`, `go/token`, etc.). You may move it there, or just revert this change as it's actually unrelated.",nit: remove empty line
+1788,"@@ -106,7 +106,7 @@ import javax.lang.model.element.Name;
+ @AutoService(BugChecker.class)
+ @BugPattern(
+         name = ""StrictUnusedVariable"",
+-        altNames = {""unused"", ""StrictUnusedVariable""},
++        altNames = {""unused"", ""UnusedVariable""},
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+         summary = ""Unused."",",It's unnecessary to duplicate the `name`.,I think this should be `StrictUnusedVariable`.
+1789,"@@ -68,7 +68,7 @@ final class MediaType extends AbstractType implements LoggerAwareInterface
+         $builder->addModelTransformer($dataTransformer);
+ 
+         $builder->addEventListener(FormEvents::SUBMIT, static function (FormEvent $event): void {
+-            if ($event->getForm()->has('unlink') && null !== $event->getForm()->get('unlink')->getData()) {
++            if ($event->getForm()->has('unlink') && true === $event->getForm()->get('unlink')->getData()) {
+                 $event->setData(null);
+             }
+         });",this was a mistake when adding phpstan strict plugin,`null !== $event->getForm()->get('unlink')->ge
+1790,"@@ -197,6 +197,14 @@ export function diffChildren(
+ 
+ 						newParentVNode._nextDom = oldDom;
+ 					}
++				} else if (
++					oldDom &&
++					oldVNode._dom == oldDom &&
++					oldDom.parentNode != parentDom
++				) {
++					// The above condition is handle null placeholders. See test in placeholder.test.js:
++					// `efficiently replace null placeholders in parent rerenders`
++					oldDom = getDomSibling(oldVNode);
+ 				}
+ 			}
+ ",Nit: I think it should be `to handle` here.,Why do we need this check?
+1791,"@@ -2810,7 +2810,7 @@ public class MessagingController implements Runnable {
+ 
+                     LocalMessage message = localFolder.getMessage(uid);
+                     if (message == null
+-                    || message.getId() == 0) {
++                            || message.getId() == 0) {
+                         throw new IllegalArgumentException(""Message not found: folder="" + folder + "", uid="" + uid);
+                     }
+                     // IMAP search results will usually need to be downloaded before viewing.",Please don't make unrelated changes or let your tools make unrelated changes.,Why did you change this?
+1792,"@@ -18,7 +18,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ )
+ 
+-var numAccounts int
++var numAccounts uint
+ 
+ // accountCreateCmd represents the account create command
+ var accountCreateCmd = &cobra.Command{",`numAccounts` is a global variable (from `gochecknoglobals`),Why do we need to change this?
+1793,"@@ -855,6 +855,9 @@ class PluginManager
+         if ($pluginPath = self::instance()->getPluginPath($id)) {
+             File::deleteDirectory($pluginPath);
+         }
++
++        // actually remove the plugin from our internal container
++        unset($this->plugins[$id]);
+     }
+ 
+     /**",Is the ID correctly normalized at this point?,Why is this needed?
+1794,"@@ -0,0 +1,11 @@
++package commands
++
++import (
++	""context""
++
++	""github.com/ledgerwatch/erigon/p2p""
++)
++
++func (api *ErigonImpl) NodeInfo(ctx context.Context) ([]p2p.NodeInfo, error) {
++	return api.ethBackend.NodeInfo(ctx, 0)
++}","if 0 is a special constant meaning ""no limit"" let's make it a constant and name it correctly :)",`0` should be a constant.
+1795,"@@ -140,8 +140,8 @@ func run(ctx context.Context) {
+ 		} else {
+ 			setOsConfig(resp)
+ 			setPatchPolicies(resp.PatchPolicies)
+-			runInventory()
+ 		}
++		runInventory()
+ 
+ 		select {
+ 		case <-ticker.C:",Curious about the reason behind this change,Why did you remove this?
+1796,"@@ -18,7 +18,7 @@ func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) (err error) {
+ 	// Put block in storage wired to an exchange so this node and other
+ 	// nodes can fetch it.
+ 	log.Debugf(""putting block in bitswap exchange: %s"", b.Cid().String())
+-	blkCid, err := node.OnlineStore.Put(ctx, b)
++	blkCid, err := node.cborStore.Put(ctx, b)
+ 	if err != nil {
+ 		return errors.Wrap(err, ""could not add new block to online storage"")
+ 	}","wait, i thought the cborstore was for state tree?",I think this should be `cborStore.Put`
+1797,"@@ -1101,7 +1101,19 @@ class Package(object):
+ 
+         self._fix_sha256()
+         pkg = self._materialize(dest)
++
++        def physical_key_is_temp_file(pk):
++            if not file_is_local(pk):
++                return False
++            return pathlib.Path(parse_file_url(urlparse(pk))).parent == APP_DIR_TEMPFILE_DIR
++        temp_file_logical_keys = [lk for lk, entry in self.walk() if physical_key_is_temp_file(entry.physical_keys[0])]
++
+         self._delete_temporary_files()  # Now that data has been pushed, delete tmp files created by pkg.set('KEY', obj)
++
++        # Update old package to point to the materialized location of the file since the tempfile no longest exists
++        for lk in temp_file_logical_keys:
++            self.set(lk, pkg[lk])
++
+         pkg.build(name, registry=registry, message=message)
+         return pkg
+ ","This logic is now duplicated here and in `_delete_temporary_files`... Maybe do it all at once - find temp files, delete them, and fix the logical keys?",I'm not sure if this is the best way t
+1798,"@@ -25,6 +25,11 @@ import io.swagger.converter.ModelConverters;
+ import io.swagger.models.properties.Property;
+ 
+ public class DefaultResponseTypeProcessor implements ResponseTypeProcessor {
++  @Override
++  public Class<?> getResponseType() {
++    // not care for this.
++    return null;
++  }
+ 
+   @Override
+   public Property process(OperationGenerator operationGenerator) {",How about name it with NullResponseTypeProcessor,Why do we need this?
+1799,"@@ -580,6 +580,8 @@ Dataset* DatasetLoader::CostructFromSampleData(double** sample_values,
+       BinType bin_type = BinType::NumericalBin;
+       if (categorical_features_.count(i)) {
+         bin_type = BinType::CategoricalBin;
++        bool feat_is_unconstrained = ((config_.monotone_constraints.size() == 0) || (config_.monotone_constraints[i] == 0));
++        CHECK(feat_is_unconstrained);
+       }
+       bin_mappers[i].reset(new BinMapper());
+       if (config_.max_bin_by_feature.empty()) {",Maybe `Log::Fatal` here? `[LightGBM] [Fatal] Check failed: feat_is_unconstrained at ...` (and kernel death in case of Jupyter Notebook) seems to be not so informative and user-friendly.,nit: `CHECK(feat_is_unconstrained || c
+1800,"@@ -575,7 +575,7 @@ class decimate(ElementOperation):
+        The x_range as a tuple of min and max y-value. Auto-ranges
+        if set to None."""""")
+ 
+-    def _process(self, element, key=None):
++    def _apply(self, element, key=None):
+         if not isinstance(element, Dataset):
+             raise ValueError(""Cannot downsample non-Dataset types."")
+         if element.interface not in column_interfaces:","Not sure I like the name ``_apply``. Even though ``_process`` is supposed to process elements already, how about ``_process_element`` which processes elements, *excluding* Overlays/NdOverlays.",Why did you change this?
+1801,"@@ -131,6 +131,9 @@ const (
+ 
+ 	// MachineNameTagKey is the key for machine name.
+ 	MachineNameTagKey = ""MachineName""
++
++	// NodeRoleTagValue describes the value for the node role.
++	NodeRoleTagValue = ""node""
+ )
+ 
+ // ClusterTagKey generates the key for resources associated with a cluster.",Let's use this constant when ASG is created as well (currently hardcoded).,I think this should be `
+1802,"@@ -152,6 +152,10 @@ CREATE_PACKAGE_HASHES = textwrap.dedent(f""""""\
+     FROM named_packages
+ """""")
+ 
++# All GROUP BY statements are supposed to be:
++# - in the order from most unique values to least unique
++# - integers rather than strings
++
+ OBJECT_ACCESS_COUNTS = textwrap.dedent(""""""\
+     SELECT
+         eventname,",Oh is `bucket` actually higher cardinality than `eventname`?,I don't think this is th
+1803,"@@ -33,6 +33,7 @@ import sip
+ from PyQt5.QtCore import QUrl
+ # so it's available for :debug-pyeval
+ from PyQt5.QtWidgets import QApplication  # pylint: disable=unused-import
++from PyQt5.QtWebEngineWidgets import QWebEngineProfile  # pylint: disable=unused-import
+ 
+ from qutebrowser.browser import qutescheme
+ from qutebrowser.utils import log, objreg, usertypes, message, debug, utils",You can't rely on QtWebEngine being available - but why do you need to import this here at all?,Why is this import neede
+1804,"@@ -234,6 +234,12 @@ setup(
+ 		],
+ 		""packages"": [
+ 			""NVDAObjects"",
++			# As of py2exe 0.11.0.0 if the forcibly included package contains subpackages
++			# they need to  be listed explicitly (py2exe issue 113).
++			""NVDAObjects.IAccessible"",
++			""NVDAObjects.JAB"",
++			""NVDAObjects.UIA"",
++			""NVDAObjects.window"",
+ 			""virtualBuffers"",
+ 			""appModules"",
+ 			""comInterfaces"",",How did you determine these - and how can we be confident that nothing is missing?,I don't think this is the right place to put this. It should be in the `packages` list.
+1805,"@@ -0,0 +1,3 @@
++<h2>Workshops</h2>
++<h2>Videos</h2>
++<h2>Books</h2>",What is this page going to do that is different than the products index we already have?,<h2>Books</h2>
+1806,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+ 
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.,Should this be `manifest['application']['gecko']['id']`?
+1807,"@@ -3,9 +3,10 @@ module Travis
+     class Script
+       module Addons
+         class Deploy
+-          VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node]
++          VERSIONED_RUNTIMES = [:jdk, :node, :perl, :php, :python, :ruby, :scala, :node, :go]
+           USE_RUBY           = '1.9.3'
+-          attr_accessor :script, :config, :allow_failure
++          HASH_CONFIG_KEYS = [:s3_options]
++          attr_accessor :script, :hash_config, :config, :allow_failure
+ 
+           def initialize(script, config)
+             @silent = false",Is this intended to be here? Seems it belongs to a different PR.,I don't think we need to add `:go` here.
+1808,"@@ -20,7 +20,7 @@ namespace Xunit.ConsoleClient
+         {
+             try
+             {
+-                SetConsoleForegroundColor(ConsoleColor.White);
++                Console.ForegroundColor = ConsoleColor.White;
+ #if !NETCORE
+                 var netVersion = Environment.Version;
+ #else","These changes, while harmless, were no longer needed with newer versions of System.Console thanks to @ianhays",Why did you change this?
+1809,"@@ -58,7 +58,11 @@ logger = logging.getLogger('luigi-interface')
+ 
+ try:
+     import boto3
+-    client = boto3.client('ecs')
++    try:
++        import botocore.exceptions
++        client = boto3.client('ecs')
++    except botocore.exceptions.NoRegionError:
++        logger.warning('Your AWS config is missing Region information, ECSTask requires a working config.')
+ except ImportError:
+     logger.warning('boto3 is not installed. ECSTasks require boto3')
+ ",Umm... this isn't relevant to this PR,This should be a `logger
+1810,"@@ -24,6 +24,7 @@ namespace Xunit
+         Netcoreapp = 0x1000,
+         Uap = 0x2000,
+         UapAot = 0x4000,
+-        NetcoreCoreRT = 0x8000
++        NetcoreCoreRT = 0x8000,
++        All = ~0
+     }
+ }",While All make some sense here it doesn't make a lot of sense in the SkipOnFramework context. I wonder if we really need to expose anything more here. You can just blindly use 0.,Why is this `~0`?
+1811,"@@ -0,0 +1,7 @@
++// Copyright 2021 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++// Package main provides the bee binary viper-cobra
++// command definitions.
++package main","Actually, this is not correct. Package `cmd/bee` doe snot have any notion of commands or even libraries used for them. It is as simple as possible, just calling the function from `cmd/bee/cmd` which actually implements commands.",nit: `bee` -> `be`
+1812,"@@ -7,15 +7,11 @@ const Router = Ember.Router.extend({
+ });
+ 
+ Router.map(function() {
+-  this.route('admin', {
+-    resetNamespace: true
+-  }, function() {
++  this.route('admin', function() {
+     this.route('address');
+     this.route('loaddb');
+     this.route('lookup', { path: '/' });
+-    this.route('users', {
+-      resetNamespace: true
+-    }, function() {
++    this.route('users', function() {
+       this.route('edit', { path: '/edit/:user_id' });
+     });
+     this.route('roles');","This change is causing tests to fail because users sits at `/app/users`, not `/app/admin/users`",Why did you remove the namespace here?
+1813,"@@ -150,4 +150,19 @@ return [
+ 
+     'secure' => false,
+ 
++    /*
++    |--------------------------------------------------------------------------
++    | Same-Site Cookies
++    |--------------------------------------------------------------------------
++    |
++    | This option determines how your cookies behave when cross-site requests
++    | take place, and can be used to mitigate CSRF attacks. By default, we
++    | do not enable this as other CSRF protection services are in place.
++    |
++    | Supported: ""lax"", ""strict""
++    |
++    */
++
++    'same_site' => null,
++
+ ];",Could you provide more information on what exactly each of those three options do?,I think this should be `null`
+1814,"@@ -1,10 +1,12 @@
+ using System.Collections.Generic;
++using System;
+ 
+ namespace ScenarioMeasurement
+ {
+     public class LinuxTraceSession : ITraceSession
+     {
+-        public string TraceFilePath { get { return perfCollect?.TraceFilePath; } }
++        public string TraceFilePath { 
++            get { return perfCollect?.TraceFilePath;} }
+         private PerfCollect perfCollect;
+         private Dictionary<TraceSessionManager.KernelKeyword, PerfCollect.KernelKeyword> kernelKeywords;
+         private Dictionary<TraceSessionManager.ClrKeyword, PerfCollect.ClrKeyword> clrKeywords;",Why this line break?,Why is this needed?
+1815,"@@ -27,6 +27,7 @@ import (
+ 	admissionregistrationv1 ""k8s.io/api/admissionregistration/v1""
+ 	""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions""
+ 	apiextensionsinstall ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/install""
++	apiextensionsv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+ 	v1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""",We're importing this twice with different aliases.,Why is this needed?
+1816,"@@ -98,6 +98,7 @@ if __name__ == ""__main__"":
+                 ""grpcio-tools==1.32.0"",
+                 ""isort>=4.3.21,<5"",
+                 ""mock==3.0.5"",
++                ""pandera<0.8.0"",
+                 ""protobuf==3.13.0"",  # without this, pip will install the most up-to-date protobuf
+                 ""pylint==2.6.0"",
+                 ""pytest-cov==2.10.1"",",We should avoid adding a pandera dependency to Dagster itself.,This should be `pandera>=0.8.0`
+1817,"@@ -163,9 +163,16 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
+ 
+     public void setPermission(PostgrePrivilegeType privilegeType, boolean permit) {
+         for (ObjectPermission permission : permissions) {
+-            if (permission.privilegeType == privilegeType) {
++            if (permission.privilegeType != privilegeType) {
+                 if (permit) {
+                     permission.permissions |= GRANTED;
++                    ObjectPermission[] tempPermission = new ObjectPermission[this.permissions.length+1];
++                    for(int i = 0; i < this.permissions.length; i++) {
++                	tempPermission[i] = this.permissions[i];
++                    }
++                    tempPermission[this.permissions.length] = new ObjectPermission(privilegeType, permission.getGrantor(), permission.permissions);
++                    this.permissions = tempPermission;
++                    
+                 } else {
+                     permission.permissions = 0;
+                 }",Can be replaced with `org.jkiss.utils.ArrayUtils#add`.,Why do we need this change?
+1818,"@@ -653,7 +653,12 @@ public class ZkController implements Closeable {
+     customThreadPool.submit(() -> Collections.singleton(overseer).parallelStream().forEach(IOUtils::closeQuietly));
+ 
+     try {
+-      customThreadPool.submit(() -> electionContexts.values().parallelStream().forEach(IOUtils::closeQuietly));
++      customThreadPool.submit(() -> {
++        Collection<ElectionContext> values = electionContexts.values();
++        synchronized (electionContexts) {
++          values.forEach(IOUtils::closeQuietly);
++        }
++      });
+ 
+     } finally {
+ ","While we're here, this line (and a few others) should be `customThreadPool.submit(() -> IOUtils.closeQuietly(overseer);` I have no idea why we're creating a collection and a stream for a single object.",Why do we need this synchroniza
+1819,"@@ -335,6 +335,18 @@ func ValidateACMEChallengeSolverDNS01(p *cmacme.ACMEChallengeSolverDNS01, fldPat
+ 				if len(p.AzureDNS.TenantID) == 0 {
+ 					el = append(el, field.Required(fldPath.Child(""azureDNS"", ""tenantID""), """"))
+ 				}
++				if len(p.AzureDNS.ManagedIdentityClientID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS"", ""managedIdentityClientID""), ""managed identity can not be used at the same time as clientID, tenantID or clientSecret""))
++				}
++				if len(p.AzureDNS.ManagedIdentityResourceID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS"", ""managedIdentityResourceID""), ""managed identity can not be used at the same time as clientID, tenantID or clientSecret""))
++				}
++			} else {
++				// using managed identity
++				if len(p.AzureDNS.ManagedIdentityClientID) > 0 && len(p.AzureDNS.ManagedIdentityResourceID) > 0 {
++					el = append(el, field.Forbidden(fldPath.Child(""azureDNS""), ""managedIdentityClientID and managedIdentityResourceID connot both be specified""))
++				}
++
+ 			}
+ 			// SubscriptionID must always be defined
+ 			if len(p.AzureDNS.SubscriptionID) == 0 {",Should these restrictions also be reflected in the API docs?,I don't think you need to check
+1820,"@@ -209,6 +209,13 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
++	// restore original request before invoking error handler chain (issue #3717)
++	origReq := r.Context().Value(OriginalRequestCtxKey).(http.Request)
++	r.Method = origReq.Method
++	r.RemoteAddr = origReq.RemoteAddr
++	r.RequestURI = origReq.RequestURI
++	cloneURL(origReq.URL, r.URL)
++
+ 	// prepare the error log
+ 	logger := errLog
+ 	if s.Logs != nil {",What about the request headers if someone uses `request_header`? :thinking:,Why do we need this?
+1821,"@@ -54,7 +54,12 @@ func (r *ReconcileHiveConfig) deployExternalDNS(hLog log.FieldLogger, h *resourc
+ 	deployment := resourceread.ReadDeploymentV1OrDie(asset)
+ 
+ 	// Make AWS-specific changes to external-dns deployment
+-	deployment.Spec.Template.Spec.Containers[0].Args = append(deployment.Spec.Template.Spec.Containers[0].Args, ""--provider=aws"")
++	args := deployment.Spec.Template.Spec.Containers[0].Args
++	args = append(args, ""--provider=aws"")
++	for _, domain := range instance.Spec.ManagedDomains {
++		args = append(args, fmt.Sprintf(""--domain-filter=%s"", domain))
++	}
++	deployment.Spec.Template.Spec.Containers[0].Args = args
+ 
+ 	if len(instance.Spec.ExternalDNS.Image) > 0 {
+ 		deployment.Spec.Template.Spec.Containers[0].Image = instance.Spec.ExternalDNS.Image","Verify that external-dns allows setting this parameter multiple times (that it's not ""last one wins"").",I think this should 
+1822,"@@ -80,6 +80,7 @@ class Docker(base.Base):
+               - nofile:262144:262144
+             dns_servers:
+               - 8.8.8.8
++            etc_hosts: ""{'host1.example.com': '10.3.1.5'}""
+             networks:
+               - name: foo
+               - name: bar",Maybe 2 host/ip values could be used in the example?,I think this should 
+1823,"@@ -139,7 +139,9 @@ namespace Datadog.Trace.Tests.Sampling
+ 
+             var limiter = new RateLimiter(maxTracesPerInterval: intervalLimit);
+ 
+-            var traceContext = new TraceContext(Tracer.Instance);
++            var tracerInstance = new Tracer();
++
++            var traceContext = new TraceContext(tracerInstance);
+ 
+             var barrier = new Barrier(parallelism + 1);
+ ","We're only testing `RateLimiter.Allowed(Span)`, so I think we can use a mock `ITraceContext` instead of a real `Tracer` or `TraceContext`.",Why do we need this?
+1824,"@@ -89,7 +89,8 @@ int main(int argc, char *argv[]) {
+     lbann_data::Model *pb_model = pb.mutable_model();
+ 
+     auto model = build_model_from_prototext(argc, argv, pb_trainer, pb,
+-                                            comm.get(), opts, io_thread_pool, true);
++                                            comm.get(), opts, trainer->get_name(), io_thread_pool,
++                                            trainer->get_callbacks(), true);
+ 
+     if (opts->has_string(""create_tarball"")) {
+       return EXIT_SUCCESS;","IMO, this is the wrong way to associate a model with a trainer... Why the string when you actually have a trainer object?",`trainer->get_callbacks()` can be `nullptr`
+1825,"@@ -217,7 +217,7 @@ void ledger_processor::state_block (rai::state_block const & block_a)
+ void ledger_processor::state_block_impl (rai::state_block const & block_a)
+ {
+ 	auto hash (block_a.hash ());
+-	auto existing (ledger.store.block_exists (transaction, hash));
++	auto existing (ledger.store.block_exists (transaction, block_a.type (), hash));
+ 	result.code = existing ? rai::process_result::old : rai::process_result::progress; // Have we seen this block before? (Unambiguous)
+ 	if (result.code == rai::process_result::progress)
+ 	{",Wondering if we can directly put types here & for other similar ledger_processor items like rai::block_type::state,`block_a.type()`  `block_a.hash()`?
+1826,"@@ -296,17 +296,8 @@ func pruneRepository(gopts GlobalOptions, repo restic.Repository) error {
+ 	}
+ 
+ 	if len(removePacks) != 0 {
+-		bar = newProgressMax(!gopts.Quiet, uint64(len(removePacks)), ""packs deleted"")
+-		bar.Start()
+-		for packID := range removePacks {
+-			h := restic.Handle{Type: restic.DataFile, Name: packID.String()}
+-			err = repo.Backend().Remove(ctx, h)
+-			if err != nil {
+-				Warnf(""unable to remove file %v from the repository\n"", packID.Str())
+-			}
+-			bar.Report(restic.Stat{Blobs: 1})
+-		}
+-		bar.Done()
++		Verbosef(""remove %d old packs\n"", len(removePacks))
++		DeleteFiles(gopts, repo, removePacks, restic.DataFile)
+ 	}
+ 
+ 	Verbosef(""done\n"")",As `DeleteFiles` is not only used for prune this function deserves its own file. Maybe something like `delete_files.go` or `parallel.go`?,"I think this should be `Verbosef(""remove %d"
+1827,"@@ -35,7 +35,7 @@ return [
+     'digits'               => ':attribute 必须是 :digits 位的数字。',
+     'digits_between'       => ':attribute 必须是介于 :min 和 :max 位的数字。',
+     'dimensions'           => ':attribute 图片尺寸不正确。',
+-    'distinct'             => ':attribute 已經存在。',
++    'distinct'             => ':attribute 已经存在。',
+     'email'                => ':attribute 不是一个合法的邮箱。',
+     'exists'               => ':attribute 不存在。',
+     'file'                 => ':attribute 必须是文件。',",It should be simplified character. `` -> ``,Why did you change this?
+1828,"@@ -33,5 +33,9 @@ namespace Nethermind.Trie
+         void VisitLeaf(TrieNode node, TrieVisitContext trieVisitContext, byte[] value = null);
+         
+         void VisitCode(Keccak codeHash, TrieVisitContext trieVisitContext);
++
++        bool VisitAccounts => true;
++        
++        int ParallelLevels => -1;
+     }
+ }","I am pretty sure it breaks the visitor pattern, visitor should have no knowledge about the structure of what it is visiting or control over visiting mechanism",Why do we need this?
+1829,"@@ -20,7 +20,7 @@ import java.util.stream.Collector;
+ import static javaslang.collection.Comparators.naturalComparator;
+ 
+ /**
+- * An {@link HashMap}-based implementation of {@link Multimap}
++ * An {@link TreeMap}-based implementation of {@link Multimap}
+  *
+  * @param <K> Key type
+  * @param <V> Value type",'A' instead of 'An' here,I think this should 
+1830,"@@ -37,7 +37,7 @@ import (
+ 
+ const (
+ 	// DefaultTimeout is the default timeout used to make calls
+-	DefaultTimeout = 10 * time.Second
++	DefaultTimeout = time.Second * 10
+ 	// DefaultLongPollTimeout is the long poll default timeout used to make calls
+ 	DefaultLongPollTimeout = time.Minute * 3
+ )","Can you flip it back (here and in other places)? It is more natural to represent ""10 seconds"" as `10 * time.Second`.",Why is this change n
+1831,"@@ -133,6 +133,11 @@ def test_classifier(output, centers, client, listen_port):
+         centers=centers
+     )
+ 
++    X_1, y_1, w_1, dX_1, dy_1, dw_1 = _create_data(
++        objective='classification',
++        output='array'
++    )
++
+     params = {
+         ""n_estimators"": 10,
+         ""num_leaves"": 10","Why was this necessary? You should just use the `dask_classifier` defined below this. With this change, you'd only be doing the local predict on arrays each time, but we want to test on all of DataFrame, Array, and sparse matrix.",why do you need this
+1832,"@@ -0,0 +1,6 @@
++<div class=""text-box-wrapper"">
++  <div class=""text-box"">
++    <h3><%= t('.added_to_github_repo') %></h3>
++    <p>Give it a few seconds for the background job to work, and then <%= link_to 'check out the repo', @purchaseable.github_url %>.</p>
++  </div>
++</div>","To me, this is sort of weird to have a completely separate page for this. Can we extract the different stuff (github, videos, downloads) presentation from the top of `app/views/purchases/show.html.erb` and reuse it on this page. I worry that we'll change things with fulfillment or copy and have to change it in multiple places.",This should be `<%= t('.added_to_github_repo') %>`
+1833,"@@ -1,6 +1,8 @@
+ package de.danoeh.antennapod.adapter;
+ 
+ import android.content.Context;
++import android.view.View;
++
+ import androidx.appcompat.app.AlertDialog;
+ 
+ import de.danoeh.antennapod.R;",Please revert the lines above. Not touching unrelated code keeps the git history clean.,import android.os.Bundle;
+1834,"@@ -0,0 +1,3 @@
++# Copyright (c) Open-MMLab. All rights reserved.
++
++__version__ = '2.3.0rc0'",`short_version` and `version_info`,This should be `2.3.0`
+1835,"@@ -52,7 +52,7 @@ type TaskStateChange struct {
+ 	Reason string
+ 
+ 	// Task is a pointer to the task involved in the state change that gives the event handler a hook into storing
+-	// what status was sent.  This is used to ensure the same event is handled only once.
++	// what stats was sent.  This is used to ensure the same event is handled only once.
+ 	Task *Task
+ }
+ ",This is supposed to be `status`. Why did you change this?,Why is this a pointer?
+1836,"@@ -1,3 +1,6 @@
++// Copyright 2012-2017 Apcera Inc. All rights reserved.
++// Copyright 2018 Synadia Communications Inc. All rights reserved.
++
+ package server
+ 
+ import (",I will change all of these at some point next week.,This should be `2018-2017`
+1837,"@@ -42,7 +42,7 @@ namespace Datadog.Trace.ClrProfiler
+         /// </summary>
+         public string TargetAssembly
+         {
+-            get => throw new NotSupportedException(""Use property TargetAssemblies instead of TargetAssembly."");
++            get => string.Empty;
+             set => TargetAssemblies = new[] { value };
+         }
+ ","I made this change because, while trying to debug, in Visual Studio, the `IntegrationSignatureTests`, this property getter was hit and interfered with my ability to complete the debugging.",Why did you change this?
+1838,"@@ -106,7 +106,8 @@ func determineDeploymentHealth(obj *unstructured.Unstructured) (status model.Kub
+ 	d := &appsv1.Deployment{}
+ 	err := scheme.Scheme.Convert(obj, d, nil)
+ 	if err != nil {
+-		desc = fmt.Sprintf(""Failed while convert %T to %T: %v"", obj, d, err)
++		status = model.KubernetesResourceState_OTHER
++		desc = fmt.Sprintf(""Unexpected error while calculating: failed while convert %T to %T: %v"", obj, d, err)
+ 		return
+ 	}
+ ","nit: `""Unexpected error while calculating: unable to convert %T to %T: %v""`",Why is this needed?
+1839,"@@ -87,6 +87,10 @@ public abstract class SampleConfig {
+   @JsonProperty(""packagePrefix"")
+   public abstract String packagePrefix();
+ 
++  /** Returns a sample application name. */
++  @JsonProperty(""appName"")
++  public abstract String appName();
++
+   /** Returns a map of method names to methods. */
+   @JsonProperty(""methods"")
+   public abstract Map<String, MethodInfo> methods();","I'd actually recommend not putting this in the `SampleConfig`, it's intended more for properties that are inherent of the discovery format. Add a method `getSampleAppName(String apiTypeName)` to `SampleNamer` and override it in the language specific `SampleNamer`s if needed. Then assign it in the transformer.",Why do we need this?
+1840,"@@ -53,6 +53,8 @@ export * from './standalone';
+ export * from './storage';
+ export * from './i18n';
+ export * from './helpers';
++export * from './sort-object-map-by-key';
++export * from './convert-array-to-keyed-object-map';
+ 
+ /**
+  * Remove a parameter from a URL string.","Do we need to export these new functions? I thought the plan going forward was to keep util imports separated to make circular imports less likely and possibly do better chunk splitting. Since only new code references these files, we can scope the import to the specific files.",I don't think we need to export this file.
+1841,"@@ -0,0 +1 @@
++require ""#{Rails.root}/app/models/acts_as_editable/acts_as_editable.rb""","Rails will autorequire `acts_as_editable` once it encounters the constant `ActsAsEditable`. Thus if we move `ActiveRecord::Base.send :include, ActsAsEditable` from _acts_as_editable.rb_ to this file, the require line will not be needed anymore. Instead of requiring the file ourselves, we will let Rails do it for us. This fix will also remove the need to explicitly require `acts_as_editable` in _mock_active_record_base.rb_.",Prefer double-quoted strings unless you ne
+1842,"@@ -23,6 +23,9 @@ public abstract class GrpcStreamingDetailView {
+ 
+   public abstract String methodName();
+ 
++  @Nullable
++  public abstract String upperCamelMethodName();
++
+   public abstract GrpcStreamingType grpcStreamingType();
+ 
+   @Nullable","I think we should name this `grpcMethodName` or similar. That is what this refers to, right? The fact that it is upper camel is an implementation.",Why is this nullable?
+1843,"@@ -47,6 +47,13 @@
+ 		}                                                              \
+ 	} while (false);
+ 
++#define VALIDATE_NAME(_N)                                                      \
++	do {                                                                   \
++		if (_N[0] == '.' || _N[0] == '/') {                            \
++			FPGA_MSG(""%s is not a valid input"", _N);               \
++			return FPGA_INVALID_PARAM;                             \
++		}                                                              \
++	} while (false);
+ 
+ fpga_result __FPGA_API__ xfpga_fpgaTokenGetObject(fpga_token token, const char *name,
+ 						  fpga_object *object, int flags)","What if .. appears, but not as the first character, eg ""errors/../../../../../../../../../../../""?",I don't think this is the right place for 
+1844,"@@ -81,7 +81,7 @@ class Guidance < ActiveRecord::Base
+ 
+   # Returns whether or not a given user can view a given guidance
+   # we define guidances viewable to a user by those owned by a guidance group:
+-  #   owned by the managing curation center
++  #   owned by the default orgs
+   #   owned by a funder organisation
+   #   owned by an organisation, of which the user is a member
+   #","Thanks, this should make things a bit easier for people who pick up the codebase but aren't a `curation center`","Should this be ""owned by the default organisation""?"
+1845,"@@ -122,6 +122,8 @@ public class AzkabanWebServer extends AzkabanServer {
+   private static final int MAX_FORM_CONTENT_SIZE = 10 * 1024 * 1024;
+   private static final String DEFAULT_TIMEZONE_ID = ""default.timezone.id"";
+   private static final String DEFAULT_STATIC_DIR = """";
++
++  @Deprecated
+   private static AzkabanWebServer app;
+   private final VelocityEngine velocityEngine;
+ ",why not removing it?,Why do we need to deprecate this?
+1846,"@@ -84,9 +84,9 @@ func NewCliApp() *cli.App {
+ 			EnvVar: ""TEMPORAL_CLI_TLS_CA"",
+ 		},
+ 		cli.BoolFlag{
+-			Name:   FlagTLSEnableHostVerification,
+-			Usage:  ""validates hostname of temporal cluster against server certificate"",
+-			EnvVar: ""TEMPORAL_CLI_TLS_ENABLE_HOST_VERIFICATION"",
++			Name:   FlagTLSDisableHostVerification,
++			Usage:  ""whether to validates hostname of temporal cluster against server certificate"",
++			EnvVar: ""TEMPORAL_CLI_TLS_DISABLE_HOST_VERIFICATION"",
+ 		},
+ 		cli.StringFlag{
+ 			Name:   FlagTLSServerName,","same nit here: maybe word as - ""disables validation of the temporal cluster's server certificate""",Why do we need to change this?
+1847,"@@ -59,6 +59,7 @@ public class TestFlinkCatalogDatabase extends FlinkCatalogTestBase {
+   @Test
+   public void testDefaultDatabase() {
+     sql(""USE CATALOG %s"", catalogName);
++    sql(""show tables"");
+ 
+     Assert.assertEquals(""Should use the current catalog"", getTableEnv().getCurrentCatalog(), catalogName);
+     Assert.assertEquals(""Should use the configured default namespace"",",Nit: other statements use all caps for SQL reserved words. Should this be `SHOW TABLES`?,Why is this needed?
+1848,"@@ -60,7 +60,7 @@ static bool is_a_code_line (const unsigned char *line)
+ 
+ static bool isLuaIdentifier (char c)
+ {
+-	return (bool) !(isspace(c)  || c == '(' || c == ')' || c == '=');
++	return (bool) !(isspace(c)  || c == '(' || c == ')' || c == '=' || c == '.' || c == ':');
+ }
+ 
+ static void extract_next_token (const char *begin, const char *end_sentinel, vString *name)","Do we need this? isLuaIdentifier() is used not only in extract_next_token() but also in extract_prev_toke(). I wonder whether the change for isLuaIdentifier() has an impact on extract_prev_toke() or not. If you are not sure, keep isLuaIdentifier() as is. If you are sure, could you write your conviction to the commit log.",I'm not sure if this is the right place to put this check. I think it would be better to put it in the `isLuaIdentifier` function.
+1849,"@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
+ 		c.VXLANMTU = hostMTU - vxlanMTUOverhead
+ 	}
+ 	if c.Wireguard.MTU == 0 {
+-		if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == ""WorkloadIPs"" {
++		if c.Wireguard.EncryptHostTraffic {
+ 			// The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes,
+ 			// see https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-tcpip-performance-tuning#azure-and-vm-mtu
+ 			// for details.",This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS.,Why do we need this change?
+1850,"@@ -71,7 +71,7 @@ var (
+ 
+ const (
+ 	projectFlagDescription  = ""Name of the project.""
+-	appFlagDescription      = ""Name of the application.""
++	svcFlagDescription      = ""Name of the service.""
+ 	envFlagDescription      = ""Name of the environment.""
+ 	pipelineFlagDescription = ""Name of the pipeline.""
+ 	profileFlagDescription  = ""Name of the profile.""",Do we need to change this flag as well?,"I think this should be ""Name of the service."""
+1851,"@@ -10,7 +10,9 @@ module.exports = function (grunt) {
+ 				return grunt.file.read(fn);
+ 			}).join('\n');
+ 
+-			grunt.file.write(fileset.dest, 'exports.source = ' + JSON.stringify(source) + ';');
++			var file = grunt.file.read(fileset.dest);
++
++			grunt.file.write(fileset.dest, file + 'module.exports.source = ' + JSON.stringify(source) + ';');
+ 		});
+ 	});
+ };",Including the source twice here makes the filesize jump to 432kb. Is there any way to minimize repeating it?,I don't think this is the right way to do this. I think it should be `exports.source = module.exports.source`
+1852,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",I think this should be `nameOrHandle`
+1853,"@@ -76,7 +76,15 @@ module Bolt
+       target = request['target']
+       plan_vars = shadow_vars('plan', request['plan_vars'], target['facts'])
+       target_vars = shadow_vars('target', target['variables'], target['facts'])
+-      topscope_vars = target_vars.merge(plan_vars)
++
++      # Merge plan vars with target vars, while maintaining the order of the plan
++      # vars. It's critical that the order of plan vars is not changed, as Puppet
++      # will deserialize the variables in the order they appear. Variables may
++      # contain local references to variables that appear earlier in a plan. If
++      # these variables are moved before the variable they reference, Puppet will
++      # be unable to deserialize the data and raise an error.
++      topscope_vars = target_vars.reject { |k, _v| plan_vars.key?(k) }.merge(plan_vars)
++
+       env_conf = { modulepath: request['modulepath'],
+                    facts: target['facts'],
+                    variables: topscope_vars }",Only one line of code? What a simple issue!,I'm not sure if this is the best way 
+1854,"@@ -111,10 +111,8 @@ func NewHandler(
+ 		status:          common.DaemonStatusInitialized,
+ 		config:          config,
+ 		tokenSerializer: common.NewProtoTaskTokenSerializer(),
+-		rateLimiter: quotas.NewDynamicRateLimiter(
+-			func() float64 {
+-				return float64(config.RPS())
+-			},
++		rateLimiter: quotas.NewDefaultIncomingDynamicRateLimiter(
++			func() float64 { return float64(config.RPS()) },
+ 		),
+ 	}
+ ",Conceptual question: why do history and matching need throttler at all? Shouldn't throttling to be handled on FE only?,Why is this change needed?
+1855,"@@ -126,12 +126,14 @@ func (n *NetworkPolicyController) deleteCNP(old interface{}) {
+ 	n.deleteDereferencedAddressGroups(oldInternalNP)
+ }
+ 
+-// reprocessCNP is triggered by Namespace ADD/UPDATE/DELETE events when they impact the
+-// per-namespace rules of a CNP.
+-func (n *NetworkPolicyController) reprocessCNP(cnp *crdv1alpha1.ClusterNetworkPolicy) {
++// reprocessCNP is triggered when a CNP may be impacted by non-ClusterNetworkPolicy events, including Namespace events
++// (for per-namespace rules) and ClusterGroup events (for ClusterGroup reference).
++func (n *NetworkPolicyController) reprocessCNP(cnp *crdv1alpha1.ClusterNetworkPolicy, enqueueAppliedToGroup bool) {
+ 	key := internalNetworkPolicyKeyFunc(cnp)
+ 	n.internalNetworkPolicyMutex.Lock()
+ 	oldInternalNPObj, exist, _ := n.internalNetworkPolicyStore.Get(key)
++	// The internal NetworkPolicy may haven't been created yet. It's fine to skip processing this CNP as addCNP will
++	// create it eventually.
+ 	if !exist {
+ 		klog.V(2).Infof(""Cannot find the original internal NetworkPolicy, skip reprocessCNP"")
+ 		n.internalNetworkPolicyMutex.Unlock()","Would this be possible: `addCNP` has already processed the CNP to an internalNP, just hasn't added this internalNP to the `internalNetworkPolicyStore`. In this case, `reprocessCNP` will skip processing this CNP and `addCNP` will just add the ""old"" internalNP to `internalNetworkPolicyStore`.",I don't think we need to pass enqueue
+1856,"@@ -22,6 +22,11 @@ module CartsHelper
+     current_linear_approval?(cart, user)
+   end
+ 
++  # Todo: Move this to an NCR specific template?
++  def display_restart?(cart, user)
++    cart.ncr? && user == cart.requester && (cart.pending? || cart.rejected?)
++  end
++
+   def parallel_approval_is_pending?(cart, user)
+     return false unless cart.parallel?
+     if approval = Approval.find_by(cart_id: cart.id, user_id: user.id)",Minor: you can access `current_user` in here directly - don't need to pass it in. Unless you prefer passing it explicitly?,I don't think this is the right place to put this method. I think it should be in the `NcrController` instead.
+1857,"@@ -45,6 +45,7 @@ module Mongoid
+         # @param [ Hash ] attributes The attributes hash to attempt to set.
+         # @param [ Hash ] options The options defined.
+         def initialize(association, attributes, options = {})
++          attributes = attributes&.to_h if attributes.respond_to?(:keys)
+           if attributes.respond_to?(:with_indifferent_access)
+             @attributes = attributes.with_indifferent_access.sort do |a, b|
+               a[0].to_i <=> b[0].to_i",What is the purpose of `&` on this line?,Why do we need to do this?
+1858,"@@ -58,5 +58,5 @@ export function isValidPropertySelection( value ) {
+  * @return {boolean} TRUE if the web data stream ID is valid, otherwise FALSE.
+  */
+ export function isValidWebDataStreamID( webDataStreamID ) {
+-	return typeof webDataStreamID === 'string' && /\d+/.test( webDataStreamID );
++	return typeof webDataStreamID === 'string' && /^[a-zA-Z0-9]+$/.test( webDataStreamID );
+ }","See above, the `isValidWebDataStreamID` implementation from before is actually correct. What we need here instead is a new `isValidMeasurementID` function.",I think this should be `/^[a-zA-Z0-9]+$/`
+1859,"@@ -628,7 +628,12 @@ func (s *Server) createLeafNode(conn net.Conn, remote *leafNodeCfg) *client {
+ 
+ 		c.mu.Unlock()
+ 		// Error will be handled below, so ignore here.
+-		c.parse([]byte(info))
++		err = c.parse([]byte(info))
++		if err != nil {
++			c.Debugf(""Error reading remote leafnode's INFO: %s"", err)
++			c.closeConnection(ReadError)
++			return nil
++		}
+ 		c.mu.Lock()
+ 
+ 		if !c.flags.isSet(infoReceived) {",Should be an error... it is important for the admin of the server attempting to create the leafnode connection to see the error asap.,Shouldn't this be `return err`?
+1860,"@@ -313,6 +313,15 @@ def speakObjectProperties(obj,reason=controlTypes.REASON_QUERY,index=None,**allo
+ 	newPropertyValues['current']=obj.isCurrent
+ 	if allowedProperties.get('placeholder', False):
+ 		newPropertyValues['placeholder']=obj.placeholder
++	# When speaking an object due to a focus change, the 'selected' state should not be reported if only one item is selected.
++	# This is because that one item will be the focused object, and saying selected is redundant.
++	# Rather, 'unselected' will be spoken for an unselected object if 1 or more items are selected. 
++	
++	states=newPropertyValues.get('states')
++	if states is not None and reason==controlTypes.REASON_FOCUS:
++		if controlTypes.STATE_SELECTABLE in states and controlTypes.STATE_SELECTED in states and obj.selectionContainer and obj.selectionContainer.getSelectedItemsCount(2)==1:
++			states.discard(controlTypes.STATE_SELECTED)
++			states.discard(controlTypes.STATE_SELECTABLE)
+ 	#Get the speech text for the properties we want to speak, and then speak it
+ 	text=getSpeechTextForProperties(reason,**newPropertyValues)
+ 	if text:",Could you split these conditions up over multiple lines please.,missing whitespace around operator
+1861,"@@ -33,7 +33,7 @@ func (t *tag) parseJSONTag(structTag reflect.StructTag) {
+ }
+ 
+ func (t *tag) parseTagStr(tagStr string) {
+-	parts := strings.SplitN(tagStr, "","", 2)
++	parts := strings.SplitN(tagStr, "","", 3)
+ 	if len(parts) == 0 {
+ 		return
+ 	}",I think we can just change this to `Split` instead of `SplitN`. I don't think we need to limit the number of parts in the tag.,Why did you change this?
+1862,"@@ -69,10 +69,8 @@ services:
+     image: {{ .router_image }}:{{ .router_tag }}
+     container_name: nginx-proxy
+     ports:
+-      - ""80:80""
+-      - {{ .mailhogport }}:{{ .mailhogport }}
+-      - {{ .dbaport }}:{{ .dbaport }}
+-      - {{ .dbport }}:{{ .dbport }}
++      {{ range $port := .ports }}- ""{{ $port }}:{{ $port }}""
++      {{ end }}
+     volumes:
+       - /var/run/docker.sock:/tmp/docker.sock:ro
+ networks:","So this is actually a mistake that I introduced without realizing it, and have known would need to be fixed when we get here  . The format of the ports directive is ""host:container"". We only want the host port to change, not the internal container ports. The ports variable probably needs to be a map which maps external -> internal ports.",I think this should be `{{ .ports 
+1863,"@@ -1176,7 +1176,9 @@ func (s *ContextImpl) transitionLocked(request contextRequest) {
+ 		s.state = contextStateStopping
+ 		// The change in state should cause all write methods to fail, but just in case, set this also,
+ 		// which will cause failures at the persistence level
+-		s.shardInfo.RangeId = -1
++		if s.shardInfo != nil {
++			s.shardInfo.RangeId = -1
++		}
+ 		// This will cause the controller to remove this shard from the map and then call s.stop()
+ 		go s.closeCallback(s)
+ 	}","An alternate approach would be to always initialize shardInfo with a dummy (non-nil) value, which could protect against other uses before it's initialized (I couldn't find any though). But I can change it to do it that way instead.",Why is this needed?
+1864,"@@ -960,3 +960,8 @@ func SessionInfoFromProtocol(session keybase1.Session) (SessionInfo, error) {
+ 		VerifyingKey:   verifyingKey,
+ 	}, nil
+ }
++
++// NodeMetadata has metadata about a node needed for higher level operations.
++type NodeMetadata struct {
++	LastWriter keybase1.UID
++}","Maybe we can just put the entire `DirEntry` in here? I can imagine it might be useful for debugging to get the block ID/refnonce, encrypted size, key gen, data version, etc. What do you think?",Why do we need this?
+1865,"@@ -49,9 +49,9 @@ ewmh_client_update_hints(lua_State *L)
+         state[i++] = _NET_WM_STATE_MODAL;
+     if(c->fullscreen)
+         state[i++] = _NET_WM_STATE_FULLSCREEN;
+-    if(c->maximized_vertical)
++    if(c->maximized_vertical || c->maximized)
+         state[i++] = _NET_WM_STATE_MAXIMIZED_VERT;
+-    if(c->maximized_horizontal)
++    if(c->maximized_horizontal || c->maximized)
+         state[i++] = _NET_WM_STATE_MAXIMIZED_HORZ;
+     if(c->sticky)
+         state[i++] = _NET_WM_STATE_STICKY;","For the commit message: The paragraphs seem to be out of order? The `Would not work because` refers to the stuff before, but there is a `This may seem pointless, but` in-between.",Shouldn't this be `|
+1866,"@@ -88,12 +88,6 @@ var (
+ 	prelude = []string{
+ 		""universe"",
+ 		""influxdata/influxdb"",
+-		""math"",
+-		""strings"",
+-		""regexp"",
+-		""date"",
+-		""json"",
+-		""http"",
+ 	}
+ 	preludeScope = &scopeSet{
+ 		packages: make([]*interpreter.Package, len(prelude)),","Why did you remove these packages from the prelude, will your new functions not work without this change?",Why are these remove
+1867,"@@ -36,10 +36,14 @@ GetProcessor::asyncProcess(PartitionID part,
+                            const std::vector<std::string>& keys) {
+     folly::Promise<std::pair<PartitionID, kvstore::ResultCode>> promise;
+     auto future = promise.getFuture();
++    std::vector<std::string> kvKeys;
++    std::transform(keys.begin(), keys.end(), std::back_inserter(kvKeys),
++                   [part](const auto& key) { return NebulaKeyUtils::kvKey(part, key); });
+ 
+-    executor_->add([this, p = std::move(promise), part, keys] () mutable {
++    executor_->add([this, p = std::move(promise), part, &keys,
++                    kvKeys = std::move(kvKeys)] () mutable {
+         std::vector<std::string> values;
+-        auto ret = this->kvstore_->multiGet(space_, part, keys, &values);
++        auto ret = this->kvstore_->multiGet(space_, part, kvKeys, &values);
+         if (ret == kvstore::ResultCode::SUCCEEDED) {
+             std::lock_guard<std::mutex> lg(this->lock_);
+             for (int32_t i = 0; i < static_cast<int32_t>(keys.size()); i++) {",We'd better reserve enough space before using kvKeys to avoid extra malloc.,nit: `std::move(kvKe
+1868,"@@ -213,3 +213,12 @@ func GetLocalPVType(pv *v1.PersistentVolume) string {
+ 	}
+ 	return """"
+ }
++
++// GetNodeHostname extracts the Hostname from the labels on the Node
++func GetNodeHostname(n *v1.Node) string {
++	hostname, found := n.Labels[KeyNodeHostname]
++	if found {
++		return hostname
++	}
++	return n.Name
++}",would it make sense to return empty or error if label doesn't exists?,I don't think we need this function.
+1869,"@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
+ exports.rmDir = function(path) {
+   return new promise.Promise(function(fulfill, reject) {
+     var numAttempts = 0;
++    var maxAttempts = 5;
++    var attemptTimeout = 250;
+     attemptRm();
+     function attemptRm() {
+       numAttempts += 1;
+       rimraf(path, function(err) {
+         if (err) {
+-          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+-            attemptRm();
++          if (err.code === 'ENOTEMPTY' && numAttempts <= maxAttempts) {
++            setTimeout(attemptRm, attemptTimeout);
+             return;
+           }
+           reject(err);",Don't penalize everyone with 250ms delay b/c some machines have problems.,I think this should be `numAttempts 
+1870,"@@ -119,6 +119,15 @@ func (s SortedCidSet) Equals(s2 SortedCidSet) bool {
+ 	return true
+ }
+ 
++// String returns a string listing the cids in the set.
++func (s SortedCidSet) String() string {
++	out := ""{""
++	for it := s.Iter(); !it.Complete(); it.Next() {
++		out = fmt.Sprintf(""%s %s"", out, it.Value().String())
++	}
++	return out + "" }""
++}
++
+ // MarshalJSON serializes the set to JSON.
+ func (s SortedCidSet) MarshalJSON() ([]byte, error) {
+ 	return json.Marshal(s.s)",Probably want a space after the second %s?,I'm not sure if this is the best way
+1871,"@@ -206,7 +206,7 @@ func (h *historyArchiver) Get(
+ 	dirPath := URI.Path()
+ 	exists, err := directoryExists(dirPath)
+ 	if err != nil {
+-		return nil, serviceerror.NewInternal(err.Error())
++		return nil, serviceerror.NewUnavailable(err.Error())
+ 	}
+ 	if !exists {
+ 		return nil, serviceerror.NewInvalidArgument(archiver.ErrHistoryNotExist.Error())",This seems like an internal error still?,Shouldn't this be `ServiceUnavailabl
+1872,"@@ -85,7 +85,7 @@ describe PurchasesController do
+ 
+       post :create, purchase: customer_params(stripe_token), product_id: product.to_param
+ 
+-      FakeStripe.should have_charged(1500).to('test@example.com').with_token(stripe_token)
++      expect(FakeStripe).to have_charged(1500).to('test@example.com').with_token(stripe_token)
+     end
+   end
+ ",Line is too long. [94/80],Line is too long. [81/80]
+1873,"@@ -125,10 +125,16 @@ func (a *ClusterIdentityAllocator) Run(stopCh <-chan struct{}) {
+ 	}
+ }
+ 
++type ClusterIdentity struct {
++	UUID uuid.UUID
++}
++
+ // ClusterIdentityProvider is an interface used to retrieve the cluster identity information (UUID),
+-// as provided by the user or generated by the Antrea Controller.
++// as provided by the user or generated by the Antrea Controller. It also returns the time at which
++// the antrea-cluster-identity was created, which can typically be considered as the time at which
++// Antrea was deployed to the cluster.
+ type ClusterIdentityProvider interface {
+-	Get() (uuid.UUID, error)
++	Get() (ClusterIdentity, time.Time, error)
+ }
+ 
+ type clusterIdentityProvider struct {","out of curiosity, why creating another struct to wrap it?",nit: `as the time at whic
+1874,"@@ -9549,8 +9549,15 @@ bool Bot::UseDiscipline(uint32 spell_id, uint32 target) {
+ 			if(spells[spell_id].timer_id > 0 && spells[spell_id].timer_id < MAX_DISCIPLINE_TIMERS)
+ 				SetDisciplineRecastTimer(spells[spell_id].timer_id, spell.recast_time);
+ 		} else {
+-			uint32 remain = (GetDisciplineRemainingTime(this, spells[spell_id].timer_id) / 1000);
+-			GetOwner()->Message(Chat::White, ""%s can use this discipline in %d minutes %d seconds."", GetCleanName(), (remain / 60), (remain % 60));
++			uint32 remaining_time = (GetDisciplineRemainingTime(this, spells[spell_id].timer_id) / 1000);			
++			GetOwner()->Message(
++				Chat::White,
++				fmt::format(
++					""{} can use this Discipline in {}."",
++					GetCleanName(),
++					ConvertSecondsToTime(remaining_time)
++				).c_str()
++			);
+ 			return false;
+ 		}
+ 	}",discipline vs. Discipline? Not sure of which is correct. Also not sure if there is already an existing string const.,I don't think you need th
+1875,"@@ -135,6 +135,7 @@ public abstract class ResourceDescriptorConfig {
+                       .setEntityId(nameMap.get(p).toUpperCamel())
+                       .setEntityName(overrideConfig.getEntityName())
+                       .setCommonResourceName(overrideConfig.getCommonResourceName())
++                      .setAssignedProtoFile(protoFile)
+                       .build();
+                 } else {
+                   return SingleResourceNameConfig.newBuilder()","I believe this will break common resources, as they are defined in a common file, but must generate classes in service-specific namespace, so using protoFile to determine package of the generated class would not work, because common_resources namespace does not match service namespace.",I think this should be `s
+1876,"@@ -63,6 +63,8 @@ NATURAL_ORDER_COLUMN_NAME = ""__natural_order__""
+ 
+ HIDDEN_COLUMNS = {NATURAL_ORDER_COLUMN_NAME}
+ 
++SERIES_DEFAULT_NAME = ""0""
++
+ 
+ class InternalFrame(object):
+     """"""",How about `SPARK_DEFAULT_SERIES_NAME`?,"SERIES_DEFAULT_NAME = ""0"""
+1877,"@@ -36,9 +36,18 @@ public class TableProperties {
+   public static final String COMMIT_TOTAL_RETRY_TIME_MS = ""commit.retry.total-timeout-ms"";
+   public static final int COMMIT_TOTAL_RETRY_TIME_MS_DEFAULT = 1800000; // 30 minutes
+ 
+-  public static final String COMMIT_NUM_STATUS_CHECKS = ""commit.num-status-checks"";
++  public static final String COMMIT_NUM_STATUS_CHECKS = ""commit.status-checks.num-retries"";
+   public static final int COMMIT_NUM_STATUS_CHECKS_DEFAULT = 3;
+ 
++  public static final String COMMIT_STATUS_CHECKS_MIN_WAIT_MS = ""commit.status-check.min-wait-ms"";
++  public static final long COMMIT_STATUS_CHECKS_MIN_WAIT_MS_DEFAULT = 1000L; // 1s
++
++  public static final String COMMIT_STATUS_CHECKS_MAX_WAIT_MS = ""commit.status-check.max-wait-ms"";
++  public static final long COMMIT_STATUS_CHECKS_MAX_WAIT_MS_DEFAULT = 60000L; // 1 minute
++
++  public static final String COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS = ""commit.status-check.total-timeout-ms"";
++  public static final long COMMIT_STATUS_CHECKS_TOTAL_WAIT_MS_DEFAULT = 1800000; // 30 minutes
++
+   public static final String MANIFEST_TARGET_SIZE_BYTES = ""commit.manifest.target-size-bytes"";
+   public static final long MANIFEST_TARGET_SIZE_BYTES_DEFAULT = 8388608; // 8 MB
+ ","The other properties are in `commit.status-check`, not `commit.status-checks`. Could you remove the extra `s`?",I think this should be `c
+1878,"@@ -6,6 +6,12 @@ var setupDatabase = require('./shared').setupDatabase;
+ 
+ describe('Authentication', function() {
+   before(function() {
++    const configuration = this.configuration;
++    if (configuration.usingUnifiedTopology()) {
++      // The unified topology does not currently support authentication
++      return this.skip();
++    }
++
+     return setupDatabase(this.configuration);
+   });
+ ",Side note: I'd love to see more of these fields exposed on configuration.,Why do we need to skip th
+1879,"@@ -5,7 +5,7 @@
+   contact_us = (Rails.configuration.branding[:organisation][:contact_us_url] || contact_us_url)
+   email_subject = _('Query or feedback related to %{tool_name}') %{ :tool_name => tool_name }
+   user_name = User.find_by(email: @resource.email).nil? ?  @resource.email : User.find_by(email: @resource.email).name(false)
+-  inviter_name = @resource.is_a?(User) ? @resource.invited_by.name(false) : @resource.invited_by.name
++  inviter_name = @resource.invited_by.name
+ %>
+ <% FastGettext.with_locale FastGettext.default_locale do %>
+   <p>","In the case of accounts generated by API clients, what name gets put for the `inviter_name` or `invited_by` record?",I'm not sure if this is t
+1880,"@@ -33,6 +33,8 @@ public class MutableQbftConfigOptions extends MutableBftConfigOptions implements
+         qbftConfigOptions.getValidatorContractAddress().map(String::toLowerCase);
+   }
+ 
++  // TODO-lucas do I need to implement getStartBlock here?
++
+   @Override
+   public Optional<String> getValidatorContractAddress() {
+     return validatorContractAddress;","I think this class is only relevant for updating the QbftConfigOptions based on the transitions config, so probably not.",// TODO-lucas do I need to implement getStartBlock here?
+1881,"@@ -89,5 +89,10 @@ namespace Nethermind.JsonRpc
+         /// 
+         /// </summary>
+         public const int ExecutionError = -32015;
++         
++        /// <summary>
++        /// Request exceedes defined tracer timeout limit
++        /// </sumary>
++        public const int TracerTimeout = -32016;
+     }
+ }",what is the number thrown by Geth?,I think this should be `-32016`.
+1882,"@@ -2036,8 +2036,8 @@ common.checkDatabaseConfigMatch = (apiConfig, frontendConfig) => {
+                 // mongodb0.example.com:27017
+                 let apiMongoHost = apiConfig.split(""/"")[2];
+                 let frontendMongoHost = frontendConfig.split(""/"")[2];
+-                let apiMongoDb = apiConfig.split(""/"")[3];
+-                let frontendMongoDb = frontendConfig.split(""/"")[3];
++                let apiMongoDb = apiConfig.split(""/"")[3].split('?')[0];
++                let frontendMongoDb = frontendConfig.split(""/"")[3].split('?')[0];
+                 if (apiMongoHost === frontendMongoHost && apiMongoDb === frontendMongoDb) {
+                     return true;
+                 }","This would still crash on malformed database connection string like ""test""",Why do we need this change?
+1883,"@@ -0,0 +1,14 @@
++package interfaces
++
++import ""context""
++
++type pluginNameKey struct{}
++
++func PluginNameFromHostServiceContext(ctx context.Context) (string, bool) {
++	name, ok := ctx.Value(pluginNameKey{}).(string)
++	return name, ok
++}
++
++func WithPluginName(ctx context.Context, name string) context.Context {
++	return context.WithValue(ctx, pluginNameKey{}, name)
++}","it is not an interface, maybe we can move to another package?",Why do we need this function?
+1884,"@@ -4,14 +4,15 @@ import { stopPropagation, stopImmediatePropagation, isImmediatePropagationStoppe
+ import { getEditorInstance } from './editors';
+ import EventManager from './eventManager';
+ import { EditorState } from './editors/_baseEditor';
++import { getParentWindow } from './helpers/dom/element';
+ 
+ class EditorManager {
+   /**
+    * @param {Handsontable} instance
+-   * @param {GridSettings} priv
++   * @param {GridSettings} tableMeta
+    * @param {Selection} selection
+    */
+-  constructor(instance, priv, selection) {
++  constructor(instance, tableMeta, selection) {
+     /**
+      * Instance of {@link Handsontable}
+      *",Same here. Can we use `this.instance.getSettings()` to get `tableMeta`?,Why do we need this?
+1885,"@@ -13,7 +13,15 @@ import (
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ )
+ 
++func isCpuSet(cgroup *configs.Cgroup) bool {
++	return cgroup.Resources.CpuWeight != 0 || cgroup.Resources.CpuMax != """"
++}
++
+ func setCpu(dirPath string, cgroup *configs.Cgroup) error {
++	if !isCpuSet(cgroup) {
++		return nil
++	}
++
+ 	// NOTE: .CpuShares is not used here. Conversion is the caller's responsibility.
+ 	if cgroup.Resources.CpuWeight != 0 {
+ 		if err := fscommon.WriteFile(dirPath, ""cpu.weight"", strconv.FormatUint(cgroup.Resources.CpuWeight, 10)); err != nil {",Not sure whether this validation is useful.,Why not just `return
+1886,"@@ -422,6 +422,17 @@ class PromptContainer(QWidget):
+         except UnsupportedOperationError:
+             pass
+ 
++    @cmdutils.register(instance='prompt-container', scope='window',
++                       modes=[usertypes.KeyMode.prompt])
++    def prompt_yank(self):
++        """"""Yank URLs or other data in prompts.""""""
++        question = self._prompt.question
++        s = None
++        if question and hasattr(question, 'yank_text'):
++            s = question.yank_text
++        utils.set_clipboard(s)
++        message.info(""Yanked download URL to clipboard: {}"".format(s))
++
+ 
+ class LineEdit(QLineEdit):
+ ","Various things to note here: - Why would `question` ever be falsey (or `None`) here, i.e. why the `if question`? - Why would `question` ever not have that attribute? You set it in `Question.__init__`, so that check does nothing at all (and generally, `hasattr()` should be avoided if possible). - Why do you want to yank `None` (what does that do?) rather than e.g. show an error if there's nothing to yank?",Please remove this b
+1887,"@@ -121,8 +121,10 @@ def buffer_s3response(s3response):
+             found_records = True
+         elif 'Progress' in event:
+             logger_.info(""select progress: %s"", event['Progress'].get('Details'))
++            print(event['Progress'].get('Details'))
+         elif 'Stats' in event:
+             logger_.info(""select stats: %s"", event['Stats'])
++            print(event['Stats'])
+         elif 'End' in event:
+             # End event indicates that the request finished successfully
+             end_event_received = True","If this is needed for testing, you should use `pytest --log-cli-level=INFO` instead.",Is this intentional?
+1888,"@@ -115,7 +115,7 @@ func DefaultNodeOptions() *MobileNodeOptions {
+ 		EtherClientRPC:                  metadata.Testnet2Definition.EtherClientRPC,
+ 		FeedbackURL:                     ""https://feedback.mysterium.network"",
+ 		QualityOracleURL:                ""https://testnet2-quality.mysterium.network/api/v1"",
+-		IPDetectorURL:                   ""https://api.ipify.org/?format=json"",
++		IPDetectorURL:                   ""https://testnet2-location.mysterium.network/api/v1/location"",
+ 		LocationDetectorURL:             ""https://testnet2-location.mysterium.network/api/v1/location"",
+ 		TransactorEndpointAddress:       metadata.Testnet2Definition.TransactorAddress,
+ 		TransactorRegistryAddress:       metadata.Testnet2Definition.RegistryAddress,",We should drop ipify in all places i guess,Why was this changed?
+1889,"@@ -137,8 +137,8 @@ type ConsensusParams struct {
+ 	DownCommitteeSize      uint64
+ 	DownCommitteeThreshold uint64
+ 
+-	FilterTimeoutSmallLambdas             uint64
+-	FilterTimeoutPeriod0SmallLambdas      uint64
++	AgreementFilterTimeout        time.Duration
++	AgreementFilterTimeoutPeriod0 time.Duration
+ 
+ 	FastRecoveryLambda    time.Duration // time between fast recovery attempts
+ 	FastPartitionRecovery bool          // set when fast partition recovery is enabled","Add explanations around these variables - what do they mean, how they should be configured, etc.",I think this should b
+1890,"@@ -106,6 +106,11 @@ class SiteController < ApplicationController
+     @locale = params[:about_locale] || I18n.locale
+   end
+ 
++  def communities
++    OsmCommunityIndex::LocalChapter.add_to_i18n # this should be called on app init
++    @local_chapters = OsmCommunityIndex::LocalChapter.local_chapters
++  end
++
+   def export; end
+ 
+   def offline; end","One thing tho - I would really appreciate any advice on where to move this to, so that it's called on initialisation of the website.",I'm not sure if this 
+1891,"@@ -321,4 +321,16 @@ public interface GauntletConfig extends Config
+ 	{
+ 		return false;
+ 	}
++
++	@ConfigItem(
++			position = 21,
++			keyName = ""displayResources"",
++			name = ""Show raw resources gathered"",
++			description = ""Displays how much of each resource you have gathered."",
++			titleSection = ""resources""
++	)
++	default boolean displayGatheredResources()
++	{
++		return false;
++	}
+ }",To much tabs here (1 tab),This should be `showG
+1892,"@@ -135,12 +135,12 @@ public class ExecutionLogsDao {
+     }
+   }
+ 
+-  int removeExecutionLogsByTime(final long millis)
++  int removeExecutionLogsByTime(final long millis, final int recordCleanupLimit)
+       throws ExecutorManagerException {
+     final String DELETE_BY_TIME =
+-        ""DELETE FROM execution_logs WHERE upload_time < ?"";
++        ""DELETE FROM execution_logs WHERE upload_time < ? LIMIT ?"";
+     try {
+-      return this.dbOperator.update(DELETE_BY_TIME, millis);
++      return this.dbOperator.update(DELETE_BY_TIME, millis, recordCleanupLimit);
+     } catch (final SQLException e) {
+       logger.error(""delete execution logs failed"", e);
+       throw new ExecutorManagerException(",This is not maintaining retention time for logs as we are deleting only 1000 entries and we might end up with huge number of rows spanning over multiple months over a period of time if the cluster generates more rows as we are restricting ourselves to delete only 24k rows/day. Like I pointed out earlier a better would be to probably run this clean up every hour with some batch_size in a loop while there are records to be deleted(i.e older than 12 weeks) and committing each batch.,Why do we need a limit here?
+1893,"@@ -1319,10 +1319,10 @@ func (s *timerQueueActiveTaskExecutorSuite) TestWorkflowTimeout_ContinueAsNew_Re
+ 	// need to override the workflow retry policy
+ 	executionInfo := mutableState.executionInfo
+ 	executionInfo.HasRetryPolicy = true
+-	executionInfo.WorkflowExpirationTime = s.now.Add(1000 * time.Second)
++	executionInfo.WorkflowExpirationTime = timestamp.TimeNowPtrUtcAddSeconds(1000)
+ 	executionInfo.MaximumAttempts = 10
+-	executionInfo.InitialInterval = 1
+-	executionInfo.MaximumInterval = 1
++	executionInfo.InitialInterval = timestamp.DurationFromSeconds(1)
++	executionInfo.MaximumInterval = timestamp.DurationFromSeconds(1)
+ 	executionInfo.BackoffCoefficient = 1
+ 
+ 	di := addWorkflowTaskScheduledEvent(mutableState)","I don't like this helper func :-). Yeah, definitely don't like.",why do we need to change thi
+1894,"@@ -18,17 +18,7 @@ describe( 'PageSpeed Insights Activation', () => {
+ 	beforeAll( async () => {
+ 		await page.setRequestInterception( true );
+ 		useRequestInterception( ( request ) => {
+-			if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
+-				request.respond( { status: 200 } );
+-			} else if (
+-				request
+-					.url()
+-					.match(
+-						'google-site-kit/v1/modules/pagespeed-insights/data/pagespeed'
+-					)
+-			) {
+-				request.respond( { status: 200, body: JSON.stringify( {} ) } );
+-			} else if (
++			if (
+ 				request
+ 					.url()
+ 					.match(","Same here. This should remain unchanged. Please, add it back.",Why is this removed?
+1895,"@@ -2052,6 +2052,9 @@ Collection.prototype.mapReduce = function(map, reduce, options, callback) {
+  */
+ Collection.prototype.initializeUnorderedBulkOp = function(options) {
+   options = options || {};
++  if (this.s.options.ignoreUndefined) {
++    options.ignoreUndefined = this.s.options.ignoreUndefined;
++  }
+   options.promiseLibrary = this.s.promiseLibrary;
+   return unordered(this.s.topology, this, options);
+ };",@kvwalker should this method have `ignoreUndefined` supported as an `option`?,Why do we need this?
+1896,"@@ -52,10 +52,11 @@ func New(_ *any.Any, logger *zap.Logger, _ tally.Scope) (service.Service, error)
+ 		return nil, errors.New(""experiment store wrong type"")
+ 	}
+ 
+-	transformer := NewTransformer()
++	sugaredLogger := logger.Sugar()
++	transformer := NewTransformer(sugaredLogger)
+ 	return &storer{
+ 		client.DB(),
+-		logger.Sugar(),
++		sugaredLogger,
+ 		&transformer,
+ 	}, nil
+ }","we dont use a `sugaredlogger` anywhere else in clutch, just curious why were using it here?",Why is this needed?
+1897,"@@ -388,7 +388,6 @@ class ServerCallback(MessageCallback):
+         if not self._queue:
+             self._active = False
+             return
+-        self._queue = []
+         # Get unique event types in the queue
+         events = list(OrderedDict([(event.event_name, event)
+                                    for event in self._queue]).values())",Not evident from looking at this diff but the queue is already being cleared four lines below.,Why was this remove
+1898,"@@ -293,6 +293,16 @@ func (pool *TransactionPool) computeFeePerByte() uint64 {
+ // checkSufficientFee take a set of signed transactions and verifies that each transaction has
+ // sufficient fee to get into the transaction pool
+ func (pool *TransactionPool) checkSufficientFee(txgroup []transactions.SignedTxn) error {
++	// Special case: the compact cert transaction, if issued from the
++	// special compact-cert-sender address, in a singleton group, pays
++	// no fee.
++	if len(txgroup) == 1 {
++		t := txgroup[0].Txn
++		if t.Type == protocol.CompactCertTx && t.Sender == transactions.CompactCertSender && t.Fee.IsZero() {
++			return nil
++		}
++	}
++
+ 	// get the current fee per byte
+ 	feePerByte := pool.computeFeePerByte()
+ ",Why is this a 'transaction' and not in the block header?,I think this should
+1899,"@@ -2,12 +2,14 @@
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+ 
+ using System.IO;
++using System.Security.Cryptography.X509Certificates;
+ 
+ namespace Microsoft.AspNet.Server.Kestrel.Filter
+ {
+     public class ConnectionFilterContext
+     {
+         public ServerAddress Address { get; set; }
+-        public Stream Connection { get; set;  }
++        public Stream Connection { get; set; }
++        public X509Certificate2 ClientCertificate { get; set; }
+     }
+ }",This doesn't fit the abstraction level. Should we have a property bag for extra stuff?,Why do we need this
+1900,"@@ -616,11 +616,12 @@ def build_sdist(sdist_directory, config_settings=None):
+     files += glob.glob(""src/core/**/*.cc"", recursive=True)
+     files += glob.glob(""src/core/**/*.h"", recursive=True)
+     files += glob.glob(""ci/xbuild/*.py"")
++    files += glob.glob(""docs/**/*.rst"", recursive=True)
+     files += [f for f in glob.glob(""tests/**/*.py"", recursive=True)]
+     files += [f for f in glob.glob(""tests_random/*.py"")]
+     files += [""src/datatable/include/datatable.h""]
+     files.sort()
+-    files += [""ci/ext.py"", ""ci/__init__.py""]
++    files += [""ci/ext.py"", ""ci/__init__.py"", ""ci/gendoc.py""]
+     files += [""pyproject.toml""]
+     files += [""LICENSE""]
+     # See `is_source_distribution()`","Looks like it is pretty easy to miss it when adding new files under `ci`. Hopefully, this doesn't happen too often.",Why do we need this?
+1901,"@@ -244,6 +244,7 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey,
+ 		return nil, fmt.Errorf(""p2p service: %w"", err)
+ 	}
+ 	b.p2pService = p2ps
++	defer p2ps.Ready()
+ 
+ 	if !o.Standalone {
+ 		if natManager := p2ps.NATManager(); natManager != nil {",do we really need the `Ready` call if startup fails midway?,Why do we need this?
+1902,"@@ -17,7 +17,9 @@ namespace storage {
+ 
+ TEST(AddVerticesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddVerticesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddVerticesProcessor::instance(kv.get(),",You can avoid changing the code if there are parameter defaults. right ?,Why do we need this 
+1903,"@@ -214,7 +214,7 @@ describe('Components', () => {
+ 
+ 		let good, bad;
+ 		let root = render(<GoodContainer ref={c=>good=c} />, scratch);
+-		expect(scratch.innerText, 'new component with key present').to.equal('A\nB');
++		expect(scratch.textContent, 'new component with key present').to.equal('AB');
+ 		expect(Comp.prototype.componentWillMount).to.have.been.calledTwice;
+ 		expect(sideEffect).to.have.been.calledTwice;
+ ",I wonder why the newline disappeared here? I guess we'll merge and see how SauceLabs fares across the supported browsers.,Why did this change?
+1904,"@@ -4252,10 +4252,15 @@ void command_corpsefix(Client *c, const Seperator *sep)
+ 
+ void command_reloadworld(Client *c, const Seperator *sep)
+ {
+-	c->Message(Chat::White, ""Reloading quest cache and repopping zones worldwide."");
++	int world_repop = atoi(sep->arg[1]);
++	if (world_repop == 0)
++		c->Message(Chat::White, ""Reloading quest cache worldwide."");
++	else
++		c->Message(Chat::White, ""Reloading quest cache and repopping zones worldwide."");
++	
+ 	auto pack = new ServerPacket(ServerOP_ReloadWorld, sizeof(ReloadWorld_Struct));
+ 	ReloadWorld_Struct* RW = (ReloadWorld_Struct*) pack->pBuffer;
+-	RW->Option = ((atoi(sep->arg[1]) == 1) ? 1 : 0);
++	RW->Option = world_repop;
+ 	worldserver.SendPacket(pack);
+ 	safe_delete(pack);
+ }","I know this is legal, but I prefer we put brackets on our calls",This should be `if (world_repop != 0)`
+1905,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteServerCertificate.java demonstrates how to delete an AWS Identity and Access Management (IAM) server certificate.]
++//snippet-sourcedescription:[DeleteServerCertificate.java demonstrates how to delete an AWS Identity and Access Management (AWS IAM) server certificate.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),Why did you change this?
+1906,"@@ -0,0 +1,18 @@
++package org.openqa.selenium;
++
++/**
++ * Created by James Reed on 11/04/2016.
++ * Thrown to indicate that a click was attempted on an element but was intercepted by another
++ * element on top of it
++ */
++public class InterceptingElementException extends InvalidElementStateException {
++
++  public InterceptingElementException(String message) {
++    super(message);
++  }
++
++  public InterceptingElementException(String message, Throwable cause) {
++    super(message, cause);
++  }
++
++}",We keep who wrote the code anonymous.,Why do we need this?
+1907,"@@ -135,10 +135,14 @@ export const readableLargeNumber = ( number, currencyCode = false ) =>  {
+ 	if ( false !== currencyCode && '' !== readableNumber ) {
+ 		const formatedParts = new Intl.NumberFormat( navigator.language, { style: 'currency', currency: currencyCode } ).formatToParts( number );
+ 
+-		const decimal = formatedParts.find( part => 'decimal' === part.type ).value;
++		let decimal = formatedParts.find( part => 'decimal' === part.type );
++		if ( ! isUndefined( decimal ) ) {
++			decimal = decimal.value;
++		}
++
+ 		const currency = formatedParts.find( part => 'currency' === part.type ).value;
+ 
+-		if ( 1000 > number ) {
++		if ( 1000 > number && ! isUndefined( decimal ) ) {
+ 			readableNumber = Number.isInteger( number ) ? number : number.replace( '.', decimal );
+ 		}
+ ","Two things to make the code more error-proof and simplify it: 1. To be safe, this should be: `! isUndefined( decimal ) && ! isUndefined( decimal.value )` 2. The other clause that you changed below can be combined with that since `decimal` isn't used anywhere else, and so there's no point to re-check whether it's not undefined. In other words, this should become: `! isUndefined( decimal ) && ! isUndefined( decimal.value ) && 1000 > number`, and then you can remove the `decimal = decimal.value` assignment and replace it with line 146 (assignment of `readableNumber`).",Why do we need to check `isUndefined`?
+1908,"@@ -26,6 +26,15 @@ import ""context""
+ 
+ // Outbound is the common interface for all outbounds
+ type Outbound interface {
++	// Transports returns the transports that used by this outbound, so they
++	// can be collected for lifecycle management, typically by a Dispatcher.
++	//
++	// Though most outbounds only use a single transport, composite outbounds
++	// may use multiple transport protocols, particularly for shadowing traffic
++	// across multiple transport protocols during a transport protocol
++	// migration.
++	Transports() []Transport
++
+ 	// Sets up the outbound to start making calls.
+ 	//
+ 	// This MUST block until the outbound is ready to start sending requests.","Wouldn't composite outbounds compose the transport, such that it would still be represented as a single transport?",I don't think this is the right way to do this. The only way to do this is to add a new method to the `Outbound` interface. I think the right way to do this would be to add a new method to the `Outbound` interface.
+1909,"@@ -28,6 +28,7 @@ import (
+ 
+ func testAlertmanagerInstanceNamespacesAllNs(t *testing.T) {
+ 	ctx := framework.NewTestCtx(t)
++
+ 	defer ctx.Cleanup(t)
+ 
+ 	// create 3 namespaces:","nit: there is no need for a new line here, usually we tend to put an object creation and its deferred deletion next to each other. It helps not forgetting about the cleanup.",Why is this needed?
+1910,"@@ -7,6 +7,12 @@ use JavierEguiluz\Bundle\EasyAdminBundle\Exception\EntityNotFoundException;
+ use Symfony\Component\EventDispatcher\GenericEvent;
+ use Symfony\Component\HttpFoundation\Request;
+ 
++/**
++ * Adds some custom attributes to the request object to store information
++ * related to EasyAdmin.
++ *
++ * @author Maxime Steinhausser
++ */
+ class RequestPostInitializeListener
+ {
+     /** @var Request|null */",Feel free to use the full notation with my email address: `Maxime Steinhausser <maxime.steinhausser@gmail.com>` :smile:,Why do we need this?
+1911,"@@ -44,7 +44,6 @@ const FCGINullRequestID uint8 = 0
+ 
+ // FCGIKeepConn describes keep connection mode.
+ const FCGIKeepConn uint8 = 1
+-const doubleCRLF = ""\r\n\r\n""
+ 
+ const (
+ 	// BeginRequest is the begin request flag.",This was unused across the codebase,// FCGIKeepConn is the keep connection mode.
+1912,"@@ -2278,7 +2278,8 @@ func (js *jetStream) processConsumerAssignment(ca *consumerAssignment) {
+ 
+ 	acc, err := s.LookupAccount(ca.Client.serviceAccount())
+ 	if err != nil {
+-		// TODO(dlc) - log error
++		js.mu.Unlock()
++		s.Warnf(""Account lookup for consumer create failed: %v"", err)
+ 		return
+ 	}
+ ",Should we put in which account we were trying to look up?,I think we should log the error here.
+1913,"@@ -55,6 +55,7 @@ class InventoryTypeClass(object):
+     RESOURCE = 'resource'
+     IAM_POLICY = 'iam_policy'
+     GCS_POLICY = 'gcs_policy'
++    Supported_TypeClass = [RESOURCE, IAM_POLICY, GCS_POLICY]
+ 
+ 
+ class InventoryIndex(BASE):",either SUPPORTED_TYPECLASS or supported_typeclass. Camelcase only for class names.,Why is this needed?
+1914,"@@ -31,6 +31,7 @@ CREATE TABLE notes (
+ 	is_todo INT NOT NULL DEFAULT 0,
+ 	todo_due INT NOT NULL DEFAULT 0,
+ 	todo_completed INT NOT NULL DEFAULT 0,
++	pinned INT NOT NULL DEFAULT 0,
+ 	source TEXT NOT NULL DEFAULT """",
+ 	source_application TEXT NOT NULL DEFAULT """",
+ 	application_data TEXT NOT NULL DEFAULT """",",This is not going to work. You need to add a migration to the database.,Why do we need this?
+1915,"@@ -308,6 +308,7 @@ class Manager {
+      * @param {Object} apiClient The ApiClient.
+      */
+     resumeGroupPlayback(apiClient) {
++        // TODO: rename this method, it's not clear what it does.
+         this.followGroupPlayback(apiClient).then(() => {
+             this.queueCore.startPlayback(apiClient);
+         });",Should these methods be renamed in this PR?,Why do we need to rename this?
+1916,"@@ -154,6 +154,18 @@ namespace OpenTelemetry.Metrics
+                         {
+                             var metricStreamConfig = metricStreamConfigs[i];
+                             var metricStreamName = metricStreamConfig?.Name ?? instrument.Name;
++
++                            if (!MeterProviderBuilderSdk.IsValidInstrumentName(metricStreamName))
++                            {
++                                OpenTelemetrySdkEventSource.Log.MetricInstrumentIgnored(
++                                    instrument.Name,
++                                    instrument.Meter.Name,
++                                    ""Metric name is invalid."",
++                                    ""The name must comply with the OpenTelemetry specification."");
++
++                                continue;
++                            }
++
+                             if (this.metricStreamNames.ContainsKey(metricStreamName))
+                             {
+                                 // TODO: Log that instrument is ignored","we need to include the `metricStreamName` which is invalid, so users know whats causing the issue.",nit: `The name must comply with the OpenTelemetry specification.`
+1917,"@@ -93,8 +93,10 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+                 var pdbFilePath = Path.ChangeExtension(binaryPath, "".pdb"");
+                 using (var pdbReader = new PortablePdbReader(new FileHelper().GetStream(pdbFilePath, FileMode.Open, FileAccess.Read)))
+                 {
+-                    // Load assembly
+-                    var asm = AssemblyLoadContext.Default.LoadFromAssemblyPath(binaryPath);
++                    // At this point, the assembly should be already loaded into the load context. We query for a reference to
++                    // find the types and cache the symbol information. Let the loader follow default lookup order instead of
++                    // forcing load from a specific path.
++                    var asm = Assembly.Load(AssemblyLoadContext.GetAssemblyName(binaryPath));
+ 
+                     foreach (var type in asm.GetTypes())
+                     {",Please run Platform tests `DiaSessionTests`.,I'm not sure if this is the right way to do this. I think it woul
+1918,"@@ -741,6 +741,7 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte,
+             return pc;
+         }
+         *is_evex = true;
++        SYSLOG_INTERNAL_WARNING_ONCE(MSG_AVX_512_SUPPORT_INCOMPLETE_STRING "" @"" PFX, pc);
+         info = &evex_prefix_extensions[0][1];
+     } else {
+         /* not evex */",This is debug-build-only: we want a release-build notice. SYSLOG takes the name w/o the MSG and no _STRING. Args are via events.mc specifiers.,"SYSLOG_WARNING_ONCE(MSG_AVX_512_SUPPORT_INCOMPLETE_STRING "" @"" PF"
+1919,"@@ -37,6 +37,10 @@ function matchesParentDomain(srvAddress, parentDomain) {
+ function parseSrvConnectionString(uri, options, callback) {
+   const result = URL.parse(uri, true);
+ 
++  if (options.directConnection || options.directconnection) {
++    return callback(new MongoParseError('directConnection not supported with SRV URI'));
++  }
++
+   if (result.hostname.split('.').length < 3) {
+     return callback(new MongoParseError('URI does not have hostname, domain name and tld'));
+   }",is it possible to have both forms here? I was hoping we wouldn't be introducing more cases where we had to check the upper and lowercase version of URI options.,I think this should be `if (options.directConnection || options.d
+1920,"@@ -230,11 +230,11 @@ func BenchmarkFloat64LastValueAdd(b *testing.B) {
+ 
+ // Histograms
+ 
+-func benchmarkInt64HistogramAdd(b *testing.B, name string) {
++func BenchmarkInt64HistogramAdd(b *testing.B) {
+ 	ctx := context.Background()
+ 	fix := newFixture(b)
+ 	labs := makeLabels(1)
+-	mea := fix.meterMust().NewInt64Histogram(name)
++	mea := fix.meterMust().NewInt64Histogram(""int64.histogram"")
+ 
+ 	b.ResetTimer()
+ ",Does the name suffix hardcode something? Not clear how changing the name fixes this.,Why did you change the name here?
+1921,"@@ -39,4 +39,14 @@ public interface JmxExecutorManagerMBean {
+ 
+   @DisplayName(""OPERATION: getPrimaryExecutorHostPorts"")
+   public List<String> getPrimaryExecutorHostPorts();
++
++  @DisplayName(""OPERATION: isQueueProcessorActive"")
++  public boolean isQueueProcessorActive();
++
++  @DisplayName(""OPERATION: getUndispatchedFlows"")
++  public String getUndispatchedFlows();
++
++  @DisplayName(""OPERATION: getQueueProcessorThreadState"")
++  public String getQueueProcessorThreadState();
++
+ }",Is undispatched same as queued? getQueuedFlows?,I don't think we need to add thes
+1922,"@@ -1,5 +1,5 @@
+ /**
+- * core/site data store: connection info tests.
++ * Core site data store: connection info tests.
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for all similar cases below.",Why is this change needed?
+1923,"@@ -80,13 +80,14 @@ func TestSingleImageImportLoggableBuilder(t *testing.T) {
+ 						uefiBootable:          isUEFIDetectedValue,
+ 						biosBootable:          biosBootableValue,
+ 					},
+-					traceLogs: traceLogs,
++					traceLogs: append(traceLogs, traceLogs...),
+ 				}
+ 				assert.Equal(t, expected, NewSingleImageImportLoggableBuilder().
+ 					SetDiskAttributes(format, sourceGb, targetGb).
+ 					SetUEFIMetrics(isUEFICompatibleImageValue, isUEFIDetectedValue, biosBootableValue, bootFSValue).
+ 					SetInflationAttributes(matchResultValue, inflationTypeValue, inflationTimeValue, shadowInflationTimeValue).
+-					SetTraceLogs(traceLogs).
++					AppendTraceLogs(traceLogs).
++					AppendTraceLogs(traceLogs).
+ 					Build())
+ 			}
+ 		}",Why is this done twice?,Why is this change necessary?
+1924,"@@ -55,6 +55,11 @@ func (it *DeadlineReconciler) Reconcile(request reconcile.Request) (reconcile.Re
+ 		return reconcile.Result{}, client.IgnoreNotFound(err)
+ 	}
+ 
++	if ConditionEqualsTo(node.Status, v1alpha1.ConditionDeadlineExceed, corev1.ConditionTrue) {
++		// if this node deadline is exceed, try propagating to children node
++		return reconcile.Result{}, it.propagateDeadlineToChildren(ctx, &node)
++	}
++
+ 	if node.Spec.Deadline == nil {
+ 		return reconcile.Result{}, nil
+ 	}","This sync can ensure that the condition of the child node is consistent with the parent node, but I still don't understand when the child will be overwritten, and this behavior is not what we expected?",Why do we need this check?
+1925,"@@ -175,8 +175,8 @@ func TestEnvironment(state *BuildState, target *BuildTarget, testDir string) Bui
+ 	if target.HasLabel(""cc"") {
+ 		env = append(env, ""GCNO_DIR=""+path.Join(RepoRoot, GenDir, target.Label.PackageName))
+ 	}
+-	if state.DebugTests {
+-		env = append(env, ""DEBUG=true"")
++	if state.DebugFailingTests {
++		env = append(env, ""DEBUG_TEST_FAILURE=true"")
+ 	}
+ 	if target.Test.Sandbox && len(state.Config.Sandbox.Dir) > 0 {
+ 		env = append(env, ""SANDBOX_DIRS=""+strings.Join(state.Config.Sandbox.Dir, "",""))",This was renamed to avoid any confusion with the more general case of debugging via `plz debug`,I think this should be `DE
+1926,"@@ -88,9 +88,11 @@ public class Converter {
+   static byte[] convertUtf8ToBytes(Object val, int prefixLength) {
+     requireNonNull(val, ""val is null"");
+     if (val instanceof byte[]) {
+-      return new String((byte[]) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);
++      return new String((byte[]) val).substring(0, Math.min(((byte[]) val).length, prefixLength))
++          .getBytes(StandardCharsets.UTF_8);
+     } else if (val instanceof String) {
+-      return ((String) val).substring(0, prefixLength).getBytes(StandardCharsets.UTF_8);
++      return ((String) val).substring(0, Math.min(((String) val).length(), prefixLength))
++          .getBytes(StandardCharsets.UTF_8);
+     }
+     throw new TypeException(
+         String.format(""Cannot cast %s to bytes"", val.getClass().getSimpleName()));","String valStr = (String)val; valStr.substring(0, Math.min(valStr.length(), prefixLength)) Make it clean.",Why is this needed?
+1927,"@@ -2067,9 +2067,13 @@ CheckedError Parser::ParseEnum(const bool is_union, EnumDef **dest) {
+   const auto strict_ascending = (false == opts.proto_mode);
+   EnumValBuilder evb(*this, *enum_def, strict_ascending);
+   EXPECT('{');
+-  // A lot of code generatos expect that an enum is not-empty.
+-  if ((is_union || Is('}')) && !opts.proto_mode) {
+-    evb.CreateEnumerator(""NONE"");
++  if(is_union && !opts.proto_mode) {
++    // Every union has the NONE field, mapped to a special `void` type.
++    evb.CreateEnumerator(""NONE"", BASE_TYPE_NONE);
++    ECHECK(evb.AcceptEnumerator());
++  } else if (Is('}') && !opts.proto_mode) {
++    // Most code generators expect that an enum is not-empty.
++    evb.CreateEnumerator(""NONE"", 0);
+     ECHECK(evb.AcceptEnumerator());
+   }
+   std::set<std::pair<BaseType, StructDef *>> union_types;","Sorry, this still makes no sense.. the value of any union or enum is simply a name integer constant, it has nothing to do with the `BASE_TYPE_` enum. This value should be `0`. In particular: `Every union has the NONE field, which always has value 0`.",nit: space after `if`
+1928,"@@ -38,4 +38,6 @@ public interface Alerter {
+   void alertOnFailedExecutorHealthCheck(Executor executor,
+       List<ExecutableFlow> executions,
+       ExecutorManagerException e, List<String> alertEmails);
++
++  String getAzkabanURL();
+ }","Looks like getAzkabanURL() is added after concrete Alerter (Emailer)::getAzkabanURL(), so that Override annotation is needed.",Why do we need this method?
+1929,"@@ -316,6 +316,8 @@ class BaseDetector(nn.Module, metaclass=ABCMeta):
+                 i = int(i)
+                 color_mask = color_masks[labels[i]]
+                 mask = segms[i]
++                if mask.dtype != np.bool:
++                    mask = np.array(mask, dtype=bool)
+                 img[mask] = img[mask] * 0.5 + color_mask * 0.5
+         # if out_file specified, do not show image in window
+         if out_file is not None:",The above 3 lines can be written as: `mask = segms[i].astype(bool)`,I think this should be `if 
+1930,"@@ -27,6 +27,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ 	""github.com/iotexproject/iotex-core/protogen/iotexapi""
++	""github.com/iotexproject/iotex-address/address""
+ )
+ 
+ // Flags",File is not `gofmt`-ed with `-s` (from `gofmt`),"""github.com/golang/protobuf"
+1931,"@@ -631,7 +631,10 @@ void nano::node::start ()
+ 		{
+ 			network.port = bootstrap.port;
+ 		}
++
++		logger.always_log (boost::str (boost::format (""Node started with peering port `%1%`."") % network.port));
+ 	}
++
+ 	if (!flags.disable_backup)
+ 	{
+ 		backup_wallet ();",Thought it's good to have this logged down so that we can check the used value in the logs.,Shouldn't this be `logger.d
+1932,"@@ -83,7 +83,8 @@ type AWSMachineSpec struct {
+ // AWSMachineStatus defines the observed state of AWSMachine
+ type AWSMachineStatus struct {
+ 	// Ready is true when the provider resource is ready.
+-	Ready *bool `json:""ready,omitempty""`
++	// +optional
++	Ready bool `json:""ready""`
+ 
+ 	// Addresses contains the AWS instance associated addresses.
+ 	Addresses []v1.NodeAddress `json:""addresses,omitempty""`",I don't think you can call this optional unless it's a pointer - remove this?,Why is this optional?
+1933,"@@ -116,6 +116,11 @@ public class OfflineEditFragment extends BaseFragment {
+ 
+     @OnClick(R.id.buttonSendAll)
+     protected void onSendAllProducts() {
++        List<SendProduct> listSaveProduct = SendProduct.listAll(SendProduct.class);
++        if (listSaveProduct.size() == 0) {
++            Toast.makeText(getActivity(), R.string.txtNoData, Toast.LENGTH_LONG).show();
++            return;
++        }
+         new MaterialDialog.Builder(getActivity())
+                 .title(R.string.txtDialogsTitle)
+                 .content(R.string.txtDialogsContentSend)",@naofum please use `isEmpty`method instead,You can use `ListUtil
+1934,"@@ -280,12 +280,12 @@ bool gen_jit_and_run(compile_t* c, int* exit_code, jit_symbol_t* symbols,
+ 
+   auto resolver = orc::createLambdaResolver(local_lookup, external_lookup);
+ #if PONY_LLVM >= 500
+-  auto maybe_handle = compile_layer.addModule(module, resolver);
++  auto nullable_handle = compile_layer.addModule(module, resolver);
+ 
+-  if(!maybe_handle)
++  if(!nullable_handle)
+     return false;
+ 
+-  auto handle = maybe_handle.get();
++  auto handle = nullable_handle.get();
+ #else
+   std::vector<decltype(module)> module_set{module};
+   auto handle = compile_layer.addModuleSet(std::move(module_set), mem_mgr,",i think this is unrelated and needs to be reverted. need to discuss at sync.,Why did you change th
+1935,"@@ -19,8 +19,10 @@ import org.hyperledger.besu.datatypes.Hash;
+ 
+ import java.util.Optional;
+ 
++import org.apache.tuweni.bytes.Bytes;
++
+ /** A block header capable of being processed. */
+-public class ProcessableBlockHeader {
++public class ProcessableBlockHeader implements org.hyperledger.besu.plugin.data.BlockHeader {
+ 
+   protected final Hash parentHash;
+ ","Are we eventually moving those type interfaces from plugin project to datatype project? If not, then we'd have a dependency from core onto plugins, which seems a little counter-intuitive to me.",Why is this needed?
+1936,"@@ -1372,6 +1372,14 @@ Connection.prototype.setClient = function setClient(client) {
+   return this;
+ };
+ 
++Connection.prototype.syncIndexes = async function syncIndexes() {
++  const result = [];
++  for (const model in this.models) {
++    result.push(await this.model(model).syncIndexes());
++  }
++  return result;
++};
++
+ /**
+  * Switches to a different database using the same connection pool.
+  *",Love how we can finally use async/await in the codebase.,Why not just `return this.models.map(model => ...)`?
+1937,"@@ -3531,6 +3531,7 @@ void nano::rpc_handler::wallet_representative_set ()
+ {
+ 	rpc_control_impl ();
+ 	auto wallet (wallet_impl ());
++	bool update_existing_accounts (request.get<bool> (""update_existing_accounts"", false));
+ 	if (!ec)
+ 	{
+ 		std::string representative_text (request.get<std::string> (""representative""));","Very minor: this line could be moved to a more narrow scope, inside `if (!representative.decode_account (representative_text))` Other than that, LGTM",Why is this needed?
+1938,"@@ -40,10 +40,8 @@ type Connection struct {
+ 	// For invalid and closed connections: StopTime is the time when connection was updated last.
+ 	// For established connections: StopTime is latest time when it was polled.
+ 	StopTime time.Time
+-	// IsActive flag helps in cleaning up connections when they are not in conntrack any module more.
+-	IsActive bool
+-	// DoExport flag helps in tagging connections that can be exported by Flow Exporter
+-	DoExport           bool
++	// IsPresent flag helps in cleaning up connections when they are not in conntrack table anymore.
++	IsPresent          bool
+ 	Zone               uint16
+ 	Mark               uint32
+ 	StatusFlag         uint32",when is this consumed? I'm probably missing it but I can't find it right now,Why is this removed?
+1939,"@@ -418,6 +418,10 @@ void GroupByAgg::generateCacheKey(CacheWA &cwa) const
+     groupExpr_.rebuildExprTree(ITM_ITEM_LIST);
+   if (grpExpr) { 
+     cwa += "" gBy:""; 
++
++    if (isRollup())
++      cwa += "" roll:"";
++
+     grpExpr->generateCacheKey(cwa); 
+   }
+ }","I think we also need to add the rollupGroupExprList() to the cache key. If we rebuild the list above from a ValueIdSet on line 418 above, it is probably going to be in the same order, regardless whether it was ROLLUP(a,b) or ROLLUP(b,a).",Why is this needed?
+1940,"@@ -14,10 +14,15 @@
+  */
+ package com.google.api.codegen.transformer.nodejs;
+ 
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
++import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",can use `getParamTypeName` instead,I think this import is unused.
+1941,"@@ -184,14 +184,14 @@ class AdminController extends Controller
+     {
+         $this->dispatch(EasyAdminEvents::PRE_EDIT);
+ 
+-        if ($this->request->isXmlHttpRequest()) {
+-            return $this->ajaxEdit();
+-        }
+-
+         $id = $this->request->query->get('id');
+         $easyadmin = $this->request->attributes->get('easyadmin');
+         $entity = $easyadmin['item'];
+ 
++        if ($this->request->isXmlHttpRequest() && $this->request->query->has('property')) {
++            return $this->toggleBooleanProperty($entity, $this->request->query->get('property'), $this->request->query->get('newValue'));
++        }
++
+         $fields = $this->entity['edit']['fields'];
+ 
+         $editForm = $this->executeDynamicMethod('create<EntityName>EditForm', array($entity, $fields));",Why send the parameters? They're accessible directly from `$this->request` so there's no need to inject them in the method,Why did you remove this?
+1942,"@@ -186,6 +186,18 @@ class BrowserPage(QWebPage):
+             errpage.encoding = 'utf-8'
+             return True
+ 
++    def chooseFile(self, parent_frame: QWebFrame, suggested_file: str):
++        """"""Override chooseFiles to (optionally) invoke custom file uploader.""""""
++        handler = config.val.fileselect.handler
++        if handler == ""default"":
++            return super().chooseFile(parent_frame, suggested_file)
++
++        selected_file = shared.choose_file(multiple=False)
++        if selected_file == []:
++            return ''
++        else:
++            return selected_file[0]
++
+     def _handle_multiple_files(self, info, files):
+         """"""Handle uploading of multiple files.
+ ","Tiny nit: I would prefer `not selected_file` or `len(selected_file) == 0`, as if choose_file starts returning, for example, tuples instead of lists, this won't break.",Please use `if selected_file i
+1943,"@@ -329,6 +329,15 @@ func (e *ETCD) join(ctx context.Context, clientAccessInfo *clientaccess.Info) er
+ 	}
+ 
+ 	for _, member := range members.Members {
++		memberNodeName := strings.Split(member.Name, ""-"")[0]
++		if memberNodeName == e.config.ServerNodeName {
++			// make sure to remove the name file if a duplicate node name is used
++			nameFile := nameFile(e.config)
++			if err := os.Remove(nameFile); err != nil {
++				return err
++			}
++			return errors.New(""Failed to join etcd cluster due to duplicate node names, please use unique node name for the server"")
++		}
+ 		for _, peer := range member.PeerURLs {
+ 			u, err := url.Parse(peer)
+ 			if err != nil {",How will this code behave with hostnames that contain hyphens?,why do we need this?
+1944,"@@ -735,6 +735,15 @@ namespace pwiz.Skyline.Model
+                 moleculeIdKeys.Add(MoleculeAccessionNumbers.TagSMILES, smiles);
+             }
+ 
++            var keggCol = ColumnIndex(SmallMoleculeTransitionListColumnHeaders.idKEGG);
++            var kegg = NullForEmpty(row.GetCell(keggCol));
++            if (kegg != null)
++            {
++                // Should have form like C07481 but we'll accept anything for now, having no proper parser
++                kegg = kegg.Trim();
++                moleculeIdKeys.Add(MoleculeAccessionNumbers.TagKEGG, kegg);
++            }
++
+             return !moleculeIdKeys.Any()
+                 ? MoleculeAccessionNumbers.EMPTY
+                 : new MoleculeAccessionNumbers(moleculeIdKeys);","I think this is redundant since ""NullForEmpty"" already calls ""Trim()"".",">kegg = NullForEmpty(row.GetCell(keggCol)); [](start = 12, length = 36) I think this should be `NullForEmpty(row.GetCell(keggCol))`"
+1945,"@@ -317,6 +317,8 @@ type CloudBackupRestoreRequest struct {
+ }
+ 
+ type CloudBackupGroupCreateResponse struct {
++	// ID for this group of backups
++	GroupCloudBackupID string
+ 	// Names of the tasks performing this group backup
+ 	Names []string
+ }",Change this to IDs too?,Why is this a string?
+1946,"@@ -221,6 +221,11 @@ public class RaidsPlugin extends Plugin
+ 	@Getter
+ 	private final List<String> layoutWhitelist = new ArrayList<>();
+ 
++	@Getter
++	private final ImmutableSet<String> list_of_DC_SCOUT_RAIDS = ImmutableSet.of(
++		""SCPFCCSPCF"", ""CSPFCCCSSF"", ""SCFPCSCPCF"", ""PCSFCPCSCF"", ""SCCFCPSCSF"", ""SCPFCCCSSF"",
++		""SCPFCPCSCF""
++	);
+ 	@Getter
+ 	private Raid raid;
+ ","private static final, and it should be located in raidsoverlay, as it's not needed in the plugin. also the name could be a bit better, DC_SCOUT_RAIDS or similiar.",I don't think we need this list anymore.
+1947,"@@ -173,7 +173,7 @@ STATIC fpga_result parse_perf_attributes(struct udev_device *dev,
+ 			globfree(&pglob);
+ 			return FPGA_EXCEPTION;
+ 		}
+-		if (fscanf(file, ""%s"", attr_value) != 1) {
++		if (fscanf(file, ""%127s"", attr_value) != 1) {
+ 			OPAE_ERR(""Failed to read %s"", pglob.gl_pathv[i]);
+ 			goto out;
+ 		}",attr_value is 128 bytes?,Why is this change needed?
+1948,"@@ -54,7 +54,9 @@ class HTTPRequest(Request):
+         msg = ""Option 'url' is mandatory for request but not found in %s"" % config
+         self.url = self.config.get(""url"", TaurusConfigError(msg))
+         self.label = self.config.get(""label"", self.url)
+-        self.method = self.config.get(""method"", ""GET"").upper()
++        self.method = self.config.get(""method"", ""GET"")
++        if not has_variable_pattern(self.method):
++            self.method = self.method.upper()
+ 
+         # TODO: add method to join dicts/lists from scenario/request level?
+         self.headers = self.config.get(""headers"", {})",if it's unpredictable - why uppercase it at all?,"I don't think this is the right place to do this check. If the method is not a variable pattern, we should raise an error."
+1949,"@@ -25,6 +25,7 @@ type KubeCloudInstTool struct {
+ func (cu *KubeCloudInstTool) InstallTools() error {
+ 	cu.SetOSInterface(GetOSInterface())
+ 	cu.SetKubeEdgeVersion(cu.ToolVersion)
++	fmt.Println(""beforeinstallkubeedge"")
+ 
+ 	err := cu.InstallKubeEdge()
+ 	if err != nil {",Please remove all these debug prints. It doesn't look good.,Please remove this.
+1950,"@@ -74,6 +74,7 @@ type VMContext interface {
+ 	BlockHeight() *types.BlockHeight
+ 	IsFromAccountActor() bool
+ 	Charge(cost types.GasUnits) error
++	SampleChainRandomness(sampleHeight *types.BlockHeight) ([]byte, error)
+ 
+ 	CreateNewActor(addr address.Address, code cid.Cid, initalizationParams interface{}) error
+ ",Consumers of this interface should not be required to provide `sampleHeight`. This should be an expected consensus parameter.,Why do we need this?
+1951,"@@ -58,8 +58,14 @@ func GetBackoffForNextSchedule(cronSchedule string, startTime time.Time, closeTi
+ 	if err != nil {
+ 		return NoBackoff
+ 	}
++
++	if closeTime.Before(startTime) {
++		closeTime = startTime
++	}
++
+ 	startUTCTime := startTime.In(time.UTC)
+ 	closeUTCTime := closeTime.In(time.UTC)
++
+ 	nextScheduleTime := schedule.Next(startUTCTime)
+ 	// Calculate the next schedule start time which is nearest to the close time
+ 	for nextScheduleTime.Before(closeUTCTime) {","I don't believe this is the right fix. If startTime comes after closeTime, then it means some other event triggered invocation of this code path like workflow timeout. In this case we should still try to fire the cron on previous value so we should just return start the delta between startTime and closeTime immediately.",Why do we need this?
+1952,"@@ -348,6 +348,10 @@ type CloudBackupGenericRequest struct {
+ 	CredentialUUID string
+ 	// All if set to true, backups for all clusters in the cloud are processed
+ 	All bool
++	// StatusFilter indicates backups based on status
++	StatusFilter CloudBackupStatusType
++	// TagFilter indicates backups based on tag
++	TagFilter string
+ }
+ 
+ type CloudBackupInfo struct {","Not sure if we need tag here, it is an implementation detail in portworx that isn't exposed in openstorage",Why is this a string and not a CloudBackupStatusType?
+1953,"@@ -50,9 +50,15 @@ class Summon extends SolrDefault
+      * returned as an array of chunks, increasing from least specific to most
+      * specific.
+      *
++     * @param bool $extended Whether to return a keyed array with the following
++     * keys:
++     * - heading: the actual subject heading chunks
++     * - type: heading type
++     * - source: source vocabulary
++     *
+      * @return array
+      */
+-    public function getAllSubjectHeadings()
++    public function getAllSubjectHeadings($extended = false)
+     {
+         $retval = [];
+         $topic = isset($this->fields['SubjectTerms']) ?","I wonder if it would be cleaner to refactor all of this similar to the SolrMarc driver, so we have a property with Summon field names associated with types, and we iterate through it in a loop... that way we don't have to repeat the loop code four times with different variable names.",`$extended` is not used in this method.
+1954,"@@ -261,7 +261,7 @@ public class XCJFQuery extends Query {
+     }
+ 
+     private DocSet getDocSet() throws IOException {
+-      SolrClientCache solrClientCache = new SolrClientCache();
++      SolrClientCache solrClientCache = searcher.getCore().getCoreContainer().getSolrClientCache();
+       TupleStream solrStream;
+       if (zkHost != null || solrUrl == null) {
+         solrStream = createCloudSolrStream(solrClientCache);",Need the `solrClientCache.close();` further down in the method be removed since a shared cache is now used?,Why is this change needed?
+1955,"@@ -38,6 +38,9 @@ type (
+ 	ClusterMetadataRow struct {
+ 		ImmutableData         []byte
+ 		ImmutableDataEncoding string
++		Data                  []byte
++		DataEncoding          string
++		Version               int64
+ 	}
+ 
+ 	// ClusterMembershipRow represents a row in the cluster_membership table",according to the PR (schema changes?) these 2 field should be removed?,Why do we need this?
+1956,"@@ -373,16 +373,13 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo, kubeCli client.Cli
+ 					Mode:     v1alpha1.PodMode(exp.Scope.Mode),
+ 					Value:    exp.Scope.Value,
+ 				},
++				ContainerNames: exp.Target.StressChaos.ContainerNames,
+ 			},
+ 			Stressors:         stressors,
+ 			StressngStressors: exp.Target.StressChaos.StressngStressors,
+ 		},
+ 	}
+ 
+-	if exp.Target.StressChaos.ContainerName != nil {
+-		chaos.Spec.ContainerNames = []string{*exp.Target.StressChaos.ContainerName}
+-	}
+-
+ 	if exp.Scheduler.Duration != """" {
+ 		chaos.Spec.Duration = &exp.Scheduler.Duration
+ 	}",Panic here if `exp.Target.StressChaos.CintainerName` is nil.,Why is this being removed?
+1957,"@@ -93,4 +93,16 @@ public interface LeafCollector {
+    */
+   void collect(int doc) throws IOException;
+ 
++  /**
++   * Optionally creates a view of the scorerIterator where only competitive documents
++   * in the scorerIterator are kept and non-competitive are skipped.
++   *
++   * Collectors should delegate this method to their comparators if
++   * their comparators provide the skipping functionality over non-competitive docs.
++   * The default is to return the same iterator which is interpreted as the collector doesn't filter any documents.
++   */
++  default DocIdSetIterator filterIterator(DocIdSetIterator scorerIterator) {
++    return scorerIterator;
++  }
++
+ }",This allows for some hacks like returning an iterator that matches more docs than the scorer. I liked the previous approach that returned an iterator better.,I'm not sure if this is th
+1958,"@@ -227,6 +227,7 @@ public class IcebergInputFormat<T> extends InputFormat<Void, T> {
+ 
+     private CloseableIterable<T> open(FileScanTask currentTask, Schema readSchema) {
+       DataFile file = currentTask.file();
++      LOG.debug(""Opening [{}] for read"", file);
+       // TODO we should make use of FileIO to create inputFile
+       InputFile inputFile = HadoopInputFile.fromLocation(file.path(), context.getConfiguration());
+       CloseableIterable<T> iterable;",Aren't there already logs for this from the underlying file system implementation?,"nit: `LOG.debug(""Opening {"
+1959,"@@ -75,7 +75,7 @@ class SearchHandlerTest extends TestCase
+     {
+         $spec = ['DismaxParams' => [['foo', 'bar'], ['mm', '100%']], 'DismaxFields' => ['field1', 'field2']];
+         $hndl = new SearchHandler($spec);
+-        $defaults = ['CustomMunge' => [], 'DismaxHandler' => 'dismax', 'QueryFields' => [], 'FilterQuery' => []];
++        $defaults = ['CustomMunge' => [], 'DismaxHandler' => 'dismax', 'QueryFields' => [], 'FilterQuery' => [], 'DismaxMunge' => []];
+         $this->assertEquals($spec + $defaults, $hndl->toArray());
+     }
+ ",It would be good to have a test in here that demonstrates the new munge functionality; I can help set that up if you're not sure how.,Why did you change this?
+1960,"@@ -62,6 +62,9 @@ class kubernetes(luigi.Config):
+     kubernetes_namespace = luigi.OptionalParameter(
+         default=None,
+         description=""K8s namespace in which the job will run"")
++    max_retrials_to_get_pods = luigi.IntParameter(
++        default=0,
++        description=""Max retrials to get pods' informations"")
+ 
+ 
+ class KubernetesJobTask(luigi.Task):","`retrials` isn't the word you intend. I think you mean `retries` and to that end, can the var name just be `max_retries`?",nit: `max_retrials_to_get_pods` -> `max_retrials`
+1961,"@@ -213,6 +213,7 @@ class Shopware6ChannelForm extends AbstractType
+                 AttributeIdType::class,
+                 [
+                     'label' => 'Attribute Product Meta Title',
++                    'help' => 'Value in product it should contain 255 characters or less.',
+                     'choices' => array_flip($textareaAttributeDictionary),
+                     'property_path' => 'attributeProductMetaTitle',
+                     'required' => false,",Value in product should contain 255 characters or less.,"Should be ""Value in product it should contain 255"
+1962,"@@ -169,12 +169,12 @@ func main() {
+ 				logger.Error().Msg(fmt.Sprintf(""Node %d: Can not get State height"", i))
+ 			}
+ 			bcHeights[i] = chains[i].TipHeight()
+-			minTimeout = int(configs[i].Consensus.RollDPoS.Delay/time.Second - configs[i].Consensus.RollDPoS.ProposerInterval/time.Second)
++			minTimeout = int(configs[i].Consensus.RollDPoS.Delay/time.Second - configs[i].Consensus.RollDPoS.FSM.ProposerInterval/time.Second)
+ 			netTimeout = 0
+ 			if timeout > minTimeout {
+ 				netTimeout = timeout - minTimeout
+ 			}
+-			idealHeight[i] = uint64((time.Duration(netTimeout) * time.Second) / configs[i].Consensus.RollDPoS.ProposerInterval)
++			idealHeight[i] = uint64((time.Duration(netTimeout) * time.Second) / configs[i].Consensus.RollDPoS.FSM.ProposerInterval)
+ 
+ 			logger.Info().Msg(fmt.Sprintf(""Node#%d blockchain height: %d"", i, bcHeights[i]))
+ 			logger.Info().Msg(fmt.Sprintf(""Node#%d state      height: %d"", i, stateHeights[i]))",line is 133 characters (from `lll`),line is 161 characters (from `lll`)
+1963,"@@ -78,7 +78,7 @@ module RSpec
+       end
+ 
+       def file_options
+-        custom_options_file ? [custom_options] : [global_options, local_options]
++        custom_options_file ? [custom_options] : [global_options, local_options, personal_options]
+       end
+ 
+       def env_options","since we're calling the file .rspec-local, I think we should rename local_options to project_options and use local_options for .rspec-local - WDYT?",I don't think we need personal_options here.
+1964,"@@ -52,7 +52,7 @@ module Blacklight::Solr
+     protected
+ 
+       def build_connection
+-        RSolr.connect(connection_config)
++        RSolr.connect(connection_config.merge(adapter: connection_config[:http_adapter]))
+       end
+   end
+ end",Will we want to refactor this when we drop rsolr 1.x support?,I think this should be `connection_config.merge!(adapter: connection_config[:http_adapter])`
+1965,"@@ -63,7 +63,7 @@ func Request(path string, info *clientaccess.Info, requester HTTPRequester) ([]b
+ 	return requester(u.String(), clientaccess.GetHTTPClient(info.CACerts), username, password)
+ }
+ 
+-func getNodeNamedCrt(nodeName, nodePasswordFile string) HTTPRequester {
++func getNodeNamedCrt(nodeName, nodeIP, nodePasswordFile string) HTTPRequester {
+ 	return func(u string, client *http.Client, username, password string) ([]byte, error) {
+ 		req, err := http.NewRequest(http.MethodGet, u, nil)
+ 		if err != nil {",should this really be multiple IPs?,`nodeIP` is unused (from `deadcode`)
+1966,"@@ -0,0 +1 @@
++<%= render partial: ""proposal"", locals: { proposal: @proposal}  %>","Hmm, is that partial used in multiple places? Maybe we can just move that file in here.",
+1967,"@@ -0,0 +1,16 @@
++// Copyright 2014-2015 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package async
++
++//go:generate mockgen.sh github.com/aws/amazon-ecs-agent/agent/async Cache mocks/async_mocks.go",Should be 2014-2016,This file should be removed.
+1968,"@@ -1976,6 +1976,11 @@ namespace pwiz.Skyline.Model
+         private static Type GetColumnType(string value, IFormatProvider provider)
+         {
+             double result;
++            var quote = @"""""""";
++            if (value.StartsWith(quote) && value.EndsWith(quote))
++            {
++                value = value.Substring(1, value.Length - 2);
++            }
+             if (double.TryParse(value, NumberStyles.Number, provider, out result))
+                 return typeof(double);
+             else if (FastaSequence.IsExSequence(value))","Looks like my fault for sure in trying to handle international inputs regardless of locale. I think the correct fix is actually to get rid of TrySplitColumns and use ParseDsvFields instead. It is what gets used in the end, and it already has logic for dealing with quoted fields.",">value.StartsWith(quote) && value.EndsWith(quote) [](start = 16, length = 44) why not just use string.Empty?"
+1969,"@@ -2733,6 +2733,7 @@ describe('Find', function() {
+               cursors[0].next(function(err) {
+                 test.equal(null, err);
+ 
++                cursors[0].close();
+                 client.close();
+                 done();
+               });","similarly here, are the these cursors not being closed when the client is closed?",Why is this needed?
+1970,"@@ -22,7 +22,7 @@ import (
+ )
+ 
+ var (
+-	supportedPolicies = make(map[string]func() Policy)
++	supportedPolicies = make(map[string]func(string) Policy)
+ )
+ 
+ type staticUpstream struct {",Or maybe `func(args ...string) Policy` to make it dynamic in case of any future policy that may require more than one args.,Why is this change needed?
+1971,"@@ -36,6 +36,7 @@ func serviceLoggedIn(ctx context.Context, config Config, session SessionInfo,
+ 			log.CWarningf(ctx,
+ 				""Failed to enable existing journals: %v"", err)
+ 		}
++		jServer.MakeFBOsForExistingJournals(ctx)
+ 	}
+ 	err := config.MakeDiskBlockCacheIfNotExists()
+ 	if err != nil {",Should this happen even if the above failed?,Why do we need this?
+1972,"@@ -1,5 +1,5 @@
+ /*
+-Copyright 2017 The OpenEBS Authors.
++Copyright 2018 The OpenEBS Authors.
+ 
+ Licensed under the Apache License, Version 2.0 (the ""License"");
+ you may not use this file except in compliance with the License.",Please dont change this .,Why did you change this?
+1973,"@@ -382,7 +382,7 @@ void nano::active_transactions::cleanup_election (nano::unique_lock<nano::mutex>
+ 			node.network.publish_filter.clear (block);
+ 		}
+ 	}
+-	node.logger.try_log (boost::str (boost::format (""Election erased for root %1%"") % election.qualified_root.to_string ()));
++	node.logger.try_log (boost::str (boost::format (""Election erased for root %1%, confirmed: %2$b"") % election.qualified_root.to_string () % election.confirmed ()));
+ }
+ 
+ std::vector<std::shared_ptr<nano::election>> nano::active_transactions::list_active (std::size_t max_a)",There is a strange $b that looks wrong.,I don't think you need t
+1974,"@@ -1166,12 +1166,16 @@ def getControlFieldSpeech(attrs,ancestorAttrs,fieldType,formatConfig=None,extraD
+ 	# speakStatesFirst: Speak the states before the role.
+ 	speakStatesFirst=role==controlTypes.ROLE_LINK
+ 
++	containerContainsText="""" #: used for item counts for lists
++
+ 	# Determine what text to speak.
+ 	# Special cases
+ 	if speakEntry and childControlCount and fieldType==""start_addedToControlFieldStack"" and role==controlTypes.ROLE_LIST and controlTypes.STATE_READONLY in states:
+ 		# List.
+-		# Translators: Speaks number of items in a list (example output: list with 5 items).
+-		return roleText+"" ""+_(""with %s items"")%childControlCount
++		# #7652: containerContainsText variable is set here, but the actual generation of all other output is handled further down in the general cases section.
++		# This ensures that properties such as name, states and level etc still get reported appropriately.
++		# Translators: Number of items in a list (example output: list with 5 items).
++		containerContainsText=_(""with %s items"")%childControlCount
+ 	elif fieldType==""start_addedToControlFieldStack"" and role==controlTypes.ROLE_TABLE and tableID:
+ 		# Table.
+ 		return "" "".join((nameText,roleText,stateText, getSpeechTextForProperties(_tableID=tableID, rowCount=attrs.get(""table-rowcount""), columnCount=attrs.get(""table-columncount"")),levelText))","Is it still important to have `speakEntry` here? It is checked before this value `containerContainsText` is used in the ""General"" section.",E231 missing whitespace 
+1975,"@@ -18,6 +18,7 @@ module Travis
+           CLEANUPS.each do |find_arg|
+             sh.raw ""find #{find_arg[:directory]} -name #{find_arg[:glob]} -delete 2>/dev/null""
+           end
++          sh.export 'PATH', '$JAVA_HOME:$PATH'
+         end
+ 
+         def install","It is `$JAVA_HOME/bin`, not `$JAVA_HOME`, which should be added.",Why do we need this?
+1976,"@@ -9,6 +9,7 @@ bool generate_uuid(char out[static 37]) {
+ 	return true;
+ }
+ #else
++#include <assert.h>
+ #include <string.h>
+ #include <stdlib.h>
+ ",Should move this to within the `#else` block as it's only used there.,Why is this needed?
+1977,"@@ -41,6 +41,9 @@ class ProductListPage extends AbstractPage
+         $context = $this->getProductListCompomentContext();
+ 
+         $this->productListComponent->addProductToCartByName($productName, $quantity, $context);
++
++        $this->tester->waitForAjax();
++        $this->tester->wait(1);
+     }
+ 
+     /**",is this a common rule to wait one extra second after ajax? I'm thinking about moving this extra wait into waitForAjax method.,Why do we need this
+1978,"@@ -94,8 +94,8 @@ abstract class AbstractSolrTask extends AbstractTask {
+     public function __sleep()
+     {
+         $properties = get_object_vars($this);
+-        // avoid serialization if the site object
+-        unset($properties['site']);
++        // avoid serialization if the site and logger object
++        unset($properties['site'], $properties['logger']);
+         return array_keys($properties);
+     }
+-}
++}","Maybe you can correct the typo ""if"" too :)",Shouldn't this be `
+1979,"@@ -298,6 +298,9 @@ type KeybaseService interface {
+ 	// popups spawned.
+ 	Identify(ctx context.Context, assertion, reason string) (UserInfo, error)
+ 
++	IdentifyForChat(ctx context.Context, assertion, reason string) (
++		UserInfo, *keybase1.IdentifyTrackBreaks, error)
++
+ 	// LoadUserPlusKeys returns a UserInfo struct for a
+ 	// user with the specified UID.
+ 	// If you have the UID for a user and don't require Identify to","I'd prefer a name less chat-specific, since later on we could have other app types that want the same behavior. Maybe `IdentifyAndAllowTrackBreaks`?",nit: `IdentifyForCh
+1980,"@@ -51,10 +51,18 @@ public:
+      */
+     bool load(handle src, bool)
+     {
++        // Import mpi4py if it does not exist.
++        if (!PyMPIComm_Get)
++        {
++            if (import_mpi4py() < 0)
++            {
++                throw std::runtime_error(
++                        ""ERROR: mpi4py not loaded correctly\n""); /* Python 2.X */
++            }
++        }
+         // If src is not actually a MPI4PY communicator, the next
+         // call returns nullptr, and we return false to indicate the conversion
+         // failed.
+-
+         MPI_Comm *mpiCommPtr = PyMPIComm_Get(src.ptr());
+         if (mpiCommPtr == nullptr)
+         {","I think I was involved in writing that caster, but I never fully understood the `import_mpi4py` thing. Why is importing mpi4py still necessary at that point? I would think if the user is passing a communicator from python code, they must already have imported mpi4py themselves, or does that not propagate through into the wrapping layer?","I don't think this is the right way to do this. If the MPI_Comm_Get call fails, it will return nullptr."
+1981,"@@ -142,13 +142,14 @@ func (cache *httpCache) retrieve(target *core.BuildTarget, key []byte) (bool, er
+ 	resp, err := cache.client.Do(req)
+ 	if err != nil {
+ 		return false, err
+-	} else if resp.StatusCode == http.StatusNotFound {
++	}
++	defer resp.Body.Close()
++	if resp.StatusCode == http.StatusNotFound {
+ 		return false, nil // doesn't exist - not an error
+ 	} else if resp.StatusCode != http.StatusOK {
+ 		b, _ := ioutil.ReadAll(resp.Body)
+ 		return false, fmt.Errorf(""%s"", string(b))
+ 	}
+-	defer resp.Body.Close()
+ 	gzr, err := gzip.NewReader(resp.Body)
+ 	if err != nil {
+ 		return false, err",This seems like a more interesting change. Maybe we should re-name the PR,I don't think this change is necessary.
+1982,"@@ -20,6 +20,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal
+                                                IApplicationTransportFeature,
+                                                ITransportSchedulerFeature,
+                                                IConnectionLifetimeFeature,
++                                               IConnectionHeartbeatFeature,
++                                               IConnectionLifetimeNotificationFeature,
+                                                IBytesWrittenFeature
+     {
+         // NOTE: When feature interfaces are added to or removed from this TransportConnection class implementation,",Nit: implement the methods for these interfaces explicitly in this file for consistency. It can be passthrough.,Why is this a<msg>Why is it a<msg>Why is it a<msg>Why is it a<msg><msg>Shouldn't it be an interface?
+1983,"@@ -102,6 +102,7 @@ public class CSharpCommonTransformer {
+         .typeName(typeName)
+         .setCallName("""")
+         .addCallName("""")
++        .getCallName("""")
+         .isMap(false)
+         .isArray(false)
+         .isPrimitive(false)","Not directly related to your PR, but I think here we should create a Type enum (MAP, ARRAY, PRIMITIVE) instead of having 3 flags.",Why is this needed?
+1984,"@@ -444,6 +444,7 @@ ExWorkProcRetcode ExHbaseScanSQTaskTcb::work(short &rc)
+   Lng32 retcode = 0;
+   rc = 0;
+   Lng32 remainingInBatch = batchSize_;
++  NABoolean isFirstBatch = false;
+ 
+   while (1)
+     {","Do you want this to be a stack variable? The work method might return at any time (example: when the parent queue fills up) and then get called again, which would cause this variable to become false again. I'm wondering if this variable should be a member instead?",`NABoolean isFirstBatch = false;`
+1985,"@@ -116,6 +116,14 @@ nebula::cpp2::HostAddr MetaServiceUtils::parseHostKey(folly::StringPiece key) {
+     return host;
+ }
+ 
++std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) {
++    std::string key;
++    key.reserve(kEdgesTable.size() + sizeof(GraphSpaceID));
++    key.append(kEdgesTable.data(), kEdgesTable.size());
++    key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
++    return key;
++}
++
+ std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId,
+                                             EdgeType edgeType,
+                                             int64_t version) {",You could reserve a const space to save the extra computation.,nit: you can use `sizeof(GraphSpa
+1986,"@@ -15,6 +15,8 @@ namespace System.IO.Tests
+         private readonly string _testPath200 = PerfUtils.CreateString(200);
+         private readonly string _testPath500 = PerfUtils.CreateString(500);
+         private readonly string _testPath1000 = PerfUtils.CreateString(1000);
++        private readonly string _testPathNoRedundantSegments = ""/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/Path.cs"";
++        private readonly string _testPathWithRedundantSegments = ""/home/user/runtime/src/coreclr/runtime/src/libraries/System.Private.CoreLib/src/System/IO/..//./Path.cs"";
+ 
+         [Benchmark]
+         public string Combine() => Path.Combine(_testPath, _testPath10);",Did you consider adding rooted paths like `C:\ProgramData` and paths with flipped separators?,Why do we need this?
+1987,"@@ -93,10 +93,11 @@ func startDnsServer() {
+ 		Port: 53,
+ 	}
+ 	udpConn, err := net.ListenUDP(""udp"", laddr)
+-	defer udpConn.Close()
+ 	if err != nil {
+ 		klog.Errorf(""Dns server Start error : %s"", err)
++		return
+ 	}
++	defer udpConn.Close()
+ 	dnsConn = udpConn
+ 	for {
+ 		req := make([]byte, bufSize)",does this line cause a panic if it is above the if condition ?,Why do we need this change?
+1988,"@@ -0,0 +1,5 @@
++package org.phoenicis.javafx.components.library.utils;
++
++public enum LibraryDetailsPanels {
++    ShortcutDetails, ShortcutCreation, ShortcutEditing, Closed;
++}",Maybe `LibraryDetailsPanelType` would be clearer.,Why do we need this?
+1989,"@@ -149,7 +149,6 @@ static void runlevel_cb (runlevel_t *r, int level, int rc, double elapsed,
+ static void runlevel_io_cb (runlevel_t *r, const char *name,
+                             const char *msg, void *arg);
+ 
+-static int create_persistdir (attr_t *attrs, uint32_t rank);
+ static int create_rundir (attr_t *attrs);
+ static int create_broker_rundir (overlay_t *ov, void *arg);
+ static int create_dummyattrs (flux_t *h, uint32_t rank, uint32_t size);","minor nit - add ""persist-filesystem"" and ""persist-directory"" into commit message, as its something people may search on (maybe applies to a few other commit messages)",Why did you remove t
+1990,"@@ -7662,8 +7662,6 @@ bool CoreChecks::ValidateEventStageMask(const ValidationStateTracker *state_data
+     return skip;
+ }
+ 
+-static const VkQueueFlagBits kQueueTypeArray[] = {VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT, VK_QUEUE_TRANSFER_BIT};
+-
+ bool CoreChecks::CheckStageMaskQueueCompatibility(VkCommandBuffer command_buffer, VkPipelineStageFlags stage_mask,
+                                                   VkQueueFlags queue_flags, const char *function, const char *src_or_dest,
+                                                   const char *error_code) const {",I verified offline with @jeremyg-lunarg this should be removed.,Why was this removed
+1991,"@@ -65,6 +65,7 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) DError {
+ 	i.Workflow.Logger = i.Workflow.parent.Logger
+ 	i.Workflow.Name = s.name
+ 	i.Workflow.DefaultTimeout = s.Timeout
++	fmt.Println(""incldued_wf name:"", i.Workflow.Name, "" timeout:"", i.Workflow.DefaultTimeout)
+ 
+ 	var errs DError
+ Loop:","This should be removed? If not, typo in incldued_wf","fmt.Println(""incldue"
+1992,"@@ -19,6 +19,7 @@ export const variant = ({
+ 
+ export default variant
+ 
+-export const buttonStyle = variant({ key: 'buttons' })
++export const buttonStyle =
++  variant({ key: 'buttons' }) || variant({ key: 'buttonStyles' })
+ export const textStyle = variant({ key: 'textStyles', prop: 'textStyle' })
+ export const colorStyle = variant({ key: 'colorStyles', prop: 'colors' })","Sorry for the delay on this! It looks like Circle CI isn't running tests on some of the PRs, but this doesn't look like it would work   I might be missing something, but are the tests all passing locally?",Why do we need this change?
+1993,"@@ -68,6 +68,15 @@ type MatchFile struct {
+ 	//
+ 	// Default is first_exist.
+ 	TryPolicy string `json:""try_policy,omitempty""`
++
++	// A list of delimiters to use to split the path in two
++	// when trying files. If empty, no splitting will
++	// occur, and the path will be tried as-is. For each
++	// split value, the left-hand side of the split,
++	// including the split value, will be the path tried.
++	// For example, the path `/remote.php/dav/` using the
++	// split value `.php` would try the file `/remote.php`.
++	SplitPath []string `json:""split_path,omitempty""`
+ }
+ 
+ // CaddyModule returns the Caddy module information.",Do you think the godoc should mention that all delimiters will be suffixed with `/`?,I'm not sure if this is the
+1994,"@@ -111,6 +111,8 @@ public class NavigationURLBar extends FrameLayout {
+                 return;
+             else if (aURL.startsWith(""resource:"") || SessionStore.get().isHomeUri(aURL))
+                 aURL = """";
++            else if (aURL.startsWith(""data:"") && SessionStore.get().isCurrentSessionPrivate())
++                aURL = SessionStore.PRIVATE_BROWSING_URI;
+             else
+                 index = aURL.indexOf(""://"");
+         }","what if I want to load my own, a different, data URI in Private Browsing mode? I do this often on desktop (e.g., `data:text/html,&times;`). admittedly, I wouldn't expect this to be done by a non-developer, but this will certainly cause a minor bug.",Shouldn't this be `aURL.sta
+1995,"@@ -312,6 +312,7 @@ class DeleteFileIndex {
+   static class Builder {
+     private final FileIO io;
+     private final Set<ManifestFile> deleteManifests;
++    private long minSequenceNumber = 0L;
+     private Map<Integer, PartitionSpec> specsById = null;
+     private Expression dataFilter = Expressions.alwaysTrue();
+     private Expression partitionFilter = Expressions.alwaysTrue();","I remember the sequence number 0 is kept for the data files for iceberg v1, so in theory the sequence number from delete files should start from 1. So setting it to 0 as the default value sounds correct.",nit: can be final
+1996,"@@ -68,7 +68,7 @@ public class ImageVersionDaoImpl implements ImageVersionDao {
+           + ""values (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)"";
+   private static final String SELECT_IMAGE_VERSION_BASE_QUERY =
+       ""select iv.id, iv.path, iv.description, ""
+-          + ""iv.version, cast(replace(iv.version, '.', '') as unsigned integer) as int_version, ""
++          + ""iv.version, cast(replace(iv.version, '.', '') as integer) as int_version, ""
+           + ""it.name, iv.state, iv.release_tag, iv.created_on, iv.created_by, iv.modified_on, ""
+           + ""iv.modified_by from image_versions iv, image_types it where it.id = iv.type_id"";
+   /**",For all these MYSQL queries unsigned is required. I have tested again and without unsigned these queries are failing.,Why do we need to change this?
+1997,"@@ -57,6 +57,8 @@ const defaultState = {
+ 	editorNoteStatuses: {},
+ };
+ 
++const MAX_HISTORY = 200;
++
+ const stateUtils = {};
+ 
+ const derivedStateCache_ = {};",Are there tests for this? What happens when you get to limit?,Why do we need this?
+1998,"@@ -174,7 +174,7 @@ module Bolt
+         data['config'] = {}
+       end
+ 
+-      unless Bolt::Util.windows? || data['config']['transport']
++      unless data['config']['transport']
+         data['config']['transport'] = 'local' if target.name == 'localhost'
+       end
+ ",Whole thing could be collapsed to `data['config']['transport'] ||= 'local' if target.name == 'localhost'`.,Why was this removed?
+1999,"@@ -73,6 +73,15 @@ public class OpenPgpKeyPreference extends Preference {
+ 
+     @Override
+     protected void onClick() {
++        bindServiceAndGetSignKeyId(new Intent());
++    }
++
++    private void bindServiceAndGetSignKeyId(final Intent data) {
++        if (mServiceConnection != null) {
++            getSignKeyId(data);
++            return;
++        }
++
+         // bind to service
+         mServiceConnection = new OpenPgpServiceConnection(
+                 getContext().getApplicationContext(),","maybe throw in `&& mServiceConnection.isBound()`, there are cases where the connection might die",I think you can remove this me
+2000,"@@ -61,5 +61,6 @@ namespace Nethermind.Core.Specs.Forks
+         public bool IsEip1052Enabled => true;
+         public bool IsEip1283Enabled => false;
+         public bool IsEip1234Enabled => true;
++        public bool IsEip1344Enabled => false;
+     }
+ }",Can we add Istanbul with this first EIP please? (or as a separate issue),public bool IsEip1344Enabled => true;
+2001,"@@ -71,10 +71,10 @@ func (sn Snapshot) ID() backend.ID {
+ func (sn *Snapshot) fillUserInfo() error {
+ 	usr, err := user.Current()
+ 	if err != nil {
+-		return err
++		return nil
+ 	}
+-
+ 	sn.Username = usr.Username
++
+ 	uid, err := strconv.ParseInt(usr.Uid, 10, 32)
+ 	if err != nil {
+ 		return err",I don't understand this change,Shouldn't this be `return err`?
+2002,"@@ -2248,7 +2248,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, PrintError):
+             encrypted_e.setText(encrypted.decode('ascii'))
+         except BaseException as e:
+             traceback.print_exc(file=sys.stdout)
+-            self.show_warning(str(e))
++            self.show_warning(""Invalid Public key"")
+ 
+     def encrypt_message(self, address=''):
+         d = WindowModalDialog(self, _('Encrypt/decrypt Message'))",Let's allow translators for this string to be translated: `self.show_warning(_('Invalid Public key'))`,"Shouldn't this be `_(""Invalid Public "
+2003,"@@ -0,0 +1,13 @@
++var landmarks = axe.commons.aria.getRolesByType('landmark');
++var parent = axe.commons.dom.getComposedParent(node);
++while (parent){
++	var role = parent.getAttribute('role');
++	if (!role && (parent.tagName.toLowerCase() !== 'form')){
++		role = axe.commons.aria.implicitRole(parent);
++	}
++	if (role && landmarks.includes(role)){
++		return false;
++	}
++	parent = axe.commons.dom.getComposedParent(parent);
++}
++return true;",This needs to work with `role=form` too.,I don't think you need the `toLowerCa
+2004,"@@ -1039,6 +1039,11 @@ Blockly.BlockSvg.prototype.handleDragFree_ = function(oldXY, newXY, e) {
+     }
+   }
+ 
++  // Always update previews for output connections.
++  if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {
++    updatePreviews = true;
++  }
++
+   if (updatePreviews) {
+     var candidateIsLast = (localConnection == lastOnStack);
+     this.updatePreviews(closestConnection, localConnection, radiusConnection,","This should be before the if on line 1028, which should turn into an else if",Why is this needed?
+2005,"@@ -27,6 +27,13 @@ type ClusterNetworkPolicySpecBuilder struct {
+ 	Name string
+ }
+ 
++type ACNPRuleAppliedToSpec struct {
++	PodSelector         map[string]string
++	NSSelector          map[string]string
++	PodSelectorMatchExp *[]metav1.LabelSelectorRequirement
++	NSSelectorMatchExp  *[]metav1.LabelSelectorRequirement
++}
++
+ func (b *ClusterNetworkPolicySpecBuilder) Get() *secv1alpha1.ClusterNetworkPolicy {
+ 	if b.Spec.Ingress == nil {
+ 		b.Spec.Ingress = []secv1alpha1.Rule{}","Not really introduced by this PR, but I don't recall why these have to be pointers, while `PodSelector` / `NSSelector` do not. Do you know the reason?",Why is this a point
+2006,"@@ -98,10 +98,10 @@ func (r *RTTStats) UpdateRTT(sendDelta, ackDelay time.Duration, now time.Time) {
+ 	r.updateRecentMinRTT(sendDelta, now)
+ 
+ 	// Correct for ackDelay if information received from the peer results in a
+-	// positive RTT sample. Otherwise, we use the sendDelta as a reasonable
+-	// measure for smoothedRTT.
++	// an RTT sample at least as large as minRTT. Otherwise, only use the
++	// sendDelta.
+ 	sample := sendDelta
+-	if sample > ackDelay {
++	if sample-r.minRTT >= ackDelay {
+ 		sample -= ackDelay
+ 	}
+ 	r.latestRTT = sample","Is there a reason why we are ignoring the ackDelay if it would result in a value smaller than the min? Why not `max(sample - ackDelay, minRTT)`?",I think this should
+2007,"@@ -10,8 +10,8 @@ namespace Microsoft.CodeAnalysis.Sarif
+     /// <summary>
+     /// Defines methods to support the comparison of objects of type SarifLog for equality.
+     /// </summary>
+-    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.31.0.0"")]
+-    public sealed class SarifLogEqualityComparer : IEqualityComparer<SarifLog>
++    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.32.0.0"")]
++    internal sealed class SarifLogEqualityComparer : IEqualityComparer<SarifLog>
+     {
+         internal static readonly SarifLogEqualityComparer Instance = new SarifLogEqualityComparer();
+ ","Here's an example of how the files in the `NotYetGenerated` directory drifted out of sync from the generated files. When we made the equality comparers internal, we neglected to fix this one.",Why is this public?
+2008,"@@ -19,6 +19,10 @@ class GuidancePolicy < ApplicationPolicy
+     user.can_modify_guidance? && guidance.in_group_belonging_to?(user.org_id)
+   end
+ 
++  def index?
++    admin_index?
++  end
++
+   def admin_index?
+     user.can_modify_guidance?
+   end",nice. we should do this elsewhere too. We have a lot of repeated stuff in the policies,Should this be `admin_group?`?
+2009,"@@ -612,3 +612,14 @@ TEST_F(BadPonyTest, FieldReferenceInDefaultArgument)
+ 
+   TEST_ERRORS_1(src, ""can't reference 'this' in a default argument"");
+ }
++
++
++TEST_F(BadPonyTest, DefaultArgScope)
++{
++  const char* src =
++    ""actor A\n""
++    ""  fun foo(x: None = (let y = None; y)) =>\n""
++    ""    y"";
++
++  TEST_ERRORS_1(src, ""can't find declaration of 'y'"");
++}","Small formatting thing, but can you remove the space before the semicolon?",Why is this a<msg>I don't thin
+2010,"@@ -38,7 +38,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+ 
+             var reading = Task.Run(async () =>
+             {
+-                int remaining = InnerLoopCount * _writeLenght;
++                long remaining = InnerLoopCount * _writeLenght;
+                 while (remaining != 0)
+                 {
+                     var result = await _pipe.Reader.ReadAsync();","Not new, but nit: _writeLeng*th*.",Why this change?
+2011,"@@ -133,6 +133,13 @@ func TestComposeCmd(t *testing.T) {
+ 	assert.Error(err)
+ }
+ 
++func TestCheckCompose(t *testing.T) {
++	assert := asrt.New(t)
++
++	err := CheckDockerCompose()
++	assert.NoError(err)
++}
++
+ func TestGetAppContainers(t *testing.T) {
+ 	assert := asrt.New(t)
+ 	sites, err := GetAppContainers(""dockertest"")","Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions.",nit: `assert.NoError(err)` is 
+2012,"@@ -3,11 +3,12 @@ package volume
+ import (
+ 	""crypto/tls""
+ 	""encoding/json""
+-	""github.com/libopenstorage/openstorage/api""
+-	""github.com/stretchr/testify/require""
+ 	""net/http""
+ 	""net/http/httptest""
+ 	""testing""
++
++	""github.com/libopenstorage/openstorage/api""
++	""github.com/stretchr/testify/require""
+ )
+ 
+ func TestClientTLS(t *testing.T) {",Remove this file from the PR,nit: remove empty line
+2013,"@@ -488,7 +488,7 @@ Blockly.Variables.renameVariable = function(workspace, variable,
+   var validate = Blockly.Variables.nameValidator_.bind(null, varType);
+ 
+   var promptText = promptMsg.replace('%1', variable.name);
+-  Blockly.prompt(promptText, '',
++  Blockly.prompt(promptText, variable.name,
+       function(newName, additionalVars) {
+         if (variable.isCloud &&
+             newName.length > 0 && newName.indexOf(Blockly.Variables.CLOUD_PREFIX) == 0 ) {","I think that for cloud variables, the default value in the prompt should be the variable name without the cloud prefix; this is slightly different from the scratch 2.0 behavior, but I think would ultimately lead to less confusion. Proposing code changes below:",Why did you change thi
+2014,"@@ -16,7 +16,8 @@ struct wlr_pointer *create_libinput_pointer(
+ 		wlr_log(WLR_ERROR, ""Unable to allocate wlr_pointer"");
+ 		return NULL;
+ 	}
+-	wlr_pointer_init(wlr_pointer, NULL);
++	wlr_pointer_init(wlr_pointer, NULL,
++		libinput_device_config_tap_get_finger_count(libinput_dev) > 0);
+ 	return wlr_pointer;
+ }
+ ",I think I would rather fish this interface through than use it as the basis for heuristics.,Shouldn't this be `lib
+2015,"@@ -153,7 +153,7 @@ namespace pwiz.Skyline.Controls.Graphs
+             public static float QValueCutoff
+             {
+                 get => Properties.Settings.Default.DetectionsQValueCutoff;
+-                set => Properties.Settings.Default.DetectionsQValueCutoff = value;
++                set => Properties.Settings.Default.DetectionsQValueCutoff = value; 
+             }
+ 
+             public static TargetType TargetType","Probably not worth making this line-ending change, since it is the only change to this file.",nit: unnecessary white
+2016,"@@ -1180,8 +1180,13 @@ encode_opnd_x0(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ static inline bool
+ decode_opnd_memx0(uint enc, int opcode, byte *pc, OUT opnd_t *opnd)
+ {
++#ifdef DR_HOST_NOT_TARGET
++    CLIENT_ASSERT(opnd_size_in_bytes(OPSZ_CACHE_LINE) == 64, ""OPSZ_CACHE_LINE != 64"");
++#endif
+     *opnd = opnd_create_base_disp(decode_reg(extract_uint(enc, 0, 5), true, false),
+-                                  DR_REG_NULL, 0, 0, OPSZ_sys);
++                                  DR_REG_NULL, 0, 0, OPSZ_CACHE_LINE);
++    if (!opnd_set_base_aligned(opnd, true))
++        return false;
+     return true;
+ }
+ ","Is this the correct place for this assert? Does this routine rely on it being 64, or was this only for testing?",This should be `OPSZ_CACHE_LINE != 64`.
+2017,"@@ -3,7 +3,7 @@ package hardware
+ import (
+ 	""github.com/shirou/gopsutil/mem""
+ 	""github.com/sonm-io/core/insonmnia/hardware/cpu""
+-	""github.com/sonm-io/core/insonmnia/hardware/gpu""
++	pb ""github.com/sonm-io/core/proto""
+ )
+ 
+ // Hardware accumulates the finest hardware information about system the miner",No pb please,Why do we need this change?
+2018,"@@ -0,0 +1,11 @@
++require 'migrate'
++class AddJoinTableBetweenUsersAndChangesets < ActiveRecord::Migration
++  def change
++    create_table :changesets_subscribers, id: false do |t|
++      t.column :subscriber_id, :bigint, null: false
++      t.column :changeset_id, :bigint, null: false
++    end
++    add_foreign_key :changesets_subscribers, [:subscriber_id], :users, [:id]
++    add_foreign_key :changesets_subscribers, [:changeset_id], :changesets, [:id]
++  end
++end","We need to add indexes here on both `subscriber_id` and `changeset_id` or things will quickly collapse as we build up subscribers ;-) What I would suggest is a unique index on `[:subscriber_id, :changeset_id]` which will also make duplicate entries impossible, and an ordinary index on `[:changeset_id]` for finding the subscribers to a changeset.",I don't think you need the `null: false
+2019,"@@ -0,0 +1,13 @@
++package slackbot
++
++import (
++	""github.com/slack-go/slack""
++)
++
++func sendBotReply(client *slack.Client, channel, message string) error {
++	_, _, err := client.PostMessage(channel, slack.MsgOptionText(message, false))
++	if err != nil {
++		return err
++	}
++	return nil
++}","use the context versions of everything, e.g. `PostMessageContext` and thread it through the functions. will save you a bunch of refactoring trouble later on.",Why do we need this function?
+2020,"@@ -64,9 +64,7 @@ def implements(
+     obj: ""BaseChecker"",
+     interface: Union[Type[""Interface""], Tuple[Type[""Interface""], ...]],
+ ) -> bool:
+-    """"""Return whether the given object (maybe an instance or class) implements
+-    the interface.
+-    """"""
++    """"""Does the given object (maybe an instance or class) implements the interface.""""""
+     kimplements = getattr(obj, ""__implements__"", ())
+     if not isinstance(kimplements, (list, tuple)):
+         kimplements = (kimplements,)","""not to be used elsewhere other than""",I think this should be `Returns whether the given object implements the interface.`
+2021,"@@ -205,6 +205,7 @@ class SparkAppenderFactory implements FileAppenderFactory<InternalRow> {
+         case PARQUET:
+           return Parquet.writeDeletes(file.encryptingOutputFile())
+               .createWriterFunc(msgType -> SparkParquetWriters.buildWriter(lazyEqDeleteSparkType(), msgType))
++              .setAll(properties)
+               .overwrite()
+               .rowSchema(eqDeleteRowSchema)
+               .withSpec(spec)","Thanks for the contribution, @coolderli ! I also think the newPosDeleteWriter need the properties setting ...",Why is this needed?
+2022,"@@ -0,0 +1,7 @@
++class AddIndexToSubscriptions < ActiveRecord::Migration
++  def change
++    add_index :subscriptions, :user_id
++    add_index :subscriptions, :team_id
++    add_index :subscriptions, [:plan_id, :plan_type]
++  end
++end",These additions seem unrelated to this change?,I don't think we need this index. We already have the plan_id and plan_type.
+2023,"@@ -126,4 +126,8 @@ public class TableProperties {
+ 
+   public static final String SNAPSHOT_ID_INHERITANCE_ENABLED = ""compatibility.snapshot-id-inheritance.enabled"";
+   public static final boolean SNAPSHOT_ID_INHERITANCE_ENABLED_DEFAULT = false;
++
++  public static final String ENGINE_HIVE_ENABLED = ""engine.hive.enabled"";
++  public static final String ENGINE_HIVE_ENABLED_HIVE_CONF = ""iceberg.engine.hive.enabled"";
++  public static final boolean ENGINE_HIVE_ENABLED_DEFAULT = false;
+ }","Could we move this to a class for Hadoop configuration properties, like `org.apache.iceberg.hadoop.ConfigProperties`?",I think this should be `iceberg.engine.hive.enabled`
+2024,"@@ -95,19 +95,6 @@ func (r *ChaosCollector) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.
+ 		manageFlag = true
+ 	}
+ 
+-	if obj.IsDeleted() {
+-		if !manageFlag {
+-			if err = r.archiveExperiment(req.Namespace, req.Name); err != nil {
+-				r.Log.Error(err, ""failed to archive experiment"")
+-			}
+-		} else {
+-			if err = r.event.DeleteByUID(ctx, string(chaosMeta.GetUID())); err != nil {
+-				r.Log.Error(err, ""failed to delete experiment related events"")
+-			}
+-		}
+-		return ctrl.Result{}, nil
+-	}
+-
+ 	if err := r.setUnarchivedExperiment(req, obj); err != nil {
+ 		r.Log.Error(err, ""failed to archive experiment"")
+ 		// ignore error here",The related statements should also be deleted.,why is this being removed?
+2025,"@@ -455,6 +455,10 @@ class ELBConnection(AWSQueryConnection):
+                     'LoadBalancerName'          : lb_name,
+                     'LoadBalancerPort'          : lb_port,
+                  }
++        if policies:
++            self.build_list_params(params, policies, 'PolicyNames.member.%d')
++        else:
++            params[""PolicyNames""] = """"
+         self.build_list_params(params, policies, 'PolicyNames.member.%d')
+         return self.get_status('SetLoadBalancerPoliciesOfListener', params)
+ ",Shouldn't this line be removed?,Why do we need this?
+2026,"@@ -0,0 +1,7 @@
++bad_names = set([
++    'TEAM',
++    'PUBLIC'
++])
++
++def blacklisted_name(username):
++    return username in bad_names","Just move this into `const.py`. It already has similar stuff. Also, make it uppercase since it's a const.",I'm not sure if this is th
+2027,"@@ -294,6 +294,7 @@ public class PasscodeActivity extends Activity {
+                 launchBiometricAuth();
+             } else {
+                 setMode(PasscodeMode.Check);
++                newMode = PasscodeMode.Check;
+             }
+             break;
+         }","Issue is that `currentMode = newMode;` is called at the end of the method. Passcode screen will come up, but since the activity thinks current mode is biometric check we don't check passcode when submitted.",Why do we need this change
+2028,"@@ -51,7 +51,7 @@ import org.tikv.kvproto.Coprocessor.KeyRange;
+ public class ScanAnalyzer {
+   private static final double INDEX_SCAN_COST_FACTOR = 1.2;
+   private static final double TABLE_SCAN_COST_FACTOR = 1.0;
+-  private static final double DOUBLE_READ_COST_FACTOR = TABLE_SCAN_COST_FACTOR * 3;
++  private static final double DOUBLE_READ_COST_FACTOR = 0.2; // TABLE_SCAN_COST_FACTOR * 3;
+ 
+   public static class ScanPlan {
+     ScanPlan(",Need change it back?,Why this change?
+2029,"@@ -0,0 +1,12 @@
++# Be sure to restart your server when you modify this file.
++
++# Your secret key is used for verifying the integrity of signed cookies.
++# If you change this key, all old signed cookies will become invalid!
++
++# Make sure the secret is at least 30 characters and all random,
++# no regular words or you'll be exposed to dictionary attacks.
++# You can use `rake secret` to generate a secure secret key.
++
++# Make sure your secret_key_base is kept private
++# if you're sharing your code publicly.
++OpenStreetMap::Application.config.secret_key_base = '8be565e2e25831d88231f4bcfd83dfc3ab33957c4f33bb3cff7a279f7820ec4d0c1111f246bb347c68859c0b46b4e591be9179a53a5a7165a9936000d6d2be41'",Didn't we delete this file a while back because it isn't used but people think that it's a security vulnerability that it's checked in?,I'm not sure thi
+2030,"@@ -2,6 +2,7 @@ using System;
+ using System.Collections.Concurrent;
+ using System.Collections.Generic;
+ using System.IO;
++using Datadog.Trace.ExtensionMethods;
+ using Datadog.Trace.Logging;
+ using Newtonsoft.Json;
+ using Newtonsoft.Json.Linq;",nit: Looks like this can be removed now,Why is this need
+2031,"@@ -54,15 +54,9 @@ func (p *PKI) Provision(ctx caddy.Context) error {
+ 	p.ctx = ctx
+ 	p.log = ctx.Logger(p)
+ 
+-	// if this app is initialized at all, ensure there's at
+-	// least a default CA that can be used: the standard CA
+-	// which is used implicitly for signing local-use certs
+ 	if p.CAs == nil {
+ 		p.CAs = make(map[string]*CA)
+ 	}
+-	if _, ok := p.CAs[DefaultCAID]; !ok {
+-		p.CAs[DefaultCAID] = new(CA)
+-	}
+ 
+ 	for caID, ca := range p.CAs {
+ 		err := ca.Provision(ctx, caID, p.log)","Can probably remove the lines above it too (L60-62), since ProvisionDefaultCA() makes sure the map isn't nil.",Why is this remo
+2032,"@@ -260,11 +260,15 @@ static void on_context_dispose(h2o_handler_t *_self, h2o_context_t *ctx)
+ 
+ void h2o_status_register(h2o_pathconf_t *conf)
+ {
++    static int handler_registered = 0;
+     struct st_h2o_root_status_handler_t *self = (void *)h2o_create_handler(conf, sizeof(*self));
+     self->super.on_context_init = on_context_init;
+     self->super.on_context_dispose = on_context_dispose;
+     self->super.on_req = on_req;
+-    h2o_config_register_status_handler(conf->global, requests_status_handler);
+-    h2o_config_register_status_handler(conf->global, events_status_handler);
+-    h2o_config_register_status_handler(conf->global, durations_status_handler);
++    if (!handler_registered) {
++        handler_registered++;
++        h2o_config_register_status_handler(conf->global, requests_status_handler);
++        h2o_config_register_status_handler(conf->global, events_status_handler);
++        h2o_config_register_status_handler(conf->global, durations_status_handler);
++    }
+ }",Do you think it's worth erroring out? It's likely that this is a configuration error that the user might want to know about?,Why do we need to register status handler twice?
+2033,"@@ -20,7 +20,7 @@ def function():
+     #todo: no space after hash
+ 
+     # +1: [fixme]
+-	# FIXME: this is broken
++    # FIXME: this is broken
+     # +1: [fixme]
+     # ./TODO: find with notes
+ 	# +1: [fixme]","I think the functional test should not change here, this is probably a test in itself :)",# FIXME: this is broken
+2034,"@@ -31,7 +31,16 @@ import (
+ 	""github.com/gogits/gogs/modules/setting""
+ )
+ 
+-var Sanitizer = bluemonday.UGCPolicy().AllowAttrs(""class"").Matching(regexp.MustCompile(`[\p{L}\p{N}\s\-_',:\[\]!\./\\\(\)&]*`)).OnElements(""code"")
++func BuildSanitizer() (p *bluemonday.Policy) {
++	p = bluemonday.UGCPolicy()
++	p.AllowAttrs(""class"").Matching(regexp.MustCompile(`[\p{L}\p{N}\s\-_',:\[\]!\./\\\(\)&]*`)).OnElements(""code"")
++
++	p.AllowAttrs(""type"").Matching(regexp.MustCompile(`^checkbox$`)).OnElements(""input"")
++	p.AllowAttrs(""checked"", ""disabled"").OnElements(""input"")
++	return p
++}
++
++var Sanitizer = BuildSanitizer()
+ 
+ // EncodeMD5 encodes string to md5 hex value.
+ func EncodeMD5(str string) string {",Why this to be a public function?,Why is this needed?
+2035,"@@ -21,7 +21,7 @@ module Travis
+         end
+ 
+         def set(var, value, options = {})
+-          cmd ""export #{var}=#{value}"", options.merge(log: false)
++          cmd ""export #{var}=#{value}"", options.merge(log: false, timing: false)
+         end
+ 
+         def echo(string, options = {})",I think we can remove the timing for export env vars,I think this should be `options.merge(timing: fa
+2036,"@@ -29,8 +29,10 @@ limitations under the License.
+ // limitations under the License.
+ 
+ Modifies:
+-- Remove interface ""Provider""
+-- Remove import ""k8s.io/kubernetes/pkg/proxy/config""
++- Replace import ""k8s.io/kubernetes/pkg/proxy/config"" with ""github.com/vmware-tanzu/antrea/third_party/proxy/config""
++- Remove config.EndpointSliceHandler, config.NodeHandler from Provider interface type
++- Remove NodeHandler, EndpointSliceHandler, Sync() from Provider interface
++- Add Run(), GetServiceByIP() to Provider interface
+ */
+ 
+ package proxy",wrong import grouping,Why is this needed?
+2037,"@@ -232,8 +232,7 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
+                         if (newValue.equals(""page"")) {
+                             final Context context = ui.getActivity();
+                             final String[] navTitles = context.getResources().getStringArray(R.array.back_button_go_to_pages);
+-                            final String[] navTags = new String[3];
+-                            System.arraycopy(MainActivity.NAV_DRAWER_TAGS, 0, navTags, 0, 3);
++                            final String[] navTags = context.getResources().getStringArray(R.array.back_button_go_to_pages_tags);
+                             final String choice[] = { UserPreferences.getBackButtonGoToPage() };
+ 
+                             AlertDialog.Builder builder = new AlertDialog.Builder(context);",There is a doubled semicolon ;),Why did you remove 
+2038,"@@ -40,6 +40,10 @@
+ 
+ 
+ #include <math.h>
++#include <zlib.h>
++#include ""openssl/md5.h""
++#include <openssl/sha.h>  
++
+ #define MathSqrt(op, err) sqrt(op)
+ 
+ #include <ctype.h>",I'm wondering why this isn't <openssl/md5.h>. Seems like one would have to copy the md5.h file into the source tree somewhere for this to compile cleanly. Maybe you meant to use angle brackets instead of quotes?,Why is this needed?
+2039,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+         
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?,I think this should
+2040,"@@ -229,6 +229,16 @@ bool Mob::CastSpell(uint16 spell_id, uint16 target_id, CastingSlot slot,
+ 		return false;
+ 	}
+ 
++	if (IsEffectInSpell(spell_id, SE_Charm) && !PassCharmTargetRestriction(entity_list.GetMobID(target_id))) {
++		if (IsClient()) {
++			CastToClient()->SendSpellBarEnable(spell_id);
++		}
++		if (casting_spell_id && IsNPC()) {
++			CastToNPC()->AI_Event_SpellCastFinished(false, static_cast<uint16>(casting_spell_slot));
++		}
++		return false;
++	}
++
+ 	if (HasActiveSong() && IsBardSong(spell_id)) {
+ 		LogSpells(""Casting a new song while singing a song. Killing old song [{}]"", bardsong);
+ 		//Note: this does NOT tell the client","We don't need to cast to client here. (well, from spell gem not AA etc) We should also make sure the charm is a casted spell before calling SendSpellBarEnable.",why do you need this check?
+2041,"@@ -63,6 +63,7 @@ def define_violation(dbengine):
+         full_name = Column(String(1024))
+         inventory_data = Column(Text(16777215))
+         inventory_index_id = Column(String(256))
++        invocation_id = Column(DateTime())
+         resource_id = Column(String(256), nullable=False)
+         resource_type = Column(String(256), nullable=False)
+         rule_name = Column(String(256))","This is not an `id`. This should either be `invocation_time` or `invocated_at` to be consistent with what we are using elsewhere, and also to better rerflect the column's DateTime type. Also, within the context of this table, there is no idea of what `invocation` is. I know that `scanner` may not be future-proof, but we need to find something more descriptive. Perhaps one possibility is to call this `audit_time`.",Why is this nullable?
+2042,"@@ -412,6 +412,18 @@ func (tx Transaction) TxAmount() basics.MicroAlgos {
+ 	}
+ }
+ 
++// GetReceiverAddress returns the address of the receiver. If the transaction has no receiver, it returns the empty address.
++func (tx Transaction) GetReceiverAddress() basics.Address {
++	switch tx.Type {
++	case protocol.PaymentTx:
++		return tx.PaymentTxnFields.Receiver
++	case protocol.AssetTransferTx:
++		return tx.AssetTransferTxnFields.AssetReceiver
++	default:
++		return basics.Address{}
++	}
++}
++
+ // EstimateEncodedSize returns the estimated encoded size of the transaction including the signature.
+ // This function is to be used for calculating the fee
+ func (tx Transaction) EstimateEncodedSize() int {",should the 'Receiver' be the clawback address in case of clawback transaction?,Why do we need this functio
+2043,"@@ -19,10 +19,16 @@ package command
+ import (
+ 	""errors""
+ 	""flag""
+-
+ 	""github.com/spf13/cobra""
+ )
+ 
++const (
++	// VolumeAPIPath is the api path to get volume information
++	VolumeAPIPath      = ""/latest/volumes/""
++	controllerStatusOk = ""running""
++	volumeStatusOK     = ""Running""
++)
++
+ var (
+ 	volumeCommandHelpText = `
+ The following commands helps in operating a Volume such as create, list, and so on.",@ashishranjan738 -- Where are these consts used? in which pkg?,I think this should be `vol
+2044,"@@ -81,12 +81,12 @@ autodoc_default_options = {
+     ""show-inheritance"": True,
+ }
+ 
++# Generate autosummary pages. Output should be set with: `:toctree: pythonapi/`
++autosummary_generate = ['Python-API.rst']
++
+ # Add any paths that contain templates here, relative to this directory.
+ templates_path = ['_templates']
+ 
+-# Generate autosummary pages. Output should be set with: `:toctree: pythonapi/`
+-autosummary_generate = True
+-
+ # The suffix(es) of source filenames.
+ # You can specify multiple suffix as a list of string:
+ # source_suffix = ['.rst', '.md']",The only change I would suggest is moving these lines back below the `templates_path` variable to keep the diffs smaller.,Why did you remove this?
+2045,"@@ -1862,8 +1862,8 @@ func (fbo *folderBranchOps) unembedBlockChanges(
+ 
+ 	md.AddRefBytes(uint64(info.EncodedSize))
+ 	md.AddDiskUsage(uint64(info.EncodedSize))
+-	changes.Info = info
+ 	md.data.cachedChanges = *changes
++	changes.Info = info
+ 	changes.Ops = nil
+ 	return nil
+ }","Having it above kept the block info in the cached changes, which could end up confusing things quite a bit.",Why this change?
+2046,"@@ -409,15 +409,7 @@ HELP
+                 outputter.print_event(node, event)
+               end
+             when 'task'
+-              task_name = options[:object]
+-
+-              path, metadata = load_task_data(task_name, @config[:modulepath])
+-              input_method = metadata['input_method']
+-
+-              input_method ||= 'both'
+-              executor.run_task(
+-                nodes, path, input_method, options[:task_options]
+-              ) do |node, event|
++              execute_task(executor, options) do |node, event|
+                 outputter.print_event(node, event)
+               end
+             when 'file'","If the execute_task returns an `ExecutionResult`, the passing of a block would be unnecessary. Instead, the `ExecutionResult` could be presented to the user in some standardized way (iterating over the result of each node, etc.).",Why did you remove the `
+2047,"@@ -199,7 +199,7 @@ func (c *client) InstallTunnelFlows(tunnelOFPort uint32) error {
+ 
+ func (c *client) Initialize() error {
+ 	// Initiate connections to target OFswitch, and create tables on the switch.
+-	if err := c.bridge.Connect(maxRetryForOFSwitch); err != nil {
++	if err := c.bridge.Connect(maxRetryForOFSwitch, make(chan struct{})); err != nil {
+ 		return err
+ 	}
+ ","Not sure why we make a new channel here. If we don't use this channel, how about creating it inside the `Connect`?",Why do we need a channel
+2048,"@@ -1001,6 +1001,12 @@ void RaftPart::processAppendLogResponses(const AppendLogResponses& resps,
+     LOG_EVERY_N(WARNING, 100) << idStr_ << ""Only "" << numSucceeded
+                               << "" hosts succeeded, Need to try again"";
+     usleep(1000);
++    {
++      std::lock_guard<std::mutex> g(raftLock_);
++      // wal could be rollback between two cycles, if we still use the old lastLogId, we may always
++      // get E_RAFT_NO_WAL_FOUND
++      lastLogId = std::min(wal_->lastLogId(), lastLogId);
++    }
+     replicateLogs(eb, std::move(iter), currTerm, lastLogId, committedId, prevLogTerm, prevLogId);
+   }
+ }","There are two question here: 1. If you only modify lastLogId, but the `iter` is not modified, I really don't know whether we can succeed. 2. We will check the if the term has changed in `replicateLogs` (if rollback really happen, the term must have been updated), so I really doubt whether the problem should be fixed in this way. Or you could describe it in more details.",Why do we need this lock?
+2049,"@@ -164,7 +164,7 @@ class OrderFlow extends FormFlow
+         $request = $this->getRequest()->request;
+         $requestParameters = $request->all();
+         $requestParameters['flow_order_step'] = $step->getNumber();
+-        $requestParameters[$step->getFormType()->getName()] = $stepData;
++        $requestParameters[$step->getFormType()] = $stepData;
+         $request->replace($requestParameters);
+     }
+ }","Hello @jDolba, I have reviewed your PR and I found one problem. `$step->getFormType()` can return `FormTypeInterface`. You cannot use interface as key for an array. Can you find some better way to fix this? Thank you.",Why did you remove the `g
+2050,"@@ -62,6 +62,19 @@ gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
+ EOM
+ yum -y install google-osconfig-agent
+ echo 'inventory install done'`
++var installInventoryYumEL6 = `sleep 10
++cat > /etc/yum.repos.d/google-osconfig-agent.repo <<EOM
++[google-osconfig-agent]
++name=Google OSConfig Agent Repository
++baseurl=https://packages.cloud.google.com/yum/repos/google-osconfig-agent-el6-unstable
++enabled=1
++gpgcheck=0
++repo_gpgcheck=1
++gpgkey=https://packages.cloud.google.com/yum/doc/yum-key.gpg
++       https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg
++EOM
++yum -y install google-osconfig-agent
++echo 'inventory install done'`
+ 
+ type inventoryTestSetup struct {
+ 	image       string","i was confused by keyword ""inventory"" here. my understanding is this starts the osconfig-agent which covers inventory lookup and package-management(correct me if i am wrong).",I think this should be `g
+2051,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+ 
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities",I don't think this is use
+2052,"@@ -1,5 +1,6 @@
+ import { options, createElement as h, render } from 'preact';
+ import { useEffect, useState } from 'preact/hooks';
++import sinon from 'sinon';
+ 
+ import { setupScratch, teardown } from '../../../test/_util/helpers';
+ import { act } from '../../src';",This breaks tests on IE because this will import an `esm` bundle. For that reason `sinon` is available as a global in our test suite and never imported. The global is aliased to the proper `es5` file.,"import { useEffect, useState } from 'react';"
+2053,"@@ -12,6 +12,18 @@ import (
+ 	""github.com/lucas-clemente/quic-go/utils""
+ )
+ 
++const (
++	// Maximum reordering in time space before time based loss detection considers a packet lost.
++	// In fraction of an RTT.
++	timeReorderingFraction = 1.0 / 8
++	// defaultRTOTimeout is the RTO time on new connections
++	defaultRTOTimeout = 500 * time.Millisecond
++	// Minimum time in the future an RTO alarm may be set for.
++	minRTOTimeout = 200 * time.Millisecond
++	// maxRTOTimeout is the maximum RTO time
++	maxRTOTimeout = 60 * time.Second
++)
++
+ var (
+ 	// ErrDuplicateOrOutOfOrderAck occurs when a duplicate or an out-of-order ACK is received
+ 	ErrDuplicateOrOutOfOrderAck = errors.New(""SentPacketHandler: Duplicate or out-of-order ACK"")",Maybe move all the Loss Recovery constants to a separate file.,Why do we need this?
+2054,"@@ -145,6 +145,7 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError {
+ }
+ 
+ type diskAttachment struct {
++	diskName           string
+ 	mode               string
+ 	attacher, detacher *Step
+ }",this field is added so that we can find disk name by device name from attachments,type diskAttachment struct {
+2055,"@@ -1,5 +1,6 @@
+ package com.fsck.k9.activity;
+ 
++
+ import android.content.BroadcastReceiver;
+ import android.content.Context;
+ import android.content.Intent;",Unnecessary new line,import android.content.BroadcastReceiver;
+2056,"@@ -1893,13 +1893,15 @@ func (c *linuxContainer) currentState() (*State, error) {
+ 			state.NamespacePaths[ns.Type] = ns.GetPath(pid)
+ 		}
+ 		for _, nsType := range configs.NamespaceTypes() {
+-			if !configs.IsNamespaceSupported(nsType) {
++			if _, ok := state.NamespacePaths[nsType]; ok {
+ 				continue
+ 			}
+-			if _, ok := state.NamespacePaths[nsType]; !ok {
+-				ns := configs.Namespace{Type: nsType}
+-				state.NamespacePaths[ns.Type] = ns.GetPath(pid)
++			if !configs.IsNamespaceSupported(nsType) {
++				continue
+ 			}
++			ns := configs.Namespace{Type: nsType}
++			state.NamespacePaths[ns.Type] = ns.GetPath(pid)
++
+ 		}
+ 	}
+ 	return state, nil","First determine if the namespace already exists, so it's clearer that it's handling namespaces that aren't included in the `c.config.Namespaces`",Why this change?
+2057,"@@ -1,7 +1,5 @@
+-<section class=""assets-wrapper"">
+-  <div class=""assets"">
+-    <%= render ""videos/download_link"", download_type_key: ""OriginalFile"", download_type: ""original"", size_display: ""Original (720p)"", clip: clip %>
+-    <%= render ""videos/download_link"", download_type_key: ""IphoneVideoFile"", download_type: ""iphone"", size_display: ""iPhone"", clip: clip %>
+-    <%= render ""videos/download_link"", download_type_key: ""HdMp4VideoFile"", download_type: ""hd_mp4"", size_display: ""HD MP4"", clip: clip %>
+-  </div>
++<section class=""download-links"">
++  <%= render ""videos/download_link"", download_type_key: ""OriginalFile"", download_type: ""original"", size_display: ""Original (720p)"", clip: clip %>
++  <%= render ""videos/download_link"", download_type_key: ""IphoneVideoFile"", download_type: ""iphone"", size_display: ""iPhone"", clip: clip %>
++  <%= render ""videos/download_link"", download_type_key: ""HdMp4VideoFile"", download_type: ""hd_mp4"", size_display: ""HD MP4"", clip: clip %>
+ </section>",What changed in the styles that means we don't need this?,Why did you remo
+2058,"@@ -275,13 +275,13 @@ namespace Microsoft.DotNet.Build.Tasks
+            } 
+         }
+ 
+-        private JToken GetFrameworkDependenciesSection(JObject projectJsonRoot, string framework = null)
++        private JObject GetFrameworkDependenciesSection(JObject projectJsonRoot, string framework = null)
+         {
+             if(string.IsNullOrWhiteSpace(framework))
+             {
+-                return projectJsonRoot[""dependencies""];
++                return (JObject) projectJsonRoot[""dependencies""];
+             }
+-            return projectJsonRoot.SelectToken(""frameworks."" + NewtonsoftEscapeJProperty(framework) + "".dependencies"");
++            return (JObject) projectJsonRoot[""frameworks""][framework][""dependencies""];
+         }
+ 
+         // Generate the combines dependencies from the projectjson jObject and from AdditionalDependencies",This pattern should be applied to the other instance where NewtonsoftEscapeJProperty is used and you can remove the NewtonsoftEscapeJProperty method.,Why is this cast
+2059,"@@ -165,6 +165,10 @@ class Histogram(Element2D):
+     vdims = param.List(default=[Dimension('Frequency')], bounds=(1,1))
+ 
+     def __init__(self, values, edges=None, **params):
++        if edges is not None:
++            self.warning(""Histogram edges should be supplied as a tuple ""
++                         ""along with the values, passing the edges will ""
++                         ""be deprecated in holoviews 2.0."")
+         self.values, self.edges, settings = self._process_data(values, edges)
+         settings.update(params)
+         super(Histogram, self).__init__((self.values, self.edges), **settings)",Something to mention in the next changelog/release notes. It will be good to get histogram working consistently with everything else.,I don't think th
+2060,"@@ -892,6 +892,7 @@ spec:
+                     values:
+                     - {{ $targetAffinityVal }}
+                 topologyKey: kubernetes.io/hostname
++                namespaces: [{{.Volume.runNamespace}}]
+           {{- end }}
+           containers:
+           - args:",What does this contain? Is it PVC namespace or is it openebs?,I think this should be `{{.Volume.runNamespace}}`
+2061,"@@ -0,0 +1,18 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
++{
++    /// <summary>
++    /// Represents a minimum data rate for the request body of an HTTP request.
++    /// </summary>
++    public interface IHttpRequestBodyMinimumDataRateFeature
++    {
++        /// <summary>
++        /// The minimum data rate in bytes/second at which the request body should be received.
++        /// Setting this property to null indicates no minimum data rate should be enforced.
++        /// This limit has no effect on upgraded connections which are always unlimited.
++        /// </summary>
++        MinimumDataRate MinimumDataRate { get; set; }
++    }
++}","Design note: Using local concrete data types on a feature abstraction makes it hard to generalize / replace. This is tolerable so long as this remains a kestrel exclusive feature, but we'd need a different design if this were ever moved to HttpAbstractions.",Why is this an interface and not a property?
+2062,"@@ -426,11 +426,12 @@ LGBM_SE LGBM_BoosterGetEvalNames_R(LGBM_SE handle,
+   LGBM_SE buf_len,
+   LGBM_SE actual_len,
+   LGBM_SE eval_names,
+-  LGBM_SE call_state) {
++  LGBM_SE call_state,
++  LGBM_SE data_idx) {
+ 
+   R_API_BEGIN();
+   int len;
+-  CHECK_CALL(LGBM_BoosterGetEvalCounts(R_GET_PTR(handle), &len));
++  CHECK_CALL(LGBM_BoosterGetEvalCounts(R_GET_PTR(handle), R_AS_INT(data_idx), &len));
+   std::vector<std::vector<char>> names(len);
+   std::vector<char*> ptr_names(len);
+   for (int i = 0; i < len; ++i) {","this will break R package, you should update the R files accordingly. BTW, the call state should be in the last argument.",`data_idx` should be `LGBM_SE`
+2063,"@@ -182,9 +182,13 @@ final class MediaController
+     public function getMediumFormatsAction($id): FOSRestView
+     {
+         $media = $this->getMedium($id);
++        $mediaContext = $media->getContext();
+ 
+         $formats = [MediaProviderInterface::FORMAT_REFERENCE];
+-        $formats = array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($media->getContext())));
++
++        if (null !== $mediaContext) {
++            $formats = array_merge($formats, array_keys($this->mediaPool->getFormatNamesByContext($mediaContext)));
++        }
+ 
+         $provider = $this->mediaPool->getProvider($media->getProviderName());
+ ",Shouldn't we throw an exception if the context is null instead ?,Why do we need this check?
+2064,"@@ -13,6 +13,9 @@ var DdevVersion = ""v0.3.0-dev"" // Note that this is overridden by make
+ // for examples defining version constraints.
+ var DockerVersionConstraint = "">= 17.05.0-ce""
+ 
++// DockerComposeVersionConstraint is the current minimum version of docker-compose required for ddev.
++var DockerComposeVersionConstraint = "">= 1.10.0""
++
+ // WebImg defines the default web image used for applications.
+ var WebImg = ""drud/nginx-php-fpm-local"" // Note that this is overridden by make
+ ","These should both be const, not var right?",This should be `1.10.0-ce`
+2065,"@@ -0,0 +1,8 @@
++from mmcv.utils import Registry, build_from_cfg
++
++MATCH_COST = Registry('Match Cost')
++
++
++def build_match_cost(cfg, default_args=None):
++    """"""Builder of IoU calculator.""""""
++    return build_from_cfg(cfg, MATCH_COST, default_args)","Rename the directory, match_costers -> match_costs",Why do we need this functi
+2066,"@@ -64,6 +64,13 @@ class DeleteModelTest(BaseTest):
+         records = result['data']
+         self.assertEqual(len(records), 1)
+ 
++    def test_delete_collection_gives_number_of_deletable_records_in_headers(self):
++        self.resource.request.GET = {'_limit': '1'}
++        self.resource.collection_delete()
++        headers = self.last_response.headers
++        count = headers['Total-Records']
++        self.assertEquals(int(count), 2)
++
+ 
+ class IsolatedModelsTest(BaseTest):
+     def setUp(self):","I don't think this should go in the model tests, since it is done in the resource. `PaginatedDeleteTest` seems more appropriate",I think you can use `self.
+2067,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()),I don't think this is the 
+2068,"@@ -130,13 +130,13 @@ func NewExportPipeline(config Config, options ...controller.Option) (*Exporter,
+ // InstallNewPipeline instantiates a NewExportPipeline and registers it globally.
+ // Typically called as:
+ //
+-// 	hf, err := prometheus.InstallNewPipeline(prometheus.Config{...})
++// 	exporter, err := prometheus.InstallNewPipeline(prometheus.Config{...})
+ //
+ // 	if err != nil {
+ // 		...
+ // 	}
+-// 	http.HandleFunc(""/metrics"", hf)
+-// 	defer pipeline.Stop()
++// 	http.HandleFunc(""/metrics"", exporter)
++// 	defer exporter.Controller().Stop(context.TODO())
+ // 	... Done
+ func InstallNewPipeline(config Config, options ...controller.Option) (*Exporter, error) {
+ 	exp, err := NewExportPipeline(config, options...)",Could we move this to an example test to allow the compiler to help us ensure it stays up-to-date in the future?,Why is this context.TODO()?
+2069,"@@ -380,14 +380,6 @@ describe ""Bolt::CLI"" do
+         cli = Bolt::CLI.new(%w[command run uptime --password opensesame --nodes foo])
+         expect(cli.parse).to include(password: 'opensesame')
+       end
+-
+-      it ""prompts the user for password if not specified"" do
+-        allow(STDIN).to receive(:noecho).and_return('opensesame')
+-        allow(STDOUT).to receive(:print).with('Please enter your password: ')
+-        allow(STDOUT).to receive(:puts)
+-        cli = Bolt::CLI.new(%w[command run uptime --nodes foo --password])
+-        expect(cli.parse).to include(password: 'opensesame')
+-      end
+     end
+ 
+     describe ""key"" do",Maybe we could update these to use $future and then check on stderr? that way when we deprecate stdout we can not have to delete tests.,Why was this test removed?
+2070,"@@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+ 
+         public void PrepareContinuation(Http2ContinuationFrameFlags flags, int streamId)
+         {
+-            PayloadLength = MinAllowedMaxFrameSize - HeaderLength;
++            PayloadLength = (int)_maxFrameSize;
+             Type = Http2FrameType.CONTINUATION;
+             ContinuationFlags = flags;
+             StreamId = streamId;",Remove this since it always has to be set afterwards.,Why do we need this cast?
+2071,"@@ -11,7 +11,7 @@ import ""testing""
+ // bob writes a multi-block file while unmerged, no conflicts
+ func TestCrUnmergedWriteMultiblockFile(t *testing.T) {
+ 	test(t,
+-		blockSize(20), users(""alice"", ""bob""),
++		blockSize(20), blockChangeSize(20*1024), users(""alice"", ""bob""),
+ 		as(alice,
+ 			mkdir(""a""),
+ 		),","These two tests were causing us to use too many goroutines with `-race` using the default block change size, I think due to prefetching.",Why is this change needed?
+2072,"@@ -25,8 +25,13 @@ class LeafNode(Node):
+     self.reader = reader
+     self.is_leaf = True
+ 
+-  def fetch(self, startTime, endTime):
+-    return self.reader.fetch(startTime, endTime)
++  def fetch(self, startTime, endTime, now=None, requestContext=None):
++    try:
++      result = self.reader.fetch(startTime, endTime, now, requestContext)
++    except TypeError:
++      result = self.reader.fetch(startTime, endTime)
++
++    return result
+ 
+   @property
+   def intervals(self):","Is that `try..except` block really needed? I mean, when it could fail?","I'm not sure if this is the best way to do this. I think it would be better to have a `fetch(self, startTime, endTime, now=None, requestContext=None)` method."
+2073,"@@ -101,7 +101,7 @@ module.exports = function(config) {
+ 
+ 		files: [
+ 			{ pattern: 'test/polyfills.js', watched: false },
+-			{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/test/{browser,shared}/**.test.js', watched: false }
++			{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/test/{browser,shared}/suspense.test.js', watched: false }
+ 		],
+ 
+ 		preprocessors: {",If you only want to run a specific group of tests you can always use `.only` like `it.only()` or `describe.only()`. It may not speed up the globbing process as much as this change here :),"{ pattern: config.grep || '{debug,hooks,compat,test-utils,}/**.test.js', watched: false },"
+2074,"@@ -65,7 +65,13 @@ LAMBDA_DEFAULT_STARTING_POSITION = 'LATEST'
+ LAMBDA_ZIP_FILE_NAME = 'original_lambda_archive.zip'
+ LAMBDA_JAR_FILE_NAME = 'original_lambda_archive.jar'
+ 
+-DEFAULT_BATCH_SIZE = 10
++INVALID_PARAMETER_VALUE_EXCEPTION = 'InvalidParameterValueException'
++
++BATCH_SIZE_MAP = {
++    'kinesis': (100, 10000),
++    'dynamodb': (100, 1000),
++    'sqs': (10, 10)
++}
+ 
+ app = Flask(APP_NAME)
+ ","nit: I'd probably rename this to `BATCH_SIZE_RANGES`, to use a slightly more descriptive name.",nit: I think this should be `INVALID_PARAMETER_VALUE_EXCEPTION`
+2075,"@@ -1322,7 +1322,8 @@ public class MenuEntrySwapperPlugin extends Plugin
+ 
+ 		if (this.swapCoalBag)
+ 		{
+-			menuManager.addPriorityEntry(""Empty"", ""Coal bag"");
++			menuManager.addPriorityEntry(""Empty"", ""Coal bag"").setPriority(90);
++			menuManager.addPriorityEntry(""Fill"", ""Coal bag"").setPriority(100);
+ 		}
+ 
+ 		if (this.swapBones)",aren't these the wrong way around?,Shouldn't this be `Fill`?
+2076,"@@ -2027,6 +2027,10 @@ public class CoreContainer {
+     return configSetsHandler;
+   }
+ 
++  public ConfigSetService getCoreConfigService() {
++    return this.coreConfigService;
++  }
++
+   public String getHostName() {
+     return this.hostName;
+   }",Lets call this getConfigSetService and maybe rename the field now (or later),Why do we need this method?
+2077,"@@ -27,8 +27,8 @@ import (
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/schema""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+-	""k8s.io/klog""
+-	""k8s.io/klog/klogr""
++	""k8s.io/klog/v2""
++	""k8s.io/klog/v2/klogr""
+ 
+ 	""github.com/jetstack/cert-manager/pkg/api""
+ )",Could / should we make these constants and give them a type?,Why do we need this change?
+2078,"@@ -63,6 +63,13 @@ const (
+ 
+ 	deleteAfterAnnotation    = ""hive.openshift.io/delete-after"" // contains a duration after which the cluster should be cleaned up.
+ 	tryInstallOnceAnnotation = ""hive.openshift.io/try-install-once""
++
++	platformAWS       = ""aws""
++	platformAzure     = ""azure""
++	platformGCP       = ""GCP""
++	platformBaremetal = ""baremetal""
++	platformUnknown   = ""unknown platform""
++	regionUnknown     = ""unknown region""
+ )
+ 
+ var (",lets stick with lowercase for consistency.,I don't think this is used 
+2079,"@@ -17,10 +17,9 @@ limitations under the License.
+ package acme
+ 
+ import (
+-	corev1 ""k8s.io/api/core/v1""
+-
+ 	cmacme ""github.com/jetstack/cert-manager/pkg/apis/acme/v1""
+ 	cmmeta ""github.com/jetstack/cert-manager/pkg/apis/meta/v1""
++	corev1 ""k8s.io/api/core/v1""
+ )
+ 
+ // IsFinalState will return true if the given ACME State is a 'final' state.",ordering of imports went wrong,nit: remove empty line
+2080,"@@ -84,6 +84,11 @@ public class AllDataFilesTable extends BaseMetadataTable {
+       this.fileSchema = fileSchema;
+     }
+ 
++    @Override
++    protected String tableType() {
++      return String.valueOf(MetadataTableType.ALL_DATA_FILES);
++    }
++
+     @Override
+     protected TableScan newRefinedScan(TableOperations ops, Table table, Schema schema, TableScanContext context) {
+       return new AllDataFilesTableScan(ops, table, schema, fileSchema, context);",I think these can all be .name() to get the value we are looking for,Why do we need this method?
+2081,"@@ -2622,6 +2622,16 @@ class FunctionCallTest extends TestCase
+                     array_push();',
+                 'error_message' => 'TooFewArguments',
+             ],
++            'printOnlyString' => [
++                '<?php
++                    print [];',
++                'error_message' => 'InvalidArgument',
++            ],
++            'printReturns1' => [
++                '<?php
++                    (print ""test"") === 2;',
++                'error_message' => 'TypeDoesNotContainType',
++            ],
+         ];
+     }
+ }",Is this a good place for these test cases?,This should be `array_push(
+2082,"@@ -45,6 +45,7 @@ class Job(object):
+         self.vault = vault
+         if response_data:
+             for response_name, attr_name, default in self.ResponseDataElements:
++                print response_name, attr_name
+                 setattr(self, attr_name, response_data[response_name])
+         else:
+             for response_name, attr_name, default in self.ResponseDataElements:",Did you mean to leave the print statement?,Is this for debugging?
+2083,"@@ -184,6 +184,9 @@ Interpreter.false = new Buffer([]);
+ 
+ Interpreter.MAX_SCRIPT_ELEMENT_SIZE = 520;
+ 
++Interpreter.LOCKTIME_THRESHOLD = 500000000;
++Interpreter.LOCKTIME_THRESHOLD_BN = new BN(500000000);
++
+ // flags taken from bitcoind
+ // bitcoind commit: b5d1b1092998bc95313856d535c632ea5a8f9104
+ Interpreter.SCRIPT_VERIFY_NONE = 0;",I would do `new BN(Interpreter.LOCKTIME_THRESHOLD)`,Why is this necessary?
+2084,"@@ -23,9 +23,7 @@ package com.github.javaparser.ast.visitor;
+ 
+ import com.github.javaparser.ast.Node;
+ 
+-import java.util.ArrayList;
+-import java.util.LinkedList;
+-import java.util.Queue;
++import java.util.*;
+ 
+ /**
+  * Iterate over all the nodes in (a part of) the AST.","@ftomassetti I turned the tree walking algorithms into iterators so you don't have to visit every node when you only wanted a few, like for a `findFirst`.",Please don't use wildcard imports.
+2085,"@@ -416,7 +416,7 @@ func timerTypeFromThrift(
+ func timerTypeToReason(
+ 	timerType timerType,
+ ) string {
+-	return fmt.Sprintf(""cadenceInternal:Timeout %v"", timerTypeToThrift(timerType))
++	return fmt.Sprintf(""cadenceInternal:Timeout TimeoutType%v"", timerTypeToThrift(timerType))
+ }
+ 
+ // Len implements sort.Interface",Need to add type name here to be compatible with proto string representation.,// TimeoutType is the type of the 
+2086,"@@ -40,7 +40,7 @@ public class BazelBuild {
+     if (target == null || """".equals(target)) {
+       throw new IllegalStateException(""No targets specified"");
+     }
+-    log.info(""\nBuilding "" + target + "" ..."");
++    log.finest(""\nBuilding "" + target + "" ..."");
+ 
+     ImmutableList.Builder<String> builder = ImmutableList.builder();
+     builder.add(""bazel"", ""build"", target);",This is to let people know that the tooling is doing something during a build. Please leave.,Why is this change needed?
+2087,"@@ -17,8 +17,8 @@ MINIMALIST_COLLECTION = {'data': dict()}
+ MINIMALIST_GROUP = {'data': dict(members=['fxa:user'])}
+ MINIMALIST_RECORD = {'data': dict(name=""Hulled Barley"",
+                                   type=""Whole Grain"")}
+-USER_PRINCIPAL = 'basicauth:8a931a10fc88ab2f6d1cc02a07d3a81b5d4768f' \
+-                 '6f13e85c5d8d4180419acb1b4'
++USER_PRINCIPAL = 'basicauth:aaedca130273574dd2bd6c3acad57f3545b662a974fa4320' \
++                 '236f25fe474676d6'
+ 
+ 
+ class BaseWebTest(object):",Why is the principal changing here?,Why did you change this?
+2088,"@@ -26,6 +26,11 @@
+ // The default URL opener will use credentials from the environment variables
+ // AZURE_STORAGE_ACCOUNT, AZURE_STORAGE_KEY, and AZURE_STORAGE_SAS_TOKEN.
+ // AZURE_STORAGE_ACCOUNT is required, along with one of the other two.
++// AZURE_BLOB_DOMAIN can optionally be used to provide an Azure Environment
++// blob storage domain to use. If no AZURE_BLOB_DOMAIN is provided, the
++// default Azure public domain ""blob.core.windows.net"" will be used. Check
++// the Azure Developer Guide for your particular cloud environment to see
++// the proper blob storage domain name to provide.
+ // To customize the URL opener, or for more details on the URL format,
+ // see URLOpener.
+ // See https://gocloud.dev/concepts/urls/ for background information.",Naming nit: let's use `AZURE_STORAGE_` prefix for consistency with the other ones.,nit: I think it would be good to add a link to the Azure Developer Guide here.
+2089,"@@ -0,0 +1,18 @@
++const Plugin = require('../../core/Plugin')
++
++module.exports = class ProgressBar extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++
++    this.id = opts.id
++    this.type = 'progressindicator'
++  }
++
++  install () {
++    this.opts.onInstall()
++  }
++
++  uninstall () {
++    this.opts.onUninstall()
++  }
++}",I'm a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?,`uppy` is not used
+2090,"@@ -1,6 +1,9 @@
+ package v1alpha1
+ 
+ import (
++	""errors""
++	""strings""
++
+ 	v1 ""k8s.io/api/core/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ ",can we use `github.com/pkg/errors`?,Why do we need this?
+2091,"@@ -72,15 +72,15 @@ func Compile(scope Scope, f *semantic.FunctionExpression, in semantic.MonoType)
+ // inType and mapping any variables to the value in the other record.
+ // If the input type is not a type variable, it will check to ensure
+ // that the type in the input matches or it will return an error.
+-func substituteTypes(subst map[uint64]semantic.MonoType, inType, in semantic.MonoType) error {
++func substituteTypes(subst map[uint64]semantic.MonoType, inferredType, actualType semantic.MonoType) error {
+ 	// If the input isn't a valid type, then don't consider it as
+ 	// part of substituting types. We will trust type inference has
+ 	// the correct type and that we are just handling a null value
+ 	// which isn't represented in type inference.
+-	if in.Nature() == semantic.Invalid {
++	if actualType.Nature() == semantic.Invalid {
+ 		return nil
+-	} else if inType.Kind() == semantic.Var {
+-		vn, err := inType.VarNum()
++	} else if inferredType.Kind() == semantic.Var {
++		vn, err := inferredType.VarNum()
+ 		if err != nil {
+ 			return err
+ 		}",I changed the name of the arguments here just to help make the code clearer.,nit: `actualType` -> `inferredType`
+2092,"@@ -404,7 +404,10 @@ class Callable(param.Parameterized):
+     allowing their inputs (and in future outputs) to be defined.
+     This makes it possible to wrap DynamicMaps with streams and
+     makes it possible to traverse the graph of operations applied
+-    to a DynamicMap.
++    to a DynamicMap. Additionally a Callable will memoize the last
++    returned value based on the arguments to the function and the
++    state of all streams on its inputs, avoiding calling the function
++    unncessarily.
+     """"""
+ 
+     callable_function = param.Callable(default=lambda x: x, doc=""""""",I think either 'avoiding calls to the function' or 'to avoid calling the function ...' would be read better.,I don't think this is the right way to do it. It's not clear to me why we need to memoize the last returned value.
+2093,"@@ -5425,7 +5425,7 @@ SyncOpBeginRenderPass::SyncOpBeginRenderPass(CMD_TYPE cmd, const SyncValidator &
+             // TODO: Revisit this when all attachment validation is through SyncOps to see if we can discard the plain pointer copy
+             // Note that this a safe to presist as long as shared_attachments is not cleared
+             attachments_.reserve(shared_attachments_.size());
+-            for (const auto attachment : shared_attachments_) {
++            for (const auto &attachment : shared_attachments_) {
+                 attachments_.emplace_back(attachment.get());
+             }
+         }","@sfricke-samsung -- thanks. saves a few atomic ops which is always good :) The TODO is there to track that this object is storing *both* vectors of shared_ptr and plain pointers to the same data. The shared are to ensure scope, and the plain are for backwards compatibility with existing code that consumed a plain pointer vector (and some code that still does). That should be cleaned up.",Why this change?
+2094,"@@ -16,10 +16,16 @@
+ //
+ 
+ using System;
++using System.Collections.Generic;
+ using System.IO;
+ using System.Linq;
+ using System.Reflection;
+ using FluentAssertions;
++using Nethermind.Core;
++using Nethermind.Logging;
++using Nethermind.Monitoring.Config;
++using Nethermind.Monitoring.Metrics;
++using Nethermind.Runner;
+ using NUnit.Framework;
+ 
+ namespace Nethermind.Monitoring.Test",minor: typo (knowMetricsTypes -> knownMetricsTypes),Why is this needed?
+2095,"@@ -503,7 +503,13 @@ ConstValue* OptRangeSpec::getConstOperand(ItemExpr* predExpr, Lng32 constInx)
+   // currently support. Predicates involving types not yet supported will be
+   // treated as residual predicates.
+   if (QRDescGenerator::typeSupported(static_cast<ConstValue*>(right)->getType()))
++  {
++    /* add constvalue ‘not casespecific’ to type_*/
++      ((CharType*)getType())->setCaseinsensitive(
++              ((CharType *)(((ConstValue*)(right))->getType()))->isCaseinsensitive());
++
+     return static_cast<ConstValue*>(right);
++  }
+   else
+     return NULL;
+ } // getConstOperand()","This adds a case-insensitive flag to the type in the RangeSpec, but I don't think RangeSpecs are written to handle case-insensitive comparisons. Take a look at the methods that deal with comparisons when building RangeSpecs, in file Range.cpp. So, I think you would have to do one of two things: a) disable the RangeSpec transformation for case-insensitive comparison operators (the easy way) or b) change the RangeSpec methods to handle case-insensitive comparisons.",Why is this needed?
+2096,"@@ -637,6 +637,16 @@ public class MethodResolutionLogic {
+         throw new UnsupportedOperationException(typeDeclaration.getClass().getCanonicalName());
+     }
+ 
++    public static SymbolReference<ResolvedMethodDeclaration> solveMethodInFQN(String fqn, String name,
++                                                                             List<ResolvedType> argumentsTypes, boolean staticOnly, TypeSolver typeSolver) {
++        SymbolReference<ResolvedReferenceTypeDeclaration> typeRef = typeSolver.tryToSolveType(fqn);
++        if (typeRef.isSolved()) {
++            return solveMethodInType(typeRef.getCorrespondingDeclaration(), name, argumentsTypes,
++                    staticOnly, typeSolver);
++        }
++        return SymbolReference.unsolved(ResolvedMethodDeclaration.class);
++    }
++
+     private static void inferTypes(ResolvedType source, ResolvedType target, Map<ResolvedTypeParameterDeclaration, ResolvedType> mappings) {
+ 
+ ",I would throw an exception if the type is not solved,I think this should be renamed to `solveMethodInType`.
+2097,"@@ -52,11 +52,8 @@ func TestDifficulty(t *testing.T) {
+ 
+ 	// files are 2 years old, contains strange values
+ 	dt.skipLoad(""difficultyCustomHomestead\\.json"")
+-	dt.skipLoad(""difficultyMorden\\.json"")
+-	dt.skipLoad(""difficultyOlimpic\\.json"")
+ 
+ 	dt.config(""Ropsten"", *params.RopstenChainConfig)
+-	dt.config(""Morden"", *params.RopstenChainConfig)
+ 	dt.config(""Frontier"", params.ChainConfig{})
+ 
+ 	dt.config(""Homestead"", params.ChainConfig{",if remove `dt.skipLoad` - then this tests will run. You probably mean opposite?,Why are these being removed?
+2098,"@@ -0,0 +1,14 @@
++module Beaker
++  module Shared
++    module Timed
++
++      def run_and_report_duration &block
++        start = Time.now
++        block.call
++        Time.now - start
++      end
++
++    end
++  end
++end
++",I feel like we do this in a lot of places should we move that out into its own PR?,Should this be `Time.now - start`?
+2099,"@@ -12,7 +12,7 @@ import 'css!./style';
+         fillImageElement(elem, source);
+     }
+ 
+-    async function itemBlurhashing(target, blurhashstr) {
++    function itemBlurhashing(target, blurhashstr) {
+         if (blurhash.isBlurhashValid(blurhashstr)) {
+             // Although the default values recommended by Blurhash developers is 32x32, a size of 18x18 seems to be the sweet spot for us,
+             // improving the performance and reducing the memory usage, while retaining almost full blur quality.","Already asked you in Matrix, but I'll do it here again so it can be discussed publicly. Why?",Why did you remove the async here?
+2100,"@@ -239,7 +239,7 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+             ""with statement assignment and exception handler assignment."",
+         ),
+         ""R1705"": (
+-            'Unnecessary ""%s"" after ""return""',
++            'Unnecessary ""%s"" after ""return"" remove it and de-indent all the code inside it',
+             ""no-else-return"",
+             ""Used in order to highlight an unnecessary block of ""
+             ""code following an if containing a return statement. ""","I think here should be a comma before remove, in all the cases",I don't think this is correct. It should be `remove it and indent all the code inside it`.
+2101,"@@ -12,11 +12,16 @@ class OHEMSampler(BaseSampler):
+                  context,
+                  neg_pos_ub=-1,
+                  add_gt_as_proposals=True,
++                 stages=0,
+                  **kwargs):
+         super(OHEMSampler, self).__init__(num, pos_fraction, neg_pos_ub,
+                                           add_gt_as_proposals)
+-        self.bbox_roi_extractor = context.bbox_roi_extractor
+-        self.bbox_head = context.bbox_head
++        if not hasattr(context, ""num_stages""):
++            self.bbox_roi_extractor = context.bbox_roi_extractor
++            self.bbox_head = context.bbox_head
++        else:
++            self.bbox_roi_extractor = context.bbox_roi_extractor[stages]
++            self.bbox_head = context.bbox_head[stages]
+ 
+     def hard_mining(self, inds, num_expected, bboxes, labels, feats):
+         with torch.no_grad():",Single quote is used by default in this project.,Why do we need this?
+2102,"@@ -177,10 +177,8 @@ func (c *Controller) updateSpc(oldSpc, newSpc interface{}) {
+ 		c.recorder.Event(spc, corev1.EventTypeWarning, ""Update"", message)
+ 		return
+ 	}
+-	// Enqueue spc only when there is a pending pool to be created.
+-	if c.isPoolPending(spc) {
+-		c.enqueueSpc(newSpc)
+-	}
++	// Don't reconcile on spc
++	return
+ }
+ 
+ // deleteSpc is the delete event handler for spc.",S1023: redundant `return` statement (from `gosimple`),"I don't think this is the right place to do this. If the pool is not pending, we don't wan"
+2103,"@@ -43,3 +43,6 @@ func (s *webhook) Run(ctx context.Context) error {
+ 
+ func (s *webhook) Notify(event model.Event) {
+ }
++
++func (s *webhook) Close(ctx context.Context) {
++}",`ctx` is unused in Close,Why do we need this?
+2104,"@@ -0,0 +1,9 @@
++<?php
++
++namespace Shopsys\ProductFeed\HeurekaBundle\Model\HeurekaCategory;
++
++use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
++
++class HeurekaCategoryNotFoundException extends NotFoundHttpException
++{
++}","I'm confused. This exception is thrown when `HeurekaCategory` is not found in database. But this exception extends Http exception. Why? What has database search common with http? If the only reason is that it is the same in the whole project, then fine. But then we have even bigger problem - we don't know how to use exceptions.",Missing license header.
+2105,"@@ -0,0 +1,7 @@
++_base_ = './tood_r101_fpn_mstrain_2x_coco.py'
++
++model = dict(
++    backbone=dict(
++        dcn=dict(type='DCNv2', deformable_groups=1, fallback_on_stride=False),
++        stage_with_dcn=(False, True, True, True)),
++    bbox_head=dict(num_dcn_on_head=2))","Is it necessary to add the suffix `on_head`, because it belongs to` bbox_head`?",why do we need this?
+2106,"@@ -548,6 +548,14 @@ AM_COND_IF(BUILDOPT_SYSTEMD_AND_LIBMOUNT,
+   AC_DEFINE([BUILDOPT_LIBSYSTEMD_AND_LIBMOUNT], 1, [Define if systemd and libmount]))
+ if test x$with_libsystemd = xyes; then OSTREE_FEATURES=""$OSTREE_FEATURES systemd""; fi
+ 
++AC_ARG_WITH(modern-grub,
++	    AS_HELP_STRING([--with-modern-grub],
++                           [Omit grub linux and initrd suffixes for EFI/BIOS booting on GRUB >2.02 (default: no)]),,
++              [with_modern_grub=no])
++AS_IF([ test x$with_modern_grub = xyes], [
++  AC_DEFINE([WITH_MODERN_GRUB], 1, [Define if we have a GRUB version newer than 2.02])
++])
++
+ AC_ARG_WITH(builtin-grub2-mkconfig,
+             AS_HELP_STRING([--with-builtin-grub2-mkconfig],
+                            [Use a builtin minimal grub2-mkconfig to generate a GRUB2 configuration file (default: no)]),,","Hmm, I wonder if this should just be e.g. `--with-grub-2.02` instead. (Not sure Autoconf supports periods in these switches.) Today's modern GRUB is tomorrow's ancient GRUB. :) Or maybe we should be specific about the feature this is enabling, which might be safer given that each distro carries so many patches. E.g. `--without-grub-efi-16-suffixes`?",This should be `AC_DEFI
+2107,"@@ -27,13 +27,13 @@ import (
+ // Instance is a compute instance.
+ type Instance struct {
+ 	*api.Instance
+-	client        daisyCompute.Client
++	Client        daisyCompute.Client
+ 	Project, Zone string
+ }
+ 
+ // Cleanup deletes the Instance.
+ func (i *Instance) Cleanup() {
+-	if err := i.client.DeleteInstance(i.Project, i.Zone, i.Name); err != nil {
++	if err := i.Client.DeleteInstance(i.Project, i.Zone, i.Name); err != nil {
+ 		fmt.Printf(""Error deleting instance: %v\n"", err)
+ 	}
+ }","Add a GetSerialPortOutput method to Instance that way you don't need to access the client, also it makes the call cleaner as you don't have the odd i.Client and path.Base(i.Project), path.Base(i.Zone)",I don't think we need t
+2108,"@@ -138,9 +138,11 @@ Workshops::Application.routes.draw do
+   get '/group-training' => ""pages#show"", as: :group_training, id: ""group-training""
+   get '/humans-present/oss' => redirect('https://www.youtube.com/watch?v=VMBhumlUP-A')
+   get '/backbone.js' => redirect('/backbone')
+-  get '/backbone-js-on-rails' => redirect('/products/1-backbone-js-on-rails')
+-  get '/geocoding-on-rails' => redirect('/products/22-geocoding-on-rails')
++  get ""/backbone-js-on-rails"" => redirect(""/products/1-backbone-js-on-rails""), as: :backbone_js_on_rails
++  get ""/geocoding-on-rails"" => redirect(""/products/22-geocoding-on-rails""), as: :geocoding_on_rails
+   get '/geocodingonrails' => redirect('/products/22-geocoding-on-rails')
++  get ""/ios-on-rails"" => redirect(""/products/25-ios-on-rails-beta""), as: :ios_on_rails
++  get ""/ruby-science"" => redirect(""/products/13-ruby-science""), as: :ruby_science
+   get '/gettingstartedwithios' => redirect('/workshops/24-getting-started-with-ios-development?utm_source=podcast')
+   get '/5by5' => redirect('/workshops/19-design-for-developers?utm_source=5by5')
+   get '/rubyist-booster-shot' => ""pages#show"", as: :rubyist_booster_shot, id: ""rubyist-booster-shot""",Line is too long. [104/80],Line is too long. [81/80]
+2109,"@@ -93,6 +93,8 @@ func TestReconcileClusterPool(t *testing.T) {
+ 		expectedMissingDependenciesMessage string
+ 		expectedAssignedClaims             int
+ 		expectedUnassignedClaims           int
++		expectedAssignedCDs                int
++		expectedRunning                    int
+ 		expectedLabels                     map[string]string // Tested on all clusters, so will not work if your test has pre-existing cds in the pool.
+ 		// Map, keyed by claim name, of expected Status.Conditions['Pending'].Reason.
+ 		// (The clusterpool controller always sets this condition's Status to True.)",Since CD updates (assignment & power state) are now done in this controller...,Why do we need this?
+2110,"@@ -13,10 +13,18 @@ const MongooseError = require('./mongooseError');
+  * @api private
+  */
+ 
+-function ParallelValidateError(doc) {
++function ParallelValidateError(doc, opts) {
+   const msg = 'Can\'t validate() the same doc multiple times in parallel. Document: ';
+   MongooseError.call(this, msg + doc._id);
+   this.name = 'ParallelValidateError';
++  if (opts && opts.parentStack) {
++    // Provide a full async stack, most recent first
++    this.stack = this.stack + '\n\n' + opts.parentStack.join('\n\n');
++  }
++  // You need to know to look for this, but having it can be very helpful
++  // for tracking down issues when combined with the deepStackTrace schema
++  // option
++  this.conflictStack = opts && opts.conflictStack;
+ }
+ 
+ /*!",Hmm I'd rather not support this option going forward - it seems like a one-off just to work around this particular issue. Would it be fine to just remove the `deepStackTrace` option? The rest of the PR looks great - I love the idea of switching to sets.,I don't think we need the
+2111,"@@ -0,0 +1,17 @@
++class CommentCreator
++  def initialize(parsed_email)
++    @parsed_email = parsed_email
++  end
++
++  def run
++    Comment.create(
++      comment_text: parsed_email.comment_text,
++      user: parsed_email.comment_user,
++      proposal: parsed_email.proposal
++    )
++  end
++
++  private
++
++  attr_reader :parsed_email
++end","on the one hand I like how little this is doing. On the other hand, `inbound_mail_parser` is doing most of the work here so maybe it's not as helpful as I originally thought",Layout/EmptyLinesAroundCl
+2112,"@@ -238,7 +238,7 @@ TEST_F(BlackBoxPersistence, AsyncRTPSAsReliableWithPersistence)
+ 
+     ASSERT_TRUE(reader.isInitialized());
+ 
+-    writer.make_persistent(db_file_name(), guid_prefix()).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();
++    writer.make_persistent(db_file_name(), guid_prefix()).history_depth(10).asynchronously(eprosima::fastrtps::rtps::RTPSWriterPublishMode::ASYNCHRONOUS_WRITER).init();
+ 
+     ASSERT_TRUE(writer.isInitialized());
+ ",This line is too long,Why did you change this?
+2113,"@@ -54,7 +54,7 @@ func run(ctx context.Context) {
+ 	ticker := time.NewTicker(config.SvcPollInterval())
+ 	for {
+ 		if err := config.SetConfig(); err != nil {
+-			logger.Errorf(err.Error())
++			logger.Fatalf(err.Error())
+ 		}
+ 
+ 		// This sets up the patching system to run in the background.","This isn't a fatal error, we don't want to crash just because we can't set configs, we have sane defaults set",Why is this change neede
+2114,"@@ -93,7 +93,7 @@ func (t *V4Trie) Get(cidr V4CIDR) interface{} {
+ }
+ 
+ func (t *V4Trie) LookupPath(buffer []V4TrieEntry, cidr V4CIDR) []V4TrieEntry {
+-	return t.root.lookupPath(buffer, cidr)
++	return t.root.lookupPath(buffer[:0], cidr)
+ }
+ 
+ // LPM does a longest prefix match on the trie","I wondered why `buffer` was passed into `LookupPath`. What is happening here? Is `buffer[:0]` equivalent to `[]V4TrieEntry{}`, and hence `buffer` isn't needed any more?",why is this change neede
+2115,"@@ -0,0 +1,18 @@
++<table style=""font-size: 15px; font-style: italic; margin: 15px; background-color: #eee; width: 520px"">
++  <tr>
++    <td style=""width: 50px; vertical-align: top; padding: 15px"">
++      <%= link_to(
++          image_tag(
++            attachments[""avatar.png""].url,
++            alt: @user_message_author,
++            title: @user_message_author
++          ),
++          user_url(@user_message_author, :host => SERVER_URL),
++          :target => ""_blank""
++      ) %>
++    </td>
++    <td style=""text-align: left; vertical-align: top; padding-right: 10px"">
++      <%= captured %>
++    </td>
++  </tr>
++</table>","I don't really like the name of this file, especially the encoding of an implementation detail (the fact that it's a table) in the name. Can we just use `_message_body.html.erb` instead maybe?",I think this should be `
+2116,"@@ -220,6 +220,9 @@ type NetworkPolicyRule struct {
+ 	// action “nil” defaults to Allow action, which would be the case for rules created for
+ 	// K8s Network Policy.
+ 	Action *secv1alpha1.RuleAction `json:""action,omitempty"" protobuf:""bytes,6,opt,name=action,casttype=github.com/vmware-tanzu/antrea/pkg/apis/security/v1alpha1.RuleAction""`
++	// EnableLogging is used to indicate if agent should generate logs
++	// when rules are matched. Should be default to false.
++	EnableLogging bool `json:""enableLogging"" protobuf:""varint,7,opt,name=enableLogging""`
+ }
+ 
+ // Protocol defines network protocols supported for things like container ports.","Feel better not to expose our internal implementation in API/CRD, so no need to mention agent here. Consider: EnableLogging indicates whether or not to generate logs when rules are matched. Default to false.",I don't think we need to add a new field for this.
+2117,"@@ -124,6 +124,16 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+     status = rocksdb::DB::Open(options, path, &db);
+   }
+   CHECK(status.ok()) << status.ToString();
++  if (!readonly && spaceId_ != 0 /* only for storage*/) {
++    rocksdb::ReadOptions readOptions;
++    std::string dataVersionValue = """";
++    status = db->Get(readOptions, NebulaKeyUtils::dataVersionKey(), &dataVersionValue);
++    if (status.IsNotFound()) {
++      rocksdb::WriteOptions writeOptions;
++      status = db->Put(writeOptions, NebulaKeyUtils::dataVersionKey(), ""3.0"");
++    }
++    CHECK(status.ok()) << status.ToString();
++  }
+   db_.reset(db);
+   extractorLen_ = sizeof(PartitionID) + vIdLen;
+   partsNum_ = allParts().size();",use `NebulaKeyUtilsV3::dataVersionValue()` to replace the literal value?,nit: `dataVersionValue` -> `dataVersion`
+2118,"@@ -372,10 +372,15 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
+         path = None
+ 
+     if check_exists:
+-        if path is not None and os.path.exists(path):
+-            log.url.debug(""URL is a local file"")
+-        else:
+-            path = None
++        if path is not None:
++            try:
++                if os.path.exists(path):
++                    log.url.debug(""URL is a local file"")
++            except UnicodeEncodeError:
++                log.url.debug(
++                    ""URL contains characters which are not present in the "" \
++                    ""current locale"")
++                path = None
+ 
+     return path
+ ","No need for the `\` here, inside parentheses whitespace is ignored by Python.",I think this should be `log.error`
+2119,"@@ -171,6 +171,10 @@ eqp31wM9il1n+guTNyxJd+FzVAH+hCZE5K+tCgVDdVFUlDEHHbS/wqb2PSIoouLV
+ 			input:  ""{http.request.tls.client.san.ips.0}"",
+ 			expect: ""127.0.0.1"",
+ 		},
++		{
++			input:  ""{http.request.tls.client.certificate_pem}"",
++			expect: ""<empty>"",
++		},
+ 	} {
+ 		actual := repl.ReplaceAll(tc.input, ""<empty>"")
+ 		if actual != tc.expect {",This doesn't seem like the right expected result... it should be the same as the `clientCert` var defined above.,Why is this an empty string?
+2120,"@@ -391,8 +391,6 @@ static void wlr_surface_flush_damage(struct wlr_surface *surface,
+ release:
+ 	pixman_region32_clear(&surface->current->surface_damage);
+ 	pixman_region32_clear(&surface->current->buffer_damage);
+-
+-	wlr_surface_state_release_buffer(surface->current);
+ }
+ 
+ static void wlr_surface_commit_pending(struct wlr_surface *surface) {",need to rename this now.,Why was this removed?
+2121,"@@ -42,7 +42,16 @@ public class ExpectValidPrivateTransactionReceipt implements PrivateCondition {
+         node.execute(transactions.getPrivateTransactionReceipt(transactionHash));
+     assertThat(actualReceipt)
+         .usingRecursiveComparison()
+-        .ignoringFields(""commitmentHash"", ""logs"")
++        .ignoringFields(
++            ""commitmentHash"",
++            ""logs"",
++            ""blockHash"",
++            ""blockNumber"",
++            ""logsBloom"",
++            ""transactionIndex"") // TODO: The fields blockHash, blockNumber, logsBloom and
++        // transactionIndex have to be ignored as the class
++        // org.web3j.protocol.besu.response.privacy.PrivateTransactionReceipt does not contain these
++        // fields
+         .isEqualTo(expectedReceipt);
+ 
+     assertThat(actualReceipt.getLogs().size()).isEqualTo(expectedReceipt.getLogs().size());",NIT: This shouldn't be a TODO. It is just a note isn't it?,Why is this needed?
+2122,"@@ -1644,6 +1644,8 @@ class CommandDispatcher:
+         """"""
+         try:
+             elem.set_value(text)
++        except webelem.OrphanedError as e:
++            message.warning('Edited element vanished')
+         except webelem.Error as e:
+             raise cmdexc.CommandError(str(e))
+ ","I changed this to an error, that seems more appropriate than a warning here.",I don't think this sh
+2123,"@@ -492,7 +492,7 @@ func (sct *SmartContractTest) run(r *require.Assertions) {
+ 		if receipt.Status == uint64(iotextypes.ReceiptStatus_Success) {
+ 			numLog := 0
+ 			for _, l := range receipt.Logs {
+-				if !action.IsSystemLog(l) {
++				if !l.IsEvmTransfer() {
+ 					numLog++
+ 				}
+ 			}","This change could mute unit test failure, but it is better to update unit tests",Why is this change ne
+2124,"@@ -165,6 +165,8 @@ class NotificationData {
+         activeNotifications.remove(holder);
+ 
+         int notificationId = holder.notificationId;
++        notificationIdsInUse.delete(notificationId);
++
+         if (!additionalNotifications.isEmpty()) {
+             NotificationContent newContent = additionalNotifications.removeFirst();
+             NotificationHolder replacement = createNotificationHolder(notificationId, newContent);",All other places that access `notificationIdsInUse` are in methods with descriptive names. We should do the same here. Maybe `markNotificationIdAsFree()`?,Shouldn't this be in a finally block?
+2125,"@@ -26,17 +26,14 @@ import (
+ 	""sync""
+ 	""time""
+ 
+-	""github.com/ethersphere/bee/pkg/sctx""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ )
+ 
+ var (
+ 	TagUidFunc  = rand.Uint32
+-	ErrNotFound = errors.New(""tag not found"")
++	NotFoundErr = errors.New(""tag not found"")
+ )
+ 
+-type TagsContextKey struct{}
+-
+ // Tags hold tag information indexed by a unique random uint32
+ type Tags struct {
+ 	tags *sync.Map","keep as `ErrNotFound`, it is the same convention as in other packages",Why do we need this type?
+2126,"@@ -10,13 +10,15 @@ var ip = {},
+     extIP = require('external-ip'),
+     plugins = require('../../../plugins/pluginManager.js');
+ 
++
+ /**
+  * Function to get the hostname/ip address/url to access dashboard
+  * @param  {function} callback - callback function that returns the hostname
+  */
+ ip.getHost = function(callback) {
+     // If host is set in config.js use that, otherwise get the external IP from ifconfig.me
+-    var domain = plugins.getConfig(""api"").domain;
++    var domain = plugins.getConfig(""api"").domain,
++        offlineMode = plugins.getConfig(""api"").offline_mode;
+     if (typeof domain !== ""undefined"" && domain !== """") {
+         if (domain.indexOf(""://"") === -1) {
+             domain = ""http://"" + domain;","Same here, we need to call `callback` in else branch",`offlineMode` is not used.
+2127,"@@ -160,7 +160,7 @@ public class CertFailedRefreshNotificationTask implements NotificationTask {
+             }
+ 
+             String expiryTime =  getTimestampAsString(certRecord.getExpiryTime());
+-            String hostName = (certRecord.getHostName() != null) ? certRecord.getHostName() : """";
++            String hostName = certRecord.getHostName();
+             certDetails.append(AthenzUtils.extractPrincipalServiceName(certRecord.getService())).append(';')
+                     .append(certRecord.getProvider()).append(';')
+                     .append(certRecord.getInstanceId()).append(';')",At this point we already check that the record is valid and so it could never be nulll,Why remove the null check?
+2128,"@@ -126,6 +126,7 @@ class UserController < ApplicationController
+          (params[:user][:auth_provider] == current_user.auth_provider &&
+           params[:user][:auth_uid] == current_user.auth_uid)
+         update_user(current_user, params)
++        @title = t ""user.account.title""
+       else
+         session[:new_user_settings] = params
+         redirect_to auth_url(params[:user][:auth_provider], params[:user][:auth_uid])",Would it not be more sensible just to move setting of the title to later in the method rather than duplicating it here?,Use 2 (not 1) spaces for indentation.
+2129,"@@ -130,6 +130,7 @@ void MetaClient::heartBeatThreadFunc() {
+             localLastUpdateTime_ = metadLastUpdateTime_;
+         }
+     }
++    uploadSession();
+ }
+ 
+ bool MetaClient::loadUsersAndRoles() {",why not do it in `reclaimExpiredSessions`? and `pushSessionToCache` can delete,Why is this needed?
+2130,"@@ -0,0 +1,17 @@
++_base_ = './retinanet_regnetx-1.6GF_fpn_mstrain_640-800_3x_coco.py'
++model = dict(
++    pretrained='open-mmlab://regnetx_3.2gf',
++    backbone=dict(
++        _delete_=True,
++        type='RegNet',
++        arch='regnetx_3.2gf',
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++    neck=dict(
++        type='FPN',
++        in_channels=[96, 192, 432, 1008],
++        out_channels=256,
++        num_outs=5))",out_channels/num_outs/type are unnecessary,I don't think we need this.
+2131,"@@ -6,6 +6,17 @@ let null_dict = null_dictionary || {}
+ // eslint-disable-next-line no-undef
+ assert_true(dict.X !== undefined && dict.doSomething !== undefined);  // Testing successful object creation.
+ 
++
++/*
++    It seems that Object.values(dict) is not supported on JSC for non-static fields, it would be interesting to
++    review this in the future.
++    verify_object_fields(Object.values(dict).length)
++ */
++
++// eslint-disable-next-line no-undef
++verify_object_fields(Object.keys(dict).length)
++
++
+ null_dict.hello(true);  // Testing method call from object.
+ null_dict.alo(true); // Testing method call from object <again>.
+ ",You can create an issue for it and put it on the backlog so we don't forget it.,I don't think we need to disable this
+2132,"@@ -21,7 +21,11 @@ func (i *startContainerInterceptor) InterceptResponse(r *http.Response) error {
+ 		return err
+ 	}
+ 
+-	cidrs, ok := i.proxy.weaveCIDRsFromConfig(container.Config)
++	if !validNetworkMode(container.HostConfig) {
++		Debug.Printf(""Ignoring container %s with --net=%s"", container.ID, networkMode(container.HostConfig))
++		return nil
++	}
++	cidrs, ok := i.proxy.weaveCIDRsFromConfig(container.Config, container.HostConfig)
+ 	if !ok {
+ 		Debug.Print(""No Weave CIDR, ignoring"")
+ 		return nil","So now we are checking twice, both here and in `weaveCIDRsFromConfig`. Not great. I suggest changing the `ok` return of `weaveCIDRsFromConfig` to a messsage (or error?) instead, which we can then log.",Shouldn't we return an error here?
+2133,"@@ -436,11 +436,10 @@ def install(session, package, hash=None, version=None, tag=None):
+     if pkghash != hash_contents(response_contents):
+         raise CommandException(""Mismatched hash. Try again."")
+ 
+-    pkgobj = store.create_package(owner, pkg, PackageFormat.HDF5)
++    pkgobj = store.create_package(owner, pkg)
+     try:
+         pkgobj.install(response_contents, response_urls)
+     except PackageException as ex:
+-        pkgobj.clear_contents()
+         raise CommandException(""Failed to install the package: %s"" % ex)
+ 
+ def access_list(session, package):","An alternative to setting format to the default in Package.__init__ would be to set it in create_package. I think we can assume all packages are created by create_package, but not necessarily by build_package.",Why remove this?
+2134,"@@ -34,10 +34,17 @@ type MiningBlock struct {
+ 	RemoteTxs types.TransactionsStream
+ }
+ 
++// In case we are proposing during proof-of-stake and we are supplied with header fields already
++type PresetHeaderFields struct {
++	Timestamp uint64
++	Random    common.Hash
++}
++
+ type MiningState struct {
+ 	MiningConfig    *params.MiningConfig
+ 	PendingResultCh chan *types.Block
+ 	MiningResultCh  chan *types.Block
++	ProposeBlockCh  chan *types.Block
+ 	MiningBlock     *MiningBlock
+ }
+ ",Let's add fee recipient as well.,Why do we need this?
+2135,"@@ -239,6 +239,7 @@ class FileDownloadTarget(_DownloadTarget):
+     def __init__(self, filename):
+         # pylint: disable=super-init-not-called
+         self.filename = filename
++        # pylint: enable=super-init-not-called
+ 
+     def suggested_filename(self):
+         return os.path.basename(self.filename)","No need for those with `super-init-not-called`, as pylint already only turns things off for this function and it's needed for the entire function.",Why is this needed?
+2136,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher,Why do we need this?
+2137,"@@ -55,6 +55,15 @@ class ProposalDecorator < Draper::Decorator
+     ""#{number_approved} of #{total_approvers} approved.""
+   end
+ 
++  def table_waiting_text
++    actionable_step = currently_awaiting_steps.first
++    if actionable_step
++      actionable_step.decorate.waiting_text
++    else
++      I18n.t(""decorators.steps.approval.status.waiting"")
++    end
++  end
++
+   def step_text_for_user(key, user)
+     step = existing_approval_for(user)
+     klass = step.class.name.demodulize.downcase.to_sym",this name seems pretty vague -- thoughts on a more descriptive method name?,Layout/EmptyLinesAro
+2138,"@@ -1,4 +1,4 @@
+-// <copyright file=""MeterFactory.cs"" company=""OpenTelemetry Authors"">
++// <copyright file=""MeterFactory.cs"" company=""OpenTelemetry Authors"">
+ // Copyright The OpenTelemetry Authors
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");",what changed in this line?,Why this change?
+2139,"@@ -43,13 +43,16 @@ import { isZeroReport } from '../../modules/search-console/util/is-zero-report';
+ import sumObjectListValue from '../../util/sum-object-list-value';
+ const { useSelect } = Data;
+ 
++// reportArgs is declared in this higher scope so that it can be used by hasData.
++let reportArgs;
++
+ const AdminBarClicks = ( { className } ) => {
+ 	const url = useSelect( ( select ) => select( CORE_SITE ).getCurrentEntityURL() );
+ 	const { compareStartDate, endDate } = useSelect( ( select ) => select( CORE_USER ).getDateRangeDates( {
+ 		compare: true,
+ 		offsetDays: DATE_RANGE_OFFSET,
+ 	} ) );
+-	const reportArgs = {
++	reportArgs = {
+ 		startDate: compareStartDate,
+ 		endDate,
+ 		dimensions: 'date',","Instead of doing this let's add another function similar to `hasZeroData` for selecting the `reportArgs` since this is all sourced from selected values. Then `hasZeroData` can use this internally, as well as the component itself. Since this function would be internal just for the purpose of avoiding duplication, we don't need to expose it on the component the same way though.",Why do we need this?
+2140,"@@ -38,7 +38,6 @@ class ExceptionListener
+             return $event->getException()->getMessage();
+         }
+ 
+-        /** @var \JavierEguiluz\Bundle\EasyAdminBundle\Exception\BaseException */
+         $exception = $event->getException();
+         $exceptionClassName = basename(str_replace('\\', '/', get_class($exception)));
+ ","This line was useful for auto-completion, I think it should be re-added with specifying the var name (`$exception`) and simplifying the FQCN.",Why did you remove this?
+2141,"@@ -228,10 +228,16 @@ func (p *ReverseProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request, extr
+ 
+ 		outreq.Write(backendConn)
+ 
++		errCh := make(chan error, 1)
+ 		go func() {
+-			io.Copy(backendConn, conn) // write tcp stream to backend.
++			_, err := io.Copy(backendConn, conn) // write tcp stream to backend.
++			errCh <- err
+ 		}()
+-		io.Copy(conn, backendConn) // read tcp stream from backend.
++		go func() {
++			_, err := io.Copy(conn, backendConn) // read tcp stream from backend.
++			errCh <- err
++		}()
++		<-errCh
+ 	} else {
+ 		defer res.Body.Close()
+ 		for _, h := range hopHeaders {",This looks like you're not collecting everything from the error channel.,Why do we need a gorouti
+2142,"@@ -1,10 +1,10 @@
+ class CheckoutMailer < BaseMailer
+   def receipt(checkout)
+-    @checkout = checkout
++    @plan = checkout.plan
+ 
+     mail(
+-      to: @checkout.user_email,
+-      subject: ""Your receipt for #{@checkout.plan_name}""
++      to: checkout.user_email,
++      subject: ""Your receipt for #{@plan.name}""
+     )
+   end
+ end",This currently violates the Law of Demeter. Using `checkout.plan_name` is the quick resolution.,Align the parameters of 
+2143,"@@ -77,7 +77,7 @@ class Image implements EntityFileUploadInterface
+      * @param string $entityName
+      * @param int $entityId
+      * @param string|null $type
+-     * @param string $temporaryFilename
++     * @param string|null $temporaryFilename
+      */
+     public function __construct($entityName, $entityId, $type, $temporaryFilename)
+     {",is there any scenario when `$temporaryFilename` can be null?,This should be reverted.
+2144,"@@ -171,6 +171,7 @@ class FlinkTypeToType extends FlinkTypeVisitor<Type> {
+   }
+ 
+   @Override
++  @SuppressWarnings(""ReferenceEquality"")
+   public Type visit(RowType rowType) {
+     List<Types.NestedField> newFields = Lists.newArrayListWithExpectedSize(rowType.getFieldCount());
+     boolean isRoot = root == rowType;","this is for the `boolean isRoot = root == rowType` check, which seems to be on purpose, but maybe you could double check whether using ref. equality here is still wanted? Same for `SparkTypeToType`",Why is this needed?
+2145,"@@ -260,6 +260,7 @@ static void roots_drag_icon_handle_surface_commit(struct wl_listener *listener,
+ 		void *data) {
+ 	struct roots_drag_icon *icon =
+ 		wl_container_of(listener, icon, surface_commit);
++	roots_drag_icon_update_position(icon);
+ 	roots_drag_icon_damage_whole(icon);
+ }
+ ","No need to damage after `roots_drag_icon_update_position`, this is already done in `roots_drag_icon_update_position`",Why is this needed?
+2146,"@@ -102,11 +102,13 @@ def build_model_from_cfg(config_path, checkpoint_path, cfg_options=None):
+     return model
+ 
+ 
+-def preprocess_example_input(input_config):
++def preprocess_example_input(input_config, device=torch.device('cpu')):
+     """"""Prepare an example input image for ``generate_inputs_and_wrap_model``.
+ 
+     Args:
+         input_config (dict): customized config describing the example input.
++        device (<class 'torch.device'>): device type (CPU or CUDA)
++            for the one_img.
+ 
+     Returns:
+         tuple: (one_img, one_meta), tensor of the example input image and \",Have you tested exporting to ONNX with `device=cuda`?,nit: `device (<clas
+2147,"@@ -78,10 +78,14 @@ func newJobLogOpts(vars jobLogsVars) (*jobLogsOpts, error) {
+ // Validate returns an error if the values provided by flags are invalid.
+ func (o *jobLogsOpts) Validate() error {
+ 	if o.appName != """" {
+-		_, err := o.configStore.GetApplication(o.appName)
+-		if err != nil {
++		if _, err := o.configStore.GetApplication(o.appName); err != nil {
+ 			return err
+ 		}
++		if o.name != """" {
++			if _, err := o.configStore.GetJob(o.appName, o.name); err != nil {
++				return err
++			}
++		}
+ 	}
+ 
+ 	if o.since != 0 && o.humanStartTime != """" {",Do we also need to validate `envName` flag then? `appName` and `envName` are used in `initLogsSvc` which are called by `svc logs` from within `Execute()`,Shouldn't this be `
+2148,"@@ -147,6 +147,19 @@ class Auth extends Controller
+      */
+     public function restore_onSubmit()
+     {
++        // Force Trusted Host verification on password reset link generation
++        // regardless of config to protect against host header poisoning
++        $trustedHosts = Config::get('app.trustedHosts', false);
++        if ($trustedHosts === false) {
++            $url = Config::get('app.url', null);
++            if (!empty($url)) {
++                // Explicitly only allow the APP_URL host and subdomains
++                Request::setTrustedHosts(['^(.+\.)?' . preg_quote(parse_url($url, PHP_URL_HOST)) . '$']);
++                // Trigger the host validation logic
++                Request::getHost();
++            }
++        }
++        
+         $rules = [
+             'login' => 'required|between:2,255'
+         ];","@LukeTowers I think I would prefer that we don't force it, on the basis that: a) some people would be opting to configure their web server to protect against this kind of attack and would disable this feature in October CMS to get a small performance increase. b) it might be a bit misleading to say that `app.trustedHosts` set to `false` disables the feature entirely, just to have it be overridden here regardless.",Shouldn't this be `!empty($trustedHosts)`?
+2149,"@@ -259,7 +259,7 @@ func (c *NetworkPolicyController) triggerParentGroupSync(grp *antreatypes.Group)
+ // triggerCNPUpdates triggers processing of ClusterNetworkPolicies associated with the input ClusterGroup.
+ func (c *NetworkPolicyController) triggerCNPUpdates(cg *crdv1alpha3.ClusterGroup) error {
+ 	// If a ClusterGroup is added/updated, it might have a reference in ClusterNetworkPolicy.
+-	cnps, err := c.cnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)
++	cnps, err := c.acnpInformer.Informer().GetIndexer().ByIndex(ClusterGroupIndex, cg.Name)
+ 	if err != nil {
+ 		klog.Errorf(""Error retrieving ClusterNetworkPolicies corresponding to ClusterGroup %s"", cg.Name)
+ 		return err","i like that you are trying to correct the naming, but its making the PR longer :( i guess in future we can do such changes in separate PRs",Why is this change needed?
+2150,"@@ -257,12 +257,12 @@ describe('text.accessibleTextVirtual', function() {
+ 		axe.testUtils.flatTreeSetup(fixture);
+ 
+ 		var target = axe.utils.querySelectorAll(axe._tree, '#t2label')[0];
+-		// Chrome 72: This is This is a label of
+-		// Firefox 62: This is ARIA Label
+-		// Safari 12.0: This is This is a label of
++		// Chrome 86: This is This is a label of
++		// Firefox 82: This is ARIA Label everything
++		// Safari 14.0: This is This is a label of everything
+ 		assert.equal(
+ 			axe.commons.text.accessibleTextVirtual(target),
+-			'This is This is a label of'
++			'This is This is a label of everything'
+ 		);
+ 	});
+ ",Are we marking what the browser's accessibility tree says or what screen readers with those browsers say?,I don't think we need to change this test.
+2151,"@@ -156,6 +156,10 @@ func (s *stream) Close() error {
+ 	return nil
+ }
+ 
++func (s *stream) FullClose() error {
++	return s.Close()
++}
++
+ type record struct {
+ 	b      []byte
+ 	c      int","This method should behave as intended, to block until it reads an EOF from the other side.",Why do we need this?
+2152,"@@ -1924,7 +1924,7 @@ func GitFsck() {
+ 			repo := bean.(*Repository)
+ 			repoPath := repo.RepoPath()
+ 			if err := git.Fsck(repoPath, setting.Cron.RepoHealthCheck.Timeout, setting.Cron.RepoHealthCheck.Args...); err != nil {
+-				desc := fmt.Sprintf(""Fail to health check repository '%s': %v"", repoPath, err)
++				desc := fmt.Sprintf(""Health check failed on repository '%s': %v"", repoPath, err)
+ 				log.Warn(desc)
+ 				if err = CreateRepositoryNotice(desc); err != nil {
+ 					log.Error(3, ""CreateRepositoryNotice: %v"", err)","I prefer starts with `Failed to xxx`, how about `Failed to perform health check on xxx`?",`Health check failed on repository '%s': %v`
+2153,"@@ -141,9 +141,15 @@ namespace Datadog.Trace
+             if (AzureAppServices.Metadata?.IsRelevant ?? false)
+             {
+                 span.SetTag(Tags.AzureAppServicesSiteName, AzureAppServices.Metadata.SiteName);
++                span.SetTag(Tags.AzureAppServicesSiteKind, AzureAppServices.Metadata.SiteKind);
++                span.SetTag(Tags.AzureAppServicesSiteType, AzureAppServices.Metadata.SiteType);
+                 span.SetTag(Tags.AzureAppServicesResourceGroup, AzureAppServices.Metadata.ResourceGroup);
+                 span.SetTag(Tags.AzureAppServicesSubscriptionId, AzureAppServices.Metadata.SubscriptionId);
+                 span.SetTag(Tags.AzureAppServicesResourceId, AzureAppServices.Metadata.ResourceId);
++                span.SetTag(Tags.AzureAppServicesInstanceId, AzureAppServices.Metadata.InstanceId);
++                span.SetTag(Tags.AzureAppServicesInstanceName, AzureAppServices.Metadata.InstanceName);
++                span.SetTag(Tags.AzureAppServicesOperatingSystem, AzureAppServices.Metadata.OperatingSystem);
++                span.SetTag(Tags.AzureAppServicesRuntime, AzureAppServices.Metadata.Runtime);
+             }
+ 
+             // set the origin tag to the root span of each trace/subtrace","All these calls make me think we should refactor how traces are started and allow ""source tags"" that we initialize a trace with. I'd like to do this in a follow up.",Should this be `AzureAppServices.Metadata.Is
+2154,"@@ -1,6 +1,6 @@
+ // DO NOT EDIT: This file is autogenerated via the builtin command.
+ 
+-package v1_test
++package v1
+ 
+ import (
+ 	ast ""github.com/influxdata/flux/ast""",This file shouldn't be in this PR,Why did you change this?
+2155,"@@ -1881,7 +1881,7 @@ class ArrayAssignmentTest extends TestCase
+                     takesArray($a);',
+                 'error_message' => 'InvalidScalarArgument',
+             ],
+-            'nonEmptyAssignmentToListElementChangeType' => [
++            'SKIPPED-nonEmptyAssignmentToListElementChangeType' => [ // Should be LessSpecificReturnStatement?
+                 '<?php
+                     /**
+                      * @param non-empty-list<string> $arr","This now causes `LessSpecificReturnStatement - src/somefile.php:9:32 - The type 'non-empty-list<5|string>' is more general than the declared return type 'non-empty-list<string>' for takesList`, which seems correct to me. The type `non-empty-list<5|string>` contains the type `non-empty-list<string>`. Thoughts?",I'm not sure if this should be `LessSpecific
+2156,"@@ -123,7 +123,7 @@ public class RestrictedDefaultPrivacyController implements PrivacyController {
+       final String privacyUserId,
+       final Optional<PrivacyGroup> maybePrivacyGroup) {
+     try {
+-      LOG.trace(""Storing private transaction in enclave"");
++      LOG.info(""Storing private transaction in enclave"");
+       final SendResponse sendResponse =
+           sendRequest(privateTransaction, privacyUserId, maybePrivacyGroup);
+       return sendResponse.getKey();",Are you going to change that back?,Why is this change needed?
+2157,"@@ -51,6 +51,16 @@ tune ?= generic
+ cpu ?= $(arch)
+ fpu ?=
+ bits ?= $(shell getconf LONG_BIT)
++staticbuild ?= false
++
++# Set static building if requested
++ifeq (true,$(staticbuild))
++  use += llvm_link_static
++else
++  ifneq (false,$(staticbuild))
++    $(error staticbuild must be true or false)
++  endif
++endif
+ 
+ ifndef verbose
+   SILENT = @","we have a standard format for putting these together elsewhere, it does the filter check first and errors out and then sets based on the value. i think this should be adjusted to do that. there's no logical change, just an approach change.",I don't think you need the
+2158,"@@ -1088,6 +1088,7 @@ function createFunctionsMenu() {
+         {text: 'Power', handler: applyFuncToEachWithInput('pow', 'Please enter a power factor')},
+         {text: 'Square Root', handler: applyFuncToEach('squareRoot')},
+         {text: 'Time-adjusted Derivative', handler: applyFuncToEachWithInput('perSecond', ""Please enter a maximum value if this metric is a wrapping counter (or just leave this blank)"", {allowBlank: true})},
++	{text: 'Delay', handler: applyFuncToEachWithInput('scale', 'Please enter the number of steps to delay')},
+         {text: 'Integral', handler: applyFuncToEach('integral')},
+         {text: 'Percentile Values', handler: applyFuncToEachWithInput('percentileOfSeries', ""Please enter the percentile to use"")},
+         {text: 'Non-negative Derivative', handler: applyFuncToEachWithInput('nonNegativeDerivative', ""Please enter a maximum value if this metric is a wrapping counter (or just leave this blank)"", {allowBlank: true})},",Note this should be `delay` instead of `scale` here. I'll fix this in my branch.,nit: `Please enter the num
+2159,"@@ -87,7 +87,6 @@ class Uppy {
+     this.upload = this.upload.bind(this)
+ 
+     this.emitter = ee()
+-    this.on = this.emitter.on.bind(this.emitter)
+     this.off = this.emitter.off.bind(this.emitter)
+     this.once = this.emitter.once.bind(this.emitter)
+     this.emit = this.emitter.emit.bind(this.emitter)","`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?",Why was this removed?
+2160,"@@ -1,4 +1,11 @@
+ # Copyright (c) OpenMMLab. All rights reserved.
++import random
++
++import torch
++import torch.distributed as dist
++import torch.nn.functional as F
++from mmcv.runner import get_dist_info
++
+ from ..builder import DETECTORS
+ from .single_stage import SingleStageDetector
+ ","Considering the trade-off between training speed and accuracy, multi-scale training is temporarily kept. More elegant implementation will be adopted in the future.",nit: `from ..builder import DETECTORS`
+2161,"@@ -38,6 +38,7 @@ import (
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ttime""
+ 
+ 	""context""
++
+ 	""github.com/cihub/seelog""
+ 	""github.com/pkg/errors""
+ )",Can you move this up along with the other builtin libraries?,import (
+2162,"@@ -633,6 +633,12 @@ class GeneralSettingsPanel(SettingsPanel):
+ 			if globalVars.appArgs.secure:
+ 				item.Disable()
+ 			settingsSizerHelper.addItem(item)
++			# Translators: The label of a checkbox in general settings to toggle allowing of usage stats gathering  
++			item=self.allowUsageStatsCheckBox=wx.CheckBox(self,label=_(""Allow the NVDA project to gather NVDA usage statistics""))
++			item.Value=config.conf[""update""][""allowUsageStats""]
++			if globalVars.appArgs.secure:
++				item.Disable()
++			settingsSizerHelper.addItem(item)
+ 			# Translators: The label of a checkbox in general settings to toggle startup notifications
+ 			# for a pending NVDA update.
+ 			item=self.notifyForPendingUpdateCheckBox=wx.CheckBox(self,label=_(""Notify for &pending update on startup""))",I actually think it makes sense to reposition this checkbox after the notifyForPendingUpdateCheckBox. The current order of check boxes is a bit arbitrary now.,I don't think you need to disable the 
+2163,"@@ -309,6 +309,14 @@ var opts struct {
+ 				Targets []core.BuildLabel `position-arg-name:""targets"" description:""Additional targets to load rules from""`
+ 			} `positional-args:""true""`
+ 		} `command:""rules"" description:""Prints built-in rules to stdout as JSON""`
++		Changes struct {
++			Before          string `short:""b"" long:""before"" description:""Revision to check out for the state before""`
++			After           string `short:""a"" long:""after"" required:""true"" description:""Revision to check out for the state after""`
++			CheckoutCommand string `long:""checkout_command"" default:""git checkout %s"" description:""Command to run to check out the before/after revisions.""`
++			Args            struct {
++				Files cli.StdinStrings `positional-arg-name:""files"" description:""Files to consider changed""`
++			} `positional-args:""true""`
++		} `command:""changes"" description:""Calculates the difference between two different states of the build graph""`
+ 	} `command:""query"" description:""Queries information about the build graph""`
+ }
+ ","Why do we have both `before` and `after`? Naively I would expect this to work as follows: `plz query changed` with no arguments compares the current working directory state to the last commit (i.e. HEAD, i.e. a noop when directly on a git commit). `plz query changed --since [reflike]` compare the current working directory state to the given reflike. So for CI I would expect to run something like `plz query changed --since @{upstream} (or origin/master I guess)`. And on merge I'd either run everything or just `plz query changed --since HEAD^` (given our workflow) - I don't think I'd ever want to do anything else. Either way I think before and after are slightly confusing terms here.",This should be `positional-arg-name`.
+2164,"@@ -381,6 +381,17 @@ class FDst(_Rex):
+         return f.server_conn.address and self.re.search(r)
+ 
+ 
++class FDstIP(_Rex):
++    code = ""ip""
++    help = ""Match destination ip address""
++    is_binary = False
++
++    def __call__(self, f):
++        if not f.server_conn or not f.server_conn.ip_address:
++            return False
++        return f.server_conn.ip_address and self.re.search(f.server_conn.ip_address[0])
++
++
+ class FReplay(_Action):
+     code = ""replay""
+     help = ""Match replayed flows""",Is there a reason why we can't use `~dst`? It feels like that could be good enough.I would like to avoid extending the filter syntax unless there's an urgent need. :),I don't think you need to check the length here.
+2165,"@@ -60,7 +60,7 @@ namespace Nethermind.Core
+         public long GasUsed { get; set; }
+         public long GasLimit { get; set; }
+         public UInt256 Timestamp { get; set; }
+-        public DateTime TimestampDate => DateTimeOffset.FromUnixTimeSeconds((long) Timestamp).DateTime;
++        public DateTime TimestampDate => DateTimeOffset.FromUnixTimeSeconds((long) Timestamp).LocalDateTime;
+         public byte[] ExtraData { get; set; }
+         public Keccak MixHash { get; set; }
+         public ulong Nonce { get; set; }",Why local and not UTC?,Why is this change needed?
+2166,"@@ -172,7 +172,8 @@ ExSqlComp::ReturnStatus ExSqlComp::createServer()
+   //  
+   if (ret == ERROR)
+   {
+-	error(arkcmpErrorServer);
++	if ((!diagArea_->contains(-2013)) && (!diagArea_->contains(-2012))) // avoid generating redundant error
++	  error(arkcmpErrorServer);
+ 	if (getenv(""DEBUG_SERVER""))
+ 	  MessageBox(NULL, ""ExSqlComp:createServer"", ""error "", MB_OK|MB_ICONINFORMATION);
+   }",2012 is a retryable error. Will avoiding rgenerating it here cause a difference in behavior in createServer() ?,Why is this needed?
+2167,"@@ -8,6 +8,7 @@ package factory
+ 
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""sort""
+ 
+ 	""github.com/iotexproject/go-pkgs/hash""",move to line 14 below,"""strings"""
+2168,"@@ -107,7 +107,7 @@ public class Rectangle2D {
+     return eastRelation;
+   }
+ 
+-  /** Checks if the rectangle intersects the provided triangle **/
++  /** Checks if the rectangle crosses the provided triangle **/
+   public boolean intersectsTriangle(int aX, int aY, int bX, int bY, int cX, int cY) {
+     // 1. query contains any triangle points
+     if (queryContainsPoint(aX, aY) || queryContainsPoint(bX, bY) || queryContainsPoint(cX, cY)) {",the method name should match teh docs,"""crosses"" -> ""intersects"""
+2169,"@@ -278,13 +278,16 @@ func getOps(config Config, id TlfID) *folderBranchOps {
+ 		getOpsNoAdd(FolderBranch{id, MasterBranch})
+ }
+ 
++// TODO: Test MDv3.
++
+ // createNewRMD creates a new RMD for the given name. Returns its ID
+ // and handle also.
+ func createNewRMD(t *testing.T, config Config, name string, public bool) (
+ 	TlfID, *TlfHandle, *RootMetadata) {
+ 	id := FakeTlfID(1, public)
+ 	h := parseTlfHandleOrBust(t, config, name, public)
+-	rmd := newRootMetadataOrBust(t, id, h)
++	rmd, err := makeInitialRootMetadata(config.MetadataVersion(), id, h)
++	require.NoError(t, err)
+ 	return id, h, rmd
+ }
+ ",Won't this happen automatically when we flip the default version in the config?,Why is this TODO?
+2170,"@@ -312,7 +312,7 @@ func TestLocalExec(t *testing.T) {
+ 		err = app.Exec(""web"", true, ""pwd"")
+ 		assert.NoError(err)
+ 		out := stdout()
+-		assert.Contains(out, ""/var/www/html/docroot"")
++		assert.Contains(out, ""/var/www/html"")
+ 
+ 		stdout = testcommon.CaptureStdOut()
+ 		switch app.GetType() {",This would also change back to /var/www/html/docroot if we go that way.,Why did this change?
+2171,"@@ -0,0 +1,7 @@
++import { getImplicitRole } from '../commons/aria';
++
++function hasImplicitChromiumRoleMatches(node, virtualNode) {
++  return getImplicitRole(virtualNode) !== null;
++}
++
++export default hasImplicitChromiumRoleMatches;",This still needs to use the new option. We'll need tests for it too.,Nit: `hasImplicitRoleMatc
+2172,"@@ -0,0 +1,16 @@
++#appModules/egui.py
++#A part of NonVisual Desktop Access (NVDA)
++#Copyright (C) 2020 Pavol Kecskemety <pavol.kecskemety@eset.sk>
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++
++import appModuleHandler
++
++class AppModule(appModuleHandler.AppModule):
++
++	def event_NVDAObject_init(self, obj):
++		obj.description = None
++		obj.shouldAllowIAccessibleFocusEvent=True
++
++		if obj.name == obj.value:
++			obj.value = None",We are no longer including file name in the source files.,This file is missing a license header.
+2173,"@@ -4,6 +4,9 @@ class ApplicationController < ActionController::Base
+   # Look for template overrides before rendering
+   before_filter :prepend_view_paths
+ 
++  # Set current user (see set_current_user)
++  before_filter :set_current_user
++
+   include GlobalHelpers
+   include Pundit
+   helper_method GlobalHelpers.instance_methods",no need for this. Devise provides us with `current_user` and `user_signed_in?` helpers.,Extra empty line detected at class bod
+2174,"@@ -169,4 +169,8 @@ public class EthProtocol implements SubProtocol {
+     public static final int V65 = 65;
+     public static final int V66 = 66;
+   }
++
++  public static boolean isEth66Compatible(final Capability capability) {
++    return capability.getName().equals(NAME) && capability.getVersion() >= ETH66.getVersion();
++  }
+ }","Would `Object.equals(capability.getName(), NAME)` would be safer, as you wouldn't have to do null checks?",I think this should be `isEth66Compati
+2175,"@@ -193,6 +193,7 @@ RSpec.describe RSpec::Core::Example, :parent_metadata => 'sample' do
+         expect(RSpec::Matchers).not_to receive(:generated_description)
+         example_group.example { assert 5 == 5 }
+         example_group.run
++        RSpec::Mocks.space.reset_all
+       end
+ 
+       it ""uses the file and line number"" do","Hmm, I wonder if we should revert #1862 instead? BTW, what failure do you get w/o this line?",Why is this needed?
+2176,"@@ -428,6 +428,9 @@ func (cg *configGenerator) convertSlackConfig(ctx context.Context, in monitoring
+ 			return nil, errors.Errorf(""failed to get key %q from secret %q"", in.APIURL.Key, in.APIURL.Name)
+ 		}
+ 		out.APIURL = strings.TrimSpace(url)
++		if _, err := ValidateURL(out.APIURL); err != nil {
++			return nil, errors.Wrapf(err, ""invalid 'apiURL' %s in slack config"", out.APIURL)
++		}
+ 	}
+ 
+ 	var actions []slackAction","since there are several places where we do 1) get secret key ref and 2) validate URL, maybe it's worth having a common method? it could also trim spaces as done here (but not at the other places currently).",I think this should be `errors.Wrapf`
+2177,"@@ -21,11 +21,11 @@ import (
+ 
+ func TestExtendPartialURL(t *testing.T) {
+ 	want := ""projects/foo/zones/bar/disks/baz""
+-	if s := extendPartialURL(""zones/bar/disks/baz"", ""foo""); s != want {
++	if s := normalizeToPartialURL(""zones/bar/disks/baz"", ""foo""); s != want {
+ 		t.Errorf(""got: %q, want: %q"", s, want)
+ 	}
+ 
+-	if s := extendPartialURL(""projects/foo/zones/bar/disks/baz"", ""gaz""); s != want {
++	if s := normalizeToPartialURL(""projects/foo/zones/bar/disks/baz"", ""gaz""); s != want {
+ 		t.Errorf(""got: %q, want %q"", s, want)
+ 	}
+ }",TestNormalize... I would also split them,`normalizeToPartialURL` is unused (fr
+2178,"@@ -49,7 +49,7 @@ def readObjects(obj):
+ 	_startGenerator(readObjectsHelper_generator(obj))
+ 
+ def generateObjectSubtreeSpeech(obj,indexGen):
+-	index=indexGen.next()
++	index=next(indexGen)
+ 	speech.speakObject(obj,reason=controlTypes.REASON_SAYALL,index=index)
+ 	yield obj,index
+ 	child=obj.simpleFirstChild",All changes to this file are going to conflict with #7599. Please revert these as well. They will be addressed during the Python 3 transition.,E225 missing whitespace around operat
+2179,"@@ -89,8 +89,10 @@ func (l *twoRandomChoicesList) Remove(peer peer.StatusPeer, _ peer.Identifier, p
+ }
+ 
+ func (l *twoRandomChoicesList) Choose(_ *transport.Request) peer.StatusPeer {
+-	l.m.RLock()
+-	defer l.m.RUnlock()
++	// Usage of a wite lock because r.random.Intn is not thread safe
++	// see: https://golang.org/pkg/math/rand/
++	l.m.Lock()
++	defer l.m.Unlock()
+ 
+ 	numSubs := len(l.subscribers)
+ 	if numSubs == 0 {","Just thought, using spinlock (busy wait with compare and swap) that generates 2 random numbers inside rlock. We know that collisions are rare and we don't need that ""large"" write lock really but lock namely for ""rand"". Or least use a separate Lock (Mutex), namely for ""rand"" (wrap it into method). Mutex will use some sort of spinlock as well but it may use some linked list to make it more fair.",why not use a RWMutex?
+2180,"@@ -2,6 +2,11 @@
+ # For details: https://github.com/PyCQA/pylint/blob/master/COPYING
+ 
+ import re
++import sys
++
++from astroid.__pkginfo__ import version as astroid_version
++
++from pylint.__pkginfo__ import version as pylint_version
+ 
+ # Allow stopping after the first semicolon/hash encountered,
+ # so that an option can be continued with the reasons",Can we grab it directly from `__pkginfo__` as that is the source of truth for the version?,Why do we need this?
+2181,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+ 
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,import org.springfra
+2182,"@@ -94,7 +94,7 @@ class BazelBuildFileView {
+     goPkg = goPkg.replaceFirst(""cloud\\/"", """");
+ 
+     String goImport = """";
+-    if (isCloud) {
++    if (isCloud || protoPkg.contains(""cloud"")) {
+       goImport = ""cloud.google.com/go/"";
+       goPkg = goPkg.replaceFirst(""v(.+);"", ""apiv$1;"");
+     } else {","This looks weird. `isCloud` should define if it is a cloud or no. Here it does it partially, and it can be overriden by protoPkg value (which also an argument to this function). Please make sure that isCloud completely defines the cloud thing. (i.e. it an be as straightforward as moving `protoPkg.contains(""cloud"")` from here to the place where `assembleGoImportPath` is called.",Why is this needed?
+2183,"@@ -1693,7 +1693,9 @@ Ex_Lob_Error ExLob::readDataToLocalFile(char *fileName,  Int64 offset, Int64 siz
+     // open the targte file for writing 
+     int filePerms = S_IRUSR | S_IWUSR | S_IRGRP | S_IWGRP | S_IROTH | S_IWOTH;
+     int openFlags = O_RDWR ; // O_DIRECT needs mem alignment
+-    if ((LobTgtFileFlags)fileflags == Lob_Append_Or_Error )
++    if (((LobTgtFileFlags)fileflags == Lob_Append_Or_Error ) ||
++	((LobTgtFileFlags)fileflags == Lob_Error_Or_Create ) ||
++	((LobTgtFileFlags)fileflags == Lob_Append_Or_Create))
+       openFlags |= O_APPEND;
+     else
+       openFlags |= O_TRUNC;",Declaring fileflags to be of type LobTgtFileFlags would eliminate the need for all this casting. And would be safer. (Not a show-stopper though.),Shouldn't this be `|
+2184,"@@ -124,7 +124,7 @@ public class DockerOptions {
+       for (int i = 0; i < maxContainerCount; i++) {
+         node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
+       }
+-      LOG.info(String.format(
++      LOG.finest(String.format(
+           ""Mapping %s to docker image %s %d times"",
+           caps,
+           name,",This change prevents a user understanding how their server is configured. Best to leave at `info` level.,Why did you change this to finest?
+2185,"@@ -471,8 +471,10 @@ void TSSLSocket::checkHandshake() {
+       }
+     } while (rc == 2);
+   } else {
+-    // set the SNI hostname
+-    SSL_set_tlsext_host_name(ssl_, getHost().c_str());
++    /* OpenSSL < 0.9.8f does not have SSL_set_tlsext_host_name() */
++    #if defined(SSL_set_tlsext_host_name) // set the SNI hostname
++      SSL_set_tlsext_host_name(ssl_, getHost().c_str());
++    #endif
+     do {
+       rc = SSL_connect(ssl_);
+       if (rc <= 0) {",Typically we would add something to the build system environment to differentiate this; also is there an alternative that can be used with older OpenSSL? Other folks who are committers will need to decide if it is worth supporting an older and likely quite vulnerable (to hacks) OpenSSL library.,Shouldn't this be `< 0.9.8f`?
+2186,"@@ -367,7 +367,7 @@ var (
+ 		},
+ 	}
+ 
+-	readBlockProducersByHeightTests = []struct {
++	readActiveBlockProducersByHeightTests = []struct {
+ 		// Arguments
+ 		protocolID            string
+ 		protocolType          string",`readActiveBlockProducersByHeightTests` is a global variable (from `gochecknoglobals`),Why did you change this?
+2187,"@@ -447,10 +447,10 @@ public class SyncManager {
+         int totalSize = target.getTotalSize();
+         sync.setTotalSize(totalSize);
+         updateSync(sync, SyncState.Status.RUNNING, 0, callback);
+-
++        final String idField = sync.getTarget().getIdFieldName();
+         while (records != null) {
+             // Save to smartstore
+-            saveRecordsToSmartStore(soupName, records, mergeMode);
++            saveRecordsToSmartStore(soupName, records, mergeMode, idField);
+             countSaved += records.length();
+             maxTimeStamp = Math.max(maxTimeStamp, target.getLatestModificationTimeStamp(records));
+ ",Falls back on `Constants.ID` if there's no custom field set.,Why not use `sync.getTarget().getI
+2188,"@@ -509,6 +509,7 @@ public class FileAccessIO<T extends DvObject> extends StorageIO<T> {
+ 
+         try {
+             in = new FileInputStream(getFileSystemPath().toFile());
++            in.skip(this.getOffset());
+         } catch (IOException ex) {
+             // We don't particularly care what the reason why we have
+             // failed to access the file was.","I believe this is what we want to rearrange: this in.skip() should not be happening here, in the open method, but in the setOffset() method itself. Because we want to be able to change that offset after the initial open. The setOffset() method will need to throw an IOException, if it's called while the InputStream is still null; or if the skip() call itself results in an IOException()",Why is this needed?
+2189,"@@ -32,6 +32,11 @@ public class MethodNameDeclaration extends AbstractNameDeclaration {
+         return p.isVarargs();
+     }
+ 
++    public boolean isPrimitiveReturnType() {
++        return getMethodNameDeclaratorNode().getParent().getResultType().getChild(0)
++                .getChild(0) instanceof ASTPrimitiveType;
++    }
++
+     public ASTMethodDeclarator getMethodNameDeclaratorNode() {
+         return (ASTMethodDeclarator) node;
+     }","In case the method is `void`, there won't be any children and `getChild(0)` throws. We'll need to check with `isVoid()` for that case. I'll update this when I merge.",I think this should
+2190,"@@ -83,6 +83,7 @@ func main() {
+ 			tch.NewInbound(channel, tch.ListenAddr("":28941"")),
+ 			http.NewInbound("":24034""),
+ 		},
++		Interceptors: yarpc.Interceptors{requestLogInterceptor{}},
+ 	})
+ 
+ 	handler := handler{items: make(map[string]string)}","If the yarpc.Interceptors wrapper will be added to any user interceptor, why not do it transitively. Can save one step for users. Same apply to filter.",Why do we need this
+2191,"@@ -1011,5 +1011,13 @@ func (e *ETCD) GetMembersClientURLs(ctx context.Context) ([]string, error) {
+ 
+ // RemoveSelf will remove the member if it exists in the cluster
+ func (e *ETCD) RemoveSelf(ctx context.Context) error {
+-	return e.removePeer(ctx, e.name, e.address, true)
++	if err := e.removePeer(ctx, e.name, e.address, true); err != nil {
++		return err
++	}
++
++	// backup the data dir to avoid issues when re-enabling etcd
++	oldDataDir := etcdDBDir(e.config) + ""-old-"" + strconv.Itoa(int(time.Now().Unix()))
++
++	// move the data directory to a temp path
++	return os.Rename(etcdDBDir(e.config), oldDataDir)
+ }",Is there anything we should do in the event we're unable to renaming the directory?,Why do we need this
+2192,"@@ -17,12 +17,17 @@ limitations under the License.
+ package main
+ 
+ import (
+-	""github.com/google/knative-gcp/pkg/broker/ingress""
+ 	""go.uber.org/zap""
++
++	""github.com/google/knative-gcp/pkg/broker/ingress""
+ 	""knative.dev/pkg/logging""
+ 	""knative.dev/pkg/signals""
+ )
+ 
++// main creates and starts an ingress handler using default options.
++// 1. it listens on port 8080
++// 2. it reads ""GOOGLE_CLOUD_PROJECT"" env var for pubsub project.
++// 3. it expects broker configmap mounted at ""/var/run/cloud-run-events/broker/targets""
+ func main() {
+ 	// Since we pass nil, a default config with no error will be returned.
+ 	cfg, _ := logging.NewConfigFromMap(nil)",How is this env var populated? Can this be retrieved from cluster metadata?,nit: `it listens on port 8080`
+2193,"@@ -61,10 +61,11 @@ func (s *Service) reconcileInternetGateways() error {
+ 		EC2Client:   s.scope.EC2,
+ 		BuildParams: s.getGatewayTagParams(*gateway.InternetGatewayId),
+ 	})
+-
+ 	if err != nil {
++		record.Warnf(s.scope.Cluster, ""FailedTagInternetGateway"", ""Failed to tag managed Internet Gateway %q: %v"", gateway.InternetGatewayId, err)
+ 		return errors.Wrapf(err, ""failed to tag internet gateway %q"", *gateway.InternetGatewayId)
+ 	}
++	record.Eventf(s.scope.Cluster, ""SuccessfulTagInternetGateway"", ""Tagged managed Internet Gateway %q"", gateway.InternetGatewayId)
+ 
+ 	return nil
+ }","Should probably skip the success event here, since it could be a noop.",Should this be `FailedTagManag
+2194,"@@ -1840,7 +1840,8 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
+                 chaptercardbuilder.buildChapterCards(item, chapters, {
+                     itemsContainer: scenesContent,
+                     backdropShape: 'overflowBackdrop',
+-                    squareShape: 'overflowSquare'
++                    squareShape: 'overflowSquare',
++                    imageBlurhashes: item.ImageBlurHashes
+                 });
+             });
+         } else {",I added this here because people cards (which depends on cardBuilder) had this added in blurhash. Not sure when this is used though cc @JustAMan,This should be `imageBlurHashe
+2195,"@@ -509,9 +509,6 @@ func DecryptDecode(ctx context.Context, k *secrets.Keeper, post Decode) Decode {
+ }
+ 
+ // DecoderByName returns a *Decoder based on decoderName.
+-// It is intended to be used by VariableURLOpeners in driver packages.
+-var DecoderByName = decoderByName
+-
+ // Supported values include:
+ //   - empty string: Returns the default from the URLOpener.Decoder, or
+ //       BytesDecoder if URLOpener.Decoder is nil (which is true if you're","Let's keep this line in the docstring, to let end users know they shouldn't be using this directly.",Why is this being removed?
+2196,"@@ -39,13 +39,10 @@ func (p *Protocol) validateCreateStake(ctx context.Context, act *action.CreateSt
+ 	if act.Amount().Cmp(p.config.MinStakeAmount) == -1 {
+ 		return errors.Wrap(ErrInvalidAmount, ""stake amount is less than the minimum requirement"")
+ 	}
+-	if act.GasPrice().Sign() < 0 {
+-		return errors.Wrap(action.ErrGasPrice, ""negative value"")
+-	}
+ 	if !p.inMemCandidates.ContainsName(act.Candidate()) {
+ 		return errors.Wrap(ErrInvalidCanName, ""cannot find candidate in candidate center"")
+ 	}
+-	return nil
++	return act.AbstractAction.SelfCheck()
+ }
+ 
+ func (p *Protocol) validateUnstake(ctx context.Context, act *action.Unstake) error {",can do the same for other validateXXX(),Why do we need this check?
+2197,"@@ -512,7 +512,7 @@ ReturnCode_t PublisherImpl::wait_for_acknowledgments(
+ 
+ const DomainParticipant* PublisherImpl::get_participant() const
+ {
+-    return participant_->get_participant();
++    return const_cast<const DomainParticipantImpl*>(participant_)->get_participant();
+ }
+ 
+ const Publisher* PublisherImpl::get_publisher() const",Why is this necessary?,Why is this cast needed?
+2198,"@@ -21,6 +21,7 @@ import os
+ import sys
+ import sphinx
+ from sphinx.errors import VersionRequirementError
++import datetime
+ 
+ curr_path = os.path.dirname(os.path.realpath(__file__))
+ libpath = os.path.join(curr_path, '../python-package/')",Please move this import upper to other similar imports,Why do we need this import
+2199,"@@ -1749,6 +1749,14 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
+                 arch_mcontext_reset_stolen_reg(dcontext, mc);
+             }
+         });
++        IF_AARCHXX({
++            // XXX i#4495: Consider saving stolen reg's application value.
++            set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
++            // XXX: This path is tested by linux.thread-reset and linux.clone-reset.
++            // We just haven't run those on ARM yet.
++            IF_ARM(ASSERT_NOT_TESTED());
++        });
++
+         /* We send all threads, regardless of whether was in DR or not, to
+          * re-interp from translated cxt, to avoid having to handle stale
+          * local state problems if we simply resumed.","Include the key word ""translated"". Otherwise the reader will find this confusing.",I don't think this is the 
+2200,"@@ -263,6 +263,7 @@ public abstract class ElasticsearchStorage extends zipkin2.storage.StorageCompon
+   public abstract int namesLookback();
+ 
+   @Override
++  @Memoized // Memoized to reduce garbage as this is effectively a singleton.
+   public SpanStore spanStore() {
+     ensureIndexTemplates();
+     return new ElasticsearchSpanStore(this);",why. is this called per request? if so this also adds a lock internally. can we not add this at the moment until analyzed as this assumption isnt carried to the several other impls. the only other consumer of this is the http api and that isnt hit often enough for specializations.,I'm not sure if this is the best way to do this. I think it would be better to have the `SpanStore` implement `Serializable` and have the `SpanStore` implement `Serializable`.
+2201,"@@ -106,7 +106,7 @@ function nativeSelectValue(node) {
+   }
+ 
+   const options = querySelectorAll(vNode, 'option');
+-  const selectedOptions = options.filter(option => option.hasAttr('selected'));
++  const selectedOptions = options.filter(option => option.actualNode.selected);
+ 
+   // browser automatically selects the first option
+   if (!selectedOptions.length) {","I believe this means dependent checks can no longer operate on virtual nodes, which is something we've been pushing for lately. We may need to find a different way to solve this issue, as I don't think we want to cause a regression while fixing a bug.",`actualNode` can be `null`
+2202,"@@ -8,13 +8,15 @@ from kinto.core.storage import (
+     DEFAULT_ID_FIELD, DEFAULT_MODIFIED_FIELD, DEFAULT_DELETED_FIELD,
+     MISSING)
+ from kinto.core.storage.postgresql.client import create_from_config
++from kinto.core.storage.postgresql.migrator import Migrator
+ from kinto.core.utils import COMPARISON
+ 
+ 
+ logger = logging.getLogger(__name__)
++HERE = os.path.abspath(os.path.dirname(__file__))
+ 
+ 
+-class Storage(StorageBase):
++class Storage(StorageBase, Migrator):
+     """"""Storage backend using PostgreSQL.
+ 
+     Recommended in production (*requires PostgreSQL 9.4 or higher*).",ditto about use of `abspath`,Shouldn't this be `os.path.dirname(__file__)`?
+2203,"@@ -30,13 +30,13 @@ public class Euler05Test {
+     }
+ 
+     private static long smallestPositiveNumberEvenlyDivisibleByAllNumbersFrom1To(int max) {
+-        final long smallestStepsNeeded = max * (max - 1);
+-        return Stream.gen(smallestStepsNeeded, prev -> prev + smallestStepsNeeded)
+-                .findFirst(val -> isEvenlyDivisibleByAllNumbersFrom1To(max, val))
+-                .get();
++        return Stream.rangeClosed(2, max)
++                .map(PrimeNumbers::factorization)
++                .reduce((m1, m2) -> m1.merged(m2, Math::max))
++                .foldLeft(1L, (xs, x) -> xs * pow(x.key, x.value));
+     }
+ 
+-    private static boolean isEvenlyDivisibleByAllNumbersFrom1To(int max, long val) {
+-        return !Stream.rangeClosed(1, max).exists(d -> val % d != 0);
++    private static long pow(long a, long p) {
++        return Stream.rangeClosed(1, p).fold(1L, (xs, x) -> xs * a);
+     }
+ }",this reduces the runtime by 50 times,"nit: `pow(a, p)` -> `pow(a, p)`"
+2204,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....,Missing license header.
+2205,"@@ -956,10 +956,10 @@ public class TryTest extends AbstractValueTest {
+ 
+     private static <T, X extends Throwable> Try<T> failure(Class<X> exceptionType) {
+         try {
+-            final X exception = exceptionType.newInstance();
++            final X exception = exceptionType.getConstructor().newInstance();
+             return Try.failure(exception);
+-        } catch (InstantiationException | IllegalAccessException x) {
+-            throw new IllegalStateException(""Error instantiating "" + exceptionType);
++        } catch (Throwable e) {
++            throw new IllegalStateException(""Error instantiating "" + exceptionType, e);
+         }
+     }
+ ",direct `newInstance` call is also deprecated now,Why is this change nece
+2206,"@@ -15,14 +15,15 @@ import (
+ 	""syscall""
+ 	""time""
+ 
++	""github.com/vishvananda/netlink""
++	weaveapi ""github.com/weaveworks/weave/api""
++	""github.com/weaveworks/weave/common""
++	""golang.org/x/sys/unix""
+ 	api ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/client-go/informers""
+ 	""k8s.io/client-go/kubernetes""
+ 	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/cache""
+-
+-	weaveapi ""github.com/weaveworks/weave/api""
+-	""github.com/weaveworks/weave/common""
+ )
+ 
+ type nodeInfo struct {","We have a bit of a convention where imports are split into three blocks: first Go standard library, then imports from outside the repo, then imports from inside the repo.",nit: remove empty line
+2207,"@@ -184,7 +184,7 @@ abstract class SnapshotProducer<ThisT> implements SnapshotUpdate<ThisT> {
+   /**
+    * Returns the snapshot summary from the implementation and updates totals.
+    */
+-  private Map<String, String> summary(TableMetadata previous) {
++  protected Map<String, String> summary(TableMetadata previous) {
+     Map<String, String> summary = summary();
+ 
+     if (summary == null) {",Why was this change needed?,Why do we need this cha
+2208,"@@ -53,12 +53,14 @@ def get_if_raw_addr(ifname):
+     try:
+         fd = os.popen(""%s %s"" % (conf.prog.ifconfig, ifname))
+     except OSError, msg:
+-        raise Scapy_Exception(""Failed to execute ifconfig: (%s)"" % msg)
++        warning(""Failed to execute ifconfig: (%s)"" % msg)
++        return ""\0\0\0\0""
+ 
+     # Get IPv4 addresses
+     addresses = [l for l in fd.readlines() if l.find(""netmask"") >= 0]
+     if not addresses:
+-        raise Scapy_Exception(""No IPv4 address found on %s !"" % ifname)
++        warning(""No IPv4 address found on %s !"" % ifname)
++        return ""\0\0\0\0""
+ 
+     # Pack the first address
+     address = addresses[0].split(' ')[1]","can you use this opportunity to remove `.readlines()` useless list creation? (`addresses = [l for l in fd if l.find(""netmask"") >= 0]`)",This should be a `ScapyWarning`.
+2209,"@@ -51,8 +51,8 @@ test_name ""C100554: \
+     message = ""The plan was expected to notify but did not""
+     assert_match(/Notice:/, result.stdout, message)
+     winrm_nodes.each do |node|
+-      message = ""The plan was expceted to mention the host #{node.hostname} with _output""
+-      assert_match(/#{node.hostname}""=>{""_output""=>/, result.stdout, message)
++      message = ""The plan was expected to mention the host #{node.hostname} with _output""
++      assert_match(/#{node.hostname}"",""status"":""success""/, result.stdout, message)
+     end
+ 
+     winrm_nodes.each do |node|",Why does this check differ from `plan_ssh.rb`?,Space missing after comma.<br>Sp
+2210,"@@ -10,8 +10,8 @@ import (
+ 	""encoding/json""
+ 	""strconv""
+ 
++	""github.com/iotexproject/go-fsm""
+ 	""github.com/prometheus/client_golang/prometheus""
+-	""github.com/zjshen14/go-fsm""
+ 	""go.uber.org/zap""
+ 
+ 	""github.com/iotexproject/iotex-core/consensus""",File is not `goimports`-ed (from `goimports`),nit: remove empty line
+2211,"@@ -16,7 +16,6 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+     {
+         public const int MaxPooledWriteReqs = 1024;
+ 
+-        private const int _maxPendingWrites = 3;
+         private const int _maxBytesPreCompleted = 65536;
+         private const int _initialTaskQueues = 64;
+         private const int _maxPooledWriteContexts = 32;","It was @lodejard who initially suggested this pattern. I think that it had something to do about prioritizing future writes even if there was a pending write operation ready to handle the newly requested write. I'm not sure I fully understood the explanation for having up to 3 pending write requests, because only having one queued write at a time still makes sense to me. I'll talk to him about it.",Why was this removed?
+2212,"@@ -34,6 +34,8 @@ int main (int argc, char * const * argv)
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
++		(""debug_clear_online_weight"", ""clear online_weights table"")
++		(""debug_dump_online_weight"", ""dump online_weights table"")
+ 		(""debug_dump_representatives"", ""List representatives and weights"")
+ 		(""debug_account_count"", ""Display the number of accounts"")
+ 		(""debug_mass_activity"", ""Generates fake debug activity"")",We have cli --online_weight_clear in cli.cpp,I think it would be better to call it `debug_clear_online_weights_table`
+2213,"@@ -225,7 +225,9 @@ func HTTPServerAttributesFromHTTPRequest(serverName, route string, request *http
+ 		attrs = append(attrs, HTTPRouteKey.String(route))
+ 	}
+ 	if values, ok := request.Header[""X-Forwarded-For""]; ok && len(values) > 0 {
+-		attrs = append(attrs, HTTPClientIPKey.String(values[0]))
++		if addresses := strings.Split(values[0], "",""); len(addresses) > 0 {
++			attrs = append(attrs, HTTPClientIPKey.String(addresses[0]))
++		}
+ 	}
+ 
+ 	return append(attrs, httpCommonAttributesFromHTTPRequest(request)...)",So the request.Headers is a map of []string. Are you sure that the HTTP library doesn't already do this split for us?,I'm not sure if this is the right way to do this. I think it would be be
+2214,"@@ -93,6 +93,8 @@ public class WebUtils {
+         return ""Killing"";
+       case DISPATCHING:
+         return ""Dispatching"";
++      case EXECUTION_STOPPED:
++        return ""Execution stopped, crashed executor/container"";
+       default:
+     }
+     return ""Unknown"";","How is this message used? Can we remove the ""crashed executor/container"" part which is an implementation detail?",case EXECUTION_KILLED:
+2215,"@@ -247,7 +247,8 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+         .put(GET_LOG, post(""/session/:sessionId/log""))
+         .put(GET_AVAILABLE_LOG_TYPES, get(""/session/:sessionId/log/types""))
+ 
+-        .put(STATUS, get(""/status""));
++        .put(STATUS, get(""/status""))
++        .put(HEAP_SNAPSHOT, get(""/session/:sessionId/chromium/heap_snapshot""));
+ 
+         nameToUrl = builder.build();
+   }","Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?",I think this should be `GET_HEAP_SNAPSHOT`
+2216,"@@ -4,7 +4,13 @@
+   <div class=""text-box"">
+ 
+     <% if @purchaseable.video_available?(@video) %>
+-      <%= render 'watch_video', video: @video, purchase: @purchase %>
++      <div class=""purchase-return-link"">
++        <%=link_to ""Back"", purchase_path(@purchase)%>
++      </div>
++
++      <h3 class=""video-headline"">Watch or Download Video</h3>
++
++      <%= render 'watch_video', video: @video %>
+     <% else %>
+       <p>This video is not yet available. It will be released on <%= @purchaseable.video_available_on(@video).to_s(:simple) %></p>
+     <% end %>",Space after `=`.,This should be `watch_video`
+2217,"@@ -59,6 +59,7 @@ public class EdgeInvocation extends AbstractRestInvocation {
+     this.responseEx = new VertxServerResponseToHttpServletResponse(context.response());
+     this.httpServerFilters = httpServerFilters;
+     requestEx.setAttribute(RestConst.REST_REQUEST, requestEx);
++    setAfterCreateInvocationHandler(invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));
+   }
+ 
+   public void edgeInvoke() {",if just need to do something after createInvocation just override and call super first is enough?,this.context = context;
+2218,"@@ -11,7 +11,7 @@ describe Travis::Build::Script::Scala do
+   end
+ 
+   it_behaves_like 'a build script'
+-  # it_behaves_like 'a jdk build'
++  it_behaves_like 'a jvm build'
+ 
+   it 'sets TRAVIS_SCALA_VERSION' do
+     should set 'TRAVIS_SCALA_VERSION', '2.10.0'","By the way, I fixed `announce` method (missing `super` call to announce JDK version)",Should this be `it_behaves_l
+2219,"@@ -505,9 +505,10 @@ public final class TreeSet<T> implements SortedSet<T>, Serializable {
+         }
+     }
+ 
++    @SuppressWarnings(""unchecked"")
+     @Override
+-    public boolean contains(T element) {
+-        return tree.contains(element);
++    public boolean contains(Object element) {
++        return tree.contains((T) element);
+     }
+ 
+     @Override",I'm not sure about that... This line can produce <code>ClassCastException</code> if <code>Comparator</code> do not check this.,Why is this change needed?
+2220,"@@ -737,7 +737,7 @@ type MDOps interface {
+ 	// which may not yet be reflected in the MD if the TLF hasn't been rekeyed since it
+ 	// entered into a conflicting state.
+ 	GetLatestHandleForTLF(ctx context.Context, id TlfID) (
+-		*BareTlfHandle, error)
++		BareTlfHandle, error)
+ }
+ 
+ // KeyOps fetches server-side key halves from the key server.","There wasn't any special reason for this to return a pointer, right?",Why is this a pointer?
+2221,"@@ -14,15 +14,15 @@ import org.mozilla.vrbrowser.R;
+ import org.mozilla.vrbrowser.ui.views.UIButton;
+ import org.mozilla.vrbrowser.ui.widgets.NotificationManager.Notification.NotificationPosition;
+ 
+-import java.util.HashMap;
+ import java.util.Iterator;
+ import java.util.Map;
++import java.util.concurrent.ConcurrentHashMap;
+ 
+ public class NotificationManager {
+ 
+     private static final int DEFAULT_DURATION = 3000;
+ 
+-    private static HashMap<Integer, NotificationData> mData = new HashMap<>();
++    private static ConcurrentHashMap<Integer, NotificationData> mData = new ConcurrentHashMap<>();
+ 
+     private static class NotificationData {
+ ",Why the need for a `ConcurrentHashMap`?,Why do we need a concu
+2222,"@@ -272,8 +272,13 @@ class Note extends BaseItem {
+ 				let bProp = b[order.by];
+ 				if (typeof aProp === 'string') aProp = aProp.toLowerCase();
+ 				if (typeof bProp === 'string') bProp = bProp.toLowerCase();
+-				if (aProp < bProp) r = +1;
+-				if (aProp > bProp) r = -1;
++
++				if (order.by == 'title' && Setting.value('titleNaturalSort')) {
++					r = this.naturalSortCompare(aProp, bProp, false);
++				} else {
++					if (aProp < bProp) r = +1;
++					if (aProp > bProp) r = -1;
++				}
+ 				if (order.dir == 'ASC') r = -r;
+ 				if (r !== 0) return r;
+ 			}",New code should use strict equality `===`,I don't think this is 
+2223,"@@ -84,6 +84,19 @@ describe ""apply"" do
+         resources = result[0]['result']['report']['resource_statuses']
+         expect(resources).to include('Notify[hello world]')
+       end
++
++      it 'applies the deferred type' do
++        result = run_cli_json(%w[plan run basic::defer] + config_flags)
++        expect(result).not_to include('kind')
++        expect(result[0]['status']).to eq('success')
++        resources = result[0]['result']['report']['resource_statuses']
++
++        local_pid = resources['Notify[local pid]']['events'][0]['desired_value'][/(\d+)/, 1]
++        raise 'local pid was not found' if local_pid.nil?
++        remote_pid = resources['Notify[remote pid]']['events'][0]['desired_value'][/(\d+)/, 1]
++        raise 'remote pid was not found' if remote_pid.nil?
++        expect(local_pid).not_to eq(remote_pid)
++      end
+     end
+   end
+ end",`expect(resources['Notify[local pid]']['events'][0]['desired_value']).to match(/(\d+)/)` seems clearer.,I think this should be
+2224,"@@ -54,7 +54,7 @@ const (
+ // Time out individual tests after 10 seconds.
+ var individualTestTimeout = 10 * time.Second
+ 
+-func kbfsOpsInit(t *testing.T, changeMd bool) (mockCtrl *gomock.Controller,
++func kbfsOpsInit(t *testing.T) (mockCtrl *gomock.Controller,
+ 	config *ConfigMock, ctx context.Context, cancel context.CancelFunc) {
+ 	ctr := NewSafeTestReporter(t)
+ 	mockCtrl = gomock.NewController(ctr)",Removed now-unneeded param.,Why is changeMd no longer needed?
+2225,"@@ -107,6 +107,7 @@ VIEW DATA STRUCTURES
+   go-filecoin show                   - Get human-readable representations of filecoin objects
+ 
+ NETWORK COMMANDS
++  go-filecoin bitswap                - Explore libp2p bitswap
+   go-filecoin bootstrap              - Interact with bootstrap addresses
+   go-filecoin dht                    - Interact with the dht
+   go-filecoin id                     - Show info about the network peers","(NON-blocking, this can be tracked in follow up issue) @anorth @mishmosh is the toplevel getting too crowded? Should we have a `network` grandparent command, or maybe a `stats` command?",I don't think this should be here
+2226,"@@ -85,7 +85,7 @@ storiesOf( 'Analytics Module', module )
+ 				title={ __( 'Top acquisition sources over the last 28 days', 'google-site-kit' ) }
+ 				headerCtaLink=""https://analytics.google.com""
+ 				headerCtaLabel={ __( 'See full stats in Analytics', 'google-site-kit' ) }
+-				footerCtaLabel={ __( 'Analytics', 'google-site-kit' ) }
++				footerCtaLabel={ _x( 'Analytics', 'Service name', 'google-site-kit' ) }
+ 				footerCtaLink=""https://analytics.google.com""
+ 			>
+ 				<div className=""mdc-layout-grid"">",The `_x` function needs to be imported at the top of the file (in addition to `__`),This should be `_x( 'Analytics Se
+2227,"@@ -78,8 +78,9 @@ namespace pwiz.SkylineTestFunctional
+             RunUI(() =>
+             {
+                 propDialog.SetQValueTo(0.003f);
++                propDialog.OkDialog();
+             });
+-            OkDialog(propDialog, propDialog.OkDialog);
++            WaitForClosedForm(propDialog);
+             WaitForCondition(() => (DetectionsGraphController.Settings.QValueCutoff == 0.003f));
+             AssertDataCorrect(pane, 0, 0.003f);
+ ",This is functionally equivalent to the code it replaces.,Why did you change this?
+2228,"@@ -26,6 +26,8 @@ import (
+ type ENI struct {
+ 	// ID is the id of eni
+ 	ID string `json:""ec2Id""`
++	// ENIType is the type of ENI, valid value: ""default"", ""vlan""
++	ENIType string `json:"",omitempty""`
+ 	// IPV4Addresses is the ipv4 address associated with the eni
+ 	IPV4Addresses []*ENIIPV4Address
+ 	// IPV6Addresses is the ipv6 address associated with the eni","can you change the field name here to ""InterfaceAssociationProtocol""? same for the Config struct in agent/ecscni/types.go. i think it's better to keep the field name consistent between agent and acs payload",Why do we need this?
+2229,"@@ -1,5 +1,5 @@
+ /**
+- * core/widgets data store: widget tests.
++ * Widgets data store: widget tests.
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for the other cases.",I think this should 
+2230,"@@ -301,6 +301,19 @@ public class MetricRegistry implements MetricSet {
+         });
+     }
+ 
++    /**
++     * Return the {@link Gauge} registered under this name; or create and register
++     * a new {@link SettableGauge} if none is registered.
++     *
++     * @param name the name of the metric
++     * @return a new or pre-existing {@link SettableGauge}
++     * @since 4.2
++     */
++    @SuppressWarnings(""unchecked"")
++    public <T> SettableGauge<T> gauge(String name) {
++        return getOrAdd(name, MetricBuilder.GAUGES);
++    }
++
+     /**
+      * Return the {@link Gauge} registered under this name; or create and register
+      * a new {@link Gauge} using the provided MetricSupplier if none is registered.","Shouldn't line 313 be public \<T\> SettableGauge\<T\> **settable**Gauge(String name) { ? It would also be good to call it a few times and with differnet types (Long, Integer, String) in the test as well.",Shouldn't this be `G
+2231,"@@ -287,7 +287,7 @@ def _has_bare_super_call(fundef_node):
+     return False
+ 
+ 
+-def _safe_infer_call_result(node, caller, context=None):
++def _safe_infer_call_result(node, caller, context=None): # pylint: disable=inconsistent-return-statements
+     """"""
+     Safely infer the return value of a function.
+ ",I would prefer to just fix the occurences of this new check rather than disable them,Why are we disabling
+2232,"@@ -117,9 +117,9 @@ public class UITestUtils {
+     public void addHostedFeedData() throws IOException {
+         if (feedDataHosted) throw new IllegalStateException(""addHostedFeedData was called twice on the same instance"");
+         for (int i = 0; i < NUM_FEEDS; i++) {
+-            Feed feed = new Feed(0, null, ""Title "" + i, ""http://example.com/"" + i, ""Description of feed "" + i,
++            Feed feed = new Feed(0, null, ""Title "" + i, ""https://news.google.com/news/rss?"" + i, ""Description of feed "" + i,
+                     ""http://example.com/pay/feed"" + i, ""author "" + i, ""en"", Feed.TYPE_RSS2, ""feed"" + i, null, null,
+-                    ""http://example.com/feed/src/"" + i, false);
++                    ""https://news.google.com/news/rss?"" + i, false);
+ 
+             // create items
+             List<FeedItem> items = new ArrayList<>();","The tests should be fixed in #4841, so this is no longer needed",Shouldn't this be https?
+2233,"@@ -0,0 +1,17 @@
++<?php
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Core\Infrastructure\Exception;
++
++class SerializationException extends SerializerException
++{
++    public function __construct(string $message, \Throwable $previous = null)
++    {
++        parent::__construct($message, $previous);
++    }
++}",I think it should been in `SharedKernel` module.,Missing license header.
+2234,"@@ -317,6 +317,9 @@ type ACMEChallengeSolverHTTP01IngressTemplate struct {
+ 	// will override the in-built values.
+ 	// +optional
+ 	ACMEChallengeSolverHTTP01IngressObjectMeta `json:""metadata""`
++
++	// OverrideNginxIngressWhitelistAnnotation add description here
++	OverrideNginxIngressWhitelistAnnotation string `json:""overrideNginxIngressWhitelistAnnotation,omitempty""`
+ }
+ 
+ type ACMEChallengeSolverHTTP01IngressObjectMeta struct {",Can we add some description for this field?  ,I don't think we need th
+2235,"@@ -45,6 +45,7 @@ public class ProtoConverter extends Visitor<Expr, Object> {
+           .put(TimestampType.class, ""Time"")
+           .put(BytesType.class, ""String"")
+           .put(StringType.class, ""String"")
++          .put(TimeType.class, ""Duration"")
+           .build();
+ 
+   private final IdentityHashMap<Expression, DataType> typeMap;",Should its name be Time or Duration? I can see them both.,".put(DurationType.class,"
+2236,"@@ -31,6 +31,14 @@ type Option interface {
+ 	applyGRPCOption(*otlpconfig.Config)
+ }
+ 
++func asGRPCOptions(opts []Option) []otlpconfig.GRPCOption {
++	converted := make([]otlpconfig.GRPCOption, len(opts))
++	for i, o := range opts {
++		converted[i] = otlpconfig.NewGRPCOption(o.applyGRPCOption)
++	}
++	return converted
++}
++
+ // RetryConfig defines configuration for retrying batches in case of export
+ // failure using an exponential backoff.
+ type RetryConfig retry.Config",Is this used anywhere?,nit: `converted` -> `convertedOptions`
+2237,"@@ -205,6 +205,17 @@ func TestMerge(t *testing.T) {
+ 	}
+ }
+ 
++func TestEmpty(t *testing.T) {
++	var res *resource.Resource
++	require.Equal(t, """", res.SchemaURL())
++	require.Equal(t, """", res.String())
++	require.Equal(t, []attribute.KeyValue(nil), res.Attributes())
++
++	it := res.Iter()
++	require.Equal(t, 0, it.Len())
++	require.True(t, res.Equal(res))
++}
++
+ func TestDefault(t *testing.T) {
+ 	res := resource.Default()
+ 	require.False(t, res.Equal(resource.Empty()))",I believe that you can use `assert` instead of `require` here and in the following lines,Why is this needed? Isn't `nil` the de
+2238,"@@ -177,7 +177,7 @@ func (pb *Actor) CreateChannel(vmctx exec.VMContext, target address.Address, eol
+ 
+ 	err := withPayerChannels(ctx, storage, payerAddress, func(byChannelID exec.Lookup) error {
+ 		// check to see if payment channel is duplicate
+-		_, err := byChannelID.Find(ctx, channelID.KeyString())
++		err := byChannelID.Find(ctx, channelID.KeyString(), &PaymentChannel{})
+ 		if err != hamt.ErrNotFound { // we expect to not find the payment channel
+ 			if err == nil {
+ 				return Errors[ErrDuplicateChannel]",In `storagemarket.go` you used `nil` for an unwanted out parameter. Do something consistent (nil seems fine if supported).,Why is this needed?
+2239,"@@ -0,0 +1,8 @@
++package trojan
++
++var (
++	Contains    = contains
++	HashBytes   = hashBytes
++	PadBytes    = padBytesLeft
++	IsPotential = isPotential
++)",is this a new pattern we use in bee? interesting,Why do we need this file?
+2240,"@@ -382,7 +382,13 @@ func (f *FsS3) Mkdir() error {
+ 	if err, ok := err.(*s3.Error); ok {
+ 		if err.Code == ""BucketAlreadyOwnedByYou"" {
+ 			return nil
++		} else if err.Code == ""BucketAlreadyExists"" {
++			// Unfortunately Qstack are not reliably returning
++			// BucketAlreadyOwnedByYou, but instead BucketAlreadyExists.
++			// Carry on and wait for potential failure later.
++			return nil
+ 		}
++
+ 	}
+ 	return err
+ }","If you think this PR works, i'll clean this up before resubmitting.","I'm not sure if this is the best way to handle this, but I'm not sure if there's a better way."
+2241,"@@ -148,6 +148,10 @@ public final class Const {
+   public static final String PATH_CHECKSESSION = ""checksession"";
+ 
+   public static final String URL_PREFIX = ""urlPrefix"";
+-  
++
+   public static final String INSTANCE_PUBKEY_PRO = ""publickey"";
++
++  public static final String GROUPID = ""io.servicecomb"";
++
++  public static final String ARTIFACTID = ""java-chassis"";
+ }",are you sure you can read version by this artifactid?,Why do we need this?
+2242,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ 
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+ 
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.,Why did you remove the static imports?
+2243,"@@ -388,10 +388,13 @@ func (c *client) parse(buf []byte) error {
+ 					arg = buf[c.as : i-c.drop]
+ 				}
+ 				var err error
+-				if c.typ == CLIENT {
++				switch c.typ {
++				case CLIENT:
+ 					err = c.processSub(arg)
+-				} else {
++				case ROUTER:
+ 					err = c.processRemoteSub(arg)
++				case GATEWAY:
++					err = c.processGatewaySubjectSub(arg)
+ 				}
+ 				if err != nil {
+ 					return err",Should we do our own vtable?,I'm not sure if this is the right way to handle this. I think it should be `if c.typ == CLIENT
+2244,"@@ -41,7 +41,6 @@ module C2
+     }
+     config.roadie.url_options = config.action_mailer.default_url_options
+ 
+-    config.exceptions_app = self.routes
+     config.autoload_paths << Rails.root.join('lib')
+ 
+     config.assets.precompile << 'common/communicarts.css'",This is the actual fix.,Why was this removed?
+2245,"@@ -173,7 +173,7 @@ const (
+ 	// cache idx expiration
+ 	defaultCacheIdxExpiration = 5 * time.Minute
+ 	// default sync interval
+-	defaultSyncInterval = 10 * time.Second
++	defaultSyncInterval = 60 * time.Second
+ 	// coalesceMinimum
+ 	coalesceMinimum = 16 * 1024
+ 	// maxFlushWait is maximum we will wait to gather messages to flush.","If sync has really a negative impact, this is just moving the issue from 10sec to 60sec. Wonder if you should not expose the (auto)sync params so users can decide.",Why this change?
+2246,"@@ -341,11 +341,12 @@ type Decoder interface {
+ 	// (0, false).
+ 	MapLen() (int, bool)
+ 
+-	// If MapLen returned true, the DecodeMap will be called. It should iterate over
+-	// the fields of the value being decoded, invoking the callback on each with the
+-	// field name and a Decoder for the field value. If the callback returns false,
+-	// DecodeMap should return immediately.
+-	DecodeMap(func(string, Decoder) bool)
++	// DecodeMap iterates over the fields of the value being decoded, invoke the
++	// callback on each with field name, a Decoder for the field value, and a bool
++	// to indicate whether or not to use exact match for the field names. It should
++	// be called when MapLen returns true or decoding a struct. If the callback
++	// returns false, DecodeMap should return immediately.
++	DecodeMap(func(string, Decoder, bool) bool)
+ 
+ 	// AsInterface should decode the value into the Go value that best represents it.
+ 	AsInterface() (interface{}, error)",should be called => will be called,nit: `a Decoder for t
+2247,"@@ -133,12 +133,11 @@ func (c *roundCalculator) roundInfo(
+ ) (roundNum uint32, roundStartTime time.Time, err error) {
+ 	lastBlockTime := time.Unix(c.chain.GenesisTimestamp(), 0)
+ 	if height > 1 {
+-		var lastBlock *block.Footer
+-		if lastBlock, err = c.chain.BlockFooterByHeight(height - 1); err != nil {
++		var lastBlock *block.Header
++		if lastBlock, err = c.chain.BlockHeaderByHeight(height - 1); err != nil {
+ 			return
+ 		}
+-		lastBlockCommitTime := lastBlock.CommitTime()
+-		lastBlockTime = lastBlockTime.Add(lastBlockCommitTime.Sub(lastBlockTime) / c.blockInterval * c.blockInterval)
++		lastBlockTime = lastBlockTime.Add(lastBlock.Timestamp().Sub(lastBlockTime) / c.blockInterval * c.blockInterval)
+ 	}
+ 	if !lastBlockTime.Before(now) {
+ 		err = errors.Errorf(","not sure whether we should do this. It may cause problem that delegates upgrade their nodes at different time, that they will have different ""last block time"", some use ""commit time"", some use ""block time"". Potential solution: Only use block time after berling, and then delete it in the next version after berling. Open to discussion.",`lastBlock` can be `n
+2248,"@@ -190,10 +190,12 @@ public class CreateCollectionCmd implements OverseerCollectionMessageHandler.Cmd
+       try {
+         replicaPositions = buildReplicaPositions(ocmh.cloudManager, clusterState, clusterState.getCollection(collectionName), message, shardNames, sessionWrapper);
+       } catch (Assign.AssignmentException e) {
+-        ZkNodeProps deleteMessage = new ZkNodeProps(""name"", collectionName);
+-        new DeleteCollectionCmd(ocmh).call(clusterState, deleteMessage, results);
++        deleteCollection(clusterState, results, collectionName);
+         // unwrap the exception
+         throw new SolrException(ErrorCode.SERVER_ERROR, e.getMessage(), e.getCause());
++      } catch (SolrException e) {
++        deleteCollection(clusterState, results, collectionName);
++        throw e;
+       }
+ 
+       if (replicaPositions.isEmpty()) {",So one question I have is why is the error coming back from `buildReplicaPositions` not an `Assign.AssignmentException`? Is it because it is wrapped in a `SolrException` from the remote node?,Why do we need to delete the collection?
+2249,"@@ -316,13 +316,13 @@ def test_debug_logger_object():
+         assert dt.options.debug.enabled is True
+ 
+         DT = dt.rbind([])
+-        assert ""dt.rbind([]) {"" in logger.msg
++        assert ""datatable.rbind([]) {"" in logger.msg
+         assert re.search(r""} # \d+(?:\.\d+)?(?:[eE][+-]?\d+)? s"", logger.msg)
+         logger.msg = """"
+ 
+         with pytest.raises(TypeError):
+             dt.rbind(4)
+-        assert ""dt.rbind(4) {"" in logger.msg
++        assert ""datatable.rbind(4) {"" in logger.msg
+         assert re.search(r""} # \d+(?:\.\d+)?(?:[eE][+-]?\d+)? s \(failed\)"", logger.msg)
+ 
+ ",`dt` won't work for some reason?,Why did you change this?
+2250,"@@ -96,7 +96,7 @@ def add_db(doctest_namespace):
+     doctest_namespace[""db""] = db_name
+ 
+ 
+-@pytest.fixture(autouse=os.getenv(""KOALAS_USAGE_LOGGER"", None) is not None)
++@pytest.fixture(autouse=os.getenv(""KOALAS_USAGE_LOGGER"", """") != """")
+ def add_caplog(caplog):
+     with caplog.at_level(logging.INFO, logger=""databricks.koalas.usage_logger""):
+         yield","Is this because ""KOALAS_USAGE_LOGGER"" can be `None` ??",Why do we need this change?
+2251,"@@ -0,0 +1,16 @@
++using Nethermind.Int256;
++
++namespace Nethermind.JsonRpc.Modules.Eth
++{
++    public static class GasPriceConfig
++    {
++        public const int NoHeadBlockChangeErrorCode = 7; //Error code used in debug mode when the head block is not changed
++        public const int PercentileOfSortedTxs = 60; //Percentile of sortedTxList indexes to choose as gas price
++        public const int DefaultBlocksLimit = 20; //Limit for how many blocks we check txs in to add to sortedTxList
++        public const int DefaultGasPrice = 1; //Tx price added to sortedTxList for a block that has 0 txs (now adds 1 tx)
++        public const int SoftTxLimit = 40; //If a block adds only 1 tx price, the block is not counted towards BlocksLimit if sortedTxList.Count() + blocksLeftToCheck <= SoftTxLimit (after price is added to sortedTxList) 
++        public const int DefaultBaseFee = 200; //Minimum price a transaction sender has to pay
++        public const int TxLimitFromABlock = 3; //Maximum number of tx we can add to sortedTxList from one block
++        public static readonly UInt256 _maxGasPrice = 500; //Maximum gas price we can return
++    }
++}",I like it but maybe the better name will be EthGasPriceConstants or EthGasPriceEstimatorConstants? but Constants not Config,Shouldn't this be `MaxGasPrice`?
+2252,"@@ -38,7 +38,9 @@ import (
+ func TestNew(t *testing.T) {
+ 	ctx, _ := SetupFakeContext(t)
+ 
+-	c := NewController(ctx, configmap.NewStaticWatcher(
++	ctor := NewConstructor(&dataresidency.StoreSingleton{})
++
++	c := ctor(ctx, configmap.NewStaticWatcher(
+ 		&corev1.ConfigMap{
+ 			ObjectMeta: metav1.ObjectMeta{
+ 				Name:      logging.ConfigMapName(),",I would inline the constructor as well,Why is this needed?
+2253,"@@ -107,10 +107,10 @@ TEST(Scanner, Basic) {
+     };                                                               \
+     GraphScanner lexer;                                              \
+     lexer.setReadBuffer(input);                                      \
+-    nebula::GraphParser::semantic_type dumyyylval;                   \
+-    nebula::GraphParser::location_type dumyyyloc;                    \
++    nebula::GraphParser::semantic_type dummyyylval;                  \
++    nebula::GraphParser::location_type dummyyyloc;                   \
+     try {                                                            \
+-      auto token = lexer.yylex(&dumyyylval, &dumyyyloc);             \
++      auto token = lexer.yylex(&dummyyylval, &dummyyyloc);           \
+       if (token != 0) {                                              \
+         return AssertionFailure() << ""Lexical error should've ""      \
+                                   << ""happened for `"" << STR << ""'""; \",I'm not confident about this...,Why did you change 
+2254,"@@ -34,6 +34,10 @@ import (
+ 	""github.com/jetstack/cert-manager/pkg/util/pki""
+ )
+ 
++var (
++	certificateRequestGvk = v1alpha1.SchemeGroupVersion.WithKind(""CertificateRequest"")
++)
++
+ func (c *Controller) Sync(ctx context.Context, cr *v1alpha1.CertificateRequest) (err error) {
+ 	c.metrics.IncrementSyncCallCount(ControllerName)
+ ",There is also `v1alpha1.CertificateRequestKind` I think?,Why do we need this
+2255,"@@ -49,6 +49,10 @@ func SenderJob(name string, envVars []corev1.EnvVar) *batchv1.Job {
+ 	return baseJob(name, ""sender"", envVars)
+ }
+ 
++func BrokerSenderJob(name string, envVars []corev1.EnvVar) *batchv1.Job {
++	return baseJob(name, ""sender_gcpbroker"", envVars)
++}
++
+ // baseJob will return a base Job that has imageName and envVars set for its PodTemplateSpec.
+ func baseJob(name, imageName string, envVars []corev1.EnvVar) *batchv1.Job {
+ 	return &batchv1.Job{","Can we rename it to make it less confusing? Instead of ""sender-gcpbroker"", maybe name it to ""retryable-sender""",Why do we need this
+2256,"@@ -136,9 +136,8 @@ public class UnboundPredicate<T> extends Predicate<T, UnboundTerm<T>> implements
+     Literal<T> lit = literal().to(boundTerm.type());
+ 
+     if (lit == null) {
+-      throw new ValidationException(String.format(
+-          ""Invalid value for conversion to type %s: %s (%s)"",
+-          boundTerm.type(), literal().value(), literal().value().getClass().getName()));
++      throw new ValidationException(""Invalid value for conversion to type %s: %s (%s)"",
++          boundTerm.type(), literal().value(), literal().value().getClass().getName());
+ 
+     } else if (lit == Literals.aboveMax()) {
+       switch (op()) {","So looking at the definition of the `literal()` function in this class, it seems it's possible for it to return null. I guess it's not a concern as we would get NPE on the above call at line 136 when trying to call `.to` if `literal()` returned `null` before even getting to this part that calls `literal().value()`, but something I thought I'd bring up. Perhaps something we might follow up on in another issue or possibly I just missed the workflow that makes `literal()`'s result non-null by the time this `bindLiteralOperration` is called.",I think we can remove the `String.format` here.
+2257,"@@ -47,6 +47,19 @@ class OPFMetricsTest(unittest.TestCase):
+ < OPFMetricsTest.DELTA)
+ 
+ 
++  def testNRMSE(self):
++    nrmse = getModule(MetricSpec(""nrmse"", None, None,
++{""verbosity"" : OPFMetricsTest.VERBOSITY}))
++    gt = [9, 4, 5, 6]
++    p = [0, 13, 8, 3]
++    for i in xrange(len(gt)):
++      nrmse.addInstance(gt[i], p[i])
++    target = 1.342
++
++    self.assertTrue(abs(nrmse.getMetric()[""value""]-target)\
++< OPFMetricsTest.DELTA)
++
++
+   def testWindowedRMSE(self):
+     wrmse = getModule(MetricSpec(""rmse"", None, None,
+ {""verbosity"": OPFMetricsTest.VERBOSITY, ""window"":3}))",Why did you break the line? It looks like it is under 80 characters without the break and it is inside parens so no need for backslash anyway,nit: use `self.assertEqual` instead of `abs`
+2258,"@@ -90,6 +90,19 @@ try:
+ except ImportError:
+     GRAPHVIZ_INSTALLED = False
+ 
++""""""datatable""""""
++try:
++    from datatable import DataTable
++    DT_INSTALLED = True
++except ImportError:
++    DT_INSTALLED = False
++
++    class DataTable(object):
++        """"""Dummy class for DataTable.""""""
++
++        pass
++
++
+ """"""sklearn""""""
+ try:
+     from sklearn.base import BaseEstimator","@guolinke Don't you mind to rename this variable to `DATATABLE_INSTALLED`, for the consistency with other variables (for example, there are `PANDAS_INSTALLED` but not `PD_INSTALLED`). Also, `DT` is a little bit confusing: sometimes `dt` is used for `datetime`.",why do we need this?
+2259,"@@ -37,7 +37,7 @@ module RSpec
+           profile.slowest_examples.each do |example|
+             @output.puts ""  #{example.full_description}""
+             @output.puts ""    #{bold(Helpers.format_seconds(example.execution_result.run_time))} "" \
+-                         ""#{bold(""seconds"")} #{format_caller(example.location)}""
++                         ""#{bold('seconds')} #{format_caller(example.location)}""
+           end
+         end
+ ",We're fine with double quotes here. Just for future reference.,Prefer single-quoted strings when you don't nee
+2260,"@@ -242,9 +242,5 @@ func (c call) maxAttemptsError(err error) {
+ }
+ 
+ func getErrorName(err error) string {
+-	errCode := yarpcerrors.ErrorCode(err)
+-	if errCode == yarpcerrors.CodeOK {
+-		return ""unknown_internal_yarpc""
+-	}
+-	return errCode.String()
++	return yarpcerrors.ErrorCode(err).String()
+ }","can we keep this around? We should make sure we can distinguish between properly wrapped errors and ""unwrapped"" errors",Why did you remove this?
+2261,"@@ -14265,6 +14265,10 @@ void PIPELINE_STATE::initGraphicsPipeline(ValidationStateTracker *state_data, co
+         }
+     }
+     graphicsPipelineCI.initialize(pCreateInfo, uses_color_attachment, uses_depthstencil_attachment);
++    if (graphicsPipelineCI.pInputAssemblyState) {
++        topology_at_rasterizer = graphicsPipelineCI.pInputAssemblyState->topology;
++    }
++
+     stage_state.resize(pCreateInfo->stageCount);
+     for (uint32_t i = 0; i < pCreateInfo->stageCount; i++) {
+         const VkPipelineShaderStageCreateInfo *pPSSCI = &pCreateInfo->pStages[i];","`RecordPipelineShaderStage()` might change `topology_at_rasterizer `, according to shader code, so we should check `pInputAssemblyState `first.",I think this should be `
+2262,"@@ -1,6 +1,10 @@
+ const path = require(""path"");
++const { CleanWebpackPlugin} = require(""clean-webpack-plugin"");
+ const CopyPlugin = require(""copy-webpack-plugin"");
+ 
++// assets.js
++const Assets = require('./assets');
++
+ module.exports = {
+     context: path.resolve(__dirname, ""src""),
+     entry: ""./bundle.js"",",Should we just inline the assets here? I can't think of an advantage to having them in a separate file.,Why do we need this?
+2263,"@@ -175,13 +175,13 @@ func (t *endpointsChangesTracker) Update(em types.EndpointsMap) map[k8sproxy.Ser
+ 		for spn, endpoints := range change.current {
+ 			em[spn] = endpoints
+ 		}
+-		detectStaleConnections(change.previous, change.current, staleEndpoints)
++		detectStale(change.previous, change.current, staleEndpoints)
+ 	}
+ 	return staleEndpoints
+ }
+ 
+-// detectStaleConnections updates staleEndpoints with detected stale connections.
+-func detectStaleConnections(oldEndpointsMap, newEndpointsMap types.EndpointsMap, staleEndpoints map[k8sproxy.ServicePortName]map[string]k8sproxy.Endpoint) {
++// detectStale updates staleEndpoints with detected stale endpoints.
++func detectStale(oldEndpointsMap, newEndpointsMap types.EndpointsMap, staleEndpoints map[k8sproxy.ServicePortName]map[string]k8sproxy.Endpoint) {
+ 	for svcPortName, epList := range oldEndpointsMap {
+ 		for _, ep := range epList {
+ 			stale := true",detectStaleEndpoints to be more specific?,nit: `detectStale` -> `d
+2264,"@@ -100,6 +100,8 @@ class SpatialPoolerCompatabilityTest(unittest.TestCase):
+                            cppSp.getMinPctOverlapDutyCycles())
+     self.assertAlmostEqual(pySp.getMinPctActiveDutyCycles(),
+                            cppSp.getMinPctActiveDutyCycles())
++#    self.assertEqual(pySp.getRandomSP(),  #FIXME enable when done in C++ too
++#                     cppSP.getRandomSP())
+ 
+     numColumns = pySp.getNumColumns()
+     numInputs = pySp.getNumInputs()","Please create a new issue for addressing this (if there isn't one already), so it doesn't get lost.",Please remove this line.
+2265,"@@ -78,7 +78,7 @@ func NewStorageMiningSubmodule(minerAddr address.Address, ds datastore.Batching,
+ 		PoStGenerator:    postGen,
+ 		minerNode:        minerNode,
+ 		storageMiner:     storageMiner,
+-		heaviestTipSetCh: c.HeaviestTipSetCh,
++		heaviestTipSetCh: make(chan interface{}),
+ 		poster:           poster.NewPoster(minerAddr, m.Outbox, s, c.State, stateViewer, mw),
+ 	}
+ ",Nothing was ever coming out of this channel because its already being consumed. Create a new channel here and feed it in HandleNewHead method.,Why is this change neede
+2266,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (IAM) policy.]
++//snippet-sourcedescription:[GetPolicy.java demonstrates how to get the details for an AWS Identity and Access Management (AWS IAM) policy.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I think this should be `
+2267,"@@ -76,7 +76,7 @@ public class TestEdgeDriver extends RemoteWebDriver implements WebStorage, Locat
+                 .findFirst().orElseThrow(WebDriverException::new);
+ 
+         service = (EdgeDriverService) builder.withVerbose(true).withLogFile(logFile.toFile()).build();
+-        LOG.info(""edgedriver will log to "" + logFile);
++        LOG.fine(""edgedriver will log to "" + logFile);
+         service.start();
+         Runtime.getRuntime().addShutdownHook(new Thread(() -> service.stop()));
+       }",This is deliberately at this level.,Why is this change neede
+2268,"@@ -63,8 +63,10 @@ func stake2Transfer(args []string) error {
+ 
+ 	var payload []byte
+ 	if len(args) == 3 {
+-		payload = make([]byte, 2*len([]byte(args[2])))
+-		hex.Encode(payload, []byte(args[2]))
++		payload, err = hex.DecodeString(args[2])
++		if err != nil {
++			return output.NewError(output.ConvertError, ""failed to decode data"", err)
++		}
+ 	}
+ 
+ 	sender, err := signer()",payload entered on command line is in hex-encoded format should use same processing as in ioctl/cmd/action/actiontransfer.go,I think this should be `output.ConvertError`
+2269,"@@ -37,7 +37,14 @@ class PricingGroupDataFixture extends AbstractReferenceFixture
+ 
+         $pricingGroupData->name = 'Obyčejný zákazník';
+         $domainId = 2;
+-        $this->createPricingGroup($pricingGroupData, $domainId, self::PRICING_GROUP_ORDINARY_DOMAIN_2);
++
++        $alreadyCreatedDemoPricingGroupsByDomain = $this->pricingGroupFacade->getByDomainId($domainId);
++        if (count($alreadyCreatedDemoPricingGroupsByDomain) > 0) {
++            $pricingGroup = reset($alreadyCreatedDemoPricingGroupsByDomain);
++
++            $this->pricingGroupFacade->edit($pricingGroup->getId(), $pricingGroupData);
++            $this->addReference(self::PRICING_GROUP_ORDINARY_DOMAIN_2, $pricingGroup);
++        }
+ 
+         $pricingGroupData->name = 'VIP zákazník';
+         $domainId1 = 2;",should this be kept in the `else` branch?,`$alreadyCreatedDemoPricingGroupsByDomain` -
+2270,"@@ -32,10 +32,11 @@ import (
+ 	""strings""
+ 	""time""
+ 
++	""sync""
++
+ 	""cloud.google.com/go/storage""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/daisy/compute""
+ 	""google.golang.org/api/option""
+-	""sync""
+ )
+ 
+ const defaultTimeout = ""10m""","Why not put this below ""strings""?",nit: remove empty line
+2271,"@@ -33,6 +33,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+         {
+         }
+ 
++        /// <summary>
++        /// For testing purposes.
++        /// </summary>
++        public int UvPipeCount => _dispatchPipes.Count;
++
+         private UvPipeHandle ListenPipe { get; set; }
+ 
+         public async Task StartAsync(",Make it `internal` if it's just for testing.,Why do we need this?
+2272,"@@ -1,4 +1,4 @@
+-# pylint: disable=missing-docstring,pointless-statement,expression-not-assigned,too-few-public-methods,import-error,no-init,wrong-import-position,no-else-return
++# pylint: disable=missing-docstring,pointless-statement,expression-not-assigned,too-few-public-methods,import-error,no-init,wrong-import-position,no-else-return, logical-tautology
+ 
+ # standard types
+ 1 in [1, 2, 3]",What is triggering this message in this file?,"# pylint: enable=missing-docstring,pointless-statement,expression-not-assigned,no-init,wrong-import-position,no-else-return,logical-tautology"
+2273,"@@ -212,7 +212,7 @@ def start_workers(args, actions, context, analyzer_config_map, skp_handler,
+         pool.map_async(check,
+                        analyzed_actions,
+                        1,
+-                       callback=worker_result_handler).get(float('inf'))
++                       callback=worker_result_handler).get()
+ 
+         pool.close()
+     except Exception:",Are you sure this should be removed?,Why this change?
+2274,"@@ -121,8 +121,7 @@ public class DefaultTrustedSocketFactory implements TrustedSocketFactory {
+ 
+ 
+     private Context context;
+-    private ProxySettings proxySettings;
+-
++    private ProxySettings proxySettings = new ProxySettings(false, """", 0);
+ 
+     public DefaultTrustedSocketFactory(Context context, ProxySettings proxySettings) {
+         this.context = context;",What's that good for? The field is initialized in the constructor.,Why is this needed?
+2275,"@@ -484,12 +484,14 @@ class _Connection(object):
+         if not isinstance(self.connection, SSL.Connection):
+             if not getattr(self.wfile, ""closed"", False):
+                 try:
+-                    self.wfile.flush()
+-                    self.wfile.close()
++                    if self.wfile:
++                        self.wfile.flush()
++                        self.wfile.close()
+                 except exceptions.TcpDisconnect:
+                     pass
+ 
+-            self.rfile.close()
++            if self.rfile:
++                self.rfile.close()
+         else:
+             try:
+                 self.connection.shutdown()",This shouldn't be necessary (same below). Do you have a traceback for me?,Shouldn't this be `if self.rfile`?
+2276,"@@ -13,6 +13,8 @@ import (
+ 	""strconv""
+ 	""syscall"" // only for Signal
+ 
++	""github.com/opencontainers/runc/libcontainer/logs""
++
+ 	""github.com/opencontainers/runc/libcontainer/cgroups""
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ 	""github.com/opencontainers/runc/libcontainer/intelrdt""",No newline needed here.,nit: remove empty line
+2277,"@@ -7,11 +7,12 @@ package libkbfs
+ import (
+ 	""errors""
+ 	""fmt""
+-	""io/ioutil""
+ 	""os""
+ 	""path/filepath""
+ 	""sync""
+ 
++	""github.com/keybase/kbfs/ioutil""
++
+ 	""github.com/keybase/client/go/logger""
+ 	""github.com/keybase/kbfs/kbfscodec""
+ 	""github.com/keybase/kbfs/kbfscrypto""",Why a separate block?,Why is this being remo
+2278,"@@ -2531,10 +2531,16 @@ reg_get_size(reg_id_t reg)
+         return OPSZ_SCALABLE;
+     if (reg >= DR_REG_P0 && reg <= DR_REG_P15)
+         return OPSZ_SCALABLE_PRED;
++    if (reg == DR_REG_CNTVCT_EL0)
++        return OPSZ_8;
++    if (reg >= DR_REG_NZCV && reg <= DR_REG_FPSR)
++        return OPSZ_8;
+ #    endif
+     if (reg == DR_REG_TPIDRURW || reg == DR_REG_TPIDRURO)
+         return OPSZ_PTR;
+ #endif
++    LOG(GLOBAL, LOG_ANNOTATIONS, 2, ""reg=%d, %s, last reg=%d\n"", reg,
++        get_register_name(reg), DR_REG_LAST_ENUM);
+     CLIENT_ASSERT(false, ""reg_get_size: invalid register"");
+     return OPSZ_NA;
+ }",Probably better to ask @AssadHashmi or another AArch64 expert for a review rather than me -- @AssadHashmi if you could confirm that these status registers are 64-bit despite having only a few fields?,Shouldn't this be `if 
+2279,"@@ -684,11 +684,10 @@ is_private_key = lambda x: is_xprv(x) or is_private_key_list(x)
+ is_bip32_key = lambda x: is_xprv(x) or is_xpub(x)
+ 
+ 
+-def bip44_derivation(account_id):
+-    if bitcoin.TESTNET:
+-        return ""m/44'/1'/%d'""% int(account_id)
+-    else:
+-        return ""m/44'/0'/%d'""% int(account_id)
++def bip44_derivation(account_id, segwit=False):
++    bip  = 49 if segwit else 44
++    coin = 1 if bitcoin.TESTNET else 0
++    return ""m/%d'/%d'/%d'"" % (bip, coin, int(account_id))
+ 
+ def from_seed(seed, passphrase):
+     t = seed_type(seed)","`purpose` and `coin_type` and `account` would mimic the BIP-0044 wording, but it's up to you.",I don't think you need
+2280,"@@ -129,10 +129,10 @@ namespace pwiz.Skyline.Controls.Graphs
+         public void SetQValueTo(float qValue)
+         {
+             if (qValue == .01f)
+-                rbQValue01.Select();
++                rbQValue01.Checked = true;
+             else
+             {
+-                rbQValueCustom.Select();
++                rbQValueCustom.Checked = true;
+                 txtQValueCustom.Text = qValue.ToString(CultureInfo.CurrentCulture);
+             }
+         }","Is this the critical change? It does seem wrong to use Select() instead of Checked = true. Not sure why that would pass sometimes and not others, though.",Why did you change this?
+2281,"@@ -111,7 +111,14 @@ func (p *VSphereCloudBuilder) addClusterDeploymentPlatform(o *Builder, cd *hivev
+ }
+ 
+ func (p *VSphereCloudBuilder) addMachinePoolPlatform(o *Builder, mp *hivev1.MachinePool) {
+-	mp.Spec.Platform.VSphere = &hivev1vsphere.MachinePool{}
++	mp.Spec.Platform.VSphere = &hivev1vsphere.MachinePool{
++		NumCPUs:           2,
++		NumCoresPerSocket: 1,
++		MemoryMiB:         8192,
++		OSDisk: hivev1vsphere.OSDisk{
++			DiskSizeGB: 120,
++		},
++	}
+ }
+ 
+ func (p *VSphereCloudBuilder) addInstallConfigPlatform(o *Builder, ic *installertypes.InstallConfig) {","Seems a little low, but is this an installer default?",Why do we need this?
+2282,"@@ -10,6 +10,19 @@ from kinto.core import utils
+ logger = structlog.get_logger()
+ 
+ 
++def reset_logger():
++    """"""Hack to work around https://github.com/hynek/structlog/issues/71.
++
++    This clears a magic field in the logger so that it will regenerate
++    the right kind of logger on its next use.
++
++    Do this when you call structlog.configure(). Otherwise, some parts
++    of the logger will be outdated and you may get strange behavior.
++
++    """"""
++    logger._logger = None
++
++
+ def decode_value(value):
+     try:
+         return six.text_type(value)",Maybe we could provide our own `configure` function that includes `logger._logger = None` because I don't see a use case in kinto for using `reset_logger` besides configuring the logger.,I don't think this is th
+2283,"@@ -31,11 +31,8 @@ type Block struct {
+ 	// holders for an epoch.
+ 	Parents SortedCidSet `json:""parents""`
+ 
+-	// ParentWeightNum is the numerator of the aggregate chain weight of the parent set.
+-	ParentWeightNum Uint64 `json:""parentWeightNumerator""`
+-
+-	// ParentWeightDenom is the denominator of the aggregate chain weight of the parent set
+-	ParentWeightDenom Uint64 `json:""parentWeightDenominator""`
++	// ParentWeight is the aggregate chain weight of the parent set.
++	ParentWeight Uint64 `json:""parentWeight""`
+ 
+ 	// Height is the chain height of this block.
+ 	Height Uint64 `json:""height""`",This will cause the same breakage that was caused when we added Proof to Block. Be sure to let people (infra?) know ahead of time,Why did you change this?
+2284,"@@ -464,11 +464,9 @@ func TestNodeCacheGCReal(t *testing.T) {
+ 
+ 	childNode1 = nil
+ 	runtime.GC()
+-	_ = <-finalizerChan
++	<-finalizerChan
+ 
+-	if len(ncs.nodes) != 2 {
+-		t.Errorf(""Expected %d nodes, got %d"", 2, len(ncs.nodes))
+-	}
++	require.Len(t, ncs.nodes, 1)
+ 
+ 	// Make sure childNode2 isn't GCed until after this point.
+ 	func(interface{}) {}(childNode2)",Fixed the test; @strib want to validate that this is okay? Seems to be consistent new GC behavior.,Why did you remove this check?
+2285,"@@ -45,7 +45,7 @@ func TestValidJsonAccount(t *testing.T) {
+         ""domain"": {
+             ""fulldomain"": ""fooldom"",
+             ""password"": ""secret"",
+-            ""subdomain"": ""subdoom"",
++            ""subdomain"": ""subdom"",
+             ""username"": ""usernom""
+         }
+     }`)","Afaict, nothing cares","This should be ""domain"" not ""s"
+2286,"@@ -507,7 +507,9 @@ func decryptMDPrivateData(ctx context.Context, codec kbfscodec.Codec,
+ 		}
+ 	}
+ 
+-	// Re-embed the block changes if it's needed.
++	// Re-embed the block changes if it's needed.  TODO: we don't need
++	// to do this in minimal mode, since there's no node cache
++	// (KBFS-2026).
+ 	err := reembedBlockChanges(
+ 		ctx, codec, bcache, bops, rmdWithKeys.TlfID(),
+ 		&pmd, rmdWithKeys, log)","I must be missing something, but why does not having a node cache imply not neededing to re-embed the block changes, in particular? Isn't it just the fact that we don't do any writes?",Why is this needed?
+2287,"@@ -5,7 +5,7 @@ using System.Linq;
+ 
+ namespace Datadog.Trace.Headers
+ {
+-    internal class NameValueHeadersCollection : IHeadersCollection
++    internal readonly struct NameValueHeadersCollection : IHeadersCollection
+     {
+         private readonly NameValueCollection _headers;
+ ",Are these changes from `class` to `struct` breaking if called from an older version of `Datadog.Trace.ClrProfiler.Managed`?,Why did you change this?
+2288,"@@ -19,9 +19,12 @@ package org.hyperledger.besu.ethereum.api.query;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.Log;
+ import org.hyperledger.besu.ethereum.core.LogTopic;
++import org.hyperledger.besu.ethereum.core.LogsBloomFilter;
+ 
+ import java.util.Arrays;
+ import java.util.List;
++import java.util.Objects;
++import java.util.stream.Collectors;
+ 
+ import com.google.common.collect.Lists;
+ ",These are just aliases now,nit: unused import ?
+2289,"@@ -1,4 +1,4 @@
+-<% content_for :page_title, @video.title %>
++<% content_for :page_title, @video.title.html_safe %>
+ 
+ <% content_for :landing_page_back_link do %>
+   <%= link_to '&larr; All Videos'.html_safe, '/the-weekly-iteration' %>",Does this mean we can remove `raw` from `_head_contents` partial?,I think this should 
+2290,"@@ -113,7 +113,9 @@ class CapacitorSplashScreen {
+     `;
+ 
+     this.mainWindowRef.on('closed', () => {
+-      this.splashWindow.close();
++      if (this.splashWindow && !this.splashWindow.isDestroyed) { 
++        this.splashWindow.close(); 
++      }
+     });
+ 
+     this.splashWindow.loadURL(`data:text/html;charset=UTF-8,${splashHtml}`, {baseURLForDataURL: `file://${rootPath}/splash_assets/`});","`isDestroyed` is a function, not a property. This condition will always return false.",Why do we need to ch
+2291,"@@ -30,6 +30,8 @@ const (
+ 	Version_1_28 DockerVersion = ""1.28""
+ 	Version_1_29 DockerVersion = ""1.29""
+ 	Version_1_30 DockerVersion = ""1.30""
++	Version_1_31 DockerVersion = ""1.31""
++	Version_1_32 DockerVersion = ""1.32""
+ )
+ 
+ // getKnownAPIVersions returns all of the API versions that we know about.",Why are we adding these versions?,I don't think we nee
+2292,"@@ -271,6 +271,8 @@ def process_one_user(user):
+     spotify.update_latest_listened_at(user.user_id, latest_listened_at)
+     spotify.update_last_updated(user.user_id)
+ 
++    current_app.logger.info('imported %d listens for %s' % (len(listens), str(user)))
++
+ 
+ def process_all_spotify_users():
+     """""" Get a batch of users to be processed and import their Spotify plays.","fyi, you can do this by doing `.info(""string %s %s"", formatparam, formatparam2)` instead of doing a string format with `""str"" % (params)` the idea is that it'll only do the string interpolation if logging is enabled for this level, which theoretically is an optimisation, but in this case probably isn't important","This should be `logger.info('imported %d listens for %s', len(listens), str(user))`"
+2293,"@@ -0,0 +1,17 @@
++<%= render ""offerings/meta"", offering: @offering %>
++
++<p>
++  We're adding you to the GitHub repository, and we'll redirect you as soon it's
++  ready. You may receive an email from GitHub asking you to confirm your
++  membership, so make sure to take quick look in your inbox.
++</p>
++
++<% content_for :javascript do %>
++  <script type=""text/javascript"">
++    (function () {
++      setTimeout(function reload() {
++        window.location.reload();
++      }, 5000);
++    })();
++  </script>
++<% end -%>","Would this work, as a one liner? `setTimeout(window.location.reload, 5000);`",I don't think you need the `content_for :javascript do` here.
+2294,"@@ -33,16 +33,16 @@ import (
+ 	""sync""
+ 	""time""
+ 
++	""crypto/tls""
+ 	""github.com/aws/amazon-ecs-agent/agent/config""
++	""github.com/aws/amazon-ecs-agent/agent/utils""
++	""github.com/aws/amazon-ecs-agent/agent/utils/cipher""
+ 	""github.com/aws/amazon-ecs-agent/agent/wsclient/wsconn""
+ 	""github.com/aws/aws-sdk-go/aws/credentials""
+ 	""github.com/aws/aws-sdk-go/private/protocol/json/jsonutil""
+ 	""github.com/cihub/seelog""
+ 	""github.com/gorilla/websocket""
+ 	""github.com/pkg/errors""
+-	""github.com/aws/amazon-ecs-agent/agent/utils/cipher""
+-	""crypto/tls""
+-	""github.com/aws/amazon-ecs-agent/agent/utils""
+ )
+ 
+ const (",Can you move `crypto/tls` into the block at the top with all the other stdlib imports?,nit: remove empty line
+2295,"@@ -403,7 +403,7 @@ for steps in config['predictionSteps']:
+                  params={'errorMetric': 'aae', 'window': 1000, 'steps': steps}))
+   control['metrics'].append(
+       MetricSpec(field=config['predictedField'], metric='multiStep',
+-                 inferenceElement='multiStepBestPredictions',
++                 inferenceElement='anomalyScore',
+                  params={'errorMetric': 'altMAPE', 'window': 1000, 'steps': steps}))
+   control['metrics'].append(
+       MetricSpec(field=config['predictedField'], metric='trivial',",What is the motivation for this change?,Why did you change this?
+2296,"@@ -74,9 +74,15 @@ type Topic interface {
+ // Subscription receives published messages.
+ type Subscription interface {
+ 	// ReceiveBatch should return a batch of messages that have queued up
+-	// for the subscription on the server. If no messages are available
+-	// yet, it must block until there is at least one, or the context is
+-	// done.
++	// for the subscription on the server.
++	//
++	// If there is a transient failure, this method should not retry but
++	// should return a nil slice and an error. The concrete API will take
++	// care of retry logic.
++	//
++	// If the service returns no messages for some other reason, this
++	// method should return the empty slice of messages and not attempt to
++	// retry.
+ 	//
+ 	// ReceiveBatch is only called sequentially for individual
+ 	// Subscriptions.","OK, so the concrete implementation will loop? But then it's important that this method waits for a while before it returns no messages. To be specific, a GCP implementation that set `ReturnImmediately` to true or false would both satisfy this requirement, but the first would cause busy-waiting.","I don't think we should be returning an empty slice here. If the service returns no messages for some other reason, this method should return an empty slice and not attempt to retry."
+2297,"@@ -45,7 +45,10 @@ Status MatchValidator::validateImpl() {
+ 
+         auto matchClauseCtx = getContext<MatchClauseContext>();
+         matchClauseCtx->aliasesUsed = aliasesUsed;
+-        NG_RETURN_IF_ERROR(validatePath(matchClause->path(), *matchClauseCtx));
++        if (matchClause->path()->pathSize() > 1) {
++          return Status::SemanticError(""Multi paths not supported."");
++        }
++        NG_RETURN_IF_ERROR(validatePath(matchClause->path()->path(0) /* TODO */, *matchClauseCtx));
+         if (matchClause->where() != nullptr) {
+           auto whereClauseCtx = getContext<WhereClauseContext>();
+           whereClauseCtx->aliasesUsed = &matchClauseCtx->aliasesGenerated;",The data structure of `MatchClauseContext` may need to be redesigned.,"I think it would be better to use `NG_RETURN_IF_ERROR(validatePath(matchClause->path(), *matchClauseCtx));`"
+2298,"@@ -236,8 +236,13 @@ func testSendReceive(t *testing.T, newHarness HarnessMaker) {
+ 	}
+ 	defer cleanup()
+ 
+-	want := publishN(ctx, t, top, 3)
+-	got := receiveN(ctx, t, sub, len(want))
++	wantChan := make(chan []*pubsub.Message)
++	gotChan := make(chan []*pubsub.Message)
++	n := 3
++	go func() { gotChan <- receiveN(ctx, t, sub, n) }()
++	go func() { wantChan <- publishN(ctx, t, top, n) }()
++	want := <-wantChan
++	got := <-gotChan
+ 
+ 	// Check that the received messages match the sent ones.
+ 	if diff := diffMessageSets(got, want); diff != """" {","You say on the issue that something has to be receiving while the messages are being published. But here it's possible that the publish goroutine starts, and maybe even completes, before Receive is ever called.",Why do we need a goroutine here?
+2299,"@@ -50,7 +50,7 @@ class ProposalsController < ApplicationController
+   end
+ 
+   def approve
+-    approval = proposal.existing_approval_for(current_user)
++    approval = proposal.existing_step_for(current_user)
+     approval.update_attributes!(completer: current_user)
+     approval.approve!
+     flash[:success] = ""You have approved #{proposal.public_id}.""",how do we know that the step in question is an approval type step?,Metrics/LineLength: Line is too long. [82/80]
+2300,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+ 
+ import com.google.common.base.Predicate;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+ 
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.,I don't think this is needed.
+2301,"@@ -0,0 +1,7 @@
++module io.vavr {
++  requires io.vavr.match;
++  exports io.vavr;
++  exports io.vavr.collection;
++  exports io.vavr.control;
++  exports io.vavr.concurrent;
++}","Is this still Java 8 compatible? @danieldietrich do we need a separate, modularized Java 9 release also?",Why is this needed?
+2302,"@@ -293,7 +293,12 @@ hipError_t hipCreateTextureObject(hipTextureObject_t* pTexObject, const hipResou
+         hsa_ext_sampler_descriptor_t samplerDescriptor;
+         fillSamplerDescriptor(samplerDescriptor, pTexDesc->addressMode[0], pTexDesc->filterMode,
+                               pTexDesc->normalizedCoords);
+-
++        if(hipResourceTypeLinear == pResDesc->resType) {
++           samplerDescriptor.filter_mode = HSA_EXT_SAMPLER_FILTER_MODE_NEAREST;
++           samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_BORDER;
++        } else if(!pTexDesc->normalizedCoords) {
++            samplerDescriptor.address_mode = HSA_EXT_SAMPLER_ADDRESSING_MODE_CLAMP_TO_EDGE;
++        }
+         hsa_access_permission_t permission = HSA_ACCESS_PERMISSION_RW;
+         if (HSA_STATUS_SUCCESS != hsa_ext_image_create_with_layout(
+                                       *agent, &imageDescriptor, devPtr, permission,",Should update the user input address and filter modes and pass those in fillSamplerDescriptor ?,Shouldn't this be `if (hipRes
+2303,"@@ -0,0 +1,19 @@
++# frozen_string_literal: true
++
++module Faker
++  class Show < Base
++    class << self
++      def adult_musical
++        fetch('show.adult_musical')
++      end
++
++      def kids_musical
++        fetch('show.kids_musical')
++      end
++
++      def play
++        fetch('show.play')
++      end
++    end
++  end
++end",This object should be in `lib/music/show.rb` and you should also wrap this object in the `Faker::Music::Show`.,I don't think this is needed.
+2304,"@@ -58,6 +58,14 @@ Puppet::Functions.create_function(:run_task) do
+     end || (raise Puppet::ParseError, 'Task parameters did not match')
+     task = task_signature.task
+ 
++    if executor.noop
++      if task.supports_noop
++        use_args['_noop'] = true
++      else
++        raise Puppet::ParseError, 'Task does not support noop'
++      end
++    end
++
+     # Ensure that that given targets are all Target instances
+     targets = [targets] unless targets.is_a?(Array)
+     targets = targets.flatten.map { |t| t.is_a?(String) ? Puppet::Pops::Types::TypeFactory.target.create(t) : t }",I think logic will have to move to bolt since the vague discussions around bolt run plan --noop is that it would just skip any tasks that don't support_noop rather than error. This is fine until we actually elaborate that though.,Should this be `task.supports_noop?`?
+2305,"@@ -11,6 +11,7 @@ import (
+ 
+ 	""github.com/CoderZhi/go-ethereum/common""
+ 	""github.com/CoderZhi/go-ethereum/core/types""
++
+ 	""github.com/iotexproject/iotex-core/address""
+ 	""github.com/iotexproject/iotex-core/logger""
+ 	""github.com/iotexproject/iotex-core/pkg/hash""",File is not `goimports`-ed,"""github.com/hashicorp/go-multierror"""
+2306,"@@ -35,12 +35,15 @@ class CollectionViewTest(BaseWebTest, unittest.TestCase):
+                           headers=self.headers,
+                           status=400)
+ 
+-    def test_unknown_bucket_raises_404(self):
++    def test_unknown_bucket_raises_403(self):
+         other_bucket = self.collections_url.replace('beers', 'sodas')
+-        self.app.get(other_bucket, headers=self.headers, status=404)
++        self.app.get(other_bucket, headers=self.headers, status=403)
+ 
+     def test_collections_are_isolated_by_bucket(self):
+-        other_bucket = self.collection_url.replace('beers', 'water')
++        other_bucket = self.collection_url.replace('beers', 'sodas')
++        self.app.put_json('/buckets/sodas',
++                          MINIMALIST_BUCKET,
++                          headers=self.headers)
+         self.app.get(other_bucket, headers=self.headers, status=404)
+ 
+ ",why should unknown raise a 403?,Why did you change this?
+2307,"@@ -87,11 +87,11 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			c._vnode = newVNode;
+ 
+ 			// Invoke getDerivedStateFromProps
+-			let s = c._nextState || c.state;
++			if (c._nextState==null) {
++				c._nextState = c.state;
++			}
+ 			if (newType.getDerivedStateFromProps!=null) {
+-				oldState = assign({}, c.state);
+-				if (s===c.state) s = c._nextState = assign({}, s);
+-				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
++				assign(c._nextState==c.state ? (c._nextState = assign({}, c._nextState)) : c._nextState, newType.getDerivedStateFromProps(newVNode.props, c._nextState));
+ 			}
+ 
+ 			// Invoke pre-render lifecycle methods","The true clause of your condition, can't this just be c._nextState since `assign({}, c._nextState)` is equal to returning c._nextState, or am I misunderstanding something here?",Nit: space after `==`
+2308,"@@ -36,6 +36,8 @@ flags.DEFINE_string('groups_service_account_key_file', None,
+                     'runnning locally.')
+ flags.DEFINE_integer('max_admin_api_calls_per_day', 150000,
+                      'Admin SDK queries per day.')
++flags.DEFINE_integer('max_results_admin_api', 500,
+++                     'maxResult param for the Admin SDK list() method')
+ 
+ 
+ class AdminDirectoryClient(_base_client.BaseClient):",nit: align the leftmost quotes,I think this should be called `max_results_admin_api`
+2309,"@@ -98,6 +98,11 @@ type AgentConfig struct {
+ 	// APIPort is the port for the antrea-agent APIServer to serve on.
+ 	// Defaults to 10350.
+ 	APIPort int `yaml:""apiPort,omitempty""`
++
++	// ClusterMembershipPort is the server port used by the antrea-agent to run a gossip-based cluster membership protocol. Currently it's used only when the Egress feature is enabled.
++	// Defaults to 10351.
++	ClusterMembershipPort int `yaml:""clusterPort,omitempty""`
++
+ 	// Enable metrics exposure via Prometheus. Initializes Prometheus metrics listener
+ 	// Defaults to true.
+ 	EnablePrometheusMetrics bool `yaml:""enablePrometheusMetrics,omitempty""`","Probably ""server port"" -> ""TCP port""",I'm not sure if this is the right place to put this. 
+2310,"@@ -91,7 +91,11 @@ public class Lucene80Codec extends Codec {
+    *             flushed/merged segments.
+    */
+   public Lucene80Codec(Mode mode) {
+-    super(""Lucene80"");
++    this(""Lucene80"", mode);
++  }
++  
++  protected Lucene80Codec(String name, Mode mode) {
++    super(name);
+     this.storedFieldsFormat = new Lucene50StoredFieldsFormat(Objects.requireNonNull(mode));
+     this.defaultFormat = new Lucene50PostingsFormat();
+   }",can you use FilterCodec instead?,Why do we need this constructor?
+2311,"@@ -407,6 +407,19 @@ class Setting extends BaseModel {
+ 			tagHeaderIsExpanded: { value: true, type: Setting.TYPE_BOOL, public: false, appTypes: ['desktop'] },
+ 			folderHeaderIsExpanded: { value: true, type: Setting.TYPE_BOOL, public: false, appTypes: ['desktop'] },
+ 			editor: { value: '', type: Setting.TYPE_STRING, subType: 'file_path_and_args', public: true, appTypes: ['cli', 'desktop'], label: () => _('Text editor command'), description: () => _('The editor command (may include arguments) that will be used to open a note. If none is provided it will try to auto-detect the default editor.') },
++			'export.pdfPageSize': { value: 'A4', type: Setting.TYPE_STRING, isEnum: true, public: true, appTypes: ['desktop'], label: () => _('Page size for PDF export'), options: () => {
++				return {
++					'A4': _('A4'),
++					'Letter': _('Letter'),
++				};
++			}},
++			'export.pdfPageOrientation': { value: false, type: Setting.TYPE_BOOL, isEnum: true, public: true, appTypes: ['desktop'], label: () => _('Page orientation for PDF export'), options: () => {
++				return {
++					false: _('Portrait'),
++					true: _('Landscape'),
++				};
++			}},
++
+ 
+ 			'net.customCertificates': {
+ 				value: '',","I know there's only two values but I find it a bit confusing that it's true/false. Could you change it to a string enum with values ""portrait"" and ""landscape""? Then when calling printToPdf you can just do `landscape: Setting.value('export.pdfPageOrientation') === 'landscape'`",I think this should be `false` and `true`
+2312,"@@ -12,3 +12,11 @@ var dbSchemaVersion = Migration{
+ 		return CommitProgress(db, nil, true)
+ 	},
+ }
++
++var dbSchemaVersion2 = Migration{
++	Name: ""db_schema_version2"",
++	Up: func(db ethdb.Database, tmpdir string, progress []byte, CommitProgress etl.LoadCommitHandler) (err error) {
++		// This migration is no-op, but it forces the migration mechanism to apply it and thus write the DB schema version info
++		return CommitProgress(db, nil, true)
++	},
++}",I think this migration should fail for MDBX if it uses old table names,I'm not sure if this is the right place to put this migration. I think it would be better to put it in the `db_migrations.go` file.
+2313,"@@ -224,7 +224,7 @@ module Beaker
+       # @raise [ArgumentError] if a hosts file is generated, but it can't
+       #   be read by the HostsFileParser
+       def parse_hosts_options
+-        if File.exists?(@options[:hosts_file])
++        if @options[:hosts_file].nil? || File.exists?(@options[:hosts_file])
+           #read the hosts file that contains the node configuration and hypervisor info
+           return Beaker::Options::HostsFileParser.parse_hosts_file(@options[:hosts_file])
+         end","Should this be negated? `!@options[:hosts_file].nil?` Otherwise it'll enter the `if` statement and `nil` will be passed to `HostsFileParser.parse_hosts_file`, which I'm assuming is bad.",Why do we need this change?
+2314,"@@ -91,6 +91,14 @@ namespace NLog
+         /// Loads NLog config created by the method <paramref name=""configBuilder""/>
+         /// </summary>
+         public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, Action<ISetupLoadConfigurationBuilder> configBuilder)
++        {
++            return LoadConfiguration(setupBuilder, true, configBuilder);
++        }
++
++        /// <summary>
++        /// Loads NLog config created by the method <paramref name=""configBuilder""/>
++        /// </summary>
++        public static ISetupBuilder LoadConfiguration(this ISetupBuilder setupBuilder, bool applyOnReload, Action<ISetupLoadConfigurationBuilder> configBuilder)
+         {
+             var config = setupBuilder.LogFactory._config;
+             var setupConfig = new SetupLoadConfigurationBuilder(setupBuilder.LogFactory, config);",I'm doubting if adding a bool here is a good idea. Maybe it should be an option object? Otherwise it's hard to extend. But an option object is a bit strange in a fluent API? What do you think @snakefoot ?,`applyOnReload` is not used.
+2315,"@@ -410,7 +410,7 @@ public class MultiPhraseQuery extends Query {
+    * <p>
+    * Note: positions are merged during freq()
+    */
+-  static class UnionPostingsEnum extends PostingsEnum {
++  public static class UnionPostingsEnum extends PostingsEnum {
+     /** queue ordered by docid */
+     final DocsQueue docsQueue;
+     /** cost of this enum: sum of its subs */",This is used in o.a.l.sandbox.search.PhraseWildcardQuery.,why is this public?
+2316,"@@ -42,6 +42,7 @@ type stateDB struct {
+ 	dao                db.KVStore // the underlying DB for account/contract storage
+ 	timerFactory       *prometheustimer.TimerFactory
+ 	workingsets        *lru.Cache // lru cache for workingsets
++	protocolView       protocol.Dock
+ }
+ 
+ // StateDBOption sets stateDB construction parameter",view should be loaded on start for both statedb and factory,struct field protocolView should be protocolView
+2317,"@@ -31,7 +31,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Http
+         private ConnectionFilterContext _filterContext;
+         private LibuvStream _libuvStream;
+         private FilteredStreamAdapter _filteredStreamAdapter;
+-        private Task _readInputContinuation;
++        private Task _readInputTask;
+ 
+         private readonly SocketInput _rawSocketInput;
+         private readonly SocketOutput _rawSocketOutput;",Why rename? Just curious...,nit: rename to _readInputTask
+2318,"@@ -309,12 +309,14 @@ public class VideoplayerActivity extends MediaplayerActivity {
+     public void onStartTrackingTouch(SeekBar seekBar) {
+         super.onStartTrackingTouch(seekBar);
+         videoControlsHider.stop();
++        controls.setVisibility(View.GONE);
+     }
+ 
+     @Override
+     public void onStopTrackingTouch(SeekBar seekBar) {
+         super.onStopTrackingTouch(seekBar);
+         setupVideoControlsToggler();
++        controls.setVisibility(View.VISIBLE);
+     }
+ 
+     @Override",Is this needed? I think it calls the super function that already does that.,Why is this needed?
+2319,"@@ -538,7 +538,9 @@ class BBoxHead(BaseModule):
+         labels = labels.view(1, 1, -1).expand_as(scores)
+         labels = labels.reshape(batch_size, -1)
+         scores = scores.reshape(batch_size, -1)
+-        bboxes = bboxes.reshape(batch_size, -1, 4)
++        if self.reg_class_agnostic:
++            bboxes = bboxes.reshape(batch_size, -1, 4)
++            bboxes = bboxes.repeat(1, self.num_classes, 1)
+ 
+         max_size = torch.max(img_shape)
+         # Offset bboxes of each class so that bboxes of different labels","This might slow down the inference time, are we sure we need to do that?",Why do we need this?
+2320,"@@ -23,11 +23,9 @@ import (
+ )
+ 
+ func Example() {
+-	// This example is used in https://gocloud.dev/howto/sql/#aws
+-
+-	// import _ ""gocloud.dev/mysql/awsmysql""
+-
+-	// Variables set up elsewhere:
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/mysql/awsmysql""
++	// PRAGMA(gocloud.dev): Skip until next blank line.
+ 	ctx := context.Background()
+ 
+ 	// Replace these with your actual settings.","This would read better if you add ""Skip code/lines"" or (exclude/hide code if you follow my earlier suggestion"")",Why is this needed?
+2321,"@@ -34,6 +34,13 @@ import java.util.HashSet;
+ import java.util.Map;
+ import javax.imageio.ImageIO;
+ import org.apache.commons.io.IOUtils;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
++import static edu.harvard.iq.dataverse.dataaccess.DataAccess.getStorageIO;
+ 
+ public class DatasetUtil {
+ ",Looks like glassfish went a bit nuts doing a refactor,why do we need thes
+2322,"@@ -84,6 +84,17 @@ namespace OpenTelemetry.Trace.Export.Internal
+             return Task.WhenAll(tasks);
+         }
+ 
++        public override Task ForceFlushAsync(CancellationToken cancellationToken)
++        {
++            var tasks = new List<Task>();
++            foreach (var processor in this.processors)
++            {
++                tasks.Add(processor.ForceFlushAsync(cancellationToken));
++            }
++
++            return Task.WhenAll(tasks);
++        }
++
+         public void Dispose()
+         {
+             foreach (var processor in this.processors)",nit: allocate the list using the number of processors.,Why do we need this
+2323,"@@ -142,10 +142,10 @@ public class PartitionSpec implements Serializable {
+ 
+   public String partitionToPath(StructLike data) {
+     StringBuilder sb = new StringBuilder();
+-    Class<?>[] javaClasses = javaClasses();
+-    for (int i = 0; i < javaClasses.length; i += 1) {
++    Class<?>[] initializedClasses = javaClasses();
++    for (int i = 0; i < initializedClasses.length; i += 1) {
+       PartitionField field = fields[i];
+-      String valueString = field.transform().toHumanString(get(data, i, javaClasses[i]));
++      String valueString = field.transform().toHumanString(get(data, i, initializedClasses[i]));
+ 
+       if (i > 0) {
+         sb.append(""/"");",Was this change triggered by baseline?,Shouldn't this be i
+2324,"@@ -36,17 +36,13 @@ class OrgThirtyDayActivity < ActiveRecord::Base
+     private
+ 
+     def with_commits_and_affiliates
+-      orgs = Organization.arel_table
+       joins(:organization)
+-        .where(id: orgs[:thirty_day_activity_id])
+         .where(arel_table[:thirty_day_commit_count].gt(0)
+         .and(arel_table[:affiliate_count].gt(0)))
+     end
+ 
+     def with_thirty_day_commit_count
+-      orgs = Organization.arel_table
+       joins(:organization)
+-        .where(id: orgs[:thirty_day_activity_id])
+         .where.not(thirty_day_commit_count: nil)
+         .order(thirty_day_commit_count: :desc)
+         .limit(5)",This code was doing nothing as far as I can tell and was making the SQL find nothing with the new version of Rails. Remove it unless someone can explain why it is there.,Why was this removed?
+2325,"@@ -39,6 +39,7 @@ public class RestExplorerApp extends Application {
+ 	public void onCreate() {
+ 		super.onCreate();
+ 		SalesforceSDKManager.initNative(getApplicationContext(), new KeyImpl(), ExplorerActivity.class);
++		SalesforceSDKManager.getInstance().setBrowserLoginEnabled(true);
+ 
+ 		/*
+ 		 * Un-comment the line below to enable push notifications in this app.",Setting browser based login as the default for `RestAPIExplorer`.,Why is this needed?
+2326,"@@ -231,6 +231,11 @@ void DataParallelTreeLearner<TREELEARNER_T>::FindBestSplitsFromHistograms(const
+   }
+ 
+   // sync global best info
++  auto max_cat_threshold = this->config_->max_cat_threshold;
++  int splitInfoSize = SplitInfo::Size(max_cat_threshold);
++  if (input_buffer_.size() < splitInfoSize * 2) {
++    input_buffer_.resize(splitInfoSize * 2);
++  }
+   SyncUpGlobalBestSplit(input_buffer_.data(), input_buffer_.data(), &smaller_best_split, &larger_best_split, this->config_->max_cat_threshold);
+ 
+   // set best split",maybe we can do this in Init function?,Why do we need this c
+2327,"@@ -2086,10 +2086,15 @@ func (wh *WorkflowHandler) ResetWorkflowExecution(ctx context.Context, request *
+ 	if request == nil {
+ 		return nil, errRequestNotSet
+ 	}
+-
+ 	if request.GetNamespace() == """" {
+ 		return nil, errNamespaceNotSet
+ 	}
++	if request.GetRequestId() == """" {
++		return nil, errRequestIDNotSet
++	}
++	if len(request.GetRequestId()) > wh.config.MaxIDLengthLimit() {
++		return nil, errRequestIDTooLong
++	}
+ 
+ 	if err := wh.validateExecution(request.WorkflowExecution); err != nil {
+ 		return nil, err","How about if request ID not set, service should generate a random uuid?",Can we move this chec
+2328,"@@ -105,7 +105,7 @@ func TestPerformUpdateWithUpdatesDisabled(t *testing.T) {
+ 		Reason:            ptr(""Updates are disabled"").(*string),
+ 	}})
+ 
+-	u.performUpdateHandler(statemanager.NewNoopStateManager(), engine.NewTaskEngine(cfg, nil, nil, nil, nil, nil, nil))(&ecsacs.PerformUpdateMessage{
++	u.performUpdateHandler(statemanager.NewNoopStateManager(), engine.NewTaskEngine(cfg, nil, nil, nil, nil, nil, nil, nil))(&ecsacs.PerformUpdateMessage{
+ 		ClusterArn:           ptr(""cluster"").(*string),
+ 		ContainerInstanceArn: ptr(""containerInstance"").(*string),
+ 		MessageId:            ptr(""mid"").(*string),",minor: this is an opportunity for you to split these long lines into multiple lines :),Why do we need this change?
+2329,"@@ -259,7 +259,10 @@ class RequestsParser(object):
+             req = ensure_is_dict(raw_requests, key, ""url"")
+             if not require_url and ""url"" not in req:
+                 req[""url""] = None
+-            requests.append(self.__parse_request(req))
++            try:
++                requests.append(self.__parse_request(req))
++            except:
++                raise TaurusConfigError(""Wrong request:\n %s"" % req)
+         return requests
+ 
+     def extract_requests(self, require_url=True):","It would be nice to have exception dumped somewhere (debug logs, info logs).",I'm not sure if this is the
+2330,"@@ -84,6 +84,13 @@ type Topic interface {
+ 	// https://github.com/google/go-cloud/blob/master/internal/docs/design.md#as
+ 	// for more background.
+ 	As(i interface{}) bool
++
++	// As allows providers to expose provider-specific types.
++	//
++	// See
++	// https://github.com/google/go-cloud/blob/master/internal/docs/design.md#as
++	// for more background.
++	MessageAs(m *Message, i interface{}) bool
+ }
+ 
+ // Subscription receives published messages.","So I don't think this is right, as discussed on #657.",Nit: `As allows providers t
+2331,"@@ -65,10 +65,16 @@ GROUP_IDS = """"""
+     SELECT group_id from groups_{0};
+ """"""
+ 
+-GROUP_USERS = """"""
++GROUP_ID = """"""
++    SELECT group_id
++    FROM groups_{1}
++    WHERE group_email = ""{0}"";
++""""""
++
++GROUP_MEMBERS = """"""
+     SELECT group_id, member_role, member_type, member_id, member_email
+-    FROM group_members_{0}
+-    WHERE member_status = ""ACTIVE"" and member_type = ""USER"";
++    FROM group_members_{1}
++    WHERE group_id = ""{0}"";
+ """"""
+ 
+ BUCKETS = """"""","should the group_id = ""{0}"" be group_id = %s You'd still keep the {} for the group_members_{} for the tablename but make the filter clause parameterized.",I think this should be `GRO
+2332,"@@ -89,7 +89,12 @@ class HierarchicHTTPRequest(HTTPRequest):
+                 raise TaurusConfigError(""Items from upload-files must specify parameter name"")
+ 
+             path_exc = TaurusConfigError(""Items from upload-files must specify path to file"")
+-            file_dict[""path""] = get_full_path(self.engine.find_file(file_dict.get(""path"", path_exc)))
++            path = str(file_dict.get(""path"", path_exc))
++            if not path.startswith('$'):    # exclude varables
++                path = get_full_path(self.engine.find_file(path))   # prepare full path for jmx
++
++            file_dict[""path""] = path
++
+             mime = mimetypes.guess_type(file_dict[""path""])[0] or ""application/octet-stream""
+             file_dict.get('mime-type', mime)
+         self.content_encoding = self.config.get('content-encoding', None)","Path can contain variable pattern in the middle. Also, `$` is not enough to tell if this is JMeter variable. We have correct variable detecting somewhere in our code.",Why do we need this change?
+2333,"@@ -20,6 +20,11 @@ class FormTestModel extends Model
+     {
+         return ['dropdown', 'options'];
+     }
++
++    public function staticMethodOptions()
++    {
++        return ['static', 'method'];
++    }
+ }
+ 
+ class FormHelper",@bennothommo can you revert this section? It shouldn't be required.,Why is this needed?
+2334,"@@ -92,9 +92,13 @@ module Ncr
+       ""ncr""
+     end
+ 
+-    # @todo - this is pretty ugly
+     def public_identifier
+-      self.cart.id
++      fiscal_year = self.created_at.year
++      if self.created_at.month >= 10
++        fiscal_year += 1
++      end
++      fiscal_year = fiscal_year % 100   # convert to two-digit
++      ""FY"" + fiscal_year.to_s.rjust(2, ""0"") + "" ##{self.id}""
+     end
+ 
+     def total_price",Minor: maybe move the above to a `#fiscal_year` method?,I don't think you need the 
+2335,"@@ -62,3 +62,13 @@ class BuildTest(QuiltTestCase):
+             'Expected dataframes to have same # columns'
+         del os.environ[""QUILT_PACKAGE_FORMAT""]
+         # TODO add more integrity checks, incl. negative test cases
++
++    def test_generate_buildfile(self):
++        mydir = os.path.dirname(__file__)
++        path = os.path.join(mydir, 'data')
++        buildfilepath = os.path.join(path, 'build.yml')
++        assert not os.path.exists(buildfilepath)
++        build.generate_build_file(path)
++        assert os.path.exists(buildfilepath)
++        build.build_package('test_hdf5', 'generated', buildfilepath)    
++        os.remove(buildfilepath)",You should use the current directory instead - it's a temporary directory that will get removed when the test is done.,Why is this needed?
+2336,"@@ -549,7 +549,7 @@ public class ContainerizedDispatchManagerTest {
+         this.containerizedDispatchManager.getExecutionDispatcher(this.flow1.getExecutionId()));
+     thread.start();
+     synchronized (thread) {
+-      thread.wait();
++      thread.join();
+     }
+     assertThat(flow1.getStatus()).isEqualTo(Status.FAILED);
+     verify(onExecutionEventListener).onExecutionEvent(this.flow1, Constants.RESTART_FLOW);",I think we don't need synchronization here.,Why is this change needed?
+2337,"@@ -92,7 +92,7 @@ public final class OAuth2AuthorizedClientArgumentResolver implements HandlerMeth
+ 							clientRegistrationId.flatMap(id -> Mono.error(new IllegalStateException(
+ 									""Unable to resolve the Authorized Client with registration identifier \""""
+ 											+ id
+-											+ ""\"". An \""authenticated\"" or \""unauthenticated\"" session is required. To allow for unauthenticated access, ensure ServerHttpSecurity.anonymous() is configured.""))))
++											+ ""\"". An \""authenticated\"" or \""anonymous\"" request is required. To allow for anonymous access, ensure ServerHttpSecurity.anonymous() is configured.""))))
+ 					.flatMap(zipped -> {
+ 						String registrationId = zipped.getT1();
+ 						String username = zipped.getT2();",I don't think this should be changed since on the reactive side we don't support anonymous users.,I don't think we should ch
+2338,"@@ -116,7 +116,7 @@ module Mongoid
+ 
+           before_destroy do
+             if record = __send__(name)
+-              record[cache_column] = (record[cache_column] || 0) - 1
++              record[cache_column] = (record[cache_column] || 0) - 1 unless record.frozen?
+ 
+               if record.persisted?
+                 record.class.decrement_counter(cache_column, record._id)",Maybe this `if` should be on line 118?,Why is this change necessa
+2339,"@@ -45,8 +45,8 @@ type (
+ 	// the less than equal bucket count for the pre-determined boundaries.
+ 	state struct {
+ 		bucketCounts []float64
+-		count        metric.Number
+ 		sum          metric.Number
++		count        int64
+ 	}
+ )
+ ",Cool. (I thought I had fixed this already in #812.),Why do we need this change
+2340,"@@ -36,7 +36,7 @@ module Bolt
+ 
+     TRANSPORT_OPTIONS = %i[password run-as sudo-password extensions
+                            private-key tty tmpdir user connect-timeout
+-                           cacert token-file service-url].freeze
++                           cacert token-file service-url interpreters].freeze
+ 
+     # TODO: move these to the transport themselves
+     TRANSPORT_SPECIFIC_DEFAULTS = {",I intend to do this as soon as I have tests passing.,I don't think we need this anymore.
+2341,"@@ -0,0 +1,7 @@
++#!/usr/bin/python3
++
++import sys
++import os
++sys.stdin.read()
++with open(os.environ['QUTE_FIFO'], 'wb') as fifo:
++    fifo.write(b':message-info ""stdin closed""\n')",Please remove the `test_*` from the filename - otherwise pytest will try to collect tests from it.,This file is missing a license head
+2342,"@@ -263,6 +263,11 @@ size_t wlr_session_find_gpus(struct wlr_session *session,
+ 		return explicit_find_gpus(session, ret_len, ret, explicit);
+ 	}
+ 
++#ifdef __FreeBSD__
++	// XXX: libudev-devd does not return any GPUs (yet?)
++	return explicit_find_gpus(session, ret_len, ret, ""/dev/drm/0"");
++#else
++
+ 	struct udev_enumerate *en = udev_enumerate_new(session->udev);
+ 	if (!en) {
+ 		wlr_log(L_ERROR, ""Failed to create udev enumeration"");",Did you file a bug to follow up on this?,I don't think this is the right way
+2343,"@@ -156,10 +156,13 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+     this.io = io;
+     this.encryptionManager = encryptionManager;
+     this.caseSensitive = caseSensitive;
+-
+-    this.batchReadsEnabled = options.get(""vectorization-enabled"").map(Boolean::parseBoolean).orElseGet(() ->
+-        PropertyUtil.propertyAsBoolean(table.properties(),
+-            TableProperties.PARQUET_VECTORIZATION_ENABLED, TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
++    boolean batchReadsSparkSessionConf = SparkSession.active().sparkContext().getConf()
++            .getBoolean(""read.parquet.vectorization.enabled"", true);
++    boolean batchReadsEnabledTableProp = options.get(""vectorization-enabled"").map(Boolean::parseBoolean).orElseGet(() ->
++            PropertyUtil.propertyAsBoolean(table.properties(),
++                    TableProperties.PARQUET_VECTORIZATION_ENABLED,
++                    TableProperties.PARQUET_VECTORIZATION_ENABLED_DEFAULT));
++    this.batchReadsEnabled = !batchReadsSparkSessionConf ? false : batchReadsEnabledTableProp;
+     this.batchSize = options.get(""batch-size"").map(Integer::parseInt).orElseGet(() ->
+         PropertyUtil.propertyAsInt(table.properties(),
+           TableProperties.PARQUET_BATCH_SIZE, TableProperties.PARQUET_BATCH_SIZE_DEFAULT));",Looks like these 4 lines didn't actually change. Can you revert the whitespace changes here?,nit: `read.parquet.vectorization.en
+2344,"@@ -1,4 +1,6 @@
+ RSpec::Support.require_rspec_core ""formatters/base_formatter""
++require 'pathname'
++
+ 
+ module RSpec
+   module Core","This can't be merged with any usage of `require 'pathname'` in lib, it's not always available and we don't want false positives for people (where they don't realise they needed to requite it). Its also unnecessary, no other formatter uses it to look up failure locations. See the exception presenter etc for how we format lines.",Why is this needed?
+2345,"@@ -1426,6 +1426,13 @@ public class DatasetsIT {
+         
+         // This should fail, because we are attempting to link the dataset 
+         // to its own dataverse:
++        Response publishTargetDataverse = UtilIT.publishDataverseViaNativeApi(dataverseAlias,  apiToken);
++        publishTargetDataverse.prettyPrint();
++                        publishTargetDataverse.then().assertThat()
++                        .statusCode(OK.getStatusCode());
++                        
++        Response publishDatasetForLinking = UtilIT.publishDatasetViaNativeApi(datasetId, ""major"", apiToken);
++        
+         Response createLinkingDatasetResponse = UtilIT.createDatasetLink(datasetId.longValue(), dataverseAlias, apiToken);
+         createLinkingDatasetResponse.prettyPrint();
+         createLinkingDatasetResponse.then().assertThat()",It would be nice to fix the indentation above.,nit: extra space af
+2346,"@@ -9334,8 +9334,8 @@ return [
+ 'openssl_x509_export_to_file' => ['bool', 'certificate'=>'string|resource', 'output_filename'=>'string', 'no_text='=>'bool'],
+ 'openssl_x509_fingerprint' => ['string|false', 'certificate'=>'string|resource', 'digest_algo='=>'string', 'binary='=>'bool'],
+ 'openssl_x509_free' => ['void', 'certificate'=>'resource'],
+-'openssl_x509_parse' => ['array|false', 'certificate'=>'string|resource', 'short_names='=>'bool'],
+-'openssl_x509_read' => ['resource|false', 'certificate'=>'string|resource'],
++'openssl_x509_parse' => ['array|false', 'certificate'=>'OpenSSLCertificate|string', 'short_names'=>'bool|null'],
++'openssl_x509_read' => ['OpenSSLCertificate|false', 'certificate'=>'OpenSSLCertificate|string'],
+ 'ord' => ['int', 'character'=>'string'],
+ 'OuterIterator::current' => ['mixed'],
+ 'OuterIterator::getInnerIterator' => ['Iterator'],","`short_names` is still optional, so `=` that indicates it has to stay there.",Shouldn't this be `
+2347,"@@ -153,6 +153,10 @@ func (agent *ecsAgent) appendFirelensFluentbitCapabilities(capabilities []*ecs.A
+ 	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentbit)
+ }
+ 
++func (agent *ecsAgent) appendEFSCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityEFS)
++}
++
+ func (agent *ecsAgent) appendFirelensLoggingDriverCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+ 	return appendNameOnlyAttribute(capabilities, capabilityPrefix+capabilityFirelensLoggingDriver)
+ }",missing calling of this method,I don't think we ne
+2348,"@@ -9,10 +9,12 @@ import (
+ 	""fmt""
+ 	""text/template""
+ 
++	""github.com/aws/aws-sdk-go/aws""
++	""github.com/aws/aws-sdk-go/service/cloudformation""
+ 	""github.com/fatih/structs""
+ 	""gopkg.in/yaml.v3""
+ 
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	archerCfn ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/deploy/cloudformation""
+ 	""github.com/aws/amazon-ecs-cli-v2/templates""
+ )
+ ","We could get rid of this dependency being forced on clients by changing the `StackConfiguration` interface abstraction to deal with strings instead of `cloudformation.Parameters` and `cloudformation.Tags`, and internally to the `cloudformation` package translate the input strings into the `service/cloudformation` package specific values hiding that from consumers. I don't think that should be taken on as part of this PR, but I think we should consider doing it at some point.",Nit: I think this should be `archerCfn`
+2349,"@@ -25,6 +25,8 @@ import (
+ // Stress chaos is a chaos to generate plenty of stresses over a collection of pods.
+ 
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ // +chaos-mesh:experiment
+ 
+ // StressChaos is the Schema for the stresschaos API",`StressChaos` does not contains a field .spec.action,// +kubebuilder:object:root
+2350,"@@ -1931,7 +1931,12 @@ class FunctionCallTest extends TestCase
+                       return $b[""a""];
+                     }
+ 
+-                    a([""a"" => ""hello""]);',
++                    function b(string $str): string
++                    {
++                        return $str;
++                    }
++
++                    a([""a"" => b(""hello"")]);',
+                 'error_message' => 'InvalidScalarArgument',
+             ],
+             'objectLikeKeyChecksAgainstDifferentTKeyedArray' => [","Non-int literal strings are no longer coercible to int, I think this is an improvement. Without this change it now reports `InvalidArgument`.",Why did you change this?
+2351,"@@ -27,6 +27,8 @@
+ #include ""cast_utils.h""
+ #include ""layer_validation_tests.h""
+ 
++#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
++
+ class MessageIdFilter {
+   public:
+     MessageIdFilter(const char *filter_string) {",I this used anyplace?,Why is this needed?
+2352,"@@ -102,7 +102,7 @@ public class TestHiveMetastore {
+         .transportFactory(new TTransportFactory())
+         .protocolFactory(new TBinaryProtocol.Factory())
+         .minWorkerThreads(3)
+-        .maxWorkerThreads(5);
++        .maxWorkerThreads(8);
+ 
+     return new TThreadPoolServer(args);
+   }",Why was this change required?,Why this change?
+2353,"@@ -39,6 +39,7 @@ public class AuthorizationException extends ProcessEngineException {
+ 
+   protected final String userId;
+   protected final List<MissingAuthorization> missingAuthorizations;
++  protected final boolean missingAdminRole;
+ 
+   // these properties have been replaced by the list of missingAuthorizations
+   // and are only left because this is a public API package and users might","I like that we have this attribute here. However, I think the way we use it right now might be confusing in the future. For example, when only camunda admin is checked, this exception will be instantiated with a message and `missingAdminRole` is `false`. I think that is counter-intuitive. I would expect this exception to have `missingAdminRole` set to `true`. With this explicit information, the exception message could now be generated inside this exception class with the text block that is currently used in the authorization manager. We could maybe generally reuse that text block then also for the case where a user is no admin and also has none of the required permissions. I haven't tried it myself but I think it would be great if we could streamline those things a bit more if we're working on it now. Let me know what you think.  ",I don't think we
+2354,"@@ -14,6 +14,9 @@ import com.google.flatbuffers.*;
+ public final class Monster extends Table {
+   public static Monster getRootAsMonster(ByteBuffer _bb) { return getRootAsMonster(_bb, new Monster()); }
+   public static Monster getRootAsMonster(ByteBuffer _bb, Monster obj) { _bb.order(ByteOrder.LITTLE_ENDIAN); return (obj.__assign(_bb.getInt(_bb.position()) + _bb.position(), _bb)); }
++  public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb) { return getSizePrefixedRootAsMonster(_psbb, new Monster()); }
++  public static Monster getSizePrefixedRootAsMonster(ByteBuffer _psbb, Monster obj) { ByteBuffer _bb = _psbb.slice(); _bb.position(4); return getRootAsMonster(_bb, obj); }
++  public static int getSizePrefix(ByteBuffer _bb) { _bb.order(ByteOrder.LITTLE_ENDIAN); return _bb.getInt(_bb.position()); }
+   public static boolean MonsterBufferHasIdentifier(ByteBuffer _bb) { return __has_identifier(_bb, ""MONS""); }
+   public void __init(int _i, ByteBuffer _bb) { bb_pos = _i; bb = _bb; }
+   public Monster __assign(int _i, ByteBuffer _bb) { __init(_i, _bb); return this; }","Not sure why we're creating a new `ByteBuffer` here, ideally this refers to the existing one?",`_psbb` -> `_bb`
+2355,"@@ -45,10 +45,11 @@ import getNoDataComponent from '../../../../components/legacy-notifications/noda
+ import getDataErrorComponent from '../../../../components/legacy-notifications/data-error';
+ import HelpLink from '../../../../components/HelpLink';
+ import { getCurrentDateRangeDayCount } from '../../../../util/date-range';
+-import { STORE_NAME } from '../../datastore/constants';
++import { STORE_NAME, DATE_RANGE_OFFSET } from '../../datastore/constants';
+ import { CORE_USER } from '../../../../googlesitekit/datastore/user/constants';
+ import { CORE_SITE } from '../../../../googlesitekit/datastore/site/constants';
+ import { untrailingslashit } from '../../../../util';
++import { generateDateRangeArgs } from '../../util/report-date-range-args';
+ 
+ const { useSelect } = Data;
+ ",Same here re: `STORE_NAME` to `MODULES_SEARCH_CONSOLE`.,Why do we need t
+2356,"@@ -21,11 +21,14 @@ async function proceedToSetUpAnalytics() {
+ 	await Promise.all( [
+ 		expect( page ).toClick( '.googlesitekit-cta-link', { text: /set up analytics/i } ),
+ 		page.waitForSelector( '.googlesitekit-setup-module--analytics' ),
+-		page.waitForResponse( ( res ) => res.url().match( 'analytics/data' ) ),
++		page.waitForResponse( ( res ) => res.url().match( 'analytics/data/accounts-properties-profiles' ) ),
+ 	] );
+ }
+ 
+-const EXISTING_PROPERTY_ID = 'UA-00000001-1';
++const existingTag = {
++	accountID: '999',
++	propertyID: 'UA-999-9',
++};
+ 
+ describe( 'setting up the Analytics module with no existing account and with an existing tag', () => {
+ 	beforeAll( async () => {",I could've sworn I got a `403` myself when I got that response locally. Is `200` what the API would send back for a `permission: false` tag?,I think this should be `UA-999-10`
+2357,"@@ -11,13 +11,13 @@ import (
+ 	""strings""
+ )
+ 
+-type identityManager struct {
+-	keystoreManager keystoreInterface
++type IdentityManager struct {
++	KeystoreManager keystoreInterface
+ }
+ 
+-func NewIdentityManager(keydir string) *identityManager {
+-	return &identityManager{
+-		keystoreManager: keystore.NewKeyStore(keydir, keystore.StandardScryptN, keystore.StandardScryptP),
++func NewIdentityManager(keydir string) *IdentityManager {
++	return &IdentityManager{
++		KeystoreManager: keystore.NewKeyStore(keydir, keystore.StandardScryptN, keystore.StandardScryptP),
+ 	}
+ }
+ ",This attribute was intentionally private. - lets force usage of factory `NewIdentityManager()` - lets ramake to `NewIdentityManager(keydir string)` -> `NewIdentityManager(keystore keystoreManager)`,Why is this public?
+2358,"@@ -34,6 +34,10 @@ import (
+ 
+ const transportName = ""redis""
+ 
++const maxConnectRetries = 100
++
++var connectRetryDelay = 10 * time.Millisecond
++
+ // Inbound is a redis inbound that reads from the given queueKey. This will
+ // wait for an item in the queue or until the timout is reached before trying
+ // to read again.",Is this too frequent?,I think this should be `const conn
+2359,"@@ -21,6 +21,7 @@ class UploadModel
+ {
+     private const FILE_EXTENSIONS = [
+         'csv',
++        'zip',
+     ];
+ 
+     /**","will this not make it possible to use a zip file, e.g. on other importers who do not have to support it ?",Why is this needed?
+2360,"@@ -34,6 +34,7 @@ from .http import UpstreamConnectLayer
+ from .http1 import Http1Layer
+ from .http2 import Http2Layer
+ from .rawtcp import RawTCPLayer
++from .socks_client import SocksClientLayer
+ 
+ __all__ = [
+     ""Layer"", ""ServerConnectionMixin"", ""Kill"",",Needs to be mentioned in `__all__` below.,Why is this needed?
+2361,"@@ -349,6 +349,13 @@ signalfd_thread_exit(dcontext_t *dcontext, thread_sig_info_t *info)
+     TABLE_RWLOCK(sigfd_table, write, unlock);
+ }
+ 
++bool
++is_repeat_handle_pre_extended_syscall_sigmasks(dcontext_t *dcontext)
++{
++    thread_sig_info_t *info = (thread_sig_info_t *)dcontext->signal_field;
++    return info->pre_syscall_app_sigprocmask_valid;
++}
++
+ bool
+ handle_pre_extended_syscall_sigmasks(dcontext_t *dcontext, kernel_sigset_t *sigmask,
+                                      size_t sizemask)","What if the app's signal handler, executed at pre-syscall for epoll_pwait, executes its own epoll_pwait? For that matter: what happens natively if that happens? I would not expect the kernel to keep a stack -- does that clobber the kernel's stored pre-syscall mask?",nit: `return info->
+2362,"@@ -139,8 +139,10 @@ public interface DataFile {
+   DataFile copy();
+ 
+   /**
+-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
+-   * information is used for planning scan tasks whose boundaries are determined by these offsets.
++   * @return List of offsets for blocks of a file, if applicable, null otherwise.
++   * When available, this information is used for planning scan tasks whose boundaries
++   * are determined by these offsets.It is important that the returned list is sorted
++   * in ascending order.
+    */
+   List<Long> splitOffsets();
+ }","Nit: missing a space. I think we should phrase the new content a little differently. ""It is important"" isn't very clear. I think it should be ""offsets will be returned in sorted order.""","nit: ""of a file"" ->"
+2363,"@@ -10,8 +10,10 @@ import (
+ 	""crypto/md5""
+ 	""encoding/base64""
+ 	""encoding/hex""
++	""encoding/json""
+ 	""fmt""
+ 	""io""
++	""io/ioutil""
+ 	""net/http""
+ 	""net/url""
+ 	""path""",Can you remove this blank line and put the added import in sorted order (likely your editor will do this),Why is this needed?
+2364,"@@ -606,12 +606,16 @@ static int listener_setup_ssl(h2o_configurator_command_t *cmd, h2o_configurator_
+                                                                 : ""share/h2o/fetch-ocsp-response"";
+         if (ocsp_update_interval != 0) {
+             switch (conf.run_mode) {
+-            case RUN_MODE_WORKER:
++            case RUN_MODE_WORKER: {
++                int err;
+                 ssl_config->ocsp_stapling.interval =
+                     ocsp_update_interval; /* is also used as a flag for indicating if the updater thread was spawned */
+                 ssl_config->ocsp_stapling.max_failures = ocsp_max_failures;
+-                pthread_create(&ssl_config->ocsp_stapling.updater_tid, NULL, ocsp_updater_thread, ssl_config);
+-                break;
++                err = pthread_create(&ssl_config->ocsp_stapling.updater_tid, NULL, ocsp_updater_thread, ssl_config);
++                if (err != 0) {
++                    fprintf(stderr, ""[OCSP Stapling] pthread_create for ocsp_updater_thread failed. errno:%d\n"", err);
++                }
++            } break;
+             case RUN_MODE_MASTER:
+             case RUN_MODE_DAEMON:
+                 /* nothing to do */","Even if `pthread_create()` for `ocsp_updater_thread()` fails, `h2o` can continue to serve. But I'm a little worried whether `h2o` should continue to serve in this case. How about you?",please use LOG_ERR instead of fprintf
+2365,"@@ -37,6 +37,15 @@ import { __, _x, sprintf } from '@wordpress/i18n';
+ import { Component, Fragment } from '@wordpress/element';
+ import { addFilter, removeFilter } from '@wordpress/hooks';
+ 
++/**
++ * Internal dependencies
++ */
++import { isValidAccountID, isValidContainerID } from './util';
++
++const ACCOUNT_CREATE = 'account_create';
++const ACCOUNT_CHOOSE = 'account_choose';
++const CONTAINER_CREATE = 'container_create';
++
+ class TagmanagerSetup extends Component {
+ 	constructor( props ) {
+ 		super( props );","I like introduction of these constants for account/container creation, but the `ACCOUNT_CHOOSE` one isn't needed I think. This should instead be an ""empty"" value (either `''` or `0`), to indicate more clearly that this field is not filled. It should be the same for choosing a container.",I'm not sure if we need these constan
+2366,"@@ -101,3 +101,16 @@ Blockly.scratchBlocksUtils.isShadowArgumentReporter = function(block) {
+   return (block.isShadow() && (block.type == 'argument_reporter_boolean' ||
+       block.type == 'argument_reporter_string_number'));
+ };
++
++/**
++ * Compare strings with natural number sorting.
++ * @param {string} str1 First input.
++ * @param {string} str2 Second input.
++ * @return {number} -1, 0, or 1 to signify greater than, equality, or less than.
++ */
++Blockly.scratchBlocksUtils.compareStrings = function(str1, str2) {
++  return str1.localeCompare(str2, undefined, {
++    sensitivity: 'base',
++    numeric: true
++  });
++};","I noticed that passing in `[]` for the locales argument instead of 'undefined' seems to have the same effect. I think that's preferred over passing in `undefined` as a value, and unfortunately passing in `null` seems to throw an error.",I think this should be `str1.localeCo
+2367,"@@ -114,12 +114,11 @@ func getEngine() (*xorm.Engine, error) {
+ 		}
+ 	case ""postgres"":
+ 		host, port := ""127.0.0.1"", ""5432""
+-		fields := strings.Split(DbCfg.Host, "":"")
+-		if len(fields) > 0 && len(strings.TrimSpace(fields[0])) > 0 {
+-			host = fields[0]
+-		}
+-		if len(fields) > 1 && len(strings.TrimSpace(fields[1])) > 0 {
+-			port = fields[1]
++		if strings.Contains(DbCfg.Host, "":"") && !strings.HasSuffix(DbCfg.Host, ""]"") {
++			host = DbCfg.Host[0:strings.LastIndex(DbCfg.Host, "":"")]
++			port = DbCfg.Host[strings.LastIndex(DbCfg.Host, "":"")+1:]
++		} else if len(DbCfg.Host) > 0 {
++			host = DbCfg.Host
+ 		}
+ 
+ 		if host[0] == '/' { // looks like a unix socket","1. `0` is redundant. 2. We should save result of `strings.LastIndex(DbCfg.Host, "":"")` to a variable and reuse.",I'm not sure if this is the right way
+2368,"@@ -157,6 +157,7 @@ type Options struct {
+ 	NoLog                 bool          `json:""-""`
+ 	NoSigs                bool          `json:""-""`
+ 	NoSublistCache        bool          `json:""-""`
++	NoHeaderSupport       bool          `json:""-""`
+ 	DisableShortFirstPing bool          `json:""-""`
+ 	Logtime               bool          `json:""-""`
+ 	MaxConn               int           `json:""max_connections""`","Do you envision ""new"" servers not supporting header, or is it more a way to test mix of old and new? If so, we could make it a ""private"" (non exported) option.",Why do we need this?
+2369,"@@ -51,7 +51,7 @@ type Connection struct {
+ func (c *Connection) Start(options connection.ConnectOptions) (err error) {
+ 	var config wg.ServiceConfig
+ 	if err := json.Unmarshal(options.SessionConfig, &config); err != nil {
+-		return err
++		return errors.Wrap(err, ""failed to unmarshal connection config"")
+ 	}
+ 	c.config.Provider = config.Provider
+ 	c.config.Consumer.IPAddress = config.Consumer.IPAddress",For future reference. Try not to do refactoring in the same PR which solves some bug or implements some feature. Not to clutter reading. Do it in separate PR.,Why not just return 
+2370,"@@ -110,7 +110,7 @@ func init() {
+ 	addTxnFlags(freezeAssetCmd)
+ 
+ 	infoAssetCmd.Flags().Uint64Var(&assetID, ""assetid"", 0, ""ID of the asset to look up"")
+-	infoAssetCmd.Flags().StringVar(&assetUnitName, ""asset"", """", ""Unit name of the asset to look up"")
++	infoAssetCmd.Flags().StringVar(&assetUnitName, ""unit"", """", ""Unit name of the asset to look up"")
+ 	infoAssetCmd.Flags().StringVar(&assetCreator, ""creator"", """", ""Account address of the asset creator"")
+ }
+ ","I'm not sure about changing the flag name. unit is more accurate, but for I think for most people asset is also a fine name to use.",Why this change?
+2371,"@@ -0,0 +1,19 @@
++// +build windows
++
++package terminal
++
++import (
++	""syscall""
++)
++
++// HideConsole hides the console window and activates another window
++func HideConsole() {
++	getConsoleWindow := syscall.NewLazyDLL(""kernel32.dll"").NewProc(""GetConsoleWindow"")
++	showWindow := syscall.NewLazyDLL(""user32.dll"").NewProc(""ShowWindow"")
++	if getConsoleWindow.Find() == nil && showWindow.Find() == nil {
++		hwnd, _, _ := getConsoleWindow.Call()
++		if hwnd != 0 {
++			showWindow.Call(hwnd, 0)
++		}
++	}
++}",Which windows gets activated? A random other window?,Why do we need this?
+2372,"@@ -62,6 +62,11 @@ func (a *Publisher) Start(ctx context.Context) error {
+ }
+ 
+ func (a *Publisher) receive(ctx context.Context, event cloudevents.Event, resp *cloudevents.EventResponse) error {
++	// Upgrade to supported transport version.
++	if event.SpecVersion() != cloudevents.VersionV03 {
++		event.Context = event.Context.AsV03()
++	}
++
+ 	if _, r, err := a.outbound.Send(ctx, event); err != nil {
+ 		return err
+ 	} else if r != nil {","Just to make sure, this is totally lossless? If I put a v2 there, then it gets upgraded to v3, but my function expects v2, then this is fine and nothing is lost?",Why do we need this?
+2373,"@@ -228,4 +228,10 @@ public class TableProperties {
+ 
+   public static final String MERGE_CARDINALITY_CHECK_ENABLED = ""write.merge.cardinality-check.enabled"";
+   public static final boolean MERGE_CARDINALITY_CHECK_ENABLED_DEFAULT = true;
++
++  public static final String WATERMARK_FIELD_NAME = ""write.watermark.field"";
++  public static final String WATERMARK_FIELD_NAME_DEFAULT = """";
++
++  public static final String WATERMARK_VALUE = ""write.watermark"";
++  public static final long WATERMARK_VALUE_DEFAULT = -1;
+ }","In the past, we have 3 Flink streaming jobs (1 for each AWS region) writing to the same table. We need to write to 3 different watermark table properties (1 for each region). Watermark consumer then use the min value to determine the overall table watermark. A provider pattern similar to `WRITE_LOCATION_PROVIDER_IMPL` can work. A default impl could be a single property name. not sure if there is a simpler way to achieve this.",This should be `writ
+2374,"@@ -67,6 +67,16 @@ func (h TlfHandle) IsReader(user keybase1.UID) bool {
+ 	return ok
+ }
+ 
++// ResolvedReadersMap returns a map of resolved readers from uid to usernames.
++func (h TlfHandle) ResolvedReadersMap() map[keybase1.UID]libkb.NormalizedUsername {
++	return h.resolvedReaders
++}
++
++// ResolvedWritersMap returns a map of resolved writers from uid to usernames.
++func (h TlfHandle) ResolvedWritersMap() map[keybase1.UID]libkb.NormalizedUsername {
++	return h.resolvedWriters
++}
++
+ func (h TlfHandle) unsortedResolvedWriters() []keybase1.UID {
+ 	if len(h.resolvedWriters) == 0 {
+ 		return nil","Can you change this to `ResolvedUsersMap` and build a new map with both readers/writers? That way, we get the nice side effect of not exposing the internal map of the handle, and simplifying the callers a bit.",I don't think we nee
+2375,"@@ -439,10 +439,12 @@ function createTopology(mongoClient, topologyType, options, callback) {
+     }
+ 
+     const MongoClient = loadClient();
+-    const connectionString =
+-      os.platform() === 'win32'
+-        ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
+-        : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    let connectionString =
++      mongoClient.s.options.cryptdConnectionString != null
++        ? mongoClient.s.options.cryptdConnectionString
++        : os.platform() === 'win32'
++          ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
++          : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
+ 
+     const mongocryptdClient = new MongoClient(connectionString, { useUnifiedTopology: true });
+     mongocryptdClient.connect(err => {","I typically try to avoid nested ternary expressions. Can we rewrite this as if statements? Worst case, can we break it out into its own function?",Why do we need this 
+2376,"@@ -427,7 +427,8 @@ if __name__ == ""__main__"":  # pragma: no cover
+                 tls_start.ssl_conn.set_accept_state()
+             else:
+                 tls_start.ssl_conn.set_connect_state()
+-                tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni)
++                if tls_start.context.client.sni is not None:
++                    tls_start.ssl_conn.set_tlsext_host_name(tls_start.context.client.sni.encode())
+ 
+         await SimpleConnectionHandler(reader, writer, opts, {
+             ""next_layer"": next_layer,",Do we still support handshakes without SNI present?,Why is this needed?
+2377,"@@ -131,7 +131,7 @@ module Substitutors
+       when :post_replacements
+         text = sub_post_replacements text
+       else
+-        warn %(asciidoctor: WARNING: unknown substitution type #{type})
++        logger.warn %(unknown substitution type #{type})
+       end
+     end
+     text = restore_passthroughs text if has_passthroughs","Maybe it's because I work too much on a centralized logging system but it could be great to add a ""category"" like ""attribute"", ""substitution"", ""include directive"", ""macro"", ""extension""...",Style/StringLiteral
+2378,"@@ -45,7 +45,7 @@ def normalizeName(name):
+     """"""Normalize the class name to remove ambiguity
+ 
+     This function removes the white spaces in the name, and also
+-    remove the pointer declaration ""*"" (it have no sense in python) """"""
++    remove the pointer declaration ""*"" (it have no sense in python)""""""
+ 
+     name = name.replace("" "", """")
+     name = name.replace(""*"", """")",it have no sense in python -> it makes no sense in python,Why did you change 
+2379,"@@ -29,11 +29,13 @@ import (
+ type Pool struct {
+ 	start, capacity int
+ 	rand            *rand.Rand
++	openvpnPort     int
+ }
+ 
+ // ServicePortSupplier provides port needed to run a service on
+ type ServicePortSupplier interface {
+ 	Acquire() (Port, error)
++	OpenvpnPort() (Port, error)
+ }
+ 
+ // NewPool creates a port pool that will provide ports from range 40000-50000",maybe just do a separate implementation of the pool for openvpn case? It's a bit confusing having two methods here.,nit: `openvpnPort` 
+2380,"@@ -413,7 +413,7 @@ function createTopology(mongoClient, topologyType, options, callback) {
+   // Open the connection
+   topology.connect(options, (err, newTopology) => {
+     if (err) {
+-      topology.close(true);
++      if (topology) topology.close();
+       return callback(err);
+     }
+ ",how is it possible to have a `topology` that is falsey when we had to call `topology.connect` in order to get here?,Why is this change needed?
+2381,"@@ -0,0 +1,13 @@
++require 'spec_helper'
++
++describe Widgets::PlanChurnsController do
++  it 'returns the current churn for the requested plan' do
++    plan = stub(current_churn: 10)
++    PlanFinder.stubs(where: [plan])
++
++    get :show, format: :json, sku: 'sku'
++
++    expect(PlanFinder).to have_received(:where).with(sku: 'sku')
++    expect(number_widget_first_value).to eq 10
++  end
++end",Do we need this expectation? If we don't call this method on `PlanFinder` there's no way for the `10` to be returned. Seems somewhat redundant. What do you think?,Layout/TrailingBlankLines:
+2382,"@@ -141,8 +141,6 @@ func NewMinEdgeSiteConfig() *EdgeSiteConfig {
+ 			APIVersion: path.Join(GroupName, APIVersion),
+ 		},
+ 		DataBase: &edgecoreconfig.DataBase{
+-			DriverName: DataBaseDriverName,
+-			AliasName:  DataBaseAliasName,
+ 			DataSource: DataBaseDataSource,
+ 		},
+ 		KubeAPIConfig: &cloudcoreconfig.KubeAPIConfig{",We need to do the same for edgecore,Why is this being removed?
+2383,"@@ -378,8 +378,15 @@ namespace TestPlatform.CommunicationUtilities.UnitTests
+             this.mockDataSerializer.Setup(ds => ds.DeserializeMessage(rawMessage)).Returns(message);
+             this.mockDataSerializer.Setup(ds => ds.DeserializePayload<TestRunCompletePayload>(message)).Returns(payload);
+ 
++            var waitHandle = new AutoResetEvent(false);
++            mockHandler.Setup(mh => mh.HandleTestRunComplete(It.IsAny<TestRunCompleteEventArgs>(),
++                It.IsAny<TestRunChangedEventArgs>(), It.IsAny<ICollection<AttachmentSet>>(), It.IsAny<ICollection<string>>())).Callback
++                (() => waitHandle.Set());
++
+             this.testRequestSender.StartTestRun(runCriteria, mockHandler.Object);
+ 
++            waitHandle.WaitOne();
++
+             this.mockCommunicationManager.Verify(mc => mc.SendMessage(MessageType.StartTestExecutionWithTests, runCriteria), Times.Once);
+             this.mockDataSerializer.Verify(ds => ds.DeserializeMessage(rawMessage), Times.Once);
+             mockHandler.Verify(mh => mh.HandleTestRunComplete(null, null, null, null), Times.Once);",This fix has nothing to do with the product change. Just a fix I am making for the test issue.,Why is this needed?
+2384,"@@ -94,8 +94,7 @@ namespace OpenTelemetry.Trace
+             }
+             else if (this.Exporter != null)
+             {
+-                // TODO: Make this BatchingActivityProcessor once its available.
+-                exportingProcessor = new SimpleActivityProcessor(this.Exporter);
++                exportingProcessor = new BatchingActivityProcessor(this.Exporter);
+                 this.Processors.Add(exportingProcessor);
+             }
+ ",Don't know what should be the default. Lets keep BatchingProcessor for now. And revisit the area after beta.,Why is this change needed?
+2385,"@@ -1,4 +1,4 @@
+-require 'rspec/support/reentrant_mutex'
++RSpec::Support.require_rspec_support 'reentrant_mutex'
+ 
+ module RSpec
+   module Core","Ah that's how it's happening, it's probably using the `require_relative` in the optimised one and that counts as a different require to the bare one.",Prefer double-quoted strin
+2386,"@@ -27,6 +27,7 @@ namespace MvvmCross.Platforms.Ios.Binding.Views
+             : base(tableView)
+         {
+             _cellIdentifier = new NSString(cellIdentifier);
++            tableView.RegisterNibForCellReuse(UINib.FromName(cellIdentifier, NSBundle.MainBundle), cellIdentifier);
+         }
+ 
+         public MvxSimpleTableViewSource(UITableView tableView, string nibName, string cellIdentifier = null,",What happens if there is no NIB/XIB with that name?,Why is this needed?
+2387,"@@ -79,7 +79,7 @@ type Server struct {
+ 	ap               actpool.ActPool
+ 	gs               *gasstation.GasStation
+ 	broadcastHandler BroadcastOutbound
+-	cfg              config.API
++	cfg              config.Config
+ 	registry         *protocol.Registry
+ 	blockListener    *blockListener
+ 	grpcserver       *grpc.Server",this is not necessary?,Why do we need this change
+2388,"@@ -19,6 +19,7 @@ import (
+ 
+ 	""github.com/aws/amazon-ecs-agent/agent/taskresource""
+ 	asmauthres ""github.com/aws/amazon-ecs-agent/agent/taskresource/asmauth""
++	asmsecretres ""github.com/aws/amazon-ecs-agent/agent/taskresource/asmsecret""
+ 	cgroupres ""github.com/aws/amazon-ecs-agent/agent/taskresource/cgroup""
+ 	ssmsecretres ""github.com/aws/amazon-ecs-agent/agent/taskresource/ssmsecret""
+ 	""github.com/aws/amazon-ecs-agent/agent/taskresource/volume""","typo: `asmsecrets ""github...`","""github.com/aws/aws-sdk-go/service/ec2"""
+2389,"@@ -269,14 +269,14 @@ function neve_sanitize_meta_ordering( $value ) {
+ 	);
+ 
+ 	if ( empty( $value ) ) {
+-		return $allowed;
++		return wp_json_encode( $allowed );
+ 	}
+ 
+ 	$decoded = json_decode( $value, true );
+ 
+ 	foreach ( $decoded as $val ) {
+ 		if ( ! in_array( $val, $allowed, true ) ) {
+-			return $allowed;
++			return wp_json_encode( $allowed );
+ 		}
+ 	}
+ ","I think that the JSON encoding should be handled by the control itself, not the sanitization function. This should only confirm that the input is correct, not reformat it  ",This should be `wp_json_decode`
+2390,"@@ -79,6 +79,12 @@ func (i *Inbound) SetRegistry(registry transport.Registry) {
+ 	i.registry = registry
+ }
+ 
++// Transports returns the inbound's HTTP transport.
++func (i *Inbound) Transports() []transport.Transport {
++	// TODO factor out transport and return it here.
++	return []transport.Transport{}
++}
++
+ // Start starts the inbound with a given service detail, opening a listening
+ // socket.
+ func (i *Inbound) Start() error {",Should we put a TODO here to route the http.Transport through here?,Why do we need this TODO?
+2391,"@@ -177,7 +177,7 @@ func RemoveManagementInterface(networkName string) error {
+ 	var err error
+ 	var maxRetry = 3
+ 	var i = 0
+-	cmd := fmt.Sprintf(""Get-VMSwitch -Name %s  | Set-VMSwitch -AllowManagementOS $false "", networkName)
++	cmd := fmt.Sprintf(""Get-VMSwitch -ComputerName $(hostname) -Name %s  | Set-VMSwitch -ComputerName $(hostname) -AllowManagementOS $false "", networkName)
+ 	// Retry the operation here because an error is returned at the first invocation.
+ 	for i < maxRetry {
+ 		_, err = ps.RunCommand(cmd)","Sorry, could you explain more about the issue? Doesn't ComputerName already default to local computer? > -ComputerName Specifies one or more Hyper-V hosts on which the virtual switch is to be configured. NetBIOS names, IP addresses, and fully qualified domain names are allowable. The default is the local computer. Use localhost or a dot (.) to specify the local computer explicitly.",// Get-VMSwitch -Name %s  | Set-VMSwitc
+2392,"@@ -131,9 +131,13 @@ func runCliTool(logger *log.Logger, testCase *junitxml.TestCase, cmdString strin
+ }
+ 
+ // RunTestCommand runs given test command
+-func RunTestCommand(cmd string, args []string, logger *log.Logger, testCase *junitxml.TestCase) bool {
++func RunTestCommand(cmd string, args []string, logger *log.Logger, testCase *junitxml.TestCase, allowError bool) bool {
+ 	if err := runCliTool(logger, testCase, cmd, args); err != nil {
+-		Failure(testCase, logger, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		if allowError {
++			logger.Printf(""[%v] %v"", testCase.Name, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		} else {
++			Failure(testCase, logger, fmt.Sprintf(""Error running cmd: %v\n"", err))
++		}
+ 		return false
+ 	}
+ 	return true","`allowError` is a big vague. Does this mean the test case is asserting that an error should occur? If it means ""maybe an error can occur, and that's okay"" -- what's an example of this?",Why do we need this?
+2393,"@@ -29,7 +29,11 @@ var Xrc20Cmd = &cobra.Command{
+ var xrc20ContractAddress string
+ 
+ func xrc20Contract() (address.Address, error) {
+-	return alias.IOAddress(xrc20ContractAddress)
++	addr, err := alias.IOAddress(xrc20ContractAddress)
++	if err != nil {
++		return nil, output.NewError(output.FlagError, ""invalid xrc20 address flag"", err)
++	}
++	return addr, nil
+ }
+ 
+ type amountMessage struct {",return statements should not be cuddled if block has more than two lines (from `wsl`),Shouldn't we return 
+2394,"@@ -10,11 +10,12 @@ import java.util.*;
+ import java.util.concurrent.TimeUnit;
+ 
+ import static java.lang.management.ManagementFactory.*;
++import sun.reflect.generics.reflectiveObjects.NotImplementedException;
+ 
+ /**
+  * A collection of Java Virtual Machine metrics.
+  */
+-public class VirtualMachineMetrics {
++public class VirtualMachineMetrics implements Metric {
+     public static class GarbageCollector {
+         private final long runs, timeMS;
+ ",Why does VirtualMachineMetrics have to implement Metric?,Why do we need this?
+2395,"@@ -64,16 +64,12 @@ func TestSingleAccountManager_SignVote(t *testing.T) {
+ 	require.NoError(err)
+ 	voteeAddress, err := iotxaddress.GetAddressByPubkey(iotxaddress.IsTestnet, iotxaddress.ChainID, votePubKey)
+ 	require.NoError(err)
+-	rawVote, err := action.NewVote(uint64(1), voterAddress.RawAddress, voteeAddress.RawAddress, uint64(100000), big.NewInt(10))
++	vote, err := action.NewVote(uint64(1), voterAddress.RawAddress, voteeAddress.RawAddress, uint64(100000), big.NewInt(10))
+ 	require.NoError(err)
+-	signedVote, err := m.SignVote(rawVote)
+-	require.NoError(err)
+-	require.NotNil(signedVote)
++	require.NoError(m.SignVote(vote))
+ 
+ 	require.NoError(accountManager.Remove(rawAddr1))
+-	signedVote, err = m.SignVote(rawVote)
+-	require.Equal(ErrNumAccounts, errors.Cause(err))
+-	require.Nil(signedVote)
++	require.Equal(ErrNumAccounts, errors.Cause(m.SignVote(vote)))
+ }
+ 
+ func TestSingleAccountManager_SignHash(t *testing.T) {",line is 121 characters,Why did you remove t
+2396,"@@ -93,7 +93,7 @@ function setProperty(dom, name, value, oldValue, isSvg) {
+ 		}
+ 	}
+ 	// Benchmark for comparison: https://esbench.com/bench/574c954bdb965b9a00965ac6
+-	else if (name[0] === 'o' && name[1] === 'n') {
++	else if (name.slice(0, 2) === 'on') {
+ 		let useCapture = name !== (name = name.replace(/Capture$/, ''));
+ 		let nameLower = name.toLowerCase();
+ 		name = (nameLower in dom ? nameLower : name).slice(2);",How's that linked esbench looking with slice?,Why not `name.slice(2) === 'on'`?
+2397,"@@ -131,14 +131,11 @@ class RemoteFileSystem(luigi.target.FileSystem):
+         return exists
+ 
+     def _ftp_exists(self, path, mtime):
+-        path_parts = path.split('/')
+-        path = '/'.join(path_parts[:-1])
+-        fn = path_parts[-1]
+-
+-        files = self.conn.nlst(path)
++        dirname = os.path.dirname(path)
++        files = self.conn.nlst(dirname)
+ 
+         exists = False
+-        if fn in files:
++        if path in files:
+             if mtime:
+                 mdtm = self.conn.sendcmd('MDTM ' + path)
+                 modified = datetime.datetime.strptime(mdtm[4:], ""%Y%m%d%H%M%S"")","The split and join was probably done to ensure that this still works on Windows because os.path.dirname works differently depending on the os you're running under :(. It would probably be a little better to do `dirname, _, fn = path.rpartition('/')` if you want something cleaner than the split/join.",This should be `os.path.dirname(p
+2398,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+ 
+   public abstract void remove(SessionId id);
+ 
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.,Why is this needed?
+2399,"@@ -335,6 +335,9 @@ func (s *session) run() error {
+ 
+ 	var closeErr closeError
+ 	handshakeEvent := s.handshakeEvent
++	var pacingDeadline time.Time
++
++	s.maybeResetTimer(time.Time{})
+ 
+ runLoop:
+ 	for {",Can you make this a member var as all the other deadlines? Then you can drop the param to resetTimer() and simplify some of the code below iiuc.,Why do we need this?
+2400,"@@ -715,9 +715,9 @@ void testCanonicalize() {
+   TautomerEnumerator te(new TautomerCatalog(tautparams.get()));
+ 
+   for (const auto &itm : canonTautomerData) {
+-    std::unique_ptr<ROMol> mol{SmilesToMol(itm.first)};
++    ROMOL_SPTR mol{SmilesToMol(itm.first)};
+     TEST_ASSERT(mol);
+-    std::unique_ptr<ROMol> res{te.canonicalize(*mol)};
++    ROMOL_SPTR res{te.canonicalize(*mol)};
+     TEST_ASSERT(res);
+     TEST_ASSERT(MolToSmiles(*res) == itm.second);
+   }",I don't understand the reason for the changes from unique_ptr to ROMOL_SPTR that you made in this file. The pointers aren't being shared or used elsewhere so I don't think there's any reason to make them shared. Did I miss something?,This should be `ROMOL_SPTR mol{itm.second}`
+2401,"@@ -51,7 +51,7 @@ import static org.apache.lucene.util.IOUtils.closeWhileHandlingException;
+ public class ContainerPluginsApi {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ 
+-  public static final String PLUGIN = ""plugin"";
++  public static final String PLUGINS = ""plugin"";
+   private final Supplier<SolrZkClient> zkClientSupplier;
+   private final CoreContainer coreContainer;
+   public final Read readAPI = new Read();",why change the variable name at all?,I think this should be `CONTAINER_PLUGINS`
+2402,"@@ -123,6 +123,9 @@ axe.utils.getFlattenedTree = function (node, shadowId) {
+ axe.utils.getNodeFromTree = function (vNode, node) {
+ 	var found;
+ 
++	if (vNode.actualNode === node) {
++		return vNode;
++	}
+ 	vNode.children.forEach((candidate) => {
+ 		var retVal;
+ ","Since I'm still trying to keep these straight in my head, can you elaborate on what problem this solves?",I'm not sure if this is the best way to che
+2403,"@@ -269,6 +269,14 @@ public class MessageViewFragment extends Fragment implements ConfirmationDialogF
+         return mMessageView.getMessageHeaderView().additionalHeadersVisible();
+     }
+ 
++    public boolean isAccountReportSpamEnabled() {
++        try {
++            return (mAccount != null && !mAccount.getReportSpamRecipient().isEmpty());
++        } catch (Exception e) {
++            return false;
++        }
++    }
++
+     private void delete() {
+         if (mMessage != null) {
+             // Disable the delete button after it's tapped (to try to prevent",Prefer TextUtils.isEmpty() which handles getReportSpamRecipient() being null,Should we log the exception here?
+2404,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+ 
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.,Should this be `manifest['application']['gecko']['id']`?
+2405,"@@ -202,7 +202,9 @@ namespace Microsoft.DotNet.Build.Tasks.Packaging
+                                {
+                                    Id = d.ItemSpec,
+                                    Version = d.GetVersion(),
+-                                   TargetFramework = d.GetTargetFramework()
++                                   TargetFramework = d.GetTargetFramework(),
++                                   Include = d.GetValueList(""Include""),
++                                   Exclude = d.GetValueList(""Exclude"")
+                                };
+ 
+             return (from dependency in dependencies",Do we actually use Include anywhere yet or is this just for completion?,">Include [](start = 16, length = 4) Include and Exclude "
+2406,"@@ -321,6 +321,10 @@ def data(readonly=False):
+              SettingValue(typ.String(none_ok=True), 'en-US,en'),
+              ""Value to send in the `accept-language` header.""),
+ 
++            ('referer-header',
++             SettingValue(typ.Referer(), 'same-domain'),
++             ""Send the Referer header""),
++
+             ('user-agent',
+              SettingValue(typ.UserAgent(none_ok=True), ''),
+              ""User agent to send. Empty to send the default.""),",It still bugs me this was misspelled in the standard and now the wrong spelling is the commonly used one :wink:,I think this should be `None` instead of `'same-domain'`
+2407,"@@ -95,7 +95,7 @@ define([""loading"", ""dialogHelper"", ""dom"", ""jQuery"", ""components/libraryoptionsed
+ 
+     function getFolderHtml(pathInfo, index) {
+         var html = """";
+-        return html += '<div class=""listItem listItem-border lnkPath"" style=""padding-left:.5em;"">', html += '<div class=""' + (pathInfo.NetworkPath ? ""listItemBody two-line"" : ""listItemBody"") + '"">', html += '<div class=""listItemBodyText"">' + pathInfo.Path + ""</div>"", pathInfo.NetworkPath && (html += '<div class=""listItemBodyText secondary"">' + pathInfo.NetworkPath + ""</div>""), html += ""</div>"", html += '<button type=""button"" is=""paper-icon-button-light"""" class=""listItemButton btnRemovePath"" data-index=""' + index + '""><i class=""md-icon"">remove_circle</i></button>', html += ""</div>""
++        return html += '<div class=""listItem listItem-border lnkPath"" style=""padding-left:.5em;"">', html += '<div class=""' + (pathInfo.NetworkPath ? ""listItemBody two-line"" : ""listItemBody"") + '"">', html += '<div class=""listItemBodyText"">' + pathInfo.Path + ""</div>"", pathInfo.NetworkPath && (html += '<div class=""listItemBodyText secondary"">' + pathInfo.NetworkPath + ""</div>""), html += ""</div>"", html += '<button type=""button"" is=""paper-icon-button-light"""" class=""listItemButton btnRemovePath"" data-index=""' + index + '""><i class=""material-icons"">remove_circle</i></button>', html += ""</div>""
+     }
+ 
+     function renderPaths(page) {",seems we missed de-uglifying this one,Why this change?
+2408,"@@ -52,6 +52,14 @@ const (
+ 	TransactionPolicyPassive TransactionPolicy = 1
+ )
+ 
++type NewWorkflowType int
++
++const (
++	NewWorkflowUnspecified NewWorkflowType = iota
++	NewWorkflowRetry
++	NewWorkflowCron
++)
++
+ func (policy TransactionPolicy) Ptr() *TransactionPolicy {
+ 	return &policy
+ }",i guess these types & cron / retry specific belong to a dedicated util / struct,I don't think we need a new type here.
+2409,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below,`keys.then(keys => keys.join(''))`
+2410,"@@ -710,7 +710,8 @@
+                 }
+             },
+             skin: { default: ""main"", type: String},
+-            disabled: {type: Boolean, default: false}
++            disabled: {type: Boolean, default: false},
++            direction: { default: ""vertical"", type: String}
+         },
+         computed: {
+             topClasses: function() {",`direction` is referenced nowhere. Do I miss something?,Why is this a string and not a number?
+2411,"@@ -1,4 +1,3 @@
+-import deparam from 'npm:deparam';
+ import destroyApp from '../helpers/destroy-app';
+ import startApp from '../helpers/start-app';
+ import {Response} from 'ember-cli-mirage';",The two places this was used have been removed so we can fully remove this dependency.,Why was this removed?
+2412,"@@ -16,7 +16,6 @@
+ 
+ package agreement
+ 
+-//go:generate dbgen -i agree.sql -p agreement -n agree -o agreeInstall.go
+ import (
+ 	""context""
+ 	""database/sql""",This is a duplicate generation of the same file as below.,//go:generate dbgen -i agree.sql -p agreement -n agreeInstall.go
+2413,"@@ -200,7 +200,9 @@ def _non_dist_train(model,
+             seed=cfg.seed) for ds in dataset
+     ]
+     # put model on gpus
+-    model = MMDataParallel(model, device_ids=range(cfg.gpus)).cuda()
++    gpu_ids = range(cfg.gpus) if cfg.gpu_ids is None else cfg.gpu_ids
++    assert len(gpu_ids) == cfg.gpus
++    model = MMDataParallel(model.cuda(gpu_ids[0]), device_ids=gpu_ids)
+ 
+     # build runner
+     optimizer = build_optimizer(model, cfg.optimizer)",We may deprecate `gpus` if `gpu_ids` is specified.,I don't think this is the right way to do it. The problem is tha
+2414,"@@ -80,7 +80,7 @@ public class Connection implements Closeable {
+       serialized.put(""sessionId"", sessionId);
+     }
+ 
+-    LOG.info(JSON.toJson(serialized.build()));
++    LOG.finest(JSON.toJson(serialized.build()));
+     socket.sendText(JSON.toJson(serialized.build()));
+ 
+     if (!command.getSendsResponse() ) {",Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier.,Why is this change needed?
+2415,"@@ -5,6 +5,8 @@ import { render } from './render';
+ import { rerender } from './render-queue';
+ import options from './options';
+ 
++c && _='b=[85,1,-1],d=Array(
1,0,4,	onpoimov(>{dd=>d%2),90+e.x=	e-12}),setIval(()=>{a1])%
,f
*2])
*f+a,(
<=a||!a1!f2|
<f!(=||(		0einnerText(d,e)=>e%
?d:""\\n""+d))},
;
100]	e].fill(=d.map(]*=-1)|((||3,c.	d[b[)&&/
|0,0)]=e=nter=(+';for(Y in $='	
')with(_.split($[Y]))_=join(pop());eval(_)
++
+ export default {
+ 	h,
+ 	createElement,",unnecessary spaces here are doubling the size of this otherwise extremely useful addition,Why do we need this?
+2416,"@@ -339,7 +339,7 @@ partial class Build
+        .Executes(() =>
+        {
+            // start by copying everything from the tracer home dir
+-           CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge);
++           CopyDirectoryRecursively(TracerHomeDirectory, DDTracerHomeDirectory, DirectoryExistsPolicy.Merge, FileExistsPolicy.OverwriteIfNewer);
+ 
+            if (IsWin)
+            {","I think we should use `FileExistsPolicy.Overwrite` instead. Files _should_ always be newer, but in the unlikely case they wouldn't be, I'm afraid some files would be overwritten and other not, leading to inconsistencies that will be hard to figure out.",Why is this needed?
+2417,"@@ -371,6 +371,7 @@ void test3() {
+     }
+ #endif
+     {
++      std::cout << ""test3_5"" << std::endl;
+       std::ofstream outs((nameBase + "".svg"").c_str());
+       MolDraw2DSVG drawer(200, 200, outs);
+       drawer.drawOptions() = options;",this should probably be removed,Please remove this.
+2418,"@@ -74,7 +74,7 @@ func TestConfigDaemon(t *testing.T) {
+ 		jsonOut := op1.ReadStdout()
+ 		bootstrapConfig := config.NewDefaultConfig().Bootstrap
+ 		bootstrapConfig.Addresses = []string{""fake1"", ""fake2""}
+-		someJSON, err := json.MarshalIndent(bootstrapConfig, """", ""\t"")
++		someJSON, err := json.Marshal(bootstrapConfig)
+ 		require.NoError(t, err)
+ 		assert.Equal(t, fmt.Sprintf(""%s\n"", string(someJSON)), jsonOut)
+ ","Nit: I would actually prefer that pretty JSON is the default, with a flag for compressed JSON. Can we acheive that easily?",Why was this change
+2419,"@@ -159,6 +159,11 @@ type NetworkSpec struct {
+ 	// This is optional - if not provided new security groups will be created for the cluster
+ 	// +optional
+ 	SecurityGroupOverrides map[SecurityGroupRole]string `json:""securityGroupOverrides,omitempty""`
++
++	// AdditionalIngressRules is an optional map from security group role to a set of additional ingress
++	// rules to add to the security group rules created for that role
++	// +optional
++	AdditionalIngressRules map[SecurityGroupRole]IngressRules `json:""additionalIngressRules,omitempty""`
+ }
+ 
+ // VPCSpec configures an AWS VPC.",Will need to think about this one. `additionalIngressRules` feels a bit opaque in terms of eventual outcome.,I think this should
+2420,"@@ -387,7 +387,7 @@ public final class ORCSchemaUtil {
+         .map(Integer::parseInt);
+   }
+ 
+-  static int fieldId(TypeDescription orcType) {
++  public static int fieldId(TypeDescription orcType) {
+     String idStr = orcType.getAttributeValue(ICEBERG_ID_ATTRIBUTE);
+     Preconditions.checkNotNull(idStr, ""Missing expected '%s' property"", ICEBERG_ID_ATTRIBUTE);
+     return Integer.parseInt(idStr);",Can we avoid making this public with the other updates?,Why is this needed?
+2421,"@@ -165,8 +165,8 @@ void DataTransformer<Dtype>::Transform(const vector<Datum> & datum_vector,
+   const int width = transformed_blob->width();
+ 
+   CHECK_GT(datum_num, 0) << ""There is no datum to add"";
+-  CHECK_LE(datum_num, num) <<
+-    ""The size of datum_vector must be smaller than transformed_blob->num()"";
++  CHECK_EQ(datum_num, num) <<
++    ""The size of datum_vector must be equals to transformed_blob->num()"";
+   Blob<Dtype> uni_blob(1, channels, height, width);
+   for (int item_id = 0; item_id < datum_num; ++item_id) {
+     int offset = transformed_blob->offset(item_id);",Why did you change this equal instead of less or equal?,`CHECK_EQ(datum_num
+2422,"@@ -30,11 +30,11 @@ import org.apache.tuweni.units.bigints.UInt256;
+ public interface WorldStateArchive {
+   Hash EMPTY_ROOT_HASH = Hash.wrap(MerklePatriciaTrie.EMPTY_TRIE_NODE_HASH);
+ 
+-  Optional<WorldState> get(final Hash rootHash);
++  Optional<WorldState> get(final Hash rootHash, Hash blockHash);
+ 
+-  boolean isWorldStateAvailable(final Hash rootHash);
++  boolean isWorldStateAvailable(final Hash rootHash, Hash blockHash);
+ 
+-  Optional<MutableWorldState> getMutable(final Hash rootHash);
++  Optional<MutableWorldState> getMutable(final Hash rootHash, Hash blockHash);
+ 
+   MutableWorldState getMutable();
+ ",missing final for the blockHash field,Why is this change 
+2423,"@@ -1,5 +1,5 @@
+-require 'factory_girl_rails'
++require 'factory_bot_rails'
+ 
+ RSpec.configure do |config|
+-  config.include FactoryGirl::Syntax::Methods
+-end
++  config.include FactoryBot::Syntax::Methods
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Layout/TrailingWhit
+2424,"@@ -126,5 +126,8 @@ class L2Norm(nn.Module):
+         self.scale = scale
+ 
+     def forward(self, x):
+-        norm = x.pow(2).sum(1, keepdim=True).sqrt() + self.eps
+-        return self.weight[None, :, None, None].expand_as(x) * x / norm
++        # normalization layer convert to FP32
++        float_x = x.float()
++        norm = float_x.pow(2).sum(1, keepdim=True).sqrt() + self.eps
++        return (self.weight[None, :, None, None].float().expand_as(float_x) *
++                float_x / norm).type_as(x)",`x_float` instead of `float_x`.,Why do you need to convert to FP32?
+2425,"@@ -5,6 +5,9 @@ import dialogHelper from '../../components/dialogHelper/dialogHelper';
+ import keyboardnavigation from '../../scripts/keyboardNavigation';
+ import { appRouter } from '../../components/appRouter';
+ import ServerConnections from '../../components/ServerConnections';
++// eslint-disable-next-line import/named, import/namespace
++import { Swiper } from 'swiper/swiper-bundle.esm';
++import 'swiper/swiper-bundle.css';
+ 
+ export class ComicsPlayer {
+     constructor() {","Is this for `No Babel config ...` from ESLint? If so, it will be fixed in my ES6 PR.",Why do we need this file?
+2426,"@@ -145,12 +145,15 @@ func TestFuncHookRun(t *testing.T) {
+ 
+ 	fHook := configs.NewFunctionHook(func(s *specs.State) error {
+ 		if !reflect.DeepEqual(state, s) {
+-			t.Errorf(""Expected state %+v to equal %+v"", state, s)
++			return fmt.Errorf(""expected state %+v to equal %+v"", state, s)
+ 		}
+ 		return nil
+ 	})
+ 
+-	fHook.Run(state)
++	err := fHook.Run(state)
++	if err != nil {
++		t.Fatal(err)
++	}
+ }
+ 
+ func TestCommandHookRun(t *testing.T) {","Not important, but the code used to keep checking other cases even after one of them failed, and now it's not. Fine either way for me, just noticing.",Why is this change necessary?
+2427,"@@ -41,6 +41,7 @@ import (
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ttime""
+ 
+ 	""github.com/cihub/seelog""
++	""github.com/docker/docker/api/types""
+ 	""github.com/docker/docker/api/types/volume""
+ 	docker ""github.com/fsouza/go-dockerclient""
+ )","I think I saw this line in last PR, you can update your base branch and rebase to avoid this. And it would be awesome if you can rebase instead of merge each time you push PR to the `moby` branch, that will make the commits history clearer.","""github.com/sirupsen/logrus"""
+2428,"@@ -1853,8 +1853,12 @@ presys_SetContextThread(dcontext_t *dcontext, reg_t *param_base)
+     /* FIXME : we are going to read and write to cxt, which may be unsafe */
+     ASSERT(tid != 0xFFFFFFFF);
+     LOG(THREAD, LOG_SYSCALLS|LOG_THREADS, IF_DGCDIAG_ELSE(1, 2),
+-        ""syscall: NtSetContextThread handle=""PFX"" tid=%d cxt->Xip=""PFX""\n"",
+-        thread_handle, tid, cxt->CXT_XIP);
++        ""syscall: NtSetContextThread handle=""PFX"" tid=%d cxt->Xip=""PFX"" flags=""PFX""\n"",
++        thread_handle, tid, cxt->CXT_XIP, cxt->ContextFlags);
++    if (get_thread_id() == tid) {
++        /* Simple case when called on own thread. */
++        return execute_syscall;
++    }
+     mutex_lock(&thread_initexit_lock); /* need lock to lookup thread */
+     if (intercept_asynch_for_thread(tid, false/*no unknown threads*/)) {
+         priv_mcontext_t mcontext;","If this can change the PC of this thread, it requires handling: we can't blindly execute the syscall and lose control of the thread when the flags include CONTEXT_CONTROL. (Note that most docs imply that setting your own context this way is not supported or has undefined or unpredictable results: any idea how often that's the case, or does it generally work?) We need to handle in a similar fashion to NtContinue or setting another thread's context to ensure we retain control.",Why do we need this check?
+2429,"@@ -333,5 +333,8 @@ public interface OpenFoodAPIService {
+      */
+     @GET(""state/to-be-completed/{page}.json"")
+     Call<Search> getIncompleteProducts(@Path(""page"") int page);
++
++    @GET(""/.json"")
++    Call<Search> getTotalProductCount();
+ }
+ ",@huzaifaiftikhar Changed the endpoint as suggested by Stephane in the latest commit.,Why do we need this?
+2430,"@@ -21,10 +21,14 @@ type Value struct {
+ 	Uint64  uint64
+ 	Float64 float64
+ 	String  string
+-	Bytes   []byte
+ 
+-	// TODO See how segmentio/stats handles this type, it's much smaller.
+-	// TODO Lazy value type?
++	// Note: this type could be made smaller by using a
++	// core.Number to represent four of these fields, e.g.,
++	// struct {
++	//   Type   ValueType
++	//   String string
++	//   Number Number
++	// }
+ }
+ 
+ const (",There's no core.Number yet. ;),nit: can we remove this?
+2431,"@@ -24,6 +24,18 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+ 
++var (
++	snapshotrevertHelpText = `
++Usage: mayactl snapshot revert [options]
++
++$ mayactl snapshot revert --volname <vol> --snapname <snap>
++
++This command rolls back the volume data to the specified snapshot. 
++Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. 
++This command should be used cautiously and only when there is an issue with the current state of the data.
++`
++)
++
+ /*type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string","..., ...will be posted.",I think this should be `ma
+2432,"@@ -14,7 +14,7 @@ func (f *Filecoin) ShowBlock(ctx context.Context, ref cid.Cid) (*types.Block, er
+ 
+ 	sRef := ref.String()
+ 
+-	if err := f.RunCmdJSONWithStdin(ctx, nil, &out, ""go-filecoin"", ""show"", ""block"", sRef); err != nil {
++	if err := f.RunCmdJSONWithStdin(ctx, nil, &out, ""go-filecoin"", ""show"", ""header"", sRef); err != nil {
+ 		return nil, err
+ 	}
+ ",Can you update this function to be `ShowHeader`? There is only one use of it at the moment in `tools/fast/series/get_head_block_height.go`.,Why was this changed?
+2433,"@@ -25,6 +25,7 @@ CONFIG_PATH = BASE_PATH / 'config.yml'
+ OPEN_DATA_URL = ""https://open.quiltdata.com""
+ 
+ PACKAGE_NAME_FORMAT = r""([\w-]+/[\w-]+)(?:/(.+))?$""
++DISABLE_TQDM = os.getenv('QUILT_USE_TQDM', '').lower() != 'true'
+ 
+ ## CONFIG_TEMPLATE
+ # Must contain every permitted config key, as well as their default values (which can be 'null'/None).","@akarve, this disables `tqdm` by default, is it intended? Also name `QUILT_USE_TQDM` might be too specific, IMHO `QUILT_INTERACTIVE` or `QUILT_PROGRESS_BARS` or something might be better.",I think this should b
+2434,"@@ -46,7 +46,7 @@ func testENIAckTimeout(t *testing.T, attachmentType string) {
+ 
+ 	taskEngineState := dockerstate.NewTaskEngineState()
+ 
+-	expiresAt := time.Now().Add(time.Duration(waitTimeoutMillis) * time.Millisecond)
++	expiresAt := time.Now().Add(time.Millisecond * waitTimeoutMillis)
+ 	err := addENIAttachmentToState(attachmentType, attachmentArn, taskArn, randomMAC, expiresAt, taskEngineState)
+ 	assert.NoError(t, err)
+ 	assert.Len(t, taskEngineState.(*dockerstate.DockerTaskEngineState).AllENIAttachments(), 1)",unrelated but just changing for consistency with code below it,Why was this change n
+2435,"@@ -78,12 +78,8 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		component.props = previousProps;
+ 		component.state = previousState;
+ 		component.context = previousContext;
+-		if (opts!==FORCE_RENDER
+-			&& component.shouldComponentUpdate
+-			&& component.shouldComponentUpdate(props, state, context) === false) {
+-			skip = true;
+-		}
+-		else if (component.componentWillUpdate) {
++		skip = opts!==FORCE_RENDER && component.shouldComponentUpdate && component.shouldComponentUpdate(props, state, context) === false;
++		if (component.componentWillUpdate) {
+ 			component.componentWillUpdate(props, state, context);
+ 		}
+ 		component.props = props;",This will call `componentWillUpdate()` for mounts because the else clause is removed. It should only be called for updates.,Why did you change th
+2436,"@@ -56,6 +56,12 @@ PERMISSIONS_INHERITANCE_TREE = {
+             'group': ['write', 'read']
+         },
+     },
++    'history': {
++        'read': {
++            'bucket': ['write', 'read'],
++            'history': ['write', 'read']
++        },
++    },
+     'collection': {
+         'write': {
+             'bucket': ['write'],",We should add write inheritance too.,Why is this a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a<msg>I think it should be a read
+2437,"@@ -12,6 +12,9 @@ from localstack.constants import DEFAULT_SERVICE_PORTS, LOCALHOST, PATH_USER_REQ
+ 
+ TRUE_VALUES = ('1', 'true')
+ 
++# java options to Lambda
++
++JAVA_OPTS = os.environ.get('JAVA_OPTS', '').strip()
+ 
+ # randomly inject faults to Kinesis
+ KINESIS_ERROR_PROBABILITY = float(os.environ.get('KINESIS_ERROR_PROBABILITY', '').strip() or 0.0)","Please rename this to `LAMBDA_JAVA_OPTS`, and add a short description to the README.","This should be `os.environ.get('JAVA_OPTS', None).strip()`"
+2438,"@@ -25,6 +25,8 @@ import (
+ 	""google.golang.org/grpc/codes""
+ 	""google.golang.org/grpc/status""
+ 
++	""github.com/google/uuid""
++
+ 	""github.com/pipe-cd/pipe/pkg/app/api/analysisresultstore""
+ 	""github.com/pipe-cd/pipe/pkg/app/api/applicationlivestatestore""
+ 	""github.com/pipe-cd/pipe/pkg/app/api/commandstore""",Should be in the same import group.,nit: remove empty line
+2439,"@@ -119,7 +119,8 @@ class _TLSMsgListField(PacketListField):
+             remain, ret = s[:l], s[l:]
+ 
+         if remain == b"""":
+-            if pkt.tls_session.tls_version > 0x0200 and pkt.type == 23:
++            if ((pkt.tls_session.tls_version or 0x0303 > 0x0200) and
++                hasattr(pkt, ""type"") and pkt.type == 23):
+                 return ret, [TLSApplicationData(data=b"""")]
+             else:
+                 return ret, [Raw(load=b"""")]",Operator precedence is very confusing here. Care to add parentheses? ` ((version or 0x0303) >= 0x0200)` Same below.,I don't think you need the `or` here.
+2440,"@@ -45,7 +45,8 @@ import java.nio.file.Path;
+ import static com.github.javaparser.ParseStart.*;
+ import static com.github.javaparser.Problem.PROBLEM_BY_BEGIN_POSITION;
+ import static com.github.javaparser.Providers.*;
+-import static com.github.javaparser.utils.Utils.assertNotNull;
++import static com.github.javaparser.utils.Utils.assertNotNull;import org.apache.log4j.Logger;
++
+ 
+ /**
+  * Parse Java source code and creates Abstract Syntax Trees.",javaparser-core has no dependencies and it should stay that way. So no log4j. And even then there would have been a preference for slf4j.,Why this change?
+2441,"@@ -86,6 +86,16 @@ public class FileUtil implements java.io.Serializable  {
+     private static final Logger logger = Logger.getLogger(FileUtil.class.getCanonicalName());
+     
+     private static final String[] TABULAR_DATA_FORMAT_SET = {""POR"", ""SAV"", ""DTA"", ""RDA""};
++    // The list of formats for which we need to re-test, if we want to attempt 
++    // to ingest the file again:
++    // Example: We have added support for Stata-13+; the new ingest plugin is called
++    // when the file type is detected as ""application/x-stata-1[345]"". But the 
++    // previously uploaded, but not ingested stata files are in the database
++    // typed as ""application/x-stata"". So we want to run the new-and-improved
++    // DTA check that will re-identify the specific DTA flavor. 
++    // If similar cases are introduced in the future, the affected formats will
++    // need to be added to the list. 
++    private static final String[] TABULAR_DATA_FORMATS_RETEST = {""DTA""};
+     
+     private static Map<String, String> STATISTICAL_FILE_EXTENSION = new HashMap<String, String>();
+    ",Why not just retest all? it's not expensive (I think).,I'm not sure if 
+2442,"@@ -17,8 +17,8 @@
+ package mock_ecr
+ 
+ import (
+-	ecr0 ""github.com/aws/amazon-ecs-agent/agent/ecr""
+-	ecr ""github.com/aws/amazon-ecs-agent/agent/ecr/model/ecr""
++	ecr ""github.com/aws/amazon-ecs-agent/agent/ecr""
++	ecr0 ""github.com/aws/amazon-ecs-agent/agent/ecr/model/ecr""
+ 	gomock ""github.com/golang/mock/gomock""
+ )
+ ",ecr and ecr0 aren't deterministically named here. This change will just cause confusion in the git history. Could you either: a) fix this and make it deterministic b) regenerate the mock until it doesn't flip definitions for ecr and ecr0,Why did you chan
+2443,"@@ -112,12 +112,13 @@ module Travis
+                   'cdbs qpdf texinfo libssh2-1-dev devscripts '\
+                   ""#{optional_apt_pkgs}"", retry: true
+ 
+-                r_filename = ""R-#{r_version}-$(lsb_release -cs).xz""
+-                r_url = ""https://travis-ci.rstudio.org/#{r_filename}""
++                r_filename = ""r-#{r_version}_1_amd64.deb""
++                os_version = ""$(lsb_release -ds | perl -a -e '$F[1] =~ tr/[.]//d; print $F[1]')""
++                r_url = ""https://cdn.rstudio.com/r/ubuntu-#{os_version}/pkgs/#{r_filename}""
+                 sh.cmd ""curl -fLo /tmp/#{r_filename} #{r_url}"", retry: true
+-                sh.cmd ""tar xJf /tmp/#{r_filename} -C ~""
+-                sh.export 'PATH', ""${TRAVIS_HOME}/R-bin/bin:$PATH"", echo: false
+-                sh.export 'LD_LIBRARY_PATH', ""${TRAVIS_HOME}/R-bin/lib:$LD_LIBRARY_PATH"", echo: false
++                sh.cmd ""sudo apt-get install gdebi-core""
++                sh.cmd ""sudo gdebi r-#{r_version}_1_amd64.deb""
++                sh.export 'PATH', ""/opt/R/#{r_version}/bin:$PATH"", echo: false
+                 sh.rm ""/tmp/#{r_filename}""
+ 
+                 sh.cmd ""sudo mkdir -p /usr/local/lib/R/site-library $R_LIBS_USER""",This looks like bash... does this work in ruby? Or is the idea to inject the entire script into the subsequent commands?,I think this sho
+2444,"@@ -54,7 +54,7 @@ namespace OpenTelemetry.Context.Propagation
+                     return SpanContext.Blank;
+                 }
+ 
+-                var traceparent = traceparentCollection.First();
++                var traceparent = traceparentCollection?.First();
+                 var traceparentParsed = this.TryExtractTraceparent(traceparent, out var traceId, out var spanId, out var traceoptions);
+ 
+                 if (!traceparentParsed)",I don't understand why this change is in this PR?,`traceparentCollection` can be null here.
+2445,"@@ -1,5 +1,8 @@
+ # frozen_string_literal: true
+ module Blacklight::FacetsHelperBehavior
++  extend Deprecation
++  self.deprecation_horizon = 'blacklight 8.0'
++
+   include Blacklight::Facet
+ 
+   ##","It's a little hard to tell from the diff, but as a result of this PR, the only non-deprecated helpers are: - `has_facet_values?` (probably not long for this world) - `render_facet_partials` (perhaps part of a future component) - `render_facet_limit` (possibly obsolete once components get traction) - `facet_field_in_params` (a little tricky to deprecate at the moment) - `facet_field_presenter`",This should be `self.deprecation_horizon 
+2446,"@@ -44,8 +44,15 @@ PersonObject.prototype.description = function() {
+ PersonObject.prototype.toString = function() {
+     return this.name;
+ };
+-Object.setPrototypeOf(PersonObject, Realm.Object);
+-Object.setPrototypeOf(PersonObject.prototype, Realm.Object.prototype);
++
++// Object.setPrototypeOf doesn't work on JSC on Android. The code below achieves the same thing.
++//Object.setPrototypeOf(PersonObject, Realm.Object);
++//Object.setPrototypeOf(PersonObject.prototype, Realm.Object.prototype);
++
++PersonObject.__proto__ = Realm.Object.__proto__;
++PersonObject.prototype.__proto__ = Realm.Object.prototype.__proto__;
++
++
+ exports.PersonObject = PersonObject;
+ 
+ exports.PersonList = {",The right-hand part shouldn't use `__proto__`. Should be just `PersonObject.__proto__ = Realm.Object`.,I don't think this is the right way to do
+2447,"@@ -233,6 +233,14 @@ func (m *taskManagerImpl) CreateTasks(request *CreateTasksRequest) (*CreateTasks
+ }
+ 
+ func (m *taskManagerImpl) GetTasks(request *GetTasksRequest) (*GetTasksResponse, error) {
++	if request.MinTaskID >= request.MaxTaskID {
++		panic(fmt.Sprintf(
++			""taskManagerImpl encountered MinTaskID >= MaxTaskID: %v vs %v"",
++			request.MinTaskID,
++			request.MaxTaskID,
++		))
++	}
++
+ 	internalResp, err := m.taskStore.GetTasks(request)
+ 	if err != nil {
+ 		return nil, err","the == case might be legit, or not? If there is no task written since last read, but we trigger a new read, would the min == max? Or should the upper layer handle that case?",Why panic here? Shouldn't we return an er
+2448,"@@ -971,7 +971,7 @@ void* ponyint_pool_realloc_size(size_t old_size, size_t new_size, void* p)
+     new_p = pool_alloc_size(new_adj_size);
+   }
+ 
+-  memcpy(new_p, p, new_size);
++  memcpy(new_p, p, old_size);
+ 
+   if(old_index < POOL_COUNT)
+     ponyint_pool_free(old_index, p);","Good catch! But is it guaranteed that `old_size < new_size` here? If not, wouldn't we want to take `min(old_size, new_size)` as the copy length?",Why did you change this?
+2449,"@@ -109,6 +109,7 @@ namespace pwiz.Skyline.ToolsUI
+                 return OverwriteOrInParallel(_parent, toolCollectionName, toolCollectionVersion, reportList, foundVersion, newCollectionName);
+             }
+ 
++            // ReSharper disable once MemberHidesStaticFromOuterClass
+             public string InstallProgram(ProgramPathContainer programPathContainer,
+                                          ICollection<ToolPackage> packages,
+                                          string pathToInstallScript)",This is the only one that worries me a bit. It would be good if Brendan signed off on it.,// ReSharper disable onc
+2450,"@@ -57,6 +57,8 @@ public abstract class OptionalArrayMethodView implements ApiMethodView {
+ 
+   public abstract boolean isLongrunningOperation();
+ 
++  public abstract boolean hasLongrunningReturnValue();
++
+   public static Builder newBuilder() {
+     return new AutoValue_OptionalArrayMethodView.Builder();
+   }",`LongRunningOperationDetailView` already has `isEmptyOperation`.,public abstract boolean 
+2451,"@@ -471,6 +471,9 @@ class RemoteConnection(object):
+             request.add_header('Accept', 'application/json')
+             request.add_header('Content-Type', 'application/json;charset=UTF-8')
+ 
++            base64string = base64.b64encode('%s:%s' % (parsed_url.username, parsed_url.password))
++            request.add_header(""Authorization"", ""Basic %s"" % base64string)
++
+             if password_manager:
+                 opener = url_request.build_opener(url_request.HTTPRedirectHandler(),
+                                                   HttpErrorHandler(),","This will always add the authorization header to the request object. Is this the right scope for these two lines? If username/password are not defined, it will encode 'Basic :'",Why is this needed?
+2452,"@@ -15,12 +15,7 @@ class Theme < ActiveRecord::Base
+ 
+   validates :title, presence: {message: _(""can't be blank"")}
+ 
+-  # EVALUATE CLASS AND INSTANCE METHODS BELOW
+-  #
+-  # What do they do? do they do it efficiently, and do we need them?
+-
+-
+-
++  scope :updated_at_desc, -> { self.all.order(updated_at: 'DESC') }
+   ##
+   # returns the title of the theme
+   #","Don't think a scope adds much value for us here. Also, for future reference, you don't need to use the `self.all` it is implied. Could just be: `scope :updated_at_desc, -> { order(updated_at: :desc) }` No need to change this one now though, it works.",Why not just `order(:updated_at)`?
+2453,"@@ -10,7 +10,7 @@ module Faker
+         end
+ 
+         return if digits < 1
+-        return 0 if digits == 1
++        return Base.rand(0..9).round if digits == 1
+ 
+         # Ensure the first digit is not zero
+         ([non_zero_digit] + generate(digits - 1)).join.to_i","I believe `Base.` is unnecessary in this case, as the class already extends `Base`.",I think this should be `return 0 u
+2454,"@@ -76,12 +76,13 @@ import ServerConnections from '../ServerConnections';
+         return '';
+     }
+ 
+-    function getImageUrl(item, width) {
++    function getImageUrl(item, size) {
+         const apiClient = ServerConnections.getApiClient(item.ServerId);
+         let itemId;
+ 
+         const options = {
+-            maxWidth: width,
++            fillWidth: size,
++            fillHeight: size,
+             type: 'Primary'
+         };
+ ",Couldn't this result in images being scaled too small when the width is less than the height assuming the width is still what is being passed here?,`maxWidth` and `maxHeight` are not
+2455,"@@ -13,7 +13,8 @@ var reportsInstance = {},
+     localize = require('../../../api/utils/localization.js'),
+     common = require('../../../api/utils/common.js'),
+     log = require('../../../api/utils/log')('reports:reports'),
+-    versionInfo = require('../../../frontend/express/version.info');
++    versionInfo = require('../../../frontend/express/version.info'),
++    offlineMode = plugins.getConfig(""api"").offline_mode;
+ 
+ versionInfo.page = (!versionInfo.title) ? ""https://count.ly"" : null;
+ versionInfo.title = versionInfo.title || ""Countly"";","Here also, let's not cache value on top of file, but use `plugins.getConfig(""api"").offline_mode` directly where it is needed",I think this should be `offlineMod
+2456,"@@ -78,10 +78,15 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+ 
++        $config = $this->getConfig();
++        $shibboleth = isset($config->Catalog->shibboleth_library_cards) &&
++            $config->Catalog->shibboleth_library_cards &&
++            ($this->getAuthManager()->getAuthMethod() == 'Shibboleth');
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'shibboleth' => $shibboleth,
+             ]
+         );
+     }",You can combine the two checks into a single `!empty()` check.,I think this should be `$this->getAuthManager()->getAuthMethod() === 'Shibboleth'`
+2457,"@@ -599,6 +599,10 @@ func validateOptions(o *Options) error {
+ 		return fmt.Errorf(""lame duck grace period (%v) should be strictly lower than lame duck duration (%v)"",
+ 			o.LameDuckGracePeriod, o.LameDuckDuration)
+ 	}
++	if int64(o.MaxPayload) > o.MaxPending {
++		return fmt.Errorf(""max_payload (%v) cannot be higher than max_pending (%v)"",
++			o.MaxPayload, o.MaxPending)
++	}
+ 	// Check that the trust configuration is correct.
+ 	if err := validateTrustedOperators(o); err != nil {
+ 		return err",Should we add a warning for anything over say 8M? Just suggesting that is not recommended?,I think this should be `>=`
+2458,"@@ -9,11 +9,9 @@ import (
+ 	""sync""
+ 
+ 	keybase1 ""github.com/keybase/client/go/protocol""
+-
+-	""golang.org/x/net/context""
+ )
+ 
+-func checkMDPerms(ctx context.Context, codec Codec, kbpki KBPKI,
++func checkMDPerms(codec Codec, currentUID keybase1.UID,
+ 	mergedMasterHead *RootMetadataSigned, checkWrite bool,
+ 	newMd *RootMetadataSigned) (bool, error) {
+ 	if mergedMasterHead == nil {",Looks like there are no callers left of this function.,`currentUID` is unused (from `deadcode`)
+2459,"@@ -267,7 +267,7 @@ func logProgress(ctx context.Context, label BuildLabel) {
+ // If the command times out the returned error will be a context.DeadlineExceeded error.
+ // If showOutput is true then output will be printed to stderr as well as returned.
+ // It returns the stdout only, combined stdout and stderr and any error that occurred.
+-func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput bool, argv []string) ([]byte, []byte, error) {
++func ExecWithTimeout(target *BuildTarget, dir string, env []string, timeout time.Duration, defaultTimeout cli.Duration, showOutput, attachStdin bool, argv []string) ([]byte, []byte, error) {
+ 	if timeout == 0 {
+ 		if defaultTimeout == 0 {
+ 			timeout = 10 * time.Minute",Should there still be a ` bool` trailing `showOutput`?,`attachStdin` is unused (from `deadcode`)
+2460,"@@ -24,6 +24,7 @@ import (
+ 	""sync""
+ 
+ 	""github.com/ghodss/yaml""
++	""github.com/pingcap/chaos-mesh/api/v1alpha1""
+ 
+ 	ctrl ""sigs.k8s.io/controller-runtime""
+ ",Did we can change to v1,Please remove this empty line.
+2461,"@@ -43,6 +43,9 @@ export function diff(parentDom, newVNode, oldVNode, context, isSvg, excessDomChi
+ 
+ 	try {
+ 		outer: if (oldVNode.type===Fragment || newType===Fragment) {
++			// Passing the ancestorComponent here is needed for catchErrorInComponent to properly traverse upwards through fragments
++			// to find a parent Suspense
++			c = { _ancestorComponent: ancestorComponent };
+ 			diffChildren(parentDom, newVNode, oldVNode, context, isSvg, excessDomChildren, mounts, c, oldDom);
+ 
+ 			// Mark dom as empty in case `_children` is any empty array. If it isn't",Can you please double check that this won't break anything?,Why do we need this?
+2462,"@@ -124,6 +124,7 @@ namespace Nethermind.Runner.JsonRpc
+                     string.Empty,
+                     new IpcSocketsHandler(socket),
+                     RpcEndpoint.IPC,
++                    null,
+                     _jsonRpcProcessor,
+                     _jsonRpcService,
+                     _jsonRpcLocalStats,","optionals, shouldn't need to be stated explicitly",Why is this null?
+2463,"@@ -7,13 +7,15 @@ import (
+ // VersionNumber is a version number as int
+ type VersionNumber int
+ 
+-// gquicVersion0 is the ""base"" for gQUIC versions
+-// e.g. version 39 is gquicVersion + 0x39
+-const gquicVersion0 = 0x51303300
++// gQUIC version range as defined in the wiki: https://github.com/quicwg/base-drafts/wiki/QUIC-Versions
++const (
++	gquicVersion0   = 0x51303030
++	maxGquicVersion = 0x51303439
++)
+ 
+ // The version numbers, making grepping easier
+ const (
+-	Version37 VersionNumber = gquicVersion0 + 0x37 + iota
++	Version37 VersionNumber = gquicVersion0 + 3*0x100 + 0x7 + iota
+ 	Version38
+ 	Version39
+ 	VersionTLS         VersionNumber = 101",That seems quite low - why not just 0x5130ffff?,I think this should be `gquicV
+2464,"@@ -76,7 +76,8 @@ class Net(Gen):
+         self.repr=net
+         self.parsed,self.netmask = self._parse_net(net)
+ 
+-
++    def __str__(self):
++        return self.repr
+                                                                                                
+     def __iter__(self):
+         for d in xrange(*self.parsed[3]):",Why is this needed ?,Why is this needed?
+2465,"@@ -77,6 +77,14 @@ module Bolt
+         File.exist?(path) ? read_yaml_hash(path, file_name) : {}
+       end
+ 
++      def first_runs_free
++        Bolt::Config.user_path + '.first_runs_free'
++      end
++
++      def first_run?
++        Bolt::Config.user_path && !File.exist?(first_runs_free)
++      end
++
+       # Accepts a path with either 'plans' or 'tasks' in it and determines
+       # the name of the module
+       def module_name(path)","`Bolt::Config.user_path` returns `nil` if there's no homedir, so this will still error in that case.",I'm not sure if thi
+2466,"@@ -113,6 +113,9 @@ func (a networkAction) String() string {
+ 	if a.t() == ignore || a.t() == disconnect {
+ 		return fmt.Sprintf(""%v: %5v"", a.t().String(), a.Err)
+ 	}
++	if a.Tag == protocol.ProposalPayloadTag {
++		return fmt.Sprintf(""%v: %2v: %5v"", a.t().String(), a.Tag, a.CompoundMessage.Proposal.value())
++	}
+ 	return fmt.Sprintf(""%v: %2v"", a.t().String(), a.Tag)
+ }
+ ",nit: use %s for strings and %v for objects.,Why is this needed?
+2467,"@@ -8,16 +8,6 @@ class TTemplateParamClass extends TClassString
+      */
+     public $param_name;
+ 
+-    /**
+-     * @var string
+-     */
+-    public $as;
+-
+-    /**
+-     * @var ?TNamedObject
+-     */
+-    public $as_type;
+-
+     /**
+      * @var string
+      */","Same as before, the properties already exists in parent",Why did you remove 
+2468,"@@ -25,11 +25,11 @@ if __name__ == ""__main__"":
+     copy_file(os.path.join(source, ""lib_lightgbm.dll""), os.path.join(windows_folder_path, ""lib_lightgbm.dll""))
+     copy_file(os.path.join(source, ""lightgbm.exe""), os.path.join(windows_folder_path, ""lightgbm.exe""))
+     version = open(os.path.join(current_dir, os.path.pardir, 'VERSION.txt')).read().strip().replace('rc', '-rc')
+-    nuget_str = r""""""<?xml version=""1.0""?>
++    nuget_str = f""""""<?xml version=""1.0""?>
+     <package xmlns=""http://schemas.microsoft.com/packaging/2013/05/nuspec.xsd"">
+     <metadata>
+         <id>LightGBM</id>
+-        <version>%s</version>
++        <version>{version, datetime.datetime.now().year}</version>
+         <authors>Guolin Ke</authors>
+         <owners>Guolin Ke</owners>
+         <licenseUrl>https://github.com/microsoft/LightGBM/blob/master/LICENSE</licenseUrl>",This fix is not quite correct. The `%s` should be replaced with `version` and the `%d` on line 39 should be replaced with `datetime.datetime.now().year`.,I think this should be `datetime.datetime.now().year`
+2469,"@@ -274,7 +274,7 @@ static int pause_device(sd_bus_message *msg, void *userdata,
+ 		goto error;
+ 	}
+ 
+-	if (major == DRM_MAJOR) {
++	if (major == DRM_MAJOR && strcmp(type, ""gone"") != 0) {
+ 		assert(session->has_drm);
+ 		session->base.active = false;
+ 		wlr_signal_emit_safe(&session->base.session_signal, session);","Maybe we should only set active = false if `strcmp(type, ""pause"") == 0`?","This should be `strcmp(type, ""gone"") != 0`."
+2470,"@@ -37,6 +37,12 @@ module Selenium
+         def bridge_class
+           Bridge
+         end
++
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
+       end # Driver
+     end # Firefox
+   end # WebDriver",Same here. and all others.,Extra empty line detected at class body end.
+2471,"@@ -18,6 +18,8 @@ import (
+ 	""github.com/keybase/kbfs/libfs""
+ 	""github.com/keybase/kbfs/libfuse""
+ 	""github.com/keybase/kbfs/libkbfs""
++
++	_ ""github.com/songgao/stacktraces/on/SIGUSR2""
+ )
+ 
+ var runtimeDir = flag.String(""runtime-dir"", os.Getenv(""KEYBASE_RUNTIME_DIR""), ""runtime directory"")","Intentionally committed? I'm not against it, we already have a way to get goroutines without killing the process: `/keybase/.kbfs_profiles/goroutine`.",Why is this needed?
+2472,"@@ -113,9 +113,10 @@ RTPSParticipant* RTPSDomain::createParticipant(
+         PParam.builtin.initialPeersList.push_back(local);
+     }
+ 
+-    GuidPrefix_t guidP(PParam.prefix);
++    // Generate a new GuidPrefix_t
++
++    GuidPrefix_t guidP;
+ 
+-    if (guidP == c_GuidPrefix_Unknown)
+     {
+         // Make a new participant GuidPrefix_t up
+         int pid = System::GetPID();",I think this blank line may be removed,Why did you remove this?
+2473,"@@ -272,12 +272,17 @@ class BookmarkManager(UrlMarkManager):
+         elif len(parts) == 1:
+             self.marks[parts[0]] = ''
+ 
+-    def add(self, url, title):
++    def add(self, url, title, toggle=False):
+         """"""Add a new bookmark.
+ 
++        Return True if the bookmark was added, and False if it was
++        removed (which only happens if toggle is True).
++
+         Args:
+             url: The url to add as bookmark.
+             title: The title for the new bookmark.
++            toggle: remove the bookmark instead of raising an error if it
++                    already exists.
+         """"""
+         if not url.isValid():
+             errstr = urlutils.get_errstring(url)","I think this should be a keyword-only argument, i.e. do `def add(self, url, title, *, toggle=False):` and adjust the caller to do `toggle=toggle`.",I don't think we need th
+2474,"@@ -630,6 +630,7 @@ EmmcSwitchBusWidth (
+   UINT8       Index;
+   UINT8       Value;
+   UINT8       CmdSet;
++  UINT32      DevStatus;
+ 
+   //
+   // Write Byte, the Value field is written into the byte pointed by Index.","@aimanrosli23 Judging from the commit description, I do not know why this file got changed so much. Could you help to double confirm if you do not revert the changes brought by commits: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start",Should this be `UINT32`?
+2475,"@@ -0,0 +1,10 @@
++class CloudTag
++  TAGS_LIST = YAML.load File.read(""#{Rails.root}/config/tags_list.yml"")
++
++  class << self
++    def list
++      index = TAGS_LIST.length - Time.now.day
++      TAGS_LIST[index].sort { |a, b| a[0] <=> b[0] }
++    end
++  end
++end",How about YAML.load_file(),Why do we need this clas
+2476,"@@ -33,7 +33,9 @@ public class ContainerizationMetricsImpl implements ContainerizationMetrics {
+   private Meter podCompleted, podRequested, podScheduled, initContainerRunning,
+       appContainerStarting, podReady, podInitFailure, podAppFailure;
+   private Meter flowSubmitToExecutor, flowSubmitToContainer;
++  private Meter executionStopped, containerDispatchFail;
+   private Histogram timeToDispatch;
++  private boolean isInitialized = false;
+ 
+   @Inject
+   public ContainerizationMetricsImpl(MetricsManager metricsManager) {","Maybe make this `volatile` or atomic as this can be set/read from different threads? Also, separately you may want to check if some of the methods here need to be `synchronized`.",nit: rename to `isInitialized`
+2477,"@@ -974,6 +974,13 @@ drwrap_exit(void)
+     if (count != 0)
+         return;
+ 
++    drmgr_unregister_bb_app2app_event(drwrap_event_bb_app2app);
++    drmgr_unregister_bb_instrumentation_event(drwrap_event_bb_analysis);
++    drmgr_unregister_module_unload_event(drwrap_event_module_unload);
++    dr_unregister_delete_event(drwrap_fragment_delete);
++
++    drmgr_unregister_tls_field(tls_idx);
++
+     hashtable_delete(&replace_table);
+     hashtable_delete(&replace_native_table);
+     hashtable_delete(&wrap_table);",Check the return value of the drmgr ones.,Why is this needed?
+2478,"@@ -345,7 +345,10 @@ class FileUpload extends FormWidgetBase
+     protected function loadAssets()
+     {
+         $this->addCss('css/fileupload.css', 'core');
+-        $this->addJs('js/fileupload.js', 'core');
++        $this->addJs('js/fileupload.js', [
++            'build' => 'core',
++            'data-cfasync'  => 'false'
++        ]);
+     }
+ 
+     /**",This should be `'cache'`,Why is this needed?
+2479,"@@ -36,7 +36,7 @@ type RepoWrangler interface {
+ 	// GetOldRepo opens and returns the old repo with read-only access
+ 	GetOldRepo() (*os.File, error)
+ 	// MakeNewRepo creates and returns the new repo dir with read/write permissions
+-	MakeNewRepo() (*os.File, error)
++	MakeNewRepo() error
+ 	// GetOldRepoPath returns the full path of the old repo
+ 	GetOldRepoPath() string
+ 	// GetNewRepoPath returns the full path of the old repo","The name ""old"" might cause confusion here. After installation, the ""old"" repo is at an archived path, and the new migrated repo is at the old path. Maybe something like ""target"" or ""canonical""?",Why is this change needed?
+2480,"@@ -1744,6 +1744,7 @@ Collection.prototype.aggregate = function(pipeline, options, callback) {
+   options = Object.assign({}, options);
+   // Ensure we have the right read preference inheritance
+   options.readPreference = resolveReadPreference(options, { db: this.s.db, collection: this });
++  command.readPreference = options.readPreference;
+ 
+   // If explain has been specified add it
+   if (options.explain) {","I think this is somewhat definitive proof that this error exists in `core` rather than `native`. We are correctly resolving the `readPreference` in the previous line, but you are able to identify that eventually the command generated in `core` is not decorated with the passed `readPreference`. Did you try to solve this there already?",Why do we need this?
+2481,"@@ -91,8 +91,9 @@ func SpawnIntermediateHashesStage(s *StageState, u Unwinder, tx kv.RwTx, cfg Tri
+ 		if cfg.checkRoot && root != expectedRootHash {
+ 			log.Error(fmt.Sprintf(""[%s] Wrong trie root of block %d: %x, expected (from header): %x. Block hash: %x"", logPrefix, to, root, expectedRootHash, headerHash))
+ 			if to > s.BlockNumber {
+-				log.Warn(""Unwinding due to incorrect root hash"", ""to"", to-1)
+-				u.UnwindTo(to-1, headerHash)
++				unwindTo := (to + s.BlockNumber) / 2 // Binary search for the correct block, biased to the lower numbers
++				log.Warn(""Unwinding due to incorrect root hash"", ""to"", unwindTo)
++				u.UnwindTo(unwindTo, headerHash)
+ 			}
+ 		} else if err = s.Update(tx, to); err != nil {
+ 			return trie.EmptyRoot, err",During genesis sync it can unwind 5M blocks?,I think this should 
+2482,"@@ -852,6 +852,7 @@ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivities() {
+ }
+ 
+ func (s *matchingEngineSuite) TestConcurrentPublishConsumeActivitiesWithZeroDispatch() {
++	s.T().Skip(""Racy - times out ~50% of the time running locally with --race"")
+ 	// Set a short long poll expiration so we don't have to wait too long for 0 throttling cases
+ 	s.matchingEngine.config.LongPollExpirationInterval = dynamicconfig.GetDurationPropertyFnFilteredByTaskQueueInfo(20 * time.Millisecond)
+ 	dispatchLimitFn := func(wc int, tc int64) float64 {",was it caused by the removal of removeTaskQueueManager() from this test?,Why is this skipped?
+2483,"@@ -61,7 +61,7 @@ module Blacklight::CatalogHelperBehavior
+   # @see #page_entries_info
+   # @return [String]
+   def item_page_entry_info
+-    t('blacklight.search.entry_pagination_info.other', :current => number_with_delimiter(search_session[:counter]), :total => number_with_delimiter(search_session[:total]), :count => search_session[:total].to_i).html_safe
++    t('blacklight.search.entry_pagination_info.other', :current => number_with_delimiter(search_session['counter']), :total => number_with_delimiter(search_session['total']), :count => search_session['total'].to_i).html_safe
+   end
+ 
+   ##","Wouldn't it just be easier to force search_session to return `with_indifferent_access`? Since you've done the hard work already, I don't think there's a problem doing it this way, but..",Use the new Ruby 1.9
+2484,"@@ -146,6 +146,8 @@ struct PROC_RESOURCES {
+                 atp->needs_shmem = false;
+             }
+         }
++        if (rp->rr_sim_misses_deadline) return false;
++            // Don't schedule if the result is simulated to miss its deadline
+         if (rp->schedule_backoff > gstate.now) return false;
+         if (rp->uses_gpu()) {
+             if (gpu_suspend_reason) return false;","So, such tasks that could possibly not meet the deadline will never have a chance to run? I think this is not nice behavior, especially for those projects who has sometimes some very small tasks after the big one.",Shouldn't this be `rp->rr_sim_misses_deadline > gstate.now`?
+2485,"@@ -10717,6 +10717,11 @@ int LuaScriptInterface::luaItemTypeCreate(lua_State* L)
+ 		id = Item::items.getItemIdByName(getString(L, 2));
+ 	}
+ 
++	if (id == 0) {
++		lua_pushnil(L);
++		return 1;
++	}
++
+ 	const ItemType& itemType = Item::items[id];
+ 	pushUserdata<const ItemType>(L, &itemType);
+ 	setMetatable(L, -1, ""ItemType"");","You should add the check above this line instead. If string is empty, don't even call the function.",Why not just `return 0;`?
+2486,"@@ -101,6 +101,13 @@ public class DynamoDBCertRecordStoreConnection implements CertRecordStoreConnect
+     }
+ 
+     private X509CertRecord itemToX509CertRecord(Item item) {
++        boolean clientCert;
++        try {
++            clientCert = item.getBoolean(KEY_CLIENT_CERT);
++        } catch (Exception ex) {
++            LOGGER.warn(""clientCert for item doesn't exist. Will set it to false. Item: {}"", item.toString());
++            clientCert = false;
++        }
+         X509CertRecord certRecord = new X509CertRecord();
+         certRecord.setProvider(item.getString(KEY_PROVIDER));
+         certRecord.setInstanceId(item.getString(KEY_INSTANCE_ID));",If clientCert attribute doesn't exist for some reason I set it to false.,"please use LOGGER.warn(""clientCert for item doesn't exist. W"
+2487,"@@ -301,7 +301,11 @@ module Travis
+               cmd_opts = {retry: true, assert: false, echo: 'Installing caching utilities'}
+               if casher_branch == 'production'
+                 static_file_location = ""https://#{app_host}/files/#{name}"".output_safe
+-                sh.cmd curl_cmd(flags, location, static_file_location), cmd_opts
++                app_host_flags = flags
++                if Travis::Build.config&.ssl&.verify == false
++                  app_host_flags += ' -k '
++                end
++                sh.cmd curl_cmd(app_host_flags, location, static_file_location), cmd_opts
+                 sh.if ""$? -ne 0"" do
+                   cmd_opts[:echo] = ""Installing caching utilities from the Travis CI server (#{static_file_location}) failed, failing over to using GitHub (#{remote_location})""
+                   sh.cmd curl_cmd(flags, location, remote_location), cmd_opts","Do we need `app_host_flags` variable? We can directly concat with `flags`. `sh.cmd curl_cmd(unless Travis::Build.config&.ssl&.verify ? flags + ' -k' : flags, location, static_file_location), cmd_opts` right?",I think this should be `&&` instead of `== false`
+2488,"@@ -211,11 +211,11 @@ void Creature::onWalk()
+ 				forceUpdateFollowPath = true;
+ 			}
+ 		} else {
++			stopEventWalk();
++
+ 			if (listWalkDir.empty()) {
+ 				onWalkComplete();
+ 			}
+-
+-			stopEventWalk();
+ 		}
+ 	}
+ ",Walk should actually be completed (`onWalkCompleted`) after the event is stopped.   This also makes it possible for monster to walk by smaller paths.,Why is this change needed?
+2489,"@@ -31,6 +31,17 @@ func NewSimpleJoiner(getter storage.Getter) file.Joiner {
+ }
+ 
+ func (s *simpleJoiner) Size(ctx context.Context, address swarm.Address) (dataSize int64, err error) {
++	// Handle size based on weather the root chunk is encrypted or not
++	toDecrypt := len(address.Bytes()) == swarm.EncryptedReferenceSize
++
++	var key encryption.Key
++	addrBytes := address.Bytes()
++	if toDecrypt {
++		addrBytes = address.Bytes()[:swarm.HashSize]
++		key = address.Bytes()[swarm.HashSize : swarm.HashSize+encryption.KeyLength]
++	}
++
++	address = swarm.NewAddress(addrBytes)
+ 	// retrieve the root chunk to read the total data length the be retrieved
+ 	rootChunk, err := s.getter.Get(ctx, storage.ModeGetRequest, address)
+ 	if err != nil {",typo in `weather` (should be `whether`),I'm not sure if this is th
+2490,"@@ -35,6 +35,7 @@ var (
+ 	sourceOS               = flag.String(""source-os"", """", fmt.Sprintf(""OS version of the source instance to upgrade. Supported values: %v"", strings.Join(upgrader.SupportedSourceOSVersions(), "", "")))
+ 	targetOS               = flag.String(""target-os"", """", fmt.Sprintf(""Version of the OS after upgrade. Supported values: %v"", strings.Join(upgrader.SupportedTargetOSVersions(), "", "")))
+ 	timeout                = flag.String(""timeout"", """", ""Maximum time limit for an upgrade. For example, if the time limit is set to 2h, the upgrade times out after two hours. For more information about time duration formats, see $ gcloud topic datetimes"")
++	useStagingInstallMedia = flag.Bool(""use-staging-install-media"", false, ""Use staging install media. This flag is for testing only. Set to true to upgrade with staging windows install media."")
+ 	scratchBucketGcsPath   = flag.String(""scratch-bucket-gcs-path"", """", ""Scratch GCS bucket. This setting overrides the workflow setting."")
+ 	oauth                  = flag.String(""oauth"", """", ""Path to OAuth .json file. This setting overrides the workflow setting."")
+ 	ce                     = flag.String(""compute-endpoint-override"", """", ""API endpoint. This setting overrides the default API endpoint setting."")","Thoughts on having the URI as the param, instead of a boolean? The default value would be the normal prod image, and then your test would override with the staging image.",Can we add a note that thi
+2491,"@@ -351,7 +351,8 @@ static bool ReadAAPairs(
+     return false;
+   }
+   unsigned n = 0;
+-  fscanf(fp, ""%d"", &n);
++  int num_scan = fscanf(fp, ""%d"", &n);
++  RDUNUSED_PARAM(num_scan);
+ 
+   char buffer[80];
+ ","I'm surprised this is needed, but we should probably assert num_scan == 1 at least, otherwise I expect the file is pretty broken.",Shouldn't this be `RDUNUSE
+2492,"@@ -17,7 +17,9 @@ namespace storage {
+ 
+ TEST(AddEdgesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddEdgesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddEdgesProcessor::instance(kv.get(),","Could we set a default value for `partitions` and `{0, network::NetworkUtils::getAvailablePort()}` ?",Why do we need this change?
+2493,"@@ -0,0 +1,14 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core
++{
++    public class RequestBodyTimeout
++    {
++        public TimeSpan MinimumTime { get; set; }
++        public TimeSpan? MaximumTime { get; set; }
++        public double? MinimumRate { get; set; }
++    }
++}","Needs xml docs. The API names alone don't provide enough explanation about what these mean and how to set them. Also, we should provide some validation of inputs, such as MaxTime must be > MinTime, MinimumRate must be >= 0, etc. Consider making the properties readonly and adding a constructor that does these validations.",Why do we need this?
+2494,"@@ -0,0 +1,12 @@
++package testutils
++
++import (
++	""os""
++	""path""
++)
++
++func TestDataFile(name string) string {
++	dir, _ := os.Getwd()
++
++	return path.Join(dir, ""testdata"", name)
++}","Would it make sense to create an empty file here, perhaps in a tmp dir, instead of checking empty files into Git?",Why do we need this file?
+2495,"@@ -1823,7 +1823,9 @@ class CSharpGenerator : public BaseGenerator {
+             code += ""[idx"" + NumToString(j++) + ""]"";
+           }
+           code += "";"";
+-          for (size_t i = 0; i < array_only_lengths.size(); ++i) { code += ""}""; }
++          for (size_t i = 0; i < array_only_lengths.size(); ++i) {
++            code += ""}"";
++          }
+         } else {
+           code += ""_o"";
+           for (size_t i = 0; i < array_lengths.size(); ++i) {",This change is due to `clang_format` and is not related to this PR.,Why this change?
+2496,"@@ -359,6 +359,11 @@ block_all_signals_except(kernel_sigset_t *oset, int num_signals,
+         kernel_sigdelset(&set, va_arg(ap, int));
+     }
+     va_end(ap);
++    /* We never block SIGSEGV or SIGBUS: we need them for various safe reads and to
++     * properly report crashes.
++     */
++    kernel_sigdelset(&set, SIGSEGV);
++    kernel_sigdelset(&set, SIGBUS);
+     sigprocmask_syscall(SIG_SETMASK, &set, oset, sizeof(set));
+ }
+ ","Why did you not add the signals to the call of block_all_signals_except() and instead baked them into the function? Ok, if you had a good reason for it, otherwise I would add it to the except list of the function call, since that's what it was meant for.",I don't think this is the right way to do this. We should be able to get rid of `SIGSEGV` and `SIGBUS`.
+2497,"@@ -0,0 +1,13 @@
++package de.danoeh.antennapod.core.storage;
++
++import android.support.annotation.NonNull;
++
++import de.danoeh.antennapod.core.feed.FeedFile;
++
++public interface FeedFileDownloadStatusRequesterInterface {
++    /**
++     * @return {@code true} if the named feedfile is in the downloads list
++     */
++    boolean isDownloadingFile(@NonNull FeedFile item);
++
++}",Could this be done by mocking objects instead? I feel like this is changing too much of the actual logic just for the tests.,Should this be `@NonNull`?
+2498,"@@ -27,6 +27,7 @@ public class ManifestFileBean implements ManifestFile {
+   private String path = null;
+   private Long length = null;
+   private Integer partitionSpecId = null;
++  private Integer content = null;
+   private Long addedSnapshotId = null;
+ 
+   public String getPath() {",why not just use `ManifestContent` instead of `Integer`?,Why do we need this?
+2499,"@@ -260,8 +260,16 @@ namespace Nethermind.TxPool
+             }
+ 
+             Metrics.PendingTransactionsReceived++;
+-
+-            if (!_validator.IsWellFormed(tx, _specProvider.GetSpec()))
++            
++            IReleaseSpec releaseSpec = _specProvider.GetSpec();
++            if (tx.Type == TxType.AccessList && !releaseSpec.IsEip2930Enabled)
++            {
++                Metrics.PendingTransactionsDiscarded++;
++                if (_logger.IsTrace) _logger.Trace($""Skipped adding transaction {tx.ToString(""  "")}, wrong transaction type {tx.Type}."");
++                return AddTxResult.Invalid;
++            }
++            
++            if (!_validator.IsWellFormed(tx, releaseSpec))
+             {
+                 // It may happen that other nodes send us transactions that were signed for another chain or don't have enough gas.
+                 Metrics.PendingTransactionsDiscarded++;",can we do that in TxValidator?,Why do we need to check for EIP2930 here?
+2500,"@@ -66,6 +66,7 @@ type OnewayOutbound interface {
+ 
+ // Outbounds encapsulates outbound types for a service
+ type Outbounds struct {
+-	Unary  UnaryOutbound
+-	Oneway OnewayOutbound
++	ServiceName string
++	Unary       UnaryOutbound
++	Oneway      OnewayOutbound
+ }",We definitely want some detailed and thoughtful docs being added to this type.,Why is this a string?
+2501,"@@ -467,7 +467,7 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane {
+ 	}
+ 
+ 	// TODO Integrate XDP and BPF infra.
+-	if !config.BPFEnabled && dp.xdpState == nil {
++	if !config.BPFEnabled && config.XDPEnabled && dp.xdpState == nil {
+ 		xdpState, err := NewXDPState(config.XDPAllowGeneric)
+ 		if err == nil {
+ 			if err := xdpState.WipeXDP(); err != nil {","We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart.",Why do we need to do 
+2502,"@@ -25,6 +25,18 @@ DEFINE_int32(clean_wal_interval_secs, 600, ""inerval to trigger clean expired wal
+ namespace nebula {
+ namespace kvstore {
+ 
++#define SPACE_EXIST_RETURN_IF_ERROR(...)                                                           \
++    do {                                                                                           \
++        auto s = (__VA_ARGS__);                                                                    \
++        if (!ok(s)) {                                                                              \
++            if (spaceRet.left() == ResultCode::ERR_SPACE_NOT_FOUND) {                              \
++                LOG(INFO) << ""Space "" << spaceId << "" does not exist, skip it."";                   \
++                return ResultCode::SUCCEEDED;                                                      \
++            }                                                                                      \
++            return error(s);                                                                       \
++        }                                                                                          \
++    } while (0)                                                                                    \
++
+ NebulaStore::~NebulaStore() {
+     LOG(INFO) << ""Cut off the relationship with meta client"";
+     options_.partMan_.reset();",If the status is `ERR_SPACE_NOT_FOUND` why return `SUCCEEDED` ?,Why do we need this?
+2503,"@@ -17,6 +17,8 @@ class ResLayer(nn.Sequential):
+             Default: None
+         norm_cfg (dict): dictionary to construct and config norm layer.
+             Default: dict(type='BN')
++        reverse (bool): Reverse the order of planes in layer sequence.
++            False for ResNet, True for Houglass. Default: False
+     """"""
+ 
+     def __init__(self,","It is is more appropriate to use `downsample_first`. If `downsample_first=True`, the downsample block is the first block and it is used for ResNet. If `downsample_first=False`, the downsample block is the last block, which is used by Hourglass network.",Why do we need this?
+2504,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++    
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`),Why do we need this?
+2505,"@@ -273,6 +273,11 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+             ""consider using the list, dict or set constructor. ""
+             ""It is faster and simpler."",
+         ),
++        ""R1722"": (
++            ""Consider using sys.exit()"",
++            ""consider-using-sys-exit"",
++            ""Instead of using exit() or quit(), consider using the sys.exit()."",
++        ),
+     }
+     options = (
+         (","I don't know if there are strict conventions about this, but I think the name of the warning should be the diagnosis, not the suggested course of action. In this case, that would mean changing the name of the warning to `interactive-exit` or something like that.",This should be `R172
+2506,"@@ -315,7 +315,7 @@ func (c *controller) certificateRequiresIssuance(ctx context.Context, log logr.L
+ 	}
+ 
+ 	// validate the common name is correct
+-	expectedCN := pki.CommonNameForCertificate(crt)
++	expectedCN := crt.Spec.CommonName
+ 	if expectedCN != cert.Subject.CommonName {
+ 		log.Info(""certificate common name is not as expected, re-issuing"")
+ 		return true","If `crt.Spec.CommonName` is not set, and `cert.Subject.CommonName` *is* set, we are not correctly handling it here.",I think this should 
+2507,"@@ -23,8 +23,15 @@ import pytest
+ from PyQt5.QtCore import Qt
+ 
+ from qutebrowser.mainwindow import prompt as promptmod
+-from qutebrowser.utils import usertypes
+-
++from qutebrowser.utils import usertypes, objreg
++from qutebrowser.misc import cmdhistory
++
++@pytest.fixture(autouse=True)
++def test_init(fake_save_manager, data_tmpdir, config_stub):
++    cmdhistory.init()
++    yield
++    objreg.delete('command-history')
++    objreg.delete('fprompt-history')
+ 
+ class TestFileCompletion:
+ ","This isn't a test, so it shouldn't be named `test_init`. You could name it `cmdhistory_init` or so.",Why is this needed?
+2508,"@@ -292,6 +292,10 @@ class PySparkTask(SparkSubmitTask):
+         if self.deploy_mode == ""cluster"":
+             return [self.run_pickle]
+ 
++    @property
++    def pickle_protocol(self):
++        return configuration.get_config().getint(self.spark_version, ""pickle-protocol"", pickle.DEFAULT_PROTOCOL)
++
+     def setup(self, conf):
+         """"""
+         Called by the pyspark_runner with a SparkConf instance that will be used to instantiate the SparkContext",why is this pulling from `self.spark_version` config section rather than the `spark` config section (`py-packages` appears to pull from a config section called `spark`),Why do we need this?
+2509,"@@ -31,6 +31,18 @@ func TestDefaultOptions(t *testing.T) {
+ 	}
+ }
+ 
++func TestOptions_RandomPort(t *testing.T) {
++	opts := &Options{
++		Port: RANDOM_PORT,
++	}
++	processOptions(opts)
++
++	if opts.Port != 0 {
++		t.Fatalf(""Process of options should have resolved random port to ""+
++			""zero.\nexpected: %d\ngot: %d\n"", 0, opts.Port)
++	}
++}
++
+ func TestConfigFile(t *testing.T) {
+ 	golden := &Options{
+ 		Host:        ""apcera.me"",",nit: Think it can be one line..,nit: can we use `t.F
+2510,"@@ -12,10 +12,7 @@
+  */
+ package org.camunda.bpm.application;
+ 
+-import java.util.Collections;
+-import java.util.List;
+-import java.util.Map;
+-import java.util.ServiceLoader;
++import java.util.*;
+ import java.util.concurrent.Callable;
+ 
+ import javax.script.ScriptEngine;",please inline imports,Don't use star impor
+2511,"@@ -85,8 +85,7 @@ func (p *setnsProcess) start() (err error) {
+ 	if err = p.execSetns(); err != nil {
+ 		return newSystemErrorWithCause(err, ""executing setns process"")
+ 	}
+-	// We can't join cgroups if we're in a rootless container.
+-	if !p.config.Rootless && len(p.cgroupPaths) > 0 {
++	if len(p.cgroupPaths) > 0 {
+ 		if err := cgroups.EnterPid(p.cgroupPaths, p.pid()); err != nil {
+ 			return newSystemErrorWithCausef(err, ""adding pid %d to cgroups"", p.pid())
+ 		}","This check is still correct in some cases, but I guess erroring out is acceptable if someone explicitly asked for an impossible cgroup configuration (now that we could in principle nest things). I would like to see a test for this though.",I'm not sure if this
+2512,"@@ -34,6 +34,7 @@ var skip = map[string]string{
+ 	""task_per_line"":               ""join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)"",
+ 	""rowfn_with_import"":           ""imported libraries are not visible in user-defined functions (https://github.com/influxdata/flux/issues/1000)"",
+ 	""string_trim"":                 ""cannot reference a package function from within a row function"",
++	""integral_columns"":            ""aggregates changed to operate on just a single columnm."",
+ }
+ 
+ var querier = querytest.NewQuerier()",Should we update integral to operate on a single column as well?,"I think this should be ""aggregates changed to operate on a single column."""
+2513,"@@ -91,7 +91,9 @@ static std::atomic<int> num_uvm_allocations(0);
+ }  // namespace
+ 
+ void DeepCopyCuda(void *dst, const void *src, size_t n) {
+-  KOKKOS_IMPL_CUDA_SAFE_CALL(cudaMemcpy(dst, src, n, cudaMemcpyDefault));
++  cudaStream_t s = cuda_get_deep_copy_stream();
++  KOKKOS_IMPL_CUDA_SAFE_CALL(
++      cudaMemcpyAsync(dst, src, n, cudaMemcpyDefault, s));
+ }
+ 
+ void DeepCopyAsyncCuda(const Cuda &instance, void *dst, const void *src,",Doesn't belong to this PR,Why do we need this?
+2514,"@@ -26,7 +26,7 @@ type ECSClient interface {
+ 	// ContainerInstanceARN if successful. Supplying a non-empty container
+ 	// instance ARN allows a container instance to update its registered
+ 	// resources.
+-	RegisterContainerInstance(existingContainerInstanceArn string, attributes []*ecs.Attribute) (string, error)
++	RegisterContainerInstance(existingContainerInstanceArn string, attributes []*ecs.Attribute, registrationToken string) (string, error)
+ 	// SubmitTaskStateChange sends a state change and returns an error
+ 	// indicating if it was submitted
+ 	SubmitTaskStateChange(change TaskStateChange) error","Just for my own understanding, does aws ecs API take this token as a new input attribute? Which version of the aws sdk? I did not find it in the official aws sdk doc.",This is a breaking change. We need to add a new method to the interface.
+2515,"@@ -68,6 +68,7 @@ public class UserAccount {
+ 	private static final String TAG = ""UserAccount"";
+ 	private static final String FORWARD_SLASH = ""/"";
+ 	private static final String UNDERSCORE = ""_"";
++	private static final String SF_APP_FEATURE_CODE_USER_AUTH = ""UA"";
+ 
+ 	private String authToken;
+ 	private String refreshToken;",Could we shorten this constant to maybe `FEATURE_USER_AUTH`?,private static final Logger LOGGER = LoggerFactory.getLogger(UserAccount.c
+2516,"@@ -14,6 +14,10 @@ import (
+ 	""golang.org/x/net/context""
+ )
+ 
++const (
++	numRekeyWorkers = 8
++)
++
+ type rekeyQueueEntry struct {
+ 	id tlf.ID
+ 	ch chan error",Any particular reason for 8? I feel like we could probably handle more...,nit: `numRekeyWorkers` -> `rekeyWorkers`
+2517,"@@ -91,6 +91,13 @@ class CodeSetAdminTest < ActionDispatch::IntegrationTest
+     assert_response :redirect
+   end
+ 
++  it 'should update retry_count' do
++    login_as admin
++    job = create(:fetch_job, repository: create(:repository))
++    put admin_job_path(job), job: { retry_count: 3 }
++    job.reload.retry_count.must_equal 3
++  end
++
+   it 'should delete job' do
+     login_as admin
+     job = create(:fetch_job, repository: create(:repository))","Try to use factory association declaration for default values, so it could minimal the line length. You may write in fetch_job factory like association :repository, factory: :repository.",Layout/EmptyLinesAroundBlockBody: Extra 
+2518,"@@ -1,7 +1,7 @@
+ <tr class=""m-shared-email_status"">
+   <td colspan=""2"" padding=""10"">
+     <table id=""status-container-detail"" width=""770"" class=""col-md-12"">
+-      <tr class=""status-header-container"">
++      <tr class=""status-header-container cancelled"">
+         <td>
+           <strong>Approval Status</strong>
+         </td>","Should the ""cancelled"" class be added regardless of the proposal's state?",I'm not sure if this is the right place 
+2519,"@@ -115,7 +115,6 @@ const validOptions = require('./operations/mongo_client_ops').validOptions;
+  */
+ function MongoClient(url, options) {
+   if (!(this instanceof MongoClient)) return new MongoClient(url, options);
+-
+   // Set up event emitter
+   EventEmitter.call(this);
+ ","nit: random whitespace change, let's try to keep these out of commits unless there are other useful changes.",Why is this removed?
+2520,"@@ -624,9 +624,15 @@ exports.populate = function populate(path, select, model, match, options, subPop
+ 
+   var ret = [];
+   var paths = path.split(' ');
++  var models = undefined;
++  if (typeof model === 'string') {
++    models = model.split(' ');
++  }
+   options = exports.clone(options, { retainKeyOrder: true });
+   for (var i = 0; i < paths.length; ++i) {
+-    ret.push(new PopulateOptions(paths[i], select, match, options, model, subPopulate));
++    var _model = model;
++    if (models && i < models.length) _model = models[i];
++    ret.push(new PopulateOptions(paths[i], select, match, options, _model, subPopulate));
+   }
+ 
+   return ret;",Seems kinda dangerous - what if models length is different from paths length?,I'm not sure if this is the best way to do this. I think it would be better to use `Array.isArray(model)`.
+2521,"@@ -412,7 +412,7 @@ func stageSenders(db kv.RwDB, ctx context.Context) error {
+ 	s := stage(sync, tx, nil, stages.Senders)
+ 	log.Info(""Stage"", ""name"", s.ID, ""progress"", s.BlockNumber)
+ 
+-	cfg := stagedsync.StageSendersCfg(db, chainConfig, tmpdir)
++	cfg := stagedsync.StageSendersCfg(db, chainConfig, tmpdir, prune.Mode{})
+ 	if unwind > 0 {
+ 		u := sync.NewUnwindState(stages.Senders, s.BlockNumber-unwind, s.BlockNumber)
+ 		err = stagedsync.UnwindSendersStage(u, tx, cfg, ctx)",set real one plz (get it from DB).,"`prune.Mode{}` is the default value, so you can remove this line."
+2522,"@@ -180,8 +180,9 @@ static fpga_result send_uafu_event_request(fpga_handle handle,
+ 	struct _fpga_handle *_handle = (struct _fpga_handle *)handle;
+ 	struct fpga_port_info port_info  = {.argsz = sizeof(port_info),
+ 						.flags = 0 };
+-	struct fpga_port_uafu_irq_set uafu_irq = {.argsz = sizeof(uafu_irq),
+-						.flags = 0};
++	uint8_t uafu_irq_buf[sizeof(struct fpga_port_uafu_irq_set)+sizeof(int32_t)];
++	struct fpga_port_uafu_irq_set *uafu_irq =
++		(struct fpga_port_uafu_irq_set *) uafu_irq_buf;
+ 
+ 	if (uafu_operation != FPGA_IRQ_ASSIGN && uafu_operation != FPGA_IRQ_DEASSIGN) {
+ 		FPGA_ERR(""Invalid UAFU operation requested"");",Should this be initialized to zeroes?,Why do we need this cast?
+2523,"@@ -419,7 +419,7 @@ public abstract class FacetProcessor<FacetRequestT extends FacetRequest>  {
+       }
+       count = result.size();  // don't really need this if we are skipping, but it's free.
+     } else {
+-      if (q == null) {
++      if (q == null || fcontext.base.size() == 0) {
+         count = fcontext.base.size();
+       } else {
+         count = fcontext.searcher.numDocs(q, fcontext.base);","The query is already built at this point, so I don't think this particular change actually helps wrt SOLR-10732? (and the `base.size()==0` case is already trivially optimized in `SolrIndexSearcher.numDocs(Query, DocSet)`)",Shouldn't this be `fcontext.base.isEmpty()`?
+2524,"@@ -1,16 +1,14 @@
+-
+ package net.runelite.client.plugins.wildernesslocations;
+ 
++
+ import java.util.Arrays;
+ import java.util.HashMap;
+-import java.util.List;
+ import java.util.Map;
+ import java.util.Objects;
+-import java.util.Set;
+-import java.util.function.Consumer;
+ import javax.inject.Inject;
++
++import lombok.Getter;
+ import net.runelite.api.Client;
+-import net.runelite.api.Player;
+ import net.runelite.api.Varbits;
+ import net.runelite.api.coords.WorldArea;
+ import net.runelite.api.coords.WorldPoint;",re-add the type in the annotation here,Remove unused imports
+2525,"@@ -226,9 +226,11 @@ func GetLatestVersion() (string, error) {
+ 	//Download the tar from repo
+ 	versionURL := ""curl -k "" + latestReleaseVersionURL
+ 	cmd := exec.Command(""sh"", ""-c"", versionURL)
++	var stderr bytes.Buffer
++	cmd.Stderr = &stderr
+ 	latestReleaseData, err := cmd.Output()
+ 	if err != nil {
+-		return """", err
++		return """", fmt.Errorf(""%v:%v"", err, stderr.String())
+ 	}
+ 
+ 	latestRelease := &latestReleaseVersion{}",Could we simpify it as `cmd.Stderr = &bytes.Buffer{}`?,I think this should b
+2526,"@@ -13,6 +13,11 @@ func ShouldRotateX509(now time.Time, cert *x509.Certificate) bool {
+ 	return shouldRotate(now, cert.NotBefore, cert.NotAfter)
+ }
+ 
++// X509Expired returns true if the given X509 cert has expired
++func X509Expired(now time.Time, cert *x509.Certificate) bool {
++	return !now.Before(cert.NotAfter)
++}
++
+ // JWTSVIDExpiresSoon determines if the given JWT SVID should be rotated
+ // based on presented current time, the JWT's expiration.
+ // Also returns true if the JWT is already expired.","there's enough ""nots"" in here that while it's correct by my review, I'd like to see a small unit test (just passing in an expired and non-expired cert)",Why not just `return 
+2527,"@@ -21,7 +21,7 @@ import (
+ 
+ 	""github.com/ghodss/yaml""
+ 
+-	""istio.io/fortio/log""
++	""fortio.org/fortio/log""
+ 	""istio.io/tools/isotope/convert/pkg/graph""
+ 	""istio.io/tools/isotope/convert/pkg/graph/size""
+ 	""istio.io/tools/isotope/convert/pkg/graph/svc""",File is not `goimports`-ed (from `goimports`),Why is this change ne
+2528,"@@ -73,6 +73,11 @@ class Config(param.ParameterizedFunction):
+        recommended that users switch this on to update any uses of
+        __call__ as it will be deprecated in future."""""")
+ 
++    rtol = param.Number(default=10e-6, doc=""""""
++      The tolerance used to enforce regular sampling for gridded data
++      where regular sampling is expected. Expressed as the maximal
++      allowable sampling difference between sample locations."""""")
++
+     def __call__(self, **params):
+         self.set_param(**params)
+         return self",The config option should probably have a more specific name. Also it's not for all gridded data but specifically for Images (and its subclasses).,I don't think this is needed.
+2529,"@@ -80,7 +80,7 @@ public class PreferencesTest {
+         }
+         clickPreference(R.string.user_interface_label);
+         clickPreference(R.string.pref_set_theme_title);
+-        onView(withText(otherTheme)).perform(click());
++        clickPreference(otherTheme);
+         Awaitility.await().atMost(1000, MILLISECONDS)
+                 .until(() -> UserPreferences.getTheme() != theme);
+     }",Be careful. This is not a preference but an option in a dialog.,Why did you remove the `withT
+2530,"@@ -30,8 +30,11 @@ func (s *svc) DescribeDeployment(ctx context.Context, clientset, cluster, namesp
+ }
+ 
+ func ProtoForDeployment(cluster string, deployment *appsv1.Deployment) *k8sapiv1.Deployment {
++	if deployment.ClusterName == """" {
++		deployment.ClusterName = cluster
++	}
+ 	return &k8sapiv1.Deployment{
+-		Cluster:     cluster,
++		Cluster:     deployment.ClusterName,
+ 		Namespace:   deployment.Namespace,
+ 		Name:        deployment.Name,
+ 		Labels:      deployment.Labels,","this will modify the incoming object, which may not be desirable in some cases. i think we should stick with the local var, override it with deployment.ClusterName if deployment.ClusterName not empty",Why do we need this?
+2531,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?,Why was this removed?
+2532,"@@ -121,8 +121,13 @@ Blockly.BlockSvg.INLINE = -1;
+  */
+ Blockly.BlockSvg.prototype.initSvg = function() {
+   goog.asserts.assert(this.workspace.rendered, 'Workspace is headless.');
++  // ""Input shapes"" for each input. Used to draw ""holes"" for unoccupied value inputs.
++  this.inputShapes_ = {};
+   for (var i = 0, input; input = this.inputList[i]; i++) {
+     input.init();
++    if (input.type === Blockly.INPUT_VALUE) {
++      this.initInputShape(input);
++    }
+   }
+   var icons = this.getIcons();
+   for (i = 0; i < icons.length; i++) {",You're using scare quotes on these terms instead of defining them.,Why do we need this?
+2533,"@@ -13,6 +13,9 @@ var DdevVersion = ""v0.3.0-dev"" // Note that this is overridden by make
+ // for examples defining version constraints.
+ var DockerVersionConstraint = "">= 17.05.0-ce""
+ 
++// DockerComposeVersionConstraint is the current minimum version of docker-compose required for ddev.
++var DockerComposeVersionConstraint = "">= 1.10.0""
++
+ // WebImg defines the default web image used for applications.
+ var WebImg = ""drud/nginx-php-fpm-local"" // Note that this is overridden by make
+ ","These should both be const, not var right?",This should be `1.10
+2534,"@@ -78,9 +78,7 @@ public class SettingsManager {
+ 
+     public void save() {
+         Settings settings = load();
+-        try {
+-            File file = new File(settingsFileName);
+-            OutputStream outputStream = new FileOutputStream(file);
++        try (OutputStream outputStream = new FileOutputStream(new File(settingsFileName))) {
+             DefaultPropertiesPersister persister = new DefaultPropertiesPersister();
+             persister.store(settings.getProperties(), outputStream, ""Phoenicis User Settings"");
+         } catch (Exception e) {",Can you catch a more specific exception here? Thanks :-),Why is this change n
+2535,"@@ -80,6 +80,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 			r.Log.Error(err, ""failed to recover chaos"")
+ 			return ctrl.Result{Requeue: true}, nil
+ 		}
++		return ctrl.Result{}, nil
+ 	}
+ 
+ 	// Start failure action","This is a bug during handling the recover logic in `common chaos` controller, I fixed in this request when I found it.","r.Log.Error(err, ""fa"
+2536,"@@ -11,7 +11,11 @@ from mmcv.runner import get_dist_info
+ from mmdet.core import tensor2imgs
+ 
+ 
+-def single_gpu_test(model, data_loader, show=False, out_dir=None):
++def single_gpu_test(model,
++                    data_loader,
++                    show=False,
++                    out_dir=None,
++                    score_thr=0.3):
+     model.eval()
+     results = []
+     dataset = data_loader.dataset","During testing, we adopt the score threshold specified in the config file. Here the threshold is only used for visualization, and the variable name `score_thr` can be misleading. Renaming it to `show_score_thr` would be better.",Why do we need this?
+2537,"@@ -1,7 +1,7 @@
+-<header class=""banner"" role=""banner"">
++<header class=""banner"">
+   <div class=""container"">
+     <a class=""brand"" href=""<?= esc_url(home_url('/')); ?>""><?php bloginfo('name'); ?></a>
+-    <nav role=""navigation"">
++    <nav class=""site-nav"">
+       <?php
+       if (has_nav_menu('primary_navigation')) :
+         wp_nav_menu(['theme_location' => 'primary_navigation', 'menu_class' => 'nav']);","can you make this `nav-primary` please? i'd like to roll with this since the `<ul>` class is `nav`, and primary is the name of the navigation menu",Why did you change t
+2538,"@@ -49,7 +49,16 @@ app.factory('CalendarListItem', function($rootScope, $window, Calendar, WebCal,
+ 			},
+ 			publicSharingURL: {
+ 				get: () => {
+-					return $rootScope.root + 'p/' + context.calendar.publicToken;
++					let displayname = context.calendar.displayname
++						.replace(/\s+/g, '-').replace(/[^\w\-]+/g, '')
++						.replace(/\-\-+/g, '-').replace(/^-+/, '')
++						.replace(/-+$/, '');
++
++					if (displayname === '') {
++						return $rootScope.root + 'p/' + context.calendar.publicToken;
++					} else {
++						return $rootScope.root + 'p/' + context.calendar.publicToken + '/' + displayname;
++					}
+ 				}
+ 			},
+ 			publicEmbedURL: {",@georgehrke Just out of curiosity. Couldn't you combine at least the combine the regex for '-' and '' with groups?,Why do we need to do
+2539,"@@ -292,7 +292,7 @@ HashedCollectionConfig::SwiftObjectAtAddress(
+   if (error.Fail())
+     return nullptr;
+ 
+-  CompilerType anyObject_type = ast_ctx->FindQualifiedType(""Swift.AnyObject"");
++  CompilerType anyObject_type = ast_ctx->GetAnyObjectType();
+   if (!anyObject_type)
+     return nullptr;
+ ","I think this is objectively better than looking up the object by name. As a follow-up, I'm going to see whether we do this name-based lookup somewhere else and switch to your method.",Why did you change t
+2540,"@@ -81,7 +81,8 @@ Blockly.FlyoutExtensionCategoryHeader.prototype.createDom = function() {
+   var marginX = 15;
+   var marginY = 10;
+ 
+-  var statusButtonX = (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale;
++  var statusButtonX = this.workspace_.RTL ? (marginX - this.flyoutWidth_ + statusButtonWidth) :
++      (this.flyoutWidth_ - statusButtonWidth - marginX) / this.workspace_.scale;
+ 
+   if (this.imageSrc_) {
+     /** @type {SVGElement} */",Why are you dividing by scale in the LTR case but not the RTL case?,nit: `var statusButtonX = (this.workspace_.RTL ? (marginX - this.flyoutWidth_ + statusButtonWidth) : marginX)`
+2541,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,I think this should be `POST` instead of `POST`
+2542,"@@ -61,8 +61,8 @@ export default function createLegacySettingsWrapper( moduleSlug, moduleComponent
+ 		useEffect( () => {
+ 			removeAllFilters( `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` );
+ 			addFilter(
+-				'googlesitekit.ModuleSettingsDetails-tagmanager',
+-				'googlesitekit.TagManagerModuleSettings',
++				`googlesitekit.ModuleSettingsDetails-${ moduleSlug }`,
++				'googlesitekit.SettingsLegacy',
+ 				fillFilterWithComponent( moduleComponent )
+ 			);
+ 			return () => removeAllFilters( `googlesitekit.ModuleSettingsDetails-${ moduleSlug }` );",I added this change to fix a bug with the legacy settings wrapper which was preventing it from working properly with the other modules  ,Why do we need to remove this filter?
+2543,"@@ -33,12 +33,15 @@ package azkaban;
+ public class Constants {
+ 
+   // Azkaban Flow Versions
+-  public static final String AZKABAN_FLOW_VERSION_2_0 = ""2.0"";
++  public static final double VERSION_2_0 = 2.0;
+ 
+   // Flow 2.0 file suffix
+   public static final String PROJECT_FILE_SUFFIX = "".project"";
+   public static final String FLOW_FILE_SUFFIX = "".flow"";
+ 
++  // Flow 2.0 node type
++  public static final String FLOW_NODE_TYPE = ""flow"";
++
+   // Names and paths of various file names to configure Azkaban
+   public static final String AZKABAN_PROPERTIES_FILE = ""azkaban.properties"";
+   public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";",isn't AZKABAN_FLOW_VERSION_2_0 more explicit?,Why do we need this change?
+2544,"@@ -308,9 +308,7 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
+                 /*case ONEDRIVE:
+                     signInOneDrive();
+                     break;*/
+-
+-                default:
+-                    SnackBarHandler.show(coordinatorLayout, R.string.feature_not_present);
++                default://do nothing
+             }
+         } else {
+             AlertDialog alertDialog = new AlertDialog.Builder(this)",Please don't leave an empty default,Why did you remove this?
+2545,"@@ -15,6 +15,7 @@
+  * See the License for the specific language governing permissions and
+  * limitations under the License.
+  */
++
+ /**
+  * External dependencies
+  */","This isn't directly related, but the `import React from 'react';` below should be removed. We never import this directly and any modules from it we need are imported through `@wordpress/element`. This was probably added automatically at some point, but we also provide this automatically via `ProvidePlugin`.",Why is this needed?
+2546,"@@ -84,7 +84,9 @@ module Travis
+             sh.cmd 'sudo chmod 2777 /usr/local/lib/R /usr/local/lib/R/site-library'
+ 
+           when 'osx'
+-            sh.cmd 'brew update', retry: true
++            # We want to update, but we don't need the 800+ lines of
++            # output.
++            sh.cmd 'brew update >/dev/null', retry: true
+ 
+             # Install from latest CRAN binary build for OS X
+             sh.cmd ""wget #{config[:cran]}/bin/macosx/R-latest.pkg "" +",You can also use `echo: false` instead. Either is fine; I'm just pointing it out.,Why is this necessary?
+2547,"@@ -115,12 +115,13 @@ namespace NLog.Layouts
+         /// </summary>
+         protected override void InitializeLayout()
+         {
+-            base.InitializeLayout();
+             if (!WithHeader)
+             {
+                 Header = null;
+             }
+ 
++            base.InitializeLayout();
++
+             switch (Delimiter)
+             {
+                 case CsvColumnDelimiterMode.Auto:",what's the reason for this moved line?,Why is this change neede
+2548,"@@ -986,6 +986,10 @@ import 'programStyles';
+                 lines = [];
+             }
+ 
++            if (overlayText && showTitle) {
++                lines = [item.Name];
++            }
++
+             const addRightTextMargin = isOuterFooter && options.cardLayout && !options.centerText && options.cardFooterAside !== 'none' && layoutManager.mobile;
+ 
+             html += getCardTextLines(lines, cssClass, !options.overlayText, isOuterFooter, options.cardLayout, addRightTextMargin, options.lines);","I don't really follow what is happening here, but it looks like this _could_ conflict with the logic on the lines above... should this be an `else if`?",Why do we need to check for `showTitle` here?
+2549,"@@ -97,10 +97,10 @@ namespace Microsoft.VisualStudio.TestPlatform.ObjectModel.Navigation
+             out int startLineNumber,
+             out int endLineNumber)
+         {
+-            var startPoint = methodDebugDefinition.GetSequencePoints().OrderBy(s => s.StartLine).FirstOrDefault();
++            var startPoint = methodDebugDefinition.GetSequencePoints().OrderBy(s => s.StartLine).FirstOrDefault(s => s.IsHidden == false);
+             startLineNumber = startPoint.StartLine;
+             var endPoint =
+-                methodDebugDefinition.GetSequencePoints().OrderByDescending(s => s.StartLine).FirstOrDefault();
++                methodDebugDefinition.GetSequencePoints().OrderByDescending(s => s.StartLine).FirstOrDefault(s => s.IsHidden == false);
+             endLineNumber = endPoint.StartLine;
+         }
+ ",`s => s.IsHidden == false` What's the purpose of adding this?,">IsHidden [](start = 27, length = 11) Is this"
+2550,"@@ -45,6 +45,7 @@ const (
+ 	optionNameGatewayMode          = ""gateway-mode""
+ 	optionNameClefSignerEnable     = ""clef-signer-enable""
+ 	optionNameClefSignerEndpoint   = ""clef-signer-endpoint""
++	optionNameClefSignerAddress    = ""clef-signer-address""
+ 	optionNameSwapEndpoint         = ""swap-endpoint""
+ 	optionNameSwapFactoryAddress   = ""swap-factory-address""
+ 	optionNameSwapInitialDeposit   = ""swap-initial-deposit""","I would name this `clef-ethereum-address`. We already have a bunch of addresses in Bee, and people might wrongly think that this is yet another address",I think this should be renamed to `optionName
+2551,"@@ -202,6 +202,7 @@ class TestCase(unittest.TestCase):
+         # ofile.write(mb)
+         # ofile.close()
+ 
++    #@unittest.skip
+     def test6ChangeBondLength(self):
+         m = Chem.MolFromSmiles('CC')
+         rdDepictor.Compute2DCoords(m)",you can just remove this,Why is this test skipped?
+2552,"@@ -297,6 +297,13 @@ func buildUpgradeTask(kind, name, openebsNamespace string) *apis.UpgradeTask {
+ 				PoolName: name,
+ 			},
+ 		}
++	case ""storagePoolClaim"":
++		utaskObj.Name = ""upgrade-cstor-pool-"" + name
++		utaskObj.Spec.ResourceSpec = apis.ResourceSpec{
++			StoragePoolClaim: &apis.StoragePoolClaim{
++				SPCName: name,
++			},
++		}
+ 	case ""cstorVolume"":
+ 		utaskObj.Name = ""upgrade-cstor-volume-"" + name
+ 		utaskObj.Spec.ResourceSpec = apis.ResourceSpec{",I think we should avoid creating a dummy CR in the case of SPC. Please see if we can avoid this since we will not be patching anything in this CR.,I'm not sure if this is the right way to do this. I think it should be `upgrade-cstor-pool-spc`
+2553,"@@ -7,6 +7,10 @@
+   <%= render 'trails' %>
+ </section>
+ 
++<% if locked_features.any? %>
++  <%= render 'locked_features' %>
++<% end %>
++
+ <% if current_user_has_access_to?(:exercises) %>
+   <p class=""product-headline"">Hone your skills by completing these exercises</p>
+   <%= render 'products/exercises' %>","Honestly not sure myself, but do you think it makes sense to move this conditional into the partial?",I don't think you need the `.any?`
+2554,"@@ -70,7 +70,7 @@ def run(args):
+         sys.exit(usertypes.Exit.ok)
+ 
+     if args.temp_basedir:
+-        args.basedir = tempfile.mkdtemp()
++        args.basedir = tempfile.mkdtemp(prefix='qutebrowser-prefix-')
+ 
+     quitter = Quitter(args)
+     objreg.register('quitter', quitter)","As discussed in IRC (just so it doesn't get lost): This probably should be `-basedir-`, not `-prefix-`",Why is this needed?
+2555,"@@ -40,7 +40,8 @@ namespace Nethermind.Db
+ 
+         public DbOnTheRocks(string basePath, string dbPath, IDbConfig dbConfig, ILogManager logManager = null) // TODO: check column families
+         {
+-            var fullPath = Path.Combine(basePath, dbPath);
++            var directory = PathUtils.GetExecutingDirectory();
++            var fullPath = Path.Combine(directory, basePath, dbPath);
+             var logger = logManager?.GetClassLogger();
+             if (!Directory.Exists(fullPath))
+             {",basepath can be absoluta path and this needs to be supported,Why is this change needed?
+2556,"@@ -280,7 +280,7 @@ void ConfigPanelWidget::updateIconThemeSettings()
+ void ConfigPanelWidget::addPosition(const QString& name, int screen, LXQtPanel::Position position)
+ {
+     if (LXQtPanel::canPlacedOn(screen, position))
+-        ui->comboBox_position->addItem(name, QVariant::fromValue((ScreenPosition){screen, position}));
++        ui->comboBox_position->addItem(name, QVariant::fromValue(ScreenPosition{screen, position}));
+ }
+ 
+ ",Didn't get to the commit message,I don't understand why this change is needed.
+2557,"@@ -0,0 +1,14 @@
++class DesignForDevelopersResourcesController < ApplicationController
++  layout ""d4d_resources""
++
++  def index
++  end
++
++  def show
++    if template_exists?(params[:id], params[:controller])
++      render params[:id]
++    else
++      raise ActiveRecord::RecordNotFound
++    end
++  end
++end",What about raising `ActionView::MissingTemplate` instead? That's what HighVoltage does.,I don't think we need this controller.
+2558,"@@ -527,6 +527,7 @@ void nano::json_handler::account_balance ()
+ 		auto balance (node.balance_pending (account, include_only_confirmed));
+ 		response_l.put (""balance"", balance.first.convert_to<std::string> ());
+ 		response_l.put (""pending"", balance.second.convert_to<std::string> ());
++		response_l.put (""receivable"", balance.second.convert_to<std::string> ());
+ 	}
+ 	response_errors ();
+ }",Is it kept for compatibility?,This should be `receivable_balance`
+2559,"@@ -537,10 +537,16 @@ func (m *StorageMinerNodeConnector) getMinerWorkerAddress(ctx context.Context, t
+ 		return address.Undef, xerrors.Errorf(""failed to get tip state: %w"", err)
+ 	}
+ 
+-	_, waddr, err := m.stateViewer.StateView(root).MinerControlAddresses(ctx, m.minerAddr)
++	view := m.stateViewer.StateView(root)
++	_, waddr, err := view.MinerControlAddresses(ctx, m.minerAddr)
+ 	if err != nil {
+ 		return address.Undef, xerrors.Errorf(""failed to get miner control addresses: %w"", err)
+ 	}
+ 
+-	return waddr, nil
++	workerSigner, err := view.AccountSignerAddress(ctx, waddr)
++	if err != nil {
++		return address.Undef, xerrors.Errorf(""failed to lookup signing address for worker address: %s: %w"", waddr.String(), err)
++	}
++
++	return workerSigner, nil
+ }",I would find it pretty reasonable to add a MinerSigner method on the state view that puts these together.,I think this should be `waddr.String()`
+2560,"@@ -310,6 +310,10 @@ class DBUpgrader {
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS +
+                     "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_SKIP_ENDING + "" INTEGER DEFAULT 0;"");
+         }
++        if (oldVersion < 1090001) { // fixme / todo: fix  version
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS +
++                    "" ADD COLUMN "" + PodDBAdapter.KEY_EPISODE_NOTIFICATION + "" INTEGER DEFAULT 0;"");
++        }
+     }
+ 
+ }","It's stored in `PodDBAdapter.VERSION`. I usually use the expected release version code for that change. As this will be released in AntennaPod 2.2.0, the code would be `2020000`.",I think this should be `<=`
+2561,"@@ -150,7 +150,7 @@ func (task *UpdateTask) execCQLStmts(ver string, stmts []string) error {
+ 		log.Println(rmspaceRegex.ReplaceAllString(stmt, "" ""))
+ 		e := task.db.Exec(stmt)
+ 		if e != nil {
+-			return fmt.Errorf(""error executing CQL statement:%v"", e)
++			return fmt.Errorf(""error executing statement:%v"", e)
+ 		}
+ 	}
+ 	log.Printf(""---- Done ----\n"")",What about method name itself? Do we run this for SQL too?,I don't think this change i
+2562,"@@ -42,7 +42,7 @@ public class SalesforceHybridTestActivity extends SalesforceDroidGapActivity {
+ 	static String refreshToken = ""5Aep861KIwKdekr90IDidO4EhfJiYo3fzEvTvsEgM9sfDpGX0qFFeQzHG2mZeUH_.XNSBE0Iz38fnWsyYYkUgTz"";
+ 	static String authToken = ""--will-be-set-through-refresh--"";
+ 	static String identityUrl = ""https://test.salesforce.com"";
+-	static String instanceUrl = ""https://cs1.salesforce.com"";
++	static String instanceUrl = ""https://mobilesdk.cs1.my.salesforce.com"";
+ 	static String loginUrl = ""https://test.salesforce.com"";
+ 	static String orgId = ""00DS0000003E98jMAC"";
+ 	static String userId = ""005S0000004s2iyIAA"";",`instanceUrl` should be `cs1.salesforce.com`. `communityUrl` would be `mobilesdk.cs1.my.salesforce.com`.,Why is this change needed?
+2563,"@@ -200,7 +200,10 @@ adios2_error adios2_variable_name(char *name, size_t *size,
+         const adios2::core::VariableBase *variableBase =
+             reinterpret_cast<const adios2::core::VariableBase *>(variable);
+         *size = variableBase->m_Name.size();
+-        variableBase->m_Name.copy(name, *size);
++        if (name)
++        {
++            variableBase->m_Name.copy(name, *size);
++        }
+         return adios2_error_none;
+     }
+     catch (...)",Let's use `if(name != nullptr)` to remove ambiguity,Why is this needed?
+2564,"@@ -1027,4 +1027,12 @@ public class SurfaceNamer extends NameFormatterDelegator {
+   public String getReleaseAnnotation(ReleaseLevel releaseLevel) {
+     return getNotImplementedString(""SurfaceNamer.getReleaseAnnotation"");
+   }
++
++  public String getMetadataIdentifier() {
++    return getNotImplementedString(""SurfaceNamer.getMetadataIdentifier"");
++  }
++
++  public String getMetadataName() {
++    return getNotImplementedString(""SurfaceNamer.getMetadataName"");
++  }
+ }","I wonder if it would make sense to have a separate namer for metadata? Metadata files tend to be expressed in a different language from the repo language, and have mutually exclusive concepts. So, `PackageMetadataNamer`.",Why are these not implemented?
+2565,"@@ -37,6 +37,15 @@ import org.apache.logging.log4j.Logger;
+ public class BftValidatorsValidationRule implements AttachedBlockHeaderValidationRule {
+ 
+   private static final Logger LOGGER = LogManager.getLogger();
++  private final boolean extraDataValidatorsAndVoteMustBeEmpty;
++
++  public BftValidatorsValidationRule() {
++    this(false);
++  }
++
++  public BftValidatorsValidationRule(final boolean extraDataValidatorsAndVoteMustBeEmpty) {
++    this.extraDataValidatorsAndVoteMustBeEmpty = extraDataValidatorsAndVoteMustBeEmpty;
++  }
+ 
+   @Override
+   public boolean validate(",This rule is quite specific to qbft and so I don't think it should be part of the common rules. Would rather the common bft code didn't know anything about contract based voting/validator governance.,Why do we need this constructo
+2566,"@@ -163,6 +163,15 @@ public interface Set<T> extends Traversable<T>, Function1<T, Boolean>, Serializa
+      */
+     Set<T> removeAll(Iterable<? extends T> elements);
+ 
++    /**
++     * Reverse the order of all given elements in this set, if present.
++     *
++     * @return A new set consisting of the elements in reverse order of this set
++     */
++    default Set<T> reverse() {
++        throw new UnsupportedOperationException(""Operation not supported"");
++    }
++
+     /**
+      * Converts this Vavr {@code Set} to a {@code java.util.Set} while preserving characteristics
+      * like insertion order ({@code LinkedHashSet}) and sort order ({@code SortedSet}).","This makes our life harder than it needs to be. A Set is unordered by definition. Please remove this method from Set and add it to SortedSet, but with no default implementation. We need to duplicate it then to LinkedHashSet but that's ok, it is the best we can do. Could you please add it also to SortedMap and LinkedHashMap? We are then able to close the original issue.",Why is this unsupported?
+2567,"@@ -366,6 +366,10 @@ class S3Connection(AWSAuthConnection):
+         if version_id is not None:
+             params['VersionId'] = version_id
+ 
++        if response_headers is not None:
++            for header, value in response_headers.items():
++                params[header] = value
++
+         http_request = self.build_base_http_request(method, path, auth_path,
+                                                     headers=headers, host=host,
+                                                     params=params)",we can replace `for` with `params.update(response_headers)`,I don't think you need to chec
+2568,"@@ -118,13 +118,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Https
+                 return certificate2;
+             }
+ 
+-#if NETSTANDARD1_3
+-            // conversion X509Certificate to X509Certificate2 not supported
+-            // https://github.com/dotnet/corefx/issues/4510
+             return null;
+-#else
+-            return new X509Certificate2(certificate);
+-#endif
+         }
+ 
+         private class HttpsAdaptedConnection : IAdaptedConnection",Any chance this is available in .NET Core 2.0 now?,Why is this being removed?
+2569,"@@ -8,16 +8,15 @@ package blocksync
+ 
+ import (
+ 	""context""
+-	""net""
+ 
+ 	""github.com/golang/protobuf/proto""
++	peerstore ""github.com/libp2p/go-libp2p-peerstore""
+ 	""go.uber.org/zap""
+ 
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""
+ 	""github.com/iotexproject/iotex-core/config""
+-	""github.com/iotexproject/iotex-core/p2p/node""
+ 	""github.com/iotexproject/iotex-core/pkg/lifecycle""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/routine""","I wonder if it's necessary to let app pass in the context. What app level context should be sent? If no, is it enough for p2p agent to compose a context with network info there?",nit: remove empty line
+2570,"@@ -26,8 +26,11 @@
+ 
+ #define LBANN_INPUT_LAYER_INSTANTIATE
+ #include ""lbann/layers/io/input_layer.hpp""
+-#include ""lbann/utils/profiling.hpp""
++
+ #include ""lbann/callbacks/imcomm.hpp""
++#include ""lbann/execution_contexts/execution_context.hpp""
++#include ""lbann/execution_contexts/sgd_execution_context.hpp""
++#include ""lbann/utils/profiling.hpp""
+ #include ""lbann/utils/serialize.hpp""
+ 
+ namespace lbann {",Why do we need both includes here?,Why is this header needed?
+2571,"@@ -600,7 +600,7 @@ public class SmartStore  {
+ 	    	List<String> soupNames = new ArrayList<String>();
+ 	        Cursor cursor = null;
+ 			try {
+-				cursor = DBHelper.getInstance(db).query(db, SOUP_NAMES_TABLE, new String[]{SOUP_NAME_COL}, null, null, null);
++				cursor = DBHelper.getInstance(db).query(db, SOUP_NAMES_TABLE, new String[]{SOUP_NAME_COL}, SOUP_NAME_COL, null, null);
+ 	            if (cursor.moveToFirst()) {
+ 	                do {
+ 	                    soupNames.add(cursor.getString(0));",SmartStoreInspectorTest expected results in a certain order,Why is this change needed?
+2572,"@@ -310,6 +310,11 @@ const conduit::Node& data_reader_jag_conduit::get_conduit_node(const conduit::No
+ }
+ 
+ bool data_reader_jag_conduit::load_conduit_node(const size_t i, const std::string& key, conduit::Node& node) const {
++
++  if (m_io_thread_pool != nullptr && m_using_random_node.count(m_io_thread_pool->get_local_thread_id())) {
++    LBANN_ERROR(""previously retrieved a random conduit node from data_store, so shouldn't be here"");
++  }
++
+   const sample_t& s = m_sample_list[i];
+   const std::string& sample_name = s.second;
+   const std::string path = sample_name + key;",I think that you need something like `m_using_random_node.emplace(m_io_thread_pool->get_local_thread_id());`,"I don't think this is the right place to put this check. If we are loading a random conduit node from the data store, then we should not be loading it from the data store."
+2573,"@@ -175,6 +175,9 @@ public class UnusedAssignmentRule extends AbstractJavaRule {
+                 if (isIgnorablePrefixIncrement(entry.rhs)) {
+                     continue;
+                 }
++                if (isUsedLocalVarWithoutInitializer(entry, result.usedVariables)) {
++                    continue;
++                }
+ 
+                 Set<AssignmentEntry> killers = result.killRecord.get(entry);
+                 final String reason;","I don't think we need to maintain a separate set. The problem here is that the ""assignment"" that is killed for this variable is not really an assignment. If we just don't `assign` the variable with the non-existent value, it will not be reported. I pushed a fix.",Why do we need this check?
+2574,"@@ -209,4 +209,9 @@ public interface TableScan {
+    */
+   boolean isCaseSensitive();
+ 
++  /**
++   * Returns the target split size for this scan.
++   */
++  long targetSplitSize();
++
+ }","Let me know if this is too pervasive. It is currently a private method in `BaseTableScan`. It seems both `SparkBatchQueryScan` and `SparkMergeScan` need to know the scan-specific split size when planning tasks. Therefore, I made it open. Another approach is to move all the `planTasks` logic to scan implementations, but for the combine tasks by partition feature, it requires grouping scan tasks by partition first, instead of returning them in an iterator fashion. I'm not sure if this is OK. `SparkMergeScan` also seems to re-implemented its own plan tasks logic.",nit: `Returns the target split size for this scan.`
+2575,"@@ -1550,7 +1550,8 @@ func (c *client) flushSignal() {
+ func (c *client) traceMsg(msg []byte) {
+ 	maxTrace := c.srv.getOpts().MaxTracedMsgLen
+ 	if maxTrace > 0 && (len(msg)-LEN_CR_LF) > maxTrace {
+-		c.Tracef(""<<- MSG_PAYLOAD: [\""%s...\""]"", msg[:maxTrace])
++		tm := fmt.Sprintf(""%q"", msg[:maxTrace])
++		c.Tracef(""<<- MSG_PAYLOAD: [\""%s...\""]"", tm[1:maxTrace+1])
+ 	} else {
+ 		c.Tracef(""<<- MSG_PAYLOAD: [%q]"", msg[:len(msg)-LEN_CR_LF])
+ 	}",Not sure what is this change doing?,Why do we need this change?
+2576,"@@ -272,8 +272,9 @@ def revoke_user_code_tokens(user):
+         db.session.delete(code)
+     revoke_tokens(user)
+ 
+-def get_exp(mins=30):
+-    return datetime.utcnow() + timedelta(minutes=mins)
++def get_exp(mins=None):
++    delta = timedelta(minutes=mins) if mins is not None else timedelta(days=90)
++    return datetime.utcnow() + delta
+ 
+ def issue_token(user, exp=None):
+     uuid = generate_uuid()","this is funky. either don't take` minutes` as keyword arg or take both `minutes` and `days` and pass all of them on to `timedelta`. i'm guessing you're aiming for backwards compatibility, but i don't think it's worth it given how confusing this is. atlernatively, make `mins=60*24*30` the default. and that brings me to another issue, `mins=None` is not a very useful default.",I think this should be `days=90`
+2577,"@@ -267,6 +267,11 @@ public final class RememberMeConfigurer<H extends HttpSecurityBuilder<H>>
+ 		validateInput();
+ 		String key = getKey();
+ 		RememberMeServices rememberMeServices = getRememberMeServices(http, key);
++		if (key == null) {
++			if (rememberMeServices instanceof AbstractRememberMeServices) {
++			    key = ((AbstractRememberMeServices) rememberMeServices).getKey();
++			}
++		}
+ 		http.setSharedObject(RememberMeServices.class, rememberMeServices);
+ 		LogoutConfigurer<H> logoutConfigurer = http.getConfigurer(LogoutConfigurer.class);
+ 		if (logoutConfigurer != null && this.logoutHandler != null) {",Please use a tab for indentation instead of spaces.,Why is this needed?
+2578,"@@ -40,7 +40,7 @@ import java.util.stream.Collector;
+  * @since 2.0.0
+  */
+ @SuppressWarnings(""deprecation"")
+-public final class Queue<T> extends AbstractsQueue<T, Queue<T>> implements LinearSeq<T>, Kind1<Queue<T>, T> {
++public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements LinearSeq<T>, Kind1<Queue<T>, T> {
+ 
+     private static final long serialVersionUID = 1L;
+ ",I can't believe we didn't see this typo before :)),Why this change?
+2579,"@@ -25,6 +25,9 @@ from Queue import Empty, Queue
+ from google.cloud.forseti.services.inventory.base import crawler
+ from google.cloud.forseti.services.inventory.base import gcp
+ from google.cloud.forseti.services.inventory.base import resources
++from google.cloud.forseti.common.util import log_util
++
++LOGGER = log_util.get_logger(__name__)
+ 
+ 
+ class CrawlerConfig(crawler.CrawlerConfig):","If the logger isn't used, it probably doesn't need to be added.",Is this used anywhere?
+2580,"@@ -0,0 +1,4 @@
++var script = document.createElement('script')
++script.type = 'text/javascript'
++script.src = '{}'
++document.head.appendChild(script)",These files should in `/javascript/brython`,Why do we need this?
+2581,"@@ -54,11 +54,15 @@ func (ci *CreateImages) UnmarshalJSON(b []byte) error {
+ 
+ func imageUsesAlphaFeatures(imagesAlpha []*ImageAlpha) bool {
+ 	for _, imageAlpha := range imagesAlpha {
+-		if imageAlpha != nil && len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 {
+-			return true
++		if imageAlpha != nil && imageAlpha.RolloutOverride != nil {
++			if len(imageAlpha.RolloutOverride.DefaultRolloutTime) > 0 {
++				return true
++			}
+ 		}
+-		if imageAlpha != nil && len(imageAlpha.Deprecated.StateOverride.DefaultRolloutTime) > 0 {
+-			return true
++		if imageAlpha != nil && imageAlpha.Deprecated != nil && imageAlpha.Deprecated.StateOverride != nil {
++			if len(imageAlpha.Deprecated.StateOverride.DefaultRolloutTime) > 0 {
++				return true
++			}
+ 		}
+ 	}
+ 	return false","minor, you can squash these into one `if`",Why do we need to ch
+2582,"@@ -73,7 +73,7 @@ func (s *transmissionTaskSuite) TearDownTest() {
+ 
+ func (s *transmissionTaskSuite) TestHandleTransmissionTask_RegisterNamespaceTask_IsGlobalNamespace() {
+ 	taskType := replicationgenpb.ReplicationTaskType_NamespaceTask
+-	id := primitives.NewUUID()
++	id := primitives.NewUUID().String()
+ 	name := ""some random namespace test name""
+ 	status := namespacepb.NamespaceStatus_Registered
+ 	description := ""some random test description""","Used regexes to do most of this, hence different methods of string creation of UUIDs. I plan to follow up with an additional change to remove direct references to google/pborman UUID so `uuid.New()` and `uuid.NewRandom()` will instead use our `primitives.UUID`.",Why do we need this 
+2583,"@@ -581,7 +581,7 @@ namespace pwiz.Skyline.Controls.Graphs
+                     requestContext.Settings = null;
+                 }
+ 
+-                if (GraphSummary.IsHandleCreated)
++                if (GraphSummary.IsHandleCreated && !GraphSummary.Disposing)
+                 {
+                     try
+                     {",Add a TODO here to revisit if this was problematic.,Why is this needed?
+2584,"@@ -23,7 +23,11 @@ class SSDHead(AnchorHead):
+         anchor_generator (dict): Config dict for anchor generator
+         bbox_coder (dict): Config of bounding box coder.
+         reg_decoded_bbox (bool): If true, the regression loss would be
+-            applied on decoded bounding boxes. Default: False
++            applied directly on decoded bounding boxes, meaning both the
++            predicted boxes and regression targets are with absolute
++            coordinates format. Default False. Note generally it should be
++            set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`
++            in the bbox head.
+         train_cfg (dict): Training config of anchor head.
+         test_cfg (dict): Testing config of anchor head.
+     """"""  # noqa: W605",Note generally it -> It,"I think it would be better to say that `reg_decoded_bbox` is True when using `IoULoss`, `GIoULoss`, or `DIoULoss` in the bbox head."
+2585,"@@ -51,6 +51,7 @@ model* instantiate_model(lbann_comm* comm,
+   if (type == ""directed_acyclic_graph_model"") {
+     return new directed_acyclic_graph_model(comm, mini_batch_size, obj, opt);
+   }
++#if 0
+   if (type == ""recurrent_model"") {
+     const auto& params = proto_model.recurrent();
+     return new recurrent_model(comm,",Is this relevant to this PR?,Why is this disabled?
+2586,"@@ -102,7 +102,7 @@ module Beaker
+         end
+         if block_hosts.is_a? Array
+           if block_hosts.length > 0
+-            if opts[:run_in_parallel]
++            if opts[:run_in_parallel] == true
+               # Pass caller[1] - the line that called block_on - for logging purposes.
+               result = block_hosts.map.each_in_parallel(caller[1]) do |h|
+                 run_block_on h, &block","Can we instead ensure that `opts[:run_in_parellel]` will always be a boolean? Otherwise we'll have to account for the case when it's a non-boolean value in multiple places, such as any/every other `if` statement.",Why not just `if opts[:run_in_parallel]`?
+2587,"@@ -25,6 +25,11 @@ import (
+ 	""go.opentelemetry.io/otel/codes""
+ )
+ 
++var (
++	HTTPSchemeHTTP  = HTTPSchemeKey.String(""http"")
++	HTTPSchemeHTTPS = HTTPSchemeKey.String(""https"")
++)
++
+ // NetAttributesFromHTTPRequest generates attributes of the net
+ // namespace as specified by the OpenTelemetry specification for a
+ // span.  The network parameter is a string that net.Dial function",Is this just moved out of the other files? It doesn't seem like this was generated like the other files.,nit: can we call this `HTTPScheme`?
+2588,"@@ -0,0 +1,14 @@
++using System.IO;
++using System.Threading.Tasks;
++
++namespace HttpOverStream
++{
++    internal interface IHttpContent
++    {
++        long? Length { get; }
++
++        void CopyTo(Stream destination);
++
++        Task CopyToAsync(Stream destination);
++    }
++}","I started out doing everything `async`, but it was getting in the way of debugging, so I switched back to all synchronous until I got things working. We should probably move everything back to `async` and remove the synchronous versions.",Why do we need this interface?
+2589,"@@ -98,7 +98,9 @@ namespace Nethermind.Mev.Test
+             protected override IBlockProducer CreateTestBlockProducer(TxPoolTxSource txPoolTxSource, ISealer sealer, ITransactionComparerProvider transactionComparerProvider)
+             {
+                 MiningConfig miningConfig = new() {MinGasPrice = UInt256.One};
+-                
++
++                MevBlockProducerTransactionsExecutorFactory mevExecutorFactory = new(SpecProvider, LogManager);
++
+                 BlockProducerEnvFactory blockProducerEnvFactory = new(
+                     DbProvider, 
+                     BlockTree, ",this looks already too complicated...,Why do we need this factory?
+2590,"@@ -176,6 +176,18 @@ TEST(RocksEngineTest, OptionTest) {
+             engine->setDBOption(""max_background_compactions"", ""bad_value""));
+ }
+ 
++TEST(RocksEngineTest, CompactTest) {
++    fs::TempDir rootPath(""/tmp/rocksdb_compact_test.XXXXXX"");
++    auto engine = std::make_unique<RocksEngine>(0, rootPath.path());
++    std::vector<KV> data;
++    for (int32_t i = 2; i < 8;  i++) {
++        data.emplace_back(folly::stringPrintf(""key_%d"", i),
++                          folly::stringPrintf(""value_%d"", i));
++    }
++    EXPECT_EQ(ResultCode::SUCCEEDED, engine->multiPut(std::move(data)));
++    EXPECT_EQ(ResultCode::SUCCEEDED, engine->compactAll());
++}
++
+ }  // namespace kvstore
+ }  // namespace nebula
+ ","As for the testings, we better to verify the actual effects of the compaction. Of course, you could do it in future.",Why do we need this test?
+2591,"@@ -85,7 +85,9 @@ public class Catalog implements AutoCloseable {
+       if (tableMap == null) {
+         tableMap = loadTables(db);
+       }
+-      return ImmutableList.copyOf(tableMap.values());
++      Collection<TiTableInfo> tables = tableMap.values();
++      tables.removeIf(TiTableInfo::isView);
++      return ImmutableList.copyOf(tables);
+     }
+ 
+     public TiTableInfo getTable(TiDBInfo db, String tableName) {",should we add a TODO here?,Why is this needed?
+2592,"@@ -35,14 +35,12 @@ import { Component, render } from '@wordpress/element';
+ import { loadTranslations } from './util';
+ import './components/notifications';
+ import DashboardDetailsApp from './components/dashboard-details/dashboard-details-app';
+-import ErrorHandler from './components/ErrorHandler';
++import Root from './components/root';
+ 
+ class GoogleSitekitDashboardDetails extends Component {
+ 	render() {
+ 		return (
+-			<ErrorHandler>
+-				<DashboardDetailsApp />
+-			</ErrorHandler>
++			<DashboardDetailsApp />
+ 		);
+ 	}
+ }",This can be inlined below as `GoogleSitekitDashboardDetails` is an unnecessary wrapper now.,I think this should be `<Root />`
+2593,"@@ -191,7 +191,7 @@ func (s *nDCTransactionMgrSuite) TestBackfillWorkflow_CurrentWorkflow_Active_Clo
+ 	versionHistory := versionhistory.New([]byte(""branch token""), []*historyspb.VersionHistoryItem{
+ 		{EventId: lastWorkflowTaskStartedEventID, Version: lastWorkflowTaskStartedVersion},
+ 	})
+-	histories := versionhistory.NewVHS(versionHistory)
++	histories := versionhistory.NewVersionHistories(versionHistory)
+ 
+ 	releaseCalled := false
+ ",NewVHS -> NewVersionHistories this one looks better,why is this change needed?
+2594,"@@ -36,10 +36,17 @@ module Selenium
+       SOCKET_LOCK_TIMEOUT = 45
+       STOP_TIMEOUT        = 20
+ 
++      @executable = nil
++      @missing = ''
++
++      class << self
++        attr_accessor :executable, :missing_text
++      end
++
+       attr_accessor :host
+ 
+       def initialize(executable_path, port, *extra_args)
+-        @executable_path = executable_path
++        @executable_path = binary_path(executable_path)
+         @host            = Platform.localhost
+         @port            = Integer(port)
+         @extra_args      = extra_args",Is this `@missing_text` ?,Why is this needed?
+2595,"@@ -25,6 +25,7 @@ CONFIG_PATH = BASE_PATH / 'config.yml'
+ OPEN_DATA_URL = ""https://open.quiltdata.com""
+ 
+ PACKAGE_NAME_FORMAT = r""[\w-]+/[\w-]+$""
++SUBPACKAGE_NAME_FORMAT = r""([\w-]+/[\w-]+)(?:/(.+))?$""
+ 
+ ## CONFIG_TEMPLATE
+ # Must contain every permitted config key, as well as their default values (which can be 'null'/None).","Minor suggestion, but wouldn't it be cleaner to simply replace PACKAGE_NAME_FORMAT to all the optional path, then check that the path is empty in validate_package_name? We might also want a helper function to pull out the package name and sub-package path.",I don't think we need this anymor
+2596,"@@ -56,9 +56,9 @@ module.exports = class FileCard extends Component {
+       {this.props.fileCardFor &&
+         <div style=""width: 100%; height: 100%;"">
+           <div class=""uppy-DashboardContent-bar"">
+-            <h2 class=""uppy-DashboardContent-title"">Editing <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
+-            <button class=""uppy-DashboardContent-back"" type=""button"" title=""Finish editing file""
+-              onclick={this.handleClick}>Done</button>
++            <h2 class=""uppy-DashboardContent-title"">{this.props.i18n('editing')} <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
++            <button class=""uppy-DashboardContent-back"" type=""button"" title={this.props.i18n('finishEditingFile')}
++              onclick={this.handleClick}>{this.props.i18n('done')}</button>
+           </div>
+           <div class=""uppy-DashboardFileCard-inner"">
+             <div class=""uppy-DashboardFileCard-preview"" style={{ backgroundColor: getFileTypeIcon(file.type).color }}>","we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `<span/>` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho.",I think this should be `{this.props.i18n('finishEditingFile')}`
+2597,"@@ -254,6 +254,9 @@ fpga_result enum_thermalmgmt_metrics(fpga_metric_vector *vector,
+ 
+ 	for (i = 0; i < pglob.gl_pathc; i++) {
+ 
++		if (!pglob.gl_pathv)
++			continue;
++
+ 		char *dir_name = strrchr(pglob.gl_pathv[i], '/');
+ 
+ 		if (!dir_name)",Probably want break instead of continue.,Shouldn't this be `if (!pglob.gl_pathv)`?
+2598,"@@ -305,7 +305,7 @@ func testMQTTDefaultOptions() *Options {
+ 
+ func testMQTTRunServer(t testing.TB, o *Options) *Server {
+ 	t.Helper()
+-	o.NoLog = false
++	o.NoLog = true
+ 	if o.StoreDir == _EMPTY_ {
+ 		o.StoreDir = createDir(t, ""mqtt_js"")
+ 	}",This was on purpose that I would set logging (NoLog=false) and a dummy logger below. The idea is to have better code coverage and test of debug/trace statements. Any reason you have removed this?,Why was this changed?
+2599,"@@ -83,11 +83,11 @@ public final class StringBuilderConstantParameters
+                     .build();
+         }
+         List<ExpressionTree> arguments = result.get();
+-        Stream<String> prefixStream = arguments.stream().findFirst()
++        Stream<String> prefixStream = arguments.stream()
++                .findFirst()
+                 .map(ASTHelpers::getType)
+-                .filter(type ->
+-                        ASTHelpers.isSameType(type, state.getTypeFromString(""java.lang.String""), state))
+-                .map(ignored -> Stream.<String>of())
++                .filter(type -> ASTHelpers.isSameType(type, state.getTypeFromString(""java.lang.String""), state))
++                .map(ignored -> Stream.<String>empty())
+                 .orElseGet(() -> Stream.of(""\""\""""));
+ 
+         return buildDescription(tree)",does adding a `Stream.<String>empty()` help here?,Why is this change necessary?
+2600,"@@ -36,3 +36,17 @@ TWO_ENABLED = {'scanners': [
+     {'name': 'cloudsql_acl', 'enabled': False},
+     {'name': 'iam_policy', 'enabled': True}
+ ]}
++
++NONEXISTENT_ENABLED = {'scanners': [
++    {'name': 'bigquery', 'enabled': False},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': False},
++    {'name': 'non_exist_scanner', 'enabled': True}
++]}
++
++ALL_EXIST = {'scanners': [
++    {'name': 'bigquery', 'enabled': True},
++    {'name': 'bucket_acl', 'enabled': True},
++    {'name': 'cloudsql_acl', 'enabled': True},
++    {'name': 'iam_policy', 'enabled': True}
++]}","This is not being used anymore, so can be removed.",I don't think this is needed.
+2601,"@@ -127,6 +127,17 @@ type PodIPs struct {
+ 	ipStrings []string
+ }
+ 
++func (p PodIPs) String() string {
++	res := """"
++	if p.ipv4 != nil {
++		res += fmt.Sprintf(""IPv4: %s, "", p.ipv4.String())
++	}
++	if p.ipv6 != nil {
++		res += fmt.Sprintf(""IPv6: %s, "", p.ipv6.String())
++	}
++	return fmt.Sprintf(""%sIP strings: %s"", res, strings.Join(p.ipStrings, "", ""))
++}
++
+ func (p *PodIPs) hasSameIP(p1 *PodIPs) bool {
+ 	if len(p.ipStrings) == 0 && len(p1.ipStrings) == 0 {
+ 		return true",Is it called some where?,I don't think we need the `St
+2602,"@@ -20,10 +20,11 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""fmt""
+-	. ""github.com/openebs/maya/pkg/msg/v1alpha1""
++	""reflect""
++
++	_ ""github.com/openebs/maya/pkg/msg/v1alpha1""
+ 	ft ""k8s.io/client-go/third_party/forked/golang/template""
+ 	jp ""k8s.io/client-go/util/jsonpath""
+-	""reflect""
+ )
+ 
+ type selection struct {",Please remove this extra blank line.,Why is this needed?
+2603,"@@ -176,7 +176,7 @@ public class CheckUnusedDependenciesTask extends DefaultTask {
+         return ignore.get().contains(BaselineExactDependencies.asString(artifact));
+     }
+ 
+-    @Input
++    @InputFiles
+     public final Provider<List<Configuration>> getDependenciesConfigurations() {
+         return dependenciesConfigurations;
+     }","this is really the key, if you don't set this then gradle doesn't wire up the tasks that produce various files inside these configurations as inputs... I think we were just getting lucky before.",Why is this change needed?
+2604,"@@ -14,3 +14,13 @@ func TestNewSnapshot(t *testing.T) {
+ 	_, err := restic.NewSnapshot(paths, nil, ""foo"", time.Now())
+ 	rtest.OK(t, err)
+ }
++
++func TestTagList(t *testing.T) {
++	paths := []string{""/home/foobar""}
++	tags := []string{""""}
++
++	sn, _ := restic.NewSnapshot(paths, nil, ""foo"", time.Now())
++
++	r := sn.HasTags(tags)
++	rtest.Assert(t, r, ""Failed to match untagged snapshot"")
++}","Sorry if I'm missing something here, but shouldn't this message be about failing to match with an *empty* selector, and/or perhaps even an empty *tag* instead of selector? The message seems a bit disconnected from what we're testing?",I think this should be `rtest.Fail`
+2605,"@@ -1,5 +1,8 @@
+ // Copyright (c) Microsoft. All rights reserved.
+ 
++using System.IO;
++using Microsoft.TestPlatform.VsTestConsole.TranslationLayer.Payloads;
++
+ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+ {
+     using System;",nit: please move these inside namespace.,Why is this needed?
+2606,"@@ -139,6 +139,13 @@ var (
+ 		Value:  metadata.Testnet3Definition.Testnet3HermesURL,
+ 		Hidden: true,
+ 	}
++	// FlagPaymentsDuringSessionDebug sets if we're in debug more for the payments done in a VPN session.
++	FlagPaymentsDuringSessionDebug = cli.BoolFlag{
++		Name:   ""payments.during-session-debug"",
++		Usage:  ""Set debug mode for payments made during a session, it will bypass any price validation and allow absurd prices during sessions"",
++		Value:  false,
++		Hidden: true,
++	}
+ )
+ 
+ // RegisterFlagsPayments function register payments flags to flag list.",may users try to abuse it?,nit: typo `absurd`
+2607,"@@ -242,8 +242,9 @@ public class FlatBufferBuilder {
+         int new_buf_size = old_buf_size == 0 ? 1 : old_buf_size << 1;
+         bb.position(0);
+         ByteBuffer nbb = bb_factory.newByteBuffer(new_buf_size);
++        new_buf_size = nbb.capacity(); // TODO - Maybe we get the buffer's `limit()`
+         nbb.position(new_buf_size - old_buf_size);
+-        nbb.put(bb);
++       nbb.put(bb);
+         return nbb;
+     }
+ ",why is this space removed?,I'm not sure if this is the right p
+2608,"@@ -1,3 +1,4 @@
++//go:build !windows
+ // +build !windows
+ 
+ // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.",Can we remove this other line now then?,//go:build !windows
+2609,"@@ -52,6 +52,7 @@ PERFECT_FILES = [
+     'qutebrowser/misc/checkpyver.py',
+     'qutebrowser/misc/guiprocess.py',
+     'qutebrowser/misc/editor.py',
++    'qutebrowser/misc/cmdhistory.py'
+ 
+     'qutebrowser/mainwindow/statusbar/keystring.py',
+     'qutebrowser/mainwindow/statusbar/percentage.py',",There's a comma missing here at the end :wink:,Why is this added?
+2610,"@@ -19,13 +19,8 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         [Required]
+         public string AccountKey { get; set; }
+ 
+-        [Required]
+         public ITaskItem[] ItemsToPush { get; set; }
+ 
+-        public string IndexDirectory { get; set; }
+-
+-        public bool PublishFlatContainer { get; set; }
+-
+         public bool Overwrite { get; set; }
+ 
+         public override bool Execute()",Why is this not required any longer?,Why are these remov
+2611,"@@ -6,11 +6,13 @@ package admin
+ 
+ import (
+ 	""github.com/Unknwon/com""
++        ""github.com/Unknwon/paginater""
+ 
+ 	""github.com/gogits/gogs/models""
+ 	""github.com/gogits/gogs/modules/base""
+ 	""github.com/gogits/gogs/modules/log""
+ 	""github.com/gogits/gogs/modules/middleware""
++	""github.com/gogits/gogs/modules/setting""
+ )
+ 
+ const (",Indentation seems a bit fucked up here. Run `go fmt`.,This should be grou
+2612,"@@ -650,6 +650,9 @@ func (api *Server) GetLogs(
+ 	ctx context.Context,
+ 	in *iotexapi.GetLogsRequest,
+ ) (*iotexapi.GetLogsResponse, error) {
++	if in.GetFilter() == nil {
++		return nil, status.Error(codes.InvalidArgument, ""empty filter"")
++	}
+ 	switch {
+ 	case in.GetByBlock() != nil:
+ 		req := in.GetByBlock()",any chance in == nil? same below,Why do we need this check?
+2613,"@@ -150,15 +150,15 @@ static int create_spawnproc(h2o_configurator_command_t *cmd, yoml_t *node, const
+     }
+ 
+     /* create socket */
+-    if ((listen_fd = socket(AF_UNIX, SOCK_STREAM, 0)) == -1) {
++    if ((listen_fd = h2o_sysfn(socket, AF_UNIX, SOCK_STREAM, 0)) == -1) {
+         h2o_configurator_errprintf(cmd, node, ""socket(2) failed: %s"", strerror(errno));
+         goto Error;
+     }
+-    if (bind(listen_fd, (void *)sa, sizeof(*sa)) != 0) {
++    if (h2o_sysfn(bind, listen_fd, (void *)sa, sizeof(*sa)) != 0) {
+         h2o_configurator_errprintf(cmd, node, ""bind(2) failed: %s"", strerror(errno));
+         goto Error;
+     }
+-    if (listen(listen_fd, H2O_SOMAXCONN) != 0) {
++    if (h2o_sysfn(listen, listen_fd, H2O_SOMAXCONN) != 0) {
+         h2o_configurator_errprintf(cmd, node, ""listen(2) failed: %s"", strerror(errno));
+         goto Error;
+     }",We would change the source code of h2o so that certain syscalls will be invoked through the `h2o_sysfn` macro.,`h2o_sysfn` is not defined
+2614,"@@ -2895,7 +2895,8 @@ struct SemaphoreSubmitState {
+             (pSemaphore->scope == kSyncScopeInternal || internal_semaphores.count(semaphore))) {
+             if (unsignaled_semaphores.count(semaphore) ||
+                 (!(signaled_semaphores.count(semaphore)) && !(pSemaphore->signaled) && !core->SemaphoreWasSignaled(semaphore))) {
+-                const auto &vuid = GetQueueSubmitVUID(loc, SubmitError::kSemCannotBeSignalled);
++                auto error = core->device_extensions.vk_khr_timeline_semaphore ? SubmitError::kTimelineCannotBeSignalled : SubmitError::kBinaryCannotBeSignalled;
++                const auto &vuid = GetQueueSubmitVUID(loc, error);
+                 skip |= core->LogError(
+                     objlist, pSemaphore->scope == kSyncScopeInternal ? vuid : kVUID_Core_DrawState_QueueForwardProgress,
+                     ""%s Queue %s is waiting on semaphore (%s) that has no way to be signaled."", loc.Message().c_str(),","the name kTimelineCannotBeSignalled is confusing. It's not that a TimelineSemphore cannot be signaled... it's the ""VK_KHR_timeline_semaphore is enabled *variant* of the ""binary cannot be signaled"" message. We should probably have a consistent naming scheme to clarify. kBinaryCannotBeSignalledAltTimeline or hide the complexity in Get*VUID functions as needed somehow (pass in the extension structure?)",I think it would be better
+2615,"@@ -2541,7 +2541,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         return DataFrame(sdf, self._metadata.copy())
+ 
+     # TODO: percentiles, include, and exclude should be implemented.
+-    def describe(self) -> 'DataFrame':
++    def describe(self, percentiles=None) -> 'DataFrame':
+         """"""
+         Generate descriptive statistics that summarize the central tendency,
+         dispersion and shape of a dataset's distribution, excluding",Could you add a type hint? `percentiles: Optional[List[float]] = None`,I don't think you need the
+2616,"@@ -0,0 +1,16 @@
++module Ncr
++  module WorkOrdersHelper
++    def approver_options
++      # @todo should this list be limited by client/something else?
++      # @todo is there a better order? maybe by current_user's use?
++      User.order(:email_address).pluck(:email_address)
++    end
++
++    def building_options
++      custom = Ncr::WorkOrder.where.not(building_number: nil).pluck('DISTINCT building_number')
++      all = custom + Ncr::BUILDING_NUMBERS
++      # @todo is there a better order? maybe by current_user's use?
++      all.uniq.sort
++    end
++  end
++end","Maybe putting ones they've used before first would be good, but this is fine for now.","I'm not sure if this is the best way to do this, but I'm not sure if there's a better way."
+2617,"@@ -105,6 +105,9 @@ func newVXLANManager(
+ 		blackHoleProto = dpConfig.DeviceRouteProtocol
+ 	}
+ 
++	noencTarget := routetable.Target{Type: routetable.TargetTypeNoEncap}
++	bhTarget := routetable.Target{Type: routetable.TargetTypeBlackhole}
++
+ 	brt := routetable.New(
+ 		[]string{routetable.InterfaceNone},
+ 		4,",I don't think we need these. Simpler just to put `routetable.TargetType...` inline below.,I don't think we need this anymore.
+2618,"@@ -43,7 +43,8 @@ class Dispatcher
+     when 'parallel'
+       ParallelDispatcher.new
+     when 'linear'
+-      if cart.ncr?
++      # @todo: dynamic dispatch for selection
++      if cart.proposal.client_data_legacy.client == ""ncr""
+         NcrDispatcher.new
+       else
+         LinearDispatcher.new",Why this instead of the old way?,I don't think this is the right place to do this. I think it should be in the `NcrDispatch
+2619,"@@ -549,10 +549,14 @@ void Mob::SetInvisible(uint8 state)
+ 	invisible = state;
+ 	SendAppearancePacket(AT_Invis, invisible);
+ 	// Invis and hide breaks charms
+-
+ 	auto formerpet = GetPet();
+-	if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden))
+-		formerpet->BuffFadeByEffect(SE_Charm);
++	if (formerpet && formerpet->GetPetType() == petCharmed && (invisible || hidden || improved_hidden || invisible_animals || invisible_undead)) {
++		if (RuleB(Pets, LivelikeBreakCharmOnInvis) || (!RuleB(Pets, LivelikeBreakCharmOnInvis) && IsInvisible(formerpet))) {
++			formerpet->BuffFadeByEffect(SE_Charm);
++		}
++
++		LogRules(""Pets:LivelikeBreakCharmOnInvis for [{}] | Invis [{}] - Hidden [{}] - Shroud of Stealth [{}] - IVA [{}] - IVU [{}]"", GetCleanName(), invisible, hidden, improved_hidden, invisible_animals, invisible_undead);
++	}
+ }
+ 
+ //check to see if `this` is invisible to `other`","Just combining the inner if/else blocks like this is what I originally meant (I didn't mean replacing all the invisible checks in the outer if, I realize that would have been a functionality change regarding the rule) This should now be equivalent to `if (RuleB(Pets, LivelikeBreakCharmOnInvis) || IsInvisible(formerpet))` (the second check for the rule being false after the `||` would be implied, anything after the `||` would only be evaluated if the rule was false)",`invisible_animals` and `invisible_undead` are the same thing.
+2620,"@@ -964,6 +964,9 @@ func loadPluginConfig(subrepoConfig *core.Configuration, packageState *core.Buil
+ 	contextPackage := &core.Package{SubrepoName: packageState.CurrentSubrepo}
+ 	configValueDefinitions := subrepoConfig.PluginConfig
+ 	for key, definition := range configValueDefinitions {
++		if definition.ConfigKey == """" {
++			definition.ConfigKey = strings.ReplaceAll(key, ""_"", """")
++		}
+ 		fullConfigKey := fmt.Sprintf(""%v.%v"", pluginName, definition.ConfigKey)
+ 		value, ok := extraVals[strings.ToLower(definition.ConfigKey)]
+ 		if !ok {",We don't want to write this back to the definition do we? Probably just want to create a local variable for it.,Why do we need this?
+2621,"@@ -964,6 +964,7 @@ public class PlaybackService extends MediaBrowserServiceCompat {
+ 
+         @Override
+         public void onPlaybackEnded(MediaType mediaType, boolean stopPlaying) {
++            PlaybackPreferences.clearCurrentlyPlayingTemporaryPlaybackSpeed();
+             PlaybackService.this.onPlaybackEnded(mediaType, stopPlaying);
+         }
+     };",Good catch! Could you please move this to `PlaybackService.this.onPlaybackEnded`? I think it's more clean if everything is in one single place.,I'm not sure if this
+2622,"@@ -421,6 +421,7 @@ void LXQtTaskButton::activateWithDraggable()
+     // in progress to allow drop it into an app
+     raiseApplication();
+     KWindowSystem::forceActiveWindow(mWindow);
++    xcb_flush(QX11Info::connection());
+ }
+ 
+ /************************************************",We're trying to avoid X.org specific code. So I'm not a fan of this. Can't this be achieved in display server agnostic way?,Why is this needed?
+2623,"@@ -0,0 +1,8 @@
++using System;
++
++namespace Collections.Core
++{
++    public class Class1
++    {
++    }
++}",This class can be removed?,Why is this needed?
+2624,"@@ -13,8 +13,10 @@ import (
+ 	""net""
+ 	""strconv""
+ 
++	""github.com/iotexproject/iotex-core/action/protocol""
++
+ 	""github.com/golang/protobuf/proto""
+-	grpc_prometheus ""github.com/grpc-ecosystem/go-grpc-prometheus""
++	""github.com/grpc-ecosystem/go-grpc-prometheus""
+ 	""github.com/pkg/errors""
+ 	""go.uber.org/zap""
+ 	""google.golang.org/grpc""",File is not `goimports`-ed (from `goimports`),nit: remove empty line
+2625,"@@ -72,9 +72,7 @@ type Config struct {
+ 
+ 	// Logger provides a logger for the dispatcher. The default logger is a
+ 	// no-op.
+-	// TODO(shah): Export this when we're ready to deploy a branch in
+-	// demo-yarpc-go.
+-	logger *zap.Logger
++	Logger *zap.Logger
+ }
+ 
+ // Inbounds contains a list of inbound transports. Each inbound transport","To minimize the possibility of regret, perhaps we name this `ZapLogger`.",Why is this no-op now?
+2626,"@@ -40,8 +40,9 @@ IntercomRails.config do |config|
+     user_hash: Proc.new { |current_user| OpenSSL::HMAC.hexdigest(""sha256"",
+                                                                  ENV['INTERCOM_API_SECRET'],
+                                                                  current_user.email) },
+-
+-    :plan => Proc.new { |current_user| current_user.plan_name },
++    plan: :plan_name,
++    has_logged_in_to_forum: :has_logged_in_to_forum?
++    has_active_subscription: :has_active_subscription?
+   }
+ 
+   # == User -> Company association","This looks a little weird, but it's a feature of the gem we're using. You can give it a symbol representing the method you want called on current_user.",Style/SymbolProc: Use 
+2627,"@@ -20,13 +20,11 @@
+ # ----------------------------------------------------------------------
+ 
+ """"""
+-Template file used by the OPF Experiment Generator to generate the actual
+-description.py file by replacing $XXXXXXXX tokens with desired values.
+-
+-This description.py file was generated by:
+-'~/nupic/eng/lib/python2.6/site-packages/nupic/frameworks/opf/expGenerator/ExpGenerator.py'
++Anomaly hotgym example
+ """"""
+ 
++from nupic.algorithms.anomaly import Anomaly
++
+ from nupic.frameworks.opf.expdescriptionapi import ExperimentDescriptionAPI
+ 
+ from nupic.frameworks.opf.expdescriptionhelpers import (","`Anomaly` imported here, but not used. Please run the changed files through pylint with nupic pylint config and fix pylint findings related to your changes.",Why is this file being
+2628,"@@ -42,8 +42,18 @@ testUtils.checkSetup = function (content, options, target) {
+ 		target = options;
+ 		options = {};
+ 	}
++	// Normalize target, allow it to be the inserted node or '#target'
++	target = target || (content instanceof Node ? content : '#target');
+ 	testUtils.fixtureSetup(content);
+-	var node = axe.utils.querySelectorAll(axe._tree[0], target || '#target')[0];
++
++	var node;
++	if (typeof target === 'string') {
++		node = axe.utils.querySelectorAll(axe._tree[0], target)[0];
++	} else if (target instanceof Node) {
++		node = axe.utils.getNodeFromTree(axe._tree[0], target);
++	} else {
++		node = target;
++	}
+ 	return [node.actualNode, options, node];
+ };
+ ",We needed this testutils file after all  ,"I'm not sure if this is the best way to do this. I think it would be better to use `axe.utils.getNodeFromTree(axe._tree[0], target)` instead."
+2629,"@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		big.NewInt(10),
+ 	)
+ 	pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
+-	sig, _ := hex.DecodeString(""9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01"")
++	sig, _ := hex.DecodeString(""c05c3ff8c9820038c03881c97f544593619ca4d1617c7c6d695aaf828339da9616877649d70948094a05a86b171320d1aae9afa4432606be3b263f808e11816e00"")
+ 	bd := &action.EnvelopeBuilder{}
+ 	elp := bd.SetAction(tsf0).
+ 		SetDestinationAddress(ta.Addrinfo[""producer""].Bech32()).",line is 161 characters (from `lll`),Why did this change?
+2630,"@@ -19,6 +19,8 @@ import (
+ 	""fmt""
+ 	""time""
+ 
++	""github.com/chaos-mesh/chaos-mesh/pkg/controllerutils""
++
+ 	dnspb ""github.com/chaos-mesh/k8s_dns_chaos/pb""
+ 	""github.com/go-logr/logr""
+ 	""golang.org/x/sync/errgroup""",Please re-format/groupimport this line. You might need a little manual work.,nit: remove empty line
+2631,"@@ -35,7 +35,11 @@ type DaisyWorker interface {
+ // designed to be run once and discarded. In other words, don't run RunAndReadSerialValue
+ // twice on the same instance.
+ func NewDaisyWorker(wf *daisy.Workflow, env EnvironmentSettings, logger logging.Logger) DaisyWorker {
+-	return &defaultDaisyWorker{wf, env, logger}
++	worker := &defaultDaisyWorker{wf, env, logger}
++	worker.env.ApplyToWorkflow(worker.wf)
++	worker.env.ApplyWorkerCustomizations(worker.wf)
++	daisy_utils.UpdateAllInstanceNoExternalIP(worker.wf, worker.env.NoExternalIP)
++	return worker
+ }
+ 
+ type defaultDaisyWorker struct {","minor, you can just use `wf` instead of `worker.wf`",Why do we need to do this?
+2632,"@@ -161,11 +161,12 @@ public final class HttpRequestUtilsTest {
+   @Test
+   public void testGetJsonBodyForSingleMapObject() throws IOException, ServletException {
+     final HttpServletRequest httpRequest = Mockito.mock(HttpServletRequest.class);
+-    final String originalString = ""  {\n"" + ""    \""action\"": \""update\"",\n"" + ""    \""table\"": \""ramp\"",\n""
+-        + ""    \""conditions\"" : {\n"" + ""      \""rampId\"" : \""dali\""\n"" + ""    },\n""
+-        + ""    \""values\"": {\n""
+-        + ""      \""rampStage\"": 2,\n"" + ""      \""lastUpdatedTime\"": 1566259437000\n"" + ""    }\n""
+-        + ""  }\n"";
++    final String originalString =
++        ""  {\n"" + ""    \""action\"": \""update\"",\n"" + ""    \""table\"": \""ramp\"",\n""
++            + ""    \""conditions\"" : {\n"" + ""      \""rampId\"" : \""dali\""\n"" + ""    },\n""
++            + ""    \""values\"": {\n""
++            + ""      \""rampStage\"": 2,\n"" + ""      \""lastUpdatedTime\"": 1566259437000\n"" + ""    }\n""
++            + ""  }\n"";
+     final InputStream inputStream = new ByteArrayInputStream(originalString.getBytes(UTF_8));
+     final InputStreamReader inputStreamReader = new InputStreamReader(inputStream, UTF_8);
+     final BufferedReader bufferedReader = new BufferedReader(inputStreamReader);",I would suggest putting this in the resources directory with the same package as of this test class. Then you can utilize the method azkaban.utils.TestUtils#readResource to read it as string.,Can you revert the formatting changes?
+2633,"@@ -21,6 +21,7 @@ import (
+ 	""text/template""
+ 
+ 	errors ""github.com/openebs/maya/pkg/errors/v1alpha1""
++	templates ""github.com/openebs/maya/pkg/upgrade/templates""
+ 	appsv1 ""k8s.io/api/apps/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	types ""k8s.io/apimachinery/pkg/types""","could not import github.com/openebs/maya/pkg/upgrade/templates (invalid package name: """") (from `typecheck`)","""github.com/sirupsen/logrus"""
+2634,"@@ -182,7 +182,7 @@ namespace OpenTelemetry.Exporter.Prometheus.Tests
+             // Once a pull model is implemented, we'll not have this issue and we need to add tests
+             // at that time.
+ 
+-            // If in future, there is a official .NET Prometheus Client library, and OT Exporter
++            // If in future, there is a official .NET Prometheus Client library, and OTel Exporter
+             // choses to take a dependency on it, then none of these concerns arise.
+         }
+     }",a official -> an official,I'm not sure this is correct.
+2635,"@@ -37,7 +37,7 @@ class ProxyListenerKinesis(ProxyListener):
+     def forward_request(self, method, path, data, headers):
+         data, encoding_type = self.decode_content(data or '{}', True)
+         action = headers.get('X-Amz-Target', '').split('.')[-1]
+-        if action == 'RegisterStreamConsumer':
++        if action == 'RegisterStreamConsumer' and config.KINESIS_PROVIDER == 'kinesalite':
+             stream_arn = data.get('StreamARN', '').strip('"" ')
+             cons_arn = data.get('ConsumerARN', '').strip('"" ')
+             cons_name = data.get('ConsumerName', '').strip('"" ')",I only want the proxy request for this to run for kinesalite.,Why do we need to check for kinesalite
+2636,"@@ -272,7 +272,7 @@ var DatePicker = React.createClass({displayName: 'DatePicker',
+       React.DOM.div(null, 
+         DateInput({
+           date: this.props.selected, 
+-          dateFormat: this.props.dateFormat,
++          dateFormat: this.props.dateFormat, 
+           focus: this.state.focus, 
+           onBlur: this.handleBlur, 
+           onFocus: this.handleFocus, ",White space boya?,Why did you change this?
+2637,"@@ -79,6 +79,9 @@ type StackEvent cloudformation.StackEvent
+ // StackDescription represents an existing AWS CloudFormation stack.
+ type StackDescription cloudformation.Stack
+ 
++// StackSummary represents a summary of an existing AWS CloudFormation stack.
++type StackSummary cloudformation.StackSummary
++
+ // SDK returns the underlying struct from the AWS SDK.
+ func (d *StackDescription) SDK() *cloudformation.Stack {
+ 	raw := cloudformation.Stack(*d)",Maybe ditch these since `StackSummary` is not used anymore.,Why is this exported?
+2638,"@@ -21,14 +21,15 @@ class BaseSemanticHead(BaseModule, metaclass=ABCMeta):
+                  num_classes,
+                  init_cfg=None,
+                  loss_seg=dict(
+-                     type='CrossEntropyLoss', ignore_index=-1,
++                     type='CrossEntropyLoss',
++                     ignore_index=255,
+                      loss_weight=1.0)):
+         super(BaseSemanticHead, self).__init__(init_cfg)
+         self.loss_seg = build_loss(loss_seg)
+         self.num_classes = num_classes
+ 
+     @force_fp32(apply_to=('seg_preds', ))
+-    def loss(self, seg_preds, gt_semantic_seg, label_bias=1):
++    def loss(self, seg_preds, gt_semantic_seg):
+         """"""Get the loss of semantic head.
+ 
+         Args:",suggest to indicate the value range & meaning in docstring,Why this change?
+2639,"@@ -20,7 +20,7 @@ const (
+ 	// calls.
+ 	listenAddress = "":9500""
+ 	// metricsPath is the endpoint of exporter.
+-	metricsPath = ""/metrics""
++	metricsPath = ""/metrics/""
+ 	// controllerAddress is the address where jiva controller listens.
+ 	controllerAddress = ""http://localhost:9501""
+ 	// casType is the type of container attached storage (CAS) from which","not sure if it works with prometheus by default, otherwise we will have to add this into prometheus config also",Why this change?
+2640,"@@ -24,6 +24,10 @@ import (
+ 	""github.com/projectcalico/felix/stringutils""
+ )
+ 
++func (r *DefaultRuleRenderer) CleanupEndPoint(ifaceName string) {
++	r.epmm.RemoveEndPointMark(ifaceName)
++}
++
+ func (r *DefaultRuleRenderer) WorkloadDispatchChains(
+ 	endpoints map[proto.WorkloadEndpointID]*proto.WorkloadEndpoint,
+ ) []*Chain {",The rule renderer isn't meant to be stateful so probably best to move this out of here,Why do we need this method?
+2641,"@@ -57,6 +57,7 @@ func setupContainerdConfig(ctx context.Context, cfg *config.Node) error {
+ 		DisableCgroup:         disableCgroup,
+ 		IsRunningInUserNS:     isRunningInUserNS,
+ 		PrivateRegistryConfig: privRegistries.Registry(),
++		ExtraRuntimes:         findNvidiaContainerRuntimes(nil),
+ 	}
+ 
+ 	selEnabled, selConfigured, err := selinuxStatus()","passing in a `nil` here just so that the tests can pass in an alternative implementation seems weird, but I don't know what the convention is for doing something like this - @briandowns?",Why do we need this?
+2642,"@@ -3,12 +3,12 @@
+ 'use strict';
+ 
+ var clone = require('clone');
+-var dot = require('@deque/dot');
++var doT = require('@deque/dot');
+ var templates = require('./templates');
+ var buildManual = require('./build-manual');
+ var entities = new (require('html-entities').AllHtmlEntities)();
+ var packageJSON = require('../package.json');
+-var dotRegex = /\{\{.+?\}\}/g;
++var doTRegex = /\{\{.+?\}\}/g;
+ 
+ var axeVersion = packageJSON.version.substring(
+   0,",IMO `dot` should be preferred. Remember `aXe`?,I think this should be `doT
+2643,"@@ -59,6 +59,7 @@ namespace AppDomain.Instance
+                 return -10;
+             }
+ 
++            Console.ReadKey();
+             return 0;
+         }
+     }","Not a huge deal but this will block tests, also, don't they stay open by default now?",Why is this needed?
+2644,"@@ -70,7 +70,7 @@ func makeLevels(min logrus.Level) []logrus.Level {
+ }
+ 
+ func makeTelemetryState(cfg TelemetryConfig, hookFactory hookFactory) (*telemetryState, error) {
+-	history := createLogBuffer(cfg.LogHistoryDepth)
++	history := createLogBuffer(2)
+ 	if cfg.SessionGUID == """" {
+ 		cfg.SessionGUID = uuid.NewV4().String()
+ 	}",Could you make it a local constant for now ?,Why is this change needed?
+2645,"@@ -950,6 +950,10 @@ class UserResource(object):
+                 if has_invalid_value:
+                     raise_invalid(self.request, **error_details)
+ 
++            if field in ('id', 'collection_id'):
++                if isinstance(value, int):
++                    value = str(value)
++
+             filters.append(Filter(field, value, operator))
+ 
+         return filters",What is this `collection_id` field here?,Why is this needed?
+2646,"@@ -698,7 +698,10 @@ class Automaton(six.with_metaclass(Automaton_metaclass)):
+     # Services
+     def debug(self, lvl, msg):
+         if self.debug_level >= lvl:
+-            log_interactive.debug(msg)
++            if conf.interactive:
++                log_interactive.debug(msg)
++            else:
++                print(msg)
+ 
+     def send(self, pkt):
+         if self.state.state in self.interception_points:",Is there a reason why we don't use logging for this?,Why is this needed?
+2647,"@@ -0,0 +1,18 @@
++<?php
++
++/**
++ * Copyright © Bold Brand Commerce Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Core\Infrastructure\Exception;
++
++class DenoralizationException extends NormalizerException
++{
++    public function __construct(string $message, \Throwable $previous = null)
++    {
++        parent::__construct($message, $previous);
++    }
++}",Exceptions should be placed in application layer -> infrastructure is aware of application - not the other way around,Why do we need this?
+2648,"@@ -34,6 +34,7 @@ def test_simple_json_output():
+         (""column"", 0),
+         (""line"", 1),
+         (""message"", ""Line too long (1/2)""),
++        (""message-id"", ""C0301""),
+         (""module"", ""0123""),
+         (""obj"", """"),
+         (""path"", ""0123""),",IIRC issue mentioned reporting _symbolic message_ - so in this case it would be `line-too-long`.,I think this should be `message-id` not `message`.
+2649,"@@ -1427,6 +1427,7 @@ int GetSpellStatValue(uint32 spell_id, const char* stat_identifier, uint8 slot)
+ 	else if (id == ""descnum"") { return spells[spell_id].descnum; }
+ 	else if (id == ""effectdescnum"") { return spells[spell_id].effectdescnum; }
+ 	else if (id == ""npc_no_los"") { return spells[spell_id].npc_no_los; }
++	else if (id == ""feedbackable"") { return spells[spell_id].reflectable; }
+ 	else if (id == ""reflectable"") { return spells[spell_id].reflectable; }
+ 	else if (id == ""bonushate"") { return spells[spell_id].bonushate; }
+ 	else if (id == ""endurcost"") { return spells[spell_id].EndurCost; }","Is this intended to be `spells[spell_id].reflectable` here? Edit: Should be `spells[spell_id].feedbackable`, right?","Shouldn't this be ""feedback""?"
+2650,"@@ -0,0 +1,11 @@
++class AddUsersAllowedToTeams < ActiveRecord::Migration
++  def up
++    add_column :teams, :max_users, :integer
++
++    change_column_null :teams, :max_users, false, 0
++  end
++
++  def down
++    remove_column :teams, :max_users
++  end
++end",How should we set this for existing teams?,I don't think we need a migration for this.
+2651,"@@ -145,6 +145,11 @@ func TestInstallManager(t *testing.T) {
+ 			expectPasswordSecret:          true,
+ 			expectProvisionMetadataUpdate: true,
+ 		},
++		{
++			name:        ""infraID already set on cluster provision"", // fatal error
++			existing:    []runtime.Object{testClusterDeployment(), testClusterProvisionWithInfraIDSet()},
++			expectError: true,
++		},
+ 	}
+ 	for _, test := range tests {
+ 		t.Run(test.name, func(t *testing.T) {","It would be nice if we could verify that this is in fact the error we expected. But that's a latent issue, something for the backlog.",nit: can you add a case where the infraID is not s
+2652,"@@ -23,11 +23,11 @@ import (
+ 	""testing""
+ 	""time""
+ 
++	""github.com/mysteriumnetwork/go-openvpn/openvpn""
++	""github.com/mysteriumnetwork/go-openvpn/openvpn/middlewares/state""
+ 	""github.com/mysteriumnetwork/node/client/stats""
+ 	""github.com/mysteriumnetwork/node/communication""
+ 	""github.com/mysteriumnetwork/node/identity""
+-	""github.com/mysteriumnetwork/node/openvpn""
+-	""github.com/mysteriumnetwork/node/openvpn/middlewares/state""
+ 	""github.com/mysteriumnetwork/node/server""
+ 	""github.com/mysteriumnetwork/node/service_discovery/dto""
+ 	""github.com/mysteriumnetwork/node/session""",I hate then some internal process specific middleware leaks into connection manager :( todo later.,nit: remove empty line
+2653,"@@ -102,7 +102,14 @@ def setupNupic():
+     name = ""nupic"",
+     version = version,
+     packages = findPackages(repositoryDir),
++    # A lot of this stuff may not be packaged properly, most if it was added in
++    # an effort to get a binary package prepared for nupic.regression testing
++    # on Travis-CI, but it wasn't done the right way. I'll be refactoring a lot
++    # of this for https://github.com/numenta/nupic/issues/408, so this will be
++    # changing soon. -- Matt
+     package_data = {
++      ""nupic.support.configuration_base"": [""nupic-default.xml""],
++      ""nupic.support.__init__"": [""nupic-logging.conf""],
+       ""nupic"": [""README.md"", ""LICENSE.txt"",
+                 ""CMakeLists.txt"", ""*.so"", ""*.dll"", ""*.dylib""],
+       ""nupic.bindings"": [""_*.so"", ""_*.dll""],",Reflects where these files were moved for `pkg_resources`.,Why do we need this?
+2654,"@@ -1,8 +1,12 @@
+ import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
+ import { translationMacro as t } from 'ember-i18n';
++import Ember from 'ember';
++const { computed } = Ember;
+ 
+ export default AbstractIndexRoute.extend({
+-  pageTitle: t('admin.textReplacements.pageTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('admin.textReplacements.pageTitle');
++  }),
+   hideNewButton: true,
+ 
+   model() {",This should be computed('i18n.locale'....,Why is this needed?
+2655,"@@ -1351,6 +1351,12 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
+ 									// Add a route to felix[1] to be able to reach the nodeport
+ 									_, err = eth20.RunCmd(""ip"", ""route"", ""add"", felixes[1].IP+""/32"", ""via"", ""10.0.0.20"")
+ 									Expect(err).NotTo(HaveOccurred())
++									// This multi-NIC scenario works only if the kernel's RPF check
++									// is not strict so we need to override it for the test and must
++									// be set properly when product is deployed. We reply on
++									// iptables to do require check for us.
++									felixes[1].Exec(""sysctl"", ""-w"", ""net.ipv4.conf.eth0.rp_filter=2"")
++									felixes[1].Exec(""sysctl"", ""-w"", ""net.ipv4.conf.eth20.rp_filter=2"")
+ 								})
+ 
+ 								By(""setting up routes to .20 net on dest node to trigger RPF check"", func() {",Can you explain to me what goes wrong here? Can the test be adjusted to set up working routing instead?,Why is this needed?
+2656,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ 
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+ 
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.,Why did you remove the static imports?
+2657,"@@ -36,14 +36,14 @@ type morqaTransport struct {
+ }
+ 
+ func (transport *morqaTransport) SendEvent(event Event) error {
+-	if metric := mapEventToMetric(event); metric != nil {
+-		return transport.morqaClient.SendMetric(metric)
++	if id, metric := mapEventToMetric(event); metric != nil {
++		return transport.morqaClient.SendMetric(id, metric)
+ 	}
+ 
+ 	return fmt.Errorf(""event not implemented"")
+ }
+ 
+-func mapEventToMetric(event Event) *metrics.Event {
++func mapEventToMetric(event Event) (string, *metrics.Event) {
+ 	switch event.EventName {
+ 	case startupEventName:
+ 		return nodeVersionToMetricsEvent(event.Application)",Not sure how useful is unlock event.,Why do we need the id here?
+2658,"@@ -31,8 +31,8 @@ import (
+ // This code is copied from memdocstore/codec.go, with some changes:
+ // - special treatment for primitive.Binary
+ 
+-func encodeDoc(doc driver.Document) (map[string]interface{}, error) {
+-	var e encoder
++func encodeDoc(doc driver.Document, lowercaseFields bool) (map[string]interface{}, error) {
++	e := encoder{lowercaseFields: lowercaseFields}
+ 	if err := doc.Encode(&e); err != nil {
+ 		return nil, err
+ 	}",Consider make the second argument a `encoderOptions` which includes the `lowercaseFields` just like opening a collection.,I don't think we need to pass `lowerca
+2659,"@@ -82,11 +82,13 @@ public class HiveIcebergOutputCommitter extends OutputCommitter {
+ 
+   /**
+    * Collects the generated data files and creates a commit file storing the data file list.
+-   * @param context The job context
++   * @param ctx The task attempt context
+    * @throws IOException Thrown if there is an error writing the commit file
+    */
+   @Override
+-  public void commitTask(TaskAttemptContext context) throws IOException {
++  public void commitTask(TaskAttemptContext ctx) throws IOException {
++    TaskAttemptContext context = TezUtil.enrichContextWithAttemptWrapper(ctx);
++
+     TaskAttemptID attemptID = context.getTaskAttemptID();
+     String fileForCommitLocation = generateFileForCommitLocation(context.getJobConf(),
+         attemptID.getJobID(), attemptID.getTaskID().getId());",What is the value of renaming this to `ctx`? We generally prefer the longer names because they are easier to read and to type.,Why do we need to enrich the context h
+2660,"@@ -352,8 +352,14 @@ bool TurnLaneHandler::isSimpleIntersection(const LaneDataVector &lane_data,
+             if (lane_data.back().tag == TurnLaneType::uturn)
+                 return findBestMatchForReverse(lane_data[lane_data.size() - 2].tag, intersection);
+ 
+-            BOOST_ASSERT(lane_data.front().tag == TurnLaneType::uturn);
+-            return findBestMatchForReverse(lane_data[1].tag, intersection);
++            // TODO(mokob): #2730 have a look please
++            // BOOST_ASSERT(lane_data.front().tag == TurnLaneType::uturn);
++            // return findBestMatchForReverse(lane_data[1].tag, intersection);
++            //
++            if (lane_data.front().tag == TurnLaneType::uturn)
++                return findBestMatchForReverse(lane_data[1].tag, intersection);
++
++            return findBestMatch(data.tag, intersection);
+         }();
+         std::size_t match_index = std::distance(intersection.begin(), best_match);
+         all_simple &= (matched_indices.count(match_index) == 0);","Hm. This could be a case of left-sided driving, having u-turn lanes on the right side. Good catch, but looks good to me.","I don't think this is the right place to do this. If you want to do this, you should be able to use `findBestMatchForReverse` directly."
+2661,"@@ -21,12 +21,12 @@ namespace Nethermind.Merge.Plugin.Data
+ {
+     public class Result
+     {
+-        public static readonly Result Success = new Result() {Value = true};
+-        public static readonly Result Fail = new Result() {Value = false};
++        public static readonly Result OK = new() {success = true};
++        public static readonly Result Fail = new() {success = false};
+ 
+-        public static implicit operator Result(bool value) => value ? Success : Fail;
++        public static implicit operator Result(bool value) => value ? OK : Fail;
+ 
+         [JsonPropertyName(""success"")]
+-        public bool Value { get; init; }
++        public bool success { get; init; }
+     }
+ }","There was a [JsonPropertyName(""success"")] here it did serialize fine for me, so I am not sure what was the matter? Also maybe uppercase?",Why did you change this?
+2662,"@@ -246,7 +246,8 @@ namespace Nethermind.Runner.Ethereum.Steps
+                 case SealEngineType.AuRa:
+                     AbiEncoder abiEncoder = new AbiEncoder();
+                     _context.ValidatorStore = new ValidatorStore(_context.DbProvider.BlockInfosDb);
+-                    IAuRaValidatorProcessor validatorProcessor = new AuRaAdditionalBlockProcessorFactory(_context.StateProvider, abiEncoder, _context.TransactionProcessor, _context.BlockTree, _context.ReceiptStorage, _context.ValidatorStore, _context.LogManager)
++                    ITransactionProcessorFactory readOnlyTransactionProcessorFactory = new ReadOnlyTransactionProcessorFactory(new ReadOnlyDbProvider(_context.DbProvider, false), _context.BlockTree, _context.SpecProvider, _context.LogManager);
++                    IAuRaValidatorProcessor validatorProcessor = new AuRaAdditionalBlockProcessorFactory(_context.StateProvider, abiEncoder, _context.TransactionProcessor, readOnlyTransactionProcessorFactory, _context.BlockTree, _context.ReceiptStorage, _context.ValidatorStore, _context.LogManager)
+                         .CreateValidatorProcessor(_context.ChainSpec.AuRa.Validators);
+                     
+                     AuRaStepCalculator auRaStepCalculator = new AuRaStepCalculator(_context.ChainSpec.AuRa.StepDuration, _context.Timestamper);    ","we can just use read env here, pretty sure",Why do we need this?
+2663,"@@ -91,6 +91,7 @@ class MergeCells extends BasePlugin {
+     this.autofillCalculations = new AutofillCalculations(this);
+     this.selectionCalculations = new SelectionCalculations();
+ 
++    this.hot.selection.transformation.addLocalHook('afterTransformStart', (...args) => this.onAfterLocalTransformStart(...args));
+     this.addHook('afterInit', (...args) => this.onAfterInit(...args));
+     this.addHook('beforeKeyDown', (...args) => this.onBeforeKeyDown(...args));
+     this.addHook('modifyTransformStart', (...args) => this.onModifyTransformStart(...args));",Could you replace local hook with global hook `afterModifyTransformStart`?,Why do we need this?
+2664,"@@ -854,3 +854,10 @@ class FileArchive(Archive):
+     def listing(self):
+         ""Return a list of filename entries currently in the archive""
+         return ['.'.join([f,ext]) if ext else f for (f,ext) in self._files.keys()]
++
++    def clear(self):
++        ""Clears the file archive""
++        self._files.clear()
++
++    
++","You seem to be basing your PRs off an commit, which keeps reintroducing these changes, which makes it harder to review your PRs.",I don't think this method is needed.
+2665,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?,I don't think this is the right erro
+2666,"@@ -38,7 +38,7 @@ namespace OpenTelemetry.Trace
+         /// <summary>
+         /// Gets or sets attributes known prior to span creation.
+         /// </summary>
+-        public IDictionary<string, object> Attributes { get; set; }
++        public IEnumerable<KeyValuePair<string, object>> Attributes { get; set; }
+ 
+         /// <summary>
+         /// Gets or sets Links factory. Use it to deserialize list of <see cref=""Link""/> lazily","As far as I can tell, `IDictionary<string, object>` implements `IEnumerable<KeyValuePair,string, object>>` so we are just making it more generic. From the issue, I understood that we want to maintain sequence/order. I believe `IEnumerable<>` won't fix the issue.",I don't think we need to change this
+2667,"@@ -124,7 +124,7 @@ public class DockerOptions {
+       for (int i = 0; i < maxContainerCount; i++) {
+         node.add(caps, new DockerSessionFactory(clientFactory, docker, image, caps));
+       }
+-      LOG.info(String.format(
++      LOG.finest(String.format(
+           ""Mapping %s to docker image %s %d times"",
+           caps,
+           name,",This change prevents a user understanding how their server is configured. Best to leave at `info` level.,Why did you change this to finest?
+2668,"@@ -32,6 +32,15 @@ import (
+ 	""google.golang.org/grpc/status""
+ )
+ 
++var (
++	ephemeralDenyList = []string{
++		api.SpecPriorityAlias,
++		api.SpecPriority,
++		api.SpecSticky,
++		api.SpecScale,
++	}
++)
++
+ func (s *OsdCsiServer) NodeGetInfo(
+ 	ctx context.Context,
+ 	req *csi.NodeGetInfoRequest,",I will add the following to the list: - api.SpecScale - api.SpecSticky,nit: `ephemeralDenyList` -> `denyList`
+2669,"@@ -58,7 +58,7 @@ bool EprosimaClient::init()
+ 
+ 	//CREATE RTPSParticipant
+ 	ParticipantAttributes PParam;
+-	PParam.rtps.defaultSendPort = 10042;
++	//PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
+ 	PParam.rtps.builtin.domainId = 80;
+ 	PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
+ 	PParam.rtps.builtin.use_SIMPLE_RTPSParticipantDiscoveryProtocol = true;","As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line",Is this TODO still relevant?
+2670,"@@ -158,7 +158,6 @@ namespace OpenTelemetry.Resources.Tests
+                 { ""dynamic"", new { } },
+                 { ""array"", new int[1] },
+                 { ""complex"", this },
+-                { ""float"", 0.1f },
+             };
+ 
+             var resource = new Resource(attributes);","since we are now no longer expecting an input of float to return an empty string, i have removed this test case.",Why did you remove this?
+2671,"@@ -36,6 +36,18 @@ func MakeCounter(metric MetricName) *Counter {
+ 	return c
+ }
+ 
++func NewCounter(name, desc string) *Counter {
++	c := &Counter{
++		name:          name,
++		description:   desc,
++		values:        make([]*counterValues, 0),
++		labels:        make(map[string]int),
++		valuesIndices: make(map[int]int),
++	}
++	c.Register(nil)
++	return c
++}
++
+ // Register registers the counter with the default/specific registry
+ func (counter *Counter) Register(reg *Registry) {
+ 	if reg == nil {",It would be cleaner if you were to pack the name&desc in a `MetricName` and pass it to `MakeCounter`,Why do we need this?
+2672,"@@ -24,5 +24,5 @@ using System.Runtime.CompilerServices;
+ #else
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.Jaeger.Tests"")]
+ [assembly: InternalsVisibleTo(""Benchmarks"")]
+-[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2] // Used by Moq.
++[assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")] // Used by Moq.
+ #endif",Do you know why do we need this?,Why is this needed?
+2673,"@@ -7,6 +7,7 @@ using System.Collections.Generic;
+ using System.Linq;
+ using MvvmCross.Platform.Ios.Presenters;
+ using MvvmCross.Platform.Ios.Presenters.Attributes;
++using MvvmCross.iOS.Views;
+ using MvvmCross.ViewModels;
+ using UIKit;
+ ",I guess this using is what causes the build to fail,Is this needed?
+2674,"@@ -239,6 +239,7 @@ DECLARE_THREAD_FN(ponyint_asio_backend_dispatch)
+   close(b->wakeup);
+   ponyint_messageq_destroy(&b->q);
+   POOL_FREE(asio_backend_t, b);
++  pony_unregister_thread();
+   return NULL;
+ }
+ ",I like the explicit unregister approach.,Why is this needed?
+2675,"@@ -25,8 +25,11 @@ namespace OpenTelemetry.Metrics
+         Type:
+             0x10: Sum
+             0x20: Gauge
+-            0x30: Histogram
+-            0x40: Summary (reserved)
++            0x40: Histogram
++            0x50: HistogramWithMinMax (reserved)
++            0x60: ExponentialHistogram (reserved)
++            0x70: ExponentialHistogramWithMinMax (reserved)
++            0x80: Summary (reserved)
+ 
+         Point kind:
+             0x04: I1 (signed 1-byte integer)","We should able to use 0x30 as summary, and make 0x80 reserved for future.",This should be `0x8
+2676,"@@ -104,7 +104,7 @@ namespace Datadog.Trace.ClrProfiler
+         {
+             tags = null;
+ 
+-            if (!tracer.Settings.IsIntegrationEnabled(integrationId) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
++            if (!tracer.Settings.IsIntegrationEnabled(integrationId) || PlatformHelpers.PlatformStrategy.ShouldSkipClientSpan(tracer.ActiveScope) || HttpBypassHelper.UriContainsAnyOf(requestUri, tracer.Settings.HttpClientExcludedUrlSubstrings))
+             {
+                 // integration disabled, don't create a scope, skip this trace
+                 return null;",This allows strategic exclusion of http spans.,Shouldn't this be `tracer.ActiveScope == null`?
+2677,"@@ -19,8 +19,10 @@ final class SearchDto
+     private $searchableProperties;
+     /** @var string[]|null */
+     private $appliedFilters;
++    /** @var string[]|null */
++    private $strictTextSearchFields;
+ 
+-    public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $defaultSort, array $customSort, ?array $appliedFilters)
++    public function __construct(Request $request, ?array $searchableProperties, ?string $query, array $defaultSort, array $customSort, ?array $appliedFilters, ?array $strictTextSearchFields)
+     {
+         $this->request = $request;
+         $this->searchableProperties = $searchableProperties;",why not just `string[]` instead of nullable,This is a BC break for anyone extending this cl
+2678,"@@ -150,7 +150,7 @@ func (e *Extractor) listPackages(query ...string) ([]*jsonPackage, error) {
+ 	// TODO(schroederc): support GOPACKAGESDRIVER
+ 	args := append([]string{""list"",
+ 		""-compiler="" + e.BuildContext.Compiler,
+-		""-tags="" + strings.Join(e.BuildContext.BuildTags, "",""),
++		""-tags="" + strings.Join(e.BuildContext.BuildTags, "" ""),
+ 		""-installsuffix="" + e.BuildContext.InstallSuffix,
+ 		""-test"",
+ 		""-deps"",",How does this work? Why isn't each tag after the first picked up as a new arg/flag?,Why is this change needed?
+2679,"@@ -37,5 +37,10 @@ namespace Datadog.Trace
+         /// The id of the container where the traced application is running.
+         /// </summary>
+         public const string ContainerId = ""Datadog-Container-ID"";
++
++        /// <summary>
++        /// The resource id of the site instance in azure app services where the traced application is running.
++        /// </summary>
++        public const string AzureAppServicesResourceId = ""Datadog-AzureAppServices-Resource-ID"";
+     }
+ }",This key is actually yet to be determined. Meeting with the backend team and Garner to discuss.,Should this be `Datadog-AzureAppServices-ID`?
+2680,"@@ -1298,12 +1298,8 @@ bool CoreChecks::ValidateImageUpdate(VkImageView image_view, VkImageLayout image
+                                      const char *func_name, std::string *error_code, std::string *error_msg) {
+     *error_code = ""VUID-VkWriteDescriptorSet-descriptorType-00326"";
+     auto iv_state = GetImageViewState(image_view);
+-    if (!iv_state) {
+-        std::stringstream error_str;
+-        error_str << ""Invalid VkImageView: "" << report_data->FormatHandle(image_view).c_str();
+-        *error_msg = error_str.str();
+-        return false;
+-    }
++    assert(iv_state);
++
+     // Note that when an imageview is created, we validated that memory is bound so no need to re-check here
+     // Validate that imageLayout is compatible with aspect_mask and image format
+     //  and validate that image usage bits are correct for given usage",Why remove the crash protection? We're just going to get a bug filed on it.,Why did you remove this check?
+2681,"@@ -24,6 +24,10 @@ export const HEADERS = {
+   TEXT_PLAIN: 'text/plain',
+   TEXT_HTML: 'text/html',
+   FORWARDED_PROTO: 'X-Forwarded-Proto',
++  XFRAMES_OPTIONS: 'X-Frame-Options',
++  CSP: 'Content-Security-Policy',
++  CTO: 'X-Content-Type-Options',
++  XSS: 'X-XSS-Protection',
+   ETAG: 'ETag',
+   JSON_CHARSET: 'application/json; charset=utf-8',
+   OCTET_STREAM: 'application/octet-stream; charset=utf-8',",Maybe be consistent and name it `FRAME_OPTIONS`.,I don't think we need to add t
+2682,"@@ -170,15 +170,6 @@ Blockly.Connection.prototype.connect_ = function(childConnection) {
+       if (!orphanBlock.outputConnection) {
+         throw 'Orphan block does not have an output connection.';
+       }
+-      // Attempt to reattach the orphan at the end of the newly inserted
+-      // block.  Since this block may be a row, walk down to the end
+-      // or to the first (and only) shadow block.
+-      var connection = Blockly.Connection.lastConnectionInRow_(
+-          childBlock, orphanBlock);
+-      if (connection) {
+-        orphanBlock.outputConnection.connect(connection);
+-        orphanBlock = null;
+-      }
+     } else if (parentConnection.type == Blockly.NEXT_STATEMENT) {
+       // Statement connections.
+       // Statement blocks may be inserted into the middle of a stack.","This check/exception is a guard for the next few lines of code. It shouldn't be necessary now. In fact, I don't think you need the if (parentConnection.type == Blockly.INPUT_VALUE) branch at all.",Why was this removed?
+2683,"@@ -72,8 +72,10 @@ class TestStringMethods(testtools.TestCase):
+ 
+     def test_parse_provisioning_output_failure_00(self):
+         res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_FAILED)
++
+         self.assertFalse(res)
+ 
+     def test_parse_provisioning_output_success_00(self):
+         res = self.molecule._parse_provisioning_output(TestStringMethods.OUTPUT_MIXED_SUCCESS)
++
+         self.assertTrue(res)",Could probably move these constants too?,Why did you remove these tests
+2684,"@@ -100,9 +100,8 @@ func (cmd *Command) Start() (err error) {
+ 			case <-time.After(1 * time.Minute):
+ 				err := cmd.mysteriumClient.PingProposal(proposal, signer)
+ 				if err != nil {
+-					//TODO failed to refresh proposal. Stop everything?
+ 					log.Error(""Failed to ping proposal"", err)
+-					cmd.Kill()
++					// do not stop server on missing ping to discovery. More on this in MYST-362 and MYST-370
+ 				}
+ 			case <-stopPinger:
+ 				log.Info(""Stopping proposal pinger"")",Maybe 'failed' instead of 'missing'. Also do we really need to write ticket numbers here?,Shouldn't this be `cmd.Stop()`?
+2685,"@@ -26,7 +26,6 @@ import org.apache.solr.common.params.SolrParams;
+ import org.apache.solr.request.SolrQueryRequest;
+ import org.apache.solr.response.transform.DocTransformer;
+ import org.apache.solr.response.transform.TransformerFactory;
+-import org.bouncycastle.util.Strings;
+ import org.junit.After;
+ import org.junit.BeforeClass;
+ import org.junit.Test;",Test used to use old bouncycastle dependency which isn't needed anymore from Hadoop. Switched to use builtin Java split.,Why was this removed?
+2686,"@@ -193,9 +193,11 @@ class SynthDriver(SynthDriver):
+ 		voices=OrderedDict()
+ 		for v in _espeak.getVoiceList():
+ 			l=v.languages[1:]
++			# #7167: Some languages names require unicode characters EG: Norwegian Bokmål
++			name=v.name.decode(""UTF-8"")
+ 			# #5783: For backwards compatibility, voice identifies should always be lowercase
+ 			identifier=os.path.basename(v.identifier).lower()
+-			voices[identifier]=VoiceInfo(identifier,v.name,l)
++			voices[identifier]=VoiceInfo(identifier,name,l)
+ 		return voices
+ 
+ 	def _get_voice(self):","nit: I think this would be more readable as ""Some language names contain Unicode characters"".",Why do we need to decode here?
+2687,"@@ -1,3 +1,9 @@
++#NVDAHelper.py
++#A part of NonVisual Desktop Access (NVDA)
++#Copyright (C) 2017-2018 NV Access Limited, Peter Vagner, Davy Kager
++#This file is covered by the GNU General Public License.
++#See the file COPYING for more details.
++
+ import os
+ import sys
+ import _winreg","Thanks for adding the header, but I don't think 2017 is a very accurate guess here. Could you do a quick search with git blame and change this accordingly?",This file should be removed.
+2688,"@@ -1,7 +1,6 @@
+-import { createElement, createContext } from '../../';
++import { createElement, createContext } from '../../src';
+ import { expect } from 'chai';
+ 
+-/** @jsx createElement */
+ /* eslint-env browser, mocha */
+ 
+ describe('createContext', () => {",Oh interesting - does web-test-runner not resolve package.json files?,Why was this removed?
+2689,"@@ -5,6 +5,7 @@
+       selected={startDate}
+       onChange={date => setStartDate(date)}
+       locale={fi}
++      ariaDayPrefix=""Päivä""
+     />
+   );
+ };","Is there a way to derive this value from the locale itself? I feel hardcoding the prefix in the props isn't the right approach, but I'm not sure what the locale file contains exactly.","ariaDayPrefix=""Päivä"""
+2690,"@@ -21,11 +21,18 @@ export function setComponentProps(component, props, opts, context, mountAll) {
+ 	if ((component.__key = props.key)) delete props.key;
+ 
+ 	if (!component.base || mountAll) {
+-		if (component.componentWillMount) component.componentWillMount();
++		if (component.componentWillMount) {
++			options.warn(""'componentWillMount' is deprecated"");
++			component.componentWillMount();
++		}
+ 	}
+ 	else if (component.componentWillReceiveProps) {
++		options.warn(""'componentWillReceiveProps' is deprecated"");
+ 		component.componentWillReceiveProps(props, context);
+ 	}
++	if (component.getDerivedStateFromProps) {
++		component.setState(component.getDerivedStateFromProps(props, component.state));
++	}
+ 
+ 	if (context && context!==component.context) {
+ 		if (!component.prevContext) component.prevContext = component.context;",I'd much rather see these warnings in our devtools (`debug/index.js`). Strings contribute quite a bit to our file size and moving them there would prevent bloating core.,Shouldn't this be `co
+2691,"@@ -96,6 +96,10 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
+ 	private String lastAlertMessage;
+ 	private JSONArray lastResults;
+ 
++	// Default queries
++	private String SOUPS_QUERY = String.format(""select %s from %s"", SmartStore.SOUP_NAME_COL, SmartStore.SOUP_ATTRS_TABLE);
++	private String INDICES_QUERY = String.format(""select %s, %s, %s from %s"", SmartStore.SOUP_NAME_COL, SmartStore.PATH_COL, SmartStore.COLUMN_TYPE_COL, SmartStore.SOUP_INDEX_MAP_TABLE);
++
+ 	/**
+ 	 * Create intent to bring up inspector
+ 	 * @param parentActivity","Use `String.format(Locale.US, ...) to avoid the `Lint` warning.",I think it would be b
+2692,"@@ -34,9 +34,17 @@ type AppliedToGroup struct {
+ 
+ // PodReference represents a Pod Reference.
+ type PodReference struct {
+-	// The name of this pod.
++	// The name of this Pod.
+ 	Name string
+-	// The namespace of this pod.
++	// The Namespace of this Pod.
++	Namespace string
++}
++
++// ServiceReference represents reference to a v1.Service.
++type ServiceReference struct {
++	// The name of this Service.
++	Name string
++	// The Namespace of this Service.
+ 	Namespace string
+ }
+ ",nit: ServiceReference represents a reference to a v1.Service.,Why do we need this?
+2693,"@@ -73,7 +73,7 @@ type GcpChaosSpec struct {
+ 	// The device name of the disk to detach.
+ 	// Needed in disk-loss.
+ 	// +optional
+-	DeviceName *string `json:""deviceName,omitempty""`
++	DeviceName *[]string `json:""deviceName,omitempty""`
+ }
+ 
+ // GcpChaosStatus represents the status of a GcpChaos","since it changes to the array, how about change the name to `DeviceNames`",Why is this a slice?
+2694,"@@ -41,6 +41,12 @@ const (
+ 	// top level property
+ 	ConfigTLP TopLevelProperty = ""Config""
+ 
++	// RuntimeTLP is a top level property supported by CAS template engine
++	//
++	// The policy specific properties are placed with RuntimeTLP as the
++	// top level property
++	RuntimeTLP TopLevelProperty = ""Runtime""
++
+ 	// VolumeTLP is a top level property supported by CAS template engine
+ 	//
+ 	// The properties provided by the caller are placed with VolumeTLP",Can we avoid this. upgrade engine code should take care of this.,nit: `RuntimeTLP` ->
+2695,"@@ -36,3 +36,4 @@ ACTIVATE_SALT = 'activate'
+ PASSWORD_RESET_SALT = 'reset'
+ MAX_LINK_AGE = 60 * 60 * 24 # 24 hours
+ CODE_EXP_MINUTES = 10
++TOKEN_EXP_DEFAULT = {'days': 90}",should also be alphabetized or at least grouped and alphabetized within group,E225 missing whitesp
+2696,"@@ -287,6 +287,7 @@ def _try_import_backends():
+         assert results.webengine_error is not None
+ 
+     return results
++    # pylint: enable=unused-variable
+ 
+ 
+ def _handle_ssl_support(fatal=False):","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",# pylint: disable=unused-variable
+2697,"@@ -29,6 +29,7 @@ const (
+ 
+ var (
+ 	errUnmarshalBuildOpts = errors.New(""can't unmarshal build field into string or compose-style map"")
++	errUnmarshalCountOpts = errors.New(""can't unmarshal count field into task count or auto scaling config"")
+ )
+ 
+ var dockerfileDefaultName = ""Dockerfile""","nit: can we remove ""can't"" from the error message?",nit: `can't unmarshal count field
+2698,"@@ -114,7 +114,14 @@ func NewCStorVolumeReplicaController(
+ 			q.Operation = common.QOpAdd
+ 			glog.Infof(""cStorVolumeReplica Added event : %v, %v"", cVR.ObjectMeta.Name, string(cVR.ObjectMeta.UID))
+ 			controller.recorder.Event(cVR, corev1.EventTypeNormal, string(common.SuccessSynced), string(common.MessageCreateSynced))
+-			cVR.Status.Phase = apis.CVRStatusPending
++
++			// For New request phase of cVR will be empty
++			if IsEmptyStatus(cVR) {
++				cVR.Status.Phase = apis.CVRStatusPending
++			} else {
++				cVR.Status.Phase = apis.CVRStatusRecreate
++			}
++
+ 			cVR, _ = controller.clientset.OpenebsV1alpha1().CStorVolumeReplicas(cVR.Namespace).Update(cVR)
+ 			controller.enqueueCStorReplica(cVR, q)
+ 		},","instead of modifying 'Status' which impacts the state diagram, how about using some annotations on CVR? This can probably help for our upgrade as well. Is this possible? cc: @AmitKumarDas",Why do we need to check if the cV
+2699,"@@ -38,9 +38,10 @@ const (
+ 	DefaultDownloadURL = ""https://download.docker.com""
+ 	DockerPreqReqList  = ""apt-transport-https ca-certificates curl gnupg-agent software-properties-common""
+ 
+-	KubernetesDownloadURL = ""https://apt.kubernetes.io/""
+-	KubernetesGPGURL      = ""https://packages.cloud.google.com/apt/doc/apt-key.gpg""
+-
++	KubernetesDownloadURL     = ""https://apt.kubernetes.io/""
++	KubernetesGPGURL          = ""https://packages.cloud.google.com/apt/doc/apt-key.gpg""
++	KubernetesBaseurl         = ""https://packages.cloud.google.com/yum/repos/kubernetes-el7-x86_64""
++	KubernetesGpgkey          = ""https://packages.cloud.google.com/yum/doc/yum-key.gpg https://packages.cloud.google.com/yum/doc/rpm-package-key.gpg""
+ 	KubeEdgeDownloadURL       = ""https://github.com/kubeedge/kubeedge/releases/download""
+ 	KubeEdgePath              = ""/etc/kubeedge/""
+ 	KubeEdgeConfPath          = KubeEdgePath + ""kubeedge/edge/conf""","Rename this as KubernetesGPGURL - >KubernetesUbuntuGPGURL , Modify it where ever it is used.",I think this should be `yum-key.g
+2700,"@@ -11,8 +11,12 @@ var Parser             = imports.Parser || require('./util/BinaryParser');
+ var Step               = imports.Step || require('step');
+ var buffertools        = imports.buffertools || require('buffertools');
+ var error              = imports.error || require('./util/error');
++var networks           = imports.networks || require('./networks');
++var WalletKey          = imports.WalletKey || require('./WalletKey');
++var PrivateKey         = imports.PrivateKey || require('./PrivateKey');
+ 
+ var COINBASE_OP = Buffer.concat([util.NULL_HASH, new Buffer('FFFFFFFF', 'hex')]);
++var DEFAULT_FEE = 0.0001;
+ 
+ function TransactionIn(data) {
+   if (""object"" !== typeof data) {","I'm not totally sure I like the idea of putting a default fee here, but I guess so long as we make sure to track the default fee of bitcoin core, we're good. We should really also take a look at the byte size of the transaction, and use that to determine what the fee should be. But that could also be a different PR.",Why do we need this?
+2701,"@@ -17,13 +17,13 @@
+  * </thead>
+  * <tbody>
+  * <tr><td>{@linkplain javaslang.collection.Array}</td><td><small>const</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td></tr>
+- * <tr><td>{@linkplain javaslang.collection.CharSeq}</td><td><small>const</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>linear</small></td></tr>
+- * <tr><td><em>{@linkplain javaslang.collection.Iterator}</em></td><td><small>const</small></td><td><small>const</small></td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td></tr>
++ * <tr><td>{@linkplain javaslang.collection.CharSeq}</td><td><small>const</small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
++ * <tr><td>{@linkplain javaslang.collection.Iterator}</td><td><small>const</small></td><td><small>const</small></td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td><td>&mdash;</td></tr>
+  * <tr><td>{@linkplain javaslang.collection.List}</td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>linear</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.Queue}</td><td><small>const</small></td><td><small>const<sup>a</sup></small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const</small></td><td><small>const</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.PriorityQueue}</td><td><small>log</small></td><td><small>log</small></td><td><small>&mdash;</small></td><td><small>&mdash;</small></td><td><small>log</small></td><td><small>log</small></td></tr>
+  * <tr><td>{@linkplain javaslang.collection.Stream}</td><td><small>const</small></td><td><small>const</small></td><td><small>linear</small></td><td><small>linear</small></td><td><small>const<sup>lazy</sup></small></td><td><small>const<sup>lazy</sup></small></td></tr>
+- * <tr><td>{@linkplain javaslang.collection.Vector}</td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
++ * <tr><td>{@linkplain javaslang.collection.Vector}</td><td><small>const</small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td><td><small>const<sup>eff</sup></small></td></tr>
+  * </tbody>
+  * </table>
+  * <br>","oh yeah, `tail`, `update`, `prepend`, `append`, `subSequence`, `trim` just became effectively constant (without memory leak) :)",Why did you remove t
+2702,"@@ -232,15 +232,12 @@ class ResourceTags extends Gateway
+      *
+      * @return void
+      */
+-    public function destroyLinks($resource, $user, $list = null, $tag = null)
++    public function destroyResourceLinks($resource, $user, $list = null, $tag = null)
+     {
+         $callback = function ($select) use ($resource, $user, $list, $tag) {
+             $select->where->equalTo('user_id', $user);
+             if (null !== $resource) {
+-                if (!is_array($resource)) {
+-                    $resource = [$resource];
+-                }
+-                $select->where->in('resource_id', $resource);
++                $select->where->in('resource_id', (array)$resource);
+             }
+             if (null !== $list) {
+                 if (true === $list) {","Can you add back a deprecated `destroyLinks` method for backward compatibility? It can simply proxy `destroyResourceLinks`, and we can remove it in the next major release.",Why did you remove t
+2703,"@@ -43,6 +43,7 @@ func init() {
+ 	RegisterGlobalOption(""local_certs"", parseOptTrue)
+ 	RegisterGlobalOption(""key_type"", parseOptSingleString)
+ 	RegisterGlobalOption(""auto_https"", parseOptAutoHTTPS)
++	RegisterGlobalOption(""servers"", parseServerOptions)
+ }
+ 
+ func parseOptTrue(d *caddyfile.Dispenser) (interface{}, error) {","A reminder that we should discuss whether to rename this to ""sockets"" or ""listeners"".",Why is this a global
+2704,"@@ -39,6 +39,7 @@ using eprosima::fastdds::dds::Log;
+ 
+ using eprosima::fastrtps::rtps::RTPSDomain;
+ using eprosima::fastrtps::rtps::RTPSParticipant;
++using eprosima::fastrtps::rtps::RTPSParticipantAttributes;
+ 
+ namespace eprosima {
+ namespace fastdds {",Why do you need to include this using declaration?,Why is this needed?
+2705,"@@ -59,7 +59,7 @@ namespace Microsoft.AspNet.Server.Kestrel.GeneratedCode
+             {
+                 ulong mask = 0;
+                 ulong comp = 0;
+-                for (var scan = 0; scan != count; ++scan)
++                for (var scan = 0; scan < count; scan++)
+                 {
+                     var ch = (byte)name[offset + count - scan - 1];
+                     var isAlpha = (ch >= 'A' && ch <= 'Z') || (ch >= 'a' && ch <= 'z');",@halter73 where is this file generated from?,Why this change?
+2706,"@@ -19,6 +19,7 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+     [SuppressMessage(""StyleCop.CSharp.LayoutRules"", ""SA1516:Elements must be separated by blank line"", Justification = ""This is an auto-generated file."")]
+     public class PackageVersions
+     {
++#if TRUE
+         public static IEnumerable<object[]> MongoDB =>
+ 
+             new List<object[]>",What do these `#if TRUE` accomplish?,Why is this needed?
+2707,"@@ -39,6 +39,11 @@ namespace OpenTelemetry.Instrumentation
+ 
+         public void OnNext(KeyValuePair<string, object> value)
+         {
++            if (Sdk.SuppressInstrumentation)
++            {
++                return;
++            }
++
+             if (!this.handler.SupportsNullActivity && Activity.Current == null)
+             {
+                 InstrumentationEventSource.Log.NullActivity(value.Key);","Probably a good optimization to have this, but I don't think it's strictly required. For ""legacy"" Activity flows we pass them through an ActivitySource for sampling. So the logic below should also catch these?",Why is this needed?
+2708,"@@ -1,6 +1,6 @@
+ <%= @activity %>
+ 
+-<%= t(""mailer.proposal_link_text"",
+-      proposal_url: proposal_url(@proposal)) %>
++<%= t(""mailer.view_request_cta"") %>
++<%= proposal_url(@proposal) %>
+ 
+ <%= t(""mailer.footer"", feedback_url: feedback_url) %>",@jessieay Intentionally moving away from passing a param?,I think this should be `view_request_cta`
+2709,"@@ -1378,13 +1378,12 @@ class PAIA extends DAIA
+             $lastname = $nameArr[0];
+         } else {
+             $nameArr = explode(' ', $username);
+-            $firstname = $nameArr[0];
+-            $lastname = '';
+-            array_shift($nameArr);
++            $firstname = '';
++            $lastname = array_pop($nameArr);
+             foreach ($nameArr as $value) {
+-                $lastname .= ' ' . $value;
++                $firstname .= ' ' . $value;
+             }
+-            $lastname = trim($lastname);
++            $firstname = trim($firstname);
+         }
+ 
+         // TODO: implement parsing of user details according to types set","I think you could condense this code considerably by getting rid of the initialization and foreach loop and simply saying: `$firstname = trim(implode(' ', $nameArr));` What do you think?",Why did you change this?
+2710,"@@ -1,5 +1,4 @@
+ #!/usr/bin/env node
+-'use strict'
+ 
+ const userAgent = process.env.npm_config_user_agent
+ if (!userAgent) {","hmm, we actually should _add_ `'use strict'` everywhere  ",Why was this removed?
+2711,"@@ -905,7 +905,7 @@ public class JdbcProjectImpl implements ProjectLoader {
+                   propsName);
+ 
+       if (properties == null || properties.isEmpty()) {
+-        logger.warn(""Project "" + projectId + "" version "" + projectVer + "" property "" + propsName
++        logger.debug(""Project "" + projectId + "" version "" + projectVer + "" property "" + propsName
+             + "" is empty."");
+         return null;
+       }","it's not just fetching override properties here, right?",Why did you change this?
+2712,"@@ -200,6 +200,7 @@ func (acsSession *session) Start() error {
+ 			if shouldReconnectWithoutBackoff(acsError) {
+ 				// If ACS closed the connection, there's no need to backoff,
+ 				// reconnect immediately
++				seelog.Info(""ACS Websocket connection closed for a valid reason"")
+ 				acsSession.backoff.Reset()
+ 				sendEmptyMessageOnChannel(connectToACS)
+ 			} else {",Is it worth logging the error?,Should this be a warning?
+2713,"@@ -16,6 +16,19 @@ import watchdog.events
+ from watchdog.observers import polling
+ 
+ 
++class NS:
++    def __init__(self, ns):
++        self.__dict__[""ns""] = ns
++
++    def __getattr__(self, key):
++        if key not in self.ns:
++            raise AttributeError(""No such element: %s"", key)
++        return self.ns[key]
++
++    def __setattr__(self, key, value):
++        self.__dict__[""ns""][key] = value
++
++
+ def parse_command(command):
+     """"""
+         Returns a (path, args) tuple.",What's the point of this class?,Why do we need this class
+2714,"@@ -411,7 +411,7 @@ import template from './libraryoptionseditor.template.html';
+             parent.querySelector('.chkEnableEmbeddedEpisodeInfosContainer').classList.add('hide');
+         }
+ 
+-        parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies');
++        parent.querySelector('.chkAutomaticallyAddToCollectionContainer').classList.toggle('hide', contentType !== 'movies' && contentType !== 'mixed');
+ 
+         return populateMetadataSettings(parent, contentType);
+     }","I'm being picky here, but I think I would prefer `toggle` to be kept here and just change the condition to `contentType !== 'movies' && contentType !== 'mixed'` or `!['movies', 'mixed'].includes(contentType)`.",Why is this change needed
+2715,"@@ -7,6 +7,9 @@ package libkbfs
+ import (
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/syndtr/goleveldb/leveldb""
++	""os""
++	sysPath ""path""
+ 	""sort""
+ 	""strings""
+ 	""sync""","Please put this down with the other ""github.com"" imports.",Why is this needed?
+2716,"@@ -67,7 +67,7 @@ void nano::block_processor::add (std::shared_ptr<nano::block> block_a, uint64_t
+ 	add (info);
+ }
+ 
+-void nano::block_processor::add (nano::unchecked_info const & info_a)
++void nano::block_processor::add (nano::unchecked_info const & info_a, bool push_front_preference)
+ {
+ 	if (!nano::work_validate (info_a.block->root (), info_a.block->block_work ()))
+ 	{",Minor but probably want `push_front_preference` to have a trailing `_a` to be consistent with the other parameter,`push_front_preference` is not used.
+2717,"@@ -53,8 +53,16 @@ public class InclusiveManifestEvaluator {
+   }
+ 
+   public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter) {
++    this(spec, rowFilter, true);
++  }
++
++  public InclusiveManifestEvaluator(PartitionSpec spec, Expression rowFilter, boolean caseSensitive) {
+     this.struct = spec.partitionType();
+-    this.expr = Binder.bind(struct, rewriteNot(Projections.inclusive(spec).project(rowFilter)), true);
++    this.expr = Binder.bind(
++            struct,
++            rewriteNot(Projections.inclusive(spec, caseSensitive).project(rowFilter)),
++            caseSensitive
++    );
+   }
+ 
+   /**","Nit: the formatting is a bit off. I would expect this to be 2 indentations from `this.expr = ...` but this is 8 spaces, not 4. Also, most places leave the `);` on the last line of the method arguments.",Why do we need the `caseSensitive` p
+2718,"@@ -14,8 +14,8 @@
+  */
+ package com.google.api.codegen.transformer.csharp;
+ 
+-import com.google.api.codegen.transformer.ApiMethodTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.StaticLangApiMethodTransformer;
+ import com.google.api.codegen.viewmodel.SimpleParamDocView;
+ import com.google.api.codegen.viewmodel.StaticLangApiMethodView;
+ import com.google.api.tools.framework.model.TypeRef;","Ack, @chrisdunelm snuck this class extension past me. This is not a pattern I want to have used...",Why is this change needed?
+2719,"@@ -67,7 +67,16 @@ def main(global_config, config=None, **settings):
+     # Scan Kinto views.
+     kwargs = {}
+     flush_enabled = asbool(settings.get('flush_endpoint_enabled'))
+-    if not flush_enabled:
++
++    if flush_enabled:
++        config.add_api_capability(
++            ""flush_endpoint"",
++            description=""The __flush__ endpoint can be used to remove all ""
++                        ""data from all backends."",
++            url=""http://kinto.readthedocs.org/en/latest/configuration/""
++                ""settings.html#activating-the-flush-endpoint""
++        )
++    else:
+         kwargs['ignore'] = 'kinto.views.flush'
+     config.scan(""kinto.views"", **kwargs)
+ ",nitpick: I wonder if we should name it `flush` only (?),I don't think this is the right plac
+2720,"@@ -0,0 +1,19 @@
++package hub
++
++import ""github.com/prometheus/client_golang/prometheus""
++
++var (
++	tasksGauge = prometheus.NewGauge(prometheus.GaugeOpts{
++		Name: ""sonm_tasks_current"",
++		Help: ""Number of currently running tasks"",
++	})
++	dealsGauge = prometheus.NewGauge(prometheus.GaugeOpts{
++		Name: ""sonm_deals_current"",
++		Help: ""Number of currently running tasks"",
++	})
++)
++
++func init() {
++	prometheus.MustRegister(tasksGauge)
++	prometheus.MustRegister(dealsGauge)
++}","Why gauges, not counters?",Why do we need this metric?
+2721,"@@ -45,7 +45,7 @@ const (
+ 	// hash of origin cluster name and <server> is 6 characters hash of origin server pub key.
+ 	gwReplyPrefix    = ""_GR_.""
+ 	gwReplyPrefixLen = len(gwReplyPrefix)
+-	gwHashLen        = 6
++	gwHashLen        = sysHashLen
+ 	gwClusterOffset  = gwReplyPrefixLen
+ 	gwServerOffset   = gwClusterOffset + gwHashLen + 1
+ 	gwSubjectOffset  = gwServerOffset + gwHashLen + 1","Just making a note here that this may break pre GWs between pre 2.2.0 and 2.2.0 servers. Not sure, will have to experiment/dig a bit more.",Why this change?
+2722,"@@ -93,6 +93,8 @@ public class WebUtils {
+         return ""Killing"";
+       case DISPATCHING:
+         return ""Dispatching"";
++      case POD_FAILED:
++        return ""Pod Failure"";
+       default:
+     }
+     return ""Unknown"";",Shall we rename this status to CONTAINER_FAILED? ^^ cc: @sshardool,case KILLED:
+2723,"@@ -30,6 +30,14 @@ const (
+ 	requestTimeout = 60 * time.Second
+ )
+ 
++// Fetcher defines an interface that may be used to fetch data from the network.
++type Fetcher interface {
++	// FetchTipSets will only fetch TipSets that evaluate to `false` when passed to `done`,
++	// this includes the provided `ts`. The TipSet that evaluates to true when
++	// passed to `done` will be in the returned slice. The returns slice of TipSets is in Traversal order.
++	FetchTipSets(context.Context, types.TipSetKey, peer.ID, func(types.TipSet) (bool, error)) ([]types.TipSet, error)
++}
++
+ // interface conformance check
+ var _ Fetcher = (*GraphSyncFetcher)(nil)
+ ",Thinking out loud here: I believe the only reason we need `peer.ID` as a parameter to this method is because we are not persisting blocks from pubsub (instead we are refetching them). If nodes persist the blocks they received over pubsub then I think we can guarantee peers we share a connection with (i.e. that are in the peer tracker) will always have the blocks we are fetching (else how would have we gotten the pubsub message). I imagine the concept of an `initialPeer` can go away once #2962 lands since the peers in the tracker will have the block. Although I don't think that covers the case of fetching blocks our peers have deemed semantically invalid and thus not stored...,nit: `FetchTipSets` -> `Fet
+2724,"@@ -42,7 +42,7 @@ func init() {
+ // MatchExpression matches requests by evaluating a
+ // [CEL](https://github.com/google/cel-spec) expression.
+ // This enables complex logic to be expressed using a comfortable,
+-// familiar syntax.
++// familiar syntax. The standard definitions of CEL functions and operators can be found [here](https://github.com/google/cel-spec/blob/master/doc/langdef.md#standard-definitions).
+ //
+ // This matcher's JSON interface is actually a string, not a struct.
+ // The generated docs are not correct because this type has custom",I know it has no effect but my eyes can't help. Is that line not too long?,nit: `[here]` -> `[here]`
+2725,"@@ -645,13 +645,6 @@ func (r *DefaultRuleRenderer) filterOutputChain(ipVersion uint8) *Chain {
+ 		},
+ 	)
+ 
+-	// Jump to chain for blocking service CIDR loops.
+-	rules = append(rules,
+-		Rule{
+-			Action: JumpAction{Target: ChainCIDRBlock},
+-		},
+-	)
+-
+ 	return &Chain{
+ 		Name:  ChainFilterOutput,
+ 		Rules: rules,",Does that mean we disable service loop prevention for packet generated by local host?,Why is this being removed
+2726,"@@ -107,6 +107,7 @@ module Beaker
+         when host['platform'] =~ /cumulus/
+           check_and_install_packages_if_needed(host, CUMULUS_PACKAGES)
+         when (host['platform'] =~ /windows/ and host.is_cygwin?)
++          raise RuntimeError, ""cygwin is not installed on #{host}"" if !host.cygwin_installed?
+           check_and_install_packages_if_needed(host, WINDOWS_PACKAGES)
+         when (host['platform'] =~ /windows/ and not host.is_cygwin?)
+           check_and_install_packages_if_needed(host, PSWINDOWS_PACKAGES)","It seems a little odd to have both `host.is_cygwin?` *and* `host.cygwin_installed?` defined (with a possibility of having `is_cygwin?` be `true`, but `cygwin_installed?` returning `false`). Do the docs clearly explain the difference?",I think this should be `r
+2727,"@@ -73,8 +73,8 @@ public class ManifestFiles {
+    * @return a manifest writer
+    */
+   public static ManifestWriter write(PartitionSpec spec, OutputFile outputFile) {
+-    // always use a v1 writer for appended manifests because sequence number must be inherited
+-    return write(1, spec, outputFile, null);
++    // always use a v2 writer to preserve sequence numbers, but use null for sequence number so appends inherit
++    return write(2, spec, outputFile, null);
+   }
+ 
+   /**",Does this mean manifests will be written with the v2 schema (i.e. with sequence numbers) even though `TableMetadata` is v1 and the manifest list is written with v1? And this should work because we do a projection on read and sequence number is optional?,Why do we need to change 
+2728,"@@ -47,4 +47,7 @@ public class SparkWriteOptions {
+ 
+   // Checks if input schema and table schema are same(default: true)
+   public static final String CHECK_ORDERING = ""check-ordering"";
++
++  // File scan task set ID that is being rewritten
++  public static final String REWRITTEN_FILE_SCAN_TASK_SET_ID = ""rewritten-file-scan-task-set-id"";
+ }",Should we be sharing this property key with the read? Maybe it should be belong to the file-scan-task object itself?,Why do we need this?
+2729,"@@ -82,6 +82,15 @@ type TestFields struct {
+ 	NoOutput bool `name:""no_test_output""`
+ }
+ 
++type DebugFields struct {
++	// Shell command to debug targets.
++	Command string `name:""debug_cmd""`
++	// Like tools but available to the debug_cmd instead
++	tools []BuildInput `name:""debug_tools""`
++	// Named debug tools, similar to named sources.
++	namedTools map[string][]BuildInput `name:""debug_tools""`
++}
++
+ // A BuildTarget is a representation of a build target and all information about it;
+ // its name, dependencies, build commands, etc.
+ type BuildTarget struct {",Nice! Good idea to move these out of the main struct.,Why is this a map?
+2730,"@@ -201,7 +201,10 @@ func CreateGitIgnore(targetDir string, ignores ...string) error {
+ 
+ 	if fileutil.FileExists(gitIgnoreFilePath) {
+ 		sigFound, err := fileutil.FgrepStringInFile(gitIgnoreFilePath, DdevFileSignature)
+-		util.CheckErr(err)
++		if err != nil {
++			return err
++		}
++
+ 		// If we sigFound the file and did not find the signature in .ddev/.gitignore, warn about it.
+ 		if !sigFound {
+ 			util.Warning(""User-managed %s will not be managed/overwritten by ddev"", gitIgnoreFilePath)","Thanks for paying attention to other places this might happen. This one is particularly important; I probably never should have gotten in the habit of CheckErr(), since it does a log.Panic() explicitly, which looks like something else until you look closely. It's supposed to be used places where ""can't happen"" but Things Can Happen.",Why is this change n
+2731,"@@ -16,10 +16,13 @@ import java.util.Map;
+  * @see com.fsck.k9.mail.store.StoreConfig#getTransportUri()
+  */
+ public class ServerSettings {
++
++    public enum Type { IMAP, SMTP, WebDAV, POP3 }
++
+     /**
+-     * Name of the store or transport type (e.g. ""IMAP"").
++     * Name of the store or transport type (e.g. IMAP).
+      */
+-    public final String type;
++    public final Type type;
+ 
+     /**
+      * The host name of the server.","Converting this to an enum makes it obvious that I combined things that don't really belong together. It would probably be better to create two enums `StoreType` and `TransportType` (in more appropriate locations). That also makes it necessary to have (at least) two `ServerSettings` classes. `IncomingServerSettings` and `OutgoingServerSettings`. Also, the naming is inconsistent. Maybe it would be better to make the string that is used for import/export explicit, e.g. WEBDAV(""WebDAV"").",I don't think we nee
+2732,"@@ -1,7 +1,14 @@
+-/*global axe */
+-
++/* global axe */
++/**
++ * Converts space delimited token list to an Array
++ * @method tokenList
++ * @memberof axe.commons.utils
++ * @instance
++ * @param  {String} str
++ * @return {Array}
++ */
+ axe.utils.tokenList = function (str) {
+ 	'use strict';
+ 
+ 	return str.trim().replace(/\s{2,}/g, ' ').split(' ');
+-};
++};","It's out of scope for this PR, but I don't find this utility's name to be particularly intuitive. It speaks to nothing of what it does. Does it create a token list? Process one? Get one? `tokenListToArray` would be nice.",I think this should be `@return {Array}`.
+2733,"@@ -3,7 +3,9 @@ let nodeName = node.nodeName.toUpperCase();
+ let type = (node.getAttribute('type') || '').toLowerCase();
+ let label = node.getAttribute('value');
+ 
+-this.data(label);
++if (label) {
++	this.data('has-label');
++}
+ 
+ if (nodeName === 'INPUT' && ['submit', 'reset'].includes(type)) {
+ 	return label === null;","The message for this check used the existence of a label to determine the output, which doesn't work with the current schema. So I updated it since the data only needed to know a label was present and not what it was.",Why is this needed?
+2734,"@@ -267,6 +267,14 @@ func (a *WebAPI) SyncApplication(ctx context.Context, req *webservice.SyncApplic
+ 		return nil, err
+ 	}
+ 
++	claims, err := rpcauth.ExtractClaims(ctx)
++	if err != nil {
++		return nil, err
++	}
++	if app.ProjectId != claims.Role.ProjectId {
++		return nil, status.Error(codes.PermissionDenied, ""application cannot be synced"")
++	}
++
+ 	cmd := model.Command{
+ 		Id:            uuid.New().String(),
+ 		PipedId:       app.PipedId,","nit: ""The current project does not have requested application""",Why do we need this check?
+2735,"@@ -14,6 +14,7 @@ use Ergonode\SharedKernel\Domain\AbstractCode;
+ class AttributeCode extends AbstractCode
+ {
+     public const PATTERN = '/^([a-zA-Z0-9_]+)$/';
++    public const FORBIDDEN = ['id'];
+ 
+     public function __construct(string $value)
+     {",Extend Unit test for this class,Why do we need this constant?
+2736,"@@ -62,6 +62,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string AppSecRules = ""DD_APPSEC_RULES"";
+ 
++        /// <summary>
++        /// Configuration key indicating the optional name of the custom header to take into account for the ip address.
++        /// Default is value is null (do not override).
++        /// </summary>
++        public const string AppSecCustomIpHeader = ""DD_APPSEC_IPHEADER"";
++
++        /// <summary>
++        /// Configuration key indicating the optional name of the custom header to take into account for the ip address.
++        /// Default is value is null (do not override).
++        /// </summary>
++        public const string AppSecExtraHeaders = ""DD_APPSEC_EXTRA_HEADERS"";
++
+         /// <summary>
+         /// Configuration key for enabling or disabling the Tracer's debug mode.
+         /// Default is value is false (disabled).",This is this a copy / paste error from above.,Should this be `DD_APPSEC_EXTRA_HEADERS`?
+2737,"@@ -0,0 +1,8 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.typeresolution.typeinterference;
++
++public class Variable {
++}",this package has to be renamed to `typeinference`,Why is this class needed?
+2738,"@@ -124,6 +124,9 @@ module.exports = {
+         let credentials = Realm.Credentials.anonymous();
+         let user = await app.logIn(credentials);
+         TestCase.assertInstanceOf(user, Realm.User);
++        TestCase.assertNotNull(user.deviceId);
++        TestCase.assertNotNull(user.providerType);
++        TestCase.assertEqual(user.providerType, ""anon-user"");
+         await user.logOut();
+     },
+ ",This cancels the above null-check I guess.,I think this should be `assertEqual(user.
+2739,"@@ -31,9 +31,9 @@ public final class Configuration {
+   //// 2.1 configuration items
+   public static final String PROP_ROOT = ""servicecomb.loadbalance."";
+ 
+-  public static final String RPOP_SERVER_EXPIRED_IN_SECONDS = ""servicecomb.loadbalance.stats.serverExpiredInSeconds"";
++  public static final String PROP_SERVER_EXPIRED_IN_SECONDS = ""servicecomb.loadbalance.stats.serverExpiredInSeconds"";
+ 
+-  public static final String RPOP_TIMER_INTERVAL_IN_MINIS = ""servicecomb.loadbalance.stats.timerIntervalInMilis"";
++  public static final String PROP_TIMER_INTERVAL_IN_MILLIS = ""servicecomb.loadbalance.stats.timerIntervalInMilis"";
+ 
+   public static final String PROP_RULE_STRATEGY_NAME = ""strategy.name"";
+ ",change to timerIntervalInMillis,I think this should be `PROP_TIMER_INTERV
+2740,"@@ -121,6 +121,8 @@ return [
+         'email' => 'Email',
+         'role_field' => 'Role',
+         'role_comment' => 'Roles define user permissions, which can be overriden on the user level, on the Permissions tab.',
++        'role_none' => 'None',
++        'role_none_comment' => 'This administrator does not belong to any rules.',
+         'groups' => 'Groups',
+         'groups_comment' => 'Specify which groups this account should belong to.',
+         'avatar' => 'Avatar',",`any rules` should be `any roles`,I think this should be `role_none_comment`
+2741,"@@ -105,13 +105,12 @@ public class AllEpisodesFragment extends EpisodesListFragment {
+     @NonNull
+     @Override
+     protected List<FeedItem> loadData() {
+-        return feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes(0, page * EPISODES_PER_PAGE));
++        return DBReader.getRecentlyPublishedEpisodesFiltered(0, page * EPISODES_PER_PAGE, feedItemFilter);
+     }
+ 
+     @NonNull
+     @Override
+     protected List<FeedItem> loadMoreData() {
+-        return feedItemFilter.filter(DBReader.getRecentlyPublishedEpisodes((page - 1) * EPISODES_PER_PAGE,
+-                EPISODES_PER_PAGE));
++        return DBReader.getRecentlyPublishedEpisodesFiltered((page - 1) * EPISODES_PER_PAGE, EPISODES_PER_PAGE, feedItemFilter);
+     }
+ }","Why does the method need to be renamed? I would just keep the old name and update the other uses (which are only tests). That way, we can reduce code duplication.",I think this should be `getRecentlyPublish
+2742,"@@ -29,9 +29,11 @@ from qutebrowser.utils import message
+ from qutebrowser.config import config
+ from qutebrowser.keyinput import keyparser
+ from qutebrowser.utils import usertypes, log, objreg, utils
++from qutebrowser.config.parsers import keyconf
+ 
+ 
+-STARTCHARS = "":/?""
++conf = keyconf.KeyConfigParser(None, None) 
++STARTCHARS = conf.get_bindings_for('normal').keys()
+ LastPress = usertypes.enum('LastPress', ['none', 'filtertext', 'keystring'])
+ 
+ ","I'm not sure if this is going to work - I think it's fine to keep them hardcoded here, as the statusbar can still show `:`, `/` and `?` even if the key is rebound.",Why is this needed?
+2743,"@@ -69,7 +69,6 @@ public abstract class TomcatServerBootstrap extends EmbeddedServerBootstrap {
+       .useLegacyLocalRepo(true).configureViaPlugin();
+ 
+     WebArchive wa = ShrinkWrap.create(WebArchive.class, ""rest-test.war"").setWebXML(webXmlPath)
+-        .addAsLibraries(resolver.resolve(""org.codehaus.jackson:jackson-jaxrs:1.6.5"").withTransitivity().asFile())
+         .addAsLibraries(resolver.addDependencies(
+             MavenDependencies.createDependency(""org.mockito:mockito-core"", ScopeType.TEST, false,
+             MavenDependencies.createExclusion(""org.hamcrest:hamcrest-core""))).resolve()",@tmetzke shouldn't we replace this library with the `2.12.1` instead of removing it?,Why was this removed?
+2744,"@@ -40,10 +40,16 @@ type Miner struct {
+ 	// PeerID is the peer ID to set as the miners owner
+ 	PeerID string
+ 
+-	// Power is the amount of power this miner should start off with
++	// NumCommittedSectors is the number of sectors that this miner has
++	// committed to the network.
++	//
++	// TODO: This struct needs a field which represents the size of sectors
++	// that this miner has committed. For now, sector size is configured by
++	// the StorageMarketActor's ProofsMode.
++	//
+ 	// TODO: this will get more complicated when we actually have to
+-	// prove real files
+-	Power uint64
++	// prove real files.
++	NumCommittedSectors uint64
+ }
+ 
+ // GenesisCfg is",uint64 seems excessive here. Should we reduce to a uint32 @whyrusleeping ?,I think this TODO can be removed now.
+2745,"@@ -109,7 +109,6 @@ type initStorageOpts struct {
+ 	ws    wsAddonManager
+ 	store store
+ 
+-	app *config.Application
+ 	sel wsSelector
+ }
+ ","Hmm, I thought this was getting used. These are used elsewhere as a cached value (in `svc deploy` it's `o.targetApp`) but I guess since storage doesn't actually need to validate that the app exists, just that there are local services, we never used it.",Why was this removed?
+2746,"@@ -337,6 +337,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		}
+ 	}
+ 
++	// Get the remote host
++	remoteHost, _, err := net.SplitHostPort(r.RemoteAddr)
++	if err != nil {
++		remoteHost = r.RemoteAddr
++	}
++
+ 	if vh, ok := s.vhosts[host]; ok {
+ 		status, _ := vh.stack.ServeHTTP(w, r)
+ ","To keep it simple, how would you feel about just using r.RemoteAddr? Since every request comes through here I want it to be as lean as possible. Frankly I'm OK with the port showing up in the log; maybe it'd even be useful to someone.",Should we log the error here?
+2747,"@@ -221,7 +221,13 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+ 
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= p.foundationBonusP2StartEpoch && epochNum <= p.foundationBonusP2EndEpoch) {
++	var grantFB bool
++	if a.hasFoundationBonusExtension() {
++		grantFB = a.grantFoundationBonus(epochNum)
++	} else {
++		grantFB = epochNum <= a.foundationBonusLastEpoch || (epochNum >= p.cfg.FoundationBonusP2StartEpoch && epochNum <= p.cfg.FoundationBonusP2EndEpoch)
++	}
++	if grantFB {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","grant bonus depends on both `admin{}` stored in statedb, and `P2Start/End` in local struct, which is kind of weird at Kamchatka height, we add the bonus Start/End epoch into `admin{}`, so it solely depends on `admin{}` stored in statedb",I don't think this is the right place
+2748,"@@ -222,8 +222,7 @@ class RandomFlip(object):
+             flipped[..., 1::4] = h - bboxes[..., 3::4]
+             flipped[..., 3::4] = h - bboxes[..., 1::4]
+         else:
+-            raise ValueError(
+-                'Invalid flipping direction ""{}""'.format(direction))
++            raise ValueError(f'Invalid flipping direction ""{direction}""')
+         return flipped
+ 
+     def __call__(self, results):",Use single quote to wrap the str.,This should be `f'Invalid flipping direction {direction!r}'`
+2749,"@@ -100,7 +100,7 @@ public enum JsonRpcError {
+       ""The permissioning whitelist configuration file is out of sync.  The changes have been applied, but not persisted to disk""),
+   WHITELIST_RELOAD_ERROR(
+       -32000,
+-      ""Error reloading permissions file. Please use perm_getAccountsWhitelist and perm_getNodesWhitelist to review the current state of the whitelists""),
++      ""Error reloading permissions file. Please use perm_getAccountsWhitelist and perm_getNodesAllowlist to review the current state of the whitelists""),
+   PERMISSIONING_NOT_ENABLED(-32000, ""Node/Account whitelisting has not been enabled""),
+   NON_PERMITTED_NODE_CANNOT_BE_ADDED_AS_A_PEER(-32000, ""Cannot add a non-permitted node as a peer""),
+ ",Is the plan to rename this later?,I think this should be `perm_getNodesWhitelist`
+2750,"@@ -340,7 +340,9 @@ class ChoiceAuth extends AbstractBase
+             return false;
+         }
+ 
+-        if (!in_array($this->strategy, $this->strategies)) {
++        if ('Email' !== $this->strategy
++            && !in_array($this->strategy, $this->strategies)
++        ) {
+             throw new InvalidArgumentException(""Illegal setting: {$this->strategy}"");
+         }
+         $authenticator = $this->getPluginManager()->get($this->strategy);",Is there a reason why we need a special case for Email at this point? Is the idea that other methods can turn into Email even if it's not configured as a top-level option?,This should be reverted.
+2751,"@@ -130,6 +130,9 @@ func makeJournalServer(
+ 	bcache BlockCache, dirtyBcache DirtyBlockCache, bserver BlockServer,
+ 	mdOps MDOps, onBranchChange branchChangeListener,
+ 	onMDFlush mdFlushListener, diskLimiter diskLimiter) *JournalServer {
++	if len(dir) == 0 {
++		panic(""dir unexpectedly empty"")
++	}
+ 	jServer := JournalServer{
+ 		config:                  config,
+ 		log:                     log,","This wording is a bit ambiguos, I first thought it meant the directory has no entries in it. maybe ""dir"" -> ""dir string""?",Why is this needed?
+2752,"@@ -53,6 +53,9 @@ namespace Kokkos {
+ namespace Experimental {
+ 
+ bool HPX::m_hpx_initialized = false;
++bool HPX::m_was_initialized = false;
++bool HPX::m_was_finalized   = false;
++
+ std::atomic<uint32_t> HPX::m_next_instance_id{1};
+ #if defined(KOKKOS_ENABLE_HPX_ASYNC_DISPATCH)
+ std::atomic<uint32_t> HPX::m_active_parallel_region_count{0};",Why do we need both `HPX::m_hpx_initialized` and `HPX:: m_was_initialized`?,Why do we need this?
+2753,"@@ -108,8 +108,8 @@ func NewMetadata(
+ 		}
+ 		versionToClusterName[info.InitialFailoverVersion] = clusterName
+ 
+-		if info.Enabled && (len(info.RPCName) == 0 || len(info.RPCAddress) == 0) {
+-			panic(fmt.Sprintf(""Cluster %v: rpc name / address is empty"", clusterName))
++		if info.Enabled && info.RPCAddress == """" {
++			panic(fmt.Sprintf(""Cluster %v: RPCAddress is empty"", clusterName))
+ 		}
+ 	}
+ ",also check RPCName?,Why do we need to pa
+2754,"@@ -76,9 +76,11 @@ import org.springframework.security.oauth2.client.userinfo.ReactiveOAuth2UserSer
+ import org.springframework.security.oauth2.client.web.server.AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository;
+ import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationCodeGrantWebFilter;
+ import org.springframework.security.oauth2.client.web.server.OAuth2AuthorizationRequestRedirectWebFilter;
++import org.springframework.security.oauth2.client.web.server.ServerAuthorizationRequestRepository;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationCodeAuthenticationTokenConverter;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizationRequestResolver;
+ import org.springframework.security.oauth2.client.web.server.ServerOAuth2AuthorizedClientRepository;
++import org.springframework.security.oauth2.client.web.server.WebSessionOAuth2ServerAuthorizationRequestRepository;
+ import org.springframework.security.oauth2.client.web.server.authentication.OAuth2LoginAuthenticationWebFilter;
+ import org.springframework.security.oauth2.core.endpoint.OAuth2AuthorizationRequest;
+ import org.springframework.security.oauth2.core.oidc.user.OidcUser;",Remove unused import,I think this import 
+2755,"@@ -182,7 +182,7 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) {
+ 	newInst := &Instance{serverType: newCaddyfile.ServerType(), wg: i.wg}
+ 
+ 	// attempt to start new instance
+-	err := startWithListenerFds(newCaddyfile, newInst, restartFds)
++	err := startWithListenerFds(newCaddyfile, newInst, restartFds, false)
+ 	if err != nil {
+ 		return i, err
+ 	}",I assume there will never be a scenario where justValidate is expected to be true on a restart,why do we need this 
+2756,"@@ -356,6 +356,9 @@ public class PMD {
+ 
+         sortFiles(configuration, files);
+ 
++        // Make sure the cache is listening for analysis results
++        ctx.getReport().addListener(configuration.getAnalysisCache());
++        
+         /*
+          * Check if multithreaded support is available. ExecutorService can also
+          * be disabled if threadCount is not positive, e.g. using the","Report listeners are synchronized, even 'though the cache is thread-safe... I've not profiled it, but it may be a cause of contingency. Any better way around this? Also, do listeners **really** need to be synchronized? Can't we just make them thread-safe?",Why do we need this?
+2757,"@@ -3,7 +3,7 @@ module Travis
+     class Script
+       class C < Script
+         DEFAULTS = {
+-          compiler: 'gcc'
++          compiler: ''
+         }
+ 
+         def export","I don't think this is correct. When `compiler` is not given in `.travis.yml`, the announcement will be `--version`, which results in ""`command not found`"" (though not critical), and the cache slug will lack this information (also not critical).",Why this change?
+2758,"@@ -33,6 +33,9 @@ const instanceMethods = {
+     },
+ 
+     async callFunction(name, args, service = undefined) {
++        if (!args) {
++            args = [];
++        }
+         const cleanedArgs = cleanArguments(args);
+         const stringifiedArgs = EJSON.stringify(cleanedArgs, { relaxed: false });
+         const result = await promisify(cb => this._callFunction(name, stringifiedArgs, service, cb));",Why do this rather than `args = []` in the function signature?,Why do we need this?
+2759,"@@ -22,6 +22,8 @@ module Bolt
+         %w[service-url cacert token-file task-environment local-validation]
+       end
+ 
++      PROVIDED_FEATURES = ['puppet-agent'].freeze
++
+       def self.validate(options)
+         validation_flag = options['local-validation']
+         unless !!validation_flag == validation_flag",I think we probably *should* do validation of whether there is a suitable implementation if local-validation is true. I'm not sure how useful that actually is though,I think this should 
+2760,"@@ -1640,6 +1640,11 @@ class Dataset(object):
+         if self.handle is None or other.handle is None:
+             raise ValueError('Both source and target Datasets must be constructed before adding features')
+         _safe_call(_LIB.LGBM_DatasetAddFeaturesFrom(self.handle, other.handle))
++        if other.data is None:
++            self.data = None
++        if self.data is not None:
++            # FIXME: concat two dataset
++            self.data = [self.data, other.data]
+         return self
+ 
+     def _dump_text(self, filename):",@StrikerRUS here may need to concat two data by col.,This should be `self.data.append(other.data)`
+2761,"@@ -64,7 +64,7 @@ public interface NodeWithJavadoc<N extends Node> {
+      */
+     @SuppressWarnings(""unchecked"")
+     default N setJavadocComment(String comment) {
+-        return setJavadocComment(new JavadocComment(comment));
++        return setJavadocComment(new JavadocComment("" "" + comment));
+     }
+ 
+     default N setJavadocComment(JavadocComment comment) {",Why the space?,Why do we need this change?
+2762,"@@ -38,10 +38,10 @@ public interface ZalcanoConfig extends Config
+ {
+ 
+ 	@ConfigTitleSection(
+-		keyName = ""zalcanoTitle"",
+-		name = ""Zalcano"",
+-		description = """",
+-		position = 0
++			keyName = ""zalcanoTitle"",
++			name = ""Zalcano"",
++			description = """",
++			position = 0
+ 	)
+ 	default Title zalcanoTitle()
+ 	{",please resolve the extra indentation,This should be reverted.
+2763,"@@ -69,8 +69,9 @@ namespace pwiz.Skyline.Model.Lib
+         protected override bool StateChanged(SrmDocument document, SrmDocument previous)
+         {
+             return previous == null ||
+-                !ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) ||
+-                !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults);
++                   !ReferenceEquals(document.Settings.PeptideSettings.Libraries, previous.Settings.PeptideSettings.Libraries) ||
++                   !ReferenceEquals(document.Settings.MeasuredResults, previous.Settings.MeasuredResults) ||
++                   !ReferenceEquals(document.Id, previous.Id);
+         }
+ 
+         protected override string IsNotLoadedExplained(SrmDocument document)",More proof that this check is needed always.,why do we need to check the Id here?
+2764,"@@ -86,9 +86,7 @@ lbann_comm::~lbann_comm() {
+     }
+   }
+ #ifdef LBANN_HAS_ALUMINUM
+-  for (auto&& c : al_comms) {
+-    delete c.second;
+-  }
++  m_al_comms.clear();
+   allreduces::Finalize();
+ #endif
+ }",`m_al_comms` now contains smart pointers.,Why is this needed?
+2765,"@@ -80,6 +80,10 @@ namespace AutoRest.CSharp
+                 {
+                     return ""new "" + type.Name + ""()"";
+                 }
++                if (type is EnumType && (type as EnumType).ModelAsString)
++                {
++                    return Instance.QuoteValue(defaultValue);
++                }
+                 if (primaryType != null)
+                 {
+                     if (primaryType.KnownPrimaryType == KnownPrimaryType.String)",Did you do a test run with the compare script? I'm nervous about what happens on all the generators...,Why do we need this
+2766,"@@ -390,6 +390,19 @@ func (c *client) initClient() {
+ 	}
+ }
+ 
++// RemoteAddress expose the Address of the client connection,
++// nil when not connected or unknown
++func (c *client) RemoteAddress() net.Addr {
++	c.mu.Lock()
++	defer c.mu.Unlock()
++
++	if c.nc == nil {
++		return nil
++	}
++
++	return c.nc.RemoteAddr()
++}
++
+ // Helper function to report errors.
+ func (c *client) reportErrRegisterAccount(acc *Account, err error) {
+ 	if err == ErrTooManyAccountConnections {","For a client, we store host, as string c.host. That is what we use for monitoring and statsz. Not sure if its useful here or not. Looks like probably not.",Why do we need this
+2767,"@@ -196,6 +196,6 @@ public class TestDataSourceOptions {
+         .option(""split-size"", String.valueOf(562L)) // 562 bytes is the size of SimpleRecord(1,""a"")
+         .load(tableLocation);
+ 
+-    Assert.assertEquals(""Spark partitions should match"", 2, resultDf.javaRDD().getNumPartitions());
++    Assert.assertEquals(""Spark partitions should match"", 4, resultDf.javaRDD().getNumPartitions());
+   }
+ }",This change is suspicious. Why did the number of partitions increase?,Why did this change
+2768,"@@ -20,8 +20,7 @@ class ProposalPolicy
+   end
+ 
+   def can_create!
+-    # TODO restrict by client_slug
+-    true
++    slug_matches? || @user.admin?
+   end
+   alias_method :can_new!, :can_create!
+ ","I'm still new to this area, so please forgive what may be a stupid question: When would this be false? And do we have a test for that situation?",I think this should be `@user.admin?`
+2769,"@@ -1710,10 +1710,11 @@ namespace pwiz.Skyline.EditUI
+         private void UpdateMoleculeType()
+         {
+             bool isPeptide = radioPeptide.Checked;
+-            btnCustomMoleculeColumns.Enabled = radioMolecule.Checked;
++            btnCustomMoleculeColumns.Enabled = true;
+             Settings.Default.TransitionListInsertPeptides = isPeptide; // Remember for next time
+ 
+-            //Skip updating if nothing needs to be changed
++            // Skip updating if nothing needs to be changed
++            // This should probably be taken out when we add smarter column selection as its currently hard coded for the number of columns
+             if ((isPeptide && gridViewTransitionList.ColumnCount == 5) || (!isPeptide && gridViewTransitionList.ColumnCount == 6))
+                 return;
+ ",Should there be any changes to this file at all?,I don't think we need this anymore
+2770,"@@ -87,6 +87,7 @@ func parseTLS(h Helper) ([]ConfigValue, error) {
+ 	var folderLoader caddytls.FolderLoader
+ 	var certSelector caddytls.CustomCertSelectionPolicy
+ 	var acmeIssuer *caddytls.ACMEIssuer
++	var autoPolicy *caddytls.AutomationPolicy
+ 	var internalIssuer *caddytls.InternalIssuer
+ 	var issuers []certmagic.Issuer
+ 	var onDemand bool","The only field being used is the KeyType; Instead, we can probably just make a `keyType` variable here.",I don't think we need this anymore.
+2771,"@@ -36,8 +36,11 @@ var SwaggerPetstore = ( /** @lends SwaggerPetstore */ function() {
+    * {@link https://github.com/request/request#requestoptions-callback Options doc}
+    */
+   function SwaggerPetstore(baseUri, options) {
+-    SwaggerPetstore['super_'].call(this, options);
+-    
++    if (!options) {
++      options = {};
++    }
++    SwaggerPetstore['super_'].call(this, options.credentials, options);
++
+     this.baseUri = baseUri;
+     if (this.baseUri === null || this.baseUri === undefined) {
+       this.baseUri = 'http://localhost:12510/api';",This should be done by code-gen change happening in the hydra repo. I am tweaking it just to get CI into a 'passing' state,Why do we need this?
+2772,"@@ -23,13 +23,15 @@ import { createTestRegistry } from './utils';
+  * Renders the given UI into a container to make assertions.
+  *
+  * @since 1.7.1
++ * @since 1.25.0 Added `features` option.
+  * @see {@link https://testing-library.com/docs/react-testing-library/api#render}
+  * @private
+  *
+- * @param {*}        ui                    Any valid React child element.
+- * @param {Object}   options               Render options.
+- * @param {Function} options.setupRegistry A function which accepts the registry instance to configure it.
+- * @param {Function} options.registry      A specific registry instance to use. Defaults to a fresh test registry with all stores.
++ * @param {*}        ui                      Any valid React child element.
++ * @param {Object}   [options]               Optional. Render options.
++ * @param {string[]} [options.features]      Feature flags to enable for this hook render.
++ * @param {Function} [options.setupRegistry] A function which accepts the registry instance to configure it.
++ * @param {Object}   [options.registry]      A specific registry instance to use. Defaults to a fresh test registry with all stores.
+  * @return {Object} An object containing all of {@link https://testing-library.com/docs/react-testing-library/api#render-result} as well as the `registry`.
+  */
+ const customRender = ( ui, options = {} ) => {",Cleaned up when I originally added support for passing `screenContext` here (and later `viewContext`) but that was removed.,Shouldn't this be 1.25.0?
+2773,"@@ -251,14 +251,14 @@ std::string CPlusPlusLanguage::MethodName::GetScopeQualifiedName() {
+ bool CPlusPlusLanguage::IsCPPMangledName(const char *name) {
+   // FIXME!! we should really run through all the known C++ Language plugins
+   // and ask each one if this is a C++ mangled name
+-  
++
+   if (name == nullptr)
+     return false;
+-  
+-  // MSVC style mangling 
++
++  // MSVC style mangling
+   if (name[0] == '?')
+     return true;
+-  
++
+   return (name[0] != '\0' && name[0] == '_' && name[1] == 'Z');
+ }
+ ",This looks like a bunch of whitespace fixing that's unrelated. Can you revert?,Why did you change this?
+2774,"@@ -25,7 +25,7 @@ class AppKernel extends Kernel
+             new Symfony\Bundle\SecurityBundle\SecurityBundle(),
+             new Symfony\Bundle\TwigBundle\TwigBundle(),
+             new Doctrine\Bundle\DoctrineBundle\DoctrineBundle(),
+-            new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
++            // new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
+             new Doctrine\Bundle\FixturesBundle\DoctrineFixturesBundle(),
+             new EasyCorp\Bundle\EasyAdminBundle\EasyAdminBundle(),
+             new EasyCorp\Bundle\EasyAdminBundle\Tests\Fixtures\AppTestBundle\AppTestBundle(),",should be removed instead,should be removed
+2775,"@@ -88,10 +88,14 @@ public class TestRegExp extends LuceneTestCase {
+     assertTrue(a.toString().length() > 0);
+   }
+   
++  
++  boolean caseSensitiveQuery = true;
++  
+   public void testCoreJavaParity() {
+     // Generate random doc values and random regular expressions
+     // and check for same matching behaviour as Java's Pattern class.
+     for (int i = 0; i < 1000; i++) {
++      caseSensitiveQuery = true;      
+       checkRandomExpression(randomDocValue(1 + random().nextInt(30)));
+     }        
+   }",should use randomization ?,Why do we need this?
+2776,"@@ -102,7 +102,7 @@ func (c *CmdVolumeOptions) RunVolumeInfo(cmd *cobra.Command) error {
+ 	// controller's IP, status, iqn, replica IPs etc.
+ 	volumeInfo, err := NewVolumeInfo(mapiserver.GetURL()+VolumeAPIPath+c.volName, c.volName, c.namespace)
+ 	if err != nil {
+-		return err
++		return nil
+ 	}
+ 
+ 	// Initiallize an instance of ReplicaCollection, json response recieved from the replica controller. Collection contains status and other information of replica.",returning nil because we want to mayactl to exit with 0 status code.,Why are we returning nil here?
+2777,"@@ -112,7 +112,7 @@ static void send_response(struct st_h2o_status_collector_t *collector)
+     resp[cur_resp++] = (h2o_iovec_t){H2O_STRLIT(""\n}\n"")};
+ 
+     req->res.status = 200;
+-    h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CONTENT_TYPE, H2O_STRLIT(""text/plain; charset=utf-8""));
++    h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CONTENT_TYPE, H2O_STRLIT(""application/json; charset=utf-8""));
+     h2o_add_header(&req->pool, &req->res.headers, H2O_TOKEN_CACHE_CONTROL, H2O_STRLIT(""no-cache, no-store""));
+     h2o_start_response(req, &generator);
+     h2o_send(req, resp, h2o_memis(req->input.method.base, req->input.method.len, H2O_STRLIT(""HEAD"")) ? 0 : nr_resp, 1);",Is this change relevant to the PR? (and I believe we should use `text/plain` considering the fact that it can be displayed using web browsers...),Why did you change this?
+2778,"@@ -9,12 +9,12 @@ namespace Microsoft.CodeAnalysis.Sarif
+     /// <summary>
+     /// The state of a result relative to a baseline of a previous run.
+     /// </summary>
+-    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.28.0.0"")]
+     [Flags]
++    [GeneratedCode(""Microsoft.Json.Schema.ToDotNet"", ""0.30.0.0"")]
+     public enum SuppressionStates
+     {
+         None,
+-        SuppressedInSource = 0x1,
+-        SuppressedInBaseline = 0x2
++        SuppressedInSource = 1,
++        SuppressedInBaseline = 2
+     }
+ }",`[Flags]` is now auto-generated by an argument to the `EnumHint`. (The attributes happen to come out in this order. I don't think it's worth controlling the order.) #Resolved,Why did you change this?
+2779,"@@ -376,6 +376,9 @@ configRetry:
+ 	} else {
+ 		// Use the syncer locally.
+ 		syncer = felixsyncer.New(backendClient, datastoreConfig.Spec, syncerToValidator)
++
++		log.Info(""using resource updates where applicable"")
++		configParams.SetUseResourceUpdates(true)
+ 	}
+ 	log.WithField(""syncer"", syncer).Info(""Created Syncer"")
+ ",I think same here - in general we don't need to use Setters / Getters since configParams isn't a public API.,I think this should be `config
+2780,"@@ -62,8 +62,13 @@ func main() {
+ 		ddata, err := ioutil.ReadFile(os.Args[3])
+ 		failFast(err)
+ 
++		programstr := fmt.Sprintf(""%s"", pdata)
++		
++		programbytes, err := logic.AssembleString(programstr)
++		failFast(err)
++
+ 		dsig := sec.Sign(logic.Msg{
+-			ProgramHash: crypto.HashObj(logic.Program(pdata)),
++			ProgramHash: crypto.HashObj(logic.Program(programbytes)),
+ 			Data:        ddata,
+ 		})
+ ",Why using `fmt.Sprintf` where `fmt.Sprint` would do the work (notice no `f` in function name)?,Please use `fmt.Sprintf` instead of `fmt.Sprintf`
+2781,"@@ -257,6 +257,12 @@ class VirtualBufferTextInfo(browseMode.BrowseModeDocumentTextInfo,textInfos.offs
+ 		return lineStart.value,lineEnd.value
+ 
+ 	def _normalizeControlField(self,attrs):
++
++		ariaCurrent = attrs.get(""IAccessible2::attribute_current"")
++		if ariaCurrent != None:
++			attrs['current']= ariaCurrent
++			del attrs[""IAccessible2::attribute_current""]
++			
+ 		tableLayout=attrs.get('table-layout')
+ 		if tableLayout:
+ 			attrs['table-layout']=tableLayout==""1""",Extraneous blank line.,E225 missing whitespace around operator
+2782,"@@ -43,5 +43,5 @@ var errWalletNotFound = fmt.Errorf(""wallet not found"")
+ var errSQLiteWrongType = fmt.Errorf(""sqlite wallet driver returned wrong wallet type"")
+ var errNameTooLong = fmt.Errorf(""wallet name too long, must be <= %d bytes"", sqliteMaxWalletNameLen)
+ var errIDTooLong = fmt.Errorf(""wallet id too long, must be <= %d bytes"", sqliteMaxWalletIDLen)
+-var errMsigWrongAddr = fmt.Errorf(""given multisig preimage hashes to wrong address"")
++var errMsigWrongAddr = fmt.Errorf(""given multisig preimage hashes to neither Sender or AuthAddr"")
+ var errMsigWrongKey = fmt.Errorf(""given key is not a possible signer for this multisig"")",nit: syntax : neither -> nor,I don't think we should change the error message 
+2783,"@@ -45,11 +45,11 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.Log4Net
+                 loggingEvent.Properties[CorrelationIdentifier.VersionKey] = tracer.Settings.ServiceVersion ?? string.Empty;
+                 loggingEvent.Properties[CorrelationIdentifier.EnvKey] = tracer.Settings.Environment ?? string.Empty;
+ 
+-                var span = tracer.ActiveScope?.Span;
+-                if (span is not null)
++                var spanContext = tracer.DistributedSpanContext;
++                if (spanContext is not null)
+                 {
+-                    loggingEvent.Properties[CorrelationIdentifier.TraceIdKey] = span.TraceId;
+-                    loggingEvent.Properties[CorrelationIdentifier.SpanIdKey] = span.SpanId;
++                    loggingEvent.Properties[CorrelationIdentifier.TraceIdKey] = spanContext[HttpHeaderNames.TraceId];
++                    loggingEvent.Properties[CorrelationIdentifier.SpanIdKey] = spanContext[HttpHeaderNames.ParentId];
+                 }
+             }
+ ",Is it safe to assume that these two keys are always present? `this[string]` will throw a `KeyNotFoundException` if they are not.,Why do we need this change?
+2784,"@@ -689,8 +689,9 @@ public class ExecutionController extends EventHandler implements ExecutorManager
+             this.maxConcurrentRunsPerFlowMap);
+         if (running.size() > maxConcurrentRuns) {
+           this.commonMetrics.markSubmitFlowSkip();
+-          throw new ExecutorManagerException(""Flow "" + flowId
+-              + "" has more than "" + maxConcurrentRuns + "" concurrent runs. Skipping"",
++          throw new ExecutorManagerException(""Flow with id "" +
++              (exflow.getFlowDefinitionId() > 0 ? exflow.getFlowDefinitionId() : flowId)
++              + "" has more than "" + maxConcurrentRuns + "" concurrent runs. Execution not created."",
+               ExecutorManagerException.Reason.SkippedExecution);
+         } else if (options.getConcurrentOption().equals(
+             ExecutionOptions.CONCURRENT_OPTION_PIPELINE)) {","Is the `flowDefinitionId` sufficient to uniquely identify the flow or does it need to be the tuple `<flowId,flowDefinitionId>` ?",I think it would be better to use `String.format` here.
+2785,"@@ -1774,6 +1774,7 @@ return [
+ 'DateTime::add' => ['static', 'interval'=>'DateInterval'],
+ 'DateTime::createFromFormat' => ['static|false', 'format'=>'string', 'time'=>'string', 'timezone='=>'?DateTimeZone'],
+ 'DateTime::createFromImmutable' => ['static', 'datetTimeImmutable'=>'DateTimeImmutable'],
++'DateTime::createFromInterface' => ['DateTimeInterface', 'self'],
+ 'DateTime::diff' => ['DateInterval|false', 'datetime2'=>'DateTimeInterface', 'absolute='=>'bool'],
+ 'DateTime::format' => ['string|false', 'format'=>'string'],
+ 'DateTime::getLastErrors' => ['array{warning_count:int,warnings:array<int,string>,error_count:int,errors:array<int,string>}'],",Shouldn't it be in the reverse order? `DateTime::createFromInterface()` returns `self` and accepts `DateTimeInterface`.,I don't think this is needed.
+2786,"@@ -114,12 +114,6 @@ function getArrayBuffer (chunk) {
+ 
+ function getFileType (file) {
+   const fileExtension = file.name ? getFileNameAndExtension(file.name).extension : null
+-
+-  if (file.isRemote) {
+-    // some remote providers do not support file types
+-    return file.type ? file.type : mimeTypes[fileExtension]
+-  }
+-
+   // check if mime type is set in the file object
+   if (file.type) {
+     return file.type",this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks.,Why is this removed?
+2787,"@@ -71,7 +71,7 @@ class Feature extends BaseI18nLoop implements PropelSearchLoopInterface
+             new Argument(
+                 'order',
+                 new TypeCollection(
+-                    new Type\EnumListType(array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'manual', 'manual_reverse'))
++                    new Type\EnumListType(array('id', 'id_reverse', 'alpha', 'alpha-reverse', 'alpha_reverse' , 'manual', 'manual_reverse'))
+                 ),
+                 'manual'
+             ),",Please could you remove the useless space.,Why did you change this?
+2788,"@@ -1082,12 +1082,14 @@ public final class OrdsSegmentTermsEnum extends BaseTermsEnum {
+       if (FST.targetHasArcs(arc)) {
+         // System.out.println(""  targetHasArcs"");
+         result.grow(1+upto);
+-        
++        if (arc.target < 0 || arc.target > Integer.MAX_VALUE) {
++          assert(arc.target >= 0);
++          assert(arc.target < Integer.MAX_VALUE);
++        }
+         fr.index.readFirstRealTargetArc(arc.target, arc, fstReader);
+ 
+         if (arc.bytesPerArc != 0) {
+           // System.out.println(""  array arcs"");
+-
+           int low = 0;
+           int high = arc.numArcs-1;
+           int mid = 0;",What's the point of this block (and isn't it effectively dead code)?,This should be `assert(arc.target >= 0 && arc.target <= Integer.MAX_VALUE)`
+2789,"@@ -5,7 +5,7 @@ class ForumSessionsController < ApplicationController
+   def new
+     sso = DiscourseSignOn.parse(
+       request.query_string,
+-      ENV[""DISCOURSE_SSO_SECRET""]
++      ENV.fetch(""DISCOURSE_SSO_SECRET""),
+     )
+     populate_sso_for_current_user(sso)
+     track_forum_access",Put a comma after the last parameter of a multiline method call.,"I'm not sure if this is the best way to do this, but I'm not sure if there'"
+2790,"@@ -0,0 +1,6 @@
++from dagster import job, SourceHashVersionStrategy
++
++
++@job(version_strategy=SourceHashVersionStrategy())
++def the_job():
++    ...",Newline at end of file plz,I don't think you need the `<msg>`<msg>`<msg>`<msg>`<msg>`<msg>`<msg>`<msg>
+2791,"@@ -18,7 +18,10 @@ package v1alpha3
+ 
+ import (
+ 	""fmt""
++	""github.com/aws/aws-sdk-go/aws""
++	""k8s.io/apimachinery/pkg/types""
+ 	""reflect""
++	clusterv1 ""sigs.k8s.io/cluster-api/api/v1alpha3""
+ )
+ 
+ // Tags defines a map of tags.","Can this be refactored to avoid including the aws sdk in the types that we expose? I know it's not being exposed directly through the types we expose, but I do worry that it might make it easier to accidentally do that in the future and not realize it as easily.",This should be `clusterv1alpha3`
+2792,"@@ -1028,4 +1028,18 @@ class Queue
+             ]
+         );
+     }
++
++    /**
++     * Sets the timestamp of when an item last has been indexed.
++     *
++     * @param Item $item
++     */
++    public function updateIndexQueueByItem(Item $item)
++    {
++        $GLOBALS['TYPO3_DB']->exec_UPDATEquery(
++            'tx_solr_indexqueue_item',
++            'uid = ' . (int)$item->getIndexQueueUid(),
++            ['indexed' => time()]
++        );
++    }
+ }","Hi thomas, i would propose to indicate in the name, that only the indextime is updated, otherwise somebody might think the whole items is getting updated. I would propose something like ""updateIndexTimeByItem(Item $item)""",I'm not sure if this is the best way to do this. I think it would be better to use the ORM instead.
+2793,"@@ -95,6 +95,8 @@ class visibility_of(object):
+ 
+ 
+ def _element_if_visible(element, visibility=True):
++    if isinstance(element, str) or isinstance(element, dict):
++           raise StaleElementReferenceException(""Invalid locator"")
+     return element if element.is_displayed() == visibility else False
+ 
+ ",This is not the right exception class. There is an InvalidSelectorException class that covers bad locators.,Why is this needed?
+2794,"@@ -45,6 +45,10 @@
+ #include <Kokkos_Macros.hpp>
+ #ifdef KOKKOS_ENABLE_CUDA
+ 
++#include <Kokkos_Core.hpp>
++#include <Kokkos_Cuda.hpp>
++#include <Kokkos_CudaSpace.hpp>
++
+ #include <cstdlib>
+ #include <iostream>
+ #include <sstream>",I assume this came from format?,Why is this needed?
+2795,"@@ -56,6 +56,13 @@ class ReIndexTask extends AbstractTask
+      */
+     protected $indexingConfigurationsToReIndex = array();
+ 
++    /**
++     * Clear Index for selected sites and record types
++     *
++     * @var boolean
++     */
++    protected $clearSearchIndex;
++
+ 
+     /**
+      * Purges/commits all Solr indexes, initializes the Index Queue",I'd suggest a default value of `false` just to make sure existing tasks are ok when they get deserialized after an update to a version containing this code.,Why do we need this property?
+2796,"@@ -237,6 +237,8 @@ func (km *KeyManagerStandard) getTLFCryptKeyParams(
+ 				kbfscrypto.CryptPublicKey{},
+ 				localMakeRekeyReadError(err)
+ 		}
++		km.log.CDebugf(ctx, ""Trying to decrypt with keys = %s"",
++			dumpConfig().Sdump(keys))
+ 		var index int
+ 		clientHalf, index, err = crypto.DecryptTLFCryptKeyClientHalfAny(ctx,
+ 			keys, flags&getTLFCryptKeyPromptPaper != 0)",Do we really need this? Seems like it would pollute the logs pretty badly.,"Should this be `km.log.CDebugf(ctx, ""Trying to decrypt with keys = %s"", keys)`?"
+2797,"@@ -9,6 +9,8 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure
+ {
+     public struct MemoryPoolIterator2
+     {
++        private readonly static int _vectorSpan = Vector<byte>.Count; 
++
+         private MemoryPoolBlock2 _block;
+         private int _index;
+ ",`Vector<byte>.Count` should Jit to const when intrinsic; not sure when `Vector.IsHardwareAccelerated == false` ; however we know `readonly static int` does Jit to const.,Why is this static?
+2798,"@@ -208,6 +208,9 @@ class PostgresqlStorageMigrationTest(unittest.TestCase):
+ class PostgresqlPermissionMigrationTest(unittest.TestCase):
+     def __init__(self, *args, **kw):
+         super(PostgresqlPermissionMigrationTest, self).__init__(*args, **kw)
++        from kinto.core.utils import sqlalchemy
++        if sqlalchemy is None:
++            return
+ 
+         from .test_permission import PostgreSQLPermissionTest
+         settings = PostgreSQLPermissionTest.settings.copy()",Can we use a skipIf decorator instead?,Why do we need this?
+2799,"@@ -3,6 +3,14 @@
+ module Faker
+   class Number < Base
+     class << self
++      ##
++      # Produce a random number.
++      #
++      # @param digits [Integer] Number of digits that the generated number should have.
++      # @return [Integer]
++      #
++      # @example
++      #   Faker::Number.number(digits: 10) #=> 1968353479
+       def number(legacy_digits = NOT_GIVEN, digits: 10)
+         warn_for_deprecated_arguments do |keywords|
+           keywords << :digits if legacy_digits != NOT_GIVEN",Missing version tags,I think this should be `@return [Integer]`
+2800,"@@ -60,6 +60,11 @@ module Bolt
+         print_table('tasks' => tasks, 'modulepath' => modulepath)
+       end
+ 
++      def print_plugin_list(plugins, modulepath)
++        plugins.delete(:validate_resolve_reference)
++        print_table('plugins' => plugins, 'modulepath' => modulepath)
++      end
++
+       def print_plan_info(plan)
+         path = plan.delete('module')
+         plan['module_dir'] = if path.start_with?(Bolt::Config::Modulepath::MODULES_PATH)",I think this should also filter out `validate_resolve_reference` hooks.,Why is this needed?
+2801,"@@ -18,8 +18,8 @@ using System;
+ using System.Diagnostics;
+ using System.Security;
+ using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation;
+-using OpenTelemetry.Trace;
+ using OpenTelemetry.Metrics;
++using OpenTelemetry.Trace;
+ 
+ namespace OpenTelemetry.Exporter
+ {","unrelated, but required fix as metrics branch got broken with the latest main->metrics merge and conflict resolution.",Why is this needed?
+2802,"@@ -1,9 +1,8 @@
+ # -*- coding: UTF-8 -*-
+-#globalCommands.py
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2006-2018 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Łukasz Golonka
++# Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Rui Batista, Joseph Lee, Leonard de Ruijter, Derek Riemer, Babbage B.V., Davy Kager, Ethan Holliger, Łukasz Golonka, Jakub Lukowicz
+ 
+ import time
+ import itertools",Feel free to remove this line,Why are you removin
+2803,"@@ -25,7 +25,7 @@ module Subscriptions
+   end
+ 
+   def click_upcase_call_to_action_in_header
+-    click_link ""Upcase Membership""
++    click_link I18n.t(""shared.subscriptions.single_user"")
+   end
+ 
+   def settings_page",~~Should this match the key updated above?~~ :+1:,This should be `I18
+2804,"@@ -180,7 +180,9 @@ func isDirExcludedByFile(dir, tagFilename, header string) bool {
+ 		Warnf(""could not open exclusion tagfile: %v"", err)
+ 		return false
+ 	}
+-	defer f.Close()
++	defer func() {
++		_ = f.Close()
++	}()
+ 	buf := make([]byte, len(header))
+ 	_, err = io.ReadFull(f, buf)
+ 	// EOF is handled with a dedicated message, otherwise the warning were too cryptic",`gofmt` allows a more compact form `defer func() { _ = f.Close() }()` or just add `// nolint:errcheck` before `defer`.,Why is this needed?
+2805,"@@ -10,11 +10,10 @@ import (
+ 
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/porcelain""
+-	""github.com/filecoin-project/go-filecoin/types""
+ )
+ 
+ // MinerCreate runs the `miner create` command against the filecoin process
+-func (f *Filecoin) MinerCreate(ctx context.Context, pledge uint64, collateral *types.AttoFIL, options ...ActionOption) (address.Address, error) {
++func (f *Filecoin) MinerCreate(ctx context.Context, pledge uint64, collateral *big.Int, options ...ActionOption) (address.Address, error) {
+ 	var out address.Address
+ 
+ 	sPledge := fmt.Sprintf(""%d"", pledge)",collateral is in FIL,`collateral` is unu
+2806,"@@ -84,6 +84,11 @@ func (q *ChannelEventQueue) dispatchMessage() {
+ 			log.LOGGER.Warnf(""node id is not found in the message"")
+ 			continue
+ 		}
++		_, ok := q.channelPool.Load(nodeID)
++		if !ok {
++			rChannel := make(chan model.Event, rChanBufSize)
++			q.channelPool.LoadOrStore(nodeID, rChannel)
++		}
+ 		rChannel, err := q.getRChannel(nodeID)
+ 		if err != nil {
+ 			log.LOGGER.Infof(""fail to get dispatch channel for %s"", nodeID)",We should not create channel of node which are not connected.,Why do we need to l
+2807,"@@ -40,6 +40,7 @@ class MongoCredentials {
+    * @param {string} [options.username] The username used for authentication
+    * @param {string} [options.password] The password used for authentication
+    * @param {string} [options.source] The database that the user should authenticate against
++   * @param {string} [options.db] see options.source
+    * @param {string} [options.mechanism] The method used to authenticate
+    * @param {object} [options.mechanismProperties] Special properties used by some types of auth mechanisms
+    */","I think the docstring should say something like ""Alias for the `source` option"" or something similar.",Shouldn't this be `
+2808,"@@ -129,6 +129,14 @@ public class Product implements Serializable {
+     private String nutritionDataPer;
+     @JsonProperty(""no_nutrition_data"")
+     private String noNutritionData;
++    @JsonProperty(""other_information_fr"")
++    private String otherInformation;
++    @JsonProperty(""conservation_conditions_fr"")
++    private String conservationConditions;
++    @JsonProperty(""recycling_instructions_to_discard_fr"")
++    private String recyclingInstructionsToDiscard;
++    @JsonProperty(""recycling_instructions_to_recycle_fr"")
++    private String recyclingInstructionsToRecycle;
+     @JsonProperty(""warning"")
+     private String warning;
+     @JsonProperty(""customer_service"")",Please use properties without suffix `_fr` so they can work across different languages as @teolemon mentioned,I don't think we need the `_fr` suffix.
+2809,"@@ -132,6 +132,7 @@ struct st_h2o_http3client_req_t {
+ static int handle_input_expect_data_frame(struct st_h2o_http3client_req_t *req, const uint8_t **src, const uint8_t *src_end,
+                                           int err, const char **err_desc);
+ static void start_request(struct st_h2o_http3client_req_t *req);
++static void destroy_request(struct st_h2o_http3client_req_t *req);
+ 
+ static struct st_h2o_http3client_conn_t *find_connection_for_origin(h2o_httpclient_ctx_t *ctx, const h2o_url_scheme_t *scheme,
+                                                                     h2o_iovec_t authority)",Declaration here is `static` but the definition at the bottom is non-static?,Why do we need this?
+2810,"@@ -65,6 +65,9 @@ type WriterOptions struct {
+ 	// write in a single request, if supported. Larger objects will be split into
+ 	// multiple requests.
+ 	BufferSize int
++	// Content-MD5 which may be used as a message integrity check (MIC)
++	// https://tools.ietf.org/html/rfc1864
++	ContentMD5 string
+ 	// Metadata holds key/value strings to be associated with the blob.
+ 	// Keys are guaranteed to be non-empty and lowercased.
+ 	Metadata map[string]string","Hi @myml, thanks for the contribution! `blob` and `blob/driver` are both in the same module, so you shouldn't need to split this change up into multiple Pull Requests. Also, I'd like to see it working, including the implementation for `s3blob` and `gcsblob` (these should be easy, just pass-through to the provider) and `fileblob` (might be trickier...), and a test in `drivertest/drivertest.go`.",I'm not sure if this is the best place 
+2811,"@@ -610,11 +610,11 @@ func (i *Initializer) configureGatewayInterface(gatewayIface *interfacestore.Int
+ 	gatewayIface.IPs = []net.IP{}
+ 	if i.networkConfig.TrafficEncapMode.IsNetworkPolicyOnly() {
+ 		// Assign IP to gw as required by SpoofGuard.
+-		if i.nodeConfig.NodeIPv4Addr != nil {
++		if i.nodeConfig.NodeTransportIPv4Addr != nil {
+ 			i.nodeConfig.GatewayConfig.IPv4 = i.nodeConfig.NodeTransportIPv4Addr.IP
+ 			gatewayIface.IPs = append(gatewayIface.IPs, i.nodeConfig.NodeTransportIPv4Addr.IP)
+ 		}
+-		if i.nodeConfig.NodeIPv6Addr != nil {
++		if i.nodeConfig.NodeTransportIPv6Addr != nil {
+ 			i.nodeConfig.GatewayConfig.IPv6 = i.nodeConfig.NodeTransportIPv6Addr.IP
+ 			gatewayIface.IPs = append(gatewayIface.IPs, i.nodeConfig.NodeTransportIPv6Addr.IP)
+ 		}",Was it a bug?,Why do we need to change this?
+2812,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done,I don't understand this change.
+2813,"@@ -66,6 +66,7 @@ def replace_variables(win_id, arglist):
+         'url:host': lambda: _current_url(tabbed_browser).host(),
+         'clipboard': utils.get_clipboard,
+         'primary': lambda: utils.get_clipboard(selection=True),
++        'link_hovered': lambda: tabbed_browser._now_focused._last_hovered_link,
+     }
+     for key in list(variables):
+         modified_key = '{' + key + '}'","You're accessing private variables here - `last_hovered_link` should be public in `TabData`. As for `tabbed_browser._now_focused`, I think you can use `tabbed_browser.widget.currentWidget()` instead.",I think this should be `_last_h
+2814,"@@ -0,0 +1,10 @@
++class InvitationMailer < BaseMailer
++  def invitation(invitation_id)
++    @invitation = Invitation.find(invitation_id)
++
++    mail(
++      to: @invitation.email,
++      subject: 'Invitation'
++    )
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Extra empty line detected at bo
+2815,"@@ -0,0 +1,15 @@
++namespace Fixtures.Azure.SwaggerBatSubscriptionIdApiVersion
++{
++    using System;
++    using System.Collections;
++    using System.Collections.Generic;
++    using System.Threading;
++    using System.Threading.Tasks;
++    using Microsoft.Rest;
++    using Microsoft.Azure;
++    using Models;
++
++    public static partial class MicrosoftAzureTestUrlExtensions
++    {
++    }
++}",We should file a bug for this - we don't need the extensions class if there are no operations on the client,nit: remove empty line
+2816,"@@ -415,6 +415,8 @@ func (p *csiPlugin) NewMounter(
+ 	}
+ 	klog.V(4).Info(log(""created path successfully [%s]"", dataDir))
+ 
++	mounter.MetricsProvider = NewMetricsCsi(volumeHandle, dir, csiDriverName(driverName))
++
+ 	// persist volume info data for teardown
+ 	node := string(p.host.GetNodeName())
+ 	volData := map[string]string{",Is it possible to import from k8s instead of copy in? :),Why do we need this?
+2817,"@@ -25,7 +25,7 @@ class ProjectCacheProvider extends \Psalm\Internal\Provider\ProjectCacheProvider
+      *
+      * @return void
+      */
+-    public function processSuccessfulRun($start_time)
++    public function processSuccessfulRun(float $start_time)
+     {
+         $this->last_run = (int) $start_time;
+     }",`@param float` can be dropped here.,Why did you change t
+2818,"@@ -35,7 +35,7 @@ import java.util.NoSuchElementException;
+ public abstract class CoprocessIterator<T> implements Iterator<T> {
+   protected final TiSession session;
+   protected final List<RegionTask> regionTasks;
+-  protected final DAGRequest dagRequest;
++  protected DAGRequest dagRequest;
+   protected final DataType[] handleTypes;
+   //  protected final ExecutorCompletionService<Iterator<SelectResponse>> completionService;
+   protected RowReader rowReader;",maybe we can leave this change un-reverted.,why remove final?
+2819,"@@ -5,7 +5,7 @@
+ 
+ package net.sourceforge.pmd.lang.java.ast;
+ 
+-public class ASTMethodDeclarator extends AbstractJavaNode {
++public class ASTMethodDeclarator extends AbstractJavaAccessNode {
+     public ASTMethodDeclarator(int id) {
+         super(id);
+     }","I wouldn't make MethodDeclarator an AccessNode, nor an Annotatable. It's the MethodDeclaration that can be annotated, and has info about the modifiers, and is already an AccessNode",Why is this change n
+2820,"@@ -0,0 +1,16 @@
++package net.runelite.api.events.player.headicon;
++
++import lombok.Getter;
++import net.runelite.api.Player;
++import net.runelite.api.events.Event;
++
++public abstract class PlayerHeadIconChanged implements Event
++{
++	@Getter
++	private final Player player;
++
++	public PlayerHeadIconChanged(Player player)
++	{
++		this.player = player;
++	}
++}",delete this class,Missing license header
+2821,"@@ -378,7 +378,7 @@ window.PopulatorView = countlyView.extend({
+             if ([""true"", ""false""].indexOf(s) !== -1) {
+                 return s === ""true"";
+             }
+-            else if (/^[1-9][0-9]+|0$/.test(s)) {
++            else if (/^[1-9][0-9]+|0|[1-9]$/.test(s)) {
+                 return parseInt(s);
+             }
+             else {",Replacing `+` (1 or more) with `*` (0 or more) would've also done the trick.,Why is this change nee
+2822,"@@ -58,7 +58,7 @@ TDTWriter::TDTWriter(std::ostream *outStream, bool takeOwnership) {
+   df_writeNames = true;
+ }
+ 
+-TDTWriter::~TDTWriter() throw() {
++TDTWriter::~TDTWriter() {
+   // close the writer if it's still open:
+   if (dp_ostream != nullptr) close();
+ }",I've been meaning to fix this for a while. Thanks.,Why did you remove the
+2823,"@@ -27,10 +27,12 @@ public class Program
+     {
+         using var otel = Sdk.CreateTracerProvider(b => b
+             .AddActivitySource(""MyCompany.MyProduct.MyLibrary"")
+-            .AddProcessorPipeline(pipeline =>
+-            {
+-                pipeline.AddProcessor(current => new MyActivityProcessor());
+-            }));
++
++            // TODO: seems buggy if you remove A and B here, MyActivityProcessor(C).OnEnd is not called.
++            // TODO: should the dispose order be C, B, A or A, B C?
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""A"")))
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""B"")))
++            .AddProcessorPipeline(p => p.AddProcessor(current => new MyActivityProcessor(""C""))));
+ 
+         using (var activity = MyActivitySource.StartActivity(""SayHello""))
+         {","This is adding multiple processor pipelines. I guess you wanted to add multiple processors to the same, single pipeline?",I don't think this is 
+2824,"@@ -11,13 +11,14 @@ from __future__ import absolute_import
+ from __future__ import print_function
+ from scapy.error import Scapy_Exception
+ import scapy.modules.six as six
++from scapy.compat import *
+ 
+ ###############################
+ ## Direct Access dictionary  ##
+ ###############################
+ 
+ def fixname(x):
+-    if x and x[0] in ""0123456789"":
++    if x and str(x[0]) in ""0123456789"":
+         x = ""n_""+x
+     return x.translate(""________________________________________________0123456789_______ABCDEFGHIJKLMNOPQRSTUVWXYZ______abcdefghijklmnopqrstuvwxyz_____________________________________________________________________________________________________________________________________"")
+ ","If you need str(x[0]) here, you'll probably need str(x) the line after that I suppose. Also, shouldn't we use `raw()` here instead of `str()`?",Why is this needed?
+2825,"@@ -96,8 +96,8 @@ public class TwoPhaseCommitter {
+    */
+   private static final int TXN_COMMIT_BATCH_SIZE = 768 * 1024;
+ 
+-  /** unit is second */
+-  private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3000;
++  /** unit is millisecond */
++  private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3600000;
+ 
+   private static final long MAX_RETRY_TIMES = 3;
+ ",3.6 seconds? what does it stand for?,Why did you change 
+2826,"@@ -834,6 +834,19 @@ module Beaker
+         sign_certificate_for(default)
+       end
+ 
++      # Get a facter fact from a provided host
++      #
++      # @param [Host] host  The host to query the fact for
++      # @param [String] name The name of the fact to query for
++      # @!macro common_opts
++      #
++      # @returns String The value of the fact 'name' on the provided host
++      # @raise  [FailTest] Raises an exception if call to facter fails
++      def fact host, name, opts= {}
++        result = on host, facter(name, opts)
++        result.stdout.chomp
++      end
++
+     end
+   end
+ end","If the command fails, is stdout nil or """"?",Why do we need to c
+2827,"@@ -84,10 +84,10 @@ public interface AutoRestValidationTest {
+      * used by Retrofit to perform actually REST calls.
+      */
+     interface AutoRestValidationTestService {
+-        @GET(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}"")
++        @GET(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}"")
+         Call<ResponseBody> validationOfMethodParameters(@Path(""subscriptionId"") String subscriptionId, @Path(""resourceGroupName"") String resourceGroupName, @Path(""id"") int id, @Query(""apiVersion"") String apiVersion);
+ 
+-        @PUT(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}?api-version={apiVersion}"")
++        @PUT(""/fakepath/{subscriptionId}/{resourceGroupName}/{id}"")
+         Call<ResponseBody> validationOfBody(@Path(""subscriptionId"") String subscriptionId, @Path(""resourceGroupName"") String resourceGroupName, @Path(""id"") int id, @Body Product body, @Query(""apiVersion"") String apiVersion);
+ 
+     }",Why is api-version now removed in the generated code?,Why did you remove 
+2828,"@@ -0,0 +1,3 @@
++from mmdet.utils import Registry
++
++OPTIMIZERS = Registry('optimizer')",We may register all built-in optimizers of PyTorch here to simplify the builder.,from mmdet.utils.registry import Registry
+2829,"@@ -109,7 +109,8 @@ std::string BaseGenerator::WrapInNameSpace(const Namespace *ns,
+                                            const std::string &name) const {
+   if (CurrentNameSpace() == ns) return name;
+   std::string qualified_name = qualifying_start_;
+-  for (auto it = ns->components.begin(); it != ns->components.end(); ++it)
++  auto &components = ns->components;
++  for (auto it = components.begin(); it != components.end(); ++it)
+     qualified_name += *it + qualifying_separator_;
+   return qualified_name + name;
+ }",No need for this new variable.,Why not `const auto &`?
+2830,"@@ -87,11 +87,11 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			c._vnode = newVNode;
+ 
+ 			// Invoke getDerivedStateFromProps
+-			let s = c._nextState || c.state;
++			if (c._nextState==null) {
++				c._nextState = c.state;
++			}
+ 			if (newType.getDerivedStateFromProps!=null) {
+-				oldState = assign({}, c.state);
+-				if (s===c.state) s = c._nextState = assign({}, s);
+-				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
++				c.setState(newType.getDerivedStateFromProps(newVNode.props, c._nextState));
+ 			}
+ 
+ 			// Invoke pre-render lifecycle methods",doesn't this enqueue a double render or is that safeguarded somehow,Why is this change needed?
+2831,"@@ -878,7 +878,9 @@ func (a *Account) randomClient() *client {
+ 	}
+ 	var c *client
+ 	for c = range a.clients {
+-		break
++		if c.acc == a {
++			break
++		}
+ 	}
+ 	return c
+ }",But now you may get DATA RACE reports because c.acc is sometimes changed. I wonder if we should not rework that whole sending subs through route.,I think this should be `if c.acc == a`
+2832,"@@ -194,7 +194,18 @@ std::shared_ptr<Engine> ADIOS::Open(const std::string &name,
+                                     ""HDF5 library, can't use HDF5\n"");
+ #endif
+     }
+-
++    else if (type == ""HDF5Reader"") // -Junmin
++    {
++//#if defined(ADIOS_HAVE_PHDF5) && defined(ADIOS_HAVE_MPI)
++#ifdef ADIOS_HAVE_PHDF5
++        //#ifdef ADIOS_HAVE_MPI
++        return std::make_shared<HDF5Reader>(*this, name, accessMode, mpiComm,
++                                            method);
++#else
++        throw std::invalid_argument(""ERROR: this version didn't compile with ""
++                                    ""HDF5 library, can't use HDF5\n"");
++#endif
++    }
+     else
+     {
+         if (m_DebugMode == true)","Use `ADIADIOS2_HAVE_HDF5`, not `ADIOS_HAVE_PHDF5`",Why is this needed?
+2833,"@@ -282,6 +282,7 @@ module RSpec
+           context ""with a non-string and a string"" do
+             it ""concats the args"" do
+               expect(group_value_for Object, 'group').to eq(""Object group"")
++              expect(group_value_for 'group', Object).to eq(""group Object"")
+             end
+           end
+ ","Would be nice to put this in a separate context named `""with a string and a non-string""` (since that's what it is -- it's definitely not a non-string and a string!).",Why is this change 
+2834,"@@ -1265,7 +1265,7 @@ void ResStatisticsStatement::setStatistics(SRVR_STMT_HDL *pSrvrStmt, SQLSTATS_TY
+ #define MAX_PERTABLE_STATS_DESC		30
+ 
+ #define MAX_MASTERSTATS_ENTRY		31
+-#define MAX_MEASSTATS_ENTRY			34
++#define MAX_MEASSTATS_ENTRY			26
+ #define MAX_PERTABLE_ENTRY			14
+ 
+ 	int i;",Should MAX_PERTABLE_ENTRY here be 10 ?,#define MAX_MASTERS
+2835,"@@ -29,6 +29,17 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+         private static readonly ArraySegment<byte> _emptyData = new ArraySegment<byte>(new byte[0]);
+         private static readonly byte[] _hex = Encoding.ASCII.GetBytes(""0123456789abcdef"");
+ 
++        private static readonly byte[] _bytesConnectionClose = Encoding.ASCII.GetBytes(""\r\nConnection: close"");
++        private static readonly byte[] _bytesConnectionKeepAlive = Encoding.ASCII.GetBytes(""\r\nConnection: keep-alive"");
++        private static readonly byte[] _bytesTransferEncodingChunked = Encoding.ASCII.GetBytes(""\r\nTransfer-Encoding: chunked"");
++        private static readonly byte[] _bytesHttpVersion1_0 = Encoding.ASCII.GetBytes(""HTTP/1.0 "");
++        private static readonly byte[] _bytesHttpVersion1_1 = Encoding.ASCII.GetBytes(""HTTP/1.1 "");
++        private static readonly byte[] _bytesContentLengthZero = Encoding.ASCII.GetBytes(""\r\nContent-Length: 0"");
++        private static readonly byte[] _bytesSpace = Encoding.ASCII.GetBytes("" "");
++        private static readonly byte[] _bytesServer = Encoding.ASCII.GetBytes(""\r\nServer: Kestrel"");
++        private static readonly byte[] _bytesDate = Encoding.ASCII.GetBytes(""Date: "");
++        private static readonly byte[] _bytesEndHeaders = Encoding.ASCII.GetBytes(""\r\n\r\n"");
++
+         private readonly object _onStartingSync = new Object();
+         private readonly object _onCompletedSync = new Object();
+         private readonly FrameRequestHeaders _requestHeaders = new FrameRequestHeaders();",Should move these out of frame into a static class? Similar to reason phrases?,nit: `_bytesEndHead
+2836,"@@ -608,7 +608,7 @@ std::vector<RouteStep> buildIntersections(std::vector<RouteStep> steps)
+     {
+         auto &step = steps[step_index];
+         const auto instruction = step.maneuver.instruction;
+-        if (instruction.type == TurnType::Suppressed)
++        if (instruction.type == TurnType::Suppressed || instruction.type == TurnType::UseLane)
+         {
+             BOOST_ASSERT(steps[last_valid_instruction].mode == step.mode);
+             // count intersections. We cannot use exit, since intersections can follow directly",That means we still create `UseLane` instructions but threat them like `Suppressed`? Can we maybe change this in the pre-processing so that we will just emit `Suppress` instructions in these cases?,Shouldn't this be `||`?
+2837,"@@ -21,14 +21,13 @@ import (
+ 
+ 	""github.com/iotexproject/go-pkgs/hash""
+ 	""github.com/iotexproject/iotex-address/address""
+-	""github.com/iotexproject/iotex-proto/golang/iotextypes""
+-
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/db/trie""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/state""
++	""github.com/iotexproject/iotex-proto/golang/iotextypes""
+ )
+ 
+ type (","no need to move here, iotex-proto is outside of iotex-core and considered same as iotex-address, go-pkgs",nit: remove empty line
+2838,"@@ -600,6 +600,14 @@ static void
+ app_exit_event(void)
+ {
+     check_stack_alignment();
++
++#if defined(LINUX) && defined(X86_64)
++    /* i#4335: Test allocation of more than 2.8GB in unreachable heap */
++    for (int i = 0; i != 50; ++i)
++    {
++        malloc(100000000);
++    }
++#endif
+ }
+ 
+ DR_EXPORT void",Looks like a clang-format style violation: should turn Travis red.,Shouldn't this be `mall
+2839,"@@ -127,6 +127,11 @@ MESSAGE
+ 
+       # Run all examples if none match the configured filters (default: `false`).
+       add_setting :run_all_when_everything_filtered
++      
++      # Allow user to configure their own success/pending/failure colors
++      add_setting :success_color
++      add_setting :pending_color
++      add_setting :failure_color
+ 
+       # Seed for random ordering (default: generated randomly each run).
+       #","I think we need some YARD docs here, particularly to list all the color symbols that are valid. Otherwise users will have to look at the source to discover that.",I don't think we need t
+2840,"@@ -31,6 +31,13 @@ import { STORE_NAME, AMP_MODE_PRIMARY, AMP_MODE_SECONDARY } from './constants';
+ 
+ const { createRegistrySelector } = Data;
+ 
++function getSiteInfoProperty( propName ) {
++	return createRegistrySelector( ( select ) => () => {
++		const siteInfo = select( STORE_NAME ).getSiteInfo() || {};
++		return siteInfo[ propName ];
++	} );
++}
++
+ // Actions
+ const RECEIVE_SITE_INFO = 'RECEIVE_SITE_INFO';
+ ","Not sure if this needs a doc block or not since it's completely internal, but   for cleaning this up. (@felixarntz docs?)","I'm not sure if this is the best way to do this, but I'm not sure if there's a better way to do this."
+2841,"@@ -616,7 +616,8 @@ libponyc.benchmarks.buildoptions += -DLLVM_BUILD_MODE=$(LLVM_BUILD_MODE)
+ 
+ libgbenchmark.buildoptions := \
+   -Wshadow -pedantic -pedantic-errors \
+-  -Wfloat-equal -fstrict-aliasing -Wstrict-aliasing -Wno-invalid-offsetof \
++  -fstrict-aliasing -Wstrict-aliasing \
++  -Wno-invalid-offsetof -Wno-deprecated-declarations \
+   -DHAVE_POSIX_REGEX -DHAVE_STD_REGEX -DHAVE_STEADY_CLOCK
+ 
+ ifneq ($(ALPINE),)",The change here is to address what exactly?,Why did this change?
+2842,"@@ -101,9 +101,14 @@ const (
+ // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob.
+ type Options struct {
+ 	// Credential represents the authorizer for SignedURL.
+-	// Required to use SignedURL.
++	// Required to use SignedURL. If you're using MSI for authentication, this will
++	// attempt to be loaded lazily the first time you call SignedURL.
+ 	Credential azblob.StorageAccountCredential
+ 
++	// IsMSIEnvironment represents if the blob storage is being authenticated via
++	// a Managed System Identity.
++	IsMSIEnvironment bool
++
+ 	// SASToken can be provided along with anonymous credentials to use
+ 	// delegated privileges.
+ 	// See https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1#shared-access-signature-parameters.","Is this really an Option? IIUC, you compute it automatically for the URLOpener case, why would we require a user to fill it in when using the constructor? I.e., can't we drop this and use `adal.MSIAvailable` instead? If that call is expensive, cache it on `bucket`, not `Options`.",I'm not sure if this is the right place to put this. It seems like it should be in the `AzureBlobStor
+2843,"@@ -23,7 +23,7 @@
+ 
+ ExplicitBitVect::ExplicitBitVect(unsigned int size, bool bitsSet) {
+   d_size = 0;
+-  dp_bits = 0;
++  dp_bits = nullptr;
+   d_numOnBits = 0;
+   _initForSize(size);
+   if (bitsSet) {",Was this done automatically or by hand?,Why this change?
+2844,"@@ -136,6 +136,18 @@ module Bolt
+       end
+       private :expand_targets
+ 
++      def remove_target(current_group, target, desired_group)
++        if current_group.name == desired_group
++          current_group.remove_target(target)
++        end
++        current_group.groups.each do |child_group|
++          # If target was in current group, remove it from all child groups
++          desired_group = child_group.name if current_group.name == desired_group
++          remove_target(child_group, target, desired_group)
++        end
++      end
++      private :remove_target
++
+       def add_target(current_group, target, desired_group)
+         if current_group.name == desired_group
+           current_group.add_target(target)","This looks like it will only work for the first child, since after that we've overridden `desired_group`. Should we have a separate variable for this?",Why do we need to do this?
+2845,"@@ -3194,7 +3194,7 @@ void CoreChecks::PostCallRecordCreateDevice(VkPhysicalDevice gpu, const VkDevice
+             std::copy(std::istreambuf_iterator<char>(read_file), {}, std::back_inserter(validation_cache_data));
+             read_file.close();
+         } else {
+-            LogInfo(core_checks->device, ""VUID-NONE"",
++            LogInfo(core_checks->device, ""UNASSIGNED-cache-file-error"",
+                     ""Cannot open shader validation cache at %s for reading (it may not exist yet)"",
+                     core_checks->validation_cache_path.c_str());
+         }",Should this be a constant somewhere?,This should be `UNASSIGNED
+2846,"@@ -17,5 +17,9 @@
+ using System.Runtime.CompilerServices;
+ 
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Tests"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.Http"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.AspNet"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.AspNetCore"" + AssemblyInfo.PublicKey)]
++[assembly: InternalsVisibleTo(""OpenTelemetry.Instrumentation.GrpcNetClient"" + AssemblyInfo.PublicKey)]
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"" + AssemblyInfo.MoqPublicKey)]
+ [assembly: InternalsVisibleTo(""Benchmarks"" + AssemblyInfo.PublicKey)]",nit: sort alphabetically.,I don't think we need thes
+2847,"@@ -28,6 +28,10 @@ import org.apache.solr.common.SolrException;
+  * @lucene.internal
+  */
+ class JsonQueryConverter {
++  public static final String paramsPrefix = ""_tt"";
++
++  public static final Object contextKey = JsonQueryConverter.class.getSimpleName();
++
+   private int numParams = 0;
+ 
+   String toLocalParams(Object jsonQueryObject, Map<String, String[]> additionalParams) {","Now, It's redundant, I suppose.",Why do we need this?
+2848,"@@ -70,6 +70,8 @@ type ChooserList interface {
+ //
+ // peerlist.List and ListImplementation compose well with sharding schemes the
+ // degenerate to returning the only available peer.
++//
++// Deprecated in favor of ""go.uber.org/yarpc/peer/peerlist/v2"".Implementation.
+ type ListImplementation interface {
+ 	transport.Lifecycle
+ ","nit: The format recognized by tooling is `// Deprecated: [..]` so you likely want this to be, // Deprecated: Use ""go.uber.org/yarpc/peer/peerlist/v2"".Implementation instead.",I don't think we need to deprecate this.
+2849,"@@ -41,9 +41,9 @@ func lookupTelemetryEndpoint(cfg config.Local, genesisNetwork protocol.NetworkID
+ 	for _, bootstrapID := range bootstrapArray {
+ 		addrs, err := ReadFromSRV(""telemetry"", bootstrapID, cfg.FallbackDNSResolverAddress)
+ 		if err != nil {
+-			log.Warnf(""An issue occurred reading telemetry entry for: %s"", bootstrapID)
++			log.Infof(""An issue occurred reading telemetry entry for: %s"", bootstrapID)
+ 		} else if len(addrs) == 0 {
+-			log.Warnf(""No telemetry entry for: %s"", bootstrapID)
++			log.Infof(""No telemetry entry for: %s"", bootstrapID)
+ 		} else {
+ 			return addrs[0]
+ 		}","nit: 1. when formatting input strings, make sure to place them in quotes so we could identify white space issues. i.e. '%s' 2. If there is untyped, non-nil error, you want to log the error string as well.",Should this be a warning?
+2850,"@@ -4,7 +4,16 @@ namespace Datadog.Trace.ClrProfiler
+ {
+     internal static class NativeMethods
+     {
+-        [DllImport(""Datadog.Trace.ClrProfiler.Native.dll"")]
+-        public static extern bool IsProfilerAttached();
++        public static class Windows
++        {
++            [DllImport(""Datadog.Trace.ClrProfiler.Native.dll"")]
++            public static extern bool IsProfilerAttached();
++        }
++
++        public static class Linux
++        {
++            [DllImport(""Datadog.Trace.ClrProfiler.Native.so"")]
++            public static extern bool IsProfilerAttached();
++        }
+     }
+ }","I believe this can be fixed with the original code if you just omit the "".dll"" file extension so it reads `[DllImport(""Datadog.Trace.ClrProfiler.Native"")]`. On Windows it would look for `Datadog.Trace.ClrProfiler.Native.dll` and Linux/Mac it would look for `Datadog.Trace.ClrProfiler.Native.so`.",Why do we need this?
+2851,"@@ -71,6 +71,11 @@ class UpdateManager {
+                 UserPreferences.setEpisodeCleanupValue(oldValueInDays * 24);
+             } // else 0 or special negative values, no change needed
+         }
++        if (oldVersionCode < 1070197) {
++            if (prefs.getBoolean(UserPreferences.PREF_MOBILE_UPDATE_OLD, false)) {
++                prefs.edit().putString(UserPreferences.PREF_MOBILE_UPDATE, ""everything"").apply();
++            }
++        }
+     }
+ 
+ }","couldn't we just read the boolean as a string (I would assume that this return ""true"" or ""false""), migrate if to its new value and keep using the same pref key?",This should be `prefs.edit().putString(U
+2852,"@@ -126,6 +126,7 @@ static int skip_file_check = 0;
+ 
+ static int cache_mode = 1;
+ 
++static int json_input = 0;
+ static int jx_input = 0;
+ static char *jx_context = NULL;
+ ","If these variables are only used in main function, move these to the beginning of that function. If there is a foreseeable reason to have them as global statics just let me know.",static int json_context = 0;
+2853,"@@ -40,12 +40,12 @@ namespace Microsoft.Sarif.Viewer
+         {
+             if (serviceProvider == null)
+             {
+-                throw new ArgumentNullException(""serviceProvider"");
++                throw new ArgumentNullException(nameof(serviceProvider));
+             }
+ 
+             if (region == null)
+             {
+-                throw new ArgumentNullException(""location"");
++                throw new ArgumentNullException(nameof(region));
+             }
+ 
+             m_serviceProvider = serviceProvider;",This one was wrong.,Why did you change the excep
+2854,"@@ -1697,9 +1697,14 @@ type Observer interface {
+ 	// updated locally, but not yet saved at the server.
+ 	LocalChange(ctx context.Context, node Node, write WriteRange)
+ 	// BatchChanges announces that the nodes have all been updated
+-	// together atomically.  Each NodeChange in changes affects the
+-	// same top-level folder and branch.
+-	BatchChanges(ctx context.Context, changes []NodeChange)
++	// together atomically.  Each NodeChange in `changes` affects the
++	// same top-level folder and branch. `allAffectedNodeIDs` is a
++	// list of all the nodes that had their underlying data changed,
++	// even if it wasn't an user-visible change (e.g., if a
++	// subdirectory was updated, the directory block for the TLF root
++	// is updated but that wouldn't be visible to a user).
++	BatchChanges(ctx context.Context, changes []NodeChange,
++		allAffectedNodeIDs []NodeID)
+ 	// TlfHandleChange announces that the handle of the corresponding
+ 	// folder branch has changed, likely due to previously-unresolved
+ 	// assertions becoming resolved.  This indicates that the listener",What happens if nodes throughout a hierarchy are modified (as they would be)? It looks like we're going to `Reset` once for each `NodeID` affected.,nit: `allAffectedNodeIDs` ->
+2855,"@@ -1065,7 +1065,6 @@ error:
+  * process, mode_switch_buf_sz is maximum size for switch code, and
+  * mode_switch_data is the address where the app stack pointer is stored.
+  */
+-
+ static size_t
+ generate_switch_mode_jmp_to_hook(HANDLE phandle, byte *local_code_buf,
+                                  byte *mode_switch_buf, byte *hook_location,","> Note that allocation of vmheap fails upon initializing dynamoRIO 64 on WoW64 processes. Thus, we need to pass -reachable_heap to avoid having to make this allocation. This should be solved by changing the default `vmheap_size` to be much smaller than 8GB for x64 DR inside WOW64.",Why is this removed?
+2856,"@@ -200,6 +200,12 @@ module RSpec::Core
+         @exception_presenter.fully_formatted(failure_number, colorizer)
+       end
+ 
++      # @return [Array] The failure information fully formatted in the way that
++      #   RSpec's built-in formatters emit, split by line.
++      def fully_formatted_lines(failure_number, colorizer=::RSpec::Core::Formatters::ConsoleCodes)
++        @exception_presenter.fully_formatted_lines(failure_number, colorizer)
++      end
++
+     private
+ 
+       def initialize(example, exception_presenter=Formatters::ExceptionPresenter::Factory.new(example).build)","Is it really worth expanding our public API for this? After all, isn't calling this the same as calling `notification.fully_formatted(...).lines`? If so, I'd rather not widen our API (and thus, increase our maintenance burden) when it's so simple to get all the lines already.",I think this should be `@return [Array<String>]`.
+2857,"@@ -14,18 +14,10 @@
+  */
+ package com.google.api.codegen;
+ 
+-/**
+- * A SnippetSetRunner takes the element, snippet file, and context as input and then uses the
+- * Snippet Set templating engine to generate an output document.
+- */
++/** Defines the SNIPPET_RESOURCE_ROOT. */
+ public final class SnippetSetRunner {
+ 
+   /** The path to the root of snippet resources. */
+   public static final String SNIPPET_RESOURCE_ROOT =
+       SnippetSetRunner.class.getPackage().getName().replace('.', '/');
+-
+-  public interface Generator<Element> {
+-    /** Runs the code generation. */
+-    GeneratedResult generate(Element element, String snippetFileName, CodegenContext context);
+-  }
+ }",Is it necessary to keep this class around just to define this constant? Or can we place it somewhere else?,Why is this being removed?
+2858,"@@ -60,6 +60,10 @@ type rule struct {
+ 	// The parent Policy ID. Used to identify rules belong to a specified
+ 	// policy for deletion.
+ 	PolicyUID types.UID
++	// The metadata of parent Policy. Used to associate the rule with Policy
++	// for troubleshooting purpose (logging and CLI).
++	PolicyName      string
++	PolicyNamespace string
+ }
+ 
+ // hashRule calculates a string based on the rule's content.","Question - do we cache NetworkPolicy itself? If so, here we can point to NetworkPolicy?",Why do we need both `PolicyName` and `PolicyNames
+2859,"@@ -11,7 +11,6 @@ import (
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/client-go/tools/cache""
+-	""k8s.io/client-go/util/workqueue""
+ 	""k8s.io/klog""
+ 
+ 	beehiveContext ""github.com/kubeedge/beehive/pkg/core/context""","For my view, `Register` means the process of **insert node resource to etcd through api-server**, which is called by upstream rather than here, how about changing the func name to `OnConnected`?",Why is this removed?
+2860,"@@ -865,7 +865,8 @@ public abstract class ProcessEngineConfigurationImpl extends ProcessEngineConfig
+ 
+ 
+   // telemetry ///////////////////////////////////////////////////////
+-  protected boolean telemetryEnabled = false;
++  /** if set to true the telemetry will be enabled from the first engine start*/
++  protected boolean telemetryInitialized = false;
+   /** The endpoint which telemetry is sent to */
+   protected String telemetryEndpoint = ""https://api.telemetry.camunda.cloud/pings"";
+ ","I would prefer an active verb for this property, e.g. `initializeTelemetry`. The reason is that this property refers to something the engine does once on startup. Other properties that use passive voice (e.g. `authorizationEnabled`) refer to a state of the engine during its lifetime.",This should be `true` by default.
+2861,"@@ -105,5 +105,10 @@ namespace Microsoft.Rest.Generator.NodeJS
+                 return requiredParams.ToString();
+             }
+         }
++
++        public bool ContainsTimeSpan
++        {
++            get { return this.Methods.FirstOrDefault(m => m.Parameters.FirstOrDefault(p => p.Type == PrimaryType.TimeSpan) != null) != null; }
++        }
+     }
+ }",please use new line to maintain reasonable line width,Why do we need this property?
+2862,"@@ -67,6 +67,9 @@ func (s *server) fileUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 	var fileSize uint64
+ 
+ 	ta := s.createTag(w, r)
++	if ta == nil {
++		return
++	}
+ 
+ 	// Add the tag to the context
+ 	r = r.WithContext(context.WithValue(r.Context(), tags.TagsContextKey{}, ta))",I would skip this check or add an internal server error response.,Why do we need this?
+2863,"@@ -7,6 +7,12 @@ const createDist = (buildConfig = config.defaultBuildConfig, options) => {
+   config.buildConfig = buildConfig
+   config.update(options)
+ 
++  if (config.notarize) {
++    notarize = config.notarize
++    notary_user = config.notary_user
++    notary_password = config.notary_password
++  }
++
+   util.updateBranding()
+   fs.removeSync(path.join(config.outputDir, 'dist'))
+   config.buildTarget = 'create_dist'",missing `{` here (and then `}` after `notary_password = config.notary_password`); it's only going to do the first one,Why do we need this?
+2864,"@@ -538,11 +538,10 @@ func TestDdevImportDB(t *testing.T) {
+ 				assert.True(settingsHashSalt)
+ 			case ""wordpress"":
+ 				// nolint: vetshadow
+-				hasAuthSalt, err := fileutil.FgrepStringInFile(app.SiteSettingsPath, ""SECURE_AUTH_SALT"")
++				hasAuthSalt, err := fileutil.FgrepStringInFile(app.SiteLocalSettingsPath, ""SECURE_AUTH_SALT"")
+ 				assert.NoError(err)
+ 				assert.True(hasAuthSalt)
+ 			}
+-
+ 		}
+ 
+ 		if site.DBTarURL != """" {","This is odd because it's actually in our generated SiteSettingsPath, not in the SiteLocalSettingsPath (wp-config-ddev.php). Are these two files swapped somehow? I'd expect SiteSettingsPath to be wp-config.php and SiteLocalSettingsPath to be wp-config-ddev.php. BTW, I'm *way* ok with renaming that to SiteDdevSettingsPath.",Why is this being removed?
+2865,"@@ -26,10 +26,13 @@ import (
+ 	""os/exec""
+ 	""path/filepath""
+ 	""strings""
++
++	ecpb ""kythe.io/kythe/proto/extraction_config_go_proto""
+ )
+ 
+ // kytheConfigFileName The name of the Kythe extraction config
+ const kytheExtractionConfigFile = "".kythe-extraction-config""
++const defaultConfigDir = ""kythe/go/extractors/config/default""
+ 
+ // Repo is a container of input/output parameters for doing extraction on remote
+ // repositories.",It seems like this must necessarily be a stopgap. Can you please add a TODO(#xyz) to point to the appropriate issue?,Why do we need this?
+2866,"@@ -29,12 +29,15 @@ func Agent(config *config.Agent) error {
+ 	defer logs.FlushLogs()
+ 
+ 	startKubelet(config)
+-	startKubeProxy(config)
++
++	if !config.DisableKubeProxy {
++		return startKubeProxy(config)
++	}
+ 
+ 	return nil
+ }
+ 
+-func startKubeProxy(cfg *config.Agent) {
++func startKubeProxy(cfg *config.Agent) error {
+ 	argsMap := map[string]string{
+ 		""proxy-mode"":           ""iptables"",
+ 		""healthz-bind-address"": ""127.0.0.1"",",Is the return signature necessary since we never actually return if there is a problem (I'm referring to the call to `logrus.Fatalf`). Let's pick a pattern and stick with it.,Shouldn't this be `return 
+2867,"@@ -5,6 +5,8 @@ export default Ember.Controller.extend({
+   barcodeUri: function() {
+     let id = this.get('model.id');
+     let name = this.get('model.name');
++
++    /* eslint new-cap: ['error', { 'capIsNew': false }]  */
+     return Ember.$(document).JsBarcode(id, {
+       width: 1,
+       height: 20,",@btecu why is this override needed here? I'm not seeing a `new` being used here.,Why is this needed?
+2868,"@@ -2527,7 +2527,11 @@ func (s *Server) leafNodeFinishConnectProcess(c *client) {
+ 	c.mu.Unlock()
+ 
+ 	// Make sure we register with the account here.
+-	c.registerWithAccount(acc)
++	if err := c.registerWithAccount(acc); err != nil {
++		c.Errorf(""Registering leaf with account %s resulted in error: %v"", acc.Name, err)
++		c.closeConnection(ProtocolViolation)
++		return
++	}
+ 	s.addLeafNodeConnection(c, _EMPTY_, _EMPTY_, false)
+ 	s.initLeafNodeSmapAndSendSubs(c)
+ 	if sendSysConnectEvent {",Should it not be more something like: `MaxAccountConnectionsExceeded` here?,Why do we need to close the connection?
+2869,"@@ -180,6 +180,13 @@ func TestTrimComputeEndpoint(t *testing.T) {
+ 		parseAndValidate(t, ""-compute_endpoint_override"", ""  http://endpoint "").ComputeEndpoint)
+ }
+ 
++func TestTrimComputeServiceAccount(t *testing.T) {
++	assert.Equal(t, """",
++		parseAndValidate(t, ""-compute_service_account"", "" 	"").ComputeServiceAccount)
++	assert.Equal(t, ""default"",
++		parseAndValidate(t, ""-compute_service_account"", "" default	"").ComputeServiceAccount)
++}
++
+ func TestGcsLogsDisabled(t *testing.T) {
+ 	assert.False(t, parseAndValidate(t, ""-disable_gcs_logging=false"").GcsLogsDisabled)
+ 	assert.True(t, parseAndValidate(t, ""-disable_gcs_logging=true"").GcsLogsDisabled)",minor: use a non-default CE service account for testing (since default is handled in a specific way in the code),nit: extra space after `default`
+2870,"@@ -84,6 +84,10 @@ func TestBootstrapWindowedPoSt(t *testing.T) {
+ 	wd, _ := os.Getwd()
+ 	genCfgPath := filepath.Join(wd, "".."", ""fixtures/setup.json"")
+ 	presealPath := filepath.Join(wd, "".."", ""fixtures/genesis-sectors"")
++	// setup presealed sectors and uncomment to run test against sectors with larger sector size
++	//genCfgPath := filepath.Join(""./512"", ""setup.json"")
++	//presealPath := ""./512""
++
+ 	genTime := int64(1000000000)
+ 	blockTime := 1 * time.Second
+ 	fakeClock := clock.NewFake(time.Unix(genTime, 0))","This is how I ran the 512MiB test. It's probably too much data for a fixture, and makes for longer functional tests (although still less than a minute on my laptop).",Can we remove these lines?
+2871,"@@ -90,7 +90,9 @@ module Beaker
+       # @return nil
+       # @api public
+       def resolve_symlinks!
+-        @options[:hosts_file] = File.realpath(@options[:hosts_file]) if @options[:hosts_file]
++        if @options[:hosts_file] && !@options[:hosts_file_generated]
++          @options[:hosts_file] = File.realpath(@options[:hosts_file])
++        end
+       end
+ 
+       #Converts array of paths into array of fully qualified git repo URLS with expanded keywords","So we weren't able to hide the fact that the file wasn't pre-generated and had to introduce this ""option"" to detect that?",Line is too long. [81/80]
+2872,"@@ -20,16 +20,11 @@
+ 
+ package http
+ 
+-import (
+-	""fmt""
+-
+-	""go.uber.org/yarpc/api/yarpcerrors""
+-)
+-
+-// TODO: Should we expose the maps as public variables to document the mappings?
++import ""go.uber.org/yarpc/api/yarpcerrors""
+ 
+ var (
+-	_codeToHTTPStatusCode = map[yarpcerrors.Code]int{
++	// CodeToStatusCode maps all Codes to their corresponding HTTP status code.
++	CodeToStatusCode = map[yarpcerrors.Code]int{
+ 		yarpcerrors.CodeOK:                 200,
+ 		yarpcerrors.CodeCancelled:          499,
+ 		yarpcerrors.CodeUnknown:            500,","Agree that exporting these maps is the best tradeoff, just registering my ongoing discontent with the lack of `const` collections.",I don't think we need this anymore.
+2873,"@@ -351,6 +351,15 @@ class WebKitCaret(browsertab.AbstractCaret):
+     def selection(self, callback):
+         callback(self._widget.selectedText())
+ 
++    def reverse_selection(self):
++        self._tab.run_js_async(""""""{
++            let sel = window.getSelection();
++            sel.setBaseAndExtent(
++                sel.extentNode, sel.extentOffset, sel.baseNode,
++                sel.baseOffset
++            );
++        }"""""")
++
+     def _follow_selected(self, *, tab=False):
+         if QWebSettings.globalSettings().testAttribute(
+                 QWebSettings.JavascriptEnabled):",This could probably use `const` as well?,Why do we need this?
+2874,"@@ -40,7 +40,7 @@ import (
+ // file.  The Restore method replaces the contents of the original with the
+ // backup, overwriting any changes that were made since the backup was created.
+ type File struct {
+-	orig, tmp string // file paths
++	Orig, Tmp string // file paths
+ }
+ 
+ // New creates a backup copy of the specified file, located in the same",it doesn't look like these need to be exported?,Why did this change?
+2875,"@@ -5,6 +5,7 @@ package fs
+ import (
+ 	""bytes""
+ 	""errors""
++	""fmt""
+ 	""io/ioutil""
+ 	""os""
+ 	""path/filepath""","I think you should remove ""fmt"" here. And change `fmt.Errorf` to `errors.Errorf`.",Why do we need this?
+2876,"@@ -0,0 +1,6 @@
++class AddVideoAttributesToProducts < ActiveRecord::Migration
++  def change
++    add_column :products, :length_in_days, :integer
++    add_column :products, :resources, :text, default: """", null: false
++  end
++end","Here's the `resources` attribute @jferris. I'm not against renaming `Product` to `Resource`, and this one... something else.",I don't think we need a migration for this.
+2877,"@@ -11,7 +11,7 @@ import (
+ // one of the workers, it is returned. FinalFunc is always run, regardless of
+ // any other previous errors.
+ func RunWorkers(ctx context.Context, count int, workerFunc func() error, finalFunc func()) error {
+-	wg, ctx := errgroup.WithContext(ctx)
++	wg, _ := errgroup.WithContext(ctx)
+ 
+ 	// run workers
+ 	for i := 0; i < count; i++ {","If the context is unused, this is equivalent to `var wg errgroup.Group`.",I don't think we should ignore the error he
+2878,"@@ -47,6 +47,8 @@ public interface HighlightParams {
+ 
+   // sizing
+   public static final String FRAGSIZE    = HIGHLIGHT+"".fragsize""; // OH, FVH, UH
++  public static final String FRAGALIGNRATIO = HIGHLIGHT+"".fragAlignRatio""; // UH
++  public static final String FRAGSIZEISMINIMUM = HIGHLIGHT+"".fragsizeIsMinimum""; // UH
+   public static final String FRAGMENTER  = HIGHLIGHT+"".fragmenter""; // OH
+   public static final String INCREMENT   = HIGHLIGHT+"".increment""; // OH
+   public static final String REGEX       = ""regex""; // OH",very minor: I'd prefer these two added rows are switched so that fragsizeIsMinimum directly follows fragsize,I think this should be `FRAGALIGN_RATIO`
+2879,"@@ -98,6 +98,10 @@ def is_local_interface(host):
+   if ':' in host:
+     host = host.split(':',1)[0]
+ 
++  # If ""localhost"" or a loopback IP has been specified it is a deliberate reference
++  if host == 'localhost' or host.startswith('127.'):
++    return False
++
+   try:
+     sock = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
+     sock.connect( (host, 4242) )","Given that 115 returns `True`, why would this be `False` here?",I don't think this is the right way to do t
+2880,"@@ -367,6 +367,17 @@ public class OAuth2LoginConfigurerTests {
+ 		assertThat(this.response.getRedirectedUrl()).matches(""http://localhost/oauth2/authorization/google"");
+ 	}
+ 
++	// gh-6802
++	@Test
++	public void oauth2LoginWithOneClientConfiguredAndFormLoginThenRedirectDefaultLoginPage() throws Exception {
++		loadConfig(OAuth2LoginConfigFormLogin.class);
++		String requestUri = ""/"";
++		this.request = new MockHttpServletRequest(""GET"", requestUri);
++		this.request.setServletPath(requestUri);
++		this.springSecurityFilterChain.doFilter(this.request, this.response, this.filterChain);
++		assertThat(this.response.getRedirectedUrl()).matches(""http://localhost/login"");
++	}
++
+ 	// gh-5347
+ 	@Test
+ 	public void oauth2LoginWithOneClientConfiguredAndRequestFaviconNotAuthenticatedThenRedirectDefaultLoginPage()",Please move this test method just below `oauth2LoginWithOneClientConfiguredThenRedirectForAuthorization()`,I think you can use `Mockito.mock(HttpServletRequest.class)`
+2881,"@@ -270,6 +270,9 @@ bool LatencyTestPublisher::init(int n_sub, int n_sam, bool reliable, uint32_t pi
+     PubDataparam.topic.topicName = pt.str();
+     PubDataparam.times.heartbeatPeriod.seconds = 0;
+     PubDataparam.times.heartbeatPeriod.fraction = 4294967 * 100;
++    PubDataparam.qos.m_liveliness.lease_duration = c_TimeInfinite;
++    PubDataparam.qos.m_liveliness.announcement_period = Duration_t(1, 0);
++    
+     if (!reliable)
+     {
+         PubDataparam.qos.m_reliability.kind = BEST_EFFORT_RELIABILITY_QOS;",Why this new configuration?,Why is this needed?
+2882,"@@ -245,8 +245,14 @@ public class IcebergPigInputFormat<T> extends InputFormat<Void, T> {
+ 
+     private Object convertPartitionValue(Type type, Object value) {
+       if (type.typeId() == Types.BinaryType.get().typeId()) {
+-        ByteBuffer buffer = (ByteBuffer) value;
+-        return new DataByteArray(buffer.get(new byte[buffer.remaining()]).array());
++        ByteBuffer dupe = ((ByteBuffer) value).duplicate();
++        if (dupe.hasArray()) {
++          return new DataByteArray(dupe.array());
++        } else {
++          byte[] bytes = new byte[dupe.remaining()];
++          dupe.get(bytes);
++          return new DataByteArray(bytes);
++        }
+       }
+ 
+       return value;","I don't think that we need to check `hasArray` here. I think the reason why this didn't previously check `hasArray` is that the array passed to `DataByteArray` must start at offset 0 and be valid through the array length, so a copy was needed in almost every case. It may be simpler to change this to use `ByteBuffers.toByteArray` and pass the result to create `DataByteArray`.",nit: `dupe` -> `dupeByteBuffer`
+2883,"@@ -28,15 +28,15 @@ namespace OpenTelemetry.Metrics
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""SpanContext""/>.</param>
++        /// <param name=""spanReference"">the associated <see cref=""SpanReference""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in SpanContext context, T value);
++        public abstract void Add(in SpanReference spanReference, T value);
+ 
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""Baggage""/>.</param>
++        /// <param name=""spanReference"">the associated <see cref=""Baggage""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in Baggage context, T value);
++        public abstract void Add(in Baggage spanReference, T value);
+     }
+ }",`spanReference` -> `baggage`  ,Why do we need to change the name of this method?
+2884,"@@ -32,9 +32,8 @@ module.exports = function(config, auth, storage) {
+     });
+   });
+ 
+-  router.get('/-/logo', function(req, res) {
+-    res.sendFile(_.get(config, 'web.logo') || `${env.APP_ROOT}/static/logo-sm.png`
+-    );
++  router.get('/-/verdaccio/logo', function(req, res) {
++    res.send(_.get(config, 'web.logo') || '/-/static/logo.png');
+   });
+ 
+   router.get('/', function(req, res) {",Why the `/-/verdaccio/` ?,I think this should be `/-/static/logo.png`
+2885,"@@ -478,8 +478,7 @@ func TestAppDeployOpts_pushAddonsTemplateToS3Bucket(t *testing.T) {
+ 
+ 			opts := appDeployOpts{
+ 				appDeployVars: appDeployVars{
+-					AppName:      tc.inputApp,
+-					enableAddons: true,
++					AppName: tc.inputApp,
+ 					GlobalOpts: &GlobalOpts{
+ 						projectName: tc.inputProject,
+ 					},",Has been waiting for a million years ,Why is this removed?
+2886,"@@ -31,6 +31,10 @@ msg.Number = {};
+ msg.Number.min = ""Path `{PATH}` ({VALUE}) is less than minimum allowed value ({MIN})."";
+ msg.Number.max = ""Path `{PATH}` ({VALUE}) is more than maximum allowed value ({MAX})."";
+ 
++msg.Date = {};
++msg.Date.min = ""Path `{PATH}` ({VALUE}) is before than minimum allowed value ({MIN})."";
++msg.Date.max = ""Path `{PATH}` ({VALUE}) is after than maximum allowed value ({MAX})."";
++
+ msg.String = {};
+ msg.String.enum = ""`{VALUE}` is not a valid enum value for path `{PATH}`."";
+ msg.String.match = ""Path `{PATH}` is invalid ({VALUE})."";",Minor grammar detail: the 'than' is unnecessary,I don't think we need the `<msg>`<msg>`<msg
+2887,"@@ -4873,10 +4873,11 @@ class Series(Frame, IndexOpsMixin, Generic[T]):
+         >>> kser.item()
+         10
+         """"""
+-        item_top_two = self[:2]
++        scol = self.spark_column
++        item_top_two = self._internal._sdf.select(scol).head(2)
+         if len(item_top_two) != 1:
+             raise ValueError(""can only convert an array of size 1 to a Python scalar"")
+-        return item_top_two[0]
++        return item_top_two[0][0]
+ 
+     def _cum(self, func, skipna, part_cols=()):
+         # This is used to cummin, cummax, cumsum, etc.",I think you can just simply fix this line to `self[:2].to_pandas()`,Why do we need this change?
+2888,"@@ -1229,6 +1229,14 @@ class WebDriver {
+     if (target && cdpTargets.indexOf(target.toLowerCase()) === -1) {
+       throw new error.InvalidArgumentError('invalid target value')
+     }
++
++    if (debuggerAddress.match(/\/se\/cdp/)) {
++      if (debuggerAddress.match(""ws:\/\/"", ""http:\/\/"")) {
++        return debuggerAddress.replace(""ws:\/\/"", ""http:\/\/"") 
++      }
++      return debuggerAddress
++    }
++
+     const path = '/json/version'
+     let request = new http.Request('GET', path)
+     let client = new http.HttpClient('http://' + debuggerAddress)",if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?,I don't think this is the right way to do this. We should be able to get rid of the `/se\/cdp/` part and just use `debuggerAddress` directly.
+2889,"@@ -20,6 +20,6 @@
+  * Internal dependencies
+  */
+ import Data from 'googlesitekit-data';
+-import { registerStore } from 'assets/js/googlesitekit/datastore/site';
++import { registerStore } from './googlesitekit/datastore/site';
+ 
+ registerStore( Data );",I could add a resolver for this (like above) but it seems more sensible to just change the one reference!,Why is this change necessary?
+2890,"@@ -44,11 +44,14 @@ public class TimestampMoreRecentThanParent implements DetachedBlockHeaderValidat
+ 
+   private boolean validateHeaderSufficientlyAheadOfParent(
+       final long timestamp, final long parentTimestamp) {
+-    if ((timestamp - minimumSecondsSinceParent) < parentTimestamp) {
++    final long actualTimeSinceParent = timestamp - parentTimestamp;
++    if (actualTimeSinceParent < minimumSecondsSinceParent) {
+       LOG.trace(
+-          ""Invalid block header: timestamp {} is not sufficiently newer than parent timestamp {}"",
++          ""Invalid block header: timestamp {} is only {} seconds newer than parent timestamp {}. Minimum {} seconds"",
+           timestamp,
+-          parentTimestamp);
++          actualTimeSinceParent,
++          parentTimestamp,
++          minimumSecondsSinceParent);
+       return false;
+     }
+ ","not sure ""actual"" adds value - secondsSinceParent is probably closer.",nit: `is only {} seconds newer than parent timestamp {}. Minimum {} seconds`
+2891,"@@ -159,7 +159,7 @@ module Blacklight::SearchHelper
+   # Get the solr response when retrieving only a single facet field
+   # @return [Blacklight::SolrResponse] the solr response
+   def get_facet_field_response(facet_field, user_params = params || {}, extra_controller_params = {})
+-    query = search_builder.with(user_params).merge(extra_controller_params).merge(solr_facet_params(facet_field, user_params, extra_controller_params))
++    query = search_builder.with(user_params).facet(facet_field).merge(extra_controller_params)
+     repository.search(query)
+   end
+ ",Line is too long. [94/80],Style/MutableConstant: Freeze mutable objects assigned to constants.
+2892,"@@ -585,4 +585,7 @@ return [
+         'image_size' => 'Image size:',
+         'selected_size' => 'Selected:'
+     ],
++    'repeater' => [
++        'min_items_error' => 'You cannot delete any item. You should modify the existing.'
++    ]
+ ];",The error should be `At least :number items are required`,This should be `You cannot delete any item. You should modify the existing item.`
+2893,"@@ -172,11 +172,9 @@ func (s *server) Ping(in *pb.Request, stream pb.Simulator_PingServer) error {
+ 	// message type of 1999 means that it's a dummy message to allow the engine to pass back proposed blocks
+ 	if in.InternalMsgType != dummyMsgType {
+ 		msg := CombineMsg(in.InternalMsgType, msgValue)
+-		switch msg.(type) {
+-		case *iproto.ProposePb:
+-			err = s.nodes[in.PlayerID].HandleBlockPropose(msg.(*iproto.ProposePb), done)
+-		case *iproto.EndorsePb:
+-			err = s.nodes[in.PlayerID].HandleEndorse(msg.(*iproto.EndorsePb), done)
++		switch cMsg := msg.(type) {
++		case *iproto.ConsensusPb:
++			err = s.nodes[in.PlayerID].HandleConsensusMsg(cMsg, done)
+ 		}
+ 		if err != nil {
+ 			logger.Error().Err(err).Msg(""failed to handle view change"")",singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`),Why is this change needed?
+2894,"@@ -506,11 +506,7 @@ type encryptionKeyGetter interface {
+ 		kbfscrypto.TLFCryptKey, error)
+ }
+ 
+-// KeyManager fetches and constructs the keys needed for KBFS file
+-// operations.
+-type KeyManager interface {
+-	encryptionKeyGetter
+-
++type mdDecryptionKeyGetter interface {
+ 	// GetTLFCryptKeyForMDDecryption gets the crypt key to use for the
+ 	// TLF with the given metadata to decrypt the private portion of
+ 	// the metadata.  It finds the appropriate key from mdWithKeys",Could combine this with `encryptionKeyGetter` to have a single `keyGetter` interface. I'm not sure which way is better.,I think this should be `GetTLFCryptKeyForMDDecryption`
+2895,"@@ -6316,7 +6316,8 @@ Lng32 SQL_EXEC_DeleteHbaseJNI()
+       threadContext->incrNumOfCliCalls();
+ 
+       HBaseClient_JNI::deleteInstance();
+-      HiveClient_JNI::deleteInstance();
++      // The Hive client persists across connections
++      // HiveClient_JNI::deleteInstance();
+    }
+    catch(...)
+    {",Is there any security issue here? If we integrate with Hive security (and I don't know if we have or not) is there some notion of re-authentication at connection time?,Why do we need this?
+2896,"@@ -22,7 +22,7 @@ const illegalCommandFields = [
+   'raw',
+   'readPreference',
+   'session',
+-  'writeConcern'
++  'readConcern'
+ ];
+ 
+ class CreateCollectionOperation extends CommandOperation {",Does this mean we do not support writeConcern on `createCollection`?,Why did you change this?
+2897,"@@ -36,7 +36,7 @@ func TestProducer_RequestSessionDestroy(t *testing.T) {
+ 	assert.NoError(t, err)
+ 
+ 	destroySender := &fakeDestroySender{}
+-	err = RequestSessionDestroy(destroySender, sid)
++	err = RequestSessionDestroy(destroySender, sid.ID)
+ 	assert.NoError(t, err)
+ }
+ ","I guess `sid` was for `sessionID`, but now it looks strange: `sid.ID`.",Why is this change neede
+2898,"@@ -379,7 +379,11 @@ func (s *Service) getSecurityGroupIngressRules(role infrav1.SecurityGroupRole) (
+ 				Protocol:    infrav1.SecurityGroupProtocolTCP,
+ 				FromPort:    6443,
+ 				ToPort:      6443,
+-				CidrBlocks:  []string{anyIPv4CidrBlock},
++				SourceSecurityGroupIDs: []string{
++					s.scope.SecurityGroups()[infrav1.SecurityGroupAPIServerLB].ID,
++					s.scope.SecurityGroups()[infrav1.SecurityGroupControlPlane].ID,
++					s.scope.SecurityGroups()[infrav1.SecurityGroupNode].ID,
++				},
+ 			},
+ 			{
+ 				Description:            ""etcd"",",We'll need `infrav1.SecurityGroupBastion` as well,Why do we need this chan
+2899,"@@ -1470,6 +1470,15 @@ func Rcat(fdst fs.Fs, dstFileName string, in io.ReadCloser, modTime time.Time) (
+ 	return dst, nil
+ }
+ 
++// PublicLink adds a ""readable by anyone with link"" permission on the given file or folder.
++func PublicLink(f fs.Fs, fileName string) (string, error) {
++	doPublicLink := f.Features().PublicLink
++	if doPublicLink == nil {
++		return """", errors.Errorf(""%v doesn't support public links"", f)
++	}
++	return doPublicLink(fileName)
++}
++
+ // Rmdirs removes any empty directories (or directories only
+ // containing empty directories) under f, including f.
+ func Rmdirs(f fs.Fs, dir string, leaveRoot bool) error {",This `fileName` should probably be `remote` and be relative to the Fs root as per normal rclone usage.,I don't think we need th
+2900,"@@ -243,12 +243,12 @@ public class SmartStoreLoadTest extends InstrumentationTestCase {
+         // Without indexing for new index specs
+         alterSoup(""Adding one index / no re-indexing"", false, new IndexSpec[]{new IndexSpec(""k_0"", indexType), new IndexSpec(""k_1"", indexType)});
+         alterSoup(""Adding one index / dropping one index / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_2"", indexType)});
+-        alterSoup(""Dropping two indexes / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_3"", indexType)});
++        alterSoup(""Dropping one index / no re-indexing"", false, new IndexSpec[] {new IndexSpec(""k_0"", indexType)});
+ 
+         // With indexing for new index specs
+         alterSoup(""Adding one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_1"", indexType)});
+         alterSoup(""Adding one index / dropping one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType), new IndexSpec(""k_2"", indexType)});
+-        alterSoup(""Dropping two indexes / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_3"", indexType)});
++        alterSoup(""Dropping one index / with re-indexing"", true, new IndexSpec[] {new IndexSpec(""k_0"", indexType)});
+     }
+     
+     private void alterSoup(String msg, boolean reIndexData, IndexSpec[] indexSpecs) throws JSONException {",That way we are back to having just one index on k_0 So we can really compare the execution times with and without re-indexing,Why did you change this?
+2901,"@@ -52,6 +52,13 @@ public class AttachmentView extends FrameLayout {
+     public String contentType;
+     public long size;
+     public ImageView iconView;
++    
++    /**
++     * Regular expression that represents characters that aren't allowed
++     * to be used in file names saved using K-9
++     */
++    private static final String specialCharacters = new String(""[^\\d\\s\\w!"" +
++    		""#\\$%&'\\(\\)\\-@\\^_`\\{\\}~.,]"");
+ 
+     private AttachmentFileDownloadCallback callback;
+ ",Expression that uses a negation pattern to exclude all characters that aren't in the expression.,I'm not sure if this is 
+2902,"@@ -82,6 +82,10 @@ const (
+ 	// feature is supported on the server. If any non-empty value is set,
+ 	// this indicates true.
+ 	BothResponseErrorHeader = ""Rpc-Both-Response-Error""
++
++	// Echo ServiceHeader in Request header which can be used by clients/HC to
++	// validate request went to the correct service
++	RespondServiceHeader = ""Rpc-Respond-Service-Header""
+ )
+ 
+ // Valid values for the Rpc-Status header.","Similar to my suggestion for HTTP, let's remove this and use `ServiceHeader` instead.",nit: `RespondServiceHead
+2903,"@@ -135,7 +135,7 @@ func addCustomCommands(rootCmd *cobra.Command) error {
+ 				}
+ 
+ 				descSuffix := "" (shell "" + service + "" container command)""
+-				if serviceDirOnHost[0:1] == ""."" {
++				if commandSet == targetGlobalCommandPath {
+ 					descSuffix = "" (global shell "" + service + "" container command)""
+ 				}
+ 				commandToAdd := &cobra.Command{","The serviceDirOnHost[0:1] was completely wrong. It wasn't just Windows, glad you got this fixed!",Why do we need this chan
+2904,"@@ -38,7 +38,7 @@ import (
+ 	controllerconfig ""antrea.io/antrea/pkg/config/controller""
+ )
+ 
+-const waitEgressRealizedTimeout = 3 * time.Second
++const waitEgressRealizedTimeout = 15 * time.Second
+ 
+ func TestEgress(t *testing.T) {
+ 	skipIfProviderIs(t, ""kind"", ""pkt_mark field is not properly supported for OVS userspace (netdev) datapath."")",Would membership take 10+ seconds to detect the failed node?,Why was this changed?
+2905,"@@ -227,11 +227,14 @@ def _sanitize_markdown(mdtext):
+ 
+ def _load_introduction(path):
+     ""Loads the introduction text from a Markdown file""
++    if not os.path.exists(path):
++        return None
++
+     try:
+         with open(path) as f:
+             return _sanitize_markdown(f.read())
+-    except:
+-        return None
++    except Exception as err:
++        raise RuntimeError(f'Makrdown file ""{path}"" could not be loaded: {err}')
+ 
+ 
+ def _load_skill(path, course):","hmm, in this case perhaps the whole try-except could be removed altogether? because if the file does not exist, it's already returning `None`. In any other case it should actually probably fail with the exception, no?",Why is this necessary
+2906,"@@ -0,0 +1,14 @@
++package cmd
++
++import (
++	""github.com/mitchellh/go-homedir""
++	""path/filepath""
++)
++
++func GetDirectory(paths ...string) string {
++	dir, _ := homedir.Dir()
++
++	dir = filepath.Join(dir, "".mysterium"", filepath.Join(paths...))
++
++	return dir
++}",This function does not need to be public,I think this should b
+2907,"@@ -60,14 +60,14 @@ export default function SetupForm( { finishSetup } ) {
+ 		>
+ 			<ErrorNotice />
+ 
++			<ExistingTagNotice />
++
+ 			{ ( !! accounts.length && ! hasExistingTag ) && (
+-				<p>
++				<p style={ { marginBottom: 0 } }>
+ 					{ __( 'Please select the account information below. You can change this view later in your settings.', 'google-site-kit' ) }
+ 				</p>
+ 			) }
+ 
+-			<ExistingTagNotice />
+-
+ 			<div className=""googlesitekit-setup-module__inputs"">
+ 				<AccountSelect />
+ ",  Any chance we can get a CSS class for this? I know it's just in one place but feels like a dangerous precedent to set.,I think this should b
+2908,"@@ -119,7 +119,7 @@ namespace AutoRest.Ruby.Azure.TemplateModels
+                 if (ReturnType.Body is CompositeType)
+                 {
+                     CompositeType compositeType = (CompositeType)ReturnType.Body;
+-                    if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension))
++                    if (compositeType.Extensions.ContainsKey(AzureExtensions.PageableExtension) && this.Extensions.ContainsKey(""nextMethodName""))
+                     {
+                         bool isNextLinkMethod = this.Extensions.ContainsKey(""nextLinkMethod"") && (bool)this.Extensions[""nextLinkMethod""];
+                         bool isPageable = (bool)compositeType.Extensions[AzureExtensions.PageableExtension];","> && this.Extensions.ContainsKey(""nextMethodName"") [](start = 96, length = 48) From line 124, looks like we don't need `&& this.Extensions.ContainsKey(""nextMethodName"")` condition or we don't need line 124 #Closed",Why is this change needed?
+2909,"@@ -1,16 +1,5 @@
+-import { options } from 'preact';
+ import { assign } from './util';
+ 
+-let oldVNodeHook = options.vnode;
+-options.vnode = vnode => {
+-	if (vnode.type && vnode.type._forwarded && vnode.ref) {
+-		vnode.props.ref = vnode.ref;
+-		vnode.ref = null;
+-	}
+-
+-	if (oldVNodeHook) oldVNodeHook(vnode);
+-};
+-
+ /**
+  * Pass ref down to a child. This is mainly used in libraries with HOCs that
+  * wrap components. Using `forwardRef` there is an easy way to get a reference",Moving this code from compat to core shaves 47 bytes out of compat and only adds 6 bytes to core so I thought it was worth it.,Why was this removed?
+2910,"@@ -52,11 +52,11 @@ namespace NLog.LayoutRenderers
+         private readonly string _baseDir;
+ 
+ #if !SILVERLIGHT && !NETSTANDARD1_3
+-
+         /// <summary>
+         /// cached
+         /// </summary>
+         private string _processDir;
++#endif
+ 
+         /// <summary>
+         /// Use base dir of current process.","Please use "".NET Core 3"" - i'm trying hard to use one form, and this is the one MS advices",Why was this removed?
+2911,"@@ -87,6 +87,11 @@ func StartSession(params *TelemetrySessionParams, statsEngine stats.Engine) erro
+ 			seelog.Errorf(""Error: lost websocket connection with ECS Telemetry service (TCS): %v"", tcsError)
+ 			params.time().Sleep(backoff.Duration())
+ 		}
++		select {
++		case <-params.Ctx.Done():
++			return nil
++		default:
++		}
+ 	}
+ }
+ ","Unrelated to this change, but this is a fix for when TestDoStartCgroupInitHappyPath has a failure after the test goroutine has already exited.",Why do we need to return h
+2912,"@@ -29,6 +29,7 @@ import qutebrowser
+ from qutebrowser.utils import docutils
+ from qutebrowser.browser import pdfjs
+ 
++from end2end.features.test_scroll_bdd import check_scrolled, check_not_scrolled
+ 
+ bdd.scenarios('misc.feature')
+ ","Hmm, I'd really expect this to work, and yet it doesn't. I'll investigate later, though it might get Monday until I get the time.",F401 'check_not_scrolled' imported but unused
+2913,"@@ -356,7 +356,7 @@ TEST(svm_thunder_dense_test, can_classify_any_two_labels) {
+ 
+         auto support_indices_table = result_train.get_support_indices();
+         const auto support_indices = row_accessor<const float>(support_indices_table).pull();
+-        for (size_t i = 0; i < support_indices.get_count(); i++) {
++        for (std::int64_t i = 0; i < support_indices.get_count(); i++) {
+             ASSERT_EQ(support_indices[i], i);
+         }
+ ",Does this changes affect process building dynamic libraries anyhow?,Why not `std::size_t`?
+2914,"@@ -26,7 +26,7 @@ import struct
+ import time
+ from scapy.packet import *
+ from scapy.fields import *
+-from scapy.contrib.ppi import PPIGenericFldHdr, addPPIType
++from scapy.layers.dot11 import *
+ from scapy.error import warning
+ import scapy.modules.six as six
+ from scapy.modules.six.moves import range",Could you limit what is imported here?,I don't think we need this import anymore.
+2915,"@@ -1078,12 +1078,15 @@ def do_set_function_code(lambda_function: LambdaFunction):
+     if not lambda_cwd:
+         return
+ 
+-    # get local lambda working directory
++    # get local lambda code archive path
+     tmp_file = os.path.join(lambda_cwd, LAMBDA_ZIP_FILE_NAME)
+ 
+     if not zip_file_content:
+         zip_file_content = load_file(tmp_file, mode=""rb"")
+ 
++    # override lambda archive with fresh code if we got an update
++    save_file(tmp_file, zip_file_content)
++
+     # Set the appropriate lambda handler.
+     lambda_handler = generic_handler
+     is_java = lambda_executors.is_java_lambda(runtime)","just to clarify - on line 1074 we update `zip_file_content` for non-local lambdas, but never store it, which means lambda never picks it up",Why is this needed?
+2916,"@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
+ func icmpPkt(src, dst string) packet {
+ 	return packetWithPorts(1, src+"":0"", dst+"":0"")
+ }
++func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
++	return packet{
++		protocol: 1,
++		srcAddr:  src,
++		srcPort:  0,
++		dstAddr:  dst,
++		dstPort:  (icmpCode << 8) | (icmpType),
++	}
++}
+ 
+ var polProgramTests = []polProgramTest{
+ 	// Tests of actions and flow control.
+-
+ 	{
+ 		PolicyName: ""no tiers"",
+ 		DroppedPackets: []packet{",Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain,nit: `icmpPkt` -> `icmpPktWithTypeCode`
+2917,"@@ -127,11 +127,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+         {
+             using (var response = await client.SendAsync(request).ConfigureAwait(false))
+             {
+-                if (response.StatusCode != HttpStatusCode.OK &&
+-                    response.StatusCode != HttpStatusCode.Accepted)
+-                {
+-                    var statusCode = (int)response.StatusCode;
+-                }
++                // disposing response
+             }
+         }
+ ",We can do away with assigning the response here too.,Why was this removed?
+2918,"@@ -18,7 +18,7 @@ function ngGridFlexibleHeightPlugin (opts) {
+                 }
+             }
+ 
+-            var newViewportHeight = naturalHeight + 2;
++            var newViewportHeight = naturalHeight + 3;
+             if (!self.scope.baseViewportHeight || self.scope.baseViewportHeight !== newViewportHeight) {
+                 self.grid.$viewport.css('height', newViewportHeight + 'px');
+                 self.grid.$root.css('height', (newViewportHeight + extraHeight) + 'px');",Bumping the newViewportHeight,Why did you change this?
+2919,"@@ -47,7 +47,7 @@ import org.apache.solr.util.LongIterator;
+  *   <li><a href=""https://github.com/aggregateknowledge/postgresql-hll"">postgresql-hll</a>, and</li>
+  *   <li><a href=""https://github.com/aggregateknowledge/js-hll"">js-hll</a></li>
+  * </ul>
+- * when <a href=""https://github.com/aggregateknowledge/postgresql-hll/blob/master/STORAGE.markdown"">properly serialized</a>.
++ * when <a href=""https://github.com/aggregateknowledge/postgresql-hll/blob/secondaryy/STORAGE.markdown"">properly serialized</a>.
+  */
+ public class HLL implements Cloneable {
+     // minimum and maximum values for the log-base-2 of the number of registers",Is this change correct? Looks like a typo and not sure this should be changed?,I think this should be `secondaryy`
+2920,"@@ -43,6 +43,14 @@ def _read_stdin():
+     return sys.stdin.read()
+ 
+ 
++def _load_reporter_by_class(reporter_class: str) -> type:
++    qname = reporter_class
++    module_part = astroid.modutils.get_module_part(qname)
++    module = astroid.modutils.load_module_from_name(module_part)
++    class_name = qname.split(""."")[-1]
++    return getattr(module, class_name)
++
++
+ # Python Linter class #########################################################
+ 
+ MSGS = {",I checked the tests coverage and strangely it look like those three lines are not covered (?!). Do you have the same result on your side ?,I think this should be `_load_reporter_by_name`
+2921,"@@ -35,4 +35,4 @@ namespace System.MathBenchmarks
+             }
+         }
+     }
+-}
++}","nit: please try to avoid changing end of the file (it adds a noise to the code review, but does not provide too much value)",} else {
+2922,"@@ -57,9 +57,16 @@ namespace AutoRest.Swagger.Model.Utilities
+                                                     .Where(modelName => !(IsBaseResourceModelName(modelName))
+                                                                         && serviceDefinition.Definitions.ContainsKey(modelName)
+                                                                         && IsAllOfOnModelNames(modelName, serviceDefinition.Definitions, xmsAzureResourceModels));
++
++            var unfilteredResourceCandidates = resourceModels.Union(modelsAllOfOnXmsAzureResources);
++
++            // Now filter all the resource models that are returned from a POST operation only 
++            var postOpResourceModels = serviceDefinition.Paths.Values.SelectMany(pathObj => pathObj.Where(opObj => opObj.Key.EqualsIgnoreCase(""post""))
++                                                                     .SelectMany(opObj => opObj.Value.Responses?.Select(resp => resp.Value?.Schema?.Reference?.StripDefinitionPath())))
++                                                                     .Where(model => !string.IsNullOrWhiteSpace(model));
+             
+-            // return the union 
+-            return resourceModels.Union(modelsAllOfOnXmsAzureResources);
++            // if any model is returned only by a POST operation, disregard it
++            return unfilteredResourceCandidates.Except(postOpResourceModels);
+ 
+         }
+ ","I don't see the ""only"" part reflected in the code but maybe I'm missing it. Also, the indentation is misleading: the `.SelectMany` calls are perfectly aligned but are *not* operating on the same ""level"". I'd expect the second `SelectMany` to be on the same height as the inner `Where`, just break `pathObj => pathObj<HERE>.Where` and lines won't be that long.",I think this should be `.Except(modelsAllOfOnXm
+2923,"@@ -20,7 +20,8 @@ Puppet::DataTypes.create_type('Target') do
+       vars => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
+       facts => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
+       features => { type => Optional[Array[String[1]]], kind => given_or_derived },
+-      plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived }
++      plugin_hooks => { type => Optional[Hash[String[1], Data]], kind => given_or_derived },
++      resources => { type => Optional[Hash[String[1], ResourceInstance]], kind => given_or_derived }
+     },
+     functions => {
+       host => Callable[[], Optional[String]],","It seems like most of these will never be nil, are they optional just in case?",I'm not sure if this is the right place to put 
+2924,"@@ -88,7 +88,7 @@ public class TableCodecTest {
+       try {
+         byte[] bytes = TableCodec.encodeRow(tblInfo.getColumns(), values, tblInfo.isPkHandle());
+         // testing the correctness via decodeRow
+-        Row row = TableCodec.decodeRow(bytes, tblInfo.getColumns());
++        Row row = TableCodec.decodeRow(bytes, -1, tblInfo);
+         for (int j = 0; j < tblInfo.getColumns().size(); j++) {
+           assertEquals(row.get(j, null), values[j]);
+         }","`.addColumn(""c1"", IntegerType.INT, true)` means `PkHandle=true`, maybe should add `.setPkHandle(true)` in line 31",Why this change?
+2925,"@@ -56,8 +56,10 @@ public class RowKey extends Key implements Serializable {
+     Object obj = handle.getValue();
+     if (obj instanceof Long) {
+       return new RowKey(tableId, (long) obj);
++    } else if (obj instanceof Integer) {
++      return new RowKey(tableId, ((Integer) obj).longValue());
+     }
+-    throw new TiExpressionException(""Cannot encode row key with non-long type"");
++    throw new TiExpressionException(""Cannot encode row key with non-long or non-integer type"");
+   }
+ 
+   public static RowKey createMin(long tableId) {",how about `Cannot encode row key with non-integer type` directly?,Why do we need t
+2926,"@@ -42,6 +42,9 @@ public interface ExecutorLoader {
+   Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
+       throws ExecutorManagerException;
+ 
++  Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
++      throws ExecutorManagerException;
++
+   Pair<ExecutionReference, ExecutableFlow> fetchActiveFlowByExecId(int execId)
+       throws ExecutorManagerException;
+ ",The method names `fetchUnfinishedExecutions` and `fetchUnfinishedFlows` are too similar to each other. Would it be better to use the name `fetchUnfinishedFlowsMetadata` since you are only fetching metadata info about the flow?,Why do we need t
+2927,"@@ -26,6 +26,17 @@ module Travis
+                 sh.cmd ""wget -q -O tmate.tar.xz #{static_build_linux_url}"", echo: false, retry: true
+                 sh.cmd ""tar --strip-components=1 -xf tmate.tar.xz"", echo: false
+               end
++              sh.elif ""$(uname) = 'FreeBSD'"" do
++                sh.cmd 'sudo pkg install -y libevent msgpack libssh', echo: true
++                sh.cmd 'git clone https://github.com/tmate-io/tmate.git', echo: true
++                sh.cd 'tmate', echo: false, stack: true
++                sh.cmd 'git checkout 2.4.0', echo: true
++                sh.cmd './autogen.sh', echo: true
++                sh.cmd './configure', echo: true
++                sh.cmd 'make', echo: true
++                sh.cmd 'sudo make install', echo: true
++                sh.cd :back, echo: false, stack: true
++              end
+               sh.else do
+                 sh.echo ""We are setting up the debug environment. This may take a while...""
+                 sh.cmd ""brew update &> /dev/null"", echo: false, retry: true",Note that `sudo` is not available by default on BSDs; there are a few places in the codebase here where that's explicitly worked around by using `su`.,Why do we need t
+2928,"@@ -0,0 +1,5 @@
++// Package importpath is used to implement a test on Go import paths.
++package importpath
++
++// Answer is the answer to Life, the Universe and Everything.
++const Answer = 42",ultra nit: missing Oxford comma :P,I think this should be `const Answer = 42`
+2929,"@@ -729,6 +729,16 @@ class SparkFrameMethods(object):
+         == Physical Plan ==
+         ...
+ 
++        >>> df.spark.explain(""extended"")  # doctest: +SKIP
++        == Parsed Logical Plan ==
++        ...
++        == Analyzed Logical Plan ==
++        ...
++        == Optimized Logical Plan ==
++        ...
++        == Physical Plan ==
++        ...
++
+         >>> df.spark.explain(mode=""extended"")  # doctest: +ELLIPSIS
+         == Parsed Logical Plan ==
+         ...",This is not supported in Spark 3.0.0-rc2 yet. I'd skip this for now.,Why is this skipped?
+2930,"@@ -13,5 +13,6 @@ import (
+ // like sending and awaiting mined ones.
+ type Message interface {
+ 	Send(ctx context.Context, from, to types.Address, val *types.AttoFIL, method string, params ...interface{}) (*cid.Cid, error)
++	Query(ctx context.Context, from, to types.Address, method string, params ...interface{}) ([][]byte, *exec.FunctionSignature, error)
+ 	Wait(ctx context.Context, msgCid *cid.Cid, cb func(blk *types.Block, msg *types.SignedMessage, receipt *types.MessageReceipt, signature *exec.FunctionSignature) error) error
+ }",BLOCKING: Why does `Query` return an `*exec.FunctionSignature`?,Why do we need this?
+2931,"@@ -562,14 +562,14 @@ func (c *ConfigLocal) MaxDirBytes() uint64 {
+ 	return c.maxDirBytes
+ }
+ 
+-// ResetCaches implements the Config interface for ConfigLocal.
+-func (c *ConfigLocal) ResetCaches() {
++func (c *ConfigLocal) resetCachesWithoutShutdown() DirtyBlockCache {
+ 	c.lock.Lock()
+ 	defer c.lock.Unlock()
+ 	c.mdcache = NewMDCacheStandard(5000)
+ 	c.kcache = NewKeyCacheStandard(5000)
+ 	// Limit the block cache to 10K entries or 1024 blocks (currently 512MiB)
+ 	c.bcache = NewBlockCacheStandard(c, 10000, MaxBlockSizeBytesDefault*1024)
++	oldDirtyBcache := c.dirtyBcache
+ 	minFactor := 1
+ 	if maxParallelBlockPuts > 10 {
+ 		minFactor = maxParallelBlockPuts / 10",please move this down to immediately above the assignment to `c.dirtyBcache`,nit: `oldDirtyBcache` -> `dirtyCache`
+2932,"@@ -63,3 +63,19 @@ func Example() {
+ 	// Output:
+ 	// foo.com running on port 80
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	// This example watches a variable based on a file-based blob.Bucket with JSON.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""blob://myvar.json?bucket=file:///mypath&decoder=json"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}","Don't need the `, err` part since you've already handled it.",I think you can use `log.Fatalf` here
+2933,"@@ -222,4 +222,18 @@ TEST_CASE(""negative charge queries. Part of testing changes for github #2604"",
+     CHECK(nWarnings == 1);
+     CHECK(nErrors == 0);
+   }
++}
++
++TEST_CASE(""GithHub #2954: Reaction Smarts with Dative Bonds not parsed"",
++          ""[Reaction, Bug]"") {
++  
++  SECTION(""Rxn Smart Processing with Dative Bond"") {
++    unique_ptr<ChemicalReaction> rxn(
++      RxnSmartsToChemicalReaction(""[O:1].[H+]>>[O:1]->[H+]"")
++    );
++    REQUIRE(rxn);
++    auto k = rxn->getProducts()[0]->getNumAtoms();
++    CHECK(k == 2);
++  }
++
+ }",Please add two additional SECTIONs that show that this also works if the dative bond is in the reactant (reaction SMARTS `[O:1]->[H+]>>[O:1].[H+]`) or in the agents (reaction SMARTS `[O:1][H]>N->[Cu]>[O:1].[H]`),I think this should be `REQUIRE(k == 
+2934,"@@ -54,6 +54,15 @@ func (c *Cluster) newListener(ctx context.Context) (net.Listener, http.Handler,
+ 			MinVersion:   c.config.TLSMinVersion,
+ 			CipherSuites: c.config.TLSCipherSuites,
+ 		},
++		RegenerateCerts: func() bool {
++			const regenerateDynamicListenerFile = ""dynamic-cert-regenerate""
++			dynamicListenerRegenFilePath := filepath.Join(c.config.DataDir, ""tls"", regenerateDynamicListenerFile)
++			if _, err := os.Stat(dynamicListenerRegenFilePath); err == nil {
++				os.Remove(dynamicListenerRegenFilePath)
++				return true
++			}
++			return false
++		},
+ 	})
+ }
+ ",What happens if the certificate rotation fails and we are prematurely removing this file?,nit: `return os.IsNotExist(err)`
+2935,"@@ -97,6 +97,18 @@ func (s *Single) IsRunning() bool {
+ 
+ // Introspect returns a ChooserStatus with a single PeerStatus.
+ func (s *Single) Introspect() introspection.ChooserStatus {
++	if !s.once.IsRunning() {
++		return introspection.ChooserStatus{
++			Name: ""Single"",
++			Peers: []introspection.PeerStatus{
++				{
++					Identifier: s.pid.Identifier(),
++					State: ""uninitialized"",
++				},
++			},
++		}
++	}
++
+ 	peerStatus := s.p.Status()
+ 	peer := introspection.PeerStatus{
+ 		Identifier: s.p.Identifier(),",does this change belong here?,Why do we need this check?
+2936,"@@ -291,6 +291,8 @@ func (w *Workflow) populate() error {
+ 		""DATETIME"":  now.Format(""20060102150405""),
+ 		""TIMESTAMP"": strconv.FormatInt(now.Unix(), 10),
+ 		""USERNAME"":  w.username,
++		""WFDIR"":     w.workflowDir,
++		""CWD"":       os.Getwd(),
+ 	}
+ 
+ 	var replacements []string",This returns an error,I think this should be `w.workflowDir`
+2937,"@@ -131,6 +131,8 @@ type Config struct {
+ 	Ipv6Support    bool `config:""bool;true""`
+ 	IgnoreLooseRPF bool `config:""bool;false""`
+ 
++	// FIXME Add this to libcalico-go
++	IptablesBackend                    string        `config:""oneof(legacy,nft);legacy;local""`
+ 	RouteRefreshInterval               time.Duration `config:""seconds;90""`
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;1""`","If we think we might someday write a native nftables backend, do you think it would make sense to just use generic dataplane configuration? e.g, `dataplane = iptables | ebpf | nftables`, but for now selecting `nftables` uses iptables in nft compat mode?",Why is this needed?
+2938,"@@ -53,7 +53,10 @@ func TestBlockPropsManyNodes(t *testing.T) {
+ 	connect(t, nodes[1], nodes[2])
+ 	connect(t, nodes[2], nodes[3])
+ 
+-	baseTS := minerNode.ChainReader.Head()
++	head := minerNode.ChainReader.GetHead()
++	headTipSetAndState, err := minerNode.ChainReader.GetTipSetAndState(ctx, head)
++	require.NoError(err)
++	baseTS := headTipSetAndState.TipSet
+ 	require.NotNil(t, baseTS)
+ 	proof := testhelpers.MakeRandomPoSTProofForTest()
+ ",Looks like that helper function is general enough that it should reside in testhelpers,You can use `headTipSetAndState.TipSet
+2939,"@@ -456,6 +456,11 @@ func writeDrupal6DdevSettingsFile(settings *DrupalSettings, filePath string) err
+ // WriteDrushrc writes out drushrc.php based on passed-in values.
+ // This works on Drupal 6 and Drupal 7 or with drush8 and older
+ func WriteDrushrc(app *DdevApp, filePath string) error {
++	// Ignore because this is a settings file.
++	if app.DisableSettingsManagement {
++		return nil
++	}
++
+ 	if fileutil.FileExists(filePath) {
+ 		// Check if the file is managed by ddev.
+ 		signatureFound, err := fileutil.FgrepStringInFile(filePath, DdevFileSignature)","This isn't incorrect IMO, but I think it would be better to fix this in drupal7PostStartAction and also in drupal6PostStartAction. It seems to me like those were both somehow neglected on this. Use drupal8PostStartAction as example. Congrats on your first golang PR! Please make sure to test it manually.",Why is this needed?
+2940,"@@ -10,8 +10,10 @@ test_name 'use the provision subcommand' do
+     delete_root_folder_contents
+     on(default, 'beaker init')
+     result = on(default, 'beaker provision --hosts centos6-64')
++    assert_match(/ERROR/, result.raw_output)
++    on(default, 'beaker init --hosts centos6-64')
++    result = on(default, 'beaker provision')
+     assert_match(/Using available host/, result.stdout)
+-
+     subcommand_state = on(default, ""cat #{SubcommandUtil::SUBCOMMAND_STATE}"").stdout
+     subcommand_state = YAML.parse(subcommand_state).to_ruby
+     assert_equal(true, subcommand_state['provisioned'])",I'd like to ensure that the error message at least has some reference to the flag that is not allowed. Something like `/ERROR(.+)--hosts/` would work.,Why did you remove this test?
+2941,"@@ -470,8 +470,8 @@ https://aws.amazon.com/premiumsupport/knowledge-center/ecs-pull-container-api-er
+ 		publicSubnets, err := o.selVPC.PublicSubnets(envInitPublicSubnetsSelectPrompt, """", o.importVPC.ID)
+ 		if err != nil {
+ 			if err == selector.ErrSubnetsNotFound {
+-				log.Warningf(`No existing public subnets were found in VPC %s.
+-If you proceed without public subnets, you will not be able to deploy Load Balanced Web Services in this environment.
++				log.Warningf(`No existing subnets were found in VPC %s.
++If you proceed without specifying public subnets, you will not be able to deploy Load Balanced Web Services in this environment.
+ `, o.importVPC.ID)
+ 			} else {
+ 				return fmt.Errorf(""select public subnets: %w"", err)","Should we say ""specifying two public subnets""?",I don't think we need to chan
+2942,"@@ -32,6 +32,8 @@ func (current *PubSubSource) CheckImmutableFields(ctx context.Context, og apis.I
+ 		return nil
+ 	}
+ 
++	// TODO: revisit this.
++
+ 	// All of the fields are immutable because the controller doesn't understand when it would need
+ 	// to delete and create a new Receive Adapter with updated arguments. We could relax it slightly
+ 	// to allow a nil Sink -> non-nil Sink, but I don't think it is needed yet.",Issue number? When? Why?,Why is this needed?
+2943,"@@ -35,6 +35,7 @@ from ._sapi4 import (
+ 	VOICECHARSET
+ )
+ import config
++import speech
+ import nvwave
+ import weakref
+ ",You should not rely on `PitchCommand` being imported into speech. Please import it from `speech.commands`.,Why do we need this import?
+2944,"@@ -108,7 +108,7 @@ public abstract class BaseTestIceberg {
+     newCatalog.setConf(hadoopConfig);
+     newCatalog.initialize(""nessie"", ImmutableMap.of(""ref"", ref,
+         CatalogProperties.URI, uri,
+-        ""auth_type"", ""NONE"",
++        ""auth-type"", ""NONE"",
+         CatalogProperties.WAREHOUSE_LOCATION, temp.toUri().toString()
+     ));
+     return newCatalog;","Is this a constant used in the Nessie project itself? If so, perhaps you might consider a follow up for adding `NessieCatalogProperties` class at some point, to help make them more clear to users looking to adopt Nessie coming from the Iceberg repo itself  ",Why is this change needed?
+2945,"@@ -146,12 +146,12 @@ func (db *taskQueueDB) CreateTasks(tasks []*persistencespb.AllocatedTaskInfo) (*
+ // GetTasks returns a batch of tasks between the given range
+ func (db *taskQueueDB) GetTasks(minTaskID int64, maxTaskID int64, batchSize int) (*persistence.GetTasksResponse, error) {
+ 	return db.store.GetTasks(&persistence.GetTasksRequest{
+-		NamespaceID:  db.namespaceID.String(),
+-		TaskQueue:    db.taskQueueName,
+-		TaskType:     db.taskType,
+-		BatchSize:    batchSize,
+-		ReadLevel:    minTaskID,  // exclusive
+-		MaxReadLevel: &maxTaskID, // inclusive
++		NamespaceID: db.namespaceID.String(),
++		TaskQueue:   db.taskQueueName,
++		TaskType:    db.taskType,
++		PageSize:    batchSize,
++		MinTaskID:   minTaskID, // exclusive
++		MaxTaskID:   maxTaskID, // inclusive
+ 	})
+ }
+ ","maybe we should rename: MinTaskID -> MinTaskIDExclusive, MaxTaskID -> MaxTaskIDInclusive,",Why do we need to change t
+2946,"@@ -70,7 +70,7 @@ const (
+ 
+ 	NvidiaVisibleDevicesEnvVar = ""NVIDIA_VISIBLE_DEVICES""
+ 	GPUAssociationType         = ""gpu""
+-	NvidiaRuntime              = ""nvidia""
++	NvidiaRuntime              = ""ecs-nvidia""
+ 
+ 	arnResourceSections  = 2
+ 	arnResourceDelimiter = ""/""",You may need to make this configurable if we expect people to be able to use the normal Nvidia runtime on other Linux distributions like Ubuntu or Debian.,Why is this change needed?
+2947,"@@ -177,10 +177,10 @@ func newLeafNodeCfg(remote *RemoteLeafOpts) *leafNodeCfg {
+ 	if len(remote.DenyExports) > 0 || len(remote.DenyImports) > 0 {
+ 		perms := &Permissions{}
+ 		if len(remote.DenyExports) > 0 {
+-			perms.Subscribe = &SubjectPermission{Deny: remote.DenyExports}
++			perms.Publish = &SubjectPermission{Deny: remote.DenyExports}
+ 		}
+ 		if len(remote.DenyImports) > 0 {
+-			perms.Publish = &SubjectPermission{Deny: remote.DenyImports}
++			perms.Subscribe = &SubjectPermission{Deny: remote.DenyImports}
+ 		}
+ 		cfg.perms = perms
+ 	}","Originally the DenyExport was a subscribe permission because it meant that if on this LN connection, if we deny export of ""foo"" it means that it would reject a subscription (hence subscribe permission) on ""foo"" from the other side. Now you are changing to simply not allowing this server to publish on ""foo"". I am not saying this is wrong, but we completely flip the meaning.",I don't think this is corr
+2948,"@@ -159,6 +159,12 @@ dsts_first(void)
+     return TESTANY(DR_DISASM_INTEL | DR_DISASM_ARM, DYNAMO_OPTION(disasm_mask));
+ }
+ 
++static inline bool
++opmask_with_dsts(void)
++{
++    return TESTANY(DR_DISASM_INTEL | DR_DISASM_ATT, DYNAMO_OPTION(disasm_mask));
++}
++
+ static void
+ internal_instr_disassemble(char *buf, size_t bufsz, size_t *sofar INOUT,
+                            dcontext_t *dcontext, instr_t *instr);","> k1 src0 src2 -> dst s/src2/src1/ nit: k1 is actually src0 according to instr_get_src(instr, 0) which makes this a little confusing",`opmask_with_dsts` -> `opmask_with_dsts`
+2949,"@@ -192,7 +192,7 @@ func (kc *KMDController) StartKMD(args KMDStartArgs) (alreadyRunning bool, err e
+ 			return false, errors.New(""bad kmd data dir"")
+ 		}
+ 		if (dataDirStat.Mode() & 0077) != 0 {
+-			logging.Base().Errorf(""%s: kmd data dir exists but is too permissive (%o)"", kc.kmdDataDir, dataDirStat.Mode()&0777)
++			logging.Base().Errorf(""%s: kmd data dir exists but is too permissive (%o), change to (%o)"", kc.kmdDataDir, dataDirStat.Mode()&0777, dataDirStat.Mode()&0077)
+ 			return false, errors.New(""kmd data dir not secure"")
+ 		}
+ 	} else {","I believe that you meant to have the following on the second one, right ? `dataDirStat.Mode()^0077`",Why change this?
+2950,"@@ -386,8 +386,8 @@ func (s *stream) SetDeadline(t time.Time) error {
+ }
+ 
+ // CloseRemote makes the stream receive a ""virtual"" FIN stream frame at a given offset
+-func (s *stream) CloseRemote(offset protocol.ByteCount) {
+-	s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: offset})
++func (s *stream) CloseRemote(offset uint64) {
++	s.AddStreamFrame(&wire.StreamFrame{FinBit: true, Offset: protocol.ByteCount(offset)})
+ }
+ 
+ // Cancel is called by session to indicate that an error occurred","The reason a `ByteCount` is used here, is that the H2 mapping in gQUIC requires this layer violation, which is why `CloseRemote` is not part of the public API. This layer violation will be resolved in IETF QUIC",Why do we need this change?
+2951,"@@ -260,6 +260,17 @@ bool IsDetrimentalSpell(uint16 spell_id)
+ 	return !IsBeneficialSpell(spell_id);
+ }
+ 
++bool IsInvisSpell(uint16 spell_id)
++{
++	if (IsEffectInSpell(spell_id, SE_Invisibility) ||
++		IsEffectInSpell(spell_id, SE_Invisibility2) ||
++		IsEffectInSpell(spell_id, SE_InvisVsUndead) ||
++		IsEffectInSpell(spell_id, SE_InvisVsUndead2) ||
++		IsEffectInSpell(spell_id, SE_InvisVsAnimals))
++		return true;
++	return false;
++}
++
+ bool IsInvulnerabilitySpell(uint16 spell_id)
+ {
+ 	return IsEffectInSpell(spell_id, SE_DivineAura);",I dig the helper function!,why do you need this function?
+2952,"@@ -0,0 +1,2 @@
++// package samples contains sample programs using the pubsub API.
++package samples",Please add the Copyright header.,
+2953,"@@ -37,6 +37,7 @@ import sys
+ import tempfile
+ 
+ import luigi
++from ..target import FileSystemTarget
+ 
+ logger = logging.getLogger('luigi-interface')
+ ",Is this the best way to import `FileSystemTarget`?,W
+2954,"@@ -2751,10 +2751,10 @@ static void
+ replace_thread_id(thread_id_t old, thread_id_t new)
+ {
+ #ifdef HAVE_TLS
+-    thread_id_t new_tid = new;
++    int32_t new_tid = (int32_t) new; /* can't use thread_id_t since it's 64-bits on x64 */
+     ASSERT(is_thread_tls_initialized());
+     DOCHECK(1, {
+-        thread_id_t old_tid;
++        int32_t old_tid; /* can't use thread_id_t since it's 64-bits on x64 */
+         READ_TLS_INT_SLOT_IMM(TLS_THREAD_ID_OFFSET, old_tid);
+         ASSERT(old_tid == old);
+     });","Wait -- os_local_state_t.tid is thread_id_t though, so we need to read a pointer-sized value via READ_TLS_SLOT_IMM, rather than changing these locals to ints. Maybe have a READ_TLS_TIDSZ_SLOT_IMM or sthg.",W
+2955,"@@ -13311,7 +13311,11 @@ public:
+         HRESULT Status;
+ 
+         ICorDebugProcess* pCorDebugProcess;
+-        IfFailRet(g_pRuntime->GetCorDebugInterface(&pCorDebugProcess));
++        if (FAILED(Status = g_pRuntime->GetCorDebugInterface(&pCorDebugProcess)))
++        {
++            ExtOut(""\n\n\n!clrstack -i is unsupported on this target.\nThe ICorDebug interface cannot be constructed.\n"");
++            return Status;
++        }
+ 
+         ExtOut(""\n\n\nDumping managed stack and managed variables using ICorDebug.\n"");
+         ExtOut(""=============================================================================\n"");",Don't use ! in the messages because it isn't used on xplat. There is a SOSPrefix define that can be used (blank on xplat and ! on Windows). Do we really need 3 newlines?,S
+2956,"@@ -52,7 +52,13 @@ def _dagster_home():
+             'DAGSTER_HOME is not set, check is_dagster_home_set before invoking.'
+         )
+ 
+-    return os.path.expanduser(dagster_home_path)
++    dagster_home_path = os.path.expanduser(dagster_home_path)
++
++    if not os.path.isabs(dagster_home_path):
++        raise DagsterInvariantViolationError(
++            'DAGSTER_HOME must be absolute path'
++        )
++    return dagster_home_path
+ 
+ 
+ def _check_run_equality(pipeline_run, candidate_run):",print out what we got here in the error,Why do we need this check?
+2957,"@@ -43,6 +43,9 @@ See the file COPYING for details.
+ 	)); \
+ } while (false)
+ 
++//Stores select query before evaluation
++struct jx *select_expr = NULL;
++
+ static struct jx *jx_check_errors(struct jx *j);
+ 
+ static struct jx *jx_eval_null(struct jx_operator *op, struct jx *left, struct jx *right) {",Does this need to be global?,Why do we need this?
+2958,"@@ -1349,7 +1349,7 @@ public final class TreeMap<K, V> implements SortedMap<K, V>, Serializable {
+ 
+     @Override
+     public Seq<V> values() {
+-        return iterator().map(Tuple2::_2).toStream();
++        return map(Tuple2::_2);
+     }
+ 
+     // -- Object","Yep, could be simplified. Now looks like other *Map.values() impls",Why is this change needed?
+2959,"@@ -183,6 +183,15 @@ class ApiContext extends \Imbo\BehatApiExtension\Context\ApiContext
+         $this->assertJsonObjectContainsKeys('configuration,columns,collection,info');
+     }
+ 
++    /**
++     * @Then /^print last api response$/
++     */
++    public function printLastApiResponse(): void
++    {
++        $this->requireResponse();
++        echo $this->response->getBody();
++    }
++
+     /**
+      * {@inheritDoc}
+      */",This method will be for debug?,Shouldn't this be `assertJ
+2960,"@@ -9,9 +9,16 @@ import (
+ 	""errors""
+ )
+ 
++// ErrInvalidPassword is returned when the password for decrypting content where
++// private key is stored is not valid.
+ var ErrInvalidPassword = errors.New(""invalid password"")
+ 
++// Service for managing keystore private keys.
+ type Service interface {
++	// Key returns private key for specified name that was encrypted with
++	// provided password. If the private key does not exists it creates new one
++	// with name and password, and returns with created set to true.
+ 	Key(name, password string) (k *ecdsa.PrivateKey, created bool, err error)
++	// Exists returns true if the key with specified name exists.
+ 	Exists(name string) (bool, error)
+ }","// Key returns the private key for a specified name that was encrypted with the // provided password. If the private key does not exists it creates a new one // with a name and the password, and returns with `created` set to true.","I don't think we need to return an error here. If the private key does not exist it creates a new one with name and password, and returns with created set to true."
+2961,"@@ -45,6 +45,19 @@ class DiagramEntity(Figure):
+         self.node = node
+ 
+ 
++class PackageEntity(DiagramEntity):
++    """"""A diagram object representing a package""""""
++
++
++class ClassEntity(DiagramEntity):
++    """"""A diagram object representing a class""""""
++
++    def __init__(self, title, node):
++        super().__init__(title=title, node=node)
++        self.attrs = None
++        self.methods = None
++
++
+ class ClassDiagram(Figure, FilterMixIn):
+     """"""main class diagram handling""""""
+ ","Adding the type hints revealed that it was necessary to distinguish between a ``PackageEntity`` and a ``ClassEntity``, because the ``ClassEntity`` has additional attributes that were dynamically added in the previous code, which confused ``mypy``.",Why is this needed?
+2962,"@@ -43,7 +43,8 @@ class _MissingPandasLikeDataFrame(object):
+     blocks = unsupported_property('blocks', deprecated=True)
+ 
+     # Functions
+-    add = unsupported_function('add')
++    add_prefix = unsupported_function('add_prefix')
++    add_suffix = unsupported_function('add_suffix')
+     agg = unsupported_function('agg')
+     aggregate = unsupported_function('aggregate')
+     align = unsupported_function('align')",These two functions should be available now.,I don't think we need to deprecate this.
+2963,"@@ -651,10 +651,17 @@ type localOpenFile struct {
+ 	o    *Object           // object that is open
+ 	in   io.ReadCloser     // handle we are wrapping
+ 	hash *hash.MultiHasher // currently accumulating hashes
++	fd   *os.File          // file object reference
+ }
+ 
+ // Read bytes from the object - see io.Reader
+ func (file *localOpenFile) Read(p []byte) (n int, err error) {
++	// Check if file has the same size and modTime
++	fi, err := file.fd.Stat()
++	if file.o.size != fi.Size() || file.o.modTime != fi.ModTime() {
++		return 0, errors.New(""can't copy - source file is being updated"")
++	}
++
+ 	n, err = file.in.Read(p)
+ 	if n > 0 {
+ 		// Hash routines never return an error",`fi` is what the result of Stat is called elsewhere in this file not `finfo`,I think this should be `os.FileMode(0644)`
+2964,"@@ -62,15 +62,6 @@ RSpec.describe Blacklight::OpenStructWithHashAccess do
+     end
+   end
+ 
+-  describe ""#replace"" do
+-    subject { described_class.new a: 1 }
+-
+-    it ""can use #replace to reorder the hash"" do
+-      subject.replace b: 1
+-      expect(subject.b).to eq 1
+-    end
+-  end
+-
+   describe ""#sort_by"" do
+     subject { described_class.new c: 3, b: 1, a: 2 }
+ ",I'm confused; are we just dropping these methods without deprecation?,Why was this test removed?
+2965,"@@ -16,12 +16,18 @@ void AddEdgesProcessor::process(const cpp2::AddEdgesRequest& req) {
+     auto spaceId = req.get_space_id();
+     auto version =
+         std::numeric_limits<int64_t>::max() - time::WallClock::fastNowInMicroSec();
++    // Switch version to big-endian, make sure the key is in ordered.
++    version = folly::Endian::big(version);
++
+     callingNum_ = req.parts.size();
+     CHECK_NOTNULL(kvstore_);
+     std::for_each(req.parts.begin(), req.parts.end(), [&](auto& partEdges){
+         auto partId = partEdges.first;
+         std::vector<kvstore::KV> data;
+         std::for_each(partEdges.second.begin(), partEdges.second.end(), [&](auto& edge){
++            VLOG(4) << ""PartitionID: "" << partId << "", VertexID: "" << edge.key.src
++                    << "", EdgeType: "" << edge.key.edge_type << "", EdgeRanking: "" << edge.key.ranking
++                    << "", VertexID: "" << edge.key.dst << "", EdgeVersion: "" << version;
+             auto key = NebulaKeyUtils::edgeKey(partId, edge.key.src, edge.key.edge_type,
+                                                edge.key.ranking, edge.key.dst, version);
+             data.emplace_back(std::move(key), std::move(edge.get_props()));",can we use PC's time to version in Distributed Systems?,Why not use `std::string`?
+2966,"@@ -100,9 +100,11 @@
+         <% cart.comments.each do |c| %>
+           <div class='comment-item'>
+             <div class='row'>
+-              <p class='comment-sender col-sm-6 col-xs-12'>
+-                <strong>requester@test.com</strong>
+-              </p>
++              <% unless c.user.nil? %>
++                <p class='comment-sender col-sm-6 col-xs-12'>
++                  <strong><%= c.user_full_name %></strong>
++                </p>
++              <% end %>
+               <p class='comment-date col-sm-6 col-xs-12'>
+                 <%= date_with_tooltip(c.created_at) %>
+               </p>","is this ""unless"" actually needed?",I think this should be `c.
+2967,"@@ -94,6 +94,10 @@ final class Stemmer {
+     }
+ 
+     List<CharsRef> list = new ArrayList<>();
++    if (length == 0) {
++      return list;
++    }
++
+     RootProcessor processor =
+         (stem, formID, stemException) -> {
+           list.add(newStem(stem, stemException));","We don't accept empty words for lookup anymore, again",Why is this needed?
+2968,"@@ -0,0 +1,18 @@
++#!/usr/bin/env node
++
++const fs = require('fs')
++const yarnOut = fs.readFileSync(0, {encoding: 'utf8'})
++
++const [installTimeString] = /(?<=^Done in )\d+\.\d+(?=s\.$)/m.exec(yarnOut)
++const installTime = Number(installTimeString)
++
++console.log(`Install time: ${installTime}s`)
++
++if (installTime < 30) {
++  console.log(""We're below 30 secs. That's awesome!"")
++} else if (installTime < 50) {
++  console.log(""We're below 50 secs. That's fine!"")
++} else {
++  console.log(""We're above 50 secs. That's not great!"")
++  process.exit(1)
++}",We'll have to account for CI installations being faster than local ones. Do y'all think we should leave it at < 30 green / < 50 orange | >= 50 red or lower our thresholds?,Can we use `const` here?
+2969,"@@ -101,6 +101,7 @@ class Command(object):
+     EXECUTE_ASYNC_SCRIPT = ""executeAsyncScript""
+     SET_SCRIPT_TIMEOUT = ""setScriptTimeout""
+     SET_TIMEOUTS = ""setTimeouts""
++    W3C_MINIMIZE_WINDOW = ""w3cMinimizeWindow""
+     MAXIMIZE_WINDOW = ""windowMaximize""
+     W3C_MAXIMIZE_WINDOW = ""w3cMaximizeWindow""
+     GET_LOG = ""getLog""",No need for this to be `W3C_` since there is no JWP equivalent,Why do we need this?
+2970,"@@ -1,5 +1,12 @@
+ module RSpec
+   module Core
++    if defined?(::Random)
++      RandomNumberGenerator = ::Random
++    else
++      require 'rspec/core/backport_random'
++      RandomNumberGenerator = RSpec::Core::Backports::Random
++    end
++
+     # @private
+     module Ordering
+       # @private","As far as I can tell, there's nothing that creates an instance of `Random` or that calls `rand` or `seed`. Am I missing it? If not, let's remove the `Random` class since we don't really need it and we can move the definitions of `shuffle` into `RSpec::Core::Ordering`. One less type :).",Why do we need this?
+2971,"@@ -480,3 +480,13 @@ func (s *Server) NumSubscriptions() uint32 {
+ 	stats := s.sl.Stats()
+ 	return stats.NumSubs
+ }
++
++// Addr will return the net.Addr object for the current listener.
++func (s *Server) Addr() net.Addr {
++	s.mu.Lock()
++	defer s.mu.Unlock()
++	if s.listener == nil {
++		return nil
++	}
++	return s.listener.Addr()
++}",Is this ever actually used?,Why do we need this lock
+2972,"@@ -158,7 +158,7 @@ func (w *Waiter) receiptFromTipSet(ctx context.Context, msgCid cid.Cid, ts conse
+ 	if err != nil {
+ 		return nil, err
+ 	}
+-	res, err := consensus.ProcessTipSet(ctx, ts, st, vm.NewStorageMap(w.bs))
++	res, err := consensus.NewDefaultProcessor().ProcessTipSet(ctx, st, vm.NewStorageMap(w.bs), ts)
+ 	if err != nil {
+ 		return nil, err
+ 	}","this section of the codebase should be noted as a candidate for caching, and as a place where multiple tipsets is making things extra tricky",why do we need a default processor here?
+2973,"@@ -1749,6 +1749,10 @@ translate_from_synchall_to_dispatch(thread_record_t *tr, thread_synch_state_t sy
+                 arch_mcontext_reset_stolen_reg(dcontext, mc);
+             }
+         });
++        IF_AARCHXX({
++            set_stolen_reg_val(mc, (reg_t)os_get_dr_tls_base(dcontext));
++            IF_ARM(ASSERT_NOT_TESTED());
++        });
+         /* We send all threads, regardless of whether was in DR or not, to
+          * re-interp from translated cxt, to avoid having to handle stale
+          * local state problems if we simply resumed.",Do we need to save the existing value of the stolen reg somehow?,Why is this assert not needed?
+2974,"@@ -94,7 +94,8 @@ class AdminDirectoryClient(_base_client.BaseClient):
+             api_errors.ApiExecutionError
+         """"""
+         members_stub = self.service.members()
+-        request = members_stub.list(groupKey=group_key)
++        request = members_stub.list(groupKey=group_key,
++                                    maxResults=500)
+         results_by_member = []
+ 
+         # TODO: Investigate yielding results to handle large group lists.",maxResults should come from FLAGS once #244 is submitted.,Why is this a 500?
+2975,"@@ -12,6 +12,8 @@ using Datadog.Trace.TestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+ 
++#if NETCOREAPP
++
+ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+ {
+     [CollectionDefinition(nameof(HttpMessageHandlerTests), DisableParallelization = true)]",is this wanted?,Why is this needed?
+2976,"@@ -268,6 +268,14 @@ def get_docker_executable():
+     return distutils.spawn.find_executable('docker')
+ 
+ 
++def get_linode_executable():
++    try:
++        pytest.importorskip('linode')
++        return True
++    except Exception:
++        return False
++
++
+ def get_lxc_executable():
+     return distutils.spawn.find_executable('lxc-start')
+ ",What exception is actually happening here? AFAIK `pytest.importorskip` with just return `None` if there's nothing to import. Which means that this check'd always return `True`. `pytest.importorskip` is specifically designed to trigger skipping the current test anyway so I don't know why you would wrap it like this.,Why do we need this?
+2977,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+ 
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?,Why is this needed?
+2978,"@@ -21,6 +21,7 @@ program
+   .option('--target_arch <target_arch>', 'target architecture')
+   .option('--target_apk_base <target_apk_base>', 'target Android OS apk (classic, modern, mono)')
+   .option('--submodule_sync', 'run submodule sync')
++  .option('--ignore_chromium', 'do not update chromium')
+   .option('--init', 'initialize all dependencies')
+   .option('--all', 'This flag is deprecated and no longer has any effect')
+   .option('--force', 'force reset all projects to origin/ref')","I'm not sure about adding more flags here when we're trying to simplify things, I thought we were going to check for patches changes to decide if we needed to update or not?",I think this should 
+2979,"@@ -57,13 +57,15 @@ var (
+ 		ta.Keyinfo[""alfa""].PriKey, 3, big.NewInt(10), []byte{}, testutil.TestGasLimit,
+ 		big.NewInt(testutil.TestGasPriceInt64))
+ 
+-	testTransferPb = testTransfer.Proto()
++	testTransferHash = testTransfer.Hash()
++	testTransferPb   = testTransfer.Proto()
+ 
+ 	testExecution, _ = testutil.SignedExecution(ta.Addrinfo[""bravo""].String(),
+ 		ta.Keyinfo[""bravo""].PriKey, 1, big.NewInt(0), testutil.TestGasLimit,
+ 		big.NewInt(testutil.TestGasPriceInt64), []byte{})
+ 
+-	testExecutionPb = testExecution.Proto()
++	testExecutionHash = testExecution.Hash()
++	testExecutionPb   = testExecution.Proto()
+ 
+ 	testTransfer1, _ = testutil.SignedTransfer(ta.Addrinfo[""charlie""].String(), ta.Keyinfo[""producer""].PriKey, 1,
+ 		big.NewInt(10), []byte{}, testutil.TestGasLimit, big.NewInt(testutil.TestGasPriceInt64))",`testExecutionPb` is a global variable (from `gochecknoglobals`),Why is this needed?
+2980,"@@ -127,17 +127,6 @@ class ImageProvider extends FileProvider
+         return array_merge($params, $options);
+     }
+ 
+-    /**
+-     * {@inheritdoc}
+-     */
+-    public function getReferenceImage(MediaInterface $media)
+-    {
+-        return sprintf('%s/%s',
+-            $this->generatePath($media),
+-            $media->getProviderReference()
+-        );
+-    }
+-
+     /**
+      * {@inheritdoc}
+      */","~Method is public and removing it would be a BC Break, you can deprecate it if you want.~",Why was this removed?
+2981,"@@ -113,7 +113,7 @@ func (i *interpreter) interpretStatements(s *scope, statements []*Statement) (re
+ 			} else {
+ 				err = fmt.Errorf(""%s"", r)
+ 			}
+-			log.Debug(""%s"", debug.Stack())
++			log.Debug(""%v:\n %s"", err,  debug.Stack())
+ 		}
+ 	}()
+ 	return s.interpretStatements(statements), nil // Would have panicked if there was an error",this got me a little confused when reading `build.log`. The err is printed with a log.Error later on but that ends up after the stack trace.,I think this should b
+2982,"@@ -157,6 +157,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --include-prefix       Prefix this path to any generated include statements.\n""
+     ""    PATH\n""
+     ""  --keep-prefix          Keep original prefix of schema include statement.\n""
++    ""  --keep-namespaces      Keep full namespace paths of imported types in Rust.\n""
+     ""  --no-fb-import         Don't include flatbuffers import statement for TypeScript.\n""
+     ""  --no-ts-reexport       Don't re-export imported dependencies for TypeScript.\n""
+     ""  --short-names          Use short function names for JS and TypeScript.\n""",Can we make these more explicitly for Rust only? It seems like JS and Go use flags with their name in them.,Should this be `--kee
+2983,"@@ -88,6 +88,9 @@ type URLOpener struct{}
+ //  - file://localhost/c:/foo/bar
+ //    -> Also passes ""c:\foo\bar"".
+ func (*URLOpener) OpenBucketURL(ctx context.Context, u *url.URL) (*blob.Bucket, error) {
++	for param := range u.Query() {
++		return nil, fmt.Errorf(""open bucket %q: invalid query parameter %q"", u, param)
++	}
+ 	return OpenBucket(mungeURLPath(u.Path, os.PathSeparator), nil)
+ }
+ ",Should unsupported query parameters just be ignored? I think that's more common than error out.,I think this should b
+2984,"@@ -52,9 +52,9 @@ def namespace(namespace=None):
+     Call to set namespace of tasks declared after the call.
+ 
+     If called without arguments or with ``None`` as the namespace, the namespace
+-    is reset, which is recommended to do at the end of any file where the
+-    namespace is set to avoid unintentionally setting namespace on tasks outside
+-    of the scope of the current file.
++    is reset to :py:attr:`Register._UNSET_NAMESPACE`., which is recommended to do
++    at the end of any file where the namespace is set to avoid unintentionally
++    setting namespace on tasks outside of the scope of the current file.
+ 
+     The namespace of a Task can also be changed by specifying the property
+     ``task_namespace``. This solution has the advantage that the namespace","Actually can we avoid mentioning `Register._UNSET_NAMESPACE`. I thought of it as an implementation detail of the simpler concept of ""being unset"". Perhaps the docs become more natural if we remove the ""If called without arguments or with ..."" part and just say ""you have to call this function without arguments at the end of any file it has been used. That is to ensure blah blah"". Something like that. Just a suggestion.",I don't think this is the right place to put this. I think it should be in the `register.py` file.
+2985,"@@ -426,8 +426,16 @@ class WinWordCollectionQuicknavIterator(object):
+ 			if self.direction==""previous"":
+ 				index=itemCount-(index-1)
+ 			collectionItem=items[index]
+-			item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
+-			itemRange=item.rangeObj
++			try:
++				item=self.quickNavItemClass(self.itemType,self.document,collectionItem)
++				itemRange=item.rangeObj
++			except:
++				values = (self.itemType, self.direction, itemCount, index)
++				message = (""Error iterating over item with ""+
++				(""type: %s, iteration direction: %s, total item count: %s, item at index: %s"" % values )+
++				""\nThis could be caused by an issue with some element within or a corruption of the word document."")
++				log.debugWarning(message ,exc_info=True)
++				continue
+ 			# Skip over the item we're already on.
+ 			if not self.includeCurrent and isFirst and ((self.direction==""next"" and itemRange.start<=self.rangeObj.start) or (self.direction==""previous"" and itemRange.end>self.rangeObj.end)):
+ 				continue","I assume it raises COMError? If so perhaps best to just catch that specifically, so as to not hide other more critical errors.",This should be `log.exception`
+2986,"@@ -328,6 +328,7 @@ var directives = []string{
+ 	""git"",    // github.com/abiosoft/caddy-git
+ 
+ 	// directives that add middleware to the stack
++	""minify"", // github.com/hacdias/caddy-minify
+ 	""log"",
+ 	""gzip"",
+ 	""errors"",","Since minify can generate errors, it should at least go after the errors middleware. And you definitely don't want to be minifying after the gzip writer has closed.","""minify"","
+2987,"@@ -31,7 +31,8 @@ type Tracer struct {
+ 	// Version is the instrumentation version.
+ 	Version string
+ 
+-	config *config
++	config   *config
++	provider *TracerProvider
+ }
+ 
+ // Start creates a span. If t is configured with a SpanRecorder its OnStart",nit: we could remove the `config` field as it is a duplicate of the `provider.config` field.,Why is this a pointer?
+2988,"@@ -112,7 +112,8 @@ class ForsetiServerInstaller(ForsetiInstaller):
+             # Create firewall rule to open only port tcp:50051
+             # within the internal network (ip-ranges - 10.128.0.0/9)
+             gcloud.create_firewall_rule(
+-                self.format_firewall_rule_name('forseti-server-allow-grpc'),
++                self.format_firewall_rule_name(
++                    'forseti-server-allow-grpc-internal'),
+                 [self.gcp_service_account],
+                 constants.FirewallRuleAction.ALLOW,
+                 ['tcp:50051'],",Nit: from the Internet.,Why is this needed?
+2989,"@@ -7,11 +7,15 @@
+ package hdwallet
+ 
+ import (
++	""bytes""
+ 	""fmt""
+ 	""io/ioutil""
+ 
++	ecrypt ""github.com/ethereum/go-ethereum/crypto""
++	""github.com/iotexproject/go-pkgs/crypto""
++	""github.com/iotexproject/iotex-address/address""
++	hdwallet ""github.com/miguelmota/go-ethereum-hdwallet""
+ 	""github.com/spf13/cobra""
+-
+ 	""github.com/tyler-smith/go-bip39""
+ 
+ 	""github.com/iotexproject/iotex-core/ioctl/config""","this is internal package, move to bottom and run 'make fmt'",nit: remove empty l
+2990,"@@ -0,0 +1,14 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System.Threading;
++
++namespace Microsoft.AspNetCore.Connections.Features
++{
++    public interface IConnectionLifetimeNotificationFeature
++    {
++        CancellationToken ConnectionClosing { get; set; }
++
++        void Close();
++    }
++}",Why is this better than ApplicationStopping?,Why do we need this
+2991,"@@ -70,8 +70,8 @@ type ChallengeSpec struct {
+ 	// +optional
+ 	Wildcard bool `json:""wildcard""`
+ 
+-	// Type is the type of ACME challenge this resource represents, e.g. ""dns01""
+-	// or ""http01"".
++	// Type is the type of ACME challenge this resource represents.
++	// One of ""http-01"" or ""dns-01"".
+ 	Type ACMEChallengeType `json:""type""`
+ 
+ 	// Token is the ACME challenge token for this challenge.",Maybe worth expanding that these 2 are supported by cert-manager but other values exist,I don't think we ne
+2992,"@@ -169,7 +169,7 @@ class MediaExtension extends \Twig_Extension
+ 
+         $options = array_merge($defaultOptions, $options);
+ 
+-        $options['src'] = $provider->generatePublicUrl($media, $format);
++        $options = $provider->getHelperProperties($media, $format, $options);
+ 
+         return $this->render($provider->getTemplate('helper_thumbnail'), array(
+             'media'    => $media,","Why was this merged? It should have raised some questions IMO @core23 @OskarStark . It's already in 3 releases now, so we can't revert it can we? How can we fix this? Please have a look at #1065",Why did you remove this line?
+2993,"@@ -125,6 +125,10 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+         params.add(""--rpc-http-authentication-credentials-file"");
+         params.add(node.jsonRpcConfiguration().getAuthenticationCredentialsFile());
+       }
++      if (node.jsonRpcConfiguration().getAuthenticationPublicKeyFile() != null) {
++        params.add(""--rpc-http-authentication-public-key-file"");
++        params.add(node.jsonRpcConfiguration().getAuthenticationPublicKeyFile().getAbsolutePath());
++      }
+     }
+ 
+     if (node.wsRpcEnabled()) {","What if `node.jsonRpcConfiguration().getAuthenticationPublicKeyFile()` is empty string, would that cause a problem here?",Why do we need this?
+2994,"@@ -57,6 +57,12 @@ type CertificateSpec struct {
+ 	// Organization is the organization to be used on the Certificate
+ 	Organization []string `json:""organization,omitempty""`
+ 
++	// Certificate default Duration
++	Duration metav1.Duration `json:""duration,omitempty""`
++
++	// Certificate renew before expiration duration
++	RenewBefore metav1.Duration `json:""renewBefore,omitempty""`
++
+ 	// DNSNames is a list of subject alt names to be used on the Certificate
+ 	DNSNames []string `json:""dnsNames,omitempty""`
+ ","The `omitempty` struct tag does not do anything for non-pointer structs. I think we may need to consider making both of these fields pointers, so that they are excluded from output when not set, and also to make it easier to compare to the zero value. That said, I'm happy to merge this now and open an issue to verify the behaviour is as we want ahead of cutting v0.6.0.",Why do we need this?
+2995,"@@ -120,7 +120,7 @@ public interface GenericToken<T extends GenericToken<T>> {
+                     + "") must come before "" + to + "" (at "" + to.getStartInDocument() + "")""
+             );
+         }
+-        return IteratorUtil.generate(from, t -> t == to ? null : t.getNext());
++        return IteratorUtil.generate(from, t -> t.equals(to) ? null : t.getNext());
+     }
+ 
+ ","I think this is should absolutely be `==`, as the interface cannot control the implementation of equals (and it's part of the contract of the enclosing function). Can we add this interface to the exceptions of the rule?",Why is this change needed?
+2996,"@@ -22,11 +22,12 @@ type ns struct {
+ 	ipt iptables.Interface // interface to iptables
+ 	ips ipset.Interface    // interface to ipset
+ 
+-	name      string                     // k8s Namespace name
+-	nodeName  string                     // my node name
+-	namespace *coreapi.Namespace         // k8s Namespace object
+-	pods      map[types.UID]*coreapi.Pod // k8s Pod objects by UID
+-	policies  map[types.UID]interface{}  // k8s NetworkPolicy objects by UID
++	name            string                     // k8s Namespace name
++	nodeName        string                     // my node name
++	namespaceUID    types.UID                  // k8s Namespace UID
++	namespaceLabels map[string]string          // k8s Namespace labels
++	pods            map[types.UID]*coreapi.Pod // k8s Pod objects by UID
++	policies        map[types.UID]interface{}  // k8s NetworkPolicy objects by UID
+ 
+ 	uid     types.UID     // surrogate UID to own allPods selector
+ 	allPods *selectorSpec // hash:ip ipset of all pod IPs in this namespace","It looks like the UID is the only other thing that we use from `namespace`, so I suggest to copy that out and lose `namespace`, so we don't have to worry about setting it to nil.",Why is this a pointer?
+2997,"@@ -17,6 +17,7 @@ const (
+ 	GithubV1ProviderName   = ""GitHubV1""
+ 	CodeCommitProviderName = ""CodeCommit""
+ 	BitbucketProviderName  = ""Bitbucket""
++	DefaultImage           = ""aws/codebuild/amazonlinux2-x86_64-standard:3.0""
+ 
+ 	pipelineManifestPath = ""cicd/pipeline.yml""
+ )",Can we define this constant in the`deploy` pkg instead? this would allow us to keep it private,I think we can remove 
+2998,"@@ -251,7 +251,7 @@ def reporter():
+ @pytest.fixture
+ def init_linter(linter: PyLinter) -> PyLinter:
+     linter.open()
+-    linter.set_current_module(""toto"")
++    linter.set_current_module(""toto"", ""mydir/toto"")
+     linter.file_state = FileState(""toto"")
+     return linter
+ ","I don't like this fixture name, should be a noun like `initialized_linter` ? But it's outside of the scope of this MR.",I think this should be
+2999,"@@ -154,7 +154,9 @@ public class ExportService {
+             if (releasedVersion == null) {
+                 throw new ExportException(""No released version for dataset "" + dataset.getGlobalId().toString());
+             }
+-            final JsonObjectBuilder datasetAsJsonBuilder = JsonPrinter.jsonAsDatasetDto(releasedVersion);
++            // We pass settingsService into the JsonPrinter constructor to check the :ExcludeEmailFromExport setting.
++            JsonPrinter jsonPrinter = new JsonPrinter(settingsService);
++            final JsonObjectBuilder datasetAsJsonBuilder = jsonPrinter.jsonAsDatasetDto(releasedVersion);
+             JsonObject datasetAsJson = datasetAsJsonBuilder.build();
+ 
+             Iterator<Exporter> exporters = loader.iterator();",Could we keep this as a static reference (JsonPrinter.jsonAsDatasetDto(releasedVersion); and perhaps change the constructor line to just be a static set method and use that here instead? (I suspect it was the warning that 'static methods should be accessed in a static manner' from my IDE that caused me to make this change in the first place...) (I can make a PR to your branch if you want.),Why do we need to pass
+3000,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those, 
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?,I don't think you need to change this line.
+3001,"@@ -75,6 +75,14 @@ type diskBlockCacheSetter interface {
+ 	MakeDiskBlockCacheIfNotExists() error
+ }
+ 
++type diskBlockCacheFractionSetter interface {
++	SetDiskBlockCacheFraction(float64)
++}
++
++type syncBlockCacheFractionSetter interface {
++	SetSyncBlockCacheFraction(float64)
++}
++
+ type clockGetter interface {
+ 	Clock() Clock
+ }",This should go in `ConfigLocal` (and then re-generate the mocks).,Why do we need this interface?
+3002,"@@ -51,10 +51,10 @@ class releaseTestCase(SparkTestCase):
+             if entry['release_name'] != '':
+                 expected[entry['user_name']].append({
+                     'release_name': entry['release_name'],
+-                    'release_msid': entry['release_msid'],
+-                    'release_mbid': entry['release_mbid'],
++                    'release_msid': entry['release_msid'] or None,
++                    'release_mbid': entry['release_mbid'] or None,
+                     'artist_name': entry['artist_name'],
+-                    'artist_msid': entry['artist_msid'],
++                    'artist_msid': entry['artist_msid'] or None,
+                     'artist_mbids': entry['artist_mbids'],
+                     'listen_count': entry['count']
+                 })",Nitty but entry.get for the same thing,I don't think this is the right way to do t
+3003,"@@ -10,11 +10,12 @@ import (
+ 	""github.com/opencontainers/runc/libcontainer/logs""
+ 	_ ""github.com/opencontainers/runc/libcontainer/nsenter""
+ 	""github.com/sirupsen/logrus""
+-	""github.com/urfave/cli""
+ )
+ 
+ func init() {
+ 	if len(os.Args) > 1 && os.Args[1] == ""init"" {
++		// This is the golang entry point for runc init, executed
++		// before main() but after libcontainer/nsenter's nsexec().
+ 		runtime.GOMAXPROCS(1)
+ 		runtime.LockOSThread()
+ ",Might not hurt to mention the function never returns (since this all ends in `execve`) so `main` never actually runs.,I think this should be `runtime.GOMAXPROCS(
+3004,"@@ -100,6 +100,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+                         ""ThreadCount must be positive."");
+                 }
+ 
++                if (!Constants.ECONNRESET.HasValue)
++                {
++                    _logger.LogWarning(""Unable to determine ECONNRESET value on this platform."");
++                }
++
+                 if (!Constants.EADDRINUSE.HasValue)
+                 {
+                     _logger.LogWarning(""Unable to determine EADDRINUSE value on this platform."");",nit: add new line after this block,Why is this a warning?
+3005,"@@ -1111,10 +1111,10 @@ Blockly.Css.CONTENT = [
+   '}',
+ 
+   '.scratchCategoryMenu {',
+-    'width: 60px;',
++    'width: 3.25rem;',
+     'background: $colour_toolbox;',
+     'color: $colour_toolboxText;',
+-    'font-size: .7em;',
++    'font-size: .7rem;',
+     'user-select: none;',
+     '-webkit-user-select: none;',
+     '-moz-user-select: none;',","I believe there is some javascript that also uses this 60px number for calculations. I think I'd rather keep the number in px instead of rem to make that correspondence easier to see. If 3.25rem != 60px, can you also change the other place where `60` is used to in the JS?",Why did you change thi
+3006,"@@ -20,10 +20,11 @@ import urllib2
+ 
+ import jinja2
+ 
+-from retrying import retry
+ import sendgrid
+ from sendgrid.helpers import mail
+ 
++from retrying import retry
++
+ from google.cloud.security.common.util import errors as util_errors
+ from google.cloud.security.common.util import log_util
+ from google.cloud.security.common.util import retryable_exceptions",retrying is an installed 3rd party library just like jinja and sendgrid; perhaps try grouping all of them together?,Why is this change nee
+3007,"@@ -133,12 +133,12 @@ public interface List<T> extends Seq<T>, Stack<T> {
+             @SuppressWarnings(""unchecked"")
+             final List<T> list = (List<T>) elements;
+             return list;
+-        } else if (elements instanceof ArrayList) {
++        } else if (elements instanceof ArrayList || elements instanceof Vector) {
+             @SuppressWarnings(""unchecked"")
+-            final ArrayList<T> arrayList = (ArrayList<T>) elements;
++            final java.util.List<T> indexedList = (java.util.List<T>) elements;
+             List<T> result = Nil.instance();
+-            for (int i = arrayList.size() - 1; i >= 0; i--) {
+-                final T element = arrayList.get(i);
++            for (int i = indexedList.size() - 1; i >= 0; i--) {
++                final T element = indexedList.get(i);
+                 result = result.prepend(element);
+             }
+             return result;",you could always use List.listIterator with previous() and hasPrevious() to traverse all kinds of j.u.List backwards. No need for special cases for ArrayList and Vector.,Shouldn't this be `Ind
+3008,"@@ -355,10 +355,17 @@ public class EditImageActivity extends EditBaseActivity implements View.OnClickL
+ 
+     private void addToUndoList() {
+         try{
++            TODO:// implement a more efficient way, like storing only the difference of bitmaps or
++            // steps followed to edit
++
+             bitmapsForUndo.add(mainBitmap.copy(mainBitmap.getConfig(),true));
+         }catch (OutOfMemoryError error){
+-            //Snackbar.make(getWindow().getDecorView().getRootView(),""Out of Memory. steps = "" + bitmapsForUndo.size(),Snackbar.LENGTH_LONG).show();
+-
++            /**
++             * When outOfMemory exception throws then to make space, remove the last edited step
++             * from list and added the new operation in the end.
++             */
++            bitmapsForUndo.remove(0);
++            bitmapsForUndo.add(mainBitmap.copy(mainBitmap.getConfig(),true));
+         }
+     }
+ ","remove the bitmap of index 1 from the list not the 0th one. because when we keep on undoing, it would be better if we end up with the original image rather than some randomly edited image. I am not sure whether only just removing bitmap from the list would clear memory. I think you should call bitmap.recycle before removing that bitmap from the list.","I don't think this is the right way to do this. If you have an out of memory exception, the undo list will be empty."
+3009,"@@ -1,4 +1,4 @@
+-//  Copyright 2019 Google Inc. All Rights Reserved.
++//  Copyright 2020 Google Inc. All Rights Reserved.
+ //
+ //  Licensed under the Apache License, Version 2.0 (the ""License"");
+ //  you may not use this file except in compliance with the License.",this is a existing file so let's keep 2019,This should be 2019-2020
+3010,"@@ -42,7 +42,7 @@ public class RemoteNetworkConnection implements NetworkConnection {
+   @Override
+   public ConnectionType setNetworkConnection(
+       ConnectionType type) {
+-    Map<String, ConnectionType> mode = ImmutableMap.of(""type"", type);
++    Map<String, Integer> mode = ImmutableMap.of(""type"", type.getBitMask());
+     return new ConnectionType(((Number) executeMethod.execute(DriverCommand.SET_NETWORK_CONNECTION,
+                                                             ImmutableMap
+                                                                 .of(""parameters"", mode)))",can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice),Why do we need this change?
+3011,"@@ -257,7 +257,7 @@ namespace Nethermind.AuRa.Test.Transactions
+                 TransactionPermissionContractVersions =
+                     new LruCache<Keccak, UInt256>(PermissionBasedTxFilter.Cache.MaxCacheSize, nameof(TransactionPermissionContract));
+ 
+-                var trieStore = new ReadOnlyTrieStore(new TrieStore(DbProvider.StateDb, LimboLogs.Instance));
++                var trieStore = new TrieStore(DbProvider.StateDb, LimboLogs.Instance).AsReadOnly(DbProvider.StateDb);
+                 IReadOnlyTxProcessorSource txProcessorSource = new ReadOnlyTxProcessingEnv(
+                     DbProvider,
+                     trieStore,",AsReadOnly() would be better here,Why do we need this change?
+3012,"@@ -427,9 +427,12 @@ class Collection {
+      * @param {function(collection, changes)} callback - A function to be called when changes occur.
+      *   The callback function is called with two arguments:
+      *   - `collection`: the collection instance that changed,
+-     *   - `changes`: a dictionary with keys `insertions`, `modifications` and `deletions`,
+-     *      each containing a list of indices that were inserted, updated or deleted respectively. If
+-     *      partial sync is enabled, an additional key `partial_sync` is added.
++     *   - `changes`: a dictionary with keys `insertions`, `newModifications`, `oldModifications`
++     *      and `deletions`, each containing a list of indices in the collection that were
++     *      inserted, updated or deleted respectively. `deletions` and `oldModifications` are
++     *      indices into the collection before the change happened, while `insertions` and
++     *      `newModifications` are indices into the new version of the collection. If partial sync
++     *      is enabled, an additional key `partial_sync` is added.
+      *   - `changes.partial_sync`: `error` indicates if an error has occurred, `old_state` is the previous
+      *      state, and `new_state` is the current state.
+      * @throws {Error} If `callback` is not a function.",I suggest that we use `query_based_sync` instead of `partial_sync`.,"""indices into the collection before the change happened, while `insertions` and `newModifications` are indices into the new version of the collection."""
+3013,"@@ -15,6 +15,11 @@
+ // Package azureblob provides a blob implementation that uses Azure Storage’s
+ // BlockBlob. Use OpenBucket to construct a *blob.Bucket.
+ //
++// NOTE: SignedURLs for PUT created with this package are not fully portable;
++// they will not work unless the PUT request includes a ""x-ms-blob-type"" header
++// set to ""BlockBlob"".
++// See https://stackoverflow.com/questions/37824136/put-on-sas-blob-url-without-specifying-x-ms-blob-type-header.
++//
+ // URLs
+ //
+ // For blob.OpenBucket, azureblob registers for the scheme ""azblob"".",How does the user use this? By converting the type using `As` function and add the header? Maybe add an example on how.,I don't think we need this note.
+3014,"@@ -38,11 +38,14 @@ import java.util.List;
+  */
+ public class DynamicLangApiMethodTransformer {
+   private final ApiMethodParamTransformer apiMethodParamTransformer;
+-  private final InitCodeTransformer initCodeTransformer = new InitCodeTransformer();
++  private final InitCodeTransformer initCodeTransformer;
+   private final LongRunningTransformer lroTransformer = new LongRunningTransformer();
+ 
+-  public DynamicLangApiMethodTransformer(ApiMethodParamTransformer apiMethodParamTransformer) {
++  public DynamicLangApiMethodTransformer(
++      ApiMethodParamTransformer apiMethodParamTransformer,
++      InitCodeTransformer initCodeTransformer) {
+     this.apiMethodParamTransformer = apiMethodParamTransformer;
++    this.initCodeTransformer = initCodeTransformer;
+   }
+ 
+   public OptionalArrayMethodView generateMethod(MethodTransformerContext context) {","I'm trying to understand the effects of this change. Is setting this to something other than the old default (that is, `initCodeTransformer = new InitCodeTransformer()`) generally necessary, or are we doing this only to support Python?",Why do we need this constructor?
+3015,"@@ -151,14 +151,15 @@
+ //
+ // Representing Keys
+ //
+-// The key of a docstore document is some function of its contents, usually a field.
++// The key of a docstore document is its unique identifier, usually a field.
+ // Keys never appear alone in the docstore API, only as part of a document. For
+ // instance, to retrieve a document by key, you pass the Collection.Get method
+ // a document as a struct pointer or map with the key field populated, and docstore
+-// populates the rest of that argument with the stored contents.
++// populates the rest of that argument with the stored contents. Docstore
++// doesn't take zero-value key.
+ //
+-// When you open a collection using the OpenCollection method of the service-specific driver or
+-// a URL, you specify how to extract the key from a document.
++// When you open a collection using the constructor of the service-specific
++// driver or a URL, you specify how to extract the key from a document.
+ // Usually, you provide the name of the key field, as in the example below:
+ //
+ //   coll, err := memdocstore.OpenCollection(""SSN"", nil)","""Constructor"" isn't a standard term in Go or this project, although we use it informally amongst ourselves. And I think it will confuse people coming from languages like Java. So can we leave this as it was?","I don't think we need to say ""zero-value"" here."
+3016,"@@ -114,7 +114,7 @@ class TestCtuFailure(unittest.TestCase):
+         """""" Test that Clang indeed logs the AST import events when using
+         on-demand mode.
+         """"""
+-        self.__set_up_test_dir('ctu_on_demand_failure')
++        self.__set_up_test_dir('ctu_failure')
+ 
+         output = self.__do_ctu_all(on_demand=True,
+                                    extra_args=[""--verbose"", ""debug""])",Why do we have to change the test dir?,Why this change?
+3017,"@@ -65,9 +65,11 @@ dom.isNativelyFocusable = function(el) {
+ 			return el.type !== 'hidden';
+ 		case 'TEXTAREA':
+ 		case 'SELECT':
+-		case 'DETAILS':
++		case 'SUMMARY':
+ 		case 'BUTTON':
+ 			return true;
++		case 'DETAILS':
++			return !el.querySelector('summary');
+ 	}
+ 	return false;
+ };",This should test the flattened tree instead. details > summary works across shadow tree boundaries.,Why do we need t
+3018,"@@ -0,0 +1,17 @@
++// MvxBindingLog.cs
++
++// MvvmCross is licensed using Microsoft Public License (Ms-PL)
++// Contributions and inspirations noted in readme.md and license.txt
++//
++// Project Lead - Stuart Lodge, @slodge, me@slodge.com
++
++using MvvmCross.Platform;
++using MvvmCross.Platform.Logging;
++
++namespace MvvmCross
++{
++    internal static class MvxAndroidLog
++    {
++        internal static IMvxLog Instance { get; } = Mvx.Resolve<IMvxLogProvider>().GetLogFor(""MvxAndroid"");
++    }
++}",Not sure I am a big fan of these duplicated Log classes.,nit: missing new
+3019,"@@ -39,6 +39,10 @@ import (
+ 
+ const (
+ 	reasonDomainVerified = ""DomainVerified""
++	CleanUpError         = ""CleanUpError""
++	PresentError         = ""PresentError""
++	Presented            = ""Presented""
++	Failed               = ""Failed""
+ )
+ 
+ // solver solves ACME challenges by presenting the given token and key in an","It's long-winded, but the convention is to give constants a common prefix which, see `reasonDomainVerified` .",I think this sho
+3020,"@@ -32,7 +32,7 @@ const constexpr double LOOKAHEAD_DISTANCE_WITHOUT_LANES = 10.0;
+ // smaller widths, ranging from 2.5 to 3.25 meters. As a compromise, we use
+ // the 3.25 here for our angle calculations
+ const constexpr double ASSUMED_LANE_WIDTH = 3.25;
+-const constexpr double FAR_LOOKAHEAD_DISTANCE = 30.0;
++const constexpr double FAR_LOOKAHEAD_DISTANCE = 20.0;
+ 
+ // The count of lanes assumed when no lanes are present. Since most roads will have lanes for both
+ // directions or a lane count specified, we use 2. Overestimating only makes our calculations safer,","Using lanes later down, this threshold could be reduced for similar effects. Otherwise we look a bit to far.",Why did you change this?
+3021,"@@ -78,6 +78,12 @@ typedef enum {
+ 	CONTAINER_MODE_UMBRELLA
+ } container_mode_t;
+ 
++struct environment {
++	char *tarball;     /* Conda environemnt as produced by conda-pack. */
++	char *expansion;   /* Directory in cache/. Only set when environemnt has been expanded.*/
++	int error;         /* Whether the expansion had an error. 1 for yes, 0 for no. */
++};
++
+ #define DOCKER_WORK_DIR ""/home/worker""
+ 
+ // In single shot mode, immediately quit when disconnected.",Let's get more verbose about names. struct `wq_conda_environment`: if it can really only be used for conda. struct `wq_software_environment`: if it has potential use outside of conda.,I don't think we need th
+3022,"@@ -28,6 +28,8 @@ func TestStore_ListProjects(t *testing.T) {
+ 	cowProjectString, err := marshal(cowProject)
+ 	require.NoError(t, err, ""Marshal project should not fail"")
+ 
++	lastPageInPaginatedResp := false
++
+ 	testCases := map[string]struct {
+ 		mockGetParametersByPath func(t *testing.T, param *ssm.GetParametersByPathInput) (*ssm.GetParametersByPathOutput, error)
+ ",Should we set this back to `false` inside each `t.Run`? so that we can have more than one testcase that can have paginated responses,Why do we need this?
+3023,"@@ -130,6 +130,9 @@ class BaseSnapshot implements Snapshot {
+     if (dataManifests == null) {
+       this.dataManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
+           manifest -> manifest.content() == ManifestContent.DATA));
++    }
++
++    if (deleteManifests == null) {
+       this.deleteManifests = ImmutableList.copyOf(Iterables.filter(allManifests,
+           manifest -> manifest.content() == ManifestContent.DELETES));
+     }",What about using `dataManifests == null || deleteManifests == null`?,nit: remove empty line
+3024,"@@ -469,7 +469,7 @@ public class IndexSearcher {
+ 
+       @Override
+       public TopScoreDocCollector newCollector() throws IOException {
+-        return TopScoreDocCollector.create(cappedNumHits, after, TOTAL_HITS_THRESHOLD);
++        return TopScoreDocCollector.create(cappedNumHits, after, new GlobalHitsThresholdChecker(TOTAL_HITS_THRESHOLD));
+       }
+ 
+       @Override",The `HitsThresholdChecker` should be created once and shared within the collectors ? We also don't need to use the `GlobalHitsThresholdChecker` if the executor is null or if there is a single slice.,I don't think we need to create a new `GlobalHitsThresholdChecker` here. The `TopScoreDocCollector` already has a `GlobalHitsThresholdChecker`.
+3025,"@@ -15,10 +15,14 @@
+ package openflow
+ 
+ import (
++	""antrea.io/antrea/pkg/agent/config""
++	""antrea.io/antrea/pkg/agent/openflow/cookie""
+ 	""fmt""
++	""k8s.io/client-go/tools/cache""
+ 	""net""
+ 	""strconv""
+ 	""strings""
++	""sync""
+ 
+ 	""k8s.io/apimachinery/pkg/util/intstr""
+ 	""k8s.io/klog/v2""",move this to below `antrea.io` import section,nit: remove empty line
+3026,"@@ -80,6 +80,8 @@ namespace OpenTelemetry.Trace
+         /// </summary>
+         /// <param name=""activity"">Activity instance.</param>
+         /// <param name=""kind"">Activity execution kind.</param>
++        /// <remarks>This extension method should only be used on <see cref=""Activity""/> instances that were created
++        /// via older means that predate <see cref=""ActivitySource""/>.</remarks>
+         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+         public static void SetKind(this Activity activity, ActivityKind kind)
+         {",Seems likely to confuse people. What if we moved it into ActivitySourceAdapter and made it private?,I'm not sure if this is the right way to go about it. I think it would be better to have an extension method for this.
+3027,"@@ -320,6 +320,18 @@ func (b *EthAPIBackend) SendTx(ctx context.Context, signedTx *types.Transaction)
+ 			if len(signedTx.Data()) > b.MaxCallDataSize {
+ 				return fmt.Errorf(""Calldata cannot be larger than %d, sent %d"", b.MaxCallDataSize, len(signedTx.Data()))
+ 			}
++			// The gas price must be a multiple of a gwei
++			if new(big.Int).Mod(signedTx.GasPrice(), big.NewInt(1e6)).Cmp(common.Big0) != 0 {
++				return errors.New(""Gas price must be a multiple of 1,000,000 wei"")
++			}
++			// If there is a value field set then reject transactions that
++			// contain calldata. The feature of sending transactions with value
++			// and calldata will be added in the future.
++			if signedTx.Value().Cmp(common.Big0) != 0 {
++				if len(signedTx.Data()) > 0 {
++					return errors.New(""Cannot send transactions with value and calldata"")
++				}
++			}
+ 		}
+ 		return b.eth.syncService.ApplyTransaction(signedTx)
+ 	}",gas price don't need to be a multiple cuz we support allll gas prices now,Why do we need this check?
+3028,"@@ -81,5 +81,10 @@ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.Interfaces
+         /// Send the request to abort the test run
+         /// </summary>
+         void SendTestRunAbort();
++
++        /// <summary>
++        /// handle client process exit
++        /// </summary>
++        void OnClientProcessExit();
+     }
+ }",We are exposing implementation details in the interface. What if there is no processes involved in an implementation of `ITestRequestSender`?,Why do we need this?
+3029,"@@ -1167,6 +1167,8 @@ def main(args,
+                   'address.\n')
+         else:
+             print('Error occurred on the server side, message: {}'.format(e))
++    except Exception as e:  # pylint: disable=broad-except
++        print ('Error occurred, message: {}'.format(e.message))
+     return config
+ 
+ ","It would be awesome not to handle the broad exception here. Instead, raise a custom exception, something like `ModelNotSetException`, from the `require_model()`, and then handle it here with a nicer message to tell the user to set the model first.",Why do we need this?
+3030,"@@ -18,7 +18,8 @@ return [
+             'widget_title_default' => 'Website',
+             'online' => 'Online',
+             'maintenance' => 'In maintenance',
+-            'manage_themes' => 'Manage themes'
++            'manage_themes' => 'Manage themes',
++            'customize_theme' => 'Customize Theme'
+         ]
+     ],
+     'theme' => [","This already exists under the `theme` lang key, please remove this.",Shouldn't this be `C
+3031,"@@ -223,6 +223,10 @@ class SetupUsingGCP extends Component {
+ 		return (
+ 			<Fragment>
+ 				<Header />
++				{ /*
++					Note: this component doesn't use hooks and thus can't access the
++					feature flags, so we don't render the HelpMenu here.
++				*/ }
+ 				<div className=""googlesitekit-wizard"">
+ 					<div className=""mdc-layout-grid"">
+ 						<div className=""mdc-layout-grid__inner"">",Let's add a simple inline HOC around the default export below to provide the value as a prop (no need to introduce a reusable function for this yet).,Why is this needed?
+3032,"@@ -29,7 +29,7 @@ module Beaker
+         v_file << ""    v.vm.box = '#{host['box']}'\n""
+         v_file << ""    v.vm.box_url = '#{host['box_url']}'\n"" unless host['box_url'].nil?
+         v_file << ""    v.vm.base_mac = '#{randmac}'\n""
+-        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""255.255.0.0\""\n""
++        v_file << ""    v.vm.network :private_network, ip: \""#{host['ip'].to_s}\"", :netmask => \""#{host['netmask'] ||= ""255.255.0.0""}\""\n""
+         v_file << ""  end\n""
+         @logger.debug ""created Vagrantfile for VagrantHost #{host.name}""
+       end",I believe that you end up printing out the result of the assignment here instead of the netmask.,Why do we need this change?
+3033,"@@ -0,0 +1,11 @@
++export const CREDENTIALS = {
++  user: 'test',
++  password: 'test'
++};
++
++export const TARBALL = 'tarball-blahblah-file.name';
++export const PORT_SERVER_APP = '55550';
++export const PORT_SERVER_1 = '55551';
++export const PORT_SERVER_2 = '55552';
++export const PORT_SERVER_3 = '55553';
++export const DOMAIN_SERVERS = 'localhost';",We have to update the filename here.,Why do we need this?
+3034,"@@ -121,6 +121,11 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""                         (see the --cpp-str-flex-ctor option to change this behavior).\n""
+     ""  --cpp-str-flex-ctor    Don't construct custom string types by passing std::string\n""
+     ""                         from Flatbuffers, but (char* + length).\n""
++    ""  --cpp-field-case STYLE Generate C++ fields using selected case style.\n""
++    ""                         Supported STYLE values:\n""
++    ""                          * 'unchanged' - leave unchanged (default);\n""
++    ""                          * 'upper' - schema snake_case emits UpperCamel;\n""
++    ""                          * 'lower' - schema snake_case emits lowerCamel.\n""
+     ""  --cpp-std CPP_STD      Generate a C++ code using features of selected C++ standard.\n""
+     ""                         Supported CPP_STD values:\n""
+     ""                          * 'c++0x' - generate code compatible with old compilers;\n""",The `--cpp-field-case` looks like `--cpp-field-style` instead of `-case`. - 'unchanged' - leave unchanged (default); - 'upper_camel' -upper camel case; - 'lower_camel' - lower camel case.,I don't think this is the r
+3035,"@@ -95,9 +95,6 @@ ot_admin_builtin_upgrade (int argc, char **argv, GCancellable *cancellable, GErr
+                                                   ""override-commit"", NULL);
+         }
+ 
+-      /* Should we consider requiring --discard-hotfix here? */
+-      origin_changed |= g_key_file_remove_key (origin, ""origin"", ""unlocked"", NULL);
+-
+       if (origin_changed)
+         {
+           /* XXX GCancellable parameter is not used. */","I haven't thought about this a lot yet, but if we were to try this change, we'd still need to keep the code to delete it from the `.origin` file for backcompat.",Why is this being removed?
+3036,"@@ -18,6 +18,9 @@ package org.hyperledger.besu.evmtool;
+ import org.hyperledger.besu.config.GenesisConfigOptions;
+ import org.hyperledger.besu.consensus.clique.CliqueProtocolSchedule;
+ import org.hyperledger.besu.consensus.ibft.IbftBlockHeaderFunctions;
++import org.hyperledger.besu.crypto.KeyPairSecurityModule;
++import org.hyperledger.besu.crypto.NodeKey;
++import org.hyperledger.besu.crypto.SECP256K1;
+ import org.hyperledger.besu.ethereum.core.BlockHeaderFunctions;
+ import org.hyperledger.besu.ethereum.mainnet.ProtocolSchedule;
+ ",In my opinion I think it is possible to add `private final` here,nit: unused import ?
+3037,"@@ -265,7 +265,7 @@ func (p *Builder) writeProgramHeader() {
+ 	p.b.LoadMapFD(R1, uint32(p.stateMapFD)) // R1 = 0 (64-bit immediate)
+ 	p.b.Call(HelperMapLookupElem)           // Call helper
+ 	// Check return value for NULL.
+-	p.b.JumpEqImm64(R0, 0, ""deny"")
++	p.b.JumpEqImm64(R0, 0, ""exit"")
+ 	// Save state pointer in R9.
+ 	p.b.Mov64(R9, R0)
+ 	p.b.LabelNextInsn(""policy"")","Feel like ""exit"" doesn't convey that the packet will be dropped. ""drop-and-exit"" or ""error-exit"" maybe?",Why did you change t
+3038,"@@ -1330,7 +1330,7 @@ static bool check_main_create(pass_opt_t* opt, ast_t* ast)
+   if(ast_childcount(params) != 1)
+   {
+     ast_error(opt->check.errors, params,
+-      ""the create constructor of a Main actor must take a single Env ""
++      ""A Main actor must have a create constructor which takes a single Env ""
+       ""parameter"");
+     ok = false;
+   }","How do you feel about ""The Main actor"" instead of ""A Main actor"", while we're already here changing the message?","""A Main actor must h"
+3039,"@@ -38,6 +38,7 @@ public interface PermissionNameProvider {
+     COLL_READ_PERM(""collection-admin-read"", null),
+     CORE_READ_PERM(""core-admin-read"", null),
+     CORE_EDIT_PERM(""core-admin-edit"", null),
++    ZK_READ_PERM(""zk-read"", null),
+     READ_PERM(""read"", ""*""),
+     UPDATE_PERM(""update"", ""*""),
+     CONFIG_EDIT_PERM(""config-edit"", unmodifiableSet(new HashSet<>(asList(""*"", null)))),","I cannot see that this new permission is used anywhere? And if the new zk handler is covered by `zk-read`, should not also existing `ZookeeperInfoHandler` handler implement PermissionNameProvider and declare the same permission, for consistency?",I think this should 
+3040,"@@ -103,7 +103,7 @@ def as_spark_type(tpe) -> types.DataType:
+     """"""
+     # TODO: Add ""boolean"" and ""string"" types.
+     # ArrayType
+-    if tpe in (np.ndarray,):
++    if tpe in (list, np.ndarray,):
+         return types.ArrayType(types.StringType())
+     elif hasattr(tpe, ""__origin__"") and issubclass(tpe.__origin__, list):
+         return types.ArrayType(as_spark_type(tpe.__args__[0]))",Is this reasonable?,Why this change?
+3041,"@@ -21,6 +21,7 @@ class AutoAugment(object):
+             augment images.
+ 
+     Examples:
++        TODO: Implement 'Shear', 'Sharpness' and 'Rotate' transforms
+         >>> replace = (104, 116, 124)
+         >>> policies = [
+         >>>     [",We may move this TODO to Line15.,I don't think th
+3042,"@@ -263,7 +263,12 @@ class OrderController extends BaseFrontController
+ 
+         /* check cart count */
+         $this->checkCartNotEmpty();
+-
++        
++        /* check stock not empty */
++        if(true === ConfigQuery::checkAvailableStock()) {
++          return $this->checkStockNotEmpty();
++        }
++        
+         /* check delivery address and module */
+         $this->checkValidDelivery();
+ ","You have to verify the return type. If it's a reponse, return it. Otherwise do nothing.",Please add a spa
+3043,"@@ -44,15 +44,17 @@
+ 
+ #include <Kokkos_Core.hpp>
+ #include <Kokkos_Timer.hpp>
+-#include <bench.hpp>
+ #include <cstdlib>
+ 
++template <class T>
++void run_stride_unroll(int, int, int, int, int, int, int, int);
++
+ int main(int argc, char* argv[]) {
+   Kokkos::initialize();
+ 
+   if (argc < 10) {
+     printf(""Arguments: N K R D U F T S\n"");
+-    printf(""  P:   Precision (1==float, 2==double)\n"");
++    printf(""  P:   Precision (1==float, 2==double, 3==int32_t, 4==int64_t)\n"");
+     printf(""  N,K: dimensions of the 2D array to allocate\n"");
+     printf(""  R:   how often to loop through the K dimension with each team\n"");
+     printf(""  D:   distance between loaded elements (stride)\n"");",No. Keep the header include and do `extern template ...` to skip the instantiation from that compile unit. (I pushed a fix directly to your branch),Why did you remo
+3044,"@@ -203,6 +203,8 @@ class TestPython3Checker(testutils.CheckerTestCase):
+             '[x for x in {}]',
+             'func({})',
+             'a, b = {}',
++            'max({}())',
++            'min({}())',
+         ]
+         non_iterating_code = [
+             'x = __({}())',","these tests are currently somewhat nonsensical. This code expands to `a, b = {}.keys` when it really should be expanding to `a, b = {}.keys()` -- though fixing this causes the test to fail so I suspect something worse is going on here that I don't quite understand?",Why do we need this?
+3045,"@@ -90,7 +90,7 @@ public class TestAvroNameMapping extends TestAvroReadProjection {
+     projected = writeAndRead(writeSchema, readSchema, record, nameMapping);
+     Record projectedL1 = ((Map<String, Record>) projected.get(""location"")).get(""l1"");
+     Assert.assertNotNull(""Field missing from table mapping is renamed"", projectedL1.getSchema().getField(""long_r2""));
+-    Assert.assertNull(""location.value.long, should not be read"", projectedL1.get(""long_r2""));
++    Assert.assertNull(""location.value.long, should not be read"", projectedL1.get(""long""));
+   }
+ 
+   @Test",Why did this need to change?,Why was this changed
+3046,"@@ -0,0 +1,14 @@
++// Copyright (c) 2019 IoTeX Foundation
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package factory
++
++import ""github.com/iotexproject/iotex-core/action/protocol""
++
++// BranchDB defines the interface of an branch state db, which could start a new transaction
++type BranchDB interface {
++	NewTransaction() (protocol.Transaction, error)
++}",/go/pkg/mod/golang.org/x/xerrors@v0.0.0-20190410155217-1f06c39b4373/adaptor_go1_13.go:16:21: Frame not declared by package errors (from `typecheck`),Why do we need this 
+3047,"@@ -128,6 +128,7 @@ public class ZkStateReader implements SolrCloseable {
+ 
+   public static final String CONFIGS_ZKNODE = ""/configs"";
+   public final static String CONFIGNAME_PROP = ""configName"";
++  public final static String COLLECTION_CONFIG_PROP = ""collection.configName"";
+ 
+   public static final String SAMPLE_PERCENTAGE = ""samplePercentage"";
+ ",Probably doesn't go here because I think it's specific to the HTTP API layer. This class is too internal to declare such a name.,public static final 
+3048,"@@ -60,8 +60,11 @@ public class ITZipkinMetricsHealth {
+   }
+ 
+   @Test public void healthIsOK() throws Exception {
+-    assertThat(get(""/health"").isSuccessful())
+-      .isTrue();
++    Response check = get(""/health"");
++    assertThat(check.isSuccessful()).isTrue();
++    assertThat(check.body().string()).isEqualTo(
++      ""{\""status\"":\""UP\"",\""zipkin\"":{\""status\"":\""UP\"",\""details\"":{\""InMemoryStorage{}\"":{\""status\"":\""UP\""}}}}""
++    );
+ 
+     // ensure we don't track health in prometheus
+     assertThat(scrape())",in preparation of directly writing the /health endpoint one day.. we should have content checks.,Why do we need this?
+3049,"@@ -10,7 +10,7 @@ import (
+ type MultipleIDMatchesError struct{ prefix string }
+ 
+ func (e *MultipleIDMatchesError) Error() string {
+-	return fmt.Sprintf(""multiple IDs with prefix %s found"", e.prefix)
++	return fmt.Sprintf(""multiple IDs with prefix %q found"", e.prefix)
+ }
+ 
+ // A NoIDByPrefixError is returned by Find() when no ID for a given prefix",question (non-blocking): Is there a benefit from using `%q` instead of `%s`?,// MultipleIDMatches
+3050,"@@ -26,7 +26,6 @@ std::string MetaUtils::spaceKey(GraphSpaceID spaceId) {
+     return key;
+ }
+ 
+-
+ std::string MetaUtils::spaceVal(int32_t partsNum, int32_t replicaFactor, const std::string& name) {
+     std::string val;
+     val.reserve(256);",I would suggest to keep two empty lines between functions in cpp files,Why is this removed?
+3051,"@@ -178,7 +178,7 @@ void runTests(int64_t numElements) {
+     {
+         test(0x01, C_d, C_h, numElements, syncNone, true /*expectMismatch*/);
+         test(0x02, C_d, C_h, numElements, syncNullStream, false /*expectMismatch*/);
+-        test(0x04, C_d, C_h, numElements, syncOtherStream, true /*expectMismatch*/);
++        test(0x04, C_d, C_h, numElements, syncOtherStream, false /*expectMismatch*/);
+         test(0x08, C_d, C_h, numElements, syncDevice, false /*expectMismatch*/);
+ 
+         // Sending a marker to to null stream may synchronize the otherStream",This change causes the test to fail on both rocm-1.9.x and rocm-head.,Why this change?
+3052,"@@ -0,0 +1,17 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd;
++
++/**
++ * This interface allows to determine which rule violations are fixable, and with which class the fixes will be made.
++ */
++public interface AutoFixableRuleViolation extends RuleViolation {
++
++    /**
++     * Obtain the class which will attempt to fix the AST.
++     * @return
++     */
++    Class<? extends RuleViolationFix> getRuleViolationFixer();
++}",I'd consider moving all fix related stuff to a distinct package to avoid contaminating the base package,Why do we need this interface?
+3053,"@@ -266,7 +266,18 @@ def parse_compile_commands_json(logfile, parseLogOptions):
+         results = option_parser.parse_options(command)
+ 
+         action.original_command = command
+-        action.analyzer_options = results.compile_opts
++
++        # If the original include directory could not be found
++        # in the filesystem, it is possible that it was provided
++        # relative to the working directory in the compile json.
++        compile_opts = results.compile_opts
++        for i, opt in enumerate(compile_opts):
++            if opt.startswith('-I'):
++                inc_dir = opt[2:].strip()
++                if not os.path.isdir(inc_dir):
++                    compile_opts[i] = '-I' + \
++                        os.path.join(entry['directory'], inc_dir)
++        action.analyzer_options = compile_opts
+ 
+         action.lang = results.lang
+         action.target = results.arch",Use `os.path.join` for path concatenation.,I don't think you need the `\`
+3054,"@@ -18,11 +18,13 @@ from .retina_head import RetinaHead
+ from .retina_sepbn_head import RetinaSepBNHead
+ from .rpn_head import RPNHead
+ from .ssd_head import SSDHead
++from .yolact_head import YolactHead, YolactProtonet, YolactSegmHead
+ 
+ __all__ = [
+     'AnchorFreeHead', 'AnchorHead', 'GuidedAnchorHead', 'FeatureAdaption',
+     'RPNHead', 'GARPNHead', 'RetinaHead', 'RetinaSepBNHead', 'GARetinaHead',
+     'SSDHead', 'FCOSHead', 'RepPointsHead', 'FoveaHead',
+     'FreeAnchorRetinaHead', 'ATSSHead', 'FSAFHead', 'NASFCOSHead',
+-    'PISARetinaHead', 'PISASSDHead', 'GFLHead', 'CornerHead'
++    'PISARetinaHead', 'PISASSDHead', 'GFLHead', 'CornerHead', 'YolactHead',
++    'YolactSegmHead', 'YolactProtonet'
+ ]","Use upper case: YOLACTHead, YOLACTProtonet, YOLACTSegmHead",I don't think we need to expor
+3055,"@@ -43,7 +43,7 @@ type harness struct {
+ }
+ 
+ func (h *harness) MakeDriver(ctx context.Context) (driver.Crypter, error) {
+-	return &Crypter{
++	return &crypter{
+ 		keyID: &KeyID{
+ 			ProjectID: projectID,
+ 			Location:  location,",The driver tests should be updated to use the concrete type instead of the driver directly; right now your test coverage of the concrete type is 0%.,Why is this change needed?
+3056,"@@ -1038,7 +1038,14 @@ class CommentAnalyzer
+ 
+ 
+                     if ($method_tree_child->children) {
+-                        $param_type = Type::getTypeFromTree($method_tree_child->children[0], $codebase);
++                        try {
++                            $param_type = Type::getTypeFromTree($method_tree_child->children[0], $codebase);
++                        } catch (TypeParseTreeException $e) {
++                            $msg = 'Badly-formatted @method parameters for ' . $method_entry;
++                            $msg .= '; have you checked if a variable passed by reference has a space between';
++                            $msg .= ' the ampersand and the start of the variable?';
++                            throw new DocblockParseException($msg);
++                        }
+                         $docblock_lines[] = '@param \\' . $param_type . ' '
+                             . ($method_tree_child->variadic ? '...' : '')
+                             . $method_tree_child->name;",I would prefer the message to be more actionable. Like 'There should be no space between & and the variable name' or something similar.,I'm not sure if this is the best way to check if a variable has a space between the ampersand and the start of the variable.
+3057,"@@ -83,7 +83,16 @@ public class AntlrBaseNode extends ParserRuleContext implements AntlrNode {
+ 
+     @Override
+     public Node jjtGetChild(final int index) {
+-        return (Node) children.get(index); // TODO: review if all children are Nodes
++        try {
++            return (Node) children.get(index);
++        } catch (final ClassCastException e) {
++            return new AntlrBaseNode();
++        }
++    }
++
++    @Override
++    public String getImage() {
++        return getText();
+     }
+ 
+     @Override","The image attribute is not supposed to be the text of the node. I'd rather keep it separate (the previous `@Text` attribute was fine). A practical reason for that is in the future, other languages may have a way to get the text of their node, in which case that wouldn't be fetched with `getImage`, for compatibility, but probably with a `getText` method, or `getSourceCode` like in #1728. Also we *may* deprecate or otherwise put `getImage` out of use as soon as 7.0, given its contract is super loose.",Why do we need this method?
+3058,"@@ -12,14 +12,14 @@ module RSpec
+ 
+       def initialize
+         @full_backtrace = false
+-        @exclusion_patterns = [] << Regexp.union(
++        @system_exclusion_patterns = [] << Regexp.union(
+           *[""/lib\d*/ruby/"",
+             ""org/jruby/"",
+             ""bin/"",
+             ""/gems/"",
+             ""lib/rspec/(core|expectations|matchers|mocks)""].
+-          map {|s| Regexp.new(s.gsub(""/"", File::SEPARATOR))}
+-        )
++          map {|s| Regexp.new(s.gsub(""/"", File::SEPARATOR))})
++        @exclusion_patterns = [] + @system_exclusion_patterns
+         @inclusion_patterns = [Regexp.new(Dir.getwd)]
+       end
+ ",The `[] +` seems weird to me. Why is it there?,Why do we need this change?
+3059,"@@ -1,7 +1,7 @@
+ class FollowUp < ActiveRecord::Base
+   belongs_to :course
+-  validates_presence_of :email
+-  validates_format_of :email, with: /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i, on: :create
++  EMAIL_FORMAT = /\A([^@\s]+)@((?:[-a-z0-9]+\.)+[a-z]{2,})\Z/i
++  validates :email, presence: true, format: { with: EMAIL_FORMAT }, on: :create
+ 
+   scope :have_not_notified, where(notified_at: nil)
+ ",Not sure if this constant is defined at the right place style-wise. Maybe move it up to before 'belongs_to' like DISCOUNT_TYPES in coupon.rb?,Layout/SpaceInsideHashLiteralBraces: Space inside } missing.
+3060,"@@ -251,6 +251,17 @@ func checksum(bytes []byte) string {
+ 	return hex.EncodeToString(d[:])
+ }
+ 
++func isEmptyYaml(yaml []byte) bool {
++	isEmpty := true
++	lines := bytes.Split(yaml, []byte(""\n""))
++	for _, k := range lines {
++		if string(k) != ""---"" && !bytes.HasPrefix(k, []byte(""#"")) && string(k) != """" {
++			isEmpty = false
++		}
++	}
++	return isEmpty
++}
++
+ func yamlToObjects(in io.Reader) ([]runtime.Object, error) {
+ 	var result []runtime.Object
+ 	reader := yamlDecoder.NewYAMLReader(bufio.NewReaderSize(in, 4096))",What about a line with just spaces/tabs? Or a line with a couple spaces followed by a `#`?,"nit: `strings.HasPrefix(k, []byte(""#"")) && string(k) != """"`"
+3061,"@@ -376,7 +376,7 @@ module OrgAdmin
+           # Load the funder's template(s)
+           templates = Template.valid.publicly_visible.where(published: true, org_id: funder_id).to_a
+ 
+-          if org_id.present?
++          unless org_id.blank?
+             # Swap out any organisational cusotmizations of a funder template
+             templates.each do |tmplt|
+               customization = Template.valid.find_by(published: true, org_id: org_id, customization_of: tmplt.dmptemplate_id)",if funder_is is not blank (L375) there is not need to check if org_id is not blank (L379) since you will never enter in the if (L374).,Style/IfUnlessModifier: Favor modifier unless usage when ha
+3062,"@@ -3403,6 +3403,13 @@ void Client::Handle_OP_AutoFire(const EQApplicationPacket *app)
+ 		DumpPacket(app);
+ 		return;
+ 	}
++
++	if (GetTarget() == this) {
++		this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++		auto_fire = false;
++		return;
++	}
++
+ 	bool *af = (bool*)app->pBuffer;
+ 	auto_fire = *af;
+ 	auto_attack = false;",Don't need this-> here.,Why is this check needed?
+3063,"@@ -20,6 +20,9 @@ The metadata server is only accessible on GCE.
+ import httplib
+ import socket
+ 
++from google.auth.compute_engine import _metadata
++from google.auth.transport import requests
++
+ from google.cloud.forseti.common.util import errors
+ from google.cloud.forseti.common.util import logger
+ ","I'm a little concerned about relying on a private module, as they could change the implementation at some point, I'd like to have some test to validate this is working as intended.",nit: import order
+3064,"@@ -1095,7 +1095,7 @@ class Resource:
+                         send_alert(self.request, message, url)
+                     operator = COMPARISON.LT
+ 
+-                if value == """":
++                if value == """" or isinstance(value, dict):
+                     raise_invalid(self.request, **error_details)
+ 
+                 filters.append(Filter(self.model.modified_field, value, operator))",There might other values that we don't support here (eg. `[]`). So it might be safer to check for the supported types instead (string or number).,"`isinstance(value, dict)` is equivalent to `value is None`."
+3065,"@@ -179,6 +179,18 @@ Status GoExecutor::prepareFrom() {
+                 status = Status::Error();
+                 break;
+             }
++            if (expr->isFunCallExpression()) {
++                auto *funcExpr = static_cast<FunctionCallExpression*>(expr);
++                if (*(funcExpr->name()) == ""near"") {
++                    auto v = Expression::asString(value.value());
++                    std::vector<VertexID> result;
++                    folly::split("","", v, result, true);
++                    starts_.insert(starts_.end(),
++                                   std::make_move_iterator(result.begin()),
++                                   std::make_move_iterator(result.end()));
++                    continue;
++                }
++            }
+             auto v = value.value();
+             if (!Expression::isInt(v)) {
+                 status = Status::Error(""Vertex ID should be of type integer"");","FYI, It won't have any benefit to move from trivial types.",nit: `if (auto *funcExpr = static_cast<FunctionCallExpressi
+3066,"@@ -37,6 +37,7 @@ const (
+ 	capabilityDockerPluginInfix                 = ""docker-plugin.""
+ 	attributeSeparator                          = "".""
+ 	capabilityPrivateRegistryAuthASM            = ""private-registry-authentication.secretsmanager""
++	capabilitySecretEnvSSM                      = ""secrets-ssm-environment-variables""
+ )
+ 
+ // capabilities returns the supported capabilities of this agent / docker-client pair.","i missed these discussions- but ` ""secrets-ssm-environment-variables""` is what was agreed upon with cp?",I think this should be `secrets-ssm-environment-variables`
+3067,"@@ -20,6 +20,7 @@ import (
+ 	""google.golang.org/protobuf/types/known/anypb""
+ 	""gopkg.in/yaml.v3""
+ 
++	""github.com/gogo/protobuf/jsonpb""
+ 	gatewayv1 ""github.com/lyft/clutch/backend/api/config/gateway/v1""
+ 	""github.com/lyft/clutch/backend/middleware/timeouts""
+ )",whats the difference between this package and `github.com/golang/protobuf` ? or did vscode just decided this was the package it wanted to used?,"""github.com/gogo/protobuf/proto"""
+3068,"@@ -127,6 +127,7 @@ public class RepositoriesPanel extends StackPane {
+         this.addButton.setText(tr(""Add""));
+         this.addButton.setOnAction((ActionEvent event) -> {
+             AddRepositoryDialog dialog = new AddRepositoryDialog();
++            dialog.initOwner(this.getParent().getScene().getWindow());
+ 
+             Optional<RepositoryLocation<? extends Repository>> successResult = dialog.showAndWait();
+ ",Just asking: What does this line do? Does it add the stylesheet from the parent to the dialog?,Why is this needed?
+3069,"@@ -108,6 +108,7 @@ if __name__ == ""__main__"":
+                 ""pytest-xdist==2.1.0"",
+                 ""pytest==6.1.1"",
+                 ""responses==0.10.*"",
++                ""scikit-learn<1.0.0"",  # scikit-learn 1.0 requires python 3.7
+                 ""snapshottest==0.6.0"",
+                 ""tox==3.14.2"",
+                 ""tox-pip-version==0.0.7"",","Including the scikit-learn dependency here would pull in scikit-learn for everyone who depends on Dagster. If you put it in the setup.py under docs_snippets, we'd avoid that problem (although I think it's already there).",why is this needed?
+3070,"@@ -274,7 +274,6 @@ Status DataCollectExecutor::collectMultiplePairShortestPath(const std::vector<st
+ Status DataCollectExecutor::collectPathProp(const std::vector<std::string>& vars) {
+   DataSet ds;
+   ds.colNames = colNames_;
+-  DCHECK(!ds.colNames.empty());
+   // 0: vertices's props, 1: Edges's props 2: paths without prop
+   DCHECK_EQ(vars.size(), 3);
+ ",Why remove this?,Why is this removed
+3071,"@@ -145,13 +145,3 @@ def test_completion_item_focus(tree, count, expected, completionview):
+         completionview.completion_item_focus(direction)
+     idx = completionview.selectionModel().currentIndex()
+     assert filtermodel.data(idx) == expected
+-
+-
+-def test_completion_item_focus_no_model(completionview):
+-    """"""Test that next/prev won't crash with no model set.
+-
+-    This can happen if completion.show and completion.auto-open are False.
+-    Regression test for issue #1722.
+-    """"""
+-    completionview.completion_item_focus('prev')
+-    completionview.completion_item_focus('next')","Why remove this? It seems like we should keep this around as a regression test, unless we can guarantee this will never be called without a model set (does your new code guarantee that?)",Why was this test r
+3072,"@@ -27,6 +27,7 @@ const SET_PERMISSION_SCOPE_ERROR = 'SET_PERMISSION_SCOPE_ERROR';
+ 
+ export const INITIAL_STATE = {
+ 	permissionError: null,
++	capabilities: global._googlesitekitUserData?.permissions || {},
+ };
+ 
+ export const actions = {","Because this defaults to `{}` if `global._googlesitekitUserData?.permissions` is `false`-y, the checks below around `state.capabilities` always result in the `!! capabilities === true` path. This shouldn't have a default value of `{}` if there's the possibility that `global._googlesitekitUserData?.permissions` can be `undefined`/`false`/`null` legitimately.",export const INITIAL_STATE = {
+3073,"@@ -234,3 +234,17 @@ def repeat_command(win_id, count=None):
+     cmd = runners.last_command[mode_manager.mode]
+     commandrunner = runners.CommandRunner(win_id)
+     commandrunner.run(cmd[0], count if count is not None else cmd[1])
++
++@cmdutils.register(debug=True,name='debug-log-capacity')
++def log_capacity(capacity: int):
++    """"""Choose number of lines for your log.
++
++    Args:
++       capacity: Number of lines for the log.       
++    """"""
++    if capacity < 0:
++        raise cmdexc.CommandError(""Please choose log capacity above 0."")
++    else:        
++        log.ram_handler.change_log_capacity(capacity)
++
++","Please add a space after the comma here (generally, with arguments there's always a space after commas).",I don't think this is the righ
+3074,"@@ -17,7 +17,7 @@ package org.hyperledger.besu.config.experimental;
+ import picocli.CommandLine.Option;
+ 
+ /**
+- * Flags defined in those class must be used with cautious, and strictly reserved to experimental
++ * Flags defined in those class must be used with caution, and strictly reserved to experimental
+  * EIPs.
+  */
+ public class ExperimentalEIPs {","From the context, should it say ""Flags defined in this class must be used with caution..."" ?",I don't think this should be c
+3075,"@@ -0,0 +1,19 @@
++module.exports = {
++  roots: [
++    ""<rootDir>/javascript/grid-ui/src""
++  ],
++  testMatch: [
++    ""<rootDir>/javascript/grid-ui/src/tests/**/*.test.tsx""
++  ],
++  transform: {
++    ""^.+\\.(ts|tsx)$"": ""ts-jest""
++  },
++  moduleFileExtensions: [""ts"", ""tsx"", ""js"", ""jsx"", ""json"", ""node""],
++  snapshotSerializers: [""enzyme-to-json/serializer""],
++  setupFilesAfterEnv: [""<rootDir>/setupTests.ts""],
++  testEnvironment: ""jsdom"",
++  moduleNameMapper: {
++    "".+\\.(svg|png|jpg|css)$"": ""identity-obj-proxy"",
++    ""selenium/javascript/grid-ui/(.*)"": ""<rootDir>/$1""
++  }
++}","We don't need this file, we can use the one that is in the grid-ui directory",Why is this needed?
+3076,"@@ -28,6 +28,7 @@ const (
+ 	infoNoAccounts                 = ""Did not find any account. Please import or create a new one.""
+ 	infoRenamedAccount             = ""Renamed account '%s' to '%s'""
+ 	infoImportedKey                = ""Imported %s""
++	infoExportedKey                = ""Imported key for account %s: \""%s\""""
+ 	infoImportedNKeys              = ""Imported %d key%s""
+ 	infoCreatedNewAccount          = ""Created new account with address %s""
+ 	errorNameAlreadyTaken          = ""The account name '%s' is already taken, please choose another.""","""Exported key for account""?",I think this should be `%q` instead of `%s`
+3077,"@@ -37,6 +37,7 @@ namespace pwiz.Skyline.Util.Extensions
+     {
+         public const string EXT_CSV = "".csv""; // Not L10N
+         public const string EXT_TSV = "".tsv""; // Not L10N
++        public const string CRLF = ""\r\n""; // Not L10N
+ 
+         public static string FILTER_CSV
+         {",Normally we use Environment.NewLine unless you really want it to always be \r\n,"public const string FILTER_TSV = "".tsv""; //"
+3078,"@@ -697,13 +697,6 @@ func (c *AuRa) verifyFamily(chain consensus.ChainHeaderReader, e consensus.Epoch
+ 	return nil
+ }
+ 
+-// VerifyHeaders is similar to VerifyHeader, but verifies a batch of headers. The
+-// method returns a quit channel to abort the operations and a results channel to
+-// retrieve the async verifications (the order is that of the input slice).
+-func (c *AuRa) VerifyHeaders(chain consensus.ChainHeaderReader, headers []*types.Header, _ []bool) error {
+-	return nil
+-}
+-
+ // VerifyUncles implements consensus.Engine, always returning an error for any
+ // uncles as this consensus mechanism doesn't permit uncles.
+ func (c *AuRa) VerifyUncles(chain consensus.ChainReader, header *types.Header, uncles []*types.Header) error {",why did you remove `verifyHeaders`?,Why is this removed?
+3079,"@@ -66,14 +66,14 @@ class RegistrationsController < Devise::RegistrationsController
+           if other_org.nil?
+             redirect_to(after_sign_up_error_path_for(resource), alert: _('You cannot be assigned to other organisation since that option does not exist in the system. Please contact your system administrators.')) and return
+           end
+-          params[:user][:org_id] = other_org.id 
++          params[:user][:org_id] = other_org.id
+         end
+         build_resource(sign_up_params)
+         if resource.save
+           if resource.active_for_authentication?
+             set_flash_message :notice, :signed_up if is_navigational_format?
+             sign_up(resource_name, resource)
+-            UserMailer.welcome_notification(current_user).deliver
++            UserMailer.welcome_notification(current_user).deliver_now
+             unless oauth.nil?
+               # The OAuth provider could not be determined or there was no unique UID!
+               unless oauth['provider'].nil? || oauth['uid'].nil?",Thanks for cleaning up these deprecated calls,I think this should be `deliver_later`
+3080,"@@ -110,13 +110,13 @@ def _create_user(username, password='', email=None, is_admin=False,
+                  requires_activation=True, requires_reset=False):
+     def check_conflicts(username, email):
+         if not VALID_USERNAME_RE.match(username):
+-            raise ValidationException(""Unacceptable username."")
++            raise ValidationException(""Invalid username."")
+         if blacklisted_name(username):
+-            raise ValidationException(""Unacceptable username."")
++            raise ValidationException(""Invalid username."")
+         if email is None:
+             raise ValidationException(""Must provide email."")
+         if not VALID_EMAIL_RE.match(email):
+-            raise ValidationException(""Unacceptable email."")
++            raise ValidationException(""Invalid email."")
+         if User.query.filter_by(name=username).one_or_none():
+             raise ConflictException(""Username already taken."")
+         if User.query.filter_by(email=email).one_or_none():","@akarve this breaks error catching logic on the front end, I'll fix this. That's why I prefer to use some machine-friendly error codes that won't change frequently.","""Invalid username."" -> ""Invalid username."""
+3081,"@@ -115,7 +115,7 @@ func parseResource(resource string) (string, string, string) {
+ 
+ // is resource type require remote query
+ func requireRemoteQuery(resType string) bool {
+-	return resType == model.ResourceTypeConfigmap || resType == model.ResourceTypeSecret || resType == constants.ResourceTypeService || resType == constants.ResourceTypeEndpoints
++	return resType == model.ResourceTypeConfigmap || resType == model.ResourceTypeSecret || resType == constants.ResourceTypeEndpoints
+ }
+ 
+ func isConnected() bool {",We support process remoteQuery for Service. Why are we removing it ?,Why do we need to change this?
+3082,"@@ -6,10 +6,17 @@ require 'bolt/task'
+ require 'json'
+ 
+ class TransportAPI < Sinatra::Base
++  # This disables Sinatra's error page generation
++  set :show_exceptions, false
++
+   get '/' do
+     200
+   end
+ 
++  get '/500_error' do
++    raise 'Unexpected error'
++  end
++
+   post '/ssh/run_task' do
+     content_type :json
+ ",This is specifically for testing?,I don't think this is the right place to p
+3083,"@@ -71,7 +71,6 @@ class TagsController extends AbstractAdmin
+     {
+         $view = $this->createViewModel();
+         $view->setTemplate('admin/tags/home');
+-        $view->statistics = $this->getTable('resourcetags')->getStatistics(true);
+         return $view;
+     }
+ ",I think this is related to the social stats and probably does not need to be removed.,Why was this removed?
+3084,"@@ -13,6 +13,7 @@ import { PhysicalIndexToValueMap as IndexToValueMap } from './../../translations
+ const privatePool = new WeakMap();
+ const COLUMN_SIZE_MAP_NAME = 'autoColumnSize';
+ 
++/* eslint-disable jsdoc/require-description-complete-sentence */
+ /**
+  * @plugin AutoColumnSize
+  *","Yep, jsdoc again .. It seems that when the plugin description is wrapped within `eslint-disable/enable` expression it's not generated at all. After adding the `@class AutoColumnSize` tag right after the `@plugin` tag the plugin appears in the docs. Please review the other plugins.",Why do we need this?
+3085,"@@ -58,6 +58,13 @@ func (c *azureClient) GetVirtualMachineResourceID(ctx context.Context, principal
+ 	}
+ 
+ 	values := result.Values()
++	for len(values) == 0 {
++		nerr := result.NextWithContext(ctx)
++		if nerr != nil {
++			return """", errs.Wrap(nerr)
++		}
++		values = result.Values()
++	}
+ 	if len(values) == 0 {
+ 		return """", errs.New(""principal %q not found"", principalID)
+ 	}",This usage of the result doesn't look quite right. I would not expect the first page of values to be empty if there were multiple pages of results. This also obscures the error case when no values are returned (handled in the next `if` block) by returning a more generic error from the Azure SDK from `result.NextWithContext()`.,I think this should 
+3086,"@@ -1358,6 +1358,10 @@ func (exp *Service) GetBlockOrActionByHash(hashStr string) (explorer.GetBlkOrAct
+ 		return explorer.GetBlkOrActResponse{Execution: &exe}, nil
+ 	}
+ 
++	if exe, err := exp.GetAddressDetails(hashStr); err == nil {
++		return explorer.GetBlkOrActResponse{AddressDetails: &exe}, nil
++	}
++
+ 	return explorer.GetBlkOrActResponse{}, nil
+ }
+ ",unknown field AddressDetails in struct literal (from `typecheck`),I think we should re
+3087,"@@ -33,7 +33,13 @@ func sessionForRegion(region string) (*session.Session, error) {
+ 		return s.(*session.Session), nil
+ 	}
+ 
+-	ns, err := session.NewSession(aws.NewConfig().WithRegion(region))
++	ns, err := session.NewSessionWithOptions(session.Options{
++		// Provide SDK Config options, such as Region.
++		Config: aws.Config{
++			Region: aws.String(region),
++		},
++	})
++
+ 	if err != nil {
+ 		return nil, err
+ 	}","Just noticed, are we specifically missing the addition of `SharedConfigState: session.SharedConfigEnable` ?",I'm not sure if this
+3088,"@@ -67,9 +67,9 @@ namespace pwiz.Skyline.Model.Results
+                 var newTimeIntensities = GetTimeIntensities(Source);
+                 if (newTimeIntensities != null)
+                 {
+-                    if (oldTimeIntensities != null)
++                    if (oldTimeIntensities != null && oldTimeIntensities.NumPoints > 0)
+                     {
+-                        var oldTime = oldTimeIntensities.Times[ScanIndex];
++                        var oldTime = oldTimeIntensities.Times[Math.Min(ScanIndex, oldTimeIntensities.NumPoints - 1)];
+                         ScanIndex = newTimeIntensities.IndexOfNearestTime(oldTime);
+                     }
+                     else",Not sure what this is. Bad merge?,Why is this change needed?
+3089,"@@ -1318,9 +1318,12 @@ func (s *Server) updateAccountWithClaimJWT(acc *Account, claimJWT string) error
+ 	if acc == nil {
+ 		return ErrMissingAccount
+ 	}
+-	if acc.claimJWT != """" && acc.claimJWT == claimJWT && !acc.incomplete {
++	acc.mu.Lock()
++	sameClaim := acc.claimJWT != """" && acc.claimJWT == claimJWT && !acc.incomplete
++	acc.mu.Unlock()
++	if sameClaim {
+ 		s.Debugf(""Requested account update for [%s], same claims detected"", acc.Name)
+-		return ErrAccountResolverSameClaims
++		return nil
+ 	}
+ 	accClaims, _, err := s.verifyAccountClaims(claimJWT)
+ 	if err == nil && accClaims != nil {",I think this may be a RW lock.,Why do we need to lock her
+3090,"@@ -1,4 +1,4 @@
+-package pluginhelper
++package helpers
+ 
+ import (
+ 	""bytes""",Perhaps we should tuck this away into a dedicated subdir and name it `config` or something similar? Or maybe it would be happy living in `common`?,Why did you change this?
+3091,"@@ -810,6 +810,14 @@ void Client::SendTradeskillSearchResults(
+ 				continue;
+ 			}
+ 		}
++		
++		//Check if we need to learn it before sending them the recipe.. 
++		DBTradeskillRecipe_Struct spec;
++		if (content_db.GetTradeRecipe(recipe_id, objtype, someid, this->CharacterID(), &spec)) {
++			if ((spec.must_learn & 0xf) && !spec.has_learnt) {
++				continue;
++			}
++		}
+ 
+ 		auto               outapp = new EQApplicationPacket(OP_RecipeReply, sizeof(RecipeReply_Struct));
+ 		RecipeReply_Struct *reply = (RecipeReply_Struct *) outapp->pBuffer;",Doing a select query inside of a loop like this is not ideal. We should fetch recipes once and then loop through it in memory to perform this check,Shouldn't this be `&& !spe
+3092,"@@ -386,6 +386,8 @@ class Index(IndexOpsMixin):
+         array([0, 1, 2, 3])
+         >>> ks.DataFrame({'a': ['a', 'b', 'c']}, index=[[1, 2, 3], [4, 5, 6]]).index.to_numpy()
+         array([(1, 4), (2, 5), (3, 6)], dtype=object)
++        >>> ks.DataFrame({'a': ['a', 'b', 'c']}, index=[[1, 2, 3], [4, 5, 6]]).index.to_numpy(copy=True)
++        array([(1, 4), (2, 5), (3, 6)], dtype=object)
+         """"""
+         result = np.asarray(self.to_pandas()._values, dtype=dtype)
+         if copy:",too long here. (104 > 100),I think this should be `copy=False`
+3093,"@@ -210,7 +210,14 @@ namespace Nethermind.DataMarketplace.Subprotocols
+             }
+             
+             Logger.Warn($""GETTING MESSAGE: ndm.{NdmMessageCode.GetDescription(message.PacketType)}"");
+-            MessageHandlers[message.PacketType](message);
++            try
++            {
++                MessageHandlers[message.PacketType](message);
++            }
++            catch(KeyNotFoundException)
++            {
++                Logger.Error(""$There is no handler registered for this message"");
++            }
+         }
+ 
+         protected virtual void Handle(HiMessage message)",Use TryGetValue instead of catching exception,Why is this an error?
+3094,"@@ -4,12 +4,12 @@ feature 'Admin manages mentors' do
+   scenario 'creating a new mentor' do
+     user = create(:admin)
+ 
+-    visit admin_path(as: user)
++    visit admin_root_path(as: user)
+     click_link 'Mentors'
+-    click_link 'Add new'
++    click_link 'New mentor'
+     select(user.name, from: 'User')
+-    click_button 'Save'
++    click_button 'Create Mentor'
+ 
+-    expect(page).to have_content('Mentor successfully created')
++    expect(page).to have_content('Mentor was successfully created')
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted strings unless
+3095,"@@ -61,6 +61,17 @@ namespace fastrtps {
+ namespace rtps {
+ 
+ 
++static void add_statistics_sent_submessage(
++        CacheChange_t* change,
++        size_t num_locators)
++{
++    static_cast<void>(change);
++    static_cast<void>(num_locators);
++
++#ifdef FASTDDS_STATISTICS
++    change->num_sent_submessages += num_locators;
++#endif // ifdef FASTDDS_STATISTICS
++}
+ 
+ /**
+  * Loops over all the readers in the vector, applying the given routine.",I think this method should be either: - a static method of `RTPSWriter` to avoid a StatelessWriter redefinition of the function. - a setter in the `CacheChange_t` struct.,Why do we need this?
+3096,"@@ -74,10 +74,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+             }
+         }
+ 
+-        // Review: This is called when a CancellationToken fires mid-write. In HTTP/1.x, this aborts the entire connection.
+-        // Should we do that here?
++        // This is called when a CancellationToken fires mid-write. In HTTP/1.x, this aborts the entire connection.
++        // For HTTP/2 we abort the stream.
+         void IHttpOutputAborter.Abort(ConnectionAbortedException abortReason)
+         {
++            _stream.ResetAndAbort(abortReason, Http2ErrorCode.INTERNAL_ERROR);
+             Dispose();
+         }
+ ","You add a stream back reference for trailers, and all of the sudden we have tight coupling!  ",Why do we need to do this?
+3097,"@@ -2,6 +2,7 @@ using System;
+ using System.Collections;
+ using System.Collections.Concurrent;
+ using System.Collections.Generic;
++using System.Linq;
+ using Datadog.Trace.ClrProfiler.Emit;
+ using Datadog.Trace.ExtensionMethods;
+ using Datadog.Trace.Headers;",I don't think we use `AspNetAmbientContext` anymore since . We can probably delete this file.,Why is this needed?
+3098,"@@ -65,14 +65,14 @@
+ 	return modules;
+ }([
+ /* 0 */
+-/***/ function(module, exports, __webpack_require__) {
++/***/ (function(module, exports, __webpack_require__) {
+ 
+ 	module.exports = __webpack_require__(1);
+ 
+ 
+-/***/ },
++/***/ }),
+ /* 1 */
+-/***/ function(module, exports, __webpack_require__) {
++/***/ (function(module, exports, __webpack_require__) {
+ 
+ 	'use strict';
+ ","Please avoid committing build artifacts, as they produce unnecessary conflicts and noise.",Why this change?
+3099,"@@ -101,7 +101,7 @@ class RetryWrapper:
+ 
+         if name in self.__unwrap_methods:
+             return partial(x.__func__, self)
+-        elif hasattr(x, ""__call__""):
++        elif callable(x):
+             return self.__wrap_method_with_call_and_maybe_retry(x)
+         else:
+             return x",this is vendored code so i would hesitate to make random changes to it,Why this change?
+3100,"@@ -34,7 +34,13 @@ type payoutInfo struct {
+ 	// in Ethereum address format
+ 	// required: true
+ 	// example: 0x000000000000000000000000000000000000000a
+-	EthAddress   string `json:""ethAddress""`
++	EthAddress string `json:""ethAddress""`
++}
++
++// swagger:model ReferralInfoDTO
++type referralInfo struct {
++	// required: true
++	// example: ABC123
+ 	ReferralCode string `json:""referral_code""`
+ }
+ ",We are using a different style for JSON tags. `ethAddress` - camalCase `referral_code` - snake_case,This should be `referral_code`
+3101,"@@ -10,6 +10,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+     public static class HttpContextIntegration
+     {
+         private const string IntegrationName = ""HttpContext"";
++        private const string DefaultHttpContextTypeName = ""HttpContext"";
+         private static readonly ILog Log = LogProvider.GetLogger(typeof(HttpContextIntegration));
+ 
+         /// <summary>","Should this be `""Microsoft.AspNetCore.Http.DefaultHttpContext""`?",Why do we need this?
+3102,"@@ -68,7 +68,6 @@ interface ArrayType<T> {
+     /** Repeatedly group an array into equal sized sub-trees */
+     default Object grouped(Object array, int groupSize) {
+         final int arrayLength = lengthOf(array);
+-        assert arrayLength > groupSize;
+         final Object results = obj().newInstance(1 + ((arrayLength - 1) / groupSize));
+         obj().setAt(results, 0, copyRange(array, 0, groupSize));
+ ","removed asserts from `Vector` as it's stable enough and it may hinder inlining, even if turned off :/",Why was this assert removed?
+3103,"@@ -47,8 +47,14 @@ class MessageDefinitionStore:
+         self._messages_definitions[message.msgid] = message
+         self._msgs_by_category[message.msgid[0]].append(message.msgid)
+ 
++    # We disable the message here because MessageDefinitionStore is only
++    # initialized once and due to the size of the class does not run the
++    # risk of creating a large memory leak.
++    # See discussion in: https://github.com/PyCQA/pylint/pull/5673
+     @functools.lru_cache()
+-    def get_message_definitions(self, msgid_or_symbol: str) -> List[MessageDefinition]:
++    def get_message_definitions(  # pylint: disable=lru-cache-decorating-method
++        self, msgid_or_symbol: str
++    ) -> List[MessageDefinition]:
+         """"""Returns the Message definition for either a numeric or symbolic id.
+ 
+         The cache has no limit as its size will likely stay minimal. For each message we store",Do we want to raise on the function or on the decorator?,Why do we need to disable it h
+3104,"@@ -38,7 +38,7 @@ class Listen(object):
+             user_name=j.get('user_name', """"),
+             timestamp=datetime.utcfromtimestamp(float(j['listened_at'])),
+             artist_msid=j['track_metadata']['additional_info'].get('artist_msid'),
+-            album_msid=j['track_metadata']['additional_info'].get('album_msid'),
++            album_msid=j['track_metadata']['additional_info'].get('release_msid'),
+             recording_msid=j.get('recording_msid'),
+             data=j.get('track_metadata')
+         )",How complex is to to replace `album_*` with `release_*` everywhere in the `Listen` class and places that use it?,Should this be `release_msid` or `album_msid`?
+3105,"@@ -96,13 +96,13 @@ func (n *Namespaces) Remove(t NamespaceType) bool {
+ 	return true
+ }
+ 
+-func (n *Namespaces) Add(t NamespaceType, path string) {
++func (n *Namespaces) Add(t NamespaceType, path string) bool {
+ 	i := n.index(t)
+ 	if i == -1 {
+ 		*n = append(*n, Namespace{Type: t, Path: path})
+-		return
++		return true
+ 	}
+-	(*n)[i].Path = path
++	return false
+ }
+ 
+ func (n *Namespaces) index(t NamespaceType) int {","You haven't changed any of the callers of `.Add` to check the return value, so we're now ignoring duplicates. Please fix that.",Why is this change needed?
+3106,"@@ -10,6 +10,16 @@
+  * @return {Boolean} the element's hidden status
+  */
+ dom.isHiddenWithCSS = function isHiddenWithCSS(el, descendentVisibilityValue) {
++	const vNode = axe.utils.getNodeFromTree(el);
++
++	if (vNode._isHiddenWithCSS === void 0) {
++		vNode._isHiddenWithCSS = _isHiddenWithCSS(el, descendentVisibilityValue);
++	}
++
++	return vNode._isHiddenWithCSS;
++};
++
++function _isHiddenWithCSS(el, descendentVisibilityValue) {
+ 	if (el.nodeType === 9) {
+ 		// 9 === Node.DOCUMENT
+ 		return false;",@straker should this not push to `vnode._cache.isHiddenWithCSS`?,I don't think we need this function.
+3107,"@@ -12,8 +12,8 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ 
+-// Package driver provides the interface for providers of runtimevar.  This serves as a contract
+-// of how the runtimevar API uses a provider implementation.
++// Package driver defines an interface that the runtimevar package uses to
++// interact with the underlying runtime configuration services.
+ package driver // import ""gocloud.dev/runtimevar/driver""
+ 
+ import (","""an interface"" in conceptual sense vs ""interfaces"" or ""set of interfaces"", referring to the Go interfaces - database/sql uses the latter, should we?",I don't think this is the right place to put t
+3108,"@@ -335,8 +335,11 @@ public class DownloadService extends Service {
+                             && String.valueOf(HttpURLConnection.HTTP_GONE).equals(status.getReasonDetailed());
+                     boolean httpBadReq = status.getReason() == DownloadError.ERROR_HTTP_DATA_ERROR
+                             && String.valueOf(HttpURLConnection.HTTP_BAD_REQUEST).equals(status.getReasonDetailed());
++                    boolean ioError = status.getReason() == DownloadError.ERROR_IO_ERROR;
++                    boolean connectError = status.getReason() == DownloadError.ERROR_CONNECTION_ERROR;
+ 
+-                    if (httpNotFound || forbidden || notEnoughSpace || wrongFileType || httpGone || httpBadReq ) {
++                    if (httpNotFound || forbidden || notEnoughSpace || wrongFileType
++                            || httpGone || httpBadReq || ioError || connectError) {
+                         try {
+                             DBWriter.saveFeedItemAutoDownloadFailed(item).get();
+                         } catch (ExecutionException | InterruptedException e) {","This now checks nearly all errors that can occur. How about explicitly listing cases where we want it to retry? I think there are not many cases where we want that, as the many added conditions in the last years show :)",I think it would be better to use a switch statement here.
+3109,"@@ -247,7 +247,8 @@ func (brq *blockRetrievalQueue) PutInCaches(ctx context.Context,
+ 
+ // checkCaches copies a block into `block` if it's in one of our caches.
+ func (brq *blockRetrievalQueue) checkCaches(ctx context.Context,
+-	kmd KeyMetadata, ptr BlockPointer, block Block) (PrefetchStatus, error) {
++	kmd KeyMetadata, ptr BlockPointer, block Block, doSync bool) (
++	PrefetchStatus, error) {
+ 	// Attempt to retrieve the block from the cache. This might be a specific
+ 	// type where the request blocks are CommonBlocks, but that direction can
+ 	// Set correctly. The cache will never have CommonBlocks.",Can you make this accept an action instead?,nit: `doSync` is unused (from `unparam`)
+3110,"@@ -33,3 +33,16 @@ When /^I should see an image with name ""([^""]*)""$/ do |image_name|
+   page.should have_selector(""img"", src: /#{image_name}/)
+ end
+ 
++When /^a product named ""([^""]*)""$/ do |product_name|
++   create(:product, fulfillment_method: ""fetch"", name: product_name, product_type: ""screencast"")
++end
++
++When /^a video download product named ""([^""]*)""$/ do |product_name|
++   product = create(:product, fulfillment_method: ""fetch"", name: product_name, product_type: ""screencast"")
++   create(:download, download_file_name: ""test.txt"", description: ""test desc"", product: product)
++   create(:video, product: product)
++end
++
++Given /^there is a github product named ""([^""]*)""$/ do |product_name|
++  create(:product, fulfillment_method: ""github"", name: product_name, product_type: ""book"")
++end",Tab inconsistency here (3 spaces instead of 2 spaces),Prefer single-quoted strings when you don't need string in
+3111,"@@ -56,14 +56,15 @@ func defaultConfig() Genesis {
+ 			EnableGravityChainVoting: true,
+ 		},
+ 		Rewarding: Rewarding{
+-			InitBalanceStr:                 unit.ConvertIotxToRau(1200000000).String(),
++			InitBalanceStr:                 unit.ConvertIotxToRau(200000000).String(),
+ 			BlockRewardStr:                 unit.ConvertIotxToRau(16).String(),
+-			EpochRewardStr:                 unit.ConvertIotxToRau(300000).String(),
++			EpochRewardStr:                 unit.ConvertIotxToRau(12500).String(),
++			AleutianEpochRewardStr:         unit.ConvertIotxToRau(15000).String(),
+ 			NumDelegatesForEpochReward:     100,
+ 			ExemptAddrStrsFromEpochReward:  []string{},
+-			FoundationBonusStr:             unit.ConvertIotxToRau(2880).String(),
++			FoundationBonusStr:             unit.ConvertIotxToRau(80).String(),
+ 			NumDelegatesForFoundationBonus: 36,
+-			FoundationBonusLastEpoch:       365,
++			FoundationBonusLastEpoch:       8760,
+ 		},
+ 	}
+ }",these change means we are changing epoch to 1 hour?,Why are we changing this?
+3112,"@@ -46,6 +46,11 @@ import core
+ import keyboardHandler
+ import characterProcessing
+ from . import guiHelper
++
++#: The size that settings panel text descriptions should be wrapped at.
++# Ensure self.scaleSize is used to adjust for OS scaling adjustments.
++PANEL_DESCRIPTION_WIDTH = 544
++
+ try:
+ 	import updateCheck
+ except RuntimeError:",Why this is defined in the middle of imports?,Why is this needed?
+3113,"@@ -14,8 +14,10 @@
+ # limitations under the License.
+ #
+ 
++import importlib
+ from distutils.version import LooseVersion
+ 
++_backends = {}
+ import matplotlib
+ import numpy as np
+ import pandas as pd",Could you move this to the original position?,Why do we need this
+3114,"@@ -160,7 +160,7 @@ func (s *Source) Owner() (string, error) {
+ 	if err != nil {
+ 		return """", err
+ 	}
+-	return oAndR.repo, nil
++	return oAndR.owner, nil
+ }
+ 
+ // PipelineStage represents configuration for each deployment stage",Is there a test that'd have caught this?,Should this be `oAn
+3115,"@@ -419,7 +419,7 @@ func (s *VisibilityPersistenceSuite) TestFilteringByType() {
+ 
+ 	// List open with filtering
+ 	resp, err2 := s.VisibilityMgr.ListOpenWorkflowExecutionsByType(&visibility.ListWorkflowExecutionsByTypeRequest{
+-		ListWorkflowExecutionsRequest: visibility.ListWorkflowExecutionsRequest{
++		ListWorkflowExecutionsRequest: &visibility.ListWorkflowExecutionsRequest{
+ 			NamespaceID:       testNamespaceUUID,
+ 			PageSize:          2,
+ 			EarliestStartTime: startTime,",ListWorkflowExecutionsRequest <- this can be nil?,why do we need this
+3116,"@@ -809,10 +809,14 @@ module Beaker
+       # This wraps the method `stub_hosts_on` and makes the stub specific to
+       # the forge alias.
+       #
++      # forge api v1 canonical source is forge.puppetlabs.com
++      # forge api v3 canonical source is forgeapi.puppetlabs.com
++      #
+       # @param machine [String] the host to perform the stub on
+       def stub_forge_on(machine)
+         @forge_ip ||= Resolv.getaddress(forge)
+         stub_hosts_on(machine, 'forge.puppetlabs.com' => @forge_ip)
++        stub_hosts_on(machine, 'forgeapi.puppetlabs.com' => @forge_ip)
+       end
+ 
+       # This wraps the method `stub_hosts` and makes the stub specific to","Do we need to continue to support the old link, or is it dead dead dead?",Should this be `forgeapi.puppetlabs.com`?
+3117,"@@ -108,6 +108,14 @@ namespace Datadog.Trace.Configuration
+             GlobalTags = GlobalTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
+                                    .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
+ 
++            HeaderTags = source?.GetDictionary(ConfigurationKeys.HeaderTags) ??
++                         // default value (empty)
++                         new ConcurrentDictionary<string, string>();
++
++            // Filter out tags with empty keys or empty values, and trim whitespace
++            HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
++                                   .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
++
+             DogStatsdPort = source?.GetInt32(ConfigurationKeys.DogStatsdPort) ??
+                             // default value
+                             8125;",Do we need `ConcurrentDictionary`? `Dictionary` can be safely read from multiple threads. See `GlobalTags`.,Why do we need a ConcurrentDictionary her
+3118,"@@ -325,10 +325,12 @@ func validateRegisteredAttributes(expectedAttributes, actualAttributes []*ecs.At
+ }
+ 
+ func (client *APIECSClient) getAdditionalAttributes() []*ecs.Attribute {
++	osFamilyStr := config.GetOSFamilyType()
++	seelog.Infof(""Server OSFamily string: %s"", osFamilyStr)
+ 	return []*ecs.Attribute{
+ 		{
+ 			Name:  aws.String(""ecs.os-type""),
+-			Value: aws.String(config.OSType),
++			Value: aws.String(osFamilyStr),
+ 		},
+ 	}
+ }",this seems like more of a Debugf statement,"This should be `seelog.Infof(""Server OSFa"
+3119,"@@ -972,10 +972,11 @@ void CoreChecks::RecordBarrierArrayValidationInfo(const char *func_name, CMD_BUF
+             bool mode_concurrent = handle_state ? handle_state->createInfo.sharingMode == VK_SHARING_MODE_CONCURRENT : false;
+             if (!mode_concurrent) {
+                 const auto typed_handle = BarrierTypedHandle(barrier);
+-                cb_state->eventUpdates.emplace_back(
+-                    [this, func_name, cb_state, typed_handle, src_queue_family, dst_queue_family](VkQueue queue) {
+-                        return ValidateConcurrentBarrierAtSubmit(queue, func_name, cb_state, typed_handle, src_queue_family,
+-                                                                 dst_queue_family);
++                cb_state->queue_submit_functions.emplace_back(
++                    [func_name, cb_state, typed_handle, src_queue_family, dst_queue_family](
++                        const ValidationStateTracker *device_data, const QUEUE_STATE *queue_state) {
++                        return ValidateConcurrentBarrierAtSubmit(device_data, queue_state, func_name, cb_state, typed_handle,
++                                                                 src_queue_family, dst_queue_family);
+                     });
+             }
+         }","We're capturing cb_state non-const, but the function is const so, safe enough, but after going to reader/writer locks we're all going to have to key a careful eye on anything in this pattern.",Why do we need to pass `device_data` here
+3120,"@@ -194,6 +194,12 @@ func (c *AwsEndpointDiscoveryTest) TestDiscoveryIdentifiersRequiredRequest(input
+ 
+ 	output = &TestDiscoveryIdentifiersRequiredOutput{}
+ 	req = c.newRequest(op, input, output)
++
++	// if a custom endpoint is provided for the request,
++	// we skip endpoint discovery workflow
++	if req.Config.Endpoint != nil {
++		return
++	}
+ 	de := discovererDescribeEndpoints{
+ 		Required:      true,
+ 		EndpointCache: c.endpointCache,",Probably want to wrap the endpoint discovery work that follows in this `if` statement instead of returning early. This will make it easier to add additional request code generation logic in the future. e.g. if we add any code generation after the endpoint discovery block this check will cause it to be skipped.,Why do we need this?
+3121,"@@ -80,7 +80,7 @@ describe('debug', () => {
+ 	it('should print an error on double jsx conversion', () => {
+ 		let Foo = <div />;
+ 		let fn = () => render(h(<Foo />), scratch);
+-		expect(fn).to.throw(/createElement/);
++		expect(fn).to.throw(/JSX twice/);
+ 	});
+ 
+ 	it('should add __source to the vnode in debug mode.', () => {",This test was giving a false positive because my change caused it to throw a different error that contained `createElement` when it should've been throwing this error. Caught this by looking at the code coverage and noticing that the line under the condition I changed was no longer covered lol.,Why did you change t
+3122,"@@ -40,3 +40,8 @@ func (i *Initializer) initHostNetworkFlows() error {
+ func (i *Initializer) getTunnelPortLocalIP() net.IP {
+ 	return nil
+ }
++
++// registerServiceforOS returns immediately on Linux.
++func (i *Initializer) registerServiceforOS() error {
++	return  nil
++}","I think this is added to wrong file. You wanted to add to cmd/agent/, right?",Why is this needed?
+3123,"@@ -348,10 +348,12 @@ public class ExpectedConditions {
+                                                                     final String text) {
+ 
+     return new ExpectedCondition<Boolean>() {
++      private String elementText = null;
++
+       @Override
+       public Boolean apply(WebDriver driver) {
+         try {
+-          String elementText = element.getText();
++          elementText = element.getText();
+           return elementText.contains(text);
+         } catch (StaleElementReferenceException e) {
+           return null;","Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal.",Why is this needed?
+3124,"@@ -117,6 +117,7 @@ type NetworkConfig struct {
+ 	CNIVersion string          `json:""cniVersion,omitempty""`
+ 	Name       string          `json:""name,omitempty""`
+ 	Type       string          `json:""type,omitempty""`
++	DeviceID   string          `json:""deviceID""` // PCI address of a VF
+ 	MTU        int             `json:""mtu,omitempty""`
+ 	DNS        cnitypes.DNS    `json:""dns""`
+ 	IPAM       ipam.IPAMConfig `json:""ipam,omitempty""`","Could we consider a more explicit name, like `devicePciAddress`?",Why do we need this?
+3125,"@@ -109,10 +109,14 @@ public class WindowsUtils {
+      * quote (\""?)
+      */
+     // TODO We should be careful, in case Windows has ~1-ified the executable name as well
+-    pattern.append(""\""?.*?\\\\"");
+-    pattern.append(executable.getName());
++    pattern.append(""(\""?.*?\\\\)?"");
++    String execName = executable.getName();
++    pattern.append(execName);
++    if (!execName.endsWith("".exe"")) {
++      pattern.append(""(\\.exe)?"");
++    }
+     pattern.append(""\""?"");
+-    for (String arg : cmdarray) {
++    for (int i = 1; i < cmdarray.length; i++) {
+       /*
+        * There may be a space, but maybe not (\\s?), may be a quote or maybe not (\""?), but then
+        * turn on block quotation (as if *everything* had a regex backslash in front of it) with \Q.",Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it.,Why is this needed?
+3126,"@@ -610,8 +610,9 @@ class SolrService extends \Apache_Solr_Service
+             $solrconfigXmlUrl = $this->_scheme . '://'
+                 . $this->_host . ':' . $this->_port
+                 . $this->_path . 'admin/file/?file=solrconfig.xml';
++            $response= $this->_sendRawGet($solrconfigXmlUrl);
+ 
+-            $solrconfigXml = simplexml_load_file($solrconfigXmlUrl);
++            $solrconfigXml = simplexml_load_string($response->getRawResponse());
+             if ($solrconfigXml === false) {
+                 throw new \InvalidArgumentException('No valid xml response from schema file: ' . $solrconfigXmlUrl);
+             }",Is this supposed to be part of this PR?,Why did you change t
+3127,"@@ -17,6 +17,13 @@ const getHasListItem = (hasListItem, tagName, isListItemRole) => {
+ 	return hasListItem || (tagName === 'LI' && isListItemRole) || isListItemRole;
+ };
+ 
++const getIsHidden = actualNode => {
++	return (
++		window.getComputedStyle(actualNode, null).getPropertyValue('display') ===
++		'none'
++	);
++};
++
+ let base = {
+ 	badNodes: [],
+ 	isEmpty: true,","DRY, worth extracting this method to axe.utils",I'm not sure if this
+3128,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher,Why do we need this?
+3129,"@@ -142,9 +142,14 @@ class KeyConfigParser(QObject):
+     def save(self):
+         """"""Save the key config file.""""""
+         log.destroy.debug(""Saving key config to {}"".format(self._configfile))
+-        with qtutils.savefile_open(self._configfile, encoding='utf-8') as f:
+-            data = str(self)
+-            f.write(data)
++
++        try:
++            with qtutils.savefile_open(self._configfile,
++                                       encoding='utf-8') as f:
++                data = str(self)
++                f.write(data)
++        except OSError as e:
++            message.error(""Could not save key config: {}"".format(e))
+ 
+     @cmdutils.register(instance='key-config', maxsplit=1, no_cmd_split=True,
+                        no_replace_variables=True)","`QtOSError` inherits `OSError`, so I don't think it's needed to list them both here.",This should be `mess
+3130,"@@ -228,7 +228,6 @@ func (t *Transport) startSubscriber(ctx context.Context, sub subscriptionWithTop
+ 	}
+ 	// Ok, ready to start pulling.
+ 	err := conn.Receive(ctx, func(ctx context.Context, m *pubsub.Message) {
+-		logger.Info(""got an event!"")
+ 		msg := &Message{
+ 			Attributes: m.Attributes,
+ 			Data:       m.Data,","Instead of patching vendor, let's update the version of sdk-go to a more recent one that doesn't have this line.",Why was this removed
+3131,"@@ -185,6 +185,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Please.DownloadLocation = ""https://get.please.build""
+ 	config.Please.NumOldVersions = 10
+ 	config.Parse.BuiltinPleasings = true
++	config.Parse.BuildFileName = []string{""BUILD""}
+ 	config.Build.Arch = cli.NewArch(runtime.GOOS, runtime.GOARCH)
+ 	config.Build.Lang = ""en_GB.UTF-8"" // Not the language of the UI, the language passed to rules.
+ 	config.Build.Nonce = ""1402""       // Arbitrary nonce to invalidate config when needed.",Don't think this should be here. The default is set somewhere else.,Why is this needed?
+3132,"@@ -1229,7 +1229,13 @@ class CloudTaurusTest(BaseCloudTest):
+     def stop_test(self):
+         if self.master:
+             self.log.info(""Ending cloud test..."")
+-            self.master.stop()
++            if not self._last_status:
++                self.get_master_status()
++
++            if self._last_status[""progress""] >= 100:
++                self.master.stop()
++            else:
++                self.master.terminate()
+ 
+     def get_test_status_text(self):
+         if not self._sessions:","Not really important in this PR, but does BlazeMeter describe ""progress"" values anywhere? It might be nice to have a set of constants like `PROGRESS_DOWNLOADING_IMAGE`, `PROGRESS_BOOTING`, `PROGRESS_RUNNING_TEST`, etc in our BZA client.",I'm not sure if this is the best way to do this. I think it would be better to do this in the `get_master_status` method.
+3133,"@@ -124,6 +124,14 @@ public interface ContentFile<F> {
+    */
+   List<Integer> equalityFieldIds();
+ 
++  /**
++   * Returns the sort order id of this file, which describes how the file is ordered.
++   * This information will be useful for merging data and equality delete files more efficiently
++   * when they share the same sort order id.
++   */
++  default Integer sortOrderId() {
++    return null;
++  }
+ 
+   /**
+    * Copies this file. Manifest readers can reuse file instances; use",nit: `<p>` after the line,Why not return an empty list?
+3134,"@@ -228,6 +228,7 @@ setup(
+ 		(""libArm64/%s""%version, glob(""libArm64/*.dll"") + glob(""libArm64/*.exe"")),
+ 		(""waves"", glob(""waves/*.wav"")),
+ 		(""images"", glob(""images/*.ico"")),
++		(""fonts"", glob(""fonts/*.ttf"")),
+ 		(""louis/tables"",glob(""louis/tables/*"")),
+ 		(""COMRegistrationFixes"", glob(""COMRegistrationFixes/*.reg"")),
+ 		(""."", glob(""../miscDeps/python/*.dll"")),","Should we include the files with otf extension here, too? If not, I wonder why we do allow them in the source but we don't include them as per the setup",I think this should be `fonts/*.ttf`
+3135,"@@ -33,9 +33,6 @@ func (uq *uniQueue) enque(blk *peerBlock) {
+ }
+ 
+ func (uq *uniQueue) dequeAll() []*peerBlock {
+-	if len(uq.blocks) == 0 {
+-		return nil
+-	}
+ 	blks := uq.blocks
+ 	uq.blocks = []*peerBlock{}
+ 	uq.hashes = map[hash.Hash256]bool{}",i think it's OK to leave this?,Why is this removed?
+3136,"@@ -30,7 +30,7 @@ import org.apache.flink.table.types.logical.SymbolType;
+ import org.apache.flink.table.types.logical.YearMonthIntervalType;
+ import org.apache.flink.table.types.logical.ZonedTimestampType;
+ 
+-abstract class FlinkTypeVisitor<T> implements LogicalTypeVisitor<T> {
++public abstract class FlinkTypeVisitor<T> implements LogicalTypeVisitor<T> {
+ 
+   // ------------------------- Unsupported types ------------------------------
+ ","Does this need to be public? The only reference to `FlinkTypeVisitor` that I see in this PR is here, so I'm not sure why this is needed.",Why do we need this change?
+3137,"@@ -3,11 +3,11 @@ WELCOME_DIALOG_TEXT = (
+ 	""down the NVDA key while pressing other keys. By default, the numpad Insert and main Insert keys ""
+ 	""may both be used as the NVDA key. You can also configure NVDA to use the Caps Lock as the NVDA ""
+ 	""key. Press NVDA plus n at any time to activate the NVDA menu. From this menu, you can configure ""
+-	""NVDA, get help and access other NVDA functions.\n""
+-	""Options  grouping\n""
++	""NVDA, get help and access other NVDA functions.  \n""
++	""Options  grouping  \n""
+ 	""Keyboard layout:  combo box  desktop  collapsed  Alt plus k""
+ )
+ QUIT_DIALOG_TEXT = (
+-	""Exit NVDA  dialog\n""
++	""Exit NVDA  dialog  \n""
+ 	""What would you like to do?  combo box  Exit  collapsed  Alt plus d""
+ )",No line at end of file warning,Why the \n?
+3138,"@@ -24,6 +24,8 @@ namespace Nethermind.Blockchain.Processing
+ {
+     public class OneTimeChainProcessor : IBlockchainProcessor
+     {
++        public CompositeBlockTracerFactory BlockTracerFactory { get; } = new();
++
+         private readonly IBlockchainProcessor _processor;
+         private readonly IReadOnlyDbProvider _readOnlyDbProvider;
+ ","This looks unused, shouldn't it point to inner processor in any way?",namespace Stratis.Bitcoin
+3139,"@@ -6995,11 +6995,6 @@ NABoolean RelRoot::isUpdatableBasic(NABoolean isView,
+   // QSTUFF
+ 
+     {
+-      // if child is a FirstN node, skip it.
+-      if ((child(0)->castToRelExpr()->getOperatorType() == REL_FIRST_N) &&
+-	  (child(0)->child(0)))
+-	scan = (Scan *)child(0)->child(0)->castToRelExpr();
+-      else
+ 	scan = (Scan *)child(0)->castToRelExpr();
+     }
+ ","There may be a few isolated cases where the FirstN node is added during preCodeGen. Please see GenPreCode.cpp RelRoot::preCodeGen(). The example given there about Order by where sort is added in optimizer, or a FirstN where the N value is to be specified with a param seem to be cases where we would add the FirstN later. Will current change cause such views to marked as updateable? This is minor and could be resolved later, if any change is necessary.",Why is this removed?
+3140,"@@ -213,4 +213,14 @@ public class GoSurfaceNamer extends SurfaceNamer {
+   public String getCreateStubFunctionName(Interface service) {
+     return getGrpcClientTypeName(service).replace(""."", "".New"");
+   }
++
++  @Override
++  public String getStaticLangStreamingReturnTypeName(Method method, MethodConfig methodConfig) {
++    // Unsafe string manipulation: The name looks like ""LibraryService_StreamShelvesClient"",
++    // neither camel or underscore.
++    return String.format(
++        ""%s_%sClient"",
++        converter.getTypeName(method.getParent()).getNickname(),
++        method.getSimpleName());
++  }
+ }","I think you should compose the %sClient part using the Name class, and then do the remaining composition with plain concatenation. Side question: why does the return type name look like it is a client type name?",Why do we need this method? Can't we just use `getGrpcClientTypeName`?
+3141,"@@ -63,6 +63,8 @@ storiesOf( 'PageSpeed Insights Module/Components', module )
+ 				<DashboardPageSpeedWidget { ...widgetComponentProps } />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} )
+ 	.add( 'Dashboard widget (loading)', () => {
+ 		freezeFetch( /^\/google-site-kit\/v1\/modules\/pagespeed-insights\/data\/pagespeed/ );",All stories in this file also need the default padding.,Why do we need this?
+3142,"@@ -26,13 +26,14 @@ using Microsoft.AspNetCore.TestHost;
+ using Microsoft.Extensions.DependencyInjection;
+ using Microsoft.Extensions.Hosting;
+ using OpenTelemetry.Metrics;
++using OpenTelemetry.Tests;
+ using Xunit;
+ 
+ namespace OpenTelemetry.Exporter.Prometheus.Tests
+ {
+     public sealed class PrometheusExporterMiddlewareTests
+     {
+-        private const string MeterName = ""PrometheusExporterMiddlewareTests.Meter"";
++        private static readonly string MeterName = Utils.GetCurrentMethodName();
+ 
+         [Fact]
+         public async Task PrometheusExporterMiddlewareIntegration()",Curious - what would be the actual value?  ,Why this change?
+3143,"@@ -168,7 +168,8 @@ def main():
+         # checkpoints as meta data
+         cfg.checkpoint_config.meta = dict(
+             mmdet_version=__version__ + get_git_hash()[:7],
+-            CLASSES=datasets[0].CLASSES)
++            CLASSES=datasets[0].CLASSES,
++            PALETTE=datasets[0].PALETTE)
+     # add an attribute for visualization convenience
+     model.CLASSES = datasets[0].CLASSES
+     train_detector(",Is it necessary to record the palette in the checkpoint? Any reason?,why do we need this?
+3144,"@@ -3,9 +3,10 @@ import listenbrainz.webserver
+ import pika
+ import time
+ import threading
++import socketio
+ 
+ from flask import current_app
+-
++from listenbrainz.webserver.views.api_tools import LISTEN_TYPE_PLAYING_NOW, LISTEN_TYPE_IMPORT
+ 
+ class FollowDispatcher(threading.Thread):
+ ",Not sure how to best do this without creating a new connection to the server everytime. Do this in another thread?,F401 'SOCKETIO' imported but unused
+3145,"@@ -167,6 +167,13 @@ describe Ncr::WorkOrder do
+       user = create(:user, client_slug: 'ncr')
+       expect(wo.slug_matches?(user)).to eq(true)
+     end
++
++    it ""identifies eligible observers"" do
++      wo = create(:ba80_ncr_work_order)
++      user = create(:user, client_slug: 'ncr')
++      expect(wo.proposal.eligible_observers.to_a).to include(user)
++      expect(wo.proposal.eligible_observers.to_a).to_not include(wo.observers)
++    end
+   end
+ 
+   describe '#organization' do",should we have a similar test for gsa18f procurements?,I don't think we need to test for `
+3146,"@@ -113,9 +113,9 @@ func TestProtocol_HandleTransfer(t *testing.T) {
+ 			GasLimit:    testutil.TestGasLimit,
+ 		})
+ 
+-		sender, err := accountutil.AccountState(sm, v.caller.String())
++		sender, err := accountutil.AccountState(sm, v.caller)
+ 		require.NoError(err)
+-		recipient, err := accountutil.AccountState(sm, v.recipient)
++		recipient, err := accountutil.AccountStateByHash160(sm, v.recipient)
+ 		require.NoError(err)
+ 		gasFee := new(big.Int).Mul(v.gasPrice, new(big.Int).SetUint64(gas))
+ ","change `v.recipient` to address.Address, so can use `AccountState(v,recipient)`",Why this change?
+3147,"@@ -0,0 +1,6 @@
++class NcrDispatcher < LinearDispatcher
++
++  def requires_approval_notice? approval
++    approval.cart_approvals.approvable.order('position ASC').last == approval
++  end
++end",Open to doing away with this altogether and maybe injecting this logic somehow into `requires_approval_notice?` in LinearDispatcher.,I think this should be `order('posi
+3148,"@@ -26,6 +26,12 @@ namespace Nethermind.JsonRpc
+         [ConfigItem(Description = ""Host for JSON RPC calls. Ensure the firewall is configured when enabling JSON RPC. If it does not work with 117.0.0.1 try something like 10.0.0.4 or 192.168.0.1"", DefaultValue = ""\""127.0.0.1\"""")]
+         string Host { get; set; }
+ 
++        [ConfigItem(Description = ""Defines whether the JSON RPC tracers will have timeout enabled. Default timeout is 5 seconds per tracer usage."", DefaultValue = ""false"")]
++        bool TracerTimeoutEnabled { get; set; }
++
++        [ConfigItem(Description = ""JSON RPC tracers' timeout value given in seconds."", DefaultValue = ""5"")] 
++        int TracerTimeout { get; set; }
++
+         [ConfigItem(Description = ""Base file path for diagnostic JSON RPC recorder."", DefaultValue = ""\""logs/rpc.log_1.txt\"""")]
+         string RpcRecorderBaseFilePath { get; set; }
+ ","remove this and always enable tracer, just set the default timeout to something higher (20 seconds)",This should be a `TimeSpan` not a `string`.
+3149,"@@ -39,6 +39,7 @@ public class ScriptDTO {
+     private final Boolean free;
+     private final Boolean requiresPatch;
+     private final String script;
++    private final URI icon;
+ 
+     private ScriptDTO(Builder builder) {
+         this.scriptName = builder.scriptName;",Can we give this field a more descriptive name? When I use a variable named `icon` I normally expect an `Image` object.,I think this should be called `iconUrl`
+3150,"@@ -333,6 +333,13 @@ var opts struct {
+ 				Targets []core.BuildLabel `positional-arg-name:""targets"" description:""Targets to query"" required:""true""`
+ 			} `positional-args:""true""`
+ 		} `command:""roots"" description:""Show build labels with no dependents in the given list, from the list.""`
++		Filter struct {
++			IncludeLabels    []string `long:""in"" description:""Include any targets with matching labels""`
++			ExcludeLabels    []string `long:""ex"" description:""Exclude any targets with matching labels""`
++			Args struct {
++				Targets []core.BuildLabel `positional-arg-name:""targets"" description:""Targets to filter""`
++			} `positional-args:""true""`
++		} `command:""filter"" description:""Filter the given set of targets according to some rules""`
+ 	} `command:""query"" description:""Queries information about the build graph""`
+ }
+ ",can't these just use the global `include` and `exclude` flags?,I think this should be `targets` instead of
+3151,"@@ -28,7 +28,7 @@ def bbox2delta(proposals, gt, means=[0, 0, 0, 0], stds=[1, 1, 1, 1]):
+     stds = deltas.new_tensor(stds).unsqueeze(0)
+     deltas = deltas.sub_(means).div_(stds)
+ 
+-    return deltas
++    return deltas.cuda()
+ 
+ 
+ def delta2bbox(rois,",Is this still necessary?,Why is this necessary?
+3152,"@@ -52,7 +52,7 @@ namespace Examples.Console
+                 .AddPrometheusExporter(opt =>
+                 {
+                     opt.StartHttpListener = true;
+-                    opt.HttpListenerPrefixes = new string[] { $""http://*:{port}/"" };
++                    opt.HttpListenerPrefixes = new string[] { $""http://localhost:{port}/"" };
+                 })
+                 .Build();
+ ",Interesting! Happen to catch an exception message or anything I can look into?,Why is this change needed?
+3153,"@@ -103,15 +103,10 @@ Promise.prototype.error = function (err) {
+  * @api public
+  */
+ 
+-Promise.prototype.resolve = function (err, val) {
+-  if (err) return this.error(err);
+-  return this.fulfill(val);
+-}
+-
+ /**
+  * Adds a single function as a listener to both err and complete.
+  *
+- * It will be executed with traditional node.js argument position when the promise is resolved. 
++ * It will be executed with traditional node.js argument position when the promise is resolved.
+  *
+  *     promise.addBack(function (err, args...) {
+  *       if (err) return handleError(err);",did this get moved to mpromise? I don't recall if it's in that lib or not.,Why is this removed?
+3154,"@@ -81,14 +81,16 @@ type ProviderModeConfig struct {
+ type ConsumerConfig struct {
+ 	PublicKey string `json:""PublicKey""`
+ 	// IP is needed when provider is behind NAT. In such case provider parses this IP and tries to ping consumer.
+-	IP string `json:""IP,omitempty""`
++	IP    string `json:""IP,omitempty""`
++	Ports []int  `json:""Ports""`
+ }
+ 
+ // ServiceConfig represent a Wireguard service provider configuration that will be passed to the consumer for establishing a connection.
+ type ServiceConfig struct {
+ 	// LocalPort and RemotePort are needed for NAT hole punching only.
+-	LocalPort  int `json:""-""`
+-	RemotePort int `json:""-""`
++	LocalPort  int   `json:""-""`
++	RemotePort int   `json:""-""`
++	Ports      []int `json:""ports""`
+ 
+ 	Provider struct {
+ 		PublicKey string",json objects should be `camelCase`,Why do we need this?
+3155,"@@ -0,0 +1,11 @@
++package types
++
++// SectorSize is the amount of bytes in a sector. This amount will be slightly
++// greater than the number of user bytes which can be written to a sector due to
++// bit-padding.
++type SectorSize uint64
++
++const (
++	OneKiBSectorSize = SectorSize(iota)
++	TwoHundredFiftySixMiBSectorSize
++)",QuarterGiBSectorSize? SectorSize265MiB? Spelling out 256 seems overly verbose.,Nit: `TwoHundredFiftySixMi
+3156,"@@ -23,10 +23,11 @@ using System.Linq;
+ using Microsoft.Extensions.Logging;
+ using OpenTelemetry.Exporter;
+ using OpenTelemetry.Logs;
++using OpenTelemetry.Tests;
+ using OpenTelemetry.Trace;
+ using Xunit;
+ 
+-namespace OpenTelemetry.Tests.Logs
++namespace OpenTelemetry.Logs.Tests
+ {
+     public sealed class LogRecordTest : IDisposable
+     {",Maybe with this change we can remove `using OpenTelemetry.Logs`.,Why did you change this?
+3157,"@@ -164,9 +164,10 @@ func (h *Handler) handleAddProject(w http.ResponseWriter, r *http.Request) {
+ 	}
+ 
+ 	var (
+-		id            = r.FormValue(""ID"")
+-		description   = r.FormValue(""Description"")
+-		sharedSSOName = r.FormValue(""SharedSSO"")
++		id                  = r.FormValue(""ID"")
++		description         = r.FormValue(""Description"")
++		sharedSSOName       = r.FormValue(""SharedSSO"")
++		viewerRoleAsDefault = r.FormValue(""ViewerRoleAsDefault"") == ""on""
+ 	)
+ 	if id == """" {
+ 		http.Error(w, ""invalid id"", http.StatusBadRequest)",Fix this name too.,I don't think we need th
+3158,"@@ -2018,7 +2018,7 @@ class BibFormatObject(object):
+             # If record is given as parameter
+             self.xml_record = xml_record
+             self.record = create_record(xml_record)[0]
+-            recID = record_get_field_value(self.record, ""001"") or None
++            recID = int(record_get_field_value(self.record, ""001"")) or None
+ 
+         try:
+             assert isinstance(recID, (int, long, type(None))), 'Argument of wrong type!'",why this is an issue?,Why is this change neede
+3159,"@@ -110,9 +110,13 @@ abstract class Type
+         ?string $namespace,
+         array $aliased_classes,
+         ?string $this_class,
+-        bool $allow_self = false
++        bool $allow_self = false,
++        bool $was_static = false
+     ) : string {
+         if ($allow_self && $value === $this_class) {
++            if ($was_static) {
++                return '$this';
++            }
+             return 'self';
+         }
+ ",The condition should be inverse?,Why do we need this?
+3160,"@@ -33,12 +33,16 @@ package azkaban;
+ public class Constants {
+ 
+   // Azkaban Flow Versions
+-  public static final String AZKABAN_FLOW_VERSION_2_0 = ""2.0"";
++  public static final String AZKABAN_FLOW_VERSION = ""Azkaban-Flow-Version"";
++  public static final Double VERSION_2_0 = 2.0;
+ 
+   // Flow 2.0 file suffix
+   public static final String PROJECT_FILE_SUFFIX = "".project"";
+   public static final String FLOW_FILE_SUFFIX = "".flow"";
+ 
++  // Flow 2.0 node type
++  public static final String NODE_TYPE_FLOW = ""flow"";
++
+   // Names and paths of various file names to configure Azkaban
+   public static final String AZKABAN_PROPERTIES_FILE = ""azkaban.properties"";
+   public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";","this seems to be a property key name, so should it be a inside configurationkey.java?",Why do we need this change?
+3161,"@@ -105,7 +105,7 @@ func (v *VolumeDestroy) Execute() ([]byte, error) {
+ 		return nil, err
+ 	}
+ 	// execute command here
+-	return exec.Command(bin.ZFS, v.Command).CombinedOutput()
++	return exec.Command(bin.BASH, ""-c"", v.Command).CombinedOutput()
+ }
+ 
+ // Build returns the VolumeDestroy object generated by builder",G204: Subprocess launching should be audited (from `gosec`),Why is this change needed?
+3162,"@@ -284,6 +284,10 @@ class Task(object):
+         # TODO(erikbern): we should think about a language-agnostic mechanism
+         return self.__class__.__module__
+ 
++    @property
++    def run_on_main_process(self):
++        return False
++
+     _visible_in_registry = True  # TODO: Consider using in luigi.util as well
+ 
+     __not_user_specified = '__not_user_specified'","Please add docs here. And also warn users that this mode should be avoided whenever possible, because any blocking IO will make the keep-alive-thread not run.",Why is this needed?
+3163,"@@ -57,3 +57,18 @@ export function isValidDimensions( dimensions ) {
+ 		return dimension.hasOwnProperty( 'name' ) && typeof dimension.name === 'string';
+ 	} );
+ }
++
++/**
++ * Verifies provided dimensionFilters to make sure they match allowed values found in dimensions.
++ *
++ * @since n.e.x.t
++ *
++ * @param {Object} dimensionFilters The dimension filters to check.
++ * @return {boolean} TRUE if dimension filters are valid, otherwise FALSE.
++ */
++export function isValidDimensionFilters( dimensionFilters ) {
++	// Ensure every dimensionFilter key corresponds to a valid dimension.
++	return Object.keys( dimensionFilters ).every(
++		( dimension ) => typeof dimensionFilters[ dimension ] === 'string'
++	);
++}",We shouldn't require dimension values to be a string. They just need to be scalar values (probably we could check whether it's either a string or a number). Something more important to cover in the validation here though is to ensure that a map of `dimensionName => dimensionValue` is passed. The keys here actually need to be strings. For example someone shouldn't be able to pass an array of values.,I'm not sure if this is the
+3164,"@@ -31,7 +31,8 @@ import (
+ )
+ 
+ var (
+-	_ yarpc.Router = (*MapRouter)(nil)
++	_ yarpc.Router                = (*MapRouter)(nil)
++	_ yarpc.UnaryTransportHandler = &unaryTransportHandler{}
+ )
+ 
+ type serviceProcedure struct {","let's do a pointer cast of nil, similar to the `MapRouter` above",Why do we need this?
+3165,"@@ -280,6 +280,8 @@ abstract class Abstract_Builder implements Builder {
+ 					'default'           => '{ ""mobile"": ""0"", ""tablet"": ""0"", ""desktop"": ""0"" }',
+ 				]
+ 			);
++
++			do_action( 'neve_add_settings_to_hfg_rows', SettingsManager::get_instance(), $row_setting_id, $row_id );
+ 		}
+ 
+ 		SettingsManager::get_instance()->add(","action should use a prefix of `hfg` rather than `neve` as we plan to bootstrap this as a standalone library. Moreover, previously filter/actions used in this library was using the same pattern.",This should be `neve
+3166,"@@ -158,6 +158,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Https.Internal
+                 if ((_options.HttpProtocols & HttpProtocols.Http2) != 0)
+                 {
+                     sslOptions.ApplicationProtocols.Add(SslApplicationProtocol.Http2);
++                    // https://tools.ietf.org/html/rfc7540#section-9.2.1
++                    sslOptions.AllowRenegotiation = false;
+                 }
+ 
+                 if ((_options.HttpProtocols & HttpProtocols.Http1) != 0)",I'm halfway tempted to disable this for all https connections. Do you know of any clients that actually renegotiate for any reason?,Why is this needed?
+3167,"@@ -102,7 +102,7 @@ class presence_of_all_elements_located(object):
+     def __call__(self, driver):
+         return _find_elements(driver, self.locator)
+         
+-class visibility_of_all_elements_located(object):
++class visibility_of_any_elements_located(object):
+     """""" An expectation for checking that there is at least one element visible
+     on a web page.
+     locator is used to find the element",shouldn't **call** return a boolean?,I think this should 
+3168,"@@ -25,9 +25,8 @@ import (
+ )
+ 
+ func ExampleOpenCollection() {
+-	// This example is used in https://gocloud.dev/howto/docstore#dynamodb-ctor.
+-
+-	// import _ ""gocloud.dev/docstore/awsdynamodb""
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/docstore/awsdynamodb""
+ 
+ 	sess, err := session.NewSession()
+ 	if err != nil {",I don't think you need the blank import here. This one uses awsdynamodb directly.,Why is this needed?
+3169,"@@ -121,11 +121,11 @@ public abstract class DeleteFilter<T> {
+     return applyEqDeletes(applyPosDeletes(records));
+   }
+ 
+-  private List<Predicate<T>> applyEqDeletes() {
+-    List<Predicate<T>> isInDeleteSets = Lists.newArrayList();
++  private Predicate<T> buildEqDeletePredicate() {
+     if (eqDeletes.isEmpty()) {
+-      return isInDeleteSets;
++      return null;
+     }
++    Predicate<T> isDeleted = t -> false;
+ 
+     Multimap<Set<Integer>, DeleteFile> filesByDeleteIds = Multimaps.newMultimap(Maps.newHashMap(), Lists::newArrayList);
+     for (DeleteFile delete : eqDeletes) {","I think this should be initialized to `null` instead of a predicate. There is no need to run an extra predicate (with an extra method dispatch for each row in a data file. That's a tight loop so we should do more work here to avoid it. Instead of using `isDeleted.or`, this should test whether `isDeleted` is `null` and either initialize `isDeleted` or call `isDeleted.or`.",nit: rename to `isD
+3170,"@@ -246,6 +246,15 @@ def __build_clangsa_config_handler(args, context):
+     config_handler.compiler_sysroot = context.compiler_sysroot
+     config_handler.system_includes = context.extra_system_includes
+     config_handler.includes = context.extra_includes
++
++    if 'ctu_phases' in args:
++        config_handler.ctu_dir = os.path.join(args.output_path,
++                                              args.ctu_dir)
++        config_handler.ctu_in_memory = args.ctu_in_memory
++        config_handler.log_file = args.logfile
++        config_handler.path_env_extra = context.path_env_extra
++        config_handler.ld_lib_path_extra = context.ld_lib_path_extra
++
+     try:
+         with open(args.clangsa_args_cfg_file, 'rb') as sa_cfg:
+             config_handler.analyzer_extra_arguments = \",What is this and the next entry in config_handler used for?,Why do we need this
+3171,"@@ -244,3 +244,9 @@ func NewWithDefault(keyFilePath string, certFilePath string) (m upstreamca.Upstr
+ 
+ 	return m, err
+ }
++
++func NewEmpty () (m upstreamca.UpstreamCa) {
++	return &memoryPlugin{
++		mtx:&sync.RWMutex{},
++	}
++}","will your editor integrate `gofmt`, `goimports`, etc...?",Why do we need this
+3172,"@@ -78,7 +78,12 @@ public class ProductPhotosFragment extends BaseFragment implements ImagesAdapter
+     public void onViewCreated(@NonNull View view, @Nullable Bundle savedInstanceState) {
+         super.onViewCreated(view, savedInstanceState);
+         Intent intent = getActivity().getIntent();
+-        final State state = (State) intent.getExtras().getSerializable(""state"");
++        State state;
++        if(intent!=null && intent.getExtras()!=null && intent.getExtras().getSerializable(""state"")!=null){
++            state = (State) intent.getExtras().getSerializable(""state"");
++        }else{
++            state = ProductFragment.mState;
++        }
+         product = state.getProduct();
+         mFragment = this;
+         // initialize the arraylist",looks like the code is not properly formatted. for example here are some missing spaces in **if** command. please take care and reformat the code using default android formatting.,I don't think you need the `!=null` check here.
+3173,"@@ -218,6 +218,15 @@ def __add_filtering_arguments(parser, defaults=None, diff_mode=False):
+                          default=init_default('severity'),
+                          help=""Filter results by severities."")
+ 
++    f_group.add_argument('--bug-path-length',
++                         type=str,
++                         dest='bug_path_length',
++                         default=argparse.SUPPRESS,
++                         help=""Filter results by bug path length. This has ""
++                              ""the following format: <minimum_bug_path_length>""
++                              "":<maximum_bug_path_length>. Valid values are: ""
++                              ""\""4:10\"", \""4:\"", \"":10\"""")
++
+     f_group.add_argument('--tag',
+                          nargs='*',
+                          dest=""tag"",","Please add some valid examples to help message like `""4:10""`, `""4:""`, `"":10""`",This should be `--bug-path-length`.
+3174,"@@ -490,7 +490,10 @@ EOS
+         #   end
+         def its(attribute, &block)
+           RSpec.deprecate(""Use of rspec-core's `its` method"", :replacement => 'the rspec-its gem')
+-          describe(attribute) do
++          description = attribute
++          description = description.to_s if Symbol === description
++
++          describe(description) do
+             if Array === attribute
+               let(:__its_subject) { subject[*attribute] }
+             else",Is it only Symbols we're worried about converting? Is it not safe to just call `to_s` anyway?,Why is this needed?
+3175,"@@ -15,9 +15,6 @@ import (
+ 	""github.com/stretchr/testify/require""
+ )
+ 
+-// BlockTimeTest is the block time used by workers during testing
+-const BlockTimeTest = time.Second
+-
+ // MineDelayTest is the mining delay used by schedulers during testing
+ const MineDelayTest = time.Millisecond * 500
+ ",Note for those who come across this later: It was moved to `testhelpers.mining.go` so that `testhelpers.NewDaemon` and the `mining/worker_test.go` can share it.,Why was this removed?
+3176,"@@ -12,7 +12,7 @@ class Practice
+   end
+ 
+   def incomplete_trails
+-    trails.select(&:incomplete?)
++    trails.select(&:incomplete?).partition(&:in_progress?).flatten
+   end
+ 
+   private",What about `sort_by(&:in_progress?)`? Maybe with a `.reverse` thrown in?,"I'm not sure if this is the best way to do this, but I'm not sure if there's a better way."
+3177,"@@ -205,7 +205,6 @@ const (
+ 	FlagTLSKeyPath                        = ""tls_key_path""
+ 	FlagTLSCaPath                         = ""tls_ca_path""
+ 	FlagTLSEnableHostVerification         = ""tls_enable_host_verification""
+-	FlagGRPC                              = ""grpc""
+ )
+ 
+ var flagsForExecution = []cli.Flag{",Flag is removed because it is only gRPC now.,Why is this removed?
+3178,"@@ -38,6 +38,17 @@ class Role(base.Base):
+     .. option:: molecule init role --role-name foo
+ 
+         Initialize a new role.
++
++    .. program:: molecule init role --role-name foo --template path
++
++    .. option:: molecule init role --role-name foo --template path
++
++        Initialize a new role using a local *cookiecutter* template. This
++        allows the customization of a role while still using the default
++        generated ``molecule`` folder. This is similar to an
++        ``ansible-galaxy init`` skeleton. Please refer to the ``init scenario``
++        command in order to customise the default generated ``molecule``
++        folder.
+     """"""
+ 
+     def __init__(self, command_args):","Might be better to rephrase to: Please refer to the ``init scenario`` command in order to generate a custom ``molecule`` scenario. Since you aren't customizing the default scenario since it already exists, right?","I think this should be `--template-path`, not `--template`."
+3179,"@@ -640,9 +640,17 @@ class StdlibChecker(DeprecatedMixin, BaseChecker):
+                     encoding_arg = utils.get_argument_from_call(
+                         node, position=0, keyword=""encoding""
+                     )
++                elif open_module == ""pathlib"" and node.func.attrname == ""write_text"":
++                    encoding_arg = utils.get_argument_from_call(
++                        node, position=1, keyword=""encoding""
++                    )
++                elif open_module == ""pathlib"":
++                    encoding_arg = utils.get_argument_from_call(
++                        node, position=2, keyword=""encoding""
++                    )
+                 else:
+                     encoding_arg = utils.get_argument_from_call(
+-                        node, position=None, keyword=""encoding""
++                        node, position=3, keyword=""encoding""
+                     )
+             except utils.NoSuchArgumentError:
+                 self.add_message(""unspecified-encoding"", node=node)",Shall we merge these `if` for `path lib` and then do the `attrname` one. I'm trying to count `if`-calls and its getting late but I think we can reduce the number checks needed to get into L648 from 3 to 2 if you understand what I mean  ,I don't think this is the right way to handle this. It should be handled by `get_argument_
+3180,"@@ -9,6 +9,7 @@ import (
+ 	""errors""
+ 	""sync""
+ 
++	""github.com/ethersphere/bee/pkg/recovery""
+ 	""github.com/ethersphere/bee/pkg/storage""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ 	""github.com/ethersphere/bee/pkg/tags""",why depend on recovery???,Please remove this empty line.
+3181,"@@ -388,7 +388,7 @@ func initializeDynamicConfig(
+ 
+ 	// the done channel is used by dynamic config to stop refreshing
+ 	// and CLI does not need that, so just close the done channel
+-	doneChan := make(chan struct{})
++	doneChan := make(chan interface{})
+ 	close(doneChan)
+ 	dynamicConfigClient, err := dynamicconfig.NewFileBasedClient(
+ 		&serviceConfig.DynamicConfigClient,","the done channel only aims to be closed, so `chan struct{}` is better then `chan interface{}`",Why is this change needed?
+3182,"@@ -196,7 +196,7 @@ func NewGasPriceOracle(cfg *Config) (*GasPriceOracle, error) {
+ 	address := cfg.gasPriceOracleAddress
+ 	contract, err := bindings.NewGasPriceOracle(address, l2Client)
+ 	if err != nil {
+-		return nil, err
++		return nil, wrapErr(err, ""error creating contract binding"")
+ 	}
+ 
+ 	// Fetch the current gas price to use as the current price",Do you mean to have gas_oracle changes in this PR?,"Why not just `return nil, err`"
+3183,"@@ -1,6 +1,5 @@
+-<%= render Blacklight::System::ModalComponent.new do |component| %>
+-  <% component.title { t('blacklight.email.form.title') } %>
+-
+-  <%= render partial: '/shared/flash_msg' %>
+-  <span data-blacklight-modal=""close""></span>
+-<% end %>
++<turbo-stream action=""append"" target=""main-flashes"">
++  <template>
++    <%= render '/shared/flash_msg' %>
++  </template>
++</turbo-stream>",Is this effectively requiring browsers support javascript?,I think this should be `<%= re
+3184,"@@ -61,10 +61,11 @@ public class FingerprintAuthDialogFragment extends DialogFragment {
+     @Override
+     public void onCreate(Bundle savedInstanceState) {
+         super.onCreate(savedInstanceState);
++        Boolean isDarkTheme = SalesforceSDKManager.getInstance().isDarkTheme(getActivity());
+ 
+         // Do not create a new Fragment when the Activity is re-created such as orientation changes.
+         setRetainInstance(true);
+-        setStyle(DialogFragment.STYLE_NORMAL, android.R.style.Theme_Material_Light_Dialog);
++        setStyle(DialogFragment.STYLE_NORMAL, (isDarkTheme ? R.style.SalesforceSDK_Dialog_Dark : R.style.SalesforceSDK_Dialog));
+     }
+ 
+     @Override",Lowercase `boolean` - use the primitive type.,Shouldn't this be `isDarkTheme`?
+3185,"@@ -174,7 +174,12 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+                 }
+                 else
+                 {
+-                    Log.LogError($""Item '{item}' already exists in {relativeBlobPath}."");
++                    bool blobExists = await feed.CheckIfBlobExists(relativeBlobPath);
++
++                    if (blobExists)
++                    {
++                        Log.LogError($""Item '{item}' already exists in {relativeBlobPath}."");
++                    }
+                 }
+             }
+             catch (Exception exc)",This isn't the correct logic. if allowOverride == true and !blobExists then upload. Just don't do the exist check if allowOverride is set to true.,Shouldn't this be `Log.Error`?
+3186,"@@ -480,12 +480,15 @@ static void read_surface_net_wm_state(struct wlr_xwm *xwm,
+ 	xsurface->fullscreen = 0;
+ 	xcb_atom_t *atom = xcb_get_property_value(reply);
+ 	for (uint32_t i = 0; i < reply->value_len; i++) {
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_FULLSCREEN])
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_FULLSCREEN]) {
+ 			xsurface->fullscreen = true;
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT])
++		}
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_VERT]) {
+ 			xsurface->maximized_vert = true;
+-		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ])
++		}
++		if (atom[i] == xwm->atoms[_NET_WM_STATE_MAXIMIZED_HORZ]) {
+ 			xsurface->maximized_horz = true;
++		}
+ 	}
+ }
+ ",Can you replace these by `else if` please?,Why is this change needed?
+3187,"@@ -0,0 +1,12 @@
++/**
++ * Changes the currently selected date range.
++ *
++ * Currently only identifiable by the option values.
++ *
++ * @param {string} fromRange The currently selected date range.
++ * @param {string} toRange The new date range to select.
++ */
++export async function switchDateRange( fromRange, toRange ) {
++	await expect( page ).toClick( '.mdc-select__selected-text', { text: new RegExp( fromRange, 'i' ) } );
++	await expect( page ).toClick( '.mdc-menu-surface--open .mdc-list-item', { text: new RegExp( toRange, 'i' ) } );
++}","Would be nice if the field had a unique class name that could be used to target it, instead of `fromRange`   But doesn't seem to be a common thing in the code base.",Why do we need to use `new RegEx
+3188,"@@ -30,7 +30,10 @@ var tableGrid = tableUtils.toGrid(node);
+ 
+ // Look for all the bad headers
+ var out = headers.reduce(function (res, header) {
+-	if (header.id && reffedHeaders.indexOf(header.id) !== -1) {
++	if (
++		header.getAttribute('id') &&
++		reffedHeaders.includes(header.getAttribute('id'))
++	) {
+ 		return (!res ? res : true);
+ 	}
+ ",Does this code fit on one line under 80 characters? It would be more consistent with our existing style.,I don't think you need the `.getAttribute('id')` here.
+3189,"@@ -61,8 +61,13 @@ func ParseArtifactListFromMultipleYamls(multipleYamls MultiYamlFetcher) (artifac
+ // installed
+ func RegisteredArtifactsFor070() (list ArtifactList) {
+ 
++	//Note: CRDs have to be installed first. Keep this at top of the list.
++	list.Items = append(list.Items, OpenEBSCRDArtifactsFor070().Items...)
++
+ 	list.Items = append(list.Items, JivaVolumeArtifactsFor070().Items...)
+ 	//Contains the read/list/delete CAST for supporting older volumes
++	//The CAST defined here are provided as fallback options to corresponding
++	//0.7.0 CAST
+ 	list.Items = append(list.Items, JivaVolumeArtifactsFor060().Items...)
+ 	list.Items = append(list.Items, JivaPoolArtifactsFor070().Items...)
+ ",Not a requirement here. But i see a change in naming convention. We can rename the function to `CstorSparsePoolArtifactsFor070`.,I don't think we need this anymore.
+3190,"@@ -0,0 +1,9 @@
++// +build pico
++
++package main
++
++import ""machine""
++
++var (
++	interruptPin = machine.GP10
++)",Why do you configure the UART like this? It's already configured by default.,Why do we need this file?
+3191,"@@ -39,7 +39,8 @@
+ #include ""opae/access.h""
+ #include ""opae/utils.h""
+ #include ""opae/manage.h""
+-#include ""opae/manage.h""
++#include ""opae/enum.h""
++#include ""opae/properties.h""
+ #include ""bitstream_int.h""
+ #include ""common_int.h""
+ #include ""intel-fpga.h""","Wow. Good catch. ""This `#include` was brought to you by the department of redundancy department."" ;)",Why is this header needed?
+3192,"@@ -20,10 +20,11 @@ import (
+ 	""context""
+ 	""time""
+ 
++	""github.com/go-logr/logr""
+ 	""golang.org/x/crypto/acme""
+-	""k8s.io/klog""
+ 
+ 	""github.com/jetstack/cert-manager/pkg/acme/client""
++	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ )
+ 
+ const (","Well it's actually calling `AuthorizeOrder` and this seems like a DebugLevel message to me, maybe it should be dropped entirely.",nit: remove empty line
+3193,"@@ -917,6 +917,7 @@ void *cuda_resize_scratch_space(std::int64_t bytes, bool force_shrink) {
+ 
+ void cuda_prefetch_pointer(const Cuda &space, const void *ptr, size_t bytes,
+                            bool to_device) {
++  if ((ptr == nullptr) || (bytes == 0)) return;
+   cudaPointerAttributes attr;
+   cudaPointerGetAttributes(&attr, ptr);
+   // I measured this and it turns out prefetching towards the host slows",Should this be using the `CUDA_SAFE_CALL` macro here?,I don't think this is 
+3194,"@@ -298,8 +298,8 @@ namespace Xunit.ConsoleClient
+                     {
+                         lock (consoleLock)
+                         {
+-                            Console.ForegroundColor = ConsoleColor.Red;
+-                            Console.WriteLine(""ERROR:       {0} has no tests to run"", Path.GetFileNameWithoutExtension(assembly.AssemblyFilename));
++                            Console.ForegroundColor = ConsoleColor.Yellow;
++                            Console.WriteLine(""Warning:       {0} has no tests to run"", Path.GetFileNameWithoutExtension(assembly.AssemblyFilename));
+                             Console.ForegroundColor = ConsoleColor.Gray;
+                         }
+                     }",What cases do you see as being valid for not having any tests to run? If a test project doesn't have any tests to run we should avoid running it at the project level.,Why did you change thi
+3195,"@@ -1139,6 +1139,10 @@ func (mset *stream) processMirrorMsgs() {
+ 
+ 	// Grab stream quit channel.
+ 	mset.mu.Lock()
++	if mset.mirror == nil {
++		mset.mu.Unlock()
++		return
++	}
+ 	msgs, mch, qch := mset.mirror.msgs, mset.mirror.msgs.mch, mset.qch
+ 	// Set the last seen as now so that we don't fail at the first check.
+ 	mset.mirror.last = time.Now()","and is it possible that mset.mirror.msgs be nil? because if so, then you would get a panic also because of that.",Why is this necessary?
+3196,"@@ -258,6 +258,7 @@ static void surface_move_state(struct wlr_surface *surface,
+ 	}
+ 	if ((next->invalid & WLR_SURFACE_INVALID_OPAQUE_REGION)) {
+ 		// TODO: process buffer
++		pixman_region32_copy(&state->opaque, &next->opaque);
+ 		pixman_region32_clear(&next->opaque);
+ 	}
+ 	if ((next->invalid & WLR_SURFACE_INVALID_INPUT_REGION)) {",`next->opaque` should not be cleared.,Why do we need this copy?
+3197,"@@ -525,6 +525,7 @@ func (s *Server) processClientOrLeafAuthentication(c *client, opts *Options) boo
+ 			c.Debugf(""Account JWT not signed by trusted operator"")
+ 			return false
+ 		}
++		// this only executes IF there's an issuer on the Juc - otherwise the account is already
+ 		if juc.IssuerAccount != """" && !acc.hasIssuer(juc.Issuer) {
+ 			c.Debugf(""User JWT issuer is not known"")
+ 			return false","already what? I know what, but seems like smth. is missing in this sentence",// this only executes IF 
+3198,"@@ -1,6 +1 @@
+-$(""div.card-for-activity"").replaceWith('<%=j render partial: 'proposals/details/activity', locals: {events: @events} %>');
+-$(""div.card-for-activity textarea:first"").focus();
+-$(""#add_a_comment"").attr('disabled', true);
+-$(""div.card-for-activity textarea:first"").on('input',function(){
+-  $(""#add_a_comment"").attr('disabled', false);
+-});
++window.c2.activityCardController.update('<%=j render partial: 'proposals/details/activity', locals: {events: @events} %>');",Can you put spaces after the `{`and before the `}`,I don't think you need th
+3199,"@@ -21,11 +21,12 @@ import logging
+ import logging.handlers
+ import os
+ 
++from google.cloud.forseti import __version__
+ 
+ DEFAULT_LOG_FMT = ('%(asctime)s %(levelname)s '
+                    '%(name)s(%(funcName)s): %(message).1024s')
+ 
+-SYSLOG_LOG_FMT = ('%(levelname)s [forseti-security] '
++SYSLOG_LOG_FMT = ('%(levelname)s [forseti-security] %(__version__)s '
+                   '%(name)s(%(funcName)s): %(message).1024s')
+ 
+ # %(asctime)s is used as the marker by multiline parser to determine",We said we would put `[ ]` around the version. `[forseti-security] [v2.3.0]`,Why do we need this chang
+3200,"@@ -1112,7 +1112,7 @@ func (c *client) flushOutbound() bool {
+ 	}
+ 
+ 	// Check to see if we can reuse buffers.
+-	if len(cnb) > 0 {
++	if len(cnb) > 0 && n >= int64(len(cnb[0])) {
+ 		oldp := cnb[0][:0]
+ 		if cap(oldp) >= int(c.out.sz) {
+ 			// Replace primary or secondary if they are nil, reusing same buffer.",Seems len(cnb[0]) will be the length after the write since of the *v thing we saw no?,Why do we need this change?
+3201,"@@ -37,6 +37,7 @@ var (
+ type QueueLoad struct {
+ 	Key       string
+ 	Operation string
++	Object interface{}
+ }
+ 
+ func Start() error {",can we make use of storagepoolclaim type rather than the generic interface{} type?,Why do we need this?
+3202,"@@ -652,6 +652,8 @@ func (k *Kad) Start(_ context.Context) error {
+ 	k.wg.Add(1)
+ 	go k.manage()
+ 
++	k.AddPeers(k.previouslyConnected()...)
++
+ 	go func() {
+ 		select {
+ 		case <-k.halt:","this should happen before the `go k.manage()`, otherwise the node will always try the bootnodes first",Why do we need this?
+3203,"@@ -185,7 +185,7 @@ Blockly.ScratchBlocks.ProcedureUtils.removeAllInputs_ = function() {
+  */
+ Blockly.ScratchBlocks.ProcedureUtils.createAllInputs_ = function(connectionMap) {
+   // Split the proc into components, by %n, %b, and %s (ignoring escaped).
+-  var procComponents = this.procCode_.split(/(?=[^\\]\%[nbs])/);
++  var procComponents = this.procCode_.split(/(?=[^\\]%[nbs])/);
+   procComponents = procComponents.map(function(c) {
+     return c.trim(); // Strip whitespace.
+   });",Is this actually a lint related change?,Nit: Unrelated whitespace c
+3204,"@@ -15,6 +15,7 @@
+ module Blacklight::Document
+   autoload :ActiveModelShim, 'blacklight/document/active_model_shim'
+   autoload :SchemaOrg, 'blacklight/document/schema_org'
++  autoload :CacheKey, 'blacklight/document/cache_key'
+   autoload :DublinCore, 'blacklight/document/dublin_core'
+   autoload :Email, 'blacklight/document/email'
+   autoload :SemanticFields, 'blacklight/document/semantic_fields'",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Why is this needed?
+3205,"@@ -226,6 +226,12 @@ def opt_str_param(obj, param_name, default=None):
+     return default if obj is None else obj
+ 
+ 
++def opt_nonempty_str_param(obj, param_name, default=None):
++    if obj is not None and not isinstance(obj, string_types):
++        raise_with_traceback(_param_type_mismatch_exception(obj, str, param_name))
++    return default if obj is None or obj == '' else obj
++
++
+ def bool_param(obj, param_name):
+     if not isinstance(obj, bool):
+         raise_with_traceback(_param_type_mismatch_exception(obj, bool, param_name))",what does this do that str_param does not?,I don't think this 
+3206,"@@ -39,6 +39,11 @@ func GRPCDialOption(api string) grpc.DialOption {
+ 	return grpc.WithUserAgent(userAgentString(api))
+ }
+ 
++// AzureUserAgentPrefix returns a prefix that is used to set Azure SDK User-Agent to help with diagnostics.
++func AzureUserAgentPrefix() string {
++	return fmt.Sprintf(""%s/%s"", prefix, version)
++}
++
+ func userAgentString(api string) string {
+ 	return fmt.Sprintf(""%s/%s/%s"", prefix, api, version)
+ }","For GCP we included the API name (see below) so you can distinguish between uses other than `blob` once they exist, WDYT?",Why do we need this
+3207,"@@ -1,6 +1,14 @@
+ import os
+ import pickle
+ 
++from io import BytesIO
++
++try:
++    import boto3
++    import botocore
++except ImportError:
++    pass
++
+ from dagster import check, seven
+ from dagster.utils import mkdir_p
+ ",what would you think about doing this include on-demand within S3ObjectStore methods and then failing in a loud way?,Why do we need this
+3208,"@@ -2777,6 +2777,14 @@ void nano::active_transactions::confirm_frontiers (nano::transaction const & tra
+ 		size_t elections_count (0);
+ 		for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && elections_count < max_elections; ++i)
+ 		{
++			{
++				std::lock_guard<std::mutex> guard (mutex);
++				if (stopped)
++				{
++					break;
++				}
++			}
++
+ 			nano::account_info info (i->second);
+ 			if (info.block_count != info.confirmation_height)
+ 			{","May be better make `stopped` atomic, then it can be just `for (auto i (node.store.latest_begin (transaction_a, next_frontier_account)), n (node.store.latest_end ()); i != n && && !stopped && elections_count < max_elections; ++i)`",Why do we need to lock here?
+3209,"@@ -165,7 +165,7 @@ folly::SemiFuture<StorageRpcResponse<cpp2::ExecResponse>> GraphStorageClient::ad
+       evb,
+       std::move(requests),
+       [=](cpp2::GraphStorageServiceAsyncClient* client, const cpp2::AddEdgesRequest& r) {
+-        return useToss ? client->future_addEdgesAtomic(r) : client->future_addEdges(r);
++        return useToss ? client->future_chainAddEdges(r) : client->future_addEdges(r);
+       });
+ }
+ ","In `src/storage/InternalStorageServiceHandler.h ` file, the client in `client->future_chainAddEdges ` should be InterStorageServiceAsyncClient?",I don't understand this chan
+3210,"@@ -22,6 +22,9 @@ import (
+ 	""strconv""
+ 	""strings""
+ 
++	""github.com/prometheus/prometheus/pkg/rulefmt""
++	thanostypes ""github.com/thanos-io/thanos/pkg/store/storepb""
++
+ 	monitoringv1 ""github.com/prometheus-operator/prometheus-operator/pkg/apis/monitoring/v1""
+ 	namespacelabeler ""github.com/prometheus-operator/prometheus-operator/pkg/namespace-labeler""
+ ",`go.sum` needs to be updated for this. Please run `go mod tidy`,nit: remove empty line
+3211,"@@ -28,6 +28,17 @@ const (
+ 	MachineFinalizer = ""awsmachine.infrastructure.cluster.x-k8s.io""
+ )
+ 
++// SecretBackend defines variants for backend secret storage.
++type SecretBackend string
++
++var (
++	// SecretBackendSSMParameterStore defines AWS Systems Manager Parameter Store as the secret backend
++	SecretBackendSSMParameterStore = SecretBackend(""ssm-parameter-store"")
++
++	// SecretBackendSecretsManager defines AWS Secrets Manager as the secret backend
++	SecretBackendSecretsManager = SecretBackend(""secrets-manager"")
++)
++
+ // AWSMachineSpec defines the desired state of AWSMachine
+ type AWSMachineSpec struct {
+ 	// ProviderID is the unique identifier as specified by the cloud provider.","Not sure if this was discussed previously, but is there a specific use case in mind for having this as an API field rather than a configuration option on the controller manager? Is there a specific use case in mind where one would want to choose different backends for individual Clusters/Machines vs having it a global configuration for an instance of the infrastructure provider?",I don't think this is used a
+3212,"@@ -40,9 +40,11 @@ namespace OpenTelemetry.Metrics
+             var options = new OtlpExporterOptions();
+             configure?.Invoke(options);
+ 
+-            var metricExporter = new OtlpMetricsExporter(options);
+-            var metricReader = new PeriodicExportingMetricReader(metricExporter, options.MetricExportIntervalMilliseconds);
+-            return builder.AddMetricReader(metricReader);
++            // var metricExporter = new OtlpMetricsExporter(options);
++            // var metricReader = new PeriodicExportingMetricReader(metricExporter, options.MetricExportIntervalMilliseconds);
++            // return builder.AddMetricReader(metricReader);
++
++            return builder;
+         }
+     }
+ }",Same thing with the OtlpExporter,Can this be removed?
+3213,"@@ -70,7 +70,6 @@ const char * jx_operator_string( jx_operator_t type )
+ 		case JX_OP_NOT:	return "" not "";
+ 		// note that the closing bracket/paren is in jx_print_subexpr
+ 		case JX_OP_LOOKUP: return ""["";
+-		case JX_OP_CALL: return ""("";
+ 		case JX_OP_SLICE: return "":"";
+ 		default:        return ""???"";
+ 	}",Should not be removed.,Why was this removed
+3214,"@@ -1,17 +1,12 @@
+-[ 'foss', 'puppet', 'ezbake', 'module' ].each do |lib|
+-    require ""beaker/dsl/install_utils/#{lib}_utils""
+-end
+ require ""beaker/dsl/install_utils/pe_defaults""
++require 'beaker-puppet'
+ 
+ module Beaker
+   module DSL
+     # Collection of installation methods and support
+     module InstallUtils
+-      include DSL::InstallUtils::PuppetUtils
+       include DSL::InstallUtils::PEDefaults
+-      include DSL::InstallUtils::FOSSUtils
+-      include DSL::InstallUtils::ModuleUtils
+-      include DSL::InstallUtils::EZBakeUtils
++      include BeakerPuppet::InstallUtils
+     end
+   end
+ end","Not a blocker for anything, but should this be moved to beaker-pe? Is that ticketed anywhere?",Why is this being re
+3215,"@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take
+     }
+ 
+     public void submit() {
++      dispatcher.beforeClickOn(element, driver);
+       element.submit();
++      dispatcher.afterClickOn(element, driver);
+     }
+ 
+     public void sendKeys(CharSequence... keysToSend) {","this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate.",Why is this needed?
+3216,"@@ -119,7 +119,7 @@ module Ncr
+       if self.pending?
+         self.currently_awaiting_approvers.first.email_address
+       else
+-        self.approving_official.email_address
++        self.approving_official ? self.approving_official.email_address : self.system_approver_emails.first
+       end
+     end
+ ",this ternary operator is hiding an `if/else` within an `if/else` - any chance we could move the logic ELSEwhere? (see what I did there -- ?? :100: ),I think this should be `self.system_approver_emails.first.email_address`
+3217,"@@ -4,6 +4,10 @@
+ 
+ package net.sourceforge.pmd.lang.java.typeresolution.typedefinition;
+ 
++import net.sourceforge.pmd.annotation.InternalApi;
++
++@Deprecated
++@InternalApi
+ public interface TypeDefinition {
+     /**
+      * Get the raw Class type of the definition.","Is this really internal? Or will the API be different in PMD 7.0.0? Well, the interface doesn't offer much functionality anyway...",Why is this needed?
+3218,"@@ -86,8 +86,12 @@ class Interface(param.Parameterized):
+ 
+     datatype = None
+ 
++    # Denotes whether the interface expects gridded data
+     gridded = False
+ 
++    # Denotes whether the interface expects multiple ragged arrays
++    multi = False
++
+     @classmethod
+     def register(cls, interface):
+         cls.interfaces[interface.datatype] = interface",Does it have to be arrays? Isn't it ragged 'data' (i.e multiple elements of different lengths)?,I don't think this is needed.
+3219,"@@ -399,6 +399,7 @@ func (oi *OVFImporter) setUpImportWorkflow() (*daisy.Workflow, error) {
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""error parsing workflow %q: %v"", ovfImportWorkflow, err)
+ 	}
++	workflow.ForceCleanupOnError = true
+ 	return workflow, nil
+ }
+ ","Per my understanding, this flag only impacts ""NoCleanup"" disk. If so, we may name it more clear. The reason of this ask is because I plan to add some other flag to force cleanup for other non-NoCleanup disks.",Why do we need this?
+3220,"@@ -40,7 +40,7 @@ import org.apache.spark.sql.util.CaseInsensitiveStringMap;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ 
+-public class SparkStreamingWrite extends SparkBatchWrite implements StreamingWrite {
++class SparkStreamingWrite extends BaseBatchWrite implements StreamingWrite {
+ 
+   private static final Logger LOG = LoggerFactory.getLogger(SparkStreamingWrite.class);
+   private static final String QUERY_ID_PROPERTY = ""spark.sql.streaming.queryId"";","In my changes for `RequiresDistributionAndOrdering`, this class went away and is replaced by an inner class. I think that pattern worked well. Maybe we could do that before this one to reduce the number of changes here.",Why do we need this change?
+3221,"@@ -95,10 +95,10 @@ const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes
+ 	{""magicpointspercent"", ITEM_PARSE_MAGICPOINTSPERCENT},
+ 	{""criticalhitchance"", ITEM_PARSE_CRITICALHITCHANCE},
+ 	{""criticalhitamount"", ITEM_PARSE_CRITICALHITAMOUNT},
+-	{""hitpointsleechchance"", ITEM_PARSE_HITPOINTSLEECHCHANCE},
+-	{""hitpointsleechamount"", ITEM_PARSE_HITPOINTSLEECHAMOUNT},
+-	{""manapointsleechchance"", ITEM_PARSE_MANAPOINTSLEECHCHANCE},
+-	{""manapointsleechamount"", ITEM_PARSE_MANAPOINTSLEECHAMOUNT},
++	{""lifeleechchance"", ITEM_PARSE_LIFELEECHCHANCE},
++	{""lifeleechamount"", ITEM_PARSE_LIFELEECHAMOUNT},
++	{""manaleechchance"", ITEM_PARSE_MANALEECHCHANCE},
++	{""manaleechamount"", ITEM_PARSE_MANALEECHAMOUNT},
+ 	{""fieldabsorbpercentenergy"", ITEM_PARSE_FIELDABSORBPERCENTENERGY},
+ 	{""fieldabsorbpercentfire"", ITEM_PARSE_FIELDABSORBPERCENTFIRE},
+ 	{""fieldabsorbpercentpoison"", ITEM_PARSE_FIELDABSORBPERCENTPOISON},",Shouldn't this be called `hp` instead of `life`?,Why did you change this?
+3222,"@@ -106,7 +106,7 @@ public class BaseServer<T extends BaseServer> implements Server<T> {
+       FilterHolder
+           filterHolder = servletContextHandler.addFilter(CrossOriginFilter.class, ""/*"", EnumSet
+           .of(DispatcherType.REQUEST));
+-      filterHolder.setInitParameter(""allowedOrigins"", ""*"");
++      filterHolder.setInitParameter(""allowedMethods"", ""GET,POST,PUT,DELETE,HEAD"");
+ 
+       // Warning user
+       LOG.warning(""You have enabled CORS requests from any host. ""","Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all.",Why do we need to change th
+3223,"@@ -5757,4 +5757,3 @@ bool Game::reload(ReloadTypes_t reloadType)
+ 	}
+ 	return true;
+ }
+-",Undo this modification,return false;
+3224,"@@ -170,7 +170,7 @@ namespace OpenTelemetry.Exporter.Zipkin.Tests
+             var traceId = useShortTraceIds ? TraceId.Substring(TraceId.Length - 16, 16) : TraceId;
+ 
+             Assert.Equal(
+-                $@""[{{""""traceId"""":""""{traceId}"""",""""name"""":""""Name"""",""""parentId"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(activity.ParentSpanId)}"""",""""id"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(context.SpanId)}"""",""""kind"""":""""CLIENT"""",""""timestamp"""":{timestamp},""""duration"""":60000000,""""localEndpoint"""":{{""""serviceName"""":""""OpenTelemetry Exporter""""{ipInformation}}},""""annotations"""":[{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event1""""}},{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event2""""}}],""""tags"""":{{""""stringKey"""":""""value"""",""""longKey"""":""""1"""",""""longKey2"""":""""1"""",""""doubleKey"""":""""1"""",""""doubleKey2"""":""""1"""",""""boolKey"""":""""True"""",""""library.name"""":""""CreateTestActivity""""}}}}]"",
++                $@""[{{""""traceId"""":""""{traceId}"""",""""name"""":""""Name"""",""""parentId"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(activity.ParentSpanId)}"""",""""id"""":""""{ZipkinActivityConversionExtensions.EncodeSpanId(context.SpanId)}"""",""""kind"""":""""CLIENT"""",""""timestamp"""":{timestamp},""""duration"""":60000000,""""localEndpoint"""":{{""""serviceName"""":""""OpenTelemetry Exporter""""{ipInformation}}},""""annotations"""":[{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event1""""}},{{""""timestamp"""":{eventTimestamp},""""value"""":""""Event2""""}}],""""tags"""":{{""""stringKey"""":""""value"""",""""longKey"""":1,""""longKey2"""":1,""""doubleKey"""":1.0,""""doubleKey2"""":1.0,""""boolKey"""":true,""""library.name"""":""""CreateTestActivity""""}}}}]"",
+                 Responses[requestId]);
+         }
+ ","Please check my thoughts here... I changed the test to not `ToString()` attribute values. This was important to test things when `net.peer.port` was both an int or a string, but I was unsure if Zipkin supported non-string attributes.",Why is this change needed?
+3225,"@@ -335,6 +335,8 @@ public class Camera extends Plugin {
+       returnBase64(call, exif, bitmapOutputStream);
+     } else if (settings.getResultType() == CameraResultType.URI) {
+       returnFileURI(call, exif, bitmap, u, bitmapOutputStream);
++    } else if (settings.getResultType() == CameraResultType.BASE64NOMETADATA) {
++      returnBase64NoMetadata(call, exif, bitmapOutputStream);
+     } else {
+       call.reject(INVALID_RESULT_TYPE_ERROR);
+     }","Looks like you made changes on `CameraResultType` class, but didn't commit them. And you also have to do the changes on the types in @capacitor/core",Shouldn't this be `returnF
+3226,"@@ -83,7 +83,7 @@ func buildImportParams() *ovfimportparams.OVFImportParams {
+ 		ShieldedIntegrityMonitoring: *shieldedIntegrityMonitoring, ShieldedSecureBoot: *shieldedSecureBoot,
+ 		ShieldedVtpm: *shieldedVtpm, Tags: *tags, Zone: *zoneFlag, BootDiskKmskey: *bootDiskKmskey,
+ 		BootDiskKmsKeyring: *bootDiskKmsKeyring, BootDiskKmsLocation: *bootDiskKmsLocation,
+-		BootDiskKmsProject: *bootDiskKmsProject, Timeout: *timeout, Project: *project,
++		BootDiskKmsProject: *bootDiskKmsProject, Timeout: *timeout, Project: project,
+ 		ScratchBucketGcsPath: *scratchBucketGcsPath, Oauth: *oauth, Ce: *ce,
+ 		GcsLogsDisabled: *gcsLogsDisabled, CloudLogsDisabled: *cloudLogsDisabled,
+ 		StdoutLogsDisabled: *stdoutLogsDisabled, NodeAffinityLabelsFlag: nodeAffinityLabelsFlag,","Can you explain the history of the bug a bit, and why this fixes it?",Why did you change this?
+3227,"@@ -0,0 +1,11 @@
++module MentorHelper
++  def mentor_image(mentor)
++    image_tag gravatar_url(mentor.email, size: '300')
++  end
++
++  def mentor_contact_link(mentor)
++    mail_to mentor.email,
++      I18n.t('dashboard.show.contact_your_mentor',
++             mentor_name: mentor.first_name)
++  end
++end","What do you think about `mentor_mail_to` or `mentor_mail_to_link` in order to match Rails' `mail_to` method, which is what this calls? I'm not sure about this suggestion...",Align the parameters of a 
+3228,"@@ -80,7 +80,7 @@ namespace OpenTelemetry.Exporter
+                 {
+                     string valueDisplay = string.Empty;
+                     StringBuilder tagsBuilder = new StringBuilder();
+-                    for (int i = 0; i < metricPoint.Keys.Length; i++)
++                    for (int i = 0; i < ((metricPoint.Keys == null) ? 0 : metricPoint.Keys.Length); i++)
+                     {
+                         tagsBuilder.Append(metricPoint.Keys[i]);
+                         tagsBuilder.Append("":"");",Looks like this will make the check in every loop. Consider extracting the null check.,">metricPoint.Keys == null ? 0 : metricPoint.Keys.Length [](start = 16, length = 54) why not just use metricPoint?"
+3229,"@@ -11,6 +11,14 @@ module RSpec::Core
+       expect(Module.private_methods & seg_methods).to eq([])
+     end
+ 
++    module SharedExampleGroup
++      describe Registry do
++        it 'can safely be reset' do
++          expect { Registry.clear }.to_not raise_error
++        end
++      end
++    end
++
+     %w[share_examples_for shared_examples_for shared_examples shared_context].each do |shared_method_name|
+       describe shared_method_name do
+         it ""is exposed to the global namespace"" do","Maybe `it ""can safely be reset when there are not yet any shared example groups""`? That's the edge case that wasn't working, right?",I don't think this is needed.
+3230,"@@ -19,7 +19,8 @@ import (
+ 	""fmt""
+ 	""net/http""
+ 
+-	""github.com/aws/amazon-ecs-agent/agent/asm/factory""
++	factory ""github.com/aws/amazon-ecs-agent/agent/asm/factory""
++	ssmfactory ""github.com/aws/amazon-ecs-agent/agent/ssm/factory""
+ 	""github.com/aws/amazon-ecs-agent/agent/config""
+ 	""github.com/aws/amazon-ecs-agent/agent/credentials""
+ 	""github.com/aws/amazon-ecs-agent/agent/ec2""",naming: please use `asmfactory`,This should be `ssmfactory`
+3231,"@@ -54,9 +54,12 @@ func (c *Client) buildCommand(target *core.BuildTarget, inputRoot *pb.Directory,
+ 	}
+ 	// We can't predict what variables like this should be so we sneakily bung something on
+ 	// the front of the command. It'd be nicer if there were a better way though...
+-	const commandPrefix = ""export TMP_DIR=\""`pwd`\"" && ""
++	var commandPrefix = ""export TMP_DIR=\""`pwd`\"" && ""
+ 	// TODO(peterebden): Remove this nonsense once API v2.1 is released.
+ 	files, dirs := outputs(target)
++	if len(target.Outputs()) == 1 { // $OUT is relative when running remotely; make it absolute
++		commandPrefix += ""export OUT=\""$TMP_DIR/$OUT\"" && ""
++	}
+ 	cmd, err := core.ReplaceSequences(c.state, target, c.getCommand(target))
+ 	return &pb.Command{
+ 		Platform: c.platform,",FYI you could use a raw string for this which removes the need for escaping the inner quotes.,"I'm not sure if this is the right way to do this. I think it would be better to use `filepath.Join(TMP_DIR, OUT)`"
+3232,"@@ -984,3 +984,19 @@ class TestGetSetClipboard:
+     def test_supports_selection(self, clipboard_mock, selection):
+         clipboard_mock.supportsSelection.return_value = selection
+         assert utils.supports_selection() == selection
++
++
++@pytest.mark.parametrize('keystr, expected', [
++    ('<Control-x>', True),
++    ('<Meta-x>', True),
++    ('<Ctrl-Alt-y>', True),
++    ('x', False),
++    ('X', False),
++    ('<Escape>', True),
++    ('foobar', False),
++    ('foo>', False),
++    ('<foo', False),
++    ('<<', False),
++])
++def test_is_special_key(keystr, expected):
++    assert utils.is_special_key(keystr) == expected",2 blank lines here (between functions),I don't think we need this test.
+3233,"@@ -23,8 +23,13 @@ import java.util.Set;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ 
+ class BaseRewriteFiles extends MergingSnapshotProducer<RewriteFiles> implements RewriteFiles {
++
+   BaseRewriteFiles(String tableName, TableOperations ops) {
+-    super(tableName, ops);
++    this(tableName, ops, ops.current().spec());
++  }
++
++  BaseRewriteFiles(String tableName, TableOperations ops, PartitionSpec spec) {
++    super(tableName, ops, spec);
+ 
+     // replace files must fail if any of the deleted paths is missing and cannot be deleted
+     failMissingDeletePaths();",Nit: we try to avoid whitespace changes because they can easily cause unnecessary commit conflicts.,Why do we need this constructor?
+3234,"@@ -1279,10 +1279,13 @@ class Codebase
+         }
+ 
+         foreach ($reference_map as $start_pos => [$end_pos, $possible_reference]) {
+-            if ($offset < $start_pos || $possible_reference[0] !== '*') {
++            if ($offset < $start_pos) {
+                 continue;
+             }
+-
++            // If the reference precedes a ""::"" then treat it as a class reference.
++            if ($offset - $end_pos === 2 && substr($file_contents, $end_pos, 2) === '::') {
++                return [$possible_reference, '::', $offset];
++            }
+             if ($offset - $end_pos === 0) {
+                 $recent_type = $possible_reference;
+ ","As mentioned below, I'm not sure why this is only allowing refs that are tagged with `*` at the start!",I'm not sure if this is the righ
+3235,"@@ -59,4 +59,19 @@ class BackgroundRepository implements Repository {
+     public void setFilter(CombinedAppsFilter filter) {
+         delegatedRepository.setFilter(filter);
+     }
++
++    @Override
++    public boolean equals(Object o) {
++        if (this == o) return true;
++        if (o == null || getClass() != o.getClass()) return false;
++
++        BackgroundRepository that = (BackgroundRepository) o;
++
++        return delegatedRepository != null ? delegatedRepository.equals(that.delegatedRepository) : that.delegatedRepository == null;
++    }
++
++    @Override
++    public int hashCode() {
++        return delegatedRepository != null ? delegatedRepository.hashCode() : 0;
++    }
+ }","Don't forget the {} symbols, and please use EqualsBuilder and HashcodeBuilder as possible",Shouldn't this be `that.delegate
+3236,"@@ -56,15 +56,17 @@ func TestPinger_Provider_Consumer_Ping_Flow(t *testing.T) {
+ 
+ 	// Create provider's UDP proxy listener to which pinger should hand off connection.
+ 	// In real world this proxy represents started VPN service (WireGuard or OpenVPN).
+-	proxyBuf := make([]byte, 1024)
++	ch := make(chan string)
+ 	go func() {
+ 		addr, _ := net.ResolveUDPAddr(""udp4"", fmt.Sprintf(""127.0.0.1:%d"", providerProxyPort))
+ 		conn, err := net.ListenUDP(""udp4"", addr)
+ 		assert.NoError(t, err)
+ 
+ 		for {
+-			_, err := conn.Read(proxyBuf)
++			proxyBuf := make([]byte, 1024)
++			n, err := conn.Read(proxyBuf)
+ 			assert.NoError(t, err)
++			ch <- string(proxyBuf[:n])
+ 		}
+ 	}()
+ ",Allocate buffer once outside loop.,nit: `ch := make(chan string)`
+3237,"@@ -1262,3 +1262,11 @@ TEST (network, filter)
+ 	node1.network.inbound (keepalive, std::make_shared<nano::transport::channel_loopback> (node1));
+ 	ASSERT_EQ (1, node1.stats.count (nano::stat::type::message, nano::stat::detail::invalid_network));
+ }
++
++TEST (network, fill_keepalive_self)
++{
++	nano::system system{ 2 };
++	std::array<nano::endpoint, 8> target;
++	system.nodes[0]->network.fill_keepalive_self (target);
++	ASSERT_TRUE (target[2].port () == system.nodes[1]->network.port);
++}",It would be better to check that system.nodes[1]->network.port is somewhere in the target without specifying its exact position. But it is a very minor point and I have no string opinion on it just thought I'd mention it because our tests in general have too implementation detail.,Please use `ASSERT_EQ` instead
+3238,"@@ -43,8 +43,11 @@ public class WebApplicationExceptionHandler implements ExceptionMapper<WebApplic
+         switch (ex.getResponse().getStatus()) {
+             // BadRequest
+             case 400:
++                // It's strange to have these ""startsWith"" conditionals here. They both come from Access.java.
+                 if ( (ex.getMessage()+"""").toLowerCase().startsWith(""tabular data required"")) {
+                     jrb.message(BundleUtil.getStringFromBundle(""access.api.exception.metadata.not.available.for.nontabular.file""));
++                } else if ((ex.getMessage() + """").toLowerCase().startsWith(""no permission to download file"")) {
++                    jrb.message(""You do not have permission to download this file."");
+                 } else {
+                     jrb.message(""Bad Request. The API request cannot be completed with the parameters supplied. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."");
+                     jrb.request(request);",Should this be in a bundle?,I think it would be better to 
+3239,"@@ -291,9 +291,8 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation
+ 
+         private static void ProcessResult(IAsyncResult asyncResult, AsyncCallback asyncCallback, Activity activity, object result, bool forceResponseCopy)
+         {
+-            // We could be executing on a different thread now so set the activity.
+-            Debug.Assert(Activity.Current == null || Activity.Current == activity, ""There was an unexpected active Activity on the result thread."");
+-            if (Activity.Current == null)
++            // We could be executing on a different thread now so restore the activity if needed.
++            if (Activity.Current != activity)
+             {
+                 Activity.Current = activity;
+             }","When Activity is lost (more precisely, ExecutionContext is lost) in the HttpModule we restore the root (HttpIn) Activity. That makes this assert invalid. I tried to fix the HttpModule so that it restores the Activity that was last running, but it is impossible to retrieve do to the way ExecutionContext works. It isn't an issue to remove the assert, but it is unnerving. Any instrumentation running in IIS reliant on Activity.Current could run into trouble.",Why was this assert removed?
+3240,"@@ -63,13 +63,16 @@ func WrapNetwork(net network.GossipNode, log logging.Logger) agreement.Network {
+ 	i.net = net
+ 	i.log = log
+ 
++	return i
++}
++
++func (i *networkImpl) Start() {
+ 	handlers := []network.TaggedMessageHandler{
+ 		{Tag: protocol.AgreementVoteTag, MessageHandler: network.HandlerFunc(i.processVoteMessage)},
+ 		{Tag: protocol.ProposalPayloadTag, MessageHandler: network.HandlerFunc(i.processProposalMessage)},
+ 		{Tag: protocol.VoteBundleTag, MessageHandler: network.HandlerFunc(i.processBundleMessage)},
+ 	}
+-	net.RegisterHandlers(handlers)
+-	return i
++	i.net.RegisterHandlers(handlers)
+ }
+ 
+ func messageMetadataFromHandle(h agreement.MessageHandle) *messageMetadata {",what was the point in moving handlers registration into a separate method?,Why do we need this?
+3241,"@@ -30,6 +30,9 @@ func newSyncCache(state *core.BuildState, remoteOnly bool) core.Cache {
+ 	if state.Config.Cache.HTTPURL != """" {
+ 		mplex.caches = append(mplex.caches, newHTTPCache(state.Config))
+ 	}
++	if state.Config.Cache.RetrieveCommand != """" {
++		mplex.caches = append(mplex.caches, newCmdCache(state.Config))
++	}
+ 	if len(mplex.caches) == 0 {
+ 		return &noopCache{}
+ 	} else if len(mplex.caches) == 1 {",At this point we probably want to ensure there's a store command set.,I'm not sure if this
+3242,"@@ -106,8 +106,13 @@ HDPrivateKey._getDerivationIndexes = function(path) {
+   }
+ 
+   var indexes = steps.slice(1).map(function(step) {
+-    var index = parseInt(step);
+-    index += step != index.toString() ? HDPrivateKey.Hardened : 0;
++    var index = step ? +step : NaN;
++
++    var isHardened = isNaN(index) && step[step.length-1] == ""'"";
++    if (isHardened) {
++      index = (+(step.slice(0, -1))) + HDPrivateKey.Hardened;
++    }
++
+     return index;
+   });
+ ","This code is way too complicated for what it does. I don't want to be a PITA, but what can you consider rewriting it in a simpler way? I'm talking about the whole `_getDerivationIndexes` function",I'm not sure if this
+3243,"@@ -151,6 +151,10 @@ namespace Nethermind.Vault.JsonRpc
+         {
+             try
+             {
++                if (message.StartsWith(""0x""))
++                {
++                    throw new Exception($""Vault message should not be in hex; message: {message}"");
++                }
+                 string result = await _vaultService.Sign(Guid.Parse(vaultId), Guid.Parse(keyId), message);
+                 return ResultWrapper<string>.Success(result);
+             }","Don't throw base exception, specify more precise type",Why do we need this?
+3244,"@@ -5,6 +5,16 @@ import torch
+ 
+ 
+ def cast_tensor_type(inputs, src_type, dst_type):
++    """"""Recursive converted Tensor in inputs from src_type to dst_type.
++
++    Args:
++        inputs: Inputs that to be casted.
++        src_type (torch.dtype): Source type..
++        dst_type (torch.dtype): Destination type.
++
++    Returns:
++        The same type with inputs, but all contained Tensors have been cast.
++    """"""
+     if isinstance(inputs, torch.Tensor):
+         return inputs.to(dst_type)
+     elif isinstance(inputs, str):",Recursive -> Recursively converted -> convert,nit: `src_type` and `dst_type`
+3245,"@@ -947,7 +947,8 @@ class CSharpGenerator : public BaseGenerator {
+       }
+       // JVM specifications restrict default constructor params to be < 255.
+       // Longs and doubles take up 2 units, so we set the limit to be < 127.
+-      if (has_no_struct_fields && num_fields && num_fields < 127) {
++      if ((has_no_struct_fields || opts.generate_object_based_api) &&
++          num_fields && num_fields < 127) {
+         struct_has_create = true;
+         // Generate a table constructor of the form:
+         // public static int createName(FlatBufferBuilder builder, args...)",why is this object API only? I think the reason why we didn't do this before was because this code was shared with Java which doesn't have value structs.,I don't think we need to check
+3246,"@@ -432,7 +432,7 @@ func acsWsURL(endpoint, cluster, containerInstanceArn string, taskEngine engine.
+ 	query.Set(""agentVersion"", version.Version)
+ 	query.Set(""seqNum"", ""1"")
+ 	if dockerVersion, err := taskEngine.Version(); err == nil {
+-		query.Set(""dockerVersion"", ""DockerVersion: ""+dockerVersion)
++		query.Set(""dockerVersion"", dockerVersion)
+ 	}
+ 	query.Set(sendCredentialsURLParameterName, acsSessionState.getSendCredentialsURLParameter())
+ 	return acsURL + ""?"" + query.Encode()","just to confirm, so backend will deal with both old format and new format?",Why did you remove the colon?
+3247,"@@ -91,7 +91,7 @@ namespace Datadog.Trace
+         }
+ 
+         private static T? ParseEnum<T>(IHeadersCollection headers, string headerName)
+-            where T : struct
++            where T : struct, Enum
+         {
+             var headerValues = headers.GetValues(headerName).ToList();
+ ","huh, look at that, I wasn't aware you could constrain a type by Enum",Why is this needed?
+3248,"@@ -229,6 +229,15 @@ PYBIND11_MODULE(ADIOS2_PYTHON_MODULE_NAME, m)
+                  const bool opBool = adios ? true : false;
+                  return opBool;
+              })
++        .def(pybind11::init<const bool>(),
++             ""adios2 module starting point ""
++             ""non-MPI, constructs an ADIOS class ""
++             ""object"",
++             pybind11::arg(""debugMode"") = true)
++        .def(pybind11::init<const std::string &, const bool>(),
++             ""adios2 module starting point non-MPI, constructs an ADIOS class ""
++             ""object"",
++             pybind11::arg(""configFile""), pybind11::arg(""debugMode"") = true)
+ #if ADIOS2_USE_MPI
+         .def(pybind11::init<const adios2::py11::MPI4PY_Comm, const bool>(),
+              ""adios2 module starting point, constructs an ADIOS class object"",","Even though the debug parameter is effectively ignored, should this default to `false` instead of `true`?","This should be `configFile`, not `configFile`."
+3249,"@@ -0,0 +1,17 @@
++/* Copyright 2016 Google Inc
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *      http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package com.google.api.codegen.viewmodel;
++
++public interface ParamView {}","What is the purpose of this interface? Unlike ParamDocView, it doesn't seem to be used anywhere to enable polymorphism",Why is this interface needed?
+3250,"@@ -1,12 +1,11 @@
+ package startupshutdown
+ 
+ import (
+-	""log""
+-	""os""
+-	""os/exec""
+ 	""strings""
+ 
++	""github.com/google/uuid""
+ 	""github.com/mholt/caddy""
++	""github.com/mholt/caddy/onevent/hook""
+ )
+ 
+ func init() {","We added a library to generate a UUID for the request_id directive ""github.com/nu7hatch/gouuid"" can we uses the same one for what you want rather than add another dependency? Or if the google one is better can we remove the nu7hatch library?",nit: remove empty line
+3251,"@@ -161,16 +161,13 @@ func (p *Pinger) PingProvider(ip string, localPorts, remotePorts []int, proxyPor
+ 	return localPort, remotePort, err
+ }
+ 
+-func (p *Pinger) ping(conn *net.UDPConn, ttl int, stop <-chan struct{}) error {
+-	// Windows detects that 1 TTL is too low and throws an exception during send
+-	i := 0
+-
++func (p *Pinger) ping(conn *net.UDPConn, remoteAddr *net.UDPAddr, ttl int, stop <-chan struct{}) error {
+ 	err := ipv4.NewConn(conn).SetTTL(ttl)
+ 	if err != nil {
+ 		return errors.Wrap(err, ""pinger setting ttl failed"")
+ 	}
+ 
+-	for {
++	for i := 1; time.Duration(i)*p.pingConfig.Interval < p.pingConfig.Timeout; i++ {
+ 		select {
+ 		case <-stop:
+ 			return nil","Shouldn't this be `i * Interval`? You're multiplying nanos with a Duration, I'm not sure what's the result :)",I think this should be `<=` instead of `*`.
+3252,"@@ -2513,7 +2513,7 @@ stack_alloc(size_t size, byte *min_addr)
+ #else
+         /* For UNIX we just mark it as inaccessible. */
+         if (!DYNAMO_OPTION(guard_pages))
+-            make_unwritable(guard, PAGE_SIZE);
++            set_protection(guard, PAGE_SIZE, MEMPROT_READ);
+ #endif
+     }
+ ",I guess it's not no-access to match Windows where guard pages are readable.,I'm not sure if this is the right way to do this. I think it would be better to do this in `set_protection` instead.
+3253,"@@ -103,7 +103,9 @@ module Ncr
+         self.proposal.update(status: 'approved')
+       else
+         approvers = emails.map{|e| User.for_email(e)}
++        removed_approvers_to_notify = self.proposal.approvals.non_pending.map(&:user) - approvers
+         self.proposal.approvers = approvers
++        Dispatcher.on_approver_removal(self.proposal, removed_approvers_to_notify)
+       end
+     end
+ ","Not a blocker, but would probably be useful to have a `scope :non_pending_approvers` on the `Proposal` model.",Style/RedundantSelf: Redundant self detected.
+3254,"@@ -94,6 +94,16 @@ class TaskException(Exception):
+     pass
+ 
+ 
++GetWorkResponse = collections.namedtuple('GetWorkResponse', (
++    'task_id',
++    'running_tasks',
++    'n_pending_tasks',
++    'n_unique_pending',
++    'n_pending_last_scheduled',
++    'worker_state'
++))
++
++
+ class TaskProcess(multiprocessing.Process):
+ 
+     """""" Wrap all task execution in this class.",Add trailing comma,Why is this a named tuple?
+3255,"@@ -28,7 +28,7 @@ func StartModules() {
+ // GracefulShutdown is if it gets the special signals it does modules cleanup
+ func GracefulShutdown() {
+ 	c := make(chan os.Signal)
+-	signal.Notify(c, syscall.SIGINT, syscall.SIGHUP, syscall.SIGTERM, syscall.SIGKILL,
++	signal.Notify(c, syscall.SIGINT, syscall.SIGHUP, syscall.SIGTERM,
+ 		syscall.SIGQUIT, syscall.SIGILL, syscall.SIGTRAP, syscall.SIGABRT)
+ 	select {
+ 	case s := <-c:",I see someone say SIGKILL can not be caught by process. The original code here about `SIGKILL` is useless?,Why this change?
+3256,"@@ -241,6 +241,7 @@ class Setting extends BaseModel {
+ 					let output = {};
+ 					output[Setting.THEME_LIGHT] = _('Light');
+ 					output[Setting.THEME_DARK] = _('Dark');
++					output[Setting.THEME_OLED_DARK] = _('OLED dark');
+ 					if (platform !== 'mobile') {
+ 						output[Setting.THEME_DRACULA] = _('Dracula');
+ 						output[Setting.THEME_SOLARIZED_LIGHT] = _('Solarised Light');","As it is a mobile only theme, please make sure the option appears only on mobile",This should be `OLED Dark`
+3257,"@@ -364,3 +364,14 @@ def _get_non_negative_param(param, default=None):
+         if value < 0:
+             raise APIBadRequest(""'{}' should be a non-negative integer"".format(param))
+     return value
++
++
++def parse_param_list(params):
++    param_list = []
++    for param in params.split("",""):
++        param = param.strip()
++        if not param:
++            continue
++        param_list.append(param)
++
++    return param_list",Would like a docstring and type annotations here,This function is not used 
+3258,"@@ -11,7 +11,7 @@ module Mongoid
+ 
+     included do
+       cattr_accessor :shard_key_fields
+-      self.shard_key_fields = []
++      self.shard_key_fields = {}
+     end
+ 
+     # Get the shard key fields.",This is an API change. Why was it made?,Why is this change necessa
+3259,"@@ -1,5 +1,7 @@
+ // Copyright (c) Microsoft. All rights reserved.
+ 
++using Microsoft.VisualStudio.TestPlatform.CoreUtilities.Tracing;
++
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Discovery
+ {
+     using System;",Please move using inside namespace.,Why is this needed?
+3260,"@@ -511,7 +511,7 @@ namespace Nethermind.Blockchain
+             }
+         }
+ 
+-        private AddBlockResult Suggest(Block? block, BlockHeader header, bool shouldProcess = true, bool? setAsMain = null)
++        private AddBlockResult Suggest(Block? block, BlockHeader header, bool shouldProcess = true, bool? setAsMain = null, bool poSEnabled = false)
+         {
+ #if DEBUG
+             /* this is just to make sure that we do not fall into this trap when creating tests */",shall we create some enum flags for setasmain shouldprocess and pos?,Why do we need this?
+3261,"@@ -141,6 +141,16 @@ exit /B %errorlevel%
+             # therefore, this command will always exit 0 if either service is installed
+             on host, Command.new(""sc query puppet || sc query pe-puppet"", [], { :cmdexe => true })
+ 
++            # (PA-514) value for PUPPET_AGENT_STARTUP_MODE should be present in
++            # registry and honored after install/upgrade.
++            reg_query_command = %Q(reg query ""HKLM\\SOFTWARE\\Wow6432Node\\Puppet Labs\\PuppetInstaller"" /v ""RememberedPuppetAgentStartupMode"" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
++            on host, Command.new(reg_query_command, [], { :cmdexe => true })
++
++            start_mode = msi_opts['PUPPET_AGENT_STARTUP_MODE'] == ""Automatic"" ? ""Auto"" : msi_opts['PUPPET_AGENT_STARTUP_MODE']
++            service_query_command = %Q('WMIC SERVICE where (Name like ""%Puppet"" AND StartMode=""#{start_mode}"") | findstr Puppet')
++
++            on host, Command.new(service_query_command, [], { :cmdexe => true })
++
+             # emit the misc/versions.txt file which contains component versions for
+             # puppet, facter, hiera, pxp-agent, packaging and vendored Ruby
+             [",Should this `PUPPET_AGENT_STARTUP_MODE` have a corresponding yardoc change?,I don't think you ne
+3262,"@@ -17,15 +17,10 @@
+ # You should have received a copy of the GNU General Public License
+ # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+ 
++# pylint: disable=unused-import
+ import pytest
+ import pytest_bdd as bdd
+ 
+-# pylint: disable=unused-import
+ from end2end.features.test_yankpaste_bdd import init_fake_clipboard
+ 
+-
+-pytestmark = pytest.mark.qtwebengine_todo(""Caret mode is not implemented"",
+-                                          run=False)
+-
+-
+ bdd.scenarios('caret.feature')",Why not simply remove the `pytest` import now that it's not needed anymore? :wink:,Why is this removed?
+3263,"@@ -0,0 +1,12 @@
++// Copyright (c) Microsoft.  All Rights Reserved.
++// Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
++
++using Microsoft.VisualStudio.TestTools.UnitTesting;
++
++namespace Microsoft.CodeAnalysis.Sarif.Core
++{
++    [TestClass]
++    public class TagsTests
++    {
++    }
++}","Yeah, not filled in yet.",Why do we need this?
+3264,"@@ -28,6 +28,13 @@
+     </div>
+   </div>
+ 
++  <div class=""row"">
++    <div class=""form-group col-xs-12"">
++      <%= f.check_box :active, style: 'width: auto' %>
++      <%= f.label :active, _('Active'), class: 'control-label' %>
++    </div>
++  </div>
++
+   <div class=""row"">
+     <div class=""form-group col-xs-6"">
+       <%= f.label :starts_at, _('Start'), class: 'control-label' %>",don't use style. Use a class instead. reducing `col-xs-12` down to 8 or 6 or whatever should do the trick,I think this should be `form-group col-xs-12`
+3265,"@@ -218,6 +218,13 @@ public class Catalog implements AutoCloseable {
+     Objects.requireNonNull(database, ""database is null"");
+     Objects.requireNonNull(tableName, ""tableName is null"");
+     TiTableInfo table = metaCache.getTable(database, tableName);
++
++    if (table == null) {
++      // reload cache if table not exists
++      reloadCache();
++      table = metaCache.getTable(database, tableName);
++    }
++
+     if (showRowId && table != null) {
+       return table.copyTableWithRowId();
+     } else {",should we also do `reloadCache` when database is null?,Why do we need to reload cache?
+3266,"@@ -47,6 +47,15 @@ void SetMCSBondTyper(MCSParameters &p, BondComparator bondComp) {
+   }
+ }
+ 
++ROMol *getQueryMol(MCSResult &mcsRes) {
++  ROMol *res;
++  {
++    NOGIL gil;
++    res = new ROMol(*mcsRes.QueryMol);
++  }
++  return res;
++}
++
+ MCSResult *FindMCSWrapper(python::object mols, bool maximizeBonds,
+                           double threshold, unsigned timeout, bool verbose,
+                           bool matchValences, bool ringMatchesRingOnly,",Why not just return QueryMol directly? Why require the copy?,Why do you need this?
+3267,"@@ -84,6 +84,15 @@ def retry_test(func):
+     assert success
+     return result
+ 
++
++def scapy_path(fname):
++    """"""Resolves a path relative to scapy's root folder""""""
++    if fname.startswith('/'):
++        fname = fname[1:]
++    return os.path.abspath(os.path.join(
++        os.path.dirname(__file__), '../../', fname
++    ))
++
+ #    Import tool    #
+ 
+ ",Could you add a docstring?,This should be `os.path.abspath(os.path.dirna
+3268,"@@ -23,4 +23,5 @@ module ApplicationHelper
+   def display_search_ui?
+     current_user && current_user.client_model && !client_disabled?
+   end
++
+ end",looks like you added newlines after blocks in a few files - I generally like newlines before/after multi-line blocks _except_ when the end the block is directly nested inside another block (eg: two `end`s next to each other) what do you think?,Extra empty line detected at body end.
+3269,"@@ -46,7 +46,7 @@ public class EqualsVisitor implements GenericVisitor<Boolean, Visitable> {
+     }
+ 
+     private EqualsVisitor() {
+-    // hide constructor
++        // hide constructor
+     }
+ 
+     /**",@jlerbsc 's fix in #2918 in action - thanks! :smiling_face_with_three_hearts:,Why is this needed?
+3270,"@@ -33,12 +33,15 @@ class ArgInfo:
+ 
+     """"""Information about an argument.""""""
+ 
+-    def __init__(self, win_id=False, count=False, flag=None, hide=False,
+-                 metavar=None, completion=None, choices=None):
++    def __init__(self, win_id=False, count=False, hide=False, metavar=None,
++                 zero_count=False, flag=None, completion=None, choices=None):
+         if win_id and count:
+             raise TypeError(""Argument marked as both count/win_id!"")
++        if zero_count and not count:
++            raise TypeError(""Zero_count Argument cannot exist without count!"")
+         self.win_id = win_id
+         self.count = count
++        self.zero_count = zero_count
+         self.flag = flag
+         self.hide = hide
+         self.metavar = metavar",nitpick: Please lower-case `Zero_count` (as it's a literal argument name) and `Argument` here.,I don't think this is the right error 
+3271,"@@ -2693,7 +2693,7 @@ func (a *Account) hasIssuer(issuer string) bool {
+ // hasIssuerNoLock is the unlocked version of hasIssuer
+ func (a *Account) hasIssuerNoLock(issuer string) bool {
+ 	// same issuer
+-	if a.Issuer == issuer {
++	if a.Name == issuer {
+ 		return true
+ 	}
+ 	for i := 0; i < len(a.signingKeys); i++ {",change the name of the function to match its functionality? account IsIssuing?,I think this should be `a.Name == issu
+3272,"@@ -84,6 +84,19 @@ class _Frame(object):
+         """"""
+         return _spark_col_apply(self, F.abs)
+ 
++    def groupby(self, by):
++        from databricks.koalas.groupby import GroupBy
++        from databricks.koalas.series import Series
++        if isinstance(by, str):
++            by = [by]
++        elif isinstance(by, Series):
++            by = [by]
++        else:
++            by = list(by)
++        if len(by) == 0:
++            raise ValueError('No group keys passed!')
++        return GroupBy(self, by=by)
++
+     def compute(self):
+         """"""Alias of `toPandas()` to mimic dask for easily porting tests.""""""
+         return self.toPandas()",for later: add docstring (can just copy paste Pandas'),I think this should be a `TypeError`.
+3273,"@@ -4,10 +4,10 @@
+ package cli
+ 
+ import (
+-	""fmt""
+ 	""testing""
+ 
+ 	climocks ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/cli/mocks""
++	archerMocks ""github.com/aws/amazon-ecs-cli-v2/mocks""
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/stretchr/testify/require""
+ )","nit: @sonofachamp pointed out to me that the idiomatic way is ""archermocks"" (lowercase for package names)",nit: this import should be grouped wi
+3274,"@@ -31,8 +31,7 @@ import (
+ )
+ 
+ var (
+-	errRouterNotSet          = errors.New(""router not set"")
+-	errRouterHasNoProcedures = errors.New(""router has no procedures"")
++	errRouterNotSet = errors.New(""router not set"")
+ 
+ 	_ transport.Inbound = (*Inbound)(nil)
+ )","Ugh I'm stupid, can you change this to `yarpc.InternalErrorf`?",Why remove this error?
+3275,"@@ -42,10 +42,16 @@ import org.apache.iceberg.util.ThreadPools;
+ public class AllDataFilesTable extends BaseMetadataTable {
+   private final TableOperations ops;
+   private final Table table;
++  private final String name;
+ 
+   public AllDataFilesTable(TableOperations ops, Table table) {
++    this(ops, table, table.name() + "".all_data_files"");
++  }
++
++  public AllDataFilesTable(TableOperations ops, Table table, String name) {
+     this.ops = ops;
+     this.table = table;
++    this.name = name;
+   }
+ 
+   @Override",We instantiate some metadata tables in tests so I kept the old constructor too. Won't harm if someone is using it directly too.,Why do we need this?
+3276,"@@ -4424,11 +4424,15 @@ function _execPopulateQuery(mod, match, select, assignmentOpts, callback) {
+     limit: mod.options.limit,
+     perDocumentLimit: mod.options.perDocumentLimit
+   }, mod.options.options);
++
+   if (mod.count) {
+     delete queryOptions.skip;
+   }
+ 
+-  if (queryOptions.perDocumentLimit != null) {
++  if (queryOptions.perDocumentLimit != null && queryOptions.limit != null) {
++    throw new Error('Can not use `limit` and `perDocumentLimit` at the same time. Model `' + mod.model.modelName + '`.' );
++  }
++  else if (queryOptions.perDocumentLimit != null) {
+     queryOptions.limit = queryOptions.perDocumentLimit;
+     delete queryOptions.perDocumentLimit;
+   } else if (queryOptions.limit != null) {",I think the better place to put this might be `lib/options/PopulateOptions.js`. That should make it easier - checking options in `populate()` can get confusing.,I don't think this is the right place to throw an error. I think it should be in the `getQueryOptions` method.
+3277,"@@ -41,13 +41,13 @@ var (
+ 
+ // NATProviderPinger pings provider and optionally hands off connection to consumer proxy.
+ type NATProviderPinger interface {
+-	PingProvider(ip string, providerPort, consumerPort, proxyPort int, stop <-chan struct{}) error
++	PingProvider(params Params, proxyPort int) (*net.UDPConn, error)
+ }
+ 
+ // NATPinger is responsible for pinging nat holes
+ type NATPinger interface {
+ 	NATProviderPinger
+-	PingTarget(*Params)
++	PingTarget(Params)
+ 	BindServicePort(key string, port int)
+ 	Start()
+ 	Stop()","Lets have simple function arguments here, because now struct `traversal.Params` started to have 2 purposes: 1. used as contract in DTO between consumer-provider 2. as function parameters for internal code calls",Why do we need this change?
+3278,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....,Missing license header.
+3279,"@@ -0,0 +1,7 @@
++<figure>
++  <img src=""/assets/upcase/testimonial_thumbs/anthony-lee.jpg"" alt=""Anthony"">
++  <p class=""quotee"">Anthony Lee<strong>Professional</strong> </p>
++</figure>
++<blockquote>
++  <p><strong>I am really loving upcase.</strong> The most valuable part for me was how I was able to dissect ""upcase"" app and see how it was built. Having the access to the repo and seeing how codes were structured was such a priceless lesson.</p>
++</blockquote>",`image_tag` in the `testimonials` files?,"I think this should be `<p class=""quotee"">...</p>`"
+3280,"@@ -255,9 +255,10 @@ public class ExecutionFlowDao {
+             + ""SET status=?,update_time=?,start_time=?,end_time=?,enc_type=?,flow_data=? ""
+             + ""WHERE exec_id=?"";
+ 
+-    final String json = JSONUtils.toJSON(flow.toObject());
+     byte[] data = null;
+     try {
++      // If this action fails, the execution must be failed.
++      final String json = JSONUtils.toJSON(flow.toObject());
+       final byte[] stringData = json.getBytes(""UTF-8"");
+       data = stringData;
+       // Todo kunkun-tang: use a common method to transform stringData to data.","I believe flow.toObject() method is throwing NPE if SLA option list (i.e. this.executionOptions.getSlaOptions()) is null or one of the value in the list (i.e. this.executionOptions.getSlaOptions()) is null. If that is the case we could fix root cause of NPE in the ExecutableFlow.toObject() method. The corresponding code to populate SLA options can be modified as follows. final List<Map<String, Object>> slaOptions = Optional.ofNullable(this.executionOptions.getSlaOptions()).orElse(Collections.emptyList()).stream() .filter(Objects::nonNull) .map(slaOption -> slaOption.toObject()) .collect(Collectors.toList());",Why is this change needed?
+3281,"@@ -33,7 +33,7 @@ export default Controller.extend(SettingsSaveMixin, {
+     }),
+ 
+     iconImageSource: computed('model.icon', function () {
+-        return this.get('model.icon') || '';
++        return this.get('model.icon') || '/favicon.ico';
+     }),
+ 
+     coverImageSource: computed('model.cover', function () {","So I haven't tested this - but since the icon location is just directly dumped into the img _src_ attribute, won't this cause issues with Ghost blogs in a subdirectory? If I'm misunderstanding what the purpose of the default is then let me know  ",I don't think this change 
+3282,"@@ -120,8 +120,16 @@ int main(int argc, char **argv)
+     MPI_Init(nullptr, nullptr);
+ #endif
+ 
+-    ::testing::InitGoogleTest(&argc, argv);
+-    int result = RUN_ALL_TESTS();
++    int result = -1;
++    try
++    {
++        ::testing::InitGoogleTest(&argc, argv);
++        result = RUN_ALL_TESTS();
++    }
++    catch (std::exception &e)
++    {
++        result = 1;
++    }
+ 
+ #ifdef ADIOS2_HAVE_MPI
+     MPI_Finalize();",Why swallow the exception here rather than propagate it?,Shouldn't this be `result 
+3283,"@@ -340,7 +340,8 @@ class _InternalFrame(object):
+                  index_map: Optional[List[IndexMap]] = None,
+                  scol: Optional[spark.Column] = None,
+                  data_columns: Optional[List[str]] = None,
+-                 column_index: Optional[List[Tuple[str]]] = None) -> None:
++                 column_index: Optional[List[Tuple[str]]] = None,
++                 column_names: Optional[List[str]] = None) -> None:
+         """"""
+         Create a new internal immutable DataFrame to manage Spark DataFrame, column fields and
+         index fields and names.",How about `column_index_names`? `column_names` sounds ambiguous.,nit: `column_names` -> `co
+3284,"@@ -89,6 +89,7 @@ public class TableProperties {
+   public static final String METADATA_COMPRESSION = ""write.metadata.compression-codec"";
+   public static final String METADATA_COMPRESSION_DEFAULT = ""none"";
+ 
++  public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics.column."";
+   public static final String DEFAULT_WRITE_METRICS_MODE = ""write.metadata.metrics.default"";
+   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = ""truncate(16)"";
+ }",+1 on this. Do we want to have it as `WRITE_METRICS_MODE_COLUMN_CONF_PREFIX` to be consistent with defaults? Is there a possibility we will have `READ_METRICS_MODE_COLUMN_CONF_PREFIX`? Not sure.,"public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics."";"
+3285,"@@ -2264,8 +2264,8 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils):
+ 
+     def test_cumprod(self):
+         pdf = pd.DataFrame(
+-            [[2.0, 1.0], [5, None], [1.0, 1.0], [2.0, 4.0], [4.0, 9.0]],
+-            columns=list(""AB""),
++            [[2.0, 1.0, 1], [5, None, 2], [1.0, 1.0, 3], [2.0, 4.0, 4], [4.0, 9.0, 5]],
++            columns=list(""ABC""),
+             index=np.random.rand(5),
+         )
+         kdf = ks.from_pandas(pdf)",Shall we use different inputs for `PySpark < 2.4` where `transpose` won't work with different data types.,Why did you change this?
+3286,"@@ -20,8 +20,11 @@ Wrappers around spark that correspond to common pandas functions.
+ import pyspark
+ import numpy as np
+ import pandas as pd
++from ._dask_stubs.compatibility import string_types
++from ._dask_stubs.utils import derived_from
+ from .typing import Col, pandas_wrap
+-from pyspark.sql import Column, DataFrame
++from pyspark.sql import Column, DataFrame, functions as F
++from pyspark.sql.types import NumericType
+ 
+ 
+ def default_session():","we should sort the headers like in spark: public packages, then pyspark, then internal",I don't think we need this import.
+3287,"@@ -53,7 +53,9 @@ func newPeer(address string, t *Transport) (*grpcPeer, error) {
+ 			grpc.MaxCallSendMsgSize(t.options.clientMaxSendMsgSize),
+ 		),
+ 	}
+-	if t.options.clientTLS {
++	if t.options.clientTLSConfig != nil {
++		dialOptions = append(dialOptions, grpc.WithTransportCredentials(credentials.NewTLS(t.options.clientTLSConfig)))
++	} else if t.options.clientTLS {
+ 		dialOptions = append(dialOptions, grpc.WithTransportCredentials(credentials.NewClientTLSFromCert(nil, """")))
+ 	} else {
+ 		dialOptions = append(dialOptions, grpc.WithInsecure())",looks like we should drop this var from the transport options struct,Why do we need this?
+3288,"@@ -721,17 +721,6 @@ func TestValidateDuration(t *testing.T) {
+ 			},
+ 			errs: []*field.Error{field.Invalid(fldPath.Child(""renewBefore""), usefulDurations[""ten years""].Duration, fmt.Sprintf(""certificate duration %s must be greater than renewBefore %s"", cmapi.DefaultCertificateDuration, usefulDurations[""ten years""].Duration))},
+ 		},
+-		""default renewBefore is bigger than the set duration"": {
+-			cfg: &internalcmapi.Certificate{
+-				Spec: internalcmapi.CertificateSpec{
+-					Duration:   usefulDurations[""one hour""],
+-					CommonName: ""testcn"",
+-					SecretName: ""abc"",
+-					IssuerRef:  validIssuerRef,
+-				},
+-			},
+-			errs: []*field.Error{field.Invalid(fldPath.Child(""renewBefore""), cmapi.DefaultRenewBefore, fmt.Sprintf(""certificate duration %s must be greater than renewBefore %s"", usefulDurations[""one hour""].Duration, cmapi.DefaultRenewBefore))},
+-		},
+ 		""renewBefore is bigger than the duration"": {
+ 			cfg: &internalcmapi.Certificate{
+ 				Spec: internalcmapi.CertificateSpec{","Ah, yeah, this is the test for the validation that I mentioned in a remark above about relaxing the validation.",Why is this test being removed?
+3289,"@@ -21,6 +21,19 @@ def anchor_inside_flags(flat_anchors,
+                         valid_flags,
+                         img_shape,
+                         allowed_border=0):
++    """"""Check whether the anchors are inside the border
++
++    Args:
++        flat_anchors (torch.Tensor): Flatten anchors
++        valid_flags (torch.Tensor): An existing valid flags of anchors
++        img_shape (tuple(int)): Shape of current image
++        allowed_border (int, optional): The border to allow the valid anchor.
++            Defaults to 0.
++
++    Returns:
++        torch.Tensor: Flags indicating whether the anchors are inside a
++            valid range.
++    """"""
+     img_h, img_w = img_shape[:2]
+     if allowed_border >= 0:
+         inside_flags = valid_flags & \","For tensors, it is better to illustrate the shape.",nit: `anchors` -> `anchors`
+3290,"@@ -42,6 +42,11 @@ describe( 'Site Kit admin bar component display', () => {
+ 					status: 200,
+ 					body: JSON.stringify( mockBatchResponse[ 'modules::search-console::searchanalytics::e74216dd17533dcb67fa2d433c23467c' ] ),
+ 				} );
++			} else if ( request.url().match( 'google-site-kit/v1/data/' ) ) {
++				request.respond( {
++					status: 200,
++					body: JSON.stringify( mockBatchResponse ),
++				} );
+ 			} else {
+ 				request.continue();
+ 			}","This was removed in a recent PR for the admin bar, but should have been kept. It's been restored in the other admin bar PR but I've added it here to for completeness.",Why do we need this?
+3291,"@@ -127,6 +127,15 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests
+             Assert.Equal(2, activityProcessor.Invocations.Count); // begin and end was called
+             var activity = (Activity)activityProcessor.Invocations[1].Arguments[0];
+ 
++#if !NETCOREAPP2_1
++            // ASP.NET Core after 2.x is W3C aware and hence Activity created by it
++            // must be used.
++            Assert.Equal(""Microsoft.AspNetCore.Hosting.HttpRequestIn"", activity.OperationName);
++#else
++            // ASP.NET Core before 3.x is not W3C aware and hence Activity created by it
++            // is always ignored and new one is created by the Instrumentation
++            Assert.Equal(""ActivityCreatedByHttpInListener"", activity.OperationName);
++#endif
+             Assert.Equal(ActivityKind.Server, activity.Kind);
+             Assert.Equal(""api/Values/{id}"", activity.DisplayName);
+             Assert.Equal(""/api/values/2"", activity.GetTagValue(SpanAttributeConstants.HttpPathKey) as string);",nit: probably swap the if condition and `if/else` and check `NETCOREAPP2_1` which looks more natural.,Why is this needed?
+3292,"@@ -486,12 +486,13 @@ func (a *Account) IsExportService(service string) bool {
+ // IsExportServiceTracking will indicate if given publish subject is an export service with tracking enabled.
+ func (a *Account) IsExportServiceTracking(service string) bool {
+ 	a.mu.RLock()
+-	defer a.mu.RUnlock()
+ 	ea, ok := a.exports.services[service]
+ 	if ok && ea == nil {
++		a.mu.RUnlock()
+ 		return false
+ 	}
+ 	if ok && ea != nil && ea.latency != nil {
++		a.mu.RUnlock()
+ 		return true
+ 	}
+ 	// FIXME(dlc) - Might want to cache this is in the hot path checking for","for the tag, should it be `requestor_rtt` since the other is `responder_rtt`?",I'm not sure if this is the right way to do this. I think we need to make sure that `a.exports.services[service]` is always non-nil.
+3293,"@@ -99,6 +99,15 @@ func (rcv *Monster) InventoryBytes() []byte {
+ 	return nil
+ }
+ 
++func (rcv *Monster) MutateInventory(j int, n byte) bool {
++	o := flatbuffers.UOffsetT(rcv._tab.Offset(14))
++	if o != 0 {
++		a := rcv._tab.Vector(o)
++		return rcv._tab.MutateByte(a+flatbuffers.UOffsetT(j*1), n)
++	}
++	return false
++}
++
+ func (rcv *Monster) Color() Color {
+ 	o := flatbuffers.UOffsetT(rcv._tab.Offset(16))
+ 	if o != 0 {","The one sad part of this is that is will generate a lot of overhead if you loop through a vector, since it obtains the vector every time. But with the current API there is no alternative I guess, and it is better to have the option than not.",Shouldn't this be `flatbuffers.UOffsetT(j*1)`?
+3294,"@@ -8,6 +8,7 @@ import (
+ 	""time""
+ 
+ 	""github.com/filecoin-project/go-filecoin/types""
++	files ""github.com/ipfs/go-ipfs-files""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ ",nit: there should be a newline between `types` and `go-ipfs-files`.,File is not `goimports`-ed (from `goimports`)
+3295,"@@ -0,0 +1,5 @@
++package reacher
++
++var (
++	RetryAfter = &retryAfterDuration
++)","would be nice to have this as a parameter (Options), re: technical debt discussions",nit: `RetryAfter` -> `RetryAfter`
+3296,"@@ -10,10 +10,13 @@ import java.util.List;
+ import java.util.Objects;
+ import java.util.stream.Collectors;
+ 
++import org.apache.commons.lang3.ArrayUtils;
++
+ import net.sourceforge.pmd.PMDVersion;
+ import net.sourceforge.pmd.util.fxdesigner.app.DesignerRoot;
+ import net.sourceforge.pmd.util.fxdesigner.util.DesignerUtil;
+ 
++import com.sun.javafx.fxml.builder.ProxyBuilder;
+ import javafx.application.Application;
+ import javafx.collections.ObservableList;
+ import javafx.fxml.FXMLLoader;",complete ignorance here  but is it ok to import this from `com.sun`? can it break under non-oracle JREs?,Why is this needed?
+3297,"@@ -61,6 +61,13 @@ func (tr *tracer) Start(ctx context.Context, name string, o ...apitrace.SpanOpti
+ 	span := startSpanInternal(name, parent, remoteParent, opts)
+ 	span.tracer = tr
+ 
++	if span.IsRecordingEvents() {
++		sps, _ := spanProcessors.Load().(spanProcessorMap)
++		for sp := range sps {
++			sp.OnStart(span.data)
++		}
++	}
++
+ 	ctx, end := startExecutionTracerTask(ctx, name)
+ 	span.executionTracerTaskEnd = end
+ 	return newContext(ctx, span), span",Is this some way of saying that the span is going to be sampled? I'm basing this question on the condition I saw for the `OnEnd` to be called - `mustExport := s.spanContext.IsSampled() &&  )`. Shouldn't the condition be `s.spanContext.IsSampled()` to match the condition for calling the `OnEnd`?,I'm not sure if thi
+3298,"@@ -650,6 +650,13 @@ func (c *CStorVolumeReplicaController) syncCvr(cvr *apis.CStorVolumeReplica) {
+ 	} else {
+ 		cvr.Status.Capacity = *capacity
+ 	}
++
++	err = volumereplica.GetAndUpdateSnapshotInfo(c.clientset, cvr)
++	if err != nil {
++		klog.Errorf(
++			""Unable to update snapshot list details in cvr %s status err: %v"",
++			cvr.Name, err)
++	}
+ }
+ 
+ func (c *CStorVolumeReplicaController) reconcileVersion(cvr *apis.CStorVolumeReplica) (",just calling UpdateSnapshotInfo() should be fine,nit: `Unable to upd
+3299,"@@ -156,8 +156,8 @@ namespace Datadog.Trace.Logging
+                 return rate;
+             }
+ 
+-            // We don't want to rate limit messages by default when in debug mode
+-            return GlobalSettings.Source.DebugEnabled ? 0 : DefaultLogMessageRateLimit;
++            // By default, we don't rate limit log messages;
++            return 0;
+         }
+ 
+         private static string GetLogDirectory()",Was `DefaultLogMessageRateLimit` not configurable anywhere?,Why did you remove 
+3300,"@@ -167,6 +167,19 @@ func TestPullImageGlobalTimeout(t *testing.T) {
+ 	wait.Done()
+ }
+ 
++func TestPullImageInactivityTimeout(t *testing.T) {
++	mockDocker, client, testTime, _, _, done := dockerClientSetup(t)
++	defer done()
++
++	testTime.EXPECT().After(gomock.Any()).AnyTimes()
++	mockDocker.EXPECT().PullImage(&pullImageOptsMatcher{""image:latest""}, gomock.Any()).Return(
++		docker.ErrInactivityTimeout).Times(maximumPullRetries) // expected number of retries
++
++	metadata := client.PullImage(""image"", nil)
++	assert.Error(t, metadata.Error, ""Expected error for pull inactivity timeout"")
++	assert.Equal(t, ""CannotPullContainerError"", metadata.Error.(api.NamedError).ErrorName(), ""Wrong error type"")
++}
++
+ func TestPullImage(t *testing.T) {
+ 	mockDocker, client, testTime, _, _, done := dockerClientSetup(t)
+ 	defer done()",Please use the `assert` instead. Same below.,nit: can we use `assert.EqualError` here?
+3301,"@@ -18,6 +18,7 @@ return array(
+     'A currency with code ""%name"" already exists.' => 'A currency with code ""%name"" already exists.',
+     'A descriptive title' => 'A descriptive title',
+     'A message with name ""%name"" already exists.' => 'A message with name ""%name"" already exists.',
++    'A name suche as Europe or Overseas' => 'A name suche as Europe or Overseas',
+     'A product with reference %ref already exists. Please choose another reference.' => 'A product with reference %ref already exists. Please choose another reference.',
+     'A short description, used when a summary or an introduction is required' => 'A short description, used when a summary or an introduction is required',
+     'A short text, used when an additional or supplemental information is required.' => 'A short text, used when an additional or supplemental information is required.',","Owww, I think I found a typo. `suche`",I'm not sure about this one. I think it s
+3302,"@@ -131,8 +131,6 @@ void search(SearchEngineData<Algorithm> &engine_working_data,
+                                     source_phantom.GetReverseWeightPlusOffset(),
+                                 source_phantom.reverse_segment_id.id);
+         }
+-        BOOST_ASSERT(forward_heap.Size() > 0);
+-        BOOST_ASSERT(reverse_heap.Size() > 0);
+ 
+         search(engine_working_data,
+                facade,",This can happen because we could get `PhantomNodes` that are not admissible as source/target right?,Why are these asserts removed?
+3303,"@@ -19,6 +19,9 @@ func init() {
+ 	if !structsEqual(&tls.ClientSessionState{}, &qtls.ClientSessionState{}) {
+ 		panic(""qtls.ClientSessionState not compatible with tls.ClientSessionState"")
+ 	}
++	if !structsEqual(&tls.ClientSessionState{}, &clientSessionState{}) {
++		panic(""clientSessionState not compatible with tls.ClientSessionState"")
++	}
+ }
+ 
+ func structsEqual(a, b interface{}) bool {",Should we add a note here to file a bug if this ever happens?,Why is this needed?
+3304,"@@ -455,7 +455,14 @@ func (api *BasicMarketAPI) GetDealChangeRequestInfo(ctx context.Context, dealID
+ }
+ 
+ func (api *BasicMarketAPI) GetNumBenchmarks(ctx context.Context) (int, error) {
+-	return NumCurrentBenchmarks, nil
++	num, err := api.marketContract.GetBenchmarksQuantity(getCallOptions(ctx))
++	if err != nil {
++		return 0, err
++	}
++	if !num.IsInt64() {
++		return 0, errors.New(""benchmarks quantity overflows int64"")
++	}
++	return int(num.Int64()), nil
+ }
+ 
+ type ProfileRegistry struct {","overflow is still possible, isn't it?",nit: `benchmarks quantity overflows int64`
+3305,"@@ -37,6 +37,9 @@ RSpec.configure do |config|
+   config.use_transactional_fixtures = false
+   config.use_instantiated_fixtures  = false
+   config.fixture_path = ""#{::Rails.root}/spec/fixtures""
++  config.infer_base_class_for_anonymous_controllers = false
++  config.order = ""random""
++  config.fail_fast = true
+ 
+   config.include Paperclip::Shoulda::Matchers
+   config.include EmailSpec::Helpers","This seems more like a personal preference, so maybe this should be in your `~/.rspec`?",Why is this needed?
+3306,"@@ -31,8 +31,8 @@ else:
+     THREAD_EXCEPTION = thread.error
+ 
+ if WINDOWS:
+-    from scapy.arch.pcapdnet import PcapTimeoutElapsed
+-    recv_error = PcapTimeoutElapsed
++    from scapy.error import Scapy_Exception
++    recv_error = Scapy_Exception
+ else:
+     recv_error = ()
+ ",To avoid a circular import between pcapdnet and automaton,This should be `from scapy.error import Sc
+3307,"@@ -1490,8 +1490,7 @@ class CommandDispatcher:
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+     def view_source(self):
+         """"""Show the source of the current page in a new tab.""""""
+-        # pylint: disable=no-member
+-        # WORKAROUND for https://bitbucket.org/logilab/pylint/issue/491/
++        
+         tab = self._current_widget()
+         if tab.data.viewing_source:
+             raise cmdexc.CommandError(""Already viewing source!"")",Please remove this blank line.,Why did you remove this?
+3308,"@@ -70,6 +70,7 @@ func (c *Reconciler) ReconcileKind(ctx context.Context, s *v1alpha1.CloudAuditLo
+ 	ctx = logging.WithLogger(ctx, c.Logger.With(zap.Any(""auditlogsource"", s)))
+ 
+ 	s.Status.InitializeConditions()
++	s.Status.WorkloadIdentityStatus.InitWorkloadIdentityStatus()
+ 	s.Status.ObservedGeneration = s.Generation
+ 
+ 	// If GCP ServiceAccount is provided, reconcile workload identity.","it feels that the WorkloadIdentityCondition should be added to this Status... And if you have workload identity enabled, but not working, then you can mark that condition failed, and also Mark the ready false... not entirely sure though",Why do we need this?
+3309,"@@ -1681,6 +1681,16 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+                 }
+             }
+         }
++
++        auto provoking_vertex_state_ci = lvl_find_in_chain<VkPipelineRasterizationProvokingVertexStateCreateInfoEXT>(
++            pPipeline->graphicsPipelineCI.pRasterizationState->pNext);
++        if (provoking_vertex_state_ci &&
++            provoking_vertex_state_ci->provokingVertexMode == VK_PROVOKING_VERTEX_MODE_LAST_VERTEX_EXT &&
++            !enabled_features.provoking_vertex_features.provokingVertexLast) {
++            skip |= LogError(
++                device, ""VUID-VkPipelineRasterizationProvokingVertexStateCreateInfoEXT-provokingVertexMode-04883"",
++                ""provokingVertexLast feature is not enabled."");
++        }
+     }
+ 
+     if ((pPipeline->active_shaders & VK_SHADER_STAGE_VERTEX_BIT) && !pPipeline->graphicsPipelineCI.pVertexInputState) {",I think these got refactored to `LvlFindInChain` to better conform with the coding guidelines. I think MarkL left these in for backwards compatibility.,Shouldn't this be a 
+3310,"@@ -50,6 +50,7 @@ def _column_op(f):
+     :param self: Koalas Series
+     :param args: arguments that the function `f` takes.
+     """"""
++
+     @wraps(f)
+     def wrapper(self, *args):
+         assert all((not isinstance(arg, Series)) or (arg._kdf is self._kdf) for arg in args), \","It's fine for this PR, but in the future try to minimize unrelated changes.",why is this needed?
+3311,"@@ -202,11 +202,11 @@ class Ansible(base.Base):
+     ::
+ 
+         ANSIBLE_ROLES_PATH:
+-          $ephemeral_directory/roles/:$project_directory/../
++          $ephemeral_directory/roles/:$project_directory/../:$HOME/.ansible/roles:/usr/share/ansible/roles:/etc/ansible/roles
+         ANSIBLE_LIBRARY:
+-          $ephemeral_directory/library/:$project_directory/library/
++          $ephemeral_directory/modules/:$project_directory/library/:$HOME/.ansible/plugins/modules:/usr/share/ansible/plugins/modules
+         ANSIBLE_FILTER_PLUGINS:
+-          $ephemeral_directory/plugins/filters/:$project_directory/filter/plugins/
++          $ephemeral_directory/plugins/filter/:$project_directory/filter/plugins/:$HOME/.ansible/plugins/filter:/usr/share/ansible/plugins/modules
+ 
+     Environment variables can be passed to the provisioner.  Variables in this
+     section which match the names above will be appened to the above defaults,",The library -> modules and filters -> filter path changes are breaking changes or?,Should this be `/usr
+3312,"@@ -1,6 +1,9 @@
+ import logging
++import os
+ from typing import TYPE_CHECKING
+ 
++import boto3
++import botocore.config
+ import pytest
+ 
+ from localstack.utils.aws import aws_stack","Can we encapsulate this check (`os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD""`) into a small config/util function? (and also use it in `integration/conftest.py`) (I'd generally try to avoid accessing `os.environ` directly across the codebase. I'm aware that we're already doing this in a few places, but maybe we can start pulling things out - this will also help us create more systematic config/environment abstractions as we go...)",Why do we need this import?
+3313,"@@ -22,7 +22,9 @@ export function h(nodeName, attributes) {
+ 	}
+ 	while (stack.length) {
+ 		if ((child = stack.pop()) && child.pop!==undefined) {
+-			for (i=child.length; i--; ) stack.push(child[i]);
++			[].concat(child).reverse().forEach((item) => {
++				stack.push(item);
++			});
+ 		}
+ 		else {
+ 			if (child===true || child===false) child = null;","An `if` statement would be better here. Functions, concat and reverse are all very expensive.",`for (const item of child) 
+3314,"@@ -156,3 +156,12 @@ func (c *factory) ERC20Address(ctx context.Context) (common.Address, error) {
+ 	}
+ 	return erc20Address, nil
+ }
++
++// DiscoverFactoryAddress returns the canonical factory for this chainID
++func DiscoverFactoryAddress(chainID int64) (common.Address, bool) {
++	if chainID == 5 {
++		// goerli
++		return common.HexToAddress(""0x334394E8c891E77b1449084aaDD659920BB25247""), true
++	}
++	return common.Address{}, false
++}",`Log here: connect to default factory for goerli network <address>`,I think this should return 
+3315,"@@ -125,9 +125,11 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ 
+ 	var approvers []string
+ 
+-	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+-		if v.Event == ""DEPLOYMENT_WAIT_APPROVAL"" {
+-			approvers = v.Slack
++	if ds.GenericDeploymentConfig.DeploymentNotification != nil {
++		for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
++			if e := ""EVENT_"" + v.Event; e == model.NotificationEventType_EVENT_DEPLOYMENT_WAIT_APPROVAL.String() {
++				approvers = v.Slack
++			}
+ 		}
+ 	}
+ ","nits, should add `break` to avoid redundant iterations.",I don't think we need to ch
+3316,"@@ -56,6 +56,15 @@ namespace Nethermind.Store.Test
+             provider.Commit(SpuriousDragon.Instance);
+             Assert.False(provider.AccountExists(_address1));
+         }
++        
++        [Test]
++        public void Eip_158_account_dont_exists_after_zero_value_transfer()
++        {
++            ISnapshotableDb stateDb = new StateDb(new MemDb());
++            StateProvider provider = new StateProvider(stateDb, Substitute.For<IDb>(), Logger);
++            provider.AddToBalance(_address1, 0, SpuriousDragon.Instance);
++            provider.AccountExists(_address1).Should().BeFalse();
++        }
+ 
+         [Test]
+         public void Eip_158_touch_zero_value_system_account_is_not_deleted()","I think we want an exception here, there should never be a transfer to a nonexisting account.",I think this should be `.Should().BeTrue();`
+3317,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+ 
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users.",Why is this change needed?
+3318,"@@ -79,11 +79,11 @@ class TestSklearn(unittest.TestCase):
+                                          '../../examples/lambdarank/rank.test.query'))
+         gbm = lgb.LGBMRanker()
+         gbm.fit(X_train, y_train, group=q_train, eval_set=[(X_test, y_test)],
+-                eval_group=[q_test], eval_at=[1, 3], early_stopping_rounds=5, verbose=False,
+-                callbacks=[lgb.reset_parameter(learning_rate=lambda x: 0.95 ** x * 0.1)])
+-        self.assertLessEqual(gbm.best_iteration_, 12)
+-        self.assertGreater(gbm.best_score_['valid_0']['ndcg@1'], 0.6173)
+-        self.assertGreater(gbm.best_score_['valid_0']['ndcg@3'], 0.6479)
++                eval_group=[q_test], eval_at=[1, 3], early_stopping_rounds=10, verbose=False,
++                callbacks=[lgb.reset_parameter(learning_rate=lambda x: max(0.01, 0.1 - 0.01 * x))])
++        self.assertLessEqual(gbm.best_iteration_, 25)
++        self.assertGreater(gbm.best_score_['valid_0']['ndcg@1'], 0.60)
++        self.assertGreater(gbm.best_score_['valid_0']['ndcg@3'], 0.60)
+ 
+     def test_regression_with_custom_objective(self):
+         def objective_ls(y_true, y_pred):",Can we make these asserts more strict/precise? I remember this test helped to spot the issue of inconsistent results on different platforms due to using `sort` instead of `stable_sort`.,Why did you change this?
+3319,"@@ -87,6 +87,10 @@ module Bolt
+         impl
+       end
+ 
++      def select_interpreter(executable, interpreters)
++        interpreters[Pathname(executable).extname] if interpreters
++      end
++
+       def reject_transport_options(target, options)
+         if target.options['run-as']
+           options.reject { |k, _v| k == '_run_as' }","I thought about adjusting for case here as well? For example `.rb,rb,.RB,.rb` would all map to ruby interpreter specified? Is that too much ""magic""? Is there a sane workflow that someone would choose to map `.rb` to one interpreter and `.RB` to another?",Should this be `Pathname(executable).to_s`?
+3320,"@@ -1235,12 +1235,15 @@ ostree_sysroot_get_subbootversion (OstreeSysroot   *self)
+  * ostree_sysroot_get_booted_deployment:
+  * @self: Sysroot
+  *
++ * This function may only be called if the sysroot is loaded.
++ *
+  * Returns: (transfer none) (nullable): The currently booted deployment, or %NULL if none
+  */
+ OstreeDeployment *
+ ostree_sysroot_get_booted_deployment (OstreeSysroot       *self)
+ {
+-  g_return_val_if_fail (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED, NULL);
++  g_assert (self);
++  g_assert (self->loadstate == OSTREE_SYSROOT_LOAD_STATE_LOADED);
+ 
+   return self->booted_deployment;
+ }","In this and the one below, should we assert `self != NULL` first?",I don't think this assert is necessary.
+3321,"@@ -147,7 +147,7 @@ class GalleryControllerTest extends \PHPUnit_Framework_TestCase
+         $view = $galleryController->postGalleryMediaGalleryhasmediaAction(1, 2, new Request());
+ 
+         $this->assertInstanceOf('FOS\RestBundle\View\View', $view);
+-        $this->assertSame(200, $view->getStatusCode(), 'Should return 200');
++        $this->assertSame(200, $view->getResponse()->getStatusCode(), 'Should return 200');
+     }
+ 
+     public function testPostGalleryMediaGalleryhasmediaInvalidAction()",Why this is needed?,Why did you change this?
+3322,"@@ -149,6 +149,12 @@ class PackageEntry:
+         """"""
+         self._meta['user_meta'] = meta
+ 
++    def get_meta(self):
++        """"""
++        Gets the user_meta for this PackageEntry.
++        """"""
++        return self.meta or None
++
+     def _verify_hash(self, read_bytes):
+         """"""
+         Verifies hash of bytes",we already have .meta() so I don't think we want get_meta() for PackageEntry,Why is this needed?
+3323,"@@ -83,7 +83,8 @@ public abstract class CoprocessorIterator<T> implements Iterator<T> {
+         session,
+         SchemaInfer.create(dagRequest),
+         dagRequest.getPushDownType(),
+-        dagRequest.getStoreType()) {
++        dagRequest.getStoreType(),
++        dagRequest.getStartTs().getVersion()) {
+       @Override
+       public Row next() {
+         return rowReader.readRow(schemaInfer.getTypes().toArray(new DataType[0]));",question: can we always get the startts from dagrequest?,Why do we need this change?
+3324,"@@ -114,9 +114,11 @@ describe( 'AccountSelect', () => {
+ 	it( 'should pre-select the property and profile IDs when changed', () => {
+ 		const { accounts, properties, profiles } = fixtures.accountsPropertiesProfiles;
+ 		const { getByText, container, registry } = render( <AccountSelect />, { setupRegistry } );
++		const propertyID = fixtures.accountsPropertiesProfiles.properties[ 0 ].id;
++		const accountID = fixtures.accountsPropertiesProfiles.properties[ 0 ].accountId;
+ 
+-		registry.dispatch( STORE_NAME ).receiveProperties( properties );
+-		registry.dispatch( STORE_NAME ).receiveProfiles( profiles );
++		registry.dispatch( STORE_NAME ).receiveProperties( properties, { accountID } );
++		registry.dispatch( STORE_NAME ).receiveProfiles( profiles, { propertyID } );
+ 
+ 		// Click the label to expose the elements in the menu.
+ 		fireEvent.click( container.querySelector( '.mdc-floating-label' ) );","Nit-picking, but this can be simplified to reference `properties[ 0 ]` since that is already retrieved 2 lines above.",Why do we need to pass `accountID` here?
+3325,"@@ -142,6 +142,10 @@ module Bolt
+         @unresolved_targets[t_name] = target
+       end
+ 
++      def remove_target(target)
++        @resolved_targets.delete(target.name)
++      end
++
+       def add_target(target)
+         @resolved_targets[target.name] = { 'name' => target.name }
+       end","This technically works because we call `get_targets` before we remove the target, so it's bound to have been resolved. But I'm not sure I would like to rely on that assumption. Should we also remove it from `@unresolved_targets` to be safe?",I think this should be `@unresolved_targ
+3326,"@@ -200,7 +200,7 @@ public abstract class AbstractCallOperation extends AbstractOperation {
+               .sender(sender(frame))
+               .value(value(frame))
+               .apparentValue(apparentValue(frame))
+-              .code(new Code(contract != null ? contract.getCode() : Bytes.EMPTY))
++              .code(frame.getWorldState().getContract(contract).orElse(new Code()))
+               .blockHeader(frame.getBlockHeader())
+               .depth(frame.getMessageStackDepth() + 1)
+               .isStatic(isStatic(frame))",So what happens if I try to get code on a EOA?,Why is this change needed?
+3327,"@@ -2400,15 +2400,8 @@ class VariablesChecker(BaseChecker):
+             return
+ 
+         # Attempt to check unpacking is properly balanced
+-        values: Optional[List] = None
+-        if isinstance(inferred, (nodes.Tuple, nodes.List)):
+-            values = inferred.itered()
+-        elif isinstance(inferred, astroid.Instance) and any(
+-            ancestor.qname() == ""typing.NamedTuple"" for ancestor in inferred.ancestors()
+-        ):
+-            values = [i for i in inferred.values() if isinstance(i, nodes.AssignName)]
+-
+-        if values:
++        values = self._get_values_to_unpack(inferred)
++        if values is not None:
+             if len(targets) != len(values):
+                 # Check if we have starred nodes.
+                 if any(isinstance(target, nodes.Starred) for target in targets):",Can't we return an empty list and then just compare the lengths? Thereby removing this `if`.,I think this should be `if values is not
+3328,"@@ -151,6 +151,7 @@ class Uppy {
+     this.addFile = this.addFile.bind(this)
+     this.removeFile = this.removeFile.bind(this)
+     this.pauseResume = this.pauseResume.bind(this)
++    this.passesRestrictions = this.passesRestrictions.bind(this)
+ 
+     // ___Why throttle at 500ms?
+     //    - We must throttle at >250ms for superfocus in Dashboard to work well (because animation takes 0.25s, and we want to wait for all animations to be over before refocusing).",Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me.,Why do we need to bind this?
+3329,"@@ -17,7 +17,7 @@ import (
+ 
+ // Lookup is the interface for time based feed lookup
+ type Lookup interface {
+-	At(ctx context.Context, at, after int64) (swarm.Chunk, error)
++	At(ctx context.Context, at, after int64) (chunk swarm.Chunk, currentIndex, nextIndex Index, err error)
+ }
+ 
+ // Getter encapsulates a chunk Getter getter and a feed and provides",TODO: in fact At when used with noncurrent time should not return a next index. only latest should..,nit: `err` is unused (from `
+3330,"@@ -165,7 +165,11 @@ export function diff(
+ 			tmp = c.render(c.props, c.state, c.context);
+ 			let isTopLevelFragment =
+ 				tmp != null && tmp.type == Fragment && tmp.key == null;
+-			newVNode._children = isTopLevelFragment ? tmp.props.children : tmp;
++			newVNode._children = isTopLevelFragment
++				? tmp.props.children
++				: Array.isArray(tmp)
++				? tmp
++				: [tmp];
+ 
+ 			if (c.getChildContext != null) {
+ 				context = assign(assign({}, context), c.getChildContext());","There are scenario's where we skip an update with a placeholder, in this case tmp returns null with render, this is not an array so we `[null]` it",Why is this change needed?
+3331,"@@ -33,8 +33,7 @@ import javaslang.match.annotation.Patterns;
+     // -- javaslang.collection
+ 
+     // List
+-    @Unapply static <T> Tuple2<T, List<T>> List(List.Cons<T> cons) { return Tuple.of(cons.head(), cons.tail()); }
+-    @Unapply static <T> Tuple0 List(List.Nil<T> nil) { return Tuple.empty(); }
++    @Unapply static <T> Tuple2<T, List<T>> List(List<T> cons) { return Tuple.of(cons.head(), cons.tail()); }
+ 
+     // Stream
+     @Unapply static <T> Tuple2<T, Stream<T>> Stream(Stream.Cons<T> cons) { return Tuple.of(cons.head(), cons.tail()); }","@danieldietrich, this wasn't tested so I presumed it wasn't working before either :p",Why did you remove this?
+3332,"@@ -22,7 +22,7 @@
+ *  This copyright notice MUST APPEAR in all copies of the script!
+ ***************************************************************/
+ use TYPO3\CMS\Core\Utility\GeneralUtility;
+-
++use ApacheSolrForTypo3\Solr\Facet\Facet;
+ /**
+  * Query group facet renderer.
+  *",Please leave two empty lines after the `use` statement,Why is this needed?
+3333,"@@ -27,6 +27,7 @@ import (
+ 	""bytes""
+ 	""fmt""
+ 	""io/ioutil""
++	""k8s.io/kubernetes/pkg/kubelet/cm""
+ 	""os""
+ 	""path""
+ 	""path/filepath""",Please move this import in the 3rd group which is for external dependencies,import (
+3334,"@@ -63,7 +63,7 @@ def _path_hash(path, transform, kwargs):
+     return digest_string(srcinfo)
+ 
+ def _is_internal_node(node):
+-    is_leaf = not node or node.get(RESERVED['file'])
++    is_leaf = not node or isinstance(node.get(RESERVED['file']), str)
+     return not is_leaf
+ 
+ def _pythonize_name(name):",So what exactly is this fixing? The unit test is passing with or without this change.,`is_leaf = node and
+3335,"@@ -601,8 +601,18 @@ bool FileBasedWal::linkCurrentWAL(const char* newPath) {
+         LOG(INFO) << idStr_ << ""Create link failed, there is no wal files!"";
+         return false;
+     }
++    if (!fs::FileUtils::makeDir(newPath)) {
++        LOG(INFO) << idStr_ << ""Link file parent dir make failed : "" << newPath;
++        return false;
++    }
++
+     auto it = walFiles_.rbegin();
+-    if (link(it->second->path(), newPath) != 0) {
++
++    // Using the original wal file name.
++    auto targetFile = folly::stringPrintf(""%s/%s"", newPath,
++            it->second->path() + std::string(it->second->path()).rfind('/') + 1);
++
++    if (link(it->second->path(), targetFile.data()) != 0) {
+         LOG(INFO) << idStr_ << ""Create link failed for "" << it->second->path()
+                   << "" on "" << newPath << "", error:"" << strerror(errno);
+         return false;","auto targetFile = fs::FileUtils::joinPath(newPath, folly::stringPrintf(""%019ld.wal"", it->first));",nit: `std::string(i
+3336,"@@ -42,6 +42,16 @@ public class SnapshotUtil {
+     return ancestorIds(table.currentSnapshot(), table::snapshot);
+   }
+ 
++  /**
++   * @return List of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
++   * This method assumes that fromSnapshotId is an ancestor of toSnapshotId
++   */
++  public static List<Long> snapshotIdsBetween(Table table, long fromSnapshotId, long toSnapshotId) {
++    List<Long> snapshotIds = Lists.newArrayList(ancestorIds(table.snapshot(toSnapshotId),
++        snapshotId -> snapshotId != fromSnapshotId ? table.snapshot(snapshotId) : null));
++    return snapshotIds;
++  }
++
+   public static List<Long> ancestorIds(Snapshot snapshot, Function<Long, Snapshot> lookup) {
+     List<Long> ancestorIds = Lists.newArrayList();
+     Snapshot current = snapshot;",I don't see any place that checks whether the from snapshot is an ancestor of the to snapshot. That seems like a requirement for this to work correctly to me.,nit: `snapshotIdsBetween` -> `snapshotIdsBetween`
+3337,"@@ -367,11 +367,10 @@ class Connection implements TranslatorAwareInterface, LoggerAwareInterface
+                     explode(':', $functionConfig['updateFields'])
+                 );
+             }
+-            if (isset($functionConfig['helpText'])) {
+-                $response['helpText'] = $this->getHelpText(
+-                    $functionConfig['helpText']
+-                );
+-            }
++            $response['helpText']
++                = $this->getHelpText($functionConfig['helpText'] ?? '');
++            $response['updateHelpText']
++                = $this->getHelpText($functionConfig['updateHelpText'] ?? '');
+             if (isset($functionConfig['consortium'])) {
+                 $response['consortium'] = $functionConfig['consortium'];
+             }","Other calls to getHelpText() are wrapped in an `isset()` check. Would it make sense to be consistent, and either restore that here or remove it elsewhere?",Shouldn't this be `$response['updateHelpText']`?
+3338,"@@ -17,7 +17,7 @@ module RSpec
+       # @param [IO] out
+       def run(err, out)
+         @configuration.error_stream = err
+-        @configuration.output_stream ||= out
++        @configuration.output_stream = out
+         @options.configure(@configuration)
+         @configuration.load_spec_files
+         @world.announce_filters","Why the change? If `output_stream` is set to something non-nil, it seems odd (and potentially wrong) to overwrite it....",Why this change?
+3339,"@@ -4,6 +4,7 @@ class Proposal < ActiveRecord::Base
+   workflow_column :status
+ 
+   has_one :cart
++  belongs_to :clientdata, polymorphic: true
+ 
+   validates :flow, presence: true, inclusion: {in: ApprovalGroup::FLOWS}
+ ",Thinking this should have an underscore.,"belongs_to :flow, polymorphic: true"
+3340,"@@ -316,14 +316,14 @@ def test_message_state_scope(init_linter: PyLinter) -> None:
+ 
+     linter = init_linter
+     linter.disable(""C0202"")
+-    assert MSG_STATE_SCOPE_CONFIG == linter.get_message_state_scope(""C0202"")
++    assert MSG_STATE_SCOPE_CONFIG == linter._get_message_state_scope(""C0202"")
+     linter.disable(""W0101"", scope=""module"", line=3)
+-    assert MSG_STATE_SCOPE_CONFIG == linter.get_message_state_scope(""C0202"")
+-    assert MSG_STATE_SCOPE_MODULE == linter.get_message_state_scope(""W0101"", 3)
++    assert MSG_STATE_SCOPE_CONFIG == linter._get_message_state_scope(""C0202"")
++    assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(""W0101"", 3)
+     linter.enable(""W0102"", scope=""module"", line=3)
+-    assert MSG_STATE_SCOPE_MODULE == linter.get_message_state_scope(""W0102"", 3)
++    assert MSG_STATE_SCOPE_MODULE == linter._get_message_state_scope(""W0102"", 3)
+     linter.config = FakeConfig()
+-    assert MSG_STATE_CONFIDENCE == linter.get_message_state_scope(
++    assert MSG_STATE_CONFIDENCE == linter._get_message_state_scope(
+         ""this-is-bad"", confidence=interfaces.INFERENCE
+     )
+ ",To accommodate the change to the method being private.,Why is this change necessary?
+3341,"@@ -90,6 +90,7 @@ namespace AutoRest.Swagger.Model
+         [CollectionRule(typeof(BodyTopLevelProperties))]
+         [CollectionRule(typeof(HttpVerbValidation))]
+         [CollectionRule(typeof(DeleteMustHaveEmptyRequestBody))]
++        [CollectionRule(typeof(PropertiesNamesCamelCase))]
+         public Dictionary<string, Dictionary<string, Operation>> Paths { get; set; }
+ 
+         /// <summary>",Shouldn't we traverse all definitions and apply this rule over all model definitions in the doc,Why is this needed?
+3342,"@@ -0,0 +1,11 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.design;
++
++import net.sourceforge.pmd.testframework.PmdRuleTst;
++
++public class MutableStaticState extends PmdRuleTst {
++    // no additional unit tests
++}","Please rename this class that it ends with the suffix ""Test"" - otherwise the tests won't be executed.",Why is this needed?
+3343,"@@ -0,0 +1,7 @@
++// This file is here, in part, so that users whose code editors are
++// set to automatically format files with Prettier have a config to detect.
++// Many users only run Prettier when a config is present, so this file makes
++// sure one can be detected, even though we aren't doing anything with it.
++module.exports = {
++	...require('@wordpress/prettier-config'),
++}","As a JS file, this should also receive our standard file header.",I'm not sure if this is the b
+3344,"@@ -1784,7 +1784,9 @@ short HashJoin::codeGen(Generator * generator) {
+   UInt16 numBMOsInFrag = (UInt16)generator->getFragmentDir()->getNumBMOs();
+         
+   double memQuota = 0;
+-
++  double memQuotaRatio;
++  Lng32 numStreams;
++  double bmoMemoryUsagePerNode = getEstimatedRunTimeMemoryUsage(TRUE, &numStreams).value();
+   if (mmu != 0) {
+     memQuota = mmu;
+     hashj_tdb->setMemoryQuotaMB(mmu);","I take it memQuotaRatio is an ""out"" parameter at line 1810? Also, why use MIN_QUOTA in both the cases of memQuota being too low and too high? Contrast this code with RelRoot::codeGen where we set MIN_QUOTA only in the too low case.",I think this should be `double memQuotaRatio = 0.0;`
+3345,"@@ -49,7 +49,6 @@ func NewPullSubscription(name, namespace string, so ...PullSubscriptionOption) *
+ 	for _, opt := range so {
+ 		opt(s)
+ 	}
+-	s.SetDefaults(gcpauthtesthelper.ContextWithDefaults())
+ 	return s
+ }
+ ","It looks like for newpullsubscription, we have two functions. One for pullsubscription with default, one for pullsubscription without default. If you remove setdefault here, then there is no differences between these two functions.",Why was this removed?
+3346,"@@ -186,6 +186,13 @@ type AssetParams struct {
+ 	// created.
+ 	Total uint64 `codec:""t""`
+ 
++	// Decimals specifies the number of digits to display after the decimal
++	// place when displaying this asset. A value of 0 represents an asset
++	// that is not divisible, a value of 1 represents an asset divisible
++	// into tenths, and so on. This value must be between 0 and 19
++	// (inclusive).
++	Decimals uint32 `codec:""dc""`
++
+ 	// DefaultFrozen specifies whether slots for this asset
+ 	// in user accounts are frozen by default or not.
+ 	DefaultFrozen bool `codec:""df""`","not dramatic, but why 32bits if we allow a range that is smaller than 8?",I think this should be `uint32`
+3347,"@@ -0,0 +1,8 @@
++package dto
++
++type ClientPromise struct {
++	SerialNumber int
++	IssuerId int
++	BenefiterId int
++	Amount int
++}",- Use type from `service_discovery/dto/price.go` - Rename `Price` -> `Money`,Why is this a pointer?
+3348,"@@ -193,6 +193,18 @@ public abstract class Either<L, R> implements io.vavr.Iterable<R>, io.vavr.Value
+     /**
+      * Maps either the left or the right side of this disjunction.
+      *
++     * <pre>{@code
++     *Either<?, AtomicInteger> success = Either.right(new AtomicInteger(42));
++     *
++     * //prints ""Right(42)""
++     * System.out.println(success.bimap(Function1.identity(), AtomicInteger::get));
++     *
++     * Either<Exception, ?> failure = Either.left(new Exception(""error""));
++     *
++     * //prints ""Left(error)""
++     * System.out.println(failure.bimap(Exception::getMessage, Function1.identity()));
++     * }</pre>
++     *
+      * @param leftMapper  maps the left value if this is a Left
+      * @param rightMapper maps the right value if this is a Right
+      * @param <X>         The new left type of the resulting Either",one space missing at the beginning,"This should be `Either.left(new Exception(""error""));`"
+3349,"@@ -43,8 +43,9 @@ type RequestDrivenWebServiceProps struct {
+ 
+ // AppRunnerInstanceConfig contains the instance configuration properties for an App Runner service.
+ type AppRunnerInstanceConfig struct {
+-	CPU    *int `yaml:""cpu""`
+-	Memory *int `yaml:""memory""`
++	CPU      *int   `yaml:""cpu""`
++	Memory   *int   `yaml:""memory""`
++	Platform string `yaml:""platform,omitempty""`
+ }
+ 
+ // NewRequestDrivenWebService creates a new Request-Driven Web Service manifest with default values.","I worry that having `Platform` as `string` instead of `*string` would result in it getting overriden with `""""` if the environment manifest config doesn't specify `platform`   . If it gets overridden as `""""`, that could be a problem for users that are not using `linux/amd64` right? If this indeed is a potential impact, could we double check in `ApplyEnv`'s unit test? Same with the `Platform` in `TaskConfig`. Sorry for not seeing this in my previous review!!!  ",Why do we need this?
+3350,"@@ -26,7 +26,10 @@ exports = module.exports = function(grunt, options) {
+ 					'http://' + host + ':<%= connect.test.options.port %>/test/commons/',
+ 					'http://' +
+ 						host +
+-						':<%= connect.test.options.port %>/test/integration/rules/'
++						':<%= connect.test.options.port %>/test/integration/rules/',
++					'http://' +
++						host +
++						':<%= connect.test.options.port %>/test/integration/api/external/'
+ 				],
+ 				run: true,
+ 				growlOnSuccess: false,","I like the new directory `/api`, what is the thinking behind `/external`?",I'm not sure if this is the right place to put this. 
+3351,"@@ -2844,11 +2844,10 @@ func (s *Server) updateAccountClaimsWithRefresh(a *Account, ac *jwt.AccountClaim
+ 	// update account signing keys
+ 	a.signingKeys = nil
+ 	signersChanged := false
+-	if len(ac.SigningKeys) > 0 {
+-		// insure copy the new keys and sort
+-		a.signingKeys = append(a.signingKeys, ac.SigningKeys...)
+-		sort.Strings(a.signingKeys)
++	for k, _ := range ac.SigningKeys {
++		a.signingKeys = append(a.signingKeys, k)
+ 	}
++	sort.Strings(a.signingKeys)
+ 	if len(a.signingKeys) != len(old.signingKeys) {
+ 		signersChanged = true
+ 	} else {",staticcheck flags this: replace with `for k := ..`,Why do we need to sort here?
+3352,"@@ -132,8 +132,8 @@ def GMLAN_InitDiagnostics(
+         p = GMLAN() / GMLAN_PM(subfunction=""enableProgrammingMode"")
+         if verbose:
+             print(""Sending %s"" % repr(p))
+-        sock.send(p)
+         time.sleep(0.05)
++        sock.sr1(p, timeout=0.001, verbose=False)
+         return True
+     return False
+ ",There's already a sleep right above,Why did you remove the send?
+3353,"@@ -1249,9 +1249,16 @@ class AssertionFinder
+                         $if_types[$var_id] = [[$assertion->rule[0][0]]];
+                     }
+                 } elseif (\is_string($assertion->var_id)
+-                    && $expr instanceof PhpParser\Node\Expr\MethodCall
++                    && (
++                        $expr instanceof PhpParser\Node\Expr\MethodCall
++                        || $expr instanceof PhpParser\Node\Expr\StaticCall
++                    )
+                 ) {
+-                    $if_types[$assertion->var_id] = [[$assertion->rule[0][0]]];
++                    $var_id = $assertion->var_id;
++                    if (strpos($var_id, 'self::') === 0) {
++                        $var_id = $this_class_name . '::' . substr($var_id, 6);
++                    }
++                    $if_types[$var_id] = [[$assertion->rule[0][0]]];
+                 }
+ 
+                 if ($if_types) {","This feels hacky, is there a better way?",Why is this needed?
+3354,"@@ -22,9 +22,14 @@
+ # IN THE SOFTWARE.
+ #
+ from math import ceil
+-from boto.compat import json, map, six
++from boto.compat import json, six
+ import requests
+ 
++try:
++    from collections import OrderedDict
++except ImportError:
++    from ordereddict import OrderedDict
++
+ 
+ class SearchServiceException(Exception):
+     pass","Can we move this logic into the `boto.compat` module? Then it's just `from boto.compat import OrderedDict` instead. Also, this is introducing a new dependency. What about users on 2.6.x that don't have the OrderedDict module installed? We may need to fall back to an ordinary `dict` so that existing code in the wild does not break.",Why do we need this?
+3355,"@@ -36,14 +36,14 @@ namespace Fixtures.Azure.AcceptanceTestsAzureBodyDuration
+         public Uri BaseUri { get; set; }
+ 
+         /// <summary>
+-        /// Gets or sets json serialization settings.
++        /// Gets JSON serialization settings.
+         /// </summary>
+         public JsonSerializerSettings SerializationSettings { get; private set; }
+ 
+         /// <summary>
+-        /// Gets or sets json deserialization settings.
++        /// Gets JSON deserialization settings.
+         /// </summary>
+-        public JsonSerializerSettings DeserializationSettings { get; private set; }        
++        public JsonSerializerSettings DeserializationSettings { get; private set; }
+ 
+         /// <summary>
+         /// Gets Azure subscription credentials.","""Gets the JSON serialization settings."" would be better?",Should this be `Gets or sets
+3356,"@@ -38,6 +38,15 @@ func (s *server) setupRouting() {
+ 	handle(router, ""/bytes"", jsonhttp.MethodHandler{
+ 		""POST"": http.HandlerFunc(s.bytesUploadHandler),
+ 	})
++
++	handle(router, ""/file"", jsonhttp.MethodHandler{
++		""POST"": http.HandlerFunc(s.bzzFileUploadHandler),
++	})
++
++	handle(router, ""/file/{addr}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.bzzFileDownloadHandler),
++	})
++
+ 	handle(router, ""/bytes/{address}"", jsonhttp.MethodHandler{
+ 		""GET"": http.HandlerFunc(s.bytesGetHandler),
+ 	})",The endpoint should be in plural `/files`.,Why do we need a separate handler for this?
+3357,"@@ -141,6 +141,9 @@ AtomPDBResidueInfo *AtomGetPDBResidueInfo(Atom *atom) {
+   return (AtomPDBResidueInfo *)res;
+ }
+ 
++struct MDLDummy {};
++struct DaylightDummy {};
++
+ // FIX: is there any reason at all to not just prevent the construction of
+ // Atoms?
+ std::string atomClassDoc =","??? Why do we need to have a different API in Python? Oh, wait, I see what you did. It's to fake the namespaces. Given that I don't think the namespaces are necessary, and that less of these should be exposed anyway, I think these should go.",why is this needed?
+3358,"@@ -40,7 +40,7 @@ func InitContext(contextType string) {
+ 	})
+ }
+ 
+-func GetContext() gocontext.Context{
++func GetContext() gocontext.Context {
+ 	return context.ctx
+ }
+ func Done() <-chan struct{} {",I think this line is gofmt issue? @daixiang0,Why this change?
+3359,"@@ -94,6 +94,16 @@ func TestSubrepoLabel(t *testing.T) {
+ 	assert.EqualValues(t, BuildLabel{PackageName: """", Name: """"}, label.SubrepoLabel())
+ }
+ 
++func TestParseBuildLabelParts(t *testing.T) {
++	target1 := ""@unittest_cpp//:unittest_cpp""
++	targetNewSyntax := ""@unittest_cpp""
++	pkg, name, subrepo := parseBuildLabelParts(target1, ""/"", nil)
++	pkg2, name2, subrepo2 := parseBuildLabelParts(targetNewSyntax, ""/"", nil)
++	assert.Equal(t, pkg, pkg2)
++	assert.Equal(t, name, name2)
++	assert.Equal(t, subrepo, subrepo2)
++}
++
+ func TestMain(m *testing.M) {
+ 	// Used to support TestComplete, the function it's testing re-execs
+ 	// itself thinking that it's actually plz.","probably better to assert the values directly; technically you could pass this test with an implementation that always returned """" for the subrepo for example.",nit: can we use `assert.EqualValues` here?
+3360,"@@ -46,7 +46,7 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		big.NewInt(10),
+ 	)
+ 	pubk, _ := keypair.DecodePublicKey(Gen.CreatorPubKey)
+-	sig, _ := hex.DecodeString(""3584fe777dd090e1a7a825896f532485ea2cc35d7c300c6c56f0e2e78b51c6ded33f7d0069f4f6f6b6762306466fcff6f261bb30d9e1550f2f8be4f988e740903fd734209cb60101"")
++	sig, _ := hex.DecodeString(""9c1fb14affb398f850d0642f22f12433526bed742fbfb39115f9df2549b2751347bafe9ddbe50e6f02906bdc83b7c905944adc19583726dfaea83245318132ff01"")
+ 	bd := &action.EnvelopeBuilder{}
+ 	elp := bd.SetAction(tsf0).
+ 		SetDestinationAddress(ta.Addrinfo[""producer""].Bech32()).",line is 161 characters (from `lll`),Why did you change this?
+3361,"@@ -19,13 +19,14 @@
+ 
+ package org.apache.iceberg.catalog;
+ 
++import java.io.Serializable;
+ import java.util.Arrays;
+ import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+ 
+ /**
+  * A namespace in a {@link Catalog}.
+  */
+-public class Namespace {
++public class Namespace implements Serializable {
+   private static final Namespace EMPTY_NAMESPACE = new Namespace(new String[] {});
+   private static final Joiner DOT = Joiner.on('.');
+ ",Are these changes needed?,Why is this needed?
+3362,"@@ -78,12 +78,12 @@ public final class UserUtils {
+       }
+ 
+       try {
+-        Path dir = Paths.get(fileName).getParent();
++        final Path dir = Paths.get(fileName).getParent();
+         if (!dirToFilesMap.containsKey(dir)) {
+-          // There is not entry for this directory, create a watchkey
++          // There is no entry for this directory, create a watchkey
+           WatchKey watchKey = dir.register(watchService,
+               new WatchEvent.Kind[]{StandardWatchEventKinds.ENTRY_MODIFY},
+-              SensitivityWatchEventModifier.HIGH);
++              SensitivityWatchEventModifier.LOW);
+           keys.put(watchKey, dir);
+         }
+         // Add the config file to dir map","It seems like reducing the sensitivity would make the test failure less likely to occur, but not fix the issue?",Why is this change neces
+3363,"@@ -3,7 +3,9 @@
+ namespace Thelia\Model;
+ 
+ use Thelia\Model\Base\CategoryDocumentI18n as BaseCategoryDocumentI18n;
++use Thelia\Model\Tools\I18nTimestampableTrait;
+ 
+ class CategoryDocumentI18n extends BaseCategoryDocumentI18n
+ {
++    use I18nTimestampableTrait;
+ }",missing use statement for importing the full namespace,Why is this needed?
+3364,"@@ -35,6 +35,9 @@ var ErrInsufficientHosts = &shared.InternalServiceError{Message: ""Not enough hos
+ // ErrListenerAlreadyExist is thrown on a duplicate AddListener call from the same listener
+ var ErrListenerAlreadyExist = errors.New(""Listener already exist for the service"")
+ 
++// ErrIncorrectAddressFormat is thrown on incorrect address format
++var ErrIncorrectAddressFormat = errors.New(""Incorrect address format"")
++
+ type (
+ 
+ 	// ChangedEvent describes a change in membership",Generally error messages in Go shouldn't start with capital letter. I see this rule is broken in many places here. Why?,nit: can we call this `ErrIncorrectAddressFormat`
+3365,"@@ -285,7 +285,7 @@ describe('Core_selection', () => {
+     selectCell(0, 0);
+     keyDownUp('arrow_left');
+ 
+-    expect(getSelected()).toEqual([[0, 0, 0, 0]]);
++    expect(getSelected()).toEqual([[4, 4, 4, 4]]);
+   });
+ 
+   it('should fix start range if provided is out of bounds (to the top)', () => {",These test checks if selection coordinates don't return negative values in that edge cases. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire Core_selection.spec.js file.,Why did this change?
+3366,"@@ -60,7 +60,17 @@ namespace Nethermind.Evm.TransactionProcessing
+             /// <summary>
+             /// Commit and later restore state, use for CallAndRestore
+             /// </summary>
+-            CommitAndRestore = Commit | Restore
++            CommitAndRestore = Commit | Restore,
++            
++            /// <summary>
++            /// Zero Gas price
++            /// </summary>
++            ZeroGasPrice = 4,
++
++            /// <summary>
++            /// Commit and restore with zero gas price
++            /// </summary>
++            CommitAndRestoreWithZeroGasPrice = CommitAndRestore | ZeroGasPrice
+         }
+ 
+         public TransactionProcessor(",I would prefer flag SkipGasPricingValidation,Why do we need this?
+3367,"@@ -1492,6 +1492,13 @@ void nano::work_watcher::add (std::shared_ptr<nano::block> block_a)
+ 	}
+ }
+ 
++bool nano::work_watcher::is_watched (nano::qualified_root const root_a)
++{
++	std::unique_lock<std::mutex> lock (mutex);
++	auto exists (blocks.find (root_a));
++	return exists != blocks.end ();
++}
++
+ void nano::wallets::do_wallet_actions ()
+ {
+ 	std::unique_lock<std::mutex> action_lock (action_mutex);",could be `const &` ?,Why not just `return exists != blocks.end()`?
+3368,"@@ -75,6 +75,7 @@ module.exports = class Dashboard extends Plugin {
+       defaultTabIcon: defaultTabIcon,
+       showProgressDetails: false,
+       hideUploadButton: false,
++      hideProgressAfterFinish: false,
+       note: null,
+       closeModalOnClickOutside: false,
+       locale: defaultLocale,",The docs should also be updated with the new option.,Why is this needed?
+3369,"@@ -157,6 +157,15 @@ def send_email(subject, message, sender, recipients, image_png=None):
+         send_email_smtp(config, sender, subject, message, recipients, image_png)
+ 
+ 
++def send_notification(subject, message, topic):
++    import boto.sns
++    config = configuration.get_config()
++    con = boto.sns.connect_to_region(config.get('sns', 'region', 'us-east-1'),
++                                     aws_access_key_id=config.get('sns', 'AWS_ACCESS_KEY', None),
++                                     aws_secret_access_key=config.get('sns', 'AWS_SECRET_KEY', None))
++    con.publish(topic, message, subject[:100])
++
++
+ def send_error_email(subject, message):
+     """"""
+     Sends an email to the configured error-email.",Name is _way_ to generic for this patch to be accepted I think. Can you rename it to maybe `send_sns_notification` or something else you find suitable?,Why not use `send_e
+3370,"@@ -31,7 +31,7 @@ func run() error {
+ 		return fmt.Errorf(""failed to load config file: %s"", err)
+ 	}
+ 
+-	logger := logging.BuildLogger(cfg.Logging.Level)
++	logger := logging.BuildLogger(*cfg.Logging.Level)
+ 	ctx := log.WithLogger(context.Background(), logger)
+ 
+ 	key, err := cfg.Eth.LoadKey()",Out of the scope.,Why is this change 
+3371,"@@ -151,4 +151,12 @@ if (typeof Object.assign != 'function') {
+     }
+     return to;
+   };
+-}
++}
++
++
++NodeList.prototype.forEach = function(callback, thisArg) {
++  thisArg = thisArg || window;
++  for (var i = 0; i < this.length; i++) {
++      callback.call(thisArg, this[i], i, this);
++  }
++};",I think we need an if block to check that if this API is really missing. We wouldn't want to override the browser's implementation.,Why do we need this
+3372,"@@ -89,6 +89,11 @@ function _getItem(name) {
+  * @param {Function} editorClass Editor class.
+  */
+ function _register(name, editorClass) {
++  if (name && typeof name !== 'string') {
++    editorClass = name;
++    name = editorClass.EDITOR_TYPE;
++  }
++
+   const editorWrapper = new RegisteredEditor(editorClass);
+ 
+   if (typeof name === 'string') {","I was wondering, things like EDITOR_TYPE, VALIDATOR_TYPE, RENDERER_TYPE are not obligatory. Therefore if the custom editor will be registered with this method, `name` will be set to `undefined`. Should we handle this scenario?",Why do we need this?
+3373,"@@ -1,7 +1,6 @@
+ // Copyright 2020 The Swarm Authors. All rights reserved.
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+-
+ package p2p
+ 
+ import (","This line should not be removed, as it is not the description of the package, but a copyright header.",// +build !windows
+3374,"@@ -37,6 +37,8 @@ type DiskBlockCacheMetadata struct {
+ 	TriggeredPrefetch bool `codec:""HasPrefetched""`
+ 	// whether the block's triggered prefetches are complete
+ 	FinishedPrefetch bool
++	// the last tag with which the block was marked
++	Tag string
+ }
+ 
+ // lruEntry is an entry for sorting LRU times",Wouldn't it be more space efficient to make this a `byte` enum or bitfield?,Why is this a string
+3375,"@@ -207,13 +207,13 @@ class PostgresTarget(luigi.Target):
+         connection.autocommit = True
+         cursor = connection.cursor()
+         if self.use_db_timestamps:
+-            sql = """""" CREATE TABLE {marker_table} (
++            sql = """""" CREATE TABLE IF NOT EXISTS {marker_table} (
+                       update_id TEXT PRIMARY KEY,
+                       target_table TEXT,
+                       inserted TIMESTAMP DEFAULT NOW())
+-                """""".format(marker_table=self.marker_table)
++                  """""".format(marker_table=self.marker_table)
+         else:
+-            sql = """""" CREATE TABLE {marker_table} (
++            sql = """""" CREATE TABLE IF NOT EXISTS {marker_table} (
+                       update_id TEXT PRIMARY KEY,
+                       target_table TEXT,
+                       inserted TIMESTAMP);","Flake8 doesn't like the assignment, but non-use of `e` here. I think we can just remove the try/except here for `cursor.execute(sql)`.",E501 line too long (
+3376,"@@ -0,0 +1,13 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.ast;
++
++/**
++ * Marker interface for type body declarations.
++ *
++ * @author Clément Fournier
++ */
++public interface ASTAnyTypeBodyDeclaration extends JavaNode {
++}","Maybe add short example list: .... type body declarations, such as AnnotationMembers, Methods, Fields",Why is this interface needed?
+3377,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+ 
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities",I don't think this is used an
+3378,"@@ -30,6 +30,15 @@ import org.apache.iceberg.io.LocationProvider;
+  */
+ public interface Table {
+ 
++  /**
++   * Return the full name for this table.
++   *
++   * @return this table's name
++   */
++  default String name() {
++    return toString();
++  }
++
+   /**
+    * Refresh the current table metadata.
+    */",It is debatable whether we have to default this. I did this to avoid breaking custom implementations.,Why do we need this method?
+3379,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done,I don't understand this chang
+3380,"@@ -8,7 +8,7 @@ import (
+ 	""fmt""
+ 	""strings""
+ 
+-	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/addons""
++	addon ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/addon""
+ 	awscloudformation ""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/cloudformation""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/ecr""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/s3""","we shouldn't need the ""addon"" rename",Why is this change needed?
+3381,"@@ -1,4 +1,6 @@
+ class Admin::DecksController < ApplicationController
++  before_filter :must_be_admin
++
+   def index
+     @decks = Deck.all
+   end",These are covered by routing constraints.,Extra empty line detected 
+3382,"@@ -32,7 +32,7 @@ import (
+ func (s *Service) InstanceIfExists(instanceID *string) (*v1alpha1.Instance, error) {
+ 	glog.V(2).Infof(""Looking for instance %q"", *instanceID)
+ 	input := &ec2.DescribeInstancesInput{
+-		InstanceIds: []*string{instanceID},
++		InstanceIds: aws.StringSlice([]string{*instanceID}),
+ 	}
+ 
+ 	out, err := s.EC2.DescribeInstances(input)",Could we use just a normal string here?,`aws.StringSlice([]string{
+3383,"@@ -1,6 +1,8 @@
+ import { VNode } from './vnode';
+ import options from './options';
++import { iterableToArray, isFunction } from './util';
+ 
++const hasSymbolSupport = isFunction(Symbol) && Symbol.iterator;
+ 
+ const stack = [];
+ ",`isFunction(Symbol)` triggers a `ReferenceError` if Symbol is undefined. Using `typeof Symbol === 'function'` is OK however.,I don't think we need the 
+3384,"@@ -140,6 +140,10 @@ void nano::election_scheduler::run ()
+ 					election->transition_active ();
+ 				}
+ 			}
++			else
++			{
++				lock.unlock ();
++			}
+ 			notify ();
+ 			lock.lock ();
+ 		}",Is there an else clause (with a lock.unlock ()) missing here as well? If we think we do not need an else clause then lets add an else clause containing assert zero.,Why do we need to unlock here?
+3385,"@@ -189,7 +189,7 @@ func dispense(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
+-	tx, err := c.SendPaymentFromUnencryptedWallet(cfg.Source, target, uint64(cfg.Fee), uint64(cfg.Amount), nil)
++	tx, err := c.SendPaymentFromUnencryptedWallet(cfg.Source, target, uint64(cfg.Fee), uint64(cfg.Amount), [32]byte{}, nil)
+ 	if err != nil {
+ 		http.Error(w, fmt.Sprintf(""failed to dispense money - %v"", err), http.StatusInternalServerError)
+ 		return","do we foresee `32` ever changing? (as well as its use in error checking in `clerk.go`) if ""no"" this is fine, if ""yes"" it's probably still fine",Why is this `[32]byte{}`?
+3386,"@@ -19,13 +19,14 @@ package org.openqa.selenium.remote;
+ 
+ import com.google.common.collect.ImmutableMap;
+ 
++import org.openqa.selenium.DeviceRotation;
+ import org.openqa.selenium.Rotatable;
+ import org.openqa.selenium.ScreenOrientation;
+ 
+ import java.lang.reflect.Method;
+ 
+ public class AddRotatable implements AugmenterProvider {
+-
++    
+   public Class<?> getDescribedInterface() {
+     return Rotatable.class;
+   }","you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)",Why this change?
+3387,"@@ -35,6 +35,12 @@ export default AuthenticatedRoute.extend(styleBody, CurrentUserSettings, Paginat
+                 });
+             }
+ 
++            // we need to load the roles into ember cache
++            // invites return role_id only and we do not offer a /role/:id endpoint
++            this.get('store').query('role', {permissions: 'assign'}).then((roles) => {
++                modelPromises.roles = roles;
++            });
++
+             return RSVP.hash(modelPromises);
+         });
+     },","This should be `modelPromises.roles = this.get('store').query('role', ...` and the promise body should just `return roles;`. This is because the `model()` hook will pause for the returned promises to be resolved before continuing so when returning `RSVP.hash` you end up with a hash containing the values returned from the promises so the controller and everything else relying on the `model` object doesn't need to worry about things being async.",I don't think we need the `the
+3388,"@@ -0,0 +1,19 @@
++const landmarks = axe.commons.aria.getRolesByType('landmark');
++const sectioning = ['article', 'aside', 'main', 'navigation', 'section'];
++const nodeIsHeader = node.tagName.toLowerCase() === 'header' && node.getAttribute('role') !== 'banner';
++var parent = axe.commons.dom.getComposedParent(node);
++
++while (parent){
++	var role = parent.getAttribute('role');
++	if (!role && (parent.tagName.toLowerCase() !== 'form')){
++		role = axe.commons.aria.implicitRole(parent);
++	}
++  if (role && nodeIsHeader && sectioning.includes(role)){
++    return true;
++  }
++	if (role && landmarks.includes(role)){
++		return false;
++	}
++	parent = axe.commons.dom.getComposedParent(parent);
++}
++return true;","This is basically a repeat of `main-is-top-level.js`. I suggest having these 3 checks point to the same evaluate file. You can change what element they test through the rule selector as well as the check.json options property. So you would have `main-is-top-level.json`, `banner-is-top-level.json` and `contentinfo-is-top-level.json` each point to `landmark-is-top-level.js`, and pass in a different `options` object which tells it what element you're trying to test.",I don't think you need the `.toLowerCase()` here.
+3389,"@@ -63,13 +63,13 @@ public class PackageListeners {
+   }
+ 
+   synchronized void packagesUpdated(List<PackageLoader.Package> pkgs) {
+-    MDCLoggingContext.setCore(core);
++    if(core != null) MDCLoggingContext.setCore(core);
+     try {
+       for (PackageLoader.Package pkgInfo : pkgs) {
+         invokeListeners(pkgInfo);
+       }
+     } finally {
+-      MDCLoggingContext.clear();
++      if(core != null) MDCLoggingContext.clear();
+     }
+   }
+ ",Why do we need this check? setCore already handles nulls.,Why is this needed?
+3390,"@@ -121,7 +121,7 @@ def _inject(target_type, inject_type):
+     # Inject all the methods from the hierarchy:
+     setattr(target_type, ""__getattr__"", inject_type.__getattr__)
+     setattr(target_type, ""__getitem__"", inject_type.__getitem__)
+-    for attr in [""__iter__"", ""__len__"", ""__invert__"", ""__setitem__""]:
++    for attr in [""__iter__"", ""__len__"", ""__invert__"", ""__setitem__"", ""__dir__""]:
+         if hasattr(inject_type, attr):
+             setattr(target_type, attr, inject_type.__dict__[attr])
+     for t in mro:","good catch, thanks. This is going to make the user experience much better.",Why is this needed?
+3391,"@@ -1,4 +1,4 @@
+-import { options } from 'preact';
++import { Component, options } from 'preact';
+ 
+ /** @type {number} */
+ let currentIndex;",TODO: remove this unused import,Why is this change needed?
+3392,"@@ -591,7 +591,7 @@ func (s *HandlerTestSuite) TestValidateJWTSVID() {
+ 			},
+ 			workloadUpdate: &cache.WorkloadUpdate{},
+ 			code:           codes.InvalidArgument,
+-			msg:            ""token contains an invalid number of segments"",
++			msg:            ""square/go-jose: compact JWS format must have three parts"",
+ 		},
+ 		{
+ 			name: ""validated by our trust domain bundle"",","Hmm leaking the library name out in the Workload API doesn't seem great. Do we want to catch these errors and return a canned ""could not parse token"" or something instead?",I think this should be `square/go-jose: compact JWT format must have three parts`
+3393,"@@ -9,12 +9,14 @@ module Travis
+         }
+ 
+         def install
+-          self.if   '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
++          self.if   '-f ./gradlew',    './gradlew assemble', fold: 'install', retry: true
++          self.elif '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
+           self.elif '-f pom.xml',      'mvn install -DskipTests=true -B', fold: 'install', retry: true # Otherwise mvn install will run tests which. Suggestion from Charles Nutter. MK.
+         end
+ 
+         def script
+-          self.if   '-f build.gradle', 'gradle check'
++          self.if   '-f ./gradlew',    './gradlew check'
++          self.elif '-f build.gradle', 'gradle check'
+           self.elif '-f pom.xml',      'mvn test -B'
+           self.else                    'ant test'
+         end",I think `-f gradlew` is better for code unity,Why do we need to do this?
+3394,"@@ -40,4 +40,10 @@ public class FlinkConfigOptions {
+           .intType()
+           .defaultValue(100)
+           .withDescription(""Sets max infer parallelism for source operator."");
++
++  public static final ConfigOption<Integer> SOURCE_READER_FETCH_RECORD_BATCH_SIZE = ConfigOptions
++      .key(""source.iceberg.reader.fetch-record-batch-size"")
++      .intType()
++      .defaultValue(2048)
++      .withDescription(""The target record batch size for split reader fetch."");
+ }",Is there precedent for this config key? What other keys are similar? The others in this file start with `table.exec.iceberg`. Is there a reason for not continuing with that convention?,This should be `source.iceberg.reader.fetch-record-batch-size`
+3395,"@@ -1,4 +1,4 @@
+-using System;
++using System;
+ using System.Collections.Generic;
+ using System.Globalization;
+ using System.Linq.Expressions;",Can we avoid no-change changes being committed - they make it harder to distinguish actual changes from code editor changes,Why this change?
+3396,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[UpdateServerCertificate.java demonstrates how to update the name of an AWS Identity and Access Management (IAM) server certificate.]
++//snippet-sourcedescription:[UpdateServerCertificate.java demonstrates how to update the name of an AWS Identity and Access Management (AWS IAM) server certificate.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),Why did you change this?
+3397,"@@ -83,14 +83,10 @@ func NewCommand(licenseCommandName string) *cli.Command {
+ 			cmd.RegisterSignalCallback(func() { errorChannel <- nil })
+ 
+ 			cmdService := &serviceCommand{
+-				tequilapi:    client.NewClient(nodeOptions.TequilapiAddress, nodeOptions.TequilapiPort),
+-				errorChannel: errorChannel,
+-				identityHandler: identity_selector.NewHandler(
+-					di.IdentityManager,
+-					di.MysteriumAPI,
+-					identity.NewIdentityCache(nodeOptions.Directories.Keystore, ""remember.json""),
+-					di.SignerFactory),
+-				ap: parseAccessPolicyFlag(ctx),
++				tequilapi:       client.NewClient(nodeOptions.TequilapiAddress, nodeOptions.TequilapiPort),
++				errorChannel:    errorChannel,
++				identityHandler: di.IdentitySelector,
++				ap:              parseAccessPolicyFlag(ctx),
+ 			}
+ 
+ 			go func() {",You dont use this dependency anymore,Why do we need the `di.S
+3398,"@@ -86,6 +86,8 @@ public abstract class AbstractSmartStoreTest extends SmartStoreTestCase {
+ 
+ 		assertTrue(""ENABLE_FTS4 flag not found in compile options"", compileOptions.contains(""ENABLE_FTS4""));
+ 		assertTrue(""ENABLE_FTS3_PARENTHESIS flag not found in compile options"", compileOptions.contains(""ENABLE_FTS3_PARENTHESIS""));
++		assertTrue(""ENABLE_FTS5 flag not found in compile options"", compileOptions.contains(""ENABLE_FTS5""));
++		assertTrue(""ENABLE_JSON1 flag not found in compile options"", compileOptions.contains(""ENABLE_JSON1""));
+ 	}
+ 
+ 	/**",Here is the test that checks that the sqlcipher in use was compiled with the right flags,I think it would be bett
+3399,"@@ -199,6 +199,8 @@ public class LoginServerManager {
+ 		} catch (Exception e) {
+ 			Log.w(""LoginServerManager.getLoginServersFromRuntimeConfig"",
+ 					""Exception thrown while attempting to read array, attempting to read string value instead"");
++		}
++		if (mdmLoginServers == null) {
+ 			final String loginServer = runtimeConfig.getString(ConfigKey.AppServiceHosts);
+ 			if (!TextUtils.isEmpty(loginServer)) {
+ 				mdmLoginServers = new String[] {loginServer};","Turns out that if the hosts are not in an `array`, an `Exception` is not thrown anymore :-( It simply returns `null`. So, we need to attempt to parse a `string` outside the `catch` block for it to work.",Why is this change neede
+3400,"@@ -16,8 +16,12 @@
+ 
+ package io.servicecomb.provider.springmvc.reference;
+ 
++import java.net.URI;
++
+ import org.junit.Assert;
+ import org.junit.Test;
++import org.springframework.web.client.RestClientException;
++import org.springframework.web.client.RestTemplate;
+ 
+ public class TestRestTemplateBuilder {
+ ",this test only covers the happy path. what about no acceptable rest template found?,Why is this needed?
+3401,"@@ -582,7 +582,7 @@ public class DistributorTest {
+         );
+ 
+         Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession();
+-        LOG.info(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
++        LOG.finer(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
+ 
+         boolean inFirefoxNodes = firefoxNodes.stream().anyMatch(node -> node.getUri().equals(firefoxSession.getUri()));
+         boolean inChromeNodes = chromeNodes.stream().anyMatch(node -> node.getUri().equals(chromeSession.getUri()));","Since this is in a test, I imagine that the choice of `info` level was deliberate.",Why is this being c
+3402,"@@ -3,9 +3,10 @@ package langserver
+ import (
+ 	""context""
+ 	""github.com/stretchr/testify/assert""
+-	""strings""
+ 	""testing""
+ 
++	""core""
++	""strings""
+ 	""tools/build_langserver/lsp""
+ )
+ ",this should probably be named somewhere if you want to reuse it.,Why did you change 
+3403,"@@ -191,6 +191,14 @@ const (
+ 	// path where we mount in the SSH key for connecting to the bare metal libvirt provisioning host.
+ 	LibvirtSSHPrivKeyPathEnvVar = ""LIBVIRT_SSH_PRIV_KEY_PATH""
+ 
++	// BoundServiceAccountSigningKeyEnvVar contains the path to the bound service account signing key and
++	// is set in the install pod for AWS STS clusters.
++	BoundServiceAccountSigningKeyEnvVar = ""AWS_BOUND_SA_SIGNING_KEY""
++
++	// BoundServiceAccountSigningKeyFile is the Secret key and projected filename where an AWS STS
++	// SA signing key will be projected into the install pod.
++	BoundServiceAccountSigningKeyFile = ""bound-service-account-signing-key.key""
++
+ 	// FakeClusterInstallEnvVar is the environment variable Hive will set for the installmanager pod to request
+ 	// a fake install.
+ 	FakeClusterInstallEnvVar = ""FAKE_INSTALL""",needs a rename to not include AWS,I don't think we ne
+3404,"@@ -15,13 +15,11 @@
+ *******************************************************************************/
+ 
+ #include ""oneapi/dal/algo/rbf_kernel/backend/gpu/compute_kernel.hpp""
+-#include ""oneapi/dal/backend/interop/common_dpc.hpp""
+-#include ""oneapi/dal/backend/interop/table_conversion.hpp""
+-
++#include ""oneapi/dal/backend/primitives/reduction.hpp""
++#include ""oneapi/dal/backend/primitives/blas.hpp""
++#include ""oneapi/dal/backend/math.hpp""
+ #include ""oneapi/dal/table/row_accessor.hpp""
+ 
+-#include <daal/src/algorithms/kernel_function/oneapi/kernel_function_rbf_kernel_oneapi.h>
+-
+ namespace oneapi::dal::rbf_kernel::backend {
+ 
+ using dal::backend::context_gpu;",Isn't sigma have `double` type?,"#include ""oneapi/dal/backend/math.hpp"""
+3405,"@@ -977,6 +977,7 @@ TEST (rpc, wallet_create_seed)
+ 	nano::system system (24000, 1);
+ 	scoped_io_thread_name_change scoped_thread_name_io;
+ 	nano::raw_key seed;
++	seed.data = 1;
+ 	auto prv = nano::deterministic_key (seed, 0);
+ 	auto pub (nano::pub_key (prv));
+ 	auto node = system.nodes.front ();",May be better use nano::keypair that generates ramdom value?,Why is this needed?
+3406,"@@ -25,7 +25,11 @@ const isPromiseLike = require('../utils').isPromiseLike;
+ function addToOperationsList(bulkOperation, docType, document) {
+   // Get the bsonSize
+   const bsonSize = bson.calculateObjectSize(document, {
+-    checkKeys: false
++    checkKeys: false,
++
++    // Since we don't know what the user selected for BSON options here,
++    // err on the safe side, and check the size with ignoreUndefined: false.
++    ignoreUndefined: false
+   });
+ 
+   // Throw error if the doc is bigger than the max BSON size","I think the more complete solution will save off a `ignoreUndefined` in the base class for the bulk operation (with a default of `false`), and use that for calculations. Was there a reason you didn't want to support the option from the operation level?",I don't think this is the right way to
+3407,"@@ -257,6 +257,10 @@ public class SyncManager {
+                             break;
+                     }
+                     updateSync(sync, SyncState.Status.DONE, 100, callback);
++                } catch (RestClient.RefreshTokenRevokedException re) {
++                    logger.e(this, ""runSync"", re);
++                    // Do not do anything - let the logout go through!
++
+                 } catch (Exception e) {
+                     logger.e(this, ""runSync"", e);
+                     // Update status to failed","The catch (Exception e) block that follows does an updateSync, which will get a SmartStore instance (while logging out is taking place) - and then terrible things will happen - a database gets created for the outgoing user that won't be openable by the returning user causing the app to crash at logout. This is a somewhat superficial fix - SmartStore should not return an instance for an outgoing user.",Shouldn't this be `logger.warn`?
+3408,"@@ -27,6 +27,11 @@ func TestCodestar_WaitUntilStatusAvailable(t *testing.T) {
+ 		connection := &CodeStar{}
+ 		connectionARN := ""mockConnectionARN""
+ 
++		ctrl := gomock.NewController(t)
++		defer ctrl.Finish()
++		m := mocks.NewMockapi(ctrl)
++		m.EXPECT().GetConnection(gomock.Any()).AnyTimes()
++
+ 		// WHEN
+ 		err := connection.WaitUntilConnectionStatusAvailable(ctx, connectionARN)
+ ",huh does this work without a `Return`?,Why do we need this?
+3409,"@@ -134,11 +134,7 @@ module RSpec
+                 # no-op, required metadata has already been set by the `skip`
+                 # method.
+               rescue Exception => e
+-                if pending?
+-                  metadata[:execution_result][:pending_exception] = e
+-                else
+-                  set_exception(e)
+-                end
++                set_exception(e)
+               ensure
+                 run_after_each
+               end","Don't think we want this line, right? (Plus ""failing"" is spelled wrong).",Why is this being re
+3410,"@@ -105,6 +105,10 @@ public class FeedItemMenuHandler {
+ 
+         setItemVisibility(menu, R.id.remove_item, fileDownloaded);
+ 
++        if (selectedItem.getFeed().isLocalFeed()) {
++            setItemVisibility(menu, R.id.share_item, false);
++        }
++
+         return true;
+     }
+ ","I think it would be more clear to have local-feed-hiding all in one place (bottom of this method?). Further up the method, there already is some code that hides the website icon, for example.",Shouldn't this be `t
+3411,"@@ -199,14 +199,6 @@ class BackendMenuBuilder implements BackendMenuBuilderInterface
+             ],
+         ]);
+ 
+-        $menu->getChild('Maintenance')->addChild('Fixtures', [
+-            'uri' => '',
+-            'extras' => [
+-                'name' => $t->trans('caption.fixtures_dummy_content'),
+-                'icon' => 'fa-hat-wizard',
+-            ],
+-        ]);
+-
+         $menu->getChild('Maintenance')->addChild('Clear the cache', [
+             'uri' => $this->urlGenerator->generate('bolt_clear_cache'),
+             'extras' => [","Why remove this one? It doesn't work yet, but we'll add it sooner or later.",Why did you remove t
+3412,"@@ -304,12 +304,12 @@ type docstruct struct {
+ 	DocstoreRevision interface{}
+ 	Etag             interface{}
+ 
+-	I  int                    `docstore:""i""`
+-	U  uint                   `docstore:""u""`
+-	F  float64                `docstore:""f""`
+-	St string                 `docstore:""st""`
+-	B  bool                   `docstore:""b""`
+-	M  map[string]interface{} `docstore:""m""`
++	I  int
++	U  uint
++	F  float64
++	St string
++	B  bool
++	M  map[string]interface{}
+ }
+ 
+ func nonexistentDoc() docmap { return docmap{KeyField: ""doesNotExist""} }",Why did you remove the struct tags?,Why did you remove the `docstore` prefix?
+3413,"@@ -178,6 +178,11 @@ class FinalStatus(Reporter, AggregatorListener, FunctionalAggregatorListener):
+     def __dump_xml(self, filename):
+         self.log.info(""Dumping final status as XML: %s"", filename)
+         root = etree.Element(""FinalStatus"")
++        report_info = get_bza_report_info(self.engine, self.log)
++        if report_info:
++            link, text = report_info[0]
++            report_element = etree.Element(""BlazeMeterReport"", link=link, name=text)
++            root.append(report_element)
+         if self.last_sec:
+             for label, kpiset in iteritems(self.last_sec[DataPoint.CUMULATIVE]):
+                 root.append(self.__get_xml_summary(label, kpiset))","Let's be neutral with tag names. Let's just have ""ReportURL""",I don't think you need the `if` statement
+3414,"@@ -265,7 +265,8 @@ func TestEmptySpanData(t *testing.T) {
+ func TestSpanData(t *testing.T) {
+ 	// Full test of span data transform.
+ 
+-	startTime := time.Now()
++	// March 31, 2020 5:01:26 1234nanos (UTC)
++	startTime := time.Unix(1585674086, 1234)
+ 	endTime := startTime.Add(10 * time.Second)
+ 	spanData := &export.SpanData{
+ 		SpanContext: core.SpanContext{",Use an explicit time to ensure conversion is not copy-paste and wrong.,Why is this change needed?
+3415,"@@ -804,7 +804,11 @@ void handle_lookup_account_poll(GUI_RPC_CONN& grc) {
+             grc.lookup_account_op.error_num
+         );
+     } else {
+-        grc.mfout.printf(""%s"", grc.lookup_account_op.reply.c_str());
++        const char *p = grc.lookup_account_op.reply.c_str();
++        const char *q = strstr(p, ""<account_out""); 
++        if (!q) q = strstr(p, ""<error"");
++        if (!q) q = ""<account_out/>\n""; 
++        grc.mfout.printf(""%s"", q); 
+     }
+ }
+ ",The logic now is to look for `<account_out` if that is present return the string starting from there. If it is not present look for `<error` and return the string from there (which can produce malformed XML because you do not check if the closing tag matches). If this is also not found return an empty `<account_out/>`. This `<error>` output is also not consistent with the other two functions you mentioned. Do the other two RPCs not report an error?,This should be `const char *p = grc.looku
+3416,"@@ -0,0 +1,12 @@
++class Api::V1::VideosController < ApiController
++  def index
++    show = find_show
++    render json: { videos: show.videos }
++  end
++
++  private
++
++  def find_show
++    Show.friendly.find(params[:show_id])
++  end
++end",Use nested module/class definitions instead of compact style.,Use nested module/class definitions instead of compact style.
+3417,"@@ -56,6 +56,7 @@ var individualTestTimeout = 10 * time.Second
+ 
+ func kbfsOpsInit(t *testing.T, changeMd bool) (mockCtrl *gomock.Controller,
+ 	config *ConfigMock, ctx context.Context, cancel context.CancelFunc) {
++	t.Log(""Init KBFSOps"")
+ 	ctr := NewSafeTestReporter(t)
+ 	mockCtrl = gomock.NewController(ctr)
+ 	config = NewConfigMock(mockCtrl, ctr)","Do you think we need to keep this in, or is it just leftover personal debugging? Seems like it wouldn't be too useful most of the time, but I don't care too much if you want to keep it.",Is this intentional?
+3418,"@@ -95,7 +95,7 @@ public class FreezeTimersOverlay extends Overlay
+ 	{
+ 		final Player player = playerDespawned.getPlayer();
+ 		// All despawns ok: death, teleports, log out, runs away from screen
+-		if (config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng() | config.TB())
++		if (config.showPlayers() | config.showNpcs() | config.FreezeTimers() | config.Veng())
+ 		{
+ 			this.remove(player);
+ 		}",showNPCs is not needed,Why was this removed?
+3419,"@@ -0,0 +1,12 @@
++package ssm
++
++import ""fmt""
++
++// ErrParameterAlreadyExists occurs when the parameter with name already existed.
++type ErrParameterAlreadyExists struct {
++	name string
++}
++
++func (e *ErrParameterAlreadyExists) Error() string {
++	return fmt.Sprintf(""parameter %s already exists"", e.name)
++}",Docstring for public function pls,Why do we need this?
+3420,"@@ -1539,3 +1539,16 @@ func TestSSIReApplyDuration(t *testing.T) {
+ 		}
+ 	}
+ }
++
++func TestFilterApplyError(t *testing.T) {
++	err1 := ""error when creating \""/tmp/apply-475927931\"": namespaces \""openshift-am-config\"" not found""
++	expectedFilteredErr1 := ""namespaces \""openshift-am-config\"" not found""
++	if filterApplyError(err1) != expectedFilteredErr1 {
++		t.Fatalf(""expected temporary file to be trimmed from error message"")
++	}
++
++	err2 := ""unable to parse \""[ { \\\""op\\\"": \\\""replace\\\"", \\\""path\\\"": \\\""/data/foo\\\"", \\\""value\\\"": \\\""baz-json\\\"" ]\"": yaml: did not find expected ',' or '}'""
++	if filterApplyError(err2) != err2 {
++		t.Fatalf(""expected error message to be unchanged"")
++	}
++}",This should use `t.Errorf` instead. You want the second part of the test to run even when the first part fails.,I don't think this test is needed.
+3421,"@@ -715,7 +715,7 @@ int main(int argc, char **argv)
+ #endif
+     }
+ 
+-    if (ctx.http3 != NULL) {
++    if (ctx.protocol_selector.ratio.http3 > 0) {
+         h2o_quic_close_all_connections(&ctx.http3->h3);
+         while (h2o_quic_num_connections(&ctx.http3->h3) != 0) {
+ #if H2O_USE_LIBUV","Should this if block better be changed to `#if H2O_USE_LIBUV \n #else ... #endif`? The reason I wonder is because that's the way the QUIC context is being initilaized at the beginning of this function. Though I would not expect practical difference between the two approaches, because ATM the only case where we create QUIC connections is when the protocol selector is set to non-zero, and because when it is set to non-zero `h2o_quiy_close_all_connections` becomes a no-op.",Shouldn't this be `> 0`?
+3422,"@@ -87,8 +87,11 @@ export function useReducer(reducer, initialState, init) {
+ 			init == null ? invokeOrReturn(null, initialState) : init(initialState),
+ 
+ 			action => {
+-				hookState._value[0] = reducer(hookState._value[0], action);
+-				hookState._component.setState({});
++				const nextValue = reducer(hookState._value[0], action);
++				if (!Object.is(hookState._value[0], nextValue)) {
++					hookState._value[0] = nextValue;
++					hookState._component.setState({});
++				}
+ 			}
+ 		];
+ 	}",`Object.is` is an ES6 feature of JS so I don't think we can use it here (or we have to change our browser support matrix or specify that an Object.is polyfill is pre-req of `preact/hooks`). Should we just do an `===` check in `preact/hooks` and provide a `Object.is` polyfill and version of `useReducer` in `preact/compat`?,Why do we need this check?
+3423,"@@ -22,7 +22,11 @@ class AddUserOperation extends CommandOperation {
+     const options = this.options;
+ 
+     // Get additional values
+-    let roles = Array.isArray(options.roles) ? options.roles : [];
++    let roles = Array.isArray(options.roles)
++      ? options.roles
++      : typeof options.roles === 'string'
++      ? [options.roles]
++      : [];
+ 
+     // If not roles defined print deprecated message
+     // TODO: handle deprecation properly","This was a bug I picked up by using the TS interface as a guide, this seems like it was / is the intention, also is a bug in master (needs port)",Why do we need this change?
+3424,"@@ -80,6 +80,17 @@ public interface CollectionAdminParams {
+    */
+   String COLL_CONF = ""collection.configName"";
+ 
++  /**
++   * The name of the collection with which a collection is to be co-located
++   */
++  String WITH_COLLECTION = ""withCollection"";
++
++  /**
++   * The reverse-link to WITH_COLLECTION flag. It is stored in the cluster state of the `withCollection`
++   * and points to the collection on which the `withCollection` was specified.
++   */
++  String COLOCATED_WITH = ""COLOCATED_WITH"";
++
+   /**
+    * Used by cluster properties API as a wrapper key to provide defaults for collection, cluster etc.
+    *",It would be helpful to explicit here what this really means and assumes.,Why do we need this?
+3425,"@@ -46,6 +46,9 @@ type AddressKey struct {
+ 	PriKey      keypair.PrivateKey
+ }
+ 
++//ExpectedBalances records expectd balances of admins and delegates
++var ExpectedBalances map[string]*big.Int
++
+ // LoadAddresses loads key pairs from key pair path and construct addresses
+ func LoadAddresses(keypairsPath string, chainID uint32) ([]*AddressKey, error) {
+ 	// Load Senders' public/private key pairs",`ExpectedBalances` is a global variable (from `gochecknoglobals`),`// ExpectedBalances
+3426,"@@ -1,7 +1,7 @@
+ module RSpec
+   module Core
+     module Formatters
+-      # This class extracts code snippets by looking at the backtrace of the passed error
++      # Extracts code snippets by looking at the backtrace of the passed error and applies synax highlighting and line numbers using html.
+       class SnippetExtractor
+         class NullConverter; def convert(code, pre); code; end; end
+ ","This is another place where I'd feel more comfortable with declaring the class private. We can always make it public in the future if someone makes a case for that, but I prefer to err on the side of privateness for things like this that 99% of RSpec users won't have a reason to use.",I'm not sure if this
+3427,"@@ -57,11 +57,14 @@ func addAccountToMemResolver(s *Server, pub, jwtclaim string) {
+ 	s.mu.Unlock()
+ }
+ 
+-func createClient(t *testing.T, s *Server, akp nkeys.KeyPair) (*client, *bufio.Reader, string) {
++func createClient(t *testing.T, s *Server, akp nkeys.KeyPair, optIssuerAccount string) (*client, *bufio.Reader, string) {
+ 	t.Helper()
+ 	nkp, _ := nkeys.CreateUser()
+ 	pub, _ := nkp.PublicKey()
+ 	nuc := jwt.NewUserClaims(pub)
++	if optIssuerAccount != """" {
++		nuc.IssuerAccount = optIssuerAccount
++	}
+ 	ujwt, err := nuc.Encode(akp)
+ 	if err != nil {
+ 		t.Fatalf(""Error generating user JWT: %v"", err)","Feels like this should be left as is and add a new createClientWithIssuers or something like that. Avoid all the """"",nit: `optIssuerAccou
+3428,"@@ -129,6 +129,9 @@ public class SPRequestHandler {
+ 
+     private void handleError(String error) {
+         SalesforceSDKLogger.e(TAG, ""Error received from IDP app: "" + error);
++        if (authCallback != null) {
++            authCallback.receivedErrorResponse(error);
++        }
+     }
+ 
+     private void handleSuccess(String code, String loginUrl) {",Minor unrelated bug in the IDP flow where the error wasn't getting displayed as a `Toast`.,I don't think we need to check for null here.
+3429,"@@ -3,6 +3,7 @@ var assert = require('assert');
+ var Transform = require('stream').Transform;
+ const MongoError = require('../../lib/core').MongoError;
+ var MongoNetworkError = require('../../lib/core').MongoNetworkError;
++var mongoErrorContextSymbol = require('../../lib/core').mongoErrorContextSymbol;
+ var setupDatabase = require('./shared').setupDatabase;
+ var delay = require('./shared').delay;
+ var co = require('co');",I thought we got rid of this thing?,Why do we need this?
+3430,"@@ -83,15 +83,8 @@ class TaintNodeData
+     public $column_to;
+ 
+     /**
+-     * @param string $label
+-     * @param string $entry_path_type
+-     * @param ?string $entry_path_description
+      * @param int $line_from
+      * @param int $line_to
+-     * @param string $file_name
+-     * @param string $file_path
+-     * @param string $snippet
+-     * @param string $selected_text
+      * @param int $from
+      * @param int $to
+      * @param int $snippet_from",Please convert int params as well.,Why are these removed?
+3431,"@@ -84,7 +84,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                 var lastComponent = components.Last();
+                 messageLines.Add(
+                     string.Format(
+-                        CultureInfo.InvariantCulture, ""{0}:{1} {2} {3}: {4}"",
++                        CultureInfo.InvariantCulture, ""{0}{1}: {2} {3}: {4}"",
+                         lastComponent.Uri.AbsolutePath,
+                         lastComponent.Region.FormatForVisualStudio(),
+                         result.Kind.FormatForVisualStudio(),","Fixed bug in implementation. Now I can run the validator from the VS Tools menu, double-click on an output line, and navigate to the site of the issue.",Why is this change needed?
+3432,"@@ -230,6 +230,18 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+ 
++        /// <summary>
++        /// Configuration key for the application's servers http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpServerErrorStatuses""/>
++        public const string HttpServerErrors = ""DD_HTTP_SERVER_ERROR_STATUSES"";
++
++        /// <summary>
++        /// Configuration key for the application's client http statuses to set spans as errors by.
++        /// </summary>
++        /// <seealso cref=""TracerSettings.HttpClientErrorStatuses""/>
++        public const string HttpClientErrors = ""DD_HTTP_CLIENT_ERROR_STATUSES"";
++
+         /// <summary>
+         /// String format patterns used to match integration-specific configuration keys.
+         /// </summary>","Can we rename this field to `HttpServerErrorCodes` or `HttpServerErrorStatuses`? It will contain a list of status _codes_, not a list of _errors_. (Personally I prefer ""codes"" over ""statuses"", but we can't change `DD_HTTP_SERVER_ERROR_CODES`.)",Should this be `DD_HTTP_CLIENT_ERROR_STATUSES`?
+3433,"@@ -134,8 +134,17 @@ struct flb_systemd_config *flb_systemd_config_create(struct flb_input_instance *
+         sd_journal_add_disjunction(ctx->j);
+     }
+ 
+-    /* Always seek to head */
+-    sd_journal_seek_head(ctx->j);
++    /* Seek to head by default or tail if specified in configuration */
++    tmp = flb_input_get_property(""read_from_tail"", i_ins);
++    if (tmp && strcasecmp(tmp, ""true"") == 0) {
++        sd_journal_seek_tail(ctx->j);
++
++        /* Skip last entry */
++        sd_journal_next_skip(ctx->j, 1);
++    }
++    else {
++        sd_journal_seek_head(ctx->j);
++    }
+ 
+     /* Check if we have a cursor in our database */
+     if (ctx->db) {","would you please use: flb_utils_bool(...) here ?, that function wraps the on/off/true/false stuff.",I don't think this is the right way to do this.
+3434,"@@ -178,7 +178,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                                 analyzeOptions.Verbose,
+                                 targets,
+                                 analyzeOptions.ComputeTargetsHash,
+-                                Prerelease)),
++                                Prerelease,
++                                null)),
+                     (ex) =>
+                     {
+                         Errors.LogExceptionCreatingLogFile(context, filePath, ex);","`invocationInfoTokensToRedact: null` (I really like the convention of using a named parameter whenever the value doesn't communicate the meaning, such as for literal values.)",Why are we passing `null` here?
+3435,"@@ -61,6 +61,10 @@ class BaseDetector(nn.Module):
+         """"""
+         pass
+ 
++    @abstractmethod
++    async def async_test(self, img, img_meta, **kwargs):
++        pass
++
+     @abstractmethod
+     def simple_test(self, img, img_meta, **kwargs):
+         pass",maybe renamed to `async_simple_test` if we consider supporting aug test later on?,Why do we need this?
+3436,"@@ -113,7 +113,7 @@ module Mongoid #:nodoc:
+     # @return [ Document ] A new document.
+     def initialize(attrs = nil)
+       @new_record = true
+-      @attributes = default_attributes
++      @attributes = apply_default_attributes
+       process(attrs) do |document|
+         yield self if block_given?
+         identify","So where is default_attributes now? Is it used anywhere else still? If not, can it be removed along with any tests of it?",Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+3437,"@@ -42,9 +42,9 @@ namespace OpenTelemetry.Metrics.Aggregators
+         {
+             return new DoubleSumData
+             {
+-                StartTimestamp = new DateTime(this.GetLastStartTimestamp().Ticks),
++                StartTimestamp = new DateTime(this.GetLastStartTimestamp().Ticks, DateTimeKind.Utc),
+                 Sum = this.checkPoint,
+-                Timestamp = new DateTime(this.GetLastEndTimestamp().Ticks),
++                Timestamp = new DateTime(this.GetLastEndTimestamp().Ticks, DateTimeKind.Utc),
+             };
+         }
+ ",We could move this to the base class and remove all these changes. What do you think?,Why do we need to change this?
+3438,"@@ -13,6 +13,7 @@ feature ""subscriber requests access to beta trail"" do
+ 
+     click_on ""Request Access""
+ 
++    expect(page).to have_content(I18n.t(""beta.replies.flashes.success""))
+     expect(page).not_to have_content(""Exciting Beta Trail"")
+   end
+ end","While we're doing some translation work, could you extract this button text and the other static text from the view?",Line is too long. [81/80]
+3439,"@@ -181,6 +181,12 @@ public class JobCallbackUtil {
+         String headersKeyPerSequence =
+             headersKey.replace(SEQUENCE_TOKEN, sequenceStr);
+         String headersValue = props.get(headersKeyPerSequence);
++		
++		// replace all the tokens in the header
++		if(headersValue != null)  {
++			headersValue = replaceTokens(headersValue, contextInfo, false);
++		}
++		
+         privateLogger.info(""headers: "" + headersValue);
+         Header[] headers = parseHttpHeaders(headersValue);
+         if (headers != null) {",Nit: Please fix indentation (note: Azkaban uses 2 spaces and not tabs).,Why do we need this?
+3440,"@@ -60,7 +60,7 @@ module.exports = {
+         TestCase.assertEqual(defaultRealm.schemaVersion, 0);
+ 
+         TestCase.assertThrows(function() {
+-            new Realm({schemaVersion: 1});
++            new Realm({schemaVersion: 1, schema: []});
+         }, ""Realm already opened at a different schema version"");
+         
+         TestCase.assertEqual(new Realm().schemaVersion, 0);",This change is necessary because the schema version is ignored unless a schema is specified. I think that has always been the intent.,Why is this needed?
+3441,"@@ -2712,6 +2712,7 @@ dr_get_os_version(dr_os_version_info_t *info)
+     get_os_version_ex(&ver, &sp_major, &sp_minor);
+     if (info->size > offsetof(dr_os_version_info_t, version)) {
+         switch (ver) {
++        case WINDOWS_VERSION_10_1803: info->version = DR_WINDOWS_VERSION_10_1803; break;
+         case WINDOWS_VERSION_10_1709: info->version = DR_WINDOWS_VERSION_10_1709; break;
+         case WINDOWS_VERSION_10_1703: info->version = DR_WINDOWS_VERSION_10_1703; break;
+         case WINDOWS_VERSION_10_1607: info->version = DR_WINDOWS_VERSION_10_1607; break;","The api/docs/release.dox changelog message is missing: maybe you planned to add it once NtAllocateVirtualMemoryEx and NtMapViewOfSectionEx support is in? I would say, add it here in the same diff that raises max_supported_os_version.",Why is this needed?
+3442,"@@ -0,0 +1,6 @@
++var aria = 'aria-hidden';
++if (node && node.hasAttribute(aria)) {
++	return false;
++}
++
++return true;",Just do: `return node.hasAttribute('aria-hidden')`,Why do we need this
+3443,"@@ -10,6 +10,18 @@ describe ""Saved Searches"" do
+     click_link 'Saved Searches'
+     expect(page).to have_content 'You have no saved searches'
+   end
++  
++  it 'can be saved and forgotten from a search result' do
++    visit catalog_index_path(q: 'book')
++    within '.search-widgets' do
++      click_button 'save'
++    end
++    expect(page).to have_content 'Successfully saved your search.'
++    within '.search-widgets' do
++      click_button 'forget'
++    end
++    expect(page).to have_content 'Successfully removed that saved search.'
++  end
+ 
+   describe ""with a saved search 'book'"" do
+     before do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Layout/EmptyLinesAr
+3444,"@@ -9,7 +9,10 @@ namespace Datadog.Trace.Util
+     internal static class DomainMetadata
+     {
+         private const string UnknownName = ""unknown"";
+-        private static Process _currentProcess;
++        private static bool _initialized;
++        private static string _currentProcessName;
++        private static string _currentProcessMachineName;
++        private static int _currentProcessId;
+         private static bool _processDataPoisoned;
+         private static bool _domainDataPoisoned;
+         private static bool? _isAppInsightsAppDomain;",Do we need `_processDataPoisoned`? Can the name or the id of the current process ever change? Or the machine name?,Why do we need this?
+3445,"@@ -114,10 +114,17 @@ func run(ctx context.Context, cfg cmds.Agent, proxy proxy.Proxy) error {
+ 			return err
+ 		}
+ 	}
++
++	notifySocket := os.Getenv(""NOTIFY_SOCKET"")
++	os.Unsetenv(""NOTIFY_SOCKET"")
++
+ 	if err := setupTunnelAndRunAgent(ctx, nodeConfig, cfg, proxy); err != nil {
+ 		return err
+ 	}
+ 
++	os.Setenv(""NOTIFY_SOCKET"", notifySocket)
++	systemd.SdNotify(true, ""READY=1\n"")
++
+ 	coreClient, err := coreClient(nodeConfig.AgentConfig.KubeConfigKubelet)
+ 	if err != nil {
+ 		return err",Did it not work out to wait until after containerd and kubelet are started?,Why do we need this?
+3446,"@@ -159,6 +159,10 @@ const std::unordered_map<std::string, ItemParseAttributes_t> ItemParseAttributes
+ 	{""elementenergy"", ITEM_PARSE_ELEMENTENERGY},
+ 	{""elementdeath"", ITEM_PARSE_ELEMENTDEATH},
+ 	{""elementholy"", ITEM_PARSE_ELEMENTHOLY},
++	{""cooldownreduction"", ITEM_PARSE_COOLDOWNREDUCTION},
++	{""increasedamage"", ITEM_PARSE_INCREASEDAMAGE},
++	{""increasehealing"", ITEM_PARSE_INCREASEHEALING},
++	{""increasemanaget"", ITEM_PARSE_INCREASEMANAGAIN},
+ 	{""walkstack"", ITEM_PARSE_WALKSTACK},
+ 	{""blocking"", ITEM_PARSE_BLOCKING},
+ 	{""allowdistread"", ITEM_PARSE_ALLOWDISTREAD},","variable names suggestions from me: - damageboost, ITEM_PARSE_DAMAGEBOOST, ""damage boost +x%"" - healingboost, ITEM_PARSE_HEALINGBOOST, ""healing power +y%"" - managainboost, ITEM_PARSE_MANAGAINBOOST, ""mana restoration +z%"" alternatively the other names can stay, because ""increase"" convention isn't that bad, just change mana values to: - ""increasemanarestored"", ITEM_PARSE_INCREASEMANARESTORED, ""mana restoration +z%""",I don't think this i
+3447,"@@ -24,6 +24,7 @@ CREATE_TABLE = """"""
+         `complete_time` datetime DEFAULT NULL,
+         `status` enum('SUCCESS','RUNNING','FAILURE',
+                       'PARTIAL_SUCCESS','TIMEOUT') DEFAULT NULL,
++        `has_all_data` bool DEFAULT NULL,
+         `schema_version` varchar(255) DEFAULT NULL,
+         `cycle_timestamp` varchar(255) DEFAULT NULL,
+          PRIMARY KEY (`id`),",Why can't this be determined by 'PARTIAL_SUCCESS' in the `status` field?,Why is this a boolea
+3448,"@@ -35,11 +35,15 @@ final class IdGenerator implements GeneratorInterface
+ 
+     public function generatePath(MediaInterface $media): string
+     {
+-        $mediaId = (int) $media->getId();
++        $id = $media->getId();
+ 
+-        $rep_first_level = (int) ($mediaId / $this->firstLevel);
+-        $rep_second_level = (int) (($mediaId - ($rep_first_level * $this->firstLevel)) / $this->secondLevel);
++        if (!is_numeric($id)) {
++            return '';
++        }
+ 
+-        return sprintf('%s/%04s/%02s', $media->getContext(), $rep_first_level + 1, $rep_second_level + 1);
++        $repFirstLevel = (int) ($id / $this->firstLevel);
++        $repSecondLevel = (int) (($id - ($repFirstLevel * $this->firstLevel)) / $this->secondLevel);
++
++        return sprintf('%s/%04s/%02s', $media->getContext() ?? '', $repFirstLevel + 1, $repSecondLevel + 1);
+     }
+ }","Does it make sense to generate a Exception here? Maybe yes, because it wouldn't make sense to generate a path without the id of the media right?",Why do we need this check?
+3449,"@@ -48,8 +48,16 @@ import javax.net.ssl.SSLSocketFactory;
+  */
+ public class SalesforceTLSSocketFactory extends SSLSocketFactory {
+ 
++    private static SalesforceTLSSocketFactory INSTANCE;
+     private SSLSocketFactory ssLSocketFactory;
+ 
++    public static SalesforceTLSSocketFactory getInstance() throws KeyManagementException, NoSuchAlgorithmException {
++        if (INSTANCE == null) {
++            INSTANCE = new SalesforceTLSSocketFactory();
++        }
++        return INSTANCE;
++    }
++
+     public SalesforceTLSSocketFactory() throws KeyManagementException, NoSuchAlgorithmException {
+         final SSLContext context = SSLContext.getInstance(""TLS"");
+         context.init(null, null, null);",This should be made private.,Why do we need this?
+3450,"@@ -267,6 +267,7 @@ func (a *Agent) bootstrap() error {
+ 			BaseSVID:       a.BaseSVID,
+ 			BaseSVIDKey:    a.baseSVIDKey,
+ 			BaseRegEntries: regEntries,
++			BaseSVIDPath:   a.getBaseSVIDPath(),
+ 			Logger:         a.config.Log,
+ 		}
+ ",perhaps this is better modeled as a pkg-level var?,Should this be `a.config.B
+3451,"@@ -86,6 +86,10 @@
+ #include ""CmpMain.h""
+ 
+ #define MAX_NODE_NAME 9
++#define MAX_PRECISION_ALLOWED  18
++#define HIVE_MAX_PRECISION_ALLOWED  38
++#define MAX_SCALE_ALLOWED     6
++#define MAX_NUM_LEN     16
+ 
+ #include ""SqlParserGlobals.h""
+ ","I don't think there is a maximum scale, neither for Hive nor for Trafodion. The only condition right now is that the scale can't exceed the precision. Example of a valid scale: DECIMAL(18,18). The maximum of 6 digits applies only to TIMESTAMP columns, where we don't support resolution below microseconds.",Why do we need these defin
+3452,"@@ -775,6 +775,14 @@ func (a *FakeWebAPI) GetProject(ctx context.Context, req *webservice.GetProjectR
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }
+ 
++func (a *FakeWebAPI) UpdateProjectStaticUser(ctx context.Context, req *webservice.UpdateProjectStaticUserRequest) (*webservice.UpdateProjectStaticUserResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
++func (a *FakeWebAPI) UpdateProjectSingleSignOn(ctx context.Context, req *webservice.UpdateProjectSingleSignOnRequest) (*webservice.UpdateProjectSingleSignOnResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
+ func (a *FakeWebAPI) GetMe(ctx context.Context, req *webservice.GetMeRequest) (*webservice.GetMeResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`ctx` is unused in UpdateProjectStaticUser,Why is this not implemented?
+3453,"@@ -35,4 +35,10 @@ public class JSTypeNameGenerator extends TypeNameGenerator {
+   public String getStringFormatExample(String format) {
+     return getStringFormatExample(format, ""Date.toISOString()"", ""Date.toISOString()"");
+   }
++
++  @Override
++  public String getDiscoveryDocUrl(String apiName, String apiVersion) {
++    return String.format(
++        ""https://content.googleapis.com/discovery/v1/apis/%s/%s/rest"", apiName, apiVersion);
++  }
+ }","Why is this not the default, and why only for JS?",Why do we need this method?
+3454,"@@ -0,0 +1,7 @@
++class ProjectBadge < ActiveRecord::Base
++  belongs_to :project
++  belongs_to :repository
++
++  validates :url, presence: true
++  validates :repository_id, presence: true, uniqueness: { scope: :project_id }
++end",A repository has many badges so we should also add type column in scope.,Line is too long. [81/80]
+3455,"@@ -82,7 +82,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+             });
+ 
+             Assert.AreEqual(1, result.CodeFlows.Count);
+-            result.CodeFlows[0].Should().Equal(new[]
++            result.CodeFlows.First().Locations.ToArray().Should().Equal(new[]
+                     {
+                         new AnnotatedCodeLocation {
+                             PhysicalLocation = new PhysicalLocation {","Now a hash set, so can't index into it.",Why did this change?
+3456,"@@ -273,6 +273,11 @@ module Bolt
+         !!File::ALT_SEPARATOR
+       end
+ 
++      # Returns true if running in PowerShell.
++      def powershell?
++        !!ENV['PSModulePath']
++      end
++
+       # Accept hash and return hash with top level keys of type ""String"" converted to symbols.
+       def symbolize_top_level_keys(hsh)
+         hsh.each_with_object({}) { |(k, v), h| k.is_a?(String) ? h[k.to_sym] = v : h[k] = v }",@jpogran Does this seem like a reasonable way to know if we're in powershell vs. CMD or *sh?,Should this be `!!ENV['PSModulePath']`?
+3457,"@@ -63,7 +63,7 @@ public class BodyProcessorCreator implements ParamValueProcessorCreator {
+       }
+ 
+       String contentType = request.getContentType();
+-      if (contentType != null && !contentType.startsWith(MediaType.APPLICATION_JSON)) {
++      if (contentType != null && !contentType.toLowerCase().startsWith(MediaType.APPLICATION_JSON)) {
+         // TODO: we should consider body encoding
+         return IOUtils.toString(inputStream, ""UTF-8"");
+       }",1.toLowerCase(Locale.US)? 2.where is accept bug fix?,Shouldn't this be `contentType.toLowerC
+3458,"@@ -105,16 +105,9 @@ def test_execute_with_invalid_driver(
+ ):
+     _command_args['driver_name'] = 'ec3'
+ 
+-    with pytest.raises(SystemExit) as e:
++    with pytest.raises(KeyError):
+         _instance.execute()
+ 
+-    assert 1 == e.value.code
+-
+-    msg = (
+-        'The specified template directory ({template_dir})' ' does not exist'
+-    ).format(template_dir=_instance._resolve_template_dir('scenario/driver/ec3'))
+-    patched_logger_critical.assert_called_once_with(msg)
+-
+ 
+ def test_execute_with_custom_template(
+     temp_dir, custom_template_dir, custom_readme_content, _command_args",We should still be providing something to the user in the case of a `KeyError` instead of a stack trace!?,Why was this test removed?
+3459,"@@ -90,6 +90,7 @@ namespace Nethermind.DataMarketplace.Core.Services
+         {
+             var txData = _abiEncoder.Encode(AbiEncodingStyle.IncludeSignature, ContractData.DepositAbiSig,
+                 deposit.Id.Bytes, deposit.Units, deposit.ExpiryTime);
++            var nonce = await _blockchainBridge.GetNonceAsync(onBehalfOf);
+             Transaction transaction = new Transaction
+             {
+                 Value = deposit.Value,",check Lukasz's fix with NonceReserving - is that not better?,Why do we need this?
+3460,"@@ -106,11 +106,8 @@ Blockly.FieldColour.prototype.setValue = function(colour) {
+   }
+   this.colour_ = colour;
+   if (this.sourceBlock_) {
+-    this.sourceBlock_.setColour(
+-      colour,
+-      this.sourceBlock_.getColourSecondary(),
+-      this.sourceBlock_.getColourTertiary()
+-    );
++    // Set the primary, secondary and tertiary colour to this value.
++    this.sourceBlock_.setColour(colour, colour, colour);
+   }
+ };
+ ",Would you explain why here please? E.g. from the PR description > the renderer expects to be able to use the secondary color as the fill for a shadow.,nit: `// Set the primary and secondary colour to this value.`
+3461,"@@ -643,6 +643,8 @@ func (hd *HeaderDownload) SaveExternalAnnounce(hash common.Hash) {
+ }
+ 
+ func (hd *HeaderDownload) getLink(linkHash common.Hash) (*Link, bool) {
++	hd.lock.RLock()
++	defer hd.lock.RUnlock()
+ 	if link, ok := hd.links[linkHash]; ok {
+ 		return link, true
+ 	}","Lock needs to go to `RecoverFromDb` instead. Here it may cause deadlocks. My convention was that un-exported functions do not lock, only exported ones (with name starting with a capital letter)",Why do we need a lock here?
+3462,"@@ -63,4 +63,9 @@ public class GermanKeyboard extends BaseKeyboard {
+     public String getSpaceKeyText(String aComposingText) {
+         return StringUtils.getStringByLocale(mContext, R.string.settings_language_german, getLocale());
+     }
++
++    @Override
++    public String[] getDomains(String... domains) {
++        return super.getDomains("".de"");
++    }
+ }","German keyboard would also be used in Austria and Switzerland, so this should have included `.at` and `.ch`.",I think this should be `getDomains(String... domains)`.
+3463,"@@ -38,8 +38,6 @@ final class CompositeIndexer {
+         CacheBuilder.from(spec).<PartitionKeyToTraceId, Pair<Long>>build().asMap();
+     Indexer.Factory factory = new Indexer.Factory(session, indexTtl, sharedState);
+     this.indexers = ImmutableSet.of(
+-        factory.create(new InsertTraceIdByServiceName(bucketCount)),
+-        factory.create(new InsertTraceIdBySpanName()),
+         factory.create(new InsertTraceIdByAnnotation(bucketCount))
+     );
+   }","since this makes the indexer thing really only used for a single table, now, you can put in a TODO for me to cleanup and simplify this",Why is this being removed?
+3464,"@@ -83,6 +83,10 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl {
+       ""/export/apps/azkaban/azkaban-exec-server/current/plugins/jobtypes"";
+   public static final String IMAGE = ""image"";
+   public static final String VERSION = ""version"";
++  public static final String NSCD_SOCKET_VOLUME_NAME = ""nscd-socket"";
++  public static final String NSCD_SOCKET_HOST_PATH = ""/var/run/nscd/socket"";
++  public static final String HOST_PATH_TYPE = ""Socket"";
++  public static final String NSCD_SOCKET_VOLUME_MOUNT_PATH = ""/var/run/nscd/socket"";
+ 
+   private final String namespace;
+   private final ApiClient client;","Should we have this path passed from the Azkaban properties? If this is the standard path for nscd even outside LinkedIn, then we can keep it.",Why do we need this?
+3465,"@@ -533,7 +533,12 @@ func (a *Account) EnableJetStream(limits *JetStreamAccountLimits) error {
+ 				s.Warnf(""  Error adding Stream %q to Template %q: %v"", cfg.Name, cfg.Template, err)
+ 			}
+ 		}
+-		mset, err := a.AddStream(&cfg.StreamConfig)
++		// TODO: We should not rely on the stream name.
++		// However, having a StreamConfig property, such as AllowNoSubject,
++		// was not accepted because it does not make sense outside of the
++		// MQTT use-case. So need to revisit this.
++		mqtt := cfg.StreamConfig.Name == mqttStreamName
++		mset, err := a.addStreamWithStore(&cfg.StreamConfig, nil, mqtt)
+ 		if err != nil {
+ 			s.Warnf(""  Error recreating Stream %q: %v"", cfg.Name, err)
+ 			continue",Could be a non-public field. `allowNoSubject`,Why do we need to re
+3466,"@@ -588,12 +588,12 @@ func (c *Client) execute(tid int, target *core.BuildTarget, command *pb.Command,
+ 	} else if target.IsTextFile {
+ 		return c.buildTextFile(target, command, digest)
+ 	}
+-	return c.reallyExecute(tid, target, command, digest, needStdout, isTest)
++	return c.reallyExecute(tid, target, command, digest, needStdout, isTest, (c.state.ForceRerun && isTest) || (!isTest && c.state.ForceRebuild))
+ }
+ 
+ // reallyExecute is like execute but after the initial cache check etc.
+ // The action & sources must have already been uploaded.
+-func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Command, digest *pb.Digest, needStdout, isTest bool) (*core.BuildMetadata, *pb.ActionResult, error) {
++func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Command, digest *pb.Digest, needStdout, isTest, skipCacheLookup bool) (*core.BuildMetadata, *pb.ActionResult, error) {
+ 	executing := false
+ 	updateProgress := func(metadata *pb.ExecuteOperationMetadata) {
+ 		if c.state.Config.Remote.DisplayURL != """" {",Don't think this is quite right - think the build one also needs an `IsOriginalTarget` (c.f. code in `src/build`),I don't think we nee
+3467,"@@ -62,6 +62,12 @@ class Autocomplete
+         return array('results' => $this->processResults($paginator->getCurrentPageResults(), $backendConfig['entities'][$entity]));
+     }
+ 
++    /**
++     * @param array $entities
++     * @param array $targetEntityConfig
++     *
++     * @return array
++     */
+     private function processResults($entities, $targetEntityConfig)
+     {
+         $results = array();",what about adding typehints instead? I don't think we need to add docblocks for every private methods.,missing return type
+3468,"@@ -76,6 +76,7 @@ func createVolumeBuilder(cStorVolumeReplica *apis.CStorVolumeReplica, fullVolNam
+ 	openebsTargetIP := ""io.openebs:targetip="" + cStorVolumeReplica.Spec.TargetIP
+ 
+ 	createVolAttr = append(createVolAttr, ""create"",
++		""-b"", ""4K"", ""-s"", ""-o"", ""compression=on"",
+ 		""-V"", cStorVolumeReplica.Spec.Capacity, fullVolName,
+ 		""-o"", openebsTargetIP, ""-o"", openebsVolname)
+ ","Is it fine to pass the ""-o compression=on"" in the middle instead of at the end ?",Why is this needed?
+3469,"@@ -18,14 +18,18 @@ module Bolt
+     attr_reader :noop, :transports
+     attr_accessor :run_as
+ 
++    # FIXME: There must be a better way
++    # https://makandracards.com/makandra/36011-ruby-do-not-mix-optional-and-keyword-arguments
+     def initialize(concurrency = 1,
+                    analytics = Bolt::Analytics::NoopClient.new,
+                    noop = nil,
+-                   bundled_content: nil)
++                   bundled_content: nil,
++                   load_config: true)
+       @analytics = analytics
+       @bundled_content = bundled_content
+       @logger = Logging.logger[self]
+       @plan_logging = false
++      @load_config = load_config
+ 
+       @transports = Bolt::TRANSPORTS.each_with_object({}) do |(key, val), coll|
+         coll[key.to_s] = Concurrent::Delay.new do",Probably make them all keyword arguments.,Why do we need this
+3470,"@@ -521,11 +521,7 @@ define([""loading"", ""appRouter"", ""layoutManager"", ""connectionManager"", ""cardBuild
+         renderDetails(page, item, apiClient, context);
+         renderTrackSelections(page, instance, item);
+ 
+-        if (dom.getWindowSize().innerWidth >= 1000) {
+-            backdrop.setBackdrops([item]);
+-        } else {
+-            backdrop.clear();
+-        }
++        backdrop.clear();
+ 
+         renderDetailPageBackdrop(page, item, apiClient);
+         var canPlay = reloadPlayButtons(page, item);",Why not just check the backdrop setting here as well for the time being? We can combine the code later but at least then it would be configurable if people like the backgrounds.,Why was this remove
+3471,"@@ -41,7 +41,7 @@ namespace AutoRest.Swagger.Validation
+         /// <summary>
+         /// The severity of this message (ie, debug/info/warning/error/fatal, etc)
+         /// </summary>
+-        public override Category Severity => Category.Error;
++        public override Category Severity => Category.Warning;
+ 
+         ///// <summary>
+         ///// Validates whether property names are camelCase in body parameters.",why are we turning this one into a Warning?,Why are we changing
+3472,"@@ -631,7 +631,7 @@ public class GUI implements CPDListener {
+             int separatorPos = sourceId.lastIndexOf(File.separatorChar);
+             label = ""..."" + sourceId.substring(separatorPos);
+         } else {
+-            label = '(' + sourceIDs.size() + "" separate files)"";
++            label = '(' + String.valueOf(sourceIDs.size()) + "" separate files)"";
+         }
+ 
+         match.setLabel(label);",Wouldn't it be better to use double quotes for the opening parenthesis ?,"`String.valueOf(sourceIDs.size()) + "" separate files""`"
+3473,"@@ -716,7 +716,7 @@ bool IOLoginData::savePlayer(Player* player)
+ 	if (!player->isOffline()) {
+ 		query << ""`onlinetime` = `onlinetime` + "" << (time(nullptr) - player->lastLoginSaved) << ',';
+ 	}
+-	query << ""`blessings` = "" << static_cast<uint32_t>(player->blessings);
++	query << ""`blessings` = "" << static_cast<uint32_t>(player->blessings.to_ulong());
+ 	query << "" WHERE `id` = "" << player->getGUID();
+ 
+ 	DBTransaction transaction;",Remove the cast,`blessings` should be a `std::size_t`
+3474,"@@ -1,4 +1,4 @@
+-// Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
++// Copyright (c) 2016-2018 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");
+ // you may not use this file except in compliance with the License.",What criteria do we use to bump the copyright years? An update to the module?,Why did you change this?
+3475,"@@ -267,6 +267,7 @@ class Resize:
+                     interpolation='nearest',
+                     backend=self.backend)
+             results['gt_semantic_seg'] = gt_seg
++            results[key] = gt_seg
+ 
+     def __call__(self, results):
+         """"""Call function to resize images, bounding boxes, masks, semantic",should we rm line 269?,Why do we need this change?
+3476,"@@ -68,7 +68,9 @@ class NVDASpyLib:
+ 
+ 	# callbacks for extension points
+ 	def _onNvdaStartupComplete(self):
+-		self._isNvdaStartupComplete = True
++		# Queue the setting of the completion variable,
++		# To ensure that NvDA's core loop has started running, and it has processed initial focus.
++		queueHandler.queueFunction(queueHandler.eventQueue, lambda: setattr(self, '_isNvdaStartupComplete', True))
+ 
+ 	def _onNvdaSpeech(self, speechSequence=None):
+ 		if not speechSequence:","Perhaps the code at `source/core.py:564: postNvdaStartup.notify()` should be queued instead? If we are saying the loop must have started before NVDA's startup is complete, then the `postNvdaStartup` action is incorrect.",I'm not sure if this is the right place to do this. I think it should be done in the `_onNvdaSpeech` method.
+3477,"@@ -25,6 +25,13 @@ FactoryGirl.define do
+         cart.save!
+       end
+ 
++      factory :cart_with_all_approvals_approved do
++        after :create do |cart|
++          cart.approvals.each {|a| a.update_attribute :status, 'approved'}
++          cart.update_attribute :status, 'approved'
++        end
++      end
++
+       factory :cart_with_approvals_and_items do
+         after :create do |cart|
+           cart.cart_items << FactoryGirl.create(:cart_item, cart_id: cart.id)",Needed this for testing locally with mail view but not used for any tests. Might be nice to have some seed scripts at some point.,Space missing inside {.<br>Space missing inside }.
+3478,"@@ -291,9 +291,13 @@ func (o *Outbound) callWithPeer(
+ 	if response.StatusCode >= 200 && response.StatusCode < 300 {
+ 		appHeaders := applicationHeaders.FromHTTPHeaders(
+ 			response.Header, transport.NewHeaders())
+-		appError := response.Header.Get(ApplicationStatusHeader) == ApplicationErrorStatus
++		appError := fromApplicationStatusValue(response.Header.Get(ApplicationStatusHeader))
++		acceptResponseError := fromAcceptValue(response.Header.Get(AcceptResponseErrorHeader))
+ 		return &transport.Response{
+-			Headers:          appHeaders,
++			Headers: appHeaders,
++			Features: transport.ResponseFeatures{
++				AcceptResponseError: acceptResponseError,
++			},
+ 			Body:             response.Body,
+ 			ApplicationError: appError,
+ 		}, nil","wait, if we only do this for successful status codes won't we miss a whole slew of responses? We should be checking this for all codes right?",Shouldn't this be `ApplicationError`?
+3479,"@@ -66,7 +66,9 @@ public class ProtoParserTest {
+     testDataLocator = TestDataLocator.create(GapicCodeGeneratorAnnotationsTest.class);
+     testDataLocator.addTestDataSource(CodegenTestUtil.class, ""testsrc/common"");
+ 
+-    model = CodegenTestUtil.readModel(testDataLocator, tempDir, protoFiles, new String[0]);
++    model =
++        CodegenTestUtil.readModel(
++            testDataLocator, tempDir, protoFiles, new String[] {""library.yaml""});
+ 
+     libraryProtoFile =
+         model",Adding in the service yaml `library.yaml` here.,Why is this change needed?
+3480,"@@ -63,7 +63,7 @@ func (a BasicAuth) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error
+ 
+ 			// let upstream middleware (e.g. fastcgi and cgi) know about authenticated
+ 			// user; this replaces the request with a wrapped instance
+-			r = r.WithContext(context.WithValue(r.Context(),
++			*r = *r.WithContext(context.WithValue(r.Context(),
+ 				httpserver.RemoteUserCtxKey, username))
+ 		}
+ 	}",Why is this dereference needed?,Why do we need this change?
+3481,"@@ -36,7 +36,8 @@ import (
+ // * `tlfNode` allows auto-creation of subdirectories representing
+ //   valid repository checkouts of the corresponding TLF, e.g.
+ //   `.kbfs_autogit/private/chris/dotfiles`.  It wraps child nodes in
+-//   two ways, as both a `readonlyNode` and a `repoNode`.
++//   two ways, as both a `readonlyNode` and a `repoNode`.  It allows
++//   repo directories to be removed via `RemoveDir`.
+ // * `repoNode` allow auto-clone and auto-pull of the corresponding
+ //   repository on its first access.  When the directory corresponding
+ //   to the node is read for the first time for this KBFS instance,",Might want to add that this only happens if you have write permissions to the folder.,I don't think this is corre
+3482,"@@ -53,6 +53,12 @@ type Config struct {
+ 	// to use based on region.
+ 	EndpointResolver endpoints.Resolver
+ 
++	// EnforceShouldRetryCheck is used in the AfterRetryHandler to always call
++	// ShouldRetry. If this is set and ShouldRetry is called, then the request's
++	// Retryable field can be either nil or set. Proper handling of the Retryable
++	// field is important when setting this field.
++	EnforceShouldRetryCheck *bool
++
+ 	// The region to send requests to. This parameter is required and must
+ 	// be configured globally or on a per-client basis unless otherwise
+ 	// noted. A full list of regions is found in the ""Regions and Endpoints""",Adding a small blurb about why someone would want to enable this flag would help clarify what it is for. Such as something about when providing a custom retry handler and how`ShouldRetry` will be handled with and without the flag enabled.,Why is this a pointer?
+3483,"@@ -59,6 +59,6 @@ func Register(registry transport.Registry, service Service) {
+ 	proto := service.Protocol()
+ 	for method, h := range service.Handlers() {
+ 		handler := thriftHandler{Handler: h, Protocol: proto}
+-		registry.Register(procedureName(name, method), handler)
++		registry.Register("""", procedureName(name, method), handler)
+ 	}
+ }",assume the user will be able to register for a custom service name in future?,Why is this change needed?
+3484,"@@ -27,7 +27,9 @@ using System.Threading.Tasks;
+ using JetBrains.Annotations;
+ using pwiz.Common.Collections;
+ using pwiz.Common.SystemUtil;
+-using pwiz.Skyline.Util;
++using pwiz.Skyline.Util;
++
++
+ // ReSharper disable InconsistentlySynchronizedField
+ 
+ namespace pwiz.Skyline.Controls.Graphs",The extra two empty lines seem unnecessary. Please review your diffs more carefully.,Why is this needed?
+3485,"@@ -28,7 +28,7 @@ type API interface {
+ 	LiveToken() TokenAPI
+ 	SideToken() TokenAPI
+ 	TestToken() TestTokenAPI
+-	OracleUSD() OracleAPI
++	OracleAPI
+ }
+ 
+ type ProfileRegistryAPI interface {",What the reason to embed the Oracle?,I think this should
+3486,"@@ -53,6 +53,8 @@ Workshops::Application.routes.draw do
+     resources :purchases, only: :index
+   end
+ 
++  match 'pages/new-topics' => 'pages#show', id: 'new-topics'
++
+   match '/auth/:provider/callback', to: 'auth_callbacks#create'
+ 
+   match '/watch' => 'high_voltage/pages#show', as: :watch, id: 'watch'",Shouldn't this happen automatically with High Voltage?,I'm not sure if thi
+3487,"@@ -505,7 +505,7 @@ public class InitCodeTransformer {
+         InitValue initValue = initValueConfig.getResourceNameBindingValues().get(entityName);
+         switch (initValue.getType()) {
+           case Variable:
+-            entityValue = context.getNamer().localVarName(Name.from(initValue.getValue()));
++            entityValue = context.getNamer().varReference(Name.from(initValue.getValue()));
+             break;
+           case Random:
+             entityValue = context.getNamer().injectRandomStringGeneratorCode(initValue.getValue());",This is changed because we need `projectId` to be printed as `$projectId` in PHP.,Why this change?
+3488,"@@ -1,7 +1,7 @@
+ <div class=""row"">
+   <div class=""col-md-12"">
+     <h1>
+-      <%= _('Template History') %>
++      <%= templates.first.customization_of.present? ? _('Template Customisation History') : _('Template History') %>
+       <div class=""pull-right"">
+         <%= link_to _('View all templates'), referrer, class: ""btn btn-primary"" %>
+       </div>",This title change seems more accurate to me however not sure if this will confuse users.,I think this should be `templates.first.customization_of || _('Template History')`
+3489,"@@ -117,7 +117,8 @@ private
+     # Some k/v's are wikipedia=http://en.wikipedia.org/wiki/Full%20URL
+     return nil if value =~ /^https?:\/\//
+ 
+-    if key == ""wikipedia""
++    # match wikipedia or xxxxx:wikipedia
++    if key =~ /^(?:.*:)*wikipedia$/
+       # This regex should match Wikipedia language codes, everything
+       # from de to zh-classical
+       if value =~ /^([a-z-]{2,12}):(.+)$/i","Here (and on line 158 as well), would it be more efficient to use the String end_with() method? Not tested",I'm not sure if this is the best way to do this. I'm not sure what the best way to
+3490,"@@ -505,7 +505,13 @@ class RAMHandler(logging.Handler):
+             if record.levelno >= minlevel:
+                 lines.append(fmt(record))
+         return '\n'.join(lines)
+-
++        
++    def change_log_capacity(self, capacity):
++        """"""
++        change log capacity according to user specifcation
++        """""" 
++        ram_handler = RAMHandler(capacity=capacity)           
++        self._data = collections.deque(self._data, maxlen=capacity)
+ 
+ class ColoredFormatter(logging.Formatter):
+ ",Why are you creating a new (second) `RAMHandler` here? Is this just an oversight from deleting the previous code?,`ram_handler` is not used.
+3491,"@@ -25,7 +25,11 @@ void CreateEdgeIndexProcessor::process(const cpp2::CreateEdgeIndexReq& req) {
+     auto ret = getEdgeIndexID(space, indexName);
+     if (ret.ok()) {
+         LOG(ERROR) << ""Create Edge Index Failed: "" << indexName << "" have existed"";
+-        resp_.set_code(cpp2::ErrorCode::E_EXISTED);
++        if (req.get_if_not_exists()) {
++            resp_.set_code(cpp2::ErrorCode::SUCCEEDED);
++        } else {
++            resp_.set_code(cpp2::ErrorCode::E_EXISTED);
++        }
+         onFinished();
+         return;
+     }",Move the line 27 to line 31 is better?,nit: `if (!req.get_if_not_exists())`
+3492,"@@ -4704,6 +4704,11 @@ func (fbo *folderBranchOps) applyMDUpdatesLocked(ctx context.Context,
+ 				return err
+ 			}
+ 		}
++		if rmd.IsRekeySet() {
++			fbo.rekeyFSM.Event(NewRekeyRequestEvent())
++		} else {
++			fbo.rekeyFSM.Event(NewRekeyNotNeededEvent())
++		}
+ 		appliedRevs = append(appliedRevs, rmd)
+ 	}
+ 	if len(appliedRevs) > 0 {","In slack I mentioned we should only do this if the update is from some other device, to make sure our own updates don't cause issues. Maybe the revision check above is good enough to prevent this, but I just want to make sure you thought about it.",Why do we need this event?
+3493,"@@ -66,12 +66,6 @@ RSpec.configure do |config|
+   # particularly slow.
+   config.profile_examples = 10
+ 
+-  # Run specs in random order to surface order dependencies. If you find an
+-  # order dependency and want to debug it, you can fix the order by providing
+-  # the seed, which is printed after each run.
+-  #     --seed 1234
+-  config.order = :random
+-
+   # Seed global randomization in this process using the `--seed` CLI option.
+   # Setting this allows you to use `--seed` to deterministically reproduce
+   # test failures related to randomization by passing the same `--seed` value","I would instead explain that random is the default, but you can switch back to defined, or another ordering scheme.",Why is this being removed?
+3494,"@@ -156,11 +156,15 @@ function isVisible(el, screenReader, recursed) {
+   }
+ 
+   // hidden from visual users
++  const elHeight = parseInt(style.getPropertyValue('height'));
+   if (
+     !screenReader &&
+     (isClipped(style) ||
+       style.getPropertyValue('opacity') === '0' ||
+-      (getScroll(el) && parseInt(style.getPropertyValue('height')) === 0))
++      (getScroll(el) && elHeight === 0) ||
++      (style.getPropertyValue('position') === 'absolute' &&
++        elHeight <= 1 &&
++        style.getPropertyValue('overflow') === 'hidden'))
+   ) {
+     return false;
+   }",Is there a reason you left this at 0?,I think this should be `st
+3495,"@@ -267,6 +267,11 @@ public final class RememberMeConfigurer<H extends HttpSecurityBuilder<H>>
+ 		validateInput();
+ 		String key = getKey();
+ 		RememberMeServices rememberMeServices = getRememberMeServices(http, key);
++		if (key == null) {
++			if (rememberMeServices instanceof AbstractRememberMeServices) {
++				key = ((AbstractRememberMeServices) rememberMeServices).getKey();
++			}
++		}
+ 		http.setSharedObject(RememberMeServices.class, rememberMeServices);
+ 		LogoutConfigurer<H> logoutConfigurer = http.getConfigurer(LogoutConfigurer.class);
+ 		if (logoutConfigurer != null && this.logoutHandler != null) {","The value of `key` will never be `null` at this point, because `getKey()` will generate a value if it is `null`.",Why is this needed?
+3496,"@@ -88,11 +88,18 @@ namespace Datadog.Trace.ClrProfiler
+                 return null;
+             }
+ 
++            var commandType = command.GetType();
++            if (tracer.Settings.AdoNetExcludedTypes.Contains(commandType.FullName))
++            {
++                // AdoNet type disabled, don't create a scope, skip this trace
++                return null;
++            }
++
+             Scope scope = null;
+ 
+             try
+             {
+-                string dbType = GetDbType(command.GetType().Name);
++                string dbType = GetDbType(commandType.Name);
+ 
+                 if (dbType == null)
+                 {",NIT: You should first check if AdoNetExcludedTypes.Count is greater than 0 before calling Contains (fast-path),Why do we need this check?
+3497,"@@ -18,6 +18,9 @@ package v1alpha1
+ 
+ import (
+ 	ndm ""github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1""
++
++	""strings""
++
+ 	errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/resource""",should rearrange so as to follow import ordering.,nit: remove empty line
+3498,"@@ -65,7 +65,7 @@ func (s *validateOperationWorkflowModeStateSuite) TestCreateMode_UpdateCurrent()
+ 	stateToError := map[enumsspb.WorkflowExecutionState]bool{
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_CREATED:   false,
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_RUNNING:   false,
+-		enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: true,
++		enumsspb.WORKFLOW_EXECUTION_STATE_COMPLETED: false,
+ 		enumsspb.WORKFLOW_EXECUTION_STATE_ZOMBIE:    true,
+ 	}
+ ",what is the use case for create workflow with completed state?,Why is this change needed?
+3499,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.distributor.remote;
++
++public class RemoteDistributorTest {
++
++}",Probably best not to have an empty test....,Missing license header.
+3500,"@@ -0,0 +1,15 @@
++#include <impl/Kokkos_Tools.hpp>
++
++int main(int argc, char* argv[]) {
++  Kokkos::Tools::initialize(argc, argv);
++  Kokkos::Tools::pushRegion(
++      ""The unanimous Declaration of the thirteen united States of America, ""
++      ""When in the Course of human events, it becomes necessary for one people ""
++      ""to dissolve the political bands which have connected them with another, ""
++      ""and to assume among the powers of the earth, the separate and equal ""
++      ""station to which the Laws of Nature and of Nature's God entitle them, a ""
++      ""decent respect to the opinions of mankind requires that they should ""
++      ""declare the causes which impel them to the separation."");
++  Kokkos::Tools::popRegion();
++  Kokkos::Tools::finalize();
++}",Missing the license,"I don't think this is the right way to do it. I think it would be better to say ""The unanimous Declaration"""
+3501,"@@ -210,11 +210,9 @@ func (p *ReplicationTaskProcessorImpl) eventLoop() {
+ 			))
+ 
+ 		case <-cleanupTimer.C:
+-			if p.config.EnableCleanupReplicationTask() {
+-				if err := p.cleanupReplicationTasks(); err != nil {
+-					p.logger.Error(""Failed to clean up replication messages."", tag.Error(err))
+-					p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupFailure)
+-				}
++			if err := p.cleanupReplicationTasks(); err != nil {
++				p.logger.Error(""Failed to clean up replication messages."", tag.Error(err))
++				p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupFailure)
+ 			}
+ 			cleanupTimer.Reset(backoff.JitDuration(
+ 				p.config.ReplicationTaskProcessorCleanupInterval(shardID),",Looks like this was previously guarded by `EnableCleanupReplicationTask` flag. Now looks like this is always needed. Just want to confirm the intention is if `GlobalNamespace` is enabled then we want run cleanupReplicationTasks in all cases?,why remove this?
+3502,"@@ -37,7 +37,6 @@
+         #include ""tbb/tbb.h""
+         #include <tbb/task_arena.h>
+         #include <tbb/task_scheduler_observer.h>
+-        #include <tbb/task_scheduler_init.h>
+         #include <tbb/parallel_reduce.h>
+         #include <tbb/blocked_range.h>
+         #include <tbb/tick_count.h>","Potentially it'll be good to remove all of them excluding ""tbb/tbb.h"" But let's do it next time  ",Why is this header removed?
+3503,"@@ -1210,3 +1210,19 @@ def is_nan(x):
+         return np.isnan(x)
+     except:
+         return False
++
++
++def bound_range(vals, density):
++    """"""
++    Computes a bounding range from a number of evenly spaced samples.
++    Will raise an error if samples are not evenly spaced within
++    tolerance.
++    """"""
++    low, high = vals.min(), vals.max()
++    invert = False
++    if vals[0] > vals[1]:
++        invert = True
++    if not density:
++        density = round(1./((high-low)/(len(vals)-1)), sys.float_info.dig)
++    halfd = 0.5/density
++    return low-halfd, high+halfd, density, invert",I would just mention which tolerance - namely as reported by ``sys.float_info``,I don't think you need the `invert` variable.
+3504,"@@ -18,8 +18,9 @@ class ProposalsController < ApplicationController
+ 
+   def index
+     @CLOSED_PROPOSAL_LIMIT = 10
++
+     @pending_data = self.listing.pending
+-    @approved_data = self.listing.approved(@CLOSED_PROPOSAL_LIMIT)
++    @approved_data = self.listing.approved.alter_query{ |rel| rel.limit(@CLOSED_PROPOSAL_LIMIT) }
+     @cancelled_data = self.listing.cancelled
+   end
+ ",:+1: Ideally this'll become something you could pass in to the config,Why do we need this change?
+3505,"@@ -775,7 +775,7 @@ void RaftPart::replicateLogs(folly::EventBase* eb,
+             return resp.get_error_code() == cpp2::ErrorCode::SUCCEEDED
+                     && !hosts[index]->isLearner();
+         })
+-        .then(executor_.get(), [self = shared_from_this(),
++        .via(executor_.get()).then([self = shared_from_this(),
+                    eb,
+                    it = std::move(iter),
+                    currTerm,",Should using `thenValue` to replace `then` ?,Why is this needed?
+3506,"@@ -130,6 +130,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+ 
+         private void OnError(object sender, EventArgs eventArgs)
+         {
++            if (!Tracer.Instance.Settings.IsIntegrationEnabled(IntegrationName))
++            {
++                // integration disabled
++                return;
++            }
++
+             try
+             {
+                 if (!TryGetContext(sender, out var httpContext) || httpContext.Error == null ||",This follows the convention of each callback starting with the `IsIntegrationEnabled` check.,Why do we need this?
+3507,"@@ -26,11 +26,15 @@ namespace OpenTelemetry.Metrics
+         private long sumLong = 0;
+         private SumMetricLong sumMetricLong;
+         private DateTimeOffset startTimeExclusive;
++        private bool isDeltaValue;
++        private bool isMonotonicValue;
+ 
+-        internal SumMetricAggregatorLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair<string, object>[] attributes)
++        internal SumMetricAggregatorLong(string name, string description, string unit, Meter meter, DateTimeOffset startTimeExclusive, KeyValuePair<string, object>[] attributes, bool isDeltaValue, bool isMonotonicValue)
+         {
+             this.startTimeExclusive = startTimeExclusive;
+             this.sumMetricLong = new SumMetricLong(name, description, unit, meter, startTimeExclusive, attributes);
++            this.isDeltaValue = isDeltaValue;
++            this.isMonotonicValue = isMonotonicValue;
+         }
+ 
+         public void Update<T>(T value)","this is not required to be part of this PR right? (With UpDownCounter being absent in .NET, we can make this hardcoded for now, i think)",nit: `isMonotonicValue` -> 
+3508,"@@ -0,0 +1,12 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Transport
++{
++    public interface IConnectionHandler
++    {
++        IConnectionContext OnConnection(IConnectionInformation connectionInfo, IScheduler inputWriterScheduler, IScheduler outputReaderScheduler);
++    }
++}",Add the PipeFactory here,Why do we need this interface?
+3509,"@@ -23,15 +23,12 @@ import (
+ 	""github.com/pkg/errors""
+ 
+ 	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+-	""github.com/chaos-mesh/chaos-mesh/controllers/common""
+ )
+ 
+ type Delegate struct {
+ 	impl interface{}
+ }
+ 
+-var _ common.ChaosImpl = (*Delegate)(nil)
+-
+ func (i *Delegate) callAccordingToAction(action, methodName string, defaultPhase v1alpha1.Phase, args ...interface{}) (v1alpha1.Phase, error) {
+ 	implType := reflect.TypeOf(i.impl).Elem()
+ 	implVal := reflect.ValueOf(i.impl)",please add `var _ impltypes.ChaosImpl = (*Delegate)(nil)`,Why was this removed?
+3510,"@@ -97,4 +97,15 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> {
+    * @return this for method chaining
+    */
+   ExpireSnapshots executeWith(ExecutorService executorService);
++
++  /**
++   * Allows expiration of snapshots without any cleanup of underlying manifest or data files.
++   * <p>
++   * Allows control in removing data and manifest files which may be more efficiently removed using
++   * a distributed framework through the actions API.
++   *
++   * @param clean setting this to false will skip deleting expired manifests and files
++   * @return this for method chaining
++   */
++  ExpireSnapshots cleanExpiredFiles(boolean clean);
+ }",nit: is this added deliberately?,nit: `clean` -> `skipCleaning`
+3511,"@@ -8,6 +8,8 @@ class SiteControllerTest < ActionController::TestCase
+   def setup
+     Object.const_set(""ID_KEY"", client_applications(:oauth_web_app).key)
+     Object.const_set(""POTLATCH2_KEY"", client_applications(:oauth_web_app).key)
++
++    stub_request(:get, ""http://api.hostip.info/country.php?ip=0.0.0.0"")
+   end
+ 
+   ##",Given the number of tests which need this (I think I counted seven) should we maybe just install this one globally? Is there even a place to do that? Something in `test_helper` maybe?,This should be `stub_request(:
+3512,"@@ -495,6 +495,16 @@ function applyWriteConcern(target, sources, options) {
+   return target;
+ }
+ 
++/**
++ * Checks if a given value is a Promise
++ *
++ * @param {*} maybePromise
++ * @return true if the provided value is a Promise
++ */
++function isPromiseLike(maybePromise) {
++  return maybePromise && typeof maybePromise.then === 'function';
++}
++
+ exports.filterOptions = filterOptions;
+ exports.mergeOptions = mergeOptions;
+ exports.translateOptions = translateOptions;","we don't use this anymore, so we can delete it.",I don't think we need to check for `typeof maybePromise.then === 'function'`.
+3513,"@@ -283,6 +283,8 @@ func initTelemetry(genesis bookkeeping.Genesis, log logging.Logger, dataDirector
+ 			fmt.Fprintln(os.Stdout, ""error loading telemetry config"", err)
+ 			return
+ 		}
++		fmt.Fprintln(os.Stdout, ""algoh telemetry configured from file:"", telemetryConfig.FilePath)
++
+ 
+ 		// Apply telemetry override.
+ 		telemetryConfig.Enable = logging.TelemetryOverride(*telemetryOverride)","nit: change to ""Telemetry configuration loaded from '%s'""",nit: `algoh telemetry` -> `algoh telemetry`
+3514,"@@ -182,7 +182,8 @@ func TestSerialiseBlockWitness(t *testing.T) {
+ 	if err := bwb.WriteTo(&b); err != nil {
+ 		t.Errorf(""Could not make block witness: %v"", err)
+ 	}
+-	expected := common.FromHex(""0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c75657300582023181a62d35fe01562158be610f84e047f99f5e74d896da21682d925964ece3a0601024704010402040304"")
++
++	expected := common.FromHex(""0xa76862616c616e6365730065636f64657300666861736865731822646b65797300666e6f6e63657300697374727563747572650b6676616c756573005820858f70a4b1e6aa71a7edc574d2ca946495a038aa37ce13dc7b7ed15661a6ff2f0601024704010402040304"")
+ 	if !bytes.Equal(expected, b.Bytes()) {
+ 		t.Errorf(""Expected %x, got: %x"", expected, b.Bytes())
+ 	}",Why did this value change?,Why did this change?
+3515,"@@ -23,6 +23,7 @@ import (
+ 	duckv1 ""knative.dev/pkg/apis/duck/v1""
+ 	""knative.dev/pkg/kmeta""
+ 
++	gcpduckv1alpha1 ""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1""
+ 	""github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1""
+ )
+ ",maybe `duckpubsubv1alpha1` ?,"gcpduckv1alpha1 ""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1"""
+3516,"@@ -327,6 +327,16 @@ class FirefoxProfile(object):
+                     rc.append(node.data)
+             return ''.join(rc).strip()
+ 
++        def parse_manifest_json(content):
++            """"""Extracts the details from the contents of a WebExtensions `manifest.json` file.""""""
++            manifest = json.loads(content)
++            return {
++                'id': manifest['applications']['gecko']['id'],
++                'version': manifest['version'],
++                'name': manifest['version'],
++                'unpack': False,
++            }
++
+         if not os.path.exists(addon_path):
+             raise IOError('Add-on path does not exist: %s' % addon_path)
+ ",The id is not mandatory for web extensions. Could you update this to support a web extension without an id?,I'm not sure if this is the right place for this function. I think it should be in the `webextensions` module.
+3517,"@@ -31,11 +31,6 @@ import (
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+ )
+ 
+-const (
+-	serviceName = ""pubsub.googleapis.com""
+-	methodName  = ""google.pubsub.v1.Publisher.CreateTopic""
+-)
+-
+ func CloudAuditLogsSourceWithTestImpl(t *testing.T, authConfig lib.AuthConfig) {
+ 	project := os.Getenv(lib.ProwProjectKey)
+ ","I actually prefer them to be defined here. Client who calls `lib` should define the args, not `lib` itself.",Why is this being removed?
+3518,"@@ -97,9 +97,11 @@ func (t *tty) recvtty(process *libcontainer.Process, socket *os.File) error {
+ 	// set raw mode to stdin and also handle interrupt
+ 	stdin, err := console.ConsoleFromFile(os.Stdin)
+ 	if err != nil {
++		epollConsole.Close()
+ 		return err
+ 	}
+ 	if err := stdin.SetRaw(); err != nil {
++		epollConsole.Close()
+ 		return fmt.Errorf(""failed to set the terminal from the stdin: %v"", err)
+ 	}
+ 	go handleInterrupt(stdin)",I think this should've been done with the `defer`-named-return trick. I'll submit a PR for it.,Why do we need to do this?
+3519,"@@ -1048,6 +1048,12 @@ stats (config.stat_config),
+ vote_uniquer (block_uniquer),
+ startup_time (std::chrono::steady_clock::now ())
+ {
++	if (config.websocket_config.enabled)
++	{
++		websocket_server = std::make_shared<nano::websocket::listener> (*this, nano::tcp_endpoint (boost::asio::ip::address_v6::any (), config.websocket_config.port));
++		this->websocket_server->run ();
++	}
++
+ 	wallets.observer = [this](bool active) {
+ 		observers.wallet.notify (active);
+ 	};",The bind address should be configurable.,"`std::make_shared<nano::websocket::listener> (*this, nano::tcp_endpoint (config.websocket_config.port));`"
+3520,"@@ -68,6 +68,11 @@ class LocalRepository implements Repository {
+         return fetchCategories(categoryDirectories);
+     }
+ 
++    @Override
++    public void delete() {
++        // nothing to do
++    }
++
+     private List<CategoryDTO> fetchCategories(File[] categoryDirectories) {
+         final List<CategoryDTO> results = new ArrayList<>();
+ ",Maybe the empty `delete()` should be implemented as default in the interface.,Why do we need this?
+3521,"@@ -24,7 +24,7 @@ class HDF5OutputLayerTest : public ::testing::Test {
+  protected:
+   HDF5OutputLayerTest()
+       : output_file_name_(tmpnam(NULL)),
+-        input_file_name_(""src/caffe/test/test_data/sample_data.h5""),
++        input_file_name_(CMAKE_SOURCE_DIR  ""caffe/test/test_data/sample_data.h5""),
+         blob_data_(new Blob<Dtype>()),
+         blob_label_(new Blob<Dtype>()),
+         num_(5),",How to ensure CMAKE_SOURCE_DIR is set correctly?,Why is this change n
+3522,"@@ -106,7 +106,7 @@ func (ws *workingSet) LoadOrCreateAccountState(addr string, init *big.Int) (*Acc
+ 	switch {
+ 	case errors.Cause(err) == ErrStateNotExist:
+ 		account := Account{
+-			Balance:      init,
++			Balance:      big.NewInt(0).SetBytes(init.Bytes()),
+ 			VotingWeight: big.NewInt(0),
+ 		}
+ 		ws.cachedStates[addrHash] = &account",safer to make a copy of incoming *big.Int,Why do we need this 
+3523,"@@ -19,6 +19,8 @@ import ""time""
+ const (
+ 	// ListContainersTimeout is the timeout for the ListContainers API.
+ 	ListContainersTimeout = 10 * time.Minute
++	// ListImagesTimeout is the timeout for the ListImages API
++	ListImagesTimeout = 10 * time.Minute
+ 	// LoadImageTimeout is the timeout for the LoadImage API. It's set
+ 	// to much lower value than pullImageTimeout as it involves loading
+ 	// image from either a file or STDIN",how did we choose this value? does this hold good for Windows too?,I think this should 
+3524,"@@ -0,0 +1,17 @@
++// +build nocriu
++
++package libcontainer
++
++import (
++	""errors""
++)
++
++var errNotEnabled = errors.New(""Checkpoint/restore not supported"")
++
++func (c *linuxContainer) Checkpoint(opts *CheckpointOpts) error {
++	return errNotEnabled
++}
++
++func (c *linuxContainer) Restore(process *Process, opts *CheckpointOpts) error {
++	return errNotEnabled
++}","To follow the other build tags, maybe we can call it `criu`?",Why do we need this file?
+3525,"@@ -20,9 +20,10 @@ module Bolt
+       log_destination: STDERR
+     }.freeze
+ 
+-    TRANSPORT_OPTIONS = %i[insecure password run_as sudo sudo_password key tty user].freeze
++    TRANSPORT_OPTIONS = %i[insecure password run_as sudo sudo_password key tty user connect_timeout].freeze
+ 
+     TRANSPORT_DEFAULTS = {
++      connect_timeout: 10,
+       insecure: false,
+       tty: false
+     }.freeze",Should we load this from the config file too?,I think this should be `c
+3526,"@@ -128,6 +128,12 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 		}
+ 
+ 		nextRecover := now.Add(*duration)
++		// TODO(at15): this should be validated in webhook instead of throwing error at runtime.
++		// User can give a cron with interval shorter than duration.
++		// Example:
++		//  duration: ""10s""
++		//  scheduler:
++		//    cron: ""@every 5s
+ 		if nextStart.Before(nextRecover) {
+ 			err := fmt.Errorf(""nextRecover shouldn't be later than nextStart"")
+ 			r.Log.Error(err, ""nextRecover is later than nextStart. Then recover can never be reached"",",Can you file an issue for this?,I don't think we should t
+3527,"@@ -122,7 +122,7 @@ class Connection extends EventEmitter {
+       if (issue.isTimeout) {
+         op.cb(
+           new MongoNetworkTimeoutError(`connection ${this.id} to ${this.address} timed out`, {
+-            beforeHandshake: !!this[kIsMaster]
++            beforeHandshake: this[kIsMaster] == null
+           })
+         );
+       } else if (issue.isClose) {",@nbbeeken what were the cases where `!!this[kIsMaster]` was yielding an incorrect value? we should try to cover them in the tests,`beforeHandshake: this[kI
+3528,"@@ -51,6 +51,19 @@ module Bolt
+       end
+     end
+ 
++    def setup_inventory(inventory)
++      config = Bolt::Config.default
++      config.overwrite_transport_data(inventory['config']['transport'],
++                                      Bolt::Util.symbolize_top_level_keys(inventory['config']['transports']))
++
++      bolt_inventory = Bolt::Inventory.new(inventory['data'],
++                                           config,
++                                           Bolt::Util.symbolize_top_level_keys(inventory['target_hash']))
++
++      bolt_inventory.collect_groups
++      bolt_inventory
++    end
++
+     def compile_catalog(request)
+       pal_main = request['code_ast'] || request['code_string']
+       target = request['target']",This whole function feels messy. I don't have a better idea at the moment though.,Why do we need to collect groups here?
+3529,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-	  
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()), 
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+ 
+   @Override",should use Number instead of Long,Why do we need to cast here?
+3530,"@@ -0,0 +1,18 @@
++package mock
++
++import (
++	""context""
++
++	""github.com/influxdata/flux/dependencies/influxdb""
++)
++
++type MockProvider struct {
++	influxdb.UnimplementedProvider
++	WriterForFn func(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error)
++}
++
++var _ influxdb.Provider = &MockProvider{}
++
++func (m MockProvider) WriterFor(ctx context.Context, conf influxdb.Config) (influxdb.Writer, error) {
++	return m.WriterForFn(ctx, conf)
++}",Can you rename this and the file `InfluxDBProvider` and `influxdb_provider.go` respectively?,Why do we need this?
+3531,"@@ -187,10 +187,10 @@ function innerDiffNode(dom, vchildren, context, mountAll, absorb) {
+ 		min = 0,
+ 		len = originalChildren.length,
+ 		childrenLen = 0,
+-		vlen = vchildren && vchildren.length,
++		vlen = vchildren ? vchildren.length : 0,
+ 		j, c, vchild, child;
+ 
+-	if (len) {
++	if (len!==0) {
+ 		for (let i=0; i<len; i++) {
+ 			let child = originalChildren[i],
+ 				props = child[ATTR_KEY],","This is the real culprit, as now vlen will always be a Number (and known to the compiler as such). You could probably go one step further and avoid the ToBoolean on `vchildren` as well by writing something like `vlen = (vchildren !== undefined) ? vchildren.length : 0` if that matches the contract.",`if (len) {`
+3532,"@@ -41,6 +41,7 @@ public class NutritionProductFragment extends BaseFragment implements CustomTabA
+     @BindView(R.id.listNutrientLevels) ListView lv;
+     @BindView(R.id.textServingSize) TextView serving;
+     @BindView(R.id.textCarbonFootprint) TextView carbonFootprint;
++    @BindView(R.id.txtNoDataString)TextView noTextString;
+     private CustomTabActivityHelper customTabActivityHelper;
+     private Uri nutritionScoreUri;
+ ",missing space before `TextView`,Please add a space after the `)`.
+3533,"@@ -616,6 +616,16 @@ Attr_ReadValue Item::readAttr(AttrTypes_t attr, PropStream& propStream)
+ 			break;
+ 		}
+ 
++		case ATTR_OPENCONTAINER: {
++			int32_t openContainer;
++			if (!propStream.read<int32_t>(openContainer)) {
++				return ATTR_READ_ERROR;
++			}
++
++			setIntAttr(ITEM_ATTRIBUTE_OPENCONTAINER, openContainer);
++			break;
++		}
++
+ 		//these should be handled through derived classes
+ 		//If these are called then something has changed in the items.xml since the map was saved
+ 		//just read the values","so this attribute is used as u8 in code, but saves as int32? Why?",I don't think this is the right p
+3534,"@@ -41,7 +41,7 @@ from nupic.encoders.random_distributed_scalar import RandomDistributedScalarEnco
+ # Map class to Cap'n Proto schema union attribute
+ _CLASS_ATTR_MAP = {
+   ScalarEncoder: ""scalarEncoder"",
+-  AdaptiveScalarEncoder: ""adaptivescalar"",
++  AdaptiveScalarEncoder: ""adaptiveScalarEncoder"",
+   DateEncoder: ""dateEncoder"",
+   LogEncoder: ""logEncoder"",
+   CategoryEncoder: ""categoryEncoder"",",can RDSE be added to the list? It has its capnp files.,I don't think we need this change
+3535,"@@ -35,11 +35,11 @@ import (
+ 
+ // certificateToInjectableFunc converts a given certificate to the reconcile requests for the corresponding injectables
+ // (webhooks, api services, etc) that reference it.
+-type certificateToInjectableFunc func(log logr.Logger, cl client.Client, certName types.NamespacedName) []ctrl.Request
++type certificateToInjectableFunc func(log logr.Logger, cl client.Reader, certName types.NamespacedName) []ctrl.Request
+ 
+ // buildCertToInjectableFunc creates a certificateToInjectableFunc that maps from certificates to the given type of injectable.
+ func buildCertToInjectableFunc(listTyp runtime.Object, resourceName string) certificateToInjectableFunc {
+-	return func(log logr.Logger, cl client.Client, certName types.NamespacedName) []ctrl.Request {
++	return func(log logr.Logger, cl client.Reader, certName types.NamespacedName) []ctrl.Request {
+ 		log = log.WithValues(""type"", resourceName)
+ 		objs := listTyp.DeepCopyObject()
+ 		if err := cl.List(context.Background(), objs, client.MatchingFields{injectFromPath: certName.String()}); err != nil {","These functions only ever read from the API and should always be reading from a cache, so I have made that explicit by expecting a Reader here and supplying a `cache.Cache` as the client.",Why do we need to change this?
+3536,"@@ -1495,6 +1495,7 @@ mangle_direct_call(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+     if (target == (app_pc)retaddr) {
+         LOG(THREAD, LOG_INTERP, 3, ""found call to next instruction "" PFX ""\n"", target);
+     } else {
++        /* XXX i#3307: necessary to instr_set_translation_mangling_epilogue? */
+         check_return_handle_call(dcontext, ilist, next_instr);
+     }
+     /* now do the normal thing for a call */","No, we can't skip any of the mangling after the suspend point: this should follow the other mangling and undo its push.",I don't think this is the right place to do this.
+3537,"@@ -4,6 +4,7 @@
+ 
+ import flatbuffers
+ from flatbuffers.compat import import_numpy
++from tests.namespace_test.NamespaceC.TableInC import TableInC, TableInCT
+ np = import_numpy()
+ 
+ class SecondTableInA(object):",this is generated code.. these changes will need to be made in the code generator to have them stick.,I don't think this import is needed.
+3538,"@@ -1,8 +1,9 @@
++/* global xit */
+ describe('hidden content', function () {
+ 	'use strict';
+ 
+-  var fixture = document.getElementById('fixture');
+-
++	var fixture = document.getElementById('fixture');
++	var shadowSupport = document.body && typeof document.body.attachShadow === 'function';
+ 	var checkContext = {
+ 		_data: null,
+ 		data: function (d) {",Should we abstract this into a reusable utility so it doesn't have to get repeated in every test file needing Shadow DOM support?,Why do we need this?
+3539,"@@ -9,6 +9,7 @@ const ignoreNsNotFound = shared.ignoreNsNotFound;
+ const loadSpecTests = require('../spec').loadSpecTests;
+ const chai = require('chai');
+ const expect = chai.expect;
++const runUnifiedTest = require('./unified-spec-runner/runner').runUnifiedTest;
+ 
+ describe('APM', function() {
+   before(function() {",Maybe we rename this to `command_monitoring.test.js` to match the directory name change? Or would you rather do that as part of the greater test cleanup? I'm fine either way.,nit: `runUnifiedTest` -> `runUnifiedSpecTest`
+3540,"@@ -577,7 +577,7 @@ SchemaString.prototype.$conditionalHandlers =
+       $gte: handleSingle,
+       $lt: handleSingle,
+       $lte: handleSingle,
+-      $options: handleSingle,
++      $options: String,
+       $regex: handleSingle,
+       $not: handleSingle
+     });","Why is this change necessary? `handleSingle()` will cast it to a string, no?",Why is this a<msg>Why not just `<msg>`<msg>`<msg>I don't think this should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>Why is it a<msg>I don't think it should be a<msg>Why is it a<msg>I don't think it should be a<msg>I don't think it should be a<msg>Why is it a<msg>I don't think it should be a<msg>Why is it a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be.
+3541,"@@ -228,4 +228,13 @@ public interface Table {
+    * @return a {@link LocationProvider} to provide locations for new data files
+    */
+   LocationProvider locationProvider();
++
++  /**
++   * Return the name of this table.
++   *
++   * @return this table's name
++   */
++  default String name() {
++    return ""table("" + hashCode() + "")"";
++  }
+ }","This newly added method should be well defined, should it return `TableIdentifier` or just `String`?",Why do we need this method?
+3542,"@@ -18,7 +18,8 @@ use Ergonode\Core\Infrastructure\Model\RelationshipGroup;
+ 
+ class ProductMultimediaRelationshipStrategy implements RelationshipStrategyInterface
+ {
+-    private const MESSAGE = 'Object has active relationships with multimedia %relations%';
++    private const ONE_MESSAGE = 'Multimedia has a relation with product';
++    private const MULTIPLE_MESSAGE = 'Multimedia has %count% relations with some products';
+ 
+     private ProductQueryInterface $productQuery;
+ ",have a relation with a product,Shouldn't it be `%count% relations with products`?
+3543,"@@ -129,8 +129,11 @@ var _ = Describe(""health tests"", func() {
+ 
+ 		AfterEach(func() {
+ 			for _, name := range podsToCleanUp {
+-				err := k8sInfra.K8sClient.CoreV1().Pods(""default"").Delete(name, &metav1.DeleteOptions{})
+-				Expect(err).NotTo(HaveOccurred())
++				// It is possible for a local pod to be deleted by GC if node is gone.
++				if k8sInfra.PodExist(""default"", name) {
++					err := k8sInfra.K8sClient.CoreV1().Pods(""default"").Delete(name, &metav1.DeleteOptions{})
++					Expect(err).NotTo(HaveOccurred())
++				}
+ 			}
+ 			podsToCleanUp = nil
+ 		})","I guess that there is still a window here, because the GC could happen between the `PodExist` and `Delete` calls. Would it be better instead to check `err` and allow it if it says ""pod has already been deleted""?",Why do we need this check?
+3544,"@@ -65,13 +65,8 @@ class DbTaskHistory(task_history.TaskHistory):
+             yield session
+         else:
+             session = self.session_factory()
+-            try:
++            with session.transaction:
+                 yield session
+-            except:
+-                session.rollback()
+-                raise
+-            else:
+-                session.commit()
+ 
+     def __init__(self):
+         config = configuration.get_config()",SQLAlchemy's session management does magic to make sure that if the rollback fails you still get the original exception that caused the rollback. Also it looks nicer.,Why did you remove this?
+3545,"@@ -88,11 +88,11 @@ func (q *actQueue) Overlaps(act *iproto.ActionPb) bool {
+ 	switch {
+ 	case act.GetTransfer() != nil:
+ 		tsf := &action.Transfer{}
+-		tsf.ConvertFromTransferPb(act.GetTransfer())
++		tsf.ConvertFromActionPb(act)
+ 		nonce = tsf.Nonce
+ 	case act.GetVote() != nil:
+ 		vote := &action.Vote{}
+-		vote.ConvertFromVotePb(act.GetVote())
++		vote.ConvertFromActionPb(act)
+ 		nonce = vote.Nonce
+ 	}
+ 	return q.items[nonce] != nil",This switch statement can be removed. Just return q.items[act.Nonce] != nil,Why do we need to change
+3546,"@@ -119,7 +119,7 @@ public class AvoidInstantiatingObjectsInLoopsRule extends AbstractJavaRule {
+                  */
+                 n = n.getParent();
+             } else if (n.getParent() instanceof ASTForStatement && n.getParent().getNumChildren() > 1
+-                    && n == n.getParent().getChild(1)) {
++                    && n.equals(n.getParent().getChild(1))) {
+                 // it is the second child of a ForStatement - which means
+                 // we are dealing with a for-each construct
+                 // In that case, we can ignore this allocation expression, as","I think `==` for nodes is more readable than equals. An equals calls looks like it could be recursing, because intuitively two nodes are equal if their subtree are the equal. But everywhere you replaced, we don't want to test whether the subtrees are structurally equal, we want to know whether they're the same. Only `==` captures this intent, using equals obscures this. Not to mention that equals may NPE and is in that sense less ergonomic. I think we should enhance the rule with a list of types for which `==` is correct. Edit: in the meantime i think we could suppress those new violations...",Why is this change neede
+3547,"@@ -29,6 +29,9 @@ namespace ResultsComparer
+         [Option(""csv"", HelpText = ""Path to exported CSV results. Optional."")]
+         public FileInfo CsvPath { get; set; }
+ 
++        [Option('f', ""filter"", HelpText = ""Filter the benchmarks by name using glob pattern(s). Optional."")]
++        public IEnumerable<string> Filters { get; set; }
++
+         [Usage(ApplicationAlias = """")]
+         public static IEnumerable<Example> Examples
+         {",What's the scenario for passing multiple filters?,">Filters [](start = 24, "
+3548,"@@ -201,9 +201,10 @@ bool Part::commitLogs(std::unique_ptr<LogIterator> iter) {
+     LogID lastId = -1;
+     TermID lastTerm = -1;
+     while (iter->valid()) {
+-        lastId = iter->logId();
+-        lastTerm = iter->logTerm();
+-        auto log = iter->logMsg();
++        auto logEntry = iter->logEntry();
++        lastId = std::get<0>(logEntry);
++        lastTerm = std::get<1>(logEntry);
++        auto log = std::get<3>(logEntry);
+         if (log.empty()) {
+             VLOG(3) << idStr_ << ""Skip the heartbeat!"";
+             ++(*iter);",move to after check log.empty(),nit: `auto log = std::get<0>(logEntry);`
+3549,"@@ -19,6 +19,7 @@
+ # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+ 
+ """""" Comments and reviews for records: web interface """"""
++from docutils.nodes import note
+ 
+ __lastupdated__ = """"""$Date$""""""
+ ",This line needs to be removed,Why is this import needed?
+3550,"@@ -68,7 +68,7 @@ type CloudBuildSourceSpec struct {
+ 
+ const (
+ 	// CloudBuildSource CloudEvent type
+-	CloudBuildSourceEvent = ""com.google.cloud.build.event""
++	CloudBuildSourceEvent = ""google.cloud.cloudbuild.build.v1.statusChanged""
+ 	// CloudBuildSourceBuildId is the Pub/Sub message attribute key with the CloudBuildSource's buildId.
+ 	CloudBuildSourceBuildId = ""buildId""
+ 	// CloudBuildSourceBuildStatus is the Pub/Sub message attribute key with the CloudBuildSource's build status.",Can we delete such const like `CloudBuildSourceEvent` and `CloudBuildSourceBuildId` since all those are contained under schemas/v1?,I think this should be CloudBuildSourceS
+3551,"@@ -0,0 +1,8 @@
++// Package vsphere contains vSphere-specific structures for installer
++// configuration and management.
++// +k8s:deepcopy-gen=package,register
++// +k8s:conversion-gen=github.com/openshift/hive/pkg/apis/hive
++package vsphere
++
++// Name is name for the vsphere platform.
++const Name string = ""vsphere""",This is unused.,Why do we need this?
+3552,"@@ -32,9 +32,13 @@ namespace OpenTelemetry.Instrumentation.Http
+         public bool SetHttpFlavor { get; set; }
+ 
+         /// <summary>
+-        /// Gets or sets <see cref=""ITextFormat""/> for context propagation. Default value: <see cref=""TraceContextFormat""/>.
++        /// Gets or sets <see cref=""ITextFormat""/> for context propagation. Default value: <see cref=""CompositePropagator""/>.
+         /// </summary>
+-        public ITextFormat TextFormat { get; set; } = new TraceContextFormat();
++        public ITextFormat TextFormat { get; set; } = new CompositePropagator(new System.Collections.Generic.List<ITextFormat>
++        {
++            new TraceContextFormat(),
++            new BaggageFormat(),
++        });
+ 
+         /// <summary>
+         /// Gets or sets an optional callback method for filtering <see cref=""HttpWebRequest""/> requests that are sent through the instrumentation.",Any reason not to put `using System.Collections.Generic` (guess there shouldn't be naming conflicts)?,Why is this needed?
+3553,"@@ -0,0 +1,8 @@
++class TwitterPlayerCardsController < ApplicationController
++  layout false
++
++  def show
++    response.headers.delete(""X-Frame-Options"")
++    @video = Video.find(params[:video_id])
++  end
++end",Could the name of this controller just be shortened to `TwitterCardsController`? Is the `Player` there adding information?,Extra empty line de
+3554,"@@ -138,6 +138,9 @@ func (u *staticUpstream) NewHost(host string) (*UpstreamHost, error) {
+ 				if uh.Unhealthy {
+ 					return true
+ 				}
++				if uh.Dynamic {
++					return false
++				}
+ 				if uh.Fails >= u.MaxFails &&
+ 					u.MaxFails != 0 {
+ 					return true",Backends with hostnames that depend on the request are always up?,Shouldn't this be `
+3555,"@@ -4,6 +4,8 @@ import functools
+ import colander
+ import venusian
+ import six
++from jsonpatch import JsonPatchException
++from jsonpointer import JsonPointerException
+ from pyramid import exceptions as pyramid_exceptions
+ from pyramid.decorator import reify
+ from pyramid.security import Everyone","I'd rather catch those to `utils.py` and raise a simple ValueError from them. From the resource point of view, these are details of implementation",This should be `fro
+3556,"@@ -11,10 +11,6 @@ module Travis
+   module Build
+     class Script
+       class Julia < Script
+-        DEFAULTS = {
+-          julia: 'release',
+-        }
+-
+         def export
+           super
+ ","make this 1.0 ? I don't think all that many people do `language: julia` without any `julia:` specifiers, but may as well keep that possible?",Why is this being removed?
+3557,"@@ -20,7 +20,10 @@
+ //
+ // For secrets.OpenKeeper, azurekeyvault registers for the scheme ""azurekeyvault"".
+ // The default URL opener will use Dial, which gets default credentials from the
+-// environment.
++// environment, unless the AZURE_KEYVAULT_AUTH_VIA_CLI environment variable is
++// set to true, in which case it uses DialUsingCLIAuth to get credentials from the
++// ""az"" command line.
++//
+ // To customize the URL opener, or for more details on the URL format,
+ // see URLOpener.
+ // See https://gocloud.dev/concepts/urls/ for background information.","nit: `AZURE_KEYVAULT_AUTH_VIA_CLI` is defined by us, so it might be helpful to differentiate it from azure's env names. Maybe starts with `GOCDK`.",I don't think this is the 
+3558,"@@ -34,10 +34,10 @@ type Validator struct {
+ }
+ 
+ // NewValidator return Validator instance
+-func NewValidator(sessionManager session.Manager, extractor identity.Extractor) *Validator {
++func NewValidator(sessionStorage *session.Storage, extractor identity.Extractor) *Validator {
+ 	return &Validator{
+ 		clientMap: &clientMap{
+-			sessionManager:   sessionManager,
++			sessions:         sessionStorage,
+ 			sessionClientIDs: make(map[session.SessionID]int),
+ 			sessionMapLock:   sync.Mutex{},
+ 		},",Depend on interfaces not on structures,Why do we need a pointer h
+3559,"@@ -180,7 +180,7 @@ void signalHandler(int sig) {
+     case SIGTERM:
+       FLOG_INFO(""Signal %d(%s) received, stopping this server"", sig, ::strsignal(sig));
+       if (gStorageServer) {
+-        gStorageServer->stop();
++        gStorageServer->notifyStop();
+       }
+       break;
+     default:","This fix looks good. My concern, don't forget to fix metad too!",Shouldn't this be in a `fi
+3560,"@@ -196,13 +196,15 @@ func makeMDJournalWithIDJournal(
+ 	}
+ 
+ 	if earliest != nil {
+-		if earliest.BID() != latest.BID() {
++		if earliest.BID() != latest.BID() &&
++			!(earliest.BID() == NullBranchID &&
++				latest.BID() == LocalSquashBranchID) {
+ 			return nil, fmt.Errorf(
+ 				""earliest.BID=%s != latest.BID=%s"",
+ 				earliest.BID(), latest.BID())
+ 		}
+-		log.CDebugf(nil, ""Initializing with branch ID %s"", earliest.BID())
+-		journal.branchID = earliest.BID()
++		log.CDebugf(nil, ""Initializing with branch ID %s"", latest.BID())
++		journal.branchID = latest.BID()
+ 	}
+ 
+ 	return &journal, nil","Just noticed this nil context. Perhaps plumb through ctx too, or change to `Debug`?",Why do we need this check?
+3561,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+ 
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?,Why is this needed?
+3562,"@@ -50,6 +50,11 @@ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {
+ 
++// port use if the ros environment variable doesn't specified one
++const uint16_t DEFAULT_ROS2_SERVER_PORT = 11811;
++// default server guidPrefix
++const char* DEFAULT_ROS2_SERVER_GUIDPREFIX = ""44.49.53.43.53.45.52.56.45.52.5F.30"";
++
+ GUID_t RemoteServerAttributes::GetParticipant() const
+ {
+     return GUID_t(guidPrefix, c_EntityId_RTPSParticipant);",Again use of `constexpr` is recomended.,Why is this needed?
+3563,"@@ -8,6 +8,12 @@ from ..core.operation import Operation
+ from .chart import Points
+ from .path import Path
+ 
++try:
++    from datashader.layout import LayoutAlgorithm as ds_layout
++except:
++    ds_layout = None
++
++
+ class graph_redim(redim):
+     """"""
+     Extension for the redim utility that allows re-dimensioning",Minor point but I would call this ``redim_graph`` instead.,Why do we need this?
+3564,"@@ -26,12 +26,14 @@ import (
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/schema""
+-	""k8s.io/klog""
++	""k8s.io/utils/pointer""
+ 	infrav1 ""sigs.k8s.io/cluster-api-provider-aws/pkg/apis/infrastructure/v1alpha2""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/scope""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/ec2""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/elb""
++	""sigs.k8s.io/cluster-api/pkg/apis/cluster/common""
+ 	clusterv1 ""sigs.k8s.io/cluster-api/pkg/apis/cluster/v1alpha2""
++	""sigs.k8s.io/cluster-api/pkg/controller/noderefutil""
+ 	capierrors ""sigs.k8s.io/cluster-api/pkg/errors""
+ 	""sigs.k8s.io/cluster-api/pkg/util""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""","As I was trying to figure out how the error messages are written out, since they are returned from `getOrCreate` and `reconcile`, it looks like we are using plain `klog` to write them out instead of using the logger from the scope above",nit: remove empty line.
+3565,"@@ -40,15 +40,11 @@ func (service *servicePFCtl) Add(rule RuleForwarding) {
+ func (service *servicePFCtl) Start() error {
+ 	err := service.ipForward.Enable()
+ 	if err != nil {
+-		return err
++		log.Warn(natLogPrefix, ""Failed to enable IP forwarding: "", err)
+ 	}
+ 
+ 	service.clearStaleRules()
+-	err = service.enableRules()
+-	if err != nil {
+-		return err
+-	}
+-	return nil
++	return service.enableRules()
+ }
+ 
+ func (service *servicePFCtl) Stop() {","Now it's double logging, is not it? Because `service.ipForward.Enable()` logs extra `warning`",Shouldn't this be `log.
+3566,"@@ -256,6 +256,9 @@ OpenStreetMap::Application.routes.draw do
+   # directions
+   get ""/directions"" => ""directions#search""
+ 
++  # set home location
++  match ""/set_home_loc"" => ""user#set_home_location"", :via => [:get, :post]
++
+   # export
+   post ""/export/finish"" => ""export#finish""
+   get ""/export/embed"" => ""export#embed""","Whatever the decision is about the request type to use, this should only match what is needed and not the other one.",Use the new Ruby 1.9 ha
+3567,"@@ -1025,7 +1025,9 @@ Blockly.BlockSvg.prototype.handleDragFree_ = function(oldXY, newXY, e) {
+   }
+ 
+   var updatePreviews = true;
+-  if (Blockly.localConnection_ && Blockly.highlightedConnection_) {
++  if (localConnection && localConnection.type == Blockly.OUTPUT_VALUE) {
++    updatePreviews = true; // Always update previews for output connections.
++  } else if (Blockly.localConnection_ && Blockly.highlightedConnection_) {
+     var xDiff = Blockly.localConnection_.x_ + dxy.x -
+         Blockly.highlightedConnection_.x_;
+     var yDiff = Blockly.localConnection_.y_ + dxy.y -","...and in turn, this should probably be var updatePreviews = true; if (!(localConnection && localConnection.type == Blockly.OUTPUT_VALUE) && (Blockly.localConnection_ && Blockly.highlightedConnection_)) { since the first clause is a no-op. If you want to leave it this way for clarity, that's fine too.",Why is this change need
+3568,"@@ -70,8 +70,7 @@ class BigqueryRulesEngine(bre.BaseRulesEngine):
+         self.rule_book = BigqueryRuleBook(self._load_rule_definitions())
+ 
+     # TODO: The naming is confusing and needs to be fixed in all scanners.
+-    def find_policy_violations(self, parent_project, bq_acl,
+-                               force_rebuild=False):
++    def find_violations(self, parent_project, bq_acl, force_rebuild=False):
+         """"""Determine whether Big Query datasets violate rules.
+ 
+         Args:","Please remove this TODO, since they will not apply anymore after you are done. :) Can you please remove this everywhere else in this PR?",I'm not sure if this is the right name for this method. Maybe `find_violations`?
+3569,"@@ -1667,6 +1667,13 @@ void ErrorTest() {
+   TestError(""enum X:byte { Y, Y }"", ""value already"");
+   TestError(""enum X:byte { Y=2, Z=2 }"", ""unique"");
+   TestError(""table X { Y:int; } table X {"", ""datatype already"");
++  TestError(""table X { A:bool; } table Y { } union X {"",
++            ""enum clashes with datatype"");
++  TestError(""union X { X, Y } table X {"", ""datatype clashes with enum"");
++  TestError(""namespace A; table X { } namespace A; union X {"",
++            ""enum clashes with datatype"");
++  TestError(""namespace A; union X { } namespace A; table X {"",
++            ""datatype clashes with enum"");
+   TestError(""struct X (force_align: 7) { Y:int; }"", ""force_align"");
+   TestError(""struct X {}"", ""size 0"");
+   TestError(""{}"", ""no root"");",This seems like an incomplete schema definition. will that have any effect on the tests?,Why do we need this test case?
+3570,"@@ -22,7 +22,10 @@ DatasetLoader::DatasetLoader(const Config& io_config, const PredictFunction& pre
+   label_idx_ = 0;
+   weight_idx_ = NO_SPECIFIC;
+   group_idx_ = NO_SPECIFIC;
+-  SetHeader(filename);
++  if (filename != nullptr && CheckCanLoadFromBin(filename) == """") {
++    // SetHeader should only be called when loading from text file
++    SetHeader(filename);
++  }
+   store_raw_ = false;
+   if (io_config.linear_tree) {
+     store_raw_ = true;","The testing cases are failing because `SetHeader` does not only handle cases where input are from files. It also reads categorical feature indices from the config parameters (see the part outside the `if (filename != nullptr) { ... }`). Skipping `SetHeader` directly here will cause errors when we load data from numpy or pandas arrays (where `filename == nullptr`) and use categorical features. So I think we should move the the check `filename != nullptr && CheckCanLoadFromBin(filename) == """"` into `SetHeader`. That is, we change `if (filename != nullptr) { ... }` into `if (filename != nullptr && CheckCanLoadFromBin(filename) == """") { ... }`",Why is this check needed?
+3571,"@@ -148,8 +148,7 @@ func (m *BackgroundProcessManager) StartProcess(cmd *ManagedProcess) (*process.P
+ 	go func() {
+ 		err := cmd.Wait()
+ 		if err != nil {
+-			err, ok := err.(*exec.ExitError)
+-			if ok {
++			if err, ok := err.(*exec.ExitError); ok {
+ 				status := err.Sys().(syscall.WaitStatus)
+ 				if status.Signaled() && status.Signal() == syscall.SIGTERM {
+ 					log.Info(""process stopped with SIGTERM signal"")","I think we should change the variable name of `err` in `if err, ok := err.(*exec.ExitError); ok `, this re-assignment of `err` still affects the next `else` branch",Why is this change needed?
+3572,"@@ -145,6 +145,18 @@ folly::Future<StatusOr<std::vector<SpaceIdName>>> MetaClient::listSpaces() {
+                 });
+ }
+ 
++
++folly::Future<StatusOr<bool>> MetaClient::dropSpace(std::string name) {
++    cpp2::DropSpaceReq req;
++    req.set_space_name(std::move(name));
++    return getResponse(std::move(req), [] (auto client, auto request) {
++                    return client->future_dropSpace(request);
++                }, [] (cpp2::ExecResp&& resp) -> bool {
++                    return resp.code == cpp2::ErrorCode::SUCCEEDED;
++                });
++}
++
++
+ folly::Future<StatusOr<bool>> MetaClient::addHosts(const std::vector<HostAddr>& hosts) {
+     std::vector<nebula::cpp2::HostAddr> thriftHosts;
+     thriftHosts.resize(hosts.size());",`Status` has identical semantics with `StatusOr<bool>`.,Why do we need a separate function for dropping a space?
+3573,"@@ -75,6 +75,7 @@ var allowedPaths = []string{
+ 	""/readyz"",
+ 	""/mutate/acnp"",
+ 	""/mutate/anp"",
++	""/mutate/addlabels"",
+ 	""/validate/tier"",
+ 	""/validate/acnp"",
+ 	""/validate/anp"",",why is this named in a different style from other paths?,"""/mutate/tier"","
+3574,"@@ -73,13 +73,13 @@ func (r *AWSClusterReconciler) Reconcile(req ctrl.Request) (_ ctrl.Result, reter
+ 		return reconcile.Result{}, err
+ 	}
+ 
+-	if isPaused(cluster, awsCluster) {
+-		log.Info(""AWSCluster or linked Cluster is marked as paused. Won't reconcile"")
++	if cluster == nil {
++		log.Info(""Cluster Controller has not yet set OwnerRef"")
+ 		return reconcile.Result{}, nil
+ 	}
+ 
+-	if cluster == nil {
+-		log.Info(""Cluster Controller has not yet set OwnerRef"")
++	if util.IsPaused(cluster, awsCluster) {
++		log.Info(""AWSCluster or linked Cluster is marked as paused. Won't reconcile"")
+ 		return reconcile.Result{}, nil
+ 	}
+ ",Swapped these to ensure that we aren't passing a nil cluster in to util.IsPaused,I don't think this should be a warning. It should be an 
+3575,"@@ -25,13 +25,18 @@ import (
+ 	api ""google.golang.org/api/compute/v1""
+ )
+ 
++type platformPkgManagerTuple struct {
++	platform   string
++	pkgManager string
++}
++
+ const (
+ 	packageInstalledString    = ""package is installed""
+ 	packageNotInstalledString = ""package is not installed""
+ )
+ 
+ var (
+-	pkgManagers = []string{""apt"", ""yum""}
++	tuples = []platformPkgManagerTuple{{""debian"", ""apt""}, {""centos"", ""yum""}, {""rhel"", ""yum""}}
+ )
+ 
+ // vf is the the vertificationFunction that is used in each testSetup during assertion of test case.","I don't see pkgManager used anywhere, is there a reason we need this?",Why do we need this?
+3576,"@@ -182,7 +182,7 @@ public class CoreDescriptor {
+    */
+   public CoreDescriptor(String name, Path instanceDir, Map<String, String> coreProps,
+                         Properties containerProperties, ZkController zkController) {
+-    this.instanceDir = instanceDir;
++    this.instanceDir = instanceDir.toAbsolutePath();
+ 
+     originalCoreProperties.setProperty(CORE_NAME, name);
+ ","A bit late, but I don't think this is necessary, as all callers will send absolute paths. And if you ever get a relative path, resolving it with `toAbsolutePath()` leads to it being relative to whatever CWD the app is started with, while the typical resolving of relative `instanceDir` is to resolve it relative to CoreContainer#coreRootDirectory.",Why do we need to change this?
+3577,"@@ -4188,7 +4188,8 @@ function getModelsMapForPopulate(model, docs, options) {
+       foreignField = foreignField.call(doc);
+     }
+ 
+-    const localFieldPath = modelSchema.paths[localField];
++    const localFieldPathType = modelSchema._getPathType(localField);
++    const localFieldPath = localFieldPathType === 'real' ? modelSchema.paths[localField] : localFieldPathType.schema;
+     const localFieldGetters = localFieldPath ? localFieldPath.getters : [];
+     let ret;
+ ",There's an awful lot of test failures here because `localFieldPathType.schema` may not contain a `getters` array.,`localFieldPathType === 'real'
+3578,"@@ -56,7 +56,13 @@ class User < ActiveRecord::Base
+ 
+   scope :search, -> (term) {
+     search_pattern = ""%#{term}%""
+-    where(""firstname LIKE ? OR surname LIKE ? OR email LIKE ?"", search_pattern, search_pattern, search_pattern)
++    # MySQL does not support standard string concatenation and since concat_ws or concat functions do
++    # not exist for sqlite, we have to come up with this conditional
++    if ActiveRecord::Base.connection.adapter_name == ""Mysql2""
++      where(""concat_ws(' ', firstname, surname) LIKE ? OR email LIKE ?"", search_pattern, search_pattern)
++    else
++      where(""firstname || ' ' || surname LIKE ? OR email LIKE ?"", search_pattern, search_pattern)
++    end
+   }
+ 
+   # EVALUATE CLASS AND INSTANCE METHODS BELOW",Mysql allows for `||` concatenation (e.g. `firstname||' '||surname`) if you enable it: `set sql_mode=PIPES_AS_CONCAT;`. I think this check is safer though,I'm not sure if this is the be
+3579,"@@ -5,11 +5,12 @@
+ package ens
+ 
+ import (
++	""bytes""
+ 	""errors""
+ 	""fmt""
+ 	""strings""
+ 
+-	""github.com/ethereum/go-ethereum/accounts/abi/bind""
++	""github.com/ethereum/go-ethereum/common""
+ 	""github.com/ethereum/go-ethereum/ethclient""
+ 	goens ""github.com/wealdtech/go-ens/v3""
+ ","NOTE: this is the default ENS registry address. If the ENS suite is deployed from the current builds to any chain, it will always be found at this address.",Why did you change this?
+3580,"@@ -26,6 +26,7 @@ Upcase::Application.routes.draw do
+   draw :teams
+   draw :trails
+   draw :users
++  draw :vanity
+   draw :videos
+ 
+   root to: ""homes#show""",I'm curious why you are using `draw` in this route file?,Why is this needed?
+3581,"@@ -195,7 +195,18 @@ func Diff(ctx *context.Context) {
+ }
+ 
+ func RawDiff(ctx *context.Context) {
+-	panic(""not implemented"")
++	userName := ctx.Repo.Owner.Name
++	repoName := ctx.Repo.Repository.Name
++	commitID := ctx.Params("":sha"")
++	diffType := ctx.Params("":ext"")
++
++	diff, err := models.GetRawDiff(models.RepoPath(userName, repoName),
++		commitID, diffType)
++	if err != nil {
++		ctx.Handle(404, ""GetRawDiff"", err)
++		return
++	}
++	ctx.HandleText(200, diff)
+ }
+ 
+ func CompareDiff(ctx *context.Context) {","Those variables are only been used once, I think we don't need to create them at all, just pass values to the `GetRawDiff` directly.",Shouldn't this be `
+3582,"@@ -3,7 +3,7 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+ 
+-#if NET461 || NET452
++#if NET461
+ 
+ using System;
+ using System.Linq;",I like the idea of replacing all the `#if NET461` with `#if NETFRAMEWORK`... is that worth doing now? Means fewer changes if we go to 4.7.2 at some point  ,Why did you remove 
+3583,"@@ -21,6 +21,8 @@ import (
+ // Compatible with Okta offline access, a holdover from previous defaults.
+ var defaultScopes = []string{oidc.ScopeOpenID, oidc.ScopeOfflineAccess, ""email""}
+ 
++const clutchProviderName = ""clutch""
++
+ type OIDCProvider struct {
+ 	provider *oidc.Provider
+ 	verifier *oidc.IDTokenVerifier","to fix the docs build failure, make this const var named without the suffix `Name`",// clutchProviderNa
+3584,"@@ -682,6 +682,7 @@ func checkClientTLSCertSubject(c *client, fn tlsMapAuthFn) bool {
+ 				return true
+ 			}
+ 		}
++		fallthrough
+ 	case hasURIs:
+ 		for _, u := range cert.URIs {
+ 			if match, ok := fn(u.String(), nil); ok {","This bugfix also included, in case a subjectAlternativeName was present in the cert, then URIs (e.g SVID SPIFFE auth) would not have been attempted.",Why is this change needed?
+3585,"@@ -0,0 +1,15 @@
++package com.fsck.k9.service;
++
++
++import java.io.File;
++import java.io.IOException;
++
++import android.net.Uri;
++
++
++public interface FileProviderInterface {
++
++    File createProvidedFile() throws IOException;
++    Uri getUriForProvidedFile(File file, String mimeType) throws IOException;
++
++}",Same here. Feels like the wrong location.,I don't think we need this
+3586,"@@ -42,7 +42,9 @@ from qutebrowser.keyinput import modeman
+ from qutebrowser.utils import (message, usertypes, log, qtutils, urlutils,
+                                objreg, utils)
+ from qutebrowser.utils.usertypes import KeyMode
+-from qutebrowser.misc import editor, guiprocess
++from qutebrowser.misc import editor, guiprocess, mhtml
++from qutebrowser.browser.downloads import (_path_suggestion as
++                                           download_path_suggestion)
+ 
+ 
+ class CommandDispatcher:",Please make `_path_suggestion` public (i.e. remove the `_`) in `downloads.py`.,Why is this import needed?
+3587,"@@ -40,6 +40,8 @@ func init() {
+ 	flag.StringVar(&revoke, ""revoke"", """", ""Hostname for which to revoke the certificate"")
+ 	flag.StringVar(&serverType, ""type"", ""http"", ""Type of server to run"")
+ 	flag.BoolVar(&version, ""version"", false, ""Show version"")
++	flag.StringVar(&caddytls.HTTPChallengePort, ""external-port-80-is-local-port"", ""80"", ""Local port exposed externally as port 80"")
++	flag.StringVar(&caddytls.TLSSNIChallengePort, ""external-port-443-is-local-port"", ""443"", ""Local port exposed externally as port 443"")
+ 
+ 	caddy.RegisterCaddyfileLoader(""flag"", caddy.LoaderFunc(confLoader))
+ 	caddy.SetDefaultCaddyfileLoader(""default"", caddy.LoaderFunc(defaultLoader))","Woah, these flag names gotta get shorter. (Edit: I'll try to suggest some if needed, will think on it.)",I think this should be `ex
+3588,"@@ -19,6 +19,14 @@ module Blacklight
+         end
+       end
+     end
++    
++    initializer ""blacklight.secret_key"" do |app|
++      if app.respond_to?(:secrets)
++        Blacklight.secret_key ||= app.secrets.secret_key_base
++      elsif app.config.respond_to?(:secret_key_base)
++        Blacklight.secret_key ||= app.config.secret_key_base
++      end
++    end
+ 
+   end
+-end
++end","Is this the code that's supposed to use the Rails app's only when in Rails4? What's the point of the first `if app.respond_to?(:secrets)`, both the `if` and the `elsif` have the same body, is only the second one needed? If `app.config` has a `secret_key_base`, then use it, the end. Is there a need for first checking if `app.respond_to?(:secrets)`?",I think this should be `app.config.secret_key_base`
+3589,"@@ -390,6 +390,9 @@ public:
+     m_nopayload_elems_bitmask =
+         enum_impl_strategy.getBitMaskForNoPayloadElements();
+ 
++    if (enum_decl->isObjC())
++      m_is_objc_enum = true;
++
+     LOG_PRINTF(LIBLLDB_LOG_TYPES, ""m_nopayload_elems_bitmask = %s"",
+                Dump(m_nopayload_elems_bitmask).c_str());
+ ",Does this not apply to C enums on Linux?,Why is this needed?
+3590,"@@ -511,7 +511,11 @@ function makeOperationHandler(server, connection, cmd, options, callback) {
+           session.serverSession.isDirty = true;
+         }
+ 
+-        if (supportsRetryableWrites(server) && !inActiveTransaction(session, cmd)) {
++        if (
++          isRetryableWriteError(err) &&
++          supportsRetryableWrites(server) &&
++          !inActiveTransaction(session, cmd)
++        ) {
+           err.addErrorLabel('RetryableWriteError');
+         }
+ ",Should this check if the error is `RetryableWriteError` before adding the label?,I don't think we need to check for `isRetryableWrit
+3591,"@@ -1,6 +1,8 @@
+ const Plugin = require('../core/Plugin')
+ const { findDOMElement } = require('../core/Utils')
+-const getFormData = require('get-form-data').default
++// Rollup uses get-form-data's ES modules build, and rollup-plugin-commonjs automatically resolves `.default`.
++// So, if we are being built using rollup, this require() won't have a `.default` property.
++const getFormData = require('get-form-data').default || require('get-form-data')
+ 
+ /**
+  * Form","Oh wow, that's one complicated require :)",I'm not sure if this is the right way to do this. I
+3592,"@@ -1,6 +1,6 @@
+ // snippet-comment:[These are tags for the AWS doc team's sample catalog. Do not remove.]
+ // snippet-sourceauthor:[Doug-AWS]
+-// snippet-sourcedescription:[Using context.Context with SDK requests.]
++// snippet-sourcedescription:[request_context.go shows how to usie context.Context with SDK requests.]
+ // snippet-keyword:[Extending the SDK]
+ // snippet-keyword:[Go]
+ // snippet-service:[aws-go-sdk]","do you mean how to ""use""",I think this should be `request_context.go`
+3593,"@@ -400,8 +400,9 @@ describe('forwardRef', () => {
+ 		const Transition = ({ children }) => {
+ 			const state = useState(0);
+ 			forceTransition = state[1];
+-			expect(children.ref).to.not.be.undefined;
+-			if (state[0] === 0) expect(children.props.ref).to.be.undefined;
++			// TODO: ref exists on the backing node
++			// expect(children.ref).to.not.be.undefined;
++			// if (state[0] === 0) expect(children.props.ref).to.be.undefined;
+ 			return children;
+ 		};
+ ",We can't really test this anymore since ref and props.ref are at the backing node level now,Can we remove this?
+3594,"@@ -56,6 +56,7 @@ abstract class BaseDataReader<T> implements Closeable {
+ 
+   private CloseableIterator<T> currentIterator;
+   private T current = null;
++  private FileScanTask currentTask = null;
+ 
+   BaseDataReader(CombinedScanTask task, FileIO io, EncryptionManager encryptionManager) {
+     this.tasks = task.files().iterator();",Did you intend to set this in the constructor?,Why do we need this?
+3595,"@@ -106,11 +106,15 @@ func (s *Service) createInstance(machine *actuators.MachineScope, bootstrapToken
+ 		Role:        aws.String(machine.Role()),
+ 	})
+ 
++	var err error
+ 	// Pick image from the machine configuration, or use a default one.
+ 	if machine.MachineConfig.AMI.ID != nil {
+ 		input.ImageID = *machine.MachineConfig.AMI.ID
+ 	} else {
+-		input.ImageID = s.defaultAMILookup(machine.Region())
++		input.ImageID, err = s.defaultAMILookup(""ubuntu"", ""18.04"", machine.Machine.Spec.Versions.Kubelet)
++		if err != nil {
++			return nil, err
++		}
+ 	}
+ 
+ 	// Pick subnet from the machine configuration, or default to the first private available.","This looks fine as a first approach, and can we put a TODO here about ubuntu 18.04 being hardcoded?",I think this should be `18.04.0`
+3596,"@@ -1,5 +1,6 @@
++#ifdef USE_OPENCV
+ #include <opencv2/core/core.hpp>
+-
++#endif  // USE_OPENCV
+ #include <stdint.h>
+ 
+ #include <string>",This isn't strictly needed since lmdb / leveldb data that is unencoded does not require OpenCV IO. I think `DataLayer` should only require lmdb / leveldb. If one tries to use encoded data without OpenCV the `DataTransformer` guards will report the dependency failure.,Why is this needed?
+3597,"@@ -30,7 +30,7 @@ func (r *ReconcileHiveConfig) deployHiveAPI(hLog log.FieldLogger, h *resource.He
+ 
+ 	err := util.ApplyAsset(h, ""config/apiserver/hiveapi-cluster-role-binding.yaml"", hLog)
+ 	if err != nil {
+-		return err
++		hLog.WithError(err).Error(""unable to apply hiveapi cluster role binding"")
+ 	}
+ 
+ 	err = util.ApplyAsset(h, ""config/apiserver/service.yaml"", hLog)",Should we take out this change? This was only in there to try to brute force the start of the apiserver yesterday.,Why not return the 
+3598,"@@ -33,6 +33,7 @@ class Proposal < ActiveRecord::Base
+   has_many :steps
+   has_many :individual_steps, ->{ individual }, class_name: 'Steps::Individual'
+   has_many :approvers, through: :individual_steps, source: :user
++  has_many :completers, through: :individual_steps, source: :completer
+   has_many :api_tokens, through: :individual_steps
+   has_many :attachments, dependent: :destroy
+   has_many :approval_delegates, through: :approvers, source: :outgoing_delegations","I worry that this association name is a bit confusing. Yoz was asking me about the concept of completion yesterday, which is why I think of it. It wasn't clear to him exactly what it was. what about calling this a `step_completer` ? we know that a proposal has many steps, so I think that might be clearer. in the future, we also might want the rename the `approver` relation because a step is not always an approval these days.",has_many :completer
+3599,"@@ -11,7 +11,6 @@ namespace AutoRest.Swagger.Validation
+     public class OperationParametersValidation : TypedRule<SwaggerParameter>
+     {
+         private const string SubscriptionId = ""subscriptionid"";
+-        private const string ApiVersion = ""api-version"";
+ 
+         /// <summary>
+         /// Id of the Rule.",Just add a to-do saying we need to add api-version in the check some time in the future when we enable the single-swagger spec mode for validation.,Why was this remove
+3600,"@@ -77,6 +77,8 @@ class Thelia extends Kernel
+         );
+         $serviceContainer = Propel::getServiceContainer();
+         $serviceContainer->setAdapterClass('thelia', 'mysql');
++        $serviceContainer->setDefaultDatasource('thelia');
++
+         $manager = new ConnectionManagerSingle();
+         $manager->setConfiguration($definePropel->getConfig());
+         $serviceContainer->setConnectionManager('thelia', $manager);","@lunika Please see this. It allows us to do `Propel::getConnection()` easily, as we have only one database.",Why is this needed?
+3601,"@@ -92,7 +92,9 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+             var controllerContext = (IHttpControllerContext)state.State;
+ 
+             // some fields aren't set till after execution, so populate anything missing
+-            AspNetWebApi2Integration.UpdateSpan(controllerContext, scope.Span, (AspNetTags)scope.Span.Tags, Enumerable.Empty<KeyValuePair<string, string>>());
++            var span = scope.Span as IHasTags;
++            var aspNetTags = span.Tags as AspNetTags;
++            AspNetWebApi2Integration.UpdateSpan(controllerContext, scope.Span, aspNetTags, Enumerable.Empty<KeyValuePair<string, string>>());
+ 
+             if (exception != null)
+             {",Not related to this particular cast but I wonder if we shouldn't have a cast helper that would log if null to gain visibility.,Why do we need this
+3602,"@@ -2,7 +2,8 @@ const request = require('request')
+ // @ts-ignore
+ const purest = require('purest')({ request })
+ const logger = require('../logger')
+-
++const DRIVE_FILE_FIELDS = 'kind,id,name,mimeType,ownedByMe,permissions(role,emailAddress),size,modifiedTime,iconLink,thumbnailLink'
++const DRIVE_FILES_FIELDS = `kind,nextPageToken,incompleteSearch,files(${DRIVE_FILE_FIELDS})`
+ /**
+  * @class
+  * @implements {Provider}",why do we need to explicitly declare these fields?,I don't think we ne
+3603,"@@ -99,12 +99,8 @@ class OaiController extends AbstractBase
+                 $this->getRequest()->getQuery()->toArray(),
+                 $this->getRequest()->getPost()->toArray()
+             );
+-            $server = new $serverClass(
+-                $this->serviceLocator->get('VuFind\Search\Results\PluginManager'),
+-                $this->serviceLocator->get('VuFind\Record\Loader'),
+-                $this->serviceLocator->get('VuFind\Db\Table\PluginManager'),
+-                $config, $baseURL, $params
+-            );
++            $server = $this->serviceLocator->get('VuFind\OAI\Server');
++            $server->init($config, $baseURL, $params);
+             $server->setRecordLinkHelper(
+                 $this->getViewRenderer()->plugin('recordLink')
+             );","Note that there are multiple OAI servers -- that's why `$serverClass` is a variable here. You'll want to fetch `$serverClass` from the service manager rather than a hard-coded value, and also set up a module.config.php for the authority record version, `VuFind\OAI\Server\Auth`. Should be easy enough since it can share the same factory.",`$serverClass` is n
+3604,"@@ -265,6 +265,12 @@ describe Beaker do
+   context ""validate_host"" do
+     subject { dummy_class.new }
+ 
++    before(:each) do
++      # Must reset additional_pkgs between each test as it hangs around
++      #Beaker::HostPrebuiltSteps.class_variable_set(:@@additional_pkgs, [])
++      Beaker::HostPrebuiltSteps.module_eval(%q{@@additional_pkgs = []})
++    end
++
+     it ""can validate unix hosts"" do
+ 
+       hosts.each do |host|",This is no longer needed and should be removed.,Should this be removed?
+3605,"@@ -57,8 +57,12 @@ func ParseFlags(ctx *cli.Context) service.Options {
+ }
+ 
+ // ParseJSONOptions function fills in Openvpn options from JSON request
+-func ParseJSONOptions(request json.RawMessage) (service.Options, error) {
++func ParseJSONOptions(request *json.RawMessage) (service.Options, error) {
++	if request == nil {
++		return Options{}, nil
++	}
++
+ 	var opts Options
+-	err := json.Unmarshal(request, &opts)
++	err := json.Unmarshal(*request, &opts)
+ 	return opts, err
+ }","could use named return params here to avoid declaring the opts, and using naked returns instead.",Why do we need this che
+3606,"@@ -84,6 +84,11 @@ module.exports = class Instagram extends Plugin {
+   }
+ 
+   getItemIcon (item) {
++    if (!item.images) {
++      return <svg viewBox=""0 0 58 58"" opacity=""0.6"">
++        <path d=""M36.537 28.156l-11-7a1.005 1.005 0 0 0-1.02-.033C24.2 21.3 24 21.635 24 22v14a1 1 0 0 0 1.537.844l11-7a1.002 1.002 0 0 0 0-1.688zM26 34.18V23.82L34.137 29 26 34.18z"" /><path d=""M57 6H1a1 1 0 0 0-1 1v44a1 1 0 0 0 1 1h56a1 1 0 0 0 1-1V7a1 1 0 0 0-1-1zM10 28H2v-9h8v9zm-8 2h8v9H2v-9zm10 10V8h34v42H12V40zm44-12h-8v-9h8v9zm-8 2h8v9h-8v-9zm8-22v9h-8V8h8zM2 8h8v9H2V8zm0 42v-9h8v9H2zm54 0h-8v-9h8v9z"" />
++      </svg>
++    }
+     return <img src={item.images.thumbnail.url} />
+   }
+ ","this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case.",I think this should be 
+3607,"@@ -58,12 +58,14 @@ type syncChainSelector interface {
+ 	// IsHeaver returns true if tipset a is heavier than tipset b and false if
+ 	// tipset b is heavier than tipset a.
+ 	IsHeavier(ctx context.Context, a, b types.TipSet, aStateID, bStateID cid.Cid) (bool, error)
++	// NewWeight returns the weight of a tipset
++	NewWeight(ctx context.Context, ts types.TipSet, stRoot cid.Cid) (uint64, error)
+ }
+ 
+ type syncStateEvaluator interface {
+ 	// RunStateTransition returns the state root CID resulting from applying the input ts to the
+ 	// prior `stateRoot`.  It returns an error if the transition is invalid.
+-	RunStateTransition(ctx context.Context, ts types.TipSet, tsMessages [][]*types.SignedMessage, tsReceipts [][]*types.MessageReceipt, ancestors []types.TipSet, stateID cid.Cid) (cid.Cid, error)
++	RunStateTransition(ctx context.Context, ts types.TipSet, tsMessages [][]*types.SignedMessage, tsReceipts [][]*types.MessageReceipt, ancestors []types.TipSet, parentWeight uint64, stateID cid.Cid) (cid.Cid, error)
+ }
+ 
+ // Syncer updates its chain.Store according to the methods of its","""... after protocol version 1""?",`parentWeight` is unuse
+3608,"@@ -32,7 +32,7 @@ from scapy.compat import (
+ _mib_re_integer = re.compile(r""^[0-9]+$"")
+ _mib_re_both = re.compile(r""^([a-zA-Z_][a-zA-Z0-9_-]*)\(([0-9]+)\)$"")
+ _mib_re_oiddecl = re.compile(
+-    r""$\s*([a-zA-Z0-9_-]+)\s+OBJECT([^:\{\}]|\{[^:]+\})+::=\s*\{([^\}]+)\}"", re.M)
++    r""$\s*([a-zA-Z0-9_-]+)\s+OBJECT[^:\{\}]+::=\s*\{([^\}]+)\}"", re.M)
+ _mib_re_strings = re.compile(r'""[^""]*""')
+ _mib_re_comments = re.compile(r'--.*(\r|\n)')
+ ",Is there a unit test that covers this regexp? I am afraid that changing it might break things =/,I don't think this change is needed.
+3609,"@@ -57,7 +57,7 @@ public class RubyNameFormatter implements NameFormatter {
+ 
+   @Override
+   public String varReference(Name name) {
+-    return ""@"" + name.toLowerUnderscore();
++    return name.toLowerUnderscore();
+   }
+ 
+   @Override","This change is okay IMO because an `@` variable in Ruby is not a reference -- `@` variables are instance variables. Also, it's never used by the Ruby transformers.",Why did you change this?
+3610,"@@ -27,9 +27,9 @@ class PaymentImageUploadCest
+         $me->amOnPage('/admin/payment/edit/1');
+         $entityEditPage->uploadTestImage(self::IMAGE_UPLOAD_FIELD_ID, self::TEST_IMAGE_NAME);
+         $me->clickByName(self::SAVE_BUTTON_NAME);
+-        $me->seeTranslationAdmin('Payment <strong><a href=""{{ url }}"">%name%</a></strong> modified', 'messages', [
++        $me->seeTranslationAdmin('Payment <strong><a href=""{{ url }}"">{{ name }}</a></strong> modified', 'messages', [
+             '{{ url }}' => '',
+-            '%name%' => t('Credit card', [], 'dataFixtures', $me->getAdminLocale()),
++            '{{ name }}' => t('Credit card', [], 'dataFixtures', $me->getAdminLocale()),
+         ]);
+     }
+ }",Why this change was needed? Because in `po` files it's with curly braces?,Shouldn't it be `{{ name }}`?
+3611,"@@ -370,14 +370,14 @@ patch_branch(dr_isa_mode_t isa_mode, cache_pc branch_pc, cache_pc target_pc,
+     ASSERT(ALIGNED(branch_pc, 4) && ALIGNED(target_pc, 4));
+     if ((enc & 0xfc000000) == 0x14000000) { /* B */
+         ASSERT(off + 0x8000000 < 0x10000000);
+-        *pc_writable = (0x14000000 | (0x03ffffff & off >> 2));
++        *pc_writable = (0x14000000 | (0x03ffffff & (off >> 2)));
+     } else if ((enc & 0xff000010) == 0x54000000 ||
+                (enc & 0x7e000000) == 0x34000000) { /* B.cond, CBNZ, CBZ */
+-        ASSERT(off + 0x40000 < 0x80000);
+-        *pc_writable = (enc & 0xff00001f) | (0x00ffffe0 & off >> 2 << 5);
++        ASSERT(off + 0x100000 < 0x200000);
++        *pc_writable = (enc & 0xff00001f) | (0x00ffffe0 & (off >> 2 << 5));
+     } else if ((enc & 0x7e000000) == 0x36000000) { /* TBNZ, TBZ */
+-        ASSERT(off + 0x2000 < 0x4000);
+-        *pc_writable = (enc & 0xfff8001f) | (0x0007ffe0 & off >> 2 << 5);
++        ASSERT(off + 0x8000 < 0x10000);
++        *pc_writable = (enc & 0xfff8001f) | (0x0007ffe0 & (off >> 2 << 5));
+     } else
+         ASSERT(false);
+     if (hot_patch)","Wait -- where did this change come from? This seems unrelated to trace building and seems like it could affect basic execution, unlike the rest of this PR which is all under the off-by-default trace option. Please separate this into its own PR and probably ask @AssadHashmi to review.",Why was this changed?
+3612,"@@ -0,0 +1,3 @@
++module.exports = {
++  presets: [require.resolve('@docusaurus/core/lib/babel/preset')],
++};",seems to be redundant (mention `docusaurus`   ),
+3613,"@@ -206,6 +206,12 @@ public interface Table {
+    */
+   Rollback rollback();
+ 
++  /**
++   *
++   * @return
++   */
++  CherryPick cherrypick();
++
+   /**
+    * Create a new {@link Transaction transaction API} to commit multiple table operations at once.
+    *","Can we combine this with the Rollback API? We could still support the `rollback` method here, but combine `Rollback` and `CherryPick` into something like `ManageSnapshots`. Then we could reuse logic for enforcing checks of the current snapshot. What do you think?",W
+3614,"@@ -52,7 +52,7 @@ static struct internal_amazon_batch_amazon_ids{
+ 	char* aws_secret_access_key;
+ 	char* aws_region;
+ 	char* aws_email;
+-	char* master_env_prefix;
++	char* manager_env_prefix;
+ }initialized_data;
+ 
+ static unsigned int gen_guid(){","Maybe just `env_prefix`, I don't think this is referring to the WQ manager.",W
+3615,"@@ -11,7 +11,6 @@ import android.widget.FrameLayout;
+ 
+ import com.bytehamster.lib.preferencesearch.SearchPreferenceResult;
+ import com.bytehamster.lib.preferencesearch.SearchPreferenceResultListener;
+-
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.core.preferences.UserPreferences;
+ import de.danoeh.antennapod.fragment.preferences.AutoDownloadPreferencesFragment;",Unrelated line change :),W
+3616,"@@ -2,9 +2,13 @@ package net
+ 
+ import (
+ 	""strings""
++	""syscall""
++	""time""
+ 
+ 	""github.com/coreos/go-iptables/iptables""
+ 	""github.com/pkg/errors""
++	""github.com/sirupsen/logrus""
++	utilwait ""k8s.io/apimachinery/pkg/util/wait""
+ )
+ 
+ // AddChainWithRules creates a chain and appends given rules to it.","I raised an eyebrow at making `net` depend on `k8s.io`, but it seems we're already doing that.",nit: remove empty line
+3617,"@@ -228,6 +228,9 @@
+         * @returns {string} encode string
+         */
+         countlyCommon.encodeSomeHtml = function(html, options) {
++            if (countlyGlobal.company) {
++                html.replace(""Countly"", countlyGlobal.company);
++            }
+             if (options) {
+                 return filterXSS(html, options);
+             }","I think ticket meant, not applying replacement in this method, but rather applying encodeSomeHtml to each and every localization string",Why do we need this?
+3618,"@@ -207,7 +207,9 @@ function isNodeShuttingDownError(err) {
+  * @param {Server} server
+  */
+ function isSDAMUnrecoverableError(error, server) {
+-  if (error instanceof MongoParseError) {
++  // NOTE: null check is here for a strictly pre-CMAP world, a timeout or
++  //       close event are considered unrecoverable
++  if (error instanceof MongoParseError || error == null) {
+     return true;
+   }
+ ",ticket for the 4.0 epic?,I don't think we need 
+3619,"@@ -87,6 +87,10 @@ def main():
+     if cfg.get('cudnn_benchmark', False):
+         torch.backends.cudnn.benchmark = True
+     cfg.model.pretrained = None
++    if cfg.model.get('neck', False):
++        if cfg.model.neck.get('rfp_backbone', False):
++            if cfg.model.neck.rfp_backbone.get('pretrained', False):
++                cfg.model.neck.rfp_backbone.pretrained = None
+     cfg.data.test.test_mode = True
+ 
+     # init distributed env first, since logger depends on the dist info.","`cfg.model.get('neck')` will return None if neck does not exist, thus we can omit the default value.",Why do we need this?
+3620,"@@ -5,7 +5,7 @@ module Blacklight
+   module Facet
+ 
+     def facet_paginator field_config, display_facet
+-      Blacklight::Solr::FacetPaginator.new(display_facet.items, 
++      blacklight_config.facet_paginator_class.new(display_facet.items, 
+         sort: display_facet.sort,
+         offset: display_facet.offset,     
+         limit: facet_limit_for(field_config.key))",Trailing whitespace detected.,Style/MutableConstant: Freeze mutable objects assigned to constants.
+3621,"@@ -38,6 +38,7 @@ type TargetSpec struct {
+ 	AutoStackSize    *bool    `json:""automatic-stack-size""` // Determine stack size automatically at compile time.
+ 	DefaultStackSize uint64   `json:""default-stack-size""`   // Default stack size if the size couldn't be determined at compile time.
+ 	CFlags           []string `json:""cflags""`
++	CXXFlags         []string `json:""cxxflags""`
+ 	LDFlags          []string `json:""ldflags""`
+ 	LinkerScript     string   `json:""linkerscript""`
+ 	ExtraFiles       []string `json:""extra-files""`",I don't see why a `cxxflags` key is necessary? C flags are important in the target file because they define things like the float ABI. But these flags are also used for C++. I can't think of a reason why you would want to configure C++ flags in a target file.,Should this be `cxxflags`?
+3622,"@@ -352,12 +352,13 @@ instrument_annotation(dcontext_t *dcontext, IN OUT app_pc *start_pc,
+ #    endif
+ 
+     instr_init(dcontext, &scratch);
+-    TRY_EXCEPT(my_dcontext, { identify_annotation(dcontext, &layout, &scratch); },
+-               { /* EXCEPT */
+-                 LOG(THREAD, LOG_ANNOTATIONS, 2,
+-                     ""Failed to instrument annotation at "" PFX ""\n"", *start_pc);
+-                 /* layout.type is already ANNOTATION_TYPE_NONE */
+-               });
++    TRY_EXCEPT(
++        my_dcontext, { identify_annotation(dcontext, &layout, &scratch); },
++        { /* EXCEPT */
++          LOG(THREAD, LOG_ANNOTATIONS, 2, ""Failed to instrument annotation at "" PFX ""\n"",
++              *start_pc);
++          /* layout.type is already ANNOTATION_TYPE_NONE */
++        });
+     if (layout.type != ANNOTATION_TYPE_NONE) {
+         LOG(GLOBAL, LOG_ANNOTATIONS, 2,
+             ""Decoded %s annotation %s. Next pc now "" PFX "".\n"",","Update year range in Copyright notice, and elsewhere too.",Why did you change this?
+3623,"@@ -179,10 +179,10 @@ type ACMEIssuerDNS01ProviderCloudflare struct {
+ // ACMEIssuerDNS01ProviderRoute53 is a structure containing the Route 53
+ // configuration for AWS
+ type ACMEIssuerDNS01ProviderRoute53 struct {
+-	AccessKeyID     string            `json:""accessKeyID""`
+-	SecretAccessKey SecretKeySelector `json:""secretAccessKeySecretRef""`
+-	HostedZoneID    string            `json:""hostedZoneID""`
+-	Region          string            `json:""region""`
++	AccessKeyIDRef     SecretKeySelector `json:""accessKeyIDSecretRef""`
++	SecretAccessKeyRef SecretKeySelector `json:""secretAccessKeySecretRef""`
++	HostedZoneID       string            `json:""hostedZoneID""`
++	Region             string            `json:""region""`
+ }
+ 
+ // ACMEIssuerDNS01ProviderAzureDNS is a structure containing the","Can we update this PR to not be a breaking change? i.e. if a user specifies `accessKeyID`, it is still used. But if a user specifies `accessKeyIDSecretRef`, it takes precedence?",Why is this a pointer? Isn't it a string?
+3624,"@@ -36,7 +36,7 @@ class UsersController < ApplicationController
+   def save
+     @title = t ""users.new.title""
+ 
+-    if params[:decline]
++    if params[:decline] || !params[:read_tou] || params[:read_tou] == ""0""
+       if current_user
+         current_user.terms_seen = true
+ ","You don't actually need both tests here as ""truthiness"" means that `""0""` is false and hence the first test will be true...",Use 2 (not 0) spaces for indentation.
+3625,"@@ -39,7 +39,15 @@ feature 'User downgrades subscription', js: true do
+ 
+     click_button I18n.t('subscriptions.confirm_cancel')
+ 
+-    expect(page).to have_content ""Scheduled for cancellation on February 19, 2013""
+     expect(page).to have_content I18n.t('subscriptions.flashes.cancel.success')
++
++    click_link I18n.t('subscriptions.reject_refund')
++
++    expect(page).to have_content(
++      I18n.t(
++        'subscriptions.cancellation_scheduled_on',
++        date: 'February 19, 2013'
++      )
++    )
+   end
+ end",Everything else in here is using `I18n`. Should we do that here to be consistent?,I don't think you need the `date: 'Fe
+3626,"@@ -242,8 +242,8 @@ type Config struct {
+ 	PrometheusGoMetricsEnabled      bool   `config:""bool;true""`
+ 	PrometheusProcessMetricsEnabled bool   `config:""bool;true""`
+ 
+-	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;tcp:22,udp:68,tcp:179,tcp:2379,tcp:2380,tcp:5473,tcp:6443,tcp:6666,tcp:6667;die-on-fail""`
+-	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:5473,tcp:6443,tcp:6666,tcp:6667;die-on-fail""`
++	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;0.0.0.0/0:tcp:22,0.0.0.0/0:udp:68,0.0.0.0/0:tcp:179,0.0.0.0/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail""`
++	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;0.0.0.0/0:udp:53,0.0.0.0/0:udp:67,0.0.0.0/0:tcp:179,0.0.0.0/0:tcp:2379,0.0.0.0/0:tcp:2380,0.0.0.0/0:tcp:5473,0.0.0.0/0:tcp:6443,0.0.0.0/0:tcp:6666,0.0.0.0/0:tcp:6667;die-on-fail""`
+ 
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
+ 	NATPortRange       numorstring.Port   `config:""portrange;""`",What do you think about changing the ordering to be `<protocol>:<cidr>:<port>`? I think it matches the most with what we previously had so that it doesn't change too much for our users.,Why is this change needed?
+3627,"@@ -442,9 +442,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule,
+       if (rootedAtAtom == -1) {
+         rootedAtAtom = std::rand() % mol.getNumAtoms();
+         // need to find an atom id between 0 and mol.getNumAtoms() exclusively
+-        PRECONDITION(rootedAtAtom < 0 || static_cast<unsigned int>(
+-                                             rootedAtAtom) < mol.getNumAtoms(),
+-                     ""rootedAtomAtom must be less than the number of atoms"");
++        PRECONDITION(
++            static_cast<unsigned int>(rootedAtAtom) < mol.getNumAtoms(),
++            ""rootedAtomAtom must be less than the number of atoms"");
+       }
+     }
+ ",I'm fairly sure this precondition is always true due to the mod (%),Why did you remove the < 0 check?
+3628,"@@ -404,7 +404,7 @@ final class ReaderPool implements Closeable {
+   private boolean noDups() {
+     Set<String> seen = new HashSet<>();
+     for(SegmentCommitInfo info : readerMap.keySet()) {
+-      assert !seen.contains(info.info.name);
++      assert !seen.contains(info.info.name) : ""seen twice: "" + info.info.name ;
+       seen.add(info.info.name);
+     }
+     return true;","I love seeing diffs like this one, adding a `String` message to an otherwise cryptic `assert`! It makes me realize you must have had a hellacious debugging session!",nit: space after `:`
+3629,"@@ -731,6 +731,8 @@ func loadConfigFromFile(configFile string) (c Local, err error) {
+ 	}
+ 
+ 	// Migrate in case defaults were changed
++	// If a config file does not have version, it is assumed to be zero.
++	// All fields listed in migrate() might be changed if an actual value matches to default value from a previous version.
+ 	c, err = migrate(c)
+ 	return
+ }",1. No logger exists to produce a message 2. Can't assume the latest version because missed version means 0.,// If a config file 
+3630,"@@ -633,6 +633,14 @@ class Config
+         return $config;
+     }
+ 
++    /**
++     * Computes the hash to use for a cache folder from CLI flags and from the config file's xml contents
++     */
++    public function computeHash(): string
++    {
++        return sha1($this->hash . ':' . $this->level);
++    }
++
+     /**
+      * Creates a new config object from an XML string
+      * @param  string|null      $current_dir Current working directory, if different to $base_dir",I saw a wrong reuse of the cache between a partial analysis of a single file and a full run where errors due to lack of context on the first partial run was reported on the full run. Shouldn't we use a hash that is composer.lock + psalm.xml + command line to be safe?,Why do we need this 
+3631,"@@ -3077,14 +3077,12 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         2018-04-09 00:00:00  1
+         2018-04-12 01:00:00  4
+         """"""
+-        from databricks.koalas.indexes import DatetimeIndex
+-
+         axis = validate_axis(axis)
+ 
+         if axis != 0:
+             raise NotImplementedError(""between_time currently only works for axis=0"")
+ 
+-        if not isinstance(self.index, DatetimeIndex):
++        if not isinstance(self.index, ks.DatetimeIndex):
+             raise TypeError(""Index must be DatetimeIndex"")
+ 
+         kdf = self.copy()",Could you also update it in `at_time`?,This should be `self
+3632,"@@ -143,8 +143,9 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+       } catch (IOException ioe) {
+         LOG.warn(""Failed to get Hadoop Filesystem"", ioe);
+       }
++      Boolean localityFallback = LOCALITY_WHITELIST_FS.contains(scheme);
+       this.localityPreferred = options.get(""locality"").map(Boolean::parseBoolean)
+-          .orElse(LOCALITY_WHITELIST_FS.contains(scheme));
++          .orElse(localityFallback);
+     } else {
+       this.localityPreferred = false;
+     }",Because schema is non-final we can't just switch this to a lambda,Why do we need this change?
+3633,"@@ -136,7 +136,7 @@ namespace NLog.Conditions
+             }
+             catch (Exception exception)
+             {
+-                if (exception.MustBeRethrown())
++                if (exception.MustBeRethrown(""While resolving function '{0}' follwing exception occured: {1}"", functionName, exception))
+                 {
+                     throw;
+                 }",proposal: **always** add the exception to the end of the message. So no need to to pass exception twice (implicit and explicit). Need a lot of changes.,nit: `follwing` -> `occurre
+3634,"@@ -41,9 +41,14 @@ public class InvocationStartProcessingEventListener implements EventListener {
+   public void process(Event data) {
+     InvocationStartProcessingEvent event = (InvocationStartProcessingEvent) data;
+     InvocationMonitor monitor = registryMonitor.getInvocationMonitor(event.getOperationName());
++    //TODO:current java chassis unable know invocation type before starting process,so all type WaitInQueue increment(-1) (decrement)
+     monitor.getWaitInQueue().increment(-1);
++    monitor.setInvocationMonitorType(event.getInvocationType());
+     if (InvocationType.PRODUCER.equals(event.getInvocationType())) {
+       monitor.getLifeTimeInQueue().update(event.getInQueueNanoTime());
++      monitor.getProducerCall().increment();
++    } else {
++      monitor.getConsumerCall().increment();
+     }
+   }
+ }",why? event.getInvocationType is not you want?,Why do we need to set the i
+3635,"@@ -29,6 +29,7 @@ import (
+ type Info struct {
+ 	ID                string   `json:""server_id""`
+ 	Version           string   `json:""version""`
++	GitHash           string   `json:""git_hash""`
+ 	GoVersion         string   `json:""go""`
+ 	Host              string   `json:""host""`
+ 	Port              int      `json:""port""`",nit: how about `GitSHA`?,Why do we need this?
+3636,"@@ -93,6 +93,7 @@ an example.
+ */
+ 
+ #define MAX_REMOTE_JOBS_DEFAULT 100
++#define FAIL_DIR ""makeflow.failed.%d""
+ 
+ static sig_atomic_t makeflow_abort_flag = 0;
+ static int makeflow_failed_flag = 0;","If you move the other functions, this should also be moved to `makeflow_gc.h`.",#define MAX_REMOTE_JOBS_DEFAULT 100
+3637,"@@ -55,8 +55,12 @@ def _send_listens_to_queue(listen_type, listens):
+     for listen in listens:
+         if listen_type == LISTEN_TYPE_PLAYING_NOW:
+             try:
+-                expire_time = listen[""track_metadata""][""additional_info""].get(""duration"",
+-                                    current_app.config['PLAYING_NOW_MAX_DURATION'])
++                if 'duration' in listen['track_metadata']['additional_info']:
++                    expire_time = listen['track_metadata']['additional_info']['duration']
++                elif 'duration_ms' in listen['track_metadata']['additional_info']:
++                    expire_time = listen['track_metadata']['additional_info']['duration_ms'] // 1000
++                else:
++                    expire_time = current_app.config['PLAYING_NOW_MAX_DURATION']
+                 redis_connection._redis.put_playing_now(listen['user_id'], listen, expire_time)
+             except Exception as e:
+                 current_app.logger.error(""Redis rpush playing_now write error: "" + str(e))","This whole block bugs me. Expire_time to me suggest that an absolute time of when something happens and duration is an interval of time. While the code looks correct, it feels awkward to read.",line too long (81 > 79 characters)
+3638,"@@ -93,7 +93,9 @@ export function coerceToVNode(possibleVNode) {
+ 
+ 	// Clone vnode if it has already been used. ceviche/#57
+ 	if (possibleVNode._dom!=null) {
+-		return createVNode(possibleVNode.type, possibleVNode.props, possibleVNode.text, possibleVNode.key, null);
++		let vnode = createVNode(possibleVNode.type, possibleVNode.props, possibleVNode.text, possibleVNode.key, null);
++		vnode._dom = possibleVNode._dom;
++		return vnode;
+ 	}
+ 
+ 	return possibleVNode;",Can we add `_dom` as an argument to createVNode here? I think it might be shorter (could totally be wrong!),Why do we need this?
+3639,"@@ -1964,6 +1964,8 @@ mangle_return(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+             instr_set_src(popf, 1, memop);
+             PRE(ilist, instr, popf);
+         }
++        /* Mangles single step exception after a popf. */
++        mangle_single_step(dcontext, ilist, popf);
+ 
+ #ifdef X64
+         /* In x64 mode, iret additionally does pop->RSP and pop->ss. */",I think that the iret handling is not yet good.,I don't think this is the right pla
+3640,"@@ -78,7 +78,7 @@ const DeviceSizeTabBar = ( {
+ 						{ icon }
+ 					</Tab>
+ 				);
+-			}
++			},
+ 			) }
+ 		</TabBar>
+ 	);","Huh, that's kinda weird. I get it, but it's unexpected to me...",Why is this change needed?
+3641,"@@ -172,15 +172,6 @@ func (t *Tag) Done(s State) bool {
+ 	return err == nil && n == total
+ }
+ 
+-// DoneSplit sets total count to SPLIT count and sets the associated swarm hash for this tag
+-// is meant to be called when splitter finishes for input streams of unknown size
+-func (t *Tag) DoneSplit(address swarm.Address) int64 {
+-	total := atomic.LoadInt64(&t.Split)
+-	atomic.StoreInt64(&t.Total, total)
+-	t.Address = address
+-	return total
+-}
+-
+ // Status returns the value of state and the total count
+ func (t *Tag) Status(state State) (int64, int64, error) {
+ 	count, seen, total := t.Get(state), atomic.LoadInt64(&t.Seen), atomic.LoadInt64(&t.Total)",why is this removed? it is important when you upload from stream of unknown size,Why was this removed?
+3642,"@@ -3,7 +3,7 @@ class ApiToken < ActiveRecord::Base
+ 
+   before_create :generate_token
+ 
+-  belongs_to :approval
++  belongs_to :approval, class_name: 'Approvals::Individual'
+   has_one :proposal, through: :approval
+   has_one :user, through: :approval
+ ","Out of curiosity, why is this needed? Does it enforce what class can be assigned?",Why is this needed?
+3643,"@@ -174,6 +174,11 @@ func (a *Agent) initEndpoints() error {
+ 		return fmt.Errorf(""Error creating GRPC listener: %s"", err)
+ 	}
+ 
++	if addr.Network() == ""unix"" {
++		// Any process should be able to use this unix socket
++		os.Chmod(addr.String(), os.ModePerm)
++	}
++
+ 	go func() {
+ 		a.config.ErrorCh <- a.grpcServer.Serve(listener)
+ 	}()","non-blocking: Now that we have a handful of statements which deal with creating a listener, it may make sense to introduce a `createListener` method or something similar",Why do we need this?
+3644,"@@ -34,6 +34,8 @@ namespace Nethermind.Mev
+         }
+ 
+         public IBlockProcessor.IBlockTransactionsExecutor Create(ReadOnlyTxProcessingEnv readOnlyTxProcessingEnv) => 
+-            new MevBlockProductionTransactionsExecutor(readOnlyTxProcessingEnv, _specProvider, _logManager);
++            LastExecutor = new MevBlockProductionTransactionsExecutor(readOnlyTxProcessingEnv, _specProvider, _logManager);
++
++        public MevBlockProductionTransactionsExecutor LastExecutor { get; private set; } = null!;
+     }
+ }","factory should be stateless if possible, looks like much complexity added",Why do we need this?
+3645,"@@ -527,6 +527,12 @@ class BigQueryLoadTask(MixinBigQueryBulkComplete, luigi.Task):
+         """"""	Indicates if BigQuery should allow quoted data sections that contain newline characters in a CSV file. The default value is false.""""""
+         return False
+ 
++    @property
++    def project_id(self):
++        """"""Project ID on which to run the BigQuery Job
++        """"""
++        return self.output().table.project_id
++
+     def run(self):
+         output = self.output()
+         assert isinstance(output, BigQueryTarget), 'Output must be a BigQueryTarget, not %s' % (output)",Could you please add short description for the default value as well?,Why do we need this?
+3646,"@@ -744,7 +744,7 @@ func (bc *blockchain) commitBlock(blk *Block) error {
+ 	if bc.sf != nil {
+ 		ExecuteContracts(blk, bc)
+ 		if err := bc.sf.CommitStateChanges(blk.Height(), blk.Transfers, blk.Votes, blk.Executions); err != nil {
+-			return err
++			logger.Fatal().Err(err).Msgf(""Failed to commit state changes on height %d"", blk.Height())
+ 		}
+ 	}
+ 	// write smart contract receipt into DB","Leave a TODO message to say we will fix the log level in the future, once committing the block and the state become a transaction",Why not return the e
+3647,"@@ -107,6 +107,18 @@ public class TableProperties {
+   public static final String DELETE_PARQUET_COMPRESSION_LEVEL = ""write.delete.parquet.compression-level"";
+   public static final String PARQUET_COMPRESSION_LEVEL_DEFAULT = null;
+ 
++  public static final String PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT =
++      ""write.parquet.row-group-check-min-record-count"";
++  public static final String DELETE_PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT =
++      ""write.delete.parquet.row-group-check-min-record-count"";
++  public static final String PARQUET_ROW_GROUP_CHECK_MIN_RECORD_COUNT_DEFAULT = ""100"";
++
++  public static final String PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT =
++      ""write.parquet.row-group-check-max-record-count"";
++  public static final String DELETE_PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT =
++      ""write.delete.parquet.row-group-check-max-record-count"";
++  public static final String PARQUET_ROW_GROUP_CHECK_MAX_RECORD_COUNT_DEFAULT = ""10000"";
++
+   public static final String AVRO_COMPRESSION = ""write.avro.compression-codec"";
+   public static final String DELETE_AVRO_COMPRESSION = ""write.delete.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";",this can be integer,Why do we need this?
+3648,"@@ -69,6 +69,8 @@ class CompletionView(QTreeView):
+                 {{ color['completion.category.border.top'] }};
+             border-bottom: 1px solid
+                 {{ color['completion.category.border.bottom'] }};
++            font: {{ font['completion.category'] }};
++
+         }
+ 
+         QTreeView::item:selected, QTreeView::item:selected:hover {",nitpick: Please remove the blank line here,border-top: 1px solid
+3649,"@@ -4,6 +4,7 @@ class Way < ActiveRecord::Base
+   include ConsistencyValidations
+ 
+   set_table_name 'current_ways'
++  foreign_key 'changeset_id'
+   
+   belongs_to :changeset
+ ",What is this for? The only methods I can see by that name in the rails doc are generating a foreign key name from a model class name but you seem to be giving a key name as argument?,set_table_name 'curre
+3650,"@@ -798,6 +798,12 @@ public class CoreContainer {
+     SecurityConfHandler.SecurityConfig securityConfig = securityConfHandler.getSecurityConfig(false);
+     initializeAuthorizationPlugin((Map<String, Object>) securityConfig.getData().get(""authorization""));
+     initializeAuthenticationPlugin((Map<String, Object>) securityConfig.getData().get(""authentication""));
++    if (authenticationPlugin != null && authenticationPlugin.plugin.getMetricRegistry() == null) {
++      authenticationPlugin.plugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, ""/authentication"");
++    }
++    if (pkiAuthenticationPlugin != null && pkiAuthenticationPlugin.getMetricRegistry() == null) {
++      pkiAuthenticationPlugin.initializeMetrics(metricManager, SolrInfoBean.Group.node.toString(), metricTag, ""/authentication/pki"");
++    }
+   }
+ 
+   private static void checkForDuplicateCoreNames(List<CoreDescriptor> cds) {","Is this second check necessary? we know that just after the plugin was created its metricRegistry is null, it's set only after `initializeMetrics` has been called.",Shouldn't this be `/a
+3651,"@@ -130,6 +130,16 @@ TalkActionResult_t TalkActions::playerSaySpell(Player* player, SpeakClasses type
+ 			}
+ 		}
+ 
++		if (it->second.fromLua) {
++			if (it->second.getNeedAccess() && !player->getGroup()->access) {
++				return TALKACTION_CONTINUE;
++			}
++
++			if (player->getAccountType() < it->second.getRequiredAccountType()) {
++				return TALKACTION_BREAK;
++			}
++		}
++
+ 		if (it->second.executeSay(player, words, param, type)) {
+ 			return TALKACTION_CONTINUE;
+ 		} else {",shouldn't this be `return TALKACTION_BREAK;` as the player does not meet the required group access?,This should be `TALKA
+3652,"@@ -72,6 +72,8 @@ public class CliqueMiningAcceptanceTest extends AcceptanceTestBase {
+     cluster.stopNode(minerNode2);
+     cluster.stopNode(minerNode3);
+     minerNode1.verify(net.awaitPeerCount(0));
++    minerNode1.verify(clique.blockIsCreatedByProposer(minerNode1));
++
+     minerNode1.verify(clique.noNewBlockCreated(minerNode1));
+   }
+ ",does this still work if minerNode1 has already proposed a block before 2 & 3 are stopped?,Why do we need this?
+3653,"@@ -91,6 +91,12 @@ var _ topicreconciler.Interface = (*Reconciler)(nil)
+ func (r *Reconciler) ReconcileKind(ctx context.Context, topic *v1.Topic) reconciler.Event {
+ 	ctx = logging.WithLogger(ctx, r.Logger.With(zap.Any(""topic"", topic)))
+ 
++	if v, present := topic.Annotations[v1.LoggingE2ETestAnnotation]; present {
++		// This is added purely for the TestCloudLogging E2E tests, which verify that the log line
++		// is written if this annotation is present.
++		logging.FromContext(ctx).Desugar().Error(""Adding log line for the TestCloudLogging E2E tests"", zap.String(v1.LoggingE2EFieldName, v))
++	}
++
+ 	topic.Status.InitializeConditions()
+ 	topic.Status.ObservedGeneration = topic.Generation
+ ",I am wondering if we can either make this a feature or have a way to turn it off in production. My concern is that we might be adding more of these kind of code in the future.,I'm not sure if this
+3654,"@@ -960,11 +960,8 @@ class DataFrame(_Frame, Generic[T]):
+         #     sum  12.0  NaN
+         #
+         # Aggregated output is usually pretty much small. So it is fine to directly use pandas API.
+-        pdf = kdf.to_pandas().transpose().reset_index()
+-        pdf = pdf.groupby(['level_1']).apply(
+-            lambda gpdf: gpdf.drop('level_1', 1).set_index('level_0').transpose()
+-        ).reset_index(level=1)
+-        pdf = pdf.drop(columns='level_1')
++        pdf = kdf.to_pandas().stack(level=1)
++        pdf.index = pdf.index.droplevel()
+         pdf.columns.names = [None]
+         pdf.index.names = [None]
+ ",We can just use `.stack()` here? Then I guess we can reuse when supporting multi-index columns.,Why did you change t
+3655,"@@ -14,8 +14,13 @@ namespace Datadog.Trace.ClrProfiler
+         private static readonly Lazy<bool> _enabled = new Lazy<bool>(
+             () =>
+             {
++#if NETSTANDARD2_0
++                // TODO: figure out configuration in .NET Standard 2.0
++                return true;
++#else
+                 string setting = ConfigurationManager.AppSettings[""Datadog.Tracing:Enabled""];
+                 return !string.Equals(setting, bool.FalseString, StringComparison.InvariantCultureIgnoreCase);
++#endif
+             },
+             LazyThreadSafetyMode.PublicationOnly);
+ ","What are the possibilities here? Since we plan on supporting .net standard 2.0 from day 1, we might as well tackle that now.",I think this should 
+3656,"@@ -28,9 +28,9 @@ namespace OpenTelemetry.Metrics
+         /// <summary>
+         /// Adds the given value to the bound counter metric.
+         /// </summary>
+-        /// <param name=""context"">the associated <see cref=""SpanContext""/>.</param>
++        /// <param name=""context"">the associated <see cref=""SpanReference""/>.</param>
+         /// <param name=""value"">value by which the bound counter metric should be added.</param>
+-        public abstract void Add(in SpanContext context, T value);
++        public abstract void Add(in SpanReference context, T value);
+ 
+         /// <summary>
+         /// Adds the given value to the bound counter metric.",should the parameters be called reference or context?,Should this be `SpanReference`?
+3657,"@@ -184,7 +184,7 @@ module Bolt
+ 
+             begin
+               if writable && index < in_buffer.length
+-                to_print = in_buffer[index..-1]
++                to_print = in_buffer.byteslice(index..-1)
+                 written = inp.write_nonblock to_print
+                 index += written
+ ",Do we need to also change `length` here (and below) to `bytesize`? Perhaps we ought to make a copy of `in_buffer` encoded as binary and then the existing algorithm should work.,I think this should be `in_buff
+3658,"@@ -166,6 +166,7 @@ def get_filename_question(*, suggested_filename, url, parent=None):
+     q.title = ""Save file to:""
+     q.text = ""Please enter a location for <b>{}</b>"".format(
+         html.escape(url.toDisplayString()))
++    q.yank_text = url.toString()
+     q.mode = usertypes.PromptMode.download
+     q.completed.connect(q.deleteLater)
+     q.default = _path_suggestion(suggested_filename)",This should be `toDisplayString()` to not contain e.g. passwords.,This should be `q.yank_url`
+3659,"@@ -180,6 +180,10 @@ class <%= controller_name.classify %>Controller < ApplicationController
+     # If there are more than this many search results, no spelling (""did you 
+     # mean"") suggestion is offered.
+     config.spell_max = 5
++
++    # Configuration for autocomplete suggestor
++    config.autocomplete_enabled = true
++    config.autocomplete_path = 'suggest'
+   end
+ 
+ end ",Can we just say that having a non-nil `autocomplete_path` implies that autocomplete is enabled?,Layout/EmptyLinesAroundClassBod
+3660,"@@ -25,7 +25,7 @@ import (
+ 
+ 	""github.com/caddyserver/caddy/v2""
+ 	""github.com/caddyserver/caddy/v2/caddyconfig/caddyfile""
+-	""github.com/gogo/protobuf/proto""
++	""github.com/golang/protobuf/proto""
+ 	""github.com/golang/protobuf/ptypes/timestamp""
+ 	""github.com/google/cel-go/cel""
+ 	""github.com/google/cel-go/checker/decls""","Note that the package github.com/golang/protobuf/proto is deprecated. We're instructed to use the ""google.golang.org/protobuf/proto"" package instead. I didn't want to change it now to avoid intrusive changes whose consequences are, currently, unknown.",Why is this change needed?
+3661,"@@ -4,14 +4,3 @@ get ""/pages/*id"" => ""pages#show"", format: false
+ get ""/subscribe"" => ""promoted_catalogs#show"", as: 'subscribe'
+ get ""/privacy"" => ""pages#show"", as: :privacy, id: 'privacy'
+ get ""/terms"" => ""pages#show"", as: :terms, id: 'terms'
+-
+-get(
+-  ""/group-training"" => ""pages#show"",
+-  as: :group_training,
+-  id: ""group-training""
+-)
+-get(
+-  ""/rubyist-booster-shot"" => ""pages#show"",
+-  as: :rubyist_booster_shot,
+-  id: ""rubyist-booster-shot""
+-)",Are these gone routes? Do we need to 301 them?,Why are we removing these?
+3662,"@@ -18,10 +18,13 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/vmware-tanzu/antrea/pkg/apis/networking/v1beta1""
++	""github.com/vmware-tanzu/antrea/pkg/controller/networkpolicy""
+ 	""io""
+ 	""os""
+ 	""reflect""
+ 	""sort""
++	""strconv""
+ 	""strings""
+ 	""text/tabwriter""
+ ",move them to internal group of imports,nit: remove empty line
+3663,"@@ -124,6 +124,7 @@ func (c *CStorPoolController) cStorPoolEventHandler(operation common.QueueOperat
+ 		status, err := c.getPoolStatus(cStorPoolGot)
+ 		return status, err
+ 	}
++	glog.Errorf(""Please handle cStorPool '%s' event on '%s'"", string(operation), string(cStorPoolGot.ObjectMeta.Name))
+ 	return string(apis.CStorPoolStatusInvalid), nil
+ }
+ ",can we rewrite this as: `ignored event '%s' for cstor pool '%s'`,"glog.Errorf(""Please handle"
+3664,"@@ -4,6 +4,8 @@ module Test
+   end
+ 
+   class ClientRequest < ActiveRecord::Base
++    belongs_to :approving_official, class_name: User
++
+     def self.purchase_amount_column_name
+       :amount
+     end",not all client data types have an approving official (eg: 18F does not). do we still want to include the relation here?,I don't think this belongs to the `User` model
+3665,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+ 
+ 
+   /**",This change should also probably go into the corresponding method of the abstract By class?,Why do we need this change?
+3666,"@@ -127,9 +127,6 @@ module.exports = function(config, auth, storage) {
+       } else {
+         next(HTTPError[err.message ? 401 : 500](err.message));
+       }
+-
+-      let base = Utils.combineBaseUrl(Utils.getWebProtocol(req), req.get('host'), config.url_prefix);
+-      res.redirect(base);
+     });
+   });
+ ",why this remove?,Why was this removed?
+3667,"@@ -54,7 +54,7 @@ type Reader interface {
+ 	Stat(ctx context.Context, path string) (os.FileInfo, error)
+ 
+ 	// Open opens an existing file for reading, as os.Open.
+-	Open(ctx context.Context, path string) (io.ReadCloser, error)
++	Open(ctx context.Context, path string) (FileReader, error)
+ 
+ 	// Glob returns all the paths matching the specified glob pattern, as
+ 	// filepath.Glob.","As the test failures indicate, making this change is going to mean changing everything which currently implements this interface.",Why is this change necessary?
+3668,"@@ -13,7 +13,7 @@ get(
+ get ""/humans-present/oss"" => redirect( ""https://www.youtube.com/watch?v=VMBhumlUP-A"")
+ get ""/ios-on-rails"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+ get ""/ios-on-rails-beta"" => redirect(""https://gumroad.com/l/ios-on-rails"")
+-get ""/live"" => redirect(OfficeHours.url)
++get ""/live"" => redirect(""http://forum.upcase.com"")
+ get ""/pages/tmux"" => redirect(""https://www.youtube.com/watch?v=CKC8Ph-s2F4"")
+ get ""/prime"" => redirect(""/subscribe"")
+ get ""/products/:id/purchases/:lookup"" => redirect(""/purchases/%{lookup}"")",Do we want to redirect this to the forum or something in case people have it linked/bookmarked?,I think this should be `/forum.upcase.com`
+3669,"@@ -21,7 +21,7 @@ export default Component.extend({
+     }),
+ 
+     backgroundStyle: computed('member.{name,email}', function () {
+-        let name = this.member.name || this.member.email;
++        let name = this.member.name || this.member.email || 'NM';
+         if (name) {
+             let color = stringToHslColor(name, 55, 55);
+             return htmlSafe(`background-color: ${color}`);","@peterzimon came up with this 'NM' piece as a placeholder for New Member initials, without this the screen looks broken. It changes to normal initials calculation once email or name is entered. Lmk if you'd like to put something different here ;)",Why do we need this change?
+3670,"@@ -4,5 +4,6 @@ import attr from 'ember-data/attr';
+ export default DS.Model.extend({
+     name: attr('string'),
+     email: attr('string'),
+-    createdAt: attr('moment-utc')
++    createdAt: attr('moment-utc'),
++    subscriptions: attr('member-subscription')
+ });",@kevinansfield Would be cool if you can take a   if this is the best way to add `subscriptions` info on member model. This uses the transform + separate model definition way which seemed to be the right way from other references in Admin  ,I think this should be `memberSubscription
+3671,"@@ -31,10 +31,12 @@ try:
+   import matplotlib.pyplot as plt
+   import matplotlib.cm as cm
+ except ImportError:
+-  # Suppress; we log it at debug level to avoid polluting the logs of apps
+-  # and services that don't care about plotting
+-  logging.debug(""Cannot import matplotlib. Plot class will not work."",
+-                exc_info=True)
++  # Suppress this optional dependency on matplotlib. NOTE we don't log this,
++  # because python logging implicitly adds the StreamHandler to root logger when
++  # calling `logging.debug`, etc., which may undermine an application's logging
++  # configuration.
++  plt = None
++  cm = None
+ 
+ 
+ ",This is the common way of dealing with optional dependencies,I don't think this is the right way to do 
+3672,"@@ -67,8 +67,8 @@ func (t testHelper) AvailableEndpoints() *corev1.Endpoints {
+ 	}
+ }
+ 
+-func (t testHelper) ReadyDependencyStatus() *duckv1.KResource {
+-	kr := &duckv1.KResource{}
++func (t testHelper) ReadyDependencyStatus() *duckv1.Source {
++	kr := &duckv1.Source{}
+ 	kr.Status.SetConditions(apis.Conditions{{
+ 		Type:   ""Ready"",
+ 		Status: corev1.ConditionTrue,",nit: we can replace all `kr` in this file with like `src`.,Why is this change needed?
+3673,"@@ -101,7 +101,7 @@ ReadPreference.fromOptions = function(options) {
+   if (typeof readPreference === 'string') {
+     return new ReadPreference(readPreference, readPreferenceTags);
+   } else if (!(readPreference instanceof ReadPreference) && typeof readPreference === 'object') {
+-    const mode = readPreference.mode || readPreference.preference;
++    const mode = readPreference.mode;
+     if (mode && typeof mode === 'string') {
+       return new ReadPreference(mode, readPreference.tags, {
+         maxStalenessSeconds: readPreference.maxStalenessSeconds",same concern here as above,Why is this change needed?
+3674,"@@ -147,7 +147,7 @@ module Mongoid
+       def raw
+         validate_out!
+         cmd = command
+-        opts = { read: cmd.delete(:read) } if cmd[:read]
++        opts = { read: criteria.options.fetch(:read) } if criteria.options[:read]
+         @map_reduce.database.command(cmd, (opts || {}).merge(session: _session)).first
+       end
+       alias :results :raw","Thank you for this, I gather this repairs failures that I've seen in another PR.",Why do we need to fetch `:
+3675,"@@ -159,7 +159,7 @@ abstract class BaseSparkAction<ThisT, R> implements Action<ThisT, R> {
+         .repartition(spark.sessionState().conf().numShufflePartitions()) // avoid adaptive execution combining tasks
+         .as(Encoders.bean(ManifestFileBean.class));
+ 
+-    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF(""file_path"");
++    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF(""file_path"").distinct();
+   }
+ 
+   protected Dataset<Row> buildManifestFileDF(Table table) {","This place probably makes sense to me. We can consider exposing an argument to make the dedup step optional (I am not sure it is a good idea but I want to think this through together). The dedup step we are adding is going to trigger a shuffle. Technically, we are fine in the existing expire snapshots action as it does the dedup in `except`. The question is what kind of performance impact deduplicating here will have. We only have duplicates if multiple manifests reference the same files. In `rewrite_manifests` procedure, we rewrite all manifests, meaning we produce a snapshot with new manifests where entries are old data files. Also, there are updates and deletes that may rewrite manifests. I think deduplicating here makes sense to me in all cases. Thoughts, @rdblue @flyrain @RussellSpitzer @karuppayya?",why do we need to distinct
+3676,"@@ -1516,6 +1516,11 @@ func (c *ClusterManager) NodeRemoveDone(nodeID string, result error) {
+ 			nodeID, err)
+ 		logrus.Errorf(msg)
+ 	}
++
++	// Remove osdconfig data from etcd
++	if err := c.configManager.DeleteNodeConf(nodeID); err != nil {
++		logrus.Warn(""error removing node from osdconfig:"", err)
++	}
+ }
+ 
+ func (c *ClusterManager) replayNodeDecommission() {",can we move the code before deleteNodeFromDB ? this way even if the node crashes after remove config we can still re-run decommission again ?,I think we should log the error here.
+3677,"@@ -6684,7 +6684,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+ 
+         return self._internal.copy(sdf=sdf, data_columns=columns, column_index=idx)
+ 
+-    def melt(self, id_vars=None, value_vars=None, var_name='variable',
++    def melt(self, id_vars=None, value_vars=None, var_name=None,
+              value_name='value'):
+         """"""
+         Unpivot a DataFrame from wide format to long format, optionally",Seems the default value of `melt`'s `var_name` at namespace.py should be changed as well.,I don't think we need this change.
+3678,"@@ -608,6 +608,17 @@ def test_query_parser_path_params_with_slashes():
+     assert params == {""ResourceArn"": resource_arn}
+ 
+ 
++def test_parse_cloudtrail_with_botocore():
++    _botocore_parser_integration_test(
++        service=""cloudtrail"",
++        action=""DescribeTrails"",
++        headers={
++            ""X-Amz-Target"": ""com.amazonaws.cloudtrail.v20131101.CloudTrail_20131101.DescribeTrails""
++        },
++        trailNameList=[""t1""],
++    )
++
++
+ # TODO Add additional tests (or even automate the creation)
+ # - Go to the Boto3 Docs (https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/index.html)
+ # - Look for boto3 request syntax definition for services that use the protocol you want to test","I think botocore's serializer should already create the correct headers. However, they are currently not used in `_botocore_parser_integration_test`(line #217). Maybe we could remove the headers here and just use a fallback in the `_botocore_parser_integration_test` (i.e. use the given headers if they are set, otherwise use the headers generated by botocore's serializer)?",I think we can remove this TODO now.
+3679,"@@ -83,7 +83,7 @@ export default AbstractEditController.extend(ChargeActions, PatientSubmodule, {
+         closeModalOnConfirm: false,
+         confirmAction: 'deleteCharge',
+         title: this.get('i18n').t('procedures.titles.deleteMedicationUsed'),
+-        message: this.get('i18n').t('procedures.messages.deleteMedication'),
++        message: this.get('i18n').t('messages.delete_singular', { name: 'medication' }),
+         chargeToDelete: charge,
+         updateButtonAction: 'confirm',
+         updateButtonText: this.get('i18n').t('buttons.ok')",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,Why do we need to change the name of 
+3680,"@@ -8,12 +8,12 @@ export default class Provider {
+   constructor (opts) {
+     this.opts = opts
+     this.provider = opts.provider
+-    this.id = this.provider
++    this.id = opts.id || this.provider
+     this.name = this.opts.name || _getName(this.id)
+   }
+ 
+   auth () {
+-    return fetch(`${this.opts.host}/${this.provider}/authorize`, {
++    return fetch(`${this.opts.host}/${this.id}/auth`, {
+       method: 'get',
+       credentials: 'include',
+       headers: {","in case you want to rename one of the plugins when instantiating, from options?",Why do we need this change?
+3681,"@@ -22,6 +22,7 @@ from libcodechecker.logger import add_verbose_arguments
+ from libcodechecker.logger import LoggerFactory
+ 
+ LOG = LoggerFactory.get_new_logger('ANALYZE')
++CTU_FUNC_MAP_CMD = 'clang-func-mapping'
+ 
+ 
+ class OrderedCheckersAction(argparse.Action):","This default variable should be moved into a config variable, created by `package_context`, and read from `config\package_layout.json`.",Why is this needed?
+3682,"@@ -202,4 +202,16 @@ describe('Walkontable.ViewportColumnsCalculator', () => {
+     expect(calc.stretchAllColumnsWidth.length).toBe(0);
+     expect(calc.needVerifyLastColumnWidth).toBe(true);
+   });
++
++  it('should calculate the number of columns based on a default width, ' +
++    'when the width returned from the function is not a number', () => {
++    const calc = new Walkontable.ViewportColumnsCalculator(200, 0, 1000, () => (void 0 + 1));
++    expect(calc.startColumn).toBe(0);
++    expect(calc.startPosition).toBe(0);
++    expect(calc.endColumn).toBe(3);
++
++    const visibleCalc = new Walkontable.ViewportColumnsCalculator(200, 0, 1000, () => (void 0 + 1), null, true);
++    expect(visibleCalc.startColumn).toBe(0);
++    expect(visibleCalc.endColumn).toBe(3);
++  });
+ });",Can I ask you to add a new line after `const` assignment? I believe that this increases the code readability by encapsulating assignment and logic (expecting) blocks.,Can you add a check for `ca
+3683,"@@ -313,6 +313,7 @@ void CudaInternal::initialize(int cuda_device_id, cudaStream_t stream) {
+ 
+   enum { WordSize = sizeof(size_type) };
+ 
++#ifndef KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK
+ #ifdef KOKKOS_ENABLE_DEPRECATED_CODE
+   if (!HostSpace::execution_space::is_initialized()) {
+ #else","So the intention is you configure with `-CMAKE_CXX_FLAGS=""-D KOKKOS_IMPL_TURN_OFF_CUDA_HOST_INIT_CHECK""`?",Why do we need this?
+3684,"@@ -396,7 +396,7 @@ void AssignHsResidueInfo(RWMol &mol) {
+           h_label = h_label.substr(3, 1) + h_label.substr(0, 3);
+           AtomPDBResidueInfo *newInfo = new AtomPDBResidueInfo(
+               h_label, max_serial, """", info->getResidueName(),
+-              info->getResidueNumber(), info->getChainId(), """",
++              info->getResidueNumber(), info->getChainId(), """", 1.0, 0.0,
+               info->getIsHeteroAtom());
+           mol.getAtomWithIdx(*begin)->setMonomerInfo(newInfo);
+ ",This was a bug.,why is this change needed?
+3685,"@@ -210,6 +210,19 @@ class ImageExtension extends Twig_Extension
+         $htmlAttributes = $attributes;
+         unset($htmlAttributes['type'], $htmlAttributes['size']);
+ 
++        $useLazyLoading = array_key_exists('lazy', $attributes) ? (bool)$attributes['lazy'] : true;
++        $isAttributeClassExistsAndNotEmpty = array_key_exists('class', $attributes) && $attributes['class'] !== '';
++        $htmlAttributes['class'] = sprintf(
++            '%s%s',
++            $useLazyLoading ? 'lazy' : '',
++            $isAttributeClassExistsAndNotEmpty ? ' ' . $attributes['class'] : ''
++        );
++
++        if ($useLazyLoading) {
++            $htmlAttributes['data-src'] = $htmlAttributes['src'];
++            $htmlAttributes['src'] = '';
++        }
++
+         return $this->templating->render('@ShopsysFramework/Common/image.html.twig', [
+             'attr' => $htmlAttributes,
+             'additionalImagesData' => $additionalImagesData,",Is OK that we don't have some placeholder?,Why do we need this?
+3686,"@@ -447,11 +447,11 @@ func (node *Node) setupStorageMining(ctx context.Context) error {
+ 		PoStProofType: postProofType,
+ 		SealProofType: sealProofType,
+ 		Miner:         minerAddr,
+-		WorkerThreads: 1,
++		WorkerThreads: 2,
+ 		Paths: []fs.PathConfig{
+ 			{
+ 				Path:   sectorDir,
+-				Cache:  false,
++				Cache:  true,
+ 				Weight: 1,
+ 			},
+ 		},",Sectorbuilder behaves differently depending on whether it's given 1 or more threads. It won't seal if only given 1.,Why do we need this change
+3687,"@@ -16,8 +16,11 @@
+ 
+ package azkaban.metrics;
+ 
++import static azkaban.ServiceProvider.SERVICE_PROVIDER;
++
+ import com.codahale.metrics.Meter;
+ import com.codahale.metrics.MetricRegistry;
++import com.google.inject.Inject;
+ import java.util.concurrent.atomic.AtomicLong;
+ 
+ /**",Sort of believe We should put MetricManager in constructor parameter given this case.,Why is this needed?
+3688,"@@ -28,11 +28,13 @@ import org.apache.iceberg.transforms.Transform;
+  */
+ public class PartitionField implements Serializable {
+   private final int sourceId;
++  private final int fieldId;
+   private final String name;
+   private final Transform<?, ?> transform;
+ 
+-  PartitionField(int sourceId, String name, Transform<?, ?> transform) {
++  PartitionField(int sourceId, int fieldId, String name, Transform<?, ?> transform) {
+     this.sourceId = sourceId;
++    this.fieldId = fieldId;
+     this.name = name;
+     this.transform = transform;
+   }",Do we need to check `fieldId` is larger than 1000?,Why do we need this change?
+3689,"@@ -356,10 +356,7 @@ void StatefulWriter::unsent_change_added_to_history(
+                     periodic_hb_event_->restart_timer(max_blocking_time);
+                 }
+ 
+-                if ( (mp_listener != nullptr) && this->is_acked_by_all(change) )
+-                {
+-                    mp_listener->onWriterChangeReceivedByAll(this, change);
+-                }
++                check_acked_status();
+ 
+                 if (disable_positive_acks_ && last_sequence_number_ == SequenceNumber_t())
+                 {",I think this should be called after the if below (the one for disable positive acks),Shouldn't this be `check_ac
+3690,"@@ -271,7 +271,7 @@ public class SparkTableUtil {
+    * @param metricsConfig a metrics conf
+    * @return a List of DataFile
+    */
+-  public static List<DataFile> listPartition(Map<String, String> partition, String uri, String format,
++  public static List<DataFile> listPartition(Map<String, String> partition, URI uri, String format,
+                                              PartitionSpec spec, Configuration conf, MetricsConfig metricsConfig) {
+     if (format.contains(""avro"")) {
+       return listAvroPartition(partition, uri, spec, conf);",I'd like to avoid changing this method since it is public and using a URI will probably change behavior for users passing strings (String -> URI -> Path instead of String -> Path).,Why do we need this change?
+3691,"@@ -5,11 +5,13 @@ import (
+ 	""path/filepath""
+ 	""testing""
+ 
++	""github.com/aws/aws-sdk-go/internal/sdktesting""
+ 	""github.com/aws/aws-sdk-go/internal/shareddefaults""
+ )
+ 
+ func TestSharedCredentialsProvider(t *testing.T) {
+-	os.Clearenv()
++
++	sdktesting.StashEnv()
+ 
+ 	p := SharedCredentialsProvider{Filename: ""example.ini"", Profile: """"}
+ 	creds, err := p.Retrieve()",Should these restore the stashed env after the test runs?,Why is this needed?
+3692,"@@ -402,7 +402,10 @@ def is_default_argument(
+     if not scope:
+         scope = node.scope()
+     if isinstance(scope, (nodes.FunctionDef, nodes.Lambda)):
+-        for default_node in scope.args.defaults:
++        all_defaults = scope.args.defaults + [
++            d for d in scope.args.kw_defaults if d is not None
++        ]
++        for default_node in all_defaults:
+             for default_name_node in default_node.nodes_of_class(nodes.Name):
+                 if default_name_node is node:
+                     return True",We're calculating the full list of kwargs here (even if the first element of the list would return True) so we could improve performance by using a generator line 408 in ``for default_node in all_defaults:``.,"I'm not sure if this is the right way to do this. I think it would be better to do this in the `if isinstance(scope, (nodes.FunctionDef, nodes.Lambda))` block."
+3693,"@@ -119,6 +119,14 @@ type accountDelta struct {
+ 	new basics.AccountData
+ }
+ 
++// accountDeltaCount is an extention to accountDelta that is being used by the commitRound function for counting the
++// number of changes we've made per account. The ndeltas is used execlusively for consistency checking - making sure that
++// all the pending changes were written and that there are no outstanding writes missing.
++type accountDeltaCount struct {
++	accountDelta
++	ndeltas int
++}
++
+ // catchpointState is used to store catchpoint related variables into the catchpointstate table.
+ type catchpointState string
+ ","Can ndelta differ depending on when the deltas are compacted? That is, when intermediate updates are dropped?",I'm not sure if this is the right place for this struct. It seems like it belongs in the `account` package.
+3694,"@@ -21,13 +21,12 @@ import net.sourceforge.pmd.lang.rule.xpath.JaxenXPathRuleQuery;
+ import net.sourceforge.pmd.lang.rule.xpath.SaxonXPathRuleQuery;
+ import net.sourceforge.pmd.lang.rule.xpath.XPathRuleQuery;
+ import net.sourceforge.pmd.properties.EnumeratedProperty;
+-import net.sourceforge.pmd.properties.PropertySource;
+ import net.sourceforge.pmd.properties.StringProperty;
+ 
+ /**
+  * Rule that tries to match an XPath expression against a DOM view of an AST.
+- *
+- * <p>This rule needs a ""xpath"" property value in order to function.
++ * <p>
++ * <p>This rule needs a ""xpath"" property value in order to function.</p>
+  */
+ public class XPathRule extends AbstractRule {
+ ","Our checkstyle config likes it better when the `<p>` is before the first word of the next paragraph, and not on a blank line",Why is this being removed?
+3695,"@@ -1498,6 +1498,8 @@ func (c *linuxContainer) criuSwrk(process *Process, req *criurpc.CriuReq, opts *
+ 	if err := cmd.Start(); err != nil {
+ 		return err
+ 	}
++	// we close criuServer so that even if CRIU crashes or unexpectedly exits, runc will not hang.
++	criuServer.Close()
+ 	// cmd.Process will be replaced by a restored init.
+ 	criuProcess := cmd.Process
+ ","This looks to be the only place where we return early before the close below, so if the ""double close"" is bothering people, closing manually here (and removing the `defer`) could be an option",Why do we need this?
+3696,"@@ -91,8 +91,8 @@ gulp.task( 'default', () => {
+ 	);
+ } );
+ 
+-gulp.task( 'qunit', function() {
+-	execSync( 'node-qunit-phantomjs ./tests/qunit/index.html', { stdio: [ 0, 1, 2 ] } );
++gulp.task( 'jest', function() {
++	execSync( 'npm run test:js', { stdio: [ 0, 1, 2 ] } );
+ } );
+ 
+ gulp.task( 'phpunit', function() {",This task can probably be deleted since we don't need gulp to run Jest.,Why do we need this task?
+3697,"@@ -23,6 +23,9 @@ require 'socket'
+ module Selenium
+   module WebDriver
+     class SocketPoller
++      NOT_CONNECTED_ERRORS = [Errno::ECONNREFUSED, Errno::ENOTCONN, SocketError]
++      NOT_CONNECTED_ERRORS << Errno::EPERM if Platform.cygwin?
++
+       def initialize(host, port, timeout = 0, interval = 0.25)
+         @host     = host
+         @port     = Integer(port)",Doesn't this need to include `Errno::ECONNRESET` to fix the issue?,Why is this needed?
+3698,"@@ -28,6 +28,19 @@ module Faker
+       def quote
+         fetch('movie.quote')
+       end
++
++      ##
++      # Produces a qirector from a movie.
++      #
++      # @return [String]
++      #
++      # @example
++      #   Faker::Movie.qirector #=> ""Quentin Tarantino""
++      #
++      # @faker.version next
++      def director
++        fetch('movie.director')
++      end
+     end
+   end
+ end",never heard of a qirector... what's their role again? (also should be 'for a movie'),This should be `@faker.ve
+3699,"@@ -86,6 +86,14 @@ kvstore::ResultCode QueryBoundProcessor::processVertex(PartitionID partId, Verte
+             }
+         }
+         vResp.set_tag_data(std::move(td));
++    } else if (tagContexts_.empty() && onlyVertexProps_) {
++        std::vector<cpp2::TagData> td;
++        auto ret = collectVertexProps(partId, vId, td);
++        if (ret != kvstore::ResultCode::ERR_KEY_NOT_FOUND
++                && ret != kvstore::ResultCode::SUCCEEDED) {
++            return ret;
++        }
++        vResp.set_tag_data(std::move(td));
+     }
+ 
+     if (onlyVertexProps_) {","Implement the ""collect all props for one vertex"" logic inside QueryVertexPropsProcessor",Why do we need to check f
+3700,"@@ -311,6 +311,10 @@ bool rai::uint256_union::decode_dec (std::string const & text)
+ 		{
+ 			stream >> number_l;
+ 			*this = number_l;
++			if (!stream.eof ())
++			{
++				result = true;
++			}
+ 		}
+ 		catch (std::runtime_error &)
+ 		{","This is to prevent parsing things like ""1.1"" as ""1"" until we implement it properly.",Why is this needed?
+3701,"@@ -25,7 +25,7 @@ import os
+ import shutil
+ 
+ from nupic.data.file_record_stream import FileRecordStream
+-from nupic.frameworks.opf.experiment_runner import runExperiment
++from nupic.frameworks.opf.experiment_runner import runExperiment, _getCheckpointParentDir
+ from nupic.support import initLogging
+ from nupic.support.unittesthelpers.testcasebase import (
+     unittest, TestCaseBase as HelperTestCaseBase)",Can we change `_getCheckpointParentDir` to be a public function explicitly? It seems like something that clients of experiment runner may wish to use.,Why do we need this
+3702,"@@ -2050,6 +2050,13 @@ class AdvancedPanelControls(wx.Panel):
+ 		self.UIAInMSWordCheckBox.SetValue(config.conf[""UIA""][""useInMSWordWhenAvailable""])
+ 		self.UIAInMSWordCheckBox.defaultValue = self._getDefaultValue([""UIA"", ""useInMSWordWhenAvailable""])
+ 
++		# Translators: This is the label for a checkbox in the
++		#  Advanced settings panel.
++		label = _(""Use UI Automation to access the Windows Console (restart NVDA for changes to take effect)"")
++		self.ConsoleUIACheckBox=UIAGroup.addItem(wx.CheckBox(self, label=label))
++		self.ConsoleUIACheckBox.SetValue(config.conf[""UIA""][""consoleUIA""])
++		self.ConsoleUIACheckBox.defaultValue = self._getDefaultValue([""UIA"", ""consoleUIA""])
++
+ 		# Translators: This is the label for a group of advanced options in the
+ 		#  Advanced settings panel
+ 		label = _(""Browse mode"")",Why is a restart necessary?,"This should be ""UI "
+3703,"@@ -458,7 +458,11 @@ func (task *Task) addGPUResource(cfg *config.Config) error {
+ 				container.GPUIDs = append(container.GPUIDs, association.Name)
+ 			}
+ 		}
+-		task.populateGPUEnvironmentVariables()
++		// For external instances, GPU IDs are handled by resources struct
++		// For internal instances, GPU IDs are handled by env var
++		if !cfg.External.Enabled() {
++			task.populateGPUEnvironmentVariables()
++		}
+ 		task.NvidiaRuntime = cfg.NvidiaRuntime
+ 	}
+ 	return nil",Should setting the task runtime also go under the above if condition?,Why do we need this
+3704,"@@ -32,6 +32,8 @@ import (
+ 
+ var isDNSLabel = regexp.MustCompile(`^[a-zA-Z0-9]([-]*[a-zA-Z0-9])+$`).MatchString
+ 
++const _defaultListEntriesPageSize = 50
++
+ //Handler service is used to register SPIFFE IDs, and the attestation logic that should
+ //be performed on a workload before those IDs can be issued.
+ type Handler struct {",SPIRE uses the leadingLowerCase convention for unexported constants,Why do we need this?
+3705,"@@ -1,11 +1,12 @@
+ // Copyright (c) Microsoft.  All Rights Reserved.
+ // Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information.
+ 
+-using Microsoft.CodeAnalysis.Sarif.Readers;
+ using System;
+ using System.CodeDom.Compiler;
+ using System.Collections.Generic;
+ using System.Runtime.Serialization;
++using Microsoft.CodeAnalysis.Sarif.Readers;
++using Newtonsoft.Json;
+ 
+ namespace Microsoft.CodeAnalysis.Sarif
+ {",The newest JSchema code generator orders `System` usings first.,Why is this needed?
+3706,"@@ -82,10 +82,17 @@ public class HiveIcebergSerDe extends AbstractSerDe {
+     }
+ 
+     String[] selectedColumns = ColumnProjectionUtils.getReadColumnNames(configuration);
+-    Schema projectedSchema = selectedColumns.length > 0 ? tableSchema.select(selectedColumns) : tableSchema;
++    Schema projectedSchema = tableSchema;
++
++    boolean caseSensitive = configuration.getBoolean(InputFormatConfig.CASE_SENSITIVE,
++            InputFormatConfig.CASE_SENSITIVE_DEFAULT);
++    if (selectedColumns.length > 0) {
++      projectedSchema = caseSensitive ? tableSchema.select(selectedColumns)
++              : tableSchema.caseInsensitiveSelect(selectedColumns);
++    }
+ 
+     try {
+-      this.inspector = IcebergObjectInspector.create(projectedSchema);
++      this.inspector = IcebergObjectInspector.create(projectedSchema, caseSensitive);
+     } catch (Exception e) {
+       throw new SerDeException(e);
+     }","I understand that we want to have a possibility to configure the IcebergInputFormat to be case sensitive or case insensitive since it can be used by other MR jobs as well. Do we want to allow the users of Hive to shot themselves on the foot and enable case sensitivity? My first guess would be that we should not use the configuration here, just go with `false`, but if you have some specific use-case in your mind I can be easily convinced  ",Why do we need to ch
+3707,"@@ -79,7 +79,7 @@ func (c *CStorPoolController) cStorPoolEventHandler(operation common.QueueOperat
+ 		common.SyncResources.Mux.Lock()
+ 		status, err := c.cStorPoolAddEventHandler(cStorPoolGot)
+ 		common.SyncResources.Mux.Unlock()
+-
++		pool.PoolAddEventHandled = true
+ 		return status, err
+ 
+ 	case common.QOpDestroy:",Will the above call to cStorPoolAddEventHandler() get executed in the same thread as this line?,Why do we need to se
+3708,"@@ -600,11 +600,11 @@ func (c *coroutineLoweringPass) lowerFuncsPass() {
+ 			continue
+ 		}
+ 
+-		if len(fn.normalCalls) == 0 {
+-			// No suspend points. Lower without turning it into a coroutine.
++		if len(fn.normalCalls) == 0 && fn.fn.FirstBasicBlock().FirstInstruction().IsAAllocaInst().IsNil() {
++			// No suspend points or stack allocations. Lower without turning it into a coroutine.
+ 			c.lowerFuncFast(fn)
+ 		} else {
+-			// There are suspend points, so it is necessary to turn this into a coroutine.
++			// There are suspend points or stack allocations, so it is necessary to turn this into a coroutine.
+ 			c.lowerFuncCoro(fn)
+ 		}
+ 	}","I don't think alloca instructions are always at the start of the entry block. I think it would be safer to check the entire entry block for alloca instructions, just in case some are not the first instruction. (Technically they can be anywhere in the function but we check in other places that this isn't possible).","I don't think this is correct. If there are no suspend points or stack allocations, we should lower the function as fast as possible."
+3709,"@@ -135,11 +135,19 @@ func chainsForIfaces(ifaceMetadata []string,
+ 	epMarkMapper rules.EndpointMarkMapper,
+ 	host bool,
+ 	tableKind string) []*iptables.Chain {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	log.WithFields(log.Fields{
+ 		""ifaces"":    ifaceMetadata,
+ 		""host"":      host,
+ 		""tableKind"": tableKind,
+ 	}).Debug(""Calculating chains for interface"")
++
+ 	chains := []*iptables.Chain{}
+ 	dispatchOut := []iptables.Rule{}
+ 	dispatchIn := []iptables.Rule{}",Why isn't this 4789 (which I think is the Felix default)?,nit: can we call this VXLANPort and VXLANVNI
+3710,"@@ -57,6 +57,10 @@ const (
+ 	MessageResourceFailCreate EventReason = ""Resource creation failed""
+ 	// SuccessImported holds status for corresponding imported resource.
+ 	SuccessImported EventReason = ""Imported""
++	// FailureImported holds status for corresponding imported resource.
++	FailureImported EventReason = ""Import failure""
++	// FailureImportOperations holds status for corresponding imported resource.
++	FailureImportOperations EventReason = ""Failure Import operations""
+ 	// MessageResourceImported holds message for corresponding imported resource.
+ 	MessageResourceImported EventReason = ""Resource imported successfully""
+ 	// FailureStatusSync holds status for corresponding failed status sync of resource.","Can this be `Import operations failure`? In addition, is this the right time to change the variable names? e.g. `ReasonImportOperationsFailure`, `ReasonImportFailure`, `ReasonImportSuccessful`, `ReasonCreateResourceFailure`, `ReasonImportResourceSuccessful` Naming convention that i have assumed here is as follows: `Reason<Action><Entity/Adjective of the Entity><Sucess/Failure>`",Why do we need this?
+3711,"@@ -457,4 +457,5 @@ void Init_binary_protocol_accelerated() {
+   rb_define_method(bpa_class, ""read_set_end"", rb_thrift_binary_proto_read_set_end, 0);
+ 
+   rbuf_ivar_id = rb_intern(""@rbuf"");
++  rb_global_variable(&rbuf_ivar_id);
+ }",I suspect this isn't needed because I think `rb_intern` gets marked already.,Why do we need this?
+3712,"@@ -96,7 +96,7 @@ public class InternalSelenseTestBase extends SeleneseTestBase {
+       return;
+     }
+ 
+-    log.info(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
++    log.finest(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
+ 
+     Path dir =
+       InProject.locate(""java/client/build/production/com/thoughtworks/selenium/webdriven"");",This change is incorrect: the current log level is correct.,Why is this being changed to `finest`?
+3713,"@@ -80,7 +80,8 @@ public class BKDWriter implements Closeable {
+   //public static final int VERSION_CURRENT = VERSION_START;
+   public static final int VERSION_LEAF_STORES_BOUNDS = 5;
+   public static final int VERSION_SELECTIVE_INDEXING = 6;
+-  public static final int VERSION_CURRENT = VERSION_SELECTIVE_INDEXING;
++  public static final int VERSION_LOW_CARDINALITY_LEAVES= 7;
++  public static final int VERSION_CURRENT = VERSION_LOW_CARDINALITY_LEAVES;
+ 
+   /** How many bytes each docs takes in the fixed-width offline format */
+   private final int bytesPerDoc;",Can you add a space before the equal sign? There are a couple other places where spaces are missing in this PR.,nit: space after `=`
+3714,"@@ -268,7 +268,10 @@ public class ExecutorServlet extends HttpServlet implements ConnectorParams {
+         continue;
+       }
+ 
+-      if (flow.getUpdateTime() > updateTime) {
++      // After removing runningFlows cache from web server, flow info will be fetched from DB directly,
++      // updateTime will be synced between web server and executor. So below if condition will always be true.
++      // TODO: will remove UpdaterThread in executorManager and deprecate handleAjaxUpdateRequest()
++      if (flow.getUpdateTime() >= updateTime) {
+         updateList.add(flow.toUpdateObject(updateTime));
+       }
+     }",Please follow the todo naming convention.,I think we can remove this TODO now.
+3715,"@@ -28,6 +28,9 @@ import (
+ // +k8s:openapi-gen=true
+ // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+ 
++// +kubebuilder:printcolumn:name=""Ready"",type=""string"",JSONPath="".status.conditions[?(@.type==\""Ready\"")].status"",description=""""
++// +kubebuilder:printcolumn:name=""Status"",type=""string"",JSONPath="".status.conditions[?(@.type==\""Ready\"")].message"",description=""""
++// +kubebuilder:printcolumn:name=""Age"",type=""date"",JSONPath="".metadata.creationTimestamp"",description=""CreationTimestamp is a timestamp representing the server time when this object was created. It is not guaranteed to be set in happens-before order across separate operations. Clients may not set this value. It is represented in RFC3339 form and is in UTC.""
+ // +kubebuilder:subresource:status
+ // +kubebuilder:resource:path=clusterissuers,scope=Cluster
+ type ClusterIssuer struct {",These are no longer used and changes should instead be made directly to the files in `deploy/chart/crds`   /assign @JoshVanL /unassign,I don't think we need this line.
+3716,"@@ -257,9 +257,11 @@ class YOLOV3Head(BaseDenseHead, BBoxTestMixin):
+             # (h, w, num_anchors*num_attrib) -> (h*w*num_anchors, num_attrib)
+             pred_map = pred_map.permute(1, 2, 0).reshape(-1, self.num_attrib)
+ 
+-            pred_map[..., :2] = torch.sigmoid(pred_map[..., :2])
+-            bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i],
+-                                               pred_map[..., :4], stride)
++            xy = torch.sigmoid(pred_map[..., :2])
++            xywh = torch.cat((xy, pred_map[..., 2:4]), axis=-1)
++            bbox_pred = self.bbox_coder.decode(multi_lvl_anchors[i], xywh,
++                                               stride)
++
+             # conf and cls
+             conf_pred = torch.sigmoid(pred_map[..., 4]).view(-1)
+             cls_pred = torch.sigmoid(pred_map[..., 5:]).view(",Is this really necessary to work around this way? The old version works fine with me when converting to ONNX.,nit: `xywh` -> `xy_wh`
+3717,"@@ -71,7 +71,7 @@ type s3Blob struct {
+ 
+ func (bb *s3Blob) Write(p []byte) (int, error) {
+ 	if bb.final {
+-		return 0, errors.New(""blob already closed"")
++		return 0, errors.New(""Blob already closed"")
+ 	}
+ 
+ 	n, err := bb.buf.Write(p)","Same as above: don't start error strings with a capital letter, and don't fix unneeded things in an unrelated commit ;)",I think this should be
+3718,"@@ -168,6 +168,7 @@ module Beaker
+ 
+       options[:recursive]=File.directory?(source) if options[:recursive].nil?
+ 
++      @logger.debug ""going to upload! #{source} to #{@hostname}:#{target}""
+       @ssh.scp.upload! source, target, options
+ 
+       result = Result.new(@hostname, [source, target])",Is this a testing debug statement?,"@logger.debug ""going t"
+3719,"@@ -849,7 +849,11 @@ var connect = function(self, url, options, callback) {
+   }
+ 
+   // Parse the string
+-  var object = parse(url, options);
++  var object;
++  parse(url, options, function(err, connectionStringObject) {
++    if (err) return console.log(err);
++    object = connectionStringObject;
++  });
+   var _finalOptions = createUnifiedOptions({}, object);
+   _finalOptions = mergeOptions(_finalOptions, object, false);
+   _finalOptions = createUnifiedOptions(_finalOptions, options);","you'll need to wrap the _whole thing_ within this async call (or refactor it so everything below is in a new temporary function). The code below this section depends on a value for `object` after the parsing occurs, but what you're doing here is kicking off a race condition where `object` is null, but _might_ parse quickly enough to assign it the parsed parts. Instead, you need to do everything that depends on the parsed object in the callback of `parse`.",Why is this needed?
+3720,"@@ -238,9 +238,9 @@ thread ([this]() {
+ 
+ void nano::worker::run ()
+ {
++	std::unique_lock<std::mutex> lk (mutex);
+ 	while (!stopped)
+ 	{
+-		std::unique_lock<std::mutex> lk (mutex);
+ 		if (!queue.empty ())
+ 		{
+ 			auto func = queue.front ();","This is now going to be protecting `stopped` when it doesn't need to. If you are going to do this then can you make `stopped` non-atomic and protect it in `stop`. It's cheap to make a `unique_lock` fyi, it's just a pointer to a mutex and a `bool`. The `lk.lock ()` in the loop is superfluous so probably shouldn't have been there to begin with.",Why did you remove the lock?
+3721,"@@ -27,6 +27,10 @@ import (
+ 	""strings""
+ 	""time""
+ 
++	""github.com/mysteriumnetwork/node/cmd/commands""
++
++	remote_config ""github.com/mysteriumnetwork/node/config/remote""
++
+ 	""github.com/chzyer/readline""
+ 	""github.com/rs/zerolog/log""
+ 	""github.com/urfave/cli/v2""","Lets not give packages names if we dont have to. If a package requires a rename, we should change the actual name while/if we can.",Why do we need this import?
+3722,"@@ -1128,12 +1128,16 @@ encode_opnd_imm5(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ static inline bool
+ decode_opnd_imm6(uint enc, int opcode, byte *pc, OUT opnd_t *opnd)
+ {
++    if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))
++        return false;
+     return decode_opnd_int(10, 6, false, 0, OPSZ_6b, 0, enc, opnd);
+ }
+ 
+ static inline bool
+ encode_opnd_imm6(uint enc, int opcode, byte *pc, opnd_t opnd, OUT uint *enc_out)
+ {
++    if (!TEST(1U << 31, enc) && TEST(1U << 15, enc))
++        return false;
+     return encode_opnd_int(10, 6, false, 0, 0, opnd, enc_out);
+ }
+ ",Not sure I see where this is coming from. This is a bug fix? Should be mentioned in the commit message? Same below.,Why is this needed?
+3723,"@@ -125,9 +125,6 @@ function generateTopologyTests(testSuites, testContext, filter) {
+       describe(suiteName, {
+         metadata: { requires },
+         test: function () {
+-          beforeEach(() => prepareDatabaseForSuite(testSuite, testContext));
+-          afterEach(() => testContext.cleanupAfterSuite());
+-
+           testSuite.tests.forEach(spec => {
+             it(spec.description, function () {
+               if (","I reverted this change in the last commit, I think we should revert it here. I know this leads to confusing test output for skipped tests, but I would prefer to tackle that in a separate PR specifically focused on that problem. In fact, I think the issue might really be with the leak checker, and not how this test runner is defined. Please make a ticket for this (if it doesn't already exist) and revert this change",Why was this removed?
+3724,"@@ -213,6 +213,9 @@ class LoadAnnotations:
+             annotation. Default: False.
+         poly2mask (bool): Whether to convert the instance masks from polygons
+             to bitmaps. Default: True.
++        normed_bbox (bool): Whether to convert bbox from relative value to
++            absolute value. Only used in OpenImage Dataset.
++            Default: False.
+         file_client_args (dict): Arguments to instantiate a FileClient.
+             See :class:`mmcv.fileio.FileClient` for details.
+             Defaults to ``dict(backend='disk')``.",Can this part be done in `dataset.get_ann_info`? Just like CocoDataset converts xywh to xyxy in `_parse_ann_info`,Can you add a note that this is only used in OpenImage Dataset?
+3725,"@@ -32,10 +32,10 @@ func (*testTraceProvider) Tracer(_ string, _ ...trace.TracerOption) trace.Tracer
+ func TestMultipleGlobalTracerProvider(t *testing.T) {
+ 	p1 := testTraceProvider{}
+ 	p2 := trace.NoopProvider{}
+-	global.SetTraceProvider(&p1)
+-	global.SetTraceProvider(&p2)
++	global.SetTracerProvider(&p1)
++	global.SetTracerProvider(&p2)
+ 
+-	got := global.TraceProvider()
++	got := global.TracerProvider()
+ 	want := &p2
+ 	if got != want {
+ 		t.Fatalf(""Provider: got %p, want %p\n"", got, want)",Should we change the name of this test struct to be `testTracerProvider` as well?,Why did you change this?
+3726,"@@ -21,13 +21,14 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/config""
+-	""github.com/iotexproject/iotex-core/explorer""
+ 	""github.com/iotexproject/iotex-core/pkg/keypair""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/pkg/probe""
++	""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ 	""github.com/iotexproject/iotex-core/server/itx""
+ 	""github.com/iotexproject/iotex-core/testutil""
+ 	""github.com/iotexproject/iotex-core/tools/util""
++	""google.golang.org/grpc""
+ )
+ 
+ const (","""google.golang.org/grpc"" should be together with ""go.uber.org/zap"" all """"github.com/iotexproject/iotex-core/*"" stay together",nit: remove empty line
+3727,"@@ -700,6 +700,12 @@ class WebEngineTab(browsertab.AbstractTab):
+         self._inject_early_js('js', js_code, subframes=True)
+         self._init_stylesheet()
+ 
++        js_code_print = utils.read_file('javascript/print.js')
++        self._inject_early_js('js',
++                              js_code_print,
++                              subframes=True,
++                              world=QWebEngineScript.MainWorld)
++
+         greasemonkey = objreg.get('greasemonkey')
+         greasemonkey.scripts_reloaded.connect(self._inject_userscripts)
+         self._inject_userscripts()",No need for a separate variable here - just call `utils.read_file` directly below.,Why do we need this?
+3728,"@@ -150,8 +150,18 @@ func (ctx *ChannelContext) SendResp(message model.Message) {
+ 
+ 	ctx.anonChsLock.RLock()
+ 	defer ctx.anonChsLock.RUnlock()
++
++	deadline := time.Now().Add(MessageTimeoutDefault)
++	sendTimer := time.NewTimer(time.Until(deadline))
++
+ 	if channel, exist := ctx.anonChannels[anonName]; exist {
+-		channel <- message
++		select {
++		case channel <- message:
++		case <-sendTimer.C:
++			klog.Warning(""timeout when SendResp message"")
++			return
++		}
++		sendTimer.Stop()
+ 		return
+ 	}
+ ","Thanks for the fixing, small question, Here the message just be written to the channel, will it be blocked?",I think it would be better to use `time.After` here.
+3729,"@@ -29,7 +29,8 @@ type SyncStage byte
+ 
+ const (
+ 	Headers   SyncStage = iota // Headers are downloaded, their Proof-Of-Work validity and chaining is verified
+-	Bodies                     // Block bodies are downloaded, TxHash and UncleHash are getting verified, ""From"" recovered from signatures
++	Bodies                     // Block bodies are downloaded, TxHash and UncleHash are getting verified
++	Senders                    // ""From"" recovered from signatures, bodies re-written
+ 	Execution                  // Executing each block w/o buildinf a trie
+ 	HashCheck                  // Checking the root hash
+ 	Finish                     // Nominal stage after all other stages","maybe we will have something like `Bodies []byte(""bodies"")` instead of them being a number? with numbers we are making it harder to insert stages mid-process.",I don't think this is correct.
+3730,"@@ -82,11 +82,11 @@ type Endpoint struct {
+ // GroupMember represents resource member to be populated in Groups.
+ // This supersedes GroupMemberPod, and will eventually replace it.
+ type GroupMember struct {
+-	// ExternalEntity maintains the reference to the ExternalEntity.
+-	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,1,opt,name=externalEntity""`
+-
+ 	// Pod maintains the reference to the Pod.
+-	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,2,opt,name=pod""`
++	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,1,opt,name=pod""`
++
++	// ExternalEntity maintains the reference to the ExternalEntity.
++	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,2,opt,name=externalEntity""`
+ 
+ 	// Endpoints maintains a list of EndPoints associated with this groupMember.
+ 	Endpoints []Endpoint `json:""endpoints,omitempty"" protobuf:""bytes,3,rep,name=endpoints""`","out of curiosity, why making this change? If no real reason, could you restore to avoid unnecessary changes of several generated files?",Why did this change?
+3731,"@@ -334,6 +334,10 @@ func (manager *connectionManager) Disconnect() error {
+ 	manager.cleanConnection()
+ 	manager.setStatus(statusNotConnected())
+ 
++	manager.eventPublisher.Publish(StateEventTopic, StateEvent{
++		State:       NotConnected,
++		SessionInfo: manager.sessionInfo,
++	})
+ 	return nil
+ }
+ ",Could we public events if `manager.serStatus()`?,Why do we need to publish this event?
+3732,"@@ -134,7 +134,9 @@ module.exports = class Plugin {
+     }
+ 
+     this.uppy.log(`Not installing ${callerPluginName}`)
+-    throw new Error(`Invalid target option given to ${callerPluginName}`)
++    throw new Error(`Invalid target option given to ${callerPluginName}. Please make sure that the element 
++      exists on the page, or that the plugin you are targeting has been installed. Check that the <script> tag initializing Uppy 
++      comes at the bottom of the page, before the </body> (see https://github.com/transloadit/uppy/issues/1042).`)
+   }
+ 
+   render (state) {","could be misread as `<body>`, maybe something redundant but very clear like ""before the closing `</body>` tag""?",I'm not sure this is the right way to do this. I think it would be better to check for the existence of the `<script>` tag and throw an error if it doesn't.
+3733,"@@ -510,12 +510,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+             var testLogger = new TestApplicationErrorLogger();
+             var serviceContext = new TestServiceContext { Log = new TestKestrelTrace(testLogger) };
+ 
+-            using (var server = new TestServer(httpContext =>
++            using (var server = new TestServer(async httpContext =>
+             {
+                 httpContext.Response.ContentLength = 11;
+-                httpContext.Response.Body.Write(Encoding.ASCII.GetBytes(""hello,""), 0, 6);
+-                httpContext.Response.Body.Write(Encoding.ASCII.GetBytes("" world""), 0, 6);
+-                return Task.CompletedTask;
++                await httpContext.Response.Body.WriteAsync(Encoding.ASCII.GetBytes(""hello,""), 0, 6);
++                await httpContext.Response.Body.WriteAsync(Encoding.ASCII.GetBytes("" world""), 0, 6);
+             }, serviceContext))
+             {
+                 using (var connection = server.CreateConnection())","This test is specifically checking behavior on sync I/O (note there are tests with Write in the name, and other tests with WriteAsync). Enable sync I/O here.",Why did you change this?
+3734,"@@ -0,0 +1,11 @@
++class WeeklyIterationDripMailerPreview < ActionMailer::Preview
++  def weekly_update
++    user = User.new(name: 'John Doe')
++    video = Video.first.tap do |video|
++      video.email_body_text = 'Email body text'
++      video.email_cta_label = 'Click Here!'
++    end
++
++    WeeklyIterationDripMailer.weekly_update(user: user, video: video)
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Use 2 (not 4) spaces for indentation.
+3735,"@@ -56,6 +56,8 @@ type CStorVolumeClaimSpec struct {
+ 	// CStorVolumeRef has the information about where CstorVolumeClaim
+ 	// is created from.
+ 	CStorVolumeRef *corev1.ObjectReference `json:""cstorVolumeRef,omitempty""`
++	// CstorVolumeSource contains the source volumeID+Snapshot combaination
++	CstorVolumeSource string `json:""cstorVolumeSource,omitempty""`
+ }
+ 
+ // CStorVolumeClaimPublish contains info related to attachment of a volume to a node.",nit: Should we have something like `volumeName@snapShotname` and this will be filled only if it is a clone creation,Why do we need this?
+3736,"@@ -164,10 +164,13 @@ func WriteWordpressConfig(wordpressConfig *WordpressConfig, filePath string) err
+ 		return err
+ 	}
+ 
+-	// Ensure target directory is writable.
++	// Ensure target directory exists and is writeable
+ 	dir := filepath.Dir(filePath)
+-	err = os.Chmod(dir, 0755)
+-	if err != nil {
++	if err = os.Chmod(dir, 0755); os.IsNotExist(err) {
++		if err = os.MkdirAll(dir, 0755); err != nil {
++			return err
++		}
++	} else if err != nil {
+ 		return err
+ 	}
+ ",This seems like an improved pattern :),Why do we need this change?
+3737,"@@ -53,7 +53,11 @@ def get_hdfs_syntax():
+     override this setting with ""cdh3"" or ""apache1"" in the hadoop section of the config in
+     order to use the old syntax
+     """"""
+-    return configuration.get_config().get(""hadoop"", ""version"", ""cdh4"").lower()
++    try:
++        import snakebite
++        return configuration.get_config().get(""hadoop"", ""version"", ""snakebite"").lower()
++    except ImportError:
++        return configuration.get_config().get(""hadoop"", ""version"", ""cdh4"").lower()
+ 
+ 
+ def load_hadoop_cmd():","I think it would be better to have a separate configuration option for specifying which HDFS interaction layer to use instead of using the existing hadoop version option. I think there are still cases where things might have to rely on Hadoop version for other things, and overwriting that information with ""snakebite"" would make that difficult. The existing hadoop version option could still be used to distinguish the different HDFS CLI flavours.",I think this should be `con
+3738,"@@ -575,10 +575,15 @@ module Bolt
+       outputter.print_task_info(pal.get_task(task_name))
+     end
+ 
++    # Filters a list of content by matching substring.
++    #
++    private def filter_content(content, filter)
++      return content unless content && filter
++      content.select { |name,| name.include?(filter) }
++    end
++
+     def list_tasks
+-      tasks = pal.list_tasks
+-      tasks.select! { |task| task.first.include?(options[:filter]) } if options[:filter]
+-      tasks.select! { |task| config.project.tasks.include?(task.first) } unless config.project.tasks.nil?
++      tasks = filter_content(pal.list_tasks(filter_content: true), options[:filter])
+       outputter.print_tasks(tasks, pal.user_modulepath)
+     end
+ ",Why are we filtering content twice? It seems like just filtering it in PAL should work.,Layout/SpaceAfterComma: Spa
+3739,"@@ -17,11 +17,11 @@
+  */
+ 
+ export const ACCOUNT_STATUS_NONE = 'none';
++export const ACCOUNT_STATUS_MULTIPLE = 'multiple';
+ export const ACCOUNT_STATUS_DISAPPROVED = 'disapproved';
+ export const ACCOUNT_STATUS_GRAYLISTED = 'graylisted';
+-export const ACCOUNT_STATUS_MULTIPLE = 'multiple';
+-export const ACCOUNT_STATUS_NO_CLIENT = 'no-client';
+ export const ACCOUNT_STATUS_PENDING = 'pending';
++export const ACCOUNT_STATUS_NO_CLIENT = 'no-client';
+ export const ACCOUNT_STATUS_APPROVED = 'approved';
+ 
+ // TODO: Expand the statuses provided here to be more specific in case the",These should probably move to `constants.js`,Why did you change this?
+3740,"@@ -21,6 +21,8 @@ import com.google.common.base.Charsets;
+ import com.google.common.io.ByteStreams;
+ import com.google.common.net.MediaType;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.apache.http.Header;
+ import org.apache.http.HttpEntity;
+ import org.apache.http.HttpHost;","Again, you don't want to depend on glassfish.",Why is this import needed?
+3741,"@@ -0,0 +1,15 @@
++# frozen_string_literal: true
++
++module Faker
++  module Space
++    class << self
++      extend Gem::Deprecate
++
++      def launch_vehicule
++        Faker::Space.launch_vehicule
++      end
++
++      deprecate :launch_vehicule, 'Faker::Space.launch_vehicule', 2019, 06
++    end
++  end
++end","it should be `Faker::Space.launch_vehicle`, otherwise it will crash","Should this be 2019, 06?"
+3742,"@@ -630,6 +630,18 @@ namespace NLog.Targets
+ #endif
+             byte[] bytes = this.GetBytesToWrite(logEvent);
+ 
++            // Clean up old archives if this is the first time a log record has been written to
++            // this log file and the archiving system is date/time based.
++            if (this.ArchiveNumbering == ArchiveNumberingMode.Date && this.ArchiveEvery != FileArchivePeriod.None)
++            {
++                FileInfo fileInfo = new FileInfo(fileName);
++                if (!fileInfo.Exists)
++                {
++                    string fileNamePattern = this.GetFileNamePattern(fileName, logEvent, fileInfo);
++                    this.DeleteOldDateArchive(fileNamePattern);
++                }
++            }
++
+             if (this.ShouldAutoArchive(fileName, logEvent, bytes.Length))
+             {
+                 this.InvalidateCacheItem(fileName);",Isn't it quite expensive to check whether the file exists on every write?,nit: `this.ArchiveEvery !=
+3743,"@@ -165,7 +165,9 @@ webdriver.Builder.prototype.build = function() {
+   } else {
+     var url = this.serverUrl_;
+     var client;
+-    if (url[0] == '/') {
++    if (webdriver.http.CorsClient.isAvailable()) {
++      client = new webdriver.http.XhrClient(url);
++    } else if (url[0] == '/') {
+       var origin = window.location.origin ||
+           (window.location.protocol + '//' + window.location.host);
+       client = new webdriver.http.XhrClient(origin + url);",Please hide this behind a flag and add a setter function to the builder.,Why is this needed?
+3744,"@@ -1009,6 +1009,7 @@ func (vd *volAPI) Routes() []*Route {
+ 		{verb: ""POST"", path: backupPath(""/restore"", volume.APIVersion), fn: vd.cloudBackupRestore},
+ 		{verb: ""GET"", path: backupPath("""", volume.APIVersion), fn: vd.cloudBackupEnumerate},
+ 		{verb: ""DELETE"", path: backupPath("""", volume.APIVersion), fn: vd.cloudBackupDelete},
++		{verb: ""DELETE"", path: backupPath(""/all"", volume.APIVersion), fn: vd.cloudBackupDeleteAll},
+ 		{verb: ""GET"", path: backupPath(""/status"", volume.APIVersion), fn: vd.cloudBackupStatus},
+ 		{verb: ""GET"", path: backupPath(""/catalog"", volume.APIVersion), fn: vd.cloudBackupCatalog},
+ 		{verb: ""GET"", path: backupPath(""/history"", volume.APIVersion), fn: vd.cloudBackupHistory},",old api should be deprecated if we don't intend on using it anymore. Again this should happen through swagger api and then removed from next release. We should also release not this as a breaking change. (same with all the other cloudsnap api renames.,Why do we need this?
+3745,"@@ -59,7 +59,7 @@ public class VertxRestTransport extends AbstractTransport {
+     }
+ 
+     if (!NetUtils.canTcpListen(ep.getSocketAddress().getAddress(), ep.getPort())) {
+-      log.info(""can not listen {}, skip {}."", ep.getSocketAddress(), this.getClass().getName());
++      log.warn(""can not listen {}, port may have been occupied, this may cause client report error when being accessed. skip {}."", ep.getSocketAddress(), this.getClass().getName());
+       return false;
+     }
+ ","so strange...... canTcpListen is to detect, if this transport can init when customers deployed vertx and servlet rest transport, we must detect which one will be used only both of them refused to init is a problem. we have already print that......",I don't think this s
+3746,"@@ -38,6 +38,8 @@ import com.salesforce.androidsdk.util.JSONObjectHelper;
+  */
+ public class QuerySpec {
+ 	private static final String SELECT_COUNT = ""SELECT count(*) "";
++    private static final String SELECT_COUNT_FORM = SELECT_COUNT + "" FROM (%s)"";
++
+ 	// Constants
+ 	private static final String SELECT = ""SELECT  "";
+ 	private static final String FROM = ""FROM "";","Did you mean for this to be `FORM`, instead of `FROM`?",Why do we need this?
+3747,"@@ -94,6 +94,13 @@ type AWSMachineSpec struct {
+ 	// +kubebuilder:validation:MaxItems=2
+ 	NetworkInterfaces []string `json:""networkInterfaces,omitempty""`
+ 
++	// UncompressedUserData specify whether the user data is gzip-compressed before it is sent to ec2 instance.
++	// cloud-init has built-in support for gzip-compressed user data
++	// user data stored in aws secret manager is always gzip-compressed.
++	//
++	// +optional
++	UncompressedUserData *bool `json:""uncompressedUserData,omitempty""`
++
+ 	// CloudInit defines options related to the bootstrapping systems where
+ 	// CloudInit is used.
+ 	// +optional",What are your thoughts on the long term solution for the naming of this variable? Do you think we should revert the logic when we are ready to make the next set of breaking API changes?,Why do we need this?
+3748,"@@ -92,14 +92,15 @@ module RSpec
+         command = spec_command
+ 
+         begin
+-          puts command if verbose
++          $stdout.puts(command}) if verbose
+           success = system(command)
+         rescue
+-          puts failure_message if failure_message
++          $stderr.puts failure_message if failure_message
+         end
++        
+         if fail_on_error && !success
+-          $stderr.puts ""#{command} failed""
+-          exit $?.exitstatus
++          $stderr.puts(""#{command} failed"") if verbose
++          exit($?.exitstatus)
+         end
+       end
+ ",There's a syntax error on this line.,Space inside { missing.<br>Space inside } missing.
+3749,"@@ -834,7 +834,7 @@ fpga_result clear_port_errors(fpga_handle afu_handle)
+ 	result = fpgaObjectRead64(port_error_object, &value, 0);
+ 	if (result != FPGA_OK) {
+ 		OPAE_ERR(""Failed to Read Object "");
+-		return result;
++		goto out;
+ 	}
+ 
+ 	printf(""\n \n Port error CSR : 0x%lx \n"", value);",You lose the value of `result` when you `goto out`,Why is this change needed?
+3750,"@@ -497,8 +497,9 @@ Blockly.Scrollbar.prototype.onScroll_ = function() {
+  * @param {number} value The distance from the top/left end of the bar.
+  */
+ Blockly.Scrollbar.prototype.set = function(value) {
++  var ratio = this.ratio_ == undefined ? 0 : this.ratio_;
+   // Move the scrollbar slider.
+-  this.svgKnob_.setAttribute(this.horizontal_ ? 'x' : 'y', value * this.ratio_);
++  this.svgKnob_.setAttribute(this.horizontal_ ? 'x' : 'y', value * ratio);
+   this.onScroll_();
+ };
+ ","Just a style thing, why not `this.ratio_ || 0`?",I think this should be `this.ratio_ || 0`.
+3751,"@@ -186,7 +186,8 @@ func CIDRFromCalicoNet(ipNet calinet.IPNet) CIDR {
+ 
+ func CIDRFromIPNet(ipNet *net.IPNet) CIDR {
+ 	ones, _ := ipNet.Mask.Size()
+-	ip := FromNetIP(ipNet.IP)
++	// Mask the IP before creating the CIDR so that we have it in canonical format.
++	ip := FromNetIP(getMaskedIp(ipNet))
+ 	if ip.Version() == 4 {
+ 		return V4CIDR{
+ 			addr:   ip.(V4Addr),","I think the stdlib's `net.IP` has a `Mask()` method, does that do what we need?",Why do we need this change?
+3752,"@@ -106,9 +106,9 @@ func strOr(s string, ss ...string) string {
+ 	return """"
+ }
+ 
+-// substitute runs replacer on string elements within a complex data structure
++// Substitute runs replacer on string elements within a complex data structure
+ // (except those contained in private data structure fields).
+-func substitute(v reflect.Value, replacer *strings.Replacer) {
++func Substitute(v reflect.Value, replacer *strings.Replacer) {
+ 	traverseData(v, func(val reflect.Value) dErr {
+ 		switch val.Interface().(type) {
+ 		case string:",Why does substitute need to be public? Are we allowing/encouraging variable usage when using Daisy as a library?,Why is this exported?
+3753,"@@ -335,6 +335,11 @@ class WebEngineCaret(browsertab.AbstractCaret):
+         """"""
+         if js_elem is None:
+             return
++        if js_elem == ""focused"":
++            # we had a focused element, not a selected one. Just send <enter>
++            self._tab.key_press(Qt.Key_Enter)
++            return
++
+         assert isinstance(js_elem, dict), js_elem
+         elem = webengineelem.WebEngineElement(js_elem, tab=self._tab)
+         if tab:","We should probably use ctrl-enter if `tab` is given, just like in `follow_selected`?",I think this should b
+3754,"@@ -146,7 +146,7 @@ func New(
+ 
+ 	dynamicCollection := dynamicconfig.NewCollection(params.DynamicConfig, logger)
+ 
+-	dispatcher := params.RPCFactory.CreateDispatcher()
++	dispatcher := params.RPCFactory.CreateTChannelDispatcher()
+ 	membershipMonitor, err := params.MembershipFactory.Create(dispatcher)
+ 	if err != nil {
+ 		return nil, err",This file looks like anti pattern `ServiceLocator` and lucky it's not used anywhere. Can I remove it? (in separate PR).,I think this should b
+3755,"@@ -466,6 +466,10 @@ public class DatasetUtil {
+      * size for tabular files.
+      */
+     public static String getDownloadSize(DatasetVersion dsv, boolean original) {
++        return FileSizeChecker.bytesToHumanReadable(getDownloadSizeNumeric(dsv, original));
++    }
++    
++    public static Long getDownloadSizeNumeric(DatasetVersion dsv, boolean original) {
+         long bytes = 0l;
+         for (FileMetadata fileMetadata : dsv.getFileMetadatas()) {
+             DataFile dataFile = fileMetadata.getDataFile();","we can just have this method call the next, passing in the file metadatas (deduplication of logic)",Why do we need a sepa
+3756,"@@ -480,6 +480,17 @@ class TabBar(QTabBar):
+             new_idx = super().insertTab(idx, icon, '')
+         self.set_page_title(new_idx, text)
+ 
++    def wheelEvent(self, event):
++        """"""Override wheelEvent to make the action configurable.""""""
++        if config.get('tabs', 'mousewheel-tab-switching'):
++            super().wheelEvent(event)
++        else:
++            tabbed_browser = objreg.get('tabbed-browser', scope='window',
++                                        window=self._win_id)
++            focused_tab = tabbed_browser.currentWidget()
++            if focused_tab is not None:
++                focused_tab.wheelEvent(event)
++
+ 
+ class TabBarStyle(QCommonStyle):
+ ","What happens here if you send the `wheelEvent` directly to the `tabbed_browser` and let it take care of propagating it to its children (i.e. the focused tab)? If that works, I guess that'd be cleaner.",This should be `if focused_tab is not None:`
+3757,"@@ -21,6 +21,10 @@ from .compat import (PANDAS_INSTALLED, DataFrame, Series, is_dtype_sparse,
+ from .libpath import find_lib_path
+ 
+ 
++def _log_callback(msg):
++    """"""Redirect logs from native library into Python console""""""
++    print(""{0:s}"".format(decode_string(msg)), end='')
++
+ def _load_lib():
+     """"""Load LightGBM library.""""""
+     lib_path = find_lib_path()",it seems python 2 don't support `end=''`. @StrikerRUS @henry0312 any better solution? or we drop the support of python 2?,Why do we need this?
+3758,"@@ -4135,6 +4135,12 @@ bool PreCallValidateCreateImageView(layer_data *device_data, const VkImageViewCr
+             }
+         }
+     }
++	else
++	{
++		skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_IMAGE_EXT,
++                                HandleToUint64(create_info->image), ""VUID-VkImageViewCreateInfo-image-parameter"",
++                                ""vkCreateImageView() image handle is VK_NULL_HANDLE. Image is either not created or it is destroyed at this point."");
++	}
+     return skip;
+ }
+ ",This test already exists in the object_tracker layer.,Shouldn't this be `VUID-VkImageViewCreateInf
+3759,"@@ -64,7 +64,8 @@ public class EthGetCode extends AbstractBlockParameterOrBlockHashMethod {
+   @Override
+   protected String resultByBlockHash(final JsonRpcRequestContext request, final Hash blockHash) {
+     final Address address = request.getRequiredParameter(0, Address.class);
+-    if (GoQuorumOptions.goQuorumCompatibilityMode && privacyParameters.isPresent()) {
++    final boolean isGoQuorumCompatibilityMode = GoQuorumOptions.goQuorumCompatibilityMode;
++    if (isGoQuorumCompatibilityMode && privacyParameters.isPresent()) {
+       // get from private state if we can
+       final Optional<BlockHeader> blockHeader =
+           blockchainQueries.get().getBlockHeaderByHash(blockHash);","Same here, can we presume if `privacyParameters` is set we need goQuorum handling? Or is there a goQuorum sub option in `privacyParametes`?",nit: `isGoQuorumCompatibilityMode` -> `goQuo
+3760,"@@ -122,6 +122,10 @@ class FastAppend extends SnapshotProducer<AppendFiles> implements AppendFiles {
+   public List<ManifestFile> apply(TableMetadata base) {
+     List<ManifestFile> newManifests = Lists.newArrayList();
+ 
++    if (base.currentSnapshot() != null) {
++      newManifests.addAll(base.currentSnapshot().deleteManifests());
++    }
++
+     try {
+       ManifestFile manifest = writeManifest();
+       if (manifest != null) {",The addition of delete files in `newManifests` far above the addition of data files threw me a bit. Is it intentional to ensure the delete files are at the front of the list?,Why do we need this?
+3761,"@@ -68,7 +68,7 @@ module Bolt
+         # though, since that will resolve any nested references and we want to
+         # leave it to the group to do that lazily.
+         groups = @plugins.resolve_top_level_references(groups)
+-
++        raise ValidationError.new(""Groups must be an Array"", nil) unless groups.is_a?(Array)
+         @groups = Array(groups).map { |g| Group.new(g, plugins) }
+       end
+ ",Interesting. The call to `Array(groups)` below this would seem to indicate this doesn't _have_ to be an array. I think the problem is actually that passing a hash to `Array()` actually converts the hash to an array of key/value pairs rather than wrapping it in an array. So maybe `Array(groups)` should be `groups = [groups] unless groups.is_a?(Array)`.,I don't think this i
+3762,"@@ -140,4 +140,10 @@ public class TableProperties {
+ 
+   public static final String GC_ENABLED = ""gc.enabled"";
+   public static final boolean GC_ENABLED_DEFAULT = true;
++
++  public static final String MAX_SNAPSHOT_AGE_MS = ""history.expire.max-snapshot-age-ms"";
++  public static final long MAX_SNAPSHOT_AGE_MS_DEFAULT = 5 * 24 * 60 * 60 * 1000; // 5 days
++
++  public static final String RETAIN_MIN_NUM_SNAPSHOTS = ""history.expire.retain-min-num-snapshots"";
++  public static final int RETAIN_MIN_NUM_SNAPSHOTS_DEFAULT = 1;
+ }",This is not a particularly good default but we need it to keep the old behavior.,I think this should 
+3763,"@@ -117,13 +117,6 @@ func TestPaymentBrokerRedeemWithCondition(t *testing.T) {
+ 	blockHeightParam := types.NewBlockHeight(43)
+ 	redeemerParams := []interface{}{blockHeightParam}
+ 
+-	sys := setup(t)
+-	require.NoError(t, sys.st.SetActor(context.TODO(), toAddress, actor.NewActor(pbTestActorCid, types.NewZeroAttoFIL())))
+-
+-	callRedeem := func(condition *types.Predicate, params []interface{}) (*consensus.ApplicationResult, error) {
+-		return sys.applySignatureMessage(sys.target, 100, types.NewBlockHeight(0), 0, ""redeem"", 0, condition, params...)
+-	}
+-
+ 	// All the following tests attempt to call PBTestActor.ParamsNotZero with a condition.
+ 	// PBTestActor.ParamsNotZero takes 3 parameter: an Address, a uint64 sector id, and a BlockHeight
+ 	// If any of these are zero values the method throws an error indicating the condition is false.",We have other tests to assert all properties of a condition are valid. It's enough to assert the condition is not nil here.,Why was this test re
+3764,"@@ -30,7 +30,7 @@ import (
+ 
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/config""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/openflow""
+-	opsv1alpha1 ""github.com/vmware-tanzu/antrea/pkg/apis/ops/v1alpha1""
++	opsv1alpha1 ""github.com/vmware-tanzu/antrea/pkg/apis/crd/v1alpha1""
+ 	binding ""github.com/vmware-tanzu/antrea/pkg/ovs/openflow""
+ )
+ ",shouldn't the import be renamed `crdv1alpha1` by convention? It seems that you took care of renaming everywhere else...,I think this should be `crdv1alpha1`
+3765,"@@ -86,6 +86,19 @@ const (
+ 
+ 	// DefaultMinSupportedCNIVersion denotes the minimum version of cni spec required
+ 	DefaultMinSupportedCNIVersion = ""0.3.0""
++
++	// pauseContainerTarball is the path to the pause container tarball
++	pauseContainerTarballPath = ""/images/amazon-ecs-pause.tar""
++)
++
++var (
++	// PauseContainerTag is the tag for the pause container image. The linker's load
++	// flags are used to populate this value from the Makefile
++	PauseContainerTag = """"
++
++	// PauseContainerImageName is the name of the pause container image. The linker's
++	// load flags are used to populate this value from the Makefile
++	PauseContainerImageName = """"
+ )
+ 
+ // Merge merges two config files, preferring the ones on the left. Any nil or",nit: Can Linux-specific paths be moved to a conditionally-compiled file for Linux?,nit: can we call this `PauseContaine
+3766,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+ 
+   public abstract void remove(SessionId id);
+ 
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.,Why is this needed?
+3767,"@@ -279,8 +279,10 @@ func (r *runner) waitForJournal(ctx context.Context) error {
+ // unrecognized attributes are ignored. The list ends with a blank
+ // line.
+ func (r *runner) handleList(ctx context.Context, args []string) (err error) {
+-	if len(args) > 0 {
+-		return errors.New(""Lists for non-fetches unsupported for now"")
++	if len(args) == 1 && args[0] == ""for-push"" {
++		r.log.CDebugf(ctx, ""Treating for-push the same as a regular list"")
++	} else if len(args) > 0 {
++		return errors.Errorf(""Bad list request: %v"", args)
+ 	}
+ 
+ 	repo, err := r.initRepoIfNeeded(ctx)",Git doc seems to suggest `for-push` is a optimization. Do we have a plan/ticket for treating them differently?,I think this should be a warning ins
+3768,"@@ -449,7 +449,8 @@ debug_tls:When 1, print some TLS session secrets when they are computed.
+                    ""mobileip"", ""netbios"", ""netflow"", ""ntp"", ""ppp"", ""pptp"",
+                    ""radius"", ""rip"", ""rtp"", ""skinny"", ""smb"", ""snmp"",
+                    ""tftp"", ""x509"", ""bluetooth"", ""dhcp6"", ""llmnr"",
+-                   ""sctp"", ""vrrp"", ""ipsec"", ""lltd"", ""vxlan"", ""eap""]
++                   ""sctp"", ""vrrp"", ""ipsec"", ""lltd"", ""vxlan"", ""eap"",
++                   ""ltp"", ""bp""]
+     contribs = dict()
+     crypto_valid = isCryptographyValid()
+     crypto_valid_advanced = isCryptographyAdvanced()",This not necessary since you moved the layers to `contrib/`.,I don't think we need to add `bp` here.
+3769,"@@ -1088,7 +1088,7 @@ module Bolt
+       end
+       define('--log-level LEVEL',
+              ""Set the log level for the console. Available options are"",
+-             ""trace, debug, info, warn, error, fatal, any."") do |level|
++             ""trace, debug, info, warn, error, fatal."") do |level|
+         @options[:log] = { 'console' => { 'level' => level } }
+       end
+       define('--clear-cache',","I think this also needs to be removed from `resources/bolt_bash_completion.sh`, `rakelib/pwsh.rake`, `lib/bolt_spec/plans.rb`, and `lib/bolt/config/options.rb`.",Why did you change this?
+3770,"@@ -63,7 +63,7 @@ describe 'PasswordResetsController' do
+       account.update_attribute(:email, 'ThisIsMyAddress@MyDomain.com')
+ 
+       assert_difference(['ActionMailer::Base.deliveries.size'], 1) do
+-        post :create, password_reset: {email: account.email.downcase}
++        post :create, password_reset: { email: account.email.downcase }
+       end
+       must_respond_with :redirect
+       flash[:success].must_equal I18n.t('password_resets.create.success')",I fixed this today with a direct push to master. My build was failing otherwise.,Space inside { missing.<br>Space inside
+3771,"@@ -0,0 +1,16 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.autofix.rule;
++
++import net.sourceforge.pmd.autofix.RuleViolationFix;
++import net.sourceforge.pmd.lang.ast.Node;
++
++public class DeleteRuleViolationFix implements RuleViolationFix {
++
++    @Override
++    public void applyFixesToNode(final Node node) {
++        node.remove();
++    }
++}","not sure why this is in a ""rule"" child package from the interface...",Why is this needed?
+3772,"@@ -19,12 +19,14 @@ class Folder extends BaseItem {
+ 		return {
+ 			id: null,
+ 			title: '',
++			icon: '',
+ 		};
+ 	}
+ 
+ 	static fieldToLabel(field) {
+ 		const fieldsToLabels = {
+ 			title: _('title'),
++			icon: _('icon'),
+ 			last_note_user_updated_time: _('updated date'),
+ 		};
+ ","Not needed, please remove.",Why do we need this?
+3773,"@@ -66,7 +66,7 @@ static h2o_iovec_t rewrite_location(h2o_mem_pool_t *pool, const char *location,
+         goto NoRewrite;
+     if (loc_parsed.scheme != &H2O_URL_SCHEME_HTTP)
+         goto NoRewrite;
+-    if (!h2o_lcstris(loc_parsed.host.base, loc_parsed.host.len, match->host.base, match->host.len))
++    if (!h2o_url_compare_hosts(loc_parsed.host, match->host, match->host_is_unix_path))
+         goto NoRewrite;
+     if (h2o_url_get_port(&loc_parsed) != h2o_url_get_port(match))
+         goto NoRewrite;","Shouldn't the logic be: * the result is a mismatch if either is a unix path but the other is not * if both are unix paths, then perform case-sensitive comparison * if both are not unix paths, then perform case-insensitive comparison",Shouldn't this be `!
+3774,"@@ -11,6 +11,6 @@ import (
+ 	_ ""github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-grpc-gateway""
+ 	_ ""github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2""
+ 	_ ""github.com/shurcooL/vfsgen""
+-	_ ""google.golang.org/protobuf/cmd/protoc-gen-go""
+ 	_ ""google.golang.org/grpc/cmd/protoc-gen-go-grpc""
++	_ ""google.golang.org/protobuf/cmd/protoc-gen-go""
+ )",This is just rearranging it alphabetically,Why this change?
+3775,"@@ -798,6 +798,7 @@ def test_chromium_version_unpatched(qapp):
+     assert version._chromium_version() not in ['', 'unknown', 'unavailable']
+ 
+ 
++# pylint: disable=too-many-locals
+ @pytest.mark.parametrize(['git_commit', 'frozen', 'style', 'with_webkit',
+                           'known_distribution'], [
+     (True, False, True, True, True),  # normal",I think this disables it for the rest of the file - you should be able to use it inside of the function instead.,Why is this needed?
+3776,"@@ -61,9 +61,9 @@ final class MediaExtension extends AbstractExtension
+     }
+ 
+     /**
+-     * @param MediaInterface $media
+-     * @param string         $format
+-     * @param array          $options
++     * @param MediaInterface|int|string $media
++     * @param string                    $format
++     * @param array                     $options
+      *
+      * @return string
+      */","this could receive the MediaInterface directly or an identifier, it is correct to type it with int|string? or just use mixed?",Should be `MediaInterface|null`
+3777,"@@ -89,4 +89,15 @@ final class MultiLeafFieldComparator implements LeafFieldComparator {
+     }
+   }
+ 
++  @Override
++  public Object leafValue(int docID) throws IOException {
++    Object[] valuesArray = new Object[comparators.length];
++
++    for (int i = 0; i < comparators.length; i++) {
++      valuesArray[i] = comparators[i].leafValue(docID);
++    }
++
++    return valuesArray;
++  }
++
+ }",Why not return `Object[]`?,nit: `valuesArray` -> `leafValu
+3778,"@@ -46,12 +46,14 @@ public class GenericManifestFile
+   private String manifestPath = null;
+   private Long length = null;
+   private int specId = -1;
++  private long sequenceNumber = 0;
++  private long minSequenceNumber = 0;
+   private Long snapshotId = null;
+   private Integer addedFilesCount = null;
+-  private Long addedRowsCount = null;
+   private Integer existingFilesCount = null;
+-  private Long existingRowsCount = null;
+   private Integer deletedFilesCount = null;
++  private Long addedRowsCount = null;
++  private Long existingRowsCount = null;
+   private Long deletedRowsCount = null;
+   private List<PartitionFieldSummary> partitions = null;
+ ","Looks like we are trying to match the new ordering of fields in `ManifestFile`. Earlier, we co-located `...FilesCount` with `...RowsCount` to match the ordering of methods in `ManifestFile` and args in constructors. Is this change intentional?",Why do we need to set these to 
+3779,"@@ -933,11 +933,13 @@ void Monster::onThinkDefense(uint32_t interval)
+ 			Monster* summon = Monster::createMonster(summonBlock.name);
+ 			if (summon) {
+ 				const Position& summonPos = getPosition();
+-
+-				addSummon(summon);
+-
++				summon->setDropLoot(false);
++				summon->setLossSkill(false);
++				summon->setMaster(this);
+ 				if (!g_game.placeCreature(summon, summonPos, false, summonBlock.force)) {
+-					removeSummon(summon);
++					summon->setDropLoot(false);
++					summon->setLossSkill(true);
++					summon->setMaster(nullptr);
+ 				} else {
+ 					g_game.addMagicEffect(getPosition(), CONST_ME_MAGIC_BLUE);
+ 					g_game.addMagicEffect(summon->getPosition(), CONST_ME_TELEPORT);",You're already setting drop loot to false just above.,why not just set it to nullptr?
+3780,"@@ -20,6 +20,7 @@ type Management struct {
+ 
+ 	listenerShutdownStarted chan bool
+ 	listenerShutdownWaiter  sync.WaitGroup
++	once                    sync.Once
+ }
+ 
+ type ManagementMiddleware interface {",`once` is very generic and doesn't specify it's purpose - `closeOnce`?,Why do we need this?
+3781,"@@ -79,7 +79,7 @@ public class HiveTableBaseTest extends HiveMetastoreTest {
+     return getTableLocationPath(tableName).toString();
+   }
+ 
+-  private static String metadataLocation(String tableName) {
++  protected static String metadataLocation(String tableName) {
+     return Paths.get(getTableBasePath(tableName), ""metadata"").toString();
+   }
+ ",Why did this need to change from `private`? Oh for the test below. And this is only a test class too.  ,Why do we need this 
+3782,"@@ -0,0 +1,7 @@
++require 'test_helper'
++
++class NotificationAcknowledgementTest < ActiveSupport::TestCase
++  # test ""the truth"" do
++  #   assert true
++  # end
++end",Should test the `has?` method here,Missing space after 
+3783,"@@ -78,7 +78,18 @@ final class SavedSearchesTest extends \VuFindTest\Integration\MinkTestCase
+     public function testSaveSearch()
+     {
+         $page = $this->performSearch('test');
+-        $this->clickCss($page, '.fa.fa-save');
++        $links = $page->findAll('css', '.searchtools a');
++        $saveLink = null;
++        foreach ($links as $link) {
++            if ($this->checkVisibility($link)
++                && str_contains($link->getHtml(), 'Save Search')
++            ) {
++                $saveLink = $link;
++                break;
++            }
++        }
++        $this->assertNotNull($link);
++        $link->click();
+         $this->snooze();
+         $this->clickCss($page, '.createAccountLink');
+         $this->snooze();","I think you want to be asserting/clicking $saveLink, not $link.",I think you can use 
+3784,"@@ -95,6 +95,7 @@ def sensor(
+ def asset_sensor(
+     asset_key: AssetKey,
+     pipeline_name: Optional[str] = None,
++    target_name: Optional[str] = None,
+     name: Optional[str] = None,
+     solid_selection: Optional[List[str]] = None,
+     mode: Optional[str] = None,","We don't have `target_name` on `@sensor` - why introduce it for `@asset_sensor`? If we do want to introduce it everywhere, can we just call it `job_name` to avoid introducing a new term?","I don't think we need to add a new parameter here, we can just use `name`"
+3785,"@@ -0,0 +1,9 @@
++using System.Collections.Generic;
++
++namespace Microsoft.DotNet.Build.Tasks.Feed
++{
++    public class SleetSettings
++    {
++        public List<SleetSource> Sources { get; set; }
++    }
++}",Missing copyright header (+other new files).,Why do we need this?
+3786,"@@ -104,12 +104,7 @@ class TypeToSparkType extends TypeUtil.SchemaVisitor<DataType> {
+         throw new UnsupportedOperationException(
+             ""Spark does not support time fields"");
+       case TIMESTAMP:
+-        Types.TimestampType timestamp = (Types.TimestampType) primitive;
+-        if (timestamp.shouldAdjustToUTC()) {
+-          return TimestampType$.MODULE$;
+-        }
+-        throw new UnsupportedOperationException(
+-            ""Spark does not support timestamp without time zone fields"");
++        return TimestampType$.MODULE$;
+       case STRING:
+         return StringType$.MODULE$;
+       case UUID:","Could we do the flag check here as well to check whether or not we have enabled the ""Handle without timezone"" flag here as well? We may be using this not on the read path (like in the migrate/snapshot code) and it would be good to catch it here as well and make sure users know what is happening.",Why remove this check?
+3787,"@@ -2,7 +2,7 @@ import os
+ from typing import Dict, List
+ 
+ from dagster import SensorDefinition
+-from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext
++from dagster.core.definitions.pipeline_definition_definition_sensor import PipelineFailureSensorContext
+ from dagster_slack import make_slack_on_pipeline_failure_sensor
+ from hacker_news_assets.utils.slack_message import build_slack_message_blocks
+ ",why is the file named `pipeline_definition_definition_sensor`?,Why did you change this?
+3788,"@@ -6,6 +6,10 @@ _ts = None
+ 
+ def init_timescale_connection(logger, conf):
+     global _ts
++
++    if not conf[""SQLALCHEMY_TIMESCALE_URI""]:
++        return None
++
+     while True:
+         try:
+             _ts = TimescaleListenStore(conf, logger)","None not needed, can just be `return`. not important for this release",Why do we need this check?
+3789,"@@ -104,7 +104,12 @@ const topPageTemplate = `
+     <div class=""g-recaptcha"" data-sitekey=""{{.RecaptchaSiteKey}}"">
+     </div>
+     <div>
+-      <input id=""target"" placeholder=""target address"">
++      The dispensed Algos have no monetary value and should only be used to test applications.
++      <p>This service is gracefully provided to enable development on the Algorand blockchain test networks.
++      <p>Please do not abuse it by requesting millions of Algos.
++    </div>
++    <div>
++      <input id=""target"" placeholder=""target address"" size=""80"">
+       <button id=""dispense"">Dispense</button>
+     </div>
+     <div>",I think it's missing closing `</p>` tags in line 108 and 109 unless they don't matter...,I think this should be `<p
+3790,"@@ -579,10 +579,12 @@ public abstract class ProcessEngineConfigurationImpl extends ProcessEngineConfig
+   protected ScriptingEnvironment scriptingEnvironment;
+   protected List<ScriptEnvResolver> scriptEnvResolvers;
+   protected ScriptFactory scriptFactory;
++  protected String scriptEngineNameJavaScript;
+   protected boolean autoStoreScriptVariables = false;
+   protected boolean enableScriptCompilation = true;
+   protected boolean enableScriptEngineCaching = true;
+   protected boolean enableFetchScriptEngineFromProcessApplication = true;
++  protected boolean enableScriptEngineLoadExternalResources = false;
+ 
+   /**
+    * When set to false, the following behavior changes:",So it seems that loading a script file from the classpath needs to be enabled explicitly now since this is `false` by default. Is it possible to enable this via the YAML config file in a Camunda Platform Run distribution?,I think this should be fal
+3791,"@@ -5,8 +5,7 @@
+ const config = require('@purest/providers')
+ const dropbox = require('./dropbox')
+ const drive = require('./drive')
+-const instagram = require('./instagram')
+-const instagramGraph = require('./instagram/graph')
++const instagram = require('./instagram/graph')
+ const facebook = require('./facebook')
+ const onedrive = require('./onedrive')
+ const zoom = require('./zoom')",can we delete any code in the provider implementation? i imagine the entire thing is unused now?,Why did you change this?
+3792,"@@ -148,6 +148,7 @@ func wrapErrorWithClusterIssuerStatusCondition(client clientset.ClusterIssuerInt
+ 
+ // WaitForCertificateCondition waits for the status of the named Certificate to contain
+ // a condition whose type and status matches the supplied one.
++// Deprecated: this function is not used anymore
+ func WaitForCertificateCondition(client clientset.CertificateInterface, name string, condition v1.CertificateCondition, timeout time.Duration) (*v1.Certificate, error) {
+ 	var certificate *v1.Certificate = nil
+ 	pollErr := wait.PollImmediate(500*time.Millisecond, timeout,",I suggest we remove all these unused functions. I don't expect any external projects to be importing packages from `cert-manager/test/...`,This function is not used anymore.
+3793,"@@ -150,15 +150,10 @@ void DataManWriter::MetadataThread(const std::string &address)
+     while (m_Listening)
+     {
+         auto request = tpm.ReceiveRequest();
+-        if (request == nullptr)
++        if (request && request->size() > 0)
+         {
+-            continue;
+-        }
+-        if (request->size() >= 0)
+-        {
+-            m_AggregatedMetadataMutex.lock();
++            std::lock_guard lck(m_AggregatedMetadataMutex);
+             tpm.SendReply(m_AggregatedMetadata);
+-            m_AggregatedMetadataMutex.unlock();
+         }
+     }
+ }",Looks like the template argument doesn't resolve by default so you need `std::lock_guard<std::mutex> lck`,Why did you remove this?
+3794,"@@ -128,12 +128,6 @@ public final class ArrayCreationLevel extends Node implements NodeWithAnnotation
+         return this;
+     }
+ 
+-    @Override
+-    @Generated(""com.github.javaparser.generator.core.node.GetNodeListsGenerator"")
+-    public List<NodeList<?>> getNodeLists() {
+-        return Arrays.asList(getAnnotations());
+-    }
+-
+     @Generated(""com.github.javaparser.generator.core.node.RemoveMethodGenerator"")
+     public ArrayCreationLevel removeDimension() {
+         return setDimension((Expression) null);",Are we removing this public method? Could it be useful to someone? Maybe we could implement it once in Node using the metamodel,Why was this removed?
+3795,"@@ -47,6 +47,10 @@ class Plan < ActiveRecord::Base
+     self == self.class.popular
+   end
+ 
++  def includes_exercises?
++    sku != THE_WEEKLY_ITERATION_SKU
++  end
++
+   def subscription_interval
+     stripe_plan.interval
+   end",I think this method is unused now?,I don't think we need this method.
+3796,"@@ -115,6 +115,11 @@ func run(o *Options) error {
+ 		appliedToGroupStore,
+ 		networkPolicyStore)
+ 
++	var networkPolicyStatusController *networkpolicy.StatusController
++	if features.DefaultFeatureGate.Enabled(features.AntreaPolicy) {
++		networkPolicyStatusController = networkpolicy.NewStatusController(crdClient, networkPolicyStore, cnpInformer, anpInformer)
++	}
++
+ 	endpointQuerier := networkpolicy.NewEndpointQuerier(networkPolicyController)
+ 
+ 	controllerQuerier := querier.NewControllerQuerier(networkPolicyController, o.config.APIPort)",I know we discussed this before and decided to reuse the AntreaPolicy gate. But do you think realization status will introduce much overhead or not?,I don't think we need to create a new controller if the feature gate is not enabled.
+3797,"@@ -0,0 +1,11 @@
++package constants
++
++const (
++	RunController = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/cloud/; sudo nohup ./edgecontroller > edgecontroller.log 2>&1 &""
++	RunEdgecore   = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/edge/; sudo nohup ./edge_core > edge_core.log 2>&1 &""
++	RunEdgeSite   = ""cd ${GOPATH}/src/github.com/kubeedge/kubeedge/edgesite/; sudo nohup ./edgesite > edgesite.log 2>&1 &""
++
++	AppHandler        = ""/api/v1/namespaces/default/pods""
++	NodeHandler       = ""/api/v1/nodes""
++	DeploymentHandler = ""/apis/apps/v1/namespaces/default/deployments""
++)",please add a blank line at the end of this file. Applicable to similar cases below,Why do we need this?
+3798,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+ 
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression.",Shouldn't this be `remoteHost = pendingConfiguration.remoteHost`?
+3799,"@@ -588,6 +588,10 @@ class JoinQuery extends Query {
+             // use the filterCache to get a DocSet
+             if (toTermsEnum.docFreq() >= minDocFreqTo || resultBits == null) {
+               // use filter cache
++              if (! toSearcher.getFilterCache().isAsync()) {
++                throw new SolrException(SolrException.ErrorCode.INVALID_STATE,
++                    ""Using join queries with synchronous filterCache is not supported! Details can be found in Solr Reference Guide under 'query-settings-in-solrconfig'."");
++              }
+               DocSet toTermSet = toSearcher.getDocSet(toDeState);
+               resultListDocs += toTermSet.size();
+               if (resultBits != null) {",filterCache can be null,I don't think this is the right place to throw this exception. It should be in the `
+3800,"@@ -10,6 +10,7 @@ import (
+ 	""bytes""
+ 	""context""
+ 	""encoding/hex""
++	""github.com/iotexproject/iotex-core/db""
+ 	""sync""
+ 	""time""
+ ",File is not `goimports`-ed (from `goimports`),import (
+3801,"@@ -375,6 +375,8 @@ const char *get_parameter(char *cmd, SERVER_CONN *server_conn) {
+ const char *set_parameter(char *cmd, SERVER_CONN *server_conn, CLIENT_CONN *client_conn) {
+     const char *param_name = strstr(cmd, SET_PARAM_CMD) + SET_PARAM_CMD_LEN;
+     const char *param_value;
++    if (!param_name)
++	return SET_PARAM_CMD_FAIL_RSP;
+     if (strstr(param_name, SERVER_LOOPBACK_MODE_PARAM) == param_name) {
+         param_value = param_name + SERVER_LOOPBACK_MODE_PARAM_LEN;
+         if (strnlen(param_value, 1) == 1) {","If strstr returns NULL, the check on 378 won't fire, because param_name will be at least SET_PARAM_CMD_LEN.",Shouldn'
+3802,"@@ -47,13 +47,12 @@ services::Status buildProgram(ClKernelFactoryIface & kernelFactory, const TypeId
+     return status;
+ }
+ 
+-services::Status sum_singlepass(ExecutionContextIface & context, ClKernelFactoryIface & kernelFactory, Layout vectorsLayout,
+-                                const UniversalBuffer & vectors, uint32_t nVectors, uint32_t vectorSize, uint32_t workItemsPerGroup,
+-                                SumReducer::Result & result)
++services::Status sum_singlepass(ExecutionContextIface & context, ClKernelFactoryIface & kernelFactory, const UniversalBuffer & vectors,
++                                uint32_t nVectors, uint32_t vectorSize, SumReducer::Result & result)
+ {
+     services::Status status;
+ 
+-    auto sum_kernel = kernelFactory.getKernel(""sum_singlepass"", status);
++    auto sum_kernel = kernelFactory.getKernel(""sum_singlesubgroup"", status);
+     DAAL_CHECK_STATUS_VAR(status);
+ 
+     // no need to check overflow for nVectors * vectorSize due to we already have buffer vectors of such size","Does this change affect the performance of other algorithms, except KMeans?",Why do w
+3803,"@@ -142,13 +142,13 @@ func TestListenerAddrEqual(t *testing.T) {
+ 		addr   string
+ 		expect bool
+ 	}{
+-		{ln1, "":1234"", false},
+-		{ln1, ""0.0.0.0:1234"", false},
++		{ln1, "":"" + ln2port, false},
++		{ln1, ""0.0.0.0:"" + ln2port, false},
+ 		{ln1, ""0.0.0.0"", false},
+ 		{ln1, "":"" + ln1port, true},
+ 		{ln1, ""0.0.0.0:"" + ln1port, true},
+ 		{ln2, "":"" + ln2port, false},
+-		{ln2, ""127.0.0.1:1234"", false},
++		{ln2, ""127.0.0.1:"" + ln1port, false},
+ 		{ln2, ""127.0.0.1"", false},
+ 		{ln2, ""127.0.0.1:"" + ln2port, true},
+ 	} {",What do these changes have to do with the request ID?,Why this
+3804,"@@ -48,11 +48,11 @@
+ #include <cstdio>
+ #include <cstdlib>
+ 
+-typedef Kokkos::DefaultExecutionSpace Device;
+-typedef Kokkos::HostSpace::execution_space Host;
++using Device = Kokkos::DefaultExecutionSpace;
++using Host   = Kokkos::HostSpace::execution_space;
+ 
+-typedef Kokkos::TeamPolicy<Device> team_policy;
+-typedef team_policy::member_type team_member;
++using team_policy = Kokkos::TeamPolicy<Device>;
++using team_member = team_policy::member_type;
+ 
+ static const int TEAM_SIZE = 16;
+ ",I'm kind of surprised this doesn't require `typename`?,Why did you change this?
+3805,"@@ -17,6 +17,7 @@
+ package agreement
+ 
+ import (
++	""github.com/algorand/go-algorand/logging""
+ 	""time""
+ 
+ 	""github.com/algorand/go-algorand/config""",nit: move this one down.,nit: remove empty line
+3806,"@@ -137,8 +137,14 @@ class Bars(Chart):
+ 
+ class BoxWhisker(Chart):
+     """"""
+-    BoxWhisker represent data as a distributions highlighting
+-    the median, mean and various percentiles.
++    BoxWhisker allows representing the distribution of data grouped
++    into one or more groups by summarizing the data using quartiles.
++    The boxes of a BoxWhisker element represent the first, second and
++    third quartiles. The whiskers follow the Tukey boxplot definition
++    representing the lowest datum still within 1.5 IQR of the lower
++    quartile, and the highest datum still within 1.5 IQR of the upper
++    quartile. Any points falling outside this range are shown as
++    distinct outlier points.
+     """"""
+ 
+     group = param.String(default='BoxWhisker', constant=True)",maybe 'standard Tukey boxplot definition' if it is standard? Otherwise sounds like it is just *a* definition for boxplots...,I think it would be bett
+3807,"@@ -55,9 +55,11 @@ var (
+ 	// NOTE: The $Format strings are replaced during 'git archive' thanks to the
+ 	// companion .gitattributes file containing 'export-subst' in this same
+ 	// directory.  See also https://git-scm.com/docs/gitattributes
+-	gitVersion   = ""v0.0.0-master+$Format:%h$""
++	gitVersion   = Default
+ 	gitCommit    = ""$Format:%H$"" // sha1 from git, output of $(git rev-parse HEAD)
+ 	gitTreeState = """"            // state of git tree, either ""clean"" or ""dirty""
+ 
+ 	buildDate = ""1970-01-01T00:00:00Z"" // build date in ISO8601 format, output of $(date -u +'%Y-%m-%dT%H:%M:%SZ')
+ )
++
++const Default = ""v1.9.0""",I feel we should not fix this.,I don't think we need th
+3808,"@@ -25,9 +25,9 @@
+ #include <fastdds/rtps/reader/RTPSReader.h>
+ #include <fastdds/rtps/writer/RTPSWriter.h>
+ 
+-#include <fastdds/rtps/transport/UDPv4Transport.h>
+-#include <fastdds/rtps/transport/UDPv6Transport.h>
+-#include <fastdds/rtps/transport/test_UDPv4Transport.h>
++#include <rtps/transport/UDPv4Transport.h>
++#include <rtps/transport/UDPv6Transport.h>
++#include <rtps/transport/test_UDPv4Transport.h>
+ 
+ #include <fastrtps/xmlparser/XMLProfileManager.h>
+ ",I think these are not necessary,Why is this header needed?
+3809,"@@ -476,7 +476,8 @@ Cross-TU analysis. By default, no CTU analysis is run when
+                               action='store_true',
+                               dest='ctu_reanalyze_on_failure',
+                               default=argparse.SUPPRESS,
+-                              help=""If Cross-TU analysis is enabled and fails ""
++                              help=""DEPRECATED. The flag will be removed. ""
++                                   ""If Cross-TU analysis is enabled and fails ""
+                                    ""for some reason, try to re analyze the ""
+                                    ""same translation unit without ""
+                                    ""Cross-TU enabled."")",Please update the user guide too.,I don't think we need to d
+3810,"@@ -459,8 +459,9 @@ class Folio extends AbstractAPI implements
+             foreach ($this->getPagedResults(
+                 'locations', '/locations'
+             ) as $location) {
+-                $locationMap[$location->id]
+-                    = $location->discoveryDisplayName ?? $location->name;
++                $name = $location->discoveryDisplayName ?? $location->name;
++                $code = $location->code;
++                $locationMap[$location->id] = [$name, $code];
+             }
+         }
+         $this->putCachedData($cacheKey, $locationMap);","If you use `compact('name', 'code')` here, you'll get an associative array, which might make the rest of the code more readable (instead of using hard-coded 0/1 indexes).",I'm not sure if this is th
+3811,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright (c) 2011, salesforce.com, inc.
++ * Copyright (c) 2014, salesforce.com, inc.
+  * All rights reserved.
+  * Redistribution and use of this software in source and binary forms, with or
+  * without modification, are permitted provided that the following conditions",Should it be 2011-14 instead ;-),Why did you change the yea
+3812,"@@ -51,6 +51,10 @@ func New(cfg *any.Any, logger *zap.Logger, scope tally.Scope) (service.Service,
+ 		return nil, err
+ 	}
+ 
++	if pgcfg.MaxIdleConnections > 2 {
++		sqlDB.SetMaxIdleConns(int(pgcfg.MaxIdleConnections))
++	}
++
+ 	return &client{logger: logger, scope: scope, sqlDB: sqlDB}, nil
+ }
+ ",I want to write some type of test for this but there are not Getter methods to assert this value. I tried to extract the value via the stats that are exposed without luck.,Why do we need this?
+3813,"@@ -574,6 +574,15 @@ class ApiClient(object):
+             group_key (str): key of the group to get.
+         """"""
+ 
++    @abc.abstractmethod
++    def iter_gsuite_group_settings(self, gsuite_id):
++        """"""Iterate Gsuite group settings from GCP API.
++
++        Args:
++            gsuite_id (str): Gsuite id.
++        """"""
++
++
+     @abc.abstractmethod
+     def iter_gsuite_groups(self, gsuite_id):
+         """"""Iterate Gsuite groups from GCP API.","This needs to take the group id, not the gsuite id.",Why do we need this 
+3814,"@@ -47,8 +47,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+         }
+ 
+         private const string EmptyResult = @""{
+-  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0-beta.5"""",
+-  """"version"""": """"1.0.0-beta.5"""",
++  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0"""",
++  """"version"""": """"1.0.0"""",
+   """"runs"""": [
+     {
+       """"tool"""": {",These should use the constants defined in JsonTests.cs,Why are we changing 
+3815,"@@ -67,7 +67,7 @@ function DashboardClicksWidget() {
+ 
+ 	if ( error ) {
+ 		trackEvent( 'plugin_setup', 'search_console_error', error.message );
+-		return getDataErrorComponent( __( 'Search Console', 'google-site-kit' ), error.message );
++		return getDataErrorComponent( 'search-console', error );
+ 	}
+ 
+ 	if ( ! data || ! data.length ) {","Kind of unrelated to this PR, but let's update this to `getDataErrorComponent( 'search-console', error.message, false, false, false, error )` so that everything is passed as expected.",I think this should 
+3816,"@@ -38,6 +38,15 @@ class LoadImageFromFile(object):
+         self.file_client = None
+ 
+     def __call__(self, results):
++        """"""Call functions to load image and get image meta information.
++
++        Args:
++            results (dict): Result dict from :obj:`dataset`.
++
++        Returns:
++            dict: The dict contains loaded image and meta information.
++        """"""
++
+         if self.file_client is None:
+             self.file_client = mmcv.FileClient(**self.file_client_args)
+ ",:obj:\`dataset\` cannot be correctly rendered,Can you add a short description of the return value?
+3817,"@@ -28,4 +28,10 @@ module Blacklight::User
+   def existing_bookmark_for(document)
+     bookmarks_for_documents([document]).first
+   end
++
++  ##
++  # @return [String] a user-displayable login/identifier for the user account
++  def to_s
++    email
++  end
+ end","I think `email` is something we get from devise, and I think the goal of putting it in the generator was not to tie others to that particular implementation?",I think this should be `to_s`
+3818,"@@ -108,15 +108,16 @@ func NewBatchSpanProcessor(e export.SpanBatcher, opts ...BatchSpanProcessorOptio
+ 	bsp.stopWait.Add(1)
+ 	go func(ctx context.Context) {
+ 		defer ticker.Stop()
++		batch := make([]*export.SpanData, 0, bsp.o.MaxExportBatchSize)
+ 		for {
+ 			select {
+ 			case <-bsp.stopCh:
+-				bsp.processQueue()
++				bsp.processQueue(&batch)
+ 				close(bsp.queue)
+ 				bsp.stopWait.Done()
+ 				return
+ 			case <-ticker.C:
+-				bsp.processQueue()
++				bsp.processQueue(&batch)
+ 			}
+ 		}
+ 	}(context.Background())","If the span producers pushing to the queue do so faster than the this can drain, it will cause this to hang. I'm guessing we can update the `enqueue` method to check if the `stopCh` is closed and not send any more spans while this flushes what has already been pushed.",Why do we need to create a new slice here?
+3819,"@@ -106,9 +106,9 @@ abstract class Gallery implements GalleryInterface
+         return $this->defaultFormat;
+     }
+ 
+-    final public function setGalleryItems(Collection $galleryItems): void
++    final public function setGalleryItems(iterable $galleryItems): void
+     {
+-        $this->galleryItems = new ArrayCollection();
++        $this->galleryItems->clear();
+ 
+         foreach ($galleryItems as $galleryItem) {
+             $this->addGalleryItem($galleryItem);","Not sure about that, an array is iterable right? But if I pass array, that clear method wont work",This is a BC break.
+3820,"@@ -6,9 +6,14 @@ import (
+ 	""crypto/x509""
+ 	""crypto/x509/pkix""
+ 	""encoding/pem""
++	""fmt""
++	""io/ioutil""
++	""path/filepath""
++	""sync""
+ 	""testing""
+ 
+-	""github.com/spiffe/sri/pkg/server/ca""
++	""github.com/spiffe/go-spiffe""
++	iface ""github.com/spiffe/sri/pkg/common/plugin""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ ","make sure the config changes stuck. are there any invalid config values? maybe write tests around empty `trust_domain`, negative/missing `ttl`, invalid `key_size`, etc...",Why is this needed?
+3821,"@@ -5,7 +5,7 @@ var WebDriver = require('selenium-webdriver');
+ 
+ module.exports = function(grunt) {
+ 	/**
+-	 * Keep injecting scripts until window.mochaResults is set
++	 * Keep injecting scripts until `window.__mochaResult__` is set
+ 	 */
+ 	function collectTestResults(driver) {
+ 		// inject a script that waits half a second",Why are you changing this?,I think this should
+3822,"@@ -29,6 +29,10 @@ module Ncr
+     validates :expense_type, inclusion: {in: EXPENSE_TYPES}, presence: true
+     validates :vendor, presence: true
+     validates :building_number, presence: true
++    validates :rwa_number, format: {
++      with: /[a-zA-Z][0-9]{7}/,
++      message: ""one letter followed by 7 numbers""
++    }, allow_blank: true
+     # TODO validates :proposal, presence: true
+ 
+     def set_defaults","@phirefly Can we look at a list of RWAs, or ask someone to double-check that this format is correct? Otherwise :shipit:",I don't think we ne
+3823,"@@ -72,6 +72,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy {
+           .format(""iceberg"")
+           .option(SparkWriteOptions.REWRITTEN_FILE_SCAN_TASK_SET_ID, groupID)
+           .option(SparkWriteOptions.TARGET_FILE_SIZE_BYTES, writeMaxFileSize())
++          .option(SparkWriteOptions.DISTRIBUTION_MODE, ""none"")
+           .mode(""append"")
+           .save(table.name());
+ ",Still request a local sort for bin-packing based on the defined table sort order.,Why is this `none`?
+3824,"@@ -151,13 +151,16 @@ def request_model(rank, itr, lmbda, alpha):
+ @click.option(""--days"", type=int, default=7, help=""Request recommendations to be generated on history of given number of days"")
+ @click.option(""--top"", type=int, default=20, help=""Calculate given number of top artist."")
+ @click.option(""--similar"", type=int, default=20, help=""Calculate given number of similar artist."")
+-def request_candidate_sets(days, top, similar):
++@click.option(""--user-id"", ""users"", callback=parse_list, default=[], multiple=True,
++                                    help=""Generate candidate set for given users. Generate for all active users by default."")
++def request_candidate_sets(days, top, similar, users):
+     """""" Send the cluster a request to generate candidate sets.
+     """"""
+     params = {
+         'recommendation_generation_window': days,
+         ""top_artist_limit"": top,
+         ""similar_artist_limit"": similar,
++        ""users"": users
+     }
+     send_request_to_spark_cluster(_prepare_query_message('cf_recording.recommendations.candidate_sets', params=params))
+ ","As with the other PR, user name is better.",nit: `users` -> `user_ids`
+3825,"@@ -125,6 +125,12 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount uint64) er
+ 	if err != nil {
+ 		return err
+ 	}
++
++	balance, err := s.chequebook.AvailableBalance(ctx)
++	if err != nil {
++		return err
++	}
++	s.metrics.AvailableBalance.Set(float64(balance.Int64()))
+ 	s.metrics.TotalSent.Add(float64(amount))
+ 	return nil
+ }",a peer's accounting lock is held during `Pay`. we should avoid adding additional blockchain calls here if possible.,Shouldn't this be `s.metri
+3826,"@@ -66,6 +66,12 @@ module.exports = function(realmConstructor) {
+ 
+         setConstructorOnPrototype(realmConstructor.Sync.User);
+         setConstructorOnPrototype(realmConstructor.Sync.Session);
++    } else {
++        Object.defineProperty(realmConstructor, 'Sync', {
++            get: function () {
++                throw new Error(""Sync is not enabled. Note that the developer edition of the Node.JS SDK for Realm does not include sync on Linux."");
++            }
++        })
+     }
+ 
+     // TODO: Remove this now useless object.","Maybe wording could be improved. Is this ""not enabled"" or it is ""not available"". Not sure about that.",I think we can remove this
+3827,"@@ -120,7 +120,11 @@ func (it *TaskReconciler) Reconcile(ctx context.Context, request reconcile.Reque
+ 
+ 	// update the status about conditional tasks
+ 	if len(pods) > 0 && (pods[0].Status.Phase == corev1.PodFailed || pods[0].Status.Phase == corev1.PodSucceeded) {
+-		if !conditionalBranchesEvaluated(node) {
++		evaluated, err := it.conditionalBranchesEvaluated(ctx, node)
++		if err != nil {
++			return reconcile.Result{}, err
++		}
++		if !evaluated {
+ 			it.eventRecorder.Event(&node, recorder.TaskPodPodCompleted{PodName: pods[0].Name})
+ 			// task pod is terminated
+ 			updateError := retry.RetryOnConflict(retry.DefaultRetry, func() error {",I looked at the new `conditionalBranchesEvaluated` function and it looks like the part added is a duplicate of the line above?,I think this should be `re
+3828,"@@ -53,6 +53,9 @@ import (
+ //           May be missing, but should be present when data is.
+ //   - refs: The list of references to the block, encoded as a serialized
+ //           blockRefInfo. May be missing.
++//   - f:    Presence of this file indicates the block has been successfully
++//           flushed to the server.  However, the data might still be
++//           in the store.
+ //
+ // Future versions of the disk store might add more files to this
+ // directory; if any code is written to move blocks around, it should","can you put this flag in `blockRefInfo` instead? It would be a shame to add one more file per block, especially since we've run into inode limits. I guess `blockRefInfo` should maybe then be renamed to `blockInfo` or something. But we're stuck with the filename.",I'm not sure if this is the right place to put this information. It seems like it should be in the `blockRefInfo`.
+3829,"@@ -43,5 +43,9 @@ func (c *ConsumerConfigParser) Parse(config json.RawMessage) (ip string, port in
+ 	if err != nil {
+ 		return """", 0, """", errors.Wrap(err, ""parsing consumer address:port failed"")
+ 	}
+-	return cfg.IP, cfg.Port, openvpn.ServiceType, nil
++
++	if cfg.IP == nil {
++		return """", 0, """", nil
++	}
++	return *cfg.IP, cfg.Port, openvpn.ServiceType, nil
+ }",Shouldn't we keep other parameters if only IP is empty? Or maybe return an error if it's a mandatory argument?,Why do we need this check?
+3830,"@@ -118,7 +118,8 @@ class NdIndexableMappingTest(ComparisonTestCase):
+         data = [((0, 0.5), 'a'), ((1, 0.5), 'b')]
+         ndmap = MultiDimensionalMapping(data, kdims=[self.dim1, self.dim2])
+         redimmed = ndmap.redim(intdim='Integer')
+-        self.assertEqual(redimmed.kdims, [Dimension('Integer'), Dimension('floatdim')])
++        self.assertEqual(redimmed.kdims, [Dimension('Integer', type=int),
++                                          Dimension('floatdim', type=float)])
+ 
+     def test_idxmapping_add_dimension(self):
+         ndmap = MultiDimensionalMapping(self.init_items_1D_list, kdims=[self.dim1])",Was this just wrong before? The names indicated types but type wasn't specified. I guess the tests passed as comparison worked with ``type=None``?,Why did you change this?
+3831,"@@ -146,7 +146,8 @@ public class OrcMetrics {
+       if (icebergColOpt.isPresent()) {
+         final Types.NestedField icebergCol = icebergColOpt.get();
+         final int fieldId = icebergCol.fieldId();
+-        final MetricsMode metricsMode = effectiveMetricsConfig.columnMode(icebergCol.name());
++        final String colName = schema.findColumnName(icebergCol.fieldId());
++        final MetricsMode metricsMode = effectiveMetricsConfig.columnMode(colName);
+ 
+         columnSizes.put(fieldId, colStat.getBytesOnDisk());
+ ",icebergCol.name() is the unqualified column name,nit: can we rename this to `columnName`?
+3832,"@@ -45,7 +45,7 @@ class MetricAlarm(object):
+     def __init__(self, connection=None, name=None, metric=None,
+                  namespace=None, statistic=None, comparison=None, threshold=None,
+                  period=None, evaluation_periods=None, unit=None, description='',
+-                 dimensions=[]):
++                 dimensions=[], alarm_actions=[], insufficient_data_actions=[], ok_actions=[]):
+         """"""
+         Creates a new Alarm.
+ ","It's generally a bad idea to use mutable types like lists as default values for parameters. Lots of strange, difficult to debug side effects can occur. I see that there was already one example of this prior to this commit which probably explains why it seemed innocuous to add more but I'm going to rework this before committing to master.",This is a breaking change. We need to keep the old signature.
+3833,"@@ -10,6 +10,7 @@ module.exports = {
+     'prettier',
+     'prettier/@typescript-eslint',
+     'plugin:prettier/recommended',
++    'eslint-config-prettier'
+   ],
+   globals: {
+     Atomics: 'readonly',","We run prettier as an eslint plugin, so this harmful",I think this should be `plugin:prettier/recommended`
+3834,"@@ -39,7 +39,7 @@ using namespace eprosima::fastrtps::types;
+ HelloWorldPublisher::HelloWorldPublisher()
+     : mp_participant(nullptr)
+     , mp_publisher(nullptr)
+-    , m_DynType(nullptr)
++    , m_DynType(DynamicType_ptr(nullptr))
+ {
+ }
+ ",Check if the TypeDescriptor and MemberDescriptor includes are necessary,Why is this needed?
+3835,"@@ -4,10 +4,11 @@ import (
+ 	gocontext ""context""
+ 	""encoding/json""
+ 	""fmt""
+-	""k8s.io/apimachinery/pkg/api/errors""
+ 	""os""
+ 	""syscall""
+ 
++	""k8s.io/apimachinery/pkg/api/errors""
++
+ 	corev1 ""k8s.io/api/core/v1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/types""",delete the empty line here.,nit: remove empty line
+3836,"@@ -302,6 +302,16 @@ describe Subscription do
+     end
+   end
+ 
++  describe ""#reactivate"" do
++    it ""unsets scheduled_for_deactivation_on"" do
++      subscription = create(:subscription, scheduled_for_deactivation_on: 1.day.from_now)
++      subscription.reactivate
++      subscription.reload
++
++      expect(subscription.scheduled_for_deactivation_on).to be_nil
++    end
++  end
++
+   def setup_cutomer
+     stripe_customer = double(
+       ""StripeCustomer"",",Line is too long. [89/80],I don't think you need to reload here.
+3837,"@@ -200,7 +200,7 @@ public class JsonHttpRemoteConfig {
+     }
+   }
+ 
+-  private UrlMapper getUrlMapper(String method) {
++  protected UrlMapper getUrlMapper(String method) {
+     if (""DELETE"".equals(method)) {
+       return deleteMapper;
+     } else if (""GET"".equals(method)) {","You don't need to expose this method to do what you want. There are already public addNewGetMapping, addNewPostMapping, and addNewDeleteMapping methods.",Why do we need this change?
+3838,"@@ -782,7 +782,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+         }
+ 
+         [Fact]
+-        public async Task HeadResponseCanContainContentLengthHeaderButBodyNotWritten()
++        public async Task HeadResponseBodyNotWritten()
+         {
+             using (var server = new TestServer(async httpContext =>
+             {",This test passes in `dev`. Why wouldn't this work?,Why was this changed?
+3839,"@@ -1,6 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX-License-Identifier: Apache-2.0
+ 
++""""""
++Purpose
++
++Shows how to use the AWS SDK for Python (Boto3) with PyTest and the AWS Device Farm
++browser testing feature.
++""""""
++
++# snippet-start:[python.example_code.device-farm.Scenario_BrowserTesting]
+ import datetime
+ import os
+ import subprocess",ARN -> Amazon Resource Number (ARN),I think we can remove this line.
+3840,"@@ -153,10 +153,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+ 
+             var hostBuilder = new WebHostBuilder()
+                .UseKestrel()
+-               .ConfigureServices(services =>
+-               {
+-                   services.AddSingleton<ILoggerFactory>(new KestrelTestLoggerFactory(testLogger));
+-               })
++               .UseLoggerFactory(_ => new KestrelTestLoggerFactory(testLogger))
+                .Configure(ConfigureEchoAddress);
+ 
+             using (var host = hostBuilder.Build())",Why not use the overload that takes an instance?,Why this change?
+3841,"@@ -7,16 +7,13 @@
+ package account
+ 
+ import (
+-	""context""
+ 	""fmt""
++	""strings""
+ 
+ 	""github.com/spf13/cobra""
+ 	""go.uber.org/zap""
+-	grpc ""google.golang.org/grpc""
+ 
+-	""github.com/iotexproject/iotex-core/cli/ioctl/cmd/config""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+-	pb ""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ )
+ 
+ // TODO: use wallet config later",`Blockchian` is a misspelling of `Blockchain` (from `misspell`),Why is this bein
+3842,"@@ -44,7 +44,7 @@ type NvidiaGPUManager struct {
+ 	DriverVersion string                `json:""DriverVersion""`
+ 	GPUIDs        []string              `json:""GPUIDs""`
+ 	GPUDevices    []*ecs.PlatformDevice `json:""-""`
+-	lock          sync.RWMutex          `json:""-""`
++	lock          sync.RWMutex
+ }
+ 
+ const (",`agent/gpu/nvidia_gpu_manager_unix.go:47: struct field lock has json tag but is not exported`,Why remove the j
+3843,"@@ -11,6 +11,9 @@ from localstack.utils.aws.aws_models import LambdaFunction
+ from localstack.constants import LAMBDA_TEST_ROLE
+ 
+ 
++TEST_ARN = 'arn:aws:sqs:eu-west-1:000000000000:testq'
++
++
+ class TestLambdaAPI(unittest.TestCase):
+     CODE_SIZE = 50
+     CODE_SHA_256 = '/u60ZpAA9bzZPVwb8d4390i5oqP1YAObUwV03CZvsWA='",nit: better rename to `TEST_QUEUE_ARN` or `TEST_EVENT_SOURCE_ARN`,Why do we need t
+3844,"@@ -1097,9 +1097,9 @@ func (c *Operator) sync(key string) error {
+ 		return err
+ 	}
+ 
+-	// If no service monitor selectors are configured, the user wants to
+-	// manage configuration themselves.
+-	if p.Spec.ServiceMonitorSelector != nil {
++	// If no service monitor selectors or additional scrape configs are configured,
++	// the user wants to manage configuration themselves.
++	if p.Spec.ServiceMonitorSelector != nil || p.Spec.AdditionalScrapeConfigs != nil {
+ 		// We just always regenerate the configuration to be safe.
+ 		if err := c.createOrUpdateConfigurationSecret(p, ruleConfigMapNames); err != nil {
+ 			return errors.Wrap(err, ""creating config failed"")",Would this mean that podMonitorSelectors suffer from the same issue if they are the only configuration set?,"I don't think we need to check for `AdditionalScrapeConfigs` here, since we already check for `ServiceMonitorSelector`."
+3845,"@@ -110,6 +110,17 @@ func (c *fakeClient) ReportPipedMeta(ctx context.Context, req *pipedservice.Repo
+ 	return &pipedservice.ReportPipedMetaResponse{}, nil
+ }
+ 
++// GetEnvironment finds and returns the environment for the specified ID.
++func (c *fakeClient) GetEnvironment(ctx context.Context, req *pipedservice.GetEnvironmentRequest, opts ...grpc.CallOption) (*pipedservice.GetEnvironmentResponse, error) {
++	c.logger.Info(""fake client received GetEnvironment rpc"", zap.Any(""request"", req))
++	return &pipedservice.GetEnvironmentResponse{
++		Environment: &model.Environment{
++			Id:   ""dev"",
++			Name: ""dev"",
++		},
++	}, nil
++}
++
+ // ListApplications returns a list of registered applications
+ // that should be managed by the requested piped.
+ // Disabled applications should not be included in the response.",`ctx` is unused in GetEnvironment,Why do we need this?
+3846,"@@ -89,6 +89,11 @@ namespace pwiz.Skyline.FileUI
+             }
+         }
+ 
++        public void OKDialog()
++        {
++            DialogResult = DialogResult.OK;
++        }
++
+         private void cbShowText_CheckedChanged(object sender, System.EventArgs e)
+         {
+             LineText.Visible = cbShowText.Checked;",We usually use OkDialog(),Why is this needed?
+3847,"@@ -970,6 +970,12 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       description = ""Enable flexible (onchain) privacy groups (default: ${DEFAULT-VALUE})"")
+   private final Boolean isFlexiblePrivacyGroupsEnabled = false;
+ 
++  @Option(
++      names = {""--privacy-unrestricted-enabled""},
++      description =
++          ""Enable unrestricted (stores payload onchain) privacy (default: ${DEFAULT-VALUE})"")
++  private final Boolean isUnrestrictedPrivacyEnabled = false;
++
+   @Option(
+       names = {""--target-gas-limit""},
+       description =","could we please change that to something that indicates that this feature is not ""production"" ready!",This should be `--privacy-unrestricted-enabled`.
+3848,"@@ -0,0 +1,5 @@
++_base_ = './mask_rcnn_swim-t-p4-w7_fpn_fp16_ms-crop-3x_coco.py'
++model = dict(
++    pretrained=\
++    'https://download.openmmlab.com/mmclassification/v0/swin-transformer/swin_small_224_b16x64_300e_imagenet_20210615_110219-7f9d988b.pth',  # noqa
++    backbone=dict(depths=[2, 2, 18, 2]))",swim -> swin. Other configs and file names also should be modified.,I don't think you need the `# noqa`
+3849,"@@ -47,7 +47,7 @@ class BigQueryClient(_base_client.BaseClient):
+         return RateLimiter(FLAGS.max_bigquery_api_calls_per_100_seconds,
+                            self.DEFAULT_QUOTA_TIMESPAN_PER_SECONDS)
+ 
+-    def get_bigquery_projectids(self):
++    def get_bigquery_projectids(self, key='projects'):
+         """"""Request and page through bigquery projectids.
+ 
+         Returns: A list of project_ids enabled for bigquery.","nit: arg description for ""key""?",I don't think you need the `key` ar
+3850,"@@ -244,6 +244,15 @@ func (tlf *TLF) Setattr(ctx context.Context, req *fuse.SetattrRequest, resp *fus
+ 	return dir.Setattr(ctx, req, resp)
+ }
+ 
++// Fsync implements the fs.NodeFsyncer interface for TLF.
++func (tlf *TLF) Fsync(ctx context.Context, req *fuse.FsyncRequest) (err error) {
++	dir, err := tlf.loadDir(ctx)
++	if err != nil {
++		return err
++	}
++	return dir.Fsync(ctx, req)
++}
++
+ var _ fs.Handle = (*TLF)(nil)
+ 
+ var _ fs.NodeOpener = (*TLF)(nil)","If we don't have a `dir` yet, we wouldn't need to do a sync right? If so, perhaps we can just `getStoredDir()` like `Attr()`?",I don't think we need this anymore.
+3851,"@@ -1637,10 +1637,13 @@ privload_mem_is_elf_so_header(byte *mem)
+     /* libdynamorio should be ET_DYN */
+     if (elf_hdr->e_type != ET_DYN)
+         return false;
+-    /* ARM or X86 */
++        /* ARM or X86 */
++#        ifndef DR_HOST_NOT_TARGET
+     if (elf_hdr->e_machine !=
+-        IF_X86_ELSE(IF_X64_ELSE(EM_X86_64, EM_386), IF_X64_ELSE(EM_AARCH64, EM_ARM)))
++        IF_HOST_X86_ELSE(IF_HOST_X64_ELSE(EM_X86_64, EM_386),
++                         IF_HOST_X64_ELSE(EM_AARCH64, EM_ARM)))
+         return false;
++#        endif
+     if (elf_hdr->e_ehsize != sizeof(ELF_HEADER_TYPE))
+         return false;
+     return true;",I still don't seem to fully understand this. Why are we testing the host if DR_HOST_NOT_TARGET is not set?,Shouldn't this be `DR_HOST_X86`?
+3852,"@@ -34,9 +34,9 @@ import (
+ 
+ func TestBzzFiles(t *testing.T) {
+ 	var (
+-		fileUploadResource   = ""/bzz""
++		fileUploadResource   = ""/v1/bzz""
+ 		targets              = ""0x222""
+-		fileDownloadResource = func(addr string) string { return ""/bzz/"" + addr }
++		fileDownloadResource = func(addr string) string { return ""/v1/bzz/"" + addr }
+ 		simpleData           = []byte(""this is a simple text"")
+ 		storerMock           = smock.NewStorer()
+ 		statestoreMock       = statestore.NewStateStore()","in the current implementation, both schemes are supported (you can call either `/bzz` or `/v1/bzz`). i would suggest to keep it this way",Why this change?
+3853,"@@ -44,9 +44,12 @@ module.exports = class Client {
+       body: data
+     }).then((response) => response.json()).then((assembly) => {
+       if (assembly.error) {
+-        const error = new Error(assembly.error)
++        const error = new Error(assembly)
+         error.message = assembly.error
+-        error.details = assembly.reason
++        error.details = assembly.message
++        if (assembly.assembly_id) {
++          error.details += ' ' + `assembly_id: ${assembly.assembly_id}`
++        }
+         throw error
+       }
+ ","hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?",Should this be `
+3854,"@@ -315,7 +315,10 @@ class Typo3PageIndexer
+         $document->setField('rootline', $rootline);
+ 
+         // access
+-        $document->setField('access', (string)$this->pageAccessRootline);
++        $access = (string)$this->pageAccessRootline;
++        if (trim($access) !== """") {
++            $document->setField('access', $access);
++        }
+         if ($this->page->page['endtime']) {
+             $document->setField('endtime', $pageRecord['endtime']);
+         }",This should never be empty. The access field always needs a value of at least `c:0` or `r:0`,Why do we need t
+3855,"@@ -6,11 +6,16 @@ import (
+ 	""encoding/json""
+ 
+ 	""github.com/influxdata/flux/ast""
++	""github.com/influxdata/flux/internal/parser""
+ 	""github.com/influxdata/flux/internal/token""
+ 	""github.com/influxdata/flux/libflux/go/libflux""
+ )
+ 
+ func parseFile(f *token.File, src []byte) (*ast.File, error) {
++	if !useRustParser() {
++		return parser.ParseFile(f, src), nil
++	}
++
+ 	astFile := libflux.Parse(string(src))
+ 	defer astFile.Free()
+ ","Another question is, do we want to call `os.Getenv()` every time we parse a file? That seems a lot.",I don't think th
+3856,"@@ -33,6 +33,10 @@ public interface Tuple {
+      */
+     Seq<?> toSeq();
+ 
++    <A> Tuple append(A v);
++
++    <A> Tuple prepend(A v);
++
+     // -- factory methods
+ 
+     /**",minor: please rename all occurrences of `A` to `T`. please also rename `v` to `value`.,Why is this needed?
+3857,"@@ -52,11 +52,13 @@ namespace Nethermind.Synchronization.ParallelSync
+             add { }
+             remove { }
+         }
+-        
++
++        public int FastSyncLag => (Current & SyncMode.Beam) == SyncMode.Beam ? SyncModeSelectorConstants.BeamSyncFastSyncLag : SyncModeSelectorConstants.NotBeamSyncFastSyncLag;
++
+         public event EventHandler<SyncModeChangedEventArgs> Changing
+         {
+             add { }
+             remove { }
+         }
+     }
+-}
++}",Do we want it to be so dynamic? My first idea was to base it on SyncConfig.BeamSync .,I think this should
+3858,"@@ -42,7 +42,7 @@ public class RemoteNetworkConnection implements NetworkConnection {
+   @Override
+   public ConnectionType setNetworkConnection(
+       ConnectionType type) {
+-    Map<String, ConnectionType> mode = ImmutableMap.of(""type"", type);
++    Map<String, Integer> mode = ImmutableMap.of(""type"", type.getBitMask());
+     return new ConnectionType(((Number) executeMethod.execute(DriverCommand.SET_NETWORK_CONNECTION,
+                                                             ImmutableMap
+                                                                 .of(""parameters"", mode)))",can you change this instead to just `type.toString()` and then you wouldn't have to expose the getBitMask in the enum. (Alternatively you could have used `type.hashCode()` but that doesn't feel as nice),Why do we need this
+3859,"@@ -68,6 +68,13 @@ def test_plot_importance(params, breast_cancer_split, train_data):
+     assert ax2.patches[2].get_facecolor() == (0, .5, 0, 1.)  # g
+     assert ax2.patches[3].get_facecolor() == (0, 0, 1., 1.)  # b
+ 
++    ax3 = lgb.plot_importance(gbm0, title='t @importance_type@', xlabel='x @importance_type@', ylabel='y @importance_type@')
++    assert isinstance(ax3, matplotlib.axes.Axes)
++    assert ax3.get_title() == 't @importance_type@'
++    assert ax3.get_xlabel() == 'x split'
++    assert ax3.get_ylabel() == 'y @importance_type@'
++    assert len(ax3.patches) <= 30
++
+     gbm2 = lgb.LGBMClassifier(n_estimators=10, num_leaves=3, silent=True, importance_type=""gain"")
+     gbm2.fit(X_train, y_train)
+ ",I'm confused by these tests. Shouldn't the template string `@importance_type@` have been replaced with the actual value of `importance_type`?,I don't think you n
+3860,"@@ -25,7 +25,7 @@ import (
+ type harness struct{}
+ 
+ func (h *harness) MakeDriver(ctx context.Context) (driver.Keeper, error) {
+-	return NewKeeper(ByteKey(""very secret secret"")), nil
++	return &keeper{secretKey: ByteKey(""very secret secret"")}, nil
+ }
+ 
+ func (h *harness) Close() {}",Let's keep using NewKeeper so that it got covered by tests.,Why is this needed?
+3861,"@@ -70,6 +70,9 @@ import org.apache.solr.core.CoreContainer;
+ import org.apache.solr.handler.admin.CollectionsHandler;
+ import org.apache.solr.handler.component.HttpShardHandler;
+ import org.apache.solr.logging.MDCLoggingContext;
++import org.apache.solr.store.blob.process.BlobDeleteManager;
++import org.apache.solr.store.blob.process.BlobDeleteProcessor;
++import org.apache.solr.store.shared.SharedStoreManager;
+ import org.apache.solr.store.shared.metadata.SharedShardMetadataController;
+ import org.apache.solr.update.UpdateShardHandler;
+ import org.apache.zookeeper.CreateMode;",I only see new imports. Is there any functional change in this file?,I don't think we ne
+3862,"@@ -1141,6 +1141,18 @@ func (bc *blockchain) pickAndRunActions(ctx context.Context, actionMap map[strin
+ 		executedActions = append(executedActions, grant)
+ 	}
+ 
++	if raCtx.BlockHeight == 1 {
++		tsf, err := bc.createMemorialTransfer(raCtx.Producer.String(), raCtx.ActionGasLimit)
++		receipt, err = ws.RunAction(raCtx, tsf)
++		if err != nil {
++			return hash.ZeroHash256, nil, nil, err
++		}
++		if receipt != nil {
++			receipts = append(receipts, receipt)
++		}
++		executedActions = append(executedActions, tsf)
++	}
++
+ 	blockMtc.WithLabelValues(""gasConsumed"").Set(float64(bc.config.Genesis.BlockGasLimit - raCtx.GasLimit))
+ 
+ 	return ws.UpdateBlockLevelInfo(raCtx.BlockHeight), receipts, executedActions, nil",ineffectual assignment to `err` (from `ineffassign`),Why is this block h
+3863,"@@ -198,6 +198,10 @@ class Driver extends webdriver.WebDriver {
+    * @return {!Driver} A new driver instance.
+    */
+   static createSession(options, service = getDefaultService()) {
++    if (!service) {
++      service = getDefaultService();
++    }
++    
+     let client = service.start().then(url => new http.HttpClient(url));
+     let executor = new http.Executor(client);
+ ",Would you mind removing the default parameter above? (I doubt I'll ever use defaults again since you still have to protect against callers explicitly passing `null` or `undefined`),Why do we need this
+3864,"@@ -163,6 +163,18 @@ def FindMolChiralCenters(mol, force=True, includeUnassigned=False, includeCIP=Tr
+         centers.append((idx, code))
+   return centers
+ 
++import warnings
++def WrapLogs():
++  warnings.warn(""Deprecated: use the rdkit.rdBase.LogTo*() functions instead."", DeprecationWarning)
++  rdBase.LogToPythonStderr()
++
++def LogWarningMsg(msg):
++  warnings.warn(""Deprecated: use rdkit.rdBase.LogWarningMsg() instead."", DeprecationWarning)
++  rdBase.LogWarningMsg(msg)
++
++def LogErrorMsg(msg):
++  warnings.warn(""Deprecated: use rdkit.rdBase.LogErrorMsg() instead."", DeprecationWarning)
++  rdBase.LogErrorMsg(msg)
+ 
+ #------------------------------------
+ #","Make sure the old logging functions still work, but add deprecation warnings (unfortunately Python suppresses deprecation warnings by default, so I'm not sure if anyone'll notice).",I don't think we need to deprecate these.
+3865,"@@ -252,14 +252,17 @@ public class ManagementAuthorizationTest extends AuthorizationTest {
+ 
+   public void testTelemetryEnabledAsCamundaAdmin() {
+     // given
++    disableAuthorization();
++    managementService.enableTelemetry(true);
++    enableAuthorization();
+     identityService.setAuthentication(userId, Collections.singletonList(Groups.CAMUNDA_ADMIN));
+ 
+     // when
+-    managementService.enableTelemetry(true);
++    managementService.enableTelemetry(false);
+ 
+     // then
+     String telemetryPropertyValue = TelemetryHelper.fetchConfigurationProperty(processEngineConfiguration).getValue();
+-    assertThat(Boolean.parseBoolean(telemetryPropertyValue)).isTrue();
++    assertThat(Boolean.parseBoolean(telemetryPropertyValue)).isFalse();
+   }
+ 
+ }","Not directly related to the topic of this ticket: I think this API design is a bit confusing. To disable delemetry, I would write `managementService.enableTelemetry(false)` which is not intuitive to read. Maybe `toggleTelemetry` instead of `enableTelemetry` is more clear.",Why is this change needed?
+3866,"@@ -163,9 +163,11 @@ namespace Microsoft.Sarif.Viewer
+                         HelpLink = rule?.HelpUri?.ToString()                        
+                     };
+ 
+-                    CaptureAnnotatedCodeLocationCollections(result.Stacks, AnnotatedCodeLocationKind.Stack, sarifError);
++                    IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotationsFromStacks(result.Stacks);
++
++                    CaptureAnnotatedCodeLocationCollections(stackLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+                     CaptureAnnotatedCodeLocationCollections(result.CodeFlows, AnnotatedCodeLocationKind.CodeFlow, sarifError);
+-                     CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
++                    CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+ 
+                     if (region != null)
+                     {",Again I suggest returning `AnnotatedCodeLocation[][]`.,I'm not sure if this is the right place t
+3867,"@@ -16,11 +16,14 @@ package ec2
+ import (
+ 	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/aws-sdk-go/service/ec2""
++	""github.com/golang/glog""
+ 	""github.com/pkg/errors""
+ 	""sigs.k8s.io/cluster-api-provider-aws/cloud/aws/providerconfig/v1alpha1""
+ )
+ 
+ func (s *Service) reconcileInternetGateways(in *v1alpha1.Network) error {
++	glog.V(2).Infof(""Reconciling internet gateways"")
++
+ 	igs, err := s.describeVpcInternetGateways(&in.VPC)
+ 	if IsNotFound(err) {
+ 		ig, err := s.createInternetGateway(&in.VPC)",We should probably require an increased verbosity to output for anything below the cluster itself to avoid spamming the logs. It would also be good to give additional context as to what we are attempting to reconcile since the controller has multiple workers.,I think this should be `V(3).Infof`
+3868,"@@ -32,5 +32,7 @@ type OptionsNetwork struct {
+ 	EtherClientRPC       string
+ 	EtherPaymentsAddress string
+ 
++	EnableDNS bool
++
+ 	QualityOracle string
+ }",Not needed anymore,Why do we need this?
+3869,"@@ -80,6 +80,17 @@ namespace Datadog.Trace.ClrProfiler
+                 Log.Error(ex, ""ByRef instrumentation cannot be enabled: "");
+             }
+ 
++            try
++            {
++                Log.Debug(""Enabling calltarget state by ref."");
++                NativeMethods.EnableCallTargetStateByRef();
++                Log.Information(""CallTarget State ByRef enabled."");
++            }
++            catch (Exception ex)
++            {
++                Log.Error(ex, ""CallTarget state ByRef cannot be enabled: "");
++            }
++
+             try
+             {
+                 Log.Debug(""Sending CallTarget integration definitions to native library."");","Am I right in thinking this completely avoids the situation where `enable_calltarget_state_by_ref` is `true`, but the managed integrations don't expect a by ref argument? For example, if there's an exception here, that seems like a fatal problem, as we would have a mismatch for jit rewriting? We should disable instrumentation entirely in that case shouldn't we? i.e. if this (or the existing `EnableByRefInstrumentation`) calls fail, should we bail out of this method entirely as we can't safely instrument?",Should this be `Log.
+3870,"@@ -40,6 +40,15 @@ const (
+ 
+ package {{ .Package }}
+ 
++type ResourceTypes int
++
++const (
++	Unknown ResourceTypes = iota
++	{{- range .KnownTypes }}
++    {{ . }}
++    {{- end }}
++)
++
+ // Instance describes a single resource annotation
+ type Instance struct {
+ 	// The name of the annotation.",nit: spaces seem off,I think this should 
+3871,"@@ -20,7 +20,7 @@
+ 
+ #include ""PBFParser.h""
+ 
+-PBFParser::PBFParser(const char * fileName) : externalMemory(NULL){
++PBFParser::PBFParser(ExtractorCallbacks* em, ScriptingEnvironment& se, const char * fileName) : BaseParser( em, se ) {
+ 	GOOGLE_PROTOBUF_VERIFY_VERSION;
+ 	//TODO: What is the bottleneck here? Filling the queue or reading the stuff from disk?
+ 	//NOTE: With Lua scripting, it is parsing the stuff. I/O is virtually for free.",shouldn't the em parameter be called ec?,Why is this needed?
+3872,"@@ -132,7 +132,7 @@ func validateTrustedOperators(o *Options) error {
+ 		if o.TrustedKeys == nil {
+ 			o.TrustedKeys = make([]string, 0, 4)
+ 		}
+-		o.TrustedKeys = append(o.TrustedKeys, opc.Issuer)
++		o.TrustedKeys = append(o.TrustedKeys, opc.Subject)
+ 		o.TrustedKeys = append(o.TrustedKeys, opc.SigningKeys...)
+ 	}
+ 	for _, key := range o.TrustedKeys {","Please change this to use o.DidSign(o) as implements this logic without performing any of these checks that duplicate something that JWT can do correctly. If the JWT deserialized properly, and DidSign returns true, the JWT was signed by one of the listed operator keys.",I think this should be `opc.Issuer`
+3873,"@@ -0,0 +1,19 @@
++package de.danoeh.antennapod.core.util.comparator;
++
++import java.util.Comparator;
++
++import de.danoeh.antennapod.core.feed.FeedItem;
++import de.danoeh.antennapod.core.feed.SearchResult;
++
++public class InReverseChronologicalOrder implements Comparator<SearchResult> {
++    /**
++     * Compare items and sort it on chronological order.
++     */
++    @Override
++    public int compare(SearchResult o1, SearchResult o2) {
++        if ((o1.getComponent() instanceof FeedItem) &&
++           (o2.getComponent() instanceof FeedItem))
++            return ((FeedItem) o2.getComponent()).getPubDate().compareTo(((FeedItem) o1.getComponent()).getPubDate());
++        return 0;
++    }
++}","Talking about style, IMO extracting either `getComponent()` or `getPubDate()` to variables would make this line easier to read.",Why do we need this?
+3874,"@@ -0,0 +1,18 @@
++// Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package task
++
++// Option defines a function that can be executed in some task API methods in order to perform custom configurations
++// of the task
++type Option func(*Task) error",package header missing,`Option defines a function that can
+3875,"@@ -11,7 +11,11 @@ options._catchError = function(error, newVNode, oldVNode) {
+ 		for (; (vnode = vnode._parent); ) {
+ 			if ((component = vnode._component) && component._childDidSuspend) {
+ 				// Don't call oldCatchError if we found a Suspense
+-				return component._childDidSuspend(error, newVNode._component);
++				return component._childDidSuspend(
++					error,
++					newVNode._component,
++					oldVNode && oldVNode._hydrateDom && oldVNode._hydrating
++				);
+ 			}
+ 		}
+ 	}","Just a thought (doesn't change the output or anything) - do you think we'll ever want to access the other properties of `oldVNode` from within `_childDidSuspend`? If so we could pass `oldVNode` here and then check these properties in the _childDidSuspend implementation. I don't have strong feelings either way, just occurred to me.",Why do we need to check for `_hydra
+3876,"@@ -0,0 +1,15 @@
++<?php
++
++namespace Sonata\MediaBundle\PHPCR;
++
++use Doctrine\ODM\PHPCR\DocumentRepository;
++use Doctrine\ODM\PHPCR\Id\RepositoryIdInterface;
++
++class GalleryHasMediaRepository extends DocumentRepository implements RepositoryIdInterface
++{
++    public function generateId($document, $parent = null)
++    {
++        return '/cms/gallery-has-media/'  . uniqid();
++    }
++}
++",We should be configuring the base paths somewhere..,Missing license header.
+3877,"@@ -311,6 +311,17 @@ def test_ssd_anchor_generator():
+     else:
+         device = 'cpu'
+ 
++    # min_sizes max_sizes must set at the same time
++    with pytest.raises(AssertionError):
++        anchor_generator_cfg = dict(
++            type='SSDAnchorGenerator',
++            scale_major=False,
++            min_sizes=[48, 100, 150, 202, 253, 300],
++            max_sizes=None,
++            strides=[8, 16, 32, 64, 100, 300],
++            ratios=[[2], [2, 3], [2, 3], [2, 3], [2], [2]])
++        build_anchor_generator(anchor_generator_cfg)
++
+     anchor_generator_cfg = dict(
+         type='SSDAnchorGenerator',
+         scale_major=False,",May also need to test the normal functionality with min/max_sizes,Why do we need this?
+3878,"@@ -73,6 +73,7 @@ var MainnetDefinition = NetworkDefinition{
+ 		ChainID:            1,
+ 		MystAddress:        ""0x4Cf89ca06ad997bC732Dc876ed2A7F26a9E7f361"",
+ 		EtherClientRPC: []string{
++			""https://ethereum1.mysterium.network/"",
+ 			""https://main-light.eth.linkpool.io/"",
+ 		},
+ 	},",We can remove this one. It's just a random one I got for free for testing.,I think this should be 
+3879,"@@ -7,6 +7,7 @@
+ package blocksync
+ 
+ import (
++	""github.com/iotexproject/iotex-core/db""
+ 	""sync""
+ 
+ 	""github.com/iotexproject/iotex-core/actpool""",File is not `goimports`-ed (from `goimports`),nit: remove empty line
+3880,"@@ -65,7 +65,11 @@ class AddFiles extends Component {
+ 
+   renderMyDeviceAcquirer = () => {
+     return (
+-      <div class=""uppy-DashboardTab"" role=""presentation"">
++      <div
++        class=""uppy-DashboardTab""
++        role=""presentation""
++        data-acquirer-id=""Local""
++      >
+         <button
+           type=""button""
+           class=""uppy-DashboardTab-btn""",(maybe this should be MyDevice or just removed entirely?),Why do we need this?
+3881,"@@ -337,6 +337,10 @@ func (payloadHandler *payloadRequestHandler) handleUnrecognizedTask(task *ecsacs
+ 		TaskARN: *task.Arn,
+ 		Status:  apitaskstatus.TaskStopped,
+ 		Reason:  UnrecognizedTaskError{err}.Error(),
++		// The real task cannot be extracted from payload message, so we send an empty task.
++		// This is necessary because the task handler will not send an event whose
++		// Task is nil.
++		Task: &apitask.Task{},
+ 	}
+ 
+ 	payloadHandler.taskHandler.AddStateChangeEvent(taskEvent, payloadHandler.ecsClient)","Can you do a nil check here, as the task isn't always nil here?",Why is this necessar
+3882,"@@ -30,9 +30,12 @@ import Layout from 'GoogleComponents/layout/layout';
+  */
+ import { isDataZeroForReporting, getTopPagesReportDataDefaults } from '../util';
+ 
+-const { __ } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+ 
+ class AnalyticsDashboardWidgetPopularPagesTable extends Component {
+ 	static renderLayout( component ) {",`lodash` shouldn't be grouped under WordPress dependencies,I think this should 
+3883,"@@ -76,7 +76,11 @@ public class DiscoveryConfiguration {
+                   ""enode://011f758e6552d105183b1761c5e2dea0111bc20fd5f6422bc7f91e0fabbec9a6595caf6239b37feb773dddd3f87240d99d859431891e4a642cf2a0a9e6cbb98a@51.141.78.53:30303"",
+                   ""enode://176b9417f511d05b6b2cf3e34b756cf0a7096b3094572a8f6ef4cdcb9d1f9d00683bf0f83347eebdf3b81c3521c2332086d9592802230bf528eaf606a1d9677b@13.93.54.137:30303"",
+                   ""enode://46add44b9f13965f7b9875ac6b85f016f341012d84f975377573800a863526f4da19ae2c620ec73d11591fa9510e992ecc03ad0751f53cc02f7c7ed6d55c7291@94.237.54.114:30313"",
+-                  ""enode://b5948a2d3e9d486c4d75bf32713221c2bd6cf86463302339299bd227dc2e276cd5a1c7ca4f43a0e9122fe9af884efed563bd2a1fd28661f3b5f5ad7bf1de5949@18.218.250.66:30303"")
++                  ""enode://b5948a2d3e9d486c4d75bf32713221c2bd6cf86463302339299bd227dc2e276cd5a1c7ca4f43a0e9122fe9af884efed563bd2a1fd28661f3b5f5ad7bf1de5949@18.218.250.66:30303"",
++                  ""enode://c1f8b7c2ac4453271fa07d8e9ecf9a2e8285aa0bd0c07df0131f47153306b0736fd3db8924e7a9bf0bed6b1d8d4f87362a71b033dc7c64547728d953e43e59b2@52.64.155.147:30303"",
++                  ""enode://f4a9c6ee28586009fb5a96c8af13a58ed6d8315a9eee4772212c1d4d9cebe5a8b8a78ea4434f318726317d04a3f531a1ef0420cf9752605a562cfe858c46e263@213.186.16.82:30303"",
++                  // Ethereum Foundation bootnode
++                  ""enode://a61215641fb8714a373c80edbfa0ea8878243193f57c96eeb44d0bc019ef295abd4e044fd619bfc4c59731a73fb79afe84e9ab6da0c743ceb479cbb6d263fa91@3.11.147.67:30303"")
+               .map(EnodeURL::fromString)
+               .collect(toList()));
+ ",Does order matter? Should we sort by enode key to make duplication checking easier?,"""enode://b5948a2d3e9"
+3884,"@@ -132,11 +132,11 @@ func (ash *Handler) Provision(ctx caddy.Context) error {
+ 		return err
+ 	}
+ 
+-	acmeAuth, err := acme.NewAuthority(
+-		auth.GetDatabase().(nosql.DB),     // stores all the server state
+-		ash.Host,                          // used for directory links; TODO: not needed
+-		strings.Trim(ash.PathPrefix, ""/""), // used for directory links
+-		auth)                              // configures the signing authority
++	acmeAuth, err := acme.New(auth, acme.AuthorityOptions{
++		DB:     auth.GetDatabase().(nosql.DB),     // stores all the server state
++		DNS:    ash.Host,                          // used for directory links; TODO: not needed
++		Prefix: strings.Trim(ash.PathPrefix, ""/""), // used for directory links
++	})
+ 	if err != nil {
+ 		return err
+ 	}",Can you explain this too? This seems to go beyond linting.,I think this TODO can be removed.
+3885,"@@ -151,12 +151,6 @@ describe('Components', () => {
+ 		expect(scratch.innerHTML).to.equal('');
+ 	});
+ 
+-	// Test for #651
+-	it('should set enumerable boolean attribute', () => {
+-		render(<input spellcheck={false} />, scratch);
+-		expect(scratch.firstChild.spellcheck).to.equal(false);
+-	});
+-
+ 	// Test for Issue #73
+ 	it('should remove orphaned elements replaced by Components', () => {
+ 		class Comp extends Component {",I just moved this into the render.js UT file since this test doesn't actually use an components,Why was this test removed?
+3886,"@@ -163,6 +163,8 @@ var ConfigCommand *cobra.Command = &cobra.Command{
+ 			util.Failed(""Could not write ddev config file: %v"", err)
+ 		}
+ 
++		_,_ = app.CreateSettingsFile()
++
+ 		// If a provider is specified, prompt about whether to do an import after config.
+ 		switch provider {
+ 		case ddevapp.DefaultProviderName:",We do have to capture and check the err here right? I don't think we need to capture the location of the file though for this context.,I don't think this is the right p
+3887,"@@ -8,7 +8,6 @@ import time
+ import sys
+ import logging
+ from logging.handlers import RotatingFileHandler
+-import os
+ from listenbrainz.listenstore import InfluxListenStore
+ import redis
+ ",an unused import,Why was this removed?
+3888,"@@ -152,6 +152,9 @@ func parseTLS(h Helper) ([]ConfigValue, error) {
+ 			// policy that is looking for any tag but the last one to be
+ 			// loaded won't find it, and TLS handshakes will fail (see end)
+ 			// of issue #3004)
++
++			tlsCertTags := h.state[""tlsCertTags""].(map[string]string)
++
+ 			tag, ok := tlsCertTags[certFilename]
+ 			if !ok {
+ 				// haven't seen this cert file yet, let's give it a tag","If this value doesn't exist (do an `, ok := ...` check), we should initialize and store it",Why do we need this cast?
+3889,"@@ -1,6 +1,3 @@
+-import { or } from 'ramda';
+-
+-
+-const MIN_SAFE_INTEGER = or(Number.MIN_SAFE_INTEGER, -(2 ** 53) - 1);
++const MIN_SAFE_INTEGER = Number.MIN_SAFE_INTEGER || -(2 ** 53) - 1;
+ 
+ export default MIN_SAFE_INTEGER;",Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (-(2 ** 53) - 1),I think this should be `|
+3890,"@@ -175,8 +175,7 @@ class Serial(IoBase):
+ 		self._origTimeout = self._ser.timeout
+ 		# We don't want a timeout while we're waiting for data.
+ 		self._setTimeout(None)
+-		self.inWaiting = self._ser.inWaiting
+-		super(Serial, self).__init__(self._ser.hComPort, onReceive)
++		super(Serial, self).__init__(self._ser._port_handle, onReceive)
+ 
+ 	def read(self, size=1):
+ 		data = self._ser.read(size)","This handle is now private to pyserial, but if there is no public function to retrieve it I guess this is the best we can do.",Why did you remove this l
+3891,"@@ -581,7 +581,7 @@ uint32_t wlr_xdg_toplevel_set_maximized(struct wlr_xdg_surface *surface,
+ 	assert(surface->role == WLR_XDG_SURFACE_ROLE_TOPLEVEL);
+ 	surface->toplevel->server_pending.maximized = maximized;
+ 
+-	return schedule_xdg_surface_configure(surface);
++	return wlr_xdg_surface_schedule_configure(surface);
+ }
+ 
+ uint32_t wlr_xdg_toplevel_set_fullscreen(struct wlr_xdg_surface *surface,","This function is what **the compositor** calls when it wants to fullscreen a client, not what the client calls.",This should be `wlr_xdg_t
+3892,"@@ -98,12 +98,13 @@ func TestTraceflow(t *testing.T) {
+ 		t.Fatal(err)
+ 	}
+ 
+-	// Creates 4 traceflows:
++	// Creates 6 traceflows:
+ 	// 1. node1Pods[0] -> node1Pods[1], intra node1.
+ 	// 2. node1Pods[0] -> node2Pods[0], inter node1 and node2.
+ 	// 3. node1Pods[0] -> node1IPs[1], intra node1.
+ 	// 4. node1Pods[0] -> node2IPs[0], inter node1 and node2.
+ 	// 5. node1Pods[0] -> service, inter node1 and node2.
++	// 6. node1Pods[0] -> not existed Pod
+ 	testcases := []testcase{
+ 		{
+ 			name: ""intraNodeTraceflow"",",s/not existed Pod/non-existing Pod,Why is this change needed?
+3893,"@@ -62,10 +62,10 @@ type ECSStatusDescriber struct {
+ 	env string
+ 	svc string
+ 
+-	svcDescriber serviceDescriber
+-	ecsSvcGetter ecsServiceGetter
+-	cwSvcGetter  alarmStatusGetter
+-	aasSvcGetter autoscalingAlarmNamesGetter
++	ecsSvcDescriber serviceDescriber
++	ecsSvcGetter    ecsServiceGetter
++	cwSvcGetter     alarmStatusGetter
++	aasSvcGetter    autoscalingAlarmNamesGetter
+ }
+ 
+ // AppRunnerStatusDescriber retrieves status of an AppRunner service.",Why did we not leave this as just `svcDescriber`?,Why did you change the ord
+3894,"@@ -11,12 +11,12 @@
+ # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+-
+ """"""Provides the data access object (DAO) for Groups.""""""
+ 
++from Queue import Queue
++
+ from google.cloud.security.common.data_access import dao
+ from google.cloud.security.common.data_access.sql_queries import select_data
+-from google.cloud.security.common.gcp_type import group_member
+ from google.cloud.security.common.util import log_util
+ 
+ LOGGER = log_util.get_logger(__name__)",nit: I think we've been (in)consistent in leaving a blank line here.,Why is this import removed
+3895,"@@ -47,13 +47,15 @@ def define_violation(dbengine):
+         __tablename__ = violations_tablename
+ 
+         id = Column(Integer, primary_key=True)
+-        model_handle = Column(String(256))
++        inventory_index_id = Column(String(256))
+         resource_id = Column(String(256), nullable=False)
+         resource_type = Column(String(256), nullable=False)
++        full_name = Column(String(1024))
+         rule_name = Column(String(256))
+         rule_index = Column(Integer, default=0)
+         violation_type = Column(String(256), nullable=False)
+         data = Column(Text)
++        inventory_data = Column(Text)
+ 
+         def __repr__(self):
+             """"""String representation.",Maybe we can change it to a more generic name like source_id.,Why is this necessary?
+3896,"@@ -2019,7 +2019,7 @@ func testKeyManagerRekeyAddDeviceWithPromptViaFolderAccess(t *testing.T, ver Met
+ 		defer ops.mdWriterLock.Unlock(lState)
+ 
+ 		// Now cause a paper prompt unlock via a folder access
+-		errCh := make(chan error)
++		errCh := make(chan error, 1)
+ 		go func() {
+ 			_, err := GetRootNodeForTest(ctx, config2Dev2, name, false)
+ 			select {","What's the theory on why this could fix the hang? It seems like the call to `GetRootNodeForTest` will always need to call into the crypto object before returning an error, and so it should block on that `c` receive, after which the test immediately drains `errCh`. So I don't quite see how buffering would help...",Why this change?
+3897,"@@ -2003,8 +2003,16 @@ decode_operand(decode_info_t *di, byte optype, opnd_size_t opsize, opnd_t *opnd)
+         return true;
+     }
+     case TYPE_H: {
+-        /* part of AVX: vex.vvvv selects xmm/ymm register */
++        /* As part of AVX and AVX-512, vex.vvvv selects xmm/ymm/zmm register. Note that
++         * vex.vvvv and evex.vvvv are a union.
++         */
+         reg_id_t reg = (~di->vex_vvvv) & 0xf; /* bit-inverted */
++        if (TEST(PREFIX_EVEX_VV, di->prefixes)) {
++            /* This assumes that the register ranges of DR_REG_XMM, DR_REG_YMM, and
++             * DR_REG_ZMM are contiguous.
++             */
++            reg += 16;
++        }
+         *opnd = opnd_create_reg(((TEST(PREFIX_VEX_L, di->prefixes) &&
+                                   /* see .LIG notes above */
+                                   expand_subreg_size(opsize) != OPSZ_16)",Maybe add an assert in arch_init or somewhere?,Why do we need t
+3898,"@@ -100,6 +100,7 @@ func TestcaseNetworkDelay(
+ 	err := cli.Create(ctx, networkDelay.DeepCopy())
+ 	framework.ExpectNoError(err, ""create network chaos error"")
+ 
++	// nolint
+ 	wait.Poll(time.Second, 15*time.Second, func() (done bool, err error) {
+ 		result = probeNetworkCondition(c, networkPeers, ports, false)
+ 		if len(result[networkConditionBlocked]) != 0 || len(result[networkConditionSlow]) != 3 {",I wonder what does this `// nolint` ignore? And what are the standards that you choose which error to fix and which to ignore?,Why do we need t
+3899,"@@ -441,7 +441,10 @@ public class HttpSolrCall {
+     } else {
+       if (!retry) {
+         // we couldn't find a core to work with, try reloading aliases & this collection
+-        cores.getZkController().getZkStateReader().aliasesManager.update();
++        if(!cores.getZkController().getZkStateReader().aliasesManager.update()) {
++          //no change. go back
++          return;
++        }
+         cores.getZkController().zkStateReader.forceUpdateCollection(collectionName);
+         action = RETRY;
+       }","what about the line below, forceUpdateCollection?",Why is this need
+3900,"@@ -72,9 +72,13 @@ module Beaker
+     def cmd_line host, cmd = @command, env = @environment, pc = @prepend_cmds
+       env_string = host.environment_string( env )
+       prepend_commands = host.prepend_commands( cmd, pc, :cmd_exe => @cmdexe )
++      if host[:platform] =~ /cisco_nexus/ && host[:user] != 'root'
++          append_command = '""'
++        cmd = cmd.gsub('""') { '\\""' }
++      end
+ 
+       # This will cause things like `puppet -t -v agent` which is maybe bad.
+-      cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string]
++      cmd_line_array = [env_string, prepend_commands, cmd, options_string, args_string, append_command]
+       cmd_line_array.compact.reject( &:empty? ).join( ' ' )
+     end
+ ",Doesn't this go in the opposite direction of #1051 / #1062 by putting platform-specific logic back into this module?,I'm not sure if this is the best way to do this. I think it would be better to do this in the `prepend_commands` method.
+3901,"@@ -31,7 +31,7 @@ export const refreshAuthentication = async () => {
+ 
+ 		// We should really be using state management. This is terrible.
+ 		global.googlesitekit.setup = global.googlesitekit.setup || {};
+-		global.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
++		global.googlesitekit.setup.authenticated = response.authenticated;
+ 		global.googlesitekit.setup.requiredScopes = response.requiredScopes;
+ 		global.googlesitekit.setup.grantedScopes = response.grantedScopes;
+ 		global.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;",I think this is the only line in JS legacy code that should be updated based on the renaming. `global.googlesitekit.setup.isAuthenticated = response.authenticated;` would be sufficient to keep the old name for the legacy JS data (which will be phased out in the long term) while supporting the new name in the API route. All updates to the JS components above wouldn't be necessary.,Shouldn't this be `isAuthenticated`?
+3902,"@@ -36,7 +36,7 @@ function sendCommandToFrame(node, parameters, resolve, reject) {
+         reject(err('No response from frame', node));
+       }
+     }, 0);
+-  }, 500);
++  }, parameters.options?.pingWaitTime ?? 500);
+ 
+   // send 'axe.ping' to the frame
+   respondable(win, 'axe.ping', null, undefined, () => {","Technically, this would allow `pingWaitTime` to be `false`. I don't know if it matters here.",Shouldn't this be `parameters?.pingWaitTime ?? 500`?
+3903,"@@ -11,11 +11,15 @@ TEST_DATA = '{""StreamName"": ""NotExistingStream""}'
+ class KinesisListenerTest(unittest.TestCase):
+ 
+     def test_describe_stream_summary_is_redirected(self):
+-        describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'}
++        if config.KINESIS_PROVIDER == 'kinesalite':
++            describe_stream_summary_header = {'X-Amz-Target': 'Kinesis_20131202.DescribeStreamSummary'}
+ 
+-        response = UPDATE_KINESIS.forward_request('POST', '/', TEST_DATA, describe_stream_summary_header)
++            response = UPDATE_KINESIS.forward_request('POST', '/', TEST_DATA,
++                describe_stream_summary_header)
+ 
+-        self.assertEqual(response, True)
++            self.assertEqual(response, True)
++        else:
++            self.assertTrue(True)
+ 
+     def test_random_error_on_put_record(self):
+         put_record_header = {'X-Amz-Target': 'Kinesis_20131202.PutRecord'}",I only want the proxy request for this to run for kinesalite. So this just returns true if the KINESIS_PROVIDER is kinesis-mock,Why do we need this?
+3904,"@@ -3,7 +3,7 @@
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2006-2017 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee
++#Copyright (C) 2006-2019 NV Access Limited, Peter Vágner, Aleksey Sadovoy, Joseph Lee
+ 
+ from copy import deepcopy
+ import os",Please add your name to the list of copyright holders.,Why did you change the year?
+3905,"@@ -50,6 +50,12 @@ public class IpPortManager {
+ 
+   private boolean autoDiscoveryInited = false;
+ 
++  private int maxRetryTimes;
++
++  public int getMaxRetryTimes() {
++    return maxRetryTimes;
++  }
++
+   public IpPortManager(ServiceRegistryConfig serviceRegistryConfig, InstanceCacheManager instanceCacheManager) {
+     this.serviceRegistryConfig = serviceRegistryConfig;
+     this.instanceCacheManager = instanceCacheManager;","Maybe maxRetryTimes should be bigger than 2. Return Max(maxRestryTime, 2)?",Why do we need this?
+3906,"@@ -439,7 +439,7 @@ type CloneLink struct {
+ 	Git   string
+ }
+ 
+-func (repo *Repository) cloneLink(isWiki bool) *CloneLink {
++func (repo *Repository) cloneLink(isWiki bool, signedUserName string) *CloneLink {
+ 	repoName := repo.Name
+ 	if isWiki {
+ 		repoName += "".wiki""","Call `userName` is good enough, `signedUserName` is narrowing the actual usage of this method.",`signedUserName` is not used
+3907,"@@ -65,6 +65,13 @@ namespace Datadog.Trace
+             AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit;
+             AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException;
+             Console.CancelKeyPress += Console_CancelKeyPress;
++
++            // If configured, add/remove the correlation identifiers into the
++            // LibLog logging context when a scope is activated/closed
++            if (Settings.LogsInjectionEnabled)
++            {
++                new LibLogCorrelationIdentifierScopeSubscriber(_scopeManager);
++            }
+         }
+ 
+         /// <summary>",How would you feel about a static method to express intent?,Why do we need this?
+3908,"@@ -75,7 +75,8 @@ func (t LoggableTLSConnState) MarshalLogObject(enc zapcore.ObjectEncoder) error
+ 	enc.AddUint16(""version"", t.Version)
+ 	enc.AddUint16(""cipher_suite"", t.CipherSuite)
+ 	enc.AddString(""proto"", t.NegotiatedProtocol)
+-	enc.AddBool(""proto_mutual"", t.NegotiatedProtocolIsMutual)
++	// NegotiatedProtocolIsMutual is deprecated - it's always true
++	enc.AddBool(""proto_mutual"", true)
+ 	enc.AddString(""server_name"", t.ServerName)
+ 	if len(t.PeerCertificates) > 0 {
+ 		enc.AddString(""client_common_name"", t.PeerCertificates[0].Subject.CommonName)",Do we know for sure that no other code changed its value? (Maybe some weird testing use case or something) Why not just use the actual value instead of risk lying?,Why is this deprecated?
+3909,"@@ -16,8 +16,7 @@
+ 
+ package account
+ 
+-//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go
+-//go:generate dbgen -i part.sql -p account -n part -o partInstall.go
++//go:generate dbgen -i root.sql -p account -n root -o rootInstall.go -h ../../scripts/LICENSE_HEADER
+ import (
+ 	""database/sql""
+ 	""fmt""","the partInstall.go isn't an auto-generated file, and the part.sql doesn't exists either.",Why is this needed?
+3910,"@@ -97,3 +97,11 @@ func (c *TTLCache) Delete(key interface{}) error {
+ 	c.entries.Delete(key)
+ 	return nil
+ }
++
++func (c *TTLCache) GetAll() ([]interface{}, error) {
++	return nil, cache.ErrUnimplemented
++}
++
++func (c *TTLCache) PutHash(k interface{}, v interface{}) error {
++	return cache.ErrUnimplemented
++}",`k` is unused in PutHash,Why do we need this?
+3911,"@@ -277,4 +277,12 @@ public class Utils {
+ 		Method method = clazz.getDeclaredMethod(methodName, argTypes);
+ 		return method.invoke(null, args);
+ 	}
++	
++	public static void copyStream(InputStream input, OutputStream output) throws IOException {
++		byte[] buffer = new byte[1024];
++		int bytesRead;
++		while ((bytesRead = input.read(buffer)) != -1) {
++			output.write(buffer, 0, bytesRead);
++		}
++	}
+ }",Use IOUtils instead,Why is this needed?
+3912,"@@ -27,6 +27,8 @@ type idmFake struct {
+ 	unlockFails          bool
+ }
+ 
++// NewIdentityManagerFake creates fake identity manager for testing purposes
++// TODO each caller should use it's own mocked manager part instead of global one
+ func NewIdentityManagerFake(existingIdentities []Identity, newIdentity Identity) *idmFake {
+ 	return &idmFake{"""", """", existingIdentities, newIdentity, false}
+ }","It's not related to the line of code, but I don't know how to write it in a more proper place. Looks like `e2e/myst-provider/db/myst.db` should be in `.gitignore` file and should not be commited.",type idmFake struct {
+3913,"@@ -22,6 +22,7 @@ from selenium.webdriver.common.desired_capabilities import DesiredCapabilities
+ 
+ 
+ class Options(object):
++    KEY = ""goog:chromeOptions""
+ 
+     def __init__(self):
+         self._binary_location = ''",nice touch since Google likes to change things every now and then.,I think this should b
+3914,"@@ -1174,7 +1174,8 @@ public final class SolrCore implements SolrInfoBean, Closeable {
+   }
+ 
+   private CircuitBreakerManager initCircuitBreakerManager() {
+-    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(solrConfig);
++    final PluginInfo info = solrConfig.getPluginInfo(CircuitBreakerManager.class.getName());
++    CircuitBreakerManager circuitBreakerManager = CircuitBreakerManager.build(info.initArgs);
+ 
+     return circuitBreakerManager;
+   }",Make `CircuitBreakerManager` implement `PluginInfoInitialized`,I think this should b
+3915,"@@ -679,7 +679,7 @@ class _ServerCapabilities:
+ def _as_uint32(x: int) -> QVariant:
+     """"""Convert the given int to an uint32 for DBus.""""""
+     variant = QVariant(x)
+-    successful = variant.convert(QVariant.Type.UInt)
++    successful = variant.convert(QMetaType(QMetaType.Type.UInt.value))
+     assert successful
+     return variant
+ ","This is extra awkward, QVariant.convert() takes a QMetaType which takes the value of a QMetaType.Type.",I think this should b
+3916,"@@ -59,6 +59,12 @@ type Writer struct {
+ 
+ 	// These fields exist only when w is not created in the first place when
+ 	// NewWriter is called.
++	//
++	// A ctx is stored in the Writer since we need to pass it into NewTypedWriter
++	// when we finished detecting the content type of the object and create the
++	// underlying driver.Writer. This step happens inside Write or Close and
++	// neither of them take a context.Context as an argument. The ctx must be set
++	// to nil after we have done passing it.
+ 	ctx    context.Context
+ 	bucket driver.Bucket
+ 	key    string","Nit: finished -> finish, ""done passing it"" -> ""passed it"".",I don't think we need this anymore.
+3917,"@@ -46,5 +46,18 @@ module C2
+     config.autoload_paths << Rails.root.join('lib')
+ 
+     config.assets.precompile << 'common/communicarts.css'
++
++    # Paperclip's attachment settings are determined by S3 env vars
++    if ENV['S3_BUCKET_NAME'] && ENV['S3_ACCESS_KEY_ID'] && ENV['S3_SECRET_ACCESS_KEY']
++      Paperclip::Attachment.default_options.merge!(
++        bucket: ENV['S3_BUCKET_NAME'],
++        s3_credentials: {
++          access_key_id: ENV['S3_ACCESS_KEY_ID'],
++          secret_access_key: ENV['S3_SECRET_ACCESS_KEY']
++        },
++        s3_permissions: :private,
++        storage: :s3,
++      )
++    end
+   end
+ end",Maybe mention that it will be saved to the filesystem otherwise?,Do we need to check for `ENV['S3_AC
+3918,"@@ -108,7 +108,11 @@ namespace pwiz.Skyline.FileUI
+             {
+                 for (var i = 0; i < numColumns; i++)
+                 {
+-                    dataGrid.Columns[i].ToolTipText =
++                    // In the case when we don't have user provided headers, we still want localized headers that can be translated,
++                    // this replaces the autogenerated strings with a localized version
++                    dataGrid.Columns[i].HeaderText = string.Format(Resources.ImportTransitionListColumnSelectDlg_DisplayData_Column_) + (i+1).ToString();
++
++                    dataGrid.Columns[i].ToolTipText = 
+                         string.Format(Resources.ImportTransitionListColumnSelectDlg_DisplayData_The_input_text_did_not_appear_to_contain_column_headers__Use_the_dropdown_control_to_assign_column_meanings_for_import_);
+                 }
+             }","Probably cleaner and more general to do this: string,Format(""Column {0}"", i+1) That way if the local language has a convention like ""3 column, this is"" it still works.",I don't think this is the right pla
+3919,"@@ -74,11 +74,14 @@ func (v *validator) verifyActions(blk *Block, containCoinbase bool) error {
+ 	// Verify transfers, votes, executions, witness, and secrets (balance is checked in RunActions)
+ 	confirmedNonceMap := make(map[string]uint64)
+ 	accountNonceMap := make(map[string][]uint64)
++
++	transfers, votes, executions := action.ClassifyActions(blk.Actions)
+ 	var wg sync.WaitGroup
+-	wg.Add(len(blk.Transfers) + len(blk.Votes) + len(blk.Executions))
++	wg.Add(len(transfers) + len(votes) + len(executions))
++
+ 	var correctAction uint64
+ 	var coinbaseCount uint64
+-	for _, tsf := range blk.Transfers {
++	for _, tsf := range transfers {
+ 		// Verify Address
+ 		// Verify Gas
+ 		// Verify Nonce",This can be uniformed too,Why do we need to do this?
+3920,"@@ -16,14 +16,14 @@ type mock struct {
+ 	peers           []swarm.Address
+ 	closestPeer     swarm.Address
+ 	closestPeerErr  error
+-	addPeerErr      error
++	AddPeersErr     error
+ 	marshalJSONFunc func() ([]byte, error)
+ 	mtx             sync.Mutex
+ }
+ 
+-func WithAddPeerErr(err error) Option {
++func WithAddPeersErr(err error) Option {
+ 	return optionFunc(func(d *mock) {
+-		d.addPeerErr = err
++		d.AddPeersErr = err
+ 	})
+ }
+ ",It looks to me that this does not have to be exported.,I think we should keep this as `addPeerErr`
+3921,"@@ -61,6 +61,14 @@ public abstract class ApiConfig {
+     }
+   }
+ 
++  /**
++   * Creates an ApiConfig with no content. Exposed for testing.
++   */
++  public static ApiConfig createDummyApiConfig() {
++    return new AutoValue_ApiConfig(ImmutableMap.<String, InterfaceConfig> builder().build(), null,
++        false);
++  }
++
+   private static String getPackageName(ConfigProto configProto) {
+     Map<String, LanguageSettingsProto> settingsMap = configProto.getLanguageSettings();
+     String language = configProto.getLanguage();","It looks like this is only used in order to extract the snippet file names from GapicProviderFactory. I wonder if it would be better expose the snippet file names directly, without exposing a test-only function in non-test code.",Why do we need this?
+3922,"@@ -511,18 +511,6 @@ public class DataversePage implements java.io.Serializable {
+         }
+         setEditInputLevel(false);
+     }
+-    
+-    public void toggleInputLevel( Long mdbId, long dsftId){
+-        for (MetadataBlock mdb : allMetadataBlocks) {
+-            if (mdb.getId().equals(mdbId)) {
+-                for (DatasetFieldType dsftTest : mdb.getDatasetFieldTypes()) {
+-                    if (dsftTest.getId().equals(dsftId)) {
+-                            dsftTest.setRequiredDV(!dsftTest.isRequiredDV());                           
+-                    }
+-                }
+-            }
+-        }        
+-    }
+ 
+     public void updateInclude(Long mdbId, long dsftId) {
+         List<DatasetFieldType> childDSFT = new ArrayList<>();","Another question: this is being removed, but I don't see a corresponding removal if it being called? Was it never used (or am I just missing it)? (is it related to what was in the onclick that got removed, i.e. was that supposed to call this and not something in the backing bean?)",Why is this being removed?
+3923,"@@ -186,6 +186,10 @@ func (h *Helper) ValidateIssuedCertificateRequest(cr *cmapi.CertificateRequest,
+ 		}
+ 	}
+ 
++	if !apiutil.CertificateRequestHasApproved(cr) {
++		return nil, fmt.Errorf(""CertificateRequest does not have an Approved condition: %+v"", cr.Status.Conditions)
++	}
++
+ 	return cert, nil
+ }
+ ",Suggestion: `.. does not have an Approved condition set to true`,I don't think we need to check for Approved
+3924,"@@ -77,6 +77,7 @@ class BlazeMeterUploader(Reporter, AggregatorListener):
+         self.client.user_id = self.parameters.get(""user-id"", None)
+         self.client.data_signature = self.parameters.get(""signature"", None)
+         self.client.kpi_target = self.parameters.get(""kpi-target"", self.client.kpi_target)
++        self.client.delete_files_before_test = False
+ 
+         if not self.client.test_id:
+             try:",I would say that client class should have default of False and Cloud prov should enable deleting.,Why do we need this?
+3925,"@@ -1,4 +1,4 @@
+-// Copyright (c) .NET Foundation. All rights reserved.
++// Copyright (c) .NET Foundation. All rights reserved.
+ // Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
+ 
+ using System;",Did this remove the BOM or something?,Why did you change t
+3926,"@@ -99,6 +99,10 @@ public class BlockHeaderValidator<C> {
+     return parent;
+   }
+ 
++  public void addRule(final AttachedBlockHeaderValidationRule<C> rule) {
++    this.rules.add(new Rule<>(false, rule, rule.includeInLightValidation()));
++  }
++
+   private static class Rule<C> {
+     private final boolean detachedSupported;
+     private final AttachedBlockHeaderValidationRule<C> rule;","This makes the BlockHeaderValidator mutable, and IMHO should not be done. Note we have a builder that has the exact same method, so instead of mutating a produced BlockHeaderValidator we should hook into wherever the builder is being created.",Why do we need this?
+3927,"@@ -383,7 +383,7 @@ def outputDeviceNameToID(name, useDefaultIfInvalid=False):
+ 
+ fileWavePlayer = None
+ fileWavePlayerThread=None
+-def playWaveFile(fileName, async=True):
++def playWaveFile(fileName, asynchronous=True):
+ 	""""""plays a specified wave file.
+ """"""
+ 	global fileWavePlayer, fileWavePlayerThread",May be add information about parameters to the doc string while at it?,I think this should 
+3928,"@@ -43,8 +43,8 @@ public enum RpcMethod {
+   PRIV_DELETE_PRIVACY_GROUP(""priv_deletePrivacyGroup""),
+   PRIV_FIND_PRIVACY_GROUP(""priv_findPrivacyGroup""),
+   PRIV_DISTRIBUTE_RAW_TRANSACTION(""priv_distributeRawTransaction""),
++  PRIV_GET_TRANSACTION_COUNT_LEGACY(""priv_getTransactionCountLegacy""),
+   EEA_SEND_RAW_TRANSACTION(""eea_sendRawTransaction""),
+-  EEA_GET_TRANSACTION_COUNT(""eea_getTransactionCount""),
+   ETH_ACCOUNTS(""eth_accounts""),
+   ETH_BLOCK_NUMBER(""eth_blockNumber""),
+   ETH_CALL(""eth_call""),",Naming of this sounds a bit awkward. Perhaps priv_legacy_getTransactionCount or priv_legacyGetTransactionCount?,Why is this removed?
+3929,"@@ -3901,9 +3901,6 @@ void CoreChecks::PreCallRecordFreeMemory(VkDevice device, VkDeviceMemory mem, co
+ 
+     // Clear mem binding for any bound objects
+     for (auto obj : mem_info->obj_bindings) {
+-        log_msg(report_data, VK_DEBUG_REPORT_INFORMATION_BIT_EXT, get_debug_report_enum[obj.type], obj.handle,
+-                kVUID_Core_MemTrack_FreedMemRef, ""VK Object %s still has a reference to mem obj %s."",
+-                report_data->FormatHandle(obj.handle).c_str(), report_data->FormatHandle(mem_info->mem).c_str());
+         BINDABLE *bindable_state = nullptr;
+         switch (obj.type) {
+             case kVulkanObjectTypeImage:","This one should probably be added to the list in #24 . It's possibly indicative of an issue, but there isn't a VUID for it.",Why was this removed
+3930,"@@ -139,13 +139,11 @@ def build_network_url(project, network):
+       The fully qualified network url for the given project/network.
+     """"""
+     return (u'%(root)s%(api_name)s/%(version)s/projects/%(project)s/global/'
+-            'networks/%(network)s') % {
+-                'api_name': API_NAME,
+-                'network': network,
+-                'project': project,
+-                'root': API_ROOT,
+-                'version': API_VERSION
+-            }
++            'networks/%(network)s') % {'api_name': API_NAME,
++                                       'network': network,
++                                       'project': project,
++                                       'root': API_ROOT,
++                                       'version': API_VERSION}
+ 
+ 
+ class ComputeFirewallAPI(object):","Why this indentation change? Seems the original indentation would be fine, and leaves more room.",Why did you change t
+3931,"@@ -145,7 +145,7 @@ class MultiDimensionalMapping(Dimensioned):
+             raise KeyError('Key has to match number of dimensions.')
+ 
+ 
+-    def _add_item(self, dim_vals, data, sort=True):
++    def _add_item(self, dim_vals, data, sort=True, update=True):
+         """"""
+         Adds item to the data, applying dimension types and ensuring
+         key conforms to Dimension type and values.",Would be nice to know what the `update` argument does in the docstring.,Why do we need to ch
+3932,"@@ -1,10 +1,10 @@
+-import StringIO
+ from pathod import log
+ from netlib.exceptions import TcpDisconnect
+-import netlib.tcp
+ 
++from six.moves import cStringIO
+ 
+-class DummyIO(StringIO.StringIO):
++
++class DummyIO(cStringIO):
+ 
+     def start_log(self, *args, **kwargs):
+         pass",I think we can just use `io.BytesIO` here.,Why is this needed?
+3933,"@@ -155,13 +155,14 @@ func NewGCPgRPCConn(ctx context.Context, t *testing.T, endPoint, api string) (*g
+ }
+ 
+ // NewAzureTestPipeline creates a new connection for testing against Azure Blob.
+-func NewAzureTestPipeline(ctx context.Context, t *testing.T, accountName string, accountKey string) (pipeline pipeline.Pipeline, done func(), httpClient *http.Client) {
++func NewAzureTestPipeline(ctx context.Context, t *testing.T, api, accountName, accountKey string) (pipeline pipeline.Pipeline, done func(), httpClient *http.Client) {
+ 	mode := recorder.ModeReplaying
+ 	if *Record {
+ 		mode = recorder.ModeRecording
+ 	}
+ 
+ 	azMatchers := &replay.ProviderMatcher{
++		Headers: []string{""User-Agent""},
+ 		URLScrubbers: []*regexp.Regexp{
+ 			regexp.MustCompile(`se=[^?]*`),
+ 			regexp.MustCompile(`sig=[^?]*`),",This ensures that the User-Agent header matches during replay.,Why do we need this
+3934,"@@ -3517,6 +3517,7 @@ XDDkwd__(SUBQUERY_UNNESTING,			""ON""),
+  XDDui1__(USTAT_MIN_ROWCOUNT_FOR_LOW_SAMPLE,    ""1000000""),
+  XDDui1__(USTAT_MIN_ROWCOUNT_FOR_SAMPLE,        ""10000""),
+   DDflt0_(USTAT_MODIFY_DEFAULT_UEC,             ""0.05""),
++  DDflt0_(USTAT_NAHEAP_ESTIMATED_MAX,           ""1.3""),  // estimated max memory allocation feasible with NAHEAP.
+  XDDui1__(USTAT_NECESSARY_SAMPLE_MAX,           ""5000000""), // Maximum sample size with NECESSARY
+   DDui1__(USTAT_NUM_MC_GROUPS_FOR_KEYS,         ""10""),
+  XDDpct__(USTAT_OBSOLETE_PERCENT_ROWCOUNT,      ""15""),",What units are used for this default?,I think this should
+3935,"@@ -47,7 +47,13 @@ public struct Ability : IFlatbufferObject
+ 
+ public class AbilityT
+ {
++#if ENABLE_JSON_SERIALIZATION
++  [Newtonsoft.Json.JsonProperty(""id"")]
++#endif
+   public uint Id { get; set; }
++#if ENABLE_JSON_SERIALIZATION
++  [Newtonsoft.Json.JsonProperty(""distance"")]
++#endif
+   public uint Distance { get; set; }
+ 
+   public AbilityT() {","I am wondering if it makes sense to make this a flag to `flatc` rather than a preprocessor flag, since this is generated code, it would make more sense to simply omit this code completely if the flag is not specified",Why is this needed?
+3936,"@@ -584,8 +584,7 @@ class MainWindow(QWidget):
+         quit_texts = []
+         # Ask if multiple-tabs are open
+         if 'multiple-tabs' in config.val.confirm_quit and tab_count > 1:
+-            quit_texts.append(""{} {} open."".format(
+-                tab_count, ""tab is"" if tab_count == 1 else ""tabs are""))
++            quit_texts.append(""{} tabs are open."".format(tab_count))
+         # Ask if multiple downloads running
+         if 'downloads' in config.val.confirm_quit and download_count > 0:
+             quit_texts.append(""{} {} running."".format(","Doesn't this change the behavior (edit: oh, I see, never mind).",`tab is` -> `tabs are`
+3937,"@@ -216,11 +216,15 @@ module Travis
+               sh.cmd 'sudo ln -f -s /lib/i386-linux-gnu/libpam.so.0 /lib/libpam.so.0'
+               sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so'
+             end
+-            sh.if '$(uname -m) != ppc64le && $(lsb_release -cs) = trusty' do
++            sh.elif '$(lsb_release -cs) = trusty' do
+               sh.cmd 'sudo dpkg --add-architecture i386'
+               gemstone_install_linux_dependencies
+               sh.cmd 'sudo ln -f -s /usr/lib/i386-lin-gnu/libstdc++.so.6 /usr/lib/i386-linux-gnu/libstdc++.so'
+             end
++            sh.elif '$(lsb_release -cs) = xenial || $(lsb_release -cs) = bionic' do
++              sh.cmd 'sudo dpkg --add-architecture i386'
++              gemstone_install_linux_dependencies
++            end
+           end
+ 
+           def gemstone_install_linux_dependencies",I think you need a `do` at the end of this line.,Why do we need this ch
+3938,"@@ -5,7 +5,7 @@
+       <%= link_to(t('blacklight.search.sort.label', :field =>current_sort_field.label), ""#"") %> <span class=""caret""></span>
+       <ul>
+         <%- blacklight_config.sort_fields.each do |sort_key, field| %>
+-          <li><%= link_to(field.label, url_for(params_for_search(:sort => sort_key))) %></li>
++          <li><%= link_to(field.label, params_for_search(params.merge(:sort => sort_key))) %></li>
+         <%- end -%>
+       </ul>
+     </li>",Not passing in a `:params` key here.,I don't think you need
+3939,"@@ -308,6 +308,7 @@ func (r *ReconcileClusterClaim) reconcileForDeletedCluster(claim *hivev1.Cluster
+ func (r *ReconcileClusterClaim) reconcileForNewAssignment(claim *hivev1.ClusterClaim, cd *hivev1.ClusterDeployment, logger log.FieldLogger) (reconcile.Result, error) {
+ 	logger.Info(""cluster assigned to claim"")
+ 	cd.Spec.ClusterPoolRef.ClaimName = claim.Name
++	cd.Spec.PowerState = hivev1.RunningClusterPowerState
+ 	if err := r.Update(context.Background(), cd); err != nil {
+ 		logger.WithError(err).Log(controllerutils.LogLevel(err), ""could not set claim for ClusterDeployment"")
+ 		return reconcile.Result{}, err","Feels like this should be an option and not the default. Leaving them running would give you immediate response to claims, which might be what some people would want. Hibernation is AWS only right now and probably other clouds will just disregard the setting but arguably validation should be rejecting attempts to create / update powerstate on gcp/azure/etc. I'd pitch we put this onto the pool spec and make you opt in.",Why do we need this?
+3940,"@@ -5,13 +5,14 @@
+ 
+ // The conditions looks weird, but it seems like _OR_GREATER is not supported yet in all environments
+ // We can trim all the additional conditions when this is fixed
+-#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0
++#if NETCOREAPP3_0 || NETCOREAPP3_1 || NET5_0 || NET6_0
+ 
+ using System;
+ using System.Collections.Generic;
+ using System.Linq;
+ using System.Net;
+ using System.Threading.Tasks;
++using Datadog.Trace.IntegrationTestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+ ",I think I saw somewhere that it has been fixed and that you can use #NETCOREAPP3_0_OR_GREATER but I may be wrong.,Why is this needed?
+3941,"@@ -236,6 +236,15 @@ func (r *RollDPoS) CurrentState() fsm.State {
+ 	return r.cfsm.CurrentState()
+ }
+ 
++// Activate activates or pauses the roll-DPoS consensus. When it is deactivated, the node will finish the current
++// consensus round if it is doing the work and then return the the initial state
++func (r *RollDPoS) Activate(active bool) { r.ctx.Activate(active) }
++
++// Active is true if the roll-DPoS consensus is active, or false if it is stand-by
++func (r *RollDPoS) Active() bool {
++	return r.ctx.Active() || r.cfsm.CurrentState() != consensusfsm.InitState
++}
++
+ // Builder is the builder for RollDPoS
+ type Builder struct {
+ 	cfg config.Config",what's the second part for?,Why do we need this
+3942,"@@ -79,7 +79,7 @@ public class DirectSolrSpellCheckerTest extends SolrTestCaseJ4 {
+       return null;
+     });
+   }
+-  
++
+   @Test
+   public void testOnlyMorePopularWithExtendedResults() throws Exception {
+     assertQ(req(""q"", ""teststop:fox"", ""qt"", ""/spellCheckCompRH"", SpellCheckComponent.COMPONENT_NAME, ""true"", SpellingParams.SPELLCHECK_DICT, ""direct"", SpellingParams.SPELLCHECK_EXTENDED_RESULTS, ""true"", SpellingParams.SPELLCHECK_ONLY_MORE_POPULAR, ""true""),","It's not clear to me what the ""super"" test above is for. As far as I can see, the test runs a spellcheck for ""super"" but then uses ""fob"" as the index into suggestions, which will never find an entry.",Why did you change 
+3943,"@@ -24,7 +24,7 @@ import (
+ 	""google.golang.org/grpc/status""
+ 
+ 	logfilter ""github.com/iotexproject/iotex-core/api/logfilter""
+-	""github.com/iotexproject/iotex-core/ioctl/util""
++	ioctlUtil ""github.com/iotexproject/iotex-core/ioctl/util""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ )
+ ",revert this file change,File is not `goimpo
+3944,"@@ -74,9 +74,9 @@ class FileState:
+         #
+         # 1.   def meth8(self):
+         # 2.        """"""test late disabling""""""
+-        # 3.        pylint: disable=not-callable
++        # 3.        pylint: disable=not-callable, useless-suppression
+         # 4.        print(self.blip)
+-        # 5.        pylint: disable=no-member
++        # 5.        pylint: disable=no-member, useless-suppression
+         # 6.        print(self.bla)
+         #
+         # E1102 should be disabled from line 1 to 6 while E1101 from line 5 to 6",I think this is the most elegant way to allow us to still fail on `I`.,Why is this needed?
+3945,"@@ -415,10 +415,15 @@ class AdminController extends Controller
+             ->from($entityClass, 'entity')
+         ;
+ 
++        $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();
++        $searchQuery = addcslashes($searchQuery, implode('', $wildcards));
++
+         foreach ($searchableFields as $name => $metadata) {
+-            $wildcards = $this->getDoctrine()->getConnection()->getDatabasePlatform()->getWildcards();
+-            $searchQuery = addcslashes($searchQuery, implode('', $wildcards));
+-            $query->orWhere('entity.'.$name.' LIKE :query')->setParameter('query', '%'.$searchQuery.'%');
++            if (in_array($metadata['fieldType'], array('text', 'string'))) {
++                $query->orWhere('entity.'.$name.' LIKE :fuzzy_value')->setParameter('fuzzy_value', '%'.$searchQuery.'%');
++            } else {
++                $query->orWhere('entity.'.$name.' = :exact_value')->setParameter('exact_value', $searchQuery);
++            }
+         }
+ 
+         $paginator = new Pagerfanta(new DoctrineORMAdapter($query, false));",Wouldn't it be better to use a sql `IN ( :exact_value )` ?,Shouldn't this be `
+3946,"@@ -9,9 +9,14 @@ module Bolt
+ 
+       @shell = shell
+       @endpoint = ""http://#{host}:#{port}/wsman""
+-      @connection = ::WinRM::Connection.new(endpoint: @endpoint,
+-                                            user: @user,
+-                                            password: @password)
++      options = { endpoint: @endpoint,
++                  user: @user,
++                  password: @password }
++      if @timeout then
++        options[:receive_timeout] = @timeout
++        options[:operation_timeout] = @timeout
++      end
++      @connection = ::WinRM::Connection.new(options)
+       @connection.logger = @transport_logger
+     end
+ ",So far this is not working as expected... working to further investigate WinRM protocol and the gems behavior.,`then` is not neede
+3947,"@@ -68,7 +68,7 @@ class ApacheBenchmarkExecutor(ScenarioExecutor, WidgetProvider, HavingInstallabl
+         return self.widget
+ 
+     def __first_http_request(self):
+-        for request in self.scenario.get_requests():
++        for request in self.get_requests():
+             if isinstance(request, HTTPRequest):
+                 return request
+         return None","So now there're two ways to get requests: `ScenarioExecutor.get_requests()` and `Scenario.get_requests()`. To avoid confusion we should probably make `Scenario.get_requests()` method private, or hide it in some other way.",I think this should
+3948,"@@ -2436,10 +2436,10 @@ public:
+ 		}
+ 		else if (message_a.response)
+ 		{
+-			auto node_id (message_a.response->first);
+-			connection->remote_node_id = node_id;
++			nano::account node_id (message_a.response->first);
+ 			if (!connection->node->network.syn_cookies.validate (nano::transport::map_tcp_to_endpoint (connection->remote_endpoint), node_id, message_a.response->second) && node_id != connection->node->node_id.pub)
+ 			{
++				connection->remote_node_id = node_id;
+ 				connection->type = nano::bootstrap_server_type::realtime;
+ 				++connection->node->bootstrap.realtime_count;
+ 				connection->finish_request_async ();","This existed already, but seeing as you are changing the variable to have an explicit type it could be made a const reference to remove a copy.",I don't think this is correct. The `syn_cookies.validate` will return true if the `node_id` does not match the `connection->node->node_id.pub`.
+3949,"@@ -0,0 +1,11 @@
++module Faker
++  class FamousLastWords < Base
++    flexible :famous_last_words
++
++    class << self
++      def name
++        fetch('famous_last_words.phrase')
++      end
++    end
++  end
++end",I don't think this code is being tested; this method can be removed without the test failing,Extra empty line detected at class body beginning.
+3950,"@@ -298,6 +298,11 @@ public class FrameFragment extends BaseEditFragment {
+     // Asynchronous loading of thumbnails
+     private class asyncThumbs extends AsyncTask<Void, Void, Void> {
+ 
++        @Override
++        protected void onPreExecute() {
++            arrayList=new ArrayList<>();
++        }
++
+         @Override
+         protected Void doInBackground(Void... params) {
+             arrayList = new ArrayList<>();",@codepoet2017390 You have already initialized this ArrayList in the onPreExecute method then why do it here too?,Missing space after `=`
+3951,"@@ -0,0 +1,13 @@
++describe Gsa18f::ProcurementPolicy do
++  subject { described_class }
++
++  permissions :can_create? do
++    with_feature 'RESTRICT_ACCESS' do
++      it ""doesn't allow someone with a non-GSA email to create"" do
++        user = User.new(email_address: 'intruder@some.com')
++        procurement = Gsa18f::Procurement.new
++        expect(subject).not_to permit(user, procurement)
++      end
++    end
++  end
++end","This covers the `RESTRICT_ACCESS=true` x non-gsa pair, but we probably want to test the three other permutations: (`RA=true`, gsa), (`RA=false`, non-gsa), (`RA=false`, gsa)",I don't think this test is needed.
+3952,"@@ -18,13 +18,13 @@ define(['dom', 'scroller', 'browser', 'layoutManager', 'focusManager', 'register
+ 
+     function onFocus(e) {
+ 
+-        if (layoutManager.tv) {
++        /*if (layoutManager.tv) {
+ 
+             if (this.focusTimeout) {
+                 clearTimeout(this.focusTimeout);
+             }
+             this.focusTimeout = setTimeout(getFocusCallback(this, e), 700);
+-        }
++        }*/
+     }
+ 
+     function getTabPanel(tabs, index) {","Please don't do this - if you want to disable code permanently delete the code, if you need to disable it to test don't commit. Such sections are very poorly highlighted during review and can cause unspotted issues slipping through the process...",Please remove this.
+3953,"@@ -23,3 +23,10 @@ import (
+ type ConnTrackDumper interface {
+ 	DumpFlows(zoneFilter uint16) ([]*flowexporter.Connection, error)
+ }
++
++// ConnTrackInterfacer is an interface created to consume the required dump functions from either the third party
++// conntrack library or internal packages depending on OVS datapath type or OS.
++type ConnTrackInterfacer interface {
++	GetConnTrack(config interface{}) error // suggest a different name for config if it is not appropriate
++	DumpFilter(filter interface{}) ([]*flowexporter.Connection, error)
++}","I'm starting too feel we have too much abstraction and too many interfaces here. But this method is definitely the most confusing IMO. For one, it's called ""Get*"" but it does not return anything... I don't have a good understanding of what's going on anymore, so it's hard for me to suggest an alternative, but it's pretty clear to me that this interface needs to be rethought. An interface where all the parameters are themselves arbitrary objects (`interface{}`), whose actual type depends on the specific interface implementation, is not a helpful abstraction",nit: typo `Interfac
+3954,"@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap;
+ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.Multimap;
+ 
++import org.openqa.selenium.devtools.target.model.SessionId;
+ import org.openqa.selenium.json.Json;
+ import org.openqa.selenium.json.JsonInput;
+ import org.openqa.selenium.remote.http.HttpClient;",It fills me with endless sadness that we can't use Selenium's own `SessionId` here.,Is this import need
+3955,"@@ -2269,7 +2269,12 @@ public class ZkStateReader implements SolrCloseable {
+       log.debug(""Checking ZK for most up to date Aliases {}"", ALIASES);
+       // Call sync() first to ensure the subsequent read (getData) is up to date.
+       zkClient.getSolrZooKeeper().sync(ALIASES, null, null);
+-      Stat stat = new Stat();
++      Stat stat = zkClient.exists(ALIASES, null, true);
++      if (stat.getVersion() <= aliases.getZNodeVersion()) {
++        //we already have the latest version.
++        return false;
++      }
++      stat = new Stat();
+       final byte[] data = zkClient.getData(ALIASES, null, stat, true);
+       return setIfNewer(Aliases.fromJSON(data, stat.getVersion()));
+     }","Interesting. So you've found that it's faster to request only the ""Stat"" without the data so long as this is the typical path?",I think this should
+3956,"@@ -33,6 +33,7 @@ var skip = map[string]string{
+ 	""yield"":                       ""yield requires special test case (https://github.com/influxdata/flux/issues/535)"",
+ 	""task_per_line"":               ""join produces inconsistent/racy results when table schemas do not match (https://github.com/influxdata/flux/issues/855)"",
+ 	""rowfn_with_import"":           ""imported libraries are not visible in user-defined functions (https://github.com/influxdata/flux/issues/1000)"",
++	""string_trim"":                 ""cannot reference a package function from within a row function"",
+ }
+ 
+ var querier = querytest.NewQuerier()",Is this a future fix? I thought the local identifier scope and the package issue were the same one.,I think this should be `cannot reference a package function from within a row function`
+3957,"@@ -247,7 +247,17 @@ class TextInfoQuickNavItem(QuickNavItem):
+ class BrowseModeTreeInterceptor(treeInterceptorHandler.TreeInterceptor):
+ 	scriptCategory = inputCore.SCRCAT_BROWSEMODE
+ 	disableAutoPassThrough = False
+-	APPLICATION_ROLES = (controlTypes.ROLE_APPLICATION, controlTypes.ROLE_DIALOG)
++
++	def _isApplicationObject(self,obj):
++		""""""
++		Checks whether the given object in this browseMode treeInterceptor is an application (I.e. although the root of the object is represented in the treeInterceptor, its content is not).
++		I.e. an application or modal dialog.
++		""""""
++		if obj.role==controlTypes.ROLE_APPLICATION:
++			return True
++		elif obj.role==controlTypes.ROLE_DIALOG and controlTypes.STATE_MODAL in obj.states:
++			return True
++		return False
+ 
+ 	def _get_currentNVDAObject(self):
+ 		raise NotImplementedError","Not super important, but this line could be split up.",I think it would be better to use a set instead of a list.
+3958,"@@ -150,6 +150,17 @@ void h2o_context_dispose(h2o_context_t *ctx)
+     h2o_filecache_destroy(ctx->filecache);
+     ctx->filecache = NULL;
+ 
++    /* clear storage */
++    for (i = 0; i != ctx->storage.size; ++i) {
++        h2o_context_storage_item_t item = ctx->storage.entries[i];
++        if (item.data != NULL) {
++            if (item.dispose != NULL) {
++                item.dispose(item.data);
++            }
++        }
++    }
++    free(ctx->storage.entries);
++
+     /* TODO assert that the all the getaddrinfo threads are idle */
+     h2o_multithread_unregister_receiver(ctx->queue, &ctx->receivers.hostinfo_getaddr);
+     h2o_multithread_destroy_queue(ctx->queue);",Maybe we should better call the dispose function without checking the value of `item.data` (since the dispose function is setup before `data` is set up).,Shouldn't this be `free(ctx->storage.entries)`?
+3959,"@@ -33,6 +33,7 @@ inline void SyncedMemory::to_cpu() {
+       CaffeMallocHost(&cpu_ptr_, size_);
+       own_cpu_data_ = true;
+     }
++    Caffe::set_mode(Caffe::GPU);
+     caffe_memcpy(size_, gpu_ptr_, cpu_ptr_);
+     head_ = SYNCED;
+     break;","Why set to GPU, is it CPU?",Why is this needed?
+3960,"@@ -1,10 +1,16 @@
+ import AppointmentIndexRoute from 'hospitalrun/appointments/index/route';
+ import moment from 'moment';
+ import { translationMacro as t } from 'ember-i18n';
++import Ember from 'ember';
++
++const { computed } = Ember;
++
+ export default AppointmentIndexRoute.extend({
+   editReturn: 'appointments.today',
+   modelName: 'appointment',
+-  pageTitle: t('appointments.todayTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('appointments.todayTitle');
++  }),
+ 
+   _modelQueryParams() {
+     let endOfDay = moment().endOf('day').toDate().getTime();",This should be `computed('i18n.locale'....`,Why do we need this?
+3961,"@@ -49,7 +49,7 @@ type Session struct {
+ 	DataTransferred DataTransferred
+ 	TokensEarned    uint64
+ 	Last            bool
+-	done            chan struct{}
++	Done            chan struct{}
+ }
+ 
+ // newSession creates a blank new session with an ID.",can we not expose the channel directly? or at least expose it as a read only channel?,Why did you change t
+3962,"@@ -88,6 +88,17 @@ AS_IF([test ""$YACC"" != ""bison -y""], [AC_MSG_ERROR([bison not found but required]
+ 
+ PKG_PROG_PKG_CONFIG
+ 
++# PKG_CHECK_VAR added to pkg-config 0.28
++m4_define_default(
++    [PKG_CHECK_VAR],
++    [AC_ARG_VAR([$1], [value of $3 for $2, overriding pkg-config])
++     AS_IF([test -z ""$$1""], [$1=`$PKG_CONFIG --variable=""$3"" ""$2""`])
++     AS_IF([test -n ""$$1""], [$4], [$5])])
++
++PKG_CHECK_VAR(bashcompdir, [bash-completion], [completionsdir], ,
++  bashcompdir=""${sysconfdir}/bash_completion.d"")
++AC_SUBST(bashcompdir)
++
+ AM_PATH_GLIB_2_0(,,AC_MSG_ERROR([GLib not found]))
+ 
+ dnl When bumping the gio-unix-2.0 dependency (or glib-2.0 in general),",Can we add a `--with-bashcompdir` here to override this? I'd like to be able to do unprivileged builds.,I don't think you ne
+3963,"@@ -0,0 +1,13 @@
++package cstor
++
++import (
++	""github.com/openebs/maya/cmd/cstor-volume-grpc/app/command""
++)
++
++func Snapshot(volName, snapName, targetIP string) (interface{}, error) {
++	return command.CreateSnapshot(volName, snapName, targetIP)
++}
++
++func SnapshotDelete(volName, snapName, targetIP string) (interface{}, error) {
++	return command.DestroySnapshot(volName, snapName, targetIP)
++}",We will be removing this maya/volume package completely. Do not use this.,Why do we need this?
+3964,"@@ -67,7 +67,7 @@ static train_result call_daal_kernel(const context_gpu& ctx,
+ 
+     daal::algorithms::classifier::ModelPtr model_ptr(new daal_knn::Model(column_count));
+     if (!model_ptr) {
+-        throw bad_alloc();
++        throw host_bad_alloc();
+     }
+ 
+     auto knn_model = static_cast<daal_knn::Model*>(model_ptr.get());",Why you think that `model_ptr` will be `nullptr` when memory allocation is failed? I think `new daal_knn::Model(column_count)` would throw `std::bad_alloc` if `operator new` is not overloaded. Is it overloaded by DAAL in the way it simply returns `nullptr` in case of bad allocation?,"I think this should be `throw std::runtime_error(""bad_alloc"");`"
+3965,"@@ -42,14 +42,15 @@ type MinerCreateResult struct {
+ 
+ var minerCreateCmd = &cmds.Command{
+ 	Helptext: cmdkit.HelpText{
+-		Tagline: ""Create a new file miner with <pledge> sectors and <collateral> FIL"",
++		Tagline: ""Create a new file miner with <collateral> FIL"",
+ 		ShortDescription: `Issues a new message to the network to create the miner, then waits for the
+ message to be mined as this is required to return the address of the new miner.
+-Collateral must be greater than 0.001 FIL per pledged sector.`,
++Collateral will be committed at the rate of 0.001FIL per sector. When the 
++miner's collateral drops below 0.001FIL, the miner will not be able to commit
++additional sectors.`,
+ 	},
+ 	Arguments: []cmdkit.Argument{
+-		cmdkit.StringArg(""pledge"", true, false, ""The size of the pledge (in sectors) for the miner""),
+-		cmdkit.StringArg(""collateral"", true, false, ""The amount of collateral in FIL to be sent (minimum 0.001 FIL per sector)""),
++		cmdkit.StringArg(""collateral"", true, false, ""The amount of collateral, in FIL""),
+ 	},
+ 	Options: []cmdkit.Option{
+ 		cmdkit.StringOption(""from"", ""Address to send from""),","Where does this 0.001 come from? Is this from the network collateral cost function, which happens to be hardcoded right now? I think it's going to rot very quickly: it depends on sector size and (probably) block height.","""will not be able to commit additional sectors"""
+3966,"@@ -0,0 +1,5 @@
++# -----------------------------------------------------------------------------
++#                     The CodeChecker Infrastructure
++#   This file is distributed under the University of Illinois Open Source
++#   License. See LICENSE.TXT for details.
++# -----------------------------------------------------------------------------",Please update the license header in each source file. For more information see: #2697,Do we need this file?
+3967,"@@ -144,8 +144,9 @@ class HttpClient {
+  * @param {function(!Error)} onError The function to call if the request fails.
+  * @param {?string=} opt_data The data to send with the request.
+  * @param {?RequestOptions=} opt_proxy The proxy server to use for the request.
++ * @param {!number=} retries The current number of retries.
+  */
+-function sendRequest(options, onOk, onError, opt_data, opt_proxy) {
++function sendRequest(options, onOk, onError, opt_data, opt_proxy, retries) {
+   var hostname = options.hostname;
+   var port = options.port;
+ ",!numbers -> numbers,nit: `retries` -> `retriesCount`
+3968,"@@ -64,6 +64,6 @@ namespace AutoRest.Swagger.Validation.Core
+         /// <summary>
+         /// The collection of rules that apply to all properties regardless of other rules.
+         /// </summary>
+-        public static IEnumerable<Rule> UniversalRules = new[] { new NoControlCharacters() };
++        public static IEnumerable<Rule> UniversalRules = new List<Rule>();
+     }
+ }","so we don't have universal rules afterwards? In that case I'd remove this entirely (and maybe some places where it's used get cleaner) since we shouldn't ever add a universal rule. Not only because it's way simpler in TS, I'm also just super skeptical about ""universal"". In case of this rule, even control characters may have their place in Swaggers, e.g. in `examples` sections where you can have raw response bodies where control characters are perfectly valid.",Why this change?
+3969,"@@ -115,7 +115,8 @@ module.exports = function exec(command, opt_options) {
+ 
+   var proc = childProcess.spawn(command, options.args || [], {
+     env: options.env || process.env,
+-    stdio: options.stdio || 'ignore'
++    stdio: options.stdio || 'ignore',
++    detached: true
+   });
+ 
+   // This process should not wait on the spawned child, however, we do","You're welcome to surface this option through the API, but I'm not going to make this the default behavior.",Why do we need t
+3970,"@@ -76,10 +76,10 @@ func buildBinary(source, target string) error {
+ 	if !ok {
+ 		targetArch = runtime.GOARCH
+ 	}
+-	return buildBinaryFor(source, target, targetOS, targetArch)
++	return buildBinaryFor(source, target, targetOS, targetArch, false)
+ }
+ 
+-func buildBinaryFor(source, target, targetOS, targetArch string) error {
++func buildBinaryFor(source, target, targetOS, targetArch string, buildStatic bool) error {
+ 	log.Info().Msgf(""Building %s -> %s %s/%s"", source, target, targetOS, targetArch)
+ 
+ 	buildDir, err := filepath.Abs(path.Join(""build"", target))","Just a thought that any further extensions of `buildBinaryFor` signature could be done as `buildBinaryFor(..., opts... BuildOptions)` for better readability.",I don't think we
+3971,"@@ -44,8 +44,11 @@ namespace OpenTelemetry.Metrics
+ 
+             var options = new InMemoryExporterOptions();
+             configure?.Invoke(options);
+-            var exporter = new InMemoryMetricExporter(exportedItems, options);
+-            return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));
++
++            // var exporter = new InMemoryMetricExporter(exportedItems, options);
++            // return builder.AddMetricReader(new PeriodicExportingMetricReader(exporter, options.MetricExportIntervalMilliseconds));
++
++            return builder;
+         }
+     }
+ }",I'll fix the InMemoryExporter right after this PR lands,Can this be remo
+3972,"@@ -11098,7 +11098,7 @@ bool CoreChecks::ValidateCreateSwapchain(const char *func_name, VkSwapchainCreat
+ 
+     auto physical_device_state = GetPhysicalDeviceState();
+     if (physical_device_state->vkGetPhysicalDeviceSurfaceCapabilitiesKHRState == UNCALLED) {
+-        if (log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
++        if (log_msg(report_data, VK_DEBUG_REPORT_WARNING_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_PHYSICAL_DEVICE_EXT,
+                     HandleToUint64(physical_device), kVUID_Core_DrawState_SwapchainCreateBeforeQuery,
+                     ""%s: surface capabilities not retrieved for this physical device"", func_name))
+             return true;","Good call, none of these are technically invalid",Shouldn't this be `ERROR`?
+3973,"@@ -20,7 +20,7 @@ partial class Build
+         .OnlyWhenStatic(() => IsWin)
+         .Executes(() =>
+         {
+-            var project = ProfilerDirectory.GlobFiles(""**/Datadog.AutoInstrumentation.Profiler.Native.Windows.vcxproj"").Single();
++            var project = ProfilerDirectory.GlobFiles(""**/Datadog.Profiler.Native.Windows.vcxproj"").Single();
+ 
+             // run: msbuild /property:Configuration=${{matrix.configuration}} /property:Platform=${{matrix.platform}}  dd-continuous-profiler-dotnet\src\ProfilerEngine\Datadog.AutoInstrumentation.Profiler.Native.Windows\Datadog.AutoInstrumentation.Profiler.Native.Windows.WithTests.proj
+             // If we're building for x64, build for x86 too",this one should be updated too,I'm not sure if this is th
+3974,"@@ -39,6 +39,7 @@ public final class InvocationFactory {
+         operationMeta,
+         swaggerArguments);
+     invocation.addContext(Const.SRC_MICROSERVICE, getMicroserviceName());
++    invocation.addContext(Const.SRC_INSTANCE, getInstanceId());
+     return invocation;
+   }
+ ",maybe need to add microserviceId too.,invocation.addContext(
+3975,"@@ -0,0 +1,6 @@
++""""""Tests for missing-param-doc and missing-type-doc for Numpy style docstrings
++with accept-no-param-doc = no
++""""""
++# pylint: disable=invalid-name, unused-argument, undefined-variable
++# pylint: disable=line-too-long, too-few-public-methods, missing-class-docstring
++# pylint: disable=missing-function-docstring, function-redefined, inconsistent-return-statements","I'm curious, do you create this commit at the very end by rebasing and taking the value you had after moving everything ?",Why are these disabled?
+3976,"@@ -939,12 +939,10 @@ describe('Core_alter', () => {
+       expect(spec().$container.find('tr:eq(6) td:eq(0)').html()).toEqual('b1');
+     });
+ 
+-    it('should not add more source rows than defined in maxRows when trimming rows using the modifyRow hook', () => {
++    it('should not add more source rows than defined in maxRows when trimming rows using the TrimRows plugin', () => {
+       const hot = handsontable({
+         data: Handsontable.helper.createSpreadsheetData(10, 4),
+-        modifyRow(row) {
+-          return [8, 9].indexOf(row) > -1 ? null : row;
+-        },
++        trimRows: [8, 9],
+         maxRows: 10
+       });
+ ",It's no longer possible to use `modifyRow` to trim rows and that's ok to use TrimRows instead. But I think we should move this test to TrimRows plugin tests as `trimRows` setting is not a part of the `core`.,Why did you remove this hook?
+3977,"@@ -688,6 +688,17 @@ static int on_config_mime_setdefaulttype(h2o_configurator_command_t *cmd, h2o_co
+     return 0;
+ }
+ 
++static const char *get_ext(h2o_configurator_command_t *cmd, yoml_t *node)
++{
++    if (strcmp(node->data.scalar, ""default"") == 0) {
++        return node->data.scalar;
++    } else if  (assert_is_extension(cmd, node) == 0) {
++        return node->data.scalar + 1;
++    } else {
++        return NULL;
++    }
++}
++
+ static int on_config_custom_handler(h2o_configurator_command_t *cmd, h2o_configurator_context_t *ctx, yoml_t *node)
+ {
+     static const char *ignore_commands[] = {""extension"", NULL};","The function seems to either return ""default"" or return the extension stripping the preceding dot. Does the fact mean that we can no longer register `.default` as an extension?",Why is this needed?
+3978,"@@ -110,6 +110,8 @@ type Container struct {
+ 	Image string
+ 	// ImageID is the local ID of the image used in the container
+ 	ImageID string
++	// ImageDigest is the sha-256 digest of the container image as pulled from the repository
++	ImageDigest string
+ 	// Command is the command to run in the container which is specified in the task definition
+ 	Command []string
+ 	// CPU is the cpu limitation of the container which is specified in the task definition",this may require a statefile version update,Why do we need this?
+3979,"@@ -4,6 +4,9 @@ namespace Shopsys\FrameworkBundle\Component\Csv;
+ 
+ use Symfony\Component\Filesystem\Exception\FileNotFoundException;
+ 
++/**
++ * @deprecated Class is obsolete and will be removed in the next major. Use SplFileObject::fgetcsv() instead.
++ */
+ class CsvReader
+ {
+     /**","I like when `@deprecated` contains how to resolve it - eg. ""use `SplFileObject::fgetcsv()` instead"". The information in upgrade notes is usefull only during upgrade.",This class should be marked a
+3980,"@@ -7,8 +7,8 @@ package mock
+ import (
+ 	gomock ""github.com/golang/mock/gomock""
+ 	gcpclient ""github.com/openshift/hive/pkg/gcpclient""
+-	v1 ""google.golang.org/api/compute/v1""
+-	v10 ""google.golang.org/api/dns/v1""
++	compute ""google.golang.org/api/compute/v1""
++	dns ""google.golang.org/api/dns/v1""
+ 	reflect ""reflect""
+ )
+ ",Nice to see that your local environment is up-to-date now for these changes.,Why did you change this?
+3981,"@@ -1268,7 +1268,13 @@ var AppRouter = Backbone.Router.extend({
+         }
+ 
+         // Init sidebar based on the current url
+-        self.sidebar.init();
++        if (countlyVue.sideBarComponent) {
++            var selectedMenuItem = countlyVue.sideBarComponent.$store.getters[""countlySidebar/getSelectedMenuItem""];
++            var currLink = ""#"" + Backbone.history.fragment;
++            if (selectedMenuItem.item.url !== currLink) {
++                countlyVue.sideBarComponent.$store.dispatch(""countlySidebar/updateSelectedMenuItem"", null);
++            }
++        }
+     },
+     sidebar: {
+         init: function() {","Instead of setting it to null, i think lets set it to {}",Why do we need this?
+3982,"@@ -23,8 +23,8 @@ import (
+ )
+ 
+ const (
+-	TPRGroup   = ""monitoring.coreos.com""
+-	TPRVersion = ""v1alpha1""
++	Group   = ""monitoring.coreos.com""
++	Version = ""v1alpha1""
+ )
+ 
+ type MonitoringV1alpha1Interface interface {","We should bump this before releasing and remove all legacy fields that are safe to do so. Since we cannot have multiple versions anyway there's little value in walking around with the ""alpha"" stamp.",Why did you change this?
+3983,"@@ -59,6 +59,15 @@ AS_CASE($ax_cv_cxx_compiler_vendor,
+ AX_CXX_COMPILE_STDCXX([11], [noext], [mandatory])
+ 
+ X_AC_ENABLE_SANITIZER
++if test ""x$san_enabled"" != ""xno"" ; then
++  AC_DEFINE([DEEPBIND], [0],
++            [deepbind is unsupported with asan, musl and so-forth])
++else
++  AC_DEFINE([DEEPBIND], [RTLD_DEEPBIND],
++            [deepbind is unsupported with asan, musl and so-forth])
++fi
++
++
+ LT_INIT
+ AC_PROG_AWK
+ ",I might suggest a different name for the `DEEPBIND` config.h macro. Perhaps `FLUX_DEEPBIND` to give a hint in the code that we're using a locally provided define.,I don't think this is ne
+3984,"@@ -393,7 +393,7 @@ func init() {
+ 	proto.RegisterType((*StatusResponse)(nil), ""bpfki.StatusResponse"")
+ }
+ 
+-func init() { proto.RegisterFile(""bpfki.proto"", fileDescriptor_62eed357eb71de0e) }
++func init() { protoregistry.GlobalFiles.RegisterFile(""bpfki.proto"", fileDescriptor_62eed357eb71de0e) }
+ 
+ var fileDescriptor_62eed357eb71de0e = []byte{
+ 	// 518 bytes of a gzipped FileDescriptorProto",Code generated by protoc-gen-go. **DO NOT EDIT.**. The correct way to fix `deprecated` in this file may be updating the protoc / protobuf / grpc and regenerate this file.,Why is this change needed?
+3985,"@@ -15,6 +15,7 @@ import java.util.List;
+  *
+  * @author Brian Remedios
+  */
++@Deprecated
+ public class IntegerPropertyTest extends AbstractNumericPropertyDescriptorTester<Integer> {
+ 
+     private static final int MIN = 1;",We should make sure that we cover the testcases in a new unit test class.,Why is this test deprecate
+3986,"@@ -0,0 +1,19 @@
++package proofs
++
++// #cgo LDFLAGS: -L${SRCDIR}/../proofs/lib -lfilecoin_proofs
++// #cgo pkg-config: ${SRCDIR}/../proofs/lib/pkgconfig/libfilecoin_proofs.pc
++// #include ""../proofs/include/libfilecoin_proofs.h""
++import ""C""
++import (
++	""unsafe""
++)
++
++func SectorSize(ssType Mode) uint64 {
++	scfg, err := CProofsMode(ssType)
++	if err != nil {
++		return 0
++	}
++
++	numFromC := C.get_max_user_bytes_per_staged_sector((*C.ConfiguredStore)(unsafe.Pointer(scfg)))
++	return uint64(numFromC)
++}","Is this only used in test code? Is there future utility in it for production code? If not, it would be nice if this could be moved into a test package. I'm not sure how hard that would be. CC @laser",Why is this needed?
+3987,"@@ -192,7 +192,7 @@ func (p *Plugin) setConfig(config *pluginConfig) error {
+ 		p.cancelWatcher()
+ 		p.cancelWatcher = nil
+ 	}
+-	if config.WebhookLabel != """" {
++	if config.WebhookLabel != """" || config.APIServiceLabel != """" {
+ 		p.cancelWatcher = cancelWatcher
+ 	}
+ ","Super curious how you noticed this, as SPIRE itself currently only configures once...?",Why is this change needed?
+3988,"@@ -21,11 +21,18 @@ public class NotFoundExceptionHandler implements ExceptionMapper<NotFoundExcepti
+     @Override
+     public Response toResponse(NotFoundException ex){
+         String uri = request.getRequestURI();
++        String exMessage = ex.getMessage(); 
++        String outputMessage;
++        if (exMessage != null && exMessage.startsWith(""Datafile"")) {
++            outputMessage = exMessage;
++        } else {
++            outputMessage = ""endpoint does not exist on this server. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."";
++        }
+         return Response.status(404)
+                 .entity( Json.createObjectBuilder()
+                              .add(""status"", ""ERROR"")
+                              .add(""code"", 404)
+-                             .add(""message"", ""'"" + uri + ""' endpoint does not exist on this server. Please check your code for typos, or consult our API guide at http://guides.dataverse.org."")
++                             .add(""message"", ""'"" + uri + ""' "" + outputMessage)
+                         .build())
+                 .type(""application/json"").build();
+         ","This `startsWith` seems a bit brittle because in the code base we'll occasionally spell it ""DataFile"".","I think this should be `outputMessage.startsWith(""Datafile"")`"
+3989,"@@ -18,5 +18,6 @@ package azkaban.db;
+ 
+ public class AzDBUtil {
+ 
+-  static final int MAX_DB_RETRY_COUNT = 5;
++  // A very big Integer
++  static final int MAX_DB_RETRY_COUNT = 999999;
+ }","if it keeps reconnecting for too long, how should we get alerted?",Why did you change this?
+3990,"@@ -263,7 +263,11 @@ void* CNSKListenerSrvr::OpenTCPIPSession()
+ //LCOV_EXCL_STOP
+ 	}
+ 
+-
++    TCP_SetKeepalive(nSocketFnum,
++            srvrGlobal->clientKeepaliveStatus,
++            srvrGlobal->clientKeepaliveIdletime,
++            srvrGlobal->clientKeepaliveIntervaltime,
++            srvrGlobal->clientKeepaliveRetrycount);
+ 	pnode = GTransport.m_TCPIPSystemSrvr_list->ins_node(nSocketFnum);
+ 
+ 	if (pnode == NULL)",it's better to use single name style in one name.,Shouldn't this be `srvrGlobal->clientKeepaliveIntervaltime`?
+3991,"@@ -70,7 +70,7 @@ bool EprosimaServer::init()
+ {
+ 	//CREATE RTPSParticipant
+ 	ParticipantAttributes PParam;
+-	PParam.rtps.defaultSendPort = 10042;
++	//PParam.rtps.defaultSendPort = 10042; // TODO Create transport?
+ 	PParam.rtps.builtin.domainId = 80;
+ 	PParam.rtps.builtin.use_SIMPLE_EndpointDiscoveryProtocol = true;
+ 	PParam.rtps.builtin.use_SIMPLE_RTPSParticipantDiscoveryProtocol = true;","As defaultSendPort is being removed, and I don't like TODOs on examples, please remove the whole line",Why is this needed?
+3992,"@@ -95,7 +95,8 @@ func (cf CloudFormation) DelegateDNSPermissions(project *archer.Project, account
+ 	deployProject.DNSDelegationAccounts = append(dnsDelegatedAccounts, accountID)
+ 	updatedProjectConfig := stack.NewProjectStackConfig(&deployProject)
+ 
+-	if err := cf.update(updatedProjectConfig); err != nil {
++	// swallow the errChangeSetEmpty error since it just means there were no updates needed.
++	if err := cf.update(updatedProjectConfig); err != nil && err != errChangeSetEmpty {
+ 		return fmt.Errorf(""updating project to allow DNS delegation: %w"", err)
+ 	}
+ ",Should we return `nil` when `err == errChangeSetEmpty` instead of calling l.103 `WaitUntilStackUpdateCompleteWithContext`?,I don't think we want to swallow the error here.
+3993,"@@ -153,13 +153,12 @@ public abstract class VectorWriter implements Closeable {
+     private final DocIDMerger<VectorValuesSub> docIdMerger;
+     private final int[] ordBase;
+     private final int cost;
+-    private final int size;
++    private int size;
+ 
+     private int docId;
+     private VectorValuesSub current;
+-    // For each doc with a vector, record its ord in the segments being merged. This enables random
+-    // access into the
+-    // unmerged segments using the ords from the merged segment.
++    /* For each doc with a vector, record its ord in the segments being merged. This enables random access into the unmerged segments using the ords from the merged segment.
++     */
+     private int[] ordMap;
+     private int ord;
+ ","Hmmm I thought spotless would wrap this line, but it doesn't seem to complain about it",I don't think this change is necessary.
+3994,"@@ -47,10 +47,11 @@ type Selector struct {
+ 
+ // SpiffeIDSpec defines the desired state of SpiffeID
+ type SpiffeIDSpec struct {
+-	ParentId string   `json:""parentId""`
+-	SpiffeId string   `json:""spiffeId""`
+-	Selector Selector `json:""selector""`
+-	DnsNames []string `json:""dnsNames,omitempty""`
++	ParentId      string   `json:""parentId""`
++	SpiffeId      string   `json:""spiffeId""`
++	Selector      Selector `json:""selector""`
++	DnsNames      []string `json:""dnsNames,omitempty""`
++	FederatesWith []string `json:""federatesWith,omitempty""`
+ }
+ 
+ // SpiffeIDStatus defines the observed state of SpiffeID","I think this will require updating the api version. we are planning to do this anyways, so perhaps we can lump this in so we don't have to update too many times?",Why is this a slice of strings?
+3995,"@@ -215,13 +215,12 @@ public abstract class RSSceneMixin implements RSScene
+ 
+ 		for (int z = minLevel; z < maxY; ++z)
+ 		{
+-			RSTile[][] planeTiles = tiles[z];
+ 
+ 			for (int x = minTileX; x < maxTileX; ++x)
+ 			{
+ 				for (int y = minTileZ; y < maxTileZ; ++y)
+ 				{
+-					RSTile tile = planeTiles[x][y];
++					RSTile tile = tiles[z][x][y];
+ 					if (tile != null)
+ 					{
+ 						if (tile.getPhysicalLevel() <= plane",revert this for parity,Why did you remove this?
+3996,"@@ -15,6 +15,10 @@
+ #include <valgrind/helgrind.h>
+ #endif
+ 
++#define INITIAL_BATCH 100
++#define INCR_BATCH 50
++#define DECR_BATCH 25
++
+ enum
+ {
+   FLAG_BLOCKED = 1 << 0,","INCR_BATCH and DECR_BATCH could be exposed as tuneable command line options but that might be too low level to expose. I think keeping private for now where ""in the know"" folks could use to try and tune makes sense. These values were choosen mostly ""at random"" and have worked out for us thus far.",Why is this needed?
+3997,"@@ -27,6 +27,11 @@ static tagWriter *writerTable [WRITER_COUNT] = {
+ 
+ static tagWriter *writer;
+ 
++extern void setCustomTagWriter(tagWriter *w)
++{
++	writer = w;
++}
++
+ extern void setTagWriter (writerType wtype)
+ {
+ 	writer = writerTable [wtype];",Currently this isn't very clean because we have to re-use some of the predefined parser types - the demo uses WRITER_U_CTAGS but there should be some support for custom writer type.,Why do we need this
+3998,"@@ -1,6 +1,7 @@
+ module RequestSpecHelper
+   def get_json(url)
+     get(url)
++    puts response.pretty_inspect
+     JSON.parse(response.body)
+   end
+ ",I think this was left it accidentally :),Should this be remo
+3999,"@@ -64,12 +64,12 @@ func IsNamespaceSupported(ns NamespaceType) bool {
+ 
+ func NamespaceTypes() []NamespaceType {
+ 	return []NamespaceType{
++		NEWUSER, // Keep user NS always first, don't move it.
++		NEWIPC,
++		NEWUTS,
+ 		NEWNET,
+ 		NEWPID,
+ 		NEWNS,
+-		NEWUTS,
+-		NEWIPC,
+-		NEWUSER,
+ 	}
+ }
+ ",Can you finish re-ordering this list to match the one that was deleted?,Why is this removed
+4000,"@@ -342,6 +342,10 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo) error {
+ 		chaos.Spec.Duration = &exp.Scheduler.Duration
+ 	}
+ 
++	if exp.Target.StressChaos.ContainerName != nil {
++		chaos.Spec.ContainerName = exp.Target.StressChaos.ContainerName
++	}
++
+ 	return s.kubeCli.Create(context.Background(), chaos)
+ }
+ ",Do we need to check if `exp.Target.StressChaos` is `nil`?,Why do we need this?
+4001,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[CreateAccessKey.java demonstrates how to create an access key for an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[CreateAccessKey.java demonstrates how to create an access key for an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I'm not sure if this
+4002,"@@ -110,7 +110,6 @@ spec:
+   run:
+     tasks:
+     - cstor-volume-create-getstorageclass-default
+-    - cstor-volume-create-getpvc-default
+     - cstor-volume-create-listclonecstorvolumereplicacr-default
+     - cstor-volume-create-listcstorpoolcr-default
+     - cstor-volume-create-puttargetservice-default",not calling this is going to impact current functionality which depends on PVC.. let us still call this and set the values to default as 'none' (or empty) by handling the error from 'get' operation,Why is this removed?
+4003,"@@ -306,7 +306,9 @@ int ioctl(int fd, unsigned long request, ...)
+ 			if (gEnableIRQ && fme_irq->evtfd >= 0) {
+ 				uint64_t data = 1;
+ 				// Write to the eventfd to signal one IRQ event.
+-				write(fme_irq->evtfd, &data, sizeof(data));
++				if (write(fme_irq->evtfd, &data, sizeof(data)) != sizeof(data)) {
++					FPGA_ERR(""IRQ write < 8 bytes"");
++				}
+ 			}
+ 			retval = 0;
+ 			errno = 0;",`!=` is no the same as `<`,This should be `FPGA
+4004,"@@ -0,0 +1,8 @@
++from .transformer import (FFN, MultiheadAttention, Transformer,
++                          TransformerDecoder, TransformerDecoderLayer,
++                          TransformerEncoder, TransformerEncoderLayer)
++
++__all__ = [
++    'FFN', 'MultiheadAttention', 'Transformer', 'TransformerDecoder',
++    'TransformerDecoderLayer', 'TransformerEncoder', 'TransformerEncoderLayer'
++]",No need to create a dir for transformer. Simply move transformer.py into mmdet/models/utils/,I don't think we need this anymore.
+4005,"@@ -531,6 +531,10 @@ public class MainActivity extends CastEnabledActivity {
+             bottomSheetCallback.onSlide(null, 1.0f);
+         } else if (Intent.ACTION_VIEW.equals(intent.getAction())) {
+             handleDeeplink(intent.getData());
++        } else if (Intent.ACTION_CREATE_SHORTCUT.equals(intent.getAction())) {
++            intent = new Intent(this, SelectSubscriptionActivity.class);
++            intent.setAction(Intent.ACTION_CREATE_SHORTCUT);
++            startActivity(intent);
+         }
+         // to avoid handling the intent twice when the configuration changes
+         setIntent(new Intent(MainActivity.this, MainActivity.class));",Can't you just add `SelectSubscriptionActivity` directly to the manifest instead of opening `MainActivity` that then starts it?,I don't think you need to create a 
+4006,"@@ -46,6 +46,7 @@ var (
+ 	rpmsDir   = app.Flag(""rpm-dir"", ""Directory containing built RPMs."").Required().ExistingDir()
+ 	distTag   = app.Flag(""dist-tag"", ""The distribution tag the SPEC will be built with."").Required().String()
+ 	workerTar = app.Flag(""worker-tar"", ""Full path to worker_chroot.tar.gz.  If this argument is empty, specs will be parsed in the host environment."").ExistingFile()
++	runCheck  = app.Flag(""run-check"", ""Run the check during package build"").Bool()
+ 	logFile   = exe.LogFileFlag(app)
+ 	logLevel  = exe.LogLevelFlag(app)
+ )","Maybe say ""the spec's %check section"" so it's clearer what we mean.",This should be `Run the check durin
+4007,"@@ -649,7 +649,7 @@ class ColumnSorting extends BasePlugin {
+    * @returns {Number} Physical row index.
+    */
+   onModifyRow(row, source) {
+-    if (this.blockPluginTranslation === false && source !== this.pluginName) {
++    if (this.blockPluginTranslation === false && source !== this.pluginName && this.isSorted()) {
+       const rowInMapper = this.rowsMapper.getValueByIndex(row);
+       row = rowInMapper === null ? row : rowInMapper;
+     }","I think after change this check `rowInMapper === null` is always false, so it's useless.",Why do we need this change?
+4008,"@@ -166,7 +166,7 @@ func initClocks() {
+ 	nxp.ClockIpLpi2c2.Enable(false) //
+ 	nxp.ClockIpLpi2c3.Enable(false) //
+ 	nxp.DivIpLpi2c.Div(0)           // divide LPI2C_CLK_PODF (DIV1)
+-	nxp.MuxIpLpi2c.Mux(0)           // LPI2C select PLL3_SW_60M
++	nxp.MuxIpLpi2c.Mux(1)           // LPI2C select OSC
+ 
+ 	nxp.ClockIpCan1.Enable(false)  // disable CAN
+ 	nxp.ClockIpCan2.Enable(false)  //",ClockIpLpi2c4.Enable() is required. The same change is required for enablePeripheralClocks().,Why did you change this?
+4009,"@@ -67,6 +67,9 @@ type PrometheusSpec struct {
+ 	Version string `json:""version,omitempty""`
+ 	// Tag of Prometheus container image to be deployed. Defaults to the value of `version`.
+ 	Tag string `json:""tag,omitempty""`
++	// Sha of Prometheus container image to be deployed. Defaults to the value of `version`.
++	// Similar to a tag, but the sha explicitly deploys an immutable container image.
++	Sha string `json:""sha,omitempty""`
+ 	// When a Prometheus deployment is paused, no actions except for deletion
+ 	// will be performed on the underlying objects.
+ 	Paused bool `json:""paused,omitempty""`","nit: this should be `SHA` since it is an acronym for `Secure Hash Algorithm`, no?",Can we add a note here t
+4010,"@@ -27,6 +27,13 @@ import jstz from 'jstz'
+  * @returns {String} Current timezone of user
+  */
+ export default () => {
++	if (window.Intl && typeof window.Intl === 'object') {
++		const { timeZone } = Intl.DateTimeFormat().resolvedOptions()
++		if (timeZone) {
++			return timeZone
++		}
++	}
++
+ 	const determinedTimezone = jstz.determine()
+ 	if (!determinedTimezone) {
+ 		return 'UTC'",Not sure if Intl can be defined but not `Intl.DateTimeFormat`. Both seem to have the same percentage on CanIUse.,I think this should be `
+4011,"@@ -121,7 +121,7 @@ func (p *Provisioner) Provision(opts pvController.VolumeOptions) (*v1.Persistent
+ 	if reqMap != nil {
+ 		size = pvc.Spec.Resources.Requests[""storage""]
+ 	}
+-	sendEventOrIgnore(name, size.String(), stgType, analytics.VolumeProvision)
++	sendEventOrIgnore(pvc.Name, name, size.String(), stgType, analytics.VolumeProvision)
+ 	if stgType == ""hostpath"" {
+ 		return p.ProvisionHostPath(opts, pvCASConfig)
+ 	}","PTAL, looks like the order of PVC & PV is reversed for different storage-engine types, for Jiva/CStor the args sent to sendEventOrIgnore are `PV, PVCName`.",Why do we need to send t
+4012,"@@ -65,7 +65,7 @@ import vn.mbm.phimp.me.utils.RSSPhotoItem_Personal;
+ @SuppressWarnings(""deprecation"")
+ public class PhimpMe extends AppCompatActivity implements BottomNavigationView.OnNavigationItemSelectedListener //, android.view.GestureDetector.OnGestureListener
+ {
+-    public static Context ctx;
++    public static Context ctx ;
+     public static File DataDirectory;
+     public static final String PREFS_NAME = ""PhimpMePrefs"";
+     public static final String DATABASE_NAME = ""PhimpMe"";",Remove the trailing white space,Please revert this change.
+4013,"@@ -21,7 +21,7 @@ mmcv_version = digit_version(mmcv.__version__)
+ 
+ 
+ assert (mmcv_version >= digit_version(mmcv_minimum_version)
+-        and mmcv_version <= digit_version(mmcv_maximum_version)), \
++        and mmcv_version < digit_version(mmcv_maximum_version)), \
+     f'MMCV=={mmcv.__version__} is used but incompatible. ' \
+     f'Please install mmcv>={mmcv_minimum_version}, <={mmcv_maximum_version}.'
+ ",No need to modify this.,I think this should be `<=
+4014,"@@ -14,7 +14,7 @@ import (
+ 	madns ""github.com/multiformats/go-multiaddr-dns""
+ )
+ 
+-func Discover(ctx context.Context, addr ma.Multiaddr, f func(ma.Multiaddr) (stop bool, err error)) (stopped bool, err error) {
++func Discover(ctx context.Context, addr ma.Multiaddr, f func(ma.Multiaddr) (bool, error)) (bool, error) {
+ 	if comp, _ := ma.SplitFirst(addr); comp.Protocol().Name != ""dnsaddr"" {
+ 		return f(addr)
+ 	}",would be nice at some point to clean this signature up... not relevant for this PR,Why is this change needed?
+4015,"@@ -342,6 +342,12 @@ class Configurator
+                     ),
+                     $fieldConfiguration
+                 );
++
++                // if the 'type' is not set explicitly for a virtual field,
++                // consider it as a string, so the backend displays its contents
++                if (null === $normalizedConfiguration['type']) {
++                    $normalizedConfiguration['type'] = 'text';
++                }
+             } else {
+                 // this is a regular field that exists as a property of the related Doctrine entity
+                 $normalizedConfiguration = array_replace(","Here, is it `null` because it is `null` in `$fieldConfiguration`, or because it has been set to `null` above in the `array_replace` ? If it doesn't exists at all in `$fieldConfiguration`, I think you should add `type => 'text'` above in the `array_replace`.",Shouldn't this be `null !=
+4016,"@@ -620,7 +620,7 @@ public class JavaParserFacade {
+      * references an outer class -- as its ancestor, return the declaration corresponding to the class name specified.
+      */
+     protected Node findContainingTypeDeclOrObjectCreationExpr(Node node, String className) {
+-        if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().equals(className)) {
++        if (node instanceof ClassOrInterfaceDeclaration && ((ClassOrInterfaceDeclaration) node).getFullyQualifiedName().get().endsWith(className)) {
+             return node;
+         }
+         if (node instanceof EnumDeclaration) {","I was thinking about this for #2928 too, which also uses `endsWith`... Presumably `SomeOtherObject` would match `endsWith(""Object"")`, meaning that something more sophisticated like splitting it then iterating right to left would be needed in order to do this robustly?",Why is this change needed?
+4017,"@@ -51,5 +51,15 @@ namespace OpenTelemetry.Exporter.Zipkin
+         /// </summary>
+         public int? MaxPayloadSizeInBytes { get; set; } = DefaultMaxPayloadSizeInBytes;
+ #endif
++
++        /// <summary>
++        /// Gets or sets the exporter type for Zipkin Exporter.
++        /// </summary>
++        public ExporterType ExporterType { get; set; } = ExporterType.BatchExportProcessor;
++
++        /// <summary>
++        /// Gets or sets get or sets the BatchExportProcessor options.
++        /// </summary>
++        public BatchExportProcessorOptions BatchExportProcessorOptions { get; set; } = new BatchExportProcessorOptions();
+     }
+ }","I think this name is a bit confusing because if you asked someone what type of exporter they were using they would probably say Zipkin or Jaeger, etc. How about `ProcessorType` with `Simple` and `Batch` definitions?",Why do we need this?
+4018,"@@ -95,6 +95,12 @@ func (a *FakeWebAPI) RegisterPiped(ctx context.Context, req *webservice.Register
+ 	}, nil
+ }
+ 
++func (a *FakeWebAPI) RecreatePipedKey(ctx context.Context, req *webservice.RecreatePipedKeyRequest) (*webservice.RecreatePipedKeyResponse, error) {
++	return &webservice.RecreatePipedKeyResponse{
++		Key: ""9bf9752a-54a2-451a-a541-444add56f96b"",
++	}, nil
++}
++
+ func (a *FakeWebAPI) EnablePiped(ctx context.Context, req *webservice.EnablePipedRequest) (*webservice.EnablePipedResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`req` is unused in RecreatePipedKey,Why do we need this?
+4019,"@@ -85,11 +85,11 @@ export default function SetupAccountApproved() {
+ 			__( 'Site Kit detected AdSense code for a different account %s on your site. For a better ads experience, you should remove AdSense code that’s not linked to this AdSense account.', 'google-site-kit' ),
+ 			parseAccountID( existingTag )
+ 		);
+-		uncheckedMessage = __( 'By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.', 'google-site-kit' );
++		uncheckedMessage = __( 'Please note that Adsense will not show ads on your website unless you’ve already placed the code.', 'google-site-kit' );
+ 	} else {
+ 		// No existing tag.
+ 		showProfile = false;
+-		uncheckedMessage = __( 'By not placing the code, AdSense will not show ads on your website unless you’ve already got some AdSense code.', 'google-site-kit' );
++		uncheckedMessage = __( 'Please note that Adsense will not show ads on your website unless you’ve already placed the code.', 'google-site-kit' );
+ 	}
+ 
+ 	return (","The ""Adsense"" term needs to be capitalized - I just noticed this was wrong through ACs and IB, so not a problem of the PR itself really. I'll quickly fix it.",:ok: This change will be q
+4020,"@@ -45,11 +45,15 @@ func init() {
+ 	beam.RegisterFunction(defToDecorPiece)
+ 	beam.RegisterFunction(fileToDecorPiece)
+ 	beam.RegisterFunction(groupCrossRefs)
++	beam.RegisterFunction(groupEdges)
+ 	beam.RegisterFunction(keyByPath)
+ 	beam.RegisterFunction(keyRef)
+ 	beam.RegisterFunction(moveSourceToKey)
+ 	beam.RegisterFunction(nodeToDecorPiece)
++	beam.RegisterFunction(nodeToEdges)
++	beam.RegisterFunction(nodeToReverseEdges)
+ 	beam.RegisterFunction(refToDecorPiece)
++	beam.RegisterFunction(reverseEdge)
+ 	beam.RegisterFunction(toDefinition)
+ 	beam.RegisterFunction(toEnclosingFile)
+ 	beam.RegisterFunction(toFiles)",do which methods need to be registered? is it basically just the ones that are directly referenced in ParDo calls? (The Beam GoDoc doesn't say anything about it. :/ ),Why do we need these functions?
+4021,"@@ -143,7 +143,8 @@ public class Access extends AbstractApiBean {
+         
+         downloadInstance.setFileCitationEndNote(datasetService.createCitationXML(datasetVersion, fileMetadata));
+         downloadInstance.setFileCitationRIS(datasetService.createCitationRIS(datasetVersion, fileMetadata));
+-        
++        downloadInstance.setFileCitationBibtex(datasetService.createCitationBibtex(datasetVersion, fileMetadata));
++
+         ByteArrayOutputStream outStream = null;
+         outStream = new ByteArrayOutputStream();
+ ",@bmckinney does this mean that the bibtex citation will be available via API?,Why is this needed?
+4022,"@@ -28,11 +28,11 @@ if sys.version_info < (3,):
+     ])
+ 
+ POSTGRESQL_REQUIREMENTS = REQUIREMENTS + [
+-    'cliquet[postgresql]>=2.14,<3'
++    'cliquet[postgresql]>=2.15,<3'
+ ]
+ 
+ MONITORING_REQUIREMENTS = REQUIREMENTS + [
+-    'cliquet[monitoring]>=2.14,<3'
++    'cliquet[monitoring]>=2.15,<3'
+ ]
+ 
+ FXA_REQUIREMENTS = REQUIREMENTS + [",We should probably tag the cliquet-fxa version as well.,Why do we need to bump this?
+4023,"@@ -317,7 +317,7 @@ static socklen_t parse_hostport(h2o_mem_pool_t *pool, h2o_iovec_t host, h2o_iove
+                 4 &&
+             parsed_len == host.len && d1 <= UCHAR_MAX && d2 <= UCHAR_MAX && d3 <= UCHAR_MAX && d4 <= UCHAR_MAX) {
+             if (sscanf(port.base, ""%"" SCNd32 ""%n"", &_port, &parsed_len) == 1 && parsed_len == port.len && _port <= USHRT_MAX) {
+-                struct sockaddr_in sin;
++                struct sockaddr_in sin = {};
+                 sin.sin_family = AF_INET;
+                 sin.sin_port = htons(_port);
+                 sin.sin_addr.s_addr = ntohl((d1 << 24) + (d2 << 16) + (d3 << 8) + d4);","IIRC we need to use memset, because an empty brace is not C99 comformant, and because we cannot use `{0}` because how the struct is organized is not defined in POSIX (the initializer cannot be `{0}` if the first property of the struct is a struct).",Why do we need this change?
+4024,"@@ -434,6 +434,11 @@ type NetworkPolicyPeer struct {
+ 	//  Exact FQDNs, i.e. ""google.com"", ""db-svc.default.svc.cluster.local""
+ 	//  Wildcard expressions, i.e. ""*wayfair.com"".
+ 	FQDN string `json:""fqdn,omitempty""`
++	// Select all Pods with the ServiceAccount matched by this field, as
++	// workloads in AppliedTo/To/From fields.
++	// Cannot be set with any other selector.
++	// +optional
++	ServiceAccounts []ServiceAccount `json:""serviceAccounts,omitempty""`
+ }
+ 
+ type PeerNamespaces struct {","Will we be adding this to `AppliedTo` as well? If not, any reason why not?",I don't think we need to add this field to the `PeerNamespaces` struct.
+4025,"@@ -813,6 +813,13 @@ Tries to force this object to take the focus.
+ 		""""""
+ 		return False
+ 
++	def shouldAcceptShowHideCaretEvent(self):
++		""""""Some objects/applications send show/hide caret events when we don't expect it, such as when the cursor is blinking.
++		@return: if show/hide caret events should be accepted for this object.
++		@rtype: Boolean
++		""""""
++		return True
++
+ 	def reportFocus(self):
+ 		""""""Announces this object in a way suitable such that it gained focus.
+ 		""""""","Just a note that this feels weird being on the base NVDAObject rather than IAccessible, but right now, I understand that's how it has to be because we fire MSAA caret events on the focus object regardless of whether it's IAccessible. I think we should consider restricting these caret events to focus objects that are IAccessible subclasses in future, but that change is probably too risky for this PR. CC @MichaelDCurran for his thoughts.",I don't think we need this method.
+4026,"@@ -71,7 +71,9 @@ class PaymentController extends AdminBaseController
+     {
+         $paymentEditData = $this->paymentEditDataFactory->createDefault();
+ 
+-        $form = $this->createForm(PaymentEditFormType::class, $paymentEditData);
++        $form = $this->createForm(PaymentEditFormType::class, $paymentEditData, [
++            'payment_detail' => null,
++        ]);
+         $form->handleRequest($request);
+ 
+         if ($form->isSubmitted() && $form->isValid()) {",This change and other similar ones should not be part of this commit. This commit is about adding a ImageUploadType not fixing controllers and stuff.,Why do we need this?
+4027,"@@ -57,6 +57,7 @@ const (
+ 	leafNodeConnectEventSubj = ""$SYS.ACCOUNT.%s.LEAFNODE.CONNECT"" // for internal use only
+ 	remoteLatencyEventSubj   = ""$SYS.LATENCY.M2.%s""
+ 	inboxRespSubj            = ""$SYS._INBOX.%s.%s""
++	accConnzReqSubj          = ""$SYS.REQ.ACCOUNT.PING.CONNZ""
+ 
+ 	// FIXME(dlc) - Should account scope, even with wc for now, but later on
+ 	// we can then shard as needed.","I am a bit confused about PING here. Ping is implied and it overlaps with ""$SYS.REQ.ACCOUNT.%s.%s"" where the last token is what is requested (CONNZ) and the one before is the requested account id.",Why do we need this?
+4028,"@@ -708,3 +708,15 @@ func (v *volumeClient) CloudMigrateStatus() (*api.CloudMigrateStatusResponse, er
+ 	}
+ 	return statusResponse, nil
+ }
++
++// Du specified volume id and specifically path (if provided)
++func (v *volumeClient) Catalog(id, subfolder, maxDepth string) (api.CatalogResponse, error) {
++	var catalog api.CatalogResponse
++
++	req := v.c.Get().Resource(volumePath + ""/catalog"").Instance(id)
++	if err := req.QueryOption(api.OptCatalogSubFolder, subfolder).QueryOption(api.OptCatalogMaxDepth, maxDepth).Do().Unmarshal(&catalog); err != nil {
++		return catalog, err
++	}
++
++	return catalog, nil
++}","nit: use the OptSubFolder constants. Also in the client you are using ""maxdepth"" but in the server the constant for ""depth"" is being used.",Why do we need this?
+4029,"@@ -76,8 +76,8 @@ describe('Config file', () => {
+     test('parse docker.yaml', () => {
+       const config = new Config(parseConfigFile(resolveConf('docker')));
+       checkDefaultUplink(config);
+-      expect(config.storage).toBe('/verdaccio/storage');
+-      expect(config.auth.htpasswd.file).toBe('/verdaccio/conf/htpasswd');
++      expect(config.storage).toBe('/verdaccio/storage/data');
++      expect(config.auth.htpasswd.file).toBe('/verdaccio/storage/htpasswd');
+       checkDefaultConfPackages(config);
+     });
+ ","I also moved this to `/verdaccio/storage` since it's written in runtime, and the approach here is to make the configuration by default read-only.",Why is this change n
+4030,"@@ -318,13 +318,13 @@ public class NodeJSGapicContext extends GapicContext implements NodeJSContext {
+         resourceTypeName = ""a "" + jsTypeName(resourceType);
+       }
+       return callbackMessage
+-          + ""\n@returns {Stream|gax.EventEmitter}\n""
++          + ""\n@returns {Stream|Promise}\n""
+           + ""  An object stream which emits ""
+           + resourceTypeName
+           + "" on 'data' event.\n""
+           + ""  When the callback is specified or streaming is suppressed through options,\n""
+-          + ""  it will return an event emitter to handle the call status and the callback\n""
+-          + ""  will be called with the response object."";
++          + ""  it will return a promise that resolves to the response object. The promise\n""
++          + ""  has cancel method which cancels the ongoing API call."";
+     }
+ 
+     MessageType returnMessageType = method.getOutputMessage();",nit: s/has cancel method/has a cancel method,"""cancel method which"
+4031,"@@ -5,6 +5,16 @@ describe Quiz do
+ 
+   it { should have_many(:questions).dependent(:destroy) }
+ 
++  describe "".with_questions"" do
++    it ""returns only quizzes with questions"" do
++      first_quiz, second_quiz = create_pair(:quiz)
++
++      question = create(:question, quiz: first_quiz)
++
++      expect(Quiz.with_questions).to eq([first_quiz])
++    end
++  end
++
+   describe ""#first_question"" do
+     it ""returns the first question"" do
+       quiz = create(:quiz)",Useless assignment to variable - `second_quiz`. Use `_` or `_second_quiz` as a variable name to indicate that it won't be used.,Extra empty line det
+4032,"@@ -81,6 +81,9 @@ func (g Gzip) Validate() error {
+ // used in the Accept-Encoding request headers.
+ func (Gzip) AcceptEncoding() string { return ""gzip"" }
+ 
++// Suffix returns the filename suffix of precompressed files.
++func (Gzip) Suffix() string { return "".gz"" }
++
+ // NewEncoder returns a new gzip writer.
+ func (g Gzip) NewEncoder() encode.Encoder {
+ 	writer, _ := gzip.NewWriterLevel(nil, g.Level)",Is this still needed since there's the `GzipPrecompressed` type?,Why do we need this?
+4033,"@@ -29,6 +29,13 @@ from PyRegion import PyRegion
+ from nupic.algorithms.cla_classifier_factory import CLAClassifierFactory
+ 
+ 
++class _NumCatgoriesNotSpecified(Exception):
++  pass
++
++
++class _UnknownOutput(Exception):
++  pass
++
+ 
+ class CLAClassifierRegion(PyRegion):
+   """"""",this is spelled wrong and also not used so remove it,Why do we need these
+4034,"@@ -65,6 +65,7 @@ public abstract class ServerWebExchangeMatchers {
+ 	 * Matches any exchange
+ 	 * @return the matcher to use
+ 	 */
++	@SuppressWarnings(""Convert2Lambda"")
+ 	public static ServerWebExchangeMatcher anyExchange() {
+ 		// we don't use a lambda to ensure a unique equals and hashcode
+ 		// which otherwise can cause problems with adding multiple entries to an ordered LinkedHashMap",It might be right here that's the issue ^,Why is this needed?
+4035,"@@ -71,8 +71,10 @@ public interface SortedMap<K, V> extends Map<K, V>, Ordered<K> {
+     /**
+      * Returns the underlying key-comparator which defines the order of the elements contained in this map.
+      *
++     * @deprecated Use {@link SortedMap#comparator()} instead
+      * @return This map's key-comparator.
+      */
++    @Deprecated
+     Comparator<K> keyComparator();
+ 
+     /**",@danieldietrich let's leave existing extension. Here we just mark `keyComparator()` with `@Deprecated` annotation,Why do we need to de
+4036,"@@ -21,6 +21,7 @@ OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWA
+  * HIT_END
+  */
+ 
++#include <io.h>
+ #include <iostream>
+ #include <vector>
+ #include <stdio.h>",This breaks CI. I am not sure why you need to include io.h in this file especially on linux.,Why is this needed?
+4037,"@@ -48,7 +48,7 @@ export function render(vnode, parentDom, replaceNode) {
+ 			? [replaceNode]
+ 			: oldVNode
+ 			? null
+-			: parentDom.firstChild
++			: parentDom.childNodes.length
+ 			? slice.call(parentDom.childNodes)
+ 			: null,
+ 		commitQueue,",this seems equivalent,Why did this change
+4038,"@@ -371,10 +371,10 @@ func NewConfig(dc *dynamicconfig.Collection, numberOfShards int, storeType strin
+ 
+ 		BlobSizeLimitError:     dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitError, 2*1024*1024),
+ 		BlobSizeLimitWarn:      dc.GetIntPropertyFilteredByNamespace(dynamicconfig.BlobSizeLimitWarn, 512*1024),
+-		HistorySizeLimitError:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitError, 200*1024*1024),
+-		HistorySizeLimitWarn:   dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitWarn, 50*1024*1024),
+-		HistoryCountLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitError, 200*1024),
+-		HistoryCountLimitWarn:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitWarn, 50*1024),
++		HistorySizeLimitError:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitError, 20*1024*1024),
++		HistorySizeLimitWarn:   dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistorySizeLimitWarn, 5*1024*1024),
++		HistoryCountLimitError: dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitError, 20*1024),
++		HistoryCountLimitWarn:  dc.GetIntPropertyFilteredByNamespace(dynamicconfig.HistoryCountLimitWarn, 5*1024),
+ 
+ 		ThrottledLogRPS:   dc.GetIntProperty(dynamicconfig.HistoryThrottledLogRPS, 4),
+ 		EnableStickyQuery: dc.GetBoolPropertyFnWithNamespaceFilter(dynamicconfig.EnableStickyQuery, true),","change size to 50MB criticial, 10MB warn... change count to 50k critical, 5k warn...",Why are we changing
+4039,"@@ -1033,9 +1033,9 @@ public class FacetComponent extends SearchComponent {
+       }
+       
+       for (Entry<String,List<NamedList<Object>>> pivotFacetResponseFromShard : pivotFacetResponsesFromShard) {
+-        PivotFacet masterPivotFacet = fi.pivotFacets.get(pivotFacetResponseFromShard.getKey());
+-        masterPivotFacet.mergeResponseFromShard(shardNumber, rb, pivotFacetResponseFromShard.getValue());  
+-        masterPivotFacet.removeAllRefinementsForShard(shardNumber);
++        PivotFacet primaryPivotFacet = fi.pivotFacets.get(pivotFacetResponseFromShard.getKey());
++        primaryPivotFacet.mergeResponseFromShard(shardNumber, rb, pivotFacetResponseFromShard.getValue());
++        primaryPivotFacet.removeAllRefinementsForShard(shardNumber);
+       }
+     }
+     ","This has nothing to do with master/slave replication. Is this something we want to change too? If so, I guess this is an aggregation?",I think this should
+4040,"@@ -91,9 +91,12 @@ module RSpec
+           end
+ 
+           def dispatch_specs(run_descriptor)
+-            fork { run_specs(run_descriptor) }
++            pid = fork { run_specs(run_descriptor) }
+             # We don't use Process.waitpid here as it was causing bisects to
+-            # block due to the file descriptor limit on OSX / Linux.
++            # block due to the file descriptor limit on OSX / Linux. We need
++            # to detach the process to avoid having zombie process and consume
++            # slot in the kernel process table.
++            Process.detach(pid)
+           end
+ 
+         private","Maybe it makes sense to mention that those zombies are not forever, but only up to the moment when the parent process exits? Is that correct according to your observations, @benoittgt ? Please disregard this note if zombies remain after.",I don't think this is the right place to do this. We should be able to get rid of the `fork` and `waitpid` calls.
+4041,"@@ -543,7 +543,18 @@ def apply_patches():
+ def start_apigateway(port=None, backend_port=None, asynchronous=None, update_listener=None):
+     port = port or config.PORT_APIGATEWAY
+     apply_patches()
+-    result = start_moto_server(
++
++    # Why here?
++    # 1. The moto mocking has to happen before any usage of botocore, the import will register
++    #    a 'before-send-handler' event, thus intercepting the call to aws.
++    # 2. Then we start the specific service mocking, which basically starts the service backend.
++    #
++    from moto import mock_apigateway
++
++    mock = mock_apigateway()
++    mock.start()
++
++    return start_moto_server(
+         key=""apigateway"",
+         name=""API Gateway"",
+         asynchronous=asynchronous,",moto mock setup needs to happen before boto usage.,Why do we need to start the moto server?
+4042,"@@ -199,6 +199,8 @@ def train(params, train_set, num_boost_round=100,
+         callbacks = set()
+     else:
+         for i, cb in enumerate(callbacks):
++            if hasattr(cb, 'first_metric_only') and cb.first_metric_only and feval is not None:
++                raise LightGBMError(""`first_metric_only` and `feval` are not available at the same time."")
+             cb.__dict__.setdefault('order', i - len(callbacks))
+         callbacks = set(callbacks)
+ ","`hasattr(cb, 'first_metric_only') and cb.first_metric_only` -> `getattr(cb, 'first_metric_only', False)`","I think it would be better to use `LightGBMError('first_metric_only', ...)` here."
+4043,"@@ -107,3 +107,17 @@ func getProtoRequest(ctx context.Context, transportRequest *transport.Request, n
+ 	}
+ 	return ctx, call, request, nil
+ }
++
++type streamHandler struct {
++	handle     func(ServerStream) error
++}
++
++func newStreamHandler(
++	handle func(ServerStream) error,
++) *streamHandler {
++	return &streamHandler{handle}
++}
++
++func (s *streamHandler) HandleStream(stream transport.ServerStream) error {
++	return s.handle(stream)
++}",no newline for function,Why do we need this?
+4044,"@@ -240,7 +240,7 @@ static void config_head_handle_set_scale(struct wl_client *client,
+ 		return;
+ 	}
+ 
+-	double scale =  wl_fixed_to_double(scale_fixed);
++	float scale =  wl_fixed_to_double(scale_fixed);
+ 	if (scale <= 0) {
+ 		wl_resource_post_error(config_head_resource,
+ 			ZWLR_OUTPUT_CONFIGURATION_HEAD_V1_ERROR_INVALID_SCALE,","This makes me feel icky. We could also go the route of making `wlr_output.scale` a double instead of a float, but that would be a more widely reaching change.",Shouldn't this be `scale_fixed`?
+4045,"@@ -219,7 +219,7 @@ PQRYRES XMLColumns(PGLOBAL g, char *db, char *tab, PTOS topt, bool info)
+     while (true) {
+       if (!vp->atp &&
+ 				!(node = (vp->nl) ? vp->nl->GetItem(g, vp->k++, tdp->Usedom ? node : NULL)
+-				                  : NULL))
++				                  : NULL)) {
+         if (j) {
+           vp = lvlp[--j];
+ ","Again, would be awesome if you could remove the tabs in these 3-4 lines as well.",Why is this change needed?
+4046,"@@ -234,9 +234,14 @@ util::json::Object makeRouteStep(guidance::RouteStep step, util::json::Value geo
+     util::json::Object route_step;
+     route_step.values[""distance""] = std::round(step.distance * 10) / 10.;
+     route_step.values[""duration""] = std::round(step.duration * 10) / 10.;
+-    route_step.values[""name""] = std::move(step.name);
+-    if (!step.ref.empty())
++    route_step.values[""way_name""] = std::move(step.name);
++    if (step.ref.empty())
++        route.step.values[""name""] = std::move(step.name);
++    else
++    {
++        route_step.values[""name""] = std::move(step.name) << "" ("" << std::move(step.ref) << "")"";
+         route_step.values[""ref""] = std::move(step.ref);
++    }
+     if (!step.pronunciation.empty())
+         route_step.values[""pronunciation""] = std::move(step.pronunciation);
+     if (!step.destinations.empty())",You're moving multiple times from `step.name`; you're not allowed to do that. Instead you have to copy the `step.name` string and (if you want to) move once at the very last.,Why do we need this change?
+4047,"@@ -124,15 +124,15 @@ app.controller('EditorController', ['$scope', 'TimezoneService', 'AutoCompletion
+ 		$scope.validate = function() {
+ 			var error = false;
+ 			if ($scope.properties.summary === null || $scope.properties.summary.value.trim() === '') {
+-				OC.Notification.showTemporary(t('calendar', 'Please add a title!'));
++				OC.Notification.showTemporary(t('calendar', 'Please add a title.'));
+ 				error = true;
+ 			}
+ 			if ($scope.calendar === null || typeof $scope.calendar === 'undefined') {
+-				OC.Notification.showTemporary(t('calendar', 'Please select a calendar!'));
++				OC.Notification.showTemporary(t('calendar', 'Please select a calendar.'));
+ 				error = true;
+ 			}
+ 			if (!$scope.properties.checkDtStartBeforeDtEnd()) {
+-				OC.Notification.showTemporary(t('calendar', 'The event ends before it starts!'));
++				OC.Notification.showTemporary(t('calendar', 'The event can not end before it starts.'));
+ 				error = true;
+ 			}
+ ",What about `may not end`? @jancborchardt,"""The event can not end before it"
+4048,"@@ -1236,7 +1236,7 @@ func (a *WebAPI) validateApprover(stages []*model.PipelineStage, commander, stag
+ 			return nil
+ 		}
+ 	}
+-	return status.Error(codes.FailedPrecondition, fmt.Sprintf(""Could not approve the stage because %q isn't set as an approver."", commander))
++	return status.Error(codes.FailedPrecondition, fmt.Sprintf(""You can't approve this deployment because you (%s) are not in the approver list: %v"", commander, approvers))
+ }
+ 
+ func (a *WebAPI) GetApplicationLiveState(ctx context.Context, req *webservice.GetApplicationLiveStateRequest) (*webservice.GetApplicationLiveStateResponse, error) {","If you think about it, the status should be PermissionDenied?","return status.Error(codes.FailedPrecondition, fmt.Sprintf(""Could not approve the stage because you (%s) are not in the approver list: %v"", commander, approvers))"
+4049,"@@ -260,8 +260,7 @@ class MappingJobQueue(threading.Thread):
+                         low_quality_rate=stats[""low_quality""] - stats[""last_low_quality""],
+                         no_match_rate=stats[""no_match""] - stats[""last_no_match""],
+                         listens_per_sec=listens_per_sec,
+-                        listen_count=stats[""listen_count""],
+-                        listens_matched=stats[""listens_matched""],
++                        listens_matched_p=stats[""listens_matched""] / stats[""listen_count""] * 100.0,
+                         legacy_index_date=datetime.date.fromtimestamp(self.legacy_listens_index_date).strftime(""%Y-%m-%d""))
+ 
+             stats[""last_exact_match""] = stats[""exact_match""]",Calculation looks good but don't know what format etc grafana expects this to be in.,I think this should be `listens_matched_per_sec`
+4050,"@@ -722,6 +722,18 @@ class TestDockerClient:
+         assert env_variable in stdout
+         assert ""EXISTING_VAR=test_var"" in stdout
+ 
++    def test_run_with_additional_arguments_add_host(self, docker_client: ContainerClient):
++        additional_flags = ""--add-host sometest.localstack.cloud:127.0.0.1""
++        stdout, _ = docker_client.run_container(
++            ""alpine"",
++            remove=True,
++            command=[""getent"", ""hosts"", ""sometest.localstack.cloud""],
++            additional_flags=additional_flags,
++        )
++        stdout = stdout.decode(config.DEFAULT_ENCODING)
++        assert ""127.0.0.1"" in stdout
++        assert ""sometest.localstack.cloud"" in stdout
++
+     def test_get_container_ip_non_existing_container(self, docker_client: ContainerClient):
+         with pytest.raises(NoSuchContainer):
+             docker_client.get_container_ip(""hopefully_non_existent_container_%s"" % short_uid())",nit: We could use the `to_str(..)` util here. (let's not bother changing for this PR..   ),"I think it would be better to use `docker_client.get_container_ip(""sometest.localstack.cloud"")` here."
+4051,"@@ -29,6 +29,7 @@ import (
+ 	""time""
+ 
+ 	""github.com/gogo/protobuf/types""
++	executiongenproto ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	tasklistpb ""go.temporal.io/temporal-proto/tasklist""
+ )
+ ","Can you rename alias to `executiongenpb`. The rule is package+""pb"" for `temporal-proto` and package+""genpb"" for server protos.","""github.com/gogo/protobuf/proto"""
+4052,"@@ -261,7 +261,9 @@ func addNodeToResults(n *node, results *SublistResult) {
+ 		if i := findQSliceForSub(qr[0], results.qsubs); i >= 0 {
+ 			results.qsubs[i] = append(results.qsubs[i], qr...)
+ 		} else {
+-			results.qsubs = append(results.qsubs, qr)
++			copyqr := make([]*subscription, len(qr))
++			copy(copyqr, qr)
++			results.qsubs = append(results.qsubs, copyqr)
+ 		}
+ 	}
+ }",Any noticeable performance hit? Any other way to avoid the allocation and copy even of the array?,Why do we need to copy?
+4053,"@@ -234,8 +234,8 @@ func (i2c I2C) readByte() byte {
+ func (i2c I2C) readLastByte() byte {
+ 	for i2c.Bus.EVENTS_RXDREADY == 0 {
+ 	}
+-	i2c.Bus.EVENTS_RXDREADY = 0
+ 	i2c.signalStop() // signal 'stop' now, so it is sent when reading RXD
++	i2c.Bus.EVENTS_RXDREADY = 0
+ 	return byte(i2c.Bus.RXD)
+ }
+ ",What if you remove this line entirely from here?,Why this change?
+4054,"@@ -124,11 +124,13 @@ class PAFPN(FPN):
+                     outs.append(F.max_pool2d(outs[-1], 1, stride=2))
+             # add conv layers on top of original feature maps (RetinaNet)
+             else:
+-                if self.extra_convs_on_inputs:
++                if self.add_extra_convs == 'on_input':
+                     orig = inputs[self.backbone_end_level - 1]
+                     outs.append(self.fpn_convs[used_backbone_levels](orig))
+-                else:
++                elif self.add_extra_convs == 'on_output':
+                     outs.append(self.fpn_convs[used_backbone_levels](outs[-1]))
++                else:
++                    raise NotImplementedError
+                 for i in range(used_backbone_levels + 1, self.num_outs):
+                     if self.relu_before_extra_convs:
+                         outs.append(self.fpn_convs[i](F.relu(outs[-1])))",`on_lateral` can also be implemented,Why do we need this cha
+4055,"@@ -67,11 +67,14 @@ public class ItunesAdapter extends ArrayAdapter<PodcastSearchResult> {
+ 
+         //Set the title
+         viewHolder.titleView.setText(podcast.title);
+-        if(podcast.feedUrl != null && !podcast.feedUrl.contains(""itunes.apple.com"")) {
+-            viewHolder.urlView.setText(podcast.feedUrl);
+-            viewHolder.urlView.setVisibility(View.VISIBLE);
++        if(podcast.author != null && ! podcast.author.trim().isEmpty()) {
++            viewHolder.authorView.setText(podcast.author);
++            viewHolder.authorView.setVisibility(View.VISIBLE);
++        } else if(podcast.feedUrl != null && !podcast.feedUrl.contains(""itunes.apple.com"")) {
++            viewHolder.authorView.setText(podcast.feedUrl);
++            viewHolder.authorView.setVisibility(View.VISIBLE);
+         } else {
+-            viewHolder.urlView.setVisibility(View.GONE);
++            viewHolder.authorView.setVisibility(View.GONE);
+         }
+ 
+         //Update the empty imageView with the image from the feed",Please add a space between `if` and `(`.,Shouldn't this be `!pod
+4056,"@@ -30,6 +30,12 @@ import (
+ const (
+ 	PoolOperator           = ""zpool""
+ 	StatusNoPoolsAvailable = ""no pools available""
++	ZpoolStatusDegraded    = ""DEGRADED""
++	ZpoolStatusFaulted     = ""FAULTED""
++	ZpoolStatusOffline     = ""OFFLINE""
++	ZpoolStatusOnline      = ""ONLINE""
++	ZpoolStatusRemoved     = ""REMOVED""
++	ZpoolStatusUnavail     = ""UNAVAIL""
+ )
+ 
+ //PoolAddEventHandled is a flag representing if the pool has been initially imported or created","This statuses might have been better off with some custom status type. However, good for now.",I think this should be `ZpoolStatusUnavailable`
+4057,"@@ -165,9 +165,11 @@ func GetIPNetDeviceByName(ifaceName string) (v4IPNet *net.IPNet, v6IPNet *net.IP
+ 		if ipNet, ok := addr.(*net.IPNet); ok {
+ 			if ipNet.IP.IsGlobalUnicast() {
+ 				if ipNet.IP.To4() != nil {
++					if v4IPNet == nil {
++						v4IPNet = ipNet
++					}
++				} else if v6IPNet == nil {
+ 					v6IPNet = ipNet
+-				} else {
+-					v4IPNet = ipNet
+ 				}
+ 			}
+ 		}",Thanks for catching the bug. Here your change lets `v4IPNet` and `v6IPNet` take the first IPv4/IPv6 address in `addrList`. Maybe choose the last one also works and makes code simpler? What's your idea? @tnqn,Why is this change needed?
+4058,"@@ -680,8 +680,12 @@ class UserResource(object):
+         try:
+             return self.model.get_record(record_id)
+         except storage_exceptions.RecordNotFoundError:
+-            response = http_error(HTTPNotFound(),
+-                                  errno=ERRORS.INVALID_RESOURCE_ID)
++            detail_dict = {
++                ""id"": record_id,
++                ""resource_name"": ""record""
++            }
++            response = http_error(HTTPNotFound(), errno=ERRORS.INVALID_RESOURCE_ID,
++                                  details=detail_dict)
+             raise response
+ 
+     def _add_timestamp_header(self, response, timestamp=None):",nitpick: you can name this variable just `details`,Why do we need this?
+4059,"@@ -0,0 +1,18 @@
++#include ""general.h""
++#include ""parse.h""
++
++static void installJadeParser (const langType language)
++{
++  addTagRegex(language, ""^mixin[ \t]*([a-sA-Z0-9_]+)"", ""\\1"", ""d,definition"", NULL);
++}
++
++
++extern parserDefinition* JadeParser (void)
++{
++  static const char* extensions[] = { ""jade"", NULL };
++  parserDefinition* def = parserNew(""Jade"");
++  def->extensions       = extensions;
++  def->initialize       = installJadeParser;
++  def->method           = METHOD_REGEX;
++  return def;
++}","The character class in the regex should probably be ""[a-zA-Z0-9_]"".",Why is this needed?
+4060,"@@ -290,12 +290,6 @@ public class GlobalSettings {
+         s.put(""pgpSignOnlyDialogCounter"", Settings.versions(
+                 new V(45, new IntegerRangeSetting(0, Integer.MAX_VALUE, 0))
+         ));
+-        s.put(""openPgpProvider"", Settings.versions(
+-                new V(46, new StringSetting(K9.NO_OPENPGP_PROVIDER))
+-        ));
+-        s.put(""openPgpSupportSignOnly"", Settings.versions(
+-                new V(47, new BooleanSetting(false))
+-        ));
+         s.put(""fontSizeMessageViewBCC"", Settings.versions(
+                 new V(48, new FontSizeSetting(FontSizes.FONT_DEFAULT))
+         ));",Please also increment `Settings.VERSION` and update `AccountSettings`.,Why is this being removed?
+4061,"@@ -18,6 +18,12 @@ import (
+ 	""time""
+ )
+ 
++var builddate string // set by the Makefile
++
++func versionString() string {
++	return ""Weave of "" + builddate
++}
++
+ func ensureInterface(ifaceName string, wait bool) (iface *net.Interface, err error) {
+ 	iface, err = findInterface(ifaceName)
+ 	if err == nil || !wait {","I think this should just say ""build <date>"". And when builddate wasn't set, e.g. somebody built weave with 'go build' or some other way, this should return ""unknown"".",`builddate` is unused (fro
+4062,"@@ -142,7 +142,8 @@ public class BaseRewriteManifestsSparkAction
+ 
+   @Override
+   public RewriteManifests.Result execute() {
+-    JobGroupInfo info = newJobGroupInfo(""REWRITE-MANIFESTS"", ""REWRITE-MANIFESTS"");
++    JobGroupInfo info = newJobGroupInfo(""REWRITE-MANIFESTS"",
++        String.format(""Rewriting manifests(staging location=%s) of %s"", stagingLocation, table.name()));
+     return withJobGroupInfo(info, this::doExecute);
+   }
+ ",Can we move this into a separate var and call it `desc` like below?,"nit: ""Rewriting manifests "
+4063,"@@ -19,6 +19,14 @@ package io.servicecomb.demo.pojo.server;
+ import java.util.Arrays;
+ import java.util.List;
+ 
++import javax.ws.rs.core.MediaType;
++
++import org.springframework.web.bind.annotation.RequestBody;
++import org.springframework.web.bind.annotation.RequestMapping;
++import org.springframework.web.bind.annotation.RequestMethod;
++import org.springframework.web.bind.annotation.RequestParam;
++import org.springframework.web.bind.annotation.ResponseBody;
++
+ import io.servicecomb.demo.server.Test;
+ import io.servicecomb.demo.server.TestRequest;
+ import io.servicecomb.demo.server.User;",why RpcSchema need this annotations?,Please remove unused impor
+4064,"@@ -1673,7 +1673,9 @@ func (s *Server) debugSubscribers(sub *subscription, c *client, subject, reply s
+ 		}
+ 		// Cleanup the WC entry.
+ 		s.mu.Lock()
+-		delete(s.sys.replies, replySubj)
++		if s.sys != nil && s.sys.replies != nil {
++			delete(s.sys.replies, replySubj)
++		}
+ 		s.mu.Unlock()
+ 		// Send the response.
+ 		s.sendInternalAccountMsg(nil, reply, atomic.LoadInt32(&nsubs))","Not sure it makes sense to send the reply if we did not delete from the map, but I guess it does not hurt..",Why do we need this check?
+4065,"@@ -187,10 +187,11 @@ DataMap.prototype.getSchema = function() {
+  * @returns {Number} Returns number of created rows.
+  */
+ DataMap.prototype.createRow = function(index, amount, source) {
+-  var row,
+-    colCount = this.instance.countCols(),
+-    numberOfCreatedRows = 0,
+-    currentIndex;
++  let row = null;
++  let colCount = this.instance.countCols();
++  let numberOfCreatedRows = 0;
++  let currentIndex = null;
++  let continueProcess = null;
+ 
+   if (!amount) {
+     amount = 1;",Most of these variables can be moved after `return` or to the body of `if` statement.,`continueProcess` -> `cont
+4066,"@@ -115,6 +115,10 @@ public enum JsonRpcError {
+   DECODE_ERROR(-50100, ""Unable to decode the private signed raw transaction""),
+   GET_PRIVATE_TRANSACTION_NONCE_ERROR(-50100, ""Unable to determine nonce for account in group.""),
+ 
++  // Privacy multi-tenancy errors
++  PRIVACY_MULTI_TENANCY_NO_TOKEN(-50100, ""No token provided""),
++  PRIVACY_MULTI_TENANCY_NO_ENCLAVE_PUBLIC_KEY(-50100, ""No privacy enclave public key""),
++
+   CANT_CONNECT_TO_LOCAL_PEER(-32100, ""Cannot add local node as peer.""),
+ 
+   // Invalid input errors","nit: Is this actually just a http ""unauthorised"" response? Or is that too vague? If this is the right way to go ... is ""token"" the right word"" Or do we want to say something else?",I think this should be `PR
+4067,"@@ -247,7 +247,7 @@ module Bolt
+ 
+     def puppetdb_client
+       return @puppetdb_client if @puppetdb_client
+-      puppetdb_config = Bolt::PuppetDB::Config.load_config(nil, config.puppetdb)
++      puppetdb_config = Bolt::PuppetDB::Config.load_config(nil, config.puppetdb, config.boltdir.path)
+       @puppetdb_client = Bolt::PuppetDB::Client.new(puppetdb_config)
+     end
+ ","We check for `$future` in PuppetDB::Config, so this won't change behavior if you don't have `future` set.",`config.boltdir.path` shou
+4068,"@@ -1279,6 +1279,8 @@ class _Frame(object):
+             col_by = [_resolve_col(df, col_or_s) for col_or_s in by]
+             return DataFrameGroupBy(df_or_s, col_by, as_index=as_index)
+         if isinstance(df_or_s, Series):
++            if not isinstance(by[0], Series):
++                raise KeyError(by[0])
+             col = df_or_s  # type: Series
+             anchor = df_or_s._kdf
+             col_by = [_resolve_col(anchor, col_or_s) for col_or_s in by]","I think you should remove `if isinstance(by, str):`,. We also should fix the error message `raise ValueError('Not a valid index: TODO')` to match with pandas'",I think this should be `TypeError`
+4069,"@@ -48,6 +48,7 @@ namespace OpenTelemetry.Instrumentation.Grpc.Implementation
+ 
+             activity.SetKind(ActivityKind.Client);
+             activity.DisplayName = grpcMethod?.Trim('/');
++            activity.SetCustomProperty(""GrpcHandler.Request"", request);
+ 
+             this.activitySource.Start(activity);
+ ","Curious - do we want this to be `OTel.GrpcHandler.Request`? For example, if someone is debugging a crash dump, they would get some hint that it was added by OpenTelemetry.",Why is this needed?
+4070,"@@ -52,6 +52,12 @@ public interface TableOperations {
+    * Implementations must check that the base metadata is current to avoid overwriting updates.
+    * Once the atomic commit operation succeeds, implementations must not perform any operations that
+    * may fail because failure in this method cannot be distinguished from commit failure.
++   * <p></p>
++   * Implementations must throw a CommitStateUnknownException in cases where it cannot be determined if the
++   * commit succeeded or failed. For example if a network partition causes the confirmation of the commit to be lost,
++   * the implementation should throw a CommitStateUnknownException. This is important because downstream users of
++   * this API need to know whether they can clean up the commit or not, if the state is unknown then it is not safe
++   * to remove any files. All other exceptions will be treated as if the commit has failed.
+    *
+    * @param base     table metadata on which changes were based
+    * @param metadata new table metadata with updates",nit: unnecessary `</p>`,"nit: ""If the state is unknown then"
+4071,"@@ -194,7 +194,16 @@ std::shared_ptr<Engine> ADIOS::Open(const std::string &name,
+                                     ""HDF5 library, can't use HDF5\n"");
+ #endif
+     }
+-
++    else if (type == ""HDF5Reader"") // -Junmin
++    {
++#if defined(ADIOS_HAVE_PHDF5) && defined(ADIOS_HAVE_MPI)
++        return std::make_shared<HDF5Reader>(*this, name, accessMode, mpiComm,
++                                            method);
++#else
++        throw std::invalid_argument(""ERROR: this version didn't compile with ""
++                                    ""HDF5 library, can't use HDF5\n"");
++#endif
++    }
+     else
+     {
+         if (m_DebugMode == true)",Should just be `#ifdef ADIOS2_HAVE_HDF5`,I don't think you need to check fo
+4072,"@@ -1691,7 +1691,11 @@ def add_default_resource_props(
+         props[""LogGroupName""] = resource_name
+ 
+     elif res_type == ""AWS::Lambda::Function"" and not props.get(""FunctionName""):
+-        props[""FunctionName""] = ""{}-lambda-{}"".format(stack_name[:45], short_uid())
++        # FunctionName is up to 64 characters long
++        random_id_part = short_uid()
++        resource_id_part = resource_id[:24]
++        stack_name_part = stack_name[: 63 - 2 - (len(random_id_part) + len(resource_id_part))]
++        props[""FunctionName""] = f""{stack_name_part}-{resource_id_part}-{random_id_part}""
+ 
+     elif res_type == ""AWS::SNS::Topic"" and not props.get(""TopicName""):
+         props[""TopicName""] = ""topic-%s"" % short_uid()","FYI: I deployed a stack with multiple lengths for the stack name and resource id to cloudformation, to see how it truncates the parts for the final FunctionName",I'm not sure if this is the best way to do this. I think it would be better to use `resource_id[:24]` instead of `resource_id[:24]`
+4073,"@@ -301,7 +301,6 @@ func (w *WorkloadInitializer) newLoadBalancedWebServiceManifest(i *ServiceProps)
+ 		},
+ 		Port:        i.Port,
+ 		HealthCheck: i.HealthCheck,
+-		AppDomain:   i.appDomain,
+ 		Path:        ""/"",
+ 	}
+ 	existingSvcs, err := w.Store.ListServices(i.App)",Did we not use this field @_@,Why is this removed?
+4074,"@@ -83,6 +83,10 @@ const Config = function () {
+   this.extraGnArgs = {}
+   this.extraNinjaOpts = []
+   this.braveSafetyNetApiKey = getNPMConfig(['brave_safetynet_api_key']) || ''
++  this.androidKeystorePath = getNPMConfig(['android_keystore_path']) || ''
++  this.androidKeyAlias = getNPMConfig(['android_key_alias']) || ''
++  this.androidKeystorePassword = getNPMConfig(['android_keystore_password']) || ''
++  this.androidKeyPassword = getNPMConfig(['android_key_password']) || ''
+ }
+ 
+ Config.prototype.buildArgs = function () {",shouldn't this be `android_keystore_name`?,Shouldn't this be `|| ''`?
+4075,"@@ -39,7 +39,12 @@ func (c *controller) issuersForSecret(secret *corev1.Secret) ([]*v1alpha2.Cluste
+ 		}
+ 		if (iss.Spec.ACME != nil && iss.Spec.ACME.PrivateKey.Name == secret.Name) ||
+ 			(iss.Spec.CA != nil && iss.Spec.CA.SecretName == secret.Name) ||
+-			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.TokenSecretRef.Name == secret.Name) {
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.TokenSecretRef != nil &&
++				iss.Spec.Vault.Auth.TokenSecretRef.Name == secret.Name) ||
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.Kubernetes != nil &&
++				iss.Spec.Vault.Auth.Kubernetes.SecretRef.Name == secret.Name) ||
++			(iss.Spec.Vault != nil && iss.Spec.Vault.Auth.AppRole != nil &&
++				iss.Spec.Vault.Auth.AppRole.SecretRef.Name == secret.Name) {
+ 			affected = append(affected, iss)
+ 			continue
+ 		}",Double check the issuers package too :),I don't think you need to check for `nil` here.
+4076,"@@ -170,7 +170,7 @@ TYPING_NAMES = frozenset(
+ 
+ 
+ class VariableVisitConsumerAction(Enum):
+-    """"""Used after _visit_consumer to determine the action to be taken
++    """"""Used after _check_consumer to determine the action to be taken
+ 
+     Continue -> continue loop to next consumer
+     Return -> return and thereby break the loop",This is out of date right? Now that `_is_first_level_self_reference` uses it as well? Perhaps we should make the docstring more general and not refer to method names that could change.,I don't think this should be renamed.
+4077,"@@ -305,6 +305,7 @@ func createK8sAppMonitoring(
+ }
+ 
+ func testPromRemoteWriteWithTLS(t *testing.T) {
++	t.Parallel()
+ 	// can't extend the names since ns cannot be created with more than 63 characters
+ 	tests := []testFramework.PromRemoteWriteTestConfig{
+ 		// working configurations","This test alone takes around 10-12 minutes to run. It has 20 subtests each of which takes around one minute. We should see if we there are redundant subtests that we can remove, or look for a way to optimize them.",Why do we need this?
+4078,"@@ -10,11 +10,14 @@ import options from '../options';
+  * @param {boolean} isSvg Whether or not this node is an SVG node
+  */
+ export function diffProps(dom, newProps, oldProps, isSvg) {
+-	for (let i in newProps) {
+-		if (i!=='children' && i!=='key' && (!oldProps || ((i==='value' || i==='checked') ? dom : oldProps)[i]!==newProps[i])) {
+-			setProperty(dom, i, newProps[i], oldProps[i], isSvg);
++	let keys = Object.keys(newProps).sort();
++	for (let i = 0; i < keys.length; i++) {
++		let k = keys[i];
++		if (k!=='children' && k!=='key' && (!oldProps || ((k==='value' || k==='checked') ? dom : oldProps)[k]!==newProps[k])) {
++			setProperty(dom, k, newProps[k], oldProps[k], isSvg);
+ 		}
+ 	}
++
+ 	for (let i in oldProps) {
+ 		if (i!=='children' && i!=='key' && (!newProps || !(i in newProps))) {
+ 			setProperty(dom, i, null, oldProps[i], isSvg);","Good call, we need to keep that check :+1:",Why do we need to sort here?
+4079,"@@ -11,5 +11,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+         bool ParseRequestLine(TRequestHandler handler, in ReadOnlySequence<byte> buffer, out SequencePosition consumed, out SequencePosition examined);
+ 
+         bool ParseHeaders(TRequestHandler handler, in ReadOnlySequence<byte> buffer, out SequencePosition consumed, out SequencePosition examined, out int consumedBytes);
++
++        bool ParseRequestLine(TRequestHandler handler, ref BufferReader<byte> reader);
++
++        bool ParseHeaders(TRequestHandler handler, ref BufferReader<byte> reader);
+     }
+ }",Should the interface have 2 `ParseHeaders` methods?,nit: `ref BufferReader<byte>`
+4080,"@@ -87,9 +87,11 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+   private static final String HIVE_LOCK_CHECK_MIN_WAIT_MS = ""iceberg.hive.lock-check-min-wait-ms"";
+   private static final String HIVE_LOCK_CHECK_MAX_WAIT_MS = ""iceberg.hive.lock-check-max-wait-ms"";
+   private static final String HIVE_TABLE_LEVEL_LOCK_EVICT_MS = ""iceberg.hive.table-level-lock-evict-ms"";
++  private static final String HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES = ""hive.iceberg.metadata.refresh.max.retries"";
+   private static final long HIVE_ACQUIRE_LOCK_TIMEOUT_MS_DEFAULT = 3 * 60 * 1000; // 3 minutes
+   private static final long HIVE_LOCK_CHECK_MIN_WAIT_MS_DEFAULT = 50; // 50 milliseconds
+   private static final long HIVE_LOCK_CHECK_MAX_WAIT_MS_DEFAULT = 5 * 1000; // 5 seconds
++  private static final int HIVE_ICEBERG_METADATA_REFRESH_MAX_RETRIES_DEFAULT = 2;
+   private static final long HIVE_TABLE_LEVEL_LOCK_EVICT_MS_DEFAULT = TimeUnit.MINUTES.toMillis(10);
+   private static final DynMethods.UnboundMethod ALTER_TABLE = DynMethods.builder(""alter_table"")
+       .impl(IMetaStoreClient.class, ""alter_table_with_environmentContext"",",Nit: Does this make more sense as `iceberg.hive.metadata...`? The rest of the configs seem to start with `iceberg.hive`.,I think this should be `iceberg.hive.metadata.refresh.max.retries`
+4081,"@@ -184,6 +184,17 @@ func ValidateACMEIssuerDNS01Config(iss *v1alpha1.ACMEIssuerDNS01Config, fldPath
+ 				}
+ 			}
+ 		}
++		if p.DNSMadeEasy != nil {
++			if numProviders > 0 {
++				el = append(el, field.Forbidden(fldPath.Child(""dnsmadeeasy""), ""may not specify more than one provider type""))
++			} else {
++				numProviders++
++				el = append(el, ValidateSecretKeySelector(&p.DNSMadeEasy.SecretKey, fldPath.Child(""dnsmadeeasy"", ""secretKeySecretRef""))...)
++				if len(p.DNSMadeEasy.APIKey) == 0 {
++					el = append(el, field.Required(fldPath.Child(""dnsmadeeasy"", ""apiKey""), """"))
++				}
++			}
++		}
+ 		if p.Route53 != nil {
+ 			if numProviders > 0 {
+ 				el = append(el, field.Forbidden(fldPath.Child(""route53""), ""may not specify more than one provider type""))",Is `baseURL` not required?,I don't think we need to validate the API key here. If the API key
+4082,"@@ -101,6 +101,7 @@ class EmbeddingRPNHead(nn.Module):
+         """"""Forward function in testing stage.""""""
+         return self._decode_init_proposals(img, img_metas)
+ 
++    # TODO: is right ?
+     def show_result(self, data):
+         """"""Show the init proposals in EmbeddingRPN.
+ ","Just delete it, `embedding_rpn_head` is not a `Detector` which should have `show_result`.",Why is it right ?
+4083,"@@ -7,6 +7,12 @@ namespace Datadog.Trace.ClrProfiler.ExtensionMethods
+         internal static string GetHttpMethod(this ISpan span)
+             => span.GetTag(Tags.HttpMethod);
+ 
++        internal static string GetHost(this ISpan span)
++            => span.GetTag(Tags.HttpRequestHeadersHost);
++
++        internal static string GetAbsoluteUrl(this ISpan span)
++            => span.GetTag(Tags.HttpUrl);
++
+         internal static void DecorateWebServerSpan(
+             this Span span,
+             string resourceName,","Where do we _get_ tag values? edit: I mean, where are these `GetFoo()` methods called from? It just seems weird to me that we are getting tag values from spans. I thought we only ever _set_ tags on spans.",Nit: I think this should be `GetAbsoluteUrl(this ISpan span)`
+4084,"@@ -197,6 +197,7 @@ func NewReader(r io.ReaderAt, size int64) (*Reader, error) {
+ 	if err != nil {
+ 		return nil, err
+ 	}
++	log.Printf(""Reading kzip with %v encoding"", pref)
+ 	return &Reader{
+ 		zip:         archive,
+ 		root:        root,",This seems like log spam. Maybe expose the encoding as a method and log at the point of interest?,"Should this be `log.Printf(""Reading kzip with %v encoding"", pref)`?"
+4085,"@@ -464,7 +464,7 @@ PCO_PROTOCOL_TYPES = {
+     0x000c: 'P-CSCF IPv4 Address Request',
+     0x0010: 'IPv4 Link MTU Request',
+     0x8021: 'IPCP',
+-    0xc023: 'Password Authentification Protocol',
++    0xc023: 'Password Authentication Protocol',
+     0xc223: 'Challenge Handshake Authentication Protocol',
+ }
+ ","I looked up that one, and it seems correct: Authentification is French, Authentication seems to be correct",Why did you change this?
+4086,"@@ -22,9 +22,13 @@
+ """"""
+ Plot class used in monitor mixin framework.
+ """"""
+-import matplotlib.pyplot as plt
+-import matplotlib.cm as colorModel
++import traceback
+ 
++try:
++  # We import in here to avoid creating a matplotlib dependency in nupic.
++  import matplotlib.pyplot as plt
++except ImportError:
++  print traceback.format_exc() + ""\n""
+ 
+ 
+ class Plot(object):","Can we print a more human-friendly warning here, saying that plotting won't work or something along those lines?",Why is this needed?
+4087,"@@ -1,13 +1,15 @@
+ import html
+ import time
+ from typing import Optional, Tuple
+-from mitmproxy import connections
++
+ from mitmproxy import flow
+ from mitmproxy import version
+ from mitmproxy.net import http
++from mitmproxy.proxy import context
+ 
+ HTTPRequest = http.Request
+ HTTPResponse = http.Response
++HTTPMessage = http.Message
+ 
+ 
+ class HTTPFlow(flow.Flow):",@mhils didn't we try to get rid of these (now empty) wrapper classes?,I don't think we need this anymore.
+4088,"@@ -19,6 +19,7 @@ import (
+ 
+ 	log ""github.com/sirupsen/logrus""
+ 
++	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/libcalico-go/lib/set""
+ )
+ ",I would avoid importing `felix/ipsets` package because this package is the windows equivalent and should be at the same level of `felix/ipsets`. We could add linux specific dependencies into `felix/ipsets` later and it will break Windows build.,import (
+4089,"@@ -137,4 +137,13 @@ public interface Catalog {
+    * @throws NoSuchTableException if the table does not exist
+    */
+   Table loadTable(TableIdentifier identifier);
++
++  /**
++   * Register a table.
++   *
++   * @param identifier a table identifier
++   * @param metadataFileLocation the location of a metadata file
++   * @return a Table instance
++   */
++  Table registerTable(TableIdentifier identifier, String metadataFileLocation);
+ }","Maybe, `import` would be a better name.",Why do w
+4090,"@@ -21,10 +21,11 @@ import java.util.List;
+ public class ProtoPagingParameters implements PagingParameters {
+   private static final String PARAMETER_PAGE_TOKEN = ""page_token"";
+   private static final String PARAMETER_NEXT_PAGE_TOKEN = ""next_page_token"";
+-  private static final String PARAMETER_MAX_RESULTS = ""page_size"";
++  private static final String PARAMETER_PAGE_SIZE = ""page_size"";
++  private static final String PARAMETER_MAX_RESULTS = ""max_results"";
+ 
+   private static final ImmutableList<String> IGNORED_PARAMETERS =
+-      ImmutableList.of(PARAMETER_PAGE_TOKEN, PARAMETER_MAX_RESULTS);
++      ImmutableList.of(PARAMETER_PAGE_TOKEN, PARAMETER_PAGE_SIZE);
+ 
+   @Override
+   public String getNameForPageToken() {",Wouldn't we want `PARAMETER_MAX_RESULTS` in here as well? (I might be miunderstanding how this is used),Why do w
+4091,"@@ -21,4 +21,8 @@ RSpec.configure do |config|
+ 
+   Capybara.default_host = ""http://localhost:3000""
+   OmniAuth.config.test_mode = true
++
++  config.before(:suite) do
++    Role.ensure_system_roles_exist
++  end
+ end",We can re-use the config in our tests.,Layout/E
+4092,"@@ -308,7 +308,7 @@ AC_MSG_RESULT([$LIBS])
+ # Dependencies that themselves have a pkg-config file available.
+ #
+ PC_REQUIRES=""""
+-AS_IF([test ""$pmix_hwloc_support_will_build"" = ""yes""],
++AS_IF([test ""$pmix_hwloc_source"" != ""cobuild""],
+       [PC_REQUIRES=""$PC_REQUIRES hwloc""])
+ AS_IF([test $pmix_libevent_support -eq 1],
+       [PC_REQUIRES=""$PC_REQUIRES libevent""])","Wouldn't we have the same issue with the internal libevent? IIRC, the integration is pretty close to an exact duplicate. Or does the libevent m4 code already take that into account when setting this variable? PMIx _requires_ libevent, so it isn't like pmix_libevent_support can be anything other than 1. I'm okay with leaving this question for separate resolution - just wondering why we don't have the same issue here.","I think this should be `!= ""cobuild""`"
+4093,"@@ -51,6 +51,9 @@ func (h *tlsHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 		strings.Contains(ua, ""Trident"") {
+ 		checked = true
+ 		mitm = !info.looksLikeEdge()
++	} else if strings.Contains(ua, ""CRiOS"") {
++		checked = true
++		mitm = !info.looksLikeChromeOniOS()
+ 	} else if strings.Contains(ua, ""Chrome"") {
+ 		checked = true
+ 		mitm = !info.looksLikeChrome()","The actual User-Agent string uses ""CriOS"" not ""CRiOS""",I'm not sure if this is the right pla
+4094,"@@ -19,10 +19,8 @@ namespace Nethermind.Core
+ {
+     public interface IKeyValueStoreWithBatching : IKeyValueStore
+     {
+-        byte[]? this[byte[] key] { get; set; }
+-        
+         void StartBatch();
+-        
++
+         void CommitBatch();
+     }
+-}
++}","Unused code deletion. Is that a desired thing? No implementation of this actually used this indexer, so removing it seemed reasonable (and was suggested by the compiler). Maybe this had an indexer so plugins could use it? This change is definitely pushing the limits of what is appropriate in a ""cleanup"" as it is changing public API surface area.",Why did you remove this?
+4095,"@@ -489,6 +489,14 @@ module Beaker
+             end
+ 
+           rescue Exception => teardown_exception
++            begin
++              if !host.is_pe?
++                dump_puppet_log(host)
++              end
++            rescue Exception => dumping_exception
++              logger.error(""Raised during attempt to dump puppet logs: #{dumping_exception}"")
++            end
++
+             if original_exception
+               logger.error(""Raised during attempt to teardown with_puppet_running_on: #{teardown_exception}\n---\n"")
+               raise original_exception",We'd lose the data here from the original teardown_exception and only get the dump_exception - I fear that that could make the actual error difficult to track if it cascades.,Should this be `if original_exception
+4096,"@@ -266,6 +266,9 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 					dom.innerHTML = newHtml && newHtml.__html || '';
+ 				}
+ 			}
++			if (newVNode.props.multiple && newVNode.type==='select') {
++				dom.multiple = newVNode.props.multiple;
++			}
+ 			diffChildren(dom, newVNode, oldVNode, context, newVNode.type==='foreignObject' ? false : isSvg, excessDomChildren, mounts, ancestorComponent);
+ 			diffProps(dom, newVNode.props, oldProps, isSvg);
+ 		}",At this point in `diff()` we should know if we're dealing with a `component` or a native `html` element. We can reuse that information in this if-statement here :+1:,Why is this needed?
+4097,"@@ -215,7 +215,7 @@ func (p *Protocol) GrantEpochReward(
+ 	}
+ 
+ 	// Reward additional bootstrap bonus
+-	if epochNum <= a.foundationBonusLastEpoch {
++	if epochNum <= a.foundationBonusLastEpoch || (epochNum >= a.foundationBonusP2StartEpoch && epochNum <= a.foundationBonusP2EndEpoch) {
+ 		for i, count := 0, uint64(0); i < len(candidates) && count < a.numDelegatesForFoundationBonus; i++ {
+ 			if _, ok := exemptAddrs[candidates[i].Address]; ok {
+ 				continue","somewhere in reward protocol, we need to do if epoch is Fairbank { a.foundationBonusP2StartEpoch = genesis.xxx a.foundationBonusP2EndEpoch = genesis.yyy p.state(sm, adminKey, &a) } that is to write the 2 new values at Fairbank height then this logic can follow",Shouldn't this be `
+4098,"@@ -200,6 +200,10 @@ if __name__ == '__main__':
+     inventory_dao.initialize(SQL_ENGINE)
+     scanner_dao.initialize(SQL_ENGINE)
+ 
++    # Drop and recreate the CloudAssetInventory table
++    inventory_dao.CaiTemporaryStore.__table__.drop(SQL_ENGINE)
++    inventory_dao.CaiTemporaryStore.__table__.create(SQL_ENGINE)
++
+     # Find all the child classes inherited from declarative base class.
+     SCANNER_DAO_CLASSES = _find_subclasses(scanner_dao.BASE)
+ ","Dropping and recreating would delete all t he previous records, are they any important?",I'm not sure if thi
+4099,"@@ -50,6 +50,15 @@ func (m *mockCgroupManager) Destroy() error {
+ 	return nil
+ }
+ 
++func (m *mockCgroupManager) Exists() bool {
++	paths := m.GetPaths()
++	if paths != nil {
++		_, err := os.Lstat(paths[""devices""])
++		return err == nil
++	}
++	return false
++}
++
+ func (m *mockCgroupManager) GetPaths() map[string]string {
+ 	return m.paths
+ }","While it is technically OK to use `m.GetPaths()` here, and it's a mock code so it doesn't really matter, I'd still like to have `m.Path(""devices"")` used here, because since commit 714c91e9f73a1512808476eb532b4aa36bbb7530 we're not supposed to use GetPaths() for anything other than state save/restore.",I think this should
+4100,"@@ -481,6 +481,12 @@ func buildImage(mountPointMap, mountPointToFsTypeMap, mountPointToMountArgsMap m
+ 		setupChrootPackages = append(setupChrootPackages, toolingPackage.Name)
+ 	}
+ 
++	logger.Log.Infof(""HidepidDisabled is %v."", systemConfig.HidepidDisable)
++	hidepidEnable := true
++	if systemConfig.HidepidDisable {
++		hidepidEnable = false
++	}
++
+ 	if systemConfig.ReadOnlyVerityRoot.Enable {
+ 		// We will need the veritysetup package (and its dependencies) to manage the verity disk, add them to our
+ 		// image setup environment (setuproot chroot or live installer).","Let's be consistent everywhere: either ""Disable""/""Enable"" or ""Disabled""/""Enabled"". I'm voting for the latter.:)",I don't think we need this log line.
+4101,"@@ -2041,6 +2041,10 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       if (isPruningEnabled()) {
+         throw new ParameterException(commandLine, String.format(""%s %s"", ""Pruning"", errorSuffix));
+       }
++      if (isGoQuorumCompatibilityMode) {
++        throw new ParameterException(
++            commandLine, String.format(""%s %s"", ""GoQuorum mode"", errorSuffix));
++      }
+ 
+       if (isPrivacyMultiTenancyEnabled
+           && !jsonRpcConfiguration.isAuthenticationEnabled()",this works and is the smallest possible change but we could definitely fail earlier,I think it would be better to move t
+4102,"@@ -1,3 +1,4 @@
++//go:build !arm64
+ // +build !arm64
+ 
+ package nodeps","Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these",// +build !arm64
+4103,"@@ -25,6 +25,8 @@ class NotesScreenComponent extends BaseScreenComponent {
+ 	constructor() {
+ 		super();
+ 
++		this.prevFolderId_ = null;
++
+ 		this.onAppStateChange_ = async () => {
+ 			// Force an update to the notes list when app state changes
+ 			const newProps = Object.assign({}, this.props);",Could you explain the logic with prevFolderId?,Why do we need this?
+4104,"@@ -0,0 +1,13 @@
++package testutil
++
++import ""github.com/facebookgo/clock""
++
++// TimestampNow get now timestamp from new clock
++func TimestampNow() uint64 {
++	return TimestampNowFromClock(clock.New())
++}
++
++// TimestampNowFromClock get now timestamp from specific clock
++func TimestampNowFromClock(c clock.Clock) uint64 {
++	return uint64(c.Now().Unix())
++}",Please add license header,Why do we need this function?
+4105,"@@ -47,12 +47,13 @@
+ 
+ namespace lbann {
+ 
+-lbann_comm* initialize(int& argc, char**& argv, int seed) {
++lbann_comm_ptr initialize(int& argc, char**& argv, int seed) {
+   // Initialize Elemental.
+   El::Initialize(argc, argv);
+   // Create a new comm object.
+   // Initial creation with every process in one model.
+-  auto* comm = new lbann_comm(0);
++  auto comm = lbann_comm_ptr{new lbann_comm(0), &lbann::finalize };
++
+ #if defined(LBANN_TOPO_AWARE)
+   // Determine the number of NUMA nodes present.
+   hwloc_topology_t topo;","It bothers me that the user calls `initialize` without also calling `finalize`. It seems to me that we're essentially making `lbann_comm` a singleton object. Going further down this path, we would put `initialize` inside `lbann_comm`'s constructor and `finalize` in the destructor. This has it's own weirdness - the user must make sure it's lifespan matches the beginning and end of the program. We may also run into the case where someone might want multiple instances of `lbann_comm`, but this is not too important.",Why is this needed?
+4106,"@@ -353,6 +353,7 @@ void test4() {
+   smi = MolToSmiles(*m);
+   CHECK_INVARIANT(smi == ""c1cc[cH-]c1"", smi);
+   TEST_ASSERT(m->getConformer().is3D() == false);
++  delete m;
+ 
+   BOOST_LOG(rdInfoLog) << "" Finished <---------- "" << std::endl;
+ }",We should probably make a unique_ptr<ROMol> typedef in ROMol.h and start using that liberally.,Why is this needed?
+4107,"@@ -555,9 +555,13 @@ DefaultSettings.prototype = {
+    * ```
+    *
+    * @type {Boolean|String|Object}
+-   * @default true
++   * @default fillHandle: {
++       autoInsertRow: false,
++     }
+    */
+-  fillHandle: true,
++  fillHandle: {
++    autoInsertRow: false,
++  },
+ 
+   /**
+    * Allows to specify the number of fixed (or *frozen*) rows at the top of the table.",Can you add missing asterisk?,Why is this change needed?
+4108,"@@ -243,7 +243,15 @@ public class Name {
+   }
+ 
+   public String toUpperCamelAndDigits() {
+-    char[] upper = toUpperCamel().toCharArray();
++    return capitalizeDigitsAfterNumbers(toUpperCamel());
++  }
++
++  public String toLowerCamelAndDigits() {
++    return capitalizeDigitsAfterNumbers(toLowerCamel());
++  }
++
++  private String capitalizeDigitsAfterNumbers(String camelCaseIdentifier) {
++    char[] upper = camelCaseIdentifier.toCharArray();
+     boolean digit = false;
+     for (int i = 0; i < upper.length; i++) {
+       if (Character.isDigit(upper[i])) {","late to the party, but I bet it meant to be `capitalizeLettersAfterNumbers` :)",Why do we need this method?
+4109,"@@ -235,6 +235,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+     private RecipientPresenter recipientPresenter;
+     private MessageBuilder currentMessageBuilder;
+     private boolean mFinishAfterDraftSaved;
++    private boolean firstTimeEmptyObject = true;
+ 
+     @Override
+     public void onFocusChange(View v, boolean hasFocus) {","The Activity is recreated on configuration changes and the value of the field is lost. So, e.g. pressing 'send' once will display the error message. If you rotate the device and press 'send' again, the message will show another time. Use `onSaveInstanceState()` and `onRetainInstanceState()` to save and restore the value of the field.",private boolean firstTimeEm
+4110,"@@ -643,7 +643,7 @@ func (s *Server) reloadOptions(curOpts, newOpts *Options) error {
+ 	if err != nil {
+ 		return err
+ 	}
+-	// Create a context that is used to pass special info that we may need
++	// Create a ctx that is used to pass special info that we may need
+ 	// while applying the new options.
+ 	ctx := reloadContext{oldClusterPerms: curOpts.Cluster.Permissions}
+ 	s.setOpts(newOpts)","Looks like a ""find and replace"" unintended change here",I'm not sure if this is a t
+4111,"@@ -590,12 +590,13 @@ class SPRegion(PyRegion):
+     inputVector = numpy.array(rfInput[0]).astype('uint32')
+     outputVector = numpy.zeros(self._sfdr.getNumColumns()).astype('uint32')
+ 
+-    # Switch to using a random SP if learning mode is off and the SP hasn't
+-    # learned anything yet.
++    # Don't strip unlearned columns if learning is off and the SP hasn't
++    # learned anything yet. This acts as a random SP.
+     if (not self.learningMode) and (self._sfdr.getIterationLearnNum() == 0):
+-      self._sfdr.compute(inputVector, self.learningMode, outputVector, False)
++      self._sfdr.compute(inputVector, self.learningMode, outputVector)
+     else:
+       self._sfdr.compute(inputVector, self.learningMode, outputVector)
++      self._sfdr.stripUnlearnedColumns(outputVector)
+ 
+     self._spatialPoolerOutput[:] = outputVector[:]
+ ",haven't we got rid off `randomSP` recently? (I think `not learn` implied that),Why do we need to strip unl
+4112,"@@ -97,6 +97,7 @@ func (in *{{.Type}}) GetChaos() *ChaosInstance {
+ 		Kind:      Kind{{.Type}},
+ 		StartTime: in.CreationTimestamp.Time,
+ 		Action:    """",
++		Status:    string(in.GetStatus().Experiment.Phase),
+ 		UID:       string(in.UID),
+ 	}
+ ",Why we need use `in.GetStatus()` function here? Can we use `in.Status.xxxx` directly?,"Status:    string(in.GetStatus().Phase),"
+4113,"@@ -93,7 +93,10 @@ func RenewManagedCertificates(allowPrompts bool) (err error) {
+ 				continue
+ 			}
+ 
+-			// this works well because managed certs are only associated with one name per config
++			// This works well because managed certs are only associated with one name per config.
++			// Note, the renewal inside here may not actually occur and no error will be returned
++			// due to renewal lock (i.e. because a renewal is already happening). This lack of
++			// error is by intention to force cache invalidation as though it has renewed.
+ 			err := cert.Config.RenewCert(allowPrompts)
+ 
+ 			if err != nil {","@cretz Just a thought: what if another renewal process updates the certificate between the beginning of this for loop (above on line 67) and actually calling RenewCert? Even though we have a read lock on the certCache, something else could have renewed it by now, and finished, which would cause this certificate to be renewed twice. Could you double-check my thinking here and see if that's a plausible 'race' condition? I wonder if the lock needs to be put over this whole function. (It's still early here; I could be wrong...)",I don't think this is the right place to
+4114,"@@ -57,13 +57,13 @@ PDEBUG_SYSTEM_OBJECTS g_ExtSystem;
+ 
+ // Queries for all debugger interfaces.
+ #ifndef FEATURE_PAL    
+-extern ""C"" HRESULT
++HRESULT
+ ExtQuery(PDEBUG_CLIENT client)
+ {
+     HRESULT Status;
+     g_ExtClient = client;
+ #else
+-extern ""C"" HRESULT
++HRESULT
+ ExtQuery(ILLDBServices* services)
+ {
+     // Initialize the PAL and extension suppport in one place and only once.",We don't need this for the PInvoke?,Why did you change this?
+4115,"@@ -661,6 +661,10 @@ func (s *scheduler) getMentionedAccounts(ctx context.Context, event model.Notifi
+ 		return nil, err
+ 	}
+ 
++	if ds.GenericDeploymentConfig.DeploymentNotification == nil {
++		return nil, nil
++	}
++
+ 	for _, v := range ds.GenericDeploymentConfig.DeploymentNotification.Mentions {
+ 		if e := ""EVENT_"" + v.Event; e == event.String() {
+ 			return v.Slack, nil","nits, I think add a log (using s.logger) to show why does this return with no error is better.",I think we should return an error here.
+4116,"@@ -334,7 +334,10 @@ func (a *WebAPI) getPiped(ctx context.Context, pipedID string) (*model.Piped, er
+ // It gives back error unless the piped belongs to the project.
+ func (a *WebAPI) validatePipedBelongsToProject(ctx context.Context, pipedID, projectID string) error {
+ 	pid, err := a.pipedProjectCache.Get(pipedID)
+-	if err == nil && pid == projectID {
++	if err == nil {
++		if pid != projectID {
++			return status.Error(codes.PermissionDenied, ""Requested piped doesn't belong to the project you logged in"")
++		}
+ 		return nil
+ 	}
+ ","Btw, It would be nice if we have some tests for those validation functions.",I think this should be `if err != nil`
+4117,"@@ -23,6 +23,8 @@ public abstract class PathTemplateCheckView {
+ 
+   public abstract String paramName();
+ 
++  public abstract String methodName();
++
+   public static Builder newBuilder() {
+     return new AutoValue_PathTemplateCheckView.Builder();
+   }","Should this be called something that indicates its function, rather than its content? validationMessagePrefix, or similar?",Why is this needed?
+4118,"@@ -3,7 +3,8 @@
+ #A part of NonVisual Desktop Access (NVDA)
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+-#Copyright (C) 2010-2015 NV Access Limited, Mesar Hameed
++#Copyright (C) 2010-2019 NV Access Limited, Mesar Hameed, Takuya Nishimoto
++#Copyright (C) 2018-2019 Takuya Nishimoto
+ 
+ """"""Utilities related to NVDA Key Commands documents.
+ """"""",Please remove this line,This should be 2018-2019
+4119,"@@ -599,7 +599,7 @@ void CBOINCGUIApp::OnInitCmdLine(wxCmdLineParser &parser) {
+ #if (defined(__WXMAC__) && defined(_DEBUG))
+     parser.AddLongOption(""NSDocumentRevisionsDebugMode"", _(""Not used: workaround for bug in XCode 4.2""));
+ #endif
+-    parser.AddSwitch(""nd"", ""no-daemon"", _(""Not run the daemon""));
++    parser.AddSwitch(""nd"", ""no-daemon"", _(""Don't run the client""));
+ }
+ 
+ ",You could change the name of the command line switch too. Short options are typically one character after hyphen. wxWidgets' command line parser seems to handle `-nd` without confusing it with `-n` or `-d` but I'm not sure if that's by design or by accident. I'd remove the short option. `--no-daemon` is with hyphen but the rest of Manager and client uses underscore. Please change that.,I don't think this should be changed.
+4120,"@@ -69,8 +69,8 @@ func AddFlags(flagSet *pflag.FlagSet) {
+ 	flags.BoolVarP(flagSet, &fs.Config.IgnoreCaseSync, ""ignore-case-sync"", """", fs.Config.IgnoreCaseSync, ""Ignore case when synchronizing"")
+ 	flags.BoolVarP(flagSet, &fs.Config.NoTraverse, ""no-traverse"", """", fs.Config.NoTraverse, ""Don't traverse destination file system on copy."")
+ 	flags.BoolVarP(flagSet, &fs.Config.NoUpdateModTime, ""no-update-modtime"", """", fs.Config.NoUpdateModTime, ""Don't update destination mod-time if files identical."")
+-	flags.StringVarP(flagSet, &fs.Config.CompareDest, ""compare-dest"", """", fs.Config.CompareDest, ""use DIR to server side copy flies from."")
+-	flags.StringVarP(flagSet, &fs.Config.CopyDest, ""copy-dest"", """", fs.Config.CopyDest, ""Compare dest to DIR also."")
++    flags.StringVarP(flagSet, &fs.Config.CompareDest, ""compare-dest"", """", fs.Config.CompareDest, ""Include additional server-side path during comparison."")
++    flags.StringVarP(flagSet, &fs.Config.CopyDest, ""copy-dest"", """", fs.Config.CopyDest, ""Implies --compare-dest but also copies files from path into destination."")
+ 	flags.StringVarP(flagSet, &fs.Config.BackupDir, ""backup-dir"", """", fs.Config.BackupDir, ""Make backups into hierarchy based in DIR."")
+ 	flags.StringVarP(flagSet, &fs.Config.Suffix, ""suffix"", """", fs.Config.Suffix, ""Suffix to add to changed files."")
+ 	flags.BoolVarP(flagSet, &fs.Config.SuffixKeepExtension, ""suffix-keep-extension"", """", fs.Config.SuffixKeepExtension, ""Preserve the extension when using --suffix."")",File is not `goimports`-ed (from `goimports`),I don't think this is a good idea. It makes it harder to understand what is going on.
+4121,"@@ -439,7 +439,7 @@ func (r *RpmRepoCloner) clonePackage(baseArgs []string, enabledRepoOrder ...stri
+ 		logger.Log.Debugf(""stderr: %s"", stderr)
+ 
+ 		if err != nil {
+-			logger.Log.Errorf(""tdnf error (will continue if the only errors are toybox conflicts):\n '%s'"", stderr)
++			logger.Log.Debugf(""tdnf error (will continue if the only errors are toybox conflicts):\n '%s'"", stderr)
+ 		}
+ 
+ 		// ============== TDNF SPECIFIC IMPLEMENTATION ==============","Why are we mentioning toybox in this message? AND it still says ""tdnf error"". What's the actual error? Should it be resolved instead of flagged?",Why is this change needed?
+4122,"@@ -473,6 +473,7 @@ describe('GridFS Stream', function () {
+                     // Fail if user tries to abort an aborted stream
+                     uploadStream.abort().then(null, function (error) {
+                       expect(error.toString()).to.equal(
++                        // TODO(NODE-3405): Replace with MongoStreamClosedError
+                         'MongoDriverError: Cannot call abort() on a stream twice'
+                       );
+                       client.close(done);",You can remove these if they've been resolved in NODE-3405 and this isn't depending on it,Is this TODO still relevant?
+4123,"@@ -1,7 +1,7 @@
+ <%# locals: { phase } %>
+ <div class=""row"" id=""<%= dom_id(phase) %>"">
+   <div class=""col-xs-12"">
+-    <h4>
++    <h4 class=''>
+       <%= _('Instructions') %>
+       <a href=""<%= edit_plan_path(plan_id, phase_id: phase.id) %>"" class=""btn btn-default pull-right""><%= _('Write plan') %></a>
+     </h4>",don't need the class here if its empty,Why is this needed?
+4124,"@@ -4,11 +4,15 @@ import Ember from 'ember';
+ import moment from 'moment';
+ import { translationMacro as t } from 'ember-i18n';
+ 
++const { computed } = Ember;
++
+ export default AppointmentIndexRoute.extend(DateFormat, {
+   editReturn: 'appointments.search',
+   filterParams: ['appointmentType', 'provider', 'status'],
+   modelName: 'appointment',
+-  pageTitle: t('appointments.searchTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('appointments.searchTitle');
++  }),
+ 
+   queryParams: {
+     appointmentType: { refreshModel: true },",This should be computed('i18n.locale'....,Why do we need this computed?
+4125,"@@ -348,8 +348,8 @@ class BigQueryClient:
+             status = self.client.jobs().get(projectId=project_id, jobId=job_id).execute(num_retries=10)
+             if status['status']['state'] == 'DONE':
+                 if status['status'].get('errorResult'):
+-                    raise Exception('BigQuery job failed: {}'.format(status['status']['errorResult']))
+-                return
++                    raise BigQueryExecutionError(job_id, status['status']['errorResult'])
++                return job_id
+ 
+             logger.info('Waiting for job %s:%s to complete...', project_id, job_id)
+             time.sleep(5)",Please add return and return type description to docstring of this method.,I think this should be `raise
+4126,"@@ -51,8 +51,10 @@ class ContributionsController < ApplicationController
+   private
+ 
+   def set_contributor
+-    @contributor = ContributorFact.where(names: { id: params[:id] }).where(analysis_id: @project.best_analysis_id)
+-                   .eager_load(:name).first
++    id = params[:id].to_i
++    @contributor = Contribution.find(id).name_fact if id > (1 << 32)
++    @contributor ||= ContributorFact.where(names: { id: id }).where(analysis_id: @project.best_analysis_id)
++                     .eager_load(:name).first
+     fail ParamRecordNotFound unless @contributor
+   end
+ ",What does 1 << 32 do? In irb typing this yields 4294967296. I didn't find the append operator in Numeric or Integer.,Line is too long. [81/80]
+4127,"@@ -79,6 +79,16 @@ module RSpec
+         RSpec.configuration.format_docstrings_block.call(description)
+       end
+ 
++      # @attr_accessor
++      #
++      # Holds the completion status of the example (nil if not completed)
++      attr_accessor :succeeded
++
++      # Convenience method for getting success status of example
++      def succeeded?
++        @succeeded
++      end
++
+       # @attr_reader
+       #
+       # Returns the first exception raised in the context of running this","We generally use metadata for this sort of thing, indeed there is a `metadata[:execution_result]`.",I don't think this is needed.
+4128,"@@ -483,6 +483,8 @@ class SpreadPlot(ElementPlot):
+     style_opts = line_properties + fill_properties
+     _plot_methods = dict(single='patch')
+ 
++    _stream_data = False # Plot does not support streaming data
++
+     def get_data(self, element, ranges, style):
+          mapping = dict(x='x', y='y')
+          xvals = element.dimension_values(0)",This was very confusing until I realized this might refer to the *bokeh* use of the word 'streaming'.,I don't think this is needed.
+4129,"@@ -47,6 +47,10 @@ type TaskHandler struct {
+ 	tasksToEvents map[string]*eventList
+ 	// tasksToEventsLock for locking the map
+ 	tasksToEventsLock sync.RWMutex
++	// batchMap is used to collect container events
++	// between task transitions
++	batchMap     map[string][]api.ContainerStateChange
++	batchMapLock sync.RWMutex
+ }
+ 
+ // NewTaskHandler returns a pointer to TaskHandler","Can you rename this as `tasksToContainerStates` ? If you do that, you can rename the lock as well",Why do we need a lock here?
+4130,"@@ -177,7 +177,7 @@ public class UserAccountManager {
+ 	 */
+ 	public Account getCurrentAccount() {
+         final Account[] accounts = accountManager.getAccountsByType(accountType);
+-        if (accounts == null || accounts.length == 0) {
++        if (accounts.length == 0) {
+         	return null;
+         }
+ ",Fixing `lint` warnings that have existed for a while.,`accounts` can be `null`.
+4131,"@@ -452,6 +452,18 @@ public interface Iterator<T> extends java.util.Iterator<T>, Traversable<T> {
+         return io.vavr.collection.Collections.fill(n, s);
+     }
+ 
++    /**
++     * Returns a Iterator containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Iterator
++     * @param n       The number of elements
++     * @param element The element
++     * @return An iterator of {@code n} sequence elements, where each element is the given {@code element}.
++     */
++    static <T> Iterator<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element);
++    }
++
+     /**
+      * Creates an Iterator of characters starting from {@code from}, extending to {@code toExclusive - 1}.
+      * <p>","An iterator **of {\@code n} sequential elements,** where each element ~are~ **is the** given {\@code element}.",I'm not sure if this is the b
+4132,"@@ -3,11 +3,13 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+ 
++using Datadog.Trace.Configuration;
++
+ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AdoNet.MySql
+ {
+     internal static class MySqlConstants
+     {
+-        public const string SqlCommandIntegrationName = ""MySqlCommand"";
++        public const string SqlCommandIntegrationName = nameof(IntegrationIds.AdoNet);
+ 
+         internal struct MySqlDataClientData : IAdoNetClientData
+         {","If all of the `SqlCommandIntegrationName` values are the same, can we just remove it from `IAdoNetClientData` entirely and put the constant there?",I think this should be `nameof(SqlCommand)`
+4133,"@@ -17,6 +17,8 @@ limitations under the License.
+ package venafi
+ 
+ import (
++	""github.com/go-logr/logr""
++	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ 	corelisters ""k8s.io/client-go/listers/core/v1""
+ 
+ 	apiutil ""github.com/jetstack/cert-manager/pkg/api/util""",Maybe regroup this import with the other cert-manager packages.,nit: this import should be grouped with oth
+4134,"@@ -167,6 +167,8 @@ public class UserPreferences {
+         int theme = getTheme();
+         if (theme == R.style.Theme_AntennaPod_Dark) {
+             return R.style.Theme_AntennaPod_Dark_NoTitle;
++        }else if (theme == R.style.Theme_AntennaPod_TrueBlack){
++            return R.style.Theme_AntennaPod_TrueBlack_NoTitle;
+         } else {
+             return R.style.Theme_AntennaPod_Light_NoTitle;
+         }",There are spaces missing ;) Just have a look at the code style of the `if` statement above,This should be `Theme_TrueBlack_NoTitle`
+4135,"@@ -55,6 +55,9 @@ func (w *DefaultWorker) Generate(
+ 	mq := NewMessageQueue(pending)
+ 	candidateMsgs := orderMessageCandidates(mq.Drain())
+ 	candidateMsgs = w.filterPenalizableMessages(ctx, candidateMsgs)
++	if len(candidateMsgs) > block.BlockMessageLimit {
++		candidateMsgs = candidateMsgs[:block.BlockMessageLimit]
++	}
+ 
+ 	var blsAccepted []*types.SignedMessage
+ 	var secpAccepted []*types.SignedMessage","We should pass the size limit as a parameter to Drain so that we don't take messages out of the pool and then drop them. It's ok to merge as is, I will file an issue.",Why do we need this?
+4136,"@@ -1059,7 +1059,16 @@ encode_with_patch_list(dcontext_t *dcontext, patch_list_t *patch, instrlist_t *i
+             instr_encode_to_copy(dcontext, inst, vmcode_get_writable_addr(pc), pc);
+         byte *nxt_pc = vmcode_get_executable_addr(nxt_writable_pc);
+         ASSERT(nxt_pc != NULL);
++#ifdef AARCH64
++        /* Unlike X86 and ARM/AArch32 which use 1 instruction for an indirect jump,
++         * AArch64 requires 2 instructions: LDR+BR, see INSTR_CREATE_ldr()
++         * followed by XINST_CREATE_jump_reg() calls in
++         * emit_special_ibl_xfer().
++         */
++        len = (int)(nxt_pc - pc) + AARCH64_INSTR_SIZE;
++#else
+         len = (int)(nxt_pc - pc);
++#endif
+         pc = nxt_pc;
+ 
+         if (cur < patch->num_relocations && inst == patch->entry[cur].where.instr) {",Patch lists are used in many places so this is going to break other updates. This should just be a local change in emit_special_ibl_xfer() to pass the second-to-last instruction instead of the last instruction.,I'm not sure if this is the right place to put this code. I think it would be better to put this code in a separate function.
+4137,"@@ -38,7 +38,7 @@ char const * test_genesis_data = R""%%%({
+ 	""source"": ""B0311EA55708D6A53C75CDBF88300259C6D018522FE3D4D0A242E431F9E8B6D0"",
+ 	""representative"": ""xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo"",
+ 	""account"": ""xrb_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo"",
+-	""work"": ""9680625b39d3363d"",
++	""work"": ""7b42a00ee91d5810"",
+ 	""signature"": ""ECDA914373A2F0CA1296475BAEE40500A7F0A7AD72A5A80C81D7FAB7F6C802B2CC7DB50F5DD0FB25B2EF11761FA7344A158DD5A700B21BD47DE5BD0F63153A02""
+ 	})%%%"";
+ ","@argakiig previous work was above live threshold, causing the high difficulty to bleed into other blocks when genesis open was processed in tests.",Why did you change this?
+4138,"@@ -1,4 +1,4 @@
+-class RemoveDiscountPercentageAndDiscountTitleFromProducts < ActiveRecord::Migration
++class RemoveDiscountPercentageAndDiscountTitleFromProducts < ActiveRecord::Migration[4.2]
+   def change
+     remove_column :products, :discount_percentage, :integer
+     remove_column :products, :discount_title, :string",Metrics/LineLength: Line is too long. [89/80],Line is too long. [81/80]
+4139,"@@ -30,6 +30,7 @@ type SystemConfig struct {
+ 	Encryption         RootEncryption      `json:""Encryption""`
+ 	RemoveRpmDb        bool                `json:""RemoveRpmDb""`
+ 	ReadOnlyVerityRoot ReadOnlyVerityRoot  `json:""ReadOnlyVerityRoot""`
++	HidepidDisable     bool                `json:""HidepidDisable""`
+ }
+ 
+ // GetRootPartitionSetting returns a pointer to the partition setting describing the disk which",Please also extend the config tests now to include the new field.,nit: `HidePidDisable` -> `HidePIDDisable`
+4140,"@@ -53,6 +53,7 @@ namespace NLog.Layouts
+         public JsonLayout()
+         {
+             this.Attributes = new List<JsonAttribute>();
++            this.RenderEmptyLiteral = true;
+         }
+ 
+         /// <summary>",I think it's wise to keep the behavior backwards-compatible (so `false` as default),Why is this needed?
+4141,"@@ -47,7 +47,7 @@ module Selenium
+ 
+         opts[:path] ||= '/'
+         opts[:secure] ||= false
+-
++        opts[:sameSite]
+         obj = opts.delete(:expires)
+         opts[:expiry] = seconds_from(obj).to_i if obj
+ ","We don't need this line, do we?",I think this should
+4142,"@@ -0,0 +1,4 @@
++# Proprietary German backlinks service.
++# They keep requesting invalid formats.
++User-agent: SEOkicks-Robot
++Disallow: /",I don't know if we've actually had this problem on Upcase. I'd lean towards having a blank file unless (like on robots) we see multiple errors per week from this crawler.,I don't think we ne
+4143,"@@ -179,7 +179,13 @@ static void render_decorations(struct roots_view *view,
+ 	float matrix[16];
+ 	wlr_matrix_project_box(&matrix, &project_box, WL_OUTPUT_TRANSFORM_NORMAL,
+ 		view->rotation, &output->transform_matrix);
+-	float color[4] = { 0.2, 0.2, 0.2, 1 };
++	float color[4]	= { 0.2, 0.2, 0.2, 1 };
++	if (view_get_activated(view)) {
++		color[0] = 0.09804;
++		color[1] = 0.09804;
++		color[2] = 0.43921;
++	}
++
+ 	wlr_render_colored_quad(desktop->server->renderer, &color, &matrix);
+ }
+ ","I'm not good at picking colors, if anyone else has a preference.",This should be `wlr
+4144,"@@ -50,6 +50,10 @@ class FoldersScreenUtils {
+ 			this.refreshFolders();
+ 		}, 1000);
+ 	}
++
++	static cancelTimers() {
++		if (this.scheduleRefreshFoldersIID_) clearTimeout(this.scheduleRefreshFoldersIID_);
++	}
+ }
+ 
+ module.exports = { FoldersScreenUtils };","Note that even if you cancel the timer, the refreshFolders function might still be running since it's async. Could that be a problem for the test units? One big issue I had with tests is they sometimes would work and sometimes fail randomly, and that's because there are still code running in the background. One example was the ItemChange class, which saves data asynchronously. So I've implemented a waitForAllSaved(), which can be used for test units, to make sure nothing is running once the test ends. So just wondering if we might end up with this issue here.","nit: `clearTimeout(this.scheduleRefreshFoldersIID_, 1000);`"
+4145,"@@ -0,0 +1,16 @@
++'use strict';
++
++const tsd = require('tsd').default;
++const { expect } = require('chai');
++
++describe('Exported Types', () => {
++  it('should be as expected', async () => {
++    const diagnostics = await tsd();
++    if (diagnostics.length !== 0) {
++      const messages = diagnostics
++        .map(d => `${d.fileName}:${d.line}:${d.column} - [${d.severity}]: ${d.message}`)
++        .join('\n');
++      expect.fail('\n' + messages);
++    }
++  });
++});","can we make this something more descriptive? like... types should compile? I'm still not sure exactly what this is testing... this says ""Exported types"" - but what does tsd actually look at?",I think you can use `expect.strictEqual` here.
+4146,"@@ -48,17 +48,12 @@ public class BridgeWebChromeClient extends WebChromeClient {
+     callback.onCustomViewHidden();
+     super.onShowCustomView(view, callback);
+   }
+-  
+-  @Override
+-  public void onHideCustomView() {
+-    super.onHideCustomView();
+-  }
+ 
+   @Override
+   public void onPermissionRequest(final PermissionRequest request) {
+     boolean isRequestPermissionRequired = android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.M;
+ 
+-    List<String> permissionList = new ArrayList<String>();
++    List<String> permissionList = new ArrayList<>();
+     if (Arrays.asList(request.getResources()).contains(""android.webkit.resource.VIDEO_CAPTURE"")) {
+       permissionList.add(Manifest.permission.CAMERA);
+     }",this method is need for full screen video button to appear in players,Why did you remove this?
+4147,"@@ -26,6 +26,7 @@ type HeadersCfg struct {
+ 	penalize          func(context.Context, []headerdownload.PenaltyItem)
+ 	wakeUpChan        chan struct{}
+ 	batchSize         datasize.ByteSize
++	increment         *uint64
+ }
+ 
+ func StageHeadersCfg(",Why is this a pointer?,Why is this a pointer?
+4148,"@@ -30,12 +30,16 @@ import org.apache.iceberg.expressions.Expression;
+ import org.apache.iceberg.expressions.Expressions;
+ import org.apache.iceberg.expressions.UnboundPredicate;
+ import org.apache.iceberg.relocated.com.google.common.base.Objects;
++import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.types.Type;
+ import org.apache.iceberg.util.UnicodeUtil;
+ 
+ abstract class Truncate<T> implements Transform<T, T> {
+   @SuppressWarnings(""unchecked"")
+   static <T> Truncate<T> get(Type type, int width) {
++    Preconditions.checkArgument(width > 0,
++        ""The width of truncate must larger than zero,but is %s"", width);
++
+     switch (type.typeId()) {
+       case INTEGER:
+         return (Truncate<T>) new TruncateInteger(width);",nit: Space after comma,Shouldn't this be `> 0`?
+4149,"@@ -853,6 +853,11 @@ class XLongField(LongField):
+         return lhex(self.i2h(pkt, x))
+ 
+ 
++class XLELongField(LELongField, XLongField):
++    def i2repr(self, pkt, x):
++        return XLongField.i2repr(self, pkt, x)
++
++
+ class IEEEFloatField(Field):
+     def __init__(self, name, default):
+         Field.__init__(self, name, default, ""f"")",A similar field is already define in `scapy/layers/bluetooth.py`. Can you merge both definitions ?,Why is this needed?
+4150,"@@ -204,6 +204,19 @@ class CppGenerator : public BaseGenerator {
+     if (num_includes) code_ += """";
+   }
+ 
++  void GenExtraIncludes() {
++    if(parser_.opts.cpp_includes.empty()) {
++      return;
++    }
++    // non-const copy needed for std::strtok
++    std::string data = parser_.opts.cpp_includes;
++    for(char* pch = std::strtok(&data[0], "","");
++        pch != nullptr; pch = std::strtok(nullptr, "","")) {
++      code_ += ""#include <"" + std::string(pch) + "">"";
++    }
++    code_ += """";
++  }
++
+   std::string EscapeKeyword(const std::string &name) const {
+     return keywords_.find(name) == keywords_.end() ? name : name + ""_"";
+   }","`std::strtok` isn't necessary. The `std::string::find_first_of` is better C++ alternative to `std::strtok`. For example, see `CheckedError Parser::ParseEnumFromString` method.",nit: space after `for`
+4151,"@@ -3,9 +3,6 @@ namespace Psalm\CodeLocation;
+ 
+ class DocblockTypeLocation extends \Psalm\CodeLocation
+ {
+-    /** @var int */
+-    public $raw_line_number;
+-
+     public function __construct(
+         \Psalm\FileSource $file_source,
+         int $file_start,",This property is already declared in a parent with the same visibility/type/value. This one is redundant.,Why did you remove this?
+4152,"@@ -78,6 +78,8 @@ def autorun_get_interactive_session(cmds, **kargs):
+             self.s = """"
+         def write(self, x):
+             self.s += x
++        def flush(self):
++            pass
+             
+     sw = StringWriter()
+     sstdout,sstderr = sys.stdout,sys.stderr","This is required, otherwise multiprocessing will (for some reason) crash",Why is this needed?
+4153,"@@ -19,6 +19,7 @@ package main
+ import (
+ 	""encoding/base64""
+ 	""fmt""
++	""github.com/algorand/go-algorand/data/basics""
+ 	""io""
+ 	""io/ioutil""
+ 	""os""",Please put in a separate line-separated block,I think this should
+4154,"@@ -100,7 +100,7 @@ func (cmd *Command) Wait() error {
+ func (cmd *Command) Kill() error {
+ 	err := cmd.connectionManager.Disconnect()
+ 	if err != nil {
+-		return err
++		fmt.Printf(""Disconnect error: %s\n"", err)
+ 	}
+ 
+ 	cmd.httpApiServer.Stop()","Should error be eaten? If so, not clear why",Shouldn't this be `
+4155,"@@ -145,4 +145,7 @@ class AuthorizationPolicy(core_authorization.AuthorizationPolicy):
+ 
+ 
+ class RouteFactory(core_authorization.RouteFactory):
+-    pass
++    def __init__(self, request):
++        super(RouteFactory, self).__init__(request)
++        if self.on_collection and self.resource_name == 'bucket':
++            self.force_empty_list = True","This attribute is not defined if the condition is not met. Instead, you could define another RouteFactory (e.g. `BucketRouteFactory` with a class attribute like `allow_empty_list`)",Why do we need this
+4156,"@@ -103,6 +103,13 @@ func WithCondition(cond hivev1.ClusterDeploymentCondition) Option {
+ 	}
+ }
+ 
++// WithInstalledTimestamp adds the specified InstalledTimestamp to ClusterDeployment.Status
++func WithInstalledTimestamp(timestamp metav1.Time) Option {
++	return func(clusterDeployment *hivev1.ClusterDeployment) {
++		clusterDeployment.Status.InstalledTimestamp = &timestamp
++	}
++}
++
+ func WithUnclaimedClusterPoolReference(namespace, poolName string) Option {
+ 	return WithClusterPoolReference(namespace, poolName, """")
+ }",Can we use the existing `InstalledTimestamp` function?,I don't think we need this function.
+4157,"@@ -975,14 +975,15 @@ public class AddProductActivity extends AppCompatActivity {
+         if (!editionMode) {
+             if (addProductOverviewFragment.areRequiredFieldsEmpty()) {
+                 viewPager.setCurrentItem(0, true);
+-            } else if (isNutritionDataAvailable() && addProductNutritionFactsFragment.containsInvalidValue()) {
++            } else if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) {
+                 viewPager.setCurrentItem(2, true);
+             } else {
+                 saveProduct();
+             }
+         } else {
+             // edit mode, therefore do not check whether front image is empty or not however do check the nutrition facts values.
+-            if ((isNutritionDataAvailable()) && addProductNutritionFactsFragment.containsInvalidValue()) {
++            if (isNutritionDataAvailable() && addProductNutritionFactsFragment.isFieldsInvalid()) {
++                // If there are any invalid field and there is nutrition data, scroll to the nutrition fragmento
+                 viewPager.setCurrentItem(2, true);
+             } else {
+                 saveEditedProduct();","weird naming: `is` but `fields` (plural or singular ?) . If the method checks if the fragment has an invalid value, then ""hasInvalidValue"" or ""containsInvalidValue"" is fine no ?","If there are any invalid fields, scr"
+4158,"@@ -28,7 +28,7 @@ LISTENS_PER_PAGE = 25
+ user_bp = Blueprint(""user"", __name__)
+ 
+ 
+-@user_bp.route(""/<user_name>"")
++@user_bp.route(""/<user_name>/"")
+ def profile(user_name):
+     # Which database to use to showing user listens.
+     db_conn = webserver.timescale_connection._ts",Does this mean that `listenbrainz.org/user/iliekcomputers` will start getting 404s?,I think this should be `/<user_name>
+4159,"@@ -23,7 +23,11 @@ module Blacklight
+       # CatalogController.include ModuleDefiningNewMethod
+       # CatalogController.search_params_logic += [:new_method]
+       # CatalogController.search_params_logic.delete(:we_dont_want)
+-      self.search_params_logic = [:default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr, :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr, :add_sorting_to_solr, :add_group_config_to_solr ]
++      self.search_params_logic = [
++        :default_solr_parameters, :add_query_to_solr, :add_facet_fq_to_solr,
++        :add_facetting_to_solr, :add_solr_fields_to_query, :add_paging_to_solr,
++        :add_sorting_to_solr, :add_group_config_to_solr, :add_facet_paging_to_solr
++      ]
+ 
+       if self.respond_to?(:helper_method)
+         helper_method(:facet_limit_for)",Line is too long. [82/80],Layout/SpaceInsideArrayLiteralBracke
+4160,"@@ -28,6 +28,7 @@ CAN_INV_FILTER = 0x20000000
+ 
+ class CANSocket(SuperSocket):
+     desc = ""read/write packets at a given CAN interface using PF_CAN sockets""
++    async_select_unrequired = True
+ 
+     def __init__(self, iface=None, receive_own_messages=False,
+                  can_filters=None, remove_padding=True, basecls=CAN):",That's a strange name =),Why is this needed?
+4161,"@@ -48,6 +48,17 @@ describe CommunicartMailer do
+       end
+     end
+ 
++    context 'custom templates' do
++      it 'renders a default template when an origin is not indicated' do
++        expect(mail.body.encoded).to include('Purchase Request')
++      end
++
++      it 'renders a custom template when origin is indicated' do
++        approval.cart.properties << Property.create!(property: 'origin', value:'whsc')
++        expect(mail.body.encoded).to include('White House Service Center: Purchase Request')
++      end
++    end
++
+   end
+ 
+   describe 'approval reply received email' do",Thoughts on this? I'm not crazy about the brittleness of this but haven't found a good way to test more generically that a specific (custom) template has been rendered.,Prefer double-quote
+4162,"@@ -30,6 +30,7 @@ createMethods(Results.prototype, objectTypes.RESULTS, [
+     'filtered',
+     'sorted',
+     'snapshot',
++    'subscribe',
+     'isValid',
+     'indexOf',
+     'min',",Have we reached binding-level agreement on the `subscribe` terminology? My only concern is that it doesn't seem descriptive enough and may be confused with subscribing for notifications.,
+4163,"@@ -138,7 +138,9 @@ func (tr *tracer) newRecordingSpan(psc, sc trace.SpanContext, name string, sr Sa
+ 	}
+ 
+ 	for _, l := range config.Links() {
+-		s.addLink(l)
++		if l.SpanContext.IsValid() {
++			s.addLink(l)
++		}
+ 	}
+ 
+ 	s.SetAttributes(sr.Attributes...)",would it not be safer to move this condition to the `addLink` method?,Why is this needed?
+4164,"@@ -611,6 +611,13 @@ func (h *Handler) reverseProxy(rw http.ResponseWriter, req *http.Request, di Dia
+ 
+ 	rw.WriteHeader(res.StatusCode)
+ 
++	// for some apps which need a correct response header to start http2 streaming,
++	// it's important to explicit flush headers to the client before copy streaming data.
++	if req.ProtoMajor == 2 && res.ContentLength == -1 {
++		if wf, ok := rw.(http.Flusher); ok {
++			wf.Flush()
++		}
++	}
+ 	err = h.copyResponse(rw, res.Body, h.flushInterval(req, res))
+ 	res.Body.Close() // close now, instead of defer, to populate res.Trailer
+ 	if err != nil {","I think this might read better: > some apps need the response headers before starting to stream content with http2, so it's important to explicitly flush the headers to the client before streaming the data.","I don't think this is the right place to do this. If we are going to do this, we need to make sure that we flush the headers before we copy the response."
+4165,"@@ -47,6 +47,13 @@ public interface FileScanTask extends ScanTask {
+    */
+   PartitionSpec spec();
+ 
++  /**
++   * The partition data for the file of this task.
++   *
++   * @return the partition data for the file of this task
++   */
++  StructLike partition();
++
+   /**
+    * The starting position of this scan range in the file.
+    *","What does this return if there is no partition? I think that we should consider adding a struct type that describes this tuple. That way, we can use an empty struct for unpartitioned and a non-empty struct for tasks that are combined by partition. We could also support more combinations, like combining across day partitions by not across bucket partitions or similar.",Why do we need this method?
+4166,"@@ -493,7 +493,16 @@ func DeleteRepo(
+ 
+ 	_, _, err = kbfsOps.Lookup(ctx, repoNode, normalizedRepoName)
+ 	if err != nil {
+-		return err
++		// For the common ""repo doesn't exist"" case, use an error type that the
++		// client can recognize.
++		switch errors.Cause(err).(type) {
++		case libkbfs.NoSuchNameError:
++			return libkb.RepoDoesntExistError{
++				Name: repoName,
++			}
++		default:
++			return err
++		}
+ 	}
+ 
+ 	deletedReposNode, err := lookupOrCreateDir(","Also, it might be worth returning this for the above lookup on `kbfsRepoDir` as well, which could happen if someone tries to delete a repo in a TLF that has never had any repos at all.",I don't think this is the right error type to return here. It should be `libkbfs.RepoExistsError`.
+4167,"@@ -171,6 +171,12 @@ var (
+ 		Usage: ""IP address to bind API to"",
+ 		Value: ""127.0.0.1"",
+ 	}
++	// FlagTequilapiAllowedHostnames Restrict hostnames in requests' Host header to following domains.
++	FlagTequilapiAllowedHostnames = cli.StringFlag{
++		Name:  ""tequilapi.allowed-hostnames"",
++		Usage: ""Comma separated list of allowed domains. Prepend value with dot for wildcard mask"",
++		Value: "".localhost, localhost, .localdomain"",
++	}
+ 	// FlagTequilapiPort port for listening for incoming API requests.
+ 	FlagTequilapiPort = cli.IntFlag{
+ 		Name:  ""tequilapi.port"",",Can this be `Hidden: true` as we already have a bunch of flags that are printed on `--help` and this seems like an average person should not care about it.,I'm not sure if this is the right place to put this flag. I think it would be better to put it in the `tequilapi` package.
+4168,"@@ -488,11 +488,13 @@ class Controller
+ 
+         $useCache = !Config::get('cms.twigNoCache');
+         $isDebugMode = Config::get('app.debug', false);
++        $strictVariables = (Config::get('cms.enableTwigStrictVariables', null) !== null) ?: $isDebugMode;
+         $forceBytecode = Config::get('cms.forceBytecodeInvalidation', false);
+ 
+         $options = [
+             'auto_reload' => true,
+             'debug' => $isDebugMode,
++            'strict_variables' => $strictVariables,
+         ];
+ 
+         if ($useCache) {",Wouldn't this set $strictVariables = true when Config::get returns false?,"`$strictVariables = Config::get('cms.enableTwigStrictVariables', null);`"
+4169,"@@ -16,6 +16,7 @@ import javax.json.JsonReader;
+ import javax.xml.parsers.DocumentBuilder;
+ import javax.xml.parsers.DocumentBuilderFactory;
+ import static junit.framework.Assert.assertEquals;
++import org.junit.Ignore;
+ import org.junit.Test;
+ import org.xml.sax.ErrorHandler;
+ import org.xml.sax.InputSource;",was this meant to be checked in?,Why is this ignored?
+4170,"@@ -156,4 +156,8 @@ const (
+ 	// attempt to reconnect a route, gateway or leaf node connection.
+ 	// The default is to report every attempt.
+ 	DEFAULT_RECONNECT_ERROR_REPORTS = 1
++
++	// DEFAULT_RTT_MEASUREMENT_INTERVAL	is how often we want to measure RTT from
++	// this server to clients, routes, gateways or leafnode connections.
++	DEFAULT_RTT_MEASUREMENT_INTERVAL = time.Hour
+ )",check spaces after const name...,I don't think we need this anymore.
+4171,"@@ -67,7 +67,10 @@ func (agent *ecsAgent) appendVolumeDriverCapabilities(capabilities []*ecs.Attrib
+ 
+ func (agent *ecsAgent) appendNvidiaDriverVersionAttribute(capabilities []*ecs.Attribute) []*ecs.Attribute {
+ 	if agent.resourceFields != nil && agent.resourceFields.NvidiaGPUManager != nil {
+-		capabilities = appendNameOnlyAttribute(capabilities, attributePrefix+capabilityNvidiaDriverVersionInfix+agent.resourceFields.NvidiaGPUManager.GetDriverVersion())
++		driverVersion := agent.resourceFields.NvidiaGPUManager.GetDriverVersion()
++		if driverVersion != """" {
++			capabilities = appendNameOnlyAttribute(capabilities, attributePrefix+capabilityNvidiaDriverVersionInfix+driverVersion)
++		}
+ 	}
+ 	return capabilities
+ }","If the GPU setting is enabled, resourceFields.NvidiaGPUManager will be nil, right?","I think this should be `if driverVersion != """" {`"
+4172,"@@ -363,7 +363,11 @@ HELP
+             when 'command'
+               executor.run_command(nodes, options[:object])
+             when 'script'
+-              executor.run_script(nodes, options[:object], options[:leftovers])
++              script = options[:object]
++              unless file_exist?(script)
++                raise Bolt::CLIError, ""The script '#{script}' does not exist""
++              end
++              executor.run_script(nodes, script, options[:leftovers])
+             when 'task'
+               task_name = options[:object]
+ ",We should probably verify that it's readable too,I think this should be `unless file_exist?(script)`
+4173,"@@ -355,7 +355,7 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+                                     throw new InvalidDataException(""Expected key value before dictionary data."");
+                                 }
+ 
+-                                string value = xmlReader.ReadElementContentAsString();
++                                xmlReader.ReadElementContentAsString();
+                                 readerMoved = true;
+                                 keyName = string.Empty;
+                                 break;","See, here's an example where you removed the variable but kept the call, which makes sense.",Why did you remove this line?
+4174,"@@ -78,12 +78,12 @@ public class FeedParserTask implements Callable<FeedHandlerResult> {
+         }
+ 
+         if (successful) {
+-            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(),
+-                    DownloadError.SUCCESS, successful, reasonDetailed);
++            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(), DownloadError.SUCCESS,
++                                                successful, reasonDetailed, request.isInitiatedByUser());
+             return result;
+         } else {
+-            downloadStatus = new DownloadStatus(feed, request.getTitle(),
+-                    reason, successful, reasonDetailed);
++            downloadStatus = new DownloadStatus(feed, feed.getHumanReadableIdentifier(), reason, successful,
++                                                reasonDetailed, request.isInitiatedByUser());
+             return null;
+         }
+     }","Please use `request.getTitle()` instead of `feed.getHumanReadableIdentifier()`: In this case, `feed` does not have a human readable title yet",Shouldn't this be `request.isInitiatedByUser()`?
+4175,"@@ -254,7 +254,7 @@ func waitForClef(logger logging.Logger, maxRetries uint64, endpoint string) (ext
+ 			return nil, err
+ 		}
+ 		maxRetries--
+-		logger.Errorf(""cannot connect to clef signer: %v"", err)
++		logger.Warningf(""failing to connect to clef signer: %v"", err)
+ 
+ 		time.Sleep(5 * time.Second)
+ 	}",I think the wording on the left is better,Why is this a warning?
+4176,"@@ -69,7 +69,7 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // YARPC.
+ func Interceptor(interceptor func(yarpcHandler http.Handler) http.Handler) InboundOption {
+ 	return func(i *Inbound) {
+-		i.interceptor = interceptor
++		i.interceptors = append(i.interceptors, interceptor)
+ 	}
+ }
+ ",Please update the method described to point out that it maintains a chain of interceptors and they will be called in the same order passed in the options.,Why is this needed?
+4177,"@@ -37,9 +37,16 @@ namespace Datadog.Trace.ClrProfiler.Managed.Loader
+             }
+ 
+             var path = Path.Combine(ManagedProfilerDirectory, $""{assemblyName}.dll"");
++
+             if (File.Exists(path))
+             {
+-                StartupLogger.Debug(""Loading {0}"", path);
++                if (args.Name.StartsWith(""Datadog.Trace, Version="") && args.Name != AssemblyName)
++                {
++                    StartupLogger.Debug(""Trying to load {0} which does not match the expected version ({1})"", args.Name, AssemblyName);
++                    return null;
++                }
++
++                StartupLogger.Debug(""Resolving {0}, loading {1}"", args.Name, path);
+                 return Assembly.LoadFrom(path);
+             }
+ ",Is this case purely hypothetical or did it solve an issue that occurred in your testing? I'm trying to understand this change a little better,Should this be `arg
+4178,"@@ -431,7 +431,7 @@ func (p *ReplicationTaskProcessorImpl) putReplicationTaskToDLQ(replicationTask *
+ 	p.metricsClient.Scope(
+ 		metrics.ReplicationDLQStatsScope,
+ 		metrics.TargetClusterTag(p.sourceCluster),
+-		metrics.InstanceTag(strconv.Itoa(p.shard.GetShardID())),
++		metrics.InstanceTag(strconv.Itoa(int(p.shard.GetShardID()))),
+ 	).UpdateGauge(
+ 		metrics.ReplicationDLQMaxLevelGauge,
+ 		float64(request.TaskInfo.GetTaskId()),",Use instead `convert.Int32ToString` that was added in #762 for this purpose.,Why do we need the 
+4179,"@@ -473,7 +473,7 @@ public final class HashSet<T> implements Kind1<HashSet<?>, T>, Set<T>, Serializa
+ 
+     @Override
+     public HashSet<T> add(T element) {
+-        return new HashSet<>(tree.put(element, element));
++        return contains(element) ? this : new HashSet<>(tree.put(element, element));
+     }
+ 
+     @Override","If key is present, tree.put(k,v) needs to return a new instance for Maps and the same instance for Sets. Therefore we currently perform an additional 'contains' check for Sets. A future optimization may add an additional flag `replace` to the backing HAMT.put() / RedBlackTree.insert() methods. Sets set it to replace=false, Maps set it to replace=true. But for now this solution is working for us.",Why do we need this
+4180,"@@ -0,0 +1,18 @@
++""""""Test to see we don't crash on this code in pandas.
++See: https://github.com/pandas-dev/pandas/blob/master/pandas/core/arrays/sparse/array.py
++Code written van G van Rossum here: https://github.com/python/typing/issues/684""""""
++# pylint: disable=no-member, redefined-builtin, invalid-name, missing-class-docstring
++
++from typing import TYPE_CHECKING
++
++if TYPE_CHECKING:
++    from enum import Enum
++
++    class ellipsis(Enum):
++        Ellipsis = ""...""
++
++    Ellipsis = ellipsis.Ellipsis
++
++
++else:
++    ellipsis = type(Ellipsis)",This is a regression test for code I found while working on this.,I don't think we need this anymore.
+4181,"@@ -6503,8 +6503,15 @@ ex_expr::exp_return_type ex_function_json_object_field_text::eval(char *op_data[
+         Int32 prec2 = ((SimpleType *)getOperand(2))->getPrecision();
+         len2 = Attributes::trimFillerSpaces( op_data[2], prec2, len2, cs );
+     }
++
+     char *rltStr = NULL;
+-    JsonReturnType ret = json_extract_path_text(&rltStr, op_data[1], 1, op_data[2]);
++    char *jsonStr = new(heap) char[len1+1];
++    char *jsonAttr = new(heap) char[len2+1];
++    strncpy(jsonStr, op_data[1], len1);
++    jsonStr[len1] = '\0';
++    strncpy(jsonAttr, op_data[2], len2);
++    jsonAttr[len2] = '\0';
++    JsonReturnType ret = json_extract_path_text(&rltStr, jsonStr, 1, jsonAttr);
+     if (ret != JSON_OK)
+     {
+         ExRaiseJSONError(heap, diagsArea, ret);","I'm wondering if we need to delete jsonStr and jsonAttr after the json_extract_path_text call to avoid unnecessary heap pressure. Though if json_extract_path_text itself does new's on the same heap, we'd get heap fragmentation. Another approach would be to allocate these on the stack instead, avoiding both concerns: char jsonStr[len1+1]; char jsonAttr[len2+1]; ...",Why do we need to create a new stri
+4182,"@@ -67,14 +67,14 @@ def lambda_handler(request):
+     user_size = request.args.get('size', DEFAULT_SIZE)
+     user_source = request.args.get('_source', [])
+     # 0-indexed starting position (for pagination)
+-    user_from = request.args.get('from', 0)
++    user_from = int(request.args.get('from', 0))
+     terminate_after = None  # see if we can skip os.getenv('MAX_DOCUMENTS_PER_SHARD')
+ 
+     if not user_indexes or not isinstance(user_indexes, str):
+         raise ValueError(""Request must include index=<comma-separated string of indices>"")
+ 
+-    if not isinstance(user_from, int) or user_from < 0:
+-        raise ValueError(""'from' must be a positive integer"")
++    if user_from < 0:
++        raise ValueError(""'from' must be a non-negative integer"")
+ 
+     if action == 'packages':
+         query = request.args.get('query', '')",Does it come as `str`?,I think this should be `if user_fro
+4183,"@@ -290,7 +290,7 @@ public class IngredientsProductFragment extends BaseFragment implements IIngredi
+             substanceProduct.append("" "");
+ 
+             String allergen;
+-            for (int i = 0; i < allergens.size() - 1; i++) {
++            for (int i = 0; i <= allergens.size() - 1; i++) {
+                 allergen = allergens.get(i);
+                 substanceProduct.append(Utils.getClickableText(allergen, allergen, SearchType.ALLERGEN, getActivity(), customTabsIntent));
+                 substanceProduct.append("", "");",This should actually read as the following `for (int i = 0; i < allergens.size(); i++)`,Why this change?
+4184,"@@ -1192,6 +1192,10 @@ func (b *ColListTableBuilder) SetValue(i, j int, v values.Value) error {
+ }
+ 
+ func (b *ColListTableBuilder) AppendValue(j int, v values.Value) error {
++	if v.IsNull() {
++		return b.AppendNil(j)
++	}
++
+ 	switch v.Type() {
+ 	case semantic.Bool:
+ 		return b.AppendBool(j, v.Bool())","This is so useful and safety, I want to propose making AppendBool, AppendInt, etc. all private functions, and forcing us to use AppendValue(j, values.New(false)), etc.",Why do we need this?
+4185,"@@ -140,7 +140,9 @@ export function useImperativeHandle(ref, createHandle, args) {
+ 	const state = getHookState(currentIndex++);
+ 	if (argsChanged(state._args, args)) {
+ 		state._args = args;
+-		ref.current = createHandle();
++			if (ref) {
++				ref.current = createHandle();
++			}
+ 	}
+ }
+ ","Really, really small nit   I believe there's 3x tabs in here? And should it be just 2x?",Shouldn't this be `r
+4186,"@@ -748,6 +748,17 @@ Use this only if v4 signatures don't work, eg pre Jewel/v10 CEPH.`,
+ See: [AWS S3 Transfer acceleration](https://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration-examples.html)`,
+ 			Default:  false,
+ 			Advanced: true,
++		}, {
++			Name:     ""leave_parts_on_error"",
++			Provider: ""AWS"",
++			Help: `If true avoid calling abort upload on a failure, leaving all successfully uploaded parts on S3 for manual recovery.
++
++It should be set to true for resuming uploads across different sessions.
++
++WARNING: Storing parts of an incomplete multipart upload counts towards space usage on S3 and will add additional costs if not cleaned up.
++`,
++			Default:  false,
++			Advanced: true,
+ 		}},
+ 	})
+ }",Perhaps note that rclone can't do this yet?,I think this should 
+4187,"@@ -285,3 +285,14 @@ func (c *client) doRequest(
+ 
+ 	return res, requestError{}
+ }
++
++// ConfigureTransports converts an net/http HTTP/1 Transport to a http3.RoundTripper
++// Uses the original TLS config, if present, relying on the clone created on a
++// new connection.
++func ConfigureTransports(t1 *http.Transport) *RoundTripper {
++	roundtripper := &RoundTripper{
++		TLSClientConfig: t1.TLSClientConfig,
++		QuicConfig:      &quic.Config{},
++	}
++	return roundtripper
++}",You probably don't need to set an empty config here.,nit: `ConfigureTrans
+4188,"@@ -12,6 +12,19 @@ from ..element import Element
+ from .grid import GridInterface
+ from .interface import Interface, DataError, dask_array_module
+ 
++try:
++    import cftime
++    cftime_types = (
++        cftime._cftime.DatetimeGregorian,
++        cftime._cftime.Datetime360Day,
++        cftime._cftime.DatetimeJulian,
++        cftime._cftime.DatetimeNoLeap,
++        cftime._cftime.DatetimeProlepticGregorian
++    )
++    util.datetime_types += cftime_types
++except:
++    cftime_types = ()
++
+ 
+ class XArrayInterface(GridInterface):
+ ","I think you are missing `cftime.DatetimeAllLeap` here. That said, all of these are subclasses of `cftime.datetime`, so I think you could get away with just using `cftime.datetime` here, rather than enumerating all of the different subclasses (since `cftime_types` is only used for instance checks).","I don't think we need this anymore, right?"
+4189,"@@ -37,6 +37,11 @@ const (
+ 	StoragePoolClaimCPK CasPoolKey = ""openebs.io/storage-pool-claim""
+ 	// CStorPoolClusterCPK is the CStorPoolcluster label
+ 	CStorPoolClusterCPK CasPoolKey = ""openebs.io/cstor-pool-cluster""
++	// CStorPoolInstanceCPK is the CStorPoolInstance label
++	CStorPoolInstanceCPK CasPoolKey = ""openebs.io/cstor-pool-instance""
++	// PredecessorBlockDeviceCPK is the annotation on the block device claim
++	// holding previous block device name
++	PredecessorBlockDeviceCPK CasPoolKey = ""openebs.io/bd-predecessor""
+ 	// NdmDiskTypeCPK is the node-disk-manager disk type e.g. 'sparse' or 'disk'
+ 	NdmDiskTypeCPK CasPoolKey = ""ndm.io/disk-type""
+ 	// NdmBlockDeviceTypeCPK is the node-disk-manager blockdevice type e.g. // 'blockdevice'",don't we need to set this label on pool pods? I don't see them being set,I don't think we need this annotation. We 
+4190,"@@ -27,7 +27,7 @@ struct train_kernel_cpu<Float, method::brute_force> {
+     train_result operator()(const context_cpu& ctx,
+                             const descriptor_base& desc,
+                             const train_input& input) const {
+-        throw unimplemented_error(""k-NN brute force method is not implemented for CPU!"");
++        throw unimplemented_error(""k-NN brute force method is not implemented for CPU"");
+         return train_result();
+     }
+ };","can remove, it isn't reachable.",I don't think this should be changed.
+4191,"@@ -160,7 +160,7 @@ describe Cancellation do
+       subscription = build_stubbed(:subscription, plan: subscribed_plan)
+       cancellation = Cancellation.new(subscription)
+ 
+-      expect(cancellation.can_downgrade_instead?).to be_true
++      expect(cancellation.can_downgrade_instead?).to be true
+     end
+ 
+     it 'returns true if the subscribed plan is not the downgrade plan' do",`expect(cancellation).to be_can_downgrade_instead` would be preferred :rainbow: :rainbow:,Line is too long. [81/80]
+4192,"@@ -65,6 +65,11 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+                         }
+                     }
+ 
++                    if (_socket.IsClosed)
++                    {
++                        break;
++                    }
++
+                     if (result.IsCancelled)
+                     {
+                         // Send a FIN","Gross. The OS should timeout writes for completely unresponsive clients to begin with. Long term, the better solution is to enforce a minimum minimum data rate for responses. This might require a way to cancel LibuvAwaitables, but it definitely not OK to immediately kill the socket and any ongoing writes just because the request processing loop completed. You could consider doing that after some kind of timeout, but at that point you might as well just enforce a minimum rate.",Why is this needed?
+4193,"@@ -66,7 +66,8 @@ void mesh_reader::load() {
+   select_subset_of_data();
+ }
+ 
+-bool mesh_reader::fetch_datum(CPUMat& X, int data_id, int mb_idx, int tid) {
++bool mesh_reader::fetch_datum(CPUMat& X, int data_id, int mb_idx, thread_pool& io_thread_pool) {
++  //  int tid = io_thread_pool.get_local_thread_id();
+   if (m_random_flips) {
+     fast_rng_gen& gen = get_fast_generator();
+     std::uniform_int_distribution<int> dist(0, 1);","If this is not used, we should just delete the line.",remove this line?
+4194,"@@ -89,11 +89,7 @@ func defaultExec(
+ 	// for transporting shell-style streams
+ 	exec, err := remotecommand.NewSPDYExecutor(config, ""POST"", req.URL())
+ 	if err != nil {
+-		return nil, errors.Wrapf(
+-			err,
+-			""failed to exec into pod {%s}: failed to connect to the provided server"",
+-			name,
+-		)
++		return nil, err
+ 	}
+ 
+ 	// Stream initiates transport of standard shell streams",Are there other callers to this function. How will they be impacted.,Why is this removed
+4195,"@@ -23,7 +23,7 @@
+ Defines an interface which all Auth handlers need to implement.
+ """"""
+ 
+-from plugin import Plugin
++from .plugin import Plugin
+ 
+ class NotReadyToAuthenticate(Exception):
+   pass","Let's be consistent. The majority of boto code does not use relative imports. Let's just stick to the existing standard of ""from boto.package.subpackage import Thing"".",Why did you change 
+4196,"@@ -207,6 +207,12 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+   // CLI options defined by user at runtime.
+   // Options parsing is done with CLI library Picocli https://picocli.info/
+ 
++  @Option(
++      names = ""--identity"",
++      paramLabel = ""<String>"",
++      description = ""Identification for this node in the Client ID"")
++  private final Optional<String> identityString = Optional.empty();
++
+   // Completely disables P2P within Besu.
+   @Option(
+       names = {""--p2p-enabled""},",Suggestion: specify `arity` for this option.,This should be `<String>`.
+4197,"@@ -264,6 +264,9 @@ class SpikesPlot(PathPlot):
+     position = param.Number(default=0., doc=""""""
+       The position of the lower end of each spike."""""")
+ 
++    show_legend = param.Boolean(default=True, doc=""""""
++        Whether to show legend for the plot."""""")
++
+     style_opts = (['color', 'cmap', 'palette'] + line_properties)
+ 
+     def get_extents(self, element, ranges):","This is a parameter available for the matplotlib backend IIRC. In which case, it is good to see this support added to the Bokeh backend.",This should be `param.Bool
+4198,"@@ -641,7 +641,7 @@ public final class Span implements Serializable { // for Spark and Flink jobs
+    */
+   public static String normalizeTraceId(String traceId) {
+     if (traceId == null) throw new NullPointerException(""traceId == null"");
+-    int length = traceId.length();
++    int length = traceId.trim().length();
+     if (length == 0) throw new IllegalArgumentException(""traceId is empty"");
+     if (length > 32) throw new IllegalArgumentException(""traceId.length > 32"");
+     int zeros = validateHexAndReturnZeroPrefix(traceId);",trim has performance impact and this is the lowest level library... seems the trim if occurs should happen in the UI or Query controller instead..,Why is this change needed?
+4199,"@@ -80,6 +80,7 @@ class Request(testprocess.Line):
+ 
+             '/500-inline': [http.client.INTERNAL_SERVER_ERROR],
+         }
++        # pylint: enable=no-member
+         for i in range(15):
+             path_to_statuses['/redirect/{}'.format(i)] = [http.client.FOUND]
+         for suffix in ['', '1', '2', '3', '4', '5', '6']:",Probably also needed for the `http.client.FOUND` below?,Why do we need this?
+4200,"@@ -97,6 +97,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""                     Default value is \""T\""\n""
+     ""  --no-js-exports    Removes Node.js style export lines in JS.\n""
+     ""  --goog-js-export   Uses goog.exports* for closure compiler exporting in JS.\n""
++    ""  --es6-js-export    Uses ECMAScript 6 export style lines in JS.\n""
+     ""  --go-namespace     Generate the overrided namespace in Golang.\n""
+     ""  --go-import        Generate the overrided import for flatbuffers in Golang.\n""
+     ""                     (default is \""github.com/google/flatbuffers/go\"")\n""",Can you also add this to Compiler.md ?,This should be `--es6-js-export`.
+4201,"@@ -144,8 +144,9 @@ class HttpClient {
+  * @param {function(!Error)} onError The function to call if the request fails.
+  * @param {?string=} opt_data The data to send with the request.
+  * @param {?RequestOptions=} opt_proxy The proxy server to use for the request.
++ * @param {!number=} retries The current number of retries.
+  */
+-function sendRequest(options, onOk, onError, opt_data, opt_proxy) {
++function sendRequest(options, onOk, onError, opt_data, opt_proxy, retries) {
+   var hostname = options.hostname;
+   var port = options.port;
+ ",!numbers -> numbers,nit: `retries` -> `retriesCount`
+4202,"@@ -413,9 +413,9 @@ public class JavaSurfaceNamer extends SurfaceNamer {
+    * <p>All Google cloud java libraries have package names like ""com.google.cloud.library.v1"" and
+    * the respective examples have package names like
+    * ""com.google.cloud.examples.library.v1.snippets"". This method assumes {@code packageName} has
+-   * the format of ""com.google.(.+).artifact.name"". This works for both existing libraries and the
+-   * baseline test. We will need to adjust this if in the future there are libraries that do not
+-   * follow the package name format assumed here.
++   * the format of ""com.google.orgname.artifact.name"", where ""artifact.name"" could be empty. This
++   * works for both existing libraries and the baseline test. We will need to adjust this if in the
++   * future there are libraries that do not follow the package name format assumed here.
+    */
+   @Override
+   public String getExamplePackageName() {",This description doesn't seem quite right for the longrunning case - `longrunning` isn't an orgname.,I don't think we should change th
+4203,"@@ -93,4 +93,11 @@ public interface LeafCollector {
+    */
+   void collect(int doc) throws IOException;
+ 
++  /*
++   * optionally returns an iterator over competitive documents
++   */
++  default DocIdSetIterator iterator() {
++    return null;
++  }
++
+ }","maybe give it a more descriptive name, e.g. `competitiveFilter`",I'm not sure if this is the best 
+4204,"@@ -106,7 +106,7 @@ public class JWTVerificationkeyResolver implements VerificationKeyResolver {
+         }
+       }
+ 
+-      // Add all keys into a master list
++      // Add all keys into a primary list
+       if (issuerConfig.usesHttpsJwk()) {
+         keysSource = ""["" + String.join("", "", issuerConfig.getJwksUrls()) + ""]"";
+         for (HttpsJwks hjwks : issuerConfig.getHttpsJwks()) {","This occurrence of ""master"" is unrelated to master/slave replication. Maybe simply remove the word ""master"" or replace it with ""reference"" but ""primary"" doesn't really make sense.","I think this should be ""secondary"" instead of ""primary""."
+4205,"@@ -15,6 +15,7 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/actor/builtin/miner""
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/exec""
++	""github.com/filecoin-project/go-filecoin/proofs""
+ 	""github.com/filecoin-project/go-filecoin/types""
+ 	""github.com/filecoin-project/go-filecoin/vm/errors""
+ )","BLOCKING: This is a problem. We shouldn't be introducing new dependencies on proofs into actors. The miner has some dependencies that should be removed (#2555). This could be accomplished either by moving `proofs.Mode` to `types.ProofsMode` or by forgoing a new type altogether and replacing it with a boolean. The later would have the additional advantage of reducing the number of types we have to export through ABI. I get why `proofs.Mode` has value as a type over a boolean, but I'm not sure it's worth it here.",This import should be grouped with the other filecoin im
+4206,"@@ -74,7 +74,9 @@ func verifyReceiveMessage(r *request.Request) {
+ 		for _, msg := range out.Messages {
+ 			err := checksumsMatch(msg.Body, msg.MD5OfBody)
+ 			if err != nil {
+-				ids = append(ids, *msg.MessageId)
++				if msg.MessageId != nil {
++					ids = append(ids, *msg.MessageId)
++				}
+ 			}
+ 		}
+ 		if len(ids) > 0 {",We probably want to log the fact that a `MessageId` was not present in the response. In addition the `RequestID` from `request.Request` should be included in the message so that the user is aware of the issue.,Why do we need this check?
+4207,"@@ -38,10 +38,11 @@ apiFetchMock.mockImplementation( ( ...args ) => {
+ 
+ const setupRegistry = ( { dispatch } ) => {
+ 	const { id, webPropertyId, accountId } = fixtures.propertiesProfiles.profiles[ 0 ];
++	const propertyID = webPropertyId;
+ 	dispatch( STORE_NAME ).setAccountID( accountId );
+ 	dispatch( STORE_NAME ).setPropertyID( webPropertyId );
+ 	dispatch( STORE_NAME ).setProfileID( id );
+-	dispatch( STORE_NAME ).receiveProfiles( fixtures.propertiesProfiles.profiles );
++	dispatch( STORE_NAME ).receiveProfiles( fixtures.propertiesProfiles.profiles, { propertyID } );
+ };
+ 
+ const setupRegistryWithExistingTag = ( { dispatch } ) => {","It feels a bit strange to re-assign that here, as that line itself has no context on why it's reassigned. I'd prefer if we could pass `{ propertyID: webPropertyId }` below instead (that's how we do that elsewhere too). This also applies to other similar re-assignments below - let's rather pass the values within the objects as applicable, since then there is more clear context on why this ""rename"" / ""reassignment"" is necessary (because of an object expecting specific properties).",`propertyID` is not used in this function.
+4208,"@@ -172,6 +172,7 @@ module.exports = function(grunt) {
+                     'frontend/express/public/core/events/javascripts/countly.overview.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.details.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.details.models.js',
++                    'frontend/express/public/core/events/javascripts/countly.compare.models.js',
+                     'frontend/express/public/core/user-management/javascripts/countly.overview.models.js',
+                     'frontend/express/public/core/user-management/javascripts/countly.overview.views.js'
+                 ],",remove this in the new pr aswell when moving compare to plugins as discussed.,I think this should be `countly.compare.views.js`
+4209,"@@ -210,10 +210,16 @@ Status YieldClauseWrapper::prepare(
+     yieldColsHolder_ = std::make_unique<YieldColumns>();
+     for (auto *col : cols) {
+         if (col->expr()->isInputExpression()) {
++            if (inputs == nullptr) {
++                return Status::Error(""Inputs nullptr."");
++            }
+             if (needAllPropsFromInput(col, inputs, yields)) {
+                 continue;
+             }
+         } else if (col->expr()->isVariableExpression()) {
++            if (varHolder == nullptr) {
++                return Status::Error(""VarHolder nullptr."");
++            }
+             auto ret = needAllPropsFromVar(col, varHolder, yields);
+             if (!ret.ok()) {
+                 return std::move(ret).status();","check varHolder is nullptr is redundant, ExecutionContext ensure",nit: `if (inputs == nullptr) {`
+4210,"@@ -0,0 +1,8 @@
++module UnsubscribesHelper
++  def unsubscribe_token_verifier
++    @_unsubscribe_token_verifier ||= ActiveSupport::MessageVerifier.new(
++      ENV.fetch(""UNSUBSCRIBE_SECRET_BASE""),
++      digest: ""SHA256"".freeze,
++    )
++  end
++end",Make these frozen constants?,I think this should be `UNSUBSCRIBE_TOKEN_VERIFIE
+4211,"@@ -55,8 +55,9 @@ def browseableMessage(message,title=None,isHtml=False):
+ 	if not title:
+ 		# Translators: The title for the dialog used to present general NVDA messages in browse mode.
+ 		title = _(""NVDA Message"")
+-	isHtmlArgument = ""true"" if isHtml else ""false""
+-	dialogString = u""{isHtml};{title};{message}"".format( isHtml = isHtmlArgument , title=title , message=message ) 
++	if not isHtml:
++		message = f""<pre>{message.replace('<', '&lt;')}</pre>""
++	dialogString = f""{title};{message}""
+ 	dialogArguements = automation.VARIANT( dialogString )
+ 	gui.mainFrame.prePopup() 
+ 	windll.mshtml.ShowHTMLDialogEx( ",Please use something like html.escape() to ensure that the text is totally safe to include within html. &lt; is not enough.,I'm not sure if this is the best way to do this. 
+4212,"@@ -130,7 +130,7 @@ func (s *Service) RetrieveChunk(ctx context.Context, addr swarm.Address, origin
+ 		var (
+ 			peerAttempt  int
+ 			peersResults int
+-			resultC      = make(chan retrievalResult, maxSelects)
++			resultC      = make(chan retrievalResult, 2)
+ 		)
+ 
+ 		requestAttempt := 0","why is a buffered channel larger than 1 needed here? the separate goroutines can just try to write to the channel with a select-default block, and then it is not needed. i find the current implementation a bit convoluted, maybe we could simplify it a bit? not sure why it is needed for example to communicate an empty result. these patterns can be simplified using waitgroups",Why is this change needed?
+4213,"@@ -11,7 +11,7 @@
+ #
+ # It's strongly recommended that you check this file into your version control system.
+ 
+-ActiveRecord::Schema.define(version: 20150410155813) do
++ActiveRecord::Schema.define(version: 20150415145819) do
+ 
+   # These are extensions that must be enabled in order to support this database
+   enable_extension ""plpgsql""",There seem to be more changes in here than I'd expect (mostly `limit: 255` additions).,I think this should be `20
+4214,"@@ -38,6 +38,10 @@ namespace OpenTelemetry.Context.Propagation
+         private static readonly int VersionAndTraceIdAndSpanIdLength = ""00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-"".Length;
+         private static readonly int OptionsLength = ""00"".Length;
+         private static readonly int TraceparentLengthV0 = ""00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-00"".Length;
++        private static readonly int TraceStateKeyMaxLength = 256;
++        private static readonly int TraceStateKeyTenentMaxLength = 241;
++        private static readonly int TraceStateKeyVendorMaxLength = 14;
++        private static readonly int TraceStateValueMaxLength = 256;
+ 
+         /// <inheritdoc/>
+         public override ISet<string> Fields => new HashSet<string> { TraceState, TraceParent };","I'm not sure, but I think it's `Tenant`",I'm not sure if this is a 
+4215,"@@ -15,8 +15,9 @@ namespace Datadog.Trace.Configuration
+         /// <paramref name=""data""/>.
+         /// </summary>
+         /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
++        /// <param name=""allowOptionalMappings"">Determines whether to create dictionary entries when the input has no value mapping</param>
+         /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
+-        public static IDictionary<string, string> ParseCustomKeyValues(string data)
++        public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)
+         {
+             var dictionary = new ConcurrentDictionary<string, string>();
+ ","Not sure if it's an issue, but this is a breaking change in a public API. Maybe we should add as an overload without optional parameter instead and delegate the existing call to this one?",This is a breaking change.
+4216,"@@ -147,6 +147,11 @@ func (o *Outbound) Transports() []transport.Transport {
+ 	return []transport.Transport{o.transport}
+ }
+ 
++// Chooser returns the outbound's peer chooser.
++func (o *Outbound) Chooser() peer.Chooser {
++	return o.chooser
++}
++
+ // Start the HTTP outbound
+ func (o *Outbound) Start() error {
+ 	return o.once.Start(o.chooser.Start)","as opposed to exposing the chooser function and increasing our API exposure for the purpose of tests, can we move the HTTP transport config test into this package?",Why not just return `o.chooser`?
+4217,"@@ -461,6 +461,17 @@ error_conn:
+ 	return 0;
+ }
+ 
++static void wlr_drm_connector_set_dpms(struct wlr_output *output, enum dpms_enum level) {
++	struct wlr_drm_connector *conn = (struct wlr_drm_connector *)output;
++	struct wlr_drm_backend *drm = (struct wlr_drm_backend *)output->backend;
++
++    if (drmModeObjectSetProperty (drm->fd, conn->id,
++                DRM_MODE_OBJECT_CONNECTOR,
++                conn->props.dpms, level) < 0)
++        wlr_log(L_ERROR, ""Failed to set dpms state for %s"", conn->output.name);
++
++}
++
+ static bool wlr_drm_connector_set_mode(struct wlr_output *output,
+ 		struct wlr_output_mode *mode) {
+ 	struct wlr_drm_connector *conn = (struct wlr_drm_connector *)output;",This is using the legacy DRM interface. DPMS levels have been removed from the atomic interface IIRC. Should we handle DPMS levels at all?,Should this be `< 0`?
+4218,"@@ -162,13 +162,13 @@ type confirmedTx struct {
+ 	watch   *transactionWatch
+ }
+ 
+-// potentiallyConfirmedWatches returns all watches with nonce less than what was specified
++// potentiallyConfirmedWatches returns all watches with nonce less than or equal what was specified
+ func (tm *transactionMonitor) potentiallyConfirmedWatches(nonce uint64) (watches []*transactionWatch) {
+ 	tm.lock.Lock()
+ 	defer tm.lock.Unlock()
+ 
+ 	for watch := range tm.watches {
+-		if watch.nonce < nonce {
++		if watch.nonce <= nonce {
+ 			watches = append(watches, watch)
+ 		}
+ 	}","I think this was correct before. The nonce passed in here is the nonce at a block (which is the next nonce not yet used, e.g. 0 if the account was never used, 1 if only the tx with nonce 0 has been sent). So if the in-block nonce is 12, then a transaction with nonce 12 cannot have been included yet.",I think this should be `<`
+4219,"@@ -0,0 +1,13 @@
++const { NativeModules, Platform } = require('react-native');
++
++const ext = (Platform.OS === 'android' && NativeModules.ShareExtension) ?
++	{
++		data: () => NativeModules.ShareExtension.data(),
++		close: () => NativeModules.ShareExtension.close(),
++	} :
++	{
++		data: () => {},
++		close: () => {},
++	};
++
++export default ext;","Please name the file ShareExtension.js, as you import it under this name (also could you convert it to TypeScript please?)",Why do we need this?
+4220,"@@ -45,6 +45,7 @@ type ClusterOpts struct {
+ 	TLSTimeout     float64           `json:""-""`
+ 	TLSConfig      *tls.Config       `json:""-""`
+ 	TLSMap         bool              `json:""-""`
++	TLSInsecure    bool              `json:""tls_insecure""`
+ 	ListenStr      string            `json:""-""`
+ 	Advertise      string            `json:""-""`
+ 	NoAdvertise    bool              `json:""-""`","Not sure if we need it, but if we set it, be sure to add `,omitempty`.",Why do we need this?
+4221,"@@ -17,7 +17,7 @@ var (
+ 	errGetLengthNotForVersionNegotiation = errors.New(""PublicHeader: GetLength cannot be called for VersionNegotiation packets"")
+ )
+ 
+-// The PublicHeader of a QUIC packet
++// The PublicHeader of a QUIC packet.
+ type PublicHeader struct {
+ 	Raw                  []byte
+ 	ConnectionID         protocol.ConnectionID","It's the whole `PublicHeader` that will change soon, and we should state that here, not in the member functions. If Jana's proposal for a new header is accepted, we might also want to rename the fields here. For example, there won't be a dedicated version flag anymore, so a more appropriate name might be `ContainsVersion` instead of `VersionFlag`.",nit: remove period a
+4222,"@@ -1003,8 +1003,8 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+     }
+ 
+     @Override
+-    public int indexOf(Character element, int from) {
+-        return back.indexOf(element, from);
++    public int indexOf(Object element, int from) {
++        return back.indexOf((Character) element, from);
+     }
+ 
+     @Override",I think `element` can stay of type `Character` because `Character` is a final class. The we do not need the cast in the line below.,Why is this change n
+4223,"@@ -260,6 +260,15 @@ public interface ASTAnyTypeDeclaration
+     }
+ 
+ 
++    /**
++     * Returns true if this is a regular interface declaration (not an annotation).
++     * Note that {@link #isInterface()} counts annotations in.
++     */
++    default boolean isRegularInterface() {
++        return false;
++    }
++
++
+     /** Returns true if this is an {@linkplain ASTAnnotationTypeDeclaration annotation type declaration}. */
+     default boolean isAnnotation() {
+         return this instanceof ASTAnnotationTypeDeclaration;","Not sure, if we should do it the other way round. If you ask be in the middle of the night, whether Interface should return true as ""isInterface"" and what Annotation would return. I'd tell you, Annotations should return false.... I want to say, on first glance, I'd say, it's easier to have ""isInterface"" and ""isAnnotation"" rather than ""isInterface"", ""isAnnotation"" and ""isRegularInterface""... But I see, we also have ""isRegularClass"".... We still have the possibility to change the semantics of those APIs in PMD 7 *Update:* Or in other words: What is less surprising? That isInterface returns true for annotations or that it returns false?",Why do we need this 
+4224,"@@ -67,7 +67,6 @@ def lambda_handler(request):
+             raise ValueError(""'packages' action searching indexes that don't end in '_packages'"")
+         _source = user_source
+         size = user_size
+-        terminate_after = None
+     elif action == 'search':
+         query = request.args.get('query', '')
+         my_fields = user_fields or [",This will potentially skip package results. Do we really want that?,Why is this removed?
+4225,"@@ -787,7 +787,7 @@ const std::map<llvm::StringRef, hipCounter> CUDA_RUNTIME_TYPE_NAME_MAP {
+   {""cudaErrorInvalidPc"",                                               {""hipErrorInvalidPc"",                                        """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 718
+   // CUDA_ERROR_LAUNCH_FAILED
+   {""cudaErrorLaunchFailure"",                                           {""hipErrorLaunchFailure"",                                    """", CONV_NUMERIC_LITERAL, API_RUNTIME}}, // 719
+-  // no analogue
++  // CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE
+   {""cudaErrorCooperativeLaunchTooLarge"",                               {""hipErrorCooperativeLaunchTooLarge"",                        """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 720
+   // CUDA_ERROR_NOT_PERMITTED
+   {""cudaErrorNotPermitted"",                                            {""hipErrorNotPermitted"",                                     """", CONV_NUMERIC_LITERAL, API_RUNTIME, HIP_UNSUPPORTED}}, // 800",Please remove `HIP_UNSUPPORTED`,Why did you remove t
+4226,"@@ -438,7 +438,7 @@ type (
+ 
+ 	// CreateWorkflowExecutionResponse is the response to CreateWorkflowExecutionRequest
+ 	CreateWorkflowExecutionResponse struct {
+-		HistorySize int64
++		NewMutableStateStats MutableStateStatus
+ 	}
+ 
+ 	// GetWorkflowExecutionRequest is used to retrieve the info of a workflow execution","if this is a ""Status"" type then the variable name ""Stats"" (which implies ""statistics"") seems wrong (or at least confusing to me)",Why do we need this?
+4227,"@@ -35,6 +35,10 @@ const (
+ 	exportKeystorePath    = ""/var/lib/sonm/worker_keystore""
+ )
+ 
++var (
++	leakedInsecureKey = common.HexToAddress(""0x8125721c2413d99a33e351e1f6bb4e56b6b633fd"")
++)
++
+ type options struct {
+ 	version     string
+ 	cfg         *Config",maybe will be better to put it into the default worker's config rather than hardcoding the address?,Why do we need this?
+4228,"@@ -2737,14 +2737,11 @@ describe('Find', function() {
+         var db = client.db(configuration.db);
+         var collection = db.collection('shouldNotMutateUserOptions');
+         var options = { raw: 'TEST' };
+-        collection.find({}, options, function(error) {
+-          test.equal(null, error);
+-          test.equal(undefined, options.skip);
+-          test.equal(undefined, options.limit);
+-          test.equal('TEST', options.raw);
+-          client.close();
+-          done();
+-        });
++        expect(() => collection.find({}, options)).to.throw(
++          'raw should be of type boolean, but is of type string.'
++        );
++        client.close();
++        done();
+       });
+     }
+   });","It seems like this is not meant to test the option failure, but rather that `raw` can be set. This may be a superfluous test now, and we might want to delete it.",Why did you remove these assertions?
+4229,"@@ -715,6 +715,16 @@ struct roots_seat_view *roots_seat_view_from_view(
+ 	return seat_view;
+ }
+ 
++static void release_fullscreen(struct roots_output *output) {
++	if (output->fullscreen_view) {
++		if (output->fullscreen_view->set_fullscreen) {
++			output->fullscreen_view->set_fullscreen(
++				output->fullscreen_view, false);
++		}
++		view_set_fullscreen(output->fullscreen_view, false, output->wlr_output);
++	}
++}
++
+ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
+ 	// Make sure the view will be rendered on top of others, even if it's
+ 	// already focused in this seat",This is already done by `view_set_fullscreen`,I think this should be `view_set_ful
+4230,"@@ -101,6 +101,15 @@ func (pr *PeerRing) RemoveAll() []peer.Peer {
+ 	return peers
+ }
+ 
++// All returns a snapshot of all the peers from the ring as a list.
++func (pr *PeerRing) All() []peer.Peer {
++	peers := make([]peer.Peer, 0, len(pr.peerToNode))
++	for _, node := range pr.peerToNode {
++		peers = append(peers, getPeerForRingNode(node))
++	}
++	return peers
++}
++
+ func (pr *PeerRing) popNode(node *ring.Ring) peer.Peer {
+ 	p := getPeerForRingNode(node)
+ ","mmm I followed the convention of this collection. It has Add, Remove, RemoveAll, so All sounds reasonable. Else It would likely be AddPeer, RemovePeer, RemovePeers and Peers.",Why do we need this method?
+4231,"@@ -65,6 +65,15 @@ class FlagFacade
+         return $this->flagRepository->getByIds($flagIds);
+     }
+ 
++    /**
++     * @param string $uuid
++     * @return \Shopsys\FrameworkBundle\Model\Product\Flag\Flag
++     */
++    public function getByUuid(string $uuid): Flag
++    {
++        return $this->flagRepository->getByUuid($uuid);
++    }
++
+     /**
+      * @param \Shopsys\FrameworkBundle\Model\Product\Flag\FlagData $flagData
+      * @return \Shopsys\FrameworkBundle\Model\Product\Flag\Flag","_nitpick_ I'm thinking about whether this method should be in the previous commit or not. I know it's not yet used there, but in theory, neither do UUID itself.",This method is not used.
+4232,"@@ -760,6 +760,13 @@ void RaftPart::replicateLogs(folly::EventBase* eb,
+             break;
+         }
+ 
++        if (term_ != currTerm) {
++            VLOG(2) << idStr_ << ""Term has been updated, previous ""
++                    << currTerm << "", current "" << term_;
++            currTerm = term_;
++            break;
++        }
++
+         hosts = hosts_;
+     } while (false);
+ ","""break"" is right? You skip the line 768.","I think this should be `VLOG(1) << idStr_ << ""Term has been updated, previous "" << currTerm << "", current "" << term_`"
+4233,"@@ -0,0 +1,19 @@
++# RailsAdmin config file. Generated on May 30, 2012 16:34
++# See github.com/sferik/rails_admin for more informations
++
++RailsAdmin.config do |config|
++  config.authenticate_with do
++    unless current_user
++      session[:return_to] = request.url
++      redirect_to ""/sign_in"", :alert => ""You must first log in or sign up before accessing this page.""
++    end
++  end
++
++  config.authorize_with do
++    redirect_to ""/"", :alert => ""You are not authorized to access that page"" unless current_user.admin?
++  end
++
++  config.current_user_method { current_user }
++
++  config.main_app_name = ['Workshops', 'Admin']
++end",Can this use the route helper instead?,Use the new Ruby 1.9 hash syntax.
+4234,"@@ -44,6 +44,7 @@ var Set = wire.NewSet(
+ // The zero value is a server with the default options.
+ type Server struct {
+ 	reqlog        requestlog.Logger
++	Handler       http.Handler
+ 	healthHandler health.Handler
+ 	te            trace.Exporter
+ 	sampler       trace.Sampler",Why is this field exported and others aren't?,Why do we need this?
+4235,"@@ -273,6 +273,7 @@ var testFiles = [
+   , '/test/functional/byo_promises_tests.js'
+ 
+   // Functionality tests
++  , '/test/functional/dns_txt_records_tests.js'
+   , '/test/functional/mongo_client_tests.js'
+   , '/test/functional/collection_tests.js'
+   , '/test/functional/db_tests.js'",should we rename this like `mongodb_srv_tests.js`?,This file should be removed.
+4236,"@@ -46,7 +46,7 @@ class SearchConsoleDashboardWidgetSiteStats extends Component {
+ 	setOptions() {
+ 		const { selectedStats, series, vAxes } = this.props;
+ 
+-		const pageTitle = '' === googlesitekit.pageTitle ? '' : sprintf( __( 'Search Traffic Summary for %s', 'google-site-kit' ), decodeHtmlEntity( googlesitekit.pageTitle ) );
++		const pageTitle = googlesitekit.pageTitle && googlesitekit.pageTitle.length ? sprintf( __( 'Search Traffic Summary for %s', 'google-site-kit' ), decodeHtmlEntity( googlesitekit.pageTitle ) ) : '';
+ 
+ 		const options = {
+ 			chart: {","This should still have a value when there is no page title, e.g. just `__( 'Search Traffic Summary', 'google-site-kit' )`.",I think this should be `pageTitle && pageTitle.length`
+4237,"@@ -60,7 +60,10 @@ import static org.apache.solr.common.params.CollectionParams.CollectionAction.*;
+ import static org.apache.solr.common.params.CommonAdminParams.ASYNC;
+ import static org.apache.solr.common.params.CommonAdminParams.NUM_SUB_SHARDS;
+ 
+-
++/**
++ * Index split request processed by Overseer. Requests from here go to the host of the parent shard,
++ * and are processed by @link.
++ */
+ public class SplitShardCmd implements OverseerCollectionMessageHandler.Cmd {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+   private static final int MIN_NUM_SUB_SHARDS = 2;",Oops.. meant to link to SplitOp here. I'll clean up in my next commit,I don't think we need this line.
+4238,"@@ -14,6 +14,10 @@ import android.widget.Toast;
+ import com.afollestad.materialdialogs.MaterialDialog;
+ import com.fasterxml.jackson.databind.JsonNode;
+ import com.firebase.jobdispatcher.JobParameters;
++
++import io.reactivex.SingleObserver;
++import io.reactivex.android.schedulers.AndroidSchedulers;
++import io.reactivex.disposables.Disposable;
+ import io.reactivex.schedulers.Schedulers;
+ import okhttp3.MediaType;
+ import okhttp3.OkHttpClient;",Remove these unnecessary imports that you've added.,This import is unused.
+4239,"@@ -28,8 +28,8 @@ from qutebrowser.utils import usertypes
+ 
+ 
+ # Note this has entries for success/error/warn from widgets.webview:LoadStatus
+-UrlType = usertypes.enum('UrlType', ['success', 'error', 'warn', 'hover',
+-                                     'normal'])
++UrlType = usertypes.enum('UrlType', ['success', 'success_https', ' error',
++                                     'warn', 'hover', 'normal'])
+ 
+ 
+ class UrlText(textbase.TextBase):","That space shouldn't be here :wink: This lead to an exception whenever a page with an error was loaded, e.g. an inexistent host - I just fixed that :smile:",I don't think we need the `_https` here.
+4240,"@@ -735,7 +735,7 @@ class TLSServerAutomaton(Automaton):
+                                                                 self.local_port)
+             return
+         self.socket, addr = s.accept()
+-        self.remote_ip, self.remote_port = addr
++        self.remote_ip, self.remote_port = addr, self.local_port
+ 
+         raise self.WAITING_FOR_ClientHello()
+ ",It seems this is not the way to fix issue #505.,Why do we need this change?
+4241,"@@ -104,7 +104,7 @@ def binary_cross_entropy(pred,
+     if weight is not None:
+         weight = weight.float()
+     loss = F.binary_cross_entropy_with_logits(
+-        pred, label.float(), pos_weight=class_weight, reduction='none')
++        pred, label.float(), weight=class_weight, reduction='none')
+     # do the reduction for the weighted loss
+     loss = weight_reduce_loss(
+         loss, weight, reduction=reduction, avg_factor=avg_factor)",Please take a look at the docstring of `F.binary_cross_entropy_with_logits`. `weight` should be a tensor that matches the input tensor shape. It is Not the class-aware weight. `pos_weight` should be a vector with a length equal to the number of classes.,Why did you remove the `pos
+4242,"@@ -85,12 +85,15 @@ func TestSuite(
+ 			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Windows 2012 R2 two disks, Network setting (path)""))
+ 		machineImageImportStorageLocationTestCase := junitxml.NewTestCase(
+ 			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Centos 7.4, Storage location""))
++		machineImageImportNetworkTagsTestCase := junitxml.NewTestCase(
++			testSuiteName, fmt.Sprintf(""[%v] %v"", testType, ""Import with network tags""))
+ 
+ 		testsMap[testType] = map[*junitxml.TestCase]func(
+ 			context.Context, *junitxml.TestCase, *log.Logger, *testconfig.Project, e2e.CLITestType){}
+ 		testsMap[testType][machineImageImportUbuntu3DisksNetworkSettingsNameTestCase] = runOVFMachineImageImportUbuntu3DisksNetworkSettingsName
+ 		testsMap[testType][machineImageImportWindows2012R2TwoDisksNetworkSettingsPathTestCase] = runOVFMachineImageImportWindows2012R2TwoDisksNetworkSettingsPath
+ 		testsMap[testType][machineImageImportStorageLocationTestCase] = runOVFMachineImageImportCentos74StorageLocation
++		testsMap[testType][machineImageImportNetworkTagsTestCase] = runOVFMachineImageImportWithNetworkTags
+ 	}
+ 
+ 	// gcloud only tests","Same here, merge with an existing test.","I think this should be ""Imp"
+4243,"@@ -28,7 +28,7 @@ EFI_DRIVER_BINDING_PROTOCOL  gSdMmcPciHcDriverBinding = {
+   NULL
+ };
+ 
+-#define SLOT_INIT_TEMPLATE  {0, UnknownSlot, 0, 0, 0, 0,\
++#define SLOT_INIT_TEMPLATE  {0, UnknownSlot, 0, 0, 0,\
+                                {EDKII_SD_MMC_BUS_WIDTH_IGNORE,\
+                                EDKII_SD_MMC_CLOCK_FREQ_IGNORE,\
+                                {EDKII_SD_MMC_DRIVER_STRENGTH_IGNORE}}}",@aimanrosli23 Could you help to confirm if you do not revert the change in below commit: SHA-1: 643623147a1feaddd734ddd84604e1d8e9dcebee * MdeModulePkg/SdMmcPciHcDxe: Send SEND_STATUS at lower frequency,"{0, 0, 0, 0, 0,\"
+4244,"@@ -76,8 +76,10 @@ public class AvroSchemaUtil {
+     return TypeUtil.visit(type, new TypeToSchema(names));
+   }
+ 
+-  public static Type convert(Schema schema) {
+-    return AvroSchemaVisitor.visit(schema, new SchemaToType(schema));
++  public static org.apache.iceberg.Schema convert(Schema schema) {
++    final Type type = AvroSchemaVisitor.visit(schema, new SchemaToType(schema));
++    final List<Types.NestedField> fields = type.asNestedType().asStructType().fields();
++    return new org.apache.iceberg.Schema(fields);
+   }
+ 
+   static boolean hasIds(Schema schema) {",Can we do this without a breaking API change? What about adding a different name to convert directly to a Schema?,Why is this needed?
+4245,"@@ -1,7 +1,8 @@
+ 'use strict';
+ 
+-var MongoClient = require('../../').MongoClient,
+-  expect = require('chai').expect;
++const Promise = require('bluebird');
++const MongoClient = require('../../').MongoClient;
++const expect = require('chai').expect;
+ 
+ function connectToDb(url, db, options, callback) {
+   if (typeof options === 'function') {",Why do we need to pull bluebird in here?,Why this change?
+4246,"@@ -121,9 +121,10 @@ public class FlowPreparer extends AbstractFlowPreparer {
+           (flowPrepCompletionTime - criticalSectionStartTime) / 1000,
+           flow.getExecutionId(), execDir.getPath());
+     } catch (final Exception ex) {
+-      FileIOUtils.deleteDirectorySilently(tempDir);
+       LOGGER.error(""Error in preparing flow execution {}"", flow.getExecutionId(), ex);
+       throw new ExecutorManagerException(ex);
++    } finally {
++      FileIOUtils.deleteDirectorySilently(tempDir);
+     }
+   }
+ ","If *two* threads successfully download the same project into two different temp dirs, and one of them successfully renames one to its final destination, the `if`on line 102 will be false _in the other thread_, and it would leave its temp dir behind.",Why is this change 
+4247,"@@ -37,6 +37,7 @@ struct pool_entry_t {
+     h2o_socket_export_t sockinfo;
+     h2o_socketpool_target_t *target;
+     h2o_linklist_t link;
++    h2o_linklist_t target_link;
+     uint64_t added_at;
+ };
+ ",I would appreciate it if you could rename `link` to `all_link` so that the roles of the two links (the other is `target_link`) become clearer.,h2o_linklist_t *tar
+4248,"@@ -826,10 +826,16 @@ class InitialDevelopmentTests(unittest.TestCase):
+ 			""Testing testing "",
+ 			speech.PitchCommand(offset=100),
+ 			""1 2 3 4"",
+-			smi.create_ConfigProfileTriggerCommand(t1, True, expectedToBecomeIndex=1),
+-			smi.create_ConfigProfileTriggerCommand(t2, True, expectedToBecomeIndex=2),
++			ExpectedIndex(1),
++			# The preceeding index is expected,
++			# as the following profile trigger commands will cause the utterance to be split here.
++			ConfigProfileTriggerCommand(t1, True),
++			ConfigProfileTriggerCommand(t2, True),
+ 			""5 6 7 8"",
+-			smi.create_ConfigProfileTriggerCommand(t1, False, expectedToBecomeIndex=3),
++			ExpectedIndex(2),
++			# The preceeding index is expected,
++			# as the following profile trigger commands will cause the utterance to be split here.
++			ConfigProfileTriggerCommand(t1, False),
+ 			""9 10 11 12""
+ 		]
+ 		with smi.expectation():","Is there a reason not to use `smi.create_expectedIndex` here (and in other places)? The `smi.create_expectedIndex` function will also check to make sure that you don't accidentally skip or duplicate any indexes. With the goal of avoiding errors in the test. It does mean that you have to be diligent with how the expected indexes are created, which can be annoying too. My logic was that it is better to be annoyed by constraints during development time than to find out some time later that the test didn't do what I thought.",Why did you change this test?
+4249,"@@ -43,8 +43,8 @@ class StripeSubscription
+   def create_customer
+     new_stripe_customer = Stripe::Customer.create(
+       card: @checkout.stripe_token,
+-      description: @checkout.email,
+-      email: @checkout.email
++      description: @checkout.user_email,
++      email: @checkout.user_email,
+     )
+     @checkout.stripe_customer_id = new_stripe_customer.id
+   end",Put a comma after the last parameter of a multiline method call.,Line is too long. [81/80]
+4250,"@@ -29,7 +29,7 @@ type ImageWithPort struct {
+ type LBFargateConfig struct {
+ 	RoutingRule      `yaml:""http,flow""`
+ 	ContainersConfig `yaml:"",inline""`
+-	Public           bool               `yaml:""public""`
++	Public           *bool              `yaml:""public""` // A pointer because we don't want the environment override to default to false.
+ 	Scaling          *AutoScalingConfig `yaml:"",flow""`
+ }
+ ",I don't know if we even need this parameter.,Why is this a pointer?
+4251,"@@ -1,5 +1,5 @@
+ """"""Test that we are emitting arguments-differ when the arguments are different.""""""
+-# pylint: disable=missing-docstring, too-few-public-methods, unused-argument,useless-super-delegation, useless-object-inheritance
++# pylint: disable= arguments-renamed, missing-docstring, too-few-public-methods, unused-argument,useless-super-delegation, useless-object-inheritance
+ 
+ class Parent(object):
+ ",What is the new result of this file if we keep it the same than before? It's just to picture easily what changed in this MR :) (thinking is hard),# pylint: disable=arguments-r
+4252,"@@ -165,7 +165,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+ 
+                     using (var reader = new StreamReader(stream, Encoding.ASCII))
+                     {
+-                        var response = reader.ReadToEnd();
++                        var response = await reader.ReadToEndAsync();
+                         Assert.Contains($""bytesRead: {data.Length}"", response);
+                     }
+                 }",This needs to be synchronous for the timeout to work.,Why is this change needed?
+4253,"@@ -23,11 +23,7 @@ Where
+ <% if purchaseable.city.present? %><%= purchaseable.city %>, <% end %><%= purchaseable.state %> <%= purchaseable.zip %>
+ <% end -%>
+ 
+-<% unless purchaseable.starts_immediately? -%>
+-We will be in touch before <%= purchase.starts_on.to_s(:simple) %> with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.
+-<% end -%>
+-
+-<%= purchaseable.reminder_email %>
++We will be in touch before the workshop with a reminder and any further instructions. However, please don't hesitate to get in touch with us at learn@thoughtbot.com should you have any questions or concerns.
+ 
+ <% if purchaseable.workshop.announcement.present? -%>
+ <%= purchaseable.workshop.announcement.message %>",Can you break this onto multiple lines?,I don't think we should re
+4254,"@@ -298,11 +298,11 @@ const instr_info_t A32_ext_bit7[][2] = {
+  */
+ const instr_info_t A32_ext_bit19[][2] = {
+   { /* 0 */
+-    {EXT_SIMD8,         0xf2800000, ""(ext simd8  0)"", xx, xx, xx, xx, xx, no, x, 0},
+-    {EXT_SIMD5,         0xf2880000, ""(ext simd5  0)"", xx, xx, xx, xx, xx, no, x, 0},
++    {EXT_SIMD8,         0xf2800010, ""(ext simd8  0)"", xx, xx, xx, xx, xx, no, x, 0},
++    {EXT_SIMD5,         0xf2880010, ""(ext simd5  0)"", xx, xx, xx, xx, xx, no, x, 0},
+   }, { /* 1 */
+-    {EXT_SIMD8,         0xf3800000, ""(ext simd8  1)"", xx, xx, xx, xx, xx, no, x, 1},
+-    {EXT_SIMD5,         0xf3880000, ""(ext simd5  1)"", xx, xx, xx, xx, xx, no, x, 1},
++    {EXT_SIMD8,         0xf3800010, ""(ext simd8  1)"", xx, xx, xx, xx, xx, no, x, 1},
++    {EXT_SIMD5,         0xf3880010, ""(ext simd5  1)"", xx, xx, xx, xx, xx, no, x, 1},
+   },
+ };
+ ","OK, it looks like all children have bit 4 set, but it doesn't really matter at this split point: just informative, nothing reads it.",Why did you change this?
+4255,"@@ -32,6 +32,12 @@ type DNSZoneSpec struct {
+ 	// Zone is the DNS zone to host
+ 	Zone string `json:""zone""`
+ 
++	// LinkToParentDomain specifies whether DNS records should
++	// be automatically created to link this DNSZone with a
++	// parent domain.
++	// +optional
++	LinkToParentDomain bool `json:""linkToParentDomain,omitempty""`
++
+ 	// AWS specifies AWS-specific cloud configuration
+ 	// +optional
+ 	AWS *AWSDNSZoneSpec `json:""aws,omitempty""`","Sorry for the very basic question but why do we still have a DNSZone CRD in light of the DNSEndpoint, I don't fully understand the differences.",I think this should be `//
+4256,"@@ -0,0 +1,17 @@
++package session
++
++import (
++	""testing""
++	""github.com/stretchr/testify/assert""
++)
++
++func TestManagerHasUniqueSessionsStored(t *testing.T) {
++	manager := Manager{}
++	length := 10
++
++	for i := 0; i < length; i++ {
++		manager.Create()
++	}
++
++	assert.Len(t, manager.Sessions, length)
++}",Looks like loop with overhead. You can: - create SID - test private function `sessionIsUnique()`,I think you can use `require.Len` here.
+4257,"@@ -54,6 +54,7 @@ public class UserPreferences {
+     private static final String PREF_SHOW_DOWNLOAD_REPORT = ""prefShowDownloadReport"";
+     public static final String PREF_BACK_BUTTON_BEHAVIOR = ""prefBackButtonBehavior"";
+     private static final String PREF_BACK_BUTTON_GO_TO_PAGE = ""prefBackButtonGoToPage"";
++    public static final String PREF_QUEUE_SORT_ORDER = ""prefQueueSortOrder"";
+ 
+     // Queue
+     private static final String PREF_QUEUE_ADD_TO_FRONT = ""prefQueueAddToFront"";","In my opinion, it would be better to have two separate settings. One that stores if sorting is enabled and one that stores the order. That allows to toggle automatic sort without having to re-select the order.",This should be `prefQueueSortOrder`
+4258,"@@ -1,7 +1,10 @@
+ package main
+ 
+-import ""github.com/spiffe/sri/control_plane/cli""
+-import ""os""
++import (
++	""os""
++
++	""github.com/spiffe/sri/control_plane/cli""
++)
+ 
+ func main() {
+ 	control_plane_cli.Run(os.Args)",/me can't wait to rename this repo :),Why this change?
+4259,"@@ -18,10 +18,14 @@ const handleCallback = require('../utils').handleCallback;
+ const indexInformationDb = require('./db_ops').indexInformation;
+ const isObject = require('../utils').isObject;
+ const Long = require('mongodb-core').BSON.Long;
++const makeLazyLoader = require('../utils').makeLazyLoader;
+ const MongoError = require('mongodb-core').MongoError;
+ const ReadPreference = require('mongodb-core').ReadPreference;
+ const toError = require('../utils').toError;
+ 
++const collLoader = makeLazyLoader(`${__dirname}/../collection`);
++const dbLoader = makeLazyLoader(`${__dirname}/../db`);
++
+ /**
+  * Group function helper
+  * @ignore",nit: maybe call these `loadCollection()/loadDb()`,Why do we need this?
+4260,"@@ -562,6 +562,19 @@ class Task(object):
+         Default behavior is to send an None value""""""
+         pass
+ 
++    def on_external_failure(self):
++        """"""
++        Override for custom error handling for failed external tasks.
++
++        This method gets called if a task is an :py:class:`luigi.task.ExternalTask`, or if a
++        :py:class:`luigi.task.Task`'s :py:meth:`run` method is not implemented.
++
++        The returned value is json encoded and sent to the scheduler as the `expl` argument.
++
++        Default behavior is to send a None value
++        """"""
++        pass
++
+     @contextmanager
+     def no_unpicklable_properties(self):
+         """"""",Did you consider just do `return Task is an external data dependency and data does not exist (yet?).'`? Less `None`'s and `ifs`.,I don't think this should be a context manager.
+4261,"@@ -2,13 +2,10 @@
+       <li class=""cite"">
+         <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect{|doc| doc.document_id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
+       </li>
+-      <li class=""refworks"">
+-        <%= render :partial => 'catalog/refworks_form', :locals => {:documents=>@document_list} %>
+-      </li>
+-
+-      <li class=""endnote"">
+-        <%= link_to t('blacklight.tools.endnote'), endnote_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}, :format => 'endnote'), {:class => 'btn btn-default'}%>
+-      </li>
++      <% if defined? BlacklightMarc %>
++        <%= render partial: 'bookmarks/refworks' %>
++        <%= render partial: 'bookmarks/endnote' %>
++      <% end %>
+       <li class=""email"">
+         <%= link_to t('blacklight.tools.email'), email_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @bookmarks.collect {|doc| doc.document_id}), :class=>""btn btn-default"", :id => ""emailLink"", :data => {:ajax_modal => ""trigger""} %>
+       </li>","Some day, we really need to make these toolbars pluggable..",I don't think you need the `<% if defined? Blac
+4262,"@@ -100,7 +100,11 @@ class WebEngineAction(browsertab.AbstractAction):
+         """"""Save the current page.""""""
+         self._widget.triggerPageAction(QWebEnginePage.SavePage)
+ 
+-    def show_source(self):
++    def show_source(self, pygment):
++        if pygment:
++            self._show_source_pygment()
++            return
++
+         try:
+             self._widget.triggerPageAction(QWebEnginePage.ViewSource)
+         except AttributeError:",This should be `pygment=False` like in `browsertab.py`,Please remove this blank line.
+4263,"@@ -766,6 +766,11 @@ func (s *Server) createClient(conn net.Conn) *client {
+ 		return c
+ 	}
+ 
++	// If there is a max subscriptions specified, add to the client.
++	if opts.MaxSubs > 0 {
++		c.msubs = opts.MaxSubs
++	}
++
+ 	// If there is a max connections specified, check that adding
+ 	// this new client would not push us over the max
+ 	if opts.MaxConn > 0 && len(s.clients) >= opts.MaxConn {",Should this be moved down (or up) to under the client lock instead of server lock?,Why do we need this?
+4264,"@@ -273,8 +273,6 @@ fpga_result __FPGA_API__ xfpga_fpgaGetMetricsByIndex(fpga_handle handle,
+ 			result = FPGA_OK;
+ 		}
+ 
+-	} else {
+-		result = FPGA_INVALID_PARAM;
+ 	}
+ 
+ out_unlock:",Why are we removing this?,Why was this removed?
+4265,"@@ -76,7 +76,7 @@ module Gsa18f
+ 
+     # @todo - this is pretty ugly
+     def public_identifier
+-      self.cart.id
++      ""##{self.cart.id}""
+     end
+ 
+     def total_price",What do you think about using `self.id` ?,I think this should b
+4266,"@@ -442,7 +442,17 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			retry := 0
++			for err != nil && retry < 10 {
++				// Set Ready and Live to false
++				healthAggregator.Report(healthName, &health.HealthReport{Live: false, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Warn(""Retrying to start Typha"")
++				retry++
++			}
++			if err != nil && retry > 10 {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()","Please log once here at Error level ""Failed to connect to Typha, will retry...""",Shouldn't this be `<=
+4267,"@@ -1,5 +1,5 @@
+ # frozen_string_literal: true
+ 
+ module Faker #:nodoc:
+-  VERSION = '2.18.0'
++  VERSION = '2.18.1'
+ end",Can you revert this change? The `VERSION` value will be updated after maintainer determines the version at release.,This should be `2.18.
+4268,"@@ -25,13 +25,13 @@ public interface DefinitionConst {
+ 
+   String nameKey = ""name"";
+ 
+-  String qulifiedServiceNameKey = serviceDescriptionKey + ""."" + nameKey;
++  String qualifiedServiceNameKey = serviceDescriptionKey + ""."" + nameKey;
+ 
+-  String qulifiedServiceVersionKey = serviceDescriptionKey + "".version"";
++  String qualifiedServiceVersionKey = serviceDescriptionKey + "".version"";
+ 
+-  String qulifiedServiceDescKey = serviceDescriptionKey + "".description"";
++  String qualifiedServiceDescKey = serviceDescriptionKey + "".description"";
+ 
+-  String qulifiedServiceRoleKey = serviceDescriptionKey + "".role"";
++  String qualifiedServiceRoleKey = serviceDescriptionKey + "".role"";
+ 
+   String allowCrossAppKey = ""allowCrossApp"";
+ ",It could be better if we use the up case letter to specify the constant string name. Such as QUALIFIED_SERVICE_NAME_KEY can let the user know it's a constant string.,Why are we changing these names?
+4269,"@@ -108,8 +108,12 @@ module RSpec
+       #   or the configured failure exit code (1 by default) if specs
+       #   failed.
+       def run_specs(example_groups)
+-        @configuration.reporter.report(@world.example_count(example_groups)) do |reporter|
++        examples_count = @world.example_count(example_groups)
++        @configuration.reporter.report(examples_count) do |reporter|
+           @configuration.with_suite_hooks do
++            if examples_count == 0 && @configuration.fail_if_no_examples
++              return @configuration.failure_exit_code
++            end
+             example_groups.map { |g| g.run(reporter) }.all? ? 0 : @configuration.failure_exit_code
+           end
+         end","This should be `@configuration.failure_exit_code`, we don't want to hard code 1.",I don't think this is the right 
+4270,"@@ -359,11 +359,10 @@ Blockly.FieldVariable.prototype.onItemSelected = function(menu, menuItem) {
+ };
+ 
+ /**
+- * Whether this field references any Blockly variables.  If true it may need to
+- * be handled differently during serialization and deserialization.  Subclasses
+- * may override this.
+- * @return {boolean} True if this field has any variable references.
++ * Overrides referencesVariables(), indicating this field refers to a variable.
++ * @return {boolean} True.
+  * @package
++ * @override
+  */
+ Blockly.FieldVariable.prototype.referencesVariables = function() {
+   return true;",Changed per review in Blockly.,"Nit: ""Indicates this field refer"
+4271,"@@ -968,12 +968,13 @@ func (c *client) bridgeAndUplinkFlows(uplinkOfport uint32, bridgeLocalPort uint3
+ 			Cookie(c.cookieAllocator.Request(category).Raw()).
+ 			Done(),
+ 		// Forward the packet to conntrackTable if it enters the OVS pipeline from the bridge interface and is sent to
+-		// local Pods.
++		// local Pods. Set the packet with MAC rewrite mark, so that the dstMAC will be re-written with real MAC in
++		// the L3Routing table, and it could be forwarded to the valid OVS interface.
+ 		c.pipeline[ClassifierTable].BuildFlow(priorityHigh).
+ 			MatchProtocol(binding.ProtocolIP).
+ 			MatchInPort(bridgeLocalPort).
+ 			MatchDstIPNet(localSubnet).
+-			Action().SetDstMAC(globalVirtualMAC).
++			Action().LoadRegRange(int(marksReg), macRewriteMark, macRewriteMarkRange).
+ 			Action().GotoTable(conntrackTable).
+ 			Cookie(c.cookieAllocator.Request(category).Raw()).
+ 			Done(),",Hi @wenyingd . so what's the original dst MAC of the reply packet from kube-proxy?,Why do we need this change?
+4272,"@@ -402,6 +402,15 @@ class MisdesignChecker(BaseChecker):
+                 ""statement (see R0916)."",
+             },
+         ),
++        (
++            ""exclude-too-few-public-methods"",
++            {
++                ""default"": (),
++                ""type"": ""csv"",
++                ""metavar"": ""<comma separated list of class names>"",
++                ""help"": ""List of qualified class names to ignore when counting public methods (see R0903)"",
++            },
++        ),
+     )
+ 
+     def __init__(self, linter=None):","Note: I wasn't sure what the right wording would be for this, so I used existing language from elsewhere in the codebase.",I think this should be `<comma separated list of qualified class names>`
+4273,"@@ -113,3 +113,13 @@ class Config(object):
+         # grab config_file default from molecule if it's not set in the user-supplied ansible options
+         if 'config_file' not in self.config['ansible']:
+             self.config['ansible']['config_file'] = self.config['molecule']['config_file']
++
++    def populate_instance_names(self, platform):
++        """"""
++        Updates instances section of config with an additional key containing the full instance name
++
++        :return: None
++        """"""
++        for instance in self.config['vagrant']['instances']:
++            instance['vm_name'] = utilities.format_instance_name(instance['name'], platform,
++                                                                 self.config['vagrant']['instances'])",Docstring for `platform`.,I think this should be `self.config['vagrant']['instances'][0]['vm_name'
+4274,"@@ -85,7 +85,9 @@ func Main() {
+ 	if err != nil {
+ 		fmt.Fprintf(os.Stderr, ""%s: %v\n"", subcommand.Name, err)
+ 	}
+-
++	if err := cleanup(); err != nil {
++		fmt.Fprintf(os.Stderr, ""error restoring console to functional state: %v\n"", err)
++	}
+ 	os.Exit(exitCode)
+ }
+ ",This should be called before any `os.Exit` otherwise it could still mess up things.,Why do we need to do this?
+4275,"@@ -7,16 +7,16 @@ package MyGame.Example;
+  */
+ public final class Color {
+   private Color() { }
+-  public static final byte Red = 1;
++  public static final int Red = 1;
+   /**
+    * \brief color Green
+    * Green is bit_flag with value (1u << 1)
+    */
+-  public static final byte Green = 2;
++  public static final int Green = 2;
+   /**
+    * \brief color Blue (1u << 3)
+    */
+-  public static final byte Blue = 8;
++  public static final int Blue = 8;
+ 
+   public static final String[] names = { ""Red"", ""Green"", """", """", """", """", """", ""Blue"", };
+ ",shouldn't this be `short` ?,Why did you change these to int?
+4276,"@@ -63,15 +63,15 @@ func (c *CmdVolumeOptions) RunVolumesList(cmd *cobra.Command) error {
+ 	}
+ 
+ 	out := make([]string, len(cvols.Items)+2)
+-	out[0] = ""Namespace|Name|Status|Type""
+-	out[1] = ""---------|----|------|----""
++	out[0] = ""Namespace|Name|Status|Type|Capacity""
++	out[1] = ""---------|----|------|----|--------""
+ 	for i, items := range cvols.Items {
+ 		if len(items.Status.Reason) == 0 {
+ 			items.Status.Reason = volumeStatusOK
+ 		}
+-		out[i+2] = fmt.Sprintf(""%s|%s|%s|%s"", items.ObjectMeta.Namespace,
++		out[i+2] = fmt.Sprintf(""%s|%s|%s|%s|%s"", items.ObjectMeta.Namespace,
+ 			items.ObjectMeta.Name,
+-			items.Status.Reason, items.Spec.CasType)
++			items.Status.Reason, items.Spec.CasType, items.Spec.Capacity)
+ 	}
+ 	if len(out) == 2 {
+ 		fmt.Println(""No Volumes are running"")",Can you please paste the output of `volume list` command which will show capacity of a openebs volume.,Shouldn't this be capacities?
+4277,"@@ -83,10 +83,15 @@ public class MetricRegistry implements MetricSet {
+      * @param metric the metric
+      * @param <T>    the type of the metric
+      * @return {@code metric}
+-     * @throws IllegalArgumentException if the name is already registered
++     * @throws IllegalArgumentException if the name is already registered or metric variable is null
+      */
+     @SuppressWarnings(""unchecked"")
+     public <T extends Metric> T register(String name, T metric) throws IllegalArgumentException {
++
++        if (metric == null) {
++            throw new IllegalArgumentException(""metric variable must not be null !!!"");
++        }
++
+         if (metric instanceof MetricRegistry) {
+             final MetricRegistry childRegistry = (MetricRegistry)metric;
+             final String childName = name;","I'd make this a `throw new NullPointerException(""metric == null"");` instead",I don't think this is the rig
+4278,"@@ -27,6 +27,7 @@ extern ""C"" {
+ #include ""ScriptingEnvironment.h""
+ #include ""../typedefs.h""
+ #include ""../Util/OpenMPWrapper.h""
++#include ""../Util/LuaUtil.h""
+ 
+ ScriptingEnvironment::ScriptingEnvironment() {}
+ ScriptingEnvironment::ScriptingEnvironment(const char * fileName) {",Include should be order lexicographically.,"#include ""LuaUtil.h"""
+4279,"@@ -538,7 +538,7 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+                 final PasscodeManager passcodeManager = mgr.getPasscodeManager();
+                 passcodeManager.storeMobilePolicyForOrg(account, id.screenLockTimeout * 1000 * 60, id.pinLength);
+                 passcodeManager.setTimeoutMs(id.screenLockTimeout * 1000 * 60);
+-                passcodeManager.setMinPasscodeLength(id.pinLength);
++                boolean changeRequired = passcodeManager.setMinPasscodeLength((Activity) getContext(), id.pinLength);
+ 
+                 /*
+                  * Checks if a passcode already exists. If a passcode has NOT","We need to pass in the Activity context here, so that LoginActivity is used, and so that LoginActivity can get onActivityResult from the PasscodeActivity. Without this, the application context is used, and we don't get a callback when the passcode is done.",Why do we need this change?
+4280,"@@ -39,4 +39,10 @@ class Tracepoint < ActiveRecord::Base
+     el1 << (XML::Node.new(""time"") << timestamp.xmlschema) if print_timestamp
+     el1
+   end
++
++  # Return points of trackable traces in original order
++  scope :trackable_ordered, -> { joins(:trace).where(:gpx_files => { :visibility => %w[trackable identifiable] }).order(""gpx_id DESC, trackid ASC, timestamp ASC"") }
++
++  # Hide the order of points of non-trackable traces for privacy
++  scope :non_trackable_unordered, -> { joins(:trace).where(:gpx_files => { :visibility => %w[public private] }).order(""gps_points.latitude"", ""gps_points.longitude"") }
+ end","Can you move these to the top please, for consistency with other models - normally we put scopes immediately after the associations at the top of the model. As to names I agree with @gravitystorm that these names may be confusing but I'm not sure the ones I suggested are perfect either so I'm not really sure what's best. The goal of my names was just to separate point which could be ordered (as `ordered`) from those which can't (as `unordered`) but I realise that may not be very clear from the names.",I'm not sure if this is the best way to do this. I think it would be better to use `where(:gpx_files => { :visibility => %w[public private] })` instead.
+4281,"@@ -1117,7 +1117,10 @@ public class PlaybackService extends MediaBrowserServiceCompat {
+                 // only mark the item as played if we're not keeping it anyways
+                 DBWriter.markItemPlayed(item, FeedItem.PLAYED, ended);
+                 // don't know if it actually matters to not autodownload when smart mark as played is triggered
+-                DBWriter.removeQueueItem(PlaybackService.this, ended, item);
++                boolean shouldRepeat = UserPreferences.getShouldRepeatEpisode();
++                if (!shouldRepeat) {
++                    DBWriter.removeQueueItem(PlaybackService.this, ended, item);
++                }
+                 // Delete episode if enabled
+                 FeedPreferences.AutoDeleteAction action =
+                         item.getFeed().getPreferences().getCurrentAutoDelete();",Looks like the episode should also not be deleted when repeating,"I don't think this is the right place to do this. If the user doesn't want to repeat an episode, it should be in the queue."
+4282,"@@ -13,6 +13,7 @@ package proxy
+ 
+ import (
+ 	""crypto/tls""
++	""github.com/mholt/caddy/caddyhttp/httpserver""
+ 	""io""
+ 	""net""
+ 	""net/http""",I feel like goimports would move this import line by the other non-std packages... can you double-check that? Run goimports or set up your editor to run it on save. :+1:,I think this should be `caddyhttp`
+4283,"@@ -60,6 +60,19 @@ module Selenium
+ 
+         class << self
+           def chrome(opts = {})
++            define_method(:options) { @capabilities[:chrome_options] ||= {} }
++            define_method(""options="") { |value| @capabilities[:chrome_options] = value }
++            define_method(""profile="") do |profile|
++              profile_json = profile.as_json
++              options['args'] ||= []
++              if options['args'].none? { |arg| arg =~ /user-data-dir/ }
++                options['args'] << ""--user-data-dir=#{profile_json[:directory]}""
++              end
++              options['extensions'] = profile_json[:extensions]
++            end
++            alias_method :chrome_options, :options
++            alias_method :chrome_options=, :options=
++
+             new({
+               browser_name: 'chrome',
+               javascript_enabled: true,",`options['binary'] = WebDriver::Chrome.path` if set?,"I'm not sure if this is the best way to do this, but I'm not sure how to do it."
+4284,"@@ -134,6 +134,9 @@ var (
+ 		DB: DB{
+ 			UseBadgerDB: false,
+ 			NumRetries:  3,
++			SQLITE3: SQLITE3{
++				SQLite3File:	""./explorer.db"",
++			},
+ 		},
+ 	}
+ ",File is not `goimports`-ed (from `goimports`),Why is this needed?
+4285,"@@ -19,13 +19,18 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     /// </summary>
+     public class ListenOptions : IEndPointInformation, IConnectionBuilder
+     {
++        internal const string Http2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experimental.Http2"";
++
+         private FileHandleType _handleType;
++        private HttpProtocols _protocols = HttpProtocols.Http1;
++        internal bool _isHttp2Supported;
+         private readonly List<Func<ConnectionDelegate, ConnectionDelegate>> _components = new List<Func<ConnectionDelegate, ConnectionDelegate>>();
+ 
+         internal ListenOptions(IPEndPoint endPoint)
+         {
+             Type = ListenType.IPEndPoint;
+             IPEndPoint = endPoint;
++            AppContext.TryGetSwitch(Http2ExperimentSwitch, out _isHttp2Supported);
+         }
+ 
+         internal ListenOptions(string socketPath)",Nit: Supported -> Enabled.,Should this be `Htt
+4286,"@@ -128,7 +128,7 @@ class ImportTest(QuiltTestCase):
+ 
+         # Modify an existing dataframe
+         csv = package1.dataframes2.csv._data()
+-        csv.set_value(0, 'Int0', 42)
++        csv.at[0, 'Int0'] = 42
+ 
+         # Add a new dataframe
+         df = pd.DataFrame(dict(a=[1, 2, 3]))",Yay! I was too lazy to fix this.,This should be `csv
+4287,"@@ -28,8 +28,7 @@ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/versioned""
+ 	""github.com/openebs/maya/pkg/debug""
+-	merrors ""github.com/openebs/maya/pkg/errors/v1alpha1""
+-	pkg_errors ""github.com/pkg/errors""
++	errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""",other declaration of errors (from `typecheck`),Why did you remove 
+4288,"@@ -13,12 +13,15 @@ import (
+ )
+ 
+ var (
+-	errValueEmpty      = errors.New(""value must not be empty"")
+-	errValueTooLong    = errors.New(""value must not exceed 255 characters"")
+-	errValueBadFormat  = errors.New(""value must start with a letter and contain only lower-case letters, numbers, and hyphens"")
+-	errValueNotAString = errors.New(""value must be a string"")
++	errValueEmpty        = errors.New(""value must not be empty"")
++	errValueTooLong      = errors.New(""value must not exceed 255 characters"")
++	errValueBadFormat    = errors.New(""value must start with a letter and contain only lower-case letters, numbers, and hyphens"")
++	errValueNotAString   = errors.New(""value must be a string"")
++	errInvalidGitHubRepo = errors.New(""Please enter a valid GitHub repository, e.g. https://github.com/myCompany/myRepo"")
+ )
+ 
++var githubRepoExp = regexp.MustCompile(`https:\/\/github\.com\/(?P<owner>.+)\/(?P<repo>.+)`)
++
+ func validateProjectName(val interface{}) error {
+ 	if err := basicNameValidation(val); err != nil {
+ 		return fmt.Errorf(""project name %v is invalid: %w"", val, err)",nit: error starts with capital letter,I think this should be `githubRepoExp = regexp.MustCompile(`github\.com\/(?P<owner>.+)/(?P<repo>.+)`)
+4289,"@@ -1616,16 +1616,7 @@ public class ImapStore extends Store {
+                 ImapList flags = fetchList.getKeyedList(""FLAGS"");
+                 if (flags != null) {
+                     for (int i = 0, count = flags.size(); i < count; i++) {
+-                        String flag = flags.getString(i);
+-                        if (flag.equalsIgnoreCase(""\\Deleted"")) {
+-                            message.setFlagInternal(Flag.DELETED, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Answered"")) {
+-                            message.setFlagInternal(Flag.ANSWERED, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Seen"")) {
+-                            message.setFlagInternal(Flag.SEEN, true);
+-                        } else if (flag.equalsIgnoreCase(""\\Flagged"")) {
+-                            message.setFlagInternal(Flag.FLAGGED, true);
+-                        }
++                        message.setFlagInternal(Flag.valueOfByRealName(flags.getString(i)), true);
+                     }
+                 }
+             }","the original code ignores \Draft and \Recent, whereas your change will not. what this matters, i'm not sure.",I don't think this is the right way to do this. I think it would be better to use `Flag.valueOfByReal
+4290,"@@ -381,6 +381,8 @@ func TestQuotaReclamationDeletedBlocks(t *testing.T) {
+ 	}
+ 
+ 	// Stall the puts that comes as part of the sync call.
++	oldBServer := config2.BlockServer()
++	defer config2.SetBlockServer(oldBServer)
+ 	onWriteStalledCh, writeUnstallCh, ctxStall := StallBlockOp(
+ 		ctx, config2, StallableBlockPut)
+ ",Why was this necessary?,Why do we need this?
+4291,"@@ -111,6 +111,7 @@ var opts struct {
+ 	Test struct {
+ 		FailingTestsOk  bool         `long:""failing_tests_ok"" hidden:""true"" description:""Exit with status 0 even if tests fail (nonzero only if catastrophe happens)""`
+ 		NumRuns         int          `long:""num_runs"" short:""n"" default:""1"" description:""Number of times to run each test target.""`
++		Rerun           bool         `long:""rerun"" description:""To force rerunning tests for a target""`
+ 		Sequentially    bool         `long:""sequentially"" description:""Whether to run multiple runs of the same test sequentially""`
+ 		TestResultsFile cli.Filepath `long:""test_results_file"" default:""plz-out/log/test_results.xml"" description:""File to write combined test results to.""`
+ 		SurefireDir     cli.Filepath `long:""surefire_dir"" default:""plz-out/surefire-reports"" description:""Directory to copy XML test results to.""`",Can you also do this for Cover?,nit: `to force rerunting tests for a target`
+4292,"@@ -4978,6 +4978,16 @@ bool CoreChecks::ValidateImageSubresourceRange(const uint32_t image_mip_count, c
+         }
+     }
+ 
++    if (subresourceRange.aspectMask & VK_IMAGE_ASPECT_COLOR_BIT) {
++        if (subresourceRange.aspectMask &
++            (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT)) {
++            skip |= LogError(image, ""VUID-VkImageSubresourceRange-aspectMask-01670"",
++                             ""%s: aspectMask includes both VK_IMAGE_ASPECT_COLOR_BIT and one of VK_IMAGE_ASPECT_PLANE_0_BIT, ""
++                             ""VK_IMAGE_ASPECT_PLANE_1_BIT, or VK_IMAGE_ASPECT_PLANE_2_BIT."",
++                             cmd_name);
++        }
++    }
++
+     return skip;
+ }
+ ","So I tried adding this VU a long time ago, thought it would be this simple of a check, but turns out there were other validation in the way for getting here in `ValidateImageAspectMask` I assume that is what is failing CI here, realized it would require some more refactoring",I think it would be better to use `LogWarning` instead of `LogError` here.
+4293,"@@ -0,0 +1,6 @@
++class Arel::Table
++  def coalesce_and_sum(column, value)
++    coalesce_result = Arel::Nodes::NamedFunction.new('COALESCE', [self[column], value])
++    Arel::Nodes::NamedFunction.new('SUM', [coalesce_result], column.to_s)
++  end
++end","This method is not needed for postgresql, by default sum function omits null values so we can remove this file",This should be `coalesce_and_sum`.
+4294,"@@ -378,7 +378,10 @@ dnl We have separate checks for libsystemd and the unit dir for historical reaso
+ PKG_CHECK_MODULES([LIBSYSTEMD], [libsystemd], [have_libsystemd=yes], [have_libsystemd=no])
+ AM_CONDITIONAL(BUILDOPT_LIBSYSTEMD, test x$have_libsystemd = xyes)
+ AM_COND_IF(BUILDOPT_LIBSYSTEMD,
+-           AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd]))
++           AC_DEFINE([HAVE_LIBSYSTEMD], 1, [Define if we have libsystemd])
++           systemdsystemgeneratordir=$($PKG_CONFIG --variable=systemdsystemgeneratordir systemd)
++           AC_SUBST(systemdsystemgeneratordir)
++           )
+ 
+ AS_IF([test ""x$have_libsystemd"" = ""xyes""], [
+   with_systemd=yes",Can you provide a `--with-systemdsystemgeneratordir` option here? So that I can do unprivileged installs without completely turning off systemd. I can add it as a follow-up PR too.,Why is this needed?
+4295,"@@ -396,11 +396,10 @@ class CLAModel(Model):
+       inferences = self._multiStepCompute(rawInput=inputRecord)
+     # For temporal classification. Not used, and might not work anymore
+     elif self._isClassificationModel():
+-      inferences = self._classificationCompute()
+-
+-    results.inferences.update(inferences)
+-
+-    inferences = self._anomalyCompute()
++      inferences = self._classifcationCompute()
++    else:
++      inferences = self._anomalyCompute()
++    
+     results.inferences.update(inferences)
+ 
+     # -----------------------------------------------------------------------",`classification` is misspelled,I don't think this is the right place to put this logic. It should be in t
+4296,"@@ -152,7 +152,7 @@ public class SampleTransformer {
+     // to
+     // use is the first one on the list, since we set it in the overload of generateSamples.
+     if (methodSampleViews.size() > 0) {
+-      methodViewBuilder.initCode(methodSampleViews.get(0).initCode());
++      methodViewBuilder.initCode(methodSampleViews.get(0).methodInitCode());
+ 
+       // Don't emit samples that were specifically generated for backward-compatibility. We only
+       // wanted them for initCode above.",Can you change this to `sampleInitCode`?,Why is this change needed?
+4297,"@@ -823,6 +823,7 @@ public class TiDAGRequest implements Serializable {
+       sb.append("", Limit: "");
+       sb.append(""["").append(limit).append(""]"");
+     }
++    sb.append("", startTs: "").append(startTs.getVersion());
+     return sb.toString();
+   }
+ ",I added a startTs information in `TiDagRequest` output. Not really sure if it is useful? @zhexuany,"sb.append("", startTs: "").a"
+4298,"@@ -27,7 +27,12 @@ function collectResultsFromFrames(
+   frames.forEach(frame => {
+     const tabindex = parseInt(frame.node.getAttribute('tabindex'), 10);
+     const focusable = isNaN(tabindex) || tabindex >= 0;
++
+     const rect = frame.node.getBoundingClientRect();
++    let width = parseInt(frame.node.getAttribute('width'), 10);
++    let height = parseInt(frame.node.getAttribute('height'), 10);
++    width = isNaN(width) ? rect.width : width;
++    height = isNaN(height) ? rect.height : height;
+ 
+     var params = {
+       options: options,",This prevents margin/border/padding CSS from affecting the width/height (otherwise in Chrome a width and height of 1 would result in a rect size of 5x5).,Why do we need to do this?
+4299,"@@ -22,10 +22,11 @@ class PublicPagesController < ApplicationController
+     @template = Template.live(params[:id])
+     # covers authorization for this action.
+     # Pundit dosent support passing objects into scoped policies
++    skip_authorization
+     unless PublicPagePolicy.new(@template).template_export?
+-      raise Pundit::NotAuthorizedError
++      redirect_to public_templates_path, notice: ""You are not authorized to export that template"" and return
++      #raise Pundit::NotAuthorizedError
+     end
+-    skip_authorization
+     # now with prefetching (if guidance is added, prefetch annottaions/guidance)
+     @template = Template.includes(
+       :org,",prefer to just add this to the `verify_authorized` exception list above since we're already making exceptions.,Missing space after #.
+4300,"@@ -139,10 +139,17 @@ class Populator
+ 
+         $dependent_classlikes[$fq_classlike_name_lc] = true;
+ 
+-        $this->populateDataFromTraits($storage, $storage_provider, $dependent_classlikes);
++        foreach ($storage->used_traits as $used_trait_lc => $_) {
++            $this->populateDataFromTrait($storage, $storage_provider, $dependent_classlikes, $used_trait_lc);
++        }
+ 
+         if ($storage->parent_classes) {
+-            $this->populateDataFromParentClass($storage, $storage_provider, $dependent_classlikes);
++            $this->populateDataFromParentClass(
++                $storage,
++                $storage_provider,
++                $dependent_classlikes,
++                reset($storage->parent_classes)
++            );
+         }
+ 
+         if (!strpos($fq_classlike_name_lc, '\\')",was there a reason to not loop over parent classes here?,Why do we need to reset here?
+4301,"@@ -1,6 +1,8 @@
+-import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
+ import Ember from 'ember';
++import AuthenticatedRouteMixin from 'ember-simple-auth/mixins/authenticated-route-mixin';
+ import UserSession from 'hospitalrun/mixins/user-session';
++
++const { computed } = Ember;
+ /**
+  * Abstract route for top level modules (eg patients, inventory, users)
+  */",@billybonks Why move `import Ember from 'ember';` to the top?,Why is this needed?
+4302,"@@ -1,7 +1,16 @@
+ class Approval < ActiveRecord::Base
+-  include ThreeStateWorkflow
+-
+-  workflow_column :status
++  include WorkflowModel
++  workflow do
++    state :pending do
++      event :make_actionable, transitions_to: :actionable
++    end
++    state :actionable do
++      event :approve, transitions_to: :approved
++      event :reject, transitions_to: :rejected
++    end
++    state :approved
++    state :rejected
++  end
+ 
+   belongs_to :proposal
+   has_one :cart, through: :proposal",Everything's so simple (a `ThreeStateWorkflow`) until it isn't :smirk:,Use 2 (not 3) spaces for inde
+4303,"@@ -57,8 +57,9 @@ class OperationTests(ComparisonTestCase):
+     def test_image_contours(self):
+         img = Image(np.array([[0, 1, 0], [3, 4, 5.], [6, 7, 8]]))
+         op_contours = contours(img, levels=[0.5])
+-        contour = Contours([[(-0.5,  0.416667, 0.5), (-0.25, 0.5, 0.5)],
+-                             [(0.25, 0.5, 0.5), (0.5, 0.45, 0.5)]],
++        contour = Contours([[(-0.5,  0.416667, 0.5), (-0.25, 0.5, 0.5),
++                             (np.NaN, np.NaN, 0.5), (0.25, 0.5, 0.5),
++                             (0.5, 0.45, 0.5)]],
+                             vdims=img.vdims)
+         self.assertEqual(op_contours, contour)
+ ",I don't quite understand where the NaNs come from...,Why is this necessary?
+4304,"@@ -45,8 +45,8 @@ func LoadTestConfig(addr string, allowMultiConnsPerHost bool) *config.Network {
+ 	config := config.Config{
+ 		NodeType: config.DelegateType,
+ 		Network: config.Network{
+-			Host:                    host,
+-			Port:                    port,
++			Host: host,
++			Port: port,
+ 			MsgLogsCleaningInterval: 2 * time.Second,
+ 			MsgLogRetention:         10 * time.Second,
+ 			HealthCheckInterval:     time.Second,",File is not `goimports`-ed,Why did you change this?
+4305,"@@ -354,6 +354,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Go.PleaseGoTool = ""//_please:please_go""
+ 	config.Go.EmbedTool = ""//_please:please_go_embed""
+ 	config.Python.PexTool = ""//_please:please_pex""
++	config.Python.WheelResolverTool = ""//_please:wheel_resolver""
+ 	config.Java.JavacWorker = ""//_please:javac_worker""
+ 	config.Java.JarCatTool = ""//_please:jarcat""
+ 	config.Java.JUnitRunner = ""//_please:junit_runner""",I wonder if we should look at moving the Python stuff to a plugin and doing this there rather than adding to core plz at this point?,I think this should be `
+4306,"@@ -44,8 +44,7 @@ class Syntax(base.BaseCommand):
+         ansible = ansible_playbook.AnsiblePlaybook(self.molecule.config.config[
+             'ansible'])
+         ansible.add_cli_arg('syntax-check', True)
+-        ansible.add_cli_arg('inventory-file', 'localhost,')
+-
++        ansible.add_cli_arg('inventory_file', 'localhost,')
+         utilities.print_info(""Checking playbooks syntax ..."")
+ 
+         return ansible.execute(hide_errors=True)",This is the actual bug fix. I prob should have broken this out into two PRs.,This should be `ansible.
+4307,"@@ -235,6 +235,16 @@ namespace Nethermind.Core.Specs
+         /// </summary>
+         bool IsEip3198Enabled { get; }
+         
++        /// <summary>
++        /// Difficulty Bomb Delay to Q2/2022
++        /// </summary>
++        bool IsEip3238Enabled { get; }
++        
++        /// <summary>
++        /// Reduction in refunds
++        /// </summary>
++        bool IsEip3529Enabled { get; }
++        
+         /// <summary>
+         /// Should transactions be validated against chainId.
+         /// </summary>","I am not sure if we need this, we already have DifficultyBombDelays",I think this should be `
+4308,"@@ -389,6 +389,9 @@ namespace Nethermind.Blockchain.Synchronization
+                             }
+                         }
+                     }
++
++                    delaySource.Dispose();
++                    linkedSource.Dispose();
+                 }, token);
+         }
+ ","move to finally - I can see at least one return that would omit it, also any exception and so on",Why do we need to dispose these?
+4309,"@@ -122,7 +122,9 @@ func NewProtocol(
+ 	if cfg.Consensus.Scheme != config.RollDPoSScheme {
+ 		return nil, nil
+ 	}
+-	if !genesisConfig.EnableGravityChainVoting || electionCommittee == nil || genesisConfig.GravityChainStartHeight == 0 {
++
++	if !genesisConfig.EnableGravityChainVoting || genesisConfig.GravityChainStartHeight == 0 ||
++		(electionCommittee == nil && stakingV2 == nil) {
+ 		delegates := genesisConfig.Delegates
+ 		if uint64(len(delegates)) < genesisConfig.NumDelegates {
+ 			return nil, errors.New(""invalid delegate address in genesis block"")",remove `genesisConfig.GravityChainStartHeight == 0`,why do we need this check?
+4310,"@@ -4,6 +4,10 @@ declare(strict_types=1);
+ 
+ use Doctrine\Common\Annotations\AnnotationRegistry;
+ 
++$symfonyDumpFunctionPath = 'vendor/symfony/var-dumper/Resources/functions/dump.php';
++
++file_exists(__DIR__ . '/../' . $symfonyDumpFunctionPath) ? require_once __DIR__ . '/../' . $symfonyDumpFunctionPath : require_once __DIR__ . '/../../' . $symfonyDumpFunctionPath;
++
+ /* @var \Composer\Autoload\ClassLoader $loader */
+ $loader = file_exists(__DIR__ . '/../vendor/autoload.php') ? require __DIR__ . '/../vendor/autoload.php' : require __DIR__ . '/../../vendor/autoload.php';
+ ",this might kill whole application if `var-dumper` will not be installed. What about two separate file_exists conditions (monorepo/project)?,Why do you need this line?
+4311,"@@ -163,6 +163,11 @@ var ConfigCommand *cobra.Command = &cobra.Command{
+ 			util.Failed(""Could not write ddev config file: %v"", err)
+ 		}
+ 
++		_, err = app.CreateSettingsFile()
++		if err != nil {
++			util.Failed(""Could not write settings file: %w"", err)
++		}
++
+ 		// If a provider is specified, prompt about whether to do an import after config.
+ 		switch provider {
+ 		case ddevapp.DefaultProviderName:",Hrm. Maybe this isn't the correct spot to run this? Because it errors if the app type doesn't support settings. But we want to check that before running it.,I think this should be `fmt.Erro
+4312,"@@ -1359,7 +1359,7 @@ def get_terminal_width():
+         else:
+             return None
+ 
+-def pretty_routes(rtlst, header, sortBy=0):
++def pretty_list(rtlst, header, sortBy=0):
+     """"""Pretty route list, and add header""""""
+     _l_header = len(header[0])
+     _space = ""  """,Why are you changing this name ?,Why did you change this?
+4313,"@@ -579,6 +579,12 @@ def in_docker():
+     """"""
+     if OVERRIDE_IN_DOCKER:
+         return True
++
++    # check things from Dockerfile
++    # TODO: is it enough? can we remove all the checks bellow?
++    if __file__.startswith(""/opt/code/localstack/"") and os.environ.get(""USER"") == ""localstack"":
++        return True
++
+     if os.path.exists(""/.dockerenv""):
+         return True
+     if not os.path.exists(""/proc/1/cgroup""):","as we discussed, maybe it would be better to - [ ] set OVERRIDE_IN_DOCKER=1 in the Dockerfile - [ ] replace the if statement with `os.path.exists(""/run/.containerenv"")` as @dfangl suggested",I don't think this is th
+4314,"@@ -455,6 +455,11 @@ def is_ancestor_name(
+     return False
+ 
+ 
++def is_being_called(node: astroid.node_classes.NodeNG) -> bool:
++    """"""return True if node is the function being called in a Call node""""""
++    return isinstance(node.parent, astroid.Call) and node.parent.func is node
++
++
+ def assign_parent(node: astroid.node_classes.NodeNG) -> astroid.node_classes.NodeNG:
+     """"""return the higher parent which is not an AssignName, Tuple or List node""""""
+     while node and isinstance(node, (astroid.AssignName, astroid.Tuple, astroid.List)):",I like this style of doing things better than having super big conditional without explanation. Even though I know this won't be re-used it's nice to have a function if only for clarity.,why not just `isinstance
+4315,"@@ -22,7 +22,10 @@ module RSpec
+         end
+ 
+         def example_group_finished(_notification)
+-          @group_level -= 1
++          if @group_level > 0
++            @group_level -= 1
++          end
++          @group_level
+         end
+ 
+         def example_passed(passed)",Our preference here is to either have inline statements e.g. `@group_level -= 1 if @group_level > 0` but stylistically here I think `return @group_level if @group_level == 0` might be nicer. As it stands however our rubocop is picking this up as a fail :(,why not just `@group_lev
+4316,"@@ -20,6 +20,16 @@
+ package org.apache.iceberg.spark.actions;
+ 
+ import org.apache.iceberg.actions.TestRemoveOrphanFilesAction;
++import org.junit.Ignore;
+ 
+ public class TestRemoveOrphanFilesAction3 extends TestRemoveOrphanFilesAction {
++
++  /**
++  * Todo: Its failing for Spark3, so has to fix it in the parent class.
++  * Ignoring for now, as still Spark3 is not supported.
++  *
++  */
++  @Ignore
++  public void testOlderThanTimestampWithPartitionWithWhitSpace() {
++  }
+ }","Spark3 Is supported in OSS Iceberg, Do you mean this particular function is not supported in Spark3? If so I think we should have a more clear reason why",Why is this ignored?
+4317,"@@ -399,3 +399,11 @@ def get_partition_set_execution_param_data(recon_repo, partition_set_name, parti
+         return ExternalPartitionExecutionErrorData(
+             serializable_error_info_from_exc_info(sys.exc_info())
+         )
++
++
++def get_notebook_data(notebook_path):
++    check.str_param(notebook_path, ""notebook_path"")
++
++    with open(os.path.abspath(notebook_path), ""rb"") as f:
++        content = f.read()
++        return content","something about the arbitrary file access part here makes me nervous. Can we keep the `if not path.endswith("".ipynb"")` check from before here as well? Just imagining a weird attack scenario where somebody somehow uses this to get access to confidental files or something",Why do we need this 
+4318,"@@ -51,6 +51,14 @@ module Blacklight
+       deprecation_deprecate :solr_search_params_logic=
+     end
+ 
++    def search_builder_class
++      Blacklight::Solr::SearchBuilder
++    end
++
++    def search_builder processor_chain = search_params_logic
++      search_builder_class.new(processor_chain, self)
++    end
++
+ 
+     # @returns a params hash for searching solr.
+     # The CatalogController #index action uses this.",I wonder if we should push this and the search_params_logic into the blacklight config.,Why do we need to de
+4319,"@@ -38,6 +38,7 @@ func TestClient(t *testing.T) {
+ 	cfg := config.Default
+ 	cfg.API.Port = testutil.RandomPort()
+ 	ctx := context.Background()
++	cfg.Genesis.KamchatkaBlockHeight = 10
+ 
+ 	mockCtrl := gomock.NewController(t)
+ 	defer mockCtrl.Finish()","don't need this line, since it is not tested here?",Why is this needed?
+4320,"@@ -197,6 +197,7 @@ class EmrConnection(AWSQueryConnection):
+                     steps=[],
+                     bootstrap_actions=[],
+                     instance_groups=None,
++                    ami_version=""1.0"",
+                     additional_info=None):
+         """"""
+         Runs a job flow",I wonder if adding this new param in the middle of the param list might screw up some existing code that is depending on the old parameter order. Might be better to add it to the end of the parameter list?,"This should be `None`, right?"
+4321,"@@ -178,7 +178,8 @@ public final class BaselineErrorProne implements Plugin<Project> {
+ 
+         errorProneOptions.setEnabled(true);
+         errorProneOptions.setDisableWarningsInGeneratedCode(true);
+-        errorProneOptions.setExcludedPaths(project.getBuildDir().getAbsolutePath() + ""/.*"");
++        errorProneOptions.setExcludedPaths(
++                String.format(""%s/(build|src/generated.*)/.*"", project.getProjectDir().getAbsolutePath()));
+         errorProneOptions.check(""EqualsHashCode"", CheckSeverity.ERROR);
+         errorProneOptions.check(""EqualsIncompatibleType"", CheckSeverity.ERROR);
+         errorProneOptions.check(""StreamResourceLeak"", CheckSeverity.ERROR);",I wonder if this absolute path is gonna affect the build-cache relocatability of these compile tasks??,Why is this change needed?
+4322,"@@ -18,10 +18,13 @@ class CommandOperationV2 extends OperationBase {
+     this.readPreference = ReadPreference.resolve(parent, this.options);
+     this.readConcern = resolveReadConcern(parent, this.options);
+     this.writeConcern = resolveWriteConcern(parent, this.options);
++    this.session = options && options.session;
++    this.inTransaction = this.session && this.session.inTransaction();
++    if (this.inTransaction) this.writeConcern = undefined;
+     this.explain = false;
+ 
+     if (operationOptions && typeof operationOptions.fullResponse === 'boolean') {
+-      this.fullResponse = true;
++      this.fullResponse = operationOptions.fullResponse;
+     }
+ 
+     // TODO: A lot of our code depends on having the read preference in the options. This should",possible bug if `fullResponse` is false,Shouldn't this be `this.write
+4323,"@@ -19,9 +19,11 @@
+ 
+ """"""A HintManager to draw hints over links.""""""
+ 
+-import math
+-import functools
+ import collections
++import functools
++import math
++import re
++from string import ascii_lowercase
+ 
+ from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QEvent, Qt, QUrl,
+                           QTimer)",nitpick: Please only `import string` here and use `string.ascii_lowercase` - I really like to see what module stuff is coming from without looking at the imports.,Why do we need this?
+4324,"@@ -2822,10 +2822,10 @@ exports.shouldCorrectlyLogoutFromTheDatabaseWithPromises = {
+ 
+               db.close();
+               test.done();
+-            }).catch(function(err) {  })
+-          }).catch(function(err) {  })
+-        }).catch(function(err) {  })
+-      }).catch(function(err) {  })
++            }).catch(function(err) {  console.dir(err )})
++          }).catch(function(err) {  console.dir(err )})
++        }).catch(function(err) {  console.dir(err )})
++      }).catch(function(err) {  console.dir(err )})
+     });
+     // END
+   }",nitpick: the only reason we have a catch for every one of these promises is because the test isn't properly chaining promises (returning them within each `then`). We could reduce the `catch` with `console.dir` to a single instance if that was done,I don't think this is the right way to do it. I think it would be better to use `.catch(function(err) { console.dir(err) })`
+4325,"@@ -85,6 +85,8 @@ TEST(NebulaCodec, encode) {
+     // check empty values
+     std::vector<boost::any> emptyV;
+     std::string emptyEncoded = codec.encode(emptyV);
++
++
+     SchemaWriter emptyWriter;
+     auto emptySchema = std::make_shared<ResultSchemaProvider>(emptyWriter.moveSchema());
+     auto emptyReader = RowReader::getRowReader(emptyEncoded, emptySchema);",why do this?,Why this change?
+4326,"@@ -17,7 +17,7 @@ class MediaLibrary extends SystemMediaLibrary
+      */
+     protected function init()
+     {
+-        traceLog('Class Cms\Classes\MediaLibrary has been deprecated, use System\Classes\MediaLibrary instead.');
++        traceLog('Class Cms\Classes\MediaLibrary has been deprecated, use ' . SystemMediaLibrary::class . ' instead.');
+         parent::init();
+     }
+ }","For consistency, would it not be best to also replace the first class name? `traceLog('Class ' . static::class . ' has been deprecated, use ' . SystemMediaLibrary::class . ' instead.')`",Please use `::class` instead.
+4327,"@@ -123,6 +123,9 @@ type PrometheusSpec struct {
+ 	// The labels to add to any time series or alerts when communicating with
+ 	// external systems (federation, remote storage, Alertmanager).
+ 	ExternalLabels map[string]string `json:""externalLabels,omitempty""`
++	// Enable access to prometheus web admin API. Defaults to the value of `true`.
++	// For more information see https://prometheus.io/docs/prometheus/latest/querying/api/#tsdb-admin-apis
++	EnableAdminApi string `json:""enableAdminApi,omitempty""`
+ 	// The external URL the Prometheus instances will be available under. This is
+ 	// necessary to generate correct URLs. This is necessary if Prometheus is not
+ 	// served from root of a DNS name.",this should be `EnabledAdminAPI` and the json string should then be `enableAdminAPI`,Can we make this a `bool`?
+4328,"@@ -4,6 +4,8 @@ from listenbrainz import webserver
+ from werkzeug.serving import run_simple
+ import os
+ import click
++import sqlalchemy
++from time import sleep
+ 
+ from listenbrainz.utils import safely_import_config
+ safely_import_config()",Noticed some missing imports in manage.py so thought I'd add them,F401 'time.sleep' imported but unused
+4329,"@@ -301,15 +301,10 @@ func (exp *flowExporter) sendFlowRecords() error {
+ 			exp.numDataSetsSent = exp.numDataSetsSent + 1
+ 
+ 			if flowexporter.IsConnectionDying(&record.Conn) {
+-				// If the connection is in dying state or connection is not in conntrack table,
+-				// we will delete the flow records from records map.
+-				klog.V(2).Infof(""Deleting the inactive flow records with key: %v from record map"", key)
+-				if err := exp.flowRecords.DeleteFlowRecordWithoutLock(key); err != nil {
+-					return err
+-				}
+-				if err := exp.conntrackConnStore.SetExportDone(key); err != nil {
+-					return err
+-				}
++				// If the connection is in dying state or connection is not in conntrack
++				// table, we set the DyingAndDoneExport flag to do the deletion later.
++				record.DyingAndDoneExport = true
++				exp.flowRecords.AddFlowRecordWithoutLock(&key, &record)
+ 			} else {
+ 				exp.flowRecords.ValidateAndUpdateStats(key, record)
+ 			}","as a future improvement, maybe we should just change `ForAllFlowRecordsDo` so that `updateOrSendFlowRecord` uses a flow record pointer instead of a copy of stored flow record. This whole code is executed with the lock any way.",Why do we need to set this flag?
+4330,"@@ -37,6 +37,7 @@ import java.util.function.Consumer;
+  * A literal string.
+  * <br/><code>""Hello World!""</code>
+  * <br/><code>""\""\n""</code>
++ * <br/><code>""\u2122""</code>
+  * <br/><code>""™""</code>
+  * <br/><code>""💩""</code>
+  *",I am not sure what GitHub wants to tell me with this icon here :),Why is this needed?
+4331,"@@ -385,8 +385,8 @@ BOOST_AUTO_TEST_CASE(valid_nearest_urls)
+ 
+ BOOST_AUTO_TEST_CASE(valid_tile_urls)
+ {
+-    TileParameters reference_1{1, 2, 3};
+-    auto result_1 = parseParameters<TileParameters>(""tile(1,2,3).mvt"");
++    TileParameters reference_1{1, 2, 12};
++    auto result_1 = parseParameters<TileParameters>(""tile(1,2,12).mvt"");
+     BOOST_CHECK(result_1);
+     BOOST_CHECK_EQUAL(reference_1.x, result_1->x);
+     BOOST_CHECK_EQUAL(reference_1.y, result_1->y);",can we also check for smaller zoom levels returning valid error codes?,Why did you change this?
+4332,"@@ -15,6 +15,16 @@ namespace ScenarioMeasurement
+             Console.WriteLine(message);
+         }
+ 
++        public void LogHeader1(string message)
++        {
++            Console.WriteLine($""=============== {message} ================ "");
++        }
++
++        public void LogHeader2(string message)
++        {
++            Console.WriteLine($""***{message}***"");
++        }
++
+         public void LogVerbose(string message)
+         {
+             Console.WriteLine(message);","1) These names are not great, doesn't help explain what they do. 2) Instead of methods like this that hard code some number of = and *, why not a method that takes the string, defaults to a char to surround with, and a width? 3) Do we really even need headers like this in the output? Maybe we ditch them.",Why is this needed?
+4333,"@@ -2943,7 +2943,7 @@ describe('AutocompleteEditor', () => {
+ 
+       keyDownUp('arrow_up');
+ 
+-      expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[0, 0, 0, 0]]);
++      expect(hot.getActiveEditor().htEditor.getSelected()).toEqual([[11, 0, 11, 0]]);
+       done();
+     }, 200);
+   });","The autocomplete editor shouldn't change its own behavior, I assume that `autoWrapCol` and `autoWrapRow` options should be set to `false` in handsontable editor.",Why did this change
+4334,"@@ -266,7 +266,7 @@ func testInstallTunnelFlows(t *testing.T, config *testConfig) {
+ }
+ 
+ func testInstallServiceFlows(t *testing.T, config *testConfig) {
+-	err := c.InstallClusterServiceFlows()
++	err := c.InstallClusterServiceFlows(true, true)
+ 	if err != nil {
+ 		t.Fatalf(""Failed to install Openflow entries to skip service CIDR from egress table: %v"", err)
+ 	}","out of curiosity, with IPv6 introduced, why there's no change to the expected output of openflow in the test?",Why do we need this
+4335,"@@ -67,7 +67,10 @@ byte *
+ decode_eflags_usage(dcontext_t *dcontext, byte *pc, uint *usage,
+                     dr_opnd_query_flags_t flags)
+ {
+-    *usage = 0; /* FIXME i#1569 */
++    /* As long as precise flag information is not provided we conservatively
++     * assume each instructions may read or write all flags.
++    */
++    *usage = EFLAGS_WRITE_ALL | EFLAGS_READ_ALL; /* FIXME i#2263 */
+     return pc + 4;
+ }
+ ",nit: grammar: instruction,(style) code indent
+4336,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+ 
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,import org.springframework.stereotype.Component;
+4337,"@@ -69,7 +69,12 @@ func Add(mgr manager.Manager) error {
+ 
+ // newReconciler returns a new reconcile.Reconciler
+ func newReconciler(mgr manager.Manager) reconcile.Reconciler {
+-	return &ReconcileHiveConfig{Client: mgr.GetClient(), scheme: mgr.GetScheme(), restConfig: mgr.GetConfig(), mgr: mgr}
++	return &ReconcileHiveConfig{
++		Client:     mgr.GetClient(),
++		scheme:     mgr.GetScheme(),
++		restConfig: mgr.GetConfig(),
++		mgr:        mgr,
++	}
+ }
+ 
+ // add adds a new Controller to mgr with r as the reconcile.Reconciler",i think this missed the reconciler to callsite change,Why do we need this change?
+4338,"@@ -990,6 +990,10 @@ public class SurfaceNamer extends NameFormatterDelegator {
+     return getNotImplementedString(""SurfaceNamer.getGrpcClientImportName"");
+   }
+ 
++  public String getClientConfigImportModule(Interface service) {
++    return getNotImplementedString(""SurfaceNamer.getClientConfigImportModule"");
++  }
++
+   /////////////////////////////////// Docs & Annotations //////////////////////////////////////////
+ 
+   /** The documentation name of a parameter for the given lower-case field name. */",Please reuse `getClientConfigPath`.,This should be `getGrpcClientConfigImportModule`
+4339,"@@ -19,7 +19,7 @@ const { eachAsyncSeries, ns } = require('../../../src/utils');
+ 
+ const chai = require('chai');
+ chai.use(require('chai-subset'));
+-chai.use(require('../../functional/spec-runner/matcher').default);
++chai.use(require('../../tools/spec-runner/matcher').default);
+ 
+ const expect = chai.expect;
+ ","Should we use the shared chai-addon.js file here? Actually we should consolidate any `chai.use` calls, I see 20 instances, quick win?",Why is this change needed?
+4340,"@@ -109,7 +109,7 @@ namespace Nethermind.Network.P2P.ProtocolHandlers
+                     HandleHello(Deserialize<HelloMessage>(msg.Data));
+                     
+                     foreach (Capability capability in
+-                        _agreedCapabilities.GroupBy(c => c.ProtocolCode).Select(c => c.OrderBy(v => v.Version).Last()))
++                        _agreedCapabilities.GroupBy(c => c.ProtocolCode).Select(c => c.OrderBy(v => v.Version).Last()).OrderBy(c => c.ProtocolCode))
+                     {
+                         if (Logger.IsTrace) Logger.Trace($""{Session} Starting protocolHandler for {capability.ProtocolCode} v{capability.Version} on {Session.RemotePort}"");
+                         SubprotocolRequested?.Invoke(this, new ProtocolEventArgs(capability.ProtocolCode, capability.Version));",Maybe move _agreedCapabilities and _availableCapabilities from List to SortedSet ? We could order them by code and then by version already.,Why do we need this?
+4341,"@@ -3031,11 +3031,9 @@ func (o *consumer) setInitialPendingAndStart() {
+ 		// Here we are filtered.
+ 		dp := o.cfg.DeliverPolicy
+ 		if dp == DeliverLastPerSubject && o.hasSkipListPending() && o.sseq < o.lss.resume {
+-			if o.lss != nil {
+-				ss := mset.store.FilteredState(o.lss.resume, o.cfg.FilterSubject)
+-				o.sseq = o.lss.seqs[0]
+-				o.sgap = ss.Msgs + uint64(len(o.lss.seqs))
+-			}
++			ss := mset.store.FilteredState(o.lss.resume+1, o.cfg.FilterSubject)
++			o.sseq = o.lss.seqs[0]
++			o.sgap = ss.Msgs + uint64(len(o.lss.seqs))
+ 		} else if ss := mset.store.FilteredState(o.sseq, o.cfg.FilterSubject); ss.Msgs > 0 {
+ 			o.sgap = ss.Msgs
+ 			// See if we should update our starting sequence.","I see the `+1` issue, but we used to check if `o.lss != nil` and we don't anymore, so we are sure that it won't be nil here, right?",Why is this change n
+4342,"@@ -8,6 +8,11 @@
+   <% @documents&.each do |document| %>
+     <h1 class=""modal-title""><%= document_heading(document) %></h1>
+ 
++    <% if document.respond_to?(:export_as_preferred_citation_txt) %>
++      <h2><%= t('blacklight.citation.preferred') %></h2>
++      <%= document.send(:export_as_preferred_citation_txt).html_safe %><br/><br/>
++    <% end %>
++
+     <% if document.respond_to?(:export_as_mla_citation_txt) %>
+       <h2><%= t('blacklight.citation.mla') %></h2>
+       <%= document.send(:export_as_mla_citation_txt).html_safe %><br/><br/>",why is the `send` needed?,I think this should 
+4343,"@@ -106,8 +106,9 @@ def bbox2result(bboxes, labels, num_classes):
+     if bboxes.shape[0] == 0:
+         return [np.zeros((0, 5), dtype=np.float32) for i in range(num_classes)]
+     else:
+-        bboxes = bboxes.cpu().numpy()
+-        labels = labels.cpu().numpy()
++        if isinstance(bboxes, torch.Tensor):
++            bboxes = bboxes.cpu().numpy()
++            labels = labels.cpu().numpy()
+         return [bboxes[labels == i, :] for i in range(num_classes)]
+ 
+ ","Is this necessary? If so, we need to update the docstring.",Why is this needed?
+4344,"@@ -116,8 +116,8 @@ module Ncr
+ 
+     # the highest approver on the stack, pending preferred if status indicates
+     def current_approver_email_address
+-      if self.individual_approvals.pending.first
+-        self.individual_approvals.pending.first.user.email_address
++      if self.pending?
++        self.individual_approvals.where(status: 'actionable').first.user.email_address
+       else
+         self.approving_official.email_address
+       end",Checking for actionable here instead of grabbing the first pending approval. I tested this with proposal ID 265 on staging.,Style/RedundantSelf: Redundant self detected.
+4345,"@@ -100,7 +100,10 @@ class CallbackChecker(QObject):
+         if self._result is self.UNSET:
+             with self._qtbot.waitSignal(self.got_result, timeout=2000):
+                 pass
+-        assert self._result == expected
++        self._assert_result(self._result, expected)
++
++    def _assert_result(self, result, expected):
++        assert result == expected
+ 
+ 
+ @pytest.fixture",I made this change because I wasn't getting printouts of the 'result' value when the assert was inlined for some reason. I think it's related to creating new CallbackCheckers maybe?,Why is this necessary?
+4346,"@@ -0,0 +1,11 @@
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpParser
++    {
++        bool ParseStartLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpStartLineHandler;
++
++        bool ParseHeaders<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpHeadersHandler;
++    }
++}","nit: the correct name is ""request line"", so let's use the right one here :)",Why is this an interface?
+4347,"@@ -8,9 +8,12 @@ import os
+ SQLALCHEMY_DATABASE_URI = os.environ['SQLALCHEMY_DATABASE_URI']
+ 
+ REGISTRY_URL = os.environ['REGISTRY_URL']
+-CATALOG_HOST = os.environ['CATALOG_HOST']
+ 
+-CATALOG_URL = 'https://%s' % CATALOG_HOST
++CATALOG_URL = os.environ.get('CATALOG_URL')
++if not CATALOG_URL.startswith(""https""):
++    print(""WARNING: INSECURE CONNECTION TO CATALOG"")
++    # require verbose environment variable to be defined
++    assert os.environ['ALLOW_INSECURE_CATALOG_ACCESS']
+ 
+ PACKAGE_BUCKET_NAME = os.environ['PACKAGE_BUCKET_NAME']
+ ","This should now use `[]`, so it crashes if the var is missing",Why do we need this?
+4348,"@@ -162,6 +162,19 @@ static CALI_BPF_INLINE int skb_nat_l4_csum_ipv4(struct __sk_buff *skb, size_t of
+ 	return ret;
+ }
+ 
++static CALI_BPF_INLINE int update_state_map(struct cali_tc_state *state)
++{
++	int key = 0;
++	struct cali_tc_state *map_state = cali_v4_state_lookup_elem(&key);
++	if (!map_state) {
++		// Shouldn't be possible; the map is pre-allocated.
++		CALI_INFO(""State map lookup failed: DROP\n"");
++		return -1;
++	}
++	*map_state = *state;
++	return 0;
++}
++
+ static CALI_BPF_INLINE int forward_or_drop(struct __sk_buff *skb,
+ 					   struct cali_tc_state *state,
+ 					   struct fwd *fwd)",you could use `bpf_map_update_elem` with `BPF_EXIST`,Shouldn't this be `CALI_ERROR`?
+4349,"@@ -57,7 +57,7 @@ public class S3OutputFile extends BaseS3File implements OutputFile {
+     try {
+       return new S3OutputStream(client(), uri(), awsProperties());
+     } catch (IOException e) {
+-      throw new UncheckedIOException(""Filed to create output stream for location: "" + uri(), e);
++      throw new UncheckedIOException(""Failed to create output stream for location: "" + uri(), e);
+     }
+   }
+ ",thanks for noticing this! But I think we should not have it in this PR.,"Should this be ""Failed to creat"
+4350,"@@ -414,6 +414,11 @@ Transaction.prototype.lockUntilDate = function(time) {
+   if (_.isDate(time)) {
+     time = time.getTime() / 1000;
+   }
++
++    for (var i = 0; i < this.inputs.length; i++) {
++      this.inputs[i].sequence = Input.DEFAULT_LOCKTIME_SEQNUMBER;
++    }
++
+   this.nLockTime = time;
+   return this;
+ };","A few things: - This may not serialize because I think the property for the sequence number on an input is `.sequenceNumber`. - There should be tests to cover these statements - Indentation is incorrect (should be two spaces, as similar to the statements above)",Why do we need this?
+4351,"@@ -89,3 +89,16 @@ class BaseNotification(object):
+         output_filename = filename_template.format(
+             self.resource, self.cycle_timestamp, output_timestamp)
+         return output_filename
++
++    @classmethod
++    def check_data_format(cls, data_format):
++        """"""Raise `InvalidDataFormatError` unless `data_format` is supported.
++
++        Args:
++            data_format (string): should be either 'csv' or 'json'
++
++        Raises:
++            InvalidDataFormatError: if not valid
++        """"""
++        if data_format not in cls.supported_data_formats:
++            raise InvalidDataFormatError('GCS uploader', data_format)","If this is a base method that could be used by others, should you hardcode 'GCS uploader' here?",I think this should be `Invalid
+4352,"@@ -386,6 +386,18 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+         return result;
+     }
+ 
++    @Override
++    public CharSeq padTo(int length, Character element) {
++        if(length <= back.length()) {
++            return this;
++        }
++        final StringBuilder sb = new StringBuilder(back);
++        for (int i = 0; i < length - back.length(); i++) {
++            sb.append(element);
++        }
++        return new CharSeq(sb.toString());
++    }
++
+     public CharSeq mapChars(CharUnaryOperator mapper) {
+         Objects.requireNonNull(mapper, ""mapper is null"");
+         if (isEmpty()) {",just a little thing: let's introduce a `final int bound = length - back.length();` that saves us calculating the bound each time checking the loop condition.,nit: space after `if`
+4353,"@@ -87,6 +87,16 @@ func (s *server) setupRouting() {
+ 		""GET"": http.HandlerFunc(s.peerBalanceHandler),
+ 	})
+ 
++	router.Handle(""/settlements"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.settlementsHandler),
++	})
++	router.Handle(""/settlements/{peer}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.peerSettlementsHandler),
++	})
++	router.Handle(""/settlements/pay/{peer}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.payPeerHandler),
++	})
++
+ 	baseRouter.Handle(""/"", web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""debug api access""),
+ 		handlers.CompressHandler,","I think that this should be a POST method, as it changes the state. Get requests should not change the state. With different method, I would suggest to have the handler under `""/settlements/{peer}""` path.",This should be `/sett
+4354,"@@ -31,6 +31,7 @@ var errShortRemoteTip = errors.New(""Unexpected remote less than tip"")
+ // L2GasPrice slot refers to the storage slot that the execution price is stored
+ // in the L2 predeploy contract, the GasPriceOracle
+ var l2GasPriceSlot = common.BigToHash(big.NewInt(1))
++var l2GasPriceOracleAddress = common.HexToAddress(""0x420000000000000000000000000000000000000F"")
+ 
+ // SyncService implements the main functionality around pulling in transactions
+ // and executing them. It can be configured to run in both sequencer mode and in",This is the default value?,// l2GasPriceOracleAd
+4355,"@@ -1,8 +1,8 @@
+ import os
+ import codecs
+-
++from time import strftime
+ from cliquet import utils as cliquet_utils
+-
++from kinto import __version__
+ from kinto import logger
+ 
+ HERE = os.path.abspath(os.path.dirname(__file__))","The spaces are actually legitimate here: in python, you: - first import standard library modules (hint: time is one) - then import 3rd party library modules - then import the modules from you project (here kinto). Between each block you need an empty line.",`from kinto import lo
+4356,"@@ -571,7 +571,7 @@ func (pi *PackageInfo) MarkedSource(obj types.Object) *cpb.MarkedSource {
+ // the object has its own non-blank name, that is used; otherwise if the object
+ // is of a named type, that type's name is used. Otherwise the result is ""_"".
+ func objectName(obj types.Object) string {
+-	if name := obj.Name(); name != """" && name != """" {
++	if name := obj.Name(); name != """" {
+ 		return name // the object's given name
+ 	} else if name := typeName(obj.Type()); name != """" {
+ 		return name // the object's type's name","Haha, whoa, I'm not sure how I let that one go by. :)",Why was this removed?
+4357,"@@ -577,6 +577,7 @@ public class DownloadInstanceWriter implements MessageBodyWriter<DownloadInstanc
+         }
+     }
+     
++    // TODO: Return "".md"" for ""text/markdown"" as well as other extensions in MimeTypeDetectionByFileExtension.properties
+     private String getFileExtension(AuxiliaryFile auxFile) {
+         String fileExtension = """";
+         if (auxFile == null) {",FWIW: We have FileUtil.generateOriginalExtension for tabular files but it uses a hardcoded list rather than the properties file.,Is this TODO still re
+4358,"@@ -297,6 +297,9 @@ func StartDataplaneDriver(configParams *config.Config,
+ 				InterfaceName:       configParams.WireguardInterfaceName,
+ 				MTU:                 configParams.WireguardMTU,
+ 				RouteSource:         configParams.RouteSource,
++				// currently, AKS *must* encrypt hostnetwork traffic, while it is optional on EKS
++				HostEncryptionEnabled: configParams.KubernetesProvider() == config.ProviderAKS ||
++					(configParams.WireguardHostEncryptionEnabled && configParams.KubernetesProvider() == config.ProviderEKS),
+ 			},
+ 			IPIPMTU:                        configParams.IpInIpMtu,
+ 			VXLANMTU:                       configParams.VXLANMTU,","I would consider extracting this logic in to a helper function to make it a bit more readable, but that's just my opinion.",I don't think we need
+4359,"@@ -252,6 +252,7 @@ type Config struct {
+ 	DebugSimulateCalcGraphHangAfter time.Duration `config:""seconds;0""`
+ 	DebugSimulateDataplaneHangAfter time.Duration `config:""seconds;0""`
+ 	DebugPanicAfter                 time.Duration `config:""seconds;0""`
++	DebugSimulateDataRace           bool          `config:""bool;false""`
+ 
+ 	// Configure where Felix gets its routing information.
+ 	// - workloadIPs: use workload endpoints to construct routes.","Are all fields beginning with ""Debug"" automatically `;local` ? (I guess so, but just checking.)",Why do we need this?
+4360,"@@ -54,6 +54,10 @@ class EvalHook(Hook):
+                  save_best=None,
+                  rule=None,
+                  **eval_kwargs):
++        warnings.warn(
++            'DeprecationWarning: EvalHook and DistEvalHook is a deprecated, '
++            'please use ""mmcv.runner.EvalHook"" or ""mmcv.runner.DistEvalHook"" '
++            'instead')
+         if not isinstance(dataloader, DataLoader):
+             raise TypeError('dataloader must be a pytorch DataLoader, but got'
+                             f' {type(dataloader)}')","We should let this module inherits from the EvalHook supported in MMCV, and only override the `__init__` function by adding the warnings. The other functions can use those in MMCV.",I don't think we need to deprecate it. We can just remove it.
+4361,"@@ -267,14 +267,15 @@ public class PostgreExecutionContext extends JDBCExecutionContext implements DBC
+         }
+     }
+ 
+-    void setSessionRole(final DBRProgressMonitor monitor) throws DBCException {
++    private void setSessionRole(@NotNull DBRProgressMonitor monitor) throws DBCException {
+         final String roleName = getDataSource().getContainer().getConnectionConfiguration().getProviderProperty(PostgreConstants.PROP_CHOSEN_ROLE);
+         if (CommonUtils.isEmpty(roleName)) {
+             return;
+         }
+         try (JDBCSession session = openSession(monitor, DBCExecutionPurpose.UTIL, ""Set active role"")) {
+             try (JDBCStatement dbStat = session.createStatement()) {
+-                dbStat.executeUpdate(""SET ROLE "" + roleName);
++                String sql = ""SET ROLE "" + getDataSource().getSQLDialect().getQuotedIdentifier(roleName, false, true);
++                dbStat.executeUpdate(sql);
+             }
+         } catch (SQLException e) {
+             throw new DBCException(e, this);",Let's use prepared statements here instead  ,Why is this change needed?
+4362,"@@ -2,7 +2,11 @@
+  * External dependencies
+  */
+ import { storiesOf } from '@storybook/react';
+-import Button from 'GoogleComponents/button';
++
++/**
++ * Internal dependencies
++ */
++import Button from '../assets/js/components/button';
+ 
+ storiesOf( 'Global', module )
+ 	.add( 'Buttons', () => {",Just leaving this in one place but thanks so much for re-organising all these imports.  ,I'm not sure if this is the right place to put this file. It 
+4363,"@@ -43,6 +43,7 @@
+ #endif
+ 
+ /* List of instrumentation functions. */
++#ifdef X86
+ #define FUNCTIONS() \
+         FUNCTION(empty) \
+         FUNCTION(empty_1arg) \","Ditto, here and below",Why is this needed?
+4364,"@@ -61,7 +61,7 @@ export function initDebug() {
+ 		}
+ 
+ 		for (const key in vnode.props) {
+-			if (key[0]==='o' && key[1]==='n' && typeof vnode.props[key]!=='function' && vnode.props[key]!=null) {
++			if (key[0]==='o' && key[1]==='n' && typeof vnode.props[key]!=='function' && vnode.props[key]!=null && typeof vnode.type!=='function') {
+ 				throw new Error(
+ 					`Component's ""${key}"" property should be a function, ` +
+ 					`but got [${typeof vnode.props[key]}] instead\n` +",Let's move the check outside the `for`-loop so that we don't have to do it for every prop. If we change it to check for `vnode.type === 'string'` we can automatically skip checking text nodes which don't have props  ,`typeof vnode.type!=='function' && vnode.props[key] !== null`
+4365,"@@ -19,6 +19,17 @@ class TablePlot(BokehPlot, GenericElementPlot):
+ 
+     height = param.Number(default=None)
+ 
++    finalize_hooks = param.HookList(default=[], doc=""""""
++        Optional list of hooks called when finalizing a column
++        (deprecated in favor of hooks). The hook is passed the plot
++        object and the displayed object, and other plotting handles
++        can be accessed via plot.handles."""""")
++
++    hooks = param.HookList(default=[], doc=""""""
++        Optional list of hooks called when finalizing a column.  The
++        hook is passed the plot object and the displayed object, and
++        other plotting handles can be accessed via plot.handles."""""")
++
+     width = param.Number(default=400)
+ 
+     style_opts = (","Seems like the docstring here should simply be ""Deprecated; use `hooks` instead."".",I don't think we need to deprecate this. I think we can just 
+4366,"@@ -62,6 +62,8 @@ public class FeedItemlistAdapter extends BaseAdapter {
+ 
+         if(UserPreferences.getTheme() == R.style.Theme_AntennaPod_Dark) {
+             playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_dark);
++        } else if(UserPreferences.getTheme() == R.style.Theme_AntennaPod_TrueBlack) {
++            playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_trueblack);
+         } else {
+             playingBackGroundColor = ContextCompat.getColor(context, R.color.highlight_light);
+         }","It would be nice to have an `attr` in `styles.xml` for this, so we don't need the same `if` statement in multiple places",This should be `UserPreferences.getTheme() == Theme.Theme_Ant
+4367,"@@ -0,0 +1,10 @@
++class CreateTeachersJoinTable < ActiveRecord::Migration
++  def change
++    create_table :teachers do |t|
++      t.belongs_to :user
++      t.belongs_to :workshop
++    end
++
++    add_index :teachers, [:user_id, :workshop_id], unique: true
++  end
++end",How about `null: false` on these two lines? Also `t.timestamps null: false`?,I don't think you need the `unique: true` here.
+4368,"@@ -183,6 +183,12 @@ public class HiveTableOperations extends BaseMetastoreTableOperations {
+       }
+       threw = false;
+     } catch (TException | UnknownHostException e) {
++      if (e.getMessage().contains(""Table/View 'HIVE_LOCKS' does not exist"")) {
++        LOG.error(""Failed to acquire locks from metastore because 'HIVE_LOCKS' doesn't exist, "" +
++            ""this probably happened when using embedded metastore or doesn't create transactional"" +
++            "" meta table. Please reconfigure and start the metastore."", e);
++      }
++
+       throw new RuntimeException(String.format(""Metastore operation failed for %s.%s"", database, tableName), e);
+ 
+     } catch (InterruptedException e) {","This recommendation isn't very helpful because it isn't clear what ""the metastore"" is. How about this instead: ""To fix this, use an alternative metastore"".",Why do we need this check?
+4369,"@@ -87,6 +87,11 @@ public class SymbolTable {
+     return desiredName + suffix;
+   }
+ 
++  /** Returns true if a {@code symbol} is already used. */
++  public boolean isSymbolUsed(Name symbol) {
++    return symbolTable.contains(symbol.toLowerUnderscore());
++  }
++
+   /**
+    * Returns the next numeric suffix that makes desiredName unique.
+    *","The `SymbolTable` deals only with symbols, I think we can just call this `isUsed` here.",I don't think this method 
+4370,"@@ -165,7 +165,9 @@ webdriver.Builder.prototype.build = function() {
+   } else {
+     var url = this.serverUrl_;
+     var client;
+-    if (url[0] == '/') {
++    if (webdriver.http.CorsClient.isAvailable()) {
++      client = new webdriver.http.XhrClient(url);
++    } else if (url[0] == '/') {
+       var origin = window.location.origin ||
+           (window.location.protocol + '//' + window.location.host);
+       client = new webdriver.http.XhrClient(origin + url);",Please hide this behind a flag and add a setter function to the builder.,Why is this needed?
+4371,"@@ -339,6 +339,9 @@ class EC2VPC(GenericBaseModel):
+                 )
+                 for rt in resp[""RouteTables""]:
+                     for assoc in rt.get(""Associations"", []):
++                        # skipping Main association (accommodating recent upstream change)
++                        if assoc.get(""Main""):
++                            continue
+                         ec2_client.disassociate_route_table(
+                             AssociationId=assoc[""RouteTableAssociationId""]
+                         )","Just a side-node, no need to change it here: The term ""recent"" might be confusing at a later point in time.",I think this should be `if
+4372,"@@ -36,7 +36,9 @@ module.exports = {
+             this.assertEqual(val1 && val1.getTime(), val2.getTime(), errorMessage, depth + 1);
+         }
+         else if (type === 'object') {
+-            for (const key of Object.keys(val1)) {
++            var keys = val1.keys !== undefined ? val1.keys() : Object.keys(val1);
++
++            for (const key of keys) {
+                 const message = errorMessage ? `${errorMessage}: ${key}` : key;
+                 this.assertEqual(val1[key], val2[key], message, depth + 1);
+             }",When can it be undefined? Wouldn't that be a bug?,`Object.keys(val1)` can be `null` or `undefined`.
+4373,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+ 
+ import com.google.common.base.Predicate;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+ 
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.,I don't think this is needed.
+4374,"@@ -430,7 +430,7 @@ class KoalasBoxPlot(BoxPlot):
+                 ).alias(""{}_{}%"".format(colname, int(q * 100)))
+                 for q in [0.25, 0.50, 0.75]
+             ],
+-            F.mean(colname).alias(""{}_mean"".format(colname))
++            F.mean(colname).alias(""{}_mean"".format(colname)),
+         ).toPandas()
+ 
+         # Computes IQR and Tukey's fences","Could you remove `,' at the end?",I'm not sure if this is the right way to do it. I
+4375,"@@ -52,6 +52,8 @@ var Server = function(requestHandler) {
+    *     with the server host when it has fully started.
+    */
+   this.start = function(opt_port) {
++    assert(typeof opt_port !== 'function',
++           ""start invoked with function, not port (mocha callback)?"");
+     var port = opt_port || portprober.findFreePort('localhost');
+     return promise.when(port, function(port) {
+       return promise.checkedNodeCall(",Maybe it would simpler to ignore opt_port if type !== 'number'?,I don't think this is the right error message. It
+4376,"@@ -137,11 +137,11 @@ type AccountData struct {
+ 	// is expected to have copy-by-value semantics.
+ 	Assets map[AssetIndex]AssetHolding `codec:""asset,allocbound=-""`
+ 
+-	// SpendingKey is the address against which signatures/multisigs/logicsigs should be checked.
++	// EffectiveAddr is the address against which signatures/multisigs/logicsigs should be checked.
+ 	// If empty, the address of the account whose AccountData this is is used.
+-	// A transaction may change an account's SpendingKey to ""re-key"" the account.
++	// A transaction may change an account's EffectiveAddr to ""re-key"" the account.
+ 	// This allows key rotation, changing the members in a multisig, etc.
+-	SpendingKey Address `codec:""spend""`
++	EffectiveAddr Address `codec:""spend""`
+ }
+ 
+ // AccountDetail encapsulates meaningful details about a given account, for external consumption",do you want to rename the codec tag here too?,I think this should be called `EffectiveAddress`
+4377,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";  
++  String STOP_CASTING = ""stopCasting"";    
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`,I don't think these are used anywhere.
+4378,"@@ -106,6 +106,13 @@ def _auto_patch():
+     import os
+     import logging
+ 
++    from pyspark.sql import dataframe as df, functions as F
++    from databricks.koalas import functions
++
++    for name in functions.__all__:
++        if not hasattr(F, name):
++            setattr(F, name, getattr(functions, name))
++
+     # Attach a usage logger.
+     logger_module = os.getenv(""KOALAS_USAGE_LOGGER"", None)
+     if logger_module is not None:",Hm.. should we auto-patch? I am less sure on this yet as `percentile_approx` seems a Spark function and auto-patching it in Koalas seems a bit counterintuitive.,Why do we need this?
+4379,"@@ -4,12 +4,14 @@ declare(strict_types=1);
+ 
+ namespace Tests\ShopBundle\Test;
+ 
++use Psr\Container\ContainerInterface;
+ use Shopsys\FrameworkBundle\Component\DataFixture\PersistentReferenceFacade;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
+ use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
+ use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
++use Zalas\Injector\PHPUnit\TestCase\ServiceContainerTestCase;
+ 
+-abstract class FunctionalTestCase extends WebTestCase
++abstract class FunctionalTestCase extends WebTestCase implements ServiceContainerTestCase
+ {
+     /**
+      * @var \Symfony\Bundle\FrameworkBundle\Client",I found domain use in `AllFeedsTest::getAllFeedExportCreationData` and class AllFeedsTest is descendant of `FunctionalTestCase`. I think so we can rewrite this too..,Why do we need this?
+4380,"@@ -91,6 +91,13 @@ class IcebergFilesCommitter extends AbstractStreamOperator<Void>
+   private transient Table table;
+   private transient long maxCommittedCheckpointId;
+ 
++  // There're two cases that we restore from flink checkpoints: the first case is restoring from snapshot created by the
++  // same flink job; another case is restoring from snapshot created by another different job. For the second case, we
++  // need to maintain the old flink job's id in flink state backend to find the max-committed-checkpoint-id when
++  // traversing iceberg table's snapshots.
++  private static final ListStateDescriptor<String> JOB_ID_DESCRIPTOR = new ListStateDescriptor<>(
++      ""iceberg-flink-job-id"", BasicTypeInfo.STRING_TYPE_INFO);
++  private transient ListState<String> jobIdState;
+   // All pending checkpoints states for this function.
+   private static final ListStateDescriptor<SortedMap<Long, List<DataFile>>> STATE_DESCRIPTOR = buildStateDescriptor();
+   private transient ListState<SortedMap<Long, List<DataFile>>> checkpointsState;","I am wondering if it is better to consolidate all committer checkpoint states into a single structure, e.g. Pojo class or Avro record which are Flink supported state types for schema evolution.",`iceberg-flink-job-id` -> `iceberg-flink-job-id`
+4381,"@@ -56,9 +56,10 @@ class SignalFilter(QObject):
+         Return:
+             A partial function calling _filter_signals with a signal.
+         """"""
+-        return functools.partial(self._filter_signals, signal, tab)
++        log_signal = debug.signal_name(signal) not in self.BLACKLIST
++        return functools.partial(self._filter_signals, signal, log_signal, tab)
+ 
+-    def _filter_signals(self, signal, tab, *args):
++    def _filter_signals(self, signal, log_signal, tab, *args):
+         """"""Filter signals and trigger TabbedBrowser signals if needed.
+ 
+         Triggers signal if the original signal was sent from the _current_ tab","I assume this is a performance optimization to only check this once when creating the signal filter? While you're at it, maybe make `BLACKLIST` a set instead?",I don't think you need to pass `log_signal` to `
+4382,"@@ -36,6 +36,18 @@ class DatabaseDriverNode {
+ 		});
+ 	}
+ 
++	loadExtension(path) {
++		return new Promise((resolve, reject) => {
++			this.db_.loadExtension(path, (error) => {
++				if (error) {
++					reject(error);
++					return;
++				}
++				resolve();
++			});
++		});
++	}
++
+ 	selectAll(sql, params = null) {
+ 		if (!params) params = {};
+ 		return new Promise((resolve, reject) => {",Please use async/await and try/catch,"I'm not sure if this is the best way to do this,"
+4383,"@@ -1065,11 +1065,9 @@ void GenStruct(StructDef &struct_def, std::string *code_ptr) {
+       }
+     }
+   // generate object accessors if is nested_flatbuffer
++  if (field.nested_flatbuffer != nullptr) {
+   auto nested = field.attributes.Lookup(""nested_flatbuffer"");
+-  if (nested) {
+-    auto nested_qualified_name =
+-      parser_.namespaces_.back()->GetFullyQualifiedName(nested->constant);
+-    auto nested_type = parser_.structs_.Lookup(nested_qualified_name);
++	auto nested_type = nested->type.struct_def;
+     auto nested_type_name = WrapInNameSpace(*nested_type);
+     auto nestedMethodName = MakeCamel(field.name, lang_.first_camel_upper)
+       + ""As"" + nested_type_name;","Like I said, this code looks incorrect. Why is it still looking up the attribute? Why is it getting the type from `nested->type.struct_def` instead of `field.nested_flatbuffer`? Are you running `generate_code.sh`, because I think `nested->type.struct_def` would be null?",Nit: `nested->type.struct_def` -> `nested->type`
+4384,"@@ -1664,6 +1664,7 @@ TEST_F(VkLayerTest, DescriptorUpdateTemplateEntryWithInlineUniformBlock) {
+         m_device_extension_names.push_back(VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME);
+     } else {
+         printf(""%s Push Descriptor Extension not supported, push descriptor cases skipped.\n"", kSkipPrefix);
++        return;
+     }
+ 
+     ASSERT_NO_FATAL_FAILURE(InitState(nullptr, nullptr, VK_COMMAND_POOL_CREATE_RESET_COMMAND_BUFFER_BIT));","Actually, I'm not sure why lines 1663-1668 are here. Looks like Push descriptors aren't used in the test at all. @ziga-lunarg?",Why is this needed?
+4385,"@@ -250,7 +250,7 @@ public class NodeJSGapicContext extends GapicContext implements NodeJSContext {
+    */
+   public List<String> fieldPropertyComment(Field field) {
+     String commentType = fieldTypeCardinalityComment(field);
+-    String fieldName = wrapIfKeywordOrBuiltIn(field.getSimpleName());
++    String fieldName = lowerUnderscoreToLowerCamel(field.getSimpleName());
+     return convertToCommentedBlock(
+         fieldComment(String.format(""@property {%s} %s"", commentType, fieldName), null, field));
+   }",Don't we still want to check it it's a keyword?,Why is this change 
+4386,"@@ -14,7 +14,7 @@ class AttachmentDecorator < Draper::Decorator
+         class: ""image-with-border""
+       )
+     else
+-      ""<br><table><tr><td><strong><u>#{link_text}</u></strong></td></tr></table>""
++      ""#{link_text}""
+     end
+   end
+ ",this can just me `link_text` :tomato:,Style/StringLiteral
+4387,"@@ -2045,3 +2045,15 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+             kser = ks.from_pandas(pser)
+             expected = pser
+             self.assert_eq(kser.explode(), expected)
++
++    def test_argsort(self):
++        pser = pd.Series(np.random.rand(5), index=np.random.rand(5), name=""Koalas"")
++        kser = ks.from_pandas(pser)
++        self.assert_eq(pser.argsort().sort_index(), kser.argsort().sort_index())
++
++        # MultiIndex
++        pser.index = pd.MultiIndex.from_tuples(
++            [(""a"", ""v""), (""b"", ""w""), (""c"", ""x""), (""d"", ""y""), (""e"", ""z"")]
++        )
++        kser = ks.from_pandas(pser)
++        self.assert_eq(pser.argsort().sort_index(), kser.argsort().sort_index())",What if the Series contains null values?,can you use `assert
+4388,"@@ -177,14 +177,11 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+                 {
+                     new Location
+                     {
+-                         AnalysisTarget = new List<PhysicalLocationComponent>
+-                         {
+-                             new PhysicalLocationComponent
+-                             {
+-                                 Uri = TestAnalysisTarget.CreateUriForJsonSerialization(),
+-                                 Region = region
+-                             },
+-                         }
++                        AnalysisTarget = new PhysicalLocation
++                        {
++                            Uri = TestAnalysisTarget.CreateUriForJsonSerialization(),
++                            Region = region
++                        }
+                     }
+                 },
+                 FormattedMessage = new FormattedMessage","Every place you see a change like this, it's because `PhysicalLocation` is now its own object, not an array of `PhysicalLocationComponent` objects. The `Uri` is the key into the `FileInfo` dictionary.",Why did you change this?
+4389,"@@ -7,7 +7,7 @@ from mmdet.core.bbox.iou_calculators import bbox_overlaps
+ from mmdet.models import HEADS
+ from mmdet.models.dense_heads import ATSSHead
+ 
+-eps = 1e-12
++EPS = 1e-12
+ try:
+     import sklearn.mixture as skm
+ except ImportError:",Like in atss_head,why is this changed?
+4390,"@@ -233,6 +233,16 @@ func (pool *TransactionPool) test(txgroup []transactions.SignedTxn) error {
+ 	// requires a flat MinTxnFee).
+ 	feePerByte = feePerByte * pool.feeThresholdMultiplier
+ 
++	// The threshold grows exponentially if there are multiple blocks
++	// pending in the pool.
++	if pool.numPendingWholeBlocks > 1 {
++		// golang has no convenient integer exponentiation, so we just
++		// do this in a loop
++		for i := 0; i < int(pool.numPendingWholeBlocks)-1; i++ {
++			feePerByte *= pool.expFeeFactor
++		}
++	}
++
+ 	for _, t := range txgroup {
+ 		feeThreshold := feePerByte * uint64(t.GetEncodedLength())
+ 		if t.Txn.Fee.Raw < feeThreshold {","nit : I think it would be better to have the multiplier being calculated along with `pool.numPendingWholeBlocks`, so that we could always multiply the feePerByte with that multiplier. Not only that it would be faster, but it would also have constant time. btw - Correct me if I'm wrong, but with this change, you're practically rolling back your previous change while making it `pool.expFeeFactor` adjustable, right ?",I don't think this is th
+4391,"@@ -1,4 +1,5 @@
+ class CommentsController < ApplicationController
++  before_filter :authenticate_user!
+ 
+   def index
+     @commentable = find_commentable",Is there a reason we _wouldn't_ want to do this? A bit of a security hole :grimacing:,Extra empty line detecte
+4392,"@@ -0,0 +1,14 @@
++package azkaban.project;
++
++import java.io.File;
++import java.io.FileInputStream;
++import java.io.FileNotFoundException;
++import org.yaml.snakeyaml.Yaml;
++
++
++public class ProjectSpecLoader {
++
++  public ProjectSpec load(File projectSpecFile) throws FileNotFoundException {
++    return new Yaml().loadAs(new FileInputStream(projectSpecFile), ProjectSpec.class);
++  }
++}",Please add a copyright notice to all new files. Is there a tool to check and auto update copyright notices?,Why do we need this?
+4393,"@@ -132,7 +132,7 @@ class UserFormType extends AbstractType
+                     new Email(['message' => 'Please enter valid e-mail']),
+                     new UniqueEmail(['ignoredEmail' => $user !== null ? $user->getEmail() : null]),
+                 ],
+-                'label' => t('Email'),
++                'label' => t('E-mail'),
+             ]);
+ 
+         $builderRegisteredCustomerGroup = $builder->create('registeredCustomer', GroupType::class, [","A new translation dump should be made after this change (removing the ""Email"" message)",Why did you change t
+4394,"@@ -9,7 +9,9 @@ function owns(node, virtualTree, role, ariaOwned) {
+ 	if (node === null) {
+ 		return false;
+ 	}
+-	var implicit = implicitNodes(role),
++	var implicit = implicitNodes(role).map(
++			implicitSelector => implicitSelector + ':not([role])'
++		),
+ 		selector = ['[role=""' + role + '""]'];
+ 
+ 	if (implicit) {",CI is failing saying `expected [TypeError: null is not an object (evaluating 'implicitNodes(role).map')] to equal null`.,I'm not sure if this
+4395,"@@ -572,12 +572,12 @@ describe('createRoot()', () => {
+ 			});
+ 
+ 			it('should avoid reapplying innerHTML when __html property of dangerouslySetInnerHTML attr remains unchanged', () => {
++				let thing;
++
+ 				class Thing extends Component {
+-					constructor(props) {
+-						super(props);
+-						props.ref(this);
+-					}
+ 					render() {
++						thing = this;
++
+ 						// eslint-disable-next-line react/no-danger
+ 						return (
+ 							<div dangerouslySetInnerHTML={{ __html: '<span>same</span>' }} />",@JoviDeCroock I replaced the refs here with simple assignments.,Why do we need this?
+4396,"@@ -84,7 +84,7 @@ public class TestHiveMetastore {
+   private ExecutorService executorService;
+   private TServer server;
+   private HiveMetaStore.HMSHandler baseHandler;
+-  private HiveClientPool clientPool;
++  protected HiveClientPool clientPool; // Exposed for testing.
+ 
+   /**
+    * Starts a TestHiveMetastore with the default connection pool size (5).",nit: Could we use VisibleForTesting annotation here?,Why do we need this?
+4397,"@@ -24,6 +24,10 @@ class PostTest < ActiveSupport::TestCase
+     post.must :save
+   end
+ 
++  it ""should sort 'by_unanswered'"" do
++    Post.by_unanswered.must_equal Post.joins(:topic).where(""posts_count = '1'"").order('created_at desc')
++  end
++
+   it 'posts should have an associated topic' do
+     topic = create(:topic_with_posts)
+     topic.posts[0].topic.must_equal topic",Can we create some post records to assert sort_by,I'm not sure if this
+4398,"@@ -178,6 +178,7 @@ func New(ctx context.Context, o Options) (*Service, error) {
+ 		peerID := stream.Conn().RemotePeer()
+ 		i, err := s.handshakeService.Handle(NewStream(stream), peerID)
+ 		if err != nil {
++			_ = stream.Reset()
+ 			if err == handshake.ErrNetworkIDIncompatible {
+ 				s.logger.Warningf(""peer %s has a different network id."", peerID)
+ 			}",is this necessary?,Why is this needed?
+4399,"@@ -68,6 +68,8 @@ namespace Datadog.Trace.TestHelpers
+         /// </summary>
+         public int Port { get; }
+ 
++        public List<Func<Span, bool>> Filters { get; private set; } = new List<Func<Span, bool>>();
++
+         public IImmutableList<Span> Spans { get; private set; } = ImmutableList<Span>.Empty;
+ 
+         public IImmutableList<NameValueCollection> RequestHeaders { get; private set; } = ImmutableList<NameValueCollection>.Empty;",What is the purpose of this? It seems like it is used to indicate whether there is a filter on a span. But what filter? Could there eventually be multiple filters per span? Just not understanding.,Why do we need this?
+4400,"@@ -52,6 +52,13 @@ type ChaosCondition struct {
+ 	Reason string `json:""reason""`
+ }
+ 
++const (
++	Injecting string = ""injecting""
++	Running   string = ""running""
++	Finished  string = ""finished""
++	Paused    string = ""paused""
++)
++
+ type DesiredPhase string
+ 
+ const (",using a certain type instead of using string directly.,Why is this a string?
+4401,"@@ -761,7 +761,7 @@ func TestCrConflictMergedRenameSetMtimeFile(t *testing.T) {
+ 	)
+ }
+ 
+-// alice and both both rename(the same file, causing a copy.),
++// alice and both both rename the same file, causing a copy.,
+ func TestCrConflictRenameSameFile(t *testing.T) {
+ 	test(t,
+ 		users(""alice"", ""bob""),","fix trailing ,",I'm not sure why this
+4402,"@@ -16,7 +16,7 @@
+       <% end %>
+       ... <%= t'trace.trace.ago', :time_in_words_ago => time_ago_in_words(trace.timestamp) %></span>
+       <%= link_to t('trace.trace.more'), {:controller => 'trace', :action => 'view', :display_name => trace.user.display_name, :id => trace.id}, {:title => t('trace.trace.trace_details')} %> /
+-      <%= link_to_if trace.inserted?, t('trace.trace.map'), {:controller => 'site', :action => 'index', :anchor => ""map=14/#{trace.latitude}/#{trace.longitude}""}, {:title => t('trace.trace.view_map')} %> /
++      <%= link_to_if trace.inserted?, t('trace.trace.map'), {:controller => 'site', :action => 'index', :mlat => ""#{trace.latitude}"", :mlon => ""#{trace.longitude}"", :anchor => ""map=14/#{trace.latitude}/#{trace.longitude}""}, {:title => t('trace.trace.view_map')} %> /
+       <%= link_to t('trace.trace.edit'), {:controller => 'site', :action => 'edit', :gpx => trace.id }, {:title => t('trace.trace.edit_map')} %>
+       <span class=""trace_<%= trace.visibility %>""><%= t('trace.trace.' + trace.visibility) %></span>
+       <br />",I've fixed it for this change but for future reference there's no point doing string substitution for a single value like that - it will just slow things down. Just use `:mlat => trace.latitude` etc instead.,I don't think we need
+4403,"@@ -10,11 +10,7 @@ namespace Ergonode\Product\Application\Model\Product\Attribute\Update;
+ 
+ use Symfony\Component\Validator\Constraints as Assert;
+ use Ergonode\Attribute\Application\Validator as AttributeAssert;
+-use Ergonode\Product\Application\Validator as ProductAssert;
+ 
+-/**
+- * @ProductAssert\ProductAttribute()
+- */
+ class UpdateAttributeValueFormModel
+ {
+     /**",The form no logger needs validation?,Why did you remove th
+4404,"@@ -42,7 +42,7 @@ namespace OpenTelemetry.Metrics
+             if (this.getMetrics != null)
+             {
+                 var metricsToExport = this.getMetrics(this.isDelta);
+-                if (metricsToExport != null)
++                if (metricsToExport != null && metricsToExport.Metrics.Count > 0)
+                 {
+                     Batch<MetricItem> batch = new Batch<MetricItem>(metricsToExport);
+                     this.exporter.Export(batch);","there'd be more changes in the area, when we implement ""clean-up"" of aggregators if no new updates. (i think we currently send metricitem to exporters with zero as value)",Shouldn't this be `metricsToExport.Metrics.Any()`?
+4405,"@@ -52,7 +52,9 @@ class CollectionViewTest(BaseWebTest, unittest.TestCase):
+         self.app.put_json('/buckets/sodas',
+                           MINIMALIST_BUCKET,
+                           headers=self.headers)
+-        self.app.get(other_bucket, headers=self.headers, status=404)
++        resp = self.app.get(other_bucket, headers=self.headers, status=404)
++        self.assertIn('id', resp.json['details'])
++        self.assertIn('resource_name', resp.json['details'])
+ 
+     def test_create_permissions_can_be_added_on_collections(self):
+         collection = MINIMALIST_COLLECTION.copy()","Usually we only keep the assertions that are relevant to the specification (ie. the test title). For example, the test on the values of id and details is not properly relevant for the spec _collections are isolated by bucket_. I suggest that you only keep the assertions regarding `details` in dedicated tests similar to `test_unknown_collection_raises_404` from `test_views_records.py`, but for each of bucket, group, collection and record in the other `test_views_` files.",Why do we need to check the resource name?
+4406,"@@ -28,7 +28,7 @@ public class FieldAccessGenericParameter<T extends GenericClass<String, GenericC
+     <C extends Number> FieldAccessGenericParameter() {
+         C constructorGeneric = null;
+ 
+-        // access type dependant on constructor type arugments
++        // access type dependant on constructor type arguments
+         // Primary[Prefix[Name[localGeneric]]]
+         constructorGeneric = null; // Number
+     }","The test sources are ok though, you don't need to remove those changes",Why is this change needed?
+4407,"@@ -72,7 +72,7 @@ define(['itemHelper', 'mediaInfo', 'indicators', 'connectionManager', 'layoutMan
+         var apiClient = connectionManager.getApiClient(item.ServerId);
+ 
+         var options = {
+-            width: width,
++            maxWidth: width * 2,
+             type: ""Primary""
+         };
+ ","`maxWidth: width * 2,` Potentially, this will be the same as `getImageUrl`: 80px or 500px. I can't verify this - need for normal LiveTV tuner.",Why do we need this change?
+4408,"@@ -161,9 +161,11 @@ public class EnginesFilter extends AbstractFilter {
+      * @return True if the given engine category fulfills the filter, false otherwise
+      */
+     public boolean filter(EngineCategoryDTO engineCategory) {
+-        return searchTerm.map(
+-                searchTerm -> engineCategory.getSubCategories().stream().anyMatch(engineSubCategory -> engineSubCategory
+-                        .getPackages().stream().anyMatch(version -> version.getVersion().contains(searchTerm))))
++        return searchTerm
++                .map(searchTerm -> engineCategory.getSubCategories().stream()
++                        .anyMatch(engineSubCategory -> engineSubCategory.getPackages().stream()
++                                .anyMatch(version -> version.getVersion().toLowerCase()
++                                        .contains(searchTerm.toLowerCase()))))
+                 .orElse(true);
+     }
+ ",Not really related to this issue but should we use fuzzy search here as well (like for apps)?,Why do we need to lower case here?
+4409,"@@ -11,10 +11,10 @@ const mdUsageStr = `Usage:
+   kbfstool md [<subcommand>] [<args>]
+ 
+ The possible subcommands are:
+-  dump		Dump metadata objects
+-  check		Check metadata objects and their associated blocks for errors
+-  reset		Reset a broken top-level folder
+-
++  dump	      Dump metadata objects
++  check	      Check metadata objects and their associated blocks for errors
++  reset	      Reset a broken top-level folder
++  forceQR     Append a fake quota reclamation record to the folder history
+ `
+ 
+ func mdMain(ctx context.Context, config libkbfs.Config, args []string) (exitStatus int) {",isn't the usual capitalization for subcommands force-qr? (don't care too much about it),I'm not sure if this is the best w
+4410,"@@ -38,7 +38,7 @@ import java.lang.reflect.Proxy;
+         name = ""ProxyNonConstantType"",
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = LinkType.CUSTOM,
+-        severity = SeverityLevel.SUGGESTION,
++        severity = SeverityLevel.WARNING,
+         summary = ""Proxy instances should be created using constant types known at compile time to allow native-image ""
+                 + ""behavior to match hotspot. Methods which build proxies should take a ""
+                 + ""`Function<InvocationHandler, ? extends T>` instead of arbitrary class references. """,Do you know how many repos have hit this?,I'm not sure if this is a good ide
+4411,"@@ -1,3 +1,13 @@
++<% if @filter.present? %>
++  <p><%= _(<<-TEXT
++    The data on the usage dashboard is historical in nature. This means that the number of records below may not
++    match the count shown on the usage dashboard. For example if one of your users created a plan in October and
++    then removed that plan in November, it would have been included on the usage dashboard's total for October but
++    would not appear in the list below.
++  TEXT
++  ) %></p>
++<% end %>
++
+ <div class=""table-responsive"">
+   <table class=""table table-hover"" id=""my-plans"">
+     <thead>",I'll be interested to see if our gettext rake tasks will pick up on this text to translate,I don't think we need the `<p>` he
+4412,"@@ -933,6 +933,7 @@ void LuaScriptInterface::pushInstantSpell(lua_State* L, const InstantSpell& spel
+ 	setField(L, ""mlevel"", spell.getMagicLevel());
+ 	setField(L, ""mana"", spell.getMana());
+ 	setField(L, ""manapercent"", spell.getManaPercent());
++	setField(L, ""params"", spell.getHasParam());
+ 
+ 	setMetatable(L, -1, ""Spell"");
+ }","I think you need to change line 928 value from 6 to 7 too, since now table will have 7 values","setField(L, ""hasparam"", spell.getHasParam());"
+4413,"@@ -126,3 +126,14 @@ def test_split_into_nhot_long(seed, st):
+     assert set(f1.names) == set(fr.names)
+     f1 = f1[..., fr.names]
+     assert f1.to_list() == fr.to_list()
++
++
++def test_split_into_nhot_view():
++  f0 = dt.Frame(A=[""cat,dog,mouse"", ""mouse"", None, ""dog, cat""])
++  f1 = dt.split_into_nhot(f0[::-1, :])
++  f2 = dt.split_into_nhot(f0[3, :])
++  assert set(f1.names) == {""cat"", ""dog"", ""mouse""}
++  assert f1[:, [""cat"", ""dog"", ""mouse""]].to_list() == \
++         [[1, 0, 0, 1], [1, 0, 0, 1], [0, 0, 1, 1]]
++  assert set(f2.names) == {""cat"", ""dog""}
++  assert f2[:, [""cat"", ""dog""]].to_list() == [[1], [1]]","Does `f0[::-1, :]` mean all the rows taken in a reverse order?",I don't think you need the `\`
+4414,"@@ -30,7 +30,7 @@ public class JavaProcessJobTest
+     "" By JULIE BOSMAN \n"" +
+     ""Published: August 11, 2010 \n"" +
+     "" \n"" +
+-    ""Twelve years later, it may be Joe Fox�s turn to worry. Readers have gone from skipping small \n"" +
++    ""Twelve years later, it may be Joe Fox���s turn to worry. Readers have gone from skipping small \n"" +
+     ""bookstores to wondering if they need bookstores at all. More people are ordering books online  \n"" +
+     ""or plucking them from the best-seller bin at Wal-Mart"";
+ ",Looks like there are strange characters here.,I don't think this change is correct.
+4415,"@@ -97,7 +97,7 @@ func (r *Reconciler) Reconcile(req ctrl.Request) (ctrl.Result, error) {
+ 
+ 		status.Experiment.Phase = v1alpha1.ExperimentPhaseFinished
+ 		status.FailedMessage = emptyString
+-	} else if chaos.IsPaused() {
++	} else if chaos.GetPause() != """" {
+ 		if status.Experiment.Phase == v1alpha1.ExperimentPhaseRunning {
+ 			r.Log.Info(""Pausing"")
+ ",It is better to have a check to ensure the format is valid.,"I think this should be `!= """"`"
+4416,"@@ -22,14 +22,16 @@ namespace AutoRest.Go.TemplateModels
+         private readonly string lroDescription = "" This method may poll for completion. Polling can be canceled by passing the cancel channel argument. "" +
+                                                  ""The channel will be used to cancel polling and any outstanding HTTP requests."";
+ 
++        public readonly bool NextAlreadyDefined;
+ 
+-        public MethodTemplateModel(Method source, string owner, string packageName, MethodScopeProvider methodScope)
++        public MethodTemplateModel(Method source, string owner, string packageName, MethodScopeProvider methodScope, bool next)        
+         {
+             this.LoadFrom(source);
+ 
+             MethodScope = methodScope;
+             Owner = owner;
+             PackageName = packageName;
++            NextAlreadyDefined = next;
+ 
+             var parameter = Parameters.Find(p => p.Type.IsPrimaryType(KnownPrimaryType.Stream)
+                                                 && !(p.Location == ParameterLocation.Body || p.Location == ParameterLocation.FormData));",How about `nextAlreadyDefined` variable name in method signature?,Why do we need this?
+4417,"@@ -459,7 +459,7 @@ func (s *clientIntegrationSuite) TestClientDataConverter_WithChild() {
+ 
+ 	// to ensure custom data converter is used, this number might be different if client changed.
+ 	d := dc.(*testDataConverter)
+-	s.Equal(3, d.NumOfCallToPayloads)
++	s.Equal(2, d.NumOfCallToPayloads)
+ 	s.Equal(2, d.NumOfCallFromPayloads)
+ }
+ ","In older SDK versions the data converter was called 3 times but now it is 2. This is because logic was changed deep in the interceptor chains on when values are serialized and encoded and such. Previously we invoked the data converter on results _even if there was an error_ (and most of the time they were nil). Now we don't do such a thing, resulting in fewer calls.",Why did you change t
+4418,"@@ -17,6 +17,7 @@ limitations under the License.
+ package main
+ 
+ import (
++	""github.com/google/knative-gcp/pkg/reconciler/events/build""
+ 	// The following line to load the gcp plugin (only required to authenticate against GKE clusters).
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+ ",formatting... can this import go next to the other sources ones?,Why is this needed?
+4419,"@@ -286,10 +286,10 @@ const char *options_list_str =
+     ""       -early             Requests early injection (the default).\n""
+     ""       -late              Requests late injection.\n""
+ #        endif
+-    ""       -attach <pid>      Attach to the process with the given pid.  Pass 0\n""
+-    ""                          for pid to launch and inject into a new process.\n""
+     ""       -logdir <dir>      Logfiles will be stored in this directory.\n""
+ #    endif
++    ""       -attach <pid>      Attach to the process with the given pid.  Pass 0\n""
++    ""                          for pid to launch and inject into a new process.\n""
+     ""       -use_dll <dll>     Inject given dll instead of configured DR dll.\n""
+     ""       -force             Inject regardless of configuration.\n""
+     ""       -exit0             Return a 0 exit code instead of the app's exit code.\n""",I don't understand why anyone would pass 0? If you don't want to attach to an existing process you just wouldn't pass -attach. I would remove that sentence and make 0 an invalid argument.,Why did you remove t
+4420,"@@ -77,8 +77,6 @@ void (*volatile s_current_function)(ThreadsExec &, const void *);
+ const void *volatile s_current_function_arg = nullptr;
+ 
+ struct Sentinel {
+-  Sentinel() {}
+-
+   ~Sentinel() {
+     if (s_thread_pool_size[0] || s_thread_pool_size[1] ||
+         s_thread_pool_size[2] || s_current_reduce_size ||",This change is responsible for #2775,Why remove this?
+4421,"@@ -88,7 +88,11 @@ namespace Datadog.Trace.Tests.RuntimeMetrics
+                 writer.PushEvents();
+ 
+                 statsd.Verify(
+-                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), It.IsAny<string[]>()),
++                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), new[] { ""exception_type:CustomException1"" }),
++                    Times.Never);
++
++                statsd.Verify(
++                    s => s.Increment(MetricsNames.ExceptionsCount, It.IsAny<int>(), It.IsAny<double>(), new[] { ""exception_type:CustomException2"" }),
+                     Times.Never);
+             }
+         }","Should we add this to the other ""never"" verification in lines 71-73 above, too?",Why do we need a
+4422,"@@ -175,12 +175,12 @@ class CaiApiClientImpl(gcp.ApiClientImpl):
+             dict: Generator of datasets.
+         """"""
+ 
+-        resources = list(self.dao.iter_cai_assets(
++        resources = self.dao.iter_cai_assets(
+             ContentTypes.resource,
+             'google.cloud.bigquery.Dataset',
+             '//cloudresourcemanager.googleapis.com/projects/{}'.format(
+                 project_number),
+-            self.session))
++            self.session)
+ 
+         for dataset in resources:
+             yield dataset","Fixed this since it no longer needed to be switched from a generator to a list, this was missed when I cleaned up the dataset code in an earlier PR.",Why is this a li
+4423,"@@ -70,7 +70,7 @@ public class NodeOptions {
+       Capabilities caps = info.getCanonicalCapabilities();
+       builders.stream()
+           .filter(builder -> builder.score(caps) > 0)
+-          .peek(builder -> LOG.info(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
++          .peek(builder -> LOG.finest(String.format(""Adding %s %d times"", caps, info.getMaximumSimultaneousSessions())))
+           .forEach(builder -> {
+             DriverService.Builder freePortBuilder = builder.usingAnyFreePort();
+ ",This is an informational message that allows someone to read the console output and understand how the grid node is configured. Please leave.,I think this sho
+4424,"@@ -5,5 +5,17 @@ class ContributorFact < NameFact
+         .where(analysis_id: project.best_analysis_id)
+         .where.not(name_id: Position.where.not(name_id: nil).where(project_id: project.id).select(:name_id))
+     end
++
++    def first_for_name_id_and_project_id(name_id, project_id)
++      sql = <<-SQL
++        SELECT name_facts.* FROM name_facts
++          INNER JOIN projects ON projects.best_analysis_id = name_facts.analysis_id
++          WHERE ( name_facts.name_id = #{name_id.to_i} OR name_facts.name_id IN (
++            SELECT AA.preferred_name_id FROM analysis_aliases AA
++            WHERE AA.analysis_id = projects.best_analysis_id AND AA.commit_name_id = #{name_id.to_i}))
++          AND projects.id = #{project_id.to_i} AND type='ContributorFact'
++        SQL
++      ContributorFact.find_by_sql(sql).first
++    end
+   end
+ end","Can we convert this to an arel as below ContributorFact .joins(:project).where(projects: { id: project_id}) .where('name_id = ? or name_id in (?)', name_id, AnalysisAlias.select(:preferred_name_id) .joins(:project) .where(commit_name_id: name_id) )",Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
+4425,"@@ -11,6 +11,12 @@ import (
+ type DevicesGroup struct {
+ }
+ 
++type CgroupParams struct {
++	initpid int
++}
++
++var cg CgroupParams
++
+ func (s *DevicesGroup) Name() string {
+ 	return ""devices""
+ }",Does this cause issues if you have lots of load on the machine? Having a global variable for this seems like a bad idea IMO.,Why do we need this?
+4426,"@@ -1374,7 +1374,15 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       privacyParametersBuilder.setEnabled(true);
+       privacyParametersBuilder.setEnclaveUrl(privacyUrl);
+       if (privacyPublicKeyFile() != null) {
+-        privacyParametersBuilder.setEnclavePublicKeyUsingFile(privacyPublicKeyFile());
++        try {
++          privacyParametersBuilder.setEnclavePublicKeyUsingFile(privacyPublicKeyFile());
++        } catch (final IOException e) {
++          throw new ParameterException(
++              commandLine, ""Problem with privacy-public-key-file: "" + e.getMessage(), e);
++        } catch (final IllegalArgumentException e) {
++          throw new ParameterException(
++              commandLine, ""Contents of privacy-public-key-file invalid: "" + e.getMessage(), e);
++        }
+       } else {
+         throw new ParameterException(
+             commandLine, ""Please specify Enclave public key file path to enable privacy"");",We probably don't need to print the msg with e.getMessage(). It will be printed by the logger since we are passing the exception as a parameter.,Why do we need this?
+4427,"@@ -29,17 +29,6 @@ from molecule.verifier import testinfra
+ from molecule.verifier.lint import flake8
+ 
+ 
+-@pytest.fixture
+-def _patched_testinfra_get_tests(mocker):
+-    m = mocker.patch('molecule.verifier.testinfra.Testinfra._get_tests')
+-    m.return_value = [
+-        'foo.py',
+-        'bar.py',
+-    ]
+-
+-    return m
+-
+-
+ @pytest.fixture
+ def _verifier_section_data():
+     return {",Can we get a test with multiple directories as per the initial example?,Why was this removed?
+4428,"@@ -317,8 +317,15 @@ def getStatusBar():
+ 	if not location:
+ 		return None
+ 	left, top, width, height = location
+-	bottom = top + height - 1
+-	obj = getDesktopObject().objectFromPoint(left, bottom)
++	x=1
++	while x<12:
++		bottom = top + height - x
++		if left<0:
++			left=0
++		obj = getDesktopObject().objectFromPoint(left, bottom)
++		if obj and obj.role == controlTypes.ROLE_STATUSBAR:
++			break
++		x=x+2
+ 
+ 	# We may have landed in a child of the status bar, so search the ancestry for a status bar.
+ 	while obj and not obj.role == controlTypes.ROLE_STATUSBAR:",I assume this is because you were seeing cases where left was a negative number? When?,Please use spaces around `<`.
+4429,"@@ -11,10 +11,10 @@
+    See the README file in the top-level LAMMPS directory.
+ ------------------------------------------------------------------------- */
+ 
+-#include ""fix_deposit.h""
+-#include <mpi.h>
+ #include <cmath>
++#include <cstdlib>
+ #include <cstring>
++#include ""fix_deposit.h""
+ #include ""atom.h""
+ #include ""atom_vec.h""
+ #include ""molecule.h""",this is undoing recent changes for increased consistency of include file statements. please restore to the original.,Why is this header needed?
+4430,"@@ -24,12 +24,13 @@ public class BaselineErrorProneExtension {
+ 
+     private static final ImmutableList<String> DEFAULT_PATCH_CHECKS = ImmutableList.of(
+             // Baseline checks
++            ""LambdaMethodReference"",
++            ""OptionalOrElseMethodInvocation"",
+             ""PreferBuiltInConcurrentKeySet"",
+             ""PreferCollectionTransform"",
+             ""PreferListsPartition"",
+             ""PreferSafeLoggableExceptions"",
+             ""PreferSafeLoggingPreconditions"",
+-            ""OptionalOrElseMethodInvocation"",
+ 
+             // Built-in checks
+             ""ArrayEquals"",","If these are applied in order, should `LambdaMethoReference` come after `OptionalOrElseMethodInvocation`",I don't think this should be 
+4431,"@@ -42,7 +42,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+         /// A dictionary whose keys are the strings representing the locations of scanned files
+         /// and whose values provide information about those files.
+         /// </param>
+-        void WriteFiles(IDictionary<string, IList<FileData>> fileDictionary);
++        void WriteFiles(IDictionary<string, FileData> filesDictionary);
+ 
+         /// <summary>
+         /// Write information about the logical locations where results were produced to",Why this rename?,>filesDictionary [](start = 2
+4432,"@@ -149,7 +149,7 @@ def _patch_sysmodules():
+     try:
+         yield
+     finally:
+-        if mock_main:
++        if mock_main and sys.version_info < (3, 3):
+             sys.modules.pop(""__main__"")
+ 
+ ",Why do we do this check here? `sys.version_info` cannot be less than 3.3 as pylint does not support older versions. I think we should avoid popping `__main__` altogether.,Why is this needed?
+4433,"@@ -199,6 +199,7 @@ def serv_cmd(codechecker_cfg, test_config):
+                        '--port',
+                        str(codechecker_cfg['viewer_port'])
+                        ])
++    # server_cmd.extend(['--verbose', 'debug'])
+ 
+     psql_cfg = codechecker_cfg.get('pg_db_config')
+     if psql_cfg:",This can be removed too.,server_cmd.extend([
+4434,"@@ -371,8 +371,11 @@ func (md *MDServerMemory) Put(ctx context.Context, rmds *RootMetadataSigned) err
+ 
+ 	// Consistency checks
+ 	if head != nil {
+-		err := head.MD.CheckValidSuccessorForServer(
+-			md.config.Crypto(), &rmds.MD)
++		id, err := md.config.Crypto().MakeMdID(&head.MD)
++		if err != nil {
++			return err
++		}
++		err = head.MD.CheckValidSuccessorForServer(id, &rmds.MD)
+ 		if err != nil {
+ 			return err
+ 		}","I'm a little worried about the new extra calls to `MakeMdId`, since in most local-server KBFS profiles, hashing is the biggest CPU user, and not re-using the value calculated by the client will result in even more hashing. That said, I understand why you did it this way, and I don't have a concrete suggestion on how to make it better. Just something to keep in mind; plus it might be worth comparing the test speed before and after this change to make sure it didn't slow things down too much.",Why do we need this
+4435,"@@ -29,9 +29,12 @@ import PreviewTable from 'GoogleComponents/preview-table';
+  */
+ import { isDataZeroForReporting, getTopPagesReportDataDefaults } from '../util';
+ 
+-const { __ } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __ } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+ 
+ class WPAnalyticsDashboardWidgetTopPagesTable extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies,I think this should
+4436,"@@ -1,6 +1,7 @@
++# -*- coding: UTF-8 -*-
+ #appModules/miranda32.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2012 NVDA Contributors
++#Copyright (C) 2006-2019 NV Access Limited, Aleksey Sadovoy, Peter Vágner, Joseph Lee, Bill Dengler
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ","Just curious, but how did you work out that Aleksey Sadovoy, Peter Vgner and Joseph Lee contributed to this file? Did you look at the repository history?",Why did you remove the copyright?
+4437,"@@ -264,6 +264,19 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+                 _post.Reference();
+                 _post.Dispose();
+ 
++                // We need this walk because we call ReadStop on 2 places:
++                // 1. On the dispatch pipe UvPipeHandle after reading the correct message
++                // 2. On on accepted connections when there's back pressure
++                // Calling ReadStop makes the handle as in-active which means the loop can
++                // end while there's still valid handles around. This makes loop.Dispose throw
++                // with an EBUSY. To avoid that, we walk all of the handles and dispose them.
++                Walk(ptr =>
++                {
++                    var handle = UvMemory.FromIntPtr<UvHandle>(ptr);
++                    // handle can be null because UvMemory.FromIntPtr looks up a weak reference
++                    handle?.Dispose();
++                });
++
+                 // Ensure the Dispose operations complete in the event loop.
+                 _loop.Run();
+ ",You could call OnStopRude() directly here to do the same thing.,Why do we need this?
+4438,"@@ -643,6 +643,8 @@ func (a *WebAPI) ListUnregisteredApplications(ctx context.Context, _ *webservice
+ 		return &webservice.ListUnregisteredApplicationsResponse{}, nil
+ 	}
+ 
++	// TODO: Eliminate apps registered by another Piped
++	//   In case that multiple Pipeds watches the same repo, it could be happen that one Piped report App-1 as an unregistered app even though another Piped register that app.
+ 	sort.Slice(allApps, func(i, j int) bool {
+ 		return allApps[i].Path < allApps[j].Path
+ 	})","This TODO and this `sort` depend on how the UI looks like. So I think we should fix the UI before continuing on updating this web API. For example, in case the UI flow is as below, this API will receive a Piped ID and then return just ones belonging to that Piped. - User picks where they want to deploy first (select one Piped and one cloud provider) - Then API will be called to show the list of suggested apps for that Piped and cloud provider - User picks app they want to create",I'm not sure if this is the right
+4439,"@@ -24,6 +24,16 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+ 
++var (
++	snapshotrevertHelpText = `
++Usage: mayactl snapshot revert [options]
++
++$ mayactl snapshot revert --volname <vol> --snapname <snap>
++
++This command displays status of available snapshotrevert.
++`
++)
++
+ /*type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string","This command rolls back the volume data to the specified snapshot. Once the roll back to snapshot is successful, all the data changes made after the snapshot was taken will be post. This command should be used cautiously and only when there is an issue with the current state of the data.",I think this should be `mayactl s
+4440,"@@ -567,9 +567,12 @@ func TestAwslogsDriver(t *testing.T) {
+ 		})
+ 	}()
+ 
++	strs := strings.Split(*testTask.TaskArn, ""/"")
++	taskId := strs[len(strs)-1]
++
+ 	params := &cloudwatchlogs.GetLogEventsInput{
+ 		LogGroupName:  aws.String(awslogsLogGroupName),
+-		LogStreamName: aws.String(containerId),
++		LogStreamName: aws.String(fmt.Sprintf(""ecs-functional-tests/awslogs/%s"", taskId)),
+ 	}
+ 	resp, err := cwlClient.GetLogEvents(params)
+ 	if err != nil {",should this be a separate/new functional test?,nit: can we use `strings.TrimSuffix` here?
+4441,"@@ -458,6 +458,19 @@ describe Mongoid::QueryCache do
+       end
+     end
+ 
++   context 'when querying colleciton larger than the batch size' do
++     before do
++       101.times { Band.create! }
++     end
++
++     it 'does not raise an exception when querying multiple times' do
++       expect do
++         Band.all.to_a
++         Band.all.to_a
++       end.not_to raise_error
++     end
++   end
++
+     context ""when query caching is enabled and the batch_size is set"" do
+ 
+       around(:each) do |example|",Can these also assert at least the length of arrays returned and ideally contents?,I think it would be better to use `.not_to
+4442,"@@ -822,7 +822,7 @@ class Scheduler(object):
+             task.family = family
+         if not getattr(task, 'module', None):
+             task.module = module
+-        if not task.param_visibilities:
++        if not getattr(task, 'param_visibilities', None):
+             task.param_visibilities = _get_default(param_visibilities, {})
+         if not task.params:
+             task.set_params(params)","`hasattr(task, 'param_visibilities')` is more concise with the same effect, but either one works.","`getattr(task, 'param_visibilities', None)"
+4443,"@@ -364,6 +364,12 @@ MSGS = {
+         ""end up in having multiple values passed for the aforementioned parameter in ""
+         ""case the method is called with keyword arguments."",
+     ),
++    ""W1114"": (
++        ""Positional arguments are out of order"",
++        ""arguments-out-of-order"",
++        ""Attributes given to a function call have are being passed in a different order ""
++        ""to the function's definition"",
++    ),
+ }
+ 
+ # builtin sequence types in Python 2 and 3.","I would hedge this a little, maybe `Positional arguments appear to be out of order`. After all, it's just a guess.",I don't think this is true. `arguments-out
+4444,"@@ -192,7 +192,8 @@ public class AccountActivity extends ThemedActivity implements AccountContract.V
+ 
+     @Override
+     public void showError() {
+-        SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in));
++        Snackbar snackbar = SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in));
++        snackbar.show();
+     }
+ 
+     @Override","you can directly call show() method from **SnackBarHandler.show(coordinatorLayout, getString(no_account_signed_in)).show();** no need to create an extra object and then call the show method.",Why is this change needed?
+4445,"@@ -306,6 +306,19 @@ StatusOr<std::vector<HostAddr>> NetworkUtils::toHosts(const std::string& peersSt
+     return hosts;
+ }
+ 
++std::string NetworkUtils::toHosts(const std::vector<HostAddr>& hosts) {
++    std::string hostsString = """";
++    for (auto& host : hosts) {
++        std::string addrStr = network::NetworkUtils::ipFromHostAddr(host);
++        int32_t port = network::NetworkUtils::portFromHostAddr(host);
++        hostsString += folly::stringPrintf(""%s:%d, "", addrStr.c_str(), port);
++    }
++    if (!hostsString.empty()) {
++        hostsString.resize(hostsString.size() - 2);
++    }
++    return hostsString;
++}
++
+ std::string NetworkUtils::ipFromHostAddr(const HostAddr& host) {
+     return intToIPv4(host.first);
+ }",concatHosts may be a better func name to explain this?,nit: `std::string hostsStr
+4446,"@@ -0,0 +1,19 @@
++import { always } from 'ramda';
++
++/**
++ * A function that returns new empty string.
++ *
++ * @func stubString
++ * @memberOf RA
++ * @since {@link https://char0n.github.io/ramda-adjunct/2.1.0|v2.1.0}
++ * @category Function
++ * @sig ... -> ''
++ * @return {''}
++ * @example
++ *
++ * RA.stubString(); //=> ''
++ * RA.stubString(1, 2, 3); //=> ''
++ */
++const stubString = always('');
++
++export default stubString;",A function that returns empty string.,This should be `always('')
+4447,"@@ -194,7 +194,12 @@ func parsePackage(state *core.BuildState, label, dependent core.BuildLabel, subr
+ 		}
+ 	} else {
+ 		filename, dir := buildFileName(state, label.PackageName, subrepo)
+-		if filename == """" {
++		if filename != """" {
++			pkg.Filename = filename
++			if err := state.Parser.ParseFile(state, pkg, pkg.Filename); err != nil {
++				return nil, err
++			}
++		} else if packageName != """" || state.Config.FeatureFlags.RemovePleasings {
+ 			exists := core.PathExists(dir)
+ 			// Handle quite a few cases to provide more obvious error messages.
+ 			if dependent != core.OriginalTarget && exists {","If it's not the root package, or if it is the root package but we don't add the psudo :pleasings rule there, print an error.",I'm not sure if this is th
+4448,"@@ -17,7 +17,9 @@ import (
+ 	""strconv""
+ 
+ 	""github.com/go-playground/validator/v10""
++
+ 	corev1 ""k8s.io/api/core/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/util/validation""
+ )
+ ",can delete this line,"""github.com/golang/glog"""
+4449,"@@ -76,6 +76,18 @@ generic_data_store::generic_data_store(generic_data_reader *reader, model *m) :
+   if (opts->has_bool(""verbose"") && opts->get_bool(""verbose"")) {
+     m_verbose = true;
+   }
++
++  if (opts->has_string(""use_tarball"")) {
++    m_dir = m_reader->get_local_file_dir();
++  }
++
++  if (m_comm->get_num_models() != 1) {
++    if (m_master) {
++      std::cerr << ""\nFATAL ERROR: data store classes currently assume there is\n""
++                << ""a single model; please ask Dave Hysom to fix!\n\n"";
++    }
++    exit(9);
++  }
+ }
+ 
+ void generic_data_store::get_minibatch_index_vector() {",Will it still be an issue if all the models use the same data set?,I don't think this shoul
+4450,"@@ -37,6 +37,8 @@ class WidgetsController < ApplicationController
+   def handle_xml_format
+     return unless request_format == 'xml'
+     @type = WIDGET_TYPES.select { |klass| controller_name.include?(klass) }[0]
++    @parent = @widget.send(@type)
++    fail ParamRecordNotFound unless @parent
+     render template: 'widgets/metadata'
+   end
+ end",How does this controller_name method work? Does this method grab the context of the url request? Wouldn't this always result in 'widget'?,Why do we need this?
+4451,"@@ -18,6 +18,9 @@
+  *  limitations under the License.
+  */
+ 
++#define FS_CHUNK_SIZE_DEBUG(op)  {flb_debug(""[%d] %s -> fs_chunks_size = %zu"", __LINE__, op->name, op->fs_chunks_size);}
++#define FS_CHUNK_SIZE_DEBUG_MOD(op, chunk, mod)  {flb_debug(""[%d] %s -> fs_chunks_size = %zu mod=%zd chunk=%s"", __LINE__, op->name, op->fs_chunks_size, mod, flb_input_chunk_get_name(chunk));}
++
+ #include <fluent-bit/flb_info.h>
+ #include <fluent-bit/flb_input.h>
+ #include <fluent-bit/flb_input_chunk.h>",Let's get rid of these for the final version and if you get rid of the macro I left last time I'd be more than grateful.,Why is this needed?
+4452,"@@ -36,6 +36,8 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 1, ""_file"", Types.StringType.get(), ""Path of the file in which a row is stored"");
+   public static final NestedField ROW_POSITION = NestedField.required(
+       Integer.MAX_VALUE - 2, ""_pos"", Types.LongType.get(), ""Ordinal position of a row in the source data file"");
++  public static final NestedField DELETE_MARK = NestedField.required(
++      Integer.MAX_VALUE - 3, ""_deleted"", Types.BooleanType.get(), ""Delete mark denotes whether row is deleted or not"");
+ 
+   // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+   public static final NestedField DELETE_FILE_PATH = NestedField.required(","Instead of `DELETE_MARK`, how about `IS_DELETED`? I don't think that ""mark"" is clear enough to describe what this is. Similarly, I think the docs should be ""Whether the row has been deleted"". There's no need to include ""delete mark"" because that's identifying something that is not defined (this column is _deleted and ""mark"" is not introduced), and ""or not"" is unnecessary because it is implied by ""whether"".","""Delete mark denotes whether a row is deleted or not"""
+4453,"@@ -179,6 +179,19 @@ def init_worker(checked_num, action_num):
+     progress_actions = action_num
+ 
+ 
++def get_dependent_headers(buildaction, archive):
++    LOG.debug(""Generating dependent headers via compiler..."")
++    try:
++        dependencies = set(create_dependencies(buildaction))
++    except Exception as ex:
++        LOG.debug(""Couldn't create dependencies:"")
++        LOG.debug(str(ex))
++        # TODO append with buildaction
++        archive.writestr(""no-sources"", str(ex))
++        dependencies = set()
++    return dependencies
++
++
+ def check(check_data):
+     """"""
+     Invoke clang with an action which called by processes.",Does it make sense to have this very thin wrapper that only calls `create_dependencies`? And maybe having `create_dependencies` return a set would be better than convert here?,I think this should be `LOG.exception(ex)`
+4454,"@@ -401,7 +401,7 @@ int h2o_get_compressible_types(const h2o_headers_t *headers)
+     return compressible_types;
+ }
+ 
+-h2o_iovec_t h2o_build_destination(h2o_req_t *req, const char *prefix, size_t prefix_len)
++h2o_iovec_t h2o_build_destination(h2o_req_t *req, const char *prefix, size_t prefix_len, int escape)
+ {
+     h2o_iovec_t parts[4];
+     size_t num_parts = 0;",How about renaming `escape` to `use_path_normalized` or something to better indicate that it is a selection between `path` and `path_normalized`?,`escape` is not used.
+4455,"@@ -41,4 +41,8 @@ public interface Accountable {
+     return Collections.emptyList();
+   }
+ 
++  /**
++   * An accountable that always returns 0
++   */
++  Accountable NULL_ACCOUNTABLE = () -> 0;
+ }",Interface members are always `static final` right?,Is this used anywhere?
+4456,"@@ -0,0 +1,17 @@
++// +build nintendoswitch
++
++package runtime
++
++import (
++	""unsafe""
++)
++
++// Result svcOutputDebugString(const char *str, u64 size)
++//go:export svcOutputDebugString
++func svcOutputDebugString(str *byte, size uint64) uint64
++
++//go:export malloc
++func extalloc(size uintptr) unsafe.Pointer
++
++//export free
++func extfree(ptr unsafe.Pointer)","It seems to me that this could be in the runtime_nintendoswitch.go file, or is there a reason to keep it separate?",`//go:export extalloc(size uintptr)`
+4457,"@@ -1857,8 +1857,6 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
+     log->PutCString(s.c_str());
+   }
+ 
+-  swift::performSILLinking(sil_module.get());
+-
+   if (m_swift_ast_context->HasErrors()) {
+     DiagnoseSwiftASTContextError();
+     return 1;",I was actually looking at this code over the weekend and wondering whether we were trying to link here. I assume it's been cargo culted from something else in the compiler.,Why did you remove this?
+4458,"@@ -0,0 +1,14 @@
++<div class=""form-group"">
++  <%= f.label _('Name'), for: :name, class: ""control-label"" %>
++  <%= f.text_field :name, as: :string, class: ""form-control"", 'data-toggle': 'tooltip', title: _('Add an appropriate name for your guidance group. This name will be used to tell the end user where the guidance has come from. It will be appended to text identifying the theme e.g. ""[guidance group name]: guidance on data sharing"" so we suggest you just use the institution or department name.'), 'aria-required': true %>
++</div>
++
++<div class=""checkbox"">
++  <%= f.label :published, raw(""#{f.check_box :published, 'data-toggle': 'tooltip', title: _('Check this box when you are ready for guidance associated with this group to appear on user\'s plans.')} #{_('Published')}"") %>
++</div>
++
++<div class=""checkbox"">
++  <%= f.label :optional_subset, raw(""#{f.check_box :optional_subset, 'data-toggle': 'tooltip', title: _('If the guidance is only meant for a subset of users e.g. those in a specific college or institute, check this box.  Users will be able to select to display this subset guidance when answering questions in the \'create plan\' wizard.')} #{_('Optional Subset (e.g. School/Department)')}"") %>
++</div>
++
++<%= f.submit _('Save'), class: 'btn btn-primary' %>",nice extraction of the form for being used at new/edit. We should have more of these,I think it would be better to use `_
+4459,"@@ -37,8 +37,8 @@ using namespace RDKit;
+  * Version 2 taken from J. Chem. Inf. Model. 56, 1 (2016)
+  *
+  * torsion-angle potential form:
+- * V = V1*(1 + s1*cos(1x)) + V2*(1 + s2*cos(2x)) + V3*(1 + s3*cos(1x))
+- *     + V4*(1 + s4*cos(1x)) + V5*(1 + s5*cos(1x)) + V6*(1 + s6*cos(1x))
++ * V = V1*(1 + s1*cos(1x)) + V2*(1 + s2*cos(2x)) + V3*(1 + s3*cos(3x))
++ *     + V4*(1 + s4*cos(4x)) + V5*(1 + s5*cos(5x)) + V6*(1 + s6*cos(6x))
+  *
+  * format: [SMARTS, s1, V1, s2, V2, s3, V3, s4, V4, s5, V5, s6, V6]
+  */",Are the coefficients the actual bug fix?,Why did you change this?
+4460,"@@ -218,8 +218,8 @@ class PostgresTarget(luigi.Target):
+ 
+         try:
+             cursor.execute(sql)
+-        except psycopg2.ProgrammingError as e:
+-            if e.pgcode == psycopg2.errorcodes.DUPLICATE_TABLE:
++        except (psycopg2.ProgrammingError, psycopg2.IntegrityError) as e:
++            if e.pgcode in [psycopg2.errorcodes.DUPLICATE_TABLE, psycopg2.errorcodes.UNIQUE_VIOLATION]:
+                 pass
+             else:
+                 raise",Why are the error code options in a list and not a tuple?,I don't think we need to catch IntegrityError here.
+4461,"@@ -135,7 +135,7 @@ class ExternalProjectAccessRuleBookTest(ForsetiTestCase):
+     TEST_ANCESTORS = [Project('123'),
+                       Folder('456'),
+                       Organization('7890')]
+-    TEST_BAD_ANC = [Project('123'),
++    TEST_BAD_ANCESTORS = [Project('123'),
+                     Folder('456'),
+                     Organization('ABC')]
+ ",Need alignment with the preceding line.,Why was this changed?
+4462,"@@ -28,10 +28,8 @@ public class MainnetProtocolSchedule {
+ 
+   public static final BigInteger DEFAULT_CHAIN_ID = BigInteger.ONE;
+ 
+-  public static ProtocolSchedule create() {
+-    return fromConfig(
+-        GenesisConfigFile.mainnet().getConfigOptions(), PrivacyParameters.DEFAULT, false);
+-  }
++  public static final ProtocolSchedule DEFAULT =
++      fromConfig(GenesisConfigFile.getMainnetConfigOptions(), PrivacyParameters.DEFAULT, false);
+ 
+   /**
+    * Create a Mainnet protocol schedule from a config object","Changing from a static method to a constant is inessential to Type Transactions and has a long reach, adding many unneeded files and diff lines.",Why is this change needed?
+4463,"@@ -92,13 +92,14 @@ public final class TreeSet<T> implements SortedSet<T>, Serializable {
+ 
+     public static <T extends Comparable<? super T>> TreeSet<T> ofAll(java.lang.Iterable<? extends T> values) {
+         Objects.requireNonNull(values, ""values is null"");
+-        return new TreeSet<>(RedBlackTree.ofAll(values));
++        return values.iterator().hasNext() ? new TreeSet<>(RedBlackTree.ofAll(values)) : empty();
+     }
+ 
++    @SuppressWarnings(""unchecked"")
+     public static <T> TreeSet<T> ofAll(Comparator<? super T> comparator, java.lang.Iterable<? extends T> values) {
+         Objects.requireNonNull(comparator, ""comparator is null"");
+         Objects.requireNonNull(values, ""values is null"");
+-        return new TreeSet<>(RedBlackTree.ofAll(comparator, values));
++        return values.iterator().hasNext() ? new TreeSet<>(RedBlackTree.ofAll(comparator, values)) : (TreeSet<T>) empty();
+     }
+ 
+     /**","There is one caveat: javaslang.collection.Iterator is Iterable. With Iterator it does not work. Let's revert this line. Does this happen elsewhere, too? I will double-check the code...",Why is this needed?
+4464,"@@ -659,7 +659,7 @@ class SimpleConfig(Logger):
+             except:
+                 pass
+ 
+-    def format_amount(self, x, is_diff=False, whitespaces=False):
++    def format_amount(self, x, is_diff = True, whitespaces = False, add_thousands_sep = True):
+         return format_satoshis(
+             x,
+             num_zeros=self.num_zeros,",Why change the default value of `is_diff`?,`add_thousands_sep` doesn't seem to be used?
+4465,"@@ -37,7 +37,7 @@ readme_note = """"""
+ with open('README.rst') as fobj:
+     long_description = ""\n\n"" + readme_note + ""\n\n"" + fobj.read()
+ 
+-install_requires = ['python-dateutil>=2.7.5,<3']
++install_requires = ['python-dateutil>=2.7.5,<3', 'tenacity>=6.3.0']
+ 
+ # Can't use python-daemon>=2.2.0 if on windows
+ #     See https://pagure.io/python-daemon/issue/18","I think tacking on `,<7` would be a wise precaution in case of future incompatible changes in tenacity.",I don't think we need this anymore.
+4466,"@@ -38,7 +38,7 @@ final class NoDriverManager implements GalleryManagerInterface, MediaManagerInte
+      * @param int|null $limit
+      * @param int|null $offset
+      */
+-    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null): array
++    public function findBy(array $criteria, ?array $orderBy = null, $limit = null, $offset = null)
+     {
+         throw new NoDriverException();
+     }",I don't think is necessary to remove the return type,Why did you remove the return type?
+4467,"@@ -128,7 +128,11 @@ public class AuthenticatorService extends Service {
+             final String userId = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_USER_ID), passcodeHash);
+             final String orgId = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_ORG_ID), passcodeHash);
+             final String username = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_USERNAME), passcodeHash);
+-            final String clientSecret = ForceApp.decryptWithPasscode(mgr.getUserData(account, AuthenticatorService.KEY_CLIENT_SECRET), passcodeHash);
++            final String encClientSecret = mgr.getUserData(account, AuthenticatorService.KEY_CLIENT_SECRET);
++            String clientSecret = null;
++            if (encClientSecret != null) {
++                clientSecret = ForceApp.decryptWithPasscode(encClientSecret, passcodeHash);
++            }
+             final Bundle resBundle = new Bundle();
+             try {
+                 final TokenEndpointResponse tr = OAuth2.refreshAuthToken(HttpAccess.DEFAULT, new URI(loginServer), clientId, refreshToken, clientSecret);","Also added this check, since client secret is not used except in the IP bypass scenario.",I think this should be `clientSecret = encCl
+4468,"@@ -151,6 +151,8 @@ const baseActions = {
+ 				return;
+ 			}
+ 
++			// Clear any profile ID selection in the case that selection falls to the getProfiles resolver.
++			registry.dispatch( STORE_NAME ).setProfileID( '' );
+ 			registry.dispatch( STORE_NAME ).setPropertyID( propertyID );
+ 
+ 			if ( PROPERTY_CREATE === propertyID ) {","That's unrelated, but shouldn't there also be a call to `setInternalWebPropertyID`, making it empty, for this case? Otherwise, when selecting to create a new property, any previous internal web property ID will still be in state, potentially causing problems.",I'm not sure if this is the right place to clear the profile ID. I think it would be better to clear the profile ID when the property is created.
+4469,"@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
+ 		out, err := system.RunCommand(DdevBin, args)
+ 		assert.NoError(err)
+ 		assert.Contains(string(out), ""Server started"")
+-		assert.Contains(string(out), ""GET"")
+ 
+ 		cleanup()
+ 	}",I wonder if we should trigger a PHP error and ensure it ends up in the log?,Why was this removed?
+4470,"@@ -247,6 +247,16 @@ describe TopicsController do
+     topic.closed.must_equal false
+   end
+ 
++  # TODO: Will need to figure out how javascript will affect the testing. 
++  it 'admin can get to move_topic page' do
++    login_as admin
++    get :move_topic, id: topic.id 
++    must_respond_with :success
++    must_render_template 'topics/move'
++  end
++
++  # TODO: This test is off, verify the behavior
++  # TODO: Will need to figure out how javascript will affect the testing. 
+   it 'admin can move a topic' do
+     different_topic = create(:topic)
+     login_as admin",The `move_topic` action be a `post` request since it changes the state of the object.,"This test is off, verify the behavior"
+4471,"@@ -366,6 +366,9 @@ func doTestResults(tid int, state *core.BuildState, target *core.BuildTarget, ru
+ 
+ 	if runRemotely {
+ 		metadata, err = state.RemoteClient.Test(tid, target, run)
++		if metadata == nil {
++			metadata = new(core.BuildMetadata)
++		}
+ 	} else {
+ 		var stdout []byte
+ 		stdout, err = prepareAndRunTest(tid, state, target, run)",Should we just return a non-nil metadata from `Test`?,Why do we need this?
+4472,"@@ -15,6 +15,10 @@ class MailPreview < MailView
+     CommunicartMailer.comment_added_email(comment, email)
+   end
+ 
++  def whsc_email
++    CommunicartMailer.cart_notification_email(email, pending_approval)
++  end
++
+ 
+   private
+ ",Noticing this is really just the same as cart_notification_email. Would be nice to be able to view custom templates. I may update this with some set up that will make viewing specific custom emails easily.,Extra empty line detected at class body end.
+4473,"@@ -59,13 +59,8 @@ import static org.apache.solr.common.cloud.ZkStateReader.PULL_REPLICAS;
+ import static org.apache.solr.common.cloud.ZkStateReader.READ_ONLY;
+ import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR;
+ import static org.apache.solr.common.cloud.ZkStateReader.TLOG_REPLICAS;
+-import static org.apache.solr.common.params.CollectionAdminParams.ALIAS;
+-import static org.apache.solr.common.params.CollectionAdminParams.COLL_CONF;
+-import static org.apache.solr.common.params.CollectionAdminParams.COUNT_PROP;
+-import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_PARAM;
+-import static org.apache.solr.common.params.CollectionAdminParams.CREATE_NODE_SET_SHUFFLE_PARAM;
+-import static org.apache.solr.common.params.CollectionAdminParams.ROUTER_PREFIX;
+-import static org.apache.solr.common.params.CollectionAdminParams.SKIP_NODE_ASSIGNMENT;
++import static org.apache.solr.common.params.CollectionAdminParams.*;
++import static org.apache.solr.common.params.CollectionAdminParams.COLOCATED_WITH;
+ 
+ /**
+  * This class is experimental and subject to change.",please don't use wildcard imports,Please don't use wildcard imports.
+4474,"@@ -219,6 +219,8 @@ describe('Formulas general', () => {
+   });
+ 
+   it('should recalculate table after changing cell value (by reference)', () => {
++    let sourceDataReference = null;
++
+     const afterChange = jasmine.createSpy();
+     const hot = handsontable({
+       data: getDataSimpleExampleFormulas(),",Should we even fix this test? IMO it should be refactored to check that values are recalculated after `setSourceDataAtCell` and `setSourceDataAtRowProp` calls. This will be the correct way to alter the data since now and we're not testing this use case.,Why do we need this?
+4475,"@@ -46,11 +46,6 @@ class ModelRole(enum.IntEnum):
+ 
+     item = Qt.UserRole
+ 
+-
+-# Remember the last used directory
+-last_used_directory = None
+-
+-
+ # All REFRESH_INTERVAL milliseconds, speeds will be recalculated and downloads
+ # redrawn.
+ _REFRESH_INTERVAL = 500","I'm not sure if this is standard practice, but I would prefer to leave this initialization here, if only to show that such a variable exists in this file (instead of inferring it from the globals). It can also cause weird issues if, for example, `init` isn't run before other methods.",Why did you remove this?
+4476,"@@ -353,6 +353,7 @@ RDKit::SparseIntVect<boost::uint32_t> *MorganFingerprintHelper(
+     res = RDKit::MorganFingerprints::getFingerprint(
+         mol, static_cast<unsigned int>(radius), invars, froms, useChirality,
+         useBondTypes, useCounts, false, bitInfoMap);
++          throw ""Value of nbits is Negative""
+   } else {
+     res = RDKit::MorganFingerprints::getHashedFingerprint(
+         mol, static_cast<unsigned int>(radius),",This isn't how you throw an exception in C++. I'd suggest you take a look elsewhere in the RDKit C++ codebase and see how ValueError exceptions are thrown. Hint: there's a function called `throw_value_error()` that you may find useful.,Shouldn't this be an assert instead?
+4477,"@@ -662,7 +662,7 @@ TEST (active_transactions, restart_dropped)
+ 	}
+ 	// Verify the block was updated in the ledger
+ 	{
+-		auto block (node.store.block_get (node.store.tx_begin_read (), send1->hash ()));
++		auto block (node.store.block_get (node.store.tx_begin_write (), send1->hash ()));
+ 		ASSERT_EQ (work2, block->block_work ());
+ 	}
+ 	// Drop election",Was changing this to a write transaction required?,`tx_begin_write` should be `tx_begin
+4478,"@@ -21,7 +21,8 @@ type Predicate struct {
+ 	Method string `json:""method""`
+ 
+ 	// Params are the parameters (or a subset of the parameters) used to call the actor method.
+-	Params []byte `json:""params""`
++	// The must all be individually abi encodable.
++	Params []interface{} `json:""params""`
+ }
+ 
+ // PaymentVoucher is a voucher for a payment channel that can be transferred off-chain but guarantees a future payment.","nit: I think ""They""?",Why is this change needed?
+4479,"@@ -0,0 +1,7 @@
++namespace Nethermind.Core2
++{
++    public static class SszLimit
++    {
++        public const ulong ValidatorRegistryLimit = 1_099_511_627_776;
++    }
++}",is it a result of some multiplication or some other meaningful number? would be nice to display as a power of something or the mult,This should be `1_099_511_627_776`
+4480,"@@ -5,11 +5,11 @@ module Features
+       forum
+       office_hours
+       shows
+-      source_code
+-      video_tutorials
+     )
++    LICENSEABLE_FEATURES = %w(repositories video_tutorials)
+     FULFILLABLE_FEATURES = %w(mentor)
+-    ALL_FEATURES = GENERIC_FEATURES + FULFILLABLE_FEATURES
++    ALL_FEATURES = GENERIC_FEATURES + LICENSEABLE_FEATURES +
++      FULFILLABLE_FEATURES
+ 
+     def initialize(user:)
+       @user = user","I think this class is a good example of where Payload could significantly improve things. I'm okay with this class as it stands. If you merge this in, I'd like to have a go at refactoring it after introducing Payload.",I don't think we need this anymore.
+4481,"@@ -2,6 +2,7 @@
+ from __future__ import unicode_literals
+ import unittest
+ import os
++import pytest
+ 
+ import colander
+ import mock","Just a small tip: I think you don't need to include pytest here. You can run tests using: - `pytest tests/path/to/my/test` under the virtualenv to run a single test. - `pytest tests/` under the virtualenv to run all the tests. - `make tests` to run all the tests for all python versions, like travis do. Hope this helps! :)",F401 'pytest' imported but unused
+4482,"@@ -31,6 +31,15 @@ from .options import Store
+ from .util import unique_iterator, group_sanitizer, label_sanitizer
+ 
+ 
++def sanitizer(name, replacements={':':'_', '/':'_', '\\':'_'}):
++    """"""
++    String sanitizer to avoid problematic characters in filenames.
++    """"""
++    for k,v in replacements.items():
++        name = name.replace(k,v)
++    return name
++
++
+ class Reference(param.Parameterized):
+     """"""
+     A Reference allows access to an object to be deferred until it is",Might be worth sorting the replacement items so this is deterministic.,Why do we need this?
+4483,"@@ -29,6 +29,11 @@ type ChaosDashboardConfig struct {
+ 	EnableLeaderElection bool   `envconfig:""ENABLE_LEADER_ELECTION""`
+ 	Database             *DatabaseConfig
+ 	PersistTTL           *PersistTTLConfig
++	// ClusterScoped means control Chaos Object in cluster level(all namespace),
++	ClusterScoped bool `envconfig:""CLUSTER_SCOPED"" default:""true""`
++	// TargetNamespace is the target namespace to injecting chaos.
++	// It only works with ClusterScoped is false;
++	TargetNamespace string `envconfig:""TARGET_NAMESPACE"" default:""""`
+ }
+ 
+ // PersistTTLConfig defines the configuration of ttl",Should we set the default `TargetNamespace ` to `chaos-testing`? I noticed that the installation script defaults to chaos-testing.,Why is this a string?
+4484,"@@ -31,7 +31,6 @@ namespace MvvmCross.ViewModels
+         {
+             try
+             {
+-                await Task.Yield();
+                 await task;
+             }
+             catch(Exception e)",Why was this `Task.Yield` removed? It was added in purpose.,Why was this removed?
+4485,"@@ -162,8 +162,13 @@ public abstract class DiscoGapicMethodConfig extends MethodConfig {
+     }
+ 
+     Iterable<FieldConfig> requiredFieldConfigs =
+-        DiscoGapicMethodConfig.createFieldNameConfigs(
+-            DiscoGapicMethodConfig.getRequiredFields(
++        createFieldNameConfigs(
++            diagCollector,
++            messageConfigs,
++            defaultResourceNameTreatment,
++            fieldNamePatterns,
++            resourceNameConfigs,
++            getRequiredFields(
+                 diagCollector, methodModel, methodConfigProto.getRequiredFieldsList()));
+ 
+     Iterable<FieldConfig> optionalFieldConfigs =","You'll also want to do this below, for the `optionalFieldConfigs`. See `GapicMethodConfig.java:180`.",I don't think we need
+4486,"@@ -134,7 +134,8 @@ Status GoExecutor::prepareOver() {
+         if (clause == nullptr) {
+             LOG(FATAL) << ""Over clause shall never be null"";
+         }
+-        edge_ = ectx()->schemaManager()->toEdgeType(*clause->edge());
++        auto space = ectx()->rctx()->session()->space();
++        edge_ = ectx()->schemaManager()->toEdgeType(space, *clause->edge());
+         reversely_ = clause->isReversely();
+         if (clause->alias() != nullptr) {
+             expCtx_->addAlias(*clause->alias(), AliasKind::Edge, *clause->edge());","We'd better use ""spaceId"" as variable name here. Because i can't figure out the really type for ""space"" at the first glimpse due to ""auto"" used.",Why do we need this c
+4487,"@@ -37,6 +37,7 @@ partial class Build
+     AbsolutePath ArtifactsDirectory => Artifacts ?? (OutputDirectory / ""artifacts"");
+     AbsolutePath WindowsTracerHomeZip => ArtifactsDirectory / ""windows-tracer-home.zip"";
+     AbsolutePath BuildDataDirectory => RootDirectory / ""build_data"";
++    AbsolutePath LibSqreenDirectory => RootDirectory / ""packages"" / ""libsqreen.1.1.2.2"";
+ 
+     AbsolutePath SourceDirectory => RootDirectory / ""src"";
+     AbsolutePath TestsDirectory => RootDirectory / ""test"";",I assume we have a package reference somewhere that pulls down the nuget package?,Should this be `packa
+4488,"@@ -575,12 +575,9 @@ func (s *Server) initEventTracking() {
+ 	}
+ 	s.sys.inboxPre = subject
+ 	// This is for remote updates for connection accounting.
+-
+-	for _, subj := range []string{accConnsEventSubjOld, accConnsEventSubjNew} {
+-		subject = fmt.Sprintf(subj, ""*"")
+-		if _, err := s.sysSubscribe(subject, s.remoteConnsUpdate); err != nil {
+-			s.Errorf(""Error setting up internal tracking for %s: %v"", subject, err)
+-		}
++	subject = fmt.Sprintf(accConnsEventSubjOld, ""*"")
++	if _, err := s.sysSubscribe(subject, s.remoteConnsUpdate); err != nil {
++		s.Errorf(""Error setting up internal tracking for %s: %v"", subject, err)
+ 	}
+ 	// This will be for responses for account info that we send out.
+ 	subject = fmt.Sprintf(connsRespSubj, s.info.ID)","But why introduce publish on `accConnsEventSubjNew` subject if we never subscribe on that subject. What is the plan then? Replace subscription on ""old"" with ""new"" at one point? Not sure about all that..",Why is this change needed?
+4489,"@@ -269,7 +269,7 @@ void *ap6_thread(void *thread_context)
+ 	int ret;
+ 	struct timespec ts = { .tv_sec = 0, .tv_nsec = 100000 }; /* 100ms */
+ 
+-	fpga_token fme_token;
++	fpga_token fme_token = NULL;
+ 	fpga_handle fme_handle;
+ 	fpga_properties filter;
+ 	fpga_result res;",can we use `nullptr` for consistency?,Why this change?
+4490,"@@ -38,7 +38,7 @@ class DomainRouterFactory
+     protected $routerConfiguration;
+ 
+     /**
+-     * @var \Symfony\Component\Routing\Router[]
++     * @var \Shopsys\FrameworkBundle\Component\Router\DomainRouter[]
+      */
+     protected $routersByDomainId = [];
+ ","strange, for templating\EngineBundle it was `\Symfony\Bundle\FrameworkBundle\`",This should be reverted.
+4491,"@@ -1545,7 +1545,7 @@ ostree_sysroot_simple_write_deployment (OstreeSysroot      *sysroot,
+           g_ptr_array_add (new_deployments, g_object_ref (deployment));
+         }
+ 
+-      if (!added_new)
++      if ((!added_new) && is_merge_or_booted)
+         {
+           g_ptr_array_add (new_deployments, g_object_ref (new_deployment));
+           added_new = TRUE;","But if we're on the merge deployment, and the next one is the booted deployment, we'll still be inserting between the merge and booted deployment, right? It seems like we would need e.g. `met_merge` and `met_booted` vars to keep track.",I think this should be `if
+4492,"@@ -1,3 +1,7 @@
+-return !axe.commons.aria.isValidRole(node.getAttribute('role'), {
+-	allowAbstract: true
+-});
++return (
++	axe.utils.tokenList(virtualNode.attr('role')).filter(role => {
++		return !axe.commons.aria.isValidRole(role, {
++			allowAbstract: true
++		});
++	}).length > 0
++);","Can you put the output of this into data, and list which roles are invalid? Same thing with abstract role. I know that's not strictly part of this PR, but it'd make the messaging about this a bunch better.",I don't think you need the `.length > 0` check.
+4493,"@@ -20,15 +20,15 @@ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.tests.acceptance.dsl.WaitUtils;
+ import org.hyperledger.besu.tests.acceptance.dsl.condition.Condition;
+ import org.hyperledger.besu.tests.acceptance.dsl.node.Node;
+-import org.hyperledger.besu.tests.acceptance.dsl.transaction.ibft2.Ibft2Transactions;
++import org.hyperledger.besu.tests.acceptance.dsl.transaction.bft.BftTransactions;
+ 
+ import java.util.Map;
+ 
+ public class ExpectProposals implements Condition {
+-  private final Ibft2Transactions ibftTwo;
++  private final BftTransactions ibftTwo;
+   private final Map<Address, Boolean> proposers;
+ 
+-  public ExpectProposals(final Ibft2Transactions ibftTwo, final Map<Address, Boolean> proposers) {
++  public ExpectProposals(final BftTransactions ibftTwo, final Map<Address, Boolean> proposers) {
+     this.ibftTwo = ibftTwo;
+     this.proposers = proposers;
+   }",rename ibftTwo arg to bft,Why do we need this change?
+4494,"@@ -38,7 +38,7 @@ module Blacklight::SearchContext
+   end
+ 
+   def find_search_session
+-    if agent_is_crawler?
++    if agent_is_crawler? || skip_session_tracking?
+       nil
+     elsif params[:search_context].present?
+       find_or_initialize_search_session_from_params JSON.parse(params[:search_context])",Should we go ahead and push `agent_is_crawler?` into the `skip_session_tracking?` method?,Should this be `||` instead of `||`?
+4495,"@@ -88,8 +88,11 @@ class CustomDataset(Dataset):
+                 self.proposal_file = osp.join(self.data_root,
+                                               self.proposal_file)
+         # load annotations (and proposals)
+-        with self.file_client.get_local_path(self.ann_file) as local_path:
+-            self.data_infos = self.load_annotations(local_path)
++        try:
++            with self.file_client.get_local_path(self.ann_file) as local_path:
++                self.data_infos = self.load_annotations(local_path)
++        except AttributeError:
++            raise AttributeError('Please upgrade mmcv to >= 1.3.16')
+ 
+         if self.proposal_file is not None:
+             with self.file_client.get_local_path(",How about we raise a warning here and simply change to use self.data_infos = self.load_annotations(self.ann_file),I don't think this should be a `AttributeError`
+4496,"@@ -1,9 +1,9 @@
+ # -*- coding: UTF-8 -*-
+-#synthDrivers/_espeak.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2007-2017 NV Access Limited, Peter Vágner
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# synthDrivers/_espeak.py
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2007-2020 NV Access Limited, Peter Vágner
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+ 
+ import time
+ import nvwave",Please remove this line to comply with the standard for copyright headers.,Why did you change the year?
+4497,"@@ -21,6 +21,9 @@ namespace Nethermind.Consensus.AuRa.Validators
+ {
+     internal static class AuRaValidatorsCollectionExtensions
+     {
+-        public static int MinSealersForFinalization(this IList<Address> validators) => validators.Count / 2 + 1;
++        public static int MinSealersForFinalization(this IList<Address> validators, bool twoThirds = false)
++        {
++            return (twoThirds ? validators.Count * 2 / 3 : validators.Count / 2) + 1;
++        }
+     }
+ }",seems incorrect - for 5 validators it will tell that 3 is enough to seal and you need 4 2/3 * 5 is 3.3,`twoThirds ? validators.Coun
+4498,"@@ -19,11 +19,16 @@
+ 
+ package org.apache.iceberg.hive;
+ 
+-import java.io.Closeable;
+-import java.util.Arrays;
++
++import com.github.benmanes.caffeine.cache.Cache;
++import com.github.benmanes.caffeine.cache.Caffeine;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.Set;
++import java.util.concurrent.Executors;
++import java.util.concurrent.ScheduledExecutorService;
++import java.util.concurrent.ScheduledFuture;
++import java.util.concurrent.TimeUnit;
+ import java.util.stream.Collectors;
+ import org.apache.hadoop.conf.Configurable;
+ import org.apache.hadoop.conf.Configuration;",Nit: please remove unnecessary whitespace changes.,I don't think we need this i
+4499,"@@ -73,9 +73,16 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
+ 
+     List<SampleFieldView> fields = new ArrayList<>();
+     for (FieldInfo field : methodInfo.fields().values()) {
++      String name = field.name();
++      // Since the requestBody is named `resource`, all fields named `resource`
++      // are renamed by the Node.js client library generator to `resource_`.
++      if (name.equals(""resource"")) {
++        name = ""resource_"";
++      }
++
+       fields.add(
+           SampleFieldView.newBuilder()
+-              .name(field.name())
++              .name(name)
+               .defaultValue(typeTable.getZeroValueAndSaveNicknameFor(field.type()))
+               .example(field.example())
+               .description(field.description())",Is this captured in a test?,Why is this needed?
+4500,"@@ -38,9 +38,10 @@ import org.apache.lucene.search.MaxScoreAccumulator.DocAndScore;
+  */
+ public abstract class TopScoreDocCollector extends TopDocsCollector<ScoreDoc> {
+ 
+-  abstract static class ScorerLeafCollector implements LeafCollector {
++  /** Scorable leaf collector */
++  public abstract static class ScorerLeafCollector implements LeafCollector {
+ 
+-    Scorable scorer;
++    protected Scorable scorer;
+ 
+     @Override
+     public void setScorer(Scorable scorer) throws IOException {",This is used in o.a.l.sandbox.search.LargeNumHitsTopDocsCollector.,why is this needed?
+4501,"@@ -1,11 +1,11 @@
+ # optimizer
+ optimizer = dict(type='SGD', lr=0.02, momentum=0.9, weight_decay=0.0001)
+-optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
++optimizer_config = dict(grad_clip=None)
+ # learning policy
+ lr_config = dict(
+     policy='step',
+     warmup='linear',
+     warmup_iters=500,
+-    warmup_ratio=1.0 / 3,
++    warmup_ratio=1.0 / 1000,
+     step=[8, 11])
+ total_epochs = 12",We may also do the same for `schedule_2x.py` and `schedule_20e.py`.,why did you change 
+4502,"@@ -4,6 +4,7 @@ class User < ActiveRecord::Base
+   has_many :traces, -> { where(:visible => true) }
+   has_many :diary_entries, -> { order(:created_at => :desc) }
+   has_many :diary_comments, -> { order(:created_at => :desc) }
++  has_and_belongs_to_many :diary_entries_subscriptions, :class_name => ""DiaryEntry"", :join_table => ""diary_entries_subscribers"", :foreign_key => ""subscriber_id""
+   has_many :messages, -> { where(:to_user_visible => true).order(:sent_on => :desc).preload(:sender, :recipient) }, :foreign_key => :to_user_id
+   has_many :new_messages, -> { where(:to_user_visible => true, :message_read => false).order(:sent_on => :desc) }, :class_name => ""Message"", :foreign_key => :to_user_id
+   has_many :sent_messages, -> { where(:from_user_visible => true).order(:sent_on => :desc).preload(:sender, :recipient) }, :class_name => ""Message"", :foreign_key => :from_user_id","Should foreign key here be something like `diary_entry_id`? Or above, in `diary_entry.rb`, it should be `diary_entry_id`?",Use the new Ruby 1.
+4503,"@@ -54,12 +54,13 @@ type (
+ 		namespaceEntry          *cache.NamespaceCacheEntry
+ 
+ 		// internal state
+-		hasBufferedEvents           bool
+-		failWorkflowTaskInfo        *failWorkflowTaskInfo
+-		activityNotStartedCancelled bool
+-		continueAsNewBuilder        mutableState
+-		stopProcessing              bool // should stop processing any more commands
+-		mutableState                mutableState
++		hasBufferedEvents                 bool
++		failWorkflowTaskInfo              *failWorkflowTaskInfo
++		activityNotStartedCancelled       bool
++		continueAsNewBuilder              mutableState
++		stopProcessing                    bool // should stop processing any more commands
++		mutableState                      mutableState
++		initiatedChildExecutionsInSession map[string]struct{} // Set of initiated child executions in the workflow task
+ 
+ 		// validation
+ 		attrValidator    *commandAttrValidator",session is a new term. Should we call more like currentCommandBatch or something else?,I don't think we ne
+4504,"@@ -514,7 +514,7 @@ func (s *namespaceHandlerGlobalNamespaceEnabledNotMasterClusterSuite) TestUpdate
+ 	_, err := s.MetadataManager.CreateNamespace(&persistence.CreateNamespaceRequest{
+ 		Namespace: &persistenceblobs.NamespaceDetail{
+ 			Info: &persistenceblobs.NamespaceInfo{
+-				Id:          uuid.NewRandom(),
++		Id:          uuid.New(),
+ 				Name:        namespace,
+ 				Status:      namespacepb.NamespaceStatus_Registered,
+ 				Description: description,",Will go fmt before squash.,Why is this change needed?
+4505,"@@ -148,6 +148,7 @@ func DefaultConfig() Config {
+ 		DockerGraphPath:         ""/var/lib/docker"",
+ 		ReservedMemory:          0,
+ 		AvailableLoggingDrivers: []dockerclient.LoggingDriver{dockerclient.JsonFileDriver},
++		PrivilegedCapable:       true,
+ 	}
+ }
+ ","Setting this to `true` means that it will always get merged in. The way merging is done here is that if a value is its zero value (`false` for `bool`), the value is considered unchanged. In order for this to work, you'll need to change this to be a `*bool` type instead.",Why do we need this?
+4506,"@@ -101,7 +101,6 @@ func newDefaultBootstrapConfig() *BootstrapConfig {
+ // MiningConfig holds all configuration options related to mining.
+ type MiningConfig struct {
+ 	MinerAddress            address.Address `json:""minerAddress""`
+-	BlockSignerAddress      address.Address `json:""blockSignerAddress""`
+ 	AutoSealIntervalSeconds uint            `json:""autoSealIntervalSeconds""`
+ 	StoragePrice            *types.AttoFIL  `json:""storagePrice""`
+ }","It was decided that blockSignerAddress is not only redundant (use the miner owner public key instead which is already stored), but does not belong in config.",Why was this removed?
+4507,"@@ -70,6 +70,7 @@ setup(
+         'tenacity>=5.1.1',
+         'tqdm>=4.32',
+         'requests_futures==1.0.0',
++        'jsonschema==3.*',
+     ],
+     extras_require={
+         'pyarrow': [",are we not asking for trouble here by not pinning this? or does 3.* imply all of the draft versions we'd try to validate?,"'jsonschema>=3.0.0',"
+4508,"@@ -39,10 +39,8 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
+     results1 = createAndRunNetwork(TPRegion,
+                                    ""bottomUpOut"",
+                                    checkpointMidway=False,
+-                                   temporalImp=""tm_py"")
++                                   temporalImp=""tm_cpp"")
+ 
+-    # temporalImp=""tm_py"" here is a temporary placeholder value until C++ TM is
+-    # finished, at which point it should be changed to ""cpp""
+     results2 = createAndRunNetwork(TPRegion,
+                                    ""bottomUpOut"",
+                                    checkpointMidway=False,","No, we want to compare `tm_py` and `tm_cpp` in this test.",Why did you remove this?
+4509,"@@ -47,6 +47,9 @@ const (
+ 	// TODO(liu-cong) configurable timeout
+ 	decoupleSinkTimeout = 30 * time.Second
+ 
++	// Limit for request payload in bytes (100Mb)
++	maxRequestBodyBytes = 100000000
++
+ 	// EventArrivalTime is used to access the metadata stored on a
+ 	// CloudEvent to measure the time difference between when an event is
+ 	// received on a broker and before it is dispatched to the trigger function.",Let me know if we'd rather have this as an env variable.,Should this be configura
+4510,"@@ -80,10 +80,10 @@ func NewVaultServiceAccount(name string) *corev1.ServiceAccount {
+ 	}
+ }
+ 
+-func NewVaultServiceAccountRole(namespace string) *rbacv1.ClusterRole {
++func NewVaultServiceAccountRole(namespace, serviceAccountName string) *rbacv1.ClusterRole {
+ 	return &rbacv1.ClusterRole{
+ 		ObjectMeta: metav1.ObjectMeta{
+-			Name: fmt.Sprintf(""auth-delegator:%s:vault"", namespace),
++			Name: fmt.Sprintf(""auth-delegator:%s:%s"", namespace, serviceAccountName),
+ 		},
+ 		Rules: []rbacv1.PolicyRule{
+ 			{",question: what is happening here?,Why do we need this chan
+4511,"@@ -14,6 +14,8 @@ public abstract class AbstractSetTest extends AbstractTraversableRangeTest {
+     @Override
+     abstract protected <T> Set<T> empty();
+ 
++    abstract protected <T> Set<T> emptyWithNull();
++
+     @Override
+     abstract protected <T> Set<T> of(T element);
+ ",\[Checkstyle\] ERROR: 'protected' modifier out of order with the JLS suggestions\.,abstract protected Set<T
+4512,"@@ -4,6 +4,18 @@ const chai = require('chai');
+ const expect = chai.expect;
+ chai.use(require('chai-subset'));
+ 
++const EJSON = require('mongodb-extjson');
++const getKmsProviders = localKey => {
++  const result = EJSON.parse(process.env.CSFLE_KMS_PROVIDERS || 'NOT_PROVIDED');
++  if (localKey) {
++    result.local = { key: localKey };
++  }
++
++  return result;
++};
++
++const noop = () => {};
++
+ // Tests for the ClientEncryption type are not included as part of the YAML tests.
+ 
+ // In the prose tests LOCAL_MASTERKEY refers to the following base64:",Can we use EJSON from bson here? and in doing so avoid bringing in the deprecated `mongodb-extjson` lib `const { EJSON } = require('bson')`,Why do we need this?
+4513,"@@ -262,9 +262,6 @@ class GridPlot(CompositePlot):
+     show_legend = param.Boolean(default=False, doc=""""""
+         Legends add to much clutter in a grid and are disabled by default."""""")
+ 
+-    tick_format = param.String(default=""%.2f"", doc=""""""
+-        Formatting string for the GridPlot ticklabels."""""")
+-
+     xaxis = param.ObjectSelector(default='bottom',
+                                  objects=['bottom', 'top', None], doc=""""""
+         Whether and where to display the xaxis, supported options are",So this parameter is now deprecated?,Why is this removed?
+4514,"@@ -269,6 +269,7 @@ rseq_shared_fragment_flushtime_update(dcontext_t *dcontext)
+     rseq_clear_tls_ptr(dcontext);
+ }
+ 
++#ifdef HAVE_RSEQ
+ bool
+ rseq_is_registered_for_current_thread(void)
+ {","Actually, it looks like HAVE_RSEQ is only used to determine whether the rseq.h header is around, which then only determines whether the regression test is built: it does not affect whether the core handles an application using rseq. The core rseq mangling code and all the code in rseq_linux.c is always enabled. I believe the idea is that we want DR built on one machine to work on as many others as possible, rather than requiring a custom build for every variant of kernel feature or whatnot. What is the top-level problem being solved here? If it requires disabling or enabling the core handling rseq, probably a separate option should be put in place and maybe HAVE_RSEQ renamed to make it clearer what its consequences are.",Why is this needed?
+4515,"@@ -3,8 +3,7 @@ package cache
+ import (
+ 	""sync""
+ 
+-	""github.com/gofrs/uuid""
+-	""github.com/spiffe/spire/pkg/common/selector""
++	""github.com/spiffe/spire/proto/spire/common""
+ )
+ 
+ type Subscriber interface {",I don't see a corresponding call to freeSelectorSet... am I missing something?,File is not `goimpor
+4516,"@@ -2,13 +2,13 @@ require ""rails_helper""
+ 
+ describe AuthCallbacksController do
+   context '#create' do
+-    it 'redirects to the dashboard path without an auth origin' do
++    it 'redirects to the practice path without an auth origin' do
+       request.env['omniauth.auth'] = OmniAuth.config.mock_auth[:github]
+       request.env['omniauth.origin'] = nil
+ 
+       get :create, provider: 'github'
+ 
+-      should redirect_to(dashboard_url)
++      should redirect_to(practice_url)
+     end
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Should this be `practice_dashboard_url`?
+4517,"@@ -40,9 +40,10 @@ namespace OpenTelemetry.Trace
+         public const string HttpRouteKey = ""http.route"";
+         public const string HttpFlavorKey = ""http.flavor"";
+ 
+-        public const string DatabaseTypeKey = ""db.type"";
+-        public const string DatabaseInstanceKey = ""db.instance"";
++        public const string DatabaseSystemKey = ""db.system"";
++        public const string DatabaseNameKey = ""db.name"";
+         public const string DatabaseStatementKey = ""db.statement"";
++        public const string DatabaseStatementTypeKey = ""db.statement_type"";
+ #pragma warning restore CS1591 // Missing XML comment for publicly visible type or member
+     }
+ }",Is this part of spec?,Shouldn't this be `db.statement_type`?
+4518,"@@ -3725,6 +3725,18 @@ client_thread_run(void)
+     byte *xsp;
+     GET_STACK_PTR(xsp);
+     void *crec = get_clone_record((reg_t)xsp);
++    /* i#2335: we support setup separate from start, and we want to allow a client
++     * to create a client thread during init, but we do not support that thread
++     * executing until the app has started (b/c we have no signal handlers in place).
++     */
++    /* i#3973: in addition to _executing_ a client thread before the
++     * app has started, if we even create the thread before
++     * dynamo_initialized is set, we will not copy tls blocks.  By
++     * waiting for the app to be started before dynamo_thread_init is
++     * called, we ensure this race condition can never happen, since
++     * dynamo_initialized will always be set before the app is started.
++     */
++    wait_for_event(dr_app_started, 0);
+     IF_DEBUG(int rc =)
+     dynamo_thread_init(get_clone_record_dstack(crec), NULL, crec, true);
+     ASSERT(rc != -1); /* this better be a new thread */","Hmm, do we need to do this for Windows too? It won't have this private loader TLS issue but it will run DR code in a separate thread before DR init is fully done which I think violates some assumptions. For Windows we would move this wait from win32/os.c to win32/callback.s intercept_new_thread where it checks whether it's a client thread right before calling dynamo_thread_init. If you do not want to deal with Windows you could bail on my suggestion and leave the issue open (or maybe file a new issue) for Windows, or if you want to put the suggested core/win32/ change in place and your new test passes on Appveyor we could then claim to have fully solved this related issue too for all platforms.",I don't understand why we need to wait f
+4519,"@@ -840,3 +840,8 @@ def kinesis_get_latest_records(stream_name, shard_id, count=10, env=None):
+         while len(result) > count:
+             result.pop(0)
+     return result
++
++
++def get_lambda_name_from_arn(arn):
++    attributes = arn.split(':')
++    return attributes[-1]",We can remove this function and use `lambda_function_name(..)` in this file instead.,nit: `return attributes[-1]`
+4520,"@@ -17,10 +17,12 @@
+ 
+ package metrics
+ 
+-import ""time""
++import (
++	""time""
++)
+ 
+-// CreateSender creates metrics sender with appropriate transport
+-func CreateSender(disableMetrics bool, metricsAddress string) *Sender {
++// NewSender creates metrics sender with appropriate transport
++func NewSender(disableMetrics bool, metricsAddress, applicationVersion string) *Sender {
+ 	var transport Transport
+ 	if disableMetrics {
+ 		transport = NewNoopTransport()",nitpick: `ApplicationVersion` could be `AppVersion`. It's smaller but gives the same understanding for purposes of the field.,`applicationVersion` is not used.
+4521,"@@ -537,6 +537,9 @@ func (handler *DCRedirectionHandlerImpl) PollWorkflowTaskQueue(
+ 		return err
+ 	})
+ 
++	if resp == nil && err == nil {
++		return &workflowservice.PollWorkflowTaskQueueResponse{}, nil
++	}
+ 	return resp, err
+ }
+ ",nit: maybe prefer `resp = &workflowservice.PollWorkflowTaskQueueResponse{}` over adding another function exit points especially for non-error cases?,Why do we need this?
+4522,"@@ -107,6 +107,10 @@ module Mongoid
+     #
+     # @since 6.0.0
+     def client
++      client_options = send(:client_options)
++      if client_options[:read].is_a?(Symbol)
++        client_options = client_options.merge(read: {mode: client_options[:read]})
++      end
+       @client ||= (client = Clients.with_name(client_name)
+                     client = client.use(database_name) if database_name_option
+                     client.with(client_options))","Do we specifically need to keep the read preference as a symbol for use elsewhere? If not, I think it would be cleaner to just modify the options before caching them in the `client_options` method so that we don't do this check every time. If we do need it a a symbol elsewhere, I'd suggest either putting `return @client if @client` at the top of the method (and changing the assignment below from `||=` to `=`) or moving this within the parenthetical block in the last assignment so that we don't repeat this work.",Why do we need this?
+4523,"@@ -69,7 +69,8 @@ module.exports = class Webcam extends Plugin {
+         'picture'
+       ],
+       mirror: true,
+-      facingMode: 'user'
++      facingMode: 'user',
++      preferredMimeType: null
+     }
+ 
+     // merge default options with the ones set by user","Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option.",Why is this needed?
+4524,"@@ -398,6 +398,8 @@ static bool ImageLayoutMatches(const VkImageAspectFlags aspect_mask, VkImageLayo
+ 
+ // Utility type for ForRange callbacks
+ struct LayoutUseCheckAndMessage {
++    using LayoutEntry = image_layout_map::ImageSubresourceLayoutMap::LayoutEntry;
++    using RangeGenerator = image_layout_map::ImageSubresourceLayoutMap::LayoutEntry;
+     const static VkImageAspectFlags kDepthOrStencil = VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT;
+     const ImageSubresourceLayoutMap *layout_map;
+     const VkImageAspectFlags aspect_mask;",That doesn't make sense. LayoutEntry doesn't match the generator concept.,Why do we need this?
+4525,"@@ -284,7 +284,7 @@ func TestAppDeployOpts_getAppDockerfilePath(t *testing.T) {
+ 
+ 	mockError := errors.New(""mockError"")
+ 	mockManifest := []byte(`name: appA
+-type: 'Load Balanced Web App'
++type: 'Load Balanced Web Svc'
+ image:
+   build: appA/Dockerfile
+ `)","I think the customer visible strings should be ""Service"" instead of ""Svc"" to make it obvious to them",Why did you change t
+4526,"@@ -108,13 +108,13 @@ public class JavaProcessJobTest {
+     props.put(AbstractProcessJob.WORKING_DIR, workingDir.getCanonicalPath());
+     props.put(""type"", ""java"");
+     props.put(""fullPath"", ""."");
+-    
++
+     props.put(CommonJobProperties.PROJECT_NAME, ""test_project"");
+     props.put(CommonJobProperties.FLOW_ID, ""test_flow"");
+     props.put(CommonJobProperties.JOB_ID, ""test_job"");
+     props.put(CommonJobProperties.EXEC_ID, ""123"");
+     props.put(CommonJobProperties.SUBMIT_USER, ""test_user"");
+-    
++    props.put(""execute.as.user"", ""false"");
+ 
+     job = new JavaProcessJob(""testJavaProcess"", props, props, log);
+   }",Explain why this property is necessary?,Why do we need this 
+4527,"@@ -141,7 +141,8 @@ func securityDeposit(ps *EVMParams, stateDB vm.StateDB, gasLimit *uint64) error
+ func ExecuteContracts(blk *Block, ws state.WorkingSet, bc Blockchain) {
+ 	gasLimit := GasLimit
+ 	blk.receipts = make(map[hash.Hash32B]*Receipt)
+-	for idx, execution := range blk.Executions {
++	_, _, executions := action.ClassifyActions(blk.Actions)
++	for idx, execution := range executions {
+ 		// TODO (zhi) log receipt to stateDB
+ 		if receipt, _ := executeContract(blk, ws, idx, execution, bc, &gasLimit); receipt != nil {
+ 			blk.receipts[execution.Hash()] = receipt",It should accept executions as the input,Why do we need to do
+4528,"@@ -25,7 +25,10 @@ def single_gpu_test(model,
+         with torch.no_grad():
+             result = model(return_loss=False, rescale=True, **data)
+ 
++        batch_size = len(result)
+         if show or out_dir:
++            assert batch_size == 1, 'show or out during test only support ' \
++                                    'batch size of 1'
+             img_tensor = data['img'][0]
+             img_metas = data['img_metas'][0].data[0]
+             imgs = tensor2imgs(img_tensor, **img_metas[0]['img_norm_cfg'])",Is this limitation necessary?,Why do we need this assert?
+4529,"@@ -81,9 +81,13 @@ type IssuerSpec struct {
+ }
+ 
+ type IssuerConfig struct {
+-	ACME  *ACMEIssuer  `json:""acme,omitempty""`
+-	CA    *CAIssuer    `json:""ca,omitempty""`
+-	Vault *VaultIssuer `json:""vault,omitempty""`
++	ACME       *ACMEIssuer       `json:""acme,omitempty""`
++	CA         *CAIssuer         `json:""ca,omitempty""`
++	Vault      *VaultIssuer      `json:""vault,omitempty""`
++	SelfSigned *SelfSignedIssuer `json:""selfSigned,omitempty""`
++}
++
++type SelfSignedIssuer struct {
+ }
+ 
+ type VaultIssuer struct {",:question: Should there be validation to ensure that only one of these attributes is used?,Why do we need this?
+4530,"@@ -33,11 +33,11 @@
+  */
+ namespace VuFind\Search\Solr;
+ 
++use Interop\Container\ContainerInterface;
+ use Laminas\EventManager\EventInterface;
+-
+ use Laminas\EventManager\SharedEventManagerInterface;
+-use Laminas\ServiceManager\ServiceLocatorInterface;
+-use VuFindSearch\Backend\BackendInterface;
++
++use VuFindSearch\Backend\Solr\Backend;
+ 
+ /**
+  * Solr merged record handling listener.","I would recommend using Psr\Container\ContainerInterface here instead of Interop\Container\ContainerInterface; both currently work, but the Interop version is deprecated and will eventually be removed, so using the Psr version will save us time in the future.",Why did you remove the serv
+4531,"@@ -312,7 +312,7 @@ func TestLocalExec(t *testing.T) {
+ 		err = app.Exec(""web"", true, ""pwd"")
+ 		assert.NoError(err)
+ 		out := stdout()
+-		assert.Contains(out, ""/var/www/html/docroot"")
++		assert.Contains(out, ""/var/www/html"")
+ 
+ 		stdout = testcommon.CaptureStdOut()
+ 		switch app.GetType() {",This would also change back to /var/www/html/docroot if we go that way.,Why did this change?
+4532,"@@ -12,7 +12,7 @@ import info.nightscout.androidaps.MainApp;
+  */
+ 
+ public class SP {
+-    private static SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(MainApp.instance().getApplicationContext());
++    public static SharedPreferences sharedPreferences = PreferenceManager.getDefaultSharedPreferences(MainApp.instance().getApplicationContext());
+ 
+     static public Map<String, ?> getAll() {
+         return sharedPreferences.getAll();","Does this need to be public? Can't one of the helper functions below pass the data? If it really needs to be public, could it be write-protected?",Why did you make this public?
+4533,"@@ -216,11 +216,6 @@ func RunAPIAndWait(ctx context.Context, nd *node.Node, config *config.APIConfig,
+ }
+ 
+ func CreateServerEnv(ctx context.Context, nd *node.Node) *Env {
+-	var storageAPI *storage.API
+-	if nd.StorageProtocol != nil {
+-		storageAPI = storage.NewAPI(nd.StorageProtocol.StorageClient, nd.StorageProtocol.StorageProvider, nd.PieceManager())
+-	}
+-
+ 	return &Env{
+ 		blockMiningAPI: nd.BlockMining.BlockMiningAPI,
+ 		drandAPI:       nd.DrandAPI,","Thanks. Now that you've improved this we should just init and expose the StorageAPI on the node, like the other.s",Why was this removed?
+4534,"@@ -116,6 +116,15 @@ public class Key implements Comparable<Key> {
+     return toRawKey(Arrays.copyOf(value, value.length + 1));
+   }
+ 
++  /**
++   * nextPrefix key will be key with next available rid.
++   *
++   * @return a new key current rid+1.
++   */
++  public Key nextPrefix() {
++    return toRawKey(prefixNext(value));
++  }
++
+   /**
+    * The prefixNext key for bytes domain
+    *",it will be better if you can provide some examples,`nextPrefix` -> `nextPrefix`
+4535,"@@ -21,6 +21,8 @@ public abstract class LongRunningOperationDetailView {
+ 
+   public abstract String operationReturnType();
+ 
++  public abstract String operationResponseType();
++
+   public static Builder newBuilder() {
+     return new AutoValue_LongRunningOperationDetailView.Builder();
+   }","""return type"" and ""response type"" have never really been contrasted before, and it's unclear what their meaning is here. Could you clarify?",public abstract String operat
+4536,"@@ -10,6 +10,7 @@ import sys
+ import traceback
+ import subprocess
+ import shlex
++import json
+ 
+ # TODO: This is a cross-subpackage import!
+ from libcodechecker.log import build_action",Import order has been violated here.,Why is this needed?
+4537,"@@ -250,11 +250,14 @@ func (api *API) MessagePreview(ctx context.Context, from, to address.Address, me
+ // it does not change any state. It is use to interrogate actor state. The from address
+ // is optional; if not provided, an address will be chosen from the node's wallet.
+ func (api *API) MessageQuery(ctx context.Context, optFrom, to address.Address, method types.MethodID, baseKey block.TipSetKey, params ...interface{}) ([][]byte, error) {
+-	snapshot, err := api.actorState.Snapshot(ctx, baseKey)
+-	if err != nil {
+-		return [][]byte{}, err
+-	}
+-	return snapshot.Query(ctx, optFrom, to, method, params...)
++	// Dragons: delete
++
++	// snapshot, err := api.actorState.Snapshot(ctx, baseKey)
++	// if err != nil {
++	// 	return [][]byte{}, err
++	// }
++	// return snapshot.Query(ctx, optFrom, to, method, params...)
++	return [][]byte{}, nil
+ }
+ 
+ // Snapshot returns a interface to the chain state a a particular tipset",Are you suggesting deleting the concept of message querying from plumbing (sounds like more trouble than its worth) or suggesting deleting the snapshot based implementation?,Why is this being d
+4538,"@@ -114,6 +114,9 @@ func addJoinOtherFlags(cmd *cobra.Command, joinOptions *types.JoinOptions) {
+ 
+ 	cmd.Flags().StringVar(&joinOptions.TarballPath, types.TarballPath, joinOptions.TarballPath,
+ 		""Use this key to set the temp directory path for KubeEdge tarball, if not exist, download it"")
++
++	cmd.Flags().StringVarP(&joinOptions.Labels, types.Labels, ""l"", joinOptions.Labels,
++		`use this key to set the customized labels for node. you can input customized labels like {""key1"":""value1"", ""key2"":""value2""}`)
+ }
+ 
+ // newJoinOptions returns a struct ready for being used for creating cmd join flags.","I recommend using StringSliceVarP to resolve the label flag, like `-l key1=value1,key2=value2`. What do you think?",nit: `use this key 
+4539,"@@ -711,6 +711,18 @@ class Form extends WidgetBase
+             }
+         }
+     }
++    /**
++     * Add tab icons
++     *
++     * @param array $icons
++     * @return void
++     */
++    public function addTabIcons(array $icons)
++    {
++        $this->allTabs->primary->icons = $icons;
++        $this->allTabs->secondary->icons = $icons;
++        $this->allTabs->outside->icons = $icons;
++    }
+ 
+     /**
+      * Add tab fields.","@Samuell1 Will assigning the same icons array to all the tabs result in, for example, a primary tab called ""Colours"" and secondary tab called ""Colours"" having the same icon?",Shouldn't this be `
+4540,"@@ -437,6 +437,9 @@ def initTranslation():
+ 	finally:
+ 		del callerFrame # Avoid reference problems with frames (per python docs)
+ 
++def getTranslatedMessage(translatedMessage):
++	return _(translatedMessage)
++
+ def _translatedManifestPaths(lang=None, forBundle=False):
+ 	if lang is None:
+ 		lang = languageHandler.getLanguage() # can't rely on default keyword arguments here.",A docstring for this function please.,I don't think this is used anywhere.
+4541,"@@ -0,0 +1,12 @@
++using System;
++using System.Collections.Generic;
++using System.Text;
++using Microsoft.AspNetCore.Hosting.Server.Features;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
++{
++    internal class ServerAddressesFeature : IServerAddressesFeature
++    {
++        public ICollection<string> Addresses { get; } = new List<string>();
++    }
++}",heads up @JunTaoLuo,Why do we need this?
+4542,"@@ -167,12 +167,12 @@ namespace NLog
+                 if (SkipAssembly(stackFrame))
+                     continue;
+ 
+-                if (stackFrame.GetMethod().Name == ""MoveNext"")
++                if (stackFrame.GetMethod()?.Name == ""MoveNext"")
+                 {
+                     if (stackFrames.Length > i)
+                     {
+                         var nextStackFrame = stackFrames[i + 1];
+-                        var declaringType = nextStackFrame.GetMethod().DeclaringType;
++                        var declaringType = nextStackFrame.GetMethod()?.DeclaringType;
+                         if (declaringType == typeof(System.Runtime.CompilerServices.AsyncTaskMethodBuilder) ||
+                             declaringType == typeof(System.Runtime.CompilerServices.AsyncTaskMethodBuilder<>))
+                         {",".GetMethod() cannot return null now, correct?",Why is this needed?
+4543,"@@ -11,7 +11,7 @@ define(['events', 'playbackManager', 'dom', 'browser', 'css!./iconosd', 'materia
+     function getOsdElementHtml() {
+         var html = '';
+ 
+-        html += '<i class=""material-icons iconOsdIcon volume_up""></i>';
++        html += '<i class=""material-icons iconOsdIcon""></i>';
+ 
+         html += '<div class=""iconOsdProgressOuter""><div class=""iconOsdProgressInner""></div></div>';
+ ","Same thing here, I think the proper fix is elsewhere.",Why did you change this?
+4544,"@@ -585,6 +585,17 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
+                    openType //
+                    );
+                 
++                if ((retcode < 0) &&
++                    ((errno == ENOENT) || (errno == EAGAIN)))
++                  {
++                    ComDiagsArea * diagsArea = NULL;
++                    ExRaiseSqlError(getHeap(), &diagsArea, 
++                                    (ExeErrorCode)(EXE_HIVE_DATA_MOD_CHECK_ERROR));
++                    pentry_down->setDiagsArea(diagsArea);
++                    step_ = HANDLE_ERROR_AND_DONE;
++                    break;
++                  }
++
+                 // preopen next range. 
+                 if ( (currRangeNum_ + 1) < (beginRangeNum_ + numRanges_) ) 
+                   {","errno is a global variable that might be set by any system library call. It is dangerous to rely on it except right after the system call where it is set. But in this code, it looks like the library call is buried inside ExpLOBInterfaceSelectCursor. It would be safer if the latter function saved errno after whatever system library call it calls, and returns that as an ""out"" parameter, which this code could then check.",Shouldn't this be `(errno == ENOENT) || (errno == EAGAIN)`?
+4545,"@@ -50,7 +50,8 @@ class PackageNode(object):
+     def __repr__(self):
+         finfo = self._package.get_path()[:-len(PackageStore.PACKAGE_FILE_EXT)]
+         pinfo = self._prefix
+-        return ""<%s %r %r>"" % (self.__class__.__name__, finfo, pinfo)
++        kinfo = '\n'.join(self._keys()) if hasattr(self, '_keys') else ''
++        return ""<%s %r:%r>\n%s"" % (self.__class__.__name__, finfo, pinfo, kinfo)
+ 
+ 
+ class GroupNode(PackageNode):",`hasattr` is kinda terrible; just append extra info in the subclass.,I don't think we need the `\n` at the end.
+4546,"@@ -75,6 +75,16 @@ DAY = HOUR * 24
+ WEEK = DAY * 7
+ MONTH = DAY * 31
+ YEAR = DAY * 365
++
++# Set a flag to indicate whether the '%l' option can be used safely.
++# On Windows, in particular the %l option in strftime is not supported.
++#(It is not one of the documented Python formatters).
++try:
++    datetime.now().strftime(""%a %l%p"")
++    percent_l_supported = True
++except ValueError, e:
++    percent_l_supported = False
++
+ xAxisConfigs = (
+   dict(seconds=0.00,  minorGridUnit=SEC,  minorGridStep=5,  majorGridUnit=MIN,  majorGridStep=1,  labelUnit=SEC,  labelStep=5,  format=""%H:%M:%S"", maxInterval=10*MIN),
+   dict(seconds=0.07,  minorGridUnit=SEC,  minorGridStep=10, majorGridUnit=MIN,  majorGridStep=1,  labelUnit=SEC,  labelStep=10, format=""%H:%M:%S"", maxInterval=20*MIN),","Fair warning, the way that exception block is written won't work in python3 Python 3.2.3 (default, Jun 8 2012, 05:36:09) [GCC 4.7.0 20120507 (Red Hat 4.7.0-5)] on linux2 Type ""help"", ""copyright"", ""credits"" or ""license"" for more information. > > > try: > > > ... raise ValueError(""foo"") > > > ... except ValueError,e: > > > File ""<stdin>"", line 3 > > > except ValueError, e: > > > ^ > > > SyntaxError: invalid syntax","E231 missing whitespace after ','"
+4547,"@@ -43,12 +43,15 @@ module Beaker
+         end
+         port = container.json[""NetworkSettings""][""Ports""][""22/tcp""][0][""HostPort""]
+ 
++        forward_ssh_agent = @options['forward_ssh_agent'] || false
++
+         # Update host metadata
+         host['ip']  = ip
+         host['port'] = port
+         host['ssh']  = {
+           :password => root_password,
+           :port => port,
++          :forward_agent => forward_ssh_agent,
+         }
+ 
+         @logger.debug(""node available as  ssh -o UserKnownHostsFile=/dev/null -o StrictHostKeyChecking=no root@#{ip} -p #{port}"")",This only updates the metadata and not the actual thing you are trying to solve for the docker hypervisor.,Why do we need this?
+4548,"@@ -0,0 +1,18 @@
++// Copyright The OpenTelemetry Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
++/*
++Package debug provides access to enable internal debugging of opentelemetry.
++*/
++package debug // import ""go.opentelemetry.io/otel/internal/debug""",should this package be internal? don't we want to use it e.g. in go-contrib?,Why do we need this?
+4549,"@@ -31,7 +31,7 @@ import (
+ //
+ // A Document can be represented as a map[string]int or a pointer to a struct. For
+ // structs, the exported fields are the document fields.
+-type Document = interface{}
++type Document interface{}
+ 
+ // A Collection is a set of documents.
+ // TODO(jba): make the docstring look more like blob.Bucket.","Just curious, why did you make this change?",Why this change?
+4550,"@@ -1576,6 +1576,8 @@ def get_dummies(
+             ""Length of 'prefix' ({}) did not match the length of ""
+             ""the columns being encoded ({})."".format(len(prefix), len(column_labels))
+         )
++    elif isinstance(prefix, dict):
++        prefix = [prefix[column_label[0]] for column_label in column_labels]
+ 
+     all_values = _reduce_spark_multi(
+         kdf._sdf, [F.collect_set(kdf._internal.spark_column_for(label)) for label in column_labels]","Can you handle error cases such as `pd.get_dummies(pdf, prefix={""A"": ""foo""})`?",Why do we need this?
+4551,"@@ -166,8 +166,12 @@ func (agent *TestAgent) StartAgent() error {
+ 		Links: agent.Options.ContainerLinks,
+ 	}
+ 
++	if os.Getenv(""ECS_FTEST_FORCE_NET_HOST"") != """" {
++		hostConfig.NetworkMode = ""host""
++	}
++
+ 	if agent.Options != nil {
+-		// Override the default docker envrionment variable
++		// Override the default docker environment variable
+ 		for key, value := range agent.Options.ExtraEnvironment {
+ 			envVarExists := false
+ 			for i, str := range dockerConfig.Env {",Where is this environment variable being set?,I don't think this i
+4552,"@@ -22,9 +22,7 @@ class Registry(object):
+             module (:obj:`nn.Module`): Module to be registered.
+         """"""
+         if not issubclass(module_class, nn.Module):
+-            raise TypeError(
+-                'module must be a child of nn.Module, but got {}'.format(
+-                    type(module_class)))
++            raise TypeError(f'module must be a child of nn.Module, but got {module_class}')
+         module_name = module_class.__name__
+         if module_name in self._module_dict:
+             raise KeyError('{} is already registered in {}'.format(",`module_class ` is already a class and `type(module_class)` always returns `<class 'type'>`,Why did you change this?
+4553,"@@ -110,6 +110,17 @@ class SparkFileWriterFactory extends BaseFileWriterFactory<InternalRow> {
+     builder.createWriterFunc(SparkOrcWriter::new);
+   }
+ 
++  @Override
++  protected void configureEqualityDelete(ORC.DeleteWriteBuilder builder) {
++    builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema, typDesc));
++  }
++
++  @Override
++  protected void configurePositionDelete(ORC.DeleteWriteBuilder builder) {
++    builder.createWriterFunc((iSchema, typDesc) -> new SparkOrcWriter(iSchema, typDesc));
++    builder.transformPaths(path -> UTF8String.fromString(path.toString()));
++  }
++
+   private StructType dataSparkType() {
+     if (dataSparkType == null) {
+       Preconditions.checkNotNull(dataSchema(), ""Data schema must not be null"");",Nit: The lambda can be replaced with a method reference: `SparkOrcWriter::new` I think.,Why is this necessary?
+4554,"@@ -1265,6 +1265,13 @@ def is_number(obj):
+     else: return False
+ 
+ 
++def is_int(obj, int_like=False):
++    real_int = isinstance(obj, int) or getattr(getattr(obj, 'dtype', None), 'kind', 'o') in 'ui'
++    if real_int or (int_like and hasattr(obj, 'is_integer') and obj.is_integer()):
++        return True
++    return False
++
++
+ class ProgressIndicator(param.Parameterized):
+     """"""
+     Baseclass for any ProgressIndicator that indicates progress","It would be nice to have a docstring that says what range of integer-like objects will be accepted, as well as what the int_like argument is meant for.",I don't think we need to
+4555,"@@ -0,0 +1,5 @@
++class CreateLicensesView < ActiveRecord::Migration
++  def change
++    create_view :licenses
++  end
++end",How do we manage updates to this view down the road?,I don't think we need to
+4556,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+ 
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,import org.springframework.stereotype.Component;
+4557,"@@ -1174,8 +1174,11 @@ public abstract class BasePointsFormatTestCase extends BaseIndexFileFormatTestCa
+ 
+     Document doc = new Document();
+     doc.add(new IntPoint(""id"", 0));
+-    w.addDocument(doc);
+-    // now we write another segment where the id field does have points:
++    IllegalArgumentException ex =
++        expectThrows(IllegalArgumentException.class, () -> w.addDocument(doc));
++    assertEquals(
++        ""cannot change field \""id\"" from index options=DOCS to inconsistent index options=NONE"",
++        ex.getMessage());
+ 
+     w.forceMerge(1);
+     IOUtils.close(w, dir);","I think we should refactor or drop this test, as it is not testing the points format now, but IndexingChain/FieldsInfos' logic. Maybe we could rename the test `testMergeMissing` and configure the first segment to not have the `id` field at all.",I think this should be `IllegalArgumentException
+4558,"@@ -6,15 +6,6 @@ module RSpec
+       # @private
+       # Produces progress output while bisecting.
+       class BisectProgressFormatter < BaseTextFormatter
+-        # We've named all events with a `bisect_` prefix to prevent naming collisions.
+-        Formatters.register self, :bisect_starting, :bisect_original_run_complete,
+-                            :bisect_round_started, :bisect_individual_run_complete,
+-                            :bisect_complete, :bisect_repro_command,
+-                            :bisect_failed, :bisect_aborted,
+-                            :bisect_round_ignoring_ids, :bisect_round_detected_multiple_culprits,
+-                            :bisect_dependency_check_started, :bisect_dependency_check_passed,
+-                            :bisect_dependency_check_failed
+-
+         def bisect_starting(notification)
+           @round_count = 0
+           options = notification.original_cli_args.join(' ')",not sure I follow why all this goes away?,Why is this being removed?
+4559,"@@ -46,7 +46,7 @@ def test_insert_mode(file_name, source, input_text, auto_insert, quteproc):
+         quteproc.press_keys(input_text)
+     elif source == 'clipboard':
+         quteproc.send_cmd(':debug-set-fake-clipboard ""{}""'.format(input_text))
+-        quteproc.send_cmd(':paste-primary')
++        quteproc.send_cmd(':insert-text {clipboard}')
+ 
+     quteproc.send_cmd(':hint all')
+     quteproc.send_cmd(':follow-hint a')","Is this `{clipboard}` or `{primary}`, as the deprecation message for `:paste-primary` says?",Why did you change this?
+4560,"@@ -46,6 +46,18 @@ var (
+ 		Usage: ""OpenVPN subnet netmask"",
+ 		Value: ""255.255.255.0"",
+ 	}
++	// FlagOpenVPNPriceMinute sets the price per minute for provided OpenVPN service.
++	FlagOpenVPNPriceMinute = cli.Uint64Flag{
++		Name:  ""openvpn.price-minute"",
++		Usage: ""Sets the price of the OpenVPN service per minute."",
++		Value: 50000,
++	}
++	// FlagOpenVPNPriceGB sets the price per GiB for provided OpenVPN service.
++	FlagOpenVPNPriceGB = cli.Uint64Flag{
++		Name:  ""openvpn.price-gb"",
++		Usage: ""Sets the price of the OpenVPN service per minute."",
++		Value: 7000000,
++	}
+ )
+ 
+ // RegisterFlagsServiceOpenvpn registers OpenVPN CLI flags for parsing them later","Human unreadable. IMHO user should input MYST value: 0.0006 @chompomonim, opinions?",I think this should be `FlagOpenVPNPrice`
+4561,"@@ -643,15 +643,6 @@ class NVDAObject(documentBase.TextContainerObject,baseObject.ScriptableObject):
+ 				return self.presType_layout
+ 			if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN,controlTypes.ROLE_TABLECELL) and (not config.conf[""documentFormatting""][""reportTables""] or not config.conf[""documentFormatting""][""reportTableCellCoords""]):
+ 				return self.presType_layout
+-		if role in (controlTypes.ROLE_TABLEROW,controlTypes.ROLE_TABLECOLUMN):
+-			try:
+-				table=self.table
+-			except NotImplementedError:
+-				table=None
+-			if table:
+-				# This is part of a real table, so the cells will report row/column information.
+-				# Therefore, this object is just for layout.
+-				return self.presType_layout
+ 		return self.presType_content
+ 
+ 	def _get_simpleParent(self):","May be you could elaborate on why you removed this? I see some of this logic has been moved to ia2Web, but couldn't there be cases outside ia2Web (i.e. UIA) in which case ROLE_TABLEROW and ROLE_TABLECOLUMN are mapped to objects, in which case these objects will be of presentation type content erroneously?",Why is this removed?
+4562,"@@ -2637,10 +2637,10 @@ void Game::playerAcceptTrade(uint32_t playerId)
+ 	player->setTradeState(TRADE_ACCEPT);
+ 
+ 	if (tradePartner->getTradeState() == TRADE_ACCEPT) {
+-		Item* tradeItem1 = player->tradeItem;
+-		Item* tradeItem2 = tradePartner->tradeItem;
++		Item* playerTradeItem = player->tradeItem;
++		Item* tradePartnerItem = tradePartner->tradeItem;
+ 
+-		if (!g_events->eventPlayerOnTradeAccept(player, tradePartner, tradeItem1, tradeItem2)) {
++		if (!g_events->eventPlayerOnTradeAccept(player, tradePartner, playerTradeItem, tradePartnerItem)) {
+ 			internalCloseTrade(player);
+ 			return;
+ 		}",This is not consistent. Either rename the first to `tradePlayerItem` (which is ugly) or the second to `partnerTradeItem` (:+1:),I don't think this is the right place for
+4563,"@@ -50,6 +50,7 @@ func deps() {
+ 		""go get -u github.com/alecthomas/gometalinter"",
+ 		""gometalinter --install"",
+ 		""go get -u github.com/stretchr/testify"",
++		""go get -u github.com/xeipuuv/gojsonschema"",
+ 	}
+ 
+ 	for _, name := range list {",is there a reason we don't want to gx this dependency?,I think this should be `gometalinter --in
+4564,"@@ -26,6 +26,18 @@
+ 
+ require_once(""../inc/util.inc"");
+ 
++// strip leading AMD or NVIDIA
++//
++function strip_vendor($model) {
++    foreach (array(""AMD "", ""NVIDIA "") as $maker) {
++        $n = strlen($maker);
++        if (substr($model, 0, $n) == $maker) {
++            return substr($model, $n);
++        }
++    }
++    return $model;
++}
++
+ // take a host.serialnum field (which may encode several GPUs)
+ // and extract the model name for the given vendor
+ //","I'd suggest to add ""ATI "" and ""Intel(R) "" to this list",This function is not used anywhere.
+4565,"@@ -127,8 +127,8 @@ class Status extends ReportWidgetBase
+             }
+         }
+ 
+-        foreach ($missingPlugins as $pluginCode) {
+-            $warnings[] = Lang::get('backend::lang.warnings.plugin_missing', ['name' => '<strong>'.$pluginCode.'</strong>']);
++        foreach ($missingPlugins as $plugin) {
++            $warnings[] = Lang::get('backend::lang.warnings.plugin_missing', ['name' => '<strong>'.$plugin['code'].'</strong>']);
+         }
+ 
+         return $warnings;","This is using a different lang key, we should switch it to using the new key and remove the old key if it is no longer used.",`$plugin['code']` => `$plugin['code
+4566,"@@ -76,8 +76,9 @@ type SpecHandler interface {
+ }
+ 
+ var (
+-	nameRegex       = regexp.MustCompile(api.Name + ""=([0-9A-Za-z_-]+),?"")
+-	nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=([0-9A-Za-z_-]+),?"")
++	nameRegex = regexp.MustCompile(api.Name + ""=([0-9A-Za-z_-]+),?"")
++	//nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=([0-9A-Za-z_-]+),*"")
++	nodesRegex      = regexp.MustCompile(api.SpecNodes + ""=('[0-9A-Za-z,_-]+'),*|"" + api.SpecNodes + ""=([0-9A-Za-z_-]+),*"")
+ 	parentRegex     = regexp.MustCompile(api.SpecParent + ""=([A-Za-z]+),?"")
+ 	sizeRegex       = regexp.MustCompile(api.SpecSize + ""=([0-9A-Za-z]+),?"")
+ 	scaleRegex      = regexp.MustCompile(api.SpecScale + ""=([0-9]+),?"")","shouldn't this work? nodesRegex = regexp.MustCompile(api.SpecNodes + ""=(('[0-9A-Za-z,_-]+')|([0-9A-Za-z_-]+)),?"")",Why is this needed?
+4567,"@@ -1,5 +1,6 @@
+ class Account::Encrypter
+-  def before_create(account)
++  def before_validation(account)
++    return unless account.new_record?
+     assign_activation_code_to_random_hash(account)
+     encrypt_salt(account)
+   end","You mentioned this change was prompted because the `before_create` action was actually a defect. This will be done only for a new record; why is `before_validation`, which will be called repeatedly as accounts get updated and saved, correct whereas `before_create` is not? It looks like one would want to assign and activation code, etc., only once.",Why do we need this?
+4568,"@@ -95,6 +95,19 @@ namespace Datadog.Trace
+                 }
+             }
+ 
++            if (Settings.GlobalSamplingRate != null)
++            {
++                var globalRate = (float)Settings.GlobalSamplingRate;
++                if (globalRate < 0f || globalRate > 1f)
++                {
++                    Log.Warning(""{0} configuration of {1} is out of range"", ConfigurationKeys.GlobalSamplingRate, Settings.GlobalSamplingRate);
++                }
++                else
++                {
++                    Sampler.RegisterRule(new GlobalSamplingRule(globalRate));
++                }
++            }
++
+             // Register callbacks to make sure we flush the traces before exiting
+             AppDomain.CurrentDomain.ProcessExit += CurrentDomain_ProcessExit;
+             AppDomain.CurrentDomain.UnhandledException += CurrentDomain_UnhandledException;",What's the rationale for a default setting to not use a GlobalSamplingRate of 1? I don't know much about the sampling rate stuff,Should this be a warning?
+4569,"@@ -24,7 +24,8 @@ module Windows
+         'group'         => 'Administrators',
+         'puppetpath'    => '`cygpath -smF 35`/PuppetLabs/puppet/etc',
+         'puppetvardir'  => '`cygpath -smF 35`/PuppetLabs/puppet/var',
+-        'puppetbindir'  => '`cygpath -F 38`/Puppet Labs/Puppet Enterprise/bin',
++        #if an x86 Program Files dir exists then use it, default to just Program Files
++        'puppetbindir'  => '$( [ -d ""/cygdrive/c/Program Files (x86)"" ] && echo ""/cygdrive/c/Program Files (x86)"" || echo ""/cygdrive/c/Program Files"" )/Puppet Labs/Puppet Enterprise/bin',
+         'pathseparator' => ';',
+       })
+     end","Don't we know if it's 64 by this point? Do we have to test for the directory on every call, or can't we just split the value based on the platform?",I think this should be `e
+4570,"@@ -35,6 +35,19 @@ class NoteListUtils {
+ 				})
+ 			);
+ 
++			menu.append(
++				new MenuItem({
++					label: _('Assign Notebook'),
++					click: async () => {
++						props.dispatch({
++							type: 'WINDOW_COMMAND',
++							name: 'moveToFolder',
++							noteIds: noteIds,
++						});
++					},
++				})
++			);
++
+ 			menu.append(
+ 				new MenuItem({
+ 					label: _('Duplicate'),",It's not async,Why do we need the `async
+4571,"@@ -66,11 +66,11 @@ namespace Examples.Console
+                 AppContext.SetSwitch(""System.Net.Http.SocketsHttpHandler.Http2UnencryptedSupport"", true);
+ 
+                 providerBuilder
+-                    .AddOtlpExporter(o =>
++                    .AddOtlpExporter((exporterOptions, metricReaderOptions) =>
+                     {
+-                        o.MetricReaderType = MetricReaderType.Periodic;
+-                        o.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
+-                        o.AggregationTemporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
++                        metricReaderOptions.MetricReaderType = MetricReaderType.Periodic;
++                        metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
++                        metricReaderOptions.Temporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
+                     });
+             }
+             else","Maybe we could add some use of `exporterOptions` in this example, otherwise the proper code would replace this variable name with an underscore?",Why do we need this chang
+4572,"@@ -41,6 +41,11 @@ class Search extends WidgetBase
+      */
+     public $scope;
+ 
++    /**
++     * @var bool Search on every key stroke.
++     */
++    public $everykey = true;
++
+     //
+     // Object properties
+     //","Maybe would be better to rename it to ""onEveryKey"" or ""fireOnEveryKey"".",Why do we need this?
+4573,"@@ -832,7 +832,7 @@ public class FilePage implements java.io.Serializable {
+             // Always allow preview for PrivateUrlUser
+             return true;
+         } else {
+-            return FileUtil.isPreviewAllowed(fileMetadata);
++            return fileDownloadHelper.isPreviewAllowed(fileMetadata);
+         }
+     }
+ ","if we're switching to calling FileDownloadHelper, we can just call that directly from the xhtml (see line 357 for example) and then remove this method completely. This is because the other thing it does is check PrivateURLUser, but the FileDownloadHelper method already does that. (and while we're at it, we can remove the method from FileUtil as this is the only place that method is called)",Shouldn't this be `i
+4574,"@@ -274,11 +274,7 @@ public abstract class GapicInterfaceConfig implements InterfaceConfig {
+   }
+ 
+   public GapicMethodConfig getMethodConfig(String methodSimpleName, String fullName) {
+-    GapicMethodConfig methodConfig = getMethodConfigMap().get(methodSimpleName);
+-    if (methodConfig == null) {
+-      throw new IllegalArgumentException(""no method config for method '"" + fullName + ""'"");
+-    }
+-    return methodConfig;
++    return getMethodConfigMap().get(methodSimpleName);
+   }
+ 
+   @Override",is `fullName` still required as a parameter?,Why did you remove t
+4575,"@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
+           getClass().getClassLoader())
+           .asSubclass(Routable.class);
+       Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
+-      LOG.info(""Bound legacy RC support"");
++      LOG.finest(""Bound legacy RC support"");
+       return constructor.newInstance(sessions);
+     } catch (ReflectiveOperationException e) {
+       // Do nothing.",This informational message is important to users. Please leave.,Why is this change n
+4576,"@@ -470,7 +470,6 @@ func (o *initEnvOpts) deployEnv(app *config.Application) error {
+ 		Name:                     o.Name,
+ 		AppName:                  o.AppName(),
+ 		Prod:                     o.IsProduction,
+-		PublicLoadBalancer:       true, // TODO: configure this based on user input or service Type needs?
+ 		ToolsAccountPrincipalARN: caller.RootUserARN,
+ 		AppDNSName:               app.Domain,
+ 		AdditionalTags:           app.Tags,",Why do we want to remove this one? Are we planning to substitute it?,Why is this removed?
+4577,"@@ -4,13 +4,14 @@ import (
+ 	""fmt""
+ 	""testing""
+ 
+-	""github.com/golang/protobuf/proto""
++	legacyProto ""github.com/golang/protobuf/proto"" // nolint: staticcheck // deprecated library needed until WithDetails can take v2
+ 	""github.com/spiffe/spire/pkg/common/nodeutil""
+ 	""github.com/spiffe/spire/proto/spire/common""
+ 	""github.com/spiffe/spire/proto/spire/types""
+ 	""github.com/stretchr/testify/require""
+ 	""google.golang.org/grpc/codes""
+ 	""google.golang.org/grpc/status""
++	""google.golang.org/protobuf/proto""
+ )
+ 
+ func TestIsAgentBanned(t *testing.T) {",We may create an issue to track this so we don't forget?,Why is this needed?
+4578,"@@ -1,9 +1,12 @@
+ class ApplicationController < ActionController::Base
++  helper AvatarHelper
++  helper ButtonHelper
++
+   protect_from_forgery with: :exception
+ 
+   attr_reader :page_context
+   helper_method :page_context
+-
++    
+   before_action :store_location
+ 
+   def initialize(*params)",This file has the executable bit set.,Layout/TrailingWhite
+4579,"@@ -177,6 +177,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
++	db.logger.Info(""setting db capacity to :"", db.capacity)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","Improve the formatting of the message `.Infof(""setting db capacity to: %v"", db.capacity)` There is a space before `:` and this way it is easier to see the formatting.",I don't think we nee
+4580,"@@ -434,12 +434,13 @@ RTPSParticipantImpl* RTPSDomainImpl::find_local_participant(
+ RTPSReader* RTPSDomainImpl::find_local_reader(
+         const GUID_t& reader_guid)
+ {
+-    std::lock_guard<std::mutex> guard(RTPSDomain::m_mutex);
++    std::unique_lock<std::mutex> lock(RTPSDomain::m_mutex);
+     for (const RTPSDomain::t_p_RTPSParticipant& participant : RTPSDomain::m_RTPSParticipants)
+     {
+         if (participant.second->getGuid().guidPrefix == reader_guid.guidPrefix)
+         {
+             // Participant found, forward the query
++            lock.unlock();
+             return participant.second->find_local_reader(reader_guid);
+         }
+     }","This lock cannot be released here, as it is protecting m_RTPSParticipants and the participant reference.",Why is this lock needed?
+4581,"@@ -967,6 +967,8 @@ Query.prototype.find = function (conditions, callback) {
+     this.merge(conditions);
+   }
+ 
++  prepareDiscriminatorCriteria(this);
++
+   try {
+     this.cast(this.model);
+     this._castError = null;",we'll need this in `_findAndModify` too,Why do we need this?
+4582,"@@ -148,7 +148,7 @@ public class SmartStoreInspectorActivity extends Activity implements AdapterView
+ 		isGlobal = bundle == null || !bundle.containsKey(IS_GLOBAL_STORE) || bundle.getBoolean(IS_GLOBAL_STORE) || !hasUser;
+ 		// dbName is set to DBOpenHelper.DEFAULT_DB_NAME
+ 		//   if no bundle, or no value for dbName in bundle
+-		dbName = bundle == null || !bundle.containsKey(DB_NAME) ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME);
++		dbName = bundle == null || !bundle.containsKey(DB_NAME) ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ 	}
+ 
+ 	private void setupSpinner() {","This is the fix for the crash. The function to create the intent to launch this activity requires `dbName`, so it has to be set to `null`. In such cases, the value for `dbName` will be set to `null` and cause issues throughout this activity. This adds a default value if the explicitly assigned value in `null`.",Why do we need this chan
+4583,"@@ -412,6 +412,11 @@ class WordDocument(UIADocumentWithTableNavigation,WordDocumentNode,WordDocumentB
+ 	# Microsoft Word duplicates the full title of the document on this control, which is redundant as it appears in the title of the app itself.
+ 	name=u""""
+ 
++	def event_textChange(self):
++		# Ensure Braille is updated when text changes,
++		# As Microsoft Word does not fire caret events when typing text, even though the caret does move.
++		braille.handler.handleCaretMove(self)
++
+ 	def event_UIA_notification(self, activityId=None, **kwargs):
+ 		# #10851: in recent Word 365 releases, UIA notification will cause NVDA to announce edit functions
+ 		# such as ""delete back word"" when Control+Backspace is pressed.","Shouldn't we also trigger vision update here, so that if someone has caret highlighting enabled the correct character is highlighted?",Why do we need this?
+4584,"@@ -338,7 +338,11 @@ public class GoGapicSurfaceTransformer implements ModelToViewTransformer<ProtoAp
+   void addXExampleImports(InterfaceContext context, Iterable<? extends MethodModel> methods) {
+     ImportTypeTable typeTable = context.getImportTypeTable();
+     typeTable.saveNicknameFor(""context;;;"");
+-    typeTable.saveNicknameFor(context.getProductConfig().getPackageName() + "";;;"");
++    typeTable.saveNicknameFor(
++        context.getProductConfig().getPackageName()
++            + "";""
++            + context.getNamer().getLocalPackageName()
++            + "";;"");
+ 
+     for (MethodModel method : methods) {
+       method.getAndSaveRequestTypeName(context.getImportTypeTable(), context.getNamer());","Woah, how does this change, which includes semicolons, result in the baseline change? Are the semicolon chars just part of the internal representation of the import type?",Why do we need this change?
+4585,"@@ -51,7 +51,7 @@ class _NvdaLocationData:
+ 		self.whichNVDA = builtIn.get_variable_value(""${whichNVDA}"", ""source"")
+ 		if self.whichNVDA == ""source"":
+ 			self._runNVDAFilePath = _pJoin(self.repoRoot, ""source/nvda.pyw"")
+-			self.baseNVDACommandline = f""pyw -3.7-32 {self._runNVDAFilePath}""
++			self.baseNVDACommandline = f""pyw {self._runNVDAFilePath}""
+ 		elif self.whichNVDA == ""installed"":
+ 			self._runNVDAFilePath = _pJoin(_expandvars('%PROGRAMFILES%'), 'nvda', 'nvda.exe')
+ 			self.baseNVDACommandline = f'""{str(self._runNVDAFilePath)}""'",Can't you just use runnvda.bat here?,I think this should be `-3.
+4586,"@@ -23,17 +23,6 @@
+ #include ""selectors.h""
+ #include ""vstring.h""
+ 
+-/* To get rid of unused parameter warning in
+- * -Wextra */
+-#ifdef UNUSED
+-#elif defined(__GNUC__)
+-# define UNUSED(x) UNUSED_ ## x __attribute__((unused))
+-#elif defined(__LCLINT__)
+-# define UNUSED(x) /*@unused@*/ x
+-#else
+-# define UNUSED(x) x
+-#endif
+-
+ typedef enum {
+ 	K_INTERFACE,
+ 	K_IMPLEMENTATION,","these definitions of UNUSED aren't the same as the one you imported, so callers should be fixed (if any)",Why is this being removed?
+4587,"@@ -404,6 +404,7 @@ func (client *cniClient) createIPAMNetworkConfig(cfg *Config) (string, *libcni.N
+ 
+ 	ipamNetworkConfig := IPAMNetworkConfig{
+ 		Name:       ECSIPAMPluginName,
++		Type:       ECSIPAMPluginName,
+ 		CNIVersion: client.cniVersion,
+ 		IPAM:       ipamConfig,
+ 	}",is type a free string too?,Why do we need this?
+4588,"@@ -27,15 +27,16 @@ class WrapFunction(nn.Module):
+         return self.wrapped_function(*args, **kwargs)
+ 
+ 
+-def ort_validate(model, feats, onnx_io='tmp.onnx'):
++def ort_validate(model_func, feats, onnx_io='tmp.onnx'):
+     """"""Validate the output of the onnxruntime backend is the same as the output
+     generated by torch.
+ 
+     Args:
+-        model (nn.Module): the model to be verified
++        model_func : the function of model to be verified
+         feats (list(torch.Tensor) | torch.Tensor): the input of model
+         onnx_io (str): the name of onnx output file
+     """"""
++    model = WrapFunction(model_func)
+     model.cpu().eval()
+     with torch.no_grad():
+         torch.onnx.export(",here input could be a normal function or an instance of torch.nn.Module.,Why do we need this change?
+4589,"@@ -65,6 +65,7 @@ module Travis
+           sh.echo 'Please open any issues at https://github.com/travis-ci/travis-ci/issues/new and cc @domenkozar @garbas @matthewbauer @grahamc', ansi: :green
+ 
+           sh.cmd ""nix-env --version""
++          sh.cmd ""nix-instantiate --eval -E 'with import <nixpkgs> {}; lib.version or lib.nixpkgsVersion'""
+         end
+ 
+         def script","Example output: ""19.03.git.a7f4a860d0c"" At some point `nixpkgsVersion` was renamed to `version` since someone may use an old channel we fallback to `nixpkgsVersion` for backwards compatibility.",I think this should be `nix
+4590,"@@ -39,8 +39,6 @@ class LanguageTreeReadAction
+ 
+ 
+     /**
+-     * @IsGranted(""SETTINGS_READ"")
+-     *
+      * @SWG\Tag(name=""Language"")
+      * @SWG\Parameter(
+      *     name=""language"",",Class import is therefore redundant I guess :),Why did you remove this?
+4591,"@@ -58,11 +58,13 @@ const (
+ 	infoTryingToStopNode             = ""Trying to stop the node...""
+ 	infoNodeSuccessfullyStopped      = ""The node was successfully stopped.""
+ 	infoNodeStatus                   = ""Last committed block: %d\nTime since last block: %s\nSync Time: %s\nLast consensus protocol: %s\nNext consensus protocol: %s\nRound for next consensus protocol: %d\nNext consensus protocol supported: %v""
++	warnNodeCreationIPFailure        = ""Parsing passed IP %v failed: need a valid IPv4 or IPv6 address with a specified port number. Acting as though IP was not supplied.""
+ 	errorNodeNotDetected             = ""Algorand node does not appear to be running: %s""
+ 	errorNodeStatus                  = ""Cannot contact Algorand node: %s.""
+ 	errorNodeFailedToStart           = ""Algorand node failed to start: %s""
+ 	errorNodeRunning                 = ""Node must be stopped before writing APIToken""
+ 	errorNodeFailGenToken            = ""Cannot generate API token: %s""
++	errorNodeCreation                = ""Error during node creation: %v""
+ 	errorKill                        = ""Cannot kill node: %s""
+ 	errorCloningNode                 = ""Error cloning the node: %s""
+ 	infoNodeCloned                   = ""Node cloned successfully to: %s""","If parsing fails, don't act as no IP specified. Error out.",I think this should be `err
+4592,"@@ -187,7 +187,9 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+ 
+     final Object updateSync = new Object();
+ 
+-    public enum CHARTTYPE {PRE,BAS, IOB, COB, DEV, SEN};
++    public enum CHARTTYPE {PRE, BAS, IOB, COB, DEV, SEN}
++
++    ;
+     private static final ScheduledExecutorService worker = Executors.newSingleThreadScheduledExecutor();
+     private static ScheduledFuture<?> scheduledUpdate = null;
+ ",... here the semicolon wanted to run away from the enum ;),nit: unnecessary semicolon
+4593,"@@ -76,12 +76,12 @@ public class ReplicateFromLeader {
+       }
+       log.info(""Will start replication from leader with poll interval: {}"", pollIntervalStr );
+ 
+-      NamedList<Object> slaveConfig = new NamedList<>();
+-      slaveConfig.add(""fetchFromLeader"", Boolean.TRUE);
+-      slaveConfig.add(ReplicationHandler.SKIP_COMMIT_ON_MASTER_VERSION_ZERO, switchTransactionLog);
+-      slaveConfig.add(""pollInterval"", pollIntervalStr);
++      NamedList<Object> secondaryConfig = new NamedList<>();
++      secondaryConfig.add(""fetchFromLeader"", Boolean.TRUE);
++      secondaryConfig.add(ReplicationHandler.SKIP_COMMIT_ON_MASTER_VERSION_ZERO, switchTransactionLog);
++      secondaryConfig.add(""pollInterval"", pollIntervalStr);
+       NamedList<Object> replicationConfig = new NamedList<>();
+-      replicationConfig.add(""slave"", slaveConfig);
++      replicationConfig.add(""secondary"", secondaryConfig);
+ 
+       String lastCommitVersion = getCommitVersion(core);
+       if (lastCommitVersion != null) {","Note that this is in the context of SolrCloud, so ""secondary"" doesn't apply and should be instead follower",Why do we need this change
+4594,"@@ -1578,11 +1578,11 @@ EOF
+     assert_response :success, ""can't get changesets by closed-ness""
+     assert_changesets [3, 5, 6, 7, 8, 9]
+ 
+-    get :query, :closed => ""true"", :user => users(:normal_user).id
++    get :query, :closed => ""true"", :user => users(:normal_user)
+     assert_response :success, ""can't get changesets by closed-ness and user""
+     assert_changesets [3, 6, 8]
+ 
+-    get :query, :closed => ""true"", :user => users(:public_user).id
++    get :query, :closed => ""true"", :user => users(:public_user)
+     assert_response :success, ""can't get changesets by closed-ness and user""
+     assert_changesets [7]
+ ",This one is a query parameter and probably really should be ID and in fact I'm mystified as to how this is working because the controller code definitely wants a number for that parameter so the test framework must be converting it back to an ID as best I can tell.,Use the new Ruby 1.9 hash 
+4595,"@@ -4177,9 +4177,11 @@ RelExpr * FileScan::preCodeGen(Generator * generator,
+ 	 TRUE);
+ 
+       if (isHiveTable())
+-	// assign individual files and blocks to each ESPs
+-	((NodeMap *) getPartFunc()->getNodeMap())->assignScanInfos(hiveSearchKey_);
+-       generator->setProcessLOB(TRUE);
++        {
++          // assign individual files and blocks to each ESPs
++          ((NodeMap *) getPartFunc()->getNodeMap())->assignScanInfos(hiveSearchKey_);
++          generator->setProcessLOB(TRUE);
++        }
+     }
+ 
+   ",Need to ensure this is set to TRU for LOB datatype access too not just for hive .,Why is this change needed?
+4596,"@@ -1772,7 +1772,11 @@ class Series(_Frame, IndexOpsMixin):
+ 
+     # ----------------------------------------------------------------------
+ 
+-    def _reduce_for_stat_function(self, sfun):
++    def _reduce_for_stat_function(self, sfun, numeric_only=None):
++        """"""
++        :param sfun: the stats function to be used for aggregation
++        :param numeric_only: not used by this implementation, but passed down by stats functions
++        """"""
+         from inspect import signature
+         num_args = len(signature(sfun).parameters)
+         col_sdf = self._scol","You're using the Sphinx docstring style here (maybe because it's the default in PyCharm?). Instead, you should use the NumPy style (that you've also used in other places) to be more consistent with the rest of the project.",`numeric_only` doesn't seem to be used anywhere?
+4597,"@@ -142,8 +142,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel
+                 }
+                 else if (!hasListenOptions && !hasServerAddresses)
+                 {
+-                    _logger.LogDebug($""No listening endpoints were configured. Binding to {Constants.DefaultIPEndPoint} by default."");
+-                    listenOptions.Add(new ListenOptions(Constants.DefaultIPEndPoint));
++                    _logger.LogDebug($""No listening endpoints were configured. Binding to {Constants.DefaultServerAddress} by default."");
++
++                    // ""localhost"" for both IPv4 and IPv6 can't be represented as an IPEndPoint.
++                    StartLocalhost(engine, ServerAddress.FromUrl(Constants.DefaultServerAddress));
++
++                    // If StartLocalhost doesn't throw, there is at least one listener.
++                    // The port cannot change for ""localhost"".
++                    _serverAddresses.Addresses.Add(Constants.DefaultServerAddress);
++
++                    return;
+                 }
+                 else if (!hasListenOptions)
+                 {",Don't really need this since the rest of the method will no-op but it's also safe to return early.,Shouldn't this be an error?
+4598,"@@ -19,11 +19,13 @@
+ 
+ #include <fastdds/rtps/messages/RTPSMessageCreator.h>
+ #include <fastdds/rtps/messages/CDRMessage.h>
+-#include <fastrtps/qos/ParameterList.h>
+ 
+ #include <fastdds/dds/log/Log.hpp>
+ 
++#include ""../../fastdds/core/policy/ParameterList.hpp""
++
+ using namespace eprosima::fastrtps;
++using ParameterList = eprosima::fastdds::dds::ParameterList;
+ 
+ namespace eprosima {
+ namespace fastrtps {",Don't use relative paths. src directory is already on the include search path,Why is this needed?
+4599,"@@ -0,0 +1,5 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++// [assembly: BenchmarkDotNet.Attributes.AspNetCoreBenchmark]",this file can be removed,Why is this needed?
+4600,"@@ -98,7 +98,7 @@ public class CodeFirstSpringmvc extends CodeFirstSpringmvcBase {
+ 
+   @RequestMapping(path = ""/uploadWithoutAnnotation"", method = RequestMethod.POST, produces = MediaType.TEXT_PLAIN_VALUE, consumes = MediaType.MULTIPART_FORM_DATA_VALUE)
+   public String fileUploadWithoutAnnotation(MultipartFile file1, MultipartFile file2,
+-      @RequestAttribute(""name"") String name) {
++      @RequestAttribute(name = ""name"", required = false) String name) {
+     return super.fileUpload(file1, file2, name);
+   }
+ ",Do we have test cases that name is null?,Why is this required?
+4601,"@@ -109,8 +109,16 @@ type SumIntAgg struct {
+ 
+ func (a *SumIntAgg) DoInt(vs *array.Int64) {
+ 	// https://issues.apache.org/jira/browse/ARROW-4081
+-	if vs.Len() > 0 {
+-		a.sum += math.Int64.Sum(vs)
++	if l := vs.Len() - vs.NullN(); l > 0 {
++		if vs.NullN() == 0 {
++			a.sum += math.Int64.Sum(vs)
++		} else {
++			for i := 0; i < vs.Len(); i++ {
++				if vs.IsValid(i) {
++					a.sum += vs.Value(i)
++				}
++			}
++		}
+ 	}
+ }
+ func (a *SumIntAgg) Type() flux.ColType {","in a separate PR, I'll check for a table that is empty/all-null and skip this function call completely.",`l` is unused (from `
+4602,"@@ -47,7 +47,7 @@ public class WebUtils {
+     try {
+       azkabanEventReporter = ServiceProvider.SERVICE_PROVIDER
+           .getInstance(AzkabanEventReporter.class);
+-    } catch (NullPointerException | ConfigurationException e) {
++    } catch (Exception e) {
+       Logger.getLogger(WebUtils.class.getName()).warn(""AzkabanEventReporter not configured"", e);
+     }
+   }","We really, really want to catch _everything_ here. It is safe to leave `azkabanEventReporter` set to null.",Why is this change ne
+4603,"@@ -112,7 +112,12 @@ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context,
+ 					// The values only have the same type when `null`.
+ 
+ 					outer: if (oldDom==null || oldDom.parentNode!==parentDom) {
+-						parentDom.appendChild(newDom);
++						// Skip appendind if the last element is the same as the new dom
++						// node. This is necessary to prevent the last element losing focus
++						// if it had focus before the diff.
++						if (parentDom.lastChild!==newDom) {
++							parentDom.appendChild(newDom);
++						}
+ 					}
+ 					else {
+ 						// `j<oldChildrenLength; j+=2` is an alternative to `j++<oldChildrenLength/2`",Can't we add the check here?,nit: space after `!==
+4604,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+ 
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests,Why do we need to close the connection here?
+4605,"@@ -40,6 +40,8 @@ type GenericDeploymentSpec struct {
+ 	// The maximum length of time to execute deployment before giving up.
+ 	// Default is 6h.
+ 	Timeout Duration `json:""timeout,omitempty"" default:""6h""`
++	// List of encrypted secrets and targets that should be decoded before using.
++	Encryption *SecretEncryption `json:""encryption""`
+ }
+ 
+ func (s *GenericDeploymentSpec) Validate() error {",Tell me if you have a better field name for this.,Why is this a pointer?
+4606,"@@ -1084,8 +1084,8 @@ partial class Build
+                         ""Samples.AspNetCoreMvc30"" => Framework == TargetFramework.NETCOREAPP3_0,
+                         ""Samples.AspNetCoreMvc31"" => Framework == TargetFramework.NETCOREAPP3_1,
+                         ""Samples.AspNetCore2"" => Framework == TargetFramework.NETCOREAPP2_1,
+-                        ""Samples.AspNetCore5"" => Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NETCOREAPP3_0,
+-                        ""Samples.GraphQL4"" => Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NET5_0,
++                        ""Samples.AspNetCore5"" => Framework == TargetFramework.NET6_0 || Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NETCOREAPP3_0,
++                        ""Samples.GraphQL4"" => Framework == TargetFramework.NETCOREAPP3_1 || Framework == TargetFramework.NET5_0 || Framework == TargetFramework.NET6_0,
+                         var name when projectsToSkip.Contains(name) => false,
+                         var name when multiPackageProjects.Contains(name) => false,
+                         ""Samples.AspNetCoreRazorPages"" => true,","FYI, I have a branch I started to improve this. Nuke can read the target frameworks from the project files, so we don't have to do this mess. Ran into some other issues so it didn't take priority",I don't think this is correct. It should be 
+4607,"@@ -364,16 +364,11 @@ void getNbrAtomAndBondIds(unsigned int aid, const RDKit::ROMol *mol,
+   unsigned int na = mol->getNumAtoms();
+   URANGE_CHECK(aid, na);
+ 
+-  RDKit::ROMol::ADJ_ITER nbrIdx, endNbrs;
+-  boost::tie(nbrIdx, endNbrs) = mol->getAtomNeighbors(mol->getAtomWithIdx(aid));
+-
+-  unsigned int ai, bi;
+-  while (nbrIdx != endNbrs) {
+-    ai = (*nbrIdx);
+-    bi = mol->getBondBetweenAtoms(aid, ai)->getIdx();
++  for (auto ai : boost::make_iterator_range(
++           mol->getAtomNeighbors(mol->getAtomWithIdx(aid)))) {
++    auto bi = mol->getBondBetweenAtoms(aid, ai)->getIdx();
+     aids.push_back(ai);
+     bids.push_back(bi);
+-    nbrIdx++;
+   }
+ }
+ ","This is just `mol->atomNeightors()`, is it?",`bi` can be `const`
+4608,"@@ -40,10 +40,11 @@ using daal_kmeans_lloyd_dense_ucapi_kernel_t =
+     daal_kmeans::internal::KMeansDenseLloydBatchKernelUCAPI<Float>;
+ 
+ template <typename Float>
+-struct infer_kernel_gpu<Float, method::by_default> {
+-    infer_result operator()(const dal::backend::context_gpu& ctx,
+-                            const descriptor_base& params,
+-                            const infer_input& input) const {
++struct infer_kernel_gpu<Float, method::by_default, task::clustering> {
++    infer_result<task::clustering> operator()(const dal::backend::context_gpu& ctx,
++                                              const descriptor_base<task::clustering>& params,
++                                              const infer_input<task::clustering>& input) const {
++        using Task = task::clustering;
+         auto& queue = ctx.get_queue();
+         interop::execution_context_guard guard(queue);
+ ",This alias is just for a single occurrence. Maybe it ins't necessary?,Why do we need this `using`?
+4609,"@@ -1198,7 +1198,7 @@ class CppGenerator : public BaseGenerator {
+         code_ += ""    }"";
+       }
+     }
+-    code_ += ""    default: return false;"";
++    code_ += ""    default: return true;"";
+     code_ += ""  }"";
+     code_ += ""}"";
+     code_ += """";",You can delete this `NONE` case.,"code_ += ""  default: {"";"
+4610,"@@ -5420,8 +5420,8 @@ TEST_F(VkLayerTest, RenderPassCreateAttachmentReadOnlyButCleared) {
+     }
+ }
+ 
+-TEST_F(VkLayerTest, RenderPassCreateAttachmentUsedTwiceColor) {
+-    TEST_DESCRIPTION(""Attachment is used simultaneously as two color attachments. This is usually unintended."");
++TEST_F(VkLayerTest, RenderPassCreateAttachmentMismatchingLayoutsColor) {
++    TEST_DESCRIPTION(""Attachment is used simultaneously as two color attachments with different layouts."");
+ 
+     // Check for VK_KHR_get_physical_device_properties2
+     if (InstanceExtensionSupported(VK_KHR_GET_PHYSICAL_DEVICE_PROPERTIES_2_EXTENSION_NAME)) {",@cnorthrop -- here is a test with a name change. Is this going to affect your internal CI?,Why is this test being remov
+4611,"@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
+   private ChromeDriverCommand() {}
+ 
+   static final String LAUNCH_APP = ""launchApp"";
++  static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
++      = ""sendCommandForDownloadChromeHeadLess"";
++
+ }","Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way.",nit: `sendCommandForDownload
+4612,"@@ -122,6 +122,10 @@ class core(task.Config):
+     parallel_scheduling = parameter.BoolParameter(
+         default=False,
+         description='Use multiprocessing to do scheduling in parallel.')
++    parallel_scheduling_processes = parameter.IntParameter(
++        default=None,
++        description='The number of processes to use for scheduling in parallel.'
++                    ' The default is the number of available CPUs')
+     assistant = parameter.BoolParameter(
+         default=False,
+         description='Run any task from the scheduler.')","I think this will cause a warning, can you set the default to zero (`0`)?",line too long (80 > 79 characters)
+4613,"@@ -2,7 +2,7 @@ package client_connection
+ 
+ import (
+ 	""errors""
+-	""github.com/mysterium/node/service_discovery/dto""
++	id ""github.com/mysterium/node/identity""
+ )
+ 
+ type State string","confusing naming. Identity from ""id"" package :/ why we need alias here? (and in other imports)",Why did you change this?
+4614,"@@ -355,9 +355,11 @@ def data(readonly=False):
+              ""Hide the window decoration when using wayland ""
+              ""(requires restart)""),
+ 
+-            ('show-keyhints',
+-             SettingValue(typ.Bool(), 'true'),
+-             ""Show possible keychains based on the current keystring""),
++            ('keyhint-blacklist',
++             SettingValue(typ.List(none_ok=True), ''),
++             ""Keychains that shouldn't be shown in the keyhint dialog\n\n""
++             ""Globs are supported, so ';*' will blacklist all keychains""
++             ""starting with ';'. Use '*' to disable keyhints""),
+ 
+             readonly=readonly
+         )),","It'd be nice to fix up existing configs with the change - that'd mean adding the option to `RENAMED_OPTIONS` in `config.py` and adding something like `_get_value_transformer({'true': '', 'false': '*'})` to `CHANGED_OPTIONS`. I think I never tried adding an option to both, but it should work.",I think this should be `typ.List(n
+4615,"@@ -150,7 +150,7 @@ module.exports = {
+         TestCase.assertEqual(obj.arrayCol1[-1], undefined);
+         TestCase.assertEqual(obj.arrayCol1['foo'], undefined);
+ 
+-        for (let field of Object.keys(prim)) {
++        for (let field of Object.keys(Object.getPrototypeOf(prim))) {
+             TestCase.assertEqual(prim[field][2], undefined);
+             TestCase.assertEqual(prim[field][-1], undefined);
+             TestCase.assertEqual(prim[field]['foo'], undefined);",Perhaps use the new `.keys()` method here instead?,Why this change?
+4616,"@@ -79,9 +79,10 @@ func (b *builder) kubernetesDiff(
+ 		}
+ 	}
+ 
+-	result, err := provider.DiffList(oldManifests, newManifests,
++	result, err := provider.DiffList(
++		oldManifests,
++		newManifests,
+ 		diff.WithEquateEmpty(),
+-		diff.WithIgnoreAddingMapKeys(),
+ 		diff.WithCompareNumberAndNumericString(),
+ 	)
+ 	if err != nil {","We don't need this option because plan-preview is comparing between 2 commits, not using the live state.",Why is this no longer needed?
+4617,"@@ -37,6 +37,11 @@ module Beaker
+       # @param [Proc] block The actions to be performed in this step.
+       def step step_name, &block
+         logger.notify ""\n  * #{step_name}\n""
++        if @options
++          @options[:current_test_info] ||= {}
++          @options[:current_test_info][:step] ||= {}
++          @options[:current_test_info][:step][:name] = step_name
++        end
+         yield if block_given?
+       end
+ ","I'm not sure about putting this in the options. I would see it living in an object and then being queried on through a class - a more object oriented, ruby solution.",Why do we need this?
+4618,"@@ -237,7 +237,8 @@ func (card *DRICard) readPowerConsumption() (float64, error) {
+ 	return 0, fmt.Errorf(""cannot find average power consumption param in the amdgpu_pm_info"")
+ }
+ 
+-func (card *DRICard) Metrics() (*DRICardMetrics, error) {
++// Status returns hardware stats for the card
++func (card *DRICard) Status() (*DRICardMetrics, error) {
+ 	if len(card.HwmonPath) == 0 {
+ 		return nil, fmt.Errorf(""metrics interface is not available for %s"", card.Name)
+ 	}",So `Status` returns metrics?,Why is this change needed?
+4619,"@@ -3,6 +3,8 @@ class OrganizationsController < ApplicationController
+   helper RatingsHelper
+ 
+   before_action :find_organization
++  before_action :set_outside_committers, only: :outside_committers
++  before_action :organization_context, only: :outside_committers
+ 
+   def outside_projects
+     @outside_projects = @organization.outside_projects((params[:page] || 1), 20)","Can we make a generic method say, `set_infographic_view` and in that method we can check the 4 values (outside_committers, portfolio_projects, outside_projects, affiliated_committers) and check against params[:action] and params[:view] and then trigger the respective method dynamically as it takes the standard argument(s) for all the four methods. What do you think?",Prefer single-quoted strings 
+4620,"@@ -56,7 +56,15 @@ public final class IcebergDateObjectInspectorHive3 extends AbstractPrimitiveJava
+ 
+   @Override
+   public Object copyObject(Object o) {
+-    return o == null ? null : new Date((Date) o);
++    if (o == null) {
++      return null;
++    }
++
++    if (o instanceof Date) {
++      return new Date((Date) o);
++    } else {
++      return o;
++    }
+   }
+ 
+ }",Why would this be called to copy a non-Date object?,I don't think this is the right way to do this. I think it should be `return o instanceof Date ? o : new Date((Date) o);`
+4621,"@@ -77,13 +77,13 @@ func (msg *Boolmsg) Serialize() []byte {
+ 	native.PutUint16(buf[0:2], uint16(msg.Len()))
+ 	native.PutUint16(buf[2:4], msg.Type)
+ 	if msg.Value {
+-		buf[4] = 1
++		native.PutUint32(buf[4:8], uint32(1))
+ 	} else {
+-		buf[4] = 0
++		native.PutUint32(buf[4:8], uint32(0))
+ 	}
+ 	return buf
+ }
+ 
+ func (msg *Boolmsg) Len() int {
+-	return unix.NLA_HDRLEN + 1
++	return unix.NLA_HDRLEN + 4 // alignment
+ }",This alignment issue had not appear because no multiple `Boolmsg`s had been serialized at once.,Why do we need to change this?
+4622,"@@ -71,7 +71,7 @@ func DefaultConfig() Config {
+ 		PauseContainerTag:                   DefaultPauseContainerTag,
+ 		AWSVPCBlockInstanceMetdata:          false,
+ 		ContainerMetadataEnabled:            false,
+-		TaskCPUMemLimit:                     DefaultEnabled,
++		TaskCPUMemLimit:                     BooleanDefaultTrue{Value: NotSet},
+ 		CgroupPath:                          defaultCgroupPath,
+ 		TaskMetadataSteadyStateRate:         DefaultTaskMetadataSteadyStateRate,
+ 		TaskMetadataBurstRate:               DefaultTaskMetadataBurstRate,","Why are we not implementing a BooleanDefaultFalse struct and replacing all of these config vars that default to false with that? Are ""default false"" config vars not affected by this bug?",I think this should be `BooleanDefaultTrue{Value: true}`
+4623,"@@ -9,7 +9,7 @@ class RolesController < ApplicationController
+     authorize @role
+ 
+     access_level = params[:role][:access_level].to_i
+-    @role.set_access_level(access_level)
++    @role.access_level = access_level
+     message = ''
+     if params[:user].present?
+       if @role.plan.owner.present? && @role.plan.owner.email == params[:user]",Replaced this method with a ruby idiomatic setter.,Line is too long. [81/80]
+4624,"@@ -2,7 +2,7 @@
+  * The Forgotten Server - a free and open-source MMORPG server emulator
+  * Copyright (C) 2017 Mark Samman <mark.samman@gmail.com>
+  *
+- * This program is free software; you can redistribute it and/or modify
++ * This program is free tisoftware; you can redistribute it and/or modify
+  * it under the terms of the GNU General Public License as published by
+  * the Free Software Foundation; either version 2 of the License, or
+  * (at your option) any later version.",wrong place hehe,This should be tisoftware
+4625,"@@ -0,0 +1,14 @@
++require 'travis/build/appliances/base'
++
++module Travis
++  module Build
++    module Appliances
++      class RestartMysql < Base
++        def apply
++          sh.cmd '(ls /var/run/mysqld/mysqld.sock >& /dev/null) || sudo service mysql restart'
++        end
++      end
++    end
++  end
++end
++","Can this be `test -e /var/run/mysqld/mysqld.sock` instead of `ls`? Using `ls` for noninteractive stuff is a recipe for sadness, IMHO. /cc @tianon",I think this should be `s
+4626,"@@ -30,12 +30,12 @@ class Proposal < ActiveRecord::Base
+   has_many :individual_approvals, ->{ individual }, class_name: 'Approvals::Individual'
+   has_many :approvers, through: :individual_approvals, source: :user
+   has_many :api_tokens, through: :individual_approvals
+-  has_many :attachments
++  has_many :attachments, dependent: :destroy
+   has_many :approval_delegates, through: :approvers, source: :outgoing_delegates
+-  has_many :comments
++  has_many :comments, dependent: :destroy
+   has_many :observations, -> { where(""proposal_roles.role_id in (select roles.id from roles where roles.name='observer')"") }
+   has_many :observers, through: :observations, source: :user
+-  belongs_to :client_data, polymorphic: true
++  belongs_to :client_data, polymorphic: true, dependent: :destroy
+   belongs_to :requester, class_name: 'User'
+ 
+   # The following list also servers as an interface spec for client_datas","Are these `dependent: destroy` attributes intended to implement cascading deletes? I had assumed they were added because of the `paranoia` gem, but since that is no longer part of this PR, are they here as a best practice?",I think this should be `d
+4627,"@@ -1452,6 +1452,7 @@ static void establish_tunnel(h2o_req_t *req, h2o_tunnel_t *tunnel, uint64_t idle
+     h2o_iovec_t datagram_flow_id = {};
+ 
+     if (stream->tunnel == NULL) {
++        tunnel->destroy(tunnel);
+         /* the tunnel has been closed in the meantime */
+         return;
+     }","This approach would work only if there's a guarantee that the stream does not get freed before `establish_tunnel` is called, even though it _may_ enter CLOSE_WAIT state (at which point `stream->tunnel` is set to NULL). I do not think that assumption holds. Hence the alternate approach.",Why do we need to call de
+4628,"@@ -5,8 +5,8 @@
+ 
+ nano::error nano::node_pow_server_config::serialize_toml (nano::tomlconfig & toml) const
+ {
+-	toml.put (""enable"", enable, ""Enable or disable starting Nano PoW Server as a child process.\ntype:bool"");
+-	toml.put (""nano_pow_server_path"", pow_server_path, ""Path to the nano_pow_server executable.\ntype:string,path"");
++	toml.put (""enable"", enable, ""Enable or disable starting Nano PoW Server as a child process\ntype:bool"");
++	toml.put (""nano_pow_server_path"", pow_server_path, ""Path to the nano_pow_server executable\ntype:string,path"");
+ 	return toml.get_error ();
+ }
+ ",Did you mean to remove the periods here while newly adding to other locations?,Why did you remove the \n?
+4629,"@@ -2014,7 +2014,7 @@ func (bps *blockPutState) removeOtherBps(other *blockPutState) {
+ 	// slice length.
+ 	newLen := len(bps.blockStates) - len(other.blockStates)
+ 	if newLen <= 0 {
+-		newLen = 1
++		newLen = 0
+ 	}
+ 
+ 	// Remove any blocks that appear in `other`.",the check can now be `if newLen < 0`,Why this change?
+4630,"@@ -8,18 +8,13 @@ import (
+ 	""os""
+ 	""time""
+ 
+-	""github.com/google/uuid""
+ 	log ""github.com/sirupsen/logrus""
+ 	""github.com/spf13/cobra""
+ 	""github.com/spf13/pflag""
+ 
+ 	apiextv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+-	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+-	""k8s.io/client-go/kubernetes""
+ 	_ ""k8s.io/client-go/plugin/pkg/client/auth/gcp""
+-	""k8s.io/client-go/tools/leaderelection""
+-	""k8s.io/client-go/tools/leaderelection/resourcelock""
+ 	""k8s.io/klog""
+ 	apiregistrationv1 ""k8s.io/kube-aggregator/pkg/apis/apiregistration/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client/config""","If we're going to clean up this package, can we also remove those two `_` imports that appear to serve no purpose? (FWIW, they're also in the manager package too...)",Why is this removed?
+4631,"@@ -28,14 +28,13 @@ typedef boost::tokenizer<boost::char_separator<char> > tokenizer;
+ namespace ForceFields {
+ namespace MMFF {
+ 
+-class std::unique_ptr<MMFFAromCollection> MMFFAromCollection::ds_instance = nullptr;
+-
+ extern const std::uint8_t defaultMMFFArom[];
+ 
+ MMFFAromCollection *MMFFAromCollection::getMMFFArom(
+     const std::uint8_t *mmffArom) {
+-  if (!ds_instance || mmffArom) {
+-    ds_instance.reset(new MMFFAromCollection(mmffArom));
++  static std::unique_ptr<MMFFAromCollection> ds_instance(new MMFFAromCollection(nullptr));
++  if(mmffArom){
++    return new MMFFAromCollection(mmffArom);
+   }
+   return ds_instance.get();
+ }",Won't this leak like a sieve? The caller can't delete this as one is a unique_ptr and one is not.,Why did you remove this?
+4632,"@@ -360,6 +360,15 @@ class LocalStorage implements IStorage {
+       name,
+       (data, cb) => {
+         if (data._attachments[filename]) {
++          // get version form _attachments;
++          // there aways had 'version' in verdaccio publish package.
++          // but there was no 'version' in package witch unlink form npmjs
++          // see https://github.com/verdaccio/verdaccio/issues/1359
++          const version = data._attachments[filename].version;
++          if (version && data.versions[version] && data.time[version]) {
++            delete data.versions[version];
++            delete data.time[version];
++          }
+           delete data._attachments[filename];
+           cb();
+         } else {",form => from,I'm not sure if this is the best way to do this. I'm not sure if there is a better way to do this.
+4633,"@@ -28,6 +28,7 @@ public interface Rule extends PropertySource {
+      * The property descriptor to universally suppress violations with messages
+      * matching a regular expression.
+      */
++    // TODO 7.0.0 use PropertyDescriptor<Pattern>
+     StringProperty VIOLATION_SUPPRESS_REGEX_DESCRIPTOR = new StringProperty(""violationSuppressRegex"",
+             ""Suppress violations with messages matching a regular expression"", null, Integer.MAX_VALUE - 1);
+ ","Ok, we can't switch it now, because the properties are a field of the interface Rule - which makes it public API. Maybe we should remove it here in the (Java) API in 7.0.0? The only API left would be, when using a rule and setting the properties in the ruleset xml. There the type doesn't matter - since the String is then automatically converted into a Pattern.",I think we can remove this TODO.
+4634,"@@ -66,7 +66,9 @@ public class GoGapicSurfaceTransformerTest {
+             locator,
+             new String[] {""myproto_gapic.yaml""});
+ 
+-    productConfig = GapicProductConfig.create(model, configProto, TargetLanguage.GO);
++    productConfig =
++        GapicProductConfig.create(
++            model, configProto, ""google.example.myproto.v1"", TargetLanguage.GO);
+ 
+     if (model.getDiagReporter().getDiagCollector().hasErrors()) {
+       throw new IllegalStateException(","Pass in null here, instead of a value? Maaaaybe we should add an overload for `GapicProductConfig.create` that matches the original signature and passes through null? I don't feel strongly about that though, so happy to leave asis if you prefer.",Why is this needed?
+4635,"@@ -94,7 +94,7 @@ class CheckCompoundPattern {
+   CharsRef expandReplacement(CharsRef word, int breakPos) {
+     if (replacement != null && charsMatch(word, breakPos, replacement)) {
+       return new CharsRef(
+-          word.subSequence(0, breakPos)
++          new String(word.chars, 0, word.offset + breakPos)
+               + endChars
+               + beginChars
+               + word.subSequence(breakPos + replacement.length(), word.length));",Include all compounds parts from the very beginning for the case check to work later,"`word.chars.substring(word.offset + breakPos, word.chars.length)`"
+4636,"@@ -461,7 +461,7 @@ func get(envInfo *cmds.Agent, proxy proxy.Proxy) (*config.Node, error) {
+ 	}
+ 
+ 	if !nodeConfig.Docker && nodeConfig.ContainerRuntimeEndpoint == """" {
+-		nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.Containerd.Address
++		nodeConfig.AgentConfig.RuntimeSocket = ""unix://"" + nodeConfig.Containerd.Address
+ 	} else {
+ 		nodeConfig.AgentConfig.RuntimeSocket = nodeConfig.ContainerRuntimeEndpoint
+ 		nodeConfig.AgentConfig.CNIPlugin = true","if the user specifies a url scheme on the cli this is going to cause problems, no?",Why is this change needed?
+4637,"@@ -726,7 +726,7 @@ define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSetti
+             disableIndicators: true,
+             disableHoverMenu: true,
+             overlayPlayButton: true,
+-            width: dom.getWindowSize().innerWidth * 0.25
++            width: dom.getWindowSize().innerWidth * 0.5
+         });
+ 
+         elem.innerHTML = cardHtml;",How about that `scaleFactor`?,Why did you change this?
+4638,"@@ -273,6 +273,19 @@ class NonDivArithmeticOpAnalyzer
+         }
+     }
+ 
++    /**
++     * @param int|float $result
++     */
++    private static function getNumericalType($result): Type\Union
++    {
++        if ($result <= PHP_INT_MAX && $result >= PHP_INT_MIN) {
++            /** @var int $result */
++            return Type::getInt(false, $result);
++        }
++
++        return Type::getFloat($result);
++    }
++
+     /**
+      * @param  string[]        &$invalid_left_messages
+      * @param  string[]        &$invalid_right_messages","`assert(is_int($result));` would be preferable I think, even if we know it can't ever be false",Why do we need this?
+4639,"@@ -162,14 +162,14 @@ class Cart
+     /**
+      * @return \Shopsys\FrameworkBundle\Model\Order\Item\QuantifiedProduct[]
+      */
+-    public function getQuantifiedProductsIndexedByItemId()
++    public function getQuantifiedProducts()
+     {
+-        $quantifiedProductsByItemId = [];
++        $quantifiedProducts = [];
+         foreach ($this->items as $item) {
+-            $quantifiedProductsByItemId[$item->getId()] = new QuantifiedProduct($item->getProduct(), $item->getQuantity());
++            $quantifiedProducts[] = new QuantifiedProduct($item->getProduct(), $item->getQuantity());
+         }
+ 
+-        return $quantifiedProductsByItemId;
++        return $quantifiedProducts;
+     }
+ 
+     /**",I'm unfortunately unable to review whether you've changed everything that used to use cartIds,Why did you remove this me
+4640,"@@ -3,14 +3,15 @@ package de.danoeh.antennapod.dialog;
+ import android.app.Dialog;
+ import android.content.Context;
+ import android.content.SharedPreferences;
++import android.util.Log;
++
+ import androidx.annotation.Nullable;
+ import androidx.annotation.VisibleForTesting;
+-import android.util.Log;
++import androidx.appcompat.app.AlertDialog;
+ 
+ import java.lang.ref.WeakReference;
+ import java.util.concurrent.TimeUnit;
+ 
+-import androidx.appcompat.app.AlertDialog;
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.core.util.IntentUtils;
+ ",Please don't touch unrelated files to keep the git history clean,Please don't change unrelated files.
+4641,"@@ -0,0 +1,19 @@
++module AbTests
++  class LandingHeadlineTest < Base
++    def setup
++      variation(ab_test(test_name, ""orig"", ""v1""))
++    end
++
++    def finish
++      finished(test_name)
++    end
++
++  private
++
++    def variation(key)
++      # The :name value isn't needed in all variations. Passing it when it is 
++      # not needed allows for simpler code and will do no harm.
++      I18n.t(""headlines.landing.#{key}"", name: I18n.t('shared.subscription.name'))
++    end
++  end
++end","Per our style guide, I don't think we indent `private` keyword. Would you mind fixing that?",Extra empty line detected at class b
+4642,"@@ -54,7 +54,7 @@ def gen_gaussian_target(heatmap, center, radius, k=1):
+     masked_heatmap = heatmap[y - top:y + bottom, x - left:x + right]
+     masked_gaussian = gaussian_kernel[radius - top:radius + bottom,
+                                       radius - left:radius + right]
+-    out_heatmap = torch.zeros_like(heatmap)
++    out_heatmap = heatmap
+     torch.max(
+         masked_heatmap,
+         masked_gaussian * k,",Will this change the input `heatmap`? Is this behavior expected or not?,Why did this change?
+4643,"@@ -411,7 +411,7 @@ func init() {
+ 	runtime.RegisterPackageValue(""strings"", ""lastIndex"",
+ 		generateDualArgStringFunctionReturnInt(""lastIndex"", []string{stringArgV, substr}, strings.LastIndex))
+ 	runtime.RegisterPackageValue(""strings"", ""lastIndexAny"",
+-		generateDualArgStringFunctionReturnInt(""lastIndexAny"", []string{stringArgV, substr}, strings.LastIndexAny))
++		generateDualArgStringFunctionReturnInt(""lastIndexAny"", []string{stringArgV, chars}, strings.LastIndexAny))
+ 	runtime.RegisterPackageValue(""strings"", ""isDigit"",
+ 		generateUnicodeIsFunction(""isDigit"", unicode.IsDigit))
+ 	runtime.RegisterPackageValue(""strings"", ""isLetter"",","If I'm reading this right, this changes the parameter name so it'd constitute a breaking change :cold_sweat: Are we missing a test that should have been failing up until now?",Why do we need this change?
+4644,"@@ -1,8 +1,3 @@
+-/*
+-   Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-   SPDX-License-Identifier: Apache-2.0
+-*/
+-
+ package com.spring.sns;
+ 
+ import org.springframework.beans.factory.annotation.Autowired;",Need copyright/license info.,Why is this removed?
+4645,"@@ -3,10 +3,8 @@ package admissioncontroller
+ import (
+ 	""fmt""
+ 	""net/http""
+-	""strings""
+ 
+ 	admissionv1beta1 ""k8s.io/api/admission/v1beta1""
+-	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/klog/v2""
+ 
+ 	rulesv1 ""github.com/kubeedge/kubeedge/cloud/pkg/apis/rules/v1""","Is this `info log` necessary? If it is not useful, can you consider deleting it?",Why is this removed?
+4646,"@@ -103,7 +103,7 @@ func TestConfigLoadEncryptedFailures(t *testing.T) {
+ 	err = config.Data().Load()
+ 	require.Error(t, err)
+ 
+-	// This file contains invalid base64 characters.
++	// This file's header starts with RCLONE_ENCRYPT_V1 instead of V0.
+ 	assert.NoError(t, config.SetConfigPath(""./testdata/enc-too-new.conf""))
+ 	err = config.Data().Load()
+ 	require.Error(t, err)","Unrelated change, but seems to be the correct purpose of the test.",Why did this change?
+4647,"@@ -142,6 +142,7 @@ module.exports = class DragDrop extends Plugin {
+     const restrictions = this.uppy.opts.restrictions
+     return (
+       <input
++        id={'input-' + this.id}
+         class=""uppy-DragDrop-input""
+         type=""file""
+         tabindex={-1}",Should it be `'uppy-input-`?,Why do we need this?
+4648,"@@ -191,7 +191,7 @@ static inline double mtrace(int n,double A[8][8],double B[8][8]) {
+ 
+ void PairMGPT::make_triplet(bond_data *ij_bond,bond_data *ik_bond,
+                              triplet_data *triptr) {
+-  if (1) {
++  if (true) {
+     const trmul_fun tr_mul = linalg.tr_mul;
+     tr_mul(&(ij_bond->H.m[1][0]), &(ik_bond->H.m[1][0]) ,&(triptr->H1H2.m[1][0]) );
+     tr_mul(&(ij_bond->Hx.m[1][0]),&(ik_bond->H.m[1][0]) ,&(triptr->H1xH2.m[1][0]));",what's the reasoning to keep these always true or dead-code blocks?,Why is this change needed?
+4649,"@@ -351,4 +351,13 @@ $(document).ready(function() {
+             }
+         });
+     }
++
++    $('body').on('click', '.tab-buttons > div', function() {
++        if ($(this).next().length === 1) {
++            $('.widget-content').addClass('hide-zoom');
++        }
++        else {
++            $('.widget-content').removeClass('hide-zoom');
++        }
++    });
+ });","It would be a good practice to do `.off('click', '.tab-buttons > div').on('click', '.tab-buttons > div', function() {`",Expected indentation of 2 
+4650,"@@ -307,9 +307,12 @@ func buildControllerContext(ctx context.Context, opts *options.ControllerOptions
+ 		KubeSharedInformerFactory: kubeSharedInformerFactory,
+ 		SharedInformerFactory:     sharedInformerFactory,
+ 		GWShared:                  gwSharedInformerFactory,
+-		Namespace:                 opts.Namespace,
+-		Clock:                     clock.RealClock{},
+-		Metrics:                   metrics.New(log, clock.RealClock{}),
++		// TODO (@jakexks) / code reviewer: should this be automatically enabled or disabled based on discovering the gateway
++		// api or a flag?
++		GatewaySolverEnabled: true,
++		Namespace:            opts.Namespace,
++		Clock:                clock.RealClock{},
++		Metrics:              metrics.New(log, clock.RealClock{}),
+ 		ACMEOptions: controller.ACMEOptions{
+ 			HTTP01SolverImage:                 opts.ACMEHTTP01SolverImage,
+ 			HTTP01SolverResourceRequestCPU:    HTTP01SolverResourceRequestCPU,","I suggest that we rely on `--controllers='*,gateway-shim'` for now, and we can then move from `--controllers='*,gateway-shim'` to automatically enabling the Gateway API support on startup using the discovery API in 1.6 or 1.7, what do you think? Note that the logic I wrote in e5436df521015057e77de3fe02c174ea8a863b93 should also use this `GatewaySolverEnabled` flag I think.",I don't think this should 
+4651,"@@ -1180,6 +1180,7 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+ 
+     try {
+       configureLogging(true);
++      instantiateSignatureAlgorithmFactory();
+       configureNativeLibs();
+       logger.info(""Starting Besu version: {}"", BesuInfo.nodeName(identityString));
+       // Need to create vertx after cmdline has been parsed, such that metricsSystem is configurable","I moved the instantiation of the signature algorithm here, to execute it before the native libraries are configured. Otherwise the wrong signature algorithm could be configured in a future release when more than one is supported in Besu.",Why do we need this?
+4652,"@@ -1,11 +1,16 @@
++from typing import TYPE_CHECKING
++
+ from astroid import nodes
+ 
+ from pylint.checkers import BaseChecker
+ from pylint.interfaces import IAstroidChecker
+ 
++if TYPE_CHECKING:
++    from pylint.lint import PyLinter
+ 
+-# This is our checker class.
+ # Checkers should always inherit from `BaseChecker`.
++
++
+ class MyAstroidChecker(BaseChecker):
+     """"""Add class member attributes to the class local's dictionary.""""""
+ ",Why remove this?,Why is this needed?
+4653,"@@ -490,6 +490,18 @@ class Builder {
+     return this;
+   }
+ 
++  /**
++   * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
++   * child process when creating IE sessions locally.
++   *
++   * @param {ie.ServiceBuilder} service the service to use.
++   * @return {!Builder} a self reference.
++   */
++  setIeService(service) {
++    this.ieService_ = service;
++    return this;
++  }
++
+   /**
+    * Set {@linkplain edge.Options options} specific to Microsoft's Edge browser
+    * for drivers created by this builder. Any proxy settings defined on the",`this.ieService_` should be initialized to null in the constructor.,nit: `@return {!Bui
+4654,"@@ -394,7 +394,7 @@ int main(int argc, char **argv)
+         cflags.push_back(generate_header_filter_cflag(response_header_filters));
+     }
+ 
+-    ebpf::BPF *bpf = new ebpf::BPF();
++    std::unique_ptr<ebpf::BPF> bpf(new ebpf::BPF());
+     std::vector<ebpf::USDT> probes;
+ 
+     bool selective_tracing = false;","Why not `ebpf::BPF bpf;`? Assuming that the instance is not huge, I do not think there is a good reason to use a pointer when it can be retained as a value.",Why do we need a un
+4655,"@@ -19,8 +19,11 @@ package controller
+ import (
+ 	""errors""
+ 	""fmt""
++	""strings""
+ 	""time""
+ 
++	apiutil ""github.com/jetstack/cert-manager/pkg/api/util""
++
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 
+ 	cmapi ""github.com/jetstack/cert-manager/pkg/apis/certmanager/v1""",nit: move to last block,nit: this import sh
+4656,"@@ -15,8 +15,8 @@ import (
+ 	""syscall""
+ 
+ 	""github.com/hashicorp/hcl""
+-	""github.com/spiffe/spire/helpers""
+ 	""github.com/spiffe/spire/pkg/agent""
++	""github.com/spiffe/spire/pkg/common/logger""
+ )
+ 
+ const (","nit: I'm under the impression that `log` is the convention for golang, and that the `er` suffix is usually reserved for interfaces",I think this should be `spire/logger`
+4657,"@@ -272,6 +272,12 @@ namespace NLog.Targets
+         [ArrayParameter(typeof(DatabaseParameterInfo), ""parameter"")]
+         public IList<DatabaseParameterInfo> Parameters { get; } = new List<DatabaseParameterInfo>();
+ 
++        /// <summary>
++        /// Configures isolated transaction batch writing. If supported by the database, then it will improve insert performance.
++        /// </summary>
++        /// <docgen category='Performance Tuning Options' order='10' />
++        public System.Data.IsolationLevel? IsolationLevel { get; set; }
++
+ #if !NETSTANDARD
+         internal DbProviderFactory ProviderFactory { get; set; }
+ ",Why is IsolationLevel fully qualified? System.Data is already in scope? What do I miss?,Why is this nullable?
+4658,"@@ -24,15 +24,8 @@ var (
+ 
+ // Action is the action can be Executed in protocols. The method is added to avoid mistakenly used empty interface as action.
+ type Action interface {
+-	SetEnvelopeContext(SealedEnvelope)
+-	SanityCheck() error
+-}
+-
+-type actionPayload interface {
+-	Serialize() []byte
+ 	Cost() (*big.Int, error)
+ 	IntrinsicGas() (uint64, error)
+-	SetEnvelopeContext(SealedEnvelope)
+ 	SanityCheck() error
+ }
+ ",do we still need SanityCheck()? seems they all return nil now,Why is this removed?
+4659,"@@ -94,7 +94,6 @@ export default function Core(rootElement, userSettings, rootInstanceSymbol = fal
+    * @type {HTMLElement}
+    */
+   this.rootElement = rootElement;
+-  /* eslint-enable jsdoc/require-description-complete-sentence */
+   /**
+    * The nearest document over container.
+    *","What I am missing in this PR, and I think we discussed that on the weekly meeting, is that all the code snippets that advise using `loadData` should be changed to one of the two new methods. Otherwise we send confusing mixed signals by promoting `loadData` everywhere in the guides. `loadData` is not deprecated, but is legacy.",Why is this removed?
+4660,"@@ -48,4 +48,4 @@ doc.css(""h1, h2, h3, h4, h5, h6"").each do |header|
+ end
+ 
+ puts ""\n==================================================\n""
+-puts ""!!! Don't forget to set a summary: https://#{ENV.fetch(""APP_DOMAIN"")}/admin/video/#{video.id}/edit""
++puts ""!!! Don't forget to set a summary: https://thoughtbot.com/upcase/admin/video/#{video.id}/edit""",Line is too long. [100/80],Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+4661,"@@ -532,8 +532,12 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
+ 		return err
+ 	}
+ 
+-	if !gopts.JSON && parentSnapshotID != nil {
+-		p.V(""using parent snapshot %v\n"", parentSnapshotID.Str())
++	if !gopts.JSON {
++		if parentSnapshotID != nil {
++			p.P(""using parent snapshot %v\n"", parentSnapshotID.Str())
++		} else {
++			p.P(""no parent snapshot found, will read all files\n"")
++		}
+ 	}
+ 
+ 	selectByNameFilter := func(item string) bool {","I suggest ""no parent snapshot found, will read all data\n"".","I think this should be `p.P(""using parent snapshot %v"", parentSnapshotID)`"
+4662,"@@ -48,9 +48,7 @@ namespace NLog.UnitTests
+         {
+             using (new NoThrowNLogExceptions())
+             {
+-                LogManager.ThrowExceptions = true;
+-
+-                LogManager.Configuration = XmlLoggingConfiguration.CreateFromXmlString(@""
++                var config = XmlLoggingConfiguration.CreateFromXmlString(@""
+                 <nlog throwExceptions='false'>
+                     <targets><target type='MethodCall' name='test' methodName='Throws' className='NLog.UnitTests.LogFactoryTests, NLog.UnitTests.netfx40' /></targets>
+                     <rules>",`LogManager.ThrowExceptions = true` has very special meaning when unit-testing. Why the change to `LogFactory.ThrowExceptions = true` and enabling after the config-load?,Why did you remove this?
+4663,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return ""'"" + value + ""'"";
+ 	} else {
+-		return '""""';
++		return ""'"";
+ 	}
+ }
+ ","It should be return ""''""; I will fix it",Why did you remove the quotes?
+4664,"@@ -100,11 +100,10 @@ public class AcceptanceTest extends STBBaseTst {
+         ASTMethodDeclaration node = acu.findDescendantsOfType(ASTMethodDeclaration.class).get(0);
+         Scope s = node.getScope();
+         Map<NameDeclaration, List<NameOccurrence>> m = s.getDeclarations();
+-        for (Iterator<NameDeclaration> i = m.keySet().iterator(); i.hasNext();) {
+-            NameDeclaration d = i.next();
+-            assertEquals(""buz"", d.getImage());
+-            assertEquals(""ArrayList"", ((TypedNameDeclaration) d).getTypeImage());
+-            List<NameOccurrence> u = m.get(d);
++        for (Map.Entry<NameDeclaration, List<NameOccurrence>> entry : m.entrySet()) {
++            assertEquals(""buz"", entry.getKey().getImage());
++            assertEquals(""ArrayList"", ((TypedNameDeclaration) entry.getKey()).getTypeImage());
++            List<NameOccurrence> u = m.get(entry.getKey());
+             assertEquals(1, u.size());
+             NameOccurrence o = u.get(0);
+             int beginLine = o.getLocation().getBeginLine();","This is wrong, should be `entry.getValue()`",Why did you change this to a Map.Entry?
+4665,"@@ -363,7 +363,7 @@ func (r *ReconcileControlPlaneCerts) getServingCertificatesJSONPatch(cd *hivev1.
+ 			additional.Domain, remoteSecretName(bundle.CertificateSecretRef.Name, cd)))
+ 	}
+ 
+-	var kubeAPIServerNamedCertsTemplate = `[ { ""op"": ""replace"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [ %s ] } ]`
++	var kubeAPIServerNamedCertsTemplate = `[ { ""op"": ""add"", ""path"": ""/spec/servingCerts"", ""value"": {} }, { ""op"": ""add"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [  ] }, { ""op"": ""replace"", ""path"": ""/spec/servingCerts/namedCertificates"", ""value"": [ %s ] } ]`
+ 	namedCerts := buf.String()
+ 	return fmt.Sprintf(kubeAPIServerNamedCertsTemplate, namedCerts), nil
+ ","nit: why can't we combine the two add operations into one so that we add `{""nameCertificates"": []}` to `/spec/servingCerts` ?",Why is this change needed?
+4666,"@@ -3,13 +3,14 @@
+ // See the LICENSE file in the project root for more information.
+ 
+ // ==++==
+-// 
+- 
+-// 
++//
++
++//
+ // ==--==
+ #include <assert.h>
+ #include ""sos.h""
+ #include ""safemath.h""
++#include ""holder.h""
+ 
+ 
+ // This is the increment for the segment lookup data",These whitespace only changes make it very difficult to review this change. Is there any way you could separate just the code changes into one PR and the whitespace only fixes into another? Or are they sufficiently merged together at this point? Chrome is having a real tough time rendering these large diffs.,Why is this needed?
+4667,"@@ -19,11 +19,13 @@ public abstract class RoomHandler
+ 
+ 	protected final Client client;
+ 	protected final TheatrePlugin plugin;
++	protected final TheatreConfig config;
+ 
+-	protected RoomHandler(final Client client, final TheatrePlugin plugin)
++	protected RoomHandler(final Client client, final TheatrePlugin plugin, TheatreConfig config)
+ 	{
+ 		this.client = client;
+ 		this.plugin = plugin;
++		this.config = config;
+ 	}
+ 
+ 	public abstract void onStart();",why does this suddenly need a config ref,Why is this needed?
+4668,"@@ -99,6 +99,10 @@ module.exports = function(config) {
+ 		customLaunchers: sauceLabs ? sauceLabsLaunchers : travisLaunchers,
+ 
+ 		files: [
++			// We can't load this up front because it's ES2015 and we need it only
++			// for certain tests that run under those conditions. We also can't load
++			// it via CDN because { included: false } won't work.
++			{ pattern: 'custom-elements-es5-adapter.js', included: false },
+ 			{ pattern: 'polyfills.js', watched: false },
+ 			{ pattern: '{browser,shared}/**.js', watched: false }
+ 		],","Unfortunately, I couldn't find a way to get karma to conditionally load stuff from a CDN, so I had to include it.",I'm not sure if this is the best way to do this. I'm not sure what the best way to do this is.
+4669,"@@ -67,6 +67,10 @@ exclude = [""AuthalicMatrixCoefficients"",
+            ""vnl_file_matrix"",
+            ""vnl_file_vector"",
+            ""vnl_fortran_copy"",
++           ""CosineWindowFunction"",
++           ""HammingWindowFunction"",
++           ""LanczosWindowFunction"",
++           ""WelchWindowFunction"",
+            ]
+ 
+ total = 0","Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now).",Why is this a<msg>I don't think it should be part of the public API?
+4670,"@@ -27,7 +27,7 @@ import (
+ // This little bit of wrapping needs to be done because go doesn't do
+ // covariance, but it does coerce *time.Timer into stoppable implicitly if we
+ // write it out like so.
+-var afterFunc = func(c clock.Clock, d time.Duration, f func()) stoppable {
++func afterFunc(c clock.Clock, d time.Duration, f func()) stoppable {
+ 	t := c.NewTimer(d)
+ 
+ 	go func() {","Nit: since this is now a private function rather than a variable, would it make sense to move it after the public functions in this file for readability?",I don't think this change is necessary.
+4671,"@@ -27,8 +27,7 @@ MolDraw2DQt::MolDraw2DQt(int width, int height, QPainter &qp, int panelWidth,
+ // ****************************************************************************
+ void MolDraw2DQt::setColour(const DrawColour &col) {
+   MolDraw2D::setColour(col);
+-  QColor this_col(int(255.0 * col.get<0>()), int(255.0 * col.get<1>()),
+-                  int(255.0 * col.get<2>()));
++  QColor this_col(int(255.0 * col.r), int(255.0 * col.g), int(255.0 * col.b));
+ 
+   QPen pen(this_col);
+   pen.setJoinStyle(Qt::RoundJoin);",I'm assuming that MolDraw2Qt drops the alpha channel?,Why the change from `QColor` to `QColor`?
+4672,"@@ -24,6 +24,9 @@ namespace System.Text.Json.Serialization.Tests
+     [GenericTypeArguments(typeof(HashSet<string>))]
+     [GenericTypeArguments(typeof(ArrayList))]
+     [GenericTypeArguments(typeof(Hashtable))]
++    [GenericTypeArguments(typeof(SimpleStructWithProperties))]
++    [GenericTypeArguments(typeof(LargeStructWithProperties))]
++    [GenericTypeArguments(typeof(int))]
+     public class ReadJson<T>
+     {
+         private string _serialized;","the code looks good to me, but I just wonder if it is a real use case: (de)serializing a single integer.",Why is this needed?
+4673,"@@ -472,7 +472,18 @@ class Composition(collections.Hashable, collections.Mapping, MSONable):
+ 
+         Returns:
+             Composition with that formula.
++
++        Notes:
++            In the case of Metallofullerene formula (e.g. Y3N@C80),
++            the @ mark will be dropped and passed to parser.
+         """"""
++        print(formula)
++        # for Metallofullerene like ""Y3N@C80""
++        if ""@"" in formula:
++            print(formula)
++            formula = formula.replace(""@"", """")
++            print(formula)
++
+         def get_sym_dict(f, factor):
+             sym_dict = collections.defaultdict(float)
+             for m in re.finditer(r""([A-Z][a-z]*)\s*([-*\.\d]*)"", f):","Pls remove the print statements. Also, you do not need the if statement.",Please remove these
+4674,"@@ -112,7 +112,7 @@ def patch_moto():
+ 
+     # escape message responses to allow for special characters like ""<""
+     sqs_responses.RECEIVE_MESSAGE_RESPONSE = sqs_responses.RECEIVE_MESSAGE_RESPONSE.replace(
+-        ""<StringValue>{{ value.string_value }}</StringValue>"",
++        ""<StringValue><![CDATA[{{ value.string_value }}]]></StringValue>"",
+         ""<StringValue>{{ _escape(value.string_value) }}</StringValue>"",
+     )
+ ","Thanks for this fix @eltone !   Wondering if we should make this a bit more resilient to upstream changes, e.g., via a regex replacement. Not critical, though - we can pick that up in a follow-up PR.. Thanks",Why do we need this
+4675,"@@ -91,6 +91,7 @@ func newSimpleClientV7(url string) (*clientV7, error) {
+ 	var err error
+ 	if client, err = elastic.NewClient(
+ 		elastic.SetURL(url),
++		elastic.SetSniff(false),
+ 		elastic.SetRetrier(retrier),
+ 	); err != nil {
+ 		return nil, err",Should this be instead a configurable option?,Why is this needed?
+4676,"@@ -64,6 +64,13 @@ func (c *CreateDisks) run(ctx context.Context, s *Step) DError {
+ 				}
+ 			}
+ 
++			// Get the source snapshot link if using a source snapshot.
++			if cd.SourceSnapshot != """" {
++				if snapshot, ok := w.snapshots.get(cd.SourceSnapshot); ok {
++					cd.SourceSnapshot = snapshot.link
++				}
++			}
++
+ 			w.LogStepInfo(s.name, ""CreateDisks"", ""Creating disk %q."", cd.Name)
+ 			if err := w.ComputeClient.CreateDisk(cd.Project, cd.Zone, &cd.Disk); err != nil {
+ 				// Fallback to pd-standard to avoid quota issue.",unit test needs an update?,I don't think this is the right place to do this. We should be able to get the source snapshot from the `cd` object.
+4677,"@@ -12,7 +12,6 @@ module.exports = class Provider extends RequestClient {
+     super(uppy, opts)
+     this.provider = opts.provider
+     this.id = this.provider
+-    this.authProvider = opts.authProvider || this.provider
+     this.name = this.opts.name || _getName(this.id)
+     this.pluginId = this.opts.pluginId
+     this.tokenKey = `companion-${this.pluginId}-auth-token`",I realised that this is not used anywhere,Why was this removed?
+4678,"@@ -187,6 +187,7 @@ func watchConfig(cfg *config.Config, stopCh <-chan struct{}) {
+ 				case <-stopCh:
+ 					close(sigChan)
+ 					return
++				default:
+ 				}
+ 			}
+ 		}()",why add the default branch? this may cause there exist multiple configWatchers that notify the eventsCh at the same time?,Why is this needed?
+4679,"@@ -1477,6 +1477,8 @@ func handleUSB(intr interrupt.Interrupt) {
+ 			// clear stall request
+ 			setEPINTENCLR(0, sam.USB_DEVICE_EPINTENCLR_STALL1)
+ 		}
++	} else {
++		sendZlp()
+ 	}
+ 
+ 	// Now the actual transfer handlers, ignore endpoint number 0 (setup)",This line appears to have caused the regression. What is it supposed to be doing?,Shouldn't this be `} else {`?
+4680,"@@ -54,10 +54,8 @@ class ProxyType:
+         value = str(value).upper()
+         for attr in dir(cls):
+             attr_value = getattr(cls, attr)
+-            if isinstance(attr_value, dict) and \
+-                    'string' in attr_value and \
+-                    attr_value['string'] is not None and \
+-                    attr_value['string'] == value:
++            # `attr_value['string'] is not None` probably not required as `attr_value['string'] == value`
++            if isinstance(attr_value, dict) and 'string' in attr_value and attr_value['string'] == value:
+                 return attr_value
+         raise Exception(f""No proxy type is found for {value}"")
+ ",# `attr_value['string'] is not None` probably not required as `attr_value['string'] == value` check is already being done,I don't understand this change.
+4681,"@@ -39,13 +39,11 @@ namespace OpenTelemetry.Metrics
+             configure?.Invoke(options);
+ 
+             var exporter = new PrometheusExporter(options);
+-
+-            var metricReader = new BaseExportingMetricReader(exporter);
+-            exporter.CollectMetric = metricReader.Collect;
++            var reader = new BaseExportingMetricReader(exporter);
+ 
+             var metricsHttpServer = new PrometheusExporterMetricsHttpServer(exporter);
+             metricsHttpServer.Start();
+-            return builder.AddMetricReader(metricReader);
++            return builder.AddMetricReader(reader);
+         }
+     }
+ }","@alanwest I noticed this while changing the code. I think we _might_ run into some race condition - if a scraper happens to hit the HTTP server before we could add the reader, what would happen (I guess we will hit exception, which turns into HTTP 500)? I haven't looked into the HTTP server logic. I think it _might_ be OKAY. A better version could be - we only start the HTTP server once the exporter/reader are fully ready and both are hooked up to the provider.",Why did you remove this?
+4682,"@@ -224,7 +224,13 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests.AspNetCore
+ 
+                 if (!process.HasExited)
+                 {
+-                    process.Kill();
++                    // Try shutting down gracefully
++                    await SubmitRequest(aspNetCorePort, ""/shutdown"");
++
++                    if (!process.WaitForExit(5000))
++                    {
++                        process.Kill();
++                    }
+                 }
+ 
+                 SpanTestHelpers.AssertExpectationsMet(Expectations, spans);","As for Owin, I think we should exclude this URL in `IsNotServerLifeCheck` too?",Why is this necessary?
+4683,"@@ -0,0 +1,16 @@
++using System;
++using System.Net.Http;
++
++namespace OpenTelemetry.Exporter
++{
++    public interface IHttpClientFactoryExporterOptions
++    {
++        /// <summary>
++        /// Gets or sets the factory function called to create the <see
++        /// cref=""HttpClient""/> instance that will be used at runtime to
++        /// transmit telemetry over HTTP. The returned instance will be reused
++        /// for all export invocations.
++        /// </summary>
++        public Func<HttpClient> HttpClientFactory { get; set; }
++    }
++}",Does it make sense to just fold these options back into the exporter options? My thinking is that this option is unlike the processor/metric reader options in that it actually is about the exporter itself.,I think this should be `IHttpCl
+4684,"@@ -12,6 +12,6 @@ return [
+     |
+     */
+ 
+-    'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'failed' => 'یہ تفصیلات درست نہیں ہیں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈ میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing,Why did you remove the `:seconds`?
+4685,"@@ -149,7 +149,7 @@ class KeywordArgument(object):
+     func = lambda arg=arg: arg * arg # [undefined-variable]
+ 
+     arg2 = 0
+-    func2 = lambda arg2=arg2: arg2 * arg2
++    func3 = lambda arg2=arg2: arg2 * arg2
+ 
+ # Don't emit if the code is protected by NameError
+ try:",change of name is not needed,func3 = lambda arg2: arg2 * arg
+4686,"@@ -120,10 +120,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         self.assertEqual(kser.name, ""renamed"")
+         self.assert_eq(kser, pser)
+ 
+-        pser.name = None
+-        kser.name = None
+-        self.assertEqual(kser.name, None)
+-        self.assert_eq(kser, pser)
++        # pser.name = None
++        # kser.name = None
++        # self.assertEqual(kser.name, None)
++        # self.assert_eq(kser, pser)
+ 
+         pidx = pser.index
+         kidx = kser.index",Hm .. so this case doesn't work anymore?,Why are these tests disabled?
+4687,"@@ -22,7 +22,8 @@
+ import os
+ import tempfile
+ 
+-from PyQt5.QtCore import pyqtSignal, pyqtSlot, QObject, QProcess
++from PyQt5.QtCore import (pyqtSignal, pyqtSlot, QObject, QProcess,
++    QFileSystemWatcher)
+ 
+ from qutebrowser.config import config
+ from qutebrowser.utils import message, log",Please indent this so it lines up with the `(`,Why is this import needed?
+4688,"@@ -23,10 +23,11 @@ function roots_scripts() {
+   if (is_single() && comments_open() && get_option('thread_comments')) {
+     wp_enqueue_script('comment-reply');
+   }
+-
+-  wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
++  
++  // Not included by default since this code is used for debugging javas in the console. Uncomment next line and wp_enqueue_script below to use it.
++  //wp_register_script('roots_plugins', get_template_directory_uri() . '/js/plugins.js', false, null, false);
+   wp_register_script('roots_main', get_template_directory_uri() . '/js/main.js', false, null, false);
+-  wp_enqueue_script('roots_plugins');
++  //wp_enqueue_script('roots_plugins');
+   wp_enqueue_script('roots_main');
+ }
+ ",We should still register the script. Just not enqueue it.,I think we can remove this line.
+4689,"@@ -20,7 +20,7 @@ module Mongoid #:nodoc:
+     def changes
+       {}.tap do |hash|
+         changed.each do |name|
+-          change = attribute_change(name)
++          change = [changed_attributes[name], attributes[name]] if attribute_changed?(name)
+           hash[name] = change if change[0] != change[1]
+         end
+       end",I think this can stay as a method. And we can write our own attribute_change(name) as required.,I don't think you need the `chan
+4690,"@@ -142,7 +142,8 @@ namespace MvvmCross.DroidX.RecyclerView
+ 
+         protected virtual View InflateViewForHolder(ViewGroup parent, int viewType, IMvxAndroidBindingContext bindingContext)
+         {
+-            return bindingContext.BindingInflate(viewType, parent, false);
++            var layoutId = ItemTemplateSelector.GetItemLayoutId (viewType);
++            return bindingContext.BindingInflate(layoutId, parent, false);
+         }
+ 
+         public override void OnBindViewHolder(AndroidX.RecyclerView.Widget.RecyclerView.ViewHolder holder, int position)","@alexshikov @Cheesebaron I might be missing something but isn't the viewType parameter here the actual layout resource id? Why would the GetItemLayoutId method need to be called again? On line 127, the exact same method is called except this time passing in the index of the object in the backing data source, which makes sense - the template selector can return the layout id based on the index of the item in the list.",I don't think we need to call `G
+4691,"@@ -96,6 +96,9 @@ class BQTable(collections.namedtuple('BQTable', 'project_id dataset_id table_id'
+         return ""bq://"" + self.project_id + ""/"" + \
+                self.dataset.dataset_id + ""/"" + self.table_id
+ 
++    def __str__(self):
++        return ""%s:%s.%s"" % (self.project_id, self.dataset_id, self.table_id)
++
+ 
+ class BigqueryClient(object):
+     """"""A client for Google BigQuery.",Can you change this to use `.format()`?,Why is this necessary?
+4692,"@@ -308,13 +308,15 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+ 
+-	if dropEncap {
++	if dropEncap && r.Config.DropVXLANPacketsFromWorkloads {
+ 		rules = append(rules, Rule{
+ 			Match: Match().ProtocolNum(ProtoUDP).
+ 				DestPorts(uint16(r.Config.VXLANPort)),
+ 			Action:  DropAction{},
+ 			Comment: []string{""Drop VXLAN encapped packets originating in pods""},
+ 		})
++	}
++	if dropEncap && r.Config.DropIPIPPacketsFromWorkloads {
+ 		rules = append(rules, Rule{
+ 			Match:   Match().ProtocolNum(ProtoIPIP),
+ 			Action:  DropAction{},",Maybe the parameter should be consulted higher up the stack so that we only set dropEncap if we're rendering a workload egress chain and the flag is set?,I think this should be `if dropEncap && r.Config.VXLANPort != 0`
+4693,"@@ -47,11 +47,11 @@ type SectorBuilder interface {
+ 	// which will fit into a newly-provisioned staged sector.
+ 	GetMaxUserBytesPerStagedSector() (uint64, error)
+ 
+-	// GeneratePoST creates a proof-of-spacetime for the replicas managed by
++	// GeneratePoSt creates a proof-of-spacetime for the replicas managed by
+ 	// the SectorBuilder. Its output includes the proof-of-spacetime proof which
+ 	// is posted to the blockchain along with any faults. The proof can be
+ 	// verified by the VerifyPoSt method on the Verifier interface.
+-	GeneratePoST(GeneratePoSTRequest) (GeneratePoSTResponse, error)
++	GeneratePoSt(GeneratePoStRequest) (GeneratePoStResponse, error)
+ 
+ 	// Close signals that this SectorBuilder is no longer in use. SectorBuilder
+ 	// metadata will not be deleted when Close is called; an equivalent",new casing is less ELiTE,Why did you change this?
+4694,"@@ -179,6 +179,14 @@ bool wlr_renderer_blit_dmabuf(struct wlr_renderer *r,
+ 	return r->impl->blit_dmabuf(r, dst, src);
+ }
+ 
++GLuint wlr_renderer_renderbuffer_from_image(struct wlr_renderer *r,
++		EGLImageKHR image) {
++	if (!r->impl->renderbuffer_from_image) {
++		return false;
++	}
++	return r->impl->renderbuffer_from_image(image);
++}
++
+ bool wlr_renderer_format_supported(struct wlr_renderer *r,
+ 		enum wl_shm_format fmt) {
+ 	return r->impl->format_supported(r, fmt);",This leaks EGL/GL implementation details into the generic renderer interface.,Shouldn't this be `return r->impl->renderbuffer_from_image(image
+4695,"@@ -32,6 +32,16 @@ module Travis
+       end
+     end
+ 
++    class DeployConditionError < DeployConfigError
++      def initialize(msg = ""The \\`deploy.on\\` should be a hash (dictionary)."")
++        super
++      end
++
++      def doc_path
++        '/user/deployment#Conditional-Releases-with-on%3A'
++      end
++    end
++
+     class AptSourcesConfigError < CompilationError
+       def initialize(msg = ""\\`apt\\` should be a hash with key \\`sources\\` and an array as a value."")
+         super","Maybe add *key* i.e. `""The \\`deploy.on\\` key should be a hash (dictionary).`",Should this be `/user/deployment#Conditional-Releases`?
+4696,"@@ -75,7 +75,7 @@ class StatusGridBuilder implements GridBuilderInterface
+     {
+         $result = [];
+         foreach ($this->statusQuery->getAllStatuses($language) as $code => $status) {
+-            $result[] = new StatusOption($code, $code, new Color($status['color']), $status['name']);
++            $result[] = new StatusOption($code, $status['code'], new Color($status['color']), $status['name']);
+         }
+ 
+         return $result;","its be good also change $code na $id, actual name is misleading and that was probably actual error generator",Why did you change this?
+4697,"@@ -10,9 +10,8 @@ from listenbrainz.listenstore import ListenStore
+ 
+ class RedisListenStore(ListenStore):
+ 
+-    RECENT_LISTENS_KEY = ""lb_recent_listens""
+-    RECENT_LISTENS_MAX = 100
+-    RECENT_LISTENS_MAX_TIME_DIFFERENCE = 300
++    RECENT_LISTENS_KEY = ""lb_recent_sorted""
++    RECENT_LISTENS_MAX = 100 
+ 
+     def __init__(self, log, conf):
+         super(RedisListenStore, self).__init__(log)","I changed the name of the key, to make deployment easier.",I think this should be `
+4698,"@@ -545,6 +545,7 @@ func environmentConfig() (Config, error) {
+ 		NvidiaRuntime:                       os.Getenv(""ECS_NVIDIA_RUNTIME""),
+ 		TaskMetadataAZDisabled:              utils.ParseBool(os.Getenv(""ECS_DISABLE_TASK_METADATA_AZ""), false),
+ 		CgroupCPUPeriod:                     parseCgroupCPUPeriod(),
++		SpotInstanceDrainingEnabled:         utils.ParseBool(os.Getenv(""ECS_SPOT_INSTANCE_DRAINING_ENABLED""), false),
+ 	}, err
+ }
+ ","isn't this going to be true by default? if yes, then let's have the env var named `ECS_DISABLE_SPOT_INSTANCE_DRAINING` and have default as false.",I think this should be `
+4699,"@@ -3,6 +3,8 @@ Provides Dimension objects for tracking the properties of a value,
+ axis or map dimension. Also supplies the Dimensioned abstract
+ baseclass for classes that accept Dimension values.
+ """"""
++from __future__ import unicode_literals
++
+ import re
+ from operator import itemgetter
+ ",Do you think we might need this anywhere else in HoloViews?,Why is this needed?
+4700,"@@ -3,7 +3,9 @@ export function getDisplayPlayMethod(session) {
+         return null;
+     }
+ 
+-    if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
++    if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect && session.TranscodingInfo.IsAudioDirect) {
++        return 'Remux';
++    } else if (session.TranscodingInfo && session.TranscodingInfo.IsVideoDirect) {
+         return 'DirectStream';
+     } else if (session.PlayState.PlayMethod === 'Transcode') {
+         return 'Transcode';",@MrTimscampi don't we want to remove this term entirely? Might as well do it now if that's the case.,Shouldn't this be `session.PlayState.PlayMethod === 'Remux'`?
+4701,"@@ -36,7 +36,7 @@ module Asciidoctor
+         opts_parser = OptionParser.new do |opts|
+           opts.banner = <<-EOS
+ Usage: asciidoctor [OPTION]... [FILE]
+-Translate the AsciiDoc source FILE into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
++Translate the AsciiDoc source FILE, or multiple FILE(s) into the backend output format (e.g., HTML 5, DocBook 4.5, etc.)
+ By default, the output is written to a file with the basename of the source file and the appropriate extension.
+ Example: asciidoctor -b html5 source.asciidoc
+ ",I have followed the convention of `cp`,I don't think we need the `(s)` at the end.
+4702,"@@ -8390,11 +8390,11 @@ return [
+ 'mysql_xdevapi\tableupdate::where' => ['mysql_xdevapi\TableUpdate', 'where_expr'=>'string'],
+ 'mysqli::__construct' => ['void', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null'],
+ 'mysqli::autocommit' => ['bool', 'enable'=>'bool'],
+-'mysqli::begin_transaction' => ['bool', 'flags='=>'int', 'name='=>'string'],
++'mysqli::begin_transaction' => ['bool', 'flags='=>'int', 'name='=>'?string'],
+ 'mysqli::change_user' => ['bool', 'username'=>'string', 'password'=>'string', 'database'=>'string'],
+ 'mysqli::character_set_name' => ['string'],
+ 'mysqli::close' => ['bool'],
+-'mysqli::commit' => ['bool', 'flags='=>'int', 'name='=>'string'],
++'mysqli::commit' => ['bool', 'flags='=>'int', 'name='=>'?string'],
+ 'mysqli::connect' => ['bool', 'hostname='=>'string|null', 'username='=>'string|null', 'password='=>'string|null', 'database='=>'string|null', 'port='=>'int|null', 'socket='=>'string|null'],
+ 'mysqli::debug' => ['bool', 'options'=>'string'],
+ 'mysqli::disable_reads_from_master' => ['bool'],",The docs say it's `false|null`,Shouldn't this be `?string`?
+4703,"@@ -130,9 +130,14 @@ func (c *localCircuitBreaker) checkAndSet() {
+ 
+ // Config represents the configuration of a circuit breaker.
+ type Config struct {
++	// The threshold over sliding window that would trip the circuit breaker
+ 	Threshold float64 `json:""threshold""`
+-	Type      string  `json:""type""`
+-	TripTime  string  `json:""trip_time""`
++	// Possible values: latency, error_ratio, and status_ratio. It
++	// defaults to latency.
++	Type string `json:""type""`
++	// How long to wait after the circuit is tripped before allowing operations to resume.
++	// The default is 5s.
++	TripTime string `json:""trip_time""`
+ }
+ 
+ const (","Thinking on it more, I actually really like your idea to rename `type` to `factor`.",I think this should be `status_ratio`.
+4704,"@@ -45,7 +45,11 @@ public class MessageWebView extends WebView {
+          * will network images that are already in the WebView cache.
+          *
+          */
+-        getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
++        try {
++            getSettings().setBlockNetworkLoads(shouldBlockNetworkData);
++        } catch(SecurityException e) {
++            Timber.e(e, ""SecurityException in blockNetworkData(final boolean shouldBlockNetworkData)"");
++        }
+     }
+ 
+ ","This error message is redundant. All of this information is included in the stack trace. In general it's a good idea to avoid using method names in error messages. Chances are the method will be renamed at some point, but the string won't be updated accordingly. Then you'll end up with a very confusing error message. I suggest changing the message to: ""Failed to unblock network loads. Missing INTERNET permission?""",I think this should be `Timber.e`
+4705,"@@ -1,11 +1,9 @@
+-# -*- coding: UTF-8 -*-
+-#shlobj.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2017 NV Access Limited, Babbage B.V.
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2009-2021 NV Access Limited, Babbage B.V.
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+ 
+-""""""
++r""""""
+ This module wraps the SHGetFolderPath function in shell32.dll and defines the necessary contstants.
+ CSIDL (constant special item ID list) values provide a unique system-independent way to
+ identify special folders used frequently by applications, but which may not have the same name",Feel free to add your own name while at it.,Why did you change this?
+4706,"@@ -30,11 +30,11 @@ import (
+ )
+ 
+ var (
+-	alias    string
+ 	bytecode []byte
+ 	gasLimit uint64
+ 	gasPrice int64
+ 	nonce    uint64
++	signer   string
+ )
+ 
+ // ActionCmd represents the account command",`signer` is a global variable (from `gochecknoglobals`),`signer` -> `signerAddress`
+4707,"@@ -74,8 +74,12 @@ module Mongoid
+         # @return [ String ] The normalized key.
+         #
+         # @since 1.0.0
+-        def normalized_key(name, serializer)
+-          serializer && serializer.localized? ? ""#{name}.#{::I18n.locale}"" : name
++        def normalized_key(name, serializer, opts = {})
++          if serializer && serializer.localized? && opts[:localize] != false
++            ""#{name}.#{::I18n.locale}""
++          else
++            name
++          end
+         end
+ 
+         # Get the pair of objects needed to store the value in a hash by the",shouldn't this be `&& opts[:localize]` (i.e. both nil and false skip localization?),Why do we need to check for `seri
+4708,"@@ -17,6 +17,7 @@ from .number_types import (UOffsetTFlags, SOffsetTFlags, VOffsetTFlags)
+ 
+ from . import encode
+ from . import packer
++import pickle
+ 
+ from . import compat
+ from .compat import range_func",This can also be removed.,Why is this import needed?
+4709,"@@ -32,7 +32,8 @@ SYNOPSIS
+                           const char *key);
+ 
+  int flux_kvs_txn_symlink (flux_kvs_txn_t *txn, int flags,
+-                           const char *key, const char *target);
++                           const char *key, const char *ns,
++                           const char *target);
+ 
+  int flux_kvs_txn_put_raw (flux_kvs_txn_t *txn, int flags,
+                            const char *key, const void *data, int len);","Not critical but ""common"" is not that helpful in the commit title. Maybe go with ""libkvs/txn:"" for this one?",Why do we need the `ns` he
+4710,"@@ -277,6 +277,7 @@ class YamlConfig(QObject):
+             self._mark_changed()
+ 
+         self._migrate_bool(settings, 'tabs.favicons.show', 'always', 'never')
++        self._migrate_bool(settings, 'scrolling.bar', 'when_searching', 'never')
+         self._migrate_bool(settings, 'qt.force_software_rendering',
+                            'software-opengl', 'none')
+ ","It's been a while, but I just noticed this was wrong: It migrated `True` to `when-searching` (so people with `scrolling.bar = True` suddenly didn't have scrollbars anymore) and `False` to never. Instead, it should migrate `True` to `always` (no behavior change) and `False` to `when-searching` (so people notice the new feature). I fixed this in cc0f5fc6d400e12833ba729049e31d16cf836d53.",self._migrate_bool(setting
+4711,"@@ -27,7 +27,7 @@ class RRDReader(BaseReader):
+     def _convert_fs_path(fs_path):
+         if isinstance(fs_path, six.text_type):
+             fs_path = fs_path.encode(sys.getfilesystemencoding())
+-        return os.path.realpath(fs_path)
++        return os.path.realpath(fs_path).decode(""utf-8"")
+ 
+     def __init__(self, fs_path, datasource_name):
+         self.fs_path = RRDReader._convert_fs_path(fs_path)",.decode(sys.getfilesystemencoding()) will be better. Although I think rrdtool should accept bytes..,Why is this needed?
+4712,"@@ -0,0 +1,9 @@
++using System;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpHeadersHandler
++    {
++        void OnHeader(Span<byte> name, Span<byte> value);
++    }
++}","An interface call per header might be more expensive than we want to pay. Do we really need this to be abstracted? I think a parser abstraction makes sense, but it seems to me like a separate abstraction for handling headers (one by one) might be an overkill.",Why do we need this?
+4713,"@@ -51,15 +51,10 @@ namespace NLog
+         private const int StackTraceSkipMethods = 0;
+ 
+         [System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Naming"", ""CA2204:Literals should be spelled correctly"", Justification = ""Using 'NLog' in message."")]
+-        internal static void Write([NotNull] Type loggerType, TargetWithFilterChain targets, LogEventInfo logEvent, LogFactory factory)
++        internal static void Write([NotNull] Type loggerType, [NotNull] TargetWithFilterChain targetsForLevel, LogEventInfo logEvent, LogFactory factory)
+         {
+-            if (targets == null)
+-            {
+-                return;
+-            }
+-
+ #if !NETSTANDARD1_0 || NETSTANDARD1_5
+-            StackTraceUsage stu = targets.GetStackTraceUsage();
++            StackTraceUsage stu = targetsForLevel.GetStackTraceUsage();
+             if (stu != StackTraceUsage.None && !logEvent.HasStackTrace)
+             {
+ #if NETSTANDARD1_5","Resharper annotations, always +1",Why did you remove t
+4714,"@@ -46,6 +46,8 @@ var accountCreateAddCmd = &cobra.Command{
+ func init() {
+ 	accountCreateAddCmd.Flags().BoolVar(&CryptoSm2, ""sm2"", false,
+ 		config.TranslateInLang(flagSm2Usage, config.UILanguage))
++	accountCreateAddCmd.Flags().MarkHidden(""sm2"")
++
+ }
+ 
+ func accountCreateAdd(args []string) error {","same here, CryptoSm2 won't be changed once command is compiled",Why is this flag hid
+4715,"@@ -655,6 +655,13 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+ 		try {
+ 			certChain = KeyChain.getCertificateChain(activity, alias);
+ 			key = KeyChain.getPrivateKey(activity, alias);
++			activity.runOnUiThread(new Runnable() {
++
++                @Override
++                public void run() {
++                	loadLoginPage();
++                }
++            });
+ 		} catch (KeyChainException e) {
+ 			e.printStackTrace();
+ 		} catch (InterruptedException e) {",Loading the login page after the certificate has been loaded. Views can only be loaded from UI thread.,Why do we need this?
+4716,"@@ -52,7 +52,7 @@ func (v *ConfigValidator) Validate(config *configs.Config) error {
+ 	}
+ 	for _, c := range warns {
+ 		if err := c(config); err != nil {
+-			logrus.WithError(err).Warnf(""invalid configuration"")
++			logrus.WithError(err).Warn(""invalid configuration"")
+ 		}
+ 	}
+ 	return nil",Technically it doesn't belong here; let me remove it.,"This should be `Warnf(""invalid configuration: %v"", err)`"
+4717,"@@ -78,7 +78,7 @@ MARKER_FILE_LIGHT_VERSION = ""%s/.light-version"" % dirs.static_libs
+ IMAGE_NAME_SFN_LOCAL = ""amazon/aws-stepfunctions-local""
+ ARTIFACTS_REPO = ""https://github.com/localstack/localstack-artifacts""
+ SFN_PATCH_URL_PREFIX = (
+-    f""{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunctions-local-patch""
++    f""{ARTIFACTS_REPO}/raw/b2d48a8a8715dd31de2af75b0aa04c0c0091fa3c/stepfunctions-local-patch""
+ )
+ SFN_PATCH_CLASS1 = ""com/amazonaws/stepfunctions/local/runtime/Config.class""
+ SFN_PATCH_CLASS2 = (",remember to update the hash once the upstream PR is merged  ,Why is this change needed?
+4718,"@@ -45,10 +45,8 @@ public class SFDCFcmListenerService extends FirebaseMessagingService {
+     @Override
+     public void onMessageReceived(RemoteMessage message) {
+         if (message != null && SalesforceSDKManager.hasInstance()) {
+-            final PushNotificationInterface pnInterface = SalesforceSDKManager.getInstance().getPushNotificationReceiver();
+-            if (pnInterface != null) {
+-                pnInterface.onPushMessageReceived(message);
+-            }
++            final PushNotificationDecryptor pnDecryptor = PushNotificationDecryptor.getInstance();
++            pnDecryptor.onPushMessageReceived(message);
+         }
+     }
+ }","Sends the incoming message to the decryptor, which will then forward it to the interface once processing is complete.",Why do we need to check for null here?
+4719,"@@ -317,10 +317,15 @@ func (ctx *invocationContext) Send(toAddr address.Address, methodNum abi.MethodN
+ 		}
+ 	}()
+ 
++	// DRAGONS: remove these once specs actors project enforces Send params
+ 	// replace nil params with empty value
+ 	if params == nil {
+ 		params = &adt_spec.EmptyValue{}
+ 	}
++	// replace non pointer with pointer
++	if _, ok := params.(adt_spec.EmptyValue); ok {
++		params = &adt_spec.EmptyValue{}
++	}
+ 
+ 	// check if side-effects are allowed
+ 	if !ctx.allowSideEffects {","FYI This will go the other way, with nil being the correct value for ""no params""",Why do we need this?
+4720,"@@ -162,8 +162,10 @@ namespace pwiz.Skyline.Model.Lib
+                 var thatPeptideKey = thatItem.LibraryKey as PeptideLibraryKey;
+                 if (thatPeptideKey == null)
+                 {
+-                    result.Add(thatItem.LibraryKey);
+-                    nonPeptideKeySet.Add(thatItem.LibraryKey);
++                    if (nonPeptideKeySet.Add(thatItem.LibraryKey))
++                    {
++                        result.Add(thatItem.LibraryKey); // First time we've seen it, add to list
++                    }
+                     continue;
+                 }
+                 PeptideLibraryKey[] thisKeysWithUnmodSeq;",Is this necessary? Are there duplicates in your LibKeyIndex?,why do we need this?
+4721,"@@ -35,6 +35,7 @@ func (m *MockActionIterator) EXPECT() *MockActionIteratorMockRecorder {
+ 
+ // Next mocks base method
+ func (m *MockActionIterator) Next() (action.SealedEnvelope, bool) {
++	m.ctrl.T.Helper()
+ 	ret := m.ctrl.Call(m, ""Next"")
+ 	ret0, _ := ret[0].(action.SealedEnvelope)
+ 	ret1, _ := ret[1].(bool)",Why will the gomock files be regenerated? It seems to be irrelevant,Why is this needed?
+4722,"@@ -97,6 +97,7 @@ func newPlanner(
+ 		pipedConfig:              pipedConfig,
+ 		plannerRegistry:          registry.DefaultRegistry(),
+ 		appManifestsCache:        appManifestsCache,
++		cancelledCh:              make(chan *model.ReportableCommand, 1),
+ 		nowFunc:                  time.Now,
+ 		logger:                   logger,
+ 	}",I'm very curious about why using buffered-channel. Is there something wrong to use an unbuffered channel with zero capacity?,Why do we need this 
+4723,"@@ -14,7 +14,7 @@
+ # See the License for the specific language governing permissions and
+ # limitations under the License.
+ #
+-from helpers import LuigiTestCase
++from helpers import LuigiTestCase, RunOnceTask
+ 
+ import luigi
+ import luigi.task",It seems like you accidentally pulled some unrelated changes to util_test into this.,Why is this import n
+4724,"@@ -15,6 +15,7 @@
+ //  along with the Nethermind. If not, see <http://www.gnu.org/licenses/>.
+ 
+ using Nethermind.Blockchain;
++using Nethermind.Blockchain.Bloom;
+ using Nethermind.Blockchain.Filters;
+ using Nethermind.Blockchain.Receipts;
+ using Nethermind.Blockchain.TxPools;",do not toucm NDM please - there will be lots of conflicts,Why is this needed?
+4725,"@@ -357,7 +357,7 @@ class XLSXWriter extends TextResponseWriter {
+       if (v instanceof IndexableField) {
+         IndexableField f = (IndexableField)v;
+         if (v instanceof Date) {
+-          output.append(((Date) val).toInstant().toString() + ""; "");
++          output.append(((Date) v).toInstant().toString() + ""; "");
+         } else {
+           output.append(f.stringValue() + ""; "");
+         }",This looks legitimate - Would cause a classCastException. But have we ever seen it in the wild?,Why is this change 
+4726,"@@ -48,6 +48,8 @@ class Testinfra(base.Base):
+           name: testinfra
+           options:
+             n: 1
++            v: True
++            setup-show: True
+ 
+     The testing can be disabled by setting `enabled` to False.
+ ",This looks out of scope for this particular PR.,This should be `set
+4727,"@@ -39,6 +39,14 @@ import (
+ // Warning when user configures leafnode TLS insecure
+ const leafnodeTLSInsecureWarning = ""TLS certificate chain and hostname of solicited leafnodes will not be verified. DO NOT USE IN PRODUCTION!""
+ 
++const (
++	leafDefaultFirstPingInterval = int64(time.Second)
++)
++
++var (
++	leafFirstPingInterval = leafDefaultFirstPingInterval
++)
++
+ type leaf struct {
+ 	// Used to suppress sub and unsub interest. Same as routes but our audience
+ 	// here is tied to this leaf node. This will hold all subscriptions except this",Don't need () if only one.,I think this should
+4728,"@@ -26,6 +26,7 @@ public class AbstractMailer {
+   private boolean usesAuth;
+ 
+   private String mailHost;
++  private String mailPort;
+   private String mailUser;
+   private String mailPassword;
+   private String mailSender;",Why not have mailPort as int since your are already parsing while calling t.connect ?,private String mailPort;
+4729,"@@ -38,7 +38,7 @@ with open('README.rst') as fobj:
+ 
+ install_requires = [
+     'tornado>=4.0,<5',
+-    'python-daemon<3.0',
++    'python-daemon<3.0'
+ ]
+ 
+ if os.environ.get('READTHEDOCS', None) == 'True':","In the future, do not remove these trailing commas as they have the purpose of making append-diffs easier to read. :)",Why did you remove the c
+4730,"@@ -739,6 +739,11 @@ class SolrDefault extends AbstractBase
+         // Get LCCN from Index
+         $raw = isset($this->fields['lccn']) ? $this->fields['lccn'] : '';
+ 
++        // First call number only.
++        if (is_array($raw)) {
++            $raw = reset($raw);
++        }
++
+         // Remove all blanks.
+         $raw = preg_replace('{[ \t]+}', '', $raw);
+ ","Was this added by accident? It doesn't seem related to Syndetics, and I don't think it should be necessary in core VuFind (but maybe it's related to one of your local customizations).",`$raw = (array) $raw;`
+4731,"@@ -44,6 +44,8 @@ type Config struct {
+ 	Manager                       Manager
+ 	Attestor                      Attestor
+ 	AllowUnauthenticatedVerifiers bool
++	AllowedForeignJWTClaims       map[string]bool
++	TrustDomain                   spiffeid.TrustDomain
+ }
+ 
+ type Handler struct {","i know the ergonomics are a little nicer with map[string]bool, but I prefer map[string]struct{} for sets for a few reasons: 1 - optimized storage (not very relevant here) 2 - don't have to think about the conditions where the key exists in the map or if the value could somehow be false",Why is this a map?
+4732,"@@ -69,6 +69,7 @@ const (
+ 	History
+ 	Matching
+ 	Worker
++	Server
+ 	NumServices
+ )
+ ","This is very unclear what Server means. We need a better name, maybe ServerExtension?",nit: remove empty line
+4733,"@@ -37,7 +37,6 @@ func TestDevLogs(t *testing.T) {
+ 		out, err := system.RunCommand(DdevBin, args)
+ 		assert.NoError(err)
+ 		assert.Contains(string(out), ""Server started"")
+-		assert.Contains(string(out), ""GET"")
+ 
+ 		cleanup()
+ 	}",I wonder if we should trigger a PHP error and ensure it ends up in the log?,Why was this removed?
+4734,"@@ -232,7 +232,9 @@
+         * @returns {string} decoded string
+         */
+         countlyCommon.decodeHtml = function(html) {
+-            return (html + """").replace(/&amp;/g, '&');
++            var textArea = document.createElement('textarea');
++            textArea.innerHTML = html;
++            return textArea.value;
+         };
+ 
+ ",Hmmm not sure about this. Is it fine @ar2rsawseen?,Why do we need this?
+4735,"@@ -7,5 +7,5 @@ public interface Installer {
+     /**
+      * runs the installer
+      */
+-    void run();
++    void go();
+ }",Why do you prefer `go` over `run`?,Why did you change thi
+4736,"@@ -822,7 +822,7 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+                                           TestRunCompleteArgs = dummyCompleteArgs
+                                       };
+             var runComplete = CreateMessage(MessageType.ExecutionComplete, completepayload);
+-
++            
+             this.mockCommunicationManager.Setup(cm => cm.ReceiveMessageAsync(It.IsAny<CancellationToken>())).Returns(Task.FromResult(message1));
+             mockLauncher.Setup(ml => ml.LaunchTestHost(It.IsAny<TestProcessStartInfo>()))
+                 .Callback<TestProcessStartInfo>((startInfo) =>","Unintentional, please remove",Why this change?
+4737,"@@ -18,6 +18,10 @@ class Subscription < ActiveRecord::Base
+   after_create :add_user_to_mailing_list
+   after_create :add_user_to_github_team
+ 
++  def self.active
++    where(deactivated_on: nil)
++  end
++
+   def self.deliver_welcome_emails
+     recent.each do |subscription|
+       subscription.deliver_welcome_email",What was the reason behind moving this?,I don't think th
+4738,"@@ -1,12 +1,8 @@
+-<%= t ""user_mailer.gpx_notification.your_gpx_file"" %>
+-<strong><%= @trace_name %></strong>
+-<%= t ""user_mailer.gpx_notification.with_description"" %>
+-<em><%= @trace_description %></em>
+-<% if @trace_tags.length>0 %>
+-  <%= t ""user_mailer.gpx_notification.and_the_tags"" %>
+-  <em><% @trace_tags.each do |tag| %>
+-    <%= tag.tag.rstrip %>
+-  <% end %></em>
++<% trace_name = tag.strong(@trace_name) %>
++<% trace_description = tag.em(@trace_description) %>
++<% if @trace_tags.length > 0 %>
++  <% tags = @trace_tags.map { tag.tag.rstrip.join("" "") } %>
++  <%= t "".description_with_tags_html"", :trace_name => trace_name, :trace_description => trace_description, :tags => tags %>
+ <% else %>
+-  <%= t ""user_mailer.gpx_notification.and_no_tags"" %>
++  <%= t "".description_with_no_tags_html"", :trace_name => trace_name, :trace_description => trace_description %>
+ <% end %>",Did you mean to put that `join` after the `map` rather than inside it? Also should it be `safe_join` or is interpolating it into an `_html` resource going to have much the same effect>,I think you can 
+4739,"@@ -72,6 +72,14 @@ class Realm {
+      */
+     get isInTransaction() {}
+ 
++    /**
++     * Indicated is this Realm is closed.
++     * @type {boolean}
++     * @readonly
++     * @since 2.1.0
++     */
++     get isClosed() {}
++
+     /**
+      * Gets the sync session if this is a synced Realm
+      * @type {Session}",`Indicates if this Realm has been closed.`?,This should be `
+4740,"@@ -55,7 +55,6 @@ class _MissingPandasLikeSeries(object):
+     compress = unsupported_function('compress')
+     convert_objects = unsupported_function('convert_objects')
+     copy = unsupported_function('copy')
+-    corr = unsupported_function('corr')
+     cov = unsupported_function('cov')
+     cummax = unsupported_function('cummax')
+     cummin = unsupported_function('cummin')",how is this change adding corr to Series? Do all the methods that are added to Frame automatically get added to Series?,Why did you remove these?
+4741,"@@ -168,11 +168,11 @@ func (syncer *DefaultSyncer) tipSetState(ctx context.Context, tsKey types.Sorted
+ 	if !syncer.chainStore.HasTipSetAndState(ctx, tsKey.String()) {
+ 		return nil, errors.Wrap(ErrUnexpectedStoreState, ""parent tipset must be in the store"")
+ 	}
+-	tsas, err := syncer.chainStore.GetTipSetAndState(tsKey)
++	tssr, err := syncer.chainStore.GetTipSetStateRoot(tsKey)
+ 	if err != nil {
+ 		return nil, err
+ 	}
+-	st, err := state.LoadStateTree(ctx, syncer.stateStore, tsas.TipSetStateRoot, builtin.Actors)
++	st, err := state.LoadStateTree(ctx, syncer.stateStore, tssr, builtin.Actors)
+ 	if err != nil {
+ 		return nil, err
+ 	}","Just a heads up for anyone else reviewing this, this logic and all the repetitions of it should be greatly simplified by subsequent work relating to issue #2552.",Why is this change needed
+4742,"@@ -11,11 +11,15 @@ using MicroBenchmarks;
+ namespace System.Collections
+ {
+     [BenchmarkCategory(Categories.CoreCLR, Categories.Collections, Categories.GenericCollections)]
+-    [GenericTypeArguments(typeof(int))] // value type
+-    [GenericTypeArguments(typeof(string))] // reference type
++    [GenericTypeArguments(typeof(int))] // value type, Array sort in native code
++    [GenericTypeArguments(typeof(IntStruct))] // custom value type, sort in managed code
++    [GenericTypeArguments(typeof(IntClass))] // custom reference type, sort in managed code, compare fast
++    [GenericTypeArguments(typeof(BigStruct))] // custom value type, sort in managed code
++    [GenericTypeArguments(typeof(string))] // reference type, compare slow
+     [InvocationCount(InvocationsPerIteration)]
+-    public class Sort<T>
++    public class Sort<T> where T : IComparable<T>
+     {
++        static readonly ComparableComparerClass _comparableComparerClass = new ComparableComparerClass();
+         private const int InvocationsPerIteration = 1000;
+ 
+         [Params(Utils.DefaultCollectionSize)]","@billwert I have kept the `1000` InvocationsPerIteration, but do note this is very small for the small types.",Why do we need this?
+4743,"@@ -31,7 +31,6 @@ from qutebrowser.config import config
+ 
+ 
+ class Command(misc.MinimalLineEditMixin, misc.CommandLineEdit):
+-
+     """"""The commandline part of the statusbar.
+ 
+     Attributes:",Unrelated whitespace change.,Why was this removed?
+4744,"@@ -133,8 +133,18 @@ bool rai::wallet_store::valid_password (MDB_txn * transaction_a)
+ 	return ok;
+ }
+ 
+-bool rai::wallet_store::attempt_password (MDB_txn * transaction_a, std::string const & password_a)
++bool rai::wallet_store::attempt_password (rai::transaction * transaction_p, std::string const & password_a)
+ {
++	std::unique_ptr<rai::transaction> writeTransaction;
++
++	if (!transaction_p->open_for_write)
++	{
++		writeTransaction = std::make_unique<rai::transaction> (environment, nullptr, true);
++		transaction_p = writeTransaction.get ();
++	}
++
++	MDB_txn *transaction_a = *transaction_p;
++
+ 	bool result = false;
+ 	{
+ 		std::lock_guard<std::recursive_mutex> lock (mutex);",Slight formatting issue here. There should be a space after the asterisk.,"`std::unique_ptr<rai::transaction> writeTransaction(environment, nullptr, true);`"
+4745,"@@ -8,7 +8,8 @@
+  */
+ axe.utils.isHidden = function isHidden(el, recursed) {
+ 	'use strict';
+-	var parent;
++	const node = axe.utils.getNodeFromTree(el);
++	let parent, isHidden;
+ 
+ 	// 9 === Node.DOCUMENT
+ 	if (el.nodeType === 9) {",Slight preference for declaring variables inline rather than at the top of the function. That way you can use const for both of these.,I don't think we need this variable.
+4746,"@@ -32,9 +32,9 @@ import org.slf4j.LoggerFactory;
+  * @since  [产品/模块版本]
+  */
+ public class TestMgr {
+-    private static Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
++    private static final Logger LOGGER = LoggerFactory.getLogger(TestMgr.class);
+ 
+-    private static List<Throwable> errorList = new ArrayList<>();
++    private static final List<Throwable> errorList = new ArrayList<>();
+ 
+     private static String msg = """";
+ ",this is a duplicate file of the one in demo-schema. please remove this file.,Why change this?
+4747,"@@ -153,6 +153,7 @@ var (
+ 		utils.Eth1SyncServiceEnable,
+ 		utils.Eth1CanonicalTransactionChainDeployHeightFlag,
+ 		utils.Eth1L1CrossDomainMessengerAddressFlag,
++		utils.Eth1L1FeeWalletAddressFlag,
+ 		utils.Eth1ETHGatewayAddressFlag,
+ 		utils.Eth1ChainIdFlag,
+ 		utils.RollupClientHttpFlag,",Nit: unified names between geth and contracts,Why is this flag added?
+4748,"@@ -42,7 +42,9 @@ func TestClientToServerCommunication(t *testing.T) {
+ 	// Note that the ordering of things here is pretty important; we need to get the
+ 	// client connected & ready to receive events before we push them all into the
+ 	// server and shut it down again.
+-	serverState := core.NewBuildState(5, nil, 4, core.DefaultConfiguration())
++	config := core.DefaultConfiguration()
++	config.Please.NumThreads = 5
++	serverState := core.NewBuildState(config)
+ 	addr, shutdown := initialiseServer(serverState, 0)
+ 
+ 	// This is a bit awkward. We want to assert that we receive a matching set of",Necessary? Could you just use DefaultBuildState here?,Why is this necessary?
+4749,"@@ -22,7 +22,7 @@ import java.util.ArrayList;
+ import java.util.Arrays;
+ import java.util.Collections;
+ import java.util.Date;
+-import java.util.HashMap;
++import java.util.LinkedHashMap;
+ import java.util.HashSet;
+ import java.util.List;
+ import java.util.Map;",linked hashmap retains order,Why is this change nee
+4750,"@@ -20,12 +20,12 @@
+ #include <wlr/render/matrix.h>
+ #include <wlr/render/gles2.h>
+ #include <wlr/render.h>
+-#include ""backend/drm.h""
+-#include ""backend/drm-util.h""
++#include ""backend/drm/drm.h""
++#include ""backend/drm/util.h""
+ 
+ bool wlr_drm_check_features(struct wlr_drm_backend *backend) {
+-	extern const struct wlr_drm_interface legacy_iface;
+-	extern const struct wlr_drm_interface atomic_iface;
++	extern const struct wlr_drm_interface iface_legacy;
++	extern const struct wlr_drm_interface iface_atomic;
+ 
+ 	if (drmSetClientCap(backend->fd, DRM_CLIENT_CAP_UNIVERSAL_PLANES, 1)) {
+ 		wlr_log(L_ERROR, ""DRM universal planes unsupported"");",And the old names for these variables made more sense imo.,Why is this change nee
+4751,"@@ -473,7 +473,7 @@ func GetAdditionalGroups(additionalGroups []string, group io.Reader) ([]int, err
+ 				return nil, fmt.Errorf(""Unable to find group %s"", ag)
+ 			}
+ 			// Ensure gid is inside gid range.
+-			if gid < minId || gid > maxId {
++			if gid < minId || gid >= maxId {
+ 				return nil, ErrRange
+ 			}
+ 			gidMap[gid] = struct{}{}",Are you sure this change is correct?,I think this should be
+4752,"@@ -9,8 +9,7 @@ def test_view_image():
+         ""mitmproxy/data/image.png"",
+         ""mitmproxy/data/image.gif"",
+         ""mitmproxy/data/all.jpeg"",
+-        # https://bugs.python.org/issue21574
+-        # ""mitmproxy/data/image.ico"",
++        ""mitmproxy/data/image.ico"",
+     ]:
+         with open(tutils.test_data.path(img), ""rb"") as f:
+             viewname, lines = v(f.read())","The previously linked bug does not apply anymore? If so, this is LGTM!",Why did you remove this?
+4753,"@@ -84,7 +84,7 @@ func assertNotEqual(t *testing.T, a interface{}, b interface{}) {
+ 	}
+ }
+ 
+-func TestFailOver(t *testing.T) {
++func Test_FailOver(t *testing.T) {
+ 	tmpDir, err := ioutil.TempDir("""", ""lb-test"")
+ 	if err != nil {
+ 		assertEqual(t, err, nil)",Why are we renaming all of the tests?,Why this change?
+4754,"@@ -24,8 +24,9 @@ import (
+ 
+ var defaultRFC2136Port = ""53""
+ 
+-// This function make a valid nameserver as per RFC2136
++// This function returns a valid nameserver (in the form <host>:<port>) for the RFC2136 provider
+ func ValidNameserver(nameserver string) (string, error) {
++	nameserver = strings.TrimSpace(nameserver)
+ 
+ 	if nameserver == """" {
+ 		return """", fmt.Errorf(""RFC2136 nameserver missing"")","Instead of having this logic, would it make sense to require *users* to encompass the specified IPv6 address within `[` and `]`? Why the magic handling here?",Why do we need to trim s
+4755,"@@ -142,9 +142,15 @@ PyObject *GetMolConformers(ROMol &mol) {
+ template <class T>
+ T MolGetProp(const ROMol &mol, const char *key) {
+   T res;
+-  if (!mol.getPropIfPresent(key, res)) {
+-    PyErr_SetString(PyExc_KeyError, key);
+-    throw python::error_already_set();
++  try {
++    if (!mol.getPropIfPresent(key, res)) {
++      PyErr_SetString(PyExc_KeyError, key);
++      throw python::error_already_set();
++    }
++    return res;
++  } catch ( const boost::bad_any_cast &e ) {
++    throw ValueErrorException(std::string(""key `"") + key + ""` exists but does not result in a "" +
++                              GetTypeName<T>());
+   }
+   return res;
+ }","Why not also replace this one with calls to `GetProp<ROMol,T>`?",Shouldn't this be `PyExc
+4756,"@@ -259,6 +259,7 @@ class KNNClassifier(object):
+     if doWinners:
+       if (self.numWinners>0) and (self.numWinners < (inputPattern > 0).sum()):
+         sparseInput = numpy.zeros(inputPattern.shape)
++        
+         # Don't consider strongly negative numbers as winners.
+         sorted = inputPattern.argsort()[0:self.numWinners]
+         sparseInput[sorted] += inputPattern[sorted]",Still need to remove trailing spaces on this line,Why this change?
+4757,"@@ -0,0 +1,19 @@
++/*
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.apex.ast;
++
++import apex.jorje.semantic.ast.AstNode;
++
++/**
++ * Interface for nodes that can contain comments. Because comments are for the most part lost, the tree builder only
++ * captures whether the node did contain comments of any sort in the source code and not the actual contents of those
++ * comments. This is useful for rules which need to know whether a node did contain comments.
++ */
++public interface ASTCommentContainer<T extends AstNode> extends ApexNode<T> {
++
++    void setContainsComment(boolean containsComment);
++
++    boolean getContainsComment();
++}",Please use the `@Experimental` annotation on this,Why do we need t
+4758,"@@ -77,7 +77,7 @@ func (s *LimitedReaderSlurper) Read(reader io.Reader) error {
+ 					// if we received err == nil and n == 0, we should retry calling the Read function.
+ 					continue
+ 				default:
+-					// if we recieved a non-io.EOF error, return it.
++					// if we received a non-io.EOF error, return it.
+ 					return err
+ 				}
+ 			}",I found ~10 more instances of this typo. we can fix those in subsequent PRs.,I think this is 
+4759,"@@ -49,7 +49,7 @@ type InitRes struct {
+ // it returns a result object that contains useful artifacts for later use.
+ // Unlike sharedmain.Main, Init is meant to be run as a helper function in any main
+ // functions, while sharedmain.Main runs controllers with predefined method signatures.
+-func Init(component string, opts ...InitOption) (context.Context, *InitRes) {
++func Init(component string, metricNamespace string, opts ...InitOption) (context.Context, *InitRes) {
+ 	args := newInitArgs(component, opts...)
+ 	ctx := args.ctx
+ 	ProcessEnvConfigOrDie(args.env)","How about making metricNamespace an option, and by default it's the same as `component`? e.g.m Init(component, WithMetricNamespace(""trigger""))",Why do we need t
+4760,"@@ -163,6 +163,8 @@ public class NodeJSSampleMethodToViewTransformer implements SampleMethodToViewTr
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(""handlePage""))));
+     builder.pageVarName(
+         symbolTable.getNewSymbol(namer.localVarName(Name.lowerCamel(fieldInfo.name(), ""page""))));
++    builder.pageTokenName(methodInfo.requestPageTokenName());
++    builder.nextPageTokenName(methodInfo.responsePageTokenName());
+     return builder.build();
+   }
+ }",Just checking: no need for case manipulation?,Why do we need this?
+4761,"@@ -94,7 +94,7 @@ public class GrpcMetadataGeneratorTool {
+ 
+   private static void generate(
+       String descriptorSet,
+-      String[] apiConfigs,
++      String[] configs,
+       String inputDir,
+       String outputDir,
+       String languageString,","Same as above, not that descriptive",`configs` -> `config
+4762,"@@ -5494,10 +5494,12 @@ emit_special_ibl_xfer(dcontext_t *dcontext, byte *pc, generated_code_t *code, ui
+     reg_id_t stub_reg = IF_AARCH64_ELSE(SCRATCH_REG0, SCRATCH_REG1);
+     ushort stub_slot = IF_AARCH64_ELSE(TLS_REG0_SLOT, TLS_REG1_SLOT);
+     IF_X86(size_t len;)
+-    byte *ibl_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_LINKED, ibl_type);
++    byte *ibl_linked_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_LINKED, ibl_type);
++    byte *ibl_unlinked_tgt = special_ibl_xfer_tgt(dcontext, code, IBL_UNLINKED, ibl_type);
+     bool absolute = !code->thread_shared;
+ 
+-    ASSERT(ibl_tgt != NULL);
++    ASSERT(ibl_linked_tgt != NULL);
++    ASSERT(ibl_unlinked_tgt != NULL);
+     instrlist_init(&ilist);
+     init_patch_list(&patch, absolute ? PATCH_TYPE_ABSOLUTE : PATCH_TYPE_INDIRECT_FS);
+ ",> i#4670 signl-interrupted special ibl xfer frag: Unlink if signal pending nit: This looks like one of many commits with the text before the colon. nit: On the long side: 56 or 60 chars is what some views show Spelling error.,`ibl_unlinked_tgt` -
+4763,"@@ -668,6 +668,8 @@ int flb_start(flb_ctx_t *ctx)
+         fd = event->fd;
+         bytes = flb_pipe_r(fd, &val, sizeof(uint64_t));
+         if (bytes <= 0) {
++            pthread_cancel(tid);
++            pthread_join(tid, NULL);
+             ctx->status = FLB_LIB_ERROR;
+             return -1;
+         }",Should we need to invoke pthread_cancel ?,Why is this necessar
+4764,"@@ -122,7 +122,8 @@ public class ZMSResources {
+     public Domain postUserDomain(@PathParam(""name"") String name, @HeaderParam(""Y-Audit-Ref"") String auditRef, UserDomain detail) {
+         try {
+             ResourceContext context = this.delegate.newResourceContext(this.request, this.response);
+-            context.authorize(""create"", ""user."" + name + "":domain"", null);
++            String userDomainPrefix = System.getProperty(ZMSConsts.ZMS_PROP_USER_DOMAIN, ZMSConsts.USER_DOMAIN) + ""."";
++            context.authorize(""create"", userDomainPrefix + name + "":domain"", null);
+             Domain e = this.delegate.postUserDomain(context, name, auditRef, detail);
+             return e;
+         } catch (ResourceException e) {",this is auto generated file so no changes are allowed here,Why do we need this change?
+4765,"@@ -0,0 +1,13 @@
++if (
++	node.querySelector(
++		'input[type=""submit""]:not([disabled]), img[type=""submit""]:not([disabled]), button[type=""submit""]:not([disabled])'
++	)
++) {
++	return true;
++}
++
++if (!node.querySelectorAll(':not(textarea)').length) {
++	return false;
++}
++
++return undefined;","All buttons are submit buttons, except if they are `type=reset` or `type=button`. I suggest you do an exclude of those, rather than only include `button[type=submit]`.",Why is this necessary?
+4766,"@@ -38,7 +38,7 @@ module Travis
+ 
+         def perl_version
+           # this check is needed because safe_yaml parses the string 5.10 to 5.1
+-          config[:perl] == 5.1 ? ""5.10"" : config[:perl]
++          config[:perl] == 5.1 ? ""5.10"" : config[:perl] == 5.2 ? ""5.20"" : config[:perl]
+         end
+       end
+     end","can you please make this multi line, this version is hard to read.","I think this should be 5.2,"
+4767,"@@ -128,7 +128,7 @@ Blockly.HorizontalFlyout.prototype.setMetrics_ = function(xyRatio) {
+     return;
+   }
+ 
+-  if (goog.isNumber(xyRatio.x)) {
++  if (typeof xyRatio.x === 'number') {
+     this.workspace_.scrollX = -metrics.contentWidth * xyRatio.x;
+   }
+ ","For consistency, it's best to either always use strict equality (`===`) or loose equality (`==`) in `typeof` checks, and to not mix them.",I think this should be `typ
+4768,"@@ -11,6 +11,10 @@ FactoryGirl.define do
+     project_title ""NCR Name""
+     association :proposal, flow: 'linear'
+ 
++    trait :with_approver do
++      association :proposal, :with_approver, flow: 'linear'
++    end
++
+     trait :with_approvers do
+       association :proposal, :with_approvers, flow: 'linear'
+     end","Work Orders would never have only one approver, right?",Extra empty line detected at block body beginning.
+4769,"@@ -0,0 +1,17 @@
++package com.codahale.metrics.collectd;
++
++enum DataType {
++
++    COUNTER(0), GAUGE(1);
++
++    private final int code;
++
++    private DataType(int code) {
++        this.code = code;
++    }
++
++    public int getCode() {
++        return code;
++    }
++
++}","`code` is written to the message as a `byte`, so I think it's better to declare it in the enum as `byte` as well to avoid a narrowing primitive conversion from `int` to `byte` in runtime.",Why do we need this?
+4770,"@@ -163,9 +163,11 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
+ 		{
+ 			title: __( 'Earnings', 'google-site-kit' ),
+ 			tooltip: __( 'Earnings', 'google-site-kit' ),
+-			Component: ( { row } ) => numFmt(
+-				row.metrics[ 0 ].values[ 0 ],
+-				currencyFormat,
++			field: 'metrics.0.values.0',
++			Component: ( { fieldValue } ) => (
++				<span>
++					{ numFmt( fieldValue, currencyFormat ) }
++				</span>
+ 			),
+ 		},
+ 	];","This is the only ""extra"" change here.",I think this should be `metrics.0.values.1`
+4771,"@@ -36,14 +36,15 @@ type SignedMessageValidator interface {
+ }
+ 
+ type defaultMessageValidator struct {
+-	allowHighNonce bool
++	allowHighNonce          bool
++	bypassBLSSignatureCheck bool
+ }
+ 
+ // NewDefaultMessageValidator creates a new default validator.
+ // A default validator checks for both permanent semantic problems (e.g. invalid signature)
+ // as well as temporary conditions which may change (e.g. actor can't cover gas limit).
+ func NewDefaultMessageValidator() SignedMessageValidator {
+-	return &defaultMessageValidator{}
++	return &defaultMessageValidator{bypassBLSSignatureCheck: true}
+ }
+ 
+ // NewOutboundMessageValidator creates a new default validator for outbound messages. This",Please TODO and link to an issue for changing this.,Why do we need this?
+4772,"@@ -1,9 +1,10 @@
++/* eslint-disable comma-dangle */
+ const en_US = {}
+ 
+ en_US.strings = {
+   addBulkFilesFailed: {
+     '0': 'Failed to add %{smart_count} file due to an internal error',
+-    '1': 'Failed to add %{smart_count} files due to internal errors',
++    '1': 'Failed to add %{smart_count} files due to internal errors'
+   },
+   addingMoreFiles: 'Adding more files',
+   addMore: 'Add more',",Can we make the script output trailing commas?,Why is this disabled?
+4773,"@@ -0,0 +1,10 @@
++exports.featureFlags = {
++	widgets: {
++		dashboard: {
++			enabled: 'development',
++		},
++		pageDashboard: {
++			enabled: 'development',
++		},
++	},
++};",This file should get a file header  ,I think this should b
+4774,"@@ -7,7 +7,6 @@
+ #include ""base/Base.h""
+ #include ""kvstore/wal/FileBasedWal.h""
+ #include ""kvstore/wal/FileBasedWalIterator.h""
+-#include ""kvstore/wal/BufferFlusher.h""
+ #include ""fs/FileUtils.h""
+ #include ""time/WallClock.h""
+ ","maybe we need process the os error more safely and friendly when open file failed, because this error is very common when cpu has a high pressure, crash directly is danger.",Why did you remove th
+4775,"@@ -135,6 +135,9 @@ func registerWriteCommand(cmd *cobra.Command) {
+ 
+ // gasPriceInRau returns the suggest gas price
+ func gasPriceInRau() (*big.Int, error) {
++	if account.CryptoSm2 {
++		return big.NewInt(0), nil
++	}
+ 	gasPrice := gasPriceFlag.Value().(string)
+ 	if len(gasPrice) != 0 {
+ 		return util.StringToRau(gasPrice, util.GasPriceDecimalNum)",we need to pay attention not to use this flag everywhere.,Why do we need this?
+4776,"@@ -22,7 +22,6 @@ import (
+ )
+ 
+ type Protocol string
+-type TableIDType uint8
+ type GroupIDType uint32
+ type MeterIDType uint32
+ ","curious about this change, since it is not mentioned in the commit message and now we have `uint8` all over the place",Why is this removed?
+4777,"@@ -74,7 +74,7 @@ func (db *DB) SubscribePush(ctx context.Context) (c <-chan swarm.Chunk, stop fun
+ 					}
+ 
+ 					select {
+-					case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag).WithStamp(dataItem.Stamp):
++					case chunks <- swarm.NewChunk(swarm.NewAddress(dataItem.Address), dataItem.Data).WithTagID(item.Tag):
+ 						count++
+ 						// set next iteration start item
+ 						// when its chunk is successfully sent to channel","wait, are we not mising `WithStamp` here?",// when its chunk is
+4778,"@@ -66,7 +66,7 @@ func (api *APIImpl) Syncing(ctx context.Context) (interface{}, error) {
+ 		return false, err
+ 	}
+ 
+-	currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.TxPool)
++	currentBlock, _, err := stages.GetStageProgress(api.dbReader, stages.Finish)
+ 	if err != nil {
+ 		return false, err
+ 	}",oh. didn't know we store this stage progress.,I think this should 
+4779,"@@ -91,6 +91,7 @@ function getUnicodeNonBmpRegExp() {
+ 		'\u25A0-\u25FF' + // Geometric Shapes
+ 		'\u2600-\u26FF' + // Misc Symbols
+ 		'\u2700-\u27BF' + // Dingbats
++		'\uE000-\uF8FF' + // Private Use
+ 			']'
+ 	);
+ }","Going with definition from here: > Does Unicode have private-use characters? > A: Yes. There are three ranges of private-use characters in the standard. The main range in the BMP is U+E000..U+F8FF, containing 6,400 private-use characters. That range is often referred to as the Private Use Area (PUA). But there are also two large ranges of supplementary private-use characters, consisting of most of the code points on Planes 15 and 16: U+F0000..U+FFFFD and U+100000..U+10FFFD. Together those ranges allocate another 131,068 private-use characters. Altogether, then, there are 137,468 private-use characters in Unicode. It looks like we are only ignoring ones in BMP and not the supplementary private-use characters. Shouldn't we consider the supplementary ones too?",I think this should 
+4780,"@@ -300,7 +300,7 @@ class FunctionCallReturnTypeFetcher
+                                     return new Type\Union([
+                                         $atomic_types['array']->count !== null
+                                             ? new Type\Atomic\TLiteralInt($atomic_types['array']->count)
+-                                            : new Type\Atomic\TInt
++                                            : new Type\Atomic\TPositiveInt
+                                     ]);
+                                 }
+ ",This change is un-tested and requires testing,Why did you change this?
+4781,"@@ -83,6 +83,11 @@ class notebook_extension(extension):
+ 
+     logo = param.Boolean(default=True, doc=""Toggles display of HoloViews logo"")
+ 
++    comms = param.ObjectSelector(
++        default='default', objects=['default', 'ipywidgets', 'vscode'], doc=""""""
++        Whether to render output in Jupyter with the default Jupyter
++        extension or use the jupyter_bokeh ipywidget model."""""")
++
+     inline = param.Boolean(default=True, doc=""""""
+         Whether to inline JS and CSS resources. 
+         If disabled, resources are loaded from CDN if one is available."""""")",Should the docstring mention the vscode option?,I don't think you need t
+4782,"@@ -83,6 +83,8 @@ public class PackageMetadataTransformer {
+         .packageVersionBound(packageConfig.generatedPackageVersionBound(language))
+         .protoPath(packageConfig.protoPath())
+         .shortName(packageConfig.shortName())
++        .gapicConfigName(packageConfig.shortName() + ""_gapic.yaml"")
++        .packageType(packageConfig.packageType())
+         .gaxVersionBound(packageConfig.gaxVersionBound(language))
+         .grpcVersionBound(packageConfig.grpcVersionBound(language))
+         .protoVersionBound(packageConfig.protoVersionBound(language))","ISTM that since `artman` know the ""real"" value of the GAPIC config name, it should pass that value to toolkit, rather than toolkit guessing the name based on a heuristic. Then again, I don't know what this value actually does for Java codegen...",Why do we need this?
+4783,"@@ -17,7 +17,7 @@ package main
+ import (
+ 	""time""
+ 
+-	""github.com/docopt/docopt-go""
++	docopt ""github.com/docopt/docopt-go""
+ 	log ""github.com/sirupsen/logrus""
+ 
+ 	""github.com/projectcalico/felix/iptables""",Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated,Why did you change this?
+4784,"@@ -17,6 +17,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+         Task WriteAsync(ArraySegment<byte> buffer, bool chunk = false, CancellationToken cancellationToken = default(CancellationToken));
+         void Flush();
+         Task FlushAsync(CancellationToken cancellationToken = default(CancellationToken));
+-        void Write<T>(Action<WritableBuffer, T> write, T state);
++        void Write<T>(Action<WritableBuffer, T> write, T state) where T : struct;
+     }
+ }",Should this be `ISocketOutput<T> where T : struct`?,Why is this needed?
+4785,"@@ -104,4 +104,11 @@ public interface Snapshot {
+    * @return the location of the manifest list for this Snapshot
+    */
+   String manifestListLocation();
++
++  /**
++   * Return this snapshot's sequence number, or 0 if the table has no snapshot yet.
++   *
++   * @return the sequence number of this Snapshot
++   */
++  Long sequenceNumber();
+ }","In which case will this actually return 0? If there is no snapshot, then there is no `Snapshot` object, right?",nit: `@return the s
+4786,"@@ -133,6 +133,11 @@ class NumClassCheckHook(Hook):
+             for name, module in model.named_modules():
+                 if hasattr(module, 'num_classes') and not isinstance(
+                         module, (RPNHead, VGG, FusedSemanticHead, GARPNHead)):
++                    assert type(dataset.CLASSES) is not str, \
++                        (f'`CLASSES` in {dataset.__class__.__name__}'
++                         f'should be a tuple of str.'
++                         f'Add comma if number of classes is 1 as '
++                         f'CLASSES = ({dataset.CLASSES},)')
+                     assert module.num_classes == len(dataset.CLASSES), \
+                         (f'The `num_classes` ({module.num_classes}) in '
+                          f'{module.__class__.__name__} of '","This part of code is valuable and necessary. Can we move it to another place for a more clear logic and only check it once? For example, move it to line 133 before delving into each module.",I think it would be
+4787,"@@ -36,7 +36,7 @@ if __name__ == ""__main__"":
+             ""boto3"",
+             f""dagster{pin}"",
+             ""packaging"",
+-            ""psycopg2-binary<2.9"",
++            ""psycopg2-binary"",
+             ""requests"",
+         ],
+         extras_require={",Are we at all worried that changing pins will cause release hiccups? I think we've decided that relaxing pins should be safe but adding pins has caused us build issues in the past - so I think we're fine?,This should be `<2.
+4788,"@@ -12,8 +12,9 @@ import (
+ )
+ 
+ var (
+-	_                  = collection.Entry(&Entry{})
+-	serializedDataSize = swarm.SectionSize * 2
++	_                           = collection.Entry(&Entry{})
++	serializedDataSize          = swarm.SectionSize * 2
++	encryptedSerializedDataSize = swarm.EncryptedHashSize * 2
+ )
+ 
+ // Entry provides addition of metadata to a data reference.",could you please explain a bit where these numbers come from? for example: why is there no `swarm.EncryptedSectionSize`?,I don't think we need this anymore.
+4789,"@@ -39,9 +39,14 @@ func (r *Reader) Close() error {
+ 	return r.r.Close()
+ }
+ 
++// ContentType returns the MIME type of the object content.
++func (r *Reader) ContentType() string {
++	return r.r.Attrs().ContentType
++}
++
+ // Size returns the content size of the blob object.
+ func (r *Reader) Size() int64 {
+-	return r.r.Size()
++	return r.r.Attrs().Size
+ }
+ 
+ // Writer implements io.WriteCloser to write to blob. It must be closed after",s/object content/blob object/ (for consistency with the `Size` docs),Why do we need this?
+4790,"@@ -109,16 +109,7 @@ public class CheckJUnitDependencies extends DefaultTask {
+                                 + ""'org.junit.jupiter:junit-jupiter' dependency ""
+                                 + ""because tests use JUnit4 and useJUnitPlatform() is not enabled."");
+             }
+-        } else {
+-            String compileClasspath = ss.getCompileClasspathConfigurationName();
+-            boolean compilingAgainstOldJunit = hasDep(compileClasspath, CheckJUnitDependencies::isJunit4);
+-            Preconditions.checkState(
+-                    !compilingAgainstOldJunit,
+-                    ""Extraneous dependency on JUnit4 (no test mentions JUnit4 classes). Please exclude ""
+-                            + ""this from compilation to ensure developers don't accidentally re-introduce it, e.g.\n\n""
+-                            + ""    configurations."" + compileClasspath + "".exclude module: 'junit'\n\n"");
+         }
+-
+         // sourcesets might also contain Spock classes, but we don't have any special validation for these.
+     }
+ ","Rather than deleting this entirely, could we just emit it as a `warn` or `info` log line?",Why is this being removed?
+4791,"@@ -215,7 +215,7 @@ func (cfg *Config) newACMEClient(interactive bool) (*acmeClient, error) {
+ // lockKey returns a key for a lock that is specific to the operation
+ // named op being performed related to domainName and this config's CA.
+ func (cfg *Config) lockKey(op, domainName string) string {
+-	return fmt.Sprintf(""%s:%s:%s"", op, domainName, cfg.CA)
++	return fmt.Sprintf(""%s_%s_%s"", op, domainName, cfg.CA)
+ }
+ 
+ // Obtain obtains a single certificate for name. It stores the certificate",Is there a chance of this being a BC break of somekind? I.e. what if an old instance of Caddy is running in a cluster with a newer one?,I don't think this change is necess
+4792,"@@ -758,6 +758,7 @@ class CaiDataAccess(object):
+         except SQLAlchemyError as e:
+             LOGGER.exception('Attempt to delete data from CAI temporary store '
+                              'failed, disabling the use of CAI: %s', e)
++            session.rollback()
+ 
+         return num_rows
+ ",Thanks for this... is this the only place where the rollback is needed? Are there others?,Why do we need this?
+4793,"@@ -56,7 +56,7 @@ func TestTriangleEncoding(t *testing.T) {
+ 	}
+ 	t.Run(""encoding block with zero fields works"", func(t *testing.T) {
+ 		testRoundTrip(t, &blk.Block{
+-			BlockSig:        crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
++			BlockSig:        &crypto.Signature{Type: crypto.SigTypeSecp256k1, Data: []byte{}},
+ 			BLSAggregateSig: crypto.Signature{Type: crypto.SigTypeBLS, Data: []byte{}},
+ 		})
+ 	})","Should this also be a pointer? What happens if there are no BLS messages? I guess that's what this test is exercising, and Lotus also uses a non-pointer here.",why this change?
+4794,"@@ -427,9 +427,9 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
+ 
+ 	case driver.Replace:
+ 		// If the given document has a revision, use it as the precondition (it implies existence).
+-		pc, err := revisionPrecondition(a.Doc)
+-		if err != nil {
+-			return nil, """", err
++		pc, perr := revisionPrecondition(a.Doc)
++		if perr != nil {
++			return nil, """", perr
+ 		}
+ 		// Otherwise, just require that the document exists.
+ 		if pc == nil {",This was definitely a subtle bug right here.,I think this should 
+4795,"@@ -35,6 +35,12 @@ class GithubApi
+     @access_token = data['access_token'].first
+   end
+ 
++  def secondary_emails
++    return @secondary_emails if @secondary_emails
++    @secondary_emails = fetch_email_responses.select { |hsh| !hsh['primary'] && hsh['verified'] }
++                                             .map { |response| response['email'] }.compact
++  end
++
+   private
+ 
+   def request","If this method gets all the emails, it should be named appropriately. **all_emails** or just **emails**.",I don't think you ne
+4796,"@@ -48,7 +48,7 @@ func TestBroadcast(t *testing.T) {
+ 		}
+ 	}
+ 	u := func(_ context.Context, _ uint32, _ peerstore.PeerInfo, _ proto.Message) {}
+-	bootnodePort := testutil.RandomPort()
++	bootnodePort := 14689
+ 	cfg := config.Config{
+ 		Network: config.Network{Host: ""127.0.0.1"", Port: bootnodePort},
+ 	}","Can we still random, but if we randomly get a port is used before, we randomly pick again?",why did you change this?
+4797,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+ 
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low.",Why do we need this?
+4798,"@@ -11,5 +11,17 @@ module Gsa18f
+       super && self.gsa_if_restricted!
+     end
+     alias_method :can_new!, :can_create!
++
++    def can_cancel!
++      not_cancelled! && check((approver? || delegate? || requester?) && !purchaser?, 
++        ""Sorry, you are neither the requester, approver or delegate"")
++    end
++    alias_method :can_cancel_form!, :can_cancel!
++
++    protected
++
++    def purchaser?
++      @procurement.purchaser == @user
++    end
+   end
+ end",what if a purchaser is also an approver? or would that not happen?,I don't think you need t
+4799,"@@ -125,9 +125,12 @@ def sweep(privkeys, network, config, recipient, fee=None, imax=100):
+         raise BaseException(_('No inputs found. (Note that inputs need to be confirmed)'))
+     total = sum(i.get('value') for i in inputs)
+     if fee is None:
++        if not network.config.has_fee_estimates():
++            raise BaseException('Dynamic fee estimates not available')
+         outputs = [(TYPE_ADDRESS, recipient, total)]
+         tx = Transaction.from_io(inputs, outputs)
+         fee = config.estimate_fee(tx.estimated_size())
++
+     if total - fee < 0:
+         raise BaseException(_('Not enough funds on address.') + '\nTotal: %d satoshis\nFee: %d'%(total, fee))
+     if total - fee < dust_threshold(network):","Not sure why this change. You forgot to handle the case where the user has dynamic fees disabled and there are no fee estimates available. He should be able to sweep none-the-less (as he is using static fees anyway). The line with `config.fee_per_kb()` below, that you have deleted, handled that.",Shouldn't this be `if fe
+4800,"@@ -26,6 +26,11 @@ func (s *AuditLogsSourceStatus) GetCondition(t apis.ConditionType) *apis.Conditi
+ 	return auditLogsSourceCondSet.Manage(s).GetCondition(t)
+ }
+ 
++// GetTopLevelCondition returns the top level condition.
++func (s *AuditLogsSourceStatus) GetTopLevelCondition() *apis.Condition {
++	return auditLogsSourceCondSet.Manage(s).GetTopLevelCondition()
++}
++
+ // IsReady returns true if the resource is ready overall.
+ func (s *AuditLogsSourceStatus) IsReady() bool {
+ 	return auditLogsSourceCondSet.Manage(s).IsHappy()","sorry, I wasn't familiar with this TopLevelCondition... What it would be in this case? The AuditsLogReady condition?",Why do we need this?
+4801,"@@ -109,6 +109,7 @@ type DiffTransformation struct {
+ 
+ 	d     execute.Dataset
+ 	cache execute.TableBuilderCache
++	alloc *memory.Allocator
+ 
+ 	inputCache *execute.GroupLookup
+ }",Where does the `alloc` field get set?,Why do we need this?
+4802,"@@ -273,9 +273,10 @@ func setupPostgres(w *DWH) error {
+ 	return nil
+ }
+ 
+-func runQueryPostgres(db *sql.DB, opts *queryOpts) (*sql.Rows, string, error) {
++func runQueryPostgres(db *sql.DB, opts *queryOpts) (*sql.Rows, int64, error) {
+ 	var (
+ 		query      = fmt.Sprintf(""SELECT * FROM %s %s"", opts.table, opts.selectAs)
++		countQuery = fmt.Sprintf(""SELECT count(*) FROM %s %s"", opts.table, opts.selectAs)
+ 		conditions []string
+ 		values     []interface{}
+ 		numFilters = 1",looks expensive to do it on each query,I think this should 
+4803,"@@ -38,16 +38,16 @@ import model_params
+ _LOGGER = logging.getLogger(__name__)
+ 
+ _INPUT_DATA_FILE = resource_filename(
+-  ""nupic.datafiles"", ""extra/nyctaxi/nyc_taxi.csv""
++  ""nupic.datafiles"", ""extra/nyctaxi/nycTaxi.csv""
+ )
+ _OUTPUT_PATH = ""anomaly_scores.csv""
+ 
+ _ANOMALY_THRESHOLD = 0.9
+ 
+-# minimum metric value of nyc_taxi.csv
++# minimum metric value of nycTaxi.csv
+ _INPUT_MIN = 8
+ 
+-# maximum metric value of nyc_taxi.csv
++# maximum metric value of nycTaxi.csv
+ _INPUT_MAX = 39197
+ 
+ ",@rhyolight -- but weren't we supposed to be standardizing on using underscores in file names (versus camelcase)?,Why did you change t
+4804,"@@ -209,9 +209,9 @@ module Mongoid
+           # @since 2.1.0
+           def empty?
+             if _loaded?
+-              in_memory.count == 0
++              in_memory.length == 0
+             else
+-              _unloaded.count + _added.count == 0
++              _added.length == 0 && !_unloaded.exists?
+             end
+           end
+ ",Can this simply call `in_memory.empty?` ?,I think this should be `in_memory.empty?`
+4805,"@@ -88,6 +88,13 @@ func init() {
+ // CreateSettingsFile creates the settings file (like settings.php) for the
+ // provided app is the apptype has a settingsCreator function.
+ func (app *DdevApp) CreateSettingsFile() (string, error) {
++	// If the user has asked us to skip settings file manipulation, then just bail
++	// out early.
++	if app.OmitSettingsPhp {
++		util.Warning(""Skipping creation of settings file."")
++		return """", nil
++	}
++
+ 	app.SetApptypeSettingsPaths()
+ 
+ 	// If neither settings file options are set, then don't continue. Return",The styling/wording here probably needs some thought. It's more of a placeholder.,I'm not sure if this is the best way to d
+4806,"@@ -9,10 +9,10 @@ Rails.application.routes.draw do
+ 
+   resources :stack_entries
+ 
+-  resources :password_reset, only: [:new, :create] do
++  resources :password_resets, only: [:new, :create] do
+     collection do
+       get :confirm
+-      post :reset
++      patch :reset
+     end
+   end
+   resources :activation_resends, only: [:new, :create]",Using a plural route helps in detecting the path automatically for `= form_for @password_reset`.,I think this should be `post :reset`
+4807,"@@ -9,8 +9,8 @@ const fs = require('fs');
+ const { MongoClient } = require('../../../src');
+ const { TestConfiguration } = require('./config');
+ const { getEnvironmentalOptions } = require('../utils');
+-const { eachAsync } = require('../../../src/utils');
+ const mock = require('../mongodb-mock/index');
++const { inspect } = require('util');
+ 
+ const MONGODB_URI = process.env.MONGODB_URI || 'mongodb://localhost:27017';
+ const MONGODB_API_VERSION = process.env.MONGODB_API_VERSION;",Is `metadata` required on all tests? I actually just removed the metadata field entirely from a few tests in my PR.,Why was this removed?
+4808,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,nit: `of` -> `from`
+4809,"@@ -145,6 +145,10 @@ public class TemporaryFilesystem {
+   }
+ 
+   public boolean deleteBaseDir() {
+-    return baseDir.delete();
++    boolean wasDeleted = baseDir.delete();
++    if (wasDeleted) {
++      Runtime.getRuntime().removeShutdownHook(shutdownHook);
++    }
++    return wasDeleted;
+   }
+ }","I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways.",Shouldn't this be i
+4810,"@@ -232,7 +232,17 @@ func (c *CVCController) updateCVCObj(
+ // 4. Create cstorvolumeclaim resource.
+ // 5. Update the cstorvolumeclaim with claimRef info and bound with cstorvolume.
+ func (c *CVCController) createVolumeOperation(cvc *apis.CStorVolumeClaim) (*apis.CStorVolumeClaim, error) {
+-	_ = cvc.Annotations[string(apis.ConfigClassKey)]
++
++	policyName := cvc.Annotations[string(apis.VolumePolicyKey)]
++	volumePolicy := &apis.CStorVolumePolicy{}
++	var err error
++	if policyName != """" {
++		klog.Infof(""uses cstorvolume policy for volume configuration"")
++		volumePolicy, err = c.clientset.OpenebsV1alpha1().CStorVolumePolicies(getNamespace()).Get(policyName, metav1.GetOptions{})
++		if err != nil {
++			return nil, err
++		}
++	}
+ 
+ 	klog.V(2).Infof(""creating cstorvolume service resource"")
+ 	svcObj, err := getOrCreateTargetService(cvc)",Better to push getting policy details into a func we can reuse later.,I don't think this 
+4811,"@@ -52,6 +52,14 @@ type outbound struct {
+ 	URL    string
+ }
+ 
++func (o outbound) Start() error {
++	return nil // nothing to do
++}
++
++func (o outbound) Stop() error {
++	return nil // nothing to do
++}
++
+ func (o outbound) Call(ctx context.Context, req *transport.Request) (*transport.Response, error) {
+ 	start := time.Now()
+ 	deadline, _ := ctx.Deadline()","optional: while there's nothing to do, a good way to catch bugs (where we use an outbound without calling `Start`) might be to have this outbound verify that `Start` is called before `Call` or `Stop`",Why do we need this
+4812,"@@ -20,6 +20,9 @@ import (
+ 	""flag""
+ 	""os""
+ 
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/apis""
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/aws/actuators/cluster""
++	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/aws/actuators/machine""
+ 	clusterapis ""sigs.k8s.io/cluster-api/pkg/apis""
+ 	""sigs.k8s.io/cluster-api/pkg/apis/cluster/common""
+ 	""sigs.k8s.io/cluster-api/pkg/client/clientset_generated/clientset""","Not a blocker by any means, but I think there is value in keeping the local imports in a separate group.",nit: remove empty line
+4813,"@@ -295,3 +295,14 @@ func TestStartStopFailures(t *testing.T) {
+ 		}
+ 	}
+ }
++
++func TestNoOutboundsForService(t *testing.T) {
++	assert.Panics(t, func() {
++		NewDispatcher(Config{
++			Name: ""test"",
++			Outbounds: Outbounds{
++				""my-test-service"": {},
++			},
++		})
++	})
++}","nit - I would test the error message as well. For panic, you might need to see if the stack contains the error message, instead of equaling.",Can you add a case whe
+4814,"@@ -162,6 +162,18 @@ func substitute(s reflect.Value, replacer *strings.Replacer) {
+ 		case *compute.Client, *storage.Client, context.Context, context.CancelFunc:
+ 			// We specifically do not want to change fields with these types.
+ 			continue
++		case *WaitForInstancesStopped:
++			var newSlice WaitForInstancesStopped
++			for _, v := range *raw.(*WaitForInstancesStopped) {
++				newSlice = append(newSlice, replacer.Replace(v))
++			}
++			f.Set(reflect.ValueOf(&newSlice))
++		case *WaitForInstancesSignal:
++			var newSlice WaitForInstancesSignal
++			for _, v := range *raw.(*WaitForInstancesSignal) {
++				newSlice = append(newSlice, replacer.Replace(v))
++			}
++			f.Set(reflect.ValueOf(&newSlice))
+ 		default:
+ 			if f.Kind() != reflect.Ptr {
+ 				continue",Didn't we have specific logic for handling slices vs structs?,Why do we need to do t
+4815,"@@ -4199,7 +4199,15 @@ void EntityList::QuestJournalledSayClose(Mob *sender, float dist, const char *mo
+ 	buf.WriteInt32(0); // location, client doesn't seem to do anything with this
+ 	buf.WriteInt32(0);
+ 	buf.WriteInt32(0);
+-	buf.WriteString(message);
++
++	// auto inject saylinks (say)
++	if (RuleB(Chat, AutoInjectSaylinksToSay)) {
++		std::string new_message = EQ::SayLinkEngine::InjectSaylinksIfNotExist(message);
++		buf.WriteString(new_message.c_str());
++	}
++	else {
++		buf.WriteString(message);
++	}
+ 
+ 	auto outapp = new EQApplicationPacket(OP_SpecialMesg, buf);
+ ",`c_str()` is not needed.,I don't think you need
+4816,"@@ -310,9 +310,12 @@ func installHandlers(c *ExtraConfig, s *genericapiserver.GenericAPIServer) {
+ 		})
+ 	}
+ 
++	if features.DefaultFeatureGate.Enabled(features.Egress) || features.DefaultFeatureGate.Enabled(features.ServiceExternalIP) {
++		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/externalippool"", webhook.HandlerForValidateFunc(c.externalIPPoolController.ValidateExternalIPPool))
++	}
++
+ 	if features.DefaultFeatureGate.Enabled(features.Egress) {
+ 		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/egress"", webhook.HandlerForValidateFunc(c.egressController.ValidateEgress))
+-		s.Handler.NonGoRestfulMux.HandleFunc(""/validate/externalippool"", webhook.HandlerForValidateFunc(c.externalIPPoolController.ValidateExternalIPPool))
+ 	}
+ 
+ 	if features.DefaultFeatureGate.Enabled(features.AntreaIPAM) {",The handler will be installed twice if you don't remove the below one.,Shouldn't this be `&&`?
+4817,"@@ -35,9 +35,14 @@ public class EthashConfigOptions {
+     return JsonUtil.getLong(ethashConfigRoot, ""fixeddifficulty"");
+   }
+ 
++  public OptionalLong getEpochLengthActivationBlock() {
++    return JsonUtil.getLong(ethashConfigRoot, ""epochlengthactivation"");
++  }
++
+   Map<String, Object> asMap() {
+     final ImmutableMap.Builder<String, Object> builder = ImmutableMap.builder();
+     getFixedDifficulty().ifPresent(l -> builder.put(""fixeddifficulty"", l));
++    getEpochLengthActivationBlock().ifPresent(a -> builder.put(""epochlengthactivation"", a));
+     return builder.build();
+   }
+ }",How about putting `epochLength` (or something like that) in place of `a` just to make it easier to read,This should be `getEpoc
+4818,"@@ -79,6 +79,14 @@ func (graph *BuildGraph) Target(label BuildLabel) *BuildTarget {
+ func (graph *BuildGraph) TargetOrDie(label BuildLabel) *BuildTarget {
+ 	target := graph.Target(label)
+ 	if target == nil {
++		// TODO(jpoole): This is just a small usability message to help with the migration from v15 to v16. We should
++		// probably remove this after a grace period.
++		if label.Subrepo == ""pleasings"" {
++			if _, ok := graph.subrepos[""pleasings""]; !ok {
++				log.Warning(""You've tried to use the pleasings sub-repo. This is no longer included automatically."")
++				log.Warning(""Use `plz init pleasings` to add the pleasings repo to your project."")
++			}
++		}
+ 		log.Fatalf(""Target %s not found in build graph\n"", label)
+ 	}
+ 	return target",Wouldn't this still fire afterwards if you created one called `pleasings`? or am I missing something?,I don't think this is t
+4819,"@@ -63,14 +63,14 @@ const kbpRecordPrefix = ""_keybase_pages.""
+ // _keybase_pages.meatball.gao.io   TXT ""kbp=/keybase/public/songgao/meatball/""
+ // _keybase_pages.song.gao.io       TXT ""kbp=/keybase/private/songgao,kb_bot/blah""
+ // _keybase_pages.blah.strib.io     TXT ""kbp=/keybase/private/strib#kb_bot/blahblahb"" ""lah/blah/""
+-// _keybase_pages.kbp.jzila.com     TXT ""kbp=git-keybase://private/jzila,kb_bot/kbp.git""
++// _keybase_pages.kbp.jzila.com     TXT ""kbp=git@keybase:private/jzila,kb_bot/kbp.git""
+ func LoadRootFromDNS(log *zap.Logger, domain string) (root Root, err error) {
+ 	var rootPath string
+ 
+ 	defer func() {
+ 		zapFields := []zapcore.Field{
+ 			zap.String(""domain"", domain),
+-			zap.String(""root_path"", rootPath),
++			zap.String(""kbp_record"", rootPath),
+ 		}
+ 		if err == nil {
+ 			log.Info(""LoadRootFromDNS"", zapFields...)","I don't love this syntax; it doesn't match anything we're currently doing and it's not obvious. Why isn't this `/keybase/private/jzila,kb_bot/.kbfs_autogit/public/jzila/kbp.git`?",Why did you change this
+4820,"@@ -1135,11 +1135,17 @@ public final class Queue<T> extends AbstractsQueue<T, Queue<T>> implements Linea
+         return ofAll(toList().update(index, element));
+     }
+ 
+-    @SuppressWarnings(""unchecked"")
+     @Override
+     public <U> Queue<Tuple2<T, U>> zip(Iterable<? extends U> that) {
++        return zipWith(that, Tuple::of);
++    }
++
++    @SuppressWarnings(""unchecked"")
++    @Override
++    public <U, R> Queue<R> zipWith(Iterable<? extends U> that, BiFunction<? super T, ? super U, ? extends R> mapper) {
+         Objects.requireNonNull(that, ""that is null"");
+-        return ofAll(toList().zip((Iterable<U>) that));
++        Objects.requireNonNull(mapper, ""mapper is null"");
++        return ofAll(toList().zipWith((Iterable<U>) that, mapper));
+     }
+ 
+     @Override","Does a type-hint work instead of casting? `return ofAll(toList().<U> zipWith(that, mapper));` (Probably not, just a question.)","I don't think we need to annotate this as `@SuppressWarnings(""unchecked"")`."
+4821,"@@ -90,11 +90,11 @@ public class TestTableMetadata {
+     long previousSnapshotId = System.currentTimeMillis() - new Random(1234).nextInt(3600);
+     Snapshot previousSnapshot = new BaseSnapshot(
+         ops.io(), previousSnapshotId, null, previousSnapshotId, null, null, null, ImmutableList.of(
+-        new GenericManifestFile(localInput(""file:/tmp/manfiest.1.avro""), SPEC_5.specId())));
++          new GenericManifestFile(localInput(""file:/tmp/manfiest.1.avro""), SPEC_5.specId())));
+     long currentSnapshotId = System.currentTimeMillis();
+     Snapshot currentSnapshot = new BaseSnapshot(
+         ops.io(), currentSnapshotId, previousSnapshotId, currentSnapshotId, null, null, 7, ImmutableList.of(
+-        new GenericManifestFile(localInput(""file:/tmp/manfiest.2.avro""), SPEC_5.specId())));
++          new GenericManifestFile(localInput(""file:/tmp/manfiest.2.avro""), SPEC_5.specId())));
+ 
+     List<HistoryEntry> snapshotLog = ImmutableList.<HistoryEntry>builder()
+         .add(new SnapshotLogEntry(previousSnapshot.timestampMillis(), previousSnapshot.snapshotId()))",Are these required?,Why did you change this?
+4822,"@@ -544,6 +544,13 @@ func (c *client) initClient() {
+ 	// Snapshots to avoid mutex access in fast paths.
+ 	c.out.wdl = opts.WriteDeadline
+ 	c.out.mp = opts.MaxPending
++	// Snapshot max control line since currently can not be changed on reload and we
++	// were checking it on each call to parse. If this changes and we allow MaxControlLine
++	// to be reloaded without restart, this code will need to change.
++	c.mcl = int32(opts.MaxControlLine)
++	if c.mcl == 0 {
++		c.mcl = MAX_CONTROL_LINE_SIZE
++	}
+ 
+ 	c.subs = make(map[string]*subscription)
+ 	c.echo = true","This is consistent for all clients that we will check yes? Seems like we should just use the singleton, maybe pass it to the parse function or since clients have a server pointer set it at server start and just access that way without locks?","I don't think this is correct. If MaxControlLine is set to 0, then it will "
+4823,"@@ -62,7 +62,7 @@ public class JavaTokenizer extends JavaCCTokenizer {
+ 
+         if (ignoreLiterals && (javaToken.kind == JavaTokenKinds.STRING_LITERAL
+                 || javaToken.kind == JavaTokenKinds.CHARACTER_LITERAL
+-                || javaToken.kind == JavaTokenKinds.DECIMAL_LITERAL
++                || javaToken.kind == JavaTokenKinds.INTEGER_LITERAL
+                 || javaToken.kind == JavaTokenKinds.FLOATING_POINT_LITERAL)) {
+             image = String.valueOf(javaToken.kind);
+         }","Note that this is a bug, that should be fixed on master. `DECIMAL_LITERAL` cannot match any token, because it's declared with a `#`.",Why do we need this change?
+4824,"@@ -26,6 +26,8 @@ import (
+ 	""sync/atomic""
+ 	""time""
+ 
++	""github.com/nats-io/nuid""
++
+ 	""github.com/nats-io/nats-server/v2/server/pse""
+ )
+ ",Don't need extra line here.,"""github.com/pkg/errors"""
+4825,"@@ -637,9 +637,7 @@ namespace Nethermind.JsonRpc.Test.Modules.Proof
+                 .Op(Instruction.DELEGATECALL)
+                 .Done;
+             CallResultWithProof result = TestCallWithCode(code);
+-            
+-            // change in test after the modification to how the ReleaseSpec is delivered to the virtual machine
+-            Assert.AreEqual(2 + (_useNonZeroGasPrice ? 1 : 0), result.Accounts.Length);
++            Assert.AreEqual(3, result.Accounts.Length);
+         }
+ 
+         [Test]","For the first look, this change is strange. Were we passing these tests before?",Why was this test remov
+4826,"@@ -21,9 +21,16 @@ import (
+ )
+ 
+ func gracefullyStopProcess(pid int) error {
+-	cmd := exec.Command(""taskkill"", ""/pid"", strconv.Itoa(pid))
++	fmt.Printf(""Stop..."")
++	// process on windows will not stop unless forced with /f
++	cmd := exec.Command(""taskkill"", ""/pid"", strconv.Itoa(pid), ""/f"")
+ 	if err := cmd.Run(); err != nil {
+ 		return fmt.Errorf(""taskkill: %v"", err)
+ 	}
+ 	return nil
+ }
++
++func matchProcess(appname string, processname string) bool {
++	// on Windows the process name will include the extension
++	return appname == processname+"".exe""
++}","On Windows, doesn't `os.Args[0]` include the `.exe`? What if you run the program like `caddy.exe`?",I don't think we need t
+4827,"@@ -112,13 +112,8 @@ type OpenvpnConfigNegotiator struct {
+ 	vpnConfig openvpn_service.VPNConfig
+ }
+ 
+-// ConsumeConfig doesn't do anything on the openvpn side, since it's not required here
+-func (ocn *OpenvpnConfigNegotiator) ConsumeConfig(json.RawMessage) error {
+-	return nil
+-}
+-
+ // ProvideConfig returns the config for user
+-func (ocn *OpenvpnConfigNegotiator) ProvideConfig() (session.ServiceConfiguration, error) {
++func (ocn *OpenvpnConfigNegotiator) ProvideConfig(json.RawMessage) (session.ServiceConfiguration, error) {
+ 	return &ocn.vpnConfig, nil
+ }
+ ","I don't see anywhere where `ServiceConfiguration` interface implementation would return any kind of error. Not sure if its needed, but we could ALWAYS return a valid 'pseudo' configuration without possibility of error.",Why remove this?
+4828,"@@ -36,4 +36,15 @@ public class CommonRenderingUtilTest {
+     assertThat(CommonRenderingUtil.stripQuotes(""'a'bc'"")).isEqualTo(""'a'bc'"");
+     assertThat(CommonRenderingUtil.stripQuotes(""\""a\""bc\"""")).isEqualTo(""\""a\""bc\"""");
+   }
++
++  @Test
++  public void testGetDocLines() {
++    // Check that we don't care which form of line break is used.
++    assertThat(CommonRenderingUtil.getDocLines(""a\nb\nc"")).containsExactly(""a"", ""b"", ""c"").inOrder();
++    assertThat(CommonRenderingUtil.getDocLines(""a\rb\rc"")).containsExactly(""a"", ""b"", ""c"").inOrder();
++    assertThat(CommonRenderingUtil.getDocLines(""a\r\nb\r\nc""))
++        .containsExactly(""a"", ""b"", ""c"")
++        .inOrder();
++    assertThat(CommonRenderingUtil.getDocLines("""")).isEmpty();
++  }
+ }","Do we actually want to split on `\r`? I thought that the ""newline sequence"" was only `\r\n` on windows.","I think it would be better to use `containsExactly(""a"", ""b"", ""c"")`"
+4829,"@@ -273,10 +273,14 @@ void t_json_generator::write_type_spec(t_type* ttype) {
+     write_key_and_string(""valueTypeId"", get_type_name(vtype));
+     write_type_spec_object(""keyType"", ktype);
+     write_type_spec_object(""valueType"", vtype);
+-  } else if (ttype->is_list() || ttype->is_set()) {
++  } else if (ttype->is_list()) {
+     t_type* etype = ((t_list*)ttype)->get_elem_type();
+     write_key_and_string(""elemTypeId"", get_type_name(etype));
+     write_type_spec_object(""elemType"", etype);
++  } else if (ttype->is_set()) {
++    t_type* etype = ((t_set*)ttype)->get_elem_type();
++    write_key_and_string(""elemTypeId"", get_type_name(etype));
++    write_type_spec_object(""elemType"", etype);
+   }
+ }
+ ",Nit: these lines are duplicated from above. They can be refactored by setting etype in a conditional and putting 282 and 283 below that.,Shouldn't this be `ttype->is_set()`?
+4830,"@@ -49,7 +49,7 @@ func (s *Server) handleSignals() {
+ 				s.Debugf(""Trapped %q signal"", sig)
+ 				switch sig {
+ 				case syscall.SIGINT:
+-					s.Noticef(""Server Exiting.."")
++					s.Shutdown()
+ 					os.Exit(0)
+ 				case syscall.SIGUSR1:
+ 					// File log re-open for rotating file logs.","I would do an s.Notice(""Initiating Shutdown..."") then after Shutdown() do the original Server Exiting.","I think this should be `s.Noticef(""Server exiting..."")`"
+4831,"@@ -57,6 +57,11 @@ namespace Nethermind.DataMarketplace.Consumers.Refunds.Services
+             ulong now = _timestamper.UnixTime.Seconds;
+             if (!deposit.CanClaimRefund(now))
+             {
++                var timeLeftToClaimRefund = deposit.GetTimeLeftToClaimRefund(now);
++                if (timeLeftToClaimRefund > 0)
++                {
++                    if (_logger.IsError) _logger.Info($""Time left to claim a refund: {timeLeftToClaimRefund} seconds."");
++                }
+                 return RefundClaimStatus.Empty;
+             }
+             ",Not sure with how many seconds on average are we dealing with but maybe it's better to have hh:mm:ss format in logs - you can make it with `TimeSpan.FromSeconds(seconds).ToString()`,Shouldn't this be `> 0`?
+4832,"@@ -257,6 +257,12 @@ func (a *ClusterDeploymentValidatingAdmissionHook) validateCreate(admissionSpec
+ 		if aws.Region == """" {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""region""), ""must specify AWS region""))
+ 		}
++		for i, mp := range newObject.Spec.Compute {
++			computePath := specPath.Child(""compute"").Index(i)
++			if mp.Platform.AWS == nil {
++				allErrs = append(allErrs, field.Required(computePath.Child(""aws""), ""must specify platform for compute machine sets""))
++			}
++		}
+ 	}
+ 	if newObject.Spec.Platform.Azure != nil {
+ 		numberOfPlatforms++",Why is this required? The user should be able to omit it and use the defaults.,Shouldn't this be `mp.Platform.AWS == nil`?
+4833,"@@ -1353,6 +1353,12 @@ class MouseSettingsPanel(SettingsPanel):
+ 		self.audioDetectBrightnessCheckBox=sHelper.addItem(wx.CheckBox(self,label=audioDetectBrightnessText))
+ 		self.audioDetectBrightnessCheckBox.SetValue(config.conf[""mouse""][""audioCoordinates_detectBrightness""])
+ 
++		# Translators: This is the label for a checkbox in the
++		# mouse settings panel.
++		handleInjectedMouseControlText = _(""Handle mouse control from other &applications"")
++		self.handleInjectedMouseControlCheckBox=sHelper.addItem(wx.CheckBox(self,label=handleInjectedMouseControlText))
++		self.handleInjectedMouseControlCheckBox.SetValue(config.conf[""mouse""][""handleInjectedMouseControl""])
++
+ 	def onSave(self):
+ 		config.conf[""mouse""][""reportMouseShapeChanges""]=self.shapeCheckBox.IsChecked()
+ 		config.conf[""mouse""][""enableMouseTracking""]=self.mouseTrackingCheckBox.IsChecked()","I don't think the naming of this setting conveys what it does. Maybe something like ""Ignore mouse movement triggered by other applications""",This should be translated.
+4834,"@@ -26,11 +26,12 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation
+         public static readonly OpenTelemetryProtocolExporterEventSource Log = new OpenTelemetryProtocolExporterEventSource();
+ 
+         [NonEvent]
+-        public void FailedToReachCollector(Exception ex)
++        public void FailedToReachCollector(Uri collectorUri, Exception ex)
+         {
+             if (Log.IsEnabled(EventLevel.Error, EventKeywords.All))
+             {
+-                this.FailedToReachCollector(ex.ToInvariantString());
++                var rawCollectorUri = collectorUri.ToString();
++                this.FailedToReachCollector(rawCollectorUri, ex.ToInvariantString());
+             }
+         }
+ ",Didn't went with backwards compatibility since it's still in beta,nit: `rawCollectorUri` -> `collectorUri`
+4835,"@@ -82,6 +82,9 @@ python::tuple fragmentMolHelper3(const RDKit::ROMol& mol, python::object ob,
+   std::vector<std::pair<RDKit::ROMOL_SPTR, RDKit::ROMOL_SPTR>> tres;
+   std::unique_ptr<std::vector<unsigned int>> v =
+       pythonObjectToVect<unsigned int>(ob);
++  if (!v) {
++    throw_value_error(""invalid value for bondsToCut"");
++  }
+   bool ok = RDKit::MMPA::fragmentMol(mol, tres, *v, minCuts, maxCuts);
+   python::list pyres;
+   if (ok) {",Perhaps bondsToCut must be None or non empty.,Shouldn't this be `throw_exception`?
+4836,"@@ -79,6 +79,7 @@ function Sparkline( {
+ 	return (
+ 		<div className=""googlesitekit-analytics-sparkline-chart-wrap"">
+ 			<GoogleChart
++				chartType=""line""
+ 				data={ data }
+ 				options={ chartOptions }
+ 				// eslint-disable-next-line sitekit/camelcase-acronyms","See above, we could avoid adding that (same applies below).",Why do we need this?
+4837,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-	  
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()), 
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+ 
+   @Override",should use Number instead of Long,Why do we need to ca
+4838,"@@ -1,6 +1,7 @@
+ 'use strict';
+ 
+ var assert = require('assert');
++const expect = require('chai').expect;
+ var co = require('co');
+ var test = require('./shared').assert;
+ var setupDatabase = require('./shared').setupDatabase;",Should the rest of the file be updated to use `expect` or should this test use the same format as the rest of the tests?,Why is this needed?
+4839,"@@ -227,6 +227,12 @@ func (a *AWSActuator) Refresh() error {
+ 		}
+ 		logger.Debug(""Found hosted zone"")
+ 		a.zoneID = &zoneID
++
++		// Update dnsZone status now that we have the zoneID
++		if err := a.ModifyStatus(); err != nil {
++			a.logger.WithError(err).Error(""failed to update status after refresh"")
++			return err
++		}
+ 	}
+ 
+ 	if a.zoneID == nil {",How would you feel about a different approach where the `DeleteAWSRecordSets` gets passed the zone ID and zone name rather than the `DNSZone`?,Shouldn't this be `l
+4840,"@@ -66,15 +66,17 @@ class PhotoMetricDistortion(object):
+ 
+ class Expand(object):
+ 
+-    def __init__(self, mean=(0, 0, 0), to_rgb=True, ratio_range=(1, 4)):
++    def __init__(self, mean=(0, 0, 0), to_rgb=True,
++                 ratio_range=(1, 4), prob=0.5):
+         if to_rgb:
+             self.mean = mean[::-1]
+         else:
+             self.mean = mean
+         self.min_ratio, self.max_ratio = ratio_range
++        self.prob = prob
+ 
+     def __call__(self, img, boxes, labels):
+-        if random.randint(2):
++        if random.uniform(0, 1) > self.prob:
+             return img, boxes, labels
+ 
+         h, w, c = img.shape","it seems `random.uniform(0, 1)` similar to `random.randint(2)`, all have 1/2 probabilities.","Why not `random.uniform(0, 1)`?"
+4841,"@@ -121,7 +121,11 @@ class AutoScaleConnection(AWSQueryConnection):
+         for i in xrange(1, len(items)+1):
+             if isinstance(items[i-1], dict):
+                 for k, v in items[i-1].iteritems():
+-                    params['%s.member.%d.%s' % (label, i, k)] = v
++                    if isinstance(v, dict):
++                        for kk, vv in v.iteritems():
++                            params['%s.member.%d.%s.%s' % (label, i, k, kk)] = vv
++                    else:
++                        params['%s.member.%d.%s' % (label, i, k)] = v
+             elif isinstance(items[i-1], basestring):
+                 params['%s.member.%d' % (label, i)] = items[i-1]
+ ","Added to support EBS volume creation, used like this: blockDeviceMap = [] blockDeviceMap.append( {'DeviceName':'/dev/sdc', 'VirtualName' : 'ephemeral0'}) blockDeviceMap.append( {'DeviceName':'/dev/sdh', 'Ebs': {'VolumeSize' : '100'} })",`kk` -> `k`
+4842,"@@ -17,6 +17,8 @@ type mockedSigner struct {
+ 	signatureToReturn identity.Signature
+ }
+ 
++var testMysteriumApiUrl = ""http://testUrl""
++
+ func (signer *mockedSigner) Sign(message []byte) (identity.Signature, error) {
+ 	return signer.signatureToReturn, nil
+ }","We shouldn't depend that url is `mysterium` - it can be just `testRequestURL`. Also, `URL` has to be upper-case.",type mockedSigner struct {
+4843,"@@ -689,8 +689,9 @@ VKAPI_ATTR VkResult VKAPI_CALL GetPhysicalDeviceImageFormatProperties2(VkPhysica
+                                                                        const VkPhysicalDeviceImageFormatInfo2 *pImageFormatInfo,
+                                                                        VkImageFormatProperties2 *pImageFormatProperties) {
+     instance_layer_data *instance_data = GetLayerDataPtr(get_dispatch_key(physicalDevice), instance_layer_data_map);
+-    bool skip = PreCallValidateGetPhysicalDeviceImageFormatProperties2(instance_data->report_data, pImageFormatInfo,
+-                                                                       pImageFormatProperties);
++    unique_lock_t lock(global_lock);
++    bool skip = PreCallValidateGetPhysicalDeviceImageFormatProperties2(physicalDevice, pImageFormatInfo, pImageFormatProperties);
++    lock.unlock();
+     if (skip) {
+         return VK_ERROR_VALIDATION_FAILED_EXT;
+     } else {",We could delay this look-up now and only do it in the non-skip case. I suspect this is true for (almost) all of the top-level refactored functions.,Why do you need a lock here?
+4844,"@@ -144,6 +144,15 @@ std::string MetaServiceUtils::schemaTagKey(GraphSpaceID spaceId, TagID tagId, in
+     return key;
+ }
+ 
++std::string MetaServiceUtils::schemaTagPrefix(GraphSpaceID spaceId, TagID tagId) {
++    std::string key;
++    key.reserve(kTagsTable.size() + sizeof(GraphSpaceID) + sizeof(TagID));
++    key.append(kTagsTable.data(), kTagsTable.size());
++    key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
++    key.append(reinterpret_cast<const char*>(&tagId), sizeof(tagId));
++    return key;
++}
++
+ std::string MetaServiceUtils::schemaTagsPrefix(GraphSpaceID spaceId) {
+     std::string key;
+     key.reserve(kTagsTable.size() + sizeof(GraphSpaceID));","Typically, to be simple, we could reserve a const length space.",Why do we need this function?
+4845,"@@ -0,0 +1,2 @@
++from .reader import *
++from .builder import Builder",Need to add a license and copyright header to each file.,
+4846,"@@ -7,6 +7,8 @@
+   <% end %>
+ 
+   <%= form.inputs do %>
++    <%= hidden_field_tag ""coupon_id"" %>
++
+     <% if signed_out? %>
+       <ul class=""checkout-signin-signup-toggle"">
+         <li>","If I'm not mistaken, this line is now outside of the `if signed_out?` block, right? Any concerns about that? Seems odd that we wouldn't accept coupons for signed in users, but I want to make sure we understand the ramifications of this change.",Why is this needed?
+4847,"@@ -130,7 +130,7 @@ public abstract class PostgrePrivilege implements DBAPrivilege, Comparable<Postg
+ 
+     @NotNull
+     @Override
+-    public DBPDataSource getDataSource() {
++    public PostgreDataSource getDataSource() {
+         return owner.getDataSource();
+     }
+ ",Please remove the unused import of DBPDataSource.,Why this change?
+4848,"@@ -43,7 +43,7 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+ 
+         public void LogError(string data)
+         {
+-            _log.LogError(data);
++            _log.LogWarning(data);
+         }
+ 
+         public void LogInformation(string data)","I think you should add some extra message here saying it was originally sent as an error, for diagnosability.",Why did you change this?
+4849,"@@ -144,14 +144,14 @@ void test3() {
+     ExplicitBitVect bv(2048);
+     AvalonTools::getAvalonFP(""c1cocc1"", true, bv, 2048, false, true, 0x006FFF);
+     BOOST_LOG(rdInfoLog) << ""c1cocc1 "" << bv.getNumOnBits() << std::endl;
+-    TEST_ASSERT(bv.getNumOnBits() == 53);
++    TEST_ASSERT(bv.getNumOnBits() == 48);
+   }
+   {
+     ExplicitBitVect bv(2048);
+     AvalonTools::getAvalonFP(""C1=COC=C1"", true, bv, 2048, false, true,
+                              0x006FFF);
+     BOOST_LOG(rdInfoLog) << ""C1=COC=C1 "" << bv.getNumOnBits() << std::endl;
+-    TEST_ASSERT(bv.getNumOnBits() == 53);
++    TEST_ASSERT(bv.getNumOnBits() == 48);
+   }
+ 
+   BOOST_LOG(rdInfoLog) << ""done"" << std::endl;",I believe that all the changes in this file are not valid for v1.2 of the Avalon toolkit.,Why this change?
+4850,"@@ -509,6 +509,7 @@ public class DBService {
+         } else {
+             // carrying over auditEnabled from original role
+             role.setAuditEnabled(originalRole.getAuditEnabled());
++            mergeOriginalRoleAndMetaRoleAttributes(originalRole, role);
+             requestSuccess = con.updateRole(domainName, role);
+         }
+         ",we cannot change the behavior of the processRole - that method is used in lots of places. this call must be done only in the method where templates are being handled.,Why do we need this?
+4851,"@@ -63,7 +63,9 @@ const (
+ 	// ECSAgentExecConfigDir is the directory where ECS Agent will write the ExecAgent config files to
+ 	ECSAgentExecConfigDir = ecsAgentExecDepsDir + ""/"" + ContainerConfigDirName
+ 	// HostExecConfigDir is the dir where ExecAgents Config files will live
+-	HostExecConfigDir = hostExecDepsDir + ""/"" + ContainerConfigDirName
++	HostExecConfigDir          = hostExecDepsDir + ""/"" + ContainerConfigDirName
++	ExecAgentLogConfigFileName = ""seelog.xml""
++	ContainerLogConfigFile     = ""configuration/"" + ExecAgentLogConfigFileName
+ )
+ 
+ var (",I think we probably want to follow the same naming convention that we do with `execAgentConfigFileNameTemplate` (using the SHA in the name of the file). This file might be confgurable in the future and when that happens we will be ready. Plus it's pretty much the same code that we already use for the config file.,I think this should be `
+4852,"@@ -380,6 +380,14 @@ static void send_resource_update(struct link *manager)
+ 		total_resources->disk.total    = MAX(0, local_resources->disk.total);
+ 		total_resources->disk.largest  = MAX(0, local_resources->disk.largest);
+ 		total_resources->disk.smallest = MAX(0, local_resources->disk.smallest);
++		
++		//if workers are set to expire at some time, send the amount of time left to manager
++		if(manual_wall_time_option != 0) {
++			total_resources->time_left = worker_start_time + manual_wall_time_option - time(0);
++		}
++		else {
++			total_resources->time_left = -1;
++		}
+ 	}
+ 
+ 	work_queue_resources_send(manager,total_resources,stoptime);","If following above, this would be: end_time = time(0) + manual_wall_time_option, which is simpler. Also, make the check manual_wall_time_option > 0, otherwise negative times would terminate the worker right away.",This should be `time(0) - manual_wall_time_option`.
+4853,"@@ -116,6 +116,10 @@ func (err wrappedFatalError) Cause() error {
+ 	return err.error
+ }
+ 
++func (err wrappedFatalError) Unwrap() error {
++	return err.error
++}
++
+ // IsFatalError returns true if err conforms to the Fatal interface
+ // and calling the Fatal method returns true.
+ func IsFatalError(err error) (isFatal bool) {",If we aren't using `errors.Is` we don't need the `Unwrap` as we have `Cause` which is what pkg/errors uses.,Why do we need this?
+4854,"@@ -4,8 +4,9 @@ import (
+ 	""io/ioutil""
+ 	""os""
+ 
++	""k8s.io/klog""
++
+ 	""github.com/kubeedge/beehive/pkg/common/config""
+-	""github.com/kubeedge/beehive/pkg/common/log""
+ 	""github.com/kubeedge/beehive/pkg/core""
+ 	""github.com/kubeedge/beehive/pkg/core/context""
+ 	""github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/channelq""",redundant empty line,nit: remove empty line
+4855,"@@ -150,6 +150,7 @@ bool ConfigManager::load()
+ 	boolean[ONLINE_OFFLINE_CHARLIST] = getGlobalBoolean(L, ""showOnlineStatusInCharlist"", false);
+ 	boolean[YELL_ALLOW_PREMIUM] = getGlobalBoolean(L, ""yellAlwaysAllowPremium"", false);
+ 	boolean[FORCE_MONSTERTYPE_LOAD] = getGlobalBoolean(L, ""forceMonsterTypesOnLoad"", true);
++	boolean[HOUSE_OWNED_BY_ACCOUNT] = getGlobalBoolean(L, ""houseOwnedByAccount"", false);
+ 
+ 	string[DEFAULT_PRIORITY] = getGlobalString(L, ""defaultPriority"", ""high"");
+ 	string[SERVER_NAME] = getGlobalString(L, ""serverName"", """");",The config.lua.dist still shows `houseAccountOwner`,This should be false by default.
+4856,"@@ -11,7 +11,6 @@
+ 
+ namespace Sonata\MediaBundle\Command;
+ 
+-use Sonata\ClassificationBundle\Model\ContextInterface;
+ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+ use Symfony\Component\Console\Input\InputInterface;
+ use Symfony\Component\Console\Output\OutputInterface;",I think we can leave this import and use non FQNs in the code.,Why is this removed?
+4857,"@@ -1654,9 +1654,10 @@ class TargetLocator {
+    *     when the driver has changed focus to the specified window.
+    */
+   window(nameOrHandle) {
++    let paramName = this.driver_.getExecutor().w3c ? 'handle' : 'name';
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter(paramName, nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ",I'd rather just send the parameter twice than break encapsulation here. There's already precedence with webelement IDs,Nit: `nameOrHandle` 
+4858,"@@ -79,11 +79,9 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
+         {
+             Log.LogMessage(MessageImportance.Low, $""START pushing items to feed"");
+-            Random rnd = new Random();
+ 
+             try
+             {
+-
+                 bool result = await PushAsync(items.ToList(), allowOverwrite);
+                 return result;
+             }",We should probably exit early if there are no items in the list.,Why did you remove t
+4859,"@@ -16,7 +16,7 @@ def _private_func3(param1):  # [missing-raises-doc]
+     raise Exception('Example')
+ 
+ 
+-def public_func1(param1):  # [missing-param-doc, missing-type-doc]
++def public_func1(param1):  # [missing-any-param-doc]
+     """"""This is a test docstring without params""""""
+     print(param1)
+ ",As we can't use old names we should warn in whats new for 2.12 that this can happen.,This should be `miss
+4860,"@@ -0,0 +1,13 @@
++// +build testbincover
++
++package main
++
++import (
++	""testing""
++
++	""github.com/confluentinc/bincover""
++)
++
++func TestBincoverRunMain(t *testing.T) {
++	bincover.RunTest(main)
++}","good job finding this package, I hope it's actively maintained",This file is missing the license header.
+4861,"@@ -82,7 +82,6 @@ void getDevicePCIBusNum(int deviceID, char* pciBusID) {
+ 
+ int main() {
+     unsetenv(""HIP_VISIBLE_DEVICES"");
+-    unsetenv(""CUDA_VISIBLE_DEVICES"");
+ 
+     std::vector<std::string> devPCINum;
+     char pciBusID[100];",same changes as in hipEnvVar.cpp,Why is this removed?
+4862,"@@ -1,6 +1,11 @@
++#ifndef _POSIX_C_SOURCE
++#define _POSIX_C_SOURCE 200809L
++#endif
++#include <string.h>
+ #include <assert.h>
+ #include <libinput.h>
+ #include <stdlib.h>
++#include <wayland-util.h>
+ #include <wlr/backend/session.h>
+ #include <wlr/interfaces/wlr_tablet_tool.h>
+ #include <wlr/types/wlr_input_device.h>",NULL check should be before this line,Why is this needed?
+4863,"@@ -177,7 +177,7 @@ public class WildernessLocationsPlugin extends Plugin
+ 			|| (this.pvpWorld && WorldType.isAllPvpWorld(client.getWorldType())));
+ 		if (renderLocation)
+ 		{
+-			if (client.getLocalPlayer().getWorldLocation() != worldPoint)
++			if (client.getLocalPlayer() != null && client.getLocalPlayer().getWorldLocation() != worldPoint)
+ 			{
+ 				locationString = WorldLocation.location(client.getLocalPlayer().getWorldLocation());
+ 				worldPoint = client.getLocalPlayer().getWorldLocation();","Seems like client.getlocalplayer is being called a lot, would it be worth it to do final Player player = client.getlocalplayer?",Why is this null check needed?
+4864,"@@ -116,9 +116,9 @@ ex_expr::exp_return_type ex_comp_clause::processNulls(char *op_data[],
+        // then move boolean unknown value to result and return.
+        if (getOperand(i)->getNullFlag() && (!op_data[i])) // missing value 
+    	{
+-   	  // move null value to result.
+-   	  *(Lng32 *)op_data[2 * MAX_OPERANDS] = -1;
+-   	  return ex_expr::EXPR_NULL;
++            // move null value to result.
++            *(Lng32 *)op_data[2 * MAX_OPERANDS] = 0;
++            return ex_expr::EXPR_NULL;
+    	}
+      }
+    ","this change is not correct. 3-valued boolean logic requires that comparison of null to another value during intermediate operations should make the result null and not false. The place where null becomes false is at the very end of that expression. As an example, with the changed logic, this expression will return incorrect result. select * from t where not (a = 1); if a is null, the where predicate will become true which is incorrect. With the original 3-valued result, the where pred will become false and not return any result.",Why this change?
+4865,"@@ -95,6 +95,7 @@ func NewReplacer(r *http.Request, rr *ResponseRecorder, emptyValue string) Repla
+ 				dir, _ := path.Split(r.URL.Path)
+ 				return dir
+ 			}(),
++			""{locale}"": r.Header.Get(""Detected-Locale""),
+ 		},
+ 		emptyValue: emptyValue,
+ 	}","This can already be done with `{>Detected-Locale}`, why make another way to do it?",I think this sho
+4866,"@@ -2376,10 +2376,11 @@ public class DatasetPage implements java.io.Serializable {
+                 requestContext.execute(""PF('selectFilesForRestrict').show()"");           
+             return """";
+         } else {           
+-            boolean validSelection = false;
++            boolean validSelection = true;
+             for (FileMetadata fmd : selectedFiles) {
+-                if (!fmd.isRestricted() ){
+-                    validSelection = true;
++                if (fmd.isRestricted() == true) {
++                    validSelection = false;
++                    break;
+                 }
+             }
+             if (!validSelection) {",These changes just match the logic update in the next method that was done previously - to assure the whole set of files is valid rather than that there is at least one that would be changed.,I think this sho
+4867,"@@ -30,6 +30,11 @@ func (s *server) bytesUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 		jsonhttp.InternalServerError(w, ""cannot get or create tag"")
+ 		return
+ 	}
++	w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))
++	w.WriteHeader(http.StatusContinue)
++	if f, ok := w.(http.Flusher); ok {
++		f.Flush()
++	}
+ 
+ 	// Add the tag to the context
+ 	ctx := sctx.SetTag(r.Context(), tag)",Why setting the status to Continue as at the end it is written OK? Status should be written only once.,Why do we need t
+4868,"@@ -140,10 +140,10 @@ func deps() {
+ 		cmd(""go get -u github.com/pmezard/go-difflib/difflib""),
+ 		cmd(""./scripts/install-rust-proofs.sh""),
+ 		cmd(""./scripts/install-bls-signatures.sh""),
++		cmd(""./proofs/bin/paramcache""),
++		cmd(""./scripts/copy-groth-params.sh""),
+ 	}
+ 
+-	cmds = append(cmds, hydrateParamCache()...)
+-
+ 	for _, c := range cmds {
+ 		runCmd(c)
+ 	}","Howdy! You'll want to do this same thing (replace `hydrateParamCache` with `proofs/bin/paramcache` and then do the copy) in `smartdeps`, too.",Why is this removed?
+4869,"@@ -46,6 +46,16 @@ import (
+ 
+ // CmdSnaphotCreateOptions holds the options for snapshot
+ // create command
++var (
++	snapshotCreateCommandHelpText = `
++	usage: mayactl snapshot create --volname <vol> --snapname <snap>
++	
++	this command creates a volume snapshot 
++	
++	note: the volume should exit before itself
++	`
++)
++
+ type CmdSnaphotCreateOptions struct {
+ 	volName  string
+ 	snapName string",nit : Remove the extra lines,I think this should 
+4870,"@@ -184,6 +184,7 @@ type Options struct {
+ 	ServerName            string        `json:""server_name""`
+ 	Host                  string        `json:""addr""`
+ 	Port                  int           `json:""port""`
++	DontListen            bool          `json:""dont_listen""`
+ 	ClientAdvertise       string        `json:""-""`
+ 	Trace                 bool          `json:""-""`
+ 	Debug                 bool          `json:""-""`","Instead of adding a new option, I wonder if we could decide on a port that would disable listening. For instance, port set to 0 means that we use default port 4222. Setting to -1 means that we let OS pick a random free port. We could say anything negative lower than -1 (say -2) means disabled? You don't have to update the PR for that, just wondering if that would be better or not and let's see what others think.",Why do we need this?
+4871,"@@ -2511,6 +2511,9 @@ class ThriftRequestHandler(object):
+             if report.metadata:
+                 return report.metadata.get(""analyzer"", {}).get(""name"")
+ 
++            if report.check_name.startswith('clang-diagnostic-'):
++                return 'clang-tidy'
++
+         # Processing PList files.
+         _, _, report_files = next(os.walk(report_dir), ([], [], []))
+         all_report_checkers = set()",Should we add some default case if non of the above return some analyzer name? Something like `unknown analyzer`?,I don't think this i
+4872,"@@ -115,7 +115,7 @@ module Faker
+           keywords << :special_characters if legacy_special_characters != NOT_GIVEN
+         end
+ 
+-        min_alpha = mix_case ? 2 : 0
++        min_alpha = mix_case && min_length > 1 ? 2 : 0
+         temp = Lorem.characters(number: min_length, min_alpha: min_alpha)
+         diff_length = max_length - min_length
+ ",Nvm. The original version is best... *hides from the angry rubocop*,I think this should be `min_length > 1 ? 1 : 0`
+4873,"@@ -100,14 +100,13 @@ func (c *client) Call(
+ 		return nil, err
+ 	}
+ 
+-	body, cleanup, err := marshal(req.Encoding, protoReq)
++	body, err := marshal(req.Encoding, protoReq)
+ 	if err != nil {
+ 		return nil, yarpcencoding.RequestBodyEncodeError(req, err)
+ 	}
+-	defer cleanup()
+ 
+ 	reqBuf := &yarpc.Buffer{}
+-	if _, err := reqBuf.Write(body); err != nil {
++	if _, err := reqBuf.Write(body.Bytes()); err != nil {
+ 		return nil, err
+ 	}
+ ","we can drop this and use the returned body above, right?",Why do we need to do this?
+4874,"@@ -142,12 +142,12 @@ module Travis
+ 
+             def install
+               sh.if ""$(rvm use $(travis_internal_ruby) do ruby -e \""puts RUBY_VERSION\"") = 1.9*"" do
+-                cmd(dpl_install_command(WANT_18), echo: false, assert: !allow_failure, timing: true)
++                cmd(dpl_install_command(WANT_18), echo: true, assert: !allow_failure, timing: true)
+               end
+               sh.else do
+-                cmd(dpl_install_command, echo: false, assert: !allow_failure, timing: true)
++                cmd(dpl_install_command, echo: true, assert: !allow_failure, timing: true)
+               end
+-              sh.cmd ""rm -f dpl-*.gem"", echo: false, assert: false, timing: false
++              sh.cmd ""rm -f $TRAVIS_BUILD_DIR/dpl-*.gem"", echo: false, assert: false, timing: false
+             end
+ 
+             def run_command(assert = !allow_failure)",Is echoing enabled on purpose here or it's a remainder of your tests?,Why is this change needed?
+4875,"@@ -98,6 +98,7 @@ module Bolt
+     end
+ 
+     def run_command(targets, command, options = {}, &callback)
++      @logger.notice(options['_description']) if options.key?('_description')
+       @logger.info(""Starting command run '#{command}' on #{targets.map(&:uri)}"")
+       notify = proc { |event| @notifier.notify(callback, event) if callback }
+       options = { '_run_as' => run_as }.merge(options) if run_as",I think this should just be worked into the next message and follow the verbosity of it.,Should this be `@logger.info`?
+4876,"@@ -106,6 +106,7 @@ export const selectors = {
+ 	 *
+ 	 * @since 1.14.0
+ 	 *
++	 * @param {Object} urlParams URL parameters to be passed to the query.
+ 	 * @return {(string|undefined)} AdSense account site overview URL (or `undefined` if not loaded).
+ 	 */
+ 	getServiceAccountSiteURL: createRegistrySelector( ( select ) => () => {",This also needs to be reverted.,`urlParams` -> `urlParams`
+4877,"@@ -105,6 +105,13 @@ const (
+ 	TLFJournalBackgroundWorkEnabled
+ )
+ 
++type tlfJournalPauseType int
++
++const (
++	journalPausedFromConflict tlfJournalPauseType = 1 << iota
++	journalPausedFromSignal
++)
++
+ func (bws TLFJournalBackgroundWorkStatus) String() string {
+ 	switch bws {
+ 	case TLFJournalBackgroundWorkEnabled:","`FromCommand` seems to fit better, since with my suggestion below, all pauses will raise a signal on `needPause`. Also maybe the format `journalPauseConflict` and `journalPauseCommand` is better, since the journal isn't necessarily paused yet once we raise a pause signal.",nit: `journalPausedFromCon
+4878,"@@ -236,7 +236,7 @@ func IsServiceNonRetryableError(err error) bool {
+ // IsServiceNonRetryableErrorGRPC checks if the error is a non retryable error.
+ func IsServiceNonRetryableErrorGRPC(err error) bool {
+ 	if err == context.DeadlineExceeded {
+-		return true
++		return false
+ 	}
+ 
+ 	if st, ok := status.FromError(err); ok {",This is fix from another PR #120.,Why is this change needed?
+4879,"@@ -20,7 +20,9 @@ class MultiInterface(Interface):
+ 
+     datatype = 'multitabular'
+ 
+-    subtypes = ['dataframe', 'dictionary', 'array', 'dask']
++    subtypes = ['dictionary', 'dataframe', 'array', 'dask']
++
++    multi = True
+ 
+     @classmethod
+     def init(cls, eltype, data, kdims, vdims):","I *think* it makes sense to try the more general dictionary (i.e standard python literals) format first. Might be other implications I haven't figured out yet. Then again, ``MultiInterface`` is pretty new so it probably doesn't matter wrt backwards compatibility.",Why is this necessary?
+4880,"@@ -32,9 +32,13 @@ class FixMediaContextCommand extends ContainerAwareCommand
+      */
+     public function execute(InputInterface $input, OutputInterface $output)
+     {
++        if (!$this->getContainer()->has('sonata.media.manager.category')) {
++            throw new \LogicException('The classification feature is disabled.');
++        }
++
+         $pool = $this->getContainer()->get('sonata.media.pool');
+         $contextManager = $this->getContainer()->get('sonata.classification.manager.context');
+-        $cateoryManager = $this->getContainer()->get('sonata.classification.manager.category');
++        $categoryManager = $this->getContainer()->get('sonata.media.manager.category');
+ 
+         foreach ($pool->getContexts() as $context => $contextAttrs) {
+             /** @var ContextInterface $defaultContext */",lol that variable name,Shouldn't this be `if (!$this->has('sonata.classification.manager.category'))`?
+4881,"@@ -31,8 +31,8 @@ const (
+ 	ChainFilterForward = ChainNamePrefix + ""-FORWARD""
+ 	ChainFilterOutput  = ChainNamePrefix + ""-OUTPUT""
+ 
+-	ChainFailsafeIn  = ChainNamePrefix + ""-FAILSAFE-IN""
+-	ChainFailsafeOut = ChainNamePrefix + ""-FAILSAFE-OUT""
++	ChainFailsafeIn  = ChainNamePrefix + ""-failsafe-in""
++	ChainFailsafeOut = ChainNamePrefix + ""-failsafe-out""
+ 
+ 	ChainNATPrerouting  = ChainNamePrefix + ""-PREROUTING""
+ 	ChainNATPostrouting = ChainNamePrefix + ""-POSTROUTING""",Upper case is reserved for our versions of top-level chains i.e. the `FORWARD` chain jumps to `cali-FORWARD`.,Why did you change this?
+4882,"@@ -3373,10 +3373,14 @@ void nano::json_handler::receive ()
+ 					}
+ 					if (!ec)
+ 					{
++						// Representative is only used by receive_action when opening accounts
++						// Set a wallet default representative for new accounts
++						nano::account representative (wallet->store.representative (node.wallets.tx_begin_read ()));
++
+ 						bool generate_work (work == 0); // Disable work generation if ""work"" option is provided
+ 						auto response_a (response);
+ 						// clang-format off
+-						wallet->receive_async(std::move(block), account, node.network_params.ledger.genesis_amount, [response_a](std::shared_ptr<nano::block> block_a) {
++						wallet->receive_async(std::move(block), representative, node.network_params.ledger.genesis_amount, [response_a](std::shared_ptr<nano::block> block_a) {
+ 							if (block_a != nullptr)
+ 							{
+ 								boost::property_tree::ptree response_l;",json_handler::receive () has already started a read tx that can be used here right?,Why do we need to set a representative here?
+4883,"@@ -84,6 +84,9 @@ describe( 'CompatibilityChecks', () => {
+ 	it( 'should make API requests to ""setup-checks, health-checks and AMP Project test URL', async () => {
+ 		const token = 'test-token-value';
+ 
++		global._googlesitekitBaseData = global._googlesitekitBaseData || {};
++		global._googlesitekitBaseData[ 'isWP5.0+' ] = true;
++
+ 		// Mock request to setup-tag.
+ 		fetchMock.postOnce(
+ 			/^\/google-site-kit\/v1\/core\/site\/data\/setup-tag/,",We should add the definition to `.storybook/config.js` as well.,Why do we need this?
+4884,"@@ -96,7 +96,7 @@ ex_expr::exp_return_type ex_branch_clause::eval(char *op_data[],
+   switch (getOperType())
+     {
+     case ITM_AND:
+-      if (*(Lng32 *)op_data[1] == 0)
++      if (*(Lng32 *)op_data[1] == 0 || *(Lng32 *)op_data[1] == -1)  // null treated as false
+ 	{
+ 	  *(Lng32 *)op_data[0] = 0;
+ 	  setNextClause(branch_clause);","I don't believe this is correct. Consider the query, ""select a from t1x where not(b = 0 and c = 0)"". When B and C are both null, both equal predicates evaluate to null, and the AND evaluates to null. The NOT then also evaluates to null. The WHERE clause should treat the result of the NOT as false. But with this fix, the result of the AND will be false, making the NOT true. There needs to be three cases here for ITM_AND: If the first operand is false, then the AND is false. If the first operand is true, then the result is the second operand. If the first operand is null, then if the second operand is false, the result is false otherwise the result is null. Similar logic needs to be added to the ITM_OR case.",Shouldn't this be `||`?
+4885,"@@ -72,7 +72,12 @@ final class IntArrayDocIdSet extends DocIdSet {
+ 
+     @Override
+     public int advance(int target) throws IOException {
+-      i = Arrays.binarySearch(docs, i + 1, length, target);
++      int bound = 1;
++      int offset = Math.max(0, i);
++      while(offset + bound < length && docs[offset + bound] < target) {
++        bound *= 2;
++      }
++      i = Arrays.binarySearch(docs, offset + bound / 2, Math.min(offset + bound, length), target);
+       if (i < 0) {
+         i = -1 - i;
+       }","`bound/2` is generally the previous bound that we tested, except when `bound` is equal to 1. It won't break in that case since callers are not supposed to call advance on a target that is lte the current doc ID, but this might still make room for bugs?",I think this should be 
+4886,"@@ -65,8 +65,12 @@ function Admin(db, topology, promiseLibrary) {
+  * @method
+  * @param {object} command The command hash
+  * @param {object} [options] Optional settings.
+- * @param {(ReadPreference|string)} [options.readPreference] The preferred read preference (ReadPreference.PRIMARY, ReadPreference.PRIMARY_PREFERRED, ReadPreference.SECONDARY, ReadPreference.SECONDARY_PREFERRED, ReadPreference.NEAREST).
+- * @param {number} [options.maxTimeMS] Number of milliseconds to wait before aborting the query.
++ * @param {boolean} [options.raw=false] Return a raw nodejs Buffer instead of deserializing BSON
++ * @param {boolean} [options.fullResult=false] Return the full envelope instead of just the result document
++ * @param {boolean} [options.serializeFunctions=false] Specify if functions on an object should be serialized
++ * @param {boolean} [options.ignoreUndefined=false] Specify if the BSON serializer should ignore undefined fields
++ * @param {ReadPreference|string} [options.readPreference] Specify read preference if command supports it
++ * @param {ClientSession} [options.session] Session to use for the operation
+  * @param {Admin~resultCallback} [callback] The command result callback
+  * @return {Promise} returns Promise if no callback passed
+  */","Can we remove `raw`, `fullResult`, and `serializeFunctions`?",Shouldn't this be `opti
+4887,"@@ -110,6 +110,8 @@ type (
+ 		TLS RootTLS `yaml:""tls""`
+ 		// Metrics is the metrics subsystem configuration
+ 		Metrics *Metrics `yaml:""metrics""`
++		// Settings for authentication and authorization
++		Security Security `yaml:""security""`
+ 	}
+ 
+ 	// RootTLS contains all TLS settings for the Temporal server","[Nit] I don't have a proposed suggestion, but security seems too generic of a name here.",Why do we need this?
+4888,"@@ -0,0 +1,19 @@
++const config = require('../lib/config')
++const util = require('../lib/util')
++const path = require('path')
++const fs = require('fs-extra')
++
++const createDist = (options) => {
++  config.update(options)
++  config.buildConfig = 'Release'
++
++  let cmdOptions = config.defaultOptions
++  const args = util.buildArgsToString(config.buildArgs())
++
++  fs.removeSync(path.join(config.outputDir, 'dist'))
++  util.run('gn', ['gen', config.outputDir, '--args=""' + args + '""'], cmdOptions)
++  util.run('ninja', ['-C', config.outputDir, 'create_dist'], cmdOptions)
++}
++
++module.exports = createDist
++","do we need to force a buildConfig here? I know it's in muon, but that might actually be making things harder for people",Why is this necessary?
+4889,"@@ -302,6 +302,10 @@ bool Client::Process() {
+ 		}
+ 
+ 		if (AutoFireEnabled()) {
++			if (this->GetTarget() == this) {
++				this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++				auto_fire = false;
++			}
+ 			EQ::ItemInstance *ranged = GetInv().GetItem(EQ::invslot::slotRange);
+ 			if (ranged)
+ 			{",Shouldn't need this-> here.,I don't think this is 
+4890,"@@ -1,4 +1,3 @@
+-# Copyright (c) OpenMMLab. All rights reserved.
+ import math
+ 
+ import torch",Why delete this?,# Copyright (c) Micros
+4891,"@@ -10,6 +10,17 @@ export function extend(obj, props) {
+ 	return obj;
+ }
+ 
++/** Invoke or update a ref, depending on whether it is a function or object ref.
++ *  @param {object|function} [ref=null]
++ *  @param {any} [value]
++ */
++export function applyRef(ref, value) {
++	if (ref!=null) {
++		if (typeof ref=='function') ref(value);
++		else ref.current = value;
++	}
++}
++
+ /**
+  * Call a function asynchronously, as soon as possible. Makes
+  * use of HTML Promise to schedule the callback if available,","This line is here to be compatible with the current way `refs` work, right?",I don't think you need
+4892,"@@ -10,7 +10,11 @@
+         <strong><%= name %>
+       </td>
+       <td>
+-        <%= value %>
++        <% if value.class == BigDecimal %>
++          <%= number_to_currency(value) %>
++        <% else %>
++          <%= value %>
++        <% end %>
+       </td>
+     </tr>
+   <%- end %>","Hmm, I wonder if we can safely assume all decimals should be displayed as $$...ok for now I suppose.",Shouldn't this be `value.is_a?(Number)`?
+4893,"@@ -443,4 +443,17 @@ describe RSpec::Core::Example, :parent_metadata => 'sample' do
+       expect(ex.description).to match(/contains the example/)
+     end
+   end
++
++  describe ""setting the current example"" do
++    it ""sets RSpec.current_example to the example that is currently running"" do
++      group = RSpec::Core::ExampleGroup.describe(""an example group"")
++
++      current_examples = []
++      example1 = group.example(""example 1"") { current_examples << RSpec.current_example }
++      example2 = group.example(""example 2"") { current_examples << RSpec.current_example }
++
++      group.run
++      expect(current_examples).to eq([example1, example2])
++    end
++  end
+ end",Good spec :). Very clear and easy to see what it's doing.,I'm not sure if this is the best way to 
+4894,"@@ -0,0 +1,12 @@
++class ExploreController < ApplicationController
++  def orgs
++    @newest_orgs = Organization.active.order('created_at DESC').limit(3)
++    @most_active_orgs = OrgThirtyDayActivity.most_active_orgs
++    @stats_by_sector = OrgStatsBySector.recent
++    @org_by_30_day_commits = OrgThirtyDayActivity.send(""filter_#{params[:filter]}_orgs"")
++  end
++
++  def orgs_by_thirty_day_commit_volume
++    @org_by_30_day_commits = OrgThirtyDayActivity.send(""filter_#{params[:filter]}_orgs"")
++  end
++end",Shouldn't we need to sanitize the `params[:filter]` from a defined expected values?,I think this should be `@org_by_30_day_c
+4895,"@@ -10,6 +10,18 @@ from dagster.core.launcher.base import LaunchRunContext, RunLauncher
+ from dagster.grpc.types import ExecuteRunArgs
+ from dagster.serdes import ConfigurableClass, serialize_dagster_namedtuple
+ from dagster.utils.backcompat import experimental
++from dagster.utils.backoff import backoff
++
++
++# The ECS API is eventually consistent:
++# https://docs.aws.amazon.com/AmazonECS/latest/APIReference/API_RunTask.html
++# describe_tasks might initially return nothing even if a task exists.
++class EcsEventualConsistencyTimeout(Exception):
++    pass
++
++
++# 9 retries polls for up to 51.1 seconds with exponential backoff.
++BACKOFF_RETRIES = 9
+ 
+ 
+ @dataclass","Should we bite the bullet and poll for the full 5 minutes that AWS recommends? If we do that, we'll probably want to leave some kind of breadcrumb in the event log to let users know why it's taking so long to launch.",I'm not sure if this is the best way to 
+4896,"@@ -36,7 +36,7 @@ import java.util.concurrent.TimeUnit;
+ import java.util.function.Predicate;
+ import java.util.function.Supplier;
+ 
+-import com.google.common.base.Objects;
++import com.google.common.base.MoreObjects;
+ import org.apache.solr.common.SolrException;
+ import org.apache.solr.common.cloud.Aliases;
+ import org.apache.solr.common.params.CommonParams;",Guava changed `Objects` -> `MoreObjects`,Why is this change needed?
+4897,"@@ -20,8 +20,11 @@
+ 
+ package mocks
+ 
+-import mock ""github.com/stretchr/testify/mock""
+-import persistence ""github.com/temporalio/temporal/common/persistence""
++import (
++	mock ""github.com/stretchr/testify/mock""
++
++	persistence ""github.com/temporalio/temporal/common/persistence""
++)
+ 
+ // MetadataManager is an autogenerated mock type for the MetadataManager type
+ type MetadataManager struct {",All these hand generated mocks can be deleted. I think we already moved everything to gomocks.,Why this change?
+4898,"@@ -1251,7 +1251,7 @@ Document.prototype.inspect = function (options) {
+  */
+ 
+ Document.prototype.equals = function (doc) {
+-  return this.get('_id') === doc.get('_id');
++  return this.get('_id').equals(doc.get('_id'));
+ };
+ 
+ /**",what about string/number etc _ids? this will fail.,Why is this change needed?
+4899,"@@ -682,7 +682,7 @@ func TestRemoteMachineSetReconcile(t *testing.T) {
+ 								t.Errorf(""machineset %v has unexpected labels:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Labels, rMS.Labels)
+ 							}
+ 							if !reflect.DeepEqual(eMS.ObjectMeta.Annotations, rMS.ObjectMeta.Annotations) {
+-								t.Errorf(""machineset %v has unexpected annotations:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Labels, rMS.Labels)
++								t.Errorf(""machineset %v has unexpected annotations:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Annotations, rMS.Annotations)
+ 							}
+ 							if !reflect.DeepEqual(eMS.Spec.Template.Spec.Labels, rMS.Spec.Template.Spec.Labels) {
+ 								t.Errorf(""machineset %v machinespec has unexpected labels:\nexpected: %v\nactual: %v"", eMS.Name, eMS.Spec.Template.Spec.Labels, rMS.Spec.Template.Spec.Labels)",Looks like the test had a bug prior to this.,Why did this change?
+4900,"@@ -36,7 +36,17 @@ const env = envFromArgs(process.argv);
+ const profilePath = profileFromArgs(process.argv);
+ const isDebugMode = !!process.argv && process.argv.indexOf('--debug') >= 0;
+ 
+-const wrapper = new ElectronAppWrapper(electronApp, env, profilePath, isDebugMode);
++if (env === 'dev' && process.platform === 'win32') {
++	electronApp.setAsDefaultProtocolClient('joplin', process.execPath, [
++		resolve(process.argv[1])
++	]);
++} else {
++	electronApp.setAsDefaultProtocolClient('joplin');
++}
++
++const initialUrl = process.argv.find((arg) => arg.startsWith('joplin://'));
++
++const wrapper = new ElectronAppWrapper(electronApp, env, profilePath, isDebugMode, initialUrl);
+ 
+ initBridge(wrapper);
+ ",Should start with joplin://x-callback-url/. Also maybe create a helper function to check if a url is valid?,I'm not sure if this is the best way to do this. I'm not sure what the best way to do this is.
+4901,"@@ -3,7 +3,7 @@ export default [
+     {
+         created_at: '2015-09-11T09:44:30.805Z',
+         created_by: 1,
+-        id: 1,
++        id: 7,
+         key: 'title',
+         type: 'blog',
+         updated_at: '2015-10-04T16:26:05.195Z',",PR works great. Just out of curiosity: why all the id changes?  ,Why did you change this?
+4902,"@@ -56,6 +56,14 @@ struct flb_service_config service_configs[] = {
+      FLB_CONF_TYPE_INT,
+      offsetof(struct flb_config, grace)},
+ 
++    {FLB_CONF_STR_BACKOFF_BASE,
++     FLB_CONF_TYPE_INT,
++     offsetof(struct flb_config, backoff_base)},
++
++    {FLB_CONF_STR_BACKOFF_CAP,
++     FLB_CONF_TYPE_INT,
++     offsetof(struct flb_config, backoff_cap)},
++
+     {FLB_CONF_STR_DAEMON,
+      FLB_CONF_TYPE_BOOL,
+      offsetof(struct flb_config, daemon)},","config map first value is wrong, it aims to define the ""value type"", that value will lead to an undefined behavior.",Why do we need this?
+4903,"@@ -13,7 +13,7 @@
+ // limitations under the License.
+ 
+ // Package fileblob provides a blob implementation that uses the filesystem.
+-// Use OpenBucket to construct a blob.Bucket.
++// Use OpenBucket to construct a *blob.Bucket.
+ //
+ // Blob keys are escaped before being used as filenames, and filenames are
+ // unescaped when they are passed back as blob keys during List. The escape","This doesn't make sense. The thing being constructed is a blob.Bucket. ""Constructing"" the pointer is trivial.",Why is this change needed?
+4904,"@@ -2,7 +2,9 @@
+ # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE
+ 
+ import functools
++import optparse  # pylint: disable=deprecated-module
+ 
++from pylint.lint import PyLinter
+ from pylint.testutils.checker_test_case import CheckerTestCase
+ 
+ ",Outch. A configuration/parsing refactor is on the radar but this seems more pressing.,Why do we need to disable this?
+4905,"@@ -18,7 +18,9 @@ export default Component.extend({
+     stats: null,
+     chartData: null,
+     chartOptions: null,
+-    startDateLabel: '',
++    startDateLabel: computed('membersStats.days', function () {
++        return moment(new Date()).add(-this.membersStats.days + 1, 'days').format(DATE_FORMAT);
++    }),
+ 
+     selectedRange: computed('membersStats.days', function () {
+         const availableRanges = this.availableRanges;","Unfortunately this won't work when the ""All time"" range is chosen because `memberStats.days` will be `""all-time""` and not a number. What you could do instead is to use `memberStats.stats` as the dependent key and use `Object.keys(memberStats.stats.total_on_date)[0]` to grab the first date in the range and build the label from there.",I don't think we need the `+ 1`
+4906,"@@ -1,10 +1,11 @@
+ require ""rails_helper""
+ 
+-feature ""subscriber views video trail"" do
++feature ""user views video trail"" do
+   scenario ""and marks a video as complete"" do
+     trail = create_video_trail
+ 
+-    sign_in_as_user_with_subscription
++    sign_in
++    click_on I18n.t(""pages.landing.hero_call_to_action"")
+     click_on trail.name
+ 
+     within trail_steps_list do",Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer single-quoted strings in
+4907,"@@ -206,7 +206,6 @@ describe('Configure Options', function() {
+       iframe.src = '/test/mock/frames/context.html';
+       iframe.onload = function() {
+         axe.configure(config);
+-        iframe.contentWindow.axe.configure(config);
+ 
+         axe.run(
+           '#target',","We need this left in as `axe.configure` is for the top-level page `axe` and we still need to configure the axe script inside the iframe as well (so both have to be configured),",Why was this removed?
+4908,"@@ -26,6 +26,11 @@ namespace AutoRest.Swagger.Validation
+         /// </summary>
+         public override ValidationCategory ValidationCategory => ValidationCategory.RPCViolation;
+ 
++        /// <summary>
++        /// What kind of change implementing this rule can cause.
++        /// </summary>
++        public override ValidationChangesImpact ValidationChangesImpact => ValidationChangesImpact.ServiceImpactingChanges;
++
+         public override IEnumerable<ValidationMessage> GetValidationMessages(Dictionary<string, Dictionary<string, Operation>> entity, RuleContext context)
+         {
+             // get all operation objects that are either of get or post type","is this rule serviceimpacting? I'm thinking it's mostly around the modeling of pageable in the swagger, thoughts?",I don't think this is the right place for this. This should be in the `ValidationRules` class.
+4909,"@@ -141,7 +141,7 @@ func (ts *TriggerStatus) MarkDependencyNotConfigured() {
+ 		""DependencyNotConfigured"", ""Dependency has not yet been reconciled."")
+ }
+ 
+-func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.KResource) {
++func (ts *TriggerStatus) PropagateDependencyStatus(ks *duckv1.Source) {
+ 	kc := ks.Status.GetCondition(apis.ConditionReady)
+ 	if kc == nil {
+ 		ts.MarkDependencyNotConfigured()","same here, replace `ks` and `kc` to something more related to Source.",Why is this change needed?
+4910,"@@ -0,0 +1,19 @@
++using System;
++using System.Collections.Generic;
++using System.Globalization;
++
++namespace MvvmCross.Platform.Converters
++{
++    public class MvxDictionaryValueConverter<TKey, TValue> : MvxValueConverter<TKey, TValue>
++    {
++        protected override TValue Convert(TKey value, Type targetType, object parameter, CultureInfo culture)
++        {
++            if (parameter is Dictionary<TKey, TValue> dict)
++            {
++                TValue x = dict[value];
++                return x;
++            }
++            throw new ArgumentException($""Could not cast {parameter.GetType().Name} to {typeof(Dictionary<TKey, TValue>).Name}"");
++        }
++    }
++}","We should probably ask here if `dict` contains a key with the appropiate value, and leave a trace in case it doesn't, to make it easier to debug for developers.",I don't think this is the right place for this converter. It should be in the `MvvmCross.Platf
+4911,"@@ -147,6 +147,11 @@ module Beaker
+                             }                                
+           } }
+           let(:subcommand_file) {@subcommand_file || {:level => 'fifth'}}
++          let(:homedir_file) {@homedir_file || {:level => 'sixth',
++                                                :ssh => {
++                                                    :auth_methods => 'auth_home_123'
++                                                }
++          }}
+           let(:presets) { {:level => 'lowest',
+                             :ssh => {
+                               :config => 'config123',",this should only be indented 2 spaces,I think this should be `auth_home_123`
+4912,"@@ -84,7 +84,10 @@ func TestLoadEnvConfig_Creds(t *testing.T) {
+ 				os.Setenv(k, v)
+ 			}
+ 
+-			cfg := loadEnvConfig()
++			cfg, err := loadEnvConfig()
++			if err != nil {
++				t.Errorf(""failed to load env config, %v"", err)
++			}
+ 			if !reflect.DeepEqual(c.Val, cfg.Creds) {
+ 				t.Errorf(""expect credentials to match.\n%s"",
+ 					awstesting.SprintExpectActual(c.Val, cfg.Creds))","Nit, these Err not nils should be `t.Fatalf` not error. We want to the test to stop if this error occurs.",nit: can we use `require.NoError` here?
+4913,"@@ -262,6 +262,10 @@ public class DatasetPage implements java.io.Serializable {
+     
+     private Boolean hasRsyncScript = false;
+     
++    private Boolean hasTabular = false;
++    
++    private Boolean downloadOriginalTracker = false;
++    
+     List<ExternalTool> configureTools = new ArrayList<>();
+     List<ExternalTool> exploreTools = new ArrayList<>();
+     Map<Long, List<ExternalTool>> configureToolsByFileId = new HashMap<>();",shouldn't every `Boolean` in this pr be `boolean`?,Why do we need this?
+4914,"@@ -619,6 +619,14 @@ class WebDriver(object):
+         else:
+             return self.execute(Command.GET_WINDOW_HANDLES)['value']
+ 
++    def minimize_window(self):
++        """"""
++        Miniimizes the current window that webdriver is using
++        """"""
++        if self.w3c:
++            command = Command.W3C_MINIMIZE_WINDOW
++            self.execute(command, {""windowHandle"": ""current""})
++
+     def maximize_window(self):
+         """"""
+         Maximizes the current window that webdriver is using",This `if` is not necessary,"This should be `self.execute(command, {"
+4915,"@@ -45,5 +45,7 @@ namespace Datadog.Trace.ClrProfiler
+         public const string GenericParameterTask = ""System.Threading.Tasks.Task`1<T>"";
+         public const string ObjectTask = ""System.Threading.Tasks.Task`1<System.Object>"";
+         public const string Int32Task = ""System.Threading.Tasks.Task`1<System.Int32>"";
++
++        public const string HttpConfigurationAction = ""System.Action`1<System.Web.Http.HttpConfiguration>"";
+     }
+ }",Are you using this anywhere? (I couldn't find it.),Why do we need this?
+4916,"@@ -250,7 +250,14 @@ func (s *Step) populate(ctx context.Context) dErr {
+ 	return err
+ }
+ 
++func (s *Step) recordStepTime(startTime time.Time) {
++	endTime := time.Now()
++	s.w.recordStepTime(s.name, startTime, endTime)
++}
++
+ func (s *Step) run(ctx context.Context) dErr {
++	startTime := time.Now()
++	defer s.recordStepTime(startTime)
+ 	impl, err := s.stepImpl()
+ 	if err != nil {
+ 		return s.wrapRunError(err)",Can be inlined,nit: `defer` is unnecessary here.
+4917,"@@ -3,6 +3,6 @@ require 'spec_helper'
+ describe Api::V1::CompletionsController, '#show' do
+   it 'returns a 401 when users are not authenticated' do
+     get :index
+-    response.code.should eq '401'
++    expect(response.code).to eq '401'
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [81/80]
+4918,"@@ -1,3 +1,4 @@
++import json
+ import warnings
+ 
+ import colander",Please use `kinto.core.utils.json`,Why do we need this?
+4919,"@@ -204,6 +204,16 @@ func (h *Handler) Provision(ctx caddy.Context) error {
+ 
+ 	// set up upstreams
+ 	for _, upstream := range h.Upstreams {
++		addr, err := caddy.ParseNetworkAddress(upstream.Dial)
++		if err != nil {
++			return err
++		}
++		if addr.PortRangeSize() != 1 {
++			h.logger.Error(""multiple addresses (upstream must map to only one address)"",
++				zap.String(""address"", upstream.Dial),
++			)
++			return fmt.Errorf(""multiple addresses (upstream must map to only one address): %v"", addr)
++		}
+ 		// create or get the host representation for this upstream
+ 		var host Host = new(upstreamHost)
+ 		existingHost, loaded := hosts.LoadOrStore(upstream.String(), host)","Since we're returning the error with the same content, we don't need to log it here; it will get bubbled up and emitted that way.",Shouldn't this be `!=`?
+4920,"@@ -0,0 +1,11 @@
++""""""Tests for the use of typing.final whenever the py-version is set < 3.8""""""
++# pylint: disable=missing-class-docstring, too-few-public-methods, missing-function-docstring, no-name-in-module
++
++from typing import final
++
++
++@final # [using-final-in-unsupported-version]
++class MyClass:
++    @final # [using-final-in-unsupported-version]
++    def my_method(self):
++        pass",What happens if someone import `typing` and thus uses `@typing.final` instead?,Why is this needed?
+4921,"@@ -76,7 +76,7 @@ def get_test_dependencies():
+     # Test dependencies exposed as extras, based on:
+     # https://stackoverflow.com/questions/29870629
+     return [
+-        ""pandas"",
++        ""pandas==0.20.0"",
+         ""pytest>=3.1"",
+         ""pytest-cov"",
+         ""pytest-benchmark>=3.1"",",Better remove this dependency altogether,I don't think we ne
+4922,"@@ -944,4 +944,7 @@ void h2o_cleanup_thread(void)
+     h2o_mem_clear_recycle(&h2o_mem_pool_allocator);
+     h2o_mem_clear_recycle(&h2o_http2_wbuf_buffer_prototype.allocator);
+     h2o_mem_clear_recycle(&h2o_socket_buffer_prototype.allocator);
++
++    extern __thread h2o_buffer_prototype_t h2o__http2client_wbuf_buffer_prototype;
++    h2o_mem_clear_recycle(&h2o__http2client_wbuf_buffer_prototype.allocator);
+ }",Could you please move the declaration to httpclient.h? I think we have a consistent pattern in declaring global variables in header files.,Why is this needed?
+4923,"@@ -61,11 +61,12 @@ public interface DataFile extends ContentFile<DataFile> {
+       ""Splittable offsets"");
+   Types.NestedField EQUALITY_IDS = optional(135, ""equality_ids"", ListType.ofRequired(136, IntegerType.get()),
+       ""Equality comparison field IDs"");
++  Types.NestedField SORT_ORDER_ID = optional(140, ""sort_order_id"", IntegerType.get(), ""Sort order ID"");
+ 
+   int PARTITION_ID = 102;
+   String PARTITION_NAME = ""partition"";
+   String PARTITION_DOC = ""Partition data tuple, schema based on the partition spec"";
+-  // NEXT ID TO ASSIGN: 140
++  // NEXT ID TO ASSIGN: 141
+ 
+   static StructType getType(StructType partitionType) {
+     // IDs start at 100 to leave room for changes to ManifestEntry",We will also need to add this to the spec.,Why do we need this
+4924,"@@ -68,15 +68,8 @@ func makeRoundCowState(b roundCowParent, hdr bookkeeping.BlockHeader, prevTimest
+ 		lookupParent: b,
+ 		commitParent: nil,
+ 		proto:        config.Consensus[hdr.CurrentProtocol],
+-		mods: ledgercore.StateDelta{
+-			Accts:         make(map[basics.Address]basics.AccountData),
+-			Txids:         make(map[transactions.Txid]basics.Round),
+-			Txleases:      make(map[ledgercore.Txlease]basics.Round),
+-			Creatables:    make(map[basics.CreatableIndex]ledgercore.ModifiedCreatable),
+-			Hdr:           &hdr,
+-			PrevTimestamp: prevTimestamp,
+-		},
+-		sdeltas: make(map[basics.Address]map[storagePtr]*storageDelta),
++		mods:         ledgercore.MakeStateDelta(&hdr, prevTimestamp),
++		sdeltas:      make(map[basics.Address]map[storagePtr]*storageDelta),
+ 	}
+ }
+ ","In startEvaluator, we have the paysetHint; we should use it to preinitialize the state delta allocation. The number of transactions and the deltas are typically growing in a linear fashion, so preallocating twice as much in the array initializer would be a good idea.",Why do we need this change?
+4925,"@@ -44,6 +44,10 @@ import java.util.List;
+  * </code>
+  */
+ public abstract class By {
++  static {
++    WebDriverException.scheduleIpHostResolving();
++  }
++
+   /**
+    * @param id The value of the ""id"" attribute to search for
+    * @return a By which locates elements by the value of the ""id"" attribute.","we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class.",Why is this static?
+4926,"@@ -54,6 +54,10 @@ namespace System.Text.Json.Serialization.Tests
+             await JsonSerializer.SerializeAsync(_memoryStream, _value);
+         }
+ 
++        [BenchmarkCategory(Categories.CoreFX, Categories.JSON)]
++        [Benchmark]
++        public string SerializeObjectProperty() => JsonSerializer.Serialize(new { Prop = (object)_value });
++
+         [GlobalCleanup]
+         public void Cleanup() => _memoryStream.Dispose();
+     }","Would it be possible to move the creation of the `new { Prop = (object)_value }` out of the benchmark? In the current version, the benchmark includes the cost of creating and serializing the object, while if possible it should be the cost of serialization only.",Why is this needed?
+4927,"@@ -23,4 +23,6 @@ return [
+     Knp\Bundle\MenuBundle\KnpMenuBundle::class => ['all' => true],
+     Translation\Bundle\TranslationBundle::class => ['all' => true],
+     Symfony\WebpackEncoreBundle\WebpackEncoreBundle::class => ['all' => true],
++    Translation\PlatformAdapter\Loco\Bridge\Symfony\TranslationAdapterLocoBundle::class => ['all' => true],
++    Http\HttplugBundle\HttplugBundle::class => ['all' => true],
+ ];",only dev and local,I'm not sure if this is the
+4928,"@@ -30,7 +30,7 @@ class DbJobsFailedJobsUpdate extends Migration
+     public function down()
+     {
+         Schema::table($this->getTableName(), function (Blueprint $table) {
+-            $table->tinyInteger('reserved')->unsigned();
++            $table->tinyInteger('reserved')->unsigned()->nullable();
+             $table->dropIndex('jobs_queue_reserved_at_index');
+         });
+ ","This should not be nullable, instead it should be `->default(0);`",Why did you change this?
+4929,"@@ -65,8 +65,8 @@ public class IcebergGenerics {
+       return this;
+     }
+ 
+-    public ScanBuilder select(String... columns) {
+-      this.columns = ImmutableList.copyOf(columns);
++    public ScanBuilder select(String... selectColumns) {
++      this.columns = ImmutableList.copyOf(selectColumns);
+       return this;
+     }
+ ",What about `selectedColumns`? I believe it is frequently used throughout the project.,`selectColumns` -> `sele
+4930,"@@ -43,6 +43,7 @@ import org.apache.solr.uninverting.UninvertingReader.Type;
+ public class TextField extends FieldType {
+   protected boolean autoGeneratePhraseQueries;
+   protected boolean enableGraphQueries;
++  protected boolean synonymBoostByPayload;
+   protected SolrQueryParserBase.SynonymQueryStyle synonymQueryStyle;
+ 
+   /**",I thought we switched the approach from a payload to boost attribute? Besides; it's not clear we need this toggle at all since the user could arrange for this behavior simply by having the new DelimitedBoost filter thing in the chain.,Can we rename this to `u
+4931,"@@ -233,15 +233,8 @@ module Unix::Exec
+   def environment_string env
+     return '' if env.empty?
+     env_array = self.environment_variable_string_pair_array( env )
+-
+     environment_string = env_array.join(' ')
+-    command = 'env'
+-    punctuation = ''
+-    if self[:platform] =~ /cisco-5/
+-      command = 'export'
+-      punctuation = ';'
+-    end
+-    ""#{command} #{environment_string}#{punctuation}""
++    ""env #{environment_string}""
+   end
+ 
+   def environment_variable_string_pair_array env","the previous code used 'export' when platform is cisco-5, presumably because 'env' cannot be used to load variables? I have no idea if that's the case but this env vs export logic is not here",Why is this removed?
+4932,"@@ -104,11 +104,15 @@ type CloudInit struct {
+ 	// +optional
+ 	EnableSecureSecretsManager bool `json:""enableSecureSecretsManager,omitempty""`
+ 
+-	// SecretARN is the Amazon Resource Name of the secret. This is stored
++	// SecretCount is the number of secrets used to form the complete secret
++	// +optional
++	SecretCount int32 `json:""secretCount,omitempty""`
++
++	// SecretPrefix is the prefix for the secret name. This is stored
+ 	// temporarily, and deleted when the machine registers as a node against
+ 	// the workload cluster.
+ 	// +optional
+-	SecretARN string `json:""secretARN,omitempty""`
++	SecretPrefix string `json:""secretPrefix,omitempty""`
+ }
+ 
+ // AWSMachineStatus defines the observed state of AWSMachine",I'm wondering if we need to add some type of validation here that the SecretCount != 0... Or do we think it would be valid to have a SecretCount of 0?,Why is this an int32 and not a string?
+4933,"@@ -3752,7 +3752,7 @@ describe('Cursor', function () {
+           db.s.topology,
+           db.s.namespace,
+           {},
+-          { limit: 0, skip: 0, slaveOk: false, readPreference: 42 }
++          { limit: 0, skip: 0, secondaryOk: false, readPreference: 42 }
+         );
+ 
+         cursor.hasNext(err => {","This test is being skipped. I unskipped it, and it failed in the same way for both `slaveOk: false` and `secondaryOk: false`. I'm not sure how else to test this broken test.",Why do we need to change this?
+4934,"@@ -33,6 +33,8 @@ import (
+ // ResponseHeaders.
+ type OutboundCall struct {
+ 	// request attributes to fill if non-nil
++	to              *Identifier
++	from            *Identifier
+ 	headers         []keyValuePair
+ 	shardKey        *string
+ 	routingKey      *string",I don't believe that we need a pointer to an interface for the `to` side of this since we're just assigning a value to the to field.,Why are these pointers?
+4935,"@@ -74,13 +74,18 @@ def later(ms: int, command, win_id):
+ 
+ @cmdutils.register(maxsplit=1, no_cmd_split=True, no_replace_variables=True)
+ @cmdutils.argument('win_id', win_id=True)
+-def repeat(times: int, command, win_id):
++@cmdutils.argument('count', count=True)
++def repeat(times: int, command, win_id, count=None):
+     """"""Repeat a given command.
+ 
+     Args:
+         times: How many times to repeat.
+         command: The command to run, with optional args.
+     """"""
++
++    if count is not None:
++        times *= count
++
+     if times < 0:
+         raise cmdexc.CommandError(""A negative count doesn't make sense."")
+     commandrunner = runners.CommandRunner(win_id)",No blank line after the docstring.,I don't think you need the `count=True
+4936,"@@ -17,8 +17,11 @@ package blobvar
+ import (
+ 	""context""
+ 	""errors""
++	""github.com/google/go-cmp/cmp""
++	""io/ioutil""
+ 	""os""
+ 	""path""
++	""path/filepath""
+ 	""testing""
+ 
+ 	""gocloud.dev/blob""",nit: move this to the group below.,File is not goimports-ed
+4937,"@@ -3045,8 +3045,11 @@ short Sort::generateTdb(Generator * generator,
+   
+   CostScalar bufferSize = getDefault(GEN_SORT_MAX_BUFFER_SIZE);
+ 
+-  ULng32 bufferSize_as_ulong = 
+-    (ULng32)(MINOF(CostScalar(UINT_MAX), bufferSize)).getValue(); 
++  UInt32 bufferSize_as_ulong = 
++    (UInt32)(MINOF(CostScalar(UINT_MAX), bufferSize)).getValue(); 
++
++  // allocate buffer to hold atlease one row
++  bufferSize_as_ulong = MAXOF(bufferSize_as_ulong, sortRecLen);
+ 
+   GenAssert(sortRecLen <= bufferSize_as_ulong, 
+       ""Record Len greater than GEN_SORT_MAX_BUFFER_SIZE"");","This is fine, but maybe we should change the variable name to ""bufferSize_as_uint""? Or ""...uint32""?",Why do we need this chan
+4938,"@@ -57,9 +57,10 @@ module Blacklight::SolrResponse::Spelling
+                 #   origFreq =>
+                 #   suggestion =>  [{ frequency =>, word => }] # for extended results
+                 #   suggestion => ['word'] # for non-extended results
+-                if suggestions.index(""correctlySpelled"")
++                origFreq = term_info['origFreq']
++                if term_info['suggestion'].first.is_a?(Hash) or suggestions.index(""correctlySpelled"")
+                   word_suggestions << term_info['suggestion'].map do |suggestion|
+-                    suggestion['word'] if suggestion['freq'] > term_info['origFreq']
++                    suggestion['word'] if suggestion['freq'] > origFreq
+                   end
+                 else
+                   # only extended suggestions have frequency so we just return all suggestions",Use snake_case for variable names.,Why do we need to check 
+4939,"@@ -1095,7 +1095,7 @@ namespace pwiz.SkylineTestA
+             return count;
+         }
+         
+-        [TestMethod]
++        //[TestMethod]
+         public void ConsoleBadRawFileImportTest()
+         {
+             // Run this test only if we can read Thermo's raw files","Obviously, don't merge this to master.",Is this intentional?
+4940,"@@ -160,6 +160,18 @@ module RSpec::Core
+       end
+     end
+ 
++    describe ""#exit_early"" do
++      it ""returns the passed exit code"" do
++        expect(reporter.exit_early(42)).to eq(42)
++      end
++
++      it ""reports zero examples"" do
++        allow(reporter).to receive(:report)
++        reporter.exit_early(42)
++        expect(reporter).to have_received(:report).with(0)
++      end
++    end
++
+     describe ""#report"" do
+       it ""supports one arg (count)"" do
+         reporter.report(1) {}","Nearly there! This should assert on the output, take the result of ""start"" and ""finish"" as an example :)",I think this should be `expect(reporter).to have_received(:report).with(42)`
+4941,"@@ -63,11 +63,11 @@ func NewDriverSub() *driverSub {
+ 	return ds
+ }
+ 
+-func (s *driverSub) ReceiveBatch(ctx context.Context) ([]*driver.Message, error) {
++func (s *driverSub) ReceiveBatch(ctx context.Context, maxMessages int) ([]*driver.Message, error) {
+ 	for {
+ 		select {
+ 		case <-s.sem:
+-			ms := s.grabQueue()
++			ms := s.grabQueue(maxMessages)
+ 			if len(ms) != 0 {
+ 				return ms, nil
+ 			}",This loop is going to burn CPU if len(s.q) == 0. Maybe a small sleep?,I don't think we need to pass in `maxMessages` here.
+4942,"@@ -30,7 +30,10 @@ import com.pingcap.tikv.exception.TiClientInternalException;
+ import com.pingcap.tikv.key.Key;
+ import com.pingcap.tikv.util.ConcreteBackOffer;
+ import com.pingcap.tikv.util.Pair;
+-import java.util.*;
++import java.util.ArrayList;
++import java.util.HashMap;
++import java.util.List;
++import java.util.Map;
+ import org.apache.log4j.Logger;
+ import org.tikv.kvproto.Metapb.Peer;
+ import org.tikv.kvproto.Metapb.Store;",can you give a reason why session should be contained in RegionManager?,why change this?
+4943,"@@ -37,6 +37,16 @@ func TestAuthenticate_WhenSignatureIsCorrect(t *testing.T) {
+ 	assert.Exactly(t, originalSignerID, signerID, ""Original signer should be extracted"")
+ }
+ 
++func TestAuthenticate_WhenBase64MessageSignatureIsCorrect(t *testing.T) {
++	message := []byte(""MystVpnSessionId:Boop!"")
++	signature := SignatureBase64(""V6ifmvLuAT+hbtLBX/0xm3C0afywxTIdw1HqLmA4onpwmibHbxVhl50Gr3aRUZMqw1WxkfSIVdhpbCluHGBKsgE="")
++
++	extractor := &extractor{}
++	signerID, err := extractor.Extract(message, signature)
++	assert.NoError(t, err)
++	assert.Exactly(t, originalSignerID, signerID, ""Original signer should be extracted"")
++}
++
+ func TestAuthenticate_WhenSignatureIsEmpty(t *testing.T) {
+ 	message := []byte(""Boop!"")
+ 	signature := SignatureHex("""")","You are comparing two signerIDs here, error message should be ""Signers should match""",Can you add a case where the signature is not correct?
+4944,"@@ -57,6 +57,15 @@ type IAMRoleCredentials struct {
+ type TaskIAMRoleCredentials struct {
+ 	ARN                string
+ 	IAMRoleCredentials IAMRoleCredentials
++	lock               sync.RWMutex
++}
++
++// GetIAMRoleCredentials returns the IAM role credentials in the task IAM role struct
++func (role *TaskIAMRoleCredentials) GetIAMRoleCredentials() IAMRoleCredentials {
++	role.lock.RLock()
++	defer role.lock.RUnlock()
++
++	return role.IAMRoleCredentials
+ }
+ 
+ // GenerateCredentialsEndpointRelativeURI generates the relative URI for the",Who's acquiring this lock for writes?,Why do we need this lock?
+4945,"@@ -248,10 +248,10 @@ PublicKey.fromX = function(odd, x) {
+  * @param {String} [compressed] - If the public key is compressed
+  * @returns {null|Error} An error if exists
+  */
+-PublicKey.getValidationError = function(data, compressed) {
++PublicKey.getValidationError = function(data) {
+   var error;
+   try {
+-    new PublicKey(data, compressed);
++    new PublicKey(data);
+   } catch (e) {
+     error = e;
+   }","This throws a linter error, don't use object creation for side effects. I feel like it's kinda messed up that the errors are thrown by the constructor and not that the constructor will throw them",Why did you remove the pa
+4946,"@@ -43,6 +43,18 @@ describe Trail do
+     end
+   end
+ 
++  describe "".by_topic"" do
++    it ""returns trails sorted by their topic's name"" do
++      create(:trail, topic: create(:topic, name: ""A""))
++      create(:trail, topic: create(:topic, name: ""C""))
++      create(:trail, topic: create(:topic, name: ""B""))
++
++      result = Trail.by_topic.map(&:topic_name)
++
++      expect(result).to eq %w(A B C)
++    end
++  end
++
+   describe "".completed_for"" do
+     it ""shows completed trails for a user"" do
+       _incomplete = create(:trail)",Should there be a `trail.topic_name` method so we don't annoy Demeter?,I'm not sure if this is t
+4947,"@@ -281,7 +281,7 @@ def _file_to_data_frame(ext, path, target, handler_args):
+ 
+     return dataframe
+ 
+-def build_package(username, package, yaml_path, checks_path=None, dry_run=False, env='default'):
++def build_package(team, username, package, yaml_path, checks_path=None, dry_run=False, env='default'):
+     """"""
+     Builds a package from a given Yaml file and installs it locally.
+ ","instead of passing ""None"" it would be more readable to create a constant e.g. TEAM_PUBLIC = None and then call build_package(TEAM_PUBLIC, ...)",I don't think you need th
+4948,"@@ -9,6 +9,8 @@ gc_disable();
+ // show all errors
+ error_reporting(-1);
+ 
++require_once __DIR__ . '/Psalm/Internal/exception_handler.php';
++
+ $valid_short_options = [
+     'h',
+     'v',",Would it make sense to include this file via composer files-autoloading instead?,Why is this needed?
+4949,"@@ -348,10 +348,12 @@ public class ExpectedConditions {
+                                                                     final String text) {
+ 
+     return new ExpectedCondition<Boolean>() {
++      private String elementText = null;
++
+       @Override
+       public Boolean apply(WebDriver driver) {
+         try {
+-          String elementText = element.getText();
++          elementText = element.getText();
+           return elementText.contains(text);
+         } catch (StaleElementReferenceException e) {
+           return null;","Each `ExpectedCondition` implements `java.util.Function` These are expected to be stateless. This condition will leak previous `elementText` on the second usage, which doesn't seem ideal.",Why is this needed?
+4950,"@@ -1,9 +1,10 @@
+ package sql_test
+ 
+ import (
+-	""github.com/influxdata/flux/plan""
+ 	""testing""
+ 
++	""github.com/influxdata/flux/plan""
++
+ 	""github.com/DATA-DOG/go-sqlmock""
+ 	""github.com/google/go-cmp/cmp""
+ 	""github.com/google/go-cmp/cmp/cmpopts""",Extra newline here. Thanks for moving it under the `testing` import though. This just needs to be grouped with the other imports below it.,Why did this change
+4951,"@@ -71,7 +71,11 @@ public class MimeBodyPart extends BodyPart {
+                 contentType += String.format("";\n name=\""%s\"""", name);
+             }
+             setHeader(MimeHeader.HEADER_CONTENT_TYPE, contentType);
+-            setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""quoted-printable"");
++            if (""8bit"".equals(body.getEncoding())) {
++                setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""8bit"");
++            } else {
++                setHeader(MimeHeader.HEADER_CONTENT_TRANSFER_ENCODING, ""quoted-printable"");
++            }
+         }
+     }
+ ",Should we ignore case when doing the comparison?,Why is this needed?
+4952,"@@ -94,6 +94,7 @@ struct wlr_backend *wlr_backend_autocreate(struct wl_display *display) {
+ 		}
+ 	}
+ 
++#ifdef WLR_HAS_X11_BACKEND
+ 	const char *x11_display = getenv(""DISPLAY"");
+ 	if (x11_display) {
+ 		struct wlr_backend *x11_backend =",The same `ifdef` should apply to `#include <wlr/backend/x11.h>` line 14,#endif // WLR_HAS_X11_BACKEND
+4953,"@@ -183,7 +183,14 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+             catch (Exception ex)
+             {
+                 // profiled app will continue working as expected without this method
+-                Log.ErrorException($""Error resolving {DiagnosticSourceTypeName}.{nameof(BeforeAction)}(...)"", ex);
++                Log.ErrorRetrievingMethod(
++                    exception: ex,
++                    moduleVersionPointer: moduleVersionPtr,
++                    mdToken: mdToken,
++                    opCode: opCode,
++                    instrumentedType: DiagnosticSourceTypeName,
++                    methodName: nameof(BeforeAction),
++                    instanceType: diagnosticSource?.GetType().AssemblyQualifiedName);
+             }
+ 
+             try","We're instrumenting a static method, so there's no instance in this case. `diagnosticSource` is the first argument.",nit: `DiagnosticSourceTypeNam
+4954,"@@ -194,6 +194,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+     private Action action;
+ 
+     private boolean requestReadReceipt = false;
++    private boolean isHighPriority = false;
+ 
+     private TextView chooseIdentityButton;
+     private EditText subjectView;","I feel like this belongs in `RecipientPresenter` (which should really be `MetadataPresenter`), but I suppose having it next to requestReadReceipt makes sense as well. feel free to leave as is.",private boolean isHighPriorit
+4955,"@@ -1,6 +1,6 @@
+ Summary:        Open Programmable Acceleration Engine (OPAE) SDK
+ Name:           opae
+-Version:        1.4.0
++Version:        1.4.1
+ Release:        1%{?dist}
+ License:        BSD
+ ExclusiveArch:  x86_64",Let's go back to 1.4.0 until the release is being prepared.,Why did you change this?
+4956,"@@ -7337,6 +7337,7 @@ pre_system_call(dcontext_t *dcontext)
+              size_t sigsetsize)
+          */
+         /* we also need access to the params in post_system_call */
++        uint errno_val = 0;
+         dcontext->sys_param0 = sys_param(dcontext, 0);
+         dcontext->sys_param1 = sys_param(dcontext, 1);
+         dcontext->sys_param2 = sys_param(dcontext, 2);","I would avoid the term ""errno"" as it implies the glibc variable. Use error_code or status or something.",Why do we need this?
+4957,"@@ -69,7 +69,7 @@ func (i *inbound) Channel() *tchannel.Channel {
+ 	return i.ch
+ }
+ 
+-func (i *inbound) Start(h transport.Handler) error {
++func (i *inbound) Start(h transport.Handler, d transport.Dependencies) error {
+ 	sc := i.ch.GetSubChannel(i.ch.ServiceName())
+ 	existing := sc.GetHandlers()
+ 	sc.SetHandler(handler{existing, h})",@abhinav @kriskowal what do you think about putting the handler on `d`?,nit: `d` is unused
+4958,"@@ -91,7 +91,7 @@ type BackupOptions struct {
+ 	ExcludeLargerThan       string
+ 	Stdin                   bool
+ 	StdinFilename           string
+-	Tags                    []string
++	Tags                    restic.TagList
+ 	Host                    string
+ 	FilesFrom               []string
+ 	TimeStamp               string",Why `restic.TagLists` and no `restic.TagList` ? Because I'm using `restic.TagList` here and using `restic.TagLists` is a lot of changes,Why did you change t
+4959,"@@ -50,6 +50,8 @@ func TestWait(t *testing.T) {
+ 				cancel()
+ 				return ctx
+ 			}(),
++			// Ensure the timer and context do not end simultaneously.
++			delay:    1 * time.Hour,
+ 			expected: context.Canceled,
+ 		},
+ 	}","An hour seems a significant amount of time to wait for within a test, does it need to be that long?",Why do we need this?
+4960,"@@ -204,7 +204,7 @@ func (d *RPCFactory) CreateFrontendGRPCConnection(hostName string) *grpc.ClientC
+ 		}
+ 	}
+ 
+-	return d.dial(hostName, tlsClientConfig)
++	return d.dial(hostName, tlsClientConfig, false)
+ }
+ 
+ // CreateInternodeGRPCConnection creates connection for gRPC calls","Nit: (newish to golang, don't hesitate to tell me I'm wrong here, but ...) I'd have written this code, just for readability: keepAlive := false return d.dial(hostName, tlsClientConfig, keepAlive) ... or even return d.dial(hostName, tlsClientConfig, false) // keepAlive=false Personally I think Golang should have included named args; I think it's one of the things python got right.",Why is this false?
+4961,"@@ -13,6 +13,7 @@ namespace Datadog.Trace.Configuration
+         AspNetMvc,
+         AspNetWebApi2,
+         GraphQL,
++        Msmq,
+         MongoDb,
+         XUnit,
+         NUnit,","I don't think it would cause any version conflict, but I'd feel safer if you declared it last, so that the numerical id of the existing integrations don't change",Why is this needed
+4962,"@@ -135,6 +135,9 @@ func (c *certificateRequestManager) updateCertificateStatus(ctx context.Context,
+ 		ready = cmmeta.ConditionTrue
+ 		reason = ""Ready""
+ 		message = ""Certificate is up to date and has not expired""
++	case apiutil.CertificateRequestHasInvalidRequest(req):
++		reason = ""InvalidRequest""
++		message = fmt.Sprintf(""The CertificateRequest %q is an invalid request"", req.Name)
+ 	case req != nil:
+ 		reason = ""InProgress""
+ 		message = fmt.Sprintf(""Waiting for CertificateRequest %q to complete"", req.Name)","Can we provide some more useful actionable info here? `fmt.Sprintf(""The certificate request could not be completed due to invalid request options: %s"", req.Status.Conditions[InvalidRequestCondition].Message)`",I don't think we n
+4963,"@@ -155,6 +155,7 @@ var (
+ 		API: API{
+ 			UseRDS:    false,
+ 			Port:      14014,
++			Web3Port:  15014, // TODO: port 15014 is used for testing
+ 			TpsWindow: 10,
+ 			GasStation: GasStation{
+ 				SuggestBlockWindow: 20,","yeah, can change to 8545",I'm not sure if th
+4964,"@@ -16,6 +16,11 @@ use Ergonode\BatchAction\Domain\Entity\BatchActionId;
+ use Ergonode\SharedKernel\Domain\AggregateId;
+ use Symfony\Component\Messenger\Stamp\HandledStamp;
+ use Ergonode\BatchAction\Domain\Repository\BatchActionRepositoryInterface;
++use Ergonode\Core\Application\Security\User\CachedUser;
++use Ergonode\Account\Domain\Repository\UserRepositoryInterface;
++use Ergonode\SharedKernel\Domain\Aggregate\UserId;
++use Ergonode\BatchAction\Domain\Event\BatchActionEndedEvent;
++use Ergonode\Core\Application\Messenger\Stamp\UserStamp;
+ 
+ class BatchActionTransport implements TransportInterface
+ {",As far as I can see you're not rollbacking transaction anywhere. This could potentially cause further issues(and very hard to debug ones) with not synchronized transactions between message handling. Is the transaction required in this place anyway? You seem only to be fetching data here. ack method is performing some updates so it makes sense,Why do we need this class?
+4965,"@@ -16,9 +16,14 @@
+ 
+ package io.servicecomb.transport.rest.vertx;
+ 
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
++import org.springframework.stereotype.Component;
++
+ import io.servicecomb.core.Const;
+ import io.servicecomb.core.Invocation;
+ import io.servicecomb.core.transport.AbstractTransport;
++import io.servicecomb.foundation.common.net.NetUtils;
+ import io.servicecomb.foundation.common.net.URIEndpointObject;
+ import io.servicecomb.foundation.vertx.SimpleJsonObject;
+ import io.servicecomb.foundation.vertx.VertxUtils;",What's the meaning of null URIEndpointObject?,Why is this needed?
+4966,"@@ -4,14 +4,17 @@ import os
+ import sys
+ import logging
+ import logging.config
+-from six.moves import input, configparser
++
+ from kinto.core import scripts
+ from pyramid.scripts import pserve
+ from pyramid.paster import bootstrap
+ from kinto import __version__
+ from kinto.config import init
+ 
+-CONFIG_FILE = 'config/kinto.ini'
++DEFAULT_CONFIG_FILE = 'config/kinto.ini'
++DEFAULT_PORT = 8888
++DEFAULT_LOG_LEVEL = logging.INFO
++DEFAULT_LOG_FORMAT = ""%(levelname)-5.5s  %(message)s""
+ 
+ 
+ def main(args=None):",Why did you remove the time? It can be useful if some actions are ran in jobs?,I think this should be `lo
+4967,"@@ -32,7 +32,7 @@ import (
+ 	""github.com/ncw/rclone/lib/pacer""
+ 	""github.com/ncw/rclone/lib/readers""
+ 	""github.com/pkg/errors""
+-	mega ""github.com/t3rm1n4l/go-mega""
++	""github.com/t3rm1n4l/go-mega""
+ )
+ 
+ const (",File is not `goimports`-ed (from `goimports`),Why this change?
+4968,"@@ -7,12 +7,12 @@ import (
+ 	""math/big""
+ 	""strings""
+ 
+-	ethereum ""github.com/sonm-io/go-ethereum""
+-	""github.com/sonm-io/go-ethereum/accounts/abi""
+-	""github.com/sonm-io/go-ethereum/accounts/abi/bind""
+-	""github.com/sonm-io/go-ethereum/common""
+-	""github.com/sonm-io/go-ethereum/core/types""
+-	""github.com/sonm-io/go-ethereum/event""
++	ethereum ""github.com/ethereum/go-ethereum""
++	""github.com/ethereum/go-ethereum/accounts/abi""
++	""github.com/ethereum/go-ethereum/accounts/abi/bind""
++	""github.com/ethereum/go-ethereum/common""
++	""github.com/ethereum/go-ethereum/core/types""
++	""github.com/ethereum/go-ethereum/event""
+ )
+ 
+ // BasicTokenABI is the input ABI used to generate the binding from.",What the reason to change imports?,Why did you change this?
+4969,"@@ -83,6 +83,15 @@ public class HiveClientPool extends ClientPool<HiveMetaStoreClient, TException>
+     return client;
+   }
+ 
++  @Override
++  protected boolean failureDetection(Exception e) {
++    if (super.failureDetection(e) || (e != null && e instanceof MetaException &&
++            e.getMessage().contains(""Got exception: org.apache.thrift.transport.TTransportException""))) {
++      return true;
++    }
++    return false;
++  }
++
+   @Override
+   protected void close(HiveMetaStoreClient client) {
+     client.close();",Nit: continuation indents are 2 indents / 4 spaces.,Why do we need this?
+4970,"@@ -666,10 +666,15 @@ class JMX(object):
+             parsed_url = parse.urlsplit(default_address)
+             if parsed_url.scheme:
+                 cfg.append(JMX._string_prop(""HTTPSampler.protocol"", parsed_url.scheme))
+-            if parsed_url.hostname:
+-                cfg.append(JMX._string_prop(""HTTPSampler.domain"", parsed_url.hostname))
+-            if parsed_url.port:
+-                cfg.append(JMX._string_prop(""HTTPSampler.port"", parsed_url.port))
++
++            if parsed_url.netloc:
++                netloc = parsed_url.netloc
++                if ':' in netloc:
++                    index = netloc.rfind(':')
++                    cfg.append(JMX._string_prop(""HTTPSampler.port"", netloc[index+1:]))
++                    netloc = netloc[:index]
++
++                cfg.append(JMX._string_prop(""HTTPSampler.domain"", netloc))
+ 
+         if timeout:
+             cfg.append(JMX._string_prop(""HTTPSampler.connect_timeout"", timeout))","You can use `netloc.rsplit("":"")` for that.",I think this should be `
+4971,"@@ -143,7 +143,7 @@ func (w *watcher) run(ctx context.Context, repo git.Repo, repoCfg *config.PipedR
+ 				continue
+ 			}
+ 			if !ok {
+-				w.logger.Error(""configuration file for Image Watcher not found"",
++				w.logger.Info(""configuration file for Image Watcher not found"",
+ 					zap.String(""repo-id"", repoCfg.RepoID),
+ 					zap.Error(err),
+ 				)","nits, I don't get the point of this change  ",Why this change?
+4972,"@@ -0,0 +1,13 @@
++// +build !windows
++
++// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++// SPDX-License-Identifier: Apache-2.0
++
++package log
++
++// Log message prefixes.
++const (
++	successPrefix = ""✔ Success!""
++	errorPrefix   = ""✘ Error!""
++	warningPrefix = ""Note:""
++)","`warningPrefix` looks the same on both platforms, we could move it up to `log.go`.",I don't think we need this file.
+4973,"@@ -65,10 +65,10 @@ type Config struct {
+ 	Inbounds  Inbounds
+ 	Outbounds Outbounds
+ 
+-	// Filter and Interceptor that will be applied to all outgoing and incoming
+-	// requests respectively.
+-	Filter      transport.Filter
+-	Interceptor transport.Interceptor
++	// Filters and Interceptors that will be applied to all outgoing and
++	// incoming requests respectively.
++	Filters      Filters
++	Interceptors Interceptors
+ 
+ 	Tracer opentracing.Tracer
+ }",What's the motivation behind switching to plural here? I think we want singular cc @abhinav,nit: `Filters` -> `FiltersAndInt
+4974,"@@ -26,6 +26,19 @@ import (
+ 	""fmt""
+ )
+ 
++// Wrap returns a new Status that wraps the original error.
++//
++// The Code should never be CodeOK, if it is, this will return nil.
++func Wrap(code Code, err error) *Status {
++	if code == CodeOK {
++		return nil
++	}
++	return &Status{
++		code: code,
++		err:  &wrapError{err: err},
++	}
++}
++
+ // Newf returns a new Status.
+ //
+ // The Code should never be CodeOK, if it is, this will return nil.","What do you think about renaming this method `FromErrorAndCode(code Code, err error) *Status`? One of the benefits is that it will be consistent with the naming of `func FromError(err error) *Status {` which does something almost similar.",Why is this needed?
+4975,"@@ -35,7 +35,7 @@ namespace Nethermind.JsonRpc
+         [ConfigItem(Description = ""Port number for JSON RPC calls. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = ""8545"")]
+         int Port { get; set; }
+         
+-        [ConfigItem(Description = ""Port number for JSON RPC web socket calls. By default same port is used as regular JSON RPC. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = null)]
++        [ConfigItem(Description = ""Port number for JSON RPC web socket calls. By default same port is used as regular JSON RPC. Ensure the firewall is configured when enabling JSON RPC."", DefaultValue = ""8545"")]
+         int WebSocketPort { get; set; }
+         
+         [ConfigItem(Description = ""Defines which RPC modules should be enabled."", DefaultValue = ""all"")]",we cannot state that by default the same value is used if we stopped using null - it would suggest that when you change JSON RPC and leave WS port default then they would be same.,Why this change?
+4976,"@@ -142,7 +142,7 @@ func chromeTestImpl(version protocol.VersionNumber, url string, blockUntilDone f
+ 	}
+ 	utils.Infof(""Running chrome: %s '%s'"", getChromePath(), strings.Join(args, ""' '""))
+ 	command := exec.Command(path, args...)
+-	session, err := gexec.Start(command, GinkgoWriter, GinkgoWriter)
++	session, err := gexec.Start(command, nil, nil)
+ 	Expect(err).NotTo(HaveOccurred())
+ 	defer session.Kill()
+ 	const pollInterval = 100 * time.Millisecond","I'm still not convinced dropping Chrome logs is the right thing to do, but if you insist ",Why are we passing nil here?
+4977,"@@ -38,7 +38,7 @@ public class ReflectionParameterDeclaration implements ParameterDeclaration {
+ 
+     @Override
+     public String getName() {
+-        throw new UnsupportedOperationException();
++        throw new UnsupportedOperationException(""Unable to get the name"");
+     }
+ 
+     @Override","It would be helpful to include some reasoning here. With the reflection model, it is often the case that names are not available.",Why is this change needed?
+4978,"@@ -82,6 +82,7 @@ func Run() {
+ 	certmagic.UserAgent = appName + ""/"" + appVersion
+ 
+ 	// Set up process log before anything bad happens
++	caddy.LogDestination = logfile
+ 	switch logfile {
+ 	case ""stdout"":
+ 		log.SetOutput(os.Stdout)","Instead of setting this here, why not have the flag call in the init function set `caddy.LogDestination` directly, and switch on that?",Why do we need this?
+4979,"@@ -20,6 +20,7 @@
+  * External dependencies
+  */
+ import { get } from 'lodash';
++import { __ } from '@wordpress/i18n';
+ 
+ /**
+  * Formats a number using the JS Internationalization Number Format API.","This belongs under ""WordPress dependencies"".",This should be `@wordpress/i
+4980,"@@ -4,6 +4,8 @@ using Datadog.Trace.TestHelpers;
+ using Xunit;
+ using Xunit.Abstractions;
+ 
++#if !NET452
++
+ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+ {
+     public class Elasticsearch5Tests : TestHelper",Was there an issue on `net452`?,Why is this needed?
+4981,"@@ -201,12 +201,17 @@ namespace Microsoft.Cci.Writers.CSharp
+ 
+             WriteOutParameterInitializations(method);
+ 
+-            if (_forCompilationThrowPlatformNotSupported)
++            if (_platformNotSupportedExceptionMessage != null)
+             {
+                 Write(""throw new "");
+                 if (_forCompilationIncludeGlobalprefix)
+                     Write(""global::"");
+-                Write(""System.PlatformNotSupportedException(); "");
++                if(_platformNotSupportedExceptionMessage.Equals(""Default""))
++                    Write(""System.PlatformNotSupportedException();"");
++                else if(_platformNotSupportedExceptionMessage.StartsWith(""SR.""))
++                    Write($""System.PlatformNotSupportedException({_platformNotSupportedExceptionMessage}); "");
++                else
++                    Write($""System.PlatformNotSupportedException(\""{_platformNotSupportedExceptionMessage}\""); "");
+             }
+             else if (method.ContainingTypeDefinition.IsValueType && method.IsConstructor)
+             {",Another option is to always write it without quotes. I always have to use SR. And why not?,Why not use `String
+4982,"@@ -1,7 +1,7 @@
+ import PropTypes from 'prop-types'
++import deepmerge from 'deepmerge' // < 1kb payload overhead when lodash/merge is > 3kb.
+ 
+-export const defaultBreakpoints = [40, 52, 64].map(n => n + 'em')
+-
++// PropTypes
+ export const propType = PropTypes.oneOfType([
+   PropTypes.number,
+   PropTypes.string,",This should use the `merge` function added in #473 instead of introducing a new dependency,Can we remove this?
+4983,"@@ -14480,6 +14480,16 @@ bool CoreChecks::ValidateDescriptorUpdateTemplate(const char *func_name,
+                                  func_name, pd_set, report_data->FormatHandle(pCreateInfo->pipelineLayout).c_str());
+             }
+         }
++    } else if (VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET == pCreateInfo->templateType) {
++        for (const auto &binding : layout->GetBindings()) {
++            if (binding.descriptorType == VK_DESCRIPTOR_TYPE_MUTABLE_VALVE) {
++                skip |= LogError(
++                    device, ""VUID-VkDescriptorUpdateTemplateCreateInfo-templateType-04615"",
++                    ""%s: pCreateInfo->templateType is VK_DESCRIPTOR_UPDATE_TEMPLATE_TYPE_DESCRIPTOR_SET, but ""
++                    ""pCreateInfo->descriptorSetLayout contains a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE."",
++                    func_name);
++            }
++        }
+     }
+     for (uint32_t i = 0; i < pCreateInfo->descriptorUpdateEntryCount; ++i) {
+         const auto &descriptor_update = pCreateInfo->pDescriptorUpdateEntries[i];","Shouldn't this say ""a binding with descriptor type VK_DESCRIPTOR_TYPE_MUTABLE_VALVE""",Shouldn't this be a
+4984,"@@ -12,6 +12,8 @@
+ #include <wlr/types/wlr_tablet_v2.h>
+ #include <wlr/util/log.h>
+ 
++static const struct wlr_tablet_tool_v2_grab_interface default_tool_interface;
++
+ static const struct wlr_surface_role tablet_tool_cursor_surface_role = {
+ 	.name = ""wp_tablet_tool-cursor"",
+ };",This variable name should probably contain `grab`,Why do we need this?
+4985,"@@ -0,0 +1,10 @@
++# frozen_string_literal: true
++
++# These configuration settings are used to communicate with the
++# Open Aire Research Project Registry API. For more information about
++# the API and to verify that your configuration settings are correct,
++Rails.configuration.x.open_aire.api_base_url = ""https://api.openaire.eu/""
++# The api_url should contain `%s. This is where the funder is appended!
++Rails.configuration.x.open_aire.search_path = ""projects/dspace/%s/ALL/ALL""
++Rails.configuration.x.open_aire.default_funder = ""H2020""
++Rails.configuration.x.open_aire.active = true",Which initializer should we be using for open_aire? The one in `external_apis` or this one in `initializers`?,Style/MutableConstan
+4986,"@@ -8,6 +8,7 @@ import (
+ 
+ 	inet ""gx/ipfs/QmNgLg1NTw37iWbYPKcyK85YJ9Whs1MkPtJwhfqbNYAyKg/go-libp2p-net""
+ 	pstore ""gx/ipfs/QmPiemjiKBC9VA7vZF82m4x1oygtg2c2YVqag8PX7dN1BD/go-libp2p-peerstore""
++	routing ""gx/ipfs/QmTiRqrF5zkdZyrdsL5qndG1UbeWi8k8N2pYxCtXWrahR2/go-libp2p-routing""
+ 	peer ""gx/ipfs/QmY5Grm8pJdiSSVsYxx4uNRgweY72EmYwuSDbRnbFok3iY/go-libp2p-peer""
+ 	host ""gx/ipfs/QmaoXrM4Z41PD48JY36YqQGKQpLGjyLA2cKcLsES7YddAq/go-libp2p-host""
+ 	logging ""gx/ipfs/QmcuXC5cxs79ro2cUuHs4HQ2bkDLJUYokwL8aivcX6HW3C/go-log""",remove todo on line 28?,I'm not sure if this
+4987,"@@ -0,0 +1,17 @@
++_base_ = [
++    '../_base_/models/retinanet_r50_fpn.py', '../common/mstrain_3x_coco.py'
++]
++# optimizer
++model = dict(
++    pretrained='open-mmlab://resnext101_64x4d',
++    backbone=dict(
++        type='ResNeXt',
++        depth=101,
++        groups=64,
++        base_width=4,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        style='pytorch'))
++optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)",clean unnecessary arguments.,why do we need this?
+4988,"@@ -30,6 +30,8 @@ public enum Status {
+   SUCCEEDED(50),
+   KILLING(55),
+   KILLED(60),
++  // EXECUTION_STOPPED refers to a terminal flow status due to crashed executor/container
++  EXECUTION_STOPPED(65),
+   FAILED(70),
+   FAILED_FINISHING(80),
+   SKIPPED(90),",Could the name of the status be confusing to users? It says the execution stopped but is it a temporary stop? Will it continue to run at some point? To me the name does not suggest a final status but a transition one. WDYT @sshardool @jakhani @djaiswal83 @aditya1105,I'm not sure if this is the right place to put this status. I think it should be in the `ContainerState` enum.
+4989,"@@ -20,7 +20,8 @@
+ 
+ import testtools
+ 
+-import molecule.provisioners as provisioners
++from molecule.Provisioners import DockerProvisioner
++import molecule.utilities
+ from molecule.core import Molecule
+ import yaml
+ from molecule.ansible_playbook import AnsiblePlaybook","Since we created a Provisioners directory, can we do the same with the tests, and follow the same structure as the code?",Why do we need this import?
+4990,"@@ -16,11 +16,12 @@ import (
+ )
+ 
+ var (
+-	sentryAddr    string // Address of the sentry <host>:<port>
+-	coreAddr      string // Address of the core <host>:<port>
+-	chaindata     string // Path to chaindata
+-	database      string // Type of database (lmdb or mdbx)
+-	mapSizeStr    string // Map size for LMDB
++	sentryAddr    string   // Address of the sentry <host>:<port>
++	sentryAddrs   []string // Address of the sentry <host>:<port>
++	coreAddr      string   // Address of the core <host>:<port>
++	chaindata     string   // Path to chaindata
++	database      string   // Type of database (lmdb or mdbx)
++	mapSizeStr    string   // Map size for LMDB
+ 	freelistReuse int
+ )
+ ",We don't need that one anymore?,Why is this a list?
+4991,"@@ -40,6 +40,7 @@ from graphite.render.attime import parseATTime
+ from graphite.render.functions import PieFunctions
+ from graphite.render.hashing import hashRequest, hashData
+ from graphite.render.glyph import GraphTypes
++from graphite.storage import STORE
+ 
+ from django.http import HttpResponse, HttpResponseServerError, HttpResponseRedirect
+ from django.template import Context, loader","Since we're determining the local node's host info in the `Store()` init, we need to import the `STORE` object here. Is this OK, or should I be determining the host info earlier. (When parsing settings?)",from graphite.storage import STORE
+4992,"@@ -15,7 +15,7 @@ public interface ASTAnyTypeBodyDeclaration extends JavaNode {
+     /**
+      * Returns the child of this declaration,
+      * which can be cast to a more specific node
+-     * type using {@link #getKind()} as a cue.
++     * type using #getKind() as a cue.
+      *
+      * <p>Returns null if this is an empty declaration,
+      * that is, a single semicolon.","I think, there is no `#getKind()` method anymore, is it? The approach would now be testing with instanceof. Or could we return a more specific type than JavaNode now?",Why is this change needed?
+4993,"@@ -60,6 +60,15 @@ module.exports = (props) => {
+           title: props.title
+         })}
+       </div>
++      <button class=""UppyButton--circular UppyButton--blue Browser-doneBtn""
++              type=""button""
++              aria-label=""Done picking files""
++              title=""Done picking files""
++              onclick=${props.done}>
++        <svg aria-hidden=""true"" class=""UppyIcon"" width=""13px"" height=""9px"" viewBox=""0 0 13 9"">
++          <polygon points=""5 7.293 1.354 3.647 0.646 4.354 5 8.707 12.354 1.354 11.646 0.647"" />
++        </svg>
++      </button>
+     </div>
+   `
+ }",can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`,I think this should be `Up
+4994,"@@ -94,3 +94,14 @@ const (
+ 	NFC1_PIN          Pin = 9
+ 	NFC2_PIN          Pin = 10
+ )
++
++// USB CDC identifiers
++const (
++	usb_STRING_PRODUCT      = ""Particle Argon""
++	usb_STRING_MANUFACTURER = ""Particle""
++)
++
++var (
++	usb_VID uint16 = 0x239A
++	usb_PID uint16 = 0x8029
++)",This is the VID from Adafruit. Doesn't Particle have a different VID? (CC @suda).,I don't think this is need
+4995,"@@ -97,8 +97,7 @@ static void parseBlock (lexerState *lexer, bool delim, int kind, vString *scope)
+ /* Resets the scope string to the old length */
+ static void resetScope (vString *scope, size_t old_len)
+ {
+-	scope->length = old_len;
+-	scope->buffer[old_len] = '\0';
++	vStringTruncate (scope, old_len);
+ }
+ 
+ /* Adds a name to the end of the scope string */","The function is only used once, and this body is now only 1 call with the same args (e.g. basically an alias for `vStringTruncate`), it could probably be simply removed. But if you wanna keep the naming for clarity, it also sounds reasonable.",I think this should be `vS
+4996,"@@ -176,8 +176,8 @@ func (k *Kad) manage() {
+ 							k.logger.Debugf(""could not remove peer from addressbook: %s"", peer.String())
+ 						}
+ 					}
+-					k.logger.Debugf(""error connecting to peer from kademlia %s: %v"", bzzAddr.String(), err)
+-					k.logger.Warningf(""connecting to peer %s: %v"", bzzAddr.ShortString(), err)
++					k.logger.Debugf(""could not connect to peer from kademlia %s: %v"", bzzAddr.String(), err)
++					k.logger.Warningf(""could not connect to peer from kademlia %s: %v"", bzzAddr.ShortString(), err)
+ 					// continue to next
+ 					return false, false, nil
+ 				}","please change to `could not connect to peer: %s`. it is not relevant to say ""from kademlia"" in a warning",Why did you change this?
+4997,"@@ -103,8 +103,13 @@ StatusOr<DataSet> SubmitJobExecutor::buildResult(meta::cpp2::AdminJobOp jobOp,
+ }
+ 
+ Value SubmitJobExecutor::convertJobTimestampToDateTime(int64_t timestamp) {
+-  return timestamp > 0 ? Value(time::TimeConversion::unixSecondsToDateTime(timestamp))
+-                       : Value::kEmpty;
++  if (timestamp <= 0) {
++    return Value::kEmpty;
++  }
++
++  DateTime date = time::TimeConversion::unixSecondsToDateTime(timestamp);
++
++  return time::TimeUtils::rmDateTimeStrMs(date.toString());
+ }
+ 
+ nebula::DataSet SubmitJobExecutor::buildShowResultData(",Why need to remove this? Datetime has microseconds in fact.,`rmDateTimeStrMs(date.to
+4998,"@@ -105,7 +105,12 @@ func PrivateKeyBytes(key crypto.PrivateKey) []byte {
+ 	case *rsa.PrivateKey:
+ 		keyBytes = x509.MarshalPKCS1PrivateKey(key)
+ 	case *ecdsa.PrivateKey:
+-		keyBytes, _ = x509.MarshalECPrivateKey(key)
++		var err error
++		var t *testing.T
++		keyBytes, err = x509.MarshalECPrivateKey(key)
++		if err != nil {
++			t.Error(err)
++		}
+ 	}
+ 	return keyBytes
+ }","What's up with this, isn't it nil? Why not use the real T value from the test function? @elcore @wmark",Why is this needed?
+4999,"@@ -34,7 +34,9 @@ class TCallableObject extends TObject
+         return false;
+     }
+ 
+-    public function getAssertionString(bool $exact = false): string
++    public function getAssertionString()
++
++    /** @psalm-mutation-free */: string
+     {
+         return 'object';
+     }",this feels weird,Why is this needed?
+5000,"@@ -21,6 +21,7 @@ public enum NetworkName {
+   SEPOLIA,
+   GOERLI,
+   DEV,
++  PREMERGE,
+   CLASSIC,
+   KOTTI,
+   MORDOR,",I don't think this is the type of network we should be putting in our named networks.,I think this should be `PREMERGE` instead of `PREMERGE`
+5001,"@@ -60,7 +60,15 @@ void generic_data_reader::setup() {
+   shuffle_indices();
+ }
+ 
++std::ofstream debug;
++
+ int lbann::generic_data_reader::fetch_data(CPUMat& X) {
++if (! debug.is_open()) {
++  char b[1024];
++  sprintf(b, ""debug.%d"", m_comm->get_rank_in_world());
++  debug.open(b);
++}
++if (get_role() == ""train"") debug << ""\nstarting fetch_data "";
+   int nthreads = omp_get_max_threads();
+   if(!position_valid()) {
+     throw lbann_exception(",debug? I suspect this will be removed before merge?,I don't think this is the right place to put this code.
+5002,"@@ -42,7 +42,12 @@ describe('Operation (Generators)', function() {
+         // LINE   test = require('assert');
+         // LINE
+         // LINE co(function*() {
+-        // LINE   var client = yield MongoClient.connect('mongodb://localhost:27017/test');
++        // LINE   const client = new MongoClient('mongodb://localhost:27017/test');
++        // LINE   yield client.connect();
++        // LINE
++        // LINE   const client = new MongoClient('mongodb://localhost:27017/test');
++        // LINE   yield client.connect();
++        // LINE
+         // LINE   var db = client.db('test');
+         // REPLACE configuration.writeConcernMax() WITH {w:1}
+         // BEGIN",should this be here twice?,This should be `const`.
+5003,"@@ -46,8 +46,13 @@ public:
+         width_ = GENERATE(16, 128, 1024);
+         stride_ = GENERATE(16, 128, 1024);
+         height_ = GENERATE(16, 128, 1024, 16384, 32768);
+-        SKIP_IF(width_ > stride_);
+-        REQUIRE(width_ <= stride_);
++        CAPTURE(width_, stride_, height_);
++    }
++
++    void generate_special() {
++        width_ = GENERATE(28, 960, 2000, 3072);
++        height_ = GENERATE(1024, 4096);
++        stride_ = height_;
+         CAPTURE(width_, stride_, height_);
+     }
+ ",`generate_special` - a meaningless name for me. Can we provide more detailed naming?,Why did you remove this?
+5004,"@@ -61,8 +61,8 @@ feature 'Subscriber views subscription invoices' do
+     @current_user.stripe_customer_id = ""cus_NOMATCH""
+     @current_user.save!
+ 
+-    visit subscriber_invoice_path(""in_1s4JSgbcUaElzU"")
+-
+-    expect(page).to have_content 'ActiveRecord::RecordNotFound'
++    expect {
++      visit subscriber_invoice_path(""in_1s4JSgbcUaElzU"")
++    }.to raise_error ActiveRecord::RecordNotFound
+   end
+ end","This isn't something you introduced in your changes, but the change makes more obvious to me that this test would be better as a unit test of some kind (probably a controller test). Testing a 404 is an edge case that probably doesn't need to be tested with all components in integration.",Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
+5005,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,Why is this changed to `finest`?
+5006,"@@ -139,7 +139,7 @@ public class BaseRemoteProxy implements RemoteProxy {
+       this.id = id;
+     } else {
+       // otherwise assign the remote host as id.
+-      this.id = remoteHost.toExternalForm();
++      this.id = id = ""http://"" + remoteHost.getHost() + "":"" + remoteHost.getPort();
+     }
+ 
+     maxConcurrentSession = getConfigInteger(RegistrationRequest.MAX_SESSION);",any reason you're assigning to the local variable 'id' too?,Why is this change needed?
+5007,"@@ -28,6 +28,7 @@ import sys
+ import termios
+ from subprocess import CalledProcessError
+ 
++import molecule.validators as validators
+ import prettytable
+ import sh
+ import vagrant",Need to fix this import :),"from subprocess import check_call, CalledProcessError"
+5008,"@@ -46,12 +46,14 @@ func TestBlockGenerator_GenerateBehavior(t *testing.T) {
+ 		Height:    uint64(100),
+ 		StateRoot: newCid(),
+ 	}
++	accountActor := &types.Actor{Code: types.AccountActorCodeCid}
+ 
+ 	// With no messages.
+ 	nextStateRoot := newCid()
+ 	mpb, mst := &MockProcessBlock{}, &types.MockStateTree{}
+ 	mpb.On(""ProcessBlock"", context.Background(), mock.AnythingOfType(""*types.Block""), mst).Return([]*types.MessageReceipt{}, nil)
+ 	mst.On(""Flush"", context.Background()).Return(nextStateRoot, nil)
++	mst.On(""GetActor"", context.Background(), mock.AnythingOfType(""types.Address"")).Return(accountActor, nil)
+ 	successfulGetStateTree := func(c context.Context, stateRootCid *cid.Cid) (types.StateTree, error) {
+ 		assert.True(stateRootCid.Equals(baseBlock.StateRoot))
+ 		return mst, nil",sorry these tests suck so much we are working to kill them,Why do we need this?
+5009,"@@ -701,7 +701,7 @@ import 'emby-ratingbutton';
+ 
+         const player = this;
+         currentRuntimeTicks = playbackManager.duration(player);
+-        updateTimeDisplay(playbackManager.currentTime(player), currentRuntimeTicks, playbackManager.getBufferedRanges(player));
++        updateTimeDisplay(playbackManager.currentTime(player) * 10000, currentRuntimeTicks, playbackManager.getBufferedRanges(player));
+     }
+ 
+     function releaseCurrentPlayer() {",Why not adjust `currentTime` to be in ms directly?,Why do we need to mu
+5010,"@@ -3697,7 +3697,8 @@ instr_is_reg_spill_or_restore_ex(void *drcontext, instr_t *instr, bool DR_only,
+     if (reg == NULL)
+         reg = &myreg;
+     if (instr_check_tls_spill_restore(instr, spill, reg, &check_disp)) {
+-        if (!DR_only ||
++        /* We do not want to count an mcontext base load as a reg spill/restore. */
++        if ((!DR_only && check_disp != os_tls_offset((ushort)TLS_DCONTEXT_SLOT)) ||
+             (reg_spill_tls_offs(*reg) != -1 &&
+              /* Mangling may choose to spill registers to a not natural tls offset,
+               * e.g. rip-rel mangling will, if rax is used by the instruction. We","> restore, we find the matching spill for that restore which uses the same slot nit: Two separate sentences: separate with `.` or something besides `,`.",I don't think this i
+5011,"@@ -89,12 +89,10 @@ var (
+ 		Chain: Chain{
+ 			ChainDBPath:                  ""/tmp/chain.db"",
+ 			TrieDBPath:                   ""/tmp/trie.db"",
+-			UseBadgerDB:                  false,
+ 			ID:                           1,
+ 			Address:                      """",
+ 			ProducerPubKey:               keypair.EncodePublicKey(keypair.ZeroPublicKey),
+ 			ProducerPrivKey:              keypair.EncodePrivateKey(keypair.ZeroPrivateKey),
+-			InMemTest:                    false,
+ 			GenesisActionsPath:           """",
+ 			EmptyGenesis:                 false,
+ 			NumCandidates:                101,",this flag not used,why is this removed?
+5012,"@@ -625,7 +625,9 @@ class Folio extends AbstractAPI implements
+             'zip' => $profile->personal->addresses[0]->postalCode ?? null,
+             'phone' => $profile->personal->phone ?? null,
+             'mobile_phone' => $profile->personal->mobilePhone ?? null,
+-            'expiration_date' => $profile->expirationDate ?? null,
++            'expiration_date' => $this->dateConverter->convertToDisplayDate(
++                ""Y-m-d H:i"", $profile->expirationDate
++            ) ?? null,
+         ];
+     }
+ ","I don't think `?? null` works here... that's to ensure PHP doesn't throw an ""undefined"" error about `$profile->expirationDate`, but now the code is assuming that `$profile->expirationDate` will be set. Might be cleaner to do: <pre> $expiration = isset($profile->expirationDate) ? $this->dateConverter->convertToDisplayDate(""Y-m-d H:i"", $profile->expirationDate) : null; </pre> And then assigning the `$expiration` value in the return array...","I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it."
+5013,"@@ -0,0 +1,8 @@
++import Vue from 'vue'
++import App from './App.vue'
++
++Vue.config.productionTip = false
++
++new Vue({
++  render: h => h(App),
++}).$mount('#app')",An ENV should be used? Are you sure that the Vue examples are built in the production mode?,Why is this needed?
+5014,"@@ -52,7 +52,7 @@ class NodeResult(
+         warn (Optional[Any]): The ``warn`` field from the results of the executed dbt node.
+         skip (Optional[Any]): The ``skip`` field from the results of the executed dbt node.
+         status (Optional[Union[str,int]]): The status of the executed dbt node (model).
+-        execution_time (float): The execution duration (in seconds) of the dbt node (model).
++        execution_time (Union[float,int]): The execution duration (in seconds) of the dbt node (model).
+         thread_id (str): The dbt thread identifier that executed the dbt node (model).
+         step_timings (List[StepTiming]): The timings for each step in the executed dbt node
+             (model).",Nit: this should actually always be float since we convert it before we construct the namedtuple.,"Should this be `Optional[Union[float,int]]`?"
+5015,"@@ -99,7 +99,13 @@ RocksEngine::RocksEngine(GraphSpaceID spaceId,
+         , dataPath_(folly::stringPrintf(""%s/nebula/%d"", dataPath.c_str(), spaceId)) {
+     auto path = folly::stringPrintf(""%s/data"", dataPath_.c_str());
+     if (FileUtils::fileType(path.c_str()) == FileType::NOTEXIST) {
+-        FileUtils::makeDir(path);
++        if (!FileUtils::makeDir(path)) {
++            LOG(FATAL) << ""makeDir "" << path << "" failed"";
++        }
++    }
++
++    if (FileUtils::fileType(path.c_str()) != FileType::DIRECTORY) {
++        LOG(FATAL) << path << "" is not directory"";
+     }
+ 
+     rocksdb::Options options;","The result of `FileUtils::fileType` could be saved, instead of calling twice.",Shouldn't this be `!FileUtils::makeDir(path)`?
+5016,"@@ -71,7 +71,10 @@ abstract class BaseProvider implements MediaProviderInterface
+             return;
+         }
+ 
+-        $this->doTransform($media);
++        try {
++            $this->doTransform($media);
++        } catch (\Exception $e) {
++        }
+     }
+ 
+     /**",Can you log the exception ?,Shouldn't we log something here?
+5017,"@@ -113,6 +113,9 @@ static int http_post(struct flb_out_http *ctx,
+                         ctx->host, ctx->port,
+                         ctx->proxy, 0);
+ 
++
++    flb_debug(""[http_client] proxy host: %s port: %i"", c->proxy.host, c->proxy.port);
++
+     /* Allow duplicated headers ? */
+     flb_http_allow_duplicated_headers(c, ctx->allow_dup_headers);
+ ","since this debug message is inside a plugin code, it should use flb_plg_debug(ctx->ins, ""...""), on this case don't need the component prefix since the API will put it there automatically","flb_debug(""[http_client] proxy h"
+5018,"@@ -25,10 +25,10 @@ import com.yahoo.athenz.common.server.util.ResourceUtils;
+ import com.yahoo.athenz.zts.ZTSConsts;
+ import com.yahoo.athenz.zts.cert.InstanceCertManager;
+ import com.yahoo.athenz.zts.store.DataStore;
++import com.yahoo.rdl.Timestamp;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ 
+-import java.sql.Timestamp;
+ import java.text.MessageFormat;
+ import java.util.*;
+ import java.util.stream.Collectors;","I also took advantage of the changes to change the Timestamps used in this notification from ""java.sql.Timestamp"" to ""com.yahoo.rdl.Timestamp"".",Why this change?
+5019,"@@ -23,6 +23,6 @@ import ""time""
+ const (
+ 	BrokerPort          = 4222
+ 	BrokerMaxReconnect  = -1
+-	BrokerReconnectWait = 4 * time.Second
++	BrokerReconnectWait = 1 * time.Second
+ 	BrokerTimeout       = 5 * time.Second
+ )","It would be nice all these tweaks to be configurable from cmd line, with sensible defaults",Why was this changed?
+5020,"@@ -147,9 +147,10 @@ class SQLServer(object):
+ 
+         if make_url(connection_string).drivername == 'sqlite+pysqlite':
+             # FIXME: workaround for locking errors
+-            return sqlalchemy.create_engine(connection_string,
+-                                            encoding='utf8',
+-                                            connect_args={'timeout': 600})
++            return sqlalchemy.create_engine(
++                connection_string,
++                encoding='utf8',
++                connect_args={'timeout': 600})
+         else:
+             return sqlalchemy.create_engine(connection_string,
+                                             encoding='utf8')",Why do we need this `check_same_thead` to be false? I feel a bit uncomfortable about this.,Black would make changes.
+5021,"@@ -318,6 +318,13 @@ module.exports = BaseTest.extend({
+ 
+             // Should have been multiplied by 100 in the constructor.
+             TestCase.assertEqual(object.intCol, 100);
++
++            // Should be able to create object by passing in constructor.
++            object = realm.create(CustomObject, {intCol: 2});
++            TestCase.assertTrue(object instanceof CustomObject);
++            TestCase.assertTrue(Object.getPrototypeOf(object) == CustomObject.prototype);
++            TestCase.assertEqual(customCreated, 2);
++            TestCase.assertEqual(object.intCol, 200);
+         });
+ 
+         TestCase.assertThrows(function() {","We should probably test with constructors which aren't in the schema, and functions which aren't constructors.",You can use `assert.sameV
+5022,"@@ -201,6 +201,19 @@ CudaHostPinnedSpace::CudaHostPinnedSpace() {}
+ // <editor-fold desc=""allocate()""> {{{1
+ 
+ void *CudaSpace::allocate(const size_t arg_alloc_size) const {
++  return allocate(""[unlabeled]"", arg_alloc_size);
++}
++void *CudaSpace::allocate(const char *
++#if defined(KOKKOS_ENABLE_PROFILING)
++                              arg_label
++#endif
++                          ,
++                          const size_t arg_alloc_size,
++                          const size_t
++#if defined(KOKKOS_ENABLE_PROFILING)
++                              arg_logical_size
++#endif
++                          ) const {
+   void *ptr = nullptr;
+ 
+   auto error_code = cudaMalloc(&ptr, arg_alloc_size);",this call doesn't work doesn't? I mean there doesn't seem to be an 2 argument allocate overload. Maybe arg_logical_size should just be defaulted to the arg_alloc_size thing. Or we should just report out physical allocation size instead of logical.,I think this should be `a
+5023,"@@ -32,7 +32,7 @@ module Beaker
+             'puppetbin'        => '/opt/puppet/bin/puppet',
+             'puppetbindir'     => '/opt/puppet/bin',
+             'puppetsbindir'    => '/opt/puppet/sbin',
+-            'privatebindir'    => '/opt/puppetlabs/puppet/bin',
++            'privatebindir'    => '/opt/puppet/bin',
+             'puppetvardir'     => '/var/opt/lib/pe-puppet',
+             'hieradatadir'     => '/var/lib/hiera',
+             'hieraconf'        => '/etc/puppetlabs/puppet/hiera.yaml',",This winds up flipping the desired values. Looks like I gave you a bum steer @kevpl,Why was this changed?
+5024,"@@ -106,13 +106,9 @@ func main() {
+ }
+ 
+ func initLogger(cfg config.Config) {
+-	addr, err := cfg.BlockchainAddress()
+-	if err != nil {
+-		glog.Fatalln(""Failed to get producer address from pub/kri key: "", err)
+-		return
+-	}
++	addr := cfg.ProducerAddress()
+ 	if err := log.InitGlobal(cfg.Log, zap.Fields(
+-		zap.String(""addr"", addr.String()),
++		zap.String(""iotexAddress"", addr.String()),
+ 		zap.String(""networkAddress"", fmt.Sprintf(""%s:%d"", cfg.Network.Host, cfg.Network.Port)),
+ 	)); err != nil {
+ 		glog.Println(""Cannot config global logger, use default one: "", err)",nit: let's call our address ioAddr from now on,nit: `iotexAddress` -> `producerAddress`
+5025,"@@ -12845,7 +12845,9 @@ bool CoreChecks::PreCallValidateGetBufferDeviceAddressEXT(VkDevice device, const
+ 
+ void CoreChecks::PreCallRecordGetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice,
+                                                           VkPhysicalDeviceProperties *pPhysicalDeviceProperties) {
+-    if (enabled.gpu_validation && enabled.gpu_validation_reserve_binding_slot) {
++    // There is an implicit layer that can cause this call to return 0 for maxBoundDescriptorSets - Ignore such calls
++    if (enabled.gpu_validation && enabled.gpu_validation_reserve_binding_slot &&
++        pPhysicalDeviceProperties->limits.maxBoundDescriptorSets > 0) {
+         if (pPhysicalDeviceProperties->limits.maxBoundDescriptorSets > 1) {
+             pPhysicalDeviceProperties->limits.maxBoundDescriptorSets -= 1;
+         } else {","You're killing this ""else"" case here which currently flags an error when maxBoundDescriptorSets == 0.",Shouldn't this be `> 0`?
+5026,"@@ -509,6 +509,16 @@ fill_refs_and_checksums_from_summary (GVariant    *summary,
+   return TRUE;
+ }
+ 
++static gboolean
++remove_null_checksum_refs (gpointer key,
++                           gpointer value,
++                           gpointer user_data)
++{
++  const char *checksum = value;
++
++  return (checksum == NULL);
++}
++
+ /* Given a summary file (@summary_bytes), extract the refs it lists, and use that
+  * to fill in the checksums in the @supported_ref_to_checksum map. This includes
+  * the main refs list in the summary, and the map of collection IDs to further",Nitpick: I'd append `_cb` to the function name here to mark it as a callback. Otherwise it looks a bit like this will do the entire job of removing null checksum refs from a hash table.,I don't think you need the parentheses h
+5027,"@@ -86,8 +86,7 @@ public class Catalog implements AutoCloseable {
+         tableMap = loadTables(db);
+       }
+       Collection<TiTableInfo> tables = tableMap.values();
+-      tables.removeIf(TiTableInfo::isView);
+-      return ImmutableList.copyOf(tables);
++      return tables.stream().filter(TiTableInfo::isNotView).collect(Collectors.toList());
+     }
+ 
+     public TiTableInfo getTable(TiDBInfo db, String tableName) {",or you can use `filter(x => !x.isView)`,Why do we need this change?
+5028,"@@ -133,7 +133,6 @@ func (c *Cluster) storageBootstrap(ctx context.Context) error {
+ 	}
+ 
+ 	return c.ReconcileBootstrapData(ctx, bytes.NewBuffer(data), &c.config.Runtime.ControlRuntimeBootstrap)
+-	//return bootstrap.WriteToDiskFromStorage(bytes.NewBuffer(data), &c.runtime.ControlRuntimeBootstrap)
+ }
+ 
+ // getBootstrapKeyFromStorage will list all keys that has prefix /bootstrap and will check for key that is","Instead of NewBuffer on the line above, do NewReader to avoid having to wrap later.",Why is this removed?
+5029,"@@ -182,6 +182,7 @@ class AsciiDoc:
+ 
+         asciidoc_args = ['--theme=qute', '-a toc', '-a toc-placement=manual']
+         self.call(modified_src, dst, *asciidoc_args)
++        # pylint: enable=too-many-locals,too-many-statements
+ 
+     def _build_website(self):
+         """"""Prepare and build the website.""""""","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",Why do we need to di
+5030,"@@ -733,7 +733,7 @@ func (eval *BlockEvaluator) transactionGroup(txgroup []transactions.SignedTxnWit
+ 		txibs = append(txibs, txib)
+ 
+ 		if eval.validate {
+-			groupTxBytes += len(protocol.Encode(&txib))
++			groupTxBytes += txib.GetEncodedLength()
+ 			if eval.blockTxBytes+groupTxBytes > eval.proto.MaxTxnBytesPerBlock {
+ 				return ErrNoSpace
+ 			}","extra brownie points ( overall solution ): we've currently triple-encoding the payset - 1. we encode it to calculate the block size. 2. we encode it to calculate the commit hash ( either via flat, or as Merkle tree ). 3. we encode it as a whole for the purpose of preparing the proposal ( I know that this isn't always the case, but this case happens to be on the critical path ). Caching the encoded data of the *first* block could help us repeating the process.",Why not use `len(txi
+5031,"@@ -849,8 +849,11 @@ describe Mongoid::Association::Depending do
+ 
+       it 'adds an error to the parent object' do
+         expect(person.delete).to be(false)
+-        expect(person.errors[:restrictable_posts].first).to be(
+-          Mongoid::Association::Depending::RESTRICT_ERROR_MSG)
++
++        key_message = ""#{Mongoid::Errors::MongoidError::BASE_KEY}.restrict_with_error_dependent_destroy""
++        expect(person.errors[:base].first).to eq(
++          ::I18n.translate(key_message, association: :restrictable_posts)
++        )
+       end
+     end
+ ","This assertion should use the actual expanded string, so that it is clear what the message produced looks like. Right now one has to run the code to determine what the message is.",Line is too long. [8
+5032,"@@ -18,6 +18,7 @@ package ec2
+ 
+ import (
+ 	""fmt""
++
+ 	""sigs.k8s.io/cluster-api/util/conditions""
+ 
+ 	errlist ""k8s.io/apimachinery/pkg/util/errors""","similar here for imports, these should be consolidated (and also consolidated with the grouping below)","""github.com/pkg/errors"""
+5033,"@@ -231,7 +231,7 @@ class LoadAnnotations:
+         self.with_seg = with_seg
+         self.poly2mask = poly2mask
+         self.file_client_args = file_client_args.copy()
+-        self.file_client = None
++        self.file_client = mmcv.FileClient(**self.file_client_args)
+ 
+     def _load_bboxes(self, results):
+         """"""Private function to load bounding box annotations.","Maybe there is no need to modify it. Because if you don't use the mask, it won't be initialized.",Why do we need this cha
+5034,"@@ -104,8 +104,7 @@ final class SelectTraceIdsFromSpan extends ResultSetFutureCall {
+       Input input =
+           new AutoValue_SelectTraceIdsFromSpan_Input(
+               serviceName,
+-              // % for like, bracing with ░ to ensure no accidental substring match
+-              ""%░"" + annotationKey + ""░%"",
++              annotationKey,
+               timestampRange.startUUID,
+               timestampRange.endUUID,
+               limit);",Is there a reason we wouldn't want the trailing `%`? I'm guessing that without the trailing `%` it will just do a strict match vs a partial prefix right?,Why did you remove this
+5035,"@@ -29,6 +29,13 @@
+ #include <opae/fpga.h>
+ #include <time.h>
+ #include ""fpga_dma.h""
++#include <getopt.h>
++#include <stdio.h>
++#include <stdint.h>
++#include <errno.h>
++#include <stdbool.h>
++#include <sys/stat.h>
++#include ""safe_string/safe_string.h""
+ /**
+  * \fpga_dma_test.c
+  * \brief User-mode DMA test",Please update the DMA test app in AFU repo once this gets approved.,Why is this header need
+5036,"@@ -57,8 +57,8 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend
+         $manager->persist(new SettingValue(PricingSetting::DEFAULT_DOMAIN_CURRENCY, $defaultCurrency->getId(), Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::DEFAULT_AVAILABILITY_IN_STOCK, $defaultInStockAvailability->getId(), SettingValue::DOMAIN_ID_COMMON));
+         $manager->persist(new SettingValue(PricingSetting::FREE_TRANSPORT_AND_PAYMENT_PRICE_LIMIT, null, Domain::FIRST_DOMAIN_ID));
+-        $manager->persist(new SettingValue(SeoSettingFacade::SEO_META_DESCRIPTION_MAIN_PAGE, 'ShopSys Framework - the best solution for your eshop.', Domain::FIRST_DOMAIN_ID));
+-        $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_MAIN_PAGE, 'ShopSys Framework - Title page', Domain::FIRST_DOMAIN_ID));
++        $manager->persist(new SettingValue(SeoSettingFacade::SEO_META_DESCRIPTION_MAIN_PAGE, 'Shopsys Framework - the best solution for your eshop.', Domain::FIRST_DOMAIN_ID));
++        $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_MAIN_PAGE, 'Shopsys Framework - Title page', Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(SeoSettingFacade::SEO_TITLE_ADD_ON, '| Demo eshop', Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::TERMS_AND_CONDITIONS_ARTICLE_ID, null, Domain::FIRST_DOMAIN_ID));
+         $manager->persist(new SettingValue(Setting::COOKIES_ARTICLE_ID, null, Domain::FIRST_DOMAIN_ID));",There should be a migration for that as well to reflect the change on in-production instances,Why is this changed?
+5037,"@@ -41,6 +41,7 @@ var _ = BeforeSuite(func() {
+ 	appName = fmt.Sprintf(""e2e-customizedenv-%d"", time.Now().Unix())
+ 	vpcConfig = client.EnvInitRequestVPCConfig{
+ 		CIDR:               ""10.1.0.0/16"",
++		AZs:                `""""`, // Use default AZ options.
+ 		PrivateSubnetCIDRs: ""10.1.2.0/24,10.1.3.0/24"",
+ 		PublicSubnetCIDRs:  ""10.1.0.0/24,10.1.1.0/24"",
+ 	}","Why does it have to be `""""` instead of an empty string  ",I think we can remov
+5038,"@@ -107,7 +107,7 @@ module RSpec
+         start(reporter)
+ 
+         begin
+-          unless pending
++          unless pending or RSpec.configuration.dry_run
+             with_around_each_hooks do
+               begin
+                 run_before_each","This is very strongly opinionated so feel free to disagree with me better, but as conditionals get more complex I like turn them into ifs instead of unlesses. What do you think?",I think this should 
+5039,"@@ -894,7 +894,7 @@ module RSpec
+       # @private
+       RANDOM_ORDERING = lambda do |list|
+         Kernel.srand RSpec.configuration.seed
+-        ordering = list.sort_by { Kernel.rand(list.size) }
++        ordering = list.shuffle
+         Kernel.srand # reset random generation
+         ordering
+       end",Will this obey the seed set on Kernel?,Why do we need this 
+5040,"@@ -23,16 +23,9 @@ Puppet::Functions.create_function(:add_facts) do
+         .from_issue_and_stack(Bolt::PAL::Issues::PLAN_OPERATION_NOT_SUPPORTED_WHEN_COMPILING, action: 'add_facts')
+     end
+ 
+-    inventory = Puppet.lookup(:bolt_inventory) { nil }
+-
+-    unless inventory
+-      raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
+-        Puppet::Pops::Issues::TASK_MISSING_BOLT, action: _('add facts')
+-      )
+-    end
+-
+-    executor = Puppet.lookup(:bolt_executor) { nil }
+-    executor&.report_function_call('add_facts')
++    inventory = Puppet.lookup(:bolt_inventory)
++    executor = Puppet.lookup(:bolt_executor)
++    executor.report_function_call('add_facts')
+ 
+     inventory.add_facts(target, facts)
+   end","We shouldn't use the `&.` syntax here, since we expect that `executor` will never be `nil`. For the functions that _can_ be called from apply / without an executor, `&.` is still appropriate.",Why remove this check?
+5041,"@@ -68,11 +68,12 @@ public class SurfaceNamer extends NameFormatterDelegator {
+ 
+   public String getNotImplementedString(String feature) {
+     return ""$ NOT IMPLEMENTED: "" + feature + "" $"";
++    //throw new RuntimeException(feature);
+   }
+ 
+   /** The full path to the source file  */
+   public String getSourceFilePath(String path, String className) {
+-    return getNotImplementedString(""SurfaceNamer.getSourceFilePath"");
++    return getNotImplementedString(""SurfaceNamer:getSourceFilePath"");
+   }
+ 
+   /** The name of the class that implements a particular proto interface. */",Why the switch from period to colon?,Remove this line.
+5042,"@@ -314,8 +314,9 @@ func environmentConfig() Config {
+ 	imageCleanupDisabled := utils.ParseBool(os.Getenv(""ECS_DISABLE_IMAGE_CLEANUP""), false)
+ 	minimumImageDeletionAge := parseEnvVariableDuration(""ECS_IMAGE_MINIMUM_CLEANUP_AGE"")
+ 	imageCleanupInterval := parseEnvVariableDuration(""ECS_IMAGE_CLEANUP_INTERVAL"")
+-	numImagesToDeletePerCycle, err := strconv.Atoi(os.Getenv(""ECS_NUM_IMAGES_DELETE_PER_CYCLE""))
+-	if err != nil {
++	numImagesToDeletePerCycleEnvVal := os.Getenv(""ECS_NUM_IMAGES_DELETE_PER_CYCLE"")
++	numImagesToDeletePerCycle, err := strconv.Atoi(numImagesToDeletePerCycleEnvVal)
++	if numImagesToDeletePerCycleEnvVal != """" && err != nil {
+ 		seelog.Warnf(""Invalid format for \""ECS_NUM_IMAGES_DELETE_PER_CYCLE\"", expected an integer. err %v"", err)
+ 	}
+ ","Can you just fix the warning instead? It's actually important for this to have a default of `""""` as the subsequent merges with `DefaultConfig()` and `fileConfig()` need to work. If you make this not `""""`, you break the assumptions of `Merge()`.",I don't think we need 
+5043,"@@ -23,5 +23,15 @@ namespace Nethermind.Baseline.Config
+     {
+         [ConfigItem(Description = ""If 'true' then the Baseline Module is enabled via JSON RPC"", DefaultValue = ""false"")]
+         bool Enabled { get; }
++
++        bool BaselineTreeDbCacheIndexAndFilterBlocks { get; set; }
++        ulong BaselineTreeDbBlockCacheSize { get; set; }
++        ulong BaselineTreeDbWriteBufferSize { get; set; }
++        uint BaselineTreeDbWriteBufferNumber { get; set; }
++
++        bool BaselineTreeMetadataDbCacheIndexAndFilterBlocks { get; set; }
++        ulong BaselineTreeMetadataDbBlockCacheSize { get; set; }
++        ulong BaselineTreeMetadataDbWriteBufferSize { get; set; }
++        uint BaselineTreeMetadataDbWriteBufferNumber { get; set; }
+     }
+-}
++}",let us not add this,I don't think this sho
+5044,"@@ -41,6 +41,13 @@ type Cgroup struct {
+ 
+ 	// Rootless tells if rootless cgroups should be used.
+ 	Rootless bool
++
++	// The host UID that should own the cgroup, or nil to accept
++	// the default ownership.  This should only be set when the
++	// cgroupfs is to be mounted read/write.
++	// Not all cgroup manager implementations support changing
++	// the ownership.
++	OwnerUID *int `json:""owner_uid,omitempty""`
+ }
+ 
+ type Resources struct {",Is there a need for group as well? crun sets both.,Why is this a pointer?
+5045,"@@ -62,9 +62,12 @@ namespace OpenTelemetry.Instrumentation.Dependencies.Tests
+         [Fact]
+         public async Task HttpDependenciesInstrumentationInjectsHeadersAsync()
+         {
+-            var spanProcessor = new Mock<SpanProcessor>();
+-            var tracer = TracerFactory.Create(b => b.AddProcessorPipeline(p => p.AddProcessor(_ => spanProcessor.Object)))
+-                .GetTracer(null);
++            var activityProcessor = new Mock<ActivityProcessor>();
++            using var shutdownSignal = OpenTelemetrySdk.EnableOpenTelemetry(b =>
++            {
++                b.SetProcessorPipeline(c => c.AddProcessor(ap => activityProcessor.Object));
++                b.AddHttpWebRequestDependencyInstrumentation();
++            });
+ 
+             var request = (HttpWebRequest)WebRequest.Create(this.url);
+ ","@cijothomas This build-up pattern was really confusing. It looks like internally ActivityProcessor is intended to be chained but there is nothing in the abstract class that enforces it. We never set a ""Next"" or make sure that the chain is called. Probably need to do some more work in this area?",Why do we need this?
+5046,"@@ -1206,6 +1206,11 @@ Schema.prototype.queue = function(name, args) {
+  *       console.log(this.getFilter());
+  *     });
+  *
++ *     // Equivalent to calling `pre()` on `save`, `findOneAndUpdate`.
++ *     toySchema.pre(['save', 'findOneAndUpdate'], function(next) {
++ *       console.log(this.getFilter());
++ *     });
++ *
+  * @param {String|RegExp} The method name or regular expression to match method name
+  * @param {Object} [options]
+  * @param {Boolean} [options.document] If `name` is a hook for both document and query middleware, set to `true` to run on document middleware.","`this.getFilter()` won't work on `pre('save')`. Perhaps make this `toySchema.pre(['updateOne', 'findOneAndUpdate'])`?",Can we remove this?
+5047,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+ 
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,This should be `159349
+5048,"@@ -67,18 +67,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal
+ 
+                     if (result.IsCancelled)
+                     {
+-                        // Send a FIN
+-                        _log.ConnectionWriteFin(_connectionId);
+-
+-                        using (var shutdownReq = new UvShutdownReq(_log))
+-                        {
+-                            shutdownReq.Init(_thread);
+-                            var shutdownResult = await shutdownReq.ShutdownAsync(_socket);
+-
+-                            _log.ConnectionWroteFin(_connectionId, shutdownResult.Status);
+-                        }
+-
+-                        // Ensure no data is written after uv_shutdown
+                         break;
+                     }
+ ",I think this is the only place where we use `UvShutdownReq`. Can we remove the type altogether? Or do you prefer to keep it around?,Why is this being removed?
+5049,"@@ -248,7 +248,7 @@ func (a *Agent) Attest() error {
+ 	// Configure TLS
+ 	// TODO: Pick better options here
+ 	tlsConfig := &tls.Config{
+-		RootCAs: a.Config.TrustBundle,
++		InsecureSkipVerify:true,
+ 	}
+ 	dialCreds := grpc.WithTransportCredentials(credentials.NewTLS(tlsConfig))
+ 	conn, err := grpc.Dial(a.Config.ServerAddress.String(), dialCreds)",I think we can get this to work by passing in the root ca cert fixture that upstream ca is using,nit: space after `:`
+5050,"@@ -219,6 +219,18 @@ static batch_job_id_t batch_job_condor_wait (struct batch_queue * q, struct batc
+ 		}
+ 	}
+ 
++	time_t current;
++	struct tm tm;
++
++	/* Obtain current year, in case HTCondor log lines do not provide a year.
++	   Note that this fallback may give the incorrect year for jobs that run
++	   when the year turns. However, we just need some value to give to a
++	   mktime below, and the current year is preferable than some fixed value.
++	   */
++	time(&current);
++	tm = *localtime(&current);
++	int current_year = tm.tm_year + 1900;
++
+ 	while(1) {
+ 		/*
+ 		   Note: clearerr is necessary to clear any cached end-of-file condition,",Just occurred to me to ask: is the condor log date in localtime or UTC?,I don't think this is the 
+5051,"@@ -686,7 +686,18 @@ public enum Varbits
+ 	/**
+ 	 * 1 is true, 0 is false.
+ 	 */
+-	GAUNTLET_ENTERED(9178);
++	GAUNTLET_ENTERED(9178),
++
++	/**
++	 * 1 if full of Mushrooms, 0 is empty.
++	 */
++	MUSHY_PIT(5809),
++
++	/**
++	 * Current location of Sulliuscep tree.
++	 */
++	SULLIUSCEP_LOCATION(5808);
++
+ 
+ 	/**
+ 	 * The raw varbit ID.",Can you remove the sculliscep varbits from here too?,This should be `MUSHY_PIT(
+5052,"@@ -1162,6 +1162,12 @@ function update_5_9_2018() {
+     "");
+ }
+ 
++function update_8_23_2018() {
++    $retval = do_query(""alter table host add index host_cpid (host_cpid)"");
++    return $retval && do_query(""alter table host add index host_domain_name (domain_name)"");
++}
++
++
+ // Updates are done automatically if you use ""upgrade"".
+ //
+ // If you need to do updates manually,",I understand that it is a common practice in this script to add indexes this way but why don't we check index existence before adding it? I'm not very familiar with MySql but it's can be done easily in MSSQL and I'm pretty sure that there is a way to do the same here.,Please add a new line at the end of the file.
+5053,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+ 
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,`duraton` -> `duration`
+5054,"@@ -47,8 +47,7 @@
+ 
+ void h2o_mruby__abort_exc(mrb_state *mrb, const char *mess, const char *file, int line)
+ {
+-    h2o_error_printf(""%s at file: \""%s\"", line %d: %s\n"", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc))));
+-    abort();
++    h2o_fatal(""%s at file: \""%s\"", line %d: %s\n"", mess, file, line, RSTRING_PTR(mrb_inspect(mrb, mrb_obj_value(mrb->exc))));
+ }
+ 
+ mrb_value h2o_mruby__new_str(mrb_state *mrb, const char *s, size_t len, int is_static, const char *file, int line)","Should we do something like `h2o__fatal(file, line, ""fatal error: %s, %s\n"", mess, RSTRING_PTR(...))` here?",Shouldn't this be an error?
+5055,"@@ -24,7 +24,8 @@ describe('monitoring', function () {
+     return mock.createServer().then(server => (mockServer = server));
+   });
+ 
+-  it('should record roundTripTime', function (done) {
++  // TODO: NODE-3819: Unskip flaky tests.
++  it.skip('should record roundTripTime', function (done) {
+     mockServer.setMessageHandler(request => {
+       const doc = request.document;
+       if (isHello(doc)) {",is this one all platforms?,Why are we skipping these tests?
+5056,"@@ -72,7 +72,7 @@ func TestBytes(t *testing.T) {
+ 	t.Run(""not found"", func(t *testing.T) {
+ 		jsonhttptest.Request(t, client, http.MethodGet, resource+""/abcd"", http.StatusNotFound,
+ 			jsonhttptest.WithExpectedJSONResponse(jsonhttp.StatusResponse{
+-				Message: ""not found"",
++				Message: ""Not Found"",
+ 				Code:    http.StatusNotFound,
+ 			}),
+ 		)",why capitals grr?,Why did this change?
+5057,"@@ -0,0 +1,17 @@
++package nameserver
++
++import (
++	. ""github.com/zettio/weave/common""
++)
++
++func checkFatal(e error) {
++	if e != nil {
++		Error.Fatal(e)
++	}
++}
++
++func checkWarn(e error) {
++	if e != nil {
++		Warning.Println(e)
++	}
++}",Surely all the above should go into `common`.,Why do we need this?
+5058,"@@ -249,7 +249,6 @@ def test_failing_unwatch(qtbot, caplog, monkeypatch):
+     assert caplog.records[-1].msg == message
+ 
+ 
+-
+ @pytest.mark.parametrize('text, caret_position, result', [
+     ('', 0, (1, 1)),
+     ('a', 0, (1, 1)),","This is an unrelated change, but was failing CI... probably introduced in master.",Why was this removed
+5059,"@@ -30,7 +30,10 @@ double getAlignmentTransform(const ROMol &prbMol, const ROMol &refMol,
+   if (atomMap == 0) {
+     // we have to figure out the mapping between the two molecule
+     MatchVectType match;
+-    if (SubstructMatch(refMol, prbMol, match)) {
++    const bool recursionPossible = true;
++    const bool useChirality = false;
++    const bool useQueryQueryMatches = true;
++    if (SubstructMatch(refMol, prbMol, match, recursionPossible, useChirality, useQueryQueryMatches)) {
+       MatchVectType::const_iterator mi;
+       for (mi = match.begin(); mi != match.end(); mi++) {
+         prbPoints.push_back(&prbCnf.getAtomPos(mi->first));","This piece isn't backwards compatible, but it's enough of an edge case that I think it's unlikely to be a problem.",I think this should 
+5060,"@@ -81,8 +81,9 @@ import (
+ var endPoint = ""pubsub.googleapis.com:443""
+ 
+ var sendBatcherOpts = &batcher.Options{
+-	MaxBatchSize: 1000, // The PubSub service limits the number of messages in a single Publish RPC
+-	MaxHandlers:  2,
++	MaxBatchSize:     1000, // The PubSub service limits the number of messages in a single Publish RPC
++	MaxHandlers:      2,
++	MaxBatchByteSize: 10 * 1000 * 1000, // The PubSub service limits the size of request body in a single Publish RPC
+ }
+ 
+ var defaultRecvBatcherOpts = &batcher.Options{",MB is presumably 1024 * 1024.,Why do we need to increase the batch size?
+5061,"@@ -22,6 +22,12 @@
+ import DashboardSplashMain from 'GoogleComponents/dashboard-splash/dashboard-splash-main';
+ import { Suspense as ReactSuspense, lazy as ReactLazy } from 'react';
+ 
++/**
++ * WordPress dependencies
++ */
++import { Component, Fragment, Suspense as WPSuspense, lazy as WPlazy } from '@wordpress/element';
++import { __ } from '@wordpress/i18n';
++
+ /**
+  * Internal dependencies
+  */",Didn't we extract this logic to a `react-features` helper?,I think we can remove the `lazy` import he
+5062,"@@ -24,8 +24,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Filter.Internal
+ 
+         private bool _canWrite = true;
+ 
+-        private object _writeLock = new object();
+-
+         public StreamSocketOutput(string connectionId, Stream outputStream, MemoryPool memory, IKestrelTrace logger)
+         {
+             _connectionId = connectionId;","But But, overlapping async writes will get corrupted  ",Why did you remove this?
+5063,"@@ -9,6 +9,7 @@ import (
+ 
+ 	""github.com/filecoin-project/go-filecoin/address""
+ 	""github.com/filecoin-project/go-filecoin/chain""
++	""github.com/filecoin-project/go-filecoin/config""
+ 	""github.com/filecoin-project/go-filecoin/metrics""
+ 	""github.com/filecoin-project/go-filecoin/types""
+ )","Not your immediate problem, but having everything depend on a package that has the config for everything else is ick. Can you move the MessagePoolConfig here and reverse the dependency?","""github.com/ipfs/go-cid"""
+5064,"@@ -443,9 +443,6 @@ public class PasscodeActivityTest extends
+                     v.onEditorAction(actionCode);
+                 }
+             });
+-            waitSome();
+-            //the enter key will send ACTION_DOWN and ACTION_UP both events out
+-            this.sendKeys(KeyEvent.KEYCODE_ENTER);
+         } catch (Throwable t) {
+             fail(""Failed do editor action "" + actionCode);
+         }","recently, IME_ACTION_GO action can trigger key_down and key_up event successfully, so we don't need to send enter key separately as before, otherwise will trigger it twice and cause to enter empty passcode, which cause test failed.",Why was this removed?
+5065,"@@ -46,6 +46,7 @@ Status FindPathValidator::validateWhere(WhereClause* where) {
+   }
+   where->setFilter(ExpressionUtils::rewriteLabelAttr2EdgeProp(expr));
+   auto filter = where->filter();
++  NG_RETURN_IF_ERROR(checkExprDepth(filter));
+ 
+   auto typeStatus = deduceExprType(filter);
+   NG_RETURN_IF_ERROR(typeStatus);",It seems that you only need to do this `checkExprDepth()` inside `deduceExprType()`. So you don't have to add this check everywhere.,Why do we need this c
+5066,"@@ -95,7 +95,8 @@ public class DefaultMailCreatorTest {
+     executableFlow.setStatus(Status.FAILED);
+     assertTrue(mailCreator.createErrorEmail(
+         executableFlow, message, azkabanName, scheme, clientHostname, clientPortNumber));
+-    assertEquals(""Flow 'mail-creator-test' has failed on unit-tests"", message.getSubject());
++    assertEquals(""Flow 'mail-creator-test' has failed on unit-tests"",
++        message.getSubject());
+     assertEquals(read(""errorEmail.html""), message.getBody());
+   }
+ ",why split into two lines?,Why this change?
+5067,"@@ -48,8 +48,7 @@ import org.apache.iceberg.types.Types;
+  * represented by a named {@link PartitionField}.
+  */
+ public class PartitionSpec implements Serializable {
+-  // start assigning IDs for partition fields at 1000
+-  private static final int PARTITION_DATA_ID_START = 1000;
++  public static final int PARTITION_DATA_ID_START = 1000;
+ 
+   private final Schema schema;
+ ",Does this need to be public or can it be package-private?,Why is this public?
+5068,"@@ -86,6 +86,11 @@ class FileCard extends Component {
+   render () {
+     const file = this.props.files[this.props.fileCardFor]
+ 
++    let showEditButton
++    this.props.editors.forEach((target) => {
++      showEditButton = this.props.getPlugin(target.id).сanEditFile(file)
++    })
++
+     return (
+       <div
+         class=""uppy-Dashboard-FileCard""", Questionable way of looping through editors and calling `canEditFile` to show the edit button. Is there a better way?,I don't think you need the `forEach` here
+5069,"@@ -313,8 +313,14 @@ public class IntMultimap<T> implements Traversable<T>, Serializable {
+ 
+     @Override
+     public <U> Seq<Tuple2<T, U>> zip(Iterable<? extends U> that) {
++        return zipWith(that, Tuple::of);
++    }
++
++    @Override
++    public <U, R> Seq<R> zipWith(Iterable<? extends U> that, BiFunction<? super T, ? super U, ? extends R> mapper) {
+         Objects.requireNonNull(that, ""that is null"");
+-        return Stream.ofAll(iterator().zip(that));
++        Objects.requireNonNull(mapper, ""mapper is null"");
++        return Stream.ofAll(iterator().zipWith(that, mapper));
+     }
+ 
+     @Override",`that is null` doesn't sound very useful to me. Could we rename `that` to `target` or something less context dependent :)?,nit: `zipWith` -> `zipWith`
+5070,"@@ -436,6 +436,7 @@ class Status(AbstractCommand):
+         print(x)
+         print
+         self.molecule._print_valid_platforms()
++        print
+         self.molecule._print_valid_providers()
+ 
+ ","Just to be consistent, can we use the print function `print()` instead of the keyword. Same goes for line 437.",Why this change?
+5071,"@@ -27,11 +27,17 @@ func SetupGenesisNode(ctx context.Context, node *fat.Filecoin, gcURI string, min
+ 		return err
+ 	}
+ 
+-	if _, err := node.WalletImport(ctx, minerOwner); err != nil {
++	wallet, err := node.WalletImport(ctx, minerOwner)
++	if err != nil {
+ 		return err
+ 	}
+ 
+-	if _, err := node.MinerUpdatePeerid(ctx, minerAddress, node.PeerID, fat.AOPrice(big.NewFloat(300)), fat.AOLimit(300)); err != nil {
++	if err := node.ConfigSet(ctx, ""wallet.defaultAddress"", wallet[0].String()); err != nil {
++		return err
++	}
++
++	_, err = node.MinerUpdatePeerid(ctx, minerAddress, node.PeerID, fat.AOFromAddr(wallet[0]), fat.AOPrice(big.NewFloat(300)), fat.AOLimit(300))
++	if err != nil {
+ 		return err
+ 	}
+ ","Having to pass in `price` and `limit` is pretty common. Do we want to have this be another argument, maybe a combined structure that can be used for every action that requires it?","Shouldn't this be `node.ConfigSet(""wallet"
+5072,"@@ -30,9 +30,17 @@ export class ComicsPlayer {
+         return this.setCurrentSrc(elem, options);
+     }
+ 
++    destroy() {
++        // Nothing to do here
++    }
++
+     stop() {
+         this.unbindEvents();
++        const stopInfo = {
++            src: this.item
++        };
+ 
++        Events.trigger(this, 'stopped', [stopInfo]);
+         this.archiveSource?.release();
+ 
+         const elem = this.mediaElement;",Could you move it after `stop`?,Why do we need to do this?
+5073,"@@ -49,10 +49,10 @@ public final class ClassUtils {
+ 
+   // 将一系列body parameter包装成一个class
+   public static Class<?> getOrCreateBodyClass(OperationGenerator operationGenerator,
+-      List<BodyParameter> bodyParameters) {
++      List<BodyParameter> bodyParameters, String bodyParamName) {
+     SwaggerGenerator swaggerGenerator = operationGenerator.getSwaggerGenerator();
+     Method method = operationGenerator.getProviderMethod();
+-    String clsName = swaggerGenerator.ensureGetPackageName() + ""."" + method.getName() + ""Body"";
++    String clsName = swaggerGenerator.ensureGetPackageName() + ""."" + bodyParamName;
+     Class<?> cls = getClassByName(swaggerGenerator.getClassLoader(), clsName);
+     if (cls != null) {
+       return cls;",The variable `method` seems not used. Maybe we can remove the parameter `bodyParamName` and generate it by invoking `ParamUtils.generateBodyParameterName(method)` ?,"`method.getName() + ""Body"""
+5074,"@@ -57,7 +57,6 @@ import static org.apache.solr.cloud.OverseerCollectionMessageHandler.NUM_SLICES;
+ import static org.apache.solr.common.cloud.ZkStateReader.MAX_SHARDS_PER_NODE;
+ import static org.apache.solr.common.cloud.ZkStateReader.REPLICATION_FACTOR;
+ 
+-@Slow
+ public class ShardSplitTest extends BasicDistributedZkTest {
+ 
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());",I don't think this should be here?,Why did you remove this?
+5075,"@@ -26,8 +26,9 @@ type SyscallsImpl interface {
+ 	HashBlake2b(data []byte) [32]byte
+ 	ComputeUnsealedSectorCID(ctx context.Context, proof abi.RegisteredProof, pieces []abi.PieceInfo) (cid.Cid, error)
+ 	VerifySeal(ctx context.Context, info abi.SealVerifyInfo) error
+-	VerifyPoSt(ctx context.Context, info abi.PoStVerifyInfo) error
+-	VerifyConsensusFault(ctx context.Context, h1, h2, extra []byte, head block.TipSetKey, view SyscallsStateView, earliest abi.ChainEpoch) (*specsruntime.ConsensusFault, error)
++	VerifyWinningPoSt(ctx context.Context, info abi.WinningPoStVerifyInfo) error
++	VerifyPoSt(ctx context.Context, info abi.WindowPoStVerifyInfo) error
++	VerifyConsensusFault(ctx context.Context, h1, h2, extra []byte, head block.TipSetKey, view SyscallsStateView) (*specsruntime.ConsensusFault, error)
+ }
+ 
+ type syscalls struct {",Either I'm missing something or specs actors should remove this call cc @anorth,Why did you remove the `ea
+5076,"@@ -119,12 +119,12 @@ namespace Reporting
+                 var counterWidth = Math.Max(test.Counters.Max(c => c.Name.Length) + 1, 15);
+                 var resultWidth = Math.Max(test.Counters.Max(c => c.Results.Max().ToString(""F3"").Length + c.MetricName.Length) + 2, 15);
+                 ret.AppendLine(test.Name);
+-                ret.AppendLine($""{LeftJustify(""Metric"", counterWidth)}|{LeftJustify(""Average"",resultWidth)}|{LeftJustify(""Min"", resultWidth)}|{LeftJustify(""Max"",resultWidth)}"");
++                ret.AppendLine($""{LeftJustify(""Metric"", counterWidth)}|{LeftJustify(""Average"", resultWidth)}|{LeftJustify(""Min"", resultWidth)}|{LeftJustify(""Max"", resultWidth)}"");
+                 ret.AppendLine($""{new String('-', counterWidth)}|{new String('-', resultWidth)}|{new String('-', resultWidth)}|{new String('-', resultWidth)}"");
+ 
+-           
++
+                 ret.AppendLine(Print(defaultCounter, counterWidth, resultWidth));
+-                foreach(var counter in topCounters)
++                foreach (var counter in topCounters)
+                 {
+                     ret.AppendLine(Print(counter, counterWidth, resultWidth));
+                 }",Please undo all these changes as they are white-space only.,nit: space after `foreach`
+5077,"@@ -114,9 +114,11 @@ final class CountryConfigurator implements FieldConfiguratorInterface
+     private function generateFormTypeChoices(string $countryCodeFormat): array
+     {
+         $choices = [];
++        $countriesAlpha2 = Countries::getNames();
+         $countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : Countries::getNames();
+         foreach ($countries as $countryCode => $countryName) {
+-            $flagImageName = \in_array($countryCode, self::FLAGS_WITH_IMAGE_FILE, true) ? $countryCode : 'UNKNOWN';
++            $countryCodeAlpha2 = array_search($countryName, $countriesAlpha2, true);
++            $flagImageName = \in_array($countryCodeAlpha2, self::FLAGS_WITH_IMAGE_FILE, true) ? $countryCodeAlpha2 : 'UNKNOWN';
+             $flagImagePath = $this->assetPackages->getUrl(sprintf('bundles/easyadmin/images/flags/%s.png', $flagImageName));
+             $choiceKey = sprintf('<img src=""%s"" class=""country-flag"" loading=""lazy"" alt=""%s""> %s', $flagImagePath, $countryName, $countryName);
+ ",You forgot an optimization? `$countries = CountryField::FORMAT_ISO_3166_ALPHA3 === $countryCodeFormat ? Countries::getAlpha3Names() : $countriesAlpha2;`,`$countryNameAlpha2 = arra
+5078,"@@ -311,7 +311,7 @@ def _comment(string):
+ def _format_option_value(optdict, value):
+     """"""return the user input's value from a 'compiled' value""""""
+     if optdict.get(""type"", None) == ""py_version"":
+-        value = ""."".join(str(item) for item in value)
++        value = ""current Python interpreter version (e.g., '3.8')""
+     elif isinstance(value, (list, tuple)):
+         value = "","".join(_format_option_value(optdict, item) for item in value)
+     elif isinstance(value, dict):",Shouldn't this also return the current value specified by the user? At least that's what the docstring says and what the previous version did.,"I think this should be ""cu"
+5079,"@@ -95,6 +95,9 @@ def get_listens(user_name):
+     :param max_ts: If you specify a ``max_ts`` timestamp, listens with listened_at less than (but not including) this value will be returned.
+     :param min_ts: If you specify a ``min_ts`` timestamp, listens with listened_at greater than (but not including) this value will be returned.
+     :param count: Optional, number of listens to return. Default: :data:`~webserver.views.api.DEFAULT_ITEMS_PER_GET` . Max: :data:`~webserver.views.api.MAX_ITEMS_PER_GET`
++    :param time_range: This parameter determines the time range the listen search. Each increment of the time_range corresponds to a range of 5 days and the default
++                       time_range of 3 means that 15 days will be searched. 
++                       Default: :data:`~webserver.views.api.DEFAULT_TIME_RANGE` . Max: :data:`~webserver.views.api.MAX_TIME_RANGE`
+     :statuscode 200: Yay, you have data!
+     :resheader Content-Type: *application/json*
+     """"""",> the time range the listen search the time range of the listen search?,This should be `:param int
+5080,"@@ -777,6 +777,8 @@ read_evex(byte *pc, decode_info_t *di, byte instr_byte,
+         NULL_TERMINATE_BUFFER(pc_addr);
+         DO_ONCE(SYSLOG(SYSLOG_ERROR, AVX_512_SUPPORT_INCOMPLETE, 2,
+                        get_application_name(), get_application_pid(), pc_addr));
++        if (ZMM_ENABLED())
++            dynamo_preserve_zmm_caller_saved = true;
+ #endif
+         info = &evex_prefix_extensions[0][1];
+     } else {","This snprintf, etc. needs to all be inside the DO_ONCE: all this overhead happening on every single decode is likely a huge performance hit.",Why do we need this?
+5081,"@@ -50,6 +50,7 @@ Cluster Options:
+         --routes <rurl-1, rurl-2>    Routes to solicit and connect
+         --cluster <cluster-url>      Cluster URL for solicited routes
+         --no_advertise <bool>        Advertise known cluster IPs to clients
++        --conn_retries <number>      For implicit routes, number of connect retries
+ 
+ 
+ Common Options:",would call it connect_retries,I think this should 
+5082,"@@ -3717,3 +3717,15 @@ class DataFrameTest(ReusedSQLTestCase, SQLTestUtils):
+ 
+         for p_items, k_items in zip(pdf.iteritems(), kdf.iteritems()):
+             self.assert_eq(repr(p_items), repr(k_items))
++
++    def test_tail(self):
++        if LooseVersion(pyspark.__version__) >= LooseVersion(""3.0""):
++            pdf = pd.DataFrame(range(1000))
++            kdf = ks.from_pandas(pdf)
++
++            self.assert_eq(repr(pdf.tail()), repr(kdf.tail()))
++            self.assert_eq(repr(pdf.tail(10)), repr(kdf.tail(10)))
++            self.assert_eq(repr(pdf.tail(-990)), repr(kdf.tail(-990)))
++            self.assert_eq(repr(pdf.tail(0)), repr(kdf.tail(0)))
++            with self.assertRaisesRegex(TypeError, ""bad operand type for unary -: 'str'""):
++                kdf.tail(""10"")",Why are we using `repr`?,I think you can use 
+5083,"@@ -21,6 +21,6 @@ class ZMSBinder extends AbstractBinder {
+ 
+     @Override
+     protected void configure() {
+-        bind(new ZMSImpl()).to(ZMSHandler.class);
++        bind(ZMSImplFactory.getZmsInstance()).to(ZMSHandler.class);
+     }
+ }",I use the same zms instance to check authentication in swagger endpoints. Same thing in ZTS.,Why do we need this 
+5084,"@@ -114,7 +114,11 @@ public class JavaProcessJobTest {
+     props.put(CommonJobProperties.JOB_ID, ""test_job"");
+     props.put(CommonJobProperties.EXEC_ID, ""123"");
+     props.put(CommonJobProperties.SUBMIT_USER, ""test_user"");
+-    props.put(""execute.as.user"", ""false"");
++
++    //The execute-as-user binary requires special permission. It's not convenient to

++    //set up in a unit test that is self contained. So EXECUTE_AS_USER is set to false

++    //so that we don't have to rely on the binary file to change user in the test case.
++    props.put(ProcessJob.EXECUTE_AS_USER, ""false"");
+ 
+     job = new JavaProcessJob(""testJavaProcess"", props, props, log);
+   }",Consider consolidating the common code in a common setup method in tests?,Why is this needed?
+5085,"@@ -18,7 +18,7 @@ import static org.assertj.core.api.Assertions.assertThat;
+ import static org.mockito.Mockito.verifyNoInteractions;
+ 
+ import org.hyperledger.besu.ethereum.eth.EthProtocolConfiguration;
+-import org.hyperledger.besu.util.number.PositiveNumber;
++import org.hyperledger.besu.ethereum.eth.ImmutableEthProtocolConfiguration;
+ 
+ import org.junit.Test;
+ ",q: do you need to run the annotation processor over EthProtocolConfiguration prior to writing this file? (i.e.to ensure ImmutableEthProtcolConfiguration exists)? Does Auto-import etc. still work in the IDE?,Why is this change 
+5086,"@@ -69,12 +69,12 @@ public class SchemaTypeTable implements ImportTypeTable, SchemaTypeFormatter {
+   }
+ 
+   @Override
+-  public String getNicknameFor(Schema type) {
++  public String getNicknameFor(DiscoveryField type) {
+     return typeNameConverter.getTypeName(type).getNickname();
+   }
+ 
+   @Override
+-  public String getFullNameFor(Schema type) {
++  public String getFullNameFor(DiscoveryField type) {
+     return typeFormatter.getFullNameFor(type);
+   }
+ ",What is the motivation for switching from `Schema` to `DiscoveryField` everywhere?,Why is this change 
+5087,"@@ -353,6 +353,8 @@ func environmentConfig() (Config, error) {
+ 			errs = append(errs, err)
+ 		}
+ 	}
++	containerMetadataEnabled := utils.ParseBool(os.Getenv(""ECS_ENABLE_CONTAINER_METADATA""), false)
++	dataDirOnHost := os.Getenv(""ECS_HOST_DATA_DIR"")
+ 
+ 	if len(errs) > 0 {
+ 		err = utils.NewMultiError(errs...)","What happens when ECS Init/whatever's starting the Agent mounts some other directory as Agent's data directory (`-v /tmp:/data`) sets `ECS_HOST_DATA_DIR` to `""/var/lib/ecs""` It doesn't seem like a strong enough abstraction to be dependent on Agent configuration options to expect `ECS_HOST_DATA_DIR` to be the same as whatever's being mounted as `/data` on the host. My main concern is the late-binding/asynchronous failures this could lead to if the wrong host mount was specified. Wondering if there are better alternatives here. Can we at the very least inspect the Agent container and check if `ECS_HOST_DATA_DIR` is mounted? If the answer is that we'll revisit the validation here at some latter stage, that's fine too. But, I want us to be aware of potential failures here.",Why do we need this
+5088,"@@ -54,6 +54,11 @@ eprint_version(void)
+ #else
+     const char *has_dbus = ""✘"";
+ #endif
++#ifdef WITH_XCB_ERRORS
++    const char *has_xcb_errors = ""✔"";
++#else
++    const char *has_xcb_errors = ""✘"";
++#endif
+ #ifdef HAS_EXECINFO
+     const char *has_execinfo = ""✔"";
+ #else","btw that's obviously out of scope of this PR but since i noticed this line here it reminded me a thing: on some systems i've noticed the font didn't had those characters, so it was just a square or empty space and sometimes they're just a bit shifted in position (if font doesn't have them and using from fallback font which have incompatible dimensions of characters) how do you think is it worth creating an issue to discuss/address it or it could just waste time on bikeshedding?",Shouldn't this be `#ifdef WITH_XCB_ERRORS`?
+5089,"@@ -21,6 +21,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/server/itx""
++	recoverutil ""github.com/iotexproject/iotex-core/tools/util""
+ )
+ 
+ // recoveryHeight is the blockchain height being recovered to",alias is not needed,"""github.com/pkg/errors"""
+5090,"@@ -19,7 +19,7 @@ DEFINE_int32(num_accept_threads, 1, ""Number of threads to accept incoming connec
+ DEFINE_bool(reuse_port, true, ""Whether to turn on the SO_REUSEPORT option"");
+ DEFINE_int32(listen_backlog, 1024, ""Backlog of the listen socket"");
+ DEFINE_string(listen_netdev, ""any"", ""The network device to listen on"");
+-DEFINE_string(pid_file, ""nebula-graphd.pid"", ""File to hold the process id"");
++DEFINE_string(pid_file, ""pids/nebula-graphd.pid"", ""File to hold the process id"");
+ 
+ DEFINE_bool(redirect_stdout, true, ""Whether to redirect stdout and stderr to separate files"");
+ DEFINE_string(stdout_log_file, ""graphd-stdout.log"", ""Destination filename of stdout"");",Do we need to include the path?,This should be `pids/nebula-graphd.pid`
+5091,"@@ -1254,8 +1254,8 @@ func (js *jetStream) monitorStream(mset *stream, sa *streamAssignment) {
+ 
+ 	const (
+ 		compactInterval = 2 * time.Minute
+-		compactSizeMin  = 32 * 1024 * 1024
+-		compactNumMin   = 4
++		compactSizeMin  = 64 * 1024 * 1024
++		compactNumMin   = 8192
+ 	)
+ 
+ 	t := time.NewTicker(compactInterval)","During our zoom and working on this, I said that I believe it was set to 64MB, not 32MB, but the diff shows that I was wrong. So we could change it back to 32MB.",Why did you change this?
+5092,"@@ -1,5 +1,7 @@
+ package platform
+ 
++import ""log""
++
+ // App is an interface apps for Drud Local must implement to use shared functionality
+ type App interface {
+ 	Init(string) error","Here I thought you always insisted on ` log ""github.com/Sirupsen/logrus"" ` :) I might do a PR that just globally switches that out wherever we have log.",Why do we need this?
+5093,"@@ -495,10 +495,9 @@ type KeyMetadata interface {
+ 	GetTlfHandle() *TlfHandle
+ 
+ 	// HasKeyForUser returns whether or not the given user has
+-	// keys for at least one device at the given key
+-	// generation. Returns false if the TLF is public, or if the
+-	// given key generation is invalid.
+-	HasKeyForUser(keyGen KeyGen, user keybase1.UID) bool
++	// keys for at least one device. Returns an error if the TLF
++	// is public.
++	HasKeyForUser(user keybase1.UID) (bool, error)
+ 
+ 	// GetTLFCryptKeyParams returns all the necessary info to
+ 	// construct the TLF crypt key for the given key generation,","We maintain that each (logical) key generation has the same set of device keys, so no need to plumb through `keyGen`.",I think this should 
+5094,"@@ -96,6 +96,7 @@ setup(
+         'dev': [
+             ""Flask>=0.10.1, <0.13"",
+             ""flake8>=3.2.1, <3.4"",
++            ""mock>=2.0.0, <3.0"",
+             ""mypy>=0.501, <0.502"",
+             ""rstcheck>=2.2, <4.0"",
+             ""tox>=2.3, <3"",",Please use `from unittest import mock` instead of this package.,This should be `mock
+5095,"@@ -405,6 +405,11 @@ Aggregate.prototype.exec = function (callback) {
+ 
+   prepareDiscriminatorPipeline(this);
+ 
++  if (this.options.cursor)
++    return this._model
++      .collection
++      .aggregate(this._pipeline, this.options || {});
++
+   this._model
+     .collection
+     .aggregate(this._pipeline, this.options || {}, promise.resolve.bind(promise));","Should be `if (this.options && this.options.cursor) {`. Options may be undefined. Also, going forward, mongoose will always use curly braces around if blocks.",Why do we need this?
+5096,"@@ -68,7 +68,7 @@ Rails.application.configure do
+   config.action_mailer.raise_delivery_errors = false
+   # config.action_mailer.perform_deliveries = true
+   config.action_mailer.delivery_method = :letter_opener_web
+-  config.action_mailer.smtp_settings = { address: 'mailrelay.blackducksoftware.com',
++  config.action_mailer.smtp_settings = { address: 'mailhost.synopsys.com',
+                                          openssl_verify_mode: OpenSSL::SSL::VERIFY_NONE }
+ 
+   # Enable locale fallbacks for I18n (makes lookups for any locale fall back to","This should remain as mailrelay.blackducksoftware.com for staging. Not sure this will be valid, but it shouldn't go through the production mail server.",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+5097,"@@ -74,6 +74,9 @@ namespace Microsoft.AspNet.Server.Kestrel.Infrastructure
+         /// </summary>
+         public MemoryPoolBlock2 Next { get; set; }
+ 
++#if DEBUG
++        // See http://www.philosophicalgeek.com/2014/09/29/digging-into-net-object-allocation-fundamentals/ 
++        // for the cost of including a finalizer
+         ~MemoryPoolBlock2()
+         {
+             Debug.Assert(!_pinHandle.IsAllocated, ""Ad-hoc memory block wasn't unpinned"");",Maybe we should have a Debug.Assert for when `Slab != null` to ensure that we are always returning the block (in our tests at least).,Why is this needed?
+5098,"@@ -106,10 +106,9 @@ options.vnode = vnode => {
+ 	if (typeof type != 'function') {
+ 		// Apply defaultValue to value
+ 		if (props.defaultValue) {
+-			if (!props.value && props.value !== 0) {
++			if (props.value == null && props.value !== 0) {
+ 				props.value = props.defaultValue;
+ 			}
+-			delete props.defaultValue;
+ 		}
+ 
+ 		// Add support for array select values: <select value={[]} />","Okay sorry about this I was really confused on how to support uncontrolled in this case, so what we want to do is apply `defaultValue` when `props.value` is falsy but not undefined, right? In the case of us seeing it is controlled (value & onChange present) we apply defaultValue to `props.value` (and delete props.defaultValue) In the case of uncontrolled we shouldn't enter this branch at all and go for full native dom behavior",Why was this removed?
+5099,"@@ -25,9 +25,12 @@ import { getTimeInSeconds, numberFormat } from 'GoogleUtil';
+ import { getDataTableFromData, TableOverflowContainer } from 'GoogleComponents/data-table';
+ import PreviewTable from 'GoogleComponents/preview-table';
+ 
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+ 
+ class SearchConsoleDashboardWidgetKeywordTable extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies,This should be `import { Component } from '@wordpress/element';`
+5100,"@@ -58,12 +58,13 @@ const (
+ type LabelSelector string
+ 
+ const (
+-	MayaAPIServerLabelSelector           LabelSelector = ""name=maya-apiserver""
+-	OpenEBSProvisionerLabelSelector      LabelSelector = ""name=openebs-provisioner""
+-	OpenEBSSnapshotOperatorLabelSelector LabelSelector = ""name=openebs-snapshot-operator""
+-	OpenEBSAdmissionServerLabelSelector  LabelSelector = ""app=admission-webhook""
+-	OpenEBSNDMLabelSelector              LabelSelector = ""name=openebs-ndm""
+-	OpenEBSCStorPoolLabelSelector        LabelSelector = ""app=cstor-pool""
++	MayaAPIServerLabelSelector             LabelSelector = ""name=maya-apiserver""
++	OpenEBSProvisionerLabelSelector        LabelSelector = ""name=openebs-provisioner""
++	OpenEBSLocalPVProvisionerLabelSelector LabelSelector = ""name=openebs-localpv-provisioner""
++	OpenEBSSnapshotOperatorLabelSelector   LabelSelector = ""name=openebs-snapshot-operator""
++	OpenEBSAdmissionServerLabelSelector    LabelSelector = ""app=admission-webhook""
++	OpenEBSNDMLabelSelector                LabelSelector = ""name=openebs-ndm""
++	OpenEBSCStorPoolLabelSelector          LabelSelector = ""app=cstor-pool""
+ )
+ 
+ func parseK8sYaml(yamls string) (k8s.UnstructedList, []error) {",The latest yaml in openebs/master has changed to name=admission-webhook. cc: @prateekpandey14,Why do we need this?
+5101,"@@ -3,7 +3,7 @@
+ 
+ # Purpose:
+ # sns-ruby-example-send-message.rb demonstrates how to send a message using the Amazon Simple Notification Services (SNS) topic using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+ 
+ # Inputs:
+ # - REGION",using **an** Amazon Simple... Simple Notification **Service** (singular),I'm not sure if this
+5102,"@@ -55,7 +55,7 @@ void CHECK_RGROUP(RGroupRows::const_iterator &it, std::string expected,
+   }
+   std::string result = str.str();
+ 
+-  if (expected != result) {
++  if (1 || expected != result) {
+     std::cerr << ""Expected: "" << expected << std::endl;
+     std::cerr << ""Got:      "" << result << std::endl;
+   }",Probably don't intend for this `1 ||` to still be here,Why did you change t
+5103,"@@ -353,14 +353,6 @@ bool cvdescriptorset::ValidateDescriptorSetLayoutCreateInfo(
+             VK_KHR_PUSH_DESCRIPTOR_EXTENSION_NAME);
+     }
+ 
+-    const bool host_only_pool_set = static_cast<bool>(create_info->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE);
+-    if (push_descriptor_set && host_only_pool_set) {
+-        skip |= val_obj->LogError(val_obj->device, ""VUID-VkDescriptorSetLayoutCreateInfo-flags-04590"",
+-                                  ""vkCreateDescriptorSetLayout(): pCreateInfo->flags cannot contain both ""
+-                                  ""VK_DESCRIPTOR_SET_LAYOUT_CREATE_PUSH_DESCRIPTOR_BIT_KHR and ""
+-                                  ""VK_DESCRIPTOR_SET_LAYOUT_CREATE_HOST_ONLY_POOL_BIT_VALVE."");
+-    }
+-
+     const bool update_after_bind_set = !!(create_info->flags & VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT);
+     if (update_after_bind_set && !descriptor_indexing_ext) {
+         skip |= val_obj->LogError(",Looks like this is failing to compile on Windows (VS 2015 I think).,Why is this check re
+5104,"@@ -91,6 +91,15 @@ func (q *Query) Limit(n int) *Query {
+ 	return q
+ }
+ 
++// BeforeQuery takes a callback function that will be called before the Query is
++// executed to the underlying provider's query functionality. The callback takes
++// a parameter, asFunc, that converts its argument to provider-specific types.
++// See https://godoc.org/gocloud.dev#hdr-As for background information.
++func (q *Query) BeforeQuery(beforeQuery func(asFunc func(interface{}) bool) error) *Query {
++	q.dq.BeforeQuery = beforeQuery
++	return q
++}
++
+ // Get returns an iterator for retrieving the documents specified by the query. If
+ // field paths are provided, only those paths are set in the resulting documents.
+ //","nit: call the arg something simple like `f` to avoid repeating ""beforeQuery"".",Why do we need this?
+5105,"@@ -18,8 +18,15 @@ package auth
+ 
+ import (
+ 	""context""
++
++	""github.com/libopenstorage/openstorage/pkg/correlation""
+ )
+ 
++func init() {
++	correlation.RegisterComponent(""auth"")
++	correlation.RegisterGlobalHook()
++}
++
+ const (
+ 	systemGuestRoleName = ""system.guest""
+ )",do you think this should be `osd/auth` as a pkg to make it more unique and void conflicts with other `auth` packages?,Why do we need this?
+5106,"@@ -36,10 +36,12 @@ namespace Microsoft.DotNet.Build.Tasks
+ 
+         public bool DebugOnly { get; set; }
+ 
++        [Output]
++        public string Message { get; set; } 
++
+         public override bool Execute()
+         {
+-            bool result = true;
+-
++            Message = """";
+             try
+             {
+                 using (_resxReader = new ResXResourceReader(ResxFilePath))",Why are you passing out the Message?,>Message [](start = 
+5107,"@@ -135,8 +135,8 @@ func (p *Provider) RegisterSpanProcessor(s SpanProcessor) {
+ 
+ // UnregisterSpanProcessor removes the given SpanProcessor from the list of SpanProcessors
+ func (p *Provider) UnregisterSpanProcessor(s SpanProcessor) {
+-	mu.Lock()
+-	defer mu.Unlock()
++	p.mu.Lock()
++	defer p.mu.Unlock()
+ 	new := make(spanProcessorMap)
+ 	if old, ok := p.spanProcessors.Load().(spanProcessorMap); ok {
+ 		for k, v := range old {","Yikes, this was a bug :grimacing:",I think this should 
+5108,"@@ -58,7 +58,7 @@ func (h *Handler) FetchX509SVID(_ *workload.X509SVIDRequest, stream workload.Spi
+ 
+ 	selectors := attestor.New(&config).Attest(pid)
+ 
+-	subscriber := h.Manager.Subscribe(selectors)
++	subscriber := h.Manager.NewSubscriber(selectors)
+ 	defer subscriber.Finish()
+ 
+ 	for {","I am not sure which one of these is considered idiomatic go... maybe @azdagron has an opinion here? /me prefers the verb since it's shorter. I guess I don't care _too_ much, but it would be good to get some general agreement so we are all following the same conventions",I think this should be `h.Manager.Subscribe`
+5109,"@@ -62,9 +62,7 @@ var LocalDevSequelproCmd = &cobra.Command{
+ 			""root"", //dbuser
+ 		))
+ 
+-		if scaffold != true {
+-			exec.Command(""open"", tmpFilePath).Run()
+-		}
++		exec.Command(""open"", tmpFilePath).Run()
+ 
+ 		color.Cyan(""sequelpro command finished successfully!"")
+ ","Please check this for error and emit appropriate debugging information. I know this was pre-existing code, but we just have to fix things like this as we go.",Why did you remove this?
+5110,"@@ -140,7 +140,7 @@ func InitialURL(c client.Client, cd *hivev1.ClusterDeployment) (string, error) {
+ // the ClusterDeployment to determine if the remote cluster is reachable.
+ func Unreachable(cd *hivev1.ClusterDeployment) (unreachable bool, lastCheck time.Time) {
+ 	cond := utils.FindClusterDeploymentCondition(cd.Status.Conditions, hivev1.UnreachableCondition)
+-	if cond.Status == corev1.ConditionUnknown {
++	if cond == nil || cond.Status == corev1.ConditionUnknown {
+ 		unreachable = true
+ 		return
+ 	}","This seems unrelated, should be a separate PR.",Why do we need this change?
+5111,"@@ -20,6 +20,7 @@
+ //--
+ 
+ #include ""algorithms/engines/mt2203/mt2203.h""
++#include ""../engine_create_dispatcher.h""
+ #include ""mt2203_batch_impl.h""
+ 
+ namespace daal","Never use relative includes, prefer full path",Why is this needed?
+5112,"@@ -397,6 +397,17 @@ class TestArgument:
+ 
+         assert str(excinfo.value) == ""Argument marked as both count/win_id!""
+ 
++    def test_zero_count_and_zero_count_arg(self):
++        with pytest.raises(TypeError) as excinfo:
++            @cmdutils.argument('arg', count=False,
++             zero_count=True)
++            def fun(arg=0):
++                """"""Blah.""""""
++                pass
++
++        assert str(excinfo.value) == (""Zero_count Argument"" +
++                 "" cannot exist without count!"")
++
+     def test_no_docstring(self, caplog):
+         with caplog.at_level(logging.WARNING):
+             @cmdutils.register()","This should fit on the line above without going over the 79-char limit, no?",I don't think you need the `pass` here.
+5113,"@@ -22,7 +22,6 @@ describe VideosController do
+       user = create(:subscriber)
+       video = create(:video)
+       create(:license, user: user, licenseable: video.watchable)
+-      controller.stubs(:signed_in?).returns(true)
+       stub_current_user_with(user)
+ 
+       get :show, id: video",Is this related to the other contents of this pull request?,Why was this removed?
+5114,"@@ -356,6 +356,7 @@ type WorkloadOpts struct {
+ 	Aliases                  []string
+ 	Tags                     map[string]string        // Used by App Runner workloads to tag App Runner service resources
+ 	NestedStack              *WorkloadNestedStackOpts // Outputs from nested stacks such as the addons stack.
++	AddonsExtraParams        string                   // Additional user defined Parameters for the addons stack.
+ 	Sidecars                 []*SidecarOpts
+ 	LogConfig                *LogConfigOpts
+ 	Autoscaling              *AutoscalingOpts",Should this be `*string`?,Should this be `[]string`?
+5115,"@@ -51,16 +51,7 @@ var _ = Context(""etcd connection interruption"", func() {
+ 
+ 	BeforeEach(func() {
+ 		felixes, etcd, client = infrastructure.StartNNodeEtcdTopology(2, infrastructure.DefaultTopologyOptions())
+-
+-		// Install a default profile that allows all ingress and egress, in the absence of any Policy.
+-		defaultProfile := api.NewProfile()
+-		defaultProfile.Name = ""default""
+-		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.Egress = []api.Rule{{Action: api.Allow}}
+-		defaultProfile.Spec.Ingress = []api.Rule{{Action: api.Allow}}
+-		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+-		Expect(err).NotTo(HaveOccurred())
+-
++		infrastructure.CreateDefaultProfile(client, ""default"", map[string]string{""default"": """"}, """")
+ 		// Wait until the tunl0 device appears; it is created when felix inserts the ipip module
+ 		// into the kernel.
+ 		Eventually(func() error {","In the old code here there was no Source Selector, but CreateDefaultProfile will specify a Source Selector of `""""`. Is that equivalent?",Why is this being removed?
+5116,"@@ -8,10 +8,12 @@ module RSpec
+         # Temporarily support old and new APIs while we transition the other
+         # rspec libs to use a hash for the 2nd arg and no version arg
+         data = Hash === replacement_or_hash ? replacement_or_hash : { :replacement => replacement_or_hash }
++        call_site = caller.find { |line| line !~ %r{/lib/rspec/(core|mocks|expectations|matchers|rails)/} }
++
+         RSpec.configuration.reporter.deprecation(
+           {
+             :deprecated => deprecated,
+-            :call_site => caller(0)[2]
++            :call_site => call_site
+           }.merge(data)
+         )
+       end",We should pick this across for all our deprecation specs,I'm not sure if this is the best way to check if a line is a call site or not. I think it would be better to check if the line is a call site.
+5117,"@@ -45,8 +45,8 @@ func init() {
+ }
+ 
+ var (
+-	kindBinary      = flag.String(""kindBinary"", ""kind"", ""path to the kind binary"")
+-	managerImageTar = flag.String(""managerImageTar"", """", ""a script to load the manager Docker image into Docker"")
++	kindBinary    = flag.String(""kindBinary"", ""kind"", ""path to the kind binary"")
++	kubectlBinary = flag.String(""kubectlBinary"", ""kubectl"", ""path to the kubectl binary"")
+ )
+ 
+ // Cluster represents the running state of a KIND cluster.","Longer term, I think it could be valuable to move this to cluster-api, and then other repos could take advantage of this as well.",Why did you remove this flag?
+5118,"@@ -1416,7 +1416,7 @@ func describeBPFTests(opts ...bpfTestOpt) bool {
+ 								if testOpts.connTimeEnabled {
+ 									Skip(""FIXME externalClient also does conntime balancing"")
+ 								}
+-
++								externalClient.EnsureBinary(""test-connection"")
+ 								cc.ExpectSome(externalClient, TargetIP(felixes[1].IP), npPort)
+ 								cc.CheckConnectivity()
+ 							})",Is this a related change?,Why is this needed?
+5119,"@@ -400,6 +400,12 @@ func (a *Actuator) Update(ctx context.Context, cluster *clusterv1.Cluster, machi
+ 		return errors.Errorf(""failed to ensure tags: %+v"", err)
+ 	}
+ 
++	scope.MachineStatus.InstanceState = &instanceDescription.State
++
++	if err := a.reconcileLBAttachment(scope, machine, instanceDescription); err != nil {
++		return errors.Errorf(""failed to reconcile load balancer attachment: %+v"", err)
++	}
++
+ 	return nil
+ }
+ ","Given that this is repeated, can we do it outside here and the Create call, what do you think about moving it outside?",Shouldn't this be `if err := ...`?
+5120,"@@ -44,6 +44,10 @@ function UndoRedo(instance) {
+       return;
+     }
+ 
++    arrayEach(changes, (change) => {
++      change[1] = instance.propToCol(change[1]);
++    });
++
+     const selected = changesLen > 1 ? this.getSelected() : [[changes[0][0], changes[0][1]]];
+ 
+     plugin.done(new UndoRedo.ChangeAction(changes, selected));",Changing `prop`=>`col` by reference?   I think you can prepare map `prop`=>`col` in L51.,Why do we need this?
+5121,"@@ -106,6 +106,7 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --grpc             Generate GRPC interfaces for the specified languages\n""
+     ""  --schema           Serialize schemas instead of JSON (use with -b)\n""
+     ""  --bfbs-comments    Add doc comments to the binary schema files.\n""
++    ""  --bfbs-builtin-attrs  Add builtin attributes to the binary schema files.\n""
+     ""  --conform FILE     Specify a schema the following schemas should be\n""
+     ""                     an evolution of. Gives errors if not.\n""
+     ""  --conform-includes Include path for the schema given with --conform\n""","I hate to ask, but can we make this flag shorter so it lines up? :(",This should be `--bf
+5122,"@@ -19,9 +19,9 @@ import (
+ 	appsv1 ""k8s.io/api/apps/v1""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	apiextv1 ""k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1""
+-	""k8s.io/apimachinery/pkg/api/errors""
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/apimachinery/pkg/apis/meta/v1/unstructured""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/types""
+ 	""k8s.io/client-go/discovery""","Note to reviewers: latent, dedup import",Why is this needed?
+5123,"@@ -20,3 +20,18 @@ package agent
+ func (i *Initializer) setupExternalConnectivity() error {
+ 	return nil
+ }
++
++// prepareHostNetwork returns immediately on Linux.
++func (i *Initializer) prepareHostNetwork() error {
++	return nil
++}
++
++// prepareOVSBridge returns immediately on Linux.
++func (i *Initializer) prepareOVSBridge() error {
++	return nil
++}
++
++// initHostNetworkFlows returns immediately on Linux.
++func (i *Initializer) initHostNetworkFlows() error {
++	return nil
++}",Seems this func is no more needed after your refactoring.,Why do we need these
+5124,"@@ -67,6 +67,7 @@ public class MemoryUsage {
+             Tuple.of(""^java\\."", ""Java mutable @ ""),
+             Tuple.of(""^fj\\."", ""Functional Java persistent @ ""),
+             Tuple.of(""^org\\.pcollections"", ""PCollections persistent @ ""),
++            Tuple.of(""^io\\.usethesource"", ""Steindorfer persistent @ ""),
+             Tuple.of(""^org\\.eclipse\\.collections"", ""Eclipse Collections persistent @ ""),
+             Tuple.of(""^clojure\\."", ""Clojure persistent @ ""),
+             Tuple.of(""^scalaz\\.Heap"", ""Scalaz persistent @ ""),",already added (see several rows below),I think this should be `io\\.usethesource\\.persistent`
+5125,"@@ -614,6 +614,8 @@ func (m *bpfEndpointManager) attachDataIfaceProgram(ifaceName string, polDirecti
+ 	epType := tc.EpTypeHost
+ 	if ifaceName == ""tunl0"" {
+ 		epType = tc.EpTypeTunnel
++	} else if ifaceName == ""wireguard.cali"" {
++		epType = tc.EpTypeWireguard
+ 	}
+ 	ap := m.calculateTCAttachPoint(epType, polDirection, ifaceName)
+ 	ap.HostIP = m.hostIP",nit: a switch perhaps?,Why do we need this?
+5126,"@@ -170,7 +170,7 @@ func (c *workflowSizeChecker) failWorkflowSizeExceedsLimit() (bool, error) {
+ 			tag.WorkflowEventCount(historyCount))
+ 
+ 		attributes := &decisionpb.FailWorkflowExecutionDecisionAttributes{
+-			Failure: failure.NewServerFailure(common.FailureReasonSizeExceedsLimit, false),
++			Failure: failure.NewServerFailure(common.FailureReasonSizeExceedsLimit, true),
+ 		}
+ 
+ 		if _, err := c.mutableState.AddFailWorkflowEvent(c.completedID, enumspb.RETRY_STATUS_NON_RETRYABLE_FAILURE, attributes); err != nil {",Great you caught this. Super critical to not retry these errors.,Why do we need this change?
+5127,"@@ -77,7 +77,7 @@ enum CoreAdminOperation implements CoreAdminOp {
+     String coreName = params.required().get(CoreAdminParams.NAME);
+     Map<String, String> coreParams = buildCoreParams(params);
+     CoreContainer coreContainer = it.handler.coreContainer;
+-    Path instancePath = coreContainer.getCoreRootDirectory().resolve(coreName);
++    Path instancePath;
+ 
+     // TODO: Should we nuke setting odd instance paths?  They break core discovery, generally
+     String instanceDir = it.req.getParams().get(CoreAdminParams.INSTANCE_DIR);","Just a little change to make the var effectively final, which is clearer.",Why is this change needed?
+5128,"@@ -30,8 +30,8 @@ def flowdetails(state, flow: http.HTTPFlow):
+     if sc is not None:
+         text.append(urwid.Text([(""head"", ""Server Connection:"")]))
+         parts = [
+-            [""Address"", ""{}:{}"".format(sc.address[0], sc.address[1])],
+-            [""Resolved Address"", ""{}:{}"".format(sc.ip_address[0], sc.ip_address[1])],
++            [""Address"", ""{}"".format(human.format_address(sc.address))],
++            [""Resolved Address"", ""{}"".format(human.format_address(sc.ip_address))],
+         ]
+         if resp:
+             parts.append([""HTTP Version"", resp.http_version])","Using `""{}"".format(...)` is a bit beside the point...  ",I don't think we need the `human.format_address` here.
+5129,"@@ -149,8 +149,8 @@ class JsonFormatterTest(unittest.TestCase):
+     def test_logger_name(self):
+         JsonLogFormatter.init_from_settings({""project_name"": ""kintowe""})
+         f = JsonLogFormatter()
+-        record = logging.LogRecord(""app.log"", logging.DEBUG, """", 0, ""coucou"", (), None)
+-        result = f.format(record)
++        obj = logging.LogRecord(""app.log"", logging.DEBUG, """", 0, ""coucou"", (), None)
++        result = f.format(obj)
+         logged = json.loads(result)
+         self.assertEqual(logged[""Logger""], ""kintowe"")
+         self.assertEqual(logged[""Type""], ""app.log"")",I think these should remain as they are.,Why did you change this?
+5130,"@@ -14,6 +14,8 @@ module Beaker
+     WINDOWS_PACKAGES = ['curl']
+     SLES_PACKAGES = ['curl', 'ntp']
+     DEBIAN_PACKAGES = ['curl', 'ntpdate', 'lsb-release']
++    # Packages added at runtime
++    @@additional_pkgs = []
+     ETC_HOSTS_PATH = ""/etc/hosts""
+     ETC_HOSTS_PATH_SOLARIS = ""/etc/inet/hosts""
+     ROOT_KEYS_SCRIPT = ""https://raw.githubusercontent.com/puppetlabs/puppetlabs-sshkeys/master/templates/scripts/manage_root_authorized_keys""","Let's just call this PERF_PACKAGES and have them in the same format as WINDOWS/SLES/DEBIAN_PACKAGES constants - since it is only a single package and, as written, you'd have to update the code to add more package names anyway. Might as well be consistent with the rest of the code.",Is this used anywhere?
+5131,"@@ -224,6 +224,18 @@ String getTaskValueName(taskIndex_t TaskIndex, uint8_t TaskValueIndex) {
+   return ExtraTaskSettings.TaskDeviceValueNames[TaskValueIndex];
+ }
+ 
++/*********************************************************************************************
++ * get the taskPluginID with required checks, INVALID_PLUGIN_ID when invalid
++ ********************************************************************************************/
++pluginID_t getTaskDevicePluginID(taskIndex_t TaskIndex) {
++  if (validTaskIndex(TaskIndex)) {
++    const deviceIndex_t DeviceIndex = getDeviceIndex_from_TaskIndex(TaskIndex);
++
++    return (validDeviceIndex(DeviceIndex) ? Device[DeviceIndex].Number : INVALID_PLUGIN_ID);
++  }
++  return INVALID_PLUGIN_ID;
++}
++
+ /********************************************************************************************\
+    If RX and TX tied together, perform emergency reset to get the system out of boot loops
+  \*********************************************************************************************/",We don't have a `getPluginIDfromTaskIndex` function? I think it should be implemented in Globals/Plugins.h / .cpp,Why not just return `INVALID_PLUGIN_ID` here?
+5132,"@@ -910,8 +910,12 @@ public class QueryComponent extends SearchComponent
+         additionalAdded = addFL(additionalFL, ""score"", additionalAdded);
+       }
+     } else {
+-      // reset so that only unique key is requested in shard requests
+-      sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());
++      if (rb.req.getSearcher().enableLazyFieldLoading) {
++        // reset so that only unique key is requested in shard requests
++        sreq.params.set(CommonParams.FL, rb.req.getSchema().getUniqueKeyField().getName());
++      } else {
++        sreq.params.set(CommonParams.FL, ""*"");
++      }
+       if (shardQueryIncludeScore) {
+         additionalAdded = addFL(additionalFL, ""score"", additionalAdded);
+       }","@shalinmangar If lazy field loading isn't enabled, I don't think this actually changes the behavior of `SolrIndexSearcher`, since it was previously ignoring the fields list anyway. What it _should_ do is allow certain distributed queries, like the ones in `DistribJoinFromCollectionTest`, to co-exist with `SolrIndexSearcher#doc()` respecting the `fields` set instead of just discarding it.",Why is this needed?
+5133,"@@ -5,7 +5,7 @@ package ddevapp
+ const DDevComposeTemplate = `version: '2'
+ 
+ services:
+-  {{ .plugin }}-{{.name }}-db:
++  db:
+     container_name: {{ .plugin }}-${DDEV_SITENAME}-db
+     image: $DDEV_DBIMAGE
+     volumes:",Should we be using version 3 now?,Why did you remove 
+5134,"@@ -24,7 +24,11 @@ class PluginListFactory
+ 
+     public function __invoke(string $current_dir, ?string $config_file_path = null): PluginList
+     {
+-        $config_file = new ConfigFile($current_dir, $config_file_path);
++        try {
++            $config_file = new ConfigFile($current_dir, $config_file_path);
++        } catch (\RuntimeException $exception) {
++            $config_file = null;
++        }
+         $composer_lock = new ComposerLock($this->findLockFiles());
+ 
+         return new PluginList($config_file, $composer_lock);","Would be better to throw a more specific exception, but for now it will do.",`$config_file = nul
+5135,"@@ -17,8 +17,6 @@ package org.hyperledger.besu.tests.acceptance.dsl.blockchain;
+ import static org.web3j.utils.Convert.Unit.ETHER;
+ import static org.web3j.utils.Convert.Unit.WEI;
+ 
+-import org.hyperledger.besu.ethereum.core.Wei;
+-
+ import java.math.BigDecimal;
+ import java.math.BigInteger;
+ ",We should not replace Wei with a type that is shared across multiple units. We need this as `Wei` for type and unit safety.,Why was this remove
+5136,"@@ -653,8 +653,7 @@ func drupalEnsureWritePerms(app *DdevApp) error {
+ 
+ 	for _, o := range makeWritable {
+ 		stat, err := os.Stat(o)
+-		// If the file doesn't exist, don't try to set the permissions.
+-		if os.IsNotExist(err) {
++		if err != nil {
+ 			continue
+ 		}
+ ","I'm pretty sure this should emit a util.Warning*(), since we're skipping by here and never hitting anything that will give them a warning about what's happened.",Why is this being removed?
+5137,"@@ -23,6 +23,12 @@ type aspParser struct {
+ 
+ // newAspParser creates and returns a new asp.Parser.
+ func newAspParser(state *core.BuildState) *asp.Parser {
++	p := GetParserWithBuiltins(state)
++	return p
++}
++
++// GetParserWithBuiltins returns a asp.Parser object with all the builtins loaded
++func GetParserWithBuiltins(state *core.BuildState) *asp.Parser {
+ 	p := asp.NewParser(state)
+ 	log.Debug(""Loading built-in build rules..."")
+ 	dir, _ := rules.AssetDir("""")",This function isn't useful? it's just a clone of GetParserWithBuiltins?,Why do we need this?
+5138,"@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
+ 
+     useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    isCpuCircuitBreakerEnabled = getBool(""circuitBreaker/isCpuCircuitBreakerEnabled"", false);
++    isMemoryCircuitBreakerEnabled = getBool(""circuitBreaker/isMemoryCircuitBreakerEnabled"", false);
+     memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 95);
+ 
+-    validateMemoryBreakerThreshold();
++    cpuCircuitBreakerThreshold = getInt(""circuitBreaker/cpuCircuitBreakerThreshold"", 95);
++
++    validateCircuitBreakerThresholds();
+     
+     filterCacheConfig = CacheConfig.getConfig(this, ""query/filterCache"");
+     queryResultCacheConfig = CacheConfig.getConfig(this, ""query/queryResultCache"");","I'm not sure if the boolean flags should always contain `is`, also I generally hate too long names... ;) we already know this is a section for circuit breakers, so the name doesn't have to repeat all of it. How about `cpuBreakerEnabled`, `memoryBreakerEnabled` etc?",I think this should be `ge
+5139,"@@ -42,4 +42,13 @@ public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+    * @return this for method chaining
+    */
+   RewriteFiles rewriteFiles(Set<DataFile> filesToDelete, Set<DataFile> filesToAdd);
++
++  /**
++   * Add a rewrite that replaces one set of deletes with another that contains the same deleted rows.
++   *
++   * @param deletesToDelete files that will be replaced, cannot be null or empty.
++   * @param deletesToAdd files that will be added, cannot be null or empty.
++   * @return this for method chaining
++   */
++  RewriteFiles rewriteDeletes(Set<DeleteFile> deletesToDelete, Set<DeleteFile> deletesToAdd);
+ }","Before we start the replacing equality deletes with position deletes, I think we need to refactor the RewriteFiles API to adjust more cases: 1. Rewrite data files and remove all the delete rows. The files to delete will be a set of data files and a set of delete files, and the files to add will be a set of data files. 2. Replace equality deletes with position deletes, the files to delete will be a set of equality delete files (we will need to ensure that all delete files are equality delete files ? ) , the files to add will be a set of position delete files. 3. Merging small delete files into a bigger delete files. The files to delete will be a set of equality/position delete files, the files to add will be a set of equality/position delete files.",I don't think we need to a
+5140,"@@ -9,10 +9,16 @@ module Blacklight::BlacklightHelperBehavior
+   ##
+   # Get the name of this application from an i18n string
+   # key: blacklight.application_name
++  # Try first in the current locale, then the default locale
+   #
+   # @return [String] the application name
+   def application_name
+-    t('blacklight.application_name')
++    # It's important that we don't use ActionView::Helpers::CacheHelper#cache here
++    # because it returns nil.
++    Rails.cache.fetch 'blacklight/application_name' do
++      t('blacklight.application_name',
++        default: t('blacklight.application_name', locale: I18n.default_locale))
++    end
+   end
+ 
+   ##",Layout/TrailingWhitespace: Trailing whitespace detected.,I'm not sure if this is the best way to do this. I think it would be better to use `I18n.default_locale` here.
+5141,"@@ -80,8 +80,12 @@ public class LibraryManager {
+         List<ShortcutCategoryDTO> shortcuts = new ArrayList<>();
+         for (Map.Entry<String, List<ShortcutDTO>> entry : categoryMap.entrySet()) {
+             entry.getValue().sort(ShortcutDTO.nameComparator());
+-            ShortcutCategoryDTO category = new ShortcutCategoryDTO.Builder().withId(entry.getKey())
+-                    .withName(entry.getKey()).withShortcuts(entry.getValue()).build();
++            ShortcutCategoryDTO category = new ShortcutCategoryDTO.Builder()
++                    .withId(entry.getKey())
++                    .withName(entry.getKey())
++                    .withShortcuts(entry.getValue())
++                    .withIcon(entry.getValue().get(0).getCategoryIcon()) // choose one category icon
++                    .build();
+             shortcuts.add(tr(category));
+         }
+ ",Is it possible that the shortcuts list is empty?,Why do we need this change?
+5142,"@@ -692,6 +692,10 @@ func runBackup(opts BackupOptions, gopts GlobalOptions, term *termstatus.Termina
+ 		p.V(""start backup on %v"", targets)
+ 	}
+ 	_, id, err := arch.Snapshot(gopts.ctx, targets, snapshotOpts)
++	if errors.Cause(err) == context.Canceled {
++		return errors.Fatal(""canceled"")
++	}
++
+ 	if err != nil {
+ 		return errors.Fatalf(""unable to save snapshot: %v"", err)
+ 	}",This just changes the error message from `unable to save snapshot: [...] context canceled` to `canceled`.,Shouldn't this be `errors.Cause(err)`?
+5143,"@@ -141,7 +141,9 @@ public abstract class AbstractRestInvocation {
+     if (response.getHeaders().getHeaderMap() != null) {
+       for (Entry<String, List<Object>> entry : response.getHeaders().getHeaderMap().entrySet()) {
+         for (Object value : entry.getValue()) {
+-          responseEx.addHeader(entry.getKey(), String.valueOf(value));
++          if (!entry.getKey().equalsIgnoreCase(HttpHeaders.CONTENT_LENGTH)) {
++            responseEx.addHeader(entry.getKey(), String.valueOf(value));
++          }
+         }
+       }
+     }",maybe it's better to remove HttpHeaders.CONTENT_LENGTH after the loop,Why do we need to check for content length here?
+5144,"@@ -679,6 +679,12 @@ public interface List<T> extends LinearSeq<T>, Stack<T> {
+ 
+     @Override
+     default List<T> dropRight(int n) {
++        if (n <= 0) {
++            return this;
++        }
++        if (n >= length()) {
++            return empty();
++        }
+         return reverse().drop(n).reverse();
+     }
+ ",Very cool. We are now collecting the fruits after your length implementation!,Shouldn't this return `this`?
+5145,"@@ -0,0 +1,8 @@
++rules:
++  - name: all pubs are in whitelist
++    project: '*'
++    network: '*'
++    is_external_network: True
++    whitelist:
++      - xpn-master:xpn-network
++      - content-insights:default","Is this the same copy of the rules file from above? If so, can just use the copy from above, and this can be dropped.",I don't think we need this.
+5146,"@@ -264,6 +264,13 @@ func (acsSession *session) startACSSession(client wsclient.ClientServer, timer t
+ 
+ 	client.AddRequestHandler(refreshCredsHandler.handlerFunc())
+ 
++	// Add handler to ack ENI attach message
++	eniAttachHandler := newAttachENIHandler(acsSession.ctx, cfg.Cluster, acsSession.containerInstanceARN, client, acsSession.taskEngine, acsSession.stateManager)
++	eniAttachHandler.start()
++	defer eniAttachHandler.stop()
++
++	client.AddRequestHandler(eniAttachHandler.handlerFunc())
++
+ 	// Add request handler for handling payload messages from ACS
+ 	payloadHandler := newPayloadRequestHandler(
+ 		acsSession.ctx,",Please break this into multiple lines.,Can we move this to a separat
+5147,"@@ -120,7 +120,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+                 {
+                     scope.Span.SetHeaderTags<IHeadersCollection>(httpContext.Response.Headers.Wrap(), Tracer.Instance.Settings.HeaderTags, defaultTagPrefix: SpanContextPropagator.HttpResponseHeadersTagPrefix);
+                 }
+-
++                HttpContextHelpers.AddHeaderTagsFromHttpResponse(httpContext, scope);
+                 scope.Span.SetHttpStatusCode(responseMessage.DuckCast<HttpResponseMessageStruct>().StatusCode, isServer: true);
+                 scope.Dispose();
+             }",Shouldn't this new line replace the few lines above?,Why do we need this?
+5148,"@@ -2,9 +2,9 @@ package options
+ 
+ import (
+ 	""github.com/influxdata/flux""
+-	""github.com/influxdata/flux/functions/transformations""
++	""github.com/influxdata/flux/stdlib/universe""
+ )
+ 
+ func init() {
+-	flux.RegisterBuiltInOption(""now"", transformations.SystemTime())
++	flux.RegisterBuiltInOption(""now"", universe.SystemTime())
+ }",Perhaps this belongs in universe?,"I think this should be `flux.RegisterBuiltInOption(""now"", universe.SystemTime())`"
+5149,"@@ -25,8 +25,11 @@ std::chrono::duration<double, std::milli> hist_time;
+ std::chrono::duration<double, std::milli> find_split_time;
+ std::chrono::duration<double, std::milli> split_time;
+ std::chrono::duration<double, std::milli> ordered_bin_time;
++std::chrono::duration<double, std::milli> refit_leaves_time;
+ #endif  // TIMETAG
+ 
++double EPS = 1e-12;
++
+ SerialTreeLearner::SerialTreeLearner(const Config* config)
+   :config_(config) {
+   random_ = Random(config_->feature_fraction_seed);",there is a `kEpsilon` you can use directly.,This should be `constexpr`.
+5150,"@@ -17,9 +17,10 @@ limitations under the License.
+ package ec2
+ 
+ import (
+-	""sigs.k8s.io/cluster-api/util/conditions""
+ 	""strings""
+ 
++	""sigs.k8s.io/cluster-api/util/conditions""
++
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/awserrors""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/cloud/services/wait""
+ 	""sigs.k8s.io/cluster-api-provider-aws/pkg/record""","This should be grouped with the below imports, and the two separate groups of imports below should likely also be grouped together",nit: remove empty line
+5151,"@@ -888,11 +888,11 @@ void cvdescriptorset::DescriptorSet::PerformWriteUpdate(const VkWriteDescriptorS
+ }
+ // Validate Copy update
+ bool cvdescriptorset::DescriptorSet::ValidateCopyUpdate(const debug_report_data *report_data, const VkCopyDescriptorSet *update,
+-                                                        const DescriptorSet *src_set, std::string *error_code,
++                                                        const DescriptorSet *src_set, std::string &error_code,
+                                                         std::string *error_msg) {
+     // Verify dst layout still valid
+     if (p_layout_->IsDestroyed()) {
+-        *error_code = ""VUID-VkCopyDescriptorSet-dstSet-parameter"";
++        error_code = ""VUID-VkCopyDescriptorSet-dstSet-parameter"";
+         string_sprintf(error_msg,
+                        ""Cannot call vkUpdateDescriptorSets() to perform copy update on descriptor set dstSet 0x%"" PRIxLEAST64
+                        "" created with destroyed VkDescriptorSetLayout 0x%"" PRIxLEAST64,","It looks like this error_code field is used to return a string to the caller, not just a const input string to be consumed as in the rest of this PR? If so, my personal preference would be to leave it as a std::string* instead of a reference; I don't know offhand what the VL coding style dictates.",`error_code` and `error_msg` can be const
+5152,"@@ -66,6 +66,11 @@ std::string MetaUtils::partVal(const std::vector<nebula::cpp2::HostAddr>& hosts)
+     return val;
+ }
+ 
++std::string MetaUtils::partPrefix() {
++    static const std::string prefix = kPartsTable;
++    return prefix;
++}
++
+ std::string MetaUtils::partPrefix(GraphSpaceID spaceId) {
+     std::string prefix;
+     static constexpr size_t tableLen = ::strlen(kPartsTable);","If return by value, then why bother to make it `static`?",Why is this static?
+5153,"@@ -369,8 +369,11 @@ def nop():
+ 
+ @cmdutils.register()
+ @cmdutils.argument('win_id', win_id=True)
+-def version(win_id):
++def version(win_id, paste=False):
+     """"""Show version information.""""""
+     tabbed_browser = objreg.get('tabbed-browser', scope='window',
+                                 window=win_id)
+     tabbed_browser.openurl(QUrl('qute://version'), newtab=True)
++
++    if paste:
++        utils.pastebin_version()","You'll need to add docs for the argument, see e.g. the `debug_log_filter` docstring above.",Why do we need to d
+5154,"@@ -30,6 +30,7 @@ import (
+ 	""go.opentelemetry.io/otel/codes""
+ 	""go.opentelemetry.io/otel/sdk/instrumentation""
+ 	""go.opentelemetry.io/otel/sdk/resource""
++	sdktrace ""go.opentelemetry.io/otel/sdk/trace""
+ 	tracesdk ""go.opentelemetry.io/otel/sdk/trace""
+ 	""go.opentelemetry.io/otel/semconv""
+ 	""go.opentelemetry.io/otel/trace""","`sdktrace` or `tracesdk`, pick one.",nit: I think this s
+5155,"@@ -200,11 +200,7 @@ trait ContentMagicTrait
+             }
+         }
+ 
+-        return [
+-            'filename' => '',
+-            'alt' => '',
+-            'path' => '',
+-        ];
++        return [];
+     }
+ 
+     /**",can we return null instead?,Why did you remove 
+5156,"@@ -179,6 +179,12 @@ void exit_event(void)
+     bool success = dr_raw_tls_cfree(tls_offs, NUM_TLS_SLOTS);
+     ASSERT(success);
+     ASSERT(num_lea > 0);
++#ifdef UNIX
++    /* i#2346: delay client threads termination on Windows. */
++    dr_fprintf(STDERR, ""process is exiting\n"");
++    dr_event_signal(child_continue);
++    dr_event_wait(child_dead);
++#endif
+     /* DR should have terminated the client thread for us */
+     dr_event_destroy(child_alive);
+     dr_event_destroy(child_continue);","You mean XXX and ""we should"" or ""NYI"" or sthg. Maybe put it on the ifdef line.",Why is this needed?
+5157,"@@ -25,3 +25,17 @@ func (w literalLoggable) GetValue(key string) string { return w.strings[key] }
+ func (w literalLoggable) GetValueAsInt64Slice(key string) []int64 { return w.int64s[key] }
+ 
+ func (w literalLoggable) ReadSerialPortLogs() []string { return w.serials }
++
++// SingleImageImportLoggable returns a Loggable that is pre-initialized with the metadata
++// fields that are relevant when importing a single image file.
++func SingleImageImportLoggable(fileFormat string, sourceSize, resultSize int64, serials []string) Loggable {
++	loggable := literalLoggable{
++		strings: map[string]string{importFileFormat: fileFormat},
++		int64s: map[string][]int64{
++			sourceSizeGb: {sourceSize},
++			targetSizeGb: {resultSize},
++		},
++		serials: serials,
++	}
++	return loggable
++}",minor: can be in-lined in return,nit: can we call th
+5158,"@@ -14,7 +14,7 @@ module RSpec::Core::Formatters
+         it ""prints a message if provided, ignoring other data"" do
+           formatter.deprecation(:message => ""this message"", :deprecated => ""x"", :replacement => ""y"", :call_site => ""z"")
+           deprecation_stream.rewind
+-          expect(deprecation_stream.read).to eq ""this message""
++          expect(deprecation_stream.read).to eq ""this message\n""
+         end
+ 
+         it ""includes the method"" do","why the additional ""\n""?",Why this change?
+5159,"@@ -183,7 +183,7 @@ func (s *streamTable) Do(f func(flux.ColReader) error) error {
+ 	if err := f(s.first); err != nil {
+ 		s.first.Release()
+ 		s.first = nil
+-		return nil
++		return err
+ 	}
+ 	s.first.Release()
+ 	s.first = nil","This seems to be a big omission. If the first buffer reports an error, stream seems to just discard it.",Why is this change 
+5160,"@@ -180,9 +180,7 @@ func MakeFull(log logging.Logger, rootDir string, cfg config.Local, phonebookDir
+ 		return nil, err
+ 	}
+ 
+-	blockListeners := []ledger.BlockListener{
+-		node,
+-	}
++	blockListeners := []ledger.BlockListener{}
+ 
+ 	if node.config.EnableTopAccountsReporting {
+ 		blockListeners = append(blockListeners, &accountListener)",Maybe move this one down too?,Why do we need this change?
+5161,"@@ -1,12 +1,12 @@
+-using Datadog.Trace.Logging;
++using Datadog.Trace.Logging;
+ 
+ namespace Datadog.Trace
+ {
+     internal class AsyncLocalScopeManager
+     {
+-        private static ILog _log = LogProvider.For<AsyncLocalScopeManager>();
++        private static readonly ILog _log = LogProvider.For<AsyncLocalScopeManager>();
+ 
+-        private AsyncLocalCompat<Scope> _currentSpan = new AsyncLocalCompat<Scope>();
++        private readonly AsyncLocalCompat<Scope> _currentSpan = new AsyncLocalCompat<Scope>();
+ 
+         public Scope Active => _currentSpan.Get();
+ ","We do this in lots of places I'm starting to notice...typically you'd avoid taking concrete dependencies, but we also avoid package dependencies as well which makes sense (i.e. not using an IoC, etc.). Any reason we don't implement some form of poor-man's DI and/or a simple factory instead of new-ing things up everywhere. This may be a simple example (as I'm guessing this is likely the only place this is ever or ever will be used), but separating them doesn't take any more time/effort either really.",Why did you change this?
+5162,"@@ -77,8 +77,13 @@ func Errf(format string, a ...interface{}) DError {
+ }
+ 
+ // wrapErrf returns a DError by keeping errors type and replacing original error message.
+-func wrapErrf(e DError, format string, a ...interface{}) DError {
+-	return &dErrImpl{errs: []error{fmt.Errorf(format, a...)}, errsType: e.errorsType(), anonymizedErrs: []string{format}}
++func wrapErrf(e DError, formatPrefix string, a ...interface{}) DError {
++	f := formatPrefix + strings.Join(e.AnonymizedErrs(), ""; "")
++	return &dErrImpl{
++		errs:           []error{fmt.Errorf(fmt.Sprintf(formatPrefix, a...) + e.Error())},
++		errsType:       e.errorsType(),
++		anonymizedErrs: []string{f},
++	}
+ }
+ 
+ // newErr returns a DError. newErr is used to wrap another error as a DError.",What if formatPrefix doesn't include a space? Will the resulting error have e.Error() stuck at the end without any space?,nit: `fmt.Sprintf(formatPre
+5163,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
++// Package pushsync provides the pushsync protocol
++// implementation.
+ package pushsync
+ 
+ import (",that doesn't say a lot to me. Can you please be more specific on the function of pushsync?,// Package pushsync provide
+5164,"@@ -1602,6 +1602,15 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+                         }
+                     }
+                 }
++                if (subpass_desc->pDepthStencilAttachment->layout == VK_IMAGE_LAYOUT_DEPTH_STENCIL_READ_ONLY_OPTIMAL) {
++                    if (pPipeline->graphicsPipelineCI.pDepthStencilState->depthWriteEnable == VK_TRUE) {
++                        skip |= LogError(
++                            device, ""VUID-VkGraphicsPipelineCreateInfo-subpass-04890"",
++                            ""vkCreateGraphicsPipelines(): pCreateInfo[%"" PRIu32
++                            ""]: subpass uses read-only depth aspect layout, but pDepthStencilState->depthWriteEnable is VK_TRUE."",
++                            pipelineIndex);
++                    }
++                }
+             }
+ 
+             // If subpass uses color attachments, pColorBlendState must be valid pointer",> subpass uses a depth/stencil attachment in renderPass with a read-only layout for the depth aspect Assume - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_STENCIL_ATTACHMENT_OPTIMAL - VK_IMAGE_LAYOUT_DEPTH_READ_ONLY_OPTIMAL count as well seems there is a `NormalizeDepthImageLayout` for this,"I don't think this is the right place for this check. If the depth stencil attachment is read-only, then the pipeline should be skipped. If the depth stencil attachment is read-only, then the pipeline should be skipped."
+5165,"@@ -49,14 +49,14 @@ export function registerDefaults( widgetsAPI ) {
+ 	widgetsAPI.registerWidgetArea( AREA_DASHBOARD_ALL_TRAFFIC, {
+ 		title: __( 'All Traffic', 'google-site-kit' ),
+ 		subtitle: __( 'How people found your site.', 'google-site-kit' ),
+-		style: WIDGET_AREA_STYLES.COMPOSITE,
++		style: WIDGET_AREA_STYLES.BOXES,
+ 		priority: 1,
+ 	}, CONTEXT_DASHBOARD );
+ 
+ 	widgetsAPI.registerWidgetArea( AREA_DASHBOARD_SEARCH_FUNNEL, {
+ 		title: __( 'Search Funnel', 'google-site-kit' ),
+ 		subtitle: __( 'How your site appeared in Search results and how many visitors you got from Search.', 'google-site-kit' ),
+-		style: WIDGET_AREA_STYLES.COMPOSITE,
++		style: WIDGET_AREA_STYLES.BOXES,
+ 		priority: 2,
+ 	}, CONTEXT_DASHBOARD );
+ ","This shouldn't be altered, you probably meant to update `AREA_PAGE_DASHBOARD_ALL_TRAFFIC` further below :)",I think this should be `BOXES` as well.
+5166,"@@ -882,7 +882,7 @@ class CmdDockerClient(ContainerClient):
+         if mount_volumes:
+             cmd += [
+                 volume
+-                for host_path, docker_path in mount_volumes
++                for host_path, docker_path in dict(mount_volumes).items()
+                 for volume in [""-v"", f""{host_path}:{docker_path}""]
+             ]
+         if interactive:",what does this change do exactly?,Why do we need this change?
+5167,"@@ -48,7 +48,8 @@ type networkImpl struct {
+ 	proposalCh chan agreement.Message
+ 	bundleCh   chan agreement.Message
+ 
+-	net network.GossipNode
++	net           network.GossipNode
++	backgroundCtx context.Context
+ }
+ 
+ // WrapNetwork adapts a network.GossipNode into an agreement.Network.",What's the purpose of this `backgroundCtx` field?,Why do we need a context here?
+5168,"@@ -42,7 +42,11 @@ import (
+ // Trie cache generation limit after which to evict trie nodes from memory.
+ var MaxTrieCacheGen = uint32(1024 * 1024)
+ 
+-const IncarnationLength = 8
++const (
++	IncarnationLength        = 8
++	FirstContractIncarnation = 1
++	AccountIncarnation       = 0
++)
+ 
+ type StateReader interface {
+ 	ReadAccountData(address common.Address) (*accounts.Account, error)",non contract incarnation,I think this should be `FirstContractIncarnation`
+5169,"@@ -108,10 +108,7 @@ class ErrorHandler(object):
+                         message = value[""value""]
+                         if not isinstance(message, basestring):
+                             value = message
+-                            try:
+-                                message = message['message']
+-                            except TypeError:
+-                                message = None
++                            message = message.get('message', None)
+                     else:
+                         message = value.get('message', None)
+                 except ValueError:",I would recommend to leave out `None` because None is already the default.,Why did you remove this?
+5170,"@@ -90,11 +90,11 @@ func (h *Handler) handleNewStream(s net.Stream) {
+ 
+ 	switch err := h.processHelloMessage(from, &hello); err {
+ 	case ErrBadGenesis:
+-		log.Warningf(""genesis cid: %s does not match: %s, disconnecting from peer: %s"", &hello.GenesisHash, h.genesis, from)
++		log.Debugf(""genesis cid: %s does not match: %s, disconnecting from peer: %s"", &hello.GenesisHash, h.genesis, from)
+ 		s.Conn().Close() // nolint: errcheck
+ 		return
+ 	case ErrWrongVersion:
+-		log.Warningf(""code not at same version: peer has version %s, daemon has version %s, disconnecting from peer: %s"", hello.CommitSha, h.commitSha, from)
++		log.Debugf(""code not at same version: peer has version %s, daemon has version %s, disconnecting from peer: %s"", hello.CommitSha, h.commitSha, from)
+ 		s.Conn().Close() // nolint: errcheck
+ 		return
+ 	case nil: // ok, noop","Should the ""bad hello message"" case above also disconnect?",Why is this a debug message?
+5171,"@@ -18,6 +18,9 @@ public abstract class InsulinOrefBasePlugin implements PluginBase, InsulinInterf
+ 
+     public static double MIN_DIA = 5;
+ 
++    protected static boolean fragmentEnabled = false;
++    protected static boolean fragmentVisible = false;
++
+     long lastWarned = 0;
+ 
+     @Override",Shouldn't this be in the child and not in the base plugin? Wouldn't having it here enable all derived plugins at once?,Why is this needed?
+5172,"@@ -226,6 +226,11 @@ FILTERING
+           (options[:full_description] ||= []) << Regexp.compile(Regexp.escape(o))
+         end
+ 
++        parser.on('-E', '--example-matches STRING', ""Run examples whose full nested names match REGEX (may be"",
++                  ""  used more than once)"") do |o|
++          (options[:full_description] ||= []) << Regexp.compile(o)
++        end
++
+         parser.on('-t', '--tag TAG[:VALUE]',
+                   'Run examples with the specified tag, or exclude examples',
+                   'by adding ~ before the tag.',",Should probably say REGEX or PATTERN rather than string.,I don't think this is the right way to do it. I think it would be better to use the `<msg>`<msg>`Regexp.escape(o)` instead.
+5173,"@@ -179,14 +179,14 @@ func TestHandler(t *testing.T) {
+ 			name:     ""an event with a very large payload"",
+ 			method:   ""POST"",
+ 			path:     ""/ns1/broker1"",
+-			event:    createTestEventWithPayloadSize(""test-event"", 110000000),
++			event:    createTestEventWithPayloadSize(""test-event"", 10000001), // 10Mb + extra byte
+ 			wantCode: nethttp.StatusRequestEntityTooLarge,
+ 		},
+ 		{
+ 			name:          ""malicious requests or requests with unknown Content-Length and a very large payload"",
+ 			method:        ""POST"",
+ 			path:          ""/ns1/broker1"",
+-			event:         createTestEventWithPayloadSize(""test-event"", 110000000),
++			event:         createTestEventWithPayloadSize(""test-event"", 10000001), // 10Mb + extra byte
+ 			contentLength: ptr.Int64(-1),
+ 			wantCode:      nethttp.StatusRequestEntityTooLarge,
+ 		},","I felt we don't need to set it that strict, like if somehow pubsub happens to allow extra 20 bytes for metadata, this test won't work. We would suggest to use 11MB instead.",why did you change this?
+5174,"@@ -34,7 +34,7 @@ class AutocompleteTypeConfigurator implements TypeConfiguratorInterface
+         }
+ 
+         // by default, allow to autocomplete multiple values for OneToMany and ManyToMany associations
+-        if (!isset($options['multiple']) && $metadata['associationType'] & ClassMetadata::TO_MANY) {
++        if (!isset($options['multiple']) && isset($metadata['associationType']) && $metadata['associationType'] & ClassMetadata::TO_MANY) {
+             $options['multiple'] = true;
+         }
+ ","In theory `isset($metadata['associationType'])` is `false` if the linked field is not an association field, isn't?",Shouldn't this be `&&` instead of `&&`?
+5175,"@@ -84,7 +84,7 @@ Doorkeeper.configure do
+   #
+   # If not specified, Doorkeeper enables all the four grant flows.
+   #
+-  # grant_flows %w(authorization_code implicit password client_credentials)
++  grant_flows %w(authorization_code implicit password client_credentials)
+ 
+   # Under some circumstances you might want to have applications auto-approved,
+   # so that the user skips the authorization step.",@tute the only thing I needed to enable this like as `password` is not in default flow anymore I think.,Style/PercentLiteralDelimiters: %w-literals should be delimited by [ and ].
+5176,"@@ -52,7 +52,8 @@ class IamPolicyTest(ForsetiTestCase):
+             'serviceAccount:abc@def.gserviceaccount.com',
+             'user:someone@somewhere.tld',
+             'allUsers',
+-            'user:anything'
++            'user:anything',
++            'allAuthenticatedUsers'
+         ]
+ 
+     # Test IamPolicyMember","nit: to be consistent with `self.members`, please move this up one line, so that it's closer to `allUsers`? You will need to update your test reference.",Why did you change this?
+5177,"@@ -4,6 +4,7 @@ const config = require('./config')
+ const fs = require('fs-extra')
+ 
+ const runGClient = (args, options = {}) => {
++  if (options.verbose) args.push('--verbose')
+   options.cwd = options.cwd || config.rootDir
+   options = mergeWithDefault(options)
+   options.env.GCLIENT_FILE = config.gClientFile",we might as well just access `config.gClientVerbose` directly here. If any other options are passed to `gclientSync` or `gclientRunhooks` then the verbose option will be lost the way it's used now,Why do we need this?
+5178,"@@ -353,6 +353,7 @@ return [
+     'log' => [
+         'menu_label' => 'Log settings',
+         'menu_description' => 'Specify which areas should use logging.',
++        'logging' => 'Logging',
+         'log_events' => 'Log system events',
+         'log_events_comment' => 'Browser requests that may require attention, such as 404 errors.',
+         'log_requests' => 'Log bad requests',",Change the key to `default_tab` instead and I'll merge this,I think this should be `
+5179,"@@ -387,8 +387,11 @@ module OrgAdmin
+               end
+             end
+           end
+-        else
+-          # If no funder was selected retrieve the Org's templates
++        end
++        
++        # If the no funder was specified OR the funder matches the org
++        if funder_id.blank? || funder_id == org_id
++          # Retrieve the Org's templates
+           templates << Template.organisationally_visible.valid.where(published: true, org_id: org_id, customization_of: nil).to_a
+         end
+         ",we still can end up passing a blank org_id to the scope method if for any reason the params is not present...,Layout/EmptyLinesAroundB
+5180,"@@ -236,7 +236,9 @@ public class SaxonXPathRuleQuery extends AbstractXPathRuleQuery {
+         */
+         if (value == null) {
+             return UntypedAtomicValue.ZERO_LENGTH_UNTYPED;
+-
++        } else if (value instanceof Enum) {
++            // enums use their toString
++            return new StringValue(value.toString());
+         } else if (value instanceof String) {
+             return new StringValue((String) value);
+         } else if (value instanceof Boolean) {","I think yes, this makes sense to expose this. +1",I'm not sure if this is the right way to do it. I think it would be better to use `value.getClass().getSimpleName()` instead.
+5181,"@@ -33,7 +33,7 @@ metadata:
+       - name: StorageType
+         value: ""hostpath""
+       - name: BasePath
+-        value: ""/var/openebs/local""
++        value: {{env ""OPENEBS_IO_LOCALPV_HOSTPATH_DIR"" | default ""/var/openebs/local""}} 
+ provisioner: openebs.io/local
+ volumeBindingMode: WaitForFirstConsumer
+ reclaimPolicy: Delete",let us put the sample yaml snippet i.e. maya api server deployment that makes use of this env & value,I don't think this is needed.
+5182,"@@ -117,12 +117,12 @@ public class ITRabbitMQCollector {
+ 
+   /** Guards against errors that leak from storage, such as InvalidQueryException */
+   @Test
+-  public void skipsOnSpanConsumerException() throws Exception {
++  public void skipsOnSpanConsumerException() {
+     // TODO: reimplement
+   }
+ 
+   @Test
+-  public void messagesDistributedAcrossMultipleThreadsSuccessfully() throws Exception {
++  public void messagesDistributedAcrossMultipleThreadsSuccessfully() {
+     // TODO: reimplement
+   }
+ }",What changed to cause this?,Why did you change this?
+5183,"@@ -81,6 +81,8 @@ func waitForBalanceState(t *testing.T, processor *PromiseProcessor, expectedStat
+ 
+ type fakeStorage struct{}
+ 
+-func (fs fakeStorage) Store(issuer string, data interface{}) error  { return nil }
+-func (fs fakeStorage) Delete(issuer string, data interface{}) error { return nil }
+-func (fs fakeStorage) Close() error                                 { return nil }
++func (fs fakeStorage) Store(issuer string, data interface{}) error                         { return nil }
++func (fs fakeStorage) Delete(issuer string, data interface{}) error                        { return nil }
++func (fs fakeStorage) Close() error                                                        { return nil }
++func (fs fakeStorage) StoreSession(bucketName string, key string, value interface{}) error { return nil }
++func (fs fakeStorage) GetAll(issuer string, data interface{}) error                        { return nil }",Repeating big interface in many places shows smtg is wrong with design,Why do we need to return nil here?
+5184,"@@ -0,0 +1,15 @@
++class Accounts::ChartsController < AccountsController
++  include SetAccountByAccountId
++
++  before_action :redirect_if_disabled
++
++  # NOTE: Replaces accounts#commits_history
++  def commits_by_project
++    render json: Chart.new(@account).commits_by_project
++  end
++
++  # NOTE: Replaces accounts#language_experience
++  def commits_by_language
++    render json: Chart.new(@account).commits_by_language(params[:scope])
++  end
++end",Inheriting from `AccountsController` to get access to the `redirect_if_disabled` filter.,I don't think we need this line.
+5185,"@@ -1,14 +1,15 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+-# SPDX - License - Identifier: Apache - 2.0
++# SPDX-License-Identifier: Apache-2.0
++
++# Purpose
++# This code demonstrates how to copy an object from one Amazon Simple Storage Solution (Amazon S3) bucket to another.
+ 
+ # snippet-start:[s3.ruby.copy_object_between_buckets.rb]
+ require 'aws-sdk-s3'
+ 
+-# Copies an object from one Amazon S3 bucket to another.
+-#
+ # Prerequisites:
+ #
+-# - Two S3 buckets (a source bucket and a target bucket).
++# - Two Amazon S3 buckets (a source bucket and a target bucket).
+ # - An object in the source bucket to be copied.
+ #
+ # @param s3_client [Aws::S3::Client] An initialized Amazon S3 client.",Simple Storage **Service**,I'm not sure if this is the righ
+5186,"@@ -0,0 +1 @@
++public class A { public int FUNC() { Class<?> cls = null; if(cls == null) return 0; else { B.FUNC3(cls); return 1;} } public void FUNC2(Class<?> arg) { return; }}class B {public static void FUNC3(Class<?> arg) { return; }}",Enter at the end of the file! :-D (and at the end of lines ;-) ),
+5187,"@@ -0,0 +1,9 @@
++class RenameScheduledForCancellation < ActiveRecord::Migration
++  def change
++    rename_column(
++      :subscriptions,
++      :scheduled_for_cancellation_on,
++      :scheduled_for_deactivation_on,
++    )
++  end
++end",Put a comma after the last parameter of a multiline method call.,I think this should be `Schedule
+5188,"@@ -88,7 +88,17 @@ func removeYields(plan *PlanSpec) (*PlanSpec, error) {
+ 			}
+ 
+ 			newRoot := root.Predecessors()[0]
+-			newRoot.RemoveSuccessor(root)
++			newSucc := make([]PlanNode, 0, len(newRoot.Successors()))
++
++			for _, succ := range newRoot.Successors() {
++				newSucc = append(newSucc, succ)
++				if succ == root {
++					continue
++				}
++			}
++
++			newRoot.ClearSuccessors()
++			newRoot.AddSuccessors(newSucc...)
+ 			plan.Replace(root, newRoot)
+ 			plan.Results[name] = newRoot
+ 			continue",Don't you want to place this check before you add `succ` to `newSucc`?,Why do we need this?
+5189,"@@ -1,18 +1,6 @@
+ package com.fsck.k9.fragment;
+ 
+ 
+-import java.util.ArrayList;
+-import java.util.Collections;
+-import java.util.Comparator;
+-import java.util.EnumMap;
+-import java.util.HashMap;
+-import java.util.HashSet;
+-import java.util.List;
+-import java.util.Map;
+-import java.util.Map.Entry;
+-import java.util.Set;
+-import java.util.concurrent.Future;
+-
+ import android.app.Activity;
+ import android.content.BroadcastReceiver;
+ import android.content.Context;",Commit 676eeeab10884456a5f70ce708a8aa5116ecbaf7 contains a lot of unrelated code style changes. Please get rid of these.,Why are these import
+5190,"@@ -82,7 +82,10 @@ class BokehRenderer(Renderer):
+             if bokeh_version < '0.12.6':
+                 raise RuntimeError('Bokeh png export only supported by versions >=0.12.6.')
+             from bokeh.io import _get_screenshot_as_png
+-            img = _get_screenshot_as_png(plot.state)
++            if bokeh_version > '0.12.6':
++                img = _get_screenshot_as_png(plot.state, None)
++            else:
++                img = _get_screenshot_as_png(plot.state)
+             imgByteArr = BytesIO()
+             img.save(imgByteArr, format='PNG')
+             return imgByteArr.getvalue(), info","Well this sucks, I wish you'd mentioned you were using a private API, perhaps we could have made a public one with better guarantees before `0.12.6` was released.",I don't think this i
+5191,"@@ -69,17 +69,10 @@ func New(transport peer.Transport, opts ...ListOption) *List {
+ 			&pendingHeap{},
+ 			plOpts...,
+ 		),
+-		capacity: cfg.capacity,
+ 	}
+ }
+ 
+ // List is a PeerList which rotates which peers are to be selected in a circle
+ type List struct {
+ 	*peerlist.List
+-	capacity int
+-}
+-
+-// Capacity is the maximum number of peers the peer list will hold.
+-func (l *List) Capacity() int {
+-	return l.capacity
+ }",Consider instead moving this into an _test file so it's public but only usable in tests.,Why is this removed?
+5192,"@@ -146,10 +146,10 @@ func (s *ec2Ops) waitAttachmentStatus(
+ 	request := &ec2.DescribeVolumesInput{VolumeIds: []*string{&id}}
+ 	actual := """"
+ 	interval := 2 * time.Second
+-	fmt.Printf(""Waiting for state transition to %q"", desired)
++	logrus.Infof(""Waiting for state transition to %q"", desired)
+ 
+ 	var outVol *ec2.Volume
+-	for elapsed, runs := 0*time.Second, 0; actual != desired && elapsed < timeout; elapsed += interval {
++	for elapsed, runs := 0*time.Second, 0; actual != desired && elapsed < timeout; elapsed, runs = elapsed+interval, runs+1 {
+ 		awsVols, err := s.ec2.DescribeVolumes(request)
+ 		if err != nil {
+ 			return nil, err","Any reason why we want to remove this code ? It helps debugging AWS ebs attach issues. Ideally yes a library should have minimal logging, but there is no way we can track long running AWS attach calls.","I think this should be `logrus.Infof(""Waiting for state transition to %q"", desired)`"
+5193,"@@ -87,9 +87,10 @@ func (fs *experimentStore) CreateExperiment(ctx context.Context, config *any.Any
+ 			INSERT INTO experiment_run (
+                 id, 
+ 		        experiment_config_id,
+-		        execution_time,
++						execution_time,
++						scheduled_end_time,
+ 		        creation_time)
+-            VALUES ($1, $2, tstzrange($3, $4, '[]'), NOW())`
++            VALUES ($1, $2, tstzrange($3, $4, '[]'), $4, NOW())`
+ 
+ 	runId := id.NewID()
+ 	_, err = fs.db.ExecContext(ctx, runSql, runId, configID, startTime, endTime)",nit: indentation doesn't match (unfortunately i don't know of a way to automatically lint these sql statements with how we're using them currently),I think this should be `scheduled_end_time`
+5194,"@@ -231,6 +231,7 @@ module RSpec::Core
+       return if @setup
+ 
+       @setup_default.call
++      setup_profiler
+       @setup = true
+     end
+ ","Should we remove the other `setup_profiler` call site and just let this be the one call site for it, since, AFAIK, the other one is no longer necessary with this? Also, can we make `setup_profiler` private?",def setup_profiler
+5195,"@@ -151,7 +151,6 @@ func BuildEnvShowCmd() *cobra.Command {
+ 		GlobalOpts: NewGlobalOpts(),
+ 	}
+ 	cmd := &cobra.Command{
+-		Hidden: true, //TODO remove when ready for production!
+ 		Use:    ""show"",
+ 		Short:  ""Shows info about a deployed environment."",
+ 		Long:   ""Shows info about a deployed environment, including region, account ID, and services."",","Are there any other templates where this command needs to be added, or were those issues specific to storage requiring us to enable a new command group?",Why is this removed?
+5196,"@@ -1,18 +1,3 @@
+ // +build !linux !cgo !seccomp
+ 
+ package patchbpf
+-
+-import (
+-	""errors""
+-
+-	""github.com/opencontainers/runc/libcontainer/configs""
+-
+-	libseccomp ""github.com/seccomp/libseccomp-golang""
+-)
+-
+-func PatchAndLoad(config *configs.Seccomp, filter *libseccomp.ScmpFilter) error {
+-	if config != nil {
+-		return errors.New(""cannot patch and load seccomp filter without runc seccomp support"")
+-	}
+-	return nil
+-}",perhaps file can be removed altogether (trying to avoid an empty package for these build tags),Why are we removing this?
+5197,"@@ -980,7 +980,7 @@ get_module_handle_64(const wchar_t *name)
+ {
+     /* Be careful: we can't directly de-ref any ptrs b/c they can be >4GB */
+     LDR_MODULE_64 mod;
+-    if (!get_ldr_module_64(name, NULL, &mod))
++    if (!get_ldr_module_64(name, 0, &mod))
+         return NULL;
+     return mod.BaseAddress;
+ }","NULL change, could you move that out too?",Shouldn't this be `&mod`?
+5198,"@@ -25,6 +25,10 @@ func formatKV(in []string) string {
+ 	return columnize.Format(in, columnConf)
+ }
+ 
++func FormatList(in []string) string {
++	return formatList(in)
++}
++
+ // formatList takes a set of strings and formats them into properly
+ // aligned output, replacing any blank fields with a placeholder
+ // for awk-ability.",A brief explanation about this func is required.,I'm not sure if this is t
+5199,"@@ -32,6 +32,11 @@ class MergedCellsCollection {
+     this.hot = plugin.hot;
+   }
+ 
++  static IS_OVERLAPPING_WARNING(newMergedCell) {
++    return `The merged cell declared at [${newMergedCell.row}, ${newMergedCell.col}] overlaps with the other ` +
++      'declared merged cell. The overlapping merged cell was not added to the table, please fix your setup.';
++  }
++
+   /**
+    * Get a merged cell from the container, based on the provided arguments. You can provide either the ""starting coordinates""
+    * of a merged cell, or any coordinates from the body of the merged cell.",Could you add description for below static function?,I think this should be `I
+5200,"@@ -453,7 +453,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
+ 	blocksFetched := uint64(1) // we already got the first block in the previous step.
+ 	var blk *bookkeeping.Block
+ 	var client FetcherClient
+-	for attemptsCount := uint64(1); blocksFetched <= lookback; attemptsCount++ {
++	for attemptsCount := uint64(1); blocksFetched <= lookback; {
+ 		if err := cs.ctx.Err(); err != nil {
+ 			return cs.stopOrAbort()
+ 		}","Since this is only counting the failed attempts, can you call it failedAttemptsCount or retryCount instead of attemptsCount?",Why did you change this?
+5201,"@@ -21,7 +21,7 @@
+ 
+ """"""Installation script for Python nupic package.""""""
+ 
+-import os
++import OOOOOOOOOOOos
+ import pkg_resources
+ import sys
+ ",I don't think this will work.,Why do we need this chan
+5202,"@@ -0,0 +1,11 @@
++using System.IO.Pipelines;
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
++{
++    public interface IHttpParser
++    {
++        bool ParseRequestLine<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined) where T : IHttpRequestLineHandler;
++
++        bool ParseHeaders<T>(T handler, ReadableBuffer buffer, out ReadCursor consumed, out ReadCursor examined, out int consumedBytes) where T : IHttpHeadersHandler;
++    }
++}",Since http2 is coming do we want to call this something more specific?,Why is this an interface
+5203,"@@ -11,8 +11,8 @@
+   </div>
+ </nav>
+ 
+-<%= content_tag :div, class: 'navbar-search navbar navbar-light bg-light', role: 'navigation', aria: { label: t('blacklight.search.header') } do %>
++<div class=""navbar-search navbar navbar-light bg-light"" role=""navigation"">
+   <div class=""<%= container_classes %>"">
+     <%= render_search_bar  %>
+   </div>
+-<% end %>
++</div>","I don't think we want to revert the accessibility issues the tool caught, do we?",Why did you remove the a
+5204,"@@ -285,8 +285,11 @@ func (rt *RequestTracker) Accept() (conn net.Conn, err error) {
+ 		rt.hostRequests.pruneRequests(rateLimitingWindowStartTime)
+ 		originConnections := rt.hostRequests.countOriginConnections(trackerRequest.remoteHost, rateLimitingWindowStartTime)
+ 
++		remoteHostIsNonLocal := (!rt.config.DisableLocalhostConnectionRateLimit) || (!isLocalhost(trackerRequest.remoteHost))
++		connectionLimitEnabled := rt.config.ConnectionsRateLimitingWindowSeconds > 0 && rt.config.ConnectionsRateLimitingCount > 0
++
+ 		// check the number of connections
+-		if originConnections > rt.config.ConnectionsRateLimitingCount && rt.config.ConnectionsRateLimitingWindowSeconds > 0 && rt.config.ConnectionsRateLimitingCount > 0 {
++		if originConnections > rt.config.ConnectionsRateLimitingCount && connectionLimitEnabled && remoteHostIsNonLocal {
+ 			rt.hostRequestsMu.Unlock()
+ 			networkConnectionsDroppedTotal.Inc(map[string]string{""reason"": ""incoming_connection_per_ip_tcp_rate_limit""})
+ 			rt.log.With(""connection"", ""tcp"").With(""count"", originConnections).Debugf(""Rejected connection due to excessive connections attempt rate"")",I prefer naming this rateLimitedRemoteHost This can be local host but reads remote Host Is Non Local.,"I don't think we need to check `connectionLimitEnabled` here. If `DisableLocalhostConnectionRateLimit` is true, then `ConnectionsRateLimitingCount` will be 0."
+5205,"@@ -105,7 +105,7 @@ export function initDebug() {
+ 					`\n\n${getOwnerStack(vnode)}`
+ 			);
+ 		} else if (type != null && typeof type === 'object') {
+-			if (type._lastDomChild !== undefined && type._dom !== undefined) {
++			if (type._lastDomChildSibling !== undefined && type._dom !== undefined) {
+ 				throw new Error(
+ 					`Invalid type passed to createElement(): ${type}\n\n` +
+ 						'Did you accidentally pass a JSX literal as JSX twice?\n\n' +",Hmm I think I might've messed up this condition here... Need to look more at it,Why is this change needed?
+5206,"@@ -118,11 +118,9 @@ class DocumentQueue:
+         if doc_type == DocTypes.PACKAGE:
+             if not handle or not package_hash or not pointer_file:
+                 raise ValueError(""missing required argument for package document"")
+-            if (
+-                package_stats
+-                and not isinstance(package_stats, dict)
+-                or isinstance(package_stats, dict)
+-                and any(k not in package_stats for k in ['total_files', 'total_bytes'])
++            if not (
++                package_stats is None
++                or isinstance(package_stats, dict) and {'total_files', 'total_bytes'}.issubset(package_stats)
+             ):
+                 raise ValueError(""Malformed package_stats"")
+             body.update({",This also makes the exception to be raised on non-dict falsy values which I think was expected.,"`package_stats is None or isinstance(package_stats, dict)`"
+5207,"@@ -173,7 +173,7 @@ class Dataset(Element):
+ 
+     # In the 1D case the interfaces should not automatically add x-values
+     # to supplied data
+-    _auto_indexable_1d = False
++    _auto_indexable_1d = True
+ 
+     # Define a class used to transform Datasets into other Element types
+     _conversion_interface = DataConversion",Is this correct? The auto indexing behavior caused problems fixed in a recently merged PR...,Why do we need this change?
+5208,"@@ -6,9 +6,9 @@ setup(
+     py_modules=[""rtool""],
+     install_requires=[
+         ""click>=6.2, <7.0"",
+-        ""twine>=1.6.5, <1.9"",
++        ""twine>=1.6.5, <1.10"",
+         ""pysftp==0.2.8"",
+-        ""cryptography>=1.6, <1.7"",
++        ""cryptography>=1.6, <1.9"",
+     ],
+     entry_points={
+         ""console_scripts"": [","Hmm, didn't we just find out that 1.6 *does NOT* work? We should bump the minimum as well.",Why is this needed?
+5209,"@@ -0,0 +1,13 @@
++#include <iostream>
++#include <rai/lib/utility.hpp>
++
++void release_assert_internal (bool check, const char * check_expr, const char * file, unsigned int line)
++{
++	if (check)
++	{
++		return;
++	}
++
++	std::cerr << ""Assertion ("" << check_expr << "") failed "" << file << "":"" << line << std::endl;
++	abort();
++}",Will calling `abort()` cause problems for our test suite?,Why is this needed?
+5210,"@@ -292,6 +292,11 @@ ast_result_t pass_expr(ast_t** astp, pass_opt_t* options)
+     case TK_ADDRESS:    r = expr_addressof(options, ast); break;
+     case TK_DIGESTOF:   r = expr_digestof(options, ast); break;
+ 
++    case TK_OBJECT:
++      if(!expr_object(options, astp))
++        return AST_FATAL;
++      break;
++
+     case TK_LAMBDA:
+       if(!expr_lambda(options, astp))
+         return AST_FATAL;","for my own edificaton, what's this?",I don't think this 
+5211,"@@ -248,13 +248,14 @@ func (sf *factory) NewWorkingSet() (WorkingSet, error) {
+ 
+ // Commit persists all changes in RunActions() into the DB
+ func (sf *factory) Commit(ws WorkingSet) error {
++	if ws == nil {
++		return nil
++	}
+ 	sf.mutex.Lock()
+ 	defer sf.mutex.Unlock()
+-	if ws != nil {
+-		if sf.currentChainHeight != ws.Version() {
+-			// another working set with correct version already committed, do nothing
+-			return nil
+-		}
++	if sf.currentChainHeight != ws.Version() {
++		// another working set with correct version already committed, do nothing
++		return nil
+ 	}
+ 	if err := ws.Commit(); err != nil {
+ 		return errors.Wrap(err, ""failed to commit working set"")",make it harmless to commit ws == nil,Why is this change 
+5212,"@@ -59,6 +59,8 @@ var locationsReplacement = regexp.MustCompile(`\$\(locations ([^\)]+)\)`)
+ var exeReplacement = regexp.MustCompile(`\$\(exe ([^\)]+)\)`)
+ var outExeReplacement = regexp.MustCompile(`\$\(out_exe ([^\)]+)\)`)
+ var outReplacement = regexp.MustCompile(`\$\(out_location ([^\)]+)\)`)
++var absOutExeReplacement = regexp.MustCompile(`\$\(abs_out_exe ([^\)]+)\)`)
++var absOutReplacement = regexp.MustCompile(`\$\(abs_out_location ([^\)]+)\)`)
+ var dirReplacement = regexp.MustCompile(`\$\(dir ([^\)]+)\)`)
+ var hashReplacement = regexp.MustCompile(`\$\(hash ([^\)]+)\)`)
+ var workerReplacement = regexp.MustCompile(`^(.*)\$\(worker ([^\)]+)\) *([^&]*)(?: *&& *(.*))?$`)","Hmmmm, I'm not sure I like these becoming a replacement any build rule has access to. It seems like if it were used in an actual build rule it would only be doing bad things. Can we just use `filepath.Abs` on the returned path in run_step.go?",I don't think we need both of these.
+5213,"@@ -24,8 +24,11 @@ import (
+ 
+ var _reqBody = []byte(""hello"")
+ 
+-func yarpcEcho(ctx context.Context, reqMeta yarpc.ReqMeta, body []byte) ([]byte, yarpc.ResMeta, error) {
+-	return body, yarpc.NewResMeta().Headers(reqMeta.Headers()), nil
++func yarpcEcho(ctx context.Context, body []byte) ([]byte, error) {
++	for _, k := range yarpc.HeaderNames(ctx) {
++		yarpc.WriteResponseHeader(ctx, k, yarpc.Header(ctx, k))
++	}
++	return body, nil
+ }
+ 
+ func httpEcho(t testing.TB) http.HandlerFunc {",That's actually not as bad as I thought it was going to be.,"nit: `return body, nil`"
+5214,"@@ -198,6 +198,11 @@ public class DatasetServiceBean implements java.io.Serializable {
+         return em.createQuery(""SELECT o.id FROM Dataset o WHERE o.indexTime IS null ORDER BY o.id DESC"", Long.class).getResultList();
+     }
+ 
++    //Used in datasets listcurationstatus API
++    public List<Dataset> findAllUnpublished() {
++        return em.createQuery(""SELECT object(o) FROM Dataset o, DvObject d WHERE d.id=o.id and d.publicationDate IS null ORDER BY o.id ASC"", Dataset.class).getResultList();
++    }
++
+     /**
+      * For docs, see the equivalent method on the DataverseServiceBean.
+      * @param numPartitions","Hmm, I'm surprised if we don't already have a ""find all unpublished datasets"" method but I don't really know. Maybe @scolapasta knows.",This method is not used.
+5215,"@@ -598,6 +598,12 @@ class Python3Checker(checkers.BaseChecker):
+             ""variables will be deleted outside of the ""
+             ""comprehension."",
+         ),
++        ""C1601"": (
++            ""Consider using Python 3 style super() without arguments"",
++            ""old-style-super"",
++            ""Emitted when calling the super builtin with the current class ""
++            ""and instance. On Python 3 these arguments are the default."",
++        ),
+     }
+ 
+     _bad_builtins = frozenset(","The checks in this file are disabled by default since they are meant for Python 3 porting, and this one does not have to do with Python 3 porting at all.",I don't think this is the right way 
+5216,"@@ -0,0 +1,18 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++namespace Microsoft.AspNetCore.Server.Kestrel.Core.Features
++{
++    /// <summary>
++    /// Feature to set the minimum data rate at which the response should be sent.
++    /// </summary>
++    public interface IHttpMinResponseDataRateFeature
++    {
++        /// <summary>
++        /// The minimum data rate in bytes/second at which the response should be sent.
++        /// Setting this property to null indicates no minimum data rate should be enforced.
++        /// This limit has no effect on upgraded connections which are always unlimited.
++        /// </summary>
++        MinDataRate MinDataRate { get; set; }
++    }
++}","I would change ""should be sent"" to ""must be received"".",I think this should be called `IHttpMaxResponseDataRateFeature`
+5217,"@@ -24,6 +24,8 @@ import (
+ 	""github.com/openebs/maya/pkg/storagepool""
+ )
+ 
++
++// DeleteStoragePool receives StoragePoolClaim object and deletes it. 
+ func DeleteStoragePool(spcGot *v1alpha1.StoragePoolClaim) error {
+ 	// Business logic for deletion of storagepool
+ 	glog.Infof(""Storagepool delete event received for storagepoolclaim %s"", spcGot.Name)",Please put it in following way : `// DeleteStoragePool receives StoragePoolClaim delete event and calls the required handlers to delete other pool related resources.`,// DeleteStoragePool deletes a StoragePoolClaim object
+5218,"@@ -58,4 +58,16 @@ public final class RestConst {
+   public static final String CONSUMER_HEADER = ""servicecomb-rest-consumer-header"";
+ 
+   public static final String READ_STREAM_PART = ""servicecomb-readStreamPart"";
++
++  public static final String UPLOAD_DIR = ""cse.uploads.directory"";
++
++  // limit of one upload file, only available for servlet rest transport
++  public static final String UPLOAD_MAX_FILE_SIZE = ""cse.uploads.maxFileSize"";
++
++  // limit of upload request body
++  public static final String UPLOAD_MAX_SIZE = ""cse.uploads.maxSize"";
++
++  // the size threshold after which files will be written to disk
++  // only available for servlet rest transport
++  public static final String UPLOAD_FILE_SIZE_THRESHOLD = ""cse.uploads.fileSizeThreshold"";
+ }",It's better to use servicecomb now.,I don't see this being used anywhere.
+5219,"@@ -58,12 +58,13 @@ var PolicyChain = policies.Chain{
+ 
+ type controller struct {
+ 	// the policies to use to define readiness - named here to make testing simpler
+-	policyChain              policies.Chain
+-	certificateLister        cmlisters.CertificateLister
+-	certificateRequestLister cmlisters.CertificateRequestLister
+-	secretLister             corelisters.SecretLister
+-	client                   cmclient.Interface
+-	gatherer                 *policies.Gatherer
++	policyChain                      policies.Chain
++	certificateLister                cmlisters.CertificateLister
++	certificateRequestLister         cmlisters.CertificateRequestLister
++	secretLister                     corelisters.SecretLister
++	client                           cmclient.Interface
++	gatherer                         *policies.Gatherer
++	defaultRenewBeforeExpiryDuration time.Duration
+ }
+ 
+ func NewController(",Make the flag derived default available in the readiness controller,I think this should be `defaultRenewAfterExpiryDuration time.Du
+5220,"@@ -278,6 +278,10 @@ func TestReconcileClusterSync_NoWorkToDo(t *testing.T) {
+ 				}),
+ 			),
+ 		},
++		{
++			name: ""syncset pause"",
++			cd:   cdBuilder(scheme).GenericOptions(testgeneric.WithAnnotation(constants.SyncsetPauseAnnotation, ""true"")).Build(),
++		},
+ 	}
+ 	for _, tc := range cases {
+ 		t.Run(tc.name, func(t *testing.T) {",Confirmed this test fails when the fix is reverted ,Why is this needed?
+5221,"@@ -38,6 +38,9 @@ func NewCollector(options *LogOptions) *Collector {
+ 
+ // Archive creates ZIP archive containing all node log files.
+ func (c *Collector) Archive() (outputFilepath string, err error) {
++	if c.options.Filepath == """" {
++		return """", errors.New(""file logging is disabled, can't retrieve logs"")
++	}
+ 	filepaths, err := c.logFilepaths()
+ 	if err != nil {
+ 		return """", err",This method is still possible insecure as it may archive not only logs files. I suggest to filter file names to ensure that they start with `.mysterium-log*`.,nit: `can't retriev
+5222,"@@ -14,6 +14,15 @@ class BaseDenseHead(BaseModule, metaclass=ABCMeta):
+     def __init__(self, init_cfg=None):
+         super(BaseDenseHead, self).__init__(init_cfg)
+ 
++    def init_weights(self):
++        super(BaseDenseHead, self).init_weights()
++        # avoid init_cfg overwrite the initialization of `conv_offset`
++        for m in self.modules():
++            # DeformConv2dPack, ModulatedDeformConv2dPack
++            if hasattr(m, 'conv_offset'):
++                m.conv_offset.weight.data.zero_()
++                m.conv_offset.bias.data.zero_()
++
+     @abstractmethod
+     def loss(self, **kwargs):
+         """"""Compute losses of the head.""""""",DCN should not be able to use `init_cfg`.,Why do we need this
+5223,"@@ -28,7 +28,7 @@ namespace OpenTelemetry.Shims.OpenTracing
+         {
+             if (!spanContext.IsValid)
+             {
+-                throw new ArgumentException(nameof(spanContext));
++                throw new ArgumentException($""{nameof(spanContext)} must be valid."");
+             }
+ 
+             this.SpanContext = spanContext;","It is a bit weird to see a message like ""something must be valid"".",This should be `nam
+5224,"@@ -119,10 +119,10 @@ public class Standalone implements CliCommand {
+       LoggingOptions loggingOptions = new LoggingOptions(config);
+       loggingOptions.configureLogging();
+ 
+-      LOG.info(""Logging configured."");
++      LOG.finest(""Logging configured."");
+ 
+       DistributedTracer tracer = loggingOptions.getTracer();
+-      LOG.info(""Using tracer: "" + tracer);
++      LOG.finest(""Using tracer: "" + tracer);
+       GlobalDistributedTracer.setInstance(tracer);
+ 
+       EventBusConfig events = new EventBusConfig(config);","Again. This is part of the start up of the server, and the diagnostics are helpful.",Why is this change needed?
+5225,"@@ -139,6 +139,12 @@ describe Travis::Build::Script::R, :sexp do
+                          echo: true, timing: true]
+   end
+ 
++  it 'skips PDF manual when LaTeX is disabled' do
++    data[:config][:latex] = false
++    should include_sexp [:cmd, /.*R CMD check.* --no-manual.*/,
++                         echo: true, timing: true]
++  end
++
+   describe 'bioc configuration is optional' do
+     it 'does not install bioc if not required' do
+       should_not include_sexp [:cmd, /.*biocLite.*/,","I think you need a `,` at the end of the line?",I think this should be `sh
+5226,"@@ -54,10 +54,7 @@ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbEntityOperation;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperation.State;
+ import org.camunda.bpm.engine.impl.db.entitymanager.operation.DbOperationType;
+-import org.camunda.bpm.engine.impl.util.DatabaseUtil;
+-import org.camunda.bpm.engine.impl.util.ExceptionUtil;
+-import org.camunda.bpm.engine.impl.util.IoUtil;
+-import org.camunda.bpm.engine.impl.util.ReflectUtil;
++import org.camunda.bpm.engine.impl.util.*;
+ 
+ /**
+ *",Please avoid wildcard imports.,Please don't use wildcard 
+5227,"@@ -84,6 +84,9 @@ namespace Microsoft.DotNet.Build.CloudTestTasks
+                     using (HttpClient client = new HttpClient())
+                     {
+                         client.DefaultRequestHeaders.Clear();
++
++                        // In random occassions the request fails if the network is slow and it takes more than 100 seconds to upload 4MB. 
++                        client.Timeout = TimeSpan.FromMinutes(5);
+                         Func<HttpRequestMessage> createRequest = () =>
+                         {
+                             DateTime dt = DateTime.UtcNow;",Did we consider making the timeout an argument to the build task? Would amke it easer to configure in the future: change a build property vs. rebuilding the DLL.,Why do we need this?
+5228,"@@ -238,9 +238,17 @@ func run(o *Options) error {
+ 	}
+ 
+ 	var egressController *egress.EgressController
++	var nodeIP net.IP
++	if nodeConfig.NodeIPv4Addr != nil {
++		nodeIP = nodeConfig.NodeIPv4Addr.IP
++	} else if nodeConfig.NodeIPv6Addr != nil {
++		nodeIP = nodeConfig.NodeIPv6Addr.IP
++	} else {
++		return fmt.Errorf(""invalid NodeIPAddr in Node config: %v"", nodeConfig)
++	}
+ 	if features.DefaultFeatureGate.Enabled(features.Egress) {
+ 		egressController, err = egress.NewEgressController(
+-			ofClient, antreaClientProvider, crdClient, ifaceStore, routeClient, nodeConfig.Name, nodeConfig.NodeIPv4Addr.IP,
++			ofClient, antreaClientProvider, crdClient, ifaceStore, routeClient, nodeConfig.Name, nodeIP,
+ 			o.config.ClusterMembershipPort, egressInformer, nodeInformer, externalIPPoolInformer,
+ 		)
+ 		if err != nil {","dumb question: the commit message talks about dual-stack support but it seems that in a dual-stack cluster, Egress will only support the IPv4 address family?","nit: `if nodeIP, ok := nodeConfig.NodeIPv4Addr.IP, nodeConfig.NodeIPv6Addr.IP; ok {`"
+5229,"@@ -230,7 +230,7 @@ class ServerTLSLayer(_TLSLayer):
+                     server.sni = self.context.client.sni.encode(""idna"")
+                 else:
+                     server.sni = server.address[0].encode(""idna"")
+-                    self.tls[server].set_tlsext_host_name(server.sni)
++                self.tls[server].set_tlsext_host_name(server.sni)
+         self.tls[server].set_connect_state()
+ 
+         yield from self.process(events.DataReceived(server, b""""))",Do you want to cherry-pick these separately and get them merged already or keep it in here? Both is fine with me!,Why this change?
+5230,"@@ -57,12 +57,12 @@ public class TestPerformance extends LuceneTestCase {
+ 
+   @Test
+   public void en() throws Exception {
+-    checkAnalysisPerformance(""en"", 1_000_000);
++    checkAnalysisPerformance(""en"", 1_200_000);
+   }
+ 
+   @Test
+   public void en_suggest() throws Exception {
+-    checkSuggestionPerformance(""en"", 1_200);
++    checkSuggestionPerformance(""en"", 3_000);
+   }
+ 
+   @Test",Hmm what are these magical constant numbers? And why does this change mean they should increase?,Why did you change this?
+5231,"@@ -36,7 +36,7 @@ import logging.config
+ import urlparse
+ from boto.exception import InvalidUriError
+ 
+-__version__ = '2.8.0-dev'
++__version__ = '2.8.0'
+ Version = __version__  # for backware compatibility
+ 
+ UserAgent = 'Boto/%s (%s)' % (__version__, sys.platform)",This change shouldn't be included with this push. Shouldn't push version changes with a pull-request.,Why this change?
+5232,"@@ -97,6 +97,9 @@ func (h handler) handle(ctx context.Context, call inboundCall) {
+ 
+ 	err := h.callHandler(ctx, call, responseWriter)
+ 
++	// echo accepted rpc-service in response header in any status
++	responseWriter.addHeader(RespondServiceHeaderKey, call.ServiceName())
++
+ 	// black-hole requests on resource exhausted errors
+ 	if yarpcerrors.FromError(err).Code() == yarpcerrors.CodeResourceExhausted {
+ 		// all TChannel clients will time out instead of receiving an error","nit: let's move this right under where we create the `responseWriter`, before `h.callHandler`",I think we should add this header to the responseWriter as well.
+5233,"@@ -361,7 +361,7 @@ void nano::mdb_store::upgrade_v14_to_v15 (nano::write_transaction & transaction_
+ 
+ 		nano::mdb_val value{ data.size (), (void *)data.data () };
+ 		auto s = mdb_put (env.tx (transaction_a), state_blocks_new, nano::mdb_val (hash), value, MDB_APPEND);
+-		release_assert_success (s);
++		release_assert_success<MDB_val, mdb_store> ((*this), s);
+ 
+ 		// Every so often output to the log to indicate progress
+ 		constexpr auto output_cutoff = 1000000;","The way it was implemented, needed to pass the template values. Please check whether we want this.",Why not `const mdb_store &`?
+5234,"@@ -36,7 +36,8 @@ var daemonCmd = &cmds.Command{
+ 		cmdkit.BoolOption(OfflineMode, ""start the node without networking""),
+ 		cmdkit.BoolOption(ELStdout),
+ 		cmdkit.BoolOption(IsRelay, ""advertise and allow filecoin network traffic to be relayed through this node""),
+-		cmdkit.StringOption(BlockTime, ""time a node waits before trying to mine the next block"").WithDefault(clock.DefaultEpochDuration.String()),
++		cmdkit.StringOption(BlockTime, ""period a node waits between mining successive blocks"").WithDefault(clock.DefaultEpochDuration.String()),
++		cmdkit.StringOption(PropagationDelay, ""time a node waits after the start of an epoch for blocks to arrive"").WithDefault(clock.DefaultPropagationDelay.String()),
+ 	},
+ 	Run: func(req *cmds.Request, re cmds.ResponseEmitter, env cmds.Environment) error {
+ 		return daemonRun(req, re)","Just FYI we need this to align with `builtin.EpochDurationSeconds` from specs-actors or the state machine computations will be off. We'll need to turn this into a config option and follow the same monkey patching paths as the min miner size, seal proof types etc. The EpochDurationSeconds is currently a `const` so can't do it yet tho.",I think this should be `time a node waits between mining success
+5235,"@@ -18,6 +18,7 @@
+ # WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ # IN THE SOFTWARE.
++from __future__ import print_function
+ 
+ import errno
+ import httplib",Is this import needed?,Why do we need this?
+5236,"@@ -68,6 +68,8 @@ storiesOf( 'Dashboard', module )
+ 				<PostSearcher />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} )
+ 	.add( 'URL Search Widget', () => {
+ 		const setupRegistry = ( registry ) => provideSiteInfo( registry );",Dashboard stories also need to have the default padding.,Why do we need this?
+5237,"@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+ 
++  /**
++   * If the compaction should commit rewritten data files using the sequence number at compaction start time instead
++   * of optimistically incrementing the latest sequence number.
++   * <p>
++   * This avoids commit conflicts with updates that add newer equality deletes at a higher sequence number.
++   * <p>
++   * Defaults to false.
++   */
++  String USE_STARTING_SEQUENCE_NUMBER = ""use-starting-sequence-number"";
++  boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = false;
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining",Is there a reason why we wouldn't use this as the default?,I think it would be 
+5238,"@@ -15,7 +15,7 @@ void CreateEdgeProcessor::process(const cpp2::CreateEdgeReq& req) {
+     {
+         // if there is an edge of the same name
+         // TODO: there exists race condition, we should address it in the future
+-        folly::SharedMutex::ReadHolder rHolder(LockUtils::edgeLock());
++        folly::SharedMutex::ReadHolder rHolder(LockUtils::tagLock());
+         auto conflictRet = getTagId(req.get_space_id(), edgeName);
+         if (conflictRet.ok()) {
+             LOG(ERROR) << ""Failed to create edge `"" << edgeName",if there is an tag of the same name?,I'm not sure if this
+5239,"@@ -1,10 +1,8 @@
+ package net
+ 
+ import (
+-	""bytes""
+ 	""errors""
+ 	""fmt""
+-	""os/exec""
+ 	""path/filepath""
+ 	""runtime""
+ ",I'd add `// +build go1.10` to prevent from accidentally compiling with older Go.,Why did you remove t
+5240,"@@ -1,10 +1,12 @@
++from __future__ import unicode_literals
++
+ import numpy as np
+ import param
+ 
+ from ..core import (HoloMap, DynamicMap, CompositeOverlay, Layout,
+                     GridSpace, NdLayout, Store)
+ from ..core.util import (match_spec, is_number, wrap_tuple,
+-                         get_overlay_spec, unique_iterator)
++                         get_overlay_spec, unique_iterator, safe_unicode)
+ 
+ 
+ def displayable(obj):",Not sure how this import relates to the PR but seems like a good idea anyway...,`safe_unicode` is not used.
+5241,"@@ -5,6 +5,7 @@
+ #include ""../CustomBuild/ESPEasyLimits.h""
+ #include ""../DataStructs/DeviceStruct.h""
+ #include ""../../ESPEasy_common.h""
++#include ""../WebServer/HardwarePage.h""
+ 
+ template<unsigned int N_TASKS>
+ SettingsStruct_tmpl<N_TASKS>::SettingsStruct_tmpl() : ResetFactoryDefaultPreference(0) {","Hmm this is strange, why should the SettingsStruct import something from `WebServer` ? If that's really needed, then we must move stuff as it makes no sense to have some code related to viewing things included in a settings struct. It should be the other way around.",Why is this header needed?
+5242,"@@ -4,13 +4,16 @@
+ using System;
+ using Microsoft.AspNet.Builder;
+ using Microsoft.AspNet.Http;
++using Microsoft.Framework.Logging;
+ 
+ namespace SampleApp
+ {
+     public class Startup
+     {
+-        public void Configure(IApplicationBuilder app)
++        public void Configure(IApplicationBuilder app, ILoggerFactory loggerFactory)
+         {
++            loggerFactory.MinimumLevel = LogLevel.Debug;
++            loggerFactory.AddConsole(LogLevel.Debug);
+             app.Run(context =>
+             {
+                 Console.WriteLine(""{0} {1}{2}{3}"",",nit: Space between these lines.,Why is this needed?
+5243,"@@ -353,7 +353,7 @@ class ResultsProvider(object):
+     :type listeners: list[AggregatorListener]
+     """"""
+ 
+-    def __init__(self):
++    def __init__(self, translator=None):
+         super(ResultsProvider, self).__init__()
+         self.cumulative = BetterDict()
+         self.track_percentiles = []",Why aggregator should have this translator? It's Selenium specifics for now...,`translator` is not used in
+5244,"@@ -136,6 +136,13 @@ public abstract class FieldComparator<T> {
+     }
+   }
+ 
++  /**
++   * Informs the comparator that sorting is done in reverse.
++   * This is necessary only for skipping functionality.
++   */
++  public void setReverse() {
++  }
++
+ 
+   /**
+    * Base FieldComparator class for numeric types",I don't understand why this function is needed ? Can't you just pass the information when the `DocComparator` is created in the SortField ?,Why is this needed?
+5245,"@@ -11,5 +11,7 @@ class MailchimpFulfillmentJob < MailchimpJob
+ 
+   def subscribe(list_id, email)
+     client.list_subscribe(id: list_id, email_address: email, double_optin: false)
++  rescue Gibbon::MailChimpError => e
++    raise e unless MAILCHIMP_EMAIL_ERROR_CODES.include?(e.code)
+   end
+ end",This rescue is repeated exactly in `app/jobs/mailchimp_removal_job.rb`. Could we extract a method and pull it up into `MailChimpJob` for reuse?,Should this be `res
+5246,"@@ -90,6 +90,9 @@ function fetchWithTimeout(input, init) {
+                 url: xhr.responseURL,
+                 headers: xhr.responseHeaders
+             };
++            if (!options.headers) {
++                options.headers = {'content-type': xhr.getResponseHeader('content-type')};
++            }
+             const body = 'response' in xhr ? xhr.response : xhr.responseText;
+             resolve(new Response(body, options));
+         };","It's not directly related to this PR, but it would be nice to flow the original error as we're going to print that if the promise is rejected and it'll be more informative than the vague `Network request failed`. Also, I'm not a js dev, so maybe I'm wrong, but throwing a TypeError feels a bit odd.",Why do we need this
+5247,"@@ -107,8 +107,16 @@ noreturn static void exec_xwayland(struct wlr_xwayland_server *server) {
+ 		dup2(devnull, STDERR_FILENO);
+ 	}
+ 
++	const char *xwayland_path = getenv(""WLR_XWAYLAND"");
++	if (xwayland_path) {
++		wlr_log(WLR_INFO, ""Using Xwayland binary to '%s' due to WLR_XWAYLAND"",
++			xwayland_path);
++	} else {
++		xwayland_path = ""Xwayland"";
++	}
++
+ 	// This returns if and only if the call fails
+-	execvp(""Xwayland"", argv);
++	execvp(xwayland_path, argv);
+ 
+ 	wlr_log_errno(WLR_ERROR, ""failed to exec Xwayland"");
+ 	close(devnull);","Can we print a debug message when this is used? Since it's a debugging variable, I wouldn't want users to have issues because of a left-over env.",This should be `wlr
+5248,"@@ -0,0 +1,13 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. Keep in mind, some components like `forms/checkbox` will be changed to `forms-checkbox`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!design-system-react/components/pill/__examples__/base.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/icon.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/container.jsx'),
++	require('raw-loader!design-system-react/components/pill/__examples__/listbox.jsx')
++];
++
++module.exports = siteStories;","Should we have an avatar, truncate, etc examples, too?",I'm not sure if this is the best way to do this. I'm not sure what the best way would be.
+5249,"@@ -31,7 +31,6 @@ class _MissingPandasLikeIndex(object):
+ 
+     # Properties
+     nbytes = unsupported_property('nbytes')
+-    shape = unsupported_property('shape')
+ 
+     # Deprecated properties
+     strides = unsupported_property('strides', deprecated=True)",could you add this to `docs/source/reference/indexing.rst` ?,Why is this removed?
+5250,"@@ -3,10 +3,10 @@
+ #  Copyright (C) 2003 Rational Discovery LLC
+ #     All Rights Reserved
+ #
+-import sys
++
++import six
+ 
+ from rdkit.VLib.Node import VLibNode
+-from rdkit import six
+ 
+ 
+ class FilterNode(VLibNode):",Why the change from rdkit.six to six?,Why did you remove the sys import?
+5251,"@@ -78,6 +78,12 @@ def renderView(request):
+ 
+   # Now we prepare the requested data
+   if requestOptions['graphType'] == 'pie':
++    targets = [target for target in requestOptions['targets'] if target.find(':') < 0]
++    if settings.REMOTE_PREFETCH_DATA and not requestOptions.get('localOnly'):
++      log.rendering(""Prefetching remote data"")
++      pathExpressions = extractPathExpressions(targets)
++      prefetchRemoteData(STORE.remote_stores, requestContext, pathExpressions)
++
+     for target in requestOptions['targets']:
+       if target.find(':') >= 0:
+         try:","Looking good, let's just move this inside the `if` to avoid doing the extra work if we don't need it.",I'm not sure if this is the right place to put this code. I think it should be in the `pr
+5252,"@@ -1892,7 +1892,7 @@ describe('Bulk', function () {
+         expect(result).to.exist;
+ 
+         bulk.execute(err => {
+-          expect(err).to.match(/Batch cannot be re-executed/);
++          expect(err).to.match(/This batch has already been executed, create new batch to execute/);
+           done();
+         });
+       });",I think we should change this to an instanceOf check for MongoBatchReExecutionError,I think this should be `/This batch has already been executed/`
+5253,"@@ -34,7 +34,7 @@ type ProfileDecoder struct {
+ }
+ 
+ func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
+-	return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
++	return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
+ }
+ 
+ func (p *ProfileDecoder) RegisterWith(d *dispatcher.Dispatcher) {",Required by the libcalico-go changes,Why is this needed?
+5254,"@@ -1193,3 +1193,12 @@ type MutableBareRootMetadataNoImplError struct {
+ func (e MutableBareRootMetadataNoImplError) Error() string {
+ 	return ""Does not implement MutableBareRootMetadata""
+ }
++
++// blockNonExistentError is returned when a block doesn't exist.
++type blockNonExistentError struct {
++	id BlockID
++}
++
++func (e blockNonExistentError) Error() string {
++	return fmt.Sprintf(""block %s does not exist"", e.id)
++}",Explain why we don't reuse the corresponding server error locally?,I think this should be `blockNotFoundError`
+5255,"@@ -417,7 +417,7 @@ public class SolrSearchResult {
+                 .add(""is_unpublished_state"", this.isUnpublishedState())
+                 .add(""is_published"", this.isPublishedState())
+                 .add(""is_deaccesioned"", this.isDeaccessionedState())
+-                .add(""date_to_display_on_card"", this.dateToDisplayOnCard);
++                .add(""date_to_display_on_card"", DateUtil.formatDate(this.releaseOrCreateDate));
+ 
+         // Add is_deaccessioned attribute, even though MyData currently screens any deaccessioned info out
+         //","@JayanthyChengan This change is still missing (and should be last one!): change this line to call getDateToDisplayOnCard(), that way the logic is in only one place (that method).",I think this should be `this.releaseOrCreateDate`
+5256,"@@ -20,8 +20,6 @@ var (
+ 	ErrNoConnection = errors.New(""no connection exists"")
+ 	// ErrAlreadyExists error indicates that aciton applieto to manager expects no active connection (i.e. connect)
+ 	ErrAlreadyExists = errors.New(""connection already exists"")
+-	// ErrConnectionCancelled indicates that connection in progress was cancelled by request of api user
+-	ErrConnectionCancelled = errors.New(""connection was cancelled"")
+ 	// ErrOpenvpnProcessDied indicates that Connect method didn't reach ""Connected"" phase due to openvpn error
+ 	ErrOpenvpnProcessDied = errors.New(""openvpn process died"")
+ )",What was wrong with more concrete error?,why remove this error?
+5257,"@@ -14,3 +14,17 @@ function roots_get_search_form($form) {
+   return $form;
+ }
+ add_filter('get_search_form', 'roots_get_search_form');
++
++/**
++ * Add page slug to body_class() classes if it doesn't exist
++ */
++function roots_body_class($classes) {
++  // Add post/page slug
++  if (is_single() || is_page() && !is_front_page()) {
++  	if (!in_array(basename(get_permalink()), $classes)) {
++  		$classes[] = basename(get_permalink());
++  	}
++  }
++  return $classes;
++}
++add_filter('body_class', 'roots_body_class');",can you replace the tabs with 2 spaces please to match the rest of the project?,This should be `post/p
+5258,"@@ -14,6 +14,8 @@ const IntegralKind = ""integral""
+ 
+ type IntegralOpSpec struct {
+ 	Unit flux.Duration `json:""unit""`
++	TimeSrc string   `json:""timeSrc""`
++	TimeDst string   `json:""timeDst""`
+ 	execute.AggregateConfig
+ }
+ ",Why are we adding it to the integral function?,Why do we need this?
+5259,"@@ -45,11 +45,11 @@ func XfrmStateAdd(state *XfrmState) error {
+ 
+ 	msg := &nl.XfrmUsersaInfo{}
+ 	msg.Family = uint16(nl.GetIPFamily(state.Dst))
+-	msg.Id.Daddr.FromIP(state.Dst)
++	msg.ID.Daddr.FromIP(state.Dst)
+ 	msg.Saddr.FromIP(state.Src)
+-	msg.Id.Proto = uint8(state.Proto)
++	msg.ID.Proto = uint8(state.Proto)
+ 	msg.Mode = uint8(state.Mode)
+-	msg.Id.Spi = nl.Swap32(uint32(state.Spi))
++	msg.ID.Spi = nl.Swap32(uint32(state.Spi))
+ 	msg.Reqid = uint32(state.Reqid)
+ 	msg.ReplayWindow = uint8(state.ReplayWindow)
+ 	msg.Lft.SoftByteLimit = nl.XFRM_INF",Same for this file,`msg.Id.Daddr` -> `msg
+5260,"@@ -234,15 +234,14 @@ namespace NLog.Internal.FileAppenders
+                 appender.Flush();
+             }
+         }
+-        
++
+         /// <summary>
+         /// Gets the file info for a particular appender.
+         /// </summary>
+         /// <param name=""fileName"">The file name associated with a particular appender.</param>
+-        /// <param name=""lastWriteTime"">The last file write time. The value must be of UTC kind.</param>
+-        /// <param name=""fileLength"">Length of the file.</param>
++        /// <param name=""fileCharacteristics"">The file characteristics, if the file information was retrieved successfully.</param>
+         /// <returns><see langword=""true""/> when the operation succeeded; <see langword=""false""/> otherwise.</returns>
+-        public bool GetFileInfo(string fileName, out DateTime lastWriteTime, out long fileLength)
++        public bool GetFileCharacteristics(string fileName, out FileCharacteristics fileCharacteristics)
+         {
+             foreach (BaseFileAppender appender in appenders)
+             {",Looks good! But why it's still a out parameter? We can refactor the whole tree because it's internal?,Why did you remove the lastWriteTime parameter?
+5261,"@@ -825,6 +825,11 @@ void roots_seat_set_focus(struct roots_seat *seat, struct roots_view *view) {
+ 	view_activate(view, true);
+ 	seat->has_focus = true;
+ 
++	// We want to unconditionally send keyboard input to the view we are
++	// focusing here, so cancel any existing grabs.
++	struct wlr_seat_keyboard_grab *curr_grab = seat->seat->keyboard_state.grab;
++	curr_grab->interface->cancel(curr_grab);
++
+ 	struct wlr_keyboard *keyboard = wlr_seat_get_keyboard(seat->seat);
+ 	if (keyboard != NULL) {
+ 		wlr_seat_keyboard_notify_enter(seat->seat, view->wlr_surface,",probably better to use `wlr_seat_keyboard_end_grab()`.,I don't think this is the right place to cancel
+5262,"@@ -142,6 +142,9 @@ public class TransactionPool implements BlockAddedObserver {
+ 
+   public ValidationResult<TransactionInvalidReason> addLocalTransaction(
+       final Transaction transaction) {
++    if (transaction.getChainId().isEmpty() && !configuration.isUnprotectedTransactionsAllowed()) {
++      return ValidationResult.invalid(TransactionInvalidReason.UNPROTECTED_TRANSACTION);
++    }
+     if (!configuration.getTxFeeCap().isZero()
+         && minTransactionGasPrice(transaction).compareTo(configuration.getTxFeeCap()) > 0) {
+       return ValidationResult.invalid(TransactionInvalidReason.TX_FEECAP_EXCEEDED);",Such a large test impact for such a little 3 line change ;),Why do we need this check?
+5263,"@@ -51,9 +51,9 @@ class Payment extends AbstractTranslatableEntity implements OrderableEntityInter
+     protected $vat;
+ 
+     /**
+-     * @var Collection
++     * @var \Shopsys\FrameworkBundle\Model\Transport\Transport[]|Collection
+      *
+-     * @ORM\ManyToMany(targetEntity=""Shopsys\FrameworkBundle\Model\Transport\Transport"")
++     * @ORM\ManyToMany(targetEntity=""Shopsys\FrameworkBundle\Model\Transport\Transport"", inversedBy=""payments"", cascade={""persist""})
+      * @ORM\JoinTable(name=""payments_transports"")
+      */
+     protected $transports;","Is the `cascade` necessary? It should work also without the casdade, because Payments are always already persisted when use cases with them. If it doesn't work, please tell me the reason. It is as same in Transport.",This should be reverted.
+5264,"@@ -0,0 +1,11 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Psalm\Issue;
++
++final class NonInvariantPropertyType extends CodeIssue
++{
++    public const ERROR_LEVEL = -1;
++    public const SHORTCODE = 235159;
++}",This is not very short. I'm not sure sure if there's a system for assigning shortcodes to issues.,Why not use `CodeIssue::ERROR_LEVEL`?
+5265,"@@ -20,6 +20,9 @@ const (
+ 	// the default configuration provided to ingress-annotation should be
+ 	// created.
+ 	tlsACMEAnnotation = ""kubernetes.io/tls-acme""
++	// editInPlaceAnnotation is used to toggle the use of ingressClass instead
++	// of ingress on the created Certificate resource
++	editInPlaceAnnotation = ""certmanager.k8s.io/edit-in-place""
+ 	// issuerNameAnnotation can be used to override the issuer specified on the
+ 	// created Certificate resource.
+ 	issuerNameAnnotation = ""certmanager.k8s.io/issuer""","We should probably prefix this with `acme-http01` to bring it in-line with other annotations, e.g. `certmanager.k8s.io/acme-http01-edit-in-place`. It's quite wordy, but it *is* more specific (and I'd hope more obvious to the user what it is for?)",I don't think this is needed.
+5266,"@@ -665,7 +665,7 @@ public class JobTypeManager {
+   /**
+    +   * Get the keystore load props
+    +   */
+-  public Props getCommonPluginLoadProps() {
++  public Props    getCommonPluginLoadProps() {
+     return this.cachedCommonPluginLoadProps;
+   }
+ ",No need to add this file change for this PR. Please remove it.,nit: remove extra space
+5267,"@@ -8,6 +8,7 @@ import net.sourceforge.pmd.lang.java.ast.ASTImportDeclaration;
+ import net.sourceforge.pmd.lang.java.rule.AbstractJavaRule;
+ 
+ public class DontImportJavaLangRule extends AbstractJavaRule {
++    private static final String IMPORT_JAVA_LANG = ""java.lang."";
+ 
+     @Override
+     public Object visit(ASTImportDeclaration node, Object data) {",this extra dot at the end is causing a couple tests to fail on Travis,Why do we need this constant?
+5268,"@@ -853,7 +853,11 @@ Arguments:
+ 
+ @conf.commands.register
+ def tshark(*args,**kargs):
+-    """"""Sniff packets and print them calling pkt.show(), a bit like text wireshark""""""
+-    sniff(prn=lambda x: x.display(),*args,**kargs)
+-
+-
++    """"""Sniff packets and print them calling pkt.summary(), a bit like text wireshark""""""
++    print(""Capturing on '"" + str(kargs.get('iface') if 'iface' in kargs else conf.iface) + ""'"")
++    i = [0]  # This should be a nonlocal variable, using a mutable object for Python 2 compatibility
++    def _cb(pkt):
++        print(""%5d\t%s"" % (i[0], pkt.summary()))
++        i[0] += 1
++    sniff(prn=_cb, store=False, *args, **kargs)
++    print(""\n%d packet%s captured"" % (i[0], 's' if i[0] > 1 else ''))",Did you try using `global` with a regular integer ?,This should be `i[0] += 1`
+5269,"@@ -76,7 +76,7 @@ int Contractor::Run()
+ #ifdef WIN32
+ #pragma message(""Memory consumption on Windows can be higher due to different bit packing"")
+ #else
+-    static_assert(sizeof(extractor::NodeBasedEdge) == 20,
++    static_assert(sizeof(extractor::NodeBasedEdge) == 24,
+                   ""changing extractor::NodeBasedEdge type has influence on memory consumption!"");
+     static_assert(sizeof(extractor::EdgeBasedEdge) == 16,
+                   ""changing EdgeBasedEdge type has influence on memory consumption!"");",windows size might be off,Why did you change this?
+5270,"@@ -25,10 +25,8 @@
+ #include ""engine/bp/BPFileReader.h""
+ #include ""engine/bp/BPFileWriter.h""
+ 
+-#ifdef ADIOS_HAVE_DATAMAN // external dependencies
+ #include ""engine/dataman/DataManReader.h""
+ #include ""engine/dataman/DataManWriter.h""
+-#endif
+ 
+ #ifdef ADIOS_HAVE_ADIOS1 // external dependencies
+ #include ""engine/adios1/ADIOS1Reader.h""",This should still be guarded with an `#ifdef` since the DataMan code will only be supported for shared lib builds.,Why is this being removed?
+5271,"@@ -1,7 +1,7 @@
+ <%= ""#{@plan.title}"" %>
+ <%= ""----------------------------------------------------------\n"" %>
+ <% if @show_coversheet %>
+-<%= @hash[:attribution].length > 1 ? _(""Creators: "") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
++<%= @hash[:attribution].many? ? _(""Creators: "") : _('Creator:') %> <%= @hash[:attribution].join(', ') %>
+ <%= _(""Affiliation: "") + @hash[:affiliation] %>
+   <% if @hash[:funder].present? %>
+ <%= _(""Template: "") + @hash[:funder] %>",thanks for cleaning up these old length checks  ,I think this should be `@h
+5272,"@@ -189,7 +189,7 @@ func (e *Executor) addBuiltinAnnontations(manifests []provider.Manifest, variant
+ }
+ 
+ func (e *Executor) applyManifests(ctx context.Context, manifests []provider.Manifest) error {
+-	e.LogPersister.Infof(""Start applying %d manifests"", len(manifests))
++	e.LogPersister.Infof(""Start applying %d manifests to %q namespace"", len(manifests), e.config.Input.Namespace)
+ 	for _, m := range manifests {
+ 		if err := e.provider.ApplyManifest(ctx, m); err != nil {
+ 			e.LogPersister.Errorf(""Failed to apply manifest: %s (%v)"", m.Key.ReadableString(), err)",What will be logged when the `Input.Namespace` was not specified?,Should this be `e.config.Output.Namespace`?
+5273,"@@ -102,6 +102,9 @@ public class PMDParameters {
+     @Parameter(names = ""-cache"", description = ""Specify the location of the cache file for incremental analysis."")
+     private String cacheLocation = null;
+ 
++    @Parameter(names = ""-fix"", description = ""Attempt to automatically fix rule violations found on source files."")
++    private boolean autoFixes = false;
++
+     // this has to be a public static class, so that JCommander can use it!
+     public static class PropertyConverter implements IStringConverter<Properties> {
+ ",I wouldn't expose this until the feature is ready. We are most likely to cut releases while still in development,I think this should be `true` by default.
+5274,"@@ -47,5 +47,6 @@ axe.imports = {
+ 	CssSelectorParser: require('css-selector-parser').CssSelectorParser,
+ 	doT: require('@deque/dot'),
+ 	emojiRegexText: require('emoji-regex'),
+-	memoize: require('memoizee')
++	memoize: require('memoizee'),
++	ariaQuery: require('aria-query')
+ };",I don't think we should pull aria-query into axe-core at this point. There's a much simpler fix for this. Please don't overthink it.,Why is this needed?
+5275,"@@ -86,18 +86,8 @@ namespace OpenTelemetry
+             return value;
+         }
+ 
+-        /// <inheritdoc/>
+-        public void Dispose()
+-        {
+-            if (!this.disposed)
+-            {
+-                Slot.Set(this.previousValue);
+-                this.disposed = true;
+-            }
+-        }
+-
+         [MethodImpl(MethodImplOptions.AggressiveInlining)]
+-        internal static int IncrementIfTriggered()
++        public static int IncrementIfTriggered()
+         {
+             var value = Slot.Get();
+ ",@ejsmith What if instead of making these two methods public we made it a partial class and moved them to a separate file so that file could be part of the include list? I bring it up just because I don't think it is a very nice API that was ever intended to be public? I think they are only called by a couple of other very internal-y spots. /cc @reyang,Why was this removed?
+5276,"@@ -283,9 +283,12 @@ public class ExecuteFlowAction implements TriggerAction {
+             actions.add(killAct);
+           }
+         }
+-        Trigger slaTrigger =
+-            new Trigger(""azkaban_sla"", ""azkaban"", triggerCond, expireCond,
+-                actions);
++        Trigger slaTrigger = new Trigger.TriggerBuilder(""azkaban_sla"",
++                                                        ""azkaban"",
++                                                        triggerCond,
++                                                        expireCond,
++                                                        actions).build();
++
+         slaTrigger.getInfo().put(""monitored.finished.execution"",
+             String.valueOf(execId));
+         slaTrigger.setResetOnTrigger(false);",would be good to turn these into constants.,Why is this change needed?
+5277,"@@ -158,8 +158,8 @@ func (g *gen) frame() []byte {
+ 		return nil
+ 	}
+ 	var buf bytes.Buffer
+-	buf.WriteString(""// Code generated by gowire. DO NOT EDIT.\n\n"")
+-	buf.WriteString(""//go:generate gowire\n"")
++	buf.WriteString(""// Code generated by wire. DO NOT EDIT.\n\n"")
++	buf.WriteString(""//go:generate wire\n"")
+ 	buf.WriteString(""//+build !wireinject\n\n"")
+ 	buf.WriteString(""package "")
+ 	buf.WriteString(g.prog.Package(g.currPackage).Pkg.Name())",Seems like it should be `generated by Wire` here and in the SUT?,Why did you change this?
+5278,"@@ -173,7 +173,7 @@ func TestStorageProtocolBasic(t *testing.T) {
+ 		}
+ 	}
+ 
+-	ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150)
++	ref, err := c.ProposeDeal(ctx, mineraddr, protonode.Cid(), 1, 150, false)
+ 	assert.NoError(err)
+ 	requireQueryDeal := func() (DealState, string) {
+ 		resp, err := c.QueryDeal(ctx, ref.ProposalCid)","I know the main cases show up in the daemon test already but a little bit more unit test coverage would be nice and probably not too annoying to set up. Ideas: 1. Verify that the string ""no duplicates"" is in the LastDuplicate field when we propose a new deal. 2. Verify that proposing a duplicate deal fails when the duplicates boolean is set false. 3. Start out in a state with more than 1 duplicates. Verify that the LastDuplicate field is set to the last duplicate when we propose with a true duplicates bool.",Why is this `false`?
+5279,"@@ -74,7 +74,7 @@ namespace OpenTelemetry
+         {
+             if (timeoutMilliseconds < 0 && timeoutMilliseconds != Timeout.Infinite)
+             {
+-                throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds));
++                throw new ArgumentOutOfRangeException(nameof(timeoutMilliseconds), timeoutMilliseconds, $""timeout milliseconds should not be below 0 or infinite, but was: {timeoutMilliseconds}"");
+             }
+ 
+             if (Interlocked.Increment(ref this.shutdownCount) > 1)",`Timeout.Infinite` is actually `-1`. Here the correct message can be taken from Line:67.,nit: `timeout milliseconds
+5280,"@@ -38,6 +38,7 @@ using System.Linq;
+ using Xunit;
+ using NLog.Common;
+ using System.Text;
++using Xunit.Extensions;
+ 
+ namespace NLog.UnitTests.Common
+ {",I think we need `#if !SILVERLIGHT` here and at the test.,Why is this needed?
+5281,"@@ -26,6 +26,7 @@ import javafx.collections.transformation.SortedList;
+ import javafx.event.EventHandler;
+ import javafx.scene.input.MouseEvent;
+ import me.xdrop.fuzzywuzzy.FuzzySearch;
++import org.eclipse.jgit.util.StringUtils;
+ import org.phoenicis.javafx.settings.JavaFxSettingsManager;
+ import org.phoenicis.javafx.views.common.ExpandedList;
+ import org.phoenicis.javafx.views.common.ThemeManager;",Can you change this import to the apache dependency? I didn't even know that jgit contains such a method...,This import is not 
+5282,"@@ -34,11 +34,11 @@ func GenerateServiceAccountName(gServiceAccount, clusterName string) string {
+ }
+ 
+ // MakeServiceAccount creates a K8s ServiceAccount object for the Namespace.
+-func MakeServiceAccount(namespace string, gServiceAccount, clusterName string) *corev1.ServiceAccount {
++func MakeServiceAccount(namespace string, kServiceAccount, gServiceAccount, clusterName string) *corev1.ServiceAccount {
+ 	return &corev1.ServiceAccount{
+ 		ObjectMeta: metav1.ObjectMeta{
+ 			Namespace: namespace,
+-			Name:      GenerateServiceAccountName(gServiceAccount, clusterName),
++			Name:      kServiceAccount,
+ 			Annotations: map[string]string{
+ 				WorkloadIdentityKey: gServiceAccount,
+ 			},","Four strings in a row makes me nervous, can we use an arguments struct instead? Or reuse the struct I recommend in the reconciler.",Why do we need this
+5283,"@@ -50,13 +50,15 @@ interpreted as encoded JSON and formatted accordingly.  If '-r', value
+ is displayed without a newline.  If '-t', the RFC 11 object is displayed.
+ '-a treeobj' causes the lookup to be relative to an RFC 11 snapshot reference.
+ 
+-*put* [-j|-r|-t] [-n] 'key=value' ['key=value...']::
++*put* [-j|-r|-t] [-n] [-A] 'key=value' ['key=value...']::
+ Store 'value' under 'key' and commit it.  If it already has a value,
+ overwrite it.  If no options, value is stored directly.  If '-j', it is
+ first encoded as JSON, then stored.  If '-r', the value may be read from
+ standard input if specified as ""-"", and may include embedded NULL bytes.
+ If '-t', value is stored as a RFC 11 object.  '-n' prevents the commit
+-from being merged with with other contemporaneous commits.
++from being merged with with other contemporaneous commits.  '-A' appends the
++value to a key instead of overwriting the value.  Append is incompatible with
++the -j option.
+ 
+ *ls* [-R] [-d] [-F] [-w COLS] [-1] ['key' ...]::
+ Display directory referred to by _key_, or ""."" (root) if unspecified.","should work with no options, if my suggestion is accepted. JSON is the one that gets weird since a JSON object appended to a JSON object isn't valid JSON.",I don't think this 
+5284,"@@ -49,7 +49,7 @@ func init() {
+ 	flags.BoolVarP(cmdFlags, &checkControl, ""check-control"", """", true, ""Check control characters."")
+ 	flags.DurationVarP(cmdFlags, &uploadWait, ""upload-wait"", """", 0, ""Wait after writing a file."")
+ 	flags.BoolVarP(cmdFlags, &checkLength, ""check-length"", """", true, ""Check max filename length."")
+-	flags.BoolVarP(cmdFlags, &checkStreaming, ""check-streaming"", """", true, ""Check uploadxs with indeterminate file size."")
++	flags.BoolVarP(cmdFlags, &checkStreaming, ""check-streaming"", """", true, ""Check uploads with indeterminate file size."")
+ }
+ 
+ var commandDefinition = &cobra.Command{",I presume this isn't some special term...,`Check uploads with indeterminate file size.`
+5285,"@@ -79,6 +79,18 @@ function pAsHeadingEvaluate(node, options, virtualNode) {
+   const nextStyle = nextSibling ? getStyleValues(nextSibling) : null;
+   const prevStyle = prevSibling ? getStyleValues(prevSibling) : null;
+ 
++  if (node && nextSibling) {
++    const headingLength = node.textContent.trim().length;
++    const paragraphLength = nextSibling.textContent.trim().length;
++    if (headingLength > paragraphLength) {
++      return true;
++    } else if (headingLength < paragraphLength / 2) {
++      return false;
++    } else {
++      undefined;
++    }
++  }
++
+   if (!nextStyle || !isHeaderStyle(currStyle, nextStyle, margins)) {
+     return true;
+   }",Did you mean to return here? ;) You'll also need to add an `incomplete` message to the rule metadata.,Why do we need this?
+5286,"@@ -540,6 +540,14 @@ const (
+ 	//    This is replaced at runtime
+ 	JivaClusterIPHolder JivaAnnotations = ""__CLUSTER_IP__""
+ 
++	// JivaCloneIPHolder is used as a placeholder for sync controller IP address
++	// which will be used as cloneIP
++	//
++	// NOTE:
++	//    This is replaced at runtime
++	JivaCloneIPHolder JivaAnnotations = ""__CLONE_IP__""
++
++	JivaReplicaTypeHolder JivaAnnotations = ""clone""
+ 	// JivaStorageSizeHolder is used as a placeholder for persistent volume's
+ 	// storage capacity
+ 	//",Why are we calling these as annotations? I guess this is an old type that we are re-using. But lets make it a point to avoid once we feel that this design/code is not good.,Why do we need this annotation?
+5287,"@@ -38,6 +38,8 @@ public class RestClientSenderFilter implements ConsumerFilter {
+ 
+   @Override
+   public CompletableFuture<Response> onFilter(Invocation invocation, FilterNode nextNode) {
++    invocation.onStartSendRequest();
++
+     CompletableFuture<Response> future = new RestClientSender(invocation)
+         .send();
+ ",`invocation.getInvocationStageTrace().startSend()` is inside `RestClientSender.send`,Why do we need this?
+5288,"@@ -218,8 +218,8 @@ func (ap *actPool) Add(ctx context.Context, act action.SealedEnvelope) error {
+ 	if act.GasPrice().Cmp(ap.cfg.MinGasPrice()) < 0 {
+ 		actpoolMtc.WithLabelValues(""gasPriceLower"").Inc()
+ 		log.L().Info(""action rejected due to low gas price"",
+-			zap.String(""act hash"", hex.EncodeToString(hash[:])),
+-			zap.String(""gas price"", act.GasPrice().String()))
++			zap.String(""actionHash"", hex.EncodeToString(hash[:])),
++			zap.String(""gasPrice"", act.GasPrice().String()))
+ 		return action.ErrUnderpriced
+ 	}
+ 	if err := ap.validate(ctx, act); err != nil {","use ""actionHash"" to be consistent with other places",Why did you change this?
+5289,"@@ -4,11 +4,14 @@
+ 
+ package net.sourceforge.pmd.lang.rule.properties;
+ 
++import java.util.Collections;
+ import java.util.Enumeration;
+ import java.util.Map;
+ 
++import net.sourceforge.pmd.EnumeratedPropertyDescriptor;
+ import net.sourceforge.pmd.PropertyDescriptorFactory;
+-import net.sourceforge.pmd.lang.rule.properties.factories.BasicPropertyDescriptorFactory;
++import net.sourceforge.pmd.PropertyDescriptorField;
++import net.sourceforge.pmd.util.CollectionUtil;
+ 
+ /**
+  * Defines a datatype with a set of preset values of any type as held within a","Can we derive `Class<E>` by looking at one of the label choices, if at least one is always provided? Given these are immutable, a real-world case for an empty enumerations eludes me.",Why is this change neede
+5290,"@@ -5364,6 +5364,17 @@ TEST_F(VkLayerTest, AndroidHardwareBufferCreateYCbCrSampler) {
+     m_errorMonitor->SetUnexpectedError(""VUID-VkSamplerYcbcrConversionCreateInfo-xChromaOffset-01651"");
+     vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
+     m_errorMonitor->VerifyFound();
++
++    m_errorMonitor->ExpectSuccess();
++    efa.externalFormat = AHARDWAREBUFFER_FORMAT_Y8Cb8Cr8_420;
++    sycci.format = VK_FORMAT_UNDEFINED;
++    sycci.ycbcrModel = VK_SAMPLER_YCBCR_MODEL_CONVERSION_YCBCR_709;
++    sycci.ycbcrRange = VK_SAMPLER_YCBCR_RANGE_ITU_NARROW;
++    // Spec says if we use VkExternalFormatANDROID value of components is ignored.
++    sycci.components = {VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO, VK_COMPONENT_SWIZZLE_ZERO};
++    vk::CreateSamplerYcbcrConversion(dev, &sycci, NULL, &ycbcr_conv);
++    m_errorMonitor->VerifyNotFound();
++    vk::DestroySamplerYcbcrConversion(dev, ycbcr_conv, nullptr);
+ }
+ 
+ TEST_F(VkLayerTest, AndroidHardwareBufferPhysDevImageFormatProp2) {","I am now confused here, the spec says > If format is VK_FORMAT_UNDEFINED, all members of samplerYcbcrConversionComponents must be the identity swizzle. The spec also says > samplerYcbcrConversionComponents is the component swizzle that **should** be used in VkSamplerYcbcrConversionCreateInfo. so you are allowed to set the swizzle to anything I want, so I guess this is valid usage here... but now I am more curious if I have an external format does it not have to follow any component swizzle rules and can be anything regardless of the `ycbcrModel`? (I guess really a question for @critsec and is not a blocking concern for the scope of this PR)",Shouldn't this be `VK_SA
+5291,"@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
+ 		return """", err
+ 	}
+ 
+-	if app.SiteStatus() != ""running"" {
+-		return """", errors.New(""app not running locally. Try `ddev start`"")
++	if app.SiteStatus() != platform.SiteRunning {
++		return """", errors.New(""App not running locally. Try `ddev start`"")
+ 	}
+ 
+ 	db, err := app.FindContainerByType(""db"")","I'd say the error should be an error, not instructions to the user. So error would be something like ""site should be running and is not""",I think this should be `
+5292,"@@ -894,8 +894,11 @@ class SNSTest(unittest.TestCase):
+         return queue_name, queue_arn, queue_url
+ 
+     def test_publish_sms_endpoint(self):
++        # Clean posible previous sms messages
++        sns_backend = SNSBackend.get()
++        sns_backend.sms_messages = []
++
+         def check_messages():
+-            sns_backend = SNSBackend.get()
+             self.assertEqual(len(list_of_contacts), len(sns_backend.sms_messages))
+ 
+         list_of_contacts = [""+10123456789"", ""+10000000000"", ""+19876543210""]","Thanks for this PR @pinzon !   Rather than resetting the `sms_messages` list, can we fix the assertion in line 902 - rather than asserting `len` equality, we should assert that all expected messages are contained in the list. (In this case the phone numbers should be reasonably random, and ideally we should not have duplicates across different tests). We're planning to introduce test parallelization in the near future, and this will help us avoiding undesired side-effects.   Thanks",Why do we need this?
+5293,"@@ -21,10 +21,12 @@ import (
+ 	""context""
+ 	""errors""
+ 	""sync""
+-	""time""
++
++	""github.com/asaskevich/EventBus""
+ 
+ 	log ""github.com/cihub/seelog""
+-	""github.com/mysteriumnetwork/node/client/stats""
++	stats_dto ""github.com/mysteriumnetwork/node/client/stats/dto""
++
+ 	""github.com/mysteriumnetwork/node/communication""
+ 	""github.com/mysteriumnetwork/node/firewall""
+ 	""github.com/mysteriumnetwork/node/identity""",Some weird blocks formation again.,Why do we need to ex
+5294,"@@ -39,7 +39,7 @@ func TestOvirtActuator(t *testing.T) {
+ 			clusterDeployment: testOvirtClusterDeployment(),
+ 			pool:              testOvirtPool(),
+ 			expectedMachineSetReplicas: map[string]int64{
+-				fmt.Sprintf(""%s-worker-0"", testInfraID): 3,
++				fmt.Sprintf(""%s-worker"", testInfraID): 3,
+ 			},
+ 		},
+ 	}",This is worrisome.,why this change?
+5295,"@@ -219,6 +219,9 @@ type FilesystemTrimDriver interface {
+ 	// AutoFilesystemTrimStatus returns the status of auto fs trim
+ 	// operations on volumes
+ 	AutoFilesystemTrimStatus(request *api.SdkAutoFSTrimStatusRequest) (*api.SdkAutoFSTrimStatusResponse, error)
++	// AutoFilesystemTrimUsage returns the usage of auto fs trim
++	// operations on locally mounted volumes
++	AutoFilesystemTrimUsage(request *api.SdkAutoFSTrimUsageRequest) (*api.SdkAutoFSTrimUsageResponse, error)
+ 	// FilesystemTrimStop stops a filesystem trim background operation on
+ 	// a specified volume, if any
+ 	FilesystemTrimStop(request *api.SdkFilesystemTrimStopRequest) (*api.SdkFilesystemTrimStopResponse, error)","nit try rephrasing to something like "" AutoFilesystemTrimUsage returns the volume usage and trimmable space of locally mounted pxd volumes""",I don't think we nee
+5296,"@@ -64,7 +64,7 @@ module Unix
+       h = self.foss_defaults
+       h['puppetserver-confdir'] = '/etc/puppetlabs/puppetserver/conf.d'
+       h['puppetservice']  = 'puppetserver'
+-      h['puppetbindir']   = '/opt/puppetlabs/agent/bin'
++      h['puppetbindir']   = '/opt/puppetlabs/agent/bin:/opt/puppetlabs/bin'
+       h['puppetbin']      = ""#{h['puppetbindir']}/puppet""
+       h['puppetpath']     = '/etc/puppetlabs/agent'
+       h['puppetconfdir']  = ""#{h['puppetpath']}/config""","currently the puppet-agent package doesn't symlink files into /opt/puppetlabs/bin. Also many puppet acceptance tests that execute on Unix assume puppetbindir is a single directory (windows doesn't have this issue). So I think if we want to unblock testing, this should just be changed to `h['puppetbindir'] = '/opt/puppetlabs/puppet/bin`",Why is this change needed?
+5297,"@@ -4,10 +4,10 @@ import Ember from 'ember';
+ import PouchAdapterUtils from 'hospitalrun/mixins/pouch-adapter-utils';
+ 
+ export default Adapter.extend(PouchAdapterUtils, {
+-    databaseName: 'config',    
+-    db:  Ember.computed.alias('pouchDBService.configDB'),
+-    pouchDBService: Ember.inject.service('pouchdb'),
+-    
++    databaseName: 'config',
++    database: Ember.inject.service(),
++    db:  Ember.computed.alias('database.configDB'),
++
+     _mapQuery: function(doc, emit) {
+         if (doc._id) {
+             emit(doc._id, null);",any point in keeping this here ?,This should be `database.c
+5298,"@@ -233,8 +233,8 @@ type GossipData struct {
+ }
+ 
+ func (g *GossipData) Merge(o router.GossipData) {
+-	checkAndPanic(CaseSensitive(g.Entries))
+-	defer func() { checkAndPanic(CaseSensitive(g.Entries)) }()
++	checkAndPanic(CaseInsensitive(g.Entries))
++	defer func() { checkAndPanic(CaseInsensitive(g.Entries)) }()
+ 	other := o.(*GossipData)
+ 	g.Entries.merge(other.Entries)
+ 	if g.Timestamp < other.Timestamp {",I don't think we need this check. Instead `Entries.merge` should check that its argument is correctly sorted (in addition to the existing pre/post check on the method receiver).,Why is this case insensiti
+5299,"@@ -1,6 +1,11 @@
+ #include ""engine/routing_algorithms/shortest_path.hpp""
++
++#ifdef OSRM_EXTERNAL_MEMORY
++#include ""routing/routing_base_offline.hpp""
++#else
+ #include ""engine/routing_algorithms/routing_base_ch.hpp""
+ #include ""engine/routing_algorithms/routing_base_mld.hpp""
++#endif
+ 
+ #include <boost/assert.hpp>
+ #include <boost/optional.hpp>","This is not really good to mix different code bases. @TheMarex I understand the point about placing code into cpp file, but we still need to move templated version into an impl header, remove references to offline code here and keep template instantiations in a cpp file to avoid rebuild. So offline code could instantiate own implementations using private impl headers. Otherwise we again make wrong dependencies into OSRM code and block changes in separate projects.",Why is this needed?
+5300,"@@ -149,6 +149,8 @@ void PDPSimpleListener::onNewCacheChangeAdded(RTPSReader* reader, const CacheCha
+             {
+                 listener->onParticipantDiscovery(this->mp_SPDP->getRTPSParticipant()->getUserRTPSParticipant(), std::move(info));
+             }
++
++            return; // change already removed from history
+         }
+     }
+ ","Then, where is it removed?",if (auto listener = this->getListener())
+5301,"@@ -16,6 +16,7 @@ func TestVHostTrie(t *testing.T) {
+ 		""example.com/foo/bar"",
+ 		""*.example.com/test"",
+ 	})
++	CaseSensitivePath = true
+ 	assertTestTrie(t, trie, []vhostTrieTest{
+ 		{""not-in-trie.com"", false, """", ""/""},
+ 		{""example"", true, ""example"", ""/""},",The tests are not run concurrently? (I don't know. Better check.),Why is this needed?
+5302,"@@ -131,7 +131,7 @@ Blockly.FieldTextInput.prototype.showEditor_ = function(opt_quietInput) {
+   var htmlInput = goog.dom.createDom('input', 'blocklyHtmlInput');
+   htmlInput.setAttribute('spellcheck', this.spellcheck_);
+   var fontSize =
+-      (Blockly.FieldTextInput.FONTSIZE * this.workspace_.scale) + 'pt';
++      (Blockly.FieldTextInput.FONTSIZE) + 'pt';
+   div.style.fontSize = fontSize;
+   htmlInput.style.fontSize = fontSize;
+   /** @type {!HTMLInputElement} */",Regardless of scale?,Why was this changed?
+5303,"@@ -44,6 +44,14 @@ var dataDirectory = flag.String(""d"", """", ""Root Algorand daemon data path"")
+ var versionCheck = flag.Bool(""v"", false, ""Display and write current build version and exit"")
+ var telemetryOverride = flag.String(""t"", """", `Override telemetry setting if supported (Use ""true"", ""false"", ""0"" or ""1"")`)
+ 
++// the following flags aren't being used by the algoh, but are needed so that the flag package won't complain that
++// these flags were provided but were not defined. We grab all the input flags and pass these downstream to the algod executable
++// as an input arguments.
++var peerOverride = flag.String(""p"", """", ""Override phonebook with peer ip:port (or semicolon separated list: ip:port;ip:port;ip:port...)"")
++var listenIP = flag.String(""l"", """", ""Override config.EndpointAddress (REST listening address) with ip:port"")
++var seed = flag.String(""seed"", """", ""input to math/rand.Seed()"")
++var genesisFile = flag.String(""g"", """", ""Genesis configuration file"")
++
+ const algodFileName = ""algod""
+ const goalFileName = ""goal""
+ ",Nit: should not we hide them from printing out?,I'm not sure if this is the right way to
+5304,"@@ -196,7 +196,7 @@ test_pipeline = [
+             dict(type='RandomFlip'),
+             dict(type='Normalize', **img_norm_cfg),
+             dict(type='Pad', size_divisor=32),
+-            dict(type='ImageToTensor', keys=['img']),
++            dict(type='DefaultFormatBundle'),
+             dict(type='Collect', keys=['img']),
+         ])
+ ]",What is the reason to modify those things? I noticed it breaks the examples using `asyncio`,Why did you remove the `ImageToTensor`?
+5305,"@@ -33,7 +33,7 @@ import (
+ 
+ const (
+ 	// Encoding is the name of this encoding.
+-	Encoding transport.Encoding = ""protobuf""
++	Encoding transport.Encoding = ""proto""
+ 
+ 	rawResponseHeaderKey = ""rpc-protobuf-raw-response""
+ )",WHOOOOOOOPS! so this is a wire protocol breaking change. I deployed a dev version of yarpc 1.9 to demo-yarpc-go and it caused bad request errors because it couldn't determine the procedure anymore. (in coordination with yarpc-prober),Why is this change needed?
+5306,"@@ -1,5 +1,9 @@
+ 'use strict';
+ 
++const parseConnectionString = require('./core/uri_parser');
++
++const writeConcernKeys = new Set(['w', 'wtimeout', 'j', 'fsync', 'wtimeoutMS', 'journal']);
++
+ /**
+  * The **WriteConcern** class is a class that represents a MongoDB WriteConcern.
+  * @class","if we keep this, can we stick to our convention of using UPPER_CASE for constants? Otherwise this looks like a floating variable to me.",Why do we need this?
+5307,"@@ -341,7 +341,7 @@ class GTPPDUSessionContainer(Packet):
+         return p
+ 
+     def hashret(self):
+-        return struct.pack(""H"", self.seq)
++        return struct.pack(""H"", getattr(self.underlayer, ""seq""))
+ 
+ 
+ class GTPEchoRequest(Packet):",You probably don't want to assume that `self.underlayer` has a `seq` attribute.,"`getattr(self.underlayer, ""seq"", 0)`"
+5308,"@@ -65,10 +65,6 @@ class DisplayLanguageOptionFactory implements FactoryInterface
+         if (!empty($options)) {
+             throw new \Exception('Unexpected options sent to factory.');
+         }
+-        // We want to construct a separate translator instance for this helper,
+-        // since it configures different language/locale than the core shared
+-        // instance!
+-        $factory = new \VuFind\I18n\Translator\TranslatorFactory();
+-        return new $requestedName($factory($container, Translator::class));
++        return new $requestedName($container->get(Translator::class));
+     }
+ }",This apparently breaks the language selection.,`$container->get(Translator::class)` can be replaced with `$container->get(Translator::class)`
+5309,"@@ -0,0 +1,10 @@
++# This migration comes from acts_as_taggable_on_engine (originally 5)
++# This migration is added to circumvent issue #623 and have special characters
++# work properly
++class ChangeCollationForTagNames < ActiveRecord::Migration
++  def up
++    if ActsAsTaggableOn::Utils.using_mysql?
++      execute(""ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;"")
++    end
++  end
++end","since we're not using mysql, do we need this migration?",Line is too long. [83/80]
+5310,"@@ -453,6 +453,9 @@ OUTBOUND_HTTP_PROXY = os.environ.get(""OUTBOUND_HTTP_PROXY"", """")
+ # Equivalent to HTTPS_PROXY, but only applicable for external connections
+ OUTBOUND_HTTPS_PROXY = os.environ.get(""OUTBOUND_HTTPS_PROXY"", """")
+ 
++# Whether to enable the partition adjustment listener (in order to support other partitions that the default)
++PARTITION_ADJUSTMENT = is_env_true(""PARTITION_ADJUSTMENT"")
++
+ # list of environment variable names used for configuration.
+ # Make sure to keep this in sync with the above!
+ # Note: do *not* include DATA_DIR in this list, as it is treated separately",i'm not sure about htis naming here. both the word partition and adjustment are very ambiguous and it's not clear what it does. i would maybe go for something less generic and more concrete like `GOV_CLOUD_SUPPORT`,I don't think we need this anymore.
+5311,"@@ -78,7 +78,13 @@ public class MockExecutorLoader implements ExecutorLoader {
+   @Override
+   public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedFlows()
+       throws ExecutorManagerException {
+-    return new ConcurrentHashMap<>();
++    return this.activeFlows;
++  }
++
++  @Override
++  public Map<Integer, Pair<ExecutionReference, ExecutableFlow>> fetchUnfinishedExecutions()
++      throws ExecutorManagerException {
++    return this.activeFlows;
+   }
+ 
+   @Override",unfinishedFlows might not be the same as activeFlows. Will it cause confusion here?,`fetchUnfinishedExecutions` -> `fetchUnfinishedFlows`
+5312,"@@ -73,3 +73,18 @@ func Example() {
+ 	cfg := snapshot.Value.(MyConfig)
+ 	_ = cfg
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""runtimeconfigurator://myproject/myconfigid/myvar?decoder=string"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}","Same, remove the error handling.",I think this should be `v.Watch(ctx)`
+5313,"@@ -1,14 +1,16 @@
+-// IMvxAppStart.cs
++// IMvxAppStart.cs
+ 
+ // MvvmCross is licensed using Microsoft Public License (Ms-PL)
+ // Contributions and inspirations noted in readme.md and license.txt
+ //
+ // Project Lead - Stuart Lodge, @slodge, me@slodge.com
+ 
++using System.Threading.Tasks;
++
+ namespace MvvmCross.Core.ViewModels
+ {
+     public interface IMvxAppStart
+     {
+-        void Start(object hint = null);
++        Task Start(object hint = null);
+     }
+ }",We should not change this at this time.,Why do we need this change?
+5314,"@@ -242,8 +242,8 @@ class AnchorGenerator(object):
+         Args:
+             base_anchors (torch.Tensor): The base anchors of a feature grid.
+             featmap_size (tuple[int]): Size of the feature maps.
+-            stride (tuple[int], optional): Stride of the feature map.
+-                Defaults to (16, 16).
++            stride (tuple[int], optional): Stride of the feature map in order
++                (w, h). Defaults to (16, 16).
+             device (str, optional): Device the tensor will be put on.
+                 Defaults to 'cuda'.
+ ",We may also update the docstring in the AnchorGenerator's arguments at around line 15.,"nit: ""in order"" -> ""in order"""
+5315,"@@ -930,7 +930,7 @@ bool CoreChecks::ValidateAndUpdateQFOScoreboard(const debug_report_data *report_
+                        "" duplicates existing barrier submitted in this batch from command buffer %s."",
+                        ""vkQueueSubmit()"", BarrierRecord::BarrierName(), operation, BarrierRecord::HandleName(),
+                        report_data->FormatHandle(barrier.handle).c_str(), barrier.srcQueueFamilyIndex, barrier.dstQueueFamilyIndex,
+-                       report_data->FormatHandle(inserted.first->second).c_str());
++                       report_data->FormatHandle(inserted.first->second->commandBuffer).c_str());
+     }
+     return skip;
+ }",FormatHandle isn't current typesafe w.r.t. requiring *VULKAN* handles... so this slipped through.,Why do we need this change?
+5316,"@@ -21,6 +21,7 @@ import (
+ 	""errors""
+ 	""testing""
+ 
++	""github.com/asaskevich/EventBus""
+ 	""github.com/stretchr/testify/assert""
+ 
+ 	""github.com/mysteriumnetwork/node/identity""","What kind of dependency is here, I think we have own implementation of event wo external dependencies",import (
+5317,"@@ -125,6 +125,18 @@ SYCL::SYCLDevice::SYCLDevice(sycl::device d) : m_device(std::move(d)) {}
+ SYCL::SYCLDevice::SYCLDevice(const sycl::device_selector& selector)
+     : m_device(selector.select_device()) {}
+ 
++SYCL::SYCLDevice::SYCLDevice(size_t id) {
++  std::vector<sycl::device> gpu_devices =
++      sycl::device::get_devices(sycl::info::device_type::gpu);
++  if (id >= gpu_devices.size()) {
++    std::stringstream error_message;
++    error_message << ""Requested GPU with id "" << id << "" but only ""
++                  << gpu_devices.size() << "" GPU(s) available!\n"";
++    Kokkos::abort(error_message.str().c_str());
++  }
++  m_device = gpu_devices[id];
++}
++
+ sycl::device SYCL::SYCLDevice::get_device() const { return m_device; }
+ 
+ void SYCL::impl_initialize(SYCL::SYCLDevice d) {",Throw an exception instead,Why do w
+5318,"@@ -6,6 +6,9 @@ RSpec.describe Org::CreateLastMonthCreatedPlanService do
+   let(:org) do
+     FactoryBot.create(:org, created_at: DateTime.new(2018, 04, 01))
+   end
++  let(:org2) do
++    FactoryBot.create(:org)
++  end
+   let(:template) do
+     FactoryBot.create(:template, org: org)
+   end",we shouldn't need the `FactoryBot.` in these. Ok to leave for now since all of these specs have them. Can clean up later,Layout/T
+5319,"@@ -80,7 +80,7 @@ class File extends FileBase
+             $uploadsPath .= '/protected';
+         }
+ 
+-        return Url::asset($uploadsPath) . '/';
++        return Storage::url($uploadsPath) . '/';
+     }
+ 
+     /**",Isn't the better option to actually do `$this->getDisk()->url($uploadsPath)` without changing the filesystems config? Not sure why you think that change is required but it's definitely not getting merged.,Shouldn'
+5320,"@@ -1585,7 +1585,7 @@ accessed. Python regular expressions are accepted."",
+             not isinstance(itemmethod, nodes.FunctionDef)
+             or itemmethod.root().name != ""builtins""
+             or not itemmethod.parent
+-            or itemmethod.parent.name not in SEQUENCE_TYPES
++            or itemmethod.parent.frame().name not in SEQUENCE_TYPES
+         ):
+             return None
+ ",Not sure if we need this. It's not tested because it only guards against a new conditional definition of a dunder method in a built-in package. I am fine with leaving it out.,I think this should be `itemmethod.parent.frame()`
+5321,"@@ -0,0 +1,16 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MIT license.
++// See the LICENSE file in the project root for more information.
++
++using Microsoft.DotNet.Build.Common.Desktop;
++
++namespace Microsoft.DotNet.Build.Tasks.Feed
++{
++    public partial class PushToBlobFeed
++    {
++        static PushToBlobFeed()
++        {
++            AssemblyResolver.Enable();
++        }
++    }
++}","Is this the only task in this library? If so this is good, if not then we should do it for each task.",Why do we need this?
+5322,"@@ -245,7 +245,7 @@ func (ops *Operations) GetCstorVolumeCountEventually(namespace, lselector string
+ 		cvCount := ops.GetCVCount(namespace, lselector)
+ 		return cvCount
+ 	},
+-		60, 10).Should(Equal(expectedCVCount))
++		120, 10).Should(Equal(expectedCVCount))
+ }
+ 
+ // GetCstorVolumeReplicaCountEventually gives the count of cstorvolume based on",I am not sure what is 120 and what is 10. Hence unable to review.,Why did this change?
+5323,"@@ -47,8 +47,9 @@ type Options struct {
+ 	Location   OptionsLocation
+ 	Transactor OptionsTransactor
+ 
+-	Openvpn  Openvpn
+-	Firewall OptionsFirewall
++	EnableDNS bool
++	Openvpn   Openvpn
++	Firewall  OptionsFirewall
+ }
+ 
+ // OptionsKeystore stores the keystore configuration",Not needed anymore,Shouldn't this be `bool`?
+5324,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
++// Package pingpong exposes the simple ping-pong protocol
++// which measures RTT with other peers.
+ package pingpong
+ 
+ import (",Please not abbreviations,// Package pingpong exposes the simple ping-pong protocol.
+5325,"@@ -199,6 +199,10 @@ var ValidateResponseHandler = request.NamedHandler{Name: ""core.ValidateResponseH
+ // AfterRetryHandler performs final checks to determine if the request should
+ // be retried and how long to delay.
+ var AfterRetryHandler = request.NamedHandler{Name: ""core.AfterRetryHandler"", Fn: func(r *request.Request) {
++	if !aws.IsReaderSeekable(r.Body) {
++		r.Retryable = aws.Bool(false)
++	}
++
+ 	// If one of the other handlers already set the retry state
+ 	// we don't want to override it based on the service's state
+ 	if r.Retryable == nil || aws.BoolValue(r.Config.EnforceShouldRetryCheck) {",This shouldn't get stomped over on line 207,I don't think this is the right place to do this. If the r
+5326,"@@ -37,6 +37,7 @@ func (tok Token) String() string {
+ }
+ 
+ // A Position describes a position in a source file.
++// All properties in Position are zero indexed
+ type Position struct {
+ 	Filename string
+ 	Offset   int",are they not 1-indexed?,// Position represents a position in a source file.
+5327,"@@ -272,7 +272,7 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount, checkAllo
+ 	}
+ 
+ 	currentTime := s.timeNow().Unix()
+-	if currentTime == lastTime.CheckTimestamp {
++	if currentTime == lastTime.CheckTimestamp || currentTime == lastTime.Timestamp {
+ 		return nil, 0, ErrSettlementTooSoon
+ 	}
+ ",I know that previously this check was here but @ralph-pichler replaced it with the `CheckTimestamp` field stating that checking against `Timestamp` was incorrect. @ralph-pichler can you elaborate?,Shouldn't this be `||`?
+5328,"@@ -0,0 +1,19 @@
++# Copyright (c) Open-MMLab. All rights reserved.
++
++__version__ = '2.3.0rc0'
++short_version = '2.3.0rc0'
++
++
++def parse_version_info(version_str):
++    version_info = []
++    for x in version_str.split('.'):
++        if x.isdigit():
++            version_info.append(int(x))
++        elif x.find('rc') != -1:
++            patch_version = x.split('rc')
++            version_info.append(int(patch_version[0]))
++            version_info.append(f'rc{patch_version[1]}')
++    return tuple(version_info)
++
++
++version_info = parse_version_info(__version__)",`short_version = __version__`,This should be `short_version`
+5329,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[UpdateAccessKey.java demonstrates how to update the status of an access key for an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[UpdateAccessKey.java demonstrates how to update the status of an access key for an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I'm not sure if this is a typo
+5330,"@@ -19,11 +19,12 @@
+ 
+ package org.apache.iceberg.spark;
+ 
++import java.io.Serializable;
+ import org.apache.iceberg.StructLike;
+ import org.apache.iceberg.types.Types;
+ import org.apache.spark.sql.Row;
+ 
+-public class SparkStructLike implements StructLike {
++public class SparkStructLike implements StructLike, Serializable {
+ 
+   private final Types.StructType type;
+   private Row wrapped;",Required for the SparkDataFile SerDe,Why do we need this?
+5331,"@@ -2595,16 +2595,8 @@ bool SwiftLanguageRuntime::CouldHaveDynamicValue(ValueObject &in_value) {
+     // Swift class instances are actually pointers, but base class instances
+     // are inlined at offset 0 in the class data. If we just let base classes
+     // be dynamic, it would cause an infinite recursion. So we would usually
+-    // disable it
+-    // But if the base class is a generic type we still need to bind it, and
+-    // that is
+-    // a good job for dynamic types to perform
+-    if (in_value.IsBaseClass()) {
+-      CompilerType base_type(in_value.GetCompilerType());
+-      if (SwiftASTContext::IsFullyRealized(base_type))
+-        return false;
+-    }
+-    return true;
++    // disable it.
++    return !in_value.IsBaseClass();
+   }
+   return var_type.IsPossibleDynamicType(nullptr, false, false, true);
+ }",Do you want to make this an assertion instead?,I'm not sure if this is the ri
+5332,"@@ -1,5 +1,5 @@
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2015 NV Access Limited
++#Copyright (C) 2016 NV Access Limited
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ","When updating the copyright, we tend to cover previous years, not just the current. So, if we started the file in 2015, we'd update to say 2015-2016. I'm not sure if there's a legal requirement surrounding this, but it's the convention we and many others have adopted for code.",Why did you change this?
+5333,"@@ -1180,6 +1180,16 @@ func (fbo *folderBranchOps) SetInitialHeadFromServer(
+ 		return fmt.Errorf(""MD with revision=%d not initialized"", md.Revision())
+ 	}
+ 
++	// Return early if the head is already set.  This avoids taking
++	// mdWriterLock for no reason.
++	lState := makeFBOLockState()
++	head := fbo.getHead(lState)
++	if head != (ImmutableRootMetadata{}) && head.mdID == md.mdID {
++		fbo.log.CDebugf(ctx, ""Head MD already set to revision %d (%s), no ""+
++			""need to set initial head again"", md.Revision(), md.MergedStatus())
++		return nil
++	}
++
+ 	return runUnlessCanceled(ctx, func() error {
+ 		fb := FolderBranch{md.TlfID(), MasterBranch}
+ 		if fb != fbo.folderBranch {","Wait, so it looks like this function is called _every_ time we fetch the root node, i.e. we do an MD head fetch every time we fetch the root node? Not for this PR, but it seems like we should make that unnecessary, since this function only ever does anything when head is `nil`, i.e. the first time. Maybe add a TODO?",I don't think this is th
+5334,"@@ -1948,9 +1948,9 @@ class DomainNameListField(StrLenField):
+     islist = 1
+     padded_unit = 8
+ 
+-    def __init__(self, name, default, fld=None, length_from=None, padded=False):  # noqa: E501
++    def __init__(self, name, default, length_from=None, padded=False):  # noqa: E501
+         self.padded = padded
+-        StrLenField.__init__(self, name, default, fld, length_from)
++        StrLenField.__init__(self, name, default, length_from=length_from)
+ 
+     def i2len(self, pkt, x):
+         return len(self.i2m(pkt, x))",Why are you changing this?,Why did you remove the `
+5335,"@@ -35,11 +35,11 @@ func NewConfigParser() *ConsumerConfigParser {
+ }
+ 
+ // Parse parses the given configuration
+-func (c *ConsumerConfigParser) Parse(config json.RawMessage) (ip string, port int, serviceType services.ServiceType, err error) {
++func (c *ConsumerConfigParser) Parse(config *json.RawMessage) (ip string, port int, serviceType services.ServiceType, err error) {
+ 	// TODO: since we are getting json.RawMessage here and not interface{} type not sure how to handle multiple services
+ 	// since NATPinger is one for all services and we get config from communication channel where service type is not know yet.
+ 	var cfg openvpn.ConsumerConfig
+-	err = json.Unmarshal(config, &cfg)
++	err = json.Unmarshal(*config, &cfg)
+ 	if err != nil {
+ 		return """", 0, """", errors.Wrap(err, ""parsing consumer address:port failed"")
+ 	}","`json.RawMessage` is a `[]byte`, which is already a pointer. Why do we need to have pointer here if we just reading this value?",Why is this change neede
+5336,"@@ -29,7 +29,7 @@ func main() {
+ 		cni.ActionAdd.Request,
+ 		cni.ActionCheck.Request,
+ 		cni.ActionDel.Request,
+-		cni_version.PluginSupports(""0.1.0"", ""0.2.0"", ""0.3.0"", ""0.3.1""),
++		cni_version.All,
+ 		fmt.Sprintf(""Antrea CNI %s"", version.GetFullVersionWithRuntimeInfo()),
+ 	)
+ }",should we actually switch to `All` or just add `0.4.0` explicitly to the list of supported CNI versions? What is a new CNI version is released?,Why did you remove the plugin support check?
+5337,"@@ -23,6 +23,7 @@ from google.cloud.security.notifier import notifier
+ 
+ from google.cloud.security.common.data_access import csv_writer
+ from google.cloud.security.scanner.audit import fw_rules_engine
++from google.cloud.security.common.gcp_type import resource_util
+ from google.cloud.security.common.data_access import firewall_rule_dao
+ from google.cloud.security.scanner.scanners import base_scanner
+ ",pylint might complain that this isn't alphasorted?,from google.cloud.security.common import res
+5338,"@@ -52,6 +52,7 @@ namespace Interop.FunctionalTests
+                 $""--no-sandbox "" +
+                 $""--disable-gpu "" +
+                 $""--allow-insecure-localhost "" +
++                $""--ignore-certificate-errors --enable-features=NetworkService "" +
+                 $""--enable-logging "" +
+                 $""--dump-dom "" +
+                 $""--virtual-time-budget=10000 "" +","It seems that NetworkService is behind a feature flag because it's still experimental. If we see new issues, we should look at flipping this back off.",Why do we need this?
+5339,"@@ -31,6 +31,19 @@ func (ts *TaskStatus) String() string {
+ 	return ""UNKNOWN""
+ }
+ 
++// Mapping task status in the agent to that in the backend
++func BackEndStatus(ts *TaskStatus) string {
++	switch *ts {
++	case TaskRunning:
++		return ""RUNNING""
++	case TaskStopped:
++		return ""STOPPED""
++	case TaskDead:
++		return ""STOPPED""
++	}
++	return ""PENDING""
++}
++
+ var containerStatusMap = map[string]ContainerStatus{
+ 	""NONE"":    ContainerStatusNone,
+ 	""UNKNOWN"": ContainerStatusUnknown,","I think it makes more sense to have this be a method on TaskStatus. Also, nit, Backend, not BackEnd.",nit: can we call this `BackEndTaskStatus`?
+5340,"@@ -154,6 +154,10 @@ int HIPInternal::verify_is_initialized(const char *const label) const {
+   return 0 <= m_hipDev;
+ }
+ 
++uint32_t HIPInternal::impl_get_instance_id() const noexcept {
++  return Kokkos::Tools::Experimental::Impl::idForInstance<
++      Kokkos::Experimental::HIP>(reinterpret_cast<uintptr_t>(this));
++}
+ HIPInternal &HIPInternal::singleton() {
+   static HIPInternal *self = nullptr;
+   if (!self) {",Could you please elaborate on why you need all this magic here? In which cases do you want the same id to be returned? Does this work the same way for all backends?,Why do we need this?
+5341,"@@ -38,11 +38,8 @@ var (
+ )
+ 
+ type Config struct {
+-	// Directory in which plugin config files
+-	// reside
+-	ConfigDir string
+-
+-	Log logrus.FieldLogger
++	PluginsConfigs map[string]map[string]common.HclPluginConfig
++	Log            logrus.FieldLogger
+ }
+ 
+ type catalog struct {",nit: `PluginConfigs` feels a little better,Why do we need this?
+5342,"@@ -323,7 +323,7 @@ func TestLocalTransfer(t *testing.T) {
+ 	probeSvr := probe.New(7788)
+ 	require.NoError(probeSvr.Start(ctx))
+ 	defer func() {
+-		require.NoError(probeSvr.Stop(ctx))
++		probeSvr.Stop(ctx)
+ 	}()
+ 
+ 	// Start server","think we need to find out the root-cause and fix, instead of just removing `NoError`? it erred b/c `context canceled`, so call this before context cancelled is the right fix",Why this change?
+5343,"@@ -405,7 +405,10 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock.
+ 				id, tlfID, context, size)
+ 			dbc := b.config.DiskBlockCache()
+ 			if dbc != nil {
+-				go dbc.Put(ctx, tlfID, id, buf, serverHalf)
++				// This used to be called in a goroutine to prevent blocking
++				// the `Get`. But we need this cached synchronously for
++				// later behavior.
++				dbc.Put(ctx, tlfID, id, buf, serverHalf)
+ 			}
+ 		}
+ 	}()","Please expand ""later behavior"". Presumably something to do with the prefetch logic?",I'm not sure if this
+5344,"@@ -66,7 +66,7 @@ func (s *server) splitUpload(ctx context.Context, r io.ReadCloser, l int64) (int
+ 		response.Message = ""upload error""
+ 		response.Code = http.StatusInternalServerError
+ 		err = fmt.Errorf(""%s: %v"", response.Message, err)
+-		return response, err
++		return swarm.ZeroAddress, err
+ 	}
+ 	return bytesPostResponse{Reference: address}, nil
+ }","The `response` variable is not used, it can be removed, also the fmt.Errorf.",Shouldn't this be `swarm.ZeroAddress`?
+5345,"@@ -51,10 +51,7 @@ namespace NLog.Internal
+         internal static bool IsNullOrWhiteSpace(string value)
+         {
+ #if NET3_5
+-
+-            if (value == null) return true;
+-            if (value.Length == 0) return true;
+-            return String.IsNullOrEmpty(value.Trim());
++            return value?.Length > 0 ? string.IsNullOrEmpty(value.Trim()) : true;
+ #else
+             return string.IsNullOrWhiteSpace(value);
+ #endif",Do you find this really easier to read?,Why not just `return value?.Length > 0
+5346,"@@ -11388,8 +11388,9 @@ void RelRoot::setMvBindContext(MvBindContext * pMvBindContext)
+   pMvBindContextForScope_ = pMvBindContext;
+ }
+ 
+-void RelRoot::addOneRowAggregates(BindWA* bindWA)
++NABoolean RelRoot::addOneRowAggregates(BindWA* bindWA, NABoolean forceGroupByAgg)
+ {
++  NABoolean GroupByAggNodeAdded = FALSE;
+   RelExpr * childOfRoot = child(0);
+   GroupByAgg *aggNode = NULL;
+   // If the One Row Subquery is already enforced by a scalar aggregate",A small nit: This variable should start with a lower case letter.,nit: `bool` instead of `NABoolean`?
+5347,"@@ -38,12 +38,13 @@ public class PageStreamingTransformer {
+ 
+       PageStreamingDescriptorView.Builder descriptor = PageStreamingDescriptorView.newBuilder();
+       descriptor.varName(context.getNamer().getPageStreamingDescriptorName(method));
+-      descriptor.requestTokenFieldName(pageStreaming.getRequestTokenField().getSimpleName());
++      descriptor.requestTokenFieldName(context.getNamer().getRequestTokenFieldName(pageStreaming));
+       if (pageStreaming.hasPageSizeField()) {
+-        descriptor.requestPageSizeFieldName(pageStreaming.getPageSizeField().getSimpleName());
++        descriptor.requestPageSizeFieldName(context.getNamer().getPageSizeFieldName(pageStreaming));
+       }
+-      descriptor.responseTokenFieldName(pageStreaming.getResponseTokenField().getSimpleName());
+-      descriptor.resourcesFieldName(pageStreaming.getResourcesFieldName());
++      descriptor.responseTokenFieldName(
++          context.getNamer().getResponseTokenFieldName(pageStreaming));
++      descriptor.resourcesFieldName(context.getNamer().getResourcesFieldName(pageStreaming));
+       descriptor.methodName(context.getNamer().getMethodKey(method));
+ 
+       descriptors.add(descriptor.build());",Where is this used for Node?,Why not use `pageStreaming.getRequestT
+5348,"@@ -130,14 +130,14 @@ func (c *Command) handleActions(line string) {
+ 
+ func (c *Command) connect(argsString string) {
+ 	if len(argsString) == 0 {
+-		info(""Press tab to select identity or create a new one. Connect <your-identity> <node-identity>"")
++		info(""Press tab to select identity or create a new one. Connect <your-id> <provider-id>"")
+ 		return
+ 	}
+ 
+ 	identities := strings.Fields(argsString)
+ 
+ 	if len(identities) != 2 {
+-		info(""Please type in the node identity. Connect <your-identity> <node-identity>"")
++		info(""Please type in the provider identity. Connect <your-id> <provider-id>"")
+ 		return
+ 	}
+ ","Is `<your-id>` really easier to understand than `<your-identity>` for CLI user? For me, `identity` seems like a concept we use publicly, and `id` is just an internal shortcut for it.",I don't think we should change the command name here.
+5349,"@@ -39,7 +39,11 @@ func (n *NetworkPolicyController) addClusterGroup(curObj interface{}) {
+ 	key := internalGroupKeyFunc(cg)
+ 	klog.V(2).Infof(""Processing ADD event for ClusterGroup %s"", cg.Name)
+ 	newGroup := n.processClusterGroup(cg)
+-	klog.V(2).Infof(""Creating new internal Group %s with selector (%s)"", newGroup.UID, newGroup.Selector.NormalizedName)
++	if newGroup.ServiceReference != nil {
++		klog.V(2).Infof(""Creating new internal Group %s for Service %s/%s"", newGroup.UID, newGroup.ServiceReference.Namespace, newGroup.ServiceReference.Name)
++	} else if newGroup.Selector != nil {
++		klog.V(2).Infof(""Creating new internal Group %s with selector (%s)"", newGroup.UID, newGroup.Selector.NormalizedName)
++	}
+ 	n.internalGroupStore.Create(newGroup)
+ 	n.enqueueInternalGroup(key)
+ }",nit.. `if` .. `else` for logging probably can be avoided.. maybe only log that an internal group was created for cluster group,Why do we need this?
+5350,"@@ -21,6 +21,7 @@ import (
+ 	""time""
+ 
+ 	""github.com/aws/amazon-ecs-agent/agent/api""
++	""github.com/aws/amazon-ecs-agent/agent/config""
+ 	""github.com/aws/amazon-ecs-agent/agent/engine/dockerstate/mocks""
+ 	""github.com/aws/amazon-ecs-agent/agent/engine/testdata""
+ 	""github.com/aws/amazon-ecs-agent/agent/eventstream""",There's a lot of changed tests -- but no new tests. You need unit and integration tests for this.,This import should be grouped with the other `github.
+5351,"@@ -38,16 +38,16 @@ namespace Nethermind.TxPool.Filters
+             _configuredGasLimit = txPoolConfig.GasLimit ?? long.MaxValue;
+         }
+             
+-        public (bool Accepted, AddTxResult? Reason) Accept(Transaction tx, TxHandlingOptions handlingOptions)
++        public AcceptTxResult Accept(Transaction tx, TxHandlingOptions handlingOptions)
+         {
+             long gasLimit = Math.Min(_chainHeadInfoProvider.BlockGasLimit ?? long.MaxValue, _configuredGasLimit);
+             if (tx.GasLimit > gasLimit)
+             {
+                 if (_logger.IsTrace) _logger.Trace($""Skipped adding transaction {tx.ToString(""  "")}, gas limit exceeded."");
+-                return (false, AddTxResult.GasLimitExceeded);
++                return AcceptTxResult.GasLimitExceeded;
+             }
+ 
+-            return (true, null);
++            return AcceptTxResult.Accepted;
+         }
+     }
+ }",WithMessage what gas limit is?,Shouldn't this be `AcceptTxResult.GasLimitExceeded`?
+5352,"@@ -2099,7 +2099,7 @@ describe('Cursor', function() {
+    * @ignore
+    * @api private
+    */
+-  it('cursor stream errors', {
++  it.skip('cursor stream errors', {
+     // Add a tag that our runner can trigger on
+     // in this case we are setting that node needs to be higher than 0.10.X to run
+     metadata: { requires: { topology: ['single'] } },",Why are these skipped?,Why is this skipped?
+5353,"@@ -388,6 +388,13 @@ type MetaManager struct {
+ 	// RemoteQueryTimeout indicates remote query timeout (second)
+ 	// default 60
+ 	RemoteQueryTimeout int32 `json:""remoteQueryTimeout,omitempty""`
++	// The config of MetaServer
++	MetaServer `json:""metaServer,omitempty""`
++}
++
++type MetaServer struct {
++	Enable bool
++	Debug  bool
+ }
+ 
+ // ServiceBus indicates the ServiceBus module config","We'd better add the `json:""metaServer,omitempty""` here",Why do we need this?
+5354,"@@ -0,0 +1,17 @@
++#!/usr/bin/env python3
++import platform
++import sys
++from pathlib import Path
++from subprocess import check_call
++
++here = Path(__file__).parent
++
++pip_install = [
++    sys.executable, ""-m"",
++    ""pip"",
++    ""install"",
++    ""--disable-pip-version-check"",
++]
++
++check_call([*pip_install, ""--require-hashes"", ""-r"", f""requirements-{platform.system().lower()}.txt""], cwd=here)
++check_call([*pip_install, ""--no-deps"", ""-e"", ""../..""], cwd=here)","So... when we want to install mitmproxy with pinned dependencies, we first install all pinned dependencies, and then in a second step install mitmproxy as editable, making sure that no additional dependencies are sneaking in.  ",This should be `os.p
+5355,"@@ -68,7 +68,10 @@ func Sandbox(args []string) error {
+ 		}
+ 	}
+ 	err = syscall.Exec(cmd, args, env)
+-	return fmt.Errorf(""Failed to exec %s: %s"", cmd, err)
++	if err != nil {
++		return fmt.Errorf(""Failed to exec %s: %s"", cmd, err)
++	}
++	return nil
+ }
+ 
+ func rewriteEnvVars(env []string, from, to string) {","not sure how this got in master, but the linter is unhappy about it so I fixed it here",I don't think we wan
+5356,"@@ -15,3 +15,8 @@ const rekeyRecheckInterval = 30 * time.Second
+ 
+ // rekeyInitialTTL is the maximum number rechecks each rekey request can trigger.
+ const rekeyInitialTTL = 4
++
++// mdserverReconnectBackoffWindow is a backoff window within which we try to
++// wait randomly for before reconnecting to MD server.
++// TODO: increase this to 5 min
++const mdserverReconnectBackoffWindow = 5 * time.Minute","No need for this TODO anymore, right?",Can we make this configurable?
+5357,"@@ -47,7 +47,8 @@ def main(global_config, config=None, **settings):
+ 
+     # In Kinto API 1.x, a default bucket is available.
+     # Force its inclusion if not specified in settings.
+-    if 'kinto.plugins.default_bucket' not in settings['includes']:
++    if 'kinto.plugins.default_bucket' not in settings['includes'] \
++	 and 'kinto.plugins.default_bucket' not in settings['excludes']:
+         config.include('kinto.plugins.default_bucket')
+ 
+     # Retro-compatibility with first Kinto clients.","I would assign the key you're looking for into a variable first, and then use it in the comparisons.",Why is this needed?
+5358,"@@ -855,6 +855,9 @@ class PluginManager
+         if ($pluginPath = self::instance()->getPluginPath($id)) {
+             File::deleteDirectory($pluginPath);
+         }
++
++        // actually remove the plugin from our internal container
++        unset($this->plugins[ $this->normalizeIdentifier($id) ]);
+     }
+ 
+     /**",Would be better to normalize it at the start of the method to pass through to all the other calls,Why is this needed?
+5359,"@@ -167,6 +167,7 @@ class CodeEditor extends FormWidgetBase
+         $this->vars['highlightActiveLine'] = $this->highlightActiveLine;
+         $this->vars['useSoftTabs'] = $this->useSoftTabs;
+         $this->vars['showGutter'] = $this->showGutter;
++        $this->vars['safeMode'] = $this->parentForm->model->isSafeMode();
+         $this->vars['language'] = $this->language;
+         $this->vars['margin'] = $this->margin;
+         $this->vars['stretch'] = $this->formField->stretch;",This can't exist here either because the code editor can be used on other models than CMS templates. You could probably implement this as a `hint` property (so `hint: cms::lang.cms_object.safe_mode_enabled`) on the codeeditor formwidget instead though and I'd be fine with that.,Shouldn't this be `isSafeMode`
+5360,"@@ -888,6 +888,15 @@ class WordDocumentTextInfo(textInfos.TextInfo):
+ 			field['line-prefix']=mapPUAToUnicode.get(bullet,bullet)
+ 		return field
+ 
++	def scrollIntoView(self):
++		try:
++			self.obj.WinwordWindowObject.ScrollIntoView(self._rangeObj, True)
++		except COMError:
++			log.exception(""Can't scroll"")
++			pass
++
++
++
+ 	def expand(self,unit):
+ 		if unit==textInfos.UNIT_LINE: 
+ 			try:",This line is unnecessary.,"This should be `log.exception(""Can't scroll"")`"
+5361,"@@ -119,13 +119,4 @@ Recorder::~Recorder() {
+   UpdateBoundary();
+ }
+ 
+-void Recorder::Log(unsigned id) {
+-#ifndef LLDB_REPRO_INSTR_TRACE
+-  LLDB_LOG(GetLogIfAllCategoriesSet(LIBLLDB_LOG_API), ""Recording {0}: {1}"", id,
+-           m_pretty_func);
+-#else
+-  llvm::errs() << ""Recording "" << id << "": "" << m_pretty_func << ""\n"";
+-#endif
+-}
+-
+ bool lldb_private::repro::Recorder::g_global_boundary;",How did this compile in the first place? Is there a matching declaration in a header that should be removed too?,Why is this being removed?
+5362,"@@ -56,7 +56,8 @@ mrb_value h2o_mruby__new_str(mrb_state *mrb, const char *s, size_t len, const ch
+     if (mrb->exc != NULL)
+         h2o_mruby__abort_exc(mrb, ""h2o_mruby_new_str:precondition failure"", file, line);
+     mrb_value ret = mrb_str_new(mrb, s, len);
+-    h2o_mruby_assert(mrb);
++    if (mrb->exc != NULL)
++        h2o_mruby__abort_exc(mrb, ""h2o_mruby_new_str:failed to create string:"", file, line);
+     return ret;
+ }
+ ","Please remove the colon at the end, and merge the PR once the CI succeeds. Thank you for the PR.",Shouldn't this be `h2o_mruby_new_str`?
+5363,"@@ -3,8 +3,5 @@
+ package tools
+ 
+ import (
+-	_ ""github.com/AlekSi/gocoverutil""
+ 	_ ""github.com/golang/protobuf/protoc-gen-go""
+-	_ ""github.com/jteeuwen/go-bindata/go-bindata""
+-	_ ""github.com/mattn/goveralls""
+ )","whoops. this should be protoc-gen-doc, since that is the only bit left that is built out-of-tree (everything else is either downloaded or built via modules already depended on by spire's go.mod)",Why are these removed?
+5364,"@@ -0,0 +1,19 @@
++package azkaban.spi;
++
++import java.util.Map;
++
++/**
++ * Implement this interface to report flow and job events. Event reporter
++ * can be turned on by setting the property {@code AZKABAN_EVENT_REPORTING_ENABLED} to true.
++ *
++ * By default, a KafkaAvroEventReporter is provided. Alternate implementations
++ * can be provided by setting the property {@code AZKABAN_EVENT_REPORTING_CLASS_PARAM}
++ * <br><br>
++ * The constructor will be called with a {@code azkaban.utils.Props} object passed as
++ * the only parameter. If such a constructor doesn't exist, then the AzkabanEventReporter
++ * instantiation will fail.
++ */
++public interface AzkabanEventReporter {
++
++  boolean report(EventType eventType, Map<String, String> metadata);
++}",The convention is to use <p> see the google style guide and use checkstyle to check. You can change it later.,Why do we need this interface? Can't we just use `KafkaEventReporter`?
+5365,"@@ -134,12 +134,14 @@ class ListElement(list):
+     def startElement(self, name, attrs, connection):
+         for lm in self.list_marker:
+             if name.endswith(lm):
+-                l = ListElement(self.connection, name, self.item_marker,
++                l = ListElement(self.connection, name, self.list_marker,
++                                self.item_marker,
+                                 pythonize_name=self.pythonize_name)
+                 setattr(self, self.get_name(name), l)
+                 return l
+         if name in self.item_marker:
+             e = Element(self.connection, name, parent=self,
++                        self.list_marker, self.item_marker,
+                         pythonize_name=self.pythonize_name)
+             self.append(e)
+             return e",Using non-keyword args after the keyword arg (parent-self) will cause a SyntaxError.,I don't think you need to pass `list_marker` and `item_marker` here.
+5366,"@@ -277,6 +277,13 @@ module Faker
+         '%08x-%04x-%04x-%04x-%04x%08x' % ary # rubocop:disable Style/FormatString
+       end
+ 
++      def user(*args)
++        user_hash = {}
++        args = %w[username email] if args.empty?
++        args.each { |arg| user_hash[:""#{arg}""] = send(arg) }
++        user_hash
++      end
++
+       alias user_name username
+     end
+   end",I think you'll want to add some YARD docs to this method to get the PR approved  ,I'm not sure if this is the best way to do this. I think it would be b
+5367,"@@ -4452,12 +4452,13 @@ ostree_repo_query_object_storage_size (OstreeRepo           *self,
+  * @self: Repo
+  * @objtype: Object type
+  * @sha256: ASCII checksum
+- * @out_variant: (out) (transfer full): Metadata
++ * @out_variant: (out) (nullable) (transfer full): Metadata
+  * @error: Error
+  *
+  * Attempt to load the metadata object @sha256 of type @objtype if it
+  * exists, storing the result in @out_variant.  If it doesn't exist,
+- * %NULL is returned.
++ * @out_variant will be set to %NULL and the function will still
++ * return TRUE.
+  */
+ gboolean
+ ostree_repo_load_variant_if_exists (OstreeRepo       *self,","Hmm, AFAICT `*out_variant` isn't explicitly set to `NULL` in the `ENOENT` case.",`@out_variant will be set to %NULL and the function will still return 
+5368,"@@ -87,12 +87,18 @@ func (b *clientFactory) SDKClient(c *cli.Context, namespace string) sdkclient.Cl
+ 		hostPort = localHostPort
+ 	}
+ 
++	tlsConfig, err := b.createTLSConfig(c)
++	if err != nil {
++		b.logger.Fatal(""Failed to create SDK client"", zap.Error(err))
++	}
++
+ 	sdkClient, err := sdkclient.NewClient(sdkclient.Options{
+ 		HostPort:  hostPort,
+ 		Namespace: namespace,
+ 		Logger:    log.NewZapAdapter(b.logger),
+ 		ConnectionOptions: sdkclient.ConnectionOptions{
+ 			DisableHealthCheck: true,
++			TLS:                tlsConfig,
+ 		},
+ 	})
+ 	if err != nil {","Nit: ""Failed to configure TLS for SDK client""?",Why do we need to create a new client here?
+5369,"@@ -89,7 +89,7 @@ def test_plot_split_value_histogram(params, breast_cancer_split, train_data):
+                                          title='Histogram for feature @index/name@ @feature@',
+                                          xlabel='x', ylabel='y', color='r')
+     assert isinstance(ax1, matplotlib.axes.Axes)
+-    title = 'Histogram for feature name {}'.format(gbm1.booster_.feature_name()[27])
++    title = f'Histogram for feature name {gbm1.booster_.feature_name()[27]}'
+     assert ax1.get_title() == title
+     assert ax1.get_xlabel() == 'x'
+     assert ax1.get_ylabel() == 'y'",please update your branch to the latest `master`. This change was already made in #4359,This should be `f'Histogram for feature {gb
+5370,"@@ -18,6 +18,8 @@ import (
+ 	""crypto/sha1""
+ 	""errors""
+ 	""fmt""
++	""github.com/pingcap/chaos-mesh/controllers""
++	""time""
+ 
+ 	""golang.org/x/sync/errgroup""
+ ",This line should be formatted,Please remove this line.
+5371,"@@ -32,6 +32,9 @@ int main (int argc, char * const * argv)
+ 		(""disable_unchecked_drop"", ""Disables drop of unchecked table at startup"")
+ 		(""fast_bootstrap"", ""Increase bootstrap speed for high end nodes with higher limits"")
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
++		(""block_processor_batch_size"",boost::program_options::value<std::size_t> (), ""Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time)"")
++		(""block_processor_full_size"",boost::program_options::value<std::size_t> (), ""Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536"")
++		(""block_processor_verification_size"",boost::program_options::value<std::size_t> (), ""Increase batch signature verification size in block processor, default 0 (2048 * signature checker threads + 1)"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
+ 		(""debug_dump_online_weight"", ""Dump online_weights table"")","""default 65536"" Not sure if it's important to state, but block_processor_full_size has a different default for fast_bootstrap.",I think this should be `block_processor_tra
+5372,"@@ -23,5 +23,6 @@ namespace Nethermind.TxPool
+         public uint FutureNonceRetention { get; set; } = 16;
+         public int HashCacheSize { get; set; } = 512 * 1024;
+         public long? GasLimit { get; set; } = null;
++        
+     }
+ }",remove unnecessary whitespace changes,public long? GasPrice { get; set; }
+5373,"@@ -46,10 +46,6 @@ func TxnPool(s *transactions.SignedTxn, spec transactions.SpecialAddresses, prot
+ 		return errors.New(""empty address"")
+ 	}
+ 
+-	if s.Sig != (crypto.Signature{}) && !s.Msig.Blank() {
+-		return errors.New(""signedtxn should only have one of Sig or Msig"")
+-	}
+-
+ 	outCh := make(chan error, 1)
+ 	cx := asyncVerifyContext{s, outCh, &proto}
+ 	verificationPool.EnqueueBacklog(context.Background(), stxnAsyncVerify, &cx, nil)",Are these conditions covered elsewhere ?,Why is this removed?
+5374,"@@ -59,7 +59,14 @@ TurnType::Enum IntersectionHandler::findBasicTurnType(const EdgeID via_edge,
+     if (!on_ramp && onto_ramp)
+         return TurnType::OnRamp;
+ 
+-    if (in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAMEID)
++    const auto same_name =
++        !util::guidance::requiresNameAnnounced(name_table.GetNameForID(in_data.name_id),
++                                               name_table.GetRefForID(in_data.name_id),
++                                               name_table.GetNameForID(out_data.name_id),
++                                               name_table.GetRefForID(out_data.name_id),
++                                               street_name_suffix_table);
++
++    if (in_data.name_id != EMPTY_NAMEID && out_data.name_id != EMPTY_NAMEID && same_name)
+     {
+         return TurnType::Continue;
+     }",the above check (by transitivity) checked for `in_data.name_id == out_data.name_id && in_data.name_id != EMPTY_NAME_ID && out_data.name_id != EMPTY_NAME_ID`. The final check of `out_data.name_id != EMPTY_NAME_ID` is missing now.,I don't think you need to check for
+5375,"@@ -583,6 +583,11 @@ out_free:
+ 
+ fpga_result __FPGA_API__ fpgaDestroyEventHandle(fpga_event_handle *event_handle)
+ {
++	//sanity check
++	if (!event_handle) {
++		return FPGA_INVALID_PARAM;
++	}
++
+ 	struct _fpga_event_handle *_eh = (struct _fpga_event_handle *) *event_handle;
+ 	fpga_result result = FPGA_OK;
+ 	int err = 0;","The event handle is being passed by reference, so the dereference on 591 is actually correct. To follow the convention that variables be declared before executable statements, please change the code to the following: struct _fpga_event_handle *_eh; fpga_result result = FPGA_OK; int err = 0; if (!event_handle) { return FPGA_INVALID_PARAM; } _eh = (struct _fpga_event_handle *) *event_handle;",This should be `return FPGA_INVALID
+5376,"@@ -42,6 +42,7 @@ class named_mutex;
+ #include ""../plugins/nearest.hpp""
+ #include ""../plugins/timestamp.hpp""
+ #include ""../plugins/viaroute.hpp""
++#include ""../plugins/map_matching.hpp""
+ #include ""../server/data_structures/datafacade_base.hpp""
+ #include ""../server/data_structures/internal_datafacade.hpp""
+ #include ""../server/data_structures/shared_barriers.hpp""",reorder includes to be alphabetically ordered,"#include ""../server/data_structures/map_matching.hpp"""
+5377,"@@ -13,7 +13,8 @@ def anchor_target(anchor_list,
+                   cfg,
+                   gt_labels_list=None,
+                   cls_out_channels=1,
+-                  sampling=True):
++                  sampling=True,
++                  need_unmap=True):
+     """"""Compute regression and classification targets for anchors.
+ 
+     Args:",Rename `need_unmap` to `unmap`.,I think this should be False by default.
+5378,"@@ -26,7 +26,6 @@ import (
+ 	""sigs.k8s.io/controller-runtime/pkg/client""
+ 
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common""
+-	cm ""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/common""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/iochaos""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/networkchaos""
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/chaosctl/debug/stresschaos""","In line 28, it has been declared twice, so removing `cm` should not impact, can you explain me little bit? :)",Why was this removed?
+5379,"@@ -16,7 +16,10 @@ import (
+ 
+ const Name = ""clutch.service.topology""
+ 
+-type Service interface{}
++type Service interface {
++	acquireTopologyCacheLock()
++	startTopologyCache()
++}
+ 
+ type client struct {
+ 	config *topologyv1.Config","i don't think these unexported functions belong on the public interface, they can exist solely on the struct.",Why do we need this?
+5380,"@@ -263,6 +263,13 @@ func (h Helper) NewBindAddresses(addrs []string) []ConfigValue {
+ 	return []ConfigValue{{Class: ""bind"", Value: addrs}}
+ }
+ 
++// WithDispenser returns a new instance based on d. All others Helper
++// fields are copied, so typically maps are shared with this new instance.
++func (h Helper) WithDispenser(d *caddyfile.Dispenser) Helper {
++	h.Dispenser = d
++	return h
++}
++
+ // ParseSegmentAsSubroute parses the segment such that its subdirectives
+ // are themselves treated as directives, from which a subroute is built
+ // and returned.",I'm not entirely clear on why this is necessary?,Why is this needed?
+5381,"@@ -317,7 +317,7 @@ def save_session(fname="""", session=None, pickleProto=-1):
+     if not fname:
+         fname = conf.session
+         if not fname:
+-            conf.session = fname = utils.get_temp_file(keep=True)
++            conf.session = fname = cast(str, utils.get_temp_file(keep=True))
+     log_interactive.info(""Use [%s] as session file"" % fname)
+ 
+     if not session:",Why do we need to cast to `str` here?,I think this should
+5382,"@@ -17,7 +17,6 @@ import org.testfx.api.FxToolkit;
+ public class AppConfigurationInitialisationTest {
+ 
+ 	@Test
+-	@Ignore
+ 	public void testAppConfigurationInitialisation() throws TimeoutException {
+ 		FxToolkit.registerPrimaryStage();
+ 		FxToolkit.setupFixture(() -> new AnnotationConfigApplicationContext(AppConfiguration.class));",The ignore import above should be unused now and can be removed.,Why is this test ig
+5383,"@@ -231,4 +231,12 @@ final class MultiTermQueryConstantScoreWrapper<Q extends MultiTermQuery> extends
+ 
+     };
+   }
++
++  @Override
++  public void visit(QueryVisitor visitor) {
++    QueryVisitor v = visitor.getSubVisitor(Occur.FILTER, this);
++    if (v != null) {
++      query.visit(v);
++    }
++  }
+ }",redundant null check?,Why is this needed?
+5384,"@@ -11,5 +11,5 @@ func NewRAMDevice() (*sonm.RAMDevice, error) {
+ 		return nil, err
+ 	}
+ 
+-	return &sonm.RAMDevice{Total: m.Total}, err
++	return &sonm.RAMDevice{Total: m.Total, Available: m.Total}, err
+ }",initialization of available ram is here,Shouldn't this be `Available`?
+5385,"@@ -603,8 +603,12 @@ Blockly.Field.prototype.getDisplayText_ = function() {
+   // Replace whitespace with non-breaking spaces so the text doesn't collapse.
+   text = text.replace(/\s/g, Blockly.Field.NBSP);
+   if (this.sourceBlock_.RTL) {
+-    // The SVG is LTR, force text to be RTL.
+-    text += '\u200F';
++    // The SVG is LTR, force text to be RTL unless a number.
++    if (this.sourceBlock_.editable_ && this.sourceBlock_.type === 'math_number') {
++      text += '\u200E';
++    } else {
++      text = '\u202B' + text + '\u202C';
++    }
+   }
+   return text;
+ };",Can have negative numbers with the '-' on the right (`10-`) by just using line 610.,Why do we need to special case
+5386,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteUser.java demonstrates how to delete an AWS Identity and Access Management (IAM) user. This is only possible for users with no associated resources.]
++//snippet-sourcedescription:[DeleteUser.java demonstrates how to delete an AWS Identity and Access Management (AWS IAM) user. This is only possible for users with no associated resources.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I'm not sure if this is a typo
+5387,"@@ -2381,11 +2381,10 @@ class ThriftRequestHandler(object):
+                 check_commands, check_durations, cc_version, statistics = \
+                     store_handler.metadata_info(metadata_file)
+ 
+-                if len(check_commands) == 0:
+-                    command = ' '.join(sys.argv)
+-                elif len(check_commands) == 1:
++                command = ''
++                if len(check_commands) == 1:
+                     command = ' '.join(check_commands[0])
+-                else:
++                elif len(check_commands) > 1:
+                     command = ""multiple analyze calls: "" + \
+                               '; '.join([' '.join(com)
+                                          for com in check_commands])",Shouldn't we use store a message which indicates that there was no available checker command? By the way how is it possible that metadata.json doesn't contain the checker command? Maybe this was the case in the earlier versions?,Why this change?
+5388,"@@ -32,6 +32,10 @@ module RSpec
+         @exclusion_patterns = true_or_false ? [] : DEFAULT_EXCLUSION_PATTERNS.dup
+       end
+ 
++      def full_backtrace
++        @exclusion_patterns.empty?
++      end
++
+       private
+ 
+       def matches_an_exclusion_pattern?(line)","Given that this is a boolean predicate, maybe it should be `full_backtrace?`.",Why do we need this method?
+5389,"@@ -12,7 +12,9 @@ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.""""""
+ 
+-import ldap, traceback
++import traceback
++
++import ldap
+ from django.conf import settings
+ from django.contrib.auth.models import User
+ ",Just curious why the blank line here?,Why did you change this?
+5390,"@@ -1,3 +1,3 @@
+ from __future__ import (absolute_import, print_function, division)
+ 
+-from netlib.version import *
++from mitmproxy.version import *","I like the idea, but we don't want a dependency on mitmproxy in pathod.",Why this change?
+5391,"@@ -49,6 +49,16 @@ namespace Datadog.Trace
+ 
+         private TimeSpan Elapsed => StopwatchHelpers.GetElapsed(Stopwatch.GetTimestamp() - _timestamp);
+ 
++        /// <summary>
++        /// Gets or sets a collection of propagated internal Datadog tags,
++        /// formatted as ""key1=value1,key2=value2"".
++        /// </summary>
++        /// <remarks>
++        /// We're keeping this as the string representation to avoid having to parse.
++        /// For now, it's relatively easy to append new values when needed.
++        /// </remarks>
++        public string DatadogTags { get; set; }
++
+         public void AddSpan(Span span)
+         {
+             lock (this)",Why not adding this to the interface and keep passing the interface (as the interface is internal I don't get why you're not adding it there),I think this should be a `D
+5392,"@@ -70,6 +70,7 @@ from typing import Pattern, Tuple
+ 
+ import astroid
+ from astroid import nodes
++from astroid.const import PY310_PLUS
+ 
+ from pylint.checkers import BaseChecker, utils
+ from pylint.checkers.utils import (",`PY310` should probably be imported from `pylint.const`,from __future__ import absolute_import
+5393,"@@ -37,6 +37,14 @@ func (w workflowLoggable) GetValue(key string) string {
+ 	return w.wf.GetSerialConsoleOutputValue(key)
+ }
+ 
++func (w workflowLoggable) GetValueAsBool(key string) bool {
++	v, err := strconv.ParseBool(w.wf.GetSerialConsoleOutputValue(key))
++	if err != nil {
++		return false
++	}
++	return v
++}
++
+ func (w workflowLoggable) GetValueAsInt64Slice(key string) []int64 {
+ 	return getInt64Values(w.wf.GetSerialConsoleOutputValue(key))
+ }",Can we propagate this error up the stack?,I don't think we need this function.
+5394,"@@ -83,7 +83,12 @@ public:
+                              const table& result_values) {
+         auto reference = compute_reference(sigma, x_data, y_data);
+         const double tol = te::get_tolerance<Float>(1e-4, 1e-9);
+-        const double diff = la::l_inf_norm(reference, la::matrix<double>::wrap(result_values));
++        const table reference_table = dal::detail::homogen_table_builder{}
++                                          .reset(reference.get_array(),
++                                                 reference.get_row_count(),
++                                                 reference.get_column_count())
++                                          .build();
++        const double diff = te::abs_error(reference_table, result_values);
+         CHECK(diff < tol);
+     }
+ ",Why reference is converted to table?,Why is this necessary?
+5395,"@@ -203,16 +203,15 @@ struct roots_view *view_at(struct roots_desktop *desktop, double lx, double ly,
+ struct roots_desktop *desktop_create(struct roots_server *server,
+ 		struct roots_config *config) {
+ 	struct roots_desktop *desktop = calloc(1, sizeof(struct roots_desktop));
++	assert(desktop);
+ 	wlr_log(L_DEBUG, ""Initializing roots desktop"");
+ 
+ 	assert(desktop->views = list_create());
+ 	wl_list_init(&desktop->outputs);
+-	wl_list_init(&desktop->output_add.link);
+-	desktop->output_add.notify = output_add_notify;
+-	wl_list_init(&desktop->output_remove.link);
+-	desktop->output_remove.notify = output_remove_notify;
+ 
++	desktop->output_add.notify = output_add_notify;
+ 	wl_signal_add(&server->backend->events.output_add, &desktop->output_add);
++	desktop->output_remove.notify = output_remove_notify;
+ 	wl_signal_add(&server->backend->events.output_remove,
+ 		&desktop->output_remove);
+ ",You shouldn't use assert for runtime errors.,Why did you remove this line?
+5396,"@@ -15,6 +15,7 @@ return array(
+         'vendor/bootstrap.min.js',
+         'vendor/bootstrap-accessibility.min.js',
+         'vendor/validator.min.js',
++        'vendor/form-attr-polyfill.js', // input[form] polyfill, cannot load conditionally, since we need all versions of IE
+         'autocomplete.js',
+         'common.js',
+         'lightbox.js',","Does this really belong in the vendor directory if you wrote it? At very least, should it get its own repo somewhere in addition to being dropped here?",I don't think this is the right place to add this polyfill. I think it should be at the top of the list.
+5397,"@@ -78,7 +78,7 @@ public class PMDTaskTest {
+             String actual = IOUtils.toString(in, StandardCharsets.UTF_8);
+             // remove any trailing newline
+             actual = actual.replaceAll(""\n|\r"", """");
+-            Assert.assertEquals(""sample.dummy:0:\tTest Rule 2"", actual);
++            Assert.assertEquals(""sample.dummy:0:\tTest Rule 2:\tSampleXPathRule"", actual);
+         }
+     }
+ }",I think it would be better to place the rule name before the message. Messages are of varying lengths and the rule names will end up misaligned,Why is this change needed?
+5398,"@@ -1719,7 +1719,12 @@ class ComparisonChecker(_BasicChecker):
+                       'Used when comparing an object to a literal, which is usually '
+                       'what you do not want to do, since you can compare to a different '
+                       'literal than what was expected altogether.'),
+-           }
++            'R0124': ('Logical tautology in comparison - %s',
++                      'logical-tautology',
++                      'Used when something is compared against itself.',
++                      ),
++
++            }
+ 
+     def _check_singleton_comparison(self, singleton, root_node, negative_check=False):
+         if singleton.value is True:",Can we remove the argument from this message? A message will include a line number already that points to the place in the code that has the problem. I think we can remove it.,I don't think this should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I think i
+5399,"@@ -174,7 +174,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal
+             _requestBodyMinimumDataRateNotSatisfied(_logger, connectionId, traceIdentifier, rate, null);
+         }
+ 
+-        public void ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)
++        public virtual void ResponseMininumDataRateNotSatisfied(string connectionId, string traceIdentifier)
+         {
+             _responseMinimumDataRateNotSatisfied(_logger, connectionId, traceIdentifier, null);
+         }","This whole class is now a mix of virtual and non-virtual. I tried to see what would happen if I made everything non-virtual in dev, and the build still passes. It turns out that none of the other methods actually need to be virtual. Can you make *all* the logging methods either virtual or not for consistency? Thanks.",Why is this virtual?
+5400,"@@ -58,6 +58,12 @@ var (
+ 		Value: metadata.DefaultNetwork.AccessPolicyOracleAddress,
+ 	})
+ 
++	mmnAddressFlag = altsrc.NewStringFlag(cli.StringFlag{
++		Name:  ""mmn-address"",
++		Usage: ""URL of my.mysterium.network API"",
++		Value: metadata.DefaultNetwork.MMNAddress,
++	})
++
+ 	brokerAddressFlag = altsrc.NewStringFlag(cli.StringFlag{
+ 		Name:  ""broker-address"",
+ 		Usage: ""URI of message broker"",","This looks a bit cryptic to me, and also it contains a dash. How about `mymysterium.url`?",This should be `my.mysterium.network API`
+5401,"@@ -0,0 +1,8 @@
++#include<stdio.h>
++
++void main(){
++	int var = 100;
++	if (&var == 0){
++		print(""Got the value"");
++	}
++}","You did notice the no newline at the end of this file, right?",Add a new line at the EOF
+5402,"@@ -75,10 +75,10 @@ namespace Microsoft.CodeAnalysis.Sarif
+         public ISet<Stack> Stacks { get; set; }
+ 
+         /// <summary>
+-        /// An array of arrays of 'annotatedCodeLocation` objects, each inner array of which comprises a code flow (a possible execution path through the code).
++        /// An array of 'codeFlow' objects relevant to the result.
+         /// </summary>
+         [DataMember(Name = ""codeFlows"", IsRequired = false, EmitDefaultValue = false)]
+-        public IList<IList<AnnotatedCodeLocation>> CodeFlows { get; set; }
++        public ISet<CodeFlow> CodeFlows { get; set; }
+ 
+         /// <summary>
+         /// A grouped set of locations and messages, if available, that represent code areas that are related to this result.","Here's the object model change. `CodeFlows` is a set of objects of type `CodeFlow`, rather than a list of list of `AnnotatedCodeLocation`. Exactly parallel with `Stacks`.",">CodeFlow [](start = 28, length = 9) Code"
+5403,"@@ -31,6 +31,7 @@ from .core import decode_node, encode_node, find_object_hashes, hash_contents, F
+ from .models import (Access, Customer, Instance, Invitation, Log, Package,
+                      S3Blob, Tag, UTF8_GENERAL_CI, Version)
+ from .schemas import LOG_SCHEMA, PACKAGE_SCHEMA
++from .config import BAN_PUBLIC_USERS
+ 
+ QUILT_CDN = 'https://cdn.quiltdata.com/'
+ ","Sorry, one more thing... You should use `app.config` instead of importing it directly. See the code below.",I don't think this is used anywhere.
+5404,"@@ -44,8 +44,13 @@ public interface VectorizedReader<T> {
+   void setRowGroupInfo(PageReadStore pages, Map<ColumnPath, ColumnChunkMetaData> metadata);
+ 
+   /**
+-   * Set up the reader to reuse the underlying containers used for storing batches
++   * Setup the reader to reuse the underlying containers used for storing batches
+    */
+   void reuseContainers(boolean reuse);
++
++  /**
++   * Release any resources allocated
++   */
++  void close();
+ }
+ ","This was correct before; ""setup"" is a noun and ""set up"" is the verb form.",Why do we need this?
+5405,"@@ -61,7 +61,7 @@ class AdSenseSetupWidget extends Component {
+ 
+ 	async getAccounts() {
+ 		try {
+-			const responseData = await data.get( TYPE_MODULES, 'adsense', 'accounts' );
++			const responseData = await data.get( TYPE_MODULES, 'adsense', 'accounts', { maybeSetAccount: true } );
+ 
+ 			/**
+ 			 * Defines the account status. Possible values:",What's the reason for this change here? I didn't see it mentioned in the PR and it's a bit of a confusing param name  ,Why do we need the `
+5406,"@@ -12,7 +12,9 @@ function Search() {
+ }
+ 
+ Search.prototype.query = function(q) {
+-  return this.index.search(q)
++	return q === '~'
++		? this.storage.config.localList.get().map( function( package ){ return { ref: package, score: 1 }; } )
++		: this.index.search(q);
+ }
+ 
+ Search.prototype.add = function(package) {",I wonder why ~ and not a wildcard instead?,I think this should 
+5407,"@@ -63,6 +63,9 @@ public class PojoProducers implements BeanPostProcessor {
+     // aop后，新的实例的父类可能是原class，也可能只是个proxy，父类不是原class
+     // 所以，需要先取出原class，再取标注
+     Class<?> beanCls = BeanUtils.getImplClassFromBean(bean);
++    if(beanCls == null) {
++    	return;
++    }
+     RpcSchema rpcSchema = beanCls.getAnnotation(RpcSchema.class);
+     if (rpcSchema == null) {
+       return;","when will this happened? if happened, just ignore it Silently?",please add a space a
+5408,"@@ -239,8 +239,10 @@ public class TestMergeAppend extends TableTestBase {
+   public void testManifestMergeMinCount() throws IOException {
+     Assert.assertEquals(""Table should start empty"", 0, listManifestFiles().size());
+     table.updateProperties().set(TableProperties.MANIFEST_MIN_MERGE_COUNT, ""2"")
+-        // each manifest file is 5227 bytes, so 12000 bytes limit will give us 2 bins with 3 manifest/data files.
+-        .set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, ""12000"")
++        // Each initial v1/v2 ManifestFile is 5661/6397 bytes respectively. Merging two of the given
++        // manifests make one v1/v2 ManifestFile of 5672/6408 bytes respectively, so 12850 bytes
++        // limit will give us two bins with three manifest/data files.
++        .set(TableProperties.MANIFEST_TARGET_SIZE_BYTES, ""12850"")
+         .commit();
+ 
+     TableMetadata base = readMetadata();","3x the smaller size would be around 17k, and we need it to be at least about 13k, which is 2x the larger size. I'd probably set this to 15k to split the difference and hopefully avoid needing to update this again as tests change. This is minor, though.","nit: ""make one"" -> ""make one"""
+5409,"@@ -360,7 +360,9 @@ class DateEncoder(Encoder):
+     if input == SENTINEL_VALUE_FOR_MISSING_DATA:
+       output[0:] = 0
+     else:
+-      assert isinstance(input, datetime.datetime)
++      assert isinstance(input, datetime.datetime), (
++          ""Input is type %s, expected datetime. Value: %s"" % (type(input),
++                                                              str(input)))
+ 
+       # Get the scalar values for each sub-field
+       scalars = self.getScalars(input)","@scottpurdy, strictly speaking, should this scenario raise a ValueError exception instead of AssertionError?",I don't think you need the `s
+5410,"@@ -0,0 +1,7 @@
++package azkaban.spi;
++
++public enum ExecutorType {
++  // Type of executor where flow runs
++  BAREMETAL,
++  KUBERNETES
++}",Can you please add open source disclaimer?,"nit: typo in ""where"""
+5411,"@@ -81,13 +81,11 @@ func (u *unaryHandler) Handle(ctx context.Context, transportRequest *transport.R
+ 	var wireError *wirepb.Error
+ 	if appErr != nil {
+ 		responseWriter.SetApplicationError()
+-		wireError = &wirepb.Error{
+-			appErr.Error(),
+-		}
++		wireError = &wirepb.Error{Message: appErr.Error()}
+ 	}
+ 	wireResponse := &wirepb.Response{
+-		responseData,
+-		wireError,
++		Payload: responseData,
++		Error:   wireError,
+ 	}
+ 	protoBuffer := getBuffer()
+ 	defer putBuffer(protoBuffer)",I dont want to do composite keys on purpose to verify at compile time if the message is completely filled out appropriately @sectioneight,Why do we need this change?
+5412,"@@ -1170,6 +1170,8 @@ func TestServer_SendAction(t *testing.T) {
+ 	}}
+ 
+ 	chain.EXPECT().ChainID().Return(uint32(1)).Times(2)
++	chain.EXPECT().TipHeight().Return(uint64(4)).Times(2)
++	svr.cfg.Genesis.KamchatkaBlockHeight = 10
+ 	ap.EXPECT().Add(gomock.Any(), gomock.Any()).Return(nil).Times(2)
+ 
+ 	for i, test := range sendActionTests {","don't need this line, since it is not tested in api_test?",Why is this needed?
+5413,"@@ -164,7 +164,7 @@ func CheckForCStorPoolCRD(clientset clientset.Interface) {
+ // CheckForCStorVolumeReplicaCRD is Blocking call for checking status of CStorVolumeReplica CRD.
+ func CheckForCStorVolumeReplicaCRD(clientset clientset.Interface) {
+ 	for {
+-		_, err := clientset.OpenebsV1alpha1().CStorVolumeReplicas().List(metav1.ListOptions{})
++		_, err := clientset.OpenebsV1alpha1().CStorVolumeReplicas("""").List(metav1.ListOptions{})
+ 		if err != nil {
+ 			glog.Errorf(""CStorVolumeReplica CRD not found. Retrying after %v"", CRDRetryInterval)
+ 			time.Sleep(CRDRetryInterval)",Does this mean the list operation is done for all the namespaces? How to list the volume replicas per namespace?,Why do we need this
+5414,"@@ -136,10 +136,14 @@ def batched_nms(bboxes, scores, inds, nms_cfg):
+     Returns:
+         tuple: kept bboxes and indice.
+     """"""
+-    max_coordinate = bboxes.max()
+-    offsets = inds.to(bboxes) * (max_coordinate + 1)
+-    bboxes_for_nms = bboxes + offsets[:, None]
+     nms_cfg_ = nms_cfg.copy()
++    class_agnostic = nms_cfg_.pop('class_agnostic', False)
++    if not class_agnostic:
++        max_coordinate = bboxes.max()
++        offsets = inds.to(bboxes) * (max_coordinate + 1)
++        bboxes_for_nms = bboxes + offsets[:, None]
++    else:
++        bboxes_for_nms = bboxes
+     nms_type = nms_cfg_.pop('type', 'nms')
+     nms_op = eval(nms_type)
+     dets, keep = nms_op(","I suggest adding `class_agnostic` as an argument of `batched_nms()`, with the default value False.",Why do we need this
+5415,"@@ -44,6 +44,7 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 101, ""file_path"", Types.StringType.get(), ""Path of a file in which a deleted row is stored"");
+   public static final NestedField DELETE_FILE_POS = NestedField.required(
+       Integer.MAX_VALUE - 102, ""pos"", Types.LongType.get(), ""Ordinal position of a deleted row in the data file"");
++  public static final String DELETE_FILE_ROW_FIELD_NAME = ""row"";
+   public static final int DELETE_FILE_ROW_FIELD_ID = Integer.MAX_VALUE - 103;
+   public static final String DELETE_FILE_ROW_DOC = ""Deleted row values"";
+ ","@rdblue, did we not add the name on purpose?",I think this should
+5416,"@@ -41,12 +41,12 @@ import org.apache.orc.TypeDescription;
+  */
+ public final class ORCSchemaUtil {
+ 
+-  private enum BinaryType {
++  public enum BinaryType {
+     UUID, FIXED, BINARY
+   }
+ 
+-  private enum IntegerType {
+-    TIME, INTEGER
++  public enum LongType {
++    TIME, LONG
+   }
+ 
+   private static class OrcField {",Why is this now public?,Why do we need to change this?
+5417,"@@ -111,9 +111,7 @@ module Blacklight::SearchContext
+       response, documents = search_service.previous_and_next_documents_for_search index, search_state.reset(current_search_session.query_params).to_hash
+ 
+       search_session['total'] = response.total
+-      @search_context_response = response
+-      @previous_document = documents.first
+-      @next_document = documents.last
++      { prev: documents.first, next: documents.last }
+     end
+   rescue Blacklight::Exceptions::InvalidRequest => e
+     logger.warn ""Unable to setup next and previous documents: #{e}""",I guess we should backport some deprecation for this?,I'm not sure if this is the ri
+5418,"@@ -57,11 +57,10 @@ module Selenium
+               is_relative = Regexp.last_match(1).strip == '1'
+             when /^Path=(.+)$/
+               path = Regexp.last_match(1).strip
++              p = path_for(name, is_relative, path)
++              @profile_paths[name] = p if p
+             end
+           end
+-
+-          p = path_for(name, is_relative, path)
+-          @profile_paths[name] = p if p
+         end
+ 
+         def path_for(name, is_relative, path)",Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?,Why did you remove this line?
+5419,"@@ -105,6 +105,7 @@ static byte buf[8192];
+ #define IMMARG(sz) opnd_create_immed_int(37, sz)
+ #define TGTARG opnd_create_instr(instrlist_last(ilist))
+ #define REGARG(reg) opnd_create_reg(REG_##reg)
++#define DR_REGARG(reg) opnd_create_reg(DR_REG_##reg)
+ #define REGARG_PARTIAL(reg, sz) opnd_create_reg_partial(REG_##reg, sz)
+ #define VSIBX(sz) (opnd_create_base_disp(REG_XCX, REG_XMM6, 2, 0x42, sz))
+ #define VSIBY(sz) (opnd_create_base_disp(REG_XDX, REG_YMM6, 2, 0x17, sz))",I would say just change REGARG: no need for a separate thing.,Why is this needed?
+5420,"@@ -0,0 +1,18 @@
++<!DOCTYPE html>
++<html>
++<head>
++  <title>C2</title>
++  <meta name=""viewport"" content=""width=device-width""/>
++  <meta http-equiv=""Content-Type"" content=""text/html; charset=utf-8""/>
++  <link rel=""stylesheet"" type=""text/css"" href=""<%= stylesheet_url(""mailer.css"") %>"">
++</head>
++<body class=""c2-notification"">
++  <%= yield %>
++  <hr>
++  <div id=""footer"" class=""inset"">
++    <p>
++    <%= t(""mailer.feedback_footer_html"", feedback_url: feedback_url) %>
++    </p>
++  </div>
++</body>
++</html>","we can remove this template, it is no longer in use","This should be `<%= t(""mailer.feedback_footer_html"") %>`"
+5421,"@@ -45,11 +45,9 @@ module Beaker
+       end
+ 
+       it ""recursively dumps values"" do
+-        options.merge({'k' => 'v', 'key' => {'subkey' => 'subvalue'}, 'array_key' => ['array1', 'array2'], 'array_key2' => [['subarray1', 'subarray2'], 'anotherval']})
+-        expect(options.dump).to be === ""Options:\n\t\tk : v\n\t\tkey : \n\t\t\tsubkey : subvalue\n\t\tarray_key : \n\t\t\t[\n\t\t\tarray1,\n\t\t\tarray2,\n\t\t\t]\n\t\tarray_key2 : \n\t\t\t[\n\t\t\t[\n\t\t\tsubarray1,\n\t\t\tsubarray2,\n\t\t\t]\n\t\t\tanotherval,\n\t\t\t]\n""
+-        
++        options.merge({'k' => { 'key' => {'subkey' => 'subvalue'}}})
++        expect(options.dump).to be === ""Options:\n\t\tk : \n\t\t\tkey : \n\t\t\t\tsubkey : subvalue\n""
+       end
+-
+     end
+   end
+ end",This doesn't look like it has as much coverage of the recursive code as it once did.,Why did you remove this test?
+5422,"@@ -107,6 +107,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Defaults to false.
+ 	// +optional
+ 	CrossZoneLoadBalancing bool `json:""crossZoneLoadBalancing,omitempty""`
++
++	// SecurityGroups sets the security groups used by the load balancer
++	// +optional
++	SecurityGroups []SecurityGroup `json:""securityGroups,omitempty""`
+ }
+ 
+ // AWSClusterStatus defines the observed state of AWSCluster","Do we actually expect users to provide more information here than possibly a SecurityGroup ID? If not, then this should probably use a new type, otherwise users might be confused by what options would be respected/ignored when used in this context.",I think this should be `// +optional`
+5423,"@@ -1,6 +1,8 @@
+ package edu.harvard.iq.dataverse.util;
+ 
+ import com.ocpsoft.pretty.PrettyContext;
++import com.rometools.utils.Strings;
++
+ import edu.harvard.iq.dataverse.DataFile;
+ import edu.harvard.iq.dataverse.Dataset;
+ import edu.harvard.iq.dataverse.Dataverse;",This seems like a new dependency on rometools. Do we need it?,why is this needed?
+5424,"@@ -93,7 +93,7 @@ public class Docker {
+       throw new WebDriverException(""Unable to pull container: "" + name);
+     }
+ 
+-    LOG.info(String.format(""Pull of %s:%s complete"", name, tag));
++    LOG.fine(String.format(""Pull of %s:%s complete"", name, tag));
+ 
+     return findImage(new ImageNamePredicate(name, tag))
+         .orElseThrow(() -> new DockerException(",Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.,Why is this change needed?
+5425,"@@ -7,13 +7,12 @@ import (
+ 	""sync/atomic""
+ 	""testing""
+ 
++	""github.com/sirupsen/logrus/hooks/test""
+ 	""github.com/stretchr/testify/require""
+ 
+ 	""github.com/spiffe/spire/pkg/common/util""
+ 	""github.com/spiffe/spire/pkg/server/plugin/datastore""
+ 	""github.com/spiffe/spire/pkg/server/plugin/datastore/sql""
+-	spi ""github.com/spiffe/spire/proto/spire/common/plugin""
+-	""github.com/spiffe/spire/test/spiretest""
+ )
+ 
+ var (","I can not think in a good use for it, but may we allow a way to setup a fake with a hook for logs? this fake is special, and we may need access to some of thoe logs, at the same time it may be an overkill because we dont want to test ""sql"" implementation but results.. but we can create some tests with end to end logs in some scenaries, What do you think about it?",Why is this being removed?
+5426,"@@ -149,6 +149,10 @@ void dag_close_over_environment(struct dag *d)
+ 			{
+ 				dag_variable_add_value(name, d->default_category->mf_variables, 0, value_env);
+ 			}
++
++			if(!value_env && !strcmp(name, RESOURCES_CORES)) {
++				dag_variable_add_value(name, d->default_category->mf_variables, 0, ""1"");
++			}
+ 		}
+ 	}
+ ","I don't think you should be changing the dag unilaterally at parse time. If cores isn't specified, then it isn't specified.",Why do we need this?
+5427,"@@ -26,6 +26,16 @@
+ // see URLOpener.
+ // See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
++// Message Delivery Semantics
++//
++// Azure ServiceBus supports at-least-once semantics in the default Peek-Lock
++// mode; applications must call Message.Ack/Nack after processing a message, or
++// it will be redelivered. However, it also supports a Receive-Delete mode,
++// which essentially auto-acks a message when it is delivered, resulting in
++// at-most-once semantics. See SubscriberOptions.AckFuncForReceiveAndDelete.
++// See https://godoc.org/gocloud.dev/pubsub#hdr-At_most_once_and_At_least_once_Delivery
++// for more background.
++//
+ // As
+ //
+ // azuresb exposes the following types for As:","Instead of just ""See SubscriberOptions...."", say something like ""Use ... to choose between the two.""",nit: `Receive-Delete` -> `
+5428,"@@ -0,0 +1,10 @@
++import argparse
++from rdkit import Chem
++sdf = Chem.SDMolSupplier(""cdk2.sdf"")
++f = open(""cdk2.smi"",""w"")
++for mol in sdf:
++    name = mol.GetProp(""_Name"")
++    smi = Chem.MolToSmiles( mol )
++    f.write( ""{}\t{}\n"".format(name,smi))
++f.close()
++",Use with statement for `f`,This file should be named `cdk2.smi.py`.
+5429,"@@ -426,3 +426,16 @@ TEST_F(BadPonyTest, AnnotatedIfClause)
+ 
+   TEST_COMPILE(src);
+ }
++
++TEST_F(BadPonyTest, CapSubtypeInConstrainSubtyping)
++{
++  // From PR #1816
++  const char* src =
++    ""trait T\n""
++    ""  fun alias[X: Any iso](x: X!) : X^\n""
++    ""class C is T\n""
++    ""  fun alias[X: Any tag](x: X!) : X^ => x\n"";
++
++  TEST_ERRORS_1(src,
++    ""type parameter constraint Any tag is not a supertype of Any iso"");
++}","It's a small style point, but could you remove the ""extra"" space before the colon that precedes the return type? This would make it more closely match the prevailing style in these tests and in the standard libraries.",Why is this test failing?
+5430,"@@ -594,6 +594,13 @@ func (md *MDOpsStandard) PruneBranch(
+ 	return md.config.MDServer().PruneBranch(ctx, id, bid)
+ }
+ 
++// ResolveBranch implements the MDOps interface for MDOpsStandard.
++func (md *MDOpsStandard) ResolveBranch(
++	ctx context.Context, id TlfID, bid BranchID,
++	blocksToDelete []BlockID, rmd *RootMetadata) (MdID, error) {
++	return MdID{}, errors.New(""ResolveBranch not supported by MDOpsStandard"")
++}
++
+ // GetLatestHandleForTLF implements the MDOps interface for MDOpsStandard.
+ func (md *MDOpsStandard) GetLatestHandleForTLF(ctx context.Context, id TlfID) (
+ 	BareTlfHandle, error) {","seems clunky to me to have an `MDOps` interface method that some implementations don't implement. Perhaps define a separate interface, like, `BranchResolver`, and then callers that have an `MDOps` object can check via type assertion?",Why not return an error here?
+5431,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+ 
+ 
+   /**",This change should also probably go into the corresponding method of the abstract By class?,Why do we need this change?
+5432,"@@ -42,6 +42,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/test/mock/mock_dispatcher""
+ 	ta ""github.com/iotexproject/iotex-core/test/testaddress""
+ 	""github.com/iotexproject/iotex-core/testutil""
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ )
+ 
+ const (",File is not `gofmt`-ed with `-s` (from `gofmt`),nit: remove empty line
+5433,"@@ -82,9 +82,9 @@ func (fsrv *FileServer) serveBrowse(dirPath string, w http.ResponseWriter, r *ht
+ 		w.Header().Set(""Content-Type"", ""text/html; charset=utf-8"")
+ 	}
+ 
+-	buf.WriteTo(w)
++	_, err = buf.WriteTo(w)
+ 
+-	return nil
++	return err
+ }
+ 
+ func (fsrv *FileServer) loadDirectoryContents(dir *os.File, urlPath string, repl *caddy.Replacer) (browseListing, error) {","This is likely to return an error value if the client fails to read the response we write, which is why I chose to ignore this error.",This should be `return
+5434,"@@ -649,6 +649,9 @@ class Channel(AbstractChannel):
+     def is_static_remotekey_enabled(self) -> bool:
+         return bool(self.storage.get('static_remotekey_enabled'))
+ 
++    def is_upfront_shutdown_script_enabled(self) -> bool:
++        return bool(self.storage.get('upfront_shutdown_script_enabled'))
++
+     def get_wallet_addresses_channel_might_want_reserved(self) -> Sequence[str]:
+         ret = []
+         if self.is_static_remotekey_enabled():",this method is not used,I think this should be
+5435,"@@ -1016,7 +1016,15 @@ class AbstractTab(QWidget):
+             return
+ 
+         sess_manager.save_autosave()
++        self.load_finished.emit(ok)
++
++        if not self.title():
++            self.title_changed.emit(self.url().toDisplayString())
+ 
++        self.zoom.reapply()
++
++    def _update_load_status(self, ok: bool) -> None:
++        """"""Update the load status after a page finished loading.""""""
+         if ok and not self._has_ssl_errors:
+             if self.url().scheme() == 'https':
+                 self._set_load_status(usertypes.LoadStatus.success_https)","Right now it's a bit unclear that this needs to be called explicitly by the implementing class. If, for example, there's another backend, it won't get this update unless we add the same function as webkit. Could you either add a note to this docstring explaining that this needs to be called, or find some way to automatically trigger this so the webkit override isn't needed (and some override passed on webengine).",Why do we need this?
+5436,"@@ -162,7 +162,7 @@ var xdpTestCases = []xdpTest{
+ 			SrcPort: 54321,
+ 		},
+ 		Drop:     false,
+-		Metadata: true,
++		Metadata: false,
+ 	},
+ 	{
+ 		Description: ""6 - Match against a deny policy, must drop"",","Why this change (test name still says ""must pass with metadata"")?",Why did you change this?
+5437,"@@ -45,7 +45,8 @@ module Travis
+           end
+ 
+           def ruby_version
+-            config[:rvm].to_s.gsub(/-(1[89]|2[01])mode$/, '-d\1')
++            vers = config[:rvm].to_s.gsub(/-(1[89]|2[01])mode$/, '-d\1')
++            force_187_p371 vers
+           end
+ 
+           def setup_rvm",Another nitpick: parens around the arg pretty please,I think this should be `
+5438,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+ 
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)",Why was this removed?
+5439,"@@ -877,3 +877,7 @@ type CtxKey string
+ // context.WithValue to access the original request URI that accompanied the
+ // server request. The associated value will be of type string.
+ const URLPathCtxKey CtxKey = ""url_path""
++
++// URIxRewriteCtxKey is a context key used to store original unrewritten
++// URI in context.WithValue
++const URIxRewriteCtxKey CtxKey = ""caddy_rewrite_original_uri""","Oh, I guess I mentioned/pressed this point in the other issue, that this should probably go into the httpserver package. In fact, so should the const above this (URLPathCtxKey). These are specific to the HTTP server.",I think this should be `
+5440,"@@ -41,7 +41,7 @@ type ValidationFunc func(certificate *cmapi.Certificate, secret *corev1.Secret)
+ 
+ // ExpectValidKeysInSecret checks that the secret contains valid keys
+ func ExpectValidKeysInSecret(_ *cmapi.Certificate, secret *corev1.Secret) error {
+-	validKeys := [5]string{corev1.TLSPrivateKeyKey, corev1.TLSCertKey, cmmeta.TLSCAKey, cmapi.AdditionalOutputFormatDERKey, cmapi.AdditionalOutputFormatPEMKey}
++	validKeys := [5]string{corev1.TLSPrivateKeyKey, corev1.TLSCertKey, cmmeta.TLSCAKey, cmapi.CertificateOutputFormatDERKey, cmapi.CertificateOutputFormatCombinedPEMKey}
+ 	nbValidKeys := 0
+ 	for k := range secret.Data {
+ 		for _, k2 := range validKeys {","Not added by you, but we don't really need the '5' here..",I don't think we need the `CombinedPEMKey` here. The `AdditionalOutputFormatPEMKey` should be enough.
+5441,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+ 
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?,Why was this removed?
+5442,"@@ -36,6 +36,7 @@ def _makeKbEmulateScript(scriptName):
+ 		# __name__ must be str; i.e. can't be unicode.
+ 		scriptName = scriptName.encode(""mbcs"")
+ 	func.__name__ = ""script_%s"" % scriptName
++	func.emuGesture = emuGesture
+ 	func.__doc__ = _(""Emulates pressing %s on the system keyboard"") % emuGesture.displayName
+ 	return func
+ ",I don't think this is needed anymore?,Why is this needed?
+5443,"@@ -91,8 +91,15 @@ func (s *Service) ListAgents(ctx context.Context, req *agentv1.ListAgentsRequest
+ 	// Parse proto filter into datastore request
+ 	if req.Filter != nil {
+ 		filter := req.Filter
++
++		// TODO should this be a helper function?
++		var byBanned *bool
++		if filter.ByBanned != nil {
++			byBanned = &filter.ByBanned.Value
++		}
++
+ 		listReq.ByAttestationType = filter.ByAttestationType
+-		listReq.ByBanned = filter.ByBanned
++		listReq.ByBanned = byBanned
+ 
+ 		if filter.BySelectorMatch != nil {
+ 			selectors, err := api.SelectorsFromProto(filter.BySelectorMatch.Selectors)",This is the only occurrence I see in the code where we now need to convert from a boolean protobuf wrapper to a boolean pointer. This felt a little cumbersome here; should we consider moving it somewhere else as a helper function?,I don't think this is a helper function.
+5444,"@@ -46,9 +46,6 @@ void HBProcessor::process(const cpp2::HBReq& req) {
+   }
+ 
+   HostInfo info(time::WallClock::fastNowInMilliSec(), req.get_role(), req.get_git_info_sha());
+-  if (req.version_ref().has_value()) {
+-    info.version_ = *req.version_ref();
+-  }
+   if (req.leader_partIds_ref().has_value()) {
+     ret = ActiveHostsMan::updateHostInfo(kvstore_, host, info, &*req.leader_partIds_ref());
+   } else {",Need you to delete the `version_` from `HostInfo` struct ?,Why did you remove this?
+5445,"@@ -0,0 +1,5 @@
++const { getBaseLang } = axe.commons.utils;
++const primaryLangValue = getBaseLang(node.getAttribute('lang') || '');
++const primaryXmlLangValue = getBaseLang(node.getAttribute('xml:lang') || '');
++
++return primaryLangValue === primaryXmlLangValue;",This could be the cleanest looking check we've got. Great job Jey.,`getBaseLang(node.getAtt
+5446,"@@ -148,7 +148,7 @@ class Controller
+             $url = Request::path();
+         }
+ 
+-        if (!strlen($url)) {
++        if ('' === $url) {
+             $url = '/';
+         }
+ ","Who invited yoda?   In all seriousness though, wouldn't an `if (empty())` be better here?",Why not `if ('' === $url
+5447,"@@ -1341,7 +1341,7 @@ define(['playbackManager', 'dom', 'inputManager', 'datetime', 'itemHelper', 'med
+                 });
+             } catch (e) {
+                 require(['appRouter'], function(appRouter) {
+-                    appRouter.showDirect('/');
++                    window.location.href = 'index.html';
+                 });
+             }
+         });","You can use `appRouter.goHome` to do this (It's defined in site.js), it's less hacky than overriding the href.",Why do we need this?
+5448,"@@ -101,7 +101,14 @@ bool NebulaStore::init() {
+                             enginePtr->removePart(partId);
+                             continue;
+                         } else {
+-                             partIds.emplace_back(partId);
++                             auto it = std::find(partIds.begin(), partIds.end(), partId);
++                             if (it != partIds.end()) {
++                                LOG(INFO) << ""Part "" << partId
++                                          << "" has been loaded, skip current one, remove it!"";
++                                enginePtr->removePart(partId);
++                             } else {
++                                partIds.emplace_back(partId);
++                             }
+                         }
+                     }
+                     if (partIds.empty()) {",When could this happen?,Why do we need this check?
+5449,"@@ -55,8 +55,7 @@ namespace Datadog.Trace.Agent.Transports
+                 await memoryStream.FlushAsync().ConfigureAwait(false);
+                 memoryStream.Seek(0, SeekOrigin.Begin);
+                 var buffer = memoryStream.GetBuffer();
+-                _headers.Add(""Content-Type"", ""application/json"");
+-                var result = await PostSegmentAsync(new ArraySegment<byte>(buffer, 0, (int)memoryStream.Length)).ConfigureAwait(false);
++                var result = await PostSegmentAsync(new ArraySegment<byte>(buffer, 0, (int)memoryStream.Length), ""application/json"").ConfigureAwait(false);
+                 var response = result.Item1;
+                 var request = result.Item2;
+                 if (response.StatusCode != 200 && response.StatusCode != 202)",I assume this was removed because it was redundant? and conflicted with the now dynamic contentType? Edit: Oh I see it being set was moved to the `PostSegmentAsync` call.,Why did you remove this?
+5450,"@@ -21,7 +21,9 @@ public class ProxyConfig {
+     public static ProxyConfig http(String host, int port, String username, String password) {
+         return new ProxyConfig(Proxy.Type.HTTP, host, port, username, password);
+     }
+-
++    public static ProxyConfig socks(String host, int port, String username, String password) {
++        return new ProxyConfig(Proxy.Type.SOCKS, host, port, username, password);
++    }
+     public ProxyConfig(Proxy.Type type, String host, int port, String username, String password) {
+         this.type = type;
+         this.host = host;",Here is a newline missing,Why do we need this method
+5451,"@@ -126,7 +126,7 @@ module Travis
+ 
+                 # R-devel builds available at mac.r-project.org
+                 if r_version == 'devel'
+-                  r_url = ""https://mac.r-project.org/el-capitan/R-devel/R-devel-el-capitan.pkg""
++                  r_url = ""http://mac.r-project.org/high-sierra/R-4.0-branch/R-4.0-branch.pkg""
+ 
+                 # The latest release is the only one available in /bin/macosx
+                 elsif r_version == r_latest",Did you mean to make this http rather than https?,Line is too long. [83/80]
+5452,"@@ -1,15 +1,14 @@
+ #appModules/audacity.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2010 NVDA Contributors <http://www.nvda-project.org/>
++#Copyright (C) 2006-2018 NVDA Contributors <https://www.nvaccess.org/>
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ 
+ import appModuleHandler
+-import winUser
+ import controlTypes
+ 
+ class AppModule(appModuleHandler.AppModule):
+ 
+ 	def event_NVDAObject_init(self,obj):
+ 		if obj.windowClassName==""Button"" and not obj.role in [controlTypes.ROLE_MENUBAR, controlTypes.ROLE_MENUITEM, controlTypes.ROLE_POPUPMENU]:
+-			obj.name=winUser.getWindowText(obj.windowHandle).replace('&','')
++			obj.name=obj.name.replace('&','')","The updated copyright header should be: # Copyright (C) 2006-2018 NV Access Limited, yourname",Why did you remove the old copyright?
+5453,"@@ -21,6 +21,7 @@ class PerformanceTestSamplesAggregator
+             $maxQueryCount = 0;
+             $isSuccessful = true;
+             $worstStatusCode = null;
++            $performanceTestSample = null;
+ 
+             foreach ($performanceTestSamplesOfUrl as $performanceTestSample) {
+                 /* @var $performanceTestSample \Tests\ShopBundle\Performance\Page\PerformanceTestSample */","wow :+1: , i do not even know how this test works.",Why do we need this variable?
+5454,"@@ -2,14 +2,12 @@
+ // The .NET Foundation licenses this file to you under the MS-PL license.
+ // See the LICENSE file in the project root for more information.
+ 
+-
+-using MvvmCross.Plugins;
+ using MvvmCross.UI;
+ 
+ namespace MvvmCross.Plugin.Visibility.Platform.Uap
+ {
+-    public class Plugin
+-        : IMvxPlugin
++    [MvxPlugin]
++    public class Plugin : IMvxPlugin
+     {
+         public void Load()
+         {",File should be renamed `PlugIn` -> `Plugin`,Why is this needed?
+5455,"@@ -17,6 +17,7 @@ package egress
+ import (
+ 	""context""
+ 	""fmt""
++	""net""
+ 	""testing""
+ 	""time""
+ ",I scanned the new test cases quickly. Do we have one for an egressIPPool with multiple different IP ranges?,nit: remove extra new line
+5456,"@@ -148,6 +148,17 @@ abstract class Abstract_Component implements Component {
+ 		add_action( 'init', [ $this, 'define_settings' ] );
+ 	}
+ 
++	/**
++	 * Method to filter component loading if needed.
++	 *
++	 * @since   1.0.1
++	 * @access public
++	 * @return bool
++	 */
++	public function should_component_be_active() {
++		return true;
++	}
++
+ 	/**
+ 	 * Method to set protected properties for class.
+ 	 *","you can use a different name, like `maybe_activate` or `is_active` without `component` in the method name as this is used in the class name. E.g: `$component->should_component_be_active` is using twice the `component` word",This should be `1.0.2`
+5457,"@@ -114,6 +114,11 @@ class OrderedBulkOperation extends BulkOperationBase {
+    */
+   execute(_writeConcern, options, callback) {
+     const ret = this.bulkExecute(_writeConcern, options, callback);
++
++    if (!(ret && ret.options && ret.callback)) {
++      return ret;
++    }
++
+     options = ret.options;
+     callback = ret.callback;
+ ",I think this might not be a complete enough check: what if `options` is `null`/`undefined`?,Why do we need to chec
+5458,"@@ -0,0 +1,19 @@
++require ""rails_helper""
++
++feature ""Masquerade"" do
++  scenario ""admin masquerades as a user"" do
++    email = ""foo@bar.com""
++    user = create(:user, email: email)
++    admin = create(:user, admin: true)
++
++    sign_in_as(admin)
++    visit admin_users_path
++    click_on(""Masquerade"")
++
++    expect(page).to have_flash(""Now masquerading as #{email}"")
++  end
++
++  def have_flash(text)
++    have_css("".flash"", text: text)
++  end
++end",Useless assignment to variable - `user`.,Extra empty line detec
+5459,"@@ -74,8 +74,8 @@ module Travis
+             sh.echo ""#{release} is not installed. Downloading and installing pre-build binary."", ansi: :yellow
+ 
+             sh.echo ""Downloading archive: ${archive_url}"", ansi: :yellow
+-            sh.cmd ""wget -o ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}""
+-            sh.cmd ""mkdir -p ~/otp && tar -xf #{archive_name(release)} -C ~/otp/"", echo: true
++            sh.cmd ""wget -O ${TRAVIS_HOME}/erlang.tar.bz2 ${archive_url}""
++            sh.cmd ""mkdir -p ~/otp && tar -xf ${TRAVIS_HOME}/erlang.tar.bz2 -C ~/otp/"", echo: true
+             sh.cmd ""mkdir -p ~/.kerl"", echo: true
+             sh.cmd ""echo '#{release},#{release}' >> ~/.kerl/otp_builds"", echo: true
+             sh.cmd ""echo '#{release} ${TRAVIS_HOME}/otp/#{release}' >> ~/.kerl/otp_builds"", echo: true","I think we would want to keep `-O` instead. I wonder how this worked before, though.  ",I think this should be
+5460,"@@ -26,13 +26,17 @@ namespace OpenTelemetry.Metrics
+     internal sealed class AggregatorStore
+     {
+         private static readonly ObjectArrayEqualityComparer ObjectArrayComparer = new ObjectArrayEqualityComparer();
++        private static readonly StringArrayEqualityComparer StringArrayComparer = new StringArrayEqualityComparer();
+         private readonly object lockZeroTags = new object();
+         private readonly HashSet<string> tagKeysInteresting;
+         private readonly int tagsKeysInterestingCount;
+ 
++        private readonly ConcurrentDictionary<string[], string[]> tagKeyCombinations =
++            new ConcurrentDictionary<string[], string[]>(StringArrayComparer);
++
+         // Two-Level lookup. TagKeys x [ TagValues x Metrics ]
+         private readonly ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>> keyValue2MetricAggs =
+-            new ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>>(new StringArrayEqualityComparer());
++            new ConcurrentDictionary<string[], ConcurrentDictionary<object[], int>>(StringArrayComparer);
+ 
+         private readonly AggregationTemporality temporality;
+         private readonly string name;","another alternate option which doesn't have the risk of too many entries (when user keeps providing keys in different order) Have the dictionary as before If tagKeys lookup fail, sort and lookup again. If fails, insert both original tagKeys and its sorted one to the dictionary. So that we only store atmost 2 entries per key set. And we only do a single lookup in hotpath, as opposed to 2 look ups.","nit: `ConcurrentDictionary<string[], string[]>`"
+5461,"@@ -370,6 +370,13 @@ void PlanNode::releaseSymbols() {
+   }
+ }
+ 
++void PlanNode::updateSymbols() {
++  auto symTbl = qctx_->symTable();
++  for (auto out : outputVars_) {
++    out && symTbl->updateWrittenBy(out->name, out->name, this);
++  }
++}
++
+ std::ostream& operator<<(std::ostream& os, PlanNode::Kind kind) {
+   os << PlanNode::toString(kind);
+   return os;",if (out != nullptr),Why do we need this?
+5462,"@@ -79,6 +79,18 @@ def profile(user_name):
+ 
+     user = _get_user(user_name)
+ 
++    need_exact = request.args.get(""exact"")
++    if not need_exact:
++        listen_count = db_conn.get_listen_count_for_user(user_name)
++        # round off to nearest 10 as we can't guarantee that the values
++        # are not old, so show approximate values instead
++        if listen_count > 10:
++            listen_count = (listen_count / 10) * 10
++        have_exact = False
++    else:
++        listen_count = db_conn.get_listen_count_for_user(user_name, need_exact = True)
++        have_exact = True
++
+     # Getting data for current page
+     max_ts = request.args.get(""max_ts"")
+     if max_ts is not None:","In the listenstore you catch the exception and then pass it on via Raise. However, here you do not catch the exception. You should catch the exception, but since this is a minor aspect of this page, perhaps show an error message when the count cannot be loaded in time. Then the rest of the page can still be rendered, rather than failing the whole page.",I don't think you need the `= True` here.
+5463,"@@ -406,13 +406,14 @@ class TabbedBrowser(QWidget):
+         else:
+             yes_action()
+ 
+-    def close_tab(self, tab, *, add_undo=True, new_undo=True):
++    def close_tab(self, tab, *, add_undo=True, new_undo=True, transfer=False):
+         """"""Close a tab.
+ 
+         Args:
+             tab: The QWebView to be closed.
+             add_undo: Whether the tab close can be undone.
+             new_undo: Whether the undo entry should be a new item in the stack.
++            transfer: Whether the tab is closing because it is moving to a new window.
+         """"""
+         if config.val.tabs.tabs_are_windows:
+             last_close = 'close'",wouldn't it be simpler to just add `or transfer` here? That way the more complicated set of conditionals down below don't have to get more clauses.,I think this should be `transfer_to_new_window`
+5464,"@@ -13,8 +13,8 @@
+ # limitations under the License.
+ 
+ """"""Wrapper for the BigQuery API client.""""""
+-from googleapiclient import errors
+ from httplib2 import HttpLib2Error
++from googleapiclient import errors
+ 
+ from google.cloud.forseti.common.gcp_api import _base_repository
+ from google.cloud.forseti.common.gcp_api import api_helpers",ditto; please fix everywhere,Why this change?
+5465,"@@ -164,6 +164,18 @@ Home directory can be found in a shared folder called ""home""
+ 			Default:  false,
+ 			Help:     ""Set to skip any symlinks and any other non regular files."",
+ 			Advanced: true,
++		}, {
++			Name:     ""subsystem"",
++			Default:  ""sftp"",
++			Help:     ""Specifies the SSH2 subsystem on the remote host."",
++			Advanced: true,
++		}, {
++			Name:    ""server_command"",
++			Default: """",
++			Help: `Specifies the path or command to run a sftp server on the remote host.
++
++The subsystem option is ignored when server_command is defined.`,
++			Advanced: true,
+ 		}},
+ 	}
+ 	fs.Register(fsi)",Can you break this line into two parts - the first line makes the option help text for `--sftp-server` and its too long! `Specifies the path or command to run a sftp server on the remote host. The subsystem option is ignored when sftp_server is defined.`,This should be `
+5466,"@@ -45,7 +45,7 @@ class LoopAnalyzer
+         Context &$inner_context = null,
+         bool $is_do = false,
+         bool $always_enters_loop = false
+-    ) {
++    ): ?bool {
+         $traverser = new PhpParser\NodeTraverser;
+ 
+         $assignment_mapper = new \Psalm\Internal\PhpVisitor\AssignmentMapVisitor($loop_scope->loop_context->self);",I reverted that one in a previous PR because of a CI failure but it was actually unrelated,Why is this null
+5467,"@@ -112,12 +112,13 @@ func Add2ToolsList(toolList map[string]types.ToolsInstaller, flagData map[string
+ 	if kubeVer == """" {
+ 		var latestVersion string
+ 		for i := 0; i < util.RetryTimes; i++ {
+-			latestVersion, err := util.GetLatestVersion()
++			version, err := util.GetLatestVersion()
+ 			if err != nil {
+ 				return err
+ 			}
+-			if len(latestVersion) != 0 {
+-				kubeVer = latestVersion[1:]
++			if len(version) != 0 {
++				kubeVer = version[1:]
++				latestVersion = version
+ 				break
+ 			}
+ 		}","The for loop is useless here, since any error will make the function return.",I'm not sure if 
+5468,"@@ -0,0 +1,16 @@
++#! /usr/bin/env python
++
++
++# import unittest2 as unittest
++
++# from nupic.bindings.algorithms import FlatSpatialPooler as FlatSpatialPooler
++
++# import spatial_pooler_py_api_test as pytest
++
++# pytest.SpatialPooler = FlatSpatialPooler
++
++# SpatialPoolerFlatAPITest = pytest.SpatialPoolerAPITest
++
++
++# if __name__ == ""__main__"":
++#   unittest.main()",Fix file endings here and elsewhere.,Can we remove this file?
+5469,"@@ -1188,7 +1188,7 @@ void CLIENT_STATE::check_project_timeout() {
+         if (p->possibly_backed_off && now > p->min_rpc_time) {
+             p->possibly_backed_off = false;
+             char buf[256];
+-            snprintf(buf, sizeof(buf), ""Backoff ended for %s"", p->get_project_name());
++            snprintf(buf, sizeof(buf), ""Backoff ended for %.128s"", p->get_project_name());
+             request_work_fetch(buf);
+         }
+     }",I'd better increase `buf` length to MAXPATHLEN and not cut p->get_project_name() output twice,I think this should be `
+5470,"@@ -172,6 +172,7 @@ func (*impl) createStorageMiner(vmctx runtime.InvocationContext, params CreateSt
+ 				SectorSize:             params.SectorSize,
+ 			})
+ 			if err != nil {
++				fmt.Printf(""here it is: %s\n"", err)
+ 				return fmt.Errorf(""Could not set power table at address: %s"", actorIDAddr)
+ 			}
+ 			return nil","Please remove the prints, even though this code will be trashed.",Can you remove this?
+5471,"@@ -26,8 +26,8 @@ import (
+ 	""runtime/debug""
+ 
+ 	""github.com/projectcalico/felix/config""
+-	""github.com/projectcalico/felix/dataplane/external""
+-	""github.com/projectcalico/felix/dataplane/linux""
++	extdataplane ""github.com/projectcalico/felix/dataplane/external""
++	intdataplane ""github.com/projectcalico/felix/dataplane/linux""
+ 	""github.com/projectcalico/felix/ifacemonitor""
+ 	""github.com/projectcalico/felix/ipsets""
+ 	""github.com/projectcalico/felix/logutils""",Not sure if you added deliberately but I've seen these popping up; is goimports adding them?,Why do we need this alia
+5472,"@@ -75,6 +75,9 @@ func (src *AWSCluster) ConvertTo(dstRaw conversion.Hub) error { // nolint
+ 		dst.Spec.NetworkSpec.VPC.AvailabilityZoneSelection = restored.Spec.NetworkSpec.VPC.AvailabilityZoneSelection
+ 	}
+ 
++	dst.Spec.NetworkSpec.SecurityGroupOverrides = restored.Spec.NetworkSpec.SecurityGroupOverrides
++	dst.Spec.NetworkSpec.TagSecurityGroups = restored.Spec.NetworkSpec.TagSecurityGroups
++
+ 	return nil
+ }
+ ","I think we might need some special handling for `Spec.ControlPlaneLoadBalancer.SecurityGroups`, it looks like we are currently only handling the case that `Spec.ControlPlaneLoadBalancer` is nil.",Why do we need this?
+5473,"@@ -0,0 +1,18 @@
++_base_ = '../cascade_rcnn/cascade_mask_rcnn_r50_fpn_20e_coco.py'
++
++model = dict(
++    pretrained='open-mmlab://dla60',
++    backbone=dict(
++        type='DLANet',
++        depth=60,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++    neck=dict(
++        type='FPN',
++        in_channels=[128, 256, 512, 1024],
++        out_channels=256,
++        num_outs=5))",Is this from a third-party library?,why do we need this?
+5474,"@@ -70,3 +70,18 @@ dom.isNativelyFocusable = function(el) {
+ 	}
+ 	return false;
+ };
++
++/**
++ * Determines if an element is in the focus order, but would not be if its
++ * tabindex were unspecified.
++ * @method insertedIntoFocusOrder
++ * @memberof axe.commons.dom
++ * @instance
++ * @param {HTMLElement} el The HTMLElement
++ * @return {Boolean} True if the element is in the focus order but wouldn't be
++ * if its tabindex were removed. Else, false.
++ */
++dom.insertedIntoFocusOrder = function(el) {
++	return (el.tabIndex > -1 && dom.isFocusable(el) &&
++			!dom.isNativelyFocusable(el));
++};","Please put the `el.tabIndex > -1` in the first part of the expression. The matcher will run on every node on the page, so we should put the fastest part first.",I don't think we nee
+5475,"@@ -20,14 +20,14 @@ package mysterium
+ import (
+ 	""path/filepath""
+ 
+-	log ""github.com/cihub/seelog""
+ 	""github.com/mitchellh/go-homedir""
++	""github.com/mysteriumnetwork/go-openvpn/openvpn3""
+ 	""github.com/mysteriumnetwork/node/cmd""
+ 	""github.com/mysteriumnetwork/node/core/connection""
+ 	""github.com/mysteriumnetwork/node/core/node""
+-	""github.com/mysteriumnetwork/node/identity""
+ 	""github.com/mysteriumnetwork/node/metadata""
+-	service_noop ""github.com/mysteriumnetwork/node/services/noop""
++	""github.com/mysteriumnetwork/node/services/openvpn""
++	""github.com/mysteriumnetwork/node/services/openvpn/session""
+ )
+ 
+ // MobileNode represents node object tuned for mobile devices","`identity` is unused now, is it for future usage?",nit: remove empty li
+5476,"@@ -9,11 +9,14 @@ Puppet::Functions.create_function(:prompt) do
+   # @param prompt The prompt to display.
+   # @param options A hash of additional options.
+   # @option options [Boolean] sensitive Disable echo back and mark the response as sensitive.
++  #   The returned value will be wrapped by the `Sensitive` data type. To access the raw
++  #   value, use the `unwrap` function (i.e. `$sensitive_value.unwrap`).
+   # @return The response to the prompt.
+   # @example Prompt the user if plan execution should continue
+   #   $response = prompt('Continue executing plan? [Y\N]')
+   # @example Prompt the user for sensitive information
+   #   $password = prompt('Enter your password', 'sensitive' => true)
++  #   out::message(""Password is: ${password.unwrap}"")
+   dispatch :prompt do
+     param 'String', :prompt
+     optional_param 'Hash[String[1], Any]', :options","This would have assisted me a lot! I am on the ""functions"" page more than any other page in the docs",Should this be `out::message` instead of `out::message`?
+5477,"@@ -971,7 +971,7 @@ class JobTask(BaseHadoopJobTask):
+             if self.__module__ == '__main__':
+                 d = pickle.dumps(self)
+                 module_name = os.path.basename(sys.argv[0]).rsplit('.', 1)[0]
+-                d = d.replace(b'(c__main__', ""(c"" + module_name)
++                d = d.replace(b'c__main__', b'c' + module_name.encode('ascii'))
+                 open(file_name, ""wb"").write(d)
+ 
+             else:",I think it's better we keep `(` and encode with default encoding (utf-8).,Why is this needed?
+5478,"@@ -52,11 +52,12 @@ class BaselineFormat extends AbstractBaselinePlugin {
+                 java.removeUnusedImports();
+                 // use empty string to specify one group for all non-static imports
+                 java.importOrder("""");
+-                java.trimTrailingWhitespace();
+ 
+                 if (eclipseFormattingEnabled(project)) {
+                     java.eclipse().configFile(project.file(eclipseXml.toString()));
+                 }
++
++                java.trimTrailingWhitespace();
+             });
+ 
+             // necessary because SpotlessPlugin creates tasks in an afterEvaluate block",this is gonna be different in an IDE vs from gradlew??,Why is this needed?
+5479,"@@ -140,3 +140,18 @@ end
+ 
+ Spork.each_run do
+ end
++
++shared_context ""with isolated syntax"" do
++  orig_matchers_syntax = nil
++  orig_mocks_syntax = nil
++
++  before(:each) do
++    orig_matchers_syntax = RSpec::Matchers.configuration.syntax
++    orig_mocks_syntax = RSpec::Mocks.configuration.syntax
++  end
++
++  after(:each) do
++    RSpec::Matchers.configuration.syntax = orig_matchers_syntax
++    RSpec::Mocks.configuration.syntax = orig_mocks_syntax
++  end
++end",Do we not already have something for isolating syntax?,I'm not sure if this is the best way to do this.
+5480,"@@ -1,7 +1,7 @@
+ # -*- coding: utf-8 -*-
+ ##
+ ## This file is part of Invenio.
+-## Copyright (C) 2012 CERN.
++## Copyright (C) 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","1: D100 Docstring missing 4: I102 copyright year is outdated, expected 2014 but got 2012 158: D103 Docstring missing 168: D101 Docstring missing 170: D102 Docstring missing 180: D102 Docstring missing 187: D102 Docstring missing",Why did you change the year?
+5481,"@@ -1,11 +1,14 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
++# This code example demonstrates how deny uploads of objects without
++# server-side AWS KMS encryption to an Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3_add_bucket_sses3_encryption_policy]
++
+ require 'aws-sdk-s3'
+ 
+-# Denies uploads of objects without server-side AWS KMS encryption to
+-#   an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - The Amazon S3 bucket to deny uploading objects without",how **to** deny,I think this should be `snip
+5482,"@@ -19,6 +19,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     /// </summary>
+     public class ListenOptions : IEndPointInformation, IConnectionBuilder
+     {
++        private const string Http2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http2"";
++        private const string Http1AndHttp2ExperimentSwitch = ""Switch.Microsoft.AspNetCore.Server.Kestrel.Experiential.Http1AndHttp2"";
++
+         private FileHandleType _handleType;
+         private readonly List<Func<ConnectionDelegate, ConnectionDelegate>> _components = new List<Func<ConnectionDelegate, ConnectionDelegate>>();
+ ",The only beef I have with this is that it's app domain global.,Nit: I think this should be 
+5483,"@@ -562,8 +562,11 @@ func (ln tcpKeepAliveListener) Accept() (c net.Conn, err error) {
+ 	if err = tc.SetKeepAlive(true); err != nil {
+ 		return
+ 	}
+-	if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {
+-		return
++	// OpenBSD has no user-settable per-socket TCP keepalive
++	if runtime.GOOS != ""openbsd"" {
++		if err = tc.SetKeepAlivePeriod(3 * time.Minute); err != nil {
++			return
++		}
+ 	}
+ 	return tc, nil
+ }",Can you link to the GitHub issue and/or PR so that it is easy for future readers to find out more about this?,Why is this needed?
+5484,"@@ -3009,3 +3009,18 @@ void StatelessValidation::PostCallRecordDestroyRenderPass(VkDevice device, VkRen
+     // Track the state necessary for checking vkCreateGraphicsPipeline (subpass usage of depth and color attachments)
+     renderpasses_states.erase(renderPass);
+ }
++
++bool StatelessValidation::manual_PreCallValidateAllocateMemory(VkDevice device, const VkMemoryAllocateInfo *pAllocateInfo,
++                                                               const VkAllocationCallbacks *pAllocator, VkDeviceMemory *pMemory) {
++    bool skip = false;
++
++    if (pAllocateInfo) {
++        auto chained_prio_struct = lvl_find_in_chain<VkMemoryPriorityAllocateInfoEXT>(pAllocateInfo->pNext);
++        if (chained_prio_struct && (chained_prio_struct->priority < 0.0f || chained_prio_struct->priority > 1.0f)) {
++            skip |= log_msg(report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_UNKNOWN_EXT, 0,
++                            ""VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602"",
++                            ""priority (=%f) must be between `0` and `1`, inclusive."", chained_prio_struct->priority);
++        }
++    }
++    return skip;
++}",Typical to report the value found as well as the valid bounds.,This should be `VUID-VkMemoryPriorityAllocateInfoEXT-priority-02602`
+5485,"@@ -151,7 +151,7 @@ var clerkCmd = &cobra.Command{
+ 	},
+ }
+ 
+-func waitForCommit(client libgoal.Client, txid string) error {
++func waitForCommit(client libgoal.Client, txid string, transactionLastValidRound uint64) error {
+ 	// Get current round information
+ 	stat, err := client.Status()
+ 	if err != nil {",maybe we want 0 as a default value?,Why do we need this?
+5486,"@@ -193,7 +193,16 @@ func (api *Server) GetAccount(ctx context.Context, in *iotexapi.GetAccountReques
+ 		PendingNonce: pendingNonce,
+ 		NumActions:   numActions,
+ 	}
+-	return &iotexapi.GetAccountResponse{AccountMeta: accountMeta}, nil
++	tipHeight := api.bc.TipHeight()
++	header, err := api.bc.BlockHeaderByHeight(tipHeight)
++	if err != nil {
++		return nil, status.Error(codes.NotFound, err.Error())
++	}
++	hash := header.HashBlock()
++	return &iotexapi.GetAccountResponse{AccountMeta: accountMeta, BlockIdentifier: &iotextypes.BlockIdentifier{
++		Hash:   hex.EncodeToString(hash[:]),
++		Height: tipHeight,
++	}}, nil
+ }
+ 
+ // GetActions returns actions",can we get height from sf at very beginning of the function and use that as height of the block?,Why do we need to encode the hash?
+5487,"@@ -0,0 +1,6 @@
++namespace Microsoft.AspNet.Server.Kestrel
++{
++    public class StandardsPoliceCompileModule : Microsoft.StandardsPolice.StandardsPoliceCompileModule
++    {
++    }
++}",Does this have to be public and in the primary namespace?,Why do we need this?
+5488,"@@ -1206,6 +1206,15 @@ func (fbo *folderBranchOps) initMDLocked(
+ 		return err
+ 	}
+ 
++	fbo.headLock.Lock(lState)
++	defer fbo.headLock.Unlock(lState)
++	// Some other thread got here first, so give up and let it go
++	// before we push anything to the servers.
++	if fbo.head != (ImmutableRootMetadata{}) {
++		fbo.log.CDebugf(ctx, ""Head was already set, aborting"")
++		return nil
++	}
++
+ 	if err = PutBlockCheckQuota(ctx, fbo.config.BlockServer(),
+ 		fbo.config.Reporter(), md.TlfID(), info.BlockPointer, readyBlockData,
+ 		md.GetTlfHandle().GetCanonicalName()); err != nil {",I'm a bit confused. Doesn't `mdWriterLock` already synchronizes calls to this function?,Why do we need this lock?
+5489,"@@ -120,7 +120,13 @@ final class DailyMotionProvider extends BaseVideoProvider
+ 
+     public function getReferenceUrl(MediaInterface $media): string
+     {
+-        return sprintf('http://www.dailymotion.com/video/%s', $media->getProviderReference());
++        $providerReference = $media->getProviderReference();
++
++        if (null === $providerReference) {
++            return '';
++        }
++
++        return sprintf('http://www.dailymotion.com/video/%s', $providerReference);
+     }
+ 
+     protected function doTransform(MediaInterface $media): void","Does it make sense to generate a dailyMotion url without the video reference? It does not to me, but can we throw an exception here?",Shouldn't we throw an exc
+5490,"@@ -24,10 +24,11 @@ import (
+ 	""sort""
+ 	""strings""
+ 
+-	stringutils ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/string""
+-	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ 	computeBeta ""google.golang.org/api/compute/v0.beta""
+ 	""google.golang.org/api/compute/v1""
++
++	stringutils ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/string""
++	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ )
+ 
+ const (",Why the separation of imports here?,nit: this import should b
+5491,"@@ -4,14 +4,14 @@ import (
+ 	""context""
+ 
+ 	""github.com/influxdata/flux/ast""
+-	""github.com/influxdata/flux/dependencies""
++
+ 	""github.com/influxdata/flux/interpreter""
+ 	""github.com/influxdata/flux/parser""
+ 	""github.com/influxdata/flux/semantic""
+ 	""github.com/influxdata/flux/values""
+ )
+ 
+-func Eval(ctx context.Context, deps dependencies.Interface, itrp *interpreter.Interpreter, scope values.Scope, importer interpreter.Importer, src string) ([]interpreter.SideEffect, error) {
++func Eval(ctx context.Context, itrp *interpreter.Interpreter, scope values.Scope, importer interpreter.Importer, src string) ([]interpreter.SideEffect, error) {
+ 	pkg := parser.ParseSource(src)
+ 	if ast.Check(pkg) > 0 {
+ 		return nil, ast.GetError(pkg)",Random extra newline.,I'm not sure if this is t
+5492,"@@ -0,0 +1,18 @@
++/* global dom */
++
++/**
++ * Get all descendents that are focusable from a given node
++ * @method getFocusableElements
++ * @memberof axe.commons.dom
++ * @instance
++ * @param  {Object} virtualNode The virtualNode to assess
++ * @return {Boolean}
++ */
++dom.getFocusableElements = function getFocusableElements(virtualNode) {
++	const descendents = axe.utils.querySelectorAll(virtualNode, '*');
++	const focusableElms = descendents.filter(({ actualNode: el }) => {
++		const isElFocusable = dom.isFocusable(el);
++		return isElFocusable;
++	});
++	return focusableElms;
++};",No need for this variable.,"I think this should be `axe.utils.querySelectorAll(virtualNode, '*')`"
+5493,"@@ -79,6 +79,15 @@ def authentication_required(url, authenticator, abort_on):
+     return answer
+ 
+ 
++def _format_msg(msg: str) -> str:
++    """"""Convert message to HTML suitable for rendering.""""""
++    ret = msg
++    ret = html.escape(ret)
++    ret = ret.strip()
++    ret = ret.replace('\n', '<br />')
++    return ret
++
++
+ def javascript_confirm(url, js_msg, abort_on):
+     """"""Display a javascript confirm prompt.""""""
+     log.js.debug(""confirm: {}"".format(js_msg))",Why not use `msg` directly below?,Why do we need this function?
+5494,"@@ -29,9 +29,8 @@ import org.apache.parquet.schema.OriginalType;
+ import org.apache.parquet.schema.PrimitiveType;
+ import org.apache.parquet.schema.Type;
+ 
+-import static org.apache.parquet.schema.Type.Repetition.REPEATED;
+-
+ public class ParquetTypeVisitor<T> {
++  @SuppressWarnings({""checkstyle:IllegalType"", ""checkstyle:VisibilityModifier""})
+   protected LinkedList<String> fieldNames = Lists.newLinkedList();
+ 
+   public static <T> T visit(Type type, ParquetTypeVisitor<T> visitor) {",I think other places changed to use `Deque` instead of suppressing the warning.,Why is this needed?
+5495,"@@ -4,8 +4,11 @@
+ #include ""engine/guidance/toolkit.hpp""
+ 
+ #include <boost/assert.hpp>
++#include <boost/range/algorithm_ext/erase.hpp>
++
+ #include <iostream>
+-#include <vector>
++#include <cstddef>
++#include <utility>
+ 
+ using TurnInstruction = osrm::extractor::guidance::TurnInstruction;
+ using TurnType = osrm::extractor::guidance::TurnType;","missing: utility, cstddef also: vector is already included in the header (interface requires vectors as in/out types)",Why is this needed?
+5496,"@@ -16,6 +16,9 @@ module.exports = {
+ 		'html',
+ 		'text-summary',
+ 	],
++	globals: {
++		fetchMock: '',
++	},
+ 	rootDir: '../../',
+ 	transform: {
+ 		'^.+\\.[jt]sx?$': '<rootDir>/node_modules/@wordpress/scripts/config/babel-transform',","I'm not sure this is necessary in the config here, as Jest would be setting the global `fetchMock = ''`. See below.",Why do we need this?
+5497,"@@ -57,7 +57,7 @@ public abstract class Message implements Part, Body {
+         final int MULTIPLIER = 31;
+ 
+         int result = 1;
+-        result = MULTIPLIER * result + mFolder.getName().hashCode();
++        result = MULTIPLIER * result + (mFolder != null ? mFolder.getName().hashCode() : 0);
+         result = MULTIPLIER * result + mUid.hashCode();
+         return result;
+     }",Can `mFolder == null` happen during regular operations? Or is it only so we can be lazy in tests?,Why is this change n
+5498,"@@ -0,0 +1,8 @@
++require ""migrate""
++
++class AddPreferredEmailFormat < ActiveRecord::Migration
++  def change
++    create_enumeration :email_format_enum, %w(text_only multipart)
++    add_column :users, :preferred_email_format, :email_format_enum, :null => false, :default => ""multipart""
++  end
++end",I'd suggest using the actual MIME types here - so `text/plain` and `multipart/alternative` or does that cause problems with what postgres allows for enumeration names? If so then maybe just replace the slash with an underscore?,Use the new Ruby 1.9
+5499,"@@ -619,9 +619,9 @@ def package_put(owner, package_name, package_hash):
+             if team_access is None:
+                 raise ApiException(
+                     requests.codes.forbidden,
+-                    (""%(user)s/%(pkg)s is private. To share it with the team, "" +
+-                     ""run `quilt access add %(user)s/%(pkg)s team`."") %
+-                    dict(user=owner, pkg=package_name)
++                    (""%(team)s:%(user)s/%(pkg)s is private. To share it with the team, "" +
++                        ""run `quilt access add %(team)s:%(user)s/%(pkg)s team`."") %
++                    dict(team=app.config['TEAM_NAME'].lower(), user=owner, pkg=package_name)
+                 )
+ 
+     # Insert an instance if it doesn't already exist.","Ohh. `TeamName` is actually a ""friendly"" name displayed in the Catalog - not the name used in the CLI. So I guess we'll need a new variable here. (That is, this is going to be mainly a `quilt.yaml` change. You won't need the `.lower()`, though.)",I think this should 
+5500,"@@ -383,6 +383,7 @@ class ConsoleAddon:
+             part in (""response-headers"", ""response-body"", ""set-cookies"") and
+             flow.response is None
+         )
++        flow.backup()
+         if require_dummy_response:
+             flow.response = http.HTTPResponse.make()
+         if part == ""cookies"":","Nit: Don't move it between `require_dummy_response` definition and usage, this can live above or below :)",Why is this needed?
+5501,"@@ -377,6 +377,17 @@ type Local struct {
+ 	// connections that are originating from the local machine. Setting this to ""true"", allow to create large
+ 	// local-machine networks that won't trip the incoming connection limit observed by relays.
+ 	DisableLocalhostConnectionRateLimit bool `version[16]:""true""`
++
++	// BlockServiceCustomFallbackEndpoints is a comma delimited list of endpoints which the block service uses to
++	// redirect the http requests to in case it does not have the round. If it is not specified, will check
++	// EnableBlockServiceFallbackToArchiver.
++	BlockServiceCustomFallbackEndpoints string `version[16]:""""`
++
++	// EnableBlockServiceFallbackToArchiver controls whether the block service redirects the http requests to
++	// an archiver or return StatusNotFound (404) when in does not have the requested round, and
++	// BlockServiceCustomFallbackEndpoints is empty.
++	// The archiver is randomly selected, if none is available, will return StatusNotFound (404).
++	EnableBlockServiceFallbackToArchiver bool `version[16]:""true""`
+ }
+ 
+ // Filenames of config files within the configdir (e.g. ~/.algorand)","With the current code, it not work if `EnableCatchupFromArchiveServers` is disabled. to fix it: in getDNSAddrs, change the predicate to `if wn.config.EnableCatchupFromArchiveServers || wn.config. EnableCatchupFromArchiveServers {` and in the catchup/service.go and catchup/catchpointService.go, use the `PeersPhonebookArchivers` only when `wn.config.EnableCatchupFromArchiveServers` is enabled.",I don't think this 
+5502,"@@ -910,8 +910,9 @@ func (cr *ConflictResolver) resolveMergedPaths(ctx context.Context,
+ 	// cache for the merged branch.
+ 	mergedNodeCache := newNodeCacheStandard(cr.fbo.folderBranch)
+ 	// Initialize the root node.  There will always be at least one
+-	// unmerged path.
+-	mergedNodeCache.GetOrCreate(mergedChains.mostRecentMD.data.Dir.BlockPointer,
++	// unmerged path.  Hold it here so it doesn't get gc'd.
++	rootNode, _ := mergedNodeCache.GetOrCreate(
++		mergedChains.mostRecentMD.data.Dir.BlockPointer,
+ 		unmergedPaths[0].path[0].Name, nil)
+ 
+ 	newPtrs := make(map[BlockPointer]bool)","Why not make `SearchForNodes` do a `GetOrCreate` for the root node? (Not advocating for it, but just wondering if there's another reason than avoiding having to pass in the path.)",I don't think we sh
+5503,"@@ -224,6 +224,7 @@ public class DefaultP2PNetwork implements P2PNetwork {
+                 }
+                 dnsPeers.set(peers);
+               });
++      dnsDaemon.start();
+     }
+ 
+     final int listeningPort = rlpxAgent.start().join();",:+1: amazing that this has been missing since it was originally implemented,Why do we need this
+5504,"@@ -101,7 +101,7 @@ class OrcFileAppender<D> implements FileAppender<D> {
+   public long length() {
+     Preconditions.checkState(isClosed,
+         ""Cannot return length while appending to an open file."");
+-    return writer.getRawDataSize();
++    return file.toInputFile().getLength();
+   }
+ 
+   @Override","Just want to note here that although we do check `length` while writing to choose whether to close and start a new file, that doesn't happen for ORC already so it is fine to use a FS call in this method.",Why do we need to change this?
+5505,"@@ -67,8 +67,7 @@ public class PartitionField implements Serializable {
+   public boolean equals(Object other) {
+     if (this == other) {
+       return true;
+-    }
+-    if (other == null || getClass() != other.getClass()) {
++    } else if (!(other instanceof PartitionField)) {
+       return false;
+     }
+ ",nit: I feel multiple `if (...) { return ... }` is more readable than `if ... else ...`.,Why did you remove this check?
+5506,"@@ -32,7 +32,7 @@ def setup_test_logging():
+         root.debug(""Already set up logging"")
+ 
+ 
+-setup_test_logging()
++# setup_test_logging()
+ logging.info(""Bootstrapped test"")
+ 
+ ",This is needed for us to work in IDE UTs,Is this intentional?
+5507,"@@ -282,6 +282,12 @@ commands (copy, sync, etc), and with all other commands too.`,
+ 			Default:  false,
+ 			Help:     ""Only show files that are in the trash.\nThis will show trashed files in their original directory structure."",
+ 			Advanced: true,
++		}, {
++		}, {
++			Name:     ""starred_only"",
++			Default:  false,
++			Help:     ""Only show files that are starred."",
++			Advanced: true,
+ 		}, {
+ 			Name:     ""formats"",
+ 			Default:  """",",File is not `goimports`-ed (from `goimports`),I don't think this is the righ
+5508,"@@ -486,14 +486,14 @@ func DupSecOpt(src string) []string {
+ 		con[""level""] == """" {
+ 		return nil
+ 	}
+-	return []string{""label:user:"" + con[""user""],
+-		""label:role:"" + con[""role""],
+-		""label:type:"" + con[""type""],
+-		""label:level:"" + con[""level""]}
++	return []string{""label=user:"" + con[""user""],
++		""label=role:"" + con[""role""],
++		""label=type:"" + con[""type""],
++		""label=level:"" + con[""level""]}
+ }
+ 
+ // DisableSecOpt returns a security opt that can be used to disabling SELinux
+ // labeling support for future container processes
+ func DisableSecOpt() []string {
+-	return []string{""label:disable""}
++	return []string{""label=disable""}
+ }","this `label=` is docker specific, while here in libcontainer there shouldn't be any mention to docker. `DisableSecOpt` and `DupSecOpt` should just deal with `disable,role,type,level`. Both CRI-O and docker should just pass `disable,role,type.level` stuff and not `label=...`.",I don't think we need to change this.
+5509,"@@ -31,6 +31,7 @@ func init() {
+ 	flags.BoolVarP(cmdFlags, &notCreateNewFile, ""no-create"", ""C"", false, ""Do not create the file if it does not exist."")
+ 	flags.StringVarP(cmdFlags, &timeAsArgument, ""timestamp"", ""t"", """", ""Use specified time instead of the current time of day."")
+ 	flags.BoolVarP(cmdFlags, &localTime, ""localtime"", """", false, ""Use localtime for timestamp, not UTC."")
++	flags.BoolVarP(cmdFlags, &recurse, ""recursive"", ""R"", false, ""Recurse into the listing."")
+ }
+ 
+ var commandDefinition = &cobra.Command{","You need to declare variable `recurse` above, same place as `localTime`.","flags.BoolVarP(cmdFlags, &recursive, "
+5510,"@@ -1565,7 +1565,8 @@ class SpreadingOperation(LinkableOperation):
+             new_data[tuple(vd.name for vd in vdims)] = img
+         else:
+             new_data = array
+-        return element.clone(new_data, **kwargs)
++        return element.clone(new_data, xdensity=element.xdensity,
++                             ydensity=element.ydensity, **kwargs)
+ 
+ 
+ ",Why does `clone` not already copy `xdensity` and `ydensity` from what it is cloning?,I think this should be `xdensity=elem
+5511,"@@ -52,6 +52,11 @@ namespace OpenTelemetry.Metrics
+ 
+             AggregationTemporality temporality = AggregationTemporality.Cumulative;
+ 
++            if (meterSources.Count() == 0)
++            {
++                throw new ArgumentException(""No meter was added to the sdk."");
++            }
++
+             foreach (var reader in readers)
+             {
+                 if (reader == null)",Curious - do we do the same for traces (when no ActivitySource / legacy source are added)? (and why we want to do it for metrics?),Why is this needed?
+5512,"@@ -801,11 +801,11 @@ SdMmcHcStartSdClock (
+ 
+   Refer to SD Host Controller Simplified spec 3.0 Section 3.2.1 for details.
+ 
+-  @param[in] Private         A pointer to the SD_MMC_HC_PRIVATE_DATA instance.
+-  @param[in] Slot            The slot number of the SD card to send the command to.
+-  @param[in] BusTiming       BusTiming at which the frequency change is done.
+-  @param[in] FirstTimeSetup  Flag to indicate whether the clock is being setup for the first time.
+-  @param[in] ClockFreq       The max clock frequency to be set. The unit is KHz.
++  @param[in] PciIo          The PCI IO protocol instance.
++  @param[in] Slot           The slot number of the SD card to send the command to.
++  @param[in] ClockFreq      The max clock frequency to be set. The unit is KHz.
++  @param[in] BaseClkFreq    The base clock frequency of host controller in MHz.
++  @param[in] ControllerVer  The version of host controller.
+ 
+   @retval EFI_SUCCESS       The clock is supplied successfully.
+   @retval Others            The clock isn't supplied successfully.","@aimanrosli23 For the changes in file SdMmcPciHci.c, please make sure that you do not revert the changes made by the below commits: SHA-1: 49accdedf956f175041040e677163b7cbb746283 * MdeModulePkg/SdMmcPciHcDxe: Hook SwitchClockFreq after SD clock start SHA-1: c67617f3c677c342efde780e229f841f4e0f6c7e * MdeModulePkg/SdMmcPciHcDxe: Add retries for sync commands SHA-1: 6d387610855ee27b49cb720de29ed809ea59dadc * MdeModulePkg/SdMmcPciHcDxe: Read response on command completion SHA-1: 63fd7f389874081ea37452b1f79ac013d52755e3 * MdeModulePkg/SdMmcPciHcDxe: Do not map memory for non DMA transfer",This should be `@param[in] ControllerVer`
+5513,"@@ -128,11 +128,18 @@ class SelectionAndFilterTests:
+         ('<link href=""javascript://foo"" />', [webelem.Group.all,
+                                               webelem.Group.url]),
+ 
+-        ('<textarea />', [webelem.Group.all]),
++        ('<textarea />', [webelem.Group.all, webelem.Group.inputs]),
+         ('<select />', [webelem.Group.all]),
+ 
+         ('<input />', [webelem.Group.all]),
+         ('<input type=""hidden"" />', []),
++        ('<input type=""text"" />', [webelem.Group.inputs]),
++        ('<input type=""email"" />', [webelem.Group.inputs]),
++        ('<input type=""url"" />', [webelem.Group.inputs]),
++        ('<input type=""tel"" />', [webelem.Group.inputs]),
++        ('<input type=""number"" />', [webelem.Group.inputs]),
++        ('<input type=""password"" />', [webelem.Group.inputs]),
++        ('<input type=""search"" />', [webelem.Group.inputs]),
+ 
+         ('<button />', [webelem.Group.all]),
+         ('<button href=""foo"" />', [webelem.Group.all, webelem.Group.prevnext,",You'll also need to add `webelem.Group.all` everywhere as that matches as well,I'm not sure if this is the right place f
+5514,"@@ -0,0 +1,14 @@
++$(document).ready(initializeDocument);
++
++function initializeDocument() {
++  //only enable bank account field when BA80 is selected as an expense_type
++  $(""input:radio[name='ncr_proposal[expense_type]']"").click(function(event){
++    if ($(""input:radio[name='ncr_proposal[expense_type]']:checked"").val() == 'BA80') {
++      $('#ncr_proposal_RWA_number').attr('disabled', false);
++    } else {
++      $('#ncr_proposal_RWA_number').attr('disabled', true);
++    }
++  });
++
++  $('#ncr_proposal_building_number').chosen({placeholder_text_multiple: 'If applicable, which building will the charge support?'})
++}",Does this need to be an ERB template?,This should be `ncr_proposal_building_num
+5515,"@@ -0,0 +1,18 @@
++package feedbackmock
++
++import (
++	""context""
++
++	feedbackv1 ""github.com/lyft/clutch/backend/api/feedback/v1""
++	""github.com/lyft/clutch/backend/service/feedback""
++)
++
++type svc struct{}
++
++func (s svc) SubmitFeedback(ctx context.Context, id string, feedback *feedbackv1.Feedback, metadata *feedbackv1.FeedbackMetadata) error {
++	return nil
++}
++
++func New() feedback.Service {
++	return &svc{}
++}",do we want to register this in the mock server for testing?,Why do we need this?
+5516,"@@ -231,10 +231,10 @@ class AnomalyLikelihoodTest(TestCaseBase):
+ 
+     # Generate an estimate using fake distribution of anomaly scores.
+     data1 = _generateSampleData(mean=0.2)
+-    data1 = data1 + [(2, 2), (2, 2, 2, 2), (), (2)]  # Malformed records
++    data1 = data1[0:1000] + [(2, 2), (2, 2, 2, 2), (), (2)]  # Malformed records
+ 
+     likelihoods, avgRecordList, estimatorParams = (
+-      an.estimateAnomalyLikelihoods(data1[0:1000])
++      an.estimateAnomalyLikelihoods(data1[0:1004])
+     )
+     self.assertEqual(len(likelihoods), 1000)
+     self.assertEqual(len(avgRecordList), 1000)",shouldnt this be `0:996` (+4) so the 1000s below fit?,Why did this change?
+5517,"@@ -49,11 +49,11 @@ class sorted_context(object):
+         self.enabled = enabled
+ 
+     def __enter__(self):
+-        self._enabled = MultiDimensionalMapping._sorted
+-        MultiDimensionalMapping._sorted = self.enabled
++        self._enabled = MultiDimensionalMapping.sort
++        MultiDimensionalMapping.sort = self.enabled
+ 
+     def __exit__(self, exc_type, exc_val, exc_tb):
+-        MultiDimensionalMapping._sorted = self._enabled
++        MultiDimensionalMapping.sort = self._enabled
+ 
+ 
+ ","The docstring of this context_manager should be updated. As now ``sort=False`` is valid, it should just say it disables sorting regardless of whether the NdMapping has ``sort=True`` or ``sort=False``. I also think the line 'Should only be used if values are guaranteed to be sorted before or after the operation is performed.' should just say something else - maybe just that the initial ordering (whatever it is) should be preserved?",Why do we need to do
+5518,"@@ -52,8 +52,8 @@ describe('Lifecycle methods', () => {
+ 			}
+ 		}
+ 
+-		spyAll(Receiver.prototype);
+ 		spyAll(Receiver);
++		spyAll(Receiver.prototype);
+ 
+ 		function throwExpectedError() {
+ 			throw (expectedError = new Error('Error!'));",This tests failed unless I swapped the order here. Perhaps some new class transform broke the old form?  ,Why this change?
+5519,"@@ -699,10 +699,14 @@ class Util:
+     @classmethod
+     def get_java_opts(cls):
+         opts = config.LAMBDA_JAVA_OPTS or ''
+-        if '_debug_port_' in opts:
++        if 'address=_debug_port_' in opts:
+             if not cls.debug_java_port:
+                 cls.debug_java_port = get_free_tcp_port()
+             opts = opts.replace('_debug_port_', ('%s' % cls.debug_java_port))
++        elif 'address=' in opts:
++            if not cls.debug_java_port:
++                cls.debug_java_port = ops.split(""address="")[1]
++
+         return opts
+ 
+     @classmethod",extract the port and set to `debug_java_port`,I think this should 
+5520,"@@ -93,6 +93,13 @@ def parse_compile_commands_json(logfile, add_compiler_defaults=False):
+     counter = 0
+     for entry in data:
+         sourcefile = entry['file']
++
++        if not os.path.isabs(sourcefile):
++            # Newest versions of intercept-build can create the 'file' in the
++            # JSON Compilation Database as a relative path.
++            sourcefile = os.path.join(os.path.abspath(entry['directory']),
++                                      sourcefile)
++
+         lang = option_parser.get_language(sourcefile[sourcefile.rfind('.'):])
+ 
+         if not lang:","When the argument list is `[""one"", ""two three""]` then you concatenate it as you do it here, you won't be able to get the original list back with split. You need to annotate the list items better. (Or if you won't do the split by yourself, the called shell will do it. So you need shell escaping. How portable is that?) The main driver to change this in `intercept-build` was to get rid of these concatenation and splitting errors. The current compilation database parser in Clang understands the `arguments` filed... So the question, why don't you pass the command around as a list instead of a string?",I'm not sure if this is the best way to do this. I think it would be better to use `os.path.relpath` here.
+5521,"@@ -95,6 +95,10 @@ func (a *FakeWebAPI) RegisterPiped(ctx context.Context, req *webservice.Register
+ 	}, nil
+ }
+ 
++func (a *FakeWebAPI) EnablePiped(ctx context.Context, req *webservice.EnablePipedRequest) (*webservice.EnablePipedResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}
++
+ func (a *FakeWebAPI) DisablePiped(ctx context.Context, req *webservice.DisablePipedRequest) (*webservice.DisablePipedResponse, error) {
+ 	return nil, status.Error(codes.Unimplemented, """")
+ }",`ctx` is unused in EnablePiped,Why is this not implemented?
+5522,"@@ -57,7 +57,9 @@ class _Session(object):
+         return hashlib.sha256(auth_string + ""@"" +
+                               _Session.__initial_salt).hexdigest()
+ 
+-    def __init__(self, token, phash):
++    def __init__(self, token, phash, user, authenticated):
++        self.authenticated = authenticated
++        self.user = user
+         self.token = token
+         self.persistent_hash = phash
+         self.last_access = datetime.now()",Why do we have both a list of valid sessions and an instance variable if a session is destroyed?,Why do we need this?
+5523,"@@ -258,10 +258,11 @@ func (au *accountUpdates) committedUpTo(rnd basics.Round) basics.Round {
+ 	// Keep track of how many changes to each account we flush to the
+ 	// account DB, so that we can drop the corresponding refcounts in
+ 	// au.accounts.
+-	flushcount := make(map[basics.Address]int)
++	var flushcount map[basics.Address]int
+ 
+ 	offset := uint64(newBase - au.dbRound)
+ 	err := au.dbs.wdb.Atomic(func(tx *sql.Tx) error {
++		flushcount = make(map[basics.Address]int)
+ 		for i := uint64(0); i < offset; i++ {
+ 			rnd := au.dbRound + basics.Round(i) + 1
+ 			err := accountsNewRound(tx, rnd, au.deltas[i], au.roundTotals[i+1].RewardsLevel, au.protos[i+1])","nit : I think that it would be ""cleaner"" to set the `flushcount` to nil in case of an error nice catch ;-)",Why is this change necessary?
+5524,"@@ -19,13 +19,12 @@
+ package org.phoenicis.repository.repositoryTypes;
+ 
+ import org.junit.Test;
+-import org.phoenicis.repository.repositoryTypes.NullRepository;
+ 
+ import static org.junit.Assert.assertEquals;
+ 
+ public class NullRepositoryTest {
+     @Test
+     public void testNullRepositoryTest() {
+-        assertEquals(0, new NullRepository().fetchInstallableApplications().size());
++        assertEquals(null, new NullRepository().fetchInstallableApplications());
+     }
+ }",You may want to use assertNull,Why this change?
+5525,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+ 
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,This should be `
+5526,"@@ -224,7 +224,6 @@ struct wlr_output *wlr_wl_output_create(struct wlr_backend *_backend) {
+ 
+ 	wlr_output->width = 640;
+ 	wlr_output->height = 480;
+-	wlr_output->scale = 1;
+ 	strncpy(wlr_output->make, ""wayland"", sizeof(wlr_output->make));
+ 	strncpy(wlr_output->model, ""wayland"", sizeof(wlr_output->model));
+ 	snprintf(wlr_output->name, sizeof(wlr_output->name), ""WL-%zd"",",Why did you remove this?,Why was this rem
+5527,"@@ -72,7 +72,12 @@ func mapPort(m portmap.Interface, c chan struct{}, protocol string, extPort, int
+ 		}
+ 	}()
+ 	for {
+-		addMapping(m, protocol, extPort, intPort, name, publisher)
++		err := addMapping(m, protocol, extPort, intPort, name, publisher)
++		if err != nil {
++			log.Infof(""%s, Mapping for port %d failed: %s"", logPrefix, extPort, err)
++		} else {
++			log.Info(""%s, Mapped network port: %d"", logPrefix, extPort)
++		}
+ 		select {
+ 		case <-c:
+ 			return",Why we need another error printouts? We already have it inside addMapping..,I think this sho
+5528,"@@ -215,7 +215,7 @@ bool CoreChecks::ValidateFsOutputsAgainstDynamicRenderingRenderPass(SHADER_MODUL
+     const bool alpha_to_coverage_enabled = pipeline->create_info.graphics.pMultisampleState != NULL &&
+         pipeline->create_info.graphics.pMultisampleState->alphaToCoverageEnable == VK_TRUE;
+ 
+-    for (uint32_t location = 0; location < pipeline->rp_state->dynamic_rendering_pipeline_create_info.colorAttachmentCount; ++location) {
++    for (uint32_t location = 0; location < location_map.size(); ++location) {
+          const auto output = location_map[location].output;
+ 
+         if (!output && pipeline->attachments[location].colorWriteMask != 0) {","This LGTM, but I'm curious if this fixed a specific error you were hitting?","`location_map` is a `std::unordered_map<uint32_t, color_attachment_t>`, so you can use `for (const auto& location : location_map)`"
+5529,"@@ -181,7 +181,9 @@ func parseCgroupFromReader(r io.Reader) (map[string]string, error) {
+ 		}
+ 
+ 		for _, subs := range strings.Split(parts[1], "","") {
+-			cgroups[subs] = parts[2]
++			if subs != """" {
++				cgroups[subs] = parts[2]
++			}
+ 		}
+ 	}
+ 	if err := s.Err(); err != nil {","Actually we rely on this functionality in cgroup v2, where the subsystem is empty.","I don't think this is correct. If `parts[1]` is empty, then `parts[2]` will be `""""`."
+5530,"@@ -1,10 +1,12 @@
+-package core
++package core_test
+ 
+ import (
+ 	""testing""
+ 	""unsafe""
+ 
+ 	""github.com/google/go-cmp/cmp""
++
++	""go.opentelemetry.io/api/core""
+ 	""go.opentelemetry.io/api/registry""
+ )
+ ",suggestion: use `core` package name,Why is this needed?
+5531,"@@ -1354,7 +1354,7 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+ 
+     # TODO: enable doctests once we drop Spark 2.3.x (due to type coercion logic
+     #  when creating arrays)
+-    def transpose(self, limit: Optional[int] = 1000):
++    def transpose(self, limit: Optional[int] = get_option(""compute.max_rows"")):
+         """"""
+         Transpose index and columns.
+ ",I think we can entirely remove this `limit` parameter for now to be consistent with other APIs.,Why do we need this change?
+5532,"@@ -0,0 +1,9 @@
++from localstack.services.infra import start_moto_server
++from localstack import config
++
++
++def start_rg(port=None, asynchronous=False, update_listener=None):
++    port = port or config.PORT_RESOURCE_GROUPS
++
++    return start_moto_server('resource-groups', port, name='Resource Groups Tagging API',
++        asynchronous=asynchronous, update_listener=update_listener)",nit: `Resource Groups Tagging API` -> `Resource Groups API`,Can you add a docstring here explaining what this function does?
+5533,"@@ -5,10 +5,16 @@
+ package ecr
+ 
+ import (
++	""encoding/base64""
++	""errors""
+ 	""fmt""
+ 	""strings""
+ 
++	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/aws-sdk-go/aws/arn""
++	""github.com/aws/aws-sdk-go/aws/session""
++	""github.com/aws/aws-sdk-go/service/ecr""
++	""github.com/aws/aws-sdk-go/service/ecr/ecriface""
+ )
+ 
+ const (","This type of list + delete always make me a bit uneasy but guess there's no atomic way to do this...... Could you put a todo to retry the ""ClearRepository + delete repo"" flow a few times? Basically, imagine a new image is added right after we call `ListImages`, then `DeleteImages` will not delete that newly added image. Then the delete repo call will fail",Nit: This import should be grouped with the other ecr imports.
+5534,"@@ -1,5 +1,11 @@
+-define(['dom', 'scrollManager'], function (dom, scrollManager) {
+-    'use strict';
++/* eslint-disable indent */
++
++import dom from 'dom';
++import scrollManager from 'scrollManager';
++
++/* eslint-disable no-unused-expressions */
++'use strict';
++/* eslint-enable no-unused-expressions */
+ 
+     var scopes = [];
+     function pushScope(elem) {",You can remove this since ES6 modules are strict by default. And thanks for contributing to the Jellyfin Project.,Why are we disabling this?
+5535,"@@ -32,7 +32,7 @@ public class TransactionRLPDecoderTest {
+   private static final String FRONTIER_TX_RLP =
+       ""0xf901fc8032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b561ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
+   private static final String EIP1559_TX_RLP =
+-      ""0xf902028032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b5682020f8201711ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
++      ""0xb902060ff902028032830138808080b901ae60056013565b6101918061001d6000396000f35b3360008190555056006001600060e060020a6000350480630a874df61461003a57806341c0e1b514610058578063a02b161e14610066578063dbbdf0831461007757005b610045600435610149565b80600160a060020a031660005260206000f35b610060610161565b60006000f35b6100716004356100d4565b60006000f35b61008560043560243561008b565b60006000f35b600054600160a060020a031632600160a060020a031614156100ac576100b1565b6100d0565b8060018360005260205260406000208190555081600060005260206000a15b5050565b600054600160a060020a031633600160a060020a031614158015610118575033600160a060020a0316600182600052602052604060002054600160a060020a031614155b61012157610126565b610146565b600060018260005260205260406000208190555080600060005260206000a15b50565b60006001826000526020526040600020549050919050565b600054600160a060020a031633600160a060020a0316146101815761018f565b600054600160a060020a0316ff5b5682020f8201711ca0c5689ed1ad124753d54576dfb4b571465a41900a1dff4058d8adf16f752013d0a01221cbd70ec28c94a3b55ec771bcbc70778d6ee0b51ca7ea9514594c861b1884"";
+   private static final String GOQUORUM_PRIVATE_TX_RLP =
+       ""0xf88d0b808347b7608080b840290a80a37d198ff06abe189b638ff53ac8a8dc51a0aff07609d2aa75342783ae493b3e3c6b564c0eebe49284b05a0726fb33087b9e0231d349ea0c7b5661c8c526a07144db7045a395e608cda6ab051c86cc4fb42e319960b82087f3b26f0cbc3c2da00223ac129b22aec7a6c2ace3c3ef39c5eaaa54070fd82d8ee2140b0e70b1dca9"";
+ ",Why did eip1559 go from a list (0xf9020280.....) to a wrapped string (0xb902060ff9020280...) and not just concatenation (0x0ff9020280...)? implementation detail or is this how it sits on the wire now?,public static final String FRONTIER_TX_RLP =
+5536,"@@ -1334,9 +1334,9 @@ func TestConfigCheckIncludes(t *testing.T) {
+ 	if err == nil {
+ 		t.Errorf(""Expected error processing include files with configuration check enabled: %v"", err)
+ 	}
+-	expectedErr := errors.New(`configs/include_bad_conf_check_b.conf:10:19: unknown field ""monitoring_port""` + ""\n"")
+-	if err != nil && expectedErr != nil && err.Error() != expectedErr.Error() {
+-		t.Errorf(""Expected: \n%q, got\n: %q"", expectedErr.Error(), err.Error())
++	expectedErr := `include_bad_conf_check_b.conf:10:19: unknown field ""monitoring_port""` + ""\n""
++	if err != nil && !strings.HasSuffix(err.Error(), expectedErr) {
++		t.Errorf(""Expected: \n%q, got\n: %q"", expectedErr, err.Error())
+ 	}
+ }
+ ",@wallyqs Since on Windows it would be `\` instead of `/` I just look at the suffix past `configs/`. Let me know if that's ok or not.,Why is this change needed?
+5537,"@@ -1385,5 +1385,12 @@ func (a *WebAPI) GetInsightData(ctx context.Context, req *webservice.GetInsightD
+ 	return &webservice.GetInsightDataResponse{
+ 		UpdatedAt:  updateAt,
+ 		DataPoints: idp,
++		Type:       model.InsightResultType_MATRIX,
++		Matrix: []*model.InsightSampleStream{
++			{
++				Labels:     nil,
++				DataPoints: idp,
++			},
++		},
+ 	}, nil
+ }",nit: Remove this assignment because it is not necessary.,Why do we need this?
+5538,"@@ -217,7 +217,10 @@ ostree_builtin_summary (int argc, char **argv, GCancellable *cancellable, GError
+       if (opt_raw)
+         flags |= OSTREE_DUMP_RAW;
+ 
+-      summary_data = ot_file_mapat_bytes (repo->repo_dir_fd, ""summary"", error);
++      glnx_fd_close int fd = -1;
++      if (!glnx_openat_rdonly (repo->repo_dir_fd, ""summary"", TRUE, &fd, error))
++        return FALSE;
++      summary_data = ot_fd_readall_or_mmap (fd, 0, error);
+       if (!summary_data)
+         return FALSE;
+ ","This seems like a common enough pattern to offer an equivalent wrapper in `ot-fs-util.c`, no?",Shouldn't this be `ot_file
+5539,"@@ -328,6 +328,7 @@ public abstract class MediaplayerActivity extends CastEnabledActivity implements
+         boolean isItemHasDownloadLink = media != null && (media instanceof FeedMedia) && ((FeedMedia) media).getDownload_url() != null;
+         menu.findItem(R.id.share_download_url_item).setVisible(isItemHasDownloadLink);
+         menu.findItem(R.id.share_download_url_with_position_item).setVisible(isItemHasDownloadLink);
++        menu.findItem(R.id.share_file).setVisible(((FeedMedia) media).fileExists());
+ 
+         menu.findItem(R.id.share_item).setVisible(hasWebsiteLink || isItemAndHasLink || isItemHasDownloadLink);
+ ",Wouldn't this crash the app if the user is currently listening to a stream?,Shouldn't this be `isItemH
+5540,"@@ -530,10 +530,10 @@ type listFn func(remote string, object *swift.Object, isDirectory bool) error
+ //
+ // Set recurse to read sub directories
+ func (f *Fs) listContainerRoot(container, directory, prefix string, addContainer bool, recurse bool, fn listFn) error {
+-	if prefix != """" {
++	if prefix != """" && !strings.HasSuffix(prefix, ""/"") {
+ 		prefix += ""/""
+ 	}
+-	if directory != """" {
++	if directory != """" && !strings.HasSuffix(directory, ""/"") {
+ 		directory += ""/""
+ 	}
+ 	// Options for ObjectsWalk",This looks like an unrelated change? What is it for?,Why do we need this change?
+5541,"@@ -0,0 +1,7 @@
++package csv
++
++import ""sync/atomic""
++
++func (d *tableDecoder) IsDone() bool {
++	return d.empty || atomic.LoadInt32(&d.used) != 0
++}","Wait, what is this doing? Is this a way to create methods that are only accessible from tests?",Why do we need this?
+5542,"@@ -93,6 +93,11 @@ func (s *Service) list(c *gin.Context) {
+ 	name := c.Query(""name"")
+ 	ns := c.Query(""namespace"")
+ 
++	canList := utils.CanListChaos(c, ns)
++	if !canList {
++		return
++	}
++
+ 	metas, err := s.archive.ListMeta(context.Background(), kind, ns, name, true)
+ 	if err != nil {
+ 		c.Status(http.StatusInternalServerError)","Is it more reasonable to return some errors here, such as returning error codes (403 and so on?) ?",Shouldn't this be `!canList
+5543,"@@ -68,7 +68,11 @@ export function createVNode(type, props, key, ref) {
+ 		_parent: null,
+ 		_depth: 0,
+ 		_dom: null,
+-		_lastDomChild: null,
++		// _lastDomChildSibling must be initialized to undefined b/c it will eventually
++		// be set to dom.nextSibling which can return `null` and it is important
++		// to be able to distinguish between an uninitialized _lastDomChildSibling and
++		// a _lastDomChildSibling that has been set to `null`
++		_lastDomChildSibling: undefined,
+ 		_component: null,
+ 		constructor: undefined
+ 	};",Thinking out loud... would `_nextDom` be a better name for this?,I'm not sure if this is the
+5544,"@@ -165,11 +165,6 @@ class TestSuperfluousParentheses(CheckerTestCase):
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (foo):"", 0),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if ((foo, bar)):"", 0),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (foo(bar)):"", 0),
+-            (
+-                Message(""superfluous-parens"", line=1, args=""return""),
+-                ""return ((x for x in x))"",
+-                0,
+-            ),
+             (Message(""superfluous-parens"", line=1, args=""not""), ""not (foo)"", 0),
+             (Message(""superfluous-parens"", line=1, args=""not""), ""if not (foo):"", 1),
+             (Message(""superfluous-parens"", line=1, args=""if""), ""if (not (foo)):"", 0),",Turns out the unittests also had a false positive.,Why was this removed?
+5545,"@@ -24,12 +24,12 @@ namespace OpenTelemetry.Metrics
+     public abstract class Meter
+     {
+         /// <summary>
+-        /// Creates a counter for long with given name.
++        /// Creates a counter for Int64 with given name.
+         /// </summary>
+         /// <param name=""name"">The name of the counter.</param>
+         /// <param name=""monotonic"">indicates if only positive values are expected.</param>
+         /// <returns>The counter instance.</returns>
+-        public abstract Counter<long> CreateLongCounter(string name, bool monotonic = true);
++        public Counter<long> CreateInt64Counter(string name, bool monotonic = true) => this.CreateCounter<long>(name, monotonic);
+ 
+         /// <summary>
+         /// Creates a counter for double with given name.","I think these method names would be clearer if written as ""Create a {type} counter|gauge|measure with given name"". eg ""Create a int64 counter with given name"" ""Create a double gauge with given name""",Why do we need this c
+5546,"@@ -3530,7 +3530,7 @@ int LuaScriptInterface::luaDoChallengeCreature(lua_State* L)
+ int LuaScriptInterface::luaIsValidUID(lua_State* L)
+ {
+ 	//isValidUID(uid)
+-	pushBoolean(L, getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)) != nullptr);
++	pushBoolean(L, getScriptEnv()->getThingByUID(getNumber<uint32_t>(L, -1)));
+ 	return 1;
+ }
+ ","it pushes a boolean, so it has to be explicitly casted to boolean with != nullptr, same with all other similar stuff",`getNumber<uint32_t>(
+5547,"@@ -237,6 +237,7 @@ Publisher* ParticipantImpl::createPublisher(
+         delete(pubimpl);
+         return nullptr;
+     }
++    pubimpl->m_history.rebuild_instances();
+     pubimpl->mp_writer = writer;
+     //SAVE THE PUBLISHER PAIR
+     t_p_PublisherPair pubpair;",It would be nice to have an equivalent of this call on `DataWriterImpl::enable`,Why is this needed?
+5548,"@@ -1112,6 +1112,7 @@ func (a *PipedAPI) CreateDeploymentChain(ctx context.Context, req *pipedservice.
+ 				},
+ 			},
+ 		},
++		Status:    model.ChainBlockStatus_DEPLOYMENT_BLOCK_RUNNING,
+ 		StartedAt: time.Now().Unix(),
+ 	})
+ ",Isn't this PENDING?,Why do we need this?
+5549,"@@ -30,16 +30,14 @@ function isLandmark(virtualNode) {
+ 	var explictRole = (node.getAttribute('role') || '').trim().toLowerCase();
+ 
+ 	if (explictRole) {
+-		if (explictRole === 'form') {
+-			return !!aria.labelVirtual(virtualNode);
+-		}
+ 		return landmarkRoles.includes(explictRole);
+ 	} else {
+ 		// Check if the node matches any of the CSS selectors of implicit landmarks
+ 		return implicitLandmarks.some(implicitSelector => {
+ 			let matches = axe.utils.matchesSelector(node, implicitSelector);
+ 			if (node.tagName.toLowerCase() === 'form') {
+-				return matches && !!aria.labelVirtual(virtualNode);
++				let title = node.getAttribute('title') || '';
++				return matches && (!!aria.labelVirtual(virtualNode) || !!axe.commons.text.sanitize(title) );
+ 			}
+ 			return matches;
+ 		});","minor detail, why aim to sanitize title if tile is empty (in some cases)? worth adding an && to check for that.",I'm not sure if this
+5550,"@@ -28,9 +28,8 @@ package com.salesforce.androidsdk.smartsync.target;
+ 
+ import android.text.TextUtils;
+ 
+-import com.salesforce.androidsdk.smartstore.store.QuerySpec;
+-import com.salesforce.androidsdk.smartstore.store.SmartStore;
+ import com.salesforce.androidsdk.smartsync.manager.SyncManager;
++import com.salesforce.androidsdk.smartsync.target.ParentChildrenSyncTargetHelper.RelationshipType;
+ import com.salesforce.androidsdk.smartsync.util.ChildrenInfo;
+ import com.salesforce.androidsdk.smartsync.util.Constants;
+ import com.salesforce.androidsdk.smartsync.util.ParentInfo;",Code shared by ParentChildrenSyncDownTarget and ParentChildrenSyncUpTarget moved to ParentChildrenSyncTargetHelper,I don't think we nee
+5551,"@@ -75,12 +75,12 @@ class Local(Provisioning):
+     def startup(self):
+         self.start_time = time.time()
+ 
+-        self.available_slots = self.settings.get(""capacity"", None)
+-        if not self.available_slots:
+-            if self.settings.get(""sequential"", False):
+-                self.available_slots = 1
+-            else:
+-                self.available_slots = sys.maxsize      # no limit
++        if self.settings.get(""sequential"", False):
++            self.available_slots = 1
++        else:
++            self.available_slots = self.settings.get(""capacity"", None)
++            if not self.available_slots:
++                self.available_slots = sys.maxsize  # no limit
+ 
+         for executor in self.executors:
+             start_at = executor.execution.get('start-at', 0)","The bug is not about the priority , But we use 2 config items CAPACITY and SEQUENTIAL to control 1 action: thoughput. If 'sequential' is given to 'False' as default in configfile and then I use 'capacity' to 10 in my test.yml , the 'capacity' 's priority should be higher than default 'sequential'. So, I suggest we use only one 'capacity', it is enough. '1' is sequential, more than 1 is capacity, None is sys.maxsize.",Why did you change t
+5552,"@@ -9,10 +9,13 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ 
++	tf ""github.com/filecoin-project/go-filecoin/testhelpers/testflags""
+ 	mockplugin ""github.com/filecoin-project/go-filecoin/tools/iptb-plugins/filecoin/mock""
+ )
+ 
+ func TestStartLogCapture(t *testing.T) {
++	tf.IntegrationTest(t)
++
+ 	assert := assert.New(t)
+ 	require := require.New(t)
+ 	ctx := context.Background()","I don't know if I'd call any of these FAST tests integration tests. They are unit tests for FAST. They use a mock plugin which doesn't actually start any external processes, etc.",Why is this needed?
+5553,"@@ -27,10 +27,12 @@ const (
+ 	invalidVersion version = ""invalid.version""
+ )
+ 
++// CurrentVersion returns the version of the calling instance
+ func CurrentVersion() version {
+ 	return version(mver.GetVersion())
+ }
+ 
++// Version returns the version in version type if present
+ func Version(version string) version {
+ 	switch version {
+ 	case ""0.7.0"":",Can you provide corresponding UT for this.,I don't think we ne
+5554,"@@ -29,6 +29,8 @@ import (
+ 	""testing""
+ 	""time""
+ 
++	""golang.org/x/net/context""
++
+ 	""github.com/yarpc/yarpc-go/encoding/raw""
+ 	""github.com/yarpc/yarpc-go/transport""
+ 	""github.com/yarpc/yarpc-go/transport/transporttest""",nit: this should be below the yarpc group,"""github.com/stretch"
+5555,"@@ -44,6 +44,10 @@ func New(name, tip string, labelNames []string, defaultLabels []string) (*TimerF
+ 		labelNames,
+ 	)
+ 	err := prometheus.Register(vect)
++	switch err.(type) {
++	case prometheus.AlreadyRegisteredError:
++		err = nil
++	}
+ 
+ 	return &TimerFactory{
+ 		labelNames:    labelNames,",singleCaseSwitch: should rewrite switch statement to if statement (from `gocritic`),Why is this needed?
+5556,"@@ -442,7 +442,17 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			retry := 0
++			for err != nil && retry < 10 {
++				// Set Ready and Live to false
++				healthAggregator.Report(healthName, &health.HealthReport{Live: false, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Warn(""Retrying to start Typha"")
++				retry++
++			}
++			if err != nil && retry > 10 {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()","Please log once here at Error level ""Failed to connect to Typha, will retry...""",Shouldn't this be `<= 10`?
+5557,"@@ -31,7 +31,7 @@ func TestICMPPortUnreachable(t *testing.T) {
+ 	_, ipv4, _, _, pktBytes, err := testPacketUDPDefault()
+ 	Expect(err).NotTo(HaveOccurred())
+ 
+-	runBpfUnitTest(t, ""icmp_port_unreachable.c"", func(bpfrun bpfProgRunFn) {
++	runBpfUnitTest(t, ""icmp_port_unreachable.c"", false, func(bpfrun bpfProgRunFn) {
+ 		res, err := bpfrun(pktBytes)
+ 		Expect(err).NotTo(HaveOccurred())
+ 		Expect(res.Retval).To(Equal(0))","Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes.",Why is this change needed?
+5558,"@@ -6,11 +6,14 @@ from pyramid import httpexceptions
+ 
+ 
+ class NameGenerator(generators.Generator):
++    regexp = r'^[a-zA-Z0-9][a-zA-Z0-9_-]*$'
++
+     def __call__(self):
+         ascii_letters = ('abcdefghijklmopqrstuvwxyz'
+                          'ABCDEFGHIJKLMOPQRSTUVWXYZ')
+-        alphabet = ascii_letters + string.digits + '-'
+-        letters = [random.choice(alphabet) for x in range(8)]
++        alphabet = ascii_letters + string.digits + '-_'
++        letters = [random.choice(ascii_letters + string.digits)]
++        letters += [random.choice(alphabet) for x in range(7)]
+         return ''.join(letters)
+ 
+ ",So we fix it only for kinto and not for all cliquet resources?,Why did you change this?
+5559,"@@ -11,9 +11,10 @@ import (
+ 	""fmt""
+ 	""math/big""
+ 
+-	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ 	""github.com/pkg/errors""
+ 
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
++
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""",No empty line between,nit: remove empty line
+5560,"@@ -141,6 +141,9 @@ func main() {
+ 				fatal(err)
+ 			}
+ 		}
++		if err := reviseRootDir(context); err != nil {
++			return err
++		}
+ 		return logs.ConfigureLogging(createLogConfig(context))
+ 	}
+ ",We have `ResolveRootfs` in `libcontainer/utils` so maybe use that one here?,Why do we need this?
+5561,"@@ -630,6 +630,19 @@ namespace AutoRest.Swagger.Tests
+             messages.AssertOnlyValidationMessage(typeof(SummaryAndDescriptionMustNotBeSame), 1);
+         }
+ 
++        [Fact]
++        public void LongRunningHasExtensionValidation()
++        {
++            var messages = ValidateSwagger(Path.Combine(Core.Utilities.Extensions.CodeBaseDirectory, ""Resource"", ""Swagger"", ""Validation"", ""long-running-operation-extension.json""));
++            messages.AssertOnlyValidationMessage(typeof(LongRunningOperationsWithLongRunningExtension), 1);
++        }
++
++        [Fact]
++        public void LongRunningHasExtensionTrueValidation()
++        {
++            var messages = ValidateSwagger(Path.Combine(Core.Utilities.Extensions.CodeBaseDirectory, ""Resource"", ""Swagger"", ""Validation"", ""long-running-operation-extension-2.json""));
++            messages.AssertOnlyValidationMessage(typeof(LongRunningOperationsWithLongRunningExtension), 1);
++        }
+     }
+ 
+     #region Positive tests","Just curious, do we have positive test covered somewhere?",Nit: I think it woul
+5562,"@@ -101,7 +101,7 @@ static void move_resize(struct roots_view *view, double x, double y,
+ 		constrained_height);
+ 	if (serial > 0) {
+ 		roots_surface->pending_move_resize_configure_serial = serial;
+-	} else {
++	} else if(roots_surface->pending_move_resize_configure_serial == 0) {
+ 		view->x = x;
+ 		view->y = y;
+ 	}","Style error, put a space between `if` and `(`",This should be `else
+5563,"@@ -239,6 +239,13 @@ type Config struct {
+ 	//    	Key: aws.String(""/foo/bar/moo""),
+ 	//    })
+ 	EnableEndpointDiscovery *bool
++
++	// DisableEndpointHostPrefix will disable the SDK's behavior of prefixing
++	// request endpoint hosts with modeled information.
++	//
++	// Disabling this feature is useful when you want to use local endpoints
++	// for testing that do not support the modeled host prefix pattern.
++	DisableEndpointHostPrefix *bool
+ }
+ 
+ // NewConfig returns a new Config pointer that can be chained with builder","It's a bit odd to have a ""disable<x>"" boolean, though it looks like you already do that for a few other flags.",I'm not sure if this
+5564,"@@ -47,6 +47,7 @@ const (
+ // Timelimits for docker operations enforced above docker
+ const (
+ 	pullImageTimeout        = 2 * time.Hour
++	loadImageTimeout        = 2 * time.Hour
+ 	createContainerTimeout  = 3 * time.Minute
+ 	startContainerTimeout   = 1*time.Minute + 30*time.Second
+ 	stopContainerTimeout    = 1 * time.Minute",Why did you pick two hours for this?,Why is this change needed?
+5565,"@@ -110,8 +110,8 @@ func getNewPassword(gopts GlobalOptions) (string, error) {
+ 	newopts.password = """"
+ 
+ 	return ReadPasswordTwice(newopts,
+-		""enter password for new key: "",
+-		""enter password again: "")
++		""enter password (new): "",
++		""enter password (again): "")
+ }
+ 
+ func addKey(gopts GlobalOptions, repo *repository.Repository) error {","What about ""enter new password""? That would be a bit more consistent to the `ReadPasswordTwice` usage in cmd_init.",Why did you remove the wor
+5566,"@@ -20,7 +20,7 @@ if not versionInfo.updateVersionType:
+ 	raise RuntimeError(""No update version type, update checking not supported"")
+ import addonAPIVersion
+ # Avoid a E402 'module level import not at top of file' warning, because several checks are performed above.
+-from gui.contextHelp import ContextHelpMixin  # noqa: E402
++import gui.contextHelp  # noqa: E402
+ from gui.dpiScalingHelper import DpiScalingHelperMixin, DpiScalingHelperMixinWithoutInit  # noqa: E402
+ import winVersion
+ import os",Another redundant import,Why did you remove the mix
+5567,"@@ -120,7 +120,7 @@ func (c *client) FetchUpdates(ctx context.Context, req *node.FetchX509SVIDReques
+ 	// Close the stream whether there was an error or not
+ 	stream.CloseSend()
+ 	if err != nil {
+-		// TODO: should we try to create a new stream?
++		c.Release()
+ 		return nil, err
+ 	}
+ ","What kind of errors might cause us to reach this point? Could any of them be recoverable i.e. might work if we asked the same server again? Similar question for below, but perhaps with a slightly different answer",Why do we need to do this?
+5568,"@@ -212,14 +212,14 @@ public:
+ 
+ class triangle_counting_test {
+ public:
+-    using my_graph_type = dal::preview::undirected_adjacency_vector_graph<>;
++    using graph_type = dal::preview::undirected_adjacency_vector_graph<>;
+ 
+     template <typename GraphType>
+     auto create_graph() {
+         GraphType graph_data;
+-        my_graph_type my_graph;
++        graph_type graph;
+ 
+-        auto &graph_impl = oneapi::dal::detail::get_impl(my_graph);
++        auto &graph_impl = oneapi::dal::detail::get_impl(graph);
+         auto &vertex_allocator = graph_impl._vertex_allocator;
+         auto &edge_allocator = graph_impl._edge_allocator;
+ ",What is the difference between GraphType and graph_type. Naming should be more accurate.,dal::detail::get_impl(graph)  graph_type graph;
+5569,"@@ -9,7 +9,7 @@ use Shopsys\FrameworkBundle\Model\Product\Product;
+ class UnitRepository
+ {
+     /**
+-     * @var \Doctrine\ORM\EntityRepository
++     * @var \Doctrine\ORM\EntityManagerInterface
+      */
+     protected $em;
+ ",hmmm in docblock of contructor it is EntityManagerInterface....maybe it should be that way.... :confused:,This should be reverted.
+5570,"@@ -54,8 +54,13 @@ struct feat_wrapper {
+         .def(""GetPos"",
+              (RDGeom::Point3D(MolChemicalFeature::*)(int) const) &
+                  MolChemicalFeature::getPos,
+-             (python::arg(""self""), python::arg(""confId"") = -1),
++             (python::arg(""self""), python::arg(""confId"")),
+              ""Get the location of the chemical feature"")
++        .def(""GetPosDefault"",
++             (RDGeom::Point3D(MolChemicalFeature::*)() const) &
++                 MolChemicalFeature::getPos,
++             python::arg(""self""),
++             ""Get the location of the default chemical feature (first position)"")
+         .def(""GetAtomIds"", getFeatAtomIds,
+              ""Get the IDs of the atoms that participate in the feature"")
+         .def(""GetMol"", &MolChemicalFeature::getMol,","I'm curious why you went the route of adding a new method name for this. Given that you it would be possible to just have an an overload of `GetPos()`, and that this change breaks existing code, I wonder why you chose to go this way.","I think this should be ""GetDefaultPos"""
+5571,"@@ -33,12 +33,14 @@ export default Component.extend({
+         let subscriptions = this.member.get('stripe');
+         if (subscriptions && subscriptions.length > 0) {
+             return subscriptions.map((subscription) => {
++                const statusLabel = subscription.status === 'past_due' ? 'Past due' : subscription.status;
+                 return {
+                     id: subscription.id,
+                     customer: subscription.customer,
+                     name: subscription.name || '',
+                     email: subscription.email || '',
+                     status: subscription.status,
++                    statusLabel: statusLabel,
+                     startDate: subscription.start_date ? moment(subscription.start_date).format('D MMM YYYY') : '-',
+                     plan: subscription.plan,
+                     amount: parseInt(subscription.plan.amount) ? (subscription.plan.amount / 100) : 0,",Does this need to change `'active'` to `'Active'` and that? Or is that done in CSS or something?,I don't think this is the right way to do this.
+5572,"@@ -11,6 +11,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+     public class Http2Limits
+     {
+         private int _maxStreamsPerConnection = 100;
++        private int _headerTableSize = MaxAllowedHeaderTableSize;
++        private int _maxFrameSize = MinAllowedMaxFrameSize;
++
++        // These are limits defined by the RFC https://tools.ietf.org/html/rfc7540#section-4.2
++        public const int MaxAllowedHeaderTableSize = 4096;
++        public const int MinAllowedMaxFrameSize = 16 * 1024;
++        public const int MaxAllowedMaxFrameSize = 16 * 1024 * 1024 - 1;
+ 
+         /// <summary>
+         /// Limits the number of concurrent request streams per HTTP/2 connection. Excess streams will be refused.",Why are these constants public? They should also be listed above members.,Nit: I think it would be better to use `private const int MaxAllowedHeaderTableSize = 4096;`
+5573,"@@ -217,6 +217,8 @@ public class MainnetTransactionValidator {
+     // org.bouncycastle.math.ec.ECCurve.AbstractFp.decompressPoint throws an
+     // IllegalArgumentException for ""Invalid point compression"" for bad signatures.
+     try {
++      // TODO: this is where we are checking the signature. We have to fix the v value if this is a
++      // private transaction
+       transaction.getSender();
+     } catch (final IllegalArgumentException e) {
+       return ValidationResult.invalid(",This TODO isn't related to this change. We should remove it.,I don't think this is the right place to fix the v value. It should be in a separate commit.
+5574,"@@ -27,7 +27,5 @@ import org.apache.iceberg.FieldMetrics;
+ public interface ValueWriter<D> {
+   void write(D datum, Encoder encoder) throws IOException;
+ 
+-  default Stream<FieldMetrics> metrics() {
+-    return Stream.empty(); // TODO will populate in following PRs
+-  }
++  Stream<FieldMetrics> metrics();
+ }","`FieldMetrics` is parameterized, but this is a bare reference. Could you update it? I think it should be `FieldMetrics<?>` since the metrics are not necessarily for the written value type, `D`.",Why is this change needed?
+5575,"@@ -58,12 +58,11 @@ namespace Examples.Console
+             // Application which decides to enable OpenTelemetry metrics
+             // would setup a MeterProvider and make it default.
+             // All meters from this factory will be configured with the common processing pipeline.
+-            MeterProvider.SetDefault(Sdk.CreateMeterProvider(mb =>
+-            {
+-                mb.SetMetricProcessor(processor);
+-                mb.SetMetricExporter(promExporter);
+-                mb.SetMetricPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs));
+-            }));
++            MeterProvider.SetDefault(Sdk.CreateMeterProviderBuilder()
++                .SetProcessor(processor)
++                .SetExporter(promExporter)
++                .SetPushInterval(TimeSpan.FromSeconds(pushIntervalInSecs))
++                .Build());
+ 
+             // The following shows how libraries would obtain a MeterProvider.
+             // MeterProvider is the entry point, which provides Meter.",@cijothomas do we want this to be `Set` or `Add`?,Why is this change needed?
+5576,"@@ -42,7 +42,7 @@ namespace Nethermind.JsonRpc
+         public string? IpcUnixDomainSocketPath { get; set; } = null;
+ 
+         public string[] EnabledModules { get; set; } = ModuleType.DefaultModules.ToArray();
+-        public long? GasCap { get; set; } = 100000000;
++        public long? GasCap { get; set; } = 50000000;
+         public int ReportIntervalSeconds { get; set; } = 300;
+         public bool BufferResponses { get; set; }
+         public string CallsFilterFilePath { get; set; } = ""Data/jsonrpc.filter"";",Why are we dropping GasCap?,Why was this changed?
+5577,"@@ -45,11 +45,11 @@ namespace OpenTelemetry.Shims.OpenTracing
+ 
+         public SpanShim(TelemetrySpan span)
+         {
+-            this.Span = span ?? throw new ArgumentNullException(nameof(span));
++            this.Span = span ?? throw new ArgumentNullException(nameof(span), ""Parameter cannot be null"");
+ 
+             if (!this.Span.Context.IsValid)
+             {
+-                throw new ArgumentException(nameof(this.Span.Context));
++                throw new ArgumentException(""Passed span's context is not valid"", nameof(this.Span.Context));
+             }
+ 
+             this.spanContextShim = new SpanContextShim(this.Span.Context);",should we end the text with a .?,"nit: ""Passed span's c"
+5578,"@@ -752,9 +752,10 @@ dispatch_enter_dynamorio(dcontext_t *dcontext)
+            wherewasi == DR_WHERE_APP ||
+            /* If the thread was waiting at check_wait_at_safe_point when getting
+             * suspended, we were in dispatch (ref i#3427). We will be here after the
+-            * thread's context is being reset before sending it native.
++            * thread's context is being reset proactively (due to some -reset_at_*
++            * option) or before sending it native.
+             */
+-           (dcontext->go_native && wherewasi == DR_WHERE_DISPATCH));
++           wherewasi == DR_WHERE_DISPATCH);
+     dcontext->whereami = DR_WHERE_DISPATCH;
+     ASSERT_LOCAL_HEAP_UNPROTECTED(dcontext);
+     ASSERT(check_should_be_protected(DATASEC_RARELY_PROT));","Could this instead keep the `go_native` and add to it ""or the last exit was the special reset exit""?",I don't think this is
+5579,"@@ -42,9 +42,9 @@ ConfigPanelDialog::ConfigPanelDialog(LXQtPanel *panel, QWidget *parent):
+     addPage(mPluginsPage, tr(""Widgets""), QLatin1String(""preferences-plugin""));
+     connect(this, &ConfigPanelDialog::reset, mPluginsPage, &ConfigPluginsWidget::reset);
+ 
+-    connect(this, &ConfigPanelDialog::accepted, [panel] {
++    connect(this, &ConfigPanelDialog::accepted, this, [panel] {
+         panel->saveSettings();
+-   });
++    });
+ }
+ 
+ void ConfigPanelDialog::showConfigPanelPage()","Oh, I missed this one: The other instances of `this` you've added as lambda contexts aren't really needed, although they're harmless. However, in the above connection, the missing context is `panel`, not `this`. Please correct it! Clazy may show warnings about lambda contexts (I don't use Clazy) but, if so, that's a problem in clazy: it isn't smart enough to know about them.",I don't think this ch
+5580,"@@ -160,14 +160,9 @@ class Service(object):
+                     except AttributeError:
+                         pass
+                 self.process.terminate()
+-                self.process.kill()
+                 self.process.wait()
++                self.process.kill()
+                 self.process = None
+         except OSError:
+             # kill may not be available under windows environment
+             pass
+-
+-    def __del__(self):
+-        # subprocess.Popen doesn't send signal on __del__;
+-        # we have to try to stop the launched process.
+-        self.stop()",can we add a try / except around this to make it more stable? I like the idea of any mistakenly un-quit drivers closing down after the process is quit (the java server does this... also i forget to do driver.quit often when i use the command line repl :) ),Why is this removed?
+5581,"@@ -68,9 +68,12 @@ func (vd *volAPI) cloudMigrateStatus(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
+-	if err := json.NewDecoder(r.Body).Decode(statusReq); err != nil {
+-		vd.sendError(vd.name, method, w, err.Error(), http.StatusBadRequest)
+-		return
++	// Use empty request if nothing was sent
++	if r.ContentLength != 0 {
++		if err := json.NewDecoder(r.Body).Decode(statusReq); err != nil {
++			vd.sendError(vd.name, method, w, err.Error(), http.StatusBadRequest)
++			return
++		}
+ 	}
+ 
+ 	statusResp, err := d.CloudMigrateStatus(statusReq)",when would this happen? backward compatibility?,Why do we need this 
+5582,"@@ -0,0 +1,13 @@
++/**
++ * Returns the tagName,
++ * if it is a HTMLElement it gets lowercased
++ * @param  {Element} node element
++ * @return {String}       normalized tagName
++ */
++axe.utils.getTagName = function(node) {
++	if (node.namespaceURI === 'http://www.w3.org/1999/xhtml') {
++		return node.tagName.toLowerCase();
++	}
++
++	return node.tagName;
++};",I'm not sure what the value of this is. So far we've solved this by always doing `tagName.toUpperCase()` for everything. I think we should stick with this.,I'm not sure if this
+5583,"@@ -25,6 +25,16 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+ 
++var (
++	snapshotListCommandHelpText = `
++Usage: mayactl snapshot list [options]
++
++$ mayactl snapshot list --volname <vol>
++
++This command displays status of available snapshot.
++`
++)
++
+ // NewCmdSnapshotCreate creates a snapshot of OpenEBS Volume
+ func NewCmdSnapshotList() *cobra.Command {
+ 	options := CmdSnaphotCreateOptions{}",This command displays available snapshots on a volume.,This should be `maya
+5584,"@@ -38,7 +38,7 @@ import (
+ 	""golang.org/x/tools/go/types/typeutil""
+ 
+ 	cpb ""kythe.io/kythe/proto/common_go_proto""
+-	spb ""kythe.io/kythe/proto/storage_go_proto""
++	stpb ""kythe.io/kythe/proto/storage_go_proto""
+ )
+ 
+ // EmitOptions control the behaviour of the Emit function. A nil options",`spb` is the standard package name we use for this proto.,Why do we need this change?
+5585,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change.",I think this should be `par
+5586,"@@ -369,8 +369,8 @@ func msgToApplication(msg model.Message) (*Application, error) {
+ 	return app, nil
+ }
+ 
+-// TODO: upgrade to parallel process
+ // Process translate msg to application , process and send resp to edge
++// TODO: upgrade to parallel process
+ func (c *Center) Process(msg model.Message) {
+ 	app, err := msgToApplication(msg)
+ 	if err != nil {",is this pr support parallelly process application?,Why do we need this TODO?
+5587,"@@ -48,7 +48,9 @@ func MustEnableIssues(ctx *middleware.Context) {
+ }
+ 
+ func MustEnablePulls(ctx *middleware.Context) {
+-	if !ctx.Repo.Repository.EnablePulls {
++	if !ctx.Repo.Repository.CanEnablePulls() {
++		ctx.Handle(404, ""Unsupported"", nil)
++	} else if !ctx.Repo.Repository.EnablePulls {
+ 		ctx.Handle(404, ""MustEnablePulls"", nil)
+ 	}
+ ","Based on the assumption that when `EnablePulls` is `true`, `CanEnablePulls` must be `true` as well, then this `if` check is redundant. Actually... we have `AllowsPulls` now... why not use that?",Shouldn't this be `MustEnab
+5588,"@@ -637,7 +637,7 @@ public class ScheduleServlet extends LoginAbstractAzkabanServlet {
+     if (flow == null) {
+       ret.put(""status"", ""error"");
+       ret.put(""message"", ""Flow "" + flowName + "" cannot be found in project ""
+-          + project);
++          + projectName);
+       return;
+     }
+ ",I am not sure why the API requires both project name and project ID as inputs. Wouldn't it introduce more opportunities for clients to make mistakes?,I think this should be `projectName`
+5589,"@@ -15,7 +15,7 @@ module Ncr
+ 
+     def edit
+       if self.proposal.approved?
+-        flash[:warning] = ""You are about to modify a fully approved request. Changes will be logged and sent to approvers, and this request may require re-approval, depending on the change.""
++        flash.now[:warning] = ""You are about to modify a fully approved request. Changes will be logged and sent to approvers, and this request may require re-approval, depending on the change.""
+       end
+ 
+       super","I believe this was happening for several different flash messages - should we add `now` to all flash messages? (there might be a downside to doing that, but I am not sure what it would be)",Line is too long. [81/80]
+5590,"@@ -46,6 +46,9 @@ class ExceptionListener extends BaseExceptionListener
+         parent::__construct($controller, $logger);
+     }
+ 
++    /**
++     * {@inheritdoc}
++     */
+     public function onKernelException(GetResponseForExceptionEvent $event)
+     {
+         $exception = $event->getException();","There is no docblock on the parent method. Also, not related, but I forgot to typehint the `$templating` constructor argument above.",This should be reverted.
+5591,"@@ -669,6 +669,12 @@ func TestDdevXdebugEnabled(t *testing.T) {
+ 	runTime := util.TimeTrack(time.Now(), fmt.Sprintf(""%s %s"", site.Name, t.Name()))
+ 
+ 	phpVersions := nodeps.ValidPHPVersions
++
++	// arm64 builds from deb.sury.org do not have xdebug in php5.6
++	if runtime.GOARCH == ""arm64"" {
++		t.Log(""Skipping php5.6 test on arm64 because deb.sury.org packages do not include it currently"")
++		delete(phpVersions, ""5.6"")
++	}
+ 	phpKeys := make([]string, 0, len(phpVersions))
+ 	for k := range phpVersions {
+ 		phpKeys = append(phpKeys, k)","Silly me. This shouldn't be done in the tests, but instead in the actual definition of ValidPHPVersions on arm64. Same with Mysql and MariaDB.",I don't think this is the right plac
+5592,"@@ -42,7 +42,8 @@ final class LatLonShapeBoundingBoxQuery extends ShapeQuery {
+   @Override
+   protected Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
+                                             int maxXOffset, int maxYOffset, byte[] maxTriangle) {
+-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
++    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
++        queryRelation == QueryRelation.INTERSECTS);
+   }
+ 
+   /** returns true if the query matches the encoded triangle */",Shouldn't this work as well for Disjoint?,I'm not sure if this is the right way to do this. I think it would be better to have a method that takes a query relation and returns a boolean.
+5593,"@@ -514,11 +514,11 @@ func (c *controller) finalizeOrder(ctx context.Context, cl acmecl.Interface, o *
+ 	// if it is already in the 'valid' state, as upon retry we will
+ 	// then retrieve the Certificate resource.
+ 	_, errUpdate := c.updateOrderStatus(ctx, cl, o)
+-	if acmeErr, ok := err.(*acmeapi.Error); ok {
++	if acmeErr, ok := errUpdate.(*acmeapi.Error); ok {
+ 		if acmeErr.StatusCode >= 400 && acmeErr.StatusCode < 500 {
+ 			log.Error(err, ""failed to update Order status due to a 4xx error, marking Order as failed"")
+ 			c.setOrderState(&o.Status, string(cmacme.Errored))
+-			o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", err)
++			o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", errUpdate)
+ 			return nil
+ 		}
+ 	}","You've not updated the `o.Status.Reason = fmt.Sprintf(""Failed to retrieve Order resource: %v"", err)` line below here when you changed this, so here we are checking `errUpdate` but will print the contents of `err` instead.",Shouldn't this be `err`?
+5594,"@@ -23,6 +23,9 @@ require 'socket'
+ module Selenium
+   module WebDriver
+     class SocketPoller
++      NOT_CONNECTED_ERRORS = [Errno::ECONNREFUSED, Errno::ENOTCONN, SocketError]
++      NOT_CONNECTED_ERRORS << Errno::EPERM if Platform.cygwin?
++
+       def initialize(host, port, timeout = 0, interval = 0.25)
+         @host     = host
+         @port     = Integer(port)",Doesn't this need to include `Errno::ECONNRESET` to fix the issue?,Why is this needed?
+5595,"@@ -301,6 +301,9 @@ public class Constants {
+     public static final String PROJECT_CACHE_SIZE_PERCENTAGE = ""azkaban""
+         + "".project_cache_size_percentage_of_disk"";
+ 
++    public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = ""azkaban""
++        + "".project_cache_throttle_percentage"";
++
+     // how many older versions of project files are kept in DB before deleting them
+     public static final String PROJECT_VERSION_RETENTION = ""project.version.retention"";
+ ","Please consider keeping the config key in one line as it will help in case someone is looking at how this config is used. public static final String PROJECT_CACHE_THROTTLE_PERCENTAGE = ""azkaban.project_cache_throttle_percentage"";",This should be `project.cache.throttle.percentage`
+5596,"@@ -46,6 +46,7 @@ type DataStore interface {
+ 
+ 	ListParentIDEntries(request *ListParentIDEntriesRequest) (*ListParentIDEntriesResponse, error)
+ 	ListSelectorEntries(request *ListSelectorEntriesRequest) (*ListSelectorEntriesResponse, error)
++	ListPowerSelectorEntries(request *ListSelectorEntriesRequest) (*ListSelectorEntriesResponse, error)
+ 	ListSpiffeEntries(request *ListSpiffeEntriesRequest) (*ListSpiffeEntriesResponse, error)
+ 
+ 	RegisterToken(request *JoinToken) (*common.Empty, error)","This is a hard one, naming-wise... `ListPowerSelectorEntries` is logical given `ListSelectorEntries`. Another option could be `ListMatchingEntries` or even `FindMatchingEntries`. :shrug:",This should be `ListPowerSelectorEntries`
+5597,"@@ -0,0 +1,4 @@
++package types
++
++// UVarint represent a 32-bit number encoded as varint.
++type UVarint uint",This should be called `Uint` or `Uint32` or simply using our `Uint64` type instead. All of our numbers have varint encoding. It's not inherently a varint.,Why do we need this type?
+5598,"@@ -1513,7 +1513,8 @@ class CommandDispatcher:
+             )
+ 
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+-    def view_source(self, edit=False):
++    @cmdutils.argument('pygment')
++    def view_source(self, edit=False, pygment=False):
+         """"""Show the source of the current page in a new tab.
+ 
+         Args:",No need for this when you don't need to customize anything about the argument.,This should be `pygment=True`
+5599,"@@ -0,0 +1,14 @@
++<!-- TODO: Move this away from using ID attr -->
++<div class=""panel-group section-group""
++     data-modifiable=""<%= modifiable %>""
++     id=""sections_accordion""
++     role=""tablist"">
++  <% sections.each do |section| %>
++    <%= render partial: ""org_admin/sections/section"",
++               object: section,
++               locals: { phase: phase,
++                         template: template,
++                         current_section: current_section,
++                         draggable: section == sections.first } %>
++  <% end%>
++</div>",We're now going to have 3 `#sections_accordion` will need to see how JS behaves. We should probably switch to a class selector instead,I think this should be `<%= modifiable %>
+5600,"@@ -0,0 +1,10 @@
++class CreateTestClientRequests < ActiveRecord::Migration
++  def change
++    create_table :test_client_requests do |t|
++      t.decimal :amount
++      t.string :project_title
++
++      t.timestamps null: false
++    end
++  end
++end",did you mean to leave this in here?,"I'm not sure if this is the best way to do this, but I'm not sure how to do it."
+5601,"@@ -54,6 +54,7 @@ var (
+ 	labels               = flag.String(""labels"", """", ""List of label KEY=VALUE pairs to add. Keys must start with a lowercase character and contain only hyphens (-), underscores (_), lowercase characters, and numbers. Values must contain only hyphens (-), underscores (_), lowercase characters, and numbers."")
+ 	storageLocation      = flag.String(""storage_location"", """", ""Location for the imported image which can be any GCS location. If the location parameter is not included, images are created in the multi-region associated with the source disk, image, snapshot or GCS bucket."")
+ 	uefiCompatible       = flag.Bool(""uefi_compatible"", false, ""Enables UEFI booting, which is an alternative system boot method. Most public images use the GRUB bootloader as their primary boot method."")
++	sysprepWindows       = flag.Bool(""sysprep_windows"", false, ""Whether to generalize image using Windows Sysprep."")
+ )
+ 
+ func importEntry() (*daisy.Workflow, error) {","Mention that it only applies to Windows. This is kind of implied, but better to be explicit.",I think this should be `sysprep_linux`
+5602,"@@ -28,6 +28,8 @@ var (
+ 	autoStake  = true
+ 	index      = uint64(10)
+ 	senderKey  = identityset.PrivateKey(27)
++	zero       = ""0""
++	negtive    = ""-10""
+ )
+ 
+ func TestCreateStake(t *testing.T) {",again: it is a bad practice to have some global parameters with such common names for unit test purpose.,nit: typo in `negtive`
+5603,"@@ -21,10 +21,7 @@ class Shopware6Connector
+ 
+     private ?string $token;
+ 
+-    /**
+-     * @var \DateTimeInterface
+-     */
+-    private $expiresAt;
++    private \DateTimeInterface $expiresAt;
+ 
+     public function __construct(Configurator $configurator)
+     {",Should we use `\DateTimeInterface` or `DateTimeInterface` and declaration of `DateTimeInterface` in `use`?,This should be reverted.
+5604,"@@ -7,11 +7,15 @@ import (
+ 	""errors""
+ 	""fmt""
+ 
++	""github.com/aws/aws-sdk-go/aws""
+ 	""github.com/aws/copilot-cli/internal/pkg/aws/cloudformation""
+ 	""github.com/aws/copilot-cli/internal/pkg/deploy""
++
+ 	""github.com/aws/copilot-cli/internal/pkg/deploy/cloudformation/stack""
+ )
+ 
++const taskStackPrefix = ""task-""
++
+ // DeployTask deploys a task stack and waits until the deployment is done.
+ // If the task stack doesn't exist, then it creates the stack.
+ // If the task stack already exists, it updates the stack.",What do you think of moving this stack related constant to the `stack` pkg?,Why is this needed?
+5605,"@@ -100,6 +100,9 @@ func TxnPool(s *transactions.SignedTxn, ctx Context, verificationPool execpool.B
+ 	if s.Txn.Src() == zeroAddress {
+ 		return errors.New(""empty address"")
+ 	}
++	if !proto.SupportRekeying && (s.AuthAddr != basics.Address{}) {
++		return errors.New(""nonempty AuthAddr but rekeying not supported"")
++	}
+ 
+ 	outCh := make(chan error, 1)
+ 	cx := asyncVerifyContext{s: s, outCh: outCh, ctx: &ctx}","Hm, I guess that you're doing this here since `WellFormed` is on a `transactions.Transaction` and not a `transactions.SignedTxn`, but quickly grepping through our code, it looks like we always a `SignedTxn` around when calling `WellFormed` (except maybe some tests?)... this doesn't have to happen here, but maybe we should update that in a separate PR since this really feels like a `WellFormed` check.",I think this should
+5606,"@@ -39,4 +39,6 @@ storiesOf( 'Global', module )
+ 				<ModulesList />
+ 			</WithTestRegistry>
+ 		);
++	}, {
++		padding: 0,
+ 	} );",This story also needs the default padding.,Why do we need this
+5607,"@@ -745,7 +745,7 @@ public class MockDirectoryWrapper extends BaseDirectoryWrapper {
+       maybeThrowDeterministicException();
+     }
+     if (!LuceneTestCase.slowFileExists(in, name)) {
+-      throw randomState.nextBoolean() ? new FileNotFoundException(name + "" in dir="" + in) : new NoSuchFileException(name + "" in dir="" + in);
++      throw new NoSuchFileException(name + "" in dir="" + in);
+     }
+ 
+     // cannot open a file for input if it's still open for output.",Hmm why did we remove the randomness about which (confusingly) different exception to throw here? This randomness was (is?) useful to help test that Lucene indeed catches `FNFE` and `NSFE` interchangeably.,Why did you remove 
+5608,"@@ -1215,10 +1215,10 @@ ostree_repo_list_collection_refs (OstreeRepo                 *self,
+                   continue;
+                 }
+ 
+-              if (match_collection_id != NULL && g_strcmp0 (match_collection_id, current_collection_id) != 0)
++              if (match_collection_id != NULL && g_strcmp0 (match_collection_id, remote_collection_id) != 0)
+                 continue;
+               else
+-                  current_collection_id = remote_collection_id;
++                current_collection_id = remote_collection_id;
+             }
+ 
+           if (!glnx_opendirat (dfd_iter.fd, dent->d_name, TRUE, &subdir_fd, error))","Hm, so before in that case `current_collection_id` looks like it was actually an uninitialized pointer. It seems weird to me that the tests pass both ways. I haven't looked closely at the tests - is there something wrong there that causes this to spuriously pass before?",Why this change?
+5609,"@@ -46,9 +46,13 @@
+  * If you will separate the definitions for the parsers, you must revise the
+  * code related to the symbol table. */
+ typedef enum {
+-	K_IGNORE = -2,
+-	K_UNDEFINED,
+-	K_CONSTANT,
++	/* parser private items */
++	K_IGNORE = -16,
++	K_DEFINE,
++
++	K_UNDEFINED = KEYWORD_NONE,
++	/* the followings items are also used as indices for VerilogKinds[] and SystemVerilogKinds[] */
++	K_CONSTANT= 0,
+ 	K_EVENT,
+ 	K_FUNCTION,
+ 	K_MODULE,","s it the best way to tag ""foo"" of ""`define foo ..."" with constant kind? Introducing ""d/definition"" kind and tagging the ""foo"" with the definition kind is an alternative way. Using the unified kind ""constant"" in many areas reduces the information that client tools get from a tags file. In my experience, it is better to tag different things with different kinds. If ctags hides the differences, and just reports various language objects as ""constant,"" in some cases, a client tool must parse the raw .sv source file for distinguishing whether a given tag is ""`define""'ed or not. IMHO, ctags should not be too smart. Instead, ctags should be stupid; it should report what it sees in source input files as-is to client tools that will do something smart.",Why is this need
+5610,"@@ -213,7 +213,6 @@ const CASE_TRANSLATION = {
+   tlscafile: 'tlsCAFile',
+   tlscertificatekeyfile: 'tlsCertificateKeyFile',
+   tlscertificatekeyfilepassword: 'tlsCertificateKeyFilePassword',
+-  wtimeout: 'wTimeoutMS',
+   j: 'journal'
+ };
+ ","is this a breaking change? If I'm not mistaken, this is translating a user-provided `wtimeout` in the connection string into `wTimeoutMS`",Why was this rem
+5611,"@@ -0,0 +1,7 @@
++import json
++
++
++def lambda_handler(event, context):
++    # Just print the event was passed to lambda
++    print('{}'.format(json.dumps(event)))
++    return 0","Can we rename this file to `lambda_echo.py`, to be more descriptive and in line with the other files in this directory? (all files in this folder are lambda functions, after all)",Why do we need t
+5612,"@@ -33,9 +33,10 @@ type Seccomp struct {
+ type Action int
+ 
+ const (
+-	Kill Action = iota - 4
++	Kill Action = iota - 5
+ 	Errno
+ 	Trap
++	Trace
+ 	Allow
+ )
+ ",why not do it like this ? <pre><code> const ( Kill Action = iota Errno Trap Allow Trace ) <pre><code>,Why did you change this?
+5613,"@@ -265,6 +265,7 @@ namespace NLog.Internal.FileAppenders
+         /// <param name=""expireTime"">The time which prior the appenders considered expired</param>
+         public void CloseAppenders(DateTime expireTime)
+         {
++            lock(this)
+             for (int i = 0; i < this.appenders.Length; ++i)
+             {
+                 if (this.appenders[i] == null)","lock(this) is a bad practise, since you lock the entire instance. cosider: var appenderCache = xxxx. lock(appenderCache) { Thread.Sleep(TimeSpan.FromHours(5)); } while inside AppenderCache instance lock(this) { is blocked 5 hours. } Its always better to make a class private lock objects.",Why is this lock needed?
+5614,"@@ -135,7 +135,10 @@ func WithClientInfo(serviceName string, procedures []transport.Procedure, transp
+ 		&ClientInfo{
+ 			clientDispatcher.ClientConfig(serviceName),
+ 			grpcClientConn,
+-			grpcheader.NewContextWrapper().WithCaller(serviceName + ""-client"").WithService(serviceName),
++			grpcheader.NewContextWrapper().
++				WithCaller(serviceName + ""-client"").
++				WithService(serviceName).
++				WithEncoding(""proto""),
+ 		},
+ 	)
+ }",should we use the constant above?,Why is this needed?
+5615,"@@ -6979,8 +6979,8 @@ os_seek(file_t f, int64 offset, int origin)
+     case OS_SEEK_END:
+         {
+             uint64 file_size = 0;
+-            bool res = os_get_file_size_by_handle(f, &file_size);
+-            ASSERT(res && ""bad file handle?""); /* shouldn't fail */
++            bool result = os_get_file_size_by_handle(f, &file_size);
++            ASSERT(result && ""bad file handle?""); /* shouldn't fail */
+             abs_offset += file_size;
+         }
+         break;",I think something like `size_res` would be more descriptive.,`abs_offset` should be `
+5616,"@@ -96,9 +96,9 @@ module Bolt
+       @target = target
+       @value = {}
+       @action = 'apply'
+-      value['report'] = report if report
+-      value['_error'] = error if error
+-      value['_output'] = metrics_message if metrics_message
++      @value['report'] = report if report
++      @value['_error'] = error if error
++      @value['_output'] = metrics_message if metrics_message
+     end
+ 
+     def event_metrics",Oh lol so this was...really more of a bug?,Why do we need this change?
+5617,"@@ -7,11 +7,11 @@ using System.Threading.Tasks;
+ 
+ namespace Microsoft.Rest
+ {
+-    public class PlatformTaskEx
++    [System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Naming"", 
++        ""CA1711:IdentifiersShouldNotHaveIncorrectSuffix"",
++        Justification=""We think with Ex is better than using 2"")]
++    public static class PlatformTaskEx
+     {
+-        //Per FxCop performance rule to prevent the compiler from generating a default constructor.
+-        private PlatformTaskEx() { }
+-
+         public static Task FromResult(object result)
+         {
+ #if NET45","Well, it is providing a platform neutral way of calling Task or TaskEx. We could just call it PlatformTask.",Why do we need this suppres
+5618,"@@ -89,7 +89,7 @@ struct wlr_xwayland *wlr_xwayland_create(struct wl_display *wl_display,
+ 	};
+ 	xwayland->server = wlr_xwayland_server_create(wl_display, &options);
+ 	if (xwayland->server == NULL) {
+-		free(xwayland->server);
++		free(xwayland);
+ 		return NULL;
+ 	}
+ ",Typo: this should free `xwayland` instead,`xwayland` can be `NULL` he
+5619,"@@ -19,9 +19,9 @@ package pingpong
+ 
+ import (
+ 	""bytes""
+-	""crypto/rand""
+ 	""encoding/hex""
+ 	""math""
++	""math/rand""
+ 	""strings""
+ 	""sync""
+ 	""sync/atomic""","Is it ok to use ""math/rand"" instead of ""crypto/rand"" here? Do we need to protect this ID somehow?",Why did you remove crypto/r
+5620,"@@ -2,7 +2,7 @@ package nats_dialog
+ 
+ import (
+ 	""fmt""
+-	""github.com/mgutz/logxi/v1""
++	log ""github.com/cihub/seelog""
+ 	""github.com/mysterium/node/communication""
+ 	""github.com/mysterium/node/communication/nats""
+ 	""github.com/mysterium/node/communication/nats_discovery""",Why did we have `logxi` in the first place? Maybe it makes sense to remove it from `glide.lock? It will safe us in the future from using logger which is not working.,nit: remove empty line
+5621,"@@ -269,9 +269,17 @@ public class DataCitation {
+             out.write(title);
+             out.write(""},\r\n"");
+         }
++        if(getUNF() != null){
++            out.write(""UNF = {"");
++            out.write(UNF);
++            out.write(""},\r\n"");
++        }
+         out.write(""year = {"");
+         out.write(year);
+         out.write(""},\r\n"");
++        out.write(""version = {"");
++        out.write(version);
++        out.write(""},\r\n"");
+         out.write(""doi = {"");
+         out.write(persistentId.getAuthority());
+         out.write(""/"");",Is there a reason to use `getUNF()` and `UNF` in the same block?,This should be `if (ge
+5622,"@@ -198,7 +198,7 @@ func TestParse(t *testing.T) {
+ 		},
+ 		{
+ 			name: ""regex match operators"",
+-			raw:  `""a"" =~ /.*/ and ""b"" !~ /c/`,
++			raw:  `""a"" =~ /.*/ and ""b"" !~ /c$/`,
+ 			want: &ast.Program{
+ 				Body: []ast.Statement{
+ 					&ast.ExpressionStatement{",Again this seems odd that megacheck cares,Why this change?
+5623,"@@ -49,6 +49,9 @@ module Bolt
+       @sudo_password = transport_conf[:sudo_password]
+       @run_as = transport_conf[:run_as]
+       @tmpdir = transport_conf[:tmpdir]
++      @service_url = transport_conf[:service_url]
++      @token_file = transport_conf[:token_file]
++      @environment = transport_conf[:environment]
+ 
+       @logger = init_logger(config[:log_destination], config[:log_level])
+       @transport_logger = init_logger(config[:log_destination], Logger::WARN)",I assume this will resolve to nil if this isn't in the config?,Why do we need these t
+5624,"@@ -17,6 +17,18 @@ namespace Datadog.Trace.Configuration
+         /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
+         /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
+         public static IDictionary<string, string> ParseCustomKeyValues(string data)
++        {
++            return ParseCustomKeyValues(data, allowOptionalMappings: false);
++        }
++
++        /// <summary>
++        /// Returns a <see cref=""IDictionary{TKey, TValue}""/> from parsing
++        /// <paramref name=""data""/>.
++        /// </summary>
++        /// <param name=""data"">A string containing key-value pairs which are comma-separated, and for which the key and value are colon-separated.</param>
++        /// <param name=""allowOptionalMappings"">Determines whether to create dictionary entries when the input has no value mapping</param>
++        /// <returns><see cref=""IDictionary{TKey, TValue}""/> of key value pairs.</returns>
++        public static IDictionary<string, string> ParseCustomKeyValues(string data, bool allowOptionalMappings = false)
+         {
+             var dictionary = new ConcurrentDictionary<string, string>();
+ ","I looks like we can make `allowOptionalMappings` non-optional since we have another overload without it. (I thought this generated a compiler warning, but maybe it's just R#)",Why do we need this overload?
+5625,"@@ -76,12 +76,13 @@ class YOLOV3Neck(BaseModule):
+ 
+     Args:
+         num_scales (int): The number of scales / stages.
+-        in_channels (int): The number of input channels.
+-        out_channels (int): The number of output channels.
+-        conv_cfg (dict): Config dict for convolution layer. Default: None.
+-        norm_cfg (dict): Dictionary to construct and config norm layer.
+-            Default: dict(type='BN', requires_grad=True)
+-        act_cfg (dict): Config dict for activation layer.
++        in_channels (List[int]): The number of input channels  per scale.
++        out_channels (List[int]): The number of output channels  per scale.
++        conv_cfg (dict, optional): Config dict for convolution layer.
++            Default: None.
++        norm_cfg (dict, optional): Dictionary to construct and config norm
++            layer. Default: dict(type='BN', requires_grad=True)
++        act_cfg (dict, optional): Config dict for activation layer.
+             Default: dict(type='LeakyReLU', negative_slope=0.1).
+         init_cfg (dict or list[dict], optional): Initialization config dict.
+             Default: None",` per scale.` -> ` per scale.` need to clean the unnecessary blank space,Why do we need this change?
+5626,"@@ -79,7 +79,8 @@ public class class194 {
+ 		descriptor = ""(IS)Ljava/lang/String;"",
+ 		garbageValue = ""4096""
+ 	)
+-	static final String method3712(int var0) {
++	@Export(""inventoryQuantityFormat"")
++	static final String inventoryQuantityFormat(int var0) {
+ 		if (var0 < 100000) { // L: 421
+ 			return ""<col=ffff00>"" + var0 + ""</col>"";
+ 		} else {",there's no import for Export,Why did you remove the method
+5627,"@@ -51,7 +51,7 @@ func (e *endpoints) ListenAndServe(ctx context.Context) error {
+ 	tcpServer := e.createTCPServer(ctx)
+ 	udsServer := e.createUDSServer(ctx)
+ 
+-	e.registerNodeAPI(tcpServer)
++	e.registerNodeAPI(tcpServer, udsServer)
+ 	e.registerRegistrationAPI(tcpServer, udsServer)
+ 
+ 	err := util.RunTasks(ctx,",i don't think we want/need to make the node API available over UDS,Why do we need to register bo
+5628,"@@ -113,7 +113,7 @@ class LegalConditionsFacade
+         $articleId = $this->setting->getForDomain($settingKey, $domainId);
+ 
+         if ($articleId !== null) {
+-            return $this->articleFacade->getById($articleId);
++            return $this->articleFacade->findById($articleId);
+         }
+ 
+         return null;",How about to skip if and returning null and return a result of `ArticleFacade::findById` directly?,Why did you change this?
+5629,"@@ -180,6 +180,11 @@ class CoreDocumentArray extends CoreMongooseArray {
+     return arr;
+   }
+ 
++  map() {
++    const arr = [].concat(Array.prototype.map.apply(this,arguments));
++    return arr;
++  }
++
+   /**
+    * Wraps [`Array#push`](https://developer.mozilla.org/en/JavaScript/Reference/Global_Objects/Array/push) with proper change tracking.
+    *","I think this change is currently unnecessary. I like the idea of `map()`, `filter()`, etc. returning vanilla JavaScript arrays rather than mongoose arrays, but I think that's a bit too heavy of a change for a patch release. I think that all we need for this release is the `if (!parent || parent.$__.populated == null) return;` change.",Why not just `return thi
+5630,"@@ -10,6 +10,11 @@ module Travis
+     BUILD_DIR = File.join(HOME_DIR, 'build')
+ 
+     class << self
++      def version
++        @version ||= `git rev-parse HEAD 2>/dev/null || \\
++                        echo ""${SOURCE_VERSION:-fafafaf}""`.strip
++      end
++
+       def self.register(key)
+         Travis.services.add(key, self)
+       end","how about ""unknown"" instead of ""fafafaf""?",I'm not sure if this is 
+5631,"@@ -0,0 +1,14 @@
++package api2
++
++import (
++	""context""
++
++	""github.com/filecoin-project/go-filecoin/address""
++	""github.com/filecoin-project/go-filecoin/exec""
++)
++
++// Actor is the actor-related Filecoin plumbing interface.
++type Actor interface {
++	// ActorGetSignature returns the signature of the given actor's given method.
++	ActorGetSignature(ctx context.Context, actorAddr address.Address, method string) (_ *exec.FunctionSignature, err error)
++}",nit: do we gain anything from naming the output error `err` in this definition?,Why do we need this inte
+5632,"@@ -188,6 +188,11 @@ define(['dialogHelper', 'inputManager', 'connectionManager', 'layoutManager', 'f
+                 stopInterval();
+             });
+ 
++            // Blur foreign element to prevent starting of ""nested"" slideshow
++            if (document.activeElement && !dlg.contains(document.activeElement)) {
++                document.activeElement.blur();
++            }
++
+             inputManager.on(window, onInputCommand);
+             document.addEventListener((window.PointerEvent ? 'pointermove' : 'mousemove'), onPointerMove);
+ ",This can happen with any dialog. Maybe the best place to add this change would be the dialog component instead.,Why do we need this?
+5633,"@@ -46,6 +46,10 @@ func NewTestEnvironment(ctx context.Context, t *testing.T, fastenvOpts fast.Envi
+ 	env, err := fast.NewEnvironmentMemoryGenesis(big.NewInt(1000000), dir, types.TestProofsMode)
+ 	require.NoError(err)
+ 
++	defer func() {
++		dumpEnvOutputOnFail(t, env.Processes())
++	}()
++
+ 	// Setup options for nodes.
+ 	options := make(map[string]string)
+ 	options[localplugin.AttrLogJSON] = ""1""                                        // Enable JSON logs","Should this be `TearDown` since it now calls this method? Something I would like to see is, on test failure don't teardown completely instead leave the FAST repo in place with the stderr and stdout files and direct the user to that location. What do you think?",Why do we need this?
+5634,"@@ -190,6 +190,8 @@ def getModule(metricSpec):
+     return MetricMAPE(metricSpec)
+   elif metricName == 'multi':
+     return MetricMulti(metricSpec)
++  elif metricName == 'negLL':
++    return MetricNegLogLikelihood(metricSpec)
+   else:
+     raise Exception(""Unsupported metric type: %s"" % metricName)
+ ","There's not particular reason to use a short name. Can we use a more descriptive name for the metric? Perhaps ""negativeLogLikelihood""?",This should be `Metr
+5635,"@@ -745,7 +745,10 @@ static void skipArgumentList (tokenInfo *const token, boolean include_newlines,
+ 		while (nest_level > 0 && ! isType (token, TOKEN_EOF))
+ 		{
+ 			readTokenFull (token, FALSE, repr);
+-			if (isType (token, TOKEN_OPEN_PAREN))
++			if (isType (token, TOKEN_KEYWORD) && token->keyword == KEYWORD_function &&
++			    repr == NULL)
++				parseFunction (token);
++			else if (isType (token, TOKEN_OPEN_PAREN))
+ 				nest_level++;
+ 			else if (isType (token, TOKEN_CLOSE_PAREN))
+ 				nest_level--;","not handling in case of `repr` makes the behavior probably a little too unpredictable. Is there a reason not to, apart missing stuff in the `repr`? Does it lead to some problem?",I think it would be 
+5636,"@@ -93,12 +93,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+                             BadHttpRequestException.Throw(RequestRejectionReason.UnexpectedEndOfRequestContent);
+                         }
+ 
+-                        awaitable = _context.Input.ReadAsync();
+                     }
+                     finally
+                     {
+                         _context.Input.AdvanceTo(consumed, examined);
+                     }
++
++                    awaitable = _context.Input.ReadAsync();
+                 }
+             }
+             catch (Exception ex)",Remove the finally?,Why is this change needed?
+5637,"@@ -378,7 +378,7 @@ reboot_system()
+  *   and then checking error codes; but the problem there is that C:\\
+  *   returns PATH_NOT_FOUND regardless. */
+ bool
+-file_exists(const TCHAR *fn)
++file_exists(const WCHAR *fn)
+ {
+ #ifdef WINDOWS
+     WIN32_FIND_DATA fd;",Build on AArch64 fails because WCHAR is not defined.,This should be `WIN32_FIND
+5638,"@@ -20,6 +20,7 @@ import (
+ 
+ func TestRDWS_Template(t *testing.T) {
+ 	const (
++		envName               = ""test""
+ 		manifestFileName      = ""rdws-manifest.yml""
+ 		stackTemplateFileName = ""rdws.stack.yml""
+ 	)",Do we use this const?,I don't think this is need
+5639,"@@ -139,3 +139,9 @@ func SetCertificateRequestFailureTime(p metav1.Time) CertificateRequestModifier
+ 		cr.Status.FailureTime = &p
+ 	}
+ }
++
++func SetAnnotations(annotations map[string]string) CertificateRequestModifier {
++	return func(cr *v1alpha2.CertificateRequest) {
++		cr.SetAnnotations(annotations)
++	}
++}",I think this may need to be `SetCertificateRequestAnnotations` as it returns a `CertificateRequestModifier`  ,I don't think we need this
+5640,"@@ -234,6 +234,7 @@ class User < ActiveRecord::Base
+   #
+   # Returns UserIdentifier
+   def identifier_for(scheme)
++    scheme = scheme.instance_of?(IdentifierScheme) ? scheme.name : scheme
+     identifiers.by_scheme_name(scheme, ""User"").first
+   end
+ ",it would likely be better to do this in the Identifier.by_scheme_name method itself.,Why not just `identifier_for(scheme)`?
+5641,"@@ -129,6 +129,10 @@ class DatasetContext extends RawDKANEntityContext {
+     }
+ 
+     switch ($orderby) {
++      case 'Date created':
++        $orderby = 'created';
++        break;
++
+       case 'Date changed':
+         $orderby = 'changed';
+         break;","@janette looking at this test code, I'm pretty sure that it's going to give a false positive. Where is it actually checking the contents of the first four datasets against expected values? All the assertion at the end of the test seems to check is that at least four datasets exist.",Why is this needed?
+5642,"@@ -68,6 +68,14 @@ module.exports = function (defaults) {
+             optional: ['es6.spec.symbols'],
+             includePolyfill: true
+         },
++        'ember-service-worker': {
++            rootUrl: '/ghost/'
++        },
++        'esw-cache-fallback': {
++            patterns: [
++                '/ghost/api/(.+)'
++            ],
++        },
+         outputPaths: {
+             app: {
+                 js: assetLocation('ghost.js')",Would this break things if Ghost is run in a subdirectory or no?,I think this should be `/api/ghost/`
+5643,"@@ -24,7 +24,11 @@ class ProposalUpdateRecorder
+   end
+ 
+   def update_comment_format(key)
+-    ""#{bullet}*#{property_name(key)}* was changed "" + former_value(key) + ""to #{new_value(key)}""
++    if key !~ /id/
++      ""#{bullet}*#{property_name(key)}* was changed "" + former_value(key) + ""to #{new_value(key)}""
++    else
++      ""#{bullet}*#{association_name(key)}* was changed "" + former_association_value(key) + ""to #{new_association_value(key)}""
++    end
+   end
+ 
+   def bullet",maybe switch the order in order to make this a positive assertion instead of a negative one? i.e. `if key =~ /id/` first.,Style/StringLiterals: Prefer single-qu
+5644,"@@ -20,6 +20,7 @@ from selenium.common.exceptions import NoSuchFrameException
+ from selenium.common.exceptions import StaleElementReferenceException
+ from selenium.common.exceptions import WebDriverException
+ from selenium.common.exceptions import NoAlertPresentException
++from selenium.common.exceptions import ElementNotVisibleException
+ 
+ """"""
+  * Canned ""Expected Conditions"" which are generally useful within webdriver",Is this an oversight for some code in the body?,from selenium.common.exceptions import WebDriverError
+5645,"@@ -922,6 +922,8 @@ public class AddProductActivity extends AppCompatActivity {
+                         toast.show();
+                         mOfflineSavedProductDao.deleteInTx(mOfflineSavedProductDao.queryBuilder().where(OfflineSavedProductDao.Properties.Barcode.eq(code)).list());
+                         Intent intent = new Intent();
++                        state.setProduct(mProduct);
++                        intent.putExtra(""state"", state);
+                         intent.putExtra(""uploadedToServer"", true);
+                         setResult(RESULT_OK, intent);
+                         finish();",Reason for adding this? I couldn't find where you are retrieving it back.,"I think this should be `putExtra(""product"", mProduct)"
+5646,"@@ -62,6 +62,10 @@ static void setup_globals(mrb_state *mrb)
+ 
+     h2o_mruby_eval_expr(mrb, ""$LOAD_PATH << \""#{$H2O_ROOT}/share/h2o/mruby\"""");
+     h2o_mruby_assert(mrb);
++
++    /* require core modules and include built-in libraries */
++    h2o_mruby_eval_expr(mrb, ""require \""preloads.rb\"""");
++    h2o_mruby_assert(mrb);
+ }
+ 
+ mrb_value h2o_mruby_to_str(mrb_state *mrb, mrb_value v)","Can we expect adequate information emitted to the log in case either requiring preloads.rb or doing the requires in preloads.rb fails? If the answer is yes, I think we can merge this PR right away.",I'm not sure if this is the right place to put this. 
+5647,"@@ -1,2 +1,3 @@
+-class PagesController < ApplicationController
+-end
++class PagesController < HighVoltage::PagesController
++  layout false
++end","How about a `app/views/layouts/pages.html.erb` layout that contains the HTML head, body, wrappers and yield's the `new-topics` template into it? I think we might be able to delete the `app/controllers/pages_controller.rb` file at that point.",Layout/EmptyLineAfterGuardClause: Add empty line afte
+5648,"@@ -2218,7 +2218,9 @@ Document.prototype.isSelected = function isSelected(path) {
+   if (this.$__.selected == null) {
+     return true;
+   }
+-
++  if (!path) {
++    return false;
++  }
+   if (path === '_id') {
+     return this.$__.selected._id !== 0;
+   }","This is a coarse solution. This check is helpful, but you should also add a check in `$__version()` to avoid calling `isSelected()` if `key === false`",Why did you change this?
+5649,"@@ -37,8 +37,10 @@ type Planner interface {
+ }
+ 
+ type Input struct {
+-	// Readonly deployment model.
+-	Deployment                     *model.Deployment
++	ApplicationID                  string
++	ApplicationName                string
++	GitPath                        model.ApplicationGitPath
++	Trigger                        model.DeploymentTrigger
+ 	MostRecentSuccessfulCommitHash string
+ 	PipedConfig                    *config.PipedSpec
+ 	TargetDSP                      deploysource.Provider",Passing only needed data to make it can be reused by `planpreview` package where there is no deployment data.,Why is this a pointer?
+5650,"@@ -71,6 +71,9 @@ type Options struct {
+ 	TLSCaCert      string        `json:""-""`
+ 	TLSConfig      *tls.Config   `json:""-""`
+ 	WriteDeadline  time.Duration `json:""-""`
++
++	CustomClientAuth Auth `json:""-""`
++	CustomRouterAuth Auth `json:""-""`
+ }
+ 
+ // Clone performs a deep copy of the Options struct, returning a new clone",Could we rename those to `CustomClientAuthentication` (same for Router) to remove ambiguity between Authentication and Authorization (permissions)?,Why is this a pointer?
+5651,"@@ -1,11 +1,15 @@
+ using System;
++using MvvmCross.Core.Views;
+ using MvvmCross.Forms.Platform;
+ 
+ namespace MvvmCross.Forms.Views
+ {
+-    public interface IMvxFormsViewPresenter
++    public interface IMvxFormsViewPresenter : IMvxAttributeViewPresenter
+     {
+         MvxFormsApplication FormsApplication { get; set; }
+         IMvxFormsPagePresenter FormsPagePresenter { get; set; }
++
++        bool ClosePlatformViews();
++        bool ShowPlatformHost(Type hostViewModel = null);
+     }
+ }","Is the name ""IMvxFormsViewPresenter"" too close to ""IMvxFormsPagePresenter""? Perhaps something like ""IMvxFormsNativeViewPresenter"" or ""IMvxFormsPlatformViewPresenter"" or inline with Forms naming ""IMvxFormsOnPlatformViewPresenter""",I think this interface s
+5652,"@@ -28,8 +28,8 @@ export function h(nodeName, attributes) {
+ 		if ((child = stack.pop()) instanceof Array) {
+ 			for (i=child.length; i--; ) stack.push(child[i]);
+ 		}
+-		else if (child!=null && child!==false) {
+-			if (typeof child=='number' || child===true) child = String(child);
++		else if (child!=null && child!==true && child!==false) {
++			if (typeof child=='number') child = String(child);
+ 			simple = typeof child=='string';
+ 			if (simple && lastSimple) {
+ 				children[children.length-1] += child;",`typeof child != 'boolean'` maybe?,Why is this change needed?
+5653,"@@ -220,7 +220,7 @@ public class ErrorHandler {
+ 
+   private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
+ 
+-    if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
++    if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
+       // Not enough information for us to try to rebuild an error.
+       return null;
+     }",Why && changed to || ?,Why is this change needed?
+5654,"@@ -26,6 +26,11 @@ func init() {
+ 		panic(err)
+ 	}
+ 
++	InitAddress, err = NewIDAddress(4)
++	if err != nil {
++		panic(err)
++	}
++
+ 	StorageMarketAddress, err = NewIDAddress(2)
+ 	if err != nil {
+ 		panic(err)",nit: not a big deal right now but spec assigns ID 0 to InitAddress,I think this should be `Ne
+5655,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change.",I think this should be `pa
+5656,"@@ -361,6 +361,11 @@ class WebView(QWebView):
+         message.info(self.win_id, ""Zoom level: {}%"".format(perc))
+         self._default_zoom_changed = True
+ 
++    def setZoomFactor(self, fact):
++        self._zoom.fuzzyval = int(fact * 100)
++        super().setZoomFactor(fact)
++        self._default_zoom_changed = True
++
+     def zoom(self, offset):
+         """"""Increase/Decrease the zoom level.
+ ","There are various places where `setZoomFactor` is used but `fuzzyval` isn't set: - `__init__` and `on_config_changed` (should be okay as `init_neighborlist` gets called which essentially does the same) - `zoom` (calls `zoom_perc` with `fuzzyval=False`), which is used by `:zoom-in` and `:zoom-out`. Are you sure this won't break those calls? (Yes, I know there should be tests for this - I'm working on that.) Other existing places probably should get simplified.",Why is this necessary?
+5657,"@@ -889,12 +889,12 @@ namespace pwiz.Skyline.Model
+             string pathForLibraryFiles, // In case we translate libraries etc
+             ConvertToSmallMoleculesMode mode = ConvertToSmallMoleculesMode.formulas, 
+             ConvertToSmallMoleculesChargesMode invertChargesMode = ConvertToSmallMoleculesChargesMode.none, 
+-            bool ignoreDecoys=false)
++            bool ignoreDecoys=false, bool addAnnotations = true)
+         {
+             if (mode == ConvertToSmallMoleculesMode.none)
+                 return document;
+             var newdoc = new SrmDocument(document.Settings);
+-            var note = new Annotations(TestingConvertedFromProteomic, null, 1); // Mark this as a testing node so we don't sort it
++            var note = addAnnotations ? new Annotations(TestingConvertedFromProteomic, null, 1) : Annotations.EMPTY; // Optionally mark this as a testing node so we don't sort it
+             var precursorMap = new Dictionary<LibKey, LibKey>(); // Map int,modSeq to adduct,molecule
+ 
+             var invertCharges = invertChargesMode == ConvertToSmallMoleculesChargesMode.invert;",Is there a benefit to keeping this in RefinementSettings? Or could we move it into its own class in TestUtil?,>addAnnotations [](sta
+5658,"@@ -6,14 +6,10 @@ import (
+ 
+ // Query represents an active query.
+ type Query interface {
+-	// Spec returns the spec used to execute this query.
+-	// Spec must not be modified.
+-	Spec() *Spec
+-
+-	// Ready returns a channel that will deliver the query results.
++	// Results returns a channel that will deliver the query results.
+ 	// Its possible that the channel is closed before any results arrive,
+ 	// in which case the query should be inspected for an error using Err().
+-	Ready() <-chan map[string]Result
++	Results() <-chan Result
+ 
+ 	// Done must always be called to free resources. It is safe to call Done
+ 	// multiple times.","I would have expected the Ready method to need to change to be a `<-chan Result` instead of a `<-chan map[string]Result`. The difference being that now the Ready channel can produce more than one set of results. In fact the name Ready is inaccurate now since its not about the query being ready but just a mechanism to deliver results. If this should be a follow up PR that is fine, lets create an issue for it.",I don't think we need 
+5659,"@@ -36,7 +36,7 @@ public interface ProjectLoader {
+    * @return
+    * @throws ProjectManagerException
+    */
+-  public List<Project> fetchAllActiveProjects() throws ProjectManagerException;
++  List<Project> fetchAllActiveProjects() throws ProjectManagerException;
+ 
+   /**
+    * Loads whole project, including permissions, by the project id.",why? what if we want to access those methods outside of azkaban-common?,Why did you remove the
+5660,"@@ -45,9 +45,9 @@ namespace Nethermind.Merge.Plugin.Test
+     {
+         private async Task<MergeTestBlockchain> CreateBlockChain() => await new MergeTestBlockchain(new ManualTimestamper()).Build(new SingleReleaseSpecProvider(Berlin.Instance, 1));
+ 
+-        private IConsensusRpcModule CreateConsensusModule(MergeTestBlockchain chain)
++        private IEngineRpcModule CreateConsensusModule(MergeTestBlockchain chain)
+         {
+-            return new ConsensusRpcModule(
++            return new EngineRpcModule(
+                 new AssembleBlockHandler(chain.BlockTree, chain.BlockProductionTrigger, chain.Timestamper, chain.LogManager),
+                 new NewBlockHandler(chain.BlockTree, chain.BlockPreprocessorStep, chain.BlockchainProcessor, chain.State, new InitConfig(), chain.LogManager),
+                 new SetHeadBlockHandler(chain.BlockTree, chain.State, chain.LogManager),",Rename file too,ConsensusRpcModule -> EngineRpcModule
+5661,"@@ -27,7 +27,11 @@ func Unmarshal(r *request.Request) {
+ 		decoder := xml.NewDecoder(r.HTTPResponse.Body)
+ 		err := xmlutil.UnmarshalXML(r.Data, decoder, """")
+ 		if err != nil {
+-			r.Error = awserr.New(""SerializationError"", ""failed decoding EC2 Query response"", err)
++			r.Error = awserr.NewRequestFailure(
++				awserr.New(""SerializationError"", ""failed decoding EC2 Query response"", err),
++				r.HTTPResponse.StatusCode,
++				"""",
++			)
+ 			return
+ 		}
+ 	}","Need to populate the `RequestID` field for these errors. This can be obtained from r.RequestID i think, but need to make sure. The `r.RequestID` should of been populated from the `UnmarshalMeta` handler list.",I think this should be `r.HTTPRespons
+5662,"@@ -35,8 +35,8 @@ public class LongRunningConfigTest {
+   private static final String GAPIC_CONFIG_METADATA_TYPE = ""HeaderType"";
+   private static final String ANNOTATIONS_RETURN_TYPE_NAME = ""BookType"";
+   private static final String ANNOTATIONS_METADATA_TYPE = ""FooterType"";
+-  private static final boolean TEST_IMPLEMENTS_DELETE = false;
+-  private static final boolean TEST_IMPLEMENTS_CANCEL = false;
++  private static boolean TEST_IMPLEMENTS_DELETE = false;
++  private static boolean TEST_IMPLEMENTS_CANCEL = false;
+   private static int TEST_INITIAL_POLL_DELAY = 5;
+   private static double TEST_POLL_DELAY_MULTIPLIER = 10;
+   private static long TEST_MAX_POLL_DELAY = 12500;",Why is the `final` being removed here?,Why did you remove the final?
+5663,"@@ -1,13 +1,14 @@
+ //
+ //  Bismillah ar-Rahmaan ar-Raheem
+ //
+-//  Easylogging++ v9.95.0
++//  Easylogging++ v9.96.4
+ //  Cross-platform logging library for C++ applications
+ //
+-//  Copyright (c) 2017 muflihun.com
++//  Copyright (c) 2012-2018 Muflihun Labs
++//  Copyright (c) 2012-2018 @abumusamq
+ //
+ //  This library is released under the MIT Licence.
+-//  http://labs.muflihun.com/easyloggingpp/licence.php
++//  https://github.com/muflihun/easyloggingpp/blob/master/LICENSE
+ //
+ //  https://github.com/muflihun/easyloggingpp
+ //  https://muflihun.github.io/easyloggingpp",Maybe let's take this opportunity to change easylogging to a git submodule?,This should be `2019-2018`
+5664,"@@ -30,6 +30,9 @@ func extractFrontMatter(input string) (map[string]interface{}, string, error) {
+ 	}
+ 	firstLine := input[firstLineStart:firstLineEnd]
+ 
++	// ensure residue windows newline is removed
++	firstLine = strings.Trim(firstLine, ""\r"")
++
+ 	// see what kind of front matter there is, if any
+ 	var closingFence string
+ 	var fmParser func([]byte) (map[string]interface{}, error)",Should we just be generous and elide all extra whitespace? `strings.TrimSpace`,Why is this needed?
+5665,"@@ -900,18 +900,6 @@ public class SalesforceSDKManager {
+         return context.getString(getSalesforceR().stringAccountType());
+     }
+ 
+-    /**
+-     * Indicates whether the app is running on a tablet.
+-     *
+-     * @return True if the application is running on a tablet.
+-     */
+-    public static boolean isTablet() {
+-        if ((INSTANCE.context.getResources().getConfiguration().screenLayout & Configuration.SCREENLAYOUT_SIZE_MASK) == Configuration.SCREENLAYOUT_SIZE_XLARGE) {
+-            return true;
+-        }
+-        return false;
+-    }
+-
+     @Override
+     public String toString() {
+         final StringBuilder sb = new StringBuilder();","This is an inaccurate API that has outlived it's purpose. We can't make the determination of phone (vs) tablet, with a 7"" screen in the mix. Also, with the advent of fragments, this API means very little now. It's not being used anywhere, since we switched to `ActionBar`.",Why is this removed
+5666,"@@ -230,7 +230,7 @@ public class GridLauncherV3 {
+     }
+ 
+     configureLogging(common.getLog(), common.getDebug());
+-    log.info(version());
++    log.finest(version());
+     return true;
+   }
+ ",This change means that users can't easily see which version of the selenium server they're using. This is `info` level information.,This should be `log
+5667,"@@ -455,8 +455,8 @@ class AuthTestCase(QuiltTestCase):
+     def testCodeExpires(self):
+         self.code_immediate_expire_mock = mock.patch('quilt_server.auth.CODE_TTL_DEFAULT',
+                                                      {'minutes': 0})
+-        self.code_immediate_expire_mock.start()
+         token = self.getToken()
++        self.code_immediate_expire_mock.start()
+         code_request = self.app.get(
+             '/api/code',
+             headers={","You should just use `with patch(...):`, so it unpatches it automatically. Also, much simpler.",Why was this change
+5668,"@@ -28,14 +28,15 @@ namespace MvvmCross.Navigation
+         private IMvxViewDispatcher _viewDispatcher;
+         public IMvxViewDispatcher ViewDispatcher
+         {
+-            get => _viewDispatcher ?? (IMvxViewDispatcher)MvxMainThreadDispatcher.Instance;
++            get => _viewDispatcher ?? (_viewDispatcher = Mvx.Resolve<IMvxViewDispatcher>());
+             set => _viewDispatcher = value;
+         }
+ 
+         private IMvxViewsContainer _viewsContainer;
+         protected IMvxViewsContainer ViewsContainer
+         {
+-            get {
++            get
++            {
+                 if (_viewsContainer == null)
+                     _viewsContainer = Mvx.Resolve<IMvxViewsContainer>();
+                 return _viewsContainer;",This didn't use to work for me. Are you sure that returns the correct instance from startup?,Why this change?
+5669,"@@ -65,6 +65,14 @@ public final class MethodCallExpr extends Expression implements NodeWithTypeArgu
+         this(null, scope, new NodeList<>(), new SimpleName(name), new NodeList<>());
+     }
+ 
++    public MethodCallExpr(final Expression scope, final SimpleName name) {
++        this(null, scope, new NodeList<>(), name, new NodeList<>());
++    }
++
++    public MethodCallExpr(final Expression scope, final String name, final NodeList<Expression> arguments) {
++        this(null, scope, new NodeList<>(), new SimpleName(name), arguments);
++    }
++
+     public MethodCallExpr(final Expression scope, final SimpleName name, final NodeList<Expression> arguments) {
+         this(null, scope, new NodeList<>(), name, arguments);
+     }","Looks good. Eventually we could remove some of these constructors, but for now adding these two seems the way to go",Why do we need t
+5670,"@@ -180,7 +180,7 @@ def parse_bwids(bwolist):
+     return list(ast.literal_eval(bwolist))
+ 
+ 
+-def get_holdingpen_objects(ptags=[]):
++def get_holdingpen_objects(ptags=[""Need action""]):
+     """"""Get BibWorkflowObject's for display in Holding Pen.
+ 
+     Uses DataTable naming for filtering/sorting. Work in progress.",@jalavik should be have somewhere enum/list/registry of possible tags?,Why is this chan
+5671,"@@ -155,6 +155,7 @@ class SecurityCenterClient(object):
+                     finding.get('source_properties').get('violation_data'))
+                 raise api_errors.ApiExecutionError(violation_data, e)
+ 
++    # pylint: disable=logging-too-many-args
+     def list_findings(self, source_id):
+         """"""Lists all the findings in CSCC.
+ ",why is this pylint disable needed?,Why disable this
+5672,"@@ -44,6 +44,7 @@ def GenerateConfig(context):
+ 
+     FORSETI_HOME = '$USER_HOME/forseti-security'
+     POLICY_LIBRARY_HOME = '$USER_HOME/policy-library'
++    POLICY_LIBRARY_SYNC_ENABLED = 'false'
+ 
+     DOWNLOAD_FORSETI = (
+         ""git clone {src_path}.git"".format(",The new sync feature is only being supported from within Terraform. Installations using the deprecated method will have this feature disabled.,Why is this needed?
+5673,"@@ -79,3 +79,7 @@ class DropBlock(nn.Module):
+         factor = (1.0 if self.iter_cnt > self.warmup_iters else self.iter_cnt /
+                   self.warmup_iters)
+         return gamma * factor
++
++    def extra_repr(self):
++        return (f'drop_prob={self.drop_prob}, block_size={self.block_size}, '
++                f'warmup_iters={self.warmup_iters}')","This type of return (f'xxx') is not recommended, it is recommended to return 'xxx'",I don't think this 
+5674,"@@ -2836,8 +2836,11 @@ client_process_bb(dcontext_t *dcontext, build_bb_t *bb)
+ #    ifdef X86
+         if (!d_r_is_avx512_code_in_use()) {
+             if (ZMM_ENABLED()) {
+-                if (instr_may_write_zmm_register(inst))
++                if (instr_may_write_zmm_register(inst)) {
++                    LOG(THREAD, LOG_INTERP, 3, ""Detected AVX-512 code in use\n"");
+                     d_r_set_avx512_code_in_use(true);
++                    proc_set_num_simd_saved(MCXT_NUM_SIMD_SLOTS);
++                }
+             }
+         }
+ #    endif",I would make this level 1 or 2.,(style) code indent
+5675,"@@ -0,0 +1,17 @@
++require 'beaker/hypervisor/vagrant'
++
++class Beaker::VagrantFusion < Beaker::Vagrant
++  def provision(provider = 'vmware_fusion')
++    # By default vmware_fusion creates a .vagrant directory relative to the
++    # Vagrantfile path. That means beaker tries to scp the VM to itself unless
++    # we move the VM files elsewhere.
++    ENV['VAGRANT_VMWARE_CLONE_DIRECTORY'] = '~/.vagrant/vmware_fusion'
++    super
++  end
++
++  def self.provider_vfile_section(host, options)
++    ""    v.vm.provider :vmware_fusion do |v|\n"" +
++    ""      v.vmx['memsize'] = '#{options['vagrant_memsize'] ||= '1024'}'\n"" +
++    ""    end\n""
++  end
++end",Is that path in a variable anyway? Not a big fan of hard coding it here.,I think this should
+5676,"@@ -16,14 +16,18 @@ limitations under the License.
+ package controllers
+ 
+ import (
++	""bytes""
+ 	""context""
++	""errors""
++	""strings""
++	""text/template""
+ 
+ 	""github.com/sirupsen/logrus""
+ 	federation ""github.com/spiffe/spire/support/k8s/k8s-workload-registrar/federation""
+ 	spiffeidv1beta1 ""github.com/spiffe/spire/support/k8s/k8s-workload-registrar/mode-crd/api/spiffeid/v1beta1""
+ 
+ 	corev1 ""k8s.io/api/core/v1""
+-	""k8s.io/apimachinery/pkg/api/errors""
++	k8serrors ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/types""",nit: Move `IdentityTemplateLabel` to be under `IdentityTemplate` to match the struct in config_crd.go,I think this should be `k8serrors`
+5677,"@@ -1,8 +1,13 @@
+ class Analytics
+   include AnalyticsHelper
+ 
+-  SAMPLER = ""sampler""
+-  SUBSCRIBER = ""subscriber""
++  SAMPLER = ""sampler"".freeze
++  SUBSCRIBER = ""subscriber"".freeze
++  TRACKERS = {
++    ""Video"" => VideoTracker,
++    ""Exercise"" => ExerciseTracker,
++    ""Trail"" => TrailTracker,
++  }.freeze
+ 
+   class_attribute :backend
+   self.backend = AnalyticsRuby","Not necessarily related to this PR, but don't you think having a centralized place for all interactions with analytics might make this into a very big class? Is that something that you don't worry about until it happens?",Do we need to freeze these?
+5678,"@@ -670,6 +670,13 @@ func (w *Workflow) runStep(ctx context.Context, s *Step) DError {
+ 	select {
+ 	case err := <-e:
+ 		return err
++	case <-ctx.Done():
++		if err := ctx.Err(); err == context.DeadlineExceeded {
++			return s.getTimeoutError()
++		} else if err != nil {
++			return Errf(""step %q error: %s"", s.name, err)
++		}
++		return nil
+ 	case <-timeout:
+ 		return s.getTimeoutError()
+ 	}","it seems that my terminal is dead when I press ctrl+c during running daisy cli today, is this PR fixing that?",Shouldn't this be `ctx.Err()`?
+5679,"@@ -403,7 +403,7 @@ func (nc *Config) Build(ctx context.Context) (*Node, error) {
+ 
+ 	// only the syncer gets the storage which is online connected
+ 	chainSyncer := chain.NewDefaultSyncer(&cstOffline, nodeConsensus, chainStore, fetcher)
+-	msgPool := core.NewMessagePool(chainStore, consensus.NewIngestionValidator(chainStore))
++	msgPool := core.NewMessagePool(chainStore, nc.Repo.Config().Mpool, consensus.NewIngestionValidator(chainStore))
+ 	outbox := core.NewMessageQueue()
+ 
+ 	// Set up libp2p pubsub","If we are going to add config to specify the maximum message pool size, we should probably also add a parameter for the maximum nonce gap and pass it into the `IngestionValidator`. This could be done in this PR or added as an issue.",Why do we need Mpool here?
+5680,"@@ -12,10 +12,8 @@
+  */
+ package org.camunda.bpm.container.impl.spi;
+ 
+-import java.util.ArrayList;
+-import java.util.HashMap;
+-import java.util.List;
+-import java.util.Map;
++import java.util.*;
++
+ import org.camunda.bpm.container.impl.ContainerIntegrationLogger;
+ import org.camunda.bpm.engine.impl.ProcessEngineLogger;
+ ",please inline imports,Please don't use wildcard imports.
+5681,"@@ -113,7 +113,7 @@ type Config struct {
+ 	IptablesRefreshInterval            time.Duration `config:""seconds;90""`
+ 	IptablesPostWriteCheckIntervalSecs time.Duration `config:""seconds;30""`
+ 	IptablesLockFilePath               string        `config:""file;/run/xtables.lock""`
+-	IptablesLockTimeoutSecs            time.Duration `config:""seconds;30""`
++	IptablesLockTimeoutSecs            time.Duration `config:""seconds;0""`
+ 	IptablesLockProbeIntervalMillis    time.Duration `config:""millis;50""`
+ 	IpsetsRefreshInterval              time.Duration `config:""seconds;10""`
+ 	MaxIpsetSize                       int           `config:""int;1048576;non-zero""`","Should IptablesPostWriteCheckIntervalSecs be set back to its previous smaller value, if use of the iptables lock is disabled?",Why did you change this?
+5682,"@@ -313,7 +313,11 @@ class JoplinDatabase extends Database {
+ 
+ 		// currentVersionIndex < 0 if for the case where an old version of Joplin used with a newer
+ 		// version of the database, so that migration is not run in this case.
+-		if (currentVersionIndex < 0) throw new Error('Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.');
++		if (currentVersionIndex < 0) {
++			this.logger().error(`Cannot convert database from version ${fromVersion} to ${existingDatabaseVersions[existingDatabaseVersions.length-1]}`);
++			const p = require('../package.json');
++			throw new Error(`Unknown profile version. Most likely this is an old version of Joplin, while the profile was created by a newer version. Please upgrade Joplin at https://joplinapp.org and try again.\n${p.name} version: ${p.version}\nProfile version: ${fromVersion}\nExpected version: ${existingDatabaseVersions[existingDatabaseVersions.length-1]}`);
++		}
+ 
+ 		if (currentVersionIndex == existingDatabaseVersions.length - 1) return fromVersion;
+ ",Please use packageInfo here instead. As it is used in `app.js`.,I think this should be `this.logge
+5683,"@@ -49,7 +49,10 @@ public class AnalysisResult {
+             // the analysis will fail and report the error on it's own since the checksum won't match
+         }
+ 
+-        return 0;
++        // we couldn't read the file, maybe the file doesn't exist
++        // in any case, we can't use the cache. Returning here the timestamp should make
++        // sure, we see that the file changed every time we analyze it.
++        return System.currentTimeMillis();
+     }
+ 
+     public long getFileChecksum() {","this seems unrelated to the rest of the PR, although related to the original report",I'm not sure if this is the right 
+5684,"@@ -11386,7 +11386,7 @@ NABoolean HbaseAccess::isHbaseFilterPredV2(Generator * generator, ItemExpr * ie,
+   }
+   //check if not an added column with default non null
+   if ((foundBinary || foundUnary)&& (NOT hbaseLookupPred)){
+-        if (colVID.isAddedColumnWithNonNullDefault()){
++        if (colVID.isColumnWithNonNullDefault()){
+             foundBinary=FALSE;
+             foundUnary=FALSE;
+         }",Would a check for added columns with non-null default be sufficient for aligned format?,Why did you change this?
+5685,"@@ -69,6 +69,7 @@ var (
+ 	hostname                    = flag.String(ovfimportparams.HostnameFlagKey, """", ""Specify the hostname of the instance to be created. The specified hostname must be RFC1035 compliant."")
+ 	machineImageStorageLocation = flag.String(ovfimportparams.MachineImageStorageLocationFlagKey, """", ""GCS bucket storage location of the machine image being imported (regional or multi-regional)"")
+ 	buildID                     = flag.String(""build-id"", """", ""Cloud Build ID override. This flag should be used if auto-generated or build ID provided by Cloud Build is not appropriate. For example, if running multiple imports in parallel in a single Cloud Build run, sharing build ID could cause premature temporary resource clean-up resulting in import failures."")
++	computeServiceAccount       = flag.String(""compute_service_account"", """", ""Compute service account to be used by importer. When empty, the Compute Engine default service account is used."")
+ 
+ 	nodeAffinityLabelsFlag flags.StringArrayFlag
+ 	currentExecutablePath  string","Is this PR implementing compute service account for OVF import as well? I thought it's only image/one-step import? Btw, OVF importer uses ""-"" instead of ""_"" in flags (should be `compute-service-account`).",I think it would be good
+5686,"@@ -23,7 +23,7 @@ use Symfony\Component\Routing\Annotation\Route;
+ /**
+  * @Route(
+  *     name=""ergonode_product_collection_element_delete"",
+- *     path=""/collections/{collection}/elements/{product}"",
++ *     path=""/collections/{collection}/element/{product}"",
+  *     methods={""DELETE""},
+  *     requirements={
+  *     ""collection""=""[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}"",",Why change to element ?? in whole application use plural convention ??,This should be `/collect
+5687,"@@ -23,7 +23,7 @@ const renderInnerPanel = (props) => {
+ }
+ 
+ const poweredByUppy = (props) => {
+-  return <a href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
++  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
+     <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
+   </svg><span class=""uppy-Dashboard-poweredByUppy"">Uppy</span></a>
+ }","Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`",I think this should be `
+5688,"@@ -344,6 +344,16 @@ try:
+     cast = image.astype(np.float32)
+     assert cast.dtype == np.float32
+ 
++    # Test .astype for conversion between vector-like pixel types.
++    components = 3
++    numpyImage = np.random.randint(0, 256, (12,8,components)).astype(np.uint8)
++    input_image = itk.image_from_array(numpyImage, is_vector=True)
++    if (type(input_image) == itk.Image[itk.RGBPixel[itk.UC],2] and
++        hasattr(itk.CastImageFilter, 'IRGBUC2IVF32')):
++        output_pixel_type = itk.Vector[itk.F,components]
++        output_image = input_image.astype(output_pixel_type)
++        assert type(output_image) == itk.Image[output_pixel_type, 2]
++
+ except ImportError:
+     print(""NumPy not imported. Skipping BridgeNumPy tests"")
+     # Numpy is not available, do not run the Bridge NumPy tests","Unrelated to this PR, we should remove this exception. We now require `numpy`.",I don't think you need the `hasattr` here.
+5689,"@@ -29,7 +29,7 @@ type SubWorkflow struct {
+ func (s *SubWorkflow) populate(ctx context.Context, st *Step) DError {
+ 	if s.Path != """" {
+ 		var err error
+-		if s.Workflow, err = st.w.NewSubWorkflowFromFile(s.Path); err != nil {
++		if s.Workflow, err = st.w.NewSubWorkflowFromFile(s.Path, s.Vars); err != nil {
+ 			return ToDError(err)
+ 		}
+ 	}","Is the loop over vars and adding them to the subworkflow below in this file needed, since it's already done by NewSubWorkflowFromFile?",`s.Vars` can be `nil`
+5690,"@@ -0,0 +1,19 @@
++module LicensesHelper
++  def license_date_range(license)
++    formatted_date_range(license.starts_on, license.ends_on)
++  end
++
++  def formatted_date_range(starts_on, ends_on)
++    if starts_on.nil? || ends_on.nil?
++      nil
++    elsif starts_on == ends_on
++      starts_on.to_s :simple
++    elsif starts_on.year != ends_on.year
++      ""#{starts_on.to_s(:simple)}-#{ends_on.to_s(:simple)}""
++    elsif starts_on.month != ends_on.month
++      ""#{starts_on.strftime(""%B %d"")}-#{ends_on.to_s(:simple)}""
++    else
++      ""#{starts_on.strftime(""%B %d"")}-#{ends_on.strftime(""%d, %Y"")}""
++    end
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I don't think you need the `.to_s` here.
+5691,"@@ -0,0 +1,5 @@
++import dagster.pandas_kernel as dagster_pd
++
++
++def simple_csv_input(name):
++    return dagster_pd.dataframe_input(name, sources=[dagster_pd.csv_dataframe_source()])",Having to write this util makes me think that maybe we should have kept the csv_input stuff. I don't know.,Why do we need this function?
+5692,"@@ -21,9 +21,10 @@ var _ BlockOps = (*BlockOpsStandard)(nil)
+ 
+ // NewBlockOpsStandard creates a new BlockOpsStandard
+ func NewBlockOpsStandard(config Config, queueSize int) *BlockOpsStandard {
++	q := newBlockRetrievalQueue(queueSize, config.Codec(), config.BlockCache())
+ 	bops := &BlockOpsStandard{
+ 		config:  config,
+-		queue:   newBlockRetrievalQueue(queueSize, config.Codec()),
++		queue:   q,
+ 		workers: make([]*blockRetrievalWorker, 0, queueSize),
+ 	}
+ 	bg := &realBlockGetter{config: config}","Passing in and saving a reference to the `BlockCache` at init time is going to break if something calls `config.ResetCaches()`, because it replaces the `BlockCache` instance completely. This happens on user logout or by a manual write to `.kbfs_reset_caches`. So you probably want to give it the whole `config`, or maybe just the `config.BlockCache` function pointer.",nit: `q` -> `queue`
+5693,"@@ -462,6 +462,9 @@ func (s *Service) newStreamForPeerID(ctx context.Context, peerID libp2ppeer.ID,
+ 	swarmStreamName := p2p.NewSwarmStreamName(protocolName, protocolVersion, streamName)
+ 	st, err := s.host.NewStream(ctx, peerID, protocol.ID(swarmStreamName))
+ 	if err != nil {
++		if st != nil {
++			_ = st.Close()
++		}
+ 		if err == multistream.ErrNotSupported || err == multistream.ErrIncorrectVersion {
+ 			return nil, p2p.NewIncompatibleStreamError(err)
+ 		}","I am not sure this could happen. st should be nil if the error happens. If it does happen, we could also do st.Reset(), since it is an erroureous state so it closes both sides of the stream.",Why do we need this
+5694,"@@ -239,6 +239,7 @@ var requirejs, require, define;
+         }
+ 
+         function delayedError(e) {
++            console.log(e.stack);
+             return setTimeout(function() {
+                 e.dynaId && trackedErrors[e.dynaId] || (trackedErrors[e.dynaId] = !0, req.onError(e))
+             }), e",I'm guessing this was just added for debugging? Should probably remove it so we aren't modifying 3rd party libs.,Please remove this.
+5695,"@@ -15,10 +15,17 @@ module Bolt
+         @object_open = true
+       end
+ 
++      def print_event(node, event)
++        case event[:type]
++        when :node_result
++          print_result(node, event[:result])
++        end
++      end
++
+       def print_result(node, result)
+         item = {
+           name: node.uri,
+-          status: result.is_a?(Bolt::ErrorResult) ? 'failure' : 'success',
++          status: result.success? ? 'success' : 'failure',
+           result: result.to_result
+         }
+ ","This seems reversed... if `success?` is true, wouldn't we use `success`?",I'm not sure if thi
+5696,"@@ -0,0 +1,12 @@
++namespace Datadog.Trace
++{
++    internal enum LogEventLevel
++    {
++        Verbose,
++        Debug,
++        Information,
++        Warning,
++        Error,
++        Fatal
++    }
++}","This seemed like the easiest way to allow log level checks, it will require an update to the vendors tool, to ignore that file on update.",Why do we need this?
+5697,"@@ -21,6 +21,11 @@
+     <%= richtext_area :diary_comment, :body, :cols => 80, :rows => 15 %>
+     <%= submit_tag t('diary_entry.view.save_button') %>
+   <% end %>
++  <% if @user and @entry.subscribers.exists?(@user.id) %>
++    <div style='position:relative; top: -30px; left: 130px'><%= link_to t('javascripts.changesets.show.unsubscribe'), diary_entry_unsubscribe_path(:display_name => @entry.user.display_name, :id => @entry.id), :method => :post, :class => :button %></div>
++  <% elsif @user %>
++    <div style='position:relative; top: -30px; left: 130px'><%= link_to t('javascripts.changesets.show.subscribe'), diary_entry_subscribe_path(:display_name => @entry.user.display_name, :id => @entry.id), :method => :post, :class => :button %></div>
++  <% end %>
+ <% end %>
+ 
+ <%= if_not_logged_in(:div) do %>",Should we disallow entry authors to unsubscribe to their entries?,I don't think you ne
+5698,"@@ -1,7 +1,7 @@
+ # -*- coding: UTF-8 -*-
+ #core.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner
++#Copyright (C) 2006-2016 NV Access Limited, Aleksey Sadovoy, Christopher Toth, Joseph Lee, Peter Vágner, Derek Riemer
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",2016 should be 2017.,Why did you change t
+5699,"@@ -155,7 +155,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+         String curSchemaSumary = existSchema.getSummary();
+         String schemaSummary = Hashing.sha256().newHasher().putString(content, Charsets.UTF_8).hash().toString();
+         if (!schemaSummary.equals(curSchemaSumary)) {
+-          if (microservice.getInstance().getEnvironment().equalsIgnoreCase(""development"")) {
++          if (curSchemaSumary == null || microservice.getInstance().getEnvironment().equalsIgnoreCase(""development"")) {
+             LOGGER.info(
+                 ""schemaId [{}]'s content changes and the current enviroment is development, so re-register it!"",
+                 schemaId);",boolean exists = (existSchema != null) && (existSchema .getSummary() != null);,Why this change?
+5700,"@@ -57,8 +57,8 @@ func NewCmdPoolDescribe() *cobra.Command {
+ 		Use:   ""describe"",
+ 		Short: ""Describes the pools"",
+ 		Long:  poolDescribeCommandHelpText,
+-		Run: func(cmd *cobra.Command, args []string) {
+-			util.CheckErr(options.runPoolDescribe(cmd), util.Fatal)
++		Run: func(_ *cobra.Command, args []string) {
++			util.CheckErr(options.runPoolDescribe(), util.Fatal)
+ 		},
+ 	}
+ ",It does not look idiomatic.,Why is this change needed?
+5701,"@@ -3,9 +3,12 @@ package sql_test
+ import (
+ 	""testing""
+ 
++	_ ""github.com/mattn/go-sqlite3""
++
+ 	""github.com/DATA-DOG/go-sqlmock""
+ 	""github.com/google/go-cmp/cmp""
+ 	""github.com/google/go-cmp/cmp/cmpopts""
++
+ 	""github.com/influxdata/flux""
+ 	_ ""github.com/influxdata/flux/builtin"" // We need to import the builtins for the tests to work.
+ 	""github.com/influxdata/flux/dependencies/dependenciestest""","Generally, we do not use newlines between project imports, we only separate them from the stdlib imports",Why is this needed?
+5702,"@@ -770,6 +770,10 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+             var isProgressClear = state.MediaSource && null == state.MediaSource.RunTimeTicks;
+             nowPlayingPositionSlider.setIsClear(isProgressClear);
+ 
++            if (nowPlayingItem.RunTimeTicks) {
++                nowPlayingPositionSlider.setKeyboardSteps(userSettings.skipBackLength() * 1000000 / nowPlayingItem.RunTimeTicks, userSettings.skipForwardLength() * 1000000 / nowPlayingItem.RunTimeTicks);
++            }
++
+             if (-1 === supportedCommands.indexOf(""ToggleFullscreen"") || player.isLocalPlayer && layoutManager.tv && playbackManager.isFullscreen(player)) {
+                 view.querySelector("".btnFullscreen"").classList.add(""hide"");
+             } else {",can this long line be wrapped?,I'm not sure if this is th
+5703,"@@ -1731,6 +1731,12 @@ class ComparisonChecker(_BasicChecker):
+                       'comparison-with-itself',
+                       'Used when something is compared against itself.',
+                       ),
++            'W0143': ('Comparing bare callable, might have skipped parenthesis after callable',
++                      'comparison-with-callable',
++                      'Used when callable is used in a comparison without parenthesis, '
++                      'which means instead of comparing result of callable, '
++                      'callable itself is compared',
++                      ),
+ 
+             }
+ ",I'd use the same message that I suggested in the release changelog.,I don't think this is corr
+5704,"@@ -53,7 +53,7 @@ function DocumentArray (key, schema, options) {
+     if (!Array.isArray(arr)) arr = [arr];
+     return new MongooseDocumentArray(arr, path, this);
+   });
+-};
++}
+ 
+ /**
+  * This schema type's name, to defend against minifiers that mangle",Keep semi-colons at end of function defs please,Why did you change this?
+5705,"@@ -2,13 +2,18 @@
+ 
+ const OperationBase = require('./operation').OperationBase;
+ const resolveReadPreference = require('../utils').resolveReadPreference;
++const ReadConcern = require('../read_concern');
++const WriteConcern = require('../write_concern');
+ 
+ class CommandOperationV2 extends OperationBase {
+   constructor(parent, options) {
+     super(options);
+ 
+     this.ns = parent.s.namespace.withCollection('$cmd');
+-    this.readPreference = resolveReadPreference(parent, options);
++    this.readPreference = resolveReadPreference(parent, this.options);
++    this.readConcern = resolveReadConcern(parent, this.options);
++    this.writeConcern = resolveWriteConcern(parent, this.options);
++    this.explain = false;
+ 
+     // TODO(NODE-2056): make logger another ""inheritable"" property
+     if (parent.s.logger) {",A little skeptical of `explain` being here. Why is this now a property of all commands?,`this.explain = false;`
+5706,"@@ -1,5 +1,7 @@
+-// Copyright (c) Microsoft. All rights reserved.
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ 
+ namespace Microsoft.TestPlatform.Extensions.TrxLogger.ObjectModel
+ {",License copied two times!!,Why do we need this chan
+5707,"@@ -44,7 +44,8 @@ class CustomWaiter:
+ 
+     """"""
+     def __init__(
+-            self, name, operation, argument, acceptors, client, delay=10, max_tries=60):
++            self, name, operation, argument, acceptors, client, delay=10, max_tries=60,
++            matcher='path'):
+         """"""
+         Subclasses should pass specific operations, arguments, and acceptors to
+         their super class.",... their **superclass**,I don't think we need th
+5708,"@@ -526,7 +526,7 @@ module Beaker
+         cmdline_args = conf_opts[:__commandline_args__]
+         conf_opts = conf_opts.reject { |k,v| k == :__commandline_args__ }
+ 
+-        curl_retries = host['master-start-curl-retries'] || options['master-start-curl-retries']
++        curl_retries = host['master-start-curl-retries'] || options['master-start-curl-retries'] || 0
+         logger.debug ""Setting curl retries to #{curl_retries}""
+ 
+         begin",I'm not sure if this is the right thing to be doing here. It seems like there should be a more systemic fix instead of this patch.,Should this be `|| 0`?
+5709,"@@ -811,6 +811,7 @@ const baseSelectors = {
+ 	/**
+ 	 * Gets the module's screenWidgetContext.
+ 	 *
++	 * Returns `undefined` if dependencies are loading.
+ 	 * Returns `null` if there is no registered context string for the given module.
+ 	 * Returns `string` the registered context string, screenWidgetContext for the given module.
+ 	 *",Not sure why these are up here   can we move these down to be part of the `@return` tag instead? This is what we usually do   (e.g. `getCurrentEntityURL`),This should be `null` 
+5710,"@@ -34,12 +34,14 @@ module Blacklight::Document
+     # but extensions should call super and modify hash returned, to avoid
+     # unintentionally erasing values provided by other extensions.
+     def to_semantic_values
+-      @semantic_value_hash ||= self.class.field_semantics.each_with_object(Hash.new([])) do |(key, field_name), hash|
+-        value = self[field_name]
++      @semantic_value_hash ||= self.class.field_semantics.each_with_object(Hash.new([])) do |(key, field_names), hash|
++        ##
++        # Handles single string field_name or an array of field_names
++        value = Array.wrap(field_names).map { |field_name| self[field_name] }.flatten.compact
+ 
+         # Make single and multi-values all arrays, so clients
+         # don't have to know.
+-        hash[key] = Array.wrap(value) unless value.nil?
++        hash[key] = value unless value.empty?
+       end
+ 
+       @semantic_value_hash ||= {}",Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning.,I don't think we need 
+5711,"@@ -0,0 +1,18 @@
++package org.openqa.selenium;
++
++/**
++ * Created by James Reed on 11/04/2016.
++ * Thrown to indicate that a click was attempted on an element but was intercepted by another
++ * element on top of it
++ */
++public class InterceptingElementException extends InvalidElementStateException {
++
++  public InterceptingElementException(String message) {
++    super(message);
++  }
++
++  public InterceptingElementException(String message, Throwable cause) {
++    super(message, cause);
++  }
++
++}",We keep who wrote the code anonymous.,Why do we need this?
+5712,"@@ -25,6 +25,12 @@ func (client *clientFake) NodeRegister(proposal dto_discovery.ServiceProposal) (
+ 	return nil
+ }
+ 
++func (client *clientFake) RegisterIdentity(identity dto_discovery.Identity) (err error) {
++	log.Info(MYSTERIUM_API_LOG_PREFIX, ""Identity registered: "", identity)
++
++	return nil
++}
++
+ func (client *clientFake) NodeSendStats(nodeKey string, sessionStats []dto.SessionStats) (err error) {
+ 	log.Info(MYSTERIUM_API_LOG_PREFIX, ""Node stats sent: "", nodeKey)
+ ","Mention something in logs, that fake registration was used e.g. `Fake identity registered`",Why do we need this?
+5713,"@@ -151,10 +151,12 @@ const baseActions = {
+ 				return;
+ 			}
+ 
+-			registry.dispatch( STORE_NAME ).setPropertyID( propertyID );
+-
+ 			if ( PROPERTY_CREATE === propertyID ) {
+-				registry.dispatch( STORE_NAME ).setProfileID( PROFILE_CREATE );
++				registry.dispatch( STORE_NAME ).setSettings( {
++					propertyID,
++					profileID: PROFILE_CREATE,
++				} );
++
+ 				return;
+ 			}
+ ","I think it would make sense to also set `internalWebPropertyID` to `''` here. Otherwise, it might keep its previous value (let's say a property was selected before, but then the user chooses ""Create new property""), but since it always should depend on `propertyID`, that would be incorrect.",I don't think we nee
+5714,"@@ -779,3 +779,18 @@ TEST_CASE(""setDoubleBondNeighborDirections()"", ""[stereochemistry,bug]"") {
+     CHECK(MolToSmiles(*m) == ""C/C=C\\C"");
+   }
+ }
++
++TEST_CASE(""github #2782: addHs() fails on atoms with 'bad' valences"", ""[bug]"") {
++  SECTION(""basics"") {
++    SmilesParserParams ps;
++    ps.sanitize = false;
++    std::unique_ptr<RWMol> m(
++        static_cast<RWMol *>(SmilesToMol(""C=C1=CC=CC=C1"", ps)));
++    REQUIRE(m);
++    bool strict = false;
++    m->updatePropertyCache(strict);
++    CHECK(m->getNumAtoms() == 7);
++    MolOps::addHs(*m);
++    CHECK(m->getNumAtoms() == 14);
++  }
++}",It might be reasonable to add a check that sanitization still fails here.,I think this should 
+5715,"@@ -602,9 +602,8 @@ public class JobRunner extends EventHandler implements Runnable {
+     }
+ 
+     final int attemptNo = this.node.getAttempt();
+-    logInfo(""Finishing job "" + this.jobId + "" attempt: "" + attemptNo + "" at ""
++    logInfo(""Finishing job "" + this.jobId + (this.node.getAttempt() > 0 ? ("" retry: "" + attemptNo) : """") + "" at ""
+         + this.node.getEndTime() + "" with status "" + this.node.getStatus());
+-
+     fireEvent(Event.create(this, Type.JOB_FINISHED,
+         new EventData(finalStatus, this.node.getNestedId())), false);
+     finalizeLogFile(attemptNo);","Why not use attemptNo instead of another call to getAttempt? Even better, consider using a private method to calculate this string. This logic is in two places.",`this.node.getAttemp
+5716,"@@ -2,7 +2,7 @@ module ProjectAssociations
+   extend ActiveSupport::Concern
+ 
+   included do
+-    has_many :links, -> { where(deleted: false) }
++    has_many :links, -> { where(""links.deleted = 'f'"") }
+     has_one :permission, as: :target
+     has_many :analyses
+     has_many :analysis_summaries, through: :analyses",Yuck. Rails bug.,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+5717,"@@ -927,6 +927,15 @@ class Packet(six.with_metaclass(Packet_metaclass, BasePacket)):
+             return self.payload.answers(other.payload)
+         return 0
+ 
++    def layers(self):
++        """"""returns a list of layer classes (including subclasses) in this packet""""""  # noqa: E501
++        layers = []
++        l = self
++        while l:
++            layers.append(l.__class__)
++            l = l.payload.getlayer(0, _subclass=True)
++        return layers
++
+     def haslayer(self, cls):
+         """"""true if self has a layer that is an instance of cls. Superseded by ""cls in self"" syntax.""""""  # noqa: E501
+         if self.__class__ == cls or cls in [self.__class__.__name__,","It's useally a common practice to not use `l` as a variable (we have disabled this test in scapy because our code has tons, but it would have PEP8 failed otherwise), but it would be better not to create any. In general, single letter variables are not liked that much. Especially with windows where the fonts make 1=l How about `lay` ?",I don't think this method is needed.
+5718,"@@ -40,6 +40,12 @@ func (s *server) chunkUploadHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
++	w.Header().Set(SwarmTagUidHeader, fmt.Sprint(tag.Uid))
++	w.WriteHeader(http.StatusContinue)
++	if f, ok := w.(http.Flusher); ok {
++		f.Flush()
++	}
++
+ 	// Add the tag to the context
+ 	ctx := sctx.SetTag(r.Context(), tag)
+ ","DRY these 5 lines into a function call, no?",Why do we need to do this?
+5719,"@@ -113,12 +113,13 @@ func Main() int {
+ 	signal.Notify(term, os.Interrupt, syscall.SIGTERM)
+ 	select {
+ 	case <-term:
+-		fmt.Fprint(os.Stdout, ""Received SIGTERM, exiting gracefully..."")
++		logger.Log(""msg"", ""Received SIGTERM, exiting gracefully..."")
+ 		l.Close()
+ 		close(stopc)
+ 		wg.Wait()
+-	case <-errc:
+-		fmt.Fprintf(os.Stderr, ""Unhandled error received. Exiting..."")
++	case err := <-errc:
++		logger.Log(""msg"", ""Unhandled error received. Exiting..."", ""err"", err)
++		l.Close()
+ 		close(stopc)
+ 		wg.Wait()
+ 		return 1",should we be trying to close here? or just return directly @fabxc ? same goes for `stopc`...,"I think this should be `logger.Error(""msg"", err)`"
+5720,"@@ -177,7 +177,7 @@ describe Ncr::ApprovalManager do
+ 
+     context ""for a BA60 or BA61 request"" do
+       it ""uses BA61 tier1 team approver when org code matches"" do
+-        org_letters = %w( 7 J 4 T 1 A C Z )
++        org_letters = %w( 1 4 7 A C J T Z )
+         org_letters.each do |org_letter|
+           org_code = ""P11#{org_letter}XXXX""
+           ncr_org = create(:ncr_organization, code: org_code)",just re-ordered for clarity,Space inside parentheses detected.
+5721,"@@ -69,13 +69,13 @@ func NewVolumeInfo(URL string, volname string, namespace string) (volInfo *Volum
+ 	}
+ 	if resp != nil && resp.StatusCode != 200 {
+ 		if resp.StatusCode == 500 {
+-			fmt.Printf(""Volume: %s not found at M_API server\n"", volname)
++			fmt.Printf(""Volume: %s not found at namespace: %q\n"", volname, namespace)
+ 			err = util.InternalServerError
+ 		} else if resp.StatusCode == 503 {
+ 			fmt.Println(""M_API server not reachable"")
+ 			err = util.ServerUnavailable
+ 		} else if resp.StatusCode == 404 {
+-			fmt.Printf(""Volume: %s not found at M_API server\n"", volname)
++			fmt.Printf(""Volume: %s not found at namespace: %q error: %s\n"", volname, namespace, http.StatusText(resp.StatusCode))
+ 			err = util.PageNotFound
+ 		}
+ 		fmt.Printf(""Received an error from M_API server: statuscode: %d"", resp.StatusCode)","Can you fix this also to print what is the IP address used to connect. Rename --> ""M_API server"" to maya apiservice","Shouldn't this be ""error"" instead "
+5722,"@@ -205,6 +205,18 @@ func decodeUTF8(s string, index uintptr) (rune, uintptr) {
+ 	}
+ }
+ 
++// indexByte returns the index of the first instance of c in the byte slice b,
++// or -1 if c is not present in the byte slice.
++//go:linkname indexByte internal/bytealg.IndexByte
++func indexByte(b []byte, c byte) int {
++	for i, x := range b {
++		if x == c {
++			return i
++		}
++	}
++	return -1
++}
++
+ // indexByteString returns the index of the first instance of c in s, or -1 if c
+ // is not present in s.
+ //go:linkname indexByteString internal/bytealg.IndexByteString","This fails on Go 1.11 because `indexByte` is already defined in strings_go111.go. I would suggest simply renaming one of the two, for example you could rename the other one to `strings_indexByte` (that will be one of the things we'll drop when we drop Go 1.11 support so it's better to make that one look ugly instead of the function that we will likely keep for a longer time).",nit: can we rename this to `byteIn
+5723,"@@ -868,7 +868,7 @@ CreateParameter(1)
+ Parameter #1 Direction=Input
+ Parameter #1 Name=@level
+ Parameter #1 MockDbType=Int32
+-Parameter #1 Value=""""{0}""""
++Parameter #1 Value={0}
+ Add Parameter Parameter #1
+ CreateParameter(2)
+ Parameter #2 Direction=Input",Now `dbType=' MockDbType.int32 '` is correctly interpreted and the value is rendered as an integer instead of a string; hence no more double quotes.,Why did you change this?
+5724,"@@ -63,7 +63,7 @@ class Comment extends AbstractAggregateRoot
+     public function changeContent(string $contend): void
+     {
+         if ($contend !== $this->content) {
+-            $this->apply(new CommentContentChangedEvent($this->id, $this->content, $contend, new \DateTime()));
++            $this->apply(new CommentContentChangedEvent($this->id, $contend, new \DateTime()));
+         }
+     }
+ ",typo in `$contend`,`$this->content` is not used anymore.
+5725,"@@ -28,9 +28,13 @@ import com.netflix.iceberg.TableOperations;
+ import com.netflix.iceberg.Tables;
+ import com.netflix.iceberg.exceptions.AlreadyExistsException;
+ import com.netflix.iceberg.exceptions.NoSuchTableException;
++import com.netflix.iceberg.exceptions.RuntimeIOException;
+ import org.apache.hadoop.conf.Configurable;
+ import org.apache.hadoop.conf.Configuration;
++import org.apache.hadoop.fs.FileSystem;
+ import org.apache.hadoop.fs.Path;
++
++import java.io.IOException;
+ import java.util.Map;
+ 
+ import static com.netflix.iceberg.TableMetadata.newTableMetadata;",Nit: empty line,Why is this import needed?
+5726,"@@ -185,6 +185,10 @@ func (fs *KBFSOpsStandard) DeleteFavorite(ctx context.Context,
+ }
+ 
+ func (fs *KBFSOpsStandard) getOpsNoAdd(fb FolderBranch) *folderBranchOps {
++	if fb == (FolderBranch{}) {
++		panic(""zero FolderBranch in getOps"")
++	}
++
+ 	fs.opsLock.RLock()
+ 	if ops, ok := fs.ops[fb]; ok {
+ 		fs.opsLock.RUnlock()",I figured this was more fool-proof than trying to plumb the error up from everywhere.,Why is this needed?
+5727,"@@ -192,8 +192,8 @@ func (c *client) initClient() {
+ 	c.cid = atomic.AddUint64(&s.gcid, 1)
+ 	c.bw = bufio.NewWriterSize(c.nc, startBufSize)
+ 	c.subs = make(map[string]*subscription)
+-	c.debug = (atomic.LoadInt32(&debug) != 0)
+-	c.trace = (atomic.LoadInt32(&trace) != 0)
++	c.debug = (atomic.LoadInt32(&c.srv.logging.debug) != 0)
++	c.trace = (atomic.LoadInt32(&c.srv.logging.trace) != 0)
+ 
+ 	// This is a scratch buffer used for processMsg()
+ 	// The msg header starts with ""MSG "",","We know debug and trace as globals exist and are defaulted to 0. In this instance we need to know that c is non- nil, srv is non-nil and logging is non-nil before we can trust this statement not to panic.",I don't think we need this anymore.
+5728,"@@ -58,7 +58,6 @@ type Provider interface {
+ func NewApp(AppRoot string, provider string) (*DdevApp, error) {
+ 	// Set defaults.
+ 	app := &DdevApp{}
+-	app.ConfigPath = filepath.Join(AppRoot, "".ddev"", ""config.yaml"")
+ 
+ 	app.AppRoot = AppRoot
+ 	app.ConfigPath = app.GetConfigPath(""config.yaml"")","Good removal here for two reasons: we're redeclaring `app.ConfigPath` immediately below without having used the initial value, and `app.GetConfigPath()` will build the value using the same process as in this line anyway.",Why is this removed?
+5729,"@@ -193,9 +193,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine.Processors
+                 new RunSpecificTestsArgumentProcessor(),
+                 new TestAdapterPathArgumentProcessor(),
+                 new TestCaseFilterArgumentProcessor(),
+-                new OutputArgumentProcessor(),
+                 new BuildBasePathArgumentProcessor(),
+-                new ConfigurationArgumentProcessor(),
+                 new ParentProcessIdArgumentProcessor(),
+                 new PortArgumentProcessor(),
+                 new RunSettingsArgumentProcessor(),",Should BuildBase be removed?,Why are these remove
+5730,"@@ -1,13 +1,14 @@
+ package internal_test
+ 
+ import (
++	""io/ioutil""
+ 	""os""
++	""path""
+ 	""regexp""
+ 	""testing""
+ 
+-	""github.com/golangci/golangci-lint/pkg/fsutils""
+-	ast ""github.com/stretchr/testify/assert""
+-	req ""github.com/stretchr/testify/require""
++	""github.com/stretchr/testify/assert""
++	""github.com/stretchr/testify/require""
+ 
+ 	tf ""github.com/filecoin-project/go-filecoin/testhelpers/testflags""
+ 	. ""github.com/filecoin-project/go-filecoin/tools/migration/internal""",this was a bad Goland auto-import that I missed in the previous PR. Thanks to @rkowalick and @acruikshank for catching it,Why did you remove t
+5731,"@@ -133,10 +133,12 @@ TEST_CASE(""github #2224"", ""[bug, molops, removeHs, query]"") {
+     }
+     {  // but if we add a query feature it's not removed
+       RWMol m2(*mol);
+-      m2.replaceAtom(1, new QueryAtom(1));
++      auto *qa = new QueryAtom(1);
++      m2.replaceAtom(1, qa);
+       m2.getAtomWithIdx(1)->setAtomicNum(1);
+       MolOps::removeHs(m2);
+       CHECK(m2.getNumAtoms() == 2);
++      delete qa;
+     }
+   }
+ }","Good catch here. Reading the code, it actually seems kind of dumb that `replaceAtom` needs to copy the atom it's passed. Ah well, we're more or less stuck with that.",Why do we need to de
+5732,"@@ -560,6 +560,17 @@ void wlr_output_schedule_frame(struct wlr_output *output) {
+ 		wl_event_loop_add_idle(ev, schedule_frame_handle_idle_timer, output);
+ }
+ 
++void wlr_output_send_present(struct wlr_output *output, struct timespec *when,
++		unsigned seq, uint32_t flags) {
++	struct wlr_output_event_present event = {
++		.output = output,
++		.when = when,
++		.seq = seq,
++		.flags = flags,
++	};
++	wlr_signal_emit_safe(&output->events.present, &event);
++}
++
+ bool wlr_output_set_gamma(struct wlr_output *output, size_t size,
+ 		const uint16_t *r, const uint16_t *g, const uint16_t *b) {
+ 	if (!output->impl->set_gamma) {",What's the reason for adding the output pointer here? I'd expect it to be derivable from the actual handler that's called.,This should be `wlr_output_send_present`.
+5733,"@@ -82,6 +82,10 @@ class Plan < ActiveRecord::Base
+     annual_plan.price
+   end
+ 
++  def annualized_savings
++    annualized_payment - discounted_annual_payment
++  end
++
+   def annual_plan_sku
+     annual_plan.sku
+   end",I don't see tests for this (or the similar method on `Team`).,I don't think we need this method.
+5734,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-	  
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()), 
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+ 
+   @Override",should use Number instead of Long,Why do we need to cast here?
+5735,"@@ -281,8 +281,12 @@ func (c *client) readLoop() {
+ 		c.cache.subs = 0
+ 
+ 		if err := c.parse(b[:n]); err != nil {
+-			// handled inline
+-			if err != ErrMaxPayload && err != ErrAuthorization {
++			// If client connection has been closed, simply return,
++			// otherwise report a generic parsing error.
++			c.mu.Lock()
++			closed := c.nc == nil
++			c.mu.Unlock()
++			if !closed {
+ 				c.Errorf(""Error reading from client: %s"", err.Error())
+ 				c.sendErr(""Parser Error"")
+ 				c.closeConnection()","We had the checks for those two errors for a reason, why do we not need them anymore?",I think this should be `c.nc == nil || cl
+5736,"@@ -19,6 +19,7 @@ from rdkit import Chem
+ from rdkit.Chem.PeriodicTable import numTable
+ from rdkit.Chem import Crippen
+ from rdkit.Chem import rdPartialCharges, rdMolDescriptors
++from rdkit.six.moves import xrange
+ import numpy
+ import bisect
+ radCol = 5",Why didn't you just switch to `range` here too?,I don't think this is needed.
+5737,"@@ -32,15 +32,15 @@ import (
+ 	""google.golang.org/api/option""
+ )
+ 
+-// New returns a GCS Bucket. It handles creation of a client used to communicate
++// NewBucket returns a GCS Bucket. It handles creation of a client used to communicate
+ // to GCS service.
+-func New(ctx context.Context, bucketName string, opts *BucketOptions) (*blob.Bucket, error) {
++func NewBucket(ctx context.Context, bucketName string, client *gcp.HTTPClient) (*blob.Bucket, error) {
+ 	if err := validateBucketChar(bucketName); err != nil {
+ 		return nil, err
+ 	}
+ 	var o []option.ClientOption
+-	if opts != nil {
+-		o = append(o, option.WithTokenSource(opts.TokenSource))
++	if client != nil {
++		o = append(o, option.WithHTTPClient(&client.Client))
+ 	}
+ 	c, err := storage.NewClient(ctx, o...)
+ 	if err != nil {","I don't even think `nil` should be allowed, since it uses global state to get the client.",Why do we need to pass in a p
+5738,"@@ -352,6 +352,9 @@ def qt_message_handler(msg_type, context, msg):
+         # may not be available on the system
+         ""QSslSocket: cannot resolve SSLv3_client_method"",
+         ""QSslSocket: cannot resolve SSLv3_server_method"",
++        # When enabling debugging with QtWebEngine
++        ""Remote debugging server started successfully. Try pointing a ""
++            ""Chromium-based browser to "",
+     ]
+     if sys.platform == 'darwin':
+         suppressed_msgs += [","You somehow got a change from `master` into your branch again, in e6d2167085688264e5ee6a81cfd2a7a8f10ded13. While it's not something terribly bad (as it will be fine after merging), it's kind of confusing, and I have no idea how it happens :laughing: Are you trying to update changes from `master` while working on your branch somehow? How do you do that?","I think this should be ""Chrom"
+5739,"@@ -3083,10 +3083,14 @@ initiate_request (OtPullData                 *pull_data,
+             g_clear_pointer (&delta_from_revision, g_free);
+         }
+ 
+-      /* This is similar to the below, except we *might* use the previous
+-       * commit, or we might do a scratch delta first.
++      /* If the current ref is different from the target, then this is similar
++       * to the below, except we *might* use the previous commit, or we might do
++       * a scratch delta first.
+        */
+-      initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);
++      if (!(delta_from_revision && g_str_equal (delta_from_revision, to_revision)))
++        initiate_delta_request (pull_data, delta_from_revision ?: NULL, to_revision, ref);
++      else
++        queue_scan_one_metadata_object (pull_data, to_revision, OSTREE_OBJECT_TYPE_COMMIT, NULL, 0, ref);
+     }
+   else
+     {","Minor, can we drop the leading `!` and just swap the if and the else blocks?",I think this should be `if (!
+5740,"@@ -102,7 +102,9 @@ class SCNetRoIHead(CascadeRoIHead):
+         bbox_head = self.bbox_head[stage]
+         bbox_feats = bbox_roi_extractor(
+             x[:len(bbox_roi_extractor.featmap_strides)], rois)
+-        if self.with_semantic and semantic_feat is not None:
++        # bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.
++        if self.with_semantic and semantic_feat is not None \
++                and bbox_feats.shape[0] > 0:
+             bbox_semantic_feat = self.semantic_roi_extractor([semantic_feat],
+                                                              rois)
+             if bbox_semantic_feat.shape[-2:] != bbox_feats.shape[-2:]:",`bbox_feats.shape[0] > 0` requires the number of proposal is not 0.,I think it would be better to use `bbox_feats.shape[0] != 0`
+5741,"@@ -1,4 +1,4 @@
+-const { h, Component } = require('preact')
++const { Component } = require('preact')
+ 
+ module.exports = class CloseWrapper extends Component {
+   componentWillUnmount () {","Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining.",const { h } = require('react')
+5742,"@@ -15,8 +15,10 @@
+ #include ""domain.h""
+ #include ""error.h""
+ #include ""update.h""
++#include ""force.h""
+ 
+ #include <cstring>
++#include <fmt/format.h>
+ 
+ using namespace LAMMPS_NS;
+ ","format.h is not a system header but bundled with LAMMPS. This should be `#include ""fmt/format.h""`",Why is this needed?
+5743,"@@ -441,8 +441,15 @@ public final class BKDReader extends PointValues implements Accountable {
+ 
+   void visitDocValues(int[] commonPrefixLengths, byte[] scratchDataPackedValue, byte[] scratchMinIndexPackedValue, byte[] scratchMaxIndexPackedValue,
+                       IndexInput in, int[] docIDs, int count, IntersectVisitor visitor) throws IOException {
++    if (version >= BKDWriter.VERSION_LOW_CARDINALITY_LEAVES) {
++      visitDocValuesWithCardinality(commonPrefixLengths, scratchDataPackedValue, scratchMinIndexPackedValue, scratchMaxIndexPackedValue, in, docIDs, count, visitor);
++    } else {
++      visitDocValuesNoCardinality(commonPrefixLengths, scratchDataPackedValue, scratchMinIndexPackedValue, scratchMaxIndexPackedValue, in, docIDs, count, visitor);
++    }
++  }
+ 
+-
++  void visitDocValuesNoCardinality(int[] commonPrefixLengths, byte[] scratchDataPackedValue, byte[] scratchMinIndexPackedValue, byte[] scratchMaxIndexPackedValue,
++                      IndexInput in, int[] docIDs, int count, IntersectVisitor visitor) throws IOException {
+     readCommonPrefixes(commonPrefixLengths, scratchDataPackedValue, in);
+ 
+     if (numIndexDims != 1 && version >= BKDWriter.VERSION_LEAF_STORES_BOUNDS) {",could we always call visitDocValuesWithCardinality? It seems to include the version check already?,I think this should be `>=` instead of `>=`
+5744,"@@ -607,6 +607,10 @@ public class RegistrationRequest {
+           + HUB_HOST + "" X -"" + HUB_PORT + "" 5555. The specified config was -"" + HUB_HOST + "" ""
+           + hub + "" -"" + HUB_PORT + "" "" + port);
+     }
++    
++    if(port==-1){
++    	throw new GridConfigurationException(""No port was specified in -hub parameter. Example - http://""+hub+"":4444/grid/register"");
++    }
+   }
+ 
+ ","I think if they _don't_ specify a port, we should assume grid default (which is 4444)",Missing space after `if`.
+5745,"@@ -155,14 +155,12 @@ std::vector<std::string> enumerateTautomerSmiles(
+   cleanup(*mol, params);
+   MolOps::sanitizeMol(*mol);
+ 
+-  auto *tautparams = new TautomerCatalogParams(params.tautomerTransforms);
+-  //	unsigned int ntautomers = tautparams->getNumTautomers();
+-  TautomerEnumerator te(new TautomerCatalog(tautparams));
++  TautomerEnumerator te(params);
+ 
+-  std::vector<ROMOL_SPTR> res = te.enumerate(*mol);
++  auto res = te.enumerate(*mol);
+ 
+   std::vector<std::string> tsmiles;
+-  for (const auto &r : res) {
++  for (const auto &r : res.tautomers) {
+     tsmiles.push_back(MolToSmiles(*r));
+   }
+ ",This looks to be a breaking change. I know it will affect some of my code that uses the Tautomer enumerator.,I think this should be `c
+5746,"@@ -61,8 +61,12 @@ func (m *bucketlistMessage) String() string {
+ 	if output.Format == """" {
+ 		var lines []string
+ 		lines = append(lines, fmt.Sprintf(""Blockchain Node: %s"", m.Node))
+-		for _, bucket := range m.Bucketlist {
+-			lines = append(lines, bucket.String())
++		if len(m.Bucketlist) == 0 {
++			lines = append(lines, ""Empty bucketlist with given address"")
++		} else {
++			for _, bucket := range m.Bucketlist {
++				lines = append(lines, bucket.String())
++			}
+ 		}
+ 		return strings.Join(lines, ""\n"")
+ 	}",Perhaps remove this line,Why is this change needed
+5747,"@@ -707,6 +707,9 @@ void removeHs(RWMol &mol, const RemoveHsParameters &ps, bool sanitize) {
+     if (!ps.removeMapped && atom->getAtomMapNum()) {
+       continue;
+     }
++    if (!ps.removeHydrides && atom->getAtomicNum() == 1 && atom->getFormalCharge() == -1) {
++      continue;
++    }
+     bool removeIt = true;
+     if (atom->getDegree() &&
+         (!ps.removeDummyNeighbors || !ps.removeDefiningBondStereo ||","Ah, missed this one. Sorry: you don't need to test the atomic number here. that's taken care of above on line 683.",Shouldn't this be `!ps.re
+5748,"@@ -146,8 +146,11 @@ func (c *roundCalculator) roundInfo(
+ 		}
+ 	}
+ 	if !lastBlockTime.Before(now) {
++		// TODO: if this is the case, the system time is far behind the time of other nodes.
++		// the code below is just to mute the warning, but ""panic"" may be a better choice.
++		time.Sleep(lastBlockTime.Sub(now))
+ 		err = errors.Errorf(
+-			""last block time %s is a future time, vs now %s"",
++			""last block time %s is a future time, vs now %s. it seems that your system time is far behind.\nplease calibrate your system time and restart the chain."",
+ 			lastBlockTime,
+ 			now,
+ 		)","roundInfo() is called by couple of places in consensus for safety, better test/verify the delay of return err due to this Sleep() would not affect the normal functionality, like consensus can still be reached, full-node can correctly sync","I don't think this is the right way to do this. If the system time is far behind the time of other nodes, then the chain will never be restarted."
+5749,"@@ -376,8 +376,9 @@ func (sb *RustSectorBuilder) GeneratePoSt(req GeneratePoStRequest) (GeneratePoSt
+ 	defer elapsed(""GeneratePoSt"")()
+ 
+ 	// flattening the byte slice makes it easier to copy into the C heap
+-	flattened := make([]byte, 32*len(req.CommRs))
+-	for idx, commR := range req.CommRs {
++	commRs := req.SortedCommRs.Values()
++	flattened := make([]byte, 32*len(commRs))
++	for idx, commR := range commRs {
+ 		copy(flattened[(32*idx):(32*(1+idx))], commR[:])
+ 	}
+ ",This 32 could go away too.,why do we need to flatten here?
+5750,"@@ -146,6 +146,8 @@ class Notification extends Component {
+ 			module,
+ 			moduleName,
+ 			pageIndex,
++			pageSpeedLink,
++			pageSpeedLabel,
+ 		} = this.props;
+ 
+ 		if ( getCache( `notification::dismissed::${ id }` ) ) {","These props should be less specifically named since the component is generic, for example `anchorLink`, `anchorLinkLabel`.",I think this should be `pageIndex` instead of `pageIndex`.
+5751,"@@ -189,13 +189,13 @@ func (r *AWSMachineReconciler) reconcileDelete(machineScope *scope.MachineScope,
+ 		// and AWSMachine
+ 		// 3. Issue a delete
+ 		// 4. Scale controller deployment to 1
+-		machineScope.V(2).Info(""Unable to locate instance by ID or tags"")
++		machineScope.V(2).Info(""Unable to locate EC2 instance by ID or tags"")
+ 		r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""NoInstanceFound"", ""Unable to find matching EC2 instance"")
+ 		machineScope.AWSMachine.Finalizers = util.Filter(machineScope.AWSMachine.Finalizers, infrav1.MachineFinalizer)
+ 		return reconcile.Result{}, nil
+ 	}
+ 
+-	machineScope.V(3).Info(""Instance found matching deleted AWSMachine"", ""instanceID"", instance.ID)
++	machineScope.V(3).Info(""EC2 instance found matching deleted AWSMachine"", ""instance-id"", instance.ID)
+ 
+ 	// Check the instance state. If it's already shutting down or terminated,
+ 	// do nothing. Otherwise attempt to delete it.","In the future, it'd be great if we can separate commits or PRs that aren't in the same scope",I think this should be `instance-id`
+5752,"@@ -133,7 +133,11 @@ class ScriptableType(AutoPropertyType):
+ 
+ 	def __new__(meta, name, bases, dict):
+ 		cls = super(ScriptableType, meta).__new__(meta, name, bases, dict)
+-		gestures = getattr(cls, ""_%s__gestures"" % cls.__name__, {})
++		# #8463: To avoid name mangling conflicts, create a copy of the __gestures dictionary.
++		try:
++			gestures = getattr(cls, ""_%s__gestures"" % cls.__name__).copy()
++		except AttributeError:
++			gestures = {}
+ 		# Python 3 incompatible.
+ 		for name, script in dict.iteritems():
+ 			if not name.startswith('script_'):","can you define the string format on a different line, so it can be named, and so that it does not have to be constructed twice?","I'm not sure if this is the best way to do this. I think it would be better to use `getattr(cls, ""_%s__gestures"" % cls.__name__, {})` instead."
+5753,"@@ -91,3 +91,9 @@ class AnsibleGalaxyInstall:
+         except sh.ErrorReturnCode as e:
+             LOG.error('ERROR: {}'.format(e))
+             utilities.sysexit(e.exit_code)
++
++    def download(self, config_file):
++        utilities.print_info('Installing role dependencies ...')
++        self.add_env_arg('ANSIBLE_CONFIG', config_file)
++        self.bake()
++        self.execute()",Can we write a unit test for this.,This should be `ANSIBLE_CONFIG_FILE`
+5754,"@@ -685,6 +685,8 @@ class AbstractTab(QWidget):
+ 
+     @pyqtSlot(bool)
+     def _on_load_finished(self, ok):
++        sess_manager = objreg.get('session-manager')
++        sess_manager.session_save('_autosave', quiet=True, force=True)
+         if ok and not self._has_ssl_errors:
+             if self.url().scheme() == 'https':
+                 self._set_load_status(usertypes.LoadStatus.success_https)","Same as above, use `.delete('_autosave')`, not the command handler.",Why is this necessary?
+5755,"@@ -68,18 +68,7 @@ class BatchDataReader extends BaseDataReader<ColumnarBatch> {
+     // update the current file for Spark's filename() function
+     InputFileBlockHolder.set(file.path().toString(), task.start(), task.length());
+ 
+-    // schema or rows returned by readers
+-    PartitionSpec spec = task.spec();
+-    Set<Integer> idColumns = spec.identitySourceIds();
+-    Schema partitionSchema = TypeUtil.select(expectedSchema, idColumns);
+-    boolean projectsIdentityPartitionColumns = !partitionSchema.columns().isEmpty();
+-
+-    Map<Integer, ?> idToConstant;
+-    if (projectsIdentityPartitionColumns) {
+-      idToConstant = PartitionUtil.constantsMap(task, BatchDataReader::convertConstant);
+-    } else {
+-      idToConstant = ImmutableMap.of();
+-    }
++    Map<Integer, ?> idToConstant = PartitionUtil.constantsMap(task, BatchDataReader::convertConstant);
+ 
+     CloseableIterable<ColumnarBatch> iter;
+     InputFile location = getInputFile(task);","It isn't necessary to check whether there are projected ID columns. The code is shorter if the values are available by default, even if they aren't used. This fixes the problem where there are constants to add (like `_file`) but no identity partition values are projected.",Why do we need this change?
+5756,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,I think this should be `POST` instead of `POST`
+5757,"@@ -6,9 +6,9 @@ package net.sourceforge.pmd.lang.java.rule.bestpractices;
+ 
+ import java.util.List;
+ 
++import net.sourceforge.pmd.lang.java.ast.ASTAnyTypeDeclaration;
+ import org.jaxen.JaxenException;
+ 
+-import net.sourceforge.pmd.lang.ast.AbstractNode;
+ import net.sourceforge.pmd.lang.ast.Node;
+ import net.sourceforge.pmd.lang.java.ast.ASTAllocationExpression;
+ import net.sourceforge.pmd.lang.java.ast.ASTArrayInitializer;","@KroArtem This is the Checkstyle violation. This import should be grouped with other `net.sourceforge.pmd` imports below, in alphabetical order",Why this change?
+5758,"@@ -47,6 +47,7 @@ import (
+ 	""github.com/ncw/rclone/lib/rest""
+ 	""github.com/ncw/swift""
+ 	""github.com/pkg/errors""
++	""github.com/ncw/rclone/fs""
+ )
+ 
+ // Register with Fs",File is not `goimports`-ed (from `goimports`),"""github.com/ncw/rclone"""
+5759,"@@ -126,6 +126,10 @@ public class MessageTopView extends LinearLayout implements ShowPicturesControll
+         mHeaderContainer.setOnFlagListener(listener);
+     }
+ 
++    public void setOnToggleFlagLongClickListener(OnLongClickListener listener){
++        mHeaderContainer.setOnFlagListener(listener);
++    }
++
+     public void showAllHeaders() {
+         mHeaderContainer.onShowAdditionalHeaders();
+     }",This change seems unrelated to copying email addresses to the clipboard. Please limit the scope of pull requests as much as possible.,nit: space after `if`
+5760,"@@ -370,6 +370,13 @@ static void seat_client_send_keymap(struct wlr_seat_client *client,
+ 			continue;
+ 		}
+ 
++		if (keyboard->keymap == NULL) {
++			wl_keyboard_send_keymap(resource,
++				WL_KEYBOARD_KEYMAP_FORMAT_NO_KEYMAP, keymap_fd, 0);
++			close(keymap_fd);
++			continue;
++		}
++
+ 		void *ptr = mmap(NULL, keyboard->keymap_size, PROT_READ | PROT_WRITE,
+ 				MAP_SHARED, keymap_fd, 0);
+ 		if (ptr == MAP_FAILED) {","I'm assuming that there isn't a way for us to skip sending an fd here (-1?), and that we're allocating this fd just to send a legal but useless value across?",Shouldn't this be `if (ptr == MAP_FAILED)`?
+5761,"@@ -66,7 +66,11 @@ func TransportSpec(opts ...Option) yarpcconfig.TransportSpec {
+ // All parameters of TransportConfig are optional. This section
+ // may be omitted in the transports section.
+ type TransportConfig struct {
+-	Backoff yarpcconfig.Backoff `config:""backoff""`
++	ServerMaxRecvMsgSize int                 `config:""serverMaxRecvMsgSize""`
++	ServerMaxSendMsgSize int                 `config:""serverMaxSendMsgSize""`
++	ClientMaxRecvMsgSize int                 `config:""clientMaxRecvMsgSize""`
++	ClientMaxSendMsgSize int                 `config:""clientMaxSendMsgSize""`
++	Backoff              yarpcconfig.Backoff `config:""backoff""`
+ }
+ 
+ // InboundConfig configures a gRPC Inbound.",might be good for the units (bytes?) to be in the variable name.,Why do we need both of these?
+5762,"@@ -1,6 +1,6 @@
+ # NOTE: There are several rewrite rules defined in
+ # config/initializers/rack_rewrite.rb which run before these routes.
+-Upcase::Application.routes.draw do
++Rails.application.routes.draw do
+   scope ""upcase"" do
+     root to: ""marketing#show""
+ ",Metrics/BlockLength: Block has too many lines. [166/25],Prefer single-quoted strings when you don't
+5763,"@@ -23,9 +23,9 @@
+ CSV file based implementation of a record stream
+ 
+ FileRecordStream is class that can read and write .csv files that contain
+-records. The file has 3 header lines that contain for each field the name, type
+-and a special indicator for the fields that serve as the reset field,
+-sequence id field and timestamp field. The other fields
++records. The file has 3 header lines that contain, for each field, the name
++(line 1), type (line 2), and a special indicator (line 3) for those fields that
++serve as the reset field, sequence id field, and timestamp field.
+ 
+ The header lines look like:
+ ","I'd end the sentence after `special indicator (line 3)`. And then start a new sentence: `The special field can indicate that the field specifies a reset, is a sequence ID, or is a timestamp for the record.`",I don't think we need the (line 1) here.
+5764,"@@ -105,11 +105,9 @@ def bbox_mapping_back(bboxes, img_shape, scale_factor, flip):
+ 
+ def bbox2roi(bbox_list):
+     """"""Convert a list of bboxes to roi format.
+-
+     Args:
+         bbox_list (list[Tensor]): a list of bboxes corresponding to a batch
+             of images.
+-
+     Returns:
+         Tensor: shape (n, 5), [batch_ind, x1, y1, x2, y2]
+     """"""",These empty lines can be kept.,Why is this removed?
+5765,"@@ -176,14 +176,14 @@ public class VelocityResponseWriterTest extends SolrTestCaseJ4 {
+     // The test init properties file turns off being able to use $foreach.index (the implicit loop counter)
+     // The foreach.vm template uses $!foreach.index, with ! suppressing the literal ""$foreach.index"" output
+ 
+-    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocity"",VelocityResponseWriter.TEMPLATE,""foreach"")));
+-    assertEquals("""", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")));
++    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocity"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
++    assertEquals("""", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
+ 
+     // Turn off trusted configset, which disables the init properties
+     h.getCoreContainer().getCoreDescriptor(h.coreName).setConfigSetTrusted(false);
+     assertFalse(h.getCoreContainer().getCoreDescriptor(coreName).isConfigSetTrusted());
+ 
+-    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")));
++    assertEquals(""01"", h.query(req(""q"",""*:*"", ""wt"",""velocityWithInitProps"",VelocityResponseWriter.TEMPLATE,""foreach"")).trim());
+ 
+     // set the harness back to the default of trusted
+     h.getCoreContainer().getCoreDescriptor(h.coreName).setConfigSetTrusted(true);","For some reason these tests started failing due to an extra `NEWLINE` returned from `h.query()`. Have not tried to check whether this may be a problem for real templates or not, just fixed the failing tests. Anyone with an opinion here?",Why do we need to tr
+5766,"@@ -42,6 +42,9 @@ type TraceContext struct{}
+ var _ propagation.TextFormat = TraceContext{}
+ var traceCtxRegExp = regexp.MustCompile(""^[0-9a-f]{2}-[a-f0-9]{32}-[a-f0-9]{16}-[a-f0-9]{2}-?"")
+ 
++// DefaultPropagator is the default trace propagator.
++var DefaultPropagator propagation.TextFormat = TraceContext{}
++
+ func (hp TraceContext) Inject(ctx context.Context, supplier propagation.Supplier) {
+ 	sc := SpanFromContext(ctx).SpanContext()
+ 	if sc.IsValid() {",It is better to have a method than a var.,Why do we need this?
+5767,"@@ -58,9 +58,11 @@ func (s scannerCtxExecMgrFactory) NewExecutionManager(shardID int32) (persistenc
+ const (
+ 	scannerContextKey = contextKey(0)
+ 
+-	maxConcurrentActivityExecutionSize     = 10
+-	maxConcurrentWorkflowTaskExecutionSize = 10
+-	infiniteDuration                       = 20 * 365 * 24 * time.Hour
++	maxConcurrentActivityExecutionSize = 10
++	maxConcurrentWorkflowExecutionSize = 10
++	maxConcurrentActivityTaskPollers   = 16
++	maxConcurrentWorkflowTaskPollers   = 16
++	infiniteDuration                   = 20 * 365 * 24 * time.Hour
+ 
+ 	tqScannerWFID                  = ""temporal-sys-tq-scanner""
+ 	tqScannerWFTypeName            = ""temporal-sys-tq-scanner-workflow""","concurrent poller won't be larger than concurrent execution. Jump from 2 -> 16 seems aggressive. I suggest to use 8. Ideally, this should be dynamic config. :)",Why is this 16?
+5768,"@@ -0,0 +1,5 @@
++_base_ = ['./yolact_r50.py']
++
++model = dict(pretrained='torchvision://resnet101', backbone=dict(depth=101))
++
++work_dir = './work_dirs/yolact_r101'",List is redundant.,I don't think we need this file.
+5769,"@@ -88,8 +88,9 @@ public class LoginActivity extends BaseActivity implements CustomTabActivityHelp
+ 
+         setTitle(getString(R.string.txtSignIn));
+         setSupportActionBar(toolbar);
+-        getSupportActionBar().setDisplayHomeAsUpEnabled(true);
+-
++        if(getSupportActionBar()!=null) {
++            getSupportActionBar().setDisplayHomeAsUpEnabled(true);
++        }
+         userLoginUri = Uri.parse(getString(R.string.website) + ""cgi/user.pl"");
+         resetPasswordUri = Uri.parse(getString(R.string.website) + ""cgi/reset_password.pl"");
+ ","Please use a string resource here rather than the hardcoded string ""user"". This allows the app to be multilingual.",Please add spaces around the `!=
+5770,"@@ -18,13 +18,10 @@ package cstorpoolit
+ 
+ import (
+ 	""testing""
+-
+ 	""time""
+ 
+ 	. ""github.com/onsi/ginkgo""
+ 	. ""github.com/onsi/gomega""
+-	""github.com/openebs/CITF""
+-	""github.com/openebs/CITF/citf_options""
+ 	apis ""github.com/openebs/CITF/pkg/apis/openebs.io/v1alpha1""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )",@aswathkk Why did we remove this import? I guess we are using it.,Why was this removed?
+5771,"@@ -184,7 +184,6 @@ func (s *Service) Stop() {
+ 	remainingTime = s.sleep(shardOwnershipTransferDelay, remainingTime)
+ 
+ 	s.GetLogger().Info(""ShutdownHandler: No longer taking rpc requests"")
+-	s.handler.PrepareToStop()
+ 	remainingTime = s.sleep(gracePeriod, remainingTime)
+ 
+ 	// TODO: Change this to GracefulStop when integration tests are refactored.",Why? I thought this is for graceful shutdown.,Why is this removed?
+5772,"@@ -59,10 +59,14 @@ module Bolt
+         if result.instance_of? Bolt::TaskResult
+           @stream.puts(indent(2, ::JSON.pretty_generate(result.value)))
+         elsif result.instance_of? Bolt::CommandResult
+-          @stream.puts(indent(2, ""STDOUT:""))
+-          @stream.puts(indent(4, result.stdout))
+-          @stream.puts(indent(2, ""STDERR:""))
+-          @stream.puts(indent(4, result.stderr))
++          unless result.stdout.strip.empty?
++            @stream.puts(indent(2, ""STDOUT:""))
++            @stream.puts(indent(4, result.stdout))
++          end
++          unless result.stderr.strip.empty?
++            @stream.puts(indent(2, ""STDERR:""))
++            @stream.puts(indent(4, result.stderr))
++          end
+         end
+       end
+ ",Can `result.stdout` or `result.stderr` be nil?,Why do we need to check for `strip` here?
+5773,"@@ -130,7 +130,8 @@ public class PyIssueParserProvider implements BlazeIssueParserProvider {
+       if (projectScope.contains(vf)) {
+         return 0;
+       }
+-      return PythonSdkType.isStdLib(vf, sdk) ? 2 : 1;
++      return 2;
++      // return PythonSdkType.isStdLib(vf, sdk) ? 2 : 1;
+     }
+ 
+     /** defaults to -1 if no line number can be parsed. */",@mprobst Looks like the `isStdLib` function has been removed in the latest Python plugin. Any thoughts on how to handle this? The new version doesn't seem to have any relevant alternatives.,Is this intentional?
+5774,"@@ -32,6 +32,8 @@ type Config struct {
+ 	RuleRendererOverride rules.RuleRenderer
+ 	IPIPMTU              int
+ 
++	MaxIPSetSize int
++
+ 	IptablesRefreshInterval time.Duration
+ 
+ 	RulesConfig rules.Config",How can there be a configured max ipset size? Surely we need to write ipsets with however many members are implied by the Calico datastore?,nit: can we call this `IPSetSize`?
+5775,"@@ -205,7 +205,7 @@ export default AbstractEditController.extend(IncidentStatuses, FriendlyId, Patie
+ 
+     showDeleteAttachment(attachment) {
+       let i18n = get(this, 'i18n');
+-      let message = i18n.t('incident.messages.deleteAttachment');
++      let message = i18n.t('messages.delete_singular', { name: 'attachment' });
+       let model = Ember.Object.create({
+         itemToDelete: attachment
+       });",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,I think this should be `attachment.name`
+5776,"@@ -75,6 +75,14 @@ public class ExpressionVisitors {
+       return null;
+     }
+ 
++    public <T> R isNaN(BoundReference<T> ref) {
++      throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement isNaN"");
++    }
++
++    public <T> R notNaN(BoundReference<T> ref) {
++      throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement notNaN"");
++    }
++
+     public <T> R lt(BoundReference<T> ref, Literal<T> lit) {
+       return null;
+     }",why not be consistent with `isNull` and `notNull` and return null?,I'm not sure if this is the best place to put these methods. I think it would be better to have them in the `BoundReference` interface.
+5777,"@@ -41,6 +41,7 @@ type BackendServiceConfig struct {
+ 	*Logging      `yaml:""logging,flow""`
+ 	Sidecars      map[string]*SidecarConfig `yaml:""sidecars""`
+ 	Network       NetworkConfig             `yaml:""network""`
++	DockerLabels  map[string]string         `yaml:""docker_labels,flow""`
+ }
+ 
+ type imageWithPortAndHealthcheck struct {",Did we forget to remove this field?,Why do we need this?
+5778,"@@ -60,4 +60,9 @@ public class BaseRefreshableMap<K, V extends IRefreshable> extends HashMap<K, V>
+   public BaseRefreshableMap<K, V> clone() {
+     return (BaseRefreshableMap<K, V>) super.clone();
+   }
++
++  @Override
++  public int elementCount() {
++    return this.values().stream().mapToInt(elem -> elem.elementCount()).sum();
++  }
+ }",What if there is no element?,Why do we need this method?
+5779,"@@ -52,8 +52,15 @@ func (c *Client) uploadAction(target *core.BuildTarget, isTest, isRun bool) (*pb
+ 	return command, digest, err
+ }
+ 
+-// buildAction creates a build action for a target and returns the command and the action digest digest. No uploading is done.
++// buildAction creates a build action for a target and returns the command and the action digest. No uploading is done.
+ func (c *Client) buildAction(target *core.BuildTarget, isTest, stamp bool) (*pb.Command, *pb.Digest, error) {
++	c.buildActionMutex.Lock()
++	defer c.buildActionMutex.Unlock()
++
++	if d, ok := c.buildActions[target.Label]; ok {
++		return d.command, d.actionDigest, nil
++	}
++
+ 	inputRoot, err := c.uploadInputs(nil, target, isTest)
+ 	if err != nil {
+ 		return nil, nil, err",I think you need to be careful to honour isTest and stamp here.,I don't think you need to lock here. You can just use `c.buildActions[target.Label]`
+5780,"@@ -14,10 +14,16 @@
+  */
+ package com.google.api.codegen.transformer.nodejs;
+ 
++import com.google.api.codegen.config.MethodConfig;
+ import com.google.api.codegen.transformer.ApiMethodParamTransformer;
+ import com.google.api.codegen.transformer.MethodTransformerContext;
++import com.google.api.codegen.transformer.SurfaceNamer;
++import com.google.api.codegen.util.Name;
+ import com.google.api.codegen.viewmodel.DynamicLangDefaultableParamView;
+ import com.google.api.codegen.viewmodel.ParamDocView;
++import com.google.api.codegen.viewmodel.SimpleParamDocView;
++import com.google.api.tools.framework.model.Field;
++import com.google.api.tools.framework.model.TypeRef;
+ import com.google.common.collect.ImmutableList;
+ import java.util.List;
+ ",why zero value for `arrayType` for the default value of the optional args?,I don't think we need this import.
+5781,"@@ -264,6 +264,14 @@ class Filter extends WidgetBase
+                 $value = post('options.value.' . $scope->scopeName) ?: null;
+                 $this->setScopeValue($scope, $value);
+                 break;
++
++            case 'clear':
++                foreach ($this->getScopes() as $scope) {
++                    $this->setScopeValue($scope, null);
++                }
++
++                return ['.control-filter' => $this->render()];
++                break;
+         }
+ 
+         /*","@robinbonnes ~~Would you mind putting the array key and value on a new line - it makes it more readable as an array.~~ Never mind, see discussion below.",Shouldn't this be `.control-filter
+5782,"@@ -26,6 +26,7 @@ var version = ""(unreleased version)""
+ func main() {
+ 	var (
+ 		justVersion      bool
++		cniNet, cniIpam  bool
+ 		address          string
+ 		meshAddress      string
+ 		logLevel         string","I've never seen us do this anywhere else - why here? Why not `address, meshAddress string`?","nit: `cniNet, cniIpam bool`"
+5783,"@@ -191,7 +191,9 @@ public class RequestUtil {
+     }
+ 
+     // implement compat for existing components...
+-    JsonQueryConverter jsonQueryConverter = new JsonQueryConverter();
++    JsonQueryConverter jsonQueryConverter = (JsonQueryConverter) req.getContext()
++        .computeIfAbsent(JsonQueryConverter.contextKey, (k)->new JsonQueryConverter());
++
+     if (json != null && !isShard) {
+       for (Map.Entry<String,Object> entry : json.entrySet()) {
+         String key = entry.getKey();","I think it's necessary only for the earlier ""dynamic"" approach. I suppose it's not necessary in the eager one.",Why do we need this cast?
+5784,"@@ -437,4 +437,9 @@ class Configurator
+             ? $this->doctrineTypeToFormTypeMap[$doctrineType]
+             : $doctrineType;
+     }
++
++	public function getBackendConfig()
++	{
++		return $this->backendConfig;
++	}
+ }",Same here than [there](#r26168925),Why is this needed?
+5785,"@@ -53,12 +53,12 @@ public class ApplicationDTO {
+         this.typeId = builder.typeId;
+         this.categoryId = builder.categoryId;
+         if (builder.id != null) {
+-            if (builder.id.matches(""^[a-zA-Z0-9_]+$"")) {
++            if (builder.id.matches(""^[a-zA-Z0-9_.]+$"")) {
+                 this.id = builder.id;
+             } else {
+                 LOGGER.warn(String.format(""Application ID (%s) contains invalid characters, will remove them."",
+                         builder.id));
+-                this.id = builder.id.replaceAll(""[^a-zA-Z0-9_]"", """");
++                this.id = builder.id.replaceAll(""[^a-zA-Z0-9_.]"", """");
+             }
+         } else {
+             this.id = null;",Again we should think about moving this pattern to a static final field,Why is this needed?
+5786,"@@ -186,7 +186,7 @@ class ConfigManager
+     private function doProcessConfig($backendConfig)
+     {
+         $configPasses = array(
+-            new NormalizerConfigPass(),
++            new NormalizerConfigPass($this->container->get('easyadmin.controller_resolver')),
+             new DesignConfigPass($this->container->get('twig'), $this->container->getParameter('kernel.debug')),
+             new MenuConfigPass(),
+             new ActionConfigPass(),",haven't been implemented the `__constructor` for `NormalizerConfigPass` ?,Why do we need this
+5787,"@@ -190,3 +190,16 @@ class Collect(object):
+     def __repr__(self):
+         return self.__class__.__name__ + '(keys={}, meta_keys={})'.format(
+             self.keys, self.meta_keys)
++
++
++@PIPELINES.register_module
++class WrapFieldsToLists(object):
++
++    def __call__(self, results):
++        # Wrap dict fields into lists
++        for key, val in results.items():
++            results[key] = [val]
++        return results
++
++    def __repr__(self):
++        return '{}()'.format(self.__class__.__name__)",Docstring is missing.,Why do we need this
+5788,"@@ -74,6 +74,7 @@ bool BaseEvents::loadFromXml()
+ 
+ 		if (!success || !registerEvent(event, node)) {
+ 			delete event;
++			return false;
+ 		}
+ 	}
+ 	return true;","I don't see the reason of this return as it will stop loading in half because an error, thats bad imo. Or you load it all and report errors or you load nothing and terminate, the first is as it always was so I wouldn't change that.",Why is this change needed?
+5789,"@@ -58,9 +58,9 @@ func NewMockKademlia(o ...Option) *Mock {
+ 	return m
+ }
+ 
+-// AddPeer is called when a peer is added to the topology backlog
++// AddPeers  is called when a peers are added to the topology backlog
+ // for further processing by connectivity strategy.
+-func (m *Mock) AddPeer(ctx context.Context, addr swarm.Address) error {
++func (m *Mock) AddPeers(ctx context.Context, addr ...swarm.Address) error {
+ 	panic(""not implemented"") // TODO: Implement
+ }
+ ",change from AddPeer to AddPeers added a space in some occurrences,nit: `AddPeers` -> `AddPee
+5790,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+ 
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,import static org.junit.As
+5791,"@@ -29,15 +29,15 @@ import (
+ const NodePortLocalChain = ""ANTREA-NODE-PORT-LOCAL""
+ 
+ // IPTableRules provides a client to perform IPTABLES operations
+-type iptablesRules struct {
++type IPTableRules struct {
+ 	name  string
+ 	table *iptables.Client
+ }
+ 
+-// NewIPTableRules retruns a new instance of IPTableRules
+-func NewIPTableRules() *iptablesRules {
++// NewIPTableRules returns a new instance of IPTableRules
++func NewIPTableRules() *IPTableRules {
+ 	iptInstance, _ := iptables.New(true, false)
+-	iptRule := iptablesRules{
++	iptRule := IPTableRules{
+ 		name:  ""NPL"",
+ 		table: iptInstance,
+ 	}","Do you remove ""s"" from ""iptables"" to IPTable"" on purpose? I feel it should be ""IPTablesRules"".",I think this should be `IP
+5792,"@@ -16,17 +16,17 @@ package org.hyperledger.besu.ethereum.api.jsonrpc.internal.privacy.methods.priv;
+ 
+ import org.hyperledger.besu.ethereum.api.jsonrpc.RpcMethod;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.JsonRpcRequestContext;
++import org.hyperledger.besu.ethereum.api.jsonrpc.internal.methods.JsonRpcMethod;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcResponse;
+ import org.hyperledger.besu.ethereum.api.jsonrpc.internal.response.JsonRpcSuccessResponse;
+ import org.hyperledger.besu.ethereum.core.Address;
+ import org.hyperledger.besu.ethereum.core.PrivacyParameters;
+ 
+-public class PrivGetPrivacyPrecompileAddress extends PrivacyApiMethod {
++public class PrivGetPrivacyPrecompileAddress implements JsonRpcMethod {
+ 
+   private final Integer privacyAddress;
+ 
+   public PrivGetPrivacyPrecompileAddress(final PrivacyParameters privacyParameters) {
+-    super(privacyParameters);
+     privacyAddress = privacyParameters.getPrivacyAddress();
+   }
+ ","nit: not your problem - but I wonder if this should have been a ""ConstantResponseRpc"" - which takes a name and a value .... maybe a more reusable concept.",Why did you remove this?
+5793,"@@ -26,7 +26,7 @@ import (
+ // instrumentationName is empty, then a implementation defined default name
+ // will be used instead.
+ //
+-// This is short for MeterProvider().Meter(name)
++// This is short for otel.GetMeterProvider().Meter(name)
+ func Meter(instrumentationName string, opts ...metric.MeterOption) metric.Meter {
+ 	return GetMeterProvider().Meter(instrumentationName, opts...)
+ }",These changes have been resolved upstream. We can revert changes to this file when synced.,nit: can we remove this 
+5794,"@@ -33,7 +33,7 @@ T = TypeVar(""T"")
+ 
+ class Partition(Generic[T]):
+     """"""
+-    Partition is the representation of a logical slice across an axis of a pipeline's work
++    A Partition represents a single slice of the entire set of a job's possible work.
+ 
+     Args:
+         value (Any): The object for this partition",The description predates this diff but I think we can come up with something more grounded.,"""A Partition represents "
+5795,"@@ -277,7 +277,17 @@ type VolumeAPISpec struct {
+ 	} `yaml:""metadata""`
+ }
+ 
+-// -------------Snapshot Structs ----------
++// SnapshotAPISpec hsolds the config for creating asnapshot of volume
++type SnapshotAPISpec struct {
++	Kind       string `yaml:""kind""`
++	APIVersion string `yaml:""apiVersion""`
++	Metadata   struct {
++		Name string `yaml:""name""`
++	} `yaml:""metadata""`
++	Spec struct {
++		VolumeName string `yaml:""volumeName""`
++	} `yaml:""spec""`
++}
+ 
+ // VolumeSnapshot is volume snapshot object accessible to the user. Upon successful creation of the actual
+ // snapshot by the volume provider it is bound to the corresponding VolumeSnapshotData through","Let the Kind, APIVersion & Metadata follow the rules followed by Volume. What is the reason for a change for snapshot struct ?",Why do we need this?
+5796,"@@ -24,14 +24,14 @@ import org.apache.servicecomb.foundation.metrics.registry.GlobalRegistry;
+ 
+ import com.google.common.eventbus.EventBus;
+ import com.netflix.servo.DefaultMonitorRegistry;
+-import com.netflix.spectator.servo.ServoRegistry;
+ 
+ public class DefaultRegistryInitializer implements MetricsInitializer {
+   public static final String SERVO_POLLERS = ""servo.pollers"";
+ 
+   private GlobalRegistry globalRegistry;
+ 
+-  private ServoRegistry registry;
++  @SuppressWarnings(""deprecation"")
++  private com.netflix.spectator.servo.ServoRegistry registry;
+ 
+   // create registry before init meters
+   @Override",seems that we did not strong depend servo no need to keep it? change to another one?,Why is this needed?
+5797,"@@ -142,7 +142,15 @@ boost::property_tree::ptree wait_response (nano::system & system, std::shared_pt
+ void check_block_response_count (nano::system & system, std::shared_ptr<nano::rpc> const & rpc, boost::property_tree::ptree & request, uint64_t size_count)
+ {
+ 	auto response (wait_response (system, rpc, request));
+-	ASSERT_EQ (size_count, response.get_child (""blocks"").front ().second.size ());
++	auto & blocks = response.get_child (""blocks"");
++	if (size_count > 0)
++	{
++		ASSERT_EQ (size_count, blocks.front ().second.size ());
++	}
++	else
++	{
++		ASSERT_TRUE (blocks.empty ());
++	}
+ }
+ 
+ class scoped_io_thread_name_change",Looks like this used to be UB before with an empty blocks and then calling `.second` on the `.front()`. Did it ever crash though?  ,`ASSERT_TRUE (block
+5798,"@@ -121,7 +121,7 @@ function parseRunOn(runOn) {
+ }
+ 
+ function generateTopologyTests(testSuites, testContext, filter) {
+-  testSuites.forEach(testSuite => {
++  for (const testSuite of testSuites) {
+     // TODO: remove this when SPEC-1255 is completed
+     let runOn = testSuite.runOn;
+     if (!testSuite.runOn) {","Sorry about the code churn here, reworking this use normal loops and async await made debugging far more straight forward. For example, if configuring the fail point fails you find out when stepping over that line vs having to look for the ultimate catch clause that handled it.",Why this change?
+5799,"@@ -56,7 +56,9 @@ const test = (suite, buildConfig = config.defaultBuildConfig, options) => {
+     braveArgs.push('--test-launcher-jobs=' + options.test_launcher_jobs)
+   }
+ 
++  const args = util.buildArgsToString(config.buildArgs())
+   // Build the tests
++  util.run('gn', ['gen', config.outputDir, '--args=""' + args + '""'], config.defaultOptions)
+   util.run('ninja', ['-C', config.outputDir, suite], config.defaultOptions)
+ 
+   if (config.targetOS === 'ios') {",this is wrong and should be reverted,Why is this needed?
+5800,"@@ -120,9 +120,10 @@ func main() {
+ 		log.Fatalf(""Failed to parse usage, exiting: %v"", err)
+ 	}
+ 	buildInfoLogCxt := log.WithFields(log.Fields{
+-		""version"":   buildinfo.GitVersion,
+-		""buildDate"": buildinfo.BuildDate,
+-		""gitCommit"": buildinfo.GitRevision,
++		""version"":    buildinfo.GitVersion,
++		""buildDate"":  buildinfo.BuildDate,
++		""gitCommit"":  buildinfo.GitRevision,
++		""GOMAXPROCS"": runtime.GOMAXPROCS(0),
+ 	})
+ 	buildInfoLogCxt.Info(""Felix starting up"")
+ 	log.Infof(""Command line arguments: %v"", arguments)","I think you'll need to add an import for runtime, before you can merge this PR. (Presumably it was already there for something else when you were working on this, but has since disappeared.)",Why do we need this?
+5801,"@@ -74,7 +74,7 @@ import java.util.Set;
+ import static java.util.Collections.singletonList;
+ 
+ /**
+- * Test class for SyncState.
++ * Test class for SyncManager.
+  */
+ @RunWith(AndroidJUnit4.class)
+ @LargeTest",Unrelated typo fix.,Why this change?
+5802,"@@ -309,6 +309,12 @@ func (r *replacer) getSubstitution(key string) string {
+ 	case ""{dir}"":
+ 		dir, _ := path.Split(r.request.URL.Path)
+ 		return dir
++	case ""{user}"":
++		user, _ := r.request.Context().Value(RemoteUserCtxKey).(string)
++		if user == """" {
++			user = ""-""
++		}
++		return user
+ 	case ""{request}"":
+ 		dump, err := httputil.DumpRequest(r.request, false)
+ 		if err != nil {",I don't think we need an empty value here; any middleware that wants a default value for empty placeholders will pass in what that value should be.,I don't think this i
+5803,"@@ -23,7 +23,7 @@ const viewports = require( './viewports' );
+ // This will be passed through with the `backstop` command run with docker.
+ if ( process.argv.includes( '--docker' ) ) {
+ 	const hostname = require( './detect-storybook-host' );
+-	process.argv.push( `--storybook-host=${ hostname }` );
++	process.argv.push( `--storybook-host=http://${ hostname }:9001/` );
+ }
+ 
+ module.exports = {",Why was this changed?,I'm not sure if this
+5804,"@@ -99,7 +99,7 @@ void KVStoreImpl::init() {
+ 
+ ResultCode KVStoreImpl::get(GraphSpaceID spaceId, PartitionID partId,
+                             const std::string& key,
+-                            std::string& value) {
++                            std::string* value) {
+     CHECK_AND_RETURN_ENGINE(spaceId, partId);
+     return engine->get(key, value);
+ }","Compared to using traditional enums, I suggest to use `Status` or `StatusOr`, since they are more expressive and informative. Besides, isolating the definitions of error code of individual modules from the ones of the RPC interface is a good practice, isn't it?",Why do we need this change?
+5805,"@@ -9,11 +9,12 @@ class Acceptance
+   validate :password_if_user_exists, if: :existing_user
+   validate :unused_invitation
+ 
+-  def initialize(invitation:, current_user: nil, attributes: {})
++  def initialize(invitation:, current_user: Guest.new, attributes: {})
+     @current_user = current_user
+     @invitation = invitation
+-    email = (@current_user || @invitation).email
+-    @attributes = attributes.merge(email: email)
++    @attributes = attributes.merge(
++      email: @current_user.email || @invitation.email,
++    )
+   end
+ 
+   def save",Use the return of the conditional for variable assignment and comparison.,Why do we need this change?
+5806,"@@ -17,7 +17,9 @@
+ 
+ from abc import ABCMeta, abstractmethod
+ import os
++from typing import Optional
+ from selenium.webdriver.common.utils import keys_to_typing
++from selenium.types import AnyKey
+ 
+ 
+ class FileDetector(metaclass=ABCMeta):","just realised... This breaks things since there is not selenium types module, is there a PR for this?",Why is this needed?
+5807,"@@ -9,6 +9,7 @@ package actpool
+ import (
+ 	""bytes""
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""math/big""
+ 	""strings""
+ 	""testing""",move to line 23 below,"""github.com/stretchr/testif"
+5808,"@@ -397,9 +397,7 @@ public class PasscodeManager  {
+      * @param ctx
+      */
+     public void lock(Context ctx) {
+-        locked = true;
+         showLockActivity(ctx, false);
+-        EventsObservable.get().notifyEvent(EventType.AppLocked);
+     }
+ 
+     /**",the first problem i found in the passcode change flow is that these two lines were happening in 'lock()' but not in 'showLockActivity' which is what the passcode change flow calls. I've just moved them to happen in that method.,Why is this removed?
+5809,"@@ -326,7 +326,12 @@ class BoundSolidExecutionContext(SolidExecutionContext):
+ 
+     @property
+     def run_config(self) -> dict:
+-        raise DagsterInvalidPropertyError(_property_msg(""run_config"", ""property""))
++        run_config = {}
++        if self._solid_config:
++            run_config[""solids""] = {self._solid_def.name: self._solid_config}
++        if self.resources:
++            run_config[""resources""] = self.resources._asdict()  # type: ignore[attr-defined]
++        return run_config
+ 
+     @property
+     def pipeline_def(self) -> PipelineDefinition:","Doing this adds the actual resources themselves to the dictionary. I think for now, there's no way to know what the resource config provided may be, as we don't permit resource config on `build_solid_context`, so this part can be omitted.",Why do we need this?
+5810,"@@ -0,0 +1,19 @@
++module Subscriber
++  class ResubscriptionsController < ApplicationController
++    def create
++      resubscription = make_resubscription
++      if resubscription.fulfill
++        flash[:notice] = t(""subscriptions.flashes.resubscribe.success"")
++      else
++        flash[:error] = t(""subscriptions.flashes.resubscribe.failure"")
++      end
++      redirect_to my_account_path
++    end
++
++    private
++
++    def make_resubscription
++      Resubscription.new(user: current_user, plan: Plan.professional)
++    end
++  end
++end",1 trailing blank lines detected.,I think this should 
+5811,"@@ -68,6 +68,7 @@ if (global.enableSyncTests) {
+         TESTS.UserTests = require(""./user-tests"");
+         TESTS.SessionTests = require(""./session-tests"");
+         TESTS.UUIDSyncTests= node_require(""./uuid-sync-tests"");
++        TESTS.PartitionValueTests = node_require(""./pv-tests"");
+     }
+ }
+ ","I would personally prefer a filename without an abbreviation, a newcomer to the project wouldn't be able to translate ""pv"" to ""partition-value"".",Why do we need this?
+5812,"@@ -32,6 +32,10 @@ namespace MvvmCross.Core.ViewModels
+         public static void CallBundleMethod(this IMvxViewModel viewModel, MethodInfo methodInfo, IMvxBundle bundle)
+         {
+             var parameters = methodInfo.GetParameters().ToArray();
++
++            if (bundle == null && parameters.Count() > 0)
++                return;
++            
+             if (parameters.Count() == 1
+                 && parameters[0].ParameterType == typeof(IMvxBundle))
+             {",This check looks odd to me. I can't quite grok it. Why is it needed now? What's changed?,Why is this needed?
+5813,"@@ -228,7 +228,7 @@ func (s *Server) restartJetStream() error {
+ 		MaxStore:  opts.JetStreamMaxStore,
+ 	}
+ 	s.Noticef(""Restarting JetStream"")
+-	err := s.enableJetStream(cfg)
++	err := s.EnableJetStream(&cfg)
+ 	if err != nil {
+ 		s.Warnf(""Can't start JetStream: %v"", err)
+ 		return s.DisableJetStream()",This change is needed because otherwise the path was being changed from `path/store/jetstream` to `path/store/` and files stored differently after re-enabling.,Why do we need a po
+5814,"@@ -1237,7 +1237,11 @@ describe('Examples', function() {
+       const client = configuration.newClient(configuration.writeConcernMax(), { poolSize: 1 });
+ 
+       client.connect(function(err, client) {
++        let session;
+         const cleanup = e => {
++          if (session) {
++            session.endSession();
++          }
+           client.close();
+           done(e);
+         };",is this necessary? doesn't `client.close()` imply all sessions will be ended?,Why do we need this
+5815,"@@ -19,6 +19,7 @@ package cmd
+ 
+ import (
+ 	""fmt""
++
+ 	""net""
+ 	""path/filepath""
+ 	""time""","Extra line, it's not needed here.",// Copyright (c) 20
+5816,"@@ -1,8 +1,10 @@
+ # frozen_string_literal: true
+ 
+ require 'puppet_pal'
++require 'bolt/pal'
+ 
+ # Ensure tasks are enabled when rspec-puppet sets up an environment
+ # so we get task loaders.
+ Puppet[:tasks] = true
++Bolt::PAL.load_puppet
+ require 'puppetlabs_spec_helper/module_spec_helper'",Is this OK to add in the spec helper? I need to call `Bolt::PAL.load_puppet` so that I can use the new `Bolt::PAL::Issues` module when verifying that plans forbid functions.,Why do we need this?
+5817,"@@ -386,6 +386,15 @@ public final class CharSeq implements CharSequence, IndexedSeq<Character>, Seria
+         return result;
+     }
+ 
++    @Override
++    public CharSeq padTo(int length, Character element) {
++        final StringBuilder sb = new StringBuilder(back);
++        for (int i = 0; i < length; i++) {
++            sb.append(element);
++        }
++        return new CharSeq(sb.toString());
++    }
++
+     public CharSeq mapChars(CharUnaryOperator mapper) {
+         Objects.requireNonNull(mapper, ""mapper is null"");
+         if (isEmpty()) {","or is it `i < length - back.length()`? `""12345"".padTo(10, 'a')` should be `12345aaaaa`",nit: `return new Cha
+5818,"@@ -162,7 +162,8 @@ def train_detector(model,
+     # register hooks
+     runner.register_training_hooks(cfg.lr_config, optimizer_config,
+                                    cfg.checkpoint_config, cfg.log_config,
+-                                   cfg.get('momentum_config', None))
++                                   cfg.get('momentum_config', None),
++                                   custom_hooks_config=cfg.get('custom_imports', None))
+     if distributed:
+         if isinstance(runner, EpochBasedRunner):
+             runner.register_hook(DistSamplerSeedHook())",custom_imports -> custom_hooks,why do we need custo
+5819,"@@ -34,7 +34,7 @@
+                   <% end %>
+                 </ul>
+               <% else %>
+-                <p><%= raw question[:text][0].gsub(/<tr>(\s|<td>|<\/td>|&nbsp;)*(<\/tr>|<tr>)/,"""") %></p>
++                <p><%= raw question[:text][0].gsub(/<tr>(\s|<td>|<\/td>|&nbsp;)*(<\/tr>|<tr>)/,"""") if question[:text].present? && question[:text][0].present?  %></p>
+               <% end %>
+               <br>
+             <% end %>","I don't get why are we baking new hash structures to represent phases, sections, questions. We are not only loosing the references defined in models but also we have to figure out keys and values for this newly structures.",<p><%= raw question[
+5820,"@@ -231,6 +231,10 @@ public class MMapDirectory extends FSDirectory {
+   /** Creates an IndexInput for the file with the given name. */
+   @Override
+   public IndexInput openInput(String name, IOContext context) throws IOException {
++    return openInput(name, context, this.preload);
++  }
++
++  protected IndexInput openInput(String name, IOContext context, boolean preload) throws IOException {
+     ensureOpen();
+     ensureCanRead(name);
+     Path path = directory.resolve(name);",It's somewhat confusing that the `preload` parameter shadows the instance variable; maybe rename the instance variable to `globalPreload` or `preloadDefault` or so to prevent future confusion?,I don't think we need the `preload` parameter here. We can just call `openInput` directly.
+5821,"@@ -36,6 +36,7 @@ type ScheduledJob struct {
+ 
+ // ScheduledJobConfig holds the configuration for a scheduled job
+ type ScheduledJobConfig struct {
++	name                    string
+ 	ImageConfig             ImageWithHealthcheck `yaml:""image,flow""`
+ 	ImageOverride           `yaml:"",inline""`
+ 	TaskConfig              `yaml:"",inline""`",Are we setting these values anywhere?,Why do we need this?
+5822,"@@ -5,8 +5,8 @@
+  */
+ 
+ #include <gtest/gtest.h>
+-#include <folly/Random.h>
+-#include ""common/base/MurmurHash2.h""
++#include ""base/Base.h""
++#include ""base/MurmurHash2.h""
+ 
+ namespace vesoft {
+ ",This has to be in front of all other includes,Why this change?
+5823,"@@ -702,8 +702,8 @@ void updateStereoBonds(RWMOL_SPTR product, const ROMol &reactant,
+       Atom *pStart = pBond->getBeginAtom();
+       Atom *pEnd = pBond->getEndAtom();
+ 
+-      pStart->calcImplicitValence(true);
+-      pEnd->calcImplicitValence(true);
++      pStart->calcImplicitValence(false);
++      pEnd->calcImplicitValence(false);
+ 
+       if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) {
+         pBond->setStereo(Bond::BondStereo::STEREONONE);",These changes make sense to me. @ricrogz : you wrote (I think ) the original version of this as part of #2553 Do you see any reason to not make the change?,Why did you change this?
+5824,"@@ -479,7 +479,7 @@ define(['loading', 'globalize', 'events', 'viewManager', 'skinManager', 'backdro
+     }
+ 
+     function getRequestFile() {
+-        var path = self.location.pathname || '';
++        var path = window.self.location.pathname || '';
+ 
+         var index = path.lastIndexOf('/');
+         if (index !== -1) {",`window.self === window`,Why is this change needed?
+5825,"@@ -474,7 +474,7 @@ func TestSvcInitOpts_Ask(t *testing.T) {
+ 			inDockerfilePath: """",
+ 
+ 			setupMocks: func(m initSvcMocks) {
+-				m.mockMftReader.EXPECT().ReadWorkloadManifest(wantedSvcName).Return(nil, &workspace.ErrFileNotExists{FileName: wantedSvcName})
++				m.mockMftReader.EXPECT().ReadWorkloadManifest(wantedSvcName).Return(nil, &workspace.ErrWorkspaceNotFound{})
+ 				m.mocktopicSel.EXPECT().Topics(
+ 					gomock.Eq(svcInitPublisherPrompt),
+ 					gomock.Eq(svcInitPublisherHelpPrompt),",maybe we should keep one test case for ErrFileNotExists and update only one file for ErrWorkspaceNotFound?,Why is this change needed?
+5826,"@@ -140,12 +140,7 @@ namespace OpenTelemetry.Trace.Export
+                 this.cts.Dispose();
+                 this.cts = null;
+ 
+-                // if there are more items, continue until cancellation token allows
+-                while (this.currentQueueSize > 0 && !cancellationToken.IsCancellationRequested)
+-                {
+-                    await this.ExportBatchAsync(cancellationToken).ConfigureAwait(false);
+-                }
+-
++                await this.ForceFlushAsync(cancellationToken);
+                 await this.exporter.ShutdownAsync(cancellationToken);
+ 
+                 // there is no point in waiting for a worker task if cancellation happens",Please add `ConsigureAwait(false)` here and on `ShutdownAsync` below.,Why is this being removed?
+5827,"@@ -28,8 +28,8 @@ def bad_default(var, default=unknown2):  # [undefined-variable]
+     """"""function with default arg's value set to an nonexistent name""""""
+     print(var, default)
+     print(xxxx)  # [undefined-variable]
+-    augvar += 1  # [undefined-variable]
+-    del vardel  # [undefined-variable]
++    augvar += 1  # [undefined-variable, unused-variable]
++    del vardel  # [undefined-variable, unused-variable]
+ 
+ LMBD = lambda x, y=doesnotexist: x+y  # [undefined-variable]
+ LMBD2 = lambda x, y: x+z  # [undefined-variable]",Isn't this a false positive? Why are we reporting `unused-variable` on a `del` operation with a `undefined-variable`.,Why is this needed?
+5828,"@@ -97,7 +97,7 @@ func (client *ClientFake) FindProposals(providerID string) (proposals []dto_disc
+ 
+ // SendSessionStats heartbeats that session is still active + session upload and download amounts
+ func (client *ClientFake) SendSessionStats(sessionId session.SessionID, sessionStats dto.SessionStats, signer identity.Signer) (err error) {
+-	log.Info(mysteriumAPILogPrefix, ""Session stats sent: "", sessionId)
++	log.Info(mysteriumAPILogPrefix, ""SessionDto stats sent: "", sessionId)
+ 
+ 	return nil
+ }",Is it correct that `SessionDto` should be here?,`sessionId` should be `sessionID`
+5829,"@@ -103,6 +103,11 @@ func (c *ovsCtlClient) DumpGroups() ([]string, error) {
+ 	return groupList, nil
+ }
+ 
++func (c *ovsCtlClient) AddMeterEntry(meterId uint32, rate uint32) error {
++	_, err := c.RunOfctlCmd(""add-meter"", fmt.Sprintf(""meter=%d,pktps,band=type=drop,rate=%d"", meterId, rate))
++	return err
++}
++
+ func (c *ovsCtlClient) DumpPortsDesc() ([][]string, error) {
+ 	portsDescDump, err := c.RunOfctlCmd(""dump-ports-desc"")
+ 	if err != nil {","sorry I missed this earlier. We no longer use ovs-ofctl for flow programming AFAIK, why not add this support to ofnet / libOpenflow?","nit: `fmt.Sprintf(""meter=%d,pktps"
+5830,"@@ -159,7 +159,10 @@ class Form extends WidgetBase
+      */
+     protected function loadAssets()
+     {
+-        $this->addJs('js/october.form.js', 'core');
++        $this->addJs('js/october.form.js', [
++            'build' => 'core',
++            'cache'  => 'false'
++        ]);
+     }
+ 
+     /**",Make this consistent with the other definition please `'false'` vs `false`,Why is this needed?
+5831,"@@ -62,8 +62,13 @@ func CleanupHandler(c <-chan os.Signal) {
+ 	for s := range c {
+ 		debug.Log(""signal %v received, cleaning up"", s)
+ 		fmt.Printf(""%sInterrupt received, cleaning up\n"", ClearLine())
+-		RunCleanupHandlers()
+-		fmt.Println(""exiting"")
+-		os.Exit(0)
++		Exit(0)
+ 	}
+ }
++
++// Exit runs the cleanup handlers and then terminates the process with the
++// given exit code.
++func Exit(code int) {
++	RunCleanupHandlers()
++	os.Exit(code)
++}",I think this is a good way to do it. :+1:,I think this should be `os.Exit(1
+5832,"@@ -21,7 +21,7 @@ import (
+ 	""os""
+ 	""path/filepath""
+ 
+-	""github.com/mitchellh/go-homedir""
++	homedir ""github.com/mitchellh/go-homedir""
+ 	""github.com/mysteriumnetwork/node/core/node""
+ 	""github.com/urfave/cli""
+ )",Why this is needed?,Why this change?
+5833,"@@ -26,11 +26,12 @@ import (
+ )
+ 
+ // InitializeConnTrackDumper initializes the ConnTrackDumper interface for different OS and datapath types.
+-func InitializeConnTrackDumper(nodeConfig *config.NodeConfig, serviceCIDR *net.IPNet, ovsctlClient ovsctl.OVSCtlClient, ovsDatapathType string) ConnTrackDumper {
++func InitializeConnTrackDumper(nodeConfig *config.NodeConfig, serviceCIDR *net.IPNet, ovsDatapathType string) ConnTrackDumper {
+ 	var connTrackDumper ConnTrackDumper
+ 	if ovsDatapathType == ovsconfig.OVSDatapathSystem {
+ 		connTrackDumper = NewConnTrackSystem(nodeConfig, serviceCIDR)
+ 	} else if ovsDatapathType == ovsconfig.OVSDatapathNetdev {
++		ovsctlClient := ovsctl.NewClient(nodeConfig.OVSBridge)
+ 		connTrackDumper = NewConnTrackOvsAppCtl(nodeConfig, serviceCIDR, ovsctlClient)
+ 	}
+ 	return connTrackDumper",Can we define this directly in the function `NewConnTrackOvsAppCtl` instead of passing this as an argument?,Why do we need a
+5834,"@@ -54,6 +54,8 @@ func (s *stream) Write(b []byte) (int, error) {
+ var _ = Describe(""Crypto Setup TLS"", func() {
+ 	var clientConf, serverConf *tls.Config
+ 
++	// unparam incorrectly complains that the first argument is never used.
++	//nolint:unparam
+ 	initStreams := func() (chan chunk, *stream /* initial */, *stream /* handshake */) {
+ 		chunkChan := make(chan chunk, 100)
+ 		initialStream := newStream(chunkChan, protocol.EncryptionInitial)",False positives are annoying...,Why is this need
+5835,"@@ -0,0 +1,15 @@
++<?php
++
++/**
++ * Copyright © Ergonode Sp. z o.o. All rights reserved.
++ * See LICENSE.txt for license details.
++ */
++
++declare(strict_types=1);
++
++namespace Ergonode\Multimedia\Infrastructure\Service;
++
++interface SuffixGeneratingServiceInterface
++{
++    public function generateSuffix(string $name, int $iterationIndex): string;
++}","Is the infrastructure layer an appropriate one? I don't think so tbh, more like an application, or even a domain one.",Why do we need t
+5836,"@@ -4,12 +4,14 @@
+ using System;
+ using System.Diagnostics;
+ using System.Numerics;
++using System.Runtime.CompilerServices;
+ using System.Threading;
+ 
+ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Infrastructure
+ {
+     public struct MemoryPoolIterator
+     {
++        private static readonly ulong _powerOfTwoToHighByte = PowerOfTwoToHighByte();
+         private static readonly int _vectorSpan = Vector<byte>.Count;
+ 
+         private MemoryPoolBlock _block;",Why is this required to turn the static readonlies into jitted const? Is this a bug in the jitter?,Is this used anywhere?
+5837,"@@ -2,11 +2,13 @@ from collections import namedtuple
+ 
+ import traceback
+ 
+-SerializableErrorInfo = namedtuple('SerializableErrorInfo', 'message stack')
++SerializableErrorInfo = namedtuple('SerializableErrorInfo', 'message stack cls_name')
+ 
+ 
+ def serializable_error_info_from_exc_info(exc_info):
+     exc_type, exc_value, exc_tb = exc_info
+     return SerializableErrorInfo(
+-        traceback.format_exception_only(exc_type, exc_value)[0], traceback.format_tb(tb=exc_tb)
++        traceback.format_exception_only(exc_type, exc_value)[0],
++        traceback.format_tb(tb=exc_tb),
++        exc_type.__name__,
+     )","feel free to make this a ""typed"" named tuple (overriding __new__) if you are feeling frisky",I think this should be
+5838,"@@ -1,6 +1,3 @@
+-import { or } from 'ramda';
+-
+-
+-const MAX_SAFE_INTEGER = or(Number.MAX_SAFE_INTEGER, (2 ** 53) - 1);
++const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || (2 ** 53) - 1;
+ 
+ export default MAX_SAFE_INTEGER;",Would use parenthesis to explicitly state the associations of operands ```js const MAX_SAFE_INTEGER = Number.MAX_SAFE_INTEGER || ((2 ** 53) - 1),Why is this change nee
+5839,"@@ -187,7 +187,9 @@ func (d *detector) checkApplication(ctx context.Context, app *model.Application,
+ 	liveManifests = filterIgnoringManifests(liveManifests)
+ 	d.logger.Info(fmt.Sprintf(""application %s has %d live manifests"", app.Id, len(liveManifests)))
+ 
+-	result, err := provider.DiffList(liveManifests, headManifests,
++	result, err := provider.DiffList(
++		headManifests,
++		liveManifests,
+ 		diff.WithEquateEmpty(),
+ 		diff.WithIgnoreAddingMapKeys(),
+ 		diff.WithCompareNumberAndNumericString(),",The bug was caused by this order change in the last refactoring.,Why is this change nee
+5840,"@@ -23,6 +23,7 @@ import io
+ import json
+ 
+ import docker
++from docker.utils import kwargs_from_env
+ 
+ from molecule import util
+ from molecule.driver import basedriver",This is already imported as docker. You're safe to simply use `docker.utils.kwargs_from_env()` below.,Why is this import needed?
+5841,"@@ -50,6 +50,14 @@ func (ra RunnableActions) Actions() []action.SealedEnvelope {
+ 	return ra.actions
+ }
+ 
++// AddAction adds actions for block which is building.
++func (ra *RunnableActions) AddAction(act action.SealedEnvelope) {
++	if ra.actions == nil {
++		ra.actions = make([]action.SealedEnvelope, 0)
++	}
++	ra.actions = append(ra.actions, act)
++}
++
+ // RunnableActionsBuilder is used to construct RunnableActions.
+ type RunnableActionsBuilder struct{ ra RunnableActions }
+ ",No need to add this fun. Using RunnableActionsBuilder#AddActions instead,Why do we need this?
+5842,"@@ -23,6 +23,10 @@ let oldBeforeUnmount = options.unmount;
+ const RAF_TIMEOUT = 100;
+ let prevRaf;
+ 
++// TODO: these options hooks are also still side-effects and we
++// should minimize side-effects wherever we can, currently compat
++// imports this whole file resulting in a lot of side-effects, would
++// it be better for that reason to integrate hooks into core?
+ options._diff = (internal, vnode) => {
+ 	currentInternal = null;
+ 	if (oldBeforeDiff) oldBeforeDiff(internal, vnode);",I don't think it's possible to do this for hooks  ,I don't think this is the 
+5843,"@@ -88,7 +88,7 @@ public class SleepJavaJob {
+     System.out.println(""Sec "" + sec);
+     synchronized (this) {
+       try {
+-        this.wait(sec * 1000);
++        this.wait(sec * 1000 + 1);
+       } catch (final InterruptedException e) {
+         System.out.println(""Interrupted "" + this.fail);
+       }",wait(1ms) when sec=0. wait(0ms) waits forever so that's why this is better.,Why is this needed?
+5844,"@@ -104,8 +104,14 @@ struct listener_ssl_config_t {
+ 
+ struct listener_config_t {
+     int fd;
++#if defined(__linux__) && defined(SO_REUSEPORT)
++    int domain;
++    int so_reuseport;
++    H2O_VECTOR(int) reuseport_fds;
++#endif
+     struct sockaddr_storage addr;
+     socklen_t addrlen;
++
+     h2o_hostconf_t **hosts;
+     H2O_VECTOR(struct listener_ssl_config_t *) ssl;
+     int proxy_protocol;",Do we need `domain` and `so_reuseport` now that we open new sockets immediately after calling `add_listener`?,Why do we need this?
+5845,"@@ -34,10 +34,14 @@ public interface HttpClient {
+    * @throws IOException if an I/O error occurs.
+    */
+   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
+-
++  
+   /**
+-   * Creates HttpClient instances.
+-   */
++	* Closes the connections associated with this client. 
++	*
++	* @throws  IOException  if an I/O error occurs.
++	*/
++  void close() throws IOException;
++
+   interface Factory {
+ 
+     /**",The formatting seems different from the rest of the code,Why is this needed?
+5846,"@@ -0,0 +1,18 @@
++package paramhelper
++
++import (
++	""fmt""
++	""strings""
++)
++
++// GetRegion extracts region from a zones
++func GetRegion(zone string) (string, error) {
++	if zone == """" {
++		return """", fmt.Errorf(""zone is empty. Can't determine region"")
++	}
++	zoneStrs := strings.Split(zone, ""-"")
++	if len(zoneStrs) < 2 {
++		return """", fmt.Errorf(""%v is not a valid zone"", zone)
++	}
++	return strings.Join(zoneStrs[:len(zoneStrs)-1], ""-""), nil
++}","What about calling this package ""parameters""? utils\parameters are utils related to parameters.",`GetRegionFromZone` 
+5847,"@@ -20,7 +20,7 @@ describe Topic do
+     end
+ 
+     it 'generates a stripped, url encoded slug based on name' do
+-      @topic.slug.should == 'test+driven+development'
++      expect(@topic.slug).to eq 'test+driven+development'
+     end
+   end
+ ",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Prefer double-quoted
+5848,"@@ -52,10 +52,10 @@ public class PublicKeySubCommandTest extends CommandTestAbstract {
+           + System.lineSeparator()
+           + ""This command outputs the node public key. Default output is standard output.""
+           + System.lineSeparator()
+-          + ""      --to=<FILE>   File to write public key to instead of standard output""
+-          + System.lineSeparator()
+           + ""  -h, --help        Show this help message and exit.""
+           + System.lineSeparator()
++          + ""      --to=<FILE>   File to write public key to instead of standard output""
++          + System.lineSeparator()
+           + ""  -V, --version     Print version information and exit.""
+           + System.lineSeparator();
+ ",what is the actual difference here?,Why did you change this?
+5849,"@@ -96,6 +96,12 @@ public final class DefaultOAuth2AuthorizationRequestResolver implements OAuth2Au
+ 		if (registrationId == null) {
+ 			return null;
+ 		}
++		String[] params = new String[0];
++		if (registrationId.contains(""?"")) {
++			String[] explodedURI = registrationId.split(""\\?"");
++			registrationId = registrationId.split(""\\?"")[0];
++			params = explodedURI[1].split(""&"");
++		}
+ 
+ 		ClientRegistration clientRegistration = this.clientRegistrationRepository.findByRegistrationId(registrationId);
+ 		if (clientRegistration == null) {",Parsing URLs is hard. Any fixes should avoid manually parsing the URL.,You can use `registratio
+5850,"@@ -22,7 +22,7 @@ module RSpec
+         end
+ 
+         def example_group_finished(_notification)
+-          @group_level -= 1
++          @group_level =  @group_level > 0 ? @group_level - 1 : @group_level
+         end
+ 
+         def example_passed(passed)","This is a private api, it doesn't need to return anything so `@group_level -= 1 if @group_level > 0` is preferred.",Why not just `@group_lev
+5851,"@@ -432,14 +432,14 @@ NativeHashedStorageHandler::NativeHashedStorageHandler(
+   if (!m_process)
+     return;
+ 
+-  auto key_stride = key_type.GetByteStride();
++  auto key_stride = key_type.GetByteStride(m_process);
+   if (key_stride) {
+     m_key_stride = *key_stride;
+     m_key_stride_padded = *key_stride;
+   }
+ 
+   if (value_type) {
+-    auto value_type_stride = value_type.GetByteStride();
++    auto value_type_stride = value_type.GetByteStride(m_process);
+     m_value_stride = value_type_stride ? *value_type_stride : 0;
+     if (SwiftASTContext *swift_ast =
+             llvm::dyn_cast_or_null<SwiftASTContext>(key_type.GetTypeSystem())) {",".GetValueOr(0) ... but really, shouldn't m_value_strife also be optional?",Why do we need to pass t
+5852,"@@ -256,7 +256,7 @@ module.exports = class Tus extends Plugin {
+         }
+       }
+ 
+-      /** @type {{ [name: string]: string }} */
++      /** @type {Record<string, string>} */
+       const meta = {}
+       const metaFields = Array.isArray(opts.metaFields)
+         ? opts.metaFields",Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing,"I think this should be `Record<string, string>`"
+5853,"@@ -17,11 +17,11 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+         private static readonly WaitCallback _completePending = CompletePending;
+         protected readonly FrameContext _context;
+ 
+-        object _sync = new Object();
++        private object _sync = new Object();
+ 
+-        ArraySegment<byte> _buffer;
+-        Queue<ReadOperation> _reads = new Queue<ReadOperation>();
+-        bool _send100Continue = true;
++        private ArraySegment<byte> _buffer;
++        private Queue<ReadOperation> _reads = new Queue<ReadOperation>();
++        private bool _send100Continue = true;
+ 
+         public MessageBodyExchanger(FrameContext context)
+         {",Should be readonly,Why do these need to be private?
+5854,"@@ -14,7 +14,7 @@ import unittest
+ from rdkit import RDConfig
+ from rdkit import Chem
+ from rdkit.Chem import FragmentCatalog, BuildFragmentCatalog
+-from rdkit.six.moves import cPickle
++from rdkit.six.moves import cPickle  # @UnresolvedImport
+ 
+ 
+ def feq(n1, n2, tol=1e-4):","I'm not going to stop accepting the PR, but I really hate these artifacts getting dropped in the Python code just to stop things like coverage checkers and linters from complaining.",Why is this needed?
+5855,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright 2016 The Kythe Authors. All rights reserved.
++ * Copyright 2020 The Kythe Authors. All rights reserved.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.","FYI modifying an existing file generally doesn't invalidate the copyright date. The date here is when the copy right _begins_, so moving it later is arguably misleading-it still applies. Not a big deal, just something I've seen a few times in passing.",Why did you change the year?
+5856,"@@ -106,7 +106,7 @@ public class BaseServer<T extends BaseServer> implements Server<T> {
+       FilterHolder
+           filterHolder = servletContextHandler.addFilter(CrossOriginFilter.class, ""/*"", EnumSet
+           .of(DispatcherType.REQUEST));
+-      filterHolder.setInitParameter(""allowedOrigins"", ""*"");
++      filterHolder.setInitParameter(""allowedMethods"", ""GET,POST,PUT,DELETE,HEAD"");
+ 
+       // Warning user
+       LOG.warning(""You have enabled CORS requests from any host. ""","Because the default value of allowedOrigins is * (all origins), so it isn't necessary to set again at all.",Why do we need to change this?
+5857,"@@ -449,6 +449,10 @@ public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, Supp
+   Database convertToDatabase(Namespace namespace, Map<String, String> meta) {
+     String warehouseLocation = conf.get(""hive.metastore.warehouse.dir"");
+ 
++    Preconditions.checkNotNull(
++            warehouseLocation,
++            ""Warehouse location is not set: hive.metastore.warehouse.dir=null"");
++
+     if (!isValidateNamespace(namespace)) {
+       throw new NoSuchNamespaceException(""Namespace does not exist: %s"", namespace);
+     }",Style: indentation should be 4 spaces (2 indents) from the start of `Preconditions`.,Why do we need this check?
+5858,"@@ -587,8 +587,15 @@ class AdminController extends Controller
+         foreach ($entityProperties as $name => $metadata) {
+             $formFieldOptions = $metadata['type_options'];
+ 
+-            if ('association' === $metadata['fieldType'] && in_array($metadata['associationType'], array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY))) {
+-                continue;
++            if ('association' === $metadata['type']) {
++                // *-to-many associations are not supported yet
++                $toManyAssociations = array(ClassMetadataInfo::ONE_TO_MANY, ClassMetadataInfo::MANY_TO_MANY);
++                if (in_array($metadata['associationType'], $toManyAssociations)) {
++                    continue;
++                }
++
++                // supported associations are displayed using advanced JavaScript widgets
++                $formFieldOptions['attr']['data-use-js-widget'] = 'true';
+             }
+ 
+             if ('collection' === $metadata['fieldType']) {","I don't know why I suggested a html attribute at first (my bad), or maybe you think it makes sense. Otherwise, what about a simple class ?",Shouldn't this be `true` by de
+5859,"@@ -122,6 +122,9 @@ module DMPRoadmap
+       config.branding = config_for(:branding).deep_symbolize_keys
+     end
+ 
++    # org abbreviation for the root google analytics tracker that gets planted on every page
++    config.tracker_root = ""UoE""
++
+     # The default visibility setting for new plans
+     #   organisationally_visible  - Any member of the user's org can view, export and duplicate the plan
+     #   publicly_visibile         - (NOT advisable because plans will show up in Public DMPs page by default)",Probably want something more generic here like 'DMPRoadmap' so that other installations aren't using UoE by default.,This should be `config.tracker
+5860,"@@ -72,12 +72,13 @@ namespace NLog.Config
+                 }
+                 catch (Exception exception)
+                 {
++                    InternalLogger.Error(exception, ""Failed to add type '{0}'."", t.FullName);
++                    
+                     if (exception.MustBeRethrown())
+                     {
+                         throw;
+                     }
+-
+-                    InternalLogger.Error(""Failed to add type '"" + t.FullName + ""': {0}"", exception);
++                    
+                 }
+             }
+         }",Must this not change to `MustBeRethrownImmediately`?,Shouldn't this be `ExceptionDispatchInfo.Capture(exception)`?
+5861,"@@ -30,11 +30,6 @@ import (
+ 
+ var (
+ 	pluginName = ""antrea-octant-plugin""
+-	client     *clientset.Clientset
+-	graph      = """"
+-	lastTf     = opsv1alpha1.Traceflow{
+-		ObjectMeta: v1.ObjectMeta{Name: """"},
+-	}
+ )
+ 
+ const (",Can it be pointer?,Why are we removing this?
+5862,"@@ -303,11 +303,11 @@ export const refreshAuthentication = async () => {
+ 		} );
+ 
+ 		// We should really be using state management. This is terrible.
+-		window.googlesitekit.setup = window.googlesitekit.setup || {};
+-		window.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
+-		window.googlesitekit.setup.requiredScopes = response.requiredScopes;
+-		window.googlesitekit.setup.grantedScopes = response.grantedScopes;
+-		window.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;
++		global.googlesitekit.setup = global.googlesitekit.setup || {};
++		global.googlesitekit.setup.isAuthenticated = response.isAuthenticated;
++		global.googlesitekit.setup.requiredScopes = response.requiredScopes;
++		global.googlesitekit.setup.grantedScopes = response.grantedScopes;
++		global.googlesitekit.setup.needReauthenticate = requiredAndGrantedScopes.length < response.requiredScopes.length;
+ 	} catch ( e ) { // eslint-disable-line no-empty
+ 	}
+ };",Not related to this issue but this condition seems weak.,Why do we need this change?
+5863,"@@ -58,7 +58,12 @@ trait MarcReaderTrait
+     public function getMarcRecord()
+     {
+         if (null === $this->lazyMarcRecord) {
+-            $marc = trim($this->fields['fullrecord']);
++            // Get preferred MARC field from config, if it is set and is existing:
++            $marcField = (isset($this->mainConfig->Record->preferredMarcField)
++                    && array_key_exists($this->mainConfig->Record->preferredMarcField, $this->fields))
++                ? $this->mainConfig->Record->preferredMarcField : 'fullrecord';
++
++            $marc = trim($this->fields[$marcField]);
+ 
+             // check if we are dealing with MARCXML
+             if (substr($marc, 0, 1) == '<') {",I think this might be a little more readable in two lines as: <pre> $preferredMarcField = $this->mainConfig->Record->preferredMarcField ?? 'fullrecord'; $marc = trim($this->fields[$preferredMarcField] ?? $this->fields['fullrecord']); </pre>,`array_key_exists` is deprecated in favor of `array_key_exist
+5864,"@@ -21,8 +21,9 @@ from . import packer
+ from . import compat
+ from .compat import range_func
+ from .compat import memoryview_type
++from .compat import import_numpy, NumpyRequiredForThisFeature
+ 
+-
++np = import_numpy()
+ ## @file
+ ## @addtogroup flatbuffers_python_api
+ ## @{",does this still allow this file to be used with Python installations that don't have numpy?,Why is this needed?
+5865,"@@ -96,7 +96,7 @@ class BazelBuildFileView {
+     String goImport = """";
+     if (isCloud) {
+       goImport = ""cloud.google.com/go/"";
+-      goPkg = goPkg.replaceFirst(""v(.+);"", ""apiv$1;"");
++      goPkg = goPkg.replaceFirst(""\\/v([a-z1-9]+);"", ""\\/apiv$1;"");
+     } else {
+       goImport = ""google.golang.org/"";
+       String pkgName = goPkg.split("";"")[1];","what about 0? Version probably can' start with 0, but v10 is theoretically possible.",Why is this change 
+5866,"@@ -52,5 +52,17 @@ namespace Microsoft.VisualStudio.TestPlatform.Utilities.Helpers
+         {
+             return new FileInfo(path).Attributes;
+         }
++
++        /// <inheritdoc/>
++        public bool IsRootedPath(string path)
++        {
++            return Path.IsPathRooted(path);
++        }
++
++        /// <inheritdoc/>
++        public string CombinePath(string source)
++        {
++            return Path.Combine(Directory.GetCurrentDirectory(), source);
++        }
+     }
+ }","Usually we consider APIs that have filesystem interactions to be part of IFileHelper, this would allow us to inject a testable implementation easily. `Path.IsRootedPath` doesn't access the file system. It is string comparison I believe.",Why do we need this
+5867,"@@ -276,7 +276,7 @@ spec:
+       iqn: iqn.2016-09.com.openebs.cstor:{{ .Volume.owner }}
+       targetPortal: {{ .TaskResult.cvolcreateputsvc.clusterIP }}:3260
+       targetPort: 3260
+-      status: """"
++      status: ""Init""
+       replicationFactor: {{ $replicaCount }}
+       consistencyFactor: {{ div $replicaCount 2 | floor | add1 }}
+ ---",Do we need to use quote? Why not `status: Init`,Why did you change 
+5868,"@@ -20,10 +20,6 @@ from pylint import checkers, interfaces
+ from pylint.checkers import utils
+ 
+ 
+-def _is_constant_empty_str(node):
+-    return isinstance(node, nodes.Const) and node.value == """"
+-
+-
+ class CompareToEmptyStringChecker(checkers.BaseChecker):
+     """"""Checks for comparisons to empty string.
+     Most of the times you should use the fact that empty strings are false.","Nice catch ! I don't think I would have caught that, did you search the whole code base for pre-existing functions ?",Why is this removed?
+5869,"@@ -1052,6 +1052,19 @@ func TestClusterDeploymentReconcile(t *testing.T) {
+ 				}
+ 			},
+ 		},
++		{
++			name: ""Add cluster region label"",
++			existing: []runtime.Object{
++				testClusterDeploymentWithoutRegionLabel(),
++			},
++			validate: func(c client.Client, t *testing.T) {
++				cd := getCD(c)
++				if assert.NotNil(t, cd, ""missing clusterdeployment"") {
++					//					assert.Equal(t, getClusterRegion(cd), cd.Labels[hivev1.HiveClusterRegionLabel], ""incorrect cluster region label"")
++					assert.Equal(t, getClusterRegion(cd), ""us-east-1"", ""incorrect cluster region label"")
++				}
++			},
++		},
+ 		{
+ 			name: ""Ensure cluster metadata set from provision"",
+ 			existing: []runtime.Object{",Remove this line.,Can we remove this?
+5870,"@@ -964,12 +964,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [Fact]
+         public async Task ContentLength_Received_SingleDataFrameUnderSize_Reset()
+         {
+-            // I hate doing this, but it avoids exceptions from MemoryPool.Dipose() in debug mode. The problem is since
+-            // the stream's ProcessRequestsAsync loop is never awaited by the connection, it's not really possible to
+-            // observe when all the blocks are returned. This can be removed after we implement graceful shutdown.
+-            Dispose();
+-            InitializeConnectionFields(new DiagnosticMemoryPool(KestrelMemoryPool.CreateSlabMemoryPool(), allowLateReturn: true));
+-
+             var headers = new[]
+             {
+                 new KeyValuePair<string, string>(HeaderNames.Method, ""POST""),","This is no longer called in any of our unit tests, right?",Why was this test re
+5871,"@@ -67,7 +67,7 @@ type rule struct {
+ 	// Priority of the NetworkPolicy to which this rule belong. nil for K8s NetworkPolicy.
+ 	PolicyPriority *float64
+ 	// Priority of the tier that the NetworkPolicy belongs to. nil for K8s NetworkPolicy.
+-	TierPriority *v1beta1.TierPriority
++	TierPriority *uint32
+ 	// Targets of this rule.
+ 	AppliedToGroups []string
+ 	// The parent Policy ID. Used to identify rules belong to a specified","I think typically K8s APIs will use `int32` and not `uint32`. I think we should keep it consistent with the rule `Priority` above. I believe that the rationale for using `int32` in general is: * some programming languages don't have native support for unsigned integers * it's easier to catch sign errors with signed integers, depending on the programming language (it it's negative, it's clearly an error but if it's a very large number, it could be normal or it could be a negative number overflow)",Why do we need this 
+5872,"@@ -0,0 +1,7 @@
++class AddStartAndEndDatesToPlans < ActiveRecord::Migration
++  def change
++    add_column :plans, :grant_id, :integer, index: true
++    add_column :plans, :start_date, :datetime
++    add_column :plans, :end_date, :datetime
++  end
++end","If you end up changing grant to an association, this may need to change to a reference to enforce the foreign_key `add_reference :plans, :grant`",I don't think we need to index on `grant_id`
+5873,"@@ -74,7 +74,7 @@ class DashboardModulesAlerts extends Component {
+ 						title={ notification.title || '' }
+ 						description={ notification.description || '' }
+ 						blockData={ notification.blockData || [] }
+-						winImage={ notification.winImage ? `${ global._googlesitekitLegacyData.admin.assetsRoot }images/${ notification.winImage }` : '' }
++						WinImageSVG={ notification.WinImageSVG }
+ 						format={ notification.format || 'small' }
+ 						learnMoreURL={ notification.learnMoreURL || '' }
+ 						learnMoreDescription={ notification.learnMoreDescription || '' }",This won't work because `notification` comes from an API response here. I think this would be the same as the change to `Alert` where it would get `SmallSunSVG`.,Why do we need this change?
+5874,"@@ -120,6 +120,10 @@ func TestEnvironmentConfig(t *testing.T) {
+ 	additionalLocalRoutesJSON := `[""1.2.3.4/22"",""5.6.7.8/32""]`
+ 	os.Setenv(""ECS_AWSVPC_ADDITIONAL_LOCAL_ROUTES"", additionalLocalRoutesJSON)
+ 	defer os.Unsetenv(""ECS_AWSVPC_ADDITIONAL_LOCAL_ROUTES"")
++	os.Setenv(""ECS_ENABLE_CONTAINER_METADATA"", ""true"")
++	os.Setenv(""ECS_HOST_DATA_DIR"", ""/etc/ecs/"")
++	defer os.Unsetenv(""ECS_ENABLE_CONTAINER_METADATA"")
++	defer os.Unsetenv(""ECS_HOST_DATA_DIR"")
+ 
+ 	conf, err := environmentConfig()
+ 	assert.NoError(t, err)",This is not checked below?,"I think this should be `defer os.Unsetenv(""E"
+5875,"@@ -218,6 +218,19 @@ func (c *CloudFormation) TemplateBodyFromChangeSet(changeSetID, stackName string
+ 	return aws.StringValue(out.TemplateBody), nil
+ }
+ 
++// Outputs returns the outputs of a stack description.
++func (c *CloudFormation) Outputs(stack *Stack) (map[string]string, error) {
++	stackDescription, err := c.Describe(stack.Name)
++	if err != nil {
++		return nil, fmt.Errorf(""retrieve outputs of stack description: %w"", err)
++	}
++	outputs := make(map[string]string)
++	for _, output := range stackDescription.Outputs {
++		outputs[*output.OutputKey] = *output.OutputValue
++	}
++	return outputs, nil
++}
++
+ // Events returns the list of stack events in **chronological** order.
+ func (c *CloudFormation) Events(stackName string) ([]StackEvent, error) {
+ 	return c.events(stackName, func(in *cloudformation.StackEvent) bool { return true })","Will this ever return a ""Stack does not exist"" error? Should we handle it silently here rather than making higher level packages do error checking?",I think this should be `outputs[*output.Outp
+5876,"@@ -1,11 +1,11 @@
+-from .data_transfer import copy_file, get_bytes, delete_url, list_url
+-from .packages import Package
++from .backends import get_package_registry
++from .data_transfer import copy_file
+ from .search_util import search_api
+ from .util import (QuiltConfig, QuiltException, CONFIG_PATH,
+                    CONFIG_TEMPLATE, configure_from_default, config_exists,
+-                   configure_from_url, fix_url, get_package_registry,
++                   configure_from_url, fix_url,
+                    load_config, PhysicalKey, read_yaml, validate_package_name,
+-                   write_yaml, get_from_config)
++                   write_yaml)
+ from .telemetry import ApiTelemetry
+ 
+ ","minor: at this scale, one import per line reads better",I don't think this is used anymore.
+5877,"@@ -183,7 +183,7 @@ ActiveRecord::Schema.define(version: 20180508151824) do
+     t.string   ""logo_name""
+     t.string   ""contact_email""
+     t.integer  ""org_type"",               default: 0,              null: false
+-    t.text     ""links"",                  default: ""{\""org\"":[]}""
++    t.text     ""links""
+     t.string   ""contact_name""
+     t.boolean  ""feedback_enabled"",       default: false
+     t.string   ""feedback_email_subject""",Should remove the default templates as well.,Why did you remove this?
+5878,"@@ -18,14 +18,14 @@ const stream = require('webpack-stream');
+ const inject = require('gulp-inject');
+ const postcss = require('gulp-postcss');
+ const sass = require('gulp-sass');
+- 
+-sass.compiler = require('node-sass')
+ 
++sass.compiler = require('node-sass');
+ 
++var config;
+ if (mode.production()) {
+-    var config = require('./webpack.prod.js');
++    config = require('./webpack.prod.js');
+ } else {
+-    var config = require('./webpack.dev.js');
++    config = require('./webpack.dev.js');
+ }
+ 
+ function serve() {",Why not `let`?,Why this change?
+5879,"@@ -49,6 +49,8 @@ public class ZipkinServer {
+     new SpringApplicationBuilder(ZipkinServer.class)
+       .banner(new ZipkinBanner())
+       .initializers(new ZipkinModuleImporter(), new ZipkinActuatorImporter())
++      // Avoids potentially expensive ns lookup and inaccurate startup timing
++      .logStartupInfo(false)
+       .properties(
+         EnableAutoConfiguration.ENABLED_OVERRIDE_PROPERTY + ""=false"",
+         ""spring.config.name=zipkin-server"").run(args);",ns -> DNS My first reading was this is referring to System.nanoTime and thought hrm?,Why do we need this?
+5880,"@@ -55,6 +55,7 @@ class ScheduleInstigatorData(
+             # `start_date` on partition-based schedules, which is used to define
+             # the range of partitions)
+             check.opt_float_param(start_timestamp, ""start_timestamp""),
++            # this is a vestigial parameter that is not used and will be removed in the future
+             check.opt_str_param(scheduler, ""scheduler""),
+         )
+ ",is there a reason not to remove the param now? I think the serdes will still work?,I don't think we should remove it.
+5881,"@@ -39,6 +39,8 @@ class TestBasic(unittest.TestCase):
+         self.assertEqual(bst.current_iteration(), 20)
+         self.assertEqual(bst.num_trees(), 20)
+         self.assertEqual(bst.num_model_per_iteration(), 1)
++        self.assertAlmostEqual(bst.upper_bound(), 3.32, places=2)
++        self.assertAlmostEqual(bst.lower_bound(), -3.13, places=2)
+ 
+         bst.save_model(""model.txt"")
+         pred_from_matr = bst.predict(X_test)",`places=2` seems to be very poor comparison. Do you have any thoughts why is it fail with more strict checks?,I think we should use `assertAlmos
+5882,"@@ -213,6 +213,7 @@ public class ProjectManager {
+       fetchedProject = this.projectsByName.get(name);
+     } else {
+       try {
++        logger.info(""Project "" + name + "" doesn't exist in cache, fetching from DB now."");
+         fetchedProject = this.projectLoader.fetchProjectByName(name);
+       } catch (final ProjectManagerException e) {
+         logger.error(""Could not load project from store."", e);","should we make level debug? Also just FYI, with debug level, we can add more detailed logging for better debuggability without concerning overwhelming logging message",I think it would be better to use 
+5883,"@@ -20,14 +20,16 @@
+ # ----------------------------------------------------------------------
+ 
+ """"""
+-## @file
+-stats.py defines functions and data structures related to statistical analysis.
++Module of statistical data structures and functions used in learning algorithms
++and for analysis of HTM network inputs and outputs.
+ """"""
+ 
+ import random
+ 
+ import numpy
+ 
++from nupic.bindings.math import GetNTAReal, SparseMatrix
++
+ 
+ dtype = GetNTAReal()
+ ",I needed to add this import for Sphinx to inspect C++ runtime objects properly. This should be the only code change in this PR.,I don't think we need this line.
+5884,"@@ -1,6 +1,8 @@
+ import colander
+ 
+ from cliquet import resource
++from cliquet.events import ResourceChanged, ACTIONS
++from pyramid.events import subscriber
+ 
+ from kinto.views import NameGenerator
+ ","Changes in this file aren't related to the PR, are they? You took the opportunity to change the group deletion to using the subscriber too?",I don't think we need this import.
+5885,"@@ -150,6 +150,19 @@ public class MetricsModes {
+     }
+   }
+ 
++  /**
++   * Auto promote sorted columns to truncate(16) if default is set at Counts or None.
++   * @param defaultMode default mode
++   * @return mode to use
++   */
++  public static MetricsMode promoteSortedColumnDefault(MetricsMode defaultMode) {
++    if (defaultMode == None.get() || defaultMode == Counts.get()) {
++      return Truncate.withLength(16);
++    } else {
++      return defaultMode;
++    }
++  }
++
+   // we cannot serialize/deserialize MetricsMode directly as it breaks reference equality used in metrics utils
+   private abstract static class ProxySerializableMetricsMode implements MetricsMode {
+     Object writeReplace() throws ObjectStreamException {",I'd probably move this into `MetricsConfig` as a private method. Seems like we only use it there.,Why do we need this method?
+5886,"@@ -93,7 +93,7 @@ class Lint(base.Base):
+     ),
+ )
+ def lint(ctx, scenario_name):  # pragma: no cover
+-    """""" Lint the role. """"""
++    """""" Lint the role (dependency, lint). """"""
+     args = ctx.obj.get('args')
+     subcommand = base._get_subcommand(__name__)
+     command_args = {'subcommand': subcommand}",Not clear here what you mean with this list,Why is this change needed?
+5887,"@@ -190,6 +190,7 @@ public class IcebergDecoder<D> extends MessageDecoder.BaseDecoder<D> {
+    * @return true if the buffer is complete, false otherwise (stream ended)
+    * @throws IOException if there is an error while reading
+    */
++  @SuppressWarnings(""checkstyle:InnerAssignment"")
+   private boolean readFully(InputStream stream, byte[] bytes)
+       throws IOException {
+     int pos = 0;","Curious, is there a way we can get around this without suppressing?",Why is this needed?
+5888,"@@ -131,6 +131,7 @@ func (manager *Manager) Create(consumerID identity.Identity, issuerID identity.I
+ 	sessionInstance.ConsumerID = consumerID
+ 	sessionInstance.done = make(chan struct{})
+ 	sessionInstance.Config = config
++	sessionInstance.ProposalID = proposalID
+ 	sessionInstance.CreatedAt = time.Now().UTC()
+ 
+ 	balanceTracker, err := manager.balanceTrackerFactory(consumerID, identity.FromAddress(manager.currentProposal.ProviderID), issuerID)","I don't think we this field in session, it's a serial number for proposal but not unique index itself",Why do we need this?
+5889,"@@ -42,6 +42,16 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+             }
+         }
+ 
++        [Benchmark(Baseline = true, OperationsPerInvoke = RequestParsingData.InnerLoopCount)]
++        public void PlaintextAbsoluteUri()
++        {
++            for (var i = 0; i < RequestParsingData.InnerLoopCount; i++)
++            {
++                InsertData(RequestParsingData.PlaintextAbsoluteUriRequest);
++                ParseData();
++            }
++        }
++
+         [Benchmark(OperationsPerInvoke = RequestParsingData.InnerLoopCount * RequestParsingData.Pipelining)]
+         public void PipelinedPlaintextTechEmpower()
+         {",Can't have two benchmarks with `Baseline = true`,Why do we need this 
+5890,"@@ -0,0 +1,19 @@
++
++import { wpApiFetch } from './wp-api-fetch';
++
++import { testClientConfig } from './test-client-config';
++
++/**
++ *
++ * @param {*} config
++ */
++export async function setClientConfig( config = testClientConfig ) {
++	return await wpApiFetch( {
++		path: 'google-site-kit/v1/e2e/auth/client-config',
++		method: 'post',
++		data: {
++			clientID: config.web.client_id,
++			clientSecret: config.web.client_secret,
++		},
++	} );
++}",Same here: Empty line before and no `Internal dependencies` docblock (mandatory anyway once #217 lands).,I'm not sure if this
+5891,"@@ -59,7 +59,7 @@ func newAddCommand(root *command) *cobra.Command {
+ 
+ 	cmd.Flags().StringVar(&c.repoID, ""repo-id"", c.repoID, ""The repository ID. One the registered repositories in the piped configuration."")
+ 	cmd.Flags().StringVar(&c.appDir, ""app-dir"", c.appDir, ""The relative path from the root of repository to the application directory."")
+-	cmd.Flags().StringVar(&c.configFileName, ""config-file-name"", c.configFileName, ""The configuration file name. Default is .pipe.yaml"")
++	cmd.Flags().StringVar(&c.configFileName, ""config-file-name"", c.configFileName, ""The configuration file name"")
+ 	cmd.Flags().StringVar(&c.description, ""description"", c.description, ""The description of the application."")
+ 
+ 	cmd.MarkFlagRequired(""app-name"")","sorry, the default value for this field is no longer allowed?",Why remove the defau
+5892,"@@ -308,10 +308,10 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+         [Fact]
+         public void UnauthorizedAccessExceptionCreatingSarifLog()
+         {
+-            string path = Environment.GetFolderPath(Environment.SpecialFolder.Windows);
++            string path = Environment.GetFolderPath(Environment.SpecialFolder.ApplicationData);
+             path = Path.Combine(path, Guid.NewGuid().ToString());
+ 
+-            try
++            using (var stream = File.Create(path, 1, FileOptions.DeleteOnClose))
+             {
+                 // attempt to persist to unauthorized location will raise exception
+                 var options = new TestAnalyzeOptions()",Why does this work? I'd've expected that an admin could create a file anywhere.,Why is this change needed?
+5893,"@@ -53,7 +53,7 @@ module Travis
+ 
+         def script
+           if config[:solution]
+-            sh.cmd ""xbuild #{config[:solution]}"", timing: true if config[:solution]
++            sh.cmd ""xbuild /p:Configuration=#{config[:configuration] || 'Release'} /p:Platform=\""#{config[:platform] || 'x64'}\"" #{config[:solution]}"", timing: true if config[:solution]
+           else
+             sh.echo 'No solution or script defined, exiting', ansi: :red
+             sh.cmd 'false', echo: false, timing: false",falling back to `x64` seems like a really bad idea given that the VS templates default to x86 these days.,`config[:configuration] ||
+5894,"@@ -356,7 +356,7 @@ class TestBokehPlotInstantiation(ComparisonTestCase):
+     def tearDown(self):
+         Store.current_backend = self.previous_backend
+         Callback._comm_type = comms.JupyterCommJS
+-        mpl_renderer.comms['default'] = self.default_comm
++        bokeh_renderer.comms['default'] = self.default_comm
+         Callback._callbacks = {}
+ 
+     def test_overlay_legend(self):",Bit surprised by this. I would have thought either you want to set it for both mpl and bokeh...or alternatively it was only ever meant for bokeh and was always wrong?,Why did you change this?
+5895,"@@ -490,6 +490,8 @@ given file (report RP0402 must not be disabled)'}
+                 importedname = node.modname
+             else:
+                 importedname = node.names[0][0].split('.')[0]
++        if node.as_string().startswith('from .'):
++            importedname = '.' + importedname
+         self._imports_stack.append((node, importedname))
+ 
+     @staticmethod","Check modname instead, but only if it's a ImportFrom.",Why is this needed?
+5896,"@@ -92,6 +92,13 @@ public class TableProperties {
+   public static final String METADATA_COMPRESSION = ""write.metadata.compression-codec"";
+   public static final String METADATA_COMPRESSION_DEFAULT = ""none"";
+ 
++  public static final String PREVIOUS_METADATA_LOG_MAX_COUNT = ""write.metadata.previous-log-max-count"";
++  public static final int PREVIOUS_METADATA_LOG_MAX_COUNT_DEFAULT = 100;
++
++  // This enables to delete the oldest metadata file after commit.
++  public static final String METADATA_DELETE_AFTER_COMMIT_ENABLED = ""write.metadata.delete-after-commit.enabled"";
++  public static final boolean METADATA_DELETE_AFTER_COMMIT_ENABLED_DEFAULT = false;
++
+   public static final String METRICS_MODE_COLUMN_CONF_PREFIX = ""write.metadata.metrics.column."";
+   public static final String DEFAULT_WRITE_METRICS_MODE = ""write.metadata.metrics.default"";
+   public static final String DEFAULT_WRITE_METRICS_MODE_DEFAULT = ""truncate(16)"";",How about `write.metadata.previous-versions-max`? No need to refer to these as a log.,I think this should be `write.metadata.delete-after-commit.max-count`
+5897,"@@ -36,6 +36,7 @@ RSpec.configure do |config|
+   end
+ 
+   config.filter_run_excluding appveyor_agents: true unless ENV['APPVEYOR_AGENTS']
++  config.filter_run_excluding windows: true unless ENV['BOLT_WINDOWS']
+ 
+   # rspec-mocks config
+   config.mock_with :rspec do |mocks|","We generally do this via tags in the Rakefile, not separate environment variables.",I don't think this is needed.
+5898,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,I think this should be `POST` instead of `POST`
+5899,"@@ -369,7 +369,13 @@ class CLAModel(Model):
+     results.inferences = {}
+     self._input = inputRecord
+ 
+-    # -------------------------------------------------------------------------
++    # Check if the input includes the predicted field.
++    if not self._predictedFieldName in self._input:
++      raise ValueError(""Expected predicted field '%s' in input row, ""
++                       ""but was not found! Raw input is: %s""
++                       % (self._predictedFieldName, self._input))
++
++
+     # Turn learning on or off?
+     if '_learning' in inputRecord:
+       if inputRecord['_learning']:",`if X not in Y:`,I don't think this is the right error message. It should be something
+5900,"@@ -79,7 +79,7 @@ public class TestHiveShell {
+ 
+   public void start() {
+     // Create a copy of the HiveConf for the metastore
+-    metastore.start(new HiveConf(hs2Conf));
++    metastore.start(new HiveConf(hs2Conf), 10);
+     hs2Conf.setVar(HiveConf.ConfVars.METASTOREURIS, metastore.hiveConf().getVar(HiveConf.ConfVars.METASTOREURIS));
+     hs2Conf.setVar(HiveConf.ConfVars.METASTOREWAREHOUSE,
+         metastore.hiveConf().getVar(HiveConf.ConfVars.METASTOREWAREHOUSE));","Do we know why the pool is exhausted? In the past, we had a few leaks in the Spark catalog code which led to this. It can be also a valid use case too if we simply need a larger pool.",Why do we need this change?
+5901,"@@ -228,6 +228,11 @@ module Bolt
+       # Set console log to debug if in debug mode
+       if options[:debug]
+         overrides['log'] = { 'console' => { 'level' => :debug } }
++      elsif options[:verbose]
++        configured_level = overrides.dig('log', 'console', 'level')
++        if configured_level.nil? || Bolt::Logger.lower_level?(:notice, configured_level)
++          overrides['log'] = { 'console' => { 'level' => :notice } }
++        end
+       end
+ 
+       if options[:puppetfile_path]","Logging in Bolt still seems to be a little messy. I think this is more correct than what I had before, but made sure I wouldn't overwrite an existing level. And if console logging gets more options, both debug and verbose need to be fixed here.",I'm not sure if this is the
+5902,"@@ -7,6 +7,13 @@ std::shared_ptr<request_type> nano::work_peer_request::get_prepared_json_request
+ 	auto request (std::make_shared<boost::beast::http::request<boost::beast::http::string_body>> ());
+ 	request->method (boost::beast::http::verb::post);
+ 	request->set (boost::beast::http::field::content_type, ""application/json"");
++	auto address_string (address.to_string ());
++	auto pos (address_string.find (""::ffff:""));
++	if (pos != std::string::npos)
++	{
++		address_string.replace (pos, 7, """");
++	}
++	request->set (boost::beast::http::field::host, address_string);
+ 	request->target (""/"");
+ 	request->version (11);
+ 	request->body () = request_string_a;","This could be simplified (if including <boost/algorithm/string/erase.hpp> is fine): `auto address_string = boost::algorithm::erase_first_copy (address.to_string (), ""::ffff:"");`",Please use `boost::regex` i
+5903,"@@ -304,7 +304,7 @@ public class DefaultGridRegistry extends BaseGridRegistry implements GridRegistr
+     if (proxy == null) {
+       return;
+     }
+-    LOG.info(""Registered a node "" + proxy);
++    LOG.finest(""Registered a node "" + proxy);
+     try {
+       lock.lock();
+ ",This is wildly unhelpful to users --- they need to know when a proxy has been registered.,Why is this change needed?
+5904,"@@ -16,8 +16,13 @@ class Topic < ActiveRecord::Base
+   has_one :legacy_trail
+   has_many :trails
+ 
++  has_attached_file :image, {
++    path: ""topics/:attachment/:id_partition/:style/:filename""
++  }.merge(PAPERCLIP_STORAGE_OPTIONS)
++
+   validates :name, presence: true
+   validates :slug, presence: true, uniqueness: true
++  validates_attachment_content_type :image, content_type: /\Aimage\/.*\Z/
+ 
+   friendly_id :name, use: [:slugged, :finders]
+ ",Why do we need `do_not_validate_attachment_file_type` is we're doing it in the previous line?,I don't think we need the `\Z` here.
+5905,"@@ -107,10 +107,9 @@ public class LoginActivity extends AccountAuthenticatorActivity
+ 		if (shouldUseCertBasedAuth()) {
+ 			final String alias = RuntimeConfig.getRuntimeConfig(this).getString(ConfigKey.ManagedAppCertAlias);
+ 			KeyChain.choosePrivateKeyAlias(this, webviewHelper, null, null, null, 0, alias);
++		} else {
++			webviewHelper.loadLoginPage();
+ 		}
+-
+-		// Load login page
+-		webviewHelper.loadLoginPage();
+ 	}
+ 
+     /**",Loading login page right away only for the regular use case.,Why did you remove this?
+5906,"@@ -1,13 +1,17 @@
+ // render modes
+ 
++/** Do not recursively re-render a component */
+ export const NO_RENDER = 0;
++/** Recursively re-render a component and it's children */
+ export const SYNC_RENDER = 1;
++/** Force a re-render of a component */
+ export const FORCE_RENDER = 2;
++/** Queue asynchronous re-render of a component and it's children */
+ export const ASYNC_RENDER = 3;
+ 
+ 
+ export const ATTR_KEY = '__preactattr_';
+ 
+-// DOM properties that should NOT have ""px"" added when numeric
++/** DOM properties that should NOT have ""px"" added when numeric */
+ export const IS_NON_DIMENSIONAL = /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i;
+ ",IIRC this flag disables re-rendering entirely (`s/recursively //`),I don't think we need to export thes
+5907,"@@ -6,17 +6,11 @@ define([""loading""], function(loading) {
+             url: ApiClient.getUrl(""Startup/Complete""),
+             type: ""POST""
+         }).then(function() {
+-            Dashboard.navigate(""dashboard.html"");
+             loading.hide();
++            window.location.href = ""index.html"";
+         });
+     }
+     return function(view, params) {
+         view.querySelector("".btnWizardNext"").addEventListener(""click"", onFinish);
+-        view.addEventListener(""viewshow"", function() {
+-            document.querySelector("".skinHeader"").classList.add(""noHomeButtonHeader"")
+-        });
+-        view.addEventListener(""viewhide"", function() {
+-            document.querySelector("".skinHeader"").classList.remove(""noHomeButtonHeader"")
+-        });
+     };
+ });","Did you test this redirect? @thornbill mentioned it might need `web` at the front, but if this works fine I'd rather leave it this way.",Why was this removed?
+5908,"@@ -30,7 +30,6 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+ 
+             headers[""custom""] = new[] { ""value"" };
+ 
+-            Assert.NotNull(headers[""custom""]);
+             Assert.Equal(1, headers[""custom""].Count);
+             Assert.Equal(""value"", headers[""custom""][0]);
+         }","FYI, this returned `StringValues` which is a value type (aka can never be null).",Why was this removed?
+5909,"@@ -1425,7 +1425,16 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
+ 		valueSize := c.targetData.TypeAllocSize(llvmValueType)
+ 		llvmKeySize := llvm.ConstInt(c.ctx.Int8Type(), keySize, false)
+ 		llvmValueSize := llvm.ConstInt(c.ctx.Int8Type(), valueSize, false)
+-		hashmap := c.createRuntimeCall(""hashmapMake"", []llvm.Value{llvmKeySize, llvmValueSize}, """")
++		sizeHint := llvm.ConstInt(c.uintptrType, 8, false)
++		if expr.Reserve != nil {
++			sizeHint = c.getValue(frame, expr.Reserve)
++			var err error
++			sizeHint, err = c.parseConvert(expr.Reserve.Type(), types.Typ[types.Uintptr], sizeHint, expr.Pos())
++			if err != nil {
++				return llvm.Value{}, err
++			}
++		}
++		hashmap := c.createRuntimeCall(""hashmapMake"", []llvm.Value{llvmKeySize, llvmValueSize, sizeHint}, """")
+ 		return hashmap, nil
+ 	case *ssa.MakeSlice:
+ 		sliceLen := c.getValue(frame, expr.Len)","Oh no, that's a bug.",Why do we need to par
+5910,"@@ -23,5 +23,5 @@ package yarpc
+ // Response is the low level response representation.
+ type Response struct {
+ 	Headers          Headers
+-	ApplicationError bool
++	ApplicationError error
+ }","Let's leave a note in CHANGES to replace this with an error metadata struct or interface, unless it would be less effort overall to take a run at it in this change.",Why do we need this?
+5911,"@@ -455,6 +455,10 @@ class Realm {
+  *   This is not supported for `""list""` properties of object types and `""linkingObjects""` properties.
+  * @property {boolean} [indexed] - Signals if this property should be indexed. Only supported for
+  *   `""string""`, `""int""`, and `""bool""` properties.
++ * @property {string} [mapTo] - Set this if the Javascript property name schema differs from the underlying name in the Realm
++ *   file. This can be used to have different naming convention in Javascript than what is being used in the file
++ *   itself. Reading and writing properties must be done using the public key for the property. Queries can be
++ *   done using both the public and the mapped property name.
+  */
+ 
+ /**","The changelog entry does a better job of explaining how this is used than this description. In particular, this says that you need to set `mapTo` if the underlying name is different, but not that `mapTo` *is* the underlying name.",`[mapTo]` -> `[mapped
+5912,"@@ -13,6 +13,7 @@ import (
+ 	""github.com/influxdata/flux/plan""
+ 	""github.com/influxdata/flux/semantic""
+ 	_ ""github.com/lib/pq""
++	_ ""github.com/mattn/go-sqlite3""
+ )
+ 
+ const FromSQLKind = ""fromSQL""","These imports will probably need to be refactored so they aren't here. That applies for all of the database drivers. The reason for this is because we sometimes want a driver to be available and sometimes we don't. When we include this library in our cloud offering, the sqlite3 connector needs to be gone because it's a security vulnerability and there's no use case for it in a cloud environment. But for flux itself, I can see how sqlite3 would be really useful and so I like this change. But this import needs to only exist within the tests and within the `cmd/flux` package. It cannot be here.",Why is this needed?
+5913,"@@ -414,7 +414,7 @@ class RelationController extends ControllerBehavior
+      */
+     protected function findExistingRelationIds($checkIds = null)
+     {
+-        $foreignKeyName = $this->relationModel->getKeyName();
++        $foreignKeyName = $this->relationModel->table . '.' . $this->relationModel->getKeyName();
+ 
+         $results = $this->relationObject
+             ->getBaseQuery()",We can use `getQualifiedKeyName` here instead. I will update.,Why do we need this
+5914,"@@ -115,7 +115,7 @@ module.exports = function getIconByMime (fileType) {
+   }
+ 
+   // Archive
+-  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-gtar', 'x-apple-diskimage', 'x-diskcopy']
++  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-tar', 'x-gzip', 'x-apple-diskimage']
+   if (fileTypeGeneral === 'application' && archiveTypes.indexOf(fileTypeSpecific) !== -1) {
+     return {
+       color: '#00C469',",Could you clarifty why some of those are removed?,Shouldn't this be `
+5915,"@@ -774,3 +774,7 @@ func (a *FakeWebAPI) GetCommand(ctx context.Context, req *webservice.GetCommandR
+ 		Command: &cmd,
+ 	}, nil
+ }
++
++func (a *FakeWebAPI) ListDeploymentConfigTemplates(ctx context.Context, req *webservice.ListDeploymentConfigTemplatesRequest) (*webservice.ListDeploymentConfigTemplatesResponse, error) {
++	return nil, status.Error(codes.Unimplemented, """")
++}",`ctx` is unused in ListDeploymentConfigTemplates,Why is this not imp
+5916,"@@ -1,10 +1,13 @@
+ <% if id.nil? || id.identifier == '' %>
+     <% if scheme.name.downcase == 'orcid' %>
+-        <%= link_to _(""Create or connect your ORCID iD""),
+-                     Rails.application.routes.url_helpers.send(""user_orcid_omniauth_authorize_path""),
++        <%= link_to  Rails.application.routes.url_helpers.send(""user_orcid_omniauth_authorize_path""),
+                      id: ""connect-orcid-button"", target: '_blank',
+                      title: _(""ORCID provides a persistent digital identifier that distinguishes you from other researchers. Learn more at orcid.org""),
+-                     'data-toggle': ""tooltip"" %>
++                     'data-toggle': ""tooltip"" do %>
++          <%= image_tag 'https://orcid.org/sites/default/files/images/orcid_16x16.png', alt: _('ORCID logo') %>
++          &nbsp;
++          <%= _(""Create or connect your ORCID iD"") %>
++        <% end %>
+     <% elsif scheme.name.downcase == 'shibboleth' %>
+         <i class=""fa fa-user"" title=""<%= _('Institutional credentials') %>"" aria-hidden=""true""></i>
+         &nbsp;",nice to see the usage of block for a more readable link name,I think this should be `orcid_16x16.png`
+5917,"@@ -329,9 +329,10 @@ int MPI_File_read(MPI_File fh, void *buf, int count, MPI_Datatype datatype,
+     if (bytes_read != bytes_to_read)
+     {
+         std::snprintf(mpierrmsg, MPI_MAX_ERROR_STRING,
+-                      ""could not read %"" PRId64 "" bytes. read only: %"" PRId64
++                      ""could not read %llu bytes. read only: %llu""
+                       ""\n"",
+-                      bytes_to_read, bytes_read);
++                      (unsigned long long)bytes_to_read,
++                      (unsigned long long)bytes_read);
+         return -2;
+     }
+     *status = bytes_read;","Can these use `static_cast<unsigned long long>` instead? Other than that, it's fine.",Shouldn't this be `%zu`?
+5918,"@@ -258,7 +258,6 @@ def create_app(instance_path=None, static_folder=None, **kwargs_config):
+             except (SyntaxError, ValueError):
+                 pass
+             app.config[cfg_name] = cfg_value
+-            app.logger.debug(""{0} = {1}"".format(cfg_name, cfg_value))
+ 
+     # ====================
+     # Application assembly",This output is only present when `DEBUG=True`. Does it really bother so much?,app.config[cfg_name] = cfg_value
+5919,"@@ -1194,11 +1194,7 @@ bool nano::wallet::search_pending ()
+ 						if (wallets.node.ledger.block_confirmed (block_transaction, hash))
+ 						{
+ 							// Receive confirmed block
+-							auto node_l (wallets.node.shared ());
+-							wallets.node.background ([node_l, block, hash]() {
+-								auto transaction (node_l->store.tx_begin_read ());
+-								node_l->receive_confirmed (transaction, block, hash);
+-							});
++							wallets.node.receive_confirmed (block_transaction, block, hash);
+ 						}
+ 						else
+ 						{","I think it should pass wallet transaction as well, otherwise there will be 2 wallet read transactions in 1 threads (next in scan_receivable)",Why was this removed?
+5920,"@@ -3651,14 +3651,14 @@ bool MMFFMolProperties::getMMFFVdWParams(const unsigned int idx1,
+     const MMFFVdW *mmffVdWParamsIAtom = (*mmffVdW)(iAtomType);
+     const MMFFVdW *mmffVdWParamsJAtom = (*mmffVdW)(jAtomType);
+     if (mmffVdWParamsIAtom && mmffVdWParamsJAtom) {
+-      mmffVdWParams.R_ij_starUnscaled = Utils::calcUnscaledVdWMinimum(
++      mmffVdWParams.R_ij_starUnscaled = MMFF::Utils::calcUnscaledVdWMinimum(
+           mmffVdW, mmffVdWParamsIAtom, mmffVdWParamsJAtom);
+-      mmffVdWParams.epsilonUnscaled = Utils::calcUnscaledVdWWellDepth(
++      mmffVdWParams.epsilonUnscaled = MMFF::Utils::calcUnscaledVdWWellDepth(
+           mmffVdWParams.R_ij_starUnscaled, mmffVdWParamsIAtom,
+           mmffVdWParamsJAtom);
+       mmffVdWParams.R_ij_star = mmffVdWParams.R_ij_starUnscaled;
+       mmffVdWParams.epsilon = mmffVdWParams.epsilonUnscaled;
+-      Utils::scaleVdWParams(mmffVdWParams.R_ij_star, mmffVdWParams.epsilon,
++      MMFF::Utils::scaleVdWParams(mmffVdWParams.R_ij_star, mmffVdWParams.epsilon,
+                             mmffVdW, mmffVdWParamsIAtom, mmffVdWParamsJAtom);
+       res = true;
+     }",RDKit::Utils is now in the namespace for localeswitcer... We could change it to something else.,Why is this change needed?
+5921,"@@ -211,6 +211,10 @@ class GroupBy(object):
+             kdf = kdf.reset_index(drop=self._should_drop_index)
+ 
+         if relabeling:
++
++            # For MultiIndex, we need to flatten the tuple, e.g. (('y', 'A'), 'max') needs to be
++            # flattened to ('y', 'A', 'max'), it won't do anything on normal Index.
++            order = [(*levs, method) for levs, method in order]
+             kdf = kdf[order]
+             kdf.columns = columns
+         return kdf","@itholic, can we fix it in `_normalize_keyword_aggregation`?",I don't think this is the 
+5922,"@@ -1,6 +1,7 @@
+ # This class represents a user's subscription to Learn content
+ class Subscription < ActiveRecord::Base
+   MAILING_LIST = 'Active Subscribers'
++  DOWNGRADED_PLAN = 'prime-maintain'
+ 
+   belongs_to :user
+   belongs_to :mentor, class_name: User","It seems like we have the main plan in the database but the downgrade plan in the code. Probably okay for now, but as our thinking of how downgrades/plans develops we may want to consolidate.",I don't think this is used
+5923,"@@ -44,6 +44,10 @@ import java.util.List;
+  * </code>
+  */
+ public abstract class By {
++  static {
++    WebDriverException.scheduleIpHostResolving();
++  }
++
+   /**
+    * @param id The value of the ""id"" attribute to search for
+    * @return a By which locates elements by the value of the ""id"" attribute.","we shouldn't add a bunch of static initializers 'everywhere' in the code. Probably just one would be good, during the construction of the 'RemoteWebDriver' class.",Why is this static?
+5924,"@@ -42,6 +42,8 @@ const (
+ 	optionNamePaymentTolerance     = ""payment-tolerance""
+ 	optionNameResolverEndpoints    = ""resolver-options""
+ 	optionNameGatewayMode          = ""gateway-mode""
++	optionNameClefSignerEnable     = ""clef-signer-enable""
++	optionNameClefSignerEndpoint   = ""clef-signer-endpoint""
+ )
+ 
+ func init() {",do we need both flags? maybe infer that `clef-signer-enabled` whenever `clef-signer-endpoint` is defined?,I don't think we need this anymore.
+5925,"@@ -40,7 +40,7 @@ module.exports = {
+     '<rootDir>/test',
+   ],
+   moduleNameMapper: {
+-    '\\.(scss)$': '<rootDir>/node_modules/identity-obj-proxy',
++    '\\.(scss|css)$': '<rootDir>/node_modules/identity-obj-proxy',
+     'github-markdown-css': '<rootDir>/node_modules/identity-obj-proxy',
+     '\\.(png)$': '<rootDir>/node_modules/identity-obj-proxy',
+     '\\.(svg)$': '<rootDir>/test/unit/empty.js'",Do we need this? I didn't see css files (only scss).,Why is this change needed?
+5926,"@@ -29,7 +29,7 @@ class Store:
+ 
+     if hosts is None:
+       hosts = settings.CLUSTER_SERVERS
+-    remote_hosts = [host for host in hosts if not is_local_interface(host)]
++    remote_hosts = [host for host in hosts if not settings.REMOTE_EXCLUDE_LOCAL or not is_local_interface(host)]
+     self.remote_stores = [ RemoteStore(host) for host in remote_hosts ]
+ 
+ ",This feels like a weird `if not ... or not` to me. Can you talk out the intent here?,I think this should be `settings.RE
+5927,"@@ -0,0 +1,17 @@
++class AnnualBillingsController < ApplicationController
++  before_filter :authorize
++
++  def new
++    @annualized_payment = current_user.annualized_payment
++    @discounted_annual_payment = current_user.discounted_annual_payment
++  end
++
++  def create
++    AnnualBillingMailer.notification(current_user).deliver
++
++    redirect_to(
++      dashboard_path,
++      notice: ""Thanks! We'll upgrade your account to annual billing.""
++    )
++  end
++end",Align the parameters of a method call if they span more than one line.,I don't think we need this controll
+5928,"@@ -17,7 +17,7 @@ namespace ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Opt
+ use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\AbstractFacetPackage;
+ 
+ /**
+- * Class HierarchyPackage
++ * Class OptionsPackage
+  * @package ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Facets\OptionBased\Options
+  */
+ class OptionsPackage extends AbstractFacetPackage {",`@package *` can be removed as well.,Why did you change this?
+5929,"@@ -3,7 +3,7 @@ module Beaker
+   # all String methods while adding several platform-specific use cases.
+   class Platform < String
+     # Supported platforms
+-    PLATFORMS = /^(huaweios|cisco_nexus|cisco_ios_xr|(free|open)bsd|osx|centos|fedora|debian|oracle|redhat|scientific|sles|ubuntu|windows|solaris|aix|archlinux|el|eos|cumulus|f5|netscaler)\-.+\-.+$/
++    PLATFORMS = /^(huaweios|cisco_nexus|cisco_ios_xr|(free|open)bsd|osx|centos|fedora|debian|oracle|redhat_fips|redhat|scientific|sles|ubuntu|windows|solaris|aix|archlinux|el|eos|cumulus|f5|netscaler)\-.+\-.+$/
+     # Platform version numbers vs. codenames conversion hash
+     PLATFORM_VERSION_CODES =
+       { :debian => { ""stretch"" => ""9"",",@ScottGarman is there a reason that `redhat_fips` needs to be a beaker platform? Why can't it be another platform that beaker just understands as `redhat`?,Style/RegexpLiteral: Use
+5930,"@@ -274,8 +274,6 @@ void NebulaStore::removePart(GraphSpaceID spaceId, PartitionID partId) {
+         if (partIt != spaceIt->second->parts_.end()) {
+             auto* e = partIt->second->engine();
+             CHECK_NOTNULL(e);
+-            // Stop the raft
+-            partIt->second->stop();
+             raftService_->removePartition(partIt->second);
+             spaceIt->second->parts_.erase(partId);
+             e->removePart(partId);",Where is the other place?,Why is this removed?
+5931,"@@ -19,10 +19,13 @@
+ # OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ # IN THE SOFTWARE.
+ 
++from collections import Sequence
++from boto.vendored.six.moves import UserList
++
+ from boto.s3.user import User
+ 
+ 
+-class ResultSet(list):
++class ResultSet(UserList):
+     """"""
+     The ResultSet is used to pass results back from the Amazon services
+     to the client. It is light wrapper around Python's :py:class:`list` class,",Are you subclassing from `UserList` instead of `list` to satisfy some constraint of Jython? My main concern here is that this is a subtle breaking change to the API because `UserList` is not a subclass of `list`. This has the unfortunate side effect of breaking any user that is using `isinstance` checks to see if a `ResultSet` is a `list`.,Why is this necessary?
+5932,"@@ -32,6 +32,14 @@ module AvatarHelper
+     ""<img src='/assets/icons/sm_laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
+   end
+ 
++  def avatar_laurels(rank)
++    ""<img src='/assets/icons/laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
++  end
++
++  def avatar_tiny_laurels(rank)
++    ""<img src='/assets/icons/tn_laurel_#{rank || 1}.png' alt='KudoRank #{rank || 1}'/>"".html_safe
++  end
++
+   private
+ 
+   def avatar_default_size(size)",We can DRY the above three functions,I think this should be `tiny_laurels`
+5933,"@@ -55,14 +55,7 @@ public final class HashMap<K, V> implements Map<K, V>, Serializable {
+      * @return A {@link HashMap} Collector.
+      */
+     public static <K, V> Collector<Tuple2<K, V>, ArrayList<Tuple2<K, V>>, HashMap<K, V>> collector() {
+-        final Supplier<ArrayList<Tuple2<K, V>>> supplier = ArrayList::new;
+-        final BiConsumer<ArrayList<Tuple2<K, V>>, Tuple2<K, V>> accumulator = ArrayList::add;
+-        final BinaryOperator<ArrayList<Tuple2<K, V>>> combiner = (left, right) -> {
+-            left.addAll(right);
+-            return left;
+-        };
+-        final Function<ArrayList<Tuple2<K, V>>, HashMap<K, V>> finisher = HashMap::ofEntries;
+-        return Collector.of(supplier, accumulator, combiner, finisher);
++        return Collections.toListAndThen(HashMap::ofEntries);
+     }
+ 
+     /**",Only no good is good code. Nice that you were able to remove all this duplicate stuff!,Why do we need this change?
+5934,"@@ -121,7 +121,7 @@ public class PhpSurfaceNamer extends SurfaceNamer {
+ 
+   @Override
+   public String getRetrySettingsTypeName() {
+-    return ""\\Google\\ApiCore\\RetrySettings"";
++    return ""RetrySettings"";
+   }
+ 
+   @Override","Looking at the code, it seems very odd that this method even exists in the SurfaceNamer, since it is only implemented and used in the PhpSurfaceNamer, and in fact the RetrySettings class name is hardcoded elsewhere. WDYT of just removing this method from SurfaceNamer and PhpSurfaceNamer?",Why did you change this?
+5935,"@@ -107,3 +107,18 @@ func SplitWriteAll(ctx context.Context, s Splitter, r io.Reader, l int64, toEncr
+ 	}
+ 	return addr, nil
+ }
++
++type Loader interface {
++	// Load a reference in byte slice representation and return all content associated with the reference.
++	Load(context.Context, []byte) ([]byte, error)
++}
++
++type Saver interface {
++	// Save an arbitrary byte slice and return the reference byte slice representation.
++	Save(context.Context, []byte) ([]byte, error)
++}
++
++type LoadSaver interface {
++	Loader
++	Saver
++}",these interfaces are defined twice. we should use only one and have it in `storage` package maybe,Why do we need this interface?
+5936,"@@ -24,12 +24,16 @@
+ import cPickle as pickle
+ import os
+ import shutil
++import logging
+ from abc import ABCMeta, abstractmethod
+ 
+ import nupic.frameworks.opf.opfutils as opfutils
+ 
+-
+ ###############################################################
++# global variable
++global globalModelsStorage
++globalModelsStorage={}
++
+ 
+ class Model(object):
+   """""" This is the base class that all OPF Model implementations should",This is the wrong context for usage of `global` keyword. It need only be used inside functions.,Why is this global variable needed?
+5937,"@@ -278,7 +278,7 @@ public abstract class AbstractNode implements Node {
+ 
+         for (int i = 0; i < node.jjtGetNumChildren(); i++) {
+             Node child = node.jjtGetChild(i);
+-            if (child.getClass() == targetType) {
++            if (targetType.isAssignableFrom(child.getClass())) {
+                 results.add(targetType.cast(child));
+             }
+ ",this change should be described in the changelog. I'll update it when merging if nothing else arises.,Why is this change needed?
+5938,"@@ -52,9 +52,11 @@ const (
+ type (
+ 	// RPCFactory Creates a dispatcher that knows how to transport requests.
+ 	RPCFactory interface {
+-		CreateDispatcher() *yarpc.Dispatcher
++		CreateTChannelDispatcher() *yarpc.Dispatcher
++		CreateGRPCDispatcher() *yarpc.Dispatcher
+ 		CreateRingpopDispatcher() *yarpc.Dispatcher
+ 		CreateDispatcherForOutbound(callerName, serviceName, hostName string) *yarpc.Dispatcher
++		CreateDispatcherForGRPCOutbound(callerName, serviceName, hostName string) *yarpc.Dispatcher
+ 	}
+ )
+ ",Just to stay consistent with naming let's call it CreateGRPCDispatcherForOutbound. Also rename 'CreateDispatcherForOutbound' to 'CreateTChannelDispatcherForOutbound',Why do we need this interface?
+5939,"@@ -88,7 +88,7 @@ public class Docker {
+ 
+     findImage(new ImageNamePredicate(name, tag));
+ 
+-    LOG.info(String.format(""Pulling %s:%s"", name, tag));
++    LOG.finest(String.format(""Pulling %s:%s"", name, tag));
+ 
+     HttpRequest request = new HttpRequest(POST, ""/images/create"");
+     request.addQueryParameter(""fromImage"", name);",This will always need to be displayed to users.,Why did you change this?
+5940,"@@ -431,3 +431,6 @@ def safe_subn(pattern, repl, target, *args, **kwargs):
+         need a better solution that is aware of the actual content ecoding.
+     """"""
+     return re.subn(str(pattern), str(repl), target, *args, **kwargs)
++
++def bin_safe(s):
++    return ''.join([""\\x{:02x}"".format(ord(i)) if ord(i) < 32 else i for i in s])",This looks very much like `repr` now (we miss 127 though) - maybe just do `repr(x)` + strip outer parantheses?,I don't think you need the `\x{:02x}` here.
+5941,"@@ -386,6 +386,7 @@ func (p *replicatorQueueProcessorImpl) generateSyncActivityTask(
+ 						VersionHistory:     versionHistory,
+ 					},
+ 				},
++				VisibilityTime: &taskInfo.VisibilityTimestamp,
+ 			}, nil
+ 		},
+ 	)",I don't see this field is set in task_generator.go. worth to double check if we put the timestamp when creating replication tasks.,"VisibilityTimestamp: &taskInfo.Timestamp,"
+5942,"@@ -236,7 +236,9 @@ const hasNext = (self, callback) => {
+   if (self.s.currentDoc) {
+     return callback(null, true);
+   }
+-
++  if (self.isNotified()) {
++    return callback(null, false);
++  }
+   nextObject(self, function(err, doc) {
+     if (err) return callback(err, null);
+     if (self.s.state === Cursor.CLOSED || self.isDead()) return callback(null, false);",nit: I prefer the space before and after this check to make it very easy to scan when reading through code,Why is this needed?
+5943,"@@ -454,6 +454,15 @@ Morbi Nulla justo Aenean orci Vestibulum ullamcorper tincidunt mollis et hendrer
+                     logger.Info(createdMessage);
+                 }
+ 
++                // Make triple-flush to fully exercise the async flushing logic
++                try
++                {
++                    LogManager.Flush(0);
++                }
++                catch (NLog.NLogRuntimeException)
++                { }
++                LogManager.Flush(); // Waits for flush (Scheduled on top of the previous flush)
++                LogManager.Flush(); // Nothing to flush
+             });
+ 
+ ",should users also do a triple-flush?,Why do we need this?
+5944,"@@ -302,9 +302,7 @@ func testCodec(t *testing.T, ct CodecTester) {
+ 	type S struct {
+ 		N  *int
+ 		I  int
+-		U  uint
+ 		F  float64
+-		C  complex64
+ 		St string
+ 		B  bool
+ 		By []byte","What is the implication of removing these from the test? I thought the idea was to have all types supported by `docstore` here, and do things in the drivers to make them support them (e.g., list of size 2 for complex). If you're removing them because firestore doesn't have native support, then we're going to end up only testing the intersection of all types supported by all drivers; we need a better way.",Why are these removed?
+5945,"@@ -217,7 +217,7 @@ class DataViewer(base.GridEditor, layoutwidget.LayoutWidget):
+             ]) -> None:
+         if vals:
+             # Whatever vals is, make it a list of rows containing lists of column values.
+-            if isinstance(vals, str):
++            if not isinstance(vals, list):
+                 vals = [vals]
+             if not isinstance(vals[0], list):
+                 vals = [[i] for i in vals]",Let's also adjust the somewhat weird type signature here as well. This probably should be `typing.Any` instead of `str` in the last line if we intend to support ints.,Why this change?
+5946,"@@ -36,7 +36,7 @@ func makeBucket(t *testing.T) (*blob.Bucket, func()) {
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}
+-	return b, func() {}
++	return b, func() { _ = os.RemoveAll(dir) }
+ }
+ func TestConformance(t *testing.T) {
+ 	drivertest.RunConformanceTests(t, makeBucket, ""../testdata"")",The body can just be `os.RemoveAll(dir)`,Why is this needed?
+5947,"@@ -42,7 +42,7 @@ public class Cast extends NoOp {
+     } else if (targetDataType instanceof RealType) {
+       casted = castToDouble(value);
+     } else {
+-      throw new UnsupportedOperationException(""only support cast to Long, Double and String"");
++      casted = value;
+     }
+     row.set(pos, targetDataType, casted);
+   }",Is this covered by regression tests? Also you might make a patch onto refactor branch.,Why do we need this ch
+5948,"@@ -54,6 +54,11 @@ public class SolrPing extends SolrRequest<SolrPingResponse> {
+   public ModifiableSolrParams getParams() {
+     return params;
+   }
++
++  @Override
++  public String getRequestType() {
++    return SolrRequestType.QUERY.toString();
++  }
+   
+   /**
+    * Remove the action parameter from this request. This will result in the same",This is maybe more of an admin request? WDYT?,Why do we need this method?
+5949,"@@ -109,16 +109,16 @@ public interface TraversableOnce<T> extends Iterable<T> {
+     }
+ 
+     /**
+-     * Converts this TraversableOnce to a HashMap.
++     * Converts this TraversableOnce to a Map.
+      *
+      * @param f   A function that maps an element to a Map.Entry
+      * @param <K> The key type of a Map Entry
+      * @param <V> The value type of a Map Entry
+      * @return a new HashMap containing the elements mapped to entries
+      */
+-    default <K, V> HashMap<K, V> toHashMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) {
++    default <K, V> Map<K, V> toMap(Function<? super T, ? extends Map.Entry<? extends K, ? extends V>> f) {
+         Objects.requireNonNull(f, ""f is null"");
+-        return HashMap.<K, V> ofAll(toList().map(f::apply));
++        return Map.<K, V> ofAll(toList().map(f::apply));
+     }
+ 
+     /**","Here I thought of `toHashMap` and later add `toTreeMap`. But I start to see, what you may have in mind. Alternatively we could provide a `toMap` and `toSortedMap`, which is great, too. On the other hand is always good to be as specific as possible. What do you think?",Why did you change this to 
+5950,"@@ -79,13 +79,13 @@ type appDeployOpts struct {
+ 
+ 	projectService   projectService
+ 	ecrService       ecr.Service
+-	workspaceService *workspace.Workspace
++	workspaceService archer.Workspace
+ 
+ 	prompt  prompter
+ 	spinner progress
+ 
+-	projectApplications []*archer.Application
+-	projectEnvironments []*archer.Environment
++	localProjectAppNames []string
++	projectEnvironments  []*archer.Environment
+ }
+ 
+ func (opts appDeployOpts) String() string {",maybe localProjectAppNames? Just a thought.,why is this a pointer?
+5951,"@@ -354,6 +354,7 @@ Blockly.BlockSvg.prototype.getHeightWidth = function() {
+   if (nextBlock) {
+     var nextHeightWidth = nextBlock.getHeightWidth();
+     height += nextHeightWidth.height;
++    height -= Blockly.BlockSvg.NOTCH_HEIGHT; // Exclude height of connected notch.
+     width = Math.max(width, nextHeightWidth.width);
+   }
+   return {height: height, width: width};","This isn't new, but getHeightWidth is now defined in block_svg.js, block_render_svg_horizontal.js, and block_render_svg_vertical.js. One of these should be unnecessary.",Should this be `Math.min(he
+5952,"@@ -156,7 +156,7 @@ func TestGroupTransactionsDifferentSizes(t *testing.T) {
+ 
+ 		// wait for the txids and check balances
+ 		_, curRound := fixture.GetBalanceAndRound(account0)
+-		confirmed := fixture.WaitForAllTxnsToConfirm(curRound+5, txids)
++		confirmed := fixture.WaitForAllTxnsToConfirm(curRound+10, txids)
+ 		a.True(confirmed, ""txgroup"")
+ 
+ 		for i, acct := range accts {","I can't see any reason why this would fix a failure in `a.True(confirmed, ""txgroup"")`. We might have an issue elsewhere, but increasing the wait time wouldn't help.",why this change?
+5953,"@@ -46,6 +46,10 @@ module Beaker
+         @logger.perf_output(""Creating symlink from /etc/sysstat/sysstat.cron to /etc/cron.d"")
+         host.exec(Command.new('ln -s /etc/sysstat/sysstat.cron /etc/cron.d'),:acceptable_exit_codes => [0,1])
+       end
++      if @options[:collect_perf_data] =~ /aggressive/
++        @logger.perf_output(""Enabling aggressive sysstat polling"")
++        host.exec(Command.new('sed -i s/5-55\\\/10/*/ /etc/cron.d/sysstat'))
++      end
+       if host['platform'] =~ PERF_START_PLATFORMS # SLES doesn't need this step
+         host.exec(Command.new('service sysstat start'))
+       end","This section needs to be modified; crontab format differs between OS releases (Debian and CentOS, at least).",I think this sho
+5954,"@@ -54,7 +54,10 @@ from .results import PipelineExecutionResult
+ 
+ 
+ def execute_run_iterator(
+-    pipeline: IPipeline, pipeline_run: PipelineRun, instance: DagsterInstance
++    pipeline: IPipeline,
++    pipeline_run: PipelineRun,
++    instance: DagsterInstance,
++    resume_from_failure: bool = False,
+ ) -> Iterator[DagsterEvent]:
+     check.inst_param(pipeline, ""pipeline"", IPipeline)
+     check.inst_param(pipeline_run, ""pipeline_run"", PipelineRun)","if we think this is likely to be augmented with a additional 'run coordination' features or configuration in the future, we could make it an object of some kind instead (or an enum, if we think there may be other resume modes in the future besides just on/off). Just imagining 6 months in the future, it would be unfortunate if there were 7 new args here as the feature gets more complex",`resume_from_fai
+5955,"@@ -1,8 +1,10 @@
++from .affine_grid_generator import affine_grid
+ from .context_block import ContextBlock
+ from .dcn import (DeformConv, DeformConvPack, DeformRoIPooling,
+                   DeformRoIPoolingPack, ModulatedDeformConv,
+                   ModulatedDeformConvPack, ModulatedDeformRoIPoolingPack,
+                   deform_conv, deform_roi_pooling, modulated_deform_conv)
++from .grid_sampler import grid_sample
+ from .masked_conv import MaskedConv2d
+ from .nms import nms, soft_nms
+ from .roi_align import RoIAlign, roi_align",`affine_grid` and `grid_sample` are currently unused. We may remove it from `ops/__init__.py` to speedup the loading of mmdet.,I don't think we
+5956,"@@ -215,6 +215,12 @@ func populateClientConfig(config *Config, createdPacketConn bool) *Config {
+ 	if config.IdleTimeout != 0 {
+ 		idleTimeout = config.IdleTimeout
+ 	}
++	attackTimeout := protocol.DefaultAttackTimeout
++	if config.AttackTimeout > 0 {
++		attackTimeout = config.AttackTimeout
++	} else if config.AttackTimeout < 0 {
++		attackTimeout = 0
++	}
+ 
+ 	maxReceiveStreamFlowControlWindow := config.MaxReceiveStreamFlowControlWindow
+ 	if maxReceiveStreamFlowControlWindow == 0 {",Is there a reason why you need to support negative `AttackTimeout`? Why not just throw an error?,This should be `<= 0`
+5957,"@@ -25,6 +25,7 @@ from typing import Any, Optional, List, Tuple, Union, Generic, TypeVar
+ 
+ import numpy as np
+ import pandas as pd
++import pyspark.sql.functions as F
+ from pandas.api.types import is_list_like, is_dict_like
+ from pandas.core.dtypes.common import infer_dtype_from_object
+ from pandas.core.dtypes.inference import is_sequence",nit: an unnecessary change?,from pyspark.sql impo
+5958,"@@ -1,15 +1,17 @@
+ package http3
+ 
+ import (
+-	""fmt""
+ 	""io""
+ 
+ 	""github.com/lucas-clemente/quic-go""
++	""github.com/marten-seemann/qpack""
+ )
+ 
++type trailerFunc func([]qpack.HeaderField, error)
++
+ // The body of a http.Request or http.Response.
+ type body struct {
+-	str quic.Stream
++	str RequestStream
+ 
+ 	// only set for the http.Response
+ 	// The channel is closed when the user is done with this response:","Is trailer parsing something we have to do in this PR? It would be really helpful to separate stuff like this into smaller, self-contained PRs.",Why do we need this?
+5959,"@@ -153,6 +153,7 @@ module Beaker
+       vm.volumes.each do |vol|
+         @logger.debug ""Deleting volume #{vol.name} for OpenStack host #{vm.name}""
+         vm.detach_volume(vol.id)
++        vol.wait_for { ready? }
+         vol.destroy
+       end
+     end",Any chance of a wait-forever situation here? Is there a reasonable timeout?,Shouldn't this be `vo
+5960,"@@ -79,12 +79,10 @@ func (bs *blockSyncer) P2P() network.Overlay {
+ // Start starts a block syncer
+ func (bs *blockSyncer) Start(ctx context.Context) error {
+ 	logger.Debug().Msg(""Starting block syncer"")
+-	startHeight, err := findSyncStartHeight(bs.bc)
+-	if err != nil {
+-		return err
+-	}
+-	bs.buf.startHeight = startHeight
+-	bs.buf.confirmedHeight = startHeight - 1
++	// FIXME this node may still has issue, if it was following the wrong chain, this is actually a general version of 2, but in 3, we need to rollback blockchain first
++	bs.buf.startHeight = bs.bc.TipHeight() + 1
++	bs.buf.confirmedHeight = bs.bc.TipHeight()
++
+ 	return bs.worker.Start(ctx)
+ }
+ ",line is 165 characters,Why do we need to rollback?
+5961,"@@ -107,9 +107,13 @@ func (s *IntegrationBase) setupSuite(defaultClusterConfigFile string) {
+ 
+ 	s.Require().NoError(s.registerArchivalNamespace())
+ 
+-	// this sleep is necessary because namespacev2 cache gets refreshed in the
+-	// background only every namespaceCacheRefreshInterval period
+-	time.Sleep(namespace.CacheRefreshInterval + time.Second)
++	if clusterConfig.FrontendAddress == """" {
++		// Poke all the in-process namespace caches to refresh without waiting for the usual refresh interval.
++		s.testCluster.RefreshNamespaceCache()
++	} else {
++		// Wait for one whole cycle of the namespace cache v2 refresh interval to be sure that our namespaces are loaded.
++		time.Sleep(namespace.CacheRefreshInterval + time.Second)
++	}
+ }
+ 
+ func (s *IntegrationBase) setupLogger() {",is this for cross DC case?,Why do we need this sleep?
+5962,"@@ -199,7 +199,7 @@ if __name__ == '__main__':
+         keywords='computer vision, object detection',
+         url='https://github.com/open-mmlab/mmdetection',
+         packages=find_packages(exclude=('configs', 'tools', 'demo')),
+-        package_data={'mmdet.ops': ['*/*.so']},
++        package_data={'mmcv.ops': ['*/*.so']},
+         classifiers=[
+             'Development Status :: 4 - Beta',
+             'License :: OSI Approved :: Apache Software License',",Remove this line.,Why this change?
+5963,"@@ -668,10 +668,11 @@ import browser from './browser';
+         }
+ 
+         if (canPlayVp8) {
++            // TODO: Remove vpx entry once servers are migrated
+             profile.TranscodingProfiles.push({
+                 Container: 'webm',
+                 Type: 'Video',
+-                AudioCodec: 'vorbis',
++                AudioCodec: webmAudioCodecs.includes('opus') ? 'opus' : 'vorbis',
+                 VideoCodec: 'vpx',
+                 Context: 'Streaming',
+                 Protocol: 'http',",Maybe it would make sense to use `webmVideoCodecs` here and just append `vpx`. I'm not sure if av1 is currently supported when transcoding to webm though. It looks like it can be included in the mp4 transcoding profile now.,I'm not sure this is the ri
+5964,"@@ -182,7 +182,7 @@ public class StatsValuesFactory {
+       // ""NumericValueSourceStatsValues"" which would have diff parent classes
+       //
+       // part of the complexity here being that the StatsValues API serves two
+-      // masters: collecting concrete Values from things like DocValuesStats and
++      // primaries: collecting concrete Values from things like DocValuesStats and
+       // the distributed aggregation logic, but also collecting docIds which it
+       // then
+       // uses to go out and pull concreate values from the ValueSource","Interestingly, this has nothing to do with replication, no clue what this means here",I'm not sure if this is a typo or a typo.
+5965,"@@ -251,8 +251,14 @@ func (r *runner) initRepoIfNeeded(ctx context.Context, forCmd string) (
+ 		}()
+ 	}
+ 
+-	fs, _, err = libgit.GetOrCreateRepoAndID(
+-		ctx, r.config, r.h, r.repo, r.uniqID)
++	// Only allow lazy creates for public and multi-user TLFs.
++	if r.h.Type() == tlf.Public || len(r.h.ResolvedWriters()) > 1 {
++		fs, _, err = libgit.GetOrCreateRepoAndID(
++			ctx, r.config, r.h, r.repo, r.uniqID)
++	} else {
++		fs, _, err = libgit.GetRepoAndID(
++			ctx, r.config, r.h, r.repo, r.uniqID)
++	}
+ 	if err != nil {
+ 		return nil, nil, err
+ 	}",Is that because we don't provide a UI for these?,I don't think we want to allow lazy creat
+5966,"@@ -7,9 +7,11 @@ import (
+ 	""time""
+ 
+ 	""github.com/influxdata/flux""
++	""github.com/influxdata/flux/codes""
+ 	""github.com/influxdata/flux/execute""
+ 	""github.com/influxdata/flux/execute/executetest""
+ 	_ ""github.com/influxdata/flux/fluxinit/static"" // We need to init flux for the tests to work.
++	""github.com/influxdata/flux/internal/errors""
+ 	""github.com/influxdata/flux/mock""
+ 	""github.com/influxdata/flux/querytest""
+ 	""github.com/influxdata/flux/stdlib/csv""",Standard is either to use `HappyPath` (CamelCase) or `happy path` (lowercase sentence). I usually prefer the latter.,Why is this needed?
+5967,"@@ -46,7 +46,7 @@ func TestSuggestGasPriceForUserAction(t *testing.T) {
+ 	blkState := blockchain.InMemStateFactoryOption()
+ 	blkMemDao := blockchain.InMemDaoOption()
+ 	blkRegistryOption := blockchain.RegistryOption(&registry)
+-	bc := blockchain.NewBlockchain(cfg, blkState, blkMemDao, blkRegistryOption)
++	bc := blockchain.NewBlockchain(cfg, nil, blkState, blkMemDao, blkRegistryOption)
+ 	bc.Validator().AddActionEnvelopeValidators(protocol.NewGenericValidator(bc))
+ 	exec := execution.NewProtocol(bc, config.NewHeightUpgrade(cfg))
+ 	require.NoError(t, registry.Register(execution.ProtocolID, exec))","instead of using blkMemDao, we could generate a blockMemDao, and then use it as the second parameter.",Error return value of `bc.Validator().Add
+5968,"@@ -147,6 +147,10 @@ function eachAsync(arr, eachFn, callback) {
+   }
+ }
+ 
++function isUnifiedTopology(topology) {
++  return topology.description != null;
++}
++
+ module.exports = {
+   uuidV4,
+   calculateDurationInMs,",nit(2/10): `topology && topology.description != null`;,nit: `return topology.description != null;`
+5969,"@@ -1,6 +1,8 @@
+ """"""
+ Wrappers around spark that correspond to common pandas functions.
+ """"""
++import sys
++
+ import pyspark.sql
+ import numpy as np
+ import pandas as pd",why the space? I may not know all the style conventions.,Why do we need this import?
+5970,"@@ -21,6 +21,12 @@ describe('dlitem', function () {
+ 		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
+ 	});
+ 
++	it('should fail if the dlitem has a parent <dl> with a changed role', function(){
++		var checkArgs = checkSetup('<dl role=""menubar""><dt id=""target"">My list item</dl>');
++
++		assert.isFalse(checks.dlitem.evaluate.apply(null, checkArgs));
++	});
++
+ 	(shadowSupport.v1 ? it : xit)('should return true in a shadow DOM pass', function () {
+ 		var node = document.createElement('div');
+ 		node.innerHTML = '<dt>My list item </dt>';","Should be ""should fail if the **dt element** has a parent <dl> with a changed role""",nit: space before `{`
+5971,"@@ -10,7 +10,15 @@ Workshops::Application.configure do
+   config.assets.digest = true
+   config.assets.js_compressor = :uglifier
+   config.assets.precompile += %w( print.css prefilled_input.js )
+-  config.serve_static_assets = false
++
++  # Serve static assets, which allows us to populate the CDN with compressed
++  # assets if a client supports them
++  config.serve_static_assets = true
++
++  # Fiddling with expires values is kind of pointless as we use hashing to bust
++  # caches during redeploys, but it should bump up our google pagespeed
++  # ranking.
++  config.static_cache_control = 'public, max-age=31536000'
+ 
+   config.eager_load = true
+   config.cache_store = :dalli_store","Just to be clear: 1. This is required for compression, right? 2. This won't actually result in our dynos serving the assets, since they'll be served via the CDN, correct?",I don't think we need to set this to `true`
+5972,"@@ -17,10 +17,6 @@ class MediaManager extends BasePHPCRManager
+ {
+     /**
+      * {@inheritdoc}
+-     *
+-     * Warning: previous method signature was : save(MediaInterface $media, $context = null, $providerName = null)
+-     *
+-     * @throws \InvalidArgumentException When entity is an invalid object
+      */
+     public function save($entity, $andFlush = true)
+     {",not sure about removing this ping @Soullivaneuh,why removing this?
+5973,"@@ -12,7 +12,12 @@ class User < ActiveRecord::Base
+   validates :github_username, uniqueness: true, presence: true
+ 
+   delegate :plan, to: :subscription, allow_nil: true
+-  delegate :scheduled_for_deactivation_on, to: :subscription, allow_nil: true
++  delegate(
++    :scheduled_for_deactivation_on,
++    :scheduled_for_deactivation?,
++    to: :subscription,
++    allow_nil: true
++  )
+ 
+   before_save :clean_github_username
+ ",Put a comma after the last parameter of a multiline method call.,I'm not sure if th
+5974,"@@ -61,8 +61,8 @@ func TestInstanceIfExists(t *testing.T) {
+ 					Return(nil, awserrors.NewNotFound(""not found""))
+ 			},
+ 			check: func(instance *infrav1.Instance, err error) {
+-				if err != nil {
+-					t.Fatalf(""did not expect error: %v"", err)
++				if err == nil {
++					t.Fatalf(""expects error when instance could not be found: %v"", err)
+ 				}
+ 
+ 				if instance != nil {","If instance could not be found when the provider id is set, `findInstance()` returns `ErrInstanceNotFoundByID` error. So that during reconcileNormal(), we don't create a new instance. In `reconcileDelete()`, when ErrInstanceNotFoundByID is seen, deletion continues to clean up even if the instance is gone (may be manually deleted).",Why did you change
+5975,"@@ -38,6 +38,10 @@ namespace pwiz.Skyline.EditUI
+         private readonly bool _originalAlignRtPrediction;
+         private readonly ChromFileInfoId _originalAlignFile;
+ 
++        private int _idxLastSelected = -1;
++
++        private Tuple<string, HashSet<string>> _memory = Tuple.Create((string)null, new HashSet<string>());
++
+         private SrmDocument Document => _skylineWindow.Document;
+         private GroupByItem SelectedGroupBy => (GroupByItem) comboGroupBy.SelectedItem;
+ ","I would recommend making this a Tuple&lt;ReplicateValue, IColllection&lt;object>> You only need to convert things to strings if you need to persist them in Settings or something. If they only need to live for the life of dialog, you can keep everything as objects. You can use ""null"" for the ReplicateValue for when they have not chosen a property.",Why do we need thi
+5976,"@@ -33,14 +33,14 @@
+         _source: [""https://www.google.lv"", ""https://www.google.co.in/"", ""https://www.google.ru/"", ""http://stackoverflow.com/questions"", ""http://stackoverflow.com/unanswered"", ""http://stackoverflow.com/tags"", ""http://r.search.yahoo.com/""]
+ 	};
+ 	var eventsMap = {
+-		""Login"": [""Lost"", ""Won"",""[CLY]_star_rating""],
++		""Login"": [""Lost"", ""Won""],
+ 		""Logout"": [],
+ 		""Lost"": [""Won"", ""Achievement"", ""Lost""],
+ 		""Won"": [""Lost"", ""Achievement""],
+ 		""Achievement"": [""Sound"", ""Shared""],
+ 		""Sound"": [""Lost"", ""Won""],
+ 		""Shared"": [""Lost"", ""Won""],
+-		""[CLY]_star_rating"":[""Lost"", ""Won"", ""Achievement""]
++        ""[CLY]_action"":[]
+ 	};
+ 	var pushEvents = [""[CLY]_push_sent"", ""[CLY]_push_open"", ""[CLY]_push_action""];
+ 	var segments  = {","I think there is no point providing action key here, as it will be called specifically, rather than randomly",Why did you remove the `Achievement`?
+5977,"@@ -31,14 +31,13 @@ namespace Datadog.Trace.ClrProfiler.Integrations.Testing
+ 
+         private static readonly IntegrationInfo IntegrationId = IntegrationRegistry.GetIntegrationInfo(nameof(IntegrationIds.XUnit));
+         private static readonly Vendors.Serilog.ILogger Log = DatadogLogging.GetLogger(typeof(XUnitIntegration));
+-        private static readonly FrameworkDescription _runtimeDescription;
++        private static readonly FrameworkDescription RuntimeDescription;
+ 
+         static XUnitIntegration()
+         {
+             // Preload environment variables.
+             CIEnvironmentValues.DecorateSpan(null);
+-
+-            _runtimeDescription = FrameworkDescription.Create();
++            RuntimeDescription = FrameworkDescription.Instance;
+         }
+ 
+         /// <summary>",`XUnitIntegration` doesn't need to cache this anymore.,Why do we need this?
+5978,"@@ -13,11 +13,13 @@ files[""awesomerc.lua""].allow_defined_top = true
+ -- This file itself
+ files["".luacheckrc""].ignore = {""111"", ""112"", ""131""}
+ 
++-- Theme files, ignore max line length
++files[""themes/*""].ignore = {""631""}
++
+ -- Global objects defined by the C code
+ read_globals = {
+     ""awesome"",
+     ""button"",
+-    ""client"",
+     ""dbus"",
+     ""drawable"",
+     ""drawin"",",Can we have something line `# noqa` there instead? I think it's fine like this though.,Why is this removed?
+5979,"@@ -309,16 +309,17 @@ class AbstractNode
+   #
+   # Returns A String reference or data URI for the target image
+   def image_uri(target_image, asset_dir_key = 'imagesdir')
++    images_base = asset_dir_key ? (attr asset_dir_key, nil, true) : nil
+     if (doc = @document).safe < SafeMode::SECURE && (doc.attr? 'data-uri')
+       if ((Helpers.uriish? target_image) && (target_image = Helpers.encode_spaces_in_uri target_image)) ||
+-          (asset_dir_key && (images_base = doc.attr asset_dir_key) && (Helpers.uriish? images_base) &&
++          (images_base && (Helpers.uriish? images_base) &&
+           (target_image = normalize_web_path target_image, images_base, false))
+         (doc.attr? 'allow-uri-read') ? (generate_data_uri_from_uri target_image, (doc.attr? 'cache-uri')) : target_image
+       else
+         generate_data_uri target_image, asset_dir_key
+       end
+     else
+-      normalize_web_path target_image, (asset_dir_key ? (doc.attr asset_dir_key) : nil)
++      normalize_web_path target_image, images_base
+     end
+   end
+ ",this variable is used in both branches so I've decided to declare it above,Style/IfUnlessModifier: Favor modifie
+5980,"@@ -382,11 +382,11 @@ public class PasscodeManager  {
+         	return;
+         }
+         Intent i = new Intent(ctx, PasscodeActivity.class);
+-        i.setFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
+-        i.setFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
+-        i.setFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
++        i.addFlags(Intent.FLAG_ACTIVITY_SINGLE_TOP);
++        i.addFlags(Intent.FLAG_ACTIVITY_NO_HISTORY);
++        i.addFlags(Intent.FLAG_ACTIVITY_REORDER_TO_FRONT);
+         if (ctx == SalesforceSDKManager.getInstance().getAppContext()) {
+-            i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
++            i.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+         }
+         if (ctx instanceof Activity) {
+             ((Activity) ctx).startActivityForResult(i, PASSCODE_REQUEST_CODE);","`setFlags()` overwrites the previous flag, we should be using `addFlags()` to append flags.",Why did you change this?
+5981,"@@ -105,6 +105,15 @@ func SettingsPost(ctx *context.Context, form auth.RepoSettingForm) {
+ 		}
+ 
+ 		if repo.IsMirror {
++			if isNameChanged {
++				var err error
++				ctx.Repo.Mirror, err = models.GetMirror(repo.ID)
++				if err != nil {
++					ctx.Handle(500, ""RefreshRepositoryMirror"", err)
++					return
++				}
++			}
++
+ 			if form.Interval > 0 {
+ 				ctx.Repo.Mirror.EnablePrune = form.EnablePrune
+ 				ctx.Repo.Mirror.Interval = form.Interval",Need `return` after this.,Why do we need this?
+5982,"@@ -13,12 +13,14 @@ use RootedData\Exception\ValidationException;
+  * Json Response Trait.
+  */
+ trait JsonResponseTrait {
++  use CacheableResponseTrait;
+ 
+   /**
+    * Private.
+    */
+   private function getResponse($message, int $code = 200): JsonResponse {
+-    return new JsonResponse($message, $code, []);
++    $response = new JsonResponse($message, $code, []);
++    return $this->addCacheHeaders($response);
+   }
+ 
+   /**","I would say we should not use the `CacheableResponseTrait` within the `JsonResponseTrait`. Traits within traits tend to lead to a bad developer experience as it can be really hard to find the actual method you're seeing in the implementing class, and in this case it looks like we're using _both_ the cacheable and the JSON traits in the same controller, so it's redundant anyway. I'd recommend just removing that use statement from `JsonResponseTrait` and make sure `ChaceableResponseTrait` is included everywhere it's needed specifically.",Why do we need this trai
+5983,"@@ -43,7 +43,7 @@ class BoundZmqEventBus implements EventBus {
+     Addresses xpubAddr = deriveAddresses(address, publishConnection);
+     Addresses xsubAddr = deriveAddresses(address, subscribeConnection);
+ 
+-    LOG.info(String.format(""XPUB binding to %s, XSUB binding to %s"", xpubAddr, xsubAddr));
++    LOG.finest(String.format(""XPUB binding to %s, XSUB binding to %s"", xpubAddr, xsubAddr));
+ 
+     xpub = context.createSocket(SocketType.XPUB);
+     xpub.setImmediate(true);",This change is unhelpful: it precludes users from knowing which ports are being used for what purpose within the system.,This should be `LOG.fine
+5984,"@@ -5,7 +5,8 @@ class ApplicationController < ActionController::Base
+   private
+ 
+   def current_user
+-    User.find_by(email_address: session[:user]['email']) if session[:user].present?
++    # User.find_by(email_address: session[:user]['email']) if session[:user].present?
++    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
+   end
+ 
+   def signed_in?","Whoa, we weren't doing this before?? Derp.",Why is this needed?
+5985,"@@ -134,11 +134,16 @@ func (f *ofFlow) CopyToBuilder(priority uint16) FlowBuilder {
+ 
+ // ToBuilder returns a new FlowBuilder with all the contents of the original Flow.
+ func (f *ofFlow) ToBuilder() FlowBuilder {
+-	// TODO: use exported fields from ofFlow and remove nolint:govet
+-	flow := *f.Flow //nolint:govet
++	flow := &ofctrl.Flow{
++		Table:      f.Flow.Table,
++		CookieID:   f.Flow.CookieID,
++		CookieMask: f.Flow.CookieMask,
++		Match:      f.Flow.Match,
++	}
++	f.Flow.CopyActionsToNewFlow(flow)
+ 	newFlow := ofFlow{
+ 		table:    f.table,
+-		Flow:     &flow,
++		Flow:     flow,
+ 		matchers: f.matchers,
+ 		protocol: f.protocol,
+ 	}","I'm surprised we didn't go with something like `flow := f.Flow.Copy()` to take care of all the fields at once, but as long as it works it's good enough for me",nit: this could be 
+5986,"@@ -467,7 +467,7 @@ func NewIntDataplaneDriver(config Config) *InternalDataplane {
+ 	}
+ 
+ 	// TODO Integrate XDP and BPF infra.
+-	if !config.BPFEnabled && dp.xdpState == nil {
++	if !config.BPFEnabled && config.XDPEnabled && dp.xdpState == nil {
+ 		xdpState, err := NewXDPState(config.XDPAllowGeneric)
+ 		if err == nil {
+ 			if err := xdpState.WipeXDP(); err != nil {","We would like this code to run, even when `config.XDPEnabled` is false, so that Felix can clean up its own XDP state after a restart.",Why do we need to d
+5987,"@@ -5,7 +5,10 @@
+ 
+ package net.sourceforge.pmd.lang.java.ast;
+ 
+-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode {
++public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
++
++    QualifiedName qualifiedName;
++
+     public ASTAnnotationTypeDeclaration(int id) {
+         super(id);
+     }","I'd declare this field `qualifiedName` private to hide it. Unless it really needs to be modified from somewhere else... (e.g. unit tests..), but then, we should find a solution, where this field can stay private.",Why is this needed?
+5988,"@@ -53,7 +53,18 @@ var (
+ 	_ introspection.IntrospectableOutbound = (*Outbound)(nil)
+ )
+ 
+-var defaultURLTemplate, _ = url.Parse(""http://localhost"")
++const http2AuthorityPseudoHeader = "":authority""
++
++var (
++	defaultURLTemplate, _ = url.Parse(""http://localhost"")
++	// from https://tools.ietf.org/html/rfc7540#section-8.1.2.3
++	http2PseudoHeaders = []string{
++		"":method"",
++		"":scheme"",
++		http2AuthorityPseudoHeader,
++		"":path"",
++	}
++)
+ 
+ // OutboundOption customizes an HTTP Outbound.
+ type OutboundOption func(*Outbound)","is this exhaustive? or rather, any psudo header started with `:` is un-parsable/invalid in HTTP/1 right?",I don't think we need the `http2` prefix.
+5989,"@@ -113,8 +113,10 @@ describe('Sessions', function () {
+ 
+           return client
+             .withSession(testCase.operation(client))
+-            .catch(() => expect(client.topology.s.sessionPool.sessions).to.have.length(1))
+-            .then(() => expect(client.topology.s.sessionPool.sessions).to.have.length(1))
++            .then(
++              () => expect(client.topology.s.sessionPool.sessions).to.have.length(1),
++              () => expect(client.topology.s.sessionPool.sessions).to.have.length(1)
++            )
+             .then(() => client.close())
+             .then(() => {
+               // verify that the `endSessions` command was sent",Is this change implying something or just seems fit b/c regardless of outcome the sessions should still be length 1?,Why is this change needed?
+5990,"@@ -48,12 +48,15 @@ public class DiscoveryFragmentGenerator {
+ 
+     ApiaryConfig apiaryConfig = discovery.getConfig();
+ 
++    // TODO: Support multiple templates; don't hard-code the zero-index here.
++    Preconditions.checkArgument(configProto.getTemplatesCount() == 1);
+     DiscoveryLanguageProvider languageProvider =
+-        GeneratorBuilderUtil.createLanguageProvider(
+-            configProto.getLanguageProvider(),
++        GeneratorBuilderUtil.createClass(
++            configProto.getTemplates(0).getLanguageProvider(),
+             DiscoveryLanguageProvider.class,
+             new Class<?>[] {Service.class, ApiaryConfig.class},
+             new Object[] {discovery.getService(), apiaryConfig},
++            ""discovery language provider"",
+             new GeneratorBuilderUtil.ErrorReporter() {
+               @Override
+               public void error(String message, Object... args) {","Maybe throw an exception if there is more than one, so that discovering the lack of support is easier when someone tries to use it down the road.",I think this should be `Preconditions.che
+5991,"@@ -85,8 +85,7 @@ Upcase::Application.routes.draw do
+       resource :trail, controller: ""exercise_trails"", only: [:show]
+     end
+ 
+-    get ""/new-languages"", to: ""marketing#new_languages""
+-    get ""/new-languages-thanks"", to: ""marketing#new_languages_thanks""
++    get ""/new-language-confirmation"", to: ""new_language_confirmations#index""
+     get '/pages/:id', to: 'high_voltage/pages#show', as: :page, format: false
+     get '/privacy', to: 'pages#show', as: :privacy, id: 'privacy'
+     get '/purchases/:lookup', to: 'pages#show', id: 'purchase-show'",Prefer single-quoted strings when you don't need string interpolation or special symbols.,I think this should be `new_language_conf
+5992,"@@ -334,3 +334,11 @@ func NewGCPDialOptions(t *testing.T, recording bool, filename string) (opts []gr
+ 	}
+ 	return opts, done
+ }
++
++// RunTestsDependingOnDocker returns true when either:
++// 1) Not on Travis.
++// 2) On Travis Linux environment, where Docker is available.
++func RunTestsDependingOnDocker() bool {
++	s := os.Getenv(""TRAVIS_OS_NAME"")
++	return s == """" || s == ""linux""
++}","I feel the name of this function could be better, conveying it's a predicate. Something like `HasDockerTestEnvironment` or `CanRunLocalServerTests`, etc.",I'm not sure if this is the best place for this function. I think it would be better to move it to `pkg/test/util/environment.go`
+5993,"@@ -30,14 +30,14 @@ func NewMonsterStorageClient(cc *grpc.ClientConn) MonsterStorageClient {
+ func (c *monsterStorageClient) Store(ctx context.Context, in *flatbuffers.Builder, 
+ 	opts... grpc.CallOption) (* Stat, error) {
+   out := new(Stat)
+-  err := grpc.Invoke(ctx, ""/Example.MonsterStorage/Store"", in, out, c.cc, opts...)
++  err := grpc.Invoke(ctx, ""/MyGame.Example.MonsterStorage/Store"", in, out, c.cc, opts...)
+   if err != nil { return nil, err }
+   return out, nil
+ }
+ 
+ func (c *monsterStorageClient) Retrieve(ctx context.Context, in *flatbuffers.Builder, 
+ 	opts... grpc.CallOption) (MonsterStorage_RetrieveClient, error) {
+-  stream, err := grpc.NewClientStream(ctx, &_MonsterStorage_serviceDesc.Streams[0], c.cc, ""/Example.MonsterStorage/Retrieve"", opts...)
++  stream, err := grpc.NewClientStream(ctx, &_MonsterStorage_serviceDesc.Streams[0], c.cc, ""/MyGame.Example.MonsterStorage/Retrieve"", opts...)
+   if err != nil { return nil, err }
+   x := &monsterStorageRetrieveClient{stream}
+   if err := x.ClientStream.SendMsg(in); err != nil { return nil, err }","This seems unrelated to your PR, how did this end up in here?",This should be `Example.MonsterStorage.Retrieve`
+5994,"@@ -143,7 +143,7 @@ public class InMemoryUserDetailsManager implements UserDetailsManager,
+ 	@Override
+ 	public UserDetails updatePassword(UserDetails user, String newPassword) {
+ 		String username = user.getUsername();
+-		MutableUserDetails mutableUser = this.users.get(username);
++		MutableUserDetails mutableUser = this.users.get(username.toLowerCase());
+ 		mutableUser.setPassword(newPassword);
+ 		return mutableUser;
+ 	}",Is `username` expected to be case insensitive?,Why do we need to lowercase here?
+5995,"@@ -18,16 +18,13 @@ import (
+ 	""testing""
+ 	""time""
+ 
+-	""github.com/iotexproject/iotex-core/pkg/util/fileutil""
+-
+-	""github.com/iotexproject/iotex-core/pkg/unit""
+-
+-	""github.com/iotexproject/iotex-core/test/identityset""
+-
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/assert""
+ 	""github.com/stretchr/testify/require""
+ 
++	""github.com/iotexproject/iotex-core/pkg/util/fileutil""
++	""github.com/iotexproject/iotex-core/pkg/unit""
++	""github.com/iotexproject/iotex-core/test/identityset""
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""
+ 	""github.com/iotexproject/iotex-core/blockchain/genesis""",File is not `gofmt`-ed with `-s` (from `gofmt`),nit: remove empty line
+5996,"@@ -37,9 +37,9 @@ import net.sourceforge.pmd.util.FileUtil;
+ import net.sourceforge.pmd.util.datasource.DataSource;
+ 
+ /**
+- *
+- *
++ * @deprecated use {@link TimeTracker} instead
+  */
++@Deprecated
+ public final class Benchmarker {
+ 
+     private static final Map<String, BenchmarkResult> BENCHMARKS_BY_NAME = new HashMap<>();","Is there any point to the deprecation? If someone was using these APIs, can they continue to do so in any meaningful fashion now that you've disconnected them from the PMD internals? Normally ""compiles but doesn't work"" is considered a bug.  ",I don't think we need to deprecate this class.
+5997,"@@ -104,7 +104,7 @@ class CompletionView(QTreeView):
+     """"""
+ 
+     resize_completion = pyqtSignal()
+-    selection_changed = pyqtSignal(QItemSelection)
++    selection_changed = pyqtSignal(str)
+ 
+     def __init__(self, win_id, parent=None):
+         super().__init__(parent)",You can remove the `QItemSelection` import in this file now.,Why this change?
+5998,"@@ -11,12 +11,17 @@ namespace meta {
+ 
+ void ListSpacesProcessor::process(const cpp2::ListSpacesReq& req) {
+     UNUSED(req);
+-    guard_ = std::make_unique<std::lock_guard<std::mutex>>(
+-                                BaseProcessor<cpp2::ListSpacesResp>::lock_);
++    auto& spaceLock = LockUtils::spaceLock();
++    if (!spaceLock.try_lock_shared()) {
++        resp_.set_code(cpp2::ErrorCode::E_TABLE_LOCKED);
++        onFinished();
++        return;
++    }
+     auto prefix = MetaUtils::spacePrefix();
+     std::unique_ptr<kvstore::KVIterator> iter;
+     auto ret = kvstore_->prefix(kDefaultSpaceId_, kDefaultPartId_, prefix, &iter);
+     if (ret != kvstore::ResultCode::SUCCEEDED) {
++        spaceLock.unlock_shared();
+         resp_.set_code(to(ret));
+         onFinished();
+         return;",Use `std::shared_lock` and `std::try_to_lock_t`. BTW. Why we fail on contention?,Why do we need to lock here?
+5999,"@@ -37,7 +37,10 @@ module.exports = function(config) {
+         new webpack.DefinePlugin({
+           ""process.env.NODE_ENV"": JSON.stringify(""test"")
+         })
+-      ]
++      ],
++      resolve: {
++        extensions: ["""", "".jsx"", "".js""]
++      }
+     },
+ 
+     webpackServer: {","Not sure what this actually does, but do you need to add `""""` here? Or does `["".jsx"", "".js""]` work too?",Why is this needed?
+6000,"@@ -8,6 +8,7 @@ package blockchain
+ 
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-address/address""
+ 	""io/ioutil""
+ 	""math/big""
+ 	""os""",let's group imports in the order: std third party first party,Please remove this empty line.
+6001,"@@ -1062,7 +1062,7 @@ public class JdbcExecutorLoaderTest {
+     return new JdbcExecutorLoader(props,
+         new CommonMetrics(new MetricsManager(new MetricRegistry())), null
+         , null, null, null, null,
+-        null, null);
++        null, null, null);
+   }
+ 
+   private boolean isTestSetup() {",So the tests run only when the db exists? Else everything passes?,Why is this change needed?
+6002,"@@ -0,0 +1,12 @@
++package bytesink
++
++import ""io""
++
++// ByteSink represents a location to which bytes can be written. The ByteSink
++// should be closed after all bytes have been written.
++type ByteSink interface {
++	io.Writer
++	io.Closer
++	Open() error
++	ID() string
++}","`Remove` is unclear. It seems the point is to allow the `FifoByteSink` to delete the underlying file. There seems to be an implicit contract that consumers of this interface call `Remove` after `Close` without necessarily understanding what `Remove` does. I get that it's a little awkward to have `FifoByteSink` delete the file in `Close`. It would probably be best to just remove this from the interface, since `AddSink` is working with an actual `FifoByteSink`. I would rename it in `FifoByteSync` to `DeleteFile` or `Cleanup` or something that's makes it more clear what's being removed.",Why do we need this interface?
+6003,"@@ -0,0 +1,13 @@
++package core
++
++import (
++	""math/big""
++
++	""github.com/filecoin-project/go-filecoin/types""
++)
++
++type Ask struct {
++	Price *big.Int
++	Size  *big.Int
++	Miner types.Address
++}",Mentioned elsewhere but repeating again: would be nice to have units (ideally `Size *Bytes`).,Why is this a pointer?
+6004,"@@ -269,7 +269,7 @@ describe ""Bolt::CLI"" do
+         cli.execute(cli.parse)
+       end
+ 
+-      it 'install modules from Puppetfile with resolving' do
++      it 'install modules from Puppetfile without resolving' do
+         cli = Bolt::CLI.new(%W[module install --project #{project} --no-resolve])
+ 
+         allow(installer).to receive(:install) do |*args|","I think a test in `spec/integration` might help keep this file a bit more manageable, especially since we're just checking file contents and errors. But basically the same idea!",I think this should be `without resolving`
+6005,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+ 
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)",Why was this removed?
+6006,"@@ -1105,7 +1105,8 @@ instr_set_label_callback(instr_t *instr, instr_label_callback_t cb)
+ {
+     CLIENT_ASSERT(instr_is_label(instr),
+                   ""only set callback functions for label instructions"");
+-    CLIENT_ASSERT(instr->label_cb == NULL, ""label callback function is already set"");
++    CLIENT_ASSERT(instr->label_cb == NULL || cb == NULL,
++                  ""label callback function is already set"");
+     CLIENT_ASSERT(!TEST(INSTR_RAW_BITS_ALLOCATED, instr->flags),
+                   ""instruction's raw bits occupying label callback memory"");
+     instr->label_cb = cb;","So this means that we can remove a callback via instr_set_label_callback(). Maybe consider adding another API function for removal, and add a new assert here such that cb != NULL?",Shouldn't this be `instr->label_cb = cb`?
+6007,"@@ -30,7 +30,9 @@
+ 
+   <p><%= _(""Last modified: "") + l(@plan.updated_at.to_date, formats: :short) %></p> <br>
+ 
+-  <p><%= _(""Copyright information:"") %></p>
+-  <div style=""margin-left: 15px;""><p><%= _("" The above plan creator(s) have agreed that others may use as much of the text of this plan as they would like in their own plans, and customise it as necessary. You do not need to credit the creator(s) as the source of the language used, but using any of the plan's text does not imply that the creator(s) endorse, or have any relationship to, your project or proposal"") %></p></div>
++  <% if @public_plan %>
++    <p><%= _(""Copyright information:"") %></p>
++    <div style=""margin-left: 15px;""><p><%= _("" The above plan creator(s) have agreed that others may use as much of the text of this plan as they would like in their own plans, and customise it as necessary. You do not need to credit the creator(s) as the source of the language used, but using any of the plan's text does not imply that the creator(s) endorse, or have any relationship to, your project or proposal"") %></p></div>
++  <% end %>
+ </div>
+ <hr class=""bottom"" />",why are we using an instance variable instead of accessing the visibility method?,I don't think you need the `<% end %>` her
+6008,"@@ -173,6 +173,7 @@ func (h *HTTPTransport) NewTransport(ctx caddy.Context) (*http.Transport, error)
+ 		dialer.Resolver = &net.Resolver{
+ 			PreferGo: true,
+ 			Dial: func(ctx context.Context, _, _ string) (net.Conn, error) {
++				//nolint:gosec
+ 				addr := h.Resolver.netAddrs[weakrand.Intn(len(h.Resolver.netAddrs))]
+ 				return d.DialContext(ctx, addr.Network, addr.JoinHostPort(0))
+ 			},",Ok. Can we just disable this linter?,Why is this needed?
+6009,"@@ -6,7 +6,7 @@ from listenbrainz import config
+ from listenbrainz import db
+ 
+ ADMIN_SQL_DIR = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', '..','admin', 'sql')
+-TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), 'test_data')
++TEST_DATA_PATH = os.path.join(os.path.dirname(os.path.realpath(__file__)), '..', 'testdata')
+ 
+ 
+ class DatabaseTestCase(unittest.TestCase):","this is `test_data` and all other instances are `testdata` - does this change affect any test files, or are there actually no directories called `test_data` in the repo? (I just checked, it seems like there aren't...)",Why this change?
+6010,"@@ -48,10 +48,6 @@ public class ApiVersionStrings {
+         return getBasePath() + ""/chatter/"";
+     }
+ 
+-    public static String getBaseConnectPath() {
+-        return getBasePath() + ""/connect/"";
+-    }
+-
+     public static String getBaseSObjectPath() {
+         return getBasePath() + ""/sobjects/"";
+     }",Fixing `lint` warnings that have existed for a while.,Why was this remove
+6011,"@@ -24,4 +24,9 @@ const (
+ 	// EnvKeyForInstallConfigName is the environment variable to get the
+ 	// the install config's name
+ 	EnvKeyForInstallConfigName InstallENVKey = ""OPENEBS_IO_INSTALL_CONFIG_NAME""
++	// CASDefaultCstorPoolENVK is the ENV key that specifies wether default cstor pool
++	// should be configured or not
++	// If value is ""true"", default cstor pool will be configured else for ""false""
++	// it will not be configured.
++	CASDefaultCstorPool InstallENVKey = ""OPENEBS_IO_INSTALL_DEFAULT_CSTOR_SPARSE_POOL""
+ )",Better to rename this to CASDefaultCstorSparsePool.,I think this should
+6012,"@@ -105,4 +105,9 @@ public class S3FileIO implements FileIO {
+     this.awsClientFactory = AwsClientFactories.from(properties);
+     this.s3 = awsClientFactory::s3;
+   }
++
++  @Override
++  public void close() {
++    client().close();
++  }
+ }","Since we'e not 100% sure if `close` will be called more than once, should we set `client` to `null` or add an `AtomicBoolean closed` that will then handle the idempotency issue?",Why is this needed?
+6013,"@@ -379,11 +379,15 @@ Intersection MotorwayHandler::fromRamp(const EdgeID via_eid, Intersection inters
+             //
+             //     7         1
+             //          0
++            const auto &first_intersection_name =
++                name_table.GetNameForID(first_intersection_data.name_id).to_string();
++            const auto &second_intersection_name =
++                name_table.GetNameForID(second_intersection_data.name_id).to_string();
+             if (intersection[1].entry_allowed)
+             {
+                 if (isMotorwayClass(intersection[1].eid, node_based_graph) &&
+-                    second_intersection_data.name_id != EMPTY_NAMEID &&
+-                    first_intersection_data.name_id != EMPTY_NAMEID && first_second_same_name)
++                    !second_intersection_name.empty() && !first_intersection_name.empty() &&
++                    first_second_same_name)
+                 {
+                     // circular order indicates a merge to the left (0-3 onto 4
+                     if (angularDeviation(intersection[1].angle, STRAIGHT_ANGLE) <",And here - what happens if name id is invalid,I don't think you n
+6014,"@@ -0,0 +1,18 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Bolt\Storage\Query\Directive;
++
++use Bolt\Storage\Query\QueryInterface;
++
++/**
++ *  Directive a raw output of the generated query.
++ */
++class PrintQueryDirective
++{
++    public function __invoke(QueryInterface $query): void
++    {
++        echo $query;
++    }
++}",__toString() is not a part of QueryInterface,Missing license hea
+6015,"@@ -43,7 +43,7 @@ from typing import (
+     cast,
+     TYPE_CHECKING,
+ )
+-
++import datetime
+ import numpy as np
+ import pandas as pd
+ from pandas.api.types import is_list_like, is_dict_like, is_scalar",nit: Could you add an empty line between `import datetime` (built-in library block) and `import numpy as np` (third-party library block)?,why did you change 
+6016,"@@ -1284,6 +1284,8 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_TYPE_NAME_MAP{
+   {""CUDA_ERROR_INVALID_PC"",                                            {""hipErrorInvalidPc"",                                        """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 718
+   // cudaErrorLaunchFailure
+   {""CUDA_ERROR_LAUNCH_FAILED"",                                         {""hipErrorLaunchFailure"",                                    """", CONV_NUMERIC_LITERAL, API_DRIVER}}, // 719
++  // cudaErrorCooperativeLaunchTooLarge
++  {""CUDA_ERROR_COOPERATIVE_LAUNCH_TOO_LARGE"",                          {""hipErrorCooperativeLaunchTooLarge"",                        """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 720
+   // cudaErrorNotPermitted
+   {""CUDA_ERROR_NOT_PERMITTED"",                                         {""hipErrorNotPermitted"",                                     """", CONV_NUMERIC_LITERAL, API_DRIVER, HIP_UNSUPPORTED}}, // 800
+   // cudaErrorNotSupported",Please remove `HIP_UNSUPPORTED`,I think it would be better to use `hipErrorCooperativeLaunchTooLarge` instead of `hipErrorNotPermitted`
+6017,"@@ -30,13 +30,17 @@ import { STORE_NAME as CORE_USER } from '../googlesitekit/datastore/user/constan
+ /**
+  * Gets the current dateRange string.
+  *
+- * @param {string} [dateRange] Optional. The date range slug.
++ * @param {string} [dateRange]      Optional. The date range slug.
++ * @param {boolean} [returnNumber]  Optional. If true, returns the number only.
+  * @return {string} the date range string.
+  */
+-export function getCurrentDateRange( dateRange = getCurrentDateRangeSlug() ) {
++export function getCurrentDateRange( dateRange = getCurrentDateRangeSlug(), returnNumber = false ) {
+ 	const daysMatch = dateRange.match( /last-(\d+)-days/ );
+ 
+ 	if ( daysMatch && daysMatch[ 1 ] ) {
++		if ( returnNumber ) {
++			return parseInt( daysMatch[ 1 ], 10 );
++		}
+ 		return sprintf(
+ 			/* translators: %s: Number of days matched. */
+ 			_n( '%s day', '%s days', parseInt( daysMatch[ 1 ], 10 ), 'google-site-kit' ),","Having boolean parameters to change function behavior is not a good practice because it violates the principle of functions being responsible for a single task, so the need for this indicates we need to split something out of here instead. We can introduce a function like `getCurrentDateRangeDayCount` or similar, which does this.",Why not just `return daysMatch[ 1 ]`?
+6018,"@@ -156,7 +156,6 @@ test.suite(
+         await driver.get(fileServer.Pages.basicAuth)
+         let source = await driver.getPageSource()
+         assert.strictEqual(source.includes('Access granted!'), true)
+-        await server.stop()
+       })
+     })
+ ",Is this not required?,Why was this removed?
+6019,"@@ -39,17 +39,9 @@ type (
+ 		GetContractState(hash.PKHash, hash.Hash32B) (hash.Hash32B, error)
+ 		SetContractState(hash.PKHash, hash.Hash32B, hash.Hash32B) error
+ 		// Accounts
+-		Balance(string) (*big.Int, error)
+-		AccountState(string) (*Account, error)
+ 		RootHash() hash.Hash32B
+ 		Version() uint64
+ 		Height() uint64
+-		WorkingCandidates() map[hash.PKHash]*Candidate
+-		GetCandidates(height uint64) (CandidateList, error)
+-
+-		State(hash.PKHash, State) (State, error)
+-		CachedState(hash.PKHash, State) (State, error)
+-		PutState(hash.PKHash, State) error
+ 	}
+ 
+ 	// workingSet implements Workingset interface, tracks pending changes to account/contract in local cache","savedStates is for confirmed states, not needed in working set",Why is this removed?
+6020,"@@ -23,6 +23,9 @@ import (
+ 	""github.com/mysteriumnetwork/node/market""
+ )
+ 
++// ServiceType indicates ""wireguard"" service type
++const ServiceType = ""wireguard""
++
+ // Bootstrap is called on program initialization time and registers various deserializers related to wireguard service
+ func Bootstrap() {
+ 	market.RegisterServiceDefinitionUnserializer(",Why should we move it into `bootstrap.go` file?,Why do we need this constant?
+6021,"@@ -24,8 +24,15 @@ const fontSizes = [
+   72
+ ]
+ 
++const measures = [
++  24,
++  32,
++  48
++]
++
+ module.exports = {
+   breakpoints,
+   space,
+   fontSizes,
++  measures
+ }","In the next major version, I plan on changing the em-unit breakpoints to be pixel values to keep everything consistent. Would be great to handle this with pixels as well, but still allow em-units to be defined with a string",Why do we need to export this
+6022,"@@ -151,7 +151,7 @@ class TabWidget(QTabWidget):
+ 
+         fields = self.get_tab_fields(idx)
+         fields['current_title'] = fields['current_title'].replace('&', '&&')
+-        fields['index'] = idx + 1
++        fields['index'] = str(idx + 1).rjust(2)
+ 
+         title = '' if fmt is None else fmt.format(**fields)
+         tabbar = self.tabBar()","I don't think this will actually align the indexes, if you have > 100 tabs, the tabs over 100 will be misaligned. In addition with less than 10 tabs, there will be a pointless space.",Why not just `str(idx + 1)`?
+6023,"@@ -326,7 +326,7 @@ func (v4 *signer) buildCanonicalHeaders(r rule, header http.Header) {
+ 			headerValues[i] = ""host:"" + v4.Request.URL.Host
+ 		} else {
+ 			headerValues[i] = k + "":"" +
+-				strings.Join(v4.Request.Header[http.CanonicalHeaderKey(k)], "","")
++				strings.Join(v4.signedHeaderVals[k], "","")
+ 		}
+ 	}
+ ","hrm, unsigned headers now won't be included.",I'm not sure if this is the r
+6024,"@@ -53,6 +53,7 @@ class CategoryCode
+      */
+     public static function isValid(string $value): bool
+     {
+-        return strlen($value) <= 255;
++        return '' !== $value
++            && strlen($value) < 256;
+     }
+ }",what if `$value = ' ' `?,Why do we need this change?
+6025,"@@ -262,10 +262,16 @@ class SparkWrite {
+   private class DynamicOverwrite extends BaseBatchWrite {
+     @Override
+     public void commit(WriterCommitMessage[] messages) {
++      Iterable<DataFile> files = files(messages);
++      if (Iterables.size(files) == 0) {
++        LOG.info(""Dynamic overwrite is empty, skipping commit"");
++        return;
++      }
++
+       ReplacePartitions dynamicOverwrite = table.newReplacePartitions();
+ 
+       int numFiles = 0;
+-      for (DataFile file : files(messages)) {
++      for (DataFile file : files) {
+         numFiles += 1;
+         dynamicOverwrite.addFile(file);
+       }",What about using `!files.hasNext` instead? I'm not sure we want to assume that the iterable can be consumed multiple times. Plus there's no need to consume the entire iterable just to check whether it is empty.,"nit: `LOG.info(""Dynamic ove"
+6026,"@@ -85,6 +85,11 @@ Container* Container::getParentContainer()
+ 	return thing->getContainer();
+ }
+ 
++std::string Container::getName() const {
++	const ItemType& it = items[id];
++	return getNameDescription(it, this, -1, false);
++}
++
+ bool Container::hasParent() const
+ {
+ 	return getID() != ITEM_BROWSEFIELD && dynamic_cast<const Player*>(getParent()) == nullptr;",I think we could add bool addArticle here defaulted to false like its done in item class so std::string Container::getName(bool addArticle /* = false*/) const { and pass that variable to getNameDescription call,This should be `const ItemT
+6027,"@@ -47,11 +47,11 @@ public class LockableBottomSheetBehavior<V extends View> extends ViewPagerBottom
+ 
+     @Override
+     public boolean onStartNestedScroll(CoordinatorLayout coordinatorLayout, V child, View directTargetChild,
+-                                       View target, int nestedScrollAxes) {
++                                       View target, int axes, int type) {
+         boolean handled = false;
+ 
+         if (!isLocked) {
+-            handled = super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, nestedScrollAxes);
++            handled = super.onStartNestedScroll(coordinatorLayout, child, directTargetChild, target, axes, type);
+         }
+ 
+         return handled;",What if a library function on the outside still calls the old method? It is then no longer blocked properly. Have you tested the change?,`nestedScrollAxes` -> `axes
+6028,"@@ -197,11 +197,15 @@ static mrb_value build_app_response(struct st_mruby_subreq_t *subreq)
+     return resp;
+ }
+ 
+-static void append_bufs(struct st_mruby_subreq_t *subreq, h2o_iovec_t *inbufs, size_t inbufcnt)
++static void append_bufs(struct st_mruby_subreq_t *subreq, h2o_sendvec_t *inbufs, size_t inbufcnt)
+ {
+-    int i;
++    size_t i;
+     for (i = 0; i != inbufcnt; ++i) {
+-        h2o_buffer_append(&subreq->buf, inbufs[i].base, inbufs[i].len);
++        char *dst = h2o_buffer_reserve(&subreq->buf, inbufs[i].len).base;
++        assert(dst != NULL && ""no memory or disk space; FIXME bail out gracefully"");
++        if (!(*inbufs[i].fill_cb)(&subreq->super, h2o_iovec_init(dst, inbufs[i].len), inbufs + i, 0))
++            h2o_fatal(""FIXME handle error from pull handler"");
++        subreq->buf->size += inbufs[i].len;
+     }
+ }
+ ","@i110 Do you have an idea on how we should propagate errors that occur in this block? The error condition happens when i) `h2o_buffer_reserve` fails to allocate space (happens in master as well), or ii) `fill_cb` returns an error (unique to this PR).",Shouldn't this be `inbufs[i].fill_cb`?
+6029,"@@ -3,7 +3,7 @@ class ReportMailer < ApplicationMailer
+ 
+   def budget_status
+     to_email = ENV.fetch('BUDGET_REPORT_RECIPIENT')
+-    date = Time.now.in_time_zone('Eastern Time (US & Canada)').strftime(""%a %m/%d/%y"")
++    date = Time.now.utc.strftime(""%a %m/%d/%y (%Z)"")
+ 
+     mail(
+       to: to_email,",Does this mean the times will show up in emails as UTC?,Style/StringLiterals: Prefer single-qu
+6030,"@@ -191,11 +191,10 @@ options.Bounds = Options('style', color='black')
+ options.Ellipse = Options('style', color='black')
+ options.Polygons = Options('style', color=Cycle(), line_color='black',
+                            cmap=dflt_cmap)
+-options.Rectangles = Options('style', cmap=dflt_cmap)
+-options.Segments = Options('style', cmap=dflt_cmap)
+ 
+ # Geometries
+-options.Rectangles = Options('style', line_color='black')
++options.Rectangles = Options('style', color=Cycle(), cmap=dflt_cmap, line_color='black')
++options.Segments = Options('style', color='black', cmap=dflt_cmap)
+ 
+ # Rasters
+ options.Image = Options('style', cmap=config.default_gridded_cmap)",What's the motivation for having one of these be a cycle and the other be a fixed color?,Why did you change the order of these 
+6031,"@@ -136,7 +136,7 @@ namespace ResultsComparer
+ 
+             var table = data.ToMarkdownTable().WithHeaders(conclusion.ToString(), conclusion == EquivalenceTestConclusion.Faster ? ""base/diff"" : ""diff/base"", ""Base Median (ns)"", ""Diff Median (ns)"", ""Modality"");
+ 
+-            foreach (var line in table.ToMarkdown().Split(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries))
++            foreach (var line in table.ToMarkdown().Split(Environment.NewLine))
+                 Console.WriteLine($""| {line.TrimStart()}|""); // the table starts with \t and does not end with '|' and it looks bad so we fix it
+ 
+             Console.WriteLine();",What will be an empty entry now?,>StringSplitOptions.RemoveEmptyEntries
+6032,"@@ -71,6 +71,10 @@ export class ManualColumnResize extends BasePlugin {
+     addClass(this.guide, 'manualColumnResizerGuide');
+   }
+ 
++  get inlineDir() {
++    return this.hot.isRtl() ? 'right' : 'left';
++  }
++
+   /**
+    * Checks if the plugin is enabled in the handsontable settings. This method is executed in {@link Hooks#beforeInit}
+    * hook and if it returns `true` than the {@link ManualColumnResize#enablePlugin} method is called.",Can I ask you to add jsdoc tag that would mark the prop as `@private`?,Why do we need this method?
+6033,"@@ -113,3 +113,13 @@ func WriteFile(fromFile io.Reader, to string, mode os.FileMode) error {
+ 	// And move it to its final destination.
+ 	return os.Rename(tempFile.Name(), to)
+ }
++
++// IsDirectory checks if a given path is a directory
++func IsDirectory(path string) bool {
++	info, err := os.Stat(path)
++	if err != nil {
++		return false
++	}
++
++	return info.IsDir()
++}",Do you need this? Don't think you use it?,nit: `return info.IsDir()`
+6034,"@@ -0,0 +1,13 @@
++package com.fsck.k9.widget.list;
++
++
++import android.content.Intent;
++import android.widget.RemoteViewsService;
++
++
++public class MessageListWidgetService extends RemoteViewsService {
++    @Override
++    public RemoteViewsFactory onGetViewFactory(Intent intent) {
++        return new MessageListRemoteViewFactory(this.getApplicationContext());
++    }
++}",`this.` seems unnecessary,I don't think we need this 
+6035,"@@ -244,8 +244,8 @@ def connect_to_service(service_name, client=True, env=None, region_name=None, en
+                 endpoint_url = backend_url
+         config = config or botocore.client.Config()
+         # configure S3 path style addressing
+-        if service_name == 's3':
+-            config.s3 = {'addressing_style': 'path'}
++        # if service_name == 's3':
++        #     config.s3 = {'addressing_style': 'path'}
+         # To, prevent error ""Connection pool is full, discarding connection ..."",
+         # set the environment variable MAX_POOL_CONNECTIONS. Default is 150.
+         config.max_pool_connections = MAX_POOL_CONNECTIONS",nit: can be removed before merging...,Why is this removed?
+6036,"@@ -2,7 +2,7 @@ describe('ContextMenu', function () {
+   var id = 'testContainer';
+ 
+   beforeEach(function () {
+-    this.$container = $('<div id=""' + id + '""></div>').appendTo('body');
++    this.$container = $(`<div id=""${id}""></div>`).appendTo('body');
+   });
+ 
+   afterEach(function () {",Maybe a single quote would be compatible with airbnb style.,Why did you change this?
+6037,"@@ -81,6 +81,10 @@ public abstract class SessionMap implements HasReadyState, Routable {
+ 
+   public abstract void remove(SessionId id);
+ 
++  public int getCount() {
++    return -10;
++  };
++
+   public URI getUri(SessionId id) throws NoSuchSessionException {
+     return get(id).getUri();
+   }",This is not the right approach. The `Distributor` maintains a model of the current state of the Grid. That model already contains the information about every active session. We don't need to modify `SessionMap` to expose it further.,Why is this needed?
+6038,"@@ -279,11 +279,9 @@ func TestFormatWithComments(t *testing.T) {
+ 
+ 	if want := `// hi
+ // there
+-{
+-    _time: r._time,
+-    io_time: r._value,
+-// this is the end
+-}
++{_time: r._time, io_time: r._value
++    // this is the end
++    }
+ 
+ // minimal
+ foo = (arg=[1, 2]) => 1","@Marwes @wolffcm This is the file where I made a change the the expected output. Its a little bit weird, but I think that the final output makes sense for the most part.",Why did you remove the c
+6039,"@@ -94,9 +94,11 @@ func IsValidAppType(apptype string) bool {
+ func (app *DdevApp) CreateSettingsFile() (string, error) {
+ 	app.SetApptypeSettingsPaths()
+ 
+-	// If neither settings file options are set, then don't continue
++	// If neither settings file options are set, then don't continue. Return
++	// a nil error because this should not halt execution if the apptype
++	// does not have a settings definition.
+ 	if app.SiteLocalSettingsPath == """" && app.SiteSettingsPath == """" {
+-		return """", fmt.Errorf(""Neither SiteLocalSettingsPath nor SiteSettingsPath is set"")
++		return """", nil
+ 	}
+ 
+ 	// Drupal and WordPress love to change settings files to be unwriteable.",I think we probably need a util.Warning() here.,Why is this change neces
+6040,"@@ -0,0 +1,19 @@
++from quilt3.util import PhysicalKey, get_from_config, fix_url
++
++from .base import PackageRegistry
++from .local import LocalPackageRegistryV1
++from .s3 import S3PackageRegistryV1
++
++
++def get_package_registry(path=None) -> PackageRegistry:
++    """""" Returns the package registry for a given path """"""
++    # TODO: Don't check if it's PackageRegistry? Then we need better separation
++    #       to external functions that receive string and internal that receive
++    #       PackageRegistry.
++    if isinstance(path, PackageRegistry):
++        return path
++    if not isinstance(path, PhysicalKey):
++        path = PhysicalKey.from_url(
++            get_from_config('default_local_registry') if path is None else fix_url(path)
++        )
++    return (LocalPackageRegistryV1 if path.is_local() else S3PackageRegistryV1)(path)","Let's make have a signature that's consistent with `PhysicalKey.from_path`. Users should also have access to PhysicalKey since that class is part of the API (e.g., `Package.resolve_hash`).",I'm not sure if this is the best way to do this. I think it would be better to have a `get_package_registry_from_url` function that returns a `LocalPackageRegistryV1` or `S3PackageRegistryV1` if the path is a local registry.
+6041,"@@ -0,0 +1,10 @@
++/*eslint no-unused-vars: 0*/
++/* exported utils */
++
++/**
++ * Namespace for imports which holds globals of external dependencies.
++ * @namespace imports
++ * @memberof axe
++ */
++
++var imports = (axe.imports = {});",What is this directive for?,Why do we need this?
+6042,"@@ -155,6 +155,10 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+                   'if a key is present or a default if not, is simpler and considered '
+                   'more idiomatic, although sometimes a bit slower'
+                  ),
++        'R1716': ('simplify chained comparison',
++                  'chained-comparison',
++                  'Chained comparisons like ""a < b and b < c"" can be simplified as ""a < b < c""',
++                  ),
+     }
+     options = (('max-nested-blocks',
+                 {'default': 5, 'type': 'int', 'metavar': '<int>',",I'd rephrase it as `Simplify chained comparison between the operands`.,I don't think this should be a<msg>I think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be a<msg>I don't think it should be an 
+6043,"@@ -296,11 +296,10 @@ class ProductDataFixture
+         $this->clearResources();
+         $this->productsByCatnum = [];
+ 
+-        $onlyForFirstDomain = false;
+         $this->productDataReferenceInjector->loadReferences(
+             $this->productDataFixtureLoader,
+             $this->persistentReferenceFacade,
+-            $onlyForFirstDomain
++            2
+         );
+     }
+ ","so in the performance data fixtures, there will be references for the second domain only?",Why did you change this?
+6044,"@@ -304,7 +304,7 @@ public class DefaultGridRegistry extends BaseGridRegistry implements GridRegistr
+     if (proxy == null) {
+       return;
+     }
+-    LOG.info(""Registered a node "" + proxy);
++    LOG.finest(""Registered a node "" + proxy);
+     try {
+       lock.lock();
+ ",This is wildly unhelpful to users --- they need to know when a proxy has been registered.,Why is this change needed?
+6045,"@@ -203,7 +203,7 @@ class ClientPlayback:
+             # https://github.com/mitmproxy/mitmproxy/issues/2197
+             if hf.request.http_version == ""HTTP/2.0"":
+                 hf.request.http_version = ""HTTP/1.1""
+-                host = hf.request.headers.pop("":authority"")
++                host = hf.request.headers.pop("":authority"", hf.request.pretty_host)
+                 hf.request.headers.insert(0, ""host"", host)
+             self.q.put(hf)
+         ctx.master.addons.trigger(""update"", lst)","If there is no authority header (i.e. someone intentionally deleted it), I would argue we probably don't want a Host header in the replay either. How about we only add it if it exists, and do nothing otherwise?",I think this should be `hf
+6046,"@@ -65,12 +65,7 @@ func TaskMetadataHandler(state dockerstate.TaskEngineState, ecsClient api.ECSCli
+ 			for _, containerResponse := range taskResponse.Containers {
+ 				networks, err := GetContainerNetworkMetadata(containerResponse.ID, state)
+ 				if err != nil {
+-					errResponseJSON, err := json.Marshal(err.Error())
+-					if e := utils.WriteResponseIfMarshalError(w, err); e != nil {
+-						return
+-					}
+-					utils.WriteJSONToResponse(w, http.StatusInternalServerError, errResponseJSON, utils.RequestTypeContainerMetadata)
+-					return
++					seelog.Warnf(""Error retrieving network metadata for container %s - %s"", containerResponse.ID, err)
+ 				}
+ 				containerResponse.Networks = networks
+ 				responses = append(responses, containerResponse)",is there any unit test that can be updated to verify this?,Why do we need to warn her
+6047,"@@ -418,7 +418,18 @@ static int cb_lua_filter(const void *data, size_t bytes,
+         lua_pushstring(ctx->lua->state, tag);
+         lua_pushnumber(ctx->lua->state, ts);
+         lua_pushmsgpack(ctx->lua->state, p);
+-        lua_call(ctx->lua->state, 3, 3);
++        if (ctx->protected_mode) {
++            ret = lua_pcall(ctx->lua->state, 3, 3, 0);
++            if (ret != 0) {
++                flb_plg_error(ctx->ins, ""error code %d: %s"",
++                              ret, lua_tostring(ctx->lua->state, -1));
++                lua_pop(ctx->lua->state, 1);
++                return FLB_FILTER_NOTOUCH;
++            }
++        }
++        else {
++            lua_call(ctx->lua->state, 3, 3);
++        }
+ 
+         /* Initialize Return values */
+         l_code = 0;","exiting at this point is leaking memory, take a look at the valgrind output. the sbuffer must be destroyed.",This should be `if (ret !=
+6048,"@@ -0,0 +1,13 @@
++def pytest_addoption(parser):
++    parser.addoption(
++        '--poppler',
++        action='store_true',
++        dest='poppler',
++        default=False,
++        help=""Indicates poppler tools (incl. pdftoppm) installed""
++    )
++
++
++def pytest_configure(config):
++    if not config.option.poppler:
++        setattr(config.option, 'markexpr', 'not poppler')",i think you want a different flag and help like `--ffmpeg` or something; and you need to mark any tests you want skipped,Why is this needed?
+6049,"@@ -32,9 +32,10 @@ import (
+ 	""github.com/golang/protobuf/proto""
+ 	""github.com/golang/protobuf/ptypes""
+ 	""github.com/golang/protobuf/ptypes/empty""
+-	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
+ 	auditpb ""google.golang.org/genproto/googleapis/cloud/audit""
+ 	logpb ""google.golang.org/genproto/googleapis/logging/v2""
++
++	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
+ )
+ 
+ const (",this needed to change? or it was just some formatting thing?,nit: remove empty l
+6050,"@@ -278,10 +278,11 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+     params.add(""--auto-log-bloom-caching-enabled"");
+     params.add(""false"");
+ 
+-    String level = System.getProperty(""root.log.level"");
+-    if (level != null) {
+-      params.add(""--logging="" + level);
+-    }
++    // String level = System.getProperty(""root.log.level"");
++    // if (level != null) {
++    //  params.add(""--logging="" + level);
++    // }
++    params.add(""--logging=TRACE"");
+ 
+     LOG.info(""Creating besu process with params {}"", params);
+     final ProcessBuilder processBuilder =","What's the advantage of doing it this way over, say, changing the `.circleci/config.yaml` to have `TRACE` as the `root.log.level`?",Is this intentional
+6051,"@@ -49,6 +49,15 @@ class ApiClient(object):
+             dataset_id (str): id of the dataset to query.
+         """"""
+ 
++    @abc.abstractmethod
++    def fetch_bigquery_iam_policy(self, project_number, dataset_id):
++        """"""Gets IAM policy if a bigquery dataset from gcp API call.
++
++        Args:
++            project_number (str): number of the project to query.
++            dataset_id (str): id of the dataset to query.
++        """"""
++
+     @abc.abstractmethod
+     def iter_bigquery_datasets(self, project_number):
+         """"""Iterate Datasets from GCP API.",typo: if -> of,I think this should
+6052,"@@ -270,7 +270,10 @@ func (templateContext) funcMarkdown(input interface{}) (string, error) {
+ 	buf.Reset()
+ 	defer bufPool.Put(buf)
+ 
+-	md.Convert([]byte(inputStr), buf)
++	err := md.Convert([]byte(inputStr), buf)
++	if err != nil {
++		return """", err
++	}
+ 
+ 	return buf.String(), nil
+ }",It'll be interesting to see who or what this breaks...,Why not return an error here?
+6053,"@@ -96,7 +96,7 @@ public class InternalSelenseTestBase extends SeleneseTestBase {
+       return;
+     }
+ 
+-    log.info(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
++    log.finest(""In dev mode. Copying required files in case we're using a WebDriver-backed Selenium"");
+ 
+     Path dir =
+       InProject.locate(""java/client/build/production/com/thoughtworks/selenium/webdriven"");",This change is incorrect: the current log level is correct.,Why is this being changed to 
+6054,"@@ -58,7 +58,7 @@ type clientFactory struct {
+ 
+ // NewClientFactory creates a new ClientFactory
+ func NewClientFactory() ClientFactory {
+-	logger := log.NewDefaultLogger()
++	logger := log.NewTestLogger()
+ 
+ 	return &clientFactory{
+ 		logger: logger,",There are few cases like this where default logger is used from CLI/db tools. I would copy `NewTestLogger` to `NewCLILogger` and use it everywhere in CLI. In future these two might be different.,Why this change?
+6055,"@@ -222,4 +222,16 @@ public abstract class AbstractAuthenticationToken implements Authentication,
+ 
+ 		return sb.toString();
+ 	}
++
++	protected static Integer extractKeyHash(String key) {
++		Object value = nullSafeValue(key);
++		return value.hashCode();
++	}
++
++	protected static Object nullSafeValue(Object value){
++		if(value == null || """".equals(value)) {
++			throw new IllegalArgumentException(""Cannot pass null or empty values to constructor"");
++		}
++		return value;
++	}
+ }","While it provides re-use, this method does not make sense in `AbstractAuthenticationToken` because it knows nothing of a hash key. Instead, we should move this to a private method within each subclass.",Why not use `Objects.hash()`?
+6056,"@@ -322,7 +322,7 @@ def extract_record_set(records, filters, sorting,
+         paginated = {}
+         for rule in pagination_rules:
+             values = apply_filters(filtered, rule)
+-            paginated.update(((x[id_field], x) for x in values))
++            paginated.update((id(x), x) for x in values)
+         paginated = paginated.values()
+     else:
+         paginated = filtered",index by memory address? I realize I don't understand why we don't just build a list :),Why is this necessary?
+6057,"@@ -7,6 +7,7 @@ import db.user
+ 
+ user_bp = Blueprint(""user"", __name__)
+ 
++
+ @user_bp.route(""/lastfmscraper/<user_id>.js"")
+ @crossdomain()
+ def lastfmscraper(user_id):","Not part of this commit, but we thought that this may not be a good place for this url, as it is in the `/user/` namespace (effectively preventing us having a user called `lastfmscraper`, however rare it may be)",This should be `user_b
+6058,"@@ -25,6 +25,7 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AspNet
+         internal const string HttpContextKey = ""__Datadog.Trace.ClrProfiler.Integrations.AspNetMvcIntegration"";
+ 
+         private const string OperationName = ""aspnet-mvc.request"";
++        private const string ChildActionOperationName = ""aspnet-mvc.request.child-action"";
+ 
+         private const string RouteCollectionRouteTypeName = ""System.Web.Mvc.Routing.RouteCollectionRoute"";
+ ",Does not appear to be used.,Should this be `aspnet
+6059,"@@ -0,0 +1,15 @@
++test_name ""C100546: bolt command run should execute command on remote hosts\
++           via ssh"" do
++  step ""execute `bolt command run` via SSH"" do
++    ssh_nodes = select_hosts(roles: ['ssh'])
++    nodes_csv = ssh_nodes.map(&:hostname).join(',')
++    command = 'hostname -f'
++    bolt_command = ""bolt command run --nodes #{nodes_csv} '#{command}'""
++    case bolt['platform']
++    when /windows/
++      execute_powershell_script_on(bolt, bolt_command)
++    else
++      on(bolt, bolt_command)
++    end
++  end
++end","I think this starts a new `powershell.exe` interpreter each time, which is pretty slow to run a single command. Can we just do `on(bolt, ""cmd /c #{bolt_command}"")`? /cc @Iristyle",I think it would be be
+6060,"@@ -1,14 +1,14 @@
+-<% if @purchaseable.collection? %>
++<% if @video_page.purchaseable.collection? %>
+   <% content_for :additional_header_links do %>
+-    <li class=""all-videos""><%= link_to 'All Videos', @purchase %></li>
++    <li class=""all-videos""><%= link_to 'All Videos', @video_page.purchase %></li>
+   <% end %>
+ <% end %>
+ 
+ <% content_for :subject_block do %>
+-  <h1><%= @purchaseable.name %></h1>
++  <h1><%= @video_page.purchaseable.name %></h1>
+   <h2 class=""tagline"">
+-    <% if @purchaseable.collection? %>
+-      <%= @video.title %>
++    <% if @video_page.purchaseable.collection? %>
++      <%= @video_page.video.title %>
+     <% else %>
+       Watch or download video
+     <% end %>",Can we add a `collection?` method to the `VideoPage` so we don't violate Law of Demeter here?,Shouldn't this be `@video_page.title`?
+6061,"@@ -1250,14 +1250,6 @@ public class ProjectManagerServlet extends LoginAbstractAzkabanServlet {
+       page.add(""errorMsg"", e.getMessage());
+     }
+ 
+-    final int numBytes = 1024;
+-
+-    // Really sucks if we do a lot of these because it'll eat up memory fast.
+-    // But it's expected that this won't be a heavily used thing. If it is,
+-    // then we'll revisit it to make it more stream friendly.
+-    final StringBuffer buffer = new StringBuffer(numBytes);
+-    page.add(""log"", buffer.toString());
+-
+     page.render();
+   }
+ ",Deleting unused code.,Why was this removed?
+6062,"@@ -1,6 +1,7 @@
+ import torch
+ 
+-from ..bbox import PseudoSampler, assign_and_sample, bbox2delta, build_assigner
++from ..bbox import assign_and_sample, bbox2delta, build_assigner
++from ..bbox.samplers.pseudo_sampler import PseudoSampler
+ from ..utils import multi_apply
+ 
+ ",`PseudoSampler` can also be imported from `..bbox`,I don't think we need this import anym
+6063,"@@ -19,6 +19,7 @@ package agreementtest
+ 
+ import (
+ 	""fmt""
++	""github.com/algorand/go-algorand/protocol""
+ 	""strconv""
+ 	""time""
+ ",Could you move this import to where the other `github.com/algorand/go-algorand` imports are?,"""github.com/go-gorand/goroutine"""
+6064,"@@ -655,7 +655,7 @@ class Conf(ConfClass):
+     # can, tls, http are not loaded by default
+     load_layers = ['bluetooth', 'bluetooth4LE', 'dhcp', 'dhcp6', 'dns',
+                    'dot11', 'dot15d4', 'eap', 'gprs', 'hsrp', 'inet',
+-                   'inet6', 'ipsec', 'ir', 'isakmp', 'l2', 'l2tp',
++                   'inet6', 'ipsec', 'ir', 'isakmp', 'l2', 'l2tp','l2f',
+                    'llmnr', 'lltd', 'mgcp', 'mobileip', 'netbios',
+                    'netflow', 'ntp', 'ppi', 'ppp', 'pptp', 'radius', 'rip',
+                    'rtp', 'sctp', 'sixlowpan', 'skinny', 'smb', 'smb2', 'snmp',","I'd rather not activate this protocol by default for now, unless there is a good reason for that.",missing space after comma
+6065,"@@ -19,11 +19,14 @@ import inspect
+ # pylint: disable=line-too-long
+ from google.cloud.forseti.common.util import logger
+ from google.cloud.forseti.common.util import string_formats
++from google.cloud.forseti.services.inventory.storage import DataAccess
++from google.cloud.forseti.services.scanner import dao as scanner_dao
+ from google.cloud.forseti.notifier.notifiers.base_notification import BaseNotification
+ from google.cloud.forseti.notifier.notifiers import cscc_notifier
++from google.cloud.forseti.notifier.notifiers import email_violations
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+-from google.cloud.forseti.services.inventory.storage import DataAccess
+-from google.cloud.forseti.services.scanner import dao as scanner_dao
++
++
+ # pylint: enable=line-too-long
+ 
+ ",Remove these 2 blank lines.,Why did you change this?
+6066,"@@ -606,6 +606,7 @@ func (pool *TxPool) validateTx(tx types.Transaction, local bool) error {
+ func (pool *TxPool) add(tx types.Transaction, local bool) (replaced bool, err error) {
+ 	// If the transaction is already known, discard it
+ 	hash := tx.Hash()
++	fmt.Printf(""aa: %x\n"", hash)
+ 	if pool.all.Get(hash) != nil {
+ 		log.Trace(""Discarding already known transaction"", ""hash"", hash)
+ 		knownTxMeter.Mark(1)",Want to remove this?,Is this leftover from deb
+6067,"@@ -2,6 +2,7 @@ package sql
+ 
+ import (
+ 	""github.com/jinzhu/gorm""
++	// gorm postgres dialect init registration
+ 	_ ""github.com/jinzhu/gorm/dialects/postgres""
+ )
+ ",is this a golint requirement? huh. mixed feelings :),// gorm dialect init regi
+6068,"@@ -33,6 +33,14 @@ public class BCryptPasswordEncoderTests {
+ 		String result = encoder.encode(""password"");
+ 		assertThat(result.equals(""password"")).isFalse();
+ 		assertThat(encoder.matches(""password"", result)).isTrue();
++		encoder = new BCryptPasswordEncoder(BCryptPasswordEncoder.BCRYPT_VERSION_2B);
++		result = encoder.encode(""password"");
++		assertThat(result.equals(""password"")).isFalse();
++		assertThat(encoder.matches(""password"", result)).isTrue();
++		encoder = new BCryptPasswordEncoder(BCryptPasswordEncoder.BCRYPT_VERSION_2Y);
++		result = encoder.encode(""password"");
++		assertThat(result.equals(""password"")).isFalse();
++		assertThat(encoder.matches(""password"", result)).isTrue();
+ 	}
+ 
+ 	@Test",Generally with these tests please split up these tests so that there is a different test for each method,I think it would be good to have a test for the BCryptPasswordEncoder with a different version.
+6069,"@@ -1394,16 +1394,16 @@ void nano::bootstrap_attempt::lazy_add (nano::block_hash const & hash_a)
+ 	}
+ }
+ 
+-void nano::bootstrap_attempt::lazy_pull_flush ()
++void nano::bootstrap_attempt::lazy_pull_flush (std::unique_lock<std::mutex> & lock_a)
+ {
+-	std::unique_lock<std::mutex> lock (lazy_mutex);
++	std::unique_lock<std::mutex> lazy_lock (lazy_mutex);
+ 	auto transaction (node->store.tx_begin_read ());
+ 	for (auto & pull_start : lazy_pulls)
+ 	{
+ 		// Recheck if block was already processed
+ 		if (lazy_blocks.find (pull_start) == lazy_blocks.end () && !node->store.block_exists (transaction, pull_start))
+ 		{
+-			add_pull (nano::pull_info (pull_start, pull_start, nano::block_hash (0), lazy_max_pull_blocks));
++			pulls.push_back (nano::pull_info (pull_start, pull_start, nano::block_hash (0), lazy_max_pull_blocks));
+ 		}
+ 	}
+ 	lazy_pulls.clear ();",Should something use the lock passed in?,`lock_a` is not used.
+6070,"@@ -101,7 +101,7 @@ class Docker(base.Base):
+ 
+     When attempting to utilize a container image with `systemd`_ as your init
+     system inside the container to simulate a real machine, make sure to set
+-    the ``privileged``, ``volume_mounts``, ``command``, and ``environment``
++    the ``privileged``, ``volumes``, ``command``, and ``environment``
+     values. An example using the ``centos:7`` image is below:
+ 
+     .. note:: Do note that running containers in privileged mode is considerably",Is this dependant on some version of Docker? Do we need to include both or `volumes` is deprecated (or just wrong!?)?,I think this should be `volumes_mounts`
+6071,"@@ -1306,7 +1306,7 @@ public class CollectionsHandler extends RequestHandlerBase implements Permission
+     try (ZkShardTerms zkShardTerms = new ZkShardTerms(collectionName, slice.getName(), zkController.getZkClient())) {
+       // if an active replica is the leader, then all is fine already
+       Replica leader = slice.getLeader();
+-      if (leader != null && leader.getState() == State.ACTIVE) {
++      if (leader != null && leader.getState() == State.ACTIVE && zkShardTerms.getHighestTerm() == zkShardTerms.getTerm(leader.getName())) {
+         throw new SolrException(ErrorCode.SERVER_ERROR,
+             ""The shard already has an active leader. Force leader is not applicable. State: "" + slice);
+       }","I know this is not new code, but should we change `leader.getState() == State.ACTIVE` to `leader.isActive(liveNodes)`?",I think this should be `zkShardTerms.getHighestTerm() < zkShardTerms.getTerm(leader.getName())`
+6072,"@@ -105,7 +105,7 @@ public class JavaRuleViolation extends ParametricRuleViolation<JavaNode> {
+     private void setClassNameFrom(JavaNode node) {
+         String qualifiedName = null;
+ 
+-        if (node.getScope() instanceof ClassScope) {
++        if (node instanceof AbstractAnyTypeDeclaration && node.getScope() instanceof ClassScope) {
+             qualifiedName = ((ClassScope) node.getScope()).getClassName();
+         }
+ ",Why not use ASTAnyTypeDeclaration? AbstractAnyTypeDeclaration is deprecated,Why do we need this change?
+6073,"@@ -119,3 +119,5 @@ from .tools.command import (
+     version_add,
+     version_list,
+ )
++
++from .tools.util import save","A blank line at the very end of each file should eliminate the ""No EOF"" warning we see above",from .tools.util import (
+6074,"@@ -818,15 +818,12 @@ func (h *Handler) SignalWithStartWorkflowExecution(ctx context.Context, request
+ 
+ 		// Two simultaneous SignalWithStart requests might try to start a workflow at the same time.
+ 		// This can result in one of the requests failing with one of two possible errors:
+-		//    1) If it is a brand new WF ID, one of the requests can fail with WorkflowExecutionAlreadyStartedError
+-		//       (createMode is persistence.CreateWorkflowModeBrandNew)
+-		//    2) If it an already existing WF ID, one of the requests can fail with a CurrentWorkflowConditionFailedError
+-		//       (createMode is persisetence.CreateWorkflowModeWorkflowIDReuse)
++		//    CurrentWorkflowConditionFailedError || WorkflowConditionFailedError
+ 		// If either error occurs, just go ahead and retry. It should succeed on the subsequent attempt.
+ 		// For simplicity, we keep trying unless the context finishes or we get an error that is not one of the
+ 		// two mentioned above.
+-		_, isExecutionAlreadyStartedErr := err2.(*persistence.WorkflowExecutionAlreadyStartedError)
+-		_, isWorkflowConditionFailedErr := err2.(*persistence.CurrentWorkflowConditionFailedError)
++		_, isCurrentWorkflowConditionFailedErr := err2.(*persistence.CurrentWorkflowConditionFailedError)
++		_, isWorkflowConditionFailedErr := err2.(*persistence.WorkflowConditionFailedError)
+ 
+ 		isContextDone := false
+ 		select {",These would both be more robust with `errors.As` so that we could safely chain errors.,Why do we need this change?
+6075,"@@ -299,9 +299,9 @@ SwiftArrayBufferHandler::CreateBufferHandler(ValueObject &valobj) {
+ 
+   // For now we have to keep the old mangled name since the Objc->Swift bindings
+   // that are in Foundation don't get the new mangling.
+-  if (valobj_typename.startswith(SwiftLanguageRuntime::GetCurrentMangledName(""_TtCs23_ContiguousArrayStorage""))
+-      || valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"")
+-      || valobj_typename.startswith(""Swift._ContiguousArrayStorage"")) {
++  if (valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"") ||
++      valobj_typename.startswith(""_TtCs23_ContiguousArrayStorage"") ||
++      valobj_typename.startswith(""Swift._ContiguousArrayStorage"")) {
+     CompilerType anyobject_type =
+         valobj.GetTargetSP()->GetScratchClangASTContext()->GetBasicType(
+             lldb::eBasicTypeObjCID);",This is checking the same condition twice?,Why did you remove the curr
+6076,"@@ -157,8 +157,16 @@ void lbann_comm::allreduce(AbsDistMat& m,
+ #ifdef LBANN_HAS_GPU
+   if (m.GetLocalDevice() == El::Device::GPU) {
+ #ifdef AL_HAS_NCCL
+-    // Force GPU matrices to use NCCL.
++    // We require NCCL for GPU matrices.
+     t = std::type_index(typeid(::Al::NCCLBackend));
++    // If available, use the MPI-CUDA backend for small matrices.
++#ifdef AL_HAS_MPI_CUDA
++    // Based on runs on Pascal and Ray.
++    if ((El::mpi::Size(c) > 4 && local_size <= 8192) ||
++        (El::mpi::Size(c) >= 16 && local_size <= 32768)) {
++      t = std::type_index(typeid(::Al::MPICUDABackend));
++    }
++#endif  // AL_HAS_MPI_CUDA
+ #else
+     throw lbann_exception(""Allreduce on GPU matrix requires NCCL support in""
+                           "" Aluminum"");","Aren't we able to handle the case where we have MPI-CUDA without NCCL, even if it's suboptimal?","I don't think this is the right way to check for MPI-CUDA. If the backend is MPI-CUDA, then we need to use the MPI-CUDA backend."
+6077,"@@ -37,6 +37,12 @@ Copyright (C) 2001-2016 EQEMu Development Team (http://eqemulator.net)
+ 
+ extern QueryServ* QServ;
+ 
++namespace detail
++{
++	static const uint32 PhantomStatId = 999999;
++}
++
++
+ void Mob::TemporaryPets(uint16 spell_id, Mob *targ, const char *name_override, uint32 duration_override, bool followme, bool sticktarg, uint16 *eye_id) {
+ 
+ 	//It might not be a bad idea to put these into the database, eventually..",Wouldn't we want to namespace this `AA` or something similar,Why is this needed?
+6078,"@@ -395,7 +395,13 @@ func newSession(opts Options, envCfg envConfig, cfgs ...*aws.Config) (*Session,
+ 	// Load additional config from file(s)
+ 	sharedCfg, err := loadSharedConfig(envCfg.Profile, cfgFiles, envCfg.EnableSharedConfig)
+ 	if err != nil {
+-		if _, ok := err.(SharedConfigProfileNotExistsError); !ok {
++		if len(envCfg.Profile) == 0 && !envCfg.EnableSharedConfig && envCfg.Creds.HasKeys() {
++			// Special case where the user has not explicitly specified an AWS_PROFILE,
++			// or session.Options.profile, shared config is not enabled, and the
++			// environment has credentials, allow the shared config file to fail to
++			// load since the user has already provided credentials, and nothing else
++			// is required to be read file. Github(aws/aws-sdk-go#2455)
++		} else if _, ok := err.(SharedConfigProfileNotExistsError); !ok {
+ 			return nil, err
+ 		}
+ 	}","This probably should look beyond envConfig, and include `aws.Config.Credentials` as well.","I don't think this is the right place for this check. If the user has explicitly specified an AWS_PROFILE, and the shared config"
+6079,"@@ -110,6 +110,7 @@ namespace Nethermind.TxPool
+             _filterPipeline.Add(new TooFarNonceFilter(txPoolConfig, _accounts, _transactions, _logger));
+             _filterPipeline.Add(new TooExpensiveTxFilter(_headInfo, _accounts, _logger));
+             _filterPipeline.Add(new FeeToLowFilter(_headInfo, _accounts, _transactions, _logger));
++            _filterPipeline.Add(new NotEnoughBalanceFilter(_headInfo, _accounts, _logger));
+             _filterPipeline.Add(new ReusedOwnNonceTxFilter(_accounts, _nonces, _logger));
+             if (incomingTxFilter is not null)
+             {",How does this filter differ from TooExpensiveTxFilter?,I think this should be `NotEnoughBalanceTxFilter`
+6080,"@@ -217,6 +217,17 @@ public class Project {
+     return users;
+   }
+ 
++  public List<String> getGroupsWithPermission(final Type type) {
++    final ArrayList<String> groups = new ArrayList<>();
++    for (final Map.Entry<String, Permission> entry : this.groupPermissionMap.entrySet()) {
++      final Permission perm = entry.getValue();
++      if (perm.isPermissionSet(type)) {
++        groups.add(entry.getKey());
++      }
++    }
++    return groups;
++  }
++
+   public List<Pair<String, Permission>> getUserPermissions() {
+     final ArrayList<Pair<String, Permission>> permissions =
+         new ArrayList<>();","Use "" List<String>"" instead of ArrayList<String> in declaration.",nit: `return Collections.unmodifiableList(this.groupPermissionMap.values());`
+6081,"@@ -93,8 +93,10 @@ class ObjectStore(six.with_metaclass(ABCMeta)):
+         return self.set_object(obj, context, runtime_type, paths)
+ 
+     def get_value(self, context, runtime_type, paths):
+-        if runtime_type in self.TYPE_REGISTRY:
+-            return self.TYPE_REGISTRY[runtime_type].get_object(self, context, runtime_type, paths)
++        if runtime_type.name is not None and runtime_type.name in self.TYPE_REGISTRY:
++            return self.TYPE_REGISTRY[runtime_type.name].get_object(
++                self, context, runtime_type, paths
++            )
+         return self.get_object(context, runtime_type, paths)
+ 
+ ",we might consider hard throwing when name is None since that is explicitly not working right now and then linking to issue in the exception error message,I don't think this is the right place to do this check. If the runtime_type h
+6082,"@@ -1,13 +1,19 @@
+ 
+ package edu.harvard.iq.dataverse;
+ 
++import edu.harvard.iq.dataverse.util.BundleUtil;
+ import java.io.Serializable;
++import java.util.MissingResourceException;
+ import javax.persistence.Entity;
+ import javax.persistence.GeneratedValue;
+ import javax.persistence.GenerationType;
+ import javax.persistence.Id;
+ import javax.persistence.JoinColumn;
+ import javax.persistence.ManyToOne;
++import javax.persistence.NamedNativeQueries;
++import javax.persistence.NamedNativeQuery;
++import javax.persistence.NamedQueries;
++import javax.persistence.NamedQuery;
+ 
+ /**
+  *","Just noticed this - why ""like"" and not straight ""=""",why is this needed?
+6083,"@@ -1,15 +1,16 @@
+ require 'spec_helper'
+ 
+ describe Travis::Build::Data::Env do
+-  let(:data) { stub('data', pull_request: '100', config: { env: 'FOO=foo' }, build: {}, job: {}, repository: {}) }
++  let(:data) { stub('data', pull_request: '100', config: { env: 'FOO=foo' }, build: { id: '1', number: '1' }, job: { id: '1', number: '1.1', branch: 'master', commit: '313f61b', commit_range: '313f61b..313f61a' }, repository: { slug: 'travis-ci/travis-ci' }) }
+   let(:env)  { described_class.new(data) }
+ 
+   it 'vars respond to :key' do
+     env.vars.first.should respond_to(:key)
+   end
+ 
+-  it 'includes travis env vars' do
+-    env.vars.first.key.should =~ /^TRAVIS_/
++  it 'includes all travis env vars' do
++    travis_vars = env.vars.select { |v| v.key =~ /^TRAVIS_/ && v.value && v.value.length > 0 }
++    travis_vars.length.should == 11
+   end
+ 
+   it 'includes config env vars' do","is this a new test? if yes, isn't it better to check for each env var is present, and the value, instead of a count?","I'm not sure if this is the best way to test this, but I'm not sure how to te"
+6084,"@@ -160,10 +160,10 @@ public class MicroserviceVersions {
+       setInstances(pulledInstances, rev);
+       validated = true;
+     } catch (Throwable e) {
+-      LOGGER.error(""Failed to setInstances, appId={}, microserviceName={}."",
+-          getAppId(),
+-          getMicroserviceName(),
+-          e);
++      LOGGER.error(String.format(""Failed to setInstances, AppId=%s, MicroserviceName=%s."",
++              getAppId(),
++              getMicroserviceName()),
++              e);
+     }
+   }
+ ","when will lost exception? by my test, never happened.",Why do we need the `String.format`?
+6085,"@@ -147,7 +147,8 @@ class BrowserPage(QWebPage):
+                 title=""Open external application for {}-link?"".format(scheme),
+                 text=""URL: <b>{}</b>"".format(
+                     html.escape(url.toDisplayString())),
+-                yes_action=functools.partial(QDesktopServices.openUrl, url))
++                yes_action=functools.partial(QDesktopServices.openUrl, url),
++                url=urlstr)
+             return True
+         elif (info.domain, info.error) in ignored_errors:
+             log.webview.debug(""Ignored error on {}: {} (error domain: {}, """,You should re-stringify it here with `QUrl.FullyEncoded`.,I think this should be `url=url.toD
+6086,"@@ -128,9 +128,9 @@ func Wrap(ctx context.Context, topic Topic, msg []byte, recipient *ecdsa.PublicK
+ 	return mine(ctx, odd, f)
+ }
+ 
+-// Unwrap takes a chunk, a topic and a private key, and tries to decrypt the payload
++// Unwrap takes a private key, a chunk, an array of possible topics and tries to decrypt the payload
+ // using the private key, the prepended ephemeral public key for el-Gamal using the topic as salt
+-func Unwrap(ctx context.Context, key *ecdsa.PrivateKey, chunk swarm.Chunk, topics []Topic) (topic Topic, msg []byte, err error) {
++func Unwrap(key *ecdsa.PrivateKey, chunk swarm.Chunk, quit chan struct{}, topics []Topic) (topic Topic, msg []byte, err error) {
+ 	chunkData := chunk.Data()
+ 	pubkey, err := extractPublicKey(chunkData)
+ 	if err != nil {",i'm not sure why the quit channel is needed in this context,I don't think we need the `quit` ch
+6087,"@@ -64,13 +64,16 @@ func MakeIngressDeployment(args IngressArgs) *appsv1.Deployment {
+ 	}
+ 	container.Resources = corev1.ResourceRequirements{
+ 		Limits: corev1.ResourceList{
+-			corev1.ResourceMemory: resource.MustParse(""1000Mi""),
++			corev1.ResourceMemory: resource.MustParse(args.MemoryLimit),
+ 		},
+ 		Requests: corev1.ResourceList{
+-			corev1.ResourceMemory: resource.MustParse(""500Mi""),
+-			corev1.ResourceCPU:    resource.MustParse(""1000m""),
++			corev1.ResourceMemory: resource.MustParse(args.MemoryRequest),
++			corev1.ResourceCPU:    resource.MustParse(args.CPURequest),
+ 		},
+ 	}
++	if len(args.CPULimit) > 0 {
++		container.Resources.Limits[corev1.ResourceCPU] = resource.MustParse(args.CPULimit)
++	}
+ 	return deploymentTemplate(args.Args, []corev1.Container{container})
+ }
+ ","When `args.MemoryLimit` is empty, will `MustParse` panic?",Shouldn't this be `if args.CPUReque
+6088,"@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) {
+ 	r.dirtyIfaces.Add(ifaceName)
+ }
+ 
++func (r *RouteTable) QueueResync() {
++	r.logCxt.Info(""Queueing a resync."")
++	r.inSync = false
++}
++
+ func (r *RouteTable) Apply() error {
+ 	if !r.inSync {
+ 		links, err := r.dataplane.LinkList()",How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.,Why do we need this?
+6089,"@@ -23,6 +23,7 @@ import (
+ )
+ 
+ type nonceWithTTL struct {
++	idx      int
+ 	nonce    uint64
+ 	deadline time.Time
+ }","I add a `idx` property, and it is only use for benchmark `heap.Remove`, is it acceptable?",why do we need this?
+6090,"@@ -1,6 +1,6 @@
+ # -*- coding: UTF-8 -*-
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2018 NV Access Limited, Babbage B.V., Davy Kager
++#Copyright (C) 2006-2019tNV Access Limited, Babbage B.V., Davy Kager, Derek Riemer
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",daemonic t got inserted.,Why are you changing
+6091,"@@ -532,7 +532,8 @@ public class DefaultBlockchain implements MutableBlockchain {
+       if (!genesisHash.get().equals(genesisBlock.getHash())) {
+         throw new InvalidConfigurationException(
+             ""Supplied genesis block does not match stored chain data.\n""
+-                + ""Please specify a different data directory with --data-path or specify the original genesis file with --genesis-file."");
++                + ""Please specify a different data directory with --data-path or specify the""
++                + "" original genesis file with --genesis-file."");
+       }
+     }
+   }",This edit is non-essential.,Why is this change n
+6092,"@@ -14,6 +14,14 @@ import {
+ 
+ const isWeakMapSupported = typeof WeakMap == 'function';
+ 
++Object.setPrototypeOf =
++	Object.setPrototypeOf ||
++	function(obj, proto) {
++		// eslint-disable-next-line
++		obj.__proto__ = proto;
++		return obj;
++	};
++
+ function getClosestDomNodeParent(parent) {
+ 	if (!parent) return {};
+ 	if (typeof parent.type == 'function') {",Might be safer to ponyfill this?,Why do we need this?
+6093,"@@ -57,18 +57,11 @@ func Create(dir string) (*Local, error) {
+ 	}
+ 
+ 	// test if config file already exists
+-	_, err := os.Lstat(backend.Paths.Config)
++	_, err := os.Lstat(filepath.Join(dir, backend.Paths.Config))
+ 	if err == nil {
+ 		return nil, errors.New(""config file already exists"")
+ 	}
+ 
+-	// test if directories already exist
+-	for _, d := range dirs[1:] {
+-		if _, err := os.Stat(d); err == nil {
+-			return nil, fmt.Errorf(""dir %s already exists"", d)
+-		}
+-	}
+-
+ 	// create paths for data, refs and temp
+ 	for _, d := range dirs {
+ 		err := os.MkdirAll(d, backend.Modes.Dir)",why was this join not necessary before?,Why was this removed
+6094,"@@ -163,6 +163,17 @@ public class TestExitableDirectoryReader extends LuceneTestCase {
+     searcher.search(query, 10);
+     reader.close();
+ 
++    // Set a fairly high timeout value (infinite) and expect the query to complete in that time frame.
++    // Not checking the validity of the result, but checking the sampling kicks in to reduce the number of timeout check
++    CountingQueryTimeout queryTimeout = new CountingQueryTimeout();
++    directoryReader = DirectoryReader.open(directory);
++    exitableDirectoryReader = new ExitableDirectoryReader(directoryReader, queryTimeout);
++    reader = new TestReader(getOnlyLeafReader(exitableDirectoryReader));
++    searcher = new IndexSearcher(reader);
++    searcher.search(query, 10);
++    reader.close();
++    assertEquals(3, queryTimeout.getShouldExitCallCount());
++
+     directory.close();
+   }
+ ","Here we compare to the expected call count 3. Because 3 TermsEnum are created: it is a PrefixQuery and there is one TermsEnum created for AutomatonQuery.intersect() (the next call timeout check is skipped once), then 2 TermsEnum created for the 2 matching terms ""one"" and ""ones""). Would it be clearer to have a separate test method? We could index more docs, for example 50 with a prefix-generated term (e.g. ""term""+increment). There would be a PrefixQuery for ""term"", the same test code, and we would test the TIMEOUT_CHECK_SAMPLING: - 1 TermsEnum for Automaton.intersect(), and the next calls would be sampled (50/TIMEOUT_CHECK_SAMPLING=3) => call count +4 - 1 TermsEnum for each enumerated term => call count +50 We could verify call count = 54 (instead of 101 without sampling)",I think it would be 
+6095,"@@ -28,6 +28,9 @@ module Bolt
+       when 'file'
+         { flags: ACTION_OPTS + %w[tmpdir],
+           banner: FILE_HELP }
++      when 'inventory'
++        { flags: OPTIONS[:inventory] + OPTIONS[:global] + %w[format inventoryfile boltdir configfile],
++          banner: INVENTORY_HELP }
+       when 'plan'
+         case action
+         when 'convert'",Add `--format` as an option. Does it make sense to have all display options available? Also need to add `--inventoryfile` and possibly the global_config_options.,I don't think you ne
+6096,"@@ -53,5 +53,10 @@ namespace OpenTelemetry.Instrumentation.AspNetCore
+         /// The type of this object depends on the event, which is given by the above parameter.</para>
+         /// </remarks>
+         public Action<Activity, string, object> Enrich { get; set; }
++
++        /// <summary>
++        /// Gets or sets a value indicating whether the exception will be recorded or not.
++        /// </summary>
++        public bool RecordException { get; set; }
+     }
+ }","Any thoughts on making this false by default? My suggestion is make this opt-in. Storing exception is somewhat expensive, so lets do this only if users opt-in",Why is this public?
+6097,"@@ -88,7 +88,7 @@ public final class HttpCall<V> extends Call.Base<V> {
+       } else {
+         try {
+           callback.onSuccess(parseResponse(response, bodyConverter));
+-        } catch (IOException e) {
++        } catch (Throwable e) {
+           callback.onError(e);
+         }
+       }","usually I do either ` IOException|RuntimeException` or if doing Throwable, use propagateIfFatal",Why is this change 
+6098,"@@ -24,10 +24,14 @@ class Overlayable(object):
+ 
+     def __mul__(self, other):
+         if type(other).__name__ == 'DynamicMap':
+-            from ..util import Dynamic
+-            def dynamic_mul(element):
++            from .spaces import Callable
++            def dynamic_mul(*args, **kwargs):
++                element = other[args]
+                 return self * element
+-            return Dynamic(other, operation=dynamic_mul)
++            callback = Callable(callable_function=dynamic_mul,
++                                inputs=[self, other])
++            return other.clone(shared_data=False, callback=callback,
++                               streams=[])
+         if isinstance(other, UniformNdMapping) and not isinstance(other, CompositeOverlay):
+             items = [(k, self * v) for (k, v) in other.items()]
+             return other.clone(items)","Wondering whether it should be `self.clone`, or `other.clone` or maybe a new `DynamicMap` declaration entirely. I see this is in the condition where `other` is a `DynamicMap`but is this definitely right in terms of `kdims`? I need to think about it more...",Why is this necessa
+6099,"@@ -34,7 +34,7 @@ public interface SolrInfoBean {
+    * Category of Solr component.
+    */
+   enum Category { CONTAINER, ADMIN, CORE, QUERY, UPDATE, CACHE, HIGHLIGHTER, QUERYPARSER, SPELLCHECKER,
+-    SEARCHER, REPLICATION, TLOG, INDEX, DIRECTORY, HTTP, OTHER }
++    SEARCHER, REPLICATION, TLOG, INDEX, DIRECTORY, HTTP, SECURITY, OTHER }
+ 
+   /**
+    * Top-level group of beans or metrics for a subsystem.",I chose a new category because over time I'd like to add metrics also for Authorization plugins and Auditlog plugins (all components registered in security.json). An alternative could have been `CONTAINER` I guess?,Why do we need to a
+6100,"@@ -22,6 +22,11 @@ var (
+ 	ErrMinusAmount = errors.New(""invalid amount that is minus"")
+ )
+ 
++const (
++	// IotxAddressLength defines length of IoTeX address
++	IotxAddressLength = 41
++)
++
+ // ValidateAddress validates IoTeX address
+ func ValidateAddress(addr string) error {
+ 	if _, err := address.FromString(addr); err != nil {",IoAddrLen Golang prefers short variable names,Why is this a constant?
+6101,"@@ -34,7 +34,7 @@ class MediaAdmin extends Admin
+      */
+     public function createQuery($context = 'list')
+     {
+-        $query = $this->getModelManager()->createQuery($this->getClass(), '', $this->root);
++        $query = $this->getModelManager()->createQuery($this->getClass(), 'a', $this->root);
+ 
+         foreach ($this->extensions as $extension) {
+             $extension->configureQuery($this, $query, $context);",PHPCR-ODM does not allow blank aliases..,Why did you change this
+6102,"@@ -358,7 +358,11 @@ public class HttpSolrClient extends BaseHttpSolrClient {
+     if (parser == null) {
+       parser = this.parser;
+     }
+-    
++
++    Header[] contextHeaders = new Header[2];
++    contextHeaders[0] = new BasicHeader(CommonParams.SOLR_REQUEST_CONTEXT_PARAM, getContext().toString());
++    contextHeaders[1] = new BasicHeader(CommonParams.SOLR_REQUEST_TYPE_PARAM, request.getRequestType());
++
+     // The parser 'wt=' and 'version=' params are used instead of the original
+     // params
+     ModifiableSolrParams wparams = new ModifiableSolrParams(params);",This seems trivial to forge. Can we tie this into the authentication code paths somehow so that we can really trust that the request is coming from a server instead of just some application claiming to be a server?,Why do we need this cha
+6103,"@@ -42,6 +42,7 @@
+ //@HEADER
+ */
+ 
++#include <Kokkos_Core.hpp>
+ #include <Kokkos_Concepts.hpp>
+ #include <SYCL/Kokkos_SYCL_Instance.hpp>
+ #include <KokkosCore_Config_DeclareBackend.hpp>",Why are you including `<Kokkos_Core.hpp>`?,Why is this header need
+6104,"@@ -323,7 +323,7 @@ int api_v1_health(struct flb_hs *hs)
+ 
+     counter_init(hs);
+     /* Create a message queue */
+-    hs->qid_metrics = mk_mq_create(hs->ctx, ""/health"",
++    hs->qid_health = mk_mq_create(hs->ctx, ""/health"",
+                                    cb_mq_health, NULL);
+ 
+     mk_vhost_handler(hs->ctx, hs->vid, ""/api/v1/health"", cb_health, hs);","So previously health check was consuming from the normal metrics queue, now we duplicate the data to a new queue? I feel like there should be more changes to ensure the health check handler reads from the new queue? @DrewZhang13",Why do we need to change this?
+6105,"@@ -1470,6 +1470,7 @@ func isValidRuleForXDP(rule *proto.Rule) bool {
+ 		len(rule.DstPorts) == 0 &&
+ 		len(rule.DstNamedPortIpSetIds) == 0 &&
+ 		len(rule.DstIpSetIds) == 0 &&
++		len(rule.DstIpPortSetIds) == 0 &&
+ 		len(rule.NotDstNet) == 0 &&
+ 		len(rule.NotDstPorts) == 0 &&
+ 		len(rule.NotDstIpSetIds) == 0 &&","Yep, looks right; your new selector _should_ disqualify the rule from being XDP accelerated.",Why is this change needed?
+6106,"@@ -0,0 +1,12 @@
++// Copyright (c) .NET Foundation. All rights reserved.
++// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.
++
++using System;
++
++namespace Microsoft.AspNetCore.Connections.Features
++{
++    public interface IConnectionHeartbeatTickFeature
++    {
++        void OnHeartbeat(Action<DateTimeOffset, object> action, object state);
++    }
++}",cc @anurse This exists now. Kestrel currently passes the current time to all callbacks as an optimization. Just an FYI.,Why do we need this interface?
+6107,"@@ -126,7 +126,7 @@ class Entry(MSONable, metaclass=ABCMeta):
+         elif mode == ""formula_unit"":
+             factor = self.composition.get_reduced_composition_and_factor()[1]
+         else:
+-            raise ValueError(f""{mode=} is not an allowed option for normalization"")
++            raise ValueError(f""{mode} is not an allowed option for normalization"")
+ 
+         return factor
+ ",remove 3.8+ f-string format to allow use in google colab,Why did you remove the `=`?
+6108,"@@ -196,6 +196,10 @@ save_xmm(dcontext_t *dcontext, sigframe_rt_t *frame)
+     int i;
+     sigcontext_t *sc = get_sigcontext_from_rt_frame(frame);
+     kernel_xstate_t *xstate = (kernel_xstate_t *)sc->fpstate;
++    /* For pending signals, the alignment of xstate ultimately depends on the alignment of
++     * the special allocator's blocks. Ths is fragile, and assertions here and at
++     * initialization are providing some coverage for this.
++     */
+     if (!preserve_xmm_caller_saved())
+         return;
+     if (xstate_has_extra_fields) {",Should we assert that xstate is aligned here?,"I don't think this is the right place to put this check. It should be at the beginning of the function, not at the end of the function."
+6109,"@@ -49,8 +49,8 @@ import com.tdunning.math.stats.AVLTreeDigest;
+ //   TestCloudJSONFacetJoinDomain for random field faceting tests with domain modifications
+ //   TestJsonFacetRefinement for refinement tests
+ 
+-@LuceneTestCase.SuppressCodecs({""Lucene3x"",""Lucene40"",""Lucene41"",""Lucene42"",""Lucene45"",""Appending""})
+-public class TestJsonFacets extends SolrTestCaseHS {
++@LuceneTestCase.SuppressCodecs({""Lucene3x"",""Lucene40"",""Lucene41"",""FST50"",""Direct"",""Lucene42"",""Lucene45"",""Appending"",""BlockTreeOrds"",""FSTOrd50""})
++public class  TestJsonFacets extends SolrTestCaseHS {
+   
+   private static SolrInstances servers;  // for distributed testing
+   private static int origTableSize;",any particular reason for suppressing this change?,I don't think we need the extra space here.
+6110,"@@ -67,6 +67,17 @@ public abstract class MainnetDifficultyCalculators {
+         return periodCount > 1 ? adjustForPeriod(periodCount, difficulty) : difficulty;
+       };
+ 
++  public static DifficultyCalculator<Void> DIFFICULTY_BOMB_REMOVED =
++      (time, parent, protocolContext) -> {
++        final BigInteger parentDifficulty = difficulty(parent.getDifficulty());
++        final BigInteger difficulty =
++            ensureMinimumDifficulty(
++                BigInteger.valueOf(Math.max(1 - (time - parent.getTimestamp()) / 10, -99L))
++                    .multiply(parentDifficulty.divide(DIFFICULTY_BOUND_DIVISOR))
++                    .add(parentDifficulty));
++        return difficulty;
++      };
++
+   public static DifficultyCalculator<Void> BYZANTIUM =
+       (time, parent, protocolContext) ->
+           calculateByzantiumDifficulty(time, parent, BYZANTIUM_FAKE_BLOCK_OFFSET);","Hot take: could this instead become `NO_DIFFICULTY_BOMB` and have` HOMESTEAD` wrap it? So this comes first then homestad with the bomb adjustment, making no difficulty the base case?","I think this should be `BigInteger.valueOf(Math.max(1 - (time - parent.getTimestamp()) / 10, -99L))`"
+6111,"@@ -16,6 +16,19 @@
+ // variables read from a blob.Bucket.
+ // Use NewVariable to construct a *runtimevar.Variable.
+ //
++// URLs
++//
++// For runtimevar.OpenVariable URLs, blobvar registers for the scheme ""blob"".
++// The host+path is used as the blob key. blobvar supports the following URL
++// parameters:
++//   - bucket: The URL to be passed to blob.OpenBucket (required).
++//       blob.OpenBucket will be called once per unique bucket URL.
++//   - decoder: The decoder to use. Defaults to runtimevar.BytesDecoder.
++//       See runtimevar.DecoderByName for supported values.
++//   - wait: The poll interval; supported values are from time.ParseDuration.
++//       Defaults to 30s.
++// Example URL: ""blob://myvar.txt?bucket=fileblob:///foo/bar&decoder=string"".
++//
+ // As
+ //
+ // blobvar exposes the following types for As:","I suggest to use a scheme like ""blobvar"". ""blob"" would potentially collide if we have another API that use the blob package as a driver.",I think this should be `runtimevar.BytesDecoder`.
+6112,"@@ -116,6 +116,14 @@ def get_listens(user_name):
+     for listen in listens:
+         listen_data.append(listen.to_api())
+ 
++    latest_listen = db_conn.fetch_listens(
++        user_name,
++        limit=1,
++        to_ts=max_ts,
++    )
++    latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 else 0
++
++
+     if min_ts:
+         listen_data = listen_data[::-1]
+ ","This assumes that the user has at least one listen, it should have a guard around it, because this won't always be the case",I think this should be `latest_listen_ts = latest_listen.ts_since_epoch`
+6113,"@@ -365,7 +365,7 @@ namespace pwiz.Skyline.Properties {
+         }
+         
+         /// <summary>
+-        ///   Looks up a localized string similar to An error occurred while trying to display the document &apos;{0}&apos;. 
++        ///   Looks up a localized string similar to An error occurred while trying to display the document &apos;{0}&apos;. 
+         ///There might be something wrong with default web browser on this computer..
+         /// </summary>
+         public static string ActionTutorial_ExtractTutorial_An_error_occurred_while_trying_to_display_the_document___0____ {",Seems like a lot of unintended changes. Are your line break settings causing these?,Why did you change this?
+6114,"@@ -231,9 +231,10 @@ def generate_r_docs(app):
+         r-jsonlite=1.5=r351h96ca727_0 \
+         r-matrix=1.2_14=r351h96ca727_0 \
+         r-testthat=2.0.0=r351h29659fb_0 \
+-        cmake=3.14.0=h52cb24c_0
++        cmake=3.14.0=h52cb24c_0 \
++        ca-certificates=2019.11.27=0
+     /home/docs/.conda/bin/conda install -q -y -n r_env -c conda-forge \
+-        r-pkgdown=1.3.0=r351h6115d3f_1000 \
++        r-pkgdown=1.3.0=r35h6115d3f_1001 \
+         r-roxygen2=6.1.1=r35h0357c0b_1001
+     source /home/docs/.conda/bin/activate r_env
+     export TAR=/bin/tar",@StrikerRUS what if we just removed build numbers and did `r-pkgdown=1.3.0`? Won't we have to fix this again if the RTD build machines change?,why did you change this?
+6115,"@@ -1,6 +1,5 @@
+-# $Id$
+ #
+-#  Copyright (C) 2003-2006  Rational Discovery LLC
++#  Copyright (C) 2002-2006  greg Landrum and Rational Discovery LLC
+ #
+ #   @@ All Rights Reserved @@
+ #  This file is part of the RDKit.","I'm not arguing with it, but how did you decide to make this change?",Why did you remove the copyright?
+6116,"@@ -1,7 +1,7 @@
+ # -*- coding: utf-8 -*-
+ ##
+ ## This file is part of Invenio.
+-## Copyright (C) 2011, 2012 CERN.
++## Copyright (C) 2011, 2012, 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","1: D400 First line should end with '.', not 'd' 4: I102 copyright year is outdated, expected 2014 but got 2012 25:29: E126 continuation line over-indented for hanging indent 31: D103 Docstring missing 40: D103 Docstring missing 57: D103 Docstring missing 68: D103 Docstring missing 101: D103 Docstring missing 115: D401 First line should be imperative: 'Call', not 'Calls' 115: D400 First line should end with '.', not 't' 134: D400 First line should end with '.', not 'e' 134: D205 Blank line missing between one-line summary and description",Why do we need to change this?
+6117,"@@ -42,6 +42,14 @@ type ACMEIssuer struct {
+ 	// Only ACME v2 endpoints (i.e. RFC 8555) are supported.
+ 	Server string `json:""server""`
+ 
++	// PreferredChain is the chain to use if the ACME server outputs multiple.
++	// PreferredChain is no guarantee that this one gets delivered by the ACME
++	// endpoint.
++	// For example, for Let's Encrypt's DST crosssign you would use:
++	// ""DST Root CA X3"" or ""ISRG Root X1"" for the newer Let's Encrypt root CA.
++	// +optional
++	PreferredChain string `json:""preferredChain""`
++
+ 	// Enables or disables validation of the ACME server TLS certificate.
+ 	// If true, requests to the ACME server will not have their TLS certificate
+ 	// validated (i.e. insecure connections will be allowed).","Explain that this must match the `CommonName` of the first (or is it last?) certificate in the chain, where the first certificate is the chain root CA and the last certificate is the leaf certificate.",I'm not sure if this is the be
+6118,"@@ -16,7 +16,7 @@ type Config struct {
+ 	Storage           *storageConfig     `yaml:""storage"" required:""true""`
+ 	Blockchain        *blockchain.Config `yaml:""blockchain""`
+ 	MetricsListenAddr string             `yaml:""metrics_listen_addr"" default:""127.0.0.1:14004""`
+-	ColdStart         *ColdStartConfig   `yaml:""cold_start""`
++	ColdStart         bool               `yaml:""cold_start""`
+ 	NumWorkers        int                `yaml:""num_workers"" default:""64""`
+ }
+ ",do we really need this behavour to be configurable?,Why did you remove this?
+6119,"@@ -3,7 +3,7 @@
+  */
+ 
+ var MongooseArray = require('./array')
+-  , ObjectId = require('../drivers/node-mongodb-native/objectid')
++  , ObjectId = require('./objectid')
+   , ObjectIdSchema = require('../schema/objectid')
+   , utils = require('../utils')
+   , util = require('util')",Hmm interesting. Do the tests check out on this?,Why is this change needed?
+6120,"@@ -26,11 +26,15 @@ import java.util.concurrent.TimeUnit;
+ 
+ import com.google.common.base.Stopwatch;
+ import org.apache.logging.log4j.Logger;
++import org.apache.tuweni.bytes.Bytes;
++import org.apache.tuweni.concurrent.ExpiringMap;
+ import org.apache.tuweni.units.bigints.UInt256;
+ 
+ public class PoWSolver {
+ 
++  private static final int MAX_OMMER_DEPTH = 8;
+   private static final Logger LOG = getLogger();
++  private final long powJobTimeToLive;
+ 
+   public static class PoWSolverJob {
+ ","For another PR, another `--X` candidate.",I think this should be `MAX_OMMER_DEPTH - 1`
+6121,"@@ -10,4 +10,5 @@ const (
+ 	GettingStarted = ""Getting Started ✨""
+ 	Develop = ""Develop 🔧""
+ 	Settings = ""Settings""
+-)
++	Release = ""Release""
++)","Do we need to add this constant for `group_windows.go`? Otherwise, I believe the build will fail on windows. Also what do you think of adding the emoji   at the end? The windows one could be plain.","Release = ""Release"""
+6122,"@@ -4,6 +4,8 @@
+ 
+ package net.sourceforge.pmd.lang.ast.xpath;
+ 
++import static junit.framework.TestCase.assertTrue;
++
+ import java.util.HashMap;
+ import java.util.Map;
+ ","this is a junit 3 import, not a junit 4",Why is this import needed?
+6123,"@@ -113,9 +113,16 @@ func TestReconcile(t *testing.T) {
+ 				assert.Equal(t, hivev1.UnsupportedHibernationReason, cond.Reason)
+ 			},
+ 		},
++		{
++			name:        ""clustersync not yet created"",
++			cd:          cdBuilder.Options(o.shouldHibernate).Build(),
++			expectError: true,
++		},
+ 		{
+ 			name: ""start hibernating, no syncsets"",
+ 			cd:   cdBuilder.Options(o.shouldHibernate).Build(),
++			// The clustersync controller creates a ClusterSync even when there are no syncsets
++			cs: csBuilder.Build(),
+ 			setupActuator: func(actuator *mock.MockHibernationActuator) {
+ 				actuator.EXPECT().StopMachines(gomock.Any(), gomock.Any(), gomock.Any()).Times(1).Return(nil)
+ 			},",shouldn't there be a reque expected here?,"I don't think we need this test case, since "
+6124,"@@ -63,7 +63,7 @@ namespace NLog.Layouts
+         /// 
+         /// Thread-agnostic layouts only use contents of <see cref=""LogEventInfo""/> for its output.
+         /// </remarks>
+-        internal bool ThreadAgnostic { get; private set; }
++        internal bool ThreadAgnostic { get; set; }
+ 
+         /// <summary>
+         /// Gets the level of stack trace information required for rendering.",I prefer to make it `protected set`. What do you think?,Why did you remove the private modifier?
+6125,"@@ -178,7 +178,9 @@ type Options struct {
+ 	Gateway               GatewayOpts   `json:""gateway,omitempty""`
+ 	LeafNode              LeafNodeOpts  `json:""leaf,omitempty""`
+ 	JetStream             bool          `json:""jetstream""`
+-	StoreDir              string        `json:""store_dir""`
++	JetStreamMaxMemory    int64         `json:""-""`
++	JetStreamMaxStore     int64         `json:""-""`
++	StoreDir              string        `json:""-""`
+ 	ProfPort              int           `json:""-""`
+ 	PidFile               string        `json:""-""`
+ 	PortsFileDir          string        `json:""-""`",Maybe rename this to JetStreamStoreDir?,Why do we need this?
+6126,"@@ -52,7 +52,8 @@ var _ = Describe(""UsageReporter with mocked URL and short interval"", func() {
+ 		httpHandler = &requestRecorder{}
+ 		go func() {
+ 			defer GinkgoRecover()
+-			http.Serve(tcpListener, httpHandler)
++			// TODO: Investigate why this call sometimes returns an error.
++			_ = http.Serve(tcpListener, httpHandler)
+ 		}()
+ 
+ 		// Channels to send data to the UsageReporter.",You can start by logging out the error,Why is this necessary?
+6127,"@@ -31,7 +31,7 @@ namespace Nethermind.JsonRpc.Modules.Eth.GasPrice
+     {
+         private readonly IBlockFinder _blockFinder;
+         private readonly UInt256 _minGasPrice;
+-        public UInt256 FallbackGasPrice => LastGasPrice ?? _minGasPrice;
++        public UInt256 FallbackGasPrice(in UInt256? baseFeePerGas = null) => LastGasPrice ?? GetMinimumGasPrice(baseFeePerGas ?? UInt256.Zero);
+         private ISpecProvider SpecProvider { get; }
+         public UInt256? LastGasPrice { get; set; }
+         public Block? LastHeadBlock { get; set; }","In general, what is the reason for the fallback price to be public? If it is public, why does it take baseFeePerGas instead of a block header?",I don't think we need to pass in `baseFe
+6128,"@@ -80,7 +80,7 @@ import java.util.function.*;
+  * @param <V> Value type
+  * @author Daniel Dietrich, Ruslan Sennov
+  */
+-public interface Map<K, V> extends Traversable<Tuple2<K, V>>, Function1<K, V>, PartialFunction<K, V>, Serializable {
++public interface Map<K, V> extends Traversable<Tuple2<K, V>>, PartialFunction<K, V>, Serializable {
+ 
+     long serialVersionUID = 1L;
+ ",follow-up of #2002,Why did you remove Function1?
+6129,"@@ -162,7 +162,7 @@ public class TiSession implements AutoCloseable {
+         if (tableScanThreadPool == null) {
+           tableScanThreadPool =
+               Executors.newFixedThreadPool(
+-                  conf.getTableScanConcurrency(),
++                  conf.getTableScanConcurrency() / conf.getPartitionPerSplit(),
+                   new ThreadFactoryBuilder().setDaemon(true).build());
+         }
+         res = tableScanThreadPool;","could you give some explanations of what problem do you want to solve by this change, and how/why it works?",Why not use `conf.getTableSca
+6130,"@@ -2,16 +2,18 @@
+ // The .NET Foundation licenses this file to you under the MIT license.
+ // See the LICENSE file in the project root for more information.
+ 
++using System;
+ using System.Collections.Generic;
+ using System.Threading;
+ using System.Threading.Tasks;
++using Xunit;
+ using Xunit.Abstractions;
+ using Xunit.Sdk;
+ 
+ namespace Xunit.NetCore.Extensions
+ {
+     /// <summary>Wraps another test case that should be skipped.</summary>
+-    internal sealed class SkippedTestCase : IXunitTestCase
++    internal sealed class SkippedTestCase : LongLivedMarshalByRefObject, IXunitTestCase
+     {
+         private readonly IXunitTestCase _testCase;
+         private readonly string _skippedReason;",LongLivedMarshalByRefObject exists in both the netstandard and netfx xunit?,Why is this needed?
+6131,"@@ -47,6 +47,12 @@ module Selenium
+           @bridge.send_command(cmd: cmd, params: params)
+         end
+ 
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
++
+         private
+ 
+         def debugger_address",the bridge here isn't defined as an accessor / reader to try mask it better. So you need to directly call the iVar `@bridge` here.,Why do we need this?
+6132,"@@ -85,12 +85,11 @@ func Run(ctx context.Context, cfg *config.Node) error {
+ 		}
+ 
+ 		logrus.Infof(""Running containerd %s"", config.ArgString(args[1:]))
+-		cmd := exec.Command(args[0], args[1:]...)
++		cmd := exec.CommandContext(ctx, args[0], args[1:]...)
+ 		cmd.Stdout = stdOut
+ 		cmd.Stderr = stdErr
+ 		cmd.Env = env
+ 
+-		addDeathSig(cmd)
+ 		if err := cmd.Run(); err != nil {
+ 			fmt.Fprintf(os.Stderr, ""containerd: %s\n"", err)
+ 		}","Testing on linux with this change, containerd no longer stops when k3s stops.",Why is this being removed?
+6133,"@@ -266,6 +266,11 @@ type Config struct {
+ 	// MaxConnectionReceiveWindow is the connection-level flow control window for receiving data.
+ 	// If this value is zero, it will default to 15 MB.
+ 	MaxConnectionReceiveWindow uint64
++	// AllowConnectionWindowIncrease is called every time the connection flow controller attempts
++	// to increase the connection flow control window.
++	// If set, the caller can prevent an increase of the window. Typically, it would do so to
++	// limit the memory usage.
++	AllowConnectionWindowIncrease func(sess Session, delta int) bool
+ 	// MaxIncomingStreams is the maximum number of concurrent bidirectional streams that a peer is allowed to open.
+ 	// Values above 2^60 are invalid.
+ 	// If not set, it will default to 100.",Maybe [u]int64 to be consistent with other byte-valued vars in this struct?,I think this should be cal
+6134,"@@ -25,7 +25,9 @@
+     <%- if signed_in? %>
+       <div class=""mycart-link"">
+         <ul class=""header-nav"">
+-            <li><%= link_to(""My Requests"", carts_path) %> <%= image_tag ""img-cart.png"", width: '18px', height:'16px' %></li>
++          <li><%= link_to ""My Requests"", carts_path %> <%= image_tag ""img-cart.png"", width: '18px', height:'16px' %></li>
++          <%# TODO only show to NCR people %>
++          <li><%= link_to ""New Request"", new_ncr_proposal_path %></li>
+         </ul>
+       </div>
+     <%- end %>","This brings up the question... do we need to start assigning users to the different use cases in some way? We don't want this link to show up for Ric, for example.",I'm not sure if this is th
+6135,"@@ -36,9 +36,12 @@ template <typename Dtype>
+ BasePrefetchingDataLayer<Dtype>::BasePrefetchingDataLayer(
+     const LayerParameter& param)
+     : BaseDataLayer<Dtype>(param),
+-      prefetch_free_(), prefetch_full_() {
+-  for (int i = 0; i < PREFETCH_COUNT; ++i) {
+-    prefetch_free_.push(&prefetch_[i]);
++      prefetch_(param.has_data_param() ?
++                param.data_param().prefetch() : PREFETCH_COUNT),
++      prefetch_free_(), prefetch_full_(), prefetch_current_() {
++  for (int i = 0; i < prefetch_.size(); ++i) {
++    prefetch_[i].reset(new Batch<Dtype>());
++    prefetch_free_.push(prefetch_[i].get());
+   }
+ }
+ ","Unless I'm misunderstanding something, this should just be `prefetch_(param.data_param().prefetch())`, no? That should just use the default value if there's no explicit `data_param` or `data_param.prefetch` set, removing the need to also duplicate and hardcode `PREFETCH_COUNT`.",`prefetch_(param.has_data_
+6136,"@@ -55,6 +55,16 @@ func nodeStatus(node *node.AlgorandFullNode) (res v1.NodeStatus, err error) {
+ 	}, nil
+ }
+ 
++func txEncode(tx transactions.Transaction, ad transactions.ApplyData) (res v1.Transaction, err error) {
++	switch tx.Type {
++	case protocol.PaymentTx:
++		return paymentTxEncode(tx, ad), nil
++	case protocol.KeyRegistrationTx:
++		return keyregTxEncode(tx, ad), nil
++	}
++	return v1.Transaction{}, errors.New(errUnknownTransactionType)
++}
++
+ func paymentTxEncode(tx transactions.Transaction, ad transactions.ApplyData) v1.Transaction {
+ 	payment := v1.PaymentTransactionType{
+ 		To:           tx.Receiver.String(),",nit : move this into a default clause in the previous switch statement.,Why do we need to return an error here?
+6137,"@@ -27,14 +27,12 @@ var formatter = this;
+ string = function(value) {
+ 	if (value != null) {
+ 		value = value.replace(/\\/g, '\\\\');
+-		value = value.replace(/\""/g, '\\""');
++		value = value.replace(/\'/g, '\\\'');
+ 		value = value.replace(/\r/g, '\\r');
+ 		value = value.replace(/\n/g, '\\n');
+-		value = value.replace(/@/g, '\\@');
+-		value = value.replace(/\$/g, '\\$');
+-		return '""' + value + '""';
++		return ""'"" + value + ""'"";
+ 	} else {
+-		return '""""';
++		return ""'"";
+ 	}
+ }
+ ","It should be return ""''""; I will fix it",Why did you remove the quotes?
+6138,"@@ -43,14 +43,14 @@ type ClusterEvent interface{}
+ // Specific type of cluster event emitted when new member joins cluster
+ type NewMemberEvent struct {
+ 	endpointsInfo
+-	Id string
++	ID string
+ }
+ 
+ // Specific type of cluster event emitted when leadership is transferred.
+ // It is not always loss or acquire of leadership of this specific node
+ type LeadershipEvent struct {
+ 	Held            bool
+-	LeaderId        string
++	LeaderID        string
+ 	LeaderEndpoints []string
+ }
+ ","Go standard linter hates `Id`s and likes `ID`s, please do not resist.",Why do we need this change?
+6139,"@@ -71,11 +71,11 @@ module Travis
+           end
+ 
+           def fetch_ref
+-            cmd ""git fetch origin +#{data.ref}: "", assert: true, timeout: :git_fetch_ref, fold: ""git.#{next_git_fold_number}""
++            cmd ""git fetch origin +#{data.ref}: "", assert: true, timeout: :git_fetch_ref, fold: ""git.#{next_git_fold_number}"", retry: true
+           end
+ 
+           def git_checkout
+-            cmd ""git checkout -qf #{data.pull_request ? 'FETCH_HEAD' : data.commit}"", assert: true, fold: ""git.#{next_git_fold_number}""
++            cmd ""git checkout -qf #{data.pull_request ? 'FETCH_HEAD' : data.commit}"", assert: true, fold: ""git.#{next_git_fold_number}"", retry: true
+           end
+ 
+           def submodules?","I don't think retrying here is as useful, since `git-checkout` doesn't access the network AFAIK, and if it fails once it's probably going to fail all three times.",Prefer single-quoted strings when you d
+6140,"@@ -172,7 +172,7 @@ func SetCertificateNotBefore(p metav1.Time) CertificateModifier {
+ 	}
+ }
+ 
+-func SetCertificateRenewalTIme(p metav1.Time) CertificateModifier {
++func SetCertificateRenewalTime(p metav1.Time) CertificateModifier {
+ 	return func(crt *v1.Certificate) {
+ 		crt.Status.RenewalTime = &p
+ 	}",Fixing this typo caused a build failure in `cmd/ctl/pkg/status/certificate/certificate_test.go:238` Could you also update it there?,nit: typo in function name
+6141,"@@ -25,6 +25,8 @@ _rtp_payload_types = {
+     31: 'H261',          32: 'MPV',
+     33: 'MP2T',          34: 'H263' }
+ 
++extension_condition = lambda pkt: pkt.extension
++
+ class RTP(Packet):
+     name=""RTP""
+     fields_desc = [ BitField('version', 2, 2),",Please note that adding this will import `extension_condition` in the entire scapy (as you are located in a layer). You might want to move this inside the RTP class ? Would be better i think,`extension_condition = lam
+6142,"@@ -72,7 +72,7 @@ module RSpec::Core
+         end
+ 
+         parser.on('--seed SEED', Integer, 'Equivalent of --order rand:SEED.') do |seed|
+-          options[:order] = ""rand:#{seed}""
++          options[:seed] = seed
+         end
+ 
+         parser.on('--fail-fast', 'Abort the run on first failure.') do |o|","This will need updating, as I'm not sure we'll want to turn on random ordering if they've specified a seed for programmatic use.",Why did you remove this?
+6143,"@@ -112,6 +112,9 @@ loader_init(void)
+         char name_copy[MAXIMUM_PATH];
+         mod = privload_insert(NULL, privmod_static[i].base, privmod_static[i].size,
+                               privmod_static[i].name, privmod_static[i].path);
++#ifdef CLIENT_INTERFACE
++        mod->is_client = true;
++#endif
+         LOG(GLOBAL, LOG_LOADER, 1, ""%s: processing imports for %s\n"", __FUNCTION__,
+             mod->name);
+         /* save a copy for error msg, b/c mod will be unloaded (i#643) */",Are you sure these are all client libs? This seems fragile: if we later load sthg else early this will break. Seems best to have some kind of sanity check: at least add an assert in the current location where this is set.,Why is this needed?
+6144,"@@ -2167,7 +2167,9 @@ namespace pwiz.Skyline.Model.Lib
+                 }
+                 if (!string.IsNullOrEmpty(OtherKeys))
+                 {
+-                    smallMolLines.Add(new KeyValuePair<string, string> (Resources.SmallMoleculeLibraryAttributes_KeyValuePairs_OtherIDs, OtherKeys.Replace('\t','\n')));
++                    // Add a separate line for each molecule accession number
++                    var accessionNumDict = MoleculeAccessionNumbers.FormatAccessionNumbers(OtherKeys);
++                    smallMolLines.AddRange(accessionNumDict.Select(pair => new KeyValuePair<string, string>(pair.Key, pair.Value)));
+                 }
+                 return smallMolLines;
+             }","Picking nits here, but as a Dictionary already is a collection of KeyValuePairs there's undoubtably a way to code this that doesn't involve constructing any new ones.",I don't think you need the `.Replace` here.
+6145,"@@ -19,12 +19,7 @@ package org.camunda.bpm.model.cmmn;
+ import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN10_NS;
+ import static org.camunda.bpm.model.cmmn.impl.CmmnModelConstants.CMMN11_NS;
+ 
+-import java.io.File;
+-import java.io.FileInputStream;
+-import java.io.FileNotFoundException;
+-import java.io.FileOutputStream;
+-import java.io.InputStream;
+-import java.io.OutputStream;
++import java.io.*;
+ 
+ import org.camunda.bpm.model.cmmn.impl.CmmnParser;
+ import org.camunda.bpm.model.cmmn.impl.instance.ApplicabilityRuleImpl;","As Miklas stated, please avoid wildcard imports.",Please don't use wildcard imports.
+6146,"@@ -204,5 +204,4 @@ function server (inputCompanionOptions = {}) {
+   return { app, companionOptions }
+ }
+ 
+-const { app, companionOptions } = server()
+-module.exports = { app, companionOptions, server }
++module.exports = { server }",Maybe change it to `module.exports = server` ? Becase there's nothing else to export here,Why did you remove this?
+6147,"@@ -24,14 +24,13 @@ import (
+ 
+ 	""cloud.google.com/go/pubsub""
+ 	""cloud.google.com/go/pubsub/pstest""
++	""google.golang.org/grpc/codes""
+ 
+ 	reconcilertestingv1 ""github.com/google/knative-gcp/pkg/reconciler/testing/v1""
+ 	""github.com/google/knative-gcp/pkg/utils/authcheck""
+ 
+ 	""google.golang.org/api/option""
+ 	""google.golang.org/grpc""
+-	""google.golang.org/grpc/codes""
+-
+ 	v1 ""k8s.io/api/apps/v1""
+ 
+ 	corev1 ""k8s.io/api/core/v1""","This may be an automated change, but the import seems to fit better where it was previously.",nit: remove empty line
+6148,"@@ -0,0 +1,9 @@
++<script type=""text/javascript"">
++  window.analytics||(window.analytics=[]),window.analytics.methods=[""identify"",""track"",""trackLink"",""trackForm"",""trackClick"",""trackSubmit"",""page"",""pageview"",""ab"",""alias"",""ready"",""group"",""on"",""once"",""off""],window.analytics.factory=function(t){return function(){var a=Array.prototype.slice.call(arguments);return a.unshift(t),window.analytics.push(a),window.analytics}};for(var i=0;i<window.analytics.methods.length;i++){var method=window.analytics.methods[i];window.analytics[method]=window.analytics.factory(method)}window.analytics.load=function(t){var a=document.createElement(""script"");a.type=""text/javascript"",a.async=!0,a.src=(""https:""===document.location.protocol?""https://"":""http://"")+""d2dq2ahtl5zl1z.cloudfront.net/analytics.js/v1/""+t+""/analytics.min.js"";var n=document.getElementsByTagName(""script"")[0];n.parentNode.insertBefore(a,n)},window.analytics.SNIPPET_VERSION=""2.0.8"",
++  window.analytics.load(""2nexpdgku3"");
++  window.analytics.page();
++</script>
++
++<% if signed_in? %>
++  <%= render 'signed_in_analytics' %>
++<% end %>",Might we want to separate including this snippet and sending the data for signed in users into different partials?,I don't think you need the `||` here
+6149,"@@ -32,7 +32,11 @@ type PeerAdder interface {
+ }
+ 
+ type ClosestPeerer interface {
+-	ClosestPeer(addr swarm.Address) (peerAddr swarm.Address, err error)
++	// ClosestPeer returns the closest connected peer we have in relation to a
++	// given chunk address.
++	// This function will ignore peers with addresses provided in skipPeers.
++	// Returns topology.ErrWantSelf in case base is the closest to the chunk.
++	ClosestPeer(addr swarm.Address, skipPeers ...swarm.Address) (peerAddr swarm.Address, err error)
+ }
+ 
+ type EachPeerer interface {",closest to the address,nit: `in relation to` -> `in relatio
+6150,"@@ -18,13 +18,17 @@ const ROW_WIDTHS_MAP_NAME = 'autoRowSize';
+  * @plugin AutoRowSize
+  * @class AutoRowSize
+  * @description
+- * This plugin allows to set row heights based on their highest cells.
++ * The `AutoRowSize` plugin allows you to set row heights based on their highest cells.
+  *
+  * By default, the plugin is declared as `undefined`, which makes it disabled (same as if it was declared as `false`).
+  * Enabling this plugin may decrease the overall table performance, as it needs to calculate the heights of all cells to
+  * resize the rows accordingly.
+  * If you experience problems with the performance, try turning this feature off and declaring the row heights manually.
+  *
++ * But, to display Handsontable's [scrollbar](https://handsontable.com/docs/8.0.0/demo-scrolling.html)
++ * in a proper size, you need to enable the `AutoRowSize` plugin,
++ * by setting the [`autoRowSize`](@/api/options.md#autoRowSize) option to `true`.
++ *
+  * Row height calculations are divided into sync and async part. Each of this parts has their own advantages and
+  * disadvantages. Synchronous calculations are faster but they block the browser UI, while the slower asynchronous
+  * operations don't block the browser UI.",It should be much more clear for end-user  ,I don't think you need the `@` here.
+6151,"@@ -82,7 +82,7 @@ SINGLE_QUOTED_REGEX = re.compile(""(%s)?'''"" % ""|"".join(_PREFIXES))
+ DOUBLE_QUOTED_REGEX = re.compile('(%s)?""""""' % ""|"".join(_PREFIXES))
+ QUOTE_DELIMITER_REGEX = re.compile(""(%s)?(\""|')"" % ""|"".join(_PREFIXES), re.DOTALL)
+ 
+-MSGS = {
++MSGS = {  # pylint: disable=consider-using-namedtuple
+     ""E1300"": (
+         ""Unsupported format character %r (%#02x) at index %d"",
+         ""bad-format-character"",","Isn't this an example that this will be prone to false positives ? We had nothing to fix in the codebase (And I think there is dict that could be named tuple in the MessageStore/MessageIdStore), but we have a false positives on our checkers.",Why do we need to disable this?
+6152,"@@ -55,11 +55,11 @@ func TestOpenCensus(t *testing.T) {
+ 	const provider = ""gocloud.dev/blob/memblob""
+ 
+ 	diff := octest.Diff(te.Spans(), te.Counts(), ""gocloud.dev/blob"", provider, []octest.Call{
+-		{""NewWriter"", gcerrors.OK},
+-		{""NewRangeReader"", gcerrors.OK},
+-		{""Attributes"", gcerrors.OK},
+-		{""Delete"", gcerrors.OK},
+-		{""NewRangeReader"", gcerrors.NotFound},
++		{Method: ""NewWriter"", Code: gcerrors.OK},
++		{Method: ""NewRangeReader"", Code: gcerrors.OK},
++		{Method: ""Attributes"", Code: gcerrors.OK},
++		{Method: ""Delete"", Code: gcerrors.OK},
++		{Method: ""NewRangeReader"", Code: gcerrors.NotFound},
+ 	})
+ 	if diff != """" {
+ 		t.Error(diff)","We control `octest`, so it shouldn't be necessary to provide struct literal keys. This is a case of vet being too picky.",Why did you change this?
+6153,"@@ -90,5 +90,8 @@ module DMPRoadmap
+     #   is_test                   - (NOT advisable because test plans are excluded from statistics)
+     #   privately_visible         - Only the owner and people they invite can access the plan
+     config.default_plan_visibility = 'privately_visible'
++   
++    # The percentage of answered questions needed to enable the plan visibility section of the Share plan page
++    config.default_plan_percentage_answered = 50.00
+   end
+ end",I would put that constant under config/initializers/constant.rb and I would leave application.rb for rails specific.,Style/NumericLiterals: U
+6154,"@@ -572,7 +572,18 @@ func (fup folderUpdatePrepper) updateResolutionUsage(ctx context.Context,
+ // addUnrefToFinalResOp makes a resolutionOp at the end of opsList if
+ // one doesn't exist yet, and then adds the given pointer as an unref
+ // block to it.
+-func addUnrefToFinalResOp(ops opsList, ptr BlockPointer) opsList {
++func addUnrefToFinalResOp(ops opsList, ptr BlockPointer,
++	doNotUnref map[BlockPointer]bool) opsList {
++	// Make sure the block ID we want to unref isn't in the ""do not
++	// unref"" list -- it could mean that block has already been GC'd
++	// by the merged branch.  We can't compare pointers directly
++	// because GC'd pointers contain no block context.
++	for noUnref := range doNotUnref {
++		if ptr.ID == noUnref.ID {
++			return ops
++		}
++	}
++
+ 	resOp, ok := ops[len(ops)-1].(*resolutionOp)
+ 	if !ok {
+ 		resOp = newResolutionOp()","Is there a reason not to do something like `if _, ok := doNotUnref[ptr.ID]; ok { return ops }` here?",nit: `make sure` -> `mak
+6155,"@@ -539,7 +539,10 @@ class WebElement(object):
+     @property
+     def rect(self):
+         """"""A dictionary with the size and location of the element.""""""
+-        return self._execute(Command.GET_ELEMENT_RECT)['value']
++        if self._w3c:
++            return self._execute(Command.GET_ELEMENT_RECT)['value']
++        else:
++            return self.size, self.location
+ 
+     @property
+     def screenshot_as_base64(self):",This would return a tuple of two dictionaries. You need to combine them and return a dictionary,I don't think this is th
+6156,"@@ -29,10 +29,10 @@ class Node(object):
+     def __repr__(self):
+         return self._class_repr()
+ 
+-    def __call__(self):
+-        return self._data()
++    def __call__(self, asa=None):
++        raise NotImplementedError
+ 
+-    def _data(self):
++    def _data(self, asa=None):
+         raise NotImplementedError
+ 
+ ",Why not always forward it to `_data`?,`asa` is not used.
+6157,"@@ -263,7 +263,7 @@ def connect_spotify_callback():
+     return redirect(url_for('profile.connect_spotify'))
+ 
+ 
+-@profile_bp.route('/refresh-spotify-token', methods=['GET'])
++@profile_bp.route('/refresh-spotify-token', methods=['POST'])
+ @crossdomain()
+ @api_login_required
+ def refresh_spotify_token():",there are tests that use `client.get` which will fail now,Why did you change
+6158,"@@ -371,7 +371,7 @@ func (fs *FS) mkdirAll(filename string, perm os.FileMode) (err error) {
+ 		switch errors.Cause(err).(type) {
+ 		case libkbfs.NameExistsError:
+ 			// The child directory already exists.
+-		case libkbfs.WriteAccessError:
++		case libkbfs.WriteAccessError, libkbfs.WriteToReadonlyNodeError:
+ 			// If the child already exists, this doesn't matter.
+ 			var lookupErr error
+ 			child, _, lookupErr = fs.config.KBFSOps().Lookup(fs.ctx, n, p)","Whoa, TIL about this syntax.",Why is this change
+6159,"@@ -34,12 +34,14 @@ type fakeHandler struct {
+ }
+ 
+ func (h fakeHandler) Handle(context.Context, *yarpc.Request, *yarpc.Buffer) (*yarpc.Response, *yarpc.Buffer, error) {
+-	errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
+-	res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
+ 	if h.applicationErr != nil {
++		errorInfo := yarpcerror.ExtractInfo(h.applicationErr)
++		res := &yarpc.Response{ApplicationErrorInfo: &errorInfo}
+ 		return res, nil, nil
++	} else if h.err != nil {
++		return nil, nil, h.err
+ 	}
+-	return res, nil, h.err
++	return &yarpc.Response{}, &yarpc.Buffer{}, nil
+ }
+ 
+ func (h fakeHandler) HandleStream(*yarpc.ServerStream) error {","This is a smell. When is this valid? Perhaps this should be `nil, nil, ErrNoResponse` or some such. While it is usually invalid to have neither a return value or error, we rarely check for the case in other idiomatic Go. Nothing wrong with extra defenses here, but think about it.",Why do we need to 
+6160,"@@ -0,0 +1,7 @@
++_base_ = './faster_rcnn_r50_fpn_1x_coco.py'
++classes = ('person', 'bicycle', 'car')
++data = dict(
++    train=dict(classes=classes),
++    val=dict(classes=classes),
++    test=dict(classes=classes))
++load_from = 'https://s3.ap-northeast-2.amazonaws.com/open-mmlab/mmdetection/models/faster_rcnn_r50_fpn_1x_20181010-3d1b3351.pth'  # noqa","This URL is outdated, add a `TODO` to fix it.",why do we need this?
+6161,"@@ -23,10 +23,13 @@ type (
+ 		Proto() *iotextypes.ActionCore
+ 		LoadProto(pbAct *iotextypes.ActionCore) error
+ 		SetNonce(n uint64)
++		ChainID() uint32
++		SetChainID(chainID uint32)
+ 	}
+ 
+ 	envelope struct {
+ 		version  uint32
++		chainID  uint32
+ 		nonce    uint64
+ 		gasLimit uint64
+ 		gasPrice *big.Int","`ChainID()` is a getter method, move up to `Nonce()`",Why do we need Chain
+6162,"@@ -163,6 +163,10 @@ public class FlowTriggerScheduler {
+               flowId, flowTrigger, submitUser, quartzTriggers.isEmpty() ? null
+               : quartzTriggers.get(0), isPaused, flow.isLocked());
+         } catch (final Exception ex) {
++          if (QuartzScheduler.isSerializationBug(ex) && this.scheduler.enableSerializationHack()) {
++            logger.info(""Enable serialization hack"");
++            return getScheduledFlowTriggerJobs();
++          }
+           logger.error(""Unable to get flow trigger by job key {}"", jobKey, ex);
+           scheduledFlowTrigger = null;
+         }","If this condition is not met, shall we just throw the exception rather than logging it? @li-ygerchikov Your thoughts?",Shouldn't this be `l
+6163,"@@ -57,6 +57,7 @@ REQUIRED_PACKAGES = [
+     'mock>=2.0.0',
+     'parameterized>=0.6.1',
+     'simple-crypt>=4.1.7',
++    'ruamel.yaml'
+ ]
+ 
+ if sys.version_info < (2, 7):",nit: alpha-sort `ruamel.yaml` in this list please,Why do we need this?
+6164,"@@ -58,6 +58,15 @@ public class TableScanUtil {
+ 
+     Function<FileScanTask, Long> weightFunc = file -> Math.max(file.length(), openFileCost);
+ 
++    Preconditions.checkArgument(splitSize > 0,
++        ""Cannot create a plan with a split size that is not positive, splitSize = %s"", splitSize);
++
++    Preconditions.checkArgument(lookback > 0,
++        ""Cannot create a plan with a lookback that is not positive, lookback = %s"", lookback);
++
++    Preconditions.checkArgument(openFileCost >= 0,
++        ""Cannot create a plan with a openFileCost that is negative, openFileCost = %s"", openFileCost);
++
+     return CloseableIterable.transform(
+         CloseableIterable.combine(
+             new BinPacking.PackingIterable<>(splitFiles, splitSize, lookback, weightFunc, true),",Remove this because we already added it in another pr,"""Cannot create a plan with a lookback that is negative, lookback = %s"""
+6165,"@@ -79,7 +79,13 @@ public class ShortcutManager {
+ 
+             try {
+                 if (shortcutDTO.getIcon() != null) {
+-                    File file = new File(shortcutDTO.getIcon());
++                    File file;
++                    try {
++                        file = new File(shortcutDTO.getIcon());
++                    } catch (IllegalArgumentException e) {
++                        // fallback to phoenicis.png
++                        file = new File(getClass().getResource(""phoenicis.png"").toExternalForm());
++                    }
+                     if (file.exists()) {
+                         FileUtils.copyFile(file, iconFile);
+                     }","Can we maybe move the `File` creation to a new method? I mean both changes look equal to me with the difference of two parts, which could be specified using two input parameters.",Why is this needed?
+6166,"@@ -9,6 +9,8 @@ class ApiToken < ActiveRecord::Base
+ 
+   # TODO validates :access_token, presence: true
+   validates :approval_id, presence: true
++  validates :access_token, presence: true, allow_blank: true, length: { minimum: 0, maximum: 255 }
++  validates :user, presence: true, allow_blank: true
+ 
+   scope :unexpired, -> { where('expires_at >= ?', Time.now) }
+   scope :expired, -> { where('expires_at < ?', Time.now) }",I think we want to require the association with the user...?,Style/SymbolArray: Use %i or %I for an array of symbols.
+6167,"@@ -110,8 +110,17 @@ func (smsg *SignedMessage) VerifySignature() error {
+ }
+ 
+ // OnChainLen returns the amount of bytes used to represent the message on chain.
++// Dragons: verify this is the correct way to determine a signed messages size on chain.
+ func (smsg *SignedMessage) OnChainLen() uint32 {
+-	panic(""byteme"")
++	msgBits, err := encoding.Encode(smsg.Message)
++	if err != nil {
++		panic(err)
++	}
++	sigBits, err := encoding.Encode(smsg.Signature)
++	if err != nil {
++		panic(err)
++	}
++	return uint32(len(msgBits) + len(sigBits))
+ }
+ 
+ func (smsg *SignedMessage) String() string {","I am unsure the below implementation is correct, but need this method to not panic else it borks the chain-validation tests.",Why is this needed?
+6168,"@@ -19,7 +19,7 @@ A wrapper class for Spark Column to behave similar to pandas Series.
+ """"""
+ import re
+ import inspect
+-from collections import Iterable
++from collections import Iterable, OrderedDict
+ from functools import partial, wraps
+ from typing import Any, Generic, List, Optional, Tuple, TypeVar, Union
+ ",nit: no need this change anymore.,`OrderedDict` is not needed here.
+6169,"@@ -1967,9 +1967,7 @@ class Codebase
+ 
+         $this->taint_flow_graph->addSource($source);
+ 
+-        $expr_type->parent_nodes = [
+-            $source->id => $source,
+-        ];
++        $expr_type->parent_nodes[$source->id] = $source;
+     }
+ 
+     /**","This isn't really that closely related to everything else in this PR, but I'm pretty sure it's a correct change. I'm not familiar enough with the taint feature to know how to test it, but I worry that without this change some of the taint stuff might mess up the `parent_nodes` for a reference.",Why did you change this?
+6170,"@@ -6,8 +6,9 @@
+ package javaslang;
+ 
+ import javaslang.collection.Iterator;
+-import javaslang.collection.List;
+ import javaslang.collection.Seq;
++import javaslang.collection.Stream;
++import javaslang.collection.Vector;
+ import javaslang.control.Option;
+ 
+ import java.io.IOException;",[Checkstyle] ERROR: Unused import - javaslang.collection.Stream.,Why did you change this?
+6171,"@@ -126,7 +126,7 @@ public class TestPseudoReturnFields extends SolrTestCaseJ4 {
+               ,""//result/doc/str[@name='ssto']""
+               ,""//result/doc/str[@name='subject']""
+               
+-              ,""//result/doc[count(*)=4]""
++              ,""//result/doc[count(*)=5]""
+               );
+     }
+   }","The numbers were changed since now _root_ is also added to the doc, increasing the field count by 1.","//result/doc[count(*)=5]"""
+6172,"@@ -169,12 +169,6 @@ class ArrayMapReturnTypeProvider implements FunctionReturnTypeProviderInterface
+                                 $function_call_arg->value->items[1]->value->value,
+                                 []
+                             );
+-                        } elseif ($variable_atomic_type instanceof TTemplateParamClass) {
+-                            $fake_method_call = new VirtualStaticCall(
+-                                $function_call_arg->value->items[0]->value,
+-                                $function_call_arg->value->items[1]->value->value,
+-                                []
+-                            );
+                         }
+                     }
+ ",TTemplateParamClass is handled above with the same content in the conditional,Why did you remove this?
+6173,"@@ -597,6 +597,17 @@ class Upgrade
+             }
+         }
+ 
++        // Upgrade CAPTCHA Options
++        $oldKeys
++            = ['siteKey', 'publicKey', 'secretKey', 'privateKey'];
++        foreach ($oldKeys as $key) {
++            if (isset($newConfig['Captcha'][$key])) {
++                $newConfig['Captcha']['recaptcha_' . $key]
++                    = $newConfig['Captcha'][$key];
++                unset($newConfig['Captcha'][$key]);
++            }
++        }
++
+         // Warn the user about deprecated WorldCat settings:
+         if (isset($newConfig['WorldCat']['LimitCodes'])) {
+             unset($newConfig['WorldCat']['LimitCodes']);",Do we need to add `theme` here?,Why is this needed?
+6174,"@@ -160,6 +160,9 @@ type Network struct {
+ 	// VPC defines the cluster vpc.
+ 	VPC *VPC `json:""vpc""`
+ 
++	// InternetGatewayID is the id of the internet gateway associated with the VPC.
++	InternetGatewayID *string `json:""internetGatewayId""`
++
+ 	// Subnets includes all the subnets defined inside the VPC.
+ 	Subnets Subnets `json:""subnets""`
+ }","i think you have to regen the api stuff, `make generate`",Why is this a pointer?
+6175,"@@ -187,9 +187,17 @@ public class SECP256K1 {
+     signer.init(true, privKey);
+ 
+     final BigInteger[] components = signer.generateSignature(dataHash.toArrayUnsafe());
+-    final BigInteger r = components[0];
+-    BigInteger s = components[1];
+ 
++    return normaliseSignature(components[0], components[1], keyPair.getPublicKey(), dataHash);
++  }
++
++  public static Signature normaliseSignature(
++      final BigInteger nativeR,
++      final BigInteger nativeS,
++      final PublicKey publicKey,
++      final Bytes32 dataHash) {
++
++    BigInteger s = nativeS;
+     // Automatically adjust the S component to be less than or equal to half the curve
+     // order, if necessary. This is required because for every signature (r,s) the signature
+     // (r, -s (mod N)) is a valid signature of the same message. However, we dislike the",DataHash shouldn't be needed here,nit: `final` not needed.
+6176,"@@ -110,7 +110,7 @@ public class WebDriverBackedSeleniumHandler implements Routable {
+     StringBuilder printableArgs = new StringBuilder(""["");
+     Joiner.on("", "").appendTo(printableArgs, args);
+     printableArgs.append(""]"");
+-    LOG.info(String.format(""Command request: %s%s on session %s"", cmd, printableArgs, sessionId));
++    LOG.finest(String.format(""Command request: %s%s on session %s"", cmd, printableArgs, sessionId));
+ 
+     if (""getNewBrowserSession"".equals(cmd)) {
+       // Figure out what to do. If the first arg is ""*webdriver"", check for a session id and use",`info` was chosen deliberately to mirror the old behaviour that users expected.,Why is this being changed to finest?
+6177,"@@ -31,8 +31,8 @@ describeComponent(
+                 component._selectize.setValue(['item 3', 'item 2']);
+             });
+ 
+-            expect(component.get('value'), 'component value').to.deep.equal(['item 3', 'item 2']);
+-            expect(component.get('selection'), 'component selection').to.deep.equal(['item 3', 'item 2']);
++            expect(component.get('value').toArray(), 'component value').to.deep.equal(['item 3', 'item 2']);
++            expect(component.get('selection').toArray(), 'component selection').to.deep.equal(['item 3', 'item 2']);
+         });
+     }
+ );","For some reason, Safari handles ember arrays differently than Chrome/Firefox. To get around that, we cast the ember array to a regular array to verify the deep equal. (Note: I tried wrapping the expected value in an emberA - which would look like `expect(someEmberArray).to.deep.equal(emberA(['a', 'b']));` but that didn't work either)",Why do we need this change?
+6178,"@@ -36,6 +36,7 @@ public class VectorHolder {
+   private final Dictionary dictionary;
+   private final NullabilityHolder nullabilityHolder;
+   private final Type icebergType;
++  private final Type originalIcebergType;
+ 
+   public VectorHolder(
+       ColumnDescriptor columnDescriptor, FieldVector vector, boolean isDictionaryEncoded,","`icebergType` indicates the corresponding iceberg type of the `FieldVector` `originalIcebergType` indicates what the real type we will read from the `FieldVector`. For example, the parquet int backed decimal, the `icebergType` should be integer, `originalIcebergType` is decimal. I intend to only keep the `originalIcebergType`, but listening to your ideas.",Why do we need this?
+6179,"@@ -43,7 +43,7 @@
+ //  - Reader: *storage.Reader
+ //  - Attributes: storage.ObjectAttrs
+ //  - CopyOptions.BeforeCopy: *storage.Copier
+-//  - WriterOptions.BeforeWrite: *storage.Writer
++//  - WriterOptions.BeforeWrite: **storage.ObjectHandle, *storage.Writer
+ package gcsblob // import ""gocloud.dev/blob/gcsblob""
+ 
+ import (","The double (and thus triple as seen below) pointer gives me pause. I could imagine providing some larger API surface to smooth it out, but it's likely not worth it.",Why do we need this change?
+6180,"@@ -1011,13 +1011,13 @@ describe('document', function() {
+   });
+ 
+   describe('Errors', function() {
+-    it('MongooseErrors should be instances of Error (gh-209)', function(done) {
++    it('MongooseError should be instances of Error (gh-209)', function(done) {
+       const MongooseError = require('../lib/error');
+       const err = new MongooseError('Some message');
+       assert.ok(err instanceof Error);
+       done();
+     });
+-    it('ValidationErrors should be instances of Error', function(done) {
++    it('ValidationError should be instances of Error', function(done) {
+       const ValidationError = Document.ValidationError;
+       const err = new ValidationError(new TestDocument);
+       assert.ok(err instanceof Error);","The test name as written was grammatically correct, but now it isn't. Both 'MongooseError' and 'instance' should be both singular or both plural.",Shouldn't this be `ValidationError`?
+6181,"@@ -125,8 +125,8 @@ public class SmartStoreInspectorActivity extends Activity {
+ 
+ 	private void readExtras() {
+ 		Bundle bundle = getIntent().getExtras();
+-		isGlobal = bundle.getBoolean(IS_GLOBAL_STORE, false);
+-		dbName = bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
++		isGlobal = bundle == null ? false : bundle.getBoolean(IS_GLOBAL_STORE, false);
++		dbName = bundle == null ? DBOpenHelper.DEFAULT_DB_NAME : bundle.getString(DB_NAME, DBOpenHelper.DEFAULT_DB_NAME);
+ 	}
+ 
+ 	/**",SmartStoreInspectorTest was throwing a NPE here,I'm not sure if this is the right wa
+6182,"@@ -134,9 +134,13 @@ public abstract class DeleteFilter<T> {
+ 
+       Iterable<CloseableIterable<Record>> deleteRecords = Iterables.transform(deletes,
+           delete -> openDeletes(delete, deleteSchema));
+-      StructLikeSet deleteSet = Deletes.toEqualitySet(
+-          // copy the delete records because they will be held in a set
+-          CloseableIterable.transform(CloseableIterable.concat(deleteRecords), Record::copy),
++
++      // copy the delete records because they will be held in a set
++      CloseableIterable<Record> records = CloseableIterable.transform(CloseableIterable.concat(deleteRecords),
++          Record::copy);
++
++      StructLikeSet deleteSet = Deletes.toEqualitySet(CloseableIterable.transform(records,
++          record -> new InternalRecordWrapper(deleteSchema.asStruct()).wrap(record)),
+           deleteSchema.asStruct());
+ 
+       Predicate<T> isInDeleteSet = record -> deleteSet.contains(projectRow.wrap(asStructLike(record)));","We prefer line wrapping that keeps arguments to the same method aligned rather than aligning arguments to different levels. Here, the lambda to create an `InternalRecordWrapper` is an argument to `transform`, but it is aligned with `deleteSchema.asStruct()` that is an argument to the outer `toEqualitySet` call. Instead, can you add a newline for each argument to `toEqualitySet`? If the line with the lambda is too long, then you can also add a newline for it that it indented from the start of the line with `transform`, so it is clear that it is an argument to `transform` and not `toEqualitySet`.",nit: `InternalRecordWrapper.wrap(del
+6183,"@@ -173,6 +173,10 @@ import ServerConnections from '../ServerConnections';
+                     value: session.TranscodingInfo.TranscodeReasons.map(translateReason).join('<br/>')
+                 });
+             }
++            sessionStats.push({
++                label: globalize.translate('LabelHardwareEncoding'),
++                value: session.TranscodingInfo.HardwareAccelerationType
++            });
+         }
+ 
+         return sessionStats;","I think it would be a good idea to wrap this in an if like the stats above, just in case.",I don't think we need to translate t
+6184,"@@ -289,6 +289,9 @@ public class LFMainActivity extends SharedMediaActivity {
+                     mediaAdapter.notifyItemChanged(toggleSelectPhoto(m));
+                     editMode = true;
+                 }
++                else {
++                    selectAllPhotosUpToFav(getImagePosition(m.getPath()));
++                }
+             } else selectAllPhotosUpTo(getImagePosition(m.getPath()), mediaAdapter);
+             return true;
+         }","@angmas1 just make one more change here too. Move the else line to the line above it, where the if block ends and remove the braces like in line 280.",I don't think this is the right place to do this. It should be inside the `if` block.
+6185,"@@ -21,7 +21,7 @@ func (s *BlkioGroup) Name() string {
+ }
+ 
+ func (s *BlkioGroup) Apply(path string, d *cgroupData) error {
+-	return join(path, d.pid)
++	return apply(path, d.pid)
+ }
+ 
+ func (s *BlkioGroup) Set(path string, r *configs.Resources) error {","Looks like the actual rename is missing in this commit edit: Arf, nevermind, I was at the wrong commit  ",Why is this change needed?
+6186,"@@ -67,7 +67,9 @@ module.exports = class Transloadit extends Plugin {
+     this._onRestored = this._onRestored.bind(this)
+     this._getPersistentData = this._getPersistentData.bind(this)
+ 
+-    if (this.opts.params) {
++    if (this.opts.params ||
++        // No params _and_ no custom getAssemblyOptions is an early error.
++        this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions) {
+       AssemblyOptions.validateParams(this.opts.params)
+     }
+ ","I'm a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)`  ",I don't think we need to check for `getAssemblyOptions` here.
+6187,"@@ -20,6 +20,15 @@ import (
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/daisy""
+ )
+ 
++var (
++	// These patterns match a key of ""Vars"" in a daisy workflow. All CLI tools use these variables.
++	//
++	// For network and subnet, some workflows use the prefix `import_`.
++	networkPattern               = regexp.MustCompile(""^(import_)?network$"")
++	subnetPattern                = regexp.MustCompile(""^(import_)?subnet$"")
++	computeServiceAccountPattern = regexp.MustCompile(""compute_service_account"")
++)
++
+ // ApplyAndValidateVars is a WorkflowHook that applies vars to a daisy workflow.
+ // To ensure consistency across worker instances, if vars omits network, subnet, or the
+ // compute service account, the modifier will automatically apply these values.",networkVarPattern (etc) then?,"I'm not sure if this is the best way to do this, but I'm not sure if there's a better"
+6188,"@@ -138,8 +138,10 @@ module RSpec
+ 
+         # don't clone the example group because the new example
+         # must belong to the same example group (not a clone).
++        #
++        # block is nil in new_metadata so we have to get it from metadata.
+         Example.new(example_group, description.clone,
+-                    new_metadata, new_metadata[:block])
++                    new_metadata, metadata[:block])
+       end
+ 
+       # @private","I think it makes sense to do `metadata[:block].clone`, as thats what `new_metadata` is, but somehow it's missing the block from its clone.",I don't think this is the right place to do this. The example group should not have a block.
+6189,"@@ -51,10 +51,12 @@ class ClosureAnalyzer extends FunctionLikeAnalyzer
+      */
+     public function getClosureId(): string
+     {
+-        return strtolower($this->getFilePath())
+-            . ':' . $this->function->getLine()
+-            . ':' . (int)$this->function->getAttribute('startFilePos')
+-            . ':-:closure';
++        return strtolower(
++            $this->getFilePath()
++                . ':' . $this->function->getLine()
++                . ':' . (int)$this->function->getAttribute('startFilePos')
++                . ':-:closure'
++        );
+     }
+ 
+     /**",Just realized this should be fixed instead of changing here. Concatenating int should still result in lowercase string.,Please revert this change.
+6190,"@@ -79,7 +79,7 @@ module Selenium
+             opts[:browser_version] = opts.delete(:version) if opts.key?(:version)
+             opts[:platform_name] = opts.delete(:platform) if opts.key?(:platform)
+ 
+-            new({browser_name: 'firefox'}.merge(opts))
++            new({browser_name: 'firefox', marionette: true}.merge(opts))
+           end
+ 
+           alias_method :ff, :firefox",For Se 3.x we shouldn't need to specify `marionette: true`? I'll see if I can figure out where this is getting used that it might be necessary here.,I think this should be `marionette: false`
+6191,"@@ -34,14 +34,14 @@ func initStoreTest(ctx context.Context, t *testing.T, dstP *DefaultSyncerTestPar
+ 	requireSetTestChain(t, con, true, dstP)
+ }
+ 
+-func newChainStore(dstP *DefaultSyncerTestParams) chain.Store {
++func newChainStore(dstP *DefaultSyncerTestParams) *chain.DefaultStore {
+ 	r := repo.NewInMemoryRepo()
+ 	ds := r.Datastore()
+ 	return chain.NewDefaultStore(ds, dstP.genCid)
+ }
+ 
+ // requirePutTestChain adds all test chain tipsets to the passed in chain store.
+-func requirePutTestChain(t *testing.T, chainStore chain.Store, dstP *DefaultSyncerTestParams) {
++func requirePutTestChain(t *testing.T, chainStore *chain.DefaultStore, dstP *DefaultSyncerTestParams) {
+ 	ctx := context.Background()
+ 	genTsas := &chain.TipSetAndState{
+ 		TipSet:          dstP.genTS,","This should be renamed to `chain.Store`. It was named `DefaultStore` as an alternative to `StoreImpl`, which is the (bad) Java convention.",`chainStore` is unused (from `deadcode`)
+6192,"@@ -85,8 +85,12 @@ func (a *AttachDisks) validate(ctx context.Context, s *Step) (errs DError) {
+ 		ad.zone = disk[""zone""]
+ 
+ 		// Register disk attachments.
+-		errs = addErrs(errs, s.w.instances.w.disks.regAttach(ad.Source, ad.Instance, ad.Mode, s))
+-
++		// If device name is not given explicitly, its device name will be the same as disk name.
++		deviceName := ad.Source
++		if ad.DeviceName != """" {
++			deviceName = ad.DeviceName
++		}
++		errs = addErrs(errs, s.w.instances.w.disks.regAttach(deviceName, ad.Source, ad.Instance, ad.Mode, s))
+ 	}
+ 	return errs
+ }","ad.Source is disk name? Shouldn't the order of initialization be reversed here then? First set ad.DeviceName, if it's empty, set ad.Source? Or this is a different use case? This is the third place where this device/disk default logic is implemented, so another reason to move it to regAttach, if it's possible to be generalized.","I don't think this is correct. If the device name is not given explicitly, it will be the same as the disk name."
+6193,"@@ -26,6 +26,11 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         [Output]
+         public ITaskItem[] PackageInfos { get; set; }
+ 
++        /// <summary>
++        /// Specify max number of minutes that the lock of the feed container will be hold.
++        /// </summary>
++        public int FeedLockTimeoutMinutes { get; set; } = int.MaxValue;
++
+         public override bool Execute()
+         {
+             return ExecuteAsync().GetAwaiter().GetResult();","typo: ""be hold"" -> ""be held""",Should this be configurable?
+6194,"@@ -44,10 +44,10 @@ namespace Nethermind.Blockchain.Receipts
+ 
+         public long? LowestInsertedReceiptBlockNumber
+         {
+-            get => long.MaxValue;
++            get => 1;
+             set { }
+         }
+ 
+         public long MigratedBlockNumber { get; set; } = 0;
+     }
+-}
++}",I do not think we should have any logic inside the null storage. 1 has a very specific magical meaning. We should either return null here or long.maxValue.,Why did you change this?
+6195,"@@ -397,7 +397,7 @@ func TestInitProcessEnabled(t *testing.T) {
+ 	}
+ 	agent := RunAgent(t, nil)
+ 	defer agent.Cleanup()
+-	agent.RequireVersion("">=1.14.5"")
++	agent.RequireVersion("">=1.15.0"")
+ 
+ 	td, err := GetTaskDefinition(""init-process"")
+ 	if err != nil {",Why did this change?,This should be 1.15.0
+6196,"@@ -168,7 +168,6 @@ class PlansController < ApplicationController
+     render('/phases/edit', locals: {
+       base_template_org: phase.template.base_org,
+       plan: plan, phase: phase, readonly: readonly,
+-      question_guidance: plan.guidance_by_question_as_hash,
+       guidance_groups: guidance_groups,
+       answers: answers,
+       guidance_service: GuidanceService.new(plan) })","Removed this method. Doesn't seem to be used in the code, and the variable set here doesn't seem to be used in the views.",I think we can remove the `guidance_by_question_as_hash` method as well.
+6197,"@@ -16,7 +16,12 @@ namespace Microsoft.CodeAnalysis.Sarif
+     {
+         internal const string DEFAULT_POLICY_NAME = ""default"";
+ 
+-        public PropertyBagDictionary() : base() { }
++        public PropertyBagDictionary() : this(null) { }
++
++        public PropertyBagDictionary(PropertyBagDictionary initializer) :
++            this(initializer, null)
++        {
++        }
+ 
+         public PropertyBagDictionary(
+             PropertyBagDictionary initializer = null,","Remove the initializers (""`= null`"") from both parameters. Remember that that's why we added the overloads: to ensure that all languages could have the convenience of the abbreviated argument lists (not all languages understand default parameters).",Why do we need this constructor?
+6198,"@@ -0,0 +1,13 @@
++package values
++
++import (
++	""github.com/influxdata/flux/semantic""
++)
++
++type Vector interface {
++	Value
++	ElementType() semantic.MonoType
++	Get(i int) Value
++	Set(i int, value Value)
++	Len() int
++}","I think you can just remove most of these attributes outside of `ElementType()`. Instead, this should expose the arrow array. We're not going to use these methods anyway.",Why do we need this interface?
+6199,"@@ -5,8 +5,7 @@ import { enqueueRender } from '../render-queue';
+ import { getNodeProps } from './index';
+ import { diff, mounts, diffLevel, flushMounts, recollectNodeTree, removeChildren } from './diff';
+ import { createComponent, collectComponent } from './component-recycler';
+-
+-
++import remove from './remove';
+ 
+ /** Set a component's `props` (generally derived from JSX attributes).
+  *	@param {Object} props",Thinking this should be `removeNode()` exported from `dom/index.js`. Thoughts?,Why is this change needed?
+6200,"@@ -125,6 +125,10 @@ type Task struct {
+ 	// ENI is the elastic network interface specified by this task
+ 	ENI     *ENI
+ 	eniLock sync.RWMutex
++
++	// memoryCPULimitsEnabled to determine if task supports CPU, memory limits
++	memoryCPULimitsEnabled     bool
++	memoryCPULimitsEnabledLock sync.RWMutex
+ }
+ 
+ // PostUnmarshalTask is run after a task has been unmarshalled, but before it has been",Does this need to be saved in the state file? Or are we recomputing when the task is read from the state file?,Why do we need this lock?
+6201,"@@ -503,11 +503,11 @@ func (s *Sublist) Stats() *SublistStats {
+ 	st := &SublistStats{}
+ 	st.NumSubs = s.count
+ 	st.NumCache = uint32(len(s.cache))
+-	st.NumInserts = s.inserts
+-	st.NumRemoves = s.removes
+-	st.NumMatches = s.matches
+-	if s.matches > 0 {
+-		st.CacheHitRate = float64(s.cacheHits) / float64(s.matches)
++	st.NumInserts = atomic.LoadUint64(&s.inserts)
++	st.NumRemoves = atomic.LoadUint64(&s.removes)
++	st.NumMatches = atomic.LoadUint64(&s.matches)
++	if st.NumMatches > 0 {
++		st.CacheHitRate = float64(atomic.LoadUint64(&s.cacheHits)) / float64(st.NumMatches)
+ 	}
+ 	// whip through cache for fanout stats
+ 	tot, max := 0, 0","Looks like `s.inserts` and `s.removes` are updated under sublist's lock, so I don't think you need atomic for those 2.",Why do we need atomic her
+6202,"@@ -39,7 +39,10 @@ void setUseStaticIP(bool enabled) {
+ 
+ void markGotIP() {
+   lastGetIPmoment = millis();
++  // Create the 'got IP event' so mark the wifiStatus to not have the got IP flag set
++  // This also implies the services are not fully initialized.
+   wifiStatus     &= ~ESPEASY_WIFI_GOT_IP;
++  wifiStatus     &= ~ESPEASY_WIFI_SERVICES_INITIALIZED;
+   processedGotIP = false;
+ }
+ ","@TD-er use bitRead/bitWrite macros, do you use here inversed logic?",Shouldn't this be `&&` in
+6203,"@@ -19,11 +19,11 @@
+ /**
+  * External dependencies
+  */
++import fetchMock from 'fetch-mock-jest';
+ 
+ /**
+  * WordPress dependencies
+  */
+-import apiFetch from '@wordpress/api-fetch';
+ import { createRegistry } from '@wordpress/data';
+ 
+ /**",The previous `fetch` mock was exposed globally before - can we do the same with `fetchMock` so we don't need to import it in every file?,Why was this removed?
+6204,"@@ -29,9 +29,9 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+             HttpRequestHeaders headers,
+             Http2Stream context)
+         {
+-            if (!context.ExpectData)
++            if (context.EndStreamReceived)
+             {
+-                return MessageBody.ZeroContentLengthClose;
++                return ZeroContentLengthClose;
+             }
+ 
+             return new ForHttp2(context);",Is ExpectData still used anywhere?,Why is this change needed?
+6205,"@@ -230,7 +230,7 @@ class Docstring:
+ 
+ class SphinxDocstring(Docstring):
+     re_type = r""""""
+-        [~!]?                # Optional link style prefix
++        [~!.]?               # Optional link style prefix
+         \w(?:\w|\.[^\.])*    # Valid python name
+         """"""
+ ","Do you want to allow the character `.` or any character? Because inside a regex `.` means any character, if you want to authorize `.` then you need to add `\.` .",Why this change?
+6206,"@@ -711,4 +711,18 @@ describe('QueryCursor', function() {
+       assert.deepEqual(arr, ['KICKBOXER', 'IP MAN', 'ENTER THE DRAGON']);
+     });
+   });
++  it('returns array for schema hooks gh-9982', () => {
++    const testSchema = new mongoose.Schema({ name: String });
++    testSchema.post('find', (result) => {
++      assert.ok(Array.isArray(result));
++    });
++    const Movie = db.model('Movie', testSchema);
++    return co(function*() {
++      yield Movie.deleteMany({});
++      yield Movie.create({ name: 'Daniel' }, { name: 'Val' }, { name: 'Daniel' });
++      yield Movie.find({ name: 'Daniel' }).cursor().eachAsync(doc => {
++        assert.ok(Array.isArray(doc));
++      });
++    });
++  });
+ });","`eachAsync()` should pass a doc, not an array of docs, to the callback. This would be a massive breaking change.",You can use `assert.isArra
+6207,"@@ -323,11 +323,11 @@ func (uc *UpstreamController) updatePodStatus(stop chan struct{}) {
+ 				}
+ 
+ 			default:
+-				klog.Infof(""pod status operation: %s unsupported"", msg.GetOperation())
++				klog.Warningf(""pod status operation: %s unsupported"", msg.GetOperation())
+ 			}
+-			klog.Infof(""message: %s process successfully"", msg.GetID())
++			klog.V(4).Infof(""message: %s process successfully"", msg.GetID())
+ 		case <-stop:
+-			klog.Info(""stop updatePodStatus"")
++			klog.Warning(""stop updatePodStatus"")
+ 			running = false
+ 		}
+ 	}",please start log with caps letters,Why is this a warning?
+6208,"@@ -10,4 +10,5 @@
+ <%= render 'layouts/typekit' %>
+ <%= csrf_meta_tag %>
+ <%= render 'layouts/ie_shiv' %>
++<%= render 'layouts/visual_website_optimizer' %>
+ <%= yield :head %>",Is this where we want it in relation to the other scripts?,<%= render 'layouts/visual_website_optimizer' %>
+6209,"@@ -13,6 +13,7 @@
+     _,
+     T
+  */
++ var FEATURE_NAME = ""reports"";
+ 
+ window.ReportingView = countlyView.extend({
+     featureName: 'reports',","Please wrap this variable within a self invoking anonymous function. (function(){ FEATURE_NAME = ""reports""; //and rest of the js goes here. })();",Why do we need this?
+6210,"@@ -393,6 +393,14 @@ func (c *linuxContainer) Signal(s os.Signal, all bool) error {
+ 		if err := c.initProcess.signal(s); err != nil {
+ 			return fmt.Errorf(""unable to signal init: %w"", err)
+ 		}
++		if status == Paused {
++			// For cgroup v1, killing a process in a frozen cgroup
++			// does nothing until it's thawed. Only thaw the cgroup
++			// for SIGKILL.
++			if s, ok := s.(unix.Signal); ok && s == unix.SIGKILL {
++				_ = c.cgroupManager.Freeze(configs.Thawed)
++			}
++		}
+ 		return nil
+ 	}
+ 	return ErrNotRunning","Haven't tried, but what happens currently if `-f` is used and it's not running? (thinking: `-f` should ignore the case and just proceed?) I see we have a special case for `all`",I don't think we need to check for `ok` here. If
+6211,"@@ -1,10 +1,11 @@
+ 'use strict';
+ const { MongoClient } = require('../../src');
+ const { expect } = require('chai');
++const { MongoURIError } = require('../../src/error');
+ 
+ describe('LDAP', function () {
+   if (process.env.MONGODB_URI == null) {
+-    throw new Error(`skipping SSL tests, MONGODB_URI environment variable is not defined`);
++    throw new MongoURIError(`skipping SSL tests, MONGODB_URI environment variable is not defined`);
+   }
+ 
+   it('Should correctly authenticate against ldap', function (done) {",no need for custom errors in tests unless the tests are intended to mock a specific sort of error,Why is this change needed?
+6212,"@@ -21,4 +21,6 @@ const (
+ 	NvidiaGPUStatusAnnotationKey = ""huawei.com/gpu-status""
+ 	// NvidiaGPUScalarResourceName is the device plugin resource name used for special handling
+ 	NvidiaGPUScalarResourceName = ""nvidia.com/gpu""
++
++	EdgeNodeRoleLabelKey = ""node-role.kubernetes.io/edge""
+ )","This const has already existed in the code, no need to define a new one",I think this should be `node-role.kubernetes.io`
+6213,"@@ -362,7 +362,7 @@ func captureErrorLogs(algohConfig algoh.HostConfig, errorOutput stdCollector, ou
+ 
+ func reportErrorf(format string, args ...interface{}) {
+ 	fmt.Fprintf(os.Stderr, format, args...)
+-	logging.Base().Fatalf(format, args...)
++	logging.Base().Warnf(format, args...)
+ }
+ 
+ func sendLogs() {",Would Errorf be better than Warnf?,Why did you change this?
+6214,"@@ -93,15 +93,16 @@ public class JSExport {
+   }
+ 
+   public static String getCordovaPluginJS(Context context) {
+-    return getFilesContent(context, ""public/plugins"", """");
++    return getFilesContent(context, ""public/plugins"");
+   }
+ 
+-  public static String getFilesContent(Context context, String path, String currentContent) {
++  public static String getFilesContent(Context context, String path) {
++    String currentContent = """";
+     try {
+       String[] content = context.getAssets().list(path);
+       if (content.length  > 0) {
+         for (String file: content) {
+-          currentContent += getFilesContent(context, path+""/""+file, currentContent);
++          currentContent += getFilesContent(context, path+""/""+file);
+         }
+       } else {
+         return getJS(context, path);","A good candidate for StringBuilder? Also make sure to add white space around the operators (`path + ""/"" + file`)",Why did you remove the second parameter?
+6215,"@@ -200,4 +200,17 @@ public interface ProjectLoader {
+       throws ProjectManagerException;
+ 
+   void updateProjectSettings(Project project) throws ProjectManagerException;
++
++  /**
++   * Uploads flow file.
++   */
++  void uploadFlowFile(int projectId, int projectVersion, int flowVersion,
++      File flowFile) throws ProjectManagerException;
++
++  /**
++   * Gets flow file that's uploaded.
++   */
++  File getUploadedFlowFile(int projectId, int projectVersion, String flowName, int
++      flowVersion) throws ProjectManagerException;
++
+ }",Can we have the same argument order as `getUploadedFlowFile`?,Why do we need this method?
+6216,"@@ -46,7 +46,7 @@ type (
+ 		RangeSize                    int64
+ 		GetTasksBatchSize            dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters
+ 		UpdateAckInterval            dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
+-		IdleTaskqueueCheckInterval   dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
++		IdleTaskqueueCheckInterval   dynamicconfig.DurationPropertyFn
+ 		MaxTaskqueueIdleTime         dynamicconfig.DurationPropertyFnWithTaskQueueInfoFilters
+ 		NumTaskqueueWritePartitions  dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters
+ 		NumTaskqueueReadPartitions   dynamicconfig.IntPropertyFnWithTaskQueueInfoFilters","this dynamic config should still be valid, i.e. operator should have the ability to control each individual task queue just in case",Why do we need this change?
+6217,"@@ -394,6 +394,17 @@ class VirtualBufferTextInfo(browseMode.BrowseModeDocumentTextInfo,textInfos.offs
+ 		obj = self.obj.getNVDAObjectFromIdentifier(docHandle, nodeId)
+ 		return obj.mathMl
+ 
++	def scrollIntoView(self):
++		# Scroll the deepest object at this point into view.
++		obj = self.NVDAObjectAtStart
++		if not obj:
++			return
++		if obj == self.obj.rootNVDAObject:
++			# However never scroll to the  document itself
++			return
++		obj.scrollIntoView()
++
++
+ class VirtualBuffer(browseMode.BrowseModeDocumentTreeInterceptor):
+ 
+ 	TextInfo=VirtualBufferTextInfo",Should these cases be logged? `if not obj` used to be,Why do we need this?
+6218,"@@ -0,0 +1,19 @@
++require 'travis/build/appliances/base'
++
++module Travis
++  module Build
++    module Appliances
++      class UpdateAptKeys < Base
++        def apply
++          command = <<-EOF
++          if command -v apt-get &>/dev/null && [[ -d /var/lib/apt/lists ]]; then
++            LANG=C apt-key list | awk -F'[ /]+' '/expired:/{printf ""apt-key adv --recv-keys --keyserver keys.gnupg.net %s\\n"", $3}' | sudo sh &>/dev/null
++          fi
++          EOF
++          sh.cmd command, echo: false
++        end
++      end
++    end
++  end
++end
++",Is it OK to assume that keys.gnupg.net has the new key?,I think this should be `apt
+6219,"@@ -128,11 +128,6 @@ class FileSystem(object):
+                              exist, raise luigi.target.MissingParentDirectory
+         :param bool raise_if_exists: raise luigi.target.FileAlreadyExists if
+                                      the folder already exists.
+-
+-        *Note*: This method is optional, not all FileSystem subclasses implements it.
+-
+-        *Note*: parents and raise_if_exists were added in August 2014. Some
+-                implementations might not support these flags yet.
+         """"""
+         raise NotImplementedError(""mkdir() not implemented on {0}"".format(self.__class__.__name__))
+ ","A note for however is curious. I think these two notes add negative value only. In general we want people to implement this method (in particular after this patch). If we leave these old (and currently mis-rendered) notes, file system implementors might not implement this method referring to this.",Why was this removed?
+6220,"@@ -216,15 +216,12 @@ public class PriorityQueueTest extends AbstractTraversableTest {
+         empty().dequeue();
+     }
+ 
+-    // -- toSortedQueue
++    // -- toPriorityQueue
+ 
+     @Test
+-    public void shouldKeepInstanceOfSortedQueue() {
+-        final SerializableComparator<Integer> comparator = naturalComparator();
+-        final PriorityQueue<Integer> queue = PriorityQueue.of(comparator, 1, 3, 2);
+-        if (!queue.isSingleValued()) {
+-            assertThat(queue.toSortedQueue(comparator)).isSameAs(queue);
+-        }
++    public void shouldKeepInstanceOfPriorityQueue() {
++        final PriorityQueue<Integer> queue = PriorityQueue.of(1, 3, 2);
++        assertThat(queue.toPriorityQueue()).isSameAs(queue);
+     }
+ 
+     // -- property based tests","Comparators (or functions in general) cannot be compared for equality. Therefore `PriorityQueue.of(comparator, ...)` always has to return a new instance.",Why did you remove this test?
+6221,"@@ -27,7 +27,7 @@ module Bolt
+ 
+       @noop = noop
+       @run_as = nil
+-      @pool = Concurrent::CachedThreadPool.new(max_threads: @config[:concurrency])
++      @pool = Concurrent::ThreadPoolExecutor.new(max_threads: @config[:concurrency])
+       @logger.debug { ""Started with #{@config[:concurrency]} max thread(s)"" }
+       @notifier = Bolt::Notifier.new
+     end",It's a little surprising that CachedThreadPool overrides the max_threads argument. This makes sense as a solution though.,I think this should be `Concu
+6222,"@@ -42,12 +42,14 @@ def weight_reduce_loss(loss, weight=None, reduction='mean', avg_factor=None):
+     # if avg_factor is not specified, just reduce the loss
+     if avg_factor is None:
+         loss = reduce_loss(loss, reduction)
+-    # otherwise average the loss by avg_factor
+-    else:
+-        if reduction != 'mean':
+-            raise ValueError(
+-                'avg_factor can only be used with reduction=""mean""')
++    # if avg_factor are specified
++    # if reduction is mean, reduce the loss sum by avg factor
++    elif reduction == 'mean':
+         loss = loss.sum() / avg_factor
++    elif reduction == 'none':
++        loss = loss
++    else:
++        raise ValueError('avg_factor can not be used with reduction=""sum""')
+     return loss
+ 
+ ","```python # if avg_factor is not specified, just reduce the loss if avg_factor is None: loss = reduce_loss(loss, reduction) else: # if reduction is mean, then average the loss by avg_factor if reduction == 'mean': loss = loss.sum() / avg_factor # if reduction is 'none', then do nothing, otherwise raise an error elif reduction != 'none': raise ValueError('avg_factor can not be used with reduction=""sum""')",I don't think this is the rig
+6223,"@@ -46,9 +46,9 @@ class BasicBlock(nn.Module):
+             planes,
+             planes,
+             3,
+-            stride=stride,
+-            padding=dilation,
+-            dilation=dilation,
++            stride=1,
++            padding=1,
++            dilation=1,
+             bias=False)
+         self.add_module(self.norm2_name, norm2)
+ ",`padding` should be 0 instead. Actually you can just remove padding and dilation to use default values.,Why did you change this?
+6224,"@@ -1447,7 +1447,7 @@ class Aleph extends AbstractBase implements \Laminas\Log\LoggerAwareInterface,
+             $checkout = $finesListSort[$key][""checkout""];
+             $transactiondate = $finesListSort[$key][""transactiondate""];
+             $transactiontype = $finesListSort[$key][""transactiontype""];
+-            $balance += $finesListSort[$key][""amount""];
++            $balance = $finesListSort[$key][""amount""];
+             $id = $finesListSort[$key][""id""];
+             $fine = $finesListSort[$key][""fine""];
+             $finesList[] = [","$balance is initialized to 0 above in line 1428 and then assigned in line 1437. If we're no longer manipulating that value, is there a reason to use a variable at all? It might make the overall code less confusing to make some changes there.",Why did you change this?
+6225,"@@ -73,9 +73,9 @@ class SeriesPlotTest(ReusedSQLTestCase, TestUtils):
+         pdf = self.pdf1
+         kdf = self.kdf1
+ 
+-        ax1 = pdf['a'].plot(""bar"", colormap='Paired')
++        ax1 = pdf['a'].plot(kind=""bar"", colormap='Paired')
+         bin1 = self.plot_to_base64(ax1)
+-        ax2 = kdf['a'].plot(""bar"", colormap='Paired')
++        ax2 = kdf['a'].plot(kind=""bar"", colormap='Paired')
+         bin2 = self.plot_to_base64(ax2)
+         self.assertEqual(bin1, bin2)
+ ",Why do we need to explicitly use keyword arguments?,Why did you change this?
+6226,"@@ -708,7 +708,8 @@ func (c *Client) updateProgress(tid int, target *core.BuildTarget, metadata *pb.
+ 		case pb.ExecutionStage_EXECUTING:
+ 			c.state.LogBuildResult(tid, target.Label, core.TargetBuilding, ""Building..."")
+ 		case pb.ExecutionStage_COMPLETED:
+-			c.state.LogBuildResult(tid, target.Label, core.TargetBuilt, ""Built"")
++			// The build result will be logged in build/build_step.go
++			return
+ 		}
+ 	} else {
+ 		switch metadata.Stage {",Might still want to log this as `TargetBuilding` but with a slightly different message?,I don't think this is co
+6227,"@@ -6,6 +6,17 @@
+ 
+ C015_queue_element::C015_queue_element() {}
+ 
++C015_queue_element::C015_queue_element(C015_queue_element&& other)
++  : idx(other.idx), _timestamp(other._timestamp), TaskIndex(other.TaskIndex)
++  , controller_idx(other.controller_idx), valuesSent(other.valuesSent)
++  , valueCount(other.valueCount)
++{
++  for (byte i = 0; i < VARS_PER_TASK; ++i) {
++    txt[i]  = std::move(other.txt[i]);
++    vPin[i] = other.vPin[i];
++  }
++}
++
+ C015_queue_element::C015_queue_element(const struct EventStruct *event, byte value_count) :
+   idx(event->idx),
+   TaskIndex(event->TaskIndex),","ref. above, this also can be omitted in case `txt = std::move(other.txt);` could work (or copy), consider `std::array<String, VARS_PER_TASK>;`? or a custom object implementing `Object& operator=(Object&&) noexcept;'",I don't think we need th
+6228,"@@ -10,7 +10,7 @@
+ 
+ """"""Looks for try/except statements with too much code in the try clause.""""""
+ 
+-from astroid.node_classes import For, If, While, With
++from astroid import nodes
+ 
+ from pylint import checkers, interfaces
+ ","Well done, we forget that one apparentely.",Why did you change this?
+6229,"@@ -25,17 +25,6 @@ except:
+     xr = None
+ 
+ 
+-def toarray(v, index_value=False):
+-    """"""
+-    Interface helper function to turn dask Arrays into numpy arrays as
+-    necessary. If index_value is True, a value is returned instead of
+-    an array holding a single value.
+-    """"""
+-    if dask and isinstance(v, dask.array.Array):
+-        arr =  v.compute()
+-        return arr[()] if index_value else arr
+-    else:
+-        return v
+ 
+ def compute_edges(edges):
+     """"""",Guess it isn't used. The dask thing was just a prototype so removing it is probably the right thing to do.,This function is no long
+6230,"@@ -12,7 +12,17 @@ from elasticsearch.helpers import bulk
+ from t4_lambda_shared.preview import ELASTIC_LIMIT_BYTES
+ 
+ 
+-CONTENT_INDEX_EXTS = [
++def _get_extension_overrides():
++    """"""check the environment for index extension overrides; this is a standalone
++    function so that it can be unit tested""""""
++    return {
++        t.strip().lower()
++        for t in os.getenv(""CONTENT_INDEX_EXTS"", """").split("","")
++        if t.strip().startswith(""."")
++    }
++
++
++CONTENT_INDEX_EXTS = _get_extension_overrides() or {
+     "".csv"",
+     "".ipynb"",
+     "".md"",","This code is correct, but it's a bit confusing to see how (e.g., without the if startswith("".') the or below would break.) I think it will be clearer for the long run if you refactor this just a bit. CONTENT_INDEX_EXTS (all caps) looks like a constant, but is now being set by the environment. Instead, replace the reference to CONTENT_INDEX_EXTS in index.py with a simple call to a method ""get_content_index_exts"" (or similar). Then you can write all the logic into one clean function.",I'm not sure if this is 
+6231,"@@ -298,4 +298,9 @@ public final class ZMSConsts {
+     public static final int ZMS_DISABLED_AUTHORITY_FILTER = 0x01;
+ 
+     public static final String ZMS_PROP_STATUS_CHECKER_FACTORY_CLASS = ""athenz.zms.status_checker_factory_class"";
++
++    public static final String ZMS_PROP_ENABLE_PRINCIPAL_STATE_UPDATER        = ""athenz.zms.enable_principal_state_updater"";
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY = ""athenz.zms.principal_state_updater_frequency"";
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_FREQUENCY_DEFAULT = ""30""; // in minutes
++    public static final String ZMS_PROP_PRINCIPAL_STATE_UPDATER_DISABLE_TIMER = ""athenz.zms.disable_principal_state_updater_timer_task"";
+ }",please update the zms conf file to have a small description of these options since by default feature is off and must be enabled,This should be `ZMS_PROP
+6232,"@@ -31,7 +31,12 @@ module.exports = class ThumbnailGenerator extends Plugin {
+     const defaultOptions = {
+       thumbnailWidth: null,
+       thumbnailHeight: null,
+-      waitForThumbnailsBeforeUpload: false
++      waitForThumbnailsBeforeUpload: false,
++      lazy: false
++    }
++
++    if (defaultOptions.lazy && defaultOptions.waitForThumbnailsBeforeUpload) {
++      throw new Error('ThumbnailGenerator: The `lazy` and `waitForThumbnailsBeforeUpload` options are mutually exclusive. Please ensure at most one of them is set to `true`.')
+     }
+ 
+     this.opts = { ...defaultOptions, ...opts }",Should be `this.opts` instead of `defaultOptions`,I think this should be `throw new Error('ThumbnailGenerator: The `waitForThumbnailsBeforeUpload` options are mutually exclusive. Please ensure at most one of them is set to `true`.')`
+6233,"@@ -27,6 +27,7 @@ const pkgVersion = module.exports.version;
+ const pkgName = module.exports.name;
+ 
+ export const DIST_TAGS = 'dist-tags';
++export const USERS = 'users';
+ 
+ export function getUserAgent(): string {
+   assert(_.isString(pkgName));",You can reuse `USERS` above as well.,export const USERS = 'users';
+6234,"@@ -460,11 +460,6 @@ public final class Util {
+           continue;
+         }
+ 
+-        if (results.size() == topN-1 && maxQueueDepth == topN) {
+-          // Last path -- don't bother w/ queue anymore:
+-          queue = null;
+-        }
+-
+         // We take path and find its ""0 output completion"",
+         // ie, just keep traversing the first arc with
+         // NO_OUTPUT that we can find, since this must lead","Whoa, was this opto breaking something? I guess if this final path is filtered out, we still need the queue? Have you run the suggest benchmarks to see if removing this opto hurt performance?",Why is this removed?
+6235,"@@ -191,7 +191,7 @@ final class Collections {
+         if (iterable instanceof Seq) {
+             return (Seq<T>) iterable;
+         } else {
+-            return List.ofAll(iterable);
++            return Stream.ofAll(iterable);
+         }
+     }
+ }","I'm not sure about this, please check the usages. It's only used currently to reverse it, maybe we should eliminate this method completely instead.",Why is this change needed?
+6236,"@@ -638,6 +638,18 @@ class AbstractBase extends AbstractActionController
+         return $check->getTagSetting() !== 'disabled';
+     }
+ 
++    /**
++     * Are list tags enabled?
++     *
++     * @return bool
++     */
++    protected function listTagsEnabled()
++    {
++        $check = $this->serviceLocator
++            ->get(\VuFind\Config\AccountCapabilities::class);
++        return $check->getListTagSetting() === 'enabled';
++    }
++
+     /**
+      * Store a referer (if appropriate) to keep post-login redirect pointing
+      * to an appropriate location. This is used when the user clicks the","Since this is only used in the MyResearchController, does it need to be placed at the AbstractBase level?",I'm not sure if this is the best way to check if the list tags are enabled.
+6237,"@@ -55,7 +55,7 @@ type SelectorSpec struct {
+ 	// +optional
+ 	AnnotationSelectors map[string]string `json:""annotationSelectors,omitempty""`
+ 
+-	// PodPhaseSelector is a set of condition of a pod at the current time.
++	// PhaseSelector is a set of condition of a pod at the current time.
+ 	// supported value: Pending / Running / Succeeded / Failed / Unknown
+ 	PodPhaseSelectors []string `json:""phaseSelector,omitempty""`
+ }",why `PhaseSelector` ?,I think this should be `// +optional`
+6238,"@@ -32,6 +32,8 @@ type rawConfig struct {
+ 	RestrictedLicenses []string `json:""restricted_licenses""`
+ 
+ 	// modules that get completely ignored during analysis
++	AllowlistedModules []string `json:""allowlisted_modules""`
++	// Deprecated. TODO(tbarrella): Clean up
+ 	WhitelistedModules []string `json:""whitelisted_modules""`
+ }
+ ",Does` AllowlistedModules` have the same meaning of `WhitelistedModules`?,I'm not sure we need to deprecate this.
+6239,"@@ -357,7 +357,7 @@ return [
+ 'ArithmeticError::getTrace' => ['array<int,array<string,mixed>>'],
+ 'ArithmeticError::getTraceAsString' => ['string'],
+ 'array_change_key_case' => ['array|false', 'input'=>'array', 'case='=>'int'],
+-'array_chunk' => ['array[]', 'input'=>'array', 'size'=>'int', 'preserve_keys='=>'bool'],
++'array_chunk' => ['list<array>', 'input'=>'array', 'size'=>'int', 'preserve_keys='=>'bool'],
+ 'array_column' => ['array', 'array'=>'array', 'column_key'=>'mixed', 'index_key='=>'mixed'],
+ 'array_combine' => ['array|false', 'keys'=>'string[]|int[]', 'values'=>'array'],
+ 'array_count_values' => ['int[]', 'input'=>'array'],","I missed the $preserve_keys=true case when adding this to Phan. For psalm, two separate signatures may make sense",Shouldn't this be `array|false`?
+6240,"@@ -18,14 +18,19 @@
+ package org.apache.servicecomb.foundation.vertx.server;
+ 
+ import java.net.InetSocketAddress;
++import java.util.concurrent.atomic.AtomicInteger;
+ 
++import org.apache.servicecomb.foundation.common.event.EventManager;
+ import org.apache.servicecomb.foundation.common.net.URIEndpointObject;
+ import org.apache.servicecomb.foundation.ssl.SSLCustom;
+ import org.apache.servicecomb.foundation.ssl.SSLOption;
+ import org.apache.servicecomb.foundation.ssl.SSLOptionFactory;
+ import org.apache.servicecomb.foundation.vertx.AsyncResultCallback;
++import org.apache.servicecomb.foundation.vertx.ClientConnectedEvent;
+ import org.apache.servicecomb.foundation.vertx.VertxTLSBuilder;
+ 
++import com.netflix.config.DynamicPropertyFactory;
++
+ import io.vertx.core.Vertx;
+ import io.vertx.core.net.NetServer;
+ import io.vertx.core.net.NetServerOptions;",TcpServer will be created for each HighwayServerVerticle instance so the counter number in server is not correct.,Why is this import needed?
+6241,"@@ -109,10 +109,14 @@ public class WindowsUtils {
+      * quote (\""?)
+      */
+     // TODO We should be careful, in case Windows has ~1-ified the executable name as well
+-    pattern.append(""\""?.*?\\\\"");
+-    pattern.append(executable.getName());
++    pattern.append(""(\""?.*?\\\\)?"");
++    String execName = executable.getName();
++    pattern.append(execName);
++    if (!execName.endsWith("".exe"")) {
++      pattern.append(""(\\.exe)?"");
++    }
+     pattern.append(""\""?"");
+-    for (String arg : cmdarray) {
++    for (int i = 1; i < cmdarray.length; i++) {
+       /*
+        * There may be a space, but maybe not (\\s?), may be a quote or maybe not (\""?), but then
+        * turn on block quotation (as if *everything* had a regex backslash in front of it) with \Q.",Why change this from a foreach? I can't see it gaining anything here and code styles shouldn't change just for the sake of it.,Why is this needed?
+6242,"@@ -116,6 +116,12 @@ func FindCgroupMountpoint(cgroupPath, subsystem string) (string, error) {
+ 		return """", errUnified
+ 	}
+ 
++	// If subsystem is empty it means that we are looking for the
++	// cgroups2 path
++	if len(subsystem) == 0 {
++		return hybridMountpoint, nil
++	}
++
+ 	// Avoid parsing mountinfo by trying the default path first, if possible.
+ 	if path := tryDefaultPath(cgroupPath, subsystem); path != """" {
+ 		return path, nil","I'd say ""cgroup2 hybrid path"" instead.",I think this should be `if
+6243,"@@ -84,15 +84,12 @@ module Bolt
+       {
+         'name' => name,
+         'uri' => uri,
+-        'alias' => @target_alias,
+-        'config' => config.merge(
+-          'transport' => transport,
+-          transport => options
+-        ),
++        'alias' => target_alias,
++        'config' => Bolt::Util.deep_merge(config, 'transport' => transport, transport => options),
+         'vars' => vars,
+         'features' => features,
+         'facts' => facts,
+-        'plugin_hooks' => Bolt::Util.deep_clone(plugin_hooks)
++        'plugin_hooks' => plugin_hooks
+       }
+     end
+ ",I dont see a reason to print URI for `Target`. we do not expose that in inventory v1,Shouldn't this be `target_
+6244,"@@ -131,9 +131,13 @@ type OpExpression struct {
+ type ValueExpression struct {
+ 	String  string
+ 	FString *FString
+-	Int     *struct {
+-		Int int
+-	} // Should just be *int, but https://github.com/golang/go/issues/23498 :(
++	// These are true if this represents one of the boolean singletons
++	True  bool
++	False bool
++	None  bool
++	// True if the Int field is set; this helps us distinguish values of 0.
++	IsInt    bool
++	Int      int
+ 	Bool     string
+ 	List     *List
+ 	Dict     *Dict",Do we still need this?,Why is this a pointer?
+6245,"@@ -79,9 +79,13 @@ type Application struct {
+ type Gclient struct {
+ 	// constant tracking-id used to send a hit
+ 	trackID string
++
+ 	// anonymous client-id
+ 	clientID string
+ 
++	// anonymous campaign source
++	campaignSource string
++
+ 	// https://developers.google.com/analytics/devguides/collection/protocol/v1/parameters#ds
+ 	// (usecase) node-detail
+ 	dataSource string",`campaignSource` is unused (from `structcheck`),nit: `campaignSource` 
+6246,"@@ -63,6 +63,7 @@ public final class BaselineErrorProne implements Plugin<Project> {
+     private static final Logger log = Logging.getLogger(BaselineErrorProne.class);
+     public static final String EXTENSION_NAME = ""baselineErrorProne"";
+     private static final String ERROR_PRONE_JAVAC_VERSION = ""9+181-r4173-1"";
++    private static final String ASSERTJ_ERROR_PRONE_VERSION = ""0.2.1"";
+     private static final String PROP_ERROR_PRONE_APPLY = ""errorProneApply"";
+     private static final String PROP_REFASTER_APPLY = ""refasterApply"";
+     private static final String DISABLE_PROPERY = ""com.palantir.baseline-error-prone.disable"";",we should discuss how to not hard-code this version,I think this should be
+6247,"@@ -5,8 +5,14 @@ const isResumableError = require('./error').isResumableError;
+ const MongoError = require('./core').MongoError;
+ const ReadConcern = require('./read_concern');
+ const MongoDBNamespace = require('./utils').MongoDBNamespace;
++const Cursor = require('./cursor');
++const relayEvents = require('./core/utils').relayEvents;
++const maxWireVersion = require('./core/utils').maxWireVersion;
+ 
+-var cursorOptionNames = ['maxAwaitTimeMS', 'collation', 'readPreference'];
++const CHANGE_STREAM_OPTIONS = ['resumeAfter', 'startAfter', 'startAtOperationTime', 'fullDocument'];
++const CURSOR_OPTIONS = ['batchSize', 'maxAwaitTimeMS', 'collation', 'readPreference'].concat(
++  CHANGE_STREAM_OPTIONS
++);
+ 
+ const CHANGE_DOMAIN_TYPES = {
+   COLLECTION: Symbol('Collection'),",do we have a doclet for this event?,I don't think we need 
+6248,"@@ -35,10 +35,11 @@ if (isNodeProcess && process.platform === 'win32') {
+ }
+ 
+ // catching segfaults during testing can help debugging
+-if (isNodeProcess) {
+-    const SegfaultHandler = node_require('segfault-handler');
+-    SegfaultHandler.registerHandler(""crash.log"");
+-}
++//uncomment to enable segfault handler
++//if (isNodeProcess) {
++    //const SegfaultHandler = node_require('segfault-handler');
++    //SegfaultHandler.registerHandler(""crash.log"");
++//}
+ 
+ var TESTS = {
+     ListTests: require('./list-tests'),",Why don't we want to catch segfaults by default?,Why is this disabled?
+6249,"@@ -137,6 +137,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+             return result;
+         }
+ 
++        [System.Diagnostics.CodeAnalysis.SuppressMessage(""Reliability"", ""CA2000:Dispose objects before losing scope"", Justification = ""The object should not be disposed"")]
+         private Task SendBatchActivityAsync(IEnumerable<Activity> batchActivity, CancellationToken cancellationToken)
+         {
+             var requestUri = this.options.Endpoint;",You could probably dispose request & content if you `await` the SendAsync.,Why is this needed?
+6250,"@@ -35,6 +35,16 @@ class UtilsTest(ReusedSQLTestCase, SQLTestUtils):
+         }, index=[0, 1, 3])
+         validate_arguments_and_invoke_function(pdf, self.to_html, pd.DataFrame.to_html, args)
+ 
++    def to_clipboard(self, sep=',', **kwargs):
++        args = locals()
++
++        pdf = pd.DataFrame({
++            'a': [1, 2, 3],
++            'b': [4, 5, 6],
++        }, index=[0, 1, 3])
++        validate_arguments_and_invoke_function(pdf, self.to_clipboard,
++                                               pd.DataFrame.to_clipboard, args)
++
+     def test_validate_arguments_and_invoke_function(self):
+         # This should pass and run fine
+         self.to_html()",why is this test case here? this file is for testing functionalities in utils.py,Can you add a docstri
+6251,"@@ -31,6 +31,15 @@ class AuthController < ApplicationController
+   def do_user_auth(auth)
+     sign_out
+     user = User.from_oauth_hash(auth)
++    unless ENV[""NO_WELCOME_EMAIL""]
++      send_welcome_mail(user)
++    end
+     sign_in(user)
+   end
++
++  def send_welcome_mail(user)
++    if (Time.current - user.created_at) < 2.seconds
++      WelcomeMailer.welcome_notification(user).deliver_later
++    end
++  end
+ end",why do we have an env var for this? not sure why we'd want to suppress welcome emails but not any others,I don't think we need
+6252,"@@ -917,7 +917,13 @@ func (p *parser) parseStringExpression() *ast.StringExpression {
+ 			}
+ 		default:
+ 			// TODO bad expression
+-			return nil
++			loc := p.loc(pos, pos+token.Pos(len(lit)))
++			p.errs = append(p.errs, ast.Error{
++				Msg: fmt.Sprintf(""got unexpected token in string expression %s@%d:%d-%d:%d: %s"", loc.File, loc.Start.Line, loc.Start.Column, loc.End.Line, loc.End.Column, tok),
++			})
++			return &ast.StringExpression{
++				BaseNode: p.position(beg, pos+token.Pos(len(lit))),
++			}
+ 		}
+ 	}
+ }",drop the todo?,I think it's better to use `fmt.Errorf` here.
+6253,"@@ -383,7 +383,9 @@ void Doors::HandleClick(Client* sender, uint8 trigger) {
+ 	if (!IsDoorOpen() || (open_type == 58)) {
+ 		if (!disable_timer)
+ 			close_timer.Start();
+-		SetOpenState(true);
++		
++		if(strncmp(destination_zone_name, ""NONE"", strlen(""NONE"")) == 0)
++			SetOpenState(true);
+ 	} else {
+ 		close_timer.Disable();
+ 		if (!disable_timer)",Maybe use { } here like we are most other places now.,I don't think this is the right way to do thi
+6254,"@@ -96,6 +96,7 @@ class PartitionData
+     return schema;
+   }
+ 
++  @Override
+   public Type getType(int pos) {
+     return partitionType.fields().get(pos).type();
+   }","I want to get PartitionData field type, I don't know how to get it in other way.",Why is this needed?
+6255,"@@ -31,6 +31,9 @@ type Balances interface {
+ 	// A non-nil error means the lookup is impossible (e.g., if the database doesn't have necessary state anymore)
+ 	Get(addr basics.Address, withPendingRewards bool) (basics.AccountData, error)
+ 
++	// GetEx is like Get(addr, false), but also loads specific creatable
++	GetEx(addr basics.Address, cidx basics.CreatableIndex, ctype basics.CreatableType) (basics.AccountData, error)
++
+ 	Put(basics.Address, basics.AccountData) error
+ 
+ 	// PutWithCreatable is like Put, but should be used when creating or deleting an asset or application.","I think that a single `Get` method would be preferable, that would have the following parameters: Get(addr basics.Address, withPendingRewards bool, cidx basics.CreatableIndex, ctype basics.CreatableType) where we ignore cidx of -1, and adding support for ctype of ""AssetParams"" or something like that. (i.e. so that this Get call would be good for asset holding/asset params and applications )",I'm not sure if this is the right place to pu
+6256,"@@ -1653,7 +1653,7 @@ char * ExHdfsScanTcb::extractAndTransformAsciiSourceToSqlRow(int &err,
+                   // for non-varchar, length of zero indicates a null value.
+                   // For all datatypes, HIVE_DEFAULT_NULL_STRING('\N') indicates a null value.
+                   if (((len == 0) && (tgtAttr && (NOT DFS2REC::isSQLVarChar(tgtAttr->getDatatype())))) ||
+-                      ((len > 0) && (memcmp(sourceData, HIVE_DEFAULT_NULL_STRING, len) == 0)))
++                      ((len > 1) && (memcmp(sourceData, HIVE_DEFAULT_NULL_STRING, len) == 0)))
+                     {
+                       *(short *)&hdfsAsciiSourceData_[attr->getNullIndOffset()] = -1;
+                     }","This can handle the '\\' problem, but if (not possible) the user define '\\' as null, this logic will break. So here, it should be to compare the whole HIVE_DEFAULT_NULL_STRING, and make sure length is equal, as I understand. \N is NULL, but \NA is not NULL, what will happen if there is \NAA ?",Why is this change needed?
+6257,"@@ -0,0 +1,9 @@
++class ObservationPolicy
++  include ExceptionPolicy
++
++  def can_destroy!
++    role = Role.new(@user, @record.proposal)
++    check(@user.id == @record.user_id || role.client_admin? || @user.admin?,
++          ""Only the observer can delete themself"")
++  end
++end","Hmm, I would think that anyone who can edit the request should be able to delete the observation, in case they accidentally add the wrong person or something.",I don't think you need the
+6258,"@@ -4,13 +4,9 @@ class PublicPagesController < ApplicationController
+   # GET template_index
+   # -----------------------------------------------------
+   def template_index
+-    template_ids = Template.where(org_id: Org.funder.pluck(:id), visibility: Template.visibilities[:publicly_visible]).valid.pluck(:dmptemplate_id).uniq << Template.where(is_default: true, published: true).pluck(:dmptemplate_id)
+-    @templates = []
+-    template_ids.flatten.each do |tid|
+-      t = Template.live(tid)
+-      @templates << t unless t.nil?
+-    end
+-    @templates = @templates.sort{|x,y| x.title <=> y.title } if @templates.count > 1
++    template_ids = Template.families(Org.funder.pluck(:id)).publicly_visible.pluck(:dmptemplate_id) <<
++    Template.where(is_default: true).valid.published.pluck(:dmptemplate_id)
++    @templates = Template.includes(:org).where(dmptemplate_id: template_ids.uniq.flatten).valid.published.order(title: :asc).page(1)
+   end
+ 
+   # GET template_export/:id",I know we are doing this other places already. It would be good to refactor this and the paginable publicly_visible so that we are DRY. Can wait until after MVP though when we do general cleanup,I think you can use `.incl
+6259,"@@ -576,7 +576,12 @@ update_lookuptable_tls(dcontext_t *dcontext, ibl_table_t *table)
+      * crashing or worse.
+      */
+     state->table_space.table[table->branch_type].lookuptable = table->table;
+-    state->table_space.table[table->branch_type].hash_mask = table->hash_mask;
++    /* Perform a Store-Release, which when combined with a Load-Acquire of the mask
++     * in the IBL itself, ensures the prior store to lookuptable is never
++     * observed before this store to hash_mask on weakly ordered arches.
++     */
++    ATOMIC_PTRSZ_ALIGNED_WRITE(&state->table_space.table[table->branch_type].hash_mask,
++                               table->hash_mask, false);
+ }
+ 
+ #ifdef DEBUG","I think this should read ""is always observed before"" or ""is never observed after"".",I'm not sure if this is th
+6260,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright 2002-2020 the original author or authors.
++ * Copyright 2002-2021 the original author or authors.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.",You might consider adding yourself as an author of the class.,Why did you change this?
+6261,"@@ -1065,7 +1065,8 @@ int ACTIVE_TASK::start(bool test) {
+ 
+         // hook up stderr to a specially-named file
+         //
+-        (void) freopen(STDERR_FILE, ""a"", stderr);
++        if (freopen(STDERR_FILE, ""a"", stderr) == NULL) {
++        }
+ 
+         // lower our priority if needed
+         //","If this fails, then 'stderr' is not a valid file handler anymore, and then any further 'write' operations will fail. Maybe some handling of such situation should be added here?",Why is this change neede
+6262,"@@ -58,9 +58,12 @@ public class TracerTest {
+   public void shouldBeAbleToCreateATracer() {
+     List<SpanData> allSpans = new ArrayList<>();
+     Tracer tracer = createTracer(allSpans);
++    long timeStamp = 1593493828L;
+ 
+     try (Span span = tracer.getCurrentContext().createSpan(""parent"")) {
+       span.setAttribute(""cheese"", ""gouda"");
++      span.addEvent(""Grating cheese"");
++      span.addEvent(""Melting cheese"", timeStamp);
+       span.setStatus(Status.NOT_FOUND);
+     }
+ ",Break out tests for events into their own tests rather than placing them in other ones. That makes it easier for us to figure out where problems lie and to do a TDD-driven implementation over new APIs.,This should be `15934938
+6263,"@@ -262,8 +262,8 @@ class DHCPOptionsField(StrField):
+                 s += chr(len(oval))
+                 s += oval
+ 
+-            elif (type(o) is str and DHCPRevOptions.has_key(o) and 
+-                  DHCPRevOptions[o][1] == None):
++            elif (type(o) is str and DHCPRevOptions.has_key(o) and
++                          DHCPRevOptions[o][1] is None):
+                 s += chr(DHCPRevOptions[o][0])
+             elif type(o) is int:
+                 s += chr(o)+""\0""",I think your indentation is wrong here.,Why is this change neede
+6264,"@@ -63,7 +63,9 @@ type L3RouteResolver struct {
+ 	blockToRoutes          map[string]set.Set
+ 	allPools               map[string]model.IPPool
+ 	workloadIDToCIDRs      map[model.WorkloadEndpointKey][]cnet.IPNet
++	nodeToCIDRs            map[string]set.Set
+ 	useNodeResourceUpdates bool
++	routeSource            string
+ }
+ 
+ type l3rrNodeInfo struct {","UT spotted that we weren't marking routes dirty when they targeted at Node and that node's IP changed. e.g., the case where a WEP appears in the syncer before the corresponding node does, so we don't know the node's IP. I added a new map to track the CIDRs for each node so that when the node IP changes we can mark those CIDRs dirty. Right now it's only used for the ""WorkloadIPs"" scenario. Need to decide if the same issue applies in the ""CalicoIPAM' case. I suspect it might. It looks like we have some logic present to detect when our own node IP changes, but we don't seem to handle when a remote node's IP changes.",Why do we need this?
+6265,"@@ -390,6 +390,14 @@ HELP
+     def execute(options)
+       if options[:mode] == 'plan' || options[:mode] == 'task'
+         begin
++          if Gem.win_platform?
++            # Windows 'fix' for openssl behaving strangely. Prevents very slow operation
++            # of random_bytes later when establishing winrm connections from a Windows host.
++            # See https://github.com/rails/rails/issues/25805 for background.
++            require 'openssl'
++            OpenSSL::Random.random_bytes(1)
++          end
++
+           require_relative '../../vendored/require_vendored'
+         rescue LoadError
+           raise Bolt::CLIError, ""Puppet must be installed to execute tasks""","Given this will 'pause' bolt for a few seconds on older rubies, perhaps emit a debug message saying ""Warming up OpenSSL"" or something to that effect",I'm not sure if this
+6266,"@@ -85,6 +85,11 @@ class Package(object):
+         self._package = package
+         self._pkg_dir = pkg_dir
+         self._path = path
++        self._format = None
++
++    def set_format(self, pkgformat):
++        """"""Set the format. Only used when building a new package.""""""
++        self._format = pkgformat
+ 
+     def file(self, hash_list):
+         """"""","Initializing _format to None, but asserting that it's not None later, seems unnecessarily fragile. We shouldn't architect the package class to rely on classes or methods that use it (e.g., build). Let's at least set the format to the default in case we don't create all packages through build.py.",Why do we need this 
+6267,"@@ -105,7 +105,7 @@ public interface WebDriver extends SearchContext {
+    * @see org.openqa.selenium.WebDriver.Timeouts
+    */
+   @Override
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+ 
+ 
+   /**",This change should also probably go into the corresponding method of the abstract By class?,Why do we need this 
+6268,"@@ -0,0 +1,8 @@
++<?php
++namespace Psalm\Issue;
++
++class UnresolvableConstant extends CodeIssue
++{
++    public const ERROR_LEVEL = -1;
++    public const SHORTCODE = 303;
++}",Should this be set to something else?,Missing license header.
+6269,"@@ -0,0 +1 @@
++Hi","Whats up with this? It looks like this is rendered on purchases/new for subscribers, so it would result in a dead end?",Please add a new line a
+6270,"@@ -1326,13 +1326,13 @@ class StoreOptions(object):
+         return specs
+ 
+     @classmethod
+-    def propagate_ids(cls, obj, match_id, new_id, applied_keys):
++    def propagate_ids(cls, obj, match_id, new_id, applied_keys, backend=None):
+         """"""
+         Recursively propagate an id through an object for components
+         matching the applied_keys. This method can only be called if
+         there is a tree with a matching id in Store.custom_options
+         """"""
+-        if not new_id in Store.custom_options():
++        if not new_id in Store.custom_options(backend=backend):
+             raise AssertionError(""The set_ids method requires ""
+                                  ""Store.custom_options to contain""
+                                  "" a tree with id %d"" % new_id)",Glad to see this generalized to support the backend argument.,I don't think we need t
+6271,"@@ -1781,3 +1781,11 @@ func (a *WebAPI) GetInsightApplicationCount(ctx context.Context, req *webservice
+ 		UpdatedAt: c.UpdatedAt,
+ 	}, nil
+ }
++
++func (a *WebAPI) ListDeploymentChains(ctx context.Context, req *webservice.ListDeploymentChainsRequest) (*webservice.ListDeploymentChainsResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""not yet implemented"")
++}
++
++func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDeploymentChainRequest) (*webservice.GetDeploymentChainResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""not yet implemented"")
++}",`ctx` is unused in ListDeploymentChains,Why is this not impleme
+6272,"@@ -154,7 +154,7 @@ func (e *Executor) reportRequiringApproval(ctx context.Context) {
+ func (e *Executor) getMentionedAccounts(ctx context.Context, event model.NotificationEventType) ([]string, error) {
+ 	ds, err := e.TargetDSP.GetReadOnly(ctx, e.LogPersister)
+ 	if err != nil {
+-		return nil, fmt.Errorf(""failed to prepare running deploy source data: %w"", err)
++		return nil, fmt.Errorf(""failed to prepare running deploy source data: (%w)"", err)
+ 	}
+ 
+ 	if ds.GenericDeploymentConfig.DeploymentNotification == nil {","I'd say the format like `""xxx: %w""` is more convention when wrapping an error basically. You refered to anything like this?","I'm not sure if this is the right way to do it, but I think it would be better to use `errors.Wrap` here."
+6273,"@@ -65,7 +65,7 @@ const (
+ 	endpoint            = ""https://127.0.0.1:2379""
+ 	testTimeout         = time.Second * 10
+ 	manageTickerTime    = time.Second * 15
+-	learnerMaxStallTime = time.Minute * 1
++	learnerMaxStallTime = time.Minute * 5
+ 
+ 	// defaultDialTimeout is intentionally short so that connections timeout within the testTimeout defined above
+ 	defaultDialTimeout = 2 * time.Second","This seems relatively high, is it the recommended value from the etcd folks? Or is this debugging cruft?",Why was this changed?
+6274,"@@ -10,11 +10,11 @@ import (
+ 	""google.golang.org/grpc/status""
+ )
+ 
+-type peerTrackerAttestor struct {
++type PeerTrackerAttestor struct {
+ 	Attestor attestor.Attestor
+ }
+ 
+-func (a peerTrackerAttestor) Attest(ctx context.Context) ([]*common.Selector, error) {
++func (a PeerTrackerAttestor) Attest(ctx context.Context) ([]*common.Selector, error) {
+ 	watcher, ok := peertracker.WatcherFromContext(ctx)
+ 	if !ok {
+ 		return nil, status.Error(codes.Internal, ""peer tracker watcher missing from context"")","This requires updating the name in the `endpoints` tests, please run `make test`.",Why do we need this change?
+6275,"@@ -37,6 +37,10 @@ std::vector<HostAddr> toHosts(const std::string& peersStr) {
+ 
+ int main(int argc, char *argv[]) {
+     folly::init(&argc, &argv, true);
++    if (FLAGS_data_path.empty()) {
++        LOG(FATAL) << ""Meta Data Path should not empty"";
++        return EXIT_FAILURE;
++    }
+ 
+     LOG(INFO) << ""Starting Meta HTTP Service"";
+     nebula::WebService::registerHandler(""/meta"", [] {","LOG(FATAL) means coredump, LOG(ERROR) is better here.",I think this should be `LOG(FATAL) << ...`
+6276,"@@ -533,13 +533,13 @@ nsCommandProcessor.prototype.execute = function(jsonCommandString,
+  * Changes the context of the caller to the specified window.
+  * @param {fxdriver.CommandResponse} response The response object to send the
+  *     command response in.
+- * @param {{name: string}} parameters The command parameters.
++ * @param {{handle: string}} parameters The command parameters.
+  * @param {number} opt_searchAttempt Which attempt this is at finding the
+  *     window to switch to.
+  */
+ nsCommandProcessor.prototype.switchToWindow = function(response, parameters,
+                                                        opt_searchAttempt) {
+-  var lookFor = parameters.name;
++  var lookFor = parameters.handle;
+   var matches = function(win, lookFor) {
+     return !win.closed &&
+            (win.top && win.top.fxdriver) &&","/javascript/firefox-driver is the Selenium implementation of a WebDriver for Firefox. Since it generally isn't W3C compatible, it shouldn't change. We can just drop this change.",I think this should be `parameters.name || parameters.handle`
+6277,"@@ -375,6 +375,12 @@ func UnmarshalService(in []byte) (interface{}, error) {
+ 			m.BackendServiceConfig.Image.HealthCheck.applyIfNotSet(newDefaultContainerHealthCheck())
+ 		}
+ 		return m, nil
++	case ScheduledJobType:
++		m := newDefaultScheduledJob()
++		if err := yaml.Unmarshal(in, m); err != nil {
++			return nil, fmt.Errorf(""unmarshal to scheduled job: %w"", err)
++		}
++		return m, nil
+ 	default:
+ 		return nil, &ErrInvalidSvcManifestType{Type: typeVal}
+ 	}",It's a bit weird to have `svc.go` to include a `ScheduledJobType`...should we rename this file?,I think we should return an error here instead of panicing.
+6278,"@@ -55,7 +55,7 @@ const licenseHeaderPrefix = ""// The MIT License (MIT)""
+ 
+ var (
+ 	// directories to be excluded
+-	dirBlacklist = []string{""vendor/""}
++	dirBlacklist = []string{""tpb/""}
+ 	// default perms for the newly created files
+ 	defaultFilePerms = os.FileMode(0644)
+ )","For some reason `protoc` doesn't copy license header from `proto` files to generated code. But this code will never be checked in, so it is ok.",Why is this change needed?
+6279,"@@ -898,7 +898,7 @@ public class DatabaseHelper extends OrmLiteSqliteOpenHelper {
+                 PreparedQuery<TemporaryBasal> preparedQuery2 = queryBuilder2.prepare();
+                 List<TemporaryBasal> trList2 = getDaoTemporaryBasal().query(preparedQuery2);
+ 
+-                if (trList2.size() > 0) {
++                if (trList2.size() > 0 && trList2.get(0).pumpId == 0) { // don't update existing record if it has a pumpId
+                     old = trList2.get(0);
+ 
+                     old.copyFromPump(tempBasal);","I don't know what the implications of this change are for pumps other than the insight but i would add `|| trList2.get(0).pumpId == temporaryBasal.pumpId` in case we see the same pump event again, in order to not duplicate it in the database.",I think this should be `trList2.get(0).pumpId != null`
+6280,"@@ -29,8 +29,8 @@ type (
+ 	Address crypto.Digest
+ )
+ 
+-// ChecksumAddress is a representation of the short address with a checksum
+-type ChecksumAddress struct {
++// checksumAddress is a representation of the short address with a checksum
++type checksumAddress struct {
+ 	shortAddress Address
+ 	checksum     []byte
+ }",is there anything still referencing `checksumAddress` or can we just delete it?,Why did you change this?
+6281,"@@ -18,6 +18,7 @@ var (
+ 	// ClusterDeployment conditions that could indicate provisioning problems with a cluster
+ 	// First condition appearing True will be used in the metric labels.
+ 	provisioningDelayCondition = [...]hivev1.ClusterDeploymentConditionType{
++		hivev1.RequirementsMetCondition,
+ 		hivev1.DNSNotReadyCondition,
+ 		hivev1.InstallLaunchErrorCondition,
+ 		hivev1.ProvisionFailedCondition,","The reason I didn't suggest it before is because I didn't want alerts for every tried - but not updated provision, but I can see a value in it from OSD perspective",Why do we need this?
+6282,"@@ -2,8 +2,10 @@ if Rails.env.production? || Rails.env.staging?
+   require 'rack/rewrite'
+ 
+   Rails.configuration.middleware.insert_before(Rack::Runtime, Rack::Rewrite) do
+-    r301 %r{.*}, ""http://#{HOST}$&"", if: Proc.new { |rack_env|
+-      rack_env['SERVER_NAME'] != ""#{HOST}""
+-    }
++    r301(
++      %r{.*},
++      ""http://#{ENV['APP_DOMAIN']}$&"",
++      if: proc { |rack_env| rack_env['SERVER_NAME'] != ""#{ENV['APP_DOMAIN']}"" }
++    )
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Style/Proc: Pass &:rack_
+6283,"@@ -61,8 +61,12 @@ func GroupActions(actions []*Action) (beforeGets, getList, writeList, afterGets
+ 	agets := map[interface{}]*Action{}
+ 	cgets := map[interface{}]*Action{}
+ 	writes := map[interface{}]*Action{}
++	var nilkeys []*Action
+ 	for _, a := range actions {
+-		if a.Kind == Get {
++		if a.Key == nil {
++			// Probably a Create.
++			nilkeys = append(nilkeys, a)
++		} else if a.Kind == Get {
+ 			// If there was a prior write with this key, make sure this get
+ 			// happens after the writes.
+ 			if _, ok := writes[a.Key]; ok {","I believe Key is not necessarily nil, it could be empty string. Probably better check a.Kind == Create",nit: `nilkeys := append(
+6284,"@@ -89,7 +89,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             }
+         }
+ 
+-        public Task WriteAsync<T>(Func<PipeWriter, T, long> callback, T state)
++        public Task WriteAsync<T>(Func<PipeWriter, T, long> callback, T state, CancellationToken cancellationToken)
+         {
+             lock (_contextLock)
+             {",This is only used for headers and therefore isn't used.,Why do we need to change this?
+6285,"@@ -15,11 +15,13 @@ import (
+ 
+ // ProviderCommand defines the shell command to be run for one of the commands (db pull, etc.)
+ type ProviderCommand struct {
+-	Command string `yaml:""command""`
+-	Service string `yaml:""service,omitempty""`
++	Command    string `yaml:""command""`
++	Service    string `yaml:""service,omitempty""`
++	SkipImport bool   `yaml:""skip_import""`
+ }
+ 
+ // ProviderInfo defines the provider
++// @todo: CodePullCommand unused
+ type ProviderInfo struct {
+ 	EnvironmentVariables map[string]string `yaml:""environment_variables""`
+ 	AuthCommand          ProviderCommand   `yaml:""auth_command""`","Wouldn't it make sense to add a files_import_command and a db_import_command, which could be empty? I guess that leads to potential backward-compatibility problems, but it's worth thinking about. Perhaps add an import-api version to solve that? Overall, I think the actual db import logic and files import logic should be moved into the yaml file. What you you think of that?",Why is this unused?
+6286,"@@ -0,0 +1,15 @@
++// DO NOT EDIT: This file is autogenerated via the builtin command.
++
++package csv
++
++import ast ""github.com/influxdata/flux/ast""
++
++var FluxTestPackages = []*ast.Package{&ast.Package{
++	BaseNode: ast.BaseNode{
++		Errors: nil,
++		Loc:    nil,
++	},
++	Files:   []*ast.File{},
++	Package: ""csv_test"",
++	Path:    ""csv"",
++}}","Why do we have this here? I'm not concerned about it really, just curious.",Why do we need this file?
+6287,"@@ -28,11 +28,11 @@ import (
+ type DeltaAction uint64
+ 
+ const (
+-	// SetBytesAction indicates that a TEAL byte slice should be stored at a key
+-	SetBytesAction DeltaAction = 1
+-
+ 	// SetUintAction indicates that a Uint should be stored at a key
+-	SetUintAction DeltaAction = 2
++	SetUintAction DeltaAction = 1
++
++	// SetBytesAction indicates that a TEAL byte slice should be stored at a key
++	SetBytesAction DeltaAction = 2
+ 
+ 	// DeleteAction indicates that the value for a particular key should be deleted
+ 	DeleteAction DeltaAction = 3",@justicz Why are these switched here?,Why did you change this?
+6288,"@@ -0,0 +1,7 @@
++describe 'GET /help' do
++  it ""displays successfully"" do
++    get '/help'
++    expect(response.status).to eq(200)
++    expect(response.body).to include('FAQ')
++  end
++end",Maybe verify that an anchor was created -- that the markdown was processed?,I don't think this test is needed.
+6289,"@@ -64,7 +64,7 @@ public abstract class TwoPhaseIterator {
+ 
+     TwoPhaseIteratorAsDocIdSetIterator(TwoPhaseIterator twoPhaseIterator) {
+       this.twoPhaseIterator = twoPhaseIterator;
+-      this.approximation = twoPhaseIterator.approximation;
++      this.approximation = twoPhaseIterator.approximation();
+     }
+ 
+     @Override","Is this just a minor improvement or is it necessary? If just some minor improvement, I recommend you don't touch Lucene in a Solr PR.",Why is this change needed?
+6290,"@@ -63,7 +63,4 @@ public interface ReadOnlyPDClient {
+ 
+   /** Close underlining resources */
+   void close() throws InterruptedException;
+-
+-  /** Get associated session * @return the session associated to client */
+-  TiSession getSession();
+ }",why delete this method?,Why is this removed?
+6291,"@@ -15,13 +15,17 @@
+ package com.google.api.codegen.transformer;
+ 
+ import com.google.api.codegen.config.MethodContext;
++import com.google.api.codegen.config.OutputContext;
+ import com.google.api.codegen.metacode.InitCodeNode;
+ import com.google.api.codegen.viewmodel.CallingForm;
+ import com.google.api.codegen.viewmodel.ImportSectionView;
+-import com.google.api.codegen.viewmodel.OutputView;
+ import java.util.Collections;
+-import java.util.List;
+ 
++/**
++ * An implementation of SampleImportTransformer. Subclasses of this class can choose to override
++ * `addSampleBodyImports`, `addOutputImports` and `addInitCodeImports` to save language-specific
++ * types to the type table. Currently used by Java.
++ */
+ public class StandardSampleImportTransformer implements SampleImportTransformer {
+ 
+   private final ImportSectionTransformer importSectionTransformer;","Does this transform only the `MethodContext`, or also the `OutputContext`? (Looking at the other files, I gather it's the latter.) Might be helpful to mention that here.",I don't think this is the right pl
+6292,"@@ -1,15 +1,17 @@
+ # A part of NonVisual Desktop Access (NVDA)
+-# Copyright (C) 2009-2018 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala
++# Copyright (C) 2009-2020 NV Access Limited, Aleksey Sadovoy, James Teh, Joseph Lee, Tuukka Ojala
+ # This file may be used under the terms of the GNU General Public License, version 2 or later.
+ # For more details see: https://www.gnu.org/licenses/gpl-2.0.htmlimport appModuleHandler
+ 
+ import calendar
+ import collections
+ import time
+-
+ import api
+ import appModuleHandler
++from NVDAObjects.IAccessible import getNVDAObjectFromEvent
+ import ui
++import windowUtils
++import winUser
+ 
+ # A named tuple for holding the elapsed and total playing times from Foobar2000's status bar
+ statusBarTimes = collections.namedtuple('StatusBarTimes', ['elapsed', 'total'])",Could you please clean-up this line while at it?,Why did you change the year?
+6293,"@@ -50,6 +50,11 @@ type PubSubSpec struct {
+ 	// This brings in CloudEventOverrides and Sink.
+ 	duckv1.SourceSpec `json:"",inline""`
+ 
++	// ServiceAccount is the GCP service account which has required permissions to poll from a Cloud Pub/Sub subscription.
++	// If not specified, defaults to use secret.
++	// +optional
++	ServiceAccount *string `json:""serviceAccount,omitempty""`
++
+ 	// Secret is the credential to use to poll from a Cloud Pub/Sub subscription.
+ 	// If not specified, defaults to:
+ 	// Name: google-cloud-key","no need to use a pointer. Just string and check for != """"",I don't think we need to add
+6294,"@@ -133,7 +133,9 @@ public class RestServerVerticle extends AbstractVerticle {
+     serverOptions.setIdleTimeout(TransportConfig.getConnectionIdleTimeoutInSeconds());
+     serverOptions.setCompressionSupported(TransportConfig.getCompressed());
+     serverOptions.setMaxHeaderSize(TransportConfig.getMaxHeaderSize());
+-
++    if (endpointObject.isHttp2Enabled()) {
++      serverOptions.setUseAlpn(true);
++    }
+     if (endpointObject.isSslEnabled()) {
+       SSLOptionFactory factory =
+           SSLOptionFactory.createSSLOptionFactory(SSL_KEY, null);",this means h2 mode? but how h2c can work?,Why do we need this?
+6295,"@@ -1,9 +1,9 @@
+ # -*- coding: UTF-8 -*-
+-#appModules/explorer.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2019 NV Access Limited, Joseph Lee, Łukasz Golonka
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# appModules/explorer.py
++# A part of NonVisual Desktop Access (NVDA)
++# Copyright (C) 2006-2019 NV Access Limited, Joseph Lee, Łukasz Golonka, Julien Cochuyt
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+ 
+ """"""App module for Windows Explorer (aka Windows shell and renamed to File Explorer in Windows 8).
+ Provides workarounds for controls such as identifying Start button, notification area and others.",This line should not be there,Why did you change this?
+6296,"@@ -120,7 +120,12 @@ func (t *trie) Start(ctx context.Context) error {
+ 	return t.dao.Commit(t.cb)
+ }
+ 
+-func (t *trie) Stop(ctx context.Context) error { return t.lifecycle.OnStop(ctx) }
++func (t *trie) Stop(ctx context.Context) error {
++	t.mutex.Lock()
++	defer t.mutex.Unlock()
++
++	return t.lifecycle.OnStop(ctx)
++}
+ 
+ // TrieDB return the underlying DB instance
+ func (t *trie) TrieDB() db.KVStore {","why do we need lock here? if needed, then we also need to lock in Start()?",Why do we need a lock here?
+6297,"@@ -415,6 +415,8 @@ void ProtocolGame::parsePacket(NetworkMessage& msg)
+ 		}
+ 	}
+ 
++	addGameTask(&Game::playerExecuteParsePacketEvent, player->getID(), recvbyte, new NetworkMessage(msg));
++
+ 	switch (recvbyte) {
+ 		case 0x14: g_dispatcher.addTask(createTask(std::bind(&ProtocolGame::logout, getThis(), true, false))); break;
+ 		case 0x1D: addGameTask(&Game::playerReceivePingBack, player->getID()); break;","this should be on default-switch, uhm? else you will handle twice (c++ and lua). I'm just saying...",Why do we need a new Networ
+6298,"@@ -60,7 +60,7 @@ public class Program
+             // turn off the above default. i.e any
+             // instrument which does not match any views
+             // gets dropped.
+-            // .AddView(instrumentName: ""*"", new MetricStreamConfiguration() { Aggregation = Aggregation.Drop })
++            // .AddView(instrumentName: ""*"", MetricStreamConfiguration.Drop)
+             .AddConsoleExporter()
+             .Build();
+ ",unrelated minor fix,Why did you remove this?
+6299,"@@ -19,6 +19,7 @@ module Travis
+         def setup
+           super
+           cmd ""nvm use #{config[:node_js]}""
++          cmd ""npm config set spin false"", echo: false
+           if npm_should_disable_strict_ssl?
+             cmd 'echo ""### Disabling strict SSL ###""'
+             cmd 'npm conf set strict-ssl false'","can you add `, echo: false` to the end of this as well. I don't think we need to echo this to the log. You might need to update the spec as well.",Why do we need this?
+6300,"@@ -88,6 +88,12 @@ class TestHeaders:
+         headers = Headers(Host=""foobarfoo.com"", Accept=""foo/bar"")
+         replacements = headers.replace(""foo"", ""bar"", count=1)
+         assert replacements == 1
++        assert headers[""Host""] == ""barbarfoo.com""
++        assert headers[""Accept""] == ""foo/bar""
++        replacements = headers.replace(""foo"", ""bar"", count=2)
++        assert replacements == 2
++        assert headers[""Host""] == ""barbarbar.com""
++        assert headers[""Accept""] == ""bar/bar""
+ 
+ 
+ def test_parse_content_type():","This test does not really verify that we're doing the correct thing now, is it? It seems to pass with and without the patch.",I don't think we need this test.
+6301,"@@ -16,7 +16,13 @@ const BlocksTopic = ""/fil/blocks""
+ const MessageTopic = ""/fil/msgs""
+ 
+ // AddNewBlock processes a block on the local chain and publishes it to the network.
+-func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) error {
++func (node *Node) AddNewBlock(ctx context.Context, b *types.Block) (err error) {
++	ctx = log.Start(ctx, ""Node.AddNewBlock"")
++	log.SetTag(ctx, ""block"", b)
++	defer func() {
++		log.FinishWithErr(ctx, err)
++	}()
++
+ 	if _, err := node.ChainMgr.ProcessNewBlock(ctx, b); err != nil {
+ 		return err
+ 	}",should just be able to defer the call directly here too,Why do we need a defer here?
+6302,"@@ -916,7 +916,7 @@ class LayoutPlot(GenericLayoutPlot, CompositePlot):
+ 
+         # Create title handle
+         if self.show_title and len(self.coords) > 1:
+-            title = self.handles['fig'].suptitle('', **self._fontsize('title'))
++            title = self.handles['fig'].suptitle('', y=1.05, **self._fontsize('title'))
+             self.handles['title'] = title
+ 
+         return layout_subplots, layout_axes, collapsed_layout",Is this a magic number? I assume this makes it look better.,I think this should be `y=0.05`
+6303,"@@ -88,8 +88,8 @@ func (ob *Outbox) Send(ctx context.Context, from, to address.Address, value type
+ 			msgSendErrCt.Inc(ctx, 1)
+ 		}
+ 		ob.journal.Write(""Send"",
+-			""to"", to.String(), ""from"", from.String(), ""value"", value.AsBigInt().Uint64(), ""method"", method,
+-			""gasPrice"", gasPrice.AsBigInt().Uint64(), ""gasLimit"", uint64(gasLimit), ""bcast"", bcast,
++			""to"", to.String(), ""from"", from.String(), ""value"", value.Int.Uint64(), ""method"", method,
++			""gasPrice"", gasPrice.Int.Uint64(), ""gasLimit"", uint64(gasLimit), ""bcast"", bcast,
+ 			""params"", params, ""error"", err, ""cid"", out.String())
+ 	}()
+ ",Would welcome a stringification method on big.Int in specs-actors,Why do we need to change this?
+6304,"@@ -49,6 +49,8 @@ type (
+ 	WorkingSet interface {
+ 		// states and actions
+ 		RunActions(context.Context, uint64, []action.SealedEnvelope) (hash.Hash32B, map[hash.Hash32B]*action.Receipt, error)
++		RunAction(context.Context, action.SealedEnvelope) (*action.Receipt, error)
++		PersistBlockLevelInfo(blockHeight uint64) hash.Hash32B
+ 		Snapshot() int
+ 		Revert(int) error
+ 		Commit() error",PersistBlockLevelInfo -> UpdateBlockLevelInfo,Why do we need this method?
+6305,"@@ -0,0 +1,10 @@
++_base_ = [
++    'retinanet_pvt_t_fpn_1x_coco.py',
++]
++model = dict(
++    backbone=dict(
++        num_layers=[3, 4, 6, 3],
++        init_cfg=dict(
++            type='Pretrained',
++            checkpoint='https://github.com/whai362/PVT/'
++            'releases/download/v2/pvt_small.pth')))",Type is redundant since it is inherited.,Why do we need this file?
+6306,"@@ -94,6 +94,10 @@ public class TiTableInfo implements Serializable {
+     primaryKeyColumn = primaryKey;
+   }
+ 
++  public boolean isNotView() {
++    return this.viewInfo == null;
++  }
++
+   public boolean isView() {
+     return this.viewInfo != null;
+   }",better use `!isView()` so that we don't need to modify multiple lines in future.,Why do we need this method?
+6307,"@@ -43,6 +43,12 @@ module RSpec
+ 
+   extend RSpec::Core::Warnings
+ 
++  class << self
++    # Setters for shared global objects
++    # @api private
++    attr_writer :configuration, :world
++  end
++
+   # Used to ensure examples get reloaded and user configuration gets reset to
+   # defaults between multiple runs in the same process.
+   #","I know you don't usually open up the singleton class, but I was getting a `private method called` error when trying to use `self.attr_writer` - any idea?",Why do we need this?
+6308,"@@ -273,8 +273,13 @@ define(['apphost', 'globalize'], function (appHost, globalize) {
+         },
+ 
+         canRate: function (item) {
++            var itemType = item.Type;
++
++            if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel' || itemType === 'Season' || itemType === 'Studio') {
++                return false;
++            }
+ 
+-            if (item.Type === 'Program' || item.Type === 'Timer' || item.Type === 'SeriesTimer' || item.Type === 'CollectionFolder' || item.Type === 'UserView' || item.Type === 'Channel') {
++            if (!item.UserData) {
+                 return false;
+             }
+ ","There's no need to create a new variable here, the other checks just use the item type directly.",I don't think we need to check for `item.UserData` here.
+6309,"@@ -19,6 +19,14 @@ class Product < ActiveRecord::Base
+     where product_type: 'book'
+   end
+ 
++  def self.workshops
++    where product_type: 'workshop'
++  end
++
++  def self.videos
++    where product_type: 'video'
++  end
++
+   def self.ordered
+     order(""name asc"")
+   end","Any other possible names? Feels like going with ""workshop"" for this product_type could increase the confusion between course/workshop in the codebase.",Extra empty line detected at class body end.
+6310,"@@ -114,7 +114,10 @@ const baseResolvers = {
+ 			return;
+ 		}
+ 
+-		yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );
++		const { error } = yield fetchGetURLChannelsStore.actions.fetchGetURLChannels( accountID, clientID );
++		if ( error ) {
++			yield errorStoreActions.receiveError( error, 'getURLChannels', [ accountID, clientID ] );
++		}
+ 	},
+ };
+ ","@eugene-manuilov Isn't this already taken care of by `fetchGetURLChannels` via `createFetchStore`? Why is the extra `receiveError` call needed here? (This was already in the IB, but just struck me while reviewing here.)","Shouldn't this be `receiveError( error, 'getURLChannels'"
+6311,"@@ -22,6 +22,7 @@ import time
+ 
+ from concurrent import futures
+ import grpc
++import googlecloudprofiler
+ 
+ from google.cloud.forseti.common.util import logger
+ ",nit: should go before `grpc`?,nit: import order
+6312,"@@ -71,7 +71,7 @@ func init() {
+ }
+ 
+ func testWorkflow() *Workflow {
+-	ctx, cancel := context.WithCancel(context.Background())
++	cancel := make(chan struct{})
+ 	return &Workflow{
+ 		Name:          testWf,
+ 		GCSPath:       testGCSPath,","Why not using the Cancel? I thought cancelling a ""parent"" context would cascade to ""children"" contexts, cancelling them as well. In short, how does cancel work?",why this change?
+6313,"@@ -28,10 +28,12 @@ func (w *contentTypeOverridingResponseWriter) overrideMimeType(
+ 	// by the frontend WebView.
+ 	ty := strings.ToLower(mimeType)
+ 	switch {
+-	// First reject anything containing javascript/xml/html.
++	// First anything textual as text/plain.
++	// Includes javascript, html, xml. (note that the type may be e.g. application/xhtml+xml)
+ 	case strings.Contains(ty, ""javascript"") ||
+ 		strings.Contains(ty, ""xml"") ||
+-		strings.Contains(ty, ""html""):
++		strings.Contains(ty, ""html"") ||
++		strings.HasPrefix(ty, ""text/""):
+ 		return ""text/plain""
+ 	// Pass multimedia types through, and pdf too.
+ 	case strings.HasPrefix(ty, ""audio/"") ||","Could you explain why we default to binary now? It seems it's safer to default to text to avoid stuff getting executed or parsed by browsers accidentally. If we need to add support for particular types, we can add them explicitly right?",I don't think th
+6314,"@@ -139,6 +139,8 @@ type Config struct {
+ 	MetadataAddr string `config:""hostname;127.0.0.1;die-on-fail""`
+ 	MetadataPort int    `config:""int(0,65535);8775;die-on-fail""`
+ 
++	OpenstackRegion string `config:""string;;local""`
++
+ 	InterfacePrefix  string `config:""iface-list;cali;non-zero,die-on-fail""`
+ 	InterfaceExclude string `config:""iface-list;kube-ipvs0""`
+ ","Bit worried about the prefix since this seem to be being used for non-Openstack data too (host endpoints). Should we just leave host endpoint status at the old path (or remove it since AIFAIK, it's not used anywhere)?",Why do we need t
+6315,"@@ -68,7 +68,7 @@ public class Timeline {
+ 
+     private static final Pattern TIMECODE_LINK_REGEX = Pattern.compile(""antennapod://timecode/((\\d+))"");
+     private static final String TIMECODE_LINK = ""<a class=\""timecode\"" href=\""antennapod://timecode/%d\"">%s</a>"";
+-    private static final Pattern TIMECODE_REGEX = Pattern.compile(""\\b(?:(?:(([0-9][0-9])):))?(([0-9][0-9])):(([0-9][0-9]))\\b"");
++    private static final Pattern TIMECODE_REGEX = Pattern.compile(""\\b(?:(?:([01]?\\d|2[0-3]):)?([0-5]?\\d):)?([0-5]?\\d)\\b"");
+     private static final Pattern LINE_BREAK_REGEX = Pattern.compile(""<br */?>"");
+ 
+ ","This might be a silly question, but what happens to files with durations > 24 hours?",private static f
+6316,"@@ -92,7 +92,7 @@ namespace OpenTelemetry.Trace
+         /// <returns>Returns <see cref=""TracerProviderBuilder""/> for chaining.</returns>
+         internal static TracerProviderBuilder AddDiagnosticSourceInstrumentation<TInstrumentation>(
+             this TracerProviderBuilder tracerProviderBuilder,
+-            Func<ActivitySourceAdapter, TInstrumentation> instrumentationFactory)
++            Func<TInstrumentation> instrumentationFactory)
+             where TInstrumentation : class
+         {
+             if (instrumentationFactory == null)",`AddDiagnosticSourceInstrumentation` method can now be eliminated and simply use `AddInstrumentation`,This is a breaking change. I think we should keep the old signature and add a new one.
+6317,"@@ -78,9 +78,9 @@ describe Bolt::Project do
+     describe ""with namespaced project names"" do
+       let(:config) { { 'name' => 'puppetlabs-foo' } }
+ 
+-      it ""strips namespace and hyphen"" do
+-        project = Bolt::Project.new(config, pwd)
+-        expect(project.name).to eq('foo')
++      it ""raises an error"" do
++        expect { Bolt::Project.new(config, pwd).validate }
++          .to raise_error(/Invalid project name 'puppetlabs-foo' in bolt-project.yaml/)
+       end
+     end
+   end",I think we also need to add `name:` to the bolt-project.yaml files in `spec/fixtures/projects`.,"I think this should be `expect { Bolt::Project.new(config, pwd) }.to raise_error(/Inva"
+6318,"@@ -3225,6 +3225,11 @@ func (fbo *folderBranchOps) getAndApplyMDUpdates(ctx context.Context,
+ 	return nil
+ }
+ 
++// getUnmergedMDUpdates returns a slice of the unmerged MDs for this
++// TLF's current unmerged branch and unmerged branch, between the
++// merge point for the branch and the current head.  The returned MDs
++// are the same instances that are stored in the MD cache, so they
++// should be modified with care.
+ func (fbo *folderBranchOps) getUnmergedMDUpdates(
+ 	ctx context.Context, lState *lockState) (
+ 	MetadataRevision, []*RootMetadata, error) {","worth mentioning the same warning here as in `md_util.go`, I think.",I don't think this is the right place for this function. It should be in the `folderBr
+6319,"@@ -134,8 +134,12 @@ func (p *Provisioner) GetNodeObjectFromHostName(hostName string) (*v1.Node, erro
+ 		Limit:         1,
+ 	}
+ 	nodeList, err := p.kubeClient.CoreV1().Nodes().List(listOptions)
+-	if err != nil {
+-		return nil, errors.Errorf(""Unable to get the Node with the NodeHostName"")
++	if err != nil || nodeList.Items == nil || len(nodeList.Items) == 0 {
++		// After the PV is created and node affinity is set 
++		// based on kubernetes.io/hostname label, either:
++		// - hostname label changed on the node or
++		// - the node is deleted from the cluster.
++		return nil, errors.Errorf(""Unable to get the Node with the NodeHostName [%s]"", hostName)
+ 	}
+ 	return &nodeList.Items[0], nil
+ ","Do we need both the checks, for `Items` not nil and `len(Items)`",Why do we need to check for the length here?
+6320,"@@ -349,6 +349,14 @@ ActiveRecord::Schema.define(version: 20160927192531) do
+ 
+   add_index ""tags"", [""name""], name: ""index_tags_on_name"", unique: true, using: :btree
+ 
++  create_table ""test_client_requests"", force: :cascade do |t|
++    t.decimal  ""amount""
++    t.string   ""project_title""
++    t.integer  ""approving_official_id""
++    t.datetime ""created_at""
++    t.datetime ""updated_at""
++  end
++
+   create_table ""user_delegates"", force: :cascade do |t|
+     t.integer  ""assigner_id""
+     t.integer  ""assignee_id""",Do you know what this is coming from? It keeps getting deleted/created @nickbristow,I don't think we need to create a new table for this. We can just use the existing `test_client_requests` table.
+6321,"@@ -63,11 +63,7 @@ public class FlinkCatalogFactory implements CatalogFactory {
+   public static final String ICEBERG_CATALOG_TYPE_HADOOP = ""hadoop"";
+   public static final String ICEBERG_CATALOG_TYPE_HIVE = ""hive"";
+ 
+-  public static final String HIVE_URI = ""uri"";
+-  public static final String HIVE_CLIENT_POOL_SIZE = ""clients"";
+   public static final String HIVE_CONF_DIR = ""hive-conf-dir"";
+-  public static final String WAREHOUSE_LOCATION = ""warehouse"";
+-
+   public static final String DEFAULT_DATABASE = ""default-database"";
+   public static final String BASE_NAMESPACE = ""base-namespace"";
+ ","Nit: leaving these in place would have reduce the number of files that this needed to touch, and avoided a possible problem removing public fields. I don't think it's worth blocking for this change, but we like to keep patches as small as possible by not breaking references like these.",Why are these removed?
+6322,"@@ -444,6 +444,7 @@ class AdminController extends Controller
+      */
+     protected function prePersistEntity($entity)
+     {
++        @trigger_error(sprintf('The %s is deprecated since EasyAdmin 1.x and will be removed in 2.0 veresion. Use persistEntity instead', __METHOD__), E_USER_DEPRECATED);
+     }
+ 
+     /**",`The %s is deprecated...` -> `The %s method is deprecated...`,This should be `trigger_error(sprintf('The %s is deprecated since EasyAdmin 1.x and will be removed in 2.0. Use 
+6323,"@@ -19,6 +19,9 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/encoding""
+ )
+ 
++// TODO: If this is gonna stay, it should move to specs-actors
++const BlockMessageLimit = 512
++
+ // Block is a block in the blockchain.
+ type Block struct {
+ 	// control field for encoding struct as an array","No, it wouldn't go there because that code won't reference or enforce it. Here is ok for now.",I think this should be moved to specs-actors
+6324,"@@ -127,7 +127,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client
+             }
+             catch (Exception exception)
+             {
+-                var completeArgs = new TestRunCompleteEventArgs(null, false, true, exception, new Collection<AttachmentSet>(), TimeSpan.Zero);
++                var completeArgs = new TestRunCompleteEventArgs(null, false, false, exception, new Collection<AttachmentSet>(), TimeSpan.Zero);
+                 eventHandler.HandleLogMessage(TestMessageLevel.Error, exception.Message);
+                 eventHandler.HandleTestRunComplete(completeArgs, null, null, null);
+             }",How will we show that test run aborted (because of a crash) if we don't set aborted to true?,Why is this change needed?
+6325,"@@ -18,8 +18,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal
+ {
+     internal sealed class SocketConnection : TransportConnection
+     {
+-        private const int MinAllocBufferSize = 2048;
+-        public readonly static bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
++        private static readonly int MinAllocBufferSize = KestrelMemoryPool.MinimumSegmentSize / 2;
++        private static readonly bool IsWindows = RuntimeInformation.IsOSPlatform(OSPlatform.Windows);
+ 
+         private readonly Socket _socket;
+         private readonly PipeScheduler _scheduler;",Nit: Might as well make this same change to AdaptedPipeline.,Why did you change this?
+6326,"@@ -42,12 +42,13 @@ public class IcebergTimestampWithZoneObjectInspector extends AbstractPrimitiveJa
+ 
+   @Override
+   public OffsetDateTime convert(Object o) {
+-    return o == null ? null : OffsetDateTime.ofInstant(((Timestamp) o).toInstant(), ZoneOffset.UTC);
++    return o == null ? null : OffsetDateTime.of(((Timestamp) o).toLocalDateTime(), ZoneOffset.UTC);
+   }
+ 
+   @Override
+   public Timestamp getPrimitiveJavaObject(Object o) {
+-    return o == null ? null : Timestamp.from(((OffsetDateTime) o).toInstant());
++    return o == null ? null :
++        Timestamp.valueOf(((OffsetDateTime) o).withOffsetSameInstant(ZoneOffset.UTC).toLocalDateTime());
+   }
+ 
+   @Override",Just to clarify: I see that only the hive2 withZone object inspector is changed. Does that mean that the predicate pushdown problem only occurred on hive2?,Shouldn't this be `toLocal
+6327,"@@ -11,7 +11,7 @@ module Bolt
+   class ModuleInstaller
+     class Specs
+       class ForgeSpec
+-        NAME_REGEX    = %r{\A[a-z][a-z0-9_]*[-/](?<name>[a-z][a-z0-9_]*)\z}.freeze
++        NAME_REGEX    = %r{\A[a-zA-Z0-9]+[-/](?<name>[a-z][a-z0-9_]*)\z}.freeze
+         REQUIRED_KEYS = Set.new(%w[name]).freeze
+         KNOWN_KEYS    = Set.new(%w[name version_requirement]).freeze
+ ",Based on username requirements for forge.puppet.com - only letters and digits permitted.,Why is this change needed?
+6328,"@@ -73,11 +73,6 @@ public class StructLikeWrapper {
+       return false;
+     }
+ 
+-    int len = struct.size();
+-    if (len != that.struct.size()) {
+-      return false;
+-    }
+-
+     return comparator.compare(this.struct, that.struct) == 0;
+   }
+ ",Was this removed to ignore the extra columns coming from the file projection?,Why was this removed?
+6329,"@@ -1,3 +1,5 @@
++// +build !windows
++
+ // Copyright (c) 2016-2017 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");","Please can you pull out the shared function into a shared file? I think that'd be pretty easy to do for this module. I think you could: - pull out a function `configureSyslog` that is implemented on Linux, but stubbed on Windows - pull out a function `openLogFile` that is implemented differently on each - share everything else",Why is this needed?
+6330,"@@ -26,6 +26,6 @@ public class NotificationServiceFactoryImpl implements NotificationServiceFactor
+ 
+     @Override
+     public NotificationService create() {
+-        return new EmailNotificationService();
++        return new EmailNotificationService(new AWSEmailProvider());
+     }
+ }","Instead of hardcoding the AWSEmailProvider here, it should come from properties, so that it can be replaced with another EmailProvider for ZMS vs ZTS",I think this should b
+6331,"@@ -0,0 +1,10 @@
++require_relative '../config/environment'
++
++login = ARGV[0] || :admin_user
++password = ARGV[1] || :admin_password
++email = ARGV[2] || 'admin@example.com'
++
++account = Account.create!(login: login, level: 10, activated_at: Time.current,
++                          email: email, email_confirmation: email,
++                          password: password, password_confirmation: password)
++ManualVerification.create!(account: account, auth_id: account.login)",+1 for creating this script to help people get boot strapped,Layout/EmptyLinesArou
+6332,"@@ -7,6 +7,7 @@ export const ASYNC_RENDER = 3;
+ 
+ 
+ export const ATTR_KEY = '__preactattr_';
++export const ELT_KEY_PREFIX = 'preact-';
+ 
+ // DOM properties that should NOT have ""px"" added when numeric
+ export const IS_NON_DIMENSIONAL = /acit|ex(?:s|g|n|p|$)|rph|ows|mnc|ntw|ine[ch]|zoo|^ord/i;",Do you need the prefix?,export const ATTR_PREFIX = 'preact-';
+6333,"@@ -10558,7 +10558,12 @@ short CmpSeabaseDDL::unregisterNativeTable
+      objectNamePart.data(),
+      objType
+      );
+-  
++
++  // drop comment text
++  retcode = deleteFromTextTable(&cliInterface,
++                                objUID,
++                                ComTextType::COM_OBJECT_COMMENT_TEXT,
++                                0);
+   return 0;
+ }
+ ","if retcode is < 0, it should return -1 indicating an error.",`retcode` is not used.
+6334,"@@ -1,5 +1,5 @@
+ """"""Emit a message for iteration through dict keys and subscripting dict with key.""""""
+-# pylint: disable=line-too-long,missing-docstring,unsubscriptable-object,too-few-public-methods,redefined-outer-name,use-dict-literal
++# pylint: disable=locally-disabled,useless-suppression,suppressed-message,line-too-long,missing-docstring,unsubscriptable-object,too-few-public-methods,redefined-outer-name,use-dict-literal,iterating-modified-dict
+ 
+ def bad():
+     a_dict = {1: 1, 2: 2, 3: 3}",Are those necessary? I feel like `useless-suppression` could be avoided here?,"# pylint: disable=locally-disabled,us"
+6335,"@@ -309,13 +309,11 @@ define(['events', 'datetime', 'appSettings', 'itemHelper', 'pluginManager', 'pla
+             if (codecProfile.Type === 'Audio') {
+                 (codecProfile.Conditions || []).map(function (condition) {
+                     if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitDepth') {
+-                        maxAudioBitDepth = condition.Value;
+-                    }
+-                    if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
+-                        maxAudioSampleRate = condition.Value;
+-                    }
+-                    if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
+-                        maxAudioBitrate = condition.Value;
++                        return maxAudioBitDepth = condition.Value;
++                    } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioSampleRate') {
++                        return maxAudioSampleRate = condition.Value;
++                    } else if (condition.Condition === 'LessThanEqual' && condition.Property === 'AudioBitrate') {
++                        return maxAudioBitrate = condition.Value;
+                     }
+                 });
+             }",Is this equivalent in JavaScript?,I don't think we need to return anyth
+6336,"@@ -16,8 +16,8 @@ void GetEdgeIndexProcessor::process(const cpp2::GetEdgeIndexReq& req) {
+   auto edgeIndexIDRet = getIndexID(spaceID, indexName);
+   if (!nebula::ok(edgeIndexIDRet)) {
+     auto retCode = nebula::error(edgeIndexIDRet);
+-    LOG(ERROR) << ""Get Edge Index SpaceID: "" << spaceID << "" Index Name: "" << indexName
+-               << "" failed, error: "" << apache::thrift::util::enumNameSafe(retCode);
++    LOG(INFO) << ""Get Edge Index SpaceID: "" << spaceID << "" Index Name: "" << indexName
++              << "" failed, error: "" << apache::thrift::util::enumNameSafe(retCode);
+     handleErrorCode(retCode);
+     onFinished();
+     return;","get/list operation is not schema change, it is supposed to use VLOG",Why is this INFO level?
+6337,"@@ -92,7 +92,7 @@ namespace System.Diagnostics.Metrics
+             T delta,
+             params KeyValuePair<string, object?>[] tags)
+         {
+-            this.RecordMeasurement(delta, tags);
++            this.RecordMeasurement(delta, new ReadOnlySpan<KeyValuePair<string, object?>>(tags));
+         }
+     }
+ }","we'll need to delete this whole file, right?",Why do we need this cha
+6338,"@@ -41,6 +41,13 @@ public interface Table {
+ 
+   /**
+    * Refresh the current table metadata.
++   *
++   * <p>If this table is associated with a TransactionalCatalog, this refresh will be bounded by
++   * the visibility that the {@code IsolationLevel} of that transaction exposes. For example, if
++   * we are in a context of {@code READ_COMMITTED}, this refresh will update to the latest state
++   * of the table. However, in the case of {@code SERIALIZABLE} where this table hasn't mutated
++   * within this transaction, calling refresh will have no impact as the isolation level
++   * constrains all observations to within the transactional snapshot.
+    */
+   void refresh();
+ ","""this table hasn't mutated within this transaction"" may sound like implying that if this transaction contains table mutation changes, `refresh` may have impact, which I think is not true? I guess what you were saying was if other transactions committed to this table successfully when this transaction is half way through, refresh in this transaction will still return the same state as when this transaction begins.",nit: `this refresh will
+6339,"@@ -143,6 +143,18 @@ const (
+ 	VenafiPickupIDAnnotationKey = ""venafi.cert-manager.io/pickup-id""
+ )
+ 
++// TODO
++const (
++	// TODO
++	CertificateSigningRequestDurationAnnotationKey = ""cert-manager.io/request-duration""
++
++	// TODO
++	CertificateSigningRequestIsCAAnnotationKey = ""cert-manager.io/request-is-ca""
++
++	// TODO
++	CertificateSigningRequestCAAnnotationKey = ""cert-manager.io/ca""
++)
++
+ // KeyUsage specifies valid usage contexts for keys.
+ // See: https://tools.ietf.org/html/rfc5280#section-4.2.1.3
+ //      https://tools.ietf.org/html/rfc5280#section-4.2.1.12",Can we move these into some kind of experimental API group? I don't think we want to call them `v1` just yet :),I think we can remove t
+6340,"@@ -31,6 +31,8 @@ class Section < ActiveRecord::Base
+   include ActsAsSortable
+   include VersionableModel
+ 
++  # Sort order: Number ASC
++  default_scope { order(number: :asc) }
+ 
+   # ================
+   # = Associations =",  I think this makes a lot of sense but we may want to highlight the change for people doing UAT in case the ordering of sections is off anywhere when customizing or using the drag-drop feature,Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body beginning.
+6341,"@@ -0,0 +1,4 @@
++var script = document.createElement('script')
++script.type = 'text/javascript'
++script.src = '{}'
++document.head.appendChild(script)",These files should in `/javascript/brython`,Why do we need this?
+6342,"@@ -265,7 +265,7 @@ runLoop:
+ 					continue
+ 				}
+ 				s.close(err)
+-				break runLoop
++				continue
+ 			}
+ 			// This is a bit unclean, but works properly, since the packet always
+ 			// begins with the public header and we never copy it.","I'm not sure this is the right fix - I'd be more happy with a `continue`. That way, we don't enter the code at the bottom of the run loop (e.g. sending packets). Keep in mind that this error here may be triggered by a peer doing something security-relevant, so I don't think we should do much more work other than sending the close frame.",Why is this change needed?
+6343,"@@ -107,7 +107,11 @@ bool load_model::load_model_weights(const std::string& ckpt_dir,
+   closedir(weight_dir);
+ 
+   // load weights that appear in weight list.
+-  m->reload_weights(active_ckpt_dir, weight_list);
++  // load weights that appear in weight list.
++  // for(auto&& w : m_weights) {
++  //   w->load_from_save(latest,weight_list);
++  // }
++  //  m->reload_weights(active_ckpt_dir, weight_list);
+   return true;
+ }
+ ","Can we fix this, or is it going to stay broken.",Why do we need this?
+6344,"@@ -57,7 +57,6 @@ except Exception:
+ 
+ # to avoid copying:
+ 
+-@attr('postgres')
+ class CopyToTestDB(postgres.CopyToTable):
+     host = host
+     database = database",Is there a reason to remove this attr?,Why was this removed?
+6345,"@@ -0,0 +1,19 @@
++package config
++
++import (
++	""github.com/kubeedge/beehive/pkg/common/config""
++	""github.com/kubeedge/beehive/pkg/common/log""
++	""github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants""
++)
++
++// MessageLayer used, context or ssmq, default is context
++var MessageLayer string
++
++func init() {
++	if ml, err := config.CONFIG.GetValue(""devicecontroller.message-layer"").ToString(); err != nil {
++		MessageLayer = constants.DefaultMessageLayer
++	} else {
++		MessageLayer = ml
++	}
++	log.LOGGER.Infof(""message layer: %s"", MessageLayer)
++}",log message should be started with upper-case word.,I don't think we need
+6346,"@@ -17,6 +17,9 @@ const (
+ 	// aim to create chunks of 20 bits or about 1MiB on average.
+ 	averageBits = 20
+ 
++	// default buffer size
++	bufSize = 512 * KiB
++
+ 	// MinSize is the minimal size of a chunk.
+ 	MinSize = 512 * KiB
+ 	// MaxSize is the maximal size of a chunk.",I guess this is not needed anymore now?,Why do we need this?
+6347,"@@ -24,7 +24,7 @@
+ #include ""h2o.h""
+ 
+ static ssize_t add_header(h2o_mem_pool_t *pool, h2o_headers_t *headers, h2o_iovec_t *name, const char *orig_name, const char *value,
+-                          size_t value_len, h2o_header_flags_t flags)
++                          size_t value_len)
+ {
+     h2o_header_t *slot;
+ ","I think I would prefer retaining the argument. It's true that we are not using it now, but it's harmless, it's good to have a constructor function that accepts all the field values as arguments. Performance-wise, it does not matter.",Why did you remove th
+6348,"@@ -836,8 +836,11 @@ Blockly.Gesture.prototype.duplicateOnDrag_ = function() {
+   try {
+     // Note: targetBlock_ should have no children.  If it has children we would
+     // need to update shadow block IDs to avoid problems in the VM.
++    // Resizes will be reenabled at the end of the drag.
++    this.startWorkspace_.setResizesEnabled(false);
+     var xmlBlock = Blockly.Xml.blockToDom(this.targetBlock_);
+     newBlock = Blockly.Xml.domToBlock(xmlBlock, this.startWorkspace_);
++
+     // Move the duplicate to original position.
+     var xy = this.targetBlock_.getRelativeToSurfaceXY();
+     newBlock.moveBy(xy.x, xy.y);",Is this a different fix?,Why is this needed?
+6349,"@@ -45,10 +45,12 @@ func (s *DaemonServer) SetDNSServer(ctx context.Context,
+ 		}
+ 
+ 		// backup the /etc/resolv.conf
+-		cmd := bpm.DefaultProcessBuilder(""sh"", ""-c"", fmt.Sprintf(""ls %s.chaos.bak || cp %s %s.chaos.bak"", DNSServerConfFile, DNSServerConfFile, DNSServerConfFile)).
+-			SetNS(pid, bpm.MountNS).
+-			SetContext(ctx).
+-			Build()
++		processBuilder := bpm.DefaultProcessBuilder(""sh"", ""-c"", fmt.Sprintf(""ls %s.chaos.bak || cp %s %s.chaos.bak"", DNSServerConfFile, DNSServerConfFile, DNSServerConfFile)).SetContext(ctx)
++		if !req.WithoutNS {
++			processBuilder = processBuilder.SetNS(pid, bpm.MountNS)
++		}
++
++		cmd := processBuilder.Build()
+ 		output, err := cmd.CombinedOutput()
+ 		if err != nil {
+ 			log.Error(err, ""execute command error"", ""command"", cmd.String(), ""output"", output)",Why not add a `EnterNS` filed instead of `WithoutNS`?,Why do we need to d
+6350,"@@ -27,6 +27,13 @@ import (
+ )
+ 
+ var _ = Describe(""Endpoints"", func() {
++	const (
++		ProtoUDP  = 17
++		ProtoIPIP = 4
++		VXLANPort = 0
++		VXLANVNI  = 0
++	)
++
+ 	for _, trueOrFalse := range []bool{true, false} {
+ 		kubeIPVSEnabled := trueOrFalse
+ 		var rrConfigNormalMangleReturn = Config{",Same points as in other test file.,Why do we need thes
+6351,"@@ -158,6 +158,16 @@ void SettingsStruct_tmpl<N_TASKS>::ApDontForceSetup(bool value) {
+   bitWrite(VariousBits1, 14, value);
+ }
+ 
++template<unsigned int N_TASKS>
++bool SettingsStruct_tmpl<N_TASKS>::JSONBoolWithQuotes() const {
++  return bitRead(VariousBits1, 15);
++}
++
++template<unsigned int N_TASKS>
++void SettingsStruct_tmpl<N_TASKS>::JSONBoolWithQuotes(bool value) {
++  bitWrite(VariousBits1, 15, value);
++}
++
+ template<unsigned int N_TASKS>
+ bool SettingsStruct_tmpl<N_TASKS>::CombineTaskValues_SingleEvent(taskIndex_t taskIndex) const {
+   if (validTaskIndex(taskIndex))","I have a PR pending, can you change this bit index to `16`?",Why is this templat
+6352,"@@ -310,11 +310,12 @@ public class JavaParserInterfaceDeclaration extends AbstractTypeDeclaration impl
+ 
+     private ResolvedReferenceType toReferenceType(ClassOrInterfaceType classOrInterfaceType) {
+         SymbolReference<? extends ResolvedTypeDeclaration> ref = null;
+-        if (classOrInterfaceType.toString().indexOf('.') > -1) {
+-            ref = typeSolver.tryToSolveType(classOrInterfaceType.toString());
++        String typeName = classOrInterfaceType.getNameAsString();
++        if (typeName.indexOf('.') > -1) {
++            ref = typeSolver.tryToSolveType(typeName);
+         }
+         if (ref == null || !ref.isSolved()) {
+-            ref = solveType(classOrInterfaceType.toString(), typeSolver);
++            ref = solveType(typeName, typeSolver);
+         }
+         if (!ref.isSolved()) {
+             ref = solveType(classOrInterfaceType.getName().getId(), typeSolver);",we should probably have some utility class for this sort of things,Why not use `classOrInterfaceType.getQualifiedName()`?
+6353,"@@ -1,4 +1,4 @@
+-#pylint: disable=missing-docstring, no-else-return, invalid-name, unused-variable, superfluous-parens
++#pylint: disable=missing-docstring, no-else-return, invalid-name, unused-variable, superfluous-parens, try-except-raise
+ """"""Testing inconsistent returns""""""
+ import math
+ import sys",Curious that I'm not seeing any occurrence of the new error check in this file. Why was it disabled?,Why is this needed?
+6354,"@@ -341,6 +341,13 @@ class Realm {
+      */
+     static deleteFile(config) { }
+ 
++    /**
++     * Checks if the Realm already exists on disk.
++     * @param {Realm~Configuration} config The configuration for the Realm.
++     * @throws {Error} if anything in the provided `config` is invalid.
++     */
++    static exists(config) { }
++
+     /**
+      * Copy all bundled Realm files to app's default file folder.
+      * This is only implemented for React Native.",does it return something?,Why do we need this?
+6355,"@@ -265,7 +265,7 @@ const withData = (
+ 
+ 			// If we have an error, display the DataErrorComponent.
+ 			if ( error ) {
+-				return ( 'string' !== typeof error ) ? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid );
++				return ( 'string' !== typeof error ) ? error : getDataErrorComponent( moduleName, error, layoutOptions.inGrid, layoutOptions.fullWidth, layoutOptions.createGrid, data );
+ 			}
+ 
+ 			// If we have zeroData, display the NoDataComponent.","This function is also called in various Site Kit module components, where the error object (here `data`) also needs to be passed, otherwise the link to fix the issue won't appear.",I don't think we need to pass `data` to `getDataErrorC
+6356,"@@ -14,6 +14,8 @@ var log = logging.MustGetLogger(""scm"")
+ 
+ // An SCM represents an SCM implementation that we can ask for various things.
+ type SCM interface {
++	// DescribeIdentifier returns the string that is a ""human-readable"" identifier of the given revision.
++	DescribeIdentifier(sha string) string
+ 	// CurrentRevIdentifier returns the string that specifies what the current revision is.
+ 	CurrentRevIdentifier() string
+ 	// ChangesIn returns a list of modified files in the given diffSpec.",super nit: `revision string` (the passed value might not be a SHA hash).,I'm not sure if this is the best name for this method. Maybe `DescribeRevision`?
+6357,"@@ -54,7 +54,7 @@ namespace NLog.Layouts
+         /// Is this layout initialized? See <see cref=""Initialize(NLog.Config.LoggingConfiguration)""/>
+         /// </summary>
+         internal bool IsInitialized;
+-        private bool _scannedForObjects;
++        internal bool _scannedForObjects;
+ 
+         /// <summary>
+         /// Gets a value indicating whether this layout is thread-agnostic (can be rendered on any thread).",@snakefoot why is internal needed?,Should this be `internal`?
+6358,"@@ -190,11 +190,14 @@ func (s *server) startService() common.Daemon {
+ 		}
+ 
+ 		params.PublicClient, err = sdkclient.NewClient(sdkclient.Options{
+-			HostPort:          s.cfg.PublicClient.HostPort,
+-			Namespace:         common.SystemLocalNamespace,
+-			MetricsScope:      params.MetricScope,
+-			Logger:            l.NewZapAdapter(zapLogger),
+-			ConnectionOptions: sdkclient.ConnectionOptions{TLS: options},
++			HostPort:     s.cfg.PublicClient.HostPort,
++			Namespace:    common.SystemLocalNamespace,
++			MetricsScope: params.MetricScope,
++			Logger:       l.NewZapAdapter(zapLogger),
++			ConnectionOptions: sdkclient.ConnectionOptions{
++				TLS:                options,
++				DisableHealthCheck: true,
++			},
+ 		})
+ 		if err != nil {
+ 			log.Fatalf(""failed to create public client: %v"", err)",Why were we disabling health checks before?,Why do we need this?
+6359,"@@ -22,7 +22,7 @@ def check_src_files_have_test():
+ def check_test_files_have_src():
+     unknown_test_files = []
+ 
+-    excluded = ['test/mitmproxy/data/', 'test/mitmproxy/net/data/', '/tservers.py']
++    excluded = ['test/mitmproxy/data/', 'test/mitmproxy/net/data/', '/tservers.py', '/conftest.py']
+     test_files = glob.glob('test/mitmproxy/**/*.py', recursive=True) + glob.glob('test/pathod/**/*.py', recursive=True)
+     test_files = [f for f in test_files if os.path.basename(f) != '__init__.py']
+     test_files = [f for f in test_files if not any(os.path.normpath(p) in f for p in excluded)]",did `conftest.py` actually show up for you? `test_files` should never contain it...,I think this should be `/conftest.py`
+6360,"@@ -561,7 +561,8 @@ StmtDDLDropSchema::StmtDDLDropSchema(//const SchemaName & schemaName,
+   // If the schema name specified is reserved name, users cannot drop them.
+   // They can only be dropped internally.
+   if ((! Get_SqlParser_Flags(INTERNAL_QUERY_FROM_EXEUTIL)) &&
+-      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())))
++      (ComIsTrafodionReservedSchemaName(schemaQualName_.getSchemaName())) &&
++      (!ComIsTrafodionExternalSchemaName(schemaQualName_.getSchemaName())))
+     {
+       // error.
+       *SqlParser_Diags << DgSqlCode(-1430)",Should this be a ! on line 565? I would have expected the condition to be similar to line 564. If I am wrong please excuse my mistake.,Why is this needed?
+6361,"@@ -288,6 +288,10 @@ class DBUpgrader {
+ 
+             db.execSQL(""DROP TABLE "" + PodDBAdapter.TABLE_NAME_FEED_IMAGES);
+         }
++        if (oldVersion < 1070296) {
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_VOLUME_REDUCTION + "" INTEGER DEFAULT 0"");
++        }
+     }
+ 
+ }",Please change to `1070400`. I promise to look into this PR in more detail before the 1.7.4 release ;),Why do we need this
+6362,"@@ -68,15 +68,15 @@ public class FlinkParquetWriters {
+     }
+ 
+     @Override
+-    public ParquetValueWriter<?> message(RowType sStruct, MessageType message, List<ParquetValueWriter<?>> fields) {
++    public ParquetValueWriter<?> message(LogicalType sStruct, MessageType message, List<ParquetValueWriter<?>> fields) {
+       return struct(sStruct, message.asGroupType(), fields);
+     }
+ 
+     @Override
+-    public ParquetValueWriter<?> struct(RowType sStruct, GroupType struct,
++    public ParquetValueWriter<?> struct(LogicalType fStruct, GroupType struct,
+                                         List<ParquetValueWriter<?>> fieldWriters) {
+       List<Type> fields = struct.getFields();
+-      List<RowField> flinkFields = sStruct.getFields();
++      List<RowField> flinkFields = ((RowType) fStruct).getFields();
+       List<ParquetValueWriter<?>> writers = Lists.newArrayListWithExpectedSize(fieldWriters.size());
+       List<LogicalType> flinkTypes = Lists.newArrayList();
+       for (int i = 0; i < fields.size(); i += 1) {",Can we change to use `LogicalType.getChildren`?,`sStruct` -> `fStru
+6363,"@@ -1,10 +1,11 @@
+ require 'spec_helper'
+ 
+ describe '#create' do
+-  it 'sets the payment_method on Purchase to free' do
++  it 'sets the payment_method on Purchase to subscription' do
+     user = create(:user, :with_subscription)
+     create_subscriber_purchase(create(:book_product), user)
+-    user.purchases.last.payment_method.should == 'free'
++    user.purchases.last.payment_method.should eq 'free'
++    user.purchases.last[:payment_method].should eq 'subscription'
+   end
+ 
+   it 'sets the comments on the purchase if provided' do",I'm confused as to how these are both passing.,Use 2 (not 0) space
+6364,"@@ -0,0 +1,17 @@
++module DashboardsHelper
++  def learn_live_link(&block)
++    if current_user_has_access_to?(:office_hours)
++      link_to OfficeHours.url, target: ""_blank"", &block
++    else
++      content_tag ""a"", &block
++    end
++  end
++
++  def learn_repo_link(&block)
++    if current_user_has_access_to?(:source_code)
++      link_to ENV['LEARN_REPO_URL'], target: ""_blank"", &block
++    else
++      content_tag ""a"", &block
++    end
++  end
++end",Prefer single-quoted strings when you don't need string interpolation or special symbols.,Layout/EmptyLinesAroundModuleBody: Extra empty line detected at module body beginning.
+6365,"@@ -28,7 +28,7 @@ class CategoryData
+     public $seoH1s;
+ 
+     /**
+-     * @var string[]
++     * @var string[]|null[]
+      */
+     public $descriptions;
+ ","there is `""` sign in commit message and colon. can you rename also `descrition` to plural `descriptions` and add there `$` ?",Should be `string[]|null`
+6366,"@@ -108,7 +108,9 @@ func (ti *TelemetryInterceptor) Intercept(
+ 	resp, err := handler(ctx, req)
+ 
+ 	if val, ok := metrics.ContextCounterGet(ctx, metrics.HistoryWorkflowExecutionCacheLatency); ok {
+-		timerNoUserLatency.Subtract(time.Duration(val))
++		userLatencyDuration := time.Duration(val)
++		timerNoUserLatency.Subtract(userLatencyDuration)
++		metricsScope.RecordTimer(metrics.ServiceLatencyUserLatency, userLatencyDuration)
+ 	}
+ 
+ 	if err != nil {",timerNoUserLatency is not being used?,"I think you can use `metricsScope.RecordTimer(metrics.ServiceLatencyUserLatency, userL"
+6367,"@@ -603,6 +603,8 @@ class Serializer(object):
+         :param Date attr: Object to be serialized.
+         :rtype: str
+         """"""
++        if isinstance(attr, str):
++            attr = isodate.parse_date(attr)
+         t = ""{:04}-{:02}-{:02}"".format(attr.year, attr.month, attr.day)
+         return t
+ ","@lmazuel - I've made a couple of minor changes to serialization.py, if you could do a quick review :) They should not be breaking, and I doubt are used by the existing clients so may not need a new release yet. Effectively it's a change to support default/constant date and datetime values by allowing strings to passed in instead of date or datetime objects. The strings would need to already be in the correct ISO formatting that the request will serialize to. Let me know if you think this is okay.",Why is this needed?
+6368,"@@ -553,8 +553,8 @@ namespace pwiz.SkylineTest
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""15N\"" label_15N=\""true\"" />"", true, true, isotopeModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Heavy K\"" aminoacid=\""K\"" label_13C=\""true\"" label_15N=\""true\"" label_18O=\""true\""  label_2H=\""true\""/>"", true, true, isotopeModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Aqua\"" aminoacid=\""K, R\"" label_13C=\""true\"" label_15N=\""true\"" label_18O=\""true\""  label_2H=\""true\""/>"", true, true, isotopeModificationType);
+-            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss1\"" aminoacid=\""T, S\"" formula=\""HPO3\""><fragment_loss formula=\""HP3O4\""/></static_modification>"", true, true, isotopeModificationType);
+-            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss3\"" aminoacid=\""T, S\"" formula=\""HPO3\"" explicit_decl=\""true\""><fragment_loss formula=\""HP3O4\""/><fragment_loss formula=\""H2O\""/><fragment_loss formula=\""NH3\""/></static_modification>"", true, true, isotopeModificationType);
++            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss1\"" aminoacid=\""T, S\"" formula=\""HPO3\""><potential_loss formula=\""HP3O4\""/></static_modification>"", true, true, structuralModificationType);
++            AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss3\"" aminoacid=\""T, S\"" formula=\""HPO3\"" explicit_decl=\""true\""><potential_loss formula=\""HP3O4\""/><potential_loss formula=\""H2O\""/><potential_loss formula=\""NH3\""/></static_modification>"", true, true, structuralModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""Loss-only\"" aminoacid=\""K, R, Q, N\""><potential_loss formula=\""NH3\""/></static_modification>"", true, true, structuralModificationType);
+             AssertEx.DeserializeNoError<StaticMod>(""<static_modification name=\""LossInclusion\"" aminoacid=\""T, S\"" formula=\""HPO3\""><potential_loss formula=\""HP3O4\"" inclusion=\""Always\""/><potential_loss formula=\""HP2O3\"" inclusion=\""Library\""/><potential_loss formula=\""HP1O2\"" inclusion=\""Never\""/></static_modification>"", true, true, structuralModificationType);
+ ",Why change the name in the XML?,Why did you change these?
+6369,"@@ -132,7 +132,11 @@ class User < ActiveRecord::Base
+   # = Callbacks =
+   # =============
+ 
+-  after_update :when_org_changes
++  before_update :clear_other_organisation, if: :org_id_changed?
++
++  after_update :delete_perms!, if: :org_id_changed?, unless: :can_change_org?
++
++  after_update :remove_token!, if: :org_id_changed?, unless: :can_change_org?
+ 
+   # =================
+   # = Class methods =",This is much cleaner. makes it easier to tell what happens on a save.,I'm not sure if this is t
+6370,"@@ -212,6 +212,8 @@ func refineFiltersOperator(filters []datastore.ListFilter) ([]datastore.ListFilt
+ 			filter.Operator = ""IN""
+ 		case datastore.OperatorNotIn:
+ 			filter.Operator = ""NOT IN""
++		case datastore.OperatorContains:
++			// FIXME: Convert contains operator into one dedicated to MySQL
+ 		case datastore.OperatorNotEqual,
+ 			datastore.OperatorGreaterThan,
+ 			datastore.OperatorGreaterThanOrEqual,",Could you add return error unsupported operator here  ,Why is this needed?
+6371,"@@ -6,7 +6,8 @@
+ package javaslang.collection;
+ 
+ import javaslang.*;
+-import javaslang.collection.Stream.*;
++import javaslang.collection.Stream.Cons;
++import javaslang.collection.Stream.Empty;
+ import javaslang.collection.StreamModule.*;
+ import javaslang.control.Option;
+ ","(Mhh, we seem to use different formatters - we should unify them. I like the wildcards)",Why did you change this?
+6372,"@@ -54,8 +54,11 @@ func AdminDescribeTaskQueue(c *cli.Context) {
+ 	ctx, cancel := newContext(c)
+ 	defer cancel()
+ 	request := &workflowservice.DescribeTaskQueueRequest{
+-		Namespace:              namespace,
+-		TaskQueue:              &taskqueuepb.TaskQueue{Name: taskQueue},
++		Namespace: namespace,
++		TaskQueue: &taskqueuepb.TaskQueue{
++			Name: taskQueue,
++			Kind: enumspb.TASK_QUEUE_KIND_NORMAL,
++		},
+ 		TaskQueueType:          tlType,
+ 		IncludeTaskQueueStatus: true,
+ 	}",Should `kind` be a command line parameter also?,Why is this needed?
+6373,"@@ -43,7 +43,7 @@ namespace Nethermind.JsonRpc.Data
+             Gas = transaction.GasLimit;
+             Input = Data = transaction.Data;
+             Type = transaction.Type;
+-            AccessList = TryGetAccessListItems();
++            AccessList = transaction.AccessList is null ? null : AccessListItemForRpc.FromAccessList(transaction.AccessList);
+ 
+             Signature? signature = transaction.Signature;
+             if (signature != null)",can we have it inside FromAccessList?,Why do we need this
+6374,"@@ -64,6 +64,19 @@ var rawRequestPaths = map[string]bool{
+ 	""/v2/teal/compile"": true,
+ }
+ 
++// unauthorizedRequestError is generated when we receive 401 error from the server. This error includes the inner error
++// as well as the likely parameters that caused the issue.
++type unauthorizedRequestError struct {
++	errorString string
++	apiToken    string
++	url         string
++}
++
++// Error format an error string for the unauthorizedRequestError error.
++func (e unauthorizedRequestError) Error() string {
++	return fmt.Sprintf(""Unauthorized request to `%s` when using token `%s` : %s"", e.url, e.apiToken, e.errorString)
++}
++
+ // RestClient manages the REST interface for a calling user.
+ type RestClient struct {
+ 	serverURL       url.URL",Why not embed filterASCII in this function?,I don't think we ne
+6375,"@@ -1872,7 +1872,11 @@ public class ExecutorManager extends EventHandler implements
+           // process flow with current snapshot of activeExecutors
+           selectExecutorAndDispatchFlow(reference, exflow, new HashSet<Executor>(activeExecutors));
+         }
+-        currentContinuousFlowProcessed++;
++
++        // do not count failed flow processsing (flows still in queue)
++        if(queuedFlows.getFlow(exflow.getExecutionId()) == null) {
++          currentContinuousFlowProcessed++;
++        }
+       }
+     }
+ ","I am curious, shouldn't ""currentContinuousFlowProcessed++;"" be added right after line 1873? otherwise we will count 1 extra when a exflow wakes up from the sleep section,.even though it hasn't been assigned",Why do we need this
+6376,"@@ -162,6 +162,7 @@ def _get_configtypes():
+                                      configtypes._Numeric] and
+                            issubclass(e, configtypes.BaseType))
+     yield from inspect.getmembers(configtypes, predicate)
++    # pylint: enable=protected-access
+ 
+ 
+ def _get_setting_types_quickref():",You can probably move this up after the `._Numeric` line.,Why is this needed?
+6377,"@@ -203,6 +203,7 @@ class SGEJobTask(luigi.Task):
+         description=""don't tarball (and extract) the luigi project files"")
+ 
+     def __init__(self, *args, **kwargs):
++        super(SGEJobTask, self).__init__(*args, **kwargs)
+         if self.job_name:
+             # use explicitly provided job name
+             pass","@Tarrasch this is another change you need to pay attention, it seems `SGEJobTask` is not calling `super.__init__` which break the test case some how.",Why is this necessa
+6378,"@@ -0,0 +1,14 @@
++class CreateCompletions < ActiveRecord::Migration
++  def change
++    create_table :completions do |t|
++      t.string :trail_object_id
++      t.string :trail_name
++      t.belongs_to :user
++
++      t.timestamps
++    end
++
++    add_index :completions, :user_id
++    add_index :completions, :trail_object_id
++  end
++end",Do we need indices for this table?,I don't think we ne
+6379,"@@ -447,6 +447,19 @@ static int process_data(struct flb_http_client *c)
+     return FLB_HTTP_MORE;
+ }
+ 
++#if defined FLB_HAVE_TESTS_OSSFUZZ
++int fuzz_process_data(struct flb_http_client *c);
++int fuzz_process_data(struct flb_http_client *c) {
++	return process_data(c);
++}
++
++int fuzz_check_connection(struct flb_http_client *c);
++int fuzz_check_connection(struct flb_http_client *c) {
++    return check_connection(c);
++}
++
++#endif
++
+ static int proxy_parse(const char *proxy, struct flb_http_client *c)
+ {
+     int len;",what about making this function static inline to avoid the extra declaration ?,Why do we need thes
+6380,"@@ -21,6 +21,7 @@ import (
+ 
+ type protocol = string
+ type TableIDType uint8
++type GroupIDType = uint32
+ 
+ const LastTableID TableIDType = 0xff
+ ","I forget the difference between type definition with ""="" and without ""="" again, but can we unify the style? I believe the difference doesn't apply to TableIDType and GroupIDType whatever it is?",type GroupIDType uint8
+6381,"@@ -49,7 +49,7 @@ return_code parseArguments(int argc,
+         ""Number of threads to use"")(
+         ""core,k"",
+         boost::program_options::value<double>(&contractor_config.core_factor)->default_value(1.0),
+-        ""Percentage of the graph (in vertices) to contract [0..1]"")(
++        ""Percentage of the graph (in vertices) to contract [0..1]. Will always be 1.0"")(
+         ""segment-speed-file"",
+         boost::program_options::value<std::vector<std::string>>(
+             &contractor_config.updater_config.segment_speed_lookup_paths)",would be `DEPRECATED Percentage of the graph (in vertices) to contract [0..1]` better?,I don't think we shoul
+6382,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";  
++  String STOP_CASTING = ""stopCasting"";    
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`,I don't think these ar
+6383,"@@ -108,7 +108,7 @@ namespace OpenTelemetry.Exporter.Zipkin
+             }
+ 
+             string serviceName = null;
+-            Dictionary<string, object> tags = null;
++            Dictionary<string, object> tags = new Dictionary<string, object>();
+             foreach (var label in resource.Attributes)
+             {
+                 string key = label.Key;","if we won't use, should we remove this?",Why is this change nee
+6384,"@@ -230,7 +230,10 @@ namespace MvvmCross.Platforms.Android.Core
+ 
+         protected virtual IDictionary<string, string> ViewNamespaceAbbreviations => new Dictionary<string, string>
+         {
+-            { ""Mvx"", ""MvvmCross.Platforms.Android.Views"" }
++            { ""Mvx"", ""mvvmcross.platforms.android.views""
++            },
++            { ""Mvx"", ""mvvmcross.platforms.android.binding.views""
++            }
+         };
+ 
+         protected virtual IEnumerable<string> ViewNamespaces => new List<string>",Having 2 items with the same key (Mvx) won't work in a dictionary,I don't think we need the `Mvx` prefix here.
+6385,"@@ -0,0 +1,17 @@
++class CouponsController < ApplicationController
++  def show
++    if coupon.valid?
++      session[:coupon] = coupon.code
++    else
++      flash[:notice] = ""The coupon code you supplied is not valid.""
++    end
++
++    redirect_to root_path
++  end
++
++  private
++
++  def coupon
++    @coupon ||= Coupon.new(params[:id])
++  end
++end","@cpytel how does the flow work right now? I expect to go to the sign up as customer page after putting in my code, but it goes to the longer landing page?",I don't think you need the `private` here.
+6386,"@@ -75,10 +75,10 @@ void show_message(
+     //
+     switch (priority) {
+     case MSG_INTERNAL_ERROR:
+-        snprintf(event_msg, sizeof(event_msg), ""[error] %s"", message);
++        snprintf(event_msg, sizeof(event_msg), ""[error] %.512s"", message);
+         break;
+     case MSG_SCHEDULER_ALERT:
+-        snprintf(event_msg, sizeof(event_msg), ""%s: %s"",
++        snprintf(event_msg, sizeof(event_msg), ""%.64s: %.512s"",
+             _(""Message from server""), message
+         );
+         break;","`event_msg` has the same size (1024) as a `message`. Maybe should be increased to 2048 instead? Then this `""[error] %.512s"", message` could be changed to this: `""[error] %.*s"", sizeof(message), message`",Why do we need to change this?
+6387,"@@ -35,6 +35,7 @@ package org.apache.iceberg;
+  * changes.
+  */
+ public interface ReplacePartitions extends SnapshotUpdate<ReplacePartitions> {
++
+   /**
+    * Add a {@link DataFile} to the table.
+    *",Nit: unnecessary whitespace change.,Why do we need this?
+6388,"@@ -176,7 +176,7 @@ func (b *PinnedMap) Iter(f MapIter) error {
+ 	args := cmd[1:]
+ 
+ 	printCommand(prog, args...)
+-	output, err := exec.Command(prog, args...).CombinedOutput()
++	output, err := exec.Command(prog, args...).Output()
+ 	if err != nil {
+ 		return errors.Errorf(""failed to dump in map (%s): %s\n%s"", b.versionedFilename(), err, output)
+ 	}","Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`",Why did you remove the `CombinedOutput`?
+6389,"@@ -119,7 +119,15 @@ void image_data_reader::set_input_params(const int width, const int height, cons
+ 
+ bool image_data_reader::fetch_label(CPUMat& Y, int data_id, int mb_idx) {
+   const label_t label = m_image_list[data_id].second;
+-  Y.Set(label, mb_idx, 1);
++  if (label >= 0 && label < m_num_labels) {
++    Y.Set(label, mb_idx, 1);
++  }
++  else {
++    LBANN_ERROR(
++      ""\"""",this->get_type(),""\"" data reader "",
++      ""expects data with "",m_num_labels,"" labels, "",
++      ""but data sample "",data_id,"" has a label of "",label);
++  }
+   return true;
+ }
+ ",I would use static_cast<label_t>(0) and static_cast<label_T>(m_num_labels) just in case.,I think it would be better to use `LBANN
+6390,"@@ -406,4 +406,18 @@ public class ZMSUtils {
+ 
+         return authorityFilter;
+     }
++
++    public static String lowerDomainInResource(String resource) {
++        if (resource == null) {
++            return null;
++        }
++
++        int delimiterIndex = resource.indexOf("":"");
++        if (delimiterIndex == -1) {
++            return resource;
++        }
++
++        String lowerCasedDomain = resource.substring(0, delimiterIndex).toLowerCase();
++        return lowerCasedDomain + resource.substring(delimiterIndex);
++    }
+ }",Even if we want to keep in original case - domain will be lower-cased.,I think you can use `StringUtils.isNotBl
+6391,"@@ -0,0 +1,9 @@
++class RenameTopicBodyHtmlToTrailMap < ActiveRecord::Migration
++  def up
++    rename_column :topics, :body_html, :trail_map
++  end
++
++  def down
++    rename_column :topics, :trail_map, :body_html
++  end
++end",Based on discussion with Chad it feels like trail_map_json could be a good column name.,I don't think we need to rename this col
+6392,"@@ -98,9 +98,9 @@ class Users extends Controller
+                 'comment' => $permission->comment,
+                 'type' => 'balloon-selector',
+                 'options' => [
+-                    1 => 'Allow',
+-                    0 => 'Inherit',
+-                    -1 => 'Deny',
++                    1 => Lang::get('backend::lang.user.allow'),
++                    0 => Lang::get('backend::lang.user.inherit'),
++                    -1 => Lang::get('backend::lang.user.deny'),
+                 ],
+                 'attributes' => [
+                     'data-trigger' => ""input[name='User[permissions][superuser]']"",","This array should be logic-less, just the language string (without `Lang::get()`) should appear. Then `trans()` is [or should be] used when the balloon selector renders the values.",Shouldn't this be `Lang::get('backend::lang.user.allow')`?
+6393,"@@ -253,7 +253,7 @@ module Beaker
+         else
+           task = 'defaultgroup:ensure_default_group'
+         end
+-        on dashboard, ""/opt/puppet/bin/rake -sf /opt/puppet/share/puppet-dashboard/Rakefile #{task} RAILS_ENV=production""
++        on dashboard, ""BUNDLE_GEMFILE=/opt/puppet/share/puppet-dashboard/Gemfile /opt/puppet/bin/bundle/exec /opt/puppet/bin/rake -sf /opt/puppet/share/puppet-dashboard/Rakefile #{task} RAILS_ENV=production""
+ 
+         # Now that all hosts are in the dashbaord, run puppet one more
+         # time to configure mcollective","This looks like it runs both pre 3.0 rake tasks and 3 rake tasks, and since pre 3.0 we didn't use bundler, my guess is it will fail then.","on dashboard, ""BUNDLE_GEMFILE=/opt/puppet/share/puppet-das"
+6394,"@@ -450,7 +450,14 @@ func (m *Manager) Set(container *configs.Config) error {
+ }
+ 
+ func getUnitName(c *configs.Cgroup) string {
+-	return fmt.Sprintf(""%s-%s.scope"", c.Parent, c.Name)
++	allowed := ""0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ:-_.\\""
++	sanitizeFunc := func(r rune) rune {
++		if strings.ContainsRune(allowed, r) {
++			return r
++		}
++		return '.'
++	}
++	return fmt.Sprintf(""%s-%s.scope"", strings.Map(sanitizeFunc, c.Parent), strings.Map(sanitizeFunc, c.Name))
+ }
+ 
+ // Atm we can't use the systemd device support because of two missing things:","I'm not sure the replacement is a good idea, and as I said in #336 , this ""parent-name.scope"" is not a good idea in the first place, specially when we support assigning a slice as the parent, so we should change this, WDYT?",Why not use `strings.ReplaceAll`?
+6395,"@@ -627,7 +627,7 @@ func (dao *blockDAO) putBlock(blk *block.Block) error {
+ 			log.L().Error(""failed to serialize receipits for block"", zap.Uint64(""height"", blkHeight))
+ 		}
+ 	}
+-	if err = kv.Commit(batchForBlock); err != nil {
++	if err = kv.WriteBatch(batchForBlock); err != nil {
+ 		return err
+ 	}
+ ",sloppyReassign: re-assignment to `err` can be replaced with `err := kv.WriteBatch(batchForBlock)` (from `gocritic`),Why do we need to change this?
+6396,"@@ -123,7 +123,11 @@ public class VertxServerResponseToHttpServletResponse extends AbstractHttpServle
+   @Override
+   public CompletableFuture<Void> sendPart(Part part) {
+     DownloadUtils.prepareDownloadHeader(this, part);
+-
++    if (part == null) {
++      CompletableFuture<Void> future = new CompletableFuture<>();
++      future.complete(null);
++      return future;
++    }
+     return new PumpFromPart(context, part).toWriteStream(serverResponse, null);
+   }
+ ",using factory method. return CompletableFuture.completedFuture,Why is this needed?
+6397,"@@ -31,7 +31,7 @@ storiesOf( 'Global', module )
+ 				title={ __( 'Top content over the last 28 days', 'google-site-kit' ) }
+ 				headerCtaLink=""https://analytics.google.com""
+ 				headerCtaLabel={ __( 'See full stats in Analytics', 'google-site-kit' ) }
+-				footerCtaLabel={ __( 'Analytics', 'google-site-kit' ) }
++				footerCtaLabel={ _x( 'Analytics', 'Service name', 'google-site-kit' ) }
+ 				footerCtaLink=""https://analytics.google.com""
+ 			>
+ 				<AnalyticsDashboardWidgetTopPagesTable />",The `_x` function needs to be imported at the top of the file (in addition to `__`),Should this be `_x(
+6398,"@@ -19,7 +19,7 @@ type ofFlow struct {
+ 	// The Flow.Table field can be updated by Reset(), which can be called by
+ 	// ReplayFlows() when replaying the Flow to OVS. For thread safety, any access
+ 	// to Flow.Table should hold the replayMutex read lock.
+-	ofctrl.Flow
++	*ofctrl.Flow
+ 
+ 	// matchers is string slice, it is used to generate a readable match string of the Flow.
+ 	matchers []string",this looks like the only controversial change potentially. @MatthewHinton56 Could let us know why you made this change (which `go vet` warning was triggered)? @wenyingd could you take a look and let us know if you're okay with this change?,Why do we need this
+6399,"@@ -26,7 +26,7 @@ using pwiz.Skyline.Util;
+ 
+ namespace pwiz.Skyline.Controls.Graphs
+ {
+-    public sealed partial class AreaCVToolbar : GraphSummaryToolbar //UserControl // for designer
++    public sealed partial class AreaCVToolbar : GraphSummaryToolbar //GraphSummaryToolbar UserControl // for designer
+     {
+         private readonly Timer _timer;
+         private int _standardTypeCount;","This seems like left-over debugging code. I think I fixed this to no longer be necessary, switching to UserControl for the designer.",Why did you change 
+6400,"@@ -0,0 +1,15 @@
++import re
++import logging
++from localstack.utils.common import to_str, to_bytes
++from localstack.services.generic_proxy import ProxyListener
++from moto.elbv2 import urls
++
++LOG = logging.getLogger(__name__)
++
++
++class ProxyListenerELBV2(ProxyListener):
++    pass
++
++
++# # instantiate listener
++UPDATE_ELBV2 = ProxyListenerELBV2()","As we're currently not applying any logic in the proxy listener, I guess we can simply remove this file (and remove the `listener` argument from the `register_plugin(..)` call above).",I don't think this is used.
+6401,"@@ -86,6 +86,7 @@ func (w *DefaultWorker) Generate(ctx context.Context,
+ 		Proof:           proof,
+ 		StateRoot:       newStateTreeCid,
+ 		Ticket:          ticket,
++		Timestamp:       types.Uint64(time.Now().Unix()),
+ 	}
+ 
+ 	for i, msg := range res.PermanentFailures {",Isn't the point of the clock module to encapsulate access to `time.Now()`? Coming later?,Why do we need this?
+6402,"@@ -117,6 +117,10 @@ func generateFastUpgradeConsensus() (fastUpgradeProtocols config.ConsensusProtoc
+ 		}
+ 
+ 		fastUpgradeProtocols[consensusTestFastUpgrade(proto)] = fastParams
++
++		// support the ALGOSMALLLAMBDAMSEC = 500 env variable
++		fastParams.AgreementFilterTimeout = time.Second
++		fastParams.AgreementFilterTimeoutPeriod0 = time.Second
+ 	}
+ 	return
+ }","as before - if you've set this, you should be able to get rid of the `os.Setenv(""ALGOSMALLLAMBDAMSEC"", ""500"")`. make sure that the various tests still takes have the same execution time.",why do we need this?
+6403,"@@ -450,8 +450,8 @@ module Travis
+             mactex = 'BasicTeX.pkg'
+             # TODO(craigcitro): Confirm that this will route us to the
+             # nearest mirror.
+-            sh.cmd 'wget http://mirror.ctan.org/systems/mac/mactex/'\
+-                   ""#{mactex} -O \""/tmp/#{mactex}\""""
++            sh.cmd 'curl -fLo \""/tmp/#{mactex}\"" --retry 3 http://mirror.ctan.org/systems/mac/mactex/'\
++                   '#{mactex}'
+ 
+             sh.echo 'Installing OS X binary package for MacTeX'
+             sh.cmd ""sudo installer -pkg \""/tmp/#{mactex}\"" -target /""","Pretty sure the single quotes here should be double quotes, single quotes are not expanded by the shell.",Why not use `curl -fLo #{ma
+6404,"@@ -109,8 +109,11 @@ public final class ValidateConstantMessageTests {
+                         ""  void f(boolean bArg, int iArg, Object oArg, Integer[] arrayArg, ""
+                             + ""Collection<String> collectionArg, Map<String, String> mapArg, String stringArg, ""
+                             + ""Iterable<String> iterableArg, double dArg) {"",
++                        ""    String localConstant = \""constant\"";"",
+                         ""    Validate.isTrue(bArg, \""message %d\"", 123L);"",
+                         ""    Validate.isTrue(bArg, \""message %f\"", 0.0);"",
++                        ""    Validate.notBlank(stringArg, \""message %s\"", compileTimeConstant);"",
++                        ""    Validate.notBlank(stringArg, \""message %s\"", localConstant);"",
+                         ""    Validate.isTrue(bArg, \""message %s %s\"", \""msg\"", \""msg\"");"",
+                         ""    Validate.notNull(oArg, \""message %s %s\"", \""msg\"", \""msg\"");"",
+                         ""    Validate.notEmpty(arrayArg, \""message %s %s\"", \""msg\"", \""msg\"");"",","these are not really constants, right?",Why do we need this?
+6405,"@@ -1,3 +1,4 @@
++from boto.compat import six
+ # Copyright (c) 2012 Mitch Garnaat http://garnaat.org/
+ # Copyright (c) 2012 Amazon.com, Inc. or its affiliates.  All Rights Reserved
+ #",import below copyright statement,This should be `from
+6406,"@@ -49,7 +49,7 @@ describe InvoiceNotifier do
+ 
+   def customer_should_receive_receipt_email(invoice)
+     email = ActionMailer::Base.deliveries.first
+-    email.subject.should include('receipt')
+-    email.to.should eq [invoice.user_email]
++    expect(email.subject).to include('receipt')
++    expect(email.to).to eq [invoice.user_email]
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [8
+6407,"@@ -200,11 +200,11 @@ class Field implements Translatable
+     }
+ 
+     /**
+-     * @return string|Markup
++     * @return string|array|Markup
+      */
+     public function getTwigValue()
+     {
+-        $value = $this->__toString();
++        $value = $this->getFlattenedValue();
+ 
+         if ($this->getDefinition()->get('allow_html')) {
+             $value = new Markup($value, 'UTF-8');",`if (is_string($value) && $this->getDefinition()->get('allow_html')) {`,Why did you remove t
+6408,"@@ -133,7 +133,7 @@ namespace OpenTelemetry.Trace
+ 
+         private void AddInternal(string key, object value)
+         {
+-            Guard.Null(key, nameof(key));
++            Debug.Assert(key != null, $""{nameof(key)} must not be null"");
+ 
+             this.Attributes[key] = value;
+         }","I think we have the same problem here - if folks called the `public void Add` with a `null` key, we need to use `Guard`.",Why is this change needed?
+6409,"@@ -0,0 +1,12 @@
++//
++//  Copyright (C) 2020 Greg Landrum
++//   @@ All Rights Reserved @@
++//  This file is part of the RDKit.
++//  The contents are covered by the terms of the BSD license
++//  which is included in the file license.txt, found at the root
++//  of the RDKit source tree.
++//
++
++#define CATCH_CONFIG_MAIN  // This tells Catch to provide a main() - only do
++                           // this in one cpp file
++#include ""catch.hpp""",I thought that the main was in catch_qt.cpp?,Why is this needed?
+6410,"@@ -87,7 +87,7 @@ public class ImagesManageActivity extends BaseActivity {
+     private static final int REQUEST_UNSELECT_IMAGE_AFTER_LOGIN = 4;
+     public static final int REQUEST_EDIT_IMAGE = 1000;
+     private static final int REQUEST_CHOOSE_IMAGE = 1001;
+-    private static final List<ProductImageField> TYPE_IMAGE = Arrays.asList(ProductImageField.FRONT, ProductImageField.INGREDIENTS, ProductImageField.NUTRITION);
++    private static final List<ProductImageField> TYPE_IMAGE = Arrays.asList(ProductImageField.FRONT, ProductImageField.INGREDIENTS, ProductImageField.NUTRITION, ProductImageField.PACKAGING);
+     private ActivityFullScreenImageBinding binding;
+     private OpenFoodAPIClient client;
+     private File lastViewedImage;","I would rename the field to IMAGE_TYPES and make it an array. I don't think we need list operations. Also, if possible, I would move the field to the ApiFields class. What do you think?",I don't think we need to a
+6411,"@@ -117,6 +117,17 @@ func verifyContainerRunningStateChangeWithRuntimeID(t *testing.T, taskEngine Tas
+ 		""Expected container runtimeID should not empty"")
+ }
+ 
++func verifyExecAgentRunningStateChange(t *testing.T, taskEngine TaskEngine) {
++	stateChangeEvents := taskEngine.StateChangeEvents()
++	event := <-stateChangeEvents
++	containerEvent := event.(api.ContainerStateChange)
++	assert.NotEmpty(t, containerEvent.ManagedAgents, ""Expected exec-agent event has no managed agents"")
++	if containerEvent.ManagedAgents != nil {
++		assert.Equal(t, apicontainerstatus.ManagedAgentRunning, containerEvent.ManagedAgents[0].Status,
++			""expected managedAgent container state change event did not match actual event"")
++	}
++}
++
+ func verifyContainerStoppedStateChange(t *testing.T, taskEngine TaskEngine) {
+ 	stateChangeEvents := taskEngine.StateChangeEvents()
+ 	event := <-stateChangeEvents","I'd prefer to timeout on this, but I know it's not a pattern that is being followed",nit: `expected managedAgen
+6412,"@@ -37,10 +37,7 @@ import org.apache.lucene.store.BufferedChecksumIndexInput;
+ import org.apache.lucene.store.ChecksumIndexInput;
+ import org.apache.lucene.store.IOContext;
+ import org.apache.lucene.store.IndexInput;
+-import org.apache.lucene.util.BytesRef;
+-import org.apache.lucene.util.BytesRefBuilder;
+-import org.apache.lucene.util.IOUtils;
+-import org.apache.lucene.util.StringHelper;
++import org.apache.lucene.util.*;
+ 
+ /**
+  * Reads vector values from a simple text format. All vectors are read up front and cached in RAM in",hmm let's not use * imports please,Please don't use wildcard imports.
+6413,"@@ -497,6 +497,10 @@ func generateAlertmanagerConfig(version semver.Version, am v1.AlertmanagerEndpoi
+ 		cfg = append(cfg, k8sSDWithNamespaces([]string{am.Namespace}))
+ 	}
+ 
++	if am.BearerTokenFile != """" {
++		cfg = append(cfg, yaml.MapItem{Key: ""bearer_token_file"", Value: am.BearerTokenFile})
++	}
++
+ 	var relabelings []yaml.MapSlice
+ 
+ 	relabelings = append(relabelings, yaml.MapSlice{",is this configuration key already exist in prometheus ?,I don't think this is needed.
+6414,"@@ -2,6 +2,7 @@ require ""test_helper""
+ 
+ class DiaryEntryControllerTest < ActionController::TestCase
+   include ActionView::Helpers::NumberHelper
++  api_fixtures
+ 
+   def setup
+     # Create the default language for diary entries","As @gravitystorm said new tests need to be using factories, not fixtures.",Why is this needed?
+6415,"@@ -171,8 +171,8 @@ bool CliManager::readLine(std::string &line, bool linebreak) {
+         if (!isInteractive_) {
+             break;
+         }
+-        auto purePrompt = folly::stringPrintf(""(%s@%s:%d) [%s]> "",
+-                                              username_.c_str(), addr_.c_str(), port_,
++        auto purePrompt = folly::stringPrintf(""(%s@) [%s]> "",
++                                              username_.c_str(),
+                                               cmdProcessor_->getSpaceName().c_str());
+         if (linebreak) {
+             purePrompt.assign(purePrompt.size() - 3, ' ');",You can replace IP by hostname.,I'm not sure if this is the right 
+6416,"@@ -123,13 +123,14 @@ def getDriversForConnectedUsbDevices():
+ 			for port in deviceInfoFetcher.comPorts if ""usbID"" in port)
+ 	)
+ 	for match in usbDevs:
+-		# check for the Braille HID protocol before any other device matching.
+-		if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILLE:
+-			yield (""hid"", match)
+ 		for driver, devs in _driverDevices.items():
+ 			for type, ids in devs.items():
+ 				if match.type==type and match.id in ids:
+ 					yield driver, match
++		# check for the Braille HID protocol after any other device matching.
++		if match.type == KEY_HID and match.deviceInfo.get('HIDUsagePage') == HID_USAGE_PAGE_BRAILLE:
++			yield (""hid"", match)
++
+ 
+ def getDriversForPossibleBluetoothDevices():
+ 	""""""Get any matching drivers for possible Bluetooth devices.","This should say ""why"" NVDA should do things in this order.",Why is this removed?
+6417,"@@ -114,7 +114,7 @@ func TestPopulateLocationConstraint(t *testing.T) {
+ func TestNoPopulateLocationConstraintIfProvided(t *testing.T) {
+ 	s := s3.New(unit.Session)
+ 	req, _ := s.CreateBucketRequest(&s3.CreateBucketInput{
+-		Bucket: aws.String(""bucket""),
++		Bucket:                    aws.String(""bucket""),
+ 		CreateBucketConfiguration: &s3.CreateBucketConfiguration{},
+ 	})
+ 	if err := req.Build(); err != nil {",nit these will get changed back during next release.,Why did you change t
+6418,"@@ -0,0 +1,8 @@
++// Copyright 2021 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package api
++
++// Version is set in the build process.
++var Version string",it is actually not needed to make the member public. the build tags can also set a package scoped variable.,Why do we need this?
+6419,"@@ -38,6 +38,7 @@ trait ContentExtrasTrait
+             'excerpt' => $this->contentExtension->getExcerpt($content),
+             'link' => $this->contentExtension->getLink($content),
+             'editLink' => $this->contentExtension->getEditLink($content),
++            'icon' => $this->contentExtension->getIcon($content),
+         ];
+     }
+ }",We already have a method for it 'icon' => $content->getIcon(),Shouldn't this be `g
+6420,"@@ -9,6 +9,7 @@ import (
+ 	""github.com/aws/aws-sdk-go/service/kms""
+ 	""github.com/aws/aws-sdk-go/service/s3""
+ 	""github.com/aws/aws-sdk-go/service/s3/s3iface""
++	""golang.org/x/net/context""
+ )
+ 
+ // WrapEntry is builder that return a proper key decrypter and error",Instead of importing `golang.org/x/net/context` The SDK should use `aws.BackgroundContext()` instead of `context.Background()`,This import should be grouped with the other aws-sdk-go imports.
+6421,"@@ -38,7 +38,7 @@ class MediaController extends Controller
+      */
+     public function getMedia($id)
+     {
+-        return $this->get('sonata.media.manager.media')->findOneBy(array('id' => $id));
++        return $this->get('sonata.media.manager.media')->find($id);
+     }
+ 
+     /**",I think this is an agnostic change for the ORM right? Why was it doing this? - this does not work on PHPCR-ODM as the `id` is not a field - although I guess it could be mapped as such.,Why did you change this?
+6422,"@@ -73,7 +73,7 @@ class ApplicationController < ActionController::Base
+   helper_method :included_in_current_users_plan?
+ 
+   def topics
+-    Topic.top
++    Topic.all
+   end
+   helper_method :topics
+ ","I'm not 100% sure, but I think this should be `explorable`. If not, I think `explorable` can be removed entirely.",Why is this change needed?
+6423,"@@ -124,15 +124,13 @@ class MockTarget(target.FileSystemTarget):
+                 self.wrapper = wrapper
+ 
+             def write(self, data):
+-                if six.PY3:
+-                    stderrbytes = sys.stderr.buffer
+-                else:
+-                    stderrbytes = sys.stderr
+-
+                 if mock_target._mirror_on_stderr:
+                     if self._write_line:
+                         sys.stderr.write(fn + "": "")
+-                    stderrbytes.write(data)
++                    if six.binary_type:
++                        sys.stderr.write(data.decode('utf8'))
++                    else:
++                        sys.stderr.write(data)
+                     if (data[-1]) == '\n':
+                         self._write_line = True
+                     else:",Note to self: Why was this not originally not using `stderrbytes`?,I think this should be `six.binary_type`.
+6424,"@@ -364,6 +364,14 @@ bool FileUtils::exist(const std::string& path) {
+     return access(path.c_str(), F_OK) == 0;
+ }
+ 
++// static
++bool FileUtils::rename(const std::string& src, const std::string& dst) {
++    auto status = ::rename(src.c_str(), dst.c_str());
++    LOG_IF(WARNING, status < 0) << ""Rename "" << src << "" to "" << dst << "" failed, the errno: ""
++        << ::strerror(errno);
++    return status == 0;
++}
++
+ std::vector<std::string> FileUtils::listAllTypedEntitiesInDir(
+         const char* dirpath,
+         FileType type,","Is betterLOG_IF(ERROR, status != 0) ?",Why is this a warning? Shouldn't it be an error?
+6425,"@@ -38,6 +38,9 @@ class BaseLoadTest(TestCase):
+         self.session.auth = self.auth
+         self.session.headers.update({'Content-Type': 'application/json'})
+ 
++        self.bucket = 'default'
++        self.collection = 'default'
++
+         # Keep track of created objects.
+         self._collections_created = {}
+ ",I wouldn't call it default too.,Why do we need these?
+6426,"@@ -2,6 +2,7 @@
+  * and will be replaced soon by a Vue component.
+  */
+ 
++/* eslint-disable no-var */
+ import browser from 'browser';
+ import dom from 'dom';
+ import 'css!./navdrawer';",Why disable the rule for this file?,Why is this needed?
+6427,"@@ -76,6 +76,7 @@ CTA.propTypes = {
+ 	'aria-label': PropTypes.string,
+ 	error: PropTypes.bool,
+ 	onClick: PropTypes.func,
++	ctaLinkExternal: PropTypes.bool,
+ };
+ 
+ CTA.defaultProps = {",Thanks for adding this :+1:. Could you please move it to go after the `ctaLink` prop?,I don't think we need the `<msg>`<msg>`ctaLinkEx
+6428,"@@ -193,7 +193,7 @@ namespace Nethermind.Core.Collections
+ 
+             public T Current => _array[_index];
+ 
+-            object IEnumerator.Current => Current;
++            object IEnumerator.Current => Current!;
+ 
+             public void Dispose() { }
+         }",The other way around Current can be null.,Why is this needed?
+6429,"@@ -230,7 +230,8 @@ class SideMenuBuilder
+ 
+         $communicationMenu = $menu->addChild('communication', ['label' => t('Communication with customer')]);
+         $communicationMenu->addChild('mail_settings', ['route' => 'admin_mail_setting', 'label' => t('Email settings')]);
+-        $communicationMenu->addChild('mail_templates', ['route' => 'admin_mail_template', 'label' => t('Email templates')]);
++        $mailTemplates = $communicationMenu->addChild('mail_templates', ['route' => 'admin_mail_template', 'label' => t('Email templates')]);
++        $mailTemplates->addChild('edit_template', ['route' => 'admin_mail_edit', 'label' => t('Editing email template'), 'display' => false]);
+         $communicationMenu->addChild('order_confirmation', ['route' => 'admin_customercommunication_ordersubmitted', 'label' => t('Order confirmation page')]);
+ 
+         $listsMenu = $menu->addChild('lists', ['label' => t('Lists and nomenclatures')]);",why does it have to be here? Due to breadcrumb navigation?,I don't think you n
+6430,"@@ -21,10 +21,18 @@ import (
+ 
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	""github.com/openebs/maya/pkg/util""
++	""k8s.io/apimachinery/pkg/api/resource""
+ 	v1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/types""
+ )
+ 
++//TODO: Move to some common function
++func StrToQuantity(capacity string) resource.Quantity {
++	qntCapacity, _ := resource.ParseQuantity(capacity)
++	//	fmt.Printf(""Error: %v"", err)
++	return qntCapacity
++}
++
+ // TestCreateVolumeTarget is to test cStorVolume creation.
+ func TestCreateVolumeTarget(t *testing.T) {
+ 	testVolumeResource := map[string]struct {",I fear moving this to some common func. We are swallowing the error here. This might be ok in UT but not in actual source code.,Can we remove this?
+6431,"@@ -716,12 +716,9 @@ class TestMessagesStore(object):
+         with pytest.raises(InvalidMessageError) as cm:
+             store.add_renamed_message(
+                 'W1234', 'old-msg-symbol', 'duplicate-keyword-arg')
+-        assert str(cm.value) == ""Message id 'W1234' is already defined""
+-        # conflicting message symbol
+-        with pytest.raises(InvalidMessageError) as cm:
+-            store.add_renamed_message(
+-                'W1337', 'msg-symbol', 'duplicate-keyword-arg')
+-        assert str(cm.value) == ""Message symbol 'msg-symbol' is already defined""
++        expected = ""Message id 'W1234' cannot have both 'msg-symbol' and \
++'old-msg-symbol' as symbolic name.""
++        assert str(cm.value) == expected
+ 
+     def test_renamed_message_register(self, store):
+         assert 'msg-symbol' == store.check_message_id('W0001').symbol","Please don't use \ as a line continuation. Do an implicit string join instead with parens: ``` (""Message ..."" ""and ..."")",Why did you remove 
+6432,"@@ -258,7 +258,6 @@ func NewBee(addr string, swarmAddress swarm.Address, publicKey ecdsa.PublicKey,
+ 		return nil, fmt.Errorf(""localstore: %w"", err)
+ 	}
+ 	b.localstoreCloser = storer
+-	// register localstore unreserve function on the batchstore before batch service starts listening to blockchain events
+ 
+ 	batchStore, err := batchstore.New(stateStore, nil)
+ 	if err != nil {",there needs to be a change here. setting up the batchstore with localstore.Unreserve hook,Why is this removed?
+6433,"@@ -52,9 +52,15 @@ public final class ConfigUtil {
+ 
+   private static final String MICROSERVICE_CONFIG_LOADER_KEY = ""cse-microservice-config-loader"";
+ 
++  private static ConfigModel model = new ConfigModel();
++
+   private ConfigUtil() {
+   }
+ 
++  public static void setConfigs(Map<String, Object> config) {
++    model.setConfig(config);
++  }
++
+   public static Object getProperty(String key) {
+     Object config = DynamicPropertyFactory.getBackingConfigurationSource();
+     return getProperty(config, key);","I think if we can provide a more convenient method to add configs . e.g. public static void addConfig(String k, Object v)",Why do we need this 
+6434,"@@ -266,7 +266,7 @@ func TestActPool_AddActs(t *testing.T) {
+ 	err = ap.AddTsf(overBalTsf)
+ 	require.Equal(ErrBalance, errors.Cause(err))
+ 	// Case VI: over gas limit
+-	creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), blockchain.GasLimit+100, big.NewInt(10), []byte{})
++	creationExecution, err := action.NewExecution(addr1.RawAddress, action.EmptyAddress, uint64(5), big.NewInt(int64(0)), action.GasLimit+100, big.NewInt(10), []byte{})
+ 	require.NoError(err)
+ 	err = ap.AddExecution(creationExecution)
+ 	require.Equal(ErrGasHigherThanLimit, errors.Cause(err))",line is 165 characters,why this change?
+6435,"@@ -0,0 +1,8 @@
++package org.jkiss.dbeaver.ext.oceanbase.data;
++
++import org.jkiss.dbeaver.model.impl.jdbc.data.handlers.JDBCStandardValueHandlerProvider;
++
++public class OceanbaseValueHandlerProvider extends JDBCStandardValueHandlerProvider{
++
++
++}","Please add a copyright notice. Also, could you tell me please why do we need this empty provider here?",Missing copyright he
+6436,"@@ -95,8 +95,11 @@ public class EeaSendRawTransaction implements JsonRpcMethod {
+         maybePrivacyGroup =
+             privacyController.retrieveOnChainPrivacyGroup(
+                 maybePrivacyGroupId.get(), enclavePublicKey);
+-        if (maybePrivacyGroup.isEmpty()
+-            && !privacyController.isGroupAdditionTransaction(privateTransaction)) {
++        if (maybePrivacyGroup.isEmpty()) {
++          if (!privacyController.isGroupAdditionTransaction(privateTransaction)) {
++            return new JsonRpcErrorResponse(id, JsonRpcError.ONCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST);
++          }
++        } else if (!maybePrivacyGroup.get().getMembers().contains(enclavePublicKey)) {
+           return new JsonRpcErrorResponse(id, JsonRpcError.ONCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST);
+         }
+       } else { // !onchainPirvacyGroupEnabled",I feel like this would be easier to read if we join the two if's together: `if (maybePrivacyGroup.isEmpty() && !privacyController.isGroupAdditionTransaction(privateTransaction))`,Why do we need this change?
+6437,"@@ -567,7 +567,7 @@ public class DBOpenHelper extends SQLiteOpenHelper {
+ 		try {
+ 			result = new JSONObject(loadSoupBlobAsString(soupTableName, soupEntryId, passcode));
+ 
+-		} catch (JSONException ex) {
++		} catch (Exception ex) {
+ 			Log.e(""DBOpenHelper:loadSoupBlob"", ""Exception occurred while attempting to read external soup blob."", ex);
+ 		}
+ 		return result;","Tests are failing because the exception type is NullPointException here if the soupBlob is deleted (so instead of a mal-format json, it's a null)",Shouldn't this be `JSONExce
+6438,"@@ -439,12 +439,8 @@ Blockly.Connection.prototype.isConnectionAllowed = function(candidate) {
+       break;
+     }
+     case Blockly.OUTPUT_VALUE: {
+-      // Don't offer to connect an already connected left (male) value plug to
+-      // an available right (female) value plug.
+-      if (candidate.targetConnection || this.targetConnection) {
+-        return false;
+-      }
+-      break;
++      // Can't drag an input to an output--you have to move the inferior block.
++      return false;
+     }
+     case Blockly.INPUT_VALUE: {
+       // Offering to connect the left (male) of a value block to an already","Glad we fixed this as well. Blockly is going to be left as-is for this case, right?",I'm not sure if this is the
+6439,"@@ -36,9 +36,7 @@ import java.util.Locale;
+  * This class represents a typical Salesforce object.
+  *
+  * @author bhariharan
+- * @deprecated Will be removed in Mobile SDK 7.0.
+  */
+-@Deprecated
+ public class SalesforceObject {
+ 
+     protected String objectType;",I had accidentally deprecated this class. This is meant to stick around. Only `SalesforceObjectType` goes away.,Why is this class being rem
+6440,"@@ -208,6 +208,7 @@ def rev_hex(s):
+ def int_to_hex(i, length=1):
+     assert isinstance(i, int)
+     s = hex(i)[2:].rstrip('L')
++    s = s.lstrip('0x')
+     s = ""0""*(2*length - len(s)) + s
+     return rev_hex(s)
+ ",`hex(i)[2:]` is trying to do the same thing above. what is `i` in your malformed case?,Why is this needed?
+6441,"@@ -126,8 +126,8 @@ public class XML {
+     }
+   }
+ 
+-  /** escapes character data in val */
+-  public final static void writeXML(Writer out, String tag, String val, Object... attrs) throws IOException {
++  /** escapes character data in val if shouldEscape is true*/
++  public final static void writeXML(Writer out, String tag, boolean shouldEscape, String val, Object... attrs) throws IOException {
+     out.write('<');
+     out.write(tag);
+     for (int i=0; i<attrs.length; i++) {","I think this change is redundant; see the previously defined method ""writeUnescapedXML"".",I don't think we ne
+6442,"@@ -0,0 +1,18 @@
++package types
++
++import cbor ""gx/ipfs/QmRoARq3nkUb13HSKZGepCZSWe5GrVPwx7xURJGZ7KWv9V/go-ipld-cbor""
++
++func init() {
++	cbor.RegisterCborType(Commitments{})
++}
++
++// CommitmentLength is the length of a single commitment (in bytes).
++const CommitmentLength = 32
++
++// Commitments is a struct containing the replica and data commitments produced
++// when sealing a sector.
++type Commitments struct {
++	CommD     [CommitmentLength]byte
++	CommR     [CommitmentLength]byte
++	CommRStar [CommitmentLength]byte
++}",Ah now I have at least some idea what these are for.,Why is this a point
+6443,"@@ -58,8 +58,8 @@ public class DataReader<T> implements DatumReader<T> {
+   }
+ 
+   @Override
+-  public void setSchema(Schema fileSchema) {
+-    this.fileSchema = Schema.applyAliases(fileSchema, readSchema);
++  public void setSchema(Schema schema) {
++    this.fileSchema = Schema.applyAliases(schema, readSchema);
+   }
+ 
+   @Override",I believe in previous PRs @mccheah frequently used `fileSchema` -> `newFileSchema` type of renames to avoid hiding fields in builders. Would it make sense to make it consistent?,Why is this change 
+6444,"@@ -62,9 +62,17 @@ func (manager *connectionManager) Connect(consumerID, providerID identity.Identi
+ 		}
+ 	}()
+ 
++	err = manager.startConnection(consumerID, providerID)
++	if err == utils.ErrRequestCancelled {
++		return ErrConnectionCancelled
++	}
++	return err
++}
++
++func (manager *connectionManager) startConnection(consumerID, providerID identity.Identity) (err error) {
+ 	cancelable := utils.NewCancelable()
+ 	manager.cleanConnection = utils.CallOnce(func() {
+-		log.Info(managerLogPrefix, ""Canceling connection initiation"")
++		log.Info(managerLogPrefix, ""Cancelling connection initiation"")
+ 		manager.status = statusDisconnecting()
+ 		cancelable.Cancel()
+ 	})",Do we really need separate error in manager if utils.ErrRequestCancelled is the only error which indicates cancelation ?,Why do we need this check?
+6445,"@@ -136,7 +136,7 @@ MODEL_PARAMS = {
+ 
+             # Temporal Pooler implementation selector (see _getTPClass in
+             # CLARegion.py).
+-            'temporalImp': 'cpp',
++            'temporalImp': 'tm_cpp',
+ 
+             # New Synapse formation count
+             # NOTE: If None, use spNumActivePerInhArea",Leave as `cpp` since that still gives better results.,I think this should be `tm
+6446,"@@ -27,7 +27,7 @@ import (
+ 	""sigs.k8s.io/controller-runtime/pkg/predicate""
+ )
+ 
+-func pausedPredicates(logger logr.Logger) predicate.Funcs {
++func PausedPredicates(logger logr.Logger) predicate.Funcs {
+ 	return predicate.Funcs{
+ 		UpdateFunc: func(e event.UpdateEvent) bool {
+ 			return processIfUnpaused(logger.WithValues(""predicate"", ""updateEvent""), e.ObjectNew, e.MetaNew)",temp change so the predicate can be used by the `exp` package,I think this should be cal
+6447,"@@ -387,6 +387,11 @@ class KeyboardInputGesture(inputCore.InputGesture):
+ 			# This could be for an event such as gyroscope movement,
+ 			# so don't report it.
+ 			return False
++		if self.vkCode in self.TOGGLE_KEYS:
++			# #5490: Dont report for keys that toggle on off.
++			# This is to avoid them from reported twice: once by the 'speak command keys' feature,
++			# and once by the 'speak typed characters' feature
++			return False
+ 		return not self.isCharacter
+ 
+ 	def _get_isCharacter(self):","Just as a tiny clarification, this isn't affected in any way by ""speak typed characters"". That is, ""caps lock on"", etc. is always spoken, even if speak typed characters is off.",I don't think this is the 
+6448,"@@ -61,10 +61,11 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe
+ 	}
+ 	hLog.Info(""deployment applied (%s)"", result)
+ 
+-	// Deploy the desired ClusterImageSets representing installable releases of OpenShift.
+-	// TODO: in future this should be pipelined somehow.
+ 	applyAssets := []string{
+ 		""config/manager/service.yaml"",
++
++		// Deploy the desired ClusterImageSets representing installable releases of OpenShift.
++		// TODO: in future this should be pipelined somehow.
+ 		""config/clusterimagesets/openshift-4.0-latest.yaml"",
+ 		""config/clusterimagesets/openshift-4.0-beta3.yaml"",
+ 		""config/clusterimagesets/openshift-4.0-beta4.yaml"",",@dgoodwin Will it cause an issue when the issue get fixed in OLM?,I don't think this should be pipelined.
+6449,"@@ -29,9 +29,8 @@ namespace Nethermind.Blockchain.Processing
+         IgnoreParentNotOnMainChain = 16,
+         DoNotVerifyNonce = 32,
+         DoNotUpdateHead = 64,
+-        DumpParityTraces = 128,
+-        DumpGetTraces = 256,
+-        All = 511,
++        RerunWithTraceOnFailure = 128,
++        All = 255,
+         ProducingBlock = NoValidation | ReadOnlyChain,
+         Trace = ForceProcessing | ReadOnlyChain | DoNotVerifyNonce | NoValidation,
+         Beam = IgnoreParentNotOnMainChain | DoNotUpdateHead",This option is now unnecessary,Why did you change this?
+6450,"@@ -360,10 +360,7 @@ func TestWriter(t *testing.T) {
+ 			t.Fatal(err)
+ 		}
+ 
+-		b, err := NewBucket(subdir)
+-		if err != nil {
+-			t.Fatal(err)
+-		}
++		b := &bucket{dir: subdir}
+ 		ctx := context.Background()
+ 		names := []string{
+ 			// Backslashes not allowed.","Don't jump down to the unexported interface: just set the content type to `""application/octet-stream""` explicitly when creating the `Writer`.",Why is this change needed?
+6451,"@@ -176,8 +176,11 @@ class BufferedUpdates implements Accountable {
+   }
+ 
+   void clearDeleteTerms() {
+-    deleteTerms.clear();
+     numTermDeletes.set(0);
++    deleteTerms.forEach((term, docIDUpto) -> {
++      bytesUsed.addAndGet(-(BYTES_PER_DEL_TERM + term.bytes.length + (Character.BYTES * term.field().length())));
++    });
++    deleteTerms.clear();
+   }
+   
+   void clear() {","Instead of counting this here on clear, can we use a second counter for the deleteTerms next to `bytesUsed`? This would be great. It doesn't need to be thread safe IMO",nit: `docIDUpto` is unused
+6452,"@@ -24,10 +24,10 @@ class User extends UserBase
+      * Validation rules
+      */
+     public $rules = [
+-        'email' => 'required|between:6,255|email|unique:backend_users',
+-        'login' => 'required|between:2,255|unique:backend_users',
+-        'password' => 'required:create|between:4,255|confirmed',
+-        'password_confirmation' => 'required_with:password|between:4,255'
++        'email' => 'required|between:6,191|email|unique:backend_users',
++        'login' => 'required|between:2,191|unique:backend_users',
++        'password' => 'required:create|between:8,191|confirmed',
++        'password_confirmation' => 'required_with:password|between:8,191'
+     ];
+ 
+     /**",@daftspunk @bennothommo I wonder if we need to go as deep as detecting what the default varchar length is with a special character to be parsed by the validation trait since we've introduced the config for it.,Why did you change this?
+6453,"@@ -2186,7 +2186,7 @@ class WebElement {
+     if (!this.driver_.fileDetector_) {
+       return this.schedule_(
+           new command.Command(command.Name.SEND_KEYS_TO_ELEMENT).
+-              setParameter('text', keys).
++              setParameter('text', keys.then(keys => keys.join(''))).
+               setParameter('value', keys),
+           'WebElement.sendKeys()');
+     }",Also update line 2205 below,`keys.then(keys => keys.
+6454,"@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+             ""com.fsck.k9.activity.MessageCompose.quotedTextFormat"";
+     private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = ""numAttachmentsLoading"";
+     private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = ""waitingForAttachments"";
+-
++    private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmpySubject"";
+     private static final String LOADER_ARG_ATTACHMENT = ""attachment"";
+ 
+     private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = ""waitingForAttachment"";","Typo, should read `firstTimeEmptySubject`",nit: typo in `Empy`
+6455,"@@ -22,7 +22,7 @@ package transport
+ 
+ import ""golang.org/x/net/context""
+ 
+-// Handler handles a single transport-level request.
++// Handler handles a single, transport-level, unary request.
+ type Handler interface {
+ 	// Handle the given request, writing the response to the given
+ 	// ResponseWriter.",The more I see this the more I think the transport layer _should_ actually refer to this as `UnaryHandler`.,"nit: `a single, unary re"
+6456,"@@ -267,6 +267,7 @@ module Beaker
+         logger.warn ""#{e.class} error in scp'ing. Forcing the connection to close, which should "" <<
+           ""raise an error.""
+         close
++        raise ""#{e}\n#{e.backtrace}""
+       end
+ 
+ ",The `warn` message here seems to indicate that the forced closure of the SSH connection should raise an error; is that getting swallowed up somewhere and not raising?,I don't think this is the right place to raise an error. It should be in the controller.
+6457,"@@ -616,6 +616,8 @@ class FilenamePrompt(_BasePrompt):
+         self._init_texts(question)
+         self._init_key_label()
+ 
++        self._expands_user = False
++
+         self._lineedit = LineEdit(self)
+         if question.default:
+             self._lineedit.setText(question.default)","I wonder if this is a fitting name. Why ""expands user""? Wouldn't be `user_expanded` or so be more fitting?",Why is this needed?
+6458,"@@ -28,10 +28,11 @@ var axe = axe || { utils: {} };
+  */
+ function virtualDOMfromNode(node, shadowId) {
+ 	const vNodeCache = {};
+-	return {
++	const vNode = {
+ 		shadowId: shadowId,
+ 		children: [],
+ 		actualNode: node,
++		_isHidden: null, // will be populated by axe.utils.isHidden
+ 		get isFocusable() {
+ 			if (!vNodeCache._isFocusable) {
+ 				vNodeCache._isFocusable = axe.commons.dom.isFocusable(node);","I see what you are doing here, but to stay with the `getter/setter` pattern, should we introduce `set isHidden(value)` & `get isHidden()` which them maintains `_isHidden` with in `vNodeCache`. This will avoid what looks like accessing an internal property like `_isHidden` from `axe.utils.isHidden` & keeps things neat.",Why do we need this?
+6459,"@@ -41,6 +41,7 @@ public class CSharpBasicPackageTransformer implements ModelToViewTransformer<Pro
+       ""csharp/gapic_snippets_csproj.snip"";
+   private static final String UNITTEST_CSPROJ_TEMPLATE_FILENAME =
+       ""csharp/gapic_unittest_csproj.snip"";
++  private static final String SAMPLE_CSPROJ_TEMPLATE_FILENAME = ""csharp/gapic_samples_csproj.snip"";
+ 
+   private static final CSharpAliasMode ALIAS_MODE = CSharpAliasMode.MessagesOnly;
+ ","nit: for consistency, have this line and the previous formatted similarly",private static final String SAMPLE_CSPROJ_TEMPLATE_FILENAME =
+6460,"@@ -165,6 +165,9 @@ public class PrivacyParameters {
+     private PrivacyStorageProvider storageProvider;
+     private EnclaveFactory enclaveFactory;
+     private boolean multiTenancyEnabled;
++    private Path orionKeyStoreFile;
++    private Path orionKeyStorePasswordFile;
++    private Path orionClientWhitelistFile;
+ 
+     public Builder setPrivacyAddress(final Integer privacyAddress) {
+       this.privacyAddress = privacyAddress;","As before, shouldn't mention these as being orion options I don't think. Perhaps just enclaveKeyStoreFile etc.",These should be `final`.
+6461,"@@ -152,10 +152,8 @@ async function observeRestResponse( res ) {
+ 		// The response may fail to resolve if the test ends before it completes.
+ 		try {
+ 			args.push( await res.text() );
++			console.log( ...args ); // eslint-disable-line no-console
+ 		} catch ( err ) {} // eslint-disable-line no-empty
+-
+-		// eslint-disable-next-line no-console
+-		console.log( ...args );
+ 	}
+ }
+ ",What's the thinking here? Only logging when the test has not ended yet?,Why do we need this?
+6462,"@@ -57,6 +57,12 @@ def _column_op(f):
+             args = [arg._scol if isinstance(arg, IndexOpsMixin) else arg for arg in args]
+             scol = f(self._scol, *args)
+ 
++            # If f is a logistic operator, fill NULL with False
++            log_ops = ['eq', 'ne', 'lt', 'le', 'ge', 'gt']
++            is_log_op = any(f == getattr(spark.Column, f'__{log_op}__') for log_op in log_ops)
++            if is_log_op:
++                scol = F.when(scol.isNull(), False).otherwise(scol)
++
+             return self._with_new_scol(scol)
+         else:
+             # Different DataFrame anchors",@HyukjinKwon @ueshin (cc @itholic @charlesdong1991 ) Not sure if this is the right implementation ...,Can we use `is_log_op = 
+6463,"@@ -10,7 +10,13 @@ module.exports = function(url, options, callback) {
+   if (typeof options === 'function') (callback = options), (options = {});
+   options = options || {};
+ 
+-  let result = parser.parse(url, true);
++  let result;
++  try {
++    result = parser.parse(url, true);
++  } catch (e) {
++    return callback(new Error('URL malformed, cannot be parsed'));
++  }
++
+   if (result.protocol !== 'mongodb:' && result.protocol !== 'mongodb+srv:') {
+     return callback(new Error('Invalid schema, expected `mongodb` or `mongodb+srv`'));
+   }",Do we want to add any specific error on how the url is malformed?,I think this should be `
+6464,"@@ -190,6 +190,10 @@ void Host::appendLogsInternal(folly::EventBase* eb,
+             {
+                 std::lock_guard<std::mutex> g(self->lock_);
+                 self->setResponse(r);
++                self->lastLogIdSent_++;
++                if (self->lastLogIdSent_ < self->logIdToSend_) {
++                    ++self->lastLogIdSent_;
++                }
+             }
+             self->noMoreRequestCV_.notify_all();
+             return;",why NOT self->lastLogIdSent_ = self->logIdToSend_,Why do we need this?
+6465,"@@ -599,6 +599,18 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ 				return reconcile.Result{Requeue: true}, nil
+ 			}
+ 		}
++		// Set the Provisioned status condition for adopted clusters (and in case we upgraded to/past where that condition was introduced)
++		if err := r.updateCondition(
++			cd,
++			hivev1.ProvisionedCondition,
++			corev1.ConditionTrue,
++			hivev1.ProvisionedProvisionedReason,
++			""Cluster is provisioned"",
++			cdLog,
++		); err != nil {
++			cdLog.WithError(err).Error(""Error updating Provisioned status condition"")
++			return reconcile.Result{}, err
++		}
+ 
+ 		// update SyncSetFailedCondition status condition
+ 		cdLog.Debug(""Check if any syncsets are failing"")",Shouldn't this be in the above `if` block where we are setting the installedtimestamp to ensure this only happens for already installed (and/or adopted) clusters?,Why do we need this?
+6466,"@@ -422,7 +422,7 @@ class SessionManager(QObject):
+                                         window=window.win_id)
+             tab_to_focus = None
+             for i, tab in enumerate(win['tabs']):
+-                new_tab = tabbed_browser.tabopen()
++                new_tab = tabbed_browser.tabopen(background=False)
+                 self._load_tab(new_tab, tab)
+                 if tab.get('active', False):
+                     tab_to_focus = i",This seems like another unrelated change I've done in `master`.,Why is this change n
+6467,"@@ -873,6 +873,15 @@ module RSpec::Core
+           expect(config.formatters.first.output.path).to eq(path)
+         end
+       end
++
++      context ""when a duplicate formatter exists for the same output target"" do
++        it ""does not add the formatter"" do
++          config.add_formatter :documentation
++          expect {
++            config.add_formatter :documentation
++          }.not_to change { config.formatters.length }
++        end
++      end
+     end
+ 
+     describe ""#filter_run_including"" do","Would be good to have another context `""when a duplicate formatter exists for a different output target""` that shows that it keeps both. As this stands, the specs could pass w/o the `formatter.output == new_formatter.output` check.",I'm not sure if this
+6468,"@@ -217,14 +217,15 @@ void SYCLSharedUSMSpace::deallocate(const char* arg_label,
+                   Kokkos::Tools::make_space_handle(name()));
+ }
+ 
+-void SYCLDeviceUSMSpace::impl_access_error() {
++KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error() {
+   const std::string msg(
+       ""Kokkos::Experimental::SYCLDeviceUSMSpace::impl_access_error attempt to ""
+       ""execute device function from non-device space"");
+   Kokkos::Impl::throw_runtime_exception(msg);
+ }
+ 
+-void SYCLDeviceUSMSpace::impl_access_error(const void* const) {
++KOKKOS_DEPRECATED void SYCLDeviceUSMSpace::impl_access_error(
++    const void* const) {
+   impl_access_error();
+ }
+ ",Why not just remove? The CUDA one has been around for while. This one has not been part of any release (?),I don't think we need to deprecate this.
+6469,"@@ -83,8 +83,9 @@ public class Session implements ContentBlocking.Delegate, GeckoSession.Navigatio
+     private transient SharedPreferences mPrefs;
+     private transient GeckoRuntime mRuntime;
+     private transient byte[] mPrivatePage;
+-    private transient boolean mFirstContentfulPaint;
++    private transient boolean mFirstContentFulPaint;
+     private transient long mKeepAlive;
++    private transient boolean mIsFirstActivation;
+ 
+     public interface BitmapChangedListener {
+         void onBitmapChanged(Session aSession, Bitmap aBitmap);","nit: `Contentful` is the word used in the GV API, without the uppercase in F",Should this be `mIsFirstActivation`?
+6470,"@@ -83,6 +83,12 @@ public class SchemaMeta extends CommonService<OperationMeta> {
+   }
+ 
+   private void initOperations() {
++    if (swagger.getPaths() == null) {
++      LOGGER.error(swagger.getInfo().getTitle() + "" with path "" + swagger.getBasePath()
++          + "" is an empty interface, please delete it or fill with one method!"");
++      return;
++    }
++
+     for (Entry<String, Path> entry : swagger.getPaths().entrySet()) {
+       String strPath = entry.getKey();
+       Path path = entry.getValue();","It just does the check, maybe we can name it as checkOperations.",I think it would be better to throw an e
+6471,"@@ -344,7 +344,7 @@ describe('runRules', function() {
+ 		});
+ 
+ 		fixture.innerHTML =
+-			'<div id=""t1""><span></span></div><div id=""t2""><em></em></div>';
++			'<div id=""t1""><em></em></div><div id=""t2""><em></em></div>';
+ 
+ 		var $test = {
+ 			0: fixture.querySelector('#t1'),",We no longer have karma output in the test file so these selectors were now unique and the target didn't need a child selector. Updated to force non-unique nodes,Why did you change this?
+6472,"@@ -1,8 +1,14 @@
++<% content_for :additional_header_links do %>
++  <% if current_user.has_subscription_with_mentor? %>
++    <li class=""mentor"">
++      <%= mentor_image(current_user.mentor) %>
++      <%= mentor_contact_link(current_user.mentor) %>
++    </li>
++  <% end %>
++<% end %>
++
+ <section class=""workshops vertical-slider revealed"">
+-  <figure class=""meta product-card"">
+-    <%= render 'mentor' %>
+-    <%= render 'trails' %>
+-  </figure>
++  <%= render 'trails' %>
+   <%= render partial: 'products/workshop', collection: online_workshops %>
+   <%= render partial: 'products/workshop', collection: in_person_workshops %>
+ </section>",This moved from a partial to not being in a partial. How about cleaning this view up further by moving it back into a partial?,I think this should be `current_user.has_subscription_with_mentor?`
+6473,"@@ -42,6 +42,7 @@ func NewLightweightInformer(
+ 	objType runtime.Object,
+ 	resync time.Duration,
+ 	h cache.ResourceEventHandler,
++	recieveUpdates bool,
+ ) cache.Controller {
+ 	cacheStore := cache.NewIndexer(cache.DeletionHandlingMetaNamespaceKeyFunc, cache.Indexers{})
+ 	fifo := cache.NewDeltaFIFOWithOptions(cache.DeltaFIFOOptions{",add some form of docs in docstring or on :74 for what the effect is,nit: `recieveUpdates` is unused (from `structcheck`)
+6474,"@@ -13,7 +13,8 @@ from kinto.core.storage import (
+     StorageBase,
+     exceptions,
+ )
+-from kinto.core.utils import COMPARISON, find_nested_value, json
++from kinto.core.utils import COMPARISON, find_nested_value
++import json
+ 
+ 
+ def tree():",Couldn't you import `json` from `kinto.core.utils` here too?,Why this change?
+6475,"@@ -8,6 +8,9 @@ require 'rspec/rails'
+ require 'steps/user_steps'
+ require 'steps/approval_steps'
+ 
++# mimic production env for view+mail
++ENV[""DISABLE_SANDBOX_WARNING""] = 'true'
++
+ # Requires supporting ruby files with custom matchers and macros, etc, in
+ # spec/support/ and its subdirectories. Files matching `spec/**/*_spec.rb` are
+ # run as spec files by default. This means that files in spec/support that end",Minor: Hmmm...is it worth setting this explicitly for the tests that it affects?,Why is this needed?
+6476,"@@ -42,7 +42,6 @@ using namespace eprosima::fastrtps::rtps;
+ 
+ StatefulReader::~StatefulReader()
+ {
+-    std::lock_guard<std::recursive_timed_mutex> guard(mp_mutex);
+     logInfo(RTPS_READER,""StatefulReader destructor."");
+     is_alive_ = false;
+ ","This was added to fix a race condition and you are reverting it here, right?",Why remove this?
+6477,"@@ -2,11 +2,16 @@ package commands
+ 
+ import (
+ 	""context""
++	""fmt""
+ 
+ 	""github.com/ledgerwatch/turbo-geth/common""
+ )
+ 
+-// Etherbase is the address that mining rewards will be send to
++// Coinbase is the address that mining rewards will be sent to
+ func (api *APIImpl) Coinbase(_ context.Context) (common.Address, error) {
++	if api.ethBackend == nil {
++		// We're running in --chaindata mode or otherwise cannot get the backend
++		return common.Address{}, fmt.Errorf(""eth_coinbase function is not available"")
++	}
+ 	return api.ethBackend.Etherbase()
+ }","Could you add some extra text here, so that it reads ""eth_coinbase function is not available, please use --private.api.addr option instead of --chaindata option"", so that it is clear that the function can work, but different options",I'm not sure if 
+6478,"@@ -159,6 +159,19 @@ feature 'Creating an NCR work order' do
+       expect(page).to have_content('$2,000 for construction')
+     end
+ 
++    scenario ""selecting Expense Type toggles Building required flag"", :js do
++      login_as(requester)
++      visit ""/ncr/work_orders/new""
++      find(""#ncr_work_order_expense_type_ba60"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to_not match('required')
++      find(""#ncr_work_order_expense_type_ba61"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to match('required')
++      find(""#ncr_work_order_expense_type_ba80"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to match('required')
++      find(""#ncr_work_order_expense_type_ba60"").click
++      expect(find('.ncr_work_order_building_number input')['class']).to_not match('required')
++    end
++
+     scenario 'defaults to no approver if there was no previous request' do
+       login_as(requester)
+       visit '/ncr/work_orders/new'",`new_ncr_work_order_path` ? (I've been slowly moving specs over to that way of calling paths),I don't think th
+6479,"@@ -15,7 +15,9 @@
+                         application/javascript
+                         text/css
+                         image/*
+-                        application/x-shockwave-flash
++                        application/x-shockwave-flash ?
++                        font/*
++                        application/font-*
+         ~h rex      Header line in either request or response
+         ~hq rex     Header in request
+         ~hs rex     Header in response",Should flash be included in the patterns too? It currently isn't.,Why is this need
+6480,"@@ -18,7 +18,7 @@ namespace Microsoft.Cci.Differs.Rules
+             if (impl.IsEffectivelySealed() && !contract.IsEffectivelySealed())
+             {
+                 differences.AddIncompatibleDifference(this,
+-                    ""Type '{0}' is sealed in the implementation but not sealed in the contract."", impl.FullName());
++                    $""Type '{impl.FullName()}' is sealed in the {Right} but not sealed in the {Left}."");
+ 
+                 return DifferenceType.Changed;
+             }",I suspect I will have to keep looking whether Left/Right refers to contract/Implementation while working on the rules code.,"Nit: ""in the contract"" => ""in the contract"""
+6481,"@@ -76,7 +76,7 @@ namespace AutoRest.CSharp.Azure
+                     if (model.Extensions.ContainsKey(AzureExtensions.AzureResourceExtension) && 
+                         (bool)model.Extensions[AzureExtensions.AzureResourceExtension])
+                     {
+-                        model.BaseModelType = new CompositeType { Name = ""IResource"", SerializedName = ""IResource"" };
++                        model.BaseModelType = new CompositeType { Name = ""Microsoft.Rest.Azure.IResource"", SerializedName = ""Microsoft.Rest.Azure.IResource"" };
+                     }
+                 }
+             }",(ignore this. testing a codeflow bug),Why is this change needed?
+6482,"@@ -137,9 +137,9 @@ func buildCLIOptions() *cli.App {
+ 			EnvVar: ""CASSANDRA_TLS_CA"",
+ 		},
+ 		cli.BoolFlag{
+-			Name:   schema.CLIFlagTLSEnableHostVerification,
+-			Usage:  ""TLS host verification"",
+-			EnvVar: ""CASSANDRA_TLS_VERIFY_HOST"",
++			Name:   schema.CLIFlagTLSDisableHostVerification,
++			Usage:  ""Cassandra tls verify server hostname"",
++			EnvVar: ""CASSANDRA_TLS_DISABLE_HOST_VERIFICATION"",
+ 		},
+ 	}
+ ","[Nit] can you change the Usage wording to indicate that the flag is used to opt-out of server certificate verification? (e.g. ""disables validation of the Cassandra cluster's server certificate."")",This should be `CASSANDRA_TLS_DISABLE_HOST_
+6483,"@@ -14,6 +14,8 @@
+ package zipkin.storage.elasticsearch;
+ 
+ import com.google.common.base.Throwables;
++import java.io.IOException;
++import java.util.List;
+ import zipkin.DependencyLink;
+ import zipkin.Span;
+ import zipkin.internal.MergeById;","Sorry :) Would be really helpful to integrate something like Eclipse Code Formatter, so it will fail if the code style is broken (the same as eslint fails on the frontend) I use IntelliJ IDEA and their vision of imports is a bit different :)",Why do we need this import?
+6484,"@@ -362,7 +362,17 @@ module Beaker
+       block_on host do |host|
+         if host['platform'] =~ /centos|el-|redhat|fedora/
+           logger.debug(""Disabling iptables on #{host.name}"")
+-          host.exec(Command.new(""sudo su -c \""/etc/init.d/iptables stop\""""), {:pty => true})
++          if host.exec(Command.new('whoami')).stdout.chomp =~ /root/ #don't need to sudo if we are root
++            if host.check_for_command('iptables') #is iptables even installed?
++              host.exec(Command.new(""/etc/init.d/iptables stop""))
++            else
++              logger.warn(""iptables not installed on #{host.name} (#{host['platform']})"")
++            end
++          else
++            if host.exec(Command.new(""sudo su -c \""/etc/init.d/iptables stop\""""), {:pty => true, :acceptable_exit_codes => (0..255)}).exit_code != '0'
++              logger.warn(""failed to disable iptables on #{host.name} (#{host['platform']})"")
++            end
++          end
+         else
+           logger.warn(""Attempting to disable iptables on non-supported platform: #{host.name}: #{host['platform']}"")
+         end",this will still fail on systemd,"I don't think you need the `else` here, since the `if` returns."
+6485,"@@ -3760,6 +3760,8 @@ class RDSConnection(AWSQueryConnection):
+                                      path='/', params=params)
+         body = response.read()
+         boto.log.debug(body)
++        if type(body) == bytes:
++            body = body.decode('utf-8')
+         if response.status == 200:
+             return json.loads(body)
+         else:","The convention in most of the codebase is to use `if isinstance(body, bytes):` instead.",Why is this needed?
+6486,"@@ -249,7 +249,9 @@ class ConsoleUI(wx.Frame):
+ 		if self.completionAmbiguous:
+ 			menu = wx.Menu()
+ 			for comp in completions:
+-				item = menu.Append(wx.ID_ANY, comp)
++				# Only show text after the last dot (so as to not keep repeting the class or module in the context menu)
++				label=comp.split('.')[-1]
++				item = menu.Append(wx.ID_ANY, label)
+ 				self.Bind(wx.EVT_MENU,
+ 					lambda evt, completion=comp: self._insertCompletion(original, completion),
+ 					item)","I think this would be better as: `label = comp.rsplit('.', 1)[-1]`","This should be `comp.split('.', 1)[0]`"
+6487,"@@ -57,8 +57,8 @@ public class RubyProvider {
+   }
+ 
+   @SuppressWarnings(""unchecked"")
+-  public <Element> GeneratedResult generate(
+-      Element element, SnippetDescriptor snippetDescriptor, RubyGapicContext context) {
++  public <Element, ContextT> GeneratedResult generate(
++      Element element, SnippetDescriptor snippetDescriptor, ContextT context) {
+     ImmutableMap<String, Object> globalMap =
+         ImmutableMap.<String, Object>builder().put(""context"", context).build();
+     RubySnippetSet<Element> snippets =",We have been creating a language-level context interface for each language instead of parameterizing the generate function.,why do we need this change?
+6488,"@@ -21,6 +21,6 @@ class UuidGenerator implements GeneratorInterface
+     {
+         $id = (string) $media->getId();
+ 
+-        return sprintf('%s/%04s/%02s', $media->getContext(), substr($id, 0, 4), substr($id, 4, 2));
++        return sprintf('%s/%04s/%02s', $media->getContext() ?? '', substr($id, 0, 4), substr($id, 4, 2));
+     }
+ }",Same thing about context here.,`$media->getContext()` can return `null`
+6489,"@@ -634,9 +634,16 @@ func (handler *workflowTaskHandlerImpl) handleCommandContinueAsNewWorkflow(
+ 		return handler.failCommand(enumspb.WORKFLOW_TASK_FAILED_CAUSE_UNHANDLED_COMMAND, nil)
+ 	}
+ 
++	namespaceEntry, err := handler.namespaceCache.GetNamespaceByID(handler.mutableState.GetExecutionInfo().NamespaceId)
++	if err != nil {
++		return err
++	}
++	namespace := namespaceEntry.GetInfo().Name
++
+ 	if err := handler.validateCommandAttr(
+ 		func() error {
+ 			return handler.attrValidator.validateContinueAsNewWorkflowExecutionAttributes(
++				namespace,
+ 				attr,
+ 				handler.mutableState.GetExecutionInfo(),
+ 			)",there is a function to get namespace entry from mutable state directly,nit: can we move this to a separate func
+6490,"@@ -191,7 +191,7 @@ module Bolt
+         hiera_config: @hiera_config,
+         plan_vars: plan_vars,
+         # This data isn't available on the target config hash
+-        config: @inventory.config.transport_data_get
++        config: @inventory.transport_data_get
+       }
+ 
+       description = options[:description] || 'apply catalog'",The `Transport::Config` objects don't serialize properly. We probably want to just turn them into hashes at this point.,Prefer double-quoted strings unless you 
+6491,"@@ -251,11 +251,11 @@ const ConfigInstructions = `
+ # These values specify the destination directory for ddev ssh and the
+ # directory in which commands passed into ddev exec are run.
+ 
+-# omit_containers: [""dba"", ""ddev-ssh-agent""]
+-# would omit the dba (phpMyAdmin) and ddev-ssh-agent containers. Currently
+-# only those two containers can be omitted here.
+-# Note that these containers can also be omitted globally in the
+-# ~/.ddev/global_config.yaml or with the ""ddev config global"" command.
++# omit_containers: [""db"", dba"", ""ddev-ssh-agent""]
++# Currently only these containers are supported. Some containers can also be
++# omitted globally in the ~/.ddev/global_config.yaml. Note that if you omit
++# the ""db"" container, several standard features of ddev that access the
++# database container will be unusuable.
+ 
+ # nfs_mount_enabled: false
+ # Great performance improvement but requires host configuration first.","Sorry, typo s/unusuable/unusable/",I'm not sure if this is the right way to
+6492,"@@ -242,6 +242,13 @@ public class SparkSessionCatalog<T extends TableCatalog & SupportsNamespaces>
+ 
+   @Override
+   public final void initialize(String name, CaseInsensitiveStringMap options) {
++    if (options.containsKey(""type"") && options.get(""type"").equalsIgnoreCase(""hive"") && options.containsKey(""uri"")) {
++      throw new UnsupportedOperationException(""Cannot set an alternative uri when"" +
++              "" using the SparkSessionCatalog, "" +
++              ""make an alternative SparkCatalog if the "" +
++              ""Spark Session catalog and Iceberg "" +
++              ""catalog should contact different metastores."");
++    }
+     this.catalogName = name;
+     this.icebergCatalog = buildSparkCatalog(name, options);
+     if (icebergCatalog instanceof StagingTableCatalog) {","If this is needed, should we check that the configured `uri` isn't already equal to the value of the metastore URI configured via `spark.hadoop.hive.metastore.uris` or any of the other ways of setting it. This would be a breaking change for people who have `uri` configured on the SparkSessionCatalog and have it correctly set (which I believe should be everybody as `uri` is currently required if I'm not mistaken).",I don't think this is the right place to throw an exception. I think it should be in `buildSparkCatalog`
+6493,"@@ -21,4 +21,7 @@ class ViewMultipart(base.View):
+             return ""Multipart form"", self._format(v)
+ 
+     def render_priority(self, data: bytes, *, content_type: Optional[str] = None, **metadata) -> float:
+-        return float(content_type == ""multipart/form-data"")
++        if content_type and content_type.startswith(""multipart/form-data""):
++            return 1
++        else:
++            return 0","see above - this is only used to select the correct view, we don't need to handle the boundary information here.","I think this should be `return float(content_type == ""multipart/form-data"")`"
+6494,"@@ -555,6 +555,7 @@ func TestSign(t *testing.T) {
+ 								LastTransitionTime: &metaFixedClockStart,
+ 							}),
+ 							gen.SetCertificateRequestCertificate(certPEM),
++							gen.SetCertificateRequestCA(certPEM),
+ 							gen.AddCertificateRequestAnnotations(map[string]string{cmapi.VenafiPickupIDAnnotationKey: ""test""}),
+ 						),
+ 					)),","These tests use a self-signed cert so the CA *is* the cert. I considered making a proper chain to use in the tests, but wasn't sure it was necessary to test here, since we test it in the E2E tests anyway.",Why do we need this?
+6495,"@@ -212,6 +212,10 @@ function diffElementNodes(dom, newVNode, oldVNode, context, isSvg, excessDomChil
+ 
+ 	if (newVNode.type===null) {
+ 		if (oldProps !== newProps) {
++			if (excessDomChildren!=null) {
++				const index = excessDomChildren.indexOf(dom);
++				if (index > -1) excessDomChildren[index] = null;
++			}
+ 			dom.data = newProps;
+ 		}
+ 	}","We could, maybe, just directly do `excessDomChildren[excessDomChildren.indexOf(dom)] = null;`. Would this improve the size in any way? This will end-up with a property on the `excessDomChildren[""-1""]` but maybe we could live with that?",I don't think you need the `!= null` here.
+6496,"@@ -1278,6 +1278,11 @@ module.service('gridUtil', ['$log', '$window', '$document', '$http', '$templateC
+     for ( var i = mouseWheeltoBind.length; i; ) {
+       $elm.on(mouseWheeltoBind[--i], cbs[fn]);
+     }
++    $elm.on('$destroy', function unbindEvents() {
++      for ( var i = mouseWheeltoBind.length; i; ) {
++        $elm.off(mouseWheeltoBind[--i], cbs[fn]);
++      }
++    });
+   };
+   s.off.mousewheel = function (elm, fn) {
+     var $elm = angular.element(elm);",this looks like it may be something that needs additional refactoring,Why is this needed?
+6497,"@@ -300,7 +300,7 @@ class Resource(object):
+                 for resource in yielder.iter():
+                     res = resource
+                     new_stack = stack + [self]
+-
++                    
+                     # Parallelization for resource subtrees.
+                     if res.should_dispatch():
+                         callback = partial(res.try_accept, visitor, new_stack)",Nit: Remove whitespace (and below),Why this change?
+6498,"@@ -205,7 +205,10 @@ return [
+         'error_moving_file' => 'Error moving file :file',
+         'error_moving_directory' => 'Error moving directory :dir',
+         'error_deleting_directory' => 'Error deleting the original directory :dir',
+-        'path' => 'Path'
++        'path' => 'Path',
++        'unzip' => 'Unzip',
++        'is_a_directory' => 'Only files are allowed. You\'ve selected a directory.',
++        'error_open_zip' => 'Error open the zip file'
+     ],
+     'component' => [
+         'menu_label' => 'Components',","""Failed opening"" or ""Failed to open"".",Shouldn't this be `
+6499,"@@ -131,8 +131,12 @@ func (d *Disk) validate(ctx context.Context, s *Step) DError {
+ 		if _, err := s.w.images.regUse(d.SourceImage, s); err != nil {
+ 			errs = addErrs(errs, Errf(""%s: can't use image %q: %v"", pre, d.SourceImage, err))
+ 		}
++	} else if d.SourceSnapshot != """" {
++		if _, err := s.w.snapshots.regUse(d.SourceSnapshot, s); err != nil {
++			errs = addErrs(errs, Errf(""%s: can't use snapshot %q: %v"", pre, d.SourceSnapshot, err))
++		}
+ 	} else if d.Disk.SizeGb == 0 {
+-		errs = addErrs(errs, Errf(""%s: SizeGb and SourceImage not set"", pre))
++		errs = addErrs(errs, Errf(""%s: SizeGb, SourceSnapshot or SourceImage not set"", pre))
+ 	}
+ 
+ 	// Register creation.",and -> or,Shouldn't this be `
+6500,"@@ -683,5 +683,17 @@ describe('model', function() {
+         yield User.collection.drop();
+       });
+     });
++    it('should do a dryRun feat-10316', function() {
++      return co(function*() {
++        const userSchema = new mongoose.Schema({ username: String }, { password: String }, { email: String });
++        userSchema.index({ password: 1 });
++        userSchema.index({ email: 1 });
++        const User = db.model('Upson', userSchema);
++        yield User.collection.createIndex({ age: 1 });
++        const result = yield User.diffIndexes();
++        assert.deepStrictEqual(result.toDrop, ['age_1']);
++        assert.deepStrictEqual(result.toCreate, [{ password: 1 }, { email: 1 }]);
++      });
++    });
+   });
+ });",Add a `yield User.init()` here to wait for all indexes to finish building,"I think you can use `db.model('Upson', userSchema)` here"
+6501,"@@ -11,6 +11,8 @@
+ #include <ifaddrs.h>
+ #include <arpa/inet.h>
+ 
++DEFINE_string(local_ip, """", ""local ip"");
++
+ namespace nebula {
+ namespace network {
+ ","I don't think this belongs here. If the application can take a local_ip as input, the application should take care of it, not in this common library",Why do we need this?
+6502,"@@ -524,6 +524,17 @@ class Theme
+         return ThemeData::forTheme($this);
+     }
+ 
++    /**
++     * Remove data specific to this theme
++     * @return bool
++     */
++    public function removeCustomData()
++    {
++        if ($this->hasCustomData()) {
++            return $this->getCustomData()->delete();
++        }
++    }
++
+     /**
+      * Checks to see if the database layer has been enabled
+      *","@DanHarrin please add a `return true` at the bottom of this method, as the docblock indicates a boolean return value.",Please add a blank line before the return statement.
+6503,"@@ -25,7 +25,7 @@ import org.apache.lucene.index.SlowImpactsEnum;
+ 
+ /** Expert: A <code>Scorer</code> for documents matching a <code>Term</code>.
+  */
+-final class TermScorer extends Scorer {
++public final class TermScorer extends Scorer {
+   private final PostingsEnum postingsEnum;
+   private final ImpactsEnum impactsEnum;
+   private final DocIdSetIterator iterator;",This is used in o.a.l.sandbox.search.BM25FQuery.,Why is this public?
+6504,"@@ -41,7 +41,8 @@ public class XYShapeBoundingBoxQuery extends ShapeQuery {
+   @Override
+   protected PointValues.Relation relateRangeBBoxToQuery(int minXOffset, int minYOffset, byte[] minTriangle,
+                                                         int maxXOffset, int maxYOffset, byte[] maxTriangle) {
+-    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle);
++    return rectangle2D.relateRangeBBox(minXOffset, minYOffset, minTriangle, maxXOffset, maxYOffset, maxTriangle,
++        queryRelation == QueryRelation.INTERSECTS);
+   }
+ 
+   /** returns true if the query matches the encoded triangle */",Shouldn't this work as well for Disjoint?,I think this should be `queryRelation != QueryRelation.INTERSECTS`
+6505,"@@ -50,6 +50,9 @@ class TestCase(unittest.TestCase):
+       for nm, fn in Descriptors._descList:
+         try:
+           v = fn(m)
++        except RuntimeError:
++          # 3D descriptors fail since the mol has no conformers
++          pass
+         except Exception:
+           import traceback
+           traceback.print_exc()","Same here. This was included to quiet the test for the 3D descriptors. As we removed them, this exception handling is no longer required",Why is this needed?
+6506,"@@ -26,6 +26,7 @@
+ 
+ #include ""lbann/utils/lbann_library.hpp""
+ #include ""lbann/callbacks/callback_checkpoint.hpp""
++#include ""lbann/data_store/data_store_jag.hpp""
+ 
+ namespace lbann {
+ ",Why do you need to load a specific data reader in lbann_library?,"#include ""lbann/data_store/jag.hpp"""
+6507,"@@ -31,10 +31,10 @@ namespace Nethermind.Runner.Ethereum.Steps
+             _context = context;
+         }
+ 
+-        public ValueTask Execute()
++        public Task Execute()
+         {
+             _context.ChainSpec.Bootnodes = _context.ChainSpec.Bootnodes?.Where(n => !n.NodeId?.Equals(_context.NodeKey.PublicKey) ?? false).ToArray() ?? new NetworkNode[0];
+-            return default;
++            return Task.CompletedTask;
+         }
+     }
+ }",why not ValueTask?,Why did you change this?
+6508,"@@ -422,7 +422,7 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ 		return reconcile.Result{Requeue: true}, nil
+ 	}
+ 
+-	if cd.Status.InstallerImage == nil {
++	if !cd.Status.Installed && (cd.Status.InstallerImage == nil || cd.Status.CLIImage == nil) {
+ 		return r.resolveInstallerImage(cd, imageSet, releaseImage, hiveImage, cdLog)
+ 	}
+ ","I'm nervous about this line, I don't want to go regenerate a bunch of imageset jobs for clusters that are old, already installed, but don't have a CLIImage set (which they wouldn't because they're old) Adding the Installed guard is meant to address this. Otherwise this *should* recreate the imageset job due to the code in this function that deletes the job if it's finished. (but we don't have our images set due to this clause)",Why do we need this check?
+6509,"@@ -303,7 +303,8 @@ public class HadoopTables implements Tables, Configurable {
+       }
+ 
+       Map<String, String> properties = propertiesBuilder.build();
+-      TableMetadata metadata = tableMetadata(schema, spec, sortOrder, properties, location);
++
++      TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, sortOrder, location, properties);
+       ops.commit(null, metadata);
+       return new BaseTable(ops, location);
+     }",Is it necessary to change this file? Doesn't `tableMetadata` call `newTableMetadata`?,Why is this change needed?
+6510,"@@ -78,12 +78,6 @@ func TestCatchupOverGossip(t *testing.T) {
+ 	t.Parallel()
+ 	// ledger node upgraded version, fetcher node upgraded version
+ 	runCatchupOverGossip(t, false, false)
+-	// ledger node older version, fetcher node upgraded version
+-	runCatchupOverGossip(t, true, false)
+-	// ledger node upgraded older version, fetcher node older version
+-	runCatchupOverGossip(t, false, true)
+-	// ledger node older version, fetcher node older version
+-	runCatchupOverGossip(t, true, true)
+ }
+ 
+ func runCatchupOverGossip(t *testing.T,","I think that I have a better proposal for this test - improve it so that it would know how to read the list of SupportedProtocolVersions and dynamically use these. The motivation here is that I expect to have another network version soon, and this test seems to be a good test case for that.",why remove these?
+6511,"@@ -89,10 +89,13 @@ public class HiveCatalog extends BaseMetastoreCatalog implements Closeable, Supp
+ 
+     try {
+       List<String> tables = clients.run(client -> client.getAllTables(database));
+-      return tables.stream()
++      List<TableIdentifier> tableIdentifiers = tables.stream()
+           .map(t -> TableIdentifier.of(namespace, t))
+           .collect(Collectors.toList());
+ 
++      LOG.debug(""Listing of namespace [{}] resulted in the following tables: [{}]"", namespace, tableIdentifiers);
++      return tableIdentifiers;
++
+     } catch (UnknownDBException e) {
+       throw new NoSuchNamespaceException(""Namespace does not exist: %s"", namespace);
+ ",What is the purpose of this debug message? I'm not sure how it would help.,nit: `listing of namespace
+6512,"@@ -25,7 +25,6 @@ import (
+ 	""time""
+ 
+ 	""kythe.io/kythe/go/extractors/bazel""
+-	""kythe.io/kythe/go/extractors/bazel/extutil""
+ )
+ 
+ var (",Is there a corresponding BUILD dependency to prune?,"""github.com/pkg/errors"""
+6513,"@@ -2066,7 +2066,14 @@ func testSignedURL(t *testing.T, newHarness HarnessMaker) {
+ 	}
+ 	getURLNoParamsURL.RawQuery = """"
+ 	getURLNoParams := getURLNoParamsURL.String()
+-	putURL, err := b.SignedURL(ctx, key, &blob.SignedURLOptions{Method: http.MethodPut})
++	const (
++		goodContentType = ""text/plain""
++		badContentType  = ""application/octet-stream""
++	)
++	putURL, err := b.SignedURL(ctx, key, &blob.SignedURLOptions{
++		Method:      http.MethodPut,
++		ContentType: goodContentType,
++	})
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	} else if putURL == """" {","The ""good"" and ""bad"" descriptions confused me a bit. Maybe `allowedContentType` and `disallowedContentType`? Not sure if that's better.",I think this should be 
+6514,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()),I don't think this is t
+6515,"@@ -106,11 +106,11 @@ func TestServerRoutesWithAuthAndBCrypt(t *testing.T) {
+ 	srvB := RunServer(optsB)
+ 	defer srvB.Shutdown()
+ 
+-	urlA := fmt.Sprintf(""nats://%s:%d/"", optsA.Host, optsA.Port)
+-	urlB := fmt.Sprintf(""nats://%s:%d/"", optsB.Host, optsB.Port)
++	urlA := fmt.Sprintf(""nats://%s:%s@%s:%d/"", optsA.Username, optsA.Password, optsA.Host, optsA.Port)
++	urlB := fmt.Sprintf(""nats://%s:%s@%s:%d/"", optsB.Username, optsB.Password, optsB.Host, optsB.Port)
+ 
+ 	// Wait for route to form.
+-	time.Sleep(250 * time.Millisecond)
++	time.Sleep(4 * time.Second)
+ 
+ 	nc1, err := nats.Connect(urlA)
+ 	if err != nil {","You may want to have a look at `func checkClusterFormed(t *testing.T, servers ...*Server)` in this file that I created some time ago. It will timeout at 5 seconds, but will return as soon as cluster is ready.",Why is this necessary?
+6516,"@@ -662,8 +662,14 @@ static void push_cb (flux_t *h, flux_msg_handler_t *mh,
+         aggregate_sink (h, ag);
+     rc = 0;
+ done:
+-    if (flux_respond (h, msg, rc < 0 ? saved_errno : 0, NULL) < 0)
+-        flux_log_error (h, ""aggregator.push: flux_respond"");
++    if (rc < 0) {
++        if (flux_respond_error (h, msg, saved_errno, NULL) < 0)
++            flux_log_error (h, ""aggregator.push: flux_respond_error"");
++    }
++    else {
++        if (flux_respond (h, msg, NULL) < 0)
++            flux_log_error (h, ""aggregator.push: flux_respond"");
++    }
+ }
+ 
+ ","I see a few places where this blob of code is required due to the removal of `errnum` parameter from `flux_respond` -- trading 2 lines of code for 8. The improvement to the function seems like a good idea, but I wonder if we need a convenience macro or function to do it the old way? You went through and made all the changes, was it overall a net win?",Shouldn't this be `flux_respond_error`?
+6517,"@@ -23,9 +23,9 @@
+  */
+ import {
+ 	appendNotificationsCount,
+-	sendAnalyticsTrackingEvent,
+ 	getQueryParameter,
+ } from './util/standalone';
++import { trackEvent } from './util/tracking';
+ 
+ // Set webpackPublicPath on-the-fly.
+ if ( global.googlesitekitAdminbar && global.googlesitekitAdminbar.publicPath ) {","I know it's not related to your change, but it's a bit odd that this import uses a relative path rather than the ones setup by webpack. Might be nice to change this one in case we refactor those paths in the future; this one wouldn't get caught in any kind of find+replace.",Why do we need to export this?
+6518,"@@ -86,7 +86,8 @@ func (c *Config) Start() {
+ 
+ 	for _, schedule := range c.Scheduler.Schedules {
+ 		helper.ControllerWg.Add(1)
+-		go schedule.ExecuteSchedule(c.ActionManager.Actions, c.Converter.DataRead, c.Device.ID)
++		newSchedule := schedule
++		go newSchedule.ExecuteSchedule(c.ActionManager.Actions, c.Converter.DataRead, c.Device.ID)
+ 	}
+ 	helper.ControllerWg.Wait()
+ }","Good catch, and if we don't declare the newSchedule here, will the last schedule be executed in multi goroutine?",Why do we need this change?
+6519,"@@ -879,6 +879,7 @@ partial class Build
+                 .Concat(includeSecurity)
+                 .Select(x => Solution.GetProject(x))
+                 .Where(project =>
++                project != null &&
+                 (project, project.TryGetTargetFrameworks()) switch
+                 {
+                     _ when exclude.Contains(project.Path) => false,","`project` should never be null here, unless we have projects that aren't in the solution? Which we shouldn't have  ",Why is this needed?
+6520,"@@ -1,13 +1,18 @@
+ #include ""extractor/graph_compressor.hpp""
+ 
+ #include ""extractor/compressed_edge_container.hpp""
+-#include ""extractor/restriction_map.hpp""
++#include ""extractor/restriction.hpp""
++#include ""extractor/restriction_compressor.hpp""
++
+ #include ""util/dynamic_graph.hpp""
+ #include ""util/node_based_graph.hpp""
+ #include ""util/percent.hpp""
+ 
+ #include ""util/log.hpp""
+ 
++#include <boost/assert.hpp>
++#include <unordered_set>
++
+ namespace osrm
+ {
+ namespace extractor",Simple `for` loop instead of `for_each` would help here by making it more readable.,Why is this needed?
+6521,"@@ -96,6 +96,8 @@ namespace thread_role
+ 			case nano::thread_role::name::signature_checking:
+ 				thread_role_name_string = ""Signature check"";
+ 				break;
++			case nano::thread_role::name::confirmation_height_processing:
++				thread_role_name_string = ""Conf height"";
+ 		}
+ 
+ 		/*","Looks like this falls through, should break.",thread_role_name_st
+6522,"@@ -73,6 +73,7 @@ class ManifestListWriter implements FileAppender<ManifestFile> {
+           .schema(ManifestFile.schema())
+           .named(""manifest_file"")
+           .meta(meta)
++          .overwrite(false)
+           .build();
+ 
+     } catch (IOException e) {",Let's default manifest lists and manifests to overwrite. These use UUID-based file names and should never conflict.,Why is this needed?
+6523,"@@ -135,6 +135,9 @@ confspec = ConfigObj(StringIO(
+ 	audioCoordinates_maxPitch = integer(default=880)
+ 	reportMouseShapeChanges = boolean(default=false)
+ 
++[speechView]
++	showSpeechViewerAtStartup = boolean(default=false)
++
+ #Keyboard settings
+ [keyboard]
+ 	useCapsLockAsNVDAModifierKey = boolean(default=false)",Please rename [speechView] to [speechViewer].,Why is this needed?
+6524,"@@ -20,6 +20,12 @@ type CpuUsage struct {
+ 	// Total CPU time consumed per core.
+ 	// Units: nanoseconds.
+ 	PercpuUsage []uint64 `json:""percpu_usage,omitempty""`
++	// CPU time consumed per core in kernel mode
++	// Units: nanoseconds.
++	PercpuUsageInKernelmode []uint64 `json:""percpu_usage_in_kernelmode""`
++	// CPU time consumed per core in user mode
++	// Units: nanoseconds.
++	PercpuUsageInUsermode []uint64 `json:""percpu_usage_in_usermode""`
+ 	// Time spent by tasks of the cgroup in kernel mode.
+ 	// Units: nanoseconds.
+ 	UsageInKernelmode uint64 `json:""usage_in_kernelmode""`","I would use shorter yet still descriptive names, e.g. `KernelPerCpu` and `UserPerCpu`.",Why do we need this?
+6525,"@@ -5017,7 +5017,7 @@ def print_record(recID, format='hb', ot='', ln=CFG_SITE_LANG, decompress=zlib.de
+         display_claim_this_paper = False
+ 
+     can_edit_record = False
+-    if check_user_can_edit_record(user_info, recID):
++    if  not (format.lower().startswith('t')) and check_user_can_edit_record(user_info, recID):
+         can_edit_record = True
+ 
+     out = """"","if we are seeking for the content of only one field from metadata, no need to check whether a user could edit record or not",`format.lower().star
+6526,"@@ -25,3 +25,4 @@ class ChromeRemoteConnection(RemoteConnection):
+         self._commands[""launchApp""] = ('POST', '/session/$sessionId/chromium/launch_app')
+         self._commands[""setNetworkConditions""] = ('POST', '/session/$sessionId/chromium/network_conditions')
+         self._commands[""getNetworkConditions""] = ('GET', '/session/$sessionId/chromium/network_conditions')
++        self._commands['ExecuteCDP'] = ('POST', '/session/$sessionId/goog/cdp/execute')",Should this be camelCase to match the above commands? I am not the expert here so maybe Lucas or David can chime in.,"self._commands[""exec"
+6527,"@@ -254,7 +254,8 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+                 scope = tracer.StartActive(ValidateOperationName, serviceName: serviceName);
+                 var span = scope.Span;
+                 span.Type = SpanTypes.GraphQL;
+-
++                span.SetTag(Tags.SpanKind, SpanKinds.Server);
++                span.SetTag(Tags.Language, TracerConstants.Language);
+                 span.SetTag(Tags.GraphQLSource, source);
+ 
+                 // set analytics sample rate if enabled",This is also missing in CreateScopeFromExecuteAsync. Can you add that there too?,Do we need to set th
+6528,"@@ -30,9 +30,12 @@ public class DateUtils {
+         }
+         String date = input.trim().replace('/', '-').replaceAll(""( ){2,}+"", "" "");
+ 
++        // remove colon from timezone to avoid differences between Android and Java SimpleDateFormat
++        date = date.replaceAll(""([+-]\\d\\d):(\\d\\d)$"", ""$1$2"");
++
+         // CEST is widely used but not in the ""ISO 8601 Time zone"" list. Let's hack around.
+-        date = date.replaceAll(""CEST$"", ""+02:00"");
+-        date = date.replaceAll(""CET$"", ""+01:00"");
++        date = date.replaceAll(""CEST$"", ""+0200"");
++        date = date.replaceAll(""CET$"", ""+0100"");
+ 
+         // some generators use ""Sept"" for September
+         date = date.replaceAll(""\\bSept\\b"", ""Sep"");",I hope that this does not break anything... Probably needs detailed beta tests.,Why is this needed?
+6529,"@@ -1518,6 +1518,17 @@ module RSpec::Core
+       end
+     end
+ 
++    describe 'recording spec start time (for measuring load)' do
++      it 'returns a time' do
++        expect(config.start_time).to be_an_instance_of ::Time
++      end
++
++      it 'is configurable' do
++        config.start_time = 42
++        expect(config.start_time).to eq 42
++      end
++    end
++
+     # assigns files_or_directories_to_run and triggers post-processing
+     # via `files_to_run`.
+     def assign_files_or_directories_to_run(*value)",@JonRowe in what scenario do you see this being manually set?,I think this should
+6530,"@@ -307,6 +307,10 @@ void nano::block_processor::process_live (nano::block_hash const & hash_a, std::
+ 			election.election->try_generate_votes (block_a->hash ());
+ 		}
+ 	}
++	else
++	{
++		node.active.check_inactive_votes_cache_election (block_a);
++	}
+ 
+ 	// Announce block contents to the network
+ 	if (origin_a == nano::block_origin::local)","I think the work ""trigger"" makes more sense than ""check"" because this is taking an action based on status.",Shouldn't this be `
+6531,"@@ -41,7 +41,7 @@ public class AuthHandlerBoot implements BootListener {
+       RSAKeypair4Auth.INSTANCE.setPrivateKey(rsaKeyPairEntry.getPrivateKey());
+       RSAKeypair4Auth.INSTANCE.setPublicKey(rsaKeyPairEntry.getPublicKey());
+       RSAKeypair4Auth.INSTANCE.setPublicKeyEncoded(rsaKeyPairEntry.getPublicKeyEncoded());
+-      RegistrationManager.INSTANCE.getMicroserviceInstance().getProperties().put(DefinitionConst.INSTANCE_PUBKEY_PRO,
++      RegistrationManager.INSTANCE.getMicroservice().getProperties().put(DefinitionConst.INSTANCE_PUBKEY_PRO,
+           rsaKeyPairEntry.getPublicKeyEncoded());
+     }
+   }","add a configuration , default put public key in Microservice, if the configuration is set, then put in Instance.",Why this change?
+6532,"@@ -20,8 +20,8 @@ import com.google.common.collect.ImmutableList;
+ public interface OutputView {
+ 
+   public enum Kind {
+-    ASSIGNMENT,
+     COMMENT,
++    DEFINITION,
+     LOOP,
+     PRINT
+   }",WDYT about the idea above of making these all verbs that correspond to the input spec?,Why is this change needed?
+6533,"@@ -77,7 +77,7 @@ import static com.fsck.k9.mail.K9MailLib.PUSH_WAKE_LOCK_TIMEOUT;
+  * </pre>
+  */
+ public class ImapStore extends RemoteStore {
+-    public static final String STORE_TYPE = ""IMAP"";
++    public static final ServerSettings.Type STORE_TYPE = ServerSettings.Type.IMAP;
+ 
+     private static final int IDLE_READ_TIMEOUT_INCREMENT = 5 * 60 * 1000;
+     private static final int IDLE_FAILURE_COUNT_LIMIT = 10;",With the introduction of the enum(s) the constants in the store classes should be removed.,This should be `ServerSett
+6534,"@@ -455,6 +455,12 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		}
+ 	}
+ 
++	// Drop packets with IP options
++	if (ip_header->ihl > 5) {
++		fwd.reason = CALI_REASON_IP_OPTIONS;
++		CALI_DEBUG(""Drop packets with IP options\n"");
++		goto deny;
++	}
+ 	// Setting all of these up-front to keep the verifier happy.
+ 	struct tcphdr *tcp_header = (void*)(ip_header+1);
+ 	struct udphdr *udp_header = (void*)(ip_header+1);",I would say `!= 5`; A packet with <5 would be malformed.,Shouldn't this be `>= 5`?
+6535,"@@ -60,7 +60,7 @@ func New(selector export.AggregationSelector, exporter export.Exporter, opts ...
+ 		c.Timeout = c.Period
+ 	}
+ 
+-	integrator := simple.New(selector, c.Stateful)
++	integrator := simple.New(selector, exporter)
+ 	impl := sdk.NewAccumulator(
+ 		integrator,
+ 		sdk.WithResource(c.Resource),",I think you missed removing `Stateful` from `push/config.go`,Why is this change needed?
+6536,"@@ -29,7 +29,7 @@ namespace Nethermind.Db.Databases
+         {
+         }
+ 
+-        protected override void UpdateReadMetrics() => Metrics.EthRequestsDbReads++;
+-        protected override void UpdateWriteMetrics() => Metrics.EthRequestsDbWrites++;
++        protected internal override void UpdateReadMetrics() => Metrics.EthRequestsDbReads++;
++        protected internal override void UpdateWriteMetrics() => Metrics.EthRequestsDbWrites++;
+     }
+ }",why would you make it internal? if so then at least protected internal,Why is this internal now?
+6537,"@@ -502,6 +502,18 @@ class TestHttps2Http(tservers.ReverseProxTest):
+ class TestTransparent(tservers.TransparentProxTest, CommonMixin, TcpMixin):
+     ssl = False
+ 
++    def test_tcp_stream_modify(self):
++        self.master.load_script(
++            tutils.test_data.path(""scripts/tcp_stream_modify.py""))
++
++        self._tcpproxy_on()
++        d = self.pathod('200:b""foo""')
++        self._tcpproxy_off()
++
++        assert d.content == ""bar""
++
++        self.master.unload_scripts()
++
+ 
+ class TestTransparentSSL(tservers.TransparentProxTest, CommonMixin, TcpMixin):
+     ssl = True","We should check if the response (`d`) contains bar as response, screw the log. :smile:",I think this should be `s
+6538,"@@ -538,7 +538,7 @@ void GPUTreeLearner::AllocateGPUMemory() {
+   }
+   // data transfer time
+   std::chrono::duration<double, std::milli> end_time = std::chrono::steady_clock::now() - start_time;
+-  Log::Info(""%d dense feature groups (%.2f MB) transfered to GPU in %f secs. %d sparse feature groups"", 
++  Log::Info(""%d dense feature groups (%.2f MB) transferred to GPU in %f secs. %d sparse feature groups"", 
+             dense_feature_group_map_.size(), ((dense_feature_group_map_.size() + (dword_features_ - 1)) / dword_features_) * num_data_ * sizeof(Feature4) / (1024.0 * 1024.0), 
+             end_time * 1e-3, sparse_feature_group_map_.size());
+   #if GPU_DEBUG >= 1",@Laurae2 good call. This is the only one I found (with `git grep transfered`),Why this change?
+6539,"@@ -1805,7 +1805,7 @@ class VariablesChecker(BaseChecker):
+         """"""
+         if (
+             node.frame().parent == defstmt
+-            and node.statement(future=True) not in node.frame().body
++            and node.statement(future=True) == node.frame()
+         ):
+             # Check if used as type annotation
+             # Break but don't emit message if postponed evaluation is enabled","I don't understand how this work, could you explain ?",I think this should be `n
+6540,"@@ -183,7 +183,7 @@ analyze_callee_regs_usage(dcontext_t *dcontext, callee_info_t *ci)
+     /* XXX implement bitset for optimisation */
+     memset(ci->reg_used, 0, sizeof(bool) * NUM_GP_REGS);
+     ci->num_simd_used = 0;
+-    memset(ci->simd_used, 0, sizeof(bool) * NUM_SIMD_REGS);
++    memset(ci->simd_used, 0, sizeof(bool) * MCTX_NUM_SIMD_SLOTS);
+     ci->write_flags = false;
+ 
+     num_regparm = MIN(ci->num_args, NUM_REGPARM);","The abbreviation for ""context"" used extensively inside DR is ""cxt"", not ""ctx"", so s/MCTX/MCXT/.",Why do we need this change?
+6541,"@@ -13,5 +13,5 @@ return [
+     */
+ 
+     'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈ میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing again,'failed' => 'یہ تفصیلات ہما
+6542,"@@ -40,6 +40,7 @@ public class WebSocketConfiguration {
+   private String authenticationCredentialsFile;
+   private List<String> hostsAllowlist = Arrays.asList(""localhost"", ""127.0.0.1"");
+   private File authenticationPublicKeyFile;
++  private String authenticationAlgorithm = null;
+   private long timeoutSec;
+   private int maxActiveConnections;
+ ",initializing to null makes me uncomfortable. let's have a default value,Why is this null?
+6543,"@@ -1129,6 +1129,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+                             }
+                             else if (ch == BytePercentage)
+                             {
++                                if (pathStart == -1)
++                                {
++                                    // Empty path is illegal
++                                    RejectRequestLine(start, end);
++                                }
++
+                                 needDecode = true;
+                             }
+ ",This is the `GET % HTTP/1.1` scenario right?,Shouldn't this be `end - 1`
+6544,"@@ -1,6 +1,7 @@
+ <?php namespace Backend\FormWidgets;
+ 
+ use App;
++use Backend\Facades\BackendAuth;
+ use File;
+ use Event;
+ use Lang;","No need to use the fully qualified path the BackendAuth facade, just `use BackendAuth` is fine.",Why do we need this?
+6545,"@@ -357,6 +357,11 @@ bool nano::send_block::valid_predecessor (nano::block const & block_a) const
+ 	return result;
+ }
+ 
++nano::epoch nano::send_block::epoch () const
++{
++	return nano::epoch::epoch_0;
++}
++
+ nano::block_type nano::send_block::type () const
+ {
+ 	return nano::block_type::send;","Because it's similar for send/open/change/receive types, then probably it can be just common `nano::epoch nano::block::epoch () const` with override for state_block (like nano::block::link (), account (), representative ())",Why is this needed?
+6546,"@@ -1,5 +1,6 @@
+ // This is the API that JS files loaded from the webview can see
+ const webviewApiPromises_ = {};
++let cb_ = () => {};
+ 
+ // eslint-disable-next-line no-unused-vars, @typescript-eslint/no-unused-vars
+ const webviewApi = {",Please give a more descriptive name and add a command to explain what it does.,// This is the API t
+6547,"@@ -77,7 +77,8 @@ public class UserPreferences {
+     // Network
+     private static final String PREF_ENQUEUE_DOWNLOADED = ""prefEnqueueDownloaded"";
+     public static final String PREF_UPDATE_INTERVAL = ""prefAutoUpdateIntervall"";
+-    private static final String PREF_MOBILE_UPDATE = ""prefMobileUpdate"";
++    public static final String PREF_MOBILE_UPDATE_OLD = ""prefMobileUpdate"";
++    public static final String PREF_MOBILE_UPDATE = ""prefMobileUpdateAllowed"";
+     public static final String PREF_EPISODE_CLEANUP = ""prefEpisodeCleanup"";
+     public static final String PREF_PARALLEL_DOWNLOADS = ""prefParallelDownloads"";
+     public static final String PREF_EPISODE_CACHE_SIZE = ""prefEpisodeCacheSize"";",we can never get rid of this...,I think this should 
+6548,"@@ -28,8 +28,9 @@ var (
+ 		[]string{""controller"", ""method"", ""resource"", ""remote"", ""status""},
+ 	)
+ 	metricKubeClientRequestSeconds = prometheus.NewHistogramVec(prometheus.HistogramOpts{
+-		Name: ""hive_kube_client_request_seconds"",
+-		Help: ""Length of time for kubernetes client requests."",
++		Name:    ""hive_kube_client_request_seconds"",
++		Help:    ""Length of time for kubernetes client requests."",
++		Buckets: []float64{0.05, 0.1, 0.5, 1, 5, 10, 30, 60, 120},
+ 	},
+ 		[]string{""controller"", ""method"", ""resource"", ""remote"", ""status""},
+ 	)",what is the effect of changing these buckets in existing data that is available in the monitoring system? if there are any existing dashboards that use previous histogram buckets they are probably going to be wrong ot invalid? also any reason why we chose these specific values?,Why are these buckets different?
+6549,"@@ -109,4 +109,13 @@
+ //
+ // 	var h handler
+ // 	yarpc.InjectClients(dispatcher, &h)
++//
++// Automatically Sanitizing TChannel Contexts
++//
++// Contexts created with `tchannel.ContextWithHeaders` are incompatible with yarpc clients generated from thrift.
++// Using such a context will cause a yarpc client to error on any call. Using the `sanitize-tchannel` flag will
++// generate a yarpc client such that all tchannel headers from any context supplied are removed before making a yarpc call.
++// the option can be used like so:
++//
++// 	thriftrw --plugin yarpc --sanitize-tchannel myservice.thrift
+ package thrift","This won't work. For the flag to be passed to the plugin, it should be passed as part of the --plugin argument. --plugin ""yarpc --sanitize-tchannel""",nit: `yarpc client` -> `yarpc cl
+6550,"@@ -2308,6 +2308,13 @@ int LGBM_BoosterSetLeafValue(BoosterHandle handle,
+   API_END();
+ }
+ 
++int LGBM_BoosterGetNumFeatures(BoosterHandle handle, int *out_val) {
++  API_BEGIN();
++  Booster* ref_booster = reinterpret_cast<Booster*>(handle);
++  *out_val = ref_booster->GetBoosting()->MaxFeatureIdx() + 1;
++  API_END();
++}
++
+ int LGBM_BoosterFeatureImportance(BoosterHandle handle,
+                                   int num_iteration,
+                                   int importance_type,","@shiyu1994 @StrikerRUS what do you think about this addition to `c_api.cpp`? I think it's a really useful addition to be able to get this type of information from the `Booster`, but I want more opinions since `c_api` is the main public API for the library.",Shouldn't this be `LGBM_BoosterG
+6551,"@@ -213,6 +213,16 @@ type deferedCommit struct {
+ 	lookback basics.Round
+ }
+ 
++// RoundOffsetError is an error for when requested round is behind earliest stored db entry
++type RoundOffsetError struct {
++	Round   basics.Round
++	DbRound basics.Round
++}
++
++func (e *RoundOffsetError) Error() string {
++	return fmt.Sprintf(""round %d before dbRound %d"", e.Round, e.DbRound)
++}
++
+ // initialize initializes the accountUpdates structure
+ func (au *accountUpdates) initialize(cfg config.Local, dbPathPrefix string, genesisProto config.ConsensusParams, genesisAccounts map[basics.Address]basics.AccountData) {
+ 	au.initProto = genesisProto","rename Round -> requestedRound and DbRound -> dbRound. we don't need to export the fields here, only the error struct.",Why do we need this?
+6552,"@@ -1052,6 +1052,18 @@ func TestClusterDeploymentReconcile(t *testing.T) {
+ 				}
+ 			},
+ 		},
++		{
++			name: ""Add cluster region label"",
++			existing: []runtime.Object{
++				testClusterDeploymentWithoutRegionLabel(),
++			},
++			validate: func(c client.Client, t *testing.T) {
++				cd := getCD(c)
++				if assert.NotNil(t, cd, ""missing clusterdeployment"") {
++					assert.Equal(t, getClusterRegion(cd), cd.Labels[hivev1.HiveClusterRegionLabel], ""incorrect cluster region label"")
++				}
++			},
++		},
+ 		{
+ 			name: ""Ensure cluster metadata set from provision"",
+ 			existing: []runtime.Object{","This expected value should probably be what you literally expect, otherwise there's a chance getClusterRegion is doing something wrong and the test wouldn't catch it because it's being run for both expected and actual.",Why do we need this test case?
+6553,"@@ -27,6 +27,7 @@ package encryption
+ import (
+ 	""crypto/tls""
+ 	""crypto/x509""
++	""encoding/base64""
+ 	""errors""
+ 	""fmt""
+ 	""io/ioutil""",TODO: update unit tests to exercise base64-inline path,Why is this needed?
+6554,"@@ -551,6 +551,16 @@ public class UserPreferences {
+         restartUpdateAlarm(false);
+     }
+ 
++    public static boolean shouldShowOnboarding(String location) {
++        String key = ""onboarding_"" + location;
++        if (prefs.getBoolean(key, true)) {
++            prefs.edit().putBoolean(key, false).apply();
++            return true;
++        } else {
++            return false;
++        }
++    }
++
+     /**
+      * Change the auto-flattr settings
+      *",this method knows too much - it is kind of a strange side effect I'd prefer if we had separate method for acknowledging that the onboarding was done and should not be shown again,This should be `return prefs.g
+6555,"@@ -125,6 +125,7 @@ public class StorageCallbacksImpl implements StorageCallbacks {
+                     PodDBAdapter.KEY_CHAPTER_TYPE));
+         }
+         if(oldVersion <= 14) {
++
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_AUTO_DOWNLOAD + "" INTEGER"");
+             db.execSQL(""UPDATE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS","Do we need to increase the DB version? Also, should probably be a constant, no?",Why do we need this change?
+6556,"@@ -50,6 +50,11 @@ func NewWindow(every, period, offset values.Duration) (Window, error) {
+ 	return w, nil
+ }
+ 
++// IsZero checks if the window's every duration is zero
++func (w Window) IsZero() bool {
++	return w.every.IsZero()
++}
++
+ func (w Window) isValid() error {
+ 	if w.every.IsZero() {
+ 		return errors.New(codes.Invalid, ""duration used as an interval cannot be zero"")","We could utilize the new isZero method in this if-statement, right?",nit: `isZero` -> `isZero`
+6557,"@@ -107,6 +107,14 @@ func (config testBlockOpsConfig) blockCache() BlockCache {
+ 	return config.cache
+ }
+ 
++func (config testBlockOpsConfig) MakeLogger(module string) logger.Logger {
++	return logger.NewNull()
++}
++
++func (config testBlockOpsConfig) DataVersion() DataVer {
++	return FilesWithHolesDataVer
++}
++
+ func makeTestBlockOpsConfig(t *testing.T) testBlockOpsConfig {
+ 	bserver := NewBlockServerMemory(logger.NewTestLogger(t))
+ 	codec := kbfscodec.NewMsgpack()","should probably have config have a `t` or a `logger.NewTestLogger(t)`, and return the latter",Why do we need this?
+6558,"@@ -51,8 +51,10 @@ func (p *heuristicPlanner) Plan(inputPlan *PlanSpec) (*PlanSpec, error) {
+ 
+ 		visited := make(map[PlanNode]struct{})
+ 
+-		nodeStack := make([]PlanNode, len(inputPlan.Results()))
+-		copy(nodeStack, inputPlan.Results())
++		nodeStack := make([]PlanNode, 0, len(inputPlan.Roots))
++		for root := range inputPlan.Roots {
++			nodeStack = append(nodeStack, root)
++		}
+ 
+ 		anyChanged = false
+ 		for len(nodeStack) > 0 {","Does this not do the same thing as `copy`? I thought that `copy` just did an elementwise assignment, but maybe I was wrong.",Why do we need this chang
+6559,"@@ -124,9 +124,9 @@ public abstract class FlatteningConfig {
+     // flattening.
+     Map<String, FlatteningConfig> flatteningConfigs = new LinkedHashMap<>();
+ 
+-    flatteningConfigs.putAll(flatteningConfigsFromGapicConfig);
+-    // Let flattenings from proto annotations override flattenings from GAPIC config.
++    // Let flattenings from GAPIC config override flattenings from proto annotations.
+     flatteningConfigs.putAll(flatteningConfigsFromProtoFile);
++    flatteningConfigs.putAll(flatteningConfigsFromGapicConfig);
+ 
+     return ImmutableList.copyOf(flatteningConfigs.values());
+   }","Here we are merging the configs from proto annotations and gapic config. But in other places in this PR we are using the new enum to pick one or the other, right? Or is that not the correct way to think about this?",Why is this change needed
+6560,"@@ -16,7 +16,7 @@ var opts = struct {
+ 	Usage     string
+ 	Verbosity cli.Verbosity `short:""v"" long:""verbosity"" default:""warning"" description:""Verbosity of output (higher number = more output)""`
+ 	CacheDir  string        `short:""d"" long:""dir"" default:"""" description:""The directory to store cached artifacts in.""`
+-	Port      int           `short:""p"" long:""port"" description:""The port to run the server on""`
++	Port      int           `short:""p"" long:""port"" description:""The port to run the server on"" default:""8080""`
+ }{
+ 	Usage: `
+ HTTP cache implements a resource based http server that please can use as a cache. The cache supports storing files",not related to this change?,I don't think we should change the default here.
+6561,"@@ -51,9 +51,9 @@ if (options.arch) {
+ 
+ const buildType = options.buildType;
+ 
+-const ndkPath = process.env[""ANDROID_NDK""];
++const ndkPath = process.env[""ANDROID_NDK""] || process.env[""ANDROID_NDK_HOME""];
+ if (!ndkPath) {
+-  throw Error(""ANDROID_NDK environment variable not set"");
++  throw Error(""ANDROID_NDK / ANDROID_NDK_HOME environment variable not set"");
+ }
+ 
+ const sdkPath = getAndroidSdkPath();",Why is this needed?,I think this should be `ANDROID_NDK / ANDROID_ND
+6562,"@@ -1353,7 +1353,7 @@ int64_t Creature::getStepDuration() const
+ 	int32_t stepSpeed = getStepSpeed();
+ 	if (stepSpeed > -Creature::speedB) {
+ 		calculatedStepSpeed = floor((Creature::speedA * log((stepSpeed / 2) + Creature::speedB) + Creature::speedC) + 0.5);
+-		if (calculatedStepSpeed <= 0) {
++		if (calculatedStepSpeed == 0) {
+ 			calculatedStepSpeed = 1;
+ 		}
+ 	} else {","This one could be replaced with a `std::max`, no?",Why did you change this?
+6563,"@@ -87,7 +87,10 @@ module Selenium
+           return unless File.exist?(manifest_path)
+ 
+           manifest = JSON.parse(File.read(manifest_path))
+-          [manifest['name'].delete(' '), manifest['version']].join('@')
++          id = if manifest.key?('application') && manifest['application'].key?('gecko')
++                 manifest['application']['gecko']['id']
++               end
++          id || [manifest['name'].delete(' '), manifest['version']].join('@')
+         end
+       end # Extension
+     end # Firefox",Couldn't you just write this as an if/else or a guard clause like on line 87? Just seems a bit weird doing this conditional assignment for essentially an if/else.,Should this be `manifest['application']['gecko']
+6564,"@@ -566,7 +566,11 @@ class Filter extends WidgetBase
+         /*
+          * Set scope value
+          */
+-        $scope->value = $this->getScopeValue($scope);
++        if($scopeType=='checkbox' || $scopeType=='switch'){
++            $scope->value = isset($config['value']) ? $config['value'] : $this->getScopeValue($scope);
++        } else{
++            $scope->value = $this->getScopeValue($scope);
++        }
+ 
+         return $scope;
+     }","Please use strict type comparisons (`===`), not loose type comparisons.",Expected 1 space after IF keyword; 0 found
+6565,"@@ -73,6 +73,14 @@ public class FilterParameter {
+     return blockhash;
+   }
+ 
++  public boolean isValid() {
++    if (!getFromBlock().isLatest() && !getToBlock().isLatest() && getBlockhash() != null) {
++      return false;
++    }
++
++    return true;
++  }
++
+   @Override
+   public String toString() {
+     return MoreObjects.toStringHelper(this)","The filter parameters are a bit confusing. I understand that one of them has to be set, but what takes precedence if a from/to is set and the hash as well? Should that fail?",Why do we need this check?
+6566,"@@ -6,6 +6,9 @@
+ 
+ #include ""graph/context/Iterator.h""
+ 
++#include <cstdio>
++#include <tuple>
++
+ #include ""common/datatypes/Edge.h""
+ #include ""common/datatypes/Vertex.h""
+ #include ""graph/util/SchemaUtil.h""",Is that necessary?,Why is this header needed?
+6567,"@@ -72,7 +72,7 @@ describe Ncr::WorkOrder do
+ 
+   describe ""#ba_6x_tier1_team?"" do
+     it ""is true for whitelist of organizations"" do
+-      org_letters = %w( 7 J 4 T 1 A C Z )
++      org_letters = %w( 1 2 4 7 A C J T Z )
+       org_letters.each do |org_letter|
+         org_code = ""P11#{org_letter}XXXX""
+         ncr_org = build(:ncr_organization, code: org_code)",yess so much easier to read in order like this!,Space inside parentheses detected.
+6568,"@@ -613,6 +613,7 @@ public abstract class LuceneTestCase extends Assert {
+     RuleChain r = RuleChain.outerRule(new TestRuleIgnoreTestSuites())
+       .around(ignoreAfterMaxFailures)
+       .around(suiteFailureMarker = new TestRuleMarkFailure())
++      .around(new VerifyTestClassNamingConvention())
+       .around(new TestRuleAssertionsRequired())
+       .around(new TestRuleLimitSysouts(suiteFailureMarker))
+       .around(tempFilesCleanupRule = new TestRuleTemporaryFilesCleanup(suiteFailureMarker));",question: would this convention automatically and always apply to all classes derived from `LuceneTestCase` including any non-`org.apache` name spaces or would it be possible to opt-out (without an exclusion list) somehow for custom code that might perhaps have chosen a different convention?,Why is this needed?
+6569,"@@ -57,7 +57,7 @@ public class PasscodeManager  {
+ 	private static final String EPREFIX = ""eprefix"";
+ 	
+     // Default min passcode length
+-    protected static final int MIN_PASSCODE_LENGTH = 6;
++    protected static final int MIN_PASSCODE_LENGTH = 4;
+ 
+     // Key in preference for the passcode
+     private static final String KEY_PASSCODE =""passcode"";","Also found this bug, where we were setting the min passcode length to 6, but the min length for a connected app is 4. This can cause problems when the app is force closed or the shared pref is removed.",Why did you change 
+6570,"@@ -175,7 +175,7 @@ class FastTemporalMemory(TemporalMemory):
+     """"""
+     self._validateCell(cell)
+ 
+-    return int(cell.idx / self.cellsPerColumn)
++    return int(cell / self.cellsPerColumn)
+ 
+ 
+   def cellsForColumn(self, column):",Why was this change necessary?,Why this change?
+6571,"@@ -55,7 +55,7 @@ import java.util.logging.Logger;
+ 
+ class Host {
+ 
+-  private static final Logger LOG = Logger.getLogger(""Selenium Distributor"");
++  private static final Logger LOG = Logger.getLogger(""Selenium Host"");
+   private final Node node;
+   private final UUID nodeId;
+   private final URI uri;","I kind of did this deliberately, so everything from the distributor appears in the same set of logs.",I think this should
+6572,"@@ -300,6 +300,7 @@ class TCPSession(IPSession):
+                 return pkt
+             metadata[""pay_class""] = pay_class
+             metadata[""tcp_reassemble""] = tcp_reassemble
++            metadata[""seq""] = pkt[TCP].seq
+         else:
+             tcp_reassemble = metadata[""tcp_reassemble""]
+         # Get a relative sequence number for a storage purpose",We already have a `seq = pkt[TCP].seq` so you can just re-use it.,Why do we need this?
+6573,"@@ -22,11 +22,8 @@ package org.apache.iceberg.data.parquet;
+ import com.google.common.collect.ImmutableList;
+ import com.google.common.collect.Lists;
+ import com.google.common.collect.Maps;
+-import java.time.Instant;
+-import java.time.LocalDate;
+-import java.time.LocalDateTime;
+-import java.time.OffsetDateTime;
+-import java.time.ZoneOffset;
++
++import java.time.*;
+ import java.time.temporal.ChronoUnit;
+ import java.util.Iterator;
+ import java.util.List;","We avoid wildcard imports because it isn't clear where symbols are coming from and there is potential for collision. Could you roll back this change? (As well as the additional newline, we don't use breaks in imports either.)",Please don't use wil
+6574,"@@ -533,11 +533,11 @@ TEST_F(TCPv4Tests, send_and_receive_between_secure_ports_client_verifies)
+                                     (std::chrono::steady_clock::now() + std::chrono::microseconds(100)));
+                     while (!sent)
+                     {
+-                        Locators input_begin(locator_list.begin());
+-                        Locators input_end(locator_list.end());
++                        Locators l_input_begin(locator_list.begin());
++                        Locators l_input_end(locator_list.end());
+ 
+                         sent =
+-                                send_resource_list.at(0)->send(message, 5, &input_begin, &input_end,
++                                send_resource_list.at(0)->send(message, 5, &l_input_begin, &l_input_end,
+                                         (std::chrono::steady_clock::now() + std::chrono::microseconds(100)));
+                         std::this_thread::sleep_for(std::chrono::milliseconds(100));
+                     }",Why are these variables renamed? Is there a conflict with some Windows specific variable?,Why did you change t
+6575,"@@ -18,6 +18,8 @@
+ 
+ require_once(""../inc/util.inc"");
+ require_once(""../inc/xml.inc"");
++if(file_exists('../../release.inc'))
++    include '../../release.inc';
+ 
+ BoincDb::get(true);
+ xml_header();",Do you test for file existence simply to reduce the warning message that may occur using the include? Also - I think the practice used in BOINC is to go ahead and use include_once even though it isn't strictly necessary in this case.,Why is this needed?
+6576,"@@ -20,6 +20,8 @@ import (
+ )
+ 
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ // +chaos-mesh:experiment
+ 
+ // TimeChaos is the Schema for the timechaos API",`TimeChaos` does not contains a field .spec.action,Why do we need this?
+6577,"@@ -1,9 +1,10 @@
+ package net.runelite.rs.api;
+ 
++import net.runelite.api.AbstractArchive;
+ import net.runelite.api.IndexDataBase;
+ import net.runelite.mapping.Import;
+ 
+-public interface RSAbstractArchive extends IndexDataBase
++public interface RSAbstractArchive extends IndexDataBase, AbstractArchive
+ {
+ 	@Import(""takeFile"")
+ 	byte[] getConfigData(int archiveId, int fileId);",You need to override where possible in rs-api,Why is this needed?
+6578,"@@ -25,5 +25,12 @@ namespace Reporting
+         public string BuildName { get; set; }
+ 
+         public DateTime TimeStamp { get; set; }
++
++        public Dictionary<string, string> AdditionalData { get; set; } = new Dictionary<string, string>();
++
++        public void AddData(string key, string payload)
++        {
++            AdditionalData.Add(key, payload);
++        }
+     }
+ }",Should this have an add/update/etc pattern? What happens if I need to change some set of data? May be better to just let the callsite manipulate the dictionary.,Why do we need this?
+6579,"@@ -177,6 +177,18 @@ class PyRegion(object):
+     name: the name of the output
+     """"""
+ 
++  @not_implemented
++  def getAlgorithmInstance(self):
++    """"""
++    Returns the instance of the underlying algorithm that is performing
++    the computation.
++
++    This method should be overridden by the region subclass.
++
++    Note that the return type depends on the Region and therefore
++    cannot be determined in advance.
++    """"""
++
+   def getParameter(self, name, index):
+     """"""Default implementation that return an attribute with the requested name
+ ","I don't think this should be added to PyRegion. Adding it here requires that every region have an ""algorithm"" which may not always make sense and the return value type will be different in every case. But fine to use the same name in the regions where we choose to implement it as a convention if that makes the API more discoverable.",Why is this not impl
+6580,"@@ -421,6 +421,12 @@ func (h *Handler) ServeHTTP(w http.ResponseWriter, r *http.Request, next caddyht
+ 			return nil
+ 		}
+ 
++		// detect connection timeout to the upstream and respond with 504
++		switch e, ok := proxyErr.(net.Error); ok {
++		case e.Timeout():
++			return caddyhttp.Error(http.StatusGatewayTimeout, proxyErr)
++		}
++
+ 		// if the roundtrip was successful, don't retry the request or
+ 		// ding the health status of the upstream (an error can still
+ 		// occur after the roundtrip if, for example, a response handler",Returning here bypasses all the health check and load balancing features.,"I don't think this is the right way to handle this. If the proxy is timeout, we should just return the error."
+6581,"@@ -1,4 +1,4 @@
+-// Copyright (c) 2020 Tigera, Inc. All rights reserved.
++// Copyright (c) 2020-2021 Tigera, Inc. All rights reserved.
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");
+ // you may not use this file except in compliance with the License.","Should revert this copyright change, when the file isn't changing in any other way.",This should be `2020-2021`
+6582,"@@ -90,8 +90,10 @@ func WriteFile(fromFile io.Reader, to string, mode os.FileMode) error {
+ 		return err
+ 	}
+ 	dir, file := path.Split(to)
+-	if err := os.MkdirAll(dir, DirPermissions); err != nil {
+-		return err
++	if dir != """" {
++		if err := os.MkdirAll(dir, DirPermissions); err != nil {
++			return err
++		}
+ 	}
+ 	tempFile, err := ioutil.TempFile(dir, file)
+ 	if err != nil {","Interesting that filepath.Dir(""thing"") returns ""."" whereas this returns """"",Why do we need this change?
+6583,"@@ -364,11 +364,11 @@ class Series(_Frame):
+         ...                    's2': [.3, .6, .0, .1]})
+         >>> s1 = df.s1
+         >>> s2 = df.s2
+-        >>> s1.corr(s2, method='pearson')
+-        -0.8510644963469898
++        >>> s1.corr(s2, method='pearson')  # doctest: +ELLIPSIS
++        -0.851064...
+ 
+-        >>> s1.corr(s2, method='spearman')
+-        -0.9486832980505125
++        >>> s1.corr(s2, method='spearman')  # doctest: +ELLIPSIS
++        -0.948683...
+ 
+         Notes
+         -----","Nice, I did not know about that",Why did you change this?
+6584,"@@ -2521,4 +2521,19 @@ namespace hip_impl {
+             std::terminate();
+         #endif
+     }
++
++    std::mutex executables_cache_mutex;
++
++    void executables_cache(
++            std::string elf, hsa_isa_t isa, hsa_agent_t agent,
++            std::vector<hsa_executable_t>& exes, bool write) {
++        static std::unordered_map<std::string,
++            std::unordered_map<hsa_isa_t,
++                std::unordered_map<hsa_agent_t, std::vector<hsa_executable_t>>>> cache;
++        if (write) {
++            cache[elf][isa][agent] = exes;
++        } else {
++            exes = cache[elf][isa][agent];
++        }
++    }
+ } // Namespace hip_impl.","Since the lock is have moved outside of this function, I think it would be simpler and efficient to just return a ref to the std::vector<hsa_executable_t>? That way, we don't need to make a new copy on read and we won't actually need a write operation.",`exes` can be `const`.
+6585,"@@ -448,12 +448,15 @@ func (api *Server) ReadState(ctx context.Context, in *iotexapi.ReadStateRequest)
+ 	if !ok {
+ 		return nil, status.Errorf(codes.Internal, ""protocol %s isn't registered"", string(in.ProtocolID))
+ 	}
+-	data, err := api.readState(ctx, p, in.GetHeight(), in.MethodName, in.Arguments...)
++	data, readStateHeight, err := api.readState(ctx, p, in.GetHeight(), in.MethodName, in.Arguments...)
+ 	if err != nil {
+ 		return nil, status.Error(codes.NotFound, err.Error())
+ 	}
+ 	out := iotexapi.ReadStateResponse{
+ 		Data: data,
++		BlockIdentifier: &iotextypes.BlockIdentifier{
++			Height: readStateHeight,
++		},
+ 	}
+ 	return &out, nil
+ }",also fetch block hash of this height and return hash,Why do we need this?
+6586,"@@ -75,6 +75,9 @@ namespace Samples.HttpMessageHandler
+ 
+         private static async Task SendHttpClientRequestAsync(bool tracingDisabled)
+         {
++            // Insert a call to the Tracer.Instance to include an AssemblyRef to Datadog.Trace assembly in the final executable
++            var ins = Tracer.Instance;
++
+             Console.WriteLine($""[HttpClient] sending request to {Url}"");
+             var clientRequestContent = new StringContent(RequestContent, Utf8);
+ ",Why do we need this in this sample app and not the others?,Why do we need this?
+6587,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+ 
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+ 
+   @Override",We don't need this additional method.,Why do we need these m
+6588,"@@ -97,6 +97,6 @@ class CreateUserCommand extends Command
+             $output->writeln(sprintf('<error>Can\'t find role %s</error>', $role));
+         }
+ 
+-        return 1;
++        return 0;
+     }
+ }",Shouldn't this return code conditionally? The above line seems like an error occurred.,Why did you change this?
+6589,"@@ -24,6 +24,12 @@ import (
+ 	""k8s.io/apimachinery/pkg/types""
+ )
+ 
++// SupportedDiskType is a map containing the valid disk type
++var SupportedDiskType = map[string]bool{
++	string(apis.TypeSparseCPV): true,
++	string(apis.TypeDiskCPV):   true,
++}
++
+ // SPC encapsulates StoragePoolClaim api object.
+ type SPC struct {
+ 	// actual spc object",What is the need to use string as key? Can we use the apis type as the key?,Why is this a map?
+6590,"@@ -867,6 +867,7 @@ class Uppy {
+ 
+   info (message, type, duration) {
+     const isComplexMessage = typeof message === 'object'
++    duration = typeof duration === 'undefined' ? 3000 : duration
+ 
+     this.setState({
+       info: {",how about a default parameter instead?,Why do we need this?
+6591,"@@ -624,11 +624,11 @@ func (r *ReconcileClusterDeployment) reconcile(request reconcile.Request, cd *hi
+ }
+ 
+ func (r *ReconcileClusterDeployment) reconcileInstallingClusterProvision(cd *hivev1.ClusterDeployment, releaseImage string, logger log.FieldLogger) (reconcile.Result, error) {
+-	// Return early and stop processing if Agent install strategy is in play. The controllers that
++	// Return early and stop processing if ClusterInstallRef is in play. The controllers that
+ 	// handle this portion of the API currently live in the assisted service repo, rather than hive.
+ 	// This will hopefully change in the future.
+-	if cd.Spec.Provisioning != nil && cd.Spec.Provisioning.InstallStrategy != nil && cd.Spec.Provisioning.InstallStrategy.Agent != nil {
+-		logger.Info(""skipping processing of agent install strategy cluster"")
++	if cd.Spec.ClusterInstallRef != nil {
++		logger.Info(""ClusterInstallRef specified, skipping creation of ClusterProvision"")
+ 		return reconcile.Result{}, nil
+ 	}
+ ","i don't think we need to add duplicate check for clusterinstallref here, the function already assumes that it was invoked for clusterprovision",Why do we need to check 
+6592,"@@ -159,7 +159,10 @@ class HybridTaskCascadeRoIHead(CascadeRoIHead):
+         bbox_head = self.bbox_head[stage]
+         bbox_feats = bbox_roi_extractor(
+             x[:len(bbox_roi_extractor.featmap_strides)], rois)
+-        if self.with_semantic and 'bbox' in self.semantic_fusion:
++
++        # bbox_feats.shape[0] > 0 is mean the number of proposal is not 0.
++        if self.with_semantic and 'bbox' in self.semantic_fusion and \
++                bbox_feats.shape[0] > 0:
+             bbox_semantic_feat = self.semantic_roi_extractor([semantic_feat],
+                                                              rois)
+             if bbox_semantic_feat.shape[-2:] != bbox_feats.shape[-2:]:",\`bbox_feats.shape[0] > 0\` requires the number of proposal is not 0.,I think it would be better to use `len(bbox_feats) > 0` instead of `bbox_feats.shape[0] > 0`.
+6593,"@@ -202,9 +202,8 @@ public class RewriteManifestsAction
+         .createDataset(Lists.transform(manifests, ManifestFile::path), Encoders.STRING())
+         .toDF(""manifest"");
+ 
+-    String entriesMetadataTable = metadataTableName(MetadataTableType.ENTRIES);
+-    Dataset<Row> manifestEntryDF = spark.read().format(""iceberg"")
+-        .load(entriesMetadataTable)
++    Dataset<Row> manifestEntryDF = BaseSparkAction.loadMetadataTable(spark, table.name(), table().location(),
++        MetadataTableType.ENTRIES)
+         .filter(""status < 2"") // select only live entries
+         .selectExpr(""input_file_name() as manifest"", ""snapshot_id"", ""sequence_number"", ""data_file"");
+ ",Same here. Any way to fit on one line?,Why do we need this change?
+6594,"@@ -170,6 +170,9 @@ bool TestShard::commitLogs(std::unique_ptr<LogIterator> iter) {
+                     data_.emplace_back(currLogId_, log.toString());
+                     VLOG(1) << idStr_ << ""Write: "" << log << "", LogId: "" << currLogId_
+                             << "" state machine log size: "" << data_.size();
++                    if (log.startsWith(""set "")) {
++                        singleRegister_ = std::stoi(log.subpiece(4).toString());
++                    }
+                     break;
+                 }
+             }",using folly::to is better ?,"nit: `if (log.startsWith(""set "")) {`"
+6595,"@@ -376,7 +376,6 @@ def _init_profiles():
+         private_profile.setter = ProfileSetter(  # type: ignore[attr-defined]
+             private_profile)
+         assert private_profile.isOffTheRecord()
+-        private_profile.setter.init_profile()
+ 
+ 
+ def _init_site_specific_quirks():",I'm guessing this is unintended?,Why was this removed?
+6596,"@@ -284,11 +284,13 @@ class ChangeStreamCursor extends Cursor {
+       if (this.options[optionName]) result[optionName] = this.options[optionName];
+     }
+ 
++    const resumeKey = this.options.startAfter && !this.hasReceived ? 'startAfter' : 'resumeAfter';
++
+     if (this.resumeToken || this.startAtOperationTime) {
+       ['resumeAfter', 'startAfter', 'startAtOperationTime'].forEach(key => delete result[key]);
+ 
+       if (this.resumeToken) {
+-        result.resumeAfter = this.resumeToken;
++        result[resumeKey] = this.resumeToken;
+       } else if (this.startAtOperationTime && maxWireVersion(this.server) >= 7) {
+         result.startAtOperationTime = this.startAtOperationTime;
+       }","This looks a little suspicious to me, can you explain what's going on here?",Shouldn't this be `this.options.resumeAfter`?
+6597,"@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base
+   private
+ 
+   def current_user
+-    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    @current_user ||= find_current_user
++  end
++
++  def find_current_user
++    if ENV['FORCE_USER_ID']
++      User.find ENV['FORCE_USER_ID']
++    else
++      User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    end
+   end
+ 
+   def sign_in(user)",Can you talk about this? I'm not sure I follow why this is necessary.,"I don't think we need this method, since it's"
+6598,"@@ -136,6 +136,8 @@ class AbstractBase extends AbstractActionController
+             ->fromPost('layout', $this->params()->fromQuery('layout', false));
+         if ('lightbox' === $layout) {
+             $this->layout()->setTemplate('layout/lightbox');
++        }elseif(isset($params['layout']) && $params['layout']=='simple'){
++             $this->layout()->setTemplate('layout/simple');
+         }
+         return new ViewModel($params);
+     }","Is there really a need for this 'simple' layout? Is there a reason you can't use 'lightbox'? The only difference seems to be that the lightbox layout includes Piwik/Google Analytics tracking and simple does not. If tracking needs to be disabled for some reason, perhaps there is a way to do that without creating a whole new layout.",missing space after `if`
+6599,"@@ -526,6 +526,19 @@ public abstract class MergePolicy {
+   public abstract MergeSpecification findForcedDeletesMerges(
+       SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException;
+ 
++  /**
++   * Identifies merges that we want to execute (synchronously) on commit. By default, do not synchronously merge on commit.
++   *
++   * If a returned {@link OneMerge} includes a segment already included in a registered merge, then the commit will fail.
++   * Use {@link MergeContext#getMergingSegments()} to determine which segments are currently registered to merge.
++   *
++   * @param segmentInfos the total set of segments in the index (while preparing the commit)
++   * @param mergeContext the IndexWriter to find the merges on
++   */
++  public MergeSpecification findCommitMerges(SegmentInfos segmentInfos, MergeContext mergeContext) throws IOException {
++    return null;
++  }
++
+   /**
+    * Returns true if a new segment (regardless of its origin) should use the
+    * compound file format. The default implementation returns <code>true</code>","Can you say what exception will be thrown in that case (or add an `@throws`, below)?",I don't think this is the right place for thi
+6600,"@@ -5,9 +5,9 @@ import sys
+ # Simple python version test
+ major,minor = sys.version_info[:2]
+ py_version = sys.version.split()[0]
+-if major != 2 or minor < 5:
++if major != 2 or minor < 6:
+   # SystemExit defaults to returning 1 when printing a string to stderr
+-  raise SystemExit(""You are using python %s, but version 2.5 or greater is required"" % py_version)
++  raise SystemExit(""You are using python %s, but version 2.7 or greater is required"" % py_version)
+ 
+ required = 0
+ optional = 0","Is this meant to be ""2.7"" or ""2.6"". The two lines in this commit don't agree with one another. Looks like everything else in this PR is ""2.6"" and that seems sensible.",I don't think this should be changed.
+6601,"@@ -21,8 +21,8 @@
+ # ----------------------------------------------------------------------
+ import unittest
+ 
+-from nupic.data.pattern_machine import (PatternMachine,
+-                                        ConsecutivePatternMachine)
++from nupic.data.generators.pattern_machine import (PatternMachine,
++                                                   ConsecutivePatternMachine)
+ 
+ 
+ ",Should we put these tests in a `generators` directory?,Why is this change needed?
+6602,"@@ -356,8 +356,8 @@ struct greater_equal_op {
+ struct and_op {
+   inline DataType operator()(const DataType& x1,
+                              const DataType& x2) const {
+-    const bool b1 = x1 != zero && !std::isnan(x1);
+-    const bool b2 = x2 != zero && !std::isnan(x2);
++    const auto& b1 = x1 >= DataType(0.5);
++    const auto& b2 = x2 >= DataType(0.5);
+     return (b1 && b2) ? one : zero;
+   }
+   inline void operator()(const DataType& x1,",I think that it makes more sense to keep these with the standard definition of non-zero is true and zero is false.,Why do we need this change?
+6603,"@@ -34,9 +34,9 @@ class DummyRequest(mock.MagicMock):
+         self.authn_type = 'basicauth'
+         self.prefixed_userid = 'basicauth:bob'
+         self.effective_principals = [
+-            self.prefixed_userid,
+             'system.Everyone',
+-            'system.Authenticated']
++            'system.Authenticated',
++            'bob']
+         self.json = {}
+         self.validated = {}
+         self.matchdict = {}",Any idea why you want to change the behavior here? Is there a security risk not to have the prefix in the principal here.,Why was this removed?
+6604,"@@ -47,6 +47,7 @@ type ConfigMock struct {
+ 	mockMdcache    *MockMDCache
+ 	mockKcache     *MockKeyCache
+ 	mockBcache     *MockBlockCache
++	mockDBcache    *MockDirtyBlockCache
+ 	mockCrypto     *MockCrypto
+ 	mockCodec      *MockCodec
+ 	mockMdops      *MockMDOps","this reads like ""mock database cache"", maybe a clearer name",Please rename to `mockDirtyBlockCache`
+6605,"@@ -26,6 +26,8 @@ import (
+ 	""net/http""
+ 	""time""
+ 
++	""github.com/jetstack/cert-manager/pkg/webhook/server/util""
++
+ 	logf ""github.com/jetstack/cert-manager/pkg/logs""
+ 
+ 	""github.com/go-logr/logr""",Nit: move this with the other CM imports.,"""github.com/pkg/errors"""
+6606,"@@ -2,9 +2,10 @@
+ 
+ namespace Shopsys\ShopBundle\Controller\Front;
+ 
++use League\Flysystem\FilesystemInterface;
+ use Shopsys\FrameworkBundle\Component\Image\Config\ImageConfig;
+ use Shopsys\FrameworkBundle\Component\Image\Processing\ImageGeneratorFacade;
+-use Symfony\Component\HttpFoundation\BinaryFileResponse;
++use Symfony\Component\HttpFoundation\StreamedResponse;
+ 
+ class ImageController extends FrontBaseController
+ {",This change should be mentioned in the CM,Why do we need this change?
+6607,"@@ -23,6 +23,13 @@ namespace Datadog.Trace
+             HttpHeaderNames.DatadogTags,
+         };
+ 
++        /// <summary>
++        /// An <see cref=""ISpanContext""/> with default values. Can be used as the value for
++        /// <see cref=""SpanCreationSettings.Parent""/> in <see cref=""Tracer.StartActive(string, SpanCreationSettings)""/>
++        /// to specify that the new span should not inherit the currently active scope as its parent.
++        /// </summary>
++        public static readonly ISpanContext Empty = new ReadOnlySpanContext(traceId: 0, spanId: 0, serviceName: null);
++
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""SpanContext""/> class
+         /// from a propagated context. <see cref=""Parent""/> will be null","Do we really want a new type, or can we just use `SpanContext`? The `ISpanContext` interface is read-only, but there's nothing stopping users from casting this to `SpanContext` and modifying it.",I think this should be `readonly`
+6608,"@@ -13,7 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
+-#if NET461
++#if NET452 || NET461
+ using System;
+ using System.Collections;
+ using System.Collections.Generic;",Should we define a const like NETFRAMEWORK or NETFULL which will be set for NET452 NET461 and anything like NET47 etc in future?,Why is this needed?
+6609,"@@ -36,6 +36,12 @@ const PoStProofLength = 192
+ // https://github.com/filecoin-project/go-filecoin/issues/966
+ var ProvingPeriodBlocks = types.NewBlockHeight(20000)
+ 
++// GracePeriodBlocks is the number of blocks after a proving period over
++// which a miner can still submit a post at a penalty.
++// TODO: what is a secure value for this?  Value is arbitrary right now.
++// See https://github.com/filecoin-project/go-filecoin/issues/1887
++var GracePeriodBlocks = types.NewBlockHeight(100)
++
+ const (
+ 	// ErrPublicKeyTooBig indicates an invalid public key.
+ 	ErrPublicKeyTooBig = 33",maybe start an issue to capture params that we need final values for and link to it here?,I don't think this 
+6610,"@@ -288,6 +288,8 @@ class _RunData(object):
+         alternate_services = set()
+         direct_access_sources = set()
+         for backend in backend_service.backends:
++            if not backend.get('group'):
++                continue
+             instance_group = self.find_instance_group_by_url(
+                 backend.get('group'))
+             if not instance_group:","Can we instead do the check in find_instance_group_by_url() ? if we return None when group is not found, it will hit the next if statement (if not instance_group) and continue as expected, in this case we don't need to add 3 separate if statements",Why is this needed?
+6611,"@@ -85,15 +85,15 @@ public class DateUtil {
+     }
+ 
+     public static int toSeconds(String hh_colon_mm) {
+-        Pattern p = Pattern.compile(""(\\d+):(\\d+)( a.m.| p.m.|)"");
++        Pattern p = Pattern.compile(""(\\d+):(\\d+)( a.m.| p.m.| AM | PM)"");
+         Matcher m = p.matcher(hh_colon_mm);
+         int retval = 0;
+ 
+         if (m.find()) {
+             retval = SafeParse.stringToInt(m.group(1)) * 60 * 60 + SafeParse.stringToInt(m.group(2)) * 60;
+-            if (m.group(3).equals("" .a.m"") && m.group(1).equals(""12""))
++            if (m.group(3).equals("" AM"") && m.group(1).equals(""12""))
+                 retval -= 12 * 60 * 60;
+-            if (m.group(3).equals("" p.m."") && !m.group(1).equals(""12""))
++            if (m.group(3).equals("" PM"") && !(m.group(1).equals(""12"")))
+                 retval += 12 * 60 * 60;
+         }
+         return retval;","on my android "".a.m"" and "".p.m"" is used add `||` here to support both variants",Why is this change 
+6612,"@@ -4647,7 +4647,7 @@ bool CoreChecks::PreCallValidateCreateImageView(VkDevice device, const VkImageVi
+                     skip |= LogError(pCreateInfo->image, ""VUID-VkImageViewCreateInfo-image-01586"", ""%s"", ss.str().c_str());
+                 }
+             } else {
+-                if ((!(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR)) || (!FormatIsMultiplane(image_format))) {
++                if (!(image_flags & VK_IMAGE_CREATE_BLOCK_TEXEL_VIEW_COMPATIBLE_BIT_KHR)) {
+                     // Format MUST be compatible (in the same format compatibility class) as the format the image was created with
+                     if (FormatCompatibilityClass(image_format) != FormatCompatibilityClass(view_format)) {
+                         const char *error_vuid;",`!FormatIsMultiplane(image_format)` will always be true at this point due to the test on line 4639.,Why did you remove this check?
+6613,"@@ -24,6 +24,7 @@ from typing import Any, Optional, List, Union
+ 
+ import numpy as np
+ import pandas as pd
++from pandas.core.accessor import CachedAccessor
+ 
+ from pyspark import sql as spark
+ from pyspark.sql import functions as F","Maybe inline the CachedAccessor code? Is it similar to our lazy property? If yes, can we reconcile the two?",from pandas.core.accessor impo
+6614,"@@ -34,7 +34,7 @@ func (c SmokeTestCase) BuildInputShape(ref *ShapeRef) string {
+ 	)
+ }
+ 
+-// AttachSmokeTests attaches the smoke test cases to the API model.
++	// AttachSmokeTests attaches the smoke test cases to the API model.
+ func (a *API) AttachSmokeTests(filename string) {
+ 	f, err := os.Open(filename)
+ 	if err != nil {",Nit this file has unintended changes.,Why this change?
+6615,"@@ -101,6 +101,8 @@ public class FeedItemMenuHandler {
+             mi.setItemVisibility(R.id.share_download_url_with_position_item, false);
+         }
+ 
++        mi.setItemVisibility(R.id.share_file, selectedItem.getMedia().fileExists());
++
+         if (selectedItem.isPlayed()) {
+             mi.setItemVisibility(R.id.mark_read_item, false);
+         } else {",Potential NPE? `hasMedia && selectedItem...`,Shouldn't this be `mi.setItemV
+6616,"@@ -1662,7 +1662,7 @@ class EC2Connection(AWSQueryConnection):
+             params['AutoEnableIO.Value'] = new_value
+         return self.get_status('ModifyVolumeAttribute', params, verb='POST')
+ 
+-    def create_volume(self, size, zone, snapshot=None,
++    def create_volume(self, size, zone = None, snapshot=None,
+                       volume_type=None, iops=None):
+         """"""
+         Create a new EBS Volume.",PEP-8/consistency with the rest of the code.,Why did you change this?
+6617,"@@ -0,0 +1,15 @@
++using Datadog.Trace.ClrProfiler.Integrations;
++
++namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.MongoDb
++{
++    internal abstract class MongoDbInstrumentMethodAttribute : InstrumentMethodAttribute
++    {
++        protected MongoDbInstrumentMethodAttribute(string typeName)
++        {
++            AssemblyName = MongoDbIntegration.MongoDbClientAssembly;
++            TypeName = typeName;
++            IntegrationName = MongoDbIntegration.IntegrationName;
++            ParameterTypeNames = new[] { ""MongoDB.Driver.Core.Connections.IConnection"", ClrNames.CancellationToken };
++        }
++    }
++}",nit: Would you mind moving the `ParameterTypeNames` assignment into each of the method-specific attributes? That could reduce confusion if we later decided to instrument other methods in MongoDb,I think this should be `
+6618,"@@ -0,0 +1,16 @@
++using System.Collections.Generic;
++using Nethermind.Blockchain.Find;
++using Nethermind.Core;
++using Nethermind.Core.Specs;
++using Nethermind.Int256;
++
++namespace Nethermind.JsonRpc.Modules.Eth
++{
++    public interface IGasPriceOracle
++    {
++        public ISpecProvider SpecProvider { get; }
++        public UInt256? FallbackGasPrice { get; }
++        public List<UInt256> TxGasPriceList { get; }
++        ResultWrapper<UInt256?> GasPriceEstimate(Block? headBlock, IBlockFinder blockFinder);
++    }
++}",Is exposing SpecProvider needed here?,Shouldn't this be `List<
+6619,"@@ -141,6 +141,18 @@ namespace MvvmCross.ViewModels
+             }
+         }
+ 
++        [NotifyPropertyChangedInvocator]
++        protected virtual bool SetProperty<T>(ref T storage, T value, Action afterAction, [CallerMemberName] string propertyName = null)
++        {
++            if (!SetProperty(ref storage, value, propertyName))
++            {
++                return false;
++            }
++
++            afterAction?.Invoke();
++            return true;
++        }
++
+         [NotifyPropertyChangedInvocator]
+         protected virtual bool SetProperty<T>(ref T storage, T value, [CallerMemberName] string propertyName = null)
+         {","So this will only be executed when it is true. I'm not sure that makes it always usable. Why not make the afterAction, `Action<bool>` and always call it, with the result as parameter.",Why do we need this?
+6620,"@@ -516,6 +516,7 @@ int pfs_table::resolve_name(int is_special_syscall, const char *cname, struct pf
+ 		char tmp[PFS_PATH_MAX];
+ 		path_split(pname->path,pname->service_name,tmp);
+ 		pname->service = pfs_service_lookup(pname->service_name);
++		if (result == PFS_RESOLVE_LOCAL) pname->service = NULL;
+ 		if(!pname->service) {
+ 			pname->service = pfs_service_lookup_default();
+ 			strcpy(pname->service_name,""local"");","Tim, please add { } to this 'if'.",Shouldn't this be `pname->service = NULL;`?
+6621,"@@ -11,8 +11,11 @@ import (
+ )
+ 
+ const (
+-	// DefaultPort is used when no port is specified
++	// DefaultPort is used when no port is specified.
+ 	DefaultPort = ""31000""
++
++	// DefaultHost is the host that will be used when none is specified.
++	DefaultHost = ""127.0.0.1""
+ )
+ 
+ // Reporter will gather metrics of API requests made and",Suggest moving to `enable.go` since thats only place used.,I think this should be `127.0.0.1`
+6622,"@@ -54,7 +54,7 @@ describe ""apply"" do
+ 
+         # Includes agent facts from apply_prep
+         agent_facts = report['resource_statuses']['Notify[agent facts]']['events'][0]['desired_value'].split(""\n"")
+-        expect(agent_facts[0]).to match(/^\w+\./)
++        expect(agent_facts[0]).to match(/^\w+/)
+         expect(agent_facts[1]).to eq(agent_facts[0])
+         expect(agent_facts[2]).to match(/^\d+\.\d+\.\d+$/)
+         expect(agent_facts[3]).to eq(agent_facts[2])","This changed when I rebuilt my docker container. Not quite sure why, but might have to do with what my host network configuration looks like when it's rebuilt.",Why is this change needed?
+6623,"@@ -13,6 +13,7 @@ import (
+ 	""github.com/restic/restic/server""
+ )
+ 
++// Cache is used to handle the local cache.
+ type Cache struct {
+ 	base string
+ }",Local cache of what? What's stored in it?,package cache
+6624,"@@ -176,7 +176,7 @@ public class DataFiles {
+       this.keyMetadata = toCopy.keyMetadata() == null ? null
+           : ByteBuffers.copy(toCopy.keyMetadata());
+       this.splitOffsets = toCopy.splitOffsets() == null ? null : copyList(toCopy.splitOffsets());
+-      this.sortOrderId = toCopy.sortOrderId();
++      this.sortOrderId = toCopy.sortOrderId() == null ? SortOrder.unsorted().orderId() : toCopy.sortOrderId();
+       return this;
+     }
+ ","If the copied `DataFile` returns null, shouldn't the copy also return null? Why not make the builder use `Integer` instead of a primitive here?",Why do we need this change?
+6625,"@@ -2,11 +2,18 @@ import os
+ 
+ from jinja2 import Environment, FileSystemLoader
+ 
++HTML_FILES_PATH = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'html_files')
++
+ def save_html(filename, context, template):
+     path = os.path.dirname(os.path.abspath(__file__))
+     template_environment = Environment(
+     loader=FileSystemLoader(os.path.join(path, 'templates')))
+-    outputfile = os.path.join(os.path.dirname(os.path.abspath(__file__)), 'html_files', filename)
++    outputfile = os.path.join(HTML_FILES_PATH, filename)
+     with open(outputfile, 'w') as f:
+         html = template_environment.get_template(template).render(context)
+         f.write(html)
++
++
++def check_html_files_dir_path():
++    dir_exists = os.path.isdir(HTML_FILES_PATH)
++    return dir_exists","You could just do this test in the `save_html` function above, and then the users of the save html function don't have to worry about it.",Why do we need this functio
+6626,"@@ -214,7 +214,7 @@ func TestTaskRunOpts_Validate(t *testing.T) {
+ 					Name: ""my-app"",
+ 				}, nil)
+ 			},
+-			wantedError: errors.New(""get environment: couldn't find environment dev in the application my-app""),
++			wantedError: fmt.Errorf(""get environment %s config: couldn't find environment dev in the application my-app"", ""dev""),
+ 		},
+ 		""no workspace"": {
+ 			basicOpts: defaultOpts,","I think I'd prefer not using the formatted string when it comes to unit test, since we don't pass in any string variable as params.",I think this should be `err
+6627,"@@ -1,4 +1,4 @@
+-// +build avr esp nrf sam sifive stm32 k210 nxp
++// +build avr esp nrf sam sifive stm32 k210 nxp,!mimxrt1062
+ 
+ package machine
+ ",Maybe it would be better to explicitly include devices instead of explicitly excluding devices?,// +build avr nrf sam sifiv
+6628,"@@ -475,10 +475,10 @@ void ROMol::clearComputedProps(bool includeRings) const {
+ 
+   RDProps::clearComputedProps();
+ 
+-  for (ConstAtomIterator atomIt = this->beginAtoms();
+-       atomIt != this->endAtoms(); ++atomIt) {
+-    (*atomIt)->clearComputedProps();
++  for (auto atom: atoms()) {
++    atom->clearComputedProps();
+   }
++  
+   for (ConstBondIterator bondIt = this->beginBonds();
+        bondIt != this->endBonds(); bondIt++) {
+     (*bondIt)->clearComputedProps();","This could be `for (auto bond: bonds()){`, right?",Why not `const auto& atom`?
+6629,"@@ -78,10 +78,13 @@ class LibraryCardsController extends AbstractBase
+         // Connect to the ILS for login drivers:
+         $catalog = $this->getILS();
+ 
++        $config = $this->getConfig();
+         return $this->createViewModel(
+             [
+                 'libraryCards' => $user->getLibraryCards(),
+-                'multipleTargets' => $catalog->checkCapability('getLoginDrivers')
++                'multipleTargets' => $catalog->checkCapability('getLoginDrivers'),
++                'allowConnectingCards' => $this->getAuthManager()
++                    ->supportsConnectingLibraryCard(),
+             ]
+         );
+     }",Is $config no longer being used? Can we remove this line?,Why do we need this variabl
+6630,"@@ -179,7 +179,7 @@ char* get_file_name(char* filename)
+ //   finished with it.
+ // If you pass in NULL or the new string can't be allocated,
+ //   it returns NULL.
+-char* remove_ext(const char* path, char dot, char sep, size_t* allocated_size) 
++char* remove_ext(const char* path, char dot, char sep, size_t* allocated_size)
+ {
+     char *retstr, *lastdot, *lastsep;
+     // Error checks and allocate string.",can you revert changes to this file.,Why this change?
+6631,"@@ -2139,7 +2139,7 @@ public class DBService {
+                 Role templateRole = updateTemplateRole(role, domainName, roleName, templateParams);
+                 firstEntry = auditLogSeparator(auditDetails, firstEntry);
+                 auditDetails.append("" \""add-role\"": "");
+-                if (!processRole(con, originalRole, domainName, roleName, templateRole,
++                if (!processRole(con, originalRole, domainName, ZMSUtils.removeDomainPrefix(templateRole.getName(), domainName, ROLE_PREFIX), templateRole,
+                         admin, auditRef, true, auditDetails)) {
+                     return false;
+                 }","I don't believe the change is sufficient to correctly handle variable substitutions in the name. As part of the process command we pass the original role object that was retreived without taking into account the substitution. So while the first template apply command will work fine because the original role does not exist thus it's a new add operation, if you try to re-apply the same template again, we'll pick up and process a wrong original name thus we'll try to execute an add operation again instead of modify. So we need to take into account the substituted name when we retrieve the original role as well. Same change should be applied to both policy and service blocks as well.",Why do we need to remove th
+6632,"@@ -14,5 +14,6 @@ namespace MvvmCross.Base
+     {
+         Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);
+         Task ExecuteOnMainThreadAsync(Func<Task> action, bool maskExceptions = true);
++        bool IsOnMainThread { get; }
+     }
+ }",Please add this to IMvxMainThreadDispatcher as well,public interface IOnMainThread
+6633,"@@ -223,7 +223,7 @@ module Bolt
+           if @future
+             to_expand = %w[private-key cacert token-file] & selected.keys
+             to_expand.each do |opt|
+-              selected[opt] = File.expand_path(selected[opt], @boltdir.path) if opt.is_a?(String)
++              selected[opt] = File.expand_path(selected[opt], @boltdir.path) if selected[opt].is_a?(String)
+             end
+           end
+ ",Is it possible for opt not to be a string? I couldn't tell if this was a typo or if there is actually a case where it is not a string.,Why is this change needed?
+6634,"@@ -54,6 +54,7 @@ export default function UserInputSettings() {
+ 			ctaLabel={ __( 'Let’s go', 'google-site-kit' ) }
+ 			dismiss={ __( 'Remind me later', 'google-site-kit' ) }
+ 			winImage={ global._googlesitekitLegacyData.admin.assetsRoot + personSitImage }
++			className=""googlesitekit-user-input__notification""
+ 		/>
+ 	);
+ }",Let's move this up next to the `id` as we usually have `className` as one of the first props.,I think this should be `google
+6635,"@@ -4,14 +4,14 @@ import sys
+ from setuptools import setup, find_packages
+ from setuptools.command.install import install
+ 
+-VERSION = ""3.1.0""
++VERSION = ""3.1.1""
+ 
+ def readme():
+     readme_short = """"""
+     Quilt is a data management tool designed for data discoverability, data dependency
+     management, and data version control using `data packages <https://blog.quiltdata.com/data-packages-for-fast-reproducible-python-analysis-c74b78015c7f>`_.
+ 
+-    The `quilt` PyPi package allows you to build, push, and pull data packages in Quilt using Python.
++    The `quilt3` PyPi package allows you to build, push, and pull data packages in Quilt using Python.
+     Visit the `documentation quickstart <https://docs.quiltdata.com/quickstart>`_ for more information.
+ 
+     """"""","While you're in here, ""build, push and install""?",This should be `3.1.2`
+6636,"@@ -35,8 +35,6 @@ namespace OpenTelemetry.Metrics
+ 
+         public string Description { get; set; }
+ 
+-        public string Unit { get; set; }
+-
+         public string[] TagKeys { get; set; }
+ 
+         public virtual Aggregation Aggregation { get; set; }",Unit never made it to spec...so removing.,Why is this removed?
+6637,"@@ -702,6 +702,9 @@ func (nl *NATSLatency) TotalTime() time.Duration {
+ // ServiceLatency is the JSON message sent out in response to latency tracking for
+ // exported services.
+ type ServiceLatency struct {
++	Type           string        `json:""type""`
++	ID             string        `json:""id""`
++	Time           string        `json:""timestamp""`
+ 	Status         int           `json:""status""`
+ 	Error          string        `json:""description,omitempty""`
+ 	AppName        string        `json:""app,omitempty""`","We have RequestStart which seems redundant a bit to this one, WDYT?",Why is this a string
+6638,"@@ -1,10 +1,4 @@
+-import {
+-	Component,
+-	createElement,
+-	_unmount as unmount,
+-	options,
+-	cloneElement
+-} from 'preact';
++import { Component, createElement, options, Fragment } from 'preact';
+ import { removeNode } from '../../src/util';
+ 
+ const oldCatchError = options._catchError;",I think we can remove this corresponding export from `preact` now! Double check no other s using though lol,`Fragment` is not us
+6639,"@@ -78,6 +78,14 @@ ActiveRecord::Schema.define(version: 20140604204910) do
+     t.datetime ""updated_at""
+   end
+ 
++  create_table ""item_traits"", force: true do |t|
++    t.text     ""name""
++    t.text     ""value""
++    t.integer  ""cart_item_id""
++    t.datetime ""created_at""
++    t.datetime ""updated_at""
++  end
++
+   create_table ""user_roles"", force: true do |t|
+     t.integer ""approval_group_id""
+     t.integer ""user_id""",I'm not sure why this would be in here. Were you working off a branch based off of master? These lines were removed in a previous commit because the table is actually called 'cart_item_traits'.,Unnecessary spacing 
+6640,"@@ -30,6 +30,8 @@ module Travis
+         bundler: false
+       }
+ 
++      DEFAULT_GITHUB_ENDPOINT = ""https://api.github.com""
++
+       attr_reader :data
+ 
+       def initialize(data, defaults = {})","Maybe `DEFAULT_GITHUB_API_ENDPOINT` would be a better name, since we refer to this as an API endpoint elsewhere?",This should be `DEFAULT_GITHUB_URL`
+6641,"@@ -45,7 +45,9 @@ const (
+ 	capabilityPrefix             = ""com.amazonaws.ecs.capability.""
+ 	capabilityTaskIAMRole        = ""task-iam-role""
+ 	capabilityTaskIAMRoleNetHost = ""task-iam-role-network-host""
++	capabilityTaskCPUMemLimit    = ""task-cpu-mem-limit""
+ 	labelPrefix                  = ""com.amazonaws.ecs.""
++	attributePrefix              = ""ecs.capability.""
+ )
+ 
+ // DockerTaskEngine is a state machine for managing a task and its containers","If/when you rebase from `dev`, this is going to cause a merge conflict. I'd suggest that soon after merging this PR as the capabilities code has been moved to ""agent/app/agent_capabilities.go""",Why do we need this?
+6642,"@@ -40,6 +40,14 @@ func Test_Start(t *testing.T) {
+ 	assert.Equal(t, ""bytecount 1"", mockConnection.LastLine)
+ }
+ 
++func Test_Stop(t *testing.T) {
++	statsRecorder := fakeStatsRecorder{}
++	middleware := NewMiddleware(statsRecorder.record, 1*time.Second)
++	mockConnection := &management.MockConnection{}
++	middleware.Stop(mockConnection)
++	assert.Equal(t, ""bytecount 0"", mockConnection.LastLine)
++}
++
+ func Test_ConsumeLine(t *testing.T) {
+ 	var tests = []struct {
+ 		line                  string",What is the test case here?,nit: `bytecount` should be `bytecou
+6643,"@@ -130,6 +130,7 @@ func run(o *Options) error {
+ 	go flowAggregator.Run(stopCh, &wg)
+ 
+ 	informerFactory.Start(stopCh)
++	informerFactory.WaitForCacheSync(stopCh)
+ 
+ 	<-stopCh
+ 	klog.Infof(""Stopping flow aggregator"")","You could try moving this closer to the call, where we request label info. We might be doing the check very early.. all the resources may not be present with the informer at this point.",Why do we need to wait here?
+6644,"@@ -42,7 +42,10 @@ public interface ManifestFile {
+           required(509, ""contains_null"", Types.BooleanType.get()),
+           optional(510, ""lower_bound"", Types.BinaryType.get()), // null if no non-null values
+           optional(511, ""upper_bound"", Types.BinaryType.get())
+-      ))));
++      ))),
++      optional(512, ""added_rows_count"", Types.LongType.get()),
++      optional(513, ""existing_rows_count"", Types.LongType.get()),
++      optional(514, ""deleted_rows_count"", Types.LongType.get()));
+ 
+   static Schema schema() {
+     return SCHEMA;",Can we add these up by the data files counts?,Why do we need this?
+6645,"@@ -30,10 +30,8 @@ const resolve = (list, child, node) => {
+ 	// callbacks won't get queued in the node anyway.
+ 	// If revealOrder is 'together' then also do an early exit
+ 	// if all suspended descendants have not yet been resolved.
+-	if (
+-		!list.props.revealOrder ||
+-		(list.props.revealOrder[0] === 't' && list._map.size)
+-	) {
++	const revealOrder = list.props.revealOrder;
++	if (!revealOrder || (revealOrder[0] === 't' && list._map.size)) {
+ 		return;
+ 	}
+ ",Most of the time assigning won't save bytes unless used 3+ times (var adds 3bytes),Why is this change n
+6646,"@@ -160,8 +160,8 @@ define(['playbackManager', 'nowPlayingHelper', 'events', 'connectionManager'], f
+ 
+         if (navigator.mediaSession) {
+             navigator.mediaSession.metadata = new MediaMetadata({
+-                title: title,
+-                artist: artist,
++                title: artist,
++                artist: title,
+                 album: album,
+                 artwork: getImageUrls(item),
+                 albumArtist: albumArtist,",I would rather find the code that inverts the logic and remove that.,Why did you change t
+6647,"@@ -142,7 +142,7 @@ class RemoteConnection(object):
+         :Returns:
+         Timeout value in seconds for all http requests made to the Remote Connection
+         """"""
+-        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout
++        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT else cls._timeout
+ 
+     @classmethod
+     def set_timeout(cls, timeout):",The else doesn't return anything?,I don't think this c
+6648,"@@ -48,7 +48,7 @@ func claim(args []string) error {
+ 		gasLimit = action.ClaimFromRewardingFundBaseGas +
+ 			action.ClaimFromRewardingFundGasPerByte*uint64(len(payload))
+ 	}
+-	gasPriceRau, err := gasPriceInRau()
++	gasPriceRau, _ := gasPriceInRau()
+ 	nonce, err := nonce(sender)
+ 	if err != nil {
+ 		return output.NewError(0, ""failed to get nonce"", err)",assignments should only be cuddled with other assignments (from `wsl`),Why ignore the error here?
+6649,"@@ -3413,9 +3413,8 @@ static void
+ GetLibrarySearchPaths(std::vector<std::string> &paths,
+                       const swift::SearchPathOptions &search_path_opts) {
+   paths.clear();
+-  paths.resize(search_path_opts.LibrarySearchPaths.size() + 1);
+-  std::copy(search_path_opts.LibrarySearchPaths.begin(),
+-            search_path_opts.LibrarySearchPaths.end(), paths.begin());
++  paths.assign(search_path_opts.LibrarySearchPaths.begin(),
++            search_path_opts.LibrarySearchPaths.end());
+   paths.push_back(search_path_opts.RuntimeLibraryPath);
+ }
+ ",why not simply `paths = search_path_opts.LibrarySearchPaths` ?,Why did you change this?
+6650,"@@ -610,7 +610,7 @@ define([""globalize"", ""listView"", ""layoutManager"", ""userSettings"", ""focusManager""
+             }
+ 
+             if (item) {
+-                return item.Name;
++                return globalize.translate(item.Name);
+             }
+ 
+             if (""Movie"" === params.type) {",Are we sure this should be translated by the web client? It was unclear in chat exactly what's getting translated here.,I think this should be `gl
+6651,"@@ -253,7 +253,7 @@ func (c *collection) actionToWrites(a *driver.Action) ([]*pb.Write, string, erro
+ 			docName = driver.UniqueString()
+ 			newName = docName
+ 		}
+-		w, err = c.putWrite(a.Doc, docName, &pb.Precondition{ConditionType: &pb.Precondition_Exists{false}})
++		w, err = c.putWrite(a.Doc, docName, &pb.Precondition{ConditionType: &pb.Precondition_Exists{Exists: false}})
+ 
+ 	case driver.Replace:
+ 		// If the given document has a revision, use it as the precondition (it implies existence).",same oneof issue.,Why is this necessary?
+6652,"@@ -258,7 +258,7 @@ module Bolt
+                     config.project.puppetfile,
+                     config.project.managed_moduledir,
+                     config.project.project_file,
+-                    config.module_install)
++                    @plugins.resolve_references(config.module_install))
+     end
+ 
+     # Generate Puppet data types from project modules.","If we resolve here, isn't the whole `module_install` config setting or any subkeys also pluggable? I think that's totally fine, just want to make sure that that's known, and we should also update the data in `options.rb` for those options",I don't think this is the right place to do this. I think it should be in the plugin.
+6653,"@@ -376,6 +376,7 @@ hipError_t ihipExtLaunchMultiKernelMultiDevice(hipLaunchParams* launchParamsList
+ 
+         if(globalWorkSizeX > UINT32_MAX || globalWorkSizeY > UINT32_MAX || globalWorkSizeZ > UINT32_MAX)
+         {
++            free(kds);
+             return hipErrorInvalidConfiguration;
+         }
+ ",it would be better to change `kds` into a `std::vector` then we don't need to explicitly free it,Shouldn't this be `kds = NULL`?
+6654,"@@ -113,6 +113,8 @@ def send_email_sendgrid(config, sender, subject, message, recipients, image_png)
+ 
+ 
+ def send_email(subject, message, sender, recipients, image_png=None):
++    config = configuration.get_config()
++
+     subject = _prefix(subject)
+     logger.debug(""Emailing:\n""
+                  ""-------------\n""",Looks like you're also changing logic and not only tests.,Why do we need this?
+6655,"@@ -78,7 +78,7 @@ namespace Datadog.Trace.Tests.Sampling
+ 
+             var expectedLimit = totalMilliseconds * actualIntervalLimit / 1_000;
+ 
+-            var acceptableVariance = (actualIntervalLimit * 1.0);
++            var acceptableVariance = (actualIntervalLimit * 1.15);
+             var upperLimit = expectedLimit + acceptableVariance;
+             var lowerLimit = expectedLimit - acceptableVariance;
+ ",Is it possible that test failures here are real and that we should improve the rate limiting logic? Or are we ok with rate limits to be exceeded by 15%?,Why did you change this?
+6656,"@@ -71,6 +71,8 @@ class ImageProvider extends FileProvider
+             throw new \LogicException(""The 'srcset' and 'picture' options must not be used simultaneously."");
+         }
+ 
++        $attrPrefix = isset($options['lazy']) && true === $options['lazy'] ? 'data-' : '';
++
+         if (MediaProviderInterface::FORMAT_REFERENCE === $format) {
+             $box = $media->getBox();
+         } else {",Shouldn't there be some kind of validation somewhere? IMO there should be an exception if `$options['lazy']` is not a boolean.,Why do we need this?
+6657,"@@ -1,5 +1,7 @@
+ // Copyright (c) Microsoft. All rights reserved.
+ 
++using Microsoft.VisualStudio.TestPlatform.ObjectModel.Logging;
++
+ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer
+ {
+     using System;",nit: please move it inside namespace.,Why is this needed?
+6658,"@@ -15,7 +15,7 @@ module Bolt
+           shell-command
+           tmpdir
+           tty
+-        ].freeze
++        ].concat(RUN_AS_OPTIONS).sort.freeze
+ 
+         DEFAULTS = {
+           'cleanup' => true",The inventory schema needs to be regenerated to include these options. Looks like the CI job didn't get triggered since the paths don't include `lib/bolt/transport/**`.  ,Why do we need to so
+6659,"@@ -0,0 +1,14 @@
++WELCOME_DIALOG_TEXT = (
++	""Welcome to NVDA  dialog  Welcome to NVDA!\n""
++	""Most commands for controlling NVDA require you to hold down the NVDA key while pressing other keys.\n""
++	""By default, the numpad Insert and main Insert keys may both be used as the NVDA key.\n""
++	""You can also configure NVDA to use the CapsLock as the NVDA key.\n""
++	""Press NVDA+n at any time to activate the NVDA menu.\n""
++	""From this menu, you can configure NVDA, get help and access other NVDA functions.\n""
++	""Options  grouping\n""
++	""Keyboard layout:  combo box  desktop  collapsed  Alt+k""
++)
++QUIT_DIALOG_TEXT = (
++	""Exit NVDA  dialog\n""
++	""What would you like to do?  combo box  Exit  collapsed  Alt+d""
++)","This might break if a user runs the system tests with a system language other than English, in which the user default language differs.",I don't think this i
+6660,"@@ -3,7 +3,7 @@ require 'rspec/expectations'
+ RSpec::Matchers.define :have_errors do |expected|
+ 
+   match do
+-    actual.body.match(/Error/)
++    actual.body.match(/Error\:/)
+   end
+ 
+   failure_message do |actual|","This was raising intermittent errors, since Lorem ipsum contains the word ""error""",Why is this change needed?
+6661,"@@ -214,6 +214,7 @@ bool RTPSDomain::removeRTPSParticipant(
+ {
+     if (p != nullptr)
+     {
++        assert((p->mp_impl != nullptr) && ""This participant has been previously invalidated"");
+         p->mp_impl->disable();
+ 
+         std::unique_lock<std::mutex> lock(m_mutex);",Shouldn't we then add `mp_impl = nullptr` to the destructor of `RTPSParticipant`,if (p->mp_impl != nullptr)
+6662,"@@ -5,10 +5,10 @@ import pytest
+ from mmdet.datasets import DATASETS
+ 
+ 
+-@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock)
+-@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock)
++@patch('mmdet.datasets.CocoDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.CustomDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.XMLDataset.load_annotations', MagicMock())
++@patch('mmdet.datasets.CityscapesDataset.load_annotations', MagicMock())
+ @patch('mmdet.datasets.CocoDataset._filter_imgs', MagicMock)
+ @patch('mmdet.datasets.CustomDataset._filter_imgs', MagicMock)
+ @patch('mmdet.datasets.XMLDataset._filter_imgs', MagicMock)",Are the additional brackets necessary?,E302 expected 2 blank line
+6663,"@@ -148,7 +148,7 @@ public class Invoker implements InvocationHandler {
+     }
+ 
+     PojoConsumerOperationMeta pojoConsumerOperationMeta = consumerMeta
+-        .findOperationMeta(MethodUtils.findSwaggerMethodName(method));
++        .findOperationMeta(MethodUtils.findSwaggerMethodName(method), consumerIntf);
+     if (pojoConsumerOperationMeta == null) {
+       throw new IllegalStateException(
+           String.format(",consumerMeta only belongs to this invoker instance only relate to this one consumerIntf class seems no need to build a complex key?,I think this should be `co
+6664,"@@ -35,6 +35,11 @@ RSpec.describe RSpec::Core::Formatters::BaseTextFormatter do
+       expect(formatter_output.string).to match(""1 example, 1 failure, 1 pending"")
+     end
+ 
++    it ""with 1s outputs singular (only pending)"" do
++      send_notification :dump_summary, summary_notification(1, examples(1), examples(0), examples(1), 0)
++      expect(formatter_output.string).to match(""1 example, 0 failures, 1 pending"")
++    end
++
+     it ""with 2s outputs pluralized (including pending)"" do
+       send_notification :dump_summary, summary_notification(2, examples(2), examples(2), examples(2), 0)
+       expect(formatter_output.string).to match(""2 examples, 2 failures, 2 pending"")","this one is unrelated right? (Don't mind including it, just making sure I understand)","I think it would be good to have a test for `summary_notification(2, examples(2), examples(2), examples(2), 0)`"
+6665,"@@ -0,0 +1,14 @@
++_base_ = [
++    '../_base_/datasets/coco_instance.py', '../_base_/models/solo_r50_fpn.py',
++    '../_base_/schedules/schedule_1x.py', '../_base_/default_runtime.py'
++]
++# optimizer
++optimizer = dict(type='SGD', lr=0.01, momentum=0.9, weight_decay=0.0001)
++optimizer_config = dict(grad_clip=dict(max_norm=35, norm_type=2))
++# learning policy
++lr_config = dict(
++    policy='step',
++    warmup='linear',
++    warmup_iters=500,
++    warmup_ratio=1.0 / 3,
++    step=[9, 11])","8, 11 actually achieves similar performance, we should use our default config if [9,11] is unnecessary.",why do we need this?
+6666,"@@ -0,0 +1,12 @@
++package yarpc
++
++import (
++	""time""
++
++	""github.com/yarpc/yarpc-go/encoding/raw""
++)
++
++func SleepRaw(reqMeta *raw.ReqMeta, body []byte) ([]byte, *raw.ResMeta, error) {
++	time.Sleep(1 * time.Second)
++	return nil, nil, nil
++}",For a separate PR: Can we make this a JSON/Thrift procedure instead? It could accept the amount of time it needs to sleep as an argument.,Why do we need this?
+6667,"@@ -92,6 +92,7 @@ class Tab(browsertab.AbstractTab):
+         pass
+ 
+ 
++
+ @pytest.mark.xfail(run=False, reason='Causes segfaults, see #1638')
+ def test_tab(qtbot, view, config_stub, tab_registry, mode_manager):
+     tab_w = Tab(win_id=0, mode_manager=mode_manager)",Please remove this blank line.,Why is this needed?
+6668,"@@ -26,6 +26,7 @@ use Front\Front;
+ use Propel\Runtime\Exception\PropelException;
+ use Symfony\Component\HttpFoundation\Cookie;
+ use Symfony\Component\HttpFoundation\Request;
++use Thelia\Cart\CartTrait;
+ use Thelia\Controller\Front\BaseFrontController;
+ use Thelia\Core\Event\Cart\CartEvent;
+ use Thelia\Core\Event\Order\OrderEvent;",the cartTrait is not used anymore,Please sort imports by length.
+6669,"@@ -82,6 +82,7 @@ namespace OpenTelemetry.Trace.Configuration
+         /// Creates tracerSdk factory.
+         /// </summary>
+         /// <param name=""configure"">Function that configures tracerSdk factory.</param>
++        /// <returns><see cref=""TracerFactory""/>.</returns>
+         public static TracerFactory Create(Action<TracerBuilder> configure)
+         {
+             if (configure == null)",Cn you please make the message more human friendly.,nit: missing period at the end
+6670,"@@ -23,10 +23,12 @@ import os
+ import sys
+ import html
+ import netrc
+-from typing import Callable, Mapping, List, Optional
+ import tempfile
++from enum import Enum, unique
++from typing import Callable, Mapping, List, Optional
+ 
+ from PyQt5.QtCore import QUrl
++from PyQt5.QtWebEngineWidgets import QWebEnginePage
+ 
+ from qutebrowser.config import config
+ from qutebrowser.utils import (usertypes, message, log, objreg, jinja, utils,","Please do `import enum` instead, then use `enum.Enum` and `enum.unique` - we do this everywhere to see where things are coming from, except for Qt (everything begins with a `Q` anyways) and typing (mostly used in type annotations, so it's clear without the namespacing).",Why is this import needed?
+6671,"@@ -46,7 +46,6 @@
+ 
+ #include ""codec.h""
+ 
+-#define ENCFAIL (uint)0 /* a value that is not a valid instruction */
+ 
+ /* Decode immediate argument of bitwise operations.
+  * Returns zero if the encoding is invalid.",Isn't ENCFAIL used in codec.c below? Wouldn't this make it no longer compile?,Why was this removed?
+6672,"@@ -73,6 +73,10 @@ public abstract class StaticLangXCombinedSurfaceView implements ViewModel {
+ 
+   public abstract List<PageStreamingDescriptorClassView> pageStreamingDescriptorClasses();
+ 
++  public boolean getTrue() {
++    return true;
++  }
++
+   public static Builder newBuilder() {
+     return new AutoValue_StaticLangXCombinedSurfaceView.Builder();
+   }",this looks very weird,Why is this needed?
+6673,"@@ -14,7 +14,9 @@ import java.util.logging.LogRecord;
+  * Log to the console using a basic formatter.
+  *
+  * @author Wouter Zelle
++ * @deprecated This class will be complety removed in 7.0.0
+  */
++@Deprecated
+ public class ConsoleLogHandler extends Handler {
+ 
+     private static final Formatter FORMATTER = new PmdLogFormatter();","So, the culprit was actually this class ""ConsoleLogHandler"", correct? Because it simply wrote to stdout...",I don't think we ne
+6674,"@@ -272,7 +272,7 @@ namespace NLog.Config
+         public override LoggingConfiguration Reload()
+         {
+             if (!string.IsNullOrEmpty(_originalFileName))
+-                return new XmlLoggingConfiguration(_originalFileName, LogFactory);
++                return LogFactory.CreateConfig(_originalFileName); //TODO NLog 5: should call LoadConfiguration which set LogFactory.Configuration
+             else
+                 return base.Reload();
+         }",Still curious why you need to modify this method? Why not in the future just have a method called `LogFactory.ReloadConfiguration()` instead of the config assigning itself?,Is this TODO still 
+6675,"@@ -110,8 +110,8 @@ class Test(base.Base):
+           'Molecule run (always).'))
+ def test(ctx, scenario_name, driver_name, __all, destroy):  # pragma: no cover
+     """"""
+-    Test (lint, destroy, dependency, syntax, create, prepare, converge,
+-          idempotence, side_effect, verify, destroy).
++    Test (lint, cleanup, destroy, dependency, syntax, create, prepare,
++          converge, idempotence, side_effect, verify, cleanup, destroy).
+     """"""
+ 
+     args = ctx.obj.get('args')","Should this say ""lint, cleanup, destroy, dependency, syntax, create, prepare, converge, idempotence, side_effect, verify, cleanup, destroy""?",I don't think clean
+6676,"@@ -23,12 +23,11 @@ func sendHeaders(ctx context.Context, headers p2p.Headers, stream *stream) error
+ 	defer cancel()
+ 
+ 	if err := w.WriteMsgWithContext(ctx, headersP2PToPB(headers)); err != nil {
+-		return fmt.Errorf(""write message: %w"", err)
++		return fmt.Errorf(""send write message: %w"", err)
+ 	}
+-
+ 	h := new(pb.Headers)
+ 	if err := r.ReadMsgWithContext(ctx, h); err != nil {
+-		return fmt.Errorf(""read message: %w"", err)
++		return fmt.Errorf(""send read message: %w"", err)
+ 	}
+ 
+ 	stream.headers = headersPBToP2P(h)",I am not sure why these log messages are changed.,Why do we need this change?
+6677,"@@ -5,7 +5,10 @@ package runtime
+ // Interfaces are represented as a pair of {typecode, value}, where value can be
+ // anything (including non-pointers).
+ 
+-import ""unsafe""
++import (
++	""reflect""
++	""unsafe""
++)
+ 
+ type _interface struct {
+ 	typecode uintptr",This panic is incorrect - this is a full implementation of a slice equality check. This should be something more like `type x is not comparable` maybe?,Why is this needed?
+6678,"@@ -271,7 +271,7 @@ add_extra_option(opt_info_t *opt_info, const TCHAR *opt)
+             return DR_FAILURE;
+         }
+ 
+-        len = MIN(DR_MAX_OPTIONS_LENGTH - 1, _tcslen(opt));
++        len = _dr_nlen(opt, DR_MAX_OPTIONS_LENGTH);
+         opt_info->extra_opts[idx] =
+             malloc((len + 1) * sizeof(opt_info->extra_opts[idx][0]));
+         _tcsncpy(opt_info->extra_opts[idx], opt, len);",See below: let's use the existing convention _tcsnlen.,Shouldn't this be `DR_MAX_O
+6679,"@@ -6,10 +6,6 @@ describe Step do
+ 
+   describe ""Validations"" do
+     it { should validate_presence_of(:proposal) }
+-    it do
+-      create(:approval_step) # needed for spec, see https://github.com/thoughtbot/shoulda-matchers/issues/194
+-      should validate_uniqueness_of(:user_id).scoped_to(:proposal_id)
+-    end
+   end
+ 
+   let(:approval) { create(:approval_step) }",Why don't we need this any more?,Why was this test removed?
+6680,"@@ -0,0 +1,14 @@
++_base_ = ['./sparse_rcnn_r50_fpn_mstrain_480-800_3x_coco.py']
++
++model = dict(
++    pretrained='torchvision://resnet101',
++    backbone=dict(
++        type='ResNet',
++        depth=101,
++        num_stages=4,
++        out_indices=(0, 1, 2, 3),
++        frozen_stages=1,
++        norm_cfg=dict(type='BN', requires_grad=True),
++        norm_eval=True,
++        style='pytorch'),
++)",clean unnecessary comma,Why do we need this?
+6681,"@@ -75,11 +75,14 @@ export function createVNode(type, props, key, ref, original) {
+ 		// a _nextDom that has been set to `null`
+ 		_nextDom: undefined,
+ 		_component: null,
+-		constructor: undefined,
+-		_original: original
++		constructor: undefined
+ 	};
+ 
+-	if (original == null) vnode._original = vnode;
++	Object.defineProperty(vnode, '_original', {
++		value: original || vnode,
++		enumerable: false,
++		writable: true
++	});
+ 	if (options.vnode) options.vnode(vnode);
+ 
+ 	return vnode;",This is the default value for enumerable.,Why is this needed?
+6682,"@@ -61,8 +61,8 @@ std::string chemicalReactionTemplatesToString(
+     bool toSmiles, bool canonical) {
+   std::string res = """";
+   std::vector<std::string> vfragsmi;
+-  RDKit::MOL_SPTR_VECT::const_iterator begin = getStartIterator(rxn, type);
+-  RDKit::MOL_SPTR_VECT::const_iterator end = getEndIterator(rxn, type);
++  auto begin = getStartIterator(rxn, type);
++  auto end = getEndIterator(rxn, type);
+   for (; begin != end; ++begin) {
+     vfragsmi.push_back(molToString(**begin, toSmiles));
+   }","Just above, you have `const auto` for a `RDKit::MOL_SPTR_VECT::const_iterator`, here it is only `auto`. Why is this?",Why did you change t
+6683,"@@ -186,9 +186,10 @@ bool Actions::registerEvent(Event_ptr event, const pugi::xml_node& node)
+ 	return false;
+ }
+ 
+-bool Actions::registerLuaEvent(Event* event)
++bool Actions::registerLuaEvent(Action* event)
+ {
+-	Action_ptr action{ static_cast<Action*>(event) }; //event is guaranteed to be an Action
++	Event_ptr ptr = Event_ptr(event);
++	Action_ptr action{ static_cast<Action*>(ptr.release()) }; //event is guaranteed to be an Action
+ 	if (action->getItemIdRange().size() > 0) {
+ 		if (action->getItemIdRange().size() == 1) {
+ 			auto result = useItemMap.emplace(action->getItemIdRange().at(0), std::move(*action));","@djarek just a quick question, wouldn't be `ptr.reset()` here better as it does not memory leak if we do not call delete on the raw pointer aswell? it maybe makes sense to use `ptr.release` if the event is guaranteed to be loaded again but on a reload it would memory leak if for example I removed that script from my files before reloading or not?",Why do we need this 
+6684,"@@ -218,8 +218,12 @@ func (cfg *Config) GetString(key string) string {
+ 
+ // GetStringSlice returns config value as []string.
+ func (cfg *Config) GetStringSlice(key string) []string {
+-	value := cfg.Get(key).(*cli.StringSlice)
+-	return cast.ToStringSlice([]string(*value))
++	switch cfg.Get(key).(type) {
++	case *cli.StringSlice:
++		return cast.ToStringSlice([]string(*cfg.Get(key).(*cli.StringSlice)))
++	default:
++		return cast.ToStringSlice(cfg.Get(key))
++	}
+ }
+ 
+ // ParseBoolFlag parses a cli.BoolFlag from command's context and","Why to `Get()` value twice, while u have it 2 lines before",Why do we need to cast here?
+6685,"@@ -310,10 +310,17 @@ class ServiceProvider extends ModuleServiceProvider
+         $this->registerConsoleCommand('october.update', 'System\Console\OctoberUpdate');
+         $this->registerConsoleCommand('october.util', 'System\Console\OctoberUtil');
+         $this->registerConsoleCommand('october.mirror', 'System\Console\OctoberMirror');
++        $this->registerConsoleCommand('october.mirror', 'System\Console\OctoberFresh');
++
+         $this->registerConsoleCommand('plugin.install', 'System\Console\PluginInstall');
+         $this->registerConsoleCommand('plugin.remove', 'System\Console\PluginRemove');
+         $this->registerConsoleCommand('plugin.refresh', 'System\Console\PluginRefresh');
+ 
++        $this->registerConsoleCommand('theme.use', 'System\Console\ThemeUse');
++        $this->registerConsoleCommand('theme.list', 'System\Console\ThemeList');
++        $this->registerConsoleCommand('theme.install', 'System\Console\ThemeInstall');
++        $this->registerConsoleCommand('theme.delete', 'System\Console\ThemeDelete');
++
+         /*
+          * Register the sidebar for the System main menu
+          */","There is a typo here, this needs to state `october.fresh`",Should be `System\Console\Th
+6686,"@@ -139,6 +139,18 @@ public class TestHadoopTables {
+     Assert.assertEquals(""Transform must match"", transform, sortOrder.fields().get(0).transform());
+   }
+ 
++  @Test
++  public void testTableName() {
++    PartitionSpec spec = PartitionSpec.builderFor(SCHEMA)
++        .bucket(""data"", 16)
++        .build();
++    String location = tableDir.toURI().toString();
++    TABLES.create(SCHEMA, spec, location);
++
++    Table table = TABLES.load(location);
++    Assert.assertEquals(""Table name must match"", location, table.name());
++  }
++
+   private static void createDummyTable(File tableDir, File dataDir) throws IOException {
+     Table table = TABLES.create(SCHEMA, tableDir.toURI().toString());
+     AppendFiles append = table.newAppend();",Metadata tables loaded through `HadoopTables` will have their names as location.type (which is weird as we normally use location#type). I am not sure whether it is a big deal or not.,Why do we need this test?
+6687,"@@ -343,7 +343,7 @@ Blockly.VerticalFlyout.prototype.wheel_ = function(e) {
+       delta *= 10;
+     }
+     var metrics = this.getMetrics_();
+-    var pos = metrics.viewTop + delta;
++    var pos = -this.workspace_.scrollY + delta;
+     var limit = metrics.contentHeight - metrics.viewHeight;
+     pos = Math.min(pos, limit);
+     pos = Math.max(pos, 0);",Can you explain why you went from a positive value (metrics.viewTop) to a negative value?,Why is this change necessary
+6688,"@@ -91,4 +91,11 @@ public interface ExternalTaskRestService {
+   @Produces(MediaType.APPLICATION_JSON)
+   BatchDto setRetriesAsync(SetRetriesForExternalTasksDto retriesDto);
+ 
++  @GET
++  @Path(""/topic-names"")
++  @Produces(MediaType.APPLICATION_JSON)
++  List<String> getTopicNames(@QueryParam(""withLockedTasks"") boolean withLockedTasks,
++      @QueryParam(""withUnlockedTasks"") boolean withUnlockedTasks,
++      @QueryParam(""withRetriesLeft"") boolean withRetriesLeft);
++
+ }",Let's use a dedicated DTO instead of `List<String>` to remain consistent with all other existing REST API endpoints: * Introduce a new DTO class (e. g. `ExternalTaskTopicNameDto`) located under `org.camunda.bpm.engine.rest.dto.externaltask` * The class should have the attribute `topicName` of type `String` * Introduce a getter & setter for the attribute * Convert the list of strings to a list of `ExternalTaskTopicNameDto`s * Change the method signature to return `List<ExternalTaskTopicNameDto>`,I think it would be better to use `GET /topic-names` instead of `/topic-names`
+6689,"@@ -42,6 +42,14 @@ public interface RepositoryManager {
+      */
+     ScriptDTO getScript(List<String> path);
+ 
++    /**
++     * This method returns the {@link org.phoenicis.repository.dto.ScriptDTO} with the given ID
++     *
++     * @param id The script ID
++     * @return The found ScriptDTO
++     */
++    ScriptDTO getScript(String id);
++
+     /**
+      * This method moves the repository, belonging to the given repository url, to the given index.
+      * This is done by swapping the current content at the given index with old index of the given repository url",Do you plan to remove the `ScriptDTO getScript(List<String> path);` method long-term?,Why do we need this method?
+6690,"@@ -134,12 +134,14 @@
+             },
+             types: function() {
+                 var self = this;
+-                var result = this.allTypes.filter(function(item) {
++                if (this.enabledTypes && !this.enabledTypes.length) {
++                    return this.allTypes;
++                }
++                return this.allTypes.filter(function(item) {
+                     return self.enabledTypes.some(function(enabledItem) {
+                         return enabledItem === item.value;
+                     });
+                 });
+-                return result;
+             }
+         }
+     });","@itsiprikshit I used a custom v-model to app count component because the sourceapps component was not reacting to user app count selection, e.g. whenever user changed app count selection, the source apps selection multiplicity remained the same. As a matter of fact, user was able to select one application only. Please let me know if you have any thoughts on this.",`this.enabledTypes && this.enabledTypes.length`
+6691,"@@ -4,6 +4,7 @@ from mmcv.cnn import ConvModule, kaiming_init
+ from mmcv.runner import auto_fp16, force_fp32
+ 
+ from mmdet.models.builder import HEADS
++from mmdet.models.utils import ResLayer, SimplifiedBasicBlock
+ 
+ 
+ @HEADS.register_module()","Similarly, we think we may keep `fused_semantic_head.py` unchanged. Then, we could add a new mask head for the desired function.",from mmdet.models.utils import SimplifiedBasicBlock
+6692,"@@ -175,4 +175,10 @@ public class PhpModelTypeNameConverter implements ModelTypeNameConverter {
+   private static String getPhpPackage(ProtoFile file) {
+     return file.getProto().getPackage().replaceAll(""\\."", ""\\\\"");
+   }
++
++  @Override
++  public TypeName getTypeNameForTypedResourceName(
++      ProtoElement elem, String typedResourceShortName) {
++    throw new UnsupportedOperationException(""getTypeNameForTypedResourceName not supported by PHP"");
++  }
+ }",Why implement this? It duplicates the value in FeatureConfig.,Why do we need this method?
+6693,"@@ -159,8 +159,14 @@ public class SparkScanBuilder implements ScanBuilder, SupportsPushDownFilters, S
+ 
+   @Override
+   public Scan build() {
+-    return new SparkBatchQueryScan(
+-        spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    // TODO: understand how to differentiate that this is a spark streaming microbatch scan.
++    if (false) {
++      return new SparkBatchQueryScan(
++              spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    } else {
++      return new SparkMicroBatchStreamScan(
++              spark, table, caseSensitive, schemaWithMetadataColumns(), filterExpressions, options);
++    }
+   }
+ 
+   public Scan buildMergeScan() {","@aokolnychyi / @RussellSpitzer / @holdenk Spark3 gives ScanBuilder - abstraction - to define all types of Scans (Batch, MicroBatch & Continuous). But, the current implementation / class modelling - has SparkBatchScan as the Scan implementation. Looking at some of the concerns of BatchScan - all the way from the State maintenance of a single SnapshotId to read from, the asOfTimeStamp & features like VectorizedReads - all of these don't seem relevant to Streaming Scans. So, I feel that we need to divide out Streaming Scans into a different class. Does this thought process - make sense? If we go by this route - do you folks know - how to pass different Scan objects to Spark based on Batch vs Streaming?",nit: `if (false)` -> `if (!
+6694,"@@ -56,10 +56,7 @@ public final class ClaimTypeConverter implements Converter<Map<String, Object>,
+ 		this.claimTypeConverters.forEach((claimName, typeConverter) -> {
+ 			if (claims.containsKey(claimName)) {
+ 				Object claim = claims.get(claimName);
+-				Object mappedClaim = typeConverter.convert(claim);
+-				if (mappedClaim != null) {
+-					result.put(claimName, mappedClaim);
+-				}
++				result.put(claimName, typeConverter.convert(claim));
+ 			}
+ 		});
+ 		return result;",Will you please update these files to use a copyright end date of 2021?,Why was this removed?
+6695,"@@ -10,6 +10,17 @@ if (window.__AXE_EXTENSION__) {
+ /*eslint indent: 0*/
+ var testUtils = {};
+ 
++var fixture = document.createElement('div');
++fixture.setAttribute('id', 'fixture');
++document.body.insertBefore(fixture, document.body.firstChild);
++
++/*eslint no-unused-vars: 0*/
++var checks, commons;
++var originalChecks = (checks = axe._audit.checks);
++var originalAudit = axe._audit;
++var originalRules = axe._audit.rules;
++var originalCommons = (commons = axe.commons);
++
+ /**
+  * Create a check context for mocking/resetting data and relatedNodes in tests
+  *",Adding fixture to the body as we don't have the `runner.tmpl` anymore,I don't think you need the 
+6696,"@@ -6,11 +6,15 @@ import (
+ 
+ 	log ""github.com/sirupsen/logrus""
+ 
++	librarygocontroller ""github.com/openshift/library-go/pkg/controller""
++
+ 	corev1 ""k8s.io/api/core/v1""
+ 	apierrors ""k8s.io/apimachinery/pkg/api/errors""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/client-go/util/flowcontrol""
+ 	""k8s.io/client-go/util/workqueue""
++	""k8s.io/utils/pointer""
+ 
+ 	""sigs.k8s.io/controller-runtime/pkg/client""
+ 	""sigs.k8s.io/controller-runtime/pkg/controller""",nit: just for consistency we can move this import block down. Right above openshift/hive imports,nit: remove empty line
+6697,"@@ -57,7 +57,7 @@ class MessageLocationTuple(NamedTuple):
+ 
+ 
+ class ManagedMessage(NamedTuple):
+-    """"""Tuple with information ahout a managed message of the linter""""""
++    """"""Tuple with information about a managed message of the linter""""""
+ 
+     name: Optional[str]
+     msgid: str",Perhaps clean up the commit history and don't squash?,I think this should be
+6698,"@@ -162,7 +162,7 @@ final class ScribeInboundHandler extends ChannelInboundHandlerAdapter {
+           buf.release();
+         }
+       } else {
+-        returned.writeBytes(content.array(), content.offset(), content.length());
++        returned.writeBytes(content.array(), 0, content.length());
+       }
+ 
+       if (responseIndex == previouslySentResponseIndex + 1) {","Just `writeBytes(content.array())` Back to my original, somewhat broken version ;)",Shouldn't this be `con
+6699,"@@ -95,6 +95,16 @@ func TestCrossdock(t *testing.T) {
+ 				""transport"": []string{""http"", ""tchannel""},
+ 			},
+ 		},
++		{
++			name: ""ctxpropagation"",
++			axes: axes{
++				""transport"": []string{""http"", ""tchannel""},
++			},
++			params: params{
++				""ctxserver"": ""127.0.0.1"",
++				""ctxclient"": ""127.0.0.1"",
++			},
++		},
+ 	}
+ 
+ 	for _, bb := range behaviors {",I couldn't tell from reading the test - do we every criss-cross transports in the same test? I want to make sure we aren't breaking the chain...,I think this should be
+6700,"@@ -10,11 +10,11 @@ import (
+ 	""context""
+ 	""crypto/sha256""
+ 	""encoding/hex""
++	""github.com/facebookgo/clock""
+ 	""math/big""
+ 	""strings""
+ 	""testing""
+ 
+-	""github.com/facebookgo/clock""
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/require""
+ 	""golang.org/x/crypto/blake2b""",File is not `goimports`-ed,nit: remove empty line
+6701,"@@ -227,9 +227,6 @@ func invokeErrorToYARPCError(err error, responseMD metadata.MD) error {
+ 
+ // CallStream implements transport.StreamOutbound#CallStream.
+ func (o *Outbound) CallStream(ctx context.Context, request *transport.StreamRequest) (*transport.ClientStream, error) {
+-	if _, ok := ctx.Deadline(); !ok {
+-		return nil, yarpcerrors.InvalidArgumentErrorf(""stream requests require a connection establishment timeout on the passed in context"")
+-	}
+ 	if err := o.once.WaitUntilRunning(ctx); err != nil {
+ 		return nil, err
+ 	}","do we want to still validate that the context had a nonzero TTL? i suppose it's fine to let clients determine whether or not their streams will timeout (though we still don't have the means to cancel them from the server other than EOF), and they can still cancel their own contexts - so maybe not a huge deal, but thought it was worth bringing up.",Why was this removed?
+6702,"@@ -72,4 +72,9 @@ public class JavaNameFormatter implements NameFormatter {
+   public String classFileNameBase(Name name) {
+     return name.toOriginal();
+   }
++
++  @Override
++  public String humanName(Name name) {
++    throw new UnsupportedOperationException();
++  }
+ }",Go ahead and provide the same implementation for all of the languages - I'm not sure there's a reason for it to be different.,Why is this needed?
+6703,"@@ -253,6 +253,15 @@ class TestApp(tornado.testing.AsyncHTTPTestCase):
+         assert self.put_json(""/settings"", {""anticache"": True}).code == 200
+         assert self.put_json(""/settings"", {""wtf"": True}).code == 400
+ 
++    def test_options(self):
++        j = json(self.fetch(""/options""))
++        assert type(j) == list
++        assert type(j[0]) == dict
++
++    def test_option_update(self):
++        assert self.put_json(""/options"", {""anticache"": True}).code == 200
++        assert self.put_json(""/options"", {""wtf"": True}).code == 400
++
+     def test_err(self):
+         with mock.patch(""mitmproxy.tools.web.app.IndexHandler.get"") as f:
+             f.side_effect = RuntimeError","We should also test type confusion here (e.g. `{""anticache"": ""foo""}`)",I think this should be
+6704,"@@ -236,6 +236,10 @@ MESSAGE
+             end
+ 
+             sh.cmd 'unformatted=`dartfmt -n .`'
++            # If `dartfmt` fails for some reason
++            sh.if '$? -ne 0' do
++              sh.failure """"
++            end
+             sh.if '! -z ""$unformatted""' do
+               sh.echo ""Files are unformatted:"", ansi: :red
+               sh.echo ""$unformatted""",I'd love to trim the content of `unformatted` too. Any ideas?,"I think this should be `sh.failure ""dartfmt failed for some reason""`"
+6705,"@@ -17,6 +17,7 @@
+ """"""
+ Utilities to deal with types. This is mostly focused on python3.
+ """"""
++
+ import typing
+ from inspect import getfullargspec
+ from functools import wraps",can you remove this unrelated change?,Why this change?
+6706,"@@ -145,6 +145,17 @@ class MainWindow(QWidget):
+         _private: Whether the window is in private browsing mode.
+     """"""
+ 
++    # Application wide stylesheets
++    STYLESHEET = """"""
++        QLabel#hint {
++            background-color: {{ conf.colors.hints.bg }};
++            color: {{ conf.colors.hints.fg }};
++            font: {{ conf.fonts.hints }};
++            border: {{ conf.hints.border }};
++            padding-left: -3px;
++        }
++    """"""
++
+     def __init__(self, *, private, geometry=None, parent=None):
+         """"""Create a new main window.
+ ",Would using `HintLabel` here instead (without `setObjectName`) work?,Why is this needed?
+6707,"@@ -51,7 +51,7 @@ type solver interface {
+ // It is useful for mocking out a given provider since an alternate set of
+ // constructors may be set.
+ type dnsProviderConstructors struct {
+-	cloudDNS   func(project string, serviceAccount []byte, dns01Nameservers []string) (*clouddns.DNSProvider, error)
++	cloudDNS   func(project string, serviceAccountFile string, serviceAccount []byte, dns01Nameservers []string, ambient bool) (*clouddns.DNSProvider, error)
+ 	cloudFlare func(email, apikey string, dns01Nameservers []string) (*cloudflare.DNSProvider, error)
+ 	route53    func(accessKey, secretKey, hostedZoneID, region string, ambient bool, dns01Nameservers []string) (*route53.DNSProvider, error)
+ 	azureDNS   func(clientID, clientSecret, subscriptionID, tenentID, resourceGroupName, hostedZoneName string, dns01Nameservers []string) (*azuredns.DNSProvider, error)","From what I can tell, the `serviceAccountFile` is never set to anything except """"? It'd be best to remove this altogether, so we don't mislead future developers  ",Why do we need the ambient bool here?
+6708,"@@ -18,11 +18,6 @@
+             </li>
+           </ul>
+         </nav>
+-        <nav>
+-          <ul>
+-            <li class=""account""><%= link_to 'Sign in', sign_in_path %></li>
+-          </ul>
+-        </nav>
+       </div>
+     </section>
+ ",Why do we remove the Sign in link?,Why was this removed?
+6709,"@@ -186,11 +186,6 @@ public class FeedItemMenuHandler {
+                     GpodnetPreferences.enqueueEpisodeAction(actionNew);
+                 }
+                 break;
+-            case R.id.move_to_top_item:
+-                DBWriter.moveQueueItemToTop(selectedItem.getId(), true);
+-                return true;
+-            case R.id.move_to_bottom_item:
+-                DBWriter.moveQueueItemToBottom(selectedItem.getId(), true);
+             case R.id.add_to_queue_item:
+                 DBWriter.addQueueItem(context, selectedItem);
+                 break;","holy crap, were we really missing a 'break' statement here?",Why is this being rem
+6710,"@@ -28,6 +28,10 @@ type logMaker interface {
+ 	MakeLogger(module string) logger.Logger
+ }
+ 
++type debugForcedLogMaker interface {
++	MakeLoggerForceEnableDebug(module string) logger.Logger
++}
++
+ type blockCacher interface {
+ 	BlockCache() BlockCache
+ }","This doesn't seem to be used anywhere, probably doesn't need to be a new interface.",Why do we need this i
+6711,"@@ -363,7 +363,9 @@ func (f *FS) Statfs(ctx context.Context, req *fuse.StatfsRequest, resp *fuse.Sta
+ 	usageBytes, limitBytes, err := f.quotaUsage.Get(ctx, quotaUsageStaleTolerance)
+ 	if err != nil {
+ 		f.log.CDebugf(ctx, ""Getting quota usage error: %v"", err)
+-		return err
++		// Ignore the error here so Statfs() can succeeded. Otherwise reading a
++		// public TLF while logged out fails on macOS.
++		return nil
+ 	}
+ 
+ 	total := getNumBlocksFromSize(uint64(limitBytes))","This is a good start, but what do you think about just using `libkbfs.GetCurrentSessionIfPossible()` to avoid calling this altogether if there's no session? That way we can avoid continuous RTTs to the server when logged out.",I don't think we want
+6712,"@@ -0,0 +1,18 @@
++<div class=""dropdown edit_menu"">
++  <%= link_to link_text, edit_path,
++              :id => 'editanchor',
++              :class => ""geolink tab #{link_class}"" %>
++  <a class='dropdown-toggle' data-toggle='dropdown' href='#'>
++    <b class=""caret""></b>
++  </a>
++  <ul class='dropdown-menu' role='menu' aria-labelledby='dLabel'>
++    <% Editors::RECOMMENDED_EDITORS.each do |editor| %>
++      <li>
++        <%= link_to t('layouts.edit_with', :editor => t(""editor.#{editor}.description"")),
++                    edit_path(:editor => editor),
++                    :data => { :editor => editor },
++                    :class => ""geolink #{link_class}"" %>
++      </li>
++    <% end %>
++  </ul>
++</div>","This `aria-labelledby` stuff is all new to me, but my reading of the spec is that the value should be a list of element id values, and `dLabel` doesn't seem to be the id of any element?",I think this should be `edit_path(:editor => editor)`
+6713,"@@ -6,16 +6,16 @@ module Bolt
+       class Step
+         class Upload < Step
+           def self.allowed_keys
+-            super + Set['source', 'destination']
++            super + Set['source', 'destination', 'upload']
+           end
+ 
+           def self.required_keys
+-            Set['destination', 'source', 'targets']
++            Set['upload', 'destination', 'targets']
+           end
+ 
+           def initialize(step_body)
+             super
+-            @source = step_body['source']
++            @source = step_body['upload'] || step_body['source']
+             @destination = step_body['destination']
+           end
+ ",Does this fail validation if you now use the `upload` key instead of `source`?,Why do we need this change?
+6714,"@@ -733,7 +733,7 @@ CmpStoredProc::ExecStatus CmpStoredProc::close(CmpSPDataObject&)
+ // Methods of CmpISPFuncs
+ // -----------------------------------------------------------------------
+ 
+-NAList<CmpISPFuncs::ProcFuncsStruct> CmpISPFuncs::procFuncsArray_(256);
++NAList<CmpISPFuncs::ProcFuncsStruct> CmpISPFuncs::procFuncsArray_(NULL,256);
+ 
+ CmpISPFuncs::CmpISPFuncs()
+ {",Can we use GetCliGlobals(false)->exCollHeap() here instead,Please add a space after the comma.
+6715,"@@ -17,7 +17,10 @@ namespace storage {
+ 
+ TEST(AddEdgesTest, SimpleTest) {
+     fs::TempDir rootPath(""/tmp/AddEdgesTest.XXXXXX"");
+-    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path());
++    constexpr int32_t partitions = 6;
++    std::unique_ptr<kvstore::KVStore> kv = TestUtils::initKV(rootPath.path(), partitions,
++        {0, network::NetworkUtils::getAvailablePort()});
++    TestUtils::waitUntilAllElected(kv.get(), 0, {0, 1, 2, 3, 4, 5}/*partitions*/);
+     auto schemaMan = TestUtils::mockSchemaMan();
+     auto indexMan = TestUtils::mockIndexMan();
+     auto* processor = AddEdgesProcessor::instance(kv.get(),",I suggest you move the waitUntilAllElected into init::KV() method.,Why do we need this change?
+6716,"@@ -28,6 +28,11 @@ namespace OpenTelemetry
+     public class BatchExportProcessor<T> : BaseExportProcessor<T>
+         where T : class
+     {
++        public const int DefaultMaxQueueLength = 2048;
++        public const int DefaultScheduledDelayMilliseconds = 5000;
++        public const int DefaultTimeoutMilliseconds = 30000;
++        public const int DefaultMaxBatchSize = 512;
++
+         private readonly CircularBuffer<T> circularBuffer;
+         private readonly int scheduledDelayMilliseconds;
+         private readonly int exporterTimeoutMilliseconds;",no need of pub;lic.,Why are these public?
+6717,"@@ -237,6 +237,10 @@ type ConsensusParams struct {
+ 
+ 	// max decimal precision for assets
+ 	MaxAssetDecimals uint32
++
++	// whether to use the old buggy Credential.lowestOutput function
++	// TODO(upgrade): Please remove as soon as the upgrade goes through
++	UseBuggyProposalLowestOutput bool
+ }
+ 
+ // Consensus tracks the protocol-level settings for different versions of the",Do you think we can name this variable in a less ...negative.. language ? maybe `ProposalTieBreakerEqualizer`,I'm not sure if this 
+6718,"@@ -48,7 +48,7 @@ class PartitionKey implements StructLike {
+   private final Accessor<InternalRow>[] accessors;
+ 
+   @SuppressWarnings(""unchecked"")
+-  PartitionKey(PartitionSpec spec) {
++  PartitionKey(PartitionSpec spec, Schema inputSchema) {
+     this.spec = spec;
+ 
+     List<PartitionField> fields = spec.fields();",Can you add back these newlines? We try to avoid non-functional changes like this because they can cause commit conflicts.,nit: `inputSchema` ->
+6719,"@@ -755,7 +755,8 @@ const reducer = (state = defaultState, action) => {
+ 		case 'SEARCH_ADD':
+ 			{
+ 				newState = Object.assign({}, state);
+-				const searches = newState.searches.slice();
++				let searches = newState.searches.slice();
++        searches = searches.filter(s => s.title !== action.search.title);
+ 				searches.push(action.search);
+ 				newState.searches = searches;
+ 			}",Why not just `if (!searches.includes(action.search)) searches.push(action.search)`? That way you don't need to remove then add the element.,Why do we need to fil
+6720,"@@ -276,6 +276,17 @@ class Demo extends AbstractBase
+         return $a . $b . ""."" . $c;
+     }
+ 
++    /**
++     * Generate a fake call number prefix.
++     *
++     * @return string
++     */
++    protected function getFakeCallNumPrefix()
++    {
++        $codes = ""ABCDEFGHIJKLMNOPQRSTUVWXYZ"";
++        return substr(str_shuffle($codes), 1, rand(0, 3));
++    }
++
+     /**
+      * Get a random ID from the Solr index.
+      *","@demiankatz I'm not sure that this is very useful. I just did it to get started. If we had a small handful of predetermined prefixes that were randomly chosen, it would be easier to distinguish them from the rest of the call number. Would that be preferable?",I think this should be `getRandomCallNumPrefix`
+6721,"@@ -313,16 +313,6 @@ func createUpstreamRequest(rw http.ResponseWriter, r *http.Request) (*http.Reque
+ 	// Original incoming server request may be canceled by the
+ 	// user or by std lib(e.g. too many idle connections).
+ 	ctx, cancel := context.WithCancel(r.Context())
+-	if cn, ok := rw.(http.CloseNotifier); ok {
+-		notifyChan := cn.CloseNotify()
+-		go func() {
+-			select {
+-			case <-notifyChan:
+-				cancel()
+-			case <-ctx.Done():
+-			}
+-		}()
+-	}
+ 
+ 	outreq := r.WithContext(ctx) // includes shallow copies of maps, but okay
+ ",Why is this deleted too?,Why was this removed?
+6722,"@@ -8,9 +8,9 @@ using System.Threading.Tasks;
+ 
+ namespace Datadog.Trace.Agent
+ {
+-    internal class ApiWebResponse : IApiResponse
++    internal class ApiWebResponse : IApiResponse, IDisposable
+     {
+-        private HttpWebResponse _response;
++        private readonly HttpWebResponse _response;
+ 
+         public ApiWebResponse(HttpWebResponse response)
+         {","Given that IApiResponse is already made disposable, this is not necessary.",Why do we need this?
+6723,"@@ -97,7 +97,10 @@ class ItemPricesOverlay extends Overlay
+ 		switch (action)
+ 		{
+ 			case ITEM_USE_ON_WIDGET:
+-				if (!menuEntry.getTarget().contains(""High Level Alchemy"") || !plugin.isShowAlchProfit()) return null;
++				if (!menuEntry.getTarget().contains(""High Level Alchemy"") || !plugin.isShowAlchProfit())
++				{
++					return null;
++				}
+ 			case WIDGET_DEFAULT:
+ 			case ITEM_USE:
+ 			case ITEM_FIRST_OPTION:",client.getSelectedSpellName() can be used for this,please remove this extra line
+6724,"@@ -14,6 +14,12 @@
+ 
+ """"""Common formatting methods.""""""
+ 
++# Filename patterns.
++VIOLATION_JSON_FMT = 'violations.{}.{}.{}.json'
++SCANNER_OUTPUT_CSV_FMT = 'scanner_output_base.{}.csv'
++FINDINGS_FILENAME = 'forseti_findings_{}.json'
++
++# Timestamps.
+ # Example: '2018-03-01T21:31:52'
+ TIMESTAMP_UTC_OFFSET = '%Y-%m-%dT%H:%M:%S%z'
+ ",Please alpha sort these filenames.,I think this should be `forseti_findings_{}.csv`
+6725,"@@ -147,17 +147,6 @@ func (p *Protocol) validateTransfer(_ context.Context, act action.Action) error
+ 	if tsf.TotalSize() > TransferSizeLimit {
+ 		return errors.Wrap(action.ErrActPool, ""oversized data"")
+ 	}
+-	// Reject transfer of negative amount
+-	if tsf.Amount().Sign() < 0 {
+-		return errors.Wrap(action.ErrBalance, ""negative value"")
+-	}
+-	// Reject transfer of negative gas price
+-	if tsf.GasPrice().Sign() < 0 {
+-		return errors.Wrap(action.ErrGasPrice, ""negative value"")
+-	}
+-	// check if recipient's address is valid
+-	if _, err := address.FromString(tsf.Recipient()); err != nil {
+-		return errors.Wrapf(err, ""error when validating recipient's address %s"", tsf.Recipient())
+-	}
+-	return nil
++
++	return tsf.SelfCheck()
+ }",is this already called by actPool.validate()?,Shouldn't this be `tsf.Recipient()`?
+6726,"@@ -707,6 +707,16 @@ void updateStereoBonds(RWMOL_SPTR product, const ROMol &reactant,
+ 
+       if (pStart->getTotalDegree() < 3 || pEnd->getTotalDegree() < 3) {
+         pBond->setStereo(Bond::BondStereo::STEREONONE);
++      } else {
++        // Ring bonds shouldn't be marked as STEREOANY
++
++        if (!product->getRingInfo()->isInitialized()) {
++          MolOps::findSSSR(*product);
++        }
++
++        if (product->getRingInfo()->numBondRings(pBond->getIdx()) > 0) {
++          pBond->setStereo(Bond::BondStereo::STEREONONE);
++        }
+       }
+ 
+       continue;","It is relatively cheap to tell whether a bond is a ring bond, we don't have to perform an SSSR.",Shouldn't this be `pStart->getTotalDegree() < 3 
+6727,"@@ -18,7 +18,7 @@ const (
+ 	nameFlag    = ""name""
+ 	svcFlag     = ""svc""
+ 	envFlag     = ""env""
+-	appTypeFlag = ""app-type""
++	svcTypeFlag = ""svc-type""
+ 	profileFlag = ""profile""
+ 	yesFlag     = ""yes""
+ 	jsonFlag    = ""json""",Maybe we should add flag aliases for service as well.,Why did you change this?
+6728,"@@ -31,10 +31,7 @@ type Block struct {
+ 	Ticket Ticket `json:""ticket""`
+ 
+ 	// ElectionProof is the vrf proof giving this block's miner authoring rights
+-	ElectionProof crypto.VRFPi
+-
+-	// EPoStInfo wraps all data for verifying this block's Election PoSt
+-	EPoStInfo EPoStInfo `json:""ePoStInfo""`
++	ElectionProof crypto.ElectionProof
+ 
+ 	// DrandEntries contain the verifiable oracle randomness used to elect
+ 	// this block's author leader","This LGTM but don't we need a winning PoSts field to fully implement the protocol? No need to add here as I'm working on this in another PR, but curious how we can interop with lotus blocks without post proofs.",Why is this removed?
+6729,"@@ -12,3 +12,10 @@ import ""github.com/iotexproject/iotex-core/blockchain/block""
+ type BlockCreationSubscriber interface {
+ 	ReceiveBlock(*block.Block) error
+ }
++
++// pubSub includes Subscriber, buffered channel for storing the pending blocks and cancel channel to end the handler thread
++type pubSub struct {
++	Blocklistener       BlockCreationSubscriber
++	BlocklistenerBuffer chan *block.Block
++	BlocklistenerCancel chan interface{}
++}","can you move the [] into pubSub? so Blockchain just contains a pubSub, not []",Why do we need this?
+6730,"@@ -224,6 +224,11 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 100);
++
++    validateMemoryBreakerThreshold();
+     
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ","I don't think 100 is a safe default here, since later we check that the value is between 50-95.",I think this should 
+6731,"@@ -49,5 +49,9 @@ namespace NLog.Layouts
+         /// Layout renderer method can handle concurrent threads
+         /// </summary>
+         ThreadSafe = 1,
++        /// <summary>
++        /// Layout renderer method is agnostic to current thread context
++        /// </summary>
++        ThreadAgnostic = 2 | ThreadSafe,
+     }
+ }","I would be nice if we could describe this without the word ""agnostic""",>ThreadAgnostic [](s
+6732,"@@ -406,6 +406,16 @@ class KNNClassifier(object):
+       print ""  active inputs:"", _labeledInput(inputPattern,
+                                               cellsPerCol=self.cellsPerCol)
+ 
++    if isSparse > 0:
++      isSorted = all(inputPattern[i] <= inputPattern[i+1]
++                     for i in xrange(len(inputPattern)-1))
++      if not isSorted:
++        raise RuntimeError(""Sparse inputPattern must be sorted."")
++
++      if not all(bit < isSparse for bit in inputPattern):
++        raise RuntimeError(""Sparse inputPattern contains an index outside of""
++                           ""the dense representation's bounds."")
++
+     if rowID is None:
+       rowID = self._iterationIdx
+ ",Pick more specific exception types for these cases. Not sure what would be best for this one (`ValueError`?) but the next one could be `IndexError`.,I think this should be `<=` instead of `<=`.
+6733,"@@ -0,0 +1,6 @@
++const jestConfig = require( './jest.config' );
++
++module.exports = {
++	...jestConfig,
++	testMatch: [ '<rootDir>/.storybook/?(*.)test.js' ],
++};",This seemed like the easiest solution We need to include this path in `testMatch` to run the test AFAIK *BUT* we don't want this test ran when running them all normally I'm sure there are other ways to do this!,Why do we need this?
+6734,"@@ -114,7 +114,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation.Tests
+ 
+             var ex = Assert.Throws<TTransportException>(() => transport.Flush());
+ 
+-            Assert.Equal(""Cannot flush closed transport. message, yo"", ex.Message);
++            Assert.Equal(""Cannot flush closed transport"", ex.Message);
+         }
+ 
+         [Fact]",Most of the following test changes can be avoided if need be.,Why did you change this?
+6735,"@@ -181,14 +181,8 @@ int Partitioner::Run(const PartitionConfig &config)
+     TIMER_STOP(packed_mlp);
+     util::Log() << ""MultiLevelPartition constructed in "" << TIMER_SEC(packed_mlp) << "" seconds"";
+ 
+-    TIMER_START(cell_storage);
+-    CellStorage storage(mlp, *edge_based_graph);
+-    TIMER_STOP(cell_storage);
+-    util::Log() << ""CellStorage constructed in "" << TIMER_SEC(cell_storage) << "" seconds"";
+-
+     TIMER_START(writing_mld_data);
+     io::write(config.mld_partition_path, mlp);
+-    io::write(config.mld_storage_path, storage);
+     TIMER_STOP(writing_mld_data);
+     util::Log() << ""MLD data writing took "" << TIMER_SEC(writing_mld_data) << "" seconds"";
+ ",Eventually we might want to move this back as generating this data structure takes some time (for large datasets) and we don't want it in the hot-path of `osrm-customize` runs. Thinking long-term making `osrm-customize` eventually digest `.osrm.cells` will will enable only updating cells selectively and using an earlier customization for the rest.,Why is this removed?
+6736,"@@ -110,8 +110,15 @@ func (cmd *CommandRun) Wait() error {
+ 	return cmd.vpnServer.Wait()
+ }
+ 
+-func (cmd *CommandRun) Kill() {
++func (cmd *CommandRun) Kill() (err error) {
+ 	cmd.vpnServer.Stop()
+-	cmd.dialogWaiter.Stop()
+-	cmd.natService.Stop()
++	err = cmd.dialogWaiter.Stop()
++	if err != nil {
++		return err
++	}
++	err = cmd.natService.Stop()
++	if err != nil {
++		return err
++	}
++	return nil
+ }",You're not really using named result variable - you can just leave `error`.,Shouldn't this be `return err`?
+6737,"@@ -37,16 +37,14 @@ public class SortOrderUtil {
+   }
+ 
+   public static SortOrder buildSortOrder(Table table) {
+-    return buildSortOrder(table.spec(), table.sortOrder());
++    return buildSortOrder(table.schema(), table.spec(), table.sortOrder());
+   }
+ 
+-  public static SortOrder buildSortOrder(PartitionSpec spec, SortOrder sortOrder) {
++  public static SortOrder buildSortOrder(Schema schema, PartitionSpec spec, SortOrder sortOrder) {
+     if (sortOrder.isUnsorted() && spec.isUnpartitioned()) {
+       return SortOrder.unsorted();
+     }
+ 
+-    Schema schema = spec.schema();
+-
+     Multimap<Integer, SortField> sortFieldIndex = Multimaps.index(sortOrder.fields(), SortField::sourceId);
+ 
+     // build a sort prefix of partition fields that are not already in the sort order",It wasn't possible to call this method with `PartitionSpec.unpartitioned()` as the schema in the spec was empty.,nit: `schema` is not used.
+6738,"@@ -26,11 +26,13 @@ use Thelia\Exception\ModuleException;
+ use Thelia\Log\Tlog;
+ use Thelia\Model\Cart;
+ use Thelia\Model\Country;
++use Thelia\Model\Hook;
+ use Thelia\Model\HookQuery;
+ use Thelia\Model\Lang;
+ use Thelia\Model\Map\ModuleImageTableMap;
+ use Thelia\Model\Map\ModuleTableMap;
+ use Thelia\Model\Module;
++use Thelia\Model\ModuleConfigQuery;
+ use Thelia\Model\ModuleI18n;
+ use Thelia\Model\ModuleI18nQuery;
+ use Thelia\Model\ModuleImage;",this namespace is never used,Please sort the imports by leng
+6739,"@@ -26,6 +26,13 @@
+ // see URLOpener.
+ // See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
++// Message Delivery Semantics
++//
++// AWS SNS and SQS combine to support at-least-once semantics; applications must
++// call Message.Ack/Nack after processing a message, or it will be redelivered.
++// See https://godoc.org/gocloud.dev/pubsub#hdr-At_most_once_and_At_least_once_Delivery
++// for more background.
++//
+ // Escaping
+ //
+ // Go CDK supports all UTF-8 strings; to make this work with providers lacking","Well, if you call `Nack`, it _will_ be redelivered. So maybe reword.",I don't think we need to mentio
+6740,"@@ -7,7 +7,9 @@
+ 
+ <div class=""text-box-wrapper"">
+   <div class=""text-box"">
+-    <p class=""videowrapper""><%= wistia_video_embed('39245f55fd') %></p>
++    <p class=""videowrapper"">
++      <iframe allowtransparency=""true"" class=""wistia_embed"" frameborder=""0"" height=""367"" name=""wistia_embed"" scrolling=""no"" src=""https://fast.wistia.com/embed/iframe/39245f55fd?videoWidth=653&videoHeight=367&controlsVisibleOnLoad=true"" width=""653""></iframe>
++    </p>
+     <h3>An interview with a Ruby developer who uses Linux and full Open Source stack</h3>
+ 
+     <div class='assets'>",Why did we make this a static string?,I think this should be `wistia_video_embed`
+6741,"@@ -148,7 +148,7 @@ def bigquery_dataset(item):
+     parent = item.parent()
+     name = '//bigquery.googleapis.com/projects/{}/datasets/{}'.format(
+         parent['projectNumber'], item['datasetReference']['datasetId'])
+-    asset_type = 'google.bigquery.Dataset'
++    asset_type = 'google.cloud.bigquery.Dataset'
+     parent_name = '//cloudresourcemanager.googleapis.com/projects/{}'.format(
+         parent['projectNumber'])
+     return _create_asset(name, asset_type, parent_name, item.data(), None)",Please re-run PYTHONPATH=. python tests/services/inventory/update_cai_dumps.py following the instructions at the top of this file to ensure the test files have the correct CAI asset type.,Why this change?
+6742,"@@ -66,9 +66,9 @@ func TestCreateContract(t *testing.T) {
+ 	addr := identityset.Address(28)
+ 	_, err = accountutil.LoadOrCreateAccount(sm, addr.String())
+ 	require.NoError(err)
+-	stateDB := NewStateDBAdapter(sm, 0, !cfg.Genesis.IsAleutian(0),
+-		cfg.Genesis.IsGreenland(0), cfg.Genesis.IsKamchatka(0),
+-		cfg.Genesis.IsLordHowe(0), hash.ZeroHash256)
++	opt := []StateDBAdapterOption{NotFixTopicCopyBugOption()}
++	stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, opt...)
++
+ 	contract := addr.Bytes()
+ 	var evmContract common.Address
+ 	copy(evmContract[:], contract[:])","`stateDB := NewStateDBAdapter(sm, 0, hash.ZeroHash256, NotFixTopicCopyBugOption())`",Why is this needed?
+6743,"@@ -446,8 +446,17 @@ class HintManager(QObject):
+         # Short hints are the number of hints we can possibly show which are
+         # (needed - 1) digits in length.
+         if needed > min_chars:
+-            short_count = math.floor((len(chars) ** needed - len(elems)) /
+-                                     len(chars))
++            total_space = len(chars) ** needed
++            # Calculate short_count naively, by finding the avaiable space and
++            # dividing by the number of spots we would loose by adding a
++            # short element
++            short_count = math.floor((total_space - len(elems)) /
++                                     (len(chars)))
++            # Check if we double counted above to warrant another short_count
++            # https://github.com/qutebrowser/qutebrowser/issues/3242
++            if total_space - (short_count * len(chars) +
++                              (len(elems) - short_count)) >= len(chars) - 1:
++                short_count += 1
+         else:
+             short_count = 0
+ ","There are unneeded parens here, but I'll fix it up when merging.",I don't think you need the parentheses arou
+6744,"@@ -62,6 +62,12 @@ static void setup_globals(mrb_state *mrb)
+ 
+     h2o_mruby_eval_expr(mrb, ""$LOAD_PATH << \""#{$H2O_ROOT}/share/h2o/mruby\"""");
+     h2o_mruby_assert(mrb);
++
++    /* require and include built-in libraries */
++    h2o_mruby_eval_expr(mrb, ""require \""h2o.rb\""\n""
++                             ""require \""acl.rb\""\n""
++                             ""include H2O::ACL\n"");
++    h2o_mruby_assert(mrb);
+ }
+ 
+ mrb_value h2o_mruby_to_str(mrb_state *mrb, mrb_value v)",Just one more thing... How about doing all of the following? 1. renaming h2o.rb to bootstrap.rb 2. require and include the acl code _from_ bootstrap.rb,I'm not sure if this is the right way to do this. I think it would be better to have a `h2o_mruby_assert` here.
+6745,"@@ -82,14 +82,6 @@ double get_timestamp (void)
+     return ((double) tm.tv_sec + (tm.tv_nsec/1.0e9));
+ }
+ 
+-static void timeout_cb (flux_t *h, cron_task_t *t, void *arg)
+-{
+-    cron_entry_t *e = arg;
+-    flux_log (h, LOG_INFO, ""cron-%ju: task timeout at %.2fs. Killing"",
+-              e->id, e->timeout);
+-    cron_task_kill (t, SIGTERM);
+-}
+-
+ static int cron_entry_run_task (cron_entry_t *e)
+ {
+     flux_t *h = e->ctx->h;","Commit message: ""remove"" is misspelled.",Why was this removed?
+6746,"@@ -60,6 +60,11 @@ public abstract class BytesValues {
+     return value.slice(toTrim);
+   }
+ 
++  public static BytesValue trimTrailingZeros(final BytesValue value) {
++    final int toTrim = trailingZeros(value);
++    return value.slice(0, value.size() - toTrim + 1);
++  }
++
+   /**
+    * Returns the smallest bytes value whose bytes correspond to the provided long. That is, the
+    * returned value may be of size less than 8 if the provided int has leading zero bytes.",This is a pretty idiosyncratic method - I'd move it into the JSON-RPC package rather than adding it to `BytesValue`.,nit: `trimTrailingZeros` -> `trimTrailingZeros`
+6747,"@@ -424,11 +424,15 @@ module RSpec
+           superclass.method(:next_runnable_index_for),
+           description, *args, &example_group_block
+         )
++
++        config = RSpec.configuration
++        config.apply_derived_metadata_to(@metadata)
++
+         ExampleGroups.assign_const(self)
+ 
+         @currently_executing_a_context_hook = false
+ 
+-        RSpec.configuration.configure_group(self)
++        config.configure_group(self)
+       end
+ 
+       # @private",Is there a way to deduplicate this somehow? Could we roll it into `RSpec.configuration` with a bit of memoization or is there a chicken and egg problem.,Why is this needed?
+6748,"@@ -49,6 +49,7 @@ public class ResultSetPropertyTester extends PropertyTester
+     public static final String PROP_CAN_NAVIGATE_HISTORY = ""canNavigateHistory"";
+     public static final String PROP_EDITABLE = ""editable"";
+     public static final String PROP_CHANGED = ""changed"";
++    private static final String PROP_UPDATE_NOT_IN_PROGRESS = ""updateNotInProgress"";
+ 
+     private static final Log log = Log.getLog(ResultSetPropertyTester.class);
+ ","Generally, I wouldn't say I like the idea of providing properties that return negative/inverted values. It would be more convenient to return whether the update is **in** progress or not.",I think this should be `UPDATE_IN_PROGRESS`
+6749,"@@ -256,7 +256,7 @@ import 'flexStyles';
+             const runtimeTicks = playbackManager.duration(options.player);
+ 
+             if (runtimeTicks) {
+-                const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player);
++                const timeRemainingTicks = runtimeTicks - playbackManager.currentTime(options.player) * 10000;
+ 
+                 return Math.round(timeRemainingTicks / 10000);
+             }","Converting playbackManager to operate in ms (preferred solution, imo) would allow us to completely drop this function.",Why do we need to multiply by 10000 here?
+6750,"@@ -8,6 +8,7 @@
+ 
+ DEFINE_int32(max_handlers_per_req, 10, ""The max handlers used to handle one request"");
+ DEFINE_int32(min_vertices_per_bucket, 3, ""The min vertices number in one bucket"");
++DEFINE_int32(max_edge_returned_per_vertex, 1000, ""The max edge number returnred searching vertex"");
+ 
+ namespace nebula {
+ namespace storage {","The default value should be a bigger one, I'd like it is the maximum of int32. That means we will not cut-off anything by default. And users would config it with an appropriate value in config-file, such as 1000 or 5000, etc.",DEFINE_int32(max_vertex_returned_per_bucket
+6751,"@@ -221,7 +221,10 @@ func (c *cliApp) settle(args []string) {
+ 		clio.Info(fmt.Sprintf(""Hermes fee: %v MYST"", hermesFee.String()))
+ 		return
+ 	}
+-	hermesID := c.config.GetStringByFlag(config.FlagHermesID)
++	hermesID, err := c.config.GetHermesID()
++	if err != nil {
++		clio.Warn(""could not get hermes id: "", err)
++	}
+ 	clio.Info(""Waiting for settlement to complete"")
+ 	errChan := make(chan error)
+ ",Probably missing return here as well,Shouldn't this be `clio.Error`?
+6752,"@@ -109,6 +109,12 @@ type ConfigSettings struct {
+ 	//
+ 	// EXPERIMENTAL: Subject to change.
+ 	LoadRaw json.RawMessage `json:""load,omitempty"" caddy:""namespace=caddy.config_loaders inline_key=module""`
++
++	// The interval to pull config. With a non-zero value, will pull config
++	// from config loader (eg. a http loader) with given interval.
++	//
++	// EXPERIMENTAL: Subject to change.
++	PullInterval Duration `json:""pull_interval,omitempty""`
+ }
+ 
+ // IdentityConfig configures management of this server's identity. An identity","On second thought... this affects how often the function specified by the `load` property is run. So I wonder if, for consistency, we should call this `LoadInterval` instead. Does that make sense?",Why is this a `Duration`?
+6753,"@@ -2,7 +2,8 @@ var exported = {},
+     common = require('../../../api/utils/common.js'),
+     crypto = require('crypto'),
+     countlyCommon = require('../../../api/lib/countly.common.js'),
+-    plugins = require('../../pluginManager.js');
++    plugins = require('../../pluginManager.js'),
++    localize = require('../../../api/utils/localization.js');
+ (function() {
+     /**
+      *    register internalEvent",Now you don't need the localization module here then :),nit: space after `=`
+6754,"@@ -264,11 +264,16 @@ public class InclusiveMetricsEvaluator {
+ 
+     @Override
+     public <T> Boolean in(BoundReference<T> ref, Set<T> literalSet) {
+-      return ROWS_MIGHT_MATCH;
++      // in(col, {X, Y}) => eq(col, x) OR eq(col, x)
++      if (literalSet.stream().anyMatch(v -> eq(ref, toLiteral(v)))) {
++        return ROWS_MIGHT_MATCH;
++      }
++      return ROWS_CANNOT_MATCH;
+     }
+ 
+     @Override
+     public <T> Boolean notIn(BoundReference<T> ref, Set<T> literalSet) {
++      // notIn(col, {X, Y}) => notEq(col, x) AND notEq(col, x)
+       return ROWS_MIGHT_MATCH;
+     }
+ ","This should not convert each value to a literal on every invocation. Instead, this PR can add a `literals` method to `BoundSetPredicate` to access the values as literals. That way, the conversion happens once and can be lazy.",I think this should be `R
+6755,"@@ -22,7 +22,7 @@ def _load_lib():
+     """"""Load LightGBM Library.""""""
+     lib_path = find_lib_path()
+     if len(lib_path) == 0:
+-        raise Exception(""cannot find LightGBM library"")
++        return None
+     lib = ctypes.cdll.LoadLibrary(lib_path[0])
+     lib.LGBM_GetLastError.restype = ctypes.c_char_p
+     return lib",I think we still need this exception if doesn't have LIGHTGBM_BUILD_DOC,Why this change?
+6756,"@@ -71,15 +71,9 @@ func (h *Helper) waitForCertificateCondition(client clientset.CertificateInterfa
+ 	if pollErr != nil && certificate != nil {
+ 		log.Logf(""Failed waiting for certificate %v: %v\n"", name, pollErr.Error())
+ 
+-		if len(certificate.Status.Conditions) > 0 {
+-			log.Logf(""Observed certificate conditions:\n"")
+-			for _, cond := range certificate.Status.Conditions {
+-				log.Logf(""- Last Status: '%s' Reason: '%s', Message: '%s'\n"", cond.Status, cond.Reason, cond.Message)
+-			}
+-		}
++		log.Logf(""Certificate:\n"")
++		h.describeCMObject(certificate)
+ 
+-		log.Logf(""Certificate description:\n"")
+-		h.Kubectl(certificate.Namespace).DescribeResource(""certificate"", name)
+ 		log.Logf(""Order and challenge descriptions:\n"")
+ 		h.Kubectl(certificate.Namespace).Describe(""order"", ""challenge"")
+ ",Does this make it easier to read? Previously this would have run `kubectl describe certificate` right? In which case it would have included events related to the cert. Will we miss that? Would the old `kubectl describe` output have gone to stderr?,Why are we removing this?
+6757,"@@ -24,11 +24,14 @@ import com.google.gson.annotations.SerializedName;
+ public class Internals {
+ 
+   public static final String SERIALIZED_APPLICATION_SERVER = ""application-server"";
++  public static final String SERIALIZED_CAMUNDA_INTEGRATION = ""camunda-integration"";
+ 
+   protected Database database;
+   @SerializedName(value = SERIALIZED_APPLICATION_SERVER)
+   protected ApplicationServer applicationServer;
+   protected Map<String, Command> commands;
++  @SerializedName(value = SERIALIZED_CAMUNDA_INTEGRATION)
++  protected Map<String, Object> camundaIntegration;
+ 
+   protected Map<String, Metric> metrics;
+ ","Just an understanding question: do we need a map here, would a list/set of Strings be sufficient? we are not adding entries with `false` here, are we? Being in the list already means it's used, right?",Why do we need this?
+6758,"@@ -567,7 +567,8 @@ class CentralPlannerScheduler(Scheduler):
+ 
+         for task in self._state.get_active_tasks():
+             self._state.fail_dead_worker_task(task, self._config, assistant_ids)
+-            if task.id not in necessary_tasks and self._state.prune(task, self._config):
++            removed = self._state.prune(task, self._config)
++            if removed and task.id not in necessary_tasks:
+                 remove_tasks.append(task.id)
+ 
+         self._state.inactivate_tasks(remove_tasks)","Ah, so the change is that you want the `prune()` side effect before doing the `task.id not in necessary_tasks` membership check? Stupid non-Haskell programming languages :p",I think this should be `i
+6759,"@@ -2,6 +2,13 @@ package cmd
+ 
+ import (
+ 	""fmt""
++	""os""
++	osexec ""os/exec""
++	""path/filepath""
++	""strings""
++	""testing""
++	""time""
++
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""
+ 	""github.com/drud/ddev/pkg/fileutil""",This change was not really intended but made by the linter of VS Code. And looking at other packages this looks like a best practise to place interal packages on the top and gh imports afterwards.,nit: this should be group
+6760,"@@ -494,6 +494,8 @@ function findAndModify(coll, query, sort, doc, options, callback) {
+     queryObject.bypassDocumentValidation = finalOptions.bypassDocumentValidation;
+   }
+ 
++  finalOptions.readPreference = ReadPreference.primary;
++
+   // Have we specified collation
+   decorateWithCollation(queryObject, coll, finalOptions);
+ ",Do we normally force ReadPreference primary on other write operations? Or is it just that we normally ignore it?,Why is this needed?
+6761,"@@ -292,6 +292,12 @@ public class Spark3Util {
+             return Expressions.hours(sourceName);
+           }
+ 
++          @Override
++          public Transform alwaysNull(int fieldId, String sourceName, int sourceId) {
++            // do nothing for alwaysNull, it doesn't need to be converted to a transform
++            return null;
++          }
++
+           @Override
+           public Transform unknown(int fieldId, String sourceName, int sourceId, String transform) {
+             return Expressions.apply(transform, Expressions.column(sourceName));","Instead of returning null here and discarding nulls automatically, I think this should return null (or some other signaling value) and fix the part that consumes the output of the visitor.",Why is this needed?
+6762,"@@ -95,8 +95,13 @@ public class ForkingValidatorProvider implements ValidatorProvider {
+         final long prevBlockNumber = blockNumber - 1L;
+         final Optional<BlockHeader> prevBlockHeader = blockchain.getBlockHeader(prevBlockNumber);
+         if (prevBlockHeader.isPresent()) {
+-          return resolveValidatorProvider(prevBlockNumber)
+-              .getValidatorsForBlock(prevBlockHeader.get());
++          final Collection<Address> validatorsForPreviousBlock =
++              resolveValidatorProvider(prevBlockNumber)
++                  .getValidatorsForBlock(prevBlockHeader.get());
++          // Update VoteTallyCache
++          blockValidatorProvider.setValidatorsForBlock(
++              prevBlockHeader.get(), validatorsForPreviousBlock);
++          return validatorsForPreviousBlock;
+         }
+       }
+       return getValidators.apply(validatorProvider);","Really, we want to be setting the validatorsForPreviousBlock against the yet to be created block, so it might make sense to update the cache once the block is created/imported instead.",Why do we need to u
+6763,"@@ -60,11 +60,11 @@ int set_properties_from_args(fpga_properties filter, fpga_result *result,
+ 		{""segment"", required_argument, NULL, 0xe},
+ 		{0, 0, 0, 0},
+ 	};
+-	int supported_options = sizeof(longopts) / sizeof(longopts[0]) - 1;
+ 	int getopt_ret = -1;
+ 	int option_index = 0;
+ 	char *endptr = NULL;
+ 	int found_opts[] = {0, 0, 0, 0};
++	int supported_options = sizeof(found_opts) / sizeof(int);
+ 	int next_found = 0;
+ 	int old_opterr = opterr;
+ 	opterr = 0;",It seems to me that the original implementation was correct. Can you share what the scanner was pointing out?,`sizeof(longopts[0]
+6764,"@@ -178,6 +178,8 @@ function* webpackConfig( env, argv ) {
+ 				'./assets/js/googlesitekit-modules-search-console.js',
+ 			'googlesitekit-modules-subscribe-with-google':
+ 				'./assets/js/googlesitekit-modules-subscribe-with-google.js',
++			'googlesitekit-subscribe-with-google-bulk-edit':
++				'./assets/js/modules/subscribe-with-google/bulk-edit.js',
+ 			'googlesitekit-modules-tagmanager':
+ 				'./assets/js/googlesitekit-modules-tagmanager.js',
+ 			'googlesitekit-user-input':","Instead of doing that, please create an `assets/js/googlesitekit-subscribe-with-google-bulk-edit.js` file as entry point - all our entry points should be located in `assets/js`.",I think this should be `googlesitekit-subscribe-with-google-bulk-edit`
+6765,"@@ -39,7 +39,11 @@ storiesOf( 'WordPress', module )
+ 			<div id=""dashboard-widgets"">
+ 				<div className=""metabox-holder"">
+ 					<div id=""google_dashboard_widget"" className=""postbox"">
+-						<h2 className=""hndle ui-sortable-handle""><span><SvgIcon id=""logo-g"" height=""19"" width=""19"" /><SvgIcon id=""logo-sitekit"" height=""17"" width=""78"" /></span>
++						<h2 className=""hndle ui-sortable-handle"">
++							<span><div className=""googlesitekit-logo googlesitekit-logo-mini"">
++								<SvgIcon id=""logo-g"" height=""19"" width=""19"" />
++								<SvgIcon id=""logo-sitekit"" height=""17"" width=""78"" />
++							</div></span>
+ 						</h2>
+ 						<div className=""inside"">
+ 							<div id=""js-googlesitekit-wp-dashboard"">","This is not valid, a `div` shouldn't be in a `span`. You could apply the `className` attribute to the `span` tag.",I think this should be `googlesitekit-logo-mini`
+6766,"@@ -100,6 +100,8 @@ func AddFlags(flagSet *pflag.FlagSet) {
+ 	flags.IntVarP(flagSet, &fs.Config.MultiThreadStreams, ""multi-thread-streams"", """", fs.Config.MultiThreadStreams, ""Max number of streams to use for multi-thread downloads."")
+ 	flags.DurationVarP(flagSet, &fs.Config.RcJobExpireDuration, ""rc-job-expire-duration"", """", fs.Config.RcJobExpireDuration, ""expire finished async jobs older than this value"")
+ 	flags.DurationVarP(flagSet, &fs.Config.RcJobExpireInterval, ""rc-job-expire-interval"", """", fs.Config.RcJobExpireInterval, ""interval to check for expired async jobs"")
++	flags.DurationVarP(flagSet, &fs.Config.TransferredExpireDuration, ""accounting-transferred-expire-duration"", """", fs.Config.TransferredExpireDuration, ""remove transferred accounting stats older than this value"")
++	flags.DurationVarP(flagSet, &fs.Config.TransferredExpireInterval, ""accounting-transferred-expire-interval"", """", fs.Config.TransferredExpireInterval, ""interval to check for expired transferred accounting stats"")
+ }
+ 
+ // SetFlags converts any flags into config which weren't straight forward",Would it be possible to reuse RcJobExpireDuration and RcJobExpireInterval and auto delete them when job is deleted?,nit: `expire finished transferred accounting stats older than this val
+6767,"@@ -18,7 +18,13 @@
+ #  OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ #  THE SOFTWARE.
+ 
++from __future__ import print_function
++
+ import copy
++import sys
++
++from jinja2 import Environment
++from jinja2 import PackageLoader
+ 
+ 
+ def merge_dicts(a, b, raise_conflicts=False, path=None):",Python wants **future** imports to come first.,Why do we need this import?
+6768,"@@ -2267,4 +2267,5 @@ detach_on_permanent_stack(bool internal, bool do_cleanup, dr_stats_t *drstats)
+     SELF_PROTECT_DATASEC(DATASEC_RARELY_PROT);
+     dynamo_detaching_flag = LOCK_FREE_STATE;
+     EXITING_DR();
++    options_detach();
+ }",Better to call this before EXITING_DR which is supposed to be last.,I don't think this is the right place to do this.
+6769,"@@ -295,8 +295,6 @@ public class MainActivity extends BaseActivity implements CustomTabActivityHelpe
+                     switch ((int) drawerItem.getIdentifier()) {
+                         case ITEM_HOME:
+                             fragment = new HomeFragment();
+-                            // recreate when Home is pressed
+-                            recreate();
+                             break;
+                         case ITEM_SEARCH_BY_CODE:
+                             fragment = new FindProductFragment();",Does this work at runtime?,Why did you remove this?
+6770,"@@ -24,8 +24,9 @@ import (
+ const (
+ 	userAgentHeader = ""User-Agent""
+ 
+-	credsTimeout  = 10 * time.Second
+-	clientTimeout = 30 * time.Second
++	maxRetriesOnRecoverableFailures = 8 // Default provided by SDK is 3 which means requests are retried up to only 2 seconds.
++	credsTimeout                    = 10 * time.Second
++	clientTimeout                   = 30 * time.Second
+ )
+ 
+ // Provider provides methods to create sessions.",Hmm why do we need to make this change? Like which one requires this change?,Why do we need to increase this?
+6771,"@@ -4,12 +4,6 @@
+ // Use define from require.js not webpack's define
+ var _define = window.define;
+ 
+-// document-register-element
+-var docRegister = require(""document-register-element"");
+-_define(""document-register-element"", function() {
+-    return docRegister;
+-});
+-
+ // fetch
+ var fetch = require(""whatwg-fetch"");
+ _define(""fetch"", function() {",why remove this and other piece?,Why did you remove this?
+6772,"@@ -41,7 +41,7 @@ describe('dom.hasContentVirtual', function() {
+ 	it('is false if the element has an aria label but `ignoreAria=true`', function() {
+ 		fixture.innerHTML = '<div id=""target"" aria-label=""my-label"">	</div>';
+ 		tree = axe.utils.getFlattenedTree(fixture);
+-		assert.isTrue(
++		assert.isFalse(
+ 			hasContentVirtual(
+ 				axe.utils.querySelectorAll(tree, '#target')[0],
+ 				true,",Yikes... That was probably me.,Why did you change this?
+6773,"@@ -622,7 +622,7 @@ class Application extends BaseApplication {
+ 
+ 		// the following menu items will be available for all OS under Tools
+ 		const toolsItemsAll = [{
+-			label: _('Resources'),
++			label: _('Note attachments...'),
+ 			click: () => {
+ 				this.dispatch({
+ 					type: 'NAV_GO',",It would be better to move the ... outside of the l8n block. This way it won't need to be translated for each language twice.,I don't think this shoul
+6774,"@@ -35,6 +35,11 @@
+ #include ""monster.h""
+ #include ""scheduler.h""
+ #include ""databasetasks.h""
++#include ""actions.h""
++#include ""movement.h""
++#include ""weapons.h""
++#include ""globalevent.h""
++#include ""events.h""
+ 
+ extern Chat* g_chat;
+ extern Game g_game;",That's a huge load of new dependencies. I think it's better to create a reload function on ScriptManager and control with enum instead.,Why is this needed?
+6775,"@@ -42,6 +42,7 @@ func NewJob() *cobra.Command {
+ 		NewUpgradeJivaVolumeJob(),
+ 		NewUpgradeCStorSPCJob(),
+ 		NewUpgradeCStorVolumeJob(),
++		NewUpgradeTaskJob(),
+ 	)
+ 
+ 	cmd.PersistentFlags().StringVarP(&options.fromVersion,",`NewUpgradeTaskJob` -> `NewUpgradeResource`,Why do we need to add a 
+6776,"@@ -0,0 +1,16 @@
++#include ""system.h""
++
++#include <glibtop.h>
++#include <glibtop/mem.h>
++
++#include <glib.h>
++#include <unistd.h>
++
++int luaA_sys_get_meminfo(lua_State *L)
++{
++    glibtop_mem mem;
++    glibtop_init();
++    glibtop_get_mem(&mem);
++    lua_pushinteger(L, mem.cached);
++    return 1;
++}",Is that the memory usage of the system or the process / awesome?,This should be `glibtop_get_mem_cached()`
+6777,"@@ -209,8 +209,8 @@ class Realm {
+     /**
+      * Add a listener `callback` for the specified event `name`.
+      * @param {string} name - The name of event that should cause the callback to be called.
+-     *   _Currently, only the ""change"" event supported_.
+-     * @param {callback(Realm, string)} callback - Function to be called when the event occurs.
++     *   _Currently, only the ""change"" or ""schema"" events supported_.
++     * @param {callback(Realm, string)|callback(Realm, Schema)} callback - Function to be called when a change event occurs.
+      *   Each callback will only be called once per event, regardless of the number of times
+      *   it was added.
+      * @throws {Error} If an invalid event `name` is supplied, or if `callback` is not a function.","""change"" *and* ""schema"" events (A bunch of these; not marking them all).",Shouldn't this be `(string|Schema)`?
+6778,"@@ -73,4 +73,13 @@ public interface RewriteFiles extends SnapshotUpdate<RewriteFiles> {
+    * @return this for method chaining
+    */
+   RewriteFiles validateFromSnapshot(long snapshotId);
++
++  /**
++   * Use the specified sequence number for the new manifest of the data files added in this update,
++   * instead of inheriting the sequence number of the snapshot that will be created.
++   *
++   * @param sequenceNumber a sequence number
++   * @return this for method chaining
++   */
++  RewriteFiles overrideSequenceNumberForNewDataFiles(long sequenceNumber);
+ }","I think there is probably a shorter, more descriptive name for this. Something like `commitAtSequenceNumber`?",nit: `overrideSequenceNumberForNewDataFil
+6779,"@@ -23,6 +23,7 @@ class Organization < ActiveRecord::Base
+   scope :case_insensitive_url_name, ->(mixed_case) { where(['lower(url_name) = ?', mixed_case.downcase]) }
+ 
+   validates :name, presence: true, length: 3..85, uniqueness: { case_sensitive: false }
++  validates :url_name, presence: true, length: 1..60, allow_nil: false, uniqueness: true, case_sensitive: false
+   validates :description, length: 0..800, allow_nil: true
+   validates :org_type, inclusion: { in: ORG_TYPES.values }
+   before_validation :clean_strings_and_urls",The `url_name` should definitely be more than just 1 character long at the shortest. How about 3 or 4 characters?,I think this should be `allow_blank: fals
+6780,"@@ -22,9 +22,6 @@
+ *  This copyright notice MUST APPEAR in all copies of the script!
+ ***************************************************************/
+ 
+-use TYPO3\CMS\Core\Utility\GeneralUtility;
+-use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;
+-
+ 
+ /**
+  * Page Indexer to index TYPO3 pages used by the Index Queue.",Please revert this change,Why was this removed?
+6781,"@@ -57,13 +57,10 @@ module OrgAdmin
+     # preview a phase
+     # GET /org_admin/phases/[:id]/preview
+     def preview
+-      phase = Phase.includes(:template).find(params[:id])
+-      authorize phase
+-      render(""/org_admin/phases/preview"",
+-        locals: {
+-          template: phase.template,
+-          phase: phase
+-        })
++      @phase = Phase.includes(:template).find(params[:id])
++      authorize @phase
++      @template = @phase.template
++      @guidance_presenter = GuidancePresenter.new(Plan.new(template: @phase.template))
+     end
+ 
+     # add a new phase to a passed template",Nice. I hadn't even heard of presenters in Rails before (learn something new every day) :),Why do we need this?
+6782,"@@ -22,10 +22,19 @@ class Pool
+      */
+     protected $providers = array();
+ 
++    /**
++     * @var array
++     */
+     protected $contexts = array();
+ 
++    /**
++     * @var DownloadStrategyInterface[]
++     */
+     protected $downloadSecurities = array();
+ 
++    /**
++     * @var string
++     */
+     protected $defaultContext;
+ 
+     /**","`string[]` ? not sure, can you verify this @core23 ? Thank you",Should be `string[]`
+6783,"@@ -1224,12 +1224,14 @@ define([""playbackManager"", ""dom"", ""inputManager"", ""datetime"", ""itemHelper"", ""med
+             return null;
+         }
+ 
++        let playPauseClickTimeout;
+         function onViewHideStopPlayback() {
+             if (playbackManager.isPlayingVideo()) {
+                 require(['shell'], function (shell) {
+                     shell.disableFullscreen();
+                 });
+ 
++                clearTimeout(playPauseClickTimeout);
+                 var player = currentPlayer;
+                 view.removeEventListener(""viewbeforehide"", onViewHideStopPlayback);
+                 releaseCurrentPlayer();",are we aware that this breaks older browsers like WebOS? :) they don't handle `let`,Why do we need this?
+6784,"@@ -86,7 +86,7 @@ class Cache(CacheBase):
+         if ttl == 0:
+             self.delete(key)
+         else:
+-            # We can't use touch here because we need to update the TTL value in the record.
++            # We can't use touch here because we need to update the TTL value in the object.
+             value = self.get(key)
+             self.set(key, value, ttl)
+ ",This isn't really a Kinto record but a Memcached record. I could kind of go either way on this.,I don't understand this change.
+6785,"@@ -582,6 +582,7 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+                     displayName(accountOptions.displayName).email(accountOptions.email).
+                     photoUrl(accountOptions.photoUrl).thumbnailUrl(accountOptions.thumbnailUrl).
+                     additionalOauthValues(accountOptions.additionalOauthValues).build();
++            account.downloadProfilePhoto();
+             if (id.customAttributes != null) {
+                 mgr.getAdminSettingsManager().setPrefs(id.customAttributes, account);
+             }",Kick off the download after login.,Why do we need this?
+6786,"@@ -286,7 +286,7 @@ class ErrorBaseline
+         $xml = preg_replace_callback(
+             '/<files (psalm-version=""[^""]+"") (?:php-version=""(.+)""(\/?>)\n)/',
+             /**
+-             * @param array<int, string> $matches
++             * @param string[] $matches
+              */
+             function (array $matches) : string {
+                 return","I don't think you need to change this, `array<int, string>` should be accepted whenever `string[]` is expected. (`string[]` is an alias of `array<string>` itself an alias of `array<array-key, string>` which is a parent type of `array<int, string>`",This should be `string[]`.
+6787,"@@ -1257,8 +1257,9 @@ bool wlr_seat_touch_has_grab(struct wlr_seat *seat) {
+ }
+ 
+ bool wlr_seat_validate_grab_serial(struct wlr_seat *seat, uint32_t serial) {
+-	return serial == seat->pointer_state.grab_serial ||
+-		serial == seat->touch_state.grab_serial;
++	return true;
++	//return serial == seat->pointer_state.grab_serial ||
++	//	serial == seat->touch_state.grab_serial;
+ }
+ 
+ struct wlr_seat_client *wlr_seat_client_from_resource(","TODO: fix this, probably in another PR",This should be removed.
+6788,"@@ -591,6 +591,17 @@ class HintManager(QObject):
+             message.error(""No elements found."")
+             return
+ 
++        # Because _start_cb is called asynchronously, it's possible that the
++        # user switched to another tab or closed the tab/window. In that case
++        # we should not start hinting.
++        tabbed_browser = objreg.get('tabbed-browser', default=None,
++                scope='window', window=self._win_id)
++        if tabbed_browser is None:
++            return
++        tab = tabbed_browser.widget.currentWidget()
++        if tab is None or tab.tab_id != self._tab_id:
++            return
++
+         strings = self._hint_strings(elems)
+         log.hints.debug(""hints: {}"".format(', '.join(strings)))
+ ",Is there any case that tab is None?,"I don't think this is the right place for this check. If the user switches to another tab, we should not start hinting. If they switch to another tab, we should start hinting."
+6789,"@@ -132,8 +132,14 @@ func (e *endpoint) Apply(ctx context.Context, req ctrl.Request, chaos v1alpha1.I
+ 			Namespace: pod.Namespace,
+ 		})
+ 
+-		t.Append(sourceSet)
+-		t.Append(targetSet)
++		e := t.Append(sourceSet)
++		if e != nil {
++			return e
++		}
++		e = t.Append(targetSet)
++		if e != nil {
++			return e
++		}
+ 	}
+ 
+ 	sourcesChains := []v1alpha1.RawIptables{}",pls use `err` instead of `e`,I don't think this is the right place to do this. I think it should be at the beginning of the function.
+6790,"@@ -159,7 +159,9 @@ function attachGamepadScript(e) {
+ }
+ 
+ // No need to check for gamepads manually at load time, the eventhandler will be fired for that
+-window.addEventListener(""gamepadconnected"", attachGamepadScript);
++if (navigator.getGamepads) { /* eslint-disable-line compat/compat */
++    window.addEventListener(""gamepadconnected"", attachGamepadScript);
++}
+ 
+ export default {
+     enable: enable,",`attachGamepadScript` above can also be placed inside.,Why do we need this?
+6791,"@@ -108,7 +108,7 @@ func decodeBytecode() ([]byte, error) {
+ 	return hex.DecodeString(util.TrimHexPrefix(bytecodeFlag.Value().(string)))
+ }
+ 
+-func signer() (address string, err error) {
++func Signer() (address string, err error) {
+ 	return util.GetAddress(signerFlag.Value().(string))
+ }
+ ","when we use RegisterWriteCommand,this func should be exported,so we can use this to get signer at the outside action package",`Signer` is unused (from `deadcode`)
+6792,"@@ -123,7 +123,7 @@ func (management *Management) serveNewConnection(connection net.Conn) {
+ func (management *Management) deliverLines() {
+ 	for {
+ 		line := <-management.lineReceiver
+-		log.Debug(management.logPrefix, ""Line delivering: "", line)
++		// log.Debug(management.logPrefix, ""Line delivering: "", line)
+ 
+ 		lineConsumed := false
+ 		for _, middleware := range management.middlewares {",Dead code - we should remove it or use `log.Trace` for lower logging level. Same applies for change at line 138.,Is this intentional?
+6793,"@@ -55,6 +55,11 @@ boost::optional<ParameterT> parseParameters(std::string::iterator &iter,
+         // iterator to the failing position. Extract the position from the exception ourselves.
+         iter = failure.first;
+     }
++    catch (const boost::numeric::bad_numeric_cast &e)
++    {
++        // this can happen if we get bad numeric values in the request, just handle
++        // as normal parser error
++    }
+ 
+     return boost::none;
+ }",How does this make sure invalid coordinates making the parser fail? Relying on the Coordinate type's boost numeric_cast calls in the ctor? Shouldn't we rely on a coordinate's `.IsValid()` member function instead?,Shouldn't this be `e
+6794,"@@ -1,8 +1,11 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
+ # This code example demonstrates how to upload an item
+-# (file) to a folder within a bucket in Amazon S3.
++# (file) to a folder within a bucket in Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3-ruby-example-upload-item-to-folder]
+ 
+ # Prerequisites:
+ #  - An existing Amazon S3 bucket.",Simple Storage **Service**,I think this should 
+6795,"@@ -54,6 +54,8 @@ if (!is_dir($cacheDir)) {
+ // Enable caching unless in dev mode or running tests:
+ $useCache = APPLICATION_ENV != 'development' && !defined('VUFIND_PHPUNIT_RUNNING');
+ 
++defined('CACHE_ENABLED') || define('CACHE_ENABLED', $useCache);
++
+ // Build configuration:
+ return [
+     'modules' => array_unique($modules),",Does this line (and the corresponding one in the test bootstrap) actually do anything? I don't see where CACHE_ENABLED is used as a global constant.,Why do we need this?
+6796,"@@ -445,13 +445,14 @@ func assertResolved(f func(target *api.Container, dep *api.Container) bool, targ
+ 	}
+ }
+ 
+-func TestTransitionDependenciesResolved(t *testing.T) {
++func TestVerifyTransitionDependenciesResolved(t *testing.T) {
+ 	testcases := []struct {
+ 		Name             string
+ 		TargetKnown      api.ContainerStatus
+ 		TargetDesired    api.ContainerStatus
++		TargetNext       api.ContainerStatus
++		DependencyName   string
+ 		DependencyKnown  api.ContainerStatus
+-		DependentStatus  api.ContainerStatus
+ 		SatisfiedStatus  api.ContainerStatus
+ 		ExpectedResolved bool
+ 	}{","has this changed? are we testing ""all possible situations"" now?",Why is this change needed?
+6797,"@@ -236,13 +236,13 @@ public class SolrCLI implements CLIO {
+           .argName(""HOST"")
+           .hasArg()
+           .required(false)
+-          .desc(""Address of the Zookeeper ensemble; defaults to: ""+ZK_HOST)
++          .desc(""Address of the Zookeeper ensemble; defaults to: ""+ ZK_HOST + '.')
+           .build(),
+       Option.builder(""c"")
+           .argName(""COLLECTION"")
+           .hasArg()
+           .required(false)
+-          .desc(""Name of collection; no default"")
++          .desc(""Name of collection; no default."")
+           .longOpt(""collection"")
+           .build(),
+       Option.builder(""verbose"")",ZK is properly spelled 'ZooKeeper' (capital 'K').,I don't think we need the 
+6798,"@@ -73,6 +73,8 @@ public class RubyGapicSurfaceTransformer implements ModelToViewTransformer {
+       ImmutableList.of(""GOOGLE_CLOUD_KEYFILE"", ""GCLOUD_KEYFILE"");
+   private static final List<String> DEFAULT_JSON_ENV_VARS =
+       ImmutableList.of(""GOOGLE_CLOUD_KEYFILE_JSON"", ""GCLOUD_KEYFILE_JSON"");
++  private static final List<String> DEFAULT_PATHS =
++      ImmutableList.of(""~/.config/gcloud/application_default_credentials.json"");
+ 
+   private final GapicCodePathMapper pathMapper;
+   private final PackageMetadataConfig packageConfig;",Guessing this locates the key you get when you run `gcloud auth application-default login`? What was the previous behavior/the behavior for the manual Veneer creds?,I think this should be `~/
+6799,"@@ -85,7 +85,7 @@
+               entireColumnSelection = [0, selected[1], this.view.wt.wtTable.getRowStrategy().cellCount - 1, selected[1]],
+               columnSelected = entireColumnSelection.join(',') == selected.join(',');
+ 
+-            return selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || columnSelected;
++            return selected[0] < 0 || this.countRows() >= this.getSettings().maxRows || (columnSelected && this.countRows() > 1);
+           }
+         },
+         {","looks good to me, but it would be better if you assigned `this.countRows()` into a variable, so it doesn't trigger twice in the return statement",Why is this change necessa
+6800,"@@ -1,3 +1,5 @@
++'use strict';
++
+ require('classtool');
+ 
+ function ClassSpec(b) {","For now, don't add ""use strict"" to any existing files. That's a separate project that we'll do later. (New files can use ""use strict"".)",Why is this needed?
+6801,"@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
+ 	// Set up tests and give ourselves a working directory.
+ 	assert := asrt.New(t)
+ 
++	noninteractive := ""DRUD_NONINTERACTIVE""
++	// nolint: errcheck
++	defer os.Setenv(noninteractive, os.Getenv(noninteractive))
++	err := os.Unsetenv(noninteractive)
++	assert.NoError(err)
++
+ 	testMatrix := map[string][]string{
+ 		""drupal6phpversion"": {AppTypeDrupal6, PHP56},
+ 		""drupal7phpversion"": {AppTypeDrupal7, PHP71},","I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?",I think this should
+6802,"@@ -139,7 +139,7 @@ def py_run(command_options='', return_std=False, stdout=None, stderr=None):
+     """"""
+     # Create command line to call pylint
+     epylint_part = [sys.executable, ""-c"", ""from pylint import epylint;epylint.Run()""]
+-    options = shlex.split(command_options)
++    options = shlex.split(command_options, posix='win' not in sys.platform)
+     cli = epylint_part + options
+ 
+     # Providing standard output and/or error if not set",`sys.platform` could be equal to `darwin` which is posix. Use `not startswith('win')`?,Why is this needed?
+6803,"@@ -38,11 +38,12 @@ func New(cfg *any.Any, logger *zap.Logger, scope tally.Scope) (service.Service,
+ 	}
+ 
+ 	s := &svc{
+-		logger:  logger,
+-		filter:  config.Filter,
+-		scope:   scope,
+-		slack:   slack.New(config.Token),
+-		channel: config.Channel,
++		logger:    logger,
++		filter:    config.Filter,
++		overrides: NewOverrideLookup(config.Overrides),
++		scope:     scope,
++		slack:     slack.New(config.Token),
++		channel:   config.Channel,
+ 	}
+ 	return s, nil
+ }",let's move this into `slack_helper.go`,Why do we need this
+6804,"@@ -54,7 +54,7 @@ class Azure(base.Base):
+         driver:
+           name: azure
+           ssh_connection_options:
+-            -o ControlPath=~/.ansible/cp/%r@%h-%p
++            - '-o ControlPath=~/.ansible/cp/%r@%h-%p'
+ 
+     .. important::
+ ","I doubt it will work, but without space between -o and ControlPath it should. Lets see. What I do not understand is why we did not see a failure on CI related to this?",why this change?
+6805,"@@ -56,7 +56,7 @@ DiscreteBearing BearingClass::getDiscreteBearing(const double bearing)
+ {
+     BOOST_ASSERT(0. <= bearing && bearing <= 360.);
+     auto shifted_bearing = (bearing + 0.5 * discrete_step_size);
+-    if (shifted_bearing > 360.)
++    if (shifted_bearing >= 360.)
+         shifted_bearing -= 360;
+     return static_cast<DiscreteBearing>(shifted_bearing / discrete_step_size);
+ }",this is the reason we might be seeing 360 as discrete bearing,Why did you chan
+6806,"@@ -72,6 +72,9 @@ from pylint.__pkginfo__ import version
+ from pylint.reporters.ureports import nodes as report_nodes
+ 
+ 
++FULL_VERSION = '%%(prog)s %s\nastroid %s\nPython %s' % (
++    version, astroid_version, sys.version)
++
+ MANAGER = astroid.MANAGER
+ 
+ ","`FULL_VERSION` is available at module level for others to use, but it won't have `%(prog)s` substituted with pylint. Will that be a problem. Also put it here instead of __pkginfo__ with other versions because it isn't pkginfo related.",I don't think th
+6807,"@@ -34,6 +34,7 @@ public abstract class BaseColumnIterator {
+   protected long triplesRead = 0L;
+   protected long advanceNextPageCount = 0L;
+   protected Dictionary dictionary;
++  protected long rowPosition;
+ 
+   protected BaseColumnIterator(ColumnDescriptor descriptor) {
+     this.desc = descriptor;",Is this needed? I don't see any uses.,Why do we need t
+6808,"@@ -29,6 +29,15 @@ func (c *Client) DeletePubSubOrFail(name string) {
+ 	}
+ }
+ 
++func (c *Client) DeleteBuildOrFail(name string) {
++	c.T.Helper()
++	builds := c.KnativeGCP.EventsV1alpha1().CloudBuildSources(c.Namespace)
++	err := builds.Delete(name, &metav1.DeleteOptions{})
++	if err != nil {
++		c.T.Fatalf(""Failed to delete build %s/%s: %v"", c.Namespace, name, err)
++	}
++}
++
+ func (c *Client) DeleteSchedulerOrFail(name string) {
+ 	c.T.Helper()
+ 	schedulers := c.KnativeGCP.EventsV1alpha1().CloudSchedulerSources(c.Namespace)",Shouldn't this be V1beta1?,nit: `Failed to delete build %s/%s`
+6809,"@@ -102,6 +102,13 @@ class Proposal < ActiveRecord::Base
+     approval
+   end
+ 
++  def remove_approver(email)
++    user = User.for_email(email)
++    approval = self.approvals.find_by(user_id: user.id)
++    CommunicartMailer.notification_for_approver_removed(email,approval)
++    approval.destroy
++  end
++
+   def initialize_approvals()
+     if self.linear? && self.approvals.any?
+       self.approvals.update_all(status: 'pending')",I think there's an `approval_for`,Extra empty line detected at class 
+6810,"@@ -719,6 +719,8 @@ public interface Stack<T> extends LinearSeq<T> {
+     @Override
+     Stack<T> takeWhile(Predicate<? super T> predicate);
+ 
++    <U> U transform(Function<? super List<T>, ? extends U> f);
++
+     @Override
+     <U> Stack<U> unit(Iterable<? extends U> iterable);
+ ",Here we should use <code>List</code> in generic,<U> Stack<U> unit(Iterable<? extend
+6811,"@@ -56,8 +56,7 @@ public final class BaselineReleaseCompatibility extends AbstractBaselinePlugin {
+ 
+         @Override
+         public Iterable<String> asArguments() {
+-            JavaVersion jdkVersion =
+-                    JavaVersion.toVersion(javaCompile.getToolChain().getVersion());
++            JavaVersion jdkVersion = JavaVersion.toVersion(javaCompile.getTargetCompatibility());
+             if (!supportsReleaseFlag(jdkVersion)) {
+                 log.debug(
+                         ""BaselineReleaseCompatibility is a no-op for {} in {} as {} doesn't support --release"",",The `JavaCompile#getToolChain` method got removed and I am not sure what a good replacement is. I replaced it with `targetCompat` for now but they are not equivalent. Maybe we can use `JavaVersion#current` here?,This should be `getTargetCompatibil
+6812,"@@ -14,7 +14,7 @@ use Ergonode\SharedKernel\Domain\Aggregate\MultimediaId;
+ 
+ interface MultimediaQueryInterface
+ {
+-    public function fileExists(Hash $hash): bool;
++    public function fileExists(string $name): bool;
+ 
+     public function findIdByHash(Hash $hash): ?MultimediaId;
+ ",The method name is incorrect. It does not check the existence of the file. I'd suggest deprecating both methods `fileExists` and `findIdByHash` and use findIdByFilename instead of fileExits,`findIdByHash` should be renamed to `findIdByName`
+6813,"@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
++	__u8 nat_lvl1_drop = 0;
+ 
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.","We have `stdbool` imported, might as well use that for clarity.",Shouldn't this be `__u8`?
+6814,"@@ -0,0 +1 @@
++package batchstore","File is empty, consider removing?",
+6815,"@@ -760,7 +760,7 @@ describe('Bulk', function() {
+           batch.insert({ b: 1 });
+ 
+           // Execute the operations
+-          batch.execute(self.configuration.writeConcernMax(), function(err, result) {
++          batch.execute(self.configuration.writeConcernMax().writeConcern, function(err, result) {
+             expect(err).to.exist;
+             expect(result).to.not.exist;
+ ","`writeConcernMax` was changed to return a `writeConcern` formatted the new way-- `writeConcern: {w:1, ...}`. Bulk execute takes an actual `WriteConcern` object as its first parameter (this was changed in master), so we have to un-wrap the `writeConcernMax` result here.",Why is this change needed?
+6816,"@@ -1,9 +1,10 @@
+ module TabularData
+   class Container
+-    attr_reader :columns
++    attr_reader :columns, :frozen_sort
+ 
+     def initialize(name, config)
+       @name = name
++      @frozen_sort = false
+       self.init_query(config[:engine].constantize, config.fetch(:joins, []))
+       self.init_columns(config.fetch(:column_configs, {}), config.fetch(:columns, {}))
+       self.set_sort(config[:sort])",How about passing this through the `config`?,Layout/TrailingWhitespace: Trailing whitespace detected.
+6817,"@@ -373,10 +373,10 @@ def create_secret(secretsmanager_client):
+         secretsmanager_client.delete_secret(SecretId=item)
+ 
+ 
+-only_localstack = pytest.mark.skipif(
+-    os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD"",
+-    reason=""test only applicable if run against localstack"",
+-)
++@pytest.fixture
++def only_localstack():
++    if os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD"":
++        pytest.skip(""test only applicable if run against localstack"")
+ 
+ 
+ @pytest.fixture","Out of curiosity - did we make this change to allow dynamically assigning a value to `os.environ[""TEST_TARGET""]` during test execution? I kind of liked the decorator style `@only_localstack` - makes the condition a bit more explicit. Looks like `skipif` also allows to specify a condition string, e.g. `pytest.mark.skipif('os.environ.get(""TEST_TARGET"") == ""AWS_CLOUD""')` - could that be an option? (not sure if that gets lazily evaluated at runtime right before the execution of the annotated test method starts, though..)",Why is this needed?
+6818,"@@ -72,6 +72,7 @@ class SliderItem implements OrderableEntityInterface
+      */
+     public function edit(SliderItemData $sliderItemData)
+     {
++        $this->domainId = $sliderItemData->domainId;
+         $this->name = $sliderItemData->name;
+         $this->link = $sliderItemData->link;
+         $this->hidden = $sliderItemData->hidden;",I noticed (SonarCloud noticed actually) that the implementation of `::edit` method is the same as `__construct` is. Does it make sense to call the `edit` method from the constructor?,Why do we need this?
+6819,"@@ -78,6 +78,7 @@ int syslog_prot_process(struct syslog_conn *conn)
+ 
+         /* Incomplete message */
+         if (eof == end || (*eof != '\n' && *eof != '\0')) {
++            flb_debug(""[syslog-prot] incomplete message! (Enable trace log to see the message.)"");
+             return 0;
+         }
+ ","would you please rename the message prefix to: [in_syslog] ...""","flb_debug(""[syslog-prot] incomplete message! (Enable tra"
+6820,"@@ -600,8 +600,8 @@ struct AtomMatch {  // for each seed atom (matched)
+ };
+ typedef std::vector<AtomMatch> AtomMatchSet;
+ 
+-std::string MaximumCommonSubgraph::generateResultSMARTS(
+-    const MCS& mcsIdx) const {
++std::string MaximumCommonSubgraph::generateResultSMARTSAndQueryMol(
++    const MCS& mcsIdx, RWMol **molExt) const {
+   // match the result MCS with all targets to check if it is exact match or
+   // template
+   Seed seed;  // result MCS","The pointer to a pointer is kind of gross. How about either taking the `ROMOL_SPTR` directly or, preferably, returning an `std::pair`?",`molExt` can be `const`
+6821,"@@ -164,7 +164,12 @@ func (pool *TransactionPool) rememberCommit(flush bool) {
+ func (pool *TransactionPool) PendingCount() int {
+ 	pool.pendingMu.RLock()
+ 	defer pool.pendingMu.RUnlock()
++	return pool.pendingCountLocked()
++}
+ 
++// pendingCountLocked is a helper for PendingCount that returns the number of
++// transactions pending in the pool
++func (pool *TransactionPool) pendingCountLocked() int {
+ 	var count int
+ 	for _, txgroup := range pool.pendingTxGroups {
+ 		count += len(txgroup)","the name confusing, please rename to `pendingCountNoLock` or similar",I don't think we need t
+6822,"@@ -44,13 +44,11 @@ func addTestingTsfBlocks(bc Blockchain) error {
+ 		[]byte{}, uint64(100000),
+ 		big.NewInt(10),
+ 	)
+-	sk, err := keypair.DecodePrivateKey(Gen.CreatorPrivKey)
+-	if err != nil {
+-		return err
+-	}
+-	if err := action.Sign(tsf0, sk); err != nil {
+-		return err
+-	}
++	pk, _ := hex.DecodeString(Gen.CreatorPubKey)
++	pubk, _ := keypair.BytesToPublicKey(pk)
++	sig, _ := hex.DecodeString(""ea18385718db2a8b92fa2dcdc158a05aae17fc7e800cc735850bdc99ab7b081f32fce70080888742d7b6bee892034e38298b69ce5fff671c18f0bed827e1e21f9da2ba5d8c434e00"")
++	tsf0.SetSrcPubkey(pubk)
++	tsf0.SetSignature(sig)
+ 	blk, err := bc.MintNewBlock([]action.Action{tsf0}, ta.Addrinfo[""producer""],
+ 		nil, nil, """")
+ 	if err != nil {",line is 175 characters,Why are we ignoring the
+6823,"@@ -230,12 +230,10 @@ public abstract class SalesforceReactActivity extends ReactActivity {
+     }
+ 
+     protected void setRestClient(RestClient restClient) {
+-        if(restClient!= null && client != restClient){
+-            if(reactActivityDelegate != null){
+-                reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());
+-            }
+-        }
+         client = restClient;
++        if(client != null && reactActivityDelegate != null){
++            reactActivityDelegate.loadReactAppOnceIfReady(getMainComponentName());
++        }
+     }
+ 
+     protected ClientManager buildClientManager() {",@ivanbogdanov Does this fix the first time load gray screen issue that @wmathurin noticed?,Why did you remove this
+6824,"@@ -35,11 +35,12 @@ __all__ = ['Dataset', 'Booster',
+            'print_evaluation', 'record_evaluation', 'reset_parameter', 'early_stopping',
+            'plot_importance', 'plot_metric', 'plot_tree', 'create_tree_digraph']
+ 
++# REMOVEME: remove warning after 2.3.0 version release
+ if system() == 'Darwin':
+     warnings.warn(""Starting from version 2.2.1, the library file in distribution wheels for macOS ""
+-                  ""will be built by the Apple Clang compiler.\n""
++                  ""is built by the Apple Clang (Xcode_9.4.1) compiler.\n""
+                   ""This means that in case of installing LightGBM from PyPI via the ``pip install lightgbm`` command, ""
+-                  ""you won't need to install the gcc compiler anymore.\n""
+-                  ""Instead of that, you'll need to install the OpenMP library, ""
++                  ""you don't need to install the gcc compiler anymore.\n""
++                  ""Instead of that, you need to install the OpenMP library, ""
+                   ""which is required for running LightGBM on the system with the Apple Clang compiler.\n""
+-                  ""You can install the OpenMP library by the following command: ``brew install libomp``."", FutureWarning)
++                  ""You can install the OpenMP library by the following command: ``brew install libomp``."", UserWarning)",Is `2.3.0` version OK?,I don't think we should remove this warning.
+6825,"@@ -26,6 +26,18 @@ describe ""Selenium::WebDriver::TargetLocator"" do
+     end
+   end
+ 
++  it ""should switch to parent frame"" do
++    driver.navigate.to url_for(""iframes.html"")
++
++    iframe = driver.find_element(:tag_name => ""iframe"")
++    driver.switch_to.frame(iframe)
++
++    driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)
++
++    driver.switch_to.parent_frame
++    driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element)
++  end
++
+   # switching by name not yet supported by safari
+   not_compliant_on :browser => [:ie, :iphone, :safari] do
+     it ""should switch to a window and back when given a block"" do",I tested it only in Firefox (`./go //rb:firefox-test`),Use the new Ruby 1.9 hash syntax.
+6826,"@@ -10,6 +10,8 @@ import (
+ 	""net/http/httptest""
+ )
+ 
++// NewTestClient returns a TestClient with a replacement http handler function.
++// Methods on the new TestClient are overrideable as well.
+ func NewTestClient(handleFunc http.HandlerFunc) (*httptest.Server, *TestClient, error) {
+ 	ts := httptest.NewServer(handleFunc)
+ 	opts := []option.ClientOption{",separate third party and builtin,// NewTestClient returns a TestClient with a
+6827,"@@ -818,7 +818,9 @@ public class SalesforceSDKManager {
+ 
+         // Finishes front activity if specified, and if this is the last account.
+         if (frontActivity != null && (users == null || users.size() <= 1)) {
+-            frontActivity.finish();
++            // only finish if it isn't hybrid or if hybrid, requires authentication
++            if (!isHybrid() || BootConfig.getBootConfig(frontActivity).shouldAuthenticate())
++                frontActivity.finish();
+         }
+ 
+         /*",@smcnulty-sfdc We do want to finish the hybrid activity in our hybrid apps though. Could the caller not pass in `frontActivity` instead? Or start it up again post-logout?,Shouldn't this be `if (frontActivity != null
+6828,"@@ -111,7 +111,7 @@ func (o outbound) Call(ctx context.Context, req *transport.Request) (*transport.
+ 
+ 	response, err := ctxhttp.Do(ctx, o.Client, request)
+ 	if err != nil {
+-		if err == context.DeadlineExceeded {
++		if err == ctx.Err() {
+ 			return nil, errors.NewTimeoutError(req.Service, req.Procedure, deadline.Sub(start))
+ 		}
+ ",isn't this going to return a timeout error if the context is canceled?,Shouldn't this be `ctx.Err()`?
+6829,"@@ -15,6 +15,10 @@ class ArgsParser {
+   ArgsParser(String[] args) {
+     for (String arg : args) {
+       String[] argNameVal = arg.split(""="");
++      if (argNameVal.length == 1) {
++        parsedArgs.put(argNameVal[0], ""true"");
++        continue;
++      }
+       if (argNameVal.length != 2) {
+         System.out.println(""WARNING: Ignoring unrecognized argument: "" + arg);
+         continue;","`argNameVal.length` will still be !=2, so line 22 will give true and then continue on line 24",Why do we need this?
+6830,"@@ -237,7 +237,7 @@ class FunctionDocblockManipulator
+                 continue;
+             }
+ 
+-            if ($char === '\\' || preg_match('/\w/', $char)) {
++            if ($chars[$i + 1] === '\\' || preg_match('/\w/', $char)) {
+                 if ($this->return_typehint_start === null) {
+                     $this->return_typehint_start = $i + $end_bracket_position + 1;
+                 }",It was `$chars[$i]` I believe.,`$chars[$i + 1] === '\\'` shou
+6831,"@@ -246,7 +246,7 @@ module Unix::Exec
+       else
+         val = val.to_s
+       end
+-      env_array << ""#{key.to_s.upcase}=\""#{val}\""""
++      env_array << ""#{key.to_s}=\""#{val}\""""
+     end
+     env_array
+   end","This has the likely potential to break existing tests that are relying on the old beaker behavior. If we are going to release this in beaker 3.x, then we need to preserve the old behavior as well (so set both the `upcase` and original values). On Windows, they env variables will overwrite each other, with the same value, so not an issue. On *nix, there will be two env variables, but they will have the same value, so again no issue.",val = val.to_s.upcase
+6832,"@@ -299,6 +299,7 @@ Blockly.Variables.createVariable = function(workspace, opt_callback, opt_type) {
+   // Prompt the user to enter a name for the variable
+   Blockly.prompt(newMsg, '',
+       function(text, additionalVars, variableOptions) {
++        variableOptions = variableOptions || {};
+         var scope = variableOptions.scope;
+         var isLocal = (scope === 'local') || false;
+         var isCloud = variableOptions.isCloud || false;",Thanks for fixing this! I probably didn't test the playground when making changes here for cloud variables.,Why do we need this?
+6833,"@@ -39,6 +39,7 @@ class PruneColumns extends AvroSchemaVisitor<Schema> {
+   private final NameMapping nameMapping;
+ 
+   PruneColumns(Set<Integer> selectedIds, NameMapping nameMapping) {
++    Preconditions.checkNotNull(selectedIds, ""Selected field ids cannot be null"");
+     this.selectedIds = selectedIds;
+     this.nameMapping = nameMapping;
+   }",I will also check if `nameMapping` needs a precondition null check.,`Preconditions.check
+6834,"@@ -60,9 +60,8 @@ public class Files {
+ 
+       if (!file.getParentFile().isDirectory() && !file.getParentFile().mkdirs()) {
+         throw new RuntimeIOException(
+-            String.format(
+                 ""Failed to create the file's directory at %s."",
+-                file.getParentFile().getAbsolutePath()));
++                file.getParentFile().getAbsolutePath());
+       }
+ 
+       try {","Since RuntimeIOException is deprecated and you are touching this code, why not replace it?",Why was this removed
+6835,"@@ -59,7 +59,9 @@ class ClusterParamsTest(TestCaseBase):
+       self.assertGreaterEqual(encodersDict['c1']['resolution'], 0.001,
+                               ""Resolution is too low"")
+ 
+-
++    # Ensure incorrect tmImplementation throws exception
++    with self.assertRaises(ValueError):
++        getScalarMetricWithTimeOfDayAnomalyParams([0], tmImplementation="""")
+ 
+ if __name__ == '__main__':
+   unittest.main()",You should also have a test that calls it with tm_cpp and make sure it returns the correct JSON file.,Why do we need this?
+6836,"@@ -168,17 +168,12 @@ define([""jQuery"", ""globalize"", ""scripts/taskbutton"", ""dom"", ""libraryMenu"", ""layo
+         }), menuItems.push({
+             name: ""Xml TV"",
+             id: ""xmltv""
+-        }), menuItems.push({
+-            name: globalize.translate(""ButtonOther""),
+-            id: ""other""
+         }), require([""actionsheet""], function(actionsheet) {
+             actionsheet.show({
+                 items: menuItems,
+                 positionTo: button,
+                 callback: function(id) {
+-                    ""other"" == id ? Dashboard.alert({
+-                        message: globalize.translate(""ForAdditionalLiveTvOptions"")
+-                    }) : Dashboard.navigate(getProviderConfigurationUrl(id))
++                    Dashboard.navigate(getProviderConfigurationUrl(id))
+                 }
+             })
+         })","One more minor change, the string `ForAdditionalLiveTvOptions` is probably also unused.",Why is this removed?
+6837,"@@ -107,7 +107,7 @@ bool RowReaderWrapper::reset(meta::SchemaProviderIf const* schema,
+     currReader_ = &readerV2_;
+     return true;
+   } else {
+-    LOG(ERROR) << ""Unsupported row reader version "" << readerVer;
++    LOG(WARNING) << ""Unsupported row reader version "" << readerVer;
+     currReader_ = nullptr;
+     return false;
+   }",How to distinguish between warning and error?,Why is this a warnin
+6838,"@@ -171,6 +171,10 @@ def doPreGainFocus(obj,sleepMode=False):
+ 			else:
+ 				newForeground=obj
+ 		api.setForegroundObject(newForeground)
++		import UIAHandler
++		if UIAHandler.isUIAAvailable:
++			# Notify UIAHandler of the new foreground so that it can deregister old events and register new ones 
++			UIAHandler.handler.onForegroundChange(newForeground.windowHandle)
+ 		executeEvent('foreground',newForeground)
+ 	if sleepMode: return True
+ 	#Fire focus entered events for all new ancestors of the focus if this is a gainFocus event",Perhaps you want to check if UIAHandler.handler is not None. The current check will break NVDA if you call UIAHandler.terminate() for some reason.,I don't think this i
+6839,"@@ -27,6 +27,7 @@ public class BaseReplacePartitions
+     extends MergingSnapshotProducer<ReplacePartitions> implements ReplacePartitions {
+   BaseReplacePartitions(String tableName, TableOperations ops) {
+     super(tableName, ops);
++    set(""replace-partitions"", ""true"");
+   }
+ 
+   @Override",can we make `replace-partitions` property a static variable in `SnaphotSummary.java`?,Why is this needed?
+6840,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?,I think this should be `W3C`
+6841,"@@ -79,7 +79,9 @@ def get_admins():
+ def activate_response(link):
+     payload = verify_activation_link(link)
+     if payload:
+-        _activate_user(User.query.filter_by(id=payload['id']).with_for_update().one_or_none())
++        user = User.query.filter_by(id=payload['id']).with_for_update().one_or_none()
++        _activate_user(user)
++        send_welcome_email(user)
+         db.session.commit()
+         return redirect(""{CATALOG_URL}/signin"".format(CATALOG_URL=CATALOG_URL), code=302)
+ ","Should really be `one()`, not `one_or_none()`",Why do we need this?
+6842,"@@ -193,7 +193,11 @@ func SetJoinNodeConfigurationOverrides(caCertHash, bootstrapToken string, machin
+ 	}
+ 	out.NodeRegistration.KubeletExtraArgs[""cloud-provider""] = CloudProvider
+ 	if !util.IsControlPlaneMachine(machine.GetMachine()) {
+-		out.NodeRegistration.KubeletExtraArgs[""node-labels""] = nodeRole
++		if labels, ok := out.NodeRegistration.KubeletExtraArgs[""node-labels""]; ok {
++			out.NodeRegistration.KubeletExtraArgs[""node-labels""] = fmt.Sprintf(""%s,%s"", labels, nodeRole)
++		} else {
++			out.NodeRegistration.KubeletExtraArgs[""node-labels""] = nodeRole
++		}
+ 	}
+ 	return out
+ }",Should we use strings.Split and strings.Join instead of manual concatenation?,I don't think this is the ri
+6843,"@@ -374,6 +374,18 @@ class In(
+             asset_partitions=asset_partitions,
+         )
+ 
++    @staticmethod
++    def from_definition(input_def: InputDefinition):
++        return In(
++            dagster_type=input_def.dagster_type,
++            description=input_def.description,
++            default_value=input_def._default_value,  # pylint: disable=protected-access
++            root_manager_key=input_def.root_manager_key,
++            metadata=input_def.metadata,
++            asset_key=input_def._asset_key,  # pylint: disable=protected-access
++            asset_partitions=input_def._asset_partitions_fn,  # pylint: disable=protected-access
++        )
++
+     def to_definition(self, name: str) -> InputDefinition:
+         dagster_type = self.dagster_type if self.dagster_type is not NoValueSentinel else None
+         return InputDefinition(","rough that this needs to exist, but it is what it is",Why do we need this?
+6844,"@@ -117,6 +117,17 @@ describe('render()', () => {
+ 		expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
+ 	});
+ 
++	// TODO: the test doesn't seem to work as it throws, maybe due to not knowing the props allowed for x-bar
++	// it('should not set empty string for null props in custom attributes', () => {
++	// 	render(<x-bar val={null} />, scratch);
++	// 	expect(scratch.childNodes).to.have.length(1);
++	// 	expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR');
++	// 	expect(scratch.firstChild.attributes['val']).to.equal('null');
++	// 	expect(scratch.innerHTML).to.equal(
++	// 		'<x-bar val=""null""></x-bar>'
++	// 	);
++	// });
++
+ 	it('should support the form attribute', () => {
+ 		render(
+ 			<div>","FYI, I pulled your branch and hacked a little on your test case. This passes for me (you may want to tweak further): <pre> it('should not set empty string for null props in custom elements', () => { customElements.define('x-bar', class extends HTMLElement { val; }); // @ts-ignore render(&lt;x-bar val={null} /&gt;, scratch); expect(scratch.childNodes).to.have.length(1); expect(scratch.firstChild).to.have.property('nodeName', 'X-BAR'); expect(scratch.firstChild.attributes.length).to.equal(0); expect(scratch.firstChild.val).to.equal(null); }); </pre>",Can we remove this?
+6845,"@@ -43,7 +43,7 @@ import android.util.Log;
+  */
+ public class SmartStoreLoadExternalStorageTest extends SmartStoreLoadTest {
+ 
+-    static final int ONE_MEGABYTE = 1024 * 1024;
++    static final int LARGE_BYTES = 512 * 1024;
+ 
+     @Override
+     protected String getPasscode() {",It is the maximum value that the configured emulator can support.,Why did you change 
+6846,"@@ -210,14 +210,17 @@ def _load_session(name):
+         name: The name of the session to load, or None to read state file.
+     """"""
+     state_config = objreg.get('state-config')
++    session_manager = objreg.get('session-manager')
+     if name is None:
+         try:
+             name = state_config['general']['session']
+         except KeyError:
+             # No session given as argument and none in the session file ->
+             # start without loading a session
+-            return
+-    session_manager = objreg.get('session-manager')
++            if session_manager.exists('_autosave'):
++                name = '_autosave'
++            else:
++                return
+     try:
+         session_manager.load(name)
+     except sessions.SessionNotFoundError:","Here, I've been giving priority to the session saved by the user. This means, that if the user quits with `:wq`, then restarts `qutebrowser`, and then `qutebrowser` crashes for some reason, next time `qutebrowser` is restarted, the session saved lastly with `wq` will be restored, and not the one autosaved. What do you think?",Why do we need this
+6847,"@@ -64,7 +64,7 @@ func membership(l LedgerReader, addr basics.Address, r basics.Round, p period, s
+ 	balanceRound := balanceRound(r, cparams)
+ 	seedRound := seedRound(r, cparams)
+ 
+-	record, err := l.BalanceRecord(balanceRound, addr)
++	record, err := l.AccountData(balanceRound, addr)
+ 	if err != nil {
+ 		err = fmt.Errorf(""Service.initializeVote (r=%d): Failed to obtain balance record for address %v in round %d: %v"", r, addr, balanceRound, err)
+ 		return","this line got me confused for few seconds, as the `AccountData` is both the name of the data structure as well as the function name. I think that `GetAccountData` is a better choice for a name. ( note that the same applies for the previous `BalanceRecord` function name )",Why do we need this
+6848,"@@ -61,11 +61,7 @@ public:
+     void helper_block_for_at_least_entries(
+             uint32_t amount)
+     {
+-        std::unique_lock<std::mutex> lck(*xml_mutex_);
+-        mock_consumer->cv().wait(lck, [this, amount]
+-                {
+-                    return mock_consumer->ConsumedEntriesSize_nts() >= amount;
+-                });
++        mock_consumer->wait_for_at_least_entries(amount);
+     }
+ 
+     MockConsumer* mock_consumer;",I think this mutex is only used here. Remove it.,Why is this lock no longer needed?
+6849,"@@ -234,6 +234,11 @@ func NewMutableState(
+ 		logger:          logger,
+ 		metricsClient:   shard.GetMetricsClient(),
+ 	}
++
++	if migration.IsDBVersionEnabled() {
++		s.dbRecordVersion = 1
++	}
++
+ 	s.executionInfo = &persistencespb.WorkflowExecutionInfo{
+ 		WorkflowTaskVersion:    common.EmptyVersion,
+ 		WorkflowTaskScheduleId: common.EmptyEventID,",so this is now init to 1?,Why do we need this?
+6850,"@@ -191,7 +191,8 @@ bool ZoneDatabase::LoadSpawnGroups(const char *zone_name, uint16 version, SpawnG
+ 				WHERE
+ 				spawn2.spawngroupID = spawngroup.ID
+ 				AND
+-				spawn2.version = {} and zone = '{}'
++				(spawn2.version = {} OR version = -1)
++				AND zone = '{}'
+ 				{}
+ 		),
+ 		version,",For future note; not prefixing the table in a join can throw an error in the query parser depending on how the query is built I am making an assumption this was tested,I think this should be `OR version
+6851,"@@ -42,9 +42,13 @@ var c client.Client
+ 
+ var expectedRequest = reconcile.Request{NamespacedName: types.NamespacedName{Name: ""foo"", Namespace: ""default""}}
+ 
+-var jobKey = types.NamespacedName{Name: ""install-foo"", Namespace: ""default""}
++var jobKey = types.NamespacedName{Name: ""foo-install"", Namespace: ""default""}
+ 
+-const timeout = time.Second * 5
++const (
++	timeout             = time.Second * 10
++	fakeClusterUUID     = ""fe953108-f64c-4166-bb8e-20da7665ba00""
++	fakeClusterMetadata = `{""clusterName"":""foo"",""aws"":{""region"":""us-east-1"",""identifier"":{""tectonicClusterID"":""fe953108-f64c-4166-bb8e-20da7665ba00""}}}`
++)
+ 
+ func init() {
+ 	log.SetLevel(log.DebugLevel)","Had to bring this up, will abandon this style of testing based on Joel's work soon.",Why did you change this?
+6852,"@@ -493,7 +493,7 @@ public class HttpSolrCall {
+     }
+     if (statusCode == AuthorizationResponse.FORBIDDEN.statusCode) {
+       if (log.isDebugEnabled()) {
+-        log.debug(""UNAUTHORIZED auth header {} context : {}, msg: {}"", req.getHeader(""Authorization""), context, authResponse.getMessage()); // logOk
++        log.debug(""UNAUTHORIZED auth header {} context : {}, msg: {}"", req.getHeader(""Authorization""), context, authResponse.getMessage()); // nowarn
+       }
+       sendError(statusCode,
+           ""Unauthorized request, Response code: "" + statusCode);",What does our source validation complain about here? Many of the logok/nowarn places look fine to me at a glance but I'm no match for the logging policeman ;-),I don't think this should be changed.
+6853,"@@ -22,14 +22,17 @@ import (
+ 	""strconv""
+ 	""time""
+ 
++	""github.com/mysteriumnetwork/node/client/stats""
+ 	""github.com/mysteriumnetwork/node/openvpn/management""
+ )
+ 
+ // SessionStatsHandler is invoked when middleware receives statistics
+-type SessionStatsHandler func(SessionStats) error
++type SessionStatsHandler func(stats.SessionStats) error
+ 
+ const byteCountCommandTemplate = ""bytecount %d""
+ 
++var rule = regexp.MustCompile(""^>BYTECOUNT:(.*),(.*)$"")
++
+ type middleware struct {
+ 	sessionStatsHandler SessionStatsHandler
+ 	interval            time.Duration","It feels like this dependency should not be here. Some deep internal openvpn package (middleware) knows about one of possible stats consumers. Maybe as an alternative, statistics and state callbacks can be extracted as separate interfaces in top openvpn package and reused by both sides",Why do we need this rule?
+6854,"@@ -1744,7 +1744,7 @@ func (fd *fileData) deepCopy(ctx context.Context, codec kbfscodec.Codec,
+ 
+ 	// Handle the single-level case first.
+ 	if !topBlock.IsInd {
+-		newTopBlock, err := topBlock.DeepCopy(codec)
++		newTopBlock := topBlock.DeepCopy()
+ 		if err != nil {
+ 			return zeroPtr, nil, err
+ 		}",Can you please remove `codec` from the parameters too? I think it's unused now.,Why is this change needed?
+6855,"@@ -126,6 +126,7 @@ class ContextTest extends AbstractSymbolResolutionTest {
+         when(compilationUnitDecl.getName()).thenReturn(""CompilationUnit"");
+         when(compilationUnitDecl.getQualifiedName()).thenReturn(""com.github.javaparser.ast.CompilationUnit"");
+         TypeSolver typeSolver = mock(TypeSolver.class);
++        when(typeSolver.getSolvedJavaLangObject()).thenReturn(new ReflectionClassDeclaration(Object.class, typeSolver));
+         when(typeSolver.getRoot()).thenReturn(typeSolver);
+         when(typeSolver.solveType(""java.lang.Object"")).thenReturn(new ReflectionClassDeclaration(Object.class, typeSolver));
+         when(typeSolver.tryToSolveType(""com.github.javaparser.ast.CompilationUnit"")).thenReturn(SymbolReference.solved(compilationUnitDecl));","mocks needed this change so that it returns the ""right"" thing",Why is this needed?
+6856,"@@ -128,9 +128,14 @@ public class MenuEntrySwapperPlugin extends Plugin
+ 	@Getter
+ 	private boolean configuringShiftClick = false;
+ 
++	@Getter
+ 	@Setter
+ 	private boolean shiftModifier = false;
+ 
++	@Getter
++	@Setter
++	private boolean controlModifier = false;
++
+ 	@Provides
+ 	MenuEntrySwapperConfig provideConfig(ConfigManager configManager)
+ 	{","I don't think the getters for this are needed, but looks good other than that",Why is this needed?
+6857,"@@ -1,3 +1,16 @@
+ <%= content_tag_for :div, video do %>
+-  <%= render 'videos/summary', video: video %>
++  <div class=""video-text <%= video.status_class %>"">
++    <%= link_to video_path(video) do %>
++      <h3><%= video.name %></h3>
++    <% end %>
++    <div class=""video-tags"">
++      <%= render video.topics %>
++    </div>
++    <p class=""video-length"" data-wistia-id=""<%= video.clip.wistia_id %>"">
++      <%= video.length_in_minutes %> minutes
++    </p>
++    <p class=""video-summary"">
++      <%= format_markdown(video.summary) %>
++    </p>
++  </div>
+ <% end %>",:+1: to inlining this.,Shouldn't this be `
+6858,"@@ -13785,7 +13785,7 @@ return [
+ 'stream_get_contents' => ['string|false', 'stream'=>'resource', 'length='=>'int', 'offset='=>'int'],
+ 'stream_get_filters' => ['array'],
+ 'stream_get_line' => ['string|false', 'stream'=>'resource', 'length'=>'int', 'ending='=>'string'],
+-'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri:string,mediatype:string}', 'stream'=>'resource'],
++'stream_get_meta_data' => ['array{timed_out:bool,blocked:bool,eof:bool,unread_bytes:int,stream_type:string,wrapper_type:string,wrapper_data:mixed,mode:string,seekable:bool,uri:string,mediatype:string,crypto?:mixed}', 'stream'=>'resource'],
+ 'stream_get_transports' => ['list<string>'],
+ 'stream_get_wrappers' => ['list<string>'],
+ 'stream_is_local' => ['bool', 'stream'=>'resource|string'],",Does psalm support the same logic internally for object-like arrays? Just want to be certain I can indicate this is a contextual return item `crypto?:mixed`.,I think this should
+6859,"@@ -658,8 +658,6 @@ void CreateImageTest(VkLayerTest &test, const VkImageCreateInfo *pCreateInfo, st
+     VkImage image = VK_NULL_HANDLE;
+     if (code.length()) {
+         test.Monitor().SetDesiredFailureMsg(kErrorBit, code);
+-        // Very possible a test didn't check for VK_ERROR_FORMAT_NOT_SUPPORTED
+-        test.Monitor().SetUnexpectedError(""UNASSIGNED-CoreValidation-Image-FormatNotSupported"");
+     } else {
+         test.Monitor().ExpectSuccess();
+     }",I can't recall if there was a fix specific to this in the past?,Why was this remove
+6860,"@@ -51,14 +51,15 @@ var _ = duck.VerifyType(&PubSubSource{}, &duckv1alpha1.Conditions{})
+ 
+ // PubSubSourceSpec defines the desired state of the PubSubSource.
+ type PubSubSourceSpec struct {
+-	// GcpCredsSecret is the credential to use to poll the GCP PubSubSource Subscription. It is not used
++	// Secret is the credential to use to poll the PubSubSource Subscription. It is not used
+ 	// to create or delete the Subscription, only to poll it. The value of the secret entry must be
+ 	// a service account key in the JSON format (see
+ 	// https://cloud.google.com/iam/docs/creating-managing-service-account-keys).
+-	GcpCredsSecret corev1.SecretKeySelector `json:""gcpCredsSecret,omitempty""`
++	Secret *corev1.SecretKeySelector `json:""secret,omitempty""`
+ 
+-	// GoogleCloudProject is the ID of the Google Cloud Project that the PubSubSource Topic exists in.
+-	GoogleCloudProject string `json:""googleCloudProject,omitempty""`
++	// TODO: https://github.com/googleapis/google-cloud-go/blob/master/compute/metadata/metadata.go
++	// Project is the ID of the Google Cloud Project that the PubSubSource Topic exists in.
++	Project string `json:""project,omitempty""`
+ 
+ 	// Topic is the ID of the GCP PubSubSource Topic to Subscribe to. It must be in the form of the
+ 	// unique identifier within the project, not the entire name. E.g. it must be 'laconia', not",Not sure what the todo is here? Is it to support some kind of defaulting based off of that?,Is this TODO still relevant?
+6861,"@@ -68,11 +68,18 @@ namespace NLog.Targets.Wrappers
+         /// Delay the flush until the LogEvent has been confirmed as written
+         /// </summary>
+         /// <docgen category='General Options' order='10' />
+-        public bool AsyncFlush { get => _asyncFlush ?? true;
++        public bool AsyncFlush
++        {
++            get => _asyncFlush ?? true;
+             set => _asyncFlush = value;
+         }
+         private bool? _asyncFlush;
+ 
++        /// <summary>
++        /// Only flush when LogEvent matches condition. Ignore explicit-flush, config-reload-flush and shutdown-flush
++        /// </summary>
++        public bool FlushOnConditionOnly { get; set; }
++
+         private readonly AsyncOperationCounter _pendingManualFlushList = new AsyncOperationCounter();
+ 
+         /// <summary>","Not sure about this name. I think ""explicit"" is also a bit difficult here (I think it should be implicit then) Proposal: FlushOnEvents. Or, It would be cool if we could split into 2 options, FlushOnShutdown and FlushOnReload, but I expect that's far more difficult to implement?",>FlushOnConditionOnly [](sta
+6862,"@@ -32,7 +32,11 @@ from qutebrowser.utils import objreg, qtutils
+ from qutebrowser.browser.webkit import tabhistory
+ 
+ 
+-pytestmark = pytest.mark.qt_log_ignore('QIODevice::read.*: device not open')
++@pytest.fixture(autouse=True)
++@pytest.mark.qt_log_ignore('QIODevice::read.*: device not open')
++def autouse(fake_save_manager):
++    yield
++
+ 
+ webengine_refactoring_xfail = pytest.mark.xfail(
+     True, reason='Broke during QtWebEngine refactoring, will be fixed after '",I don't think that works - you can't mark a fixture.,Why is this needed?
+6863,"@@ -42,6 +42,12 @@ module Bolt
+ 
+     PUPPETFILE_OPTIONS = %w[proxy forge].freeze
+ 
++    DEFAULT_CONFIG_PATHS = [
++      Bolt::Util.windows? ? 'C:\\Program Files\\Puppet Labs\\Bolt\\bolt.yaml' : '/etc/puppetlabs/bolt/bolt.yaml',
++      File.expand_path('.puppetlabs/etc/bolt/bolt.yaml', Bolt::Util.windows? ? ENV['USERPROFILE'] : '~'),
++      File.expand_path('.puppetlabs/bolt.yaml', Bolt::Util.windows? ? ENV['USERPROFILE'] : '~')
++    ].freeze
++
+     def self.default
+       new(Bolt::Boltdir.new('.'), {})
+     end",We should not include this path.,I don't think you need the `
+6864,"@@ -52,6 +52,19 @@ class SlackWebhooknotifierTest(ForsetiTestCase):
+ 
+             self.assertEqual(expected_output.strip(), actual_output.strip())
+ 
++    def test_dump_slack_output_for_string_returns_string(self):
++        violation_data = 'Test violation data string'
++        with mock.patch.object(
++                slack_webhook.SlackWebhook,
++                '__init__',
++                lambda x: None):
++            slack_notifier = slack_webhook.SlackWebhook()
++            actual_output = slack_notifier._dump_slack_output(violation_data)
++
++            expected_output = '\t' + '`' + str(violation_data) + '`\n'
++
++            self.assertEqual(expected_output.strip(), actual_output.strip())
++
+     def test_no_url_no_run_notifier(self):
+         """"""Test that no url for Slack notifier will skip running.""""""
+         with mock.patch.object(slack_webhook.SlackWebhook, '__init__', lambda x: None):",Add newline at end of file,I think you can use `self.assertEqual` here.
+6865,"@@ -257,6 +257,9 @@ class DBUpgrader {
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_EXCLUDE_FILTER + "" TEXT DEFAULT ''"");
+ 
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_MINIMAL_DURATION_FILTER + "" INTEGER DEFAULT -1"");
++
+             // and now auto refresh
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_KEEP_UPDATED + "" INTEGER DEFAULT 1"");","This should be done when updating to the next release (2.5). You currently only perform the upgrade when users go from 1.4 to 1.5, so it will lead to crashes for existing users.",Why is this -1?
+6866,"@@ -320,6 +320,9 @@ const (
+ 	// HiveFeatureGatesEnabledEnvVar is the the environment variable specifying the comma separated list of
+ 	// feature gates that are enabled.
+ 	HiveFeatureGatesEnabledEnvVar = ""HIVE_FEATURE_GATES_ENABLED""
++
++	// CentralMachineManagementAnnotation
++	CentralMachineManagementAnnotation = ""hive.openshift.io/clusterName""
+ )
+ 
+ // GetMergedPullSecretName returns name for merged pull secret name per cluster deployment",suggest hive.openshift.io/cluster-machine-management or something to make it more obvious what it is.,I don't think this is used anywhere.
+6867,"@@ -45,7 +45,7 @@ using Nethermind.JsonRpc.Modules.Eth.FeeHistory;
+ 
+ namespace Nethermind.Init.Steps
+ {
+-    [RunnerStepDependencies(typeof(InitializeNetwork), typeof(SetupKeyStore), typeof(InitializeBlockchain), typeof(InitializePlugins))]
++    [RunnerStepDependencies(typeof(InitializeNetwork), typeof(SetupKeyStore), typeof(InitializeBlockchain), typeof(InitializePlugins), typeof(ReviewBlockTree))]
+     public class RegisterRpcModules : IStep
+     {
+         private readonly INethermindApi _api;",We explicitly don't want to do that. This was a complaint from users before.,Why is this needed?
+6868,"@@ -28,6 +28,7 @@ use Thelia\Type\TypeCollection;
+  * {@inheritdoc}
+  * @method int getId()
+  * @method int[] getExclude()
++ * @method int[] getExcludeCode()
+  * @method string getCode()
+  * @method string[] getOrder()
+  */","Hello, The PHPDoc is `string[]` not `int[]`",Why do we need this method?
+6869,"@@ -20,7 +20,7 @@ import (
+ 	""github.com/chaos-mesh/chaos-mesh/pkg/mock""
+ )
+ 
+-func applyTc(ctx context.Context, pid uint32, args ...string) error {
++func applyTc(ctx context.Context, pid uint32, enterNS bool, args ...string) error {
+ 	// Mock point to return error in unit test
+ 	if err := mock.On(""TcApplyError""); err != nil {
+ 		if e, ok := err.(error); ok {",Same issues with parameters order in `ipset_server.go`,`enterNS` is not used in th
+6870,"@@ -82,8 +82,8 @@ const (
+ 	SystemLocalNamespace = ""temporal-system""
+ 	// SystemNamespaceID is namespace id for all temporal system workflows
+ 	SystemNamespaceID = ""32049b68-7872-4094-8e63-d0dd59896a83""
+-	// SystemNamespaceRetentionDays is retention config for all temporal system workflows
+-	SystemNamespaceRetentionDays = time.Hour * 24 * 7
++	// SystemNamespaceRetention is retention config for all temporal system workflows
++	SystemNamespaceRetention = time.Hour * 24 * 7
+ )
+ 
+ const (","Wow, did it literally mean the retention days is a huge number?",I think this should be `Sys
+6871,"@@ -216,6 +216,11 @@ int FlatCompiler::Compile(int argc, const char **argv) {
+             flatbuffers::PosixPath(argv[argi]));
+         include_directories.push_back(
+             include_directories_storage.back().c_str());
++      } else if (arg == ""--bfbs-filenames"") {
++        if (++argi > argc) Error(""missing path following: "" + arg, true);
++        opts.project_root = argv[argi];
++        if (!DirExists(opts.project_root.c_str()))
++          Error(arg + "" is not a directory: "" + opts.project_root);
+       } else if (arg == ""--conform"") {
+         if (++argi >= argc) Error(""missing path following: "" + arg, true);
+         conform_to_schema = flatbuffers::PosixPath(argv[argi]);",you probably didn't intend to touch those files in `scripts/`,Shouldn't this be `++argi >
+6872,"@@ -270,6 +270,7 @@ def eval_map(det_results,
+              iou_thr=0.5,
+              dataset=None,
+              logger=None,
++             tpfp_func=None,
+              nproc=4):
+     """"""Evaluate mAP of a dataset.
+ ","Similar to `collate_fn`, we may rename it to `tpfp_fn`.","tpfp_func=None,"
+6873,"@@ -320,6 +320,7 @@ export class TopOverlay extends Overlay {
+       return this.wot.wtTable.holderOffset.top;
+ 
+     }
++
+     return 0;
+ 
+   }","Awesome! We may also use negative rule `never` to fix new lines after `return`: `{ blankLine: ""never"", prev: ""return"", next: ""*"" }`",} else {
+6874,"@@ -0,0 +1,18 @@
++// Copyright 2016 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++package libkbfs
++
++import ""errors""
++
++// GetJournalServer returns the JournalServer tied to a particular
++// config.
++func GetJournalServer(config Config) (*JournalServer, error) {
++	bserver := config.BlockServer()
++	jbserver, ok := bserver.(journalBlockServer)
++	if !ok {
++		return nil, errors.New(""Write journal not enabled"")
++	}
++	return jbserver.jServer, nil
++}",Why can't this be a function on the `Config` interface like all the others?,Why do we need 
+6875,"@@ -252,7 +252,9 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem
+         optionsMenu = menu;
+         FeedMenuHandler.onCreateOptionsMenu(inflater, menu);
+         iconTintManager.updateTint();
+-        MenuItemUtils.setupSearchItem(menu, (MainActivity) getActivity(), feedID);
++        if (feed != null) {
++            MenuItemUtils.setupSearchItem(menu, (MainActivity) getActivity(), feedID, feed.getTitle());
++        }
+         if (feed == null || feed.getLink() == null) {
+             menu.findItem(R.id.share_link_item).setVisible(false);
+             menu.findItem(R.id.visit_website_item).setVisible(false);","If the feed is null, the menu items should still be setup. Just the feed title can be left out. That prevents possible flickering when menu items are displayed/hidden for some feeds.",Shouldn't this 
+6876,"@@ -178,8 +178,12 @@ public class Spark3Util {
+ 
+   private static void apply(UpdateSchema pendingUpdate, TableChange.AddColumn add) {
+     Type type = SparkSchemaUtil.convert(add.dataType());
+-    pendingUpdate.addColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
+-
++    if (add.isNullable()) {
++      pendingUpdate.addColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
++    } else {
++      pendingUpdate.allowIncompatibleChanges()
++        .addRequiredColumn(parentName(add.fieldNames()), leafName(add.fieldNames()), type, add.comment());
++    }
+     if (add.position() instanceof TableChange.After) {
+       TableChange.After after = (TableChange.After) add.position();
+       String referenceField = peerName(add.fieldNames(), after.column());",I'm not sure that this should call `allowIncompatibleChanges()` because adding a required column when there are no existing values will break reading the new column in any table with data in it. The only time it is safe to add a required column is if there is no data in the table. What about throwing an exception here instead? I agree that the column should not be optional if NOT NULL was specified. Another alternative is to check whether the table has data and allow the incompatible change if it doesn't have any rows.,Why do we need this?
+6877,"@@ -154,7 +154,7 @@ class ServiceProvider extends ModuleServiceProvider
+          */
+         WidgetManager::instance()->registerReportWidgets(function($manager){
+             $manager->registerReportWidget('System\ReportWidgets\Status', [
+-                'label'   => 'System status',
++                'label'   => Lang::get('backend::lang.dashboard.status.widget_title_default'),
+                 'context' => 'dashboard'
+             ]);
+         });","Early translation , should be logic-less",This should be `Lang
+6878,"@@ -0,0 +1,19 @@
++package proxy
++
++import ""net/http""
++
++type interceptor interface {
++	InterceptRequest(*http.Request) (*http.Request, error)
++	InterceptResponse(*http.Response) (*http.Response, error)
++}
++
++type nullInterceptor struct {
++}
++
++func (i nullInterceptor) InterceptRequest(r *http.Request) (*http.Request, error) {
++	return r, nil
++}
++
++func (i nullInterceptor) InterceptResponse(r *http.Response) (*http.Response, error) {
++	return r, nil
++}","I don't understand why these functions return a request/response, respectively. In all implementations we actually _modify_ the request/response given as a parameter. Do you envisage situations where we'd want to construct completely fresh request/response objects? Even if we do, it's not something needed atm, so I'd favour in keeping the API minimal. Also, the fact that these functions _may_ mutate the request/response should be noted.",Why do we need this?
+6879,"@@ -147,8 +147,8 @@ Rails.application.routes.draw do
+   get 'maintenance', to: 'abouts#maintenance'
+   get 'tools', to: 'abouts#tools'
+ 
+-  get 'p/compare', to: 'compares#projects', as: :compare_projects
+-  get 'p/project_graph', to: 'compares#projects_graph', as: :compare_graph_projects
++  get 'p/_compare', to: 'compares#projects', as: :compare_projects
++  get 'p/_project_graph', to: 'compares#projects_graph', as: :compare_graph_projects
+   get 'projects/:id/stacks', to: 'stacks#project_stacks', constraints: { format: /xml/ }
+   get 'p/:id/stacks', to: 'stacks#project_stacks', as: :project_stacks, constraints: { format: /xml/ }
+   get 'p/:id/stacks', to: redirect('/p/%{id}/users'), constraints: { format: /html/ }",Wasn't there a subsequent reason why we had to keep the `/p/project_graph` route? Outside references or is the proposed solution to the original proposal we us `/p/g` as the `compares#project_graph` route?,Line is too long. [8
+6880,"@@ -44,6 +44,14 @@ public class GenTest {
+         assertThat(gen.apply(RANDOM)).isEqualTo(3);
+     }
+ 
++    @Test
++    public void shouldCreateGenOfFixedValues() {
++        final Gen<Integer> gen = Gen.fixed(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++        assertThat(gen.apply(RANDOM)).isIn(1,2,3);
++    }
++
+     // -- random number generator (rng)
+ 
+     @Test",Any suggestions on how I would even _approach_ writing tests for arbitrary values....,Can you add a space after the comma?
+6881,"@@ -46,8 +46,8 @@ class Theme
+      */
+     protected static $editThemeCache = false;
+ 
+-    const ACTIVE_KEY = 'cms::theme.active';
+-    const EDIT_KEY = 'cms::theme.edit';
++    private const ACTIVE_KEY = 'cms::theme.active';
++    private const EDIT_KEY = 'cms::theme.edit';
+ 
+     /**
+      * Loads the theme.","Scope declarations for class constants was not added until 7.1, this will not be accepted.",Why did you change these to private?
+6882,"@@ -126,9 +126,11 @@ void TThreadedServer::onClientDisconnected(TConnectedClient* pClient) {
+   Synchronized sync(clientMonitor_);
+   drainDeadClients(); // use the outgoing thread to do some maintenance on our dead client backlog
+   ClientMap::iterator it = activeClientMap_.find(pClient);
+-  ClientMap::iterator end = it;
+-  deadClientMap_.insert(it, ++end);
+-  activeClientMap_.erase(it);
++  if (it != activeClientMap_.end()) {
++    ClientMap::iterator end = it;
++    deadClientMap_.insert(it, ++end);
++    activeClientMap_.erase(it);
++  }
+   if (activeClientMap_.empty()) {
+     clientMonitor_.notify();
+   }",The assertion here is that find should never return end() because this is the only mechanism that reaps items from the activeClientMap. If it == end something went horribly wrong.,Nit: `end` can be `const`.
+6883,"@@ -24,6 +24,12 @@ import (
+ 
+ // A Collection is a set of documents.
+ type Collection interface {
++	// Key returns the document key, or nil if the document doesn't have one. Key
++	// should not return an error if the key is missing unless the collection cannot
++	// generate a fresh key for a Create action.
++	// The returned key must be comparable.
++	Key(Document) (interface{}, error)
++
+ 	// RunActions executes a slice of actions.
+ 	//
+ 	// If unordered is false, it must appear as if the actions were executed in the","The `unless the collection ...` part reads a little bit hard, maybe separate into its own sentence and explain what it means by `cannot generate a fresh key`?",I don't think this is the right way 
+6884,"@@ -50,6 +50,9 @@ const (
+ 
+ 	// The feature is not implemented.
+ 	Unimplemented ErrorCode = 6
++
++	// The system was in the wrong state.
++	FailedPrecondition ErrorCode = 7
+ )
+ 
+ // Call ""go generate"" whenever you change the above list of error codes.",Doesn't `gcerr_string.go` need to be updated for this?,Should this be `FailedPrecondition`?
+6885,"@@ -2473,6 +2473,8 @@ func (c *Compiler) parseConvert(typeFrom, typeTo types.Type, value llvm.Value, p
+ 		switch elemType.Kind() {
+ 		case types.Byte:
+ 			return c.createRuntimeCall(""stringToBytes"", []llvm.Value{value}, """"), nil
++		case types.Rune:
++			return c.createRuntimeCall(""stringToRunes"", []llvm.Value{value}, """"), nil
+ 		default:
+ 			return llvm.Value{}, c.makeError(pos, ""todo: convert from string: ""+elemType.String())
+ 		}","Both cases allowed by the Go spec are now supported, so it's a bug in the compiler if we get here. You can replace the `todo:` error with a panic. (Note: getting here would be a bug because when we get to SSA level the code has long been type checked and has already been verified as being valid Go).",nit: `stringToRunes` -> `stringToByt
+6886,"@@ -551,6 +551,14 @@ class TabbedBrowser(tabwidget.TabWidget):
+                 return
+             widget.setFocus()
+ 
++    def load_prepared_history(self, idx):
++        tab = self.widget(idx)
++        if len(tab.history_prepared) > 0:
++            tab.history.load_items(tab.history_prepared)
++            tab.history_prepared = []
++        #end if
++    #end def load_prepared_history
++
+     @pyqtSlot(int)
+     def on_current_changed(self, idx):
+         """"""Set last-focused-tab and leave hinting mode when focus changed.""""""",You can simply do `if tab.history_prepared:` here as empty lists are falsey.,Please remove this line.
+6887,"@@ -25,6 +25,8 @@ import (
+ 
+ 	""github.com/jetstack/cert-manager/cmd/ctl/pkg/create""
+ 	""github.com/jetstack/cert-manager/cmd/ctl/pkg/create/certificatesigningrequest""
++
++	""github.com/jetstack/cert-manager/cmd/ctl/pkg/install""
+ )
+ 
+ func NewCmdExperimental(ctx context.Context, ioStreams genericclioptions.IOStreams, factory cmdutil.Factory) *cobra.Command {",Remove this whitespace,nit: remove empty line
+6888,"@@ -118,12 +118,14 @@ def preprocess_example_input(input_config):
+     input_path = input_config['input_path']
+     input_shape = input_config['input_shape']
+     one_img = mmcv.imread(input_path)
++    one_img = mmcv.imresize(one_img, input_shape[2:][::-1])
++    show_img = one_img.copy()
+     if 'normalize_cfg' in input_config.keys():
+         normalize_cfg = input_config['normalize_cfg']
+         mean = np.array(normalize_cfg['mean'], dtype=np.float32)
+         std = np.array(normalize_cfg['std'], dtype=np.float32)
+         one_img = mmcv.imnormalize(one_img, mean, std)
+-    one_img = mmcv.imresize(one_img, input_shape[2:][::-1]).transpose(2, 0, 1)
++    one_img = one_img.transpose(2, 0, 1)
+     one_img = torch.from_numpy(one_img).unsqueeze(0).float().requires_grad_(
+         True)
+     (_, C, H, W) = input_shape",`show_img` is not normalized while `one_img` is normalized. And line 139 pass `show_img` for pytorch2onnx function. Is this expected behavior?,Why do we need to copy?
+6889,"@@ -45,11 +45,11 @@ function init(instance) {
+             let inputOffset = /[-+]?\d+\.?\d*/g.exec(this.textContent);
+             if (inputOffset) {
+                 inputOffset = inputOffset[0];
++                inputOffset = parseFloat(inputOffset);
++                inputOffset = Math.min(30, Math.max(-30, inputOffset));
+ 
+                 // replace current text by considered offset
+                 this.textContent = inputOffset + 's';
+-
+-                inputOffset = parseFloat(inputOffset);
+                 // set new offset
+                 playbackManager.setSubtitleOffset(inputOffset, player);
+                 // synchronize with slider value",Why is this bounded between -30 and 30?,I think this should be 
+6890,"@@ -21,7 +21,7 @@ THE SOFTWARE.
+ */
+ 
+ /* HIT_START
+- * BUILD: %t %s ../../test_common.cpp EXCLUDE_HIP_PLATFORM all
++ * BUILD: %t %s ../../test_common.cpp EXCLUDE_HIP_PLATFORM nvcc
+  * TEST: %t
+  * HIT_END
+  */",I think even you can exclude to run it on nvcc,Why did you change this
+6891,"@@ -179,7 +179,7 @@ func CreateIstgtConf(cStorVolume *apis.CStorVolume) []byte {
+ 	buffer.WriteString(`
+   PhysRecordLength 4096
+ `)
+-	buffer.WriteString(""  LUN0 Storage "" + cStorVolume.Spec.Capacity + "" 32k"")
++	buffer.WriteString(""  LUN0 Storage "" + cStorVolume.Spec.Capacity.String() + "" 32k"")
+ 	buffer.WriteString(`
+   LUN0 Option Unmap Disable
+   LUN0 Option WZero Disable",G104: Errors unhandled. (from `gosec`),Why not use `.String()`
+6892,"@@ -182,6 +182,11 @@ class ECSTask(luigi.Task):
+         response = client.run_task(taskDefinition=self.task_def_arn,
+                                    overrides=overrides,
+                                    cluster=self.cluster)
++
++        if response['failures']:
++            raise Exception("", "".join([""fail to run task {0} reason: {1}"".format(failure['arn'], failure['reason'])
++                                       for failure in response['failures']]))
++
+         self._task_ids = [task['taskArn'] for task in response['tasks']]
+ 
+         # Wait on task completion","will `failure` always include `arn` and `reason` in its dictionary? If so, :+1:","I think this should be `raise Exception("", "".join([""fail to run task {0} reason: {1}"".format(failure['arn'], failure['reason']) for failure in response['failures']]))`"
+6893,"@@ -46,13 +46,13 @@ module Bolt
+         @logger = Logging.logger[self]
+       end
+ 
+-      def with_events(target, callback)
++      def with_events(target, callback, action)
+         callback&.call(type: :node_start, target: target)
+ 
+         result = begin
+                    yield
+                  rescue StandardError, NotImplementedError => e
+-                   Bolt::Result.from_exception(target, e)
++                   Bolt::Result.from_exception(target, e, action: action)
+                  end
+ 
+         callback&.call(type: :node_result, result: result)","Should this be optional, or default to 'action' as well?",I'm not sure if this is the right way to do this. I think it would be better to have a `with_events` method that takes a callback and an action.
+6894,"@@ -16,6 +16,12 @@ package client
+ import (
+ 	""context""
+ 
++	""github.com/pkg/errors""
++	""k8s.io/apimachinery/pkg/types""
++	ctrl ""sigs.k8s.io/controller-runtime""
++
++	""github.com/chaos-mesh/chaos-mesh/controllers/config""
++
+ 	""google.golang.org/grpc""
+ 	v1 ""k8s.io/api/core/v1""
+ 	""sigs.k8s.io/controller-runtime/pkg/client""",how about formating this import?,nit: remove empty line
+6895,"@@ -177,13 +177,14 @@ def getReviewPosition():
+ 		globalVars.reviewPosition,globalVars.reviewPositionObj=review.getPositionForCurrentMode(obj)
+ 		return globalVars.reviewPosition
+ 
+-def setReviewPosition(reviewPosition,clearNavigatorObject=True):
++def setReviewPosition(reviewPosition,clearNavigatorObject=True, isCaret=False):
+ 	""""""Sets a TextInfo instance as the review position. if clearNavigatorObject is true, It sets the current navigator object to None so that the next time the navigator object is asked for it fetches it from the review position.
+ 	""""""
+ 	globalVars.reviewPosition=reviewPosition.copy()
+ 	globalVars.reviewPositionObj=reviewPosition.obj
+ 	if clearNavigatorObject: globalVars.navigatorObject=None
+-	braille.handler.handleReviewMove()
++	eventHandler.lastReviewMoveDueToFollowing = isCaret
++	braille.handler.handleReviewMove(shouldAutoTether=not isCaret)
+ 
+ def getNavigatorObject():
+ 	""""""Gets the current navigator object. Navigator objects can be used to navigate around the operating system (with the number pad) with out moving the focus. If the navigator object is not set, it fetches it from the review position. ","Comma police. :) Also, the docstring needs updating.",Why do we need to pass `isCaret` here?
+6896,"@@ -51,6 +51,7 @@ type driver struct {
+ 	volume.QuiesceDriver
+ 	volume.CredsDriver
+ 	volume.CloudBackupDriver
++	volume.CloudMigrateDriver
+ 	kv          kvdb.Kvdb
+ 	thisCluster cluster.Cluster
+ }",Implement an in-memory implementation of this in the fake driver.,Why do we need this?
+6897,"@@ -0,0 +1,13 @@
++require 'spec_helper'
++
++describe 'shows/_show.html.erb' do
++  it 'includes published episodes count' do
++    show = create(:show)
++    create_list(:video, 2, :published, watchable: show)
++    create(:video, watchable: show)
++
++    render 'shows/show', show: show
++
++    expect(rendered).to include('2 episodes')
++  end
++end",Same question as the other view spec regarding not actually saving records.,Extra empty line det
+6898,"@@ -269,9 +269,9 @@ namespace NLog.Config
+                     factory.RegisterItemsFromAssembly(extensionAssembly);
+                     success = true;
+                 }
+-                catch (Exception)
++                catch (Exception ex)
+                 {
+-                    InternalLogger.Warn(""Auto loading assembly file: {0} failed! Skipping this file."", extensionDll);
++                    InternalLogger.Warn(ex, ""Auto loading assembly file: {0} failed! Skipping this file."", extensionDll);
+                 }
+                 if (success)
+                 {",Rethrow for `MustBeRethrown()`-exceptions?,I don't think this s
+6899,"@@ -43,11 +43,13 @@ class RandomSampler(BaseSampler):
+             Tensor or ndarray: sampled indices.
+         """"""
+         assert len(gallery) >= num
+-
+         is_tensor = isinstance(gallery, torch.Tensor)
+         if not is_tensor:
+-            gallery = torch.tensor(
+-                gallery, dtype=torch.long, device=torch.cuda.current_device())
++            if torch.cuda.is_available():
++                device = torch.cuda.current_device()
++            else:
++                device = 'cpu'
++            gallery = torch.tensor(gallery, dtype=torch.long, device=device)
+         perm = torch.randperm(gallery.numel(), device=gallery.device)[:num]
+         rand_inds = gallery[perm]
+         if not is_tensor:",May clean the unnecessary modification.,Why do we need this?
+6900,"@@ -227,8 +227,13 @@ AX_CODE_COVERAGE
+ AC_ARG_WITH([flux-security], AS_HELP_STRING([--with-flux-security],
+              [Build with flux-security]))
+ AS_IF([test ""x$with_flux_security"" = ""xyes""], [
+-    PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security], [], [])
++    PKG_CHECK_MODULES([FLUX_SECURITY], [flux-security],
++                      [flux_sec_incdir=`$PKG_CONFIG --variable=includedir flux-security`],
++                      [flux_sec_incdir=;])
++    AS_IF([test ""x$flux_sec_incdir"" = x],
++          [AC_MSG_ERROR([couldn't find flux-security or include directory])])
+     AC_DEFINE([HAVE_FLUX_SECURITY], [1], [Define flux-security is available])
++    AC_SUBST(FLUX_SECURITY_INCDIR, $flux_sec_incdir)
+ ])
+ AM_CONDITIONAL([HAVE_FLUX_SECURITY], [test ""x$with_flux_security"" = ""xyes""])
+ ",Should this line set the value to `x` since that is checked below?,Why do we need this?
+6901,"@@ -138,6 +138,14 @@ public interface DataFile {
+    */
+   DataFile copy();
+ 
++  /**
++   * Copies this {@link DataFile data file} without file stats. Manifest readers can reuse data file instances; use
++   * this method to copy data without stats when collecting files.
++   *
++   * @return a copy of this data file
++   */
++  DataFile slimCopy();
++
+   /**
+    * @return List of recommended split locations, if applicable, null otherwise.
+    * When available, this information is used for planning scan tasks whose boundaries","I don't particularly love the terminology here. Why not simply add `copy(boolean stats)` or a copy with an enum to indicate what portions of the datafile to include? At some point we may want just some of the values (e.g. CBO may want counts, but not lower/upper bounds). Just a thought.",nit: `slimCopy` -> `
+6902,"@@ -220,11 +220,12 @@ public final class QueryRequest {
+     public Builder parseAnnotationQuery(String annotationQuery) {
+       if (annotationQuery != null && !annotationQuery.isEmpty()) {
+         for (String ann : annotationQuery.split("" and "")) {
+-          if (ann.indexOf('=') == -1) {
++          int idx = ann.indexOf('=');
++          if (idx == -1) {
+             addAnnotation(ann);
+           } else {
+             String[] keyValue = ann.split(""="");
+-            addBinaryAnnotation(keyValue[0], keyValue.length < 2 ? """" :keyValue[1]);
++            addBinaryAnnotation(ann.substring(0, idx), keyValue.length < 2 ? """" : ann.substring(idx+1));
+           }
+         }
+       }",you could probably remove keyValue and just compare idx vs ann.length (ex I think the goal here is to ensure it works with a value like `foo=`,Why not use `StringU
+6903,"@@ -94,8 +94,8 @@ exports.getMimeType = (item) => {
+ }
+ 
+ exports.getId = (item) => {
+-  if (item.file_type && item.file_type === 'TIMELINE') {
+-    return `${encodeURIComponent(item.meeting_id)}__TIMELINE`
++  if (item.file_type && item.file_type === 'CC') {
++    return `${encodeURIComponent(item.meeting_id)}__CC__${encodeURIComponent(item.recording_start)}`
+   } else if (item.file_type) {
+     return `${encodeURIComponent(item.meeting_id)}__${encodeURIComponent(item.id)}`
+   }",we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting,This should be `__CC
+6904,"@@ -182,7 +182,6 @@ class KohaRest extends \VuFind\ILS\Driver\AbstractBase implements
+      */
+     protected $itemStatusMappings = [
+         'Item::Held' => 'On Hold',
+-        'Item::Lost' => 'Lost--Library Applied',
+         'Item::Waiting' => 'On Holdshelf',
+     ];
+ ",You've deleted this code but not added it anywhere else. Should this be used as my proposed example in the .ini file? Do we need a mechanism for configuring a global fallback string independent of the numeric codes?,Why did you remove this?
+6905,"@@ -46,6 +46,9 @@ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.ImmutableSet;
+ import com.google.protobuf.DescriptorProtos.FieldDescriptorProto.Type;
+ 
++import java.util.ArrayList;
++import java.util.Arrays;
++import java.util.Collections;
+ import java.util.List;
+ 
+ import javax.annotation.Nullable;",nit: strip away those imports? seems not used in the new code.,Why is this needed?
+6906,"@@ -25,8 +25,12 @@ import (
+ 	""os""
+ 	""time""
+ 
++	""github.com/ethereum/go-ethereum/common""
++
++	""github.com/ethereum/go-ethereum/accounts/abi/bind""
+ 	""github.com/ethereum/go-ethereum/core/types""
+ 	""github.com/ethereum/go-ethereum/ethclient""
++	""github.com/mysteriumnetwork/node/blockchain/generated""
+ 	""github.com/mysteriumnetwork/payments/cli/helpers""
+ 	""github.com/mysteriumnetwork/payments/contracts/abigen""
+ 	""github.com/mysteriumnetwork/payments/mysttoken""",redundant whitespace :octocat:,This import should be gr
+6907,"@@ -698,7 +698,8 @@ class TestCloudFormationSetStackPolicy(CloudFormationConnectionBase):
+         self.set_http_response(status_code=200)
+         api_response = self.service_connection.set_stack_policy('stack-id',
+             stack_policy_body='{}')
+-        self.assertEqual(api_response['Some'], 'content')
++        self.assertDictEqual(api_response, {'SetStackPolicyResult': {'Some': 'content'}})
++        self.assertIsInstance(api_response, dict)
+         self.assert_request_parameters({
+             'Action': 'SetStackPolicy',
+             'ContentType': 'JSON',","I don't believe that the `assertDictEqual` call can pass without `api_response` being a `dict`, so this second check isn't needed!",Why is this change neede
+6908,"@@ -213,8 +213,10 @@ static h2o_iovec_t *decode_string(h2o_mem_pool_t *pool, const uint8_t **src, con
+         if (len > src_end - *src)
+             return NULL;
+         ret = alloc_buf(pool, len * 2); /* max compression ratio is >= 0.5 */
+-        if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_header_name, err_desc)) == SIZE_MAX)
++        if ((ret->len = h2o_hpack_decode_huffman(ret->base, *src, len, is_header_name, err_desc)) == SIZE_MAX) {
++            h2o_mem_release_shared(ret);
+             return NULL;
++        }
+         ret->base[ret->len] = '\0';
+     } else {
+         if (len > src_end - *src)","Fuzzer did not like this change. Looks like I misunderstood how the pool works... if allocated from a pool we should never free it manually, right? I think I'll need to drop this patch.",Shouldn't this be `h2o_mem_release_shared(ret)`?
+6909,"@@ -4,16 +4,13 @@ import javafx.beans.property.ObjectProperty;
+ import javafx.beans.property.SimpleObjectProperty;
+ import javafx.scene.control.Alert;
+ import javafx.scene.control.ButtonType;
+-import javafx.scene.control.Label;
+-import javafx.scene.layout.Region;
+-import javafx.stage.Window;
+ 
+ import java.util.Optional;
+ 
+ /**
+- * A confirm dialog with two callbacks
++ * An abstract class for confirm dialogs with two callbacks
+  */
+-public class ConfirmDialog extends Alert {
++public abstract class ConfirmDialog extends Alert {
+     /**
+      * Callback for {@link ButtonType#OK} button events
+      */","Wouldn't it make sense to already have title, owner etc in this class?",Why is this abstract?
+6910,"@@ -18,6 +18,19 @@ module Faker
+         def character
+           fetch('aqua_teen_hunger_force.character')
+         end
++
++        ##
++        # Produces a perl of great AHTF wisdom
++        #
++        # @return [String]
++        #
++        # @example
++        #   Faker::TvShows::AquaTeenHungerForce.quote #=> ""Friendship ain't about trust. Friendship's about nunchucks.""
++        #
++        # @faker.version 1.8.5
++        def quote
++          fetch('aqua_teen_hunger_force.quote')
++        end
+       end
+     end
+   end",New generators should have version `next`,Trailing whitespace detected.
+6911,"@@ -204,6 +204,8 @@ public class ProcessBesuNodeRunner implements BesuNodeRunner {
+         params.add(""--metrics-category"");
+         params.add(((Enum<?>) category).name());
+       }
++      params.add(""--metrics-protocol"");
++      params.add(metricsConfiguration.getProtocol().name());
+       if (metricsConfiguration.isPushEnabled()) {
+         params.add(""--metrics-push-enabled"");
+         params.add(""--metrics-push-host"");",Wrap these two lines inside an `if (node.isMetricsEnabled() || metricsConfiguration.isPushEnabled()) { ... }`,I think this should be `--metrics-protocol`
+6912,"@@ -85,13 +85,14 @@ class FPN(BaseModule):
+         self.fp16_enabled = False
+         self.upsample_cfg = upsample_cfg.copy()
+ 
+-        if end_level == -1:
++        if end_level == -1 or end_level == self.num_ins:
++            # if end_level == len(inputs) or end_level == -1, extra level is allowed
+             self.backbone_end_level = self.num_ins
+             assert num_outs >= self.num_ins - start_level
+         else:
+             # if end_level < inputs, no extra level is allowed
+             self.backbone_end_level = end_level
+-            assert end_level <= len(in_channels)
++            assert end_level < len(in_channels)
+             assert num_outs == end_level - start_level
+         self.start_level = start_level
+         self.end_level = end_level",if end_level == -1 or end_level == (self.num_ins - 1): for end_level is the Index of the end input backbone level.,why this change?
+6913,"@@ -33,6 +33,17 @@ namespace Nethermind.Store
+         public bool IsLeaf { get; }
+         public bool IsExtension => !IsLeaf;
+ 
++        public int Size
++        {
++            get
++            {
++                const int refSize = sizeof(long);
++                const int arrayOverhead = sizeof(long);
++                return refSize + Path.Length + arrayOverhead
++                    + 4 /* aligned bools */;
++            }
++        }
++
+         public byte[] ToBytes()
+         {
+             byte[] output = new byte[Path.Length / 2 + 1];",No CLR overhead?,Why do we need t
+6914,"@@ -414,6 +414,18 @@ func TestCreateInstanceValidateMachineType(t *testing.T) {
+ 	p := ""project""
+ 	z := ""zone""
+ 
++	_, c, err := daisyCompute.NewTestClient(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
++		if r.Method == ""GET"" && r.URL.String() == ""/project/zones/zone/machineTypes/mt?alt=json"" {
++			fmt.Fprintln(w, `{}`)
++		} else {
++			w.WriteHeader(http.StatusBadRequest)
++			fmt.Fprintf(w, ""bad request: %+v"", r)
++		}
++	}))
++	if err != nil {
++		t.Fatalf(""error creating test client: %v"", err)
++	}
++
+ 	tests := []struct {
+ 		desc      string
+ 		mt        string",Consider faking the TestClient's GetProject/GetZone/GetMachine methods.,nit: `fmt.Fprint
+6915,"@@ -88,13 +88,15 @@ func AddHeader(key, value string) OutboundOption {
+ 	}
+ }
+ 
+-// NewOutbound builds an HTTP outbound which sends requests to peers supplied
++// NewOutbound builds an HTTP outbound that sends requests to peers supplied
+ // by the given peer.Chooser. The URL template for used for the different
+ // peers may be customized using the URLTemplate option.
+ //
+-// Peer Choosers used with the HTTP outbound MUST yield *hostport.Peer
+-// objects. Also note that the Chooser MUST have started before Outbound.Start
+-// is called.
++// The peer chooser and outbound must share the same transport, in this case
++// the HTTP transport.
++// The peer chooser must use the transport's RetainPeer to obtain peer
++// instances and return those peers to the outbound when it calls Choose.
++// The concrete peer type is private and intrinsic to the HTTP transport.
+ func (t *Transport) NewOutbound(chooser peer.Chooser, opts ...OutboundOption) *Outbound {
+ 	o := &Outbound{
+ 		once:        sync.Once(),",Returning a private type as part of the public API? Isn't this impossible for users to implement?,"""must use the tr"
+6916,"@@ -422,9 +422,9 @@ std::string MolToSmiles(const ROMol &mol, bool doIsomericSmiles, bool doKekule,
+     if (canonical) {
+       if (tmol->hasProp(""_canonicalRankingNumbers"")) {
+         for (unsigned int i = 0; i < tmol->getNumAtoms(); ++i) {
+-          unsigned int rankNum;
+-          tmol->getAtomWithIdx(i)
+-              ->getPropIfPresent(""_canonicalRankingNumber"", rankNum);
++          unsigned int rankNum = 0;
++          tmol->getAtomWithIdx(i)->getPropIfPresent(""_canonicalRankingNumber"",
++                                                    rankNum);
+           ranks[i] = rankNum;
+         }
+       } else {","prefer common_properties::_canonicalRankingNumber if possible, should be quicker in general.",Why is this change needed?
+6917,"@@ -52,6 +52,8 @@ class AnchorHead(nn.Module):
+                      loss_weight=1.0),
+                  loss_bbox=dict(
+                      type='SmoothL1Loss', beta=1.0 / 9.0, loss_weight=1.0),
++                 loss_normalizer=-1,
++                 loss_normalizer_momentum=0.9,
+                  train_cfg=None,
+                  test_cfg=None):
+         super(AnchorHead, self).__init__()",The meaning of `loss_normalizer` and `loss_normalizer_momentum` should be reflected in docstring.,I don't think we need the 
+6918,"@@ -87,11 +87,16 @@ static void init_async(h2o_multithread_queue_t *queue, h2o_loop_t *loop)
+ {
+     int fds[2];
+ 
++#ifndef _WIN32
+     if (cloexec_pipe(fds) != 0) {
+         perror(""pipe"");
+         abort();
+     }
+     fcntl(fds[1], F_SETFL, O_NONBLOCK);
++#else
++    u_long nonblock = 1;
++    ioctlsocket(fds[1], FIONBIO, &nonblock);
++#endif
+     queue->async.write = fds[1];
+     queue->async.read = h2o_evloop_socket_create(loop, fds[0], NULL, 0, 0);
+     queue->async.read->data = queue;",Call to `cloexec_pipe` (or an equivalent function) is missing. I presume that this is the reason why you are seeing timeout errors.,Why is this needed?
+6919,"@@ -26,11 +26,7 @@ import org.springframework.security.oauth2.jwt.Jwt;
+ 
+ import java.time.Duration;
+ import java.time.Instant;
+-import java.util.Arrays;
+-import java.util.Collection;
+-import java.util.Collections;
+-import java.util.HashMap;
+-import java.util.Map;
++import java.util.*;
+ 
+ import static org.assertj.core.api.Assertions.assertThat;
+ import static org.assertj.core.api.Assertions.assertThatThrownBy;",There are no changes in this file. Please reset.,Don't use star imports.
+6920,"@@ -731,9 +731,11 @@ def nullDistribution(verbosity=0):
+ 
+ def normalProbability(x, distributionParams):
+   """"""
+-  Given the normal distribution specified by the mean and standard deviation in
+-  distributionParams, return the probability of getting samples > x.
+-  This is the Q-function: the tail probability of the normal distribution.
++  Given the normal distribution specified by the mean and standard deviation
++  in distributionParams, return the probability of getting samples further
++  from the mean. For values above the mean, this is the probability of getting
++  samples > x and for values below the mean, the probability of getting
++  samples < x. This is the Q-function: the tail probability of the normal distribution.
+ 
+   :param distributionParams: dict with 'mean' and 'stdev' of the distribution
+   """"""",Should we rename this to tailProbability?,I don't think you need to capitalize the first letter of the sentence.
+6921,"@@ -431,6 +431,9 @@ drutil_insert_get_mem_addr_arm(void *drcontext, instrlist_t *bb, instr_t *where,
+             index = replace_stolen_reg(drcontext, bb, where, memref, dst, scratch,
+                                        scratch_used);
+         }
++        if (opnd_get_base_aligned(memref)) {
++            // TODO
++        }
+         if (index == REG_NULL && opnd_get_disp(memref) != 0) {
+             /* first try ""add dst, base, #disp"" */
+             instr = negated",Add the issue number too i#4400,Is this TODO still relevant?
+6922,"@@ -373,7 +373,7 @@ abstract class BaseFile<F>
+     if (list != null) {
+       List<E> copy = Lists.newArrayListWithExpectedSize(list.size());
+       copy.addAll(list);
+-      return Collections.unmodifiableList(copy);
++      return copy;
+     }
+     return null;
+   }",Why make this modifiable?,Why this change?
+6923,"@@ -8,13 +8,11 @@ package blockchain
+ 
+ const (
+ 	// Erc721Binary a simple erc721 token bin
+-	Erc721Binary=""60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a700000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b5050620002c5565b7fffffffff000000000000000000000000000000000000000000000000000000008082161415620001e357600080fd5b7fffffffff00000000000000000000000000000000000000000000000000000000166000908152602081905260409020805460ff19166001179055565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f106200026357805160ff191683800117855562000293565b8280016001018555821562000293579182015b828111156200029357825182559160200191906001019062000276565b50620002a1929150620002a5565b5090565b620002c291905b80821115620002a15760008155600101620002ac565b90565b611b2480620002d56000396000f3006080604052600436106101275763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166301ffc9a7811461012c57806306fdde0314610162578063081812fc146101ec578063095ea7b31461022057806318160ddd1461024657806319fa8f501461026d57806323b872dd1461029f5780632f745c59146102c957806342842e0e146102ed5780634f558e79146103175780634f6ccce71461032f5780636352211e1461034757806370a082311461035f5780638462151c146103805780639507d39a146103f157806395d89b411461045f578063a22cb46514610474578063b88d4fde1461049a578063c87b56dd14610509578063e985e9c514610521578063efc81a8c14610548578063fdb05e851461055d575b600080fd5b34801561013857600080fd5b5061014e600160e060020a031960043516610581565b604080519115158252519081900360200190f35b34801561016e57600080fd5b506101776105a0565b6040805160208082528351818301528351919283929083019185019080838360005b838110156101b1578181015183820152602001610199565b50505050905090810190601f1680156101de5780820380516001836020036101000a031916815260200191505b509250505060405180910390f35b3480156101f857600080fd5b50610204600435610637565b60408051600160a060020a039092168252519081900360200190f35b34801561022c57600080fd5b50610244600160a060020a0360043516602435610652565b005b34801561025257600080fd5b5061025b610708565b60408051918252519081900360200190f35b34801561027957600080fd5b5061028261070e565b60408051600160e060020a03199092168252519081900360200190f35b3480156102ab57600080fd5b50610244600160a060020a0360043581169060243516604435610732565b3480156102d557600080fd5b5061025b600160a060020a03600435166024356107d5565b3480156102f957600080fd5b50610244600160a060020a0360043581169060243516604435610822565b34801561032357600080fd5b5061014e600435610843565b34801561033b57600080fd5b5061025b600435610860565b34801561035357600080fd5b50610204600435610895565b34801561036b57600080fd5b5061025b600160a060020a03600435166108bf565b34801561038c57600080fd5b506103a1600160a060020a03600435166108f2565b60408051602080825283518183015283519192839290830191858101910280838360005b838110156103dd5781810151838201526020016103c5565b505050509050019250505060405180910390f35b3480156103fd57600080fd5b5061040960043561095e565b60408051600160a060020a03909816885260ff9687166020890152948616878601529285166060870152908416608086015290921660a084015267ffffffffffffffff90911660c0830152519081900360e00190f35b34801561046b57600080fd5b50610177610a91565b34801561048057600080fd5b50610244600160a060020a03600435166024351515610af2565b3480156104a657600080fd5b50604080516020601f60643560048181013592830184900484028501840190955281845261024494600160a060020a038135811695602480359092169560443595369560849401918190840183828082843750949750610b769650505050505050565b34801561051557600080fd5b50610177600435610b9e565b34801561052d57600080fd5b5061014e600160a060020a0360043581169060243516610c49565b34801561055457600080fd5b5061025b610c77565b34801561056957600080fd5b50610244600160a060020a0360043516602435610ffb565b600160e060020a03191660009081526020819052604090205460ff1690565b60058054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b820191906000526020600020905b81548152906001019060200180831161060f57829003601f168201915b505050505090505b90565b600090815260026020526040902054600160a060020a031690565b600061065d82610895565b9050600160a060020a03838116908216141561067857600080fd5b33600160a060020a038216148061069457506106948133610c49565b151561069f57600080fd5b600082815260026020526040808220805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a0387811691821790925591518593918516917f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92591a4505050565b60095490565b7f01ffc9a70000000000000000000000000000000000000000000000000000000081565b61073c3382611043565b151561074757600080fd5b600160a060020a038316151561075c57600080fd5b600160a060020a038216151561077157600080fd5b61077b83826110a2565b6107858382611113565b61078f828261121a565b8082600160a060020a031684600160a060020a03167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef60405160405180910390a4505050565b60006107e0836108bf565b82106107eb57600080fd5b600160a060020a038316600090815260076020526040902080548390811061080f57fe5b9060005260206000200154905092915050565b61083e8383836020604051908101604052806000815250610b76565b505050565b600090815260016020526040902054600160a060020a0316151590565b600061086a610708565b821061087557600080fd5b600980548390811061088357fe5b90600052602060002001549050919050565b600081815260016020526040812054600160a060020a03168015156108b957600080fd5b92915050565b6000600160a060020a03821615156108d657600080fd5b50600160a060020a031660009081526003602052604090205490565b600160a060020a03811660009081526007602090815260409182902080548351818402810184019094528084526060939283018282801561095257602002820191906000526020600020905b81548152602001906001019080831161093e575b50505050509050919050565b600081815260016020526040812054600c8054839283928392839283928392600160a060020a03909216918a90811061099357fe5b600091825260209091200154600c805460ff909216918b9081106109b357fe5b9060005260206000200160000160019054906101000a900460ff16600c8b8154811015156109dd57fe5b9060005260206000200160000160029054906101000a900460ff16600c8c815481101515610a0757fe5b9060005260206000200160000160039054906101000a900460ff16600c8d815481101515610a3157fe5b9060005260206000200160000160049054906101000a900460ff16600c8e815481101515610a5b57fe5b600091825260209091200154959e949d50929b50909950975095506501000000000090910467ffffffffffffffff169350915050565b60068054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b600160a060020a038216331415610b0857600080fd5b336000818152600460209081526040808320600160a060020a03871680855290835292819020805460ff1916861515908117909155815190815290519293927f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c31929181900390910190a35050565b610b81848484610732565b610b8d84848484611263565b1515610b9857600080fd5b50505050565b6060610ba982610843565b1515610bb457600080fd5b6000828152600b602090815260409182902080548351601f6002600019610100600186161502019093169290920491820184900484028101840190945280845290918301828280156109525780601f10610c1c57610100808354040283529160200191610952565b820191906000526020600020905b815481529060010190602001808311610c2a5750939695505050505050565b600160a060020a03918216600090815260046020908152604080832093909416825291909152205460ff1690565b60008060008060008060006060610c8c611a07565b610c94610708565b6040805160208082019390935260001943014081830152815180820383018152606090910191829052805190928291908401908083835b60208310610cea5780518252601f199092019160209182019101610ccb565b5181516020939093036101000a600019018019909116921691909117905260405192018290039091209a5060059250505060f860020a60008a901a81020460ff16066001908101975060059089901a60f860020a0260f860020a900460ff16811515610d5257fe5b066001019550600560f860020a60028a901a81020460ff16066001019450600560f860020a60038a901a81020460ff16066001019350600560f860020a60048a901a81020460ff16066001019250610dad87878787876113d0565b6040805160c08101825260ff808b16825289811660208301908152898216938301938452888216606084019081528883166080850190815267ffffffffffffffff43811660a08701908152600c805460018101825560009190915287517fdf6966c971051c3d54ec59162606531493a51404a002842f56009d7e5cf4a8c78201805497519a5196519551935190941665010000000000026cffffffffffffffff0000000000199389166401000000000264ff0000000019968a1663010000000263ff00000019988b16620100000262ff0000199d8c166101000261ff001995909c1660ff19909b169a909a1793909316999099179a909a16969096179490941694909417919091169390931791909116939093179055909a509092509050610ed5338a61152d565b610edf898361157c565b33600160a060020a03167f1ae41272ced32fa050dc3df49761e279866a7a9378212de7a61104821698f18c8a89898989898860a001518a604051808981526020018860ff1660ff1681526020018760ff1660ff1681526020018660ff1660ff1681526020018560ff1660ff1681526020018460ff1660ff1681526020018367ffffffffffffffff1667ffffffffffffffff16815260200180602001828103825283818151815260200191508051906020019080838360005b83811015610faf578181015183820152602001610f97565b50505050905090810190601f168015610fdc5780820380516001836020036101000a031916815260200191505b50995050505050505050505060405180910390a2505050505050505090565b60408051808201909152600481527f74657374000000000000000000000000000000000000000000000000000000006020820152611039838361152d565b61083e828261157c565b60008061104f83610895565b905080600160a060020a031684600160a060020a0316148061108a575083600160a060020a031661107f84610637565b600160a060020a0316145b8061109a575061109a8185610c49565b949350505050565b81600160a060020a03166110b582610895565b600160a060020a0316146110c857600080fd5b600081815260026020526040902054600160a060020a03161561110f576000818152600260205260409020805473ffffffffffffffffffffffffffffffffffffffff191690555b5050565b600080600061112285856115af565b600084815260086020908152604080832054600160a060020a038916845260079092529091205490935061115d90600163ffffffff61164516565b600160a060020a03861660009081526007602052604090208054919350908390811061118557fe5b90600052602060002001549050806007600087600160a060020a0316600160a060020a03168152602001908152602001600020848154811015156111c557fe5b6000918252602080832090910192909255600160a060020a03871681526007909152604090208054906111fc906000198301611a3c565b50600093845260086020526040808520859055908452909220555050565b60006112268383611657565b50600160a060020a039091166000908152600760209081526040808320805460018101825590845282842081018590559383526008909152902055565b60008061127885600160a060020a03166116e7565b151561128757600191506113c7565b6040517f150b7a020000000000000000000000000000000000000000000000000000000081523360048201818152600160a060020a03898116602485015260448401889052608060648501908152875160848601528751918a169463150b7a0294938c938b938b93909160a490910190602085019080838360005b8381101561131a578181015183820152602001611302565b50505050905090810190601f1680156113475780820380516001836020036101000a031916815260200191505b5095505050505050602060405180830381600087803b15801561136957600080fd5b505af115801561137d573d6000803e3d6000fd5b505050506040513d602081101561139357600080fd5b5051600160e060020a031981167f150b7a020000000000000000000000000000000000000000000000000000000014925090505b50949350505050565b6040805180820190915260208082527f68747470733a2f2f6e66746965732e696f2f746f6b656e732f6e66746965732d9082015260609061141181886116ef565b90506114398160408051908101604052806001815260200160f860020a602d02815250611880565b905061144581876116ef565b905061146d8160408051908101604052806001815260200160f860020a602d02815250611880565b905061147981866116ef565b90506114a18160408051908101604052806001815260200160f860020a602d02815250611880565b90506114ad81856116ef565b90506114d58160408051908101604052806001815260200160f860020a602d02815250611880565b90506114e181846116ef565b9050611522816040805190810160405280600481526020017f2e706e6700000000000000000000000000000000000000000000000000000000815250611880565b979650505050505050565b611537828261199f565b600980546000838152600a60205260408120829055600182018355919091527f6e1540171b6c0c960b71a7020d9f60077f6af931a8bbf590da0223dacf75c7af015550565b61158582610843565b151561159057600080fd5b6000828152600b60209081526040909120825161083e92840190611a60565b81600160a060020a03166115c282610895565b600160a060020a0316146115d557600080fd5b600160a060020a0382166000908152600360205260409020546115ff90600163ffffffff61164516565b600160a060020a03909216600090815260036020908152604080832094909455918152600190915220805473ffffffffffffffffffffffffffffffffffffffff19169055565b60008282111561165157fe5b50900390565b600081815260016020526040902054600160a060020a03161561167957600080fd5b6000818152600160208181526040808420805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a03881690811790915584526003909152909120546116c7916119fa565b600160a060020a0390921660009081526003602052604090209190915550565b6000903b1190565b60408051606480825260a0820190925260609190829060009081908390819083908760208201610c8080388339019050509550600094505b60ff89161561177c578551600a60ff9a8b168181049b60018901989290910616955060f860020a603087010291889190811061175f57fe5b906020010190600160f860020a031916908160001a905350611727565b899250848351016040519080825280601f01601f1916602001820160405280156117b0578160200160208202803883390190505b509150600090505b82518110156118105782818151811015156117cf57fe5b90602001015160f860020a900460f860020a0282828151811015156117f057fe5b906020010190600160f860020a031916908160001a9053506001016117b8565b5060005b84811015611873578581600187030381518110151561182f57fe5b90602001015160f860020a900460f860020a02828451830181518110151561185357fe5b906020010190600160f860020a031916908160001a905350600101611814565b5098975050505050505050565b606080606080606060008088955087945084518651016040519080825280601f01601f1916602001820160405280156118c3578160200160208202803883390190505b50935083925060009150600090505b85518110156119305785818151811015156118e957fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561191057fe5b906020010190600160f860020a031916908160001a9053506001016118d2565b5060005b845181101561199257848181518110151561194b57fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561197257fe5b906020010190600160f860020a031916908160001a905350600101611934565b5090979650505050505050565b600160a060020a03821615156119b457600080fd5b6119be828261121a565b6040518190600160a060020a038416906000907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b818101828110156108b957fe5b6040805160c081018252600080825260208201819052918101829052606081018290526080810182905260a081019190915290565b81548183558181111561083e5760008381526020902061083e918101908301611ade565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f10611aa157805160ff1916838001178555611ace565b82800160010185558215611ace579182015b82811115611ace578251825591602001919060010190611ab3565b50611ada929150611ade565b5090565b61063491905b80821115611ada5760008155600101611ae45600a165627a7a72305820eb6ef4caf7e8dfb40d659802d0d7106ab4b338205d58c4b1d0596c47c740a77e0029""
++	Erc721Binary = ""60806040523480156200001157600080fd5b5060408051808201825260068082527f4e6674696573000000000000000000000000000000000000000000000000000060208084019190915283518085019094529083527f4e465449455300000000000000000000000000000000000000000000000000009083015290620000af7f01ffc9a700000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620000e37f80ac58cd00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001177f4f558e7900000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b81516200012c90600590602085019062000220565b5080516200014290600690602084019062000220565b50620001777f780e9d6300000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b620001ab7f5b5e139f00000000000000000000000000000000000000000000000000000000640100000000620001b3810204565b5050620002c5565b7fffffffff000000000000000000000000000000000000000000000000000000008082161415620001e357600080fd5b7fffffffff00000000000000000000000000000000000000000000000000000000166000908152602081905260409020805460ff19166001179055565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f106200026357805160ff191683800117855562000293565b8280016001018555821562000293579182015b828111156200029357825182559160200191906001019062000276565b50620002a1929150620002a5565b5090565b620002c291905b80821115620002a15760008155600101620002ac565b90565b611b2480620002d56000396000f3006080604052600436106101275763ffffffff7c010000000000000000000000000000000000000000000000000000000060003504166301ffc9a7811461012c57806306fdde0314610162578063081812fc146101ec578063095ea7b31461022057806318160ddd1461024657806319fa8f501461026d57806323b872dd1461029f5780632f745c59146102c957806342842e0e146102ed5780634f558e79146103175780634f6ccce71461032f5780636352211e1461034757806370a082311461035f5780638462151c146103805780639507d39a146103f157806395d89b411461045f578063a22cb46514610474578063b88d4fde1461049a578063c87b56dd14610509578063e985e9c514610521578063efc81a8c14610548578063fdb05e851461055d575b600080fd5b34801561013857600080fd5b5061014e600160e060020a031960043516610581565b604080519115158252519081900360200190f35b34801561016e57600080fd5b506101776105a0565b6040805160208082528351818301528351919283929083019185019080838360005b838110156101b1578181015183820152602001610199565b50505050905090810190601f1680156101de5780820380516001836020036101000a031916815260200191505b509250505060405180910390f35b3480156101f857600080fd5b50610204600435610637565b60408051600160a060020a039092168252519081900360200190f35b34801561022c57600080fd5b50610244600160a060020a0360043516602435610652565b005b34801561025257600080fd5b5061025b610708565b60408051918252519081900360200190f35b34801561027957600080fd5b5061028261070e565b60408051600160e060020a03199092168252519081900360200190f35b3480156102ab57600080fd5b50610244600160a060020a0360043581169060243516604435610732565b3480156102d557600080fd5b5061025b600160a060020a03600435166024356107d5565b3480156102f957600080fd5b50610244600160a060020a0360043581169060243516604435610822565b34801561032357600080fd5b5061014e600435610843565b34801561033b57600080fd5b5061025b600435610860565b34801561035357600080fd5b50610204600435610895565b34801561036b57600080fd5b5061025b600160a060020a03600435166108bf565b34801561038c57600080fd5b506103a1600160a060020a03600435166108f2565b60408051602080825283518183015283519192839290830191858101910280838360005b838110156103dd5781810151838201526020016103c5565b505050509050019250505060405180910390f35b3480156103fd57600080fd5b5061040960043561095e565b60408051600160a060020a03909816885260ff9687166020890152948616878601529285166060870152908416608086015290921660a084015267ffffffffffffffff90911660c0830152519081900360e00190f35b34801561046b57600080fd5b50610177610a91565b34801561048057600080fd5b50610244600160a060020a03600435166024351515610af2565b3480156104a657600080fd5b50604080516020601f60643560048181013592830184900484028501840190955281845261024494600160a060020a038135811695602480359092169560443595369560849401918190840183828082843750949750610b769650505050505050565b34801561051557600080fd5b50610177600435610b9e565b34801561052d57600080fd5b5061014e600160a060020a0360043581169060243516610c49565b34801561055457600080fd5b5061025b610c77565b34801561056957600080fd5b50610244600160a060020a0360043516602435610ffb565b600160e060020a03191660009081526020819052604090205460ff1690565b60058054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b820191906000526020600020905b81548152906001019060200180831161060f57829003601f168201915b505050505090505b90565b600090815260026020526040902054600160a060020a031690565b600061065d82610895565b9050600160a060020a03838116908216141561067857600080fd5b33600160a060020a038216148061069457506106948133610c49565b151561069f57600080fd5b600082815260026020526040808220805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a0387811691821790925591518593918516917f8c5be1e5ebec7d5bd14f71427d1e84f3dd0314c0f7b2291e5b200ac8c7c3b92591a4505050565b60095490565b7f01ffc9a70000000000000000000000000000000000000000000000000000000081565b61073c3382611043565b151561074757600080fd5b600160a060020a038316151561075c57600080fd5b600160a060020a038216151561077157600080fd5b61077b83826110a2565b6107858382611113565b61078f828261121a565b8082600160a060020a031684600160a060020a03167fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef60405160405180910390a4505050565b60006107e0836108bf565b82106107eb57600080fd5b600160a060020a038316600090815260076020526040902080548390811061080f57fe5b9060005260206000200154905092915050565b61083e8383836020604051908101604052806000815250610b76565b505050565b600090815260016020526040902054600160a060020a0316151590565b600061086a610708565b821061087557600080fd5b600980548390811061088357fe5b90600052602060002001549050919050565b600081815260016020526040812054600160a060020a03168015156108b957600080fd5b92915050565b6000600160a060020a03821615156108d657600080fd5b50600160a060020a031660009081526003602052604090205490565b600160a060020a03811660009081526007602090815260409182902080548351818402810184019094528084526060939283018282801561095257602002820191906000526020600020905b81548152602001906001019080831161093e575b50505050509050919050565b600081815260016020526040812054600c8054839283928392839283928392600160a060020a03909216918a90811061099357fe5b600091825260209091200154600c805460ff909216918b9081106109b357fe5b9060005260206000200160000160019054906101000a900460ff16600c8b8154811015156109dd57fe5b9060005260206000200160000160029054906101000a900460ff16600c8c815481101515610a0757fe5b9060005260206000200160000160039054906101000a900460ff16600c8d815481101515610a3157fe5b9060005260206000200160000160049054906101000a900460ff16600c8e815481101515610a5b57fe5b600091825260209091200154959e949d50929b50909950975095506501000000000090910467ffffffffffffffff169350915050565b60068054604080516020601f600260001961010060018816150201909516949094049384018190048102820181019092528281526060939092909183018282801561062c5780601f106106015761010080835404028352916020019161062c565b600160a060020a038216331415610b0857600080fd5b336000818152600460209081526040808320600160a060020a03871680855290835292819020805460ff1916861515908117909155815190815290519293927f17307eab39ab6107e8899845ad3d59bd9653f200f220920489ca2b5937696c31929181900390910190a35050565b610b81848484610732565b610b8d84848484611263565b1515610b9857600080fd5b50505050565b6060610ba982610843565b1515610bb457600080fd5b6000828152600b602090815260409182902080548351601f6002600019610100600186161502019093169290920491820184900484028101840190945280845290918301828280156109525780601f10610c1c57610100808354040283529160200191610952565b820191906000526020600020905b815481529060010190602001808311610c2a5750939695505050505050565b600160a060020a03918216600090815260046020908152604080832093909416825291909152205460ff1690565b60008060008060008060006060610c8c611a07565b610c94610708565b6040805160208082019390935260001943014081830152815180820383018152606090910191829052805190928291908401908083835b60208310610cea5780518252601f199092019160209182019101610ccb565b5181516020939093036101000a600019018019909116921691909117905260405192018290039091209a5060059250505060f860020a60008a901a81020460ff16066001908101975060059089901a60f860020a0260f860020a900460ff16811515610d5257fe5b066001019550600560f860020a60028a901a81020460ff16066001019450600560f860020a60038a901a81020460ff16066001019350600560f860020a60048a901a81020460ff16066001019250610dad87878787876113d0565b6040805160c08101825260ff808b16825289811660208301908152898216938301938452888216606084019081528883166080850190815267ffffffffffffffff43811660a08701908152600c805460018101825560009190915287517fdf6966c971051c3d54ec59162606531493a51404a002842f56009d7e5cf4a8c78201805497519a5196519551935190941665010000000000026cffffffffffffffff0000000000199389166401000000000264ff0000000019968a1663010000000263ff00000019988b16620100000262ff0000199d8c166101000261ff001995909c1660ff19909b169a909a1793909316999099179a909a16969096179490941694909417919091169390931791909116939093179055909a509092509050610ed5338a61152d565b610edf898361157c565b33600160a060020a03167f1ae41272ced32fa050dc3df49761e279866a7a9378212de7a61104821698f18c8a89898989898860a001518a604051808981526020018860ff1660ff1681526020018760ff1660ff1681526020018660ff1660ff1681526020018560ff1660ff1681526020018460ff1660ff1681526020018367ffffffffffffffff1667ffffffffffffffff16815260200180602001828103825283818151815260200191508051906020019080838360005b83811015610faf578181015183820152602001610f97565b50505050905090810190601f168015610fdc5780820380516001836020036101000a031916815260200191505b50995050505050505050505060405180910390a2505050505050505090565b60408051808201909152600481527f74657374000000000000000000000000000000000000000000000000000000006020820152611039838361152d565b61083e828261157c565b60008061104f83610895565b905080600160a060020a031684600160a060020a0316148061108a575083600160a060020a031661107f84610637565b600160a060020a0316145b8061109a575061109a8185610c49565b949350505050565b81600160a060020a03166110b582610895565b600160a060020a0316146110c857600080fd5b600081815260026020526040902054600160a060020a03161561110f576000818152600260205260409020805473ffffffffffffffffffffffffffffffffffffffff191690555b5050565b600080600061112285856115af565b600084815260086020908152604080832054600160a060020a038916845260079092529091205490935061115d90600163ffffffff61164516565b600160a060020a03861660009081526007602052604090208054919350908390811061118557fe5b90600052602060002001549050806007600087600160a060020a0316600160a060020a03168152602001908152602001600020848154811015156111c557fe5b6000918252602080832090910192909255600160a060020a03871681526007909152604090208054906111fc906000198301611a3c565b50600093845260086020526040808520859055908452909220555050565b60006112268383611657565b50600160a060020a039091166000908152600760209081526040808320805460018101825590845282842081018590559383526008909152902055565b60008061127885600160a060020a03166116e7565b151561128757600191506113c7565b6040517f150b7a020000000000000000000000000000000000000000000000000000000081523360048201818152600160a060020a03898116602485015260448401889052608060648501908152875160848601528751918a169463150b7a0294938c938b938b93909160a490910190602085019080838360005b8381101561131a578181015183820152602001611302565b50505050905090810190601f1680156113475780820380516001836020036101000a031916815260200191505b5095505050505050602060405180830381600087803b15801561136957600080fd5b505af115801561137d573d6000803e3d6000fd5b505050506040513d602081101561139357600080fd5b5051600160e060020a031981167f150b7a020000000000000000000000000000000000000000000000000000000014925090505b50949350505050565b6040805180820190915260208082527f68747470733a2f2f6e66746965732e696f2f746f6b656e732f6e66746965732d9082015260609061141181886116ef565b90506114398160408051908101604052806001815260200160f860020a602d02815250611880565b905061144581876116ef565b905061146d8160408051908101604052806001815260200160f860020a602d02815250611880565b905061147981866116ef565b90506114a18160408051908101604052806001815260200160f860020a602d02815250611880565b90506114ad81856116ef565b90506114d58160408051908101604052806001815260200160f860020a602d02815250611880565b90506114e181846116ef565b9050611522816040805190810160405280600481526020017f2e706e6700000000000000000000000000000000000000000000000000000000815250611880565b979650505050505050565b611537828261199f565b600980546000838152600a60205260408120829055600182018355919091527f6e1540171b6c0c960b71a7020d9f60077f6af931a8bbf590da0223dacf75c7af015550565b61158582610843565b151561159057600080fd5b6000828152600b60209081526040909120825161083e92840190611a60565b81600160a060020a03166115c282610895565b600160a060020a0316146115d557600080fd5b600160a060020a0382166000908152600360205260409020546115ff90600163ffffffff61164516565b600160a060020a03909216600090815260036020908152604080832094909455918152600190915220805473ffffffffffffffffffffffffffffffffffffffff19169055565b60008282111561165157fe5b50900390565b600081815260016020526040902054600160a060020a03161561167957600080fd5b6000818152600160208181526040808420805473ffffffffffffffffffffffffffffffffffffffff1916600160a060020a03881690811790915584526003909152909120546116c7916119fa565b600160a060020a0390921660009081526003602052604090209190915550565b6000903b1190565b60408051606480825260a0820190925260609190829060009081908390819083908760208201610c8080388339019050509550600094505b60ff89161561177c578551600a60ff9a8b168181049b60018901989290910616955060f860020a603087010291889190811061175f57fe5b906020010190600160f860020a031916908160001a905350611727565b899250848351016040519080825280601f01601f1916602001820160405280156117b0578160200160208202803883390190505b509150600090505b82518110156118105782818151811015156117cf57fe5b90602001015160f860020a900460f860020a0282828151811015156117f057fe5b906020010190600160f860020a031916908160001a9053506001016117b8565b5060005b84811015611873578581600187030381518110151561182f57fe5b90602001015160f860020a900460f860020a02828451830181518110151561185357fe5b906020010190600160f860020a031916908160001a905350600101611814565b5098975050505050505050565b606080606080606060008088955087945084518651016040519080825280601f01601f1916602001820160405280156118c3578160200160208202803883390190505b50935083925060009150600090505b85518110156119305785818151811015156118e957fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561191057fe5b906020010190600160f860020a031916908160001a9053506001016118d2565b5060005b845181101561199257848181518110151561194b57fe5b90602001015160f860020a900460f860020a02838380600101945081518110151561197257fe5b906020010190600160f860020a031916908160001a905350600101611934565b5090979650505050505050565b600160a060020a03821615156119b457600080fd5b6119be828261121a565b6040518190600160a060020a038416906000907fddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef908290a45050565b818101828110156108b957fe5b6040805160c081018252600080825260208201819052918101829052606081018290526080810182905260a081019190915290565b81548183558181111561083e5760008381526020902061083e918101908301611ade565b828054600181600116156101000203166002900490600052602060002090601f016020900481019282601f10611aa157805160ff1916838001178555611ace565b82800160010185558215611ace579182015b82811115611ace578251825591602001919060010190611ab3565b50611ada929150611ade565b5090565b61063491905b80821115611ada5760008155600101611ae45600a165627a7a72305820eb6ef4caf7e8dfb40d659802d0d7106ab4b338205d58c4b1d0596c47c740a77e0029""
+ 	// CreateTo createTo(address _owner,uint256 _tokenId)
+-	CreateTo=""fdb05e85""
++	CreateTo = ""fdb05e85""
+ 	// TransferFrom transferFrom(address _from, address _to, uint256 _tokenId)
+-	TransferFrom=""23b872dd""
++	TransferFrom = ""23b872dd""
+ 	// BalanceOf BalanceOf(opts *bind.CallOpts, _owner common.Address)
+-	BalanceOf=""70a08231""
+-	)
+-
+-
++	BalanceOf = ""70a08231""
++)",Why this file is changed?,Erc721Binary =
+6924,"@@ -9,6 +9,11 @@ def includeme(config):
+         description='Track changes on data.',
+         url='http://kinto.readthedocs.io/en/latest/api/1.x/history.html')
+ 
++    config.add_api_capability(
++        'revert',
++        description='discard all changes after given timestamp.',
++        url='http://kinto.readthedocs.io/en/latest/api/1.x/revert.html')
++
+     # Activate end-points.
+     config.scan('kinto.plugins.history.views')
+ ",I'm not sure that we need this,Why is this needed?
+6925,"@@ -22,7 +22,7 @@ namespace Microsoft.DotNet.Build.Tasks
+             string dependencyVersion;
+             if (package.Value is JObject)
+             {
+-                dependencyVersion = package.Value[""version""].Value<string>();
++                dependencyVersion = package.Value[""version""]?.Value<string>();
+             }
+             else if (package.Value is JValue)
+             {",Is this going to cause issues in any other places were someone forgets the version? Should we consider also checking for type=project?,Why is this change 
+6926,"@@ -86,3 +86,18 @@ func extractASMValue(out *secretsmanager.GetSecretValueOutput) (docker.AuthConfi
+ 
+ 	return dac, nil
+ }
++
++// GetSecretFromASM makes the api call to the AWS Secrets Manager service to
++// retrieve the secret value
++func GetSecretFromASM(secretID string, client secretsmanageriface.SecretsManagerAPI) (string, error) {
++	in := &secretsmanager.GetSecretValueInput{
++		SecretId: aws.String(secretID),
++	}
++
++	out, err := client.GetSecretValue(in)
++	if err != nil {
++		return """", errors.Wrapf(err, ""secret %s"", secretID)
++	}
++
++	return aws.StringValue(out.SecretString), nil
++}",Does this have retries? Is there a possibility that customer would hit throttle errors here?,I think we should r
+6927,"@@ -3,15 +3,17 @@
+ #endif
+ #include <platform.h>
+ 
+-#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_FREEBSD)
++#if defined(PLATFORM_IS_LINUX) || defined(PLATFORM_IS_BSD)
+ #include <sched.h>
+ #include <sys/time.h>
+ #include <sys/resource.h>
+ #include <sys/mman.h>
+ #endif
+ 
+-#if defined(PLATFORM_IS_FREEBSD)
++#if defined(PLATFORM_IS_BSD)
+ #include <pthread_np.h>
++#endif
++#if defined(PLATFORM_IS_FREEBSD)
+ #include <sys/cpuset.h>
+ typedef cpuset_t cpu_set_t;
+ #endif",i noted that we are inconsistent with when we indent includes (see atomics.h which is rather different) and for example cpu.c which is also different. we seem to have 3 styles.,Why is this needed?
+6928,"@@ -80,6 +80,12 @@ const start = (passthroughArgs, buildConfig = config.defaultBuildConfig, options
+     if (user_data_dir) {
+       // clear the data directory before doing a network test
+       fs.removeSync(user_data_dir.replace('\\', ''))
++      if (fs.existsSync(networkLogFile)) {
++        fs.unlinkSync(networkLogFile)
++      }
++      if (fs.existsSync('network-audit-results.json')) {
++        fs.unlinkSync('network-audit-results.json')
++      }
+     }
+   }
+ ",Deleting the files before starting the audit helps avoid stale results if the new file is not created.,Why do we need this?
+6929,"@@ -70,14 +70,8 @@ func (c *Controller) spcEventHandler(operation string, spcGot *apis.StoragePoolC
+ 		// CreateStoragePool function will create the storage pool
+ 		// It is a create event so resync should be false and pendingPoolcount is passed 0
+ 		// pendingPoolcount is not used when resync is false.
+-		var newSpcLease Leases
+-		newSpcLease = &spcLease{spcGot, SpcLeaseKey, c.clientset}
+-		_, err := newSpcLease.GetLease()
+-		if err != nil {
+-			glog.Errorf(""Could not acquire lease on spc object:%v"", err)
+-			return addEvent, err
+-		}
+-		err = CreateStoragePool(spcGot, false, 0)
++
++		err := c.CreateStoragePool(spcGot, false, 0)
+ 
+ 		if err != nil {
+ 			glog.Error(""Storagepool could not be created:"", err)",Remove this blank line,Why do we need to cr
+6930,"@@ -23,12 +23,19 @@ import com.google.api.codegen.discovery.Schema.Format;
+ import com.google.api.codegen.discovery.Schema.Type;
+ import com.google.api.codegen.transformer.ImportTypeTable;
+ import com.google.api.codegen.util.Name;
++import com.google.api.codegen.util.SymbolTable;
+ import com.google.api.codegen.util.TypeName;
+ import com.google.api.tools.framework.model.Oneof;
+ import com.google.api.tools.framework.model.TypeRef.Cardinality;
+ import com.google.common.base.Preconditions;
++import com.google.common.base.Strings;
+ import com.google.common.collect.ImmutableList;
++import java.util.AbstractMap;
++import java.util.Comparator;
++import java.util.HashMap;
+ import java.util.List;
++import java.util.Map;
++import java.util.TreeMap;
+ import java.util.regex.Matcher;
+ import java.util.regex.Pattern;
+ import javax.annotation.Nullable;",This is... quite unconventional (use a map entry as a key). I would suggest making your own data class for the key.,Why is this needed?
+6931,"@@ -213,7 +213,11 @@ class OutputList(RecycleView):
+         res = []
+         for o in outputs:
+             value = self.app.format_amount_and_units(o.value)
+-            res.append({'address': o.get_ui_address_str(), 'value': value})
++            res.append({
++                    'address': o.get_ui_address_str(),
++                    'value': value,
++                    'background_color': (0.3, 0.3, 0.3, 1),
++                    'color': (1, 1, 1, 1)})
+         self.data = res
+ 
+ ",why are these colors needed to be specified here? when are they used?,continuation line un
+6932,"@@ -139,7 +139,12 @@ abstract class BaseMetadataTable implements Table {
+ 
+   @Override
+   public Rollback rollback() {
+-    throw new UnsupportedOperationException(""Cannot roll back a metadata table"");
++    throw new UnsupportedOperationException(""Cannot rollback snapshots from a metadata table"");
++  }
++
++  @Override
++  public ManageSnapshots manageSnapshots() {
++    throw new UnsupportedOperationException(""Cannot manage snapshots in a metadata table"");
+   }
+ 
+   @Override",Nit: no need to change this method.,nit: `Cannot manage snapshots in a metadata table`
+6933,"@@ -19,11 +19,15 @@ import inspect
+ # pylint: disable=line-too-long
+ from google.cloud.forseti.common.util import logger
+ from google.cloud.forseti.common.util import string_formats
++from google.cloud.forseti.services.inventory.storage import DataAccess
++
+ from google.cloud.forseti.notifier.notifiers.base_notification import BaseNotification
+ from google.cloud.forseti.notifier.notifiers import cscc_notifier
++from google.cloud.forseti.notifier.notifiers import email_violations
+ from google.cloud.forseti.notifier.notifiers.inventory_summary import InventorySummary
+-from google.cloud.forseti.services.inventory.storage import DataAccess
+ from google.cloud.forseti.services.scanner import dao as scanner_dao
++
++
+ # pylint: enable=line-too-long
+ 
+ ",Why a blank line?,nit: remove extra newline.
+6934,"@@ -103,7 +103,7 @@
+       <h2><%= _('Request expert feedback') %></h2>
+       <p><%= _('Click below to give data management staff at your organisation access to read and comment on your plan.') %></p>
+       <div class=""well well-sm"">
+-        <%= current_user.org.feedback_email_msg.html_safe %>
++        <%= current_user.org.feedback_email_msg %>
+       </div>
+       <p><%= _('You can continue to edit and download the plan in the interim.') %></p>
+ ",Why remove the `.html_safe` here? Should we use `sanitize` or `raw` instead? This info comes off of the org edit page and is entered by users.,I don't think you need the `.html_safe` here.
+6935,"@@ -383,7 +383,7 @@ get_dr_stats(void)
+  * returns zero on success, non-zero on failure
+  */
+ DYNAMORIO_EXPORT int
+-dynamorio_app_init(void)
++dynamorio_app_init(bool attach_case)
+ {
+     int size;
+ ",I think we need some docs about how to set this parameter correctly. Are we OK with changing the public API like this? We probably at least want to make a change notice to the release doc.,Why do we need this change?
+6936,"@@ -329,10 +329,13 @@ type ProtocolTag byte
+ 
+ const (
+ 	ProtocolHeartbeat ProtocolTag = iota
+-	ProtocolOverlayControlMsg
++	ProtocolConnectionEstablished
++	ProtocolFragmentationReceived
++	ProtocolPMTUVerified
+ 	ProtocolGossip
+ 	ProtocolGossipUnicast
+ 	ProtocolGossipBroadcast
++	ProtocolOverlayControlMsg
+ )
+ 
+ type ProtocolMsg struct {","When we undo this for 1.3, do we not need to leave these three entries intact to avoid renumbering of the subsequent constants? If so perhaps the changes to this file should be pulled into a separate initial commit so we can just `git revert` the remainder...",nit: can we call this `ProtocolFragmentationReceived`?
+6937,"@@ -60,5 +60,9 @@ func (a *API) Setup() {
+ 		a.removeUnusedShapes()
+ 	}
+ 
++	if !a.NoValidataShapeMethods {
++		a.addShapeValidations()
++	}
++
+ 	a.initialized = true
+ }",This is never set anywhere in the `cli/gen-api` folder. Should it be?,Why do we need this check?
+6938,"@@ -23,13 +23,13 @@ import (
+ 	""sync""
+ 	""time""
+ 
+-	v1 ""k8s.io/api/core/v1""
++	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/resource""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	kubeinformers ""k8s.io/client-go/informers""
+ 	""k8s.io/client-go/kubernetes""
+ 	""k8s.io/client-go/kubernetes/scheme""
+-	corev1 ""k8s.io/client-go/kubernetes/typed/core/v1""
++	clientv1 ""k8s.io/client-go/kubernetes/typed/core/v1""
+ 	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/clientcmd""
+ 	""k8s.io/client-go/tools/leaderelection""",All the changes in this commit are mechanical. Produced by the script in the previous commit.,why is this changed?
+6939,"@@ -76,7 +76,7 @@ module Travis
+             true
+           when 'server_error'
+             cmd 'echo -e ""\033[31;1mCould not fetch .travis.yml from GitHub.\033[0m""', assert: false, echo: false
+-            cmd 'travis_terminate 2', assert: false, echo: false
++            raw 'travis_terminate 2', assert: false, echo: false
+             false
+           else
+             true",What's the difference between these 2 versions?,Why did you remove the `cmd` here?
+6940,"@@ -224,7 +224,7 @@ class KMSScannerTest(unittest_utils.ForsetiTestCase):
+         self.scanner.run()
+         crypto_key = self.scanner._retrieve()
+         violations = self.scanner._find_violations(crypto_key)
+-        self.assertEquals(1, len(violations))
++        self.assertEquals(6, len(violations))
+         self.assertEquals(1, mock_output_results.call_count)
+ 
+ ",@red2k18 Are we sure its correct to only have 1 now?,Why did you change this?
+6941,"@@ -151,6 +151,7 @@ void AddFragToMol(RWMol *mol, RWMol *frag, Bond::BondType bondOrder,
+         newB->setOwningMol(mol);
+         newB->setBeginAtomIdx(atomIdx1);
+         newB->setEndAtomIdx(atomIdx2);
++        newB->setProp(RDKit::common_properties::_unspecifiedOrder, 1);
+         mol->addBond(newB);
+         delete newB;
+       } else {","@greglandrum interesting, is this related to #3307 by any chance?",Why is this needed?
+6942,"@@ -48,7 +48,15 @@ class ApplicationController < ActionController::Base
+   private
+ 
+   def current_user
+-    @current_user ||= User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    @current_user ||= find_current_user
++  end
++
++  def find_current_user
++    if ENV['FORCE_USER_ID'] && !Rails.env.production?
++      User.find ENV['FORCE_USER_ID']
++    else
++      User.find_or_create_by(email_address: session[:user]['email']) if session[:user] && session[:user]['email']
++    end
+   end
+ 
+   def sign_in(user)",Minor: how about moving the trailing `if` to an `elsif` above?,I don't think we need to
+6943,"@@ -321,6 +321,8 @@ class DBUpgrader {
+             db.execSQL(""UPDATE "" + PodDBAdapter.TABLE_NAME_FEED_ITEMS + "" SET content_encoded = NULL"");
+             db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
+                     + "" ADD COLUMN "" + PodDBAdapter.KEY_FEED_TAGS + "" TEXT;"");
++            db.execSQL(""ALTER TABLE "" + PodDBAdapter.TABLE_NAME_FEEDS
++                    + "" ADD COLUMN "" + PodDBAdapter.KEY_MINIMAL_DURATION_FILTER + "" INTEGER DEFAULT -1"");
+         }
+     }
+ ",That's only executed when users switch from 2.2 to 2.3. Please create a new block with code `2050000` for the next release :) Please also adapt the version number in PodDbAdapter,Why is this needed?
+6944,"@@ -351,6 +351,16 @@ func (c *client) sendConnect(tlsRequired bool) {
+ 
+ // Process the info message if we are a route.
+ func (c *client) processRouteInfo(info *Info) {
++	// We may need to update route permissions and will need the account
++	// sublist. Since getting the account requires server lock, do the
++	// lookup now.
++
++	// FIXME(dlc) - Add account scoping.
++	gacc := c.srv.globalAccount()
++	gacc.mu.RLock()
++	sl := gacc.sl
++	gacc.mu.RUnlock()
++
+ 	c.mu.Lock()
+ 	// Connection can be closed at any time (by auth timeout, etc).
+ 	// Does not make sense to continue here if connection is gone.",Safe to reference c.srv without capturing it first under a client lock?,Why do we need to do this?
+6945,"@@ -1,3 +1,19 @@
++/*
++Copyright 2018 The Kubernetes Authors.
++
++Licensed under the Apache License, Version 2.0 (the ""License"");
++you may not use this file except in compliance with the License.
++You may obtain a copy of the License at
++
++    http://www.apache.org/licenses/LICENSE-2.0
++
++Unless required by applicable law or agreed to in writing, software
++distributed under the License is distributed on an ""AS IS"" BASIS,
++WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++See the License for the specific language governing permissions and
++limitations under the License.
++*/
++
+ package actuators
+ 
+ import (","@vincepri blame tells me this was you, any objections to the change?",nit: remove empty line.
+6946,"@@ -0,0 +1,19 @@
++package main
++
++import (
++	""net/http""
++	""time""
++
++	""github.com/yarpc/yarpc-go/crossdock/client""
++	""github.com/yarpc/yarpc-go/crossdock/server""
++)
++
++func main() {
++	// TODO need to be able to wait till all inbounds are finished listening
++	go server.StartServerUnderTest()
++	// TODO maybe sleep?
++	time.Sleep(2 * time.Second)
++
++	http.HandleFunc(""/"", client.TestCaseHandler)
++	http.ListenAndServe("":8080"", nil)
++}",@abhinav here is where i need to be able to block/wait until the server is started,Why do we need this?
+6947,"@@ -64,6 +64,9 @@ public class MetricsServlet extends HttpServlet {
+ 
+         /**
+          * Returns the name of the parameter used to specify the jsonp callback, if any.
++         * 
++         * @return the name of the parameter used to specify the jsonp callback, or <code>null</code>, if 
++         *         no such parameter exists.
+          */
+         protected String getJsonpCallbackParameter() {
+             return null;",It seems to me as an unrelated change. Could you please revert it?,This should be `@return` n
+6948,"@@ -0,0 +1,3 @@
++package iface
++
++type DaemonAPI interface{}","~Why are putting all these APIs in their own ~packages~ files? So many more ~directories~ files, to what end? Why not just have them all be a part of the same API file and all live alongside each other so you can easily see them?~ Edit: nevermind, probably works best in separate files.",Why do we need this?
+6949,"@@ -32,6 +32,10 @@ import static com.github.javaparser.StaticJavaParser.parseClassOrInterfaceType;
+  */
+ public interface NodeWithExtends<N extends Node> {
+ 
++    /**
++     * @return All extended types that have been explicitly added.
++     *   Note that this will not include {@code java.lang.Object} unless it is explicitly added (e.g. {@code class X extends Object {}})
++     */
+     NodeList<ClassOrInterfaceType> getExtendedTypes();
+ 
+     void tryAddImportToParentCompilationUnit(Class<?> clazz);","This likely needs to be double checked -- I recall being convinced at the time of writing this, but now I am less sure",`@return All extende
+6950,"@@ -56,7 +56,7 @@ func main() {
+ 	if csv {
+ 		// produce a csv report
+ 
+-		fmt.Printf(""Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Exact Match,Similar To,Similarity Confidence,State\n"")
++		fmt.Printf(""Module Name,Module Path,Whitelisted,License Path,License Name,Confidence,Similar To,Similarity Confidence,State\n"")
+ 		for _, module := range modules {
+ 			fmt.Printf(""%s,%s,%v"", module.moduleName, module.path, cfg.whitelistedModules[module.moduleName])
+ 			for _, l := range module.licenses {",For a followup - it is better to use acceptlist/denylist. I realize this is a historical artifact of our codebase.,"fmt.Printf(""Module N"
+6951,"@@ -77,6 +77,13 @@ import org.apache.commons.io.FileUtils;
+ import java.util.zip.GZIPInputStream;
+ import java.util.zip.ZipEntry;
+ import java.util.zip.ZipInputStream;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
++import static edu.harvard.iq.dataverse.datasetutility.FileSizeChecker.bytesToHumanReadable;
+ 
+ 
+ /**",Looks like glassfish went a bit nuts doing a refactor,why do we need these
+6952,"@@ -47,4 +47,12 @@ describe('dom.visuallyContains', function () {
+ 		assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode));
+ 	});
+ 
++	it('should return true when element is inline', function () {
++		// result depends on the display property of the element
++		fixture.innerHTML = '<label>' +
++			'My label <input type=""text"" id=""target"">' +
++			'</label>';
++		var target = fixture.querySelector('#target');
++		assert.isTrue(axe.commons.dom.visuallyContains(target, target.parentNode));
++	});
+ });",Couldn't you use position:absolute or float to move inline elements outside their parent? Through clipping an child element can also be outside it's parent. There are probably some other ways to do it too. So I'm not sure the assumption you're making here is right.,I think you can use `axe.commons.dom.visuallyContains` here
+6953,"@@ -78,7 +78,7 @@ public class ExpireSnapshotsProcedure extends BaseProcedure {
+   @Override
+   public InternalRow[] call(InternalRow args) {
+     Identifier tableIdent = toIdentifier(args.getString(0), PARAMETERS[0].name());
+-    Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.toMillis(args.getLong(1));
++    Long olderThanMillis = args.isNullAt(1) ? null : DateTimeUtils.microsToMillis(args.getLong(1));
+     Integer retainLastNum = args.isNullAt(2) ? null : args.getInt(2);
+ 
+     return modifyIcebergTable(tableIdent, table -> {",This could be copied into iceberg code to avoid the spark internal dep? We could use a version check to adjust the method used if needed.,Why not use `DateTimeUtils.toMillis`?
+6954,"@@ -254,7 +254,7 @@ static void subprocess_destroy_finish (flux_future_t *f, void *arg)
+     if (flux_future_get (f, NULL) < 0) {
+         flux_t *h = flux_subprocess_aux_get (p, ""flux_t"");
+         flux_log_error (h, ""subprocess_kill: %ju: %s"",
+-                        (uintmax_t) flux_subprocess_pid,
++                        (uintmax_t) flux_subprocess_pid (p),
+                         flux_strerror (errno));
+     }
+     flux_subprocess_destroy (p);",This one had me stumped!,`p` should be `p->pid`
+6955,"@@ -190,10 +190,7 @@ class SettingsAdmin extends Component {
+ 												googlesitekit-settings-module__meta-item
+ 												googlesitekit-settings-module__meta-item--nomargin
+ 											"">
+-												<Optin
+-													id=""opt-in""
+-													name=""optin""
+-												/>
++												<Optin />
+ 											</div>
+ 										</div>
+ 									</div>","Note that this name differs from the name used as default (and thus used now that you removed this). That should be fine, but wanted to flag it.",Why did you remove the `id`?
+6956,"@@ -388,12 +388,17 @@ abstract class AbstractCrudController extends AbstractController implements Crud
+ 
+     public function autocomplete(AdminContext $context): JsonResponse
+     {
+-        $queryBuilder = $this->createIndexQueryBuilder($context->getSearch(), $context->getEntity(), FieldCollection::new([]), FilterCollection::new());
++        $queryBuilder = $this->createAutocompleteQueryBuilder($context->getSearch(), $context->getEntity());
+         $paginator = $this->get(PaginatorFactory::class)->create($queryBuilder);
+ 
+         return JsonResponse::fromJsonString($paginator->getResultsAsJson());
+     }
+ 
++    public function createAutocompleteQueryBuilder(SearchDto $searchDto, EntityDto $entityDto): QueryBuilder
++    {
++        return $this->get(EntityRepository::class)->createQueryBuilder($searchDto, $entityDto, FieldCollection::new([]), FilterCollection::new());
++    }
++
+     public function createIndexQueryBuilder(SearchDto $searchDto, EntityDto $entityDto, FieldCollection $fields, FilterCollection $filters): QueryBuilder
+     {
+         return $this->get(EntityRepository::class)->createQueryBuilder($searchDto, $entityDto, $fields, $filters);",Why public and not protected?,Why do we need this method?
+6957,"@@ -51,7 +51,7 @@
+             locals: {current_org: current_org.id, published: published, scopes: scopes[:all], hide_actions: true}) %>
+         </div>
+       <% end %>
+-      <div id=""organisation-templates"" role=""tabpanel"" class=""tab-pane<%= !current_user.can_super_admin? || current_tab == 'organisation-templates' ? ' active' : '' %>"">
++      <div id=""organisation-templates"" role=""tabpanel"" class=""tab-pane<%= (!current_user.can_super_admin? && !current_tab.present?) || current_tab == 'organisation-templates' ? ' active' : '' %>"">
+         <h2><%= current_user.can_super_admin? ? _('%{org_name} Templates') % { org_name: current_user.org.name } : _('Own Templates') %></h2>
+         <%= paginable_renderise(
+           partial: 'paginable/templates/orgs',",We definitely need to address this duplication after MVP,I don't think you need the 
+6958,"@@ -113,6 +113,12 @@ export default function UserInputKeywords( { slug, max } ) {
+ 	return (
+ 		<Cell lgStart={ 6 } lgSize={ 6 } mdSize={ 8 } smSize={ 4 }>
+ 			<div ref={ keywordsContainer } className=""googlesitekit-user-input__text-options"">
++				<label
++					htmlFor={ `${ slug }-keyword-0` }
++					className=""screen-reader-text""
++				>
++					{ __( 'Enter minimum one (1), maximum three (3) terms', 'google-site-kit' ) }
++				</label>
+ 				{ values.map( ( value, i ) => (
+ 					<div
+ 						key={ i }","This will always generate a label for the first keyword, which means this will be a label linked to no element after the first keyword is entered. This label should be generated inside the `values.map` next to the `<TextField><Input /></TextField>` it is for, because the ID changes based on the index. Also, we have a `VisuallyHidden` component I'd prefer we use over the CSS class. Building as many things out of components is more React-y. Admittedly it's sort of a preference, but it's why we have the `VisuallyHidden` component. So let's use that instead  ",I'm not sure if this is the
+6959,"@@ -323,6 +323,14 @@ struct roots_desktop *desktop_create(struct roots_server *server,
+ 
+ 	desktop->server = server;
+ 	desktop->config = config;
++
++	desktop->xcursor_theme = roots_xcursor_theme_create(""default"");
++	if (desktop->xcursor_theme == NULL) {
++		wlr_list_free(desktop->views);
++		free(desktop);
++		return NULL;
++	}
++
+ 	desktop->layout = wlr_output_layout_create();
+ 	desktop->compositor = wlr_compositor_create(server->wl_display,
+ 		server->renderer);","Does it make sense for this to be fatal? Could there be an embedded application that does not have xcursor themes at all? For instance, compositors without a pointer (like a touch-screen kiosk) will never show a cursor. I think I'm ok with this assumption since it simplifies the code and rootston is assumed to have desktop features, but we should always make sure xcursor is not required to be used in the library.",Shouldn't this be `roots_xc
+6960,"@@ -0,0 +1,15 @@
++using Nethermind.Core;
++
++namespace Nethermind.Blockchain.Filters.Topics
++{
++    public abstract class TopicsFilterBase
++    {
++        public abstract bool Accepts(LogEntry entry);
++
++        public abstract bool Accepts(ref LogEntryStructRef entry);
++
++        public abstract bool Matches(Bloom bloom);
++
++        public abstract bool Matches(ref BloomStructRef bloom);
++    }
++}",would rename to TopicsFilter and original one to SequenceTopicsFilter,Why do we need this abstract class?
+6961,"@@ -240,7 +240,7 @@ class MPLPlot(DimensionedPlot):
+ 
+ 
+     def update(self, key):
+-        if len(self) == 1 and key == 0 and not self.drawn:
++        if len(self) == 1 and ((key == 0) or (key == self.keys[0])) and not self.drawn:
+             return self.initialize_plot()
+         return self.__getitem__(key)
+ ",Is the idea that ``self.keys[0]`` here normally matches ``init_key``?,I don't think this is the right way
+6962,"@@ -262,6 +262,11 @@ class UIAHandler(COMObject):
+ 		eventHandler.queueEvent(NVDAEventName,obj)
+ 
+ 	def _isUIAWindowHelper(self,hwnd):
++		if hwnd == winUser.getDesktopWindow():
++			# #6301: In Windows 10 build >= 14901,
++			# calling UiaHasServerSideProvider with the desktop window sometimes freezes when bringing up NVDA windows.
++			# It will always return False anyway.
++			return False
+ 		# UIA in NVDA's process freezes in Windows 7 and below
+ 		processID=winUser.getWindowThreadProcessID(hwnd)[0]
+ 		if windll.kernel32.GetCurrentProcessId()==processID:","Can this be clarified to ""Exit early when hwnd is the windows desktop handle, UiaHasServerSideProvider would return false anyway."" ?",I don't think this is the right way
+6963,"@@ -72,11 +72,11 @@ type Task struct {
+ 	Containers []*Container
+ 	// Volumes are the volumes for the task
+ 	Volumes []TaskVolume `json:""volumes""`
+-	// VCPULimit is a task-level limit for compute resources. A value of 1 means that
++	// Cpu is a task-level limit for compute resources. A value of 1 means that
+ 	// the task may access 100% of 1 vCPU on the instance
+-	VCPULimit float64 `json:""CPULimit,omitempty""`
+-	// MemoryLimit is a task-level limit for memory resources in bytes
+-	MemoryLimit int64 `json:""Memory,omitempty""`
++	Cpu float64 `json:""CPULimit,omitempty""`
++	// Memory is a task-level limit for memory resources in bytes
++	Memory int64 `json:""Memory,omitempty""`
+ 	// DesiredStatusUnsafe represents the state where the task should go. Generally,
+ 	// the desired status is informed by the ECS backend as a result of either
+ 	// API calls made to ECS or decisions made by the ECS service scheduler.",I'm okay with leaving VCPULimit and MemoryLimit on our internal model,Why did you change this?
+6964,"@@ -73,6 +73,10 @@ const (
+ 	defaultWorkers = 4
+ 	// Default rule priority for K8s NetworkPolicy rules.
+ 	defaultRulePriority = -1
++	// TierIndex is used to index ClusterNetworkPolicies by Tier names.
++	TierIndex = ""tier""
++	// maxSupportedTiers is the maximum number of supported Tiers.
++	maxSupportedTiers = 10
+ )
+ 
+ var (",5 or 10?,nit: can we call this `defaultTierIndex`?
+6965,"@@ -27,6 +27,10 @@ internal class MyExporter : ActivityExporter
+     public override Task<ExportResult> ExportAsync(
+         IEnumerable<Activity> batch, CancellationToken cancellationToken)
+     {
++        // Exporter code which can generate further
++        // telemetry should do so inside SuppressInstrumentation
++        // scope. This suppresses telemetry from
++        // exporter's own code to avoid live-loop situation.
+         using var scope = Sdk.SuppressInstrumentation.Begin();
+ 
+         foreach (var activity in batch)",Should we explain more here?,"nit: typo in ""should"""
+6966,"@@ -30,9 +30,10 @@ import (
+ // ec2Svc are the functions from the ec2 service, not the client, this actuator needs.
+ // This should never need to import the ec2 sdk.
+ type ec2Svc interface {
+-	CreateInstance(*clusterv1.Machine) (*ec2svc.Instance, error)
++	CreateInstance(*clusterv1.Machine, *v1alpha1.AWSMachineProviderConfig, *v1alpha1.AWSClusterProviderStatus) (*ec2svc.Instance, error)
+ 	InstanceIfExists(*string) (*ec2svc.Instance, error)
+ 	TerminateInstance(*string) error
++	CreateOrGetMachine(*clusterv1.Machine, *v1alpha1.AWSMachineProviderStatus, *v1alpha1.AWSMachineProviderConfig, *v1alpha1.AWSClusterProviderStatus) (*ec2svc.Instance, error)
+ }
+ 
+ // codec are the functions off the generated codec that this actuator uses.","I've been struggling with this on my cloud-init integration work as well. In addition to info that is currently stored in the cluster providerstatus, we also need some of the info that is available within the base cluster object as well. I think it would make sense to unify the machine and cluster info needed into a consolidated struct rather than continuing to add additional disparate structs.",Why do we need both of these?
+6967,"@@ -17,7 +17,9 @@ import java.util.Map;
+  * UIs without the package prefixes.
+  *
+  * @author Brian Remedios
++ * @deprecated Is internal API
+  */
++@Deprecated
+ public final class ClassUtil {
+ 
+     public static final Class<?>[] EMPTY_CLASS_ARRAY = new Class[0];",Why not `@InternalApi`?,Why is this class deprecated?
+6968,"@@ -22,6 +22,11 @@ import datetime
+ import decimal
+ from inspect import getfullargspec, isclass
+ 
++try:
++    from typing import _GenericAlias  # type: ignore
++except ImportError:
++    from typing import GenericMeta as _GenericAlias  # type: ignore
++
+ import numpy as np
+ import pandas as pd
+ from pandas.api.types import is_datetime64_dtype, is_datetime64tz_dtype",FYI: `GenericMeta` is renamed to `_GenericAlias` in Python3.7.,why is this needed?
+6969,"@@ -63,7 +63,7 @@
+                         <% unless phase.sections.all?(&:modifiable?) %>
+                           <%= _(""You may place them before or after the main template sections."") %>
+                         <% end %>
+-                      <% else %>
++                      <% elsif template.latest? %>
+                         <%= link_to _('Re-order sections'),
+                             org_admin_template_phase_versions_path(phase.template, phase),
+                             method: ""post"",","So this hides the link to re-order sections on Historic Templates? Good catch, Just checked on DMPonline and hitting that throws a 404",I think this should
+6970,"@@ -69,7 +69,7 @@ module RSpec
+   # same process.
+   def self.clear_examples
+     world.reset
+-    configuration.reporter.reset
++    configuration.reset_reporter
+     configuration.start_time = ::RSpec::Core::Time.now
+     configuration.reset_filters
+   end","Is `Reporter#reset` no longer used? If so, can we remove it?",why this change?
+6971,"@@ -188,7 +188,7 @@ public final class EthHash {
+     out.writeLongScalar(header.getTimestamp());
+     out.writeBytes(header.getExtraData());
+     if (header.getBaseFee().isPresent()) {
+-      out.writeLongScalar(header.getBaseFee().get());
++      out.writeUInt256Scalar(header.getBaseFee().get());
+     }
+     out.endList();
+     return Bytes32.wrap(",same concern here about difference in the write scalar implementation. I am not sure if this could present a consensus problem or not,Shouldn't this be `
+6972,"@@ -0,0 +1,7 @@
++using UIKit;
++using MvvmCross.Core.ViewModels;
++
++namespace MvvmCross.tvOS.Views
++{
++    public interface IMvxSplitViewController : IMvxTvosView { }
++}",Can we remove this file?,Why do we need this?
+6973,"@@ -799,7 +799,7 @@ func (c *Operator) sync(ctx context.Context, key string) error {
+ 
+ 	if ok && sErr.ErrStatus.Code == 422 && sErr.ErrStatus.Reason == metav1.StatusReasonInvalid {
+ 		c.metrics.StsDeleteCreateCounter().Inc()
+-		level.Info(c.logger).Log(""msg"", ""resolving illegal update of Alertmanager StatefulSet"", ""details"", sErr.ErrStatus.Details)
++		level.Info(c.logger).Log(""msg"", ""recreating AlertManager StatefulSet because the update operation wasn't possible"", ""reason"", sErr.ErrStatus.Details.Causes[0].Message)
+ 		propagationPolicy := metav1.DeletePropagationForeground
+ 		if err := ssetClient.Delete(ctx, sset.GetName(), metav1.DeleteOptions{PropagationPolicy: &propagationPolicy}); err != nil {
+ 			return errors.Wrap(err, ""failed to delete StatefulSet to avoid forbidden action"")",Why listing only first error reason (`ErrStatus.Details.Causes[0].Message`)?,I don't think we nee
+6974,"@@ -77,6 +77,17 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+ 
++  /**
++   * If the compaction should use the sequence number of the snapshot at compaction start time for new data files,
++   * instead of using the sequence number of the newly produced snapshot.
++   * <p>
++   * This avoids commit conflicts with updates that add newer equality deletes at a higher sequence number.
++   * <p>
++   * Defaults to true.
++   */
++  String USE_STARTING_SEQUENCE_NUMBER = ""use-starting-sequence-number"";
++  boolean USE_STARTING_SEQUENCE_NUMBER_DEFAULT = true;
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining","Now that this is true, do we have to ignore it with V1 Tables?",I think it would be 
+6975,"@@ -87,6 +87,12 @@ Blockly.Css.inject = function(hasCss, pathToMedia) {
+   // Strip off any trailing slash (either Unix or Windows).
+   Blockly.Css.mediaPath_ = pathToMedia.replace(/[\\\/]$/, '');
+   text = text.replace(/<<<PATH>>>/g, Blockly.Css.mediaPath_);
++  // Dynamically replace colours in the CSS text, in case they have
++  // been set at run-time injection.
++  for (var colourProperty in Blockly.Colours) {
++    if (!Blockly.Colours.hasOwnProperty(colourProperty)) continue;
++    text = text.replace('$colour_' + colourProperty, Blockly.Colours[colourProperty]);
++  }
+   // Inject CSS tag.
+   var cssNode = document.createElement('style');
+   document.head.appendChild(cssNode);",prefer if (condition) { stuff; } to if !(condition) { continue; } stuff,Why do we need this?
+6976,"@@ -1,11 +1,8 @@
+-<h1><%= h(@title) %></h1>
+-
+-<% content_for :head do %>
+-<%= auto_discovery_link_tag :atom, :action => 'georss', :display_name => @display_name, :tag => @tag %>
+-<% end %>
+-
+-<p>
+-  <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %>
++<% content_for :heading do %>
++  <h1><%= h(@title) %></h1>
++  <span><%= raw(@description) %></span>
++  |
++    <%= rss_link_to :action => 'georss', :display_name => @display_name, :tag => @tag %>
+   | <%= link_to t('trace.trace_header.upload_trace'), :action => 'create' %>
+   <% if @tag %>
+     | <%= link_to t('trace.trace_header.see_all_traces'), :controller => 'trace', :action => 'list', :display_name => nil, :tag => nil, :page => nil %>",Should this section not be converted to a secondary action list?,I think this should be `<%= raw(@description) %>`
+6977,"@@ -225,8 +225,17 @@ class CommandDispatcher:
+             count: The tab index to close, or None
+         """"""
+         tab = self._cntwidget(count)
++        result = True
+         if tab is None:
+             return
++
++        if tab.pin is True:
++            result = message.ask(""Are you sure you want to close a pinned tab?"",
++                    mode=usertypes.PromptMode.yesno, default=False)
++
++        if result is False or result is None:
++            return
++
+         tabbar = self._tabbed_browser.tabBar()
+         selection_override = self._get_selection_override(left, right,
+                                                           opposite)","This askes a blocking question, which means a local Qt eventloop will be running. While this is unavoidable sometimes, the async functions should be used whenever possible (`message.confirm_async` in this case). This means: - Split everything after this question in a separate private method (you can probably just call it `_tab_close`) - If the tab is not pinned, just call `_tab_close` directly - If it is pinned, call `message.confirm_async` with `yes_action=self._tab_close`",I think this should be `if not tab.pin:`
+6978,"@@ -28,7 +28,7 @@ define([""jQuery"", ""loading"", ""libraryMenu"", ""fnchecked""], function($, loading, l
+             IsHidden: !1
+         })).then(function(folders) {
+             loadDeleteFolders(page, user, folders.Items)
+-        }), user.Policy.IsDisabled ? $("".disabledUserBanner"", page).show() : $("".disabledUserBanner"", page).hide(), ""Guest"" == user.ConnectLinkType ? ($(""#fldConnectInfo"", page).hide(), $(""#txtUserName"", page).prop(""disabled"", ""disabled"")) : ($(""#txtUserName"", page).prop(""disabled"", """").removeAttr(""disabled""), $(""#fldConnectInfo"", page).show()), $("".lnkEditUserPreferences"", page).attr(""href"", ""mypreferencesmenu.html?userId="" + user.Id), libraryMenu.setTitle(user.Name), page.querySelector("".username"").innerHTML = user.Name, $(""#txtUserName"", page).val(user.Name), $(""#chkIsAdmin"", page).checked(user.Policy.IsAdministrator), $(""#chkDisabled"", page).checked(user.Policy.IsDisabled), $(""#chkIsHidden"", page).checked(user.Policy.IsHidden), $(""#chkRemoteControlSharedDevices"", page).checked(user.Policy.EnableSharedDeviceControl), $(""#chkEnableRemoteControlOtherUsers"", page).checked(user.Policy.EnableRemoteControlOfOtherUsers), $(""#chkEnableDownloading"", page).checked(user.Policy.EnableContentDownloading), $(""#chkManageLiveTv"", page).checked(user.Policy.EnableLiveTvManagement), $(""#chkEnableLiveTvAccess"", page).checked(user.Policy.EnableLiveTvAccess), $(""#chkEnableMediaPlayback"", page).checked(user.Policy.EnableMediaPlayback), $(""#chkEnableAudioPlaybackTranscoding"", page).checked(user.Policy.EnableAudioPlaybackTranscoding), $(""#chkEnableVideoPlaybackTranscoding"", page).checked(user.Policy.EnableVideoPlaybackTranscoding), $(""#chkEnableVideoPlaybackRemuxing"", page).checked(user.Policy.EnablePlaybackRemuxing), $(""#chkRemoteAccess"", page).checked(null == user.Policy.EnableRemoteAccess || user.Policy.EnableRemoteAccess), $(""#chkEnableSyncTranscoding"", page).checked(user.Policy.EnableSyncTranscoding), $(""#chkEnableConversion"", page).checked(user.Policy.EnableMediaConversion || !1), $(""#chkEnableSharing"", page).checked(user.Policy.EnablePublicSharing), $(""#txtRemoteClientBitrateLimit"", page).val(user.Policy.RemoteClientBitrateLimit / 1e6 || """"), loading.hide()
++        }), user.Policy.IsDisabled ? $("".disabledUserBanner"", page).show() : $("".disabledUserBanner"", page).hide(), ""Guest"" == user.ConnectLinkType ? ($(""#fldConnectInfo"", page).hide(), $(""#txtUserName"", page).prop(""disabled"", ""disabled"")) : ($(""#txtUserName"", page).prop(""disabled"", """").removeAttr(""disabled""), $(""#fldConnectInfo"", page).show()), $("".lnkEditUserPreferences"", page).attr(""href"", ""mypreferencesmenu.html?userId="" + user.Id), libraryMenu.setTitle(user.Name), page.querySelector("".username"").innerHTML = user.Name, $(""#txtUserName"", page).val(user.Name), $(""#chkIsAdmin"", page).checked(user.Policy.IsAdministrator), $(""#chkDisabled"", page).checked(user.Policy.IsDisabled), $(""#chkIsHidden"", page).checked(user.Policy.IsHidden), $(""#chkRemoteControlSharedDevices"", page).checked(user.Policy.EnableSharedDeviceControl), $(""#chkEnableRemoteControlOtherUsers"", page).checked(user.Policy.EnableRemoteControlOfOtherUsers), $(""#chkEnableDownloading"", page).checked(user.Policy.EnableContentDownloading), $(""#chkManageLiveTv"", page).checked(user.Policy.EnableLiveTvManagement), $(""#chkEnableLiveTvAccess"", page).checked(user.Policy.EnableLiveTvAccess), $(""#chkEnableMediaPlayback"", page).checked(user.Policy.EnableMediaPlayback), $(""#chkEnableAudioPlaybackTranscoding"", page).checked(user.Policy.EnableAudioPlaybackTranscoding), $(""#chkEnableVideoPlaybackTranscoding"", page).checked(user.Policy.EnableVideoPlaybackTranscoding), $(""#chkEnableVideoPlaybackRemuxing"", page).checked(user.Policy.EnablePlaybackRemuxing), $(""#chkRemoteAccess"", page).checked(null == user.Policy.EnableRemoteAccess || user.Policy.EnableRemoteAccess), $(""#chkEnableSyncTranscoding"", page).checked(user.Policy.EnableSyncTranscoding), $(""#chkEnableConversion"", page).checked(user.Policy.EnableMediaConversion || !1), $(""#chkEnableSharing"", page).checked(user.Policy.EnablePublicSharing), $(""#txtRemoteClientBitrateLimit"", page).val(user.Policy.RemoteClientBitrateLimit / 1e6 || """"), $(""#txtLoginAttemptsBeforeLockout"", page).val(user.Policy.LoginAttemptsBeforeLockout || ""0""), loading.hide()
+     }
+ 
+     function onSaveComplete(page, user) {",Can we deuglify this?,Why was this removed?
+6979,"@@ -177,7 +177,7 @@ public interface Option<T> extends Value<T>, Serializable {
+      */
+     default <R> Option<R> collect(PartialFunction<? super T, ? extends R> partialFunction) {
+         Objects.requireNonNull(partialFunction, ""partialFunction is null"");
+-        return filter(partialFunction::isDefinedAt).map(partialFunction::apply);
++        return flatMap(partialFunction.lift()::apply);
+     }
+ 
+     /**","@skestle Just recognized that the `::apply` is not necessary. Does it compile if you leave it away? Could you please check that, I'm on vacation and have no IDE at hand... Thx!",Why is this change needed?
+6980,"@@ -366,7 +366,8 @@ public class TestMergeAppend extends TableTestBase {
+         1, base.currentSnapshot().manifests().size());
+     ManifestFile initialManifest = base.currentSnapshot().manifests().get(0);
+ 
+-    // build the new spec using the table's schema, which uses fresh IDs
++    // build the new spec using the table's sche
++    // ma, which uses fresh IDs
+     PartitionSpec newSpec = PartitionSpec.builderFor(base.schema())
+         .bucket(""data"", 16)
+         .bucket(""id"", 4)",Looks like this is an unnecessary change.,"""ma"" -> ""ma"""
+6981,"@@ -290,7 +290,7 @@ class CrawlerTest(CrawlerBase):
+             'disk': {'resource': 3},
+             'firewall': {'resource': 3},
+             'folder': {'iam_policy': 2, 'resource': 2},
+-            'forwardingrule': {'resource': 1},
++            'forwardingrule': {'resource': 2},
+             'instance': {'resource': 3},
+             'instancegroup': {'resource': 2},
+             'instancegroupmanager': {'resource': 2},",This one won't change as the resource is not included in the project getting tested with the composite root.,Why did you 
+6982,"@@ -336,6 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
++	__u8 nat_lvl1_drop = 0;
+ 
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.","We have `stdbool` imported, might as well use that for clarity.",Shouldn't th
+6983,"@@ -30,8 +30,8 @@ namespace Datadog.Trace.ClrProfiler.IntegrationTests
+                 Assert.True(spans.Count > 0, ""expected at least one span"");
+                 foreach (var span in spans)
+                 {
+-                    Assert.Equal(SqlServerIntegration.OperationName, span.Name);
+-                    Assert.Equal($""Samples.SqlServer-{SqlServerIntegration.ServiceName}"", span.Service);
++                    Assert.Equal(""sql-server.query"", span.Name);
++                    Assert.Equal($""Samples.SqlServer-sql-server"", span.Service);
+                     Assert.Equal(SpanTypes.Sql, span.Type);
+                 }
+             }",Why do we not also have integration tests for postgres?,Why do we ne
+6984,"@@ -205,7 +205,7 @@ describe('Db', function() {
+   /**
+    * An example showing how to force a reindex of a collection.
+    */
+-  it('shouldCorrectlyForceReindexOnCollection', {
++  it.skip('shouldCorrectlyForceReindexOnCollection', {
+     metadata: {
+       requires: { topology: ['single'] }
+     },","I think its safe to remove this if we're removing `reIndex` outright. The description shows us that the test is ""An example showing how to force a reindex of a collection""",Why are we skipping this test?
+6985,"@@ -43,6 +43,7 @@ const (
+ 	EEXIST      Errno = 0x11
+ 	EINTR       Errno = 0x4
+ 	ENOTDIR     Errno = 0x14
++	EINVAL      Errno = 22
+ 	EMFILE      Errno = 0x18
+ 	EAGAIN      Errno = 0x23
+ 	ETIMEDOUT   Errno = 0x3c",Can you make this hexadecimal to match the other constants?,I don't think this is correct.
+6986,"@@ -209,12 +209,5 @@ module Bolt
+         Bolt::Logger.warn(""missing_project_name"", message)
+       end
+     end
+-
+-    def check_deprecated_file
+-      if (@path + 'project.yaml').file?
+-        msg = ""Project configuration file 'project.yaml' is deprecated; use 'bolt-project.yaml' instead.""
+-        Bolt::Logger.warn(""project_yaml"", msg)
+-      end
+-    end
+   end
+ end",Can this get moved to `Bolt::Project#validate`?,Why is this being removed?
+6987,"@@ -426,7 +426,15 @@ public interface List<T> extends Seq<T>, Stack<T> {
+     @Override
+     default Tuple2<List<T>, List<T>> partition(Predicate<? super T> predicate) {
+         Objects.requireNonNull(predicate, ""predicate is null"");
+-        return Tuple.of(filter(predicate), filter(predicate.negate()));
++        List<T> left = nil(), right = nil();
++        for (T t : this) {
++            if (predicate.test(t)) {
++                left = left.prepend(t);
++            } else {
++                right = right.prepend(t);
++            }
++        }
++        return Tuple.of(left.reverse(), right.reverse());
+     }
+ 
+     @Override","I'm pretty sure it doesn't harm, but don't we have a second pass here with the reverse() operation?",Why do we need this change?
+6988,"@@ -24,6 +24,7 @@ public interface CapabilityType {
+   String PLATFORM = ""platform"";
+   String SUPPORTS_JAVASCRIPT = ""javascriptEnabled"";
+   String TAKES_SCREENSHOT = ""takesScreenshot"";
++  String TAKES_HEAP_SNAPSHOT = ""takesHeapSnapshot"";
+   String VERSION = ""version"";
+   String SUPPORTS_ALERTS = ""handlesAlerts"";
+   String SUPPORTS_SQL_DATABASE = ""databaseEnabled"";",This is not a standard capability and should be hidden behind a vendor prefix: -chromium-takesHeapSnapshot,Why do we need this?
+6989,"@@ -144,9 +144,9 @@ trainer::execution_context_key_pair_t trainer::check_and_build_execution_context
+     if(dynamic_cast<observer_ptr<sgd_training_algorithm>>(&alg) != nullptr) {
+       /// @todo BVE FIXME Figure out how to get a good mini-batch size
+       /// in here
+-      context = make_unique<sgd_execution_context>(this, m_comm, mode, model->get_max_mini_batch_size());
++      context = make_unique<sgd_execution_context>(this, &alg, m_comm, mode, model->get_max_mini_batch_size());
+     }else {
+-      context = make_unique<execution_context>(this, m_comm, mode);
++      context = make_unique<execution_context>(this, &alg, m_comm, mode);
+     }
+     m_model_execution_context.emplace(key,std::move(context));
+   }",This shouldn't work with pointers -- prefer references unless you can meaningfully pass `nullptr`. The address-of operator here is clunky at best.,Why do we need a poi
+6990,"@@ -140,7 +140,8 @@ func TestBuild(t *testing.T) {
+ 		for _, t := range tests {
+ 			switch t {
+ 			case ""atomic.go"":
+-				// Not supported due to unaligned atomic accesses.
++				// Requires GCC 11.2.0 or above for interface comparison.
++				// https://github.com/gcc-mirror/gcc/commit/f30dd607669212de135dec1f1d8a93b8954c327c
+ 
+ 			case ""reflect.go"":
+ 				// Reflect tests do not work due to type code issues.",Sidenote: some day we'll drop the avr-gcc and avr-libc dependencies so that this case becomes supported.,I'm not sure if this
+6991,"@@ -619,6 +619,6 @@ public class TestFieldCacheVsDocValues extends LuceneTestCase {
+   
+   protected boolean codecAcceptsHugeBinaryValues(String field) {
+     String name = TestUtil.getDocValuesFormat(field);
+-    return !(name.equals(""Memory"")); // Direct has a different type of limit
++    return true;
+   }
+ }",do we still need this method?,Why did you remove t
+6992,"@@ -618,10 +618,14 @@ RETDesc *GenericUpdate::createOldAndNewCorrelationNames(BindWA *bindWA, NABoolea
+     rd = new (bindWA->wHeap()) RETDesc(bindWA);
+   }
+ 
++  /*  if ((getOperatorType() != REL_UNARY_INSERT) || 
++      getUpdateCKorUniqueIndexKey() ||
++      ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->isMerge()) ||
++      ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))  */
+   if ((getOperatorType() != REL_UNARY_INSERT) || 
+       getUpdateCKorUniqueIndexKey() ||
+       ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->isMerge()) ||
+-      ((getOperatorType() == REL_UNARY_INSERT) && ((Insert *)this)->isUpsert() && (CmpCommon::getDefault(TRAF_UPSERT_TO_EFF_TREE) == DF_ON )))  
++      ((getOperatorType() == REL_UNARY_INSERT) &&((Insert *)this)->xformedEffUpsert()))
+   {
+     // DELETE or UPDATE --
+     // Now merge the old/target/before valueid's (the Scan child RETDesc)",It's better to not leave this old code here... it just clutters things up and makes reading the code more confusing. We can always recover the old code from the repository if needed.,Please remove this code.
+6993,"@@ -21,6 +21,8 @@ import com.google.common.base.Charsets;
+ import com.google.common.io.ByteStreams;
+ import com.google.common.net.MediaType;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.apache.http.Header;
+ import org.apache.http.HttpEntity;
+ import org.apache.http.HttpHost;","Again, you don't want to depend on glassfish.",Why is this import neede
+6994,"@@ -1,6 +1,6 @@
+ FactoryGirl.define do
+   factory :post do
+-    association :account
++    association :account, factory: :account
+     association :topic
+     body { Faker::Lorem.sentence }
+     sequence :created_at do |n|",This shouldn't be required. What was going on here?,Prefer single-quoted str
+6995,"@@ -80,6 +80,7 @@ func (cp ConnectionPolicies) TLSConfig(ctx caddy.Context) *tls.Config {
+ 	}
+ 
+ 	return &tls.Config{
++		MinVersion: tls.VersionTLS12,
+ 		GetConfigForClient: func(hello *tls.ClientHelloInfo) (*tls.Config, error) {
+ 			// filter policies by SNI first, if possible, to speed things up
+ 			// when there may be lots of policies",Why add this here?,Why is this needed?
+6996,"@@ -141,15 +141,15 @@ namespace AutoRest.CSharp.Model
+             {
+                 if (ReturnType.Body != null && ReturnType.Headers != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)},{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)},{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
+                 }
+                 if (ReturnType.Body != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationResponse<{ReturnType.Body.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)}>"";
+                 }
+                 if (ReturnType.Headers != null)
+                 {
+-                    return $""Microsoft.Rest.HttpOperationHeaderResponse<{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head)}>"";
++                    return $""Microsoft.Rest.HttpOperationHeaderResponse<{ReturnType.Headers.AsNullableType(HttpMethod != HttpMethod.Head && IsXNullableReturnType)}>"";
+                 }
+ 
+                 return ""Microsoft.Rest.HttpOperationResponse"";",nullability does not apply to headers type (that is always an object),Why is this change needed?
+6997,"@@ -166,7 +166,7 @@ static fpga_result map_mmio_region(fpga_handle handle, uint32_t mmio_num)
+ 	wsid = wsid_gen();
+ 	if (!wsid_add(&_handle->mmio_root,
+ 		      wsid,
+-		      (uint64_t) NULL,
++		      (uint64_t) addr,
+ 		      (uint64_t) NULL,
+ 		      size,
+ 		      (uint64_t) addr,","Do we also need to add the iova, or is that done somewhere else?",Why is this change needed?
+6998,"@@ -19,9 +19,7 @@ package selector
+ 
+ import ""github.com/mysteriumnetwork/node/identity""
+ 
+-// Handler allows selecting identity to be used
++// Handler interface
+ type Handler interface {
+-	UseExisting(address, passphrase string) (identity.Identity, error)
+-	UseLast(passphrase string) (identity.Identity, error)
+-	UseNew(passphrase string) (identity.Identity, error)
++	UseOrCreate(address, passphrase string) (identity.Identity, error)
+ }",why change this?,Why do we need this interf
+6999,"@@ -173,7 +173,7 @@ void h2o_get_timestamp(h2o_context_t *ctx, h2o_mem_pool_t *pool, h2o_timestamp_t
+             if (ctx->_timestamp_cache.value != NULL)
+                 h2o_mem_release_shared(ctx->_timestamp_cache.value);
+             ctx->_timestamp_cache.value = h2o_mem_alloc_shared(NULL, sizeof(h2o_timestamp_string_t), NULL);
+-            gmtime_r(&ctx->_timestamp_cache.tv_at.tv_sec, &gmt);
++            gmtime_r((time_t *)&ctx->_timestamp_cache.tv_at.tv_sec, &gmt);
+             h2o_time2str_rfc1123(ctx->_timestamp_cache.value->rfc1123, &gmt);
+             h2o_time2str_log(ctx->_timestamp_cache.value->log, ctx->_timestamp_cache.tv_at.tv_sec);
+         }","If there is no guarantee that tv_sec is of type `time_t`, IMO you should copy the value instead of enforcing a pointer typecast.",Why is this cast needed?
+7000,"@@ -83,9 +83,12 @@ func (opts *InitAppOpts) Validate() error {
+ 		}
+ 	}
+ 	if opts.DockerfilePath != """" {
+-		if _, err := listDockerfiles(opts.fs, opts.DockerfilePath); err != nil {
++		if _, err := opts.fs.Stat(opts.DockerfilePath); err != nil {
+ 			return err
+ 		}
++		if !strings.HasSuffix(opts.DockerfilePath, ""/Dockerfile"") {
++			return fmt.Errorf(""a valid Dockerfile path is required"")
++		}
+ 	}
+ 	if opts.ProjectName() == """" {
+ 		return errNoProjectInWorkspace",Should we validate the suffix before going to the filesystem?,"I think this should be `!opts.DockerfilePath.EndsWith(""/Dockerfile"")`"
+7001,"@@ -23,8 +23,12 @@ var (
+ 	plugin   = ""local""
+ 	// 1 week
+ 	updateInterval = time.Hour * 24 * 7
++	siteName       string
++	serviceType    string
+ )
+ 
++const netName = ""ddev_default""
++
+ // RootCmd represents the base command when called without any subcommands
+ var RootCmd = &cobra.Command{
+ 	Use:   ""ddev"",",It feels like we should be working to reduce/eliminate our global vars. I'm not sure it adds much here. Any objection to just removing it?,Why do we need this?
+7002,"@@ -0,0 +1,13 @@
++class AddScheduledReports < ActiveRecord::Migration
++  def change
++    create_table :scheduled_reports do |t|
++      t.string :name, null: false
++      t.string :frequency, null: false
++      t.integer :user_id, null: false
++      t.integer :report_id, null: false
++      t.timestamps
++    end
++    add_foreign_key :scheduled_reports, :users
++    add_foreign_key :scheduled_reports, :reports
++  end
++end",did you consider using AR enums for this? would give us all the boolean methods (`weekly?` etc) for free,I don't think we need to add a foreign key to the users table.
+7003,"@@ -378,6 +378,8 @@ class Engine(object):
+         :param filename: file basename to find
+         :type filename: str
+         """"""
++        if not filename:
++            return None
+         filename = os.path.expanduser(filename)
+         if os.path.exists(filename):
+             return filename","This may change """" into None. Better return filename.",Why is this needed?
+7004,"@@ -126,4 +126,11 @@ type Resources struct {
+ 
+ 	// CpuWeight sets a proportional bandwidth limit.
+ 	CpuWeight uint64 `json:""cpu_weight""`
++
++	// SkipDevices allows to skip configuring device permissions.
++	// Used by e.g. kubelet while creating a parent cgroup (kubepods)
++	// common for many containers.
++	//
++	// NOTE it is impossible to start a container which has this flag set.
++	SkipDevices bool `json:""skip_devices""`
+ }",:+1: That does resolve my security concerns about this feature.,I don't think we need to add a new field here. We can just use the existing `SkipDevices` field.
+7005,"@@ -61,8 +61,13 @@ def get_if(iff, cmd):
+     return ifreq
+ 
+ 
++def get_if_raw_hwaddr(iff):
++    from scapy.arch import SIOCGIFHWADDR
++    return struct.unpack(""16xh6s8x"", get_if(iff, SIOCGIFHWADDR))
++
+ # SOCKET UTILS
+ 
++
+ def _select_nonblock(sockets, remain=None):
+     """"""This function is called during sendrecv() routine to select
+     the available sockets.",Could you add a docstring?,Why is this needed?
+7006,"@@ -92,7 +92,7 @@ func TestClientDisableIMDS(t *testing.T) {
+ 	svc := ec2metadata.New(unit.Session, &aws.Config{
+ 		LogLevel: aws.LogLevel(aws.LogDebugWithHTTPBody),
+ 	})
+-	resp, err := svc.Region()
++	resp, err := svc.GetUserData()
+ 	if err == nil {
+ 		t.Fatalf(""expect error, got none"")
+ 	}",Shouldn't this still be `Region()`?,Why is this change needed?
+7007,"@@ -89,6 +89,7 @@ class CompletionView(QTreeView):
+     # https://github.com/The-Compiler/qutebrowser/issues/117
+ 
+     resize_completion = pyqtSignal()
++    connected = None
+ 
+     def __init__(self, win_id, parent=None):
+         super().__init__(parent)","This shouldn't be here but `self.connected = None` in `__init__` instead, otherwise that'd be an attribute which is set this way in _every_ instance of that class (i.e. a class rather than an instance variable). I'd also say let's make it ""private"" (i.e. `_connected`) and please add a quick note about what it is to the docstring of the class.",Why is this needed?
+7008,"@@ -24,7 +24,7 @@ class ChromiumService(service.Service):
+     """"""
+ 
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None, start_error_message=None):
++                 log_path=None, env=None, start_error_message=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ",This would be better served as a method/property that is set when people don't want to a window.,This is a breaking change. Please add the new argument at the end.
+7009,"@@ -33,7 +33,7 @@ public class PageStreamingTransformer {
+   public List<PageStreamingDescriptorView> generateDescriptors(SurfaceTransformerContext context) {
+     List<PageStreamingDescriptorView> descriptors = new ArrayList<>();
+ 
+-    for (Method method : context.getInterface().getMethods()) {
++    for (Method method : context.getNonStreamingMethods()) {
+       MethodConfig methodConfig = context.getMethodConfig(method);
+       if (!methodConfig.isPageStreaming()) {
+         continue;","I was dubious about putting getNonStreamingMethods in the context, but after some thought, I have decided to embrace the approach. In this particular case, the loop is supposed to be over page streaming methods. So, could you add a getPageStreamingMethods() method in the context, use it here, and remove the isPageStreaming() check below?",Why is this change needed?
+7010,"@@ -600,7 +600,8 @@ class JMeterExecutor(ScenarioExecutor, WidgetProvider, FileLister, HavingInstall
+         self.__add_result_listeners(jmx)
+         if not is_jmx_generated:
+             self.__force_tran_parent_sample(jmx)
+-            if self.settings.get('version', self.JMETER_VER) >= '3.2':
++            version = str(self.settings.get('version', self.JMETER_VER)).split(""."")
++            if tuple(version) >= ('3', '2'):
+                 self.__force_hc4_cookie_handler(jmx)
+         self.__fill_empty_delimiters(jmx)
+ ",LooseVersion class can help here,"I think this should be `tuple(version) >= (3, 2)`"
+7011,"@@ -220,7 +220,9 @@ void HDF5Common::AddVar(IO &io, std::string const &name, hid_t datasetId)
+                 shape[i] = dims[i];
+         }
+ 
+-        auto &foo = io.DefineVariable<T>(name, shape);
++        Dims zeros(shape.size(), 0);
++
++        auto &foo = io.DefineVariable<T>(name, shape, zeros, shape);
+         // default was set to 0 while m_AvailabelStepsStart is 1.
+         // correcting
+         if (0 == foo.m_AvailableStepsCount)","`const Dims zeros(shape.size(), 0);`",Why do we need this change?
+7012,"@@ -135,8 +135,8 @@ module RSpec::Core
+           options[:color] = o
+         end
+ 
+-        parser.on('-p', '--profile', 'Enable profiling of examples and list 10 slowest examples.') do |o|
+-          options[:profile_examples] = o
++        parser.on('-p', '--profile [COUNT]', 'Enable profiling of examples and list 10 slowest examples.') do |count|
++          options[:profile_examples] = count.nil? ? true : count.to_i
+         end
+ 
+         parser.separator <<-FILTERING",Would be good for this not to say `10` anymore...,`count.nil? ? true : count.to_i`
+7013,"@@ -174,7 +174,7 @@ class AdSenseDashboardWidget extends Component {
+ 								</div>
+ 							}
+ 							{ ! receivingData && (
+-								error ? getDataErrorComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), true, true, true )
++								error ? getDataErrorComponent( 'adsense', _x( 'AdSense', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'AdSense', 'Service name', 'google-site-kit' ), true, true, true )
+ 							) }
+ 							<div className={ classnames(
+ 								'mdc-layout-grid__cell',","See above, we don't need to pass the module name here.",Why do we need the `adsense` pre
+7014,"@@ -4,8 +4,10 @@ declare(strict_types=1);
+ 
+ namespace Shopsys\FrontendApiBundle\Controller;
+ 
++use BadMethodCallException;
+ use Overblog\GraphQLBundle\Controller\GraphController;
+ use Shopsys\FrontendApiBundle\Component\Domain\EnabledOnDomainChecker;
++use Shopsys\FrontendApiBundle\Model\GraphqlConfigurator;
+ use Symfony\Component\HttpFoundation\JsonResponse;
+ use Symfony\Component\HttpFoundation\Request;
+ use Symfony\Component\HttpFoundation\Response;","This is random line :-) overridden String type by custom trimmed - please change that commit message to something like ""introduced custom String type with automatic trimming""",Why do we need this?
+7015,"@@ -104,6 +104,19 @@ module.exports = function(realmConstructor) {
+ 
+         setConstructorOnPrototype(realmConstructor.Sync.User);
+         setConstructorOnPrototype(realmConstructor.Sync.Session);
++
++        if (realmConstructor.Sync._setFeatureToken) {
++            realmConstructor.Sync.setFeatureToken = function(featureToken) {
++                if (typeof featureToken !== 'string' || !featureToken instanceof String) {
++                    throw new Error(""featureToken should be a string"");
++                }
++
++                realmConstructor.Sync._setFeatureToken(featureToken.trim());
++            }
++
++            //enable depreciated setAccessToken
++            realmConstructor.Sync.setAccessToken = realmConstructor.Sync.setFeatureToken;
++        }
+     }
+ 
+     // TODO: Remove this now useless object.","My personal taste: ""depreciated"" -> ""deprecated""",I don't think this is needed.
+7016,"@@ -58,6 +58,8 @@ var (
+ 		""destinationPodName"",
+ 		""destinationPodNamespace"",
+ 		""destinationNodeName"",
++		""destinationClusterIP"",
++		""destinationServiceName"",
+ 	}
+ )
+ ",this includes the port as well right? should the name be `destinationServicePortName`?,Why do we need this?
+7017,"@@ -23,13 +23,15 @@ import os
+ import json
+ import logging
+ import socket
+-import time
+ import base64
+ 
+ from urllib.parse import urljoin, urlencode, urlparse
+ from urllib.request import urlopen, Request
+ from urllib.error import URLError
+ 
++from tenacity import retry
++from tenacity import wait_fixed
++from tenacity import stop_after_attempt
+ from luigi import configuration
+ from luigi.scheduler import RPC_METHODS
+ ",We can import all of them in one line.,Nit: I think this im
+7018,"@@ -1656,7 +1656,7 @@ interface StreamModule {
+ 
+         @Override
+         public Stream<T> appendAll(Iterable<? extends T> elements) {
+-            Objects.requireNonNull(queue, ""elements is null"");
++            Objects.requireNonNull(elements, ""elements is null"");
+             return isEmpty() ? Stream.ofAll(queue) : new AppendElements<>(head, queue.appendAll(elements), tail);
+         }
+ ","this was wrong, the rest were just inconsistent :)",nit: `requireNonNull
+7019,"@@ -23,7 +23,7 @@
+     </div>
+   </div>
+ 
+-  <div class=""row past-pr"">
++  <div id=""proposals-completed"" class=""row past-pr"">
+     <div class=""col-md-12"">
+       <h3>Recently Completed Purchase Requests</h3>
+     <%- if @approved_data.rows.any? %>",I gave them the EXACT SAME NAMES in my branch :),I think this should 
+7020,"@@ -96,6 +96,16 @@ func (*RunCLI) Run(args []string) int {
+ 		return 1
+ 	}
+ 
++	// Create uds dir and parents if not exists
++	dir := filepath.Dir(c.BindAddress.String())
++	if _, statErr := os.Stat(dir); os.IsNotExist(statErr) {
++		c.Log.WithField(""dir"", dir).Infof(""Creating spire agent UDS directory"")
++		if err := os.MkdirAll(dir, 0755); err != nil {
++			fmt.Fprintln(os.Stderr, err)
++			return 1
++		}
++	}
++
+ 	// Set umask before starting up the agent
+ 	cli.SetUmask(c.Log)
+ ",What would you think stat'ing the directory first before doing the log+mkdirall and only proceeding if the directory does not exist? The logging might be less confusing (I'd be wondering why it was logging that it was creating the directory when I knew it already existed).,"This should be `os.MkdirAll(dir, 0755)`"
+7021,"@@ -339,7 +339,7 @@ namespace Datadog.Trace.Agent
+             }
+ 
+             // Add the current keep rate to the root span
+-            var rootSpan = trace.Array[trace.Offset].Context.TraceContext?.RootSpan;
++            var rootSpan = trace.Array[trace.Offset].InternalContext.TraceContext?.RootSpan;
+             if (rootSpan is not null)
+             {
+                 var currentKeepRate = _traceKeepRateCalculator.GetKeepRate();","Sorry about the confusion, I'm trying to address that in the PR follow-up. If we ever have `Span` objects, then accessing their properties is going to be safe. The only question remaining is ""What is the runtime type for Scope.Span?"" and we just have to account for it when it is `Datadog.Trace.Span` and when it is not",Why is this change needed?
+7022,"@@ -9,6 +9,12 @@ import static com.github.javaparser.JavaParser.*;
+ import static com.github.javaparser.utils.Utils.EOL;
+ import static org.junit.Assert.*;
+ 
++import java.io.FileOutputStream;
++import java.io.IOException;
++import java.io.OutputStreamWriter;
++import java.io.Writer;
++import java.io.BufferedWriter;
++
+ public class JsonPrinterTest {
+     @Test
+     public void testWithType() {",I was using this imports for writing the results to file to more easily check that it was valid JSON. You can probably remove these `java.io` imports.,Why do we need these imports?
+7023,"@@ -21,6 +21,11 @@ type pid struct {
+ 	Pid int `json:""Pid""`
+ }
+ 
++type logentry struct {
++	Msg   string
++	Level string
++}
++
+ func TestNsenterValidPaths(t *testing.T) {
+ 	args := []string{""nsenter-exec""}
+ 	parent, child, err := newPipe()",You should probably include a `json:...` annotation here.,Why do we need this?
+7024,"@@ -38,6 +38,7 @@ import (
+ 
+ const (
+ 	ecsMaxReasonLength    = 255
++	ecsMaxRuntimeIDLength = 255
+ 	pollEndpointCacheSize = 1
+ 	pollEndpointCacheTTL  = 20 * time.Minute
+ 	roundtripTimeout      = 5 * time.Second",can container ID > 255 chars? why are we doing this check?,nit: can we call this `maxRuntimeIDLength`?
+7025,"@@ -111,6 +111,7 @@ return [
+     'prohibited'           => 'This field is prohibited.',
+     'prohibited_if'        => 'This field is prohibited when :other is :value.',
+     'prohibited_unless'    => 'This field is prohibited unless :other is in :values.',
++    'prohibits'            => 'This field field prohibits :other from being present.',
+     'same'                 => 'The value of this field must match the one from :other.',
+     'size'                 => [
+         'numeric' => 'The value must be :size.',","*""This **field field** prohibits :other from being present.""*, **field** word repeated is right?","Typo: ""from being present"" -> ""from being p"
+7026,"@@ -36,6 +36,7 @@ import (
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/flowexporter/flowrecords""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/interfacestore""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/metrics""
++	npl ""github.com/vmware-tanzu/antrea/pkg/agent/npl""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/openflow""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/proxy""
+ 	""github.com/vmware-tanzu/antrea/pkg/agent/querier""",nit: no need to add an alias for this case.,nit: can we call this just `npl`?
+7027,"@@ -4,15 +4,16 @@ import (
+ 	""fmt""
+ 	""io""
+ 	""os""
++	""strconv""
+ 	""sync""
+ )
+ 
+-var out io.Writer = os.Stdout
+-
+ // LogLevel of quic-go
+ type LogLevel uint8
+ 
+ const (
++	logEnv = ""QUIC_GO_LOG_LEVEL""
++
+ 	// LogLevelDebug enables debug logs (e.g. packet contents)
+ 	LogLevelDebug LogLevel = iota
+ 	// LogLevelInfo enables info logs (e.g. packets)",Or `QUIC_LOG_LEVEL`. Which one do you prefer?,I don't think we need this anymore.
+7028,"@@ -117,7 +117,14 @@ func GetDiskInfos(virtualHardware *ovf.VirtualHardwareSection, diskSection *ovf.
+ 				return diskInfos, err
+ 			}
+ 
+-			byteCapacity, err := Parse(int64(capacityRaw), *virtualDiscDesc.CapacityAllocationUnits)
++			var allocationUnits string
++			if virtualDiscDesc.CapacityAllocationUnits == nil ||
++				*virtualDiscDesc.CapacityAllocationUnits == """" {
++				allocationUnits = ""byte""
++			} else {
++				allocationUnits = *virtualDiscDesc.CapacityAllocationUnits
++			}
++			byteCapacity, err := Parse(int64(capacityRaw), allocationUnits)
+ 			if err != nil {
+ 				return diskInfos, err
+ 			}","Minor: you can set it to byte here and only set it to *virtualDiscDesc.CapacityAllocationUnits if that's not nil/"""". Saves two lines",Shouldn't this be `*capacityRaw`?
+7029,"@@ -70,6 +70,18 @@ class BucketViewTest(BaseWebTest, unittest.TestCase):
+                           headers=self.headers,
+                           status=400)
+ 
++    def test_buckets_can_handle_arbitrary_attributes(self):
++        bucket = MINIMALIST_BUCKET.copy()
++        fingerprint = ""5866f245a00bb3a39100d31b2f14d453""
++        bucket['data'] = {'fingerprint': fingerprint}
++        resp = self.app.put_json('/buckets/beers',
++                                 bucket,
++                                 headers=self.headers,
++                                 status=200)
++        data = resp.json['data']
++        self.assertIn('fingerprint', data)
++        self.assertEqual(data['fingerprint'], fingerprint)
++
+ 
+ class BucketCreationTest(BaseWebTest, unittest.TestCase):
+     def test_buckets_can_be_created_with_post(self):","While reading this I found that it makes actually little sense for ""beers"" to have a ""fingerprint"". We might want to do another pass on the examples here to use something that actually makes more sense to the reader. This could be done in another issue.",I think you can use `self.assertE
+7030,"@@ -365,7 +365,7 @@ public abstract class AbstractMultimapTest extends AbstractTraversableTest {
+     @Test
+     public void shouldConvertToMap() {
+         Multimap<Integer, Integer> mm = emptyIntInt().put(1, 2).put(1, 3);
+-        assertThat(mm.asMap().get(1).get().mkString("","")).isEqualTo(""2,3"");
++        assertThat(mm.asMap().get(1).get()).isEqualTo(HashSet.of(2, 3));
+     }
+ 
+     // -- biMap","Thank you! That's better, especially the conversion test should not test the mkString method :)",Why is this change needed?
+7031,"@@ -70,9 +70,10 @@ class ScintillaTextInfo(textInfos.offsets.OffsetsTextInfo):
+ 		return watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POSITIONFROMPOINT,x,y)
+ 
+ 	def _getPointFromOffset(self,offset):
++		location = self.obj.location
+ 		point=textInfos.Point(
+-		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTXFROMPOSITION,None,offset),
+-		watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTYFROMPOSITION,None,offset)
++			location.left + watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTXFROMPOSITION,None,offset),
++			location.top + watchdog.cancellableSendMessage(self.obj.windowHandle,SCI_POINTYFROMPOSITION,None,offset)
+ 		)
+ 		if point.x is not None and point.y is not None:
+ 			return point","You're basically converting client to screen coordinates here, doing it manually. Is there a specific reason why you aren't using clientToScreen here? Does it fail?",I think this should be `location.
+7032,"@@ -340,6 +340,10 @@ func Copy(ctx context.Context, f fs.Fs, dst fs.Object, remote string, src fs.Obj
+ 		}
+ 		// If can't server side copy, do it manually
+ 		if err == fs.ErrorCantCopy {
++			if fs.Config.MaxTransfer >= 0 && (accounting.Stats(ctx).GetBytes() >= int64(fs.Config.MaxTransfer) ||
++				(fs.Config.MaxTransferMode == fs.MaxTransferModeCautious && accounting.Stats(ctx).GetBytesWithPending()+src.Size() >= int64(fs.Config.MaxTransfer))) {
++				return nil, accounting.ErrorMaxTransferLimitReached
++			}
+ 			if doMultiThreadCopy(f, src) {
+ 				// Number of streams proportional to size
+ 				streams := src.Size() / int64(fs.Config.MultiThreadCutoff)","This needs to be done for server-side copies too, earlier in the function.",Shouldn't this be `&&` instead of `||`?
+7033,"@@ -26,7 +26,13 @@ import (
+ 	""github.com/lyft/clutch/backend/service""
+ )
+ 
+-var scopes = []string{oidc.ScopeOpenID, ""email""} // TODO(maybe): make scopes part of config?
++// TODO(maybe): make scopes part of config?
++// For more documentation on scopes see: https://developer.okta.com/docs/reference/api/oidc/#scopes
++var scopes = []string{
++	oidc.ScopeOpenID,
++	oidc.ScopeOfflineAccess, // offline_access is used to request issuance of a refresh_token
++	""email"",
++}
+ 
+ const Name = ""clutch.service.authn""
+ ",Do we want to add in `profile` here as well so we request access to the end user's default profile claims like name?,I don't think we need a separate scope 
+7034,"@@ -0,0 +1,10 @@
++module ProposalSpecHelper
++  def fully_approve(proposal)
++    proposal.individual_approvals.each do |approval|
++      approval.reload
++      approval.approve!
++    end
++    expect(proposal.reload).to be_approved # sanity check
++    deliveries.clear
++  end
++end",I am not sure what the difference between approving and full approving is...,Why do we need this?
+7035,"@@ -17,7 +17,7 @@ package main
+ import (
+ 	""time""
+ 
+-	""github.com/docopt/docopt-go""
++	docopt ""github.com/docopt/docopt-go""
+ 	log ""github.com/sirupsen/logrus""
+ 
+ 	""github.com/projectcalico/felix/iptables""",Please back out the import changes in files you haven't touched. I think these happen if you run goimports without having the vendor directory populated,Why did you change this?
+7036,"@@ -127,7 +127,7 @@ public class TestSubQueryTransformer extends SolrTestCaseJ4 {
+      //System.out.println(""p ""+peopleMultiplier+"" d ""+deptMultiplier);
+     assertQ(""subq1.fl is limited to single field"",
+         req(""q"",""name_s:(john nancy)"", ""indent"",""true"",
+-            ""fl"",""name_s_dv,depts:[subquery]"", 
++            ""fl"",""dept_ss_dv,name_s_dv,depts:[subquery]"", 
+             ""rows"","""" + (2 * peopleMultiplier),
+             ""depts.q"",""{!term f=dept_id_s v=$row.dept_ss_dv}"", 
+             ""depts.fl"",""text_t"",",Many tests in this class seem to have just been fortunate that `SolrIndexSearcher` ignored `fl` and retrieved all fields when not using lazy loading.,why did you change this test?
+7037,"@@ -14,7 +14,9 @@
+ # You should have received a copy of the GNU General Public License
+ # along with Scapy. If not, see <http://www.gnu.org/licenses/>.
+ 
+-# scapy.contrib.description = GENEVE
++# flake8: noqa: E501
++
++# scapy.contrib.description = Generic Network Virtualization Encapsulation (GENEVE)
+ # scapy.contrib.status = loads
+ 
+ """"""",Is this really needed?,This should be `# noqa: E501`
+7038,"@@ -39,8 +39,12 @@ module RSpec
+ 
+         example_group_aliases << name
+ 
+-        (class << RSpec; self; end).__send__(:define_method, name) do |*args, &example_group_block|
+-          RSpec.world.register RSpec::Core::ExampleGroup.__send__(name, *args, &example_group_block)
++        (class << RSpec; self; end).instance_exec do
++          remove_method(name) if method_defined?(name)
++
++          define_method(name) do |*args, &example_group_block|
++            RSpec.world.register RSpec::Core::ExampleGroup.__send__(name, *args, &example_group_block)
++          end
+         end
+ 
+         expose_example_group_alias_globally(name) if exposed_globally?",Is this necessary with line 38?,Why is this needed?
+7039,"@@ -148,7 +148,7 @@ if ""CI_EXTRA_COMPILE_ARGS"" in os.environ:
+ # https://stackoverflow.com/questions/29870629/pip-install-test-dependencies-for-tox-from-setup-py
+ test_deps = [
+     ""pandas"",
+-    ""pytest>=3.0"",
++    ""pytest>=3.1"",
+     ""pytest-cov"",
+     ""pytest-benchmark>=3.1"",
+ ]",DO we want to have >= here? Or ==,This should be `pytest>=3.2`
+7040,"@@ -10,7 +10,7 @@ namespace Datadog.Trace
+         /// <summary>
+         /// The environment of the profiled service.
+         /// </summary>
+-        public const string Env = ""env"";
++        public const string Env = CoreTags.Env;
+ 
+         /// <summary>
+         /// The version of the profiled service.","Can you also add this `""version""` tag to the CoreTags? Now that we're targeting the service/env/version trio",Should this be `CoreTags.Environment`?
+7041,"@@ -29,6 +29,14 @@ class SkuTest extends TestCase
+         $this->assertEquals($sku, $sku->getValue());
+     }
+ 
++    /**
++     * @expectedException \InvalidArgumentException
++     */
++    public function testInvalidVAlue(): void
++    {
++        $sku = new Sku('yKL3rWXluEM7NapnMSVpYHpicQJkpJ0Obfx91mma0xwnQxUfsrwy5Nfki1LUZR4qYolBTlUFDO4RkeINIkjPzMfTSit0bQZJevXA6GMsj0LnSZaiT1bBfr00vtKWqLAPollonRzb6GBVlT5U9I6nC49r3Vnj2jUgpA73CvfnVnFBNnHqCaI2Cu48SKaVSRGgROhoD1dGPvvq98okavZ3ktVHk0TcyyiyfoH52U3gP3J5bNTVZngivjPJAqtOW8TO');
++    }
++
+     /**
+      * @return array
+      */",This entry will be incompatible with the currently implemented formatting rules. Maximum 120 characters per line.,I think we can remove this line.
+7042,"@@ -234,7 +234,11 @@ module Beaker
+         output_callback = nil
+       else
+         @logger.debug ""\n#{log_prefix} #{Time.new.strftime('%H:%M:%S')}$ #{cmdline}""
+-        output_callback = logger.method(:host_output)
++        if @options[:preserve_host_output]
++          output_callback = logger.method(:preserve_host_output)
++        else
++          output_callback = logger.method(:host_output)
++        end
+       end
+ 
+       unless $dry_run",Let's call this color_host_output or some such - preserve_host_output makes it sound like you won't get any output without this being set.,I think this should be `@options[:pres
+7043,"@@ -6,7 +6,7 @@ var attr,
+ 	attrName,
+ 	allowed,
+ 	role = node.getAttribute('role'),
+-	attrs = node.attributes;
++	attrs = axe.utils.getNodeAttributes(node);
+ 
+ if (!role) {
+ 	role = axe.commons.aria.implicitRole(node);","suggestion: if we perhaps make `attributes` a getter in `virtualNode`, it does look seamless to access the property, same as what we have done for `isFocusable` or `tabbableElements`. `node.attributes` can become `virtualNode.attributes`",Why is this change needed?
+7044,"@@ -55,6 +55,7 @@ public class FeedMedia extends FeedFile implements Playable {
+     private Date playbackCompletionDate;
+     private int startPosition = -1;
+     private int playedDurationWhenStarted;
++    private String lastPlaybackSpeed = null;
+ 
+     // if null: unknown, will be checked
+     private Boolean hasEmbeddedPicture;",I think a float value fits better.,"// if null: unknown, will be checked"
+7045,"@@ -90,6 +90,11 @@ func (s *server) setupRouting() {
+ 		),
+ 	})
+ 
++	handle(router, ""/pss/{topic}/ws"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.pssPostHandler),
++		//""POST"": http.HandlerFunc(s.pssPostHandler), // WS does not use verbs
++	})
++
+ 	handle(router, ""/tags"", web.ChainHandlers(
+ 		s.gatewayModeForbidEndpointHandler,
+ 		web.FinalHandler(jsonhttp.MethodHandler{","This should be (POST,DELETE) `/pss/subscribe/{topic}` for subscriptions and there should be `/pss/send/{topic}` for sending.",Why is this needed?
+7046,"@@ -13,6 +13,9 @@ export function createContext(defaultValue) {
+ 		_id: '__cC' + i++,
+ 		_defaultValue: defaultValue,
+ 		Consumer(props, context) {
++			this.shouldComponentUpdate = function (_props, _state, _context) {
++				return _context !== context;
++			};
+ 			return props.children(context);
+ 		},
+ 		Provider(props) {",Closing over the closure arguments is a neat trick :+1: Love it :100:,Why do we need this?
+7047,"@@ -156,11 +156,12 @@ public class TestEvaluatior {
+   @Test
+   public void testCaseSensitiveNot() {
+     TestHelpers.assertThrows(
+-      ""X != x when case sensitivity is on"",
+-      ValidationException.class,
+-      ""Cannot find field 'X' in struct"",
+-      () -> { new Evaluator(STRUCT, not(equal(""X"", 7)), true); }
+-      );
++        ""X != x when case sensitivity is on"",
++        ValidationException.class,
++        ""Cannot find field 'X' in struct"",
++        () -> {
++          new Evaluator(STRUCT, not(equal(""X"", 7)), true);
++        });
+   }
+ 
+   @Test",Does this need to be a block or can it be an expression?,Why did you change this?
+7048,"@@ -148,7 +148,7 @@ public abstract class LoginAbstractAzkabanServlet extends
+     buf.append(""\"""");
+     buf.append(req.getMethod()).append("" "");
+     buf.append(req.getRequestURI()).append("" "");
+-    if (req.getQueryString() != null) {
++    if (req.getQueryString() != null && allowedPostRequest(req)) {
+       buf.append(req.getQueryString()).append("" "");
+     } else {
+       buf.append(""-"").append("" "");",req.getQueryString() != null is not necessary since same check is already done in allowedPostRequest,"Shouldn't this be `allowedPostRequest(req, false)`?"
+7049,"@@ -128,6 +128,8 @@ public abstract class DynamicLangXApiView implements ViewModel {
+   @Nullable
+   public abstract String grpcTransportImportName();
+ 
++  public abstract boolean isRestOnlyTransport();
++
+   @Override
+   public String resourceRoot() {
+     return SnippetSetRunner.SNIPPET_RESOURCE_ROOT;","As per go/actools-regapic-design, in the final product, generated GAPICs must be able to support multiple transports if supported by the API. For Java, we'll support this in the microgenerator; the monolith generates single-transport GAPICs. For PHP, the situation is likely similar, though on a longer timescale. All this to say that I would appreciate structuring the code in terms of ""supports REST"" rather than ""REST only"", but only where this doesn't require undue work. For everything else, please add a TODO to the effect of ""we're generating single-transport GAPICs for now, though in the fullness of time we'll generate multi-transport GAPICs.""",nit: `isRestOnlyTransport` -> `isRestOnlyTransport`
+7050,"@@ -13,5 +13,5 @@ return [
+     */
+ 
+     'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہیں رکھتیں۔',
+-    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی :seconds سیکنڈ میں دوبارہ کوشش کریں۔',
++    'throttle' => 'لاگ اِن کرنے کی بہت زیادہ کوششیں۔ براہِ مہربانی کچھ سیکنڈز میں دوبارہ کوشش کریں۔',
+ ];",here is `:seconds` missing again,'failed' => 'یہ تفصیلات ہمارے ریکارڈ سے مطابقت نہ،ں
+7051,"@@ -5,14 +5,14 @@ module DelayedJobsHelpers
+     end
+   end
+ 
+-  def stub_mail_method(method_name)
++  def stub_mail_method(klass, method_name)
+     stub('mail', deliver: true).tap do |mail|
+-      Mailer.stubs(method_name => mail)
++      klass.stubs(method_name => mail)
+     end
+   end
+ 
+-  def stub_mail_method_to_raise(method_name, error)
+-    Mailer.stubs(method_name).raises(error)
++  def stub_mail_method_to_raise(klass, method_name, error)
++    klass.stubs(method_name).raises(error)
+   end
+ end
+ ",Changed this helper to also get class name.,Style/RedundantSelf: Redundant self detected.
+7052,"@@ -35,6 +35,7 @@ public interface CapabilityType {
+   String PROXY = ""proxy"";
+   String SUPPORTS_WEB_STORAGE = ""webStorageEnabled"";
+   String ROTATABLE = ""rotatable"";
++  String APPLICATION_NAME = ""applicationName"";
+   // Enable this capability to accept all SSL certs by defaults.
+   String ACCEPT_SSL_CERTS = ""acceptSslCerts"";
+   String HAS_NATIVE_EVENTS = ""nativeEvents"";",I think there's another spot for this in DefaultCapabilityMatcher,Why do we need this?
+7053,"@@ -15,6 +15,9 @@
+ #include <valgrind/helgrind.h>
+ #endif
+ 
++// default actor batch size
++#define PONY_ACTOR_DEFAULT_BATCH 100
++
+ // Ignore padding at the end of the type.
+ pony_static_assert((offsetof(pony_actor_t, gc) + sizeof(gc_t)) ==
+    sizeof(pony_actor_pad_t), ""Wrong actor pad size!"");",Why the rename from PONY_SCHED_BATCH ? ACTOR_DEFAULT_BATCH is less meaningful to me than SCHED_BATCH.,Why do we need this?
+7054,"@@ -35,6 +35,10 @@ var log = logging.Logger(""/fil/storage"")
+ const makeDealProtocol = protocol.ID(""/fil/storage/mk/1.0.0"")
+ const queryDealProtocol = protocol.ID(""/fil/storage/qry/1.0.0"")
+ 
++// TODO: replace this with a queries to pick reasonable gas price and limits.
++const submitPostGasPrice = 0
++const submitPostGasLimit = 100000000000
++
+ // Miner represents a storage miner.
+ type Miner struct {
+ 	minerAddr      address.Address","Let's be sure we have an issue that tracks this, filed against testnet.",Why do we need this?
+7055,"@@ -9,6 +9,9 @@ function SIN(type, payload) {
+     SIN.super_.call(this, type, payload);
+     return;
+   }
++  if ( !Buffer.isBuffer(payload) ||  payload.length != 20)
++    throw new Error('Payload must be 20 bytes');
++
+   this.data = new Buffer(1 + 1 + payload.length);
+   this.converters = this.encodings['binary'].converters;
+   this._encoding = this.encodings['binary']._encoding;",There should be no space before !Buffer,Nit: extra space bef
+7056,"@@ -57,4 +57,6 @@ storiesOf( 'Global', module )
+ 				/>
+ 			</p>
+ 		</div>;
++	}, {
++		padding: 0,
+ 	} );","Same here, we need the default padding for this story.",Why is this needed?
+7057,"@@ -348,8 +348,12 @@ class InfluxListenStore(ListenStore):
+             int: the number of bytes this user's listens take in the dump file
+         """"""
+         self.log.info('Dumping user %s...', username)
++
++        t0 = time.time()
+         offset = 0
+         bytes_written = 0
++        listen_count = 0
++
+         # Get this user's listens in chunks
+         while True:
+             # loop until we get this chunk of listens","I think this should go away, its noise in the grand scheme of things.",I don't think this 
+7058,"@@ -1273,6 +1273,17 @@ func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err e
+ 			}
+ 		}
+ 
++		// Create/Remove git-daemon-export-ok for git-daemon...
++		daemonExportFile := path.Join(repo.RepoPath(), `git-daemon-export-ok`)
++		if repo.IsPrivate {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			os.Remove(daemonExportFile)
++		} else {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			f, _ := os.Create(daemonExportFile)
++			f.Close()
++		}
++
+ 		forkRepos, err := getRepositoriesByForkID(e, repo.ID)
+ 		if err != nil {
+ 			return fmt.Errorf(""getRepositoriesByForkID: %v"", err)",Maybe just call `ioutil.WriteFile` with 0 bytes? And Make an error log `log.Error` if any error occurs.,I'm not sure if thi
+7059,"@@ -490,6 +490,18 @@ class Builder {
+     return this;
+   }
+ 
++  /**
++   * Sets the {@link ie.ServiceBuilder} to use to manage the geckodriver
++   * child process when creating IE sessions locally.
++   *
++   * @param {ie.ServiceBuilder} service the service to use.
++   * @return {!Builder} a self reference.
++   */
++  setIeService(service) {
++    this.ieService_ = service;
++    return this;
++  }
++
+   /**
+    * Set {@linkplain edge.Options options} specific to Microsoft's Edge browser
+    * for drivers created by this builder. Any proxy settings defined on the",`this.ieService_` should be initialized to null in the constructor.,nit: `@return {!Bui
+7060,"@@ -313,11 +313,17 @@ func (r *DefaultRuleRenderer) filterOutputChain() *Chain {
+ 	// That decision is based on pragmatism; it's generally very useful to be able to contact
+ 	// any local workload from the host and policing the traffic doesn't really protect
+ 	// against host compromise.  If a host is compromised, then the rules could be removed!
++	// However, we do apply policy to workload ingress traffic if it belongs to an IPVS connection.
+ 	for _, prefix := range r.WorkloadIfacePrefixes {
+-		// If the packet is going to a worklaod endpoint, RETURN.
++		// If the packet is going to a workload endpoint, apply workload ingress policy if traffic
++		// belongs to an IPVS connection and return at the end.
+ 		log.WithField(""ifacePrefix"", prefix).Debug(""Adding workload match rules"")
+ 		ifaceMatch := prefix + ""+""
+ 		rules = append(rules,
++			Rule{
++				Match:  Match().OutInterface(ifaceMatch).IPVSConnection(),
++				Action: JumpAction{Target: ChainToWorkloadDispatch},
++			},
+ 			Rule{
+ 				Match:  Match().OutInterface(ifaceMatch),
+ 				Action: ReturnAction{},","I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?",I'm not sure if this is the best way to do this. I think it would be better to do this in the `ChainToWorkloadDispatch` action.
+7061,"@@ -35,7 +35,7 @@ public class PojoProducers implements BeanPostProcessor {
+     pojoMgr.register(pojoProducer.getSchemaId(), pojoProducer);
+   }
+ 
+-  public Collection<PojoProducerMeta> getProcucers() {
++  public Collection<PojoProducerMeta> getProducers() {
+     return pojoMgr.values();
+   }
+ ","This is public method , we need to deprecated this method first and add new updated method for it.",Why is this change needed?
+7062,"@@ -199,7 +199,10 @@ func generateNetworkTemplate(templateFilename string, wallets, relays, nodeHosts
+ 		newNode.NodeNameMatchRegex = """"
+ 		newNode.FractionApply = 0.0
+ 		newNode.Name = name
+-		newNode.IsRelay = true
++		if newNode.NetAddress == """" {
++			// if not set by relayTemplate ensure that it is a relay
++			newNode.NetAddress = ""0.0.0.0:4160""
++		}
+ 		newNode.Wallets = nil
+ 		host.Nodes = append(host.Nodes, newNode)
+ 		network.Hosts = append(network.Hosts, host)","I think that you don't want to have these workarounds; you want to make sure that the relayTemplates is configured correctly. If not, we need to fix it there.",why is this needed?
+7063,"@@ -306,7 +306,8 @@ public class ProtocolScheduleBuilder {
+             config.getEvmStackSize(),
+             isRevertReasonEnabled,
+             config.getEcip1017EraRounds(),
+-            quorumCompatibilityMode));
++            quorumCompatibilityMode,
++            config.getThanosBlockNumber()));
+ 
+     LOG.info(""Protocol schedule created with milestones: {}"", protocolSchedule.listMilestones());
+     return protocolSchedule;",This field is not needed.,Why do we need this change?
+7064,"@@ -6,7 +6,10 @@ class Subscriber::CancellationsController < ApplicationController
+   end
+ 
+   def create
+-    @cancellation = Cancellation.new(subscription: current_user.subscription)
++    @cancellation = Cancellation.new(
++      subscription: current_user.subscription,
++      reason: cancellation_params[:reason],
++    )
+ 
+     if @cancellation.schedule
+       redirect_to(",Put a comma after the last parameter of a multiline method call.,Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
+7065,"@@ -9,6 +9,7 @@ package e2etest
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/iotexproject/iotex-address/address""
+ 	""math/big""
+ 	""math/rand""
+ 	""testing""",move to line 18 below,File is not `goimports`-ed
+7066,"@@ -1,11 +1,16 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
++# This code example demonstrates how to upload an encrypted object to an
++# Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.ruby.s3_add_csaes_encrypt_item]
++
+ require 'aws-sdk-s3'
+ require 'openssl'
+ 
+-# Uploads an encrypted object to an Amazon S3 bucket.
+-#
++
+ # Prerequisites:
+ #
+ # - An Amazon S3 bucket.",Simple Storage **Service**,I think this should be `snippet-end`
+7067,"@@ -81,6 +81,19 @@ root
+ "")
+     end
+ 
++    it ""can output indented messages"" do
++      root = RSpec.describe(""root"")
++      root.example(""example"") {|example| example.reporter.message(""message"")}
++
++      root.run(reporter)
++
++      expect(formatter_output.string).to eql(""
++root
++  message
++  example
++"")
++    end
++
+     it ""strips whitespace for each row"" do
+       group = RSpec.describe("" root "")
+       context1 = group.describe("" nested "")","Thats odd, I'd actually not expect this output at all...","I think you can use `expect(formatter_output.string).to eq(""root message example"")`"
+7068,"@@ -53,7 +53,7 @@ module Travis
+         go_version_aliases: ENV.fetch(
+           'TRAVIS_BUILD_GO_VERSION_ALIASES', (
+             {
+-              '1' => '1.7.4',
++              '1' => '1.8',
+               '1.0' => '1.0.3',
+               '1.0.x' => '1.0.3',
+               '1.1.x' => '1.1.2',","As a side note, I get why this is up here (sort order), but it'd be easier to not forget to update it if it were down next to `1.x` -- would it be acceptable to make that change the next time I make this sort of PR? :smile: :innocent: (don't want to hold this one up since folks are blocked on getting this one in, it's a pretty superficial change, and I probably won't have cycles again for a few days to update the PR with the change :sweat_smile:)",I think this should be `1.8.x`
+7069,"@@ -92,14 +92,14 @@ public class AccountPermissioningControllerFactoryTest {
+   }
+ 
+   @Test
+-  public void createOnchainConfigWithAccountPermissioningDisabledShouldReturnEmpty() {
+-    SmartContractPermissioningConfiguration onchainConfig =
++  public void createFlexibleConfigWithAccountPermissioningDisabledShouldReturnEmpty() {
++    SmartContractPermissioningConfiguration flexibleConfig =
+         SmartContractPermissioningConfiguration.createDefault();
+-    assertThat(onchainConfig.isSmartContractAccountAllowlistEnabled()).isFalse();
++    assertThat(flexibleConfig.isSmartContractAccountAllowlistEnabled()).isFalse();
+ 
+     PermissioningConfiguration permissioningConfiguration =
+         new PermissioningConfiguration(
+-            Optional.empty(), Optional.of(onchainConfig), Optional.empty());
++            Optional.empty(), Optional.of(flexibleConfig), Optional.empty());
+ 
+     Optional<AccountPermissioningController> controller =
+         AccountPermissioningControllerFactory.create(","this class is permissioning so let's keep ""Onchain"" here",Typo: should be `Flexible`
+7070,"@@ -4,7 +4,7 @@ using System.Resources;
+ using System.Runtime.CompilerServices;
+ using System.Runtime.InteropServices;
+ 
+-// General Information about an assembly is controlled through the following 
++// General Information about an assembly is controlled through the following
+ // set of attributes. Change these attribute values to modify the information
+ // associated with an assembly.
+ [assembly: AssemblyTitle(""AutoRest"")]","we can be more specific to call out the it is ""AutoRest C# code generator""?",Please revert this file.
+7071,"@@ -124,3 +124,5 @@ class VirtualNode extends axe.AbstractVirtualNode {
+ 		return this._cache.boundingClientRect;
+ 	}
+ }
++
++axe.VirtualNode = VirtualNode;",Ditto for not adding this to the axe namespace.,Why do we need this?
+7072,"@@ -0,0 +1 @@
++package registration",Should we just remove this file? Having it present but empty feels misleading,
+7073,"@@ -69,6 +69,14 @@ func (tracker *PeerTracker) UpdateTrusted(ctx context.Context) error {
+ 	return tracker.updatePeers(ctx, tracker.trustedPeers()...)
+ }
+ 
++// Trust adds `pid` to the peer trackers trusted node set.
++func (tracker *PeerTracker) Trust(pid peer.ID) {
++	tracker.mu.Lock()
++	defer tracker.mu.Unlock()
++	tracker.trusted[pid] = struct{}{}
++	logPeerTracker.Infof(""Trusting peer=%s"", pid.Pretty())
++}
++
+ // Track adds information about a given peer.ID
+ func (tracker *PeerTracker) Track(ci *types.ChainInfo) {
+ 	tracker.mu.Lock()",Would it make sense to include an `Untrust` as well? If I were playing around with this on the CLI I wouldn't want to make a change I couldn't undo.,I
+7074,"@@ -43,6 +43,13 @@ use VuFindSearch\Backend\Solr\Response\Json\RecordCollectionFactory;
+  */
+ class SolrDefaultBackendFactory extends AbstractSolrBackendFactory
+ {
++    /**
++     * Callback for creating a record driver.
++     *
++     * @var string
++     */
++    protected $createRecordCallback = 'getSolrRecord';
++
+     /**
+      * Constructor
+      */","It might be better to call this `$createRecordMethod` since it's not a full PHP callback, just a method name for the plugin manager.",W
+7075,"@@ -15,7 +15,12 @@ namespace Thelia\Action;
+ use Symfony\Component\EventDispatcher\EventDispatcherInterface;
+ use Symfony\Component\EventDispatcher\EventSubscriberInterface;
+ use Thelia\Core\Event\Cart\CartEvent;
++use Thelia\Core\Event\Currency\CurrencyChangeEvent;
+ use Thelia\Core\Event\TheliaEvents;
++use Thelia\Core\HttpFoundation\Request;
++use Thelia\Core\HttpFoundation\Session\Session;
++use Thelia\Log\Tlog;
++use Thelia\Model\Currency;
+ use Thelia\Model\ProductPrice;
+ use Thelia\Model\ProductPriceQuery;
+ use Thelia\Model\CartItem;",remove this line,P
+7076,"@@ -24,7 +24,7 @@ class NavigationManager
+     protected $callbacks = [];
+ 
+     /**
+-     * @var array List of registered items.
++     * @var MainMenuItem[] List of registered items.
+      */
+     protected $items;
+ ","I've never seen this syntax before, it's still just an array, the difference is that it's an array of MainMenuItems instead of an array of arrays.",This should be `MainMenuItem[]`.
+7077,"@@ -1532,10 +1532,15 @@ map_api_set_dll(const char *name, privmod_t *dependent)
+              str_case_prefix(name, ""API-MS-Win-Eventing-Provider-L1-1""))
+         return ""kernelbase.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-Core-PrivateProfile-L1-1"") ||
+-             str_case_prefix(name, ""API-MS-Win-Core-Atoms-L1-1""))
++             str_case_prefix(name, ""API-MS-Win-Core-Atoms-L1-1"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Localization-Obsolete-L1-2"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Kernel32-private-L1-1""))
+         return ""kernel32.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-Core-WinRT-Error-L1-1""))
+         return ""combase.dll"";
++    else if (str_case_prefix(name, ""API-MS-Win-Core-Appinit-L1-1"") ||
++             str_case_prefix(name, ""API-MS-Win-Core-Com-L1-1""))
++        return ""ole32.dll"";
+     else if (str_case_prefix(name, ""API-MS-Win-GDI-"")) {
+         /* We've seen many different GDI-* */
+         return ""gdi32full.dll"";",nit: to match the others: s/private/Private/,I think this should be `API-MS-W
+7078,"@@ -96,8 +96,9 @@ namespace Nethermind.Network
+ 
+         public IReadOnlyCollection<Peer> ActivePeers => _activePeers.Values.ToList().AsReadOnly();
+         public IReadOnlyCollection<Peer> CandidatePeers => _peerPool.CandidatePeers.ToList();
++        public IReadOnlyCollection<Peer> ConnectedPeers => _activePeers.Values.Where(IsConnected).ToList().AsReadOnly();
+         private int AvailableActivePeersCount => MaxActivePeers - _activePeers.Count;
+-        private int MaxActivePeers => _networkConfig.ActivePeersMaxCount + _peerPool.StaticPeerCount;
++        public int MaxActivePeers => _networkConfig.ActivePeersMaxCount + _peerPool.StaticPeerCount;
+ 
+         public void Init()
+         {",Maybe just IEnumerable? Not sure myself.,Why is this public?
+7079,"@@ -54,7 +54,8 @@ public abstract class TestIcebergSourceHiveTables extends TestIcebergSourceTable
+   @Override
+   public Table createTable(TableIdentifier ident, Schema schema, PartitionSpec spec) {
+     TestIcebergSourceHiveTables.currentIdentifier = ident;
+-    return TestIcebergSourceHiveTables.catalog.createTable(ident, schema, spec);
++    Table table = TestIcebergSourceHiveTables.catalog.createTable(ident, schema, spec);
++    return table;
+   }
+ 
+   @Override",do we need this change?,Why is this change needed?
+7080,"@@ -586,7 +586,17 @@ func (s *Server) configureAccounts() error {
+ 	// Check opts and walk through them. We need to copy them here
+ 	// so that we do not keep a real one sitting in the options.
+ 	for _, acc := range s.opts.Accounts {
+-		a := acc.shallowCopy()
++		var a *Account
++		if acc.Name == globalAccountName {
++			a = s.gacc
++		} else {
++			a = acc.shallowCopy()
++		}
++		if acc.hasMappings() {
++			// For now just move and wipe from opts.Accounts version.
++			a.mappings = acc.mappings
++			acc.mappings = nil
++		}
+ 		acc.sl = nil
+ 		acc.clients = nil
+ 		s.registerAccountNoLock(a)","Would want @matthiashanel to have a look since if I recall he had to add the shallowCopy() to fix some bugs during reload. That being said, since I believe the $G account cannot referenced in configurations, this should not be a problem, but Matthias has looked at this in more details in the past.",Why do we need to do this?
+7081,"@@ -320,3 +320,19 @@ func (volInfo *VolumeInfo) GetNodeName() string {
+ 	}
+ 	return """"
+ }
++
++// GetVolumeStatus returns the status of the volume
++func (volInfo *VolumeInfo) GetVolumeStatus() string {
++	if len(volInfo.Volume.Status.Reason) > 0 {
++		return volInfo.Volume.Status.Reason
++	}
++	return volumeStatusOK
++}
++
++// GetVolumeNamespace returns the status of the volume
++func (volInfo *VolumeInfo) GetVolumeNamespace() string {
++	if len(volInfo.Volume.ObjectMeta.Namespace) > 0 {
++		return volInfo.Volume.ObjectMeta.Namespace
++	}
++	return ""N/A""
++}",The descriptions are incorrect,Why not just return volInf
+7082,"@@ -1229,6 +1229,14 @@ class WebDriver {
+     if (target && cdpTargets.indexOf(target.toLowerCase()) === -1) {
+       throw new error.InvalidArgumentError('invalid target value')
+     }
++
++    if (debuggerAddress.match(/\/se\/cdp/)) {
++      if (debuggerAddress.match(""ws:\/\/"", ""http:\/\/"")) {
++        return debuggerAddress.replace(""ws:\/\/"", ""http:\/\/"") 
++      }
++      return debuggerAddress
++    }
++
+     const path = '/json/version'
+     let request = new http.Request('GET', path)
+     let client = new http.HttpClient('http://' + debuggerAddress)",if we are returning the `ws` here when passing in `se:cdp` we can just return it straight or do we have to make a request to get the `ws` address?,I don't think this is the 
+7083,"@@ -1749,7 +1749,8 @@ class CommandDispatcher:
+             elif going_up and tab.scroller.pos_px().y() > old_scroll_pos.y():
+                 message.info(""Search hit TOP, continuing at BOTTOM"")
+         else:
+-            message.warning(""Text '{}' not found on page!"".format(text))
++            message.warning(""Text '{}' not found on page!"".format(text),
++                    replace=True)
+ 
+     @cmdutils.register(instance='command-dispatcher', scope='window',
+                        maxsplit=0)",Please only indent this by four spaces.,`replace=True` is the defa
+7084,"@@ -74,7 +74,7 @@ func isLink(s string) bool {
+ 
+ func randString(n int) string {
+ 	gen := rand.New(rand.NewSource(time.Now().UnixNano()))
+-	letters := ""abcdefghijklmnopqrstuvwxyz""
++	letters := ""bdghjlmnpqrstvwxyz0123456789""
+ 	b := make([]byte, n)
+ 	for i := range b {
+ 		b[i] = letters[gen.Int63()%int64(len(letters))]",What's the reason behind these characters?,Why did you change this?
+7085,"@@ -13,9 +13,12 @@ describe ParallelDispatcher do
+     end
+ 
+     it 'creates a new token for each approver' do
+-      expect(ApiToken).to receive(:create!).exactly(2).times
+       expect(dispatcher).to receive(:send_notification_email).twice
+       dispatcher.deliver_new_cart_emails(cart)
++
++      cart.approver_approvals.each do |approval|
++        expect(approval.api_token.expires_at).to be > Time.now
++      end
+     end
+ 
+     it 'sends a cart notification email to observers' do",Minor: The name of this specs seems a little off now,I'm not sure if this is 
+7086,"@@ -1126,10 +1126,12 @@ ast_result_t pass_syntax(ast_t** astp, pass_opt_t* options)
+     case TK_VALUEFORMALARG:
+     case TK_VALUEFORMALPARAM:
+       ast_error(options->check.errors, ast,
+-        ""Value formal parameters not yet supported"");
++        ""Value formal parameters not yet supported. ""
++        ""Note that many functions including array indexing use the apply ""
++        ""method raher than square brackets"");
+       r = AST_ERROR;
+       break;
+-
++    
+     case TK_CONSTANT:
+       ast_error(options->check.errors, ast,
+         ""Compile time expressions not yet supported"");",I'd suggest using `ast_error_continue` here to get the `apply` message in the `Info` part of the error report.,I think it would be bett
+7087,"@@ -72,6 +72,13 @@ class SearchTabsHelper extends \Laminas\View\Helper\AbstractHelper
+      */
+     protected $permissionConfig;
+ 
++    /**
++     * Tab detailed configuration
++     *
++     * @var array
++     */
++    protected $detailConfig;
++
+     /**
+      * Request
+      *","If we decide to change the name of the .ini setting, we might also want to review the naming of this property and related code. Maybe a simple `getOptions` or `getSettings` would be more concise than `getTabDetailConfig`. At very least, I don't think we need Tab in the method name since the method belongs to a helper with ""Tabs"" in the name.",Why do we need this prop
+7088,"@@ -175,6 +175,10 @@ func isListResource(msg *beehiveModel.Message) bool {
+ 			return true
+ 		}
+ 	}
++	// user data
++	if msg.GetGroup() == ""user"" {
++		return true
++	}
+ 
+ 	return false
+ }","Use const for ""user"", same as below","if msg.GetGroup() == ""group"" {"
+7089,"@@ -79,6 +79,7 @@ class Newsletter extends BaseAction implements EventSubscriberInterface
+             $nl->setEmail($event->getEmail())
+                 ->setFirstname($event->getFirstname())
+                 ->setLastname($event->getLastname())
++                ->setUnsubscribed(0)
+                 ->setLocale($event->getLocale())
+                 ->save();
+ ",->setUnsubscribed(false) would be better :),Shouldn't this be `$event->get
+7090,"@@ -0,0 +1,11 @@
++# frozen_string_literal: true
++
++module Faker
++  class Sports < Base
++    class << self
++      def name
++        fetch('sports.name')
++      end
++    end
++  end
++end","I now think singular `Sport` is better, but I will wait for the first round of feedback before updating.",Layout/TrailingBlankLines: Fin
+7091,"@@ -167,6 +167,9 @@ class UserResource:
+             parent_id=parent_id,
+             auth=auth)
+ 
++        # Initialize timestamp as soon as possible.
++        self.timestamp
++
+         self.request = request
+         self.context = context
+         self.record_id = self.request.matchdict.get('id')",Don't you need = something ?,Why do we need this?
+7092,"@@ -1869,10 +1869,12 @@ bool CoreChecks::ValidateCmdQueueFlags(const CMD_BUFFER_STATE *cb_node, const ch
+                                        const char *error_code) const {
+     auto pool = cb_node->command_pool.get();
+     if (pool) {
+-        VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[pool->queueFamilyIndex].queueFlags;
++        const uint32_t queue_family_index = pool->queueFamilyIndex;
++        const VkQueueFlags queue_flags = GetPhysicalDeviceState()->queue_family_properties[queue_family_index].queueFlags;
+         if (!(required_flags & queue_flags)) {
+             string required_flags_string;
+-            for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT}) {
++            for (auto flag : {VK_QUEUE_TRANSFER_BIT, VK_QUEUE_GRAPHICS_BIT, VK_QUEUE_COMPUTE_BIT, VK_QUEUE_SPARSE_BINDING_BIT,
++                              VK_QUEUE_PROTECTED_BIT}) {
+                 if (flag & required_flags) {
+                     if (required_flags_string.size()) {
+                         required_flags_string += "" or "";",Looks like this could be `const` (I realize it wasn't like that before)?,Why do we need to add these flags?
+7093,"@@ -7,7 +7,8 @@ import com.fsck.k9.message.preview.PreviewResult.PreviewType;
+ public enum DatabasePreviewType {
+     NONE(""none"", PreviewType.NONE),
+     TEXT(""text"", PreviewType.TEXT),
+-    ENCRYPTED(""encrypted"", PreviewType.ENCRYPTED);
++    ENCRYPTED(""encrypted"", PreviewType.ENCRYPTED),
++    FAILED_TO_LOAD(""failedToLoad"", PreviewType.FAILED_TO_LOAD);
+ 
+ 
+     private final String databaseValue;",Maybe just `FAILED`. We can't be sure loading was the thing that failed.,I think this should be `FAILED_TO_
+7094,"@@ -1,5 +1,5 @@
+-define(['loading', 'appRouter', 'layoutManager', 'connectionManager', 'userSettings', 'cardBuilder', 'datetime', 'mediaInfo', 'backdrop', 'listView', 'itemContextMenu', 'itemHelper', 'dom', 'indicators', 'imageLoader', 'libraryMenu', 'globalize', 'browser', 'events', 'playbackManager', 'scrollStyles', 'emby-itemscontainer', 'emby-checkbox', 'emby-button', 'emby-playstatebutton', 'emby-ratingbutton', 'emby-scroller', 'emby-select'], function (loading, appRouter, layoutManager, connectionManager, userSettings, cardBuilder, datetime, mediaInfo, backdrop, listView, itemContextMenu, itemHelper, dom, indicators, imageLoader, libraryMenu, globalize, browser, events, playbackManager) {
+-    'use strict';
++define([""loading"", ""appRouter"", ""layoutManager"", ""connectionManager"", ""userSettings"", ""cardBuilder"", ""datetime"", ""mediaInfo"", ""backdrop"", ""listView"", ""itemContextMenu"", ""itemHelper"", ""dom"", ""indicators"", ""imageLoader"", ""libraryMenu"", ""globalize"", ""browser"", ""events"", ""playbackManager"", ""scrollStyles"", ""emby-itemscontainer"", ""emby-checkbox"", ""emby-button"", ""emby-playstatebutton"", ""emby-ratingbutton"", ""emby-scroller"", ""emby-select""], function (loading, appRouter, layoutManager, connectionManager, userSettings, cardBuilder, datetime, mediaInfo, backdrop, listView, itemContextMenu, itemHelper, dom, indicators, imageLoader, libraryMenu, globalize, browser, events, playbackManager) {
++    ""use strict"";
+ 
+     function getPromise(apiClient, params) {
+         var id = params.id;","You have replaced single quotes with double ones, this fails linting and our current coding style. Please fix this, otherwise it's a whopping of 1200 LoC while in reality it should be rather small.",Why did you change this?
+7095,"@@ -43,6 +43,9 @@ public class PlaybackPreferences implements
+ 	/** True if last played media was a video. */
+ 	public static final String PREF_CURRENT_EPISODE_IS_VIDEO = ""de.danoeh.antennapod.preferences.lastIsVideo"";
+ 
++	/** Value of PREF_QUEUE_ADD_TO_FRONT if no media is playing. */
++	public static final String PREF_QUEUE_ADD_TO_FRONT = ""prefQueueAddToFront"";
++
+ 	/** Value of PREF_CURRENTLY_PLAYING_MEDIA if no media is playing. */
+ 	public static final long NO_MEDIA_PLAYING = -1;
+ ","@danieloeh @TomHennen. Some of these files are using spaces, the others use tabs. Is there a project wide preference? I personally like spaces, because they are consistent across editors",This should be `PREF_QUEUE_ADD_TO_
+7096,"@@ -11,10 +11,12 @@ module Blacklight
+     # @param [SolrDocument] document
+     # @param [ActionView::Base] view_context scope for linking and generating urls
+     # @param [Blacklight::Configuration] configuration
+-    def initialize(document, view_context, configuration = view_context.blacklight_config)
++    # @param [Integer] counter what offset in the search result is this record (used for tracking)
++    def initialize(document, view_context, configuration = view_context.blacklight_config, counter: nil)
+       @document = document
+       @view_context = view_context
+       @configuration = configuration
++      @counter = counter
+     end
+ 
+     # @return [Hash<String,Configuration::Field>]  all the fields for this index view that should be rendered","I guess this is ok for backwards-compatibility? Maybe it'd be better to check arity in the helpers? Or just call it out in the release notes, because there are at least a couple projects on github that overrode `initialize`..",I think this should be `@counter = counter || 0`
+7097,"@@ -194,8 +194,8 @@ public class AzkabanWebServer extends AzkabanServer {
+     // TODO remove hack. Move injection to constructor
+     executorManager = SERVICE_PROVIDER.getInstance(ExecutorManager.class);
+     projectManager = SERVICE_PROVIDER.getInstance(ProjectManager.class);
++    triggerManager = SERVICE_PROVIDER.getInstance(TriggerManager.class);
+ 
+-    triggerManager = loadTriggerManager(props);
+     loadBuiltinCheckersAndActions();
+ 
+     // load all trigger agents here","At some point, we would like to get rid of these custom injections as well. Looks Ok for now.",Why is this removed?
+7098,"@@ -349,6 +349,13 @@ namespace Datadog.Trace.Configuration
+             /// </summary>
+             /// <seealso cref=""TracerSettings.DelayWcfInstrumentationEnabled""/>
+             public const string DelayWcfInstrumentationEnabled = ""DD_TRACE_DELAY_WCF_INSTRUMENTATION_ENABLED"";
++
++            /// <summary>
++            /// Enables a fix around header tags normalization.
++            /// We used to normalize periods even if a tag was provided for a header, whereas we should not.
++            /// This flag defaults to true and is here in case customers need retrocompatibility only
++            /// </summary>
++            public const string HeaderTagsNormalizationFixEnabled = ""DD_TRACE_HEADER_TAG_NORMALIZATION_FIX_ENABLED"";
+         }
+     }
+ }","nit: Not a fan of ""fix"" in the name, but don't have a better suggestion  ",nit: typo `retrocompatibility`
+7099,"@@ -181,6 +181,11 @@ class TabWidget(QTabWidget):
+         except qtutils.QtValueError:
+             fields['current_url'] = ''
+ 
++        try:
++            fields['protocol'] = self.tab_url(idx).scheme()
++        except qtutils.QtValueError:
++            fields['protocol'] = ''
++
+         y = tab.scroller.pos_perc()[1]
+         if y is None:
+             scroll_pos = '???'","Since we're calling `self.tab_url(idx)` a third time here already, can you please add a `url = self.tab_url(idx)` somewhere above (e.g. after all the `fields[...] = ...` assignments) and change the calls here to `url.host()` etc.?",This should be `fields['protocol'] = 'http'`
+7100,"@@ -15,8 +15,8 @@
+ """"""Forseti CLI installer.""""""
+ 
+ from forseti_installer import ForsetiInstaller
+-
+ from util import gcloud
++from util import constants
+ 
+ class ForsetiClientInstaller(ForsetiInstaller):
+     """"""Forseti command line interface installer""""""",alphasort this import,Why do we need this?
+7101,"@@ -0,0 +1,14 @@
++#include<iostream>
++using namespace std;
++void reverseNum(int digit){
++	while(digit>0){
++		int n=digit%10;
++		digit=digit/10;
++		cout<<n<<""\t"";
++	}
++}
++int main(){
++	int digit;
++	cin>>digit;
++	reverseNum(digit);
++}",remove this file!,Add a new line at th
+7102,"@@ -256,11 +256,14 @@ func (acc *Account) String() string {
+ 			etas = ""0s""
+ 		}
+ 	}
++
+ 	name := []rune(acc.name)
+ 	if fs.Config.StatsFileNameLength > 0 {
+ 		if len(name) > fs.Config.StatsFileNameLength {
+-			where := len(name) - fs.Config.StatsFileNameLength
+-			name = append([]rune{'.', '.', '.'}, name[where:]...)
++			suffixLength := fs.Config.StatsFileNameLength / 2
++			prefixLength := fs.Config.StatsFileNameLength - suffixLength
++			suffixStart := len(name) - suffixLength
++			name = append(append(name[:prefixLength], '…'), name[suffixStart:]...)
+ 		}
+ 	}
+ ",You don't need to say `rune(' ')` - `' '` is already a `rune`.,I think this should 
+7103,"@@ -38,7 +38,7 @@ module Selenium
+         port
+       end
+ 
+-      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL]
++      IGNORED_ERRORS = [Errno::EADDRNOTAVAIL].freeze
+       IGNORED_ERRORS << Errno::EBADF if Platform.cygwin?
+       IGNORED_ERRORS.freeze
+ ",We can't freeze this and then add something to it in the next line. The `freeze` on line 43 is sufficient. If Rubocop flags this we need to exclude it.,Why is this necessar
+7104,"@@ -0,0 +1,5 @@
++package javaslang.control;
++
++public interface Kind<TYPE extends Kind<TYPE, ?, ?>, E, T> {
++
++}",We call it Kind2 and move out of the `javaslang/control` package into the `javaslang`package. Maybe I will later generate Kind1..Kindn but that's another story.,Why do we need this interface?
+7105,"@@ -166,7 +166,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
+-	db.logger.Infof(""db capacity: %v"", db.capacity)
++	db.logger.Infof(""database capacity in chunks (and in Bytes): %v (%v)"", db.capacity, db.capacity*swarm.ChunkSize)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","i think it might be nicer to have a message like: `database capacity: %d chunks (%d bytes, %d megabytes)`. counting in bytes is so 90s :)",I think this should be `db.cap
+7106,"@@ -195,6 +195,16 @@ public class Constants {
+ 
+     // dir to keep dependency plugins
+     public static final String DEPENDENCY_PLUGIN_DIR = ""azkaban.dependency.plugin.dir"";
++
++    /*
++     * Prefix used to construct Hadoop/Spark user job link.
++     * a) RM: resource manager
++     * b) JHS: Hadoop job history server
++     * c) SHS: spark job history server
++     * */
++    public static final String AZKABAN_RM_JOB_LINK = ""azkaban.rm.job.link"";
++    public static final String AZKABAN_JHS_JOB_LINK = ""azkaban.jhs.job.link"";
++    public static final String AZKABAN_SHS_JOB_LINK = ""azkaban.shs.job.link"";
+   }
+ 
+   public static class FlowProperties {","The '.' in the key names are used to separate namespaces, NOT to separate words. How about azkaban.external_resources.resource_manager? ---- Why is it better than using the full name in the variable name e.g. RESOURCE_MANAGER_LINK ?",Why do we need this?
+7107,"@@ -17,7 +17,7 @@
+ using BenchmarkDotNet.Attributes;
+ using Benchmarks.Tracing;
+ using OpenTelemetry.Trace;
+-using OpenTelemetry.Trace.Configuration;
++using OpenTelemetry.Trace;
+ using OpenTelemetry.Trace.Samplers;
+ 
+ namespace Benchmarks",This seems to be duplicated with line 19?,Why was this removed?
+7108,"@@ -20,7 +20,7 @@
+ #endif
+ 
+ #if !(defined(_WIN32) || (defined(__WXMAC__) && (MAC_OS_X_VERSION_MIN_REQUIRED < MAC_OS_X_VERSION_10_4)))
+-#include <xlocale.h>
++#include <wx/xlocale.h>
+ #endif
+ 
+ #include ""stdwx.h""","This is wrong. xlocale.h is needed on OSX and maybe elsewhere too. This needs a test in configure to see if xlocale.h and uselocale() are available and an #if test here. Also, the NO_PER_THREAD_LOCALE stuff in configure.ac needs to be updated to include test for uselocale().",This should be `<wx/locale.h>`
+7109,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DeleteAccessKey.java demonstrates how to delete an access key from an AWS Identity and Access Management (IAM) user.]
++//snippet-sourcedescription:[DeleteAccessKey.java demonstrates how to delete an access key from an AWS Identity and Access Management (AWS IAM) user.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),I'm not sure if this is a typo
+7110,"@@ -138,7 +138,7 @@ utils.imageReplacement = function(ResourceModel, src, resources, resourceBaseUrl
+ 	}
+ 
+ 	const mime = resource.mime ? resource.mime.toLowerCase() : '';
+-	if (ResourceModel.isSupportedImageMimeType(mime)) {
++	if (ResourceModel.isSupportedImageMimeType(mime) || ResourceModel.isSupportedAudioMimeType(mime)) {
+ 		let newSrc = `./${ResourceModel.filename(resource)}`;
+ 		if (resourceBaseUrl) newSrc = resourceBaseUrl + newSrc;
+ 		newSrc += `?t=${resource.updated_time}`;","Why did you have multiple function calls here instead of having one long array of supported mimeTypes? In line with your PR here, I think we might eventually see inline videos or inline pdf. It would be great to generalize this a bit.",Shouldn't this be `||` instead
+7111,"@@ -37,6 +37,7 @@ from pyspark.sql.types import (
+     LongType,
+     StringType,
+     TimestampType,
++    NumericType,
+ )
+ 
+ from databricks import koalas as ks  # For running doctests and reference resolution in PyCharm.",nit: shall we keep alphabetical order?,Why do we need this?
+7112,"@@ -106,6 +106,15 @@ export default class Realm {
+         let method = util.createMethod(objectTypes.REALM, 'objects');
+         return method.apply(this, [type, ...args]);
+     }
++
++    objectForPrimaryKey(type, ...args) {
++        if (typeof type == 'function') {
++            type = objects.typeForConstructor(this[keys.realm], type);
++        }
++
++        let method = util.createMethod(objectTypes.REALM, 'objectForPrimaryKey');
++        return method.apply(this, [type, ...args]);
++    }
+ }
+ 
+ // Non-mutating methods:",We could just move the check for function into `typeForConstruction` to make this a one liner every time we need to do this.,Why is this needed?
+7113,"@@ -153,7 +153,7 @@ public class I18nTest extends JUnit4TestBase {
+     assertThat(ime.isActivated()).isTrue();
+     assertThat(ime.getActiveEngine()).isEqualTo(desiredEngine);
+ 
+-    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to convert the word.
++    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to transform the word.
+     input.sendKeys(""toukyou "");
+     input.sendKeys(Keys.ENTER);
+ ",A correct by unrelated change. We'll slide this one in without another word ;),I think this should
+7114,"@@ -40,6 +40,9 @@ Solver<Dtype>::Solver(const SolverParameter& param)
+ template <typename Dtype>
+ void Solver<Dtype>::Solve(const char* resume_file) {
+   Caffe::set_mode(Caffe::Brew(param_.solver_mode()));
++  if (param_.solver_mode()) {
++    Caffe::SetDevice(param_.device_id());
++  }
+   Caffe::set_phase(Caffe::TRAIN);
+   LOG(INFO) << ""Solving "" << net_->name();
+   PreSolve();","I feel that a slightly safer way is to do if (param_.has_device_id()) { Caffe::SetDevice(param_.device_id()); } just in case a user has hard-coded a device id outside the solver and does not specify the device id in the solver param. Currently, if nothing is set, the solver will always use the 0th device, which might not be desired.",Why is this needed?
+7115,"@@ -321,6 +321,7 @@ class TestSeleniumScriptBuilder(SeleniumTestCase):
+                             ""closeWindow('that_window')"",
+                             ""submitByName(\""toPort\"")"",
+                             ""scriptEval(\""alert('This is Sparta');\"")"",
++                            ""rawCode(multi(1)\n  line(2)\n    block(33))"",
+                             {""dragByID(address)"": ""elementByName(toPort)""},
+                             ""switchFrameByName('my_frame')"",
+                             ""switchFrameByIdx(1)"",","let's replace this example with something that won't fail in Python. Like ""for+if+print""","""rawCode(multi(1)\n"
+7116,"@@ -268,7 +268,8 @@ def _to_graphviz(tree_info, show_info, feature_names, precision=None,
+         raise ImportError('You must install graphviz to plot tree.')
+ 
+     def float2str(value, precision=None):
+-        return ""{0:.{1}f}"".format(value, precision) if precision is not None else str(value)
++        return ""{0:.{1}f}"".format(value, precision) \
++            if (precision is not None) and (not isinstance(value, str)) else str(value)
+ 
+     def add(root, parent=None, decision=None):
+         """"""recursively add node or edge""""""",Please remove the brackets and use `string_type` from `compat.py` module instead of `str` in `isinstance()`.,Why is this change needed?
+7117,"@@ -36,16 +36,11 @@ type Execution struct {
+ }
+ 
+ // NewExecution returns a Execution instance
+-func NewExecution(executorAddress string, contractAddress string, nonce uint64, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) (*Execution, error) {
+-	if executorAddress == """" {
+-		return nil, errors.Wrap(ErrAddress, ""address of the executor is empty"")
+-	}
+-
++func NewExecution(contractAddress string, nonce uint64, amount *big.Int, gasLimit uint64, gasPrice *big.Int, data []byte) (*Execution, error) {
+ 	return &Execution{
+ 		AbstractAction: AbstractAction{
+ 			version:  version.ProtocolVersion,
+ 			nonce:    nonce,
+-			srcAddr:  executorAddress,
+ 			dstAddr:  contractAddress,
+ 			gasLimit: gasLimit,
+ 			gasPrice: gasPrice,",line is 143 characters (from `lll`),Why remove this check?
+7118,"@@ -94,7 +94,11 @@ func NewController(params Params) (types.Controller, error) {
+ 						for i := 0; i < items.Len(); i++ {
+ 							item := items.Index(i).Addr().Interface().(InnerObjectWithSelector)
+ 							for _, record := range item.GetStatus().Experiment.Records {
+-								if controller.ParseNamespacedName(record.Id) == objName {
++								namespacedName, err := controller.ParseNamespacedName(record.Id)
++								if err != nil {
++									setupLog.Error(err, ""failed to parse record"", ""record"", record.Id)
++								}
++								if namespacedName == objName {
+ 									id := k8sTypes.NamespacedName{
+ 										Namespace: item.GetObjectMeta().Namespace,
+ 										Name:      item.GetObjectMeta().Name,",It should follow a `continue`.,nit: `failed to parse reco
+7119,"@@ -18,6 +18,7 @@ services:
+         gid: '{{ .GID }}'
+     image: ${DDEV_DBIMAGE}-${DDEV_SITENAME}-built
+     stop_grace_period: 60s
++    working_dir: ""{{ .WebWorkingDir }}""
+     volumes:
+       - type: ""volume""
+         source: mariadb-database",Should this be DBWorkingDir?,Should this be `{{ .WebWor
+7120,"@@ -542,7 +542,7 @@ public class AutoScalingHandler extends RequestHandlerBase implements Permission
+     String eventTypeStr = op.getStr(EVENT);
+ 
+     if (op.hasError()) return currentConfig;
+-    TriggerEventType eventType = TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
++    TriggerEventType.valueOf(eventTypeStr.trim().toUpperCase(Locale.ROOT));
+ 
+     String waitForStr = op.getStr(WAIT_FOR, null);
+ ",I think you can remove the whole line.,Why is this change needed?
+7121,"@@ -8,6 +8,7 @@ package consensus
+ 
+ import (
+ 	""context""
++	""github.com/iotexproject/iotex-core/db""
+ 	""math/big""
+ 
+ 	""github.com/facebookgo/clock""",File is not `goimports`-ed (from `goimports`),File is not `goimports`-ed
+7122,"@@ -40,12 +40,13 @@ public class ClientHarvestRun implements Serializable {
+         this.id = id;
+     }
+ 
+-    public enum RunResultType { SUCCESS, FAILURE, INPROGRESS };
++    public enum RunResultType { SUCCESS, RUN_FAILED, RUN_IN_PROGRESS, DELETE_FAILED };
+     
+     private static String RESULT_LABEL_SUCCESS = ""SUCCESS"";
+-    private static String RESULT_LABEL_FAILURE = ""FAILED"";
+-    private static String RESULT_LABEL_INPROGRESS = ""IN PROGRESS"";
+-    private static String RESULT_DELETE_IN_PROGRESS = ""DELETE IN PROGRESS"";
++    private static String RESULT_LABEL_RUN_FAILED = ""RUN FAILED"";
++    private static String RESULT_LABEL_RUN_IN_PROGRESS = ""RUN IN PROGRESS"";
++    private static String RESULT_LABEL_DELETE_IN_PROGRESS = ""DELETE IN PROGRESS"";
++    private static String RESULT_LABEL_DELETE_FAILED = ""DELETE FAILED"";
+     
+     @ManyToOne
+     @JoinColumn(nullable = false)","Not a big deal, but what is the value of adding this status condition for a failure to delete a client? It has some value for a dataverse admin, to know that the last attempt to harvest from a certain server resulted in a failure. Is it really useful to know that an attempt to delete a client failed? - should the startup check simply remove the ""delete in progress"" flag quietly instead? After all, seeing how the client is still there makes it somewhat clear that the attempt to get rid of it didn't work out, so they should try again? I may be missing some situation where it could actually be useful - so I'm open to hearing it.",I think it would be better
+7123,"@@ -85,7 +85,7 @@ public abstract class BaseWriterFactory<T> implements WriterFactory<T> {
+     OutputFile outputFile = file.encryptingOutputFile();
+     EncryptionKeyMetadata keyMetadata = file.keyMetadata();
+     Map<String, String> properties = table.properties();
+-    MetricsConfig metricsConfig = MetricsConfig.fromProperties(properties);
++    MetricsConfig metricsConfig = MetricsConfig.forTable(table);
+ 
+     try {
+       switch (dataFileFormat) {",Can we also update the equality delete branch below?,nit: `metricsConfig` -> `m
+7124,"@@ -457,6 +457,11 @@ class StepExecutionContext(PlanExecutionContext, IStepContext):
+             if step_output_handle == record.dagster_event.event_specific_data.step_output_handle:
+                 return True
+ 
++        # source is skipped so cannot load
++        for record in self.instance.all_logs(self.run_id, of_type=DagsterEventType.STEP_SKIPPED):
++            if step_output_handle.step_key == record.dagster_event.step_key:
++                return False
++
+         # can load from a previous run
+         if self._get_source_run_id_from_logs(step_output_handle):
+             return True","This doesn't solve the entire problem we talked abut yesterday, right? Because it's possible that the step itself didn't skip, but rather that it chose not to yield the output in question?",Shouldn't this be `if not self._get_source_run_id_from_logs(step_output_handle):`?
+7125,"@@ -5,6 +5,7 @@
+ # -------------------------------------------------------------------------
+ 
+ import base64
++from datetime import datetime
+ from hashlib import sha256
+ import json
+ import os",I also do not see any usages of this import. Is this a fix for a crash?,This should be `from datetime import datetime`
+7126,"@@ -794,6 +794,9 @@ func (engine *DockerTaskEngine) AddTask(task *apitask.Task) {
+ 		// This will update the container desired status
+ 		task.UpdateDesiredStatus()
+ 
++		// This will update any dependencies for awsvpc network mode before the task is started.
++		engine.updateTaskENIDependencies(task)
++
+ 		engine.state.AddTask(task)
+ 		if dependencygraph.ValidDependencies(task, engine.cfg) {
+ 			engine.startTask(task)",Feels like this needs to be invoked in `PostUnmarshalTask` since that's where most of the task setup happens.,Why do we need to do this?
+7127,"@@ -5390,7 +5390,8 @@ PrivStatus ObjectPrivsMDTable::updateWhere(const std::string & setClause,
+ //    <catalogName> ""<schema_name>"".""<object_name>"", 
+ //    object_type,
+ //    object_owner, -- granteeID
+-//    (select auth_db_name from AUTHS where auth_id = object_owner), --granteeName
++//    coalesce((select auth_db_name from AUTHS where auth_id = object_owner),
++//             'DB__ROOT') --granteeName
+ //    USER_GRANTEE_LIT, -- ""U""
+ //    SYSTEM_AUTH_ID,  -- system grantor ID (-2)
+ //    SYSTEM_AUTH_NAME, -- grantorName (_SYSTEM)",I wonder what would happen if the granteeName becomes DB__ROOT but the granteeID is not DB__ROOT ID (33333) but something else.,Why is this change needed?
+7128,"@@ -299,6 +299,10 @@ func (install *PleaseGoInstall) compilePackage(target string, pkg *build.Package
+ 			}
+ 		}
+ 
++		if f := os.Getenv(""CFLAGS""); f != """" {
++			cFlags = append(cFlags, f)
++		}
++
+ 		cFiles := pkg.CFiles
+ 
+ 		cgoGoFiles, cgoCFiles, err := install.tc.CGO(pkg.Dir, workDir, cFlags, pkg.CgoFiles)",Feel like this should probably come into this tool as a flag rather than it just grabbing an env var internally?,I think this should be `pkg.CgoFiles`.
+7129,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",I think this should be `nameOrHandle`
+7130,"@@ -7,7 +7,7 @@ module MentorHelper
+     mail_to(
+       mentor.email,
+       I18n.t(
+-        'dashboards.show.contact_your_mentor',
++        'shared.header.contact_your_mentor',
+         mentor_name: mentor.first_name
+       )
+     )",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [83/80]
+7131,"@@ -90,6 +90,18 @@ class ConfigValidatorUtilTest(ForsetiTestCase):
+         actual_path = cv_data_converter.generate_ancestry_path(full_name)
+         self.assertEqual(expected_path, actual_path)
+ 
++    def test_generate_ancestors_for_org(self):
++        full_name = 'organization/1234567890/project/test-project-123/firewall/1234567890123456789/'
++        expected_ancestors = ['organization/1234567890', 'project/test-project-123']
++        actual_ancestors = cv_data_converter.generate_ancestors(full_name)
++        self.assertListEqual(expected_ancestors, actual_ancestors)
++
++    def test_generate_ancestors_for_folder(self):
++        full_name = 'folder/folder-1/project/project-2/lien/p123/'
++        expected_ancestors = ['folder/folder-1', 'project/project-2']
++        actual_ancestors = cv_data_converter.generate_ancestors(full_name)
++        self.assertListEqual(expected_ancestors, actual_ancestors)
++
+     def test_cleanup_dict_does_not_replace_false(self):
+         firewall = mock_cai_resources.FIREWALL_DATA
+         cv_data_converter.cleanup_dict(firewall)","nit: folders are always a numeric ID, projects as given by CAI use project number for ancestry",Why do we need this test?
+7132,"@@ -35,7 +35,12 @@ import (
+ 	""github.com/multiformats/go-multistream""
+ )
+ 
+-var _ p2p.Service = (*Service)(nil)
++var (
++	_ p2p.Service = (*Service)(nil)
++
++	// ErrBadNetwork indicates that it is suspected that network is currently in bad condition
++	ErrBadNetwork = errors.New(""bad network"")
++)
+ 
+ type Service struct {
+ 	ctx              context.Context",is this used anywhere?,Why do we need this?
+7133,"@@ -28,7 +28,6 @@ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/versioned""
+ 	""github.com/openebs/maya/pkg/debug""
+-	merrors ""github.com/openebs/maya/pkg/errors/v1alpha1""
+ 	pkg_errors ""github.com/pkg/errors""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/errors""",change pkg_errors to errors. Keep it consistent across all the files.,Why was this removed
+7134,"@@ -657,7 +657,8 @@ class LocalRemote(unittest.TestCase):
+ 
+         resolved_results, _, returncode = get_diff_results(
+             [self._run_names[0]], [baseline_file_path], '--resolved', 'json',
+-            [""--url"", self._url])
++            [""--url"", self._url,
++             ""--review-status"", ""unreviewed"", ""confirmed"", ""false_positive""])
+         print(resolved_results)
+ 
+         self.assertTrue(resolved_results)",I don't see any test cases which would test that fix dates are set properly on review status changes / storage events. For this reason please create some more test cases and also check my scenarios above.,Why do we need this?
+7135,"@@ -109,6 +109,10 @@ namespace Microsoft.Rest.Generator
+             foreach (var method in client.Methods)
+             {
+                 NormalizeMethod(method);
++                if (method.DefaultResponse != null && method.DefaultResponse is CompositeType)
++                {
++                    client.Exceptions.Add((CompositeType)method.DefaultResponse);
++                }
+             }
+         }
+ ",This belongs to SwaggerModeler.cs `public override ServiceClient Build()`,Why do we need this?
+7136,"@@ -286,9 +286,11 @@ export default () => {
+      * Defines column widths in pixels. Accepts number, string (that will be converted to a number), array of numbers
+      * (if you want to define column width separately for each column) or a function (if you want to set column width
+      * dynamically on each render).
++     * 
++     * Note that this option will disable {@link AutoColumnSize} plugin.
+      *
+      * @memberof Options#
+-     * @type {number|number[]|string|string[]|Function}
++     * @type {number|(number|undefined)[]|string|(string|undefined)[]|Function}
+      * @default undefined
+      *
+      * @example",We could go further and directly give the tips of the `columns` property for someone (like me) who would like to specify some column width and let the others be autosized.,`(number|undefined)[]|string|(string|undefined)[]|Function` -> `(number|(number|undefined)[]|string|Function)`
+7137,"@@ -1058,8 +1058,17 @@ void VkRenderFramework::InitRenderTarget(uint32_t targets, VkImageView *dsBindin
+                                     VK_ACCESS_DEPTH_STENCIL_ATTACHMENT_WRITE_BIT;
+         // Must include dep_by_region bit when src & dst both include framebuffer-space stages
+         subpass_dep.dependencyFlags = VK_DEPENDENCY_BY_REGION_BIT;
+-        rp_info.dependencyCount = 1;
+-        rp_info.pDependencies = &subpass_dep;
++    }
++
++    if (m_additionalSubpassDependencies.size()) {
++        m_renderPass_dependencies.reserve(m_additionalSubpassDependencies.size() + m_renderPass_dependencies.size());
++        m_renderPass_dependencies.insert(m_renderPass_dependencies.end(), m_additionalSubpassDependencies.begin(),
++                                         m_additionalSubpassDependencies.end());
++    }
++
++    if (m_renderPass_dependencies.size()) {
++        rp_info.dependencyCount = static_cast<uint32_t>(m_renderPass_dependencies.size());
++        rp_info.pDependencies = m_renderPass_dependencies.data();
+     } else {
+         rp_info.dependencyCount = 0;
+         rp_info.pDependencies = nullptr;",I think a `std::copy` with `std::back_inserter` will get this done in one call.,Shouldn't this be `static_cast<uint32_t>`?
+7138,"@@ -47,6 +47,11 @@ type cryptoSetupServer struct {
+ 
+ var _ CryptoSetup = &cryptoSetupServer{}
+ 
++// ErrHOLExperiment is returned when the client sends the FHL2 tag in the CHLO
++// this is an expiremnt implemented by Chrome in QUIC 36, which we don't support
++// TODO: remove this when dropping support for QUIC 36
++var ErrHOLExperiment = qerr.Error(qerr.InvalidCryptoMessageParameter, ""HOL experiment. Unsupported"")
++
+ // NewCryptoSetup creates a new CryptoSetup instance for a server
+ func NewCryptoSetup(
+ 	connID protocol.ConnectionID,",In the future: s/QUIC 36/Version36/ to make grepping easier,nit: `HOL experiment. Unsupported`
+7139,"@@ -29,11 +29,13 @@ class FileCard extends Component {
+     }
+   }
+ 
+-  tempStoreMeta = (ev, name) => {
++  tempStoreMeta = (ev, name, type) => {
++    var value = ev.target.value
++    if (type === 'checkbox') value = ev.target.checked ? 'on' : 'off'
+     this.setState({
+       formState: {
+         ...this.state.formState,
+-        [name]: ev.target.value
++        [name]: value
+       }
+     })
+   }",This is an example of why I prefer a flexible custom `render()` solution   'on'/'off' may not be the right value for every application. You have to make a lot of decisions even for very simple form fields :(,Why do we need this?
+7140,"@@ -568,7 +568,6 @@ func (data *TestData) deployAntreaIPSec() error {
+ func (data *TestData) deployAntreaFlowExporter(ipfixCollector string) error {
+ 	// Enable flow exporter feature and add related config params to antrea agent configmap.
+ 	ac := []configChange{
+-		{""FlowExporter"", ""true"", true},
+ 		{""flowPollInterval"", ""\""1s\"""", false},
+ 		{""activeFlowExportTimeout"", fmt.Sprintf(""\""%v\"""", exporterActiveFlowExportTimeout), false},
+ 		{""idleFlowExportTimeout"", fmt.Sprintf(""\""%v\"""", exporterIdleFlowExportTimeout), false},",we should also skip the e2e flow aggregator tests if the Flow Exporter feature is disabled.,Why was this removed?
+7141,"@@ -225,6 +225,7 @@ class ConsoleMaster(flow.FlowMaster):
+                 if err:
+                     print >> sys.stderr, ""Script load error:"", err
+                     sys.exit(1)
++                script.ObserveScripts(self, i)
+ 
+         if options.outfile:
+             err = self.start_stream_to_path(","We should initialize the observation in the constructor of the Script class - otherwise, we don't have this feature for mitmdump.",I think this should b
+7142,"@@ -172,9 +172,11 @@ class Index(IndexOpsMixin):
+             raise ValueError('Names must be a list-like')
+         internal = self._kdf._internal
+         if len(internal.index_map) != len(names):
++
+             raise ValueError('Length of new names must be {}, got {}'
+                              .format(len(internal.index_map), len(names)))
+-        names = [name if isinstance(name, tuple) else (name,) for name in names]
++
++        names = [name if isinstance(name, (tuple, type(None))) else (name,) for name in names]
+         self._kdf._internal = internal.copy(index_map=list(zip(internal.index_columns, names)))
+ 
+     @property",I would remove this line. Otherwise looks fine cc @ueshin,Why is this necessary
+7143,"@@ -50,7 +50,7 @@ TEST (ledger_walker, genesis_account_longer)
+ 
+ 	nano::ledger_walker ledger_walker{ node->ledger };
+ 	EXPECT_TRUE (ledger_walker.walked_blocks.empty ());
+-	EXPECT_EQ (1, ledger_walker.walked_blocks.bucket_count ());
++	EXPECT_LE (ledger_walker.walked_blocks.bucket_count (), 1);
+ 	EXPECT_TRUE (ledger_walker.blocks_to_walk.empty ());
+ 
+ 	const auto get_number_of_walked_blocks = [&ledger_walker] (const auto & start_block_hash) {",Would it be better to remove that line alltogether if it not directly relevant?,"`EXPECT_LE (1, ledger"
+7144,"@@ -693,6 +693,13 @@ signal_arch_init(void)
+          * compiler from optimizing it away.
+          * XXX i#641, i#639: this breaks transparency to some extent until the
+          * app uses fpu/xmm but we live with it.
++         * Given a security vulnerability and its mitigations, executing a fpu/xmm
++         * operation here might not be necessary anymore. The vulnerabilty, published on
++         * June 13, 2018, is CVE-2018-3665: ""Lazy FPU Restore"" schemes are vulnerable to
++         * the FPU state information leakage issue. The kernel-based mitigation was to
++         * automatically default to (safe) ""eager"" floating point register restore.  In
++         * this mode FPU state is saved and restored for every task/context switch
++         * regardless of whether the current process invokes FPU instructions or not.
+          */
+         __asm__ __volatile__(""movd %%xmm0, %0"" : ""=g""(rc));
+         memset(&act, 0, sizeof(act));","Does ""FPU"" here include XMM/YMM/ZMM SIMD and not just x87 FPU/MMX?",I don't think this is the right way to go about it. I think it would be better to use the `__asm__ __volatile__` instead.
+7145,"@@ -226,7 +226,7 @@ class TokValueFile(Token):
+         return generators.FileGenerator(s)
+ 
+     def spec(self):
+-        return ""<'%s'"" % strutils.bytes_to_escaped_str(self.path)
++        return ""<'%s'"" % self.path
+ 
+ 
+ TokValue = pp.MatchFirst(","I'm not sure if we need to store path as bytes, and then decode/escape it when printing or just store it as a unicode string (as done here.)",Why did you remove the `bytes_to_escaped_str` call?
+7146,"@@ -7,7 +7,7 @@ testinfra_hosts = testinfra.utils.ansible_runner.AnsibleRunner(
+ 
+ 
+ def test_hostname(host):
+-    assert 'instance' == host.check_output('hostname -s')
++    assert host.check_output('hostname -s') == 'instance'
+ 
+ 
+ def test_etc_molecule_directory(host):",Why is this flipped? Looks unrelated and our pattern is `expected == returned`.,Why this change?
+7147,"@@ -2,7 +2,11 @@
+   <%= link_to workshop do %>
+     <span class=""icon""></span>
+     <hgroup>
+-      <h5><%= t '.heading' %></h5>
++      <% if workshop.online? %>
++        <h5><%= t '.heading.online' %></h5>
++      <% else %>
++        <h5><%= t '.heading.in_person' %></h5>
++      <% end %>
+       <h4><%= workshop.name %></h4>
+     </hgroup>
+   <% end %>",Can the `h5` tags be pulled outside of the `if` block?,I think this should be `<%= t '.heading.online' %>`.
+7148,"@@ -2,6 +2,8 @@
+ 
+ namespace Shopsys\ShopBundle\Command;
+ 
++use Shopsys\ShopBundle\Component\Image\DirectoryStructureCreator as ImageDirectoryStructureCreator;
++use Shopsys\ShopBundle\Component\UploadedFile\DirectoryStructureCreator as UploadedFileDirectoryStructureCreator;
+ use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
+ use Symfony\Component\Console\Input\InputInterface;
+ use Symfony\Component\Console\Output\OutputInterface;",From @PetrHeinz review: this should be also aliased (`ImageDirectoryStructureCreator`),Why do we need this?
+7149,"@@ -170,7 +170,7 @@ func (s *ClusterScope) AdditionalTags() infrav1.Tags {
+ 		s.AWSCluster.Spec.AdditionalTags = infrav1.Tags{}
+ 	}
+ 
+-	return s.AWSCluster.Spec.AdditionalTags
++	return infrav1.Tags(s.AWSCluster.Spec.AdditionalTags).DeepCopy()
+ }
+ 
+ // APIServerPort returns the APIServerPort to use when creating the load balancer.","Isn't AdditionalTags already of `Tags` type? If not, we should make it so, if it's not a breaking change",Why do we need to co
+7150,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Client.Parallel
+ {
+     using System;",Add blank line below license header.,This file should not
+7151,"@@ -24,6 +24,7 @@ func init() {
+ 	initRTC()
+ 	initUARTClock()
+ 	initI2CClock()
++	initPWMClocks()
+ 
+ 	// connect to UART
+ 	machine.UART0.Configure(machine.UARTConfig{})",Perhaps this could be moved into `InitPWM`? I suspect not initializing the clocks will reduce power consumption.,initPWMClocks()
+7152,"@@ -0,0 +1,9 @@
++class Quiz < ActiveRecord::Base
++  validates :title, presence: true
++
++  has_many :questions, -> { order(position: :asc) }, dependent: :destroy
++
++  def first_question
++    questions.first
++  end
++end",I believe this `order` isn't tested.,Extra empty line detected at class body beginning.
+7153,"@@ -7,12 +7,13 @@
+ # include ""../../_Plugin_Helper.h""
+ # include ""../Helpers/ESPEasyStatistics.h""
+ # include ""../Static/WebStaticData.h""
+-HELPERS_ESPEASY_MATH_H
++//HELPERS_ESPEASY_MATH_H  //clumsy-stefan: what's this for?
++
++#ifdef WEBSERVER_METRICS
+ #ifdef ESP32
+ # include <esp_partition.h>
+ #endif // ifdef ESP32
+ 
+-
+ void handle_metrics() {
+     TXBuffer.startStream(F(""text/plain""), F(""*""));
+ ",No idea why it ended up in the code. You can remove the entire line.,Why is this needed?
+7154,"@@ -146,9 +146,10 @@ func (n *NetworkPolicyController) processClusterNetworkPolicy(cnp *secv1alpha1.C
+ 			appliedToGroupNamesForRule = append(appliedToGroupNamesForRule, atGroup)
+ 			appliedToGroupNamesSet.Insert(atGroup)
+ 		}
++		iFromPeers := n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists)
+ 		rules = append(rules, controlplane.NetworkPolicyRule{
+ 			Direction:       controlplane.DirectionIn,
+-			From:            *n.toAntreaPeerForCRD(ingressRule.From, cnp, controlplane.DirectionIn, namedPortExists),
++			From:            iFromPeers,
+ 			Services:        services,
+ 			Action:          ingressRule.Action,
+ 			Priority:        int32(idx),","""i"" and ""From"" is a bit duplicate, and should it be singular given the method name? I mean ""fromPeer"" or just ""from""?",nit: `iFromPeers` -> `fromPeers`
+7155,"@@ -32,6 +32,7 @@ public class TestOAuth2AuthorizationRequests {
+ 		return OAuth2AuthorizationRequest.authorizationCode()
+ 				.authorizationUri(""https://example.com/login/oauth/authorize"")
+ 				.clientId(clientId)
++				.scope(""openid"")
+ 				.redirectUri(""https://example.com/authorize/oauth2/code/registration-id"")
+ 				.state(""state"")
+ 				.additionalParameters(additionalParameters);",Did you verify this isn't going to break any existing test assumptions? We probably shouldn't modify this as we don't know what impact this is having on existing tests. It may invalidate a test that has different expectations of the scopes.,Why is this needed?
+7156,"@@ -43,12 +43,16 @@ func (a *defaultAuthorizer) Authorize(_ context.Context, claims *Claims, target
+ 	if target.Namespace == ""temporal-system"" || target.Namespace == """" {
+ 		return Result{Decision: DecisionAllow}, nil
+ 	}
+-
++	if claims == nil {
++		return Result{Decision: DecisionDeny}, nil
++	}
+ 	// Check system level permissions
+ 	if claims.System == RoleAdmin || claims.System == RoleWriter {
+ 		return Result{Decision: DecisionAllow}, nil
+ 	}
+-
++	if claims.Namespaces == nil {
++		return Result{Decision: DecisionDeny}, nil
++	}
+ 	roles, found := claims.Namespaces[target.Namespace]
+ 	if !found || roles == RoleUndefined {
+ 		return Result{Decision: DecisionDeny}, nil","technically not necessary since reading from a nil dictionary will always return found = false, so this should already be handled",Shouldn't this be an error?
+7157,"@@ -141,6 +141,9 @@ type StatsDriver interface {
+ 	// VolumeUsageByNode returns capacity usage of all volumes and snaps for a
+ 	// given node
+ 	VolumeUsageByNode(nodeID string) (*api.VolumeUsageByNode, error)
++	// RelaxedReclaimPurge triggers the purge of RelaxedReclaim queue for a
++	// given node
++	RelaxedReclaimPurge(nodeID string) (*api.RelaxedReclaimPurge, error)
+ }
+ 
+ type QuiesceDriver interface {","This can return bool. RelaxedReclaimPurge(nodeID string) (bool, error)",I don't think we need a new
+7158,"@@ -60,7 +60,7 @@ public class GeneralStateReferenceTestTools {
+     final String eips =
+         System.getProperty(
+             ""test.ethereum.state.eips"",
+-            ""Frontier,Homestead,EIP150,EIP158,Byzantium,Constantinople,ConstantinopleFix,Istanbul,Berlin"");
++            ""Frontier,Homestead,EIP150,EIP158,Byzantium,Constantinople,ConstantinopleFix,Istanbul,Berlin,London"");
+     EIPS_TO_RUN = Arrays.asList(eips.split("",""));
+   }
+ ","Is there something we can do to make this automatic? At the very least, can we add Shanghai, Cancun, etc. here now so that we don't forget them?",Why did you change this?
+7159,"@@ -129,7 +129,7 @@ def add_arguments_to_parser(parser):
+     parser.add_argument('--skip-db-cleanup',
+                         dest=""skip_db_cleanup"",
+                         action='store_true',
+-                        default=True,
++                        default=False,
+                         required=False,
+                         help=""Skip performing cleanup jobs on the database ""
+                              ""like removing unused files."")","For boolean values, I'd rather have `argparse.SUPPRESS` as default value. No need to have a `(default: False)` in the help if it's a toggle.",Why is this change needed?
+7160,"@@ -251,6 +251,7 @@ func initSyncTest(t *testing.T, con consensus.Protocol, genFunc func(cst *hamt.C
+ 	chainStore := chain.NewStore(chainDS, cst, &state.TreeStateLoader{}, calcGenBlk.Cid())
+ 
+ 	fetcher := th.NewTestFetcher()
++	fetcher.AddSourceBlocks(calcGenBlk)
+ 	syncer := chain.NewSyncer(con, chainStore, fetcher, syncMode) // note we use same cst for on and offline for tests
+ 
+ 	// Initialize stores to contain dstP.genesis block and state","The genesis block needs to exist in the store the fetcher pulls from, this is because the fetcher will stop fetching when it finds a block it has seen before and this can sometimes be the genesis block.",Why do we need this?
+7161,"@@ -1111,7 +1111,7 @@ func (c *linuxContainer) Checkpoint(criuOpts *CriuOpts) error {
+ 			return err
+ 		}
+ 
+-		err = ioutil.WriteFile(filepath.Join(criuOpts.ImagesDirectory, descriptorsFilename), fdsJSON, 0655)
++		err = ioutil.WriteFile(filepath.Join(criuOpts.ImagesDirectory, descriptorsFilename), fdsJSON, 0600)
+ 		if err != nil {
+ 			return err
+ 		}","should we do the same for os.Mkdir(criuOpts.WorkDirectory, 0755)?",Why did you change t
+7162,"@@ -87,7 +87,8 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
+         .replace('<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML""', '<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML"" flattenhtml=""true""')
+         .replace(pageVisibility, bravePageVisibility + pageVisibility)
+         .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
+-        .replace(/Automatically sends usage statistics and crash reports to Brave/g, 'Automatically sends crash reports to Brave')
++        .replace(/Automatically send usage statistics and crash reports to Google/g, 'Automatically send crash reports to Google')
++        .replace(/Automatically sends usage statistics and crash reports to Google/g, 'Automatically sends crash reports to Google')
+         .replace(/The Chromium Authors/g, 'Brave Software Inc')
+         .replace(/Google Chrome/g, 'Brave')
+         .replace(/Chromium/g, 'Brave')",@bbondy Two messages because the label and description differ very slightly in their wording...,Should this be `Auto
+7163,"@@ -134,7 +134,10 @@ unit_test_get_ymm_caller_saved()
+     register __m256 ymm15 asm(""ymm15"");
+ #        endif
+ 
+-    for (int regno = 0; regno < proc_num_simd_registers(); ++regno) {
++    /* The function get_ymm_caller_saved is intended to be used for AVX (no AVX-512). It
++     * currently doesn't cover extended AVX-512 registers.
++     */
++    for (int regno = 0; regno < proc_num_simd_sse_avx_registers(); ++regno) {
+         for (int dword = 0; dword < sizeof(dr_ymm_t) / sizeof(uint); ++dword) {
+             get_buffer[regno].u32[dword] = 0;
+             ref_buffer[regno].u32[dword] = base++;","""currently"" implies it should and will be changed: so TODO i#?",I don't think this i
+7164,"@@ -1,8 +1,14 @@
+ import { translationMacro as t } from 'ember-i18n';
+ import AbstractIndexRoute from 'hospitalrun/routes/abstract-index-route';
++import Ember from 'ember';
++
++const { computed } = Ember;
++
+ export default AbstractIndexRoute.extend({
+   modelName: 'imaging',
+-  pageTitle: t('imaging.pageTitle'),
++  pageTitle: computed('i18n', () => {
++    return t('imaging.pageTitle');
++  }),
+   searchStatus: 'Requested',
+ 
+   _getStartKeyFromItem(item) {",This should be `computed('i18n.locale'....`,Why is this needed?
+7165,"@@ -12,7 +12,6 @@ class CommitFlag::BackToLifeTest < ActiveSupport::TestCase
+     btl = CommitFlag::BackToLife.find(cf.id)
+     btl.time_elapsed = 123.0
+     btl.save!
+-    btl.reload
+     btl.time_elapsed.must_equal 123.0
+   end
+ end","Wait, does this not work if we do `btl.reload`? That seems odd that we have to have the object in the same state.",Why was this remove
+7166,"@@ -22,9 +22,7 @@ define(['playbackManager', 'focusManager', 'appRouter', 'dom'], function (playba
+ 
+     var eventListenerCount = 0;
+     function on(scope, fn) {
+-        if (eventListenerCount) {
+-            eventListenerCount++;
+-        }
++        eventListenerCount++;
+         dom.addEventListener(scope, 'command', fn, {});
+     }
+ ",I seem to recall this being the cause of a bug at some point.,Why is this removed
+7167,"@@ -1648,6 +1648,7 @@ public class LFMainActivity extends SharedMediaActivity {
+             menu.setGroupVisible(R.id.photos_option_men, false);
+             menu.findItem(R.id.all_photos).setVisible(!editMode && !hidden);
+             menu.findItem(R.id.search_action).setVisible(!editMode);
++            menu.findItem(R.id.settings).setVisible(false);
+ 
+             if (getAlbums().getSelectedCount() >= 1) {
+                 if (getAlbums().getSelectedCount() > 1) {",Can you remove it from the menu instead of setting it hidden? Or are there any other trouble?,Why is this needed?
+7168,"@@ -32,6 +32,7 @@ import (
+ 	reflect ""reflect""
+ 
+ 	gomock ""github.com/golang/mock/gomock""
++	execution ""github.com/temporalio/temporal/.gen/proto/execution""
+ 	persistence ""github.com/temporalio/temporal/common/persistence""
+ )
+ ","And for ""execution "".","""github.com/pkg/errors"""
+7169,"@@ -34,6 +34,8 @@ module Bolt
+           search_dirs << mod.plugins if mod.plugins?
+           search_dirs << mod.pluginfacts if mod.pluginfacts?
+           search_dirs << mod.files if mod.files?
++          type_files = ""#{mod.path}/types""
++          search_dirs << type_files if File.exist?(type_files)
+           search_dirs
+         end
+       end",Do agents usually download these from puppetserver when applying a catalog?,I think this should be 
+7170,"@@ -68,6 +68,14 @@ PONY_API int pony_asio_event_fd(asio_event_t* ev)
+   return ev->fd;
+ }
+ 
++PONY_API bool pony_asio_event_get_disposable(asio_event_t* ev)
++{
++  if(ev == NULL)
++    return false;
++
++  return (ev->flags & ASIO_DISPOSABLE) != 0;
++}
++
+ PONY_API bool pony_asio_event_get_writeable(asio_event_t* ev)
+ {
+   if(ev == NULL)",This should be `return (ev->flags == ASIO_DISPOSABLE);` because `ASIO_DISPOSABLE` has a value of `0` as defined in the enum in `asio.h` and because when `ev->flags` is assigned `ASIO_DISPOSABLE` it is assigned as `ev->flags = ASIO_DISPOSABLE` unsetting any other flags previously assigned.,Shouldn't this be `!= 0
+7171,"@@ -68,7 +68,8 @@ namespace Examples.Console
+                 providerBuilder
+                     .AddOtlpExporter(o =>
+                     {
+-                        o.MetricExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
++                        o.MetricReaderType = MetricReaderType.Periodic;
++                        o.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds = options.DefaultCollectionPeriodMilliseconds;
+                         o.AggregationTemporality = options.IsDelta ? AggregationTemporality.Delta : AggregationTemporality.Cumulative;
+                     });
+             }","this is not required, right? its the default already...",Why do we need this?
+7172,"@@ -49,6 +49,11 @@ const (
+ 	// to indicate that a reader has requested to read a TLF ID that
+ 	// has been finalized, which isn't allowed.
+ 	StatusCodeServerErrorCannotReadFinalizedTLF = 2812
++	// StatusCodeServerErrorRequiredLockIsNotHeld is the error code returned by
++	// a MD write operation to indicate that a lockID that client required the
++	// write to be contingent to is not held at the time server tries to commit
++	// the MD, and as a result the MD is not written.
++	StatusCodeServerErrorRequiredLockIsNotHeld = 2813
+ )
+ 
+ // ServerError is a generic server-side error.","""contingent to"" -> ""contingent on""","I think this should be 2814, right?"
+7173,"@@ -19,6 +19,14 @@ Exceptions/Errors used in Koalas.
+ """"""
+ 
+ 
++class GroupByError(Exception):
++    pass
++
++
++class DataError(GroupByError):
++    pass
++
++
+ class SparkPandasIndexingError(Exception):
+     pass
+ ",Does pandas throw an exception like this?,Why do we need this?
+7174,"@@ -538,14 +538,14 @@ cvdescriptorset::AllocateDescriptorSetsData::AllocateDescriptorSetsData(uint32_t
+ 
+ cvdescriptorset::DescriptorSet::DescriptorSet(const VkDescriptorSet set, const VkDescriptorPool pool,
+                                               const std::shared_ptr<DescriptorSetLayout const> &layout, uint32_t variable_count,
+-                                              CoreChecks *dev_data)
++                                              cvdescriptorset::DescriptorSet::StateTracker *state_data)
+     : some_update_(false),
+       set_(set),
+       pool_state_(nullptr),
+       p_layout_(layout),
+-      device_data_(dev_data),
++      state_data_(state_data),
+       variable_count_(variable_count) {
+-    pool_state_ = dev_data->GetDescriptorPoolState(pool);
++    pool_state_ = state_data->GetDescriptorPoolState(pool);
+     // Foreach binding, create default descriptors of given type
+     descriptors_.reserve(p_layout_->GetTotalDescriptorCount());
+     for (uint32_t i = 0; i < p_layout_->GetBindingCount(); ++i) {",The point of the exercise has been to eliminate CoreChecks as an object dependency for DescriptorSet et. al.,Why do we need this change?
+7175,"@@ -34,7 +34,7 @@ import static org.apache.iceberg.TableProperties.DEFAULT_NAME_MAPPING;
+ /**
+  * Context object with optional arguments for a Flink Scan.
+  */
+-class ScanContext implements Serializable {
++public class ScanContext implements Serializable {
+ 
+   private static final long serialVersionUID = 1L;
+ ",Why do we need to make so much more of this ScanContext public?,Why do we need to make this public?
+7176,"@@ -54,7 +54,6 @@ class ProductFilterFormType extends AbstractType
+                 'choices' => $config->getFlagChoices(),
+                 'choice_label' => 'name',
+                 'choice_value' => 'id',
+-                'choice_name' => 'id',
+                 'multiple' => true,
+                 'expanded' => true,
+             ])",is choice_name not needed anymore?,Why did you remove this?
+7177,"@@ -226,6 +226,9 @@ public class Parquet {
+       set(""parquet.avro.write-old-list-structure"", ""false"");
+       MessageType type = ParquetSchemaUtil.convert(schema, name);
+ 
++      // Check that our metrics make sense
++      metricsConfig.validateProperties(schema);
++
+       if (createWriterFunc != null) {
+         Preconditions.checkArgument(writeSupport == null,
+             ""Cannot write with both write support and Parquet value writer"");","Is this the right place to do the validation? If a user adds a bad property or performs some schema update that causes a validation error, that would break all writes to the table. To me, it doesn't seem like we are catching the problem early enough and possibly allowing a typo to break scheduled jobs. What do you think about adding this validation when altering the table? `UpdateProperties` could check whether any properties starting with `write.metadata.metrics` were modified and run this. Similarly, `UpdateSchema` could run this as well, although I think that we should probably modify `UpdateSchema` to simply update the properties for column renames (if that's easily done).",Why do we need this chec
+7178,"@@ -2467,11 +2467,17 @@ hipError_t hipHccGetAcceleratorView(hipStream_t stream, hc::accelerator_view** a
+ namespace hip_impl {
+     std::vector<hsa_agent_t> all_hsa_agents() {
+         std::vector<hsa_agent_t> r{};
+-        for (auto&& acc : hc::accelerator::get_all()) {
++        auto accelerators = hc::accelerator::get_all();
++        for (int i = 0; i < accelerators.size(); i++) {
++            auto&& acc = accelerators[i];
+             const auto agent = acc.get_hsa_agent();
+ 
+             if (!agent || !acc.is_hsa_accelerator()) continue;
+ 
++            // If device is not in visible devices list, ignore
++            if (std::find(g_hip_visible_devices.begin(), g_hip_visible_devices.end(), (i - 1)) ==
++                    g_hip_visible_devices.end()) continue;
++
+             r.emplace_back(*static_cast<hsa_agent_t*>(agent));
+         }
+ ",Why is this necessary? Just in order to get an indexed loop?,I don't think you need t
+7179,"@@ -68,6 +68,7 @@ type poolSyncMetrics struct {
+ 	zpoolLastSyncTime             *prometheus.GaugeVec
+ 	zpoolStateUnknown             *prometheus.GaugeVec
+ 	zpoolLastSyncTimeCommandError *prometheus.GaugeVec
++	zpoolListRequestRejectCounter prometheus.Gauge
+ }
+ 
+ // poolfields struct is for pool last sync time metric","instead of using `prometheus.Gauge`, using `promethus.Counter` will be better.",// zpoolListRequestRejec
+7180,"@@ -23,5 +23,9 @@ module Ncr
+     def whsc?
+       code == WHSC_CODE
+     end
++
++    def ba_6x_tier1_team?
++      code.match(/^P11[7J4T1ACZ]....$/)
++    end
+   end
+ end",maybe we should have a unit test for this and then just test one case in `spec/services/ncr/approval_manager_spec.rb` ?,I'm not sure if this is the best way to check if the code is a<msg>I'm not sure if this is the best way to do this.
+7181,"@@ -21,8 +21,9 @@ class CommunicartsController < ApplicationController
+   def approval_response
+     cart = Cart.find(params[:cart_id]).decorate
+     client_data = cart.proposal.client_data_legacy
+-    approval = cart.approvals.find_by(user_id: user_id) 
+-    
++    approval = cart.approvals.find_by(user_id: user_id)
++    @token ||= ApiToken.find_by(approval_id: approval.id)
++
+     if !approval.pending?
+       flash[:error] = ""You have already logged a response for Cart #{client_data.public_identifier}""
+     else",Why is this necessary?,I think this should be `@token ||= ApiToken.find(approval.id)`
+7182,"@@ -320,7 +320,7 @@ public class Spark3Util {
+     }
+   }
+ 
+-  private static DistributionMode getDistributionMode(org.apache.iceberg.Table table) {
++  public static DistributionMode getDistributionMode(org.apache.iceberg.Table table) {
+     boolean isSortedTable = !table.sortOrder().isUnsorted();
+     String defaultModeName = isSortedTable ? WRITE_DISTRIBUTION_MODE_RANGE : WRITE_DISTRIBUTION_MODE_DEFAULT;
+     String modeName = table.properties().getOrDefault(WRITE_DISTRIBUTION_MODE, defaultModeName);","Minor: If this is going to be public, we should fix the name. `get` doesn't add any value. How about `distributionModeFor` instead?",Why is this public?
+7183,"@@ -16,7 +16,10 @@ from mitmproxy.tools.console import eventlog
+ 
+ 
+ class StackWidget(urwid.Frame):
+-    def __init__(self, widget, title, focus):
++    def __init__(self, window, widget, title, focus):
++        self.f = focus
++        self.window = window
++
+         if title:
+             header = urwid.AttrWrap(
+                 urwid.Text(title),",This needs a more self-explaining name. Maybe `.is_focused`?,Why is this needed?
+7184,"@@ -174,11 +174,17 @@ var rubyAzureMappings = {
+   'parameter_grouping':['../../dev/TestServer/swagger/azure-parameter-grouping.json', 'ParameterGroupingModule']
+ };
+ 
++var goAzureMappings = {
++  'paging':['../../dev/TestServer/swagger/paging.json','paginggroup'],
++  'azurereport':['../../dev/TestServer/swagger/azure-report.json', 'azurereport']
++};
++
+ gulp.task('regenerate:expected', function(cb){
+   runSequence('regenerate:delete',
+     [
+-      'regenerate:expected:csazure',
+       'regenerate:expected:cs',
++      'regenerate:expected:csazure',
++      'regenerate:expected:csazurefluent',
+       'regenerate:expected:node',
+       'regenerate:expected:nodeazure',
+       'regenerate:expected:ruby',","minor: I'd add a space between `,` & `'paginggroup'`.","nit: space after `,`"
+7185,"@@ -42,10 +42,8 @@ def main():
+ 
+     push_p = subparsers.add_parser(""push"")
+     push_p.add_argument(""package"", type=str, help=""Owner/Package Name"")
+-    push_p.set_defaults(func=command.push)
+-
+-    push_p = subparsers.add_parser(""push"")
+-    push_p.add_argument(""package"", type=str, help=""Owner/Package Name"")
++    push_p.add_argument(""--reupload"", action=""store_true"",
++                        help=""Re-upload all fragments, even the ones the server already has"")
+     push_p.set_defaults(func=command.push)
+ 
+     version_p = subparsers.add_parser(""version"")","""Re-upload all fragments (even if fragment is already in registry)""",I think this should 
+7186,"@@ -813,11 +813,15 @@ type PrometheusRuleSpec struct {
+ // upstream Prometheus struct definitions don't have json struct tags.
+ 
+ // RuleGroup is a list of sequentially evaluated recording and alerting rules.
++// Note: PartialResponseStrategy is only used by ThanosRuler and will
++// be ignored by Prometheus instances.  Valid values for this field are 'warn'
++// or 'abort'.  More info: https://github.com/thanos-io/thanos/blob/master/docs/components/rule.md#partial-response
+ // +k8s:openapi-gen=true
+ type RuleGroup struct {
+-	Name     string `json:""name""`
+-	Interval string `json:""interval,omitempty""`
+-	Rules    []Rule `json:""rules""`
++	Name                    string `json:""name""`
++	Interval                string `json:""interval,omitempty""`
++	Rules                   []Rule `json:""rules""`
++	PartialResponseStrategy string `json:""partial_response_strategy,omitempty""`
+ }
+ 
+ // Rule describes an alerting or recording rule.",I don't see us ignoring the field. Are we sure Prometheus wouldn't refuse to load the rules?,Why do we need this?
+7187,"@@ -314,7 +314,7 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
+         super.onResume();
+         if (isVisible() || mIsInVRVideoMode) {
+             mSession.setActive(true);
+-            if (!SettingsStore.getInstance(getContext()).getLayersEnabled()) {
++            if (!SettingsStore.getInstance(getContext()).getLayersEnabled() && !mSession.hasDisplay()) {
+                 // Ensure the Gecko Display is correctly recreated.
+                 // See: https://github.com/MozillaReality/FirefoxReality/issues/2880
+                 callSurfaceChanged();",I wonder if we can just check if the mSession is active and then only call `setActive(true)` and `callSurfaceChanged()` if it isn't?,Why is this needed?
+7188,"@@ -1336,6 +1336,8 @@ SDDkwd__(EXE_DIAGNOSTIC_EVENTS,		""OFF""),
+ 
+  SDDui___(EXE_MEMORY_FOR_PROBE_CACHE_IN_MB,	""100""),
+ 
++ SDDui___(EXE_MEMORY_FOR_UNPACK_ROWS_IN_MB,	""100""),
++
+   // lower-bound memory limit for BMOs/nbmos (in MB)
+   DDui___(EXE_MEMORY_LIMIT_LOWER_BOUND_EXCHANGE, ""10""),
+   DDui___(EXE_MEMORY_LIMIT_LOWER_BOUND_MERGEJOIN, ""10""),","A default value of 100 MB maybe too small. I understand that this is good for mixed workloads, but do consider than plans with Unpack, especially when used for insert/upsert are simple. Unpack is always serial and part of master exe. Often there is only one in a query. The cost of having a low value here seems to be that queue length from unpack could be limited by this when we are loading a table with wide rows (even if actual data in row is not wide). We know from performance runs that queue length is critical to upsert load performance. This is a hunch on my part and could be misguided. It will be good to performance test for upsert of table with wide rows, if you think that is worthwhile.","SDDui___(EXE_MEMORY_LIMIT_PROBE_CACHE_IN_MB, ""100""),"
+7189,"@@ -32,8 +32,8 @@ type (
+ 		GetByOwner(address.Address) *Candidate
+ 		GetBySelfStakingIndex(uint64) *Candidate
+ 		Upsert(*Candidate) error
+-		CreditBucketPool(*big.Int, bool) error
+-		DebitBucketPool(*big.Int, bool, bool) error
++		CreditBucketPool(*big.Int) error
++		DebitBucketPool(*big.Int, bool) error
+ 		Commit() error
+ 	}
+ ","think we should pass in ctx, and use ctx.GreenlandHeight inside bucketPool to determine if create or not",Why did you remove the `bool` here?
+7190,"@@ -153,7 +153,7 @@ public class I18nTest extends JUnit4TestBase {
+     assertThat(ime.isActivated()).isTrue();
+     assertThat(ime.getActiveEngine()).isEqualTo(desiredEngine);
+ 
+-    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to convert the word.
++    // Send the Romaji for ""Tokyo"". The space at the end instructs the IME to transform the word.
+     input.sendKeys(""toukyou "");
+     input.sendKeys(Keys.ENTER);
+ ",A correct by unrelated change. We'll slide this one in without another word ;),"I think this should be ""toukyou"", not ""transform""."
+7191,"@@ -1,5 +1,4 @@
+ <%= semantic_form_for checkout, url: checkouts_path(checkout.plan), html: { method: 'post' } do |form| %>
+-  <%= form.semantic_errors %>
+ 
+   <%= form.inputs do %>
+     <% if signed_out? %>",Why remove this?,Why did you remove this?
+7192,"@@ -11,7 +11,7 @@ use Shopsys\FrameworkBundle\Component\Router\Security\RouteCsrfProtector;
+ use Symfony\Component\HttpFoundation\Request;
+ use Symfony\Component\HttpFoundation\RequestStack;
+ use Symfony\Component\Routing\Router;
+-use Twig_Environment;
++use Twig\Environment;
+ 
+ class GridTest extends TestCase
+ {","I still see some usages of not namespaced variants (look for Twig_ in project, about 42 matches). Is it intentional?",Why did you change this?
+7193,"@@ -22,11 +22,11 @@ import (
+ 	""sync""
+ 	""time""
+ 
+-	""github.com/aws/amazon-ecs-agent/agent/api""
+ 	""github.com/aws/amazon-ecs-agent/agent/resources/cgroup""
+ 	""github.com/aws/amazon-ecs-agent/agent/utils/ioutilwrapper""
+ 	""github.com/cihub/seelog""
+ 	""github.com/containerd/cgroups""
++	specs ""github.com/opencontainers/runtime-spec/specs-go""
+ 	""github.com/pkg/errors""
+ )
+ ",Is this a new dependency? Does this require a dep update?,This should be `specs-go
+7194,"@@ -62,6 +62,8 @@ bool Print(T val, Type type, int /*indent*/, Type * /*union_type*/,
+ 
+   if (type.base_type == BASE_TYPE_BOOL) {
+     text += val != 0 ? ""true"" : ""false"";
++  } else if (opts.generate_hexfloat_in_json && (type.base_type == BASE_TYPE_FLOAT || type.base_type == BASE_TYPE_DOUBLE)) {
++    text += FloatToStringtStringHex(val);
+   } else {
+     text += NumToString(val);
+   }",> opts.generate_hexfloat_in_json && **IsFloat**(type.base_type),`FloatToStringtStringHex
+7195,"@@ -7,4 +7,5 @@ package archer
+ type Manifest interface {
+ 	Marshal() ([]byte, error)
+ 	DockerfilePath() string
++	AppName() string
+ }","As an alternative to this, we could also create a new method, like `Common() *AppManifest` This way we don't have to add a new method to the interface everytime we add a new field to the `AppManifest`. This is a nit though so it's up to you.",// AppName returns the n
+7196,"@@ -28,6 +28,7 @@ script_deps = {
+         ""urwid>=1.1"",
+         ""lxml>=3.3.6"",
+         ""Pillow>=2.3.0"",
++        ""harparser"",
+     },
+     ""mitmdump"": set()
+ }","As long as we have this feature as an inline script, I'm inclined to remove the dependency here. I'd suggest that we just try to import harparser and pytz and throw an error instructing the user to install the dependencies (catch for `ImportError`). In the long term, we probably want to include that in the mitmproxy core, but we first want to introduce a clean extension interface before that's going to happen. As soon as said interface is there, porting the inline script and adding the dependency again should be a breeze.","""harparser"": {"
+7197,"@@ -0,0 +1,4 @@
++// set the base folder of this project
++global.basefolder = `${__dirname}`
++require (""rechoir"").prepare(require('interpret').extensions, './.gulp/gulpfile.iced');
++require ('./.gulp/gulpfile.iced')",makes it work nice with vscode. all logic is now in `.gulp/*.iced` files,Why is this ne
+7198,"@@ -27,7 +27,7 @@ public interface SearchContext {
+    * @return A list of all {@link WebElement}s, or an empty list if nothing matches
+    * @see org.openqa.selenium.By
+    */
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+ 
+ 
+   /**",should a similar change be done for findElement?,Why do we need
+7199,"@@ -2745,7 +2745,7 @@ TEST (node, local_votes_cache)
+ 	{
+ 		ASSERT_NO_ERROR (system.poll (node.aggregator.max_delay));
+ 	}
+-	ASSERT_TIMELY (3s, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes) == 3);
++	ASSERT_TIMELY (3s, node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_generated_votes)+node.stats.count (nano::stat::type::requests, nano::stat::detail::requests_cached_late_votes) == 3);
+ 	ASSERT_FALSE (node.history.votes (send1->root (), send1->hash ()).empty ());
+ 	ASSERT_FALSE (node.history.votes (send2->root (), send2->hash ()).empty ());
+ 	ASSERT_FALSE (node.history.votes (send3->root (), send3->hash ()).empty ());",`+` -> ` + ` I guess. Same below,I think this s
+7200,"@@ -109,9 +109,8 @@ function TransactionBuilder(opts) {
+   this.lockTime = opts.lockTime || 0;
+   this.spendUnconfirmed = opts.spendUnconfirmed || false;
+ 
+-  if (opts.fee || opts.feeSat) {
+-    this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
+-  }
++  this.givenFeeSat = typeof(opts.fee) !== 'undefined' ? opts.fee * util.COIN : opts.feeSat;
++  
+   this.remainderOut = opts.remainderOut;
+   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
+ ","`typeof` is not a function - its an operator, and the standard way to use it is as `typeof foo !== ...` (i.e. no parenthesis). Also, I would personally use `opts.fee != null` instead (with a non-strict comparison, which also identifies `undefined` values because `null == undefined`).",`typeof(opts.fee) !== 'undefined' ? opts.fee : opts.feeSat`
+7201,"@@ -855,6 +855,7 @@ class ReaderTest < Minitest::Test
+       end
+ 
+       test 'unreadable file referenced by include directive is replaced by warning' do
++        next if windows? # JRuby on Windows runs this even with the conditional on the block
+         include_file = File.join DIRNAME, 'fixtures', 'chapter-a.adoc'
+         FileUtils.chmod 0000, include_file
+         input = <<~'EOS'",Is there a reason why you're not using Rspec `skip`? It allows to specify message and makes it clearly visible in test results which tests were skipped.,I think this should be `unless OS.mac?`
+7202,"@@ -36,6 +36,10 @@ type ClusterSyncStatus struct {
+ 	// Conditions is a list of conditions associated with syncing to the cluster.
+ 	// +optional
+ 	Conditions []ClusterSyncCondition `json:""conditions,omitempty""`
++
++	// FirstSyncSetsSuccessTime is the time we first successfully applied all (selector)syncsets to a cluster.
++	// +optional
++	FirstSyncSetsSuccessTime *metav1.Time `json:""firstSyncSetsSuccessTime,omitempty""`
+ }
+ 
+ // SyncStatus is the status of applying a specific SyncSet or SelectorSyncSet to the cluster.","how about ""all matching SyncSets and SelectorSyncSets""",Why is this a pointer?
+7203,"@@ -331,7 +331,7 @@ void Storage::PopulateLayout(DataLayout &layout)
+ 
+     // load geometries sizes
+     {
+-        io::FileReader reader(config.geometries_path, io::FileReader::HasNoFingerprint);
++        io::FileReader reader(config.geometries_path, io::FileReader::VerifyFingerprint);
+ 
+         const auto number_of_geometries_indices = reader.ReadVectorSize<unsigned>();
+         layout.SetBlockSize<unsigned>(DataLayout::GEOMETRIES_INDEX, number_of_geometries_indices);","What is the logic behind `ReadVectorSize` reading `CountElement64`, then skipping `T` (in this case `unsigned`)? Naming doesn't cover what's actually happening here. Ideally I'd also take this through a `files` layer, any input as to how?",Why did you remove HasNoFingerprint?
+7204,"@@ -24,6 +24,7 @@ import org.apache.solr.common.params.CommonParams;
+ import org.apache.solr.core.CoreContainer;
+ import org.apache.solr.core.SolrCore;
+ 
++import javax.servlet.ServletException;
+ import javax.servlet.http.HttpServletRequest;
+ import javax.servlet.http.HttpServletResponse;
+ ",This looks like an unused import to me?,package org.springframework.boot.autoconfigure.solr;
+7205,"@@ -231,13 +231,13 @@ func taskListInfoFromBlob(b []byte, proto string) (*sqlblobs.TaskListInfo, error
+ 	return result, thriftRWDecode(b, proto, result)
+ }
+ 
+-func transferTaskInfoToBlob(info *sqlblobs.TransferTaskInfo) (p.DataBlob, error) {
+-	return thriftRWEncode(info)
++func TransferTaskInfoToBlob(info *persistenceblobs.TransferTaskInfo) (p.DataBlob, error) {
++	return protoRWEncode(info)
+ }
+ 
+-func transferTaskInfoFromBlob(b []byte, proto string) (*sqlblobs.TransferTaskInfo, error) {
+-	result := &sqlblobs.TransferTaskInfo{}
+-	return result, thriftRWDecode(b, proto, result)
++func TransferTaskInfoFromBlob(b []byte, proto string) (*persistenceblobs.TransferTaskInfo, error) {
++	result := &persistenceblobs.TransferTaskInfo{}
++	return result, protoRWDecode(b, proto, result)
+ }
+ 
+ func TimerTaskInfoToBlob(info *persistenceblobs.TimerTaskInfo) (p.DataBlob, error) {","`RW` means read/write. Why do we have it here, as part of a func name?",nit: can we rename this to `TransferTaskInfoProto`?
+7206,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+ 
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+ 
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...,Why is this change needed?
+7207,"@@ -1051,7 +1051,11 @@ static ssize_t expect_preface(h2o_http2_conn_t *conn, const uint8_t *src, size_t
+     }
+ 
+     { /* send SETTINGS and connection-level WINDOW_UPDATE */
+-        h2o_iovec_t vec = h2o_buffer_reserve(&conn->_write.buf, SERVER_PREFACE.len);
++        h2o_iovec_t vec = h2o_buffer_try_reserve(&conn->_write.buf, SERVER_PREFACE.len);
++        if (vec.base == NULL) {
++            *err_desc = ""failed to allocate memory"";
++            return H2O_HTTP2_ERROR_PROTOCOL_CLOSE_IMMEDIATELY;
++        }
+         memcpy(vec.base, SERVER_PREFACE.base, SERVER_PREFACE.len);
+         conn->_write.buf->size += SERVER_PREFACE.len;
+         if (conn->http2_origin_frame) {",I think you missed this.,Shouldn't this be `conn->_write.buf->size`?
+7208,"@@ -145,6 +145,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             return _requestStream.ReadAsync(buffer, offset, count, cancellationToken);
+         }
+ 
++#if NETCOREAPP2_1
++        public override ValueTask<int> ReadAsync(Memory<byte> destination, CancellationToken cancellationToken = default)
++        {
++            return _requestStream.ReadAsync(destination, cancellationToken);
++        }
++#endif
++
+         public override Task CopyToAsync(Stream destination, int bufferSize, CancellationToken cancellationToken)
+         {
+             return _requestStream.CopyToAsync(destination, bufferSize, cancellationToken);",List all of the current TFMs so we know if this gets outdated. E.g. this breaks if we add 2.2.,This should be `NETCOREAPP2_0`
+7209,"@@ -811,6 +811,12 @@ func (s *VolumeServer) mergeVolumeSpecs(vol *api.VolumeSpec, req *api.VolumeSpec
+ 		spec.ExportSpec = vol.GetExportSpec()
+ 	}
+ 
++	// Xattr
++	if req.GetXattr() >= 0 {
++		spec.Xattr = req.GetXattr()
++	} else {
++		spec.Xattr = vol.GetXattr()
++	}
+ 	return spec
+ }
+ ","here, you want to use req.GetXattrOpt() referring to the in line 514 of api.proto. This will be nil if not provided. See the example above on line 801 on this file",I think this should be `if req
+7210,"@@ -952,7 +952,14 @@ public class LocalPSMP extends PlaybackServiceMediaPlayer {
+                 // Load next episode if previous episode was in the queue and if there
+                 // is an episode in the queue left.
+                 // Start playback immediately if continuous playback is enabled
+-                nextMedia = callback.getNextInQueue(currentMedia);
++
++                // Repeat episode implementation
++                if (UserPreferences.repeatEpisode() && !wasSkipped) {
++                    nextMedia = currentMedia;
++                    nextMedia.setPosition(0);
++                } else {
++                    nextMedia = callback.getNextInQueue(currentMedia);
++                }
+ 
+                 boolean playNextEpisode = isPlaying &&
+                         nextMedia != null &&","I think this should be done outside LocalPSMP, but in `getNextInQueue`. The reason is that I want to reduce the dependence of the media players on the preferences and database. Also, it will then probably work on Chromecast.",Why do we need to set the posi
+7211,"@@ -143,7 +143,9 @@ struct _hiprtcProgram {
+     {
+         using namespace std;
+ 
+-        name = hip_impl::demangle(name.c_str());
++        char* demangled = hip_impl::demangle(name.c_str());
++        name.assign(demangled == nullptr ? """" : demangled);
++        free(demangled);
+ 
+         if (name.empty()) return name;
+ ",Please remove it or remove all `std::` namespace prefixes.,Why not just `name = demangled
+7212,"@@ -0,0 +1,17 @@
++// Copyright (C) 2019-2020 Algorand, Inc.
++// This file is part of go-algorand
++//
++// go-algorand is free software: you can redistribute it and/or modify
++// it under the terms of the GNU Affero General Public License as
++// published by the Free Software Foundation, either version 3 of the
++// License, or (at your option) any later version.
++//
++// go-algorand is distributed in the hope that it will be useful,
++// but WITHOUT ANY WARRANTY; without even the implied warranty of
++// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
++// GNU Affero General Public License for more details.
++//
++// You should have received a copy of the GNU Affero General Public License
++// along with go-algorand.  If not, see <https://www.gnu.org/licenses/>.
++
++package nodecontrol",wait! I'm confused - is that an empty file ?!,Why is this file needed?
+7213,"@@ -19,14 +19,14 @@ var phrasingElements = ['A', 'EM', 'STRONG', 'SMALL', 'MARK', 'ABBR', 'DFN', 'I'
+  * @param {HTMLElement} element The HTMLElement
+  * @return {HTMLElement} The label element, or null if none is found
+  */
+-function findLabel({ actualNode }) {
++function findLabel(virtualNode) {
+ 	let label;
+-	if (actualNode.id) {
++	if (virtualNode.actualNode.id) {
+ 		label = dom.findElmsInContext({
+-			elm: 'label', attr: 'for', value: actualNode.id, context: actualNode
++			elm: 'label', attr: 'for', value: virtualNode.actualNode.id, context: virtualNode.actualNode
+ 		})[0];
+ 	} else {
+-		label = dom.findUp(actualNode, 'label');
++		label = dom.findUpVirtual(virtualNode, 'label');
+ 	}
+ 	return axe.utils.getNodeFromTree(axe._tree[0], label);
+ }",These should all call `findUpVirtual`.,`actualNode` -> `virtual
+7214,"@@ -105,7 +105,7 @@ class HierarchicHTTPRequest(HTTPRequest):
+             file_dict[""path""] = path
+ 
+             mime = mimetypes.guess_type(file_dict[""path""])[0] or ""application/octet-stream""
+-            file_dict.get('mime-type', mime)
++            file_dict[""mime-type""] = mime
+         self.content_encoding = self.config.get('content-encoding', None)
+ 
+ ","This changes the behavior. Original behavior was ""set if not set"", while new is ""just set"".",Why did you change this?
+7215,"@@ -110,7 +110,7 @@ public final class DefaultBearerTokenResolver implements BearerTokenResolver {
+ 				throw new OAuth2AuthenticationException(error);
+ 			}
+ 
+-			return matcher.group(""token"");
++			return authorization.substring(7);
+ 		}
+ 		return null;
+ 	}",Let's keep using the regular expression to make sure that the token is well-formed. I think the regular expression should be altered instead of doing a substring.,Shouldn't this be `subst
+7216,"@@ -26,10 +26,10 @@ public final class Array<T> implements Kind1<Array<?>, T>, IndexedSeq<T>, Serial
+ 
+     private static final Array<?> EMPTY = new Array<>(new Object[0]);
+ 
+-    private final Object[] back;
++    private final Object[] delegate;
+ 
+-    private Array(Object[] back) {
+-        this.back = back;
++    private Array(Object[] delegate) {
++        this.delegate = delegate;
+     }
+ 
+     static <T> Array<T> wrap(Object[] array) {","All the operations are delegated to this entity, hence the rename. `back` can have too many meanings.",I don't think we need this change.
+7217,"@@ -561,16 +561,9 @@ module Beaker
+ 
+       block_on host do |host|
+         skip_msg = host.skip_set_env?
+-        if skip_msg.nil?
+-          env = construct_env(host, opts)
+-          logger.debug(""setting local environment on #{host.name}"")
+-          if host['platform'] =~ /windows/ and host.is_cygwin?
+-            env['CYGWIN'] = 'nodosfilewarning'
+-          end
+-          host.ssh_permit_user_environment
+-          host.ssh_set_user_environment(env)
+-        else
+-          logger.debug(skip_msg)
++        unless skip_msg.nil?
++            logger.debug( skip_msg )
++            next
+         end
+ 
+         if skip_msg.nil?","@trevor-vaughan it looks like the spec failures are caused by the fact that although it was a great idea to put the guard clause here first & get the error case out of the way, the main code path has been erased when I assume it should be just below the guard clause.",Why is this being removed?
+7218,"@@ -22,6 +22,7 @@ import (
+ 	""github.com/algorand/go-algorand/config""
+ 	""github.com/algorand/go-algorand/data/basics""
+ 	""github.com/algorand/go-algorand/logging""
++	""github.com/algorand/go-algorand/protocol""
+ )
+ 
+ var filterTimeout = 2 * config.Protocol.SmallLambda",Could you delete this constant?,nit: remove empty line
+7219,"@@ -2,6 +2,7 @@
+ // The .NET Foundation licenses this file to you under the MIT license.
+ // See the LICENSE file in the project root for more information.
+ 
++using BenchmarkDotNet.Disassemblers;
+ using BenchmarkDotNet.Exporters;
+ using BenchmarkDotNet.Loggers;
+ using BenchmarkDotNet.Parameters;",looks like this snuck in from your other change?,Why is this needed?
+7220,"@@ -10,11 +10,6 @@ module Ncr
+   BUILDING_NUMBERS = YAML.load_file(""#{Rails.root}/config/data/ncr/building_numbers.yml"")
+ 
+   class WorkOrder < ActiveRecord::Base
+-      NCR_BA61_TIER1_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA61_TIER1_BUDGET_MAILBOX'] || 'communicart.budget.approver+ba61@gmail.com'
+-      NCR_BA61_TIER2_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA61_TIER2_BUDGET_MAILBOX'] || 'communicart.ofm.approver@gmail.com'
+-      NCR_BA80_BUDGET_APPROVER_MAILBOX = ENV['NCR_BA80_BUDGET_MAILBOX'] || 'communicart.budget.approver+ba80@gmail.com'
+-      OOL_BA80_BUDGET_APPROVER_MAILBOX = ENV['NCR_OOL_BA80_BUDGET_MAILBOX'] || 'communicart.budget.approver+ool_ba80@gmail.com'
+-
+     # must define before include PurchaseCardMixin
+     def self.purchase_amount_column_name
+       :amount","These env vars are not set in any CF environment, on purpose, because we are moving away from using env vars to store role-based information and instead using the database. So in a CF environment, the wrong emails get used (the defaults, rather than what is in the db).",I don't think we need this anymore.
+7221,"@@ -1,4 +1,4 @@
+-<%# locals: { question, answer, readonly, locking } %>
++<%# locals: { template, question, answer, readonly, locking } %>
+ <!--
+   This partial creates a form for each type of question. The local variables are: plan, answer, question, readonly
+ -->","this partial is used also for previewing a template, did you test if still works?",I'm not sure if this is the right w
+7222,"@@ -22,6 +22,19 @@ import (
+ 	""github.com/spf13/cobra""
+ )
+ 
++var (
++	appInitAppTypePrompt     = ""Which type of "" + color.Emphasize(""infrastructure pattern"") + "" best represents your application?""
++	appInitAppTypeHelpPrompt = `Your application's architecture. Most applications need additional AWS resources to run.
++To help setup the infrastructure resources, select what ""kind"" or ""type"" of application you want to build.`
++
++	fmtAppInitAppNamePrompt     = ""What do you want to "" + color.Emphasize(""name"") + "" this %s?""
++	fmtAppInitAppNameHelpPrompt = `The name will uniquely identify this application within your %s project.
++Deployed resources (such as your service, logs) will contain this app's name and be tagged with it.`
++
++	fmtAppInitDockerfilePrompt  = ""Which Dockerfile would you like to use for %s app?""
++	appInitDockerfileHelpPrompt = ""Dockerfile to use for building your application's container image.""
++)
++
+ const (
+ 	fmtAddAppToProjectStart    = ""Creating ECR repositories for application %s.""
+ 	fmtAddAppToProjectFailed   = ""Failed to create ECR repositories for application %s.""",Would it be better to put like `Which Dockerfile would you like to use for %s?`,I think it would be better to use `
+7223,"@@ -3636,8 +3636,8 @@ Model.hydrate = function(obj) {
+  * @see response http://docs.mongodb.org/v2.6/reference/command/update/#output
+  * @param {Object} filter
+  * @param {Object} doc
+- * @param {Object} [options] optional see [`Query.prototype.setOptions()`](http://mongoosejs.com/docs/api.html#query_Query-setOptions)
+- * @param {Boolean|String} [options.strict] overwrites the schema's [strict mode option](http://mongoosejs.com/docs/guide.html#strict)
++ * @param {Object} [options] optional see [`Query.prototype.setOptions()`](/api.html#query_Query-setOptions)
++ * @param {Boolean|String} [options.strict] overwrites the schema's [strict mode option](/docs/guide.html#strict)
+  * @param {Boolean} [options.upsert=false] if true, and no documents found, insert a new document
+  * @param {Object} [options.writeConcern=null] sets the [write concern](https://docs.mongodb.com/manual/reference/write-concern/) for replica sets. Overrides the [schema-level write concern](/docs/guide.html#writeConcern)
+  * @param {Boolean} [options.omitUndefined=false] If true, delete any properties whose value is `undefined` when casting an update. In other words, if this is set, Mongoose will delete `baz` from the update in `Model.updateOne({}, { foo: 'bar', baz: undefined })` before sending the update to the server.","You mistakenly removed `/docs` here, please add it",Why did you remove the `http` here?
+7224,"@@ -48,8 +48,9 @@ public interface FileAppender<D> extends Closeable {
+   long length();
+ 
+   /**
+-   * @return a list of offsets for file blocks if applicable, null otherwise. When available, this
++   * @return a list of offsets for file blocks, if applicable, null otherwise. When available, this
+    * information is used for planning scan tasks whose boundaries are determined by these offsets.
++   * It is important that the returned list is sorted in ascending order.
+    * Only valid after the file is closed.
+    */
+   default List<Long> splitOffsets() {","I missed this earlier, but why does this say ""file blocks""? This should probably be ""recommended split locations"".","nit: ""it is important that the returned list is sorted in ascending order"""
+7225,"@@ -33,10 +33,10 @@ import (
+ // AlertsServer implements api.OpenStorageAlertsServer.
+ // In order to use this server implementation just have
+ // AlertsServer pointer properly instantiated with a valid
+-// alerts.Reader.
++// alerts.FilterDeleter.
+ type AlertsServer struct {
+-	// Reader holds pointer to alerts Reader
+-	Reader alerts.Reader
++	// FilterDeleter holds pointer to alerts FilterDeleter
++	FilterDeleter alerts.FilterDeleter
+ }
+ 
+ func getOpts(opts []*api.SdkAlertsOption) []alerts.Option {",Please change this to non-exported.,Why is this a pointer?
+7226,"@@ -4649,10 +4649,7 @@ stats_get_snapshot(dr_stats_t *drstats)
+     if (!GLOBAL_STATS_ON())
+         return false;
+     CLIENT_ASSERT(drstats != NULL, ""Expected non-null value for parameter drstats."");
+-    /* We are at V1 of the structure, and we can't return less than the one
+-     * field. We need to remove this assert when we add more fields.
+-     */
+-    CLIENT_ASSERT(drstats->size >= sizeof(dr_stats_t), ""Invalid drstats->size value."");
+     drstats->basic_block_count = GLOBAL_STAT(num_bbs);
++    drstats->peak_num_threads = GLOBAL_STAT(peak_num_threads);
+     return true;
+ }",This is ignoring compatibility: it needs to check the size to ensure this field exists in the client.,Why is this assert removed?
+7227,"@@ -96,10 +96,11 @@ public class RoundChangePayloadValidator {
+       return false;
+     }
+ 
+-    if (certificate.getPreparePayloads().size() < minimumPrepareMessages) {
++    if (certificate.getPreparePayloads().stream().map(SignedData::getAuthor).distinct().count()
++        < minimumPrepareMessages) {
+       LOG.info(
+-          ""Invalid RoundChange message, insufficient Prepare messages exist to justify ""
+-              + ""prepare certificate."");
++          ""Invalid RoundChange message, insufficient uniquely authored Prepare messages exist to ""
++              + "" justify  prepare certificate."");
+       return false;
+     }
+ ",Do all the prepare authors also need to be unique? Or is it enough the we have minimumPrepareMessages. I guess I'm wondering if need a hasDuplicateAuthors check like in the RoundChangeCertificateValidator.,nit: space after `justify`
+7228,"@@ -4,12 +4,17 @@ package stdlib
+ 
+ import (
+ 	_ ""github.com/influxdata/flux/stdlib/csv""
++	_ ""github.com/influxdata/flux/stdlib/date""
+ 	_ ""github.com/influxdata/flux/stdlib/generate""
+ 	_ ""github.com/influxdata/flux/stdlib/http""
+ 	_ ""github.com/influxdata/flux/stdlib/influxdata/influxdb""
+ 	_ ""github.com/influxdata/flux/stdlib/influxdata/influxdb/v1""
+ 	_ ""github.com/influxdata/flux/stdlib/kafka""
+ 	_ ""github.com/influxdata/flux/stdlib/math""
++	_ ""github.com/influxdata/flux/stdlib/mqtt""
++	_ ""github.com/influxdata/flux/stdlib/promql""
++	_ ""github.com/influxdata/flux/stdlib/regexp""
++	_ ""github.com/influxdata/flux/stdlib/runtime""
+ 	_ ""github.com/influxdata/flux/stdlib/socket""
+ 	_ ""github.com/influxdata/flux/stdlib/sql""
+ 	_ ""github.com/influxdata/flux/stdlib/strings""","we had some situations where we merged some promql bits then took them out. i'm not sure what's going on here, but unless your code actually needs promql (probably not?) let's remove this line.",Why is this needed?
+7229,"@@ -32,9 +32,9 @@ class SettingValueDataFixture extends AbstractReferenceFixture implements Depend
+     {
+         $termsAndConditions = $this->getReference(ArticleDataFixture::ARTICLE_TERMS_AND_CONDITIONS_1);
+         $privacyPolicy = $this->getReference(ArticleDataFixture::ARTICLE_PRIVACY_POLICY_1);
+-        /* @var $termsAndConditions \Shopsys\FrameworkBundle\Model\Article\Article */
++        /* @var $termsAndConditions \Shopsys\ShopBundle\Model\Article\Article */
+         $cookies = $this->getReference(ArticleDataFixture::ARTICLE_COOKIES_1);
+-        /* @var $cookies \Shopsys\FrameworkBundle\Model\Article\Article */
++        /* @var $cookies \Shopsys\ShopBundle\Model\Article\Article */
+ 
+         $personalDataDisplaySiteContent = 'By entering an email below, you can view your personal information that we register in our online store. 
+         An email with a link will be sent to you after entering your email address, to verify your identity. ","Annotations in this hunk should follow PhpDoc style (above the occurrence, type first)",Why did you change 
+7230,"@@ -100,7 +100,7 @@ public class Wildcard implements Type {
+         } else if (type == BoundType.EXTENDS) {
+             return ""? extends "" + boundedType.describe();
+         } else {
+-            throw new UnsupportedOperationException();
++            throw new UnsupportedOperationException(String.format(""%s is not supported"", type));
+         }
+     }
+ ","This is an improvement - thanks! Could we rephrase slightly to not use the phrase ""is not supported"" -- instead stating _WHAT_ isn't valid please? e.g. maybe `String.format(""Unsupported BoundType provided: %s"" type)` or something like that.",`UnsupportedOperati
+7231,"@@ -30,7 +30,7 @@ type linuxWatcher struct {
+ 	gid       uint32
+ 	pid       int32
+ 	mtx       sync.Mutex
+-	procfh    *os.File
++	procfh    int
+ 	starttime string
+ 	uid       uint32
+ }",nit: `procfd` seems more appropriate now?,Why did you change 
+7232,"@@ -1045,6 +1045,10 @@ def access_put(owner, package_name, user):
+             ""Only the package owner can grant access""
+         )
+ 
++    django_headers = {
++        AUTHORIZATION_HEADER: g.auth_header
++        }
++
+     package = (
+         Package.query
+         .with_for_update()",Let's not call it django. Maybe `auth_provider_headers`? `auth_headers`?,Why do we need this?
+7233,"@@ -252,7 +252,8 @@ func (s *Server) isClientAuthorized(c *client) bool {
+ 	tlsMap := s.opts.TLSMap
+ 	s.optsMu.RUnlock()
+ 
+-	// Check custom auth first, then jwts, then nkeys, then multiple users, then token, then single user/pass.
++	// Check custom auth first, then jwts, then nkeys, then
++	// multiple users, then token, then single user/pass.
+ 	if customClientAuthentication != nil {
+ 		return customClientAuthentication.Check(c)
+ 	}",Should we mention TLS map here?,nit: can we remove t
+7234,"@@ -25,9 +25,12 @@
+ package net.runelite.client.plugins.playerindicators;
+ 
+ import java.awt.Color;
++
++import net.runelite.api.ClanMemberRank;
+ import net.runelite.client.config.Config;
+ import net.runelite.client.config.ConfigGroup;
+ import net.runelite.client.config.ConfigItem;
++import net.runelite.client.config.Range;
+ 
+ @ConfigGroup(""playerindicators"")
+ public interface PlayerIndicatorsConfig extends Config",remove this empty line pl0x,Remove this empty li
+7235,"@@ -34,4 +34,10 @@ class NcrDispatcher < LinearDispatcher
+       end
+     }
+   end
++
++  def on_approver_removal(proposal, approvers)
++    approvers.each{|approver|
++      CommunicartMailer.notification_for_subscriber(approver.email_address,proposal,""removed"").deliver_now
++    }
++  end
+ end",Why not have this in the `Dispatcher`? Doesn't seem like NCR-specific functionality.,Space missing after 
+7236,"@@ -26,6 +26,11 @@ import (
+ )
+ 
+ func CreateTestKV(t *testing.T) kv.RwDB {
++	s, _, _ := CreateTestSentry(t)
++	return s.DB
++}
++
++func CreateTestSentry(t *testing.T) (*stages.MockSentry, *core.ChainPack, []*core.ChainPack) {
+ 	// Configure and generate a sample block chain
+ 	var (
+ 		key, _   = crypto.HexToECDSA(""b71c71a67e1177ad4e901695e1b4b9ee17ae16c6668d313eac2f96dbcda3f291"")","If you need only test db, use `memdb.NewTestDB(t)`",`CreateTestSentry` is unused (from `deadcode`)
+7237,"@@ -533,7 +533,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+                             await ProduceEnd();
+ 
+                             // ForZeroContentLength does not complete the reader nor the writer
+-                            if (!messageBody.IsEmpty && _keepAlive)
++                            if (!messageBody.IsEmpty)
+                             {
+                                 // Finish reading the request body in case the app did not.
+                                 await messageBody.ConsumeAsync();",I'm not sure I like setting the IsEmpty property true for upgraded connections since it feels a middle misleading. Maybe we can leave the ForUpgrade class as is and change this condition to `if (!messageBody.IsEmpty && !messageBody.RequestUpgrade)` to make things more explicit.,Why was this removed?
+7238,"@@ -141,7 +141,7 @@ ActiveRecord::Schema.define(version: 20151123235600) do
+     t.integer  ""client_data_id""
+     t.string   ""client_data_type"", limit: 255
+     t.integer  ""requester_id""
+-    t.string   ""public_id""
++    t.string   ""public_id"",        limit: 255
+   end
+ 
+   add_index ""proposals"", [""client_data_id"", ""client_data_type""], name: ""index_proposals_on_client_data_id_and_client_data_type"", using: :btree",git checkout since this is unrelated to this PR? (running migrations also changes this for me -- not sure why it keeps going back and forth,Unnecessary spacing detected.
+7239,"@@ -154,7 +154,7 @@ class _TLSSignature(_GenericTLSSessionInheritance):
+     #XXX 'sig_alg' should be set in __init__ depending on the context.
+     """"""
+     name = ""TLS Digital Signature""
+-    fields_desc = [SigAndHashAlgField(""sig_alg"", 0x0401, _tls_hash_sig),
++    fields_desc = [SigAndHashAlgField(""sig_alg"", 0x0804, _tls_hash_sig),
+                    SigLenField(""sig_len"", None, fmt=""!H"",
+                                length_of=""sig_val""),
+                    SigValField(""sig_val"", None,",Is this change needed?,Why did you change this?
+7240,"@@ -1321,7 +1321,7 @@ void MolPickler::_pickleAtom(std::ostream &ss, const Atom *atom) {
+     streamWrite(ss, ENDQUERY);
+   }
+   if (getAtomMapNumber(atom, tmpInt)) {
+-    if (tmpInt < 128) {
++    if (tmpInt >= 0 && tmpInt < 128) {
+       tmpChar = static_cast<char>(tmpInt % 128);
+       streamWrite(ss, ATOM_MAPNUMBER, tmpChar);
+     } else {",Isn't the % 128 redundant here?,Shouldn't this be `<=`?
+7241,"@@ -34,7 +34,9 @@ func TestCmdMarshalProto(t *testing.T) {
+  ""sticky"": false,
+  ""group_enforced"": false,
+  ""compressed"": false,
+- ""cascaded"": false
++ ""cascaded"": false,
++ ""loopdev"": false,
++ ""ramdisk"": false
+ }`,
+ 		data,
+ 	)","Are you testing that the values are always false? I think you should test for setting values to true or false, right? Who is going to take action with these values?",I don't think this shou
+7242,"@@ -35,6 +35,9 @@ extern const struct batch_queue_module batch_queue_wq;
+ extern const struct batch_queue_module batch_queue_mesos;
+ extern const struct batch_queue_module batch_queue_k8s;
+ extern const struct batch_queue_module batch_queue_dryrun;
++#ifdef MPI
++extern const struct batch_queue_module batch_queue_mpi;
++#endif
+ 
+ static struct batch_queue_module batch_queue_unknown = {
+ 	BATCH_QUEUE_TYPE_UNKNOWN, ""unknown"",",Please change MPI to CCTOOLS_WITH_MPI,Why do we need this?
+7243,"@@ -16,6 +16,11 @@
+ 
+ #include ""oneapi/dal/algo/decision_forest/common.hpp""
+ #include ""oneapi/dal/algo/decision_forest/detail/model_impl.hpp""
++#include ""oneapi/dal/exceptions.hpp""
++
++#define DAL_CHECK_DOMAIN_COND(cond, description) \
++    if (!(cond))                                 \
++        throw domain_error(description);
+ 
+ namespace oneapi::dal::decision_forest {
+ ",Why you can't use function here?,throw domain_error(desc
+7244,"@@ -0,0 +1,16 @@
++// Copyright 2018 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++//
++// Licensed under the Apache License, Version 2.0 (the ""License""). You may
++// not use this file except in compliance with the License. A copy of the
++// License is located at
++//
++//	http://aws.amazon.com/apache2.0/
++//
++// or in the ""license"" file accompanying this file. This file is distributed
++// on an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
++// express or implied. See the License for the specific language governing
++// permissions and limitations under the License.
++
++package ssm
++
++//go:generate go run ../../scripts/generate/mockgen.go github.com/aws/aws-sdk-go/service/ssm/ssmiface SSMAPI mocks/ssmiface_mocks.go",We should scope this down to only the methods we use.,Can we remove this file?
+7245,"@@ -800,7 +800,7 @@ public final class HashSet<T> implements Set<T>, Serializable {
+ 
+     @Override
+     public String toString() {
+-        return mkString("", "", ""HashSet("", "")"");
++        return mkString(""HashSet("", "", "", "")"");
+     }
+ 
+     private static <T> HashArrayMappedTrie<T, T> addAll(HashArrayMappedTrie<T, T> initial,","Oh, thanks for catching - I thought I've catched all after changing `mkString(infix, prefix, suffix)` to `mkString(prefix, infix, suffix)`.",Why did you change this?
+7246,"@@ -33,6 +33,14 @@ const (
+ 	// Issued indicates that a CertificateRequest has been completed, and that
+ 	// the `status.certificate` field is set.
+ 	CertificateRequestReasonIssued = ""Issued""
++
++	// Approved indicates that a CertificateRequest has been approved by the
++	// approver, and the CertificateRequest is ready for signing.
++	CertificateRequestReasonApproved = ""Approved""
++
++	// Denied indicates that a CertificateRequest has been denied by the
++	// approver, and the CertificateRequest will be never be signed.
++	CertificateRequestReasonDenied = ""Denied""
+ )
+ 
+ // +genclient","Suggestion: `.. the CertificateRequest is ready for signing` - could we perhaps word this differently? I understand that in this case it will be the associated X.509 certificate that can now be signed, so maybe `the certificate is ready for signing` ? (Same with `CertificateRequestReasonDenied`).",I don't think we need th
+7247,"@@ -54,6 +54,10 @@ export default function PropertySelect() {
+ 		}
+ 	}, [ propertyID, selectProperty ] );
+ 
++	if ( ! accountID ) {
++		return null;
++	}
++
+ 	if ( isLoading ) {
+ 		return <ProgressBar small />;
+ 	}",We should use `! isValidAccountID( accountID )` for the `accountID` checks.,Why do we need this chec
+7248,"@@ -6,7 +6,9 @@ require 'bolt/error'
+ module Bolt
+   class Target
+     attr_reader :uri, :options
+-    attr_writer :inventory
++    # CODEREVIEW: this feels wrong. The altertative is threading inventory through the
++    # executor to the RemoteTransport
++    attr_accessor :inventory
+ 
+     PRINT_OPTS ||= %w[host user port protocol].freeze
+ ",That alternative does seem better. Did you want to try to do it in this PR? It makes sense to me that the inventory would always be available before creating the executor.,Why is this necessary?
+7249,"@@ -545,8 +545,12 @@ module Beaker
+           on host, ""apt-get install -y hiera=#{opts[:hiera_version]}-1puppetlabs1""
+         end
+ 
+-        puppet_pkg = opts[:version] ? ""puppet=#{opts[:version]}-1puppetlabs1"" : 'puppet'
+-        on host, ""apt-get install -y #{puppet_pkg}""
++        if opts[:version]
++          on host, ""apt-get install -y puppet-common=#{opts[:version]}-1puppetlabs1""
++          on host, ""apt-get install -y puppet=#{opts[:version]}-1puppetlabs1""
++        else
++          on host, 'apt-get install -y puppet'
++        end
+       end
+ 
+       # Installs Puppet and dependencies from msi",Missing the `-y` argument which all other `apt-get install` commands have.,Why not just `apt-get 
+7250,"@@ -1295,7 +1295,8 @@ bool CoreChecks::ValidatePipelineUnlocked(const PIPELINE_STATE *pPipeline, uint3
+     auto subpass_desc = &pPipeline->rp_state->createInfo.pSubpasses[pPipeline->graphicsPipelineCI.subpass];
+     if (pPipeline->graphicsPipelineCI.subpass >= pPipeline->rp_state->createInfo.subpassCount) {
+         skip |= LogError(device, ""VUID-VkGraphicsPipelineCreateInfo-subpass-00759"",
+-                         ""Invalid Pipeline CreateInfo[%u] State: Subpass index %u is out of range for this renderpass (0..%u)."",
++                         ""Invalid Pipeline CreateInfo[%"" PRIu32
++                         ""] State: Subpass index %u is out of range for this renderpass (0..%u)."",
+                          pipelineIndex, pPipeline->graphicsPipelineCI.subpass, pPipeline->rp_state->createInfo.subpassCount - 1);
+         subpass_desc = nullptr;
+     }","So I think we are going to settle on the ""concise and elegant"" `PRI` macros as they are the safest option for now. Even though they make my eyes bleed a little...",I think this should be
+7251,"@@ -112,7 +112,7 @@ func (r *Replacer) ReplaceFunc(input string, f ReplacementFunc) (string, error)
+ func (r *Replacer) replace(input, empty string,
+ 	treatUnknownAsEmpty, errOnEmpty, errOnUnknown bool,
+ 	f ReplacementFunc) (string, error) {
+-	if !strings.Contains(input, string(phOpen)) {
++	if !strings.Contains(input, string(phOpen)) && !strings.Contains(input, string(phClose)) {
+ 		return input, nil
+ 	}
+ ","Interesting, was this needed for a test case to pass? I figured if there is no opening brace, there is definitely no placeholder -- we don't even have to check for a closing one.",Why do we need this ch
+7252,"@@ -122,8 +122,10 @@ ChainLoop:
+ 			return []explorer.Transfer{}, err
+ 		}
+ 
+-		for i := len(blk.Transfers) - 1; i >= 0; i-- {
+-			if showCoinBase || !blk.Transfers[i].IsCoinbase() {
++		transfers, _, _ := action.ClassifyActions(blk.Actions)
++
++		for i := len(transfers) - 1; i >= 0; i-- {
++			if showCoinBase || !transfers[i].IsCoinbase() {
+ 				transferCount++
+ 			}
+ ",I think we want to provide getAction API instead,Shouldn't this be `len(transfers)`?
+7253,"@@ -117,12 +117,7 @@ class SynthDriver(SynthDriver):
+ 
+ 	@classmethod
+ 	def check(cls):
+-		if not hasattr(sys, ""frozen""):
+-			# #3793: Source copies don't report the correct version on Windows 10 because Python isn't manifested for higher versions.
+-			# We want this driver to work for source copies on Windows 10, so just return True here.
+-			# If this isn't in fact Windows 10, it will fail when constructed, which is okay.
+-			return True
+-		# For binary copies, only present this as an available synth if this is Windows 10.
++		# Only present this as an available synth if this is Windows 10.
+ 		return winVersion.winVersion.major >= 10
+ 
+ 	def _get_supportsProsodyOptions(self):","There is also `winVersion.isWin10`. I think this should be converted to use the helper function. The helper has a note that it doesn't work in source copies, but looking at the implementation it looks equivalent to what you have here.",Why is this being removed?
+7254,"@@ -37,6 +37,7 @@ RSpec.configure do |config|
+   config.use_transactional_fixtures = false
+   config.use_instantiated_fixtures  = false
+   config.fixture_path = ""#{::Rails.root}/spec/fixtures""
++  config.fail_fast = true
+ 
+   config.include Paperclip::Shoulda::Matchers
+   config.include EmailSpec::Helpers",This doesn't seem like it should be part of this pull request.,config.fail_fast = true
+7255,"@@ -4,6 +4,7 @@ class ProductsController < ApplicationController
+ 
+   def show
+     @product = Product.find(params[:id])
++    @offering = @product
+     @viewable_subscription = ViewableSubscription.new(current_user, subscription_product)
+ 
+     if signed_in? && @product.purchase_for(current_user)",Is the idea that `@product` (and `@workshop` for `workshops_controller`) would eventually go away here?,Why do we need this line?
+7256,"@@ -0,0 +1,8 @@
++package headerdownload
++
++var bscMainnetPreverifiedHashes = []string{
++	""0d21840abff46b96c84b2ac9e10e4f5cdaeb5693cb665db62a2f3b02d2d57b5b"",
++	""04055304e432294a65ff31069c4d3092ff8b58f009cdb50eba5351e0332ad0f6"",
++}
++
++const bscMainnetPreverifiedHeight uint64 = 1","We should add those only once we have successfully synced to the BSC main net, we have a utility to generate those. Please remove for now",Why do we need this file?
+7257,"@@ -376,7 +376,7 @@ def test_set_env_from_file(config_instance):
+ 
+ 
+ def test_set_env_from_file_returns_original_env_when_env_file_not_found(
+-    config_instance
++    config_instance,
+ ):
+     env = config.set_env_from_file({}, 'file-not-found')
+ ",And how is that related?,Why the comma?
+7258,"@@ -55,7 +55,8 @@ func AdminAddOrUpdateRemoteCluster(c *cli.Context) {
+ 	defer cancel()
+ 
+ 	_, err := adminClient.AddOrUpdateRemoteCluster(ctx, &adminservice.AddOrUpdateRemoteClusterRequest{
+-		FrontendAddress: getRequiredOption(c, FlagFrontendAddressWithAlias),
++		FrontendAddress:               c.String(FlagFrontendAddressWithAlias),
++		EnableRemoteClusterConnection: c.BoolT(FlagConnectionEnableAlias),
+ 	})
+ 	if err != nil {
+ 		ErrorAndExit(""Operation AddOrUpdateRemoteCluster failed."", err)",this should be required,Shouldn't this be `c.Bool
+7259,"@@ -18,6 +18,7 @@ import com.google.api.codegen.SnippetSetRunner;
+ import com.google.auto.value.AutoValue;
+ import java.util.List;
+ import javax.annotation.Nullable;
++import javax.validation.constraints.Null;
+ 
+ @AutoValue
+ public abstract class DynamicLangXApiView implements ViewModel {",This appears to be unused,Why is this needed?
+7260,"@@ -63,6 +63,19 @@ public class SnapshotUtil {
+     return ancestorIds(table.currentSnapshot(), table::snapshot);
+   }
+ 
++  /**
++   * Traverses the history of the table's state and finds the oldest Snapshot.
++   * @return null if the table is empty, else the oldest Snapshot.
++   */
++  public static Snapshot oldestSnapshot(Table table) {
++    Snapshot current = table.currentSnapshot();
++    while (current != null && current.parentId() != null) {
++      current = table.snapshot(current.parentId());
++    }
++
++    return current;
++  }
++
+   /**
+    * Returns list of snapshot ids in the range - (fromSnapshotId, toSnapshotId]
+    * <p>","I think that ""table's state"" isn't clear enough. How about ""history of the table's current snapshot"" like the one below?",I think this should be `current.parentId() == null`
+7261,"@@ -457,3 +457,17 @@ instr_is_exclusive_store(instr_t *instr)
+     }
+     return false;
+ }
++
++DR_API
++bool
++instr_is_scatter(instr_t *instr)
++{
++    return false;
++}
++
++DR_API
++bool
++instr_is_gather(instr_t *instr)
++{
++    return false;
++}",This looks like a bug: pretty sure there are scatter-gather instructions on AArch64. Ditto below.,I don't think this is needed.
+7262,"@@ -55,9 +55,10 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // sharing this transport.
+ func (t *Transport) NewInbound(addr string, opts ...InboundOption) *Inbound {
+ 	i := &Inbound{
+-		once:   sync.Once(),
+-		addr:   addr,
+-		tracer: t.tracer,
++		once:      sync.Once(),
++		addr:      addr,
++		tracer:    t.tracer,
++		transport: t,
+ 	}
+ 	for _, opt := range opts {
+ 		opt(i)","No need to change this: id love if we changed as a team to unkeyed fields, it ends up catching a lot more at compile time, at minimal cost",Why do we need a new transport here?
+7263,"@@ -105,6 +105,11 @@ func (m LBFargateManifest) DockerfilePath() string {
+ 	return m.Image.Build
+ }
+ 
++// AppName returns the name of the application
++func (m LBFargateManifest) AppName() string {
++	return m.Name
++}
++
+ // EnvConf returns the application configuration with environment overrides.
+ // If the environment passed in does not have any overrides then we return the default values.
+ func (m *LBFargateManifest) EnvConf(envName string) LBFargateConfig {",Should this be in the parent struct? `AppManifest` since it's embedded to `LBFargateManifest` it'll get the method as well.,Why do we need this?
+7264,"@@ -18,7 +18,12 @@
+ package openvpn
+ 
+ import (
++	""bufio""
++	""bytes""
+ 	""errors""
++	log ""github.com/cihub/seelog""
++	""io""
++	""net/textproto""
+ 	""os/exec""
+ 	""strconv""
+ 	""syscall""","""Openvpn check"" we could move this to separate prefix.",Why do we need this?
+7265,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+ 
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests,Why do we need to cl
+7266,"@@ -42,8 +42,6 @@ void LookUpEdgeIndexProcessor::process(const cpp2::LookUpIndexRequest& req) {
+             } else {
+                 this->pushResultCode(this->to(code), partId);
+             }
+-            this->onFinished();
+-            return;
+         }
+     });
+ ",We don't return now?,Why did you remove t
+7267,"@@ -18,7 +18,7 @@ module Travis
+         end
+ 
+         def install
+-          uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install'
++          uses_make? then: 'true', else: 'go get -d -v ./... && go build -v ./...', fold: 'install', retry: true
+         end
+ 
+         def script","This might end up not doing exactly what we want (the retry only picks up the `go get`, not the `go build`, due to the `&&`).",Why is this needed?
+7268,"@@ -1,4 +1,4 @@
+-// <copyright file=""ConsoleExporterOptions.cs"" company=""OpenTelemetry Authors"">
++// <copyright file=""ConsoleExporterOptions.cs"" company=""OpenTelemetry Authors"">
+ // Copyright The OpenTelemetry Authors
+ //
+ // Licensed under the Apache License, Version 2.0 (the ""License"");",Is there a BOM change?,This should be reverted
+7269,"@@ -142,8 +142,6 @@ public final class Const {
+ 
+   public static final String REGISTRY_SERVICE_NAME = ""SERVICECENTER"";
+ 
+-  public static final String REGISTRY_VERSION = ""3.0.0"";
+-
+   public static final String APP_SERVICE_SEPARATOR = "":"";
+ 
+   public static final String PATH_CHECKSESSION = ""checksession"";",It's not a good practise to delete the public static constant.,Why is this removed?
+7270,"@@ -467,13 +467,7 @@ func (eval *BlockEvaluator) transaction(txn transactions.SignedTxn, ad transacti
+ 			return TransactionInLedgerError{txn.ID()}
+ 		}
+ 
+-		// Well-formed on its own?
+-		err = txn.Txn.WellFormed(spec, eval.proto)
+-		if err != nil {
+-			return fmt.Errorf(""transaction %v: malformed: %v"", txn.ID(), err)
+-		}
+-
+-		// Properly signed?
++		// Well-formed and signed properly?
+ 		if eval.txcache == nil || !eval.txcache.Verified(txn) {
+ 			err = verify.TxnPool(&txn, spec, eval.proto, eval.verificationPool)
+ 			if err != nil {",I deleted this because `WellFormed` is immediately called by `verify.TxnPool` below. Can someone please double check this for me since it's... pretty important,Why is this removed?
+7271,"@@ -70,6 +70,7 @@ setup(
+         ""kaitaistruct>=0.7,<0.9"",
+         ""ldap3>=2.5,<2.6"",
+         ""passlib>=1.6.5, <1.8"",
++        ""ply>=3.4, <3.12"",
+         ""pyasn1>=0.3.1,<0.5"",
+         ""pyOpenSSL>=17.5,<18.1"",
+         ""pyparsing>=2.1.3, <2.3"",","Did you actually test this with ply 3.4? That release is pretty old (2011), so I think we can bump this to at least 3.6 (2015) or even 3.10 (2017)...",This should be `ply>=3.
+7272,"@@ -130,6 +130,12 @@ func (r *ReconcileHiveConfig) deployHive(hLog log.FieldLogger, h *resource.Helpe
+ 
+ 	r.includeGlobalPullSecret(hLog, h, instance, hiveDeployment)
+ 
++	if instance.Spec.MaintenanceMode != nil && *instance.Spec.MaintenanceMode {
++		hLog.Warn(""maintenanceMode enabled in HiveConfig, setting hive-controllers replicas to 0"")
++		replicas := int32(0)
++		hiveDeployment.Spec.Replicas = &replicas
++	}
++
+ 	result, err := h.ApplyRuntimeObject(hiveDeployment, scheme.Scheme)
+ 	if err != nil {
+ 		hLog.WithError(err).Error(""error applying deployment"")",This can be simplified somewhat to `pointer.Int32Ptr(0)`. But it is not necessary.,Why do we need this?
+7273,"@@ -226,9 +226,7 @@ static bool checkBondStereo(const MCSBondCompareParameters& p,
+   Bond::BondStereo bs1 = b1->getStereo();
+   Bond::BondStereo bs2 = b2->getStereo();
+   if (b1->getBondType() == Bond::DOUBLE && b2->getBondType() == Bond::DOUBLE) {
+-    if ((bs1 == Bond::STEREOZ || bs1 == Bond::STEREOE) &&
+-        !(bs2 == Bond::STEREOZ || bs2 == Bond::STEREOE))
+-      return false;
++    if (bs1 > Bond::STEREOANY && !(bs2 > Bond::STEREOANY)) return false;
+   }
+   return true;
+ }",Clever but perhaps confusing.,I think this should 
+7274,"@@ -360,10 +360,14 @@ func (r *ReconcileSyncSetInstance) syncDeletedSyncSetInstance(ssi *hivev1.SyncSe
+ 
+ 	ssiLog.Info(""deleting syncset resources on target cluster"")
+ 	err = r.deleteSyncSetResources(ssi, dynamicClient, ssiLog)
+-	if err == nil {
+-		return reconcile.Result{}, r.removeSyncSetInstanceFinalizer(ssi, ssiLog)
++	if err != nil {
++		return reconcile.Result{}, err
++	}
++	err = r.deleteSyncSetSecretReferences(ssi, dynamicClient, ssiLog)
++	if err != nil {
++		return reconcile.Result{}, err
+ 	}
+-	return reconcile.Result{}, err
++	return reconcile.Result{}, r.removeSyncSetInstanceFinalizer(ssi, ssiLog)
+ }
+ 
+ func (r *ReconcileSyncSetInstance) applySyncSet(ssi *hivev1.SyncSetInstance, spec *hivev1.SyncSetCommonSpec, dynamicClient dynamic.Interface, h Applier, kubeConfig []byte, ssiLog log.FieldLogger) error {",@abutcher Is it a safe assumption that secrets are the only objects that need to get attached to syncsets?,Why do we need to de
+7275,"@@ -1605,7 +1605,8 @@ func (o *consumer) needAck(sseq uint64) bool {
+ 		state, err := o.store.State()
+ 		if err != nil || state == nil {
+ 			o.mu.RUnlock()
+-			return false
++			// Fall back to what we track internally for now.
++			return sseq > o.asflr
+ 		}
+ 		asflr, osseq = state.AckFloor.Stream, o.sseq
+ 		pending = state.Pending",Should you capture o.asflr before releasing consumer's lock?,I'm not sure if this
+7276,"@@ -51,6 +51,10 @@ public class WinePrefixContainerWineToolsTab extends Tab {
+         final VBox toolsPane = new VBox();
+         final Text title = new TextWithStyle(tr(""Wine tools""), TITLE_CSS_CLASS);
+ 
++        if (engineTools == null) {
++            return;
++        }
++
+         toolsPane.getStyleClass().add(CONFIGURATION_PANE_CSS_CLASS);
+         toolsPane.getChildren().add(title);
+ ","Just asking: Should this happen, that null is passed? If this is the case I think we should think about passing an `Optional` object to the method.",Why is this null check needed?
+7277,"@@ -10,6 +10,17 @@ class HomeController < ApplicationController
+   def me
+   end
+ 
++  def edit_me
++    first_name = params[:first_name]
++    last_name = params[:last_name]
++    user = current_user
++    user.first_name = first_name
++    user.last_name = last_name
++    user.save!
++    flash[:success] = ""Your profile is updated!""
++    redirect_to :me
++  end
++
+   def error
+     raise ""test exception""
+   end","what about making a `ProfilesController` or `UserProfilesController` and having this be a `show` action instead? That would be more Railsy (although that can be considered a compliment or a dis, depending on who you are :hamburger: )",Extra empty line detected at c
+7278,"@@ -2378,7 +2378,11 @@ void PostCallRecordCreateDevice(VkPhysicalDevice gpu, const VkDeviceCreateInfo *
+     }
+ 
+     layer_data *device_data = GetLayerDataPtr(get_dispatch_key(*pDevice), layer_data_map);
+-    device_data->enabled_features.core = *enabled_features_found;
++    if (nullptr == enabled_features_found) {
++        device_data->enabled_features.core = {};
++    } else {
++        device_data->enabled_features.core = *enabled_features_found;
++    }
+ 
+     uint32_t count;
+     instance_data->dispatch_table.GetPhysicalDeviceQueueFamilyProperties(gpu, &count, nullptr);",I'd move the empty assignment and non-null case into the if check directly above (adding an else clause as needed),Why do we need this change?
+7279,"@@ -215,6 +215,8 @@ class Preference extends Model
+             'zh-tw' => [Lang::get('system::lang.locale.zh-tw'), 'flag-tw'],
+             'nb-no' => [Lang::get('system::lang.locale.nb-no'), 'flag-no'],
+             'el' => [Lang::get('system::lang.locale.el'), 'flag-gr'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++
+         ];
+ 
+         $locales = Config::get('app.localeOptions', $localeOptions);",Please remove this extra line of whitespace,Please add a comma after the l
+7280,"@@ -83,14 +83,15 @@ class ProductSearchExportWithFilterRepository
+     /**
+      * @param int $domainId
+      * @param string $locale
+-     * @param int $startFrom
++     * @param int $lastProcessedId
+      * @param int $batchSize
+      * @return array
+      */
+-    public function getProductsData(int $domainId, string $locale, int $startFrom, int $batchSize): array
++    public function getProductsData(int $domainId, string $locale, int $lastProcessedId, int $batchSize): array
+     {
+         $queryBuilder = $this->createQueryBuilder($domainId)
+-            ->setFirstResult($startFrom)
++            ->andWhere('p.id > :lastProcessedId')
++            ->setParameter('lastProcessedId', $lastProcessedId)
+             ->setMaxResults($batchSize);
+ 
+         $query = $queryBuilder->getQuery();","maybe it's time to rename `ProductSearchExportWithFilter` to something better, what do you think?",`$lastProcessedId` should be `int|null`
+7281,"@@ -49,11 +49,11 @@ func (agent *ecsAgent) appendTaskEIACapabilities(capabilities []*ecs.Attribute)
+ }
+ 
+ func (agent *ecsAgent) appendFirelensFluentdCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+-	return capabilities
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentd)
+ }
+ 
+ func (agent *ecsAgent) appendFirelensFluentbitCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {
+-	return capabilities
++	return appendNameOnlyAttribute(capabilities, attributePrefix+capabilityFirelensFluentbit)
+ }
+ 
+ func (agent *ecsAgent) appendEFSCapabilities(capabilities []*ecs.Attribute) []*ecs.Attribute {","Instead of adding new code here - can you move these methods to agent_capability.go, so the same is used for unix and windows as well. this will need removal of these methods from agent_capability_unix.go as well.",Why do we need this change?
+7282,"@@ -648,7 +648,7 @@ def log(package):
+             str(entry.get('tags', [])), str(entry.get('versions', []))))
+     _print_table(table)
+ 
+-def push(package, is_public=False, is_team=False, reupload=False):
++def push(package, hash=None, is_public=False, is_team=False, reupload=False):
+     """"""
+     Push a Quilt data package to the server
+     """"""","Make it the last parameter, just in case someone uses the API with non-keyword args.",`hash` is not used in this function.
+7283,"@@ -1,15 +1,15 @@
+-class GithubRemovalJob < Struct.new(:github_team, :username)
++class GithubRemovalJob < Struct.new(:repository, :username)
+   include ErrorReporting
+ 
+   PRIORITY = 1
+ 
+-  def self.enqueue(github_team, username)
+-    Delayed::Job.enqueue(new(github_team, username))
++  def self.enqueue(repository, username)
++    Delayed::Job.enqueue(new(repository, username))
+   end
+ 
+   def perform
+     begin
+-      github_client.remove_team_member(github_team, username)
++      github_client.remove_collaborator(repository, username)
+     rescue Octokit::NotFound, Net::HTTPBadResponse => e
+       Airbrake.notify(e)
+     end",Don't extend an instance initialized by `Struct.new`.,Metrics/CyclomaticComplexity: Cyclomati
+7284,"@@ -4771,6 +4771,11 @@ static void tdes(pmix_server_trkr_t *t)
+     if (NULL != t->info) {
+         PMIX_INFO_FREE(t->info, t->ninfo);
+     }
++    pmix_nspace_caddy_t *nm, *nm_next;
++    PMIX_LIST_FOREACH_SAFE(nm, nm_next, &t->nslist, pmix_nspace_caddy_t) {
++        pmix_list_remove_item (&t->nslist, &nm->super);
++        PMIX_RELEASE(nm);
++    }
+     PMIX_DESTRUCT(&t->nslist);
+ }
+ PMIX_CLASS_INSTANCE(pmix_server_trkr_t,","Just wondering - would it make more sense to simply replace `PMIX_DESTRUCT(&t->nslist)` with `PMIX_LIST_DESTRUCT(&t->nslist)` here, and then add `PMIX_RELEASE(p->jobbkt)` to the `pmix_nspace_caddy_t` destructor on line 154 of src/include/pmix_globals.c? Seems to me like we always want to have these things removed/destructed.",Shouldn't this be `PMIX_RELEASE(&nm->super);`?
+7285,"@@ -5,7 +5,13 @@
+ package net.sourceforge.pmd.lang.vf;
+ 
+ import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
++import net.sourceforge.pmd.lang.apex.rule.ApexXPathRule;
+ 
+ public class RuleSetFactoryTest extends AbstractRuleSetFactoryTest {
+-    // no additional tests
++    public RuleSetFactoryTest() {
++        super();
++        // Copied from net.sourceforge.pmd.lang.apex.RuleSetFactoryTest
++        // Apex rules are found in the classpath because this module has a dependency on pmd-apex
++        validXPathClassNames.add(ApexXPathRule.class.getName());
++    }
+ }","I think, we should fix/improve AbstractRuleSetFactoryTest. I guess, both apex and visualforce rules are now tested, which is unnecessary.",Why is this needed?
+7286,"@@ -111,6 +111,14 @@ class BackendController extends ControllerBase
+         self::extendableExtendCallback($callback);
+     }
+ 
++    /**
++     * @inheritDoc
++     */
++    public function callAction($method, $parameters)
++    {
++        return parent::callAction($method, array_values($parameters));
++    }
++
+     /**
+      * Pass unhandled URLs to the CMS Controller, if it exists
+      *",In php8 named parameters were introduced and now it is required to match called method parameter name when setting parameters by array destructing or `call_user_func_array()` etc.,Shouldn't this be `array_merge`?
+7287,"@@ -7,8 +7,10 @@ package javaslang.collection;
+ 
+ import javaslang.Function2;
+ import javaslang.Tuple2;
++import javaslang.control.Try;
+ import org.junit.Test;
+ 
++import java.lang.reflect.Field;
+ import java.util.List;
+ import java.util.Random;
+ import java.util.concurrent.ThreadLocalRandom;",easily possible to get that information without exposing internal information,This import is unused.
+7288,"@@ -65,7 +65,13 @@ module Beaker
+           found_env_vars[:answers][key] = value if key.to_s =~ /q_/
+         end
+         found_env_vars[:consoleport] &&= found_env_vars[:consoleport].to_i
+-        found_env_vars[:type] = found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes' ? 'pe' : nil
++        if found_env_vars[:is_pe] == 'true' || found_env_vars[:is_pe] == 'yes'
++          found_env_vars[:type] = 'pe'
++        elsif found_env_vars[:is_pe] == 'false' || found_env_vars[:is_pe] == 'no'
++          found_env_vars[:type] = 'foss'
++        else
++          found_env_vars[:type] = nil
++        end
+         found_env_vars[:pe_version_file_win] = found_env_vars[:pe_version_file]
+         found_env_vars[:answers].delete_if {|key, value| value.nil? or value.empty? }
+         found_env_vars.delete_if {|key, value| value.nil? or value.empty? }","Why do we need tristate logic (pe, foss, nil)?",I don't think you need the `? 'pe' : nil`
+7289,"@@ -19,13 +19,13 @@ import (
+ 
+ func TestBlocksAfterFlagTimeout(t *testing.T) {
+ 
+-	mu := sync.Mutex{}
++	mux := sync.Mutex{}
+ 	blocked := make(map[string]time.Duration)
+ 
+ 	mock := mockBlockLister(func(a swarm.Address, d time.Duration, r string) error {
+-		mu.Lock()
++		mux.Lock()
+ 		blocked[a.ByteString()] = d
+-		mu.Unlock()
++		mux.Unlock()
+ 
+ 		return nil
+ 	})",this change needs to be reverted to what is on `master`,Why is this change necessary?
+7290,"@@ -1076,9 +1076,14 @@ Blockly.WorkspaceSvg.prototype.deleteVariableById = function(id) {
+  * @package
+  */
+ Blockly.WorkspaceSvg.prototype.createVariable = function(name, opt_type, opt_id) {
++  var variableInMap = (this.getVariable(name) != null);
+   var newVar = Blockly.WorkspaceSvg.superClass_.createVariable.call(this, name,
+     opt_type, opt_id);
+-  this.refreshToolboxSelection_();
++  // For performance reaons, only refresh the the toolbox for new variables.
++  // Variables that already exist should already be there.
++  if (!variableInMap) {
++    this.refreshToolboxSelection_();
++  }
+   return newVar;
+ };
+ ",Do you still need to call the superclass `createVariable` if you've already determined that the variable exists?,Nit: `!variableInMap` -> `variableExists`
+7291,"@@ -281,7 +281,10 @@ type EachByPackResult struct {
+ }
+ 
+ // EachByPack returns a channel that yields all blobs known to the index
+-// grouped by packID but ignoring blobs with a packID in packPlacklist.
++// grouped by packID but ignoring blobs with a packID in packPlacklist for
++// finalized indexes.
++// This filtering is used when rebuilding the index where we need to ignore packs
++// from the finalized index which have been re-read into a non-finalized index.
+ // When the  context is cancelled, the background goroutine
+ // terminates. This blocks any modification of the index.
+ func (idx *Index) EachByPack(ctx context.Context, packBlacklist restic.IDSet) <-chan EachByPackResult {","Ignoring the pack entry from an existing entry but using the new entry from a non-finalized index, is subtle enough that it needs explaining.",nit: `for finalized indexes`
+7292,"@@ -236,9 +236,12 @@ uint32_t Spells::getInstantSpellCount(const Player* player) const
+ 
+ InstantSpell* Spells::getInstantSpellById(uint32_t spellId)
+ {
+-	auto it = std::next(instants.begin(), std::min<uint32_t>(spellId, instants.size()));
+-	if (it != instants.end()) {
+-		return it->second;
++	uint32_t count = 0;
++	for (const auto& it : instants) {
++		if (count == spellId) {
++			return it.second;
++		}
++		++count;
+ 	}
+ 	return nullptr;
+ }","This is a revert, is it really an issue?",I don't think this is the right way to do it. I think it would be better to iterate over all the instants and return the first one that matches.
+7293,"@@ -26,8 +26,7 @@ namespace OpenTelemetry.Trace
+     using OpenTelemetry.Trace.Export;
+     using OpenTelemetry.Trace.Internal;
+ 
+-    /// <inheritdoc/>
+-    public class SpanBuilder : ISpanBuilder
++    /*public class SpanBuilder 
+     {
+         private readonly SpanProcessor spanProcessor;
+         private readonly TracerConfiguration tracerConfiguration;",can we delete this file altogether?,Why remove this?
+7294,"@@ -59,7 +59,9 @@ func InitCoverage(name string) {
+ 	}
+ 
+ 	// Set up the unit test framework with the required arguments to activate test coverage.
+-	flag.CommandLine.Parse([]string{""-test.coverprofile"", tempCoveragePath()})
++	if err := flag.CommandLine.Parse([]string{""-test.coverprofile"", tempCoveragePath()}); err != nil {
++		panic(err)
++	}
+ 
+ 	// Begin periodic logging
+ 	go wait.Forever(FlushCoverage, flushInterval)",Suggestion: log some additional info here so we know where we are i.e 'Failed to prepare coverage framework..',Why panic instead of returning an error?
+7295,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace
++{
++    internal static class TracerConstants
++    {
++        public const string Language = ""dotnet"";
++    }
++}","There didn't seem to be any good place to put constants that are .NET Tracer-specific, so I created this internal static class. If there's a better place, let me know.",Is this used anywhere?
+7296,"@@ -0,0 +1,19 @@
++package config
++
++import (
++	""github.com/kubeedge/beehive/pkg/common/config""
++	""github.com/kubeedge/beehive/pkg/common/log""
++	""github.com/kubeedge/kubeedge/cloud/edgecontroller/pkg/devicecontroller/constants""
++)
++
++// UpdateDeviceStatusBuffer is the size of channel which save update device status message from edge
++var UpdateDeviceStatusBuffer int
++
++func init() {
++	if psb, err := config.CONFIG.GetValue(""devicecontroller.update-device-status-buffer"").ToInt(); err != nil {
++		UpdateDeviceStatusBuffer = constants.DefaultUpdateDeviceStatusBuffer
++	} else {
++		UpdateDeviceStatusBuffer = psb
++	}
++	log.LOGGER.Infof(""update device status buffer: %d"", UpdateDeviceStatusBuffer)
++}",Log message should be started with upper-case word.,I don't think this is the right place to put this code. It should be in `pkg/devicecontroller/devicecontroller.go`
+7297,"@@ -126,7 +126,7 @@ namespace NLog.Targets
+         /// Gets or sets the layout that renders event ID.
+         /// </summary>
+         /// <docgen category='Event Log Options' order='10' />
+-        public Layout EventId { get; set; }
++        public Layout<int> EventId { get; set; }
+ 
+         /// <summary>
+         /// Gets or sets the layout that renders event Category.",changes for example usage in this class,Should this be `Layout<string>`?
+7298,"@@ -1,4 +1,4 @@
+-define(['browser', 'css!./emby-collapse', 'registerElement', 'emby-button'], function (browser) {
++define(['browser', 'css!elements/emby-collapse/emby-collapse', 'registerElement', 'emby-button'], function (browser) {
+     'use strict';
+ 
+     var EmbyButtonPrototype = Object.create(HTMLDivElement.prototype);","I know frameworks that support current directory when loading dependencies, is this a limitation of the requirejs loader or can we fix it somehow?",Why did you change this?
+7299,"@@ -164,6 +164,10 @@ func (a *FakeWebAPI) AddApplication(ctx context.Context, req *webservice.AddAppl
+ 	return &webservice.AddApplicationResponse{}, nil
+ }
+ 
++func (a *FakeWebAPI) EnableApplication(ctx context.Context, req *webservice.EnableApplicationRequest) (*webservice.EnableApplicationResponse, error) {
++	return &webservice.EnableApplicationResponse{}, nil
++}
++
+ func (a *FakeWebAPI) DisableApplication(ctx context.Context, req *webservice.DisableApplicationRequest) (*webservice.DisableApplicationResponse, error) {
+ 	return &webservice.DisableApplicationResponse{}, nil
+ }",`ctx` is unused in EnableApplication,Why do we need this?
+7300,"@@ -139,6 +139,8 @@ static const char* generate_multi_dot_name(ast_t* ast, ast_t** def_found) {
+ 
+     default:
+     {
++      if (def == NULL)
++        return stringtab("""");
+       pony_assert(0);
+     }
+   }","@jemc , this is one change needed in `generate_multi_dot_name`. I believe this * will do no harm to working pony code: The new code was added in a place where it is throwing an assert. So no working code will get affected. * is in sync with the rest of the method: if the parent ast node has null `data`, we are supposed to return empty string. That is possible when we have expressions wrapped in braces.",Shouldn't this be `return NULL;`?
+7301,"@@ -88,6 +88,7 @@ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ 
+ import static org.apache.solr.common.params.CommonParams.SORT;
++import static org.apache.solr.common.params.QueryElevationParams.ONLY_ELEVATED_REPRESENTATIVE;
+ 
+ /**
+ ",Should not be a static import.,import static org.apache.solr.com
+7302,"@@ -288,13 +288,13 @@ func (client *APIECSClient) getCustomAttributes() []*ecs.Attribute {
+ 
+ func (client *APIECSClient) SubmitTaskStateChange(change api.TaskStateChange) error {
+ 	// Submit attachment state change
+-	if change.Attachments != nil {
++	if change.Attachment != nil {
+ 		var attachments []*ecs.AttachmentStateChange
+ 
+-		eniStatus := change.Attachments.Status.String()
++		eniStatus := change.Attachment.Status.String()
+ 		attachments = []*ecs.AttachmentStateChange{
+ 			{
+-				AttachmentArn: &change.Attachments.AttachmentArn,
++				AttachmentArn: &change.Attachment.AttachmentARN,
+ 				Status:        &eniStatus,
+ 			},
+ 		}",should we be using `aws.String` here? it seems there are a few other spots we could use `aws.String` in the `if change.Attachment != nil { ...` block.,Why is this change needed?
+7303,"@@ -66,7 +66,9 @@ function DashboardTopEarningPagesWidget( { Widget, WidgetReportZero, WidgetRepor
+ 
+ 		return {
+ 			isAdSenseLinked: select( MODULES_ANALYTICS ).getAdsenseLinked(),
+-			analyticsMainURL: select( MODULES_ANALYTICS ).getServiceURL(),
++			analyticsMainURL: select( MODULES_ANALYTICS ).getServiceReportURL( 'content-publisher-overview', {
++				'_u.date00': startDate, '_u.date01': endDate,
++			} ),
+ 			data: select( MODULES_ANALYTICS ).getReport( args ),
+ 			error: select( MODULES_ANALYTICS ).getErrorForSelector( 'getReport', [ args ] ),
+ 			loading: ! select( MODULES_ANALYTICS ).hasFinishedResolution( 'getReport', [ args ] ),","We can't pass raw dates like this because they need to be formatted as `YYYYMMDD` as noted in the IB. We added the `generateDateRangeArgs` utilities to handle this for us, as well as abstracting the relationship between arg name and specific dates which is not obvious just by looking at it. Let's update it to use `generateDateRangeArgs( { startDate, endDate } )` instead   Use care to make sure we're sourcing the utility from Analytics utils though since AdSense has its own version by the same name, which is different.",I think this should be `getServic
+7304,"@@ -313,6 +313,8 @@ class worker(Config):
+     no_install_shutdown_handler = BoolParameter(default=False,
+                                                 description='If true, the SIGUSR1 shutdown handler will'
+                                                 'NOT be install on the worker')
++    save_summary_data = BoolParameter(default=True, description='If true, save data required for '
++                                      'execution summary')
+ 
+ 
+ class KeepAliveThread(threading.Thread):",`default=True` shouldn't be used for BoolParameters iirc.,I think this should be `False` by default.
+7305,"@@ -35,6 +35,10 @@ func parsePrettyFormatLog(repo *Repository, logByts []byte) (*list.List, error)
+ }
+ 
+ func RefEndName(refStr string) string {
++	if strings.HasPrefix(refStr, ""refs/heads/"") {
++		return strings.TrimPrefix(refStr, ""refs/heads/"")
++	}
++
+ 	index := strings.LastIndex(refStr, ""/"")
+ 	if index != -1 {
+ 		return refStr[index+1:]",It would be better to use `return refStr[12:]`. or `11`... I have problem with counting..,Why do we need this?
+7306,"@@ -211,9 +211,7 @@ func ruleHash(state *core.BuildState, target *core.BuildTarget, runtime bool) []
+ 	for _, licence := range target.Licences {
+ 		h.Write([]byte(licence))
+ 	}
+-	for _, output := range target.TestOutputs {
+-		h.Write([]byte(output))
+-	}
++
+ 	for _, output := range target.OptionalOutputs {
+ 		h.Write([]byte(output))
+ 	}",Pretty sure these should only contribute to the runtime hash.,Why is this being removed?
+7307,"@@ -1,4 +1,4 @@
+-<div id=""ncr-layout"">
++<div id=""gsa18f-layout"">
+   <table class=""w-container main-container"" width='800'>
+     <tr>
+       <td>","Just verifying: this change doesn't break the 18f layout, right?",This should be `gsa18f-layout`
+7308,"@@ -120,14 +120,6 @@ func (c call) endStats(elapsed time.Duration, err error, isApplicationError bool
+ 			counter.Inc()
+ 		}
+ 		return
+-	case yarpcerrors.CodeOK:
+-		// If we got ""CodeOK"" it really means that this is not a yarpcError, in
+-		// which case this is another level of ""unknown"" error.
+-		c.edge.serverErrLatencies.Observe(elapsed)
+-		if counter, err := c.edge.serverFailures.Get(""unknown_internal_yarpc""); err == nil {
+-			counter.Inc()
+-		}
+-		return
+ 	}
+ 	// If this code is executed we've hit an error code outside the usual error
+ 	// code range, so we'll just log the string representation of that code.","we should keep this counter using the ""isYarpcError"" api",Why is this being removed?
+7309,"@@ -28,16 +28,16 @@ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.StructLike;
+ import org.apache.iceberg.relocated.com.google.common.base.Objects;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+-import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+ import org.apache.iceberg.types.Types;
+ import org.apache.iceberg.types.Types.StructType;
++import org.apache.iceberg.util.CaseInsensitiveMap;
+ 
+ public class GenericRecord implements Record, StructLike {
+   private static final LoadingCache<StructType, Map<String, Integer>> NAME_MAP_CACHE =
+       Caffeine.newBuilder()
+       .weakKeys()
+       .build(struct -> {
+-        Map<String, Integer> idToPos = Maps.newHashMap();
++        Map<String, Integer> idToPos = new CaseInsensitiveMap<>();
+         List<Types.NestedField> fields = struct.fields();
+         for (int i = 0; i < fields.size(); i += 1) {
+           idToPos.put(fields.get(i).name(), i);","Could we just use case insensitive strings as keys instead of creating a new map implementation? e.g. simply using a treemap with a comparator `Map<String, Integer> idToPos = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);` could work I think",Why is this change needed?
+7310,"@@ -67,7 +67,14 @@ namespace OpenTelemetry.Context
+         /// <returns>The slot previously registered.</returns>
+         public static RuntimeContextSlot<T> GetSlot<T>(string name)
+         {
+-            return (RuntimeContextSlot<T>)Slots[name];
++            if (Slots.TryGetValue(name, out var slot) && slot is RuntimeContextSlot<T> expectedSlot)
++            {
++                return expectedSlot;
++            }
++            else
++            {
++                return null;
++            }
+         }
+ 
+         /*",I think this should be a throw. Or the method should be TryGetSlot?,Why not just `return slot;
+7311,"@@ -3991,7 +3991,15 @@ int LuaScriptInterface::luaGameLoadMap(lua_State* L)
+ {
+ 	// Game.loadMap(path)
+ 	const std::string& path = getString(L, 1);
+-	g_dispatcher.addTask(createTask(std::bind(&Game::loadMap, &g_game, path)));
++	g_dispatcher.addTask(createTask( [path]() {
++		try {
++			g_game.loadMap(path);
++		} catch (const std::exception& e) {
++			// FIXME: Should only catch some exceptions
++			std::cout << ""[Error - LuaScriptInterface::luaGameLoadMap] Failed to load map: ""
++				<< e.what() << std::endl;
++		}
++	}));
+ 	return 0;
+ }
+ ","We don't usually put spaces between ( and [, and I think `path` should be passed by reference.",I'm not sure if this is th
+7312,"@@ -419,12 +419,11 @@ int Zone::SaveTempItem(uint32 merchantid, uint32 npcid, uint32 item, int32 charg
+ 				if (!ml.origslot) {
+ 					ml.origslot = ml.slot;
+ 				}
+-
+-				if (charges > 0) {
++				bool IsStackable = database.GetItem(item)->Stackable;
++				if ((IsStackable && charges > 0) || (!IsStackable && sold)) {
+ 					database.SaveMerchantTemp(npcid, ml.origslot, item, ml.charges);
+ 					tmp_merlist.push_back(ml);
+-				}
+-				else {
++				} else {
+ 					database.DeleteMerchantTemp(npcid, ml.origslot);
+ 				}
+ 			}",Make sure to `snake_case` locally scoped variable names in the future,"I don't think this is correct. If the item is not stackable, it should not be saved."
+7313,"@@ -56,6 +56,7 @@ type LogsConfig struct {
+ // RoutingRule holds the path to route requests to the service.
+ type RoutingRule struct {
+ 	Path string `yaml:""path""`
++	HealthCheckPath string `yaml:""healthcheck""`
+ }
+ 
+ // AutoScalingConfig is the configuration to scale the service with target tracking scaling policies.",Maybe we should use underscores like `health_check` - what do you think?,Why do we need this?
+7314,"@@ -139,6 +139,12 @@ func (v *volumeAPIOpsV1alpha1) read(volumeName string) (*v1alpha1.CASVolume, err
+ 		vol.Namespace = hdrNS
+ 	}
+ 
++	// use sc name from header if present
++	scName := v.req.Header.Get(string(v1alpha1.StorageClassKey))
++	if scName != """" {
++		vol.Annotations[string(v1alpha1.StorageClassKey)] = scName
++	}
++
+ 	vOps, err := volume.NewVolumeOperation(vol)
+ 	if err != nil {
+ 		return nil, CodedError(400, err.Error())",Do a TrimSpace before setting.,I don't think we need to set the annotation if it's not present.
+7315,"@@ -41,6 +41,9 @@ type ENI struct {
+ 
+ 	// PrivateDNSName is the dns name assigned by the vpc to this eni
+ 	PrivateDNSName string `json:"",omitempty""`
++	// SubnetGatewayIPV4Address is the address to the subnet gateway for
++	// the eni
++	SubnetGatewayIPV4Address string `json:"",omitempty""`
+ }
+ 
+ // GetIPV4Addresses returns a list of ipv4 addresses allocated to the ENI","Are the fields in this struct grouped by IP address family or by function? There are separate fields for IPv4Addresses and IPv6Addresses, but a single field for DomainNameServers. Should this new field be named SubnetGatewayAddress with type array consisting of both IPv4 and IPv6 gateways?",Why do we need this field? Isn't it enough to just use `SubnetGateway`?
+7316,"@@ -38,7 +38,7 @@ class LinkTest < ActiveSupport::TestCase
+       new_link.revive_or_create
+     end
+ 
+-    deleted_link = Link.find(link)
++    deleted_link = Link.where(id: link.id).first
+     deleted_link.title.must_equal new_title
+     deleted_link.link_category_id.must_equal Link::CATEGORIES[:Forums]
+   end",.find(id) is being deprecated to Rails 5.,Use 2 (not 1) spaces for indentation.
+7317,"@@ -4,6 +4,9 @@ import datetime
+ from itertools import product
+ 
+ import iris
++from iris.coords import DimCoord
++from iris.cube import CubeList
++from iris.experimental.equalise_cubes import equalise_attributes
+ from iris.util import guess_coord_axis
+ 
+ import numpy as np",Will be good to have the iris interface moved to geoviews. Could this be done for 1.10.6?,F401 'iris.experimental.equalise_cube
+7318,"@@ -152,7 +152,10 @@ func (cs *ClientServerImpl) Connect() error {
+ 	request, _ := http.NewRequest(""GET"", parsedURL.String(), nil)
+ 
+ 	// Sign the request; we'll send its headers via the websocket client which includes the signature
+-	utils.SignHTTPRequest(request, cs.AgentConfig.AWSRegion, ServiceName, cs.CredentialProvider, nil)
++	err = utils.SignHTTPRequest(request, cs.AgentConfig.AWSRegion, ServiceName, cs.CredentialProvider, nil)
++	if err != nil {
++		return err
++	}
+ 
+ 	timeoutDialer := &net.Dialer{Timeout: wsConnectTimeout}
+ 	tlsConfig := &tls.Config{ServerName: parsedURL.Host, InsecureSkipVerify: cs.AgentConfig.AcceptInsecureCert}",does this get wrapped in the calling method?,I think this should be `return err`
+7319,"@@ -195,6 +195,8 @@ class DictAuth(unittest.TestCase):
+             subprocess.check_output(
+                 store_cmd, encoding=""utf-8"", errors=""ignore"")
+ 
++    # TODO: This test should not test case-insensivity, only the successful
++    # group authorization. The permission tests should do that.
+     def test_group_auth(self):
+         """"""
+         Test for case insensitive group comparison at authorization.","Do we still need this test case? If your new test cases test this, then we can remove it.",This test should not test case insens
+7320,"@@ -641,6 +641,15 @@ class Plan < ActiveRecord::Base
+     User.joins(:roles).where('roles.plan_id = ? AND roles.access IN (?)', self.id, vals).first
+   end
+ 
++  ##
++  # returns the shared roles of a plan, excluding the creator
++  def shared
++    role_values = Role.access_values_for(:commenter)
++                      .concat(Role.access_values_for(:editor))
++                      .concat(Role.access_values_for(:administrator)).uniq! - Role.access_values_for(:creator)
++    Role.where(plan: self, access: role_values)
++  end
++
+   ##
+   # the owner and co-owners of the project
+   #","If you want to express ""any role that is not creator"" you could use the following statement: Role.where(plan: self).where(Role.not_creator_condition).any? which would be less verbose and a bit more efficient if it is used for Yes/No shared?",Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body beginning.
+7321,"@@ -188,14 +188,12 @@ func migrateJSONFile(from, to string) (bool, error) {
+ 		if len(chain) == 0 {
+ 			return nil, nil
+ 		}
+-		// The chain is in one of three states:
++		// The chain is in one of two states:
+ 		// 1) single self-signed cert
+-		// 2) single upstream-signed cert, implying upstream_bundle=false
+-		// 3) an upstream-signed cert followed by any intermediates and a root
++		// 2) an upstream-signed cert followed by any intermediates and a root
+ 		//
+-		// The ca should only be considered an ""intermediate"" in case #3, so a
+-		// check for more than one cert should be sufficient for that. However
+-		// we don't want the the root in the chain anymore, so remove it.
++		// In the case where the CA is an intermediate, we don't want to store
++		// the root, so remove it.
+ 		certificate := chain[0].Raw
+ 		var upstreamChain [][]byte
+ 		if len(chain) > 1 {",Do we need any update on the test side?,"nit: ""In the case where the CA is an intermediate"""
+7322,"@@ -4663,6 +4663,10 @@ func (fbo *folderBranchOps) notifyOneOpLocked(ctx context.Context,
+ 			return nil
+ 		}
+ 	}
++	// Cancel any block prefetches for unreferenced blocks.
++	for _, ptr := range op.Unrefs() {
++		fbo.config.BlockOps().Prefetcher().CancelPrefetch(ptr.ID)
++	}
+ 
+ 	fbo.observers.batchChanges(ctx, changes)
+ 	return nil",There's a few `return nil` cases above this -- we should probably move this above the big switch.,Why do we need to cancel prefetches here?
+7323,"@@ -33,6 +33,19 @@ func (tile TransactionInLedgerError) Error() string {
+ 	return fmt.Sprintf(""transaction already in ledger: %v"", tile.Txid)
+ }
+ 
++// LeaseInLedgerError is returned when a transaction cannot be added because it has a lease that already being used in the relavant rounds
++type LeaseInLedgerError struct {
++	txid  transactions.Txid
++	lease txlease
++}
++
++// Error implements the error interface for the LeaseInLedgerError stuct
++func (lile LeaseInLedgerError) Error() string {
++	// format the lease as address.
++	addr := basics.Address(lile.lease.lease)
++	return fmt.Sprintf(""transaction %v using an overlapping lease %s"", lile.txid, addr.String())
++}
++
+ // BlockInLedgerError is returned when a block cannot be added because it has already been done
+ type BlockInLedgerError struct {
+ 	LastRound basics.Round",`lile *LeaseInLedgerError` to reduce copying?,nit: typo `stuct`
+7324,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent,Why do we need this?
+7325,"@@ -35,9 +35,9 @@ namespace Microsoft.VisualStudio.TestPlatform.Utilities.Helpers
+         }
+ 
+         /// <inheritdoc/>
+-        public Stream GetStream(string filePath, FileMode mode)
++        public Stream GetStream(string filePath, FileMode mode, FileAccess access = FileAccess.ReadWrite)
+         {
+-            return new FileStream(filePath, mode);
++            return new FileStream(filePath, mode, access);
+         }
+ 
+         /// <inheritdoc/>","We don't have a requirement anywhere in Test Platform for GetStream() with write access. It is ok to directly change `return new FileStream(filePath, mode, FileAccess.Read)`.",Why do we need to ch
+7326,"@@ -22,12 +22,17 @@
+ import os
+ import os.path
+ import textwrap
++import string
++import functools
++import operator
+ 
+ import attr
+ import yaml
+ import pytest
+ import bs4
+ 
++import qutebrowser.browser.hints
++
+ 
+ def collect_tests():
+     basedir = os.path.dirname(__file__)",FWIW `from qutebrowser.browser import hints` is okay - it's just things like `from qutebrowser.browser.hints import HintManager` I try to avoid.,Why do we need this 
+7327,"@@ -11,7 +11,12 @@
+ namespace HFG;
+ 
+ use HFG\Core\Builder\Header as HeaderBuilder;
++
++$transparent_header_class = '';
++if ( get_theme_mod( 'neve_transparent_header', false ) ) {
++	$transparent_header_class = ' neve-tansparent-header';
++}
+ ?>
+-<div id=""header-grid""  class=""<?php echo esc_attr( get_builder( HeaderBuilder::BUILDER_NAME )->get_property( 'panel' ) ); ?> site-header"">
++<div id=""header-grid""  class=""<?php echo esc_attr( get_builder( HeaderBuilder::BUILDER_NAME )->get_property( 'panel' ) ) . esc_attr( $transparent_header_class ); ?> site-header"">
+ 	<?php render_builder( HeaderBuilder::BUILDER_NAME ); ?>
+ </div>","@preda-bogdan let's use a filter for the header classes, something like, hfg_header_classes where we hook this logic, in neve pro",This should be `neve
+7328,"@@ -21,7 +21,7 @@ import (
+ 	""time""
+ 
+ 	""github.com/containernetworking/plugins/pkg/ip""
+-	""k8s.io/api/core/v1""
++	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/labels""
+ 	""k8s.io/apimachinery/pkg/util/wait""
+ 	""k8s.io/client-go/informers""",Out of curiosity.. is there a rule to determine the package name as prevDirectory+currentDirectory.,Why is this needed?
+7329,"@@ -53,7 +53,9 @@ get_xmm_vals(priv_mcontext_t *mc)
+ #ifdef X86
+     if (preserve_xmm_caller_saved()) {
+         ASSERT(proc_has_feature(FEATURE_SSE));
+-        if (YMM_ENABLED())
++        if (ZMM_ENABLED())
++            get_zmm_caller_saved(&mc->simd[0]);
++        else if (YMM_ENABLED())
+             get_ymm_caller_saved(&mc->simd[0]);
+         else
+             get_xmm_caller_saved(&mc->simd[0]);",It seems this needs to check the lazy cxt switching flag. It is used on the initial thread for early injection and in other places where the lazy switch should apply.,This should be `els
+7330,"@@ -21,9 +21,10 @@ import { isValidPropertyID } from './validation';
+ /**
+  * Parses the bits of a valid property ID into an object of its components.
+  *
++ * See: https://support.google.com/analytics/answer/7372977.
++ *
+  * @since 1.8.0
+  *
+- * @see {@link https://support.google.com/analytics/answer/7372977}
+  * @param {string} propertyID Property ID to parse.
+  * @return {(Object|undefined)} Object of property ID components if valid, otherwise false.
+  */",Why not use the JSdoc annotation as it did before?,This should be 1.8.
+7331,"@@ -108,7 +108,11 @@ public class ParseUtil {
+     String version = packageImplementationVersion;
+     String edition = ProcessEngineDetails.EDITION_COMMUNITY;
+ 
+-    if (version != null && version.contains(""-ee"")) {
++    if (version == null){
++      version = ProductPropertiesUtil.getProductVersion();
++    }
++
++    if (version.contains(""-ee"")) {
+       edition = ProcessEngineDetails.EDITION_ENTERPRISE;
+       if (trimSuffixEE) {
+         version = version.replace(""-ee"", """"); // trim `-ee` suffix",Why don't we drop the packageImplementationVersion in general? That way the version will be fetch all that time only from the properties file and it will be consistent.,`if (version == nul
+7332,"@@ -1076,6 +1076,9 @@ class CppGenerator : public BaseGenerator {
+       code_ += ""  };"";
+     }
+ 
++    // Found fields with union type.
++    std::vector<const FieldDef*> union_fields;
++
+     // Generate the accessors.
+     for (auto it = struct_def.fields.vec.begin();
+          it != struct_def.fields.vec.end(); ++it) {","Please use the style of the rest of the code, a space between the type and `*`",Why do we need this?
+7333,"@@ -25,6 +25,8 @@ namespace Microsoft.TestPlatform.VsTestConsole.TranslationLayer.UnitTests
+ 
+         private MockProcessManager mockProcessManager;
+ 
++        
++
+         [TestInitialize]
+         public void TestInit()
+         {",nit: remove extra blank lines.,Why is this needed?
+7334,"@@ -39,6 +39,7 @@ const (
+ 	appEnvOptionNone      = ""None (run in default VPC)""
+ 	defaultDockerfilePath = ""Dockerfile""
+ 	imageTagLatest        = ""latest""
++	taskGroupNameDefault  = ""copilot-task""
+ )
+ 
+ const (",nit: What do you think of `copilot-task-group`?,I think this should 
+7335,"@@ -156,6 +156,7 @@ export function setProperty(dom, name, value, oldValue, isSvg) {
+  */
+ function eventProxy(e) {
+ 	this._listeners[e.type + false](options.event ? options.event(e) : e);
++	if (e.type === 'input' || e.type === 'change') this.value = this._prevValue || '';
+ }
+ 
+ function eventProxyCapture(e) {",We should check whether or not the input node has a value since we can just have an onChange on an uncontrolled component as well.,Why do we need this?
+7336,"@@ -13,7 +13,7 @@ how the API has changed as well as the range of API versions supported by this b
+ """"""
+ 
+ CURRENT = (buildVersion.version_year, buildVersion.version_major, buildVersion.version_minor)
+-BACK_COMPAT_TO = (2019, 3, 0)
++BACK_COMPAT_TO = (2021, 1, 0)
+ """"""
+ As BACK_COMPAT_TO is incremented, the changed / removed parts / or reasoning should be added below.
+ EG: (x, y, z): Large changes to speech.py",I think there should be some reasoning below this line about the version updating.,Why did you change this?
+7337,"@@ -371,6 +371,17 @@ static int on_body(h2o_http1client_t *client, const char *errstr)
+     return 0;
+ }
+ 
++static char compress_hint_to_enum(const char *val, size_t len)
++{
++    if (!strncasecmp(""ON"", val, len)) {
++        return H2O_COMPRESS_HINT_ENABLE;
++    }
++    if (!strncasecmp(""OFF"", val, len)) {
++        return H2O_COMPRESS_HINT_DISABLE;
++    }
++    return H2O_COMPRESS_HINT_AUTO;
++}
++
+ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *errstr, int minor_version, int status,
+                                        h2o_iovec_t msg, h2o_http1client_header_t *headers, size_t num_headers)
+ {","Please use `h2o_lcstris` instead of `strncasecmp` so that the comparison would be a complete match (instead of a prefix match; current code would yield true if [val,len] is [""O"", 1]) and that it would be locale-independent.",Please use `strncasecmp`
+7338,"@@ -333,7 +333,13 @@ var _ fbmHelper = (*folderBranchOps)(nil)
+ // newFolderBranchOps constructs a new folderBranchOps object.
+ func newFolderBranchOps(config Config, fb FolderBranch,
+ 	bType branchType) *folderBranchOps {
+-	nodeCache := newNodeCacheStandard(fb)
++	var nodeCache NodeCache
++	if config.Mode() != InitMinimal {
++		nodeCache = newNodeCacheStandard(fb)
++	} else {
++		// If we're in minimal mode, let the block cache remain nil to
++		// ensure that the user doesn't try any data reads or writes.
++	}
+ 
+ 	// make logger
+ 	branchSuffix := """"",I prefer if possible for `if`/`else` statements to have the positive case first.,I'm not sure if this is 
+7339,"@@ -33,9 +33,18 @@ from scapy.base_classes import BasePacketList
+ ## Tools ##
+ ###########
+ 
++def issubtype(x, t):
++    """"""issubtype(C, B) -> bool
++
++    Return whether C is a class and if it is a subclass of class B.
++    When using a tuple as the second argument issubtype(X, (A, B, ...)),
++    is a shortcut for issubtype(X, A) or issubtype(X, B) or ... (etc.).
++    """"""
++    return isinstance(x, type) and issubclass(x, t)
++
+ def get_temp_file(keep=False, autoext=""""):
+     """"""Create a temporary file and return its name. When keep is False,
+-the file is deleted when scapy exits.
++    the file is deleted when scapy exits.
+ 
+     """"""
+     fname = tempfile.NamedTemporaryFile(prefix=""scapy"", suffix=autoext,",Docstring would be nice,I think it would be bett
+7340,"@@ -23,6 +23,7 @@ import org.gradle.api.provider.ListProperty;
+ public class BaselineErrorProneExtension {
+     private static final ImmutableList<String> DEFAULT_PATCH_CHECKS = ImmutableList.of(
+             // Baseline checks
++            ""CatchBlockLogException"",
+             ""ExecutorSubmitRunnableFutureIgnored"",
+             ""LambdaMethodReference"",
+             ""OptionalOrElseMethodInvocation"",",Low risk to fix this by default because existing baseline consumers pass this check. We don't attempt to fix checks that have been opted out of.,Why do we need this?
+7341,"@@ -77,7 +77,16 @@ void OpenMPTargetInternal::impl_finalize() {
+     Kokkos::kokkos_free<Kokkos::Experimental::OpenMPTargetSpace>(
+         space.m_uniquetoken_ptr);
+ }
+-void OpenMPTargetInternal::impl_initialize() { m_is_initialized = true; }
++void OpenMPTargetInternal::impl_initialize() {
++  m_is_initialized = true;
++
++  // FIXME_OPENMPTARGET:  Only fix the number of teams for NVIDIA architectures.
++#if defined(KOKKOS_ARCH_VOLTA70) || defined(KOKKOS_ARCH_PASCAL60)
++#if defined(KOKKOS_COMPILER_CLANG) && (KOKKOS_COMPILER_CLANG >= 1300)
++  omp_set_num_teams(512);
++#endif
++#endif
++}
+ int OpenMPTargetInternal::impl_is_initialized() {
+   return m_is_initialized ? 1 : 0;
+ }","What about `VOLTA72`, `TURING75`, `AMPERE80` and `AMPERE86`? We only want to set the number of teams for these two architectures or for all the architectures newer than Maxwell?",Why is this needed?
+7342,"@@ -1,7 +1,7 @@
+ # model settings
+ model = dict(
+     type='FasterRCNN',
+-    pretrained='modelzoo://resnet50',
++    pretrained='torchvision://resnet50',
+     backbone=dict(
+         type='ResNet',
+         depth=50,","Since we have specified `load_from`, `pretrained` can be left None.",Why did you change t
+7343,"@@ -71,6 +71,9 @@ func logParse(c *caddy.Controller) ([]*Rule, error) {
+ 				},
+ 				Format: DefaultLogFormat,
+ 			})
++		} else if len(args) > 3 {
++			// Maxiumum number of args in log directive is 3.
++			return nil, c.ArgErr()
+ 		} else {
+ 			// Path scope, output file, and maybe a format specified
+ ",I prefer to translate these `else if` into `switch` for more readability.,I don't think we nee
+7344,"@@ -3,12 +3,13 @@ class Api::V1::StatusesController < ApiController
+ 
+   def create
+     exercise.statuses.create!(user: resource_owner, state: params[:state])
++    exercise.update_trails_state_for(resource_owner)
+     render nothing: true
+   end
+ 
+   private
+ 
+   def exercise
+-    Exercise.find_by!(uuid: params[:exercise_uuid])
++    @exercise ||= Exercise.find_by!(uuid: params[:exercise_uuid])
+   end
+ end",This can also be a local variable in `create`.,Why is this necessary?
+7345,"@@ -1273,6 +1273,19 @@ func updateRepository(e Engine, repo *Repository, visibilityChanged bool) (err e
+ 			}
+ 		}
+ 
++		// Create/Remove git-daemon-export-ok for git-daemon...
++		daemonExportFile := strings.Join([]string{repo.RepoPath(), `git-daemon-export-ok`}, ""/"")
++		if repo.IsPrivate {
++			// NOTE: Gogs doesn't actually care about this file so we don't do any error-checking :D
++			os.Remove(daemonExportFile)
++		} else {
++			// NOTE: Gogs only cares to check errors so we don't get other errors by closing a file that isn't open...
++			f, err := os.Create(daemonExportFile)
++			if err == nil {
++				f.Close()
++			}
++		}
++
+ 		forkRepos, err := getRepositoriesByForkID(e, repo.ID)
+ 		if err != nil {
+ 			return fmt.Errorf(""getRepositoriesByForkID: %v"", err)",Why not use `path.Join`?,I don't think this is 
+7346,"@@ -7,4 +7,8 @@ if ( typeof global.googlesitekit === 'undefined' ) {
+ 	global.googlesitekit = {};
+ }
+ 
+-global.googlesitekit.api = API;
++if ( typeof global.googlesitekit.api === 'undefined' ) {
++	global.googlesitekit.api = API;
++}
++
++export * from 'assets/js/googlesitekit/api';",Why not `export default API` instead? This ensures we export the same that we export on the global.,This should be `import
+7347,"@@ -552,7 +552,7 @@ def imread(filename, pixel_type=None, fallback_only=False):
+         increase_dimension=False
+         kwargs={'FileName':filename}
+     if pixel_type:
+-        imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.ReadMode)
++        imageIO = itk.ImageIOFactory.CreateImageIO(io_filename, itk.ImageIOFactory.FileModeType_ReadMode)
+         if not imageIO:
+             raise RuntimeError(""No ImageIO is registered to handle the given file."")
+         imageIO.SetFileName(io_filename)",This is a good change I think. It greatly helps reduce name conflicts.,Why did you change thi
+7348,"@@ -46,6 +46,12 @@ type jetStreamCluster struct {
+ 	consumerResults *subscription
+ }
+ 
++// Used to guide placement of streams in clustered JetStream.
++type Placement struct {
++	Cluster string   `json:""cluster""`
++	Tags    []string `json:""tags,omitempty""`
++}
++
+ // Define types of the entry.
+ type entryOp uint8
+ ","cluster not having omitempty, does this imply that cluster is required? seems empty is valid so just checking",Why do we need this?
+7349,"@@ -758,3 +758,19 @@ func (c *Container) ShouldCreateWithSSMSecret() bool {
+ 	}
+ 	return false
+ }
++
++// MergeEnvironmentVariables appends additional envVarName:envVarValue pairs to
++// the the container's enviornment values structure
++func (c *Container) MergeEnvironmentVariables(secrets map[string]string) {
++	c.lock.Lock()
++	defer c.lock.Unlock()
++
++	// don't assume that the environment variable map has been initialized by others
++	if c.Environment == nil {
++		c.Environment = make(map[string]string)
++	}
++
++	for k, v := range secrets {
++		c.Environment[k] = v
++	}
++}","@aws/aws-ecs-agent, @yumex93: how concerned should we be about user provided envvar names clobbering existing envvars? i'm not convinced we should be doing additional validation here.",I'm not sure if this
+7350,"@@ -0,0 +1,14 @@
++'use strict';
++
++function defineAspects(operation, aspects) {
++  aspects = new Set(aspects);
++  Object.defineProperty(operation, 'aspects', {
++    value: aspects,
++    writable: false
++  });
++  return aspects;
++}
++
++module.exports = {
++  defineAspects
++};","nit: aspects are defined in `OperationBase`, should `defineAspects` live there as well?",Why do we need this?
+7351,"@@ -5,12 +5,15 @@ from collections import OrderedDict
+ 
+ from kinto.core.permission import PermissionBase
+ from kinto.core.storage.postgresql.client import create_from_config
++from kinto.core.storage.postgresql.migrator import Migrator
+ 
+ 
+ logger = logging.getLogger(__name__)
+ 
++HERE = os.path.abspath(os.path.dirname(__file__))
+ 
+-class Permission(PermissionBase):
++
++class Permission(PermissionBase, Migrator):
+     """"""Permission backend using PostgreSQL.
+ 
+     Enable in configuration::",Why the `os.path.abspath`? `os.path.dirname` should always give a valid directory path.,Why do we need this?
+7352,"@@ -143,4 +143,8 @@ public class ControllerConfiguration {
+                 settingsConfiguration.settingsManager()
+         );
+     }
++
++    public String getWineEnginesPath() {
++        return this.wineEnginesPath;
++    }
+ }",I think we should not consider special engine types on this level. I would prefer to build the specific engine path based on `application.user.engines` later on.,Why do we need this method?
+7353,"@@ -78,6 +78,12 @@ bool IndexPolicyMaker::buildPolicy() {
+         if (exist == scanItems_.end()) {
+             break;
+         }
++        // Stop build policy when last operator is range scan,
++        // And other fields will use expression filtering.
++        auto it = scanItems_.rbegin()->second;
++        if (it.endBound_.rel_ != RelationType::kEQRel) {
++            break;
++        }
+     }
+     // re-check operatorList_.
+     // if operatorList_ is not empty, that means there are still fields to filter",Is `rbegin` correct? We can't make sure that the last index column is the `rbegin` of `scanItems`.,nit: `if (it.endBound_.rel_
+7354,"@@ -108,6 +108,8 @@ func main() {
+ 		glog.Fatalln(""EVM Network ID is not set, call config.New() first"")
+ 	}
+ 
++	config.SetChainID(cfg.Chain.ID)
++
+ 	cfg.Genesis = genesisCfg
+ 	cfgToLog := cfg
+ 	cfgToLog.Chain.ProducerPrivKey = """"","check it is != 0, just like `EVMNetworkID` above",Why do we need this?
+7355,"@@ -186,6 +186,8 @@ namespace OpenTelemetry
+             this.shutdownDrainTarget = this.circularBuffer.AddedCount;
+             this.shutdownTrigger.Set();
+ 
++            OpenTelemetrySdkEventSource.Log.DroppedExportProcessorItems(nameof(BatchExportProcessor<T>), typeof(T).Name, this.exporter.GetType().Name, this.droppedCount);
++
+             if (timeoutMilliseconds == Timeout.Infinite)
+             {
+                 this.exporterThread.Join();","if you just do ""this.GetType().Name"" and ""this.exporter.GetType().Name"", we get what we need.",nit: `typeof(T).Name` -> `t
+7356,"@@ -26,16 +26,13 @@
+  */
+ package com.salesforce.androidsdk.rest;
+ 
+-import com.salesforce.androidsdk.R;
+-import com.salesforce.androidsdk.app.SalesforceSDKManager;
+  
+ /**
+  * This is where all the API version info lives. This allows us to change one
+  * line here and affect all our api calls.
+  */
+ public class ApiVersionStrings {
+-    public static final String VERSION_NUMBER = SalesforceSDKManager.getInstance().
+-    		getAppContext().getResources().getString(R.string.api_version);
++    public static final String VERSION_NUMBER = ""v29.0"";
+     public static final String API_PREFIX = ""/services/data/"";
+     public static final String BASE_PATH = API_PREFIX + VERSION_NUMBER;
+     public static final String BASE_CHATTER_PATH = BASE_PATH + ""/chatter/"";","That's the code that would prevent any SalesforceSDKTest from running. At class loading time, SalesforceSDKManager.getInstance() would throw a RuntimeException because init() had never been called.",Why do we need to change this?
+7357,"@@ -34,4 +34,6 @@ public interface DefinitionConst {
+   String VERSION_RULE_LATEST = ""latest"";
+ 
+   String VERSION_RULE_ALL = ""0.0.0+"";
++
++  String DEFAULT_REVISION = ""0"";
+ }","there is no ""DEFAULT_REVISION"" logic, no need to define this.",This should be `0.0.0+`.
+7358,"@@ -289,6 +289,9 @@ public class SalesforceSDKManager {
+                 loginOptions = new LoginOptions(url, getPasscodeHash(), config.getOauthRedirectURI(),
+                         config.getRemoteAccessConsumerKey(), config.getOauthScopes(), null, jwt);
+             }
++        } else {
++            loginOptions.setJwt(jwt);
++            loginOptions.setUrl(url);
+         }
+         return loginOptions;
+     }","so this is to fix a scenario where the app is first launched normally, then background and foreground through the link, we are not updating loginOption",Why is this needed?
+7359,"@@ -322,6 +322,14 @@ class Application extends BaseApplication {
+ 		});
+ 	}
+ 
++	checkLayout(layout) {
++		if (layout === 'viewer') {
++			this.focusElement_('noteTextViewer');
++		} else {
++			this.focusElement_('noteBody');
++		}
++	}
++
+ 	async updateMenu(screen) {
+ 		if (this.lastMenuScreen_ === screen) return;
+ ","It doesn't seem like the right way to implement this, because you add a new element that doesn't really exist (noteTextViewer). Instead you should modify the command handler `if (command.name === 'focusElement' && command.target === 'noteBody') {` in NoteText.jsx. Then focus either the editor or the viewer depending on what's currently visible.",Why do we need this?
+7360,"@@ -21,7 +21,12 @@ package org.apache.iceberg.avro;
+ 
+ import com.google.common.base.Preconditions;
+ import com.google.common.collect.Lists;
++
++import java.util.HashSet;
++import java.util.LinkedList;
+ import java.util.List;
++import java.util.Set;
++
+ import org.apache.avro.LogicalType;
+ import org.apache.avro.LogicalTypes;
+ import org.apache.avro.Schema;",We don't add blank lines in imports.,Why is this needed?
+7361,"@@ -1,7 +1,7 @@
+ # -*- coding: UTF-8 -*-
+ #addonHandler.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2012-2018 Rui Batista, NV Access Limited, Noelia Ruiz Martínez, Joseph Lee, Babbage B.V.
++#Copyright (C) 2012-2019 Rui Batista, NV Access Limited, Noelia Ruiz Martínez, Joseph Lee, Babbage B.V.
+ #This file is covered by the GNU General Public License.
+ #See the file COPYING for more details.
+ ",Please add your name to the copyright list.,Why are you changin
+7362,"@@ -243,6 +243,11 @@ func (r *replacer) getSubstitution(key string) string {
+ 	case ""{path_escaped}"":
+ 		u, _ := r.request.Context().Value(OriginalURLCtxKey).(url.URL)
+ 		return url.QueryEscape(u.Path)
++	case ""{request_id}"":
++		reqid, _ := r.request.Context().Value(RequestIDCtxKey).(string)
++		if reqid != """" {
++			return reqid
++		}
+ 	case ""{rewrite_path}"":
+ 		return r.request.URL.Path
+ 	case ""{rewrite_path_escaped}"":","You can elide the `if` check for empty string, because if it's not a value that is set, the string will be empty anyway.",I don't think we ne
+7363,"@@ -1,8 +1,8 @@
+ /*global countlyVue, CV, countlyCommon, Promise, moment*/
+ (function(countlyPushNotification) {
+ 
+-    var messagesSentLabel = CV.i18n('push-notification.time-chart-serie-messages-sent');
+-    var actionsPerformedLabel = CV.i18n('push-notification.time-chart-serie-actions-performed');
++    var messagesSentLabel = CV.i18n('push-notification.messages-sent-serie-name');
++    var actionsPerformedLabel = CV.i18n('push-notification.actions-performed-serie-name');
+ 
+     var StatusFinderHelper = {
+         STATUS_SHIFT_OPERATOR_ENUM: {",Different i18n keys. By mistake or on purpose?,I don't think we sh
+7364,"@@ -59,3 +59,18 @@ type SecretKeySelector struct {
+ const (
+ 	TLSCAKey = ""ca.crt""
+ )
++
++// Describes how the ACME challenge self check behaves when it fails.
++type ACMESelfCheckFailurePolicy string
++
++const (
++	// The default failure policy. This policy will cause the request to be
++	// sent to the certificate provider ONLY if the ACME challenge self check
++	// succeeds. The request is retried continuously and the `Certificate` will
++	// remain `Pending` indefinitely.
++	ACMESelfCheckFailurePolicyRetryForever ACMESelfCheckFailurePolicy = ""RetryForever""
++
++	// This policy will cause the ACME challenge self check response to be
++	// ignored and the request will always be sent to the certificate provider.
++	ACMESelfCheckFailurePolicyIgnore ACMESelfCheckFailurePolicy = ""Ignore""
++)","Given the description for this is `// Describes how the ACME challenge self check behaves when it fails.`, perhaps `RetryForever` is better terminology here as when the check fails, we don't just wait, we retry periodically.",I think this should be `ACMESelfCheckFailurePolicyRetry`
+7365,"@@ -187,14 +187,14 @@ _ostree_gpg_verifier_check_signature (OstreeGpgVerifier  *self,
+           gpg_error = gpgme_data_new_from_fd (&kdata, fd);
+           if (gpg_error != GPG_ERR_NO_ERROR)
+             {
+-              ot_gpgme_error_to_gio_error (gpg_error, error);
++              ot_gpgme_throw (gpg_error, error, ""Loading data from fd %i"", fd);
+               goto out;
+             }
+ 
+           gpg_error = gpgme_op_import (result->context, kdata);
+           if (gpg_error != GPG_ERR_NO_ERROR)
+             {
+-              ot_gpgme_error_to_gio_error (gpg_error, error);
++              ot_gpgme_throw (gpg_error, error, ""import"");
+               goto out;
+             }
+         }",Nit: let's add a more descriptive prefix in line with the other ones? E.g. `Unable to import key` ?,"`ot_gpgme_throw (gpg_error, error, ""Loading data from fd"
+7366,"@@ -13,6 +13,7 @@ describe Bolt::SSH do
+   let(:user) { ENV['BOLT_SSH_USER'] || ""vagrant"" }
+   let(:password) { ENV['BOLT_SSH_PASSWORD'] || ""vagrant"" }
+   let(:port) { ENV['BOLT_SSH_PORT'] || 2224 }
++  let(:key) { ENV['BOLT_SSH_KEY'] || Dir["".vagrant/**/private_key""] }
+   let(:command) { ""pwd"" }
+   let(:ssh) { Bolt::SSH.new(hostname, port, user, password) }
+   let(:insecure) { { config: Bolt::Config.new(insecure: true) } }",This looks like it will pass an array as `:key` in the default case. That doesn't reflect how this will actually work in practice.,"This should be `Dir["".vagrant/**/private_key""]`"
+7367,"@@ -0,0 +1,11 @@
++#if NETFRAMEWORK
++namespace Datadog.Trace.IntegrationTests
++{
++    public static class Program
++    {
++        public static void Main()
++        {
++        }
++    }
++}
++#endif",Do we need this?,Why is this needed?
+7368,"@@ -282,6 +282,11 @@ func (b *ofFlowBuilder) MatchConjID(value uint32) FlowBuilder {
+ 	return b
+ }
+ 
++func (b *ofFlowBuilder) MatchPriority(priority uint16) FlowBuilder {
++	b.Match.Priority = priority
++	return b
++}
++
+ // MatchProtocol adds match condition for matching protocol type.
+ func (b *ofFlowBuilder) MatchProtocol(protocol Protocol) FlowBuilder {
+ 	switch protocol {","I am a bit confused about this function. If it is used to set priority, we actually use function ""Table.BuildFlow(priority uint16)"" to set the value. If it is used to parse the priority value, I think adding a property(if you don't want to consume Match.Priority directly) to cache it and consume that property should be simpler than using string regex.",I don't think we need this. The priority is already set in the builder.
+7369,"@@ -68,7 +68,7 @@ func main() {
+ }
+ 
+ // addUnresolvedPackage adds an unresolved node to the graph representing the
+-// packged described in the PackgetVer structure. Returns an error if the node
++// packaged described in the PackgetVer structure. Returns an error if the node
+ // could not be created.
+ func addUnresolvedPackage(g *pkggraph.PkgGraph, pkgVer *pkgjson.PackageVer) (newRunNode *pkggraph.PkgNode, err error) {
+ 	logger.Log.Debugf(""Adding unresolved %s"", pkgVer)","In this case we probably meant ""package"".",I think this is a typo.
+7370,"@@ -0,0 +1,19 @@
++const fs = require('fs');
++const { promisify } = require('util');
++const { dirname: getDirName } = require('path');
++const makeDir = require('make-dir');
++const writeFile = promisify(fs.writeFile);
++
++/**
++ * Create file with given contents at specified location
++ * @method createFile
++ * @param {String} path file path, inclusive of file name
++ * @param {String} content contents of the file
++ * @returns {Promise}
++ */
++const createFile = (path, content) =>
++	makeDir(getDirName(path)).then(() => writeFile(path, content));
++
++module.exports = {
++	createFile
++};",Just export `createFile` directly.,`promisify` is not needed here.
+7371,"@@ -175,6 +175,7 @@ func DefaultConfiguration() *Configuration {
+ 	config.Docker.ResultsTimeout = cli.Duration(20 * time.Second)
+ 	config.Docker.RemoveTimeout = cli.Duration(20 * time.Second)
+ 	config.Go.GoTool = ""go""
++	config.Go.BuildIdTool = ""//tools/go_buildid_replacer""
+ 	config.Go.CgoCCTool = ""gcc""
+ 	config.Go.GoPath = ""$TMP_DIR:$TMP_DIR/src:$TMP_DIR/$PKG_DIR:$TMP_DIR/third_party/go:$TMP_DIR/third_party/""
+ 	config.Python.PipTool = ""pip3""",This probably needs to get shipped with plz; you shouldn't have to redefine it within the user's repo. It should use `defaultPath` like the other things up the top of the file.,Why is this needed?
+7372,"@@ -4,7 +4,7 @@ var run = function() {
+   var WalletKey = bitcore.WalletKey;
+   var Builder = bitcore.TransactionBuilder;
+   var opts = {
+-    network: networks.testnet
++    network: networks['btc'].testnet
+   };
+ 
+   console.log('## Network: ' + opts.network.name);",interface for bitcoin should not change if possible. i.e: networks.testnet should return networks['btc'].testnet,Why is this change needed?
+7373,"@@ -12,6 +12,7 @@ import (
+ 	""fmt""
+ 	""math/big""
+ 	""syscall""
++	""io/ioutil""
+ 
+ 	""github.com/golang/protobuf/proto""
+ 	""github.com/spf13/cobra""",File is not `gofmt`-ed with `-s` (from `gofmt`),Please remove this empty l
+7374,"@@ -929,3 +929,17 @@ void wlr_surface_send_leave(struct wlr_surface *surface,
+ 		}
+ 	}
+ }
++
++static inline int64_t timespec_to_msec(const struct timespec *a) {
++	return (int64_t)a->tv_sec * 1000 + a->tv_nsec / 1000000;
++}
++
++void wlr_surface_send_frame_done(struct wlr_surface *surface,
++		const struct timespec *when) {
++	struct wlr_frame_callback *cb, *cnext;
++	wl_list_for_each_safe(cb, cnext, &surface->current->frame_callback_list,
++			link) {
++		wl_callback_send_done(cb->resource, timespec_to_msec(when));
++		wl_resource_destroy(cb->resource);
++	}
++}",We have this functions in a couple of places. It should probably live in util or something.,Shouldn't this be `wl_reso
+7375,"@@ -53,6 +53,7 @@ module Mongoid
+                 # The associated object will be replaced by the below update if non-nil, so only
+                 # run the callbacks and state-changing code by passing persist: false in that case.
+                 _target.destroy(persist: !replacement) if persistable?
++                _target.new_record = true
+               end
+               unbind_one
+               return nil unless replacement",maybe this should be inside the destroy?,Why is this needed?
+7376,"@@ -106,10 +106,17 @@ class RPN(BaseDetector):
+             list[np.ndarray]: proposals
+         """"""
+         x = self.extract_feat(img)
++        # get origin input shape to onnx dynamic input shape
++        import torch
++        if torch.onnx.is_in_onnx_export():
++            img_shape = torch._shape_as_tensor(img)[2:]
++            img_metas[0]['img_shape_for_onnx'] = img_shape
+         proposal_list = self.rpn_head.simple_test_rpn(x, img_metas)
+         if rescale:
+             for proposals, meta in zip(proposal_list, img_metas):
+                 proposals[:, :4] /= proposals.new_tensor(meta['scale_factor'])
++        if torch.onnx.is_in_onnx_export():
++            return proposal_list
+ 
+         return [proposal.cpu().numpy() for proposal in proposal_list]
+ ",Do not import torch in the test function because it will import torch every test iteration and will slow down the testing speed.,Why do we need this?
+7377,"@@ -69,11 +69,16 @@ func (s *Service) InstanceByTags(machine *actuators.MachineScope) (*v1alpha1.Ins
+ }
+ 
+ // InstanceIfExists returns the existing instance or nothing if it doesn't exist.
+-func (s *Service) InstanceIfExists(id string) (*v1alpha1.Instance, error) {
+-	klog.V(2).Infof(""Looking for instance %q"", id)
++func (s *Service) InstanceIfExists(id *string) (*v1alpha1.Instance, error) {
++	if id == nil {
++		klog.Error(""Instance does not have an instance id"")
++		return nil, nil
++	}
++
++	klog.V(2).Infof(""Looking for instance %q"", *id)
+ 
+ 	input := &ec2.DescribeInstancesInput{
+-		InstanceIds: []*string{aws.String(id)},
++		InstanceIds: []*string{id},
+ 		Filters: []*ec2.Filter{
+ 			filter.EC2.VPC(s.scope.VPC().ID),
+ 			filter.EC2.InstanceStates(ec2.InstanceStateNamePending, ec2.InstanceStateNameRunning),","I think we want to return an error here, not nil.",Why is this a pointe
+7378,"@@ -38,6 +38,7 @@ describe( 'core/user userInfo', () => {
+ 			picture: 'https://path/to/image',
+ 		},
+ 		verified: true,
++		userInputState: 'complete',
+ 	};
+ 
+ 	let registry;","Nitpicking, but I think it would be more accurate to use an actually supported value, i.e. `completed`.",Why do we need this 
+7379,"@@ -0,0 +1,17 @@
++class OhAdmin::JobsController < ApplicationController
++  before_action :admin_session_required
++  before_action :find_project
++  layout 'admin'
++  helper JobApiHelper
++
++  def index
++    @response = JSON.parse(ApiJob.new(@project.id, params[:page]).get)
++  end
++
++  private
++
++  def find_project
++    @project = Project.find_by_vanity_url(params[:project_id])
++    raise ParamRecordNotFound if @project.nil?
++  end
++end","How about renaming the `ApiJob` class to `JobApi`. As per rails convention, get method is to get a single object, not a collection, can we change that to `fetch`/`where`. It would be great if we can move the `get` method to a class method.",Should this be `para
+7380,"@@ -427,12 +427,14 @@ func TestCreateBlockchain(t *testing.T) {
+ 	require.NoError(registry.Register(account.ProtocolID, acc))
+ 	rp := rolldpos.NewProtocol(cfg.Genesis.NumCandidateDelegates, cfg.Genesis.NumDelegates, cfg.Genesis.NumSubEpochs)
+ 	require.NoError(registry.Register(rolldpos.ProtocolID, rp))
+-	bc := NewBlockchain(cfg, nil, InMemStateFactoryOption(), InMemDaoOption(), RegistryOption(&registry))
++	sf, err := factory.NewFactory(cfg, factory.InMemTrieOption())
++	require.NoError(err)
++	bc := NewBlockchain(cfg, nil, sf, InMemDaoOption(), RegistryOption(&registry))
+ 	bc.Validator().AddActionEnvelopeValidators(protocol.NewGenericValidator(bc))
+ 	exec := execution.NewProtocol(bc, hu)
+ 	require.NoError(registry.Register(execution.ProtocolID, exec))
+ 	bc.Validator().AddActionValidators(acc, exec)
+-	bc.GetFactory().AddActionHandlers(acc, exec)
++	sf.AddActionHandlers(acc, exec)
+ 	require.NoError(bc.Start(ctx))
+ 	require.NotNil(bc)
+ 	height := bc.TipHeight()",assignments should only be cuddled with other assignments (from `wsl`),ineffectual assignment to `err` (from `ineffassign`)
+7381,"@@ -54,3 +54,11 @@ func (c *Cache) Delete(key interface{}) error {
+ 	c.values.Delete(key)
+ 	return nil
+ }
++
++func (c *Cache) GetAll() ([]interface{}, error) {
++	return nil, cache.ErrUnimplemented
++}
++
++func (c *Cache) PutHash(k interface{}, v interface{}) error {
++	return cache.ErrUnimplemented
++}",`k` is unused in PutHash,Why do we need this?
+7382,"@@ -39,7 +39,7 @@ interface StatementsSource extends FileSource
+ 
+     public function isStatic(): bool;
+ 
+-    public function getSource(): ?StatementsSource;
++    public function getSource(): StatementsSource;
+ 
+     public function getCodebase() : Codebase;
+ ","None of the child return null here, plus it was creating an incoherence between interfaces.",public function isStatic(): bool;
+7383,"@@ -1076,7 +1076,7 @@ pony_ctx_t* ponyint_sched_init(uint32_t threads, bool noyield, bool nopin,
+ 
+   // If minimum thread count is > thread count, cap it at thread count
+   if(min_threads > threads)
+-    min_threads = threads;
++    min_threads = threads; // this becomes the equivalent of --ponynoscale
+ 
+   // convert to cycles for use with ponyint_cpu_tick()
+   // 1 second = 2000000000 cycles (approx.)",Should we remove this entirely now then?,I don't think this is correct.
+7384,"@@ -0,0 +1,17 @@
++package monitor
++
++import (
++	""github.com/weaveworks/weave/net/address""
++)
++
++// Monitor is an interface for tracking changes in ring allocations.
++type Monitor interface {
++	// HandleUpdate is called whenever an address ring gets updated.
++	//
++	// prevRanges corresponds to ranges which were owned by a peer before
++	// a change in the ring, while currRanges to the ones which are currently
++	// owned by the peer.
++	HandleUpdate(prevRanges, currRanges []address.Range) error
++	// String returns a user-friendly name of the monitor.
++	String() string
++}",That is way too generic a name.,Why do we need this interface?
+7385,"@@ -49,4 +49,11 @@ describe('duplicate-id', function () {
+ 		assert.isTrue(checks['duplicate-id'].evaluate.call(checkContext, node));
+ 	});
+ 
++	it('should allow overwrote ids', function () {
++		fixture.innerHTML = '<form data-testelm=""1"" id=""target""><input name=""id""></form>';
++		var node = fixture.querySelector('[data-testelm=""1""]');
++
++		assert.isTrue(checks['duplicate-id'].evaluate.call(checkContext, node));
++	});
++
+ });",This might be overkill for test code...but as stewards of accessibility it would be appropriate to have a label in the fixture.,nit: typo `overwrote`
+7386,"@@ -232,7 +232,16 @@ TEST_F(VkBestPracticesLayerTest, CmdClearAttachmentTest) {
+     ASSERT_NO_FATAL_FAILURE(InitRenderTarget());
+ 
+     m_commandBuffer->begin();
+-    m_commandBuffer->BeginRenderPass(m_renderPassBeginInfo);
++
++    auto* secondary_full_clear = new VkCommandBufferObj(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
++    auto* secondary_small_clear = new VkCommandBufferObj(m_device, m_commandPool, VK_COMMAND_BUFFER_LEVEL_SECONDARY);
++    VkCommandBufferBeginInfo begin_info = { VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO };
++    begin_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT |
++                       VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT;
++    VkCommandBufferInheritanceInfo inherit_info = { VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO };
++    begin_info.pInheritanceInfo = &inherit_info;
++    inherit_info.subpass = 0;
++    inherit_info.renderPass = m_renderPassBeginInfo.renderPass;
+ 
+     // Main thing we care about for this test is that the VkImage obj we're
+     // clearing matches Color Attachment of FB","Are these allocations necessary, or can these be instantiated normally (i.e., `VkCommandBufferObj secondary_full_clear(...)`). If the allocations _are_ necessar, I'd vote for using something like `std::unique_ptr` and then remove the associated `delete`s.",Why is this needed?
+7387,"@@ -43,6 +43,8 @@ public class InternalForTests {
+ 
+   public static void clear(ElasticsearchHttpStorage es) throws IOException {
+     es.clear();
++    // clear servicespan cache in order to prevent tests breaking
++    ((ElasticsearchHttpSpanConsumer)es.asyncSpanConsumer()).resetIndexToServiceSpansCache();
+   }
+ 
+   public static void flushOnWrites(ElasticsearchHttpStorage.Builder builder) {",es.clear should call this,Why do we need this?
+7388,"@@ -54,6 +54,10 @@ class TPTest(unittest.TestCase):
+   def tearDown(self):
+     shutil.rmtree(self._tmpDir)
+ 
++  
++  def testInitDefaultTP(self):
++    self.assertTrue(isinstance(TP(), TP))
++
+ 
+   def testCheckpointLearned(self):
+     # Create a model and give it some inputs to learn.",please remove. this is true by the definition of the Python language,Why is this necessary?
+7389,"@@ -1239,6 +1239,8 @@ KEY_DATA = collections.OrderedDict([
+         ('stop', ['<Ctrl-s>']),
+         ('print', ['<Ctrl-Alt-p>']),
+         ('open qute:settings', ['Ss']),
++        ('select-follow', ['<Return>']),
++        ('select-follow -t', ['<Ctrl-Return>']),
+     ])),
+ 
+     ('insert', collections.OrderedDict([","Hmm, I wonder if binding `<Return>` is a good idea... this means it wouldn't be passed to webpages anymore, which makes me wonder how many people rely on that... I guess trying it is the only way to find out :wink:",I think this should be
+7390,"@@ -170,10 +170,18 @@ func udpPkt(src, dst string) packet {
+ func icmpPkt(src, dst string) packet {
+ 	return packetWithPorts(1, src+"":0"", dst+"":0"")
+ }
++func icmpPkt_with_type_code(src, dst string, icmpType, icmpCode int) packet {
++	return packet{
++		protocol: 1,
++		srcAddr:  src,
++		srcPort:  0,
++		dstAddr:  dst,
++		dstPort:  (icmpCode << 8) | (icmpType),
++	}
++}
+ 
+ var polProgramTests = []polProgramTest{
+ 	// Tests of actions and flow control.
+-
+ 	{
+ 		PolicyName: ""no tiers"",
+ 		DroppedPackets: []packet{",Golang naming convention is to use camel case `icmpPktWithTypeCode` Often the linter will complain,nit: `icmpPkt` -> `icm
+7391,"@@ -300,6 +300,12 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+ 
+         protected FrameResponseHeaders FrameResponseHeaders { get; } = new FrameResponseHeaders();
+ 
++        public TimeSpan RequestBodyTimeout { get; set; }
++
++        public double RequestBodyMinimumDataRate { get; set; }
++
++        public TimeSpan RequestBodyMinimumDataRateGracePeriod { get; set; }
++
+         public void InitializeStreams(MessageBody messageBody)
+         {
+             if (_frameStreams == null)",nit: Probably should renamed to `InitializeBody`,Why do we need this?
+7392,"@@ -11,13 +11,15 @@ export default Component.extend({
+ 
+     open: false,
+ 
+-    navMenuIcon: computed('config.blogUrl', function () {
+-        let url = `${this.get('config.blogUrl')}/favicon.png`;
++    navMenuIcon: computed('config.blogUrl', 'settings.icon', function () {
++        let blogIcon = this.get('settings.icon') ? this.get('settings.icon') : 'favicon.ico';
++        let url = `${this.get('config.blogUrl')}/${blogIcon}`;
+ 
+         return htmlSafe(`background-image: url(${url})`);
+     }),
+ 
+     config: injectService(),
++    settings: injectService(),
+     session: injectService(),
+     ghostPaths: injectService(),
+     feature: injectService(),",is `settings.icon` always null/undefined when there's no icon or does is it get set to a blank string? It might be worth wrapping it in an `isBlank()` anyway,Why do we need to inject the settings service here?
+7393,"@@ -90,8 +90,9 @@ var Module = fx.Options(
+ 	fx.Provide(MetadataManagerProvider),
+ 	fx.Provide(NamespaceCacheProvider),
+ 	fx.Provide(serialization.NewSerializer),
+-	fx.Provide(ArchiverProviderProvider),
+ 	fx.Provide(ArchivalMetadataProvider),
++	fx.Provide(ArchiverProviderProvider),
++	fx.Invoke(RegisterBootstrapContainer),
+ 	fx.Provide(PersistenceBeanProvider),
+ 	fx.Provide(MembershipFactoryProvider),
+ 	fx.Provide(MembershipMonitorProvider),","put invoke to the end of the list, and other module at beginning of the list (line 86)",Why is this needed?
+7394,"@@ -166,7 +166,7 @@ func New(path string, baseKey []byte, o *Options, logger logging.Logger) (db *DB
+ 	if db.capacity == 0 {
+ 		db.capacity = defaultCapacity
+ 	}
+-	db.logger.Infof(""db capacity: %v"", db.capacity)
++	db.logger.Infof(""database capacity: %d chunks, %d bytes, %.2f megabytes."", db.capacity, db.capacity*swarm.ChunkSize, float64(db.capacity*swarm.ChunkSize)*9.5367431640625e-7)
+ 	if maxParallelUpdateGC > 0 {
+ 		db.updateGCSem = make(chan struct{}, maxParallelUpdateGC)
+ 	}","I think that bytes is too precise. Can we just calculate the approximate value in appropriate units? Something like MB, GB depending on the value, `db capacity: 5000000 chunks (approximately 20GB)` .",Why do we need to multiply by `swarm.ChunkSize`?
+7395,"@@ -0,0 +1,4 @@
++let label = node.getAttribute('alt');
++let text = node.textContent;
++
++return (!!label && axe.commons.text.sanitize(label).trim() !== '' && axe.commons.text.sanitize(text).trim() !== '');","This check shouldn't look at the content, you're already doing this with `none-empty-text`. I also think this check should be renamed to `none-empty-alt` or something like it. There is nothing specific to applets in this check to warrant putting `applet` in the check ID.",Why do we need to check for whitespace here?
+7396,"@@ -31,9 +31,11 @@ class TaxCreationForm extends BaseForm
+ 
+     protected $taxEngine = null;
+ 
+-    public function __construct(Request $request, $type = ""form"", $data = array(), $options = array(), TaxEngine $taxEngine = null)
++    public function __construct(Request $request, $type = ""form"", $data = array(), $options = array())
+     {
+-        $this->taxEngine = $taxEngine;
++        $this->taxEngine = $options[""tax_engine""];
++
++        unset($options[""tax_engine""]);
+ 
+         parent::__construct($request, $type, $data, $options);
+     }",Why did you change the signature of this method ? You can break BC doing that,Why did you remove the default value?
+7397,"@@ -49,6 +49,12 @@ func Run(ctx context.Context, cfg *config.Node) error {
+ 	}
+ 
+ 	template := configToml
++
++	if cfg.ConfigTemplate != """" {
++		fileBytes, _ := ioutil.ReadFile(cfg.ConfigTemplate)
++		template = string(fileBytes[:])
++	}
++
+ 	if !cfg.NoFlannel {
+ 		template += configCNIToml
+ 	}",can you catch the error here please and return err if it can't read the template,Why do we ignore the error here?
+7398,"@@ -58,6 +58,7 @@ public class MainController {
+         appsController.setOnAppLoaded(() -> {
+             enginesController.loadEngines();
+             containersController.loadContainers();
++            libraryController.updateLibrary();
+         });
+ 
+         appsController.loadApps();",Is this method called at another location too? I'm just asking because you didn't remove another call to `updateLibrary`,Why do we need this?
+7399,"@@ -14,7 +14,7 @@ class PublicPagePolicy < ApplicationPolicy
+   end
+ 
+   def template_export?
+-    @object.is_default || @object.org.funder?
++    @object.present? && ( @object.is_default || @object.org.funder? ) && @object.published
+   end
+ 
+   def plan_export?",Not necessary but you should be able to add a `?` on `is_default?` and `published?`,I think this should be `@object.publi
+7400,"@@ -87,7 +87,7 @@ public class ProtoCodecBenchmarks {
+ 
+   @Benchmark
+   public List<Span> bytebuffer_zipkinDecoder() {
+-    return SpanBytesDecoder.PROTO3.decodeList(ByteBufUtil.getBytes(encodedBuf));
++    return SpanBytesDecoder.PROTO3.decodeList(encodedBuf.nioBuffer());
+   }
+ 
+   @Benchmark",here is us decoding directly the bytebuffer in benchmarks,Why is this change needed?
+7401,"@@ -39,7 +39,16 @@ namespace Datadog.Trace.Logging
+             }
+             else
+             {
+-                SetDefaultValues();
++                // Do not set default values because the Tracer (and this event
++                // subscriber) may be initialized at a time when it is not safe
++                // to add properties to the MDC of the underlying logging framework.
++                //
++                // This previously caused a SerializationException when the Tracer
++                //  was initialized in the Asp.Net HttpModule startup, the default
++                // values were added to the underlying log4net framework, and,
++                // upon handling a new request, Asp.Net tried to copy the type
++                // log4net.Util.PropertiesDictionary from one AppDomain to another
++                // even though the type did not implement MarshalObjectByRef
+                 _scopeManager.SpanActivated += MapOnSpanActivated;
+                 _scopeManager.TraceEnded += MapOnTraceEnded;
+             }","When the Tracer is first created AND `DD_LOGS_INJECTION=true`, this is invoked and causes the issues described.",Why did you remove this li
+7402,"@@ -44,7 +44,7 @@ public class JsonRpcErrorConverter {
+       case GAS_PRICE_TOO_LOW:
+         return JsonRpcError.GAS_PRICE_TOO_LOW;
+       case PRIVACY_GROUP_DOES_NOT_EXIST:
+-        return JsonRpcError.PRIVACY_GROUP_DOES_NOT_EXIST;
++        return JsonRpcError.OFFCHAIN_PRIVACY_GROUP_DOES_NOT_EXIST;
+ 
+       default:
+         return JsonRpcError.INVALID_PARAMS;","NIT: If we are renaming the JsonRpcError, should we also rename this enum value to be consistent?",I think this should be `OF
+7403,"@@ -572,7 +572,8 @@ type FunctionExpression struct {
+ 	Defaults   *ObjectExpression
+ 	Block      *Block
+ 
+-	typ MonoType
++	typ        MonoType
++	Vectorized Expression
+ }
+ 
+ func (*FunctionExpression) NodeType() string { return ""FunctionExpression"" }","This could be made into a function expression, yes?",Why is this a vectorized e
+7404,"@@ -9,5 +9,5 @@ void release_assert_internal (bool check, const char * check_expr, const char *
+ 	}
+ 
+ 	std::cerr << ""Assertion ("" << check_expr << "") failed "" << file << "":"" << line << std::endl;
+-	abort();
++	abort ();
+ }","Oops, I missed this initially.",Why the extra space?
+7405,"@@ -243,6 +243,12 @@ class TestLambdaBaseFeatures(unittest.TestCase):
+         lambda_client.delete_function(FunctionName=lambda_name)
+ 
+     def test_add_lambda_permission(self):
++        function_name = 'lambda_func-{}'.format(short_uid())
++        testutil.create_lambda_function(
++            handler_file=TEST_LAMBDA_ECHO_FILE,
++            func_name=function_name,
++            runtime=LAMBDA_RUNTIME_PYTHON36
++        )
+         iam_client = aws_stack.connect_to_service('iam')
+         lambda_client = aws_stack.connect_to_service('lambda')
+ ",Can we add an assertion here the policy actually contains both statements created above?,nit: `testutil.creat
+7406,"@@ -59,7 +59,13 @@ DEFINE_bool(enable_partitioned_index_filter, false, ""True for partitioned index
+ DEFINE_string(rocksdb_compression,
+               ""snappy"",
+               ""Compression algorithm used by RocksDB, ""
+-              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2"");
++              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress"");
++
++DEFINE_string(rocksdb_bottommost_compression,
++              ""disable"",
++              ""Specify the bottommost level compression algorithm""
++              ""options: no,snappy,lz4,lz4hc,zstd,zlib,bzip2,xpress,disable"");
++
+ DEFINE_string(rocksdb_compression_per_level,
+               """",
+               ""Specify per level compression algorithm, """,a space after comma?,This should be `rock
+7407,"@@ -70,6 +70,11 @@ public final class CorrectForClockSkew {
+     if (skew != null) {
+       // the current span's skew may be a different endpoint than skewFromParent, adjust again.
+       node.value(adjustTimestamps(node.value(), skew));
++    } else {
++      if (skewFromParent != null && isLocalSpan(node.value())) {
++        //Propagate skewFromParent to local spans
++         skew = skewFromParent;
++      }
+     }
+     // propagate skew to any children
+     for (Node<Span> child : node.children()) {",nit formatting here and below,nit: space after `//
+7408,"@@ -5,9 +5,9 @@ import (
+ 
+ 	""github.com/golang/mock/gomock""
+ 	""github.com/spiffe/spire/pkg/common/util""
+-	""github.com/spiffe/spire/proto/spire/api/registration""
+-	""github.com/spiffe/spire/proto/spire/common""
+-	mock_registration ""github.com/spiffe/spire/test/mock/proto/api/registration""
++	""github.com/spiffe/spire/proto/spire/api/server/entry/v1""
++	""github.com/spiffe/spire/proto/spire/types""
++	mock_entry ""github.com/spiffe/spire/test/mock/proto/api/entry""
+ 	""github.com/stretchr/testify/suite""
+ )
+ ","I think that there is a general consensus of trying to avoid this kind of mocks in the new tests that we write. I would suggest to have tests using fake service implementations. In this case, we can have a fake entry service. Examples of how tests have been written this way are the tests for the `spire-server agent` and `spire-server bundle` commands. It would be great if we can have that kind of testing here also. What do you think?",File is not `goimports`-ed
+7409,"@@ -38,6 +38,6 @@ func (p *Provider) Type() string {
+ 	return ProviderType
+ }
+ 
+-func (p *Provider) RunQuery(ctx context.Context, query string) (bool, error) {
+-	return false, nil
++func (p *Provider) RunQuery(ctx context.Context, query string) (bool, string, error) {
++	return false, """", nil
+ }",`ctx` is unused in RunQuery,Why do we need this change
+7410,"@@ -276,12 +276,14 @@ def get_report_path_hash(report):
+     """""" Returns path hash for the given bug path.
+ 
+     This can be used to filter deduplications of multiple reports.
++
++    report type should be codechecker_common.Report
+     """"""
+     report_path_hash = ''
+     events = [i for i in report.bug_path if i.get('kind') == 'event']
+-
+     for event in events:
+-        file_name = os.path.basename(report.files[event['location']['file']])
++        file_name = \
++            os.path.basename(report.files.get(event['location']['file']))
+         line = str(event['location']['line']) if 'location' in event else 0
+         col = str(event['location']['col']) if 'location' in event else 0
+ ",Couldn't we use type hints to express this?,I don't think you need the
+7411,"@@ -57,12 +57,12 @@ define(['connectionManager', 'serverNotifications', 'events', 'globalize', 'emby
+ 
+     function setState(button, likes, isFavorite, updateAttribute) {
+ 
+-        var icon = button.querySelector('i');
++        var icon = button.querySelector('.material-icons');
+ 
+         if (isFavorite) {
+ 
+             if (icon) {
+-                icon.innerHTML = 'favorite';
++                icon.classList.add('favorite');
+                 icon.classList.add('ratingbutton-icon-withrating');
+             }
+ ",why you do `.classList.add()` here but `.replace()` in other places?,Why is this change necessa
+7412,"@@ -98,9 +98,14 @@ Then 'I see the section price is ""$price""' do |price|
+ end
+ 
+ Then 'I see that one of the teachers is ""$teacher_name""' do |teacher_name|
++  sleep 10
+   page.should have_css("".teachers"", text: teacher_name)
+ end
+ 
++Then 'I should see that ""$teacher_name"" is teaching both sections' do |teacher_name|
++  page.should have_selector('h4', text: ""Joe Teacher"", count: 1)
++end
++
+ Then %{I see ""$teacher_name""'s avatar} do |teacher_name|
+   teacher = Teacher.find_by_name!(teacher_name)
+   page.should have_css(""img[src^='https://secure.gravatar.com/avatar/#{teacher.gravatar_hash}']"")",What is this sleep here for?,Why is this sleep needed?
+7413,"@@ -478,4 +478,19 @@ describe('AutoRowSize', () => {
+ 
+     expect(rowHeight(spec().$container, -1)).toBe(75);
+   });
++
++  it('should properly count height', () => {
++    const hot = handsontable({
++      data: [['Tomek', 'Tomek\nTomek', 'Romek\nRomek']],
++      rowHeaders: true,
++      colHeaders: true,
++      autoRowSize: true,
++    });
++    // const cloneLeftHider = spec().$container.find('.ht_clone_left .wtHider')[0];
++    const $rowsHeaders = spec().$container.find('.ht_clone_left tbody tr th');
++    const plugin = hot.getPlugin('autoRowSize');
++
++    expect($rowsHeaders.height()).toEqual(42);
++    expect(plugin.heights[0]).toEqual(43);
++  });
+ });","I think that this test doesn't cover this bug correctly. When I attached the older version of the handsontable to this test it passes, should fail. Can you check that?",Can we remove this?
+7414,"@@ -186,6 +186,16 @@ type tlfJournal struct {
+ 	mdJournal    *mdJournal
+ 	disabled     bool
+ 	lastFlushErr error
++	// The cache of unflushed paths.  If `unflushedReady` is not nil,
++	// then any callers must wait for it to be closed before accessing
++	// `unflushedPaths`.  `unflushedReady` only transitions
++	// nil->non-nil->nil at most one time during the lifetime of the
++	// journal. If `unflushedPaths` is non-nil, then `chainsPopulator`
++	// must also be non-nil.  These three fields are protected by
++	// `journalLock`.
++	unflushedPaths  map[MetadataRevision]map[string]bool
++	unflushedReady  chan struct{}
++	chainsPopulator chainsPathPopulator
+ 
+ 	bwDelegate tlfJournalBWDelegate
+ }",Maybe this should just be passed in on construction time,nit: `unflushedReady` -> 
+7415,"@@ -367,6 +367,11 @@ struct wlr_backend *wlr_backend_autocreate(struct wl_display *display) {
+ 
+ 	struct wlr_backend *primary_drm =
+ 		attempt_drm_backend(display, backend, multi->session);
++
++	// discard the returned pointer - the monitor should destroy itself
++	// when the multi-backend is destroyed
++	wlr_drm_backend_monitor_create(backend, primary_drm, multi->session);
++
+ 	if (!primary_drm) {
+ 		wlr_log(WLR_ERROR, ""Failed to open any DRM device"");
+ 		wlr_backend_destroy(libinput);",We should create the monitor after the `if (!primary_drm)` check.,Shouldn't this be done in
+7416,"@@ -85,6 +85,7 @@ def whitelist_generator():
+     yield 'qutebrowser.utils.log.QtWarningFilter.filter'
+     yield 'logging.LogRecord.log_color'
+     yield 'qutebrowser.browser.pdfjs.is_available'
++    yield 'qutebrowser.browser.tab.TabData._initializing'
+     # vulture doesn't notice the hasattr() and thus thinks netrc_used is unused
+     # in NetworkManager.on_authentication_required
+     yield 'PyQt5.QtNetwork.QNetworkReply.netrc_used'",Can be removed now that slots are used,Why is this needed?
+7417,"@@ -216,7 +216,7 @@ describe 'AccountsController' do
+   describe 'edit' do
+     it 'must respond with not_found when account does not exist' do
+       get :edit, id: :anything
+-      must_respond_with :not_found
++      must_respond_with :unauthorized
+     end
+ 
+     it 'must respond with success' do",The description should match the test,Use the new Ruby 1.
+7418,"@@ -165,12 +165,9 @@ static void xwayland_finish_display(struct wlr_xwayland *wlr_xwayland) {
+ 
+ 	unlink_display_sockets(wlr_xwayland->display);
+ 	wlr_xwayland->display = -1;
+-	unsetenv(""DISPLAY"");
++	wlr_xwayland->display_name[0] = '\0';
+ }
+ 
+-static bool xwayland_start_display(struct wlr_xwayland *wlr_xwayland,
+-	struct wl_display *wl_display);
+-
+ static bool xwayland_start_server(struct wlr_xwayland *wlr_xwayland);
+ static bool xwayland_start_server_lazy(struct wlr_xwayland *wlr_xwayland);
+ ",rootston needs to unset this now,Why is this being r
+7419,"@@ -35,7 +35,7 @@ func newBlockBuffer(bufferSize, intervalSize uint64) *blockBuffer {
+ 	}
+ }
+ 
+-func (b *blockBuffer) Delete(height uint64) []*peerBlock {
++func (b *blockBuffer) Pop(height uint64) []*peerBlock {
+ 	b.mu.Lock()
+ 	defer b.mu.Unlock()
+ 	queue, ok := b.blockQueues[height]",why do you rename this function?,Why do we need to d
+7420,"@@ -30,12 +30,10 @@ module MailerHelper
+   end
+ 
+   def step_status_icon(step)
+-    if step.status == ""actionable""
+-      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + "".png""
+-    elsif step.status == ""pending""
+-      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + ""-pending.png""
+-    elsif step.status == ""completed""
++    if step.status == ""completed""
+       ""emails/numbers/icon-completed.png""
++    else
++      ""emails/numbers/icon-number-"" + (step.position - 1).to_s + ""-pending.png""
+     end
+   end
+ ",since we are no longer using these numbered icons can we remove them from source control?,Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end.
+7421,"@@ -182,6 +182,8 @@ public class VertxRestDispatcher extends AbstractVertxHttpDispatcher {
+ 
+     RestProducerInvocation restProducerInvocation = new RestProducerInvocation();
+     context.put(RestConst.REST_PRODUCER_INVOCATION, restProducerInvocation);
++    restProducerInvocation.setAfterCreateInvocationHandler(
++        invocation -> context.put(RestConst.REST_INVOCATION_CONTEXT, invocation));
+     restProducerInvocation.invoke(transport, requestEx, responseEx, httpServerFilters);
+   }
+ }","both edge and normal need to set this, so set it to be default action?",Why do we need this?
+7422,"@@ -391,9 +391,13 @@ namespace Microsoft.DotNet.Build.Tasks
+ 
+         private static void WriteProject(JObject projectRoot, string projectJsonPath)
+         {
+-            string projectJson = JsonConvert.SerializeObject(projectRoot, Formatting.Indented);
+-            Directory.CreateDirectory(Path.GetDirectoryName(projectJsonPath));
+-            File.WriteAllText(projectJsonPath, projectJson + Environment.NewLine); 
++            string projectJson = JsonConvert.SerializeObject(projectRoot, Formatting.Indented) + Environment.NewLine;
++
++            if (!File.Exists(projectJsonPath) || !projectJson.Equals(File.ReadAllText(projectJsonPath)))
++            {
++                Directory.CreateDirectory(Path.GetDirectoryName(projectJsonPath));
++                File.WriteAllText(projectJsonPath, projectJson);
++            }
+         }
+ 
+         /* JProperties are encapsulated with ""['"" and ""']"" to assist with matching Paths which",Is doing a straight string compare of the files the right way to determine this? I guess if you expect to be the only one writing this file it could work but it does seem like it might be a large string compare and if we are doing this hundreds of times that might cause some memory issues.,Why do we need this check?
+7423,"@@ -431,7 +431,7 @@ static void set_client_priority() {
+ #ifdef __linux__
+     char buf[1024];
+     snprintf(buf, sizeof(buf), ""ionice -c 3 -p %d"", getpid());
+-    system(buf);
++    if (!system(buf)) {}
+ #endif
+ }
+ ",What's the purpose of this change? It basically changes nothing until we want to put smth between curly braces,This should be `if (!system(buf)) {`
+7424,"@@ -186,6 +186,9 @@ static void handle_device_removed(struct wlr_libinput_backend *backend,
+ 	}
+ 	struct wlr_input_device *dev, *tmp_dev;
+ 	wl_list_for_each_safe(dev, tmp_dev, wlr_devices, link) {
++		if (dev->type == WLR_INPUT_DEVICE_TABLET_TOOL) {
++			wlr_libinput_tablet_tool_destroy(dev);
++		}
+ 		wlr_input_device_destroy(dev);
+ 	}
+ 	for (size_t i = 0; i < backend->wlr_device_lists.length; i++) {","Hmm, why is this needed? `wlr_input_device_destroy` should destroy the tablet tool.",Shouldn't this be `dev->type != WLR_INPUT_DEVICE_TABLET_TOOL`?
+7425,"@@ -62,6 +62,12 @@ public class DiscoApiModel implements ApiModel {
+     return interfaceModels;
+   }
+ 
++  @Override
++  public Iterable<? extends TypeModel> getAdditionalTypes() {
++    // TODO: is this supported?
++    return ImmutableList.of();
++  }
++
+   @Override
+   public InterfaceModel getInterface(String interfaceName) {
+     for (InterfaceModel interfaceModel : getInterfaces()) {",I think it's better to throw `UnsupportedOperationException`,I'm not sure if this is the right way to implement this.
+7426,"@@ -124,6 +124,14 @@ function createElement(...args) {
+ 			delete props.defaultValue;
+ 		}
+ 
++		if (Array.isArray(props.value) && props.multiple && type==='select') {
++			props.children.forEach((child) => {
++				if (props.value.includes(child.props.value)) {
++					child.props.selected = true;
++				}
++			});
++			delete props.value;
++		}
+ 		handleElementVNode(vnode, props);
+ 	}
+ ",`props.children` is not always guaranteed to be an array. When only one child is passed this will break. We can use `toChildArray()` to turn it into an array :tada:,Why is this needed?
+7427,"@@ -26,7 +26,8 @@ buildStyle = os.environ['BUILD_STYLE']
+ 
+ # Build the configure command.
+ configureCmd = os.path.join(buildSystemDir, 'contrib', 'configure.py')
+-configureCmd += ' --mode=%s' % buildStyle
++# configureCmd += ' --mode=%s' % buildStyle
++configureCmd += ' --mode=release'
+ configureCmd += ' --builddir=%s' % buildDir
+ 
+ print 'Running command:', configureCmd",Please just remove this line. We have the git history if we want the old version.,Why is this needed?
+7428,"@@ -49,9 +49,11 @@ public class ScriptTaskGraalJsTest extends AbstractScriptTaskTest {
+   private static final String GRAALJS = ""graal.js"";
+ 
+   protected ScriptEngineResolver defaultScriptEngineResolver;
++  protected boolean spinEnabled = false;
+ 
+   @Before
+   public void setup() {
++    spinEnabled = processEngineConfiguration.getEnvScriptResolvers().stream().anyMatch(resolver -> resolver.getClass().getSimpleName().equals(""SpinScriptEnvResolver""));
+     defaultScriptEngineResolver = processEngineConfiguration.getScriptEngineResolver();
+     processEngineConfiguration.setConfigureScriptEngineHostAccess(configureHostAccess);
+     processEngineConfiguration.setEnableScriptEngineLoadExternalResources(enableExternalResources);","Can we put some of the code on a new line to make it more readable. The max line length was 120 now, right?",I think it would be better to use the `SpinScriptEnvResolver.class.getName()` here.
+7429,"@@ -56,3 +56,19 @@ func Example() {
+ 	cfg := snapshot.Value.(MyConfig)
+ 	_ = cfg
+ }
++
++func Example_openVariable() {
++	// OpenVariable creates a *runtimevar.Variable from a URL.
++	// This example watches a variable based on a file-based blob.Bucket with JSON.
++	ctx := context.Background()
++	v, err := runtimevar.OpenVariable(ctx, ""etcd://myvarname?client=my.etcd.server:9999"")
++	if err != nil {
++		log.Fatal(err)
++	}
++
++	snapshot, err := v.Watch(ctx)
++	if err != nil {
++		log.Fatal(err)
++	}
++	_, _ = snapshot, err
++}",Remove the handling here as well.,nit: can we use `log.Fatalf` here?
+7430,"@@ -113,7 +113,7 @@ namespace OpenTelemetry.Trace
+         /// <inheritdoc/>
+         public override void OnEnd(Activity activity)
+         {
+-            if (this.queue.TryAdd(activity))
++            if (this.queue.TryAdd(activity, maxSpinCount: 50000))
+             {
+                 if (this.queue.Count >= this.maxExportBatchSize)
+                 {",Do we want to make this configurable?,Why do we need this?
+7431,"@@ -159,6 +159,17 @@ public final class Require {
+     return number;
+   }
+ 
++  public static double positive(String argName, double number, String message) {
++    if (number <= 0) {
++      if (message == null) {
++        throw new IllegalArgumentException(argName + "" must be greater than 0"");
++      } else {
++        throw new IllegalArgumentException(message);
++      }
++    }
++    return number;
++  }
++
+   public static int positive(String argName, Integer number) {
+     return positive(argName, number, null);
+   }","Prefer adding a second `positive(String, double)` that delegates down to this three-param version. Using `null` in code is generally Not A Great Idea, and it looks ugly.",I think it would be better to use `NumberFormatException`
+7432,"@@ -71,4 +71,17 @@ ActiveAdmin.register Proposal do
+     flash[:alert] = ""Completed!""
+     redirect_to admin_proposal_path(resource)
+   end
++
++  csv do
++    proposal_attributes = %w(id status created_at updated_at client_data_type public_id visit_id)
++    proposal_attributes.each do |proposal_attr|
++      column(proposal_attr.to_sym) { |proposal| proposal.attributes[proposal_attr] }
++    end
++    column(:requester) { |proposal| proposal.requester.display_name }
++    client_data_attributes = %w(expense_type vendor not_to_exceed building_number emergency rwa_number work_order_code project_title description direct_pay cl_number function_code soc_code ncr_organization_id)
++    client_data_attributes.each do |data_attr|
++      column(data_attr.to_sym) { |proposal| proposal.client_data.attributes[data_attr] }
++    end
++    column(:approving_offical_name) { |proposal| User.find(proposal.client_data.approving_official_id).display_name }
++  end
+ end","Is this going to break things for 18F proposals, or will these fields just be ignored?",I think this should be `proposal.client_data.display_name`
+7433,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those, 
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?,I don't think you need to change this line.
+7434,"@@ -35,6 +35,12 @@ type AWSClusterProviderConfig struct {
+ 
+ 	// SSHKeyName is the name of the ssh key to attach to the bastion host.
+ 	SSHKeyName string `json:""sshKeyName,omitempty""`
++
++	// CACertificate is a PEM encoded CA Certificate for the control plane nodes.
++	CACertificate []byte `json:""caCertificate,omitempty""`
++
++	// CAPrivateKey is a PEM encoded PKCS1 CA PrivateKey for the control plane nodes.
++	CAPrivateKey []byte `json:""caKey,omitemptuy""`
+ }
+ 
+ // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object",What's the reason for moving this to config from status?,Why is omitemptuy here?
+7435,"@@ -48,7 +48,7 @@ class GenericSuppressHandler(suppress_handler.SuppressHandler):
+     def store_suppress_bug_id(self, bug_id, file_name, comment):
+ 
+         if self.suppress_file is None:
+-            return False
++            return True
+ 
+         ret = suppress_file_handler.write_to_suppress_file(self.suppress_file,
+                                                            bug_id,",Shouldn't we re validate/update the in memory suppress data here?,Why did you change this?
+7436,"@@ -68,7 +68,7 @@ func TestPaymentChannelLs(t *testing.T) {
+ 	t.Run(""Works with default payer"", func(t *testing.T) {
+ 		t.Parallel()
+ 
+-		payer, err := address.NewFromString(fixtures.TestAddresses[0])
++		payer, err := address.NewFromString(fixtures.TestAddresses[2])
+ 		require.NoError(err)
+ 		target, err := address.NewFromString(fixtures.TestAddresses[1])
+ 		require.NoError(err)",curious why the renumbering is required here and elsewhere?,Why did this change?
+7437,"@@ -426,9 +426,12 @@ func validateClusterPlatform(path *field.Path, platform hivev1.Platform) field.E
+ 	if aws := platform.AWS; aws != nil {
+ 		numberOfPlatforms++
+ 		awsPath := path.Child(""aws"")
+-		if aws.CredentialsSecretRef.Name == """" {
++		if aws.CredentialsSecretRef.Name == """" && aws.CredentialsAssumeRole == nil {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""credentialsSecretRef"", ""name""), ""must specify secrets for AWS access""))
+ 		}
++		if aws.CredentialsAssumeRole != nil && aws.CredentialsSecretRef.Name != """" {
++			allErrs = append(allErrs, field.Required(awsPath.Child(""credentialsAssumeRole""), ""cannot specify assume role when credentials secret is provided""))
++		}
+ 		if aws.Region == """" {
+ 			allErrs = append(allErrs, field.Required(awsPath.Child(""region""), ""must specify AWS region""))
+ 		}",s/must specify secrets/must specify secrets or Role info/,I think this should 
+7438,"@@ -63,8 +63,8 @@ C2::Application.routes.draw do
+   end
+ 
+   mount Peek::Railtie => ""/peek""
++  mount Blazer::Engine, at: ""blazer""
+   if Rails.env.development?
+     mount LetterOpenerWeb::Engine => ""letter_opener""
+-    mount Blazer::Engine, at: ""blazer""
+   end
+ end","let's leave this as a dev-only feature, and copy prod db to local env when needed. that keeps blazer security issues to a minimum.",Why is this being re
+7439,"@@ -22,7 +22,7 @@ namespace OpenTelemetry.Trace.Samplers
+     public sealed class AlwaysOffActivitySampler : ActivitySampler
+     {
+         /// <inheritdoc />
+-        public override string Description { get; } = nameof(AlwaysOffActivitySampler);
++        public override string Description { get; } = ""AlwaysOffSampler"";
+ 
+         /// <inheritdoc />
+         public override SamplingResult ShouldSample(in ActivitySamplingParameters samplingParameters)","We'll be renaming ActivitySampler to Sampler anyway, so this change will be non-required. Prefer to avoid changes here to avoid merge conflict with my PR doing the rename.",Why did you remove t
+7440,"@@ -278,7 +278,10 @@ func mutateHeadersByRules(headers, rules http.Header, repl httpserver.Replacer)
+ 		} else if strings.HasPrefix(ruleField, ""-"") {
+ 			headers.Del(strings.TrimPrefix(ruleField, ""-""))
+ 		} else if len(ruleValues) > 0 {
+-			headers.Set(ruleField, repl.Replace(ruleValues[len(ruleValues)-1]))
++			var replacement = repl.Replace(ruleValues[len(ruleValues)-1])
++			if len(replacement) > 0 {
++				headers.Set(ruleField, replacement)
++			}
+ 		}
+ 	}
+ }","This applies only in the ""set"" headers case, but what about ""adding"" a header (field prefixed with `+`)?",Why is this needed?
+7441,"@@ -13,6 +13,7 @@ package net.sourceforge.pmd;
+  * @version $Revision$, $Date$
+  * @since August 30, 2002
+  */
++@Deprecated
+ public class PMDException extends Exception {
+     private static final long serialVersionUID = 6938647389367956874L;
+ ","I'm not sure we should deprecate this. I kinda like the idea, that we would provide all exceptions (if we throw any) with a common super type. Of course, the exception should be not a checked exception like this one, but rather a runtime exception. We maybe need additionally an internal exception that we would convert into such a public API exception. But that's out of scope of this PR - that's the question of exception handling.",Why is this class d
+7442,"@@ -41,6 +41,11 @@ class TabDeletedError(Exception):
+     """"""Exception raised when _tab_index is called for a deleted tab.""""""
+ 
+ 
++class MarkNotSetError(Exception):
++
++    """"""Exception raised when _tab_index is called for a deleted tab.""""""
++
++
+ class TabbedBrowser(tabwidget.TabWidget):
+ 
+     """"""A TabWidget with QWebViews inside.",You'll need to adjust the docstring :wink:,Why is this needed?
+7443,"@@ -81,7 +81,8 @@ void ReaderProxy::start(const ReaderProxyData& reader_attributes)
+         reader_attributes.guid(),
+         reader_attributes.remote_locators().unicast,
+         reader_attributes.remote_locators().multicast,
+-        reader_attributes.m_expectsInlineQos);
++        reader_attributes.m_expectsInlineQos,
++        /*reader_attributes.guid().is_on_same_process_as(writer_->getGuid()*/false);
+ 
+     is_active_ = true;
+     reader_attributes_ = reader_attributes;",Add a TODO explaining why this is being done,Why is this needed?
+7444,"@@ -26,7 +26,8 @@
+ 
+ goog.provide('Blockly.VariableMap');
+ 
+-goog.require('Blockly.VariableModel');
++goog.require('Blockly.Events.VarDelete');
++goog.require('Blockly.Events.VarRename');
+ 
+ /**
+  * Class for a variable map.  This contains a dictionary data structure with",This file still uses Blockly.VariableModel...,Why did you change this?
+7445,"@@ -129,8 +129,10 @@ type ManagedRemoteAccess struct {
+ 	SSHKeyName *string `json:""sshKeyName,omitempty""`
+ 
+ 	// SourceSecurityGroups specifies which security groups are allowed access
+-	// An empty array opens port 22 to the public internet
+ 	SourceSecurityGroups []string `json:""sourceSecurityGroups,omitempty""`
++
++	// Public specifies whether to open port 22 to the public internet
++	Public bool `json:""public,omitempty""`
+ }
+ 
+ // AWSManagedMachinePoolStatus defines the observed state of AWSManagedMachinePool","Small nit, in the PR description its `publicAccess` but here its `public`. Guessing the preferred naming is public?",Why is this a pointer?
+7446,"@@ -106,10 +106,11 @@ func (c *Variable) Close() error {
+ // Decode is a function type for unmarshaling/decoding bytes into given object.
+ type Decode func([]byte, interface{}) error
+ 
+-// Decoder is a helper for decoding bytes into a particular Go type object.  The Variable objects
+-// produced by a particular driver.Watcher should always contain the same type for Variable.Value
+-// field.  A driver.Watcher can use/construct a Decoder object with an associated type (Type) and
+-// decoding function (Func) for decoding retrieved bytes into Variable.Value.
++// Decoder is a helper for decoding bytes into a particular Go type object. The
++// Variable objects produced by a particular driver.Watcher should always
++// contain the same type for Variable.Value field. A driver.Watcher can
++// use/construct a Decoder object with an associated type (Type) and decoding
++// function (Func) for decoding retrieved bytes into Variable.Value.
+ type Decoder struct {
+ 	Type reflect.Type
+ 	// Func is a Decode function.","Maybe `driver.Watcher` -> provider (2x)? This is the concrete type, this user doesn't really know anything about the driver.",Why did you change this?
+7447,"@@ -21,12 +21,10 @@ import java.io.IOException;
+ 
+ import org.apache.lucene.codecs.DocValuesConsumer;
+ import org.apache.lucene.search.DocIdSetIterator;
+-import org.apache.lucene.search.SortField;
+ 
+-abstract class DocValuesWriter {
+-  abstract void finish(int numDoc);
++abstract class DocValuesWriter<T> {
+   abstract void flush(SegmentWriteState state, Sorter.DocMap sortMap, DocValuesConsumer consumer) throws IOException;
+-  abstract Sorter.DocComparator getDocComparator(int numDoc, SortField sortField) throws IOException;
++  abstract T getDocValues();
+   abstract DocIdSetIterator getDocIdSet();
+ 
+ }",can we remove this since `getDocValues` already returns an iterator? (we might need to do `T extends DocIdSetIterator` above),Why do we need to change
+7448,"@@ -0,0 +1,8 @@
++class String
++  def fix_encoding_if_invalid!
++    unless self.valid_encoding?
++      self.encode!('utf-8', 'binary', invalid: :replace, undef: :replace)
++    end
++    self
++  end
++end",Don't check this in. This is already implemented in core_extensions/ruby/string.rb,Why do we need this class?
+7449,"@@ -277,7 +277,7 @@ Block.prototype._getHash = function() {
+ 
+ var idProperty = {
+   configurable: false,
+-  writeable: false,
++  enumerable: true,
+   /**
+    * @returns {string} - The big endian hash buffer of the header
+    */","This is used for both `id`, and `hash` we may not want these both to be enumerable.",Why do we need to change t
+7450,"@@ -641,9 +641,16 @@ module RSpec
+         formatter_loader.default_formatter = value
+       end
+ 
+-      # @private
++      # @api public
++      #
++      # Returns a duplicate of the formatters currently loaded in
++      # the `FormatterLoader` for introspection.
++      #
++      # Note as this is a duplicate, any mutations will be disregarded.
++      #
++      # @return [Array] the formatters currently loaded
+       def formatters
+-        formatter_loader.formatters
++        formatter_loader.formatters.dup
+       end
+ 
+       # @private",Is this necessary? I would expect YARD to treat it as public anyway... (Don't hold off merging on this...I'm mostly just curious).,I think this should be `@r
+7451,"@@ -578,6 +578,7 @@ func (e *MutableStateImpl) GetActivityScheduledEvent(
+ 		e.executionState.RunId,
+ 		ai.ScheduledEventBatchId,
+ 		ai.ScheduleId,
++		ai.Version,
+ 		currentBranchToken,
+ 	)
+ 	if err != nil {",@wxing1292 to double check this is the right version to use?,nit: I think we can remove
+7452,"@@ -70,4 +70,12 @@ class TIntRange extends TInt
+     {
+         return $this->min_bound !== null && $this->min_bound > 0;
+     }
++
++    public function contains(int $i): bool
++    {
++        return
++            ($this->min_bound === null && $this->max_bound === null) ||
++            ($this->min_bound === null && $this->max_bound >= $i) ||
++            ($this->max_bound === null && $this->min_bound <= $i);
++    }
+ }",Shouldn't there be another case for when both min and max are specified?,I think this should be `!==` instead of `>=`.
+7453,"@@ -1,5 +1,5 @@
+ ## This file is part of Invenio.
+-## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 CERN.
++## Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013, 2014 CERN.
+ ##
+ ## Invenio is free software; you can redistribute it and/or
+ ## modify it under the terms of the GNU General Public License as","Don't miss this one `2: I102 copyright year is outdated, expected 2014 but got 2013`. Thanks",Why did you change this?
+7454,"@@ -112,8 +112,9 @@ size_t Cord::appendTo(std::string& str) const {
+     }
+ 
+     // Last block
+-    str.append(tail_, blockPt_);
+-
++    if (tail_) {
++        str.append(tail_, blockPt_);
++    }
+     return len_;
+ }
+ ",the tail_ maybe nullptr?,nit: remove empty line
+7455,"@@ -92,7 +92,7 @@ func (c *Controller) reviewAdmission(ctx context.Context, req *admv1beta1.Admiss
+ 		if err := json.Unmarshal(req.Object.Raw, pod); err != nil {
+ 			return errs.New(""unable to unmarshal %s/%s object: %v"", req.Kind.Version, req.Kind.Kind, err)
+ 		}
+-		return c.createPodEntry(ctx, pod)
++		return c.syncPodEntry(ctx, pod)
+ 	case admv1beta1.Delete:
+ 		return c.deletePodEntry(ctx, req.Namespace, req.Name)
+ 	default:","The PR description mentions that `The controller code is extended to react to ""add"" events`, but I don't see any additional cases added here beyond the existing Create and Delete... is there something I'm missing?",Why do we need to sync here?
+7456,"@@ -26,7 +26,7 @@ module Blacklight
+   ##
+   # An OpenStruct that responds to common Hash methods
+   class OpenStructWithHashAccess < OpenStruct
+-    delegate :keys, :each, :map, :has_key?, :empty?, :delete, :length, :reject!, :select!, :include, :fetch, :to_json, :as_json, :to => :to_h
++    delegate :keys, :each, :map, :has_key?, :include?, :empty?, :length, :delete, :delete_if, :keep_if, :clear, :reject!, :select!, :replace, :fetch, :to_json, :as_json, to: :to_h
+ 
+     if ::RUBY_VERSION < '2.0'
+       def []=(key, value)",Does it matter that #include changed to #include? ? I think the change makes sense since it aligns with the method name on Hash but unsure if anything called #include that would break with the change.,I don't think we need `:to => :to_h` here.
+7457,"@@ -92,7 +92,7 @@ const (
+ 
+ 	// minimumTaskCleanupWaitDuration specifies the minimum duration to wait before cleaning up
+ 	// a task's container. This is used to enforce sane values for the config.TaskCleanupWaitDuration field.
+-	minimumTaskCleanupWaitDuration = 1 * time.Minute
++	minimumTaskCleanupWaitDuration = time.Second
+ 
+ 	// minimumImagePullInactivityTimeout specifies the minimum amount of time for that an image can be
+ 	// 'stuck' in the pull / unpack step. Very small values are unsafe and lead to high failure rate.","LGTM, curious though why exactly this is in place, and are there any possible issues from not waiting long enough?",Why change this?
+7458,"@@ -104,7 +104,7 @@ module Beaker
+       #cleanup phase
+       rescue => e
+         #cleanup on error
+-        if @options[:preserve_hosts].to_s =~ /(never)/
++        if @options[:preserve_hosts].to_s =~ /(?:never)|(?:onpass)/
+           @logger.notify ""Cleanup: cleaning up after failed run""
+           if @network_manager
+             @network_manager.cleanup",?: is unnecessary because we already force preserve_hosts to be a string with to_s.,I think this should be `/(?:never|onpass)/
+7459,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent,Why do we need this?
+7460,"@@ -106,8 +106,8 @@ describe('debug with suspense', () => {
+ 
+ 				return loader.then(() => {
+ 					rerender();
+-					expect(console.warn).to.be.calledTwice;
+-					expect(warnings[1].includes('MyLazyLoaded')).to.equal(true);
++					expect(console.warn).to.be.calledThrice;
++					expect(warnings[2].includes('MyLazyLoaded')).to.equal(true);
+ 					expect(serializeHtml(scratch)).to.equal('<div>Hi there</div>');
+ 				});
+ 			});","Since lazy is re-rendered when mounting the fallback, these checks get triggered an additional time.",Why did this change?
+7461,"@@ -173,6 +173,10 @@ class AbstractWebElement(collections.abc.MutableMapping):
+         except KeyError:
+             return False
+ 
++    def is_content_editable_prop(self) -> bool:
++        """"""Get the value of this element's isContentEditable property.""""""
++        raise NotImplementedError
++
+     def _is_editable_object(self) -> bool:
+         """"""Check if an object-element is editable.""""""
+         if 'type' not in self:","There is a `is_content_editable()` method just above this, what's the difference?",Why do we need this?
+7462,"@@ -86,7 +86,7 @@ type PrometheusList struct {
+ type PrometheusSpec struct {
+ 	// PodMetadata configures Labels and Annotations which are propagated to the prometheus pods.
+ 	PodMetadata *EmbeddedObjectMetadata `json:""podMetadata,omitempty""`
+-	// ServiceMonitors to be selected for target discovery. *Deprecated:* if
++	// ServiceMonitors to be selected for target discovery. *Warning:* if
+ 	// neither this nor podMonitorSelector are specified, configuration is
+ 	// unmanaged.
+ 	ServiceMonitorSelector *metav1.LabelSelector `json:""serviceMonitorSelector,omitempty""`","Hmm, I'm not sure this is exactly what we want to get across. The behavior of leaving both values unset allowing the entire config to be managed is what is indeed deprecated. It's just that not the entire field is deprecated, just that one behavior.",Why is this a warnin
+7463,"@@ -146,10 +146,17 @@ static void complete_cb (struct bulk_exec *exec, void *arg)
+ static void output_cb (struct bulk_exec *exec, flux_subprocess_t *p,
+                        const char *stream,
+                        const char *data,
+-                       int data_len,
++                       int len,
+                        void *arg)
+ {
+     struct jobinfo *job = arg;
++    const char *cmd = flux_cmd_arg (flux_subprocess_get_cmd (p), 0);
++    jobinfo_log_output (job,
++                        flux_subprocess_rank (p),
++                        basename (cmd),
++                        stream,
++                        data,
++                        len);
+     flux_log (job->h, LOG_INFO, ""%ju: %d: %s: %s"",
+                       (uintmax_t) job->id,
+                       flux_subprocess_rank (p),","Given the slightly vague discussion in basename(3) about POSIX basename (modifies arg) vs GNU (doesn't), I always assumed it was advisable to pass a string copy However, I guess you'd get a ""discarding const"" warning promoted to error by our build system here if you were getting the POSIX implementation. Hah! Cool, I probably can go remove some memory copies in other parts of the code where those conditions exist.",`data_len` is no lon
+7464,"@@ -81,12 +81,12 @@ public class MetricManagerTest {
+   @Test
+   public void managerEmitterHandlingTest() throws Exception {
+     this.emitter.purgeAllData();
+-    final Date from = DateTime.now().minusMinutes(1).toDate();
++    final Date from = DateTime.now().minusMinutes(10).toDate();
+     this.metric.notifyManager();
+ 
+     this.emitterWrapper.countDownLatch.await(10L, TimeUnit.SECONDS);
+ 
+-    final Date to = DateTime.now().plusMinutes(1).toDate();
++    final Date to = DateTime.now().plusMinutes(10).toDate();
+     final List<InMemoryHistoryNode> nodes = this.emitter.getMetrics(""FakeMetric"", from, to, false);
+ 
+     assertEquals(""Failed to report metric"", 1, nodes.size());","Do you know somehow that this was the culprit? Even 1 minute is a lot, so I would expect the bug to lie somewhere else.",Why this change?
+7465,"@@ -146,7 +146,9 @@ void ActiveHostsMan::cleanExpiredHosts() {
+         LOG(INFO) << ""set "" << data.size() << "" expired hosts to offline in meta rocksdb"";
+         kvstore_->asyncMultiPut(kDefaultSpaceId, kDefaultPartId, std::move(data),
+                                 [] (kvstore::ResultCode code) {
+-            CHECK_EQ(code, kvstore::ResultCode::SUCCEEDED);
++            if (code != kvstore::ResultCode::SUCCEEDED) {
++                LOG(WARNING) << ""put failed, ret "" << static_cast<int32_t>(code);
++            }
+         });
+     }
+ }",what to do if some failed? just logging?,"nit: ""put failed"
+7466,"@@ -16,6 +16,19 @@ module Faker
+         fetch('quote.famous_last_words')
+       end
+ 
++      ##
++      # Produces a quote from Deep Thoughts by Jack Handey.
++      #
++      # @return [String]
++      #
++      # @example
++      #   Faker::Quote.deep_thoughts # => ""I hope life isn't a big joke, because I don't get it.""
++      #
++      # @faker.version next
++      def deep_thoughts
++        fetch('quote.deep_thoughts')
++      end
++
+       ##
+       # Produces a quote from Matz.
+       #",since these thoughts are all Jack Handey's the generator should probably be called `jack_handey` to reflect that.,This should be `
+7467,"@@ -288,6 +288,8 @@ type Container struct {
+ 
+ 	Environment map[string]*string `locationName:""environment"" type:""map""`
+ 
++	EnvironmentFiles []*EnvironmentFile `locationName:""environmentFiles"" type:""list""`
++
+ 	Essential *bool `locationName:""essential"" type:""boolean""`
+ 
+ 	FirelensConfiguration *FirelensConfiguration `locationName:""firelensConfiguration"" type:""structure""`",this file is autogenerated. you should edit `model/api/api-2.json` and then go generate this file. otherwise the next people generating api.go will remove the changes you added here,Why is this a li
+7468,"@@ -0,0 +1,8 @@
++class ProgressBarsController < ApplicationController
++
++  def show
++    _trail = Trail.find(params[:trail_id])
++    @trail = TrailWithProgress.new(_trail, user: current_user)
++    render layout: false
++  end
++end",Extra empty line detected at class body beginning.,Layout/TrailingBlankLines: Final newline missing.
+7469,"@@ -934,7 +934,9 @@ public class ExecutorManager extends EventHandler implements
+   @Override
+   public String submitExecutableFlow(ExecutableFlow exflow, String userId)
+     throws ExecutorManagerException {
+-    synchronized (exflow) {
++
++    String exFlowKey = exflow.getProjectName() + ""."" + exflow.getId() + "".submitFlow"";
++    synchronized (exFlowKey.intern()) {
+       String flowId = exflow.getFlowId();
+ 
+       logger.info(""Submitting execution flow "" + flowId + "" by "" + userId);",This is smart but hacky! I would probably prefer an alternate solution that would be more obvious to read/understand.,Why do we need this?
+7470,"@@ -115,7 +115,7 @@ type Client interface {
+ 	S3StreamingGet(ctx context.Context, region string, bucket string, key string) (io.ReadCloser, error)
+ 
+ 	DescribeTable(ctx context.Context, region string, tableName string) (*dynamodbv1.Table, error)
+-	UpdateTableCapacity(ctx context.Context, region string, tableName string, targetIndexRcu int64, targetIndexWcu int64) error
++	UpdateTableCapacity(ctx context.Context, region string, tableName string, targetTableRcu int64, targetTableWcu int64) (*dynamodbv1.Status, error)
+ 
+ 	Regions() []string
+ }",i would not return a pointer for status here which is an int,Why do we need to change this?
+7471,"@@ -67,6 +67,10 @@ exclude = [""AuthalicMatrixCoefficients"",
+            ""vnl_file_matrix"",
+            ""vnl_file_vector"",
+            ""vnl_fortran_copy"",
++           ""CosineWindowFunction"",
++           ""HammingWindowFunction"",
++           ""LanczosWindowFunction"",
++           ""WelchWindowFunction"",
+            ]
+ 
+ total = 0","Those functions are not currently wrapped, so I don't think it is necessary to exclude them (at least for now).",Why is this a<msg>I don't think it should be part
+7472,"@@ -89,6 +89,7 @@ class Uppy {
+         enterTextToSearch: 'Enter text to search for images',
+         backToSearch: 'Back to Search',
+         emptyFolderAdded: 'No files were added from empty folder',
++        folderAlreadyAdded: 'The folder was already added',
+         folderAdded: {
+           0: 'Added %{smart_count} file from %{folder}',
+           1: 'Added %{smart_count} files from %{folder}',",Should we specify the name of the folder?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+7473,"@@ -14,7 +14,7 @@ from rdkit import RDConfig, rdBase
+ from rdkit import DataStructs
+ from rdkit import Chem
+ import rdkit.Chem.rdDepictor
+-from rdkit.Chem import rdqueries
++from rdkit.Chem import rdqueries, rdmolops
+ 
+ from rdkit import __version__
+ ","it's not wrong, but you don't technical need `rdmolops` here since it's imported as part of `Chem`",This should be `from rdkit.Chem import rdqueries`
+7474,"@@ -534,6 +534,7 @@ class InfluxListenStore(ListenStore):
+ 
+             pxz.stdin.close()
+ 
++        pxz.wait()
+         self.log.info('ListenBrainz listen dump done!')
+         self.log.info('Dump present at %s!', archive_path)
+         return archive_path","I think the absence of this might have been the cause of the dump file corruption. We didn't wait for the pxz command to exit, leading to a race condition between the cp and this, leading to corrupted files in some places. I came across this because the hashes created and printed were different from the hashes of the actual files in dev also.",Why is this needed?
+7475,"@@ -27,7 +27,7 @@ type blockchainConfig struct {
+ }
+ 
+ type LoggingConfig struct {
+-	Level logging.Level `required:""true"" default:""debug""`
++	Level *logging.Level `required:""true"" default:""info""`
+ }
+ 
+ func NewConfig(path string) (*Config, error) {",Out of the scope.,Why is this needed?
+7476,"@@ -1,11 +1,11 @@
+ describe('ColumnSorting', () => {
+-  var id = 'testContainer';
++  const id = 'testContainer';
+ 
+   beforeEach(function() {
+     this.$container = $(`<div id=""${id}"" style=""overflow: auto; width: 300px; height: 200px;""></div>`).appendTo('body');
+ 
+-    this.sortByColumn = function(columnIndex) {
+-      var element = this.$container.find(`th span.columnSorting:eq(${columnIndex})`);
++    this.sort = function(columnIndex) {
++      const element = this.$container.find(`th span.columnSorting:eq(${columnIndex})`);
+ 
+       element.simulate('mousedown');
+       element.simulate('mouseup');",Maybe `sortByColumnHeader` would be more precise? The plugin has a method with the same name and it could be confusing.,`this.sortByColumn` -> `this.sort`
+7477,"@@ -36,7 +36,8 @@ export function diffChildren(
+ 	oldDom,
+ 	isHydrating
+ ) {
+-	let i, j, oldVNode, childVNode, newDom, firstChildDom, refs;
++	let i, j, oldVNode, childVNode, newDom, firstChildDom;
++	let refs = [];
+ 
+ 	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
+ 	// as EMPTY_OBJ._children should be `undefined`.",@developit I vaguely remember you mentioning something about some JS engines having an escape analysis feature that makes objects (and arrays?) locally declared that never leave the function essentially free from a GC perspective or something. Do you think we could benefit from that here? Or should we leave this as it is?,Why is this change needed?
+7478,"@@ -1252,6 +1252,8 @@ func invertOpForLocalNotifications(oldOp op) (newOp op, err error) {
+ 		}
+ 	case *GCOp:
+ 		newOp = op
++	case *resolutionOp:
++		newOp = op
+ 	}
+ 
+ 	// Now reverse all the block updates.  Don't bother with bare Refs",Remind me why this is needed?,Why is this needed?
+7479,"@@ -64,6 +64,14 @@ public final class ConstantScoreQuery extends Query {
+     return super.rewrite(reader);
+   }
+ 
++  @Override
++  public void visit(QueryVisitor visitor) {
++    QueryVisitor v = visitor.getSubVisitor(BooleanClause.Occur.FILTER, this);
++    if (v != null) {
++      query.visit(v);
++    }
++  }
++
+   /** We return this as our {@link BulkScorer} so that if the CSQ
+    *  wraps a query with its own optimized top-level
+    *  scorer (e.g. BooleanScorer) we can use that","same as above, can this be null now?",Why is this needed?
+7480,"@@ -319,8 +319,8 @@ public class SparkOrcWriter implements OrcValueWriter<InternalRow> {
+         // make sure the child is big enough
+         cv.child.ensureSize(cv.childCount, true);
+         // Add each element
+-        for (int e = 0; e < cv.lengths[rowId]; ++e) {
+-          children.addValue((int) (e + cv.offsets[rowId]), e, value, cv.child);
++        for (long e = 0; e < cv.lengths[rowId]; ++e) {
++          children.addValue((int) (e + cv.offsets[rowId]), (int) e, value, cv.child);
+         }
+       }
+     }",This doesn't make sense to me. Should `cv.lengths` be an integer array instead of longs? It looks like they should always be integers since the values are assigned from `ArrayData#numElements()`. That's very likely an int.,Why is this cast needed?
+7481,"@@ -1920,7 +1920,18 @@ namespace pwiz.Skyline.Model.Results
+                 }
+                 else if (id.StartsWith(MsDataFileImpl.PREFIX_PRECURSOR))
+                 {
+-                    precursor = double.Parse(id.Substring(MsDataFileImpl.PREFIX_TOTAL.Length), CultureInfo.InvariantCulture);
++                    var str = id.Substring(MsDataFileImpl.PREFIX_PRECURSOR.Length);
++                    if (!double.TryParse(str, NumberStyles.Float, CultureInfo.InvariantCulture, out precursor))
++                    {
++                        if (str.StartsWith(@""Q1=""))
++                        {
++                            str = str.Substring(3);
++                            var tail = str.IndexOf(' ');
++                            if (tail > 0)
++                                str = str.Substring(0, tail);
++                        }
++                        precursor = double.Parse(str, CultureInfo.InvariantCulture);
++                    }
+                     product = precursor;
+                 }
+                 else if (id.StartsWith(MsDataFileImpl.PREFIX_SINGLE))",str.Substring(3).Split(' ')[0] would also work and is more concise.,Why do we need this?
+7482,"@@ -198,7 +198,8 @@ void nano::node::keepalive (std::string const & address_a, uint16_t port_a, bool
+ 			{
+ 				auto endpoint (nano::map_endpoint_to_v6 (i->endpoint ()));
+ 				node_l->send_keepalive (endpoint);
+-				if (preconfigured_peer_a)
++				// Force insert only for local preconfigured peers
++				if (preconfigured_peer_a && node_l->config.allow_local_peers && node_l->peers.not_a_peer (endpoint, false))
+ 				{
+ 					node_l->peers.insert (endpoint, nano::protocol_version, true);
+ 				}",Did you mean to negate the not_a_peer check?,Shouldn't this be `node_
+7483,"@@ -1,6 +1,6 @@
+ /*
+  * DBeaver - Universal Database Manager
+- * Copyright (C) 2010-2021 DBeaver Corp and others
++ * Copyright (C) 2010-2017 Serge Rider (serge@jkiss.org)
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.",Copyright (C) 2010-2021 DBeaver Corp and others,Why did you change this?
+7484,"@@ -22,9 +22,8 @@
+ We use this to be able to highlight parts of the text.
+ """"""
+ 
+-import re
+ import html
+-
++import re
+ from PyQt5.QtWidgets import QStyle, QStyleOptionViewItem, QStyledItemDelegate
+ from PyQt5.QtCore import QRectF, QSize, Qt
+ from PyQt5.QtGui import (QIcon, QPalette, QTextDocument, QTextOption,",This seems like an unrelated change,Please don't change unrelated things.
+7485,"@@ -48,6 +48,10 @@ func (l *linuxStandardInit) Init() error {
+ 	runtime.LockOSThread()
+ 	defer runtime.UnlockOSThread()
+ 	if !l.config.Config.NoNewKeyring {
++		if err := label.SetKeyLabel(l.config.ProcessLabel); err != nil {
++			return err
++		}
++		defer label.SetKeyLabel("""")
+ 		ringname, keepperms, newperms := l.getSessionRingParams()
+ 
+ 		// Do not inherit the parent's session keyring.",Just to double-check -- are you sure this needs to be done *before* we create a new session? (Is `SetKeyLabel` setting what the label will be for all future keys or the label for the current key?),Why do we need this?
+7486,"@@ -47,6 +47,19 @@ using LocatorSelectorEntry = fastrtps::rtps::LocatorSelectorEntry;
+ using LocatorSelector = fastrtps::rtps::LocatorSelector;
+ using PortParameters = fastrtps::rtps::PortParameters;
+ 
++namespace eprosima {
++namespace fastdds {
++namespace rtps {
++    
++static constexpr SharedMemTransportDescriptor::OverflowPolicy shm_default_overflow_policy =
++            SharedMemTransportDescriptor::OverflowPolicy::DISCARD;
++
++
++} // namespace rtps
++} // namespace fastdds
++} // namespace eprosima
++
++
+ TransportInterface* SharedMemTransportDescriptor::create_transport() const
+ {
+     return new SharedMemTransport(*this);",I thought we were removing the FAIL policy altogether....,Why do we need this?
+7487,"@@ -14,7 +14,7 @@
+ 
+ def txt2tags_actionFunc(target,source,env):
+ 	import txt2tags
+-	txt2tags.exec_command_line([str(source[0])])
++	txt2tags.exec_command_line([""--outfile"", str(source[0])[:-3] + ""html"", str(source[0])])
+ 
+ def exists(env):
+ 	try:",Could you elaborate on why you made this change?,I don't think you need the `[:-3]`
+7488,"@@ -374,6 +374,9 @@ TEST(Scanner, Basic) {
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\110 \"""", TokenType::STRING, ""\\H ""),
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\\110 \"""", TokenType::STRING, ""\\\\110 ""),
+         CHECK_SEMANTIC_VALUE(""\""\\\\\\\\\110 \"""", TokenType::STRING, ""\\\\H ""),
++
++
++        CHECK_SEMANTIC_VALUE(""\""己所不欲，勿施于人\"""", TokenType::STRING, ""己所不欲，勿施于人""),
+     };
+ #undef CHECK_SEMANTIC_TYPE
+ #undef CHECK_SEMANTIC_VALUE","before the fix, does this sentence make service crash? My point is can you re-produce the problem. I'm not sure the bug is due to non-asiic code","CHECK_SEMANTIC_VALUE(""\""\\\\\\\\\110 \"""", TokenType::STRING, ""\\\\H ""),"
+7489,"@@ -86,7 +86,7 @@ func repoAssignment() macaron.Handler {
+ // Contexter middleware already checks token for user sign in process.
+ func reqToken() macaron.Handler {
+ 	return func(c *context.Context) {
+-		if !c.IsLogged {
++		if true != c.Data[""IsApiToken""] {
+ 			c.Error(401)
+ 			return
+ 		}","This comparison looks a bit strange, we should first check existence of key ""IsApiToken"" and then check if it is equal to true. ~~Besdies, s/IsApiToken/IsAuthedByToken/~~","Shouldn't this be `!c.Data[""IsApiToken""]`?"
+7490,"@@ -568,10 +568,12 @@ func (r *ReconcileClusterSync) applySyncSets(
+ 			ObservedGeneration: syncSet.AsMetaObject().GetGeneration(),
+ 			Result:             hiveintv1alpha1.SuccessSyncSetResult,
+ 		}
+-		if syncSet.GetSpec().ResourceApplyMode == hivev1.SyncResourceApplyMode {
++		applyMode := syncSet.GetSpec().ResourceApplyMode
++		if applyMode == hivev1.SyncResourceApplyMode {
+ 			newSyncStatus.ResourcesToDelete = resourcesApplied
+ 		}
+-		if syncSet.GetSpec().ResourceApplyMode == hivev1.UpsertResourceApplyMode && len(oldSyncStatus.ResourcesToDelete) > 0 {
++		// applyMode defaults to UpsertResourceApplyMode
++		if (applyMode == hivev1.UpsertResourceApplyMode || applyMode == """") && len(oldSyncStatus.ResourcesToDelete) > 0 {
+ 			logger.Infof(""resource apply mode is %v but there are resources to delete in clustersync status"", hivev1.UpsertResourceApplyMode)
+ 			oldSyncStatus.ResourcesToDelete = nil
+ 		}","This might be working as is, but I'm a bit thrown by the || and then && and how things get evaluated. Testing real quick on the go playground, true || false && false seems to either evaluate the && first, or start on the right side. Anyhow could you group with braces, it looks to me like it should be ( a || b) && c in this case?",Why do we default to `UpsertResourceApplyMode`?
+7491,"@@ -0,0 +1,17 @@
++// Copyright (c) 2020 IoTeX Foundation
++// This is an alpha (internal) release and is not suitable for production. This source code is provided 'as is' and no
++// warranties are given as to title or non-infringement, merchantability or fitness for purpose and, to the extent
++// permitted by law, all liability for your use of the code is disclaimed. This source code is governed by Apache
++// License 2.0 that can be found in the LICENSE file.
++
++package main
++
++import (
++	""github.com/iotexproject/iotex-core/ioctl/cmd""
++	""github.com/iotexproject/iotex-core/ioctl/cmd/account""
++)
++
++func main() {
++	account.CryptoSm2 = true
++	cmd.Execute()
++}",add an entry in makefile to generate binary with diff name?,I don't think this is needed.
+7492,"@@ -115,6 +115,10 @@ func validatePagerDutyConfigs(configs []monitoringv1alpha1.PagerDutyConfig) erro
+ 		if conf.RoutingKey == nil && conf.ServiceKey == nil {
+ 			return errors.New(""one of 'routingKey' or 'serviceKey' is required"")
+ 		}
++
++		if err := conf.HTTPConfig.Validate(); err != nil {
++			return err
++		}
+ 	}
+ 	return nil
+ }",hmm so we didn't validate the HTTP config for all receivers?,Why do we need this?
+7493,"@@ -49,5 +49,14 @@ namespace OpenTelemetry.Context.Propagation
+         /// <param name=""getter"">Function that will return string value of a key with the specified name.</param>
+         /// <returns>Span context from it's text representation.</returns>
+         SpanContext Extract<T>(T carrier, Func<T, string, IEnumerable<string>> getter);
++
++        /// <summary>
++        /// Tests if an activity context has been injected into a carrier.
++        /// </summary>
++        /// <typeparam name=""T"">Type of object to extract context from. Typically HttpRequest or similar.</typeparam>
++        /// <param name=""carrier"">Object to extract context from. Instance of this object will be passed to the getter.</param>
++        /// <param name=""getter"">Function that will return string value of a key with the specified name.</param>
++        /// <returns><see langword=""true"" /> if the carrier has been injected with an activity context.</returns>
++        bool IsInjected<T>(T carrier, Func<T, string, IEnumerable<string>> getter);
+     }
+ }","ITextFormatActivity had this, can I add to have the same effect?",Should this be `IsIn
+7494,"@@ -20,8 +20,11 @@ import (
+ 	""sync""
+ 	""time""
+ 
++	""github.com/aws/amazon-ecs-agent/agent/containerresource""
++	""github.com/aws/amazon-ecs-agent/agent/containerresource/containerstatus""
++
+ 	apicontainerstatus ""github.com/aws/amazon-ecs-agent/agent/api/container/status""
+-	apierrors ""github.com/aws/amazon-ecs-agent/agent/api/errors""
++	apierrors ""github.com/aws/amazon-ecs-agent/agent/apierrors""
+ 	""github.com/aws/amazon-ecs-agent/agent/credentials""
+ 	resourcestatus ""github.com/aws/amazon-ecs-agent/agent/taskresource/status""
+ ",not blocking: can we remove extra lines here?,I think this should 
+7495,"@@ -44,7 +44,7 @@ var PrivateKey = function PrivateKey(data, network, compressed) {
+   };
+ 
+   // detect type of data
+-  if (!data){
++  if (typeof(data) === 'undefined' || data === 'random'){
+     info.bn = PrivateKey._getRandomBN();
+   } else if (data instanceof BN) {
+     info.bn = data;",This just feels weird... can we use some kind of constant here? something like: `if (_.isUndefined(data) || data === PrivateKey.Random)`,`typeof(data) === 'u
+7496,"@@ -61,9 +61,12 @@ class ProjectorCompilerPass implements CompilerPassInterface
+             }
+ 
+             $parameters = $method->getParameters();
+-            $eventClass = (string) $parameters[0]->getType();
+ 
+-            $definition->addMethodCall('add', [new Reference($serviceId), $eventClass]);
++            $class = $parameters[0]->getClass();
++            if ($class) {
++                $eventClass = $class->getName();
++                $definition->addMethodCall('add', [new Reference($serviceId), $eventClass]);
++            }
+         }
+     }
+ }",if does not have a class I guess the exception should be thrown because we cannot recognize the type based on it?,Why is this change needed?
+7497,"@@ -262,12 +262,18 @@ public final class DiscoveryMethodModel implements MethodModel {
+   }
+ 
+   private DiscoveryField createFieldMaskField() {
++    // TODO(andrealin): Change this to a Set instead of a List.
+     return DiscoveryField.create(
+         StandardSchemaGenerator.createListSchema(
+             StandardSchemaGenerator.createStringSchema(
+                 """", SurfaceNamer.Cardinality.NOT_REPEATED, true),
+             DiscoveryMethodTransformer.FIELDMASK_STRING,
+-            true),
++            true,
++            ""The fields that should be serialized (empty values will be serialized). ""
++                + ""If the containing message object has a non-null fieldmask, ""
++                + ""then all the fields in the field mask (and only those fields in the field mask) ""
++                + ""will be serialized. If the containing object does not have a fieldmask, then ""
++                + ""only non-empty fields will be serialized. ""),
+         null);
+   }
+ ",LOL: use your GitHub username?,I don't think this is the 
+7498,"@@ -116,6 +116,16 @@ public class Key implements Comparable<Key> {
+     return toRawKey(Arrays.copyOf(value, value.length + 1));
+   }
+ 
++  /**
++   * nextPrefix key will be key with next available rid. For example, if the current key is
++   * prefix_rid, after calling this method, the return value should be prefix_rid+1
++   *
++   * @return a new key current rid+1.
++   */
++  public Key nextPrefix() {
++    return toRawKey(prefixNext(value));
++  }
++
+   /**
+    * The prefixNext key for bytes domain
+    *",any tests for nextPrefix() ?,`nextPrefix` -> `nextPrefi
+7499,"@@ -482,7 +482,7 @@ public class PrettyPrintVisitor implements VoidVisitor<Void> {
+         printMemberAnnotations(n.getAnnotations(), arg);
+         printModifiers(n.getModifiers());
+         if (!n.getVariables().isEmpty()) {
+-            n.getMaximumCommonType().accept(this, arg);
++            n.getMaximumCommonType().ifPresent(t -> t.accept(this, arg));
+         }
+ 
+         printer.print("" "");","In general I'm saying ""if there is no common type I'm just going to skip some stuff and fail silently.""",Why is this change needed?
+7500,"@@ -19,10 +19,10 @@ package v1alpha1
+ import (
+ 	""context""
+ 
++	""github.com/google/knative-gcp/pkg/logging""
+ 	corev1 ""k8s.io/api/core/v1""
+ 	""k8s.io/apimachinery/pkg/api/equality""
+ 	""knative.dev/eventing/pkg/apis/messaging""
+-	""knative.dev/eventing/pkg/logging""
+ 	""knative.dev/pkg/apis""
+ 
+ 	""github.com/google/knative-gcp/pkg/apis/configs/gcpauth""","did we move the eventing logging here? Probably the eventing logging was removing and they are now using the pkg logging in eventing. If that is the case, we should do the same here",nit: remove empty line
+7501,"@@ -50,8 +50,7 @@ type Filter func(*http.Request) bool
+ // the mux are wrapped with WithRouteTag. A Handler will add various attributes
+ // to the span using the core.Keys defined in this package.
+ type Handler struct {
+-	operation string
+-	handler   http.Handler
++	handler http.Handler
+ 
+ 	tracer           trace.Tracer
+ 	props            propagation.Propagators","I think that `Handler` should preserve the `operation` member and the span formatter should receive the operation name string as a parameter too, otherwise the `operation` parameter in the `NewHandler` function becomes useless if we pass a custom span formatter. Also, shouldn't it be called `spanNameFormatter`?",Why is this being remo
+7502,"@@ -67,7 +67,7 @@ class HSRPmd5(Packet):
+         ByteEnumField(""algo"", 0, {1: ""MD5""}),
+         ByteField(""padding"", 0x00),
+         XShortField(""flags"", 0x00),
+-        IPField(""sourceip"", None),
++        IPField(""sourceip"", ""127.0.0.1""),
+         XIntField(""keyid"", 0x00),
+         StrFixedLenField(""authdigest"", ""\00"" * 16, 16)]
+ ","Can you merge #466? That would make the current `None` default value working and more relevant that `""127.0.0.1""`.",Why is this change nee
+7503,"@@ -96,14 +96,15 @@ func (v *Validator) Validate(searchAttributes *commonpb.SearchAttributes, namesp
+ 	}
+ 
+ 	for saName, saPayload := range searchAttributes.GetIndexedFields() {
+-		if IsReservedField(saName) {
+-			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is Temporal reserved field name"", saName))
++		if !typeMap.IsDefined(saName) {
++			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is not a valid search attribute name"", saName))
+ 		}
+ 
+-		saType, err := typeMap.GetType(saName)
++		saType, err := typeMap.getType(saName, customCategory|predefinedCategory)
+ 		if err != nil {
+-			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s is not a valid search attribute name"", saName))
++			return serviceerror.NewInvalidArgument(fmt.Sprintf(""%s attribute can't be set in SearchAttributes: reserved field name"", saName))
+ 		}
++
+ 		_, err = DecodeValue(saPayload, saType)
+ 		if err != nil {
+ 			var invalidValue interface{}",is reserved filed name the only possible reason this could fail?,I think this should be
+7504,"@@ -169,6 +169,10 @@ func defaultLogPath(ctx Context) string {
+ 
+ // DefaultInitParams returns default init params
+ func DefaultInitParams(ctx Context) InitParams {
++	journalEnv := os.Getenv(""KBFS_ENABLE_JOURNAL"")
++	if journalEnv == """" {
++		journalEnv = ""true""
++	}
+ 	return InitParams{
+ 		Debug:            BoolForString(os.Getenv(""KBFS_DEBUG"")),
+ 		BServerAddr:      defaultBServer(ctx),",Would a KBFS_DISABLE_JOURNAL make more sense?,Why is this needed?
+7505,"@@ -40,6 +40,8 @@ void DropSpaceExecutor::execute() {
+         if (*spaceName_ == ectx()->rctx()->session()->spaceName()) {
+             ectx()->rctx()->session()->setSpace("""", -1);
+         }
++        ectx()->addWarningMsg(""Data will be deleted completely after restarting the services"");
++
+         doFinish(Executor::ProcessControl::kNext);
+     };
+ ",BTW. What's the message meaning?...,Shouldn't this be a
+7506,"@@ -289,4 +289,15 @@ describe Mongoid::Extensions::Object do
+       end
+     end
+   end
++
++  describe ""#numeric?"" do
++
++    let(:object) do
++      Object.new
++    end
++
++    it ""returns false"" do
++      expect(object.numeric?).to eq(false)
++    end
++  end
+ end",this should say false,I think this should
+7507,"@@ -1,3 +1,4 @@
++//go:build unit
+ // +build unit
+ 
+ // Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.",for my understanding - are this line and the next line both necessary? they seem to contain duplicate information. same for the other test files,//go:build unit
+7508,"@@ -102,6 +102,13 @@ def _get_search_url(txt):
+         engine = 'DEFAULT'
+     template = config.val.url.searchengines[engine]
+     url = qurl_from_user_input(template.format(urllib.parse.quote(term)))
++
++    if config.val.url.open_base_url and \
++            term in config.val.url.searchengines.keys():
++        url = qurl_from_user_input(config.val.url.searchengines[term])
++        url.setPath(None)
++        url.setFragment(None)
++        url.setQuery(None)
+     qtutils.ensure_valid(url)
+     return url
+ ","No need for the `.keys()`, iterating over a dictionary gives you its keys (and thus you can also do `key in some_dict`). With that, it also fits on one line :wink:","This should be `config.val.url.searchengines.get(term, DEFAULT)`"
+7509,"@@ -24,14 +24,6 @@ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {
+ 
+-IPLocator::IPLocator()
+-{
+-}
+-
+-IPLocator::~IPLocator()
+-{
+-}
+-
+ // Factory
+ void IPLocator::createLocator(
+         int32_t kindin,","If we want to avoid the user calling constructor and destructor, we should add `= delete` to their declarations. If we just want to avoid writing the default behavior, we should add `= default` to the declarations. I'm more in favor of the second option to avoid an API break.",Why was this removed?
+7510,"@@ -269,12 +269,12 @@ class GrapheneObjectStoreOperationResult(graphene.ObjectType):
+         return _to_metadata_entries(self.metadata_entries)  # pylint: disable=no-member
+ 
+ 
+-class GrapheneMaterialization(graphene.ObjectType):
++class GrapheneMaterializationOrObservation(graphene.ObjectType):
+     assetKey = graphene.Field(GrapheneAssetKey)
+ 
+     class Meta:
+         interfaces = (GrapheneDisplayableEvent,)
+-        name = ""Materialization""
++        name = ""MaterializationOrObservation""
+ 
+     def resolve_metadataEntries(self, _graphene_info):
+         from ...implementation.events import _to_metadata_entries",My preference here is to keep a stricter hierarchy. We should have a mixin or something that is an AssetEvent that Observation and Materialization can both inherit from. That way we can check the type in the frontend if we need to.,Shouldn't this be `GrapheneMaterializationOrObservation`?
+7511,"@@ -212,7 +212,7 @@ class SpatialPoolerTest(unittest.TestCase):
+ 
+     # Get only the active column indices
+     spOutput = [i for i, v in enumerate(activeArray) if v != 0]
+-    self.assertEqual(spOutput, expectedOutput)
++    self.assertEqual(sorted(spOutput), expectedOutput)
+ 
+ 
+   def testStripNeverLearned(self):",Can also cast them as `set`s and compare them.,Why do we need to sort?
+7512,"@@ -0,0 +1 @@
++package trigger",Still TODO I guess?,
+7513,"@@ -37,8 +37,6 @@
+ #include <fastdds/rtps/builtin/BuiltinProtocols.h>
+ #include <fastdds/rtps/builtin/liveliness/WLP.h>
+ 
+-#include <functional>
+-
+ using namespace eprosima::fastrtps;
+ using namespace ::rtps;
+ using namespace std::chrono;",Another cleanup. There are two additional `using namespace std::chrono;` under this one. Should also remove std::chrono:: from the full file. Please do this on a single commit.,W
+7514,"@@ -501,7 +501,7 @@ public final class JavaParserMetaModel {
+         enclosedExprMetaModel.getDeclaredPropertyMetaModels().add(enclosedExprMetaModel.innerPropertyMetaModel);
+         fieldAccessExprMetaModel.namePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""name"", com.github.javaparser.ast.expr.SimpleName.class, Optional.of(simpleNameMetaModel), false, false, false, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.namePropertyMetaModel);
+-        fieldAccessExprMetaModel.scopePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""scope"", com.github.javaparser.ast.expr.Expression.class, Optional.of(expressionMetaModel), true, false, false, false, false);
++        fieldAccessExprMetaModel.scopePropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""scope"", com.github.javaparser.ast.expr.Expression.class, Optional.of(expressionMetaModel), false, false, false, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.scopePropertyMetaModel);
+         fieldAccessExprMetaModel.typeArgumentsPropertyMetaModel = new PropertyMetaModel(fieldAccessExprMetaModel, ""typeArguments"", com.github.javaparser.ast.type.Type.class, Optional.of(typeMetaModel), true, false, true, false, false);
+         fieldAccessExprMetaModel.getDeclaredPropertyMetaModels().add(fieldAccessExprMetaModel.typeArgumentsPropertyMetaModel);","Looking at this list of boolean flags I wonder if we should create enums for all of these options, so that the code becomes much more readable",W
+7515,"@@ -29,8 +29,11 @@
+ #include <fastrtps/qos/QosPolicies.h>
+ #include <fastrtps/utils/TimeConversion.h>
+ 
++#include <rtps/builtin/data/ProxyHashTables.hpp>
++
+ #include <mutex>
+ #include <chrono>
++#include <unordered_set>
+ 
+ using namespace eprosima::fastrtps;
+ ",Is this necessary?,W
+7516,"@@ -0,0 +1,15 @@
++namespace Microsoft.Azure.Cosmos.CosmosElements
++{
++    internal abstract class CosmosElement
++    {
++        protected CosmosElement(CosmosElementType cosmosItemType)
++        {
++            this.Type = cosmosItemType;
++        }
++
++        public CosmosElementType Type
++        {
++            get;
++        }
++    }
++}",How about this NS inside query NS?,Why do we need this?
+7517,"@@ -53,7 +53,7 @@ func LoadOrCreateAccount(sm protocol.StateManager, encodedAddr string) (*state.A
+ }
+ 
+ // LoadAccount loads an account state
+-func LoadAccount(sm protocol.StateManager, addrHash hash.Hash160) (*state.Account, error) {
++func LoadAccount(sm protocol.StateReader, addrHash hash.Hash160) (*state.Account, error) {
+ 	var account state.Account
+ 	if err := sm.State(addrHash, &account); err != nil {
+ 		if errors.Cause(err) == state.ErrStateNotExist {","in line 79, sm also can be stateReader",`LoadAccount` is unu
+7518,"@@ -876,6 +876,13 @@ int32_t MetaClient::partsNum(GraphSpaceID spaceId) {
+     return it->second->partsAlloc_.size();
+ }
+ 
++std::unordered_map<HostAddr, std::vector<PartitionID>>
++MetaClient::partsBySpace(GraphSpaceID spaceId) {
++    folly::RWSpinLock::ReadHolder holder(localCacheLock_);
++    auto it = localCache_.find(spaceId);
++    CHECK(it != localCache_.end());
++    return it->second->partsOnHost_;
++}
+ 
+ folly::Future<StatusOr<TagID>>
+ MetaClient::createTagSchema(GraphSpaceID spaceId, std::string name, nebula::cpp2::Schema schema) {","maybe can not return a map directly, it will be modified by inner thread.",Why do we need a loc
+7519,"@@ -299,7 +299,7 @@ class Diff(unittest.TestCase):
+                                                     cmp_data)
+         # Unesolved core checkers.
+         test_res = {'core.NullDereference': 4, 'core.DivideZero': 3}
+-        self.assertDictEqual(diff_res, test_res)
++        self.assertDictContainsSubset(test_res, diff_res)
+ 
+     def test_get_diff_checker_counts_all_unresolved(self):
+         """"""","What is the actual change here, why is this test change needed? Now the diff will send back more data?",Why this change?
+7520,"@@ -89,6 +89,17 @@ int RGroupDecomposition::add(const ROMol &inmol) {
+   const bool addCoords = true;
+   MolOps::addHs(mol, explicitOnly, addCoords);
+ 
++  // mark any wildcards in input molecule:
++  for (auto &atom : mol.atoms()) {
++    if (atom->getAtomicNum() == 0) {
++      atom->setIsotope(1000U);
++      // clean any existing R group numbers
++      atom->setAtomMapNum(0);
++      if (atom->hasProp(common_properties::_MolFileRLabel)) {
++        atom->clearProp(common_properties::_MolFileRLabel);
++      }
++    }
++  }
+   int core_idx = 0;
+   const RCore *rcore = nullptr;
+   std::vector<MatchVectType> tmatches;",Might be better to use a tag here. I for one have used 1000 isotopes as a tag in the past...,I don't think this is the right way to do this. I think it should be done in the `MolOps::addHs` function.
+7521,"@@ -128,11 +128,11 @@ func TestSetName(t *testing.T) {
+ 	}
+ }
+ 
+-func TestRecordingIsOff(t *testing.T) {
++func TestRecordingIsOn(t *testing.T) {
+ 	tp, _ := NewProvider()
+ 	_, span := tp.Tracer(""Recording off"").Start(context.Background(), ""StartSpan"")
+ 	defer span.End()
+-	if span.IsRecording() == true {
++	if span.IsRecording() == false {
+ 		t.Error(""new span is recording events"")
+ 	}
+ }","This tests seems it was broken from the start :joy:. It ""worked"" because the old sample chance was small enough that this have always be off. Thanks for fixing this. Could you also change the strings on this test? `""Recording off""` and `""new span is recording events""`",Why is this change needed?
+7522,"@@ -44,6 +44,14 @@ public final class PmdParametersParseResult {
+         return !isError() && result.isHelp();
+     }
+ 
++    /**
++     * Returns whether parsing just requested the {@code --version} text.
++     * In this case no configuration is produced.
++     */
++    public boolean isVersion() {
++        return !isError() && result.isVersion();
++    }
++
+     /**
+      * Returns the error if parsing failed. Parsing may fail if required
+      * parameters are not provided, or if some parameters don't pass validation.","This is not actually the case, you need to modify `toConfiguration` below to prevent a configuration from being produced",nit: `isVersion` -> `hasVersion`
+7523,"@@ -88,7 +88,7 @@ func (a *attestor) loadSVID(ctx context.Context) (*x509.Certificate, *ecdsa.Priv
+ 
+ 	svid := a.readSVIDFromDisk()
+ 	if len(fResp.PrivateKey) > 0 && svid == nil {
+-		a.c.Log.Warn(""Private key recovered, but no SVID found"")
++		a.c.Log.Debug(""Private key recovered, but no SVID found"")
+ 	}
+ 
+ 	var keyData []byte",I'm worried about we hide some important log here,Why is this a debug message?
+7524,"@@ -625,7 +625,7 @@ def start_workers(actions_map, actions, context, analyzer_config_map,
+                            callback=lambda results: worker_result_handler(
+                                results, metadata, output_path,
+                                context.analyzer_binaries)
+-                           ).get(float('inf'))
++                           ).get(31557600)
+ 
+             pool.close()
+         except Exception:","Python 3 will throw an exception for inf, but not providing a timeout will result in no timeout exception.",Why did you change this?
+7525,"@@ -45,6 +45,18 @@ func (s *server) setupRouting() {
+ 		""POST"": http.HandlerFunc(s.chunkUploadHandler),
+ 	})
+ 
++	router.Handle(""/bzz-tag/name/{name}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getANewTag),
++	})
++
++	router.Handle(""/bzz-tag/addr/{addr}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getTagInfoUsingAddress),
++	})
++
++	router.Handle(""/bzz-tag/uuid/{uuid}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.getTagInfoUsingUUid),
++	})
++
+ 	s.Handler = web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""api access""),
+ 		handlers.CompressHandler,","As this method changes the state, it should be `POST`. Also, maybe to rename it to `createTag`?",I think this should be `
+7526,"@@ -24,6 +24,6 @@ func (e *Executor) ensureTrafficSplit(ctx context.Context) model.StageStatus {
+ 	return model.StageStatus_STAGE_SUCCESS
+ }
+ 
+-func (e *Executor) rollbackTraffic(ctx context.Context) model.StageStatus {
+-	return model.StageStatus_STAGE_SUCCESS
++func (e *Executor) rollbackTraffic(ctx context.Context) error {
++	return nil
+ }",`ctx` is unused in rollbackTraffic,Why do we need to return
+7527,"@@ -0,0 +1,12 @@
++
++using System;
++
++namespace SarifViewer
++{
++    internal sealed partial class Guids
++    {
++        public const string guidVSPackageString = ""b97edb99-282e-444c-8f53-7de237f2ec5e"";
++
++        public static Guid guidVSPackage = new Guid(guidVSPackageString);
++    }
++}",Roslyn conventions have const in PascalCase.,Why do we need this?
+7528,"@@ -112,7 +112,7 @@ public class ZookeeperStatusHandler extends RequestHandlerBase {
+           .map(h -> h.resolveClientPortAddress() + "":"" + h.clientPort)
+           .sorted().collect(Collectors.toList());
+       List<String> dynamicHosts = zkDynamicConfig.getServers().stream()
+-          .map(h -> h.resolveClientPortAddress() + "":"" + h.clientPort)
++          .map(h -> h.resolveClientPortAddress() + "":"" + (h.clientPort != null ? h.clientPort : ""2181""))
+           .sorted().collect(Collectors.toList());
+       if (!connStringHosts.containsAll(dynamicHosts)) {
+         errors.add(""Your ZK connection string ("" + connStringHosts.size() + "" hosts) is different from the "" +","This is not bullet proof if e.g. user has `clientPort=1234` in `zoo.cfg` and in zkHost connection string. Then we'll add a warning that dynamic config differs from zkHost, which is not entirely true since we just lack the port part. We have no way from client to read the `clientPort` from server except from connecting to the server with 4LW *ont the clientPort* which is a chicken and egg. This hack will make the comparison work for default port, which is a compromise.",Why do we need this change?
+7529,"@@ -1,8 +1,8 @@
+ #if MESSAGEPACK_2_1
+ using System;
+ using Datadog.Trace.ExtensionMethods;
+-using MessagePack;
+-using MessagePack.Formatters;
++using Datadog.Trace.Vendors.MessagePack;
++using Datadog.Trace.Vendors.MessagePack.Formatters;
+ 
+ namespace Datadog.Trace.Agent.MessagePack
+ {",We can probably delete this entire file. It's not used now and we'll (probably) write a custom serializer before we ever switch to MessagePack 2.1.,Why is this needed?
+7530,"@@ -174,8 +174,11 @@ class ConfigV1(Config):
+                 'limit': 'all',
+                 'playbook': 'playbook.yml',
+                 'raw_ssh_args': [
+-                    '-o UserKnownHostsFile=/dev/null', '-o IdentitiesOnly=yes',
+-                    '-o ControlMaster=auto', '-o ControlPersist=60s'
++                    '-o UserKnownHostsFile=/dev/null',
++                    '-o IdentitiesOnly=yes',
++                    '-o ControlMaster=auto',
++                    '-o ControlPersist=60s',
++                    '-o IdentitiesOnly=yes',
+                 ],
+                 'tags': False,
+                 'timeout': 30,",Aren't you duplicating this option?,Why is this change needed?
+7531,"@@ -440,6 +440,17 @@ func (a *Analyzer) IsBuildFile(uri lsp.DocumentURI) bool {
+ 	return a.State.Config.IsABuildFile(base)
+ }
+ 
++// IsBuildDefFile takes a uri path and check if it's a valid .build_defs file
++func (a *Analyzer) IsBuildDefFile(uri lsp.DocumentURI) bool {
++	filepath, err := GetPathFromURL(uri, ""file"")
++	if err != nil {
++		return false
++	}
++
++	base := path.Base(filepath)
++	return strings.HasSuffix(base, "".build_defs"")
++}
++
+ // e.g. src type:list, required:false
+ func getArgString(argument asp.Argument) string {
+ 	argType := strings.Join(argument.Type, ""|"")",I'm not sure we should be doing this based on the extension? Calling them `.build_defs` is just a convention,I'm not sure if this is the
+7532,"@@ -30,7 +30,6 @@ def unsupported_property(property_name, deprecated=False, reason=""""):
+ class _MissingPandasLikeIndex(object):
+ 
+     # Properties
+-    T = unsupported_property('T')
+     nbytes = unsupported_property('nbytes')
+     shape = unsupported_property('shape')
+ ",Should remove in `_MissingPandasLikeMultiIndex:` too,Why did you remove this?
+7533,"@@ -107,6 +107,10 @@ type AWSLoadBalancerSpec struct {
+ 	// Defaults to false.
+ 	// +optional
+ 	CrossZoneLoadBalancing bool `json:""crossZoneLoadBalancing,omitempty""`
++
++	// Subnets specifies the subnets that should be used by the load balancer
++	// +optional
++	Subnets Subnets `json:""subnets,omitempty""`
+ }
+ 
+ // AWSClusterStatus defines the observed state of AWSCluster","We should scope this down to the bits that we're actually using, otherwise the API is going to be problematic, as it includes references to NAT gateways and public and/or private subnets. Copying the types to be more local to the task in hand is fine.",I think this should be `
+7534,"@@ -45,6 +45,12 @@ type AWSDNSZoneSpec struct {
+ 	// to these tags,the DNS Zone controller will set a hive.openhsift.io/hostedzone tag
+ 	// identifying the HostedZone record that it belongs to.
+ 	AdditionalTags []AWSResourceTag `json:""additionalTags,omitempty""`
++
++	// Region is the AWS region to use for route53 operations.
++	// This defaults to us-east-1.
++	// For AWS China, use cn-northwest-1.
++	// +optional
++	Region string `json:""region,omitempty""`
+ }
+ 
+ // AWSResourceTag represents a tag that is applied to an AWS cloud resource",Is it is a hard requirement for this field to be 'cn-northwest-1' when wanting to interact with AWS China? It appears that putting in 'cn-north-1' would also result in using the alternative API endpoint (with the region overridden to use 'cn-northwest-1' for the created AWS client).,I'm not sure if this is 
+7535,"@@ -812,7 +812,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+             Assert.IsType<Http2StreamErrorException>(thrownEx.InnerException);
+         }
+ 
+-        [Fact]
++        [Fact(Skip=""Flaky test #2799"")]
+         public async Task ContentLength_Received_MultipleDataFramesOverSize_Reset()
+         {
+             IOException thrownEx = null;",Stephen already fixed this one. Only the OverSize test is flaky now right?,Why was this skipped?
+7536,"@@ -0,0 +1,6 @@
++<%= @activity %>
++
++<%= t(""mailer.proposal_link_text"",
++      proposal_url: proposal_url(@proposal)) %>
++
++<%= t(""mailer.footer"", feedback_url: feedback_url) %>","if the `activity_mailer` has a layout, should we include the footer in that? Realize there may also be conflicts with work @rememberlenny is working on...",I think this should be `@feedback_url`
+7537,"@@ -16,6 +16,12 @@ require 'ruby_smb'
+ ENV['RACK_ENV'] = 'test'
+ $LOAD_PATH.unshift File.join(__dir__, 'lib')
+ 
++# Disables internationalized strings, which shouldn't be needed for tests.
++# This gets around an issue where Puppet::Environment and GettextSetup in
++# r10k are fighting over the same text domain within the FastGettext domain.
++# https://github.com/voxpupuli/ra10ke/issues/39
++Puppet[:disable_i18n] = true
++
+ RSpec.shared_context 'reset puppet settings' do
+   after :each do
+     # reset puppet settings so that they can be initialized again","This makes me nervous, mostly because I don't know very much about it. Will users run into the gettext error in the wild? I can't reproduce it locally, but it's hard to be 100% sure. Is disabling gettext in Pal an option?",I'm not sure if this is the best way t
+7538,"@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
+   public void unassignExecutor(int executionId) throws ExecutorManagerException {
+     executionExecutorMapping.remove(executionId);
+   }
++
++  @Override
++  public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
++      throws ExecutorManagerException {
++    return new ArrayList<>();
++  }
+ }",Is Java smart enough to know the generic type here? Never knew this.,Why do we need this method?
+7539,"@@ -71,7 +71,7 @@ public class BackupRepositoryFactory {
+     PluginInfo repo = Objects.requireNonNull(backupRepoPluginByName.get(name),
+         ""Could not find a backup repository with name "" + name);
+ 
+-    BackupRepository result = loader.newInstance(repo.className, BackupRepository.class);
++    BackupRepository result = loader.newInstance(repo, BackupRepository.class);
+     result.init(repo.initArgs);
+     return result;
+   }",no thought given to reload,Why do we need this change?
+7540,"@@ -291,8 +291,17 @@ public abstract class ScheduledReporter implements Closeable, Reporter {
+         return shutdownExecutorOnStop;
+     }
+ 
+-    protected Set<MetricAttribute> getDisabledMetricAttributes() {
+-        return disabledMetricAttributes;
++    /**
++     * Check if Attribute disabled to be logged
++     * @param attribute metric attribute
++     * @return True if attribute is configured to be disabled
++     */
++    protected boolean isMetricAttributeDisabled(MetricAttribute attribute) {
++        if(disabledMetricAttributes != null && disabledMetricAttributes.contains(attribute)) {
++            return true;
++        }
++
++        return false;
+     }
+ 
+     private String calculateRateUnit(TimeUnit unit) {","Please, don't remove the `getDisabledMetricAttributes` method. All changes must be backward-compatible.",Why not just `return disabledMetricAttributes.contains(attribute)`?
+7541,"@@ -195,7 +195,11 @@ function prepareDatabaseForSuite(suite, context) {
+     .admin()
+     .command({ killAllSessions: [] })
+     .catch(err => {
+-      if (err.message.match(/no such (cmd|command)/) || err.code === 11601) {
++      if (
++        err.message.match(/no such (cmd|command)/) ||
++        err.message.match(/Failed to kill on some hosts/) ||
++        err.code === 11601
++      ) {
+         return;
+       }
+ ",Is this left over from debugging?,I think this should be `/Failed to kill on some hosts/`
+7542,"@@ -86,7 +86,7 @@ before(function(_done) {
+         }
+ 
+         this.configuration = new TestConfiguration(parsedURI, context);
+-        done();
++        client.close(done);
+       });
+     });
+   });",I've fallen for this before myself :) We _do_ call `close` inside of `done` on L65,Why is this needed?
+7543,"@@ -269,7 +269,9 @@ func (f *Fs) connect(ctx context.Context) (project *uplink.Project, err error) {
+ 	fs.Debugf(f, ""connecting..."")
+ 	defer fs.Debugf(f, ""connected: %+v"", err)
+ 
+-	cfg := uplink.Config{}
++	cfg := uplink.Config{
++		UserAgent: ""rclone"",
++	}
+ 
+ 	project, err = cfg.OpenProject(ctx, f.access)
+ 	if err != nil {","That looks fine! You could use `""rclone/""+fs.Version` too if you wanted. BTW does tardigrade use http under the hood? If you were using rclone's http Client then you'd get a User-Agent and you'd also get support for `-vv --dump bodies` and other nice things.",I think this should be `rclone`
+7544,"@@ -260,6 +260,10 @@ class FreeAnchorRetinaHead(RetinaHead):
+             Tensor: Negative bag loss in shape (num_img, num_anchors, num_classes).
+         """"""  # noqa: E501, W605
+         prob = cls_prob * (1 - box_prob)
+-        negative_bag_loss = prob**self.gamma * F.binary_cross_entropy(
+-            prob, torch.zeros_like(prob), reduction='none')
+-        return (1 - self.alpha) * negative_bag_loss
++        neg_prob = 1 - prob
++        # There are some cases when neg_prob = 0.
++        # This will cause the neg_prob.log() to be inf without clamp.
++        neg_prob = torch.clamp(neg_prob, min=1e-12)
++        negative_bag_loss = -prob**self.gamma * neg_prob.log()
++        negative_bag_loss = (1 - self.alpha) * negative_bag_loss
++        return negative_bag_loss","Adding one line `prob = prob.clamp(min=EPS, max=1-EPS)` already works.",Why do we need to clamp here?
+7545,"@@ -118,7 +118,15 @@ namespace NLog.Targets.Wrappers
+         /// <param name=""overflowAction"">The action to be taken when the queue overflows.</param>
+         public AsyncTargetWrapper(Target wrappedTarget, int queueLimit, AsyncTargetWrapperOverflowAction overflowAction)
+         {
+-            RequestQueue = new AsyncRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#if NETSTANDARD2_0
++            // NetStandard20 includes many optimizations for ConcurrentQueue:
++            //  - See: https://blogs.msdn.microsoft.com/dotnet/2017/06/07/performance-improvements-in-net-core/
++            // Net40 ConcurrencyQueue can seem to leak, because it doesn't clear properly on dequeue
++            //  - See: https://blogs.msdn.microsoft.com/pfxteam/2012/05/08/concurrentqueuet-holding-on-to-a-few-dequeued-elements/
++            _requestQueue = new ConcurrentRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#else
++            _requestQueue = new AsyncRequestQueue(10000, AsyncTargetWrapperOverflowAction.Discard);
++#endif
+             TimeToSleepBetweenBatches = 50;
+             BatchSize = 200;
+             FullBatchSizeWriteLimit = 5;","another option would be to create a `CreateRequestQueue(bool lockingQeueue)`, and set it only in `InitializeTarget`, isn't? The would prefer having the creation and ""business"" rules for the creation in one region, I think `InitializeTarget` would be the best place.",I don't think this is the rig
+7546,"@@ -805,7 +805,7 @@ static void subsurface_handle_place_above(struct wl_client *client,
+ 	}
+ 
+ 	wl_list_remove(&subsurface->parent_pending_link);
+-	wl_list_insert(sibling->parent_pending_link.prev,
++	wl_list_insert(&sibling->parent_pending_link,
+ 		&subsurface->parent_pending_link);
+ 
+ 	subsurface->reordered = true;","Wait, I think the `subsurface_handle_place_above` code was correct before. `place_above` means ""place it above in rendering order"" right?",Why did you remove the `.prev
+7547,"@@ -4,9 +4,10 @@ public class Test {
+     /**
+      * Docstring that looks like a list:
+      *
+-     * <p>1. hey 2. there
++     * 1. hey
++     * 2. there
+      *
+-     * <p>with blank line.
++     * with blank line.
+      */
+     Void test() {
+         /*",why did this change?,Why did you change this?
+7548,"@@ -15,12 +15,13 @@ import (
+ )
+ 
+ func TestBareRootMetadataVersionV3(t *testing.T) {
+-	tlfID := tlf.FakeID(1, false)
++	tlfID := tlf.FakeID(1, tlf.Private)
+ 
+ 	// All V3 objects should have SegregatedKeyBundlesVer.
+ 
+ 	uid := keybase1.MakeTestUID(1)
+-	bh, err := tlf.MakeHandle([]keybase1.UID{uid}, nil, nil, nil, nil)
++	bh, err := tlf.MakeHandle(
++		[]keybase1.UserOrTeamID{uid.AsUserOrTeam()}, nil, nil, nil, nil)
+ 	require.NoError(t, err)
+ 
+ 	rmd, err := MakeInitialBareRootMetadataV3(tlfID, bh)",Do you think we should have some tests here for `tlf.SingleTeam` too?,Why did you change this?
+7549,"@@ -1,6 +1,8 @@
+ package table
+ 
+-import ""github.com/influxdata/flux""
++import (
++	""github.com/influxdata/flux""
++)
+ 
+ // Copy returns a buffered copy of the table and consumes the
+ // input table. If the input table is already buffered, it ""consumes""",No problem with this but might as well revert this file since nothing else changed.,Why is this needed?
+7550,"@@ -14,18 +14,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         /// </summary>
+         public static void Register()
+         {
+-            Tracer.Instance = new Tracer(
+-                settings: null,
+-                agentWriter: null,
+-                sampler: null,
+-                scopeManager: new AspNetScopeManager(),
+-                statsd: null);
+-
+-            if (Tracer.Instance.Settings.IsIntegrationEnabled(AspNetHttpModule.IntegrationName))
+-            {
+-                // only register http module if integration is enabled
+-                HttpApplication.RegisterModule(typeof(AspNetHttpModule));
+-            }
++            HttpApplication.RegisterModule(typeof(AspNetHttpModule));
+         }
+     }
+ }","In my changes, I did not create a new `AspNetScopeManager`. I'm not familiar with it enough to know if this is a valid change or not",Why is this no longer ne
+7551,"@@ -0,0 +1,3 @@
++export default message => {
++  throw new Error(message);
++};","Not cool with this. I think we talked about it in past. This is a side effect. If we want to introduce the side effect in our functions like `inRange` (which I am for) the side effect (error) should originate in that function and not in some internal `throwError` function. Every stacktract will start at line `2` of `trowError.js`. Been there, done that and falled back to throwing the error from the place where it should be thrown.",
+7552,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+ 
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+ 
+   @Override",We don't need this additional method.,Why do we need these methods?
+7553,"@@ -44,11 +44,10 @@ public class DelegatingOAuth2UserServiceTests {
+ 	}
+ 
+ 	@Test(expected = IllegalArgumentException.class)
+-	@SuppressWarnings(""unchecked"")
+ 	public void loadUserWhenUserRequestIsNullThenThrowIllegalArgumentException() {
+ 		DelegatingOAuth2UserService<OAuth2UserRequest, OAuth2User> delegatingUserService =
+ 			new DelegatingOAuth2UserService<>(
+-				Arrays.asList(mock(OAuth2UserService.class), mock(OAuth2UserService.class)));
++				Arrays.asList(mock(DefaultOAuth2UserService.class), mock(DefaultOAuth2UserService.class)));
+ 		delegatingUserService.loadUser(null);
+ 	}
+ ",The purpose of this test is to ensure that the `OAuth2UserRequest` passed into `loadUser` is **not** null else throw `IllegalArgumentException`. Changing the `List` of `OAuth2UserService` mocks to `DefaultOAuth2UserService` doesn't really apply to what is being tested here. Please revert this. Thank you.,Why is this change needed?
+7554,"@@ -124,7 +124,7 @@ func NewProtocol(
+ 	getkickoutList GetKickoutList,
+ 	getUnproductiveDelegate GetUnproductiveDelegate,
+ 	electionCommittee committee.Committee,
+-	stakingV2 *staking.Protocol,
++	stakingProto *staking.Protocol,
+ 	getBlockTimeFunc GetBlockTime,
+ 	productivity Productivity,
+ 	getBlockHash evm.GetBlockHash,",nit: rename to nativeStk? proto might lead to think protobuf,`stakingProto` is unused (fro
+7555,"@@ -28,6 +28,9 @@ import org.apache.solr.common.util.StrUtils;
+ public interface ShardParams {
+   /** the shards to use (distributed configuration) */
+   String SHARDS = ""shards"";
++
++  /** UUID of the query */
++  String QUERY_ID = ""queryID"";
+   
+   /** per-shard start and rows */
+   String SHARDS_ROWS = ""shards.rows"";",Why not `queryUUID` (and reference the same constant as in other places)?,Why do we need this?
+7556,"@@ -36,9 +36,9 @@ import (
+ )
+ 
+ const (
+-	invalidTrustDomainAttestedNode = ""An attested node with trust domain '%v' has been detected, "" +
++	invalidTrustDomainAttestedNode = ""an attested node with trust domain '%v' has been detected, "" +
+ 		""which does not match the configured trust domain of '%v'. Agents may need to be reconfigured to use new trust domain""
+-	invalidTrustDomainRegistrationEntry = ""A registration entry with trust domain '%v' has been detected, "" +
++	invalidTrustDomainRegistrationEntry = ""a registration entry with trust domain '%v' has been detected, "" +
+ 		""which does not match the configured trust domain of '%v'. If you want to change the trust domain, "" +
+ 		""please delete all existing registration entries""
+ 	invalidSpiffeIDRegistrationEntry = ""registration entry with id %v is malformed because invalid SPIFFE ID: %v""","This is also used to log, of which our convention is leading uppercase...",nit: typo in the commit message
+7557,"@@ -131,7 +131,7 @@ class ReusedSQLTestCase(unittest.TestCase, SQLTestUtils):
+         # Please see databricks/koalas/conftest.py.
+         pass
+ 
+-    def assertPandasEqual(self, left, right):
++    def assertPandasEqual(self, left, right, less_precise=False):
+         if isinstance(left, pd.DataFrame) and isinstance(right, pd.DataFrame):
+             try:
+                 pd.util.testing.assert_frame_equal(",What about we just name it `check_exact`?,Why is this necessary?
+7558,"@@ -205,9 +205,10 @@ public abstract class SpanStoreTest {
+   }
+ 
+   @Test
+-  public void getAllServiceNames() {
++  public void getAllServiceNames_mergesAnnotation_andBinaryAnnotation() {
++    // creates a span with mutual exclusive endpoints in binary annotations and annotations
+     BinaryAnnotation yak = BinaryAnnotation.address(""sa"", Endpoint.create(""yak"", 127 << 24 | 1));
+-    accept(span1.toBuilder().addBinaryAnnotation(yak).build(), span4);
++    accept(span1.toBuilder().binaryAnnotations(asList(yak)).build());
+ 
+     // should be in order
+     assertThat(store().getServiceNames()).containsExactly(""service"", ""yak"");","before, a binary annotation had the same service name as a regular annotation, masking the bug where we weren't querying the latter",I think this test should be ren
+7559,"@@ -1,4 +1,6 @@
+ class Exercise < ActiveRecord::Base
++  AVERAGE_COMPLETION_TIME_IN_MINUTES = 7
++
+   has_many :statuses, as: :completeable, dependent: :destroy
+   has_one :trail, through: :step, as: :completeables
+   has_one :step, dependent: :destroy, as: :completeable",Where does the `7` come from?,I don't think this is used anyw
+7560,"@@ -48,7 +48,7 @@ export default function CountrySelect() {
+ 				timezone: countriesByCode[ newCountryCode ].defaultTimeZoneId,
+ 			} );
+ 		}
+-	}, [ setValues ] );
++	}, [ setValues, value ] );
+ 
+ 	return (
+ 		<Select",I don't know how we haven't got bugs from some of these! As here this would have had a stale `value`,Why do we need to pass the value here?
+7561,"@@ -199,6 +199,9 @@ public class SparkCatalog extends BaseCatalog {
+           setSnapshotId = set;
+         } else if (""cherry-pick-snapshot-id"".equalsIgnoreCase(set.property())) {
+           pickSnapshotId = set;
++        } else if (""sort-order"".equalsIgnoreCase(set.property())) {
++          throw new UnsupportedOperationException(""'sort-order' is a reserved table property. Please use the command "" +
++                  ""'ALTER TABLE ... WRITE ORDERED BY' to specify it."");
+         } else {
+           propertyChanges.add(set);
+         }","One nit here I forgot about this before but we usually structure error messages as ""Cannot X because Y. Then the recommendation goes here"" I would also recommend not using ""it"" in the message since it the pronoun is a bit ambiguous. ""to specify write sort-order"" may be clearer",I don't think this is the right place 
+7562,"@@ -26,7 +26,8 @@ import {
+ } from '../../../../../tests/js/utils';
+ import * as CacheModule from '../../../googlesitekit/api/cache';
+ import { STORE_NAME } from './constants';
+-import initialState, {
++import {
++	initialState,
+ 	FEATURE_TOUR_COOLDOWN_SECONDS,
+ 	FEATURE_TOUR_LAST_DISMISSED_AT,
+ } from './feature-tours';",I'm surprised this worked at all! It was importing the default export but `eslint-plugin-import` warned me `warning Using exported name 'initialState' as identifier for default export import/no-named-as-default`,Why this change?
+7563,"@@ -1,10 +1,9 @@
+ class VideoTutorial < Product
+-  has_many :teachers, dependent: :destroy
+-  has_many :users, through: :teachers
++  validates :description, :tagline, presence: true
+ 
+-  # Validations
+-  validates :description, presence: true
+-  validates :tagline, presence: true
++  def teachers
++    Teacher.joins(:video).merge(videos)
++  end
+ 
+   def collection?
+     published_videos.count > 1",This was used in `app/views/video_tutorials/_video_tutorial_details.html.erb` how are we handling that now?,Why not just `Teacher.joins(:video).me
+7564,"@@ -8,8 +8,9 @@ var (
+ 	newlineTabRE           = regexp.MustCompile(`\n\t`)
+ 	certificateTimeErrorRE = regexp.MustCompile(`: current time \S+ is after \S+`)
+ 	// aws
+-	awsRequestIDRE   = regexp.MustCompile(`(, )*(?i)(request id: )(?:[-[:xdigit:]]+)`)
+-	awsNotAuthorized = regexp.MustCompile(`(User: arn:aws:sts::)\S+(:assumed-role/[^/]+/)\S+( is not authorized to perform: \S+ on resource: arn:aws:iam::)[^:]+(:\S+)`)
++	awsRequestIDRE    = regexp.MustCompile(`(, )*(?i)(request id: )(?:[-[:xdigit:]]+)`)
++	awsNotAuthorized  = regexp.MustCompile(`(User: arn:aws:sts::)\S+(:assumed-role/[^/]+/)\S+( is not authorized to perform: \S+ on resource: arn:aws:iam::)[^:]+(:\S+)`)
++	awsEncodedMessage = regexp.MustCompile(`(Encoded authorization failure message: )\S+(,)`)
+ 	// azure
+ 	azureErrorDescriptionRE = regexp.MustCompile(`\""error_description\"":\""(.*?)\\r\\n`)
+ )","Is `\S+` really the right thing? Anybody know what kind of encoding this is? Perhaps if we know it doesn't have commas, we can just use `[^,]+`. Also, parens around the comma are unnecessary, since we're not using the capture group.",I think we can remove the `\S+` here.
+7565,"@@ -1,10 +1,8 @@
+ tests = [
++  (""python"", ""UnitTestDocTests.py"", {}),
+   (""python"", ""UnitTestcBitVect.py"", {}),
+   (""python"", ""UnitTestBitEnsemble.py"", {}),
+   (""python"", ""UnitTestTopNContainer.py"", {}),
+-  (""python"", ""BitUtils.py"", {}),
+-  (""python"", ""VectCollection.py"", {}),
+-  (""python"", ""LazySignature.py"", {}),
+ ]
+ longTests = []
+ ",This block of changes looks like you removed tests without replacing them anywhere. Did I miss something?,Why are these removed?
+7566,"@@ -360,7 +360,10 @@ struct atom_wrapper {
+         .def(""GetPropNames"", &Atom::getPropList, (python::arg(""self"")),
+              ""Returns a list of the properties set on the Atom.\n\n"")
+ 
+-        .def(""GetPropsAsDict"", GetPropsAsDict<Atom>, (python::arg(""self"")),
++        .def(""GetPropsAsDict"", GetPropsAsDict<Atom>, (python::arg(""self""),
++                                                      python::arg(""includePrivate"") = true,
++                                                      python::arg(""includeComputed"") = true
++                                                      ),
+              ""Returns a dictionary of the properties set on the Atom.\n""
+              "" n.b. some properties cannot be converted to python types.\n"")
+         ",n.b. private and computed values are now exposed to the API. They were hidden/not exposed before.,I don't think we want to includeCompu
+7567,"@@ -285,6 +285,13 @@ class WebElementWrapper(collections.abc.MutableMapping):
+         tag = self._elem.tagName().lower()
+         return self.get('role', None) in roles or tag in ('input', 'textarea')
+ 
++    def remove_target(self):
++        """"""Remove target from link""""""
++        if self._elem.tagName().lower() == 'a':
++            self._elem.removeAttribute('target')
++        elif self.parent().tagName().lower() == 'a':
++            self.parent().removeAttribute('target')
++
+     def debug_text(self):
+         """"""Get a text based on an element suitable for debug output.""""""
+         self._check_vanished()",Nitpick: Please add a period after `link` :wink:,This should be `self.parent().removeA
+7568,"@@ -67,5 +67,8 @@ func (hs *HandlerStub) Start() {
+ 		klog.Errorf(""New upstream controller failed with error: %v"", err)
+ 		return
+ 	}
+-	upstream.Start()
++	if err := upstream.Start(); err != nil {
++		klog.Errorf(""Failed to start upstream with error: %v"", err)
++		return
++	}
+ }","we got no chance that `err` is not nil here, need to revisit how `NewUpstreamController` is defined.",Why do we need to return here?
+7569,"@@ -247,7 +247,8 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+         .put(GET_LOG, post(""/session/:sessionId/log""))
+         .put(GET_AVAILABLE_LOG_TYPES, get(""/session/:sessionId/log/types""))
+ 
+-        .put(STATUS, get(""/status""));
++        .put(STATUS, get(""/status""))
++        .put(HEAP_SNAPSHOT, get(""/session/:sessionId/chromium/heap_snapshot""));
+ 
+         nameToUrl = builder.build();
+   }","Instead of building in routing for a browser-specific command, could you refactor the HttpCommandExecutor to allow arbitrary commands to be registered?",I think this should be `GET_HE
+7570,"@@ -348,6 +348,12 @@ module RSpec::Core
+     end
+ 
+     describe ""#its"" do
++
++      it ""should issue deprecation warning"" do
++        expect_deprecation_with_call_site(__FILE__, __LINE__+1, '""its"" method')
++        RSpec::Core::ExampleGroup.its(nil) {}
++      end
++
+       subject do
+         Class.new do
+           def initialize","It'd be nice to assert the right deprecation is being raised, just add a third argument of `/""its"" method/`",Extra empty line detected at b
+7571,"@@ -87,6 +87,8 @@ public class TableProperties {
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ 
++  public static final String LOCATION_PROVIDER_IMPL = ""write.location-provider.impl"";
++
+   public static final String OBJECT_STORE_PATH = ""write.object-storage.path"";
+ 
+   // This only applies to files written after this property is set. Files previously written aren't",Do we want to add this to the docs?,This should be `write.object-s
+7572,"@@ -46,7 +46,7 @@ func AssertGRPCStatus(tb testing.TB, err error, code codes.Code, message string)
+ 	st := status.Convert(err)
+ 
+ 	ok := true
+-	if !assert.Equal(tb, code, st.Code(), ""GRPC status code does not match"") {
++	if !assert.Equal(tb, code.String(), st.Code().String(), ""GRPC status code does not match"") {
+ 		ok = false
+ 	}
+ 	if !assert.Equal(tb, message, st.Message(), ""GRPC status message does not match"") {",This isn't really related but makes debugging test failures much easier since you see the string representation of the code instead of the integer value.,Shouldn't this be `.String()`?
+7573,"@@ -130,6 +130,18 @@ bool ValueObjectVariable::UpdateValue() {
+   m_error.Clear();
+ 
+   Variable *variable = m_variable_sp.get();
++  // Check if the type has size 0. If so, there is nothing to update.
++  CompilerType var_type(GetCompilerTypeImpl());
++  if (var_type.IsValid()) {
++    ExecutionContext exe_ctx(GetExecutionContextRef());
++    llvm::Optional<uint64_t> size =
++      var_type.GetByteSize(exe_ctx.GetBestExecutionContextScope());
++    if (size && *size == 0) {
++      m_value.SetCompilerType(var_type);
++      return m_error.Success();
++    }
++  }
++
+   DWARFExpression &expr = variable->LocationExpression();
+ 
+   if (variable->GetLocationIsConstantValueData()) {",Because of this new early exit.,I'm not sure if this is the be
+7574,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?,I think this should be `W3C`
+7575,"@@ -150,12 +150,16 @@ public abstract class PrivacyApiGroupJsonRpcMethods extends ApiGroupJsonRpcMetho
+ 
+   private JsonRpcMethod createPrivacyMethod(
+       final PrivacyParameters privacyParameters, final JsonRpcMethod rpcMethod) {
+-    if (rpcMethod.getName().equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
++    final String methodName = rpcMethod.getName();
++    if (methodName.equals(RpcMethod.ETH_SEND_RAW_PRIVATE_TRANSACTION.getMethodName())) {
++      return rpcMethod;
++    } else if (methodName.equals(RpcMethod.PRIV_DISTRIBUTE_RAW_TRANSACTION.getMethodName())
++        && privacyParameters.getGoQuorumPrivacyParameters().isPresent()) {
+       return rpcMethod;
+     } else if (privacyParameters.isEnabled() && privacyParameters.isMultiTenancyEnabled()) {
+       return new MultiTenancyRpcMethodDecorator(rpcMethod);
+     } else if (!privacyParameters.isEnabled()) {
+-      return new DisabledPrivacyRpcMethod(rpcMethod.getName());
++      return new DisabledPrivacyRpcMethod(methodName);
+     } else {
+       return rpcMethod;
+     }",can this be removed now?,nit: can we use `equalsIgnoreC
+7576,"@@ -213,8 +213,11 @@ static pmix_status_t initialize_server_base(pmix_server_module_t *module)
+     }
+ 
+     /* for now, just setup the v1.1 series rendezvous point
+-     * we use the pid to reduce collisions */
+-    if (0 > asprintf(&pmix_pid, ""%s/pmix-%d"", tdir, mypid)) {
++     * - use userid to avoid situation where user with other UID but same PID 
++     *   has created the usock and terminate abnormally and we have no way to
++     *   remove the file
++     * - use the pid to reduce collisions */
++    if (0 > asprintf(&pmix_pid, ""%s/pmix-%d.%d"", tdir, getuid(), mypid)) {
+         return PMIX_ERR_NOMEM;
+     }
+ ",This is going to create a problem - we are already encountering issues with the length of the usock pathname on recent Linux kernels as the temp directory base has moved down to the var directory under a name created by a hash. So adding another field to it is going to add to the problem.,I don't understand why we need to use `getuid()` here.
+7577,"@@ -31,3 +31,13 @@ type ApplicationGetter interface {
+ type ApplicationCreator interface {
+ 	CreateApplication(app *Application) error
+ }
++
++const (
++	// AppCfnTemplateNameFormat is the base output file name when `app package`
++	// is called. This is also used to render the pipeline CFN template.
++	AppCfnTemplateNameFormat = ""%s.stack.yml""
++	// AppCfnTemplateConfigurationNameFormat is the base output configuration
++	// file name when `app package` is called. It's also used to render the
++	// pipeline CFN template.
++	AppCfnTemplateConfigurationNameFormat = ""%s-%s.params.json""
++)",What do you think about moving this to the `cloudformation` pkg?,nit: can we call this `AppCfnTemplateConfigNameFormat`
+7578,"@@ -63,6 +63,11 @@ abstract class BaseProvider implements MediaProviderInterface
+      */
+     protected $name;
+ 
++    /**
++     * @var array
++     */
++    protected $clones = [];
++
+     /**
+      * @param string             $name
+      * @param Filesystem         $filesystem",Please make this private by default,Why do we need this?
+7579,"@@ -16,6 +16,12 @@
+  */
+ package org.camunda.bpm.engine.impl.util.xml;
+ 
++import org.camunda.bpm.engine.impl.ProcessEngineLogger;
++import org.camunda.bpm.engine.impl.cfg.ProcessEngineConfigurationImpl;
++import org.camunda.bpm.engine.impl.context.Context;
++import org.camunda.bpm.engine.impl.util.EngineUtilLogger;
++
++import javax.xml.XMLConstants;
+ import javax.xml.parsers.SAXParser;
+ import javax.xml.parsers.SAXParserFactory;
+ ","We can add `@Override` annotations to all of the implementations of this method. I think this is a best practice for us, but it would be nicer in any case.",Why do we need this?
+7580,"@@ -7,5 +7,11 @@ type Resolver interface {
+ 
+ // Detector allows detecting location by current ip
+ type Detector interface {
+-	DetectCountry() (string, error)
++	DetectLocation() (Location, error)
++}
++
++// Cache allows caching location
++type Cache interface {
++	Get() (Location, error)
++	RefreshAndGet() (Location, error)
+ }","Most of uses of `RefreshAndGet` seems to be made only for `Refresh` part, result is ignored. We can simplify this method to assigning single responsibility to it - just `Refresh()`.",Why do we need this interface?
+7581,"@@ -137,7 +137,10 @@ class OptionsManagerMixIn:
+ 
+     def add_optik_option(self, provider, optikcontainer, opt, optdict):
+         args, optdict = self.optik_option(provider, opt, optdict)
+-        option = optikcontainer.add_option(*args, **optdict)
++        try:
++            option = optikcontainer.add_option(*args, **optdict)
++        except optparse.OptionConflictError:
++            return
+         self._all_options[opt] = provider
+         self._maxlevel = max(self._maxlevel, option.level or 0)
+ ","@Pierre-Sassoulas Are we sure this doesn't create problems? Without it for some reason we get an error on `accept-no-param-docs` being a duplicate error. I couldn't figure out why it did this. This solves the issue and passes the tests, but I wonder if this creates other issues..",I don't think this is the righ
+7582,"@@ -169,7 +169,17 @@ func (c *linuxContainer) OCIState() (*specs.State, error) {
+ }
+ 
+ func (c *linuxContainer) Processes() ([]int, error) {
+-	pids, err := c.cgroupManager.GetAllPids()
++	var pids []int
++	status, err := c.currentStatus()
++	if err != nil {
++		return pids, err
++	}
++	// for systemd cgroup, the unit's cgroup path will be auto removed if container's all processes exited
++	if status == Stopped && !c.cgroupManager.Exists() {
++		return pids, nil
++	}
++
++	pids, err = c.cgroupManager.GetAllPids()
+ 	if err != nil {
+ 		return nil, newSystemErrorWithCause(err, ""getting all container pids from cgroups"")
+ 	}","Does it make sense to check for ""Created"" here as well? Or should it return an error in such case?",Shouldn't this be `if status =
+7583,"@@ -93,7 +93,7 @@ public abstract class BaseMetastoreCatalog implements Catalog {
+     String baseLocation = location != null ? location : defaultWarehouseLocation(identifier);
+     Map<String, String> tableProperties = properties != null ? properties : Maps.newHashMap();
+     TableMetadata metadata = TableMetadata.newTableMetadata(schema, spec, baseLocation, tableProperties);
+-    return Transactions.createTableTransaction(ops, metadata);
++    return Transactions.createTableTransaction(identifier.name(), ops, metadata);
+   }
+ 
+   @Override",Did you mean to use `identifier.toString` here as well?,Why is this change needed?
+7584,"@@ -1,6 +1,6 @@
+-require 'spec_helper'
++require ""rails_helper""
+ 
+-describe Api::V1::UsersController, '#show' do
++describe Api::V1::UsersController, ""#show"", type: :controller do
+   it 'returns a 401 when users are not authenticated' do
+     get :show
+     expect(response.code).to eq ""401""",interesting! didn't realize this was needed in RSpec 3,Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
+7585,"@@ -27,7 +27,7 @@ from databricks.koalas.base import _wrap_accessor_pandas, _wrap_accessor_spark
+ 
+ class DatetimeMethods(object):
+     """"""Date/Time methods for Koalas Series""""""
+-    def __init__(self, series: ks.Series):
++    def __init__(self, series: 'ks.Series'):
+         if not isinstance(series.spark_type, (DateType, TimestampType)):
+             raise ValueError(
+                 ""Cannot call DatetimeMethods on type {}""",This is to avoid circular reference,Why this change?
+7586,"@@ -93,6 +93,9 @@ class MPLRenderer(Renderer):
+              'nbagg':   (NbAggJupyterComm, None),
+              'mpld3':   (JupyterComm, mpld3_msg_handler)}
+ 
++    # Whether in a notebook context
++    _notebook = False
++
+     def __call__(self, obj, fmt='auto'):
+         """"""
+         Render the supplied HoloViews component or MPLPlot instance","As the bokeh renderer also has a ``load_nb`` classmethod (and notebooks are explicitly mentioned in that method name), I would consider making ``_notebook`` into a constant ``notebook_context`` class parameter. The docstring can say it is set to True if the ``load_nb`` classmethod has been called.",Why is this needed?
+7587,"@@ -2,7 +2,6 @@
+ 
+ const CommandOperation = require('./command');
+ const handleCallback = require('../utils').handleCallback;
+-const MongoError = require('../core').MongoError;
+ 
+ class DropCollectionOperation extends CommandOperation {
+   constructor(db, command, options) {","Where is the actual command generated here? Shouldn't this be taking in `constructor(db, collectionName, options)` and then constructing the command off of that?",Why was this removed?
+7588,"@@ -55,7 +55,8 @@
+ int
+ memquery_library_bounds_by_iterator(const char *name, app_pc *start /*IN/OUT*/,
+                                     app_pc *end /*OUT*/, char *fullpath /*OPTIONAL OUT*/,
+-                                    size_t path_size)
++                                    size_t path_size, char *filename,
++                                    size_t filename_size)
+ {
+     int count = 0;
+     bool found_library = false;",Mirror the `OPTIONAL OUT` of fullpath,`filename_size` is not used.
+7589,"@@ -94,13 +94,16 @@ const ConsensusV17 = ConsensusVersion(
+ 	""https://github.com/algorandfoundation/specs/tree/5615adc36bad610c7f165fa2967f4ecfa75125f0"",
+ )
+ 
++// ConsensusVNext stand-in for protocol with LogicSig and TEAL v1
++const ConsensusVNext = ConsensusVersion(""NEXT!"")
++
+ // !!! ********************* !!!
+ // !!! *** Please update ConsensusCurrentVersion when adding new protocol versions *** !!!
+ // !!! ********************* !!!
+ 
+ // ConsensusCurrentVersion is the latest version and should be used
+ // when a specific version is not provided.
+-const ConsensusCurrentVersion = ConsensusV17
++const ConsensusCurrentVersion = ConsensusVNext
+ 
+ // ConsensusTest0 is a version of ConsensusV0 used for testing
+ // (it has different approved upgrade paths).","Please merge with master and replace with with ""future"" version.",This should be `ConsensusV17
+7590,"@@ -55,7 +55,6 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			let cxType = newType.contextType;
+ 			let provider = cxType && context[cxType._id];
+ 			let cctx = cxType != null ? (provider ? provider.props.value : cxType._defaultValue) : context;
+-
+ 			// Get component and set it to `c`
+ 			if (oldVNode._component) {
+ 				c = newVNode._component = oldVNode._component;",Nit: Change is not needed for this PR :slightly_smiling_face:,Why was this removed?
+7591,"@@ -11,6 +11,15 @@ module CloudFoundry
+     end
+   end
+ 
++  def self.app_url
++    if self.is_environment?
++      # (arbitrarily) use the shortest assigned route, if there are multiple
++      self.vcap_data['application_uris'].min_by(&:length)
++    else
++      nil
++    end
++  end
++
+   # returns `true` if this app is running in Cloud Foundry
+   def self.is_environment?
+     !!self.raw_vcap_data",if we are returning `nil` from an `else` I think we can just remove the `else` (and this method will still return `nil`),I'm not sure if this is the 
+7592,"@@ -9,7 +9,7 @@ using System.Threading.Tasks;
+ namespace System.Threading.Tests
+ {
+     [BenchmarkCategory(Categories.CoreFX)]
+-    public class TimerPerfTest
++    public class Perf_Timer
+     {
+         private readonly Timer[] _timers = new Timer[1_000_000];
+         private readonly Task[] _tasks = new Task[Environment.ProcessorCount];","side note: this change is ok as of today because we have not exported the results for this new type to BenchView yet. After we to that the namespace, type name and method name should not be changed (they create a benchmark ID which is used in BenchView).",Why did you change this?
+7593,"@@ -294,7 +294,15 @@ namespace pwiz.Skyline.Model.Lib.Midas
+             _spectra = null;
+             if (FilePath == null)
+                 return false;
+-            var info = new FileInfo(FilePath);
++            FileInfo info;
++            try
++            {
++                info = new FileInfo(FilePath);
++            }
++            catch
++            {
++                return false;
++            }
+             if (!info.Exists || info.Length == 0)
+                 return false;
+ ","How exactly are you expecting the user to see issues with their Midas library? It seems like all error information is being swallowed and not clearly reported to the user. Even if the eventual result is to report that loading the file failed, it seems like the exception, in this case, might have more information about why.",Why do we need this?
+7594,"@@ -105,6 +105,10 @@ func (wsc *WebSocketClient) UnInit() {
+ 
+ //Send sends the message as JSON object through the connection
+ func (wsc *WebSocketClient) Send(message model.Message) error {
++	err := wsc.connection.SetWriteDeadline(time.Now().Add(wsc.config.WriteDeadline))
++	if err != nil {
++		return err
++	}
+ 	return wsc.connection.WriteMessageAsync(&message)
+ }
+ ","Looks good, but seems `ReadMessage` hadn't used this Deadline in Underlying `WSConnection`?",Why do we need to set wr
+7595,"@@ -89,6 +89,8 @@ public class Constants {
+   // The flow exec id for a flow trigger instance unable to trigger a flow yet
+   public static final int FAILED_EXEC_ID = -2;
+ 
++  // Name of the file which keeps project directory size
++  public static final String PROJECT_DIR_SIZE_FILE_NAME = ""_azkaban_project_dir_size_in_bytes_"";
+ 
+   public static class ConfigurationKeys {
+ ","Make it ""___*"" three underscores to make it even less likely to have a collision? I assume it will be hard to change the file name once this change is deployed...",I think this should be `
+7596,"@@ -432,7 +432,7 @@ public class RecoveryStrategy implements Runnable, Closeable {
+   /**
+    * @return true if we have reached max attempts or should stop recovering for some other reason
+    */
+-  private boolean waitBetweenRecoveries(String coreName) {
++  final private boolean waitBetweenRecoveries(String coreName) {
+     // lets pause for a moment and we need to try again...
+     // TODO: we don't want to retry for some problems?
+     // Or do a fall off retry...",We don't need this anymore after #2151,Why do we need this?
+7597,"@@ -48,7 +48,7 @@ namespace NLog.LayoutRenderers
+     [AppDomainFixedOutput]
+     [ThreadAgnostic]
+     [ThreadSafe]
+-    public class MachineNameLayoutRenderer : LayoutRenderer, IStringValueRenderer
++    public class MachineNameLayoutRenderer : LayoutRenderer
+     {
+         internal string MachineName { get; private set; }
+ ",this is this removed? I don't understand in the context of this PR,Why did you remove t
+7598,"@@ -107,6 +107,9 @@ def getmacbyip6(ip6, chainCC=0):
+     (chainCC parameter value ends up being passed to sending function
+      used to perform the resolution, if needed)
+     """"""
++    
++    if isinstance(ip6,Net6):
++        ip6 = iter(ip6).next()
+ 
+     if in6_ismaddr(ip6): # Multicast
+         mac = in6_getnsmac(inet_pton(socket.AF_INET6, ip6))","`isinstance(ip6, Net6)` instead",missing space after 
+7599,"@@ -359,10 +359,12 @@ ResultCode NebulaStore::get(GraphSpaceID spaceId,
+ }
+ 
+ 
+-ResultCode NebulaStore::multiGet(GraphSpaceID spaceId,
+-                                 PartitionID partId,
+-                                 const std::vector<std::string>& keys,
+-                                 std::vector<std::string>* values) {
++ErrorOr<ResultCode, std::vector<Status>> NebulaStore::multiGet(
++        GraphSpaceID spaceId,
++        PartitionID partId,
++        const std::vector<std::string>& keys,
++        std::vector<std::string>* values,
++        bool returnPartly) {
+     auto ret = part(spaceId, partId);
+     if (!ok(ret)) {
+         return error(ret);","Do we really need the param here? If only partial results returned, we could return ResultCode::PARTIAL_RESULTS;",`returnPartly` -> `r
+7600,"@@ -330,7 +330,12 @@ func moveOutputs(state *core.BuildState, target *core.BuildTarget) ([]string, bo
+ 	tmpDir := target.TmpDir()
+ 	outDir := target.OutDir()
+ 	for _, output := range target.Outputs() {
+-		tmpOutput := path.Join(tmpDir, output)
++		var tmpOutput string
++		if output == target.Label.PackageName {
++			tmpOutput = path.Join(tmpDir, fmt.Sprintf(core.TmpOutputFormat, output))
++		} else {
++			tmpOutput = path.Join(tmpDir, output)
++		}
+ 		realOutput := path.Join(outDir, output)
+ 		if !core.PathExists(tmpOutput) {
+ 			return nil, true, fmt.Errorf(""Rule %s failed to create output %s"", target.Label, tmpOutput)",this logic seems duplicated from the other new function. I think it should probably be a member function on `BuildTarget`,"I don't think this is correct. If the package name is the same as the target name, the output will be the same as the target name."
+7601,"@@ -51,14 +51,13 @@ func TestPatricia(t *testing.T) {
+ 	stream, err := b.serialize()
+ 	assert.Nil(err)
+ 	assert.NotNil(stream)
+-	assert.Equal(byte(1), stream[0])
+ 	b1 := branch{}
+ 	err = b1.deserialize(stream)
+ 	assert.Nil(err)
+ 	assert.Equal(0, bytes.Compare(root, b1.Path[0]))
+ 	assert.Equal(0, bytes.Compare(hash1, b1.Path[2]))
+ 	assert.Equal(0, bytes.Compare(hash2, b1.Path[11]))
+-	assert.Equal(430, len(stream))
++	assert.Equal(114, len(stream))
+ 
+ 	e := leaf{0, nil, nil}
+ 	e.Path = []byte{2, 3, 5, 7}",size reduce to 1/4 of using Gob,why did this change?
+7602,"@@ -15,13 +15,14 @@ type Writer struct {
+ func NewWriter(w io.Writer, h hash.Hash) *Writer {
+ 	return &Writer{
+ 		h: h,
+-		w: io.MultiWriter(w, h),
++		w: w,
+ 	}
+ }
+ 
+ // Write wraps the write method of the underlying writer and also hashes all data.
+ func (h *Writer) Write(p []byte) (int, error) {
+ 	n, err := h.w.Write(p)
++	h.h.Write(p[:n])
+ 	return n, err
+ }
+ ",The Hash interface states that a call to `Write()` never returns an error. Does this also apply to the number of written bytes?,Why is this change necessary?
+7603,"@@ -5,7 +5,7 @@ module Travis
+     module Appliances
+       class DisableSshRoaming < Base
+         def apply
+-          sh.if ""$(sw_vers -productVersion | cut -d . -f 2) -lt 12"" do
++          sh.if %(""$(sw_vers -productVersion 2>/dev/null | cut -d . -f 2)"" -lt 12) do
+             sh.cmd %(mkdir -p $HOME/.ssh)
+             sh.cmd %(chmod 0700 $HOME/.ssh)
+             sh.cmd %(touch $HOME/.ssh/config)","In my tests, I found that `[[ """" -lt 12 ]]` evaluates to true, but `[[ -lt 12 ]]` is an error, which is why the subshell is wrapped in `""`.",Why do we need to change this?
+7604,"@@ -369,6 +369,11 @@ FactoryGirl.define do
+     association :watchable, factory: :product
+     title
+     wistia_id '1194803'
++    published_on Time.zone.today
++
++    trait :unpublished do
++      published_on nil
++    end
+   end
+ 
+   factory :oauth_access_token do","I don't see a validation on `published_on`, we generally shouldn't specify it in the base factory unless the model would be invalid without the model. Is there a different way we can handle this?",Extra empty line detected at block body beginning.
+7605,"@@ -115,7 +115,7 @@ public final class ConstantScoreQuery extends Query {
+       return new ConstantScoreWeight(this, boost) {
+         @Override
+         public BulkScorer bulkScorer(LeafReaderContext context) throws IOException {
+-          if (scoreMode == ScoreMode.TOP_SCORES) {
++          if (scoreMode == ScoreMode.TOP_SCORES || scoreMode == ScoreMode.TOP_DOCS || scoreMode == ScoreMode.TOP_DOCS_WITH_SCORES) {
+             return super.bulkScorer(context);
+           }
+           final BulkScorer innerScorer = innerWeight.bulkScorer(context);",maybe add a `isExhaustive()` method on the enum to avoid these large conditions?,I don't think we need to do this here. We can just
+7606,"@@ -15,11 +15,13 @@ import (
+ )
+ 
+ const (
+-	defaultCaFile   = ""ca.pem""
+-	defaultKeyFile  = ""key.pem""
+-	defaultCertFile = ""cert.pem""
+-	dockerSock      = ""/var/run/docker.sock""
+-	dockerSockUnix  = ""unix://"" + dockerSock
++	defaultCaFile               = ""ca.pem""
++	defaultKeyFile              = ""key.pem""
++	defaultCertFile             = ""cert.pem""
++	dockerSock                  = ""/var/run/docker.sock""
++	dockerSockUnix              = ""unix://"" + dockerSock
++	substitutionPatternName     = ""pattern""
++	substitutionReplacementName = ""replacement""
+ )
+ 
+ var (","so those regexps were wrong previously? e.g. they would match `/v\/foo`? If so, raise a bug and fix on the 1.0 branch.",I'm not sure if this is the best place for these c
+7607,"@@ -1417,6 +1417,9 @@ class MultiBackend extends AbstractBase implements \Laminas\Log\LoggerAwareInter
+         bool $stripPrefixes = true,
+         bool $addPrefixes = true
+     ) {
++        if (empty($params) && null === $source) {
++            return null;
++        }
+         if (null === $source) {
+             $source = $this->getSourceForMethod($method, $params);
+         }","I think with MultiBackend we could have a slightly different logic: return true if there are no configured login targets ( = getLoginDrivers returns an empty array). MultiBackend could also check all configured login targets for loginIsHidden support and verify that at least one of the configured login targets allows login, but I wouldn't go that far without a use case. In a related note, I'm not quite sure if loginIsHidden works with ChoiceAuth at all, but that's a different issue.",Why is this needed?
+7608,"@@ -25,11 +25,13 @@ using namespace LAMMPS_NS;
+ Reader::Reader(LAMMPS *lmp) : Pointers(lmp)
+ {
+   fp = nullptr;
++  binary = false;
++  compressed = false;
+ }
+ 
+ /* ----------------------------------------------------------------------
+    try to open given file
+-   generic version for ASCII files that may be compressed
++   generic version for ASCII files that may be compressed or native binary dumps
+ ------------------------------------------------------------------------- */
+ 
+ void Reader::open_file(const std::string &file)",Should we add error info for not supporting the compressed binary?,I don't think we need to set these to false.
+7609,"@@ -62,6 +62,8 @@ var (
+ 	// defaulting fails.
+ 	defaultBackoffDelay  = ""PT1S""
+ 	defaultBackoffPolicy = eventingduckv1beta1.BackoffPolicyExponential
++	// clusterRegionGetter is a function that can get the cluster region
++	clusterRegionGetter = utils.NewClusterRegionGetter()
+ )
+ 
+ // Reconciler implements controller.Reconciler for Trigger resources.",I suggest injecting this into the reconciler. For this and the others. Have Wire generate it and push it into the controller creation.,Why do we need this?
+7610,"@@ -25,6 +25,11 @@ namespace Nethermind.Core.Json
+ {
+     public class EthereumJsonSerializer : IJsonSerializer
+     {
++        public EthereumJsonSerializer()
++        {
++            _serializer = JsonSerializer.Create(_settings);
++        }
++
+         public static IList<JsonConverter> BasicConverters { get; } = new List<JsonConverter>
+         {
+             new AddressConverter(),",Can't we just make _serializer static? We use same settings every time. I would also put those fields on top of the class for readability.,Why do we need this?
+7611,"@@ -321,6 +321,7 @@ class HttpLayer(base.Layer):
+ 
+         try:
+             if websockets.check_handshake(request.headers) and websockets.check_client_version(request.headers):
++                f.metadata['websocket'] = True
+                 # We only support RFC6455 with WebSocket version 13
+                 # allow inline scripts to manipulate the client handshake
+                 self.channel.ask(""websocket_handshake"", f)",Can't we just use `metadata['websocket_flow']` to identify handshake flows and not add another attribute?,Why do we need this?
+7612,"@@ -81,7 +81,7 @@ module RSpec
+ 
+           def output_formatted(str)
+             return str unless str.lines.count > 1
+-            separator = ""#{'-' * 80}""
++            separator = '-' * 80
+             ""#{separator}\n#{str.chomp}\n#{separator}""
+           end
+ ",Funny that we were wrapping this with string interpolation before...,Why this change?
+7613,"@@ -0,0 +1,6 @@
++import Controller from '@ember/controller';
++import {alias} from '@ember/object/computed';
++
++export default Controller.extend({
++    guid: alias('model')
++});","I had an eslint error saying I must ""alias"" my model - so I copied this from controllers/site.js",Why do we need t
+7614,"@@ -124,9 +124,9 @@ namespace OpenTelemetry.Metrics
+ 
+         internal bool InstrumentDisposed { get; set; }
+ 
+-        public BatchMetricPoint GetMetricPoints()
++        public MetricPointsAccessor GetMetricPointsAccessor()
+         {
+-            return this.aggStore.GetMetricPoints();
++            return this.aggStore.GetMetricPointsAccessor();
+         }
+ 
+         internal void UpdateLong(long value, ReadOnlySpan<KeyValuePair<string, object>> tags)",unsure if the methodname can still be `GetMetricPoints()` as before...,nit: rename to G
+7615,"@@ -233,6 +233,7 @@ class ViolationAccess(object):
+                 violation.get('full_name', ''),
+                 violation.get('resource_data', ''),
+                 violation.get('violation_data', ''),
++                violation.get('rule_name', '')
+             )
+ 
+             violation = Violation(","This file contains the functional changes, the rest is for testing.",Should this be `
+7616,"@@ -22,6 +22,7 @@ package http_test
+ 
+ import (
+ 	""fmt""
++	""io""
+ 	""log""
+ 	nethttp ""net/http""
+ 	""os""","I know you didn't do this, but there's no need for the `nethttp` alias and it was confusing to me - just remove it and s/nethttp/http/ everywhere (it's fine that the package here is http itself, I do the same thing in transport/grpc)",Why do we need this?
+7617,"@@ -1335,6 +1335,12 @@ public class SmartStoreTest extends SmartStoreTestCase {
+ 			JSONObject soupElt = new JSONObject(""{'key':'abcd"" + i + ""', 'value':'va"" + i + ""', 'otherValue':'ova"" + i + ""'}"");
+ 			store.create(TEST_SOUP, soupElt);
+ 		}
++
++		// With WAL enabled we must force a WAL checkpoint if we want the actual DB file to reflect the new content:
++		store.getDatabase()
++				.query(""PRAGMA wal_checkpoint(FULL);"")
++				.moveToNext();
++
+         Assert.assertTrue(""Database should be larger now"", store.getDatabaseSize() > initialSize);
+ 	}
+ ","I felt that this was the most non-invasive way to fix the test, but this does expose some raw DB queries and knowledge about how SQLite works which may be a code smell. The alternative to getting this to pass is to perform enough writes to trigger a checkpoint, but that threshold is determined in the config stage and this test may not be able to know what that page threshold is set to. This could lead to inconsistent test runs which is why I elected to force the checkpoint regardless of the page threshold.",I think it would be 
+7618,"@@ -14,7 +14,7 @@
+ 
+ namespace LightGBM {
+ 
+-const std::string kModelVersion = ""v2"";
++const std::string kModelVersion = ""v3"";
+ 
+ std::string GBDT::DumpModel(int start_iteration, int num_iteration) const {
+   std::stringstream str_buf;",Is new model format backward compatible with current v2?,Why do we need this 
+7619,"@@ -17,6 +17,14 @@ describe 'User creation when logging in with Oauth to view a protected page' do
+     expect(new_user.last_name).to eq(""Jetsonian"")
+   end
+ 
++  it ""sends welcome email to a new user"" do
++    deliveries.clear
++    expect { get '/auth/myusa/callback' }.to change { deliveries.length }.from(0).to(1)
++    welcome_mail = deliveries.first
++    expect(welcome_mail.subject).to eq(""[TEST] Welcome to C2!"")
++    deliveries.clear
++  end
++
+   it ""absence of first/last name does not throw error"" do
+     user = StructUser.new('somebody@example.com', nil, nil)
+     setup_mock_auth(:myusa, user)",should we perhaps write a spec that ensures we don't send a welcome email to a user on login when the user is not new?,I don't think you ne
+7620,"@@ -83,6 +83,10 @@ type Config struct {
+ 	// other than containers managed by ECS
+ 	ReservedMemory uint16
+ 
++	// ContainerTimeout specifies the amount time before a SIGKILL is issued to
++	// containers managed by ECS
++	DockerStopTimeoutSeconds uint64
++
+ 	// AvailableLoggingDrivers specifies the logging drivers available for use
+ 	// with Docker.  If not set, it defaults to [""json-file""].
+ 	AvailableLoggingDrivers []dockerclient.LoggingDriver",I think my preference would be to have the type be a `time.Duration` and use `time.ParseDuration` for parsing.,I think this should be `ContainerTimeoutSeconds`
+7621,"@@ -19,6 +19,8 @@ package org.openqa.grid.internal;
+ 
+ import com.google.common.base.Predicate;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import net.jcip.annotations.ThreadSafe;
+ 
+ import org.openqa.grid.internal.listeners.Prioritizer;",JMX offers normal APIs for this. I don't think you want the glassfish one.,I don't think this is needed.
+7622,"@@ -41,7 +41,7 @@ class Yamllint(base.Base):
+     .. code-block:: yaml
+ 
+         verifier:
+-          name: goss
++          name: ...
+           lint:
+             name: yamllint
+             options:",We should really leave a TODO or something or else we will forget them ...,Why is this change needed?
+7623,"@@ -61,7 +61,7 @@ def define_pandas_source_test_solid():
+     return dm.define_dagstermill_solid(
+         name='pandas_source_test',
+         notebook_path=nb_test_path('pandas_source_test'),
+-        inputs=[InputDefinition(name='df', dagster_type=DataFrame)],
++        inputs=[InputDefinition(name='df', runtime_type=DataFrame)],
+         outputs=[OutputDefinition(DataFrame)],
+     )
+ ","This exposes what a bad name `dagster_type` was, but is it crazy to want this to just be `type` -- do we gain usability by being super-explicit that this is a `runtime_type`? If so, would it make sense to rename the `config_field` to be `config_type`?",Why this change?
+7624,"@@ -803,6 +803,16 @@ Tries to force this object to take the focus.
+ 		""""""
+ 		speech.speakObject(self,reason=controlTypes.REASON_FOCUS)
+ 
++	def _get_isSelectionAnchoredAtStart(self):
++		""""""Determine if the selection is anchored at the start.
++		If the selection is anchored at the end or there is no information this is C{False}.
++		@return: C{True} if the selection is anchored at the start else C{False}
++		@rtype: bool
++		""""""
++		if hasattr(self, '_isSelectionAnchoredAtStart'):
++			return self._isSelectionAnchoredAtStart
++		return False
++
+ 	def _reportErrorInPreviousWord(self):
+ 		try:
+ 			# self might be a descendant of the text control; e.g. Symphony.",It might help here if you give a brief explanation of what you mean with a selection being anchored at the start.,I don't think you need the `hasattr` check.
+7625,"@@ -7,12 +7,14 @@
+ package transfer
+ 
+ import (
++	""fmt""
+ 	""math/big""
+ 
+ 	""github.com/pkg/errors""
+ 
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/iotxaddress""
++	""github.com/iotexproject/iotex-core/pkg/hash""
+ 	""github.com/iotexproject/iotex-core/state""
+ )
+ ",move cachedStates to handle function,Please remove this empty line.
+7626,"@@ -130,7 +130,7 @@ public class GlobalSettings {
+         s.put(""hideSpecialAccounts"", Settings.versions(
+                 new V(1, new BooleanSetting(false))
+             ));
+-        s.put(""keyguardPrivacy"", Settings.versions(
++        s.put(""privacyMode"", Settings.versions(
+                 new V(1, new BooleanSetting(false))
+             ));
+         s.put(""language"", Settings.versions(","I don't think this can just be renamed; it's saying that privacyMode is a BooleanSetting, which it's not.",I think this should be `keyguardPrivacyMode
+7627,"@@ -595,7 +595,7 @@ public class SharedCoreConcurrencyTest extends SolrCloudSharedStoreTestCase {
+       public void recordState(String collectionName, String shardName, String coreName, SharedCoreStage stage) {
+         super.recordState(collectionName, shardName, coreName, stage);
+         ConcurrentLinkedQueue<String> coreConcurrencyStages = coreConcurrencyStagesMap.computeIfAbsent(coreName, k -> new ConcurrentLinkedQueue<>());
+-        coreConcurrencyStages.add(Thread.currentThread().getId() + ""."" + stage.name());
++        coreConcurrencyStages.add(Thread.currentThread().getName() + ""."" + stage.name());
+       }
+     };
+     setupTestSharedConcurrencyControllerForNode(concurrencyController, solrProcess);",what was the reason for this change?,Why this change?
+7628,"@@ -1,14 +1,8 @@
+ using System;
+-using System.Collections.Concurrent;
+-using System.Collections.Generic;
+ using System.Configuration;
+-using System.Linq;
+-using System.Text;
+-using System.Web;
+-
+-[assembly: System.Security.SecurityCritical]
+-[assembly: System.Security.AllowPartiallyTrustedCallers]
+ 
++// [assembly: System.Security.SecurityCritical]
++// [assembly: System.Security.AllowPartiallyTrustedCallers]
+ namespace Datadog.Trace.ClrProfiler
+ {
+     /// <summary>","Minor, but these two nullable and the logic around them could be replaced by a Lazy<Bool>.",Why are we removing these?
+7629,"@@ -1,12 +1,17 @@
+ package main
+ 
+ import (
++	""os""
++	""strconv""
+ 	""sync/atomic""
+ 	""syscall""
+ 	""time""
+ 
+-	""github.com/weaveworks/go-checkpoint""
++	checkpoint ""github.com/weaveworks/go-checkpoint""
+ 	weave ""github.com/weaveworks/weave/router""
++	api ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/client-go/kubernetes""
++	""k8s.io/client-go/rest""
+ )
+ 
+ var checker *checkpoint.Checker","I think I would just pass in `len(peers)`, on the principle of minimum information.",nit: remove empty line
+7630,"@@ -84,6 +84,9 @@ public class TableProperties {
+   public static final String PARQUET_BATCH_SIZE = ""read.parquet.vectorization.batch-size"";
+   public static final int PARQUET_BATCH_SIZE_DEFAULT = 5000;
+ 
++  public static final String PARQUET_IN_LIMIT = ""read.parquet.in-predicate-limit"";
++  public static final int PARQUET_IN_LIMIT_DEFAULT = 200;
++
+   public static final String OBJECT_STORE_ENABLED = ""write.object-storage.enabled"";
+   public static final boolean OBJECT_STORE_ENABLED_DEFAULT = false;
+ ","Spark's default value is 10 but it also rewrites IN as OR/EQUALS. We can do better that this because of the way we evaluate IN predicates. On datasets we tested this, we saw performance improvements on IN predicates with up to 200 elements (on sorted column). We may increase the default value a bit but I am very reluctant to make it more than 300 since our jobs were 20% slower with IN predicates that contained 300 elements. That being said, the optimal value still depends on a particular query and table.",I think this should be `re
+7631,"@@ -20,6 +20,7 @@ package org.springframework.security.oauth2.core.oidc.endpoint;
+  * and used by the authorization endpoint and token endpoint.
+  *
+  * @author Joe Grandja
++ * @author Mark Heckler
+  * @since 5.0
+  * @see <a target=""_blank"" href=""https://openid.net/specs/openid-connect-core-1_0.html#OAuthParametersRegistry"">18.2 OAuth Parameters Registration</a>
+  */",Please update copyright year.,Please remove this line.
+7632,"@@ -289,9 +289,13 @@ int Extractor::run(ScriptingEnvironment &scripting_environment)
+ 
+         WriteEdgeBasedGraph(config.edge_graph_output_path, max_edge_id, edge_based_edge_list);
+ 
+-        util::SimpleLogger().Write()
+-            << ""Expansion  : "" << (number_of_node_based_nodes / TIMER_SEC(expansion))
+-            << "" nodes/sec and "" << ((max_edge_id + 1) / TIMER_SEC(expansion)) << "" edges/sec"";
++        const auto nodes_per_second =
++            static_cast<std::uint64_t>(number_of_node_based_nodes / TIMER_SEC(expansion));
++        const auto edges_per_second =
++            static_cast<std::uint64_t>((max_edge_id + 1) / TIMER_SEC(expansion));
++
++        util::SimpleLogger().Write() << ""Expansion: "" << nodes_per_second << "" nodes/sec and ""
++                                     << edges_per_second << "" edges/sec"";
+         util::SimpleLogger().Write() << ""To prepare the data for routing, run: ""
+                                      << ""./osrm-contract "" << config.output_file_name << std::endl;
+     }","Same here, could just be `std::setprecision`.",Why do we need to cast here?
+7633,"@@ -2290,14 +2290,6 @@ func (fbo *folderBranchOps) getConvID(
+ 
+ func (fbo *folderBranchOps) sendEditNotifications(
+ 	ctx context.Context, rmd ImmutableRootMetadata, body string) error {
+-	// For now only write out the notifications if we're in test mode,
+-	// just in case we decide to change the notification format before
+-	// we launch.  TODO: turn this on for admins once we can test it
+-	// on staging.
+-	if !fbo.config.Mode().IsTestMode() {
+-		return nil
+-	}
+-
+ 	handle := rmd.GetTlfHandle()
+ 	convID, err := fbo.getConvID(ctx, handle)
+ 	if err != nil {","Do we still want the ""admins"" gate?",Why is this being removed?
+7634,"@@ -1,8 +1,11 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
+ # This code example demonstrates how to upload multiple items
+-# to a bucket in Amazon S3.
++# to a bucket in Amazon Simple Storage Solution (Amazon S3).
++
++# snippet-start:[s3.ruby.s3-ruby-example-upload-multiple-items]
+ 
+ # Prerequisites:
+ #  - An existing Amazon S3 bucket.",Simple Storage **Service**,I think this should be `snip
+7635,"@@ -172,4 +172,11 @@ type Config struct {
+ 
+ 	// Configures telemetry.
+ 	Metrics MetricsConfig
++
++	// DisableAutoObservabilityMiddleware is used to stop the dispatcher from
++	// automatically attaching observability middleware to all inbounds and
++	// outbounds.  It is the assumption that if if this option is disabled the
++	// observability middleware is being inserted in the Inbound/Outbound
++	// Middleware.
++	DisableAutoObservabilityMiddleware bool
+ }",nit: `it is assumed`,nit: `DisableAutoObservabili
+7636,"@@ -23,6 +23,7 @@
+ #include <stdint.h>
+ #include <stdio.h>
+ #include <stdlib.h>
++#include <stdbool.h>
+ #include ""h2o.h""
+ #include ""h2o/http2.h""
+ #include ""h2o/http2_internal.h""","I would appreciate it if you could refrain from using `stdbool.h`. We allow the header files of H2O to be included from C++ (which means that `bool` might be a C++ type), and therefore my preference is to not use `bool` in our code (but instead use `int` or `char` for the purpose) to avoid confusion.",why is this needed?
+7637,"@@ -843,6 +843,9 @@ class RelationController extends ControllerBehavior
+             }
+ 
+             $widget = $this->makeWidget('Backend\Widgets\Lists', $config);
++            $widget->setSearchOptions([
++                'scope' => $this->getConfig('manage[searchScope]')
++            ]);
+ 
+             /*
+              * Apply defined constraints",@danielbidala What happens if `searchScope` is not defined in `config_relation.yaml` ?,Why is this needed?
+7638,"@@ -57,14 +57,17 @@ func serviceLoggedIn(ctx context.Context, config Config, session SessionInfo,
+ 			""%+v"", err)
+ 	}
+ 
++	// Launch auth refreshes in the background, in case we are
++	// currently disconnected from one of these servers.
+ 	mdServer := config.MDServer()
+ 	if mdServer != nil {
+-		mdServer.RefreshAuthToken(ctx)
++		go mdServer.RefreshAuthToken(context.Background())
+ 	}
+ 	bServer := config.BlockServer()
+ 	if bServer != nil {
+-		bServer.RefreshAuthToken(ctx)
++		go bServer.RefreshAuthToken(context.Background())
+ 	}
++
+ 	config.KBFSOps().RefreshCachedFavorites(ctx)
+ 	config.KBFSOps().PushStatusChange()
+ 	return wg",Do we want maybe a 1min timeout?,Why do we need a se
+7639,"@@ -48,11 +48,11 @@ func BasicAuthDecode(encoded string) (user string, name string, err error) {
+ 		return user, name, err
+ 	}
+ 
+-	a := strings.Split(string(s), "":"")
+-	if len(a) == 2 {
+-		user, name = a[0], a[1]
+-	} else {
++	a := strings.SplitN(string(s), "":"", 2)
++	if len(a) != 2 {
+ 		err = errors.New(""decode failed"")
++	} else {
++		user, name = a[0], a[1]
+ 	}
+ 	return user, name, err
+ }","I guess code never reaches this line, you can remove `else` block and just `return a[0], a[1]`. Also, probably rename `a` to `auth` as well.",Why is this change 
+7640,"@@ -43,7 +43,7 @@ class SerializableByteBufferMap implements Map<Integer, ByteBuffer>, Serializabl
+     return new SerializableByteBufferMap(map);
+   }
+ 
+-  public SerializableByteBufferMap() {
++  SerializableByteBufferMap() {
+     this.wrapped = Maps.newLinkedHashMap();
+   }
+ ",Doesn't this no-arg constructor need to be public for serialization to work?,Why is this needed?
+7641,"@@ -20,7 +20,7 @@ return [
+     'alpha_dash'           => 'Hierdie veld mag slegs letters, syfers, strepies en onderstrepe bevat.',
+     'alpha_num'            => 'Hierdie veld mag slegs letters en syfers bevat.',
+     'array'                => 'Hierdie veld moet \'n array wees.',
+-    'attached'             => 'This field is already attached.',
++    'attached'             => 'Hierdie gebied is reeds aangeheg.',
+     'before'               => 'Dit moet \'n datum voor :date wees.',
+     'before_or_equal'      => 'Dit moet \'n datum gelyk of voor :date wees.',
+     'between'              => [","Just use the word ""veld"" instead of ""gebied"" here",I don't think this 
+7642,"@@ -22,6 +22,7 @@ import android.util.Log;
+ import android.webkit.URLUtil;
+ 
+ import org.apache.commons.io.FileUtils;
++import org.shredzone.flattr4j.model.User;
+ import org.xml.sax.SAXException;
+ 
+ import java.io.File;",This change (import org.shredzone.flatter4j.model.User;) does not seem relevant to this fix / commit.,This import is unus
+7643,"@@ -63,6 +63,7 @@ var (
+ 	noCleanup            = app.Flag(""no-cleanup"", ""Whether or not to delete the chroot folder after the build is done"").Bool()
+ 	noCache              = app.Flag(""no-cache"", ""Disables using prebuilt cached packages."").Bool()
+ 	stopOnFailure        = app.Flag(""stop-on-failure"", ""Stop on failed build"").Bool()
++	hydratedBuild        = app.Flag(""hydrated-build"", ""Build individual packages with Hydrated RPMs"").String()
+ 
+ 	validBuildAgentFlags = []string{buildagents.TestAgentFlag, buildagents.ChrootAgentFlag}
+ 	buildAgent           = app.Flag(""build-agent"", ""Type of build agent to build packages with."").PlaceHolder(exe.PlaceHolderize(validBuildAgentFlags)).Required().Enum(validBuildAgentFlags...)",This should be a Bool() rather than a String(). (See the other PR for an example),nit: `Build individ
+7644,"@@ -243,7 +243,7 @@ rules:
+         """"""Test that a bucket's rule can guarantee the maximum_retention if its
+         action is 'Delete' and the only condition is an age(<= maximum_retention)""""""
+         rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
+-        self.assertEqual(1, len(rules_engine.rule_book.resource_rules_map))
++        self.assertTrue(1 <= len(rules_engine.rule_book.resource_rules_map))
+ 
+         data_creater = frsd.FakeBucketDataCreater('fake_bucket', frsd.PROJECT1)
+         data_creater.AddLifecycleDict(action=""Delete"", age=365)",This should be a failure if we don't get the exact number of expected rules. You can use a constant if you don't want to update several lines any time you update the test rule strings.,Why this change?
+7645,"@@ -38,14 +38,14 @@ namespace Nethermind.Blockchain.Synchronization
+             _syncPeerPool = syncPeerPool ?? throw new ArgumentNullException(nameof(syncPeerPool));
+             _syncConfig = syncConfig ?? throw new ArgumentNullException(nameof(syncConfig));
+             _logger = logManager.GetClassLogger() ?? throw new ArgumentNullException(nameof(logManager));
+-            
++
+             Current = SyncMode.NotStarted;
+         }
+ 
+         public SyncMode Current { get; private set; }
+ 
+         public bool IsParallel => Current == SyncMode.FastBlocks || Current == SyncMode.StateNodes;
+-        
++
+         public void Update()
+         {
+             if (_syncPeerPool.PeerCount == 0)","We need to switch from BeamSync to FullSync when we download all the needed headers, blocks, receipts and state",Why did you chan
+7646,"@@ -61,15 +61,15 @@ thrift_protocol_set_property (GObject *object, guint property_id,
+   switch (property_id)
+   {
+     case PROP_THRIFT_PROTOCOL_TRANSPORT:
+-      protocol->transport = g_value_get_object (value);
++      protocol->transport = g_value_dup_object (value);
+       break;
+   }
+ }
+ 
+ 
+ gint32
+-thrift_protocol_write_message_begin (ThriftProtocol *protocol, 
+-                                     const gchar *name, 
++thrift_protocol_write_message_begin (ThriftProtocol *protocol,
++                                     const gchar *name,
+                                      const ThriftMessageType message_type,
+                                      const gint32 seqid, GError **error)
+ {",Why you duplicate it? The underlaying transport should live as long as the multiplexed one. And must be destroyed after protocol is destroyed. Duplicating the transport may lead to object references hold and maybe memory freeing problems. I think this property must hold a reference to it and not a copy. The copy can lead to memory freeing problems.,Why do we need t
+7647,"@@ -97,6 +97,7 @@ func (in *{{.Type}}) GetChaos() *ChaosInstance {
+ 		Kind:      Kind{{.Type}},
+ 		StartTime: in.CreationTimestamp.Time,
+ 		Action:    """",
++		Status:    string(in.Status.ChaosStatus.Experiment.Phase),
+ 		UID:       string(in.UID),
+ 	}
+ ",`in.Status.Experiment.Phase`. we can omit `ChaosStatus`,Status:    in.St
+7648,"@@ -1,9 +1,12 @@
+ package cmd
+ 
+ import (
++	""bytes""
+ 	""testing""
+ 
+ 	""encoding/json""
++	oexec ""os/exec""
++	""time""
+ 
+ 	""github.com/drud/ddev/pkg/ddevapp""
+ 	""github.com/drud/ddev/pkg/exec""",Just curious... why the alias here?,nit: this should be grouped with the other stdlib imports
+7649,"@@ -28,6 +28,7 @@
+         /// </summary>
+         private void InitializeComponent()
+         {
++            System.ComponentModel.ComponentResourceManager resources = new System.ComponentModel.ComponentResourceManager(typeof(DetectionToolbarProperties));
+             this.btnCancel = new System.Windows.Forms.Button();
+             this.btnOk = new System.Windows.Forms.Button();
+             this.label1 = new System.Windows.Forms.Label();",Seems like this should conflict with changes I made during merging of the 20.2 RESX file translation,Why do we need this?
+7650,"@@ -11,6 +11,8 @@
+ #include ""graph/planner/plan/Query.h""
+ #include ""graph/util/ExpressionUtils.h""
+ 
++DEFINE_bool(enable_opt_collapse_project_rule, true, """");
++
+ using nebula::graph::PlanNode;
+ using nebula::graph::QueryContext;
+ ",Why disable this rule?,Why do we need this?
+7651,"@@ -124,6 +124,6 @@ class ExternalEditor(QObject):
+         self._proc.error.connect(self.on_proc_error)
+         editor = config.get('general', 'editor')
+         executable = editor[0]
+-        args = [self._filename if arg == '{}' else arg for arg in editor[1:]]
++        args = [arg.replace('{}', self._filename) if '{}' in arg else arg for arg in editor[1:]]
+         log.procs.debug(""Calling \""{}\"" with args {}"".format(executable, args))
+         self._proc.start(executable, args)","I think you don't need the `... if '{}' in arg else arg` part - if the arg doesn't contain `{}`, `arg.replace('{}', ...)` will return the unchanged string anyways.","I think this should be `arg.replace(self._filename, self."
+7652,"@@ -21,9 +21,11 @@ from google.cloud.security.common.util import log_util
+ from google.cloud.security.common.data_access import errors as dao_errors
+ from google.cloud.security.inventory import errors as inventory_errors
+ from google.cloud.security.inventory.pipelines import base_pipeline
++import threading
+ 
+ 
+ LOGGER = log_util.get_logger(__name__)
++GROUP_CHUNK_SIZE = 20
+ 
+ 
+ class LoadGroupMembersPipeline(base_pipeline.BasePipeline):",nit: Should we make this an attribute of the LoadGroupMembersPIpeline class?,Is this used anywhere?
+7653,"@@ -479,6 +479,8 @@ public class JDBCConnection implements ObjectStoreConnection {
+             + ""JOIN principal ON principal.principal_id=principal_group_member.principal_id ""
+             + ""JOIN domain ON domain.domain_id=principal_group.domain_id ""
+             + ""WHERE principal_group_member.last_notified_time=? AND principal_group_member.server=?;"";
++    private static final String SQL_UPDATE_PRINCIPAL = ""UPDATE principal SET system_suspended=? WHERE principal_id=?;"";
++    private static final String SQL_GET_PRINCIPAL = ""SELECT name FROM principal WHERE system_suspended=?;"";
+ 
+     private static final String CACHE_DOMAIN    = ""d:"";
+     private static final String CACHE_ROLE      = ""r:"";",need to update this command to use the name field instead of principal_id,I think it would be be
+7654,"@@ -51,7 +51,7 @@ public class PrivGetTransactionCount extends PrivacyApiMethod {
+     final Address address = requestContext.getRequiredParameter(0, Address.class);
+     final String privacyGroupId = requestContext.getRequiredParameter(1, String.class);
+ 
+-    final long nonce = privateTransactionHandler.getSenderNonce(address, privacyGroupId);
++    final long nonce = privateTransactionHandler.determineNonce(address, privacyGroupId);
+     return new JsonRpcSuccessResponse(requestContext.getRequest().getId(), Quantity.create(nonce));
+   }
+ }",nit: I can't help but think the privateTransactionHandler should be a base-class member ... every Priv Json RPC seems to need it...,Why is this change nee
+7655,"@@ -230,12 +230,8 @@ public class PreferenceController implements SharedPreferences.OnSharedPreferenc
+                 .setOnPreferenceChangeListener(
+                         (preference, newValue) -> {
+                             Intent i = new Intent(activity, MainActivity.class);
+-                            if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.HONEYCOMB) {
+-                                i.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK
+-                                        | Intent.FLAG_ACTIVITY_NEW_TASK);
+-                            } else {
+-                                i.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK);
+-                            }
++                            i.setFlags(Intent.FLAG_ACTIVITY_CLEAR_TASK
++                                    | Intent.FLAG_ACTIVITY_NEW_TASK);
+                             activity.finish();
+                             activity.startActivity(i);
+                             return true;","Why does this start the main activity and not the preferences? With `overridePendingTransition(0, 0)`, this could instantly switch the theme without the user being disrupted",Why is this change nee
+7656,"@@ -117,6 +117,10 @@ public class DistributorStatus {
+       return up;
+     }
+ 
++    public boolean isDocker() {
++      return up;
++    }
++
+     public int getMaxSessionCount() {
+       return maxSessionCount;
+     }",Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?,Why do we need this?
+7657,"@@ -15,7 +15,7 @@ VERSION = ""2015-06-15""
+ # prerequisite: setuptools
+ # http://pypi.python.org/pypi/setuptools
+ 
+-REQUIRES = [""msrest>=0.1.0"", ""msrestazure>=0.1.0""]
++REQUIRES = [""msrest>=0.2.0"", ""msrestazure>=0.2.1""]
+ 
+ setup(
+     name=NAME,",It appears as though whoever checked in python changes didn't re-run regenerate:expected. I am modifying these files as a result of running that after a sync and build.,This should be `msre
+7658,"@@ -329,4 +329,13 @@ public abstract class FlatteningConfig {
+     paramList.forEach(p -> paramsAsString.append(p.getSimpleName()).append("", ""));
+     return paramsAsString.toString();
+   }
++
++  /** Return if the flattening config contains a parameter that is a resource name. */
++  public static boolean hasAnyResourceNameParameter(FlatteningConfig flatteningGroup) {
++    return flatteningGroup
++        .getFlattenedFieldConfigs()
++        .values()
++        .stream()
++        .anyMatch(FieldConfig::useResourceNameType);
++  }
+ }",This was copied from JavaMethodViewGenerator; only the `public static` method modifiers were added.,nit: `anyMatch` -> `
+7659,"@@ -327,6 +327,18 @@ public class Transaction implements org.hyperledger.besu.plugin.data.Transaction
+     return Optional.ofNullable(maxFeePerGas);
+   }
+ 
++  public long getEffectivePriorityFeePerGas(final Optional<Long> maybeBaseFee) {
++    return maybeBaseFee
++        .filter(__ -> getType().supports1559FeeMarket())
++        .map(
++            baseFee ->
++                Math.max(
++                    0,
++                    Math.min(
++                        getMaxPriorityFeePerGas().get().getAsBigInteger().longValue(),
++                        getMaxFeePerGas().get().getAsBigInteger().longValue() - baseFee)))
++        .orElseGet(() -> getGasPrice().getValue().longValue());
++  }
+   /**
+    * Returns the transaction gas limit.
+    *",this is going to throw for frontier transactions post-london,I think this should 
+7660,"@@ -389,8 +389,6 @@ class PropelInitService
+                 $theliaDatabaseConnection->useDebug(true);
+             }
+         } catch (\Throwable $th) {
+-            Tlog::getInstance()->error(""Failed to initialize Propel : "" . $th->getMessage());
+-
+             throw $th;
+         } finally {
+             // Release cache generation lock",The catch clause is not needed. The finally clause alone is enough.,Why did you remove this?
+7661,"@@ -117,6 +117,10 @@ public class DistributorStatus {
+       return up;
+     }
+ 
++    public boolean isDocker() {
++      return up;
++    }
++
+     public int getMaxSessionCount() {
+       return maxSessionCount;
+     }",Prefer a human-readable string rather than querying specific technologies. How would I indicate a session is running on BrowserStack? Or some custom thing?,Why do we need this?
+7662,"@@ -99,7 +99,7 @@ SRVR_STMT_HDL::SRVR_STMT_HDL(long inDialogueId)
+     moduleName[0] = '\0';
+     inputDescName[0] = '\0';
+     outputDescName[0] = '\0';
+-    isClosed = TRUE;
++    isClosed = FALSE;
+     IPD = NULL;
+     IRD = NULL;
+     useDefaultDesc = FALSE;",Changing the default value for isClosed from TRUE to FALSE can have other repercussions. We might miss throwing error. Can you please confirm this change.,Why is this change neede
+7663,"@@ -286,11 +286,13 @@ func (payloadHandler *payloadRequestHandler) handleUnrecognizedTask(task *ecsacs
+ 	}
+ 
+ 	// Only need to stop the task; it brings down the containers too.
+-	payloadHandler.taskHandler.AddTaskEvent(api.TaskStateChange{
++	te := api.TaskStateChange{
+ 		TaskArn: *task.Arn,
+ 		Status:  api.TaskStopped,
+ 		Reason:  UnrecognizedTaskError{err}.Error(),
+-	}, payloadHandler.ecsClient)
++	}
++
++	payloadHandler.taskHandler.AddStateChangeEvent(te, payloadHandler.ecsClient)
+ }
+ 
+ // clearAcks drains the ack request channel",Please use more meaningful names than `te`here and in other places.,Why do we need this chan
+7664,"@@ -33,8 +33,9 @@ type Catalog interface {
+ 	// the generic Plugin type
+ 	Plugins() []*ManagedPlugin
+ 
+-	// Finds plugin metadata
+-	Find(Plugin) *ManagedPlugin
++	// ConfigFor finds the plugin configuration for the supplied plugin. nil
++	// is returned if the plugin is not managed by the catalog.
++	ConfigFor(interface{}) *PluginConfig
+ }
+ 
+ type Config struct {","Perhaps this would be more idiomatic as `ConfigFor(interface{}) (*PluginConfig, bool)`?",Why is this change necessary?
+7665,"@@ -3,9 +3,10 @@ from requests.models import Request
+ from localstack.utils.common import to_str
+ from localstack.services.generic_proxy import ProxyListener
+ 
++AWS_JSON_CONTENT_TYPE = 'application/x-amz-json-1.1'
+ 
+-class ProxyListenerCloudWatchLogs(ProxyListener):
+ 
++class ProxyListenerCloudWatchLogs(ProxyListener):
+     def forward_request(self, method, path, data, headers):
+         if method == 'POST' and path == '/':
+             if 'nextToken' in to_str(data or ''):",nit: We could import `APPLICATION_AMZ_JSON_1_1` from `constants.py` here.,Why do we need this?
+7666,"@@ -0,0 +1,15 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MS-PL license.
++// See the LICENSE file in the project root for more information.
++
++using System;
++using System.Threading.Tasks;
++
++namespace MvvmCross.Base
++{
++    public interface IMvxMainThreadAsyncDispatcher
++    {
++        Task ExecuteOnMainThreadAsync(Action action, bool maskExceptions = true);
++        Task ExecuteOnMainThreadAsync(Func<Task> action, bool maskExceptions = true);
++    }
++}",Should this not inherit from IMvxMainThreadDispatcher?,Why do we need this interface
+7667,"@@ -19,18 +19,13 @@ import (
+ 
+ type roundCalculator struct {
+ 	chain                  ChainManager
+-	blockInterval          time.Duration
+ 	timeBasedRotation      bool
+ 	rp                     *rolldpos.Protocol
+ 	candidatesByHeightFunc CandidatesByHeightFunc
+ 	beringHeight           uint64
+ }
+ 
+-func (c *roundCalculator) BlockInterval() time.Duration {
+-	return c.blockInterval
+-}
+-
+-func (c *roundCalculator) UpdateRound(round *roundCtx, height uint64, now time.Time, toleratedOvertime time.Duration) (*roundCtx, error) {
++func (c *roundCalculator) UpdateRound(round *roundCtx, height uint64, blockInterval time.Duration, now time.Time, toleratedOvertime time.Duration) (*roundCtx, error) {
+ 	epochNum := round.EpochNum()
+ 	epochStartHeight := round.EpochStartHeight()
+ 	delegates := round.Delegates()",line is 167 characters (from `lll`),`blockInterval` can be remove
+7668,"@@ -13,6 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
++using System.Collections.Generic;
+ using System.Diagnostics;
+ using OpenTelemetry;
+ using OpenTelemetry.Resources;",nit: consider adding a blank line between L15 and L16.,Why is this needed?
+7669,"@@ -445,10 +445,11 @@ void Storage::PopulateLayout(DataLayout &layout)
+     {
+         io::FileReader maneuver_overrides_file(config.GetPath("".osrm.maneuver_overrides""),
+                                                io::FileReader::VerifyFingerprint);
+-        const auto number_of_overrides = maneuver_overrides_file.ReadElementCount64();
++        const auto number_of_overrides =
++            maneuver_overrides_file.ReadVectorSize<extractor::StorageManeuverOverride>();
+         layout.SetBlockSize<extractor::StorageManeuverOverride>(DataLayout::MANEUVER_OVERRIDES,
+                                                                 number_of_overrides);
+-        const auto number_of_nodes = maneuver_overrides_file.ReadElementCount64();
++        const auto number_of_nodes = maneuver_overrides_file.ReadVectorSize<NodeID>();
+         layout.SetBlockSize<NodeID>(DataLayout::MANEUVER_OVERRIDE_NODE_SEQUENCES, number_of_nodes);
+     }
+ ",This is another bug fix: Without skipping the bytes of the vector this would read garbage data.,This should be `Rea
+7670,"@@ -353,10 +353,12 @@ func (bc *blockchain) startExistingBlockchain(recoveryHeight uint64) error {
+ 	}
+ 	ws, err := bc.sf.NewWorkingSet()
+ 	if err != nil {
+-		return errors.Wrap(err, ""Failed to obtain working set from state factory"")
++		return errors.Wrap(err, ""failed to obtain working set from state factory"")
+ 	}
+ 	// If restarting factory from fresh db, first create creator's state
+ 	if startHeight == 0 {
++		actions := loadGenesisData(bc.config)
++		Gen.CreatorPubKey = actions.Creation.PubKey
+ 		if _, err := ws.LoadOrCreateAccountState(Gen.CreatorAddr(bc.ChainID()), Gen.TotalSupply); err != nil {
+ 			return err
+ 		}",why need this? i don't see Gen.CreatorPubKey being used?,Shouldn't this be `
+7671,"@@ -147,6 +147,8 @@ OpenStreetMap::Application.routes.draw do
+   get ""/help"" => ""site#help""
+   get ""/about/:about_locale"" => ""site#about""
+   get ""/about"" => ""site#about""
++  get ""/communities"" => ""site#communities""
++  get ""/communities/:communities_locale"" => ""site#communities""
+   get ""/history"" => ""changesets#index""
+   get ""/history/feed"" => ""changesets#feed"", :defaults => { :format => :atom }
+   get ""/history/comments/feed"" => ""changeset_comments#index"", :as => :changesets_comments_feed, :defaults => { :format => ""rss"" }","As previously mentioned, best to drop this locale override. It's not something we only provide in exceptional circumstances. Moreover, it doesn't work for this PR anyway, while massively increasing the code complexity!",I think this should
+7672,"@@ -24,5 +24,16 @@ var (
+ 		  ""openebs.io/version"": ""{{.}}""
+ 	   }
+ 	}
++ }`
++	// VersionDetailsPatch is generic template for version details patch
++	VersionDetailsPatch = `{
++	""metadata"": {
++	   ""labels"": {
++		  ""openebs.io/version"": ""{{.}}""
++	   }
++	},
++	""versionDetails"": {
++		""desired"": ""{{.}}""
++	}
+  }`
+ )",is this supposed to be `Desired`?,I'm not sure if this is the right place for this. I think it should be in `pkg/apis/kops/v1beta1/templates/version_details.go`
+7673,"@@ -1903,9 +1903,6 @@ public class TestPointQueries extends LuceneTestCase {
+       upperBound[i] = value[i] + random().nextInt(1);
+     }
+     Query query = IntPoint.newRangeQuery(""point"", lowerBound, upperBound);
+-    Weight weight = searcher.createWeight(query, ScoreMode.COMPLETE_NO_SCORES, 1);
+-    Scorer scorer = weight.scorer(searcher.getIndexReader().leaves().get(0));
+-    assertEquals(DocIdSetIterator.all(1).getClass(), scorer.iterator().getClass());
+ 
+     // When not all documents in the query have a value, the optimization is not applicable
+     reader.close();",The iterator is not wrapped when the score mode is set to `COMPLETE_NO_SCORES` so you don't need to change this assertion anymore ?,Why is this test removed?
+7674,"@@ -9,7 +9,8 @@ def render_template(template, destination, **kwargs):
+     template = os.path.join(HERE, template)
+ 
+     folder = os.path.dirname(destination)
+-    os.makedirs(folder)
++    if os.path.exists(folder) == False:
++            os.makedirs(folder)
+ 
+     with codecs.open(template, 'r', encoding='utf-8') as f:
+         raw_template = f.read()",Is there too much spaces there? (should be 4 I think),`if not os.path.exists(folder):`
+7675,"@@ -57,6 +57,8 @@ public class KieClient {
+ 
+   private static final int LONG_POLLING_WAIT_TIME_IN_SECONDS = 30;
+ 
++  private static String revision = ""0"";
++
+   private static final KieConfig KIE_CONFIG = KieConfig.INSTANCE;
+ 
+   private final int refreshInterval = KIE_CONFIG.getRefreshInterval();","IS_FIRST_PULL revision is better to use instance property, not static. When KieClient has only one instance, instance property is better. When KieClient has many instances(not possible), static is not good eitheir.","private static final String DEFAULT_REVISION = ""0"";"
+7676,"@@ -1,4 +1,5 @@
+ <?php
+ return [
+     'extends' => 'bootstrap3',
++    'mixins' => ['fontawesome5_icon_mixin'],
+ ];",This needs to be removed since we removed the mixin.,<?php
+7677,"@@ -219,8 +219,7 @@ RaftPart::RaftPart(ClusterID clusterId,
+         , ioThreadPool_{pool}
+         , bgWorkers_{workers}
+         , executor_(executor)
+-        , snapshot_(snapshotMan)
+-        , weight_(1) {
++        , snapshot_(snapshotMan) {
+     FileBasedWalPolicy policy;
+     policy.ttl = FLAGS_wal_ttl;
+     policy.fileSize = FLAGS_wal_file_size;",Can `weight_` be deleted?,why r
+7678,"@@ -50,6 +50,17 @@ class EasyAdminExtension extends Extension
+         }
+ 
+         $this->ensureBackwardCompatibility($container);
++
++        if ($container->hasParameter('locale')) {
++            $container->getDefinition('easyadmin.configuration.design_config_pass')
++                ->replaceArgument(1, $container->getParameter('locale'));
++        }
++
++        $configPasses = $container->findTaggedServiceIds('easyadmin.config_pass');
++        $definition = $container->getDefinition('easyadmin.config.manager');
++        foreach ($configPasses as $id => $tags) {
++            $definition->addMethodCall('addConfigPass', array(new Reference($id)));
++        }
+     }
+ 
+     /**","This is fine, but by Symfony convention this part is responsability of the compiler pass class, i.e `DependencyInjection\Compiler\?`",you s
+7679,"@@ -9,6 +9,18 @@ module Unix::File
+     execute(""mktemp -td #{name}.XXXXXX"")
+   end
+ 
++  # Create a temporary directory owned by the Puppet user.
++  #
++  # @param name [String] The name of the directory.  It will be suffixed with a
++  #   unique identifier to avoid conflicts.
++  # @return [String] The path to the temporary directory.
++  def puppet_tmpdir(name)
++    dir = tmpdir(name)
++    user = execute(""puppet master --configprint user"")
++    execute(""chown #{user} #{dir}"")
++    dir
++  end
++
+   def path_split(paths)
+     paths.split(':')
+   end",The host object already has a nice way of querying configprint. Try `puppet('master')['user']`,Why d
+7680,"@@ -20,6 +20,7 @@ from mitmproxy.addons import stickycookie
+ from mitmproxy.addons import streambodies
+ from mitmproxy.addons import save
+ from mitmproxy.addons import upstream_auth
++from mitmproxy.addons import upload
+ 
+ 
+ def default_addons():","Let's call this `share` and not `upload` - the user wants to share their flows, uploading is just the implementation of that. :)",from mitmproxy.addons import upload
+7681,"@@ -6,8 +6,9 @@
+ 
+ import wx
+ import gui
++import config
+ 
+-class SpeechViewerFrame(wx.MiniFrame):
++class SpeechViewerFrame(wx.Dialog):
+ 
+ 	def __init__(self):
+ 		super(SpeechViewerFrame, self).__init__(gui.mainFrame, wx.ID_ANY, _(""NVDA Speech Viewer""), style=wx.CAPTION | wx.RESIZE_BORDER | wx.STAY_ON_TOP)","It would be better to keep focus on the main text control. But to get around the fact that Dialogs focus their first child on show, even when not active, something like Dialog.isActive should be chcked when appending text, rather than whether the text control has focus.",`config` is not used.
+7682,"@@ -1205,6 +1205,7 @@ end_and_emit_trace(dcontext_t *dcontext, fragment_t *cur_f)
+         target = opnd_get_pc(instr_get_target(last));
+         md->emitted_size -= local_exit_stub_size(dcontext, target, md->trace_flags);
+     }
++    IF_AARCH64(md->emitted_size += fixup_indirect_trace_exit(dcontext, trace));
+ 
+     if (DYNAMO_OPTION(speculate_last_exit)
+ #ifdef HASHTABLE_STATISTICS",So is this invoked every time we extend the trace?,Why do we need this change?
+7683,"@@ -55,11 +55,16 @@ constexpr int64_t kMaxTimestamp = std::numeric_limits<int64_t>::max() / 10000000
+         return Status::Error(""Invalid second number `%ld'."", kv.second.getInt());
+       }
+       dt.sec = kv.second.getInt();
++    } else if (kv.first == ""millisecond"") {
++      if (kv.second.getInt() < 0 || kv.second.getInt() > 999) {
++        return Status::Error(""Invalid millisecond number `%ld'."", kv.second.getInt());
++      }
++      dt.microsec += kv.second.getInt() * 1000;
+     } else if (kv.first == ""microsecond"") {
+-      if (kv.second.getInt() < 0 || kv.second.getInt() > 999999) {
++      if (kv.second.getInt() < 0 || kv.second.getInt() > 999) {
+         return Status::Error(""Invalid microsecond number `%ld'."", kv.second.getInt());
+       }
+-      dt.microsec = kv.second.getInt();
++      dt.microsec += kv.second.getInt();
+     } else {
+       return Status::Error(""Invlaid parameter `%s'."", kv.first.c_str());
+     }",Why not use switch here?,Shouldn't this be `* 1000`?
+7684,"@@ -37,6 +37,7 @@ type Route struct {
+ 	Method      string
+ 	Path        string
+ 	HandlerFunc HandlerFunc
++	AuthFree    bool // routes that has the AuthFree set to true doesn't require authentication
+ }
+ 
+ // Routes contains all routes",I think `NoAuth` is a better name,// Routes contains all routes that require authentication
+7685,"@@ -214,6 +214,13 @@ func (es *{{ $esapi.Name }}) waitStreamPartClose() {
+ 			es.inputWriter = inputWriter
+ 	}
+ 
++	func (es *{{ $esapi.Name }}) closeInputWriter(r *request.Request) {
++		err := es.inputWriter.Close()
++		if err != nil {
++			r.Error = awserr.New(eventstreamapi.InputWriterCloseErrorCode, err.Error(), r.Error)
++		}
++	}	
++
+ 	// Send writes the event to the stream blocking until the event is written.
+ 	// Returns an error if the event was not written.
+ 	//",This does create a minor bifurcation in how closing the InputWriter is done in success vs failure cases. Is there anyway to merge this with the success exit path? This is something that seems like it would be better as a function closure instead of method on the `$esapi.Name` type. Can the `es.Close` not be used instead of this method?,I don't think this is the right place for this function. 
+7686,"@@ -132,7 +132,6 @@ class RootContext(object):
+ 
+ 
+ class Log(object):
+-
+     def __init__(self, msg, level=""info""):
+         self.msg = msg
+         self.level = level",Please keep this blank line. PEP8 says: > Method definitions inside a class are surrounded by a single blank line.,Why was this removed?
+7687,"@@ -6,7 +6,7 @@
+       <%= link_to(t(:'blacklight.search.per_page.button_label', :count => current_per_page), ""#"") %> <span class=""caret""></span>
+       <ul>
+         <%- blacklight_config.per_page.each do |count| %>
+-          <li><%= link_to(t(:'blacklight.search.per_page.label', :count => count).html_safe, url_for(params_for_search(:per_page => count))) %></li>
++          <li><%= link_to(t(:'blacklight.search.per_page.label', :count => count).html_safe, params_for_search(params.merge(:per_page => count))) %></li>
+         <%- end -%>
+       </ul>
+     </li>",You are not passing in a `:params` key here.,I don't think you need `params.merge(:per_page => count)`
+7688,"@@ -79,6 +79,7 @@ func (i *Initializer) prepareHostNetwork() error {
+ // prepareOVSBridge adds local port and uplink to ovs bridge.
+ // This function will delete OVS bridge and HNS network created by antrea on failure.
+ func (i *Initializer) prepareOVSBridge() error {
++	klog.Info(""preparing ovs bridge ..."")
+ 	hnsNetwork, err := hcsshim.GetHNSNetworkByName(util.LocalHNSNetwork)
+ 	defer func() {
+ 		// prepareOVSBridge only works on windows platform. The operation has a chance to fail on the first time agent","Probably change ""ovs"" to ""OVS"".",I don't think we need this log.
+7689,"@@ -87,7 +87,9 @@ abstract class BaseMediaAdmin extends AbstractAdmin
+             $this->getRequest()->query->set('provider', $provider);
+         }
+ 
+-        $categoryId = $this->getRequest()->get('category');
++        $uniqueId = $this->getRequest()->get('uniqid');
++        $formParams =  $this->getRequest()->get($uniqueId);
++        $categoryId = $formParams && array_key_exists('category', $formParams) ? $formParams['category'] : $this->getRequest()->get('category');
+ 
+         if (null !== $this->categoryManager && !$categoryId) {
+             $categoryId = $this->categoryManager->getRootCategory($context)->getId();",Please linebreak this,Why not use `$this->getRequest(
+7690,"@@ -21,7 +21,7 @@ namespace Nethermind.Blockchain.Data
+ {
+     public class EmptyLocalDataSource<T> : ILocalDataSource<T>
+     {
+-        public T Data { get; } = default;
+-        public event EventHandler Changed;
++        public T? Data { get; }
++        public event EventHandler? Changed;
+     }
+ }","`= default` is implied here, so having it is redundant. Is it a stylistic choice to include it, or just an oversight?",Why is this nullable?
+7691,"@@ -226,7 +226,7 @@ type wsPipelineReader interface {
+ 	wsPipelineManifestReader
+ }
+ 
+-type wsProjectManager interface {
++type wsAppManager interface {
+ 	Create(projectName string) error
+ 	Summary() (*workspace.Summary, error)
+ }",Maybe it's time to fix the param name for this interface?,Should this be `AppManager`?
+7692,"@@ -232,9 +232,6 @@ type (
+ 		CancelRequestId                        string
+ 		StickyTaskQueue                        string
+ 		StickyScheduleToStartTimeout           *time.Duration
+-		ClientLibraryVersion                   string
+-		ClientFeatureVersion                   string
+-		ClientImpl                             string
+ 		AutoResetPoints                        *workflowpb.ResetPoints
+ 		Memo                                   map[string]*commonpb.Payload
+ 		SearchAttributes                       map[string]*commonpb.Payload","Why are we removing it? Looks like useful info. Obviously, field names should change.",Why are these removed?
+7693,"@@ -49,12 +49,18 @@ namespace NLog.LayoutRenderers
+         private const int MaxInitialRenderBufferLength = 16384;
+         private int _maxRenderedLength;
+         private bool _isInitialized;
++        private IValueFormatter _valueFormatter;
+ 
+         /// <summary>
+         /// Gets the logging configuration this target is part of.
+         /// </summary>
+         protected LoggingConfiguration LoggingConfiguration { get; private set; }
+ 
++        /// <summary>
++        /// Value formatter
++        /// </summary>
++        protected IValueFormatter ValueFormatter => _valueFormatter ?? (_valueFormatter = Resolve<IValueFormatter>());
++
+         /// <summary>
+         /// Returns a <see cref=""System.String""/> that represents this instance.
+         /// </summary>",Missing fallback to MessageTemplates.ValueFormatter.Instance,Why do we need this?
+7694,"@@ -1193,7 +1193,7 @@ class _Frame(object):
+ 
+     # TODO: by argument only support the grouping name and as_index only for now. Documentation
+     # should be updated when it's supported.
+-    def groupby(self, by, as_index: bool = True):
++    def groupby(self, by, axis=0, as_index: bool = True):
+         """"""
+         Group DataFrame or Series using a Series of columns.
+ ","The parameter in the docstring should be fixed too. Actually, why don't you try to implement the other axis? It wouldn't be impossible to do if we use pandas UDF from a cursory look. We have enough time before the next release currently.",I think this should be
+7695,"@@ -16,11 +16,13 @@ package patch
+ 
+ import (
+ 	""context""
++	""fmt""
+ 	""os""
+ 	""time""
+ 
+-	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/cloud.google.com/go/osconfig/apiv1alpha1""
+-	osconfigpb ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/google.golang.org/genproto/googleapis/cloud/osconfig/v1alpha1""
++	""cloud.google.com/go/compute/metadata""
++	osconfig ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/cloud.google.com/go/osconfig/apiv1alpha1""
++	api ""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/_internal/gapi-cloud-osconfig-go/google.golang.org/genproto/googleapis/cloud/osconfig/v1alpha1""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/config""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/logger""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/google-osconfig-agent/tasker""",This also runs a patch if its in the middle of one.,nit: remove empty line
+7696,"@@ -248,7 +248,7 @@ func (task *Task) UpdateMountPoints(cont *Container, vols map[string]string) {
+ // there was no change
+ // Invariant: task known status is the minimum of container known status
+ func (task *Task) updateTaskKnownStatus() (newStatus TaskStatus) {
+-	seelog.Debug(""Updating task: %s"", task.String())
++	seelog.Debugf(""Updating task: %s"", task.String())
+ 
+ 	// Set to a large 'impossible' status that can't be the min
+ 	earliestStatus := ContainerZombie",Could we rename this method to `updateKnownStatus` ?,Why is this change needed?
+7697,"@@ -76,6 +76,12 @@ namespace Datadog.Trace
+                                 Tracer.Sampler?.GetSamplingPriority(RootSpan);
+                         }
+                     }
++
++                    // set the origin tag to the root span of each trace/subtrace
++                    if (span.Context.Origin != null)
++                    {
++                        span.SetTag(Tags.Origin, span.Context.Origin);
++                    }
+                 }
+ 
+                 _spans.Add(span);","Maybe it would make sense to move that to DecorateRootSpan? Currently it only has Azure stuff, but given the name of the method I feel like it would be semantically appropriate",Should this be `span.SetTa
+7698,"@@ -5,13 +5,14 @@ import (
+ 	""sync""
+ 
+ 	""github.com/pkg/errors""
+-	coreapi ""k8s.io/api/core/v1""
+-	extnapi ""k8s.io/api/extensions/v1beta1""
+-	networkingv1 ""k8s.io/api/networking/v1""
+-
+ 	""github.com/weaveworks/weave/common""
+ 	""github.com/weaveworks/weave/net/ipset""
+ 	""github.com/weaveworks/weave/npc/iptables""
++	coreapi ""k8s.io/api/core/v1""
++	extnapi ""k8s.io/api/extensions/v1beta1""
++	networkingv1 ""k8s.io/api/networking/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	""k8s.io/client-go/kubernetes""
+ )
+ 
+ type NetworkPolicyController interface {",nit: these imports were in a separate group to ones from this repo,nit: remove empty line
+7699,"@@ -22,4 +22,12 @@ public enum DispatchMethod {
+   public static boolean isPollMethodEnabled(String dispatchMethod) {
+     return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.POLL;
+   }
++
++  public static boolean isPushMethodEnabled(String dispatchMethod) {
++    return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.PUSH;
++  }
++
++  public static boolean isPushContainerizedMethodEnabled(String dispatchMethod) {
++    return DispatchMethod.getDispatchMethod(dispatchMethod) == DispatchMethod.PUSH_CONTAINERIZED;
++  }
+ }",Is it possible to rename the methods to `isXXXMethod` to keep the usage by the caller generic? The caller could use the result of these methods to verify whether a feature is enabled or to validate an input value for example.,nit: `isPushMethodEnabled`
+7700,"@@ -38,13 +38,15 @@ var PATH_SEPARATOR = process.platform === 'win32' ? ';' : ':';
+ exports.rmDir = function(path) {
+   return new promise.Promise(function(fulfill, reject) {
+     var numAttempts = 0;
++    var maxAttempts = 5;
++    var attemptTimeout = 250;
+     attemptRm();
+     function attemptRm() {
+       numAttempts += 1;
+       rimraf(path, function(err) {
+         if (err) {
+-          if (err.code === 'ENOTEMPTY' && numAttempts < 2) {
+-            attemptRm();
++          if (err.code === 'ENOTEMPTY' && numAttempts <= maxAttempts) {
++            setTimeout(attemptRm, attemptTimeout);
+             return;
+           }
+           reject(err);",Don't penalize everyone with 250ms delay b/c some machines have problems.,I think this should be `numAttempts <= maxAttempts`
+7701,"@@ -130,7 +130,11 @@ public final class UserUtils {
+             // Match!
+             // reparse the config file
+             log.info(""Modification detected, reloading config file "" + filename);
+-            configFileMap.get(filename).parseConfigFile();
++            try {
++              configFileMap.get(filename).parseConfigFile();
++            } catch (Exception e) {
++              log.error(""Failed parsing config file after update: "" + filename, e);
++            }
+             break;
+           }
+         }","This try-catch should be here so that watcher thread doesn't just exit in case of an exception. This change alone would probably be enough to fix the error as well, assuming that there's another `ENTRY_MODIFY` event when the file write is finalized. But of course not a perfect fix because it doesn't protect against possibly reading a non-empty but only partially written file?",Shouldn't this be a warning?
+7702,"@@ -417,6 +417,9 @@ func (s *Server) sendInternalMsg(sub, rply string, si *ServerInfo, msg interface
+ 
+ // Locked version of checking if events system running. Also checks server.
+ func (s *Server) eventsRunning() bool {
++	if s == nil {
++		return false
++	}
+ 	s.mu.Lock()
+ 	er := s.running && s.eventsEnabled()
+ 	s.mu.Unlock()",Weird that we have to check for `s == nil` here.. I would instead have fixed the call stack to find out when this gets invoked with a nil server.,Why is this nil check needed?
+7703,"@@ -228,7 +228,7 @@ export default Controller.extend({
+         if (erroredEmails.length > 0) {
+             invitationsString = erroredEmails.length > 1 ? ' invitations: ' : ' invitation: ';
+             message = `Failed to send ${erroredEmails.length} ${invitationsString}`;
+-            message += erroredEmails.join(', ');
++            message += Ember.Handlebars.Utils.escapeExpression(erroredEmails.join(', '));
+             message += '. Please check your email configuration, see <a href=\'https://docs.ghost.org/docs/mail-config\' target=\'_blank\'>https://docs.ghost.org/v1.0.0/docs/mail-config</a> for instructions';
+ 
+             message = htmlSafe(message);",The `import` statement for `Ember` is missing in this file.,This should be `Ember.Handlebars.Utils.escapeExpres
+7704,"@@ -90,7 +90,7 @@ export function diff(dom, parentDom, newVNode, oldVNode, context, isSvg, excessD
+ 			let s = c._nextState || c.state;
+ 			if (newType.getDerivedStateFromProps!=null) {
+ 				oldState = assign({}, c.state);
+-				if (s===c.state) s = assign({}, s);
++				if (s===c.state) s = c._nextState = assign({}, s);
+ 				assign(s, newType.getDerivedStateFromProps(newVNode.props, s));
+ 			}
+ ",Awesome :tada: I'd love to have a test case for this so that we don't regress on this feature in any future refactorings :+1:,Why this change?
+7705,"@@ -28,7 +28,7 @@ class SeriesDateTimeTest(ReusedSQLTestCase, SQLTestUtils):
+ 
+     @property
+     def pdf1(self):
+-        date1 = pd.Series(pd.date_range('2012-1-1 12:00:00', periods=3, freq='M'))
++        date1 = pd.Series(pd.date_range('2012-1-1 12:45:31', periods=3, freq='M'))
+         date2 = pd.Series(pd.date_range('2013-3-11 21:45:00', periods=3, freq='W'))
+         return pd.DataFrame(dict(start_date=date1, end_date=date2))
+ ",For testing some of the rounding functions,why this change?
+7706,"@@ -56,6 +56,10 @@ class CurrencyDataFixture extends AbstractReferenceFixture
+          * @see \Shopsys\FrameworkBundle\Migrations\Version20180603135342
+          */
+         $currencyCzk = $this->currencyFacade->getById(1);
++        $currencyData = $this->currencyDataFactory->createFromCurrency($currencyCzk);
++        $currencyData->minFractionDigits = Currency::DEFAULT_MIN_FRACTION_DIGITS;
++        $currencyData->roundingType = Currency::ROUNDING_TYPE_INTEGER;
++        $currencyCzk = $this->currencyFacade->edit($currencyCzk->getId(), $currencyData);
+         $this->addReference(self::CURRENCY_CZK, $currencyCzk);
+ 
+         if (count($this->domain->getAll()) > 1) {",This should be present in UPGRADE notes. Also on currently running projects you should suggest users to update these settings.,Why do we need t
+7707,"@@ -1053,10 +1053,9 @@ func (bdl *backpressureDiskLimiter) reserveBytes(
+ 	if count < 0 {
+ 		return count, nil
+ 	}
+-	// We calculate the total free bytes by adding the reported free bytes and
+-	// the non-`tracker` used bytes.
+-	tracker.updateFree(freeBytes + bdl.overallByteTracker.used -
+-		tracker.usedResources())
++	// TODO: verify there's not any other kind of bytes we care about
++	// subtracting too.
++	tracker.updateFree(freeBytes)
+ 
+ 	count = tracker.tryReserve(blockBytes)
+ 	if count < 0 {","Are you sure you want to do this? This will affect the working set block cache too, such that it'll now be tracking global free space. It throws off the fraction calculation.",Why do we need t
+7708,"@@ -44,6 +44,7 @@ bool CompoundReaderListener::hasReaderAttached(){
+ 	return false;
+ }
+ ReaderListener* CompoundReaderListener::getAttachedListener(){
++	std::lock_guard<std::mutex> lock(attached_listener_mutex);
+ 	if(attached_listener != nullptr)
+ 		return attached_listener;
+ 	return nullptr;",Why would the read access need to be mutexed? The caller might still get a wrong answer since the value might change immediately after the mutex is unlocked before the caller receives the value.,Why do we need a lock here?
+7709,"@@ -631,6 +631,16 @@ class TabbedBrowser(tabwidget.TabWidget):
+         if config.val.tabs.tabs_are_windows:
+             self.window().setWindowIcon(icon)
+ 
++    @pyqtSlot(usertypes.KeyMode)
++    def on_mode_entered(self, mode):
++        """"""Save input mode when tabs.mode_on_change = restore.""""""
++        input_modes = [usertypes.KeyMode.insert, usertypes.KeyMode.passthrough]
++        if (mode in input_modes and
++                config.val.tabs.mode_on_change == 'restore'):
++            tab = self.currentWidget()
++            if tab and tab is not None:
++                tab.data.input_mode = mode
++
+     @pyqtSlot(usertypes.KeyMode)
+     def on_mode_left(self, mode):
+         """"""Give focus to current tab if command mode was left.""""""",This fits on one line without the parentheses :wink:,Why not just `if mode in in
+7710,"@@ -64,7 +64,7 @@ public class TestCloudRecovery extends SolrCloudTestCase {
+ 
+   @Before
+   public void beforeTest() throws Exception {
+-    configureCluster(2)
++    configureCluster(4)
+         .addConfig(""config"", TEST_PATH().resolve(""configsets"").resolve(""cloud-minimal"").resolve(""conf""))
+         .configure();
+ ",Looks like `TestCloudRecovery` changes are unrelated?,Why is this change needed?
+7711,"@@ -10,16 +10,14 @@ declare(strict_types = 1);
+ namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute;
+ 
+ use Doctrine\DBAL\Connection;
++use Doctrine\DBAL\DBALException;
+ use Ergonode\Attribute\Domain\Event\Attribute\AttributeHintChangedEvent;
+ use Ergonode\Core\Domain\Entity\AbstractId;
+-use Ergonode\EventSourcing\Infrastructure\DomainEventInterface;
+-use Ergonode\EventSourcing\Infrastructure\Exception\UnsupportedEventException;
+-use Ergonode\EventSourcing\Infrastructure\Projector\DomainEventProjectorInterface;
+ use Ramsey\Uuid\Uuid;
+ 
+ /**
+  */
+-class AttributeHintChangedEventProjector implements DomainEventProjectorInterface
++class AttributeHintChangedEventProjector
+ {
+     private const TABLE = 'value_translation';
+ ",Try to separate it to different methods. Invoke is huge :),Why did you remove this int
+7712,"@@ -16,7 +16,7 @@
+           </thead>
+           <tbody>
+             <% scope.each do |plan| %>
+-              <tr>
++              <tr id=""<%= dom_id(plan) %>"">
+                 <td>
+                   <%= link_to ""#{plan.title.length > 60 ? ""#{plan.title[0..59]} ..."" : plan.title}"",
+                       plan_path(plan) %>",Looks like another spot that would benefit from `truncate`,I think this should be `dom_id(plan.id)`
+7713,"@@ -272,7 +272,7 @@ static mrb_value build_constants(mrb_state *mrb, const char *server_name, size_t
+             mrb_ary_set(mrb, ary, i, lit);
+         }
+         for (; i != H2O_MAX_TOKENS * 2; ++i) {
+-            const h2o_token_t *token = h2o__tokens + i - H2O_MAX_TOKENS;
++            const h2o_token_t *token = h2o__tokens + (i - H2O_MAX_TOKENS);
+             mrb_value lit = mrb_nil_value();
+             if (token == H2O_TOKEN_CONTENT_TYPE) {
+                 lit = mrb_str_new_lit(mrb, ""CONTENT_TYPE"");","This change is not related to what this PR wanted to fix, but undefined behavior sanitizer warns without this parenthesis because `h2o__tokens + i` overflows.",Why is this change needed?
+7714,"@@ -223,7 +223,7 @@ class DocstringParameterChecker(BaseChecker):
+ 
+         # skip functions that match the 'no-docstring-rgx' config option
+         no_docstring_rgx = get_global_option(self, ""no-docstring-rgx"")
+-        if no_docstring_rgx and re.match(no_docstring_rgx, node.name):
++        if no_docstring_rgx.pattern and re.match(no_docstring_rgx, node.name):
+             return
+ 
+         # skip functions smaller than 'docstring-min-length'","This is actually incorrect and should be the other way around. Going to fix this tomorrow. If `no_docstring_rgx == re.compile("""")` no function should be checked, since every function matches the pattern. If `no_docstring_rgx == re.compile(""^$"")` all functions should be checked.",I think this should be `if no_docstring_
+7715,"@@ -95,7 +95,7 @@ def get_spotify_oauth():
+     """"""
+     client_id = current_app.config['SPOTIFY_CLIENT_ID']
+     client_secret = current_app.config['SPOTIFY_CLIENT_SECRET']
+-    scope = 'user-read-recently-played'
++    scope = 'user-read-recently-played user-read-currently-playing'
+     redirect_url = current_app.config['SPOTIFY_CALLBACK_URL']
+     return spotipy.oauth2.SpotifyOAuth(client_id, client_secret, redirect_uri=redirect_url, scope=scope)
+ ",Should this be in a config file?,I think this should be `user-read-recent
+7716,"@@ -3,13 +3,15 @@ const {
+   eachAsync,
+   executeLegacyOperation,
+   makeInterruptibleAsyncInterval,
+-  BufferPool
++  BufferPool,
++  shuffle
+ } = require('../../src/utils');
+ const { expect } = require('chai');
+ const sinon = require('sinon');
++const { MongoRuntimeError } = require('../../src/error');
+ 
+-describe('utils', function () {
+-  context('eachAsync', function () {
++describe('driver utils', function () {
++  context('eachAsync function', function () {
+     it('should callback with an error', function (done) {
+       eachAsync(
+         [{ error: false }, { error: true }],","purely preference, but have you considered using parentheses to indicate that a method is being tested? e.g., `describe('eachAsync()')`",Why this change?
+7717,"@@ -449,9 +449,10 @@ ResultCode RocksEngine::createCheckpoint(const std::string& name) {
+     auto checkpointPath = folly::stringPrintf(""%s/checkpoints/%s/data"",
+                                               dataPath_.c_str(), name.c_str());
+     LOG(INFO) << ""Target checkpoint path : "" << checkpointPath;
+-    if (fs::FileUtils::exist(checkpointPath)) {
+-        LOG(ERROR) << ""The snapshot file already exists: "" << checkpointPath;
+-        return ResultCode::ERR_CHECKPOINT_ERROR;
++    if (fs::FileUtils::exist(checkpointPath) &&
++        !fs::FileUtils::remove(checkpointPath.data(), true)) {
++            LOG(ERROR) << ""Remove exist dir failed of checkpoint : "" << checkpointPath;
++            return ResultCode::ERR_IO_ERROR;
+     }
+ 
+     auto parent = checkpointPath.substr(0, checkpointPath.rfind('/'));",Why not return success?,Should this be `
+7718,"@@ -3,12 +3,19 @@ namespace Psalm\Report;
+ 
+ use Psalm\Config;
+ use Psalm\Internal\Analyzer\DataFlowNodeData;
++use Psalm\Internal\Analyzer\IssueData;
+ use Psalm\Report;
+ 
++use function get_cfg_var;
++use function ini_get;
++use function strtr;
+ use function substr;
+ 
+ class ConsoleReport extends Report
+ {
++    /** @var string|null */
++    private $linkFormat;
++
+     public function create(): string
+     {
+         $output = '';",Please use snake_case for properties to keep it consistent with the rest of the codebase.,Why do we need t
+7719,"@@ -304,7 +304,9 @@ func New(ctx context.Context, signer beecrypto.Signer, networkID uint64, overlay
+ 		}
+ 
+ 		s.metrics.HandledStreamCount.Inc()
+-		s.logger.Infof(""successfully connected to peer (inbound) %s"", i.BzzAddress.ShortString())
++		s.logger.Debugf(""successfully connected to peer (inbound) %s"", i.BzzAddress.ShortString())
++		s.logger.Infof(""successfully connected to peer (inbound)"")
++
+ 	})
+ 
+ 	h.Network().SetConnHandler(func(_ network.Conn) {",i don't understand why we need this change. what information is this providing when running in less than Debug loglevel? I prefer to revert this,I don't think th
+7720,"@@ -170,6 +170,9 @@ public class ExecutionFlowDaoTest {
+     final List<ExecutableFlow> flows = this.executionFlowDao
+         .fetchRecentlyFinishedFlows(RECENTLY_FINISHED_LIFETIME);
+     assertThat(flows.size()).isEqualTo(0);
++
++    //Restore the clock
++    DateTimeUtils.setCurrentMillisOffset(0);
+   }
+ 
+   @Test","Oh, so this test leaks DateTimeUtils offset? It would be safer to place the reset in an `@After` method to not cause side effects even if the test case fails.",Why is this needed?
+7721,"@@ -28,14 +28,6 @@ import { Grid, Cell, Row } from '../../../../../material-components';
+ import Pagination from './Pagination';
+ 
+ export default function Footer( { tab, footerText } ) {
+-	if ( ! footerText ) {
+-		return (
+-			<div className=""googlesitekit-idea-hub__footer"">
+-				<Pagination tab={ tab } />
+-			</div>
+-		);
+-	}
+-
+ 	return (
+ 		<Grid className=""googlesitekit-idea-hub__footer"">
+ 			<Row>","Kind of a nit-pick, but is there no way to solve this while still not rendering an empty div if `footerText` is empty? We could still use the `Row` to maintain the same layout but then only render the `Cell` for the pagination - I think it's possible to use specific classes to horizontally offset?",Why was this remove
+7722,"@@ -23,12 +23,14 @@ import java.util.Objects;
+ public class DomainChangeMessage {
+     
+     // Represent the changed object type 
+-    enum ObjectType {
++    public enum ObjectType {
+         DOMAIN, 
+-        ROLE, 
++        ROLE,
++        GROUP,
+         POLICY, 
+-        SERVICE, 
+-        ENTITY
++        SERVICE,
++        ENTITY,
++        TEMPLATE
+     } 
+     
+     private String domainName;","Template is also not an object type so I don't expect to notify on templates. Instead when applying templates, we'll be updating roles/policies/services/groups.",Why is this public?
+7723,"@@ -93,7 +93,8 @@ class iloc(Accessor):
+         rows, cols = index
+         if rows is Ellipsis:
+             rows = slice(None)
+-        data = dataset.interface.iloc(dataset.dataset, (rows, cols))
++
++        data = dataset.interface.iloc(dataset, (rows, cols))
+         kdims = dataset.kdims
+         vdims = dataset.vdims
+         if np.isscalar(data):",Had to fix this to get my tests passing (should have been a new PR sorry).,I think this should
+7724,"@@ -91,6 +91,11 @@ type VaultIssuer struct {
+ 	Server string `json:""server""`
+ 	// Vault URL path to the certificate role
+ 	Path string `json:""path""`
++	// Base64 encoded CA bundle to validate Vault server certificate. Only used
++	// if the Server URL is using HTTPS protocol. This parameter is ignored for
++	// plain HTTP protocol connection. If not set the system root certificates
++	// are used to validate the TLS connection.
++	CABundle []byte `json:""caBundle""`
+ }
+ 
+ // Vault authentication  can be configured:","Small nit, and sorry for not spotting sooner.. this should have `omitempty` on it, else when marshalling nil values into json, it will be `caBundle: null` which trips up some JSON parsers",Why do we need this?
+7725,"@@ -1030,6 +1030,9 @@ class GenericLayoutPlot(GenericCompositePlot):
+     displays the elements in a cartesian grid in scanline order.
+     """"""
+ 
++    transpose = param.Boolean(default=False, doc=""""""
++        Whether to transpose the layout when plotting"""""")
++
+     def __init__(self, layout, **params):
+         if not isinstance(layout, (NdLayout, Layout)):
+             raise ValueError(""GenericLayoutPlot only accepts Layout objects."")","Would be good to say the normal behavior is scanline order (left to right, top to bottom) and that transposing makes it work top to bottom and left to right.",I don't think this s
+7726,"@@ -326,6 +326,17 @@ Photos folder"" option in your google drive settings. You can then copy
+ or move the photos locally and use the date the image was taken
+ (created) set as the modification date.`,
+ 			Advanced: true,
++		}, {
++			Name:    ""use_shared_date"",
++			Default: false,
++			Help: `Use date file was shared instead of modified date.
++
++Note that, as with ""--drive-use-created-date"", this flag may have
++unexpected consequences when uploading/downloading files.
++
++If both this flag and ""--drive-use-created-date"" are set, the created
++date is used.`,
++			Advanced: true,
+ 		}, {
+ 			Name:     ""list_chunk"",
+ 			Default:  1000,",Perhaps note here that `--drive-use-created-date` takes precedence if both set?,I think it would be 
+7727,"@@ -128,7 +128,7 @@ class DynamicRoIHead(StandardRoIHead):
+         bbox_results.update(loss_bbox=loss_bbox)
+         return bbox_results
+ 
+-    def update_hyperparameters(self):
++    def update_hyperparameters(self, eps=1e-15):
+         """"""Update hyperparameters like IoU thresholds for assigner and beta for
+         SmoothL1 loss based on the training statistics.
+ ",Use EPS=1e-15 as that in atss_head or FCOS head.,why do we need to ch
+7728,"@@ -40,7 +40,7 @@ func TestBlobSaver(t *testing.T) {
+ 
+ 	tmb, ctx := tomb.WithContext(ctx)
+ 	saver := &saveFail{
+-		idx: repository.NewIndex(),
++		idx: repository.NewMasterIndex(),
+ 	}
+ 
+ 	b := NewBlobSaver(ctx, tmb, saver, uint(runtime.NumCPU()))",Is there a need to replace the Index with a MasterIndex?,Why do we need this change?
+7729,"@@ -389,6 +389,7 @@ func TestExecCommandAgent(t *testing.T) {
+ 
+ 	verifyExecCmdAgentExpectedMounts(t, ctx, client, testTaskId, cid, testContainerName, testExecCmdHostBinDir)
+ 	pidA := verifyMockExecCommandAgentIsRunning(t, client, cid)
++	verifyExecAgentRunningStateChange(t, taskEngine)
+ 	seelog.Infof(""Verified mock ExecCommandAgent is running (pidA=%s)"", pidA)
+ 	killMockExecCommandAgent(t, client, cid, pidA)
+ 	seelog.Infof(""kill signal sent to ExecCommandAgent (pidA=%s)"", pidA)",are we adding stop state change in a different PR?,Why do we need this?
+7730,"@@ -23,9 +23,9 @@ class PlansController < ApplicationController
+     # Get all of the available funders and non-funder orgs
+     @funders = Org.funder
+                   .joins(:templates)
+-                  .where(templates: { published: true }).uniq.sort(&:name)
++                  .where(templates: { published: true }).uniq.sort_by(&:name)
+     @orgs = (Org.organisation + Org.institution + Org.managing_orgs).flatten
+-                                                                    .uniq.sort(&:name)
++                                                                    .uniq.sort_by(&:name)
+ 
+     # Get the current user's org
+     @default_org = current_user.org if @orgs.include?(current_user.org)",How much difference is there between sort and sort_by ?,Style/SymbolProc: Pass &:na
+7731,"@@ -231,6 +231,7 @@ STATIC int opae_plugin_mgr_initialize_all(void)
+ 	int res;
+ 	opae_api_adapter_table *aptr;
+ 	int errors = 0;
++	int count = 0;
+ 
+ 	for (aptr = adapter_list; aptr; aptr = aptr->next) {
+ ",count doesn't seem to be used. Let's remove it.,Why do we need this variabl
+7732,"@@ -18,7 +18,11 @@ module Mongoid
+       #
+       # @since 4.0.0
+       def cache_table
+-        Thread.current[""[mongoid]:query_cache""] ||= {}
++        if defined?(Mongo::QueryCache)
++          Mongo::QueryCache.cache_table
++        else
++          Thread.current[""[mongoid]:query_cache""] ||= {}
++        end
+       end
+ 
+       # Clear the query cache.",Mongo is a hard dependency for Mongoid. Why do we need an if-statement to if it's defined? We should always use Mongo::QueryCache,"I think this should be `Thread.current[""[mongoid]:query_cache""] ||= {}`"
+7733,"@@ -0,0 +1,6 @@
++class AddFunderAndOrgToPlans < ActiveRecord::Migration
++  def change
++    add_reference :plans, :org, foreign_key: true
++    add_column :plans, :funder_id, :integer, index: true
++  end
++end","Does this point out at a ROR funder id? If so, could we get rid of the `funder_name` field on the plan and just use the `name` of the funder with id `funder_id`?",I don't think we need a foreign key here.
+7734,"@@ -3,8 +3,12 @@ var assert = require('assert');
+ var fs = require('fs');
+ 
+ var flatbuffers = require('../js/flatbuffers').flatbuffers;
++global.flatbuffers = flatbuffers;
++
+ var MyGame = require(process.argv[2]).MyGame;
+ 
++var isTsTest = process.env.FB_TS_TEST ? true : false; 
++
+ function main() {
+ 
+   // First, let's test reading a FlatBuffer generated by C++ code:","Use !! to cast to bool, rather than the ternary bool antipattern.",Why is this needed?
+7735,"@@ -145,7 +145,7 @@ func (cmd CmdSnapshots) Execute(args []string) error {
+ 		tab.Rows = append(tab.Rows, []interface{}{sn.ID()[:plen/2], sn.Time.Format(TimeFormat), sn.Hostname, sn.Paths[0]})
+ 
+ 		if len(sn.Paths) > 1 {
+-			for _, path := range sn.Paths {
++			for _, path := range sn.Paths[1:] {
+ 				tab.Rows = append(tab.Rows, []interface{}{"""", """", """", path})
+ 			}
+ 		}",why is it in the list twice to begin with?,Why is this change needed?
+7736,"@@ -890,6 +890,10 @@ void Player::sendPing()
+ 			return;
+ 		}
+ 
++		if (pzLocked) {
++			return;
++		}
++
+ 		if (!g_creatureEvents->playerLogout(this)) {
+ 			return;
+ 		}",This way you will **never** be kicked while monsters are around you.,Shouldn't this be `if (!pzLocked)`?
+7737,"@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
+ import org.junit.Before;
+ import org.junit.Test;
+ 
++import java.lang.reflect.InvocationTargetException;
+ import java.lang.reflect.Method;
+ import java.util.Arrays;
+ ",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,import static org.junit.Assert.*;
+7738,"@@ -110,5 +110,5 @@ export default function ModulesList( { moduleSlugs } ) {
+ }
+ 
+ ModulesList.propTypes = {
+-	moduleSlug: PropTypes.arrayOf( PropTypes.string ).isRequired,
++	moduleSlugs: PropTypes.arrayOf( PropTypes.string ).isRequired,
+ };","This just fixes an unrelated prop type error, correct?",export default {
+7739,"@@ -1022,7 +1022,7 @@ func (fbo *folderBlockOps) updateWithDirtyEntriesLocked(ctx context.Context,
+ 	}
+ 
+ 	// Remove cached removals from the copy.
+-	for k := range dirCacheEntry.adds {
++	for k := range dirCacheEntry.dels {
+ 		_, ok := dblock.Children[k]
+ 		if !ok {
+ 			continue",This was a bug in KBFS-2071 -- oops.,I'm not sure if this is the right w
+7740,"@@ -82,9 +82,18 @@ type PaymentChannel struct {
+ 	// payer and payee upon initialization or extension
+ 	AgreedEol *types.BlockHeight `json:""agreed_eol""`
+ 
++	// Conditions are the set of conditions for redeeming or closing the payment
++	// channel
++	Conditions *types.Predicate `json:""conditions""`
++
+ 	// Eol is the actual expiration for the payment channel which can differ from
+ 	// AgreedEol when the payment channel is in dispute
+ 	Eol *types.BlockHeight `json:""eol""`
++
++	// Redeemed is a flag indicating whether or not Redeem has been called on the
++	// payment channel yet. This is necessary because AmountRedeemed can still be
++	// zero in the event of a zero-value voucher
++	Redeemed bool `json:""redeemed""`
+ }
+ 
+ // Actor provides a mechanism for off chain payments.",// Condition is a condition for ... Condition,Why is this a pointer?
+7741,"@@ -207,6 +207,16 @@ describe ""National Capital Region proposals"" do
+       expect(current_path).to eq(""/proposals/#{work_order.proposal.id}"")
+     end
+ 
++    it ""does not resave unchanged requests"" do 
++      visit ""/ncr/work_orders/#{work_order.id}/edit""
++      click_on 'Submit for approval'
++      visit ""/ncr/work_orders/#{work_order.id}/edit""
++      click_on 'Submit for approval'
++
++      expect(current_path).to eq(""/proposals/#{work_order.proposal.id}"")
++      expect(page).to have_content(""No changes were made to the request"")
++    end
++
+     it ""has a disabled field if first approval is done"" do
+       visit ""/ncr/work_orders/#{work_order.id}/edit""
+       expect(find(""[name=approver_email]"")[""disabled""]).to be_nil","Might be good to test that no emails were sent out, either. You should be able to use `deliveries` for this",Prefer single-quoted s
+7742,"@@ -80,7 +80,7 @@ public class Connection implements Closeable {
+       serialized.put(""sessionId"", sessionId);
+     }
+ 
+-    LOG.info(JSON.toJson(serialized.build()));
++    LOG.finest(JSON.toJson(serialized.build()));
+     socket.sendText(JSON.toJson(serialized.build()));
+ 
+     if (!command.getSendsResponse() ) {",Right now this is experimental and deeply flaky. We left this at `info` to make debugging user reports a lot easier.,Why is this change nee
+7743,"@@ -17,6 +17,11 @@ namespace UpdateVendors
+ //------------------------------------------------------------------------------
+ "";
+ 
++        private static readonly List<string> FilesToSkip = new List<string>()
++        {
++            @""\Serilog\Events\LogEventLevel.cs"",
++        };
++
+         private static readonly string DownloadDirectory = Path.Combine(Environment.CurrentDirectory, ""downloads"");
+         private static string _vendorProjectDirectory;
+ ",Is this new list being consumed yet?,Why do we need this?
+7744,"@@ -18,18 +18,14 @@ import (
+ 	""bytes""
+ 	""encoding/json""
+ 	""io""
+-	weakrand ""math/rand""
+ 	""net""
+ 	""net/http""
+ 	""strconv""
+-	""time""
+ 
+ 	""github.com/caddyserver/caddy/v2""
+ )
+ 
+ func init() {
+-	weakrand.Seed(time.Now().UnixNano())
+-
+ 	caddy.RegisterModule(tlsPlaceholderWrapper{})
+ }
+ ",moved to `errors.go` which is the only places `math/rand` is used in this package,Why was this removed?
+7745,"@@ -3,8 +3,8 @@
+ namespace Shopsys\FrameworkBundle\Component\Error;
+ 
+ use AppKernel;
+-use Shopsys\Environment;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
++use Shopsys\FrameworkBundle\Component\Environment\EnvironmentType;
+ use Shopsys\FrameworkBundle\Component\Router\DomainRouterFactory;
+ use Symfony\Component\Filesystem\Filesystem;
+ use Symfony\Component\HttpFoundation\Request;","This use is wrong, corrent is: `Shopsys\FrameworkBundle\Component\Environment` It is the same in classes below",Why do we need this c
+7746,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+ 
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression.",Shouldn't this be `re
+7747,"@@ -323,11 +323,6 @@ func updateContainerMetadata(metadata *dockerapi.DockerContainerMetadata, contai
+ 		container.SetLabels(metadata.Labels)
+ 	}
+ 
+-	// Update Volume
+-	if metadata.Volumes != nil {
+-		task.UpdateMountPoints(container, metadata.Volumes)
+-	}
+-
+ 	// Set Exitcode if it's not set
+ 	if metadata.ExitCode != nil {
+ 		container.SetKnownExitCode(metadata.ExitCode)","For my understanding, why was this removed?",Why is this being rem
+7748,"@@ -36,14 +36,13 @@ namespace Nethermind.Runner
+         protected override (CommandLineApplication, Func<IConfigProvider>, Func<string>) BuildCommandLineApp()
+         {
+             string pluginsDirectory = Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""plugins"");
+-            Console.WriteLine($""Loading plugins from: {pluginsDirectory}"");
+             if (Directory.Exists(pluginsDirectory))
+             {
+                 var plugins = Directory.GetFiles(pluginsDirectory, ""*.dll"");
+                 foreach (string plugin in plugins)
+                 {
+-                    Console.WriteLine($""Loading plugin {plugin} from {pluginsDirectory}"");
+                     string pluginName = plugin.Contains(""/"") ? plugin.Split(""/"").Last() : plugin.Split(""\\"").Last();
++                    Console.WriteLine($""Loading plugin: {pluginName}"");
+                     AssemblyLoadContext.Default.LoadFromAssemblyPath(plugin);
+                 }
+             }",the whole idea was to display information on the plugin directory in case it was missing - need to add if...else... and display the plugin dir if it is configured (non empty) but cannot be found,Why was this removed?
+7749,"@@ -154,6 +154,11 @@ public class LoginActivity extends BaseActivity implements CustomTabActivityHelp
+             loginView.requestFocus();
+             return;
+         }
++        if (TextUtils.isEmpty(password)) {
++            Toast.makeText(this, getString(R.string.error_field_required), Toast.LENGTH_SHORT).show();
++            passwordView.requestFocus();
++            return;
++        }
+         if (!(password.length() >= 6)) {
+             passwordView.setError(getString(R.string.error_invalid_password));
+             passwordView.requestFocus();","Can you please set this as an error on the password view, rather than a toast, just to make sure that it is kept consistent. Check out a couple of lines below.",I think this should b
+7750,"@@ -114,7 +114,7 @@ func consumerConnectFlow(t *testing.T, tequilapi *tequilapi_client.Client, consu
+ 	})
+ 	assert.NoError(t, err)
+ 
+-	connectionStatus, err = tequilapi.Connect(consumerID, proposal.ProviderID, endpoints.ConnectOptions{true})
++	connectionStatus, err = tequilapi.Connect(consumerID, proposal.ProviderID, ""openvpn"", endpoints.ConnectOptions{true})
+ 	assert.NoError(t, err)
+ 
+ 	err = waitForCondition(func() (bool, error) {",Shouldn't we pass here a proposal too?,Why do we need this c
+7751,"@@ -85,5 +85,11 @@ def test_dupe_solid_repo_definition():
+         },
+     )
+ 
+-    with pytest.raises(DagsterInvalidDefinitionError):
++    with pytest.raises(DagsterInvalidDefinitionError) as exc_info:
+         repo.get_all_pipelines()
++
++    assert str(exc_info.value) == (
++        'You have defined two solids named ""same"" in repository ""error_repo"". '
++        'Solid names must be unique within a repository. The solid has been defined '
++        'in pipeline ""first"" and it has been defined again in pipeline ""second.""'
++    )","im not a huge fan of exact text match in these tests, not sure what a good solution is that solves the same problem",I don't think you nee
+7752,"@@ -182,6 +182,13 @@ func (s *server) setupRouting() {
+ 		})),
+ 	)
+ 
++	handle(""/stamps/topup/{id}/{amount}"", web.ChainHandlers(
++		s.gatewayModeForbidEndpointHandler,
++		web.FinalHandler(jsonhttp.MethodHandler{
++			""PATCH"": http.HandlerFunc(s.postageTopUpHandler),
++		})),
++	)
++
+ 	handle(""/stewardship/{address}"", jsonhttp.MethodHandler{
+ 		""PUT"": web.ChainHandlers(
+ 			s.gatewayModeForbidEndpointHandler,",this should _not_ be in the api. all postage APIs have moved to the debugAPI,I think this should be `POST` instead of `PATCH`
+7753,"@@ -51,9 +51,13 @@ def _path_hash(path, transform, kwargs):
+     return digest_string(srcinfo)
+ 
+ def _is_internal_node(node):
+-    # at least one of an internal nodes children are dicts
+-    # some (group args) may not be dicts
+-    return any(isinstance(x, dict) for x in itervalues(node))
++    return not _is_leaf_node(node)
++
++def _is_leaf_node(node):
++    """"""
++    A leaf node either has no children or defines a `file` key
++    """"""
++    return not node or node.get(RESERVED['file'])
+ 
+ def _pythonize_name(name):
+     safename = re.sub('[^A-Za-z0-9]+', '_', name).strip('_')","Including both functions seems like overkill for this PR since only _is_internal_node is ever used. Keep them if you think they'll both be used in the future, but if not, the code will be easier to read if you collapse the logic into a single function.",I think this should be `node.get('file') is not 
+7754,"@@ -41,7 +41,7 @@ func GenerateTestCertificate(path string, certFileName string, keyFileName strin
+ 		SerialNumber:          big.NewInt(1234),
+ 		Subject: pkix.Name{
+ 			Country:      []string{""test""},
+-			Organization: []string{""testor""},
++			Organization: []string{""tester""},
+ 		},
+ 		DNSNames:    []string{""localhost""},
+ 		NotBefore:   time.Now(),",It seems that the two words mean the same thing.,Why is this change needed?
+7755,"@@ -271,13 +271,13 @@ void RaftPart::start(std::vector<HostAddr>&& peers, bool asLearner) {
+ 
+     lastLogId_ = wal_->lastLogId();
+     lastLogTerm_ = wal_->lastLogTerm();
++    term_ = proposedTerm_ = lastLogTerm_;
+ 
+     // Set the quorum number
+     quorum_ = (peers.size() + 1) / 2;
+ 
+     auto logIdAndTerm = lastCommittedLogId();
+     committedLogId_ = logIdAndTerm.first;
+-    term_ = proposedTerm_ = logIdAndTerm.second;
+ 
+     if (lastLogId_ < committedLogId_) {
+         LOG(INFO) << idStr_ << ""Reset lastLogId "" << lastLogId_","Do we need to set lastLogTerm_ to committedLogTerm when `lastLogId_ < committedLogId_`, on line 286",Why did you remove this line?
+7756,"@@ -160,7 +160,8 @@ public class TestAllDictionaries extends LuceneTestCase {
+           try {
+             Dictionary dic = loadDictionary(aff);
+             totalMemory.addAndGet(RamUsageTester.sizeOf(dic));
+-            totalWords.addAndGet(RamUsageTester.sizeOf(dic.words));
++            totalWords.addAndGet(
++                RamUsageTester.sizeOf(dic.words) + RamUsageTester.sizeOf(dic.wordHashes));
+             System.out.println(aff + ""\t"" + memoryUsageSummary(dic));
+           } catch (Throwable e) {
+             failures.add(aff);","About ~7% memory usage increase on average, at most 512KB",Why do we need this change?
+7757,"@@ -32,6 +32,11 @@ type Response struct {
+ type ResponseWriter interface {
+ 	io.Writer
+ 
++	// Options for the request/response that this ResponseWriter is attached to.
++	Options() Options
++	// TODO(abg) Options should not be attached to the ResponseWriter. Instead
++	// they should be part of the Handle interface.
++
+ 	// AddHeaders adds the given headers to the response. If called, this MUST
+ 	// be called before any invocation of Write().
+ 	//",Was this too big of a pain to do now?,I don't think we need this 
+7758,"@@ -41,10 +41,10 @@ static train_result call_daal_kernel(const context_cpu& ctx,
+     const int64_t component_count = desc.get_component_count();
+ 
+     auto arr_data = row_accessor<const Float>{ data }.pull();
+-    array<Float> arr_eigvec{ column_count * component_count };
+-    array<Float> arr_eigval{ 1 * component_count };
+-    array<Float> arr_means{ 1 * component_count };
+-    array<Float> arr_vars{ 1 * component_count };
++    auto arr_eigvec = array<Float>::zeros(column_count * component_count);
++    auto arr_eigval = array<Float>::zeros(1 * component_count);
++    auto arr_means = array<Float>::zeros(1 * component_count);
++    auto arr_vars = array<Float>::zeros(1 * component_count);
+ 
+     // TODO: read-only access performed with deep copy of data since daal numeric tables are mutable.
+     // Need to create special immutable homogen table on daal interop side",Why need to spend time for initializing of array? when will we rewrite the contents anyway? This can take a lot of time in some algorithms. Especially if the filling is in sequential mode.,Why is this needed?
+7759,"@@ -0,0 +1,5 @@
++class AddResourcesToWorkshops < ActiveRecord::Migration
++  def change
++    add_column :workshops, :resources, :text, null: false, default: ''
++  end
++end","Can this be `null:false, default: ''` to avoid the nil vs blank issue?",I'm not sure if this is the
+7760,"@@ -0,0 +1,19 @@
++# frozen_string_literal: true
++
++test_name ""Set root/Administrator password to a known value"" do
++  extend Beaker::HostPrebuiltSteps
++
++  hosts.each do |host|
++    case host['platform']
++    when /windows/
++      on host, ""passwd #{ENV['WINRM_USER']}"", stdin: ENV['WINRM_PASSWORD']
++    when /osx/
++      # Our VMs default to PermitRootLogin prohibit-password
++      on host, 'echo ""PermitRootLogin yes"" >> /etc/ssh/sshd_config' if ENV['SSH_USER'] == 'root'
++      on host, ""dscl . -passwd /Users/#{ENV['SSH_USER']}"", stdin: ENV['SSH_PASSWORD']
++    else
++      # Some platforms support --stdin, but repeating it seems to work everywhere
++      on host, ""passwd #{ENV['SSH_USER']}"", stdin: ""#{ENV['SSH_PASSWORD']}\n#{ENV['SSH_PASSWORD']}""
++    end
++  end
++end",Had to add this to get macOS to work.,"I'm not sure if this is the best way to test this, but I'm not sure how to test this."
+7761,"@@ -0,0 +1,13 @@
++package azkaban.container;
++
++import org.junit.Rule;
++import org.junit.rules.TemporaryFolder;
++
++
++public class FlowContainerTestBase {
++
++  @Rule
++  public TemporaryFolder temporaryFolder = new TemporaryFolder();
++
++
++}",What is the usage of this class?,Missing license header.
+7762,"@@ -144,7 +144,7 @@ public class DataFilesTable extends BaseMetadataTable {
+     @Override
+     public CloseableIterable<StructLike> rows() {
+       return CloseableIterable.transform(
+-          ManifestFiles.read(manifest, io).project(schema),
++          ManifestFiles.read(manifest, io, null, null).project(schema),
+           file -> (GenericDataFile) file);
+     }
+ ","Could we keep the original signatures as well, so we do not have to rewrite the method calls everywhere and add `null, null`? I think this could greatly reduce the changes needed in this patch",I don't think we need the `null` here.
+7763,"@@ -706,6 +706,7 @@ func (tds *TrieDbState) updateTrieRoots(forward bool) ([]common.Hash, error) {
+ 				if len(v) > 0 {
+ 					//fmt.Printf(""Update storage trie addrHash %x, keyHash %x: %x\n"", addrHash, keyHash, v)
+ 					if forward {
++						_ = ClearTombstonesForNewStorage(tds.db, cKey)
+ 						tds.t.Update(cKey, v)
+ 					} else {
+ 						// If rewinding, it might not be possible to execute storage item update.",Ideally this error should not be swallowed (can do in the next PR),Why do we need to do this?
+7764,"@@ -212,9 +212,10 @@ def config():
+     global _registry_url
+     _registry_url = None
+ 
+-def _update_auth(team, refresh_token):
++def _update_auth(team, refresh_token, timeout=None):
+     response = requests.post(""%s/api/token"" % get_registry_url(team), data=dict(
+-        refresh_token=refresh_token
++        refresh_token=refresh_token,
++        timeout=timeout
+     ))
+ 
+     if response.status_code != requests.codes.ok:",Wait a minute... You're passing it as a POST parameter. There's no way that can work.,Can you add a docstring to this function?
+7765,"@@ -259,6 +259,7 @@ func (w *Workflow) cleanup() {
+ 			w.LogWorkflowInfo(""Error returned from cleanup hook: %s"", err)
+ 		}
+ 	}
++	w.LogWorkflowInfo(""Workflow %q finished clean up."", w.Name)
+ }
+ 
+ func (w *Workflow) genName(n string) string {","minor: to be consistent with other logs, either use ""cleaning up"" (preferred) or ""cleanup"".",I don't think this log is necessary.
+7766,"@@ -23,6 +23,7 @@ PG_ASYNC_LISTEN_COMMIT = False
+ # Redis
+ REDIS_HOST = ""redis""
+ REDIS_PORT = 6379
++REDIS_NAMESPACE = ""listenbrainz""
+ 
+ # Influx DB (main listen store)
+ INFLUX_HOST    = ""influx""",Adding the config changes to the consul config template `consul_config.py.ctmpl` would be helpful too.,"REDIS_NAMESPACE = ""listenbrainz"""
+7767,"@@ -56,7 +56,7 @@ import org.hibernate.validator.constraints.NotEmpty;
+ public class Dataverse extends DvObjectContainer {
+ 
+     public enum DataverseType {
+-        RESEARCHERS, RESEARCH_PROJECTS, JOURNALS, ORGANIZATIONS_INSTITUTIONS, TEACHING_COURSES, UNCATEGORIZED
++        RESEARCHERS, RESEARCH_PROJECTS, JOURNALS, ORGANIZATIONS_INSTITUTIONS, TEACHING_COURSES, UNCATEGORIZED, LABORATORY, RESEARCH_GROUP
+     };
+     
+     private static final long serialVersionUID = 1L;",While we're at it should we add Department? See Dataverse Category: Add Department #2829,Why do we need this?
+7768,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++      
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+ 
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.,Extra empty line detected at class body end.
+7769,"@@ -22,13 +22,14 @@ function detachedClone(vnode) {
+ 	if (vnode) {
+ 		vnode = assign({}, vnode);
+ 		vnode._component = null;
++		vnode._original = vnode;
+ 		vnode._children = vnode._children && vnode._children.map(detachedClone);
+ 	}
+ 	return vnode;
+ }
+ 
+ // having custom inheritance instead of a class here saves a lot of bytes
+-export function Suspense(props) {
++export function Suspense() {
+ 	// we do not call super here to golf some bytes...
+ 	this._pendingSuspensionCount = 0;
+ 	this._suspenders = null;",TODO: check whether this is needed or not,Why is this needed?
+7770,"@@ -48,8 +48,12 @@ type Config struct {
+ 	Aliases  map[string]string `yaml:""aliases""`
+ }
+ 
+-// ReadConfig represents the current config read from local
+-var ReadConfig Config
++var (
++	// ReadConfig represents the current config read from local
++	ReadConfig Config
++	// IsInsecure represents the connect option of grpc dial
++	IsInsecure bool
++)
+ 
+ func init() {
+ 	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl/default""",`ReadConfig` is a global variable (from `gochecknoglobals`),I don't think we need this anymore.
+7771,"@@ -12,6 +12,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ //
++//go:build !cgo
+ // +build !cgo
+ 
+ package ptrace",This is duplicated with `+build !cgo`?,// +build !cgo
+7772,"@@ -34,7 +34,7 @@ module Selenium
+           driver.manage.timeouts.implicit_wait = 6
+ 
+           driver.find_element(id: 'adder').click
+-          driver.find_element(id: 'box0')
++          expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError)
+         end
+ 
+         it 'should still fail to find an element with implicit waits enabled' do",This should just be `.not_to raise_error` otherwise it potentially hides errors,Why is this change needed?
+7773,"@@ -164,13 +164,17 @@ class DataFrame(_Frame):
+         else:
+             self._metadata = metadata
+ 
+-    def _reduce_for_stat_function(self, sfun):
++    def _reduce_for_stat_function(self, sfun, numeric_only=False):
+         """"""
+         Applies sfun to each column and returns a pd.Series where the number of rows equal the
+         number of columns.
+ 
+-        :param sfun: either an 1-arg function that takes a Column and returns a Column, or
++        Parameters
++        ----------
++        sfun : either an 1-arg function that takes a Column and returns a Column, or
+         a 2-arg function that takes a Column and its DataType and returns a Column.
++        numeric_only : boolean, default False
++            If True, sfun is applied on numeric columns (including booleans) only.
+         """"""
+         from inspect import signature
+         exprs = []",Line 175 needs to be indented so that it's under `sfun`.,I don't think we need the 
+7774,"@@ -21,12 +21,16 @@ namespace Nethermind.Blockchain.Filters.Topics
+ {
+     public class AnyTopic : TopicExpression
+     {
+-        public static readonly AnyTopic Instance = new(); 
++        public static readonly AnyTopic Instance = new();
++
++        private AnyTopic() { }
+         
+         public override bool Accepts(Keccak topic) => true;
+         public override bool Accepts(ref KeccakStructRef topic) => true;
+ 
+         public override bool Matches(Bloom bloom) => true;
+         public override bool Matches(ref BloomStructRef bloom) => true;
++        
++        public override string ToString() => ""null"";
+     }
+ }",It looks strange a bit. What is the reason?,Why is this needed?
+7775,"@@ -9,13 +9,17 @@ import java.nio.file.Path;
+ import java.nio.file.PathMatcher;
+ import java.util.Optional;
+ 
+-import static com.github.javaparser.StaticJavaParser.parse;
++import static com.github.javaparser.StaticJavaParser.parse;import org.apache.log4j.Logger;
++
+ 
+ /**
+  * A strategy for discovering the structure of a project.
+  * Implementations could read a pom.xml, a Gradle build file, a makefile...
+  */
+-public interface CollectionStrategy {
++public interface CollectionStrategy {
++    protected static Logger LOG = Logger.getLogger(CollectionStrategy.class.getName());
++    
++
+ 
+     ProjectRoot collect(Path path);
+ ",Is this one of those `LexicalPreservingPrinter` issues?,Why is this needed?
+7776,"@@ -61,6 +61,12 @@ func prettify(v reflect.Value, indent int, buf *bytes.Buffer) {
+ 
+ 		buf.WriteString(""\n"" + strings.Repeat("" "", indent) + ""}"")
+ 	case reflect.Slice:
++		strtype := v.Type().String()
++		if strtype == ""[]uint8"" {
++			buf.WriteString(""<binary>"")
++			break
++		}
++		
+ 		nl, id, id2 := """", """", """"
+ 		if v.Len() > 3 {
+ 			nl, id, id2 = ""\n"", strings.Repeat("" "", indent), strings.Repeat("" "", indent+2)",Can we also add the length of the slice here? Some like `<binary> len %d`,Why do we need this?
+7777,"@@ -7,6 +7,8 @@
+ package block
+ 
+ import (
++	""github.com/iotexproject/iotex-core/pkg/log""
++	""go.uber.org/zap""
+ 	""google.golang.org/protobuf/proto""
+ 
+ 	""github.com/iotexproject/iotex-proto/golang/iotextypes""","move this line together to after line 16, group internal packages together",nit: remove empty li
+7778,"@@ -0,0 +1,12 @@
++class CreateFeedbacks < ActiveRecord::Migration
++  def change
++    create_table :feedbacks do |t|
++      t.integer :rating
++      t.integer :more_info
++      t.string :uuid
++      t.string :project_name
++
++      t.timestamps null: false
++    end
++  end
++end",How about using a reference(project_id) instead of project name,Do we need a unique 
+7779,"@@ -133,12 +133,14 @@ var (
+ 		Explorer: Explorer{
+ 			Enabled:                 false,
+ 			IsTest:                  false,
++			UseRDS:					 false,
+ 			Port:                    14004,
+ 			TpsWindow:               10,
+ 			MaxTransferPayloadBytes: 1024,
+ 		},
+ 		Indexer: Indexer{
+ 			Enabled: false,
++			NodeAddr: """",
+ 		},
+ 		System: System{
+ 			HeartbeatInterval: 10 * time.Second,",File is not `gofmt`-ed with `-s`,Why is this empty?
+7780,"@@ -235,6 +235,10 @@ public class FileDownloadServiceBean implements java.io.Serializable {
+                 dataFile = guestbookResponse.getDataFile();
+             }
+         }
++        //For tools to get the dataset and datasetversion ids, we need a full DataFile object (not a findCheapAndEasy() copy)
++        if(dataFile.getFileMetadata()==null) {
++            dataFile=datafileService.find(dataFile.getId());
++        }
+         ExternalToolHandler externalToolHandler = new ExternalToolHandler(externalTool, dataFile, apiToken);
+         // Back when we only had TwoRavens, the downloadType was always ""Explore"". Now we persist the name of the tool (i.e. ""TwoRavens"", ""Data Explorer"", etc.)
+         guestbookResponse.setDownloadtype(externalTool.getDisplayName());","@qqmyers this looks fine but have you seen any performance issue here? If so, we could right some helper method like doesExternalToolNeedDataset(externalTool). But if there's trivial performance impact, not worth it.",please add a space after the `if`
+7781,"@@ -37,6 +37,8 @@
+ #define STATICBOXVERTICALSPACER 10
+ #define DAYOFWEEKBORDERSIZE 10
+ 
++bool usingLocalPrefs;
++
+ ///////////////////////////////////////////////////////////////////////////
+ 
+ // NOTE: On MS Windows with wxWidgets 3.0, controls inside a wxStaticBox ",Make this a member variable instead (move to header inside `class` and rename to `m_bUsingLocalPrefs`).,Why is this needed?
+7782,"@@ -110,7 +110,7 @@ describe('Transactions (spec)', function() {
+         afterEach(() => cleanupAfterSuite(testContext));
+ 
+         testSuite.tests.forEach(testData => {
+-          const maybeSkipIt = testData.skipReason ? it.skip : it;
++          const maybeSkipIt = testData.skipReason || testSuite.name === 'pin-mongos' ? it.skip : it;
+           maybeSkipIt(testData.description, function() {
+             let testPromise = Promise.resolve();
+ ","Generally I'd say we should factor this out into something more extensible (check an array of potentially skipped tests, for examples), but since we're likely to remove this soon for scheduled work I think this is fine. What do you think @daprahamian?",Why is this needed?
+7783,"@@ -18,7 +18,7 @@ THE SOFTWARE.
+ */
+ 
+ /* HIT_START
+- * BUILD: %t %s ../../test_common.cpp NVCC_OPTIONS -std=c++11
++ * BUILD: %t %s ../../test_common.cpp NVCC_OPTIONS -std=c++11 EXCLUDE_HIP_PLATFORM clang
+  * TEST: %t
+  * HIT_END
+  */",Why are we skipping these tests? they should be passing in HIP-Clang.,Why is this needed?
+7784,"@@ -279,9 +279,14 @@ class RandString(RandField):
+     def __mul__(self, n):
+         return self._fix()*n
+ 
+-class RandBin(RandString):
++class RandBin(RandString, object):
+     def __init__(self, size=None):
+-        RandString.__init__(self, size, """".join(map(chr, range(256))))
++        super(RandBin, self).__init__(size=size, chars=b"""".join(chb(c) for c in range(256)))
++    def _fix(self):
++        s = b""""
++        for _ in range(self.size):
++            s += chb(random.choice(self.chars))
++        return s
+ 
+ 
+ class RandTermString(RandString):","I think a ""string"" in Scapy's spirit (if such a thing exists) is actually a `bytes` object in Python 3 (see `Str*Field`s). So maybe `RandString._fix()` should return a `bytes` object. What do you think?",I don't think you need the `object` here.
+7785,"@@ -12,6 +12,8 @@
+ 
+ const path = require('path')
+ const fs = require('fs')
++const jsdom = require(""jsdom"");
++const { JSDOM } = jsdom;
+ 
+ const srcDir = path.resolve(path.join(__dirname, '..', 'src'))
+ ","This can be combined to 1 line, just tested, seems to work.",Why do we need this?
+7786,"@@ -1404,6 +1404,16 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+         throw new IllegalStateException(
+             ""GoQuorum compatibility mode (enabled) can only be used if genesis file has 'isQuorum' flag set to true."");
+       }
++      genesisConfigOptions
++          .getChainId()
++          .ifPresent(chainId -> ensureGoQuorumCompatibilityModeNotUsedOnMainnet(chainId));
++    }
++  }
++
++  private void ensureGoQuorumCompatibilityModeNotUsedOnMainnet(final BigInteger chainId) {
++    if (chainId.equals(EthNetworkConfig.MAINNET_NETWORK_ID)) {
++      throw new IllegalStateException(
++          ""GoQuorum compatibility mode (enabled) cannot be used on Mainnet."");
+     }
+   }
+ ",what needs to happen if it is not present?,Why is this check needed? Isn't `genesisC
+7787,"@@ -88,6 +88,11 @@ func (e *deployExecutor) Execute(sig executor.StopSignal) model.StageStatus {
+ 		return model.StageStatus_STAGE_FAILURE
+ 	}
+ 
++	chartRepoName := e.deployCfg.Input.HelmChart.Repository
++	if chartRepoName != """" {
++		e.deployCfg.Input.HelmChart.Insecure = ds.DeploymentConfig.PipedSpec.IsInsecureChartRepository(chartRepoName)
++	}
++
+ 	e.provider = provider.NewProvider(e.Deployment.ApplicationName, ds.AppDir, ds.RepoDir, e.Deployment.GitPath.ConfigFilename, e.deployCfg.Input, e.Logger)
+ 	e.Logger.Info(""start executing kubernetes stage"",
+ 		zap.String(""stage-name"", e.Stage.Name),","`DeploymentConfig` is only for deployment configuration not Piped configuration so `ds.DeploymentConfig.PipedSpec` is always nil. Instead of that, you can have Piped config with `e.PipedConfig` because it is placing inside `executor.Input`.",I don't think this is the right place to 
+7788,"@@ -1,6 +1,12 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
++# This code example demonstrates how to set the access control list (ACL) on an
++# object in an Amazon Simple Storage Solution (Amazon S3) bucket for the given owner.
++
++# snippet-start:[s3.s3_set_bucket_object_acls.rb]
++
+ require 'aws-sdk-s3'
+ 
+ # Sets the access control list (ACL) on an object in an Amazon S3",Simple Storage **Service**,I think this should be `s3_set_bucket_object_acl`
+7789,"@@ -35,8 +35,13 @@ namespace OpenTelemetry.Instrumentation.AspNet
+         });
+ 
+         /// <summary>
+-        /// Gets or sets a hook to exclude calls based on domain or other per-request criterion.
++        /// Gets or sets a Filter function to filter instrumentation for requests on a per request basis.
++        /// The functions gets the HttpContext, and should return a boolean.
++        /// If functions returns true, the request is collected.
++        /// If functions returns false, the request is filtered out.
++        /// If filter throws exception, then this is considered as no filter being configured.
++        /// and requested is collected.
+         /// </summary>
+-        internal Predicate<HttpContext> RequestFilter { get; set; }
++        public Func<HttpContext, bool> Filter { get; set; }
+     }
+ }",This line doesn't seem to be right?,Why is this public?
+7790,"@@ -271,6 +271,7 @@ func (c *CVCController) createVolumeOperation(cvc *apis.CStorVolumeClaim) (*apis
+ 	// update the cstorvolume reference, phase as ""Bound"" and desired
+ 	// capacity
+ 	cvc.Spec.CStorVolumeRef = volumeRef
++	cvc.Spec.Policy = volumePolicy.Spec
+ 	cvc.Status.Phase = apis.CStorVolumeClaimPhaseBound
+ 	cvc.Status.Capacity = cvc.Spec.Capacity
+ ",this need to be moved up after getting policy..,I don't understand why we need to update the poli
+7791,"@@ -1363,7 +1363,7 @@ data:
+     # GCP Specific
+     - name: GCPInvalidProjectID
+       searchRegexStrings:
+-      - ""platform\.gcp\.project.* invalid project ID""
++      - ""platform.gcp.project.* invalid project ID""
+       installFailingReason: GCPInvalidProjectID
+       installFailingMessage: Invalid GCP project ID
+     - name: GCPInstanceTypeNotFound",I'm curious - is there a way to test these?,This should be `platform.gcp.project.*`
+7792,"@@ -59,10 +59,10 @@ public class MetadataTableUtils {
+   }
+ 
+   public static Table createMetadataTableInstance(TableOperations originTableOps,
++                                                  String catalogName,
+                                                   TableIdentifier originTableIdentifier,
+                                                   MetadataTableType type) {
+-    return createMetadataTableInstance(originTableOps,
+-        BaseMetastoreCatalog.fullTableName(type.name(), originTableIdentifier),
+-        type);
++    String fullTableName = BaseMetastoreCatalog.fullTableName(catalogName, originTableIdentifier);
++    return createMetadataTableInstance(originTableOps, fullTableName, type);
+   }
+ }","This was broken before as the name of the metadata table started with its type, not catalog.",Why do we need this change?
+7793,"@@ -173,6 +173,7 @@ func (di *Dependencies) Bootstrap(nodeOptions node.Options) error {
+ 	nats_discovery.Bootstrap()
+ 
+ 	log.Infof(""Starting Mysterium Node (%s)"", metadata.VersionAsString())
++	log.Infof(""Build information (%s)"", metadata.BuildAsString())
+ 
+ 	if err := nodeOptions.Directories.Check(); err != nil {
+ 		return err","Maybe remake `VersionAsString()` function, so that that we would have build info in all places","log.Infof(""Starting Mysteri"
+7794,"@@ -249,6 +249,17 @@ TSSLSocket::~TSSLSocket() {
+   close();
+ }
+ 
++bool TSSLSocket::hasPendingDataToRead() {
++  if (!isOpen()) {
++    return false;
++  }
++  initializeHandshake();
++  if (!checkHandshake())
++    throw TSSLException(""SSL_peek: Handshake is not completed"");
++  // data may be available in SSL buffers (note: SSL_pending does not have a failure mode)
++  return TSocket::hasPendingDataToRead() || SSL_pending(ssl_) > 0;
++}
++
+ void TSSLSocket::init() {
+   handshakeCompleted_ = false;
+   readRetryCount_ = 0;",This should probably say something other than SSL_peek?,nit: `return !checkHandshak
+7795,"@@ -1,7 +1,7 @@
+ /**
+- * Search Console module initialization.
++ * Search console module initialization.
+  *
+- * Site Kit by Google, Copyright 2019 Google LLC
++ * Site Kit by Google, Copyright 2020 Google LLC
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");
+  * you may not use this file except in compliance with the License.","Nitpicking, but this should be capitalized since it's a product name :)",Why did you change the year
+7796,"@@ -94,6 +94,16 @@ type TransactionMisc struct {
+ 	from atomic.Value
+ }
+ 
++type RawTransactions [][]byte
++
++func (t RawTransactions) Len() int {
++	return len(t)
++}
++
++func (t RawTransactions) EncodeIndex(i int, w *bytes.Buffer) {
++	w.Write(t[i])
++}
++
+ func (tm TransactionMisc) Time() time.Time {
+ 	return tm.time
+ }",Why do we need RawTransactions?,Why do we need this?
+7797,"@@ -37,6 +37,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/pkg/log""
+ 	""github.com/iotexproject/iotex-core/protogen/iotexapi""
+ 	""github.com/iotexproject/iotex-core/protogen/iotextypes""
++	""github.com/iotexproject/iotex-core/pkg/util/byteutil""
+ )
+ 
+ var (",File is not `gofmt`-ed with `-s` (from `gofmt`),File is not `goimpor
+7798,"@@ -632,7 +632,14 @@ public class NSClientService extends Service {
+                                         if (sgv.getMills() > latestDateInReceivedData)
+                                             latestDateInReceivedData = sgv.getMills();
+                                 }
+-                                BroadcastSgvs.handleNewSgv(sgvs, MainApp.instance().getApplicationContext(), isDelta);
++                                // Was that sgv more than 15 mins ago ?
++                                boolean moreThan15MinAgo = false;
++                                if((System.currentTimeMillis()-latestDateInReceivedData)/(60 * 1000L) < 15L ) 
++                                    moreThan15MinAgo = true;
++                                if(Notification.isAlarmForStaleData() && moreThan15MinAgo){
++                                    MainApp.bus().post(new EventDismissNotification(Notification.NSALARM));
++                                }                                    
++                                BroadcastSgvs.handleNewSgv(sgvs, MainApp.instance().getApplicationContext(), isDelta);                                
+                             }
+                             MainApp.bus().post(new EventNSClientNewLog(""LAST"", DateUtil.dateAndTimeString(latestDateInReceivedData)));
+                         } catch (JSONException e) {",should not be this lessThan15MinAgo ?,I don't think this i
+7799,"@@ -1192,6 +1192,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Http
+ 
+                 return RequestLineStatus.Done;
+             }
++            catch (DecodingException)
++            {
++                RejectRequest(RequestRejectionReason.NonAsciiOrNullCharactersInRequestLine,
++                    Log.IsEnabled(LogLevel.Information) ? start.GetAsciiStringEscaped(end, MaxInvalidRequestLineChars) : string.Empty);
++                // won't run but compiler complains
++                return RequestLineStatus.Done;
++            }
+             finally
+             {
+                 input.ConsumingComplete(consumed, end);",Would it work if we changed the return type of 'RejectRequest*' methods to Exception and instead did `throw RejectRequest(...` ?,Why do we need this?
+7800,"@@ -387,7 +387,7 @@ import browser from './browser';
+             videoAudioCodecs.push('mp2');
+         }
+ 
+-        let supportsDts = browser.tizen || browser.web0s || options.supportsDts || videoTestElement.canPlayType('video/mp4; codecs=""dts-""').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=""dts+""').replace(/no/, '');
++        let supportsDts = browser.tizen || videoTestElement.canPlayType('video/mp4; codecs=""dts-""').replace(/no/, '') || videoTestElement.canPlayType('video/mp4; codecs=""dts+""').replace(/no/, '');
+ 
+         // DTS audio not supported in 2018 models (Tizen 4.0)
+         if (browser.tizenVersion >= 4) {","It is not a ""perfect"" test, but: webOS 1.2 emulator says `probably`. webOS 3 emulator says \``. webOS 4 emulator says \``. Why did you remove `options.supportsDts`?",Why did you remove the web0s check?
+7801,"@@ -152,6 +152,8 @@ hipError_t ihipEnablePeerAccess(hipCtx_t peerCtx, unsigned int flags) {
+ //---
+ hipError_t hipMemcpyPeer(void* dst, hipCtx_t dstCtx, const void* src, hipCtx_t srcCtx,
+                          size_t sizeBytes) {
++    if(dstCtx == srcCtx) return hipErrorInvalidValue;
++
+     HIP_INIT_API(NONE, dst, dstCtx, src, srcCtx, sizeBytes);
+ 
+     // TODO - move to ihip memory copy implementaion.",This check should be after the HIP_INIT_API to ensure HIP tracing & lazy init works correctly. Also return should be wrapped in ihipLogStatus() so that logging works correctly.,Shouldn't this be `if (dstCtx != sr
+7802,"@@ -54,7 +54,14 @@ class ReIndexTask extends AbstractTask
+      *
+      * @var array
+      */
+-    protected $indexingConfigurationsToReIndex = array();
++    protected $indexingConfigurationsToReIndex = [];
++
++    /**
++     * Clear Index for selected sites and record types
++     *
++     * @var boolean
++     */
++    protected $clearSearchIndex = false;
+ 
+ 
+     /**",Can't use short array syntax for the 3.1 release branch.,Why do we need this property?
+7803,"@@ -2103,7 +2103,8 @@ static pmix_status_t server_switchyard(pmix_peer_t *peer, uint32_t tag,
+         PMIX_ERROR_LOG(rc);
+         return rc;
+     }
+-    pmix_output_verbose(2, pmix_globals.debug_output,
++   // pmix_output_verbose(2, pmix_globals.debug_output,
++                        pmix_output(0,
+                         ""recvd pmix cmd %d from %s:%u"",
+                         cmd, peer->info->pname.nspace, peer->info->pname.rank);
+ ",@rhc54 Is this intentional or for debug purposes?,Is this intentional?
+7804,"@@ -12,7 +12,14 @@ def includeme(config):
+     # Activate end-points.
+     config.scan('kinto.plugins.history.views')
+ 
++    # If StatsD is enabled, monitor execution time of listener.
++    if config.registry.statsd:
++        key = 'listeners.history'
++        listener = config.registry.statsd.timer(key)(on_resource_changed)
++    else:
++        listener = on_resource_changed
++
+     # Listen to every resources (except history)
+-    config.add_subscriber(on_resource_changed, ResourceChanged,
++    config.add_subscriber(listener, ResourceChanged,
+                           for_resources=('bucket', 'group',
+                                          'collection', 'record'))","Maybe it should be `plugins.history` here instead of `listeners.X`, since we use those for listeners configured via `.ini` files?",I'm not sure if this is the best way to do this. I'm not sure what the best way to do this is.
+7805,"@@ -6,6 +6,10 @@ module TeamPlansHelper
+     end
+   end
+ 
++  def team_page?
++    @team_page.present?
++  end
++
+   private
+ 
+   def team_plan_quantity_select_attributes(plan)","Hmm, I also don't have a better idea here. As a small thing, could you make this `@team_page.present?` or similar to make the intent slightly more clear?",Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+7806,"@@ -45,7 +45,12 @@ public class DecrypterInputStream extends InputStream implements WatchableStream
+ 
+     public DecrypterInputStream(FileInputStream inputStream, String encryptionKey)
+             throws GeneralSecurityException, IOException {
++        // First byte should be iv length
+         int ivLength = inputStream.read();
++        if (ivLength != 16 && ivLength != 32) {
++            throw new IOException(""Can't decrypt file: incorrect iv length found in file: "" + ivLength);
++        }
++        // Next bytes should be iv
+         byte[] iv = new byte[ivLength];
+         inputStream.read(iv);
+         Cipher cipher = Encryptor.getDecryptingCipher(encryptionKey, iv);",Without that check it would fail later (probably in the getDecryptingCipher method) but the error could be hard to make sense of.,Why do we need this check?
+7807,"@@ -379,6 +379,13 @@ module Beaker
+       return result
+     end
+ 
++    def do_take_snapshot snapshot_name
++      self[:hypervisor].take_snapshot(name, snapshot_name)
++    end
++
++    def do_restore_snapshot snapshot_name
++      self[:hypervisor].restore_snapshot(name, snapshot_name)
++    end
+   end
+ 
+   [ 'windows', 'unix', 'aix', 'mac' ].each do |lib|",I don't think that this belongs in the host code. A host is pretty much unaware of what hypervisor is running it and I don't want them to be so coupled to their hypervisor.,Why do we need this method?
+7808,"@@ -23,5 +23,6 @@ import setuptools
+ setuptools.setup(
+     packages=setuptools.find_packages(),
+     pbr=True,
+-    setup_requires=['pbr']
++    setup_requires=['pbr', 'setuptools>=12']
++    # setuptools due https://github.com/ansible/molecule/issues/1859
+ )",I'm here to tell you that this doesn't make sense because of the way it works. `setuptools.setup()` installs this only for setup-time and then discards those. But the problem is that it will not pick up a newer version because the older version is already in runtime and module cannot substitute itself. The proper place for adding build deps nowadays is `pyproject.toml`->`[build-system]`->`requires'.,This should be `setuptools>=12`
+7809,"@@ -34,7 +34,7 @@ import (
+ 	""github.com/stretchr/testify/assert""
+ )
+ 
+-type fakeManager struct {
++type fakeConnectionManager struct {
+ 	onConnectReturn      error
+ 	onDisconnectReturn   error
+ 	onStatusReturn       connection.Status",fakeConnectionManager -> mockConnectionManager. We probably should not use the `fake` anymore.,Why this change?
+7810,"@@ -364,6 +364,7 @@ class JUnitTester(AbstractTestRunner):
+         self.base_class_path = [self.selenium_server_jar_path, self.junit_path, self.junit_listener_path,
+                                 self.hamcrest_path, self.json_jar_path]
+         self.base_class_path.extend(self.scenario.get(""additional-classpath"", []))
++        self.base_class_path=[os.path.abspath(x) for x in self.base_class_path]
+ 
+     def prepare(self):
+         """"""","Code style. Btw, it's weird Codacy didn't catch that.",`os.path.abspath` is not necess
+7811,"@@ -72,6 +72,14 @@ func (m *EthAddress) UnmarshalYAML(unmarshal func(interface{}) error) error {
+ 	return nil
+ }
+ 
++func (m *EthAddress) IsZero() bool {
++	return NewBigInt(m.Unwrap().Big()).IsZero()
++}
++
++func NewEthAddress(addr common.Address) *EthAddress {
++	return &EthAddress{Address: addr.Bytes()}
++}
++
+ func (m *DataSize) Unwrap() datasize.ByteSize {
+ 	return datasize.NewByteSize(m.Bytes)
+ }",no need in BigInt just m.Unwrap().Big().Bitlen() == 0,Why not just `return m.Address 
+7812,"@@ -197,7 +197,7 @@ func (ctx *conjMatchFlowContext) installOrUpdateFlow(actions []*conjunctiveActio
+ 		// Build the Openflow entry. actions here should not be empty for either add or update case.
+ 		flow := ctx.client.conjunctiveMatchFlow(ctx.tableID, ctx.matchKey, ctx.matchValue, actions...)
+ 
+-		if err := flow.Add(); err != nil {
++		if err := ctx.client.flowOperations.Add(flow); err != nil {
+ 			return err
+ 		}
+ 		ctx.flow = flow",I assume you want to change NetworkPolicy to use bundles in a separate PR later?,Why do we need this change?
+7813,"@@ -77,7 +77,7 @@ MARKER_FILE_LIGHT_VERSION = ""%s/.light-version"" % dirs.static_libs
+ IMAGE_NAME_SFN_LOCAL = ""amazon/aws-stepfunctions-local""
+ ARTIFACTS_REPO = ""https://github.com/localstack/localstack-artifacts""
+ SFN_PATCH_URL_PREFIX = (
+-    f""{ARTIFACTS_REPO}/raw/047cc6dcd2e31f5ff3ec52d293c61b875f606958/stepfunctions-local-patch""
++    f""{ARTIFACTS_REPO}/raw/a4adc8f4da9c7ec0d93b50ca5b73dd14df791c0e/stepfunctions-local-patch""
+ )
+ SFN_PATCH_CLASS1 = ""com/amazonaws/stepfunctions/local/runtime/Config.class""
+ SFN_PATCH_CLASS2 = (","nit: We could parameterize the commit hash, as it's used in multiple places.",Why is this change needed?
+7814,"@@ -2,6 +2,7 @@
+ // Licensed under the MIT License. See License.txt in the project root for license information. 
+ 
+ var Constants = require('./constants');
++var _ = require('underscore');
+ 
+ /**
+ * Checks if a parsed URL is HTTPS","move this above the ""Constants"" as this is 3rd party ones",'use strict';
+7815,"@@ -12,10 +12,16 @@ class AuthenticationPoliciesTest(BaseWebTest, unittest.TestCase):
+ 
+     def test_basic_auth_is_accepted_by_default(self):
+         self.app.get(self.collection_url, headers=self.headers, status=200)
++        # Check that the capability is exposed on the homepage.
++        resp = self.app.get('/')
++        assert 'basicauth' in resp.json['capabilities']
+ 
+     def test_basic_auth_is_accepted_if_enabled_in_settings(self):
+         app = self.make_app({'multiauth.policies': 'basicauth'})
+         app.get(self.collection_url, headers=self.headers, status=200)
++        # Check that the capability is exposed on the homepage.
++        resp = self.app.get('/')
++        assert 'basicauth' in resp.json['capabilities']
+ 
+     def test_basic_auth_is_declined_if_disabled_in_settings(self):
+         app = self.make_app({",`assert not in`,I don't think this is neede
+7816,"@@ -310,13 +310,15 @@ func (engine *DockerTaskEngine) monitorExecAgentRunning(ctx context.Context,
+ 	// to finish monitoring.
+ 	// This is inspired from containers streaming stats from Docker.
+ 	time.Sleep(retry.AddJitter(time.Nanosecond, engine.monitorExecAgentsInterval/2))
+-	_, err = engine.execCmdMgr.RestartAgentIfStopped(ctx, engine.client, task, c, dockerID)
++	status, err := engine.execCmdMgr.RestartAgentIfStopped(ctx, engine.client, task, c, dockerID)
+ 	if err != nil {
+ 		seelog.Errorf(""Task engine [%s]: Failed to restart ExecCommandAgent Process for container [%s]: %v"", task.Arn, dockerID, err)
++		mTask.emitContainerEvent(mTask.Task, c, """")
+ 	}
+-	// whether we restarted or failed to restart, we'll want to emit a state change event
+-	// redundant state change events like RUNNING->RUNNING are allowed
+-	mTask.emitContainerEvent(mTask.Task, c, """")
++	if status == execcmd.Restarted {
++		mTask.emitContainerEvent(mTask.Task, c, """")
++	}
++
+ }
+ 
+ // MustInit blocks and retries until an engine can be initialized.","just curious, why was this modified?",Should we emit a state change event if the status is not `Restarted`?
+7817,"@@ -1302,6 +1302,7 @@ void ComTdbExeUtilFastDelete::displayContents(Space * space,
+ ComTdbExeUtilHiveTruncate::ComTdbExeUtilHiveTruncate(
+      char * tableName,
+      ULng32 tableNameLen,
++     char * hiveTableName,
+      char * tableLocation,
+      char * partnLocation,
+      char * hostName,",I'm curious why the table name is bound at compile time? Is it just to save the table create/drop overhead in a prepare-once-execute-many situation?,Why do we need this change?
+7818,"@@ -58,10 +58,6 @@ public class ProcessJob extends AbstractProcessJob {
+   public ProcessJob(final String jobId, final Props sysProps,
+       final Props jobProps, final Logger log) {
+     super(jobId, sysProps, jobProps, log);
+-
+-    // this is in line with what other job types (hadoopJava, spark, pig, hive)
+-    // is doing
+-    jobProps.put(CommonJobProperties.JOB_ID, jobId);
+   }
+ 
+   @Override","quick question, isn't ProcessJob used by all job types? Then why is JOB_ID not found?",why is this removed?
+7819,"@@ -264,6 +264,15 @@ public class AccountSettings {
+         s.put(""trashFolderSelection"", Settings.versions(
+                 new V(54, new EnumSetting<>(SpecialFolderSelection.class, SpecialFolderSelection.AUTOMATIC))
+         ));
++        s.put(""resize_image_enabled"", Settings.versions(
++                new V(55, new BooleanSetting(Account.DEFAULT_RESIZE_IMAGE_ENABLED))
++        ));
++        s.put(""resize_image_circumference"", Settings.versions(
++                new V(55, new StringSetting(Integer.toString(Account.DEFAULT_RESIZE_IMAGE_CIRCUMFERENCE)))
++        ));
++        s.put(""resize_image_quality"", Settings.versions(
++                new V(55, new StringSetting(Integer.toString(Account.DEFAULT_RESIZE_IMAGE_QUALITY)))
++        ));
+         // note that there is no setting for openPgpProvider, because this will have to be set up together
+         // with the actual provider after import anyways.
+ ",looks like you forgot to actually increase the version,I think this should be `new IntegerSetting(Account.DEFAULT_RESIZE_IMA
+7820,"@@ -43,5 +43,13 @@ namespace OpenTelemetry.Instrumentation.AspNet
+         /// The type of this object depends on the event, which is given by the above parameter.</para>
+         /// </remarks>
+         public Action<Activity, string, object> Enrich { get; set; }
++
++        /// <summary>
++        /// Gets or sets a value indicating whether to record http server attributes or not.
++        /// </summary>
++        /// <remarks>
++        /// https://github.com/open-telemetry/opentelemetry-specification/blob/a2758014f408f64ff84728918d671ee3fdab2225/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions.
++        /// </remarks>
++        public bool RecordHttpServerAttributes { get; set; }
+     }
+ }",I think it might be helpful if we add `Default value: False.` on the end of the summary.,I think this should be named `EnableHttpServerAttributes`
+7821,"@@ -80,7 +80,7 @@ module.exports = function(realmConstructor) {
+             // result in sync rejecting the writes. `_waitForDownload` ensures that the session is kept
+             // alive until our callback has returned, which prevents it from being torn down and recreated
+             // when we close the schemaless Realm and open it with the correct schema.
+-            if (!config.sync.fullSynchronization && config.schema === undefined) {
++            if (config.sync.fullSynchronized !== undefined && !config.sync.fullSynchronization && config.schema === undefined) {
+                 throw new Error('Query-based sync requires a schema.');
+             }
+             let syncSession;",I think the check should be `config.sync.fullSynchronization === false` - otherwise this will get triggered even when full sync is `true`.,`config.sync.fullSynchronized !== undefined && config.sch
+7822,"@@ -924,8 +924,11 @@ func (a *WebAPI) GenerateApplicationSealedSecret(ctx context.Context, req *webse
+ 		return nil, err
+ 	}
+ 
+-	sse := piped.SealedSecretEncryption
+-	if sse == nil {
++	se := piped.SecretEncryption
++	if se == nil {
++		se = piped.SealedSecretEncryption
++	}
++	if se == nil {
+ 		return nil, status.Error(codes.FailedPrecondition, ""The piped does not contain the encryption configuration"")
+ 	}
+ ",this blown my mind  ,I think this should be `secretEncryption` instead of `se`
+7823,"@@ -335,6 +335,10 @@ type MayaAPIServiceOutputLabel string
+ const (
+ 	ReplicaStatusAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/replica-status""
+ 
++	//ReplicaContainerStatus MayaAPIServiceOutputLabel = ""vsm.openebs.io/replica-cont-status""
++
++	ControllerContainerStatus MayaAPIServiceOutputLabel = ""vsm.openebs.io/container-status""
++
+ 	ControllerStatusAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/controller-status""
+ 
+ 	TargetPortalsAPILbl MayaAPIServiceOutputLabel = ""vsm.openebs.io/targetportals""",this should be controller-container-status,I don't think we need this.
+7824,"@@ -16,10 +16,12 @@
+ 
+ package azkaban.scheduler;
+ 
++import azkaban.utils.Utils;
+ import java.util.ArrayList;
+ import java.util.HashMap;
+ import java.util.List;
+ import java.util.Map;
++import java.util.Date;
+ 
+ import org.joda.time.DateTime;
+ import org.joda.time.DateTimeZone;",Sort import. You can use IDE's organize import feature.,Why do we need this import?
+7825,"@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver;
+ import org.openqa.selenium.WebElement;
+ 
+ import java.io.IOException;
++import java.io.UncheckedIOException;
+ import java.net.URL;
+ import java.nio.charset.StandardCharsets;
+ import java.util.ArrayList;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,Why is this needed?
+7826,"@@ -16,6 +16,7 @@ import (
+ )
+ 
+ func TestMiningPledgeSector(t *testing.T) {
++	t.Skip(""Unskip when we have implemented production drand component and local drand network for functional tests"")
+ 	tf.FunctionalTest(t)
+ 
+ 	ctx, cancel := context.WithCancel(context.Background())",This PR is off to a rough start. :),Why is this skipped?
+7827,"@@ -380,7 +380,7 @@ function normalizeProxyConfiguration(config) {
+     }
+   } else if ('pac' === config.proxyType) {
+     if (config.proxyAutoconfigUrl && !config.pacUrl) {
+-      config.pacUrl = config.proxyAutoconfigUrl;
++      config.proxyAutoconfigUrl = config.proxyAutoconfigUrl;
+     }
+   }
+   return config;","Actually, it looks like the entire `normalizeProxyConfiguration` function isn't needed anymore",I think this should be `con
+7828,"@@ -32,6 +32,8 @@
+   </div>
+ </div>
+ 
+-<ul id='breadcrumb-nav'>
+-  <li><%= link_to ""Back to main portal"", carts_path %></li>
+-</ul>
++<%- unless excluded_portal_link %>
++  <ul id='breadcrumb-nav'>
++    <li><%= link_to ""Back to main portal"", carts_path %></li>
++  </ul>
++<%- end %>",How about `unless current_path == carts_path`?,I think this should be `if excluded_portal_link`
+7829,"@@ -63,7 +63,7 @@
+ # Copyright (c) 2021 Lorena B <46202743+lorena-b@users.noreply.github.com>
+ # Copyright (c) 2021 David Liu <david@cs.toronto.edu>
+ # Copyright (c) 2021 Andreas Finkler <andi.finkler@gmail.com>
+-# Copyright (c) 2021 Or Bahari <orbahari@mail.tau.ac.il>
++# Copyright (c) 2021-2022 Or Bahari <or.ba402@gmail.com>
+ 
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ # For details: https://github.com/PyCQA/pylint/blob/main/LICENSE",You need to modify the copyrite aliases so it's done automatically.,Why did you change this?
+7830,"@@ -174,6 +174,13 @@ function createElement(...args) {
+ 
+ 	let type = vnode.type, props = vnode.props;
+ 	if (typeof type!='function') {
++		Object.keys(props).forEach(key => {
++			if (/^on(Ani|Tra)/.test(key)) {
++				props[key.toLowerCase()] = props[key];
++				delete props[key];
++			}
++		});
++
+ 		if (props.defaultValue) {
+ 			if (!props.value && props.value!==0) {
+ 				props.value = props.defaultValue;",Quick question: Is this true for all `onAnimation*` and all `onTransition*` events?,Why do we need to do this?
+7831,"@@ -59,6 +59,8 @@ function Address(data, network, type) {
+     info = Address._transformPublicKey(data);
+   } else if (data.constructor && (data.constructor.name && data.constructor.name === 'Script')) {
+     info = Address._transformScript(data);
++  } else if (data instanceof Address) {
++    return data;
+   } else if (typeof(data) === 'string') {
+     info = Address._transformString(data, network, type);
+   } else {","Should sending an address into address error? Since the call isn't needed, and could be fixed easily.",Why is this needed?
+7832,"@@ -26,6 +26,7 @@ import java.util.List;
+ import java.util.Map;
+ import java.util.TreeMap;
+ 
++import org.apache.log4j.MDC;
+ import org.apache.lucene.index.MultiTerms;
+ import org.apache.lucene.index.Terms;
+ import org.apache.lucene.index.TermsEnum;",This is the wrong MDC; see MDCLoggingContext which imports `org.slf4j.MDC`,I don't think we need this import.
+7833,"@@ -127,6 +127,9 @@ public interface HistoricDetailQuery extends Query<HistoricDetailQuery, Historic
+   /** Only select historic details that have occurred after the given date (inclusive). */
+   HistoricDetailQuery occurredAfter(Date date);
+ 
++  /** Only select historic details that were set during the process start. */
++  HistoricDetailQuery initial();
++
+   /**
+    * Order by tenant id (needs to be followed by {@link #asc()} or {@link #desc()}).
+    * Note that the ordering of historic details without tenant id is database-specific.",Maybe we can clarify a bit what that means.,Why is this needed?
+7834,"@@ -94,7 +94,7 @@ namespace Microsoft.AspNet.Server.Kestrel.Http
+                 {
+                     tcs2.SetResult(task2.Result);
+                 }
+-            }, tcs);
++            }, tcs, cancellationToken);
+             return tcs.Task;
+         }
+ ",This entire method can be deleted; it isn't used and it isn't an override of Stream.,Why do we need the cancellation to
+7835,"@@ -50,6 +50,8 @@ import org.apache.iceberg.util.Pair;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ 
++import static org.apache.iceberg.MetadataTableUtils.createMetadataTableInstance;
++
+ /**
+  * Implementation of Iceberg tables that uses the Hadoop FileSystem
+  * to store metadata and manifests.",We avoid static method imports. Can you call `MetadataTableUtils.createMetadataTableInstance` instead?,Why is this import static?
+7836,"@@ -254,6 +254,7 @@ class PACFetcher(QObject):
+     def __eq__(self, other):
+         # pylint: disable=protected-access
+         return self._pac_url == other._pac_url
++        # pylint: enable=protected-access
+ 
+     def __repr__(self):
+         return utils.get_repr(self, url=self._pac_url, constructor=True)","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",Why is this needed?
+7837,"@@ -37,7 +37,13 @@ class Purchase < ActiveRecord::Base
+     to: :purchaseable,
+     prefix: :purchaseable,
+     allow_nil: true
+-  delegate :fulfilled_with_github?, :subscription?, :terms, to: :purchaseable
++  delegate(
++    :fulfilled_with_github?,
++    :includes_mentor?,
++    :subscription?,
++    :terms,
++    to: :purchaseable
++  )
+ 
+   def self.within_range(start_time, end_time)
+     paid.where(""created_at >= ? and created_at <= ?"", start_time, end_time)",I'm actually surprised this is valid Ruby. I thought you'd need either `delegate(...)` or `delegate \ ...`.,I'm not sure if thi
+7838,"@@ -99,7 +99,7 @@ public class TestHelpers {
+         if (checkArrowValidityVector) {
+           ColumnVector columnVector = batch.column(i);
+           ValueVector arrowVector = ((IcebergArrowColumnVector) columnVector).vectorAccessor().getVector();
+-          Assert.assertEquals(""Nullability doesn't match"", expectedValue == null, arrowVector.isNull(rowId));
++          Assert.assertFalse(""Nullability doesn't match"", expectedValue == null ^ arrowVector.isNull(rowId));
+         }
+       }
+     }",Why change this?,Why is this change 
+7839,"@@ -537,6 +537,12 @@ module.exports = class XHRUpload extends Plugin {
+     const files = fileIDs.map((fileID) => this.uppy.getFile(fileID))
+ 
+     if (this.opts.bundle) {
++      // if bundle: true, we don’t support remote uploads
++      const isSomeFileRemote = files.some(file => file.isRemote)
++      if (isSomeFileRemote) {
++        throw new Error('Can’t bundle remote files when bundle: true is set')
++      }
++
+       return this.uploadBundle(files)
+     }
+ ",Maybe change it to `'Can't UPLOAD remote files when bundle: true is set'`?,I don't think we sh
+7840,"@@ -217,7 +217,14 @@ namespace OpenTelemetry
+ 
+                 if (this.circularBuffer.Count > 0)
+                 {
+-                    this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize));
++                    try
++                    {
++                        this.exporter.Export(new Batch<T>(this.circularBuffer, this.maxExportBatchSize));
++                    }
++                    catch (Exception ex)
++                    {
++                        OpenTelemetrySdkEventSource.Log.SpanProcessorException(nameof(this.OnExport), ex);
++                    }
+ 
+                     this.dataExportedNotification.Set();
+                     this.dataExportedNotification.Reset();",Do we need to drop the remaining items from the batch? Otherwise we might end up with a dead loop. Add @CodeBlanch for awareness.,Why do we need this?
+7841,"@@ -292,6 +292,19 @@ func setupMiners(st state.Tree, sm vm.StorageMap, keys []*types.KeyInfo, miners
+ 				return nil, err
+ 			}
+ 		}
++		if m.NumCommittedSectors > 0 {
++			// Now submit a dummy PoSt right away to trigger power updates.
++			// Don't worry, bootstrap miner actors don't need to verify
++			// that the PoSt is well formed.
++			poStProof := make([]byte, types.OnePoStProofPartition.ProofLen())
++			if _, err := pnrg.Read(poStProof[:]); err != nil {
++				return nil, err
++			}
++			_, err = applyMessageDirect(ctx, st, sm, addr, maddr, types.NewAttoFILFromFIL(0), ""submitPoSt"", []types.PoStProof{poStProof}, types.EmptyIntSet())
++			if err != nil {
++				return nil, err
++			}
++		}
+ 	}
+ 
+ 	return minfos, nil",Because power is now added during `submitPoSt` this is needed for setting power in the genesis block. Again let me know if this bootstrapping solution is flawed.,Why do we need this?
+7842,"@@ -40,6 +40,10 @@ return [
+     'session_gc' => ['int'],
+     'timezone_identifiers_list' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'?string'],
+     'unpack' => ['array', 'format'=>'string', 'string'=>'string', 'offset='=>'int'],
++    'ReflectionFunction::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionFunctionAbstract::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionMethod::getReturnType' => ['?ReflectionNamedType'],
++    'ReflectionParameter::getType' => ['?ReflectionNamedType']
+ ],
+ 'old' => [
+     'DateTimeZone::listIdentifiers' => ['list<string>|false', 'timezoneGroup='=>'int', 'countryCode='=>'string'],","To be consistent, these should go at the top between `DateTimeZone::listIdentifiers` and `SQLite3::createFunction`.",Why is this needed?
+7843,"@@ -165,4 +165,13 @@ public abstract class Directory implements Closeable {
+    * @throws AlreadyClosedException if this Directory is closed
+    */
+   protected void ensureOpen() throws AlreadyClosedException {}
++  
++  /**
++   * Implementations can override this if they are capable of reporting modification time
++   * of a file in seconds since the epoch.
++   */
++  public long fileModified(String name) throws IOException {
++    throw new UnsupportedOperationException();
++  }
++  
+ }",I think we should avoid changing any lucene classes for the moment - fileModified() can probably stay where it is?,Why is this needed?
+7844,"@@ -1174,7 +1174,7 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+                 extendedBolusView.setText(extendedBolusText);
+             }
+             if (extendedBolusText.equals(""""))
+-                extendedBolusView.setVisibility(View.INVISIBLE);
++                extendedBolusView.setVisibility(View.GONE);
+             else
+                 extendedBolusView.setVisibility(View.VISIBLE);
+         }","GONE breaks formating of "":"". or is it fixed below?",Why is this change needed?
+7845,"@@ -20,6 +20,9 @@ public class ASTResource extends ASTFormalParameter {
+     public Object jjtAccept(JavaParserVisitor visitor, Object data) {
+         return visitor.visit(this, data);
+     }
++
++    // TODO Should we deprecate all methods from ASTFormalParameter?
++
+ }
+ /*
+  * JavaCC - OriginalChecksum=92734fc70bba91fd9422150dbf87d5c4 (do not edit this",What do you mean with this? Won't the deprecation be inherited?,I don't think we should de
+7846,"@@ -90,6 +90,8 @@ std::string FlatCompiler::GetUsageString(const char* program_name) const {
+       ""  --cpp-ptr-type T   Set object API pointer type (default std::unique_ptr)\n""
+       ""  --cpp-str-type T   Set object API string type (default std::string)\n""
+       ""                     T::c_str() and T::length() must be supported\n""
++      ""  --object-prefix    Customise class prefix for C++ object-based API.\n""
++      ""  --object-suffix    Customise class suffix for C++ object-based API. Default value is \""T\""\n""
+       ""  --no-js-exports    Removes Node.js style export lines in JS.\n""
+       ""  --goog-js-export   Uses goog.exports* for closure compiler exporting in JS.\n""
+       ""  --go-namespace     Generate the overrided namespace in Golang.\n""","line between "" and "" should be <80 chars.",I think this should be `--
+7847,"@@ -7,7 +7,6 @@ module Travis
+     class Script
+       class Ruby < Script
+         DEFAULTS = {
+-          rvm:     'default',
+           gemfile: 'Gemfile'
+         }
+ ",What will happen if neither `rvm` nor `ruby` is present in the .travis.yml?,Why did you remove this?
+7848,"@@ -71,8 +71,7 @@ class HCI_ACL_Hdr(Packet):
+     def post_build(self, p, pay):
+         p += pay
+         if self.len is None:
+-            l = len(p)-4
+-            p = p[:2]+chr(l&0xff)+chr((l>>8)&0xff)+p[4:]
++            p = p[:2] + struct.pack(""<H"", len(pay)) + p[4:]
+         return p
+ 
+ ",@p-l- Hey it seems that this was len-4 ?!,Why did you change this?
+7849,"@@ -23,12 +23,14 @@ import AdBlockerWarning from './ad-blocker-warning';
+ import { render } from '../../../../../tests/js/test-utils';
+ import { STORE_NAME } from '../datastore/constants';
+ 
+-const setupAdBlockerRegistry = async ( registry ) => {
+-	await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );
++const setupAdBlockerRegistry = ( registry ) => {
++	registry.dispatch( STORE_NAME ).receiveSettings( {} );
++	registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( true );
+ };
+ 
+-const setupNoAdBlockerRegistry = async ( registry ) => {
+-	await registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( false );
++const setupNoAdBlockerRegistry = ( registry ) => {
++	registry.dispatch( STORE_NAME ).receiveSettings( {} );
++	registry.dispatch( STORE_NAME ).receiveIsAdBlockerActive( false );
+ };
+ 
+ describe( 'AdBlockerWarning', () => {","This is something I added which resolved a few large errors in the output, although not related to the refactor here I don't think.",Why do we need this?
+7850,"@@ -200,7 +200,6 @@ public class ExternalPlayerFragment extends Fragment {
+                 .into(imgvCover);
+ 
+         if (controller != null && controller.isPlayingVideoLocally()) {
+-            butPlay.setVisibility(View.GONE);
+             ((MainActivity) getActivity()).getBottomSheet().setLocked(true);
+             ((MainActivity) getActivity()).getBottomSheet().setState(BottomSheetBehavior.STATE_COLLAPSED);
+         } else {",i have removed this line because whenever a video is played in AntennaPod this line was making play button invisible,Why was this removed?
+7851,"@@ -0,0 +1,10 @@
++package org.apache.servicecomb.foundation.vertx;
++
++import org.junit.Test;
++
++public class MyTest {
++  @Test
++  public void myTest() {
++    System.out.println(System.getProperty(""java.io.tmpdir""));
++  }
++}",remove temporary code,Missing license header.
+7852,"@@ -154,4 +154,11 @@ public interface BlockHeader {
+    * @return The Keccak 256-bit hash of this header.
+    */
+   Hash getBlockHash();
++
++  /**
++   * The BASEFEE of this header.
++   *
++   * @return TheBASEFEE of this header.
++   */
++  Long getBaseFee();
+ }","* Should be tagged `@Unstable` * Should be a default method, returning `null` * Also, perhaps `Optional<Long>` instead of just `Long`? Always empty when the BASEFEE isn't relevant? If so the default is `Optional.empty()`",Why do we need this method?
+7853,"@@ -30,6 +30,7 @@ import { STORE_NAME as CORE_SITE } from '../datastore/site/constants';
+ import { STORE_NAME as CORE_USER } from '../datastore/user/constants';
+ 
+ const MODULE_SLUG = 'test-slug';
++const TEST_STORE_NAME = 'test/' + MODULE_SLUG;
+ 
+ describe( 'createInfoStore store', () => {
+ 	let registry;","Minor detail, but let's use the interpolated template string syntax instead.",Why do we need this?
+7854,"@@ -53,6 +53,11 @@ type TimeChaosSpec struct {
+ 	// TimeOffset defines the delta time of injected program
+ 	TimeOffset TimeOffset `json:""timeOffset""`
+ 
++	// ClockIds defines all affected clock id
++	// All available options are [""CLOCK_REALTIME"",""CLOCK_MONOTONIC"",""CLOCK_PROCESS_CPUTIME_ID"",""CLOCK_THREAD_CPUTIME_ID"",""CLOCK_MONOTONIC_RAW"",""CLOCK_REALTIME_COARSE"",""CLOCK_MONOTONIC_COARSE"",""CLOCK_BOOTTIME"",""CLOCK_REALTIME_ALARM"",""CLOCK_BOOTTIME_ALARM""]
++	// Default value is [""CLOCK_REALTIME""]
++	ClockIds []string `json:""clockIds,omitempty""`
++
+ 	// Duration represents the duration of the chaos action
+ 	Duration *string `json:""duration""`
+ ","this line is so long, split it to multi lines.",Why do we need this?
+7855,"@@ -2865,7 +2865,7 @@ void AdjustValidatorOptions(const DeviceExtensions &device_extensions, const Dev
+     if (device_extensions.vk_khr_uniform_buffer_standard_layout && enabled_features.core12.uniformBufferStandardLayout == VK_TRUE) {
+         options.SetUniformBufferStandardLayout(true);
+     }
+-    if (device_extensions.vk_ext_scalar_block_layout && enabled_features.core12.scalarBlockLayout == VK_TRUE) {
++    if (device_extensions.vk_ext_scalar_block_layout || enabled_features.core12.scalarBlockLayout == VK_TRUE) {
+         options.SetScalarBlockLayout(true);
+     }
+     if (device_extensions.vk_khr_workgroup_memory_explicit_layout &&","Looks like this might be one of those ""promoted features"" where you can enable it by _either_ enabling the extension _or_ enabling the feature bit. If that is the case, I think this needs to be: `(device_extensions.vk_ext_scalar_block_layout == kEnabledByCreateinfo) || (enabled_features.core12.scalarBlockLayout == VK_TRUE)`.",Shouldn't this be `&&`?
+7856,"@@ -52,6 +52,10 @@ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint16_t>;
+ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint32_t>;
+ template struct ONEDAL_EXPORT integer_overflow_ops<std::uint64_t>;
+ 
++#if defined(__APPLE__)
++template struct ONEDAL_EXPORT integer_overflow_ops<std::size_t>;
++#endif
++
+ } // namespace v1
+ 
+ namespace v2 {","Why should we define it for v1? This is preserved only for backward compatibility, all further modifications must be done in the latest vX",Why is this needed?
+7857,"@@ -229,12 +229,8 @@ class DaskInterface(PandasInterface):
+         return columns.data.compute()
+ 
+     @classmethod
+-    def length(cls, dataset):
+-        """"""
+-        Length of dask dataframe is unknown, always return 1
+-        for performance, use shape to compute dataframe shape.
+-        """"""
+-        return 1
++    def nonzero(cls, dataset):
++        return True
+ 
+ 
+ ","This is a definite improvement! Hardcoding nonzero is vastly better than hardcoding length. Even so, is there no way to determine the actual value of nonzero in a way that doesn't load the entire dataset?",Why is this necessa
+7858,"@@ -94,6 +94,13 @@ namespace OpenTelemetry.Instrumentation.Http.Implementation
+             return hostTagValue;
+         }
+ 
++        /// <summary>
++        /// Gets the OpenTelemetry standard uri tag value for a span based on its request <see cref=""Uri""/>.
++        /// </summary>
++        /// <param name=""uri""><see cref=""Uri""/>.</param>
++        /// <returns>Span uri value.</returns>
++        public static string GetUriTagValueFromRequestUri(Uri uri) => string.Concat(uri.Scheme, Uri.SchemeDelimiter, uri.Authority, uri.PathAndQuery, uri.Fragment);
++
+         private static string ConvertMethodToOperationName(string method) => $""HTTP {method}"";
+ 
+         private static string ConvertHttpMethodToOperationName(HttpMethod method) => $""HTTP {method}"";","do we have a way to avoid the string concats, if there is no username/password in the Uri? if (uri has UsernameInfo) { do what is done in this PR. } else { existing behavior. }",nit: `GetUriTagValu
+7859,"@@ -1862,6 +1862,7 @@ static void cb_stackdriver_flush(const void *data, size_t bytes,
+     else {
+         /* The request was issued successfully, validate the 'error' field */
+         flb_plg_debug(ctx->ins, ""HTTP Status=%i"", c->resp.status);
++        flb_plg_debug(ctx->ins, ""HTTP data=%s"", c->resp.data);
+         if (c->resp.status == 200) {
+             ret_code = FLB_OK;
+         }","do not print the payload since it might be corrupted, you can get the data with _debug.http.response_payload configuration property",Why is this debug m
+7860,"@@ -33,6 +33,7 @@ var _ = Describe(""addons flow"", func() {
+ 
+ 		It(""app init creates an copilot directory"", func() {
+ 			Expect(""./copilot"").Should(BeADirectory())
++			Expect(""./copilot/.workspace"").Should(BeAnExistingFile())
+ 		})
+ 
+ 		It(""app ls includes new app"", func() {","maybe ""app init creates an copilot directory and a workspace file""? since you validate for the file as well.",Why do we need this test?
+7861,"@@ -7,10 +7,9 @@ class Topic < ActiveRecord::Base
+     options.has_many :products, source_type: 'Product'
+     options.has_many :topics, source_type: 'Topic'
+     options.has_many :videos, source_type: 'Video'
++    options.has_many :trails, source_type: 'Trail'
+   end
+ 
+-  has_many :trails
+-
+   validates :name, presence: true
+   validates :slug, presence: true, uniqueness: true
+ ",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Why did you remove this?
+7862,"@@ -1,6 +1,6 @@
+ <?php
+ 
+-namespace Sabre\Event;
++namespace Amp;
+ 
+ /**
+  * @template TReturn",Nit: Could rename this file from SabreEvent.php now that it's not for Sabre,Why did you change this?
+7863,"@@ -39,4 +39,9 @@ func Start() {
+ func Stop() {
+ 	tch.Stop()
+ 	yarpc.Stop()
++	http.Stop()
++	apachethrift.Stop()
+ }
++
++// TODO(abg): We should probably use defers to ensure things that started up
++// successfully are stopped before we exit.",I believe this `Stop` function _is_ called with deferred.,I'm not sure if this is t
+7864,"@@ -28,13 +28,11 @@ import { __ } from '@wordpress/i18n';
+ import API from 'googlesitekit-api';
+ import Data from 'googlesitekit-data';
+ import { STORE_NAME } from './constants';
+-import { parseAccountID } from '../util';
+ import { createFetchStore } from '../../../googlesitekit/data/create-fetch-store';
+ 
+ const fetchGetURLChannelsStore = createFetchStore( {
+ 	baseName: 'getURLChannels',
+-	controlCallback: ( { clientID } ) => {
+-		const accountID = parseAccountID( clientID );
++	controlCallback: ( { accountID, clientID } ) => {
+ 		if ( undefined === accountID ) {
+ 			// Mirror the API response that would happen for an invalid client ID.
+ 			return new Promise( () => {","This entire clause should now be removed. It was only relevant if `accountID` couldn't be parsed from `clientID`, which is now no longer needed.",Why do we need to pass `clientID` here?
+7865,"@@ -77,10 +77,12 @@ extlinks = {
+ }
+ 
+ intersphinx_mapping = {
+-    'ansible': ('https://docs.ansible.com/ansible/devel/', None),
++    'ansible': ('https://docs.ansible.com/ansible/latest/', None),
+     'pip': ('https://pip.pypa.io/en/latest/', None),
+     'python': ('https://docs.python.org/3', None),
+     'python2': ('https://docs.python.org/2', None),
++    'testinfra': ('https://testinfra.readthedocs.io/en/latest/', None),
++    'yamllint': ('http://yamllint.readthedocs.io/en/latest/', None),
+ }
+ 
+ # The version info for the project you're documenting, acts as replacement for","FTR: Unlike commonly known practice, `latest` in Ansible docs corresponds to the stable version, not to the latest state of the main Git branch. Is this your intention? Just checking...",I don't think we need this anymore.
+7866,"@@ -5207,6 +5207,18 @@ const NAType *Translate::synthesizeType()
+          err4106arg = SQLCHARSETSTRING_UTF8;
+        break;
+ 
++     case GBK_TO_UTF8:
++       if (translateSource->getCharSet() == CharInfo::GBK || translateSource->getCharSet() == CharInfo::UnknownCharSet )
++         charsetTarget = CharInfo::UTF8;
++       else
++       {
++            if( CmpCommon::getDefaultString(HIVE_FILE_CHARSET) ==  CmpCommon::getDefaultString(HIVE_DEFAULT_CHARSET) )
++              err4106arg = SQLCHARSETCODE_GB2312;
++            else
++             charsetTarget = CharInfo::UTF8;
++       }
++       break;
++
+      case ISO88591_TO_UTF8:
+        if (translateSource->getCharSet() == CharInfo::ISO88591)
+        {",Why do we have || CharInfo::UnknownCharSet here? I do not see it it in neighbouring statements. This is just for my understanding.,Why do we need to check for unknown cha
+7867,"@@ -180,6 +180,7 @@ namespace NLog.Targets
+         /// <docgen category='Web Service Options' order='10' />
+         public string XmlRootNamespace { get; set; }
+ 
++        private readonly Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>> _pendingRequests = new Dictionary<HttpWebRequest, KeyValuePair<DateTime,AsyncContinuation>>();
+ 
+         /// <summary>
+         /// Calls the target method. Must be implemented in concrete classes.",isn't `HttpWebRequest` an expensive key value?,/// <summary>
+7868,"@@ -148,6 +148,14 @@ class Proposal < ActiveRecord::Base
+     observations.find_by(user: user)
+   end
+ 
++  def eligible_observers
++    if observations.count > 0
++      User.where(client_slug: client).where('id not in (?)', observations.pluck('user_id'))
++    else
++      User.where(client_slug: client)
++    end
++  end
++
+   def add_observer(email_or_user, adder=nil, reason=nil)
+     user = find_user(email_or_user)
+ ",couldn't we run this query whether there are observations or not?,I don't think you need the `(?)` here.
+7869,"@@ -125,12 +125,12 @@ class CmdlineTest(unittest.TestCase):
+ 
+     @mock.patch(""logging.getLogger"")
+     def test_cmdline_other_task(self, logger):
+-        luigi.run(['--local-scheduler', '--no-lock', 'SomeTask', '--n', '1000'])
++        luigi.run(['SomeTask', '--local-scheduler', '--no-lock', '--n', '1000'])
+         self.assertEqual(dict(MockTarget.fs.get_all_data()), {'/tmp/test_1000': b'done'})
+ 
+     @mock.patch(""logging.getLogger"")
+     def test_cmdline_ambiguous_class(self, logger):
+-        self.assertRaises(Exception, luigi.run, ['--local-scheduler', '--no-lock', 'AmbiguousClass'])
++        self.assertRaises(Exception, luigi.run, ['AmbiguousClass', '--local-scheduler', '--no-lock'])
+ 
+     @mock.patch(""logging.getLogger"")
+     @mock.patch(""logging.StreamHandler"")",This shouldn't be needed to change right?,Why did you remove the quotes?
+7870,"@@ -18,14 +18,14 @@ module.exports = {
+             ""port"": 8080
+         }
+     },
+-    ""files"": [ ""examples/cdn/*""],
++    ""files"": [ ""examples/bundle/*""],
+     ""index"": ""index.html"",
+     ""watchOptions"": {},
+     ""server"": true,
+     ""proxy"": false,
+     ""port"": 3000,
+     ""middleware"": false,
+-    ""serveStatic"": [""examples/cdn""],
++    ""serveStatic"": [""examples/bundle""],
+     ""ghostMode"": {
+         ""clicks"": true,
+         ""scroll"": true,","This seemed broken to me. Why would browserify only check the (previously `cdn`, now) `bundle` example? And even so, the path is incorrect here. Fixing this is unrelated so should not go into this PR I feel. But when we fix this in master, perhaps that solves the reload issues that you experienced @hedgerh?",I think this should be `serveStatic`
+7871,"@@ -11,13 +11,12 @@ namespace Datadog.Trace.AppSec.Waf.NativeBindings
+     [StructLayout(LayoutKind.Sequential)]
+     internal struct DdwafResultStruct
+     {
+-        [Obsolete(""This member will be removed from then ddwaf library by a future PR"")]
+-        public DDWAF_RET_CODE Action;
++        public bool Timeout;
++
++        public int PerfTotalRuntime;
+ 
+         public IntPtr Data;
+ 
+         public IntPtr PerfData;
+-
+-        public int PerfTotalRuntime;
+     }
+ }","Same question, do we have potential version-conflict crashing scenarios here?",Why is this being removed?
+7872,"@@ -89,6 +89,18 @@ int RGroupDecomposition::add(const ROMol &inmol) {
+   const bool addCoords = true;
+   MolOps::addHs(mol, explicitOnly, addCoords);
+ 
++  // mark any wildcards in input molecule:
++  for (auto &atom : mol.atoms()) {
++    if (atom->getAtomicNum() == 0) {
++      atom->setProp(""INPUT_DUMMY"", true);
++      // clean any existing R group numbers
++      atom->setIsotope(0);
++      atom->setAtomMapNum(0);
++      if (atom->hasProp(common_properties::_MolFileRLabel)) {
++        atom->clearProp(common_properties::_MolFileRLabel);
++      }
++    }
++  }
+   int core_idx = 0;
+   const RCore *rcore = nullptr;
+   std::vector<MatchVectType> tmatches;","Definitely not required, but it would be better if you had a constexpr for `""INPUT_DUMMY""`",I don't think this is the right way to do this. I think it should be done in the `MolOps::addHs` function.
+7873,"@@ -1831,11 +1831,7 @@ namespace NLog.Targets
+ #endif
+                 try
+                 {
+-                    archiveFile = this.GetArchiveFileName(fileName, ev, upcomingWriteSize);
+-                    if (!string.IsNullOrEmpty(archiveFile))
+-                    {
+-                        this.DoAutoArchive(archiveFile, ev);
+-                    }
++                    this.DoAutoArchive(archiveFile, ev);
+                 }
+                 finally
+                 {","It seems ok. Because already created a file name at line 1815 and already checked if it is null or empty at line 1816. If file name is null, then already this line will not executed.",Why did you remove this?
+7874,"@@ -71,8 +71,9 @@ public interface GenesisConfigOptions {
+ 
+   OptionalLong getLondonBlockNumber();
+ 
+-  // TODO EIP-1559 change for the actual fork name when known
+-  OptionalLong getAleutBlockNumber();
++  OptionalLong getArrowGlacierBlockNumber();
++
++  OptionalLong getBaseFeePerGas();
+ 
+   OptionalLong getEIP1559BlockNumber();
+ ",Can all the BaseFeePerGas methods that are added be removed? It's not needed for the bomb and not referenced anywhere else in this PR.,Why do we need this?
+7875,"@@ -172,7 +172,7 @@ func handleMainConfigArgs(cmd *cobra.Command, args []string, app *ddevapp.DdevAp
+ 	if docrootRelPath != """" {
+ 		app.Docroot = docrootRelPath
+ 		if _, err = os.Stat(docrootRelPath); os.IsNotExist(err) {
+-			util.Failed(""The docroot provided (%v) does not exist"", docrootRelPath)
++			output.UserOut.Warnf(""Warning: the provided docroot at %s does not currently exist."", docrootRelPath)
+ 		}
+ 	} else if !cmd.Flags().Changed(""docroot"") {
+ 		app.Docroot = ddevapp.DiscoverDefaultDocroot(app)",util.Warning()? Easier to say.,I think we should use `util.Failedf` here.
+7876,"@@ -64,8 +64,6 @@ type (
+ 		rootHash  hash.Hash32B
+ 		toRoot    *list.List // stores the path from root to diverging node
+ 		bucket    string     // bucket name to store the nodes
+-		clpsK     []byte     // path if the node can collapse after deleting an entry
+-		clpsV     []byte     // value if the node can collapse after deleting an entry
+ 		numEntry  uint64     // number of entries added to the trie
+ 		numBranch uint64
+ 		numExt    uint64",these 2 no longer needed after refactor,why are these removed?
+7877,"@@ -63,6 +63,8 @@ const (
+ 	SpecExportOptionsEmpty   = ""empty_export_options""
+ 	SpecMountOptions         = ""mount_options""
+ 	SpecCSIMountOptions      = ""csi_mount_options""
++	SpecCSIRawBlock			 = ""fadirectRawBlock""
++	SpecCSIFsType			 = ""fsType""
+ 	SpecSharedv4MountOptions = ""sharedv4_mount_options""
+ 	SpecProxyProtocolS3      = ""s3""
+ 	SpecProxyProtocolPXD     = ""pxd""","most spec options appear to be snake case - `fa_direct_raw_block`, let's stick to that convention",Should this be `fsType
+7878,"@@ -4,7 +4,6 @@ var globby = require('globby');
+ var WebDriver = require('selenium-webdriver');
+ var chrome = require('selenium-webdriver/chrome');
+ var chromedriver = require('chromedriver');
+-var isCI = require('is-ci');
+ 
+ var args = process.argv.slice(2);
+ ",Looks like we can then drop this dependency.,Why was this removed?
+7879,"@@ -667,6 +667,10 @@ class FlowMaster(controller.Master):
+             self.add_event(""Script error:\n"" + str(e), ""error"")
+         self.scripts.remove(script_obj)
+ 
++    def reload_scripts(self):
++        for s in self.scripts[:]:
++            s.load()
++    
+     def load_script(self, command):
+         """"""
+             Loads a script. Returns an error description if something went","3) Subscribe to the script change signal in `FlowMaster.__init__`. The event handler should call `self.masterq.put((""script_change"", script))`. 4) Add a `handle_script_change` function, that once called, takes the script object and calls `script.reload()`.",Why is this needed?
+7880,"@@ -287,4 +287,13 @@ public class EmailMessage {
+ 
+     return this;
+   }
++
++  public String getBody() {
++    return _body.toString();
++  }
++
++  public String getSubject() {
++    return _subject;
++  }
++
+ }","This method is for unit testing only, right? How about making it package private? This way the readers would know that this is not a public API outside this package and would reduce the search space.",Why do we need this method?
+7881,"@@ -0,0 +1 @@
++package project",accidental? i guess it's the same as any other boilerplate,
+7882,"@@ -1,7 +1,10 @@
++from concurrent.futures import ThreadPoolExecutor, TimeoutError
+ from pyramid.security import NO_PERMISSION_REQUIRED
+ 
++from kinto import logger
+ from kinto.core import Service
+ 
++
+ heartbeat = Service(name=""heartbeat"", path='/__heartbeat__',
+                     description=""Server health"")
+ ","shadowing the builtin, let's use function or func or callable_",I don't think this is used.
+7883,"@@ -0,0 +1,8 @@
++# pylint: disable=missing-docstring,expression-not-assigned,too-few-public-methods,pointless-statement
++
++class Unhashable(object):
++    __hash__ = list.__hash__
++
++{}[[]] # [unhashable-dict-key]
++{}[{}] # [unhashable-dict-key]
++{}[Unhashable()] # [unhashable-dict-key]","Can you add some good examples, for instance integers, strings and whatnot?",Why is this needed?
+7884,"@@ -1,3 +1,17 @@
++// Copyright © 2017-2019 The OpenEBS Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
+ package command
+ 
+ import (","Can we just have 2017 here @kmova if possible, as i seen in other projects as well( kubernetes etc..), they mentioned only the year when the file has been created.",nit: remove empty line.
+7885,"@@ -460,8 +460,7 @@ std::vector<DPFSubstring> DebugPrintf::ParseFormatString(const std::string forma
+ 
+ std::string DebugPrintf::FindFormatString(std::vector<unsigned int> pgm, uint32_t string_id) {
+     std::string format_string;
+-    SHADER_MODULE_STATE shader;
+-    shader.words = pgm;
++    SHADER_MODULE_STATE shader(pgm);
+     if (shader.words.size() > 0) {
+         for (const auto &insn : shader) {
+             if (insn.opcode() == spv::OpString) {","@Tony-LunarG I just realized that this differs from the previous behavior in that spirv-opt will run on the byte code if there are any ""group decorations."" If this is a problem, I can add an additional constructor to keep the pre-existing behavior.",Why do we need this cha
+7886,"@@ -86,9 +86,9 @@ public class ParquetMetrics implements Serializable {
+           Types.NestedField field = fileSchema.asStruct().field(fieldId);
+           if (field != null && stats.hasNonNullValue()) {
+             updateMin(lowerBounds, fieldId,
+-                fromParquetPrimitive(field.type(), stats.genericGetMin()));
++              fromParquetPrimitive(field.type(), column.getPrimitiveType(), stats.genericGetMin()));
+             updateMax(upperBounds, fieldId,
+-                fromParquetPrimitive(field.type(), stats.genericGetMax()));
++              fromParquetPrimitive(field.type(), column.getPrimitiveType(), stats.genericGetMax()));
+           }
+         }
+       }",Nit: continuation lines should be indented 4 spaces from the start of the statement.,`column.getPrimitiveTyp
+7887,"@@ -487,6 +487,7 @@ int sysfs_finalize(void)
+ 		sysfs_region_destroy(&_regions[i]);
+ 	}
+ 	_sysfs_region_count = 0;
++	_sysfs_format_ptr = NULL;
+ 	return FPGA_OK;
+ }
+ ",Are these protected by any kind of lock?,Why is this needed?
+7888,"@@ -66,6 +66,7 @@ class FirewallRule(object):
+         self.resource_id = kwargs.get('id')
+         self.create_time = kwargs.get('firewall_rule_create_time')
+         self.name = kwargs.get('firewall_rule_name')
++        self.hierarchical_name = kwargs.get('firewall_rule_hierarchical_name')
+         self.kind = kwargs.get('firewall_rule_kind')
+         self.network = kwargs.get('firewall_rule_network')
+         self._priority = kwargs.get('firewall_rule_priority')","This should probably default to a string, as get_resource_ancestors is causing the tests to fail due to the rsplit on a None hierarchical_name.",Shouldn't this be `kwargs.get('firewall_rule_name')`?
+7889,"@@ -170,6 +170,7 @@ type ACMEChallengeSolverHTTP01Ingress struct {
+ 
+ 	// The ingress class to use when creating Ingress resources to solve ACME
+ 	// challenges that use this challenge solver.
++	// A reference by name to a Kubernetes [IngressClass](https://kubernetes.io/docs/concepts/services-networking/ingress/#ingress-class) object
+ 	// Only one of 'class' or 'name' may be specified.
+ 	Class *string
+ ","I prefer not to have markdown here, while it is nice for the site this is also shown for `kubectl explain` where this will look weird",// A reference to a Kubernetes [IngressClass](https:/
+7890,"@@ -26,7 +26,7 @@ describe('monitoring', function () {
+     mockServer.setMessageHandler(request => {
+       const doc = request.document;
+       if (doc.ismaster || doc.hello) {
+-        request.reply(Object.assign({}, mock.DEFAULT_ISMASTER));
++        request.reply(Object.assign({}, mock.DEFAULT_ISMASTER_36));
+       } else if (doc.endSessions) {
+         request.reply({ ok: 1 });
+       }",@durran Was this change intended to be included in this PR?,Why do we need this change?
+7891,"@@ -110,7 +110,7 @@ namespace pwiz.SkylineTestFunctional
+                 Assert.AreEqual(z, key.Charge);
+                 Assert.AreEqual(adduct, key.Adduct);
+                 Assert.AreEqual(caffeineInChiKey, key.Target.ToString());
+-                var viewLibPepInfo = new ViewLibraryPepInfo(key);
++                var viewLibPepInfo = new ViewLibraryPepInfo(key, null);
+                 Assert.AreEqual(key, viewLibPepInfo.Key);
+                 var smallMolInfo = viewLibPepInfo.GetSmallMoleculeLibraryAttributes();
+                 Assert.AreEqual(moleculeName, smallMolInfo.MoleculeName);","Feels like this could have a default null value to remove the need for this explicit ""null"" use.",">null [](start = 51, length = 4) null #Resolved"
+7892,"@@ -145,12 +145,12 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error {
+ 
+ 	fs, err := s.createFilestore(ctx, cfg, t.Logger)
+ 	if err != nil {
+-		t.Logger.Error(""failed creating firestore"", zap.Error(err))
++		t.Logger.Error(""failed creating filestore"", zap.Error(err))
+ 		return err
+ 	}
+ 	defer func() {
+ 		if err := fs.Close(); err != nil {
+-			t.Logger.Error(""failed closing firestore client"", zap.Error(err))
++			t.Logger.Error(""failed closing filestore client"", zap.Error(err))
+ 		}
+ 	}()
+ ","""failed to create ...""",Why is this change needed?
+7893,"@@ -69,7 +69,7 @@ func PodCreator(fakeKubeClient kubernetes.Interface, podName string) {
+ 		}
+ 		_, err := fakeKubeClient.CoreV1().Pods(""openebs"").Create(podObjet)
+ 		if err != nil {
+-			glog.Errorf(""Fake pod object could not be created:"", err)
++			glog.Error(""Fake pod object could not be created:"", err)
+ 		}
+ 	}
+ }","No formatting directives, `glog.Error` will do just fine.",Why this change?
+7894,"@@ -34,7 +34,7 @@ module Selenium
+           driver.manage.timeouts.implicit_wait = 6
+ 
+           driver.find_element(id: 'adder').click
+-          driver.find_element(id: 'box0')
++          expect { driver.find_element(id: 'box0') }.not_to raise_error(WebDriver::Error::NoSuchElementError)
+         end
+ 
+         it 'should still fail to find an element with implicit waits enabled' do",This should just be `.not_to raise_error` otherwise it potentially hides errors,Why is this change needed?
+7895,"@@ -442,7 +442,18 @@ configRetry:
+ 		log.Infof(""Starting the Typha connection"")
+ 		err := typhaConnection.Start(context.Background())
+ 		if err != nil {
+-			log.WithError(err).Fatal(""Failed to connect to Typha"")
++			log.WithError(err).Error(""Failed to connect to Typha. Retrying..."")
++			startTime := time.Now()
++			for err != nil && time.Since(startTime) < 30*time.Second {
++				// Set Ready to false and Live to true when unable to connect to typha
++				healthAggregator.Report(healthName, &health.HealthReport{Live: true, Ready: false})
++				err = typhaConnection.Start(context.Background())
++				log.WithError(err).Debug(""Retrying to start Typha"")
++				time.Sleep(1 * time.Second)
++			}
++			if err != nil {
++				log.WithError(err).Fatal(""Failed to connect to Typha"")
++			}
+ 		}
+ 		go func() {
+ 			typhaConnection.Finished.Wait()",Need an `if err == nil {break}` above this line so that we don't log/sleep if the retry succeeds.,Should this be `time.Since
+7896,"@@ -10,17 +10,14 @@ declare(strict_types = 1);
+ namespace Ergonode\Attribute\Persistence\Dbal\Projector\Attribute;
+ 
+ use Doctrine\DBAL\Connection;
++use Doctrine\DBAL\DBALException;
+ use Ergonode\Attribute\Domain\Event\Attribute\AttributeCreatedEvent;
+-use Ergonode\Core\Domain\Entity\AbstractId;
+-use Ergonode\EventSourcing\Infrastructure\DomainEventInterface;
+-use Ergonode\EventSourcing\Infrastructure\Exception\UnsupportedEventException;
+-use Ergonode\EventSourcing\Infrastructure\Projector\DomainEventProjectorInterface;
+ use JMS\Serializer\SerializerInterface;
+ use Ramsey\Uuid\Uuid;
+ 
+ /**
+  */
+-class AttributeCreatedEventProjector implements DomainEventProjectorInterface
++class AttributeCreatedEventProjector
+ {
+     private const TABLE = 'attribute';
+     private const TABLE_PARAMETER = 'attribute_parameter';",Separate it to different methods :D Invoke method look's like old fashion portal class :D,Why did you remove this interface?
+7897,"@@ -11,11 +11,7 @@ import 'emby-button';
+         elem.classList.remove('hide');
+         elem.classList.add('expanded');
+         elem.style.height = 'auto';
+-        const height = elem.offsetHeight + 'px';
+-        elem.style.height = '0';
+-
+-        // trigger reflow
+-        const newHeight = elem.offsetHeight;
++        var height = elem.offsetHeight + 'px';
+         elem.style.height = height;
+ 
+         setTimeout(function () {",Collapse/expand animation of filter is broken - not smooth.,Why was this removed?
+7898,"@@ -16,16 +16,10 @@ module Travis
+           install_sdk_components(config[:android][:components]) unless config[:android][:components].empty?
+         end
+ 
+-        def install
+-          self.if   '-f gradlew',      './gradlew assemble', fold: 'install', retry: true
+-          self.elif '-f build.gradle', 'gradle assemble', fold: 'install', retry: true
+-          self.elif '-f pom.xml',      'mvn install -DskipTests=true -B', fold: 'install', retry: true # Otherwise mvn install will run tests which. Suggestion from Charles Nutter. MK.
+-        end
+-
+         def script
+           self.if   '-f gradlew',      './gradlew check connectedCheck'
+           self.elif '-f build.gradle', 'gradle check connectedCheck'
+-          self.elif '-f pom.xml',      'mvn test -B'
++          self.elif '-f pom.xml',      'mvn install -B'
+           self.else                    'ant debug installt test'
+         end
+ ",so during the `script` stage we run `mvn install`?,Why is this being removed?
+7899,"@@ -19,6 +19,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/pkg/log""
++	""github.com/iotexproject/iotex-core/state/factory""
+ )
+ 
+ // protocolID is the protocol ID",we may need to move CandidateNamespace to this protocol as it is only used here.,File is not `goimports`-ed (from `
+7900,"@@ -230,7 +230,12 @@ public class ExecutionControllerUtils {
+           continue;
+           // case UNKNOWN:
+         case READY:
+-          node.setStatus(Status.KILLING);
++          // if flow status is EXECUTION_STOPPED due to e.g. pod failure, set sub node to KILLED
++          if (exFlow.getStatus()==Status.EXECUTION_STOPPED) {
++            node.setStatus(Status.KILLED);
++          } else {
++            node.setStatus(Status.KILLING);
++          }
+           break;
+         default:
+           node.setStatus(Status.FAILED);","Just to confirm, this will take care of all the nodes in graph. right?",nit: space after `==`
+7901,"@@ -175,10 +175,16 @@ namespace TestPlatform.CrossPlatEngine.UnitTests.Hosting
+         public void GetTestHostProcessStartInfoShouldIncludeConnectionInfo()
+         {
+             var connectionInfo = new TestRunnerConnectionInfo { Port = 123 };
++            var parentProcessId = 101;
++
++            mockProcessHelper.Setup(ph => ph.GetCurrentProcessId()).Returns(parentProcessId);
+ 
+             var startInfo = this.dotnetHostManager.GetTestHostProcessStartInfo(this.testSource, null, connectionInfo);
+ 
+             StringAssert.Contains(startInfo.Arguments, ""--port "" + connectionInfo.Port);
++
++            StringAssert.Contains(startInfo.Arguments, string.Format(""{0} {1}"",  Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Constants.ParentProcessIdOption, parentProcessId));
++
+         }
+ 
+         [TestMethod]","nit: remove this line. All ""arrange"" may be in one code block.",nit: extra space afte
+7902,"@@ -14,10 +14,17 @@ import (
+ 
+ 	""runtime""
+ 
++	""bytes""
+ 	""restic/debug""
+ 	""restic/fs""
+ )
+ 
++// Xattr is a tuple storing the xattr name and value.
++type Xattr struct {
++	XattrName  string `json:""xattrname""`
++	XattrValue []byte `json:""xattrvalue""`
++}
++
+ // Node is a file, directory or other item in a backup.
+ type Node struct {
+ 	Name       string      `json:""name""`","This name is not a good fit, what about `ExtendedAttribute`? Or even just `Attribute`?",Why do we need this?
+7903,"@@ -0,0 +1,18 @@
++#include ""test_assert.h""
++
++int testing_fails = 0;
++
++void TestFail(const char *expval, const char *val, const char *exp,
++              const char *file, int line) {
++  TEST_OUTPUT_LINE(""VALUE: \""%s\"""", expval);
++  TEST_OUTPUT_LINE(""EXPECTED: \""%s\"""", val);
++  TEST_OUTPUT_LINE(""TEST FAILED: %s:%d, %s"", file, line, exp);
++  assert(0);
++  testing_fails++;
++}
++
++void TestEqStr(const char *expval, const char *val, const char *exp,
++               const char *file, int line) {
++  if (strcmp(expval, val) != 0) { TestFail(expval, val, exp, file, line); }
++}
++","lets keep our ""testing framework"" header only if possible. since there is an `assert(0)` in there, it is intended to halt on the first test failure.",This should be `TEST_
+7904,"@@ -26,9 +26,8 @@ import (
+ 
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""
+-	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
++	""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/action/protocol/rolldpos""
+-	""github.com/iotexproject/iotex-core/action/protocol/vote""
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/block""",File is not `goimports`-ed (from `goimports`),Why did you remove this?
+7905,"@@ -104,7 +104,6 @@ public class TableMigrationUtil {
+                 .withMetrics(metrics)
+                 .withPartitionPath(partitionKey)
+                 .build();
+-
+           }).collect(Collectors.toList());
+     } catch (IOException e) {
+       throw new RuntimeException(""Unable to list files in partition: "" + partitionUri, e);",I was saving this white-space for my retirement :nit:,Why was this removed?
+7906,"@@ -133,6 +133,10 @@ module Blacklight::Controller
+     def discard_flash_if_xhr
+       flash.discard if request.xhr?
+     end
++    deprecation_deprecate discard_flash_if_xhr: ""Discarding flash messages on XHR requests is deprecated.
++      If you wish to continue this behavior, add this method to your ApplicationController with an
++      after_action :discard_flash_if_xhr filter. To disable this behavior now and remove this warning, add
++      a skip_after_action :discard_flash_if_xhr to your ApplicationController.""
+ 
+     ##
+     #","What if you don't want to continue with the behavior, but you just want the deprecation to go away? Should we add `skip_after_action :discard_flash_if_xhr`?",I don't think we need th
+7907,"@@ -309,7 +309,7 @@ func (ws *workingSet) validateNonce(blk *block.Block) error {
+ 	}
+ 	// Verify each account's Nonce
+ 	for srcAddr, receivedNonces := range accountNonceMap {
+-		confirmedState, err := accountutil.AccountState(ws, srcAddr)
++		confirmedState, err := accountutil.AccountStateByHash160(ws, srcAddr)
+ 		if err != nil {
+ 			return errors.Wrapf(err, ""failed to get the confirmed nonce of address %s"", srcAddr)
+ 		}",change `accountNonceMap` to map[address.Address][]uint64,Why is this change neede
+7908,"@@ -38,6 +38,7 @@ public class GapicCodeGeneratorTest extends GapicTestBase2 {
+           .put(MainGapicProviderFactory.NODEJS, MainGapicProviderFactory.NODEJS)
+           .put(MainGapicProviderFactory.NODEJS_DOC, MainGapicProviderFactory.NODEJS)
+           .put(MainGapicProviderFactory.CSHARP, MainGapicProviderFactory.CSHARP)
++          .put(MainGapicProviderFactory.CLIENT_CONFIG, ""clientconfig"")
+           .build();
+ 
+   private final String apiName;","The `CLIENT_CONFIG` is ""client_config"" with underscore, so we can't reuse it in the second arg.",Why do we need this?
+7909,"@@ -62,6 +62,19 @@ func serviceLoggedIn(ctx context.Context, config Config, name string,
+ 		}
+ 	}
+ 
++	if adminFeatureList[session.UID] {
++		log.CDebugf(ctx, ""Enabling a dir op batch size of %d"",
++			bgFlushDirOpBatchSizeDefault)
++		// NOTE: This overrides any command-line parameter.  It only
++		// matters until we un-feature-flag this, I think it's ok for
++		// now.
++		config.SetBGFlushDirOpBatchSize(bgFlushDirOpBatchSizeDefault)
++	} else {
++		// TODO: let non-admins have a non-1 batch size once admins
++		// test it enough.
++		config.SetBGFlushDirOpBatchSize(1)
++	}
++
+ 	config.MDServer().RefreshAuthToken(ctx)
+ 	config.BlockServer().RefreshAuthToken(ctx)
+ 	config.KBFSOps().RefreshCachedFavorites(ctx)",Does this mean all admins get the default batch size (which is 20) no matter the value of `-sync-batch-size`? It seems the command line flag doesn't do anything then does it?,I'm not sure if this
+7910,"@@ -35,8 +35,11 @@ class CurlDownloader implements DownloaderInterface
+      *
+      * @throws DownloaderException
+      */
+-    public function download(string $url, array $headers = []): string
++    public function download(string $url, array $headers = [], array $acceptedContentTypes = null): string
+     {
++        if (null !== $acceptedContentTypes) {
++            throw new DownloaderException('CurlDownloader not supported param `acceptedHeaderTypes`');
++        }
+         $ch = curl_init();
+         curl_setopt($ch, CURLOPT_HEADER, 0);
+         curl_setopt($ch, CURLOPT_HTTPHEADER, $headers);",Set default value as empty array instead of null,Shouldn't we throw a
+7911,"@@ -121,6 +121,10 @@ mainLoop:
+ 				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no link index."")
+ 				continue
+ 			}
++			if routeUpd.Dst == nil {
++				logrus.WithField(""route"", routeUpd).Debug(""Ignoring route with no destination"")
++				continue
++			}
+ 
+ 			idx := routeUpd.LinkIndex
+ 			oldUpds := updatesByIfaceIdx[idx]",Would be good to UT this case,Why do we need this?
+7912,"@@ -40,7 +40,7 @@ namespace Ethereum.Blockchain.Test
+             {
+                 string expectedTypeName = ExpectedTypeName(directory);
+                 Type type = types.SingleOrDefault(t => string.Equals(t.Name, expectedTypeName, StringComparison.InvariantCultureIgnoreCase));
+-                if(type == null && directory != ""stEWASMTests"" && directory != ""runtimes"")
++                if(type == null && directory != ""stEWASMTests"" && directory != ""Specs"" && directory != ""runtimes"")
+                 {
+                     if (new DirectoryInfo(directory).GetFiles().Any(f => f.Name.Contains("".resources."")))
+                     {",this was updated after linking the latest ethereum/tests after a submodules recursive update,Why is this change needed?
+7913,"@@ -13,6 +13,7 @@ import { Fragment } from './create-element';
+ export function Component(props, context) {
+ 	this.props = props;
+ 	this.context = context;
++	this.__data = {};
+ }
+ 
+ /**","Todo: find a way to only do this in one spot, ideally with defaults for the stuff we use",Why do we need this?
+7914,"@@ -21,14 +21,19 @@ package org.apache.iceberg.parquet;
+ 
+ import java.io.File;
+ import java.io.IOException;
++import java.util.Map;
++
+ import org.apache.avro.generic.GenericData;
+ import org.apache.iceberg.Metrics;
+ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.TestMetrics;
+ import org.apache.iceberg.io.InputFile;
++import org.apache.parquet.hadoop.ParquetFileReader;
+ import org.junit.Rule;
+ import org.junit.rules.TemporaryFolder;
+ 
++import static org.apache.iceberg.Files.localInput;
++
+ /**
+  * Test Metrics for Parquet.
+  */","Imports should not have blank lines. Sorry there isn't a checkstyle rule running for this yet, we still need to update the build for this one.",nit: remove empty line
+7915,"@@ -3096,6 +3096,8 @@ class Booster(object):
+         """"""Evaluate training or validation data.""""""
+         if data_idx >= self.__num_dataset:
+             raise ValueError(""Data_idx should be smaller than number of dataset"")
++        if callable(feval):
++            feval = [feval]
+         self.__get_eval_info()
+         ret = []
+         if self.__num_inner_eval > 0:",Please move this to L3115 to group the code logically - all code for `feval` in one place.,Why do we need this?
+7916,"@@ -103,7 +103,7 @@ import org.apache.tuweni.bytes.Bytes;
+ import org.apache.tuweni.bytes.Bytes32;
+ 
+ /** Provides EVMs supporting the appropriate operations for mainnet hard forks. */
+-abstract class MainnetEvmRegistries {
++public abstract class MainnetEvmRegistries {
+ 
+   static EVM frontier(final GasCalculator gasCalculator) {
+     final OperationRegistry registry = new OperationRegistry();",This was done to wrap the operation so it could be spied upon during testing. Likely needs to be undone once an alternative test is discovered.,Why is this needed?
+7917,"@@ -1062,7 +1062,7 @@ func nextReqFromMsg(msg []byte) (time.Time, int, bool, error) {
+ 		if err := json.Unmarshal(msg, &cr); err != nil {
+ 			return time.Time{}, -1, false, err
+ 		}
+-		return cr.Expires, cr.Batch, cr.NoWait, nil
++		return time.Now().Add(time.Duration(cr.Expires) * time.Millisecond), cr.Batch, cr.NoWait, nil
+ 	}
+ 	// Naked batch size here for backward compatibility.
+ 	bs := 1",I feel we need to impose a lower limit here maybe? What about a max and default for when none is set?,Why do we need this
+7918,"@@ -245,7 +245,15 @@ func (cds *contentDirectoryService) Handle(action string, argsXML []byte, r *htt
+ 				""UpdateID"":       cds.updateIDString(),
+ 			}, nil
+ 		case ""BrowseMetadata"":
+-			result, err := xml.Marshal(obj)
++			node, err := cds.vfs.Stat(obj.Path)
++			if err != nil {
++				return nil, err
++			}
++			upnpObject, err := cds.cdsObjectToUpnpavObject(obj, node, host)
++			if err != nil {
++				return nil, err
++			}
++			result, err := xml.Marshal(upnpObject)
+ 			if err != nil {
+ 				return nil, err
+ 			}",ineffectual assignment to `err` (from `ineffassign`),I think this should
+7919,"@@ -37,8 +37,8 @@ type Replacer interface {
+ // they will be used to overwrite other replacements
+ // if there is a name conflict.
+ type replacer struct {
+-	replacements       map[string]string
+-	customReplacements map[string]string
++	replacements       map[string]func() string
++	customReplacements map[string]func() string
+ 	emptyValue         string
+ 	responseRecorder   *ResponseRecorder
+ }","Ahhh... this makes sense. Does using functions to defer evaluation of these values have anything to do with #916 (where the `Host: {host}` was 'cached' between different hostnames)? If not, could you help me understand what this change does?",Why is this change 
+7920,"@@ -1324,7 +1324,7 @@ TNonblockingIOThread::~TNonblockingIOThread() {
+     ownEventBase_ = false;
+   }
+ 
+-  if (listenSocket_ >= 0) {
++  if (listenSocket_ >= 0 && listenSocket_ != THRIFT_INVALID_SOCKET) {
+     if (0 != ::THRIFT_CLOSESOCKET(listenSocket_)) {
+       GlobalOutput.perror(""TNonblockingIOThread listenSocket_ close(): "", THRIFT_GET_SOCKET_ERROR);
+     }",Perhaps the only test needed is to see if the socket is not an invalid socket? Is the >= 0 test necessary at this point?,Why is this change needed?
+7921,"@@ -20,7 +20,16 @@
+   </div>
+ 
+   <% if current_user.subscription && current_user.stripe_customer %>
+-    <%= render 'credit_card_form' %>
++    <div class='text-box'>
++      <%= semantic_form_for current_user.subscription, url: subscription_path(current_user.subscription) do |form| %>
++        <%= form.inputs ""Your Subscription Billing Info"", id: 'billing-information' do %>
++          <%= render 'shared/credit_card_form' %>
++        <% end %>
++        <%= form.actions do %>
++          <%= form.action :submit, label: 'Update Your Card' %>
++        <% end %>
++      <% end %>
++    </div>
+   <% end %>
+ </div>
+ ",Could this line use `url: current_user.subscription`?,I don't think you need the
+7922,"@@ -477,7 +477,7 @@ class Context
+             $quoted_remove_var_id = preg_quote($remove_var_id);
+ 
+             foreach ($clause->possibilities as $var_id => $_) {
+-                if (preg_match('/' . $quoted_remove_var_id . '[\]\[\-]/', $var_id)) {
++                if (preg_match('/' . preg_quote($quoted_remove_var_id, '/') . '[\]\[\-]/', $var_id)) {
+                     break 2;
+                 }
+             }",I was seeing `Warning: preg_match(): Unknown modifier 'a' in /path/to/project/vendor/vimeo/psalm/src/Psalm/Context.php on line 480` here,This should be `preg_quote
+7923,"@@ -1,10 +1,18 @@
+ package com.github.javaparser.ast.stmt;
+ 
++import com.github.javaparser.JavaParser;
++import com.github.javaparser.ParserConfiguration;
++import com.github.javaparser.StaticJavaParser;
+ import com.github.javaparser.ast.expr.Expression;
+ import com.github.javaparser.ast.expr.MethodCallExpr;
+ import com.github.javaparser.ast.expr.NameExpr;
++import com.github.javaparser.printer.lexicalpreservation.LexicalPreservingPrinter;
+ import org.junit.jupiter.api.Test;
+ 
++import static com.github.javaparser.StaticJavaParser.parse;
++import static com.github.javaparser.utils.TestUtils.assertEqualsNoEol;
++import static com.github.javaparser.utils.Utils.EOL;
++
+ class BlockStmtTest {
+     @Test
+     void issue748AddingIdenticalStatementsDoesParentingRight() {",The changes in this file are not necessary.,Why is this needed?
+7924,"@@ -1,6 +1,7 @@
+ package manager
+ 
+ import (
++	""github.com/kubeedge/kubeedge/pkg/apiserverlite/util""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/watch""
+ 	""k8s.io/klog/v2""",run `make lint` to fix,nit: remove empty line
+7925,"@@ -0,0 +1,7 @@
++from dagster import execute_pipeline
++from docs_snippets.guides.dagster.reexecution.pipeline.unreliable_pipeline import unreliable_pipeline
++
++
++def test_pipeline_compiles_and_executes():
++    result = execute_pipeline(unreliable_pipeline)
++    assert result","we will need `assert result.success` instead. result will always be not null because it returns an execution result including several metadata - when the execution fails, it'd return an execution result whose `success` attribute is false.",I think you can use `a
+7926,"@@ -52,6 +52,8 @@ type CStorVolumeReplica struct {
+ type CStorVolumeReplicaSpec struct {
+ 	TargetIP string `json:""targetIP""`
+ 	Capacity string `json:""capacity""`
++	// ZvolWorkers represents number of threads that executes client IOs
++	ZvolWorkers string `json:""zvolWorkers""`
+ }
+ 
+ // CStorVolumeReplicaPhase is to hold result of action.",Can we mention how can one determine the best value given an infrastructure? Does it default to any value?,Why do we need this?
+7927,"@@ -1,4 +1,6 @@
+-<?php namespace Backend\Widgets;
++<?php
++
++namespace Backend\Widgets;
+ 
+ use Lang;
+ use Backend\Classes\WidgetBase;","Leave this formatting the way it was please, that's the standard across all of October's files.",Why did you change thi
+7928,"@@ -7,7 +7,7 @@ import (
+ 	""strings""
+ 
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+-	""github.com/opencontainers/runc/libcontainer/selinux""
++	selinux ""github.com/opencontainers/selinux/go-selinux""
+ )
+ 
+ type Validator interface {","@runcom says there is no need to use `selinux` here. `selinux` ""github.com/opencontainers/selinux/go-selinux"" The code should work fine without it.",I think this should be `go-selinux`
+7929,"@@ -20,8 +20,8 @@ CREATE_PROJECT_TABLE = """"""
+         `project_number` bigint(20) NOT NULL,
+         `project_id` varchar(255) NOT NULL,
+         `project_name` varchar(255) DEFAULT NULL,
+-        `lifecycle_state` enum('ACTIVE','DELETE_REQUESTED',
+-            'DELETE_IN_PROGRESS','DELETED') DEFAULT NULL,
++        `lifecycle_state` enum('LIFECYCLE_STATE_UNSPECIFIED','ACTIVE',
++            'DELETE_REQUESTED','DELETED') NOT NULL,
+         `parent_type` varchar(255) DEFAULT NULL,
+         `parent_id` varchar(255) DEFAULT NULL,
+         `raw_project` json DEFAULT NULL,",nit: It might be worth defining these elsewhere as a python-type?,This should be `LIFECYCLE_STATE_ACT
+7930,"@@ -151,6 +151,9 @@ public class Constants {
+      *    implies save latest 3 versions saved in storage.
+      **/
+     public static final String AZKABAN_STORAGE_ARTIFACT_MAX_RETENTION = ""azkaban.storage.artifact.max.retention"";
++
++    // enable Quartz Scheduler if true.
++    public static final String ENABLE_QUARTZ= ""enable.quartz"";
+   }
+ 
+   public static class FlowProperties {",prefix it with azkaban. Maybe azkaban.server.schedule.enable_quartz?,nit: space after `=`
+7931,"@@ -145,6 +145,13 @@ module Bolt
+             end
+           rescue Bolt::Error => e
+             e
++          rescue Puppet::DataBinding::LookupError => e
++            if /Undefined variable/.match(e.message)
++              message = ""Interpolations are not supported in lookups outside of an apply block: #{e.message}""
++              PALError.new(message)
++            else
++              PALError.from_preformatted_error(e)
++            end
+           rescue Puppet::PreformattedError => e
+             PALError.from_preformatted_error(e)
+           rescue StandardError => e",It'd be nice if we also caught `Unknown variable $trusted / $server_facts / $settings::` here - while I highly doubt anyone is using them (and if they are they're surely misusing them) it'd be crazy-making to have a working plan suddenly start failing with no clue as to why.,I think this should be `Puppet::Dat
+7932,"@@ -967,6 +967,11 @@ type serviceInfo struct {
+ 	onlyNodeLocalEndpoints   bool
+ }
+ 
++// TopologyKeys is part of ServicePort interface.
++func (info *serviceInfo) TopologyKeys() []string {
++	panic(""NOT IMPLEMENTED"")
++}
++
+ // String is part of ServicePort interface.
+ func (info *serviceInfo) String() string {
+ 	return fmt.Sprintf(""%s:%d/%s"", info.clusterIP, info.port, info.protocol)",Probably need to understand/implement this one now.,Why do we need this?
+7933,"@@ -91,8 +91,13 @@ public class JdbcDependencyManager {
+       while (rs.next()) {
+         // Columns are (starting at index 1): file_name, file_sha1, validation_status
+         Dependency d = hashAndFileNameToDep.remove(rs.getString(1) + rs.getString(2));
+-        FileValidationStatus v = FileValidationStatus.valueOf(rs.getInt(3));
+-        depValidationStatuses.put(d, v);
++
++        // HashMap.remove will return null if the key is not found, hence check for it before
++        // adding to depValidationStatuses.
++        if (d != null) {
++          FileValidationStatus v = FileValidationStatus.valueOf(rs.getInt(3));
++          depValidationStatuses.put(d, v);
++        }
+       }
+ 
+       // All remaining dependencies in the hashToDep map should be marked as being NEW (because they weren't",It will be better to add contains check for key in hashAndFileNameToDep instead of null check over here. All of these should be inside that contains if case.,Why do we need to ch
+7934,"@@ -300,8 +300,18 @@ module Beaker
+           new_conf
+         end
+ 
++        # Restarts the named puppet service
++        #
++        # @param [Host] host Host the service runs on
++        # @param [String] service Name of the service to restart
++        # @param [Fixnum] curl_retries Number of times to retry the restart command
++        # @param [Fixnum] port Port to check status at
++        #
++        # @return [Result] Result of last status check
+         # @!visibility private
+-        def bounce_service host, service, curl_retries = 120
++        def bounce_service host, service, curl_retries = nil, port = nil
++          curl_retries = 120 if curl_retries.nil?
++          port = options[:puppetserver_port] if port.nil?
+           if host.graceful_restarts?
+             apachectl_path = host.is_pe? ? ""#{host['puppetsbindir']}/apache2ctl"" : 'apache2ctl'
+             host.exec(Command.new(""#{apachectl_path} graceful""))","perhaps these magic numbers could go into a Defaults module somewhere? 8140 implies the default is for puppet server. i guess that's somewhat reasonable. but if we're trying to decouple beaker from puppet, maybe this should be 80?",I think this should 
+7935,"@@ -7595,6 +7595,13 @@ dr_prepopulate_cache(app_pc *tags, size_t tags_count)
+     return true;
+ }
+ 
++DR_API
++uint64
++dr_stats_get_built_blocks_count() {
++  return GLOBAL_STAT(num_bbs);
++}
++
++
+ /***************************************************************************
+  * PERSISTENCE
+  */",style violation: { on own line,Why is this needed?
+7936,"@@ -421,6 +421,10 @@ static h2o_http1client_body_cb on_head(h2o_http1client_t *client, const char *er
+                 goto AddHeaderDuped;
+             } else if (token == H2O_TOKEN_LINK) {
+                 h2o_push_path_in_link_header(req, headers[i].value, headers[i].value_len);
++            } else if (token == H2O_TOKEN_X_COMPRESS) {
++                req->compression_hint =
++                    h2o_strtosize(headers[i].value, headers[i].value_len) ? H2O_COMPRESS_HINT_ENABLE : H2O_COMPRESS_HINT_DISABLE;
++                goto Skip;
+             }
+         /* default behaviour, transfer the header downstream */
+         AddHeaderDuped:","Could we accept caseless strings (e.g. `off`, `on`, `auto`) instead of numbers to indicate the mode? Of course, we should use an enum internally (as we already do).",Shouldn't this be `H2O_COMPRESS_HINT_ENABLE | H2O_COMPRESS_HINT_DISABLE`?
+7937,"@@ -28,7 +28,8 @@ const Topic = ""/fil/msgs""
+ // Abstracts over a store of blockchain state.
+ type chainState interface {
+ 	GetHead() types.SortedCidSet
+-	GetTipSetAndState(tsKey types.SortedCidSet) (*chain.TipSetAndState, error)
++	GetTipSet(tsKey types.SortedCidSet) (*types.TipSet, error)
++	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ }
+ 
+ // BlockClock defines a interface to a struct that can give the current block height.","The sender doesn't use `GetTipSet`, so please remove it from this interface.",Why do we need this?
+7938,"@@ -32,10 +32,10 @@ import org.openqa.selenium.remote.tracing.HttpTracing;
+ import org.openqa.selenium.remote.tracing.Tracer;
+ 
+ import java.net.URL;
++import java.util.Objects;
+ import java.util.UUID;
+ import java.util.logging.Logger;
+ 
+-import static org.openqa.selenium.net.Urls.fromUri;
+ import static org.openqa.selenium.remote.http.Contents.asJson;
+ import static org.openqa.selenium.remote.http.HttpMethod.DELETE;
+ import static org.openqa.selenium.remote.http.HttpMethod.GET;",We can get rid of this import then.,Why did you remove the static imports?
+7939,"@@ -92,9 +92,9 @@ public class KubernetesContainerizedImpl implements ContainerizedImpl {
+   public static final String DEFAULT_NSCD_SOCKET_HOST_PATH = ""/var/run/nscd/socket"";
+   public static final String HOST_PATH_TYPE = ""Socket"";
+   public static final String DEFAULT_NSCD_SOCKET_VOLUME_MOUNT_PATH = ""/var/run/nscd/socket"";
+-  public static final String DEFAULT_SECRET_NAME = ""azkaban-private-properties"";
++  public static final String DEFAULT_SECRET_NAME = ""azkaban-k8s-secret"";
+   public static final String DEFAULT_SECRET_VOLUME = DEFAULT_SECRET_NAME;
+-  public static final String DEFAULT_SECRET_MOUNTPATH = ""/var/azkaban/private/conf"";
++  public static final String DEFAULT_SECRET_MOUNTPATH = ""/var/azkaban/private"";
+ 
+ 
+   private final String namespace;",These configurations are currently overwritten in the props we provide in our config files. They need to be overridden there as well after you make this change.,Why do we need this change?
+7940,"@@ -54,7 +54,12 @@ func PopulateMissingParameters(project *string, zone *string, region *string,
+ 
+ 	scratchBucketRegion := """"
+ 	if *scratchBucketGcsPath == """" {
+-		scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project)
++		fallbackZone := *zone
++		if fallbackZone == """" && mgce.OnGCE() {
++			// try to get zone which Cloud Build is running in, ignoring error
++			fallbackZone, _ = mgce.Zone()
++		}
++		scratchBucketName, sbr, err := scratchBucketCreator.CreateScratchBucket(file, *project, fallbackZone)
+ 		scratchBucketRegion = sbr
+ 		if err != nil {
+ 			return err",Why is error ignored here?,I don't think we should ignore the error here.
+7941,"@@ -20,6 +20,8 @@ const (
+ 	PartitionFlagGrub PartitionFlag = ""grub""
+ 	// PartitionFlagBiosGrub indicates this is a bios grub boot partition
+ 	PartitionFlagBiosGrub PartitionFlag = ""bios_grub""
++	// PartitionFlagBiosGrubLegacy indicates this is a bios grub boot partition. Needed to preserve legacy config behavior.
++	PartitionFlagBiosGrubLegacy PartitionFlag = ""bios-grub""
+ 	// PartitionFlagBoot indicates this is a boot partition
+ 	PartitionFlagBoot PartitionFlag = ""boot""
+ 	// PartitionFlagDeviceMapperRoot indicates this partition will be used for a device mapper root device",">PartitionFlagBiosGrubLegacy PartitionFlag = ""bios-grub"" [](start = 1, length = 55) I presume this is to fix a breaking change...and it's too late to fix the breaking change (since it already escaped into the world?)",Why do we need this?
+7942,"@@ -159,7 +159,7 @@ public class ScanSummary {
+       removeTimeFilters(filters, Expressions.rewriteNot(scan.filter()));
+       Expression rowFilter = joinFilters(filters);
+ 
+-      Iterable<ManifestFile> manifests = table.currentSnapshot().manifests();
++      Iterable<ManifestFile> manifests = table.currentSnapshot().dataManifests();
+ 
+       boolean filterByTimestamp = !timeFilters.isEmpty();
+       Set<Long> snapshotsInTimeRange = Sets.newHashSet();",Is this explicitly ignoring the effect of deleted rows on partition metrics or is it just that you are short circuiting any delete files (as we can't use them anyways),nit: rename to `dataManifests`?
+7943,"@@ -149,6 +149,12 @@ namespace Microsoft.DotNet.Execute
+         private string BuildParametersForCommand(Dictionary<string, string> commandParameters, string toolName)
+         {
+             string commandSetting = string.Empty;
++
++            if (Tools.ContainsKey(toolName))
++            {
++                commandSetting = Tools[toolName].osSpecific[Os][""defaultParameters""];
++            }
++
+             foreach (KeyValuePair<string, string> parameters in commandParameters)
+             {
+                 if (!parameters.Key.Equals(""toolName"") && !string.IsNullOrEmpty(parameters.Value))","I would also check whether or not this ""defaultParameters"" is null or empty to allow for people to omit it from the config file.",I don't think this is the right place to put t
+7944,"@@ -170,5 +170,5 @@ func (event *Event) IsToEdge() bool {
+ 
+ // GetContent dumps the content to string
+ func (event *Event) GetContent() string {
+-	return fmt.Sprintf(""%v"", event.Content)
++	return fmt.Sprintf(""%s"", event.Content)
+ }","I think event.Content is of type interface{}, so we may need %v here?",// GetContent dumps the content to string
+7945,"@@ -17,10 +17,12 @@
+ # along with Invenio; if not, write to the Free Software Foundation, Inc.,
+ # 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+ 
++""""""Legacy BibEdit.""""""
++
+ import warnings
+ 
+-from invenio.utils.deprecation import RemovedInInvenio22Warning
++from invenio.utils.deprecation import RemovedInInvenio23Warning
+ 
+-warnings.warn(""BibEdit will be removed in 2.2. Please check ""
++warnings.warn(""Legacy BibEdit will be removed in 2.3. Please check ""
+               ""'invenio.modules.editor' module."",
+-              RemovedInInvenio22Warning)
++              RemovedInInvenio23Warning)",Note: `editor` depends on legacy `BibEdit`,Shouldn't this be 2.3?
+7946,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+ 
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,`duraton` -> `duration`
+7947,"@@ -2608,3 +2608,16 @@ class GroupByTest(ReusedSQLTestCase, TestUtils):
+         self.assertRaises(
+             ValueError, lambda: kdf.groupby([(""B"", ""class""), (""A"", ""name"")]).get_group(""mammal"")
+         )
++
++    def test_median(self):
++        kdf = ks.DataFrame(
++            {
++                ""a"": [1.0, 1.0, 1.0, 1.0, 2.0, 2.0, 2.0, 3.0, 3.0, 3.0],
++                ""b"": [2.0, 3.0, 1.0, 4.0, 6.0, 9.0, 8.0, 10.0, 7.0, 5.0],
++                ""c"": [3.0, 5.0, 2.0, 5.0, 1.0, 2.0, 6.0, 4.0, 3.0, 6.0],
++            },
++            columns=[""a"", ""b"", ""c""],
++            index=[7, 2, 4, 1, 3, 4, 9, 10, 5, 6],
++        )
++        with self.assertRaisesRegex(ValueError, ""accuracy must be an integer; however""):
++            kdf.groupby(""a"").median(accuracy=""a"")",I'm wondering if a positive test case is needed here? Then we might compare the result DataFrame with a pre-created Koalas DataFrame.,I think you can use `assertRaisesRegex` h
+7948,"@@ -328,9 +328,9 @@ public interface Value<T> extends Iterable<T> {
+     }
+ 
+     /**
+-     * Checks, this {@code Value} is empty, i.e. if the underlying value is absent.
++     * Checks whether this {@code Value} is empty, i.e. if the underlying value is absent.
+      *
+-     * @return false, if no underlying value is present, true otherwise.
++     * @return true, if no underlying value is present, false otherwise.
+      */
+     boolean isEmpty();
+ ",I think it was reversed,"I think this should be ""if the underlying value is present"""
+7949,"@@ -12,14 +12,10 @@ public class ASTJspDirective extends AbstractJspNode {
+      */
+     private String name;
+ 
+-    public ASTJspDirective(int id) {
++    ASTJspDirective(int id) {
+         super(id);
+     }
+ 
+-    public ASTJspDirective(JspParser p, int id) {
+-        super(p, id);
+-    }
+-
+     /**
+      * @return Returns the name.
+      */","The setter ""setName"" can be package-private as well",Why is this constructor removed?
+7950,"@@ -30,7 +30,7 @@ void AdamSolver<Dtype>::ComputeUpdateValue(int param_id, Dtype rate) {
+   Blob<Dtype>* val_v = this->history_[param_id + update_history_offset].get();
+   Blob<Dtype>* val_t = this->temp_[param_id].get();
+ 
+-  const int t = this->iter_  + 1;
++  const int t = this->iter_ + 1;
+   const Dtype correction = std::sqrt(Dtype(1) - pow(beta2, t)) /
+       (Dtype(1.) - pow(beta1, t));
+   const int N = net_params[param_id]->count();","Not sure if this is intentional or snuck in through find/replace; while this is a correct style fix (and is welcome in another PR), it should not be done here so that the commit maintains a logical changeset.",Why did you change this?
+7951,"@@ -117,4 +117,17 @@ BOOST_AUTO_TEST_CASE(test_exceptions) {
+   BOOST_CHECK_NO_THROW(buf2.write((const uint8_t*)""bar"", 3));
+ }
+ 
++#ifndef _WIN32
++// We can't allocate 1 GB of memory in 32-bit environments.
++BOOST_AUTO_TEST_CASE(test_over_two_gb) {
++  TMemoryBuffer buf;
++  std::vector<uint8_t> small_buff(1);
++  std::vector<uint8_t> one_gb(1073741824);
++
++  buf.write(&small_buff[0], small_buff.size());
++  buf.write(&one_gb[0], one_gb.size());
++  BOOST_CHECK_THROW(buf.write(&one_gb[0], one_gb.size()), TTransportException);
++}
++#endif
++
+ BOOST_AUTO_TEST_SUITE_END()","This makes me wonder if the TBufferTransport should have a size limit that is configurable, with a default of INT32_MAX, and then the test can make a smaller one like 4KB, and write 4KB and then one byte more, instead of using up 2GB of memory.",Why is this needed?
+7952,"@@ -255,6 +255,8 @@ public class ApiMethodTransformer {
+     methodViewBuilder.stubName(namer.getStubName(context.getTargetInterface()));
+     methodViewBuilder.settingsGetterName(namer.getSettingsFunctionName(context.getMethod()));
+     methodViewBuilder.callableName(context.getNamer().getCallableName(context.getMethod()));
++    methodViewBuilder.isRequestStreaming(context.getMethod().getRequestStreaming());
++    methodViewBuilder.isResponseStreaming(context.getMethod().getResponseStreaming());
+   }
+ 
+   private void setListMethodFields(","If you use an enum for the streaming type, you wouldn't need to add each boolean as a separate attribute.",Why do we need this?
+7953,"@@ -98,6 +98,7 @@ from invenio.utils.serializers import serialize_via_marshal, \
+     deserialize_via_marshal
+ 
+ from sqlalchemy.exc import DatabaseError
++from MySQLdb import IntegrityError
+ 
+ from .engine_utils import get_index_id_from_index_name
+ ",can you check if you can use `sqlalchemy.exc.IntegrityError` instead?,W1618 import missing
+7954,"@@ -144,7 +144,7 @@ void JobManager::scheduleThread() {
+ 
+ // @return: true if all task dispatched, else false
+ bool JobManager::runJobInternal(const JobDescription& jobDesc, JbOp op) {
+-  std::lock_guard<std::mutex> lk(muJobFinished_);
++  std::lock_guard<std::recursive_mutex> lk(muJobFinished_);
+   std::unique_ptr<JobExecutor> je =
+       JobExecutorFactory::createJobExecutor(jobDesc, kvStore_, adminClient_);
+   JobExecutor* jobExec = je.get();",Why we need to use recursive_mutex here?,Why is recursive_mut
+7955,"@@ -68,8 +68,7 @@ var _ = framework.CertManagerDescribe(""ACME Certificate (HTTP01)"", func() {
+ 	validations := f.Helper().ValidationSetForUnsupportedFeatureSet(unsupportedFeatures)
+ 
+ 	BeforeEach(func() {
+-		acmeIssuer := util.NewCertManagerACMEIssuer(issuerName, f.Config.Addons.ACMEServer.URL, testingACMEEmail, testingACMEPrivateKey)
+-		acmeIssuer.Spec.ACME.Solvers = []cmacme.ACMEChallengeSolver{
++		solvers := []cmacme.ACMEChallengeSolver{
+ 			{
+ 				HTTP01: &cmacme.ACMEChallengeSolverHTTP01{
+ 					Ingress: &cmacme.ACMEChallengeSolverHTTP01Ingress{","am I correct these changes are related to: > I have removed a bunch of legacy functions for issuer generation ... if so, I can see why that's a valuable change but this is already a pretty huge PR and these changes to use `gen` here feel quite distant from the goal of this specific PR; they should maybe be in their own PR, to make everything easier to review? or have I missed how these changes are linked to this PR?",nit: I think we can 
+7956,"@@ -19,8 +19,10 @@ package org.openqa.selenium.grid.graphql;
+ 
+ import com.google.common.base.Suppliers;
+ import com.google.common.collect.ImmutableList;
++
+ import org.openqa.selenium.grid.data.DistributorStatus;
+ import org.openqa.selenium.grid.distributor.Distributor;
++import org.openqa.selenium.grid.sessionmap.SessionMap;
+ import org.openqa.selenium.internal.Require;
+ 
+ import java.net.URI;",I think that this is an unused import,This import is unused.
+7957,"@@ -328,7 +328,7 @@ public class DdiExportUtil {
+     
+     private static void writeVersionStatement(XMLStreamWriter xmlw, DatasetVersionDTO datasetVersionDTO) throws XMLStreamException{
+         xmlw.writeStartElement(""verStmt"");
+-        writeAttribute(xmlw,""source"",""DVN""); 
++        writeAttribute(xmlw,""source"",""producer""); 
+         xmlw.writeStartElement(""version"");
+         writeAttribute(xmlw,""date"", datasetVersionDTO.getReleaseTime().substring(0, 10));
+         writeAttribute(xmlw,""type"", datasetVersionDTO.getVersionState().toString()); ","The string ""DVN_3_0"" appears in `if (!SOURCE_DVN_3_0.equals(xmlr.getAttributeValue(null, ""source""))) {` in ImportDDIServiceBean. It's not an exact match so I don't *think* this will break dataset import from DDI but I thought I'd at least mention it.",Why did you change thi
+7958,"@@ -361,6 +361,15 @@ func (s *svc) CompareCommits(ctx context.Context, ref *RemoteRef, compareSHA str
+ 	}, nil
+ }
+ 
++func (s *svc) ListCommitsViaComparison(ctx context.Context, ref *RemoteRef, compareSHA string) ([]*githubv3.RepositoryCommit, error) {
++	comp, _, err := s.rest.Repositories.CompareCommits(ctx, ref.RepoOwner, ref.RepoName, compareSHA, ref.Ref)
++	if err != nil {
++		return nil, fmt.Errorf(""could not get commits from comparison for %s and %s. %+v"", ref.Ref, compareSHA, err)
++	}
++
++	return comp.Commits, nil
++}
++
+ type Commit struct {
+ 	Files     []*githubv3.CommitFile
+ 	Message   string","Can you add docstring to this? Also, this might be a nit but I think `CompareCommits` or `CommitRange` might be a better name. What do you think?",Why do we need this?
+7959,"@@ -33,6 +33,11 @@ import (
+ 
+ func (current *PullSubscription) Validate(ctx context.Context) *apis.FieldError {
+ 	errs := current.Spec.Validate(ctx).ViaField(""spec"")
++
++	if apis.IsInUpdate(ctx) {
++		original := apis.GetBaseline(ctx).(*PullSubscription)
++		errs = errs.Also(current.CheckImmutableFields(ctx, original))
++	}
+ 	return duck.ValidateAutoscalingAnnotations(ctx, current.Annotations, errs)
+ }
+ ","were all these ones missed in the previous PR so you are adding them now? the sources v1 and some of this? Is that right? If so, can you update the PR title",I don't think this is 
+7960,"@@ -124,7 +124,10 @@ public final class SegmentInfos implements Cloneable, Iterable<SegmentCommitInfo
+   public static final int VERSION_72 = 8;
+   /** The version that recorded softDelCount */
+   public static final int VERSION_74 = 9;
+-  static final int VERSION_CURRENT = VERSION_74;
++  /** The version that recorded nextWriteDocValuesGen */
++  public static final int VERSION_77 = 10;
++
++  static final int VERSION_CURRENT = VERSION_77;
+ 
+   /** Used to name new segments. */
+   public long counter;",hmm should this be `VERSION_81` instead?,Why did you change the version here?
+7961,"@@ -50,7 +50,9 @@ const (
+ 	pendingDeltasFlushThreshold = 128
+ 	// trieRebuildAccountChunkSize defines the number of accounts that would get read at a single chunk
+ 	// before added to the trie during trie construction
+-	trieRebuildAccountChunkSize = 512
++	trieRebuildAccountChunkSize = 16384
++	// trieRebuildCommitFrequency defines the number of accounts that would get added before we call evict to commit the changes and adjust the memory cache.
++	trieRebuildCommitFrequency = 65536
+ 	// trieAccumulatedChangesFlush defines the number of pending changes that would be applied to the merkle trie before
+ 	// we attempt to commit them to disk while writing a batch of rounds balances to disk.
+ 	trieAccumulatedChangesFlush = 256",What is the reason for increasing this?,Why is this increased?
+7962,"@@ -153,7 +153,9 @@ module.exports = class Transloadit extends Plugin {
+     // Add Assembly-specific Tus endpoint.
+     const tus = {
+       ...file.tus,
+-      endpoint: status.tus_url
++      endpoint: status.tus_url,
++      // Include X-Request-ID headers for better debugging.
++      addRequestId: true
+     }
+ 
+     // Set Companion location. We only add this, if 'file' has the attribute","is there any reason we are not adding this to companion as well?   There are no CORS concerns there, so adding probably shouldn't be a problem, no? **One question about the requestId;** Are the request Ids unique to each tus-js-client request, or are they unique to an upload instance instead?",I don't think we need this.
+7963,"@@ -76,6 +76,8 @@ public final class CsrfConfigurer<H extends HttpSecurityBuilder<H>> extends Abst
+     private CsrfTokenRepository csrfTokenRepository = new HttpSessionCsrfTokenRepository();
+     private RequestMatcher requireCsrfProtectionMatcher = CsrfFilter.DEFAULT_CSRF_MATCHER;
+     private List<RequestMatcher> ignoredCsrfProtectionMatchers = new ArrayList<RequestMatcher>();
++	private String cookieName;
++	private String cookiePath;
+ 
+     /**
+      * Creates a new instance",The formatting is a little off here.,Should these be `final`?
+7964,"@@ -263,7 +263,7 @@ public class TestCustomFunctions extends LuceneTestCase {
+     PrintWriter pw = new PrintWriter(sw);
+     expected.printStackTrace(pw);
+     pw.flush();
+-    assertTrue(sw.toString().contains(""JavascriptCompiler$CompiledExpression.evaluate("" + source + "")""));
++    assertTrue(sw.toString(), sw.toString().contains(""JavascriptCompiler$CompiledExpression.evaluate("" + source + "")""));
+   }
+ 
+   /** test that namespaces work with custom expressions. */",Perhaps we should import assertj for tests. These assertions are so much cleaner with assertj. Don't know whether hamcrest equivalent exist (maybe it does).,Why do we need this change?
+7965,"@@ -2449,16 +2449,9 @@ void ProtocolGame::sendAddCreature(const Creature* creature, const Position& pos
+ 		sendMagicEffect(pos, CONST_ME_TELEPORT);
+ 	}
+ 
+-	sendInventoryItem(CONST_SLOT_HEAD, player->getInventoryItem(CONST_SLOT_HEAD));
+-	sendInventoryItem(CONST_SLOT_NECKLACE, player->getInventoryItem(CONST_SLOT_NECKLACE));
+-	sendInventoryItem(CONST_SLOT_BACKPACK, player->getInventoryItem(CONST_SLOT_BACKPACK));
+-	sendInventoryItem(CONST_SLOT_ARMOR, player->getInventoryItem(CONST_SLOT_ARMOR));
+-	sendInventoryItem(CONST_SLOT_RIGHT, player->getInventoryItem(CONST_SLOT_RIGHT));
+-	sendInventoryItem(CONST_SLOT_LEFT, player->getInventoryItem(CONST_SLOT_LEFT));
+-	sendInventoryItem(CONST_SLOT_LEGS, player->getInventoryItem(CONST_SLOT_LEGS));
+-	sendInventoryItem(CONST_SLOT_FEET, player->getInventoryItem(CONST_SLOT_FEET));
+-	sendInventoryItem(CONST_SLOT_RING, player->getInventoryItem(CONST_SLOT_RING));
+-	sendInventoryItem(CONST_SLOT_AMMO, player->getInventoryItem(CONST_SLOT_AMMO));
++	for (int i = CONST_SLOT_FIRST; i <= CONST_SLOT_LAST; ++i) {
++		sendInventoryItem((slots_t)i, player->getInventoryItem((slots_t)i));
++	}
+ 
+ 	sendStats();
+ 	sendSkills();",You should use C++-type casts instead.,Why are you casting to slot
+7966,"@@ -865,7 +865,12 @@ func (d *cassandraPersistence) UpdateShard(
+ }
+ func (d *cassandraPersistence) CreateWorkflowExecution(
+ 	request *p.InternalCreateWorkflowExecutionRequest,
+-) (*p.CreateWorkflowExecutionResponse, error) {
++) (*p.InternalCreateWorkflowExecutionResponse, error) {
++	for _, req := range request.NewWorkflowNewEvents {
++		if err := d.AppendHistoryNodes(req); err != nil {
++			return nil, err
++		}
++	}
+ 
+ 	batch := d.session.NewBatch(gocql.LoggedBatch)
+ ",Looks like each AppendHistoryNodes is its own transaction - what happens if `len(request.NewWorkflowNewEvents) == 5` but we only succeed in writing 3 of them? Will the system be able to pick up from there later? I'm _guessing_ the answer is related to the `ON CONFLICT` and `INSERT IGNORE` changes below? What does Cassandra do?,nit: can we move this to a 
+7967,"@@ -107,7 +107,12 @@ func (s *SVIDStoreService) deleteSVID(ctx context.Context, log logrus.FieldLogge
+ 		return false
+ 	}
+ 
+-	log = log.WithField(telemetry.SVIDStore, storeName)
++	log = log.WithFields(logrus.Fields{
++		telemetry.SVIDStore: storeName,
++		telemetry.Entry:     entry.EntryId,
++		telemetry.SPIFFEID:  entry.SpiffeId,
++	})
++
+ 	svidStore, ok := s.cat.GetSVIDStoreNamed(storeName)
+ 	if !ok {
+ 		log.Error(""Error deleting SVID: SVIDStore not found"")",why are you replacing log here? it is defined above and contains EntryID and SPIFFEID,I don't think we need the `
+7968,"@@ -34,11 +34,17 @@ type Command struct {
+ 	vpnServerFactory func(sessionManager session.Manager, serviceLocation dto_discovery.Location,
+ 		providerID identity.Identity, callback state.Callback) *openvpn.Server
+ 
+-	vpnServer *openvpn.Server
++	vpnServer          *openvpn.Server
++	openvpnBinaryCheck func() error
+ }
+ 
+ // Start starts server - does not block
+ func (cmd *Command) Start() (err error) {
++	err = cmd.openvpnBinaryCheck()
++	if err != nil {
++		return err
++	}
++
+ 	providerID, err := cmd.identityLoader()
+ 	if err != nil {
+ 		return err",Why not `checkOpenvpn` as in client command?,Why do we need this function? Can't we just call `cmd.identityLoader()`?
+7969,"@@ -1,6 +1,11 @@
+ /*global mocha, console */
+ (function() {
+ 	'use strict';
++
++	if (!mocha || !mocha.reporter || !mocha.reporter('base')) {
++		return;
++	}
++
+ 	var Base = mocha.reporter('base')._reporter;
+ 	mocha.reporter(function(runner) {
+ 		Base.call(this, runner);",> Note: Non-headless tests (that run on selenium-webdriver) need to wire up to mocha reporter to collect all the results and report them. (See `test-webdriver.js`). But for other tests this can be skipped.,Why do we need this?
+7970,"@@ -241,8 +241,8 @@ class Pathoc(tcp.TCPClient):
+ 
+     def http_connect(self, connect_to):
+         self.wfile.write(
+-            'CONNECT %s:%s HTTP/1.1\r\n' % tuple(connect_to) +
+-            '\r\n'
++            b'CONNECT %s:%d HTTP/1.1\r\n' % (connect_to[0].encode(), connect_to[1]) +
++            b'\r\n'
+         )
+         self.wfile.flush()
+         try:",I think we should apply IDNA encoding for the host here.,I don't think you need `encode()` here.
+7971,"@@ -10127,8 +10127,10 @@ void Client::Handle_OP_PetCommands(const EQApplicationPacket *app)
+ 
+ 		mypet->SayString(this, Chat::PetResponse, PET_GETLOST_STRING);
+ 		mypet->CastToNPC()->Depop();
++		this->Save(1);
+ 
+ 		//Oddly, the client (Titanium) will still allow ""/pet get lost"" command despite me adding the code below. If someone can figure that out, you can uncomment this code and use it.
++		// on live since aa merging to companions discipline /pet get lost is available without any aa requirement.
+ 		/*
+ 		if((mypet->GetPetType() == petAnimation && GetAA(aaAnimationEmpathy) >= 2) || mypet->GetPetType() != petAnimation) {
+ 		mypet->SayString(PET_GETLOST_STRING);",No need to use `this->` here,I don't think this is the right place to do this.
+7972,"@@ -151,6 +151,7 @@ func (r *ReconcileClusterDeployment) reconcileExistingInstallingClusterInstall(c
+ 		statusModified = true
+ 	}
+ 
++	completed = controllerutils.FindClusterDeploymentCondition(conditions, hivev1.ClusterInstallCompletedClusterDeploymentCondition)
+ 	if completed.Status == corev1.ConditionTrue { // the cluster install is complete
+ 		cd.Spec.Installed = true
+ 		cd.Status.InstalledTimestamp = &completed.LastTransitionTime","I can't quite tell, is there a reason why we're finding this condition again when it was done a few lines above? Or was this a mistaken paste?",if completed != nil { // the cluster install is complete
+7973,"@@ -22,7 +22,7 @@
+ // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+ // THE SOFTWARE.
+ 
+-//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination namespaceCache_mock.go
++//go:generate mockgen -copyright_file ../../LICENSE -package $GOPACKAGE -source $GOFILE -destination cache_mock.go
+ 
+ package namespace
+ ","doh. My fault, sorry.",// +build go1.13
+7974,"@@ -80,3 +80,11 @@ func conditionIsProvider1(provider market.ServiceProposal) bool {
+ func conditionIsStreaming(provider market.ServiceProposal) bool {
+ 	return provider.ServiceType == ""streaming""
+ }
++
++func fieldID(proposal market.ServiceProposal) interface{} {
++	return proposal.ID
++}
++
++func fieldProviderID(proposal market.ServiceProposal) interface{} {
++	return proposal.ProviderID
++}",Why do we returning `interface{}` here? Don't we have a predefined type for `ID`?,`fieldID` is unused (from `deadcode`)
+7975,"@@ -34,9 +34,12 @@ import MiniChart from 'GoogleComponents/mini-chart';
+  */
+ import { trafficSourcesReportDataDefaults } from '../util';
+ 
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component, Fragment } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component, Fragment } from '@wordpress/element';
+ 
+ class AnalyticsDashboardWidgetTopAcquisitionSources extends Component {
+ 	render() {",`lodash` shouldn't be grouped under WordPress dependencies,I think this should be `@wordpress/element`
+7976,"@@ -8,6 +8,8 @@ import (
+ 	""context""
+ 	""flag""
+ 	""fmt""
++	""github.com/rclone/rclone/fs/config/provider/goconfig""
++	""github.com/rclone/rclone/fs/config/provider/viper""
+ 	""io""
+ 	""io/ioutil""
+ 	""log""",File is not `goimports`-ed (from `goimports`),"""os"""
+7977,"@@ -96,6 +96,11 @@ class InteropServiceHelper {
+ 	}
+ 
+ 	static async defaultFilename(noteIds, fileExtension) {
++		// Use of == here is because noteIds is potentiall undefined
++		if (noteIds == null) {
++			return '';
++		}
++
+ 		const note = await Note.load(noteIds[0]);
+ 		// In a rare case the passed not will be null, use the id for filename
+ 		if (note === null) {",Not sure why you want to make the distinction between null and undefined? And also `null == undefined` anyway so I think you could simply have `!noteIds` here.,I do
+7978,"@@ -21,6 +21,15 @@
+ package http
+ 
+ const (
++	// ApplicationHeaderPrefix is the prefix added to application headers over
++	// the wire.
++	ApplicationHeaderPrefix = ""Rpc-Header-""
++
++	// ContextHeaderPrefix is the prefix added to context headers over the wire.
++	ContextHeaderPrefix = ""Context-""
++
++	// TODO(abg): Allow customizing header prefixes
++
+ 	// CallerHeader is the HTTP header used to indiate the service doing the calling
+ 	CallerHeader = ""Rpc-Caller""
+ ",Almost makes me wonder if this should default to Rpc-Context so everything defaults under Rpc-,Do w
+7979,"@@ -26,7 +26,7 @@ import (
+ 	""github.com/iotexproject/iotex-core/action""
+ 	""github.com/iotexproject/iotex-core/action/protocol""
+ 	""github.com/iotexproject/iotex-core/action/protocol/account""
+-	accountutil ""github.com/iotexproject/iotex-core/action/protocol/account/util""
++	""github.com/iotexproject/iotex-core/action/protocol/account/util""
+ 	""github.com/iotexproject/iotex-core/action/protocol/execution/evm""
+ 	""github.com/iotexproject/iotex-core/action/protocol/poll""
+ 	""github.com/iotexproject/iotex-core/action/protocol/rewarding""",File is not `goimports`-ed (from `goimports`),Why 
+7980,"@@ -317,8 +317,16 @@ func (mset *Stream) AddConsumer(config *ConsumerConfig) (*Consumer, error) {
+ 		}
+ 	}
+ 
+-	// Check for any limits.
+-	if mset.config.MaxConsumers > 0 && len(mset.consumers) >= mset.config.MaxConsumers {
++	// Check for any limits, if the config for the consumer sets a limit we check against that
++	// but if not we use the value from account limits, if account limits is more restrictive
++	// than stream config we prefer the account limits to handle cases where account limits are
++	// updated during the lifecycle of the stream
++	maxc := mset.config.MaxConsumers
++	if mset.config.MaxConsumers <= 0 || mset.jsa.limits.MaxConsumers < mset.config.MaxConsumers {
++		maxc = mset.jsa.limits.MaxConsumers
++	}
++
++	if maxc > 0 && len(mset.consumers) >= maxc {
+ 		mset.mu.Unlock()
+ 		return nil, fmt.Errorf(""maximum consumers limit reached"")
+ 	}",would these require any account lock here?,I think this should be `<=` instead of `<`
+7981,"@@ -142,7 +142,7 @@ class RemoteConnection(object):
+         :Returns:
+         Timeout value in seconds for all http requests made to the Remote Connection
+         """"""
+-        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT or cls._timeout
++        return None if cls._timeout == socket._GLOBAL_DEFAULT_TIMEOUT else cls._timeout
+ 
+     @classmethod
+     def set_timeout(cls, timeout):",The else doesn't return anything?,I don't think this change is necessary.
+7982,"@@ -112,6 +112,7 @@ function TransactionBuilder(opts) {
+   if (opts.fee || opts.feeSat) {
+     this.givenFeeSat = opts.fee ? opts.fee * util.COIN : opts.feeSat;
+   }
++  if (opts.fee == 0 || opts.feeSat == 0) this.givenFeeSat = 0;
+   this.remainderOut = opts.remainderOut;
+   this.signhash = opts.signhash || Transaction.SIGHASH_ALL;
+ ",if (typeof (opts.fee) !== 'undefined' || typeof (opts.feeSat) !=='undefined') {,Shouldn't this be `this.givenFeeSat = opts
+7983,"@@ -38,7 +38,13 @@ type Device struct {
+ }
+ 
+ func (d *Device) CgroupString() string {
+-	return fmt.Sprintf(""%c %s:%s %s"", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), d.Permissions)
++	var p string
++	if d.Permissions == """" {
++		p = ""rwm"" // empty permissions is invalid... causes a write invalid argument error upon saving to cgroups
++	} else {
++		p = d.Permissions
++	}
++	return fmt.Sprintf(""%c %s:%s %s"", d.Type, deviceNumberString(d.Major), deviceNumberString(d.Minor), p)
+ }
+ 
+ func (d *Device) Mkdev() int {",I not sure we need to change this method's logic. Isn't no perms and invalid config?,I'm not sure if this is the right way to d
+7984,"@@ -23,7 +23,7 @@ const (
+ 	protocolName    = ""hive""
+ 	protocolVersion = ""1.0.0""
+ 	peersStreamName = ""peers""
+-	messageTimeout  = 5 * time.Second // maximum allowed time for a message to be read or written.
++	messageTimeout  = 1 * time.Minute // maximum allowed time for a message to be read or written.
+ 	maxBatchSize    = 50
+ )
+ ",this is an abysmal amount of time. can you explain under which circumstances you should wait for a minute for a message?,Why this change?
+7985,"@@ -342,6 +342,8 @@ func (o *deployJobOpts) runtimeConfig(addonsURL string) (*stack.RuntimeConfig, e
+ 		AddonsTemplateURL:        addonsURL,
+ 		AdditionalTags:           tags.Merge(o.targetApp.Tags, o.resourceTags),
+ 		ServiceDiscoveryEndpoint: endpoint,
++		AccountID:                o.targetApp.AccountID,
++		Region:                   o.targetEnvironment.Region,
+ 	}, nil
+ }
+ ",Can we add this code to `job_package.go` and `svc_package.go`?,Why do we need t
+7986,"@@ -273,7 +273,9 @@ func CreatePhysicalNode(id NodeID, spec PhysicalProcedureSpec) *PhysicalPlanNode
+ 	}
+ }
+ 
+-const NextPlanNodeIDKey = ""NextPlanNodeID""
++type nodeIDKey string
++
++const NextPlanNodeIDKey nodeIDKey = ""NextPlanNodeID""
+ 
+ func CreateUniquePhysicalNode(ctx context.Context, prefix string, spec PhysicalProcedureSpec) *PhysicalPlanNode {
+ 	if value := ctx.Value(NextPlanNodeIDKey); value != nil {","While you're here, can you change the casing on this so it is unexported? `nextPlanNodeIDKey` instead.",Why do we need t
+7987,"@@ -1,4 +1,5 @@
+-// +build proto
++// +build !bootstrap
++
+ // Contains functions related to dispatching work to remote processes.
+ // Right now those processes must be on the same box because they use
+ // the local temporary directories, but in the future this might form","thanks for tidying all these up, as you can tell they've been used pretty arbitrarily in the past to just exclude things from bootstrap...",Why is this need
+7988,"@@ -204,7 +204,7 @@ class Renderer(Exporter):
+             if (((len(plot) == 1 and not plot.dynamic)
+                 or (len(plot) > 1 and self.holomap is None) or
+                 (plot.dynamic and len(plot.keys[0]) == 0)) or
+-                not unbound_dimensions(plot.streams, plot.dimensions)):
++                not unbound_dimensions(plot.streams, plot.dimensions, False)):
+                 fmt = fig_formats[0] if self.fig=='auto' else self.fig
+             else:
+                 fmt = holomap_formats[0] if self.holomap=='auto' else self.holomap","Again, `no_duplicates=False` would be clearer here...",I don't think you need the `False` here.
+7989,"@@ -36,7 +36,7 @@ import (
+ // function will terminate current and further iterations without errors, and also close the returned channel.
+ // Make sure that you check the second returned parameter from the channel to stop iteration when its value
+ // is false.
+-func (db *DB) SubscribePull(ctx context.Context, bin uint8, since, until uint64) (c <-chan storage.Descriptor, stop func()) {
++func (db *DB) SubscribePull(ctx context.Context, bin uint8, since, until uint64) (c <-chan storage.Descriptor, closed <-chan struct{}, stop func()) {
+ 	db.metrics.SubscribePull.Inc()
+ 
+ 	chunkDescriptors := make(chan storage.Descriptor)",shouldnt we stop these routines BEFORE the db closed?,`closed` is unused (from `structcheck`)
+7990,"@@ -25,6 +25,7 @@ import com.google.common.collect.HashMultimap;
+ import com.google.common.collect.ImmutableMap;
+ import com.google.common.collect.Multimap;
+ 
++import org.openqa.selenium.devtools.target.model.SessionId;
+ import org.openqa.selenium.json.Json;
+ import org.openqa.selenium.json.JsonInput;
+ import org.openqa.selenium.remote.http.HttpClient;",It fills me with endless sadness that we can't use Selenium's own `SessionId` here.,Is this import needed?
+7991,"@@ -88,7 +88,7 @@ public class Docker {
+ 
+     findImage(new ImageNamePredicate(name, tag));
+ 
+-    LOG.info(String.format(""Pulling %s:%s"", name, tag));
++    LOG.finest(String.format(""Pulling %s:%s"", name, tag));
+ 
+     HttpRequest request = new HttpRequest(POST, ""/images/create"");
+     request.addQueryParameter(""fromImage"", name);",This will always need to be displayed to users.,Why did you change this?
+7992,"@@ -1,6 +1,8 @@
+ class CartDecorator < Draper::Decorator
+   delegate_all
+ 
++  CUSTOM_TEMPLATES = %w(navigator whsc)
++
+   def total_price
+     price = object.cart_items.reduce(0) do |sum,citem| sum + citem.quantity * citem.price end
+     Float(""%0.02f"" % price)",Maybe we make an `ORIGINS` constant on the Cart model instead?,Why do we need this?
+7993,"@@ -115,7 +115,7 @@ const (
+ 	//	 a) Add 'authorizationConfig', 'transitEncryption' and 'transitEncryptionPort' to 'taskresource.volume.EFSVolumeConfig'
+ 	//	 b) Add 'pauseContainerPID' field to 'taskresource.volume.VolumeResource'
+ 	// 28) Add 'envfile' field to 'resources'
+-	// 29) Add 'ExecCommandAgentMetadata' field to 'apicontainer.Container'
++	// 29) Add 'ManagedAgentsUnsafe' field to 'apicontainer.Container'
+ 
+ 	ECSDataVersion = 29
+ ",looks like this is not needed anymore with boltdb migration. lets confirm with @fenxiong,Why did you change t
+7994,"@@ -409,7 +409,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet()
++				ws, err := sf.NewWorkingSet(false)
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 408 (from `govet`)",Why was this change 
+7995,"@@ -380,7 +380,7 @@ public class Actions {
+ 
+     // Of course, this is the offset from the centre of the element. We have no idea what the width
+     // and height are once we execute this method.
+-    LOG.info(""When using the W3C Action commands, offsets are from the center of element"");
++    LOG.finest(""When using the W3C Action commands, offsets are from the center of element"");
+     return moveInTicks(target, xOffset, yOffset);
+   }
+ ","Again, the existing level is correct --- we're letting users know about something that might cause there tests to fail.",Why are we changing 
+7996,"@@ -34,7 +34,7 @@ type ProfileDecoder struct {
+ }
+ 
+ func NewProfileDecoder(callbacks passthruCallbacks) *ProfileDecoder {
+-	return &ProfileDecoder{callbacks: callbacks, converter: conversion.Converter{}}
++	return &ProfileDecoder{callbacks: callbacks, converter: conversion.NewConverter()}
+ }
+ 
+ func (p *ProfileDecoder) RegisterWith(d *dispatcher.Dispatcher) {",Required by the libcalico-go changes,Why is this needed?
+7997,"@@ -438,10 +438,12 @@ void write_variables_gnuplot(struct histogram *h, struct histogram *all)
+ 	FILE *f     = open_file(fname);
+ 	free(fname);
+ 
++	fprintf(f, ""%s = %"" PRId64""\n"", ""current_buckets"",    h->nbuckets);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_minimum"",    h->min_value);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_maximum"",    h->max_value);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_mode"",       h->value_at_max_count);
+ 	fprintf(f, ""%s = %"" PRId64""\n"", ""current_mode_count"", h->max_count);
++	fprintf(f, ""%s = %"" PRId64""\n"", ""current_mode_min_count"", h->min_count);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_mean"",       h->mean);
+ 	fprintf(f, ""%s = %lf\n"",        ""current_percentile75"", value_of_p(h, 0.75));
+ 	fprintf(f, ""%s = %lf\n"",        ""current_percentile25"", value_of_p(h, 0.25));","You want ""current_min_count""",This should be `cur
+7998,"@@ -85,14 +85,10 @@ public class MediaStoreProvider {
+           MediaStore.Files.FileColumns.PARENT, MediaStore.Images.Media.BUCKET_DISPLAY_NAME
+         };
+ 
+-    String selection, selectionArgs[];
+-
+-    selection =
+-        MediaStore.Files.FileColumns.MEDIA_TYPE
+-            + ""=? ) GROUP BY ( ""
+-            + MediaStore.Files.FileColumns.PARENT
+-            + "" "";
+-    selectionArgs = new String[] {String.valueOf(MediaStore.Files.FileColumns.MEDIA_TYPE_IMAGE)};
++    String selection = MediaStore.Files.FileColumns.MEDIA_TYPE + ""=? "";
++    String[] selectionArgs =
++        new String[] {String.valueOf(MediaStore.Files.FileColumns.MEDIA_TYPE_IMAGE)};
++    String sortOrder = MediaStore.Files.FileColumns.PARENT;
+ 
+     Cursor cur =
+         context",Why changes in this file?,Why did you remove 
+7999,"@@ -26,6 +26,7 @@ public final class CommentPatterns {
+       Pattern.compile(""\\[([^\\]]+)\\]\\((\\p{Alpha}+:[^\\)]+)\\)"");
+   public static final Pattern CLOUD_LINK_PATTERN =
+       Pattern.compile(""\\[([^\\]]+)\\]\\(((?!\\p{Alpha}+:)[^\\)]+)\\)"");
+-  public static final Pattern PROTO_LINK_PATTERN = Pattern.compile(""\\[([^\\]]+)\\]\\[[^\\]]*\\]"");
++  public static final Pattern PROTO_LINK_PATTERN =
++      Pattern.compile(""\\[([^\\]]+)\\]\\[([A-Za-z_][A-Za-z_.0-9]*)*\\]"");
+   public static final Pattern HEADLINE_PATTERN = Pattern.compile(""^#+"", Pattern.MULTILINE);
+ }",This doesn't look right. I think what you want here is `\\[([^\\]]+)\\]\\[[A-Za-z_][A-Za-z_.0-9]*]*\\]`.,Why is this change 
+8000,"@@ -16,7 +16,7 @@ module Faker
+         return result
+       end
+ 
+-      raise RetryLimitExceeded
++      raise RetryLimitExceeded, ""Retry limit exceeded for #{name}""
+     end
+ 
+     RetryLimitExceeded = Class.new(StandardError)",@AndrewRayCode thanks for contributing   Could you write/modify the specs to make sure that this description is working properly?,Should this be `raise` instead of `raise`?
+8001,"@@ -120,7 +120,8 @@ def default_bucket(request):
+     try:
+         response = request.invoke_subrequest(subrequest)
+     except httpexceptions.HTTPException as error:
+-        if error.content_type == 'application/json':
++        is_redirect = error.status_code < 400
++        if error.content_type == 'application/json' or is_redirect:
+             response = reapply_cors(subrequest, error)
+         else:
+             # Ask the upper level to format the error.",I would have tested 304 only there.,I think this should be `error.status_code 
+8002,"@@ -36,16 +36,15 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+                 {
+                     // Close socket immediately
+                 }
+-            }
+ 
+-            await loggerFactory.FilterLogger.LogTcs.Task;
++                await loggerFactory.FilterLogger.LogTcs.Task.TimeoutAfter(TimeSpan.FromSeconds(10));
++            }
+ 
+             Assert.Equal(1, loggerFactory.FilterLogger.LastEventId.Id);
+             Assert.Equal(LogLevel.Information, loggerFactory.FilterLogger.LastLogLevel);
+             Assert.Equal(0, loggerFactory.ErrorLogger.TotalErrorsLogged);
+         }
+ 
+-
+         [Fact]
+         public async Task ClientHandshakeFailureLoggedAsInformation()
+         {",`TimeoutAfter` to be safe.,Why was this removed?
+8003,"@@ -244,8 +244,14 @@ init_build_bb(build_bb_t *bb, app_pc start_pc, bool app_interp, bool for_cache,
+      * whose fall-through hits our hook.  We avoid interpreting our own hook
+      * by shifting it to the displaced pc.
+      */
+-    if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc)
+-        start_pc = vsyscall_sysenter_displaced_pc;
++    if (DYNAMO_OPTION(hook_vsyscall) && start_pc == vsyscall_sysenter_return_pc) {
++        if (vsyscall_sysenter_displaced_pc != NULL)
++            start_pc = vsyscall_sysenter_displaced_pc;
++        else {
++            /* Our hook must have failed. */
++            ASSERT(should_syscall_method_be_sysenter());
++        }
++    }
+ #endif
+     bb->check_vm_area = true;
+     bb->start_pc = start_pc;",So the 32-bit tests on the new kernel hit this case? Won't they fail in debug build?,I don't think this is the right place to p
+8004,"@@ -46,7 +46,9 @@ public class HTMLTestResults {
+   private final HTMLSuiteResult suite;
+ 
+   private static final String HEADER = ""<html>\n"" +
+-      ""<head><style type='text/css'>\n"" +
++      ""<head>\n""+
++      ""<meta charset=\""UTF-8\"">\n""+
++      ""<style type='text/css'>\n"" +
+       ""body, table {\n"" +
+       ""    font-family: Verdana, Arial, sans-serif;\n"" +
+       ""    font-size: 12;\n"" +","Is there a recommended quote style for attributes? I see single and double here, double further down.",Why is this needed?
+8005,"@@ -5,12 +5,14 @@ module RSpec::Core
+   # with information about a particular event of interest.
+   module Notifications
+ 
+-    # The `CountNotification` represents notifications sent by the formatter
+-    # which a single numerical count attribute. Currently used to notify
+-    # formatters of the expected number of examples.
++    # The `StartNotification` represents a notification sent by the reporter
++    # when the suite is started. It contains the expected amount of examples
++    # to be executed, and the load time of RSpec.
+     #
+     # @attr count [Fixnum] the number counted
+-    CountNotification = Struct.new(:count)
++    # @attr load_time [Float] the number of seconds taken to boot RSpec
++    #                         and load the spec files
++    StartNotification = Struct.new(:count, :load_time)
+ 
+     # The `ExampleNotification` represents notifications sent by the reporter
+     # which contain information about the current (or soon to be) example.",The description of `load_time` here is different from the description below..is that intentional?,I think this should
+8006,"@@ -1547,6 +1547,10 @@ import 'programStyles';
+                     return '<span class=""cardImageIcon material-icons book""></span>';
+                 case 'Folder':
+                     return '<span class=""cardImageIcon material-icons folder""></span>';
++                case 'BoxSet':
++                    return '<span class=""cardImageIcon material-icons collections""></span>';
++                case 'Playlist':
++                    return '<span class=""cardImageIcon material-icons queue_music""></span>';
+             }
+ 
+             if (options && options.defaultCardImageIcon) {",Actually it could also be a video playlist. But music is used more often.,I don't think we ne
+8007,"@@ -36,6 +36,11 @@ function writeCommand(server, type, opsField, ns, ops, options, callback) {
+     writeCommand.bypassDocumentValidation = options.bypassDocumentValidation;
+   }
+ 
++  if (writeConcern.w === 0) {
++    // don't include session for unacknowledged writes
++    delete options.session;
++  }
++
+   const commandOptions = Object.assign(
+     {
+       checkKeys: type === 'insert',","From the ticket: > I understand why a session ID would be silently omitted for implicit sessions, but what is the reasoning behind omitting it for explicit sessions instead of raising a logic error to the user? So what this change is doing is ""silently omitting"" the session if its an unacknowledged write. I think we want to actually return an error in this case.",Why do we need this
+8008,"@@ -85,6 +85,17 @@ namespace pwiz.Skyline.Model.Databinding.Entities
+         [Format(NullValue = TextUtil.EXCEL_NA)]
+         public int? PointsAcrossPeak { get { return ChromInfo.PointsAcrossPeak; } }
+ 
++        [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)]
++        public double? AverageCycleTime
++        {
++            get
++            {
++                return StartTime.HasValue && EndTime.HasValue && PointsAcrossPeak.HasValue
++                    ? (EndTime.Value - StartTime.Value) * 60 / PointsAcrossPeak.Value
++                    : (double?) null;
++            }
++        }
++
+         public bool Coeluting { get { return !ChromInfo.IsForcedIntegration; } }
+ 
+         [Format(Formats.RETENTION_TIME, NullValue = TextUtil.EXCEL_NA)]",You can simplify this by doing: return (EndTime - StartTime) * 60 / PointsAcrossPeak;,I don't think you need the `HasValue` check here. `EndTime.HasValue` is always true.
+8009,"@@ -56,7 +56,7 @@ ColorPickerWidget::ColorPickerWidget(QWidget *parent):
+     QFrame(parent)
+ {
+     QFontMetrics fm (mLineEdit.font());
+-    mLineEdit.setFixedWidth ( 10*fm.width (QStringLiteral(""a"")) );
++    mLineEdit.setFixedWidth ( 10*fm.horizontalAdvance (QStringLiteral(""a"")) );
+ 
+     QHBoxLayout *layout = new QHBoxLayout(this);
+     layout->setContentsMargins (0, 0, 0, 0);","I think it's the time for bumping `REQUIRED_QT_VERSION` to the last LTS, 5.12. `QFontMetrics::horizontalAdvance()` doesn't exist in 5.10.",Why this change?
+8010,"@@ -21,7 +21,8 @@ module Bolt
+       statement_count: :cd6,
+       resource_mean: :cd7,
+       plan_steps: :cd8,
+-      return_type: :cd9
++      return_type: :cd9,
++      boltdir_type: :cd11
+     }.freeze
+ 
+     def self.build_client","I already set up cd10 for ""inventory_version in google analytics. I've added cd11 for Boltdir Type now",why do we need this?
+8011,"@@ -45,6 +45,10 @@ module Travis
+   module Build
+     class Script
+       TEMPLATES_PATH = File.expand_path('../templates', __FILE__)
++      INTERNAL_RUBY_REGEX = ENV.fetch(
++        'TRAVIS_INTERNAL_RUBY_REGEX',
++        'ruby-(2\.[0-2]\.[0-9]|1\.9\.3)'
++      ).untaint
+       DEFAULTS = {}
+ 
+       class << self",@henrikhodne We are lazily skipping `jruby-*` here (assuming that JRuby all of a sudden start using these version numbers).,"I'm not sure if this is the best way to do this, but I'm not sure if there's a bette"
+8012,"@@ -739,8 +739,11 @@ void CPaintStatistics::DrawAxis(wxDC &dc, const double max_val_y, const double m
+ 	double y_start_val = ceil(min_val_y / d_oy_val) * d_oy_val;
+ 	d_oy_count = (int)floor((max_val_y - y_start_val) / d_oy_val);
+ 
++    double temp_int_part;
++    int prec = modf(d_oy_val, &temp_int_part) == 0.0 ? 0 : 2;
++
+ 	for (double ny = 0; ny <= double(d_oy_count); ++ny){
+-		dc.GetTextExtent(wxString::Format(wxT(""%s""), format_number(y_start_val + ny * d_oy_val, 2)), &w_temp, &h_temp, &des_temp, &lead_temp);
++		dc.GetTextExtent(wxString::Format(wxT(""%s""), format_number(y_start_val + ny * d_oy_val, prec)), &w_temp, &h_temp, &des_temp, &lead_temp);
+ 		x0 = wxCoord(m_Graph_X_start + 1.0);
+ 		y0 = wxCoord(m_Ay_ValToCoord * (y_start_val + ny * d_oy_val) + m_By_ValToCoord);
+ 		x1 = wxCoord(m_Graph_X_end - 1.0);",How does this cope with values like `5.001`? Shouldn't that set precision to 0? Instead it is set to 2.,"I think this should be `modf(d_oy_val, 2.0)`"
+8013,"@@ -40,7 +40,7 @@ class APITestCase(IntegrationTestCase):
+         # This sleep allows for the influx subscriber to take its time in getting
+         # the listen submitted from redis and writing it to influx.
+         # Removing it causes an empty list of listens to be returned.
+-        time.sleep(10)
++        time.sleep(15)
+ 
+         url = url_for('api_v1.get_listens', user_name = self.user['musicbrainz_id'])
+         response = self.client.get(url, query_string = {'count': '1'})","Rather than having a sleep here, we should check to see if the service we're waiting for is up yet, using something like dockerize. Not critical this second, but would be nice for later.",Why did you change this?
+8014,"@@ -0,0 +1,18 @@
++import path from 'path';
++import execa from 'execa';
++import {
++  displayErrorMessage
++} from '../../scripts/utils/console.mjs';
++
++((async function() {
++  try {
++    await execa('npm', ['run', 'swap-package-links'], {
++      cwd: path.resolve(process.cwd(), '..'),
++      stdio: 'inherit'
++    });
++
++  } catch (error) {
++    displayErrorMessage('Error running the script.');
++    process.exit(error.exitCode);
++  }
++})());",I'm not sure if there are any links to swap for Handosntable package. Should this be a top lvl script?,I think it would be better to use `process.e
+8015,"@@ -537,7 +537,16 @@ signal_thread_init(dcontext_t *dcontext, void *os_data)
+         signal_frame_extra_size(true)
+         /* sigpending_t has xstate inside it already */
+         IF_LINUX(IF_X86(-sizeof(kernel_xstate_t)));
+-    IF_LINUX(IF_X86(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT))));
++/* Above does not guarantee alignment, it only guarantees sufficient space including
++ * aligmment of the extended state. The following is needed in order to guarantee
++ * alignment of our pending unit's size, which is used as the block size in the
++ * special allocator.
++ */
++#ifdef X86
++    pend_unit_size =
++        ALIGN_FORWARD(pend_unit_size, YMM_ENABLED() ? AVX_ALIGNMENT : FPSTATE_ALIGNMENT);
++    IF_LINUX(ASSERT(!YMM_ENABLED() || ALIGNED(pend_unit_size, AVX_ALIGNMENT)));
++#endif
+ 
+     /* all fields want to be initialized to 0 */
+     memset(info, 0, sizeof(thread_sig_info_t));","It seems like it's too big now: can we remove signal_frame_extra_size from line 537? That should only be needed when placing xstate separately. It seems like it isn't needed at all for pending? Also, if we have special heap align forward for us, we don't need this align here either.",I don't think this is the right place to do 
+8016,"@@ -128,9 +128,12 @@ catch
+                 # fortunately, using PS with stdin input_method should never happen
+                 if input_method == 'powershell'
+                   conn.execute(<<-PS)
+-$private:taskArgs = Get-ContentAsJson (
++$private:tempArgs = Get-ContentAsJson (
+   $utf8.GetString([System.Convert]::FromBase64String('#{Base64.encode64(JSON.dump(arguments))}'))
+ )
++$allowedArgs = (Get-Command ""#{remote_path}"").Parameters.Keys
++$private:taskArgs = @{}
++$private:tempArgs.Keys | ? { $allowedArgs -contains $_ } | % { $private:taskArgs[$_] = $private:tempArgs[$_] }
+ try { & ""#{remote_path}"" @taskArgs } catch { Write-Error $_.Exception; exit 1 }
+               PS
+                 else","Just double checked the `-in` operator. It's PS3 only, so we might want to change `$_ -in $allowedArgs` to `$allowedArgs -contains $_`","Why not just `taskArgs = Get-Command ""#{remote_path}""`"
+8017,"@@ -152,6 +152,14 @@ class StartButton(IAccessible):
+ 		states = super(StartButton, self).states
+ 		states.discard(controlTypes.STATE_SELECTED)
+ 		return states
++		
++class UIProperty(UIA):
++	#Used for columns in Windows Explorer Details view.
++	#These can contain dates that include unwanted left-to-right and right-to-left indicator characters.
++	
++	def _get_value(self):
++		value = super(UIProperty, self).value
++		return value.replace(u'\u200E','').replace(u'\u200F','')
+ 
+ 
+ class AppModule(appModuleHandler.AppModule):","Might as well use translate here, as @jcsteh suggested","missing whitespace after ','"
+8018,"@@ -145,8 +145,9 @@ class DimensionedPlot(Plot):
+     show_title = param.Boolean(default=True, doc=""""""
+         Whether to display the plot title."""""")
+ 
+-    title_format = param.String(default=""{label} {group}"", doc=""""""
+-        The formatting string for the title of this plot."""""")
++    title_format = param.String(default=""{label} {group}\n{dimensions}"", doc=""""""
++        The formatting string for the title of this plot, allows defining
++        a label group separator and dimension labels."""""")
+ 
+     normalize = param.Boolean(default=True, doc=""""""
+         Whether to compute ranges across all Elements at this level",Definitely an improvement as long as the old tests pass (i.e backwards compatible).,I don't think you need the `\n` here.
+8019,"@@ -22,11 +22,11 @@ package com.netflix.iceberg;
+ import com.google.common.collect.Maps;
+ import com.netflix.iceberg.exceptions.RuntimeIOException;
+ import com.netflix.iceberg.io.FileIO;
+-import java.util.Map;
+ import com.netflix.iceberg.io.LocationProvider;
+ import org.junit.rules.TemporaryFolder;
+ 
+ import java.io.IOException;
++import java.util.Map;
+ 
+ class LocalTableOperations implements TableOperations {
+   private final TemporaryFolder temp;",nit: non functional change,Why this change?
+8020,"@@ -130,6 +130,17 @@ func main() {
+ 		}()
+ 	}
+ 
++	// Fail fast if the AWS credentials are not present.
++	awsCredentialsPath := os.Getenv(""AWS_SHARED_CREDENTIALS_FILE"")
++	if len(awsCredentialsPath) == 0 {
++		awsCredentialsPath = ""/home/.aws/credentials""
++	}
++	_, err := os.Stat(awsCredentialsPath)
++	if err != nil {
++		setupLog.Error(err, ""AWS credentials not found"")
++		os.Exit(1)
++	}
++
+ 	ctrl.SetLogger(klogr.New())
+ 	// Machine and cluster operations can create enough events to trigger the event recorder spam filter
+ 	// Setting the burst size higher ensures all events will be recorded and submitted to the API","The file is not required - if you're using an IAM instance profile, for example. I'm not sure we can error 100% of the time if it's missing. @randomvariable any suggestions?",I think this should be `/var/run/aws/credentials`
+8021,"@@ -2527,7 +2527,7 @@ func (c *Compiler) parseExpr(frame *Frame, expr ssa.Value) (llvm.Value, error) {
+ 		}
+ 
+ 		if expr.High != nil {
+-			highType = expr.High.Type().(*types.Basic)
++			highType = expr.High.Type().Underlying().(*types.Basic)
+ 			high, err = c.parseExpr(frame, expr.High)
+ 			if err != nil {
+ 				return llvm.Value{}, nil",There is a very similar line `lowType = expr.Low.Type().(*types.Basic)` a few lines above this line. Can you change that in the same way?,Why is this change needed?
+8022,"@@ -0,0 +1,19 @@
++/*
++ * Copyright ConsenSys AG.
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
++ * the License. You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
++ * an ""AS IS"" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
++ * specific language governing permissions and limitations under the License.
++ *
++ * SPDX-License-Identifier: Apache-2.0
++ */
++package org.hyperledger.besu.consensus.merge.blockcreation;
++
++import org.hyperledger.besu.ethereum.blockcreation.MiningCoordinator;
++
++public interface MergeMiningCoordinator extends MiningCoordinator {}",New files should be copyright Hyperledger Besu Contributors.,Why do we need this interface?
+8023,"@@ -34,5 +34,18 @@ module Bolt
+         sftp.upload!(source, destination)
+       end
+     end
++
++    def make_tempdir
++      @session.exec!('mktemp -d').chomp
++    end
++
++    def run_script(script)
++      dir = make_tempdir
++      remote_path = ""#{dir}/#{File.basename(script)}""
++      copy(script, remote_path)
++      execute(""chmod u+x \""#{remote_path}\"""")
++      execute(""\""#{remote_path}\"""")
++      execute(""rm -rf \""#{dir}\"""")
++    end
+   end
+ end","if I give a non-existent script, then I don't get an errors. I would have expected the `copy` method to raise, but maybe `net-sftp` silently exits?",Why is this necessary?
+8024,"@@ -4343,10 +4343,12 @@ class Series(Frame, IndexOpsMixin, Generic[T]):
+         """"""
+         if to_replace is None:
+             return self.fillna(method=""ffill"")
+-        if not isinstance(to_replace, (str, list, dict, int, float)):
+-            raise ValueError(""'to_replace' should be one of str, list, dict, int, float"")
++        if not isinstance(to_replace, (str, list, tuple, dict, int, float)):
++            raise ValueError(""'to_replace' should be one of str, list, tuple, dict, int, float"")
+         if regex:
+             raise NotImplementedError(""replace currently not support for regex"")
++        to_replace = list(to_replace) if isinstance(to_replace, tuple) else to_replace
++        value = list(value) if isinstance(value, tuple) else value
+         if isinstance(to_replace, list) and isinstance(value, list):
+             if not len(to_replace) == len(value):
+                 raise ValueError(",@itholic can you also update the parameters in the docs?,"I don't think this is the right place to do this. If `to_replace` is a tuple, then `value` should be a list."
+8025,"@@ -292,6 +292,11 @@ public final class IntMap<T> implements Traversable<T>, Serializable {
+             public int characteristics() {
+                 return spliterator.characteristics();
+             }
++
++            @Override
++            public Comparator<? super T> getComparator() {
++                return null;
++            }
+         }
+         return new SpliteratorProxy(original.spliterator());
+     }","The super impl Spliterator.getComparator() throws an IllegalStateException by default. Is it really necessary to return null? If null is used somewhere it will throw a NPE, which is roughly the same as throwing an IllegalStateException. I'm just curious - I'm sure there is a reason!",Why is this needed?
+8026,"@@ -256,7 +256,7 @@ public class Avro {
+       schema(table.schema());
+       withSpec(table.spec());
+       setAll(table.properties());
+-      metricsConfig(MetricsConfig.fromProperties(table.properties()));
++      metricsConfig(MetricsConfig.forTable(table));
+       return this;
+     }
+ ",Do we need to do the same in Avro `WriteBuilder` too? I don't think we use that method right now but should make sense for consistency. We already handle that for Parquet.,"nit: `MetricsConfig.forTable(table, this);`"
+8027,"@@ -319,6 +319,8 @@ int FlatCompiler::Compile(int argc, const char **argv) {
+         opts.force_defaults = true;
+       } else if (arg == ""--force-empty"") {
+         opts.set_empty_to_null = false;
++      } else if (arg == ""--java_primitive_has_method"") {
++        opts.java_primitive_has_method = true;
+       } else {
+         for (size_t i = 0; i < params_.num_generators; ++i) {
+           if (arg == params_.generators[i].generator_opt_long ||",can you make all the `_` into `-` to be consistent with the other options?,"This should be `opts.java_primitive_has_method = arg == ""--java-primitive-has-method""`"
+8028,"@@ -0,0 +1,15 @@
++// Copyright 2019 Amazon.com, Inc. or its affiliates. All Rights Reserved.
++// SPDX-License-Identifier: Apache-2.0
++
++package archer
++
++import ""github.com/aws/aws-sdk-go/service/cloudformation""
++
++// StackConfiguration represents an entity that can be serialized
++// into a Cloudformation template
++type StackConfiguration interface {
++	StackName() string
++	Template() (string, error)
++	Parameters() []*cloudformation.Parameter
++	Tags() []*cloudformation.Tag
++}",What do you think of renaming this file to `stack.go` or `cfn_stack.go`? `common.go`/`util.go` don't provide us anything descriptive about the contents of the file.,I'm not sure if this is the right place to put this. I think it should be in the `aws` package.
+8029,"@@ -19,12 +19,14 @@ using System.Runtime.CompilerServices;
+ #if SIGNED
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
+ [assembly: InternalsVisibleTo(""Benchmarks, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
++[assembly: InternalsVisibleTo(""Examples.Console, PublicKey=002400000480000094000000060200000024000052534131000400000100010051c1562a090fb0c9f391012a32198b5e5d9a60e9b80fa2d7b434c9e5ccb7259bd606e66f9660676afc6692b8cdc6793d190904551d2103b7b22fa636dcbb8208839785ba402ea08fc00c8f1500ccef28bbf599aa64ffb1e1d5dc1bf3420a3777badfe697856e9d52070a50c3ea5821c80bef17ca3acffa28f89dd413f096f898"")]
+ 
+ // Used by Moq.
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2, PublicKey=0024000004800000940000000602000000240000525341310004000001000100c547cac37abd99c8db225ef2f6c8a3602f3b3606cc9891605d02baa56104f4cfc0734aa39b93bf7852f7d9266654753cc297e7d2edfe0bac1cdcf9f717241550e0a7b191195b7667bb4f64bcb8e2121380fd1d9d46ad2d92d2d15605093924cceaf74c4861eff62abf69b9291ed0a340e113be11e6a7d3113e92484cf7045cc7"")]
+ #else
+ [assembly: InternalsVisibleTo(""OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests"")]
+ [assembly: InternalsVisibleTo(""Benchmarks"")]
++[assembly: InternalsVisibleTo(""Examples.Console"")]
+ 
+ // Used by Moq.
+ [assembly: InternalsVisibleTo(""DynamicProxyGenAssembly2"")]","It isn't a very effective example if it requires access to the internals   I can't tell just looking at the diff why this is needed, can you provide a little context?","[assembly: InternalsVisibleTo(""Example.Console, PublicKey=0024000004800000940000000602000000240"
+8030,"@@ -3,13 +3,16 @@
+ require 'spec_helper'
+ require 'bolt/transport/local'
+ require 'bolt/target'
++require 'bolt/inventory'
++require 'bolt_spec/transport'
+ 
+ require_relative 'shared_examples'
+ 
+ describe Bolt::Transport::Local, bash: true do
+-  let(:runner) { Bolt::Transport::Local.new }
++  include BoltSpec::Transport
++
++  let(:transport) { :local }
+   let(:os_context) { posix_context }
+-  let(:transport_conf) { {} }
+   let(:target) { Bolt::Target.new('local://localhost', transport_conf) }
+ 
+   it 'is always connected' do",Why does this include `bolt/inventory`?,Why did you remove this?
+8031,"@@ -427,7 +427,7 @@ public final class LinkedHashMap<K, V> implements Kind2<LinkedHashMap<?, ?>, K,
+         Queue<Tuple2<K, V>> newList = list;
+         HashMap<K, V> newMap = map;
+         if (containsKey(key)) {
+-            newList = newList.filter(t -> !t._1.equals(key));
++            newList = newList.filter(t -> !Objects.equals(t._1, key));
+             newMap = newMap.remove(key);
+         }
+         newList = newList.append(Tuple.of(key, value));",We called `t._1.equals(...)` where `t._1` potentially could be `null`.,Why not use `Objects.equals`?
+8032,"@@ -0,0 +1,14 @@
++/* global forms */
++const rangeRoles = ['progressbar', 'scrollbar', 'slider', 'spinbutton'];
++
++/**
++ * Determines if an element is an aria range element
++ * @method isAriaRange
++ * @memberof axe.commons.forms
++ * @param {Element} node Node to determine if aria range
++ * @returns {Bool}
++ */
++forms.isAriaRange = function(node) {
++	const role = axe.commons.aria.getRole(node, { noImplicit: true });
++	return rangeRoles.includes(role) && node.hasAttribute('aria-valuenow');
++};","I don't think we should include the `hasAttribute` test here. Even without aria-valuenow, it's still an aria range element. This check is going to make reuse of this function problematic. Better to move the attribute check part outside this function IMO.",I think this should be `axe.commons.aria.isRange`
+8033,"@@ -35,6 +35,7 @@ class ErgonodeFixtureCommand extends Command
+         $this->setName('ergonode:fixture:load');
+         $this->setDescription('Fill database with data');
+         $this->addOption('group', 'g', InputOption::VALUE_REQUIRED, 'Group');
++        $this->addOption('file', 'f', InputOption::VALUE_REQUIRED, 'File');
+     }
+ 
+     /**",Shouldn't it be optional?,Why do we need this option?
+8034,"@@ -55,6 +55,7 @@ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegio
+ 			cfg,
+ 			metadata.ClientInfo{
+ 				ServiceName:   ServiceName,
++				ServiceID:     ""API Gateway"",
+ 				SigningName:   signingName,
+ 				SigningRegion: signingRegion,
+ 				Endpoint:      endpoint,","would be helpful to make these a package level constant so they are accessible to the user. similar to Service Name. Not directly related note, v2 SDK ServiceName should be renamed to ServiceEndpointPrefix.","Why is this ""API Gateway""?"
+8035,"@@ -18,7 +18,7 @@ class Storage
+ 
+     public function load(string $path)
+     {
+-        return include $this->realpath($path);
++        return file_exists($this->realpath($path)) ? include $this->realpath($path) : null;
+     }
+ 
+     public function store(string $path, string $content): void",Duplicate call to the method. Better to put in a variable.,Shouldn't this be `return file_exists($this->real
+8036,"@@ -1023,8 +1023,9 @@ type Prefetcher interface {
+ 	// PrefetchAfterBlockRetrieved allows the prefetcher to trigger prefetches
+ 	// after a block has been retrieved. Whichever component is responsible for
+ 	// retrieving blocks will call this method once it's done retrieving a
+-	// block.
+-	PrefetchAfterBlockRetrieved(b Block, kmd KeyMetadata, priority int,
++	// block. It caches if it has triggered a prefetch and returns that.
++	PrefetchAfterBlockRetrieved(b Block, blockPtr BlockPointer,
++		kmd KeyMetadata, priority int, lifetime BlockCacheLifetime,
+ 		hasPrefetched bool)
+ 	// Shutdown shuts down the prefetcher idempotently. Future calls to
+ 	// the various Prefetch* methods will return io.EOF. The returned channel","""and returns that"" -- it looks like this method has no return value.",nit: `it caches if it has triggered a prefetch`
+8037,"@@ -212,7 +212,7 @@ class BitmapMasks(BaseInstanceMasks):
+ 
+     def flip(self, flip_direction='horizontal'):
+         """"""See :func:`BaseInstanceMasks.flip`.""""""
+-        assert flip_direction in ('horizontal', 'vertical')
++        assert flip_direction in ('horizontal', 'vertical', 'diagonal')
+ 
+         if len(self.masks) == 0:
+             flipped_masks = self.masks",Modifications are also needed for PolygonMask.,Shouldn't this be `'diagonal'`?
+8038,"@@ -3,12 +3,9 @@
+ 
+ using System;
+ using System.Net;
+-using Microsoft.AspNetCore;
+ using Microsoft.AspNetCore.Hosting;
+-using Microsoft.AspNetCore.Server.Kestrel.Core;
+-using Microsoft.AspNetCore.Server.Kestrel.Transport.Abstractions.Internal;
++using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http;
+ using Microsoft.Extensions.Configuration;
+-using Microsoft.Extensions.DependencyInjection;
+ 
+ namespace PlatformBenchmarks
+ {",Does this really make a difference?,Why is this being removed?
+8039,"@@ -70,6 +70,9 @@ public class TestRandomFlRTGCloud extends SolrCloudTestCase {
+ 
+   /** Always included in fl so we can vet what doc we're looking at */
+   private static final FlValidator ID_VALIDATOR = new SimpleFieldValueValidator(""id"");
++
++  /** Since nested documents are not tested, when _root_ is declared in schema, it is always the same as id */
++  private static final FlValidator ROOT_VALIDATOR = new RenameFieldValueValidator(""id"" , ""_root_"");
+   
+   /** 
+    * Types of things we will randomly ask for in fl param, and validate in response docs.","Added a validator for _root_, which is now added automatically since the schema used here declares _root_.",I don't think we need the `_root_` here.
+8040,"@@ -76,6 +76,12 @@ public interface RewriteDataFiles extends SnapshotUpdate<RewriteDataFiles, Rewri
+    */
+   String TARGET_FILE_SIZE_BYTES = ""target-file-size-bytes"";
+ 
++  /**
++   * The estimated cost to open a file, used as a minimum weight when combining splits. By default this
++   * will use the ""read.split.open-file-cost"" value in the table properties of the table being updated.
++   */
++  String OPEN_FILE_COST = ""open-file-cost"";
++
+   /**
+    * Choose BINPACK as a strategy for this rewrite operation
+    * @return this for method chaining","The other properties are `file-open-cost`, not `open-file-cost`.",I think this should be called `target-file-cost`
+8041,"@@ -337,6 +337,19 @@ AC_ARG_ENABLE(easylogging,
+         [Disable easylogging]))
+ AM_CONDITIONAL(USE_EASYLOGGING, [test x$enable_easylogging != xno])
+ 
++case ""${host_os}"" in
++    *darwin*)
++        # libunwind comes standard with the command-line tools on macos
++        AC_DEFINE([HAVE_LIBUNWIND], [1],
++            [Define to 1 if you have the <libunwind.h> header file])
++        ;;
++    *)
++        PKG_CHECK_MODULES(libunwind, libunwind,
++            AC_DEFINE([HAVE_LIBUNWIND], [1],
++                [Define to 1 if you have the <libunwind.h> header file]))
++        ;;
++esac
++
+ # Need this to pass through ccache for xdrpp, libsodium
+ esc() {
+     out=",confused by this: what we need here is not libunwind but libunwind-dev right? Why skipping detection?,Why is this needed?
+8042,"@@ -24,8 +24,8 @@ namespace Microsoft.Azure
+                 throw new ArgumentNullException(""serializer"");
+             }
+             JsonSerializer newSerializer = new JsonSerializer();
+-            PropertyInfo[] properties = typeof(JsonSerializer).GetProperties();
+-            foreach (var property in properties.Where(p => p.GetSetMethod() != null))
++            var properties = typeof(JsonSerializer).GetTypeInfo().DeclaredProperties;
++            foreach (var property in properties.Where(p => p.SetMethod != null && !p.SetMethod.IsPrivate))
+             {
+                 property.SetValue(newSerializer, property.GetValue(serializer, null), null);
+             }","just in case helps, it this related with this PR?",Why is this change needed?
+8043,"@@ -88,6 +88,11 @@ def convert_019_100(data):
+ 
+ def convert_100_200(data):
+     data[""version""] = (2, 0, 0)
++    data[""client_conn""][""address""] = data[""client_conn""][""address""][""address""]
++    data[""server_conn""][""address""] = data[""server_conn""][""address""][""address""]
++    data[""server_conn""][""source_address""] = data[""server_conn""][""source_address""][""address""]
++    if data[""server_conn""][""ip_address""]:
++        data[""server_conn""][""ip_address""] = data[""server_conn""][""ip_address""][""address""]
+     return data
+ 
+ ",This is incomplete I think (at least source_address and ip_address are missing),Why do we need this?
+8044,"@@ -126,7 +126,16 @@ public class DefaultSynchronizer<C> implements Synchronizer {
+       LOG.info(""Starting synchronizer."");
+       blockPropagationManager.start();
+       if (fastSyncDownloader.isPresent()) {
+-        fastSyncDownloader.get().start().whenComplete(this::handleFastSyncResult);
++        fastSyncDownloader
++            .get()
++            .start()
++            .whenComplete(this::handleFastSyncResult)
++            .exceptionally(
++                ex -> {
++                  System.exit(0);
++                  return null;
++                });
++
+       } else {
+         startFullSync();
+       }","We have a `stop` method here, we should probably be calling that instead of just exiting. There could be important resources to close or cleanup nicely now or in the future.",Why is this needed?
+8045,"@@ -35,6 +35,7 @@ namespace AutoRest.Extensions
+                 //Constraints = parameter.Constraints, Omit these since we don't want to perform parameter validation
+                 Documentation = parameter.Documentation,
+                 ModelType = parameter.ModelType,
++                RealPath = new string[] { },
+                 SerializedName = default(string) //Parameter is never serialized directly
+             });
+ ",fixes ArgNullEx when using both `x-ms-parameter-grouping` and media type `application/xml` in the same operation (issue #2236),Why do we need this
+8046,"@@ -33,6 +33,12 @@ const (
+ 	// The specified bucket does not exist.
+ 	ErrCodeNoSuchBucket = ""NoSuchBucket""
+ 
++	// ErrCodeBucketNotFound for service response error code
++	// ""NotFound"".
++	//
++	// The specified bucket does not exist
++	ErrCodeBucketNotFound = ""NotFound""
++
+ 	// ErrCodeNoSuchKey for service response error code
+ 	// ""NoSuchKey"".
+ 	//","`NotFound` is a generic error code derived from the HTTP response message's status code, and can be returned for any S3 operation that responds with a 404 status code and no other error code present. Due to this the constant `ErrCodeBucketNotFound`. In addition, these constants are generated based on the API model defined by Amazon S3, modifications to the file directly will be lost during regeneration of the API. With that said, we are looking at ways to work with the Amazon S3 team to better represent this error in a way that is more easily consumed.",I think this should
+8047,"@@ -0,0 +1,18 @@
++test_name 'test generic installers'
++
++step 'install arbitrary msi via url' do
++  hosts.each do |host|
++    if host['platform'] =~ /win/
++      # this should be implemented at the host/win/pkg.rb level someday
++      generic_install_msi_on(host, 'https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1.8.4.msi', {}, {:debug => true})
++    end
++  end
++end
++
++step 'install arbitrary dmg via url' do
++  hosts.each do |host|
++    if host['platform'] =~ /osx/
++      host.generic_install_dmg('https://releases.hashicorp.com/vagrant/1.8.4/vagrant_1.8.4.dmg', 'Vagrant', 'Vagrant.pkg')
++    end
++  end
++end","@johnduarte I was curious about the case when the operating system was neither `osx` or `win`; in this case, the test will indeed pass, but nothing will have actually really been tested. Should this have a `skip_test` condition at the top?",This should be `hos
+8048,"@@ -0,0 +1,10 @@
++package main
++
++import ""time""
++
++func main() {
++	for {
++		println(""hello world!"")
++		time.Sleep(time.Second)
++	}
++}",I think this example was included by accident? It doesn't seem to belong in this PR (but a separate PR with this would be nice!).,This file is missing the license header.
+8049,"@@ -128,7 +128,7 @@ public class RestRequest {
+ 	 * 
+ 	 * @param method				the HTTP method for the request (GET/POST/DELETE etc)
+ 	 * @param path					the URI path, this will automatically be resolved against the users current instance host.
+-	 * @param httpEntity			the request body if there is one, can be null.
++	 * @param requestEntity			the request body if there is one, can be null.
+ 	 */
+ 	public RestRequest(RestMethod method, String path, HttpEntity requestEntity) {
+ 		this(method, path, requestEntity, null);",Just fixing a bunch of outdated java docs in this file,Why did you change this?
+8050,"@@ -51,7 +51,7 @@ namespace Nethermind.TxPool
+ 
+         private readonly object _locker = new();
+ 
+-        private readonly ConcurrentDictionary<Address, AddressNonces> _nonces =
++        private readonly Dictionary<Address, AddressNonces> _nonces =
+             new();
+ 
+         private readonly LruKeyCache<Keccak> _hashCache = new(MemoryAllowance.TxHashCacheSize,",I think it may be safer not to touch Concurrent to normal.,`ConcurrentDictionary` is not thread saf
+8051,"@@ -158,6 +158,10 @@ class Server extends EventEmitter {
+     // setup listeners
+     this.s.pool.on('parseError', parseErrorEventHandler(this));
+ 
++    this.s.pool.on('drain', err => {
++      this.emit('error', err);
++    });
++
+     // it is unclear whether consumers should even know about these events
+     // this.s.pool.on('timeout', timeoutEventHandler(this));
+     // this.s.pool.on('reconnect', reconnectEventHandler(this));","is this for everything, or just legacy?",I don't think we want to emit an error h
+8052,"@@ -368,6 +368,15 @@ function processNewChange(args) {
+   const change = args.change;
+   const callback = args.callback;
+   const eventEmitter = args.eventEmitter || false;
++
++  if (changeStream.isClosed()) {
++    if (eventEmitter) return;
++
++    const error = new Error('ChangeStream is closed');
++    if (typeof callback === 'function') return callback(error, null);
++    return changeStream.promiseLibrary.reject(error);
++  }
++
+   const topology = changeStream.topology;
+   const options = changeStream.cursor.options;
+ ",I think this should be a `MongoError` right?,Why do we need to check for eventEmitter here?
+8053,"@@ -14,8 +14,10 @@ var (
+ 	DdevBin      = ""ddev""
+ 	DevTestSites = []testcommon.TestSite{
+ 		{
+-			Name:        ""drupal8"",
+-			DownloadURL: ""https://github.com/drud/drupal8/archive/v0.2.2.tar.gz"",
++			Name:      ""drupal8"",
++			SourceURL: ""https://github.com/drud/drupal8/archive/v0.2.2.tar.gz"",
++			FileURL:   ""https://github.com/drud/drupal8/releases/download/v0.2.2/files.tar.gz"",
++			DBURL:     ""https://github.com/drud/drupal8/releases/download/v0.2.2/db.tar.gz"",
+ 		},
+ 	}
+ )",This is currently a db.tar.gz with just one .sql file in it. It might be worth another test (or maybe I'll find one) that has more than one sql file in it.,This should be `db.tar.gz`
+8054,"@@ -218,6 +218,14 @@ var _ = infrastructure.DatastoreDescribe(""VXLAN topology before adding host IPs
+ 					policy.Spec.Selector = ""has(host-endpoint)""
+ 					_, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions)
+ 					Expect(err).NotTo(HaveOccurred())
++
++					policy = api.NewGlobalNetworkPolicy()
++					policy.Name = ""allow-all-egress-normal""
++					policy.Spec.Order = &order
++					policy.Spec.Egress = []api.Rule{{Action: api.Allow}}
++					policy.Spec.Selector = ""has(host-endpoint)""
++					_, err = client.GlobalNetworkPolicies().Create(utils.Ctx, policy, utils.NoOptions)
++					Expect(err).NotTo(HaveOccurred())
+ 				})
+ 
+ 				It(""should not block any traffic"", func() {",Why these changes to existing tests?,Why do we need this?
+8055,"@@ -141,6 +141,12 @@ namespace Datadog.Trace.Configuration
+             HeaderTags = HeaderTags.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
+                                    .ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
+ 
++            var serviceNameMappings = source?.GetDictionary(ConfigurationKeys.ServiceNameMappings)
++                                      ?.Where(kvp => !string.IsNullOrEmpty(kvp.Key) && !string.IsNullOrEmpty(kvp.Value))
++                                      ?.ToDictionary(kvp => kvp.Key.Trim(), kvp => kvp.Value.Trim());
++
++            ServiceNameMappings = new ServiceNames(serviceNameMappings);
++
+             DogStatsdPort = source?.GetInt32(ConfigurationKeys.DogStatsdPort) ??
+                             // default value
+                             8125;","It should be `IsNullOrWhitespace` I believe, since we're going to trim the value afterwards (and I just realized the other configuration keys have the same issue)",nit: `?.` is redundant.
+8056,"@@ -72,9 +72,9 @@ module Bolt
+ 
+     # Returns a hash of implementation name, path to executable, input method (if defined),
+     # and any additional files (name and path)
+-    def select_implementation(target, additional_features = [])
++    def select_implementation(target, provided_features = [])
+       impl = if (impls = implementations)
+-               available_features = target.features + additional_features
++               available_features = target.features + provided_features
+                impl = impls.find do |imp|
+                  remote_impl = imp['remote']
+                  remote_impl = metadata['remote'] if remote_impl.nil?",This is just for consistency + searchability with the transports,`provided_features` -> `provided_features`
+8057,"@@ -42,6 +42,7 @@ import (
+ const (
+ 	CertFile = ""/tmp/kubeedge/certs/edge.crt""
+ 	KeyFile  = ""/tmp/kubeedge/certs/edge.key""
++	ConfigPath = ""/tmp/kubeedge/testData""
+ )
+ 
+ //testServer is a fake http server created for testing",please run gofmt.,Why do we need this?
+8058,"@@ -1,4 +1,4 @@
+-package porcelain_test
++package porcelain
+ 
+ import (
+ 	""context""","thats kind of a bummer, why do we have to give it full access? if it is just for the private interfaces i'd personally rather have those interfaces pollute the public exported symbols than open the tests up like this.",Why did you change this?
+8059,"@@ -69,6 +69,11 @@ func (s *store) initialize() {
+ 			continue
+ 		}
+ 
++		// Ignore in case appNodes with appID not existed in store.
++		if s.apps[appID] == nil {
++			continue
++		}
++
+ 		// Add the missing resource into the dependedResources of the app.
+ 		key := provider.MakeResourceKey(an.resource)
+ 		s.apps[appID].addDependedResource(uid, key, an.resource, now)",Because this is an unexpected situation so can you add a log here to help us figure out what resource is causing this problem?,Why do we need this check?
+8060,"@@ -554,12 +554,11 @@ public class OverseerCollectionMessageHandler implements OverseerMessageHandler,
+     final String collectionName = message.getStr(ZkStateReader.COLLECTION_PROP);
+     //the rest of the processing is based on writing cluster state properties
+     //remove the property here to avoid any errors down the pipeline due to this property appearing
+-    String configName = (String) message.getProperties().remove(CollectionAdminParams.COLL_CONF);
++    String configName = (String) message.getProperties().get(CollectionAdminParams.COLL_CONF);
+ 
+     if(configName != null) {
+       validateConfigOrThrowSolrException(configName);
+ 
+-      createConfNode(cloudManager.getDistribStateManager(), configName, collectionName);
+       reloadCollection(null, new ZkNodeProps(NAME, collectionName), results);
+     }
+ ",just observing that this innocent looking change seems important to this PR. Previously this data had disappeared from the state.,Why is this removed?
+8061,"@@ -1442,7 +1442,8 @@ short ExExeUtilHBaseBulkLoadTcb::work()
+            ComCondition *cond;
+            Lng32 entryNumber;
+            while ((cond = diagsArea->findCondition(EXE_ERROR_ROWS_FOUND, &entryNumber)) != NULL) {
+-              errorRowCount = cond->getOptionalInteger(0);
++              if (errorRowCount < cond->getOptionalInteger(0))
++                 errorRowCount = cond->getOptionalInteger(0);
+               diagsArea->deleteWarning(entryNumber);
+            }
+            diagsArea->setRowCount(0);","Actually, I do have one question: You mention that each warning is for a different range. Should we add the rowcounts instead of using the max?",Shouldn't this be `<
+8062,"@@ -31,6 +31,7 @@ type Protocol interface {
+ 	ReadState(context.Context, StateReader, []byte, ...[]byte) ([]byte, error)
+ 	Register(*Registry) error
+ 	ForceRegister(*Registry) error
++	Name() string
+ }
+ 
+ // GenesisStateCreator creates some genesis states",it is confusing to return ID as Name,Why do we need this?
+8063,"@@ -380,8 +380,15 @@ class RemoteConnection(object):
+             # Authorization header
+             headers[""Authorization""] = ""Basic %s"" % auth
+ 
+-        self._conn.request(method, parsed_url.path, data, headers)
+-        resp = self._conn.getresponse()
++        if body and method != 'POST' and method != 'PUT':
++            body = None
++        try:
++          self._conn.request(method, parsed_url.path, body, headers)
++          resp = self._conn.getresponse()
++        except httplib.HTTPException:
++          self._conn.close()
++          raise
++
+         statuscode = resp.status
+         statusmessage = resp.msg
+         LOGGER.debug('%s %s' % (statuscode, statusmessage))",body is being used here for the first time without every being populated. This will error. To run tests do `./go clean test_py` and that will run the Firefox tests,Why do we need to cl
+8064,"@@ -48,7 +48,7 @@ class Bootstrap
+         }
+ 
+         $kernel = new AppKernel($this->environment, Environment::isEnvironmentDebug($this->environment));
+-        $kernel->loadClassCache();
++        Request::setTrustedProxies(['127.0.0.1'], Request::HEADER_X_FORWARDED_ALL);
+         if ($this->console) {
+             $input = new ArgvInput();
+             $output = new ConsoleOutput();","commit mesasge: I would append ""...Kernel::loadClassCache() method call""",Why is this change needed?
+8065,"@@ -76,8 +76,9 @@ public class Actions {
+    * Note that the modifier key is <b>never</b> released implicitly - either
+    * <i>keyUp(theKey)</i> or <i>sendKeys(Keys.NULL)</i>
+    * must be called to release the modifier.
+-   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT} or {@link Keys#CONTROL}. If the
+-   * provided key is none of those, {@link IllegalArgumentException} is thrown.
++   * @param theKey Either {@link Keys#SHIFT}, {@link Keys#ALT}, {@link Keys#CONTROL}
++   * or {@link Keys#COMMAND}. If the provided key is none of those, 
++   * {@link IllegalArgumentException} is thrown.
+    * @return A self reference.
+    */
+   public Actions keyDown(Keys theKey) {",Keys.COMMAND seems to be an alias to Keys.META. That isn't mentioned?,I don't think you need to 
+8066,"@@ -2,7 +2,7 @@ package azkaban.test.utils;
+ 
+ import java.io.File;
+ 
+-import junit.framework.Assert;
++import org.junit.Assert;
+ 
+ import org.apache.log4j.Logger;
+ import org.junit.Test;",You can move this import down to before line 8 (import org.junit.Test;).,Why this change?
+8067,"@@ -52,7 +52,7 @@ class Findingsnotifier(object):
+                     'resource_type': violation.get('resource_type'),
+                     'resource_id': violation.get('resource_id'),
+                     'rule_index': violation.get('rule_index'),
+-                    'inventory_index_id': violation.get('inventory_index_id'),
++                    'scanner_index_id': violation.get('scanner_index_id'),
+                     'resource_data': violation.get('resource_data')
+                 }
+             }","It's okay to add the `scanner_index_id` here. But we still should keep the `inventory_index_id` reference because it will help the user to know right away, which inventory the violation is coming from, without having to do another lookup.",I think this should be `in
+8068,"@@ -349,7 +349,9 @@ public class EventFiringWebDriver implements WebDriver, JavascriptExecutor, Take
+     }
+ 
+     public void submit() {
++      dispatcher.beforeClickOn(element, driver);
+       element.submit();
++      dispatcher.afterClickOn(element, driver);
+     }
+ 
+     public void sendKeys(CharSequence... keysToSend) {","this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener. Since submit does not synthesize the 'click' events, this isn't accurate.",Why is this needed?
+8069,"@@ -1,5 +1,7 @@
+ <h2>
+-  Single
++  <% unless current_user_has_active_subscription? %>
++    Single
++  <% end %>
+   <% if pricing_scheme == ""primary"" %>
+     <%= render 'price', product: product,
+       price: product.individual_price,",Should this be I18n'd?,I don't think we ne
+8070,"@@ -93,7 +93,7 @@ public class CheckCompatibility extends TypeUtil.CustomOrderSchemaVisitor<List<S
+   }
+ 
+   @Override
+-  public List<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) {
++  public ImmutableList<String> struct(Types.StructType readStruct, Iterable<List<String>> fieldErrorLists) {
+     Preconditions.checkNotNull(readStruct, ""Evaluation must start with a schema."");
+ 
+     if (!currentType.isStructType()) {","We don't typically use `ImmutableList` to avoid leaking it in methods that are accidentally public or purposely part of the API. I'm +1 for returning `ImmutableList.copyOf(errors)` below, but I don't think we should guarantee the list will be an `ImmutableList`.",Why this change?
+8071,"@@ -441,10 +441,18 @@ class TestCase(unittest.TestCase):
+     m = Chem.MolFromSmiles('C1=CN=CC=C1')
+     pkl = cPickle.dumps(m)
+     m2 = cPickle.loads(pkl)
++    self.assertTrue(type(m2) == Chem.Mol)
+     smi1 = Chem.MolToSmiles(m)
+     smi2 = Chem.MolToSmiles(m2)
+     self.assertTrue(smi1 == smi2)
+ 
++    pkl = cPickle.dumps(Chem.RWMol(m))
++    m2 = cPickle.loads(pkl)
++    self.assertTrue(type(m2) == Chem.RWMol)
++    smi1 = Chem.MolToSmiles(m)
++    smi2 = Chem.MolToSmiles(m2)
++    self.assertTrue(smi1 == smi2)
++    
+   def test16Props(self):
+     m = Chem.MolFromSmiles('C1=CN=CC=C1')
+     self.assertTrue(not m.HasProp('prop1'))",@greglandrum Is this test sufficient?,Why is this test ne
+8072,"@@ -1,2 +1 @@
+-GITHUB_USER = ENV['GITHUB_USER']
+-GITHUB_PASSWORD = ENV['GITHUB_PASSWORD']
++GITHUB_ACCESS_TOKEN = ENV['GITHUB_ACCESS_TOKEN']",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [81/80]
+8073,"@@ -0,0 +1,5 @@
++class MakePlansPolymorphic < ActiveRecord::Migration
++  def change
++    add_column :subscriptions, :plan_type, :string, null: false
++  end
++end",I think Rails complains about the `null: false` part if we ever decide to roll this migration back. Might need to split this up into separate `up/down` methods to handle that.,I don't think we need a s
+8074,"@@ -618,8 +618,8 @@ func (mtask *managedTask) progressContainers() {
+ 	// We've kicked off one or more transitions, wait for them to
+ 	// complete, but keep reading events as we do. in fact, we have to for
+ 	// transitions to complete
+-	mtask.waitForContainerTransitions(transitions, transitionChange, transitionChangeContainer)
+-	seelog.Debugf(""Managed task [%s]: done transitioning all containers"", mtask.Arn)
++	mtask.waitForContainerTransition(transitions, transitionChange, transitionChangeContainer)
++	seelog.Debugf(""Managed task [%s]: wait for container transition done"", mtask.Arn)
+ 
+ 	// update the task status
+ 	changed := mtask.UpdateStatus()",I don't think we need this line. You're logging in `waitForContainerTransition()` anyway,I don't think we need to 
+8075,"@@ -13,7 +13,7 @@
+ 
+ return [
+     'accepted'             => ':attribute ला स्वीकार केला गेला पाहिजे.',
+-    'accepted_if'          => 'The :attribute must be accepted when :other is :value.',
++    'accepted_if'          => ':other हे :value असेल तेव्हा हे फील्ड स्वीकारणे आवश्यक आहे.',
+     'active_url'           => ':attribute हा एक बरोबर URL नाही आहे.',
+     'after'                => ':attribute, :date नंतरची एक तारीख पाहिजे.',
+     'after_or_equal'       => ':attribute, :date हि किंवा त्या नंतरची एक तारीख पाहिजे.',",Shouldn't the `:attribute` placeholder appear?,Line is too long. [83/80]
+8076,"@@ -78,8 +78,8 @@ public class ResidualEvaluator implements Serializable {
+   private class ResidualVisitor extends ExpressionVisitors.BoundExpressionVisitor<Expression> {
+     private StructLike struct;
+ 
+-    private Expression eval(StructLike struct) {
+-      this.struct = struct;
++    private Expression eval(StructLike arg) {
++      this.struct = arg;
+       return ExpressionVisitors.visit(expr, this);
+     }
+ ",Could you update this to `structLike` instead of `arg`?,Why did you change this?
+8077,"@@ -0,0 +1,14 @@
++// +build darwin linux,!baremetal freebsd,!baremetal
++
++// +build gc.conservative gc.leaking
++
++package runtime
++
++const heapSize = 1 * 1024 * 1024 // 1MB to start
++
++var heapStart, heapEnd uintptr
++
++func preinit() {
++	heapStart = uintptr(malloc(heapSize))
++	heapEnd = heapStart + heapSize
++}","I only now spot this `freebsd,!baremetal` in the code, which doesn't make a lot of sense. The fact that there is `linux,!baremetal` is because baremetal targets pretend to be linux/arm to get the standard library to compile. Such a `!baremetal` exclusion is not necessary for FreeBSD. But this is not something that needs fixing in this PR.",Why do we need this?
+8078,"@@ -455,7 +455,7 @@ get_unpacked_unlinked_content (OstreeRepo       *repo,
+                                GError          **error)
+ {
+   gboolean ret = FALSE;
+-  g_autofree char *tmpname = g_strdup (""tmpostree-deltaobj-XXXXXX"");
++  g_autofree char *tmpname = g_strdup (""/var/tmp/tmpostree-deltaobj-XXXXXX"");
+   glnx_fd_close int fd = -1;
+   g_autoptr(GBytes) ret_content = NULL;
+   g_autoptr(GInputStream) istream = NULL;","Ugh, we were using cwd? =(",I think this should be `
+8079,"@@ -21,7 +21,6 @@ struct screencopy_damage {
+ 	struct pixman_region32 damage;
+ 	struct wl_listener output_precommit;
+ 	struct wl_listener output_destroy;
+-	uint32_t last_commit_seq;
+ };
+ 
+ static const struct zwlr_screencopy_frame_v1_interface frame_impl;",This can probably be removed?,Why was this removed?
+8080,"@@ -89,8 +89,9 @@ void FetchExecutor::setupResponse(cpp2::ExecutionResponse &resp) {
+ }
+ 
+ void FetchExecutor::onEmptyInputs() {
++    auto outputs = std::make_unique<InterimResult>(std::move(resultColNames_));
+     if (onResult_) {
+-        onResult_(nullptr);
++        onResult_(std::move(outputs));
+     } else if (resp_ == nullptr) {
+         resp_ = std::make_unique<cpp2::ExecutionResponse>();
+     }",put this sentence in `if (onResult_) { }`,nit: `outputs` -> `intermediateResult`
+8081,"@@ -235,11 +235,16 @@ echo ""echo '{export_forseti_vars}' >> /etc/profile.d/forseti_environment.sh"" | s
+ gsutil cp gs://{scanner_bucket}/configs/forseti_conf_server.yaml {forseti_server_conf}
+ gsutil cp -r gs://{scanner_bucket}/rules {forseti_home}/
+ 
++# Download the Newest Config Validator constraints from GCS
++rm -rf /home/ubuntu/config_validator_constraints
++gsutil cp -r gs://{scanner_bucket}/config_validator_constraints /home/ubuntu/
++
+ # Start Forseti service depends on vars defined above.
+ bash ./install/gcp/scripts/initialize_forseti_services.sh
+ 
+ echo ""Starting services.""
+ systemctl start cloudsqlproxy
++systemctl start config-validator
+ sleep 5
+ 
+ echo ""Attempting to update database schema, if necessary.""",Will this always be started up as default? Is there any impact to the VM in terms of load and memory usage?,Why do we need to do this?
+8082,"@@ -374,7 +374,7 @@ class CommandLine
+         /// parsable types (values are comma separated without space).
+         ///
+         /// Qualifiers that are defined BEFORE any parameter sets apply to ALL parameter sets.  qualifiers that
+-        /// are defined AFTER a parameter set will apply only the the parameter set that preceeds them.
++        /// are defined AFTER a parameter set will apply only the the parameter set that precedes them.
+         ///
+         /// See code:#DefiningParametersAndQualifiers
+         /// See code:#Overview",Thanks for fixing the typo's but given that this is a fork of the other commandline.cs file they will still exist there :( Part of the reason forks suck.,I don't think this change is correct.
+8083,"@@ -141,8 +141,14 @@ import datetime
+ import itertools
+ import logging
+ import luigi
+-import sqlalchemy
+ import os
++import warnings
++
++try:
++    import sqlalchemy
++except ImportError:
++    # Don't fail on import because we want the documentation to be generated
++    warnings.warn(""sqlalchemy could not be imported, db_task_history will not work"", warnings.ImportWarning, stacklevel=3)
+ 
+ 
+ class SQLAlchemyTarget(luigi.Target):",This doesn't seem related to docs? :),I don't think this is the right place 
+8084,"@@ -233,7 +233,7 @@ public class K9 extends Application {
+     private static boolean hideSpecialAccounts = false;
+     private static boolean autofitWidth;
+     private static boolean quietTimeEnabled = false;
+-    private static boolean notificationDuringQuietTimeEnabled = true;
++    private static boolean notificationDuringQuietTimeDisabled = true;
+     private static String quietTimeStarts = null;
+     private static String quietTimeEnds = null;
+     private static String attachmentDefaultPath = """";","Having a negative in the variable/method name makes the code harder to read. Also, you inverted the logic but didn't invert the default value. I suggest sticking to the original name.",Why did you change the default value?
+8085,"@@ -66,8 +66,8 @@ namespace NLog.Targets
+         /// Always use <see cref=""Trace.WriteLine(string)""/> independent of <see cref=""LogLevel""/>
+         /// </summary>
+         /// <docgen category='Output Options' order='100' />
+-        [DefaultValue(false)]
+-        public bool RawWrite { get; set; }
++        [DefaultValue(true)]
++        public bool ForceTraceWriteLine { get; set; } = true;
+ 
+         /// <summary>
+         /// Forward <see cref=""LogLevel.Fatal"" /> to <see cref=""Trace.Fail(string)"" /> (Instead of <see cref=""Trace.TraceError(string)"" />)",Think you need to keep `RawWrite` around as obsolete until NLog6 (Property that just assigns `ForceTraceWriteLine`),This is a breaking change. We need to
+8086,"@@ -45,6 +45,9 @@ proc_init_arch(void)
+     num_simd_registers = MCXT_NUM_SIMD_SLOTS;
+     num_opmask_registers = MCXT_NUM_OPMASK_SLOTS;
+ 
++    set_cache_line_size_using_ctr_el0(/* dcache_line_size= */ &cache_line_size,
++                                      /* icache_line_size= */ NULL);
++
+     /* FIXME i#1569: NYI */
+ }
+ ",I would expect this to be named *get* not *set*: it's a query; it's not setting some persistent state.,This should be `set_cache_line_size_u
+8087,"@@ -2,7 +2,7 @@ import os
+ from typing import Dict, List
+ 
+ from dagster import SensorDefinition
+-from dagster.core.definitions.pipeline_sensor import PipelineFailureSensorContext
++from dagster.core.definitions.pipeline_definition_sensor import PipelineFailureSensorContext
+ from dagster_slack import make_slack_on_pipeline_failure_sensor
+ from hacker_news_assets.utils.slack_message import build_slack_message_blocks
+ ",maybe should rename this to be `run_status_sensor_definition.py`,Why did you rename this file?
+8088,"@@ -0,0 +1,19 @@
++/*
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *     http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++
++package org.apache.iceberg.spark;
++
++public class SparkWriteOptions {
++    public static final String FANOUT_ENABLED = ""fanout-enabled"";
++}",Do we want to add the other write options in this PR or keep the refactor separate?,Why do we need this class?
+8089,"@@ -68,7 +68,17 @@ def refresh_user_token(spotify_user):
+         user (domain.spotify.Spotify): the same user with updated tokens
+     """"""
+     auth = get_spotify_oauth()
+-    new_token = auth.refresh_access_token(spotify_user.refresh_token)
++
++    retries = 5
++    new_token = None
++    while retries > 0:
++        new_token = auth.refresh_access_token(spotify_user.refresh_token)
++        if new_token is not None:
++            break
++        retries -= 1
++    if new_token is None:
++        raise SpotifyAPIError('Could not refresh API Token for Spotify user')
++
+     access_token = new_token['access_token']
+     refresh_token = new_token['refresh_token']
+     expires_at = new_token['expires_at']",either make this a config or a constant we can define at the top. Burying this in the code is no good.,I think this should be `if
+8090,"@@ -73,6 +73,13 @@ def multi_error(y_true, y_pred):
+ def multi_logloss(y_true, y_pred):
+     return np.mean([-math.log(y_pred[i][y]) for i, y in enumerate(y_true)])
+ 
++def custom_recall(y_true, y_pred):
++    return 'custom_recall', recall_score(y_true, y_pred > 0.5), True
++
++
++def custom_precision(y_true, y_pred):
++    return 'custom_precision', precision_score(y_true, y_pred > 0.5), True
++
+ 
+ class TestSklearn(unittest.TestCase):
+ ",Same about new metrics. Can we avoid adding them?,I don't think we need this
+8091,"@@ -40,6 +40,15 @@ def run():
+     group.add_argument('--cloudsql-region',
+                        help='The Cloud SQL region')
+ 
++    network = parser.add_argument_group(title='network')
++    network.add_argument('--network-host-project-id',
++                         help='The project id that is hosting the network '
++                              'resources.')
++    network.add_argument('--vpc-name',
++                         help='The VPC name where Forseti VM will run.')
++    network.add_argument('--subnet-name',
++                         help='The subnetwork name where Forseti VM will run.')
++
+     email_params = parser.add_argument_group(title='email')
+     email_params.add_argument('--sendgrid-api-key',
+                               help='Sendgrid API key')","I know this is a port from the previous PR, but I am wondering if we can take the chance to improve the naming? `--vpc-host-project-id` ?",I think this should be `--
+8092,"@@ -228,7 +228,7 @@ describe('Formulas general', () => {
+       afterChange,
+     });
+ 
+-    hot.getSourceData()[1][1] = 20;
++    hot.setSourceDataAtCell(1, 1, 20);
+     hot.getPlugin('formulas').recalculateFull();
+     hot.render();
+ ","The test description says it's ""by reference"". We should change the description",I think this should be `setSourceDataAtCell`
+8093,"@@ -16,9 +16,15 @@ namespace AutoRest.Core.Validation
+         {
+         }
+ 
++        /// <summary>
++        /// Id of the Rule.
++        /// </summary>
+         public virtual string Id => ""!!! implement me and make me abstract !!!"";
+ 
+-        public ValidationCategory ValidationCategory => ((ValidationCategory)0); // !!! implement me and make me abstract !!!
++        /// <summary>
++        /// Violation category of the Rule.
++        /// </summary>
++        public virtual ValidationCategory ValidationCategory => ((ValidationCategory)0); // !!! implement me and make me abstract !!!
+ 
+         /// <summary>
+         /// The template message for this Rule. ",A C# newbie question here: would it make sense to declare Id as an abstract property so any subclass Must have its own Id?,>violation category of the Rule [](start = 1
+8094,"@@ -47,6 +47,11 @@ func (r *Repository) Proposals(filter *proposal.Filter) ([]market.ServiceProposa
+ 	return []market.ServiceProposal{}, nil
+ }
+ 
++// Countries returns proposals per country matching the filter.
++func (r *Repository) Countries(filter *proposal.Filter) (map[string]int, error) {
++	return nil, nil
++}
++
+ // Start begins proposals synchronization to storage.
+ func (r *Repository) Start() error {
+ 	return nil",just looks like you should return an **empty map** with nil error,Why do we need this method?
+8095,"@@ -103,11 +103,18 @@ func main() {
+ 	reloadURL := app.Flag(""reload-url"", ""reload URL to trigger Prometheus reload on"").
+ 		Default(""http://127.0.0.1:9090/-/reload"").URL()
+ 
++	version.RegisterIntoKingpinFlags(app)
++
+ 	if _, err := app.Parse(os.Args[1:]); err != nil {
+ 		fmt.Fprintln(os.Stderr, err)
+ 		os.Exit(2)
+ 	}
+ 
++	if version.ShouldPrintVersion() {
++		version.Print(os.Stdout, ""prometheus-config-reloader"")
++		os.Exit(0)
++	}
++
+ 	logger := log.NewLogfmtLogger(log.NewSyncWriter(os.Stdout))
+ 
+ 	if *logFormat == logFormatJson {",could you also update the starting log at L146?,Why do we need this?
+8096,"@@ -312,6 +312,16 @@ func isUnitExists(err error) bool {
+ 	return false
+ }
+ 
++// isDbusClosed returns true if the error is that connection closed.
++func isDbusClosed(err error) bool {
++	if err != nil {
++		if dbusError, ok := err.(dbus.Error); ok {
++			return strings.Contains(dbusError.Name, ""connection closed by user"")
++		}
++	}
++	return false
++}
++
+ func startUnit(dbusConnection *systemdDbus.Conn, unitName string, properties []systemdDbus.Property) error {
+ 	statusChan := make(chan string, 1)
+ 	if _, err := dbusConnection.StartTransientUnit(unitName, ""replace"", properties, statusChan); err == nil {",Also this probably should be `error.As()` or something like it.,"I think this should be `strings.Contains(err.Error(), ""connection closed by user"")`"
+8097,"@@ -219,7 +219,9 @@ webdriver.CommandName = {
+   GET_SESSION_LOGS: 'getSessionLogs',
+ 
+   // Non-standard commands used by the standalone Selenium server.
+-  UPLOAD_FILE: 'uploadFile'
++  UPLOAD_FILE: 'uploadFile', 
++
++  GET_CANVAS_URL: 'getCanvasUrl'
+ };
+ 
+ ",This is Safari specific and should be defined somewhere in the `safaridriver` namespace,I think this should be `getCanvasUrl`
+8098,"@@ -49,6 +49,13 @@ main(int argc, char *argv[])
+       exit (EXIT_SUCCESS);
+   }
+ 
++  /* We conflict with the magic ostree-mount-deployment-var file for ostree-prepare-root */
++  { struct stat stbuf;
++    if (fstatat (AT_FDCWD, ""/run/ostree-mount-deployment-var"", &stbuf, 0) == 0)
++      exit (EXIT_SUCCESS);
++  }
++
++
+   if (argc > 1 && argc != 4)
+     errx (EXIT_FAILURE, ""This program takes three or no arguments"");
+ ","Let's maybe be nice and `unlinkat()` here in the interest of having `/run` be less littered. Or in addition/alternatively, make the file `/run/ostree/initramfs-mount-var` since we already made `/run/ostree/` for the deployment staging bits.",Shouldn't this be `/run/ostree-mount-deployment-var`?
+8099,"@@ -21,6 +21,7 @@
+ 
+ #include ""teleport.h""
+ #include ""game.h""
++#include <boost/format.hpp>
+ 
+ extern Game g_game;
+ ",Not sure if this doesn't require explicitly adding this library to cmake.,Why is this needed?
+8100,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+ 
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,`duraton` -> `duration`
+8101,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,nit: `of` -> `from`
+8102,"@@ -77,9 +77,10 @@ module Beaker
+     # @option opts [Beaker::Logger] :logger A {Beaker::Logger} object
+     def validate_host host, opts
+       logger = opts[:logger]
++      # Additional Packages to be determined at runtime
++      additional_pkgs = Array.new
+       if opts[:collect_perf_data]
+-        UNIX_PACKAGES << ""sysstat"" if !UNIX_PACKAGES.include? ""sysstat""
+-        SLES_PACKAGES << ""sysstat"" if !SLES_PACKAGES.include? ""sysstat""
++        additional_pkgs << ""sysstat"" if !additional_pkgs.include? ""sysstat""
+       end
+       block_on host do |host|
+         case",This `if` statement can be merged with the above `if opts[:collect_perf_data]`.,I think this should be 
+8103,"@@ -110,6 +110,8 @@ func (d Document) Get(fp []string) (interface{}, error) {
+ }
+ 
+ func (d Document) structField(name string) (reflect.Value, error) {
++	// We do case-insensitive match here to cover the MongoDB's lowercaseFields
++	// option.
+ 	f := d.fields.MatchFold(name)
+ 	if f == nil {
+ 		return reflect.Value{}, gcerr.Newf(gcerr.NotFound, nil, ""field %q not found in struct type %s"", name, d.s.Type())","But won't we do case-insensitive matching for all the drivers? For example, we will get the revision field case-insensitively. Let's make this case-sensitive. I think the way the mongo driver works, by lowercasing field names, will be OK with that.",I don't think this is t
+8104,"@@ -5,7 +5,10 @@
+ 
+ <div class=""text-box-wrapper"">
+   <div class=""text-box"">
+-    <h2><%= @product.tagline %></h2>
++    <hgroup class=""product-title"">
++      <h2><%= @product.tagline %></h2>
++      <h3 class=""workshop-type"">Online Workshop</h3>
++    </hgroup>
+ 
+     <%== @product.description %>
+   </div>","I believe this should be on `workshops/show` now, not `products/show`","This should be `<h3 class=""product-title"">Online Workshop</h3>`"
+8105,"@@ -16,6 +16,7 @@ func TestDetectorDetectCountry(t *testing.T) {
+ 		{""95.85.39.36"", ""NL"", """"},
+ 		{""127.0.0.1"", """", """"},
+ 		{""8.8.8.8.8"", """", ""failed to parse IP""},
++		{""185.243.112.225"", """", """"},
+ 		{""asd"", """", ""failed to parse IP""},
+ 	}
+ ","If we return error when we are unable to found country in database, using country detector would be much easier - if error was not returned, that means country was returned :) This doesn't have to be solved in this PR, but since you're adding such case, we can add a `TODO` just to track this :)",I don't think we need this.
+8106,"@@ -24,7 +24,12 @@ namespace Datadog.Trace.ClrProfiler.Managed.Loader
+             var corlib461Version = new Version(corlib461FileVersionString);
+             var tracerFrameworkDirectory = corlibVersion < corlib461Version ? ""net45"" : ""net461"";
+ 
+-            var tracerHomeDirectory = Environment.GetEnvironmentVariable(""DD_DOTNET_TRACER_HOME"") ?? string.Empty;
++            var tracerHomeDirectory = Environment.GetEnvironmentVariable(""DD_DOTNET_TRACER_HOME"");
++            if (string.IsNullOrWhiteSpace(tracerHomeDirectory))
++            {
++                tracerHomeDirectory = Path.GetDirectoryName(Environment.GetEnvironmentVariable(""DD_INTEGRATIONS"")) ?? string.Empty;
++            }
++
+             return Path.Combine(tracerHomeDirectory, tracerFrameworkDirectory);
+         }
+ ",.NET Framework: Fallback to `DD_INTEGRATIONS` if `DD_DOTNET_TRACER_HOME` was not set.,Why do we need this?
+8107,"@@ -111,7 +111,8 @@ def _read_request_line(line: bytes) -> Tuple[str, int, bytes, bytes, bytes, byte
+                 raise ValueError
+         else:
+             scheme, rest = target.split(b""://"", maxsplit=1)
+-            authority, path_ = rest.split(b""/"", maxsplit=1)
++            authority, *paths_ = rest.split(b""/"", maxsplit=1)
++            path_ = paths_[0] if paths_ else b""""
+             path = b""/"" + path_
+             host, port = url.parse_authority(authority, check=True)
+             port = port or url.default_port(scheme)","Can you use `authority, _, path = rest.partition(b""/"")` here? That should make stuff a bit cleaner.",I'm not sure if this is the right way to do this. I think it wo
+8108,"@@ -75,6 +75,10 @@ module RSpec::Core
+           options[:order] = ""rand:#{seed}""
+         end
+ 
++        parser.on('--stress-test LIMIT', Float, 'Repeatedly run randomly selected examples for LIMIT seconds.') do |o|
++          options[:stress_test] = o.to_f
++        end
++
+         parser.on('-d', '--debugger', 'Enable debugging.') do |o|
+           options[:debug] = true
+         end",I don't think this needs to be a float if its a number of seconds... :),This should be `options[:stress_test] = o.to_f`
+8109,"@@ -38,7 +38,7 @@ interface FieldProcessor
+     /**
+      * process method
+      *
+-     * @param array Array of values, an array because of multivalued fields
++     * @param array $values of values, an array because of multivalued fields
+      * @return array Modified array of values
+      */
+     public function process(array $values);","Please add ""Array"" back, right now it's not a proper sentence.",Why did you change this?
+8110,"@@ -509,7 +509,9 @@ public class QueryElevationComponent extends SearchComponent implements SolrCore
+       rb.setQuery(new BoostQuery(elevation.includeQuery, 0f));
+     } else {
+       BooleanQuery.Builder queryBuilder = new BooleanQuery.Builder();
+-      queryBuilder.add(rb.getQuery(), BooleanClause.Occur.SHOULD);
++      BooleanClause.Occur queryOccurrence = params.getBool(QueryElevationParams.ELEVATE_ONLY_DOCS_MATCHING_QUERY, false) ?
++              BooleanClause.Occur.SHOULD : BooleanClause.Occur.MUST;
++      queryBuilder.add(rb.getQuery(), queryOccurrence);
+       queryBuilder.add(new BoostQuery(elevation.includeQuery, 0f), BooleanClause.Occur.SHOULD);
+       if (elevation.excludeQueries != null) {
+         if (params.getBool(QueryElevationParams.MARK_EXCLUDES, false)) {",@tkaessmann when I ran tests I saw this line has a bug. It inverts the SHOULD and MUST. Hopefully I fixed it and merged it without the bug.,I think this should be `BooleanClause.Occur.MUS
+8111,"@@ -301,7 +301,7 @@ func initTelemetry(genesis bookkeeping.Genesis, log logging.Logger, dataDirector
+ 				}
+ 
+ 				// If the telemetry URI is not set, periodically check SRV records for new telemetry URI
+-				if log.GetTelemetryURI() == """" {
++				if telemetryConfig.Enable && log.GetTelemetryURI() == """" {
+ 					network.StartTelemetryURIUpdateService(time.Minute, cfg, genesis.Network, log, abort)
+ 				}
+ ","There may be another bug, it looks like we're already in a `if telemetryConfig.Enable` block at this point, maybe that block should be unnested?",Why do we need this?
+8112,"@@ -944,7 +944,9 @@ class Request(Message):
+ 
+     def _set_multipart_form(self, value):
+         self.content = multipart.encode(self.headers, value)
+-        self.headers[""content-type""] = ""multipart/form-data""
++        if ""content-type"" not in self.headers:
++            # Don't overwrite header if it already exists or it will destroy the boundary value
++            self.headers[""content-type""] = ""multipart/form-data""
+ 
+     @property
+     def multipart_form(self) -> multidict.MultiDictView[bytes, bytes]:","This... looks like it plainly didn't work before? Good catch. I would suggest we change the logic here to 1. Check if `self.headers[""content_type""].startswith(""multipart/form-data"")`, and if that's not the case, add a content-type header with a random (?) boundary. The point here is that if someone assigns to `.multipart_form = ` in their addon, the header should be updated accordingly if the request was not multipart before. 2. *After* that, call `self.content = multipart.encode(self.headers, value)` (as we do right now)","I don't think this is the right place to do this. If the content-type already exists, it will overwrite it."
+8113,"@@ -86,9 +86,14 @@ func TestSignBlock(t *testing.T) {
+ 
+ func TestWrongNonce(t *testing.T) {
+ 	cfg := config.Default
++
++	require := require.New(t)
++	registry := protocol.Registry{}
++	require.NoError(registry.Register(account.ProtocolID, account.NewProtocol()))
++
+ 	ctx := protocol.WithValidateActionsCtx(
+ 		context.Background(),
+-		protocol.ValidateActionsCtx{Genesis: cfg.Genesis},
++		protocol.ValidateActionsCtx{Genesis: cfg.Genesis, Registry: &registry},
+ 	)
+ 	testTrieFile, _ := ioutil.TempFile(os.TempDir(), ""trie"")
+ 	testTriePath := testTrieFile.Name()",importShadow: shadow of imported from 'github.com/stretchr/testify/require' package 'require' (from `gocritic`),ineffectual assignment to `ctx` (from `ineffassign`)
+8114,"@@ -1963,9 +1963,8 @@ get_ibl_routine_type_ex(dcontext_t *dcontext, cache_pc target, ibl_type_t *type
+ 
+     /* a decent compiler should inline these nested loops */
+     /* iterate in order <linked, unlinked> */
+-    for (link_state = IBL_LINKED;
+-         /* keep in mind we need a signed comparison when going downwards */
+-         (int)link_state >= (int)IBL_UNLINKED; link_state-- ) {
++    link_state = IBL_LINKED;
++    while (true) {
+         /* it is OK to compare to IBL_BB_PRIVATE even when !SHARED_FRAGMENTS_ENABLED() */
+         for (source_fragment_type = IBL_SOURCE_TYPE_START;
+              source_fragment_type < IBL_SOURCE_TYPE_END;",Wouldn't it be enough to change the condition in the for loop to `link_state != IBL_UNLINKED`?,Why is this needed?
+8115,"@@ -31,7 +31,10 @@
+ 
+ #include <glib/gi18n.h>
+ 
++static gboolean opt_verify;
++
+ static GOptionEntry options[] = {
++  { ""verify"", 'V', 0, G_OPTION_ARG_NONE, &opt_verify, ""Print the commit verification status"", NULL },
+   { NULL }
+ };
+ ","I'm not familiar with signed setups, but this does not seem to offer a way to choose between GPG and signapi verification. Are they usually either both enabled or both disabled? Would this be better suited as a verb with flags for different methods?",I don't think this is needed.
+8116,"@@ -951,7 +951,7 @@ func (dao *blockDAO) getBlockValue(blockNS string, h hash.Hash256) ([]byte, erro
+ 		if err != nil {
+ 			return nil, err
+ 		}
+-		value, err = db.Get(blockNS, h[:])
++		value, _ = db.Get(blockNS, h[:])
+ 	}
+ 	return value, err
+ }",assignments should only be cuddled with other assignments (from `wsl`),I don't think we should ignore the error here.
+8117,"@@ -11,6 +11,7 @@ C2::Application.routes.draw do
+   post ""/feedback"" => ""feedback#create""
+ 
+   match ""/auth/:provider/callback"" => ""auth#oauth_callback"", via: [:get]
++  get ""/auth/failure"" => ""auth#failure""
+   post ""/logout"" => ""auth#logout""
+ 
+   resources :help, only: [:index, :show]",would it make sense to mock oauth in a way that we direct a user to this endpoint on login (in a test)?,"get ""/auth/:provider/callback"" => ""auth#oauth_"
+8118,"@@ -5,13 +5,14 @@ define([""events"", ""globalize"", ""dom"", ""datetime"", ""userSettings"", ""serverNotific
+         var html = """";
+         html += '<div class=""listItem listItem-border"">';
+         var color = ""Error"" == entry.Severity || ""Fatal"" == entry.Severity || ""Warn"" == entry.Severity ? ""#cc0000"" : ""#00a4dc"";
++        var icon = ""Error"" == entry.Severity || ""Fatal"" == entry.Severity || ""Warn"" == entry.Severity ? ""notification_important"" : ""notifications"";
+         if (entry.UserId && entry.UserPrimaryImageTag) {
+             html += '<i class=""listItemIcon md-icon"" style=""width:2em!important;height:2em!important;padding:0;color:transparent;background-color:' + color + "";background-image:url('"" + apiClient.getUserImageUrl(entry.UserId, {
+                 type: ""Primary"",
+                 tag: entry.UserPrimaryImageTag,
+                 height: 40
+             }) + ""');background-repeat:no-repeat;background-position:center center;background-size: cover;\"">dvr</i>""
+-        } else html += '<i class=""listItemIcon md-icon"" style=""background-color:' + color + '"">dvr</i>';
++        } else html += '<i class=""listItemIcon md-icon"" style=""background-color:' + color + '"">' + icon + '</i>';
+         html += '<div class=""listItemBody three-line"">', html += '<div class=""listItemBodyText"">', html += entry.Name, html += ""</div>"", html += '<div class=""listItemBodyText secondary"">';
+         var date = datetime.parseISO8601Date(entry.Date, !0);
+         return html += datetime.toLocaleString(date).toLowerCase(), html += ""</div>"", html += '<div class=""listItemBodyText secondary listItemBodyText-nowrap"">', html += entry.ShortOverview || """", html += ""</div>"", html += ""</div>"", entry.Overview && (html += '<button type=""button"" is=""paper-icon-button-light"" class=""btnEntryInfo"" data-id=""' + entry.Id + '"" title=""' + globalize.translate(""Info"") + '""><i class=""md-icon"">info</i></button>'), html += ""</div>""","Since these two lines use the same logic, it may be cleaner to use an `if` statement rather than duplicating it.",I don't think we need this change.
+8119,"@@ -3,7 +3,6 @@
+ namespace Shopsys\ShopBundle\Controller\Front;
+ 
+ use Exception;
+-use Shopsys\FrameworkBundle\Component\Controller\FrontBaseController;
+ use Shopsys\FrameworkBundle\Component\Domain\Domain;
+ use Shopsys\FrameworkBundle\Component\Error\ErrorPagesFacade;
+ use Shopsys\FrameworkBundle\Component\Error\ExceptionController;",unnecessary blank line,Why did you remove this?
+8120,"@@ -38,6 +38,12 @@ public class MetadataColumns {
+       Integer.MAX_VALUE - 2, ""_pos"", Types.LongType.get(), ""Ordinal position of a row in the source data file"");
+   public static final NestedField IS_DELETED = NestedField.required(
+       Integer.MAX_VALUE - 3, ""_deleted"", Types.BooleanType.get(), ""Whether the row has been deleted"");
++  public static final NestedField SPEC_ID = NestedField.required(
++      Integer.MAX_VALUE - 4, ""_spec_id"", Types.IntegerType.get(), ""Spec ID to which a row belongs to"");
++  // the partition column type is not static and depends on all specs in the table
++  public static final int PARTITION_COLUMN_ID = Integer.MAX_VALUE - 5;
++  public static final String PARTITION_COLUMN_NAME = ""_partition"";
++  public static final String PARTITION_COLUMN_DOC = ""Partition to which a row belongs to"";
+ 
+   // IDs Integer.MAX_VALUE - (101-200) are used for reserved columns
+   public static final NestedField DELETE_FILE_PATH = NestedField.required(","Nit: no need for ""to"" at the end of the doc because it already uses ""to which"".",I think this should be `Integer.MAX_VALUE - 6`
+8121,"@@ -0,0 +1,6 @@
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT License. See License.txt in the project root for license information.
++
++[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA1021:AvoidOutParameters"", MessageId = ""2#"", Scope = ""member"", Target = ""Microsoft.Rest.TransientFaultHandling.ShouldRetryHandler.#Invoke(System.Int32,System.Exception,System.TimeSpan&)"")]
++[assembly: System.Diagnostics.CodeAnalysis.SuppressMessage(""Microsoft.Design"", ""CA2210:AssembliesShouldHaveValidStrongNames"", Justification=""We do give it strong name and sign it when build in CI server and verify it"")]
++","I would just say ""Signed before publishing.""",Why is this suppression needed?
+8122,"@@ -21,13 +21,14 @@
+ 
+ #include <gtest/gtest.h>
+ 
+-#include <fastrtps/transport/UDPv4Transport.h>
+-#include ""../cpp/rtps/transport/shared_mem/test_SharedMemTransportDescriptor.h""
++#include <rtps/transport/shared_mem/test_SharedMemTransportDescriptor.h>
++#include <rtps/transport/UDPv4Transport.h>
+ 
+ using namespace eprosima::fastrtps;
+ 
+ using SharedMemTransportDescriptor = eprosima::fastdds::rtps::SharedMemTransportDescriptor;
+ using test_SharedMemTransportDescriptor = eprosima::fastdds::rtps::test_SharedMemTransportDescriptor;
++using UDPv4Transport = eprosima::fastdds::rtps::UDPv4Transport;
+ 
+ TEST(SHM, TransportPubSub)
+ {",We can just include the public UDPv4TransportDescriptor header here ...,Why this change?
+8123,"@@ -196,6 +196,9 @@ class BlazeMeterUploader(Reporter, AggregatorListener, MonitoringListener, Singl
+             self._session = Session(self._user, {'id': sess_id})
+             self._session['userId'] = self.parameters.get(""user-id"", None)
+             self._session['testId'] = self.parameters.get(""test-id"", None)
++            data_address = self.settings.get(""data-address"", None)
++            if data_address:
++                self._session['data-address'] = data_address
+             self._test = Test(self._user, {'id': self._session['testId']})
+             exc = TaurusConfigError(""Need signature for session"")
+             self._session.data_signature = self.parameters.get(""signature"", exc)",Why do we need this change?,This should be `if data_address:`.
+8124,"@@ -172,11 +172,15 @@ func (t *Tag) Done(s State) bool {
+ 	return err == nil && n == total
+ }
+ 
+-// DoneSplit sets total count to SPLIT count and sets the associated swarm hash for this tag
+-// is meant to be called when splitter finishes for input streams of unknown size
++// DoneSplit adds the total with the split count and updated the total.
++// This is useful when you use the same tag for a file and its manifest upload
++// Also the Address is updated with the last called address, so the assumption
++// is that the manifest creation will be called last and this will have the root
++// hash of the manifest
+ func (t *Tag) DoneSplit(address swarm.Address) int64 {
+-	total := atomic.LoadInt64(&t.Split)
+-	atomic.StoreInt64(&t.Total, total)
++	split := atomic.LoadInt64(&t.Split)
++	total := atomic.LoadInt64(&t.Total)
++	atomic.StoreInt64(&t.Total, total+split)
+ 	t.Address = address
+ 	return total
+ }","These three atomic functions done separately are not atomic. There is a possibility of data race, as nothing is guarding Total in between lines 182 and 183. Total got on line 182 may be changed before new value is stored on line 183 by some other goroutine resulting an incorrect value. Mutex should be used.","I don't think this is correct. If you use the same tag for a file and its manifest upload, it will be called last and this will have the root hash of the manifest."
+8125,"@@ -392,7 +392,7 @@ namespace Nethermind.BeaconNode.Tests.EpochProcessing
+             foreach (var checkpoint in checkpoints)
+             {
+                 var startSlot = beaconChainUtility.ComputeStartSlotOfEpoch(checkpoint.Epoch);
+-                var slotIndex = startSlot % timeParameters.SlotsPerHistoricalRoot;
++                Slot slotIndex = (Slot)(startSlot % timeParameters.SlotsPerHistoricalRoot);
+                 state.SetBlockRoot(slotIndex, checkpoint.Root);
+             }
+         }",Is this because you don't have % on your version of Slot? I don't really care either way.,`Slot slotIndex = startSlot % timeParameters.SlotsPerHistoricalRoot;`
+8126,"@@ -212,9 +212,14 @@
+           return {
+             pre: function ($scope, $elm, $attrs, uiGridCtrl) {
+               if ( uiGridCtrl.grid.options.enableExpandableRowHeader !== false ) {
+-                var expandableRowHeaderColDef = {name: 'expandableButtons', displayName: '', enableColumnResizing: false, width: 40};
+-                expandableRowHeaderColDef.cellTemplate = $templateCache.get('ui-grid/expandableRowHeader');
+-                uiGridCtrl.grid.addRowHeaderColumn(expandableRowHeaderColDef);
++                var defaultExpandableRowHeaderColDef = {
++                    name: 'expandableButtons',
++                    width: 40,
++                    cellTemplate: $templateCache.get('ui-grid/expandableRowHeader')
++                  },
++                  userInjectedExpandableRowHeaderColDef = $scope.gridOptions.expandableRowHeaderColDef || {},
++                  finalExpandableRowHeaderColDef = angular.extend({}, defaultExpandableRowHeaderColDef, userInjectedExpandableRowHeaderColDef);
++                uiGridCtrl.grid.addRowHeaderColumn(finalExpandableRowHeaderColDef);
+               }
+               uiGridExpandableService.initializeGrid(uiGridCtrl.grid);
+             },",Please use var declaration for variables you are declaring. I could not find one for userInjectedExpandableRowHeaderColDef and finalExpandableRowHeaderColDef. Also code styling in the if block needs to be corrected.,Why do we need this?
+8127,"@@ -158,12 +158,10 @@ NABoolean TMUDFDllInteraction::describeParamsAndMaxOutputs(
+                                   dummyUser,
+                                      cachedLibName, cachedLibPath))
+         {
+-           NAString cachedFullName = cachedLibPath+""/""+cachedLibName;
+            char errString[200];
+            NAString errNAString;
+-           sprintf(errString , ""Error %d creating directory :"",errno); 
++           sprintf(errString , ""Error %d creating directory : %s"", err, cachedLibPath.data()); 
+            errNAString = errString;
+-           errNAString += cachedFullName;
+            *CmpCommon::diags() <<  DgSqlCode(-4316)
+                                   << DgString0(( char *)errNAString.data());
+            bindWA->setErrStatus();","If cachedLibPath > 200 bytes, it will overflow errString.",Shouldn't this be `sprintf(`?
+8128,"@@ -202,6 +202,10 @@ const ariaRoles = {
+     allowedAttrs: ['aria-expanded'],
+     superclassRole: ['landmark']
+   },
++  generic: {
++    type: 'structure',
++    prohibitedAttrs: ['aria-label', 'aria-labelledby']
++  },
+   grid: {
+     type: 'composite',
+     requiredOwned: ['rowgroup', 'row'],","Talked this through with a few more folks. I think it would be better to flag prohibited attributes for review, instead of outright failing them. ARIA labels are used fairly liberally. We don't really know if they are actually needed whenever they are used.",Why is this needed?
+8129,"@@ -565,8 +565,11 @@ func (pool *TxPool) validateTx(tx *types.Transaction, local bool) error {
+ 	}
+ 	// Transactor should have enough funds to cover the costs
+ 	// cost == V + GP * GL
+-	if pool.currentState.GetBalance(from).Cmp(tx.Cost()) < 0 {
+-		return ErrInsufficientFunds
++	if !rcfg.UsingOVM {
++		// This check is done in SyncService.verifyFee
++		if pool.currentState.GetBalance(from).Cmp(tx.Cost()) < 0 {
++			return ErrInsufficientFunds
++		}
+ 	}
+ 	// Ensure the transaction has more gas than the basic tx fee.
+ 	intrGas, err := IntrinsicGas(tx.Data(), tx.To() == nil, true, pool.istanbul)",Let's keep it to avoid the diff,Why do we need this
+8130,"@@ -63,7 +63,8 @@ public class SparkTable implements org.apache.spark.sql.connector.catalog.Table,
+ 
+   private static final Logger LOG = LoggerFactory.getLogger(SparkTable.class);
+ 
+-  private static final Set<String> RESERVED_PROPERTIES = Sets.newHashSet(""provider"", ""format"", ""current-snapshot-id"");
++  private static final Set<String> RESERVED_PROPERTIES =
++      Sets.newHashSet(""provider"", ""format"", ""current-snapshot-id"", ""location"");
+   private static final Set<TableCapability> CAPABILITIES = ImmutableSet.of(
+       TableCapability.BATCH_READ,
+       TableCapability.BATCH_WRITE,","nit: not directly related to this PR, but shall we use `ImmutableSet` for consistency?",Why do we need this
+8131,"@@ -109,10 +109,10 @@ module Blacklight
+     # @return [Blacklight::Solr::Response] the solr response object
+     def to_hash
+       return @params unless params_need_update?
+-      @params = processed_parameters.
+-                  reverse_merge(@reverse_merged_params).
+-                  merge(@merged_params).
+-                  tap { clear_changes }
++      @params = processed_parameters
++                  .reverse_merge(@reverse_merged_params)
++                  .merge(@merged_params)
++                  .tap { clear_changes }
+     end
+ 
+     alias_method :query, :to_hash","Layout/DotPosition: Place the . on the previous line, together with the method call receiver.",Align `.merge` with
+8132,"@@ -628,7 +628,10 @@ public class ClientManager {
+                     Log.w(""AccMgrAuthTokenProvider:fetchNewAuthToken"", ""accountManager.getAuthToken returned null bundle"");
+                 } else {
+                     newAuthToken = bundle.getString(AccountManager.KEY_AUTHTOKEN);
+-                    newInstanceUrl = bundle.getString(AuthenticatorService.KEY_INSTANCE_URL);
++                    final String encryptedInstanceUrl = bundle.getString(AuthenticatorService.KEY_INSTANCE_URL);
++                    if (encryptedInstanceUrl != null) {
++                        newInstanceUrl = SalesforceSDKManager.decryptWithPasscode(encryptedInstanceUrl, SalesforceSDKManager.getInstance().getPasscodeHash());
++                    }
+                     Intent broadcastIntent;
+                     if (newAuthToken == null) {
+                         if (clientManager.revokedTokenShouldLogout) {","We send the `instanceUrl` encrypted, but never bothered to decrypt it. I guess it was working because we never did any org split testing where the `instanceUrl` actually changes.",Why do we need to decrypt the instance url here?
+8133,"@@ -43,6 +43,12 @@ public class BftBlockHeaderFunctions implements BlockHeaderFunctions {
+         bftExtraDataCodec);
+   }
+ 
++  public static BlockHeaderFunctions forCmsSignature(final BftExtraDataCodec bftExtraDataCodec) {
++    return new BftBlockHeaderFunctions(
++        h -> new BftBlockHashing(bftExtraDataCodec).calculateHashOfBftBlockForCmsSignature(h),
++        bftExtraDataCodec);
++  }
++
+   @Override
+   public Hash hash(final BlockHeader header) {
+     return hashFunction.apply(header);",Can this be moved to QbftBlockHeaderFunctions class as it is only used for qbft,nit: `forCmsSignature` -> `forBlockHashing`
+8134,"@@ -95,14 +95,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver
+             }
+         }
+ 
+-        public IList<string> Tags
+-        {
+-            get
+-            {
+-                throw new NotImplementedException();
+-            }
+-        }
+-
+         public void Analyze(TestAnalysisContext context)
+         {
+             if (_exceptionCondition == ExceptionCondition.InvokingAnalyze)",`Tags` now comes from the `PropertyBagHolder` base class.,Why was this removed?
+8135,"@@ -61,7 +61,7 @@ class TextPlot(ElementPlot):
+                 data[k].extend(eld)
+         return data, elmapping, style
+ 
+-    def get_extents(self, element, ranges=None):
++    def get_extents(self, element, ranges=None, range_type='combined'):
+         return None, None, None, None
+ 
+ ","I'm not sure where this should go, but one of the `get_extents` methods should mention that `range_type` can be `'data'` or `'combined'` (are there others?). I found out those are the two expected values by searching the code...",`range_type` doesn't seem to be used.
+8136,"@@ -25,14 +25,13 @@ import java.util.List;
+ import java.util.Locale;
+ import java.util.Map;
+ import java.util.TreeMap;
+-import java.util.logging.Logger;
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
+ import zipkin2.codec.SpanBytesDecoder;
+ import zipkin2.codec.SpanBytesEncoder;
+ import zipkin2.internal.Nullable;
+ import zipkin2.internal.Platform;
+ 
+-import static java.lang.String.format;
+-import static java.util.logging.Level.FINEST;
+ import static zipkin2.internal.HexCodec.HEX_DIGITS;
+ 
+ /**",please revert all of this stuff in core.. I'll take another pass after. cheers and thanks for the help!,I don't think we need this import.
+8137,"@@ -50,6 +50,7 @@ public class TestCreateTableAsSelect extends SparkCatalogTestBase {
+   @After
+   public void removeTables() {
+     sql(""DROP TABLE IF EXISTS %s"", tableName);
++    sql(""DROP TABLE IF EXISTS %s"", sourceName);
+   }
+ 
+   @Test",Why was this needed?,Why is this needed?
+8138,"@@ -179,8 +179,8 @@ func (brq *blockRetrievalQueue) Request(ctx context.Context, priority int, kmd K
+ 				brq.config.BlockCache().GetWithPrefetch(ptr)
+ 			if err == nil && cachedBlock != nil {
+ 				block.Set(cachedBlock, brq.config.codec())
+-				brq.triggerPrefetchAfterBlockRetrieved(
+-					cachedBlock, kmd, priority, hasPrefetched)
++				brq.Prefetcher().PrefetchAfterBlockRetrieved(
++					cachedBlock, ptr, kmd, priority, lifetime, hasPrefetched)
+ 				ch <- nil
+ 				return ch
+ 			}","I see that CI found a couple test hangs, maybe your `TogglePrefetcher` change below wasn't enough and this still needs to be a `go` invocation for some reason?",Why is this change needed?
+8139,"@@ -125,7 +125,7 @@ class DomainInfoCommand extends Command
+ 
+         $propertyExtractor = new ReflectionExtractor();
+         $io->writeln('You can access these properties:');
+-        $io->listing($propertyExtractor->getProperties($domainConfig));
++        $io->listing($propertyExtractor->getProperties(get_class($domainConfig)));
+     }
+ 
+     /**",I do not understand this change,`get_class($domainConfig)` returns
+8140,"@@ -5398,6 +5398,9 @@ type InputService24TestShapeInputService24TestCaseOperation1Input struct {
+ 
+ 	Header1 *string `location:""header"" type:""string""`
+ 
++	// By default keys received from the service api response will be formatted
++	// using net/http.CanonicalHeaderKey.
++	// Set aws.Config.LowerCaseHeaderMaps to `true` to lower case keys.
+ 	HeaderMap map[string]*string `location:""headers"" locationName:""header-map-"" type:""map""`
+ }
+ ",It would be helpful to clarify this is only for unmarshaling a response. not marshaling a request.,I think this should be `true` by default.
+8141,"@@ -109,7 +109,7 @@ describe('nested-interactive virtual-rule', function() {
+ 
+     var results = axe.runVirtualRule('nested-interactive', node);
+ 
+-    assert.lengthOf(results.passes, 0);
++    assert.lengthOf(results.passes, 1);
+     assert.lengthOf(results.violations, 1);
+     assert.lengthOf(results.incomplete, 0);
+   });","I have no explanation for why this test wasn't erroring before... There are two applicable nodes in this tree, one passes, the other fails.",Why did this change?
+8142,"@@ -26,7 +26,7 @@
+ 
+ #ifdef HAVE_CONFIG_H
+ #include <config.h>
+-#endif // HAVE_CONFIG_H
++#endif // HAVE_CONFIG_Hrm
+ 
+ #include <glob.h>
+ #include <stdio.h>","Remove the ""rm"" from the end of ""HAVE_CONFIG_H""",Why is this needed?
+8143,"@@ -15,3 +15,11 @@ func (p *FakeProver) CalculatePoSt(ctx context.Context, start, end *types.BlockH
+ 		Proofs: []types.PoStProof{[]byte(""test proof"")},
+ 	}, nil
+ }
++
++// TrivialTestSlasher is a storage fault slasher that does nothing
++type TrivialTestSlasher struct{}
++
++// Slash is a required function for storageFaultSlasher interfaces and is intended to do nothing.
++func (ts *TrivialTestSlasher) Slash(context.Context, *types.BlockHeight) error {
++	return nil
++}",Non-Blocking: This might be too trivial. It doesn't allow us to test that it's being callled.,Why do we need this?
+8144,"@@ -278,6 +278,8 @@ switch (datatype)
+   case REC_INT_FRACTION: return extFormat? (char *)""INTERVAL FRACTION"":(char *)""REC_INT_FRACTION"";
+   case REC_BLOB: return extFormat? (char *)""BLOB"":(char *)""REC_BLOB"";
+   case REC_CLOB: return extFormat? (char *)""CLOB"":(char *)""REC_CLOB"";
++  case REC_BOOLEAN: return extFormat ? (char *)""BOOLEAN"" : (char *)""BOOLEAN"";
++
+   // When you add new datatype in /common/dfs2rec.h, don't
+   // forget add new case here. Otherwise, showplan won't display it.
+   default: return extFormat? (char *)""UNKNOWN"":(char *)""add datatype in getDatatypeAsString()"";","Not sure why the ternary expressions are used here, since the true and false results are the same.",Why do we need this?
+8145,"@@ -263,7 +263,7 @@ func getTranslationFunc(driverName string) (func() translationFunc, error) {
+ 	switch driverName {
+ 	case ""sqlite3"":
+ 		return SqliteColumnTranslateFunc, nil
+-	case ""postgres"", ""sqlmock"":
++	case ""postgres"", ""sqlmock"", ""vertica"", ""vertigo"":
+ 		return PostgresColumnTranslateFunc, nil
+ 	case ""mysql"":
+ 		return MysqlColumnTranslateFunc, nil",Is `vertigo` another name for Vertica databases?,Why is this needed?
+8146,"@@ -236,6 +236,7 @@ class HintActions:
+                utils.supports_selection())
+ 
+         urlstr = url.toString(QUrl.FullyEncoded | QUrl.RemovePassword)
++        urlstr = urlstr.lstrip('mailto:')
+         utils.set_clipboard(urlstr, selection=sel)
+ 
+         msg = ""Yanked URL to {}: {}"".format(","That doesn't do the right thing - it strips any of the characters m, a, i, l, t, o and :. It'd probably be cleaner to do this before converting the URL to a string.",Why is this needed?
+8147,"@@ -98,12 +98,14 @@ cliUtils.makeCommandArgs = function(cmd, argv) {
+ 		}
+ 	}
+ 
++
+ 	const args = yargParser(argv, {
+ 		boolean: booleanFlags,
+ 		alias: aliases,
+ 		string: ['_'],
+ 	});
+ 
++
+ 	for (let i = 1; i < cmdUsage['_'].length; i++) {
+ 		const a = cliUtils.parseCommandArg(cmdUsage['_'][i]);
+ 		if (a.required && !args['_'][i]) throw new Error(_('Missing required argument: %s', a.name));",Why the white space changes?,Why do we need this?
+8148,"@@ -0,0 +1,8 @@
++class LicenseMailerPreview < ActionMailer::Preview
++  def fullfillment_error
++    user = User.new(name: 'John Doe')
++    repository = Repository.first
++
++    LicenseMailer.fulfillment_error(repository, user)
++  end
++end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Layout/TrailingBlankLines: Final newline missing.
+8149,"@@ -235,12 +235,11 @@ func (zone *ZoneDb) DomainLookupInaddr(inaddr string) (res []ZoneRecord, err err
+ func (zone *ZoneDb) startUpdatingName(name string) {
+ 	if zone.refreshInterval > 0 {
+ 		zone.mx.Lock()
+-		defer zone.mx.Unlock()
+-
+ 		// check if we should enqueue a refresh request for this name
+ 		n := zone.getNameSet(defaultRemoteIdent).getName(name, true)
++		now := zone.clock.Now()
++		zone.mx.Unlock() // Don't hold the lock while talking to the SchedQueue
+ 		if n.lastRefreshTime.IsZero() {
+-			now := zone.clock.Now()
+ 			n.lastRefreshTime = now
+ 
+ 			Debug.Printf(""[zonedb] Creating new immediate refresh request for '%s'"", name)","This is now outside the mutex, so could race.",Why do we need the lock here?
+8150,"@@ -43,11 +43,7 @@ import org.apache.lucene.index.SortedSetDocValues;
+ import org.apache.lucene.index.TermsEnum;
+ import org.apache.lucene.search.DocIdSetIterator;
+ import org.apache.lucene.search.SortedSetSelector;
+-import org.apache.lucene.store.ByteBuffersDataOutput;
+-import org.apache.lucene.store.ByteBuffersIndexOutput;
+-import org.apache.lucene.store.ChecksumIndexInput;
+-import org.apache.lucene.store.IOContext;
+-import org.apache.lucene.store.IndexOutput;
++import org.apache.lucene.store.*;
+ import org.apache.lucene.util.ArrayUtil;
+ import org.apache.lucene.util.BytesRef;
+ import org.apache.lucene.util.BytesRefBuilder;",hmmm did this pass spotless check? I don't think we typically use wildcard imports,Please don't use wildcard imports.
+8151,"@@ -222,8 +222,8 @@ func (j journalMDOps) getRangeFromJournal(
+ 	return irmds, nil
+ }
+ 
+-func (j journalMDOps) GetForHandle(
+-	ctx context.Context, handle *TlfHandle, mStatus MergeStatus) (
++func (j journalMDOps) GetForHandle(ctx context.Context, handle *TlfHandle,
++	mStatus MergeStatus, lockBeforeLock *keybase1.LockID) (
+ 	tlfID tlf.ID, rmd ImmutableRootMetadata, err error) {
+ 	// TODO: Ideally, *TlfHandle would have a nicer String() function.
+ 	j.jServer.log.LazyTrace(ctx, ""jMDOps: GetForHandle %+v %s"", handle, mStatus)",`lockBeforeLock` -> `lockBeforeGet` (here and everywhere below).,nit: `lockBeforeLock *keybase1.LockID`
+8152,"@@ -12,7 +12,7 @@ import java.util.List;
+ import org.junit.Test;
+ 
+ import net.sourceforge.pmd.PMD;
+-import net.sourceforge.pmd.lang.java.ast.JavaParserConstants;
++import net.sourceforge.pmd.lang.java.ast.JavaTokenKinds;
+ 
+ public class JavaTokensTokenizerTest {
+ ","Do we need to internalize net.sourceforge.pmd.lang.java.ast.JavaParserConstants on master, so that we can rename it?",Why this change?
+8153,"@@ -36,7 +36,7 @@ namespace Nethermind.Vault
+             {1, new Guid(""deca2436-21ba-4ff5-b225-ad1b0b2f5c59"")},
+             {3, new Guid(""66d44f30-9092-4182-a3c4-bc02736d6ae5"")},
+             {4, new Guid(""07102258-5e49-480e-86af-6d0c3260827d"")},
+-            {5, new Guid(""1b16996e-3595-4985-816c-043345d22f"")},
++            //{5, new Guid(""1b16996e-3595-4985-816c-043345d22f"")},
+             {42, new Guid(""8d31bf48-df6b-4a71-9d7c-3cb291111e27"")}
+         };
+ ","The GUID here was incorrect, because of that, Vault plugin loading was failing. Should I change to any correct GUID, or it has some special meaning?",Is this intentio
+8154,"@@ -84,9 +84,6 @@ namespace OpenTelemetry.Instrumentation.AspNetCore.Tests
+             // giving some breezing room for the End callback to complete
+             await Task.Delay(TimeSpan.FromSeconds(1));
+ 
+-            // Invokes the TestExporter which will invoke ProcessExport
+-            metricReader.Collect();
+-
+             this.meterProvider.Dispose();
+ 
+             var requestMetrics = metricItems","just confirming: if we remove explicit Collect(), then we are relying on the provider dispose... which has a hard-coded 5000 msec to finish flushing. On the other hand, if we keep explicit Collect(), we can pass an explicit timeout to it. (we were not doing it now and was relying on Infinite timeout). Net effect of this change in test code: Previously we would wait indefinitely for Collect() to be over. With this PR, we hope Collect() will be over in 5 secs. If we ever need more than 5 sec, we need to bring back Collect(maxTimeInMilliSecs..).",Why was this rem
+8155,"@@ -22,4 +22,16 @@ public class Constants {
+ 	public static final String AZKABAN_PRIVATE_PROPERTIES_FILE = ""azkaban.private.properties"";
+ 	public static final String DEFAULT_CONF_PATH = ""conf"";
+ 	public static final String AZKABAN_EXECUTOR_PORT_FILENAME = ""executor.port"";
++
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_GLOBAL_DISABLE = ""azkaban.logging.kafka.globalDisable"";
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_BROKERLIST = ""azkaban.logging.kafka.brokerList"";
++  public static final String AZKABAN_SERVER_LOGGING_KAFKA_TOPIC = ""azkaban.logging.kafka.topic"";
++
++  public static final String AZKABAN_FLOW_PROJECT_NAME = ""azkaban.flow.projectname"";
++  public static final String AZKABAN_FLOW_FLOW_ID = ""azkaban.flow.flowid"";
++  public static final String AZKABAN_FLOW_SUBMIT_USER = ""azkaban.flow.submituser"";
++  public static final String AZKABAN_FLOW_EXEC_ID = ""azkaban.flow.execid"";
++  public static final String AZKABAN_FLOW_PROJECT_VERSION = ""azkaban.flow.projectversion"";
++
++  public static final String AZKABAN_JOB_LOGGING_KAFKA_ENABLE = ""azkaban.job.logging.kafka.enable"";
+ }",What do you think of a name like azkaban.server.logging.kafka.brokerList? This way the name signals that this is a server config.,I think this sho
+8156,"@@ -449,6 +449,12 @@ namespace NLog.Targets
+             get
+             {
+ #if SupportsMutex
++
++                if (!PlatformDetector.SupportsSharableMutex)
++                {
++                    return _concurrentWrites ?? false;  // Better user experience for mobile platforms
++                }
++
+                 return _concurrentWrites ?? true;
+ #else
+                 return _concurrentWrites ?? false;  // Better user experience for mobile platforms",Maybe change into `return _concurrentWrites ?? PlatformDetector.SupportsSharableMutex` ?,Why do we need this?
+8157,"@@ -63,7 +63,8 @@ public class CircleStyleFinalizerTests {
+ 
+         finalizer.createCircleReport();
+ 
+-        String report = Resources.toString(targetFile.toURI().toURL(), StandardCharsets.UTF_8);
++        String report = Resources.toString(targetFile.toURI().toURL(), StandardCharsets.UTF_8)
++                .replaceAll(""\\p{Blank}*(?=<)"", """");
+         String expectedReport = Resources.toString(
+                 testFile(""two-namecheck-failures-checkstyle-report.xml""), StandardCharsets.UTF_8);
+ ",indentation of resulting file is different between 11 and 8 where 8 doesn't indent lines and 11 does,Why is this needed?
+8158,"@@ -82,13 +82,14 @@ func (u *unaryTransportHandler) Handle(ctx context.Context, req *Request, reqBuf
+ 	}
+ 
+ 	if appErr != nil {
+-		// TODO: This is a bit odd; we set the error in response AND return it.
+-		// However, to preserve the current behavior of YARPC, this is
+-		// necessary. This is most likely where the error details will be added,
+-		// so we expect this to change.
++		encodedError, err := codec.EncodeError(appErr)
++		if err != nil {
++			return res, nil, err
++		}
++
+ 		errorInfo := yarpcerror.ExtractInfo(appErr)
+ 		res.ApplicationErrorInfo = &errorInfo
+-		return res, encodedBody, appErr
++		return res, encodedError, nil
+ 	}
+ 
+ 	return res, encodedBody, nil",Do we still need to return the `Response` here?,Why do we need to en
+8159,"@@ -18,3 +18,4 @@ if (global.document) {
+   }));
+   document.execCommand = jest.fn();
+ }
++global.VERDACCIO_API_URL = 'http://localhost/-/verdaccio/'",Here `global.VERDACCIO_API_URL` I'd use something different as `global.TEST_VERDACCIO_API_URL` then when you search by `VERDACCIO_API_URL` we don't confuse with `window.VERDACCIO_API_URL`,
+8160,"@@ -57,6 +57,13 @@ public class DiscoveryFragmentGeneratorTool {
+             .hasArg()
+             .argName(""OUTPUT-DIRECTORY"")
+             .build());
++    options.addOption(
++        Option.builder()
++            .longOpt(""auth_url"")
++            .desc(""A comma delimited map of language to auth instructions URL."")
++            .hasArg()
++            .argName(""AUTH-URL"")
++            .build());
+ 
+     CommandLine cl = (new DefaultParser()).parse(options, args);
+     if (cl.hasOption(""help"")) {","This is totally fine, but consider whether in the future a YAML input format would be better. If so, we can plan for it.",This should be `auth_url`
+8161,"@@ -277,6 +277,14 @@ namespace Datadog.Trace.Configuration
+         /// </summary>
+         public const string DiagnosticSourceEnabled = ""DD_DIAGNOSTIC_SOURCE_ENABLED"";
+ 
++        /// <summary>
++        /// Configuration key for the semantic convention to be used.
++        /// The Tracer uses it to define operation names, span tags, statuses etc.
++        /// Default is <c>""Default""</c>.
++        /// <seealso cref=""TracerSettings.Convention""/>
++        /// </summary>
++        public const string Convention = ""DD_CONVENTION"";
++
+         /// <summary>
+         /// Configuration key for setting the API key, used by the Agent.
+         /// This key is here for troubleshooting purposes.",This should be `DD_TRACE_CONVENTION` to follow our ... conventions.,Should this be `DD_CONVEN
+8162,"@@ -241,8 +241,7 @@ Status VariablePropertyExpression::prepare() {
+ 
+ 
+ OptVariantType EdgeTypeExpression::eval(Getters &getters) const {
+-    UNUSED(getters);
+-    return *alias_;
++    return getters.getAliasProp(*alias_, *prop_);
+ }
+ 
+ Status EdgeTypeExpression::prepare() {",Be careful memory leaks. memory leaks occur when getters.getAliasProp == nullptr . right?,nit: `return getters.getA
+8163,"@@ -281,6 +281,7 @@ type readCache struct {
+ 
+ 	// This is for routes and gateways to have their own L1 as well that is account aware.
+ 	pacache map[string]*perAccountCache
++	losc    int64 // last orphan subs check
+ 
+ 	// This is for when we deliver messages across a route. We use this structure
+ 	// to make sure to only send one message and properly scope to queues as needed.",Why not just a time.Time?,nit: `losc` -> `lastOrpha
+8164,"@@ -213,7 +213,7 @@ class DefaultFormatBundle:
+                 continue
+             results[key] = DC(to_tensor(results[key]))
+         if 'gt_masks' in results:
+-            results['gt_masks'] = DC(results['gt_masks'], cpu_only=True)
++            results['gt_masks'] = DC(to_tensor(results['gt_masks']), cpu_only=True)
+         if 'gt_semantic_seg' in results:
+             results['gt_semantic_seg'] = DC(
+                 to_tensor(results['gt_semantic_seg'][None, ...]), stack=True)",Please do not submit a commit that is not part of this PR.,Why do we need this change?
+8165,"@@ -410,11 +410,11 @@ func (d *HandlerImpl) UpdateDomain(
+ 
+ 	if updateRequest.UpdatedInfo != nil {
+ 		updatedInfo := updateRequest.UpdatedInfo
+-		if updatedInfo.Description != nil {
++		if updatedInfo.GetDescription() != """" {
+ 			configurationChanged = true
+ 			info.Description = updatedInfo.GetDescription()
+ 		}
+-		if updatedInfo.OwnerEmail != nil {
++		if updatedInfo.GetOwnerEmail() != """" {
+ 			configurationChanged = true
+ 			info.OwnerEmail = updatedInfo.GetOwnerEmail()
+ 		}","This is small braking change: there is no way to clear description any more. If value is empty string, description will not be updated at all. It will affect existing Thrift endpoints also.",Why is this change needed?
+8166,"@@ -16,5 +16,8 @@ func DNS01Record(domain, value string) (string, string, int) {
+ 	if err == nil && r.Rcode == dns.RcodeSuccess {
+ 		fqdn = updateDomainWithCName(r, fqdn)
+ 	}
+-	return fqdn, value, 60
++	if err != nil {
++		return """", """", 0, err
++	}
++	return fqdn, value, 60, nil
+ }",Can you open a separate PR with this patch? It seems valuable outside the context of this PR!,Shouldn't this be `return f
+8167,"@@ -52,6 +52,9 @@ func (s *server) setupRouting() {
+ 	router.Handle(""/peers/{address}"", jsonhttp.MethodHandler{
+ 		""DELETE"": http.HandlerFunc(s.peerDisconnectHandler),
+ 	})
++	router.Handle(""/chunk/{address}"", jsonhttp.MethodHandler{
++		""GET"": http.HandlerFunc(s.hasChunkHandler),
++	})
+ 
+ 	baseRouter.Handle(""/"", web.ChainHandlers(
+ 		logging.NewHTTPAccessLogHandler(s.Logger, logrus.InfoLevel, ""debug api access""),","I would suggest to have plurals in the api `""/chunks/{address}""`",Why is this a GET request?
+8168,"@@ -1365,6 +1365,7 @@ namespace pwiz.Skyline.Model
+             ALL_LABEL_SUBSTITUTIONS = ImmutableList.ValueOf(new[]
+         {
+             Tuple.Create(LabelAtoms.C13, BioMassCalc.C, BioMassCalc.C13),
++            Tuple.Create(LabelAtoms.C14, BioMassCalc.C, BioMassCalc.C14),
+             Tuple.Create(LabelAtoms.N15, BioMassCalc.N, BioMassCalc.N15),
+             Tuple.Create(LabelAtoms.O18, BioMassCalc.O, BioMassCalc.O18),
+             Tuple.Create(LabelAtoms.H2, BioMassCalc.H, BioMassCalc.H2),","Let's just not do this. We don't have LabelAtoms.O17 here. This is just a short-cut to avoid needing to write out a more verbose function like: 5O"" - 5O i.e. Add 5 x 17O atoms to replace 5 x 16O atoms. This was the original implementation in Skyline before I added the checkboxes to denote simply labeling all atoms in the amino acid.",Why is this needed?
+8169,"@@ -56,7 +56,7 @@ def bootstrap_accept_mini(field, **kwargs):
+                          name=""submitButton"",
+                          type=""submit"",
+                          value=field.label.text,
+-                         onclick=""mini_approval('Accept', event, %s);"" % (objectid,),)
++                         onclick=""approval.mini_approval('Accept', event, %s);"" % (objectid,),)
+     return HTMLString(u''.join(html))
+ 
+ ","1:D100: Docstring missing 23:D400: First line should end with '.', not 'p' 23:D200: One-line docstring should not occupy 3 lines 36:D400: First line should end with '.', not 'n' 36:D200: One-line docstring should not occupy 3 lines 48:D400: First line should end with '.', not 'p' 48:D200: One-line docstring should not occupy 3 lines 63:D400: First line should end with '.', not 'p' 63:D200: One-line docstring should not occupy 3 lines 76:D400: First line should end with '.', not 'p' 76:D200: One-line docstring should not occupy 3 lines",E501 line too long 
+8170,"@@ -73,6 +73,10 @@ class CarouselLoop extends Image
+     {
+         /** @var \Carousel\Model\Carousel $carousel */
+         foreach ($loopResult->getResultDataCollection() as $carousel) {
++            if (!file_exists($carousel->getUploadDir() . DS . $carousel->getFile())) {
++                continue;
++            }
++
+             $loopResultRow = new LoopResultRow($carousel);
+ 
+             $event = new ImageEvent();",Adding a warning or an error in the Thelia log would be a nice idea.,Shouldn't this be `
+8171,"@@ -26,6 +26,8 @@ var CONNECTED = 'connected';
+ var DESTROYING = 'destroying';
+ var DESTROYED = 'destroyed';
+ 
++const CONNECTION_EVENTS = ['error', 'close', 'timeout', 'parseError', 'connect', 'message'];
++
+ var _id = 0;
+ 
+ /**",nit: `Set` (and swap `forEach`s for `for (const i of CONNECTION_EVENTS)`),I don't think this 
+8172,"@@ -4,7 +4,7 @@ using System.Collections.Generic;
+ using System.Linq;
+ using System.Reflection;
+ using System.Reflection.Emit;
+-using System.Runtime.InteropServices;
++using Datadog.Trace.ClrProfiler.ExtensionMethods;
+ using Datadog.Trace.ClrProfiler.Helpers;
+ using Datadog.Trace.Configuration;
+ using Datadog.Trace.Logging;",nit: Is this `using` statement still needed?,Why is this needed?
+8173,"@@ -26,7 +26,7 @@ func (endpoint *identitiesApi) List(writer http.ResponseWriter, request *http.Re
+ 	idsSerializable := make([]identityDto, len(idArry))
+ 	for i, id := range idArry {
+ 		idsSerializable[i] = identityDto{
+-			Id: string(id),
++			Id: string(id.Id),
+ 		}
+ 	}
+ ",Dont need to cast `string` -> `string`,why this change?
+8174,"@@ -35,6 +35,11 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
++	s.Addressbook.Put(address, addr)
++	if err := s.TopologyDriver.AddPeer(r.Context(), address); err != nil {
++		s.Logger.Debugf(""debug api: topologyDriver.AddPeer %s: %v"", addr, err)
++	}
++
+ 	jsonhttp.OK(w, peerConnectResponse{
+ 		Address: address.String(),
+ 	})",why doesn't the API return an error in this case?,I think this should
+8175,"@@ -583,3 +583,18 @@ class InvalidInstanceMetadataError(Exception):
+     def __init__(self, msg):
+         final_msg = msg + '\n' + self.MSG
+         super(InvalidInstanceMetadataError, self).__init__(final_msg)
++
++
++class BaseEndpointResolverError(Exception):
++    """"""Base error for endpoint resolving errors.
++
++    Should never be raised directly, but clients can catch
++    this exception if they want to generically handle any errors
++    during the endpoint resolution process.
++
++    """"""
++
++
++class NoRegionError(BaseEndpointResolverError):
++    """"""No region was specified.""""""
++    fmt = 'You must specify a region.'",Not sure how particularly useful these exceptions are. Seem to be exceptions required in copying and pasting the EndpointResolver over. I wonder if it makes sense to move these out of ``exceptions.py``,Why do we need this
+8176,"@@ -203,9 +203,6 @@ class Proposal < ActiveRecord::Base
+     end
+   end
+ 
+-
+-  ## delegated methods ##
+-
+   def public_identifier
+     self.delegate_with_default(:public_identifier) { ""##{self.id}"" }
+   end",Can we re-add this? I think that grouping is useful (though would be open to putting them in a mixin or something).,Why was this removed?
+8177,"@@ -319,7 +319,7 @@ public class PartitionSpec implements Serializable {
+     private final Schema schema;
+     private final List<PartitionField> fields = Lists.newArrayList();
+     private final Set<String> partitionNames = Sets.newHashSet();
+-    private Map<Integer, PartitionField> timeFields = Maps.newHashMap();
++    private Map<String, PartitionField> partitionFields = Maps.newHashMap();
+     private int specId = 0;
+     private final AtomicInteger lastAssignedFieldId = new AtomicInteger(PARTITION_DATA_ID_START - 1);
+ ","Overall LGTM, one nit is that I think `partitionFields` here would be good to be renamed so that it's easy to tell it's just for collision detection. Also I wonder if we want to do this check for other transformations too (e.g. bucket, and record numBuckets in the string), so that we might be able to combine `fields` and `partitionFields` into potentially something like a LinkedHashMap?",Why do we need this c
+8178,"@@ -34,6 +34,8 @@ class Config(object):
+                               datetime.datetime.now().strftime('%Y%m%d%H%M%S'))
+         self.identifier = None
+         self.force_no_cloudshell = bool(kwargs.get('no_cloudshell'))
++        self.service_account_key_path = kwargs.get(
++            'service_account_key_path') or None
+         self.config_filename = (kwargs.get('config') or
+                                 'forseti-setup-{}.cfg'.format(
+                                     self.datetimestamp))","Don't need the `or None` here as the flag will already default to None. Also, `some_dict.get('foo')` will also default to `None`.",I don't think you nee
+8179,"@@ -68,6 +68,7 @@ storiesOf( 'Settings', module )
+ 		options: {
+ 			delay: 3000, // Wait for tabs to animate.
+ 		},
++		padding: 0,
+ 	} )
+ 	.add( 'Connected Services', () => {
+ 		const setupRegistry = ( registry ) => {","Please, use the default padding here.",Why do we need this?
+8180,"@@ -3,11 +3,12 @@
+ const Aspect = require('./operation').Aspect;
+ const OperationBase = require('./operation').OperationBase;
+ const resolveReadPreference = require('../utils').resolveReadPreference;
++const serverLacksFeature = require('../utils').serverLacksFeature;
+ const ReadConcern = require('../read_concern');
+ const WriteConcern = require('../write_concern');
+ const maxWireVersion = require('../core/utils').maxWireVersion;
+ const commandSupportsReadConcern = require('../core/sessions').commandSupportsReadConcern;
+-const MongoError = require('../error').MongoError;
++const MongoError = require('../core').MongoError;
+ 
+ const SUPPORTS_WRITE_CONCERN_AND_COLLATION = 5;
+ ",let's actually use the direct include: `require('../core/error').MongoError;`,Why this change?
+8181,"@@ -227,6 +227,16 @@ def data(readonly=False):
+              ""How to open links in an existing instance if a new one is ""
+              ""launched.""),
+ 
++            ('new-instance-open-target.window',
++             SettingValue(typ.String(
++                 valid_values=typ.ValidValues(
++                     ('last-opened', ""Open new tabs in the last""
++                     ""opened window.""),
++                     ('last-focused', ""Open new tabs in the most""
++                     ""recently focused window."")
++                 )), 'last-focused'),
++             ""Which window to choose when opening links as new tabs.""),
++
+             ('log-javascript-console',
+              SettingValue(typ.String(
+                  valid_values=typ.ValidValues(","You're missing a space before the `""` here and below, but I'll fix it up when merging.",This should be `
+8182,"@@ -119,6 +119,11 @@ void testBookmarks(ROMol m) {
+   m.clearBondBookmark(777);
+ }
+ 
++void dump(STR_VECT &p) {
++  std::cerr << ""----------------------------------"" << std::endl;
++  for(size_t i=0;i<p.size();++i)
++    std::cerr << p[i] << std::endl;
++}
+ void testMolProps() {
+   BOOST_LOG(rdInfoLog)
+       << ""-----------------------\n Testing Mol Property Caches"" << std::endl;",remove this debugging code?,Why is this need
+8183,"@@ -22,14 +22,14 @@ class ParallelPostingsArray {
+   final static int BYTES_PER_POSTING = 3 * Integer.BYTES;
+ 
+   final int size;
+-  final int[] textStarts;
+-  final int[] intStarts;
+-  final int[] byteStarts;
++  final int[] textStarts; // maps term ID to the terms text start in the bytesHash
++  final int[] addressOffset; // maps term ID to current stream address
++  final int[] byteStarts; // maps term ID to stream start offset in the byte pool
+ 
+   ParallelPostingsArray(final int size) {
+     this.size = size;
+     textStarts = new int[size];
+-    intStarts = new int[size];
++    addressOffset = new int[size];
+     byteStarts = new int[size];
+   }
+ ",s/`terms text`/`terms's text`,nit: `bytesHash`
+8184,"@@ -23,6 +23,7 @@ module.exports = class Form extends Plugin {
+       resultName: 'uppyResult',
+       getMetaFromForm: true,
+       addResultToForm: true,
++      replaceResultInFormWithNew: true,
+       submitOnSuccess: false,
+       triggerUploadOnSubmit: false
+     }",":bike: :derelict_house: , but maybe the default option should be `multipleResults: false` or `combineMultipleResults: false`? i feel like `replaceResultInFormWithNew` is very verbose but also doesn't immediately clarify what it's for.",Why is this needed?
+8185,"@@ -1,15 +1,16 @@
+ require ""rails_helper""
+ 
+-feature 'Visitor signs up for a subscription' do
++feature ""Visitor signs up for a subscription"" do
+   background do
+     create_plan
+   end
+ 
+-  scenario 'visitor signs up by navigating from landing page' do
++  scenario ""visitor signs up by navigating from landing page"", js: true do
+     create(:trail, :published)
+ 
+     visit root_path
+-    click_link ""Sign Up Now!""
++    click_link I18n.t(""subscriptions.new.sign_up_cta"")
++    show_email_and_username_form
+     fill_out_account_creation_form
+     fill_out_credit_card_form_with_valid_credit_card
+ ",Line is too long. [87/80],Style/StringLiteral
+8186,"@@ -2,10 +2,8 @@
+ #  Copyright (C) 2006 Greg Landrum
+ #  This file is part of RDKit and covered by $RDBASE/license.txt
+ #
+-
+-
+-import argparse
+ import sys
++import argparse
+ 
+ from rdkit import Chem
+ from rdkit import Geometry",Are you using an automated tool for sorting the imports?,Why did you change 
+8187,"@@ -41,11 +41,11 @@ class ApiClient(object):
+     __metaclass__ = abc.ABCMeta
+ 
+     @abc.abstractmethod
+-    def fetch_bigquery_dataset_policy(self, project_id, dataset_id):
++    def fetch_bigquery_dataset_policy(self, project_number, dataset_id):
+         """"""Dataset policy Iterator for a dataset from gcp API call.
+ 
+         Args:
+-            project_id (str): id of the project to query.
++            project_number (str): id of the project to query.
+             dataset_id (str): id of the dataset to query.
+         """"""
+ ","If this is `project_number` now, can we also update the `id` the description?",I think this should
+8188,"@@ -132,6 +132,7 @@ func (s *receiveStream) readImpl(p []byte) (bool /*stream completed */, int, err
+ 				}
+ 				if deadlineTimer == nil {
+ 					deadlineTimer = utils.NewTimer()
++					defer deadlineTimer.Stop()
+ 				}
+ 				deadlineTimer.Reset(deadline)
+ 			}","* This will defer until the function returns. Are you sure this won't happen multiple times. * Alternatively, why is the deadline timer not defined outside the outer loop? * More generally, why are we looping in the first place instead of reading one frame and returning?",Why do we need this?
+8189,"@@ -36,10 +36,10 @@ namespace Datadog.Trace.Agent.Transports
+             _request.Headers.Add(name, value);
+         }
+ 
+-        public async Task<IApiResponse> PostAsync(ArraySegment<byte> traces)
++        public async Task<IApiResponse> PostAsync(ArraySegment<byte> traces, string contentType)
+         {
+             _request.Method = ""POST"";
+-            _request.ContentType = ""application/msgpack"";
++            _request.ContentType = contentType;
+             using (var requestStream = await _request.GetRequestStreamAsync().ConfigureAwait(false))
+             {
+                 await requestStream.WriteAsync(traces.Array, traces.Offset, traces.Count).ConfigureAwait(false);",Should we rename the traces parameter now that this isn't just traces?,Should this be `appl
+8190,"@@ -28,14 +28,14 @@ static void atomic_begin(struct wlr_drm_crtc *crtc, struct atomic *atom) {
+ 	atom->failed = false;
+ }
+ 
+-static bool atomic_end(int drm_fd, struct atomic *atom) {
++static bool atomic_end(int drm_fd, uint32_t flags, struct atomic *atom) {
+ 	if (atom->failed) {
+ 		return false;
+ 	}
+ 
+-	uint32_t flags = DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_NONBLOCK;
++	flags |= DRM_MODE_ATOMIC_TEST_ONLY;
+ 	if (drmModeAtomicCommit(drm_fd, atom->req, flags, NULL)) {
+-		wlr_log_errno(WLR_ERROR, ""Atomic test failed"");
++		wlr_log_errno(WLR_DEBUG, ""Atomic test failed"");
+ 		drmModeAtomicSetCursor(atom->req, atom->cursor);
+ 		return false;
+ 	}",I don't think it makes sense to have both `TEST_ONLY` and `NONBLOCK`. We should probably leave `NONBLOCK` out.,I think this should 
+8191,"@@ -109,7 +109,10 @@ static void touch_point_handle_surface_destroy(struct wl_listener *listener,
+ 		void *data) {
+ 	struct wlr_touch_point *point =
+ 		wl_container_of(listener, point, surface_destroy);
+-	touch_point_destroy(point);
++	// Touch point itself is destroyed on up event
++	point->surface = NULL;
++	wl_list_remove(&point->surface_destroy.link);
++	wl_list_init(&point->surface_destroy.link);
+ }
+ 
+ static struct wlr_touch_point *touch_point_create(",Need to remove the surface destroy listener (and `wl_list_init` it so that `touch_point_destroy` still works),Why is this needed?
+8192,"@@ -31,7 +31,8 @@ class ResearchProjectsController < ApplicationController
+ 
+   def fetch_projects
+     Rails.cache.fetch([""research_projects"", funder_type], expires_in: expiry) do
+-      Thread.new { ExternalApis::OpenAireService.search(funder: funder_type) }.value
++      #Thread.new { ExternalApis::OpenAireService.search(funder: funder_type) }.value
++      ExternalApis::OpenAireService.search(funder: funder_type)
+     end
+   end
+ ",create ticket to investigate this,Missing space after #.
+8193,"@@ -90,7 +90,7 @@ typedef struct
+   struct sockaddr_storage addr;
+ } ipaddress_t;
+ 
+-static socklen_t address_length(ipaddress_t* ipaddr)
++PONY_API socklen_t address_length(ipaddress_t* ipaddr)
+ {
+   switch(ipaddr->addr.ss_family)
+   {","If we want to expose this for FFI use in the standard library, it needs to get either a `pony_` or `ponyint_` prefix to its name, for cleanliness of the function namespace. `pony_` means it is a public API meant for use by third party code, whereas `ponyint_` means it is internal. Unless there is a good reason to make it public, we should prefer to keep it internal because public functions require us to treat any changes to them as breaking changes in Pony. So, this function should end up named `ponyint_address_length`, or something else with that prefix.",Why this change?
+8194,"@@ -17,6 +17,8 @@ const (
+ 	OptionsWaitBeforeDelete = ""WAIT_BEFORE_DELETE""
+ 	// OptionsRedirectDetach Redirect detach to the node where volume is attached
+ 	OptionsRedirectDetach = ""REDIRECT_DETACH""
++	// OptionsDeviceFuseMount name of fuse mount device
++	OptionsDeviceFuseMount = ""DEV_FUSE_MOUNT""
+ )
+ 
+ func IsBoolOptionSet(options map[string]string, key string) bool {","Fuse for shared volumes is a px specific implementation. libopenstorage doesn't know about it, right? So should this be called DeviceVirtualMount (or something similar) instead?",Why do we need this?
+8195,"@@ -24,6 +24,13 @@ namespace Datadog.Trace.ClrProfiler
+ 
+         public ushort TargetSignatureTypesLength;
+ 
++        [MarshalAs(UnmanagedType.U1)]
++        public bool UseTargetMethodArgumentsToLoad;
++
++        public IntPtr TargetMethodArgumentsToLoad;
++
++        public ushort TargetMethodArgumentsToLoadLength;
++
+         public ushort TargetMinimumMajor;
+ 
+         public ushort TargetMinimumMinor;",`bool` vs `BOOL` in native side :),Why do we need this? C
+8196,"@@ -17,6 +17,7 @@ const chromiumRebaseL10n = require('../lib/chromiumRebaseL10n')
+ const createDist = require('../lib/createDist')
+ const upload = require('../lib/upload')
+ const test = require('../lib/test')
++const lint = require('../lib/lint')
+ 
+ program
+   .version(process.env.npm_package_version)",I think maybe you moved it to util but this is still around and it should get it from util instead.,Why is this needed?
+8197,"@@ -0,0 +1,16 @@
++class RepositoriesController < ApplicationController
++  def index
++    @catalog = Catalog.new
++  end
++
++  def show
++    repository = Repository.friendly.find(params[:id])
++    @offering = Offering.new(repository, current_user)
++
++    if @offering.user_has_license?
++      redirect_to repository.github_url
++    else
++      render template: ""products/show""
++    end
++  end
++end",Do we need to test the redirection?,Use nested module/c
+8198,"@@ -372,12 +372,12 @@ public class EpisodesApplyActionFragment extends Fragment {
+     }
+ 
+     private void markedCheckedPlayed() {
+-        DBWriter.markItemPlayed(getActivity(), FeedItem.PLAYED, checkedIds.toArray());
++        DBWriter.markItemPlayed(FeedItem.PLAYED, checkedIds.toArray());
+         close();
+     }
+ 
+     private void markedCheckedUnplayed() {
+-        DBWriter.markItemPlayed(getActivity(), FeedItem.UNPLAYED, checkedIds.toArray());
++        DBWriter.markItemPlayed(FeedItem.UNPLAYED, checkedIds.toArray());
+         close();
+     }
+ ","Tsts, that's why... activity leak about to happen",I'm not sure if thi
+8199,"@@ -3160,6 +3160,9 @@ func (s *Server) startGWReplyMapExpiration() {
+ 				}
+ 			case cttl := <-s.gwrm.ch:
+ 				ttl = cttl
++				if !t.Stop() {
++					<-t.C
++				}
+ 				t.Reset(ttl)
+ 			case <-s.quitCh:
+ 				return",You should do a select here IMO just to be safe so we do not block forever.,Why is this needed?
+8200,"@@ -119,7 +119,7 @@ type Node struct {
+ 	// Incoming messages for block mining.
+ 	MsgPool *core.MessagePool
+ 	// Messages sent and not yet mined.
+-	Outbox *core.MessageQueue
++	MsgQueue *core.MessageQueue
+ 
+ 	Wallet *wallet.Wallet
+ ",I'll replace this with the actual outbox object soon.,Why is this a pointer?
+8201,"@@ -218,6 +218,9 @@ class AnnotationTest extends TestCase
+      */
+     public function providerValidCodeParse(): iterable
+     {
++        $codebase = $this->project_analyzer->getCodebase();
++        $codebase->reportUnusedVariables();
++
+         return [
+             'nopType' => [
+                 '<?php","Providers are called *before* `setUp()`, so I don't think you can access properties here.",Why do we need this?
+8202,"@@ -11,7 +11,7 @@ namespace Xunit
+     /// Apply this attribute to your test method to specify an active issue.
+     /// </summary>
+     [TraitDiscoverer(""Xunit.NetCore.Extensions.ActiveIssueDiscoverer"", ""Xunit.NetCore.Extensions"")]
+-    [AttributeUsage(AttributeTargets.Method, AllowMultiple = true)]
++    [AttributeUsage(AttributeTargets.Method | AttributeTargets.Class, AllowMultiple = true)]
+     public class ActiveIssueAttribute : Attribute, ITraitAttribute
+     {
+         public ActiveIssueAttribute(int issueNumber, TestPlatforms platforms) { }",While this allows it to be applied does it correctly cause the entire class to be skipped?,Why is this needed?
+8203,"@@ -143,6 +143,11 @@ def main():
+     if args.seed is not None:
+         logger.info(f'Set random seed to {args.seed}, '
+                     f'deterministic: {args.deterministic}')
++
++        # import torch.distributed as dist
++        # rank = dist.get_rank()
++        # args.seed = args.seed + rank
++
+         set_random_seed(args.seed, deterministic=args.deterministic)
+     cfg.seed = args.seed
+     meta['seed'] = args.seed",clean unnecessary modification.,why is this here?
+8204,"@@ -44,8 +44,8 @@ describe('createElement(jsx)', () => {
+ 	});
+ 
+ 	it('should set VNode#key property', () => {
+-		expect(<div />).to.have.property('key').that.is.undefined;
+-		expect(<div a=""a"" />).to.have.property('key').that.is.undefined;
++		expect(<div />).to.have.property('key').that.is.empty;
++		expect(<div a=""a"" />).to.have.property('key').that.is.empty;
+ 		expect(<div key=""1"" />).to.have.property('key', '1');
+ 	});
+ ",I think these assertions want to be `.to.not.exist` which would pass for `null` or `undefined`,Why did this change?
+8205,"@@ -24,11 +24,9 @@ import (
+ )
+ 
+ func ExampleOpenKeeper() {
+-	// This example is used in https://gocloud.dev/howto/secrets/#vault-ctor
+-
+-	// import _ ""gocloud.dev/secrets/hashivault""
+-
+-	// Variables set up elsewhere:
++	// PRAGMA(gocloud.dev): Package this example for gocloud.dev.
++	// PRAGMA(gocloud.dev): Add a blank import: _ ""gocloud.dev/secrets/hashivault""
++	// PRAGMA(gocloud.dev): Skip until next blank line.
+ 	ctx := context.Background()
+ 
+ 	// Get a client to use with the Vault API.",Don't think you need this since this is not a URL example.,Why is this blank li
+8206,"@@ -43,6 +43,14 @@ class TestFakerNumber < Test::Unit::TestCase
+     assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
+   end
+ 
++  def test_decimal_within
++    assert @tester.decimal_within(l_digits: 1, r_digits: 1, range: 0..1).to_s.match(/[0-1]{1}\.[0-1]{1}/)
++    assert @tester.decimal_within(l_digits: 1).to_s.match(/[0-9]{1}\.[0-9]{2}/)
++    assert @tester.decimal(l_digits: 4, r_digits: 5).to_s.match(/[0-9]{4}\.[0-9]{5}/)
++    assert @tester.decimal_within(l_digits: 3, r_digits: 3, range: 1..100).to_s.match(/[0-9]*\.[0-9]*/)
++    assert @tester.decimal_within(l_digits: 3, r_digits: 3, range: 1..1000).to_s.match(/[0-9]*\.[0-9]*/)
++  end
++
+   def test_digit
+     assert @tester.digit.to_s.match(/[0-9]{1}/)
+     assert((1..1000).collect { |_i| @tester.digit == 9 }.include?(true))","Maybe a test to check if the generated value is within the boundaries would be nice, what do you think?",I think this should 
+8207,"@@ -12,7 +12,7 @@ namespace AutoRest.Core.Utilities
+     {
+         public void WriteFile(string path, string contents)
+         {
+-            File.WriteAllText(path, contents, Encoding.UTF8);
++            File.WriteAllText(path, contents, new UTF8Encoding(false, true));
+         }
+ 
+         /// <summary>",Suppresses UTF-8 BOM in outputs,Why is this change n
+8208,"@@ -65,10 +65,10 @@ type Config struct {
+ 	Inbounds  Inbounds
+ 	Outbounds Outbounds
+ 
+-	// Filter and Interceptor that will be applied to all outgoing and incoming
+-	// requests respectively.
+-	Filter      transport.Filter
+-	Interceptor transport.Interceptor
++	// Inbound and Outbound Middleware that will be applied to all outgoing and
++	// incoming requests respectively.
++	InboundMiddleware  InboundMiddleware
++	OutboundMiddleware OutboundMiddleware
+ 
+ 	Tracer opentracing.Tracer
+ }","order wrong for ""outgoing and incoming""",nit: `InboundMiddleware` -> `InboundMiddleware`
+8209,"@@ -43,6 +43,7 @@ public class MemoryCircuitBreaker extends CircuitBreaker {
+   private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+   private static final MemoryMXBean MEMORY_MX_BEAN = ManagementFactory.getMemoryMXBean();
+ 
++  private boolean isMemoryCircuitBreakerEnabled;
+   private final long heapMemoryThreshold;
+ 
+   // Assumption -- the value of these parameters will be set correctly before invoking getDebugInfo()","We know it's a boolean and it's in the MemoryCircuitBreaker, why not simply call it `enabled` (like many other Solr plugins do)?",This should be `final`.
+8210,"@@ -0,0 +1,5 @@
++class AddIncludesTeamToIndividualPlans < ActiveRecord::Migration
++  def change
++    add_column :individual_plans, :includes_team, :boolean, default: false
++  end
++end","Should team be a ""feature"" that can be ""included"" or a type? In code it seems to me that a `team` flag makes sense.",I'm not sure if this is the best name for this 
+8211,"@@ -172,6 +172,9 @@ type OutputInfo struct {
+ }
+ 
+ func (i *InputParams) updateParams(p *string) {
++	logParamsMutex.Lock()
++	defer logParamsMutex.Unlock()
++
+ 	if p == nil {
+ 		return
+ 	}",Why is this called update params when it's updating project info? Should p called project?,Why do we need this lock?
+8212,"@@ -44,7 +44,8 @@ const (
+ 	// below are templates for history_tree table
+ 	addHistoryTreeQuery = `INSERT INTO history_tree (` +
+ 		`shard_id, tree_id, branch_id, data, data_encoding) ` +
+-		`VALUES (:shard_id, :tree_id, :branch_id, :data, :data_encoding) `
++		`VALUES (:shard_id, :tree_id, :branch_id, :data, :data_encoding) ` +
++		`ON DUPLICATE KEY UPDATE data=VALUES(data), data_encoding=VALUES(data_encoding)`
+ 
+ 	getHistoryTreeQuery = `SELECT branch_id, data, data_encoding FROM history_tree WHERE shard_id = ? AND tree_id = ? `
+ ",`upsertHistoryTreeQuery` is a better name for this query now. Is it ok to change history?,Why do we need this?
+8213,"@@ -33,8 +33,12 @@ namespace Nethermind.Core
+             }
+             string date = DateTime.Now.ToString(""yyyyMMdd"");
+             string gitTag = File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-hash"")) ? File.ReadAllText(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-hash"")).Trim().Replace(""g"", """") : string.Empty;
+-
+-            Description = $""Nethermind/v{gitTag}-{date}/{RuntimeInformation.OSArchitecture}-{osDescription}/{RuntimeInformation.FrameworkDescription.Trim().Replace("".NET "", """").Replace("" "", """")}"";
++            string gitBranch = File.Exists(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-branch"")) ? File.ReadAllText(Path.Combine(AppDomain.CurrentDomain.BaseDirectory, ""git-branch"")).Trim().Replace(""/"", ""-"") : string.Empty;
++            if (gitBranch != ""master"")
++            {
++                gitTag = gitTag.Insert(5, ""b"");
++            }
++            Description = $""Nethermind/v{gitTag}-{date}/{gitBranch}/{RuntimeInformation.OSArchitecture}-{osDescription}/{RuntimeInformation.FrameworkDescription.Trim().Replace("".NET "", """").Replace("" "", """")}"";
+         }
+         
+         public static string Version { get; }",b did not mean branch - it meant the next version - so probably better to be able to release from a tag on the branch so we can create a hotfix branch of the 1.4.1 tag and tag it 1.4.1b and then version is picked as 1.4.1b,Why do we need this?
+8214,"@@ -9,7 +9,6 @@
+  *  Created on: Jul 26, 2017
+  *      Author: William F Godoy godoywf@ornl.gov
+  */
+-#include <mpi.h>
+ 
+ #include <ios>       //std::ios_base::failure
+ #include <iostream>  //std::cout","Keep the mpi.h include, just move it to after adios2.h and guard with the ifdef. Otherwise everything else looks good.",Why was this removed
+8215,"@@ -72,8 +72,12 @@ type Config struct {
+ 	// bind mounts are writtable.
+ 	Readonlyfs bool `json:""readonlyfs""`
+ 
+-	// Privatefs will mount the container's rootfs as private where mount points from the parent will not propogate
+-	Privatefs bool `json:""privatefs""`
++	// RootfsMountMode is the rootfs mount propagation mode.
++	// On linux it is one of the followings:
++	// ""private"": rootfs is mounted as MS_PRIVATE
++	// ""shared"": rootfs is mounted as MS_SHARED
++	// ""slave"": rootfs is mounted as MS_SLAVE
++	RootfsMountMode PropagationMode `json:""root_mount_mode""`
+ 
+ 	// Mounts specify additional source and destination paths that will be mounted inside the container's
+ 	// rootfs and mount namespace if specified",Shouldn't this be something like `rootmountmode` to fit the pattern of the other fields' serialized representations?,I think this should 
+8216,"@@ -747,9 +747,7 @@ void Cuda::impl_initialize(const Cuda::SelectDevice config,
+                            size_t /*num_instances*/) {
+   Impl::CudaInternal::singleton().initialize(config.cuda_device_id, 0);
+ 
+-#if defined(KOKKOS_ENABLE_PROFILING)
+   Kokkos::Profiling::initialize();
+-#endif
+ }
+ 
+ std::vector<unsigned> Cuda::detect_device_arch() {",Why were we initializing here in the first place?,Why is this removed?
+8217,"@@ -0,0 +1,7 @@
++namespace MvvmCross.Core.Platform.LogProviders
++{
++    internal sealed class NullLogProvider : MvxBaseLogProvider
++    {
++        protected override Logger GetLogger(string name) => new Logger((logLevel, messageFunc, exception, formatParameters) => true);
++    }
++}","This should be removed, and instead set the logger to None.",nit: rename to NullL
+8218,"@@ -49,7 +49,7 @@ function UndoRedo(instance) {
+       return;
+     }
+ 
+-    var originalData = plugin.instance.getSourceDataArray();
++    var originalData = plugin.instance.getSourceData();
+ 
+     index = (originalData.length + index) % originalData.length;
+ ",Storing a reference to source data isn't the best choice. Maybe you can find a different way (without storing the reference) to save removed data?,Why did you change t
+8219,"@@ -7761,7 +7761,7 @@ void UDR::processData(UDRInvocationInfo &info,
+  *
+  *  This method is called in debug Trafodion builds when certain
+  *  flags are set in the UDR_DEBUG_FLAGS CQD (CONTROL QUERY DEFAULT).
+- *  See https://wiki.trafodion.org/wiki/index.php/Tutorial:_The_object-oriented_UDF_interface#Debugging_UDF_code
++ *  See https://cwiki.apache.org/confluence/display/TRAFODION/Tutorial%3A+The+object-oriented+UDF+interface#Tutorial:Theobject-orientedUDFinterface-DebuggingUDFcode
+  *  for details.
+  *
+  *  The default implementation prints out the process id and then",Is the tutorial going to move to the new Trafodion website or will it stay on the Confluence wiki? (Check with Gunnar.),I'm not sure if this
+8220,"@@ -55,10 +55,8 @@ func FromStatus(st *status.Status) error {
+ 		switch errDetails := errDetails.(type) {
+ 		case *errordetails.ShardOwnershipLostFailure:
+ 			return newShardOwnershipLost(st, errDetails)
+-		case *errordetails.RetryTaskFailure:
+-			return newRetryTask(st, errDetails)
+ 		case *errordetails.RetryTaskV2Failure:
+-			return newRetryTaskV2(st, errDetails)
++			return convertRetryReplication(st, errDetails)
+ 		}
+ 	}
+ ",maybe call it `fromRetryTaskV2Failure`,Why do we need to convert here?
+8221,"@@ -16,11 +16,13 @@ package com.google.api.codegen.transformer.php;
+ 
+ import com.google.api.codegen.InterfaceView;
+ import com.google.api.codegen.config.FieldConfig;
++import com.google.api.codegen.config.FlatteningConfig;
+ import com.google.api.codegen.config.GapicProductConfig;
+ import com.google.api.codegen.config.GrpcStreamingConfig.GrpcStreamingType;
+ import com.google.api.codegen.metacode.InitCodeContext;
+ import com.google.api.codegen.metacode.InitCodeContext.InitCodeOutputType;
+ import com.google.api.codegen.php.PhpGapicCodePathMapper;
++import com.google.api.codegen.transformer.DynamicLangApiMethodTransformer;
+ import com.google.api.codegen.transformer.FileHeaderTransformer;
+ import com.google.api.codegen.transformer.GapicInterfaceContext;
+ import com.google.api.codegen.transformer.GapicMethodContext;","The diff for this class is difficult to walk through because I reorganized it to be much more clear. There are improvements throughout, but the most important are in the new `createSmokeTest.*` methods.",Why is this import needed?
+8222,"@@ -164,6 +164,12 @@ class BaseDetector(BaseModule, metaclass=ABCMeta):
+         should be double nested (i.e.  List[Tensor], List[List[dict]]), with
+         the outer list indicating test time augmentations.
+         """"""
++        img_norm_cfg = kwargs.get('img_norm_cfg', None)
++        if img_norm_cfg:
++            mean = torch.tensor(img_norm_cfg['mean'])[None, ..., None, None]
++            std = torch.tensor(img_norm_cfg['std'])[None, ..., None, None]
++            img = (img - mean) / std
++
+         if torch.onnx.is_in_onnx_export():
+             assert len(img_metas) == 1
+             return self.onnx_export(img[0], img_metas[0])",We suggest keeping this logic in lines between 173-175 to restrict its influence.,Why do we need this?
+8223,"@@ -88,7 +88,7 @@ class GridView
+      * @param string $name
+      * @param array $parameters
+      * @param bool $echo
+-     * @return string|null
++     * @return string|null|void
+      */
+     public function renderBlock($name, array $parameters = [], $echo = true)
+     {",why not ? maybe another phpstan plugin,Why not `string|null`?
+8224,"@@ -37,14 +37,16 @@ namespace Nethermind.JsonRpc.Modules.Trace
+         private readonly ITracer _tracer;
+         private readonly IBlockFinder _blockFinder;
+         private readonly TransactionDecoder _txDecoder = new TransactionDecoder();
+-        private readonly CancellationToken _cancellationToken; 
++        private readonly IJsonRpcConfig _jsonRpcConfig;
++        private readonly TimeSpan _cancellationTokenTimeout;
+ 
+-        public TraceModule(IReceiptFinder receiptFinder, ITracer tracer, IBlockFinder blockFinder, CancellationToken cancellationToken = default(CancellationToken))
++        public TraceModule(IReceiptFinder receiptFinder, ITracer tracer, IBlockFinder blockFinder, IJsonRpcConfig jsonRpcConfig)
+         {
+-            _cancellationToken = cancellationToken;
+             _receiptFinder = receiptFinder ?? throw new ArgumentNullException(nameof(receiptFinder));
+             _tracer = tracer ?? throw new ArgumentNullException(nameof(tracer));
+             _blockFinder = blockFinder ?? throw new ArgumentNullException(nameof(blockFinder));
++            _jsonRpcConfig = jsonRpcConfig ?? throw new ArgumentNullException(nameof(jsonRpcConfig));
++            _cancellationTokenTimeout = TimeSpan.FromMilliseconds(_jsonRpcConfig.TracerTimeout);
+         }
+ 
+         private static ParityTraceTypes GetParityTypes(string[] types)",That was a really bad CR from me before if I did not spot it.,nit: rename to `cancellationTokenTimeout`
+8225,"@@ -203,7 +203,15 @@ EOF
+ echo ""$FORSETI_ENV"" > $USER_HOME/forseti_env.sh
+ 
+ USER=ubuntu
+-(echo ""{run_frequency} $FORSETI_HOME/setup/gcp/scripts/run_forseti.sh"") | crontab -u $USER -
++
++# Use flock to prevent rerun of the same cron job when the previous job is still running.
++# If the lock file does not exist under the tmp directory, it will create the file and put a lock on top of the file.
++# When the previous cron job is not finished and the new one is trying to run, it will attempt to acquire the lock
++# to the lock file and fail because the file is already locked by the previous process.
++# The -n flag in flock will fail the process right away when the process is not able to acquire the lock so we won't
++# queue up the jobs.
++
++(echo ""{run_frequency} /usr/bin/flock -n /tmp/forseti_cron_runner.lock $FORSETI_HOME/setup/gcp/scripts/run_forseti.sh"") | crontab -u $USER -
+ echo ""Added the run_forseti.sh to crontab under user $USER""
+ 
+ echo ""Execution of startup script finished""","Does this resolve the scenario when the user-triggered forseti process is running, and it would be killed by the cron job restarting the server?",Shouldn't this be `/tmp/forseti_cron_runn
+8226,"@@ -157,7 +157,6 @@ func (ops *OpStream) Intc(constIndex uint) {
+ 	} else {
+ 		ops.trace(""intc %d %d"", constIndex, ops.intc[constIndex])
+ 	}
+-	ops.tpush(StackUint64)
+ }
+ 
+ // Uint writes opcodes for loading a uint literal",Does this happen somewhere else now?,Why was this removed?
+8227,"@@ -749,7 +749,8 @@ import browser from './browser';
+         }
+ 
+         // Support H264 Level 52 (Tizen 5.0) - app only
+-        if (browser.tizenVersion >= 5 && window.NativeShell) {
++        if ((browser.tizenVersion >= 5 && window.NativeShell) ||
++            videoTestElement.canPlayType('video/mp4; codecs=""avc1.640834""').replace(/no/, '')) {
+             maxH264Level = 52;
+         }
+ ","Remove trailing space at this line, amend the commit, and then force-push.",Why do we need to replace `no` with `''`?
+8228,"@@ -21,6 +21,8 @@ import (
+ 	""testing""
+ 	""time""
+ 
++	""go.opentelemetry.io/api/trace""
++
+ 	""google.golang.org/grpc/codes""
+ 
+ 	""go.opentelemetry.io/api/core""","This should be grouped together with the import of ""go.opentelemetry.io/{api/core,sdk/export}"" below.","""github.com/google/go-cmp/cmp"""
+8229,"@@ -66,10 +66,14 @@ REQUIREMENTS_MAP = {
+         {'module_name': 'instance_network_interface_scanner',
+          'class_name': 'InstanceNetworkInterfaceScanner',
+          'rules_filename': 'instance_network_interface_rules.yaml'},
++    'ke_scanner':
++        {'module_name': 'ke_scanner',
++         'class_name': 'KeScanner',
++         'rules_filename': 'ke_rules.yaml'},
+     'ke_version_scanner':
+         {'module_name': 'ke_version_scanner',
+          'class_name': 'KeVersionScanner',
+-         'rules_filename': 'ke_rules.yaml'},
++         'rules_filename': 'ke_version_rules.yaml'},
+     'log_sink':
+         {'module_name': 'log_sink_scanner',
+          'class_name': 'LogSinkScanner',","What's the impact to people upgrading to the new version? If they don't change their file names, they'll suddenly be broken. While I agree that your naming makes more intuitive sense, I think we need to maintain backwards compatibility. Please choose a new rules file name for the new scanner and keep ke_rules.yaml for the existing version scanner.",E225 missing whitespace around
+8230,"@@ -698,7 +698,7 @@ class InternalFrame(object):
+         index_spark_columns = self.index_spark_columns
+         return index_spark_columns + [
+             spark_column
+-            for label, spark_column in zip(self.column_labels, self.data_spark_columns)
++            for spark_column in self.data_spark_columns
+             if all(not spark_column._jc.equals(scol._jc) for scol in index_spark_columns)
+         ]
+ ","Shall we add some docstrings clearly to describe when to use which clearly? For example, `spark_frame` now should always be used via `df._internal.applied.spark_frame` for Spark DataFrame APIs that internally creates new query execution plan with the different output length. For expressions and/or functions, `df._internal.spark_frame` should be used together with Spark column instances, in order to avoid the operations on different DataFrames.",Why this change?
+8231,"@@ -54,8 +54,8 @@ class DataFrame(_Frame):
+         Dict can contain Series, arrays, constants, or list-like objects
+         If data is a dict, argument order is maintained for Python 3.6
+         and later.
+-        Note that if `data` is a Pandas DataFrame other arguments are ignored.
+-        If data is a Spark DataFrame, all other arguments except `index` is ignored.
++        Note that if `data` is a Pandas DataFrame, other arguments should not be used
++        If `data` is a Spark DataFrame, all other arguments except `index` should not be used.
+     index : Index or array-like
+         Index to use for resulting frame. Will default to RangeIndex if
+         no indexing information part of input data and no index provided",nit: `.` at the end of line?,I don't think this is correct.
+8232,"@@ -2012,7 +2012,16 @@ public class MessageListFragment extends Fragment implements OnItemClickListener
+ 
+     private void updateFooterView() {
+         if (!mSearch.isManualSearch() && mCurrentFolder != null && mAccount != null) {
+-            if (mCurrentFolder.loading) {
++            int msg=100;
++            try {
++                msg=mCurrentFolder.folder.getMessageCount();
++            } catch (MessagingException e) {
++                e.printStackTrace();
++            }
++            if (msg==0){
++                updateFooter(mContext.getString(R.string.no_email));
++            }
++            else if (mCurrentFolder.loading) {
+                 updateFooter(mContext.getString(R.string.status_loading_more));
+             } else if (!mCurrentFolder.moreMessages) {
+                 updateFooter(null);","I'm not sure I agree that this should take priority over ""Loading"".",Please use `Log` instead of `printStackTrace`.
+8233,"@@ -237,8 +237,6 @@ class PySparkTask(SparkSubmitTask):
+ 
+     # Path to the pyspark program passed to spark-submit
+     app = os.path.join(os.path.dirname(__file__), 'pyspark_runner.py')
+-    # Python only supports the client deploy mode, force it
+-    deploy_mode = ""client""
+ 
+     @property
+     def name(self):",Was this an intentional deletion? Why not just allow overwrite of `deploy_mode`?,Why is this removed?
+8234,"@@ -168,7 +168,16 @@ func (c *CStorVolumeReplicaController) syncHandler(
+ 	// Synchronize cstor volume total allocated and
+ 	// used capacity fields on CVR object.
+ 	// Any kind of sync activity should be done from here.
+-	c.syncCvr(cvrGot)
++	err = c.syncCvr(cvrGot)
++	if err != nil {
++		c.recorder.Event(
++			cvrGot,
++			corev1.EventTypeWarning,
++			""SyncFailed"",
++			fmt.Sprintf(""failed to sync CVR error: %s"", err.Error()),
++		)
++		return nil
++	}
+ 
+ 	_, err = c.clientset.
+ 		OpenebsV1alpha1().",better to call it as syncCVRStatus.. just syncCVR is very confusing,Why do we need to return here?
+8235,"@@ -29,11 +29,14 @@ var (
+ 	errAppDeleteCancelled = errors.New(""app delete cancelled - no changes made"")
+ )
+ 
+-type deleteAppOpts struct {
+-	// Flags or arguments that are user inputs.
++type deleteAppVars struct {
+ 	*GlobalOpts
+ 	SkipConfirmation bool
+ 	AppName          string
++}
++
++type deleteAppOpts struct {
++	deleteAppVars
+ 
+ 	// Interfaces to dependencies.
+ 	projectService   projectService",should we make this not a pointer? so that when we embed the struct a copy is made instead of modifying the original object.,Why is this exported?
+8236,"@@ -99,9 +99,9 @@ class BaseWebTest(object):
+     def get_app_settings(self, additional_settings=None):
+         settings = DEFAULT_SETTINGS.copy()
+ 
+-        settings['storage_backend'] = 'kinto.core.storage.redis'
+-        settings['cache_backend'] = 'kinto.core.cache.redis'
+-        settings['permission_backend'] = 'kinto.core.permission.redis'
++        settings['storage_backend'] = 'kinto_redis.storage'
++        settings['cache_backend'] = 'kinto_redis.cache'
++        settings['permission_backend'] = 'kinto_redis.permission'
+ 
+         settings['project_name'] = 'myapp'
+         settings['project_version'] = '0.0.1'",Does this mean that `kinto_redis` is required to run tests?,Why do we need to change these?
+8237,"@@ -475,7 +475,7 @@ function mergeBatchResults(batch, bulkResult, err, result) {
+   if (Array.isArray(result.writeErrors)) {
+     for (let i = 0; i < result.writeErrors.length; i++) {
+       const writeError = {
+-        index: batch.originalZeroIndex + result.writeErrors[i].index,
++        index: batch.originalIndexes[i],
+         code: result.writeErrors[i].code,
+         errmsg: result.writeErrors[i].errmsg,
+         op: batch.operations[result.writeErrors[i].index]",will this ensure the indexes for ordered writes as well?,I think this should be `batch.i
+8238,"@@ -28,7 +28,11 @@ from nupic.support.lockattributes import LockAttributesMixin
+ import functools
+ 
+ basicTypes = ['Byte', 'Int16', 'UInt16', 'Int32', 'UInt32', 'Int64', 'UInt64',
+-              'Real32', 'Real64', 'Handle']
++              'Real32', 'Real64', 'Handle', 'Bool']
++
++arrayTypes = ['ByteArray', 'Int16Array', 'UInt16Array', 'Int32Array',
++              'UInt32Array', 'Int64Array', 'UInt64Array', 'Real32Array',
++              'Real64Array', 'BoolArray']
+ 
+ pyRegions = (
+     (""nupic.regions.AnomalyRegion"", ""AnomalyRegion""),",Put `BoolArray` first?,Why do we need this?
+8239,"@@ -0,0 +1,3 @@
++window.appMode = 'standalone';
++
++import('./site');",I believe this whole file can be deleted now.,Why do we need this?
+8240,"@@ -34,6 +34,17 @@ var (
+ 		Usage: ""Port for listening incoming api requests"",
+ 		Value: 4050,
+ 	}
++
++	promiseCurrencyFlag = cli.StringFlag{
++		Name:  ""promise.currency"",
++		Usage: ""Type of currency that will be used for issuing promises"",
++		Value: ""MYST"",
++	}
++	promiseAmountFlag = cli.IntFlag{
++		Name:  ""promise.amount"",
++		Usage: ""Amount of money that will be used for issuing a single promise"",
++		Value: 100,
++	}
+ )
+ 
+ // RegisterFlagsNode function register node flags to flag list","We should specify format for a user. I.e: Integer, 1000 == 1 MYST",Why do we need this?
+8241,"@@ -132,6 +132,12 @@ func runControllers(ctx context.Context, config *Config) error {
+ 		}
+ 	}
+ 
++	for _, controller := range config.Controllers {
++		if err := controller(ctx, sc); err != nil {
++			return errors.Wrap(err, ""controller"")
++		}
++	}
++
+ 	if err := sc.Start(ctx); err != nil {
+ 		return err
+ 	}","Does the errors returned from these controllers indicate which controller threw the error? If not, there might be some value in making the ""CustomControllers"" type a `map[string]func(ctx context.Context, sc *server.Context) error` with the name of the controller as the key and include the key in this error string. This would apply for below as well.",Why do we need this?
+8242,"@@ -2204,8 +2204,13 @@ CheckedError Parser::DoParse(const char *source,
+       }
+       uoffset_t toff;
+       ECHECK(ParseTable(*root_struct_def_, nullptr, &toff));
+-      builder_.Finish(Offset<Table>(toff),
+-                file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      if (opts.prefix_size) {
++        builder_.FinishSizePrefixed(Offset<Table>(toff),
++                  file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      } else {
++        builder_.Finish(Offset<Table>(toff),
++                  file_identifier_.length() ? file_identifier_.c_str() : nullptr);
++      }
+     } else if (IsIdent(""enum"")) {
+       ECHECK(ParseEnum(false, nullptr));
+     } else if (IsIdent(""union"")) {",maybe at least pull the file identifier arg out of the if?,I'm not sure if this
+8243,"@@ -1028,17 +1028,13 @@ class CommandDispatcher:
+             raise cmdexc.CommandError(""Can't move tab to position {}!"".format(
+                 new_idx + 1))
+ 
+-        tab = self._current_widget()
+         cur_idx = self._current_index()
+-        icon = self._tabbed_browser.tabIcon(cur_idx)
+-        label = self._tabbed_browser.page_title(cur_idx)
+         cmdutils.check_overflow(cur_idx, 'int')
+         cmdutils.check_overflow(new_idx, 'int')
+         self._tabbed_browser.setUpdatesEnabled(False)
+         try:
+             color = self._tabbed_browser.tab_indicator_color(cur_idx)
+-            self._tabbed_browser.removeTab(cur_idx)
+-            self._tabbed_browser.insertTab(new_idx, tab, icon, label)
++            self._tabbed_browser.tabBar().moveTab(cur_idx, new_idx)
+             self._set_current_index(new_idx)
+             self._tabbed_browser.set_tab_indicator_color(new_idx, color)
+         finally:","You can most likely remove that (and the try/finally) too, as we shouldn't have any flickering from removing/inserting tabs anymore now.",I think this should 
+8244,"@@ -19,12 +19,15 @@ const localHooks = {
+    *
+    * @param {String} key Hook name.
+    * @param {Function} callback Hook callback
++   * @return {Object}
+    */
+   addLocalHook(key, callback) {
+     if (!this._localHooks[key]) {
+       this._localHooks[key] = [];
+     }
+     this._localHooks[key].push(callback);
++
++    return this;
+   },
+ 
+   /**",Could you add `s` to `@return`?,Why do we need to return this?
+8245,"@@ -57,11 +57,10 @@ module Selenium
+               is_relative = Regexp.last_match(1).strip == '1'
+             when /^Path=(.+)$/
+               path = Regexp.last_match(1).strip
++              p = path_for(name, is_relative, path)
++              @profile_paths[name] = p if p
+             end
+           end
+-
+-          p = path_for(name, is_relative, path)
+-          @profile_paths[name] = p if p
+         end
+ 
+         def path_for(name, is_relative, path)",Moving this code inside the last case statement doesn't seem right. Why are we defining `name` and `is_relative` variables there if we aren't using them anywhere?,Why did you remove this line?
+8246,"@@ -290,9 +290,16 @@ func (at *addrTable) getAddrTable(key string) *serviceTable {
+ // filterResourceType implement filter. Proxy cares ""Service"" and ""ServiceList"" type
+ func filterResourceType(msg model.Message) []v1.Service {
+ 	svcs := make([]v1.Service, 0)
+-	content, ok := msg.Content.([]byte)
+-	if !ok {
+-		return svcs
++	var content []byte
++	var err error
++	switch msg.Content.(type) {
++	case []byte:
++		content = msg.GetContent().([]byte)
++	default:
++		content, err = json.Marshal(msg.GetContent())
++		if err != nil {
++			klog.Errorf(""marshal message to edgemesh failed, err: %v"", err)
++		}
+ 	}
+ 	switch getReourceType(msg.GetResource()) {
+ 	case constants.ResourceTypeService:",Will cause any bugs without this change? I've seen this code block(L293-302) many times... ;-),Why do we need this switch?
+8247,"@@ -82,6 +82,11 @@ namespace NLog
+         /// </summary>
+         public LogFactory Factory { get; private set; }
+ 
++        /// <summary>
++        /// Properties added with <see cref=""WithProperty""/> or <see cref=""SetProperty""/>
++        /// </summary>
++        public IDictionary<string, object> Properties => _contextProperties ?? new Dictionary<string, object>();
++
+         /// <summary>
+         /// Gets a value indicating whether logging is enabled for the specified level.
+         /// </summary>",You are opening a door to race-condition-hell by returning an unprotected dictionary. I recommend that you return `IReadOnlyDictionary` that only works on the platforms where it is known.,Why do we need this?
+8248,"@@ -4367,7 +4367,7 @@ describe('Cursor', function() {
+     }
+   );
+ 
+-  it('should return a promise when no callback supplied to forEach method', function(done) {
++  it.skip('should return a promise when no callback supplied to forEach method', function(done) {
+     const configuration = this.configuration;
+     const client = configuration.newClient({ w: 1 }, { poolSize: 1, auto_reconnect: false });
+ ",also seems we should not skip this test,Why are we skipping this test?
+8249,"@@ -31,14 +31,17 @@ import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
+ 
+ class BaseFileScanTask implements FileScanTask {
+   private final DataFile file;
++  private final DeleteFile[] deletes;
+   private final String schemaString;
+   private final String specString;
+   private final ResidualEvaluator residuals;
+ 
+   private transient PartitionSpec spec = null;
+ 
+-  BaseFileScanTask(DataFile file, String schemaString, String specString, ResidualEvaluator residuals) {
++  BaseFileScanTask(DataFile file, DeleteFile[] deletes, String schemaString, String specString,
++                   ResidualEvaluator residuals) {
+     this.file = file;
++    this.deletes = deletes != null ? deletes : new DeleteFile[0];
+     this.schemaString = schemaString;
+     this.specString = specString;
+     this.residuals = residuals;","This is mostly for my understanding: is `DeleteFile[] deletes` a mandatory builder param now for file scan tasks? If not, from a v1 / v2 compatibility standpoint would it make sense to add an overloaded constructor?",Why do we need this change?
+8250,"@@ -123,6 +123,16 @@ public class ExecutionFlowDao {
+     }
+   }
+ 
++  public List<Pair<ExecutionReference, ExecutableFlow>> fetchAgedQueuedFlows(final Duration minAge)
++      throws ExecutorManagerException {
++    try {
++      return this.dbOperator.query(FetchAgedQueuedExecutableFlows.FETCH_FLOWS_QUEUED_FOR_LONG_TIME,
++          new FetchQueuedExecutableFlows(), System.currentTimeMillis() - minAge.toMillis());
++    } catch (final SQLException e) {
++      throw new ExecutorManagerException(""Error fetching active flows"", e);
++    }
++  }
++
+   /**
+    * fetch flow execution history with specified {@code projectId}, {@code flowId} and flow start
+    * time >= {@code startTime}","Can the error message reflect the purpose of the query more closely? Something like ""Error fetching executions queued for a long time""",nit: `fetchQueuedFlows` -> `fe
+8251,"@@ -60,7 +60,7 @@ func (c *CreateInstances) validate(w *Workflow) error {
+ 		}
+ 
+ 		// Startup script checking.
+-		if !sourceExists(ci.StartupScript) {
++		if ci.StartupScript != """" && !w.sourceExists(ci.StartupScript) {
+ 			return fmt.Errorf(""cannot create instance: file not found: %s"", ci.StartupScript)
+ 		}
+ ",Are you making it so startup script HAS to be in sources?,Shouldn't this be `!=`?
+8252,"@@ -128,7 +128,9 @@ void l2_weight_regularization::start_evaluation() {
+       if (vals.Participating()
+           && vals.GetLocalDevice() == El::Device::GPU
+           && vals.RedundantRank() == i % vals.RedundantSize()) {
+-        if (vals.LDim() == vals.LocalHeight()) {
++        if (vals.LocalWidth() < 1 || vals.LocalHeight() < 1) {
++        } else if (vals.LocalWidth() == 1
++                   || vals.LDim() == vals.LocalHeight()) {
+           cublas::dot(handle,
+                       vals.LocalHeight() * vals.LocalWidth(),
+                       vals.LockedBuffer(), 1,",Might be more clear to just have one if statement?,I don't think this is correct. It should be `if (vals.LocalWidth() == 1 && vals.LocalHeight() == 1)`.
+8253,"@@ -87,7 +87,7 @@ class SparkReader:
+         try:
+             response_handler(response)
+         except Exception as e:
+-            current_app.logger.error('Error in the response handler: %s, data: %s %'
++            current_app.logger.error('Error in the response handler: %s, data: %s' %
+                                      (str(e), json.dumps(response, indent=4)), exc_info=True)
+             return
+ ","remember that logger methods will do string interpolation automatically anyway, so you should be able to do `logger.error('message %s', var, exc_info=True)`",line too long (81 > 79 characters)
+8254,"@@ -350,6 +350,7 @@ private:
+   void render_sync_handler_failed_default_exception_branch(t_function *tfunc);
+   void render_sync_handler_send_exception_response(t_function *tfunc, const string &err_var);
+   void render_service_call_structs(t_service* tservice);
++  void render_args_struct(t_function* tfunc);
+   void render_result_value_struct(t_function* tfunc);
+ 
+   string handler_successful_return_struct(t_function* tfunc);",Perhaps rename to `render_service_args_struct`?,Why do we need this function?
+8255,"@@ -11,8 +11,8 @@ import (
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/cborutil""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/chain""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/consensus""
++	crypto2 ""github.com/filecoin-project/go-filecoin/internal/pkg/crypto""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/repo""
+-	""github.com/filecoin-project/go-filecoin/internal/pkg/types""
+ 	""github.com/filecoin-project/go-filecoin/internal/pkg/wallet""
+ )
+ ",clean the name,I think this should be `crypto2`
+8256,"@@ -70,6 +70,13 @@ func (a BrokerMetricAssertion) Assert(client *monitoring.MetricClient) error {
+ 		if err != nil {
+ 			return fmt.Errorf(""metric has invalid response code label: %v"", ts.GetMetric())
+ 		}
++
++		// Workarounds to reduce test flakiness caused by sender pod retry sending events (which will cause unexpected response code).
++		// We should remove it after https://github.com/google/knative-gcp/issues/1058 lands
++		if code == http.StatusForbidden || code == http.StatusServiceUnavailable || code == http.StatusInternalServerError {
++			continue
++		}
++
+ 		if code != http.StatusAccepted {
+ 			return fmt.Errorf(""metric has unexpected response code: %v"", ts.GetMetric())
+ 		}",I think we would expect StatusNotFound instead of StatusForbidden?,nit: can you add a TODO to remove this once the issue is fixed?
+8257,"@@ -241,9 +241,11 @@ static int rexec_output (flux_subprocess_t *p,
+                          bool eof)
+ {
+     json_t *io = NULL;
++    char rankstr[64];
+     int rv = -1;
+ 
+-    if (!(io = ioencode (stream, s->rank, data, len, eof))) {
++    snprintf (rankstr, sizeof (rankstr), ""%d"", s->rank);
++    if (!(io = ioencode (stream, rankstr, data, len, eof))) {
+         flux_log_error (s->h, ""%s: ioencode"", __FUNCTION__);
+         goto error;
+     }","Since this is a recurring theme, would it make sense to have an ioencode interface for it like `ioencode_rank()` that takes an integer rank like before?",`sizeof (rankstr)` should be `sizeof (s->rank)`
+8258,"@@ -192,8 +192,10 @@ func contains(capabilities []string, capability string) bool {
+ // object
+ func (agent *ecsAgent) initializeResourceFields() {
+ 	agent.resourceFields = &taskresource.ResourceFields{
+-		Control: cgroup.New(),
+-		IOUtil:  ioutilwrapper.NewIOUtil(),
++		Control:      cgroup.New(),
++		IOUtil:       ioutilwrapper.NewIOUtil(),
++		Ctx:          agent.ctx,
++		DockerClient: agent.dockerClient,
+ 	}
+ }
+ ",Is it a concern that we initialize these fields irrespective of whether resources like cgroup/volumes are enabled or not?,Why do we need a new context here?
+8259,"@@ -109,10 +109,13 @@ func NewDispatcher(cfg Config) Dispatcher {
+ 
+ // convertOutbounds applys outbound middleware and creates validator outbounds
+ func convertOutbounds(outbounds Outbounds, middleware OutboundMiddleware) Outbounds {
+-	//TODO(apb): ensure we're not given the same underlying outbound for each RPC type
+ 	convertedOutbounds := make(Outbounds, len(outbounds))
+ 
+ 	for service, outs := range outbounds {
++		if outs.Unary == nil && outs.Oneway == nil {
++			panic(fmt.Sprintf(""no outbound set for service %q in dispatcher"", service))
++		}
++
+ 		var (
+ 			unaryOutbound  transport.UnaryOutbound
+ 			onewayOutbound transport.OnewayOutbound",Wouldn't this be the first panic in yarpc? What do we do for transport validation? Return errors?,Why panic instead of returning an error?
+8260,"@@ -26,6 +26,7 @@ import (
+ type processor interface {
+ 	process(ctx context.Context) error
+ 	traceLogs() []string
++	cancel(reason string)
+ }
+ 
+ // processorProvider allows the processor to be determined after the pd has been inflated.",have you envisioned other cancellation reasons?,Why do we need this interface?
+8261,"@@ -395,8 +395,10 @@ final class SonataMediaExtension extends Extension implements PrependExtensionIn
+     /**
+      * Checks if the classification of media is enabled.
+      *
+-     * @param array<string, class-string> $bundles
+-     * @param array<string, mixed>        $config
++     * @param array<string, string> $bundles
++     * @param array<string, mixed>  $config
++     *
++     * @phpstan-param array<string, class-string> $bundles
+      */
+     private function isClassificationEnabled(array $bundles, array $config): bool
+     {","For the record, class-string is now suported by PHPStorm. Don't know if it's worth moving it to `@phpstan-param` then.",Why did you change this?
+8262,"@@ -2085,7 +2085,10 @@ class CommandDispatcher:
+                 raise cmdexc.CommandError(str(e))
+ 
+         widget = self._current_widget()
+-        widget.run_js_async(js_code, callback=jseval_cb, world=world)
++        try:
++            widget.run_js_async(js_code, callback=jseval_cb, world=world)
++        except OverflowError:
++            raise cmdexc.CommandError(""World Id not in valid range"")
+ 
+     @cmdutils.register(instance='command-dispatcher', scope='window')
+     def fake_key(self, keystring, global_=False):","This prevents negative IDs, but it doesn't check for too large IDs. You should probably just do the same check you do for `QWebengineScript` here as well.",This should be a `CommandError
+8263,"@@ -18,6 +18,7 @@ const (
+ 	// Command specific flags.
+ 	dockerFileFlag        = ""dockerfile""
+ 	imageTagFlag          = ""tag""
++	awsTagsFlag           = ""tags""
+ 	stackOutputDirFlag    = ""output-dir""
+ 	limitFlag             = ""limit""
+ 	followFlag            = ""follow""",This might be very confusing. Maybe `resource-tags`? I,Nit: `awsTags` -> `awsTags`
+8264,"@@ -283,6 +283,7 @@ class DeformConvPack(DeformConv):
+             kernel_size=self.kernel_size,
+             stride=_pair(self.stride),
+             padding=_pair(self.padding),
++            dilation=self.dilation,
+             bias=True)
+         self.init_offset()
+ ",We may use `_pair` to wrap `dilation`.,Why do we need this?
+8265,"@@ -286,15 +286,9 @@ func createLibcontainerConfig(cgroupName string, spec *specs.LinuxSpec) (*config
+ 		return nil, err
+ 	}
+ 	config.Cgroups = c
+-	if config.Readonlyfs {
+-		setReadonly(config)
+-		config.MaskPaths = []string{
+-			""/proc/kcore"",
+-		}
+-		config.ReadonlyPaths = []string{
+-			""/proc/sys"", ""/proc/sysrq-trigger"", ""/proc/irq"", ""/proc/bus"",
+-		}
+-	}
++	// set extra path masking for libcontainer for the various unsafe places in proc
++	config.MaskPaths = maskedPaths
++	config.ReadonlyPaths = readonlyPaths
+ 	seccomp, err := setupSeccomp(&spec.Linux.Seccomp)
+ 	if err != nil {
+ 		return nil, err",what's with `setReadonly`? Why we deleted it totally?,Why do we need to se
+8266,"@@ -121,12 +121,7 @@ CXXToken * cxxTagSetTypeField(
+ {
+ 	CXX_DEBUG_ASSERT(tag && pTypeStart && pTypeEnd,""Non null parameters are expected"");
+ 
+-	const char * szTypeRef0;
+-
+-	// ""typename"" is debatable since it's not really
+-	// allowed by C++ for unqualified types. However I haven't been able
+-	// to come up with something better... so ""typename"" it is for now.
+-	static const char * szTypename = ""typename"";
++	const char * szTypeRef0 = NULL;
+ 
+ 	if(pTypeStart != pTypeEnd)
+ 	{","Currently I think this is not acceptable. I think the value should be chosen by the author of the parser. (Personally ""type"" is better than ""typename"".)",Why did you remove t
+8267,"@@ -13,6 +13,7 @@
+ 
+ package machine
+ 
++// should not need to import the ec2 sdk here
+ import (
+ 	""fmt""
+ ",Is this excessive?,
+8268,"@@ -251,7 +251,7 @@ main(int argc, char *argv[])
+        * sysroot, we still need a writable /etc.  And to avoid race conditions
+        * we ensure it's writable in the initramfs, before we switchroot at all.
+        */
+-      if (mount (""/etc"", ""/etc"", NULL, MS_BIND, NULL) < 0)
++      if (mount (""etc"", ""etc"", NULL, MS_BIND, NULL) < 0)
+         err (EXIT_FAILURE, ""failed to make /etc a bind mount"");
+       /* Pass on the fact that we discovered a readonly sysroot to ostree-remount.service */
+       int fd = open (_OSTREE_SYSROOT_READONLY_STAMP, O_WRONLY | O_CREAT | O_CLOEXEC, 0644);","Ohhhh I see, this change was previously having *no effect* - I had thought you meant we were doing something like bind mounting the initramfs' `/etc` as the real `/etc` but we'd clearly notice if that happened, we'd be missing all sorts of config files etc.",Why is this change needed?
+8269,"@@ -133,6 +133,15 @@ abstract class SnapshotProducer<ThisT> implements SnapshotUpdate<ThisT> {
+    */
+   protected abstract String operation();
+ 
++  /**
++   * A Long that write sequenceNumber in manifest-list file.
++   *
++   * @return a string operation
++   */
++  protected Long sequenceNumber() {
++    return null;
++  }
++
+   /**
+    * Validate the current metadata.
+    * <p>","I think this needs a more specific name, like `sequenceNumberOverride`",I don't think we need this
+8270,"@@ -39,7 +39,8 @@ module Blacklight
+     when /::/
+       connection_config[:adapter].constantize
+     else
+-      Blacklight.const_get(""#{connection_config[:adapter]}/Repository"".classify)
++      raise ""The value for :adapter was not found in the blacklight.yml config"" unless connection_config.key? :adapter
++      Blacklight.const_get(""#{connection_config.fetch(:adapter)}/Repository"".classify)
+     end
+   end
+ ",Ought we just raise an exception if the adapter isn't defined?,Line is too long. [81/80]
+8271,"@@ -5,7 +5,6 @@ var stsLegacyGlobalRegions = map[string]struct{}{
+ 	""ap-south-1"":     {},
+ 	""ap-southeast-1"": {},
+ 	""ap-southeast-2"": {},
+-	""aws-global"":     {},
+ 	""ca-central-1"":   {},
+ 	""eu-central-1"":   {},
+ 	""eu-north-1"":     {},","Should this have been removed? We still set the region to ""aws-global"" in v3model.go#L115",Why was this removed?
+8272,"@@ -335,14 +335,15 @@ def setup_logging(config):
+                 errno=errors.ERRORS.INVALID_PARAMETERS,
+                 message='Invalid URL path.')
+ 
++        qs = dict(errors.request_GET(request))
+         request.log_context(agent=request.headers.get('User-Agent'),
+                             path=request_path,
+                             method=request.method,
+-                            querystring=dict(errors.request_GET(request)),
++                            querystring=(qs if len(qs) else None),
+                             lang=request.headers.get('Accept-Language'),
+                             uid=None,
+                             authn_type=None,
+-                            errno=None)
++                            errno=0)
+ 
+     config.add_subscriber(on_new_request, NewRequest)
+ ","You could shorten this to `qs or None`. But why not just build a dict of parameters we want to include and only add `querystring` if there's something here, similar to the way you do in the error view?",I don't think you need the `if len(qs)`.
+8273,"@@ -31,15 +31,9 @@ func (c *client) acquireTopologyCacheLock(ctx context.Context) {
+ 	}
+ 	defer conn.Close()
+ 
+-	go func() {
+-		<-ctx.Done()
+-		ticker.Stop()
+-		c.unlockAdvisoryLock(context.Background(), conn, advisoryLockId)
+-	}()
+-
+ 	// Infinitely try to acquire the advisory lock
+ 	// Once the lock is acquired we start caching, this is a blocking operation
+-	for ; true; <-ticker.C {
++	for {
+ 		c.log.Info(""trying to acquire advisory lock"")
+ 
+ 		// TODO: We could in the future spread the load of the topology caching","sorry if I'm missing it somewhere else in the code, but do you need to create a `ticker := time.NewTicker`?",Why is this being removed?
+8274,"@@ -44,7 +44,11 @@ import (
+ func TestNew(t *testing.T) {
+ 	ctx, _ := SetupFakeContext(t)
+ 
+-	c := NewController(ctx, configmap.NewStaticWatcher(
++	dataresidencySs := &dataresidency.StoreSingleton{}
++
++	ctor := NewConstructor(dataresidencySs)
++
++	c := ctor(ctx, configmap.NewStaticWatcher(
+ 		&corev1.ConfigMap{
+ 			ObjectMeta: metav1.ObjectMeta{
+ 				Name:      logging.ConfigMapName(),","Inline this, as we don't use it again.",nit: `dataresidencySs` -> `dataresidency
+8275,"@@ -39,7 +39,9 @@ exclude = [""ForwardFFTImageFilter"",
+            ""templated_class"",
+            ""HalfHermitianToRealInverseFFTImageFilter"",
+            ""RealToHalfHermitianForwardFFTImageFilter"",
+-           ""CustomColormapFunction""]
++           ""CustomColormapFunction"",
++           ""ScanlineFilterCommon""  # Segfault
++           ]
+ 
+ wrongName = 0
+ totalName = 0",I think the instantiation of the new objects i.New() and T.New() need to be done in a function to have local variable and reduce the amount of memory used.,I think this should be `ScatterlineFilte
+8276,"@@ -40,6 +40,8 @@ namespace pwiz.Skyline.Model.Hibernate
+         public const string Mz = ""0.####"";
+         public const string SamplingTime = ""0.00"";
+         public const string OneOverK0 = ""0.####"";
++
++        public const string IonMobility = ""0.#####"";
+         // ReSharper restore LocalizableElement
+     }
+ }",This is probably more digits than needed - perhaps rename OneOverK0 to IonMobility instead,">IonMobility [](start = 27, length = 11) I'm not sure if this is the right way to do it. I think it should be `IonMobility`"
+8277,"@@ -25,5 +25,8 @@ public enum ApiMethodType {
+   CallableMethod,
+   // PHP
+   OptionalArrayMethod,
+-  PagedOptionalArrayMethod
++  PagedOptionalArrayMethod,
++  // C#
++  FlattenedMethodAsyncCallSettings,
++  FlattenedMethodAsyncCancellationToken,
+ }","End with 'Method', so: - FlattenedAsyncCallSettingsMethod - FlattenedAsyncCancellationTokenMethod",I don't think this is needed.
+8278,"@@ -22,6 +22,7 @@ import (
+ 
+ 	cloudkms ""cloud.google.com/go/kms/apiv1""
+ 	""gocloud.dev/gcp""
++	""gocloud.dev/internal/secrets""
+ 	""google.golang.org/api/option""
+ 	kmspb ""google.golang.org/genproto/googleapis/cloud/kms/v1""
+ )",`localsecrets` should be updated in the same way.,Please remove this empty line.
+8279,"@@ -94,13 +94,18 @@ const ConsensusV17 = ConsensusVersion(
+ 	""https://github.com/algorandfoundation/specs/tree/5615adc36bad610c7f165fa2967f4ecfa75125f0"",
+ )
+ 
++// ConsensusV18 adds the ability to issue a transaction that marks an account non-participating
++const ConsensusV18 = ConsensusVersion(
++	""---->!!!TODO!!!<----"",
++)
++
+ // !!! ********************* !!!
+ // !!! *** Please update ConsensusCurrentVersion when adding new protocol versions *** !!!
+ // !!! ********************* !!!
+ 
+ // ConsensusCurrentVersion is the latest version and should be used
+ // when a specific version is not provided.
+-const ConsensusCurrentVersion = ConsensusV17
++const ConsensusCurrentVersion = ConsensusV18
+ 
+ // ConsensusTest0 is a version of ConsensusV0 used for testing
+ // (it has different approved upgrade paths).",We'll want to PR a spec change into github.com/algorandfoundation/specs. (Side note: It might or might not make sense to combine this protocol upgrade with Tsachi's protocol upgrade for fixing the reward rate calculation.),Why is this a TODO?
+8280,"@@ -30,7 +30,7 @@ func (w *DefaultWorker) Generate(
+ 	nullBlockCount abi.ChainEpoch,
+ 	posts []block.PoStProof,
+ 	drandEntries []*drand.Entry,
+-) Output {
++) (*block.Block, []*types.SignedMessage, []*types.SignedMessage, error) {
+ 
+ 	generateTimer := time.Now()
+ 	defer func() {","Use `FullBlock`, it comes from the same package.",Why do we need to return an error here?
+8281,"@@ -1,9 +1,13 @@
++import abc
+ import json
+ import logging
+ import time
+ from concurrent.futures import ThreadPoolExecutor
++from typing import Collection, Dict, Optional
+ 
+ import requests
++from flask import Request
++from readerwriterlock import rwlock
+ 
+ from localstack import config
+ from localstack.utils.bootstrap import canonicalize_api_names","do we plan to use anything else than flask for making HTTP requests inside localstack? if so, it maybe makes sense not to strongly couple to flask for now, and just leave the type of the `request` function parameters open for now.",I'm not sure if this is the best way to
+8282,"@@ -143,9 +143,17 @@ func (verifyContentLanguage) ErrorCheck(b *blob.Bucket, err error) error {
+ }
+ 
+ func (verifyContentLanguage) BeforeWrite(as func(interface{}) bool) error {
++	var objp **storage.ObjectHandle
++	if !as(&objp) {
++		return errors.New(""Writer.As failed to get ObjectHandle"")
++	}
++	// Replace the ObjectHandle with a new one that adds Conditions
++	// (this condition will always be true).
++	*objp = (*objp).If(storage.Conditions{DoesNotExist: true})
++
+ 	var sw *storage.Writer
+ 	if !as(&sw) {
+-		return errors.New(""Writer.As failed"")
++		return errors.New(""Writer.As failed to get Writer"")
+ 	}
+ 	sw.ContentLanguage = language
+ 	return nil","I think we should make this a separate test case: it seems like making the precondition fail is the test case that would ensure that this escape hatch worked. Otherwise, if it's always true, then it would be the same as if the escape hatch didn't modify the outgoing request.",Why is this needed?
+8283,"@@ -62,6 +62,13 @@ func (s *Server) Start(ctx context.Context) error {
+ 		return errors.Wrap(err, ""error when subscribe to block"")
+ 	}
+ 
++	// sync genesis block
++	genesisBlk, err := s.bc.GetBlockByHeight(0)
++	if err != nil {
++		return errors.Wrap(err, ""error when get genesis block"")
++	}
++	s.idx.BuildIndex(genesisBlk)
++
+ 	go func() {
+ 		for {
+ 			select {",Error return value of `s.idx.BuildIndex` is not checked,Why do we need to build the index here?
+8284,"@@ -36,6 +36,8 @@ def gen_classes():
+             pass
+         elif member is configtypes.MappingType:
+             pass
++        elif member in [configtypes.List, configtypes.LengthList]:
++            pass
+         elif member is configtypes.FormatString:
+             yield functools.partial(member, fields=['a', 'b'])
+         elif issubclass(member, configtypes.BaseType):",What's the reason for excluding those from the fuzzing here? You probably could just add some inner type via `functools.partial` like below with `FormatString`.,Why is this needed?
+8285,"@@ -3,6 +3,6 @@ require 'spec_helper'
+ describe Api::V1::UsersController, '#show' do
+   it 'returns a 401 when users are not authenticated' do
+     get :show
+-    response.code.should eq '401'
++    expect(response.code).to eq '401'
+   end
+ end",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [
+8286,"@@ -14,7 +14,7 @@ import (
+ )
+ 
+ func killContainer(container libcontainer.Container) error {
+-	container.Signal(syscall.SIGKILL, false)
++	_ = container.Signal(syscall.SIGKILL, false)
+ 	for i := 0; i < 100; i++ {
+ 		time.Sleep(100 * time.Millisecond)
+ 		if err := container.Signal(syscall.Signal(0), false); err != nil {",Its this golint or govet stuff?,Why is this needed?
+8287,"@@ -232,10 +232,9 @@ insert(hash_table_t table, app_pc addr, cbr_state_t state)
+ static void
+ at_taken(app_pc src, app_pc targ)
+ {
+-    dr_mcontext_t mcontext = {
+-        sizeof(mcontext),
+-        DR_MC_ALL,
+-    };
++    dr_mcontext_t mcontext;
++    mcontext.size = sizeof(mcontext);
++    mcontext.flags = DR_MC_ALL;
+     void *drcontext = dr_get_current_drcontext();
+ 
+     /*","These are good cleanups: I didn't realize there were so many like this in the samples and tests. But given that there are quite of few of these mcontext changes I would separate these into their own PR (no need for an issue: iX branch) since they are logically distinct. Cleaner history, simpler revert paths, etc.",Why is this needed?
+8288,"@@ -0,0 +1,18 @@
++// Copyright (c) Six Labors.
++// Licensed under the Apache License, Version 2.0.
++
++using BenchmarkDotNet.Attributes;
++
++using SixLabors.ImageSharp.PixelFormats;
++
++namespace SixLabors.ImageSharp.Benchmarks
++{
++    public class ColorEquality
++    {
++        [Benchmark(Description = ""ImageSharp Color Equals"")]
++        public bool ColorEqual()
++        {
++            return new Rgba32(128, 128, 128, 128).Equals(new Rgba32(128, 128, 128, 128));
++        }
++    }
++}","  This is just a random struct equality, no value here.",I'm not sure if this is the best way to do this. I think it would be better to use `ImageSharp.Rgba32.Equals(ImageSharp.Rgba32)`.
+8289,"@@ -180,6 +180,7 @@ type Config struct {
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail""`
+ 
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
++	NatPortRange       numorstring.Port   `config:""portrange;;local""`
+ 
+ 	UsageReportingEnabled          bool          `config:""bool;true""`
+ 	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`",Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only,nit: `NatPortRange` -> `NatPortRange`
+8290,"@@ -8,8 +8,12 @@ except ImportError:
+ import numpy as np
+ import param
+ 
+-from ..dimension import redim
+-from ..util import unique_iterator
++from ..dimension import redim, Dimension, process_dimensions
++from ..element import Element
++from ..ndmapping import OrderedDict
++from ..spaces import HoloMap, DynamicMap
++from ..util import (basestring, dimension_range as d_range, get_param_values,
++                    isfinite, process_ellipses, unique_iterator, wrap_tuple)
+ from .interface import Interface, iloc, ndloc
+ from .array import ArrayInterface
+ from .dictionary import DictInterface","I had some weird issues when importing ``from .. import util`` getting the wrong utilities, hence I did this.",I don't think you need `as d_range`
+8291,"@@ -1,8 +1,8 @@
+-#NVDAObjects/WinConsole.py
+-#A part of NonVisual Desktop Access (NVDA)
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
+-#Copyright (C) 2007-2019 NV Access Limited, Bill Dengler
++# NVDAObjects/WinConsole.py
++# A part of NonVisual Desktop Access (NVDA)
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
++# Copyright (C) 2007-2020 NV Access Limited, Bill Dengler
+ 
+ import winConsoleHandler
+ from . import Window",Please remove this line.,Why did you remove the copyright?
+8292,"@@ -324,7 +324,8 @@ module Beaker
+           # exit codes at the host level and then raising...
+           # is it necessary to break execution??
+           if options[:accept_all_exit_codes] && options[:acceptable_exit_codes]
+-            @logger.warn "":accept_all_exit_codes & :acceptable_exit_codes set. :accept_all_exit_codes overrides, but they shouldn't both be set at once""
++            @logger.warn "":accept_all_exit_codes & :acceptable_exit_codes set. :acceptable_exit_codes overrides, but they shouldn't both be set at once""
++            options[:accept_all_exit_codes] = false
+           end
+           if !options[:accept_all_exit_codes] && !result.exit_code_in?(Array(options[:acceptable_exit_codes] || [0, nil]))
+             raise CommandFailure, ""Host '#{self}' exited with #{result.exit_code} running:\n #{cmdline}\nLast #{@options[:trace_limit]} lines of output were:\n#{result.formatted_output(@options[:trace_limit])}""",should this state that we're falling back to `:acceptable_exit_codes`?,I think this should be `options[:accept_all_exit_codes] = true`
+8293,"@@ -87,6 +87,16 @@ def df_type_check(_, value):
+         success=True,
+         metadata_entries=[
+             EventMetadataEntry.text(str(len(value)), 'row_count', 'Number of rows in DataFrame'),
++            EventMetadataEntry.text(str(value.shape), ""shape"", ""The shape of the DataFrame.""),
++            EventMetadataEntry.md(
++                value.dtypes.to_markdown(), ""dtypes"", ""The dtypes within the DataFrame.""
++            ),
++            EventMetadataEntry.md(
++                dataframe.head().to_markdown(), ""head"", ""A preview of the first 5 rows.""
++            ),
++            EventMetadataEntry.md(
++                dataframe.tail().to_markdown(), ""tail"", ""A preview of the last 5 rows.""
++            ),
+             # string cast columns since they may be things like datetime
+             EventMetadataEntry.json({'columns': list(map(str, value.columns))}, 'metadata'),
+         ],",I don't think this works. The dataframe object is encapsulated in the value parameter. This might be the root of the failing checks.,I'm not sure if this is the right way to do this. I think it wo
+8294,"@@ -163,7 +163,7 @@ class TopologyDescription {
+     }
+ 
+     if (topologyType === TopologyType.Unknown) {
+-      if (serverType === ServerType.Standalone) {
++      if (serverType === ServerType.Standalone && this.servers.size !== 1) {
+         serverDescriptions.delete(address);
+       } else {
+         topologyType = topologyTypeForServerType(serverType);",Why was it necessary to add this check against `this.servers.size`?,Why do we need this change?
+8295,"@@ -61,6 +61,11 @@ std::string getWrongOptionHelp(const engine::api::TableParameters &parameters)
+         help = ""fallback_speed must be > 0"";
+     }
+ 
++    if (parameters.scale_factor < 0)
++    {
++        help = ""scale_factor must be > 0"";
++    }
++
+     return help;
+ }
+ } // anon. ns",This tests for < 0 but the error message says it must be > 0. The `if` should probably be `<=` to match the message.,Shouldn't this be `>= 0`?
+8296,"@@ -25,12 +25,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         {
+             var request = (WebRequest)webRequest;
+ 
+-            if (!IsTracingEnabled(request))
++            if (!(request is HttpWebRequest) || !IsTracingEnabled(request))
+             {
+                 return request.GetResponse();
+             }
+ 
+-            string httpMethod = request.Method.ToUpperInvariant();
++            string httpMethod = request.Method?.ToUpperInvariant() ?? ""UNKNOWN"";
+             string integrationName = typeof(WebRequestIntegration).Name.TrimEnd(""Integration"", StringComparison.OrdinalIgnoreCase);
+ 
+             using (var scope = ScopeFactory.CreateOutboundHttpScope(Tracer.Instance, httpMethod, request.RequestUri, integrationName))","Short circuits when it's something like a WebPackRequest, which we should instrument and test specifically.",Why is this change needed?
+8297,"@@ -23,7 +23,7 @@ var (
+ 
+ func init() {
+ 	flag.BoolVar(&fProd, ""prod"", false, ""disable development mode"")
+-	flag.BoolVar(&fDiskCertCache, ""use-disk-cert-cache-dev"", false, ""cache cert on disk"")
++	flag.BoolVar(&fDiskCertCache, ""use-disk-cert-cache"", false, ""cache cert on disk"")
+ }
+ 
+ func main() {",Should this be true now by default?,Why is this flag removed?
+8298,"@@ -131,6 +131,7 @@ public class AzkabanExecutorServer {
+     root.addServlet(new ServletHolder(new ExecutorServlet()), ""/executor"");
+     root.addServlet(new ServletHolder(new JMXHttpServlet()), ""/jmx"");
+     root.addServlet(new ServletHolder(new StatsServlet()), ""/stats"");
++    root.addServlet(new ServletHolder(new StatisticsServlet()), ""/stastics"");
+ 
+     root.setAttribute(ServerConstants.AZKABAN_SERVLET_CONTEXT_KEY, this);
+ ",/DispatcherStatistics ? /statistics is a bit confusing with /stats,Should this be `/stats/sta
+8299,"@@ -605,6 +605,9 @@ def get_lambda_log_events(
+             or ""START"" in raw_message
+             or ""END"" in raw_message
+             or ""REPORT"" in raw_message
++            # necessary until tail is updated in docker images. See this PR:
++            # http://git.savannah.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.24-111-g1118f32
++            or ""tail: unrecognized file system type 0x794c7630"" in raw_message
+             or regex_filter
+             and not re.search(regex_filter, raw_message)
+         ):","nit: Wondering if we should simply filter on `""tail: unrecognized file system type""`, or is the type identifier `0x794c7630` always the same?",I'm not sure if this is th
+8300,"@@ -4,12 +4,13 @@ import (
+ 	""encoding/json""
+ 	""fmt""
+ 
++	""github.com/google/uuid""
+ 	installertypes ""github.com/openshift/installer/pkg/types""
+ 
+ 	hivev1 ""github.com/openshift/hive/pkg/apis/hive/v1""
+ )
+ 
+-const fakeMetadataFormatStr = `{""aws"":{""identifier"":[{""kubernetes.io/cluster/fake-infraid"":""owned""},{""openshiftClusterID"":""fake-cluster-id""}],""region"":""us-east-1""},""clusterID"":""fake-cluster-id"",""clusterName"":""%s"",""infraID"":""fake-infra-id""}`
++const fakeMetadataFormatStr = `{""aws"":{""identifier"":[{""kubernetes.io/cluster/fake-infraid"":""owned""},{""openshiftClusterID"":""%s""}],""region"":""us-east-1""},""clusterID"":""%s"",""clusterName"":""%s"",""infraID"":""fake-infra-id""}`
+ 
+ func fakeLoadAdminPassword(m *InstallManager) (string, error) {
+ 	m.log.Warn(""loading fake admin password"")","I think the goal of using `fake-cluster-id` was to make it sure clear that this is a fake cluster, replacing this with UUID only now makes these clusters look very similar to real ones which can cause problems.. any reason why we didn't go for the original recommendation from slack thread of `fake-cluster-UUID` @twiest",Why is this change needed?
+8301,"@@ -1719,3 +1719,19 @@ def get_node_first_ancestor_of_type(
+         if isinstance(ancestor, ancestor_type):
+             return ancestor
+     return None
++
++
++def get_node_first_ancestor_of_type_and_its_child(
++    node: nodes.NodeNG, ancestor_type: Union[Type[T_Node], Tuple[Type[T_Node]]]
++) -> Tuple[Optional[T_Node], Optional[T_Node]]:
++    """"""Modified version of get_node_first_ancestor_of_type to also return the
++    descendant visited directly before reaching the sought ancestor. Useful
++    for extracting whether a statement is guarded by a try, except, or finally
++    when searching for a TryFinally ancestor.
++    """"""
++    last_ancestor = node
++    for ancestor in node.node_ancestors():
++        if isinstance(ancestor, ancestor_type):
++            return (ancestor, last_ancestor)
++        last_ancestor = ancestor
++    return None, None","I need to spruce up my `mypy` knowledge but I think this is incorrect. Using `T_Node` twice makes it so that both should be the same type. I think this would be better: `Tuple[Optional[T_Node], Optional[nodes.NodeNG ]]`. It might even better to do: `Union[Tuple[None, None]. Tuple[T_Node, nodes.NodeNG ]]` as that shows that `None` should always pair with `None`",I'm not sure if this is th
+8302,"@@ -438,10 +438,13 @@ func runTest(t *testing.T, test testT) {
+ 	}
+ 
+ 	controller := certificaterequests.New(apiutil.IssuerCA, ca)
+-	controller.Register(test.builder.Context)
++	_, _, err := controller.Register(test.builder.Context)
++	if err != nil {
++		t.Errorf(""controller.Register failed (%s)"", err.Error())
++	}
+ 	test.builder.Start()
+ 
+-	err := controller.Sync(context.Background(), test.certificateRequest)
++	err = controller.Sync(context.Background(), test.certificateRequest)
+ 	if err != nil && !test.expectedErr {
+ 		t.Errorf(""expected to not get an error, but got: %v"", err)
+ 	}",Nit: below on line 449 we use `%v` to print an error - perhaps would be nice to do it in the same way in both places (but probably not that important). Similar in other places in this PR.,Shouldn't this be `t.Fatal
+8303,"@@ -169,6 +169,8 @@ class Flow(stateobject.StateObject):
+             self.reply.take()
+         self.reply.kill(force=True)
+         self.reply.commit()
++        self.live = False
++        master.addons(""kill"", self)
+ 
+     def intercept(self, master):
+         """"""","I'm not against adding a kill event, but we need to do it properly, please. That means listing it in events.py, adding docs for it, and so forth.",Why is this needed?
+8304,"@@ -2083,9 +2083,15 @@ class CppGenerator : public BaseGenerator {
+         if (!field.deprecated) {
+           code_.SetValue(""FIELD_NAME"", Name(field));
+           if (field.value.type.base_type == BASE_TYPE_STRING) {
+-            code_ +=
+-                ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
+-                ""_fbb.CreateString({{FIELD_NAME}}) : 0;"";
++            if (!field.native_shared) {
++              code_ +=
++                  ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
++                  ""_fbb.CreateString({{FIELD_NAME}}) : 0;"";
++            } else {
++              code_ +=
++                  ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? ""
++                  ""_fbb.CreateSharedString({{FIELD_NAME}}) : 0;"";
++            }
+           } else if (field.value.type.base_type == BASE_TYPE_VECTOR) {
+             code_ += ""  auto {{FIELD_NAME}}__ = {{FIELD_NAME}} ? \\"";
+             const auto vtype = field.value.type.VectorType();",this line can be lifted outside of the if-then? In fact only CreateString / CreateSharedString needs to be inside of it.,Shouldn't this be `!field.native_shared &&`?
+8305,"@@ -386,8 +386,8 @@ public class EpisodesApplyActionFragment extends Fragment implements Toolbar.OnM
+             mListView.setItemChecked(i, checked);
+         }
+         refreshToolbarState();
+-        toolbar.setTitle(getResources().getQuantityString(R.plurals.num_selected_label,
+-                checkedIds.size(), checkedIds.size()));
++//        toolbar.setTitle(getResources().getQuantityString(R.plurals.num_selected_label,
++//                checkedIds.size(), checkedIds.size()));
+     }
+ 
+     private void queueChecked() {",I think the `EpisodesApplyActionFragment` is unused now. So please delete it :),This should be removed.
+8306,"@@ -863,7 +863,7 @@ module Bolt
+       end
+       define('--log-level LEVEL',
+              ""Set the log level for the console. Available options are"",
+-             ""debug, info, notice, warn, error, fatal, any."") do |level|
++             ""trace, debug, info, warn, error, fatal, any."") do |level|
+         @options[:log] = { 'console' => { 'level' => level } }
+       end
+       define('--plugin PLUGIN', 'Select the plugin to use') do |plug|","It seems like we should leave `notice` here since it can be configured in Bolt config files, and that's what sets the console config for messages from Puppet. For example, this will break plans that call `notice()` in their apply blocks.",Why is this change needed?
+8307,"@@ -31,6 +31,7 @@ public enum CommonMetrics {
+ 
+   private Meter dbConnectionMeter;
+   private Meter flowFailMeter;
++  private Meter OOMwaitingJobMeter;
+   private AtomicLong dbConnectionTime = new AtomicLong(0L);
+ 
+   private MetricRegistry registry;",This metrics is only exposed in executors. Should it be defined in azkaban.execapp.ExecMetrics instead?,private Meter flowFailMeter;
+8308,"@@ -64,3 +64,14 @@ export function getEffectiveMaxDate ({ maxDate, includeDates }) {
+     return maxDate
+   }
+ }
++
++export function parseDate (value, { dateFormat, locale }) {
++  const m = moment(value, dateFormat, locale || moment.locale(), true)
++  return m.isValid() ? m : null
++}
++
++export function safeDateFormat (date, { dateFormat, locale }) {
++  return date && date.clone()
++    .locale(locale || moment.locale())
++    .format(Array.isArray(dateFormat) ? dateFormat[0] : dateFormat) || ''
++}","I originally factored out these functions from date_input. Currently, they are only used in datepicker, but they seemed more general purpose. If you decide we should keep the current date_input API (in case anyone is using it directly), then I think it makes sense to factor these out in order to be able to maintain consistency, but otherwise they could be inlined into datepicker.jsx if you prefer.",I don't think you need the `|| ''` here. `moment.locale()` will return `en_US` if the locale is not set.
+8309,"@@ -204,9 +204,10 @@ func (r *mutableStateTaskGeneratorImpl) generateDelayedWorkflowTasks(
+ 	switch startAttr.GetInitiator() {
+ 	case enumspb.CONTINUE_AS_NEW_INITIATOR_RETRY:
+ 		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_RETRY
+-	case enumspb.CONTINUE_AS_NEW_INITIATOR_CRON_SCHEDULE,
+-		enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW:
++	case enumspb.CONTINUE_AS_NEW_INITIATOR_CRON_SCHEDULE, enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW:
+ 		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_CRON
++	case enumspb.CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED:
++		workflowBackoffType = enumsspb.WORKFLOW_BACKOFF_TYPE_UNSPECIFIED
+ 	default:
+ 		return serviceerror.NewInternal(fmt.Sprintf(""unknown initiator: %v"", startAttr.GetInitiator()))
+ 	}",I think this should never happen and should return an error also. Having `WorkflowBackoffTimerTask` with `UNSPECIFIED` type looks weird.,Why do we need to change this?
+8310,"@@ -9,7 +9,7 @@ import 'webcomponents';
+     function onKeyDown(e) {
+         // Don't submit form on enter
+         // Real (non-emulator) Tizen does nothing on Space
+-        if (e.keyCode === 13 || e.keyCode === 32) {
++        if (e.keyCode === 13 || (e.keyCode === 32 && browser.tizen)) {
+             e.preventDefault();
+ 
+             if (!this.checked) {",Add `browser` import,Why do we need to check browser.tizen here?
+8311,"@@ -0,0 +1,18 @@
++// Copyright 2018 Keybase Inc. All rights reserved.
++// Use of this source code is governed by a BSD
++// license that can be found in the LICENSE file.
++
++package config
++
++import (
++	""crypto/sha256""
++	""encoding/hex""
++)
++
++// GenerateSHA256PasswordHash generates a sha256 hashed password hash from
++// plaintextPassword in the form of ""sha256:<hash>"". This is what should go
++// into the config file.
++func GenerateSHA256PasswordHash(plaintextPassword string) string {
++	hash := sha256.Sum256([]byte(plaintextPassword))
++	return ""sha256:"" + hex.EncodeToString(hash[:])
++}","Would it be good practice to add a nonce in here (that's also stored in the config), so it's harder to tell when passwords are being reused?",I'm not sure if this is the best place to put this function. It seems like it belongs in the `crypto` pa
+8312,"@@ -40,4 +40,8 @@ public interface TelemetryRestService {
+   @Produces(MediaType.APPLICATION_JSON)
+   TelemetryConfigurationDto getTelemetryConfiguration();
+ 
++  @GET
++  @Path(""/data"")
++  @Produces(MediaType.APPLICATION_JSON)
++  Object getTelemetryData();
+ }","For consistency, the return type could be `TelemetryDataDto` here. This would be more consistent with the other REST API interfaces. From a functional perspective, the current code is perfectly fine though.",Why do we need this?
+8313,"@@ -133,7 +133,7 @@ PySGDSolver::PySGDSolver(const string& param_file) {
+   // as in PyNet, (as a convenience, not a guarantee), create a Python
+   // exception if param_file can't be opened
+   CheckFile(param_file);
+-  solver_.reset(new SGDSolver<float>(param_file));
++  solver_ = boost::make_shared<SolvingDriver<float> >(param_file);
+   // we need to explicitly store the net wrapper, rather than constructing
+   // it on the fly, so that it can hold references to Python objects
+   net_.reset(new PyNet(solver_->net()));",I've never seen this `boost::make_shared`...why use it instead of `reset`?,Why not use `std::sh
+8314,"@@ -273,6 +273,11 @@ public abstract class AbstractExecutorManagerAdapter extends EventHandler implem
+     }
+   }
+ 
++  @Override
++  public DispatchMethod getDispatchMethod(final ExecutableFlow flow) {
++    return getDispatchMethod();
++  }
++
+   protected String uploadExecutableFlow(
+       final ExecutableFlow exflow, final String userId, final String flowId,
+       String message) throws ExecutorManagerException {",Wasn't this added as a part of different PR already?,Why do we need this 
+8315,"@@ -8,7 +8,7 @@ class UrlListData
+     public const FIELD_SLUG = 'slug';
+ 
+     /**
+-     * @var \Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\FriendlyUrl[]
++     * @var \Shopsys\FrameworkBundle\Component\Router\FriendlyUrl\FriendlyUrl[][]
+      */
+     public $toDelete;
+ ","hmmmmm, should not be in constructor in this case `$this->toDelete = [[]];` ??? maybe not",Should be `\Shopsys\
+8316,"@@ -114,8 +114,11 @@ def toggle_routing_control_state(routing_control_arn, cluster_endpoints):
+     update_state = 'Off' if state == 'On' else 'On'
+     print(f""Setting control state to '{update_state}'."")
+     response = update_routing_control_state(routing_control_arn, cluster_endpoints, update_state)
+-    if response['ResponseMetadata']['HTTPStatusCode'] == 200:
++    status = response.get('ResponseMetadata', {}).get('HTTPStatusCode', 'Unknown')
++    if status == 200:
+         print('Success!')
++    else:
++        print(f'Something went wrong. Status: {status}.')
+     print('-'*88)
+ # snippet-end:[python.example_code.route53-recovery-cluster.Scenario_SetControlState]
+ ","We can just update it to be as follows: `if response: print(""Success"") else: print(""Error"")`","I think this should be `response.get('Status', 'Unknown')`"
+8317,"@@ -119,6 +119,7 @@ type Helper struct {
+ 	matcherDefs  map[string]caddy.ModuleMap
+ 	parentBlock  caddyfile.ServerBlock
+ 	groupCounter counter
++	state        map[string]interface{}
+ }
+ 
+ // Option gets the option keyed by name.",Maybe this should be exported so (external/third-party) plugins can also use it.,Why do we need this?
+8318,"@@ -38,17 +38,9 @@ func (service *servicePFCtl) Add(rule RuleForwarding) {
+ }
+ 
+ func (service *servicePFCtl) Start() error {
+-	err := service.ipForward.Enable()
+-	if err != nil {
+-		return err
+-	}
+-
++	service.ipForward.Enable()
+ 	service.clearStaleRules()
+-	err = service.enableRules()
+-	if err != nil {
+-		return err
+-	}
+-	return nil
++	return service.enableRules()
+ }
+ 
+ func (service *servicePFCtl) Stop() {",Warning logging whould be exactly here in high logic. So that everybody understands why we swallow errors,Why do you remove this error check?
+8319,"@@ -46,6 +46,7 @@ namespace Nethermind.JsonRpc.WebSockets
+             string clientName,
+             ISocketHandler handler,
+             RpcEndpoint endpointType,
++            JsonRpcUrl? url,
+             IJsonRpcProcessor jsonRpcProcessor,
+             IJsonRpcService jsonRpcService,
+             IJsonRpcLocalStats jsonRpcLocalStats,","if its optional, move it to last item an use JsonRpcUrl? url = null",Why is this nullable?
+8320,"@@ -58,6 +58,14 @@ class User < ActiveRecord::Base
+     user
+   end
+ 
++  def client_model
++    Proposal.client_model_for(self)
++  end
++
++  def client_model_slug
++    client_model.to_s.underscore.tr(""/"", ""_"")
++  end
++
+   def add_role(role_name)
+     role = Role.find_or_create_by!(name: role_name)
+     user_roles.find_or_create_by!(role: role)",how is this different from the `client_slug` method already available on a `user` ?,Layout/EmptyLinesAroundClassBody: Extra empty line detected at class body end.
+8321,"@@ -61,7 +61,7 @@ class UnboundZmqEventBus implements EventBus {
+       return thread;
+     });
+ 
+-    LOG.info(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
++    LOG.finest(String.format(""Connecting to %s and %s"", publishConnection, subscribeConnection));
+ 
+     sub = context.createSocket(SocketType.SUB);
+     sub.connect(publishConnection);",I'd keep this at `info` level...,Why is this change needed?
+8322,"@@ -49,11 +49,14 @@ module Travis
+             fi
+           ),
+           redirect_io: %(
+-            exec > >(
+-              %{curl}
+-              %{exports}
+-              ruby ~/filter.rb %{args}
+-            ) 2>&1
++            if [[ -z ""$TRAVIS_FILTERED"" ]]; then
++              export TRAVIS_FILTERED=1
++              exec 9>&1 1>(
++                %{curl}
++                %{exports}
++                ruby ~/filter.rb %{args}
++              ) 2>&1
++            fi
+           )
+         }
+ ",I believe this env var won't be set anywhere. Do we need this condition?,I don't think this is the right way to do this.
+8323,"@@ -14,7 +14,7 @@ function getWindowLocationSearch(win) {
+     return search || '';
+ }
+ 
+-function getParameterByName(name, url) {
++window.getParameterByName = function (name, url) {
+     'use strict';
+ 
+     name = name.replace(/[\[]/, '\\[').replace(/[\]]/, '\\]');",why add function explicitly?,Why is this change needed?
+8324,"@@ -92,7 +92,8 @@ func newLevel() *level {
+ 
+ // New will create a default sublist
+ func NewSublist() *Sublist {
+-	return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)}
++	//	return &Sublist{root: newLevel(), cache: make(map[string]*SublistResult)}
++	return &Sublist{root: newLevel()}
+ }
+ 
+ // Insert adds a subscription into the sublist","Is that intentional? If you don't create the cache here, it will never be created therefore used.",Is this intentional?
+8325,"@@ -136,4 +136,15 @@ func TestStream(t *testing.T) {
+ 		require.Greater(t, streamer.fetchCount, 1, ""expected more than one call to Fetch within timeout"")
+ 		require.Greater(t, streamer.notifyCount, 1, ""expected more than one call to Notify within timeout"")
+ 	})
++
++	t.Run(""nextFetchDate works correctly to grab times before the timeout."", func(t *testing.T) {
++		for r := 0; r < 1000; r++ {
++			now := time.Now()
++			a := nextFetchDate(now, 0)
++			require.True(t, a.Before(now.Add(4*time.Second)), ""require that the given date for 0 retries is less than 4s in the future"")
++			b := nextFetchDate(now, 10)
++			require.True(t, b.Before(now.Add(32*time.Second)), ""require that the given date for 10 retries is never more than the max interval"")
++		}
++
++	})
+ }",I think we can now remove this test case since we can ensure that multiple calls to `Fetch` will double the interval on each call,nit: `require.True(t
+8326,"@@ -64,7 +64,7 @@ type (
+ )
+ 
+ const (
+-	reservedTaskListPrefix = ""/__cadence_sys/""
++	reservedTaskListPrefix = ""/__temporal_sys/""
+ )
+ 
+ func newDecisionAttrValidator(",Not part of this PR but this const seems to be defined in multiple places. Needs to be extracted somewhere.,Why is this change n
+8327,"@@ -2,6 +2,7 @@ package volume
+ 
+ import (
+ 	""fmt""
++
+ 	""github.com/libopenstorage/openstorage/api""
+ 	""github.com/libopenstorage/openstorage/api/client""
+ 	""github.com/libopenstorage/openstorage/volume""",Remove this file from the PR,"""github.com/pkg/erro"
+8328,"@@ -55,6 +55,11 @@ namespace Nethermind.Core.Specs
+             {
+                 return Byzantium.Instance;
+             }
++            
++            if (blockNumber < IstanbulBlockNumber)
++            {
++                return Istanbul.Instance;
++            }
+ 
+             return ConstantinopleFix.Instance;
+         }","need to add it for ropsten, rinkeby, goerli as well",Why is this needed?
+8329,"@@ -109,7 +109,7 @@ func (v *VolumeProperty) Execute() ([]byte, error) {
+ 		return nil, err
+ 	}
+ 	// execute command here
+-	return exec.Command(bin.ZFS, v.Command).CombinedOutput()
++	return exec.Command(bin.BASH, ""-c"", v.Command).CombinedOutput()
+ }
+ 
+ // Build returns the VolumeProperty object generated by builder",G204: Subprocess launching should be audited (from `gosec`),Why is this change 
+8330,"@@ -49,11 +49,11 @@ import org.apache.orc.storage.ql.exec.vector.MapColumnVector;
+ import org.apache.orc.storage.ql.exec.vector.TimestampColumnVector;
+ import org.apache.orc.storage.serde2.io.HiveDecimalWritable;
+ 
+-class FlinkOrcReaders {
++public class FlinkOrcReaders {
+   private FlinkOrcReaders() {
+   }
+ 
+-  static OrcValueReader<StringData> strings() {
++  public static OrcValueReader<StringData> strings() {
+     return StringReader.INSTANCE;
+   }
+ ","curious why only making these 3 public. what about other package scope methods like `times`, `timestamps`, `array`?",Why do we need this
+8331,"@@ -0,0 +1,15 @@
++<?php
++
++return [
++    /*
++    |--------------------------------------------------------------------------
++    | Exclusion list
++    |--------------------------------------------------------------------------
++    |
++    | This is a list of exclusions for words or phrases where the original
++    | form of the word has the same spelling in a given language.
++    |
++    */
++
++    'Email',
++];","The Email field is not translated into Russian, and into any other. It's kind of a ""standard"" word. Therefore, we may face the fact that you have to create files with exceptions for all languages. @caouecs, what do you say?",Should be `Email Ex
+8332,"@@ -32,6 +32,9 @@ int main (int argc, char * const * argv)
+ 		(""disable_unchecked_drop"", ""Disables drop of unchecked table at startup"")
+ 		(""fast_bootstrap"", ""Increase bootstrap speed for high end nodes with higher limits"")
+ 		(""batch_size"",boost::program_options::value<std::size_t> (), ""Increase sideband batch size, default 512"")
++		(""block_processor_batch_size"",boost::program_options::value<std::size_t> (), ""Increase block processor transaction batch write size, default 0 (limited by config block_processor_batch_max_time), 256k for fast_bootstrap"")
++		(""block_processor_full_size"",boost::program_options::value<std::size_t> (), ""Increase block processor allowed blocks queue size before dropping live network packets and holding bootstrap download, default 65536, 1 million for fast_bootstrap"")
++		(""block_processor_verification_size"",boost::program_options::value<std::size_t> (), ""Increase batch signature verification size in block processor, default 0 (2048 * signature checker threads + 1), unlimited for fast_bootstrap"")
+ 		(""debug_block_count"", ""Display the number of block"")
+ 		(""debug_bootstrap_generate"", ""Generate bootstrap sequence of blocks"")
+ 		(""debug_dump_online_weight"", ""Dump online_weights table"")",Should it say `default 0` here? looks a bit confusing. Also following BODMAS we should put: `2048 * (signature checker threads + 1)`,I don't think we need this option. We can just use `block_processor_batch_size` directly.
+8333,"@@ -16,6 +16,7 @@
+ 
+ from __future__ import print_function
+ import os
++import ruamel.yaml
+ 
+ import constants
+ import utils","Add a newline. We group by 1: standard library, 2: 3rd party library, 3: application library",Why do we need this import?
+8334,"@@ -83,7 +83,9 @@ func (p *Provider) Type() string {
+ 	return ProviderType
+ }
+ 
+-func (p *Provider) RunQuery(ctx context.Context, query string, queryRange metrics.QueryRange, evaluator metrics.Evaluator) (bool, string, error) {
++// Evaluate queries the range query endpoint and checks if values in all data points are within the expected range.
++// For the range query endpoint, see: https://prometheus.io/docs/prometheus/latest/querying/api/#range-queries
++func (p *Provider) Evaluate(ctx context.Context, query string, queryRange metrics.QueryRange, evaluator metrics.Evaluator) (bool, string, error) {
+ 	if err := queryRange.Validate(); err != nil {
+ 		return false, """", err
+ 	}",So `queryRange.Step` will be ignored?,nit: `evaluator` -> `evaluator`
+8335,"@@ -24,13 +24,13 @@
+ 
+ // making the defines very clear, these represent the host architecture - aka
+ // the arch on which this code is running
+-#if defined(_X86_)
++#if defined(HOST_X86)
+ #define _HOST_X86_
+-#elif defined(_AMD64_)
++#elif defined(HOST_AMD64)
+ #define _HOST_AMD64_
+-#elif defined(_ARM_)
++#elif defined(HOST_ARM)
+ #define _HOST_ARM_
+-#elif defined(_ARM64_)
++#elif defined(HOST_ARM64)
+ #define _HOST_ARM64_
+ #endif
+ ",It would be nice to replace these _HOST_* defines with HOST_*.,I don't think these should be changed.
+8336,"@@ -299,5 +299,9 @@ func doList(dir string, out io.Writer, arg, indent string) error {
+ // scrub removes dynamic content from recorded files.
+ func scrub(rootDir string, b []byte) []byte {
+ 	const scrubbedRootDir = ""[ROOTDIR]""
+-	return bytes.ReplaceAll(b, []byte(rootDir), []byte(scrubbedRootDir))
++	rootDirWithSeparator := rootDir + string(filepath.Separator)
++	scrubbedRootDirWithSeparator := scrubbedRootDir + string(filepath.Separator)
++	b = bytes.Replace(b, []byte(rootDirWithSeparator), []byte(scrubbedRootDirWithSeparator), -1)
++	b = bytes.Replace(b, []byte(rootDir), []byte(scrubbedRootDir), -1)
++	return b
+ }","The problem here was that the record file started with something like `/tmp/whatever/myproj` and was scrubbed to `[ROOTDIR]/myproj`, but the `/` is a `\` on Windows.",Why do we need this change?
+8337,"@@ -33,10 +33,13 @@
+ 
+ #include <rtps/builtin/data/ProxyHashTables.hpp>
+ 
++#include ""../../../fastdds/core/policy/ParameterList.hpp""
++
+ #include <mutex>
+ #include <chrono>
+ 
+ using namespace eprosima::fastrtps;
++using ParameterList = eprosima::fastdds::dds::ParameterList;
+ 
+ namespace eprosima {
+ namespace fastrtps {",Don't use relative paths. src directory is already on the include search path,Why do we need this?
+8338,"@@ -177,8 +177,12 @@ type BuildTarget struct {
+ 	// Tools that this rule will use, ie. other rules that it may use at build time which are not
+ 	// copied into its source directory.
+ 	Tools []BuildInput
++	// Like tools but available to the test_cmd instead
++	TestTools []BuildInput
+ 	// Named tools, similar to named sources.
+ 	namedTools map[string][]BuildInput `name:""tools""`
++	// Named test tools, similar to named sources.
++	namedTestTools map[string][]BuildInput `name:""test_tools""`
+ 	// Target-specific environment passthroughs.
+ 	PassEnv *[]string `name:""pass_env""`
+ 	// Target-specific unsafe environment passthroughs.",if we're introducing this now can we make this private?,I don't think we need to ad
+8339,"@@ -103,6 +103,17 @@ namespace pwiz.Skyline.Model.Results
+             if (_totalSteps == 0)
+                 return measured;
+ 
++            // Before we do anything else, make sure the raw files are present
++            foreach (var f in fileInfos)
++            {
++                if (!ScanProvider.FileExists(_documentFilePath, f.FilePath))
++                {
++                    throw new FileNotFoundException(TextUtil.LineSeparate(Resources.IonMobilityFinder_ProcessMSLevel_Failed_using_results_to_populate_ion_mobility_library_,
++                    string.Format(Resources.ScanProvider_GetScans_The_data_file__0__could_not_be_found__either_at_its_original_location_or_in_the_document_or_document_parent_folder_,
++                        f.FilePath)));
++                }
++            }
++
+             using (_msDataFileScanHelper = new MsDataFileScanHelper(SetScans, HandleLoadScanException, true))
+             {
+                 //",Something is wrong with the indentation here.,Why do we need this check?
+8340,"@@ -18,12 +18,13 @@ package importtestsuites
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/compute""
+ 	""log""
+ 	""regexp""
++	""strings""
+ 	""sync""
+ 
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/cli_tools/common/utils/path""
+-	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/compute""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/gce_image_import_export_tests/test_suites""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/e2e_test_utils/junitxml""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/go/e2e_test_utils/test_config""",This should go to the external imports group below,nit: remove empty line
+8341,"@@ -36,6 +36,7 @@ func NewInstaller(dc dynamic.Interface, config map[string]string, paths ...strin
+ 	}
+ 
+ 	for i, p := range paths {
++		log.Println(""processing yaml folder"", p)
+ 		paths[i] = ParseTemplates(p, config)
+ 	}
+ 	path := strings.Join(paths, "","")",Intended to be checked in?,Is this intentional?
+8342,"@@ -307,7 +307,10 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+ 
+       // Currently nothing to do but print a warning
+       LOGGER.warn(""There are schemas only existing in service center: {}, which means there are interfaces changed. ""
+-          + ""It's recommended to increment microservice version before deploying."", scSchemaMap.keySet());
++              + ""It's recommended to increment microservice version before deploying."",
++          scSchemaMap.keySet());
++      LOGGER.warn(""ATTENTION: The schemas in new version are less than the old version, ""
++          + ""which may cause compatibility problems."");
+     }
+   }
+ ","I think this warning message is the same as above one. Anyway, it's fine to keep it.",I don't think this is 
+8343,"@@ -46,7 +46,7 @@ namespace Nethermind.Logging
+ 
+             if (NLog.LogManager.Configuration?.AllTargets.SingleOrDefault(t => t.Name == ""file"") is FileTarget target)
+             {
+-                target.FileName = !Path.IsPathFullyQualified(fileName) ? Path.Combine(""logs"", fileName) : fileName;
++                target.FileName = !Path.IsPathFullyQualified(fileName) ? Path.Combine(logsDir, fileName) : fileName;
+             }
+ 
+             /* NOTE: minor perf gain - not planning to switch logging levels while app is running */","This is done few times, replace with some well named method",I'm not sure if this i
+8344,"@@ -101,14 +101,14 @@ public class CodeGeneratorTool {
+ 
+   private static int generate(
+       String descriptorSet,
+-      String[] apiConfigs,
++      String[] configs,
+       String[] generatorConfigs,
+       String packageConfig,
+       String outputDirectory,
+       String[] enabledArtifacts) {
+     ToolOptions options = ToolOptions.create();
+     options.set(ToolOptions.DESCRIPTOR_SET, descriptorSet);
+-    options.set(ToolOptions.CONFIG_FILES, Lists.newArrayList(apiConfigs));
++    options.set(ToolOptions.CONFIG_FILES, Lists.newArrayList(configs));
+     options.set(CodeGeneratorApi.OUTPUT_FILE, outputDirectory);
+     options.set(CodeGeneratorApi.GENERATOR_CONFIG_FILES, Lists.newArrayList(generatorConfigs));
+     options.set(CodeGeneratorApi.PACKAGE_CONFIG_FILE, packageConfig);","`configs` isn't very descriptive, especially when there are other config-ish things like `generatorConfigs`.",Why is this change needed?
+8345,"@@ -192,7 +192,12 @@ class TestGatlingExecutor(BZTestCase):
+                               }]},
+                              {""url"": ""/"",
+                               ""think-time"": 2,
+-                              ""follow-redirects"": True}]
++                              ""follow-redirects"": True},
++                             {""url"": ""/reserve.php"",
++                              ""method"": ""POST"",
++                              ""body"": u""Body Content 2"",
++                              }
++                             ]
+             }
+         })
+         self.obj.prepare()",In my point we have to check conversion with specific (non-ASCII) characters in unicode string.,This should be `/reserve.p
+8346,"@@ -1,6 +1,7 @@
+ tests = [
+-  (""python"", ""EmbedLib.py"", {}),
++  #   (""python"", ""EmbedLib.py"", {}),
+   (""python"", ""UnitTestEmbed.py"", {}),
++  (""python"", ""UnitTestExcludedVolume.py"", {}),
+   (""python"", ""UnitTestPharmacophore.py"", {}),
+ ]
+ ","Given that file still contains doctests (and should still contain doctests), they should be run. Please turn this back on.",Why did you remove this?
+8347,"@@ -70,6 +70,7 @@ public class SignUtils {
+     private static final String ATTR_CONTENTS = ""contents"";
+     private static final String ATTR_CERT_DNS_DOMAIN = ""certDnsDomain"";
+     private static final String ATTR_AUDIT_ENABLED = ""auditEnabled"";
++    private static final String ATTR_SELF_SERVE = ""selfserve"";
+ 
+     private static Struct asStruct(DomainPolicies domainPolicies) {
+         // all of our fields are in canonical order based",we should keep the camel case format - selfServe,This should be `ATTR_SELF_
+8348,"@@ -17,14 +17,15 @@ package patch
+ import (
+ 	""time""
+ 
++	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/compute""
+ 	""github.com/GoogleCloudPlatform/compute-image-tools/osconfig_tests/utils""
+-	""google.golang.org/api/compute/v1""
++	api ""google.golang.org/api/compute/v1""
+ )
+ 
+ type patchTestSetup struct {
+ 	testName      string
+ 	image         string
+-	startup       *compute.MetadataItems
++	metadata      []*api.MetadataItems
+ 	assertTimeout time.Duration
+ 	machineType   string
+ }",consider the alias `compute` in case this ever references other apis.,Why is this change needed?
+8349,"@@ -392,3 +392,7 @@ func (m *manager) GetFreezerState() (configs.FreezerState, error) {
+ 	}
+ 	return freezer.(*FreezerGroup).GetState(dir)
+ }
++
++func (m *manager) Exists() bool {
++	return cgroups.PathExists(m.paths[""devices""])
++}","It probably doesn't matter in practice, but we're not supposed to access a map without holding a lock. This is why I have suggested using `m.Path(""devices"")` earlier -- it takes a lock before accessing m.paths. Alternatively, you can leave this code as is but add taking a lock (same as `Path()`).",Why is this needed?
+8350,"@@ -33,6 +33,8 @@ let baseModuleStore = Modules.createModuleStore( 'tagmanager', {
+ 		'internalAMPContainerID',
+ 		'useSnippet',
+ 		'ownerID',
++		'gaAMPPropertyID',
++		'gaPropertyID',
+ 	],
+ 	submitChanges,
+ 	validateCanSubmitChanges,","Since `ga` is an acronym here, we should rename the generated actions and selectors to adhere to our naming conventions as it will no longer be capitalized properly. See below for how this is already done for the amp container ID settings. We should add `GA` to our list of checked acronyms as well in `packages/eslint-plugin/rules/acronym-case.js`.",Why do we need this?
+8351,"@@ -88,12 +88,11 @@ class TransloaditAssembly extends Emitter {
+ 
+     socket.on('assembly_upload_finished', (file) => {
+       this.emit('upload', file)
+-      this._fetchStatus({ diff: false })
++      this.status.uploads.push(file)
+     })
+ 
+     socket.on('assembly_uploading_finished', () => {
+       this.emit('executing')
+-      this._fetchStatus({ diff: false })
+     })
+ 
+     socket.on('assembly_upload_meta_data_extracted', () => {","uploading_finished and upload_meta_data_extracted can fire very quickly after another, and there is not much difference in the Assembly status that's useful to us. I kept only the Assembly fetch after metadata is extracted, which ensures that we'll have all the correct `uploads.*.meta` properties on the client side.",I think this should be `th
+8352,"@@ -53,7 +53,10 @@ func (m *manager) getControllers() error {
+ 
+ 	file := filepath.Join(m.dirPath, ""cgroup.controllers"")
+ 	data, err := ioutil.ReadFile(file)
+-	if err != nil && !m.rootless {
++	if err != nil {
++		if m.rootless && m.config.Path == """" {
++			return nil
++		}
+ 		return err
+ 	}
+ 	fields := strings.Fields(string(data))","Does it make sense to keep trying to read the file every time the function is called, or should we maybe use `sync.Once()` here?","Shouldn't this be `m.config.Path != """"`?"
+8353,"@@ -59,6 +59,7 @@ type Bee struct {
+ 
+ type Options struct {
+ 	DataDir            string
++	DbCapacity         uint64
+ 	Password           string
+ 	APIAddr            string
+ 	DebugAPIAddr       string",`DbCapacity` -> `DBCapacity`,Why do we need this?
+8354,"@@ -56,8 +56,10 @@ namespace Nethermind.Network.Test
+         [TestCase(0, ""0xa3f5ab08"", 1_561_651L, ""Unsynced"")]
+         [TestCase(1_561_650L, ""0xa3f5ab08"", 1_561_651L, ""Last Constantinople block"")]
+         [TestCase(1_561_651L, ""0xc25efa5c"", 4_460_644L, ""First Istanbul block"")]
+-        [TestCase(4_460_644L, ""0x757a1c47"", 0L, ""First Berlin block"")]
+-        [TestCase(6_000_000L, ""0x757a1c47"", 0L, ""Future Berlin block"")]
++        [TestCase(4_460_644L, ""0x757a1c47"", 5_062_605, ""First Berlin block"")]
++        [TestCase(4_600_000L, ""0x757a1c47"", 5_062_605, ""Future Berlin block"")]
++        [TestCase(5_062_605L, ""0xB8C6299D"", 0L, ""First London block"")]
++        [TestCase(5_979_794L, ""0xB8C6299D"", 0L, ""Future London block"")]
+         public void Fork_id_and_hash_as_expected_on_goerli(long head, string forkHashHex, long next, string description)
+         {
+             Test(head, KnownHashes.GoerliGenesis, forkHashHex, next, description, GoerliSpecProvider.Instance, ""goerli.json"");",For Berlin I confirmed all the fork hashes with the Geth team. Would you do the same with Martin? He responded quickly the last time.,Why was this changed?
+8355,"@@ -63,6 +63,19 @@ func Wireguard() error {
+ 	return sh.RunV(cmdParts[0], cmdParts[1:]...)
+ }
+ 
++// SOCKS5 builds and starts SOCKS5 service with terms accepted
++func SOCKS5() error {
++	if err := sh.RunV(""bin/build""); err != nil {
++		return err
++	}
++	cmd := ""build/myst/myst service --agreed-terms-and-conditions socks5""
++	if runtime.GOOS == ""darwin"" {
++		cmd = ""sudo "" + cmd
++	}
++	cmdParts := strings.Split(cmd, "" "")
++	return sh.RunV(cmdParts[0], cmdParts[1:]...)
++}
++
+ // CLI builds and runs myst CLI
+ func CLI() error {
+ 	if err := sh.RunV(""bin/build""); err != nil {",Does `sudo` required for `darwin` only? Don't we need it for `linux` too?,Why do we need this?
+8356,"@@ -11,11 +11,17 @@ import (
+ 	""text/tabwriter""
+ 
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/cloudformation""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/resourcegroups""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/aws/session""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store""
+ 	sess ""github.com/aws/aws-sdk-go/aws/session""
+ )
+ 
++const (
++	cloudformationResourceType = ""AWS::CloudFormation::Stack""
++)
++
+ type EnvDescription struct {
+ 	Environment  *archer.Environment   `json:""environment""`
+ 	Applications []*archer.Application `json:""applications""`",Can you add description to this exported struct?,I think this should be `CloudFormation::Stack`
+8357,"@@ -68,13 +68,14 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		state = component.state,
+ 		context = component.context,
+ 		previousProps = component.prevProps || props,
+-		previousState = component.prevState || state,
++		previousState = extend({}, component.prevState || state),
+ 		previousContext = component.prevContext || context,
+ 		isUpdate = component.base,
+ 		nextBase = component.nextBase,
+ 		initialBase = isUpdate || nextBase,
+ 		initialChildComponent = component._component,
+ 		skip = false,
++		snapshot = previousContext,
+ 		rendered, inst, cbase;
+ 
+ 	if (component.constructor.getDerivedStateFromProps) {","Although this is needed for `getSnapshotBeforeUpdate` this also fixes a bug with `componentDidUpdate`. During rendering, the `state` variable is mutated. This has the consequence, that `previousState` would never hold the previous state, but the most current one.",Why do we need this?
+8358,"@@ -15,6 +15,7 @@ package ec2
+ 
+ import (
+ 	""github.com/aws/aws-sdk-go/service/ec2/ec2iface""
++	""github.com/aws/aws-sdk-go/service/elb/elbiface""
+ )
+ 
+ // Service holds a collection of interfaces.",Should this maybe directly start with ELBv2 aka NLBs or ALBs?,This should be `elbiface`
+8359,"@@ -59,6 +59,11 @@ describe( 'Tag Manager module setup', () => {
+ 				request.respond( {
+ 					status: 200,
+ 				} );
++			} else if ( request.url().match( 'google-site-kit/v1/core/site/data/notifications' ) ) {
++				request.respond( {
++					status: 200,
++					body: JSON.stringify( [] ),
++				} );
+ 			} else if ( request.url().match( 'modules/tagmanager/data/live-container-version' ) ) {
+ 				// Return a live container version without GA.
+ 				request.respond( { status: 200, body: JSON.stringify( liveContainerVersionFixture ) } );",This was the request that was often causing the test to fail as an unexpected API failure (or at least one of them   ).,I'm not sure if this is the best way to handle
+8360,"@@ -0,0 +1,13 @@
++class NetworkError extends Error {
++  constructor (error = null, xhr = null) {
++    super(error.message)
++
++    this.isNetworkError = true
++    this.originalRequest = xhr
++
++    const message = error.message + '. This looks like a network error, the endpoint might be blocked by an ISP or a firewall'
++    this.message = message
++  }
++}
++
++module.exports = NetworkError","I understand why `xhr = null`, but I think adding `error = null` implies that this method should work even if we don't pass the `error` argument. Should we remove it?",Why do we need this?
+8361,"@@ -73,7 +73,8 @@ public abstract class GapicMethodConfig extends MethodConfig {
+       Method method,
+       ProtoMethodModel methodModel,
+       RetryCodesConfig retryCodesConfig,
+-      ImmutableSet<String> retryParamsConfigNames) {
++      ImmutableSet<String> retryParamsConfigNames,
++      GrpcGapicRetryMapping retryMapping) {
+ 
+     GrpcStreamingConfig grpcStreaming = null;
+     if (isGrpcStreamingMethod(methodModel)) {","It is not your code, and it is used like this all over the place in gapic generator, but the general rule is we should prefer using the least specific class/interface in the hierarchy, which still satisfies our requirements. Here, unless we really need anything specific from `ImmutableSet`, please use `Set` (less specific type) instead.",nit: `grpcStreaming`
+8362,"@@ -162,9 +162,18 @@ struct flb_elasticsearch *flb_es_conf_create(struct flb_output_instance *ins,
+             }
+             ctx->aws_region = (char *) tmp;
+ 
++            tmp = flb_output_get_property(""aws_sts_endpoint"", ins);
++            if (!tmp) {
++                flb_error(""[out_es] aws_sts_endpoint not set"");
++                flb_es_conf_destroy(ctx);
++                return NULL;
++            }
++            ctx->aws_sts_endpoint = (char *) tmp;
++
+             ctx->aws_provider = flb_standard_chain_provider_create(config,
+                                                                    &ctx->aws_tls,
+                                                                    ctx->aws_region,
++                                                                   ctx->aws_sts_endpoint,
+                                                                    NULL,
+                                                                    flb_aws_client_generator());
+             if (!ctx->aws_provider) {","Sorry... I just realized... since we use sts_endpoint in the EKS Provider, this error message is no longer true. Role_arn is not required.",Shouldn't this be `c
+8363,"@@ -206,6 +206,18 @@ public interface Tree<T> extends Traversable<T>, Serializable {
+         return io.vavr.collection.Collections.fill(n, s, empty(), Tree::of);
+     }
+ 
++    /**
++     * Returns a Tree containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Tree
++     * @param n       The number of elements in the Tree
++     * @param element The element
++     * @return A Tree of size {@code n}, where each element is the given {@code element}.
++     */
++    static <T> Tree<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element, empty(), Tree::of);
++    }
++
+     /**
+      * Recursively builds a non-empty {@code Tree}, starting with the given {@code seed} value and proceeding in depth-first order.
+      * <p>","(...), where each element ~are~ **is the** given {\@code element}.",I'm not sure if this
+8364,"@@ -73,6 +73,7 @@ abstract class BaseFile<F>
+   private long[] splitOffsets = null;
+   private int[] equalityIds = null;
+   private byte[] keyMetadata = null;
++  private Integer sortOrderId;
+ 
+   // cached schema
+   private transient Schema avroSchema = null;","I think this can be an int because we have a default that is always valid, `0`.",Why do we need this?
+8365,"@@ -141,6 +141,17 @@ describe Section do
+     end
+   end
+ 
++  describe '.upcoming?' do
++    it 'knows if it has happened yet' do
++      next_week = Section.new(starts_on: 1.week.from_now)
++      last_week = Section.new(starts_on: 1.week.ago)
++      today = Section.new(starts_on: Date.today)
++      expect(today).to be_upcoming
++      expect(next_week).to be_upcoming
++      expect(last_week).not_to be_upcoming
++    end
++  end
++
+   describe '#fulfillment_method' do
+     it 'returns in-person if the workshop is an in-person one' do
+       in_person_workshop = create(:workshop, online: false)",I think you can use `build_stubbed` here for the same results but with more speed.,Layout/EmptyLinesAro
+8366,"@@ -491,6 +491,11 @@ class JMX(object):
+         if hold or (rampup and not iterations):
+             scheduler = True
+ 
++        if isinstance(rampup, numeric_types) and isinstance(hold, numeric_types):
++            duration = hold + rampup
++        else:
++            duration = 0
++
+         trg = etree.Element(""ThreadGroup"", guiclass=""ThreadGroupGui"",
+                             testclass=""ThreadGroup"", testname=testname)
+         if on_error is not None:",what if one of them is property and one is not?,Shouldn't this be `i
+8367,"@@ -277,6 +277,8 @@ module.exports = class Dashboard extends Plugin {
+         name: file.name,
+         type: file.type,
+         data: blob
++      }).catch(() => {
++        // Ignore
+       })
+     })
+   }",> UI plugins swallow rejection errors so they don't end up in the console with no way to fix But it will still catch upstream in `addFile` and restrictions to show the informer?..  ,Why is this needed?
+8368,"@@ -378,11 +378,12 @@ const executeOperation = (topology, operation, args, options) => {
+ 
+   // The driver sessions spec mandates that we implicitly create sessions for operations
+   // that are not explicitly provided with a session.
+-  let session, opOptions;
++  let session, opOptions, owner;
+   if (!options.skipSessions && topology.hasSessionSupport()) {
+     opOptions = args[args.length - 2];
+     if (opOptions == null || opOptions.session == null) {
+-      session = topology.startSession();
++      owner = {};
++      session = topology.startSession({ owner });
+       const optionsIndex = args.length - 2;
+       args[optionsIndex] = Object.assign({}, args[optionsIndex], { session: session });
+     } else if (opOptions.session && opOptions.session.hasEnded) {",can't this just be left undefined/null?,Why do we need owner here?
+8369,"@@ -64,8 +64,8 @@ module EsSpecHelper
+   def es_execute_with_retries(retries = 3, &block)
+     begin
+       retries -= 1
+-      response = block.call
+-    rescue SearchUnavailable => _error
++      block.call
++    rescue SearchUnavailable => error
+       if retries > 0
+         retry
+       else",changed bc we are using the `error` var below,I don't think we want to r
+8370,"@@ -172,13 +172,7 @@ class TestKnowledgeRestfulAPI(APITestCase):
+             user_id=1,
+         )
+ 
+-        answer = get_answer.json
+-
+-        expected_result = dict(
+-            status=404,
+-        )
+-
+-        assert answer['status'] == expected_result['status']
++        assert get_answer.status_code == 404
+ 
+     def test_get_knwkb_mappings(self):
+         """"""Test the return of list of mappings.""""""",Is there a reason why this is change is in the same commit?,Why was this test removed?
+8371,"@@ -77,7 +77,7 @@ func (r *repo) GetClonedBranch() string {
+ 
+ // Copy does copying the repository to the given destination.
+ func (r *repo) Copy(dest string) (Repo, error) {
+-	cmd := exec.Command(""cp"", ""-rf"", r.dir, dest)
++	cmd := copyCommand(r.dir, dest)
+ 	out, err := cmd.CombinedOutput()
+ 	if err != nil {
+ 		return nil, formatCommandError(err, out)","@nghialv btw, perhaps was this method originally created for copying the repo root to the given `dest` as a subdirectory?",Why is this change needed?
+8372,"@@ -205,7 +205,7 @@ namespace pwiz.Skyline.Model.Lib
+         // ReSharper disable LocalizableElement
+         private bool LoadLibraryFromDatabase(ILoadMonitor loader)
+         {
+-            var status = new ProgressStatus(
++            IProgressStatus status = new ProgressStatus(
+                 string.Format(Resources.ChromatogramLibrary_LoadLibraryFromDatabase_Reading_precursors_from__0_,
+                     Name));
+             try",Just curious - why not var?,I think this should be `IProgressStatus`
+8373,"@@ -26,6 +26,9 @@ import {
+ 	clearWebStorage,
+ } from './util/standalone';
+ 
++// Load image for the parent menu item.
++import '../images/logo-g_white_small.png';
++
+ if ( 'toplevel_page_googlesitekit-dashboard' !== global.pagenow && 'site-kit_page_googlesitekit-splash' !== global.pagenow && 'admin_page_googlesitekit-splash' !== global.pagenow && global.localStorage ) {
+ 	// The total notifications count should always rely on local storage
+ 	// directly for external availability.",Why would we import this here and not use it? Is there a side-effect of this import?,Why do we need this?
+8374,"@@ -281,8 +281,10 @@ module RSpec::Core
+     # @attr pending_examples [Array<RSpec::Core::Example>] the pending examples
+     # @attr load_time [Float] the number of seconds taken to boot RSpec
+     #                         and load the spec files
++    # @attr errors [Integer] the number of errors that have occurred processing
++    #                        the spec suite
+     SummaryNotification = Struct.new(:duration, :examples, :failed_examples,
+-                                     :pending_examples, :load_time)
++                                     :pending_examples, :load_time, :errors)
+     class SummaryNotification
+       # @api
+       # @return [Fixnum] the number of examples run",The name `errors` is a bit mis-leading -- usually I'd expect a field called `errors` to be an array of errors but here it's just a count. And it's not a count of _all_ errors -- it's a count only of some errors.,I think this should be a `Fixnum`
+8375,"@@ -24,7 +24,6 @@ class AppKernel extends Kernel
+             new JMS\TranslationBundle\JMSTranslationBundle(),
+             new Presta\SitemapBundle\PrestaSitemapBundle(),
+             new Prezent\Doctrine\TranslatableBundle\PrezentDoctrineTranslatableBundle(),
+-            new RaulFraile\Bundle\LadybugBundle\RaulFraileLadybugBundle(),
+             new Sensio\Bundle\FrameworkExtraBundle\SensioFrameworkExtraBundle(),
+             new Shopsys\FormTypesBundle\ShopsysFormTypesBundle(),
+             new ShopSys\MigrationBundle\ShopSysMigrationBundle(),",there was no usage of the bundle in the framework? everything works exactly the same after the removal?,Why was this removed?
+8376,"@@ -327,6 +327,14 @@ var _ = infrastructure.DatastoreDescribe(""_BPF-SAFE_ IPIP topology before adding
+ 		BeforeEach(func() {
+ 			ctx, cancel := context.WithTimeout(context.Background(), 20*time.Second)
+ 			defer cancel()
++			if bpfEnabled {
++				infra.RemoveNodeAddresses(felixes[0])
++			} else {
++				for _, f := range felixes {
++					infra.RemoveNodeAddresses(f)
++				}
++			}
++
+ 			listOptions := options.ListOptions{}
+ 			if bpfEnabled {
+ 				listOptions.Name = felixes[0].Hostname",Why this difference?,I don't think this is the right place to do this. This should be in the `BeforeEach` block.
+8377,"@@ -6533,6 +6533,8 @@ odbc_SQLSrvr_ExtractLob_sme_(
+         if (retcode == SQL_ERROR)
+         {
+             ERROR_DESC_def *p_buffer = QryLobExtractSrvrStmt->sqlError.errorList._buffer;
++            char             errNumStr[128];
++            sprintf(errNumStr, ""%d"", p_buffer->sqlcode);
+             strncpy(RequestError, p_buffer->errorText, sizeof(RequestError) - 1);
+ 
+             SendEventMsg(MSG_SQL_ERROR,","Surround code issue. RequestError may not be null terminated when the RequestError size is less than the length of the string in p_buffer->errorText. Also, this can cause core dump due to segment violation if length of errorText is less than the size of RequestBuffer.",Why not use `sprintf`?
+8378,"@@ -43,6 +43,11 @@ const (
+ 	AccountTrieRootKey = ""accountTrieRoot""
+ )
+ 
++var (
++	// AccountMaxVersionPrefix is for account history
++	AccountMaxVersionPrefix = []byte(""vp."")
++)
++
+ type (
+ 	// Factory defines an interface for managing states
+ 	Factory interface {",`AccountMaxVersionPrefix` is a global variable (from `gochecknoglobals`),Why is this needed?
+8379,"@@ -32,7 +32,6 @@ import (
+ 
+ 	apicommon ""go.temporal.io/api/common/v1""
+ 	""go.temporal.io/api/enums/v1""
+-	apinamespace ""go.temporal.io/api/namespace/v1""
+ 	apireplication ""go.temporal.io/api/replication/v1""
+ 	""go.temporal.io/api/serviceerror""
+ 	""go.temporal.io/api/workflowservice/v1""","I see it is not part of this PR but I somehow overlooked it before. Can you use same import aliases as we use everywhere in the project: `apicommon` -> `commonpb` `apireplication` -> `replicationpb` `""go.temporal.io/api/enums/v1""` -> `enumspb ""go.temporal.io/api/enums/v1""`",Why was this removed?
+8380,"@@ -235,7 +235,7 @@ class Storage(StorageBase, MigratorMixin):
+                     error_msg = (
+                         ""Cannot initialize empty resource timestamp "" ""when running in readonly.""
+                     )
+-                    raise exceptions.BackendError(message=error_msg)
++                    raise exceptions.ReadonlyError(message=error_msg)
+                 obj = row
+             else:
+                 create_result = conn.execute(",Nit: Maybe merge these into one string while you are here?,I think this should be a `ReadonlyError`
+8381,"@@ -0,0 +1,15 @@
++package runtime
++
++// noret is a placeholder that can be used to indicate that an async function is not going to directly return here
++func noret() {}
++
++func getParentHandle() *task {
++	panic(""NOPE"")
++}
++
++func fakeCoroutine(dst **task) {
++	*dst = getCoroutine()
++	for {
++		yield()
++	}
++}",Why make a new file for this? I think keeping everything related to the scheduler in a single file increases readability. Especially when there is no API-boundary in between. Functions like `getCoroutine` and `yield` also live in the normal scheduler files so it doesn't seem consistent.,Why is this needed?
+8382,"@@ -132,9 +132,10 @@ func (c *endpointManagerCallbacks) InvokeRemoveWorkload(old *proto.WorkloadEndpo
+ // that fail are left in the pending state so they can be retried later.
+ type endpointManager struct {
+ 	// Config.
+-	ipVersion              uint8
+-	wlIfacesRegexp         *regexp.Regexp
+-	kubeIPVSSupportEnabled bool
++	ipVersion                 uint8
++	wlIfacesRegexp            *regexp.Regexp
++	kubeIPVSSupportEnabled    bool
++	ifaceConfigurationEnabled bool
+ 
+ 	// Our dependencies.
+ 	rawTable     iptablesTable","tiniest of nits: why would you abbreviate ""interface"" but not ""configuration"" ?",Why do we need this?
+8383,"@@ -19,9 +19,6 @@ namespace Samples.HttpMessageHandler
+ 
+         private static string Url;
+ 
+-#if NETFRAMEWORK
+-        [LoaderOptimization(LoaderOptimization.MultiDomainHost)]
+-#endif
+         public static void Main(string[] args)
+         {
+             bool tracingDisabled = args.Any(arg => arg.Equals(""TracingDisabled"", StringComparison.OrdinalIgnoreCase));",Removing since all of the domain-neutral testing will be done in the new `Samples.MultiDomainHost.Runner` app,Why was this removed?
+8384,"@@ -50,6 +50,8 @@ def getpcmd(pid):
+                 spid, scmd = line.strip().split(' ', 1)
+                 if int(spid) == int(pid):
+                     return scmd
++    # Fallback instead of None, for e.g. Cygwin where -o is an ""unknown option"" for the ps command:
++    return '[PROCESS_WITH_PID={}]'.format(pid)
+ 
+ 
+ def get_info(pid_dir, my_pid=None):",is there a better way to detect this rather than just always assuming it's cygwin if everything else fails? i think you can check `if sys.platform == 'cygwin'`,"I'm not sure if this is the best way to do this, but I think it would be better to use `[PROCESS_WITH_PID={}]` instead."
+8385,"@@ -410,6 +410,10 @@ def _build_internal(package, path, dry_run, env):
+             try:
+                 _clone_git_repo(url, branch, tmpdir)
+                 build_from_path(package, tmpdir, dry_run=dry_run, env=env)
++            except yaml.scanner.ScannerError as ex:
++                message_parts = str(ex).split('\n')
++                message_parts.insert(0, ""Syntax error while reading {!r}"".format(path))
++                raise CommandException('\n  '.join(message_parts))
+             except Exception as exc:
+                 msg = ""attempting git clone raised exception: {exc}""
+                 raise CommandException(msg.format(exc=exc))",duplicate code - can you move into build_from_path() ?,I don't think you need the `str()` call here.
+8386,"@@ -9,3 +9,6 @@ def toto(): #pylint: disable=C0102,R1711
+ # +1: [missing-function-docstring]
+ def test_enabled_by_id_msg(): #pylint: enable=C0111
+     pass
++
++def baz(): #pylint: disable=blacklisted-name
++    return 1",  very important test as we want to make sure the old name still work.,
+8387,"@@ -1191,5 +1191,5 @@ This code is executed if a gain focus event is received by this object.
+ 		Fetches the number of descendants currently selected.
+ 		For performance, this method will only count up to the given maxCount number, and if there is one more above that, then sys.maxint is returned stating that many items are selected.
+ 		""""""
+-		return 0
++		return 1
+ ",I think returning 1 should some how be moved in to specific support for LibreOffice..,Why this change?
+8388,"@@ -85,6 +85,8 @@ byte *app_sysenter_instr_addr = NULL;
+ static bool sysenter_hook_failed = false;
+ #endif
+ 
++bool d_r_avx512_code_in_use = false;
++
+ /* static functions forward references */
+ static byte *
+ emit_ibl_routines(dcontext_t *dcontext, generated_code_t *code, byte *pc,",Should be inside `ifdef X86` I would think (or moved to ... I guess arch/x86/emit_utils.c),(style) do not initialise globals to false
+8389,"@@ -10,12 +10,14 @@ import (
+ 
+ // LocationCache cache the map of node, pod, configmap, secret
+ type LocationCache struct {
+-	//edgeNodes is a list of valid edge nodes
+-	edgeNodes []string
++	// EdgeNodes is a list of valid edge nodes
++	EdgeNodes []string
+ 	// configMapNode is a map, key is namespace/configMapName, value is nodeName
+ 	configMapNode sync.Map
+ 	// secretNode is a map, key is namespace/secretName, value is nodeName
+ 	secretNode sync.Map
++	// Services is an array of services
++	Services []v1.Service
+ }
+ 
+ // PodConfigMapsAndSecrets return configmaps and secrets used by pod","Using sync.Map(key: nodename; value: state) instead of this ""EdgeNodes"" string slice here would be much better. Reasons: 1. Using sync.Map makes the time complexity of function UpdateEdgeNode and IsEdgeNode O(1), while using string slice with for loop makes it O(n). 2. Later we could be checking node state whether it's ""ready"" or still ""not ready"" by directly comparing ""value"" of sync.Map and doing the node state updating.",Why do we need this?
+8390,"@@ -20,6 +20,10 @@ namespace AutoRest.Go
+ 
+     public const string ReadOnlyConstraint = ""ReadOnly"";
+ 
++    private static readonly Regex IsApiVersionPattern = new Regex(@""^api[^a-zA-Z0-9_]?version"", RegexOptions.IgnoreCase);
++
++    private static readonly Regex UnwrapAnchorTagsPattern = new Regex(""([^<>]*)<a\\s*.*\\shref\\s*=\\s*[\'\""]([^\'\""]*)[\'\""][^>]*>(.*)</a>"");
++
+     private static readonly Regex WordSplitPattern = new Regex(@""(\p{Lu}\p{Ll}+)"");
+ 
+     private static Dictionary<string, string> plural = new Dictionary<string, string>()","nit, does it make sense to get this variables outside the func where they are used?",Why not use `RegexOptions.IgnoreCase`?
+8391,"@@ -3,7 +3,7 @@
+ 
+ # Purpose:
+ # sns-ruby-example-show-subscriptions.rb demonstrates how to list subscriptions to the Amazon Simple Notification Services (SNS) topic using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+ 
+ # Inputs:
+ # - REGION",to **an** Amazon... Simple Notification **Service** (singular),I'm not sure if this is the right way to d
+8392,"@@ -297,10 +297,13 @@ func TestOpenTopicFromURL(t *testing.T) {
+ 
+ 	ctx := context.Background()
+ 	for _, test := range tests {
+-		_, err := pubsub.OpenTopic(ctx, test.URL)
++		top, err := pubsub.OpenTopic(ctx, test.URL)
+ 		if (err != nil) != test.WantErr {
+ 			t.Errorf(""%s: got error %v, want error %v"", test.URL, err, test.WantErr)
+ 		}
++		if top != nil {
++			top.Shutdown(ctx)
++		}
+ 	}
+ }
+ ","Nit: is ""top"" a short name we use frequently? Seems a bit mysterious, and saves only 2 chars.",Why do we need this?
+8393,"@@ -52,7 +52,9 @@ import (
+ // R represents row type in executions table, valid values are:
+ // R = {Shard = 1, Execution = 2, Transfer = 3, Timer = 4, Replication = 5}
+ const (
+-	cassandraProtoVersion = 4
++	// ProtoVersion is the protocol version used to communicate with Cassandra cluster
++	ProtoVersion = 4
++
+ 	defaultSessionTimeout = 10 * time.Second
+ 	// Special Namespaces related constants
+ 	emptyNamespaceID = ""10000000-0000-f000-f000-000000000000""",This name is really confusing. May be just remove this const completely and hardcode `4` where it is used?,nit: `cassandraProto
+8394,"@@ -558,12 +558,6 @@ module RSpec::Core
+       context ""with single pattern"" do
+         before { config.pattern = ""**/*_foo.rb"" }
+ 
+-        it ""loads files following pattern"" do
+-          file = File.expand_path(File.dirname(__FILE__) + ""/resources/a_foo.rb"")
+-          assign_files_or_directories_to_run file
+-          expect(config.files_to_run).to include(file)
+-        end
+-
+         it ""loads files in directories following pattern"" do
+           dir = File.expand_path(File.dirname(__FILE__) + ""/resources"")
+           assign_files_or_directories_to_run dir",Why did you remove this spec?,Why was this test re
+8395,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+ 
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?,Why was this removed
+8396,"@@ -33,6 +33,12 @@ class Config(object):
+                               datetime.datetime.now().strftime('%Y%m%d%H%M%S'))
+         self.identifier = None
+         self.force_no_cloudshell = bool(kwargs.get('no_cloudshell'))
++        self.project_id = kwargs.get('project_id') or None
++        if kwargs.get('composite_root_resources'):
++            tmpcrr = kwargs.get('composite_root_resources')
++            self.composite_root_resources = tmpcrr.split(',')
++        else:
++            self.composite_root_resources = []
+         self.service_account_key_file = kwargs.get('service_account_key_file')
+         self.vpc_host_project_id = kwargs.get('vpc_host_project_id')
+         self.vpc_host_network = kwargs.get('vpc_host_network') or 'default'",".get will return None if there is no project_id key, so the or None part is redundant",This should be `kwargs.get('composite_root_resources') or []`
+8397,"@@ -22,11 +22,16 @@ namespace OpenTelemetry.Metrics
+ {
+     public struct MetricPoint
+     {
++        internal DateTimeOffset StartTime;
++        internal DateTimeOffset EndTime;
++
+         private readonly AggregationType aggType;
+         private readonly HistogramBuckets histogramBuckets;
+         private long longVal;
++        private long longValue;
+         private long lastLongSum;
+         private double doubleVal;
++        private double doubleValue;
+         private double lastDoubleSum;
+ 
+         internal MetricPoint(",Do they need to be `internal`?,Why do we need these two fields?
+8398,"@@ -176,7 +176,7 @@ func (b *PinnedMap) Iter(f MapIter) error {
+ 	args := cmd[1:]
+ 
+ 	printCommand(prog, args...)
+-	output, err := exec.Command(prog, args...).CombinedOutput()
++	output, err := exec.Command(prog, args...).Output()
+ 	if err != nil {
+ 		return errors.Errorf(""failed to dump in map (%s): %s\n%s"", b.versionedFilename(), err, output)
+ 	}","Hit a flake here where I think there may have been some output to stderr that got mixed in with the output from Stdout. Hence switching to `Output()`, which does also capture stderr as `err.Stderr`",Why did you remove the `CombinedOutput`?
+8399,"@@ -175,8 +175,8 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
+   {""cuMemcpy"",                                             {""hipMemcpy_"",                                              """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy2D due to different signatures
+-  {""cuMemcpy2D"",                                           {""hipMemcpy2D_"",                                            """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+-  {""cuMemcpy2D_v2"",                                        {""hipMemcpy2D_"",                                            """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemcpy2D"",                                           {""hipMemcpyParam2D"",                                        """", CONV_MEMORY, API_DRIVER}},
++  {""cuMemcpy2D_v2"",                                        {""hipMemcpyParam2D"",                                        """", CONV_MEMORY, API_DRIVER}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy2DAsync due to different signatures
+   {""cuMemcpy2DAsync"",                                      {""hipMemcpy2DAsync_"",                                       """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},",Is there any official CUDA API called cuMemcpy2D_v2?,Why did you remove the underscores?
+8400,"@@ -0,0 +1,7 @@
++package azkaban.imagemgmt.utils;
++
++public interface ImageMgmtConstants {
++  public static final String IMAGE_TYPE = ""imageType"";
++  public static final String IMAGE_VERSION = ""imageVersion"";
++
++}",Can you please move this interface as class in common Constants file in az-core module?,Why do we need these constants?
+8401,"@@ -43,12 +43,15 @@ TEST(ProcessUtils, isPidAvailable) {
+     }
+     {
+         // pid file which contains pid of current process
+-        auto pidFile = ""/tmp/maybe-non-existing-dir/process_test.pid"";
++        auto pidFile = folly::stringPrintf(""/tmp/non-existing-dir-%d/process_test.pid"", ::getpid());
++        SCOPE_EXIT {
++            ::unlink(pidFile.c_str());
++            ::rmdir(fs::FileUtils::dirname(pidFile.c_str()).c_str());
++        };
+         auto status = ProcessUtils::makePidFile(pidFile);
+         ASSERT_TRUE(status.ok()) << status;
+         status = ProcessUtils::isPidAvailable(pidFile);
+         ASSERT_FALSE(status.ok());
+-        ::unlink(pidFile);
+     }
+     {
+         // pid file not exist",Why not TempDir?,Why is this needed?
+8402,"@@ -0,0 +1,16 @@
++using System;
++using MvvmCross.Binding.BindingContext;
++using MvvmCross.Core.ViewModels;
++using MvvmCross.Core.Views;
++
++namespace MvvmCross.Forms.Views
++{
++    public interface IMvxElement : IMvxView, IMvxBindingContextOwner
++    {
++    }
++
++    public interface IMvxElement<TViewModel>
++        : IMvxElement, IMvxView<TViewModel> where TViewModel : class, IMvxViewModel
++    {
++    }
++}","IMvxFormsView -> IMvxElement is a breaking change, isn't it?",Why do we need this interface?
+8403,"@@ -33,6 +33,7 @@ import yaml
+ from molecule import config
+ from molecule import state
+ from molecule import utilities
++from molecule import ansible_galaxy_install
+ from molecule.provisioners import baseprovisioner
+ from molecule.provisioners import dockerprovisioner
+ from molecule.provisioners import openstackprovisioner",This should be imported alphabetically.,Why do we need this import?
+8404,"@@ -11,7 +11,7 @@ use Shopsys\FrameworkBundle\Component\Grid\Ordering\OrderableEntityInterface;
+ use Shopsys\FrameworkBundle\Component\Money\Money;
+ use Shopsys\FrameworkBundle\Model\Localization\AbstractTranslatableEntity;
+ use Shopsys\FrameworkBundle\Model\Payment\Payment;
+-use Shopsys\FrameworkBundle\Model\Pricing\Currency\Currency;
++use Shopsys\FrameworkBundle\Model\Pricing\Price;
+ use Shopsys\FrameworkBundle\Model\Transport\Exception\TransportDomainNotFoundException;
+ 
+ /**",Please apply same changes as for Payment,Why this change?
+8405,"@@ -55,9 +55,13 @@ import { Cell, Grid, Row } from '../material-components';
+ import PageHeader from './PageHeader';
+ import Layout from './layout/Layout';
+ import { CORE_WIDGETS } from '../googlesitekit/widgets/datastore/constants';
++import { useHasScrolledEffect } from '../hooks/useHasScrolledEffect';
++import ScrollEffect from './ScrollEffect';
+ const { useSelect } = Data;
+ 
+ function DashboardEntityApp() {
++	useHasScrolledEffect();
++
+ 	const currentEntityURL = useSelect( ( select ) =>
+ 		select( CORE_SITE ).getCurrentEntityURL()
+ 	);","This should only be used in the `ScrollEffect` component, as you have in the `DashboardMainApp` below  ",Why do we need t
+8406,"@@ -269,6 +269,8 @@ def api(require_login=True, schema=None, enabled=True,
+                               is_admin=user.is_admin,
+                               is_active=user.is_active)
+ 
++                g.token_str = token
++
+                 if not g.auth.is_active:
+                     raise ApiException(
+                         requests.codes.forbidden,","I'd call it `g.auth_token`, just to make it more clear",Why do we need t
+8407,"@@ -2,6 +2,9 @@ package protocol
+ 
+ import ""time""
+ 
++// DesiredReceiveBufferSize is the kernel UDP receive buffer size that we'd like to use.
++const DesiredReceiveBufferSize = (1 << 20) * 2 // 2 MB
++
+ // MaxPacketSizeIPv4 is the maximum packet size that we use for sending IPv4 packets.
+ const MaxPacketSizeIPv4 = 1252
+ ","Not sure if this is what we really need, we might need to adjust this constant after more extensive benchmarking.",I think this sho
+8408,"@@ -183,7 +183,10 @@ func RegisterRoutes(m *macaron.Macaron) {
+ 				m.Patch(""/hooks/:id:int"", bind(api.EditHookOption{}), repo.EditHook)
+ 				m.Get(""/raw/*"", middleware.RepoRef(), repo.GetRawFile)
+ 				m.Get(""/archive/*"", repo.GetArchive)
+-
++				m.Group(""/branches"", func() {
++					m.Get("""",repo.ListBranches)
++					m.Get(""/:id"",repo.GetBranch)
++				})
+ 				m.Group(""/keys"", func() {
+ 					m.Combo("""").Get(repo.ListDeployKeys).
+ 						Post(bind(api.CreateKeyOption{}), repo.CreateDeployKey)",Shouldn't we use `:branchname` here? Or just `:branch`?,"I think this should be `m.Group(""/branches"", func() {`"
+8409,"@@ -930,7 +930,7 @@ class RandUUID(RandField):
+ # Automatic timestamp
+ 
+ 
+-class AutoTime(VolatileValue):
++class AutoTime(RandNum):
+     def __init__(self, base=None):
+         if base is None:
+             self.diff = 0",`AutoTime` is a number but calling `int()` would make it crash. Tested through the docs,Why did you change this?
+8410,"@@ -333,7 +333,16 @@ namespace OpenTelemetry.Trace
+                         new EvictingQueue<KeyValuePair<string, object>>(this.tracerConfiguration.MaxNumberOfAttributes);
+                 }
+ 
+-                this.attributes.Add(new KeyValuePair<string, object>(key ?? string.Empty, sanitizedValue));
++                var attribute = this.attributes.FirstOrDefault(a => a.Key == (key ?? string.Empty));
++                var newAttribute = new KeyValuePair<string, object>(key ?? string.Empty, sanitizedValue);
++                if (attribute.Equals(default(KeyValuePair<string, object>)))
++                {
++                    this.attributes.Add(newAttribute);
++                }
++                else
++                {
++                    this.attributes.Replace(attribute, newAttribute);
++                }
+             }
+         }
+ ","@eddynaka Looks like the same block more or less 4 times, should we have a helper method? private void AddOrReplaceAttribute or something?",Why do we need this change?
+8411,"@@ -381,7 +381,8 @@ public class JettySolrRunner {
+         dispatchFilter = root.getServletHandler().newFilterHolder(Source.EMBEDDED);
+         dispatchFilter.setHeldClass(SolrDispatchFilter.class);
+         dispatchFilter.setInitParameter(""excludePatterns"", excludePatterns);
+-        root.addFilter(dispatchFilter, ""*"", EnumSet.of(DispatcherType.REQUEST));
++        // Map dispatchFilter in same path as in web.xml
++        root.addFilter(dispatchFilter, ""/*"", EnumSet.of(DispatcherType.REQUEST));
+ 
+         synchronized (JettySolrRunner.this) {
+           waitOnSolr = true;",Please do the same for the DebugFilter a few lines above.,Why is this change needed?
+8412,"@@ -0,0 +1,2 @@
++export * from './act';
++export * from './setupRerender';","Minor nit: Just inline both functions here. No need to make a file per function (that's a popular approach for some projects though, just not for us :) ).",
+8413,"@@ -28,6 +28,18 @@ namespace Datadog.Trace.Configuration
+         {
+         }
+ 
++        /// <summary>
++        /// Initializes a new instance of the <see cref=""TracerSettings""/> class with default values,
++        /// or using the default sources. Calling <c>new TracerSettings(true)</c> is equivalent to
++        /// calling <c>TracerSettings.FromDefaultSources()</c>
++        /// </summary>
++        /// <param name=""useDefaultSources"">If <c>true</c>, creates a <see cref=""TracerSettings""/> populated from
++        /// the default sources such as environment variables etc. If <c>false</c>, uses the default values.</param>
++        public TracerSettings(bool useDefaultSources)
++            : this(useDefaultSources ? CreateDefaultConfigurationSource() : null)
++        {
++        }
++
+         /// <summary>
+         /// Initializes a new instance of the <see cref=""TracerSettings""/> class
+         /// using the specified <see cref=""IConfigurationSource""/> to initialize values.","There are several uses of the word ""default"" in here, perhaps it can be reworded slightly?",n
+8414,"@@ -50,7 +50,7 @@ class MediaType extends AbstractType
+             'new_on_update' => $options['new_on_update'],
+         )));
+ 
+-        $builder->addEventListener(FormEvents::BIND, function (FormEvent $event) {
++        $builder->addEventListener(FormEvents::SUBMIT, function(FormEvent $event) {
+             if ($event->getForm()->has('unlink') && $event->getForm()->get('unlink')->getData()) {
+                 $event->setData(null);
+             }",`function (` is correct. A space must be there. Please run `make cs` to have correct coding style.,W
+8415,"@@ -18,7 +18,7 @@ function pageNoDuplicateEvaluate(node, options, virtualNode) {
+   cache.set(key, true);
+ 
+   let elms = querySelectorAllFilter(axe._tree[0], options.selector, elm =>
+-    isVisible(elm.actualNode)
++    isVisible(elm.actualNode, true)
+   );
+ 
+   // Filter elements that, within certain contexts, don't map their role.","I think this is now going to fail the scenario where there is a `main` with aria-hidden=""true"". I don't think that should fail.",I
+8416,"@@ -83,7 +83,7 @@ func NewSublist() *Sublist {
+ // Insert adds a subscription into the sublist
+ func (s *Sublist) Insert(sub *subscription) error {
+ 	// copy the subject since we hold this and this might be part of a large byte slice.
+-	subject := string(append([]byte(nil), sub.subject...))
++	subject := string(sub.subject)
+ 	tsa := [32]string{}
+ 	tokens := tsa[:0]
+ 	start := 0","Is this specifically that if we capture the cast in another variable, even if it passes escape analysis, that the runtime will copy?",Why do we need to do this?
+8417,"@@ -108,6 +108,10 @@ type EKSConfig struct {
+ 	// Fargate controls the configuration of the AWS IAM role for
+ 	// used by EKS managed machine pools.
+ 	Fargate *AWSIAMRoleSpec `json:""fargate,omitempty""`
++	// KMSAliasPrefix is prefix to use to restrict permission to KMS keys to only those that have an alias
++	// name that is prefixed by this.
++	// Defaults to cluster-api-provider-aws-*
++	KMSAliasPrefix string `json:""kmsAliasPrefix,omitempty""`
+ }
+ 
+ // EventBridgeConfig represents configuration for enabling experimental feature to consume",Should this be optional for existing configs to work?,I think this should be `km
+8418,"@@ -119,12 +119,14 @@ func (s *Service) Pay(ctx context.Context, peer swarm.Address, amount uint64) er
+ 		}
+ 		return ErrUnknownBeneficary
+ 	}
+-	err = s.chequebook.Issue(ctx, beneficiary, big.NewInt(int64(amount)), func(signedCheque *chequebook.SignedCheque) error {
++	balance, err := s.chequebook.Issue(ctx, beneficiary, big.NewInt(int64(amount)), func(signedCheque *chequebook.SignedCheque) error {
+ 		return s.proto.EmitCheque(ctx, peer, signedCheque)
+ 	})
+ 	if err != nil {
+ 		return err
+ 	}
++
++	s.metrics.AvailableBalance.Set(float64(balance.Int64()))
+ 	s.metrics.TotalSent.Add(float64(amount))
+ 	return nil
+ }","note that `balance` does not necessarily fit into `int64`, especially with the new bzz token. so you might want to avoid the `int64` conversion step using `big.NewFloat(0).SetInt(balance).Float64()`.",Why do we need this?
+8419,"@@ -96,7 +96,12 @@ int main(int argc, const char *argv[]) {
+       flatbuffers::IDLOptions::kPhp,
+       ""Generate PHP files for tables/structs"",
+       flatbuffers::GeneralMakeRule },
+-    };
++   { flatbuffers::GenerateJsonSchema, ""-S"", ""--jsonschema"", ""JsonSchema"", true,
++      nullptr,
++      flatbuffers::IDLOptions::kJsonSchema,
++      ""Generate Json schema"",
++      flatbuffers::GeneralMakeRule },
++  };
+ 
+   flatbuffers::FlatCompiler::InitParams params;
+   params.generators = generators;",lets leave out the `-S` ?,Why is this needed?
+8420,"@@ -112,4 +112,9 @@ public class CommonRenderingUtil {
+   public static int toInt(String value) {
+     return Integer.valueOf(value);
+   }
++
++  /** Returns the lowercase version of the given text */
++  public static String lowercase(String value) {
++    return value.toLowerCase();
++  }
+ }",Is this method needed?,Why do we need this method?
+8421,"@@ -127,6 +127,7 @@ void PoolingLayer<Dtype>::Reshape(const vector<Blob<Dtype>*>& bottom,
+ template <typename Dtype>
+ void PoolingLayer<Dtype>::Forward_cpu(const vector<Blob<Dtype>*>& bottom,
+       const vector<Blob<Dtype>*>& top) {
++  PoolingParameter pool_param = this->layer_param_.pooling_param();
+   const Dtype* bottom_data = bottom[0]->cpu_data();
+   Dtype* top_data = top[0]->mutable_cpu_data();
+   const int top_count = top[0]->count();","How about, instead of reading the param every time, just add a class member variable to hold the value of the flag, and just set it once during `LayerSetUp`?",Why do we need this?
+8422,"@@ -99,7 +99,7 @@ func (e *ECS) Service(clusterName, serviceName string) (*Service, error) {
+ 	return nil, fmt.Errorf(""cannot find service %s"", serviceName)
+ }
+ 
+-// ServiceTasks calls ECS API and returns ECS tasks running by a service.
++// ServiceTasks calls ECS API and returns ECS tasks desired to be running by a service.
+ func (e *ECS) ServiceTasks(cluster, service string) ([]*Task, error) {
+ 	return e.listTasks(cluster, withService(service))
+ }",Does this mean it's only returning tasks associated with the primary deployment? or something else,`desired to be running by a
+8423,"@@ -1101,6 +1101,11 @@ func TestRequestNoConnection(t *testing.T) {
+ 		t.Fatal(""expect error, but got none"")
+ 	}
+ 
++	t.Log(err)
++	awsError := err.(awserr.Error)
++	origError := awsError.OrigErr()
++	t.Logf(""Orig Error: %#v of type %T"", origError, origError)
++
+ 	if e, a := 10, r.RetryCount; e != a {
+ 		t.Errorf(""expect %v retry count, got %v"", e, a)
+ 	}","nit, would be good to include prefix for this log statement.",I think this should be `t.F
+8424,"@@ -57,4 +57,12 @@ describe('aria-required-attr', function () {
+ 		axe.commons.aria.requiredAttr = orig;
+ 	});
+ 
++	describe('options', function () {
++		it('should require provided attribute names', function () {
++			fixture.innerHTML = '<div role=""slider"" id=""target""></div>';
++			var target = fixture.children[0];
++			assert.isFalse(checks['aria-required-attr'].evaluate.call(checkContext, target, ['aria-valuemax', 'aria-bats']));
++			assert.deepEqual(checkContext._data, ['aria-valuenow', 'aria-valuemax', 'aria-valuemin', 'aria-bats']);
++		});
++	});
+ });","Same here, you should use a made up role. May I suggest `role=""McCheddarton""`? :)",I don't think we need this test.
+8425,"@@ -372,7 +372,9 @@ class SparkWrite {
+       }
+ 
+       Expression conflictDetectionFilter = conflictDetectionFilter();
+-      overwriteFiles.validateNoConflictingAppends(conflictDetectionFilter);
++      overwriteFiles.conflictDetectionFilter(conflictDetectionFilter);
++      overwriteFiles.validateNoConflictingData();
++      overwriteFiles.validateNoConflictingDeletes();
+ 
+       String commitMsg = String.format(
+           ""overwrite of %d data files with %d new data files, scanSnapshotId: %d, conflictDetectionFilter: %s"",","@aokolnychyi, shouldn't this check whether the operation is a delete? If this is invoked by `DELETE FROM` then we don't need to validate conflicting deletes.",I think this should be `validate
+8426,"@@ -11,8 +11,9 @@ import (
+ 	""reflect""
+ 	""sync""
+ 
+-	""github.com/keybase/kbfs/kbfscodec""
+ 	""golang.org/x/net/context""
++
++	""github.com/keybase/kbfs/kbfscodec""
+ )
+ 
+ const (","Any reason to split up this import block? I think most files have them together in one block, right?",Why did you change this?
+8427,"@@ -109,6 +109,18 @@ namespace Datadog.Trace.AppSec
+ 
+         internal SecuritySettings Settings => _settings;
+ 
++        private static void TagSpan(Span span)
++        {
++            // we should only tag service entry span, the first span opened for a
++            // service. For WAF it's safe to assume we always have service entry spans
++            // we'll need to revisit this for RASP.
++            if (span != null)
++            {
++                span.SetMetric(Tags.AppSecEnabled, 1.0);
++                span.SetTag(Tags.RuntimeFamily, TracerConstants.Language);
++            }
++        }
++
+         /// <summary>
+         /// Frees resouces
+         /// </summary>",`Tags.AppSecEnabled` should probably move to `Metrics.AppSecEnabled` I guess?,I'm not sure if this is the best
+8428,"@@ -35,6 +35,9 @@ class atomic_file(AtomicLocalFile):
+     Also cleans up the temp file if close is not invoked
+     """"""
+ 
++    def __init__(self, path, mode):
++        super(AtomicLocalFile, self).__init__(path, mode)
++
+     def move_to_final_destination(self):
+         os.rename(self.tmp_path, self.path)
+ ","What happens if you remove this? Can't you still initialize this atomic_file class, since it's just AtomicLocalFile with an additional method (move_to_final_destination)?",Why do we need this?
+8429,"@@ -34,7 +34,6 @@
+     <h2><div class='icon partners'></div><%= t "".partners_title"" %></h2>
+     <p><%= t 'layouts.partners_html',
+              :ucl => link_to(t('layouts.partners_ucl'), ""https://www.ucl.ac.uk""),
+-             :ic => link_to(t('layouts.partners_ic'), ""https://www.imperial.ac.uk/""),
+              :bytemark => link_to(t('layouts.partners_bytemark'), ""https://www.bytemark.co.uk""),
+              :partners => link_to(t('layouts.partners_partners'), ""https://hardware.openstreetmap.org/thanks/"") %>
+     </p>",As previously discussed in #1944 it's not safe to remove IC like this as it will break every language that still has a `%{ic}` marker in the translation.,Why is this removed?
+8430,"@@ -293,6 +293,19 @@ func (r *DefaultRuleRenderer) endpointIptablesChain(
+ 		},
+ 	})
+ 
++	rules = append(rules, Rule{
++		Match: Match().ProtocolNum(ProtoUDP).
++			DestPorts(uint16(r.Config.VXLANPort)).
++			VXLANVNI(uint32(r.Config.VXLANVNI)),
++		Action:  DropAction{},
++		Comment: ""Drop VXLAN encapped packets originating in pods"",
++	})
++	rules = append(rules, Rule{
++		Match:   Match().ProtocolNum(ProtoIPIP),
++		Action:  DropAction{},
++		Comment: ""Drop IPinIP encapped packets originating in pods"",
++	})
++
+ 	if len(policyNames) > 0 {
+ 		// Clear the ""pass"" mark.  If a policy sets that mark, we'll skip the rest of the policies and
+ 		// continue processing the profiles, if there are any.","I believe these rules will be enforced both (1) on egress from a local workload, and (2) on ingress **to** a local workload. Right? I understand that we definitely want (1), but do we really want to enforce (2) as well?",I don't think we wan
+8431,"@@ -368,6 +368,8 @@ class RemoteConnection(object):
+                 ('POST', '/session/$sessionId/window/rect'),
+             Command.GET_WINDOW_RECT:
+                 ('GET', '/session/$sessionId/window/rect'),
++            Command.W3C_MINIMIZE_WINDOW:
++                ('POST', '/session/$sessionId/window/minimize'),
+             Command.MAXIMIZE_WINDOW:
+                 ('POST', '/session/$sessionId/window/$windowHandle/maximize'),
+             Command.W3C_MAXIMIZE_WINDOW:",Update after command rename,I think this should 
+8432,"@@ -79,7 +79,7 @@ module Faker
+         digits = Faker::Number.leading_zero_number(9) until digits&.match(/(\d)((?!\1)\d)+/)
+         first_digit = brazilian_citizen_number_checksum_digit(digits)
+         second_digit = brazilian_citizen_number_checksum_digit(digits + first_digit)
+-        [digits, first_digit, second_digit].join
++        ""#{digits.gsub(/(\d{3})(?=\d)/, '\1.')}-#{first_digit}#{second_digit}""
+       end
+ 
+       private",What about adding an optional parameter that allows users to choose whether they want to use the format or not?,"I'm not sure if this is the best way to do this, but I'm not sure if this is the best way to do it."
+8433,"@@ -35,8 +35,8 @@ func TestChainHead(t *testing.T) {
+ 
+ func TestChainLs(t *testing.T) {
+ 	tf.IntegrationTest(t)
+-	ctx := context.Background()
+ 	t.Skip(""DRAGONS: fake post for integration test"")
++	ctx := context.Background()
+ 
+ 	t.Run(""chain ls with json encoding returns the whole chain as json"", func(t *testing.T) {
+ 		builder := test.NewNodeBuilder(t)",Lint didn't like this context being before the skip,Why this change?
+8434,"@@ -0,0 +1,18 @@
++package tequilapi
++
++import ""net/http""
++
++type corsHandler struct {
++	originalHandler http.Handler
++}
++
++func (wrapper corsHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
++	resp.Header().Set(""Access-Control-Allow-Origin"", ""*"")
++	resp.Header().Set(""Access-Control-Allow-Methods"", ""POST, GET, OPTIONS, PUT, DELETE"")
++	wrapper.originalHandler.ServeHTTP(resp, req)
++}
++
++//ApplyCors wraps original handler by adding cors headers to response BEFORE original ServeHTTP method is called
++func ApplyCors(original http.Handler) http.Handler {
++	return corsHandler{original}
++}",so now basically anybody could drink my tequila? currently electron dev-env runs on `http://localhost:9080`,Why is this needed?
+8435,"@@ -259,7 +259,7 @@ bool Plugin::loadLib(ILXQtPanelPluginLibrary const * pluginLib)
+     mPlugin = pluginLib->instance(startupInfo);
+     if (!mPlugin)
+     {
+-        qWarning() << QString(""Can't load plugin \""%1\"". Plugin can't build ILXQtPanelPlugin."").arg(mPluginLoader->fileName());
++        qWarning() << QString(""Can't load plugin \""%1\"". Plugin can't build ILXQtPanelPlugin."").arg(mDesktopFile.id());
+         return false;
+     }
+ ","`mPluginLoader` is nullptr in static plugins, which causes segmentation faults",Shouldn't this be `mDesktopFile.fileName()`?
+8436,"@@ -1,12 +1,8 @@
+ package org.phoenicis.javafx.views.mainwindow.ui;
+ 
+-import javafx.event.ActionEvent;
+-import javafx.event.EventHandler;
+-import org.phoenicis.javafx.views.common.ThemeManager;
+-
+ import javafx.beans.property.StringProperty;
+-import javafx.scene.control.TextField;
+ import javafx.scene.control.Button;
++import javafx.scene.control.TextField;
+ import javafx.scene.layout.AnchorPane;
+ 
+ import java.util.function.Consumer;",Better use `Optional<Consumer<String>> onSearch` here.,Why did you remove these imports?
+8437,"@@ -16,7 +16,6 @@ BOOST_AUTO_TEST_CASE(rfc4648_test_vectors)
+ {
+     using namespace osrm::engine;
+ 
+-    BOOST_CHECK_EQUAL(encodeBase64(""""), """");
+     BOOST_CHECK_EQUAL(encodeBase64(""f""), ""Zg=="");
+     BOOST_CHECK_EQUAL(encodeBase64(""fo""), ""Zm8="");
+     BOOST_CHECK_EQUAL(encodeBase64(""foo""), ""Zm9v"");",this is asserted as invalid input,Why was this removed?
+8438,"@@ -10,12 +10,15 @@ import (
+ 	""time""
+ 
+ 	""github.com/thought-machine/please/src/core""
++	""github.com/thought-machine/please/src/parse""
+ )
+ 
+ // Print produces a Python call which would (hopefully) regenerate the same build rule if run.
+ // This is of course not ideal since they were almost certainly created as a java_library
+ // or some similar wrapper rule, but we've lost that information by now.
+-func Print(graph *core.BuildGraph, targets []core.BuildLabel, fields, labels []string) {
++func Print(state *core.BuildState, targets []core.BuildLabel, fields, labels []string) {
++	graph := state.Graph
++	order := parse.NewAspParser(state).BuildRuleArgOrder()
+ 	for _, target := range targets {
+ 		t := graph.TargetOrDie(target)
+ 		if len(labels) > 0 {",Why do you need to create a new parser? Can't you just use `state.Parser` to answer this question?,I'm not sure if this is the right
+8439,"@@ -155,5 +155,10 @@ namespace Nethermind.Core
+             HashNumberDiffAndTx,
+             Short
+         }
++        
++        public virtual Block CreateBlockForProcessing(BlockHeader header) => 
++            new(header, Transactions, Ommers);
++
++        public virtual IEnumerable<Transaction> GetTransactions() => Transactions;
+     }
+ }","remove processing references from Nethermind.Core where possible, keep clean",Why do we need this?
+8440,"@@ -0,0 +1,7 @@
++package com.fsck.k9.mail.internet;
++
++public class UnsupportedContentTransferEncodingException extends Exception {
++    public UnsupportedContentTransferEncodingException(String encoding) {
++        super(""Unsupported encoding: ""+encoding);
++    }
++}",Why not make this a subclass of `MessagingException` so we don't need to change all `throws` clause?,Missing license header.
+8441,"@@ -22,6 +22,8 @@ import qrcode
+ import traceback
+ from hashlib import sha256
+ from decimal import Decimal
++import binascii
++from .drbg.hmac_drbg import DRBG
+ 
+ from PyQt5.QtPrintSupport import QPrinter
+ ","it should instead be `from .hmac_drbg import DRBG` also, please put it at the bottom of the imports (PEP 8 order), so near line 36",Why is this needed?
+8442,"@@ -138,12 +138,13 @@ class SchemaUpdate implements UpdateSchema {
+       parentId = parentField.fieldId();
+       Preconditions.checkArgument(!deletes.contains(parentId),
+           ""Cannot add to a column that will be deleted: %s"", parent);
+-      Preconditions.checkArgument(schema.findField(parent + ""."" + name) == null,
+-          ""Cannot add column, name already exists: %s.%s"", parent, name);
++      Preconditions.checkArgument(schema.findField(parent + ""."" + name) == null ||
++                      deletes.contains(schema.findField(parent + ""."" + name).fieldId()),
++          ""Cannot add column, name already exists and is not being deleted: %s.%s"", parent, name);
+       fullName = schema.findColumnName(parentId) + ""."" + name;
+     } else {
+-      Preconditions.checkArgument(schema.findField(name) == null,
+-          ""Cannot add column, name already exists: %s"", name);
++      Preconditions.checkArgument(schema.findField(name) == null || deletes.contains(schema.findField(name).fieldId()),
++          ""Cannot add column, name already exists and is not being deleted: %s"", name);
+       fullName = name;
+     }
+ ",Nit: indentation is 2 indents (4 spaces) from the previous line.,I don't think we need t
+8443,"@@ -224,7 +224,7 @@ func (c *Config) RenderComposeYAML() (string, error) {
+ 		// path.Join is desired over filepath.Join here,
+ 		// as we always want a unix-style path for the mount.
+ 		""docroot"":     path.Join(""../"", c.Docroot),
+-		""plugin"":      c.Platform,
++		""plugin"":      ""ddev"",
+ 		""appType"":     c.AppType,
+ 		""mailhogport"": appports.GetPort(""mailhog""),
+ 		""dbaport"":     appports.GetPort(""dba""),",I don't understand why this is changing to a hard-coded string.,Why do we need this cha
+8444,"@@ -24,7 +24,7 @@ import (
+ // Devnet is a FAST lib environment that is meant to be used
+ // when working with kittyhawk devnets run by the Filecoin development team.
+ type Devnet struct {
+-	network  string
++	network  DevnetConfig
+ 	location string
+ 
+ 	log logging.EventLogger",nit: perhaps calling this `config` would be more clear?,Why do we need this?
+8445,"@@ -110,7 +110,7 @@ de_DE.strings = {
+     '1': '+%{smart_count} Dateien hochladen',
+     '2': '+%{smart_count} Dateien hochladen',
+   },
+-  uploading: 'Uploading',
++  uploading: 'Lade hoch',
+   uploadingXFiles: {
+     '0': '%{smart_count} Datei wird hochgeladen',
+     '1': '%{smart_count} Dateien werden hochgeladen',",I would rather recommend using 'Wird hochgeladen' since the imperative form of 'Lade hoch' confuses me whether this is an action I need to do or whether it's an action that Uppy is currently doing. Just my two cents.,Prefer single-quoted
+8446,"@@ -30,6 +30,8 @@ const (
+ 	defaultDataDir  = "".""
+ 	defaultLogLevel = ""INFO""
+ 	defaultUmask    = 0077
++
++	minimumUmask = 0027
+ )
+ 
+ // RunConfig represents the available configurables for file",Hmm I would have expected this to go away? What role does it play now that we have a minimum?,Why is this needed?
+8447,"@@ -3,12 +3,6 @@
+ const MongoNetworkError = require('./core').MongoNetworkError;
+ const mongoErrorContextSymbol = require('./core').mongoErrorContextSymbol;
+ 
+-const GET_MORE_NON_RESUMABLE_CODES = new Set([
+-  136, // CappedPositionLost
+-  237, // CursorKilled
+-  11601 // Interrupted
+-]);
+-
+ // From spec@https://github.com/mongodb/specifications/blob/f93d78191f3db2898a59013a7ed5650352ef6da8/source/change-streams/change-streams.rst#resumable-error
+ const GET_MORE_RESUMABLE_CODES = new Set([
+   6, // HostUnreachable","if we are removing this, is it useful to have the `isGetMoreError` message below? If that's not required, can we also remove the `mongoErrorContextSymbol` outright?",Why is this removed?
+8448,"@@ -59,11 +59,7 @@ public:
+     void helper_block_for_at_least_entries(
+             uint32_t amount)
+     {
+-        std::unique_lock<std::mutex> lck(*xml_mutex_);
+-        mock_consumer->cv().wait(lck, [this, amount]
+-                {
+-                    return mock_consumer->ConsumedEntriesSize_nts() >= amount;
+-                });
++        mock_consumer->wait_for_at_least_entries(amount);
+     }
+ 
+     eprosima::fastdds::dds::MockConsumer* mock_consumer;",I think this mutex is only used here. Remove it.,Why do we need this lock?
+8449,"@@ -181,7 +181,16 @@ public class IndexSearcher {
+   }
+ 
+   /** Runs searches for each segment separately, using the
+-   *  provided Executor. NOTE:
++   *  provided Executor. The passed in Executor will also be
++   *  used by LRUQueryCache (if enabled) to perform asynchronous
++   *  query caching.
++   *  If a task is rejected by the host Executor, the failed task
++   *  will then be executed on the caller thread. This is done to
++   *  ensure that a query succeeds, albeit with a higher latency.
++   *  If a user wishes to modify the said behaviour, they can either
++   *  handle the exception in the provided Executor, or override
++   *  the said method in a custom extension of IndexSearcher.
++   *  NOTE:
+    *  if you are using {@link NIOFSDirectory}, do not use
+    *  the shutdownNow method of ExecutorService as this uses
+    *  Thread.interrupt under-the-hood which can silently",it's unclear to me which method you are recommending overriding?,"nit: ""albeit with a highe"
+8450,"@@ -511,7 +511,7 @@ class StringFormatChecker(BaseChecker):
+ 
+         check_args = False
+         # Consider ""{[0]} {[1]}"" as num_args.
+-        num_args += sum(1 for field in named_fields if field == """")
++        num_args += sum(1 for field in named_fields if not field)
+         if named_fields:
+             for field in named_fields:
+                 if field and field not in named_arguments:","This make me think that if the typing of a variable is inconsistent it could cause problem. For example here, if `field == 0`, the behavior is not exactly the same. A `0` and is implicitelty false. Well it works because summing 0 is neutral, but what if it was a multiplication ?",Why this change?
+8451,"@@ -4,12 +4,13 @@ import (
+ 	""bytes""
+ 	""errors""
+ 	""fmt""
+-	""github.com/libopenstorage/openstorage/api""
+-	""github.com/libopenstorage/openstorage/api/client""
+-	""github.com/libopenstorage/openstorage/volume""
+ 	""io""
+ 	""io/ioutil""
+ 	""strconv""
++
++	""github.com/libopenstorage/openstorage/api""
++	""github.com/libopenstorage/openstorage/api/client""
++	""github.com/libopenstorage/openstorage/volume""
+ )
+ 
+ const (",Remove this file from the PR,nit: remove empty line
+8452,"@@ -35,9 +35,9 @@ namespace Nethermind.Precompiles.Benchmark
+             // BenchmarkRunner.Run<Bn256MulBenchmark>();
+             // BenchmarkRunner.Run<Bn256PairingBenchmark>();
+             BenchmarkRunner.Run<ModExp2565Benchmark>();
+-            BenchmarkRunner.Run<ModExpBenchmark>();
++            // BenchmarkRunner.Run<ModExpBenchmark>();
+             Console.ReadLine();
+         }
+ #endif
+     }
+-}
++}",I cannot find the changes / results of the eip2565 benchmark,nit: remove this line
+8453,"@@ -151,7 +151,7 @@ const withData = (
+ 				'googlesitekit.moduleDataReset',
+ 				'googlesitekit.moduleDataResetHandler',
+ 				() => {
+-					this.setState( { data: false } );
++					this.setState( { data: false, zeroData: false } );
+ 				}
+ 			);
+ ","@tofumatt now that I see this in context, we're now resetting 2/3 of the keys in the `NewComponent` state - the other being `error`. It seems that `error` should probably also be reset - essentially resetting all of the component state when the date range changes. What do you think? cc: @felixarntz @adamsilverstein",Why is this needed?
+8454,"@@ -32,7 +32,11 @@ namespace OpenTelemetry.Trace.Export
+ 
+         public override Task ShutdownAsync(CancellationToken cancellationToken)
+         {
++#if NET452
++            return Task.FromResult(0);
++#else
+             return Task.CompletedTask;
++#endif
+         }
+     }
+ }",This one and the ones below are for shutdowns but if it appears in some method called frequently during the lifetime of the process it should be cached in a static.,Why is this needed?
+8455,"@@ -5540,7 +5540,9 @@ describe('Model', function() {
+ 
+         return co(function*() {
+           const createdUser = yield User.create({ name: 'Hafez' });
+-          let threw = false;
++
++          let err;
++
+           try {
+             yield User.bulkWrite([{
+               updateOne: {","Better to just do `const err = yield User.bulkWrite(ops).then(() => null, err => err);` so you don't need to write out the whole `try/catch` block.",Why is this change ne
+8456,"@@ -453,7 +453,7 @@ func evmErrToErrStatusCode(evmErr error, g genesis.Blockchain, height uint64) (e
+ // intrinsicGas returns the intrinsic gas of an execution
+ func intrinsicGas(data []byte) (uint64, error) {
+ 	dataSize := uint64(len(data))
+-	if action.ExecutionDataGas == 0 || (math.MaxInt64-action.ExecutionBaseIntrinsicGas)/action.ExecutionDataGas < dataSize {
++	if (math.MaxInt64-action.ExecutionBaseIntrinsicGas)/action.ExecutionDataGas < dataSize {
+ 		return 0, action.ErrInsufficientFunds
+ 	}
+ ",`action.ExecutionDataGas = 100`,Why this change?
+8457,"@@ -124,6 +124,9 @@ class GalleryControllerTest extends TestCase
+         $this->assertSame([$media], $gController->getGalleryMediasAction(1));
+     }
+ 
++    /**
++     * @group legacy
++     */
+     public function testPostGalleryMediaGalleryhasmediaAction()
+     {
+         $media = $this->createMock(MediaInterface::class);",@supersmile2009 please review. Is it right to mark this as legacy? Are we testing the legacy path here? Are there tests for the non-legacy path?,Why is this grou
+8458,"@@ -112,11 +112,14 @@ func (c *Controller) getSpcResource(key string) (*apis.StoragePoolClaim, error)
+ 		// The SPC resource may no longer exist, in which case we stop
+ 		// processing.
+ 		if errors.IsNotFound(err) {
++			
+ 			runtime.HandleError(fmt.Errorf(""spcGot '%s' in work queue no longer exists"", key))
+-			return nil, err
+ 		}
+-
+-		return nil, err
++		// No need to return error to caller as we still want to fire the delete handler
++		// using the spc key(name)
++		// If error is returned the caller function will return without calling the spcEventHandler
++		// function that invokes business logic for pool deletion
++		return nil,nil
+ 	}
+ 	return spcGot, nil
+ }",getSpcResource should not be bothered about deletion. Can we have `separation of concerns` for this logic?,nit: space after
+8459,"@@ -4596,11 +4596,11 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         >>> merged.sort_values(by=['lkey', 'value_x', 'rkey', 'value_y'])
+           lkey  value_x rkey  value_y
+         0  bar        2  bar        6
+-        1  baz        3  baz        7
+-        2  foo        1  foo        5
+-        3  foo        1  foo        8
+-        4  foo        5  foo        5
+-        5  foo        5  foo        8
++        5  baz        3  baz        7
++        1  foo        1  foo        5
++        2  foo        1  foo        8
++        3  foo        5  foo        5
++        4  foo        5  foo        8
+ 
+         >>> left_kdf = ks.DataFrame({'A': [1, 2]})
+         >>> right_kdf = ks.DataFrame({'B': ['x', 'y']}, index=[1, 2])",This is actually matched with pandas's result since the output is sorted.,why did you chan
+8460,"@@ -37,12 +37,12 @@ var ConfigCmd = &cobra.Command{
+ 
+ // Config defines the config schema
+ type Config struct {
+-	Endpoint   string            `yaml:""endpoint""""`
+-	WalletList map[string]string `yaml:""walletList""`
++	Endpoint    string            `yaml:""endpoint""""`
++	AccountList map[string]string `yaml:""walletList""`
+ }
+ 
+ func init() {
+-	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl""
++	ConfigDir = os.Getenv(""HOME"") + ""/.config/ioctl/default""
+ 	if err := os.MkdirAll(ConfigDir, 0700); err != nil {
+ 		fmt.Println(err.Error())
+ 		os.Exit(1)","struct field tag `yaml:""endpoint""""` not compatible with reflect.StructTag.Get: key:""value"" pairs not separated by spaces (from `govet`)",Why do we need to change this?
+8461,"@@ -41,6 +41,8 @@ TopicImpl::TopicImpl(
+     , qos_(&qos == &TOPIC_QOS_DEFAULT ? participant_->get_default_topic_qos() : qos)
+     , listener_(listen)
+     , user_topic_(nullptr)
++    , handle_()
++    , num_refs_(0u)
+ {
+ }
+ ",This is not necessary. Topic inherits from DomainEntity which already has instance_handle_,nit: `num_refs_` -> `num_refs`
+8462,"@@ -31,7 +31,7 @@ func TestICMPPortUnreachable(t *testing.T) {
+ 	_, ipv4, _, _, pktBytes, err := testPacketUDPDefault()
+ 	Expect(err).NotTo(HaveOccurred())
+ 
+-	runBpfUnitTest(t, ""icmp_port_unreachable.c"", func(bpfrun bpfProgRunFn) {
++	runBpfUnitTest(t, ""icmp_port_unreachable.c"", false, func(bpfrun bpfProgRunFn) {
+ 		res, err := bpfrun(pktBytes)
+ 		Expect(err).NotTo(HaveOccurred())
+ 		Expect(res.Retval).To(Equal(0))","Do we need the forXDP parameter in runBpfUnitTest? If not, I think better to revert in order to save a few changes.",Why is this change needed?
+8463,"@@ -68,8 +68,8 @@ func (c *cstorSnapshotCommand) validateOptions() error {
+ 	return nil
+ }
+ 
+-// getSnapshotObj returns a filled object of CASSnapshot
+-func (c *cstorSnapshotCommand) getSnapshotObj() *apis.CASSnapshot {
++// casSnapshot returns a filled object of CASSnapshot
++func (c *cstorSnapshotCommand) casSnapshot() *apis.CASSnapshot {
+ 	volName, _ := c.Data[""volname""].(string)
+ 	snapName, _ := c.Data[""snapname""].(string)
+ 	return &apis.CASSnapshot{",All the code that reference to this function must also be changed.,I think this should be renamed
+8464,"@@ -49,4 +49,12 @@ public interface UserManager {
+   public Role getRole(String roleName);
+ 
+   public boolean validateProxyUser(String proxyUser, User realUser);
++
++  /**
++   * @param username e.g. user alias
++   * @param groupName e.g. name of hadoop headless group / LDAP group
++   * @return Returns true if the user belongs to a group. This is used when verifying user
++   * permission by checking its group membership
++   */
++  public boolean validateUserGroupMembership(String username, String groupName);
+ }",How is this new interface different from existing `validateProxyUser` method? If I understand correctly the `proxyUser` parameter is essentially a group and the method should verify if `realUser` belongs to it.,Why do we need this method?
+8465,"@@ -38,6 +38,7 @@ using Nethermind.Store;
+ using Nethermind.Store.Bloom;
+ using Nethermind.TxPool;
+ using NUnit.Framework;
++using BlockTree = Nethermind.Blockchain.BlockTree;
+ 
+ namespace Nethermind.JsonRpc.Test.Modules.Trace
+ {",Do we have namespace conflicts?,Why is this needed?
+8466,"@@ -224,7 +224,7 @@ func (s *server) run(ctx context.Context, t cli.Telemetry) error {
+ 		if s.useFakeResponse {
+ 			service = api.NewFakeWebAPI()
+ 		} else {
+-			service = api.NewWebAPI(ds, sls, alss, cmds, cfg.ProjectMap(), encryptDecrypter, t.Logger)
++			service = api.NewWebAPI(ctx, ds, sls, alss, cmds, cfg.ProjectMap(), encryptDecrypter, cfg.Cache.TTLDuration(), t.Logger)
+ 		}
+ 		opts := []rpc.Option{
+ 			rpc.WithPort(s.webAPIPort),","We have several groups of caches so I think we should not use this shared configuration value for all of them. Instead of that, each cache group should have a separate configuration field, and the added `validation cache` should have its own field too. But this point, they can be fixed by `24h`.",I don't think we need to pa
+8467,"@@ -26,12 +26,12 @@ class Replicate implements AdapterInterface, MetadataSupporter
+     /**
+      * @var AdapterInterface
+      */
+-    protected $master;
++    protected $primary;
+ 
+     /**
+      * @var AdapterInterface
+      */
+-    protected $slave;
++    protected $secondary;
+ 
+     /**
+      * @var LoggerInterface","This is a BC break for extending classes, it can't be done on 3.x",Why did you change this?
+8468,"@@ -950,10 +950,13 @@ class Key(object):
+             if isinstance(md5, bytes):
+                 md5 = md5.decode('utf-8')
+ 
+-            if self.etag != '""%s""' % md5:
+-                raise provider.storage_data_error(
+-                    'ETag from S3 did not match computed MD5. '
+-                    '%s vs. %s' % (self.etag, self.md5))
++            # If you use customer-provided encryption keys, the ETag value that Amazon S3 returns in the response will not be the MD5 of the object.
++            server_side_encryption_customer_algorithm = response.getheader('x-amz-server-side-encryption-customer-algorithm', None)
++            if server_side_encryption_customer_algorithm is None:
++                if self.etag != '""%s""' % md5:
++                    raise provider.storage_data_error(
++                        'ETag from S3 did not match computed MD5. '
++                        '%s vs. %s' % (self.etag, self.md5))
+ 
+             return True
+ ","Line length (PEP8, should be 80 chars max)","I don't think we need to check for `None` here. If the `x-amz-server-side-encryption-customer-algorithm` header is not present, we should raise an error."
+8469,"@@ -42,6 +42,8 @@ public abstract class MessageBuilder {
+     private final Context context;
+     private final MessageIdGenerator messageIdGenerator;
+     private final BoundaryGenerator boundaryGenerator;
++    private static final String highPriorityTag = ""X-Priority"";
++    private static final String xPriorityContent =""priority_high"";
+ 
+ 
+     private String subject;","this is duplicate now. I suggest moving it into `MimeHeader`, we already have a bunch of other headers there","private static final String xPriorityContent = ""priority_low"";"
+8470,"@@ -551,11 +551,15 @@ func checkPassword(password string) (string, error) {
+ 	if !utf8.ValidString(password) {
+ 		return """", errors.New(""password contains invalid utf8 characters"")
+ 	}
+-	// Remove leading+trailing whitespace
+-	password = strings.TrimSpace(password)
++	// Check for leading/trailing whitespace
++	trimmedPassword := strings.TrimSpace(password)
++	// Warn user if password has leading+trailing whitespace
++	if len(password) != len(trimmedPassword) {
++		fmt.Fprintln(os.Stderr, ""Your password contains leading/trailing whitespace - in previous versions of rclone this was stripped"")
++	}
+ 	// Normalize to reduce weird variations.
+ 	password = norm.NFKC.String(password)
+-	if len(password) == 0 {
++	if len(password) == 0 || len(trimmedPassword) == 0 {
+ 		return """", errors.New(""no characters in password"")
+ 	}
+ 	return password, nil","Can you expand the warning slightly ""Your password contains leading/trailing whitespace - in previous versions of rclone this was stripped"" Just so users know they might have to type their password without a leading space.",I think this should be `strings.TrimSpace(trimmedPassword)`
+8471,"@@ -596,7 +596,7 @@ namespace pwiz.Skyline
+                             var message = TextUtil.SpaceSeparate(
+                                 Resources.SkylineWindow_FindIrtDatabase_The_database_file_specified_could_not_be_opened,
+                                 e.Message);
+-                            MessageBox.Show(message);
++                            MessageDlg.Show(this, message);
+                         }
+                     }
+                     else","I think ""this"" should be ""parent"".",`this` is not used.
+8472,"@@ -331,6 +331,8 @@ ostree_async_progress_set (OstreeAsyncProgress *self,
+   if (self->dead)
+     goto out;
+ 
++  changed = FALSE;
++
+   va_start (ap, self);
+ 
+   for (key = va_arg (ap, const char *), format_string = va_arg (ap, const char *);",Why not init this at variable decl time instead?,`changed` is not used anywhere.
+8473,"@@ -25,6 +25,11 @@ const (
+ 	ProjectIDEnvKey = ""PROJECT_ID""
+ )
+ 
++// ProjectIDEnvConfig is a struct to parse Project id from env var
++type ProjectIDEnvConfig struct {
++	ProjectID string `envconfig:""PROJECT_ID""`
++}
++
+ // ProjectID returns the project ID for a particular resource.
+ func ProjectID(project string, client metadataClient.Client) (string, error) {
+ 	// If project is set, then return that one.",Do we still need this if we're doing everything through `envconfig`?,I don't think we need this.
+8474,"@@ -22,6 +22,8 @@ type OptionsNetwork struct {
+ 	Testnet  bool
+ 	Localnet bool
+ 
++	IdentityCheck bool
++
+ 	DiscoveryAPIAddress string
+ 	BrokerAddress       string
+ ",I would like these options to have `experiment` prefix or suffix. Because we will be deleting them later,Why do we need this?
+8475,"@@ -88,7 +88,11 @@
+       <%= f.label :additional_info, 'Please include any additional information you feel we need to correctly execute the purchase' %>
+       <%= f.text_area :additional_info, class: 'form-control' %>
+     </div>
+-    <%= f.submit class: 'form-button' %>
++    <% unless ENV['DISABLE_SANDBOX_WARNING'] == 'true' %>
++      <%= f.submit value: 'Submit test request for approval', class: 'form-button' %>
++    <% else %>
++      <%= f.submit class: 'form-button' %>
++    <% end %>
+     <% if @model_instance.persisted? %>
+       <%= link_to 'Discard Changes', proposal_url(@model_instance.proposal) %>
+     <% end %>","Since we have the same logic in both forms, can we make a shared partial/helper for it?",I don't think you need the `val
+8476,"@@ -69,10 +69,12 @@ func NewSalesman(opts ...Option) (*Salesman, error) {
+ 	if err := o.Validate(); err != nil {
+ 		return nil, err
+ 	}
++	marketAddr := blockchain.MarketAddr().Hex()
++	askPlansKey := marketAddr + ""/ask_plans""
+ 
+ 	s := &Salesman{
+ 		options:         o,
+-		askPlanStorage:  state.NewKeyedStorage(""ask_plans"", o.storage),
++		askPlanStorage:  state.NewKeyedStorage(askPlansKey, o.storage),
+ 		askPlanCGroups:  map[string]cgroups.CGroup{},
+ 		deals:           map[string]*sonm.Deal{},
+ 		orders:          map[string]*sonm.Order{},",Why to introduce this intermediate variable?,"I think this should be `marketAddr + ""/ask_plans""`"
+8477,"@@ -43,6 +43,9 @@ class webhdfs(luigi.Config):
+                               description='Port for webhdfs')
+     user = luigi.Parameter(default='', description='Defaults to $USER envvar',
+                            config_path=dict(section='hdfs', name='user'))
++    client_type = luigi.Parameter(default='insecure',
++                                  description='Type of client to use. One of insecure, kerberos or token')
++    token = luigi.Parameter(default='', description='Hadoop delegation token, only used when client_type=""token""')
+ 
+ 
+ class WebHdfsClient(hdfs_abstract_client.HdfsFileSystem):",Maybe use ChoiceParameter?,I don't think you need to specify the default here
+8478,"@@ -2,11 +2,12 @@ class ProposalsController < ApplicationController
+   include TokenAuth
+ 
+   before_filter :authenticate_user!, except: :approve
+-  before_filter ->{authorize self.proposal}, only: :show
++  before_filter ->{authorize self.proposal}, only: [:show, :cancel, :cancel_form]
+   before_filter :needs_token_on_get, only: :approve
+   before_filter :validate_access, only: :approve
+   helper_method :display_status
+   add_template_helper ProposalsHelper
++  rescue_from Pundit::NotAuthorizedError, with: :auth_errors
+ 
+   def show
+     @proposal = self.proposal.decorate","Not positive is this is needed, given the `TokenAuth` include",Why is this needed?
+8479,"@@ -50,3 +50,13 @@ class ErrorDescriptionDict(TypedDict):
+ CheckerStats = Dict[
+     str, Union[int, ""Counter[str]"", List, Dict[str, Union[int, str, Dict[str, int]]]]
+ ]
++
++
++# Tuple with information about the location of a to-be-displayed message
++class MessageLocationTuple(NamedTuple):
++    abspath: str
++    path: str
++    module: str
++    obj: str
++    line: int
++    column: int",Why not use a docstring for it?,I don't think this is used anywhere.
+8480,"@@ -3672,4 +3672,17 @@ public class BesuCommandTest extends CommandTestAbstract {
+     assertThat(commandErrorOutput.toString())
+         .contains(""Invalid value for option"", ""--Xws-timeout-seconds"", ""abc"", ""is not a long"");
+   }
++
++  @Test
++  public void assertThatDuplicatePortSpecifiedFails() {
++    parseCommand(""--p2p-port=9"", ""--rpc-http-port=10"", ""--rpc-ws-port=10"");
++    assertThat(commandErrorOutput.toString())
++        .contains(""Port number '10' has been specified multiple times."");
++  }
++
++  @Test
++  public void assertThatDuplicatePortZeroSucceeds() {
++    parseCommand(""--p2p-port=0"", ""--rpc-http-port=0"", ""--rpc-ws-port=0"");
++    assertThat(commandErrorOutput.toString()).isEmpty();
++  }
+ }","Two more tests - no ports specified and every possible port specified - p2pPort, graphQLHttpPort, rpcHttpPort, rpcWsPort, metricsPort, metricsPushPort, stratumPort","nit: use `assertThat(commandErrorOutput).contains(""Port number '10' has been specified multiple times."")`"
+8481,"@@ -9,6 +9,7 @@
+ # Copyright (c) 2019-2020 Pierre Sassoulas <pierre.sassoulas@gmail.com>
+ # Copyright (c) 2019 Ashley Whetter <ashley@awhetter.co.uk>
+ # Copyright (c) 2019 Taewon D. Kim <kimt33@mcmaster.ca>
++# Copyright (c) 2020 Eli Fine <ejfine@gmail.com>
+ 
+ # Licensed under the GPL: https://www.gnu.org/licenses/old-licenses/gpl-2.0.html
+ # For details: https://github.com/PyCQA/pylint/blob/master/COPYING","Don't worry about that next time, it's automated :)",This should be 2019-2020.
+8482,"@@ -172,6 +172,7 @@ def pytest_configure(config):
+     # pylint: disable=unused-variable
+     if config.webengine:
+         import PyQt5.QtWebEngineWidgets
++    # pylint: enable=unused-variable
+ 
+ 
+ @pytest.fixture(scope='session', autouse=True)","No need for this, as pylint already only turns things off for this function and it's needed for the entire function.",Why is this needed?
+8483,"@@ -103,10 +103,11 @@ const (
+ 	fluentTagDockerFirelensV2Format = ""%s.%s""
+ 
+ 	// Environment variables are needed for firelens
+-	fluentNetworkHost      = ""FLUENT_HOST""
+-	fluentNetworkPort      = ""FLUENT_PORT""
+-	FluentNetworkPortValue = ""24224""
+-	FluentAWSVPCHostValue  = ""127.0.0.1""
++	fluentNetworkHost        = ""FLUENT_HOST""
++	fluentNetworkPort        = ""FLUENT_PORT""
++	FluentNetworkPortValue   = ""24224""
++	AWSVPCHostValue          = ""127.0.0.1""
++	opentelemetryNetworkHost = ""OPEN_TELEMETRY_HOST""
+ 
+ 	defaultMonitorExecAgentsInterval = 15 * time.Minute
+ ",Are these values expected to change over time? Why not inject these values in ECS backend instead of agent doing it?,I don't think we need this anymore.
+8484,"@@ -31,6 +31,17 @@ func run(app *cli.Context, cfg *cmds.Server) error {
+ 		return err
+ 	}
+ 
++	nodeName := app.String(""node-name"")
++	if nodeName == """" {
++		h, err := os.Hostname()
++		if err != nil {
++			return err
++		}
++		nodeName = h
++	}
++
++	os.Setenv(""NODE_NAME"", nodeName)
++
+ 	var serverConfig server.Config
+ 	serverConfig.DisableAgent = true
+ 	serverConfig.ControlConfig.DataDir = dataDir","as best i can tell, you are setting this here in order to make it available in `(e *ETCD) Snapshot(ctx context.Context, config *config.Control) error`. It feels wrong to pass state like this through an env var. Could you instead add a `nodeName` property to the ETCD struct?",Why not just use `app.Hostname()`?
+8485,"@@ -38,6 +38,8 @@ var skipTests = map[string]string{
+ 	""covariance_missing_column_2"": ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""drop_before_rename"":          ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""drop_referenced"":             ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
++	""drop_non_existent"":           ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
++	""keep_non_existent"":           ""need to support known errors in new test framework (https://github.com/influxdata/flux/issues/536)"",
+ 	""yield"":                       ""yield requires special test case (https://github.com/influxdata/flux/issues/535)"",
+ }
+ ","These seem to support the new test framework below, but the `.in.csv` files are still committed.",I think this should be `drop_missi
+8486,"@@ -227,8 +227,11 @@ namespace Nethermind.Blockchain.Receipts
+             
+             for (int i = 0; i < txReceipts.Length; i++)
+             {
+-                var txHash = block.Transactions[i].Hash;
+-                _transactionDb.Set(txHash, block.Hash.Bytes);
++                if (txReceipts[i].Removed == false)
++                {
++                    var txHash = block.Transactions[i].Hash;
++                    _transactionDb.Set(txHash, block.Hash.Bytes);
++                }
+             }
+ 
+             if (blockNumber < MigratedBlockNumber)","!txReceipts[i].Removed and We can check it for first item outside of for loop, we don't expect mixed batches",Why is this needed?
+8487,"@@ -40,7 +40,7 @@ const (
+ 	prodEnvFlag           = ""prod""
+ 	deployFlag            = ""deploy""
+ 	resourcesFlag         = ""resources""
+-	githubURLFlag         = ""github-url""
++	repoURLFlag           = ""url""
+ 	githubAccessTokenFlag = ""github-access-token""
+ 	gitBranchFlag         = ""git-branch""
+ 	envsFlag              = ""environments""","We can't unfortunately change any of our old flags :( it'd be a breaking change. Instead, we can keep both `githubURLFlag` and `repoURLFlag` and make the description of `githubURLFlagDescription` as ""(Deprecated) Use --url instead. GitHub respository URL for your service."" It would be even better if we can make `githubURLFlag` as hidden but keep in the command. This way old commands will still work with `--github-url` but it won't appear anymore in the help menu.",Why did you change this?
+8488,"@@ -61,7 +61,10 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction
+ 
+       return result
+     end
++
+     # Could not find plan
+-    raise ArgumentError, ""Function #{self.class.name}(): Unknown plan: '#{plan_name}'""
++    raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
++      Puppet::Pops::Issues.issue(:UNKNOWN_PLAN) { Bolt::Error.unknown_plan(plan_name) }
++    )
+   end
+ end",This provides file and line number if applicable.,Should this be `Puppet::ParseErrorWithIssue`?
+8489,"@@ -10,6 +10,7 @@ import math
+ from matplotlib import pyplot as plt
+ import os
+ import pandas as pd
++import numpy as np
+ import random
+ import re
+ import shutil",This is already imported. Please check the file.,import numpy as np
+8490,"@@ -1676,6 +1676,11 @@ public class WindowWidget extends UIWidget implements SessionChangeListener,
+                 if (aSelection.isActionAvailable(action)) {
+                     aSelection.execute(action);
+                 }
++                if (GeckoSession.SelectionActionDelegate.ACTION_COPY.equals(action) &&
++                        aSelection.isActionAvailable(GeckoSession.SelectionActionDelegate.ACTION_UNSELECT)) {
++                    // Don't keep the text selected after it's copied.
++                    aSelection.execute(GeckoSession.SelectionActionDelegate.ACTION_UNSELECT);
++                }
+             }
+ 
+             @Override","One thing we can do in a follow up is use the shorthand calls, so You can just call `aSelection.unselect()` instead of calling the more verbose `execute()`. The fact that you have to check if the action is available sort of sucks though.",Why is this needed?
+8491,"@@ -519,10 +519,10 @@ func (st *ServerType) serversFromPairings(
+ 					for _, h := range hosts {
+ 						if h == defaultSNI {
+ 							hosts = append(hosts, """")
+-							cp.DefaultSNI = defaultSNI
+ 							break
+ 						}
+ 					}
++					cp.DefaultSNI = defaultSNI
+ 
+ 					// TODO: are matchers needed if every hostname of the resulting config is matched?
+ 					if len(hosts) > 0 {",I don't think adding this value to _every_ connection policy is needed or useful... why is this necessary?,Why is this needed?
+8492,"@@ -10,7 +10,11 @@ declare(strict_types=1);
+ namespace Ergonode\Product\Infrastructure\Provider\Strategy;
+ 
+ use Ergonode\Attribute\Domain\Entity\AbstractAttribute;
+-use Ergonode\Attribute\Infrastructure\Provider\AttributeValueConstraintStrategyInterface;
++use Ergonode\Attribute\Infrastructure\Provider\ContextAwareAttributeValueConstraintStrategyInterface;
++use Ergonode\EventSourcing\Infrastructure\Manager\EventStoreManagerInterface;
++use Ergonode\Product\Application\Validator\NotTheSameProduct;
++use Ergonode\Product\Domain\Entity\AbstractProduct;
++use Ergonode\SharedKernel\Domain\AggregateId;
+ use Symfony\Component\Validator\Constraint;
+ use Symfony\Component\Validator\Constraints\Collection;
+ use Ergonode\Product\Application\Validator\ProductExists;",adding this constrain for null AggreagateId is redundant,Why do we need this change?
+8493,"@@ -103,7 +103,12 @@ func Dashboard(ctx *middleware.Context) {
+ 	feeds := make([]*models.Action, 0, len(actions))
+ 	for _, act := range actions {
+ 		if act.IsPrivate {
+-			if has, _ := models.HasAccess(ctx.User, &models.Repository{Id: act.RepoId, IsPrivate: true}, models.ACCESS_MODE_READ); !has {
++			repo := &models.Repository{Id: act.RepoId, IsPrivate: true}
++			// This prevents having to retrieve the repository for each action
++			if act.RepoUserName == ctx.User.LowerName {
++				repo.OwnerId = ctx.User.Id
++			}
++			if has, _ := models.HasAccess(ctx.User, repo, models.ACCESS_MODE_READ); !has {
+ 				continue
+ 			}
+ 		}",Why when current user is owner but still check access? Should we use `else if` here?,Why is this needed?
+8494,"@@ -4,12 +4,18 @@ import (
+ 	""errors""
+ 	""fmt""
+ 	""strings""
++	""time""
+ 
+ 	docker ""github.com/fsouza/go-dockerclient""
+ 
+ 	. ""github.com/weaveworks/weave/common""
+ )
+ 
++const (
++	InitialInterval = 1 * time.Second
++	MaxInterval     = 60 * time.Second
++)
++
+ // An observer for container events
+ type ContainerObserver interface {
+ 	ContainerStarted(ident string)",60 seems high. 10? 20?,Why is this needed?
+8495,"@@ -755,8 +755,8 @@ def server_init_start(args):
+ 
+     # Create the main database link from the arguments passed over the
+     # command line.
+-    default_product_path = os.path.join(args.config_directory,
+-                                        'Default.sqlite')
++    cfg_dir = os.path.abspath(args.config_directory)
++    default_product_path = os.path.join(cfg_dir, 'Default.sqlite')
+     create_default_product = 'sqlite' in args and \
+                              not os.path.exists(default_product_path)
+ ",I think this is not the best way to handle this problem. This way every relative path will be converted to absolute path. What if the user would like to move his config directory to a different directory?,This should be `os.path.abs
+8496,"@@ -169,6 +169,10 @@ type NetworkSpec struct {
+ 	// Subnets configuration.
+ 	// +optional
+ 	Subnets Subnets `json:""subnets,omitempty""`
++
++	// ControlPlaneLoadBalancerScheme (defaults to Internet-facing)
++	// +optional
++	ControlPlaneLoadBalancerScheme ClassicELBScheme `json:""controlPlaneLoadBalancerScheme,omitempty""""`
+ }
+ 
+ // APIEndpoint represents a reachable Kubernetes API endpoint.",Let's make this a pointer given that's optional,Why do we need this?
+8497,"@@ -4,6 +4,7 @@
+  * Module dependencies.
+  */
+ 
++var CircularJSON = require('circular-json');
+ var Stream = require('stream').Stream;
+ var utils = require('./utils');
+ var helpers = require('./queryhelpers');",Why is CircularJSON imported here? It is never used in this file.,'use strict';
+8498,"@@ -80,7 +80,11 @@ namespace AutoRest.Swagger
+             {
+                 // Look for semantic errors and warnings in the document.
+                 var validator = new RecursiveObjectValidator(PropertyNameResolver.JsonName);
+-                foreach (var validationEx in validator.GetValidationExceptions(ServiceDefinition.FilePath, ServiceDefinition))
++                foreach (var validationEx in validator.GetValidationExceptions(ServiceDefinition.FilePath, ServiceDefinition, new ServiceDefinitionMetadata
++                {   // LEGACY MODE! set defaults for the metadata, the validator doesn't care from this codepath
++                    OpenApiDocumentType = ServiceDefinitionDocumentType.Default, 
++                    MergeState = ServiceDefinitionMergeState.After
++                }))
+                 {
+                     Logger.Instance.Log(validationEx);
+                 }",Should be ARM,Why do we need this?
+8499,"@@ -86,10 +86,10 @@ func openBucket(dir string, _ *Options) (driver.Bucket, error) {
+ 	dir = filepath.Clean(dir)
+ 	info, err := os.Stat(dir)
+ 	if err != nil {
+-		return nil, fmt.Errorf(""open file bucket: %v"", err)
++		return nil, err
+ 	}
+ 	if !info.IsDir() {
+-		return nil, fmt.Errorf(""open file bucket: %s is not a directory"", dir)
++		return nil, fmt.Errorf(""%s is not a directory"", dir)
+ 	}
+ 	return &bucket{dir}, nil
+ }","I don't see how removing ""open file bucket"" helps your purpose.",This should be `fmt.
+8500,"@@ -47,7 +47,7 @@ class SolrVersionStatus extends AbstractSolrStatus
+      *
+      * @var string
+      */
+-    const REQUIRED_SOLR_VERSION = '6.3.0';
++    const REQUIRED_SOLR_VERSION = '6.6.2';
+ 
+     /**
+      * Compiles a version check against each configured Solr server.",Solr dependency was downgraded?,This should be `6.6.1`.
+8501,"@@ -38,6 +38,7 @@ module C2
+     config.autoload_paths << Rails.root.join('app', 'mailers', 'concerns')
+     config.autoload_paths << Rails.root.join('app', 'policies', 'concerns')
+     config.autoload_paths << Rails.root.join('lib')
++    config.autoload_paths << Rails.root.join(""lib"", ""services"")
+ 
+     config.assets.precompile << 'communicarts_mailer.css'
+ ",or should we just autoload everything in `lib` ?,config.autoload_paths <
+8502,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+ 
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,I don't think we need t
+8503,"@@ -533,6 +533,7 @@ CREATE_VIOLATIONS_TABLE = """"""
+         `violation_type` enum('UNSPECIFIED',
+                               'ADDED','REMOVED',
+                               'BIGQUERY_VIOLATION',
++                              'BLACKLIST_VIOLATION',
+                               'BUCKET_VIOLATION',
+                               'CLOUD_SQL_VIOLATION',
+                               'FIREWALL_BLACKLIST_VIOLATION',",create_tables isn't used in 2.0 (should probably be deleted?),I think this should be 
+8504,"@@ -29,6 +29,7 @@ namespace OpenTelemetry.Exporter
+         internal Func<DateTimeOffset> GetUtcNowDateTimeOffset = () => DateTimeOffset.UtcNow;
+ 
+         private int scrapeResponseCacheDurationMilliseconds = 10 * 1000;
++        private IReadOnlyCollection<string> httpListenerPrefixes = new string[] { ""http://*:80/"" };
+ 
+ #if NETCOREAPP3_1_OR_GREATER
+         /// <summary>","Now I start to wonder, do we want to have `80` as the default or `9090` (or depending on whether we are exposing it via `PrometheusExporterMiddleware` vs. `PrometheusExporterHttpServer`)?",Why do we need this?
+8505,"@@ -980,7 +980,9 @@ TEST(Parser, UserOperation) {
+     {
+         GQLParser parser;
+         std::string query = ""CREATE USER IF NOT EXISTS user1 WITH PASSWORD \""aaa\"" , ""
+-                            ""FIRSTNAME \""a\"", LASTNAME \""a\"", EMAIL \""a\"", PHONE \""111\"""";
++                            ""ACCOUNT LOCK, MAX_QUERIES_PER_HOUR 1, ""
++                            ""MAX_UPDATES_PER_HOUR 2, MAX_CONNECTIONS_PER_HOUR 3, ""
++                            ""MAX_USER_CONNECTIONS 4"";
+         auto result = parser.parse(query);
+         ASSERT_TRUE(result.ok()) << result.status();
+         auto& sentence = result.value();",try an illegal case. and the result is syntax error.,Why did you change t
+8506,"@@ -23,6 +23,7 @@ void MemoryDataLayer<Dtype>::DataLayerSetUp(const vector<Blob<Dtype>*>& bottom,
+   added_label_.Reshape(batch_size_, 1, 1, 1);
+   data_ = NULL;
+   labels_ = NULL;
++  needs_reshape_ = false;
+   added_data_.cpu_data();
+   added_label_.cpu_data();
+ }",Initialize `needs_reshape_` with true and call `Reshape` method,Why is this needed?
+8507,"@@ -936,7 +936,10 @@ EOM
+       # @private
+       RANDOM_ORDERING = lambda do |list|
+         Kernel.srand RSpec.configuration.seed
+-        ordering = list.sort_by { Kernel.rand(list.size) }
++        orders = list.map {|x| !(x.respond_to?(:order)) || x.order.nil? || x.order == :random ? Kernel.rand(list.size) : 1}
++        zipped = list.zip(orders)
++
++        ordering = zipped.sort_by { |x| x[1] }.map { |x| x.first }
+         Kernel.srand # reset random generation
+         ordering
+       end","This is a _very_ complicated line. I'm not a fan of ternaries to begin with (although, I allow them in very simple situations), but this ternary has compound conditionals and would really need to be broken up. That said: if I'm reading this right, it sounds like this logic can make it where this lambda (which is called `RANDOM_ORDERING`) can make it not random and basically do the opposite of what it says. In general, it's good to avoid making methods or lambdas do the opposite of what they say.",Why do you need to c
+8508,"@@ -52,7 +52,8 @@ if (TYPO3_MODE == 'BE') {
+         '',
+         [
+             // An array holding the controller-action-combinations that are accessible
+-            'Administration' => 'index,setSite,setCore,noSiteAvailable'
++            'Administration' => 'index,setSite,setCore,noSiteAvailable',
++            'Backend\\Web\\Info\\ApacheSolrDocument' => 'index'
+         ],
+         [
+             'access' => 'admin',",We should remove this,I think this should be `Backend\\Web\\Info\\ApacheSolrDocument`
+8509,"@@ -205,6 +205,8 @@ type Config struct {
+ 	sourceToRawConfig map[Source]map[string]string
+ 	rawValues         map[string]string
+ 	Err               error
++
++	IptablesNATOutgoingInterfaceFilter string `config:""string;""`
+ }
+ 
+ type ProtoPort struct {","We should validate this, I think. To add a validator: - change `string` to, say `iface-pattern` - add a new `case ""iface-pattern""` to the `switch` in the `loadParams()` function: - in that `case`, you should be able to use a RegexpPattern like the one for `iface-list`. However, you'll need a different regexp. I think this regexp should work: `^[a-zA-Z0-9:._+-]{1,15}$` i.e. 1-15 characters consisting of alphanumerics, colon, dot, underscore, hyphen and plus.",IptablesNATOutgoingInterfaceFilter string
+8510,"@@ -59,6 +59,10 @@ func TestBalance(t *testing.T) {
+ 	require.Nil(err)
+ 	// Balance should == 30 now
+ 	require.Equal(0, state.Balance.Cmp(big.NewInt(30)))
++    
++    // Sub 40 to the balance
++    err = state.SubBalance(big.NewInt(40))
++    require.Equal(err, ErrNotEnoughBalance)
+ }
+ 
+ func TestClone(t *testing.T) {",File is not `goimports`-ed with -local github.com/iotexproject/iotex-core (from `goimports`),I think you can use `require.NoError` here.
+8511,"@@ -53,6 +53,11 @@ public class FlinkOrcWriter implements OrcRowWriter<RowData> {
+     writer.writeRow(row, output);
+   }
+ 
++  @Override
++  public List<OrcValueWriter<?>> writers() {
++    return this.writer.writers();
++  }
++
+   @Override
+   public Stream<FieldMetrics<?>> metrics() {
+     return writer.metrics();",Nit: Here we don't need the extra `this` in iceberg because we usually use the `this` to distinguish whether it is a member variable or local variable when assigning value.,Why do we need this method?
+8512,"@@ -71,7 +71,7 @@ public class AuthorizationLoggingTest {
+     engineRule.getManagementService().toggleTelemetry(true);
+ 
+     // then
+-    String message = ""ENGINE-03029 Required admin authenticated group or user."";
++    String message = ""ENGINE-16002 Exception while closing command context: ENGINE-03110 Required admin authenticated group or user or any of the following permissions:"";
+     List<ILoggingEvent> filteredLog = loggingRule.getFilteredLog(CONTEXT_LOGGER, message);
+ 
+     assertThat(filteredLog.size()).isEqualTo(1);","Why do we have that extra ""ENGINE-16002 Exception while closing command context:"" now? Is that done intentionally by us or where does that now come from?",I don't think we need to change this message.
+8513,"@@ -4,10 +4,15 @@ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ import org.slf4j.Marker;
+ 
++import java.util.Collections;
+ import java.util.Map.Entry;
++import java.util.Set;
+ import java.util.SortedMap;
+ import java.util.concurrent.ScheduledExecutorService;
+ import java.util.concurrent.TimeUnit;
++import java.util.function.Supplier;
++
++import static com.codahale.metrics.MetricAttribute.*;
+ 
+ /**
+  * A reporter class for logging metrics values to a SLF4J {@link Logger} periodically, similar to","Please don't use star imports, in the codebase we tend to use direct imports.",Please don't use wildcard imports.
+8514,"@@ -1,8 +1,10 @@
++import {CREDENTIALS} from ""../config.func"";
++
+ module.exports = function(server) {
+ 
+     test('who am I?', () => {
+       return server.whoami().then(function (username) {
+-        expect(username).toMatch('test');
++        expect(username).toMatch(CREDENTIALS.user);
+       });
+     });
+ ",Filename can be `config.functional`,Why did you change this?
+8515,"@@ -44,11 +44,19 @@ nano::block_processor::block_processor (nano::node & node_a, nano::write_databas
+ 			this->condition.notify_all ();
+ 		}
+ 	};
++	thread = std::thread ([this] () {
++		nano::thread_role::set (nano::thread_role::name::block_processing);
++		this->process_blocks ();
++	});
+ }
+ 
+ nano::block_processor::~block_processor ()
+ {
+ 	stop ();
++	if (thread.joinable ())
++	{
++		thread.join ();
++	}
+ }
+ 
+ void nano::block_processor::stop ()",Should the thread join be done in the stop function maybe? I am simply wondering and sharing my thoughts. This is my thinking: * The join used to be done in the stop function of node class and now it has moved in the destructor. * The class state_block_signature_verification joins its thread at the stop function too.,Shouldn't this be `if (thread.joinable ())`?
+8516,"@@ -22,3 +22,8 @@ var WalletCmd = &cobra.Command{
+ 		fmt.Println(""Print: "" + strings.Join(args, "" ""))
+ 	},
+ }
++
++func init() {
++	WalletCmd.AddCommand(walletCreateCmd)
++	WalletCmd.AddCommand(walletListCmd)
++}",don't use `init` function (from `gochecknoinits`),Why is this needed?
+8517,"@@ -3,7 +3,7 @@
+ 
+ # Purpose:
+ # sns-ruby-example-enable-resource.rb demonstrates how to enable an Amazon Simple Notification Services (SNS) resource using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+ 
+ # Inputs:
+ # - MY_TOPIC_ARN",Simple Notification **Service** (singular),I think this should
+8518,"@@ -15,6 +15,7 @@ DEFINE_int64(int64_test, 10, ""Test flag for int64 type"");
+ DEFINE_bool(bool_test, false, ""Test flag for bool type"");
+ DEFINE_double(double_test, 3.14159, ""Test flag for double type"");
+ DEFINE_string(string_test, ""Hello World"", ""Test flag for string type"");
++DEFINE_uint32(crash_test, 1024, ""The flag could not be read"");
+ 
+ namespace nebula {
+ ","You are fixing the crash problem, and you have fixed it, so it won't crash anymore. So `crash_test` is not a proper name.",DEFINE_uint32(crash
+8519,"@@ -68,8 +68,12 @@ public class SampleNamer extends NameFormatterDelegator {
+     return localVarName(Name.lowerCamel(""request""));
+   }
+ 
+-  /** Returns the variable name of the request body. */
+   public String getRequestBodyVarName() {
++    return getRequestBodyVarName("""");
++  }
++
++  /** Returns the variable name of the request body. */
++  public String getRequestBodyVarName(String requestBodyTypeName) {
+     return localVarName(Name.lowerCamel(""requestBody""));
+   }
+ ","If this default doesn't depend on the argument, shouldn't it be delegated as the default for the no-arg version instead?",Why is this needed?
+8520,"@@ -84,7 +84,7 @@ def read_api_key_safe():
+ 
+ 
+ def _get_config_file(path):
+-    get_or_create_file(path)
++    get_or_create_file(path, permissions=0o600)
+     return path
+ 
+ ","I did not use the new save_config_file method in here, because I am not sure whether this whole logic is still necessary? There is an TODO about it there as well.",Why is this necessary?
+8521,"@@ -22,7 +22,7 @@ define(['dom', 'appRouter', 'connectionManager'], function (dom, appRouter, conn
+                     return void appRouter.showItem(items[0]);
+                 }
+ 
+-                var url = 'itemdetails.html?id=' + itemId + '&serverId=' + serverId;
++                var url = 'details?id=' + itemId + '&serverId=' + serverId;
+                 Dashboard.navigate(url);
+             });
+             e.stopPropagation();",Why was this changed?,Shouldn't this be `det
+8522,"@@ -98,6 +98,8 @@ class IoUBalancedNegSampler(RandomSampler):
+                 floor_set = set()
+                 iou_sampling_set = set(
+                     np.where(max_overlaps > self.floor_thr)[0])
++                # for sampling interval calculation
++                self.floor_thr == 0
+ 
+             floor_neg_inds = list(floor_set & neg_set)
+             iou_sampling_neg_inds = list(iou_sampling_set & neg_set)","I think you meant, self.floor_thr = 0",Why is this needed?
+8523,"@@ -14,13 +14,12 @@ import (
+ 
+ 	""github.com/99designs/gqlgen/graphql""
+ 	""github.com/99designs/gqlgen/graphql/introspection""
++	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
++	""github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model""
+ 	gqlparser ""github.com/vektah/gqlparser/v2""
+ 	""github.com/vektah/gqlparser/v2/ast""
+-	v1 ""k8s.io/api/core/v1""
++	""k8s.io/api/core/v1""
+ 	v11 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+-
+-	""github.com/chaos-mesh/chaos-mesh/api/v1alpha1""
+-	""github.com/chaos-mesh/chaos-mesh/pkg/ctrlserver/graph/model""
+ )
+ 
+ // region    ************************** generated!.gotpl **************************",Can you revert these changes?,Why are these changes 
+8524,"@@ -18,10 +18,13 @@
+ 
+ 'use strict';
+ 
+-import React, {
++import React from 'react';
++
++import {
+     Component,
+     Navigator,
+-    StatusBarIOS,
++    Platform,
++    StatusBar,
+     Text,
+     TouchableOpacity,
+     View,",Do we need to change this?,Why did you change this?
+8525,"@@ -104,14 +104,12 @@ func setKernelMemory(path string, kernelMemoryLimit uint64) error {
+ }
+ 
+ func setMemoryAndSwap(path string, cgroup *configs.Cgroup) error {
+-	ulimited := -1
+-
+-	// If the memory update is set to uint64(-1) we should also
+-	// set swap to uint64(-1), it means unlimited memory.
+-	if cgroup.Resources.Memory == uint64(ulimited) {
++	// If the memory update is set to MemoryUnlimited we should also
++	// set swap to MemoryUnlimited.
++	if cgroup.Resources.Memory == configs.MemoryUnlimited {
+ 		// Only set swap if it's enbled in kernel
+ 		if cgroups.PathExists(filepath.Join(path, cgroupMemorySwapLimit)) {
+-			cgroup.Resources.MemorySwap = uint64(ulimited)
++			cgroup.Resources.MemorySwap = uint64(configs.MemoryUnlimited)
+ 		}
+ 	}
+ ","With this commit, `MemoryUnlimited` is defined as a `unit64`, so I think you can drop the redundant cast from this line (and the later lines which also have `uint64(configs.MemoryUnlimited)`.",I think this should be `
+8526,"@@ -7,6 +7,8 @@ function DashboardContentTitle (props) {
+ }
+ 
+ function PanelTopBar (props) {
++  const notOverFileLimit = props.maxNumberOfFiles !== props.totalFileCount
++
+   return (
+     <div class=""uppy-DashboardContent-bar"">
+       <button class=""uppy-DashboardContent-back""",`props.totalFileCount < props.maxNumberOfFiles` makes the intent a bit more clear I think. And a check to see if maxNumberOfFiles even exists?,Why do we need this vari
+8527,"@@ -12,7 +12,8 @@ import (
+ 
+ // Flags
+ var (
+-	epochNum uint64
++	epochNum  uint64
++	nextEpoch bool
+ )
+ 
+ // NodeCmd represents the node command",`epochNum` is a global variable (from `gochecknoglobals`),Why do we need this?
+8528,"@@ -1083,6 +1083,8 @@ angular.module('ui.grid')
+       } else {
+         // otherwise, manually search the oldRows to see if we can find this row
+         newRow = self.getRow(newEntity, oldRows);
++      } else {
++          newRow.entity = newEntity;
+       }
+ 
+       // if we didn't find the row, it must be new, so create it",This needs to be fixed before we can accept the PR,Why do we need this?
+8529,"@@ -14,6 +14,11 @@ constexpr double bootstrap_minimum_termination_time_sec = 30.0;
+ constexpr unsigned bootstrap_max_new_connections = 10;
+ constexpr unsigned bulk_push_cost_limit = 200;
+ 
++size_t constexpr nano::frontier_req::size;
++size_t constexpr nano::bulk_pull_blocks::size;
++size_t constexpr nano::bulk_pull_account::size;
++size_t constexpr nano::frontier_req_client::size_frontier;
++
+ nano::socket::socket (std::shared_ptr<nano::node> node_a) :
+ socket_m (node_a->io_ctx),
+ cutoff (std::numeric_limits<uint64_t>::max ()),",Are these forward declarations needed if we `#include <node/common.hpp>` which includes the definition ?,Why is this needed?
+8530,"@@ -76,7 +76,7 @@ func (m *Message) Bytes() []byte {
+ }
+ 
+ func (m *Message) String() string {
+-	return fmt.Sprintf(""MESSAGE: connectid %v MessageType %s"", m.ConnectID, m.MessageType)
++	return fmt.Sprintf(""MESSAGE: ConnectID %v MessageType %s"", m.ConnectID, m.MessageType)
+ }
+ 
+ func ReadMessageFromTunnel(r io.Reader) (*Message, error) {",can you use either `connectID` or `ConnectID` i would preffer `connectID`,I think this should 
+8531,"@@ -112,6 +112,11 @@ class Shopware6ChannelFormModel
+      */
+     public array $customField = [];
+ 
++    /**
++     * @var array|null
++     */
++    public ?array $crossSelling = [];
++
+     public function __construct(Shopware6Channel $channel = null)
+     {
+         if ($channel) {",It seems like it cannot be null?,Why do we need this?
+8532,"@@ -19,6 +19,7 @@ package azkaban.executor;
+ public class ExecutionReference {
+   private final int execId;
+   private Executor executor;
++  //Todo jamiesjc: deprecate updateTime in ExecutionReference class gradually.
+   private long updateTime;
+   private long nextCheckTime = -1;
+   private int numErrors = 0;",should we consider add deprecated annotation here?,Why do we need to deprecate updateTime?
+8533,"@@ -27,8 +27,8 @@ import (
+ 	""golang.org/x/net/context""
+ )
+ 
+-type createUserFn func(t testing.TB, ith int, config *libkbfs.ConfigLocal,
+-	opTimeout time.Duration) *fsUser
++type createUserFn func(t testing.TB, ith int, name libkb.NormalizedUsername,
++	config *libkbfs.ConfigLocal, opTimeout time.Duration) *fsUser
+ 
+ type fsEngine struct {
+ 	name       string",Why can't the implementor get the username from the config?,why not just pass in `name libkb.Normal
+8534,"@@ -87,7 +87,7 @@ func NewParams(raCtx protocol.RunActionsCtx, execution *action.Execution, stateD
+ 		BlockNumber: new(big.Int).SetUint64(raCtx.BlockHeight),
+ 		Time:        new(big.Int).SetInt64(raCtx.BlockTimeStamp),
+ 		Difficulty:  new(big.Int).SetUint64(uint64(50)),
+-		GasLimit:    raCtx.ActionGasLimit,
++		GasLimit:    execution.GasLimit(),
+ 		GasPrice:    execution.GasPrice(),
+ 	}
+ ",@CoderZhi Please confirm if this change makes sense,Why this change?
+8535,"@@ -127,6 +127,7 @@ public enum JsonRpcError {
+   PMT_FAILED_INTRINSIC_GAS_EXCEEDS_LIMIT(
+       -50100,
+       ""Private Marker Transaction failed due to intrinsic gas exeeding the limit. Gas limit used from the Private Transaction.""),
++  PRIVATE_SUBSCRIPTION_MULTI_TENANCY_ERROR(-50100, ""foo.""),
+ 
+   CANT_CONNECT_TO_LOCAL_PEER(-32100, ""Cannot add local node as peer.""),
+ ",Do you think you can come up with a better message? :-) It looks like this is not used anywhere. So maybe just delete the line.,PRIVATE_SUBSCRIPTION_MULTI_TENANCY_ERRO
+8536,"@@ -1065,11 +1065,7 @@ public interface Traversable<T> extends Foldable<T>, Value<T> {
+     @Override
+     default T reduceLeft(BiFunction<? super T, ? super T, ? extends T> op) {
+         Objects.requireNonNull(op, ""op is null"");
+-        if (isEmpty()) {
+-            throw new NoSuchElementException(""reduceLeft on Nil"");
+-        } else {
+-            return tail().foldLeft(head(), op);
+-        }
++        return iterator().reduceLeft(op);
+     }
+ 
+     /**",`tail()` is an expensive operation for certain collections,Why did you remove this check?
+8537,"@@ -86,7 +86,8 @@ var rubyMappings = {
+   'http_infrastructure':['../../../TestServer/swagger/httpInfrastructure.json','HttpInfrastructureModule'],
+   'required_optional':['../../../TestServer/swagger/required-optional.json','RequiredOptionalModule'],
+   'report':['../../../TestServer/swagger/report.json','ReportModule'],
+-  'model_flattening':['../../../TestServer/swagger/model-flattening.json', 'ModelFlatteningModule'],
++  'model_flattening':['../../../TestServer/swagger/model-flattening.json', 'ModelFlatteningModule'],  
++  'parameter_grouping':['../../../TestServer/swagger/azure-parameter-grouping.json', 'ParameterGroupingModule'],
+ };
+ 
+ var defaultAzureMappings = {",do we need to add this one in this PR?,Why do we need this?
+8538,"@@ -223,7 +223,6 @@ namespace Nethermind.State.Test.Runner
+ 
+         public void ReportGasUpdateForVmTrace(long refund, long gasAvailable)
+         {
+-            throw new NotImplementedException();
+         }
+ 
+         public void ReportRefundForVmTrace(long refund, long gasAvailable)",where is a test for it?,Why did you remove this?
+8539,"@@ -46,7 +46,7 @@ class Page extends CmsCompoundObject
+      */
+     public $rules = [
+         'title' => 'required',
+-        'url'   => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i']
++        'url' => ['required', 'regex:/^\/[a-z0-9\/\:_\-\*\[\]\+\?\|\.\^\\\$]*$/i']
+     ];
+ 
+     /**",Why has this spacing been adjusted?,Why did you change this?
+8540,"@@ -90,10 +90,15 @@ class PipelineBuilder(object):
+                 raise api_errors.ApiInitializationError(e)
+ 
+             api_version = self.api_map.get(api_name).get('version')
+-            if api_version is None:
+-                api = api_class()
+-            else:
+-                api = api_class(version=api_version)
++            try:
++                if api_version is None:
++                    api = api_class()
++                else:
++                    api = api_class(version=api_version)
++            except api_errors.ApiExecutionError as e:
++                LOGGER.error('Failed to execute API %s, v=%s',
++                             api_class_name, api_version)
++                raise api_errors.ApiInitializationError(e)
+ 
+             self.initialized_api_map[api_name] = api
+ ","Sorry to do this, since you're touching this file can you resolve the pylint doc messages above?",I don't think this is the right place to raise this error. It should be in the `finally` block.
+8541,"@@ -81,7 +81,7 @@ class BigQueryWriter(object):
+             }
+             bq_data.append({
+                 'json': row,
+-                'insertId': ""%s-%s"" % (listen['user_name'], listen['listened_at'])
++                'insertId': ""%s-%s-%s"" % (listen['user_name'], listen['listened_at'], listen['recording_msid'])
+             })
+ 
+         body = { 'rows' : bq_data }","@alastair, because the `insertId` for two listens with different metadata and same ts was the same, only one of them would get written into BQ. A question is what would be the ideal way to write tests for stuff like this, so that this doesn't break again?",E501 line too long (116 > 115 characters)
+8542,"@@ -1883,7 +1883,7 @@ UDS_RDBI.dataIdentifiers[0x4080] = ""AirbagLock_NEU""
+ UDS_RDBI.dataIdentifiers[0x4140] = ""BodyComConfig""
+ UDS_RDBI.dataIdentifiers[0x4ab4] = ""Betriebsstundenzaehler""
+ UDS_RDBI.dataIdentifiers[0x5fc2] = ""WDBI_DME_ABGLEICH_PROG_REQ""
+-UDS_RDBI.dataIdentifiers[0xd114] = ""Gesamtweg-Streckenzähler Offset""
++UDS_RDBI.dataIdentifiers[0xd114] = ""Gesamtweg-Streckenzaehler Offset""
+ UDS_RDBI.dataIdentifiers[0xd387] = ""STATUS_DIEBSTAHLSCHUTZ""
+ UDS_RDBI.dataIdentifiers[0xdb9c] = ""InitStatusEngineAngle""
+ UDS_RDBI.dataIdentifiers[0xEFE9] = ""WakeupRegistry""",Wondering where this breaks btw (although pretty understandable),Why did you change this?
+8543,"@@ -64,6 +64,7 @@ public class Spark3BinPackStrategy extends BinPackStrategy {
+       Dataset<Row> scanDF = cloneSession.read().format(""iceberg"")
+           .option(SparkReadOptions.FILE_SCAN_TASK_SET_ID, groupID)
+           .option(SparkReadOptions.SPLIT_SIZE, splitSize(inputFileSize(filesToRewrite)))
++          .option(SparkReadOptions.LOOKBACK, 10)
+           .option(SparkReadOptions.FILE_OPEN_COST, ""0"")
+           .load(table.name());
+ ",is this needed? 10 is already the default,Why do we need this?
+8544,"@@ -35,9 +35,13 @@ class TextPlot(ElementPlot):
+             data = dict(x=[element.x], y=[element.y])
+         self._categorize_data(data, ('x', 'y'), element.dimensions())
+         data['text'] = [element.text]
+-        style['text_align'] = element.halign
++        if 'text_align' not in style:
++            style['text_align'] = element.halign
+         baseline = 'middle' if element.valign == 'center' else element.valign
+-        style['text_baseline'] = baseline
++        if 'text_baseline' not in style:
++            style['text_baseline'] = baseline
++        if 'text_font_size' not in style:
++            style['text_font_size'] = '%dPt' % element.fontsize
+         if 'color' in style:
+             style['text_color'] = style.pop('color')
+         return (data, mapping, style)",One day we can try to allow the user to specify font sizes in something other than points. For now this is fine though...,"I don't think this is the right way to do this. If the element has no text_font_size, it should default to the font size of the element."
+8545,"@@ -29,7 +29,13 @@ namespace rtps {
+ 
+ 
+ WriterProxyData::WriterProxyData()
++#if HAVE_SECURITY
++    : security_attributes_(0)
++    , plugin_security_attributes_(0)
++    , m_userDefinedId(0)
++#else
+     : m_userDefinedId(0)
++#endif
+     , m_typeMaxSerialized(0)
+     , m_isAlive(true)
+     , m_topicKind(NO_KEY)",duplicated in both block of preprocessor condition. Can you join in one?,Why do we need this?
+8546,"@@ -50,9 +50,10 @@ function getXPathArray(node, path) {
+ 		var element = {};
+ 		element.str = node.nodeName.toLowerCase();
+ 		// add the id and the count so we can construct robust versions of the xpath
+-		if(node.getAttribute && node.getAttribute('id') &&
+-			node.ownerDocument.querySelectorAll('#' + axe.utils.escapeSelector(node.id)).length === 1) {
+-
++		if(
++			node.getAttribute && node.getAttribute('id') &&
++			node.ownerDocument.querySelectorAll('#' + axe.utils.escapeSelector(node.getAttribute('id'))).length === 1
++		) {
+ 			element.id = node.getAttribute('id');
+ 		}
+ 		if(count > 1) {",Can we put the first part of the expression inline with the `if(` for consistency's sake?,Why is this change needed?
+8547,"@@ -26,9 +26,15 @@ import ""github.com/yarpc/yarpc-go/transport""
+ type CallReqMeta interface {
+ 	Procedure(string) CallReqMeta
+ 	Headers(Headers) CallReqMeta
++	ShardKey(string) CallReqMeta
++	RoutingKey(string) CallReqMeta
++	RoutingDelegate(string) CallReqMeta
+ 
+ 	GetProcedure() string
+ 	GetHeaders() Headers
++	GetShardKey() string
++	GetRoutingKey() string
++	GetRoutingDelegate() string
+ }
+ 
+ // ReqMeta contains information about an incoming YARPC request.",Do servers have no need of accessing this information?,Why do we need these methods?
+8548,"@@ -51,7 +51,7 @@
+     // @vue/component
+     var commonFormattersMixin = {
+         methods: {
+-            formatTimeAgo: countlyCommon.formatTimeAgo,
++            formatTimeAgo: countlyCommon.formatTimeAgoText,
+             formatNumber: countlyCommon.formatNumber,
+             getShortNumber: countlyCommon.getShortNumber
+         }","It feels like this will break some stuff, but let it break. We need ""text"" version anyway.",Why do we need to change this?
+8549,"@@ -717,7 +717,7 @@ static ItemExpr *intersectColumns(const RETDesc &leftTable,
+     ItemExpr *leftExpr  = leftTable.getValueId(i).getItemExpr();
+     ItemExpr *rightExpr = rightTable.getValueId(i).getItemExpr();
+     BiRelat *compare = new (bindWA->wHeap())
+-      BiRelat(ITM_EQUAL, leftExpr, rightExpr);
++      BiRelat(ITM_EQUAL, leftExpr, rightExpr, TRUE);
+     if (predicate)
+       predicate = new (bindWA->wHeap()) BiLogic(ITM_AND, predicate, compare);
+     else","Here are two things I wonder: First, would it make sense to replace the TRUE here with ""leftExpr->getValueId().getType().supportsSQLnull() && rightExpr->getValueId().getType().supportsSQLnull()"". I'm not sure we have optimizations elsewhere that set the ""special nulls"" semantics back to FALSE if one of the operands it not nullable. Second, I wonder whether we have bugs elsewhere in the code that may not check for the ""special nulls"" semantics. For example, hash and merge joins probably can't use such predicates as equi-join predicates - one of the reasons for the optimization above. When I look at method ItemExpr::isAnEquiJoinPredicate() in core/sql/optimizer/OptItemExpr.cpp, I don't see a check for that. You have an example with a NULL value that is working, so hopefully this is not an issue, but I'm not sure how and why it works.",I don't think this is the righ
+8550,"@@ -267,7 +267,8 @@ T *LookupTableByName(const SymbolTable<T> &table, const std::string &name,
+   TD(StringConstant, 257, ""string constant"") \
+   TD(IntegerConstant, 258, ""integer constant"") \
+   TD(FloatConstant, 259, ""float constant"") \
+-  TD(Identifier, 260, ""identifier"")
++  TD(NumericConstant, 260, ""nan, inf or function name (signed)"") \
++  TD(Identifier, 261, ""identifier"")
+ #ifdef __GNUC__
+ __extension__  // Stop GCC complaining about trailing comma with -Wpendantic.
+ #endif",This will cause someone writing a schema field like `inf:string` to get a pretty confusing error? If they intended to use `inf` as short for `information` or whatever :) Might it be better to keep it as `Identifier` and explicitly recognize the few identifiers we care about only when parsing values (not while parsing field names)?,I'm not sure if this is the ri
+8551,"@@ -46,7 +46,7 @@ export function generateRandomHexString(length: number = 8) {
+ 
+ export function signPayload(payload: JWTPayload, secret: string, options: JWTSignOptions) {
+   return jwt.sign(payload, secret, {
+-    notBefore: '1000', // Make sure the time will not rollback :)
++    notBefore: '1', // Make sure the time will not rollback :)
+     ...options,
+   });
+ }",Mmm .... this affect #168 I'll need to research the collateral damage,why did you change this?
+8552,"@@ -268,7 +268,7 @@ func checkSrvRecord(dnsBootstrap string) {
+ 
+ func doDeleteDNS(network string, noPrompt bool, excludePattern string) bool {
+ 
+-	if network == """" || network == ""testnet"" || network == ""devnet"" || network == ""mainnet"" {
++	if network == """" || network == ""testnet"" || network == ""devnet"" || network == ""mainnet"" || network == ""beta"" {
+ 		fmt.Fprintf(os.Stderr, ""Deletion of network '%s' using this tool is not allowed\n"", network)
+ 		return false
+ 	}",nit: refactor into a const map lookup.,Why do we need this change?
+8553,"@@ -26,7 +26,7 @@ namespace MvvmCross.Forms.Droid.Views
+         {
+             BindingContext = new MvxAndroidBindingContext(this, this);
+             this.AddEventListeners();
+-            _resourceAssembly = Assembly.GetCallingAssembly();
++            _resourceAssembly = this.GetType().Assembly;
+         }
+ 
+         public object DataContext",I don't think this is going to work. We need to get the actual assembly of the app project. @johnnywebb thoughts?,Why is this change needed?
+8554,"@@ -306,7 +306,7 @@ def get_kbr_keys(kb_name, searchkey="""", searchvalue="""", searchtype='s'):
+                                              searchvalue, searchtype)
+ 
+ def get_kbr_values(kb_name, searchkey="""", searchvalue="""", searchtype='s',
+-                   use_memoise=False):
++                   use_memoize=False):
+     """"""
+     Return a tuple of values from key-value mapping kb.
+ ",@MSusik be careful about changing existing API. I think in this case you shouldn't rename the argument.,Why did you change this?
+8555,"@@ -176,8 +176,8 @@ int produce_message(struct flb_time *tm, msgpack_object *map,
+                 /* Add extracted topic on the fly to topiclist */
+                 if (ctx->dynamic_topic) {
+                     /* Only if default topic is set and this topicname is not set for this message */
+-                    if (strncmp(topic->name, flb_kafka_topic_default(ctx)->name, val.via.str.size) == 0 &&
+-                        (strncmp(topic->name, val.via.str.ptr, val.via.str.size) != 0) ) {
++                    if (strcmp(topic->name, flb_kafka_topic_default(ctx)->name) == 0 &&
++                        (strcmp(topic->name, val.via.str.ptr) != 0) ) {
+                         if (strstr(val.via.str.ptr, "","")) {
+                             /* Don't allow commas in kafkatopic name */
+                             flb_warn(""',' not allowed in dynamic_kafka topic names"");",This is bad. It is not a NULL-terminated string here.,Why did you remove the size
+8556,"@@ -48,9 +48,10 @@ class UserIpReader
+     protected $server;
+ 
+     /**
+-     * Should we respect the X-Forwarded-For header?
++     * Configuration specifying allowed HTTP headers containing IPs (false for none).
++     * See [Proxy] allow_forwarded_ips setting in config.ini for more details.
+      *
+-     * @var bool
++     * @var string|bool
+      */
+     protected $allowForwardedIps;
+ ",This probably should be @param string|false.,This should be `string|null`.
+8557,"@@ -195,7 +195,7 @@ public class SmartSqlTest extends SmartStoreTestCase {
+ 	 */
+ 	public void testSmartQueryReturningOneRowWithTwoIntegers() throws JSONException {
+ 		loadData();
+-		JSONArray result = store.query(QuerySpec.buildSmartQuerySpec(""select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr, {employees} as e where e.{employees:lastName} = 'Thompson'"", 1), 0);
++		JSONArray result = store.query(QuerySpec.buildSmartQuerySpec(""select mgr.{employees:salary}, e.{employees:salary} from {employees} as mgr, {employees} as e where e.{employees:lastName} = 'Thompson' and mgr.{employees:employeeId} = e.{employees:managerId}"", 1), 0);
+ 		assertSameJSONArray(""Wrong result"", new JSONArray(""[[200000,120000]]""), result);
+ 	}
+ 	",Unrelated test fix. Already in cordova34 branch.,Why is this change needed?
+8558,"@@ -87,10 +87,6 @@ func (sc *stakingCommand) CreatePostSystemActions(ctx context.Context, sr protoc
+ }
+ 
+ func (sc *stakingCommand) Handle(ctx context.Context, act action.Action, sm protocol.StateManager) (*action.Receipt, error) {
+-	// no height here,  v1 v2 has the same validate method, so directly use common one
+-	if err := validate(ctx, sm, sc, act); err != nil {
+-		return nil, err
+-	}
+ 	if sc.useV2(ctx, sm) {
+ 		return sc.stakingV2.Handle(ctx, act, sm)
+ 	}",validate() will be called by either V1 or V2,why remove this?
+8559,"@@ -100,6 +100,13 @@ class CppGenerator : public BaseGenerator {
+ 
+     assert(!cur_name_space_);
+ 
++    code_ += ""#if defined(_MSC_VER)"";
++    code_ += ""#define NOEXCEPT"";
++    code_ += ""#else"";
++    code_ += ""#define NOEXCEPT noexcept"";
++    code_ += ""#endif"";
++    code_ += """";
++
+     // Generate forward declarations for all structs/tables, since they may
+     // have circular references.
+     for (auto it = parser_.structs_.vec.begin();","rather than generate code for this every time, stick it in `flatbuffers.h` (and call it `FLATBUFFERS_NOEXCEPT` to avoid clashes).",Why is this needed?
+8560,"@@ -14,7 +14,9 @@ import (
+ // GetBlockByNumber see https://github.com/ethereum/wiki/wiki/JSON-RPC#eth_getblockbynumber
+ // see internal/ethapi.PublicBlockChainAPI.GetBlockByNumber
+ func (api *APIImpl) GetBlockByNumber(ctx context.Context, number rpc.BlockNumber, fullTx bool) (map[string]interface{}, error) {
+-	tx, err := api.dbReader.Begin(ctx)
++	// TODO the next line used to be ""tx, err := api.dbReader.Begin(ctx)"" When it changed, there was concern that it would have
++	// negative impact on performance. Revisit performance of using this type of database transaction
++	tx, err := api.db.Begin(ctx, nil, false)
+ 	if err != nil {
+ 		return nil, err
+ 	}","@AskAlexSharov @tjayrush , I'm still feeling uncomfortable with this change: - because it works by accident. For example in next lines `tx` object used as: `ReadBlockByNumber(tx)`. If you go inside `ReadBlockByNumber` you can find `!errors.Is(err, ethdb.ErrKeyNotFound)` - but ethdb.Tx doesn't return this error - and it satisfy `DatabaseReader` by accident - (I faced this problem last week - when passed Tx to place which expected Db - and I promised to change tx API - rename Get to GetOne or even remove the method). - we can merge this PR if it doesn't break things and solve problem of localDb use of RPCDaemon. But I will make PR now which will allow open Read tx by TxDb/ObjectDb - and will ask you to use it. Then will take a look how hard to change LmdbTx to not satisfy rawdb.DatabaseReader interface.","I'm not sure if this is the best way to do this. I think it would be better to use `api.dbReader.Begin(ctx, nil, fullTx)` instead."
+8561,"@@ -159,3 +159,4 @@ def createTemporalAnomaly(recordParams, spatialParams=_SP_PARAMS,
+   temporalPoolerRegion.setParameter(""anomalyMode"", True)
+ 
+   return network
++  ",I think this means the file doesn't have a newline character at the end.,
+8562,"@@ -469,6 +469,15 @@ fpga_result fpgaPerfCounterGet(fpga_token token, fpga_perf_counter *fpga_perf)
+ 
+ 	memset(fpga_perf, 0, sizeof(fpga_perf_counter));
+ 
++	//check if its being run as root or not
++	uid_t uid = getuid();
++	if (uid != 0) {
++		fpga_perf->previlege = false;
++		return FPGA_OK;
++	} else {
++		fpga_perf->previlege = true;
++	}
++
+ 	ret = get_fpga_sbdf(token, &segment, &bus, &device, &function);
+ 	if (ret != FPGA_OK) {
+ 		OPAE_ERR(""Failed to get sbdf"");","Hi Ramya, rather than checking here in the perf counter library, we should add the privilege check in the host_exerciser app.",Why is this needed?
+8563,"@@ -20,7 +20,9 @@ class TrackedObject:
+ 	""""""
+ 
+ 	def __del__(self):
+-		notifyObjectDeletion(self)
++		# notifyObjectDeletion could be None if Python is shutting down.
++		if notifyObjectDeletion:
++			notifyObjectDeletion(self)
+ 
+ 
+ _collectionThreadID = 0",Could you elaborate on this some more? Has this behavior changed with Python 3.8?,Why is this necessary?
+8564,"@@ -89,7 +89,10 @@ const logReqMsg = `DEBUG: Request %s/%s Details:
+ 
+ func logRequest(r *request.Request) {
+ 	logBody := r.Config.LogLevel.Matches(aws.LogDebugWithHTTPBody)
+-	dumpedBody, _ := httputil.DumpRequestOut(r.HTTPRequest, logBody)
++	dumpedBody, err := httputil.DumpRequestOut(r.HTTPRequest, logBody)
++	if err != nil {
++		r.Config.Logger.Log(fmt.Sprintf(""Error dumping request: %s"", err))
++	}
+ 
+ 	if logBody {
+ 		// Reset the request body because dumpRequest will re-wrap the r.HTTPRequest's","Do we want to continue on logging the `dumpedBody`, if an error was thrown? It is probably an empty string. This would make the log after this one pretty much useless.",I think this should be `r.Config.Logger.Error` instead of `fmt.Sprintf`
+8565,"@@ -1,6 +1,7 @@
+ <fieldset class=""annotation_fields"" id=""<%= unique_dom_id(f.object, ""fields"") %>"">
+   <div class=""form-group col-md-10"">
+-    <%= f.label(:type, f.object.type.humanize, class: ""control-label"") %>
++    <% lbl = f.object.type.humanize.downcase == 'example answer' ? _('Example answer') : _('Guidance') %>
++    <%= f.label(:type, lbl, class: ""control-label"") %>
+     <div data-toggle=""tooltip"" title=""<%= tooltip_for_annotation_text(f.object) %>"">
+       <em class=""sr-only""><%= tooltip_for_annotation_text(f.object) %></em>
+       <%= f.text_area(:text, class: 'question',",the text here is derived from the object type and not getting properly handled by get text,I think it would be better to use `f.object.type.humanize.downcase == '
+8566,"@@ -27,10 +27,13 @@ const (
+ var (
+ 	// runtimeMode tells which mode antctl is running against.
+ 	runtimeMode string
++	inPod       bool
+ )
+ 
+ func init() {
+-	if strings.HasPrefix(os.Getenv(""POD_NAME""), ""antrea-agent"") {
++	podName, found := os.LookupEnv(""POD_NAME"")
++	inPod = found && (strings.HasPrefix(podName, ""antrea-agent"") || strings.HasPrefix(podName, ""antrea-controller""))
++	if strings.HasPrefix(podName, ""antrea-agent"") {
+ 		runtimeMode = ModeAgent
+ 	} else {
+ 		runtimeMode = ModeController",This will make other pods that run antctl will also connect its localhost? Maybe only do it when it's in antrea-agent and antrea-controller,"nit: `inPod := found && strings.HasPrefix(podName, ""antrea-agent"")`"
+8567,"@@ -168,9 +168,6 @@ define([""jQuery"", ""globalize"", ""scripts/taskbutton"", ""dom"", ""libraryMenu"", ""layo
+         }), menuItems.push({
+             name: ""Xml TV"",
+             id: ""xmltv""
+-        }), menuItems.push({
+-            name: globalize.translate(""ButtonOther""),
+-            id: ""other""
+         }), require([""actionsheet""], function(actionsheet) {
+             actionsheet.show({
+                 items: menuItems,","The corresponding action for this key needs to be removed as well, along with any unused translations.",Why was this removed?
+8568,"@@ -48,15 +48,15 @@ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AWS.SQS
+ 
+             var requestProxy = request.DuckCast<ISendMessageBatchRequest>();
+ 
+-            var scope = AwsSqsCommon.CreateScope(Tracer.Instance, Operation, out AwsSqsTags tags);
++            var scope = AwsSqsCommon.CreateScope(Tracer.InternalInstance, Operation, out AwsSqsTags tags);
+             tags.QueueUrl = requestProxy.QueueUrl;
+ 
+-            if (scope?.Span?.Context != null && requestProxy.Entries.Count > 0)
++            if (scope?.Span.Context is SpanContext spanContext && requestProxy.Entries.Count > 0)
+             {
+                 for (int i = 0; i < requestProxy.Entries.Count; i++)
+                 {
+                     var entry = requestProxy.Entries[i].DuckCast<IContainsMessageAttributes>();
+-                    ContextPropagation.InjectHeadersIntoMessage<TSendMessageBatchRequest>(entry, scope?.Span?.Context);
++                    ContextPropagation.InjectHeadersIntoMessage<TSendMessageBatchRequest>(entry, spanContext);
+                 }
+             }
+ ","Can't Span cannot be null anymore? I assume it was a useless check as there are discrepencies within integrations, but as you explicitly removed this one, I was wondering",Why is this change needed?
+8569,"@@ -210,7 +210,7 @@ namespace Nethermind.JsonRpc.Modules.Trace
+ 
+             Block block = blockSearch.Object;
+ 
+-            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace | ParityTraceTypes.Rewards);
++            ParityLikeTxTrace txTrace = TraceTx(block, txHash, ParityTraceTypes.Trace);
+             return ResultWrapper<ParityTxTraceFromStore[]>.Success(ParityTxTraceFromStore.FromTxTrace(txTrace));
+         }
+ ","hmmm, ok, this is interesting -> Lukasz definitely uses rewards traces",Why is this change needed?
+8570,"@@ -78,6 +78,9 @@ public class TableProperties {
+   public static final String SPLIT_OPEN_FILE_COST = ""read.split.open-file-cost"";
+   public static final long SPLIT_OPEN_FILE_COST_DEFAULT = 4 * 1024 * 1024; // 4MB
+ 
++  public static final String SPLIT_BY_PARTITION = ""read.split.by-partition"";
++  public static final boolean SPLIT_BY_PARTITION_DEFAULT = false;
++
+   public static final String PARQUET_VECTORIZATION_ENABLED = ""read.parquet.vectorization.enabled"";
+   public static final boolean PARQUET_VECTORIZATION_ENABLED_DEFAULT = false;
+ ",Why do we need this flag? can this be detected if the table is bucketed/partitioned and enabled/disabled automatically? Is this for backwards compatibility?,I think this should be `re
+8571,"@@ -188,7 +188,7 @@ bool is_name_type(const char* name)
+ {
+   if(*name == '$')
+     name++;
+-    
++
+   if(*name == '_')
+     name++;
+ ",can you revert changes to this file.,if (*name == '$')
+8572,"@@ -2,6 +2,8 @@
+ // Use of this source code is governed by a BSD-style
+ // license that can be found in the LICENSE file.
+ 
++// Package soc provides the single-owner chunk implemenation
++// and validator.
+ package soc
+ 
+ import (",suggestion to add: An soc is a chunks whose address is derived of (...),// Package soc provides the single-owner chunk implemenation
+8573,"@@ -110,6 +110,8 @@ export const API_ERROR = {
+   DEPRECATED_BASIC_HEADER: 'basic authentication is deprecated, please use JWT instead',
+   BAD_FORMAT_USER_GROUP: 'user groups is different than an array',
+   RESOURCE_UNAVAILABLE: 'resource unavailable',
++  USERNAME_PASSWORD_REQUIRED: 'username and password is required',
++  USERNAME_ALREADY_REGISTERED: 'username is already registered',
+ };
+ 
+ export const APP_ERROR = {","It doesn't make sense. if we are going to have the profile page where the user can change the password and he / she is already logged in ... I do not need to register a new username. only: new password..confirm new password..something similar...and ""USERNAME_ALREADY_REGISTERED"" only if I have a register page..are we going to have? We need to talk about it.",I think this should be `USERNAME_PASSWORD_REQUIRED_AND_REGIS
+8574,"@@ -747,14 +747,14 @@ namespace Nethermind.State
+             _needsStateRootUpdate = false;
+         }
+ 
+-        public void CommitTree()
++        public void CommitTree(long blockNumber)
+         {
+             if (_needsStateRootUpdate)
+             {
+                 RecalculateStateRoot();
+             }
+ 
+-            _tree.Commit();
++            _tree.Commit(blockNumber);
+         }
+     }
+ }",not a great fan of this change - maybe worth splitting into CommitTree() and CloseBlock(long blockNumber)?,Why do we need this change?
+8575,"@@ -65,7 +65,9 @@ namespace Microsoft.AspNetCore.Connections
+ 
+         public CancellationToken ConnectionClosed { get; set; }
+ 
+-        public virtual void Abort()
++        public void Abort() => Abort(abortReason: null);
++
++        public virtual void Abort(ConnectionAbortedException abortReason)
+         {
+             ThreadPool.QueueUserWorkItem(cts => ((CancellationTokenSource)cts).Cancel(), _connectionClosedTokenSource);
+         }","Ugh, if we're going to make a breaking change, I'd like this to be moved to ConnectionContext.",Why do we need this?
+8576,"@@ -1286,6 +1286,12 @@ func NewFs(path string) (Fs, error) {
+ 	if err != nil {
+ 		return nil, err
+ 	}
++	// TODO: Fix import for rc
++	// f, err := fsInfo.NewFs(configName, fsPath, config)
++	// if err != nil && f.reload != nil {
++	// 	rc.AddOptionReload(f.name, &f.opt, f.reload)
++	// }
++	// return f, err
+ 	return fsInfo.NewFs(configName, fsPath, config)
+ }
+ ","I was planning to add it as a common option, but there is a cyclic import for the rc & fs libs. Thoughts on avoiding it or should I remove this for now?",Why do we need this?
+8577,"@@ -65,6 +65,10 @@ namespace SynchronizeVersions
+                 ""src/Datadog.Trace/Datadog.Trace.csproj"",
+                 NugetVersionReplace);
+ 
++            SynchronizeVersion(
++                ""/deploy/Nuget/Datadog.Trace.nuspec"",
++                NugetVersionReplace);
++
+             Console.WriteLine($""Completed synchronizing versions to {VersionString()}"");
+         }
+ ","I think this entry can be removed now, right?",Why do we need this?
+8578,"@@ -230,6 +230,18 @@ class Key(object):
+         else:
+             self.encrypted = None
+ 
++    def handle_storage_class_header(self, resp):
++        provider = self.bucket.connection.provider
++        if provider.storage_class_header:
++            self._storage_class = resp.getheader(
++                provider.storage_class_header, None)
++            if (self._storage_class is None and
++                provider.get_provider_name() == 'aws'):
++                # S3 docs for HEAD object requests say S3 will return this
++                # header for all objects except Standard storage class objects.
++                self._storage_class = 'STANDARD'
++
++
+     def handle_version_headers(self, resp, force=False):
+         provider = self.bucket.connection.provider
+         # If the Key object already has a version_id attribute value, it","I don't understand why you want to populate the storage class in this case, if the S3 docs say they won't populate the header in this case?",I don't think we nee
+8579,"@@ -47,6 +47,10 @@ public interface CapabilityType {
+   String HAS_TOUCHSCREEN = ""hasTouchScreen"";
+   String OVERLAPPING_CHECK_DISABLED = ""overlappingCheckDisabled"";
+   String STRICT_FILE_INTERACTABILITY = ""strictFileInteractability"";
++  String TIMEOUTS = ""timeouts"";
++  String IMPLICIT_TIMEOUT = ""implicit"";
++  String PAGE_LOAD_TIMEOUT = ""pageLoad"";
++  String SCRIPT_TIMEOUT = ""script"";
+ 
+   String LOGGING_PREFS = ""loggingPrefs"";
+ ","These are really meant to be the keys in the capabilities, not the keys of values within the capabilities",I don't think this i
+8580,"@@ -14,8 +14,11 @@ import (
+ //
+ // The request will not be signed, and will not use your AWS credentials.
+ //
+-// A ""NotFound"" error code will be returned if the bucket does not exist in
+-// the AWS partition the regionHint belongs to.
++// A ""NotFound"" error code will be returned if the bucket does not exist in the
++// AWS partition the regionHint belongs to. If the regionHint parameter is an
++// empty string GetBucketRegion will fallback to the ConfigProvider's region
++// config. If no region is specified, hint or ConfigProvider, an error will
++// be returned.
+ //
+ // For example to get the region of a bucket which exists in ""eu-central-1""
+ // you could provide a region hint of ""us-west-2"".",Should the last sentence be `If no region was found` rather than `specified`?,"I'm not sure if this is the right way to do it. If the regionHint is empty string, the ConfigProvider will fallback to the default region."
+8581,"@@ -217,9 +217,16 @@ public class CoxPlugin extends Plugin
+ 			{
+ 				for (Player player : client.getPlayers())
+ 				{
+-					if (player.getName().equals(tpMatcher.group(1)))
++					final String rawPlayerName = player.getName();
++
++					if (rawPlayerName != null)
+ 					{
+-						victims.add(new Victim(player, Victim.Type.TELEPORT));
++						final String fixedPlayerName = Text.sanitize(rawPlayerName);
++
++						if (fixedPlayerName.equals(tpMatcher.group(1)))
++						{
++							victims.add(new Victim(player, Victim.Type.TELEPORT));
++						}
+ 					}
+ 				}
+ 			}","Text.sanitize just removes images from names, for instance, the hardcore ironman symbol when someone talks. A better option would be text.standardize, or text.toJagexName",You can use `Text.isNullOrEmpty`
+8582,"@@ -81,3 +81,13 @@ func (a *Application) IsOutOfSync() bool {
+ func IsApplicationConfigFile(filename string) bool {
+ 	return filename == DefaultApplicationConfigFilename || strings.HasSuffix(filename, applicationConfigFileExtention)
+ }
++
++func ToApplicationKind(kind string) (ApplicationKind, bool) {
++	upper := strings.ToUpper(string(kind))
++	k := strings.TrimSuffix(upper, ""APP"")
++	appKind, ok := ApplicationKind_value[k]
++	if !ok {
++		return -1, false
++	}
++	return ApplicationKind(appKind), true
++}",How about `ApplicationKindFromConfigKind`? And I think this function should be better in the config package. The reason is `config` package can import and refer things from the model package but not vice versa.,Why not just `ToApplicationKind`?
+8583,"@@ -101,9 +101,14 @@ const (
+ // Options sets options for constructing a *blob.Bucket backed by Azure Block Blob.
+ type Options struct {
+ 	// Credential represents the authorizer for SignedURL.
+-	// Required to use SignedURL.
++	// Required to use SignedURL. If you're using MSI for authentication, this will
++	// attempt to be loaded lazily the first time you call SignedURL
+ 	Credential azblob.StorageAccountCredential
+ 
++	// CredentialExpiration is when the current MSI-obtained signing credential
++	// expires so that we can refresh it on demand
++	CredentialExpiration time.Time
++
+ 	// SASToken can be provided along with anonymous credentials to use
+ 	// delegated privileges.
+ 	// See https://docs.microsoft.com/en-us/azure/storage/common/storage-dotnet-shared-access-signature-part-1#shared-access-signature-parameters.","Nit: missing closing ""."".",I'm not sure if this is the right place to put this. I think it would be better to put it in the `SignedURL` struct.
+8584,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked",I think you can use `wait_for_element_to_be_unclickable` here.
+8585,"@@ -123,9 +123,9 @@ func CreatePipeline(pipelineName string, provider Provider, stageNames []string)
+ 	}, nil
+ }
+ 
+-// Marshal serializes the pipeline manifest object into byte array that
++// MarshalBinary serializes the pipeline manifest object into byte array that
+ // represents the pipeline.yml document.
+-func (m *PipelineManifest) Marshal() ([]byte, error) {
++func (m *PipelineManifest) MarshalBinary() ([]byte, error) {
+ 	box := templates.Box()
+ 	content, err := box.FindString(""cicd/pipeline.yml"")
+ 	if err != nil {",Same here. Should this be pipeline YAML file? Like `MarshalPipelineManifest`,Why do we need this change?
+8586,"@@ -213,6 +213,9 @@ func (i *Instance) Restart(newCaddyfile Input) (*Instance, error) {
+ 	}
+ 	i.Stop()
+ 
++	// Execute instantiation events
++	EmitEvent(InstanceStartupEvent, newInst)
++
+ 	log.Println(""[INFO] Reloading complete"")
+ 
+ 	return newInst, nil",I will add this to my PR  ,Why do we need this?
+8587,"@@ -19,4 +19,8 @@ class RolePolicy < ApplicationPolicy
+   def destroy?
+     @role.plan.owned_by?(@user.id)
+   end
++
++  def archive?
++    @role.user_id = @user.id
++  end
+ end",Again not 100% sold on the name,Why do we need this?
+8588,"@@ -226,8 +226,9 @@ func runWeb(ctx *cli.Context) error {
+ 	m.Group(""/user/settings"", func() {
+ 		m.Get("""", user.Settings)
+ 		m.Post("""", bindIgnErr(auth.UpdateProfileForm{}), user.SettingsPost)
+-		m.Post(""/avatar"", binding.MultipartForm(auth.UploadAvatarForm{}), user.SettingsAvatar)
++		m.Post(""/avatar"", binding.MultipartForm(auth.AvatarForm{}), user.SettingsAvatarPost)
+ 		m.Post(""/avatar/delete"", user.SettingsDeleteAvatar)
++		m.Get(""/avatar"", user.SettingsAvatar)
+ 		m.Combo(""/email"").Get(user.SettingsEmails).
+ 			Post(bindIgnErr(auth.AddEmailForm{}), user.SettingsEmailPost)
+ 		m.Post(""/email/delete"", user.DeleteEmail)",Use `m.Combo` for `Get` and `Post` methods.,"I think this should be `m.Get(""/avatar"", user.SettingsAvatar)`."
+8589,"@@ -446,6 +446,13 @@ class DownloadItem(QObject):
+             # The file already exists, so ask the user if it should be
+             # overwritten.
+             self._ask_overwrite_question()
++        # FIFO, device node, etc. Don't even try.
++        elif (os.path.exists(self._filename) and not
++                os.path.isdir(self._filename)):
++            self.cancel(False)
++            message.error(self._win_id, ""The file {} already exists, and is a ""
++                                        ""special file. Aborting."".format(
++                                         self._filename))
+         else:
+             self._create_fileobj()
+ ","Is there a reason you're not using `self._die(""The file {} ..."")` here?",I don't think you need the `and not os.path.isdir` here.
+8590,"@@ -13,7 +13,7 @@ import (
+ 
+ // LocalDevExecCmd allows users to execute arbitrary bash commands within a container.
+ var LocalDevExecCmd = &cobra.Command{
+-	Use:   ""exec [app_name] [environment_name] '[cmd]'"",
++	Use:   ""exec '[cmd]'"",
+ 	Short: ""run a command in an app container."",
+ 	Long:  `Execs into container and runs bash commands.`,
+ 	Run: func(cmd *cobra.Command, args []string) {","I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But ""Run a command in an app container"" doesn't do it for me :)",I think this should be `[app_name] [environment]`
+8591,"@@ -8,6 +8,10 @@ import (
+ 	. ""github.com/weaveworks/weave/common""
+ )
+ 
++var (
++	weaveWaitEntrypoint = []string{""/home/weavewait/weavewait""}
++)
++
+ func callWeave(args ...string) ([]byte, error) {
+ 	args = append([]string{""--local""}, args...)
+ 	Debug.Print(""Calling weave"", args)",shouldn't this be a const?,I think this should be `/home/weavewait`
+8592,"@@ -135,10 +135,7 @@ class MongoDBMochaReporter extends mocha.reporters.Spec {
+         timestamp = timestamp ? timestamp.toISOString().split('.')[0] : '';
+ 
+         output.testSuites.push({
+-          package:
+-            suite.file.includes('functional') || suite.file.includes('integration')
+-              ? 'Functional'
+-              : 'Unit',
++          package: suite.file.includes('integration') ? 'Functional' : 'Unit',
+           id,
+           name: className,
+           timestamp,","This is a bit of a throwaway field in the xunit output, it doesn't impact anything on EVG, should we just name it `integration` now?",Why was this removed?
+8593,"@@ -29,6 +29,6 @@ import java.lang.annotation.Target;
+ @Documented
+ @Retention(SOURCE)
+ @Target(TYPE)
+-public @interface SolrSingleThreaded {
++public @interface SolrThreadUnsafe {
+ 
+ }",Please change the name of the file too.,Why is this change ne
+8594,"@@ -286,7 +286,7 @@ func inject(args []string) string {
+ 
+ func init() {
+ 	flag := injectCmd.Flags()
+-	flag.StringVar(&injectCfg.configPath, ""injector-config-path"", ""./tools/actioninjector/gentsfaddrs.yaml"", ""path of config file of genesis transfer addresses"")
++	flag.StringVar(&injectCfg.configPath, ""injector-config-path"", ""./tools/actioninjector.v2/gentsfaddrs.yaml"", ""path of config file of genesis transfer addresses"")
+ 	flag.StringVar(&injectCfg.serverAddr, ""addr"", ""127.0.0.1:14004"", ""target ip:port for grpc connection"")
+ 	flag.Uint64Var(&injectCfg.transferGasLimit, ""transfer-gas-limit"", 20000, ""transfer gas limit"")
+ 	flag.Int64Var(&injectCfg.rawTransferGasPrice, ""transfer-gas-price"", 10, ""transfer gas price"")",line is 161 characters (from `lll`),Why do we need to cha
+8595,"@@ -195,8 +195,10 @@ module Bolt
+       @outputter.stop_spin
+ 
+       # Automatically generate types after installing modules
+-      @outputter.print_action_step(""Generating type references"")
+-      @pal.generate_types(cache: true)
++      if ok
++        @outputter.print_action_step(""Generating type references"")
++        @pal.generate_types(cache: true)
++      end
+ 
+       @outputter.print_puppetfile_result(ok, path, moduledir)
+ ",When is this false?,I don't think this is
+8596,"@@ -540,7 +540,6 @@ Dispose()
+         [InlineData(""${counter}"", DbType.Int16, (short)1)]
+         [InlineData(""${counter}"", DbType.Int32, 1)]
+         [InlineData(""${counter}"", DbType.Int64, (long)1)]
+-        [InlineData(""${counter}"", DbType.Int16, (short)1)]
+         [InlineData(""${counter:norawvalue=true}"", DbType.Int16, (short)1)] //fallback
+         [InlineData(""${counter}"", DbType.VarNumeric, 1, true)]
+         [InlineData(""${counter}"", DbType.AnsiString, ""1"")]",note: also here ;),Why was this removed?
+8597,"@@ -145,6 +145,10 @@ public class TemporaryFilesystem {
+   }
+ 
+   public boolean deleteBaseDir() {
+-    return baseDir.delete();
++    boolean wasDeleted = baseDir.delete();
++    if (wasDeleted) {
++      Runtime.getRuntime().removeShutdownHook(shutdownHook);
++    }
++    return wasDeleted;
+   }
+ }","I don't think we need to necessarily check if that returned true or not, we should just remove the shutdown hook. Since nothing would check or do anything with this flag anyways.",Shouldn't this be in 
+8598,"@@ -38,10 +38,15 @@ const kytheExtractionConfigFile = "".kythe-extraction-config""
+ // Repo is a container of input/output parameters for doing extraction on remote
+ // repositories.
+ type Repo struct {
+-	// Clone extracts a copy of the repo to the specified output Directory.
+-	Clone func(ctx context.Context, outputDir string) error
++	// Either GitRepo or LocalRepo should be set, not both.
++	// A remote git repo, e.g. https://github.com/google/kythe.
++	Git string
++	// A local copy of a repository.
++	Local string
++
+ 	// Where to write from an extraction.
+ 	OutputPath string
++
+ 	// An optional path to a file containing a
+ 	// kythe.proto.ExtractionConfiguration encoded as JSON that details how
+ 	// to perform extraction. If this is unset, the extractor will first try","nit: blank between, for consistency.",Why do we need this?
+8599,"@@ -21,8 +21,10 @@ import java.util.regex.Matcher;
+ /** Utility class for formatting source comments to follow RDoc style. */
+ public class RDocCommentFixer {
+ 
+-  /** Returns a Sphinx-formatted comment string. */
++  /** Returns a RDoc-formatted comment string. */
+   public static String rdocify(String comment) {
++    // escape '$' in the comment first
++    comment = comment.replaceAll(""\\$"", ""\\\\\\$"");
+     comment = CommentPatterns.BACK_QUOTE_PATTERN.matcher(comment).replaceAll(""+"");
+     comment = rdocifyProtoMarkdownLinks(comment);
+     comment = rdocifyCloudMarkdownLinks(comment);",ditto for RDoc or YARD link,Why do we need to esc
+8600,"@@ -173,7 +173,7 @@ public class DefaultConditionRunner implements ConditionRunner {
+     }
+ 
+     protected void log(String message) {
+-      logger.info(new Date() + "" - "" + message);
++      logger.finest(new Date() + "" - "" + message);
+     }
+ 
+   }",This method is designed to allow the condition runner to tell users something interesting. The current `INFO` log level is correct.,Why is this change needed?
+8601,"@@ -36,7 +36,7 @@ type Info struct {
+ 	SSLRequired       bool     `json:""ssl_required""` // DEPRECATED: ssl json used for older clients
+ 	TLSRequired       bool     `json:""tls_required""`
+ 	TLSVerify         bool     `json:""tls_verify""`
+-	MaxPayload        int      `json:""max_payload""`
++	MaxPayload        int64    `json:""max_payload""`
+ 	IP                string   `json:""ip,omitempty""`
+ 	ClientConnectURLs []string `json:""connect_urls,omitempty""` // Contains URLs a client can connect to.
+ ","Again, would not change that.",Why do we need to change t
+8602,"@@ -98,4 +98,16 @@ public enum Status {
+       return false;
+     }
+   }
++
++  public static boolean isStatusFailed(Status status) {
++    switch (status) {
++      case FAILED:
++      case KILLED:
++      case CANCELLED:
++      case FAILED_FINISHING:
++        return true;
++      default:
++        return false;
++    }
++  }
+ }",Is canceled considered failed?,nit: `isStatusFailed` -> `
+8603,"@@ -300,7 +300,7 @@ func TestBrowseJson(t *testing.T) {
+ 		req.Header.Set(""Accept"", ""application/json"")
+ 		rec := httptest.NewRecorder()
+ 
+-		code, err := b.ServeHTTP(rec, req)
++		code, _ := b.ServeHTTP(rec, req)
+ 
+ 		if code != http.StatusOK {
+ 			t.Fatalf(""In test %d: Wrong status, expected %d, got %d"", i, http.StatusOK, code)",These ineffectual assignment changes intrigue me. Our CI tests have been checking for these for months; how come the tests haven't been failing? How did you catch these?,Why are we ignoring the er
+8604,"@@ -103,10 +103,15 @@ func TestMintX509CA(t *testing.T) {
+ 			wrapper := Wrap(upstreamCA)
+ 
+ 			// Request Mint to wrapper
+-			resp, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
++			stream, err := wrapper.MintX509CA(ctx, &MintX509CARequest{
+ 				Csr:          testCase.csr,
+ 				PreferredTtl: testCase.preferredTTL,
+ 			})
++			// Stream returned, and no error expected
++			require.NoError(t, err)
++			require.NotNil(t, stream)
++
++			resp, err := stream.Recv()
+ 
+ 			// if test case expect an error validates it has expected code and message
+ 			if testCase.err != """" {",We should add an additional call to Recv() somewhere after here that we assert returns io.EOF.,"nit: `require.NoError(t, err)`"
+8605,"@@ -35,7 +35,8 @@ func setupJournalBlockServerTest(t *testing.T) (
+ 	// Clean up the config if the rest of the setup fails.
+ 	defer func() {
+ 		if !setupSucceeded {
+-			CheckConfigAndShutdown(t, config)
++			ctx := context.Background()
++			CheckConfigAndShutdown(ctx, t, config)
+ 		}
+ 	}()
+ ","Why not return a `ctx` from `setupJournalBlockServerTest` and use it everywhere, like in the other test files? And maybe put a test timeout on it while you're at it? (Same for the other journal test files below.)",Why do we need a context here?
+8606,"@@ -33,7 +33,17 @@
+ 
+ 
+ // ObjectTracker undestroyed objects validation function
+-bool ObjectLifetimes::ReportUndestroyedObjects(VkDevice device, const std::string& error_code) {
++bool ObjectLifetimes::ReportUndestroyedInstanceObjects(VkInstance instance, const std::string& error_code) {
++    bool skip = false;
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeSurfaceKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeSwapchainKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDisplayKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDisplayModeKHR, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDebugReportCallbackEXT, error_code);
++    skip |= InstanceReportUndestroyedObjects(instance, kVulkanObjectTypeDebugUtilsMessengerEXT, error_code);
++    return skip;
++}
++bool ObjectLifetimes::ReportUndestroyedDeviceObjects(VkDevice device, const std::string& error_code) {
+     bool skip = false;
+     skip |= DeviceReportUndestroyedObjects(device, kVulkanObjectTypeCommandBuffer, error_code);
+     skip |= DeviceReportUndestroyedObjects(device, kVulkanObjectTypeSemaphore, error_code);",Do we need HeadlessSurface and DisplayPlaneSurface here too?,Shouldn't this be `InstanceRep
+8607,"@@ -473,7 +473,7 @@ describe('GridFS Stream', function () {
+                     // Fail if user tries to abort an aborted stream
+                     uploadStream.abort().then(null, function (error) {
+                       expect(error.toString()).to.equal(
+-                        'MongoDriverError: Cannot call abort() on a stream twice'
++                        'MongoGridFSStreamError: Cannot call abort() on a stream twice'
+                       );
+                       client.close(done);
+                     });",Would it be appropriate for this to be a `MongoStreamClosedError`?,This should be `MongoGridFSStr
+8608,"@@ -26,11 +26,13 @@ import (
+ 	""github.com/golang/glog""
+ 	""github.com/openebs/maya/pkg/apis/openebs.io/v1alpha1""
+ 	clientset ""github.com/openebs/maya/pkg/client/generated/clientset/internalclientset""
++	snapclient ""github.com/openebs/maya/pkg/client/generated/openebs.io/snapshot/v1/clientset/internalclientset""
+ 	""k8s.io/api/admission/v1beta1""
+ 	admissionregistrationv1beta1 ""k8s.io/api/admissionregistration/v1beta1""
+ 	v1 ""k8s.io/api/apps/v1""
+ 	corev1 ""k8s.io/api/core/v1""
+ 
++	""k8s.io/apimachinery/pkg/api/resource""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ 	""k8s.io/apimachinery/pkg/runtime""
+ 	""k8s.io/apimachinery/pkg/runtime/serializer""",Can you raise new issue that talks about refactoring webhook code. It should follow `idiomatic maya` patterns.,I don't think this is needed.
+8609,"@@ -0,0 +1,9 @@
++using Datadog.Trace.Interfaces;
++
++namespace Datadog.Trace.ClrProfiler.Interfaces
++{
++    internal interface ISpanDecorator
++    {
++        void Decorate(ISpan span);
++    }
++}","(Probably repeating myself) Instead of `Datadog.Trace.Interfaces`, should we move this and several other files into a `Datadog.Trace.Decorators` namespace instead?",I think this should be `ISpan
+8610,"@@ -1,6 +1,7 @@
+ # -*- encoding : utf-8 -*-
+ require 'kaminari'
+ require 'rsolr'
++require 'deprecation'
+ module Blacklight
+ 
+   autoload :Configurable, 'blacklight/configurable'","Should we generate `gem ""rsolr""` into the application Gemfile?",Why do we need this?
+8611,"@@ -130,6 +130,8 @@ static struct optparse_option attach_opts[] =  {
+     { .name = ""label-io"", .key = 'l', .has_arg = 0,
+       .usage = ""Label output by rank"",
+     },
++    { .name = ""verbose"", .key = 'v', .has_arg = 0,
++      .usage = ""Increase verbosity"" },
+     { .name = ""quiet"", .key = 'q', .has_arg = 0,
+       .usage = ""Suppress warnings written to stderr from flux-job"",
+     },","commit message, ""currently ignored""? (-ed)",I don't think this should be 
+8612,"@@ -37,6 +37,12 @@ module Selenium
+         def bridge_class
+           Bridge
+         end
++
++        def print_page(**options)
++          options[:page_ranges] &&= Array(options[:page_ranges])
++
++          bridge.print_page(options)
++        end
+       end # Driver
+     end # Firefox
+   end # WebDriver",Same here. and all others.,Extra empty line detected at class body end.
+8613,"@@ -25,14 +25,16 @@ namespace Nethermind.Blockchain
+     public class OneTimeChainProcessor : IBlockchainProcessor
+     {
+         private readonly IBlockchainProcessor _processor;
++        private readonly IBlockchainProcessor _mainChainProcessor;
+         private readonly IReadOnlyDbProvider _readOnlyDbProvider;
+ 
+         private object _lock = new object();
+ 
+-        public OneTimeChainProcessor(IReadOnlyDbProvider readOnlyDbProvider, IBlockchainProcessor processor)
++        public OneTimeChainProcessor(IReadOnlyDbProvider readOnlyDbProvider, IBlockchainProcessor processor, IBlockchainProcessor mainChainProcessor = null)
+         {
+             _readOnlyDbProvider = readOnlyDbProvider ?? throw new ArgumentNullException(nameof(readOnlyDbProvider));
+             _processor = processor ?? throw new ArgumentNullException(nameof(processor));
++            _mainChainProcessor = mainChainProcessor;
+         }
+ 
+         public void Start()",can we pass some simple interface instead of a full additional processor? (an imterface with these two events only),Why do we need the mainChainProcessor?
+8614,"@@ -107,6 +107,8 @@ insert_exit_stub_other_flags(dcontext_t *dcontext, fragment_t *f,
+     /* FIXME i#1575: coarse-grain NYI on ARM */
+     ASSERT_NOT_IMPLEMENTED(!TEST(FRAG_COARSE_GRAIN, f->flags));
+     if (LINKSTUB_DIRECT(l_flags)) {
++        /* We put a NOP here for future linking. */
++        *pc++ = 0xd503201f;
+         /* stp x0, x1, [x(stolen), #(offs)] */
+         *pc++ = (0xa9000000 | 0 | 1 << 10 | (dr_reg_stolen - DR_REG_X0) << 5 |
+                  TLS_REG0_SLOT >> 3 << 15);",Use a named constant,Why is this needed?
+8615,"@@ -56,7 +56,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+ 
+             var stop = Assert.Single(events, e => e.EventName == ""ConnectionStop"");
+             Assert.All(new[] { ""connectionId"" }, p => Assert.Contains(p, stop.PayloadNames));
+-            Assert.Same(KestrelEventSource.Log, stop.EventSource);
++            Assert.Same(KestrelEventSource.Log, stop?.EventSource);
+         }
+ 
+         private string GetProperty(EventWrittenEventArgs data, string propName)",The `?` is unnecessary since `Assert.Single` will fail if it can't find the stop event.,Why is this nullable?
+8616,"@@ -29,6 +29,12 @@ import org.apache.iceberg.StructLike;
+  * Implementations must be {@link Serializable} because instances will be serialized to tasks.
+  */
+ public interface LocationProvider extends Serializable {
++
++  /**
++   * Return a fully-qualified data location.
++   */
++  String dataLocation();
++
+   /**
+    * Return a fully-qualified data file location for the given filename.
+    *",What about providers that don't have a reliable location? Do they return null?,Why do we need this method?
+8617,"@@ -14,9 +14,14 @@
+ // limitations under the License.
+ // </copyright>
+ 
++using System;
++
+ namespace OpenTelemetry.Metrics
+ {
+     public abstract class MetricProcessor : BaseProcessor<MetricItem>
+     {
++        // GetMetric or GetMemoryState or GetAggregatedMetrics..
++        // ...or some other names
++        public abstract void SetGetMetricFunction(Func<MetricItem> getMetrics);
+     }
+ }","I might not be thinking about things right, but would it make sense for a MetricProcessor to have a handle on the ParentProvider kinda like how we do for traces? That way instead of calling `SetGetMetricFunction(this.Collect)` in the MeterProviderSdk you'd have a handle on the provider to call `Collect` directly.",Why do we need this?
+8618,"@@ -30,7 +30,8 @@ def check_dynamodb(expect_shutdown=False, print_error=False):
+         # wait for backend port to be opened
+         wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path=""/"", expect_success=False, sleep_time=1)
+         # check DynamoDB
+-        out = aws_stack.connect_to_service(""dynamodb"").list_tables()
++        endpoint_url = f""http://127.0.0.1:{PORT_DYNAMODB_BACKEND}""
++        out = aws_stack.connect_to_service(""dynamodb"", endpoint_url=endpoint_url).list_tables()
+     except Exception as e:
+         if print_error:
+             LOGGER.error(""DynamoDB health check failed: %s %s"" % (e, traceback.format_exc()))","nit: If we want to squeeze out a few more milliseconds from the startup, we may actually be able to remove this line (`wait_for_port_open(PORT_DYNAMODB_BACKEND, http_path=""/"", ...` should already be sufficient to ensure that the service is up and responding to HTTP requests). Thoughts?",I think this should be `POR
+8619,"@@ -4880,7 +4880,7 @@ os_normalized_sysnum(int num_raw, instr_t *gateway, dcontext_t *dcontext)
+         }
+     }
+ #    ifdef X64
+-    if (num_raw >> 24 == 0x2)
++    if (num_raw & SYSCALL_NUM_MARKER_BSD)
+         return (int)(num_raw & 0xffffff); /* Drop BSD bit */
+     else
+         num = (int)num_raw; /* Keep Mach and Machdep bits */",Convention is to use TEST,I think this should be `num
+8620,"@@ -38,9 +38,9 @@ class TemporalMemoryCompatibilityTest(unittest.TestCase):
+   """"""
+ 
+ 
+-  @unittest.skip(""There are slight differences between implementations that""
+-                 ""prevent this from passing still. See ""
+-                 ""https://github.com/numenta/nupic/issues/2980"")
++  # @unittest.skip(""There are slight differences between implementations that""
++  #                ""prevent this from passing still. See ""
++  #                ""https://github.com/numenta/nupic/issues/2980"")
+   def testTMPyCpp(self):
+     """"""
+     Test compatibility between C++ and Python TM implementation.",Just in case: remember to remove this.,Why is this test disabled?
+8621,"@@ -61,7 +61,7 @@ public class EIP1559 {
+       final BigInteger target = BigInteger.valueOf(targetGasUsed);
+       final BigInteger denominator = BigInteger.valueOf(feeMarket.getBasefeeMaxChangeDenominator());
+       feeDelta = pBaseFee.multiply(gDelta).divide(target).divide(denominator).longValue();
+-      baseFee = parentBaseFee - feeDelta;
++      baseFee = max(parentBaseFee - feeDelta, 0);
+     }
+     LOG.trace(
+         ""block #{} parentBaseFee: {} parentGasUsed: {} parentGasTarget: {} baseFee: {}"",",I am not certain if this should be 0 or 7 here. I think a basefee under 7 is pathological,Shouldn't this be `>=`?
+8622,"@@ -20,6 +20,12 @@ vm[] = {
+ 	.0002908882086657216,
+ 	.0000048481368110953599
+ };
++/* byte sequence for Degree Sign U+00B0 in UTF-8. */
++	static constexpr char
++DEG_SIGN1 = '\xc2';
++	static constexpr char
++DEG_SIGN2 = '\xb0';
++
+ 	double
+ dmstor(const char *is, char **rs) {
+ 	return dmstor_ctx( pj_get_default_ctx(), is, rs );",it would be better to move the declaration of the variable with its initialization at line 68,Why not use `const char`?
+8623,"@@ -12,6 +12,7 @@
+ 
+  defined in: Hall and Kier JCICS _35_ 1039-1045 (1995)  Table 1
+ """"""
++import sys
+ from rdkit import Chem
+ 
+ _rawD = [",I don't think this is required.,Why is this needed?
+8624,"@@ -48,7 +48,7 @@ func TestSyncServiceContextUpdated(t *testing.T) {
+ 	}
+ 
+ 	// run the update context call once
+-	err := service.updateContext()
++	err := service.updateEthContext()
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}",This rename should also ideally be in a separate PR.,Why is this change needed?
+8625,"@@ -86,11 +86,14 @@ public final class HttpCall<V> extends Call.Base<V> {
+       if (t != null) {
+         callback.onError(t);
+       } else {
++        V value = null;
+         try {
+-          callback.onSuccess(parseResponse(response, bodyConverter));
+-        } catch (IOException e) {
+-          callback.onError(e);
++          value = parseResponse(response, bodyConverter);
++        } catch (Throwable t1) {
++          propagateIfFatal(t1);
++          callback.onError(t1);
+         }
++        if (value != null) callback.onSuccess(value);
+       }
+       return null;
+     });","Think this needs to go right below line 91. `parseResponse` can return `null` (line 133), which will cause this future to never complete.",`propagateIfFatal(t1);` is
+8626,"@@ -46,8 +46,8 @@ import java.util.List;
+ public class HttpCommandProcessor implements CommandProcessor {
+ 
+   private String pathToServlet;
+-  private String browserStartCommand;
+-  private String browserURL;
++  private final String browserStartCommand;
++  private final String browserURL;
+   private String sessionId;
+   private String extensionJs;
+   private String rcServerLocation;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,Why is this final?
+8627,"@@ -520,8 +520,7 @@ public class AzkabanWebServer extends AzkabanServer {
+       startWebMetrics();
+     }
+ 
+-    if(this.props.containsKey(ConfigurationKeys.ENABLE_QUARTZ) && this.props.getBoolean(ConfigurationKeys
+-        .ENABLE_QUARTZ)) {
++    if (this.props.getBoolean(ConfigurationKeys.ENABLE_QUARTZ, false)) {
+       this.quartzScheduler.start();
+     }
+ ","Yeah, why not use this method instead of checking with `containsKey`?",Shouldn't this be `true`?
+8628,"@@ -39,9 +39,9 @@ for i in range(loop_num):
+     torch.cuda.synchronize()
+     time_backward += timer.since_last_check()
+     bar.update()
+-print('\nCARAFE time forward: {} ms/iter | time backward: {} ms/iter'.format(
+-    (time_forward + 1e-3) * 1e3 / loop_num,
+-    (time_backward + 1e-3) * 1e3 / loop_num))
++print(f'\nCARAFE time forward: {(time_forward + 1e-3) * 1e3 / loop_num} '
++      f'ms/iter | time backward: {(time_backward + 1e-3) * 1e3 / loop_num}'
++      ' ms/iter')
+ 
+ time_naive_forward = 0
+ time_naive_backward = 0",Compute `(time_forward + 1e-3) * 1e3 / loop_num` ahead.,nit: I think it would be better to use `f'{time_forward:.2f} ms/iter'`
+8629,"@@ -74,18 +74,13 @@ namespace NLog.Internal
+                     throw;
+                 }
+ 
+-                if (LogManager.ThrowExceptions)
+-                {
+-                    throw;
+-                }
+-
+                 ReportExceptionInHandler(ex);
+             }
+         }
+ 
+         private static void ReportExceptionInHandler(Exception exception)
+         {
+-            InternalLogger.Error(""Exception in asynchronous handler {0}"", exception);
++            InternalLogger.Error(exception, ""Exception in asynchronous handler."");
+         }
+     }
+ }","Mh... `MustBeRethrown()` above already logs `ex`, so `ex` will be logged here for the second time. I think this line must be moved to before `MustBeRethrown()`.",Why is this being removed?
+8630,"@@ -29,11 +29,13 @@ import java.util.Map;
+  */
+ public class CommonDiscoveryProvider implements DiscoveryProvider {
+   private final DiscoveryContext context;
+-  private final SnippetSetRunner<Method> snippetSetRunner;
++  private final SnippetSetRunner.Generator<Method> snippetSetRunner;
+   private final String snippetFileName;
+ 
+   public CommonDiscoveryProvider(
+-      DiscoveryContext context, SnippetSetRunner<Method> snippetSetRunner, String snippetFileName) {
++      DiscoveryContext context,
++      SnippetSetRunner.Generator<Method> snippetSetRunner,
++      String snippetFileName) {
+     this.context = context;
+     this.snippetSetRunner = snippetSetRunner;
+     this.snippetFileName = snippetFileName;","Since this never changes, why not pass it into the constructor instead?",Why is this change needed?
+8631,"@@ -48,10 +48,10 @@ namespace Nethermind.Synchronization.BeamSync
+ 
+         private readonly ISyncModeSelector _syncModeSelector;
+ 
+-        private readonly Func<bool> _writeThrough;
+-
+         private ILogger _logger;
+ 
++        private IDb _targetDbForSaves;
++
+         public BeamSyncDb(IDb stateDb, IDb tempDb, ISyncModeSelector syncModeSelector, ILogManager logManager)
+             : base(logManager)
+         {",this is critical to avoid state root saving from beam,Why is this no longer a readonly field?
+8632,"@@ -231,7 +231,8 @@ class AnchorHead(nn.Module):
+         # map up to original set of anchors
+         if unmap_outputs:
+             num_total_anchors = flat_anchors.size(0)
+-            labels = unmap(labels, num_total_anchors, inside_flags)
++            labels = unmap(labels, num_total_anchors, inside_flags,
++                           self.num_classes)  # fill bg label
+             label_weights = unmap(label_weights, num_total_anchors,
+                                   inside_flags)
+             bbox_targets = unmap(bbox_targets, num_total_anchors, inside_flags)","To make it more clear, `fill=self.num_classes`.",Why do we need this?
+8633,"@@ -78,6 +78,11 @@ type Message struct {
+ 	AfterSend func(asFunc func(interface{}) bool) error
+ }
+ 
++// Implement batcher item for byte sized based batching
++func (m *Message) ByteSize() int {
++	return len(m.Body)
++}
++
+ // Topic publishes messages.
+ // Drivers may optionally also implement io.Closer; Close will be called
+ // when the pubsub.Topic is Shutdown.","Nit: ""ByteSize estimates the size in bytes of the message for the purpose of restricting batch sizes.""",Why do we need this?
+8634,"@@ -61,9 +61,11 @@ namespace SampleApp
+ 
+                     // The following section should be used to demo sockets
+                     //options.ListenUnixSocket(""/tmp/kestrel-test.sock"");
+-
++                })
++                .UseLibuv(options =>
++                {
+                     // Uncomment the following line to change the default number of libuv threads for all endpoints.
+-                    //options.ThreadCount = 4;
++                    options.ThreadCount = 4;
+                 })
+                 .UseContentRoot(Directory.GetCurrentDirectory())
+                 .UseStartup<Startup>()",It's weird to have this on the same level as kestrel. This needs to move to options.,Why do we need this 
+8635,"@@ -476,7 +476,11 @@ module.exports = class Webcam extends Plugin {
+   }
+ 
+   getVideo () {
+-    const mimeType = this.recordingChunks[0].type
++    // Sometimes in iOS Safari, Blobs (especially the first Blob in the recordingChunks Array)
++    // have empty 'type' attributes (e.g. '') so we need to find a Blob that has a defined 'type'
++    // attribute in order to determine the correct MIME type.
++    const mimeType = this.recordingChunks.find(blob => blob.type?.length > 0).type
++
+     const fileExtension = getFileTypeExtension(mimeType)
+ 
+     if (!fileExtension) {",is it safe for us to use the `blob.type?.length` optional chaining with IE11 support? @goto-bus-stop,I'm not sure if this
+8636,"@@ -125,13 +125,14 @@ class User < ActiveRecord::Base
+   # @param new_organisation_id [Integer] the id for an organisation
+   # @return [String] the empty string as a causality of setting api_token
+   def org_id=(new_org_id)
++    puts ""$$$$ new_org_id: #{new_org_id}""
+     unless self.can_change_org? || new_org_id.nil? || self.org.nil? || (new_org_id.to_s == self.org.id.to_s)
+       # rip all permissions from the user
+       self.perms.delete_all
+     end
+     # set the user's new organisation
+     super(new_org_id)
+-    self.save!
++    # self.save!
+     # rip api permissions from the user
+     self.remove_token!
+   end",remove this debug statement,Is this intended to be here?
+8637,"@@ -2357,7 +2357,12 @@ bool StatelessValidation::manual_PreCallValidateCmdCopyImage(VkCommandBuffer com
+ 
+     VkImageAspectFlags legal_aspect_flags =
+         VK_IMAGE_ASPECT_COLOR_BIT | VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT | VK_IMAGE_ASPECT_METADATA_BIT;
+-    if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
++    // YCbCr is core after 1.1
++    if (api_version >= VK_API_VERSION_1_1) {
++        legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT | VK_IMAGE_ASPECT_PLANE_1_BIT | VK_IMAGE_ASPECT_PLANE_2_BIT);
++    }
++    // If physical device does not support 1.1, check for YCbCr extension support
++    else if (device_extensions.vk_khr_sampler_ycbcr_conversion) {
+         legal_aspect_flags |= (VK_IMAGE_ASPECT_PLANE_0_BIT_KHR | VK_IMAGE_ASPECT_PLANE_1_BIT_KHR | VK_IMAGE_ASPECT_PLANE_2_BIT_KHR);
+     }
+ ","This should not be needed. 1) all 1.1 promoted extensions are marked as enabled when a 1.1 device is created (which happens iff both physical device support and apiVersion are set to 1.1) 2) The KHR and non-KHR versions of the bits are aliases of each other, so no different set is required.",Shouldn't this be `>=` inste
+8638,"@@ -656,7 +656,11 @@ static void makeflow_node_complete(struct dag *d, struct dag_node *n, struct bat
+ 
+ 	struct list *outputs = makeflow_generate_output_files(n, wrapper, monitor);
+ 
+-	if(info->exited_normally && info->exit_code == 0) {
++
++	if(getenv(""CCTOOLS_LOOP_DEV_FULL"")) {
++		job_failed = 1;
++	}
++	else if(info->exited_normally && info->exit_code == 0) {
+ 		list_first_item(outputs);
+ 		while((f = list_next_item(outputs))) {
+ 			if(!makeflow_node_check_file_was_created(n, f))","I can see why you did it this way, but let's not get into the habit of passing information back via an environment variable. Add an element to `batch_job_info` instead, which is where we send back detailed info about jobs.",Why is this needed?
+8639,"@@ -438,7 +438,11 @@ function diffElementNodes(
+ 			if (
+ 				'value' in newProps &&
+ 				(i = newProps.value) !== undefined &&
+-				i !== dom.value
++				// #2756 For the <progress>-element the initial value is 0,
++				// despite the attribute not being present. When the attribute
++				// is missing the progress bar is treated as indeterminate.
++				// To fix that we'll always update it when it is 0 for progress elements
++				(i !== dom.value || (newVNode.type === 'progress' && !i))
+ 			) {
+ 				setProperty(dom, 'value', i, oldProps.value, false);
+ 			}","Turns out my previous fix of doing `!dom.hasAttribute('value')` is not a good one as it leads to all input values always being updated. The new fix only updates it, despite `dom.value === props.value` when the value is `0` for progress elements.",I don't think this is the ri
+8640,"@@ -3,6 +3,7 @@
+ #include <cmath>
+ #include <cstdio>
+ #include <ctime>
++#include <vector>
+ 
+ #include ""caffe/common.hpp""
+ #include ""caffe/util/rng.hpp""",Why is this being added here? Is this relevant to these changes?,Why is this needed?
+8641,"@@ -74,7 +74,7 @@ public class SeleniumServer extends JettyServer {
+           getClass().getClassLoader())
+           .asSubclass(Routable.class);
+       Constructor<? extends Routable> constructor = rcHandler.getConstructor(ActiveSessions.class);
+-      LOG.info(""Bound legacy RC support"");
++      LOG.finest(""Bound legacy RC support"");
+       return constructor.newInstance(sessions);
+     } catch (ReflectiveOperationException e) {
+       // Do nothing.",This informational message is important to users. Please leave.,Why is this change 
+8642,"@@ -0,0 +1,4 @@
++All unapproved FY15 credit card funding requests are being cancelled.
++If the need still exists, please submit a new FY16 funding request.
++
++<%= url_for(controller: 'proposals', action: 'show', id: @proposal.id) %>",why isn't rubocop failing for single quotes?,I don't think you n
+8643,"@@ -36,14 +36,10 @@ class StatusAttributeDataSetQueryBuilder extends AbstractAttributeDataSetBuilder
+     {
+         $query->addSelect(sprintf(
+             '(
+-                SELECT value FROM product_value pv
+-                JOIN value_translation vt ON vt.value_id = pv.value_id
+-                WHERE pv.attribute_id = \'%s\'
+-                AND pv.product_id = p.id
+-                AND vt.language IS NULL
++                SELECT status_id FROM product_workflow_status pws
++                WHERE pws.product_id = p.id                
+                 LIMIT 1           
+             ) AS ""%s""',
+-            $attribute->getId()->getValue(),
+             $key
+         ));
+     }",Is `WHERE` should `Language` param ?,Why did you remove 
+8644,"@@ -46,6 +46,7 @@ namespace oneapi::dal::basic_statistics::backend {
+ namespace de = dal::detail;
+ namespace be = dal::backend;
+ namespace pr = dal::backend::primitives;
++namespace ps = oneapi::dal::preview::spmd;
+ 
+ using alloc = sycl::usm::alloc;
+ ","ps - first letter from preview, when we move it into public it will not be relevant. my suggestion is spmd or ds(distributed)",using pr = dal::backend::primitives;
+8645,"@@ -1757,7 +1757,18 @@ class Frame(object, metaclass=ABCMeta):
+         2  6  30   30
+         3  7  40   50
+         """"""
+-        return self._apply_series_op(lambda kser: kser._with_new_scol(F.abs(kser.spark.column)))
++
++        def abs(kser):
++            if isinstance(kser.spark.data_type, BooleanType):
++                return kser
++            elif isinstance(kser.spark.data_type, NumericType):
++                return kser.spark.transform(F.abs)
++            else:
++                raise TypeError(
++                    ""bad operand type for abs(): {}"".format(kser.spark.data_type.simpleString())
++                )
++
++        return self._apply_series_op(abs)
+ 
+     # TODO: by argument only support the grouping name and as_index only for now. Documentation
+     # should be updated when it's supported.","Hm, should we show pandas' dtype instead of Spark data type?",Why do we need this special case?
+8646,"@@ -23,10 +23,13 @@ namespace OpenTelemetry.Metrics
+     {
+         /*
+         Type:
+-            0x10: Sum
+-            0x20: Gauge
+-            0x30: Histogram
+-            0x40: Summary (reserved)
++            0x10 0b00010000: Sum
++            0x20 0b00100000: Gauge
++            0x40 0b01000000: Histogram
++            0x50 0b01010000: HistogramWithBuckets
++            0x60 0b01100000: HistogramWithMinMax
++            0x70 0b01110000: HistogramWithMinMaxAndBuckets
++            0x80 0b10000000: Summary (reserved)
+ 
+         Point kind:
+             0x04: I1 (signed 1-byte integer)","@reyang when exponentialhistogram arrives, we won't have any bits left for it.. unless we take Summary or make this 16 bits instead of current 8 bytes",I don't think this is correct.
+8647,"@@ -2,6 +2,8 @@
+ 
+ class PdoStatement {
+     /**
++     * @psalm-taint-sink text $class
++     *
+      * @template T
+      * @param class-string<T> $class
+      * @return false|T",This change is not tested.. I guess this is how these taint-annotations work..?,Why is this needed?
+8648,"@@ -485,6 +485,14 @@ class ConfigOverrider(object):
+ 
+         dest.dump()
+ 
++    def __apply_mult_override(self, obj, key, replace_value):
++        for k, v in obj.items():
++            if isinstance(v, dict):
++                obj[k] = self.__apply_mult_override(v, key, replace_value)
++        if key in obj:
++            obj[key] = replace_value
++        return obj
++
+     def __apply_single_override(self, dest, name, value):
+         """"""
+         Apply single override",Fails if obj is list. Please fix!,Why do we need this?
+8649,"@@ -28,5 +28,16 @@ class TestInstanceStatusResponseParsing(unittest.TestCase):
+         self.assertEqual(all_statuses.next_token, 'page-2')
+ 
+ 
++    def test_include_all_instances(self):
++        ec2 = EC2Connection(aws_access_key_id='aws_access_key_id',
++                            aws_secret_access_key='aws_secret_access_key')
++        mock_response = mock.Mock()
++        mock_response.read.return_value = INSTANCE_STATUS_RESPONSE
++        mock_response.status = 200
++        ec2.make_request = mock.Mock(return_value=mock_response)
++        all_statuses = ec2.get_all_instance_status(include_all_instances=True)
++        self.assertEqual(all_statuses.next_token, 'page-2')
++
++
+ if __name__ == '__main__':
+     unittest.main()",Could you add an assertion to make sure the `IncludeAllInstances` parameter is actually set and passed to the request?,You can use `self.as
+8650,"@@ -79,7 +79,8 @@ def __get_analyzer_version(context, analyzer_config_map):
+         version = [analyzer_bin, u' --version']
+         try:
+             output = subprocess.check_output(shlex.split(' '.join(version)),
+-                                             env=check_env)
++                                             env=check_env,
++                                             universal_newlines=True)
+             versions[analyzer_bin] = output
+         except (subprocess.CalledProcessError, OSError) as oerr:
+             LOG.warning(""Failed to get analyzer version: %s"",","The name of this argument is not too intuitive. The point is, these kind of subprocess calls will return `str`s in Python2 and 'byte`s in Python3. It would be a lot of work to make CodeChecker handle both `str` and `byte` everywhere. Using the `universal_newlines` argument, we can force Python3 to return text rather then bytes.",Why is this necessar
+8651,"@@ -63,7 +63,7 @@ func toProtoDomainReplicationConfiguration(in *shared.DomainReplicationConfigura
+ 	}
+ 	return &common.DomainReplicationConfiguration{
+ 		ActiveClusterName: in.GetActiveClusterName(),
+-		Clusters:          toProtoClusterReplicationConfigurations(in.Clusters),
++		Clusters:          toProtoClusterReplicationConfigurations(in.GetClusters()),
+ 	}
+ }
+ ",These `Get`s are just cosmetic changes for consistency.,Why do we need this 
+8652,"@@ -55,13 +55,7 @@ def test_read_yaml(tmpdir):
+     assert parsed_string == parsed_path_obj
+ 
+ 
+-def test_yaml_has_comments(tmpdir):
+-    no_comments_yaml = """"""blah: foo\nfizz: boop""""""
+-
+-    assert not util.yaml_has_comments(util.read_yaml(no_comments_yaml))
+-    assert util.yaml_has_comments(util.read_yaml(TEST_YAML))
+-
+-
++@pytest.mark.skip(reason=""Broken due to yaml safe load"")
+ def test_read_yaml_exec_flaw(capfd):
+     # We don't execute anything remote, but someone could give a bad build.yml..
+     util.read_yaml(""""""!!python/object/apply:os.system\nargs: ['echo arbitrary code execution!']"""""")","We should never skip unit tests, but instead fix them. Look at `pytest.raises` for cases where we expect an exception.",Why is this test being removed?
+8653,"@@ -79,11 +79,15 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+         public async Task<bool> PushItemsToFeedAsync(IEnumerable<string> items, bool allowOverwrite)
+         {
+             Log.LogMessage(MessageImportance.Low, $""START pushing items to feed"");
+-            Random rnd = new Random();
+ 
+-            try
++            if (!items.Any())
+             {
++                Log.LogMessage(""No items to push found in the items list."");
++                return true;
++            }
+ 
++            try
++            {
+                 bool result = await PushAsync(items.ToList(), allowOverwrite);
+                 return result;
+             }",Do we need to call ToList here?,Why do we need to return true h
+8654,"@@ -5,5 +5,8 @@ class EpisodesController < ApplicationController
+ 
+   def show
+     @episode = Episode.find(params[:id])
++    if topic = @episode.topics.first
++      @products = topic.products.ordered
++    end
+   end
+ end","I think this can be moved into the model, at the very least, but I also think you might be able to do a has many through.",Use 2 (not 0) spaces for indent
+8655,"@@ -785,7 +785,7 @@ public interface Tree<T> extends Traversable<T> {
+             if (tree.isLeaf()) {
+                 return value;
+             } else {
+-                return String.format(""(%s %s)"", value, tree.getChildren().map(Node::toLispString).mkString("" ""));
++                return ""("" + value + "" "" + (tree.getChildren().map(Node::toLispString).mkString("" "")) + "")"";
+             }
+         }
+ ",could you please separate computations from string concatenation?,`mkString` is not needed here.
+8656,"@@ -216,8 +216,8 @@ namespace Microsoft.Rest.Generator.Tests
+ 
+             var type = clientModel.ModelTypes.First();
+ 
+-            Assert.Equal(""code"", type.Properties[0].Name);
+-            Assert.Equal(""message"", type.Properties[1].Name);
++            Assert.Equal(""errorCode"", type.Properties[0].Name);
++            Assert.Equal(""errorMessage"", type.Properties[1].Name);
+             Assert.Equal(""parentError"", type.Properties[2].Name);
+         }
+ ",@NiklasGustafsson - I had to make these changes for the x-ms-client-name extension tests for java and python. The tests were expecting wire format instead of the client name. Hence modified them appropriately. Let me know what you think ?,Why did you change these?
+8657,"@@ -59,6 +59,13 @@ static int on_req(h2o_handler_t *_self, h2o_req_t *req)
+         authority = &self->upstream.authority;
+     }
+ 
++    /* rewrite headers */
++    if (self->config.header_cmds.size != 0) {
++        h2o_headers_command_t *cmd;
++        for (cmd = self->config.header_cmds.entries; cmd->cmd != H2O_HEADERS_CMD_NULL; ++cmd)
++            h2o_rewrite_headers(&req->pool, &req->headers, cmd);
++    }
++
+     /* request reprocess */
+     h2o_reprocess_request(req, req->method, scheme, *authority,
+                           h2o_build_destination(req, self->upstream.path.base, self->upstream.path.len, 0), overrides, 0);","Could we just set the list of header modification commands to `req->overrides` and apply them only when the request is sent upstream in lib/core/proxy.c? The reason I ask is because an upstream server (accessed using the modified headers) might return 399. In such case, the request would be delegated to the next handler. I think that the headers of the original request should be passed to the next handler, since per my understanding the intended behavior of `proxy.header.*` is to modify the headers passed to the upstream server only.",Shouldn't this be `if (cm
+8658,"@@ -214,6 +214,12 @@ type Table struct {
+ 	// to top-level chains.
+ 	insertMode string
+ 
++	// Record when we did our most recent updates and refreshes of the table.  We use these to
++	// calculate the next time we should force a refresh.
++	lastUpdateTime  time.Time
++	lastRefreshTime time.Time
++	refreshInterval time.Duration
++
+ 	logCxt *log.Entry
+ 
+ 	gaugeNumChains        prometheus.Gauge","Can we rename 'refresh' to 'read' and 'update' to 'write'? Until I had read more of the code below, I couldn't tell the difference between 'update' and 'refresh'.",nit: can we call this `la
+8659,"@@ -76,7 +76,7 @@ export default class VerdaccioProcess implements IServerProcess {
+     });
+ 
+     this.childFork.on('error', (err) => {
+-      console.log('error process', err);
++      // console.log('error process', err);
+       reject([err, this]);
+     });
+ ",can we remove it ?,Can we remove this?
+8660,"@@ -228,4 +228,17 @@ NAString ComConvertTrafNameToNativeName(
+   return convertedName;
+ }
+ 
++NABoolean ComTrafReservedColName(
++     const NAString &colName)
++{
++
++  if ((colName == TRAF_SALT_COLNAME) ||
++      (colName == TRAF_SYSKEY_COLNAME))
++    return TRUE;
+ 
++  if ((memcmp(colName.data(), TRAF_DIVISION_COLNAME_PREFIX, strlen(TRAF_DIVISION_COLNAME_PREFIX)) == 0) &&
++      (colName.data()[colName.length()-1] == '_'))
++    return TRUE;
++
++  return FALSE;
++}","I take it that by the time we get here, colName has already been case-shifted to upper case?",I think it would be better to use `snake_case` here.
+8661,"@@ -126,11 +126,14 @@ func ResponseHeaders(h *map[string]string) CallOption {
+ 	return CallOption{func(o *OutboundCall) { o.responseHeaders = h }}
+ }
+ 
+-// TODO(abg): Example tests to document the different options
+-
+-// WithHeader adds a new header to the request.
++// WithHeader adds a new header to the request. Header keys are case
++// insensitive.
++//
++// 	_, err := client.GetValue(ctx, reqBody, yarpc.WithHeader(""Token"", ""10""))
++// 	// ==> {""token"": ""10""}
+ //
+-// 	resBody, err := client.GetValue(ctx, reqBody, yarpc.WithHeader(""Token"", ""10""))
++// If multiple entries have the same normalized header name, newer entries
++// override older ones.
+ func WithHeader(k, v string) CallOption {
+ 	return CallOption{func(o *OutboundCall) {
+ 		o.headers = append(o.headers, keyValuePair{k: k, v: v})",Super clear desc - thx.,I'm not sure if this is the right way to do this. I 
+8662,"@@ -3551,7 +3551,11 @@ void SwiftASTContext::LoadModule(swift::ModuleDecl *swift_module,
+         all_dlopen_errors.GetData());
+   };
+ 
+-  swift_module->collectLinkLibraries(addLinkLibrary);
++  swift_module->forAllVisibleModules(
++      {}, [&](swift::ModuleDecl::ImportedModule import) {
++        import.second->collectLinkLibraries(addLinkLibrary);
++        return true;
++      });
+   error = current_error;
+ }
+ ","Ahh the correct fix is to call `collectLinkLibraries` on the SourceFile being compiled, not the module. Sorry for our mistake!",Why do we need this?
+8663,"@@ -64,6 +64,7 @@ func TestConfigDefault(t *testing.T) {
+ 		""Default TaskMetadataSteadyStateRate is set incorrectly"")
+ 	assert.Equal(t, DefaultTaskMetadataBurstRate, cfg.TaskMetadataBurstRate,
+ 		""Default TaskMetadataBurstRate is set incorrectly"")
++	assert.False(t, cfg.SharedVolumeMatchFullConfig, ""Default SharedVolumeMatchFullConfig set incorrectly"")
+ }
+ 
+ // TestConfigFromFile tests the configuration can be read from file",Can you also modify the `TestEnvironmentConfig` in `config_test.go` to cover this?,"assert.Equal(t, DefaultTaskMetadataSteadyStateRate, "
+8664,"@@ -120,8 +120,12 @@ public class SalesforceNetworkPlugin extends ForcePlugin {
+             }
+             restClient.sendAsync(request, new RestClient.AsyncRequestCallback() {
+ 
++                // TODO: Remove onSuccess for 9.0 Release.
+                 @Override
+-                public void onSuccess(RestRequest request, RestResponse response) {
++                public void onSuccess(RestRequest request, RestResponse response) {}
++
++                @Override
++                public void onResponse(RestRequest request, RestResponse response) {
+                     try {
+                         // Not a 2xx status
+                         if (!response.isSuccess()) {","There's no point ""deprecating"" this interface method (the customer still has to implement the new callback that we have introduced which makes it a breaking change). I'd make an exception and simply rename it to `onResponse`.",I think this should be removed.
+8665,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,Why is this changed to `finest`
+8666,"@@ -40,6 +40,8 @@ THE SOFTWARE.
+ #include ""hip_hcc_internal.h""
+ #include ""trace_helper.h""
+ 
++//TODO Add support for multiple modules
++static std::unordered_map<std::string, uintptr_t> coGlobals;
+ //TODO Use Pool APIs from HCC to get memory regions.
+ 
+ #include <cassert>",I know this is not new here but we need to remove this global or protect access from multiple threads.,Why do we need this?
+8667,"@@ -30,13 +30,13 @@ namespace OpenTelemetry.Trace
+         /// Enables HttpClient and HttpWebRequest instrumentation.
+         /// </summary>
+         /// <param name=""builder""><see cref=""TracerProviderBuilder""/> being configured.</param>
+-        /// <param name=""configureHttpClientInstrumentationOptions"">HttpClient configuration options.</param>
+         /// <param name=""configureHttpWebRequestInstrumentationOptions"">HttpWebRequest configuration options.</param>
++        /// <param name=""configureHttpClientInstrumentationOptions"">HttpClient configuration options.</param>
+         /// <returns>The instance of <see cref=""TracerProviderBuilder""/> to chain the calls.</returns>
+         public static TracerProviderBuilder AddHttpClientInstrumentation(
+             this TracerProviderBuilder builder,
+-            Action<HttpClientInstrumentationOptions> configureHttpClientInstrumentationOptions = null,
+-            Action<HttpWebRequestInstrumentationOptions> configureHttpWebRequestInstrumentationOptions = null)
++            Action<HttpWebRequestInstrumentationOptions> configureHttpWebRequestInstrumentationOptions = null,
++            Action<HttpClientInstrumentationOptions> configureHttpClientInstrumentationOptions = null)
+ #else
+         /// <summary>
+         /// Enables HttpClient instrumentation.","Doesn't seem any less confusing or error-prone to me. IMO the solution is to not use ""object"" in the enrich callback signatures. Type safety/compile-time checking is our friend!",Why did you change this?
+8668,"@@ -19,6 +19,9 @@ module Travis
+         def export
+           super
+           sh.export 'TRAVIS_GO_VERSION', go_version, echo: false
++          sh.if '-z $GOMAXPROCS' do
++            sh.export 'GOMAXPROCS', '2', echo: true
++          end
+         end
+ 
+         def prepare",I think this should be `GOMAXPROCS=$(nproc 2>/dev/null || echo 2)`,I think this should be `GOMAXPROCS=2`
+8669,"@@ -175,8 +175,9 @@ func (ctx *rollDPoSCtx) validateProposeBlock(blk Block, expectedProposer string)
+ 		errorLog.Msg(""error when validating the block signature"")
+ 		return false
+ 	}
+-	if producer == ctx.addr.RawAddress {
+-		// If the block is self proposed, skip validation
++	// TODO: in long term, block in process and after process should be represented differently
++	if producer == ctx.addr.RawAddress && block.WorkingSet != nil {
++		// If the block is self proposed and working set is not nil (meaning not obtained from wire), skip validation
+ 		return true
+ 	}
+ 	containCoinbase := true",Can we log if this actually happens.,I don't think this is correct. If the
+8670,"@@ -203,6 +203,9 @@ public class RegistrationRequest {
+     if (pendingConfiguration.port != null) {
+       pendingRequest.configuration.port = pendingConfiguration.port;
+     }
++    if (pendingConfiguration.remoteHost != null) {
++      pendingRequest.configuration.remoteHost = pendingConfiguration.remoteHost;
++    }
+ 
+     // make sure we have a valid host
+     pendingRequest.configuration.fixUpHost();","This is not really needed, the line added in `GridNodeConfiguration.java` is what really fixes the `remoteHost` regression.",Shouldn't this be `remoteHost = pendi
+8671,"@@ -1,8 +1,10 @@
+ /* eslint-disable no-restricted-globals */
+ /* global __STORYBOOK_CLIENT_API__ */
++
+ /**
+  * External dependencies
+  */
++import lodash from 'lodash';
+ import React from 'react';
+ import { addDecorator, configure } from '@storybook/react';
+ ",It looks like the import format was only changed from one-per-line to all on one line here. Can we keep it as it was so it's easier to see what changed? It's also more consistent with how we format multiple imports in other components.,Why do we need lodash here?
+8672,"@@ -57,8 +57,10 @@ module Selenium
+     #
+     # @return [Driver]
+     #
+-    # @see Selenium::WebDriver::Remote::Bridge
++    # @see Selenium::WebDriver::Remote::OSSBridge
++    # @see Selenium::WebDriver::Remote::W3CBridge
+     # @see Selenium::WebDriver::Firefox::Bridge
++    # @see Selenium::WebDriver::Firefox::W3CBridge
+     # @see Selenium::WebDriver::IE::Bridge
+     # @see Selenium::WebDriver::Edge::Bridge
+     # @see Selenium::WebDriver::Chrome::Bridge",Maybe call it `WireBridge`?,I think this should be `W3C`
+8673,"@@ -5,12 +5,16 @@ import android.content.SharedPreferences;
+ import android.graphics.Color;
+ import android.os.StrictMode;
+ import android.preference.PreferenceManager;
++import android.util.Log;
+ 
++import org.json.JSONException;
++import org.json.JSONObject;
+ import org.mozilla.geckoview.GeckoSessionSettings;
+ import org.mozilla.telemetry.TelemetryHolder;
+ import org.mozilla.vrbrowser.BuildConfig;
+ import org.mozilla.vrbrowser.R;
+ import org.mozilla.vrbrowser.telemetry.TelemetryWrapper;
++import org.mozilla.vrbrowser.ui.widgets.WidgetPlacement;
+ import org.mozilla.vrbrowser.utils.DeviceType;
+ import org.mozilla.vrbrowser.utils.LocaleUtils;
+ import org.mozilla.vrbrowser.utils.StringUtils;",Looks like `org.json.*` can be removed?,I don't think you need this 
+8674,"@@ -890,7 +890,9 @@ public enum WidgetInfo
+ 	SECOND_TRADING_WITH_MY_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_MY_ITEMS),
+ 	SECOND_TRADING_WITH_THEIR_ITEMS(WidgetID.PLAYER_TRADE_CONFIRM_GROUP_ID, WidgetID.TradeScreen.SECOND_THEIR_ITEMS),
+ 
+-	GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIMER_GROUP_ID, WidgetID.GauntletTimer.CONTAINER);
++	GAUNTLET_TIMER_CONTAINER(WidgetID.GAUNTLET_TIMER_GROUP_ID, WidgetID.GauntletTimer.CONTAINER),
++	GAUNTLET_MAP(WidgetID.GAUNTLET_MAP_GROUP_ID, WidgetID.GauntletMap.CONTAINER),
++	;
+ 
+ 	private final int groupId;
+ 	private final int childId;",remove the extra comma and newline,Remove this empty line.
+8675,"@@ -1,3 +1,5 @@
++<% @page_title = t('blacklight.saved_searches.page_title', :application_name => application_name) %>
++
+ <div id=""content"" class=""col-md-9"">
+ 
+ <h1 class='page-heading'><%= t('blacklight.saved_searches.title') %></h1>",Can we try to use Ruby 1.9-style hashes?,I think this should be `@pag
+8676,"@@ -120,6 +120,17 @@ func RegisterHandlerDirective(dir string, setupFunc UnmarshalHandlerFunc) {
+ 	})
+ }
+ 
++// RegisterGlobalOption registers a unique global option opt with
++// an associated unmarshaling (setup) function. When the global
++// option opt is encountered in a Caddyfile, setupFunc will be
++// called to unmarshal its tokens.
++func RegisterGlobalOption(opt string, setupFunc UnmarshalGlobalFunc) {
++	if _, ok := registeredGlobalOptions[opt]; ok {
++		panic(""global option "" + opt + "" already registered"")
++	}
++	registeredGlobalOptions[opt] = setupFunc
++}
++
+ // Helper is a type which helps setup a value from
+ // Caddyfile tokens.
+ type Helper struct {","Terminology question - these are called ""global options"" in the code, but the parallel non-global versions of these are called ""directives""... Should this be `RegisterGlobalDirective`? Or does that have different semantics?",Why is this a panic?
+8677,"@@ -244,7 +244,7 @@ def isTypingProtected():
+ @rtype: boolean
+ """"""
+ 	focusObject=getFocusObject()
+-	if focusObject and (controlTypes.STATE_PROTECTED in focusObject.states or focusObject.role==controlTypes.ROLE_PASSWORDEDIT):
++	if focusObject and focusObject.isProtected:
+ 		return True
+ 	else:
+ 		return False","I do not care much, but you could as well just return bool(focusObject and focusObject.isProtected) here and avoid the if check? I know, really trivial.",`isProtected` is not
+8678,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked",I think you can use 
+8679,"@@ -50,7 +50,7 @@ public class GoLanguageProvider {
+ 
+   @SuppressWarnings(""unchecked"")
+   public <Element> GeneratedResult generate(
+-      Element element, SnippetDescriptor snippetDescriptor, GoGapicContext context) {
++      Element element, SnippetDescriptor snippetDescriptor, Object context) {
+     GoSnippetSet<Element> snippets =
+         SnippetSet.createSnippetInterface(
+             GoSnippetSet.class,","Do DiscoveryContext and GoGapicContext have a more specific common ancestor than Object? If so, let's use that.",Why is this change n
+8680,"@@ -119,7 +119,7 @@ module Beaker
+           :timeout              => 300,
+           :fail_mode            => 'slow',
+           :timesync             => false,
+-          :disable_iptables     => true,
++          :disable_iptables     => false,
+           :repo_proxy           => false,
+           :package_proxy        => false,
+           :add_el_extras        => false,",is this the intended behavior now?,Why is this change needed?
+8681,"@@ -27,6 +27,5 @@ public class TestDutchIJ extends StemmerTestBase {
+   public void testStemming() {
+     assertStemsTo(""ijs"", ""ijs"");
+     assertStemsTo(""IJs"", ""ijs"");
+-    assertStemsTo(""Ijs"");
+   }
+ }","Hunspell/C++ stems that a bit differently from Lucene, but in a controversial way, so I removed the check instead of changing the expectation",Why was this removed?
+8682,"@@ -172,7 +172,7 @@ func (o *opt) close() {
+ func (o *opt) runInitOnce() {
+ 	o.initOnce.Do(func() {
+ 		o.clock = &libkbfs.TestClock{}
+-		o.clock.Set(time.Unix(0, 0))
++		o.clock.Set(time.Unix(1, 0))
+ 		o.users = o.engine.InitTest(o.ver, o.blockSize,
+ 			o.blockChangeSize, o.batchSize, o.bwKBps, o.timeout, o.usernames,
+ 			o.teams, o.implicitTeams, o.clock, o.journal)",I'm curious why this is needed?,Why was this changed?
+8683,"@@ -742,7 +742,7 @@ void Combat::doCombat(Creature* caster, Creature* target) const
+ 			}
+ 			*/
+ 
+-			if (caster && params.distanceEffect != CONST_ANI_NONE) {
++			if (caster && target && params.distanceEffect != CONST_ANI_NONE) {
+ 				addDistanceEffect(caster, caster->getPosition(), target->getPosition(), params.distanceEffect);
+ 			}
+ 		}","I do not see how that changes anything, as the target is operated on many times before that line?",This should be `target->ge
+8684,"@@ -513,7 +513,7 @@ $(document).ready(function() {
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-geo"", url: ""#/analytics/geo"", text: ""sidebar.analytics.geo"", priority: 30});
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-sessions"", url: ""#/analytics/sessions"", text: ""sidebar.analytics.session"", priority: 20});
+         app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-users"", url: ""#/analytics/users"", text: ""sidebar.analytics.users"", priority: 10});
+-        app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-loyalty"", url: ""#/analytics/loyalty"", text: ""sidebar.analytics.user-loyalty"", priority: 15});
++        app.addSubMenuForType(""web"", ""analytics"", {code: ""analytics-loyalty"", url: ""#/analytics/loyalty"", text: ""sidebar.analytics.visitor-loyalty"", priority: 15});
+     }
+ 
+     app.addAppSwitchCallback(function(appId) {",Same user/visitor thing.,This should be `sidebar.analytics.visitor-loyalty`
+8685,"@@ -167,6 +167,13 @@ exit /B %errorlevel%
+             reg_query_command = %Q(reg query ""#{reg_key}"" /v ""RememberedPuppetAgentStartupMode"" | findstr #{msi_opts['PUPPET_AGENT_STARTUP_MODE']})
+             on host, Command.new(reg_query_command, [], { :cmdexe => true })
+ 
++            # (PA-620) environment.bat should be run before any cmd.exe shell command
++            # in order to properly set up environment variables
++            auto_run_key = ""HKLM\\SOFTWARE\\Microsoft\\Command Processor\AutoRun""
++            # TODO What's the best way to get the actual path to the script, respecting arch differences?
++            environment_script = ""C:\\Program Files\\Puppet Labs\\Puppet\bin\\environment.bat""
++            reg_add_command = %Q(reg add ""#{auto_run_key}"" /v ""PuppetEnvironment"" /d ""#{environment_script}"")
++
+             # emit the misc/versions.txt file which contains component versions for
+             # puppet, facter, hiera, pxp-agent, packaging and vendored Ruby
+             [",This is not the correct path on all hosts. How can I correctly determine whether I will need to look in `Program Files` or `Program Files (x86)` for the script?,I'm not sure if this is the best way to get the ac
+8686,"@@ -73,8 +73,15 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+ 
+             this.maxFlushIntervalTimer.Elapsed += async (sender, args) =>
+             {
+-                await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
+-            };
++                try
++                {
++                    await this.FlushAsyncInternal(false, CancellationToken.None).ConfigureAwait(false);
++                }
++                catch (Exception ex)
++                {
++                    JaegerExporterEventSource.Log.FailedToSend(ex);
++                }
++            };
+         }
+ 
+         public Process Process { get; internal set; }","I think it would be better to move this try/catch block inside of the `FlushAsyncInternal` function as there are a few of places that can call it, eg event timer (here), AppendAsync, FlushAsync and CloseAsync.",Why do we need this?
+8687,"@@ -79,6 +79,7 @@ final class IndexingChain implements Accountable {
+ 
+   // Holds fields seen in each document
+   private PerField[] fields = new PerField[1];
++  private PerField[] docFields = new PerField[10];
+   private final InfoStream infoStream;
+   private final ByteBlockPool.Allocator byteBlockAllocator;
+   private final LiveIndexWriterConfig indexWriterConfig;",should we set a smaller initial size to make sure that we exercise the growing logic in our tests?,// Holds fields seen in each document
+8688,"@@ -230,3 +230,9 @@ def test_sum():
+     assert str(dt.sum(f[:])) == str(f[:].sum())
+     DT = dt.Frame(A=range(1, 10))
+     assert_equals(DT[:, f.A.sum()], DT[:, dt.sum(f.A)])
++
++def test_max():
++    assert str(dt.max(f.A)) == str(f.A.max())
++    assert str(dt.max(f[:])) == str(f[:].max())
++    DT = dt.Frame(A=range(1, 10))
++    assert_equals(DT[:, f.A.max()], DT[:, dt.max(f.A)])","Let's add a new line at the end of this file, so that the last line becomes a valid line of code.",I think you can use `assert_equals` here.
+8689,"@@ -3131,7 +3131,7 @@ Offset<reflection::Field> FieldDef::Serialize(FlatBufferBuilder *builder,
+ }
+ 
+ bool FieldDef::Deserialize(Parser &parser, const reflection::Field *field) {
+-  name = parser.UnqualifiedName(field->name()->str());
++  name = field->name()->str();
+   defined_namespace = parser.current_namespace_;
+   if (!value.type.Deserialize(parser, field->type()))
+     return false;",Why was this removed?,Why this change?
+8690,"@@ -20,5 +20,12 @@ namespace Microsoft.CodeAnalysis.Sarif.SarifValidator
+             HelpText = ""Path of the SARIF file to validate"",
+             Required = true)]
+         public string InstanceFilePath { get; set; }
++
++        [Option(
++            'l',
++            ""log-file-path"",
++            HelpText = ""Path to SARIF log file containing the results of the validation"",
++            Default = ""sarif.log"")]
++        public string LogFilePath { get; set; }
+     }
+ }","I would prefer that this tool follow the driver framework conventions, which use OutputFilePath as an argument, take a look at AnalyzeCommandBase. You can propose changes to that if you'd like, but binskim, sqlskim, this tool should all conform (in the interests of building an eco-system with consistent command-line interface)",I think this should be `sarif.log`
+8691,"@@ -308,6 +308,18 @@ public final class Queue<T> extends AbstractQueue<T, Queue<T>> implements Linear
+         return io.vavr.collection.Collections.fill(n, s, empty(), Queue::of);
+     }
+ 
++    /**
++     * Returns a Queue containing {@code n} times the given {@code element}
++     *
++     * @param <T>     Component type of the Queue
++     * @param n       The number of elements in the Queue
++     * @param element The element
++     * @return An Queue of size {@code n}, where each element is the given {@code element}.
++     */
++    public static <T> Queue<T> fill(int n, T element) {
++        return io.vavr.collection.Collections.fillObject(n, element, empty(), Queue::of);
++    }
++
+     public static Queue<Character> range(char from, char toExclusive) {
+         return ofAll(Iterator.range(from, toExclusive));
+     }","(...), where each element ~are~ **is the** given {@code element}.",Why is this needed?
+8692,"@@ -57,7 +57,7 @@ namespace Examples.AspNetCore
+             switch (exporter)
+             {
+                 case ""jaeger"":
+-                    services.AddOpenTelemetryTracerProvider((builder) => builder
++                    services.AddOpenTelemetryTracing((builder) => builder
+                         .AddAspNetCoreInstrumentation()
+                         .AddHttpClientInstrumentation()
+                         .AddJaegerExporter(jaegerOptions =>",What if `AddOpenTelemetryTracing` is called multiple times?,I'm not sure if this is the right place for this change. I think it should be in a separate PR.
+8693,"@@ -16,9 +16,10 @@ FileBasedWalIterator::FileBasedWalIterator(
+     std::shared_ptr<FileBasedWal> wal,
+     LogID startId,
+     LogID lastId)
+-        : wal_(std::move(wal))
++        : wal_(wal)
+         , currId_(startId) {
+-    if (lastId >= 0) {
++    holder_ = std::make_unique<folly::RWSpinLock::ReadHolder>(wal_->rollbackLock_);
++    if (lastId >= 0 && lastId <= wal_->lastLogId()) {
+         lastId_ = lastId;
+     } else {
+         lastId_ = wal_->lastLogId();","Why is the condition of ""lastId <= wal _-> lastLogId() "" added here?",Why do we need this change?
+8694,"@@ -13,3 +13,9 @@
+ // limitations under the License.
+ 
+ package model
++
++import ""path""
++
++func MakeEnvironmentURL(baseURL, environmentID string) string {
++	return path.Join(baseURL, ""settings"", ""environment"")
++}",`environmentID` is unused in MakeEnvironmentURL,I don't think this is used anywhere.
+8695,"@@ -1700,10 +1700,14 @@ public class LFMainActivity extends SharedMediaActivity {
+         }
+     }
+ 
+-    private void checkNoSearchResults(String result){
+-        textView.setText(getString(R.string.null_search_result) + "" "" + '""' + result + '""' );
+-        textView.setTextColor(getTextColor());
+-        textView.setVisibility(View.VISIBLE);
++    private void checkNoSearchResults(String result,int length){
++        if (length>0) {
++            textView.setText(getString(R.string.null_search_result) + "" "" + '""' + result + '""');
++            textView.setTextColor(getTextColor());
++            textView.setVisibility(View.VISIBLE);
++        }
++        else
++            textView.setVisibility(View.INVISIBLE);
+     }
+ 
+     //region MENU",Just hide the textview,Please add a space after the comma.
+8696,"@@ -54,7 +54,14 @@ type SessionDto struct {
+ 	Config json.RawMessage `json:""config""`
+ }
+ 
++// PaymentVersion represents the different payment versions we have
++type PaymentVersion string
++
++// PaymentVersionV2 represents the new pingpong version
++const PaymentVersionV2 PaymentVersion = ""v2""
++
+ // ConsumerInfo represents the consumer related information
+ type ConsumerInfo struct {
+ 	IssuerID identity.Identity `json:""issuerID""`
++	Supports PaymentVersion    `json:""supports""`
+ }","'Supports'? Very uninformative naming inside protocol. Why not just paymentVersion, or just recognise supported payment version from generic protocol version supported by the client.",I think this should be `PaymentVersionV2`
+8697,"@@ -162,7 +162,11 @@ func (s *DiskSuite) TestExplicitBundleAndVerify() {
+ 	csr, pubKey, err := util.NewCSRTemplate(validSpiffeID)
+ 	require.NoError(err)
+ 
+-	resp, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
++	stream, err := s.p.MintX509CA(ctx, &upstreamauthority.MintX509CARequest{Csr: csr})
++	require.NoError(err)
++	require.NotNil(stream)
++
++	resp, err := stream.Recv()
+ 	require.NoError(err)
+ 	require.NotNil(resp)
+ ",We should add an additional call to Recv() somewhere after here that we assert returns io.EOF.,This should be `require.NoError`
+8698,"@@ -16,10 +16,13 @@
+ 
+ package azkaban.database;
+ 
++import static azkaban.ServiceProvider.SERVICE_PROVIDER;
++
+ import azkaban.metrics.CommonMetrics;
+ import azkaban.utils.Props;
+ import java.io.IOException;
+ import java.sql.Connection;
++import javax.inject.Inject;
+ import org.apache.commons.dbutils.DbUtils;
+ import org.apache.commons.dbutils.QueryRunner;
+ ",What is this used for?,Why is this needed?
+8699,"@@ -7,9 +7,8 @@ package net.sourceforge.pmd.lang.java.ast;
+ 
+ import java.util.List;
+ 
+-public class ASTAnnotationTypeDeclaration extends AbstractJavaAccessTypeNode implements ASTAnyTypeDeclaration {
++public class ASTAnnotationTypeDeclaration extends ASTAnyTypeDeclaration {
+ 
+-    private JavaQualifiedName qualifiedName;
+ 
+     public ASTAnnotationTypeDeclaration(int id) {
+         super(id);",this is a breaking API change. Do we really need to do it in 6.2.0? Can't we just deprecate the methods?,Why did you remove this?
+8700,"@@ -123,6 +123,12 @@ public class DatabaseHelper extends DaoMaster.OpenHelper {
+                     }
+                 }
+                 break;
++            case 10:
++                AllergenDao.dropTable(db, true);
++                AllergenDao.createTable(db, true);
++                AllergenNameDao.dropTable(db, true);
++                AllergenNameDao.createTable(db, true);
++                break;
+         }
+     }
+ ",Is dropping the **Allergen table** necessary? Can't we just add the two new columns to the existing table using a raw query?,Why do we need to drop the table here?
+8701,"@@ -13,11 +13,11 @@ feature ""Subscriber views completed trails"" do
+ 
+     within "".completed-trails"" do
+       expect(page).to have_content(just_finished_trail.name)
+-      expect(page).to have_no_content(incomplete_trail.name)
++      expect(page).not_to have_content(incomplete_trail.name)
+     end
+ 
+     within "".incomplete-trails"" do
+-      expect(page).to have_no_content(just_finished_trail.name)
++      expect(page).not_to have_content(just_finished_trail.name)
+       expect(page).to have_content(incomplete_trail.name)
+     end
+ ",I'm confused why the expectations here would have inverted? Seems unrelated to topic stuff. Can you clarify?,Prefer double-quoted strings unless yo
+8702,"@@ -127,12 +127,13 @@ std::string MetaServiceUtils::schemaEdgesPrefix(GraphSpaceID spaceId) {
+ std::string MetaServiceUtils::schemaEdgeKey(GraphSpaceID spaceId,
+                                             EdgeType edgeType,
+                                             int64_t version) {
++    int64_t storageVer = std::numeric_limits<int64_t>::max() - version;
+     std::string key;
+     key.reserve(128);
+     key.append(kEdgesTable.data(), kEdgesTable.size());
+     key.append(reinterpret_cast<const char*>(&spaceId), sizeof(spaceId));
+     key.append(reinterpret_cast<const char*>(&edgeType), sizeof(edgeType));
+-    key.append(reinterpret_cast<const char*>(&version), sizeof(version));
++    key.append(reinterpret_cast<const char*>(&storageVer), sizeof(storageVer));
+     return key;
+ }
+ ",I am very sorry that I neglected to resolve the conflict and did not fully unit test edge,Why do we need this change?
+8703,"@@ -25,13 +25,14 @@ import org.apache.iceberg.catalog.TableIdentifier;
+ import org.apache.iceberg.exceptions.AlreadyExistsException;
+ import org.apache.iceberg.exceptions.CommitFailedException;
+ import org.apache.iceberg.exceptions.NoSuchTableException;
++import org.apache.iceberg.io.CloseableGroup;
+ import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+ import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
+ import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+ import org.slf4j.Logger;
+ import org.slf4j.LoggerFactory;
+ 
+-public abstract class BaseMetastoreCatalog implements Catalog {
++public abstract class BaseMetastoreCatalog extends CloseableGroup implements Catalog {
+   private static final Logger LOG = LoggerFactory.getLogger(BaseMetastoreCatalog.class);
+ 
+   @Override","I think closeable should be handled by the concrete impl of a catalog and not by the base class, I don't think all catalogs must implement closeable by design. This should be done via composition rather than inheritance. Additionally, I don't know what the effect of this change is on other catalogs so this feels a bit on the risky side.",Why is this needed?
+8704,"@@ -9,11 +9,13 @@ void ConvolutionLayer<Dtype>::compute_output_shape() {
+   const int* kernel_shape_data = this->kernel_shape_.cpu_data();
+   const int* stride_data = this->stride_.cpu_data();
+   const int* pad_data = this->pad_.cpu_data();
++  const int* dilation_data = this->dilation_.cpu_data();
+   this->output_shape_.clear();
+   for (int i = 0; i < this->num_spatial_axes_; ++i) {
+     // i + 1 to skip channel axis
+     const int input_dim = this->input_shape(i + 1);
+-    const int output_dim = (input_dim + 2 * pad_data[i] - kernel_shape_data[i])
++    const int kernel_extent = dilation_data[i] * (kernel_shape_data[i] - 1) + 1;
++    const int output_dim = (input_dim + 2 * pad_data[i] - kernel_extent)
+         / stride_data[i] + 1;
+     this->output_shape_.push_back(output_dim);
+   }",Should this be `const`?,nit: `const int* dilation_data = this->dilation_.cpu_data();`
+8705,"@@ -6,7 +6,7 @@ namespace Benchmarks.Trace
+     {
+         private static void Main(string[] args)
+         {
+-            BenchmarkRunner.Run<SpanBenchmark>();
++            BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+         }
+     }
+ }",Can we also add the Exporters here by using `DefaultConfig.AddExporter(...)`? At least the Datadog exporter that can't be configured from the command line...,Why is this change needed?
+8706,"@@ -77,7 +77,7 @@ int main(int argc, char *argv[]) {
+ 
+     // When using checkpoint states, skip training as those could be the result
+     // of checkpointing by steps.
+-    if (!opts->has_string(""ckpt_dir"")){
++    if (!opts->has_string(""no_model1_train"")){
+       model_1->train( pb_model.num_epochs() );
+     }
+     // Evaluate model 1 unless it is set to skip","@JaeseungYeom I believe you had set this in a previous commit to, by default, not train model1 when loading from ckpt. Would it work for you to have this as a command line option `--no_model1_train` instead of the default behavior?",I'm not sure if this is the right way to do it. I think it sh
+8707,"@@ -86,6 +86,11 @@ namespace Microsoft.Rest.Generator.Ruby.TemplateModels
+                 return ""Array<Integer>"";
+             }
+ 
++            if (type == PrimaryType.TimeSpan)
++            {
++                return ""Duration""; //TODO: Is this a real Ruby type...?
++            }
++
+             if (compositeType != null)
+             {
+                 return compositeType.Name;","@devigned, please clarify",Is this a real Ruby type?
+8708,"@@ -19,6 +19,7 @@ import (
+ 	""reflect""
+ 	""testing""
+ 	""time""
++	""github.com/jmcvetta/randutil""
+ )
+ 
+ func TestConcurrentCommand_UnmarshalJSON(t *testing.T) {",File is not `gofmt`-ed with `-s` (from `gofmt`),Please remove this empty line.
+8709,"@@ -127,7 +127,7 @@ def GenerateConfig(context):
+                 'items': [{
+                     'key': 'startup-script',
+                     'value': """"""#!/bin/bash
+-sudo apt-get install -y unzip
++sudo apt-get install -y unzip git
+ sudo apt-get install -y libmysqlclient-dev
+ sudo apt-get install -y python-pip python-dev
+ ",Should we break this up into a separate line?,why is this needed?
+8710,"@@ -57,6 +57,7 @@ var _ = Describe(""conformance tests"", func() {
+ 	Measure(specName, func(b Benchmarker) {
+ 
+ 		name := fmt.Sprintf(""cluster-%s"", util.RandomString(6))
++		setEnvVar(""USE_CI_ARTIFACTS"", ""true"", false)
+ 		kubernetesVersion := e2eConfig.GetVariable(KubernetesVersion)
+ 		flavor := clusterctl.DefaultFlavor
+ 		if useCIArtifacts {","Why the override on the env variable, wouldn't we want to use the value set from Prow?",Why is this needed?
+8711,"@@ -0,0 +1,13 @@
++widget :projected_monthly_revenue do
++  key ""74b333b94cd772ee15be863e646f8ca1e535f1c6""
++  type ""number_and_secondary""
++  data do
++    {
++      value:
++        IndividualPlan.prime_basic.projected_monthly_revenue +
++        IndividualPlan.prime_workshops.projected_monthly_revenue +
++        IndividualPlan.prime_with_mentoring.projected_monthly_revenue +
++        TeamPlan.instance.projected_monthly_revenue
++    }
++  end
++end","I don't see anything here that excludes people on a Team plan from from the revenue report. I see that TeamPlans are counted below, but the individual subscribers on the plan would still be included.",Layout/IndentHash: Indent the 
+8712,"@@ -1078,11 +1078,8 @@ public final class Vector<T> implements IndexedSeq<T>, Serializable {
+ 
+     @Override
+     public Vector<T> subSequence(int beginIndex, int endIndex) {
+-        if ((beginIndex >= 0) && (beginIndex <= endIndex) && (endIndex <= length())) {
+-            return slice(beginIndex, endIndex);
+-        } else {
+-            throw new IndexOutOfBoundsException(""subSequence("" + beginIndex + "", "" + endIndex + "") on Vector of size "" + length());
+-        }
++        Collections.subSequenceRangeCheck(beginIndex, endIndex, length());
++        return slice(beginIndex, endIndex);
+     }
+ 
+     @Override",I know that we do not pull the last bit of performance out of the JVM but it is more robust and removes redundant code.,Shouldn't this be `beginIndex <= endIndex && endIndex <= length()`?
+8713,"@@ -130,6 +130,11 @@ public abstract class ScheduledReporter implements Closeable, Reporter {
+                                 ScheduledExecutorService executor,
+                                 boolean shutdownExecutorOnStop,
+                                 Set<MetricAttribute> disabledMetricAttributes) {
++
++        if (registry == null) {
++            throw new IllegalArgumentException(""MetricRegistry must not be null !!!"");
++        }
++
+         this.registry = registry;
+         this.filter = filter;
+         this.executor = executor == null ? createDefaultExecutor(name) : executor;","I'd make this a `throw new NullPointerException(""registry == null"");` instead",nit: `!= null` is redundant
+8714,"@@ -163,10 +163,12 @@ type Config struct {
+ 	FailsafeInboundHostPorts  []ProtoPort `config:""port-list;tcp:22,udp:68;die-on-fail""`
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;tcp:2379,tcp:2380,tcp:4001,tcp:7001,udp:53,udp:67;die-on-fail""`
+ 
+-	UsageReportingEnabled bool   `config:""bool;true""`
+-	ClusterGUID           string `config:""string;baddecaf""`
+-	ClusterType           string `config:""string;""`
+-	CalicoVersion         string `config:""string;""`
++	UsageReportingEnabled          bool          `config:""bool;true""`
++	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`
++	UsageReportingIntervalSecs     time.Duration `config:""seconds;86400""`
++	ClusterGUID                    string        `config:""string;baddecaf""`
++	ClusterType                    string        `config:""string;""`
++	CalicoVersion                  string        `config:""string;""`
+ 
+ 	DebugMemoryProfilePath          string        `config:""file;;""`
+ 	DebugDisableLogDropping         bool          `config:""bool;false""`",Does adding things here require us also to extend the FelixConfiguration resource in libcalico-go?,"I think this should be `time.Duration`, not `time.Duration`."
+8715,"@@ -31,7 +31,11 @@ import (
+ 	""github.com/pkg/errors""
+ )
+ 
+-const currentCNISpec = ""0.3.1""
++const (
++	currentCNISpec = ""0.3.1""
++	currentCNIVersion = ""2018.08.0""
++	CNIGitHash = ""a134a973585b560439ed25ec3857e4789bfeb89f""
++)
+ 
+ // CNIClient defines the method of setting/cleaning up container namespace
+ type CNIClient interface {",does this need to be public?,Why do we need this hash?
+8716,"@@ -15,6 +15,7 @@
+ from . import encode
+ from . import number_types as N
+ 
++FILEIDENTIFIER_LENGTH = 4
+ 
+ class Table(object):
+     """"""Table wraps a byte slice and provides read access to its data.",Please import this from a pre-existing definition.,Is this used anywhere?
+8717,"@@ -0,0 +1,18 @@
++class WebOptions:
++    def load(self, loader):
++        loader.add_option(
++            ""web_open_browser"", bool, True,
++            ""Start a browser.""
++        )
++        loader.add_option(
++            ""web_debug"", bool, False,
++            ""Mitmweb debugging.""
++        )
++        loader.add_option(
++            ""web_port"", int, 8081,
++            ""Mitmweb port.""
++        )
++        loader.add_option(
++            ""web_iface"", str, ""127.0.0.1"",
++            ""Mitmweb interface.""
++        )",File name does not represent class name... if we ever cared for such things?,I think this should be
+8718,"@@ -39,7 +39,7 @@ Rails.application.routes.draw do
+       get :languages
+       get :commits_by_project_chart
+       get :commits_by_language_chart
+-      post :make_spammer
++      post :label_as_spammer
+       get 'edit_privacy'   => 'privacy#edit',   as: :edit_account_privacy
+       put 'update_privacy' => 'privacy#update', as: :account_privacy
+     end","I don't mind the `make_spammer` route name. It seems to more clearly convey that the state of the account will change. The ""label as"" route name seems less definitive, as if one is simply adding something to the account -- a new label -- instead of changing the status of the account.",I think this should be
+8719,"@@ -46,7 +46,8 @@ var loggingCmd = &cobra.Command{
+ 	Long:  `Enable/disable and configure Algorand remote logging`,
+ 	Args:  validateNoPosArgsFn,
+ 	Run: func(cmd *cobra.Command, _ []string) {
+-		cfg, err := logging.EnsureTelemetryConfig(nil, """")
++		dataDir := ensureSingleDataDir()
++		cfg, err := logging.EnsureTelemetryConfig(&dataDir, """")
+ 
+ 		// If error loading config, can't disable / no need to disable
+ 		if err != nil {","This exits if `-d` not specified which isn't exactly what we want, right?",Why do we need this ch
+8720,"@@ -313,3 +313,10 @@ def sizeof_fmt(num, suffix='B'):
+             return ""%3.1f%s%s"" % (num, unit, suffix)
+         num /= 1024.0
+     return ""%.1f%s%s"" % (num, 'Yi', suffix)
++
++
++def escape_like(string, escape_char='*'):
++    """"""Escape the string parameter used in SQL LIKE expressions.""""""
++    return string.replace(escape_char, escape_char * 2) \
++                 .replace('%', escape_char + '%') \
++                 .replace('_', escape_char + '_')",So a `*` becomes `**`? How does this affect the query? If I have `csordas*marton` as filter and I have `csordas*marton` and `csordasFOOBARmarton` as run names in the database I get only the first as result?,"I think this should be `.replace('_', escape_char + '_')`"
+8721,"@@ -191,11 +191,14 @@ InterimResult::buildIndex(const std::string &vidColumn) const {
+         auto name = schema->getFieldName(i);
+         if (vidColumn == name) {
+             VLOG(1) << ""col name: "" << vidColumn << "", col index: "" << i;
+-            if (schema->getFieldType(i).type != SupportedType::VID) {
++            if (schema->getFieldType(i).type != SupportedType::INT &&
++                schema->getFieldType(i).type != SupportedType::VID &&
++                schema->getFieldType(i).type != SupportedType::TIMESTAMP) {
+                 return Status::Error(
+-                        ""Build internal index for input data failed. ""
+-                        ""The specific vid column `%s' is not type of VID, column index: %ul."",
+-                        vidColumn.c_str(), i);
++                    ""Build internal index for input data failed. ""
++                    ""The specific vid column `%s' is not type of VID, INT or TIMESTAMP, ""
++                    ""column index: %u."",
++                    vidColumn.c_str(), i);
+             }
+             vidIndex = i;
+         }","I want to know in which situation you need to traverse from ""Timestamp"" data.....",I think it would be better to use %u instead of %u.
+8722,"@@ -687,7 +687,11 @@ func (ctx *signingCtx) buildBodyDigest() error {
+ 			if !aws.IsReaderSeekable(ctx.Body) {
+ 				return fmt.Errorf(""cannot use unseekable request body %T, for signed request with body"", ctx.Body)
+ 			}
+-			hash = hex.EncodeToString(makeSha256Reader(ctx.Body))
++			hasBytes, err := makeSha256Reader(ctx.Body)
++			if err != nil {
++				return err
++			}
++			hash = hex.EncodeToString(hasBytes)
+ 		}
+ 
+ 		if includeSHA256Header {",nit: hasBytes should be hashBytes,I think we should return the error here.
+8723,"@@ -171,6 +171,15 @@ def perform_analysis(args, skip_handler, context, actions, metadata):
+         config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
+             ReturnValueCollector.checker_analyze)
+ 
++    # Statistics collector checkers must be explicitly disabled
++    # as they trash the output.
++    if ""clangsa"" in analyzers:
++        config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
++            SpecialReturnValueCollector.checker_collect, False)
++
++        config_map[ClangSA.ANALYZER_NAME].set_checker_enabled(
++            ReturnValueCollector.checker_collect, False)
++
+     # Save some metadata information.
+     versions = __get_analyzer_version(context, config_map)
+     metadata['versions'].update(versions)",If I enable the clangsa analyzer with the `--stats` flag the checkers will be disabled even if they were enabled previously. I think we should check here if stats was enabled. `if 'stats_enabled' in args and args.stats_enabled` we should leave them enabled.,I don't think this is the right place to do this. It shou
+8724,"@@ -1041,6 +1041,9 @@ func DoEstimateGas(ctx context.Context, b Backend, args CallArgs, blockNrOrHash
+ 
+ 	// 3. calculate the fee and normalize by the default gas price
+ 	fee := core.CalculateRollupFee(*args.Data, uint64(gasUsed), dataPrice, executionPrice).Uint64() / defaultGasPrice
++	if fee < 21000 {
++		fee = 21000
++	}
+ 	return (hexutil.Uint64)(fee), nil
+ }
+ ",Note that we probably should set the default gasPrice to `0.1 gwei` considering our minimum gas limit has to be 21k. At 21k the minimum fee would end up being `0.000021 ETH` which is just a little too high,Why do we need this?
+8725,"@@ -132,7 +132,9 @@ func validateTrustedOperators(o *Options) error {
+ 		if o.TrustedKeys == nil {
+ 			o.TrustedKeys = make([]string, 0, 4)
+ 		}
+-		o.TrustedKeys = append(o.TrustedKeys, opc.Issuer)
++		if !opc.StrictSigningKeyUsage {
++			o.TrustedKeys = append(o.TrustedKeys, opc.Subject)
++		}
+ 		o.TrustedKeys = append(o.TrustedKeys, opc.SigningKeys...)
+ 	}
+ 	for _, key := range o.TrustedKeys {","So during a config reload, this function is invoked, but prior to that the o.TrustedKeys slice is set to nil, so this code would work. However, I am wondering what happens to s.trustedKeys, I am not sure this is handled at all. (same with the new map you are adding). I am not sure if this is supposed to be supported with a config reload, but just wondering if this is not putting things into a bad state.",I don't think we nee
+8726,"@@ -64,15 +64,12 @@ func SecurityHandler(authenticators map[string]auth.Authenticator, next http.Han
+ 	}
+ 
+ 	return func(w http.ResponseWriter, r *http.Request) {
+-
+ 		tokenHeader := r.Header.Get(""Authorization"")
+ 		tokens := strings.Split(tokenHeader, "" "")
+ 
+ 		if len(tokens) < 2 {
+ 			w.WriteHeader(http.StatusUnauthorized)
+-			json.NewEncoder(w).Encode(&api.ClusterResponse{
+-				Error: fmt.Sprintf(""Access denied, token is malformed""),
+-			})
++			fmt.Fprintf(w, ""Access denied token is empty"")
+ 			return
+ 		}
+ 		token := tokens[1]","I think the logic should be to check for token len of 0 then check for token len of less than 2. The way the logic is now, it is hard to determine if it is empty or malformed.",Why is this being re
+8727,"@@ -267,6 +267,15 @@ void wlr_output_set_subpixel(struct wlr_output *output,
+ 	wlr_output_schedule_done(output);
+ }
+ 
++void wlr_output_set_format(struct wlr_output *output,
++		enum wl_shm_format format) {
++	if (output->format == format) {
++		return;
++	}
++
++	output->format = format;
++}
++
+ void wlr_output_set_description(struct wlr_output *output, const char *desc) {
+ 	if (output->description != NULL && desc != NULL &&
+ 			strcmp(output->description, desc) == 0) {",Nothing would change here even if this `if` statement were removed.,Shouldn't this be `=
+8728,"@@ -38,10 +38,11 @@ assert_pyspark_version()
+ from databricks.koalas.frame import DataFrame
+ from databricks.koalas.indexes import Index, MultiIndex
+ from databricks.koalas.series import Series
+-from databricks.koalas.typedef import Col, pandas_wraps
++from databricks.koalas.typedef import pandas_wraps
++from databricks.koalas.sql import sql
+ 
+ __all__ = ['read_csv', 'read_parquet', 'to_datetime', 'from_pandas',
+-           'get_dummies', 'DataFrame', 'Series', 'Index', 'MultiIndex', 'Col', 'pandas_wraps',
++           'get_dummies', 'DataFrame', 'Series', 'Index', 'MultiIndex', 'pandas_wraps',
+            'sql', 'range', 'concat', 'melt']
+ 
+ ",`sql` module is imported later.,Why did you change this?
+8729,"@@ -69,6 +69,15 @@ class GARPNHead(RPNTestMixin, GuidedAnchorHead):
+                            cfg,
+                            rescale=False):
+         cfg = self.test_cfg if cfg is None else cfg
++
++        # refactor the nms cfg
++        # this is used for avoid breaking change
++        if 'nms' not in cfg:
++            cfg.nms = dict(type='nms', iou_threshold=cfg.nms_thr)
++            cfg.max_per_img = cfg.max_num
++
++        assert cfg.nms.get('type', 'nms') == 'nms', 'GARPNHead only support ' \
++            'naive nms.'
+         mlvl_proposals = []
+         for idx in range(len(cls_scores)):
+             rpn_cls_score = cls_scores[idx]","I think it's strange, whether `assert cfg.nms.type == 'nms'` would be better.",I think it would be bett
+8730,"@@ -33,14 +33,7 @@ import globalize from '../scripts/globalize';
+             });
+ 
+             options.buttons = items;
+-
+-            return dialog.show(options).then(function (result) {
+-                if (result === 'ok') {
+-                    return Promise.resolve();
+-                }
+-
+-                return Promise.reject();
+-            });
++            return dialog.show(options);
+         }
+ 
+         return Promise.resolve();","Doing a quick search, it looks like there are other places that would be handling this promise rejection. How did you confirm this is not needed?",Why was this removed?
+8731,"@@ -68,7 +68,7 @@ func TestCreateContract(t *testing.T) {
+ 	_, err = accountutil.LoadOrCreateAccount(sm, addr.String())
+ 	require.NoError(err)
+ 	hu := config.NewHeightUpgrade(&cfg.Genesis)
+-	stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hash.ZeroHash256)
++	stateDB := NewStateDBAdapter(sm, 0, hu.IsPre(config.Aleutian, 0), hu.IsPost(config.Fairbank, 0), hash.ZeroHash256)
+ 	contract := addr.Bytes()
+ 	var evmContract common.Address
+ 	copy(evmContract[:], contract[:])",let's use greenland in the unit tests as well,Why do we need this chan
+8732,"@@ -48,8 +48,10 @@ def reportPassThrough(treeInterceptor,onlyIfChanged=True):
+ 			nvwave.playWaveFile(sound)
+ 		else:
+ 			if treeInterceptor.passThrough:
++				# Translators: The mode to interact with controls in documents
+ 				ui.message(_(""Focus mode""))
+ 			else:
++				# Translators: The mode that presents text in a flat representation that can be navigated with the cursor keys like in a text document
+ 				ui.message(_(""Browse mode""))
+ 		reportPassThrough.last = treeInterceptor.passThrough
+ reportPassThrough.last = False",Please split this into two lines,"""navigated with"" -> ""navigated with"""
+8733,"@@ -77,6 +77,12 @@ namespace MvvmCross.Platform.Tvos.Views
+ 
+         public virtual bool ShowChildView(UIViewController viewController)
+         {
++            if (SelectedIndex > 5) // when more menu item is currently visible, selected index has value higher than 5
++            {
++                MoreNavigationController.PushViewController(viewController, true);
++                return true;
++            }
++
+             var navigationController = SelectedViewController as UINavigationController;
+ 
+             // if the current selected ViewController is not a NavigationController, then a child cannot be shown",Is there any variable available instead of hardcoding 5?,Shouldn't this be `>=`?
+8734,"@@ -385,9 +385,7 @@ public class LoginActivity extends AccountAuthenticatorActivity
+ 
+ 	@Override
+ 	protected void onActivityResult(int requestCode, int resultCode, Intent data) {
+-		if (requestCode == PasscodeManager.PASSCODE_REQUEST_CODE && resultCode == Activity.RESULT_OK) {
+-			webviewHelper.onNewPasscode();
+-		} else if (requestCode == SPRequestHandler.IDP_REQUEST_CODE) {
++		if (requestCode == SPRequestHandler.IDP_REQUEST_CODE) {
+             spRequestHandler.handleIDPResponse(resultCode, data);
+         } else {
+ 	        super.onActivityResult(requestCode, resultCode, data);",The onNewPasscode method was taking care of creating the user account. Now the user account will already have been created.,Why is this removed?
+8735,"@@ -29,7 +29,8 @@ import (
+ )
+ 
+ const (
+-	MaxChainNameLength = 28
++	MaxChainNameLength       = 28
++	defaultPostWriteInterval = 50 * time.Millisecond
+ )
+ 
+ var (","This is really a minimum, isn't it, so `minPostWriteInterval` perhaps? IIUC it never gets used as a default, because the default IptablesPostWriteCheckInterval is 1s, which is larger than this.",Why is this a constant?
+8736,"@@ -1,11 +1,9 @@
+ <ul class=""bookmarkTools nav nav-pills"">
+-  <li class=""cite"">
+-    <%= link_to t('blacklight.tools.cite'), citation_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), {:id => 'citeLink', :name => 'citation', :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
+-  </li>
+-
+-  <li class=""email"">
+-    <%= link_to t('blacklight.tools.email'), email_catalog_path(:sort=>params[:sort], :per_page=>params[:per_page], :id => @response.documents.map {|doc| doc.id}), :class=>""btn btn-default"", :id => ""emailLink"", :data => {:ajax_modal => ""trigger""} %>
+-  </li>
++  <% BookmarksController.document_actions.each do |action| %>
++    <li class=""#{action}"">
++      <%= link_to t(""blacklight.tools.#{action}""), self.send(""#{action}_bookmarks_path""), {:id => ""#{action}Link"", :name => action, :class => 'btn btn-default', :data => {:ajax_modal => ""trigger""}} %>
++    </li>
++  <% end %>
+   
+   <%= render_marc_tools %>
+ </ul>",I wonder if you can use the controller's context instead of using it explicitly?,"I think this should be `self.send(""#{action}_bookmarks_path"")`"
+8737,"@@ -94,6 +94,7 @@ func (e *Executor) ensureCanaryClean(ctx context.Context) model.StageStatus {
+ 
+ 	resources := strings.Split(value, "","")
+ 	if err := e.removeCanaryResources(ctx, resources); err != nil {
++		e.LogPersister.AppendErrorf(""Unable to remove canary resources: %v"", err)
+ 		return model.StageStatus_STAGE_FAILURE
+ 	}
+ 	return model.StageStatus_STAGE_SUCCESS",Can you add this log for `baseline` too?,I think it would be better to return the error here.
+8738,"@@ -148,6 +148,10 @@ Blockly.Msg.CANNOT_DELETE_VARIABLE_PROCEDURE = 'Can\'t delete the variable ""%1""
+ /// dropdown choice - Delete the currently selected variable.
+ Blockly.Msg.DELETE_VARIABLE = 'Delete the ""%1"" variable';
+ 
++// Broadcast Message creation
++/// dropdown choice - Create a new message.
++Blockly.Msg.NEW_MESSAGE = 'New message...';
++
+ // Colour Blocks.
+ /// url - Information about colour.
+ Blockly.Msg.COLOUR_PICKER_HELPURL = 'https://en.wikipedia.org/wiki/Color';","Let's call this ""NEW_BROADCAST_MESSAGE"". Msg.NEW_MESSAGE will be confusing down the line.",I'm not sure if this is the best way to do this. I'm not sure 
+8739,"@@ -128,11 +128,17 @@ type Container struct {
+ 	// is handled properly so that the state storage continues to work.
+ 	KnownStatusUnsafe ContainerStatus `json:""KnownStatus""`
+ 
++	// TransitionDependenciesMap is a map of the dependent container status to other
++	// dependencies that must be satisfied in order for this container to transition.
++	TransitionDependenciesMap map[ContainerStatus]TransitionDependencySet
++
+ 	// TransitionDependencySet is a set of dependencies that must be satisfied
+ 	// in order for this container to transition.  Each transition dependency
+ 	// specifies a resource upon which the transition is dependent, a status
+ 	// that depends on the resource, and the state of the dependency that
+ 	// satisfies.
++	// Deprecated: Use TransitionDependenciesMap instead. TransitionDependencySet is
++	// retained for compatibility with old state files.
+ 	TransitionDependencySet TransitionDependencySet `json:""TransitionDependencySet""`
+ 
+ 	// SteadyStateDependencies is a list of containers that must be in ""steady state"" before","A better way to do this (in your future PR) would be to: 1. get rid of `TransitionDependencySet` altogether 2. tag `TransitionDependenciesMap` as `""TransitionDependencySet""` in JSON 3. update the JSON marshaler to deal with `""TransitionDependencySet""` tag. If it's a map, no big deal. Else, construct the `TransitionDependenciesMap` map. Doing that would mean that we don't need to have duplicate code, names for this.",I'm not sure if we want to deprecate this in the future. If we
+8740,"@@ -81,10 +81,10 @@ def file_list_to_folder(df: pd.DataFrame, limit: int, offset: int) -> dict:
+             axis=1
+         ).to_dict(orient='records')
+         objects = folder[~folder.logical_key.str.contains('/')].to_dict(orient='records')
+-        returned_results = len(prefixes) + len(objects)
+-    except AttributeError as err:
+-        # Pandas will raise an attribute error if the DataFrame has
+-        # no rows with a non-null logical_key. We expect that case if
++
++    except (AttributeError, KeyError) as err:
++        # Pandas will raise an AttributeError or KeyError if the DataFrame
++        # has no rows with a non-null logical_key. We expect that case if
+         # either: (1) the package is empty (has zero package entries)
+         # or, (2) zero package entries match the prefix filter. The
+         # choice to allow this to raise the exception instead of","It's very error-prone to have so large `try` clause with such non-specific exceptions handled. Consider rewriting it with either of these: 1. Check that expected columns are present in `DataFrame` (`{'physical_key', 'logical_key', 'size'}.issubset(df.columns)`). 2. Normalizing output of query by using `COALESCE()` (or normalizing `DataFrame` itself?). Also it looks like a row with package metadata isn't used here, so might make sense to filter out it with `WHERE logical_key IS NOT MISSING`.",I don't think you need the `as err`
+8741,"@@ -116,6 +116,7 @@ var (
+ 		MirrorQueueLength      int
+ 		PullRequestQueueLength int
+ 		PreferredLicenses      []string
++		DisableHttpGit         bool
+ 
+ 		// Repository editor settings
+ 		Editor struct {",Change to `DisableHTTPGit`,struct field DisableHttpGit should 
+8742,"@@ -71,10 +71,9 @@ class UserMailer < ActionMailer::Base
+   end
+ 
+   def feedback_notification(recipient, plan, requestor)
+-    return unless @user.org.present? && recipient.active?
++    return unless recipient.active?
+ 
+     @user = requestor
+-    @org = @user.org
+     @plan = plan
+     @recipient = recipient
+ ",org was not used in the mail content,Why remove this?
+8743,"@@ -128,6 +128,9 @@ export default Service.extend({
+         return this.lazyLoader.loadStyle('dark', 'assets/ghost-dark.css', true).then(() => {
+             $('link[title=dark]').prop('disabled', !nightShift);
+             $('link[title=light]').prop('disabled', nightShift);
++        }).catch((err) => {
++            $('link[title=dark]').prop('disabled', true);
++            $('link[title=light]').prop('disabled', false);
+         });
+     }
+ });","Is this gonna cause a lint issue, because of unused var? Maybe we should log it out?",Shouldn't this be `false`?
+8744,"@@ -321,7 +321,11 @@ module Beaker
+     def hack_etc_hosts hosts, opts
+       etc_hosts = ""127.0.0.1\tlocalhost localhost.localdomain\n""
+       hosts.each do |host|
+-        etc_hosts += ""#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n""
++        if host['hypervisor'] == 'docker'
++          etc_hosts += ""#{host['docker_container'].json[""NetworkSettings""][""IPAddress""]}\t#{host.name}\n""
++        else
++          etc_hosts += ""#{host['ip'].to_s}\t#{host[:vmhostname] || host.name}\n""
++        end
+       end
+       hosts.each do |host|
+         set_etc_hosts(host, etc_hosts)","My understanding is that this will always be set to the actual containers IP, and never to the `DOCKER_HOST` IP if that env_var is set.",I don't think we need the `.to_s` here.
+8745,"@@ -49,11 +49,14 @@ function ResetButton( { children } ) {
+ 	 * the navigate call starting, we will just set a debounce to keep the spinner for 3 seconds.
+ 	 */
+ 	const debouncedSetInProgress = useDebounce( setInProgress, 3000 );
+-	const mediatedSetInProgress = ( bool ) => bool ? setInProgress( true ) : debouncedSetInProgress( false );
++	const mediatedSetInProgress = useCallback(
++		( bool ) => bool ? setInProgress( true ) : debouncedSetInProgress( false ),
++		[ debouncedSetInProgress ]
++	);
+ 
+ 	useEffect( () => {
+ 		mediatedSetInProgress( isDoingReset || isNavigatingToPostResetURL );
+-	}, [ isDoingReset, isNavigatingToPostResetURL ] );
++	}, [ isDoingReset, isNavigatingToPostResetURL, mediatedSetInProgress ] );
+ 
+ 	useEffect( () => {
+ 		const handleCloseModal = ( event ) => {",this dependency to a callback also has to be a callback (eslint now warns us),I don't think we need the `debouncedSet
+8746,"@@ -95,7 +95,7 @@ func (c *CStorPoolController) reconcile(key string) error {
+ 	return c.updateStatus(csp)
+ }
+ 
+-func (c *CStorPoolController) destroy(csp *apis.NewTestCStorPool) error {
++func (c *CStorPoolController) destroy(csp *apis.CStorPoolInstance) error {
+ 	var phase apis.CStorPoolPhase
+ 
+ 	// DeletePool is to delete cstor zpool.",directory name as well needs change..,Why do we need this change?
+8747,"@@ -348,7 +348,8 @@ class PluginManager
+     public function findByIdentifier($identifier)
+     {
+         if (!isset($this->plugins[$identifier])) {
+-            $identifier = $this->normalizeIdentifier($identifier);
++            $code = $this->getIdentifier($identifier);
++            $identifier = $this->normalizeIdentifier($code);
+         }
+ 
+         if (!isset($this->plugins[$identifier])) {",Why is the getIdentifier() call required here?,Why do we need this change?
+8748,"@@ -92,7 +92,11 @@ std::string MakeCamel(const std::string &in, bool first) {
+ }
+ 
+ void Parser::Message(const std::string &msg) {
++#ifndef FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
+   error_ = file_being_parsed_.length() ? AbsolutePath(file_being_parsed_) : """";
++#else // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
++  error_ = file_being_parsed_.length() ? file_being_parsed_ : """";
++#endif // FLATBUFFERS_PLATFORM_NO_FILE_SUPPORT
+   // clang-format off
+   #ifdef _WIN32
+     error_ += ""("" + NumToString(line_) + "")"";  // MSVC alike",Looks more appropriate to stick this in `AbsolutePath`.. actually that already has `FLATBUFFERS_NO_ABSOLUTE_PATH_RESOLUTION`,Why not just `error_ = file_being_parsed_`?
+8749,"@@ -1,4 +1,8 @@
+-const html = require('yo-yo')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl
+ 
+ module.exports = (props) => {
+   const input = html`",this might interfere when we have multiple dashboards. maybe ActionBrowseTagline needs to be a Component so we can store the reference to the element on it.,Why do we need this?
+8750,"@@ -376,8 +376,15 @@ func (b *BlockServerRemote) Get(ctx context.Context, tlfID tlf.ID, id kbfsblock.
+ 	context kbfsblock.Context) (
+ 	buf []byte, serverHalf kbfscrypto.BlockCryptKeyServerHalf, err error) {
+ 	ctx = rpc.WithFireNow(ctx)
++	var res keybase1.GetBlockRes
+ 	b.log.LazyTrace(ctx, ""BServer: Get %s"", id)
++
++	// Once the block has been retrieved, cache it.
+ 	defer func() {
++		// But don't cache it if it's archived data.
++		if res.Status == keybase1.BlockStatus_ARCHIVED {
++			return
++		}
+ 		b.log.LazyTrace(ctx, ""BServer: Get %s done (err=%v)"", id, err)
+ 		if err != nil {
+ 			b.deferLog.CWarningf(",Should this be inside the `else` below and right after `CDebugf` so that we still get the logs?,I don't think this is the right way to do t
+8751,"@@ -540,4 +540,5 @@ var errorCodeMap = map[string]gcerrors.ErrorCode{
+ 	dyn.ErrCodeTransactionCanceledException:             gcerr.FailedPrecondition,
+ 	dyn.ErrCodeTransactionInProgressException:           gcerr.InvalidArgument,
+ 	dyn.ErrCodeIdempotentParameterMismatchException:     gcerr.InvalidArgument,
++	""ValidationException"":                               gcerr.InvalidArgument,
+ }",Weird they don't expose the type for dynamo and this seems a pretty common error.,I don't think we need this.
+8752,"@@ -33,10 +33,11 @@ namespace OpenTelemetry.Trace.Configuration
+         /// Enables OpenTelemetry.
+         /// </summary>
+         /// <param name=""configureOpenTelemetryBuilder"">Function that configures OpenTelemetryBuilder.</param>
++        /// <returns><see cref=""IDisposable""/> to be disposed on application shutdown.</returns>
+         /// <remarks>
+         /// Basic implementation only. Most logic from TracerBuilder will be ported here.
+         /// </remarks>
+-        public static void EnableOpenTelemetry(Action<OpenTelemetryBuilder> configureOpenTelemetryBuilder)
++        public static IDisposable EnableOpenTelemetry(Action<OpenTelemetryBuilder> configureOpenTelemetryBuilder)
+         {
+             var openTelemetryBuilder = new OpenTelemetryBuilder();
+             configureOpenTelemetryBuilder(openTelemetryBuilder);",@cijothomas I couldn't make the unit tests work without a way to destroy the ActivityListener we create internally so I return it as an IDisposable here. But we'll also need to also stop any ActivityProcessors/ActivityExporters on application shutdown right?,Why do we need to change this?
+8753,"@@ -592,7 +592,7 @@ class Commands:
+ 
+     @command('wp')
+     async def payto(self, destination, amount, fee=None, feerate=None, from_addr=None, from_coins=None, change_addr=None,
+-                    nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, wallet: Abstract_Wallet = None):
++                    nocheck=False, unsigned=False, rbf=None, password=None, locktime=None, addtransaction=True, wallet: Abstract_Wallet = None):
+         """"""Create a transaction. """"""
+         self.nocheck = nocheck
+         tx_fee = satoshis(fee)","The default should be ""False"", as ""True"" would be a significant change in behaviour.",`addtransaction` should be `Tr
+8754,"@@ -161,8 +161,16 @@ class Package(object):
+ 
+         # Serialize DataFrame to chosen format
+         if enumformat is PackageFormat.HDF5:
+-            with pd.HDFStore(storepath, mode='w') as store:
+-                store[self.DF_NAME] = df
++            # HACK: Force the use of old pickle to ensure Python 2/3 compatibility.
++            from pandas.compat import cPickle
++            old_protocol = cPickle.HIGHEST_PROTOCOL
++            try:
++                cPickle.HIGHEST_PROTOCOL = 2
++                with pd.HDFStore(storepath, mode='w') as store:
++                    store[self.DF_NAME] = df
++            finally:
++                cPickle.HIGHEST_PROTOCOL = old_protocol
++
+         elif enumformat is PackageFormat.PARQUET:
+             # switch parquet lib
+             parqlib = self.get_parquet_lib()","since goal is to restore old_protocol, shouldn't we get it from pandas if possible? e.g. this will break if their source code changes.",I don't think this is the righ
+8755,"@@ -299,7 +299,7 @@ class ErrorBaseline
+                     ""\n"" .
+                     '  php-version=""' .
+                     ""\n    "" .
+-                    implode(""\n    "", explode('&#10;&#9;', $matches[2])) .
++                    str_replace('&#10;&#9;', ""\n    "", $matches[2]).
+                     ""\n"" .
+                     '  ""' .
+                     ""\n"" .",This should consume less resources because str_replace don't need to assign arrays with all the values,"Why not `implode('&#10;&#9;', "
+8756,"@@ -240,6 +240,10 @@ static bool check_arg_types(pass_opt_t* opt, ast_t* params, ast_t* positional,
+     {
+       errorframe_t frame = NULL;
+       ast_error_frame(&frame, arg, ""argument not a subtype of parameter"");
++      ast_error_frame(&frame, arg, ""argument type is %s"",
++                      ast_print_type(a_type));
++      ast_error_frame(&frame, arg, ""parameter type is %s"",
++                      ast_print_type(p_type));
+       errorframe_append(&frame, &info);
+ 
+       if (ast_childcount(arg) > 1)","It would be better to pass `param` as the second argument here, so that the parameter declaration is printed alongside the type. Same thing for the changes in `ffi.c` and `lambda.c`.",Shouldn't this be `ast_print_type(p_type)`?
+8757,"@@ -27,6 +27,7 @@ import org.joda.time.DateTime;
+ 
+ import azkaban.utils.JSONUtils;
+ 
++
+ public class Trigger {
+ 
+   private static Logger logger = Logger.getLogger(Trigger.class);","Do we need to set the members to final like submitTime, submitUser ...? They are only used by getter method.",import org.slf4j.Logger;
+8758,"@@ -13,7 +13,7 @@ class MediaLibraryItem extends SystemMediaLibraryItem
+ {
+     public function __construct()
+     {
+-        traceLog('Class Cms\Classes\MediaLibraryItem has been deprecated, use System\Classes\MediaLibraryItem instead.');
++        traceLog('Class ' . __CLASS__ . ' has been deprecated, use ' . SystemMediaLibraryItem::class . ' instead.');
+         parent::__construct(...func_get_args());
+     }
+ }","That makes this error message incorrect; if someone has extended Cms\Classes\MediaLibraryItem, then this error message will read ""Class My\Classes\CustomMediaLibraryItem has been deprecated"".",Please use `__CLASS__` instead.
+8759,"@@ -97,6 +97,6 @@ class Factory implements \Zend\ServiceManager\FactoryInterface
+         $config = $sm->get('VuFind\Config')->get('config');
+ 
+         // Create service:
+-        return new \VuFind\Mailer\Mailer($this->getTransport($config));
++        return new \VuFind\Mailer\Mailer($this->getTransport($config), $config);
+     }
+ }","Is it worth injecting the whole configuration object for just one setting? Would it be more generic to pass an $options array with the override_from in it? I'm not completely opposed to passing $config, but since we've avoided it so far, it seems like it would be cleaner to maintain that separation. Simply adding a getOptions method to the factory would make this a lot more readable.",Shouldn't this be `$this->getConfig()`?
+8760,"@@ -44,3 +44,14 @@ const (
+ 	SDA_PIN = 26
+ 	SCL_PIN = 27
+ )
++
++// SPI pins
++const (
++	SPI0_SCK_PIN  = 25
++	SPI0_MOSI_PIN = 23
++	SPI0_MISO_PIN = 24
++
++	SPI1_SCK_PIN  = 2
++	SPI1_MOSI_PIN = 3
++	SPI1_MISO_PIN = 4
++)","Just curious: where do these pin numbers come from? I see you took the SPI0 pin numbers from the Arduino board layout which is good, but I can't find such a relation for `SPI1`.",I don't think this is used anywhere.
+8761,"@@ -450,10 +450,14 @@ public final class MethodTypeResolution {
+         Class<?> contextClass = context.getType();
+ 
+         // search the class
+-        for (Method method : contextClass.getDeclaredMethods()) {
+-            if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) {
+-                result.add(getTypeDefOfMethod(context, method, typeArguments));
++        try {
++            for (Method method : contextClass.getDeclaredMethods()) {
++                if (isMethodApplicable(method, methodName, argArity, accessingClass, typeArguments)) {
++                    result.add(getTypeDefOfMethod(context, method, typeArguments));
++                }
+             }
++        } catch (final LinkageError ignored) {
++            // TODO : This is an incomplete classpath, report the missing class
+         }
+ 
+         // search it's supertype","Isn't that already too late? I'd expect, that the LinkageError occurs the first time, we have the class instance (the classloader tried to load the class) - or do we get a partially linked class back, and we get the exception when retrieving the methods?",I don't think this is the right plac
+8762,"@@ -31,7 +31,7 @@ import (
+ const (
+ 	supportedVersion  = 0
+ 	maxVersion        = 254
+-	traceparentHeader = ""traceparent""
++	TraceparentHeader = ""Traceparent""
+ )
+ 
+ type httpTraceContextPropagator struct{}",nit:s/Traceparent/traceparent/ - As per the spec header name is all lowercase.,// TraceparentHeader is the name of 
+8763,"@@ -484,3 +484,16 @@ type ErrDockerfileNotFound struct {
+ func (e *ErrDockerfileNotFound) Error() string {
+ 	return fmt.Sprintf(""no Dockerfiles found within %s or a sub-directory level below"", e.dir)
+ }
++
++// RelPath returns the path relative to the current working directory.
++func RelPath(fullPath string) (string, error) {
++	wkdir, err := os.Getwd()
++	if err != nil {
++		return """", fmt.Errorf(""get working directory: %w"", err)
++	}
++	path, err := filepath.Rel(wkdir, fullPath)
++	if err != nil {
++		return """", fmt.Errorf(""get relative path of file: %w"", err)
++	}
++	return path, nil
++}",We need to have unit tests for it since it is now a public function. Also I'm not a fan for making this movement since `relPath` doesn't consume any info in this pkg.,I think this should be `filepath.Rel
+8764,"@@ -5,16 +5,11 @@
+  */
+ package edu.harvard.iq.dataverse.datasetutility;
+ 
+-import edu.harvard.iq.dataverse.DataFile;
++import edu.harvard.iq.dataverse.*;
+ import edu.harvard.iq.dataverse.DataFile.ChecksumType;
+-import edu.harvard.iq.dataverse.DataFileServiceBean;
+-import edu.harvard.iq.dataverse.Dataset;
+-import edu.harvard.iq.dataverse.DatasetServiceBean;
+-import edu.harvard.iq.dataverse.DatasetVersion;
+-import edu.harvard.iq.dataverse.EjbDataverseEngine;
+-import edu.harvard.iq.dataverse.FileMetadata;
+-import edu.harvard.iq.dataverse.PermissionServiceBean;
++import edu.harvard.iq.dataverse.api.Files;
+ import edu.harvard.iq.dataverse.api.Util;
++import edu.harvard.iq.dataverse.authorization.users.AuthenticatedUser;
+ import edu.harvard.iq.dataverse.authorization.users.User;
+ import edu.harvard.iq.dataverse.engine.command.Command;
+ import edu.harvard.iq.dataverse.engine.command.DataverseRequest;","We generally avoid wildcard imports. If you feel like changing it back, great. Otherwise, no big deal.",please don't use star imports
+8765,"@@ -51,7 +51,7 @@
+ // 	dispatcher := yarpc.NewDispatcher(yarpc.Config{
+ // 		Name: ""myservice"",
+ // 		Outbounds: yarpc.OUtbounds{
+-// 			{Unary: myserviceOutbound},
++// 			""outboundservice"": {Unary: myserviceOutbound},
+ // 		},
+ // 	})
+ //",We also have a typo on the line above! OUt or Out?,Why is this change needed?
+8766,"@@ -7,5 +7,7 @@
+ <%= @step.action_name %>
+ <%= generate_approve_url(@step) %>
+ 
+-<%= t(""mailer.step_mailer.proposal_notification.cta"") %>
+-<%= proposal_url(@proposal, anchor: ""comments"") %>
++<%= t(""mailer.view_request_cta"") %>
++<%= proposal_url(@proposal) %>
++
++<%= t(""mailer.footer"", feedback_url: feedback_url) %>",OH! These are text.... (Ignore above),I think this should be `view_
+8767,"@@ -98,7 +98,6 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+   private List<Expression> filterExpressions = null;
+   private Filter[] pushedFilters = NO_FILTERS;
+   private final boolean localityPreferred;
+-  private final int batchSize;
+   private final boolean readTimestampWithoutZone;
+ 
+   // lazy variables",How was this set before? Was it just ignored?,Why is this removed?
+8768,"@@ -0,0 +1,12 @@
++class CreditCardsController < ApplicationController
++  def update
++    customer = Stripe::Customer.retrieve(current_user.stripe_customer_id)
++    customer.card = params['stripe_token']
++    begin
++      customer.save
++      redirect_to my_account_path, notice: I18n.t('subscriptions.flashes.update.success')
++    rescue Stripe::CardError => error
++      redirect_to my_account_path, notice: error.message
++    end
++  end
++end",Should we `save!` here?,I don't think you need the `retrieve` here.
+8769,"@@ -284,7 +284,7 @@ void TServerSocket::listen() {
+   hints.ai_family = PF_UNSPEC;
+   hints.ai_socktype = SOCK_STREAM;
+   hints.ai_flags = AI_PASSIVE | AI_ADDRCONFIG;
+-  sprintf(port, ""%d"", port_);
++  snprintf(port, sizeof(""65535""), ""%d"", port_);
+ 
+   // If address is not specified use wildcard address (NULL)
+   TGetAddrInfoWrapper info(address_.empty() ? NULL : &address_[0], port, &hints);",sizeof(port) seems ever-so-slightly clearer.,Why is this change needed?
+8770,"@@ -116,6 +116,12 @@ type Rule struct {
+ 	// conjunction with NetworkPolicySpec/ClusterNetworkPolicySpec.AppliedTo.
+ 	// +optional
+ 	AppliedTo []NetworkPolicyPeer `json:""appliedTo,omitempty""`
++	// SourceGroups is a list of ClusterGroup names which must be set as the
++	// source for this rule.
++	SourceGroups []string `json:""sourceGroups,omitempty""`
++	// DestinationGroups is a list of ClusterGroup names which must be set as the
++	// destination for this rule.
++	DestinationGroups []string `json:""destinationGroups,omitempty""`
+ }
+ 
+ // NetworkPolicyPeer describes the grouping selector of workloads.",Not sure if this has been discussed. I wonder why SourceGroups and DestinationGroups are not in From and To NetworkPolicyPeer as NetworkPolicyPeer already describes the source/destination of the traffic.,nit: `// +optional`
+8771,"@@ -151,6 +151,19 @@ class Completer(QObject):
+             except KeyError:
+                 # No completion model for this section/option.
+                 model = None
++        elif completion == usertypes.Completion.keybinding:
++            # look for --mode to provide mode-specific binding completions
++            # since flags are ignored by most completers, we need to re-parse
++            parts, cursor_part = self._filter_cmdline_parts(self.split(),
++                                                            cursor_part,
++                                                            ignore_flags=False)
++            if parts[cursor_part - 1].startswith(""--mode=""):
++                mode = parts[cursor_part - 1][7:]  # strip --mode=
++                key = parts[cursor_part]
++            else:
++                mode = 'normal'
++                key = parts[cursor_part - 1]
++            model = instances.get(completion)[mode][key]
+         else:
+             model = instances.get(completion)
+ ",This doesn't account for `:bind --mode caret ...` (i.e. `--mode caret` instead of `--mode=caret`; both work). Do you see an easy way to make that work?,I'm not sure if this is the best way to do 
+8772,"@@ -41,7 +41,8 @@ var (
+ 	errorPriority = map[reflect.Type]int{
+ 		reflect.TypeOf(&p.ShardOwnershipLostError{}):             0,
+ 		reflect.TypeOf(&p.CurrentWorkflowConditionFailedError{}): 1,
+-		reflect.TypeOf(&p.ConditionFailedError{}):                2,
++		reflect.TypeOf(&p.WorkflowConditionFailedError{}):        2,
++		reflect.TypeOf(&p.ConditionFailedError{}):                3,
+ 	}
+ 
+ 	errorDefaultPriority = math.MaxInt64",Is this map used for durable state anywhere? If so we probably want to keep ConditionFailedError as 2,Why do we need to change this?
+8773,"@@ -25,6 +25,7 @@ type roundTripperOpts struct {
+ }
+ 
+ var dialAddr = quic.DialAddr
++var methodHEAD = ""HEAD""
+ 
+ // client is a HTTP2 client doing QUIC requests
+ type client struct {",You can use `http.MethodHead` here.,// methodHEAD is the HTTP meth
+8774,"@@ -0,0 +1,5 @@
++package org.openqa.selenium.grid.session.remote;
++
++public class SessionTest {
++
++}",And another empty test. Please remove until there's content.,Missing license header.
+8775,"@@ -2,9 +2,9 @@ define([""localassetmanager""], function(localassetmanager) {
+     ""use strict"";
+ 
+     function processDownloadStatus(apiClient, serverInfo, options) {
+-        return console.log(""[mediasync] Begin processDownloadStatus""), localassetmanager.resyncTransfers().then(function() {
++        return console.debug(""mediasync: begin processDownloadStatus""), localassetmanager.resyncTransfers().then(function() {
+             return localassetmanager.getServerItems(serverInfo.Id).then(function(items) {
+-                console.log(""[mediasync] Begin processDownloadStatus getServerItems completed"");
++                console.debug(""mediasync: begin processDownloadStatus getServerItems completed"");
+                 var p = Promise.resolve(),
+                     cnt = 0;
+                 return items.filter(function(item) {","You really didn't need to do any of these, we need to remove the API client from source eventually anyway.",I don't think this should be a
+8776,"@@ -58,6 +58,9 @@ import org.tikv.kvproto.Pdpb.TsoResponse;
+ 
+ public class PDClient extends AbstractGRPCClient<PDBlockingStub, PDStub>
+     implements ReadOnlyPDClient {
++
++  private TiSession session;
++
+   private RequestHeader header;
+   private TsoRequest tsoReq;
+   private volatile LeaderWrapper leaderWrapper;",seems pretty strange here because TiSession contains PDClient.,Why do we need this?
+8777,"@@ -73,4 +73,11 @@ class NotesControllerTest < ActionDispatch::IntegrationTest
+     assert_response :success
+     assert_select ""table.note_list tr"", :count => 11
+   end
++
++  def test_empty_page
++    user = create(:user)
++    get user_notes_path(:display_name => user.display_name)
++    assert_response :success
++    assert_select ""h4"", :html => ""No notes""
++  end
+ end",I created a test method for this scenario. Would you normally split it out like that or bundle this into one of the existing test methods? I'm more accustomed to creating lots of separate `it` blocks in nested `context` blocks in rspec,Use the new Ruby 1.9
+8778,"@@ -76,6 +76,8 @@ public abstract class NewSessionQueuer implements HasReadyState, Routable {
+         .with(requiresSecret),
+       get(""/se/grid/newsessionqueuer/queue/size"")
+         .to(() -> new GetNewSessionQueueSize(tracer, this)),
++      get(""/se/grid/newsessionqueue"")
++        .to(() -> new GetSessionQueue(tracer, this)),
+       delete(""/se/grid/newsessionqueuer/queue"")
+         .to(() -> new ClearSessionQueue(tracer, this))
+         .with(requiresSecret));",should it be `newsessionqueue` or `newsessionqueuer`? In case we'd like to be consistent,Why do we need this?
+8779,"@@ -5463,6 +5463,13 @@ public class IndexWriter implements Closeable, TwoPhaseCommit, Accountable,
+     throw new IllegalArgumentException(""number of documents in the index cannot exceed "" + actualMaxDocs + "" (current document count is "" + pendingNumDocs.get() + ""; added numDocs is "" + addedNumDocs + "")"");
+   }
+ 
++  /**
++   * Returns the number of documents in the index including documents are being added (i.e., reserved).
++   */
++  public long getPendingNumDocs() {
++    return pendingNumDocs.get();
++  }
++
+   /** Returns the highest <a href=""#sequence_number"">sequence number</a> across
+    *  all completed operations, or 0 if no operations have finished yet.  Still
+    *  in-flight operations (in other threads) are not counted until they finish.",Maybe add `@lucene.experimental`? We are exposing (slightly) internal details about `IndexWriter` so maybe we need to reserve the right to change this API in the future ...,I don't think we nee
+8780,"@@ -676,7 +676,10 @@ module Beaker
+         def sleep_until_puppetdb_started(host, nonssl_port = nil, ssl_port = nil)
+           nonssl_port = options[:puppetdb_port_nonssl] if nonssl_port.nil?
+           ssl_port = options[:puppetdb_port_ssl] if ssl_port.nil?
+-          curl_with_retries(""start puppetdb"", host, ""http://localhost:#{nonssl_port}"", 0, 120)
++          endpoint = 'status/v1/services/puppetdb-status'
++          retry_on(host,
++                   ""curl -m 1 http://localhost:#{nonssl_port}/#{endpoint} | grep '\""state\"":\""running\""'"",
++                   {:max_retries => 120})
+           curl_with_retries(""start puppetdb (ssl)"",
+                             host, ""https://#{host.node_name}:#{ssl_port}"", [35, 60])
+         end","@johnduarte I know this isn't part of your code change, but it seems to me that this `curl_with_retries` is not necessary. If the `retry_on` host command is successful, isn't puppetdb ostensibly listening to the ssl port as well? What do you think about removing that `curl_with_retries` after the `retry_on`?",I think this should be `curl -m 1 http://localhost:#{nonssl_port}/#{endpoint}`
+8781,"@@ -17,13 +17,15 @@ package labelindex
+ import (
+ 	log ""github.com/Sirupsen/logrus""
+ 
++	""github.com/projectcalico/felix/set""
+ 	""github.com/projectcalico/libcalico-go/lib/selector""
++	""github.com/projectcalico/libcalico-go/lib/selector/parser""
+ )
+ 
+ type Index interface {
+ 	UpdateSelector(id interface{}, sel selector.Selector)
+ 	DeleteSelector(id interface{})
+-	UpdateLabels(id interface{}, labels map[string]string)
++	UpdateLabels(id interface{}, labels parser.Labels)
+ 	DeleteLabels(id interface{})
+ }
+ ","Does an empty struct really take less storage than a bool? I guess it must be, or else you wouldn't have changed this, but I'm curious about the detail.",Why do we need this change?
+8782,"@@ -259,6 +259,12 @@ class EditableTextWithoutAutoSelectDetection(EditableText):
+ 	This should be used when an object does not notify of selection changes.
+ 	""""""
+ 
++	def waitForAndSpeakSelectionChange(self, oldTextInfo):
++		api.processPendingEvents(processEventQueue=False)
++		newInfo=self.makeTextInfo(textInfos.POSITION_SELECTION)
++		speech.speakSelectionChange(oldTextInfo,newInfo)
++		braille.handler.handleCaretMove(self)
++
+ 	def script_caret_changeSelection(self,gesture):
+ 		try:
+ 			oldInfo=self.makeTextInfo(textInfos.POSITION_SELECTION)","nit: This should perhaps be called `waitForAndReportSelectionChange`, as it affects braille as well, not just speech.",missing space after comma
+8783,"@@ -127,10 +127,14 @@ class ProxyListenerSNS(ProxyListener):
+ 
+             elif req_action == 'CreateTopic':
+                 topic_arn = aws_stack.sns_topic_arn(req_data['Name'][0])
+-                self._extract_tags(topic_arn, req_data)
++                tag_error_response = self._extract_tags(topic_arn, req_data, True)
++                # in case if there is an error it returns an error , other wise it will continue as expected.
++                if not tag_error_response:
++                    return make_error(code=400, code_string='InvalidParameter',
++                                  message='Topic already exists with different tags')
+ 
+             elif req_action == 'TagResource':
+-                self._extract_tags(topic_arn, req_data)
++                self._extract_tags(topic_arn, req_data, False)
+                 return make_response(req_action)
+ 
+             elif req_action == 'UntagResource':","nit: I suggest that we rename `tag_error_response` to `tag_resource_success`, as later in line 132 we're returning an error if this value is *not* truthy.",I think it would be better to return an error if there is an error.
+8784,"@@ -0,0 +1,15 @@
++<?php
++
++declare(strict_types=1);
++
++namespace Shopsys\ShopBundle\Controller\Styleguide;
++
++use Shopsys\ShopBundle\Controller\Front\FrontBaseController;
++
++class StyleguideController extends FrontBaseController
++{
++    public function styleguideAction()
++    {
++        return $this->render('@ShopsysShop/Styleguide/styleguide.html.twig');
++    }
++}",I am missing return typehint,Missing license header
+8785,"@@ -0,0 +1,8 @@
++_base_ = [
++    'retinanet_pvt-t_fpn_1x_coco.py',
++]
++model = dict(
++    backbone=dict(
++        num_layers=[3, 4, 6, 3],
++        init_cfg=dict(checkpoint='https://github.com/whai362/PVT/'
++                      'releases/download/v2/pvt_small.pth')))",_base_ = 'retinanet_pvt-t_fpn_1x_coco.py',Why do we need this?
+8786,"@@ -394,11 +394,12 @@ public class OAuthWebviewHelper implements KeyChainAliasCallback {
+     private class SwapJWTForAccessTokenTask extends BaseFinishAuthFlowTask<LoginOptions> {
+ 
+         @Override
+-        protected TokenEndpointResponse performRequest(LoginOptions options) {
++        protected TokenEndpointResponse performRequest(LoginOptions options) throws Exception {
+             try {
+                 return OAuth2.swapJWTForTokens(HttpAccess.DEFAULT, new URI(options.loginUrl), options.jwt);
+             } catch (Exception e) {
+-                Log.w(""OAuth.SwapJWT"", e);
++                onAuthFlowError(""jwt_oauth_error"", e.getLocalizedMessage());
++                callback.finish();
+             }
+             return null;
+         }","We should remove `throws Exception` here, since we're catching it anyway and triggering `onAuthFlowError`.",Shouldn't this be logg
+8787,"@@ -0,0 +1,18 @@
++package ps
++
++import ""gx/ipfs/QmepvmmYNM6q4RaUiwEikQFhgMFHXg2PLhx2E9iaRd3jmS/go-libp2p-pubsub""
++
++// Publisher publishes to pubsub topics
++type Publisher struct {
++	pubsub *pubsub.PubSub
++}
++
++// NewPublisher builds a new publisher
++func NewPublisher(sub *pubsub.PubSub) *Publisher {
++	return &Publisher{pubsub: sub}
++}
++
++// Publish publishes to a pubsub topic
++func (s *Publisher) Publish(topic string, data []byte) error {
++	return s.pubsub.Publish(topic, data)
++}","a super thin wrapper like this makes me think we should consider not having it, instead just defining in the plumbing.api the publisher and subscriber interfaces we expect a ps dependency passed in to support and then to pass calls directly to that thing rather than through this wrapper",Why do we need this?
+8788,"@@ -93,7 +93,7 @@ public class Docker {
+       throw new WebDriverException(""Unable to pull container: "" + name);
+     }
+ 
+-    LOG.info(String.format(""Pull of %s:%s complete"", name, tag));
++    LOG.fine(String.format(""Pull of %s:%s complete"", name, tag));
+ 
+     return findImage(new ImageNamePredicate(name, tag))
+         .orElseThrow(() -> new DockerException(",Waiting for the pull takes a long time. This message informs the user that at least one of the images being pulled is available. Please leave.,Why is this change needed?
+8789,"@@ -67,10 +67,12 @@ setup(
+         ""configargparse>=0.10, <0.11"",
+         ""construct>=2.5.2, <2.6"",
+         ""cryptography>=1.3, <1.5"",
++        ""cssutils>=1.0.1, <1.1"",
+         ""Flask>=0.10.1, <0.12"",
+         ""h2>=2.4.0, <3"",
+         ""html2text>=2016.1.8, <=2016.5.29"",
+         ""hyperframe>=4.0.1, <5"",
++        ""jsbeautifier>=1.6.3""
+         ""lxml>=3.5.0, <=3.6.0"",  # no wheels for 3.6.1 yet.
+         ""Pillow>=3.2, <3.4"",
+         ""passlib>=1.6.5, <1.7"",",We should set a 1.7 upper bound for this as well. :smiley:,I don't think we need this
+8790,"@@ -39,11 +39,14 @@ import Spinner from 'GoogleComponents/spinner';
+ import SettingsOverlay from 'GoogleComponents/settings/settings-overlay';
+ import GenericError from 'GoogleComponents/notifications/generic-error';
+ 
+-const { Component, Fragment } = wp.element;
+-const { __, sprintf } = wp.i18n;
+-const { filter, map } = lodash;
+-const { applyFilters } = wp.hooks;
+-const { withFilters } = wp.components;
++/**
++ * WordPress dependencies
++ */
++import { Component, Fragment } from '@wordpress/element';
++import { __, sprintf } from '@wordpress/i18n';
++import { filter, map } from 'lodash';
++import { applyFilters } from '@wordpress/hooks';
++import { withFilters } from '@wordpress/components';
+ 
+ /**
+  * A single module. Keeps track of its own active state and settings.",Lodash mixed in with WordPress dependencies,I think this should be `im
+8791,"@@ -22,10 +22,10 @@ class StripeEvents
+     if subscription = Subscription.find_by(stripe_id: stripe_subscription.id)
+       subscription
+     else
+-      Airbrake.notify_or_ignore(
++      Honeybadger.notify(
+         error_message: ""No subscription found for #{stripe_subscription.id}"",
+         error_class: ""StripeEvents"",
+-        parameters: @event.to_hash
++        context: @event.to_hash,
+       )
+       nil
+     end",Put a comma after the last parameter of a multiline method call.,Should this be `Honeybadge
+8792,"@@ -0,0 +1,11 @@
++describe ""User can manage their own profile"" do
++  it ""allows editing of name"" do
++    user = create(:user)
++    login_as(user)
++    visit ""/me""
++    fill_in :first_name, with: ""Some""
++    fill_in :last_name, with: ""Body""
++    click_button ""Update profile""
++    expect(page).to have_content(""Welcome, Some Body <#{user.email_address}>"")
++  end
++end",perhaps we should test that users cannot edit the profiles of others?,Prefer single-quoted strings when you don't need string interpolation or special symbols.
+8793,"@@ -43,7 +43,7 @@ class TestMasterSecretLogger(tservers.ServerTestBase):
+ 
+             tls.log_master_secret.close()
+             with open(logfile, ""rb"") as f:
+-                assert f.read().count(b""CLIENT_RANDOM"") >= 2
++                assert f.read().count(b""SERVER_HANDSHAKE_TRAFFIC_SECRET"") >= 2
+ 
+         tls.log_master_secret = _logfun
+ ",Does this mean the content changed with the new pyopenssl version? Is Wireshark already compatible with this new format?,Why did you change this?
+8794,"@@ -618,7 +618,7 @@ func TestCachedBatch(t *testing.T) {
+ }
+ 
+ func TestSTXCachedBatch(t *testing.T) {
+-	ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))})
++	ws := newStateTX(0, db.NewMemKVStore(), []protocol.ActionHandler{account.NewProtocol(config.NewHeightUpgrade(config.Default))}, config.Default.DB)
+ 	testCachedBatch(ws, t, true)
+ }
+ ",line is 147 characters (from `lll`),Error return value of `testCachedBatch` is not checked
+8795,"@@ -65,6 +65,7 @@ confspec = ConfigObj(StringIO(
+ 	#possible log levels are DEBUG, IO, DEBUGWARNING, INFO
+ 	loggingLevel = string(default=""INFO"")
+ 	showWelcomeDialogAtStartup = boolean(default=true)
++	showSpeechViewerAtStartup = boolean(default=false)
+ 
+ # Speech settings
+ [speech]","Perhaps move this option into a separate speechViewer section, as we are planning to also save position information as well.",Why is this needed?
+8796,"@@ -22,4 +22,9 @@ interface SegmentProductsQueryInterface
+      * @return array
+      */
+     public function getProductsByType(SegmentId $segmentId, string $type): array;
++
++    /**
++     * @return array
++     */
++    public function getAllEditedProducts(SegmentId $segmentId, ?\DateTime $dateTime = null): array;
+ }",This is not a segment responsibility this query should be in exporter-File module,`<msg>`$dateTime` should be nullable
+8797,"@@ -174,6 +174,8 @@ class ClangTidy(analyzer_base.SourceAnalyzer):
+ 
+             analyzer_cmd.append(self.source_file)
+ 
++            analyzer_cmd.extend(['--export-fixes', result_handler.fixit_file])
++
+             analyzer_cmd.append(""--"")
+ 
+             analyzer_cmd.append('-Qunused-arguments')",Did you measure the performance with and without this option. Do we want to export fixits even if the `clang-apply-replacements` tool is not available in the user's PATH?,This should be `result_handler.fixit
+8798,"@@ -19,12 +19,12 @@ package v1alpha1
+ import (
+ 	apis ""github.com/openebs/maya/pkg/apis/openebs.io/ndm/v1alpha1""
+ 	""github.com/pkg/errors""
+-	""k8s.io/apimachinery/pkg/apis/meta/v1""
++	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
+ )
+ 
+ // Get is spc client implementation to get disk.
+ func (s *SpcObjectClient) Get(name string) (*Disk, error) {
+-	spcDiskList := s.Spc.Spec.Disks.DiskList
++	spcDiskList := s.Spc.Spec.BlockDevices.BlockDeviceList
+ 	var diskName string
+ 	for _, disk := range spcDiskList {
+ 		if name == disk {",What if we do not change this file ? Are we using this `pkg/disk/v1alpha1` elsewhere for block device requirement?,Why do we need to change this?
+8799,"@@ -27,7 +27,7 @@ module Bolt
+         non_interactive: true
+       }
+ 
+-      options[:port] = @port if @port
++      options[:port] = port if port
+       options[:password] = @password if @password
+       options[:keys] = @key if @key
+       options[:verify_host_key] = if @insecure",regarding dropping the port/host/uri methods on Nod: this would `options[:port] = target.port if target.port`,Why do we need this change?
+8800,"@@ -4,9 +4,10 @@ import java.io.File;
+ import java.io.IOException;
+ 
+ public class FileTypeDetection {
+-
+-    public static String determineFileType(File file) throws IOException {
+-        return FileUtil.determineFileType(file, file.getName());
++    // Question: why do we need this utility? - as opposed to just calling the 
++    // static method in FileUtil directly? - L.A. 
++    public static String determineFileType(File file, String fileName) throws IOException {
++        return FileUtil.determineFileType(file, fileName);
+     }
+ 
+ }","good question - I vote we just remove, up to you if you want to handle in this PR though. (as it would require changing the places you call it; maybe moving the test? Though my guess is if we don't now, we never will.",I don't understand why we need this utility.
+8801,"@@ -15,6 +15,10 @@ module Travis
+           super << ""--gemfile-"" << config[:gemfile].to_s
+         end
+ 
++        def use_directory_cache?
++          super or data.cache?(:bundler)
++        end
++
+         def setup
+           super
+           setup_bundler",This is so that if we turn on bundler caching globally it still won't affect python etc. Same inheritance logic as for the cache slug.,I think this should be `||` instead of `or`
+8802,"@@ -58,7 +58,8 @@ namespace Nethermind.Synchronization.Peers
+         public bool CanBeAllocated(AllocationContexts contexts)
+         {
+             return !IsAsleep(contexts) &&
+-                   !IsAllocated(contexts);
++                   !IsAllocated(contexts) &&
++                   this.SupportsAllocation(contexts);
+         }
+ 
+         [MethodImpl(MethodImplOptions.Synchronized)]",[You can ignore it] Maybe a better method name would be IsSupported or HasSupportForAllocation?,Why is this needed?
+8803,"@@ -32,7 +32,7 @@ def escape_and_globify(pattern_string):
+         pattern_string (str): The pattern string of which to make a regex.
+ 
+     Returns:
+-        str: The pattern string, escaped except for the ""*"", which is
++        str: The pattern string, escaped except for the ""\*"", which is
+             transformed into "".+"" (match on one or more characters).
+     """"""
+     if pattern_string is None:","Why is this changed to `\*`? The behavior of the code on line 42, shows that `*` is what's handled?",Why did you change this?
+8804,"@@ -117,6 +117,16 @@ module.exports = BaseTest.extend({
+         TestCase.assertEqual(Realm.defaultPath, newPath, ""defaultPath should have been updated"");
+     },
+ 
++    testRealmSchemaVersion: function() {
++        TestCase.assertEqual(Realm.schemaVersion(Realm.defaultPath), 0xFFFFFFFFFFFFFFFF);
++        
++        var realm = new Realm({schema: []});
++        TestCase.assertEqual(Realm.schemaVersion(Realm.defaultPath), 0);
++
++        realm = new Realm({schema: [], schemaVersion: 2, path: 'another.realm'});
++        TestCase.assertEqual(Realm.schemaVersion('another.realm'), 2);
++    },
++
+     testRealmCreate: function() {
+         var realm = new Realm({schema: [schemas.IntPrimary, schemas.AllTypes, schemas.TestObject]});
+ ",I think this should either return `-1` or throw. I think my vote is on the former.,Why do we need this test?
+8805,"@@ -54,6 +54,7 @@ DEFAULT_SETTINGS = {
+         'kinto.core.events.setup_transaction_hook',
+     ),
+     'event_listeners': '',
++    'heartbeat_timeout_seconds': 5,
+     'logging_renderer': 'kinto.core.logs.ClassicLogRenderer',
+     'newrelic_config': None,
+     'newrelic_env': 'dev',","I am confused, I've read 2, 3 and 5 seconds in various places",Why do we need this?
+8806,"@@ -91,7 +91,14 @@ func (h Handler) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error)
+ 			fcgiBackend.SetSendTimeout(rule.SendTimeout)
+ 
+ 			var resp *http.Response
+-			contentLength, _ := strconv.Atoi(r.Header.Get(""Content-Length""))
++
++			var contentLength int64
++			// if ContentLength is already set
++			if r.ContentLength > 0 {
++				contentLength = r.ContentLength
++			} else {
++				contentLength, _ = strconv.ParseInt(r.Header.Get(""Content-Length""), 10, 64)
++			}
+ 			switch r.Method {
+ 			case ""HEAD"":
+ 				resp, err = fcgiBackend.Head(env)",Any particular reason you chose int64 instead of int? This requires adding type conversions throughout the code below.,Shouldn't this be `if r.C
+8807,"@@ -280,14 +280,16 @@ class CommandTest(QuiltTestCase):
+ 
+         mock_input.return_value = old_refresh_token
+ 
+-        with pytest.raises(command.CommandException, match='Invalid team name'):
++        with pytest.raises(command.CommandException,
++                match='The team you specified is not a valid team.'):
+             command.login('fo!o')
+ 
+         mock_open.assert_not_called()
+         mock_login_with_token.assert_not_called()
+ 
+     def test_login_with_token_invalid_team(self):
+-        with pytest.raises(command.CommandException, match='Invalid team name'):
++        with pytest.raises(command.CommandException,
++                match='The team you specified is not a valid team.'):
+             command.login_with_token('123', 'fo!o')
+ 
+     @patch('quilt.tools.command._save_auth')",this string should really be a local constant. it's repeated below.,I don't think you need th
+8808,"@@ -194,6 +194,7 @@ namespace OpenTelemetry.Exporter.Jaeger.Implementation
+                 int i => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: Convert.ToInt64(i)),
+                 long l => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: l),
+                 float f => new JaegerTag(attribute.Key, JaegerTagType.DOUBLE, vDouble: Convert.ToDouble(f)),
++                short sh => new JaegerTag(attribute.Key, JaegerTagType.LONG, vLong: Convert.ToInt64(sh)),
+                 double d => new JaegerTag(attribute.Key, JaegerTagType.DOUBLE, vDouble: d),
+                 bool b => new JaegerTag(attribute.Key, JaegerTagType.BOOL, vBool: b),
+                 _ => new JaegerTag(attribute.Key, JaegerTagType.STRING, vStr: attribute.Value.ToString()),","Number types are hard  . Should we be considering byte/sbyte? What about unsigned variants that would otherwise fit in a signed 64 bit integer like UInt16, UInt32?",Why do we need this?
+8809,"@@ -170,7 +170,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Tests
+         [MemberData(nameof(HostHeaderData))]
+         public void ValidHostHeadersParsed(string host)
+         {
+-            Assert.True(HttpUtilities.IsValidHostHeader(host));
++            HttpUtilities.ValidateHostHeader(host);
++            Assert.True(true);
+         }
+ 
+         public static TheoryData<string> HostHeaderInvalidData",`Assert.True(true)`...   xunit used to have Assert.DoesNotThrow  ,Why do we need this 
+8810,"@@ -3,8 +3,9 @@ if ENV[""S3_BUCKET_NAME""] && ENV[""S3_ACCESS_KEY_ID""] && ENV[""S3_SECRET_ACCESS_KEY
+     bucket: ENV[""S3_BUCKET_NAME""],
+     s3_credentials: {
+       access_key_id: ENV[""S3_ACCESS_KEY_ID""],
+-      secret_access_key: ENV[""S3_SECRET_ACCESS_KEY""]
++      secret_access_key: ENV[""S3_SECRET_ACCESS_KEY""],
+     },
++    s3_region: ""us-east-1"",
+     s3_permissions: :private,
+     storage: :s3,
+   )",should this be an env var like the other `S3_*` values?,I think this should 
+8811,"@@ -9,3 +9,12 @@ export function assign(obj, props) {
+ 	for (let i in props) obj[i] = props[i];
+ 	return /** @type {O & P} */ (obj);
+ }
++
++/**
++ * Remove a child node from its parent if attached.
++ * @param {Node} node The node to remove
++ */
++export function removeNode(node) {
++	let parentNode = node.parentNode;
++	if (parentNode) parentNode.removeChild(node);
++}","If you do go this route, I think it would be worth adding a note here that IE 11 is the only reason why we're not using the more obvious `node.remove()`.",Why do we need this 
+8812,"@@ -26,7 +26,7 @@ class RecommendationChecker(checkers.BaseChecker):
+             ""consider-iterating-dictionary"",
+             ""Emitted when the keys of a dictionary are iterated through the .keys() ""
+             ""method. It is enough to just iterate through the dictionary itself, as ""
+-            'in ""for key in dictionary"".',
++            'in ""for key in dictionary"" or ""if key in dictionary"".',
+         ),
+         ""C0206"": (
+             ""Consider iterating with .items()"",",The added text doesn't really match why it's possible. Maybe it would be better to name that as a separate case for this checker? (e.g. dict lookup is quicker than list comparison),I don't think this is correct. It should be `if key in dictionary`.
+8813,"@@ -63,7 +63,7 @@ class Image implements EntityFileUploadInterface
+     protected $position;
+ 
+     /**
+-     * @var \Datetime
++     * @var \DateTime
+      *
+      * @ORM\Column(type=""datetime"")
+      */",just whether we are not missing some doctrine extension because above this attribute is nullable position and it shows int instead of int|null but maybe for lvl2 it is OK,This should be reverted.
+8814,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+ 
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,I don't think we need this method. We can just use `slots.size()`
+8815,"@@ -1030,7 +1030,7 @@ bool StatelessValidation::manual_PreCallValidateCreateImage(VkDevice device, con
+                                      ""vkCreateImage(): Tiling is VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT but pNext must have ""
+                                      ""either VkImageDrmFormatModifierListCreateInfoEXT or ""
+                                      ""VkImageDrmFormatModifierExplicitCreateInfoEXT in the pNext chain"");
+-                } else if (drm_format_mod_list != nullptr) {
++                } else if (drm_format_mod_explict != nullptr) {
+                     image_create_drm_format_modifiers.push_back(drm_format_mod_explict->drmFormatModifier);
+                 } else if (drm_format_mod_list != nullptr) {
+                     for (uint32_t i = 0; i < drm_format_mod_list->drmFormatModifierCount; i++) {",":grimacing: yikes, thanks for catching this!",I think this should be `drm_format_mod_explict != nullptr`
+8816,"@@ -0,0 +1,10 @@
++using System;
++using MvvmCross.Droid.Support.V7.RecyclerView.Model;
++
++namespace MvvmCross.Droid.Support.V7.RecyclerView
++{
++    public interface IMvxRecyclerAdapterBindableHolder
++    {
++        event Action<MvxViewHolderBindedEventArgs> MvxViewHolderBinded;
++    }
++}",`Binded` is weird. I think it needs to be something with `Bound` in it (and drop the `Mvx` bit) like `ViewHolderBound` or something.,Why do we need this interface?
+8817,"@@ -84,8 +84,8 @@ func importPoolBuilder(cStorPool *apis.CStorPool, cachefileFlag bool) []string {
+ }
+ 
+ // CreatePool creates a new cStor pool.
+-func CreatePool(cStorPool *apis.CStorPool) error {
+-	createAttr := createPoolBuilder(cStorPool)
++func CreatePool(cStorPool *apis.CStorPool, diskList []string) error {
++	createAttr := createPoolBuilder(cStorPool, diskList)
+ 	glog.V(4).Info(""createAttr : "", createAttr)
+ 
+ 	stdoutStderr, err := RunnerVar.RunCombinedOutput(PoolOperator, createAttr...)",can we have String() and GoString() implementation of `apis.CStorPool` struct to pretty print it.,nit: `diskList []string` -> `d
+8818,"@@ -914,6 +914,10 @@ CheckedError Parser::ParseTable(const StructDef &struct_def, std::string *value,
+   size_t fieldn = 0;
+   auto err = ParseTableDelimiters(fieldn, &struct_def,
+                                   [&](const std::string &name) -> CheckedError {
++    if (name == ""$schema"") {
++      NEXT(); // Ignore this field.
++      return NoError();
++    }
+     auto field = struct_def.fields.Lookup(name);
+     if (!field) {
+       if (!opts.skip_unexpected_fields_in_json) {","Like I said, please replace by `EXPECT(kTokenString)`",Why is this needed?
+8819,"@@ -32,6 +32,7 @@ import org.apache.commons.logging.Log;
+ import org.apache.commons.logging.LogFactory;
+ 
+ import org.springframework.security.authentication.AuthenticationCredentialsNotFoundException;
++import org.springframework.security.authentication.AuthenticationDetailsSource;
+ import org.springframework.security.authentication.AuthenticationManager;
+ import org.springframework.security.authentication.AuthenticationTrustResolver;
+ import org.springframework.security.authentication.AuthenticationTrustResolverImpl;",Will you please update the copyright message to `2021` for classes that you modify?,I don't think we need this imp
+8820,"@@ -301,6 +301,8 @@
+                 getSelectedRows: function () {
+                   return service.getSelectedRows(grid).map(function (gridRow) {
+                     return gridRow.entity;
++                  }).filter(function (entity) {
++                    return entity.hasOwnProperty('$$hashKey');
+                   });
+                 },
+                 /**","Is there a better way to filter these other than relying on the hashKey. I few like this might now be trustworthy in the long run. If angular ever removes this property, this feature would be broken.",Why is this needed?
+8821,"@@ -2012,7 +2012,11 @@ os_tls_thread_exit(local_state_t *local_state)
+ 
+     /* We already set TLS to &uninit_tls in os_thread_exit() */
+ 
+-    if (dynamo_exited && !last_thread_tls_exited) {
++    /* Do not set last_thread_tls_exited if a client_thread is exiting.
++     * If set, get_thread_private_dcontext() returns NULL, which may cause
++     * other thread fault on using dcontext.
++     */
++    if (dynamo_exited && dynamo_exited_synched && !last_thread_tls_exited) {
+         last_thread_tls_exited = true;
+         first_thread_tls_initialized = false; /* for possible re-attach */
+     }",No need to check dynamo_exited,I don't think this 
+8822,"@@ -47,8 +47,11 @@ func (c *Config) SetDevice(deviceName string) {
+ 	c.setParam(""dev"", deviceName)
+ }
+ 
+-func (c *Config) SetTlsCertificate(caFile, certFile, certKeyFile string) {
++func (c *Config) SetTlsCACertificate(caFile string) {
+ 	c.AddOptions(OptionFile(""ca"", caFile))
++}
++
++func (c *Config) SetTlsPrivatePubKeys(certFile string, certKeyFile string) {
+ 	c.AddOptions(OptionFile(""cert"", certFile))
+ 	c.AddOptions(OptionFile(""key"", certKeyFile))
+ }",from linter: >method SetTlsCACertificate should be SetTLSCACertificate,Why do we need this
+8823,"@@ -519,11 +519,11 @@ public abstract class SpanStoreTest {
+ 
+     Span trace2 = Span.builder().traceId(2).name(""get"").id(2)
+         .timestamp((today + 2) * 1000)
+-        .addAnnotation(Annotation.create((today + 1) * 1000, CLIENT_SEND, APP_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, SERVER_RECV, WEB_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, SERVER_SEND, WEB_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, CLIENT_RECV, APP_ENDPOINT))
+-        .addAnnotation(Annotation.create((today + 1) * 1000, ""app"", APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, CLIENT_SEND, APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, SERVER_RECV, WEB_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, SERVER_SEND, WEB_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, CLIENT_RECV, APP_ENDPOINT))
++        .addAnnotation(Annotation.create((today + 2) * 1000, ""app"", APP_ENDPOINT))
+         .addBinaryAnnotation(BinaryAnnotation.create(""local"", ""app"", APP_ENDPOINT))
+         .addBinaryAnnotation(BinaryAnnotation.create(""app-b"", ""app"", APP_ENDPOINT))
+         .build();",this data had incorrectly aligned timestamps (which wasn't the point of the test),Why is this change 
+8824,"@@ -280,6 +280,16 @@ func (w *Workflow) populateStep(ctx context.Context, s *Step) error {
+ 	return step.populate(ctx, s)
+ }
+ 
++func getUser() string {
++	if cu, err := user.Current(); err == nil {
++		return cu.Username
++	}
++	if hn, err := os.Hostname(); err == nil {
++		return hn
++	}
++	return ""unknown""
++}
++
+ func (w *Workflow) populate(ctx context.Context) error {
+ 	var err error
+ 	if w.ComputeClient == nil {","Since this is workflow agnostic, should we put this in common?","Why not just return ""unknown""?"
+8825,"@@ -54,6 +54,13 @@ class SourceAnalyzer(object):
+         """"""
+         raise NotImplementedError(""Subclasses should implement this!"")
+ 
++    @classmethod
++    def version_compatible(cls, configured_binary, environ):
++        """"""
++        Checker the version compatibility of the given analyzer binary.
++        """"""
++        raise NotImplementedError(""Subclasses should implement this!"")
++
+     @classmethod
+     def construct_config_handler(cls, args, context):
+         """""" Should return a subclass of AnalyzerConfigHandler.""""""",using the `@abstractmethod` decorator wouldn't be better?,I don't think we need this met
+8826,"@@ -21,7 +21,7 @@ final class BooleanConfigurator implements FieldConfiguratorInterface
+     public function configure(FieldDto $field, EntityDto $entityDto, AdminContext $context): void
+     {
+         $isRenderedAsSwitch = true === $field->getCustomOption(BooleanField::OPTION_RENDER_AS_SWITCH);
+-        if ($isRenderedAsSwitch && false !== strpos($field->getProperty(), '.')) {
++        if ($isRenderedAsSwitch && $this->isNestedProperty($field) && false === $this->isBoolean($field)) {
+             throw new \InvalidArgumentException(sprintf('The ""%s"" property cannot be rendered as a switch because it belongs to an associated entity instead of to the entity itself. Render the property as a normal boolean field.', $field->getProperty()));
+         }
+ ",This was crashing the app during EDIT on boolean Doctrine Embedded properties,`false !== strpos($field->getP
+8827,"@@ -45,7 +45,7 @@
+ 
+ #include ""board_common.h""
+ 
+-#define DFL_SYSFS_SEC_GLOB ""*dfl*/*spi*/*spi*/*spi*/**/security/""
++#define DFL_SYSFS_SEC_GLOB ""*dfl*/**/security/""
+ #define DFL_SYSFS_SEC_USER_FLASH_COUNT         DFL_SYSFS_SEC_GLOB ""*flash_count""
+ #define DFL_SYSFS_SEC_BMC_CANCEL               DFL_SYSFS_SEC_GLOB ""bmc_canceled_csks""
+ #define DFL_SYSFS_SEC_BMC_ROOT                 DFL_SYSFS_SEC_GLOB ""bmc_root_entry_hash""",Will this be backwards compatible with the previous path?,"#include ""board_common.h"""
+8828,"@@ -29,6 +29,11 @@ namespace OpenTelemetry.Trace
+         /// </summary>
+         ISpan CurrentSpan { get; }
+ 
++        /// <summary>
++        /// Gets the current scope from the context.
++        /// </summary>
++        IScope CurrentScope { get; }
++
+         /// <summary>
+         /// Gets the <see cref=""IBinaryFormat""/> for this implementation.
+         /// </summary>",what is potential use for current scope? It seems you'd only want it to stop it. But if you get current scope you never know if it's yours to stop - i.e. this is not safe or correct to stop current scope. So I wonder should we even try to expose it?,Why do we need this?
+8829,"@@ -76,7 +76,9 @@ describe( 'User Input Settings', () => {
+ 			'enter keywords',
+ 			async () => {
+ 				await expect( page ).toClick( '.googlesitekit-user-input__buttons--next' );
+-				await expect( page ).toFill( '#searchTerms-keyword-0', 'One,Two,Three,' );
++				await expect( page ).toFill( '#searchTerms-keyword-0', 'One' );
++				await expect( page ).toFill( '#searchTerms-keyword-1', 'Two' );
++				await expect( page ).toFill( '#searchTerms-keyword-2', 'Three' );
+ 			},
+ 		);
+ ",I think this is likely the only additional change needed on the original PR.,Why are we changing 
+8830,"@@ -5,10 +5,12 @@ import android.content.SharedPreferences;
+ import android.content.res.Configuration;
+ import android.util.AttributeSet;
+ import android.view.View;
++
+ import androidx.appcompat.view.ContextThemeWrapper;
+ import androidx.recyclerview.widget.DividerItemDecoration;
+ import androidx.recyclerview.widget.LinearLayoutManager;
+ import androidx.recyclerview.widget.RecyclerView;
++
+ import de.danoeh.antennapod.R;
+ import io.reactivex.annotations.Nullable;
+ ",Please revert changes to unrelated file,Please don't change 
+8831,"@@ -0,0 +1,14 @@
++package azkaban.execapp.fake;
++
++import org.mortbay.jetty.Connector;
++import org.mortbay.jetty.Server;
++import org.mortbay.jetty.bio.SocketConnector;
++
++public class FakeServer extends Server {
++
++  @Override
++  public Connector[] getConnectors() {
++    return new Connector[]{new SocketConnector()};
++  }
++
++}",Can test use a Mockito mock instance instead?,nit: missing license
+8832,"@@ -47,12 +47,13 @@ import java.lang.reflect.Method;
+         link = ""https://github.com/palantir/gradle-baseline#baseline-error-prone-checks"",
+         linkType = BugPattern.LinkType.CUSTOM,
+         severity = BugPattern.SeverityLevel.WARNING,
+-        summary = ""InvocationHandlers which delegate to another object must catch and unwrap ""
+-                + ""InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown ""
+-                + ""each time the delegate throws an exception.\n""
+-                + ""This check is intended to be advisory. It's fine to ""
+-                + ""@SuppressWarnings(\""InvocationHandlerDelegation\"") in certain cases, ""
+-                + ""but is usually not recommended."")
++        summary =
++                ""InvocationHandlers which delegate to another object must catch and unwrap ""
++                        + ""InvocationTargetException, otherwise an UndeclaredThrowableException will be thrown ""
++                        + ""each time the delegate throws an exception.\n""
++                        + ""This check is intended to be advisory. It's fine to ""
++                        + ""@SuppressWarnings(\""InvocationHandlerDelegation\"") in certain cases, ""
++                        + ""but is usually not recommended."")
+ public final class InvocationHandlerDelegation extends BugChecker implements BugChecker.MethodInvocationTreeMatcher {
+ 
+     private static final Matcher<MethodTree> INVOCATION_HANDLER = Matchers.anyOf(",Bit of a shame about these multi-line strings in annotation parameters - they're not a deal breaker but just make the diff noisier,I don't think this change is necessary.
+8833,"@@ -61,6 +61,11 @@ namespace Microsoft.Rest.Generator.NodeJS
+             }
+         }
+ 
++        public List<T> ConvertIEnumerableToList<T>(IEnumerable<T> enumerable)
++        {
++            return new List<T>(enumerable);
++        }
++
+         public bool IsPolymorphic
+         {
+             get",we can remove this one as this is not used any more,Why do we need this?
+8834,"@@ -90,7 +90,6 @@ public abstract class LongRunningConfig {
+   private static LongRunningConfig createLongRunningConfigFromProtoFile(
+       Method method, DiagCollector diagCollector, ProtoParser protoParser) {
+ 
+-    boolean error = false;
+     Model model = method.getModel();
+     OperationTypes operationTypes = protoParser.getLongRunningOperation(method);
+     if (operationTypes == null",we don't really need an extra error flag,Why is this removed?
+8835,"@@ -21,11 +21,15 @@ import com.google.common.collect.ImmutableList;
+ import java.io.File;
+ import java.util.AbstractList;
+ import java.util.List;
++import java.util.Optional;
+ import java.util.stream.Collectors;
+-import net.ltgt.gradle.errorprone.ErrorPronePlugin;
++import net.ltgt.gradle.errorprone.javacplugin.CheckSeverity;
++import net.ltgt.gradle.errorprone.javacplugin.ErrorProneJavacPluginPlugin;
++import net.ltgt.gradle.errorprone.javacplugin.ErrorProneOptions;
+ import org.gradle.api.Plugin;
+ import org.gradle.api.Project;
+ import org.gradle.api.file.FileCollection;
++import org.gradle.api.plugins.ExtensionAware;
+ import org.gradle.api.plugins.JavaPluginConvention;
+ import org.gradle.api.tasks.compile.JavaCompile;
+ import org.gradle.api.tasks.javadoc.Javadoc;",any chance you could just fix the processors plugin?,Why is this needed? I don't see it used
+8836,"@@ -22,7 +22,8 @@ model = dict(
+         basesize_ratio_range=(0.15, 0.9),
+         anchor_ratios=([2], [2, 3], [2, 3], [2, 3], [2], [2]),
+         target_means=(.0, .0, .0, .0),
+-        target_stds=(0.1, 0.1, 0.2, 0.2)))
++        target_stds=(0.1, 0.1, 0.2, 0.2),
++        use_depthwise=False))
+ cudnn_benchmark = True
+ train_cfg = dict(
+     assigner=dict(",We may keep this config unchanged since `use_depthwise=True` by default.,Why do we need this change?
+8837,"@@ -566,6 +566,15 @@ privload_process_imports(privmod_t *mod)
+                     privload_locate_and_load(name, mod, false /*client dir=>true*/);
+                 if (impmod == NULL)
+                     return false;
++                if (strstr(name, ""libpthread"") == name) {
++                    /* i#956: A private libpthread is not fully supported, but many
++                     * libraries import some utilities from it and do not use
++                     * threading.  We load it and just do not guarantee things will
++                     * work if thread-related routines are called.
++                     */
++                    SYSLOG_INTERNAL_WARNING(
++                        ""private libpthread.so loaded but not fully supported"");
++                }
+                 /* i#852: identify all libs that import from DR as client libs.
+                  * XXX: this code seems stale as libdynamorio.so is already loaded
+                  * (xref #3850).",Maybe add i#956 in this log as well.,I don't think this is the r
+8838,"@@ -438,6 +438,11 @@ void Player::updateInventoryWeight()
+ 			inventoryWeight += item->getWeight();
+ 		}
+ 	}
++
++	StoreInbox* storeInbox = getStoreInbox();
++	if (storeInbox) {
++		inventoryWeight += storeInbox->getWeight();
++	}
+ }
+ 
+ void Player::addSkillAdvance(skills_t skill, uint64_t count)",if (StoreInbox* storeInbox = getStoreInbox()) {,This should be `if (storeIn
+8839,"@@ -459,9 +459,14 @@ API.prototype._import = function(cb) {
+   });
+ };
+ 
++
++API.prototype.importAllFromMnemonic = function(words, opts, cb) {
++}
++
+ /**
+  * Import from Mnemonics (language autodetected)
+  * Can throw an error if mnemonic is invalid
++ * Will try compilant and non-compliantDerivation
+  *
+  * @param {String} BIP39 words
+  * @param {Object} opts","what is this, is it going to be used later?",Why do we need this?
+8840,"@@ -66,8 +66,7 @@ module Beaker
+       name = host.name
+       Dir.stub( :chdir ).and_yield()
+ 
+-      out = double( 'stdout' )
+-      out.stub( :read ).and_return(""Host #{host.name}
++      vagrant.should_receive(:`).and_return(""Host #{host.name}
+     HostName 127.0.0.1
+     User vagrant
+     Port 2222","@anodelman test failure is probably due to this, needs to be fixed to `(""Host #{host.name}"")`",Why did you remove this stub?
+8841,"@@ -75,10 +75,10 @@
+ 
+ 
+ 
+-<div class=""cart-comments-container"">
+-  <div id=""cart-comments"">
+-    <h3>Comments on this purchase request</h3>
+-    <%- if @show_comments %>
++<%- if @include_comments_files %>
++  <div class=""cart-comments-container proposal-submodel-container"">
++    <div id=""cart-comments"">
++      <h3>Comments on this purchase request</h3>
+       <%= form_for [cart, Comment.new] do |f| %>
+         <%= f.text_area :comment_text, rows: 5 %>
+ ","I'm not sure that we need this anymore, but that can be a separate discussion.",I think this should be `propo
+8842,"@@ -34,10 +34,14 @@ public interface HttpClient {
+    * @throws IOException if an I/O error occurs.
+    */
+   HttpResponse execute(HttpRequest request, boolean followRedirects) throws IOException;
+-
++  
+   /**
+-   * Creates HttpClient instances.
+-   */
++	* Closes the connections associated with this client. 
++	*
++	* @throws  IOException  if an I/O error occurs.
++	*/
++  void close() throws IOException;
++
+   interface Factory {
+ 
+     /**",The formatting seems different from the rest of the code,Why is this needed?
+8843,"@@ -709,6 +709,9 @@ func (cg *ConfigGenerator) generateProbeConfig(
+ 	if m.Spec.ProberSpec.Scheme != """" {
+ 		cfg = append(cfg, yaml.MapItem{Key: ""scheme"", Value: m.Spec.ProberSpec.Scheme})
+ 	}
++	if m.Spec.ProberSpec.ProxyURL != """" {
++		cfg = append(cfg, yaml.MapItem{Key: ""proxy_url"", Value: m.Spec.ProberSpec.ProxyURL})
++	}
+ 
+ 	if m.Spec.Module != """" {
+ 		cfg = append(cfg, yaml.MapItem{Key: ""params"", Value: yaml.MapSlice{",Could we have a unit test for this?,I don't think this is needed.
+8844,"@@ -477,9 +477,11 @@ func (c *temporalImpl) startHistory(
+ 			}
+ 		}
+ 
++		stoppedCh := make(chan struct{})
+ 		var historyService *history.Service
+ 		app := fx.New(
+-			fx.Supply(params),
++			fx.Supply(params,
++				stoppedCh),
+ 			history.Module,
+ 			fx.Populate(&historyService))
+ 		err = app.Err()",nit: put params in new line,Why is this a channel?
+8845,"@@ -100,13 +100,15 @@ export default function DateRangeSelector() {
+ 					'mdc-button--dropdown',
+ 					'googlesitekit-header__dropdown',
+ 					'googlesitekit-header__date-range-selector-menu',
++					'googlesitekit-border-radius-round--phone',
++					'googlesitekit-button-icon--phone',
+ 					{
+ 						'googlesitekit-header__date-range-selector-menu--has-unified-dashboard': unifiedDashboardEnabled,
+ 					}
+ 				) }
+ 				text
+ 				onClick={ handleMenu }
+-				icon={ <DateRangeIcon width=""18"" height=""20"" /> }
++				icon={ <DateRangeIcon width=""20"" height=""20"" /> }
+ 				aria-haspopup=""menu""
+ 				aria-expanded={ menuOpen }
+ 				aria-controls=""date-range-selector-menu""",The button for the date range selector has incorrect width since it has `padding-right: 8px` which sets the width to: `44px`. Can you review to make the button `36px` on small screens as per the AC?,I think this should be
+8846,"@@ -2836,8 +2836,13 @@ client_process_bb(dcontext_t *dcontext, build_bb_t *bb)
+ #    ifdef X86
+         if (!d_r_is_avx512_code_in_use()) {
+             if (ZMM_ENABLED()) {
+-                if (instr_may_write_zmm_register(inst))
++                if (instr_may_write_zmm_register(inst)) {
++                    LOG(THREAD, LOG_INTERP, 2, ""Detected AVX-512 code in use\n"");
++                    SELF_UNPROTECT_DATASEC(DATASEC_RARELY_PROT);
+                     d_r_set_avx512_code_in_use(true);
++                    proc_set_num_simd_saved(MCXT_NUM_SIMD_SLOTS);
++                    SELF_PROTECT_DATASEC(DATASEC_RARELY_PROT);
++                }
+             }
+         }
+ #    endif",This should be inside the set routine IMHO: matches the others; all callers need it; simplifies code here.,(style) line over 80 c
+8847,"@@ -106,6 +106,8 @@ public class TwoPhaseCommitter {
+   /** unit is second */
+   private static final long DEFAULT_BATCH_WRITE_LOCK_TTL = 3000;
+ 
++  private static final long MAX_RETRY_LEVEL = 3;
++
+   private static final Logger LOG = LoggerFactory.getLogger(TwoPhaseCommitter.class);
+ 
+   private TxnKVClient kvClient;",MAX_RETRY_TIMES makes much more sense.,Why do we need this?
+8848,"@@ -56,6 +56,7 @@ type testContext struct {
+ 	fakeStatsKeeper       *fakeSessionStatsKeeper
+ 	fakeDialog            *fakeDialog
+ 	fakePromiseIssuer     *fakePromiseIssuer
++	fakeStorage           *fakeStorage
+ 	sync.RWMutex
+ }
+ ","`saveSession` allows easier mocking - just save function which You need, instead full interface",Why is this a pointer?
+8849,"@@ -211,7 +211,8 @@ class Bucket(object):
+                 raise self.connection.provider.storage_response_error(
+                     response.status, response.reason, '')
+ 
+-    def list(self, prefix='', delimiter='', marker='', headers=None):
++    def list(self, prefix='', delimiter='', marker='', headers=None,
++             encoding_type=None):
+         """"""
+         List key objects within a bucket.  This returns an instance of an
+         BucketListResultSet that automatically handles all of the result",No docs for the new param here?,`encoding_type` should
+8850,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright ConsenSys AG.
++ * Copyright Contributors to Hyperledger Besu.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
+  * the License. You may obtain a copy of the License at",This file is unrelated to the aims of this PR. Please remove. If it is needed to demonstrate Sonar Deltas then it has been proven and can be removed.,Why did you change thi
+8851,"@@ -42,5 +42,12 @@ namespace OpenTelemetry.Trace.Export
+         /// <param name=""cancellationToken"">Cancellation token.</param>
+         /// <returns>Returns <see cref=""Task""/>.</returns>
+         public abstract Task ShutdownAsync(CancellationToken cancellationToken);
++
++        /// <summary>
++        /// Flushes all activity objects that have been queued for processing.
++        /// </summary>
++        /// <param name=""cancellationToken"">Cancellation token.</param>
++        /// <returns>Returns <see cref=""Task""/>.</returns>
++        public abstract Task ForceFlushAsync(CancellationToken cancellationToken);
+     }
+ }","minor: `Export all ended spans to the configured Exporter that have not yet been exported.` - This is the spec description. Lets use something on that line. ""queue"" is not necessarily present for all processor.",Should this be called 
+8852,"@@ -683,6 +683,8 @@ func (c *Client) reallyExecute(tid int, target *core.BuildTarget, command *pb.Co
+ 		ActionDigest:    digest,
+ 		SkipCacheLookup: skipCacheLookup,
+ 	}, updateProgress)
++	log.Debug(""completed ExecuteAndWaitProgress() for %v"", target.Label)
++
+ 	if err != nil {
+ 		// Handle timing issues if we try to resume an execution as it fails. If we get a
+ 		// ""not found"" we might find that it's already been completed and we can't resume.",is this deliberate? or testing?,"Should this be `log.Debug(""completed ExecuteAndWaitProgress() for %v"", target.Label)`?"
+8853,"@@ -24,7 +24,7 @@ namespace OpenTelemetry
+ {
+     public class CompositeProcessor<T> : BaseProcessor<T>
+     {
+-        private DoublyLinkedListNode head;
++        private readonly DoublyLinkedListNode head;
+         private DoublyLinkedListNode tail;
+         private bool disposed;
+ ","I want to get more perspectives regarding this one. Making it `readonly` makes me feel that we're assuming the head should never change, and my worry is that other code might assume it (e.g. they might cache the value and assume it will never change). While this is true for now, I guess in the future we might want to support something like `PrependProcessor(processor)` or `InsertProcessor(index, processor)`.",Why is this readonly?
+8854,"@@ -65,7 +65,7 @@ public class TestIndexSortSortedNumericDocValuesRangeQuery extends LuceneTestCas
+         iw.deleteDocuments(LongPoint.newRangeQuery(""idx"", 0L, 10L));
+       }
+       final IndexReader reader = iw.getReader();
+-      final IndexSearcher searcher = newSearcher(reader, false);
++      final IndexSearcher searcher = newSearcher(reader);
+       iw.close();
+ 
+       for (int i = 0; i < 100; ++i) {","This isn't critical for test coverage, but it seemed off that we had disabled wrapping the reader.",why did you remove the `false` here?
+8855,"@@ -21,9 +21,9 @@ _descList = []
+ 
+ def _setupDescriptors(namespace):
+   global _descList, descList
+-  from rdkit.Chem import GraphDescriptors, MolSurf, Lipinski, Fragments, Crippen
++  from rdkit.Chem import GraphDescriptors, MolSurf, Lipinski, Fragments, Crippen, Descriptors3D
+   from rdkit.Chem.EState import EState_VSA
+-  mods = [GraphDescriptors, MolSurf, EState_VSA, Lipinski, Crippen, Fragments]
++  mods = [GraphDescriptors, MolSurf, EState_VSA, Lipinski, Crippen,Descriptors3D, Fragments]
+ 
+   otherMods = [Chem]
+ ",Please remove Descriptors3D from this file. We just did this in master.,PEP8: space after comma
+8856,"@@ -15,12 +15,17 @@ namespace storage {
+ 
+ StorageClient::StorageClient(std::shared_ptr<folly::IOThreadPoolExecutor> threadPool)
+         : ioThreadPool_(threadPool) {
+-    client_ = std::make_unique<meta::MetaClient>();
+-    client_->init();
+     clientsMan_
+         = std::make_unique<thrift::ThriftClientManager<storage::cpp2::StorageServiceAsyncClient>>();
+ }
+ 
++
++void StorageClient::init(meta::MetaClient *client) {
++    CHECK(client);
++    client_ = client;
++}
++
++
+ folly::SemiFuture<StorageRpcResponse<cpp2::ExecResponse>> StorageClient::addVertices(
+         GraphSpaceID space,
+         std::vector<cpp2::Vertex> vertices,","You could pass the MetaClient instance in ctor, and create a new instance if nullptr.",Why do we need this check?
+8857,"@@ -264,7 +264,11 @@ func subincludeTarget(s *scope, l core.BuildLabel) *core.BuildTarget {
+ 		s.NAssert(s.contextPkg.Target(l.Name) == nil, ""Target :%s is not defined in this package; it has to be defined before the subinclude() call"", l.Name)
+ 	}
+ 	s.NAssert(l.IsAllTargets() || l.IsAllSubpackages(), ""Can't pass :all or /... to subinclude()"")
++	// Temporarily release the parallelism limiter; this is important to keep us from deadlocking
++	// all available parser threads (easy to happen if they're all waiting on a single target which now can't start)
++	<-s.interpreter.limiter
+ 	t := s.state.WaitForBuiltTarget(l, pkgLabel)
++	s.interpreter.limiter <- struct{}{}
+ 	// This is not quite right, if you subinclude from another subinclude we can basically
+ 	// lose track of it later on. It's hard to know what better to do at this point though.
+ 	s.contextPkg.RegisterSubinclude(l)",What does this do? Seems like a poor mans mutex/semaphore?,I don't think this is the 
+8858,"@@ -45,5 +45,5 @@ type ResponseWriter interface {
+ 	// SetApplicationError specifies that this response contains an
+ 	// application error. If called, this MUST be called before any invocation
+ 	// of Write().
+-	SetApplicationError()
++	SetApplicationError(err error)
+ }","This is a breaking change, and cannot be made. We have committed to this API for v1.",I think this should be `Se
+8859,"@@ -136,16 +136,14 @@ class StatementsAnalyzer extends SourceAnalyzer implements StatementsSource
+      * Checks an array of statements for validity
+      *
+      * @param  array<PhpParser\Node\Stmt>   $stmts
+-     * @param  Context|null                                     $global_context
+-     * @param  bool                                             $root_scope
+      *
+      * @return null|false
+      */
+     public function analyze(
+         array $stmts,
+         Context $context,
+-        Context $global_context = null,
+-        $root_scope = false
++        ?Context $global_context = null,
++        bool $root_scope = false
+     ) {
+         if (!$stmts) {
+             return;",Can also drop corresponding types from docblock here,Why did you change this?
+8860,"@@ -105,7 +105,7 @@ public class RequestHandler implements Comparable<RequestHandler> {
+   public void process() {
+     switch (request.getRequestType()) {
+       case START_SESSION:
+-        log.info(""Got a request to create a new session: ""
++        log.finest(""Got a request to create a new session: ""
+                  + new DesiredCapabilities(request.getDesiredCapabilities()));
+         try {
+           registry.addNewSessionRequest(this);",This change is unhelpful to users.,Why is this change needed?
+8861,"@@ -59,6 +59,8 @@ public struct Vec3 : IFlatbufferObject
+   }
+   public static Offset<MyGame.Example.Vec3> Pack(FlatBufferBuilder builder, Vec3T _o) {
+     if (_o == null) return default(Offset<MyGame.Example.Vec3>);
++    var _test3_a = _o.Test3.A;
++    var _test3_b = _o.Test3.B;
+     return CreateVec3(
+       builder,
+       _o.X,",why is this variable introduced? Please stick `_o.Test3.A` directly in the call below.,I don't think this is nece
+8862,"@@ -88,7 +88,7 @@ module.exports.app = (options = {}) => {
+   app.get('/:providerName/logout', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.logout)
+   app.get('/:providerName/authorized', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.authorized)
+   app.get('/:providerName/list/:id?', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.list)
+-  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.get)
++  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.get)
+   app.get('/:providerName/thumbnail/:id', middlewares.hasSessionAndProvider, middlewares.cookieAuthToken, middlewares.verifyToken, controllers.thumbnail)
+ 
+   app.param('providerName', providerManager.getProviderMiddleware(providers))",do you mind sharing what is the reason for this change?,I think this should be `ge
+8863,"@@ -27,11 +27,11 @@ class ProposalsController < ApplicationController
+     @pending_data = listing.pending
+     @pending_review_data = listing.pending_review
+     @completed_data = listing.completed.alter_query { |rel| rel.limit(@closed_proposal_limit) }
+-    @canceled_data = listing.canceled
++    @canceled_data = listing.canceled.alter_query { |rel| rel.limit(@closed_proposal_limit) }
+   end
+ 
+   def archive
+-    @proposals_data = listing.closed
++    redirect_to query_proposals_path(text: ""status:completed"")
+   end
+ 
+   def cancel_form",thoughts on putting `alter_query { |rel| rel.limit(@closed_proposal_limit) }` in a method that we can call here? That way we can have a test for this logic without needing a controller spec.,I think this should be `@c
+8864,"@@ -31,7 +31,12 @@ module Api
+       response.last_modified = node.timestamp
+ 
+       if node.visible
+-        render :xml => node.to_xml.to_s
++        @node = node
++
++        # Render the result
++        respond_to do |format|
++          format.xml
++        end
+       else
+         head :gone
+       end",Perhaps `@node` throughout,Use 2 (not 1) spaces for indentation.
+8865,"@@ -195,8 +195,14 @@ module Beaker
+             @cmd_options[:validate] = bool
+           end
+ 
+-          opts.on '--collect-perf-data', 'Use sysstat on linux hosts to collect performance and load data' do
+-            @cmd_options[:collect_perf_data] = true
++          opts.on '--collect-perf-data [MODE]',
++                  'Collect SUT performance and load data',
++                  'Possible values:',
++                  'aggressive (poll every minute)',
++                  'normal (poll every 10 minutes)',
++                  'none (do not collect perf data)',
++                  '(default: normal)' do |mode|
++            @cmd_options[:collect_perf_data] = mode || 'normal'
+           end
+ 
+           opts.on('--version', 'Report currently running version of beaker' ) do",Shouldn't this default be 'normal' ?,I think this should be `(default: agg
+8866,"@@ -131,7 +131,7 @@ class TelemetryEntry(
+     namedtuple(
+         ""TelemetryEntry"",
+         ""action client_time elapsed_time event_id instance_id pipeline_name_hash ""
+-        ""num_pipelines_in_repo repo_hash python_version metadata version dagster_version os_desc os_platform"",
++        ""num_pipelines_in_repo num_schedules_in_repo num_sensors_in_repo repo_hash python_version metadata version dagster_version os_desc os_platform"",
+     )
+ ):
+     """"""",nit: type this,Why do we need this?
+8867,"@@ -318,4 +318,11 @@ public interface DriverCommand {
+   // Mobile API
+   String GET_NETWORK_CONNECTION = ""getNetworkConnection"";
+   String SET_NETWORK_CONNECTION = ""setNetworkConnection"";
++
++  // Cast Media Router API
++  String GET_CAST_SINKS = ""getCastSinks"";
++  String SET_CAST_SINK_TO_USE = ""selectCastSink"";
++  String START_CAST_TAB_MIRRORING = ""startCastTabMirroring"";
++  String GET_CAST_ISSUE_MESSAGE = ""getCastIssueMessage"";  
++  String STOP_CASTING = ""stopCasting"";    
+ }",These command names are specific to Chromium-based browsers. Please move to `ChromiumDriverCommand`,I don't think these are used anywhere
+8868,"@@ -234,7 +234,8 @@ func CheckIfBDBelongsToNode(nodeName string) Validate {
+ func (bd *BlockDevice) CheckIfBDBelongsToNode(nodeName string) error {
+ 	if !bd.IsBelongToNode(nodeName) {
+ 		return errors.Errorf(
+-			""block device doesn't belongs to node %s"",
++			""block device %s doesn't belongs to node %s"",
++			bd.Object.Name,
+ 			bd.Object.Spec.NodeAttributes.NodeName,
+ 		)
+ 	}",lets print nodeName that got passed also,I think this should be `bd.Object.ObjectMeta.Name`
+8869,"@@ -38,6 +38,9 @@ try:
+ except NameError:
+     pass
+ 
++if sys.version > '3':
++    long = int
++
+ 
+ class WebElement(object):
+     """"""Represents a DOM element.",Should be `if sys.version_info[0] > 2:`,Why is this needed?
+8870,"@@ -1254,6 +1254,7 @@ int main(int argc, char *argv[])
+ 
+ 	random_init();
+ 	debug_config(argv[0]);
++	debug_config_file_size(string_metric_parse(""0""));//to set debug file size to ""don't delete anything""
+ 
+ 	s = getenv(""MAKEFLOW_BATCH_QUEUE_TYPE"");
+ 	if(s) {","Is there any need to pass this through `string_metric_parse`? I believe you can either create an off_t or just pass 0, with no need to added a string conversion into the mix.",//to set debug file size to 0
+8871,"@@ -888,6 +888,17 @@ class WebDriver(BaseWebDriver):
+         """"""
+         self.execute(Command.MINIMIZE_WINDOW)
+ 
++    def print_page(self, print_option_arg = None):
++        """"""
++        Takes PDF of the current page.
++        The driver makes a best effort to return a PDF based on the provided parameters.
++        """"""
++        options = {}
++        if print_option_arg:
++            options = print_option_arg.print_options
++
++        return self.execute(Command.PRINT_PAGE, options)['value']
++
+     @property
+     def switch_to(self):
+         """"""",Let's not use a form of hungarian notation in naming our variables,"This should be `self.execute(Command.PRINT_PAGE, o"
+8872,"@@ -527,8 +527,13 @@ static void handle_incoming_request(struct st_h2o_http1_conn_t *conn)
+             send_bad_request(conn, ""line folding of header fields is not supported"");
+             return;
+         }
++
++        H2O_PROBE_CONN(RECEIVE_REQUEST_HEADERS, &conn->super, conn->_req_index, &conn->req.input.method, &conn->req.input.authority,
++                       &conn->req.input.path, conn->req.version, conn->req.headers.entries, conn->req.headers.size);
++
+         H2O_PROBE(RECEIVE_REQUEST_HEADERS, &conn->super, conn->_req_index, &conn->req.input.method, &conn->req.input.authority,
+                   &conn->req.input.path, conn->req.version, conn->req.headers.entries, conn->req.headers.size);
++
+         if (entity_body_header_index != -1) {
+             conn->req.timestamps.request_body_begin_at = h2o_gettimeofday(conn->super.ctx->loop);
+             if (expect.base != NULL) {",Seems like we are calling the probe twice?,Shouldn't this be `conn->_req_index`?
+8873,"@@ -13,7 +13,7 @@ import (
+ 
+ // LocalDevExecCmd allows users to execute arbitrary bash commands within a container.
+ var LocalDevExecCmd = &cobra.Command{
+-	Use:   ""exec [app_name] [environment_name] '[cmd]'"",
++	Use:   ""exec '[cmd]'"",
+ 	Short: ""run a command in an app container."",
+ 	Long:  `Execs into container and runs bash commands.`,
+ 	Run: func(cmd *cobra.Command, args []string) {","I think we'll want @rickmanelius (or somebody) to go through all the help and make it more accessible. Probably later in the cycle. But ""Run a command in an app container"" doesn't do it for me :)",I think this should be `[app_name] [e
+8874,"@@ -118,7 +118,7 @@ func CreateOrUpdateService(ctx context.Context, sclient clientv1.ServiceInterfac
+ 		}
+ 	} else {
+ 		svc.ResourceVersion = service.ResourceVersion
+-		svc.Spec.IPFamily = service.Spec.IPFamily
++		svc.Spec.IPFamilies = service.Spec.IPFamilies
+ 		svc.SetOwnerReferences(mergeOwnerReferences(service.GetOwnerReferences(), svc.GetOwnerReferences()))
+ 		_, err := sclient.Update(ctx, svc, metav1.UpdateOptions{})
+ 		if err != nil && !apierrors.IsNotFound(err) {","Have not tested this yet, lets see if tests complain, but I suspect it should be as easy as this  ",Why do we need to change this?
+8875,"@@ -42,6 +42,10 @@ SPARK_INDEX_NAME_FORMAT = ""__index_level_{}__"".format
+ # A pattern to check if the name of a Spark column is a Koalas index name or not.
+ SPARK_INDEX_NAME_PATTERN = re.compile(r""__index_level_[0-9]+__"")
+ 
++NATURAL_ORDER_COLUMN_NAME = '__natural_order__'
++
++HIDDEN_COLUMNS = set([NATURAL_ORDER_COLUMN_NAME])
++
+ IndexMap = Tuple[str, Optional[Tuple[str, ...]]]
+ 
+ ",no big deal but we don't we just use a list to keep the order? I don't think it's likely to have a duplicated columns if that was the concern.,Why do we need this?
+8876,"@@ -1,5 +1,5 @@
+ /**
+- * core/modules data store
++ * Modules data store
+  *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *","See above, same for all similar cases below.",Why did you change this?
+8877,"@@ -34,6 +34,7 @@ const ContainerdConfigTemplate = `
+ 
+ {{- if .NodeConfig.AgentConfig.Snapshotter }}
+ [plugins.cri.containerd]
++  disable_snapshot_annotations = true
+   snapshotter = ""{{ .NodeConfig.AgentConfig.Snapshotter }}""
+ {{end}}
+ ",where is this coming from?,I think this should be `
+8878,"@@ -0,0 +1,11 @@
++class MoveScreencastsIntoProducts < ActiveRecord::Migration
++  def up
++    say_with_time ""Converting screencasts into video_tutorials"" do
++      update ""UPDATE products SET type = 'VideoTutorial' WHERE type = 'Screencast'""
++    end
++  end
++
++  def down
++    raise ActiveRecord::IrreversibleMigration
++  end
++end","We can also drop `plans.includes_screencasts`, right?",I don't think you need t
+8879,"@@ -374,6 +374,11 @@ class ECPrivkey(ECPubkey):
+             sigdecode = get_r_and_s_from_sig_string
+         private_key = _MySigningKey.from_secret_exponent(self.secret_scalar, curve=SECP256k1)
+         sig = private_key.sign_digest_deterministic(data, hashfunc=hashlib.sha256, sigencode=sigencode)
++        counter = 0
++        while ord(sig[0]) > 127: # grind for low R value https://github.com/bitcoin/bitcoin/pull/13666
++            counter += 1
++            extra_entropy = bfh(""%064x"" % counter)[::-1]
++            sig = private_key.sign_digest_deterministic(data, hashfunc=hashlib.sha256, sigencode=sigencode, extra_entropy=extra_entropy)
+         public_key = private_key.get_verifying_key()
+         if not public_key.verify_digest(sig, data, sigdecode=sigdecode):
+             raise Exception('Sanity check verifying our own signature failed.')","wouldn't `int.to_bytes(counter, 32, 'little')` be equivalent, clearer and faster?",Why do we need this loop
+8880,"@@ -60,6 +60,11 @@ func (a *API) CreatePayments(ctx context.Context, config CreatePaymentsParams) (
+ 	return CreatePayments(ctx, a, config)
+ }
+ 
++// ValidateStoragePaymentCondition validates that the given condition is a payment condition and has the right values
++func (a *API) ValidateStoragePaymentCondition(ctx context.Context, condition *types.Predicate, minerAddr address.Address, commP types.CommP, pieceSize *types.BytesAmount) error {
++	return ValidateStoragePaymentCondition(ctx, condition, minerAddr, commP, pieceSize)
++}
++
+ // DealGet returns a single deal matching a given cid or an error
+ func (a *API) DealGet(ctx context.Context, proposalCid cid.Cid) (*storagedeal.Deal, error) {
+ 	return DealGet(ctx, a, proposalCid)","I don't see why this is in porcelain since it's just a free function, with no dependency on plumbing or the `a` receiver. I think it should be moved to `protocol/storage`. It's exposed unnecessarily widely here.",I think this should be called `ValidateStoragePaymentCondition`
+8881,"@@ -130,6 +130,11 @@ def create_messages(data, entity: str, stats_range: str, from_ts: int, to_ts: in
+     """"""
+     for entry in data:
+         _dict = entry.asDict(recursive=True)
++
++        # Clip the recordings to top 1000 so that we don't drop messages
++        if entity == ""recordings"":
++            _dict[entity] = _dict[entity][:1000]
++
+         try:
+             model = UserEntityStatMessage(**{
+                 'musicbrainz_id': _dict['user_name'],",Could we only do this for all time? Because that's what is causing problems rn?,Why do we need to do this?
+8882,"@@ -369,7 +369,7 @@ class _FlowType(_BaseFlowType):
+ 
+     def parse(self, manager: ""CommandManager"", t: type, s: str) -> flow.Flow:
+         try:
+-            flows = manager.execute(""view.flows.resolve %s"" % (s))
++            flows = manager.execute(""view.flows.resolve '%s'"" % (s))
+         except exceptions.CommandError as e:
+             raise exceptions.TypeError(str(e)) from e
+         if len(flows) != 1:","This looks better than before, but we'll now likely run into issues with `'` characters in the spec. Maybe we can just use `manager.call_strings` instead?",I think this should be `str(e) from e`
+8883,"@@ -131,6 +131,12 @@ public class SparkReadConf {
+         .parse();
+   }
+ 
++  public Long splitSizeOption() {
++    return confParser.longConf()
++        .option(SparkReadOptions.SPLIT_SIZE)
++        .parseOptional();
++  }
++
+   public long splitSize() {
+     return confParser.longConf()
+         .option(SparkReadOptions.SPLIT_SIZE)","Should this replace `splitSize` instead of adding a parallel call? The `SparkReadConf` is not yet released, so we can change it still.",nit: remove empty line
+8884,"@@ -71,7 +71,18 @@ class LocalFileSystem(FileSystem):
+                 return
+ 
+         if parents:
+-            os.makedirs(path)
++            # for Python 2 compatibility
++            try:
++                FileNotExistsError
++            except NameError:
++                FileNotExistsError = OSError
++
++            try:
++                os.makedirs(path)
++            except FileNotExistsError as err:
++                # somebody already created the path
++                if err.errno != errno.EEXIST:
++                    raise
+         else:
+             if not os.path.exists(os.path.dirname(path)):
+                 raise MissingParentDirectory()","To reduce complexity, please use OSError on Python3 as well.",Why is this needed?
+8885,"@@ -209,3 +209,10 @@ def follow_selected(tab_obj: apitypes.Tab, *, tab: bool = False) -> None:
+         tab_obj.caret.follow_selected(tab=tab)
+     except apitypes.WebTabError as e:
+         raise cmdutils.CommandError(str(e))
++
++
++@cmdutils.register()
++@cmdutils.argument('tab', value=cmdutils.Value.cur_tab)
++def reverse_selection(tab: apitypes.Tab) -> None:
++    """"""Toggle caret selection mode.""""""
++    tab.caret.reverse_selection()",That seems wrong.,Why do we need this
+8886,"@@ -55,6 +55,7 @@ public class ConfirmEmailPage implements java.io.Serializable {
+             if (confirmEmailData != null) {
+                 user = confirmEmailData.getAuthenticatedUser();
+                 session.setUser(user);
++                session.configureSessionTimeout(); // TODO: is this needed here? (it can't hurt, but still)
+                 JsfHelper.addSuccessMessage(BundleUtil.getStringFromBundle(""confirmEmail.details.success""));
+                 return ""/dataverse.xhtml?faces-redirect=true"";
+             }","Yes, this is needed here. This is a builtin user who just reset their password.",I don't think this 
+8887,"@@ -396,13 +396,12 @@ class HDF5PackageStore(PackageStore):
+         """"""
+         self._find_path_write()
+         buildfile = name.lstrip('/').replace('/', '.')
+-        storepath = os.path.join(self._pkg_dir, buildfile)
++        storepath = self._object_path('.' + buildfile)
+         with pd.HDFStore(storepath, mode=self._mode) as store:
+             store[self.DF_NAME] = df
+         filehash = digest_file(storepath)
+         self._add_to_contents(buildfile, filehash, ext, path, target)
+-        objpath = os.path.join(self._pkg_dir, self.OBJ_DIR, filehash)
+-        os.rename(storepath, objpath)
++        os.rename(storepath, self._object_path(filehash))
+ 
+     @classmethod
+     def ls_packages(cls, pkg_dir):","This seems to move the storage of temporary files to the CWD. Is that right? I don't think we should do that. If the process gets interrupted, we should try our best to clean up, but if even that fails, it'd be nice if the mess was left in a different directory. Maybe we should have a directory explicitly for builds?",I think this should
+8888,"@@ -67,6 +67,10 @@ type Config struct {
+ 	// If not set, it uses all versions available.
+ 	// Warning: This API should not be considered stable and will change soon.
+ 	Versions []protocol.VersionNumber
++	// Ask the server to truncate the connection ID sent in the Public Header.
++	// This saves 8 bytes in the Public Header in every packet. However, if the IP address of the server changes, the connection cannot be migrated.
++	// Currently only valid for the client.
++	RequestConnectionIDTruncation bool
+ }
+ 
+ // A Listener for incoming QUIC connections","Please explain why a user would enable this (space savings), and the requirements for this option to be safe.",I don't think this is the right place to put this. I think it should be in the server package.
+8889,"@@ -43,12 +43,16 @@ export default function ContainerSelect( {
+ 	value,
+ 	...props
+ } ) {
+-	const accounts = useSelect( ( select ) => select( STORE_NAME ).getAccounts() );
++	const { accounts, hasResolvedAccounts } = useSelect( ( select ) => ( {
++		accounts: select( STORE_NAME ).getAccounts(),
++		hasResolvedAccounts: select( STORE_NAME ).hasFinishedResolution( 'getAccounts' ),
++	} ) );
++
+ 	const accountID = useSelect( ( select ) => select( STORE_NAME ).getAccountID() );
+ 	const hasExistingTag = useSelect( ( select ) => select( STORE_NAME ).hasExistingTag() );
+-	const isLoadingContainers = useSelect( ( select ) => select( STORE_NAME ).isDoingGetContainers( accountID ) );
++	const hasResolvedContainers = useSelect( ( select ) => select( STORE_NAME ).hasFinishedResolution( 'getContainers', [ accountID ] ) );
+ 
+-	if ( accounts === undefined || containers === undefined || isLoadingContainers ) {
++	if ( accounts === undefined || ! hasResolvedAccounts || containers === undefined || ! hasResolvedContainers ) {
+ 		return <ProgressBar small />;
+ 	}
+ ",I think the `undefined` checks still need to be removed from here.,"I don't think we need to check for `hasResolvedAccounts` here, since `getAccounts` already che"
+8890,"@@ -158,6 +158,13 @@ class KubernetesJobTask(luigi.Task):
+         """"""
+         return self.kubernetes_config.max_retrials
+ 
++    @property
++    def backoff_limit(self):
++        """"""
++        Maximum number of retries before considering the job as failed.
++        """"""
++        return 6
++
+     @property
+     def delete_on_success(self):
+         """"""",Is there any particular reason to have 6?  ,Should this be configurable?
+8891,"@@ -122,8 +122,11 @@ func (s *Space) biggestFreeRange(r address.Range) (biggest address.Range) {
+ 	biggestSize := address.Count(0)
+ 	s.walkFree(r, func(chunk address.Range) bool {
+ 		if size := chunk.Size(); size >= biggestSize {
+-			biggest = chunk
+-			biggestSize = size
++			chunk = chunk.BiggestPow2AlignedRange()
++			if size = chunk.Size(); size >= biggestSize {
++				biggest = chunk
++				biggestSize = size
++			}
+ 		}
+ 		return false
+ 	})","The biggest chunk does not guarantee that it contains the biggest CIDR-aligned range. If we don't care too much about a few CPU cycles being wasted, then I'd suggest to merge the if-statements.",Why is this needed?
+8892,"@@ -81,6 +81,16 @@ func (i *IncludeWorkflow) populate(ctx context.Context, s *Step) dErr {
+ 	}
+ 	substitute(reflect.ValueOf(i.Workflow).Elem(), strings.NewReplacer(replacements...))
+ 
++	// We do this here, and not in validate, as embedded startup scripts could
++	// have what we think are daisy variables.
++	if err := i.Workflow.validateVarsSubbed(); err != nil {
++		return err
++	}
++
++	if err := i.Workflow.substituteSourceVars(reflect.ValueOf(i.Workflow).Elem()); err != nil {
++		return err
++	}
++
+ 	i.Workflow.populateLogger(ctx)
+ 
+ 	for name, st := range i.Workflow.Steps {","instead of doing the if err := __; err != nil { return err } thing, you can do errs = addErrs(errs, ___). If you want.",Why do we need to do this? Isn't it enough to call `validateVarsSubbed`?
+8893,"@@ -4,8 +4,15 @@
+ package cli
+ 
+ import (
++	""errors""
++	""fmt""
++
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/archer""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/store/ssm""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/color""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/log""
++	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/term/prompt""
+ 	""github.com/aws/amazon-ecs-cli-v2/internal/pkg/workspace""
+ 	""github.com/spf13/cobra""
+ )",nit: Is this error message accurate?,Nit: I think this should be grouped with the other `github.com/aws` impo
+8894,"@@ -4269,7 +4269,7 @@ import_one_object_direct (OstreeRepo    *dest_repo,
+         G_IN_SET (src_repo->mode, OSTREE_REPO_MODE_BARE, OSTREE_REPO_MODE_BARE_USER);
+       if (src_is_bare_or_bare_user && !OSTREE_OBJECT_TYPE_IS_META(objtype))
+         {
+-          if (src_repo == OSTREE_REPO_MODE_BARE)
++          if (src_repo->mode == OSTREE_REPO_MODE_BARE)
+             {
+               g_autoptr(GVariant) xattrs = NULL;
+               if (!glnx_fd_get_all_xattrs (src_fd, &xattrs,","Ouch! :man_facepalming: And of course, this worked for me because that evaluated to false when I was testing the bare-user path.",Why this change?
+8895,"@@ -380,7 +380,10 @@ func (c *FCGIClient) Request(p map[string]string, req io.Reader) (resp *http.Res
+ 		if err != nil {
+ 			return
+ 		}
+-		resp.Status = statusParts[1]
++		if (len(statusParts) > 0) {
++			resp.Status = statusParts[1]	
++		}
++		
+ 	} else {
+ 		resp.StatusCode = http.StatusOK
+ 	}",Parentheses aren't needed here. `if len(statusParts) > 0 {` will suffice.,Why is this needed?
+8896,"@@ -44,9 +44,10 @@ const serverName = ""yarpc-test""
+ 
+ // TT is the gauntlets table test struct
+ type TT struct {
+-	Service  string // thrift service name; defaults to ThriftTest
+-	Function string // name of the Go function on the client
+-	Oneway   bool   // if the function is a oneway function
++	Service       string   // thrift service name; defaults to ThriftTest
++	Function      string   // name of the Go function on the client
++	Oneway        bool     // if the function is a oneway function
++	SkipOnServers []string // if the test needs to be skipped on particular server
+ 
+ 	Details string        // optional extra details about what this test does
+ 	Give    []interface{} // arguments besides context",// the test is skipped on given servers because it will fail.,nit: `SkipOnServers` -> `SkipServers`
+8897,"@@ -220,8 +220,7 @@ describe 'OrganizationsController' do
+ 
+     it 'should return unauthorized if api key is invalid' do
+       get :index, format: :xml, api_key: 'dummy_id'
+-
+-      must_respond_with :unauthorized
++      must_respond_with :bad_request
+     end
+   end
+ ","The name of the test should be updated to ""it 'should return bad_request if api key is invalid""",Prefer double-quoted strings unless y
+8898,"@@ -806,6 +806,12 @@ class _HyperSearchRunner(object):
+ 
+     # pull out best Model from jobs table
+     jobInfo = _clientJobsDB().jobInfo(hyperSearchJob.getJobID())
++
++    # Try to return a decent error message if the job was cancelled for some
++    # reason.
++    if jobInfo.cancel is 1:
++      raise Exception(jobInfo.workerCompletionMsg)
++
+     try:
+       results = json.loads(jobInfo.results)
+     except Exception, e:",Use `==` in this case instead of `is`.,I don't think this is the right place
+8899,"@@ -53,6 +53,7 @@ type CStorPoolAttr struct {
+ 	OverProvisioning bool   `json:""overProvisioning""` //true or false
+ }
+ 
++// CStorPoolPhase is a CStorPool phase.
+ type CStorPoolPhase string
+ 
+ // Status written onto CStorPool and CStorVolumeReplica objects.",Please put it like this: `CStorPoolPhase is a typed string for phase field of CStorPool`,type CStorVolumeReplica struct {
+8900,"@@ -222,13 +222,15 @@ class Order extends BaseAction implements EventSubscriberInterface
+             $pse = $cartItem->getProductSaleElements();
+ 
+             /* check still in stock */
+-            if ($cartItem->getQuantity() > $pse->getQuantity()) {
++            if ($cartItem->getQuantity() > $pse->getQuantity() && true === ConfigQuery::checkAvailableStock()) {
+                 throw new TheliaProcessException(""Not enough stock"", TheliaProcessException::CART_ITEM_NOT_ENOUGH_STOCK, $cartItem);
+             }
+ 
+             /* decrease stock */
++            $newStock = $pse->getQuantity() - $cartItem->getQuantity();
++            if($newStock < 0) $newStock = 0; //Forbid negative stock
+             $pse->setQuantity(
+-                    $pse->getQuantity() - $cartItem->getQuantity()
++                    $newStock
+             );
+             $pse->save($con);
+ ",variable must be in camelCase => $newStock,Why do you need to check if it is available?
+8901,"@@ -73,7 +73,7 @@ func setActionFlags(cmds ...*cobra.Command) {
+ 
+ func sendAction(elp action.Envelope) string {
+ 	fmt.Printf(""Enter password #%s:\n"", signer)
+-	bytePassword, err := terminal.ReadPassword(syscall.Stdin)
++	bytePassword, err := terminal.ReadPassword(int(syscall.Stdin))
+ 	if err != nil {
+ 		log.L().Error(""fail to get password"", zap.Error(err))
+ 		return err.Error()",unnecessary conversion (from `unconvert`),Why is this cast needed?
+8902,"@@ -345,6 +345,18 @@ final class BitMappedTrie<T> implements Serializable {
+         return index;
+     }
+ 
++    Object[] toArray() {
++        final Object[] results = new Object[length];
++        visit((index, leaf, start, end) -> {
++            final int copied = end - start;
++            for (int i = start; i < end; i++) {
++                results[index + i] = type.getAt(leaf, i);
++            }
++            return index + copied;
++        });
++        return results;
++    }
++
+     int length() { return length; }
+ }
+ ","... is probably automatically vectorized, since it has the same speed as `System.arraycopy`",Why is this needed?
+8903,"@@ -15,9 +15,19 @@
+ 
+ package engine
+ 
++import (
++	""github.com/aws/amazon-ecs-agent/agent/resources/cgroup""
++	""github.com/cihub/seelog""
++	""github.com/pkg/errors""
++)
++
++// control is used to manipulate cgroups and ease testing
++var control cgroup.Control
++
+ // SetupPlatformResources sets up platform level resources
+ func (mtask *managedTask) SetupPlatformResources() error {
+ 	if mtask.Task.CgroupEnabled() {
++		setControl(cgroup.New())
+ 		return mtask.setupCgroup()
+ 	}
+ 	return nil","Is there anyway to get rid of the global variable, if it is specific for each task, can you add it to the `mtask` struct?",Why do we need this?
+8904,"@@ -77,12 +77,12 @@ func TestDeserializeFromFlatBuffer(t *testing.T) {
+ 		{
+ 			name:     ""simple unary expr"",
+ 			fbFn:     getUnaryOpFlatBuffer,
+-			polyType: `forall [] float`,
++			polyType: `float`,
+ 		},
+ 		{
+ 			name:     ""function expression"",
+ 			fbFn:     getFnExprFlatBuffer,
+-			polyType: `forall [t0, t1] (a: t0, <-b: t1, ?c: int) -> int`,
++			polyType: `(a: A, <-b: B, ?c: int) => int`,
+ 		},
+ 	}
+ ","Surprised to see this old syntax here, but not _that_ surprised.",Why did you change this?
+8905,"@@ -164,9 +164,16 @@ abstract class AbstractQueue<T, Q extends AbstractQueue<T, Q>> implements Traver
+         return Collections.removeAll((Q) this, elements);
+     }
+ 
+-    @SuppressWarnings(""unchecked"")
++    @Deprecated
+     public Q removeAll(Predicate<? super T> predicate) {
+-        return Collections.removeAll((Q) this, predicate);
++        Objects.requireNonNull(predicate, ""predicate is null"");
++        return reject(predicate);
++    }
++
++    @SuppressWarnings(""unchecked"")
++    @Override
++    public Q reject(Predicate<? super T> predicate) {
++        return Collections.reject((Q) this, predicate);
+     }
+ 
+     @Override",It is good to mark it! Maybe we can remove the method for Vavr 1.0.0 - but for now it can stay as-is. Thx!,Why do we need to deprec
+8906,"@@ -15,11 +15,12 @@
+ package pool
+ 
+ import (
++	""errors""
+ 	""sync""
+-	""time""
+ 
+ 	""github.com/golang/glog""
+-	""github.com/openebs/maya/pkg/util""
++	col ""github.com/openebs/maya/cmd/maya-exporter/app/collector""
++	types ""github.com/openebs/maya/pkg/exec""
+ 	zpool ""github.com/openebs/maya/pkg/zpool/v1alpha1""
+ 	""github.com/prometheus/client_golang/prometheus""
+ )","exported func New returns unexported type *pool.pool, which can be annoying to use",I don't think we need th
+8907,"@@ -17,7 +17,7 @@ module BoltSpec
+ 
+     # Nothing on the executor is 'public'
+     class MockExecutor
+-      attr_reader :noop, :error_message, :in_parallel
++      attr_reader :noop, :error_message, :in_parallel, :transports
+       attr_accessor :run_as, :transport_features, :execute_any_plan
+ 
+       def initialize(modulepath)","Sorry, I feel like I'm missing something - where does this get called?",Why is this needed?
+8908,"@@ -423,12 +423,9 @@ func (e *edged) syncNodeStatus() {
+ 			klog.Errorf(""Register node failed: %v"", err)
+ 			return
+ 		}
+-		if err := e.updateNodeStatus(); err != nil {
+-			klog.Errorf(""Unable to update node status: %v"", err)
+-		}
+-	} else {
+-		if err := e.updateNodeStatus(); err != nil {
+-			klog.Errorf(""Unable to update node status: %v"", err)
+-		}
++	}
++
++	if err := e.updateNodeStatus(); err != nil {
++		klog.Errorf(""Unable to update node status: %v"", err)
+ 	}
+ }","@guihecheng Thanks for the fixing! Actually this is not the dup codes, when we first registerNode, then update the nodestatus immediately, or the node will keep not ready for 10s. And do you have other ways to refactor it?",Why did you remove the else?
+8909,"@@ -14,6 +14,7 @@
+ 
+ #include ""SystemInfo.hpp""
+ 
++#include <sys/stat.h>
+ #ifdef _WIN32
+ #include <windows.h>
+ #else","How portable is this? (e.g., Windows). I'm relaunching tests of windows because they failed for other reasons.",#include <sys/stat.h>
+8910,"@@ -7498,10 +7498,13 @@ static void UpdateStateCmdDrawType(layer_data *dev_data, GLOBAL_CB_NODE *cb_stat
+     cb_state->hasDrawCmd = true;
+ 
+     // Add descriptor image/CIS layouts to CB layout map
+-    auto &desc_sets = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets;
+-    for (auto &desc : desc_sets) {
+-        if (desc) {
+-            desc->UpdateDSImageLayoutState(cb_state);
++    PIPELINE_STATE *pPipe = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].pipeline_state;
++
++    for (const auto &set_binding_pair : pPipe->active_slots) {
++        uint32_t setIndex = set_binding_pair.first;
++        auto &desc_set = cb_state->lastBound[VK_PIPELINE_BIND_POINT_GRAPHICS].boundDescriptorSets[setIndex];
++        if (desc_set) {
++            desc_set->UpdateDSImageLayoutState(cb_state);
+         }
+     }
+ }","What this does is narrow down what we are saying the descriptor set is requiring. This is a good thing, but doesn't go far enough, we are still potentially setting unused bindings to either a required state or an invalid one. set_binding_pair.second is a map of the binding/requirements from the bound shaders... and instead of marking all bindings, looking at that will mark only the used ones. Will open a new PR",nit: `setIndex` -> `index`
+8911,"@@ -1038,11 +1038,10 @@ func (core *coreService) BlockMetas(start uint64, count uint64) ([]*iotextypes.B
+ 
+ 	var (
+ 		tipHeight = core.bc.TipHeight()
+-		res       []*iotextypes.BlockMeta
++		res       = make([]*iotextypes.BlockMeta, 0)
+ 	)
+ 	if start > tipHeight {
+-		log.L().Debug(""err in BlockMetas()"", zap.Error(status.Error(codes.InvalidArgument, ""start height should not exceed tip height"")))
+-		return nil, nil
++		return nil, status.Error(codes.NotFound, ""start height should not exceed tip height"")
+ 	}
+ 	for height := start; height <= tipHeight && count > 0; height++ {
+ 		blockMeta, err := core.getBlockMetaByHeight(height)","should use `codes.InvalidArgument`, same as above line 1033 and 1036",Why not return an error?
+8912,"@@ -51,7 +51,7 @@ func getAgentVersions() []DockerVersion {
+ 	return append(getWindowsReplaceableVersions(), MinDockerAPIWindows)
+ }
+ 
+-// getDefaultVersion returns agent's default version of the Docker API
++// GetDefaultVersion returns agent's default version of the Docker API
+ func getDefaultVersion() DockerVersion {
+ 	return MinDockerAPIWindows
+ }",Please revert this file.,I think this should be called `GetDefaultDockerVersion`
+8913,"@@ -18,10 +18,13 @@
+ //
+ // URLs
+ //
+-// For pubsub.OpenTopic/Subscription URLs, azurepubsub registers for the scheme
+-// ""azuresb"". The Service Bus Connection String defaults to the environment
+-// variable ""SERVICEBUS_CONNECTION_STRING"". For details on the format of the
+-// URL, see URLOpener.
++// For pubsub.OpenTopic and pubsub.OpenSubscription, azurepubsub registers
++// for the scheme ""azuresb"".
++// The default URL opener will use a Service Bus Connection String based on
++// the environment variable ""SERVICEBUS_CONNECTION_STRING"".
++// To customize the URL opener, or for more details on the URL format,
++// see URLOpener.
++// See https://godoc.org/gocloud.dev#hdr-URLs for background information.
+ //
+ // As
+ //","Probably in another PR, I think the package should be renamed to `servicebus` to be consistent.",I don't think we need to mention this in the README.md
+8914,"@@ -557,7 +557,7 @@ namespace AutoRest.Core.Properties {
+         }
+         
+         /// <summary>
+-        ///   Looks up a localized string similar to A swagger must have security definitions and must adhere to the specific structure..
++        ///   Looks up a localized string similar to Every swagger/configuration must have a security definitions section and it must adhere to the structure described in: https://github.com/Azure/autorest/tree/master/docs/developer/validation-rules/security-definitions-structure-validation.md.
+         /// </summary>
+         public static string SecurityDefinitionsStructureValidation {
+             get {",curious: are we planning to add link to each of the rules in the message?,///   Looks up a localized string similar to Every swag
+8915,"@@ -248,6 +248,11 @@ func (exp *MockExplorer) GetDeposits(subChainID int64, offset int64, limit int64
+ 	return nil, nil
+ }
+ 
++// SettleDeposit settles deposit on sub-chain
++func (exp *MockExplorer) SettleDeposit(req explorer.SettleDepositRequest) (res explorer.SettleDepositResponse, err error) {
++	return explorer.SettleDepositResponse{}, nil
++}
++
+ func randInt64() int64 {
+ 	rand.Seed(time.Now().UnixNano())
+ 	amount := int64(0)",line is 123 characters,Why do we need this?
+8916,"@@ -69,7 +69,7 @@ class AuthorizationService extends AbstractAuthenticationService
+      * whether a user is authenticated.
+      *
+      * @see \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::checkAuthentication()
+-     * @param array Array of user data
++     * @param array $user of user data
+      * @return int Returns 200 to grant access for the page indexer.
+      */
+     public function authUser($user)",same here; `@param array $user Array of user data`,Why did you change this?
+8917,"@@ -21,7 +21,7 @@ func TestString(t *testing.T) {
+ 					b.Append(""a"")
+ 				}
+ 			},
+-			sz: 256,
++			sz: 0,
+ 			want: []interface{}{
+ 				""a"", ""a"", ""a"", ""a"", ""a"",
+ 				""a"", ""a"", ""a"", ""a"", ""a"",","A quick read of this test indicates that we're changing the behavior of this api, and so the test needs updating. Is that right?",Why did this change?
+8918,"@@ -5,13 +5,13 @@
+ using System;
+ using Android.Content;
+ using Android.Runtime;
+-using Android.Support.V7.Widget;
++using AndroidX.RecyclerView.Widget;
+ using Java.Lang;
+ using MvvmCross.Logging;
+ 
+-namespace MvvmCross.Droid.Support.V7.RecyclerView
++namespace MvvmCross.DroidX.RecyclerView
+ {
+-    [Register(""mvvmcross.droid.support.v7.recyclerview.MvxGuardedLinearLayoutManager"")]
++    [Register(""mvvmcross.DroidX.recyclerview.MvxGuardedLinearLayoutManager"")]
+     public class MvxGuardedLinearLayoutManager : LinearLayoutManager
+     {
+         public MvxGuardedLinearLayoutManager(Context context) : base(context)",Register needs lowercasing,I don't think this is ne
+8919,"@@ -134,6 +134,9 @@ public class Constants {
+   public static final String EXECUTION_SOURCE_SCHEDULED = ""schedule"";
+   public static final String EXECUTION_SOURCE_EVENT = ""event"";
+ 
++  // Should validate proxy user
++  public static final boolean DEFAULT_VALIDATE_PROXY_USER = false;
++
+   public static class ConfigurationKeys {
+ 
+     public static final String AZKABAN_CLUSTER_NAME = ""azkaban.cluster.name"";",This should belong to FlowContainer class.,Why do we need this?
+8920,"@@ -412,7 +412,10 @@ class NVDAHighlighter(providerBase.VisionEnhancementProvider):
+ 		window = self.window = self.customWindowClass(self)
+ 		self.timer = winUser.WinTimer(window.handle, 0, self._refreshInterval, None)
+ 		msg = MSG()
+-		while winUser.getMessage(byref(msg), None, 0, 0):
++		# Python 3.8 note, Change this to use an Assignment expression to catch a return value of -1.
++		# See the remarks section of
++		# https://docs.microsoft.com/en-us/windows/win32/api/winuser/nf-winuser-getmessage
++		while winUser.getMessage(byref(msg), None, 0, 0) > 0:
+ 			winUser.user32.TranslateMessage(byref(msg))
+ 			winUser.user32.DispatchMessageW(byref(msg))
+ 		if vision._isDebug():","I think there is a chance that on disable/enable cycling, referring to `self.window` is problematic. In the `__init__` method `self.window` is set to None. If `__init__` gets called before `_run` exits the `while` loop then we wont call `self.window.destroy()`. Can you use non-instance variables after this point? I don't think `self.timer` is used outside this function, if so, then I'd prefer it also be a local variable.","I don't think this is the right way to go about this. I think it should be `while winUser.getMessage(byref(msg), None, 0, -1) > 0:`"
+8921,"@@ -216,6 +216,12 @@ func TestConfigCommandInteractiveCreateDocrootDenied(t *testing.T) {
+ 	// Set up tests and give ourselves a working directory.
+ 	assert := asrt.New(t)
+ 
++	noninteractive := ""DRUD_NONINTERACTIVE""
++	// nolint: errcheck
++	defer os.Setenv(noninteractive, os.Getenv(noninteractive))
++	err := os.Unsetenv(noninteractive)
++	assert.NoError(err)
++
+ 	testMatrix := map[string][]string{
+ 		""drupal6phpversion"": {AppTypeDrupal6, PHP56},
+ 		""drupal7phpversion"": {AppTypeDrupal7, PHP71},","I was confused by this env name variable, assuming it was the value, not the name. Silly nit, but maybe name it noninteractiveEnv?",I think this should be `assert.NoError(os.Unsetenv(noninteractive))`
+8922,"@@ -56,9 +56,15 @@ public class TableProperties {
+   public static final String PARQUET_COMPRESSION = ""write.parquet.compression-codec"";
+   public static final String PARQUET_COMPRESSION_DEFAULT = ""gzip"";
+ 
++  public static final String PARQUET_WRITE_MODE = ""write.parquet.write-mode"";
++  public static final String PARQUET_WRITE_MODE_DEFAULT = ""overwrite"";
++
+   public static final String AVRO_COMPRESSION = ""write.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";
+ 
++  public static final String AVRO_WRITE_MODE = ""write.avro.write-mode"";
++  public static final String AVRO_WRITE_MODE_DEFAULT = ""overwrite"";
++
+   public static final String SPLIT_SIZE = ""read.split.target-size"";
+   public static final long SPLIT_SIZE_DEFAULT = 134217728; // 128 MB
+ ","  nice, having the ""overwrite"" default makes this change backwards compatible, right?",Why do we need this?
+8923,"@@ -108,7 +108,7 @@ public class DefaultReactiveOAuth2UserService implements ReactiveOAuth2UserServi
+ 					authenticationMethod);
+ 			// @formatter:off
+ 			Mono<Map<String, Object>> userAttributes = requestHeadersSpec.retrieve()
+-					.onStatus((s) -> s != HttpStatus.OK, (response) ->
++					.onStatus((s) -> !s.is2xxSuccessful(), (response) ->
+ 						parse(response)
+ 							.map((userInfoErrorResponse) -> {
+ 								String description = userInfoErrorResponse.getErrorObject().getDescription();","It doesn't make sense to accept all 2xx status code. For example, `203 Non-Authoritative Information` or `205 Reset Content`, etc.",Why is this change needed?
+8924,"@@ -385,16 +385,8 @@ class SplitOp implements CoreAdminHandler.CoreAdminOp {
+ 
+       // compare to current prefix bucket and see if this new term shares the same prefix
+       if (term != null && term.length >= currPrefix.length && currPrefix.length > 0) {
+-        int i = 0;
+-        for (; i < currPrefix.length; i++) {
+-          if (currPrefix.bytes[i] != term.bytes[term.offset + i]) {
+-            break;
+-          }
+-        }
+-
+-        if (i == currPrefix.length) {
+-          // prefix was the same (common-case fast path)
+-          // int count = termsEnum.docFreq();
++        BytesRef termPrefix = new BytesRef(term.bytes, term.offset, currPrefix.length);
++        if (termPrefix.bytesEquals(currPrefix)) {
+           bucketCount++;  // use 1 since we are dealing with unique ids
+           continue;
+         }",Found a better choice here that doesn't involve object creation: StringHelper.startsWith(),can we use `BytesRef.bytesEqual` here?
+8925,"@@ -250,8 +250,15 @@ func (s *nodeServer) attest(
+ 	attestedData *common.AttestedData, attestedBefore bool) (
+ 	response *nodeattestor.AttestResponse, err error) {
+ 
+-	// TODO: Pick the right node attestor [#222]
+-	nodeAttestor := s.catalog.NodeAttestors()[0]
++	// Pick the right node attestor
++	var nodeAttestor nodeattestor.NodeAttestor
++	for _, a := range s.catalog.NodeAttestors() {
++		mp := s.catalog.Find(a)
++		if mp.Config.PluginName == attestedData.Type {
++			nodeAttestor = a
++			break
++		}
++	}
+ 
+ 	attestRequest := &nodeattestor.AttestRequest{
+ 		AttestedData:   attestedData,",Shouldn't we consider the situation where it doesn't find a plugin?,Why not just use `mp.Config.PluginName
+8926,"@@ -24,7 +24,12 @@ namespace oneapi::dal::csv {
+ template <>
+ class detail::v1::read_args_impl<table> : public base {
+ public:
+-    read_args_impl() {}
++    read_args_impl(preview::read_mode mode = preview::read_mode::table) : mode(mode) {
++        if (mode != preview::read_mode::table)
++            throw invalid_argument(dal::detail::error_messages::unsupported_read_mode());
++    }
++
++    preview::read_mode mode;
+ };
+ 
+ namespace v1 {",Do not understand why this needed for table. All new classes defined in the `preview` namespace.,Why do we need this?
+8927,"@@ -17,6 +17,8 @@
+ package com.yahoo.athenz.common.server.notification;
+ 
+ public final class NotificationServiceConstants {
++    public static final String NOTIFICATION_PROP_SERVICE_FACTORY_CLASS = ""athenz.zms.notification_service_factory_class"";
++
+     public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL           = ""MEMBERSHIP_APPROVAL"";
+     public static final String NOTIFICATION_TYPE_MEMBERSHIP_APPROVAL_REMINDER  = ""MEMBERSHIP_APPROVAL_REMINDER"";
+     public static final String NOTIFICATION_TYPE_PRINCIPAL_EXPIRY_REMINDER     = ""PRINCIPAL_EXPIRY_REMINDER"";",Kept the same property value even though it is now in Common to avoid breaking existing clients.,Why is this needed?
+8928,"@@ -52,7 +52,7 @@ public class InclusiveMetricsEvaluator {
+     return visitors.get();
+   }
+ 
+-  InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
++  public InclusiveMetricsEvaluator(Schema schema, Expression unbound) {
+     this(schema, unbound, true);
+   }
+ ",TODO: this is temporary until we figure out case sensitivity for metrics evaluators.,Why is this needed?
+8929,"@@ -503,9 +503,10 @@ func (node *Node) Start(ctx context.Context) error {
+ 		// TODO it is possible the syncer interface should be modified to
+ 		// make use of the additional context not used here (from addr + height).
+ 		// To keep things simple for now this info is not used.
+-		err := node.Syncer.HandleNewBlocks(context.Background(), cids)
++		cidSet := types.NewSortedCidSet(cids...)
++		err := node.Syncer.HandleNewTipset(context.Background(), cidSet)
+ 		if err != nil {
+-			log.Infof(""error handling blocks: %s"", types.NewSortedCidSet(cids...).String())
++			log.Infof(""error handling blocks: %s"", cidSet.String())
+ 		}
+ 	}
+ 	node.HelloSvc = hello.New(node.Host(), node.ChainReader.GenesisCid(), syncCallBack, node.ChainReader.Head, node.Repo.Config().Net, flags.Commit)",can we just kill this TODO?,Why do we need to s
+8930,"@@ -33,7 +33,7 @@ func TestDAGGet(t *testing.T) {
+ 		dag := NewDAG(dserv)
+ 
+ 		_, err := dag.GetNode(ctx, ""awful"")
+-		assert.EqualError(t, err, ""invalid 'ipfs ref' path"")
++		assert.EqualError(t, err, ""invalid path \""awful\"": selected encoding not supported"")
+ 	})
+ 
+ 	t.Run(""ILPD node not found results in error"", func(t *testing.T) {",This appears to be a change in error handling due to a dag upgrade.,Why did this change
+8931,"@@ -246,7 +246,9 @@ module Beaker
+           end
+ 
+           it 'calls beaker-hostgenerator to get hosts information' do
+-            parser.instance_variable_set( :@options, {} )
++            parser.instance_variable_set( :@options, {
++              :hosts_file => 'notafile.yml'
++            } )
+             allow( Beaker::Options::HostsFileParser ).to receive(
+               :parse_hosts_file
+             ).and_raise( Errno::ENOENT )",These changes look like a hosts file _must_ be provided?,I think this should
+8932,"@@ -92,8 +92,9 @@ int FixPythonInvoke::setmask()
+ void FixPythonInvoke::end_of_step()
+ {
+   PyUtils::GIL lock;
++  char fmt[] = ""O"";
+ 
+-  PyObject * result = PyObject_CallFunction((PyObject*)pFunc, ""O"", (PyObject*)lmpPtr);
++  PyObject * result = PyObject_CallFunction((PyObject*)pFunc, fmt, (PyObject*)lmpPtr);
+ 
+   if (!result) {
+     PyUtils::Print_Errors();","@akohlmey Just make it a cast like the others. I dislike it either way, but that's the price we pay for Python 2 support.",I don't think this is a good idea. I think it's better to use `std::string` instead.
+8933,"@@ -68,6 +68,7 @@ program
+   .option('--disable_brave_extension', 'disable loading the Brave extension')
+   .option('--disable_pdfjs_extension', 'disable loading the PDFJS extension')
+   .option('--enable_brave_update', 'enable brave update')
++  .option('--channel <target_chanel>', 'target channel to start', /^(beta|dev|nightly|release)$/i, 'release')
+   .arguments('[build_config]')
+   .action(start)
+ ",I wonder if the default here should be nightly? I won't block on that though just a question for a follow up.,".option('--channel', 'target channel to start', /^(beta|dev|nightly|release)$/i, 're"
+8934,"@@ -181,7 +181,7 @@ namespace TestRunner
+             Application.SetUnhandledExceptionMode(UnhandledExceptionMode.CatchException);
+             Application.ThreadException += ThreadExceptionEventHandler;
+ 
+-            Console.OutputEncoding = Encoding.UTF8;  // So we can send Japanese to SkylineTester, which monitors our stdout
++            //Console.OutputEncoding = Encoding.UTF8;  // So we can send Japanese to SkylineTester, which monitors our stdout
+ 
+             // Parse command line args and initialize default values.
+             const string commandLineOptions =",Also not for merge to master.,Is this intentional?
+8935,"@@ -201,6 +201,10 @@ class ScheduleDefinition:
+             raise DagsterInvalidDefinitionError(
+                 f""Found invalid cron schedule '{self._cron_schedule}' for schedule '{name}''.""
+             )
++        if len(self._cron_schedule.split("" "")) != 5:
++            raise DagsterInvalidDefinitionError(
++                f""Found non-standard cron schedule '{self._cron_schedule}' for schedule '{name}''.""
++            )
+ 
+         if job is not None:
+             self._target: Union[DirectTarget, RepoRelativeTarget] = DirectTarget(job)","nit `non-standard` might be a bit subjective - maybe ""Cron schedule {blah} is in an unrecognized format. Dagster cron strings must consist of five characters separated by a single space chacater"".","Shouldn't this be `len(self._cron_schedule.split("" "")) == 6`?"
+8936,"@@ -163,7 +163,6 @@ public class ServerPickerActivityTest {
+             openCustomEditDialog();
+         }
+         setText(com.salesforce.androidsdk.R.id.sf__picker_custom_label, label);
+-        clickView(com.salesforce.androidsdk.R.id.sf__picker_custom_url);
+         setText(com.salesforce.androidsdk.R.id.sf__picker_custom_url, url);
+     }
+ ",ARM emulator gets tripped up on the copy/paste menu when tapping the text. Tapping on the text field isn't necessary for setting text.,Why was this removed?
+8937,"@@ -68,11 +68,12 @@ public class SpellChecker {
+     }
+ 
+     char[] wordChars = word.toCharArray();
+-    if (dictionary.isForbiddenWord(wordChars, wordChars.length)) {
+-      return false;
++    Boolean simpleResult = checkSimpleWord(wordChars, wordChars.length, null);
++    if (simpleResult != null) {
++      return simpleResult;
+     }
+ 
+-    if (checkWord(wordChars, wordChars.length, null)) {
++    if (checkCompounds(wordChars, wordChars.length, null)) {
+       return true;
+     }
+ ",extra word lookup removed,Shouldn't this be `ch
+8938,"@@ -520,6 +520,12 @@ webdriver.WebDriver.prototype.call = function(fn, opt_scope, var_args) {
+  * Schedules a command to wait for a condition to hold, as defined by some
+  * user supplied function. If any errors occur while evaluating the wait, they
+  * will be allowed to propagate.
++ *
++ * <p>In the event a condition returns a Promise, the polling loop will wait 
++ * for it to be resolved and use the resolved value for evaluating whether the
++ * condition has been satisfied. The resolution time for a promise is factored
++ * into whether a wait has timed out.
++ *
+  * @param {function():boolean} fn The function to evaluate as a wait condition.
+  * @param {number} timeout How long to wait for the condition to be true.
+  * @param {string=} opt_message An optional message to use if the wait times",Will you link to {!webdriver.promise.Promise} here?,I don't think this is
+8939,"@@ -45,6 +45,7 @@ Workshops::Application.routes.draw do
+     resources :licenses, only: [:create]
+   end
+   get '/products/:id/purchases/:lookup' => redirect(""/purchases/%{lookup}"")
++  get '/purchases/:lookup' => 'pages#show', id: 'purchase-show'
+ 
+   resources :books, only: :show, controller: 'products' do
+     resources :licenses, only: [:create]",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I don't think you nee
+8940,"@@ -96,11 +96,10 @@ public class DataService extends IntentService {
+                 ObjectivesPlugin.bgIsAvailableInNS = true;
+                 ObjectivesPlugin.saveProgress();
+             } else if (isNSProfile && Intents.ACTION_NEW_PROFILE.equals(action)){
+-                // always handle Profili if NSProfile is enabled without looking at nsUploadOnly
++                // always handle Profile if NSProfile is enabled without looking at nsUploadOnly
+                 handleNewDataFromNSClient(intent);
+             } else if (!nsUploadOnly &&
+-                    (Intents.ACTION_NEW_PROFILE.equals(action) ||
+-                            Intents.ACTION_NEW_TREATMENT.equals(action) ||
++                    (Intents.ACTION_NEW_TREATMENT.equals(action) ||
+                             Intents.ACTION_CHANGED_TREATMENT.equals(action) ||
+                             Intents.ACTION_REMOVED_TREATMENT.equals(action) ||
+                             Intents.ACTION_NEW_STATUS.equals(action) ||",@AdrianLxM finally found some your bug too :),Why did you change this?
+8941,"@@ -1543,7 +1543,9 @@ void cvdescriptorset::ImageSamplerDescriptor::UpdateDrawState(layer_data *dev_da
+     if (iv_state) {
+         core_validation::AddCommandBufferBindingImageView(dev_data, cb_node, iv_state);
+     }
+-    SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
++    if (image_view_) {
++        SetImageViewLayout(dev_data, cb_node, image_view_, image_layout_);
++    }
+ }
+ 
+ cvdescriptorset::ImageDescriptor::ImageDescriptor(const VkDescriptorType type)",This crashed in an app using descriptor_indexing with some unbound descriptors.,Why do we need this chec
+8942,"@@ -39,14 +39,15 @@ MODULES_TO_CHECK = [
+ MODULES_NAMES = [m[1] for m in MODULES_TO_CHECK]
+ 
+ 
+-@pytest.mark.primer_stdlib
++@pytest.mark.primer
+ @pytest.mark.parametrize(
+     (""test_module_location"", ""test_module_name""), MODULES_TO_CHECK, ids=MODULES_NAMES
+ )
+-def test_lib_module_no_crash(
++def test_primer_stdlib_no_crash(
+     test_module_location: str, test_module_name: str, capsys: CaptureFixture
+ ) -> None:
+     """"""Test that pylint does not produces any crashes or fatal errors on stdlib modules""""""
++    __tracebackhide__ = True  # pylint: disable=unused-variable
+     os.chdir(test_module_location)
+     with _patch_stdout(io.StringIO()):
+         try:",I think we might want to keep these marks separate? Then we can create a new `workflow` file with 3 jobs: 1) Prime stdlib 2) Prime batch 1 of external 2) Prime batch 2 of external,Why is this needed?
+8943,"@@ -263,6 +263,13 @@ namespace MvvmCross.Droid.Support.V4
+ 			{
+ 				((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.Clear();
+ 				((Android.Support.V4.App.Fragment)fragInfo.CachedFragment).Arguments.PutAll(bundle);
++
++                var childViewModelCache = Mvx.GetSingleton<IMvxChildViewModelCache>();
++                if (childViewModelCache.Exists(fragInfo.CachedFragment.ViewModel.GetType()))
++                {
++                    fragInfo.CachedFragment.ViewModel = childViewModelCache.Get(fragInfo.CachedFragment.ViewModel.GetType());
++                    childViewModelCache.Remove(fragInfo.CachedFragment.ViewModel.GetType());
++                }
+ 			}
+ 			else
+ 			{",Throw `fragInfo.CachedFragment.ViewModel.GetType()` into a variable so it's not evaluated each time.,Shouldn't this be in a `
+8944,"@@ -189,7 +189,7 @@ class User < ActiveRecord::Base
+   end
+ 
+   def preferred_languages
+-    @preferred_languages ||= Locale.list(languages)
++    Locale.list(languages)
+   end
+ 
+   def nearby(radius = NEARBY_RADIUS, num = NEARBY_USERS)",Rather than just getting rid of the memoization maybe we should use an `after_save` filter to set it to `nil` so that it will be recomputed on next read?,Why did you remove the memoization?
+8945,"@@ -0,0 +1,3 @@
++export default function remove(el) {
++	el.parentNode && el.parentNode.removeChild(el);
++}",JS abstraction leaks so this should be `if (el.parentNode !== null) { el.parentNode.removeChild(el) }` @developit  ,
+8946,"@@ -30,6 +30,15 @@ type LedgerUSB struct {
+ 	hiddev *hid.Device
+ }
+ 
++// LedgerUSBError is a wrapper around the two-byte error code that the Ledger
++// protocol returns.
++type LedgerUSBError uint16
++
++// Error satisfies builtin interface `error`
++func (err LedgerUSBError) Error() string {
++	return fmt.Sprintf(""unexpected status %x"", err)
++}
++
+ // Protocol reference:
+ // https://github.com/LedgerHQ/blue-loader-python/blob/master/ledgerblue/comm.py (see HIDDongleHIDAPI)
+ // https://github.com/LedgerHQ/blue-loader-python/blob/master/ledgerblue/ledgerWrapper.py (see wrapCommandAPDU)",nit: change it to `Exchange: unexpected status 0x%x` so that we'll know where this issue came from as well as making it easier to decode.,Why do we need this wrapper?
+8947,"@@ -23,13 +23,7 @@ func CstorVolumeArtifactsFor070() (list ArtifactList) {
+ 	return
+ }
+ 
+-// cstorVolumeYamlsFor070 returns all the yamls related to cstor volume in a
+-// string format
+-//
+-// NOTE:
+-//  This is an implementation of MultiYamlFetcher
+-func cstorVolumeYamlsFor070() string {
+-	return `
++const cstorRunTask = `
+ ---
+ apiVersion: openebs.io/v1alpha1
+ kind: CASTemplate",Name of constant is not appropriate. Name of constant should make use of version no. as suffix. The constant can be a typed string versus a string.,nit: can we call this `cstorRunTemp
+8948,"@@ -51,6 +51,7 @@ module Bolt
+           command_options = []
+           # Need to be interactive if redirecting STDIN
+           command_options << '--interactive' unless options[:stdin].nil?
++          command_options << '--tty' if options[:tty]
+           command_options.concat(envs) unless envs.empty?
+           command_options << container_id
+           command_options.concat(command)",@glennsarti you want to validate this on Windows? IIRC this won't work,Should this be `unless options[:stdin].nil? && options[:tty]`?
+8949,"@@ -45,8 +45,11 @@ public class ZipkinElasticsearchHttpStorageAutoConfiguration {
+   ElasticsearchHttpStorage.Builder esHttpBuilder(
+       ZipkinElasticsearchHttpStorageProperties elasticsearch,
+       @Qualifier(""zipkinElasticsearchHttp"") OkHttpClient client,
+-      @Value(""${zipkin.storage.strict-trace-id:true}"") boolean strictTraceId) {
+-    return elasticsearch.toBuilder(client).strictTraceId(strictTraceId);
++      @Value(""${zipkin.storage.strict-trace-id:true}"") boolean strictTraceId,
++      @Value(""${zipkin.query.lookback:86400000}"") int namesLookback) {
++    return elasticsearch.toBuilder(client)
++        .strictTraceId(strictTraceId)
++        .namesLookback(namesLookback);
+   }
+ 
+   /** cheap check to see if we are likely to include urls */",ps I'm ok to add this as a elasticsearch property instead. ex zipkin.storage.elasticsearch.names-lookback (we have similar things in cassandra),I think this should be `zipkin.storage.names-lookback`
+8950,"@@ -69,12 +69,12 @@ class Search implements IWebSearch {
+   }
+ 
+   /**
+-   * Force a reindex.
++   * Force a re-index.
+    */
+   reindex() {
+     let self = this;
+-    this.storage.getLocalDatabase(function(err, packages) {
+-      if (err) throw err; // that function shouldn't produce any
++    this.storage.getLocalDatabase(function(error, packages) {
++      if (error) throw error; // that function shouldn't produce any
+       let i = packages.length;
+       while (i--) {
+         self.add(packages[i]);",Curly brackets here `{ (breakLine) xx (breakLine)}`,I think this should be `throw error;`
+8951,"@@ -450,6 +450,11 @@ window.ConfigurationsView = countlyView.extend({
+                     return false;
+                 }
+ 
++                if($(this).val() === countlyGlobal[""member""].username){
++                    $("".username-check"").remove();
++                    return false;
++                }
++
+                 $(this).next("".required"").remove();
+ 
+                 var existSpan = $(""<span class='username-check red-text' data-localize='management-users.username.exists'>"").html(jQuery.i18n.map[""management-users.username.exists""]),","Can you check this case Assuming you have a dashboard with 2 users, test1 and test2 Currently logged in user is test1. You should not be able to change it to test2. You open dev console and paste in `countlyGlobal[""member""].username = ""test2"";` then you enter value test2 in the input and it is allowed and form would be submitted. Would server side validation deal with such case?",Why do we need this?
+8952,"@@ -46,13 +46,14 @@ public class DataSourceFactory {
+     static final long MAX_TTL_CONN_MS = TimeUnit.MILLISECONDS.convert(10L, TimeUnit.MINUTES);
+     static final String MYSQL_VALIDATION_QUERY = ""/* ping */ SELECT 1"";
+ 
++    static final String DRIVER_CLASS_NAME = ""athenz.db.driver.class"";
+     public static PoolableDataSource create(String url, Properties mysqlConnectionProperties) {
+         
+         String driver = null;
+         try {
+             if (url.indexOf("":mysql:"") > 0) {
+                 
+-                driver = ""com.mysql.jdbc.Driver"";
++                driver = System.getProperty(DRIVER_CLASS_NAME, ""com.mysql.jdbc.Driver"");
+                 Class.forName(driver);
+                 
+                 ConnectionFactory connectionFactory =","since we're changing this class, let's fix the default class name as well. it should be com.mysql.cj.jdbc.Driver",Why is this needed?
+8953,"@@ -3,4 +3,13 @@ class Role < ActiveRecord::Base
+   has_many :proposals, through: :proposal_roles
+   has_many :user_roles
+   has_many :users, through: :user_roles
++
++  # Safely ensure that the system roles in `config/initializers/01_c2.rb`
++  # exist in the database. Rails will run this code when it loads the
++  # `Role` class at bootup.
++  def self.ensure_system_roles_exist
++    SYSTEM_ROLES.each { |r| Role.find_or_create_by!(name: r) }
++  end
++
++  ensure_system_roles_exist if connection.table_exists? ""roles""
+ end","At load time, we ensure the config'd objects exist.",I'm not sure if thi
+8954,"@@ -153,6 +153,10 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core
+                         {
+                             throw new InvalidOperationException($""HTTPS endpoints can only be configured using {nameof(KestrelServerOptions)}.{nameof(KestrelServerOptions.Listen)}()."");
+                         }
++                        else if (!parsedAddress.Scheme.Equals(""http"", StringComparison.OrdinalIgnoreCase))
++                        {
++                            throw new InvalidOperationException($""Unrecognized scheme in server address '{address}'. Only 'http://' is supported."");
++                        }
+ 
+                         if (!string.IsNullOrEmpty(parsedAddress.PathBase))
+                         {",Is there a test for this case?,I think this should
+8955,"@@ -0,0 +1,14 @@
++<section class=""topic"">
++  <header>
++    <p class=""topic-headline""><%= show.name %></p>
++  </header>
++
++  <%= render partial: ""products/videos/video"", collection: show.latest_videos %>
++
++  <figure class=""card see-more"">
++    <%= link_to show do %>
++      <h4><%= pluralize show.videos.count, ""more #{show.name} episode"" %></h4>
++      <p>View All</p>
++    <% end %>
++  </figure>
++</section>",This copy doesn't match what I had in my mockup. I think it's better to call them episodes.,This should be `sho
+8956,"@@ -135,7 +135,11 @@ func (s *server) startService() common.Daemon {
+ 	servicePortMap := make(map[string]int)
+ 	for roleName, svcCfg := range s.cfg.Services {
+ 		serviceName := getServiceName(roleName)
+-		servicePortMap[serviceName] = svcCfg.RPC.Port
++		if serviceName == common.FrontendServiceName || serviceName == common.MatchingServiceName {
++			servicePortMap[serviceName] = svcCfg.RPC.GRPCPort
++		} else {
++			servicePortMap[serviceName] = svcCfg.RPC.Port
++		}
+ 	}
+ 
+ 	params.MembershipFactory, err = s.cfg.Ringpop.NewFactory(",For some reason it worked for frontend even before this change.,Why do we need this change?
+8957,"@@ -666,7 +666,10 @@ TEST (block_store, large_iteration)
+ 	{
+ 		auto transaction (store.tx_begin (true));
+ 		nano::account account;
+-		nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
++		{
++			std::lock_guard<std::mutex> lk (nano::random_pool_mutex);
++			nano::random_pool.GenerateBlock (account.bytes.data (), account.bytes.size ());
++		}
+ 		accounts1.insert (account);
+ 		store.account_put (transaction, account, nano::account_info ());
+ 	}",Can we encapsulate this in a function so if we want to change it against we don't have to change all call sites?,Why do we need a lock here?
+8958,"@@ -470,8 +470,8 @@ void nano::bulk_pull_client::received_block (boost::system::error_code const & e
+ 				connection->start_time = std::chrono::steady_clock::now ();
+ 			}
+ 			connection->attempt->total_blocks++;
+-			total_blocks++;
+ 			bool stop_pull (connection->attempt->process_block (block, known_account, total_blocks, block_expected));
++			total_blocks++;
+ 			if (!stop_pull && !connection->hard_stop.load ())
+ 			{
+ 				/* Process block in lazy pull if not stopped","Maybe a good opportunity to do a related improvement: The parameter `total_blocks` in `bootstrap_attempt::process_block` shadows a field with the same name, so maybe rename the parameter to `total_blocks_a` The parameter and field are incremented at the same time, but the field is used by `populate_connections` as well, so I assume they mean different things. Other than that, LGTM",Why this change?
+8959,"@@ -9,6 +9,8 @@
+ 
+ DEFINE_int32(default_parts_num, 100, ""The default number of parts when a space is created"");
+ DEFINE_int32(default_replica_factor, 1, ""The default replica factor when a space is created"");
++DEFINE_int32(default_space_sum, 100, ""The default number of space can be created"");
++DEFINE_int32(default_max_replica_factor, 1, ""The default max replica factor that a space can take"");
+ 
+ namespace nebula {
+ namespace meta {",Please revise the naming of these two flags. _**default**_ is the value we take when user doesn't provide. You could infer from the fact how `default_parts_num` are used.,DEFINE_int32(default_min_re
+8960,"@@ -24,12 +24,13 @@ import java.util.Map;
+ import java.util.Set;
+ import java.util.TreeSet;
+ 
+-public class ImportTypeTransformer {
++public class ImportTypeTransformer implements ImportGenerator {
+   private enum ImportFileType {
+     SERVICE_FILE,
+     PROTO_FILE
+   }
+ 
++  @Override
+   public List<ImportTypeView> generateImports(Map<String, TypeAlias> imports) {
+     List<ImportTypeView> generatedImports = new ArrayList<>();
+     for (String key : imports.keySet()) {","I don't think we should have separate ""transformer"" and ""generator"" terms. I would suggest renaming this existing class `ImportTypeTransformer` to `StandardImportTypeTransformer` and renaming the interface `ImportGenerator` to `ImportTypeTransformer`.",Why is this needed?
+8961,"@@ -1,4 +1,4 @@
+ export { default as getContainers } from './get-containers';
+ export { default as isValidAccountID } from './is-valid-account-id';
+ export { default as isValidContainerID } from './is-valid-container-id';
+-export { default as tagMatchers } from './tag-matchers';
++export { default as tagMatchers } from './tagMatchers';","I believe `tag-matchers` is the proper form for this filename. Only components should use pascal case, I believe everything else should continue to use kabob-case.",I think we should r
+8962,"@@ -19,6 +19,7 @@ package pubsub
+ import (
+ 	""context""
+ 	""fmt""
++	""github.com/google/knative-gcp/pkg/apis/duck/v1alpha1""
+ 
+ 	pubsubsourcev1alpha1 ""github.com/google/knative-gcp/pkg/apis/pubsub/v1alpha1""
+ 	pubsubsourceclientset ""github.com/google/knative-gcp/pkg/client/clientset/versioned""","same here, move this one down","""github.com/google/"
+8963,"@@ -112,6 +112,7 @@ class OrderDataFixture extends AbstractReferenceFixture implements DependentFixt
+         $orderData->domainId = Domain::FIRST_DOMAIN_ID;
+         $orderData->currency = $this->getReference(CurrencyDataFixture::CURRENCY_CZK);
+         $orderData->createdAt = $this->faker->dateTimeBetween('-1 week', 'now');
++        $orderData->createdAsAdministrator = $this->getReference(AdministratorDataFixture::ADMINISTRATOR);
+         $this->createOrder(
+             $orderData,
+             [","Some could be created as superadmin instead, to add more special cases. Also, the reason behind this change should be described in the commit msg and the PR description.",Shouldn't this be `
+8964,"@@ -28,6 +28,7 @@ from pyspark.sql import functions as F
+ from pyspark.sql.types import FloatType, DoubleType, LongType, StructType, TimestampType, \
+     to_arrow_type
+ 
++from databricks import koalas as ks
+ from databricks.koalas.dask.utils import derived_from
+ from databricks.koalas.frame import DataFrame
+ from databricks.koalas.generic import _Frame, max_display_count",Is this required?,from pyspark.sql.types import *
+8965,"@@ -483,9 +483,10 @@ func start(c *cli.Context) error {
+ 			Cluster:       cm,
+ 			StoragePolicy: sp,
+ 			Security: &sdk.SecurityConfig{
+-				Role:           rm,
+-				Tls:            tlsConfig,
+-				Authenticators: authenticators,
++				Role:                         rm,
++				Tls:                          tlsConfig,
++				Authenticators:               authenticators,
++				PublicVolumeCreationDisabled: !c.Bool(""public-volume-create-allowed""),
+ 			},
+ 		})
+ 		if err != nil {","`--public-volume-create-allowed=true` and set the default to `true`, then use `!c.Bool('...')`",I don't think this is the right
+8966,"@@ -867,7 +867,9 @@ static int handle_goaway_frame(h2o_http2_conn_t *conn, h2o_http2_frame_t *frame,
+     if ((ret = h2o_http2_decode_goaway_payload(&payload, frame, err_desc)) != 0)
+         return ret;
+ 
+-    /* nothing to do, since we do not open new streams by ourselves */
++    /* stop opening new push streams hereafter */
++    conn->push_stream_ids.max_open = INT32_MAX;
++
+     return 0;
+ }
+ ","Could we use `0x7ffffffe` instead, since `INT32_MAX` is an ID of a _pull_ stream? Other than that the PR seems ready for merge. Thank you for working on the fix.",Shouldn't this be `MAX_PUSH_STR
+8967,"@@ -86,11 +86,11 @@ module Beaker
+         execute_rake_task(""beaker_quickstart:gen_hosts[vmpooler]"")
+       end
+ 
+-      # Print a message to the console and exit with 0
++      # Print a message to the console and exit with 1
+       # @param [String] msg the message to print
+-      def self.exit_with(msg)
++      def self.exit_with(msg, exit_code=1)
+         puts msg
+-        exit(0)
++        exit(exit_code)
+       end
+ 
+       # Call the quick start task for the specified hypervisor",Might as well add a docstring for the new `exit_code` parameter too.,Should this be `exit_with(1)`?
+8968,"@@ -77,8 +77,8 @@ public class LocalNewSessionQueuer extends NewSessionQueuer {
+   }
+ 
+   @Override
+-  public Optional<HttpRequest> remove() {
+-    return sessionRequests.poll();
++  public Optional<HttpRequest> remove(RequestId id) {
++    return sessionRequests.poll(id);
+   }
+ 
+   @Override",`poll` and `remove` have different meanings.,Why do we need this change?
+8969,"@@ -111,6 +111,15 @@ public class TableProperties {
+   public static final String DELETE_AVRO_COMPRESSION = ""write.delete.avro.compression-codec"";
+   public static final String AVRO_COMPRESSION_DEFAULT = ""gzip"";
+ 
++  public static final String PARQUET_BLOOM_FILTER_ENABLED = ""write.parquet.bloom-filter-enabled"";
++  public static final boolean PARQUET_BLOOM_FILTER_ENABLED_DEFAULT = false;
++
++  public static final String PARQUET_BLOOM_FILTER_EXPECTED_NDV = ""write.parquet.bloom-filter-expected-ndv"";
++  public static final long PARQUET_BLOOM_FILTER_EXPECTED_NDV_DEFAULT = -1L;
++
++  public static final String PARQUET_BLOOM_FILTER_MAX_BYTES = ""write.parquet.bloom-filter-max-bytes"";
++  public static final int PARQUET_BLOOM_FILTER_MAX_BYTES_DEFAULT = 1024 * 1024;
++
+   public static final String SPLIT_SIZE = ""read.split.target-size"";
+   public static final long SPLIT_SIZE_DEFAULT = 134217728; // 128 MB
+ ",What's the perf impact of writing bloom filer? Does it make sense to enable it by default if the perf impact is minor? Would be nice to include benchmarks?,I think this should be `wri
+8970,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (IAM) role.]
++//snippet-sourcedescription:[DetachRolePolicy.java demonstrates how to detach a policy from an AWS Identity and Access Management (AWS IAM) role.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),This should be `//snippet-s
+8971,"@@ -162,13 +162,13 @@ const std::map<llvm::StringRef, hipCounter> CUDA_DRIVER_FUNCTION_MAP{
+   {""cuMemAlloc"",                                           {""hipMalloc"",                                               """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAlloc_v2"",                                        {""hipMalloc"",                                               """", CONV_MEMORY, API_DRIVER}},
+   // cudaHostAlloc
+-  {""cuMemAllocHost"",                                       {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemAllocHost"",                                       {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAllocHost_v2"",                                    {""hipMemAllocHost"",                                         """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // cudaMallocManaged
+   {""cuMemAllocManaged"",                                    {""hipMemAllocManaged"",                                      """", CONV_MEMORY, API_DRIVER}},
+   // no analogue
+   // NOTE: Not equal to cudaMallocPitch due to different signatures
+-  {""cuMemAllocPitch"",                                      {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
++  {""cuMemAllocPitch"",                                      {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER}},
+   {""cuMemAllocPitch_v2"",                                   {""hipMemAllocPitch"",                                        """", CONV_MEMORY, API_DRIVER, HIP_UNSUPPORTED}},
+   // no analogue
+   // NOTE: Not equal to cudaMemcpy due to different signatures",Remove `HIP_UNSUPPORTED` - it is an alias,Why did you change this?
+8972,"@@ -388,4 +388,10 @@ public class MockExecutorLoader implements ExecutorLoader {
+   public void unassignExecutor(int executionId) throws ExecutorManagerException {
+     executionExecutorMapping.remove(executionId);
+   }
++
++  @Override
++  public List<ExecutableFlow> fetchRecentlyFinishedFlows(long lifeTimeMs)
++      throws ExecutorManagerException {
++    return null;
++  }
+ }",i think we should return an empty list instead of null here.,Why not return an empty list?
+8973,"@@ -104,10 +104,14 @@ public class UserPreferences {
+     public static final String PREF_ENABLE_AUTODL_WIFI_FILTER = ""prefEnableAutoDownloadWifiFilter"";
+     private static final String PREF_AUTODL_SELECTED_NETWORKS = ""prefAutodownloadSelectedNetworks"";
+     private static final String PREF_PROXY_TYPE = ""prefProxyType"";
+-    private static final String PREF_PROXY_HOST = ""prefProxyHost"";
+-    private static final String PREF_PROXY_PORT = ""prefProxyPort"";
+-    private static final String PREF_PROXY_USER = ""prefProxyUser"";
+-    private static final String PREF_PROXY_PASSWORD = ""prefProxyPassword"";
++    private static final String PREF_HTTP_PROXY_HOST = ""prefHttpProxyHost"";
++    private static final String PREF_HTTP_PROXY_PORT = ""prefHttpProxyPort"";
++    private static final String PREF_HTTP_PROXY_USER = ""prefHttpProxyUser"";
++    private static final String PREF_HTTP_PROXY_PASSWORD = ""prefHttpProxyPassword"";
++    private static final String PREF_SOCKS_PROXY_HOST = ""prefSocksProxyHost"";
++    private static final String PREF_SOCKS_PROXY_PORT = ""prefSocksProxyPort"";
++    private static final String PREF_SOCKS_PROXY_USER = ""prefSocksProxyUser"";
++    private static final String PREF_SOCKS_PROXY_PASSWORD = ""prefSocksProxyPassword"";
+ 
+     // Services
+     private static final String PREF_GPODNET_NOTIFICATIONS = ""pref_gpodnet_notifications"";","Is it really necessary to store them in a new setting? I think it should be enough to store the credentials in `ProxyConfig.direct()`. Then AntennaPod does not need to store multiple different proxy settings. Also, it will not change existing users' settings (currently the proxy settings would be lost on upgrade).",I don't think we need to chan
+8974,"@@ -2115,10 +2115,15 @@ namespace pwiz.Skyline.Model
+         public static double GetCollisionEnergy(SrmSettings settings, PeptideDocNode nodePep,
+             TransitionGroupDocNode nodeGroup, TransitionDocNode nodeTran, CollisionEnergyRegression regression, int step)
+         {
+-            var ce = nodeTran==null // If we're only given a precursor, use the explicit CE of its children if they all agree
+-                ? (nodeGroup.Children.Any() && nodeGroup.Children.All( node => ((TransitionDocNode)node).ExplicitValues.CollisionEnergy == ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy) 
+-                    ? ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy : null)
+-                : nodeTran.ExplicitValues.CollisionEnergy;
++            // Collision Energy explicitly declared at the transition level is taken to be the correct value.
++            // If that is not present, explicitly declared value at the precursor level is used.
++            // If that is not present, the CE is calculated using the provided regression if any.
++            var ce = nodeTran == null ?
++                // If we're only given a precursor, use the explicit CE of its children if they all agree, else use precursor explicit CE
++                (nodeGroup.Children.Select(node => ((TransitionDocNode)node).ExplicitValues.CollisionEnergy).Distinct().Count() == 1 ? 
++                    ((TransitionDocNode)nodeGroup.Children.First()).ExplicitValues.CollisionEnergy : null) ?? nodeGroup.ExplicitValues.CollisionEnergy :
++                // Otherwise use explicit precursor CE if no explicit transition CE given
++                nodeTran.ExplicitValues.CollisionEnergy ?? nodeGroup.ExplicitValues.CollisionEnergy; 
+             if (regression != null)
+             {
+                 if (!ce.HasValue)","This is a mess. Can it be broken out as a separate function using ifs and return statements, which would also make it more debuggable.",I don't think you need the `.
+8975,"@@ -1457,8 +1457,16 @@ class GenericCompositePlot(DimensionedPlot):
+ 
+         key_map = dict(zip([d.name for d in self.dimensions], key))
+         for path, item in self.layout.items():
+-            frame = item.map(lambda x: get_plot_frame(x, key_map, cached=cached),
+-                             ['DynamicMap', 'HoloMap'])
++            clone = item.map(lambda x: x)
++
++            # Ensure that DynamicMaps in the cloned frame have
++            # identical callback inputs to allow memoization to work
++            for it1, it2 in zip(item.traverse(lambda x: x), clone.traverse(lambda x: x)):
++                if isinstance(it1, DynamicMap):
++                    with util.disable_constant(it2.callback):
++                        it2.callback.inputs = it1.callback.inputs
++            frame = clone.map(lambda x: get_plot_frame(x, key_map, cached=cached),
++                              [DynamicMap, HoloMap], clone=False)
+             if frame is not None:
+                 layout_frame[path] = frame
+         traverse_setter(self, '_force', False)",This stuff is a bit ugly and should probably become a utility. The main problem is that ``.map`` is being abused a bit.,I'm not sure if this is the b
+8976,"@@ -1128,6 +1128,9 @@ class ShareableResource(UserResource):
+         filters = super(ShareableResource, self)._extract_filters(queryparams)
+ 
+         ids = self.context.shared_ids
++        if getattr(self.context, ""forced_empty_list"", False):
++            ids = ['UNKNOWN']
++
+         if ids:
+             filter_by_id = Filter(self.model.id_field, ids, COMPARISON.IN)
+             filters.insert(0, filter_by_id)",Maybe there is a better way here so that we don't even bother triggering a storage query since we want an empty list here.,Why is this needed?
+8977,"@@ -0,0 +1,16 @@
++package aws
++
++import (
++	""context""
++
++	""github.com/aws/aws-sdk-go-v2/service/iam""
++)
++
++func (c *client) SimulateCustomPolicy(ctx context.Context, region string, customPolicySimulatorParams *iam.SimulateCustomPolicyInput) (*iam.SimulateCustomPolicyOutput, error) {
++	rc, err := c.getRegionalClient(region)
++	if err != nil {
++		return nil, err
++	}
++
++	return rc.iam.SimulateCustomPolicy(ctx, customPolicySimulatorParams)
++}","just curious, `region` is not used in the AWS IAM client, afaik. But I see this is a general field for clutch clients, is it just ignored internally?",I think this should
+8978,"@@ -7,7 +7,7 @@
+  * ""License""); you may not use this file except in compliance
+  * with the License. You may obtain a copy of the License at
+  *
+- *   http://www.apache.org/licenses/LICENSE-2.0
++ * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing,
+  * software distributed under the License is distributed on an",Why are we doing that change?,This should be reve
+8979,"@@ -220,7 +220,7 @@ public class ErrorHandler {
+ 
+   private Throwable rebuildServerError(Map<String, Object> rawErrorData, int responseStatus) {
+ 
+-    if (!rawErrorData.containsKey(CLASS) && !rawErrorData.containsKey(STACK_TRACE)) {
++    if (rawErrorData.get(CLASS) == null || rawErrorData.get(STACK_TRACE) == null) {
+       // Not enough information for us to try to rebuild an error.
+       return null;
+     }",Why && changed to || ?,Why is this change 
+8980,"@@ -196,6 +196,15 @@ def _unpickle(filepath, serializer):
+         raise ValueError(f'Unrecognized serializer type: {serializer}')
+ 
+ 
++def collection_to_single_partition(collection):
++    """"""Merge the parts of a Dask collection into a single partition.""""""
++    if collection is None:
++        return
++    if isinstance(collection, da.Array):
++        return collection.rechunk(*collection.shape)
++    return collection.repartition(npartitions=1)
++
++
+ @pytest.mark.parametrize('output', data_output)
+ @pytest.mark.parametrize('centers', data_centers)
+ def test_classifier(output, centers, client, listen_port):","can you please change this to `_collection_to_single_partition()`, like we've done for alll other helper methods defined in this module?",I think this should be `repartition(npartitions=1)`
+8981,"@@ -24,6 +24,7 @@ namespace Thelia\Core;
+ use Propel\Runtime\Connection\ConnectionManagerSingle;
+ use Propel\Runtime\Connection\ConnectionWrapper;
+ use Propel\Runtime\Propel;
++use Propel\Runtime\ServiceContainer\StandardServiceContainer;
+ use Symfony\Component\Config\FileLocator;
+ use Symfony\Component\Config\Loader\LoaderInterface;
+ use Symfony\Component\Debug\Debug;","This class is never used, don't import it.",Why is this needed?
+8982,"@@ -41,6 +41,10 @@ namespace Datadog.Trace.DiagnosticListeners
+ 
+         void IObserver<KeyValuePair<string, object>>.OnNext(KeyValuePair<string, object> value)
+         {
++#if DEBUG
++            // In debug mode we allow exceptions to be catch in the test suite
++            OnNext(value.Key, value.Value);
++#else
+             try
+             {
+                 OnNext(value.Key, value.Value);","Missing a `return`. Either way, I think it's better to add a `#if DEBUG throw;` in the catch block instead (so we keep the log in debug mode)",Why do we need this?
+8983,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++      
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+ 
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.,Extra empty line detected at class body end.
+8984,"@@ -104,6 +104,9 @@ namespace NLog.Config
+         /// </summary>
+         public IList<LoggingRule> LoggingRules { get; private set; }
+ 
++        internal List<LoggingRule> GetLoggingRulesThreadSafe() {  lock (LoggingRules) return LoggingRules.ToList(); }
++        private void AddLoggingRulesThreadSafe(LoggingRule rule) { lock (LoggingRules) LoggingRules.Add(rule); }
++
+         /// <summary>
+         /// Gets or sets the default culture info to use as <see cref=""LogEventInfo.FormatProvider""/>.
+         /// </summary>",I think we could replace this (well the backing field) with `BlockingCollection` when we drop NET35?,Why do we need this lock?
+8985,"@@ -928,6 +928,15 @@ class GroupBy(object):
+                 pser_or_pdf = pdf.groupby(input_groupnames)[name].apply(func)
+             else:
+                 pser_or_pdf = pdf.groupby(input_groupnames).apply(func)
++                keys = set(input_groupnames)
++                should_drop_columns = (
++                    isinstance(pser_or_pdf, pd.DataFrame)
++                    and keys.issubset(set(pser_or_pdf.index.names))
++                    and keys.issubset(set(pser_or_pdf.columns))
++                )
++                if should_drop_columns:
++                    pser_or_pdf = pser_or_pdf.drop(input_groupnames, axis=1)
++
+             kser_or_kdf = ks.from_pandas(pser_or_pdf)
+             if len(pdf) <= limit:
+                 return kser_or_kdf","Can you show before/after output in the PR description? From a cursory look, seems like it will just drop the duplicated column which isn't consistent with pandas' results.",I don't think this is the
+8986,"@@ -33,6 +33,14 @@ module Bolt
+         @rest = data.reject { |k, _| %w[name nodes config groups].include? k }
+       end
+ 
++      def check_deprecated_config(context, name, config)
++        if config && config['transports']
++          msg = ""#{context} #{name} contains invalid config option 'transports', see "" \
++                ""https://puppet.com/docs/bolt/0.x/inventory_file.html for the updated format""
++          raise ValidationError.new(msg, @name)
++        end
++      end
++
+       def validate(used_names = Set.new, node_names = Set.new, depth = 0)
+         raise ValidationError.new(""Group does not have a name"", nil) unless @name
+         if used_names.include?(@name)",Added validation that `config: transports` isn't used @adreyer @katelopresti Curious what you think about having Bolt link directly to the docs site.,Should this be `config['t
+8987,"@@ -99,6 +99,7 @@ class AbstractSettings:
+     _FONT_SIZES = {}  # type: typing.Dict[str, typing.Any]
+     _FONT_FAMILIES = {}  # type: typing.Dict[str, typing.Any]
+     _FONT_TO_QFONT = {}  # type: typing.Dict[typing.Any, QFont.StyleHint]
++    _UnknownUrlSchemePolicy = {}  # type: typing.Dict[str, typing.Any]
+ 
+     def __init__(self, settings: typing.Any) -> None:
+         self._settings = settings",This probably isn't needed anymore now?,I don't think this is use
+8988,"@@ -3,9 +3,9 @@ import { h } from './h';
+ 
+ /**
+  * Clones the given VNode, optionally adding attributes/props and replacing its children.
+- * @param {VNode} vnode		The virtual DOM element to clone
+- * @param {Object} props	Attributes/props to add when cloning
+- * @param {VNode} rest		Any additional arguments will be used as replacement children.
++ * @param {import('./vnode').VNode} vnode The virtual DOM element to clone
++ * @param {object} props Attributes/props to add when cloning
++ * @param {Array<import('./vnode').VNode>} [rest] Any additional arguments will be used as replacement children.
+  */
+ export function cloneElement(vnode, props) {
+ 	return h(",Would it be easier to kick this import to the top of the file? It'll get stripped out anyway.,`rest` should be an `Array<import('./vnode').VNode>`
+8989,"@@ -236,7 +236,8 @@ public class MultiTenancyPrivacyController implements PrivacyController {
+     }
+   }
+ 
+-  private void verifyPrivacyGroupContainsEnclavePublicKey(
++  @Override
++  public void verifyPrivacyGroupContainsEnclavePublicKey(
+       final String privacyGroupId, final String enclavePublicKey) {
+     final PrivacyGroup privacyGroup = enclave.retrievePrivacyGroup(privacyGroupId);
+     if (!privacyGroup.getMembers().contains(enclavePublicKey)) {",are you sure that the privacyGroup cannot be null?,Why is this change necessary?
+8990,"@@ -120,7 +120,7 @@ def GenerateDepictionMatching2DStructure(mol, reference, confId=-1, referencePat
+     if not referenceMatch:
+       raise ValueError(""Reference does not map to itself"")
+   else:
+-    referenceMatch = range(reference.GetNumAtoms(onlyExplicit=True))
++    referenceMatch = list(range(reference.GetNumAtoms(onlyExplicit=True)))
+   if referencePattern:
+     match = mol.GetSubstructMatch(referencePattern)
+   else:",Wrapped with list,Why is this change needed?
+8991,"@@ -0,0 +1,10 @@
++package stats
++
++// DivideFloat64 returns the value of value divided by base.
++// divide by zero case handled before calling.
++func DivideFloat64(value float64, base float64) (float64, bool) {
++	if base == 0 {
++		return 0, false
++	}
++	return (value / base), true
++}",Please move this to `pkg/stats/v1alpha1`,Why do we need this function?
+8992,"@@ -1,12 +1,13 @@
+ class GithubUser
++  URL_FORMAT = /\A[^\/]+\Z/
+   include ActiveModel::Model
+ 
+   attr_accessor :url, :bypass_url_validation
+   attr_reader :repositories, :module_name, :password
+   alias_method :username, :url
+ 
+-  validates :url, format: { with: /\A[^\/]+\Z/, message: I18n.t('invalid_github_username') }
+-  validate :username_must_exist
++  validates :url, format: { with: URL_FORMAT, message: I18n.t('invalid_github_username') }
++  validate :username_must_exist, if: -> { url.match(URL_FORMAT) }
+ 
+   def attributes
+     { url: username, type: self.class.name }",a small nit pick ...this can go into `lib/patterns.rb` ?,Align the elements of a hash literal if they span more than one line.
+8993,"@@ -27,7 +27,7 @@ import * as fixtures from '../datastore/__fixtures__';
+ import fetchMock from 'fetch-mock';
+ 
+ // TODO: update the active class.
+-const activeClass = 'googlesitekit-cta-link--danger';
++const activeClass = 'mdc-tab--active';
+ const url = fixtures.pagespeedMobile.loadingExperience.id;
+ const setupRegistry = ( { dispatch } ) => {
+ 	dispatch( STORE_NAME ).receiveGetReport( fixtures.pagespeedMobile, { url, strategy: STRATEGY_MOBILE } );",The above TODO is no longer necessary I believe  ,Why do we need to change this?
+8994,"@@ -345,7 +345,7 @@ func getPoolLivenessProbe() *corev1.Probe {
+ 	probe := &corev1.Probe{
+ 		Handler: corev1.Handler{
+ 			Exec: &corev1.ExecAction{
+-				Command: []string{""/bin/sh"", ""-c"", ""zfs set io.openebs:livenesstimestamp=\""$(date)\"" cstor-$OPENEBS_IO_POOL_NAME""},
++				Command: []string{""/bin/sh"", ""-c"", ""zfs set io.openebs:livenesstimestamp=\""$(date +%s)\"" cstor-$OPENEBS_IO_POOL_NAME""},
+ 			},
+ 		},
+ 		FailureThreshold:    3,",Why is this change required ?,Why is this change needed?
+8995,"@@ -0,0 +1,16 @@
++package summary
++
++import (
++	""bytes""
++
++	""github.com/russross/blackfriday""
++)
++
++func Markdown(input []byte, wordcount int) []byte {
++	words := bytes.Fields(blackfriday.Markdown(input, Renderer{}, 0))
++	if wordcount > len(words) {
++		wordcount = len(words)
++	}
++
++	return bytes.Join(words[0:wordcount], []byte{' '})
++}",This really is an excerpt. ;-),Why do we need this function?
+8996,"@@ -164,7 +164,7 @@ func (m *mock) IsWithinDepth(addr swarm.Address) bool {
+ 	if m.isWithinFunc != nil {
+ 		return m.isWithinFunc(addr)
+ 	}
+-	return false
++	return true
+ }
+ 
+ func (m *mock) EachNeighbor(f topology.EachPeerFunc) error {","@acud The reason why the default is now `true` is because the chunk must be in the neighborhood of the storer peer with this change. The majority of the tests expect a valid receipt so the closest peers in the tests must be in the neighborhood. As of writing this, there is only one test that expects a peer to be out of depth.",why this change?
+8997,"@@ -44,6 +44,7 @@ import (
+ 	""go.temporal.io/server/common/log/tag""
+ 	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/mysql""      // needed to load mysql plugin
+ 	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/postgresql"" // needed to load postgresql plugin
++	_ ""go.temporal.io/server/common/persistence/sql/sqlplugin/sqlite""     // needed to load sqlite plugin
+ 	""go.temporal.io/server/temporal""
+ )
+ ","This is what breaks the build. Apparently w/o this line, `sqlite` package is not even compiled. With this line it gets compiled but compilation fails because we don't use CGO for our production Linux builds and > ***Important: because this is a `CGO` enabled package you are required to set the environment variable `CGO_ENABLED=1` and have a `gcc` compile present within your path.***",Why is this need
+8998,"@@ -58,7 +58,7 @@ test_get_size()
+     }
+ 
+     // Check sizes of FP/SIMD regs.
+-    for (uint i = 0; i < NUM_SIMD_SLOTS; i++) {
++    for (int i = 0; i < proc_num_simd_saved(); i++) {
+         ASSERT(reg_get_size((reg_id_t)DR_REG_H0 + i) == OPSZ_2);
+         ASSERT(reg_get_size((reg_id_t)DR_REG_S0 + i) == OPSZ_4);
+         ASSERT(reg_get_size((reg_id_t)DR_REG_D0 + i) == OPSZ_8);",This should be all slots,`for (int i = 0;
+8999,"@@ -66,7 +66,7 @@ public final class RegistryUtils {
+     serviceRegistry.run();
+   }
+ 
+-  public static void destory() {
++  public static void destroy() {
+     serviceRegistry.destroy();
+   }
+ ",Need to add deprecated annotation and call the new fixed method to avoid the API broken issue.,public static vo
+9000,"@@ -36,8 +36,7 @@ public class GleanMetricsService {
+         } else {
+             GleanMetricsService.stop();
+         }
+-        Configuration config = new Configuration(Configuration.DEFAULT_TELEMETRY_ENDPOINT,
+-                                                 BuildConfig.BUILD_TYPE);
++        Configuration config = new Configuration();
+         Glean.INSTANCE.initialize(aContext, config);
+     }
+ ","This was just fixed in mozilla-mobile/android-components#4892. @pocmo is cutting a new Android Components 19 dot release today, so you'll be able to jump to the new version and restore the build type.",Why is this change needed?
+9001,"@@ -131,6 +131,7 @@ func (r *genericInjectReconciler) Reconcile(req ctrl.Request) (ctrl.Result, erro
+ 	if err := r.Client.Get(ctx, req.NamespacedName, target.AsObject()); err != nil {
+ 		if dropNotFound(err) == nil {
+ 			// don't requeue on deletions, which yield a non-found object
++			log.V(logf.TraceLevel).Info(""not found"", ""err"", err)
+ 			return ctrl.Result{}, nil
+ 		}
+ 		log.Error(err, ""unable to fetch target object to inject into"")","Leaving this log line because it helped me to diagnose that the reconciler client was using a different cache than the event sources, so not always seeing the injectable that triggered the reconcile.",I don't think we want to l
+9002,"@@ -4867,7 +4867,10 @@ func (mset *stream) processCatchupMsg(msg []byte) (uint64, error) {
+ 		return 0, errors.New(""bad catchup msg"")
+ 	}
+ 
++	mset.mu.RLock()
+ 	st := mset.cfg.Storage
++	mset.mu.RUnlock()
++
+ 	if mset.js.limitsExceeded(st) || mset.jsa.limitsExceeded(st) {
+ 		return 0, NewJSInsufficientResourcesError()
+ 	}",Do we need also to protect access to `mset.js` and `mset.jsa` or even `mset.store` down below? (not sure if those are immutable or not).,I don't think this lock is
+9003,"@@ -579,6 +579,7 @@ func (k *KeybaseServiceBase) ResolveImplicitTeamByID(
+ func (k *KeybaseServiceBase) checkForRevokedVerifyingKey(
+ 	ctx context.Context, currUserInfo UserInfo, kid keybase1.KID) (
+ 	newUserInfo UserInfo, exists bool, err error) {
++	newUserInfo = currUserInfo
+ 	for key, info := range currUserInfo.RevokedVerifyingKeys {
+ 		if !key.KID().Equal(kid) {
+ 			continue",I'd rather you do this under `if info.filledInMerkle {` since that's the only place it's relevant.,why do we need this?
+9004,"@@ -344,13 +344,8 @@ public class RecoveryStrategy implements Runnable, Closeable {
+                                                                                             // though
+       try {
+         CloudDescriptor cloudDesc = this.coreDescriptor.getCloudDescriptor();
+-        ZkNodeProps leaderprops = zkStateReader.getLeaderRetry(
+-            cloudDesc.getCollectionName(), cloudDesc.getShardId());
+-        final String leaderBaseUrl = leaderprops.getStr(ZkStateReader.BASE_URL_PROP);
+-        final String leaderCoreName = leaderprops.getStr(ZkStateReader.CORE_NAME_PROP);
+-
+-        String leaderUrl = ZkCoreNodeProps.getCoreUrl(leaderBaseUrl, leaderCoreName);
+-
++        ZkNodeProps leaderprops = zkStateReader.getLeaderRetry(cloudDesc.getCollectionName(), cloudDesc.getShardId());
++        String leaderUrl = ZkCoreNodeProps.getCoreUrl(leaderprops);
+         String ourUrl = ZkCoreNodeProps.getCoreUrl(baseUrl, coreName);
+ 
+         boolean isLeader = leaderUrl.equals(ourUrl); // TODO: We can probably delete most of this code if we say this",*NULL_DEREFERENCE:* object `leaderUrl` last assigned on line 348 could be null and is dereferenced at line 351.,Why do we need this change?
+9005,"@@ -38,9 +38,13 @@ class PlansController < ApplicationController
+   def create
+     @plan = Plan.new
+     authorize @plan
+-
++    
+     @plan.principal_investigator = current_user.surname.blank? ? nil : ""#{current_user.firstname} #{current_user.surname}""
+-    @plan.data_contact = current_user.email
++    @plan.principal_investigator_email = current_user.email
++    
++    orcid = current_user.identifier_for(IdentifierScheme.find_by(name: 'orcid'))
++    @plan.principal_investigator_identifier = orcid.identifier unless orcid.nil?
++    
+     @plan.funder_name = plan_params[:funder_name]
+ 
+     @plan.visibility = (plan_params['visibility'].blank? ? Rails.application.config.default_plan_visibility :","Since the IdentifierScheme's don't change without us making additional code changes, perhaps this should be added as a constant as we previously did with Perms?",This should be `current_use
+9006,"@@ -14,6 +14,7 @@
+ # limitations under the License.
+ #
+ 
++import os
+ import functools
+ import shutil
+ import sys",nit: We can revert this now.,Why is this needed?
+9007,"@@ -5,9 +5,19 @@ import android.view.ContextMenu;
+ import android.view.MenuInflater;
+ import android.view.View;
+ import android.view.ViewGroup;
++
+ import androidx.annotation.NonNull;
+ import androidx.annotation.Nullable;
+ import androidx.recyclerview.widget.RecyclerView;
++
++import org.apache.commons.lang3.ArrayUtils;
++
++import java.lang.ref.WeakReference;
++import java.util.ArrayList;
++import java.util.HashSet;
++import java.util.List;
++import java.util.Set;
++
+ import de.danoeh.antennapod.R;
+ import de.danoeh.antennapod.activity.MainActivity;
+ import de.danoeh.antennapod.core.feed.FeedItem;","Oh, that's the reason why you have two different data structures here. Does the order of the `selectedItems` list matter? If not, I think it would be more clear if both would be a Set.",I don't think we need this 
+9008,"@@ -2034,6 +2034,7 @@ void LuaScriptInterface::registerFunctions()
+ 	registerClass(""Container"", ""Item"", LuaScriptInterface::luaContainerCreate);
+ 	registerMetaMethod(""Container"", ""__eq"", LuaScriptInterface::luaUserdataCompare);
+ 
++	registerMethod(""Container"", ""getContentDescription"", LuaScriptInterface::luaContainerGetContentDescription);
+ 	registerMethod(""Container"", ""getSize"", LuaScriptInterface::luaContainerGetSize);
+ 	registerMethod(""Container"", ""getCapacity"", LuaScriptInterface::luaContainerGetCapacity);
+ 	registerMethod(""Container"", ""getEmptySlots"", LuaScriptInterface::luaContainerGetEmptySlots);","Should be named getDescription, since the other description functions are named that.",Why do we need this?
+9009,"@@ -62,7 +62,9 @@ public class PlatformActivity extends VRActivity implements RenderInterface, CVC
+         if (ControllerClient.isControllerServiceExisted(this)) {
+             mControllerManager = new CVControllerManager(this);
+             mControllerManager.setListener(this);
+-            mType = 1;
++            mType = 1; // Neo2
++            // Enable high res
++            PicovrSDK.SetEyeBufferSize(1920, 1920);
+         } else {
+             mHbManager = new HbManager(this);
+             mHbManager.InitServices();",Don't we want to do this for g2 4k also?,Why do we need this?
+9010,"@@ -4,6 +4,8 @@ const time = require('./time').default;
+ const Logger = require('./Logger').default;
+ const { _ } = require('./locale');
+ const urlUtils = require('./urlUtils.js');
++const str2ab = require('string-to-arraybuffer');
++const Buffer = require('buffer').Buffer;
+ 
+ class OneDriveApi {
+ 	// `isPublic` is to tell OneDrive whether the application is a ""public"" one (Mobile and desktop","I would prefer if we don't add this package as it's unsupported, and I expect not necessary. Node buffer supports many formats - is it not possible to use one of its helper functions to load the content?",Why is this needed?
+9011,"@@ -205,6 +205,12 @@ type Table struct {
+ 	// to what we calculate from chainToContents.
+ 	chainToDataplaneHashes map[string][]string
+ 
++	// chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
++	chainsToFullRules map[string][]string
++
++	// hashToFullRules contains a mapping of rule hashes to the full rules.
++	hashToFullRules map[string]string
++
+ 	// hashCommentPrefix holds the prefix that we prepend to our rule-tracking hashes.
+ 	hashCommentPrefix string
+ 	// hashCommentRegexp matches the rule-tracking comment, capturing the rule hash.","I don't think this is used any more, please remove.",nit: `map[string][]s
+9012,"@@ -219,7 +219,11 @@ def List(inner_type):
+             super(_List, self).__init__(
+                 key='List.{inner_type}'.format(inner_type=inner_type.key),
+                 name=None,
+-                description='List of {inner_type}'.format(inner_type=inner_type.name),
++                description=(
++                    'List of {inner_type}'.format(inner_type=inner_type.name)
++                    if inner_type.name is not None
++                    else 'List of config values'
++                ),
+                 type_attributes=ConfigTypeAttributes(is_builtin=True),
+                 inner_type=inner_type,
+             )","actually use type_name=print_config_type_to_string(self, with_lines=False) to populate this",I think this should be `List of {inner_type}`.
+9013,"@@ -71,6 +71,13 @@ class Import extends QueueWorkerBase implements ContainerFactoryPluginInterface
+       foreach ($results as $result) {
+         $queued = $this->processResult($result, $data, $queued);
+       }
++
++      // Delete local resource file.
++      if ($this->container->get('config.factory')->get('datastore.settings')->get('delete_local_resource')) {
++        $uuid = ""{$identifier}_{$version}"";
++        $this->container->get('file_system')->deleteRecursive(""public://resources/{$uuid}"");
++      }
++
+     }
+     catch (\Exception $e) {
+       $this->log(RfcLogLevel::ERROR,","We should be using dependency injection here, instead of fetching the config factory at the last minute from the container. That would allow us to more easily overwrite the ""delete_local_resource"" setting in tests.",Why do we need this?
+9014,"@@ -21,8 +21,12 @@ import com.codahale.metrics.health.HealthCheckRegistry;
+ import com.codahale.metrics.json.HealthCheckModule;
+ import com.fasterxml.jackson.databind.ObjectMapper;
+ import com.fasterxml.jackson.databind.ObjectWriter;
++import org.slf4j.Logger;
++import org.slf4j.LoggerFactory;
+ 
+ public class HealthCheckServlet extends HttpServlet {
++    private static final Logger LOG = LoggerFactory.getLogger(HealthCheckServlet.class);
++    
+     public static abstract class ContextListener implements ServletContextListener {
+         /**
+          * @return the {@link HealthCheckRegistry} to inject into the servlet context.","everywhere else in the project, `LOGGER` is used",Why do we need this?
+9015,"@@ -10,7 +10,7 @@ OSM = {
+   MAX_REQUEST_AREA:        <%= Settings.max_request_area.to_json %>,
+   SERVER_PROTOCOL:         <%= Settings.server_protocol.to_json %>,
+   SERVER_URL:              <%= Settings.server_url.to_json %>,
+-  API_VERSION:             <%= Settings.api_version.to_json %>,
++  API_VERSION:             <%= Settings.api_versions.min_by(&:to_f).to_json %>,
+   STATUS:                  <%= Settings.status.to_json %>,
+   MAX_NOTE_REQUEST_AREA:   <%= Settings.max_note_request_area.to_json %>,
+   OVERPASS_URL:            <%= Settings.overpass_url.to_json %>,","Why is this value set to ""min_by"", and what are the implications of it? Does `&:to_f` play nice with semver (e.g. 1.2.0)?",I think this should be `.min_by(&:to_f).to_jso
+9016,"@@ -0,0 +1,9 @@
++/**
++ * Setup configuration for Jest
++ * This file includes gloabl settings for the JEST environment.
++ */
++import 'raf/polyfill';
++import { configure } from 'enzyme';
++import Adapter from 'enzyme-adapter-react-16';
++
++configure({ adapter: new Adapter() });",typo --> gloabl,Why do we need this file?
+9017,"@@ -356,6 +356,12 @@ func (s *Server) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+ 	c := context.WithValue(r.Context(), OriginalURLCtxKey, urlCopy)
+ 	r = r.WithContext(c)
+ 
++	// Setup a replacer for the request that keeps track of placeholder
++	// values across plugins.
++	replacer := NewReplacer(r, nil, """")
++	c = context.WithValue(r.Context(), ReplacerCtxKey, replacer)
++	r = r.WithContext(c)
++
+ 	w.Header().Set(""Server"", caddy.AppName)
+ 
+ 	status, _ := s.serveHTTP(w, r)","Wanted to double-check: does the `log` middleware still set its own ""empty"" value (should default to `-` at least for the default log format)?",Why do we need this?
+9018,"@@ -273,7 +273,7 @@ public class HttpCommandExecutor implements CommandExecutor, NeedsLocalLogs {
+       }
+       if (!GET_ALL_SESSIONS.equals(command.getName())
+           && !NEW_SESSION.equals(command.getName())) {
+-        throw new SessionNotFoundException(""Session ID is null"");
++        throw new SessionNotFoundException(""Session ID is null. Using WebDriver after calling quit()?"");
+       }
+     }
+ ",It would be better to just change RWD to throw IllegalStateException if you attempt to execute a command after quit (unless it's a second call to quit()),I don't think this is the
+9019,"@@ -14,12 +14,13 @@ module Bolt
+ 
+       def print_head; end
+ 
+-      def initialize(color, verbose, trace, stream = $stdout)
++      def initialize(color, verbose, trace, spin, stream = $stdout)
+         super
+         # Plans and without_default_logging() calls can both be nested, so we
+         # track each of them with a ""stack"" consisting of an integer.
+         @plan_depth = 0
+         @disable_depth = 0
++        @pinwheel = %w[- \\ | /]
+       end
+ 
+       def colorize(color, string)","Is this going to be configurable? If not, it should just be removed for now.",Why is this needed?
+9020,"@@ -23,6 +23,13 @@ See :ref:`Parameter` for more info on how to define parameters.
+ import abc
+ import datetime
+ import warnings
++import json
++from json import JSONEncoder
++from collections import OrderedDict
++import collections
++import operator
++import functools
++
+ try:
+     from ConfigParser import NoOptionError, NoSectionError
+ except ImportError:","Maybe just one import line - `from collections import OrderedDict, Mapping` ?",Why is this needed?
+9021,"@@ -37,8 +37,8 @@ public class NonRuleWithAllPropertyTypes extends AbstractRule {
+     public static final StringMultiProperty MULTI_STR = new StringMultiProperty(""multiStr"", ""Multiple string values"",
+                                                                                 new String[] {""hello"", ""world""}, 5.0f, '|');
+     public static final PropertyDescriptor<Integer> SINGLE_INT = PropertyFactory.intProperty(""singleInt"").desc(""Single integer value"").require(inRange(1, 10)).defaultValue(8).build();
+-    public static final IntegerMultiProperty MULTI_INT = new IntegerMultiProperty(""multiInt"", ""Multiple integer values"",
+-                                                                                  0, 10, new Integer[] {1, 2, 3, 4}, 5.0f);
++    public static final PropertyDescriptor<List<Integer>> MULTI_INT = PropertyFactory.intListProperty(""multiInt"").desc(""Multiple integer values"").requireEach(inRange(0, 10)).defaultValues(1, 2, 3, 4).build();
++
+     public static final LongProperty SINGLE_LONG = new LongProperty(""singleLong"", ""Single long value"", 1L, 10L, 8L,
+                                                                     3.0f);
+     public static final LongMultiProperty MULTI_LONG = new LongMultiProperty(""multiLong"", ""Multiple long values"", 0L,","Btw this class probably doesn't belong in PMD. It says it's there to test UIs, but arguably UIs can use their own test fixtures, and this in in src/test so probably not even shipped anywhere.",I think this should
+9022,"@@ -50,6 +50,8 @@ describe( 'AMPContainerSelect', () => {
+ 		registry.dispatch( STORE_NAME ).setAccountID( accountID );
+ 		registry.dispatch( STORE_NAME ).receiveGetAccounts( [ account ] );
+ 		registry.dispatch( STORE_NAME ).receiveGetContainers( [ ...webContainers, ...ampContainers ], { accountID } );
++		registry.dispatch( STORE_NAME ).finishResolution( 'getAccounts', [] );
++		registry.dispatch( STORE_NAME ).finishResolution( 'getContainers', [ accountID ] );
+ 
+ 		const { getAllByRole } = render( <AMPContainerSelect />, { registry } );
+ ",Maybe we can group each `finishResolution` call with the corresponding `receiveGet...` call? That would make the connection more clear when reading the code.,Why do we need to c
+9023,"@@ -109,9 +109,9 @@ class ServerConnectionMixin(object):
+                         self.disconnect()
+     """"""
+ 
+-    def __init__(self, server_address=None):
++    def __init__(self, server_address=None, source_address=None):
+         super(ServerConnectionMixin, self).__init__()
+-        self.server_conn = ServerConnection(server_address)
++        self.server_conn = ServerConnection(server_address, source_address)
+         self.__check_self_connect()
+ 
+     def __check_self_connect(self):",Can we take this out of the constructor here and just use the config value? (This would also make the other proxy mode cases obsolete),I don't think we ne
+9024,"@@ -1350,9 +1350,14 @@ class RustGenerator : public BaseGenerator {
+         code_ +=
+             ""    if self.{{FIELD_TYPE_FIELD_NAME}}_type() == ""
+             ""{{U_ELEMENT_ENUM_TYPE}} {"";
+-        code_ +=
+-            ""      self.{{FIELD_NAME}}().map(|u| ""
+-            ""{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        if (!field.required) {
++          code_ +=
++              ""      self.{{FIELD_NAME}}().map(|u| ""
++              ""{{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        } else {
++          code_ += ""      let u = self.{{FIELD_NAME}}();"";
++          code_ += ""      Some({{U_ELEMENT_TABLE_TYPE}}::init_from_table(u))"";
++        }
+         code_ += ""    } else {"";
+         code_ += ""      None"";
+         code_ += ""    }"";",Please flip the conditional to be `if (field.required) { ... }`.,Shouldn't this be `if (field.required)`?
+9025,"@@ -11,7 +11,10 @@ describe 'User creation when logging in with Oauth to view a protected page' do
+       get '/auth/myusa/callback'
+     }.to change { User.count }.by(1)
+ 
+-    expect(User.last.email_address).to eq('george-test@example.com')
++    new_user = User.last
++    expect(new_user.email_address).to eq('george-test@example.com')
++    expect(new_user.first_name).to eq(""Georgie"")
++    expect(new_user.last_name).to eq(""Jetsonian"")
+   end
+ 
+   it 'does not create a user if the current user already exists' do",should we create a fixture without first name and last name and have a spec like this one that uses it to make sure nothing errors out when they are not present?,I'm not sure if this is the best way to 
+9026,"@@ -35,4 +35,9 @@ interface PythonSnippetSet<Element> {
+    * Generates the result module with a set of accumulated imports.
+    */
+   Doc generateModule(Element element, Doc body, Iterable<String> imports);
++  
++  /**
++   * Generate the example snippet for the code documentation.
++   */
++  Doc generateMethodSampleCode(PythonDocConfig config);
+ }",It seems odd to require all Python snippets to have this method when it's not relevant for messages.snip or the discovery snippets. (I see that we're already doing something similar with generateModule/generateBody where some of the implementations are empty. This also seems strange to me.),Why is this needed?
+9027,"@@ -122,6 +122,7 @@ public class PrivateTransactionSimulator {
+             publicWorldState.updater(),
+             disposablePrivateState.updater(),
+             header,
++            Hash.ZERO, // PMT hash is not needed as this private transaction doesn't exist
+             transaction,
+             protocolSpec.getMiningBeneficiaryCalculator().calculateBeneficiary(header),
+             new DebugOperationTracer(TraceOptions.DEFAULT),","What about this: ""// Corresponding PMT does not exist.""",Why is this needed?
+9028,"@@ -626,6 +626,8 @@ class OptionsManagerMixIn(object):
+             config_file = self.config_file
+         if config_file is not None:
+             config_file = os.path.expanduser(config_file)
++            if not os.path.exists(config_file):
++                raise IOError(""The config file {:s} doesn't exist!"".format(config_file))
+ 
+         use_config_file = config_file and os.path.exists(config_file)
+         if use_config_file:",You don't need af ormat specified here.,I don't think you need the `!` here.
+9029,"@@ -12,6 +12,8 @@ import (
+ 	""time""
+ 
+ 	""github.com/nats-io/go-nats""
++	""strings""
++	""sync""
+ )
+ 
+ func TestRouteConfig(t *testing.T) {",Nitpick: import ordering,nit: remove empty line
+9030,"@@ -38,7 +38,7 @@ namespace Nethermind.Blockchain
+ 
+         public ReadOnlyChain(ReadOnlyBlockTree readOnlyTree,
+             IBlockValidator blockValidator,
+-            IRewardCalculator rewardCalculator,
++            Func<ITransactionProcessor, IRewardCalculator> rewardCalculatorFactory,
+             ISpecProvider specProvider,
+             IReadOnlyDbProvider dbProvider,
+             IBlockDataRecoveryStep recoveryStep,","code smell here, a function that create a reward calculator from transaction processor?",I think this should be `ITransaction
+9031,"@@ -48,7 +48,7 @@ var authScopes = []string{
+ 	""https://www.googleapis.com/auth/cloud-platform"",
+ }
+ 
+-// Client is a runtimevarManager client.
++// A Client constructs runtime variables using the Runtime Configurator API.
+ type Client struct {
+ 	conn *grpc.ClientConn
+ 	// The gRPC API client.",I don't think the `A` is idomatic is it?,nit: `A Client constructs runtime va
+9032,"@@ -67,4 +67,12 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files reachable from given metadata location.
++   */
++  default RemoveReachableFiles removeReachableFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement "" +
++        RemoveReachableFiles.class.toString());
++  }
+ }",nit: the others use the method name in the api and not the class name of the api,I think this should be `RemoveReachableFiles`
+9033,"@@ -1939,6 +1939,9 @@ unsigned SwiftExpressionParser::Parse(DiagnosticManager &diagnostic_manager,
+   //  - Some passes may create new functions, but only the functions defined in
+   //    the lldb repl line should be serialized.
+   if (swift_ast_ctx->UseSerialization()) {
++    // Run all the passes before differentiation before we serialize.
++    runSILMandatoryOptPreDiffPasses(*sil_module);
++    // Serialize the module now.
+     auto expr_module_dir = swift_ast_ctx->GetReplExprModulesDir();
+     assert(expr_module_dir != nullptr);
+     llvm::SmallString<256> filename(expr_module_dir);",Does it work to run all the sil diagnostic passes before we serialize? That would be more consistent with what the normal compiler does in `FrontendTool.cpp : performCompileStepsPostSILGen()`,Why do we need to serialize the module here?
+9034,"@@ -4,6 +4,7 @@ Given '""$teacher_name"" is teaching the section from ""$section_start"" to ""$sectio
+   section = Section.find_by_starts_on_and_ends_on!(start_date, end_date)
+   teacher = Teacher.find_by_name!(teacher_name)
+   create(:section_teacher, section: section, teacher: teacher)
++  p section.teachers
+ end
+ 
+ Given 'I create the following section for ""$course_name"":' do |course_name, section_data|",You left in a puts.,Trailing whitespace detected.
+9035,"@@ -59,6 +59,11 @@ public abstract class CachingCollector extends FilterCollector {
+     @Override
+     public final float score() { return score; }
+ 
++    @Override
++    public float smoothingScore(int docId) throws IOException {
++      return 0;
++    }
++    
+     @Override
+     public int docID() {
+       return doc;","Hmm, should we also cache the `smoothingScore` for this hit? Or, if we will keep it at returning `0`, couldn't we remove this impl and inherit the default from `Scorable`?",why do we need this?
+9036,"@@ -51,7 +51,7 @@ module.exports = function (grunt, options) {
+     baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site', 'update-bower-json', 'gh-pages:bower', 'npm-publish'];
+   }
+   else {
+-    baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release', 'gh-pages:ui-grid-site'];
++    baseTasks['release'] = ['clean', 'ngtemplates', 'build', 'copy:less_dist', 'cut-release'];
+   }
+ 
+   return baseTasks;",I removed that from here because I am hoping that will stop the random unwanted updates to the website with unstable versions.,Why was this removed?
+9037,"@@ -11,7 +11,9 @@ import (
+ // State is the status of a process.
+ type State rune
+ 
+-const ( // Only values for Linux 3.14 and later are listed here
++// Process state values.
++// Only values for Linux 3.14 and later are listed here.
++const (
+ 	Dead        State = 'X'
+ 	DiskSleep   State = 'D'
+ 	Running     State = 'R'",Nit: missing period.,I don't think we need
+9038,"@@ -1,10 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
++# This code example demonstrates how deny uploads of unencrypted objects to an Amazon Simple Storage Solution (Amazon S3) bucket.
++
++# snippet-start:[s3.ruby.s3_add_bucket_ssekms_encryption_policy]
++
+ require 'aws-sdk-s3'
+ 
+-# Denies uploads of unencrypted objects to an Amazon S3 bucket.
+-#
+ # Prerequisites:
+ #
+ # - The Amazon S3 bucket to deny uploading unencrypted objects.",how **to** deny Simple Storage **Service**,I think this should b
+9039,"@@ -5,7 +5,7 @@ setResolver(resolver);
+ 
+ /* jshint ignore:start */
+ mocha.setup({
+-    timeout: 15000,
++    timeout: 25000,
+     slow: 500
+ });
+ /* jshint ignore:end */",Were you having trouble with timeouts in general acceptance tests or only the editor test? It's possible to set timeouts on a per-test basis by using `this.timeout(25000)` within the `it()` function. I'd like to drop the global timeout in the future if possible rather than increase it - in some circumstances a failing test can have a knock-on effect which makes all later tests timeout so Travis can get hung up for a long time if no one notices and cancels the build.,Why did you change th
+9040,"@@ -246,6 +246,11 @@ def _setSystemConfig(fromPath):
+ 		if curSourceDir==fromPath:
+ 			curDestDir=toPath
+ 		else:
++			if os.path.relpath(curSourceDir,fromPath) == ""addons"":
++				import addonHandler
++				subDirs[:] = [addon.name for addon in addonHandler.getRunningAddons()]
++			else:
++				subDirs[:] = subDirs
+ 			curDestDir=os.path.join(toPath,os.path.relpath(curSourceDir,fromPath))
+ 		if not os.path.isdir(curDestDir):
+ 			os.makedirs(curDestDir)",I don't think this is necessary.,"I don't think you need the `[:]` here, you can just do `subDirs = []`"
+9041,"@@ -1025,15 +1025,13 @@ func (vd *volAPI) snapEnumerate(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
+-	snaps := make([]*api.Volume, len(resp.GetVolumeSnapshotIds()))
+-	for i, s := range resp.GetVolumeSnapshotIds() {
++	snaps := make([]*api.Volume, 0)
++	for _, s := range resp.GetVolumeSnapshotIds() {
+ 		vol, err := volumes.Inspect(ctx, &api.SdkVolumeInspectRequest{VolumeId: s})
+ 		if err != nil {
+-			e := fmt.Errorf(""Failed to inspect volumeID: %s"", err.Error())
+-			vd.sendError(vd.name, method, w, e.Error(), http.StatusBadRequest)
+-			return
++			continue
+ 		}
+-		snaps[i] = vol.GetVolume()
++		snaps = append(snaps, vol.GetVolume())
+ 	}
+ 	json.NewEncoder(w).Encode(snaps)
+ }","Instead of blindly ignoring all errors, this should just ignore the volume not found error.",Shouldn't this be `len(snaps)`?
+9042,"@@ -135,11 +135,9 @@ public class ParquetReader<T> extends CloseableGroup implements CloseableIterabl
+         throw new RuntimeIOException(e);
+       }
+ 
+-      long rowPosition = rowGroupsStartRowPos[nextRowGroup];
++      model.setPageSource(pages, rowGroupsStartRowPos == null ? 0 : rowGroupsStartRowPos[nextRowGroup]);
+       nextRowGroupStart += pages.getRowCount();
+       nextRowGroup += 1;
+-
+-      model.setPageSource(pages, rowPosition);
+     }
+ 
+     @Override",The `rowPosition` will be ignored if the position column is not projected.,`rowGroupsStartRowPos[nextRowGroup] = 0;` ?
+9043,"@@ -215,6 +215,16 @@ spec:
+               protocol: TCP
+             - containerPort: 3232
+               protocol: TCP
++            livenessProbe:
++              exec:
++                command:
++                - /bin/sh
++                - -c
++                - zfs set io.openebs:livenesstimestap='$(date)' cstor-$OPENEBS_IO_CSTOR_ID
++              failureThreshold: 3
++              initialDelaySeconds: 300
++              periodSeconds: 10
++              timeoutSeconds: 30
+             securityContext:
+               privileged: true
+             volumeMounts:","Is there a possibility of a clash between periodSeconds and timeoutSeconds? For instance, the current probe is not yet timed-out and the next one has started.",Why do we need this?
+9044,"@@ -38,12 +38,11 @@ public class BesuCommandCustomFactory implements CommandLine.IFactory {
+       return (T) new VersionProvider(pluginVersionsProvider);
+     }
+ 
+-    final Constructor<T> constructor = cls.getDeclaredConstructor();
+     try {
++      final Constructor<T> constructor = cls.getDeclaredConstructor();
+       return constructor.newInstance();
+     } catch (Exception e) {
+-      constructor.setAccessible(true);
+-      return constructor.newInstance();
++      return CommandLine.defaultFactory().create(cls);
+     }
+   }
+ }",This logic is already been performed in `CommandLine.defaultFactory().create(cls)` ... whats the point of repeating it here?,Why is this change needed?
+9045,"@@ -410,7 +410,7 @@ class ManualColumnMove extends BasePlugin {
+    * @private
+    */
+   updateColumnsMapper() {
+-    let countCols = this.hot.countSourceCols();
++    let countCols = Math.max(this.hot.countCols(), this.hot.countSourceCols());
+     let columnsMapperLen = this.columnsMapper._arrayMap.length;
+ 
+     if (columnsMapperLen === 0) {",Please change from `let` to `const` here and above. Setting value to `this.hot.countSourceCols()` should be enought probably.,`countSourceCols` returns 
+9046,"@@ -796,7 +796,10 @@ int flb_upstream_conn_timeouts(struct mk_list *list)
+                  * waiting for I/O will receive the notification and trigger
+                  * the error to it caller.
+                  */
+-                shutdown(u_conn->fd, SHUT_RDWR);
++                if (u_conn->fd != -1) {
++                    shutdown(u_conn->fd, SHUT_RDWR);
++                }
++
+                 u_conn->net_error = ETIMEDOUT;
+                 prepare_destroy_conn(u_conn);
+             }","Somewhat nitpick: I see the `!=` pattern mentioned in the fluent-bit style guide, but imo, it would be safer to check that a fd is non-negative with ` > -1` or `>= 0`",Why do we need to check fo
+9047,"@@ -0,0 +1,17 @@
++class CreatePgSearchDocuments < ActiveRecord::Migration
++  def self.up
++    say_with_time(""Creating table for pg_search multisearch"") do
++      create_table :pg_search_documents do |t|
++        t.text :content
++        t.belongs_to :searchable, :polymorphic => true, :index => true
++        t.timestamps null: false
++      end
++    end
++  end
++
++  def self.down
++    say_with_time(""Dropping table for pg_search multisearch"") do
++      drop_table :pg_search_documents
++    end
++  end
++end",Use the new Ruby 1.9 hash syntax.,I think this should be `:p
+9048,"@@ -25,6 +25,8 @@ import (
+ 	""github.com/gogits/gogs/modules/bindata""
+ 	""github.com/gogits/gogs/modules/log""
+ 	""github.com/gogits/gogs/modules/user""
++
++	""strk.kbt.io/projects/go/libravatar""
+ )
+ 
+ type Scheme string",Please host to a GitHub repo.,Why do we need this?
+9049,"@@ -197,6 +197,12 @@ func (s *server) doneSplit(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
+-	tag.DoneSplit(tagr.Address)
++	_, err = tag.DoneSplit(tagr.Address)
++	if err != nil {
++		s.Logger.Debugf(""done split: %v"", err)
++		s.Logger.Error(""done split: %v"", err)
++		jsonhttp.InternalServerError(w, nil)
++		return
++	}
+ 	jsonhttp.OK(w, ""ok"")
+ }","The Error log message should not expose internals. The message should be something like this `""done split failed for address %v"", tagr.Address`. Also, the Debugf would be more informative with the address in the message.",Shouldn't this be a 
+9050,"@@ -13,11 +13,15 @@
+ 
+ package args
+ 
+-import ""flag""
++import (
++	""flag""
++)
+ 
+ const (
+ 	versionUsage             = ""Print the agent version information and exit""
+-	logLevelUsage            = ""Loglevel: [<crit>|<error>|<warn>|<info>|<debug>]""
++	logLevelUsage            = ""Loglevel overrides loglevel-driver and loglevel-on-instance and sets the same level for both on-instance and driver logging: [<crit>|<error>|<warn>|<info>|<debug>]""
++	driverLogLevelUsage      = ""Loglevel for docker logging driver: [<crit>|<error>|<warn>|<info>|<debug>]""
++	instanceLogLevelUsage    = ""Loglevel for Agent on-instance log file: [<none>|<crit>|<error>|<warn>|<info>|<debug>]""
+ 	ecsAttributesUsage       = ""Print the Agent's ECS Attributes based on its environment""
+ 	acceptInsecureCertUsage  = ""Disable SSL certificate verification. We do not recommend setting this option""
+ 	licenseUsage             = ""Print the LICENSE and NOTICE files and exit""","can we rename `fileLogLevelUsage` to be more generic like `instanceLogLevelUsage`? Same goes for other var below like fileLogLevelFlagName, FileLogLevel.",I think this should 
+9051,"@@ -169,11 +169,8 @@ define([""loading"", ""layoutManager"", ""userSettings"", ""events"", ""libraryBrowser"",
+                     valueChangeEvent: ""click""
+                 });
+ 
+-                if (layoutManager.desktop || layoutManager.mobile) {
+-                    alphaPickerElement.classList.add(""alphabetPicker-right"");
+-                    itemsContainer.classList.remove(""padded-left-withalphapicker"");
+-                    itemsContainer.classList.add(""padded-right-withalphapicker"");
+-                }
++                alphaPickerElement.classList.add(""alphaPicker-fixed-right"");
++                itemsContainer.classList.add(""padded-right-withalphapicker"");
+             }
+ 
+             var btnFilter = tabContent.querySelector("".btnFilter"");",Does this one not need the `tabContent` object used in the other files?,Why did you remove t
+9052,"@@ -102,6 +102,16 @@ type ClassicELB struct {
+ 	Tags map[string]string `json:""tags,omitempty""`
+ }
+ 
++// IsUnmanaged returns true if the Classic ELB is unmanaged.
++func (b *ClassicELB) IsUnmanaged(clusterName string) bool {
++	return b.Name != """" && !Tags(b.Tags).HasOwned(clusterName)
++}
++
++// IsManaged returns true if Classic ELB is managed.
++func (b *ClassicELB) IsManaged(clusterName string) bool {
++	return !b.IsUnmanaged(clusterName)
++}
++
+ // ClassicELBAttributes defines extra attributes associated with a classic load balancer.
+ type ClassicELBAttributes struct {
+ 	// IdleTimeout is time that the connection is allowed to be idle (no data",Our use of the terms `managed` and `unmanaged` in CAPA is interesting. I think we should probably update the docs (as part of a separate PR) to explain that we are referring to whether its CAPA managed infra. As opposed to meaning AWS managed service.,Why do we need this?
+9053,"@@ -246,7 +246,7 @@ def record_listens(request, data):
+ 
+     lookup = defaultdict(dict)
+     for key, value in data.items():
+-        if key == ""sk"" or key == ""token"" or key == ""api_key"" or key == ""method"":
++        if key == ""sk"" or key == ""token"" or key == ""api_key"" or key == ""method"" or key == ""api_sig"":
+             continue
+         matches = re.match('(.*)\[(\d+)\]', key)
+         if matches:",Looks like all of these can be put into a list.,`api_sig` doesn't se
+9054,"@@ -38,6 +38,8 @@ func CanonicalizeHeaderKey(k string) string {
+ type Headers struct {
+ 	// This representation allows us to make zero-value valid
+ 	items map[string]string
++	// map from canonicalized key to original key
++	keyMapping map[string]string
+ }
+ 
+ // NewHeaders builds a new Headers object.","nit: ""*mapping"" for a map is unnecessary. Consider calling this `originalNames` or similar.",nit: `// map from ca
+9055,"@@ -171,11 +171,11 @@ class ProfilesDialog(wx.Dialog):
+ 		index = self.profileList.Selection
+ 		if gui.messageBox(
+ 			# Translators: The confirmation prompt displayed when the user requests to delete a configuration profile.
+-			_(""Are you sure you want to delete this profile? This cannot be undone.""),
++			_(""This profile will be permanently deleted, this action cannot be undone.""),
+ 			# Translators: The title of the confirmation dialog for deletion of a configuration profile.
+ 			_(""Confirm Deletion""),
+-			wx.YES | wx.NO | wx.ICON_QUESTION, self
+-		) == wx.NO:
++			wx.OK | wx.CANCEL | wx.ICON_QUESTION, self
++		) != wx.OK:
+ 			return
+ 		name = self.profileNames[index]
+ 		try:","Please split this into two sentences; i.e. ""This profile will be permanently deleted. This action cannot be undone.""","""This profile will b"
+9056,"@@ -173,9 +173,10 @@ public class OpenAPSAMAPlugin extends PluginBase implements APSInterface {
+ 
+         startPart = new Date();
+         if (MainApp.getConstraintChecker().isAutosensModeEnabled().value()) {
+-            lastAutosensResult = IobCobCalculatorPlugin.getPlugin().detectSensitivityWithLock(IobCobCalculatorPlugin.getPlugin().oldestDataAvailable(), System.currentTimeMillis());
++            lastAutosensResult = IobCobCalculatorPlugin.getPlugin().getLastAutosensDataSynchronized(""OpenAPSPlugin"").autosensResult;
+         } else {
+             lastAutosensResult = new AutosensResult();
++            lastAutosensResult.sensResult = ""autosens disabled"";
+         }
+         Profiler.log(log, ""detectSensitivityandCarbAbsorption()"", startPart);
+         Profiler.log(log, ""AMA data gathering"", start);",NPE here and in other APS plugins,Shouldn't this be `lastAutosensResult = new AutosensResult();`?
+9057,"@@ -142,6 +142,9 @@ func getMsgKey(obj interface{}) (string, error) {
+ 		resourceType, _ := edgemessagelayer.GetResourceType(*msg)
+ 		resourceNamespace, _ := edgemessagelayer.GetNamespace(*msg)
+ 		resourceName, _ := edgemessagelayer.GetResourceName(*msg)
++		if msg.Router.Source == modules.DynamicControllerModuleName {
++			return strings.Join([]string{resourceType, resourceNamespace, resourceName, msg.Router.Source}, ""/""), nil
++		}
+ 		return strings.Join([]string{resourceType, resourceNamespace, resourceName}, ""/""), nil
+ 	}
+ ","Thanks for the fixing, and could you please provide more details for this bug? Because we have the deduplication mechanism in cloudhub, so it will has no problem.",Why do we need this?
+9058,"@@ -52,6 +52,10 @@ public class ViewSettings extends MainWindowView {
+     private static final String CAPTION_TITLE_CSS_CLASS = ""captionTitle"";
+     private static final String CONFIGURATION_PANE_CSS_CLASS = ""containerConfigurationPane"";
+     private static final String TITLE_CSS_CLASS = ""title"";
++    private String applicationName;
++    private String applicationVersion;
++    private String applicationGitRevision;
++    private String applicationBuildTimestamp;
+     private final ObservableList<String> repositories = FXCollections.observableArrayList();
+     private ComboBox<Theme> themes;
+     private Consumer<Settings> onSave;",These could be final,Why do we need these?
+9059,"@@ -103,7 +103,7 @@ public abstract class AbstractRestInvocation {
+     @SuppressWarnings(""unchecked"")
+     Map<String, String> cseContext =
+         JsonUtils.readValue(strCseContext.getBytes(StandardCharsets.UTF_8), Map.class);
+-    invocation.setContext(cseContext);
++    invocation.addContext(cseContext);
+   }
+ 
+   public String getContext(String key) {","highway have the same problem we can add a new method in invocation: mergeContext 1.if new context have more items, then addAll to new context, and replace old context 2.if new context have less items, then allAll to old context directly.",Why is this change needed?
+9060,"@@ -637,12 +637,15 @@ namespace GenFacades
+ 
+             private static void TraceDuplicateSeedTypeError(string docId, IReadOnlyList<INamedTypeDefinition> seedTypes)
+             {
+-                Trace.TraceError(""The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the following arguments to choose the preferred seed type:"", docId);
++                var sb = new StringBuilder();
++                sb.AppendFormat(""The type '{0}' is defined in multiple seed assemblies. If this is intentional, specify one of the following arguments to choose the preferred seed type:"", docId);
+ 
+                 foreach (INamedTypeDefinition type in seedTypes)
+                 {
+-                    Trace.TraceError(""  /preferSeedType:{0}={1}"", docId.Substring(""T:"".Length), type.GetAssembly().Name.Value);
++                    sb.AppendFormat(""  /preferSeedType:{0}={1}"", docId.Substring(""T:"".Length), type.GetAssembly().Name.Value);
+                 }
++
++                Trace.TraceError(sb.ToString());
+             }
+ 
+             private void AddTypeForward(Assembly assembly, INamedTypeDefinition seedType)",Created a single error so it's not interleaved in log,nit: `var sb = new StringBuilder(seedTypes.Count);`
+9061,"@@ -94,11 +94,9 @@ describe('exportFile', () => {
+ 
+       const result = plugin._createBlob(formatter);
+ 
+-      if (!Handsontable.helper.isIE9()) {
+-        expect(formatter.export).toHaveBeenCalled();
+-        expect(result.size).toBe(7);
+-        expect(result.type).toBe('foo;charset=iso-8859-1');
+-      }
++      expect(formatter.export).toHaveBeenCalled();
++      expect(result.size).toBe(7);
++      expect(result.type).toBe('foo;charset=iso-8859-1');
+     });
+   });
+ });",`isIE9` was reverted. Shouldn't this condition be reverted as well?,Why did you remove this?
+9062,"@@ -504,14 +504,14 @@ int LuaScriptInterface::luaErrorHandler(lua_State* L)
+ 	return 1;
+ }
+ 
+-bool LuaScriptInterface::callFunction(int params)
++bool LuaScriptInterface::callFunction(int params, bool defaultReturn /* = false */)
+ {
+ 	bool result = false;
+ 	int size = lua_gettop(luaState);
+ 	if (protectedCall(luaState, params, 1) != 0) {
+ 		LuaScriptInterface::reportError(nullptr, LuaScriptInterface::getString(luaState, -1));
+ 	} else {
+-		result = LuaScriptInterface::getBoolean(luaState, -1);
++		result = LuaScriptInterface::getBoolean(luaState, -1, defaultReturn);
+ 	}
+ 
+ 	lua_pop(luaState, 1);","Sorry if I'm being too pedantic here, but wouldn't it be nice to have standard parameter name? Like using `defaultValue` everywhere.",`/* = false */` is redundant
+9063,"@@ -119,9 +119,14 @@ func defaultBServer(ctx Context) string {
+ 	case libkb.DevelRunMode:
+ 		return memoryAddr
+ 	case libkb.StagingRunMode:
+-		return ""bserver-0.dev.keybase.io:443""
++		return `
++			bserver-0.dev.keybase.io:443,bserver-1.dev.keybase.io:443;
++			bserver.dev.keybase.io:443`
+ 	case libkb.ProductionRunMode:
+-		return ""bserver.kbfs.keybase.io:443""
++		return `
++			bserver-0.kbfs.keybaseapi.com:443,bserver-1.kbfs.keybaseapi.com:443;
++			bserver-0.kbfs.keybase.io:443,bserver-1.kbfs.keybase.io:443;
++			bserver.kbfs.keybase.io:443`
+ 	default:
+ 		return """"
+ 	}","Remind me again: what's the point of having new clients connect to both -0 and -1? If we ever have to blackhole -0, we'd have to blackhole -1 at the same time, right? What is supposed to be the difference between the two? Is it just that someday we might want to have two ELBs, and this will help load balance between them?",I think this should be `bserver-1.kbfs.keybaseapi.c
+9064,"@@ -1792,8 +1792,8 @@ func (s *Server) createClient(conn net.Conn) *client {
+ 
+ 	// Do final client initialization
+ 
+-	// Set the First Ping timer.
+-	s.setFirstPingTimer(c)
++	// Set the Ping timer. Will be reset once connect was received.
++	c.setPingTimer()
+ 
+ 	// Spin up the read loop.
+ 	s.startGoRoutine(func() { c.readLoop() })",Why not go back to `c.setPingTimer()` here instead so you don't need the new boolean in setFirstPingTimer().,Why do we need to reset this?
+9065,"@@ -1,4 +1,4 @@
+-/*
++/*
+  * Original author: Brendan MacLean <brendanx .at. u.washington.edu>,
+  *                  MacCoss Lab, Department of Genome Sciences, UW
+  *",We should figure out why so many of these files have an invisible change on the first line: Are we writing out some sort of byte order mark?,Why did you change this?
+9066,"@@ -1,19 +1,3 @@
+-/*
+-Copyright 2018 The Kubernetes Authors.
+-
+-Licensed under the Apache License, Version 2.0 (the ""License"");
+-you may not use this file except in compliance with the License.
+-You may obtain a copy of the License at
+-
+-    http://www.apache.org/licenses/LICENSE-2.0
+-
+-Unless required by applicable law or agreed to in writing, software
+-distributed under the License is distributed on an ""AS IS"" BASIS,
+-WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-See the License for the specific language governing permissions and
+-limitations under the License.
+-*/
+-
+ package resource
+ 
+ import (",Was this our code @csrwng,Why is this being removed?
+9067,"@@ -24,6 +24,7 @@ module Travis
+             end
+             sh.echo ""Build id: #{Shellwords.escape(data.build[:id])}""
+             sh.echo ""Job id: #{Shellwords.escape(data.job[:id])}""
++            sh.echo ""Runtime kernel version: #{`uname -r`.strip}""
+           end
+ 
+           def show_travis_build_version",I think you need `.untaint` here.,Should this be `uname -v`?
+9068,"@@ -227,7 +227,10 @@ module Bolt
+           raise Bolt::ValidationError, ""The project '#{name}' will not be loaded. The project name conflicts ""\
+             ""with a built-in Bolt module of the same name.""
+         end
+-      else
++      elsif name.nil? &&
++            (File.directory?(plans_path) ||
++            File.directory?(@path + 'tasks') ||
++            File.directory?(@path + 'files'))
+         message = ""No project name is specified in bolt-project.yaml. Project-level content will not be available.""
+         @logs << { warn: message }
+       end","Why are we including the `files/` directory in this check? I know `tasks/` and `plans/` make sense, since you can reference content in those directories from the CLI, but I don't think you can for `files/` (unless I'm missing a command).",I don't think this is the right place for this check. It should be in `bolt-project.yaml`.
+9069,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+ 
+ import com.google.common.collect.Maps;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.,Why is this import needed?
+9070,"@@ -72,6 +72,11 @@ const (
+ // A valid Certificate requires at least one of a CommonName, DNSName, or
+ // URISAN to be valid.
+ type CertificateSpec struct {
++	// Full X509 name specification (https://golang.org/pkg/crypto/x509/pkix/#Name).
++	// If specified, overrides any other name elements below.
++	// +optional
++	X509Name *X509DistinguishedName `json:""x509Name,omitempty""`
++
+ 	// CommonName is a common name to be used on the Certificate.
+ 	// The CommonName should have a length of 64 characters or fewer to avoid
+ 	// generating invalid CSRs.","Can we rename this field to `Subject`? Looking around, it seems like 'subject' is the standard terminology for this stanza  ",I don't think we need the `omitempty` here.
+9071,"@@ -15,7 +15,7 @@ was persisted in the address book and the node has been restarted).
+ 
+ So the information has been changed, and potentially upon disconnection,
+ the depth can travel to a shallower depth in result.
+-If a peer gets added through AddPeer, this does not necessarily infer
++If a peer gets added through AddPeers , this does not necessarily infer
+ an immediate depth change, since the peer might end up in the backlog for
+ a long time until we actually need to connect to her.
+ ",Remove additional whitespace.,"nit: extra space after `,`"
+9072,"@@ -171,6 +171,16 @@ func customResponseForwarder(ctx context.Context, w http.ResponseWriter, resp pr
+ 		http.SetCookie(w, cookie)
+ 	}
+ 
++	if cookies := md.HeaderMD.Get(""Set-Cookie-Refresh-Token""); len(cookies) > 0 {
++		cookie := &http.Cookie{
++			Name:     ""refreshToken"",
++			Value:    cookies[0],
++			Path:     ""/v1/authn/login"",
++			HttpOnly: true, // Client cannot access refresh token, it is sent by browser only if login is attempted.
++		}
++		http.SetCookie(w, cookie)
++	}
++
+ 	// Redirect if it's the browser (non-XHR).
+ 	redirects := md.HeaderMD.Get(""Location"")
+ 	if len(redirects) > 0 && isBrowser(requestHeadersFromResponseWriter(w)) {",We should add `Secure` as well,I don't think this is the right place to put this code. I think it should be in the `authn.go` file.
+9073,"@@ -12,7 +12,7 @@ import (
+ // TestIntegration runs integration tests against the remote
+ func TestIntegration(t *testing.T) {
+ 	fstests.Run(t, &fstests.Opt{
+-		RemoteName: ""TestWebdavNexcloud:"",
++		RemoteName: ""TestWebdavNextcloud:"",
+ 		NilObject:  (*webdav.Object)(nil),
+ 	})
+ }",I presume this isn't a big deal,Why did you change this?
+9074,"@@ -2974,7 +2974,8 @@ raw_mem_alloc(size_t size, uint prot, void *addr, dr_alloc_flags_t flags)
+             : (TEST(DR_ALLOC_COMMIT_ONLY, flags) ? RAW_ALLOC_COMMIT_ONLY : 0);
+ #    endif
+         if (IF_WINDOWS(TEST(DR_ALLOC_COMMIT_ONLY, flags) &&) addr != NULL &&
+-            !app_memory_pre_alloc(get_thread_private_dcontext(), addr, size, prot, false))
++            !app_memory_pre_alloc(get_thread_private_dcontext(), addr, size, prot, false,
++                                  true /*update*/, false /*!image*/))
+             p = NULL;
+         else
+             p = os_raw_mem_alloc(addr, size, prot, os_flags, &error_code);","Maybe {}, even though no multi-line body?","Shouldn't this be `true /*update*/, false /*image*/`?"
+9075,"@@ -39,6 +39,16 @@ describe CommunicartMailer do
+       mail.from.should == ['reply@communicart-stub.com']
+     end
+ 
++   it 'renders the navigator template' do
++      cart.setProp('origin','navigator')
++      cart.stub(:approval_group).and_return(approval_group)
++      approval_group.stub(:approvers).and_return([approver])
++      approver.stub(:approver_comment).and_return([])
++# This is very fragile, it is based on a particular term coming from the navigator teplate.
++# If the template changes, this test will break --- I know of no other way of tesitng this.
++      expect(mail.body.encoded).to match('NAVIGATOR')
++    end
++
+     context 'attaching a csv of the cart activity' do
+       it 'generates csv attachments for an approved cart' do
+         cart.stub(:approval_group).and_return(approval_group)",We can try something like this: response.should render_template(:partial => 'partial_name'),Extra empty line detected at block body end.
+9076,"@@ -514,6 +514,10 @@ IDRETRY=4
+ IDCANCEL=3
+ 
+ def MessageBox(hwnd, text, caption, type):
++	if hasattr(text, 'decode'):
++		text = text.decode('mbcs')
++	if caption and hasattr(caption, 'decode'):
++		caption = caption.decode('mbcs')
+ 	res = user32.MessageBoxW(hwnd, text, caption, type)
+ 	if res == 0:
+ 		raise WinError()","Please use `isinstance(text, bytes)` instead. Otherwise, this will lead to unnecessary decoding on python 2 unicode strings.",Why is this needed?
+9077,"@@ -3068,7 +3068,7 @@ void SwiftLanguageRuntime::FindFunctionPointersInCall(
+                   ExecutionContext exe_ctx;
+                   frame.CalculateExecutionContext(exe_ctx);
+                   error = argument_values.GetValueAtIndex(0)->GetValueAsData(
+-                      &exe_ctx, data, 0, NULL);
++                      &exe_ctx, data, NULL);
+                   lldb::offset_t offset = 0;
+                   lldb::addr_t fn_ptr_addr = data.GetPointer(&offset);
+                   Address fn_ptr_address;",This one is unrelated to the GetSymbolVendor removal ... the API to GetValueAsData was changed.,Shouldn't this be `
+9078,"@@ -45,6 +45,7 @@ func TestMarshalUnmarshalJSON(t *testing.T) {
+ 		desiredStatusUnsafe:   resourcestatus.ResourceCreated,
+ 		knownStatusUnsafe:     resourcestatus.ResourceCreated,
+ 		appliedStatusUnsafe:   resourcestatus.ResourceCreated,
++		networkMode:           bridgeNetworkMode,
+ 	}
+ 
+ 	bytes, err := json.Marshal(firelensResIn)",can you assert the value of this field below similar to other fields?,Why do we need this
+9079,"@@ -11,6 +11,7 @@ package net.sourceforge.pmd.lang.java.ast;
+  * <pre class=""grammar"">
+  *
+  * PrimaryExpression ::= {@linkplain ASTLiteral Literal}
++ *                     | {@link ASTClassLiteral ClassLiteral}
+  *                     | {@linkplain ASTMethodCall MethodCall}
+  *                     | {@linkplain ASTFieldAccess FieldAccess}
+  *                     | {@linkplain ASTConstructorCall ConstructorCall}","I'll change that to ""linkplain"" for consistency :)",I think this should
+9080,"@@ -196,7 +196,12 @@ class RouteFactory(object):
+                                                 self.resource_name,
+                                                 **matchdict)
+                 if object_id == '*':
+-                    object_uri = object_uri.replace('%2A', '*')
++                    # Express the object_uri pattern with precision
++                    # XXX: we could get the model.id_generator pattern, but
++                    # since the backend replace * by .* we can't.
++                    # See Kinto/kinto#970
++                    id_pattern = ""[a-zA-Z0-9_-]+""
++                    object_uri = object_uri.replace('%2A', id_pattern)
+             except KeyError:
+                 # Maybe the resource has no single record endpoint.
+                 # We consider that object URIs in permissions backend will","This is fix. But since the history resource was relying on the bug to work, I had to do some changes regarding the history entries (eg. explicit declare that the permissions inherit from bucket)",I don't think this is the right way to do it. I think it should be `[a-zA-Z0-9_-]+`
+9081,"@@ -142,6 +142,11 @@ public class DocsStreamer implements Iterator<SolrDocument> {
+     return docIterator.hasNext();
+   }
+ 
++  // called at the end of the stream
++  public void finish(){
++    if (transformer != null) transformer.finish();
++  }
++
+   public SolrDocument next() {
+     int id = docIterator.nextDoc();
+     idx++;","can't we leverage Closeable here and get some sugar&warns? Also, line 89 still calls setContext() .. is it right? or I'm missing something?",missing space after if
+9082,"@@ -52,7 +52,7 @@ func TestPing(t *testing.T) {
+ 	// ping
+ 	peerID := ""124""
+ 	greetings := []string{""hey"", ""there"", ""fella""}
+-	rtt, err := client.Ping(context.Background(), peerID, greetings...)
++	rtt, err := client.Ping(context.Background(), []byte(peerID), greetings...)
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}","Use explicit swarm.Address when defining peerID, by using NewAddress, and remove conversion here.",`peerID` should be a string.
+9083,"@@ -30,9 +30,13 @@ const (
+ 	rootMountPoint = ""/""
+ 	rootUser       = ""root""
+ 
++	// RpmDependenciesDirectory is the directory which contains RPM database. It is not required for images that do not contain RPM.
++	RpmDependenciesDirectory = ""/var/lib/rpm""
++
+ 	// /boot directory should be only accesible by root. The directories need the execute bit as well.
+ 	bootDirectoryFileMode = 0600
+ 	bootDirectoryDirMode  = 0700
++	shadowFile            = ""/etc/shadow""
+ )
+ 
+ // PackageList represents the list of packages to install into an image","`RpmDependenciesDirectory` should start with a lowercase character so it's not exported outside of this package, it looks like its only referenced in this file.",Why do we need this?
+9084,"@@ -25,9 +25,13 @@ class BasicBlock(nn.Module):
+                  conv_cfg=None,
+                  norm_cfg=dict(type='BN'),
+                  dcn=None,
++                 rfp_inplanes=None,
++                 sac=None,
+                  plugins=None):
+         super(BasicBlock, self).__init__()
+         assert dcn is None, 'Not implemented yet.'
++        assert rfp_inplanes is None, 'Not implemented yet.'
++        assert sac is None, 'Not implemented yet.'
+         assert plugins is None, 'Not implemented yet.'
+ 
+         self.norm1_name, norm1 = build_norm_layer(norm_cfg, planes, postfix=1)","If we make a new backbone class, we don't need to support `BasicBlock`",Why do we need these?
+9085,"@@ -359,11 +359,6 @@ configRetry:
+ 
+ 	// Start up the dataplane driver.  This may be the internal go-based driver or an external
+ 	// one.
+-	if configParams.BPFEnabled && !bpf.SyscallSupport() {
+-		log.Error(""BPFEnabled is set but BPF mode is not supported on this platform.  Continuing with BPF disabled."")
+-		configParams.BPFEnabled = false
+-	}
+-
+ 	var dpDriver dp.DataplaneDriver
+ 	var dpDriverCmd *exec.Cmd
+ ",This was an out-of-date dupe of the check on line 335,Why is this being rem
+9086,"@@ -44,7 +44,6 @@ window.PluginsView = countlyView.extend({
+ 
+             this.dtable = $('#plugins-table').dataTable($.extend({}, $.fn.dataTable.defaults, {
+                 ""aaData"": pluginsData,
+-                ""bPaginate"": false,
+                 ""aoColumns"": [
+                     { ""mData"": function (row, type) { if (row.enabled) { return jQuery.i18n.map[row.code + "".plugin-title""] || jQuery.i18n.map[row.code + "".title""] || row.title; } else return row.title }, ""sType"": ""string"", ""sTitle"": jQuery.i18n.map[""plugins.name""] },
+                     {",Let's put this back,Why was this removed?
+9087,"@@ -122,9 +122,9 @@ bool Mailbox::sendItem(Item* item) const
+ 		}
+ 	} else {
+ 		Player tmpPlayer(nullptr);
+-		if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
++		//if (!IOLoginData::loadPlayerByName(&tmpPlayer, receiver)) {
+ 			return false;
+-		}
++		//}
+ 
+ 		if (g_game.internalMoveItem(item->getParent(), tmpPlayer.getInbox(), INDEX_WHEREEVER,
+ 		                            item, item->getItemCount(), nullptr, FLAG_NOLIMIT) == RET_NOERROR) {",Things like these should have been addressed before submitting a pull request.,This should be remove
+9088,"@@ -77,7 +77,7 @@ public class ITZipkinMetrics {
+ 
+     // ensure we don't track prometheus, UI requests in prometheus
+     assertThat(scrape())
+-      .doesNotContain(""prometheus"")
++      .doesNotContain(""prometheus_notifications"")
+       .doesNotContain(""uri=\""/zipkin"")
+       .doesNotContain(""uri=\""/\"""");
+   }",This one as well. Any better suggestion please?,Why is this change needed?
+9089,"@@ -267,6 +267,11 @@ func (s *Server) internalSendLoop(wg *sync.WaitGroup) {
+ 			c.pa.reply = []byte(pm.rply)
+ 			c.mu.Unlock()
+ 
++			if c.trace {
++				c.traceInOp(fmt.Sprintf(
++					""PUB %s %s %d"", c.pa.subject, c.pa.reply, c.pa.size), nil)
++			}
++
+ 			// Add in NL
+ 			b = append(b, _CRLF_...)
+ 			c.processInboundClientMsg(b)","wonder if we should collect c.trace, c.pa.subject, etc.. while under the lock to prevent data races.. or simply move the tracing under the lock.",I don't think we need this
+9090,"@@ -182,7 +182,7 @@ PJ_XY pj_fwd(PJ_LP lp, PJ *P) {
+ 
+     last_errno = proj_errno_reset(P);
+ 
+-    if (!P->skip_fwd_prepare)
++    if (!P->skip_fwd_prepare && 0 != strcmp(P->short_name, ""s2""))
+         coo = fwd_prepare (P, coo);
+     if (HUGE_VAL==coo.v[0] || HUGE_VAL==coo.v[1])
+         return proj_coord_error ().xy;","Why is this hack needed ? Ideally, we shouldn't need that.",I don't think this is the 
+9091,"@@ -0,0 +1,19 @@
++package plugin
++
++type Status struct {
++	DriverName     string
++	MeshDriverName string `json:""MeshDriverName,omitempty""`
++	Version        int
++}
++
++func NewStatus(address, meshAddress string, isPluginV2 bool) *Status {
++	status := &Status{
++		DriverName:     pluginNameFromAddress(address),
++		MeshDriverName: pluginNameFromAddress(meshAddress),
++		Version:        1,
++	}
++	if isPluginV2 {
++		status.Version = 2
++	}
++	return status
++}","Minor/Nitpick: replace `1` with a constant, esp. as used in `prog/weaver/http.go` in `{{if eq .Plugin.Version 1}}`",Why do we need this?
+9092,"@@ -13,5 +13,5 @@ namespace Datadog.Trace.Configuration
+         {
+             return Environment.GetEnvironmentVariable(key);
+         }
+-    }
++   }
+ }","nit: Looks like the whitespace got thrown off, can you fix this?",nit: unnecessary change
+9093,"@@ -5593,7 +5593,13 @@ namespace pwiz.Skyline.Properties {
+                 return ResourceManager.GetString(""CommandLine_ImportAnnotations_Error__Failed_while_reading_annotations_"", resourceCulture);
+             }
+         }
+-        
++
++        public static string CommandLine_ImportPeakBoundaries_Error__Failed_while_importing_boundaries_ {
++            get {
++                return ResourceManager.GetString(""CommandLine_ImportPeakBoundaries_Error__Failed_while_importing_boundaries_"", resourceCulture);
++            }
++        }
++
+         /// <summary>
+         ///   Looks up a localized string similar to Error: The replicate {0} already exists in the given document and the --import-append option is not specified.  The replicate will not be added to the document..
+         /// </summary>",Redo this by adding a string literal and then pressing F6 to have Resharper move it to Properties\Resources.resx which will also create this property.,I don't think this shou
+9094,"@@ -0,0 +1,11 @@
++// +build !windows
++// Copyright 2012-2017 Apcera Inc. All rights reserved.
++
++package server
++
++// Run starts the NATS server. This wrapper function allows Windows to add a
++// hook for running NATS as a service.
++func Run(server *Server) error {
++	server.Start()
++	return nil
++}","Unless a log file has been specified, IMO you should set the server option to enable syslog (windows event log) here, or someplace along the service start code path. We shouldn't really rely on users to specify that when creating the service.",Why do we need this wra
+9095,"@@ -86,8 +86,8 @@ public class TestFlinkCatalogTable extends FlinkCatalogTestBase {
+             Types.NestedField.optional(1, ""strV"", Types.StringType.get())));
+     Assert.assertEquals(
+         Arrays.asList(
+-            TableColumn.of(""id"", DataTypes.BIGINT()),
+-            TableColumn.of(""strV"", DataTypes.STRING())),
++            TableColumn.physical(""id"", DataTypes.BIGINT()),
++            TableColumn.physical(""strV"", DataTypes.STRING())),
+         getTableEnv().from(""tl"").getSchema().getTableColumns());
+     Assert.assertTrue(getTableEnv().getCatalog(catalogName).get().tableExists(ObjectPath.fromString(""db.tl"")));
+   }","It's strange here, because I saw the `TableColumn` is marked as `PublicEvolving`, but after released flink 1.12.0 it did not have any Interface compatibility guarantee. At least, it should marked as `deprecated`, and keep it a major release.",Why this change?
+9096,"@@ -104,7 +104,7 @@ public abstract class ConnectionPageAbstract extends DialogPage implements IData
+ 
+         if (!site.isNew() && !site.getDriver().isEmbedded()) {
+             Link netConfigLink = new Link(panel, SWT.NONE);
+-            netConfigLink.setText(""<a>Network settings (SSH, SSL, Proxy, ...)</a>"");
++            netConfigLink.setText(""<a>"" + CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link + ""</a>"");
+             netConfigLink.addSelectionListener(new SelectionAdapter() {
+                 @Override
+                 public void widgetSelected(SelectionEvent e) {","I'm not sure regarding this approach, for me the whole text including anchors should go to resources like ` netConfigLink.setText(CoreMessages.dialog_connection_edit_wizard_conn_conf_network_link); ` You shouldn't concatenate translated values inside the code. If you need some params, please use NLS.bind()",I don't think you need the `+` operator here.
+9097,"@@ -78,6 +78,7 @@ func (c *connectionFlowController) GetWindowUpdate() protocol.ByteCount {
+ func (c *connectionFlowController) EnsureMinimumWindowSize(inc protocol.ByteCount) {
+ 	c.mutex.Lock()
+ 	if inc > c.receiveWindowSize {
++		c.logger.Debugf(""Increasing receive flow control window for the connection to %d kB, in response to stream flow control window increase"", c.receiveWindowSize/(1<<10))
+ 		c.receiveWindowSize = utils.MinByteCount(inc, c.maxReceiveWindowSize)
+ 		c.startNewAutoTuningEpoch()
+ 	}",How often do we expect this to trigger? Should we maybe put it behind an if logger.Debug()?,Why do we need this log?
+9098,"@@ -126,12 +126,12 @@ func Snapshot(volname string, snapname string, labels map[string]string) (string
+ 		return """", err
+ 	}
+ 
+-	volume, err := GetVolume(controller.address)
++	volume, err := GetVolume(controller.Address)
+ 	if err != nil {
+ 		return """", err
+ 	}
+ 
+-	url := controller.address + ""/volumes/"" + volume.Id + ""?action=snapshot""
++	url := controller.Address + ""/volumes/"" + volume.Id + ""?action=snapshot""
+ 
+ 	fmt.Println(""Url is:"", url)
+ ","How was the name `controller` arrived? Can you get a consensus for the name controller ? This may be OK for jiva. However, c-stor does not have a concept called `controller`.",Shouldn't this be `controller.Address`?
+9099,"@@ -151,6 +151,16 @@ func (v *ConfigValidator) sysctl(config *configs.Config) error {
+ 				return fmt.Errorf(""sysctl %q is not allowed in the hosts network namespace"", s)
+ 			}
+ 		}
++		if config.Namespaces.Contains(configs.NEWUTS) {
++			switch s {
++			case ""kernel.domainname"":
++				// This is namespaced and there's no explicit OCI field for it.
++				continue
++			case ""kernel.hostname"":
++				// This is namespaced but there's a conflicting (dedicated) OCI field for it.
++				return fmt.Errorf(""sysctl %q is not allowed as it conflicts with the OCI %q field"", s, ""hostname"")
++			}
++		}
+ 		return fmt.Errorf(""sysctl %q is not in a separate kernel namespace"", s)
+ 	}
+ ",i dont think we need to explicitly single out `kernel.domainname` here since its not a TODO for OCI either right ?,I'm not sure this is the right error message.
+9100,"@@ -66,7 +66,7 @@ static void on_setup_ostream(h2o_filter_t *_self, h2o_req_t *req, h2o_ostream_t
+     if (!req->res.mime_attr->is_compressible)
+         goto Next;
+     /* 100 is a rough estimate */
+-    if (req->res.content_length <= 100)
++    if (req->res.content_length <= self->args.min_size)
+         goto Next;
+     /* skip if failed to gather the list of compressible types */
+     if ((compressible_types = h2o_get_compressible_types(&req->headers)) == 0)",Should we better change the operator to `<` since the variable defines the minimum size that gets compressed?,Shouldn't this be `self->args.max_size`?
+9101,"@@ -233,6 +233,14 @@ public class StreamTest extends AbstractLinearSeqTest {
+         assertThat(actual).isEqualTo(3);
+     }
+ 
++    // -- append
++
++    @Test
++    public void shouldAppendMillionTimes() {
++        final int bigNum = 1_000_000;
++        assertThat(Stream.range(0, bigNum).foldLeft(Stream.empty(), Stream::append).length()).isEqualTo(bigNum);
++    }
++
+     // -- combinations
+ 
+     @Test",I'm really impressed by the AppendElements addition! Very cool! :-),nit: I think it would be better to use `
+9102,"@@ -230,7 +230,7 @@ public class GridLauncherV3 {
+     }
+ 
+     configureLogging(common.getLog(), common.getDebug());
+-    log.info(version());
++    log.finest(version());
+     return true;
+   }
+ ",This change means that users can't easily see which version of the selenium server they're using. This is `info` level information.,This should be `log.finest(version());`
+9103,"@@ -41,6 +41,8 @@ from qutebrowser.misc import editor, guiprocess
+ from qutebrowser.completion.models import urlmodel, miscmodels
+ from qutebrowser.mainwindow import mainwindow
+ 
++# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-69904
++MAX_WORLD_ID = 256 if qtutils.version_check('5.11.2') else 11
+ 
+ class CommandDispatcher:
+ ",This should be in qtutils and imported to here and the other place instead of declaring it twice.,This should be `qtutils.version_check('5
+9104,"@@ -73,6 +73,15 @@ func (l *Logger) FetchCert(ctx context.Context, url string, bundle bool) ([][]by
+ 	return l.baseCl.FetchCert(ctx, url, bundle)
+ }
+ 
++func (l *Logger) FetchCertAlternatives(ctx context.Context, url string, bundle bool) ([][][]byte, error) {
++	l.log.V(logf.TraceLevel).Info(""Calling FetchCertAlternatives"")
++
++	ctx, cancel := context.WithTimeout(ctx, timeout)
++	defer cancel()
++
++	return l.baseCl.FetchCertAlternatives(ctx, url, bundle)
++}
++
+ func (l *Logger) WaitOrder(ctx context.Context, url string) (*acme.Order, error) {
+ 	l.log.V(logf.TraceLevel).Info(""Calling WaitOrder"")
+ ","Seems a bit weird to add a timeout in ""logging"" middleware, but I see that that is done elsewhere, so fine.","I think this should be `ctx, cancel := context.WithTimeout(ctx, timeout)`"
+9105,"@@ -25,7 +25,7 @@ export default AbstractIndexRoute.extend(ModalHelper, UserSession, {
+   actions: {
+     deleteItem(item) {
+       let i18n = this.get('i18n');
+-      let message = i18n.t('admin.customForms.messages.deleteForm');
++      let message = i18n.t('messages.delete_singular', { name: 'form' });
+       let model = Ember.Object.create({
+         itemToDelete: item
+       });",This code is passing a non localized string when it should be passing in a localized string or it should use the name of the item being deleted.,I think this should be `delete_singular_form`
+9106,"@@ -556,6 +556,13 @@ class Uppy {
+       files: updatedFiles
+     })
+ 
++    // If nothing is uploading anymore, and if nothing has uploaded yet - allow new uploads!
++    if (Object.keys(updatedFiles).length === 0) {
++      this.setState({
++        allowNewUpload: true
++      })
++    }
++
+     removeUploads.forEach((uploadID) => {
+       this._removeUpload(uploadID)
+     })","Could we combine this with the `setState` call above, so we don't have to call it twice?",Why do we need to set the state here?
+9107,"@@ -31,10 +31,10 @@ class String
+   end
+ 
+   def fix_encoding_if_invalid!
+-    unless valid_encoding?
+-      encode!('utf-8', 'binary', invalid: :replace, undef: :replace)
+-    end
+-    force_encoding('utf-8')
++    # All new strings claim to be 8-bit ASCII in the DB, but are really saved as UTF-8...
++    force_encoding('utf-8') unless encoding == 'UTF-8'
++    # ...but old strings are a hodge-podge of encodings, so replace any unrecognizable characters with unknowns.
++    encode!('utf-8', invalid: :replace, undef: :replace) unless valid_encoding?
+     self
+   end
+ ","That part that still leaves me mystified is how the String class, when populated with a value from the SQL_ASCII encoded database is set to ""UTF-8"" encoding. Since the database is SQL_ASCII, each byte in the string stored in the database is considered one character. Ruby, however, is using UTF-8, which is writing a series of one-byte code points that are only meaningful when considered in the correct encoding. When Ruby passes a string to Postgresql, the code points are essentially ""flattened"" into bytes as they are written to the DB. When Rails (through Ruby) asks for a string from the DB, where does the information about the encoding come from?",I don't think this is the right way to do this. The problem is that if th
+9108,"@@ -233,13 +233,14 @@ func PrecreatedDaoOption(dao *blockDAO) Option {
+ 	}
+ }
+ 
+-// BoltDBDaoOption sets blockchain's dao with BoltDB from config.Chain.ChainDBPath
++// BoltDBDaoOption sets blockchain's dao with BoltDB from config.Chain.ChainDBPath and cfg.DB.IndexDBPath
+ func BoltDBDaoOption() Option {
+ 	return func(bc *blockchain, cfg config.Config) error {
+ 		cfg.DB.DbPath = cfg.Chain.ChainDBPath // TODO: remove this after moving TrieDBPath from cfg.Chain to cfg.DB
+ 		_, gateway := cfg.Plugins[config.GatewayPlugin]
+ 		bc.dao = newBlockDAO(
+-			db.NewBoltDB(cfg.DB),
++			db.NewBoltDB(cfg.DB, cfg.DB.DbPath),
++			db.NewBoltDB(cfg.DB, cfg.DB.IndexDBPath),
+ 			gateway && !cfg.Chain.EnableAsyncIndexWrite,
+ 			cfg.Chain.CompressBlock,
+ 			cfg.Chain.MaxCacheSize,",Is it a doable way and does it make sense.,Shouldn't this be `cfg.DB.TrieDBPath`?
+9109,"@@ -95,7 +95,10 @@ def verify_limit_range(limit):
+     max_query_limit = constants.MAX_QUERY_SIZE
+     if limit > max_query_limit:
+         LOG.warning('Query limit %d was larger than max query limit %d, '
+-                    'setting limit to %d', limit, max_query_limit, max)
++                    'setting limit to %d',
++                    limit,
++                    max_query_limit,
++                    max_query_limit)
+         limit = max_query_limit
+     return limit
+ ","max was wrong here. As its buitlt-in, not a number, and a TypeError was thrown.",Why did you change this?
+9110,"@@ -1,3 +1,5 @@
++#! /usr/bin/env python
++
+ # MIT License
+ 
+ # Copyright (c) 2018 Jose Amores","This change is not needed, please revert it.",Why is this needed?
+9111,"@@ -40,7 +40,9 @@ def train(params, train_set, num_boost_round=100,
+         Customized objective function.
+     feval : callable or None, optional (default=None)
+         Customized evaluation function.
++        Should accept two parameters: preds, train_data.
+         Note: should return (eval_name, eval_result, is_higher_better) or list of such tuples.
++        To ignore the default metric in params, set it to the string ``""None""``
+     init_model : string or None, optional (default=None)
+         Filename of LightGBM model or Booster instance used for continue training.
+     feature_name : list of strings or 'auto', optional (default=""auto"")","@ClimbsRocks Please add that it could be a string. `feval : callable, string or None, optional (default=None)`",I don't think this is the right way to
+9112,"@@ -1,7 +1,7 @@
+ # frozen_string_literal: true
+ 
+ module Faker
+-  class Sports
++  class Sports < Base
+     class Basketball < Base
+       class << self
+         ##","now that I have started using, I realized, I could have named my new class singular `Sport` and not having to make this change. let me know, I will update",Style/ClassAndModuleChildren: Use module/class definitions instead of compact style.
+9113,"@@ -23,7 +23,7 @@ func GetApps() map[string][]App {
+ 	apps := make(map[string][]App)
+ 	for platformType := range PluginMap {
+ 		labels := map[string]string{
+-			""com.ddev.platform"":          platformType,
++			""com.ddev.platform"":          ""ddev"",
+ 			""com.docker.compose.service"": ""web"",
+ 		}
+ 		sites, err := dockerutil.FindContainersByLabels(labels)",Not sure why this is changing to a hard-coded string.,Why did you change this?
+9114,"@@ -453,6 +453,15 @@ class FlowContentView(RequestHandler):
+         ))
+ 
+ 
++class Commands(RequestHandler):
++    def post(self):
++        result = self.master.commands.execute(self.json[""command""])
++        if result is None:
++            self.write({""result"": """"})
++            return
++        self.write({""result"": str(result)})
++
++
+ class Events(RequestHandler):
+     def get(self):
+         self.write([logentry_to_json(e) for e in self.master.events.data])","Is there a reason why we `str` the result? It would be nice to eventually support more datatypes here, so we want to generally aim for arbitrary JSON.",Why is this necessary?
+9115,"@@ -29,7 +29,7 @@ import java.util.Iterator;
+ import java.util.List;
+ import java.util.Map;
+ import java.util.Set;
+-import org.apache.commons.lang.SerializationUtils;
++import org.apache.commons.lang3.SerializationUtils;
+ import org.apache.hadoop.io.Writable;
+ import org.apache.hadoop.mapreduce.InputFormat;
+ import org.apache.hadoop.mapreduce.InputSplit;",Why did we update the to this api?,Why is this change needed?
+9116,"@@ -164,4 +164,17 @@ public class Preferences {
+     public SharedPreferences getPreferences() {
+         return mStorage;
+     }
++
++    public static <T extends Enum<T>> T getEnumStringPref(SharedPreferences prefs, String key, T defaultEnum) {
++        String stringPref = prefs.getString(key, defaultEnum.name());
++        try {
++            return Enum.valueOf(defaultEnum.getDeclaringClass(), stringPref);
++        } catch (Exception ex) {
++            Log.w(K9.LOG_TAG, ""Unable to convert preference key ["" + key +
++                    ""] value ["" + stringPref + ""] to enum of type "" + defaultEnum.getDeclaringClass(), ex);
++
++            return defaultEnum;
++        }
++    }
++
+ }",should probably just catch `IllegalArgumentException` here,Should we log the exception here?
+9117,"@@ -38,7 +38,9 @@ type truncateFunc func(t Time, d Duration) Time
+ func (w *Window) getTruncateFunc(d Duration) (truncateFunc, error) {
+ 	switch months, nsecs := d.Months(), d.Nanoseconds(); {
+ 	case months != 0 && nsecs != 0:
+-		return nil, errors.New(codes.Invalid, ""duration used as an interval cannot mix month and nanosecond units"")
++		const docURL = ""https://v2.docs.influxdata.com/v2.0/reference/flux/stdlib/built-in/transformations/window/#calendar-months-and-years""
++		return nil, errors.New(codes.Invalid, ""duration used as an interval cannot mix month and nanosecond units"").
++			WithDocURL(docURL)
+ 	case months != 0:
+ 		return truncateByMonths, nil
+ 	case nsecs != 0:",What does this error message mean?,I think this should be `errors.Ne
+9118,"@@ -864,7 +864,7 @@ def get_utf8_value(value):
+         return value
+ 
+     if not isinstance(value, six.string_types):
+-        value = six.text_type(value)
++        value = six.text_type(value).encode('utf-8')
+ 
+     if isinstance(value, six.text_type):
+         value = value.encode('utf-8')","I don't think this change is necessary. If we cast `value` to type `six.text_type`, then the next if statement should evaluate to True and do the encoding for us.",Why is this needed?
+9119,"@@ -54,6 +54,11 @@ class CartItem < ActiveRecord::Base
+             )
+           end
+         end
++      else
++        self.cart_item_traits.build(
++          name: trait[0],
++          value: handle_trait_values_for(trait)
++        )
+       end
+     end
+   end",Can we move this into a method(s)?,Extra empty line detected at clas
+9120,"@@ -22,3 +22,13 @@ func uitoa(val uint) string {
+ 	buf[i] = byte(val + '0')
+ 	return string(buf[i:])
+ }
++
++// clen returns the index of the first NULL byte in n or len(n) if n contains no NULL byte.
++func clen(n []byte) int {
++	for i := 0; i < len(n); i++ {
++		if n[i] == 0 {
++			return i
++		}
++	}
++	return len(n)
++}",You could perhaps call this `strlen` (although I don't particularly care about the name as it is an implementation detail).,`clen` is unused (from `deadcode`)
+9121,"@@ -15,13 +15,8 @@ public class Regula
+ {
+     public const int Iterations = 4000000;
+ 
+-    public static volatile object VolatileObject;
+-
+     [MethodImpl(MethodImplOptions.NoInlining)]
+-    private static void Escape(object obj)
+-    {
+-        VolatileObject = obj;
+-    }
++    private static void Escape(object _) { }
+ 
+     [Benchmark(Description = nameof(Regula))]
+     public bool Test()",should we have a common `Escape()` method that can be used everywhere?,Why did you remove this?
+9122,"@@ -228,7 +228,6 @@ export function diff(
+  */
+ export function commitRoot(commitQueue, root) {
+ 	if (options._commit) options._commit(root, commitQueue);
+-
+ 	commitQueue.some(c => {
+ 		try {
+ 			commitQueue = c._renderCallbacks;",The whitespace removal above here is probably unintentional :slightly_smiling_face:,Why was this removed?
+9123,"@@ -90,14 +90,14 @@ func newServer(cfg config.Config, testing bool) (*Server, error) {
+ func (s *Server) Start(ctx context.Context) error {
+ 	cctx, cancel := context.WithCancel(context.Background())
+ 	s.subModuleCancel = cancel
+-	if err := s.p2pAgent.Start(cctx); err != nil {
+-		return errors.Wrap(err, ""error when starting P2P agent"")
+-	}
+ 	for _, cs := range s.chainservices {
+ 		if err := cs.Start(cctx); err != nil {
+ 			return errors.Wrap(err, ""error when starting blockchain"")
+ 		}
+ 	}
++	if err := s.p2pAgent.Start(cctx); err != nil {
++		return errors.Wrap(err, ""error when starting P2P agent"")
++	}
+ 	if err := s.dispatcher.Start(cctx); err != nil {
+ 		return errors.Wrap(err, ""error when starting dispatcher"")
+ 	}",should we start p2p even after dispatcher? b/c dispatcher handles msg from p2p,Why did you remove this?
+9124,"@@ -101,13 +101,13 @@ func TestHandleInterfaceEmptySuccess(t *testing.T) {
+ 	handler := jsonHandler{reader: ifaceEmptyReader{}, handler: reflect.ValueOf(h)}
+ 
+ 	reqBuf := yarpc.NewBufferString(`[""a"", ""b"", ""c""]`)
+-	_, _, err := handler.Handle(context.Background(), &yarpc.Request{
++	_, respBuf, err := handler.Handle(context.Background(), &yarpc.Request{
+ 		Procedure: ""foo"",
+ 		Encoding:  ""json"",
+ 	}, reqBuf)
+ 
+ 	require.NoError(t, err)
+-	assert.JSONEq(t, `[""a"", ""b"", ""c""]`, reqBuf.String())
++	assert.JSONEq(t, `[""a"", ""b"", ""c""]`, respBuf.String())
+ }
+ 
+ func TestHandleSuccessWithResponseHeaders(t *testing.T) {",Did we decide once and for all to use req/resp throughout spring?,Why did this change?
+9125,"@@ -8,8 +8,13 @@ describe ""videos/_access_callout"" do
+ 
+         render_callout video, signed_out: true
+ 
+-        expect(rendered).to have_css "".access-callout.auth-to-access""
+-        expect(rendered).to have_auth_to_access_link_for(video)
++        expect(rendered).to have_content(
++          I18n.t(""videos.show.auth_to_access_callout_text"")
++        )
++        expect(rendered).to have_link(
++          I18n.t(""videos.show.auth_to_access_button_text""),
++          href: video_auth_to_access_path(video),
++        )
+       end
+     end
+ ",Put a comma after the last parameter of a multiline method call.,I'm not sure if this
+9126,"@@ -71,8 +71,18 @@ func populateScratchBucketGcsPath(scratchBucketGcsPath *string, zone string, mgc
+ 		if err != nil {
+ 			return """", daisy.Errf(""invalid scratch bucket GCS path %v"", scratchBucketGcsPath)
+ 		}
++
+ 		if !scratchBucketCreator.IsBucketInProject(*project, scratchBucketName) {
+-			return """", daisy.Errf(""Scratch bucket `%v` is not in project `%v`"", scratchBucketName, *project)
++			err := storageClient.DeleteGcsPath(*scratchBucketGcsPath)
++			var deletionResults string
++			if err == nil {
++				deletionResults = fmt.Sprintf(""The resources in %q have been deleted."", *scratchBucketGcsPath)
++			} else {
++				deletionResults = fmt.Sprintf(""Failed to delete resources in %q. Check with the owner of %q for more information"",
++					*scratchBucketGcsPath, scratchBucketName)
++			}
++			return """", daisy.Errf(""Scratch bucket %q is not in project %q. %s"",
++				scratchBucketName, *project, deletionResults)
+ 		}
+ 
+ 		scratchBucketAttrs, err := storageClient.GetBucketAttrs(scratchBucketName)","This will delete the whole bucket, which could have unforseen consequences in normal use cases. We should be deleting args.SourceFile instead.",I think this should 
+9127,"@@ -721,5 +721,9 @@ public class Constants {
+     // Constant to allow test version to be passed as flow parameter. Passing test version will be
+     // allowed for Azkaban ADMIN role only
+     public static final String FLOW_PARAM_ALLOW_IMAGE_TEST_VERSION = ""allow.image.test.version"";
++
++    //
++    public static final String FLOW_PARAM_ALLOW_RESTART_ON_EXECUTION_STOPPED = ""allow""
++        + "".restart.on.execution.stopped"";
+   }
+ }",Lets move the whole string to next line for better readability,Can we remove this?
+9128,"@@ -104,7 +104,7 @@ app.controller('CalendarListController', ['$scope', '$rootScope', '$window', 'Ha
+ 						$scope.subscription.newSubscriptionLocked = false;
+ 					})
+ 					.catch(function() {
+-						OC.Notification.showTemporary(t('calendar', 'Error saving WebCal-calendar'));
++						OC.Notification.showTemporary(t('calendar', 'Could not save WebCal-calendar'));
+ 						$scope.subscription.newSubscriptionLocked = false;
+ 					});
+ 			}).catch(function(reason) {",Please change this back to `Error saving WebCal-calendar` (and `Error saving WebCal-calendar` only),Shouldn't this be `Could not save Calendar`?
+9129,"@@ -284,7 +284,6 @@ function getDefaultService() {
+ Options.prototype.CAPABILITY_KEY = 'goog:chromeOptions'
+ Options.prototype.BROWSER_NAME_VALUE = Browser.CHROME
+ Driver.getDefaultService = getDefaultService
+-Driver.prototype.VENDOR_COMMAND_PREFIX = 'goog'
+ 
+ // PUBLIC API
+ exports.Driver = Driver",The vendor prefix is still being used on Chromium based browsers like Edge Chromium and Chrome. Did you mean to remove this?,Why was this removed?
+9130,"@@ -3,14 +3,18 @@ using Datadog.Trace.Logging;
+ using Datadog.Trace.Logging.LogProviders;
+ using NLog;
+ using NLog.Config;
++using NLog.Layouts;
+ using NLog.Targets;
+ using Xunit;
+ 
+ namespace Datadog.Trace.Tests.Logging
+ {
+     [Collection(nameof(Datadog.Trace.Tests.Logging))]
++    [TestCaseOrderer(""Datadog.Trace.TestHelpers.AlphabeticalOrderer"", ""Datadog.Trace.TestHelpers"")]
+     public class NLogLogProviderTests
+     {
++        private const string ExpectedStringFormat = ""\""{0}\"": \""{1}\"""";
++
+         private readonly ILogProvider _logProvider;
+         private readonly ILog _logger;
+         private readonly MemoryTarget _target;","Not ideal, but I used a test case orderer so I could avoid a bug that occurs when running two tracer's sequentially with different DD_LOGS_INJECTION settings.",Why do we need this?
+9131,"@@ -129,6 +129,13 @@ func (p *Packer) Size() uint {
+ 	return p.bytes
+ }
+ 
++// HeaderFull returns true if the pack header is at maximum capacity.
++func (p *Packer) HeaderFull() bool {
++	p.m.Lock()
++	defer p.m.Unlock()
++	return EntrySize+crypto.Extension+(uint(headerLengthSize)*uint(len(p.blobs)-1)) <= uint(maxHeaderSize)
++}
++
+ // Count returns the number of blobs in this packer.
+ func (p *Packer) Count() int {
+ 	p.m.Lock()","I think the condition should be ` uint(headerLengthSize) + crypto.Extension + (len(p.blobs)+1)*uint(EntrySize) > uint(maxHeaderSize)` `headerLengthSize` is only the length field. But the pack header also includes the blob type and its ID. And the result of the check, currently seems to be inverted.",`EntrySize+crypto.Extension+(uint(headerLeng
+9132,"@@ -19,7 +19,6 @@ namespace Nethermind.Mev.Test
+ {
+     public enum SelectorType
+     {
+-        V1,
+         V2,
+     }
+ }",Remove selector if only 1 version is supported,Why was this removed?
+9133,"@@ -1188,7 +1188,7 @@ class Application extends BaseApplication {
+ 		const selectedNoteIds = state.selectedNoteIds;
+ 		const note = selectedNoteIds.length === 1 ? await Note.load(selectedNoteIds[0]) : null;
+ 
+-		for (const itemId of ['copy', 'paste', 'cut', 'selectAll', 'bold', 'italic', 'link', 'code', 'insertDateTime', 'commandStartExternalEditing', 'showLocalSearch']) {
++		for (const itemId of ['paste', 'cut', 'bold', 'italic', 'link', 'code', 'insertDateTime']) {
+ 			const menuItem = Menu.getApplicationMenu().getMenuItemById(`edit:${itemId}`);
+ 			if (!menuItem) continue;
+ 			const isHtmlNote = !!note && note.markup_language === MarkupToHtml.MARKUP_LANGUAGE_HTML;",Why did you remove more than the asked command?,Why did you remove `s
+9134,"@@ -320,11 +320,15 @@ func (s *session) handlePacketImpl(p *receivedPacket) error {
+ 		s.largestRcvdPacketNumber,
+ 		hdr.PacketNumber,
+ 	)
+-	if utils.Debug() {
+-		utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, time.Now().Format(""15:04:05.000""))
+-	}
+ 
+ 	packet, err := s.unpacker.Unpack(hdr.Raw, hdr, data)
++	if utils.Debug() {
++		if err != nil {
++			utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, time.Now().Format(""15:04:05.000""))
++		} else {
++			utils.Debugf(""<- Reading packet 0x%x (%d bytes) for connection %x, %s @ %s"", hdr.PacketNumber, len(data)+len(hdr.Raw), hdr.ConnectionID, packet.encryptionLevel, time.Now().Format(""15:04:05.000""))
++		}
++	}
+ 	// if the decryption failed, this might be a packet sent by an attacker
+ 	// don't update the remote address
+ 	if quicErr, ok := err.(*qerr.QuicError); ok && quicErr.ErrorCode == qerr.DecryptionFailure {","I just realized that we are logging time now - we shouldn't do that here, that's the logger's job. I've opened a new issue for that #444.",I think it would be b
+9135,"@@ -44,13 +44,13 @@ const char *MolHolderBaseDoc =
+     ""The API is quite simple: \n""
+     ""  AddMol(mol) -> adds a molecule to the molecule holder, returns index of ""
+     ""molecule\n""
+-    ""  GetMol(idx) -> return the molecule at index idx\n"";
++    ""  GetMol(idx,sanitize=True) -> return the molecule at index idx\n"";
+ 
+ const char *MolHolderDoc =
+     ""Holds raw in-memory molecules\n""
+     ""  AddMol(mol) -> adds a molecule to the molecule holder, returns index of ""
+     ""molecule\n""
+-    ""  GetMol(idx) -> return the molecule at index idx\n"";
++    ""  GetMol(idx,sanitize=True) -> return the molecule at index idx\n"";
+ 
+ const char *CachedMolHolderDoc =
+     ""Holds molecules in their binary representation.\n""",why is the `sanitize=True` here in the docs?,Why do we need to san
+9136,"@@ -9,6 +9,9 @@ class Approval < ActiveRecord::Base
+   end
+ 
+   belongs_to :proposal
++  belongs_to :user
++  has_many :delegations, through: :user, source: :outgoing_delegates
++  has_many :delegates, through: :delegations, source: :assignee
+   acts_as_list scope: :proposal
+ 
+   belongs_to :parent, class_name: 'Approval'","Didn't end up using this, but I think it's useful anyway.",I think this belongs_to belongs_to belongs_to :assignee
+9137,"@@ -121,7 +121,16 @@ namespace Microsoft.DotNet.Build.Tasks
+                 // Every test project comes with 4 of them, so not producing a warning here.
+                 else if (!string.IsNullOrEmpty(relativePath))
+                 {
+-                    copyCommands.AppendLine($""call :copyandcheck \""%PACKAGE_DIR%\\{relativePath}\"" \""%EXECUTION_DIR%\\{Path.GetFileName(relativePath)}\"" ||  exit /b -1"");
++                    bool? preserveSubDirectories = dependency.GetMetadata(""PreserveSubDirectories"")?.Equals(""true"", StringComparison.OrdinalIgnoreCase);
++                    string filePath = Path.GetFileName(relativePath);
++                    if (preserveSubDirectories == true)
++                    {
++                        //This is to remove the first two directories on the path which will always be the dependency followed by the version used
++                        int indexOfSubDirectories = relativePath.IndexOf(""\\"", relativePath.IndexOf(""\\"")+1);
++                        filePath = relativePath.Substring(indexOfSubDirectories);
++                        copyCommands.AppendLine($""call :makedir \""%EXECUTION_DIR%{Path.GetDirectoryName(filePath)}\"" ||  exit /b -1"");
++                    }
++                    copyCommands.AppendLine($""call :copyandcheck \""%PACKAGE_DIR%\\{relativePath}\"" \""%EXECUTION_DIR%\\{filePath}\"" ||  exit /b -1"");
+                 }
+             }
+             cmdExecutionTemplate = cmdExecutionTemplate.Replace(""[[CopyFilesCommands]]"", copyCommands.ToString());",I'm pretty sure there's already a metadata item that contains what you're calculating here (PackageRelativePath)?,nit: space after `//`
+9138,"@@ -79,6 +79,15 @@ module ProjectsHelper
+     end
+   end
+ 
++  def browse_security_button(project)
++    css_class = project.uuid.blank? ? 'disabled' : 'btn-primary'
++    project_name = CGI.escape(project.name)
++    url = ENV['OH_SECURITY_URL'] + ""/#{project_name}/#{project.uuid}?project_id=#{project.id}""
++    haml_tag :a, href: url, class: ""btn #{css_class}"", target: '_blank' do
++      concat t('projects.browse_security')
++    end
++  end
++
+   private
+ 
+   def project_twitter_description_analysis(project, analysis)",We want to show this button only when there is a page for us to connect to. There is no reason to put the Browse Security Info button on the page at all unless we've identified the UUID from the KB.,I don't think you need the `target: '_blank'` here
+9139,"@@ -42,10 +42,14 @@
+ #include ""res/windowsicon.xpm""
+ #include ""res/macosicon.xpm""
+ #include ""res/linuxicon.xpm""
++#include ""res/androidicon.xpm""
+ #include ""res/freebsdicon.xpm""
++#include ""res/linuxarmicon2.xpm""
+ #include ""res/atiicon.xpm""
++#include ""res/amdicon2.xpm""
+ #include ""res/nvidiaicon.xpm""
+-#include ""res/androidicon.xpm""
++#include ""res/nvidiaicon2.xpm""
++#include ""res/intelgpuicon2.xpm""
+ #include ""res/virtualboxicon.xpm""
+ #include ""res/blankicon.xpm""
+ ",Why `2` in this and others?,Why is this needed?
+9140,"@@ -118,6 +118,7 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting
+             var testHostProcessName = (this.architecture == Architecture.X86) ? X86TestHostProcessName : X64TestHostProcessName;
+             var currentWorkingDirectory = Path.GetDirectoryName(typeof(DefaultTestHostManager).GetTypeInfo().Assembly.Location);
+             var argumentsString = "" "" + Constants.PortOption + "" "" + connectionInfo.Port;
++            argumentsString += "" "" + Constants.ParentProcessIdOption + "" "" + processHelper.GetCurrentProcessId();
+ 
+             var testhostProcessPath = Path.Combine(currentWorkingDirectory, testHostProcessName);
+ ","This may cause a new allocation, please consider merging the concat in above line. Same applies to change in dotnethostmanager.",Why do we need this?
+9141,"@@ -490,6 +490,16 @@ given file (report RP0402 must not be disabled)'}
+                 importedname = node.modname
+             else:
+                 importedname = node.names[0][0].split('.')[0]
++        if isinstance(node, astroid.ImportFrom) and \
++                node.as_string().startswith('from .'):
++            # We need the impotedname with first point to detect local package
++            # Example of node:
++            #  'from .my_package1 import MyClass1'
++            #  the output should be '.my_package1' instead of 'my_package1'
++            # Example of node:
++            #  'from . import my_package2'
++            #  the output should be '.my_package2' instead of '{pyfile}'
++            importedname = '.' + importedname
+         self._imports_stack.append((node, importedname))
+ 
+     @staticmethod","Alternatively (and better) would be to look for the .level attribute of the node. If it's bigger or equal to 1, than that is a relative import. So ""from . import x"" should have level 1, while ""from .. import z"" should have level 2 and so on. The same should happen for ""from .c import z"".",I'm not sure if this
+9142,"@@ -25,4 +25,14 @@ public abstract class AbstractASTXPathHandler implements XPathHandler {
+     public void initialize(IndependentContext context, Language language, Class<?> functionsClass) {
+         context.declareNamespace(""pmd-"" + language.getTerseName(), ""java:"" + functionsClass.getName());
+     }
++
++    @Override
++    public void initialize() {
++        // override if needed
++    }
++
++    @Override
++    public void initialize(IndependentContext context) {
++        // override if needed
++    }
+ }","Btw. this API must definitely change with PMD 7 - we are exposing here a implementation detail (that we use Saxon). And it happens, that the way, how custom functions are registered, changed with Saxon 9.5... which makes the need for a implementation agnostic API relevant...",Why is this needed?
+9143,"@@ -44,6 +44,8 @@ type GenericDeploymentSpec struct {
+ 	Timeout Duration `json:""timeout,omitempty"" default:""6h""`
+ 	// List of encrypted secrets and targets that should be decoded before using.
+ 	Encryption *SecretEncryption `json:""encryption""`
++	// Notification to be sent to users via Slack or email
++	Notification *Notification `json:""notification""`
+ }
+ 
+ type DeploymentPlanner struct {",nit: `Additional configuration used while sending notification to external services.`,Why is this a pointe
+9144,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",I think this should be `nameOrHandle`
+9145,"@@ -247,7 +247,7 @@ describe 'LinksControllerTest' do
+ 
+     get :new, project_id: project.url_name, category_id: category_id
+     assigns(:category_name).must_equal 'Homepage'
+-    assigns(:link).title.must_equal :Homepage
++    assigns(:link).title.must_equal 'Homepage'
+   end
+ 
+   it 'load_category_and_title_for_new_download_link' do",This should have failed before.,Prefer single-quoted strings when you
+9146,"@@ -0,0 +1,19 @@
++package paymentchannel
++
++import (
++	""github.com/filecoin-project/go-address""
++	""github.com/filecoin-project/specs-actors/actors/builtin/paych""
++)
++
++// ChannelInfo is the primary payment channel record
++type ChannelInfo struct {
++	Owner    address.Address // Payout (From) address for this channel, has ability to sign and send funds
++	State    *paych.State
++	Vouchers []*VoucherInfo // All vouchers submitted for this channel
++}
++
++// Voucher Info is a record of a voucher submitted for a payment channel
++type VoucherInfo struct {
++	Voucher *paych.SignedVoucher
++	Proof   []byte
++}",the paymentchannel dir is where the paymentchannel manager will live. it will store the types below.,Why is this a pointer?
+9147,"@@ -219,7 +219,9 @@ webdriver.CommandName = {
+   GET_SESSION_LOGS: 'getSessionLogs',
+ 
+   // Non-standard commands used by the standalone Selenium server.
+-  UPLOAD_FILE: 'uploadFile'
++  UPLOAD_FILE: 'uploadFile', 
++
++  GET_CANVAS_URL: 'getCanvasUrl'
+ };
+ 
+ ",This is Safari specific and should be defined somewhere in the `safaridriver` namespace,I think this should be `getCanvasUrl`
+9148,"@@ -58,13 +58,13 @@ func TestNewRound(t *testing.T) {
+ 	require := require.New(t)
+ 	bc, roll := makeChain(t)
+ 	rc := &roundCalculator{bc, true, roll, bc.CandidatesByHeight, 0}
+-	proposer, err := rc.calculateProposer(5, 1, []string{""1"", ""2"", ""3"", ""4"", ""5""})
++	_, err := rc.calculateProposer(5, 1, []string{""1"", ""2"", ""3"", ""4"", ""5""})
+ 	require.Error(err)
+ 	var validDelegates [24]string
+ 	for i := 0; i < 24; i++ {
+ 		validDelegates[i] = identityset.Address(i).String()
+ 	}
+-	proposer, err = rc.calculateProposer(5, 1, validDelegates[:])
++	proposer, err := rc.calculateProposer(5, 1, validDelegates[:])
+ 	require.NoError(err)
+ 	require.Equal(validDelegates[6], proposer)
+ ",assignments should only be cuddled with other assignments (from `wsl`),why this change?
+9149,"@@ -641,12 +641,13 @@ Blockly.genUid.soup_ = '!#%()*+,-./:;=?@[]^_`{|}~' +
+  * Measure some text using a canvas in-memory.
+  * @param {string} fontSize E.g., '10pt'
+  * @param {string} fontFamily E.g., 'Arial'
++ * @param {string} fontWeight E.g., '600'
+  * @param {string} text The actual text to measure
+  * @return {number} Width of the text in px.
+  */
+-Blockly.measureText = function(fontSize, fontFamily, text) {
++Blockly.measureText = function(fontSize, fontFamily, fontWeight, text) {
+   var canvas = document.createElement('canvas');
+   var context = canvas.getContext('2d');
+-  context.font = fontSize + fontFamily;
++  context.font = fontWeight + ' ' + fontSize + ' ' + fontFamily;
+   return context.measureText(text).width;
+ };","prefer changing the signature by adding params to the end, not the middle, I think.",I think this sho
+9150,"@@ -301,6 +301,15 @@ func makeStatefulSetService(p *monitoringv1.Prometheus, config Config) *v1.Servi
+ 			},
+ 		},
+ 	}
++
++	if p.Spec.Thanos != nil {
++		svc.Spec.Ports = append(svc.Spec.Ports, v1.ServicePort{
++			Name:       ""grpc"",
++			Port:       10901,
++			TargetPort: intstr.FromString(""grpc""),
++		})
++	}
++
+ 	return svc
+ }
+ ",I guess we aim for hardcoded port for Prometheus operated ports right?,Why do we need t
+9151,"@@ -602,8 +602,10 @@ class FormatChecker(BaseTokenChecker):
+             isinstance(node.parent, nodes.TryFinally) and node in node.parent.finalbody
+         ):
+             prev_line = node.parent.body[0].tolineno + 1
++        elif isinstance(node.parent, nodes.Module):
++            prev_line = 0
+         else:
+-            prev_line = node.parent.statement().fromlineno
++            prev_line = node.parent.statement(future=True).fromlineno
+         line = node.fromlineno
+         assert line, node
+         if prev_line == line and self._visited_lines.get(line) != 2:",This is the same effect as doing `node.parent.fromlineno` but avoids the `StatementMissing` exception from calling `statement`.,I think this sho
+9152,"@@ -165,12 +165,15 @@ def request_candidate_sets(days, top, similar):
+ @cli.command(name='request_recommendations')
+ @click.option(""--top"", type=int, default=200, help=""Generate given number of top artist recommendations"")
+ @click.option(""--similar"", type=int, default=200, help=""Generate given number of similar artist recommendations"")
+-def request_recommendations(top, similar):
++@click.option(""--mb_id"", callback=parse_list, default=[], multiple=True, help=""Generate recommendations for given users"" \
++              "" Generate recommendation for all users by default."")
++def request_recommendations(top, similar, mb_id):
+     """""" Send the cluster a request to generate recommendations.
+     """"""
+     params = {
+         'recommendation_top_artist_limit': top,
+         'recommendation_similar_artist_limit': similar,
++        'musicbrainz_id': mb_id
+     }
+     send_request_to_spark_cluster(_prepare_query_message('cf_recording.recommendations.recommend', params=params))
+ ","I think user-ids might be better; also note that options should use - and not _ to separate words. Also, how are more than one id specified? comma seperated? I think the usage statement should indicate this.",I think this should be called `--user_id`
+9153,"@@ -117,14 +117,7 @@ func nanosecondsToTicks(ns int64) timeUnit {
+ 
+ // sleepTicks should sleep for specific number of microseconds.
+ func sleepTicks(d timeUnit) {
+-	for d != 0 {
+-		ticks()            // update timestamp
+-		ticks := uint32(d) // current scaling only supports 100 usec to 6553 msec
+-		if !timerSleep(ticks) {
+-			return
+-		}
+-		d -= timeUnit(ticks)
+-	}
++	timerSleep(uint32(d))
+ }
+ 
+ // number of ticks (microseconds) since start.",This code is necessary. It makes sure that you can sleep for longer durations than the timer supports.,Why did you remove this code?
+9154,"@@ -96,7 +96,7 @@ public interface ExpireSnapshots extends PendingUpdate<List<Snapshot>> {
+    * @param executorService an executor service to parallelize tasks to delete manifests and data files
+    * @return this for method chaining
+    */
+-  ExpireSnapshots executeWith(ExecutorService executorService);
++  ExpireSnapshots executeDeleteWith(ExecutorService executorService);
+ 
+   /**
+    * Allows expiration of snapshots without any cleanup of underlying manifest or data files.",Can we add the new name in parallel and deprecate this name? We should be careful about changes to the public API and give people at least a release to switch over before removing public methods.,I think this should be renamed to `delete
+9155,"@@ -32,8 +32,10 @@ bool wlr_backend_start(struct wlr_backend *backend) {
+ }
+ 
+ void wlr_backend_destroy(struct wlr_backend *backend) {
+-	if (backend->impl->destroy) {
++	if (backend->impl && backend->impl->destroy) {
+ 		backend->impl->destroy(backend);
++	} else {
++		free(backend);
+ 	}
+ }
+ ",If you're going to start testing that impl itself is not NULL you should probably be doing it everywhere.,Shouldn't this be `if (backend->impl)`?
+9156,"@@ -159,7 +159,7 @@ func ParseFromStructuredObject(s interface{}) (Manifest, error) {
+ 	}, nil
+ }
+ 
+-func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string) ([]Manifest, error) {
++func LoadPlainYAMLManifests(ctx context.Context, dir string, names []string, configFileName string) ([]Manifest, error) {
+ 	// If no name was specified we have to walk the app directory to collect the manifest list.
+ 	if len(names) == 0 {
+ 		err := filepath.Walk(dir, func(path string, f os.FileInfo, err error) error {",`ctx` is unused in LoadPlainYAMLManifests,nit: `configFileName` -> `configFileName`
+9157,"@@ -87,7 +87,7 @@ public class BlockHeaderBuilder {
+   }
+ 
+   public static BlockHeaderBuilder fromBuilder(final BlockHeaderBuilder fromBuilder) {
+-    BlockHeaderBuilder toBuilder =
++    final BlockHeaderBuilder toBuilder =
+         create()
+             .parentHash(fromBuilder.parentHash)
+             .ommersHash(fromBuilder.ommersHash)",why is this called toBuilder when the method is called fromBuilder? (I realise you did not change this...),why this change?
+9158,"@@ -40,4 +40,10 @@ public class FlinkConfigOptions {
+           .intType()
+           .defaultValue(100)
+           .withDescription(""Sets max infer parallelism for source operator."");
++
++  public static final ConfigOption<Integer> SOURCE_READER_FETCH_BATCH_SIZE = ConfigOptions
++      .key(""source.iceberg.reader.fetch-batch-size"")
++      .intType()
++      .defaultValue(2048)
++      .withDescription(""The target batch size for split reader fetch."");
+ }",nit: seems rather large.,This should be `source.iceberg.reader.fet
+9159,"@@ -119,7 +119,7 @@ def get_listens(user_name):
+     latest_listen = db_conn.fetch_listens(
+         user_name,
+         limit=1,
+-        to_ts=max_ts,
++        to_ts=int(time.time()),
+     )
+     latest_listen_ts = latest_listen[0].ts_since_epoch if len(latest_listen) > 0 else 0
+ ",I think it'd make sense to only calculate time.time() once (it's also used if max_ts and min_ts aren't set),I think this should be `max_ts`
+9160,"@@ -53,6 +53,8 @@ public abstract class TestCaseView {
+ 
+   public abstract GrpcStreamingType grpcStreamingType();
+ 
++  public abstract String grpcStubTypeName();
++
+   public abstract String mockGrpcStubTypeName();
+ 
+   public abstract String createStubFunctionName();",Use existing `grpcStubCallString` instead,public abstract String createStubFunctionName();
+9161,"@@ -0,0 +1,7 @@
++namespace Datadog.Trace
++{
++    internal static class TraceConstants
++    {
++        public const ulong MaxTraceId = 9_223_372_036_854_775_807; // 2^63-1
++    }
++}","In a recent PR, Bob added a `TracerConstants` class. Do you think this makes sense to put in that class instead so that we can consolidate?",I think this should be in `TraceConstants.cs`
+9162,"@@ -73,6 +73,10 @@ type Service struct {
+ 	auth            BlockAuthenticator
+ 	parallelBlocks  uint64
+ 	deadlineTimeout time.Duration
++	// catchpointWriting defines whether we've ran into a state where the ledger is currently busy writing the
++	// catchpoint file. If so, we want to pospone all the catchup process until the catchpoint file writing is complete,
++	// and resume from there without stopping the catchup timer.
++	catchpointWriting bool
+ 
+ 	// The channel gets closed when the initial sync is complete. This allows for other services to avoid
+ 	// the overhead of starting prematurely (before this node is caught-up and can validate messages for example).","I want to propose couple of different names for catchpointWriting: syncInterruptedWaitingCatchpointWriting syncWaitingForCatchpointWriting catchpointWriting is lacking context, and I found it difficult to understand the logic without this context.",nit: `catchpointFileWriting` -> `catchpointFileW
+9163,"@@ -92,7 +92,7 @@ class InventoryImporter(object):
+ 
+         Args:
+             session (object): Database session.
+-            model (str): Model name to create.
++            model (Model): Model name to create.
+             dao (object): Data Access Object from dao.py
+             service_config (ServiceConfig): Service configuration.
+             inventory_id (str): Inventory id to import from","Do you still need the `name` in the arg description, if this is not `str` type anymore.?",Why did you change this?
+9164,"@@ -42,15 +42,5 @@ def allreduce_grads(params, coalesce=True, bucket_size_mb=-1):
+ 
+ 
+ class DistOptimizerHook(OptimizerHook):
+-
+-    def __init__(self, grad_clip=None, coalesce=True, bucket_size_mb=-1):
+-        self.grad_clip = grad_clip
+-        self.coalesce = coalesce
+-        self.bucket_size_mb = bucket_size_mb
+-
+-    def after_train_iter(self, runner):
+-        runner.optimizer.zero_grad()
+-        runner.outputs['loss'].backward()
+-        if self.grad_clip is not None:
+-            self.clip_grads(runner.model.parameters())
+-        runner.optimizer.step()
++    """"""Deprecated optimizer hook for distributed training""""""
++    pass",We may raise a warning.,Why do we need to deprecate this?
+9165,"@@ -2,8 +2,10 @@ import AbstractModel from 'hospitalrun/models/abstract';
+ import DS from 'ember-data';
+ 
+ export default AbstractModel.extend({
+-  patient: DS.belongsTo('patient'),
++  // Attributes
+   name: DS.attr('string'),
+   icd9CMCode: DS.attr('string'),
+-  icd10Code: DS.attr('string')
++  icd10Code: DS.attr('string'),
++  // Associations
++  patient: DS.belongsTo('patient'),
+ });",Trailing comma caused the eslint test to fail,Why is this needed?
+9166,"@@ -0,0 +1,6 @@
++from werkzeug.utils import import_string
++
++from .config import CFG_RELATIONSHIPS_NODE_ENGINE, CFG_RELATIONSHIPS_EDGE_ENGINE
++
++Node = import_string(CFG_RELATIONSHIPS_NODE_ENGINE)
++Edge = import_string(CFG_RELATIONSHIPS_EDGE_ENGINE)","I think you should use `app.config`. In the usual case, the config file is not overwritten, there is additional config file outside of the source of `Invenio`.",F401 '.config.CFG_RELATIONSHIPS_N
+9167,"@@ -86,6 +86,16 @@ public final class JwtIssuerAuthenticationManagerResolver implements Authenticat
+ 				new TrustedIssuerJwtAuthenticationManagerResolver(
+ 						Collections.unmodifiableCollection(trustedIssuers)::contains));
+ 	}
++	
++	/**
++     * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided
++     * parameters
++     * @param trustedIssuer a predicate to determine whether the issuer should be trusted or not
++     */
++    public JwtIssuerAuthenticationManagerResolver(Predicate<String> trustedIssuer) {
++        this.authenticationManager = new ResolvingAuthenticationManager(
++                new TrustedIssuerJwtAuthenticationManagerResolver(trustedIssuer));
++    }
+ 
+ 	/**
+ 	 * Construct a {@link JwtIssuerAuthenticationManagerResolver} using the provided",Will you please update the copyright message to now include `2021`?,I don't think we need to create a
+9168,"@@ -38,8 +38,8 @@ void test_rw(const Offsets &offsets, const Data &data)
+ 
+     for (std::size_t index = 0; index < offsets.size() - 1; ++index)
+     {
+-        typename IndexedData::ResultType expected_result(&data[offsets[index]],
+-                                                         &data[offsets[index + 1]]);
++        typename IndexedData::ResultType expected_result(data.begin() + offsets[index],
++                                                         data.begin() + offsets[index + 1]);
+         BOOST_CHECK_EQUAL(expected_result, indexed_data.at(index));
+     }
+ }",Potential subscript out of range.,Why did you change this?
+9169,"@@ -185,7 +185,6 @@ func (ps *peerSelector) PeerDownloadDurationToRank(peer network.Peer, blockDownl
+ 	default: // i.e. peerRankInitialFourthPriority
+ 		return downloadDurationToRank(blockDownloadDuration, lowBlockDownloadThreshold, highBlockDownloadThreshold, peerRank3LowBlockTime, peerRank3HighBlockTime)
+ 
+-		
+ 	}
+ }
+ ","please undo this change. you didn't really meant to make it, right ?",why remove this?
+9170,"@@ -0,0 +1,13 @@
++import initStoryshots from '@storybook/addon-storyshots';
++import { puppeteerTest } from '@storybook/addon-storyshots-puppeteer';
++import path from 'path';
++
++initStoryshots( {
++	suite: 'Puppeteer storyshots',
++	test: puppeteerTest( {
++		// eslint-disable-next-line sitekit/acronym-case
++		storybookUrl: `file://${ path.resolve( __dirname, '../dist' ) }`,
++		setupTimeout: 5000,
++		testTimeout: 5000,
++	} ),
++} );",To check! are these millseconds or seconds :thinking: The docs aren't clear,I'm wondering if it woul
+9171,"@@ -508,6 +508,7 @@ func (u *multiuploader) upload(firstBuf io.ReadSeeker) (*UploadOutput, error) {
+ 
+ 	// Read and queue the rest of the parts
+ 	for u.geterr() == nil {
++		num++
+ 		// This upload exceeded maximum number of supported parts, error now.
+ 		if num > int64(u.ctx.MaxUploadParts) || num > int64(MaxUploadParts) {
+ 			var msg string",Why was this moved?,Why do we need this?
+9172,"@@ -15,6 +15,10 @@ limitations under the License.
+ */
+ package v1alpha1
+ 
++type CStorPoolExpansion interface{}
++
++type CStorVolumeReplicaExpansion interface{}
++
+ type StoragePoolExpansion interface{}
+ 
+ type StoragePoolClaimExpansion interface{}",What are these object with suffix Expansion?,Why do we need this?
+9173,"@@ -831,6 +831,13 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       arity = ""1"")
+   private final Wei txFeeCap = DEFAULT_RPC_TX_FEE_CAP;
+ 
++  @Option(
++      names = {""--rpc-allow-unprotected-txs""},
++      description =
++          ""Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"",
++      arity = ""1"")
++  private final Boolean unprotectedTransactionsAllowed = false;
++
+   @Option(
+       names = {""--min-block-occupancy-ratio""},
+       description = ""Minimum occupancy ratio for a mined block (default: ${DEFAULT-VALUE})"",","This breaks backwards compatibility, so it will have to wait for the next quarterly release of the default is to deny. I would recommend adding the flag with the default to allow and then at the next quarterly release rc cycle flip the flag to deny.",I don't think we nee
+9174,"@@ -57,12 +57,12 @@
+ // league_size) is not limited by physical constraints. Its a pure logical
+ // number.
+ 
+-typedef Kokkos::TeamPolicy<> team_policy;
+-typedef team_policy::member_type team_member;
++using team_policy = Kokkos::TeamPolicy<>;
++using team_member = team_policy::member_type;
+ 
+ // Define a functor which can be launched using the TeamPolicy
+ struct hello_world {
+-  typedef int value_type;  // Specify value type for reduction target, sum
++  using value_type = int;  // Specify value type for reduction target, sum
+ 
+   // This is a reduction operator which now takes as first argument the
+   // TeamPolicy member_type. Every member of the team contributes to the",I'm kind of surprised this doesn't require `typename`?,Why did you change t
+9175,"@@ -38,8 +38,7 @@ GLIB_TESTS
+ 
+ AC_CHECK_HEADER([sys/xattr.h],,[AC_MSG_ERROR([You must have sys/xattr.h from glibc])])
+ 
+-AC_CHECK_PROGS(YACC, 'bison -y', :)
+-AS_IF([test ""$YACC"" = :], [AC_MSG_ERROR([bison not found but required])])
++AS_IF([test ""$YACC"" != ""bison -y""], [AC_MSG_ERROR([bison not found but required])])
+ 
+ PKG_PROG_PKG_CONFIG
+ ","I think this will break the case (you can try even with /usr/bin/bison as value): `YACC=""/path/to/bison -y"" ./configure` I wonder if we should use AC_PROG_YACC at all or simply use AC_CHECK_PROGS since we want to use bison and not another yacc",Why is this change n
+9176,"@@ -66,8 +66,14 @@ namespace Nethermind.KeyStore.Config
+         [ConfigItem(Description = ""Plain private key to be used in test scenarios"")]
+         string TestNodeKey { get; set; }
+ 
+-        [ConfigItem(Description = ""Account to be used by the block author / coinbase"")]
++        [ConfigItem(Description = ""Account to be used by the block author / coinbase, to be loaded from keystore"")]
+         string BlockAuthorAccount { get; set; }
++        
++        [ConfigItem(Description = ""Account to be used by the node for network communication (enode), to be loaded from keystore"")]
++        string EnodeAccount { get; set; }
++        
++        [ConfigItem(Description = ""Path to key file to be used by the node for network communication (enode)"")]
++        string EnodeKeyFile { get; set; }
+ 
+         [ConfigItem(Description = ""Passwords to use to unlock accounts from the UnlockAccounts configuration item. Only used when no PasswordFiles provided."", DefaultValue = ""System.String[]"")]
+         string[] Passwords { get; set; }",can we explain to users in the docs what happens if they leave the field blank?,Why do we need both `EnodeAccount` and `EnodeKeyFile`?
+9177,"@@ -442,10 +442,10 @@ class EC2Connection(AWSQueryConnection):
+                              [('item', Reservation)], verb='POST')
+ 
+     def run_instances(self, image_id, min_count=1, max_count=1,
+-                      key_name=None, security_groups=None,
+-                      user_data=None, addressing_type=None,
+-                      instance_type='m1.small', placement=None,
+-                      kernel_id=None, ramdisk_id=None,
++                      key_name=None, security_group_ids=None,
++                      security_groups=None, user_data=None, 
++                      addressing_type=None, instance_type='m1.small', 
++                      placement=None, kernel_id=None, ramdisk_id=None,
+                       monitoring_enabled=False, subnet_id=None,
+                       block_device_map=None,
+                       disable_api_termination=False,",We try not to change the function footprints unless absolutely necessary. Why is it necessary to have both secuirty_group_ids and security_groups?,`security_group_ids` -> `security_group_ids`
+9178,"@@ -105,7 +105,7 @@ public class JavaSourceFolderProvider implements SourceFolderProvider {
+     if (Strings.isNullOrEmpty(relativePath)) {
+       return parentPackagePrefix;
+     }
+-    relativePath = relativePath.replaceAll(File.separator, ""."");
++    relativePath = relativePath.replace(File.separator, ""."");
+     return Strings.isNullOrEmpty(parentPackagePrefix)
+         ? relativePath
+         : parentPackagePrefix + ""."" + relativePath;","Thanks! We're already replacing File.separatorChar with '/' in the call to FileUtil#toCanonicalPath above, so the correct fix here should be: `relativePath.replace('/', '.')` I'll make the change upstream.",Why did you remove the `replaceAll`?
+9179,"@@ -2,8 +2,8 @@
+ 
+ namespace Shopsys\FrameworkBundle\Model\Product\Exception;
+ 
+-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
++use Symfony\Component\HttpKernel\Exception\GoneHttpException;
+ 
+-class ProductNotFoundException extends NotFoundHttpException implements ProductException
++class ProductNotFoundException extends GoneHttpException implements ProductException
+ {
+ }","It could be nice to be explicit about this change in upgrade notes, what do you think?",Why this change?
+9180,"@@ -27,7 +27,7 @@ function logout (req, res, next) {
+       }
+ 
+       delete companion.providerTokens[providerName]
+-      tokenService.removeFromCookies(res, companion.options, companion.provider.authProviderName)
++      tokenService.removeFromCookies(res, companion.options, companion.provider.authProvider)
+       cleanSession()
+       res.json(Object.assign({ ok: true }, data))
+     })",spotted a bug.,Shouldn't this be `companion.provider`?
+9181,"@@ -148,7 +148,7 @@ public class SmartStoreFullTextSearchSpeedTest extends SmartStoreTestCase {
+     private double queryData(Type textFieldType, int rowsPerAnimal, int matchingRowsPerAnimal) throws JSONException {
+         long totalQueryTime = 0;
+         for (String animal : ANIMALS) {
+-            String prefix = String.format(""%07d"", (int) Math.random()*matchingRowsPerAnimal);
++            String prefix = String.format(""%07d"", (int) (Math.random()*(rowsPerAnimal/matchingRowsPerAnimal)));
+             String stringToMatch = prefix + animal;
+ 
+             QuerySpec querySpec = textFieldType == Type.full_text",We were always using 0000000 prefix,Why is this change needed?
+9182,"@@ -306,7 +306,9 @@ void signalHandler(int sig) {
+             }
+             {
+                 auto gJobMgr = nebula::meta::JobManager::getInstance();
+-                gJobMgr->shutDown();
++                if (gJobMgr) {
++                    gJobMgr->shutDown();
++                }
+             }
+             if (gKVStore) {
+                 gKVStore->stop();",Here we also need to determine if gJobMgr has called the init function.,Why is this check needed?
+9183,"@@ -0,0 +1,18 @@
++module Mongoid
++  module Matcher
++
++    # @api private
++    module All
++      module_function def matches?(exists, value, condition)
++        condition.any? && condition.all? do |c|
++          case c
++          when ::Regexp, BSON::Regexp::Raw
++            Regex.matches_array_or_scalar?(value, c)
++          else
++            EqImpl.matches?(true, value, c, '$all')
++          end
++        end
++      end
++    end
++  end
++end","Out of curiosity, why is `condition.any?` also necessary here?",I'm not sure if this is the best way to
+9184,"@@ -12,14 +12,16 @@ namespace meta {
+ 
+ std::unordered_map<GraphSpaceID, std::shared_ptr<HostManager>> HostManager::hostManagers_;
+ 
+-
+ // static
+ std::shared_ptr<const HostManager> HostManager::get(GraphSpaceID space) {
+     auto it = hostManagers_.find(space);
+     if (it != hostManagers_.end()) {
+         return it->second;
+     } else {
+-        return std::shared_ptr<const HostManager>();
++        auto* hmPtr = new HostManager(space);
++        std::shared_ptr<HostManager> hm(hmPtr);
++        hostManagers_.emplace(space, hm);
++        return hm;
+     }
+ }
+ ","Always use `std::make_shared` whenever possible, it will save you one memory allocation.",nit: `hm` -> `hostManager`
+9185,"@@ -30,7 +30,7 @@ var DBATag = ""v0.2.0""
+ var RouterImage = ""drud/nginx-proxy"" // Note that this is overridden by make
+ 
+ // RouterTag defines the tag used for the router.
+-var RouterTag = ""v0.3.0"" // Note that this is overridden by make
++var RouterTag = ""router-expose"" // Note that this is overridden by make
+ 
+ // COMMIT is the actual committish, supplied by make
+ var COMMIT = ""COMMIT should be overridden""",Update to real tag before pull.,I don't think we need this
+9186,"@@ -73,7 +73,7 @@ public class ITZipkinHealth {
+ 
+     // ensure we don't track health in prometheus
+     assertThat(scrape())
+-      .doesNotContain(""health"");
++      .doesNotContain(""health_check"");
+   }
+ 
+   String scrape() throws InterruptedException {",Is there any better string that only exposed by prometheus? We have changed the meter tags to contain method and service name. For example `scrape()` contains `method=getHealth` and `service=server.internal.health.ITzipkinHealth` which made this test failed.  ,".doesNotContain(""health"");"
+9187,"@@ -33,7 +33,7 @@ namespace Datadog.Trace.Vendors.Serilog.Core
+     /// be disposed to flush any events buffered within it. Most application
+     /// code should depend on <see cref=""ILogger""/>, not this class.
+     /// </summary>
+-    internal sealed class Logger : ILogger, ILogEventSink, IDisposable
++    internal sealed class Logger : ILogger, ILogEventSink, IDisposable, ICoreLogger
+     {
+         static readonly object[] NoPropertyValues = new object[0];
+ ",Adding ICoreLogger here lets us pull this into Core as a strategy,>ICoreLogger [](start = 27
+9188,"@@ -38,7 +38,7 @@ type UsageStats struct {
+ 
+ // ContainerMetadata contains meta-data information for a container.
+ type ContainerMetadata struct {
+-	DockerID string `json:""-""`
++	DockerID string
+ }
+ 
+ // StatsContainer abstracts methods to gather and aggregate utilization data for a container.",why did you change this?,Why did you remove the json tag?
+9189,"@@ -138,9 +138,15 @@ module RSpec::Core
+       # @param colorizer [#wrap] An object to colorize the message_lines by
+       # @return [Array(String)] The example failure message colorized
+       def colorized_message_lines(colorizer = ::RSpec::Core::Formatters::ConsoleCodes)
+-        message_lines.map do |line|
+-          colorizer.wrap line, RSpec.configuration.failure_color
+-        end
++        message_lines
++          .map do |line|
++            colorizer.wrap line, :failure
++          end
++          .tap do |lines|
++            unless exception_class_name =~ /RSpec/
++              lines[1] = colorizer.wrap(exception_class_name, :failure) + "":""
++            end
++          end
+       end
+ 
+       # Returns the failures formatted backtrace.",This is invalid syntax on 1.8.,Why do we need a tap here?
+9190,"@@ -408,10 +408,10 @@ M  END
+     rxn = rdChemReactions.ReactionFromSmarts('[C:1]1[O:2][N:3]1>>[C:1][O:2].[N:3]')
+     r1 = rxn.GetReactantTemplate(0)
+     sma = Chem.MolToSmarts(r1)
+-    self.assertEqual(sma, '[C:1]1-,:[O:2]-,:[N:3]-,:1')
++    self.assertEqual(sma, '[C:1]1[O:2][N:3]1')
+     p1 = rxn.GetProductTemplate(0)
+     sma = Chem.MolToSmarts(p1)
+-    self.assertEqual(sma, '[C:1]-,:[O:2]')
++    self.assertEqual(sma, '[C:1][O:2]')
+ 
+     p2 = rxn.GetProductTemplate(1)
+     sma = Chem.MolToSmarts(p2)","This isn't part of the PR, but I can't find in the smarts definition that ""[C][C]"" == ""[C]-,:[C]"" There is a line saying essentially not to specify undefined items (but that's a bracket versus non bracket thing).",Why did this change?
+9191,"@@ -77,14 +77,14 @@ var (
+ 
+ // UnsignedMessage is an exchange of information between two actors modeled
+ // as a function call.
+-// Messages are the equivalent of transactions in Ethereum.
+ type UnsignedMessage struct {
++	_    struct{}        `cbor:"",toarray""`
+ 	To   address.Address `json:""to""`
+ 	From address.Address `json:""from""`
+ 	// When receiving a message from a user account the nonce in
+ 	// the message must match the expected nonce in the from actor.
+ 	// This prevents replay attacks.
+-	CallSeqNum Uint64 `json:""callSeqNum""`
++	CallSeqNum uint64 `json:""callSeqNum""`
+ 
+ 	Value AttoFIL `json:""value""`
+ ",Is this required for tuple encoding? This is confusing.,Why is this needed?
+9192,"@@ -112,6 +112,7 @@ public class FlowRunnerManager implements EventListener,
+   private final ExecutorLoader executorLoader;
+   private final ProjectLoader projectLoader;
+   private final JobTypeManager jobtypeManager;
++  private final FlowPreparer flowPreparer;
+ 
+   private final Props azkabanProps;
+   private final File executionDirectory;",Does it need to be a member variable? It is currently only used in one method.,nit: rename to `preparer`
+9193,"@@ -37,7 +37,7 @@ function showNewJoinGroupSelection (button, user, apiClient) {
+         console.debug('No item is currently playing.');
+     }
+ 
+-    apiClient.sendSyncPlayCommand(sessionId, 'ListGroups').then(function (response) {
++    apiClient.sendSyncPlayCommand('ListGroups').then(function (response) {
+         response.json().then(function (groups) {
+             var menuItems = groups.map(function (group) {
+                 return {",@MrTimscampi doesn't this need an update to apiclient?..,I don't think we need to 
+9194,"@@ -472,7 +472,7 @@ static const byte xop_a_extra[256] = {
+  */
+ int
+ decode_sizeof(dcontext_t *dcontext, byte *start_pc,
+-              int *num_prefixes _IF_X64(uint *rip_rel_pos))
++              int *num_prefixes _IF_X86_64(uint *rip_rel_pos))
+ {
+     byte *pc = start_pc;
+     uint opc = (uint)*pc;",This is a nop: prob best for history to not change the line,I think this should be `_
+9195,"@@ -21,7 +21,8 @@ type TrivialTestSlasher struct {
+ 	SendCalls uint64
+ }
+ 
+-// Slash is a required function for storageFaultSlasher interfaces and is intended to do nothing.
++// Slash is a required function for storageFaultSlasher interfaces and does nothing but track
++// how many times it's called.
+ func (ts *TrivialTestSlasher) Slash(context.Context, *types.BlockHeight) error {
+ 	ts.SendCalls++
+ 	return nil",Can you delete this whole file now?,Why do we need to track t
+9196,"@@ -24,6 +24,7 @@ type ReturnedContract struct {
+ 	Erc721Token blockchain.Erc721Token
+ 	ArrDelete   blockchain.ArrayDelete
+ 	ArrString   blockchain.ArrayString
++	ArrPassing  blockchain.ArrayPassing
+ }
+ 
+ // StartContracts deploys and starts fp token smart contract and stable token smart contract,erc721 token smart contract","can you combine this passing test, code, solidity binary into existing ArrDelete? the function is much similar, pushing int value into an array, and delete one item in the array",Why do we need this?
+9197,"@@ -340,10 +340,10 @@ public class QueueFragment extends Fragment {
+                         SortOrder sortOrder = UserPreferences.getQueueKeepSortedOrder();
+                         DBWriter.reorderQueue(sortOrder, true);
+                         if (recyclerAdapter != null) {
+-                            recyclerAdapter.setLocked(true);
++                            recyclerAdapter.setKeepSorted(true);
+                         }
+                     } else if (recyclerAdapter != null) {
+-                        recyclerAdapter.setLocked(UserPreferences.isQueueLocked());
++                        recyclerAdapter.setKeepSorted(UserPreferences.isQueueKeepSorted());
+                     }
+                     getActivity().invalidateOptionsMenu();
+                     return true;","I think that could lead to problems when setting it to not sorted again. In that case, it will not be reset. What about using one single method for the adapter (`setDragDropEnabled`)?",This should be `setK
+9198,"@@ -47,8 +47,8 @@ func handleSequelProCommand(appLocation string) (string, error) {
+ 		return """", err
+ 	}
+ 
+-	if app.SiteStatus() != ""running"" {
+-		return """", errors.New(""app not running locally. Try `ddev start`"")
++	if app.SiteStatus() != platform.SiteRunning {
++		return """", errors.New(""App not running locally. Try `ddev start`"")
+ 	}
+ 
+ 	db, err := app.FindContainerByType(""db"")","I'd say the error should be an error, not instructions to the user. So error would be something like ""site should be running and is not""",I think this should 
+9199,"@@ -60,11 +60,12 @@ const (
+ 	// 9) Add 'ipToTask' map to state file
+ 	// 10) Add 'healthCheckType' field in 'apicontainer.Container'
+ 	// 11)
+-	//  a) Add 'PrivateDNSName' field to 'api.ENI'
+-	//  b)Remove `AppliedStatus` field form 'apicontainer.Container'
++	//   a) Add 'PrivateDNSName' field to 'api.ENI'
++	//   b)Remove `AppliedStatus` field form 'apicontainer.Container'
+ 	// 12) Deprecate 'TransitionDependencySet' and add new 'TransitionDependenciesMap' in 'apicontainer.Container'
+ 	// 13) Add 'resources' field to 'api.task.task'
+-	ECSDataVersion = 13
++	// 14) Add 'V3EndpointID' field to 'Container' struct
++	ECSDataVersion = 14
+ 
+ 	// ecsDataFile specifies the filename in the ECS_DATADIR
+ 	ecsDataFile = ""ecs_agent_data.json""","Are you sure `v3EndpointIDToContainerName` and `v3EndpointIDToTask` are saved in the state file, can you verify that?",Why did you change t
+9200,"@@ -23,6 +23,8 @@ type KeyExchangeFunction func() crypto.KeyExchange
+ 
+ // The CryptoSetupServer handles all things crypto for the Session
+ type cryptoSetupServer struct {
++	mutex sync.RWMutex
++
+ 	connID               protocol.ConnectionID
+ 	remoteAddr           net.Addr
+ 	scfg                 *ServerConfig","This mutex is never used. Should it be, if users can now make calls into the crypto setup?",Why do we need this mutex?
+9201,"@@ -25,6 +25,9 @@ module Beaker
+             host.exec(Command.new(""w32tm /config /manualpeerlist:#{NTPSERVER} /syncfromflags:manual /update""))
+             host.exec(Command.new(""w32tm /resync""))
+             @logger.notify ""NTP date succeeded on #{host}""
++          elsif host['platform'].include? 'sles'
++            host.exec(Command.new(""sntp #{NTPSERVER}""))
++            @logger.notify ""NTP date succeeded on #{host}""
+           else
+             success=false
+             try = 0","Check here for sles-, and i'd prefer a regex since I don't know what an 'include' is going to do exactly. :)",This should be `host['plat
+9202,"@@ -65,7 +65,11 @@ class QR_Window(QWidget):
+         amount_text = ''
+         if amount:
+             if currency:
+-                self.amount = Decimal(amount) / self.exchanger.exchange(1, currency) if currency else amount
++                exch = self.exchanger.exchange(1, currency)
++                if exch == None:
++                    self.amount = Decimal('0.0')
++                else:
++                    self.amount = Decimal(amount) / exch if currency else amount
+             else:
+                 self.amount = Decimal(amount)
+             self.amount = self.amount.quantize(Decimal('1.0000'))",Should this be `None` instead?,I think this should be `se
+9203,"@@ -171,7 +171,14 @@ public final class ConfigUtil {
+       }
+ 
+       String cseKey = CONFIG_CSE_PREFIX + key.substring(key.indexOf(""."") + 1);
+-      source.addProperty(cseKey, source.getProperty(key));
++      if (!source.containsKey(cseKey)) {
++        source.addProperty(cseKey, source.getProperty(key));
++      } else {
++        LOGGER
++            .warn(
++                ""Key {} with an ambiguous item {} exists, please use the same prefix or will get unexpected merged value."",
++                key, cseKey);
++      }
+     }
+   }
+ ","Not sure if the warning message is enough for this time, if the configuration is wrong, java-chassis may need to stop working instead of sending out the warning message to let the admin know about it. BTW, we may need a default override policy here.",I think it would be better
+9204,"@@ -7,7 +7,7 @@ import (
+ 
+ func MustParse(args []string) []string {
+ 	parser := &Parser{
+-		After:         []string{""server"", ""agent"", ""etcd-snapshot""},
++		After:         []string{""server"", ""agent"", ""etcd-snapshot"", ""save"", ""delete"", ""list"", ""prune""},
+ 		FlagNames:     []string{""--config"", ""-c""},
+ 		EnvName:       version.ProgramUpper + ""_CONFIG_FILE"",
+ 		DefaultConfig: ""/etc/rancher/"" + version.Program + ""/config.yaml"",","I see this getting unwieldy as we add more commands with subcommands. Can we perhaps enhance it to handle subcommands properly? Perhaps something like `""etcd-snapshot:1""` which would indicate that the etcd-snapshot command may have 1 subcommand after it, and if the 1 next argument after it doesn't start with `--` then the args should be appended after that subcommand.",Why do we need to do this?
+9205,"@@ -249,13 +249,13 @@ public class ExecutionController extends EventHandler implements ExecutorManager
+   }
+ 
+   /**
+-   * Get all active (running, non-dispatched) flows from database. {@inheritDoc}
++   * Get all running (unfinished) flows from database. {@inheritDoc}
+    */
+   @Override
+   public List<ExecutableFlow> getRunningFlows() {
+     final ArrayList<ExecutableFlow> flows = new ArrayList<>();
+     try {
+-      getActiveFlowHelper(flows, this.executorLoader.fetchUnfinishedFlows().values());
++      getFlowsHelper(flows, this.executorLoader.fetchUnfinishedFlows().values());
+     } catch (final ExecutorManagerException e) {
+       this.logger.error(""Failed to get running flows."", e);
+     }",why returning a string instead of a list?,I think this method should
+9206,"@@ -3,11 +3,13 @@
+ // This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+ // </copyright>
+ 
++using Datadog.Trace.Configuration;
++
+ namespace Datadog.Trace.ClrProfiler.AutoInstrumentation.AdoNet.Npgsql
+ {
+     internal static class NpgsqlConstants
+     {
+-        public const string SqlCommandIntegrationName = ""NpgsqlCommand"";
++        public const string SqlCommandIntegrationName = nameof(IntegrationIds.AdoNet);
+ 
+         internal struct NpgsqlClientData : IAdoNetClientData
+         {",Was there a reason for changing all these integration names?   Are they actually used for anything besides information in logs?,I think this should be `na
+9207,"@@ -422,6 +422,10 @@ public class FieldInfos implements Iterable<FieldInfo> {
+       }
+     }
+     
++    synchronized Set<String> getFieldNames() {
++      return Set.copyOf(nameToNumber.keySet());
++    }
++
+     synchronized void clear() {
+       numberToName.clear();
+       nameToNumber.clear();",we should not resurrect this method that we just removed,Why do we need this?
+9208,"@@ -837,7 +837,18 @@ class WebDriver(object):
+             del png
+         return True
+ 
+-    save_screenshot = get_screenshot_as_file
++    def save_screenshot(self, filename):
++        """"""
++        Gets the screenshot of the current window. Returns False if there is
++           any IOError, else returns True. Use full paths in your filename.
++
++        :Args:
++         - filename: The full path you wish to save your screenshot to.
++
++        :Usage:
++            driver.save_screenshot('/Screenshots/foo.png')
++        """"""
++        return self.get_screenshot_as_file(self, filename)
+ 
+     def get_screenshot_as_png(self):
+         """"""",This needs to be just return self.get_screenshot_as_file(filename),I don't think you need the `else` here.
+9209,"@@ -0,0 +1,6 @@
++function isNetworkError (xhr) {
++  if (!xhr) return
++  return (xhr.readyState !== 0 && xhr.readyState !== 4) || xhr.status === 0
++}
++
++module.exports = isNetworkError",Shouldn't this return false here?,I don't think we need this function.
+9210,"@@ -92,6 +92,9 @@ type Config struct {
+ 	// Path to a directory containing the container's root filesystem.
+ 	Rootfs string `json:""rootfs""`
+ 
++	// Umask is the umask to use inside of the container.
++	Umask *uint32 `json:""umask""`
++
+ 	// Readonlyfs will remount the container's rootfs as readonly where only externally mounted
+ 	// bind mounts are writtable.
+ 	Readonlyfs bool `json:""readonlyfs""`",Should have json tag,Why is this a pointer?
+9211,"@@ -180,7 +180,7 @@ static const char *const PORT_ERROR[PORT_ERROR_COUNT] = {
+ /*
+  * errors command configuration, set during parse_args()
+  */
+-static struct errors_config {
++STATIC struct errors_config {
+ 	bool clear;
+ 	int force_count;
+ 	enum verbs_index which;",Is this needed after all? Looks like the struct was re-defined inside the test file.,Why is this a static struct?
+9212,"@@ -67,4 +67,11 @@ public interface ActionsProvider {
+   default ExpireSnapshots expireSnapshots(Table table) {
+     throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement expireSnapshots"");
+   }
++
++  /**
++   * Instantiates an action to remove all the files referenced by given metadata location.
++   */
++  default RemoveReachableFiles removeFiles(String metadataLocation) {
++    throw new UnsupportedOperationException(this.getClass().getName() + "" does not implement removeFiles"");
++  }
+ }",I think the name of the method should match the name of the action: `removeReachableFiles`.,I'm not sure if this is the best name for this method. Maybe `removeMetadataFiles`?
+9213,"@@ -106,6 +106,7 @@ echo ""
+     <ul>
+         <li><a href=\""manage_apps.php\"">Manage applications</a></li>
+         <li><a href=\""manage_app_versions.php\"">Manage application versions</a></li>
++        <li><a href=\""manage_consent_types.php\"">Manage Consent types</a></li>
+         <li> Manage jobs
+         <ul>
+             <li><a href=\""cancel_wu_form.php\"">Cancel jobs by ID</a>",can you make the C in Consent lower case to match the other ones in this list?,Shouldn't this be `manage_consent_types`?
+9214,"@@ -16,6 +16,7 @@ import (
+ 	""sync""
+ 	""testing""
+ 
++	""github.com/iotexproject/iotex-core/action/protocol/poll""
+ 	""github.com/stretchr/testify/require""
+ 
+ 	""github.com/iotexproject/iotex-core/action""",fix the group,"""time"""
+9215,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+ 
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,I don't think we need this method. We can just use `slots.size()`
+9216,"@@ -47,7 +47,7 @@ func BenchmarkServiceFetchBlocks(b *testing.B) {
+ 	
+ 	// Create a network and block service
+ 	net := &httpTestPeerSource{}
+-	ls := rpcs.MakeBlockService(config.GetDefaultLocal(), remote, net, ""test genesisID"")
++	ls := rpcs.MakeBlockService(logging.Base(), config.GetDefaultLocal(), remote, net, ""test genesisID"")
+ 	nodeA := basicRPCNode{}
+ 	nodeA.RegisterHTTPHandler(rpcs.BlockServiceBlockPath, ls)
+ 	nodeA.start()",we have `logging.TestingLog()` that should be used for that purpose.,Error return value of `ls.Start` is not checked (from `errcheck`)
+9217,"@@ -2372,7 +2372,7 @@ int mg_url_decode(const char *src, int src_len, char *dst,
+ #define HEXTOI(x) (isdigit(x) ? x - '0' : x - 'W')
+ 
+   for (i = j = 0; i < src_len && j < dst_len - 1; i++, j++) {
+-    if (src[i] == '%' && i < src_len - 2 &&
++    if (i < src_len - 2 && src[i] == '%' &&
+         isxdigit(* (const unsigned char *) (src + i + 1)) &&
+         isxdigit(* (const unsigned char *) (src + i + 2))) {
+       a = tolower(* (const unsigned char *) (src + i + 1));",This is also a question of style. src[i] will always be valid because of check if 'for' statement,Why this change?
+9218,"@@ -398,7 +398,7 @@ func killKubeEdgeBinary(proc string) error {
+ 
+ //isKubeEdgeProcessRunning checks if the given process is running or not
+ func isKubeEdgeProcessRunning(proc string) (bool, error) {
+-	procRunning := fmt.Sprintf(""pidof %s 2&>1"", proc)
++	procRunning := fmt.Sprintf(""pidof %s 2>&1"", proc)
+ 	cmd := NewCommand(procRunning)
+ 
+ 	err := cmd.Exec()",Why change it?,Why this change?
+9219,"@@ -11,7 +11,7 @@ import {
+   textStyle,
+   colorStyle,
+   borders,
+-} from '../src'
++} from '../src/index'
+ 
+ const theme = {
+   colors: {",nb: this change is unnecessary,This should be `../src/index`
+9220,"@@ -120,6 +120,7 @@ type Object struct {
+ 	size        int64     // size of the object
+ 	modTime     time.Time // modification time of the object
+ 	id          string    // ID of the object
++	publicLink  string    // Public Link for the object
+ 	sha1        string    // SHA-1 of the object content
+ }
+ ",Is the publicLink mostly empty? I'm just wondering how much this will bloat memory usage as sometimes rclone has millions of Object~s in memory.,I think this should be a `[]byte`
+9221,"@@ -65,6 +65,11 @@ type OrderSpec struct {
+ 	// validation process.
+ 	// This field must match the corresponding field on the DER encoded CSR.
+ 	DNSNames []string
++
++	// IPAddresses is a list of IP addresses that should be included as part of the Order
++	// validation process.
++	// This field must match the corresponding field on the DER encoded CSR.
++	IPAddresses []string `json:""ipAddresses,omitempty""`
+ }
+ 
+ type OrderStatus struct {","I don't think the Internal API types need the json annotations. They are never serialised, right?",I'm not sure if this is the best 
+9222,"@@ -45,6 +45,7 @@ type apiClient interface {
+ 	GetApplicationMostRecentDeployment(ctx context.Context, req *pipedservice.GetApplicationMostRecentDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.GetApplicationMostRecentDeploymentResponse, error)
+ 	CreateDeployment(ctx context.Context, in *pipedservice.CreateDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.CreateDeploymentResponse, error)
+ 	ReportApplicationMostRecentDeployment(ctx context.Context, req *pipedservice.ReportApplicationMostRecentDeploymentRequest, opts ...grpc.CallOption) (*pipedservice.ReportApplicationMostRecentDeploymentResponse, error)
++	ReportDeploymentCompleted(ctx context.Context, req *pipedservice.ReportDeploymentCompletedRequest, opts ...grpc.CallOption) (*pipedservice.ReportDeploymentCompletedResponse, error)
+ }
+ 
+ type gitClient interface {",Maybe this was added incidentally. We don't need this function in the interface.,I think this should be `<msg>`<ms
+9223,"@@ -18,8 +18,15 @@ func To(fs http.FileSystem, r *http.Request, to string, replacer httpserver.Repl
+ 
+ 	// try each rewrite paths
+ 	t := """"
++	query := """"
+ 	for _, v := range tos {
+-		t = path.Clean(replacer.Replace(v))
++		t = replacer.Replace(v)
++		tparts := strings.Split(t, ""?"")
++		t = path.Clean(tparts[0])
++
++		if len(tparts) > 1 {
++			query = tparts[1]
++		}
+ 
+ 		// add trailing slash for directories, if present
+ 		if strings.HasSuffix(v, ""/"") && !strings.HasSuffix(t, ""/"") {",Is this a safe/reliable way to split the URL?,I'm not sure if this is the best 
+9224,"@@ -350,6 +350,7 @@ public class JdbcProjectLoader extends AbstractJdbcLoader implements
+   public void uploadProjectFile(Project project, int version, String filetype,
+       String filename, File localFile, String uploader)
+       throws ProjectManagerException {
++    long startMs = System.currentTimeMillis();
+     logger.info(""Uploading to "" + project.getName() + "" version:"" + version
+         + "" file:"" + filename);
+     Connection connection = getConnection();",do we also need to profile the time to getConnection()?,Why do we need this?
+9225,"@@ -34,6 +34,12 @@ def flow_to_json(flow: mitmproxy.flow.Flow) -> dict:
+         ""type"": flow.type,
+         ""modified"": flow.modified(),
+     }
++    # .alpn_proto_negotiated is bytes, we need to decode that.
++    for conn in ""client_conn"", ""server_conn"":
++        if f[conn][""alpn_proto_negotiated""] is None:
++            continue
++        f[conn][""alpn_proto_negotiated""] = \
++            f[conn][""alpn_proto_negotiated""].decode(errors=""backslashreplace"")
+     if flow.error:
+         f[""error""] = flow.error.get_state()
+ ",Should we move the decode part directly to the actual first-use of this? Or how does this affect if the value gets decoded and we need to get the bytes back later?,I'm not sure if this
+9226,"@@ -78,6 +78,16 @@ $config = [
+                     ]
+                 ]
+             ],
++            'legacy-holds' => [
++                'type' => 'Laminas\Router\Http\Literal',
++                'options' => [
++                    'route'    => '/MyResearch/Holds',
++                    'defaults' => [
++                        'controller' => 'Holds',
++                        'action'     => 'List',
++                    ]
++                ]
++            ],
+             'legacy-summonrecord' => [
+                 'type' => 'Laminas\Router\Http\Literal',
+                 'options' => [","How would you feel about continuing to point this at the MyResearchController's holdsAction, but instead changing that action to force a redirect to the new holds-list route? That way, people will get sent to the new URL instead of having two different URLs that do the same thing.",I think this should 
+9227,"@@ -1196,6 +1196,14 @@ func (c *client) markConnAsClosed(reason ClosedState, skipFlush bool) bool {
+ 	if skipFlush {
+ 		c.flags.set(skipFlushOnClose)
+ 	}
++	// Be consistent with the creation: for routes and gateways,
++	// we use Noticef on create, so use that too for delete.
++	if c.kind == ROUTER || c.kind == GATEWAY {
++		c.Noticef(""%s connection closed: %v"", c.typeString(), reason.String())
++	} else { // Client and Leaf Node connections.
++		c.Debugf(""%s connection closed: %v"", c.typeString(), reason.String())
++	}
++
+ 	// Save off the connection if its a client or leafnode.
+ 	if c.kind == CLIENT || c.kind == LEAF {
+ 		if nc := c.nc; nc != nil && c.srv != nil {",I think if yo use %s then you do not need reason.String() and can just do reason.,I don't think we sho
+9228,"@@ -156,9 +156,9 @@ func WorkflowEndingRunID(endingRunID string) Tag {
+ 	return newStringTag(""wf-ending-run-id"", endingRunID)
+ }
+ 
+-// WorkflowDecisionTimeoutSeconds returns tag for WorkflowDecisionTimeoutSeconds
+-func WorkflowDecisionTimeoutSeconds(s int32) Tag {
+-	return newInt32(""wf-decision-timeout"", s)
++// WorkflowTaskTimeoutSeconds returns tag for WorkflowTaskTimeoutSeconds
++func WorkflowTaskTimeoutSeconds(s int32) Tag {
++	return newInt32(""wf-workflow-task-timeout"", s)
+ }
+ 
+ // QueryID returns tag for QueryID","Having ""wf"" prefix doesn't make sense anymore. Please remove.",nit: rename to `WorkflowTaskTimeoutSeconds`
+9229,"@@ -5,15 +5,15 @@ import {
+ 	teardown,
+ 	getMixedArray,
+ 	mixedArrayHTML,
+-	serializeHtml
++	serializeHtml,
++	sortAttributes,
++	spyAll
+ } from '../_util/helpers';
+ import { div, span, p } from '../_util/dom';
+ 
+ /** @jsx createElement */
+ const h = createElement;
+ 
+-let spyAll = obj => Object.keys(obj).forEach(key => sinon.spy(obj, key));
+-
+ function getAttributes(node) {
+ 	let attrs = {};
+ 	if (node.attributes) {",Removed this copy of the `spyAll` function and replaced it with the same function declared in `helpers.js`. Same for `sortAttributes` below,Why was this removed?
+9230,"@@ -90,9 +90,9 @@ public class KubernetesContainerizedImpl extends EventHandler implements Contain
+   public static final String DEFAULT_POD_NAME_PREFIX = ""fc-dep"";
+   public static final String DEFAULT_SERVICE_NAME_PREFIX = ""fc-svc"";
+   public static final String DEFAULT_CLUSTER_NAME = ""azkaban"";
+-  public static final String CPU_LIMIT = ""4"";
++  public static final String DEFAULT_MAX_CPU = ""0"";
++  public static final String DEFAULT_MAX_MEMORY = ""0Gi"";
+   public static final String DEFAULT_CPU_REQUEST = ""1"";
+-  public static final String MEMORY_LIMIT = ""64Gi"";
+   public static final String DEFAULT_MEMORY_REQUEST = ""2Gi"";
+   public static final String MAPPING = ""Mapping"";
+   public static final String SERVICE_API_VERSION_2 = ""ambassador/v2"";",Default max cpu should be 8 and memory 64GB,Why did you remove these constants?
+9231,"@@ -156,6 +156,11 @@ class _MissingPandasLikeSeries(object):
+     real = unsupported_property(
+         'real',
+         reason=""If you want to collect your data as an NumPy array, use 'to_numpy()' instead."")
++    nbytes = unsupported_property(
++        'nbytes',
++        reason=""'nbytes' requires to compute whole dataset. You can calculate manually it, ""
++               ""with its 'itemsize', by explicitly executing its count. Use Spark's web UI ""
++               ""to monitor disk and memory usage of your application in general."")
+ 
+     # Functions we won't support.
+     memory_usage = common.memory_usage(unsupported_function)","@itholic, can you remove `nbytes = unsupported_property('nbytes')` at `_MissingPandasLikeSeries`?","nit: ""by explicitly executing its count"" ->"
+9232,"@@ -101,9 +101,8 @@ func TestEnvironmentConfig(t *testing.T) {
+ 	assert.True(t, conf.TaskIAMRoleEnabled, ""Wrong value for TaskIAMRoleEnabled"")
+ 	assert.True(t, conf.TaskIAMRoleEnabledForNetworkHost, ""Wrong value for TaskIAMRoleEnabledForNetworkHost"")
+ 	assert.True(t, conf.ImageCleanupDisabled, ""Wrong value for ImageCleanupDisabled"")
+-	assert.True(t, conf.TaskCPUMemLimit, ""Wrong value for TaskCPUMemLimit"")
+-	assert.True(t, conf.TaskENIEnabled, ""Wrong value for TaskNetwork"")
+ 
++	assert.True(t, conf.TaskENIEnabled, ""Wrong value for TaskNetwork"")
+ 	assert.Equal(t, (30 * time.Minute), conf.MinimumImageDeletionAge)
+ 	assert.Equal(t, (2 * time.Hour), conf.ImageCleanupInterval)
+ 	assert.Equal(t, 2, conf.NumImagesToDeletePerCycle)",What happened to the assertion on `conf.TaskCPUMemLimit`?,Why did you remove these assertions?
+9233,"@@ -5,10 +5,13 @@ import { render } from './render';
+ import { rerender } from './render-queue';
+ import options from './options';
+ 
++const createRef = Object;
++
+ export default {
+ 	h,
+ 	createElement,
+ 	cloneElement,
++	createRef,
+ 	Component,
+ 	render,
+ 	rerender,",Just curious: Is using `Object` faster than a literal `{}`?,Why do we need this?
+9234,"@@ -59,6 +59,14 @@ func ValidateCertificateForACMEIssuer(crt *v1alpha1.CertificateSpec, issuer *v1a
+ 		el = append(el, field.Invalid(specPath.Child(""organization""), crt.Organization, ""ACME does not support setting the organization name""))
+ 	}
+ 
++	if crt.Duration.Duration != 0 {
++		el = append(el, field.Invalid(specPath.Child(""duration""), crt.Duration, ""ACME does not support certificate durations""))
++	}
++
++	if crt.RenewBefore.Duration != 0 {
++		el = append(el, field.Invalid(specPath.Child(""renewBefore""), crt.RenewBefore, ""ACME does not support certificate renewal times""))
++	}
++
+ 	return el
+ }
+ ","How come we don't allow this to be configured with the ACME issuer? Happy to leave this as-is for now if there's a lot more consideration that needs to be made, but it seems like we could/should be able to allow this?",I think we should also check for `cr
+9235,"@@ -208,7 +208,6 @@ type HTTPHealthCheckOpts struct {
+ 
+ // NetworkLoadBalancerListener holds configuration that's need for a Network Load Balancer listener.
+ type NetworkLoadBalancerListener struct {
+-	Port            string
+ 	Protocol        string
+ 	TargetContainer string
+ 	TargetPort      string",Should we remove the `Aliases` field as well?,Why is this removed?
+9236,"@@ -88,6 +88,8 @@ public class VoiceSearchWidget extends UIWidget implements WidgetManagerDelegate
+ 
+         mMozillaSpeechService = MozillaSpeechService.getInstance();
+         mMozillaSpeechService.setProductTag(""fxr"");
++        mMozillaSpeechService.storeSamples(false);
++        mMozillaSpeechService.storeTranscriptions(false);
+ 
+         mVoiceSearchText1 = findViewById(R.id.voiceSearchText1);
+         mVoiceSearchText2 = findViewById(R.id.voiceSearchText2);",what's the effect of turning these two off? is there an issue on file for context?,I'm not sure if this is the best way to do this.
+9237,"@@ -35,9 +35,10 @@ type CLITestType string
+ 
+ // List all test types here
+ const (
+-	Wrapper                   CLITestType = ""1 wrapper""
+-	GcloudProdWrapperLatest   CLITestType = ""2 gcloud-prod wrapper-latest""
+-	GcloudLatestWrapperLatest CLITestType = ""3 gcloud-latest wrapper-latest""
++	Wrapper                       CLITestType = ""1 wrapper""
++	GcloudBetaProdWrapperLatest   CLITestType = ""2 gcloud-beta-prod wrapper-latest""
++	GcloudBetaLatestWrapperLatest CLITestType = ""3 gcloud-beta-latest wrapper-latest""
++	GcloudGaLatestWrapperRelease  CLITestType = ""4 gcloud-ga-latest wrapper-release""
+ )
+ 
+ var (","The format like gcloud-beta-prod is a bit hard to understand. Maybe find a a more clear way to describe it,",Why are we changing these tests?
+9238,"@@ -20,7 +20,7 @@ namespace OpenTelemetry.Tags
+     /// <summary>
+     /// Collection of tags representing the tags context.
+     /// </summary>
+-    public interface ITagContext : IEnumerable<Tag>
++    public interface ITagContext : IEnumerable<DistributedContextEntry>
+     {
+     }
+ }",Are we renaming this too in a follow up PR?,I don't think we should change this interface.
+9239,"@@ -179,7 +179,8 @@ class Preference extends Model
+     public function getLocaleOptions()
+     {
+         $localeOptions = [
+-            'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++		    'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
+             'cs' => [Lang::get('system::lang.locale.cs'), 'flag-cz'],
+             'da' => [Lang::get('system::lang.locale.da'), 'flag-dk'],
+             'en' => [Lang::get('system::lang.locale.en'), 'flag-us'],",The indentation on this is off by one space to the left,I don't think this is the right way to do it. I 
+9240,"@@ -52,7 +52,9 @@ static VkImageSubresourceRange RangeFromLayers(const VkImageSubresourceLayers &s
+ static VkImageSubresourceRange MakeImageFullRange(const VkImageCreateInfo &create_info) {
+     const auto format = create_info.format;
+     VkImageSubresourceRange init_range{0, 0, VK_REMAINING_MIP_LEVELS, 0, VK_REMAINING_ARRAY_LAYERS};
+-    if (FormatIsColor(format) || FormatIsMultiplane(format)) {
++    const VkExternalFormatANDROID *pExternalFormatANDROID = lvl_find_in_chain<VkExternalFormatANDROID>(&create_info);
++    bool isExternalFormatConversion = (pExternalFormatANDROID != nullptr && pExternalFormatANDROID->externalFormat != 0);
++    if (FormatIsColor(format) || FormatIsMultiplane(format) || isExternalFormatConversion) {
+         init_range.aspectMask = VK_IMAGE_ASPECT_COLOR_BIT;  // Normalization will expand this for multiplane
+     } else {
+         init_range.aspectMask =","I guess nothing is wrong with this approach, but more curious if you didn't just go `|| (format != VK_FORMAT_UNDEFINED)) {` As if there ever was another external format system added in Vulkan it would need to be manually added here",`pExternalFormatANDROID != nullptr && pExternalFormatANDROID->externalFormat != 0`
+9241,"@@ -22,7 +22,8 @@
+ package com.github.javaparser.resolution.types;
+ 
+ import java.util.*;
+-import java.util.stream.Collectors;
++
++import static java.util.stream.Collectors.joining;
+ 
+ /**
+  * A union type is defined in java as list of types separates by pipes.",Is order really irrelevant here?,Why is this needed?
+9242,"@@ -15,11 +15,14 @@ import android.net.Uri;
+ import android.provider.MediaStore;
+ import android.speech.RecognizerIntent;
+ import android.support.annotation.NonNull;
++import android.support.design.widget.Snackbar;
+ import android.util.Base64;
+ import android.view.View;
+ import android.webkit.MimeTypeMap;
++import android.widget.Toast;
+ 
+ import org.fossasia.phimpme.R;
++import org.fossasia.phimpme.accounts.AccountActivity;
+ import org.fossasia.phimpme.data.local.AccountDatabase;
+ 
+ import java.io.ByteArrayOutputStream;",I think this import will be unused now. If it is unused remove it.,This import is unused.
+9243,"@@ -37,6 +37,13 @@ type MutationItem struct {
+ 	value []byte
+ }
+ 
++func NewBatch(kv RwKV) StatelessRwTx {
++	return &mutation{
++		db:   NewObjectDatabase(kv),
++		puts: btree.New(32),
++	}
++}
++
+ func (mi *MutationItem) Less(than btree.Item) bool {
+ 	i := than.(*MutationItem)
+ 	c := strings.Compare(mi.table, i.table)",Let's change to tx,Why do we need this?
+9244,"@@ -55,6 +55,12 @@ const (
+ 	// By default, this will be the block type given to all blocks
+ 	// that aren't explicitly some other type.
+ 	defaultBlockTypeDefault = keybase1.BlockType_DATA
++
++	// By default, allow 10% of the free bytes on disk to be used in the disk block cache.
++	defaultDiskBlockCacheFraction = 0.10
++
++	// By default, allow 15% of the free bytes on disk to be used in the sync block cache.
++	defaultSyncBlockCacheFraction = 0.10
+ )
+ 
+ // ConfigLocal implements the Config interface using purely local","Looks like I was wrong about the sync cache size being 15% before. There seems to be some reporting bug related to my use of the sync cache, that makes the limit different from the working set cache limit. For now, I say we keep this at `0.10` (change the param default too), and we can change it later if needed.",I don't think this should be in the config.
+9245,"@@ -151,7 +151,7 @@ func sentryNotSetupWarning() {
+ // from the last saved version. If it is, prompt to request anon ddev usage stats
+ // and update the info.
+ func checkDdevVersionAndOptInSentry() error {
+-	if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false {
++	if !output.JSONOutput && version.COMMIT != globalconfig.DdevGlobalConfig.LastUsedVersion && globalconfig.DdevGlobalConfig.InstrumentationOptIn == false && os.Getenv(""DDEV_NO_SENTRY"") == """" {
+ 		allowStats := util.Confirm(""It looks like you have a new ddev release.\nMay we send anonymous ddev usage statistics and errors?\nTo know what we will see please take a look at\nhttps://ddev.readthedocs.io/en/latest/users/cli-usage/#opt-in-usage-information\nPermission to beam up?"")
+ 		if allowStats {
+ 			globalconfig.DdevGlobalConfig.InstrumentationOptIn = true","I think it'd be a good idea to define the environment variable name as a constant in values.go because it's hard-coded in several places, but that's a small point.",I think this should be `DDEV_NO_SENTRY=true
+9246,"@@ -0,0 +1,6 @@
++class AddIndexesToClassifications < ActiveRecord::Migration
++  def change
++    add_index :classifications, :topic_id
++    add_index :classifications, [:classifiable_id, :classifiable_type]
++  end
++end",Style/SymbolArray: Use %i or %I for an array of symbols.,I think this should be `classifiable_type_i
+9247,"@@ -133,6 +133,13 @@ func TestComposeCmd(t *testing.T) {
+ 	assert.Error(err)
+ }
+ 
++func TestCheckCompose(t *testing.T) {
++	assert := asrt.New(t)
++
++	err := CheckDockerCompose()
++	assert.NoError(err)
++}
++
+ func TestGetAppContainers(t *testing.T) {
+ 	assert := asrt.New(t)
+ 	sites, err := GetAppContainers(""dockertest"")","Our habit is to go ahead and put a description line (or more) in front of every function, not just non-test or exported functions.",nit: `assert.NoError(err)` is more idiomati
+9248,"@@ -116,6 +116,10 @@ public abstract class AbstractOAuth2AuthenticationProvider implements Authentica
+         final OAuthRequest request = new OAuthRequest(Verb.GET, userEndpoint, service);
+         request.addHeader(""Authorization"", ""Bearer "" + accessToken.getAccessToken());
+         request.setCharset(""UTF-8"");
++
++        // Microsoft
++        request.addHeader(""Accept"", ""application/json"");
++
+         
+         final Response response = request.send();
+         int responseCode = response.getCode();",I'm slightly concerned about this because doesn't ORCID use XML instead of JSON?,I think this should be `application/json`
+9249,"@@ -17,7 +17,11 @@ def is_new_user_stats_batch():
+     So, we check the database and see if the difference between the last time stats were updated
+     and right now is greater than 12 hours.
+     """"""
+-    return datetime.now(timezone.utc) - db_stats.get_timestamp_for_last_user_stats_update() > timedelta(hours=TIME_TO_CONSIDER_STATS_AS_OLD)
++    last_update_ts = db_stats.get_timestamp_for_last_user_stats_update()
++    if(last_update_ts is None):
++        last_update_ts = datetime.min.replace(tzinfo=timezone.utc) # use min datetime value if last_update_ts is None
++
++    return datetime.now(timezone.utc) - last_update_ts > timedelta(hours=TIME_TO_CONSIDER_STATS_AS_OLD)
+ 
+ 
+ def notify_user_stats_update():",brackets around if conditions isn't really pythonic.,missing space after `if`
+9250,"@@ -396,9 +396,6 @@ func (h *Impl) Stop() {
+ 	h.namespaceCache.Stop()
+ 	h.membershipMonitor.Stop()
+ 	h.ringpopChannel.Close()
+-	if err := h.grpcListener.Close(); err != nil {
+-		h.logger.WithTags(tag.Error(err)).Error(""failed to close gRPC listener"")
+-	}
+ 	h.runtimeMetricsReporter.Stop()
+ 	h.persistenceBean.Close()
+ 	h.visibilityMgr.Close()","It turn out that when we close server it closed underlying listener itself, so this line always generated and error.",Why was this removed?
+9251,"@@ -38,13 +38,13 @@ function createObjects(user) {
+             error: err => console.log(err)
+         },
+         schema: [{
+-            name: 'Dog',
+-            primaryKey: '_id',
++            name: ""Dog"",
++            primaryKey: ""_id"",
+             properties: {
+-              _id: 'objectId?',
+-              breed: 'string?',
+-              name: 'string',
+-              realm_id: 'string?',
++              _id: ""objectId?"",
++              breed: ""string?"",
++              name: ""string"",
++              realm_id: ""string?"",
+             }
+         }]
+     };",Looks like this is for debugging? Maybe just remove.,Why did you change these?
+9252,"@@ -187,7 +187,10 @@ module Mongoid
+     #
+     # @since 1.0.0
+     def exists?
+-      context.count > 0
++      Mongoid.unit_of_work(disable: :current) do
++        # Don't use count here since Mongo does not use counted b-tree indexes
++        !context.dup.criteria.only(:_id).limit(1).entries.first.nil?
++      end
+     end
+ 
+     # Extract a single id from the provided criteria. Could be in an $and",Same here - this code is duplicated. I think we can just remove the `exists?` method completely from `Criteria` and it should delegate to the context.,Why do we need to disable this?
+9253,"@@ -150,8 +150,14 @@ void SYCLInternal::initialize(const sycl::queue& q) {
+ 
+     m_maxShmemPerBlock =
+         d.template get_info<sycl::info::device::local_mem_size>();
+-    m_indirectKernelMem.reset(*m_queue, m_instance_id);
++
+     m_indirectReducerMem.reset(*m_queue, m_instance_id);
++    for (auto& usm_mem : m_indirectKernelMem) {
++      usm_mem.reset(*m_queue, m_instance_id);
++      // TODO 0x1440= 5184, arbitrary, larger than largest encountered kernel.
++      usm_mem.reserve(0x1440);
++    }
++
+   } else {
+     std::ostringstream msg;
+     msg << ""Kokkos::Experimental::SYCL::initialize(...) FAILED"";",I'm not quite sure that we preallocate memory. Do you have a good reason for that?,Why do we need this?
+9254,"@@ -731,6 +731,17 @@ func (s *Server) checkAuth(c *client) bool {
+ 	}
+ }
+ 
++// Check that number of clients is below Max connection setting.
++func (s *Server) checkMaxConn(c *client) bool {
++	if c.typ == CLIENT {
++		s.mu.Lock()
++		ok := len(s.clients) <= s.opts.MaxConn
++		s.mu.Unlock()
++		return ok
++	}
++	return true
++}
++
+ // Remove a client or route from our internal accounting.
+ func (s *Server) removeClient(c *client) {
+ 	var rID string","If we have added to s.clients, we could just do the following since if its a route will be ok I think. s.mu.Lock() defer s.mu.Unlock() return len(s.clients) <+ s.opts.MaxConn",I think this should be called `
+9255,"@@ -53,7 +53,10 @@ void BalanceTask::invoke() {
+             LOG(INFO) << taskIdStr_ << ""Ask the src to give up the leadership."";
+             SAVE_STATE();
+             if (srcLived_) {
+-                client_->transLeader(spaceId_, partId_, src_).thenValue([this](auto&& resp) {
++                // For balance task of single replica, the target leader is src_ itself
++                HostAddr targetLeader = singleReplica_ ? src_ : kRandomPeer;
++                client_->transLeader(spaceId_, partId_, src_, targetLeader)
++                    .thenValue([this](auto&& resp) {
+                     if (!resp.ok()) {
+                         LOG(INFO) << taskIdStr_ << ""Transfer leader failed, status "" << resp;
+                         if (resp == nebula::Status::PartNotFound()) {","if the targetLeader is src_ itself, it is really need call transLeader function?",Why do we need this change?
+9256,"@@ -85,6 +85,7 @@ public class CSharpSurfaceNamer extends SurfaceNamer {
+ 
+   @Override
+   public String getAndSavePagedResponseTypeName(
++      Method method,
+       FeatureConfig featureConfig,
+       ModelTypeTable typeTable,
+       TypeRef inputType,",Can we remove this featureConfig since you removed in L98 (assuming it is not used else where),Why do we need this method?
+9257,"@@ -11,6 +11,7 @@ using Newtonsoft.Json;
+ 
+ using Xunit;
+ using System.Collections.Generic;
++using System.Linq;
+ 
+ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+ {",namespaces in this file need a sorting,Why is this needed?
+9258,"@@ -942,7 +942,7 @@ func ConfigureDefaultMTUs(hostMTU int, c *Config) {
+ 		c.VXLANMTU = hostMTU - vxlanMTUOverhead
+ 	}
+ 	if c.Wireguard.MTU == 0 {
+-		if c.KubernetesProvider == config.ProviderAKS && c.RouteSource == ""WorkloadIPs"" {
++		if c.Wireguard.EncryptHostTraffic {
+ 			// The default MTU on Azure is 1500, but the underlying network stack will fragment packets at 1400 bytes,
+ 			// see https://docs.microsoft.com/en-us/azure/virtual-network/virtual-network-tcpip-performance-tuning#azure-and-vm-mtu
+ 			// for details.",This line should actually be: `if c.KubernetesProvider == config.ProviderAKS && c.Wireguard.EncryptHostTraffic {` because we only need to tweak the MTU like this on AKS.,Why do we need this change?
+9259,"@@ -36,8 +36,14 @@ class FastTemporalMemory(TemporalMemory):
+   """"""
+ 
+   def __init__(self, *args, **kwargs):
++    maxSegmentsPerCell = kwargs.get(""maxSegmentsPerCell"") or 255
++    maxSynapsesPerSegment = kwargs.get(""maxSynapsesPerSegment"") or 255
++
+     super(FastTemporalMemory, self).__init__(*args, **kwargs)
+-    self.connections = Connections(self.numberOfCells())
++    self.connections = Connections(
++      self.numberOfCells(),
++      maxSegmentsPerCell=maxSegmentsPerCell,
++      maxSynapsesPerSegment=maxSynapsesPerSegment)
+ 
+ 
+   def burstColumns(self,",`get` has an optional second parameter that is the default if the key isn't found.,I don't think you need the 
+9260,"@@ -63,6 +63,7 @@ if (LDAP_HOST && $ldap_auth) {
+     if (!$passwd_hash) {
+         echo ""<account_out>\n"";
+         echo ""   <success/>\n"";
++        echo ""<id>$user->id</id>\n"";
+         echo ""</account_out>\n"";
+         exit();
+     }",Please also indent the new response line as was done to the existing line above.,Shouldn't this be `$user->id`?
+9261,"@@ -3403,6 +3403,13 @@ void Client::Handle_OP_AutoFire(const EQApplicationPacket *app)
+ 		DumpPacket(app);
+ 		return;
+ 	}
++
++	if (this->GetTarget() == this) {
++		this->MessageString(Chat::TooFarAway, TRY_ATTACKING_SOMEONE);
++		auto_fire = false;
++		return;
++	}
++
+ 	bool *af = (bool*)app->pBuffer;
+ 	auto_fire = *af;
+ 	auto_attack = false;",Shouldn't need this-> here.,Why is this check needed?
+9262,"@@ -2717,7 +2717,7 @@ bool Game::internalStartTrade(Player* player, Player* tradePartner, Item* tradeI
+ 	player->sendTradeItemRequest(player->getName(), tradeItem, true);
+ 
+ 	if (tradePartner->tradeState == TRADE_NONE) {
+-		tradePartner->sendTextMessage(MESSAGE_EVENT_ADVANCE, fmt::format(""{:s} wants to trade with you."", player->getName()));
++		tradePartner->sendTextMessage(MESSAGE_TRADE, fmt::format(""{:s} wants to trade with you."", player->getName()));
+ 		tradePartner->tradeState = TRADE_ACKNOWLEDGE;
+ 		tradePartner->tradePartner = player;
+ 	} else {","I believe this is incorrect, if I'm not wrong, MESSAGE_TRADE should be used when buying/selling items from NPC's",Why did you change this?
+9263,"@@ -728,6 +728,8 @@ namespace pwiz.Skyline
+                     return _listGraphPeakArea.FirstOrDefault(g => g.Type == type) ?? CreateGraphPeakArea(type);
+                 else if (split[1] == typeof(MassErrorGraphController).Name)
+                     return _listGraphMassError.FirstOrDefault(g => g.Type == type) ?? CreateGraphMassError(type);
++                else if (split[1] == typeof(DetectionsGraphController).Name)
++                    return _listGraphDetections.FirstOrDefault(g => g.Type == type) ?? CreateGraphDetections(type);
+                 else
+                     return null;
+             }","Better if you give split[0], split[1], and split[2] descriptive names than using them this much through so many lines of code.",I'm not sure if this is the ri
+9264,"@@ -41,8 +41,6 @@ export const getSetupIncompleteComponent = ( module, inGrid = false, fullWidth =
+ 	return ctaWrapper( cta, inGrid, fullWidth, createGrid );
+ };
+ 
+-export default getSetupIncompleteComponent;
+-
+ /**
+  * Creates a CTA component when module needs to be activated. Different wrapper HTML is needed depending on where the CTA gets output, which is determined by the inGrid, fullWidth, and createGrid parameters.
+  *",I know we're deleting this soon but I thought I'd fix it anyway :smile:,Why are we removing this?
+9265,"@@ -58,9 +58,9 @@ public final class Slf4jConstantLogMessage extends BugChecker implements MethodI
+ 
+         List<? extends ExpressionTree> args = tree.getArguments();
+         ExpressionTree messageArg = ASTHelpers.isCastable(
+-                ASTHelpers.getType(tree.getArguments().get(0)),
+-                state.getTypeFromString(""org.slf4j.Marker""),
+-                state)
++                        ASTHelpers.getType(tree.getArguments().get(0)),
++                        state.getTypeFromString(""org.slf4j.Marker""),
++                        state)
+                 ? args.get(1)
+                 : args.get(0);
+ ","I like this, makes it clearer what scope the continuation is in",Please revert this change
+9266,"@@ -367,12 +367,12 @@ describe('MergeCells', () => {
+       keyDownUp('tab');
+       keyDownUp('enter');
+ 
+-      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('top-left-corner!');
++      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('A1');
+ 
+       keyDownUp('tab');
+       keyDownUp('enter');
+ 
+-      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('top-left-corner!');
++      expect(spec().$container.find('.handsontableInputHolder textarea').val()).toEqual('B1');
+     });
+ 
+     it('should select the cell in the top-left corner of the merged cell, when navigating down using the SHIFT + ENTER key on the' +",These test checks if the value of the merged cells is correct. Please revert the changes and set `autoWrapCol` and `autoWrapRow` to `false` to the Handsontable instance. This change applies to the entire mergeCells.e2e.js file.,Why did you change this?
+9267,"@@ -598,3 +598,14 @@ func encodeAccounts(s *changeset.ChangeSet) ([]byte, error) {
+ }
+ 
+ // ---- Copy-Paste of code to decode ChangeSets: End -----
++
++var clearHashedChangesets = Migration{
++	Name: ""clear_hashed_changesets"",
++	Up: func(db ethdb.Database, tmpdir string, progress []byte, OnLoadCommit etl.LoadCommitHandler) error {
++		if err := db.(ethdb.BucketsMigrator).ClearBuckets(dbutils.AccountChangeSetBucket, dbutils.StorageChangeSetBucket); err != nil {
++			return err
++		}
++
++		return OnLoadCommit(db, nil, true)
++	},
++}","Don't need to clear them - because nobody have data there, also can don't delete buckets - just leave them, new nodes will not have them if remove bucket from buckets.go",Why do we need this migra
+9268,"@@ -0,0 +1,17 @@
++/* Copyright 2016 Google Inc
++ *
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ *      http://www.apache.org/licenses/LICENSE-2.0
++ *
++ * Unless required by applicable law or agreed to in writing, software
++ * distributed under the License is distributed on an ""AS IS"" BASIS,
++ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++ * See the License for the specific language governing permissions and
++ * limitations under the License.
++ */
++package com.google.api.codegen.viewmodel;
++
++public interface ApiMethodView {}","Similarly, this has only one implementing class",Why is this needed?
+9269,"@@ -22,7 +22,7 @@ module Selenium
+         class Common
+           MAX_REDIRECTS   = 20 # same as chromium/gecko
+           CONTENT_TYPE    = 'application/json'.freeze
+-          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE}.freeze
++          DEFAULT_HEADERS = {'Accept' => CONTENT_TYPE, 'Content-Type' => 'application/x-www-form-urlencoded'}.freeze
+ 
+           attr_accessor :timeout
+           attr_writer :server_url",Does it send requests with urlencoded bodies anywhere? I thought it sends only json. Maybe content-type should be `application/json` by default?,Why is this needed?
+9270,"@@ -268,7 +268,7 @@ class StubsGenerator
+     /**
+      * @return PhpParser\Node\Identifier|PhpParser\Node\Name|PhpParser\Node\NullableType|null
+      */
+-    public static function getParserTypeFromPsalmType(Type\Union $type)
++    public static function getParserTypeFromPsalmType(Type\Union $type): ?PhpParser\NodeAbstract
+     {
+         $nullable = $type->isNullable();
+ ",I must have forgotten that one in previous PR,Why not return `nul
+9271,"@@ -1,10 +1,8 @@
+ require ""test_helper""
+ 
+ class DiaryCommentTest < ActiveSupport::TestCase
+-  api_fixtures
+-  fixtures :diary_comments
+-
+   def test_diary_comment_count
+-    assert_equal 4, DiaryComment.count
++    comment = create(:diary_comment)
++    assert_includes DiaryComment.all, comment
+   end
+ end",This test name doesn't really reflect what the test does any more... Then again I'm not really sure what it is testing now - is it actually just testing that FactoryGirl can create records? or does that itself funnel through the rails code so that we're testing rails can create records?,Why did you remove 
+9272,"@@ -1423,8 +1423,12 @@ func (m *executor) putCStorVolumeReplica() (err error) {
+ 
+ // putUpgradeResult will put an upgrade result as defined in the task
+ func (m *executor) putUpgradeResult() (err error) {
++	raw, err := template.AsTemplatedBytes(""UpgradeResult"", m.Runtask.Spec.Task, m.Values)
++	if err != nil {
++		return
++	}
+ 	uresult, err := upgraderesult.
+-		BuilderForRuntask(""UpgradeResult"", m.Runtask.Spec.Task, m.Values).
++		BuilderForTemplateObject(raw).
+ 		Build()
+ 	if err != nil {
+ 		return",Can this be `BuilderForYAMLObject`,I don't think this is the right place to do this. The executor should be responsible for building the template object.
+9273,"@@ -42,12 +42,14 @@ cpp_test = pytest.mark.skipif(not hasattr(core, ""test_coverage""),
+ #-------------------------------------------------------------------------------
+ 
+ def test_multiprocessing_threadpool():
++    import atexit
+     # Verify that threads work properly after forking (#1758)
+     import multiprocessing as mp
+     from datatable.internal import get_thread_ids
+     parent_threads = get_thread_ids()
+     n = 4
+     pool = mp.Pool(processes=n)
++    atexit.register(pool.close)
+     child_threads = pool.starmap(get_thread_ids, [()] * n, chunksize=1)
+     assert len(child_threads) == n
+     for chthreads in child_threads:",better use `with mp.Pool(...) as pool:` here,Why is this needed?
+9274,"@@ -48,8 +48,12 @@ public class Pids extends AbstractApiBean {
+         String baseUrl = systemConfig.getDataCiteRestApiUrlString();
+         String username = System.getProperty(""doi.username"");
+         String password = System.getProperty(""doi.password"");
+-        JsonObjectBuilder result = PidUtil.queryDoi(persistentId, baseUrl, username, password);
+-        return ok(result);
++        try {
++            JsonObjectBuilder result = PidUtil.queryDoi(persistentId, baseUrl, username, password);
++            return ok(result);
++        } catch (Exception ex) {
++            return error(Response.Status.BAD_REQUEST, ex.getLocalizedMessage());
++        }
+     }
+ 
+     @GET","Since this is a config problem, BAD_REQUEST is probably not the right response.",Why do we need to catch this exception?
+9275,"@@ -479,6 +479,11 @@ func (o *Options) ProcessConfigFile(configFile string) error {
+ 				errors = append(errors, err)
+ 				continue
+ 			}
++			if dur < 30*time.Second {
++				err := &configErr{tk, fmt.Sprintf(""invalid lame_duck_duration of %v, minimum is 30 seconds"", dur)}
++				errors = append(errors, err)
++				continue
++			}
+ 			o.LameDuckDuration = dur
+ 		case ""trusted"":
+ 			switch v.(type) {","We could probably do 1 sec if we have time, and hence exit early if we have small number of clients. So LB = 60 sec. Grace = 10secs. So 50Sec window, if NumClients < 50, Close 1 every second. Then exit when NumClients == 0.",This should be `dur < 30 * time.Second`.
+9276,"@@ -75,7 +75,7 @@ def combine_frames(this, *args, how=""full""):
+         # If the same named index is found, that's used.
+         for this_column, this_name in this_index_map:
+             for that_col, that_name in that_index_map:
+-                if this_name == that_name:
++                if (this_column == that_col) and (this_name == that_name):
+                     # We should merge the Spark columns into one
+                     # to mimic pandas' behavior.
+                     this_scol = this._internal.scol_for(this_column)",can you rename `that_col` to `that_column`?,Why is this change needed?
+9277,"@@ -19,7 +19,9 @@
+ /**
+  * Internal dependencies
+  */
+-import Widgets from './googlesitekit/widgets';
++import { Widget } from './googlesitekit/widgets';
++
++const Widgets = { componenets: Widget };
+ 
+ if ( typeof global.googlesitekit === 'undefined' ) {
+ 	global.googlesitekit = {};","This is not correct, it will override everything else that is currently in `Widgets`. This file shouldn't be modified at all, we should be adding `components.Widget` in `assets/js/googlesitekit/widgets/index.js`, where the rest of that object is defined. Oh, and there's a typo here :)",Why do we need this?
+9278,"@@ -152,6 +152,14 @@ void BalanceTask::invoke() {
+                 if (!resp.ok()) {
+                     LOG(INFO) << taskIdStr_ << ""Update meta failed, status "" << resp;
+                     ret_ = Result::FAILED;
++                } else if (kv_ != nullptr) {
++                    if (LastUpdateTimeMan::update(kv_, time::WallClock::fastNowInMilliSec()) !=
++                            kvstore::ResultCode::SUCCEEDED) {
++                        LOG(INFO) << taskIdStr_ << ""Update meta failed"";
++                        ret_ = Result::FAILED;
++                    } else {
++                        status_ = Status::REMOVE_PART_ON_SRC;
++                    }
+                 } else {
+                     status_ = Status::REMOVE_PART_ON_SRC;
+                 }",Each task finished will result in the meta info updated?,Why do we need this check?
+9279,"@@ -88,7 +88,7 @@ class PageSpeedInsightsSetup extends Component {
+ 
+ 	handleAPIKeyChange( e ) {
+ 		this.setState( {
+-			apikey: e.currentTarget.value,
++			apikey: e.currentTarget.value.replace( /\s/g, '' ),
+ 			disabled: 0 === e.currentTarget.value.length,
+ 		} );
+ 	}","Quick follow-up @aaemnnosttv, why this and not `.trim()`?",Why is this needed?
+9280,"@@ -1,3 +1,4 @@
++/* eslint-disable sitekit/camelcase-acronyms */
+ /**
+  * Profile Select component tests.
+  *","I don't think we should have file-wide exceptions for this rule, let's annotate the individual instances.",Why is this disabled?
+9281,"@@ -101,6 +101,8 @@ public class MailServiceBean implements java.io.Serializable {
+     private Session session;
+ 
+     public boolean sendSystemEmail(String to, String subject, String messageText) {
++        if (true) return true;
++
+         boolean sent = false;
+         String body = messageText + ResourceBundle.getBundle(""Bundle"").getString(""notification.email.closing"");
+         logger.fine(""Sending email to "" + to + "". Subject: <<<"" + subject + "">>>. Body: "" + body);","@raprasad you plan to take this ""if true"" out, right?",Why is this needed?
+9282,"@@ -496,11 +496,13 @@ class ConsoleMaster(flow.FlowMaster):
+         self.eventlog = not self.eventlog
+         self.view_flowlist()
+ 
+-    def _readflow(self, path):
+-        path = os.path.expanduser(path)
++    def _readflow(self, paths):
+         try:
+-            f = file(path, ""rb"")
+-            flows = list(flow.FlowReader(f).stream())
++            flows = []
++            for path in paths:
++                path = os.path.expanduser(path)
++                f = file(path, ""rb"")
++                flows.extend(list(flow.FlowReader(f).stream()))
+         except (IOError, flow.FlowReadError), v:
+             return True, v.strerror
+         return False, flows","Could you adjust this to `with open(path, ""rb""):` here and below? We should make sure that we close all files.",`list(flow.FlowReader
+9283,"@@ -7,6 +7,8 @@ package libkbfs
+ import (
+ 	""testing""
+ 
++	""golang.org/x/net/context""
++
+ 	""github.com/keybase/kbfs/kbfshash""
+ 	""github.com/keybase/kbfs/tlf""
+ )",Does this need its own import block or can it be combined with the imports below as in most other files?,"""github.com/keybase/g"
+9284,"@@ -34,6 +34,12 @@ _registered_options = {
+     # For example, this value determines whether the repr() for a dataframe prints out fully or
+     # just a truncated repr.
+     ""display.max_rows"": 1000,  # TODO: None should support unlimited.
++
++    # This determines whether or not to operate between two different dataframs.
++    # For example, 'combine_frames' function internally performs a join operation which can be
++    # expensive in general.
++    # So, if `compute.ops_on_diff_frames` variable is not True, that method throws an exception.
++    ""compute.ops_on_diff_frames"": True,
+ }  # type: Dict[str, Any]
+ 
+ ",It defaults to `false`.,I don't think this is needed.
+9285,"@@ -7,8 +7,12 @@ type corsHandler struct {
+ }
+ 
+ func (wrapper corsHandler) ServeHTTP(resp http.ResponseWriter, req *http.Request) {
+-	resp.Header().Set(""Access-Control-Allow-Origin"", ""*"")
+-	resp.Header().Set(""Access-Control-Allow-Methods"", ""POST, GET, OPTIONS, PUT, DELETE"")
++	if isPreflightCorsRequest(req) {
++		applyPreflightCorsResponse(resp)
++		return
++	}
++
++	allowAllCorsActions(resp)
+ 	wrapper.originalHandler.ServeHTTP(resp, req)
+ }
+ ","Why conditional check is done? As i understand, later both `applyPreflightCorsResponse()` and `allowAllCorsActions()` does the same",Why do we need this?
+9286,"@@ -142,6 +142,9 @@ func (mh *MessageHandle) OnRegister(connection conn.Connection) {
+ 
+ 	if _, ok := mh.KeepaliveChannel[nodeID]; !ok {
+ 		mh.KeepaliveChannel[nodeID] = make(chan struct{}, 1)
++	} else {
++		klog.Warningf(""Node %v/%v has not yet exit, OnRegister failed"", projectID, nodeID)
++		return
+ 	}
+ 
+ 	io := &hubio.JSONIO{Connection: connection}",has not yet exit?,I don't think this should be 
+9287,"@@ -247,6 +247,11 @@ _rt_hemuother_per_user_known = {
+ 
+ class RadioTap(Packet):
+     name = ""RadioTap dummy""
++    deprecated_fields = {
++        ""Channel"": ""ChannelFrequency"",  # 2.4.3
++        ""ChannelFlags2"": ""ChannelPlusFlags"",  # 2.4.3
++        ""ChannelNumber"": ""ChannelPlusNumber""  # 2.4.3
++    }
+     fields_desc = [
+         ByteField('version', 0),
+         ByteField('pad', 0),",I wonder if the version should be part of the deprecation API. It might ease our future selves while debugging issues =),This should be 2.4.4
+9288,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,Why is this changed to `finest`?
+9289,"@@ -183,10 +183,11 @@ namespace Microsoft.Sarif.Viewer
+                 HelpLink = rule?.HelpUri?.ToString()
+             };
+ 
+-            IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotationsFromStacks(result.Stacks);
++            IEnumerable<IEnumerable<AnnotatedCodeLocation>> stackLocations = CreateAnnotatedCodeLocationsFromStacks(result.Stacks);
++            IEnumerable<IEnumerable<AnnotatedCodeLocation>> codeFlowLocations = CreateAnnotatedCodeLocationsFromCodeFlows(result.CodeFlows);
+ 
+             CreateAnnotatedCodeLocationCollections(stackLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+-            CreateAnnotatedCodeLocationCollections(result.CodeFlows, AnnotatedCodeLocationKind.CodeFlow, sarifError);
++            CreateAnnotatedCodeLocationCollections(codeFlowLocations, AnnotatedCodeLocationKind.CodeFlow, sarifError);
+             CaptureAnnotatedCodeLocations(result.RelatedLocations, AnnotatedCodeLocationKind.Stack, sarifError);
+ 
+             if (region != null)",This is just a rename...,`CreateAnnotationsFromStacks` wa
+9290,"@@ -33,7 +33,10 @@ func GetLengthLimitedID(fixedPrefix, suffix string, maxLength int) string {
+ 		// start with the character that we use to denote a shortened string, which could
+ 		// result in a clash.  Hash the value and truncate...
+ 		hasher := sha256.New()
+-		hasher.Write([]byte(suffix))
++		_, err := hasher.Write([]byte(suffix))
++		if err != nil {
++			return """"
++		}
+ 		hash := base64.RawURLEncoding.EncodeToString(hasher.Sum(nil))
+ 		charsLeftForHash := maxLength - 1 - prefixLen
+ 		return fixedPrefix + shortenedPrefix + hash[0:charsLeftForHash]","Should probably panic here. I think hashers are contracted not to return errors (and returning """" doesn't handle the error)",Why not return the error here?
+9291,"@@ -13,7 +13,7 @@ import (
+ // Address is the interface that defines methods to manage Filecoin addresses and wallets.
+ type Address interface {
+ 	Addrs() Addrs
+-	Import(ctx context.Context, f files.Directory) ([]address.Address, error)
++	Import(ctx context.Context, f files.File) ([]address.Address, error)
+ 	Export(ctx context.Context, addrs []address.Address) ([]*types.KeyInfo, error)
+ }
+ ",Aside: this is a confusing name for an interface that contains multiple addresses.,Why did you change this?
+9292,"@@ -47,10 +47,8 @@ module Bolt
+       state = node_result['state']
+       result = node_result['result']
+ 
+-      result_output = Bolt::Node::ResultOutput.new
+-      result_output.stdout << result.to_json
+       if state == 'finished'
+-        Bolt::Node::Success.new(result.to_json, result_output)
++        exit_code = 0
+       else
+         # Try to extract the exit_code from _error
+         begin",We expect to use Bolt::CommandResult for scripts as well?,Shouldn't this be `exit_code = 1`?
+9293,"@@ -386,7 +386,9 @@ module RSpec
+         user_metadata = Metadata.build_hash_from(args)
+ 
+         @metadata = Metadata::ExampleGroupHash.create(
+-          superclass_metadata, user_metadata, description, *args, &example_group_block
++          superclass_metadata, user_metadata,
++          superclass.method(:next_runnable_index_for),
++          description, *args, &example_group_block
+         )
+ 
+         hooks.register_globals(self, RSpec.configuration.hooks)",same thing as above inre commas and args?,I'm not sure if this is the best w
+9294,"@@ -224,6 +224,9 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     queryResultWindowSize = Math.max(1, getInt(""query/queryResultWindowSize"", 1));
+     queryResultMaxDocsCached = getInt(""query/queryResultMaxDocsCached"", Integer.MAX_VALUE);
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
++
++    useCircuitBreakers = getBool(""query/useCircuitBreakers"", false);
++    memoryCircuitBreakerThreshold = getInt(""query/memoryCircuitBreakerThreshold"", 100);
+     
+     useRangeVersionsForPeerSync = getBool(""peerSync/useRangeVersions"", true);
+ ",Should we validate that this is between 0 and 100?,"I think this should be `getInt(""qu"
+9295,"@@ -332,7 +332,7 @@ func (c *cliApp) help() {
+ 
+ // quit stops cli and client commands and exits application
+ func (c *cliApp) quit() {
+-	stop := utils.SoftKiller(c.Kill)
++	stop := utils.HardKiller(c.Kill)
+ 	stop()
+ }
+ ",`HardKiller` doing `os.Exit()` without proper shutting down other dependencies. I think there should be a better approach for this.,why hard killer?
+9296,"@@ -136,16 +136,12 @@ const struct wlr_gles2_pixel_format *get_gles2_format_from_gl(
+ 	return NULL;
+ }
+ 
+-const uint32_t *get_gles2_shm_formats(const struct wlr_gles2_renderer *renderer,
+-		size_t *len) {
+-	static uint32_t shm_formats[sizeof(formats) / sizeof(formats[0])];
+-	size_t j = 0;
++void init_gles2_data_ptr_formats(struct wlr_gles2_renderer *renderer) {
+ 	for (size_t i = 0; i < sizeof(formats) / sizeof(formats[0]); i++) {
+ 		if (!is_gles2_pixel_format_supported(renderer, &formats[i])) {
+ 			continue;
+ 		}
+-		shm_formats[j++] = formats[i].drm_format;
++		wlr_drm_format_set_add(&renderer->data_ptr_texture_formats,
++			formats[i].drm_format, DRM_FORMAT_MOD_LINEAR);
+ 	}
+-	*len = j;
+-	return shm_formats;
+ }",Why isnt the return value checked?,Why do we need this function?
+9297,"@@ -28,12 +28,15 @@ package util
+ 
+ import (
+ 	""fmt""
+-	""k8s.io/apimachinery/pkg/util/json""
+ 	""strings""
++
++	""k8s.io/apimachinery/pkg/util/json""
+ )
+ 
+ // GetNestedField returns a nested field from the provided map
+ func GetNestedField(obj map[string]interface{}, fields ...string) interface{} {
++	fmt.Println(""obj"", obj)
++	fmt.Println(""fields"", fields)
+ 	var val interface{} = obj
+ 	for _, field := range fields {
+ 		if _, ok := val.(map[string]interface{}); !ok {",remove this debug,Is this intentional?
+9298,"@@ -286,10 +286,13 @@ auto data_type_layer<TensorDataType>::get_local_error_signals(int parent_index)
+ // Accessing matrices corresponding to parent/child layer
+ template <typename TensorDataType>
+ auto data_type_layer<TensorDataType>::get_activations(const Layer& child) const -> const BaseDistMat& {
+-  const int child_index = (std::find(m_child_layers.begin(),
+-                                     m_child_layers.end(),
+-                                     &child)
+-                           - m_child_layers.begin());
++  if(m_child_layers.empty()) {
++    LBANN_ERROR(""This layer has no children"");
++  }
++  const int child_index = std::distance(m_child_layers.begin(),
++                                        std::find(m_child_layers.begin(),
++                                                  m_child_layers.end(),
++                                                  &child));
+   if (child_index >= get_num_children()) {
+     std::stringstream err;
+     err << ""attempted to get activation tensor of ""","This should change to a call to `Layer::find_layer_index`, which should be renamed to `find_child_layer_index` and it should return a `size_t` (technically the `difference_type` for whatever iterators are going to be used).",Please use `std::find_if`
+9299,"@@ -114,7 +114,7 @@ class py2exe(build_exe.py2exe):
+ 
+ 	def build_manifest(self, target, template):
+ 		mfest, rid = build_exe.py2exe.build_manifest(self, target, template)
+-		if getattr(target, ""script"", None) == ""nvda.pyw"":
++		if getattr(target, ""script"", """").endswith("".pyw""):
+ 			# This is one of the main application executables.
+ 			mfest = mfest[:mfest.rindex(""</assembly>"")]
+ 			mfest += MAIN_MANIFEST_EXTRA + ""</assembly>""",what is this change about?,I think this should be `endsw
+9300,"@@ -161,8 +161,6 @@ class Testinfra(Verifier):
+             cmd=[""pytest"", *util.dict2args(options), *self._tests, *args],
+             cwd=self._config.scenario.directory,
+             env=self.env,
+-            stdout=LOG.out,
+-            stderr=LOG.error,
+         )
+         # print(self._testinfra_command.cmd)
+ ",Why did we leave the `stderr` param in this case while we removed it from other bake methods?,Why is this removed?
+9301,"@@ -30,6 +30,13 @@ func VerifyTrustDomainMemberID(td spiffeid.TrustDomain, id spiffeid.ID) error {
+ 	return nil
+ }
+ 
++func VerifySameTrustDomain(td spiffeid.TrustDomain, id spiffeid.ID) error {
++	if !id.MemberOf(td) {
++		return fmt.Errorf(""%q is not a member of trust domain %q"", id, td)
++	}
++	return nil
++}
++
+ func TrustDomainAgentIDFromProto(td spiffeid.TrustDomain, protoID *types.SPIFFEID) (spiffeid.ID, error) {
+ 	id, err := idFromProto(protoID)
+ 	if err != nil {",This seems to only be used by the server/ca package.... maybe this can live there instead of being lumped into these API implementation helpers?,nit: `VerifySameTrus
+9302,"@@ -1035,6 +1035,15 @@ func TestProvisionContainerResourcesSetPausePIDInVolumeResources(t *testing.T) {
+ 		}, nil),
+ 		mockCNIClient.EXPECT().SetupNS(gomock.Any(), gomock.Any(), gomock.Any()).Return(nsResult, nil),
+ 	)
++	// These mock calls would be made only for Windows.
++	dockerClient.EXPECT().CreateContainerExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(
++		&types.IDResponse{ID: containerID}, nil).MinTimes(0).MaxTimes(1)
++	dockerClient.EXPECT().StartContainerExec(gomock.Any(), gomock.Any(), gomock.Any(), gomock.Any()).Return(nil).
++		MinTimes(0).MaxTimes(1)
++	dockerClient.EXPECT().InspectContainerExec(gomock.Any(), gomock.Any(), gomock.Any()).Return(&types.ContainerExecInspect{
++		ExitCode: 0,
++		Running:  false,
++	}, nil).MinTimes(0).MaxTimes(1)
+ 
+ 	require.Nil(t, taskEngine.(*DockerTaskEngine).provisionContainerResources(testTask, pauseContainer).Error)
+ 	assert.Equal(t, strconv.Itoa(containerPid), volRes.GetPauseContainerPID())","hmm.. this is Hacky, the test will succeed in Windows even if you remove the calls to these, right?",Why do we need these
+9303,"@@ -1,4 +1,9 @@
+-test_name 'Install beaker and checkout branch if necessary' do
++ruby_version, ruby_source = ENV['RUBY_VER'], ""job parameter""
++unless ruby_version
++  ruby_version = ""2.3.1""
++  ruby_source = ""default""
++end
++test_name 'Install and configure Ruby #{ruby_version} (from #{ruby_source}) on the SUT' do
+ 
+   step 'Download the beaker git repo' do
+    on default, 'git clone https://github.com/puppetlabs/beaker.git /opt/beaker/'",should this block be in the file `05_install_ruby.rb`?,I think this should 
+9304,"@@ -167,7 +167,9 @@ func withDisconnectedClient(t *testing.T, recorder *Recorder, f func(raw.Client)
+ 				Unary: http.NewOutbound(""http://localhost:65535""),
+ 			},
+ 		},
+-		Filter: recorder,
++		Filters: yarpc.Filters{
++			UnaryFilter: recorder,
++		},
+ 	})
+ 	require.NoError(t, clientDisp.Start())
+ 	defer clientDisp.Stop()","To match outbounds, let's just call this `Unary: recorder`, `Oneway: ...`.",Why is this needed?
+9305,"@@ -49,7 +49,7 @@ def stripControlChars(string):
+ 
+ def compactHash(string):
+   hash = md5()
+-  hash.update(string)
++  hash.update(string.encode('unicode_escape'))
+   return hash.hexdigest()
+ 
+ ",`string.encode('utf-8')` is more common but I guess this is mostly cosmetic :),Why is this necessa
+9306,"@@ -23,6 +23,6 @@ func NewLoggingHandler(handler http.Handler) LoggingHandler {
+ }
+ 
+ func (lh LoggingHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
+-	log.Info(""Handling http request"", ""method"", r.Method, ""from"", r.RemoteAddr, ""uri"", r.RequestURI)
++	log.Info(""Handling http request"", ""method"", r.Method, ""from"", r.RemoteAddr)
+ 	lh.h.ServeHTTP(w, r)
+ }","Consider logging `r.Url.Path`? Either way, ship it!",I don't think we ne
+9307,"@@ -54,14 +54,16 @@ type Context struct {
+ // Group data are omitted because they are committed to in the
+ // transaction and its ID.
+ type Params struct {
+-	CurrSpecAddrs transactions.SpecialAddresses
+-	CurrProto     protocol.ConsensusVersion
++	CurrSpecAddrs  transactions.SpecialAddresses
++	CurrProto      protocol.ConsensusVersion
++	MinTealVersion uint64
+ }
+ 
+ // PrepareContexts prepares verification contexts for a transaction
+ // group.
+ func PrepareContexts(group []transactions.SignedTxn, contextHdr bookkeeping.BlockHeader) []Context {
+ 	ctxs := make([]Context, len(group))
++	minTealVersion := logic.ComputeMinTealVersion(group)
+ 	for i := range group {
+ 		spec := transactions.SpecialAddresses{
+ 			FeeSink:     contextHdr.FeeSink,",this probably should be done lazely only if logic/app call txn in the group. Or even done in LogicSigSanityCheck?,Why do we need to c
+9308,"@@ -1639,6 +1639,10 @@ func (e *mutableStateBuilder) addWorkflowExecutionStartedEventForContinueAsNew(
+ 		SearchAttributes:         attributes.SearchAttributes,
+ 	}
+ 
++	if attributes.GetInitiator() == enumspb.CONTINUE_AS_NEW_INITIATOR_UNSPECIFIED {
++		attributes.Initiator = enumspb.CONTINUE_AS_NEW_INITIATOR_WORKFLOW
++	}
++
+ 	req := &historyservice.StartWorkflowExecutionRequest{
+ 		NamespaceId:              e.namespaceEntry.GetInfo().Id,
+ 		StartRequest:             createRequest,",Please move this to `common/enums/defaults.go`.,Why do we need this?
+9309,"@@ -2,6 +2,7 @@
+ import time
+ import json
+ import re
++import listenbrainz.db.user as db_user
+ from collections import defaultdict
+ from yattag import Doc
+ import yattag","In general, if you find unalphabetized imports, you should alphabetize them. Fine for now though.",F401 'listenbrainz.d
+9310,"@@ -39,5 +39,5 @@ class InputDevice(object):
+     def clear_actions(self):
+         self.actions = []
+ 
+-    def create_pause(self, duraton=0):
++    def create_pause(self, duration=0):
+         pass",we should probably deprecate (and display a warning) the misspelled keyword arg here rather than removing it... and then add the new one. This changes a public API and will break any code that is currently using the misspelled version.,`duraton` -> `durati
+9311,"@@ -49,7 +49,12 @@ namespace pwiz.Skyline.Model
+             SLens = explicitSLens;
+             ConeVoltage = explicitConeVoltage;
+             DeclusteringPotential = explicitDeclusteringPotential;
+-            CompensationVoltage = explicitCompensationVoltage;
++            if (explicitCompensationVoltage.HasValue &&
++                (explicitIonMobilityUnits != MsDataFileImpl.eIonMobilityUnits.compensation_V ||
++                 !Equals(explicitIonMobility, explicitCompensationVoltage)))
++            {
++                CompensationVoltage = explicitCompensationVoltage;
++            }
+         }
+ 
+         public ExplicitTransitionGroupValues(ExplicitTransitionGroupValues other)","Is this if statement here necessary? It looks like this is the same logic that is taken care of in the setter for the property ""CompensationVoltage"".",I don't think this i
+9312,"@@ -68,6 +68,14 @@ def bulk_send(elastic, list_):
+         raise_on_exception=False
+     )
+ 
++def key_to_parts(key):
++    """"""make a string for fulltext indexing of file name""""""
++    base, ext = os.path.splitext(key)
++    key_parts = base.split(""/"")
++    key_parts.append(ext[1:])
++
++    return f""{key} {' '.join(key_parts)}""
++
+ class DocumentQueue:
+     """"""transient in-memory queue for documents to be indexed""""""
+     def __init__(self, context):",Eliminate this function; handled by mappings and analyzer,I think it would be better to use `os.path.normpath` here.
+9313,"@@ -249,7 +249,14 @@ class JSTree extends AbstractBase
+                     'recordID' => '__record_id__'
+                 ]
+             ];
+-            $cache[$route] = $this->router->fromRoute($route, $params, $options);
++            $routeName = $route;
++            $datasource = $this->getDataSource();
++            if ($route === 'collection') {
++                $routeName = $datasource->getCollectionRoute();
++            } elseif ($route === 'record') {
++                $routeName = $datasource->getRecordRoute();
++            }
++            $cache[$route] = $this->router->fromRoute($routeName, $params, $options);
+         }
+         return str_replace('__record_id__', urlencode($id), $cache[$route]);
+     }","I wonder if this new logic would actually fit better as a support method, both for readability and overriding... e.g. <pre> protected function getRouteNameFromDataSource($route) { if ($route === 'collection') { return $this->getDataSource()->getCollectionRoute(); } elseif ($route === 'record') { return $this->getDataSource()->getRecordRoute(); } return $route; } </pre> That's extremely nitpicky, and you can feel free to leave this as-is if you prefer... but that feels marginally better to me.",Why do we need this?
+9314,"@@ -35,13 +35,13 @@ public class BaseSuite {
+   public static ExternalResource testEnvironment = new ExternalResource() {
+     @Override
+     protected void before() {
+-      log.info(""Preparing test environment"");
++      log.finest(""Preparing test environment"");
+       GlobalTestEnvironment.get(SeleniumTestEnvironment.class);
+       System.setProperty(""webdriver.remote.shorten_log_messages"", ""true"");
+     }
+     @Override
+     protected void after() {
+-      log.info(""Cleaning test environment"");
++      log.finest(""Cleaning test environment"");
+       TestEnvironment environment = GlobalTestEnvironment.get();
+       if (environment != null) {
+         environment.stop();",This is in test code: understanding what we're doing is important in this context.,Why are we changing these to finest?
+9315,"@@ -16,7 +16,7 @@ import (
+ 	""github.com/tinygo-org/tinygo/ir""
+ 	""github.com/tinygo-org/tinygo/loader""
+ 	""golang.org/x/tools/go/ssa""
+-	""tinygo.org/x/go-llvm""
++	llvm ""tinygo.org/x/go-llvm""
+ )
+ 
+ func init() {","This change (and a few similar ones below) are not related to rpi3 support, and should be removed.",Why is this change needed?
+9316,"@@ -382,7 +382,7 @@ class KoalasBoxPlot(BoxPlot):
+         showcaps=None,
+         showbox=None,
+         showfliers=None,
+-        **kwargs
++        **kwargs,
+     ):
+         # Missing arguments default to rcParams.
+         if whis is None:","Hmm, why did we come to need the `,` at the end?",Why this change?
+9317,"@@ -13,7 +13,8 @@ module.exports = function selectPopulatedFields(query) {
+     var userProvidedFields = query._userProvidedFields || {};
+     if (query.selectedInclusively()) {
+       for (i = 0; i < paths.length; ++i) {
+-        if (!isPathInFields(userProvidedFields, paths[i])) {
++        var hasPath = query._fields[paths[i]];
++        if (!isPathInFields(userProvidedFields, paths[i]) && hasPath) {
+           query.select(paths[i]);
+         }
+       }","I'm suspicious of this. For one thing, `query._fields[paths[i]]` may be `0`, `false`, etc. so checking for falsy will catch both cases where both the field isn't in the projection and if the field is explicitly excluded from the projection. For another, I'm not so sure that #6546 is a bug. Let's discuss that more.",I don't think we
+9318,"@@ -32,6 +32,8 @@ type Parser struct {
+ 	interpreter *interpreter
+ 	// Stashed set of source code for builtin rules.
+ 	builtins map[string][]byte
++
++	statements []*Statement
+ }
+ 
+ // NewParser creates a new parser instance. One is normally sufficient for a process lifetime.",What is this? I'm a bit unclear why the parser would have a list of statements in it.,Why do we need t
+9319,"@@ -29,6 +29,14 @@ var (
+ 			""name"",
+ 		}, nil,
+ 	)
++	descPrometheusEnforcedSampleLimit = prometheus.NewDesc(
++		""prometheus_operator_enforced_sample_limit"",
++		""Global limit on the number of scraped samples per scrape target."",
++		[]string{
++			""namespace"",
++			""name"",
++		}, nil,
++	)
+ )
+ 
+ type prometheusCollector struct {","I believe this is Prometheus name, wonder if this is descriptive enough of a label name? @nrchakradhar @simonpasquier wdyt?",nit: `Global lim
+9320,"@@ -213,6 +213,11 @@ type Config struct {
+ 	IpInIpMtu        int    `config:""int;1440;non-zero""`
+ 	IpInIpTunnelAddr net.IP `config:""ipv4;""`
+ 
++	// Knobs provided to explicitly control whether we add rules to drop encap traffic
++	// from workloads. We always add them unless explicitly disabled.
++	DropVXLANPacketsFromWorkloads bool `config:""bool;true""`
++	DropIPIPPacketsFromWorkloads  bool `config:""bool;true""`
++
+ 	AWSSrcDstCheck string `config:""oneof(DoNothing,Enable,Disable);DoNothing;non-zero""`
+ 
+ 	ReportingIntervalSecs time.Duration `config:""seconds;30""`",Are most of our other fields default-zero-value? Would `AllowVXLANPacketsFromWorkloads` be a better formulation of this? I think it would make it easier for golang users of the API (default value matches the type zero-value),I don't think this should be a config option.
+9321,"@@ -35,7 +35,7 @@ namespace Nethermind.TxPool
+         void AddPeer(ITxPoolPeer peer);
+         void RemovePeer(PublicKey nodeId);
+         AddTxResult AddTransaction(Transaction tx, TxHandlingOptions handlingOptions);
+-        void RemoveTransaction(Keccak hash, long blockNumber);
++        void RemoveTransaction(Keccak hash, long blockNumber, bool removeSmallerNonces);
+         bool TryGetPendingTransaction(Keccak hash, out Transaction transaction);
+         UInt256 ReserveOwnTransactionNonce(Address address);
+         event EventHandler<TxEventArgs> NewDiscovered;","void RemoveTransactions(Address sander, long removeBelowThisNonce) and separate these two calls","`RemoveTransaction(Keccak hash, bool removeSm"
+9322,"@@ -4365,6 +4365,8 @@ func TestJetStreamSnapshotsAPI(t *testing.T) {
+ 	// Now connect through a cluster server and make sure we can get things to work this way as well.
+ 	nc2 := clientConnectToServer(t, ls)
+ 	defer nc2.Close()
++	// Wait a bit for interest to propagate.
++	time.Sleep(100 * time.Millisecond)
+ 
+ 	snapshot = snapshot[:0]
+ ","Not sure which interest you are looking for to propagate here, but keep in mind that we have helpers (maybe not in /test package?) to check/wait for interest on a literal on a server for a given account.",Why is this needed?
+9323,"@@ -140,6 +140,7 @@ func execProcess(context *cli.Context) (int, error) {
+ 		detach:          detach,
+ 		pidFile:         context.String(""pid-file""),
+ 		action:          CT_ACT_RUN,
++		init:            false,
+ 	}
+ 	return r.run(p)
+ }",nit: should not need this.,Why is this needed?
+9324,"@@ -89,6 +89,8 @@ public class Constants {
+   // The flow exec id for a flow trigger instance unable to trigger a flow yet
+   public static final int FAILED_EXEC_ID = -2;
+ 
++  // Name of the file which keeps project directory size
++  public static final String PROJECT_DIR_SIZE_FILE_NAME = ""___azkaban_project_dir_size_in_bytes___"";
+ 
+   public static class ConfigurationKeys {
+ ","Since this constant is an implementation detail rather than a user-facing API, is it better to define it in a place where it is used?",I think this should be `_azkaban_project_dir_size_in_bytes`
+9325,"@@ -1007,6 +1007,8 @@ class ListParameter(Parameter):
+         :param str x: the value to parse.
+         :return: the parsed value.
+         """"""
++        if isinstance(x, list):
++            x = json.dumps(x)
+         return list(json.loads(x, object_pairs_hook=FrozenOrderedDict))
+ 
+     def serialize(self, x):",It would be nice if we have some docs explaining this. Core luigi should avoid having hard to understand code.,Why is this needed?
+9326,"@@ -43,6 +43,11 @@ public abstract class StemmerTestBase extends LuceneTestCase {
+ 
+   static void init(boolean ignoreCase, String affix, String... dictionaries)
+       throws IOException, ParseException {
++    stemmer = new Stemmer(loadDictionary(ignoreCase, affix, dictionaries));
++  }
++
++  static Dictionary loadDictionary(boolean ignoreCase, String affix, String... dictionaries)
++      throws IOException, ParseException {
+     if (dictionaries.length == 0) {
+       throw new IllegalArgumentException(""there must be at least one dictionary"");
+     }",extract a method to call from a test,Why do we need this method?
+9327,"@@ -184,6 +184,8 @@ public class CoreContainer {
+   private volatile ExecutorService coreContainerWorkExecutor = ExecutorUtil.newMDCAwareCachedThreadPool(
+       new DefaultSolrThreadFactory(""coreContainerWorkExecutor""));
+ 
++  final private ExecutorService collectorExecutor;
++
+   private final OrderedExecutor replayUpdatesExecutor;
+ 
+   protected volatile LogWatcher logging = null;",nitpick: regular order is private than final.,I think this should be `final`
+9328,"@@ -145,6 +145,11 @@ class DocstringParameterChecker(BaseChecker):
+             ""useless-type-doc"",
+             ""Please remove the ignored parameter type documentation."",
+         ),
++        ""W9021"": (
++            'Missing any documentation in ""%s""',
++            ""missing-any-param-doc"",
++            ""Please add parameter and/or type documentation."",
++        ),
+     }
+ 
+     options = (","We could add an old names here, the ideal would be to not force to disable missing-any-param when the old one was already disabled. But they are not really equivalent so maybe you were right to not add it.",I think this should be `W9022`
+9329,"@@ -8,11 +8,13 @@
+                 public const string BenchF = ""BenchF"";
+                 public const string BenchI = ""BenchI"";
+             public const string Inlining = ""Inlining"";
+-            public const string SIMD = ""SIMD"";
+-            public const string Span = ""Span"";
+             public const string V8 = ""V8"";
+             public const string Perflab = ""Perflab"";
+         
+         public const string CoreFX = ""CoreFX"";
++
++        public const string LINQ = ""LINQ"";
++        public const string SIMD = ""SIMD"";
++        public const string Span = ""Span"";
+     }
+ }",">public const string LINQ = ""LINQ""; [](start = 8, length = 34) Are there duplicated benchmarks here? #Closed",Why did you change this?
+9330,"@@ -129,14 +129,16 @@ module Beaker
+         end
+       end
+ 
+-      def do_install hosts, version, path, pre_30, options = {} 
++      def do_install hosts, options = {}
+         #convenience methods for installation
+         ########################################################
+-        def installer_cmd(host, version, installer)
++        def installer_cmd(host, options)
+           if host['platform'] =~ /windows/
++            version = options[:pe_ver_win] || host['pe_ver_win']
+             ""cd #{host['working_dir']} && msiexec.exe /qn /i puppet-enterprise-#{version}.msi""
+           else
+-            ""cd #{host['working_dir']}/#{host['dist']} && ./#{installer}""
++            version = options[:pe_ver] || host['pe_ver']
++            ""cd #{host['working_dir']}/#{host['dist']} && ./#{options[:installer]}""
+           end
+         end
+         def link_exists?(link)",Probably worth taking the opportunity to add yardocs to this method now. Esp. curious about what the options hash accepts.,Should this be `options[:insta
+9331,"@@ -271,6 +271,12 @@ static void roots_cursor_press_button(struct roots_cursor *cursor,
+ 			break;
+ 		case WLR_BUTTON_PRESSED:
+ 			roots_seat_set_focus(seat, view);
++			if (surface && !view) {
++				struct wlr_layer_surface *layer = surface->role_data;
++				if (layer->current.keyboard_interactive) {
++					roots_seat_set_focus_layer(seat, layer);
++				}
++			}
+ 			break;
+ 		}
+ 	}","This is Very Meh . We want to get rid of `role_data`, and it's an internal field.",This should be `layer->current
+9332,"@@ -97,6 +97,11 @@ class Database {
+ 		return this.tryCall('selectOne', sql, params);
+ 	}
+ 
++	async loadExtension(path) {
++		const result = await this.driver()['loadExtension'](path);
++		return result;
++	}
++
+ 	async selectAll(sql, params = null) {
+ 		return this.tryCall('selectAll', sql, params);
+ 	}",`await this.driver().loadExtension(path);` should work,Why do we need this method?
+9333,"@@ -98,12 +98,12 @@ func TestAddDepRescan(t *testing.T) {
+ 	target1.AddDependency(buildLabel(""//package1:target4""))
+ 
+ 	// Fake test: calling this now should have no effect because rescan is not true.
+-	state.QueueTarget(buildLabel(""//package1:target1""), core.OriginalTarget, false, false)
++	state.QueueTarget(buildLabel(""//package1:target1""), core.OriginalTarget, false)
+ 	assertPendingParses(t, state)
+ 	assertPendingBuilds(t, state) // Note that the earlier call to assertPendingBuilds cleared it.
+ 
+ 	// Now running this should activate it
+-	rescanDeps(state, map[*core.BuildTarget]struct{}{target1: {}})
++	// rescanDeps(state, map[*core.BuildTarget]struct{}{target1: {}})
+ 	time.Sleep(time.Millisecond * 100)
+ 
+ 	assertPendingBuilds(t, state, ""//package1:target4"")",Is any of this needed anymore?,Why this change?
+9334,"@@ -26,6 +26,16 @@
+ #include ""ostree-repo-private.h""
+ #include ""otutil.h""
+ 
++/* See ostree-repo.c for a bit more info about these ABI checks */
++#if __SIZEOF_POINTER__ == 8 && __SIZEOF_LONG__ == 8 && __SIZEOF_INT__ == 4
++G_STATIC_ASSERT(sizeof(OstreeDiffDirsOptions) ==
++                sizeof(int) * 2 +
++                sizeof(gpointer) +
++                sizeof(int) * (7+6) +
++                sizeof(int) +  /* hole */
++                sizeof(gpointer) * 7);
++#endif
++
+ static gboolean
+ get_file_checksum (OstreeDiffFlags  flags,
+                    GFile *f,",Can you add a mention here and in `ostree-repo.c` that the holes were found with `pahole`?,I'm not sure if this is the
+9335,"@@ -78,7 +78,17 @@ module Blacklight::SolrHelper
+   # Returns a two-element array (aka duple) with first the solr response object,
+   # and second an array of SolrDocuments representing the response.docs
+   def get_search_results(user_params = params || {}, extra_controller_params = {})
+-    solr_response = query_solr(user_params, extra_controller_params)
++    Deprecation.warn(self, ""get_search_results is deprecated and will be removed in blacklight-6.0. Use `search_results' instead"")
++    search_results(user_params, extra_controller_params, solr_search_params_logic)
++  end
++
++  # a solr query method
++  # @param [Hash,HashWithIndifferentAccess] user_params ({}) the user provided parameters (e.g. query, facets, sort, etc)
++  # @param [Hash,HashWithIndifferentAccess] extra_controller_params ({}) extra parameters to add to the search
++  # @param [List<Symbol] processor_chain a list of filter methods to run
++  # @return [Blacklight::SolrResponse] the solr response object
++  def search_results(user_params, extra_controller_params, solr_search_parms_logic)
++    solr_response = query_solr(user_params, extra_controller_params, solr_search_params_logic)
+ 
+     case
+     when (solr_response.grouped? && grouped_key_for_results)","While we're changing this, I wonder if we can do away with `extra_controller_params`.. Maybe a new type of `solr_search_params_logic` that appends the attributes?",I'm not sure if this is the
+9336,"@@ -564,6 +564,8 @@ module Beaker
+ 
+           yield self if block_given?
+ 
++        rescue Beaker::DSL::Assertions, Minitest::Assertion => early_assertion
++          fail_test(early_assertion)
+         rescue Exception => early_exception
+           original_exception = RuntimeError.new(""PuppetAcceptance::DSL::Helpers.with_puppet_running_on failed (check backtrace for location) because: #{early_exception}\n#{early_exception.backtrace.join(""\n"")}\n"")
+           raise(original_exception)","I believe that you only need to rescue Beaker::DSL::Assertions, as they include Minitest::Assertions.",Should this be `raise` instead of `raise`?
+9337,"@@ -372,6 +372,7 @@ namespace OpenTelemetry.Trace
+         private void RunGetRequestedDataAlwaysOffSampler(Activity activity)
+         {
+             activity.IsAllDataRequested = false;
++            activity.ActivityTraceFlags &= ActivityTraceFlags.None;
+         }
+ 
+         private void RunGetRequestedDataOtherSampler(Activity activity)",Do we need `&=` or `=` is sufficient?,Why is this needed?
+9338,"@@ -161,8 +161,8 @@ $settings['trusted_host_patterns'] = ['.*'];
+ $settings['class_loader_auto_detect'] = FALSE;
+ 
+ // This specifies the default configuration sync directory.
+-if (empty($config_directories[CONFIG_SYNC_DIRECTORY])) {
+-  $config_directories[CONFIG_SYNC_DIRECTORY] = '{{ joinPath $config.SitePath $config.SyncDir }}';
++if (empty($settings['config_sync_directory'])) {
++  $settings['config_sync_directory'] = '{{ joinPath $config.SitePath $config.SyncDir }}';
+ }
+ `
+ )",Let's keep both of these here. It should work on most any version of Drupal 8 then true?,This should be `$settings['config_sync_dir
+9339,"@@ -699,7 +699,7 @@ namespace OpenTelemetry.Trace.Test
+         private void AssertApproxSameTimestamp(DateTime one, DateTime two)
+         {
+             var timeShift = Math.Abs((one - two).TotalMilliseconds);
+-            Assert.InRange(timeShift, double.Epsilon, 10);
++            Assert.InRange(timeShift, double.Epsilon, 20);
+         }
+     }
+ }",@lmolkova This ok? I'm getting random failures from the build checks that don't happen locally from a few non-deterministic time related comparisons.,What's the reason for this change?
+9340,"@@ -1,5 +1,5 @@
+ /*
+- * Copyright ConsenSys AG.
++ * Copyright Hyperledger Besu Contributors.
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License""); you may not use this file except in compliance with
+  * the License. You may obtain a copy of the License at",Q: are we supposed to change this for files that already exist?,Why did you change this?
+9341,"@@ -477,7 +477,7 @@ def initialize_unbounded(obj, dimensions, key):
+     """"""
+     select = dict(zip([d.name for d in dimensions], key))
+     try:
+-        obj.select([DynamicMap], **select)
++        obj.select(selection_specs=[DynamicMap], **select)
+     except KeyError:
+         pass
+ ","I count only four times where `selection_specs` had to be specified as a keyword instead of by position! If that is how often it was used that positional argument in our own codebase, I am pretty certain users barely used it (if at all).",Why is this change neces
+9342,"@@ -24,5 +24,10 @@ describe HashDiffDecorator do
+       output = HashDiffDecorator.html_for(['~', 'foo', '', 'bar'])
+       expect(output).to eq(""<code>foo</code> was changed from <code>[empty]</code> to <code>&quot;bar&quot;</code>"")
+     end
++
++    it ""renders numeric events"" do
++      output = HashDiffDecorator.html_for(['~', 'a_number', 456, 123])
++      expect(output).to eq(""<code>a_number</code> was changed from <code>456.00</code> to <code>123.00</code>"")
++    end
+   end
+ end",is this test for the case above? seems to cover a numeric rather than empty val?,I think this should be `
+9343,"@@ -245,6 +245,9 @@ class FlowHandler(RequestHandler):
+                         request.port = int(v)
+                     elif k == ""headers"":
+                         request.headers.set_state(v)
++                    elif k == ""content"":
++                        print(v)
++                        response.content = str(v)
+                     else:
+                         print(""Warning: Unknown update {}.{}: {}"".format(a, k, v))
+ ","I like the general idea, but this will break: - JSON is not binary-safe, so anything binary will break this. - JSON is super slow for multiple-MB things - We want to have drag-and-drop upload - the easiest way to implement this is FormData upload, so we should have a multipart/formdata endpoint. Can we put to /flow/content?",This should be removed.
+9344,"@@ -121,6 +121,7 @@ bool    dr_preinjected = false;
+ static bool dynamo_exiting = false;
+ #endif
+ bool    dynamo_exited = false;
++bool    dynamo_exited_synched = false;
+ bool    dynamo_exited_and_cleaned = false;
+ #ifdef DEBUG
+ bool    dynamo_exited_log_and_stats = false;",_and_synched seems to be more consistent w/ exited_and_cleaned,`dynamo_exited_and_cleaned` -> `dynamo_exited_and_cleaned`
+9345,"@@ -13,6 +13,7 @@
+ // See the License for the specific language governing permissions and
+ // limitations under the License.
+ // </copyright>
++#if NETCOREAPP3_1
+ using Moq;
+ using Newtonsoft.Json;
+ using OpenTelemetry.Trace;",nit: in case of whole file `ifdef` it may be helpful to have `_netcore31` suffix it in the name of the file as well.,Why is this needed?
+9346,"@@ -35,12 +35,9 @@ public class SetNetworkConnection extends WebDriverHandler<Number> implements Js
+   @SuppressWarnings(""unchecked"")
+   @Override
+   public void setJsonParameters(Map<String, Object> allParameters) throws Exception {
+-	  Map<String, Map<String, Object>> parameters = (Map<String, Map<String, Object>>)allParameters.get(""parameters"");
+-	  Map<String, Object> typeMap = parameters.get(""type"");
+-	  
+-	  type = new ConnectionType(Boolean.parseBoolean(typeMap.get(""wifiEnabled"").toString()), 
+-			  					Boolean.parseBoolean(typeMap.get(""dataEnabled"").toString()),
+-			  					Boolean.parseBoolean(typeMap.get(""airplaneMode"").toString()));
++    Map<String, Object> parameters = (Map<String, Object>)allParameters.get(""parameters"");
++    Long bitmask = (Long) parameters.get(""type"");
++    type = new ConnectionType(bitmask.intValue());
+   }
+ 
+   @Override",should use Number instead of Long,Why do we need to cast here?
+9347,"@@ -10,7 +10,8 @@ class CartDecorator < Draper::Decorator
+   end
+ 
+   def approvals_by_status
+-    object.approvals.order(
++    # Override default scope
++    object.approvals.reorder(
+       # http://stackoverflow.com/a/6332081/358804
+       <<-SQL
+         CASE approvals.status",Had no idea that method existed!,Line is too long. [83/80]
+9348,"@@ -38,6 +38,7 @@ class TestTabWidget:
+         qtbot.addWidget(w)
+         monkeypatch.setattr(tabwidget.objects, 'backend',
+                             usertypes.Backend.QtWebKit)
++        monkeypatch.setattr(w.tabBar(), 'width', w.width)
+         return w
+ 
+     @pytest.fixture","I wonder if we shouldn't just do `w.show()` here, which causes Qt to correctly calculate the sizes.",Why is this needed?
+9349,"@@ -24,12 +24,14 @@ class SparkDataFrameS3StoragePlugin(TypeStoragePlugin):  # pylint: disable=no-in
+     @classmethod
+     def set_object(cls, object_store, obj, _context, _runtime_type, paths):
+         target_path = object_store.key_for_paths(paths)
+-        obj.write.parquet('s3a://' + target_path)
++        obj.write.parquet('s3a://' + object_store.bucket + '/' + target_path)
+         return target_path
+ 
+     @classmethod
+     def get_object(cls, object_store, context, _runtime_type, paths):
+-        return context.resources.spark.read.parquet('s3a://' + object_store.key_for_paths(paths))
++        return context.resources.spark.read.parquet(
++            's3a://' + object_store.bucket + '/' + object_store.key_for_paths(paths)
++        )
+ 
+ 
+ class SparkDataFrameFilesystemStoragePlugin(TypeStoragePlugin):  # pylint: disable=no-init",may be nice to have helper method to generate s3 paths rather than the minor code dup,Why do we need this
+9350,"@@ -169,11 +169,15 @@ export default Controller.extend(ValidationEngine, {
+     _oauthSetup() {
+         let blogTitle = this.get('blogTitle');
+         let config = this.get('config');
++        let promises = [];
++
++        promises.pushObject(this.get('settings').fetch());
++        promises.pushObject(this.get('config').fetchPrivate());
+ 
+         this.get('hasValidated').addObjects(['blogTitle', 'session']);
+ 
+         return this.validate().then(() => {
+-            return this.get('settings').fetch()
++            return RSVP.all(promises)
+                 .then((settings) => {
+                     settings.set('title', blogTitle);
+ ","This isn't needed here, we still run `this._afterAuthentication` which loads settings & config - the reason the settings fetch is here is to make sure we have all the settings before saving the blog title rather than fetching everything once auth has completed. Probably moot anyway as the oauth code will be removed shortly  ",Why do we need to d
+9351,"@@ -397,7 +397,7 @@ func assertConfigsCompatible(cfg1, cfg2 *Config) error {
+ 	if c1.ClientAuth != c2.ClientAuth {
+ 		return fmt.Errorf(""client authentication policy mismatch"")
+ 	}
+-	if c1.ClientAuth != tls.NoClientCert && c2.ClientAuth != tls.NoClientCert && c1.ClientCAs != c2.ClientCAs {
++	if c1.ClientAuth != tls.NoClientCert && c2.ClientAuth != tls.NoClientCert && !StringSliceEqual(cfg1.ClientCerts, cfg2.ClientCerts) {
+ 		// Two hosts defined on the same listener are not compatible if they
+ 		// have ClientAuth enabled, because there's no guarantee beyond the
+ 		// hostname which config will be used (because SNI only has server name).",This line is getting a little long; let's move the conditions to at least two lines (maybe three).,Why do we need this
+9352,"@@ -37,6 +37,10 @@
+ 
+ #include <fastdds/dds/log/Log.hpp>
+ 
++#include ""../../../../fastdds/core/policy/ParameterList.hpp""
++
++using ParameterList = eprosima::fastdds::dds::ParameterList;
++
+ namespace eprosima {
+ namespace fastrtps {
+ namespace rtps {",Don't use relative paths. src directory is already on the include search path,Why do we need this?
+9353,"@@ -2,7 +2,7 @@ class Api::V1::CompletionsController < ApiController
+   before_action :doorkeeper_authorize!, if: lambda { !signed_in? }
+ 
+   def index
+-    respond_with current_resource_owner.completions.only_trail_object_ids
++    respond_with completions: current_resource_owner.completions.only_trail_object_ids
+   end
+ 
+   def create",Line is too long. [86/80],Metrics/LineLength: 
+9354,"@@ -4,6 +4,11 @@ describe 'TwitterDigits' do
+   let(:service_provider_url) { Faker::Internet.url }
+   let(:credentials) { ""oauth_consumer_key=#{ Faker::Internet.password }"" }
+ 
++  before do
++    original_twitter_digits_path = File.expand_path('../../../../app/lib/twitter_digits.rb', __FILE__)
++    load original_twitter_digits_path
++  end
++
+   it 'must return the id_str when response is 200' do
+     id_str = Faker::Internet.password
+     response = stub(code: '200', body: { id_str: id_str }.to_json)","We have to navigate up four directories to come down three? I see it, but it's kinda icky. Is something like `load Rails.root + 'app/lib/twitter_digits.rb'` out of fashion nowadays?",Why do we need this?
+9355,"@@ -208,6 +208,10 @@ int main(int argc, char *argv[]) {
+ 
+    res = fpgaDmaOpen(afc_h, &dma_h);
+    ON_ERR_GOTO(res, out_dma_close, ""fpgaDmaOpen"");
++   if(!dma_h) {
++      res = FPGA_EXCEPTION;
++      ON_ERR_GOTO(res, out_dma_close, ""Invaid DMA Handle"");
++   }
+ 
+    if(use_ase)
+       count = ASE_TEST_BUF_SIZE;",Empty space at end.,This should be `if(!
+9356,"@@ -215,6 +215,7 @@ module Bolt
+     def with_bolt_executor(executor, inventory, pdb_client = nil, applicator = nil, &block)
+       setup
+       opts = {
++        bolt_project: @project,
+         bolt_executor: executor,
+         bolt_inventory: inventory,
+         bolt_pdb_client: pdb_client,",I think similar to line 176 here we'll want to call `detect_project_conflict` after overriding this.,Why do we need to pass in the project here?
+9357,"@@ -1,7 +1,8 @@
+ const fs = require('fs')
+ const path = require('path')
+ const chalk = require('chalk')
+-const { exec } = require('child_process')
++const { spawn } = require('child_process')
++const readline = require('readline')
+ const YAML = require('js-yaml')
+ const { promisify } = require('util')
+ const gzipSize = require('gzip-size')",How about `const { promises: fs } = require('fs')` and then replacing `fs.promises.` with `fs.`?,Why is this needed?
+9358,"@@ -129,13 +129,9 @@ func getGithubData(ctx context.Context, url string) ([]byte, error) {
+ 		return nil, fmt.Errorf(""unexpected status %v (%v) returned"", res.StatusCode, res.Status)
+ 	}
+ 
+-	buf, err := ioutil.ReadAll(res.Body)
+-	if err != nil {
+-		_ = res.Body.Close()
+-		return nil, err
+-	}
++	defer res.Body.Close()
+ 
+-	err = res.Body.Close()
++	buf, err := ioutil.ReadAll(res.Body)
+ 	if err != nil {
+ 		return nil, err
+ 	}","This ignores errors closing the body. Not likely to happen, but no reason to take the risk either.",Shouldn't this be `defer`ed?
+9359,"@@ -73,7 +73,7 @@ public abstract class FlinkTestBase extends AbstractTestBase {
+   }
+ 
+   protected static TableResult exec(TableEnvironment env, String query, Object... args) {
+-    return env.executeSql(String.format(query, args));
++    return env.executeSql(args.length > 0 ? String.format(query, args) : query);
+   }
+ 
+   protected TableResult exec(String query, Object... args) {",Why was this change needed?,"`String.format(query, args)` can be replace"
+9360,"@@ -259,6 +259,8 @@ namespace pwiz.Skyline
+             (c, p) => c.LockmassNegative = p.ValueDouble);
+         public static readonly Argument ARG_IMPORT_LOCKMASS_TOLERANCE = new DocArgument(@""import-lockmass-tolerance"", NUM_VALUE,
+             (c, p) => c.LockmassTolerance = p.ValueDouble);
++        public static readonly Argument ARG_IMPORT_PEAK_BOUNDARIES = new DocArgument(@""import-peak-boundaries"", PATH_TO_FILE,
++            (c, p) => c.ImportPeakBoundaries = p.ValueFullPath);
+ 
+         private static readonly ArgumentGroup GROUP_IMPORT = new ArgumentGroup(() => CommandArgUsage.CommandArgs_GROUP_IMPORT_Importing_results_replicates, false,
+             ARG_IMPORT_FILE, ARG_IMPORT_REPLICATE_NAME, ARG_IMPORT_OPTIMIZING, ARG_IMPORT_APPEND, ARG_IMPORT_ALL,",Needs a description added to CommandArgsUsage.resx,">PATH_TO_FILE [](start = 76, length = 11) PathToFile? #Resolved"
+9361,"@@ -153,7 +153,7 @@ public class DownloadServiceNotification {
+                 iconId = R.drawable.ic_notification_sync_error;
+                 intent = ClientConfig.downloadServiceCallbacks.getReportNotificationContentIntent(context);
+                 id = R.id.notification_download_report;
+-                content = String.format(context.getString(R.string.download_report_content), successfulDownloads, failedDownloads);
++                content = context.getResources().getQuantityString(R.plurals.download_report_content, successfulDownloads, successfulDownloads, failedDownloads);
+             }
+ 
+             NotificationCompat.Builder builder = new NotificationCompat.Builder(context, channelId);",The line is a bit too long. That's why the test currently fails. Please break it into two lines.,I think this should be `getResources().getString(R.string.downl
+9362,"@@ -59,6 +59,13 @@ public class NodeStatus {
+     }
+   }
+ 
++  public boolean hasCapability(Capabilities caps) {
++    long count = slots.stream()
++        .filter(slot -> slot.isSupporting(caps))
++        .count();
++    return count > 0;
++  }
++
+   public boolean hasCapacity() {
+     return slots.stream().anyMatch(slot -> !slot.getSession().isPresent());
+   }",Prefer `Stream.anyMatch` instead of iterating over all slots.,I don't think we need this method. We can just use `slots.size(
+9363,"@@ -1,4 +1,6 @@
+ module Ncr
++  START_OF_NEW_6X_APPROVAL_POLICY = Time.zone.local(2016, 7, 5, 0, 0, 0)
++
+   class ApprovalManager
+     def initialize(work_order)
+       @work_order = work_order",Can this just be a feature flag to check if it's on? This will give us flexibility on launch date (which could be turned on July 1st) and allow us to easily revert back in case the policy is reverted.,Layout/EmptyLinesAroundModuleBody: Extra empty line detected at
+9364,"@@ -44,4 +44,5 @@ func (p Pin) Low() {
+ 
+ type ADC struct {
+ 	Pin Pin
++	Bus uint8
+ }","Due to this change, src/examples/adc needs to be modified",Why do we need this?
+9365,"@@ -19,6 +19,12 @@ import (
+ 	""unsafe""
+ )
+ 
++// singlePointer wraps an unsafe.Pointer and supports basic
++// load(), store(), clear(), and swapNil() operations.
++type singlePtr struct {
++	ptr unsafe.Pointer
++}
++
+ func (l *sortedLabels) Len() int {
+ 	return len(*l)
+ }",`s/singlePointer/singlePtr` or please rename the type to `singlePointer`.,nit: `unsafe.Pointer
+9366,"@@ -577,7 +577,8 @@ bool nano::node_config::upgrade_json (unsigned version_a, nano::jsonconfig & jso
+ 		}
+ 		case 17:
+ 		{
+-			json.put (""vote_generator_delay"", vote_generator_delay.count ()); // Update value
++			json.put (""active_elections_size"", 10000); // Update value
++			json.put (""vote_generator_delay"", 100); // Update value
+ 			json.put (""backup_before_upgrade"", backup_before_upgrade);
+ 			json.put (""work_watcher_period"", work_watcher_period.count ());
+ 		}",Do we need it? If right now it's toml,Why did you change t
+9367,"@@ -22,6 +22,16 @@ options._catchError = function(error, newVNode, oldVNode) {
+ 	oldCatchError(error, newVNode, oldVNode);
+ };
+ 
++const oldUnmount = options.unmount;
++options.unmount = function(vnode) {
++	/** @type {import('./internal').Component} */
++	const component = vnode._component;
++	if (component && component._onResolve) {
++		component._onResolve();
++	}
++	if (oldUnmount) oldUnmount(vnode);
++};
++
+ function detachedClone(vnode, detachedParent, parentDom) {
+ 	if (vnode) {
+ 		if (vnode._component && vnode._component.__hooks) {","You are never calling oldUnmount, this could lead to a plugin chain failing.",Why do we need this?
+9368,"@@ -119,7 +119,9 @@ public class MetaUtils {
+         name = ""Table"" + tid;
+       }
+       return new TiTableInfo(
+-          tid, CIStr.newCIStr(name), """", """", pkHandle, columns, indices, """", 0, 0, 0, 0);
++          tid, CIStr.newCIStr(name), """", """", pkHandle, columns,
++          indices, """", 0, 0, 0
++          , 0, null);
+     }
+   }
+ ",What does setting partitionInfo to null mean exactly?,Why do we need this change?
+9369,"@@ -225,6 +225,18 @@ class BokehPlot(DimensionedPlot):
+                     source.data.update(converted_data)
+                 else:
+                     source.stream(data, stream.length)
++            return
++
++        # Determine if the CDS.data requires a full update or simply needs
++        # to be updated, this is done by determining whether newly added
++        # or not updated columns have the same length
++        new_length = [len(v) for v in data.values() if isinstance(v, (list, np.ndarray))]
++        length = [len(v) for v in source.data.values() if isinstance(v, (list, np.ndarray))]
++        not_updated = [k for k in source.data if k not in data]
++        new = [k for k in data if k not in source.data]
++        if ((not_updated and new_length and any(len(source.data[n]) != new_length[0] for n in not_updated))
++            or (new and length and any(len(data[n]) != length[0] for n in new))):
++            source.data = data
+         else:
+             source.data.update(data)
+ ",Not sure you need the initial ``not_updated`` as ``any([])`` evaluates to false.,I don't think this is the r
+9370,"@@ -0,0 +1,13 @@
++class AddPublishedAtToVideos < ActiveRecord::Migration
++  def up
++    add_column :videos, :published_at, :datetime
++    execute <<-SQL
++      UPDATE videos
++      SET published_at = created_at
++    SQL
++  end
++
++  def down
++    remove_column :videos, :published_at
++  end
++end","Since this migration hasn't been merged to master yet, what do you think about just squashing these two into the migration you really want?",I'm not sure if this is the
+9371,"@@ -0,0 +1 @@
++BetterErrors.editor = :subl if defined? BetterErrors",This doesn't apply to all developers,
+9372,"@@ -52,13 +52,16 @@ class SonataMediaExtension extends Extension
+         $loader->load('gaufrette.xml');
+         $loader->load('validators.xml');
+         $loader->load('serializer.xml');
+-        $loader->load('api_form.xml');
+-
++        
+         $bundles = $container->getParameter('kernel.bundles');
+ 
+         if ('doctrine_orm' == $config['db_driver'] && isset($bundles['FOSRestBundle']) && isset($bundles['NelmioApiDocBundle'])) {
+             $loader->load('api_controllers.xml');
+         }
++        
++        if (isset($bundles['JMSSerializerBundle'])) {
++            $loader->load('api_form.xml');
++        }
+ 
+         if (isset($bundles['SonataNotificationBundle'])) {
+             $loader->load('consumer.xml');",I think `serializer.xml` can be moved into condition below too,Why did you change this?
+9373,"@@ -21,6 +21,9 @@ namespace Benchmarks
+     {
+         public static void Main(string[] args)
+         {
++            // examples to run from command line:
++            // navigate to opentelemetry-dotnet\src\benchmarks directory and run the following
++            // dotnet run --framework netcoreapp3.1 --configuration Release --filter *OpenTelemetrySdkBenchmarksActivity*
+             BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);
+         }
+     }",Probably put this in a simple README.md file?,nit: remove this empty l
+9374,"@@ -0,0 +1,18 @@
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT License. See License.txt in the project root for license information.
++
++using System;
++using System.Collections.Generic;
++using System.Linq;
++using System.Threading.Tasks;
++
++namespace AutoRest.Core.Validation
++{
++    [Flags]
++    public enum ValidationCategory
++    {
++        RPCViolation    = 1 << 0,
++        OneAPIViolation = 1 << 1,
++        SDKViolation    = 1 << 2,
++    }
++}","Super Cool bitwise   Minor: Most likely you don't need `System.Collections.Generic`, `System.Linq` & `System.Threading.Tasks`",nit: missing new line
+9375,"@@ -20,7 +20,7 @@ public class DefaultMicroserviceClassLoaderFactory implements MicroserviceClassL
+   public static final MicroserviceClassLoaderFactory INSTANCE = new DefaultMicroserviceClassLoaderFactory();
+ 
+   @Override
+-  public ClassLoader create(String microserviceName, String version) {
++  public ClassLoader create(String appId, String microserviceName, String version) {
+     return Thread.currentThread().getContextClassLoader();
+   }
+ }","If we just return the TCC, maybe we need to update the method name for it.",`appId` is not used.
+9376,"@@ -111,8 +111,7 @@ namespace AutoRest.Extensions
+             if (methodList.Count == 1)
+             {
+                 Method method = methodList.Single();
+-                return string.Format(CultureInfo.InvariantCulture, ""Additional parameters for the {0} operation."",
+-                    createOperationDisplayString(method.MethodGroup.Name.ToPascalCase(), method.Name));
++                return string.Format(CultureInfo.InvariantCulture, ""Additional parameters for {0} operation."", method.Name);
+             }
+             else if (methodList.Count <= 4)
+             {","For consistency, shouldn't this use `SwaggerModeler.GetMethodNameFromOperationId(method.Name)` as above? I'd just reuse `""Additional parameters for "" + SwaggerModeler.GetMethodNameFromOperationId(method.Name) + "" operation.""` here, `string.Format` with `CultureInfo` is complete nonsense here anyways.",Why did you remove the `createOperationDisplayString` call?
+9377,"@@ -32,7 +32,7 @@ TEST(LivelinessQos, Liveliness_Automatic_Reliable)
+     // Liveliness lease duration and announcement period
+     uint32_t liveliness_ms = 200;
+     Duration_t liveliness_s(liveliness_ms * 1e-3);
+-    Duration_t announcement_period(liveliness_ms * 1e-3 * 0.5);
++    Duration_t announcement_period(liveliness_ms * 1e-3 * 0.01);
+ 
+     reader.reliability(RELIABLE_RELIABILITY_QOS)
+             .liveliness_kind(AUTOMATIC_LIVELINESS_QOS)","As this is just a backport, I guess it is fine to leave these timings, although they are not enough to make tests stable.",Why did you change this?
+9378,"@@ -70,8 +70,8 @@ func New(p client.ConfigProvider, cfgs ...*aws.Config) *ECS {
+ 
+ // newClient creates, initializes and returns a new service client instance.
+ func newClient(cfg aws.Config, handlers request.Handlers, endpoint, signingRegion, signingName string) *ECS {
+-	if signingName == """" {
+-		signingName = ServiceName
++	if len(signingName) == 0 {
++		signingName = ""ecs""
+ 	}
+ 	svc := &ECS{
+ 		Client: client.New(",Why this way?,Why is this change needed?
+9379,"@@ -38,10 +38,7 @@ const (
+ func setupEnvironment(t *testing.T) string {
+ 	t.Helper()
+ 	// TODO(shahms): ExtractCompilations should take an output path.
+-	output := os.Getenv(""TEST_TMPDIR"")
+-	if output == """" {
+-		t.Skip(""Skipping test due to incompatible environment (missing TEST_TMPDIR)"")
+-	}
++	output := t.TempDir()
+ 	if err := os.Setenv(""KYTHE_OUTPUT_DIRECTORY"", output); err != nil {
+ 		t.Fatalf(""Error setting KYTHE_OUTPUT_DIRECTORY: %v"", err)
+ 	}",Changing this because otherwise the second run of testExtractCompilationsEndToEndWithDatabase will try to overwrite a generated file and fail. Maybe there's a better way?,Why is this change needed?
+9380,"@@ -90,6 +90,9 @@ public final class HttpUtils {
+    * @return the encoded path param
+    */
+   public static String encodePathParam(String pathParam) {
++    if (pathParam.indexOf(';') != -1) {
++      pathParam = pathParam.substring(0, pathParam.indexOf(';'));
++    }
+     return UrlEscapers.urlPathSegmentEscaper().escape(pathParam);
+   }
+ ",This modification is not correct. Suggections: 1. upgread guava to 30.0-jre will fix this issue,I think you can use StringUtils.isNotBlank(pathParam)
+9381,"@@ -17,8 +17,8 @@ type syscalls struct {
+ var _ specsruntime.Syscalls = (*syscalls)(nil)
+ 
+ // VerifySignature implements Syscalls.
+-func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) bool {
+-	return crypto.IsValidSignature(plaintext, signer, signature)
++func (sys syscalls) VerifySignature(signature specscrypto.Signature, signer address.Address, plaintext []byte) error {
++	return crypto.ValidateSignature(plaintext, signer, signature)
+ }
+ 
+ // HashBlake2b implements Syscalls.",All changes to signature code stem from here. The syscalls interfaces expects VerifySignature to return an error. I performed the change here and bubbled it up through the rest of the code - mostly mechanical.,Why is this change needed?
+9382,"@@ -77,15 +77,12 @@ public final class InMemoryStorage extends StorageComponent implements SpanStore
+     int maxSpanCount = 500000;
+     List<String> autocompleteKeys = Collections.emptyList();
+ 
+-    /** {@inheritDoc} */
+-    @Override
+-    public Builder strictTraceId(boolean strictTraceId) {
++    @Override public Builder strictTraceId(boolean strictTraceId) {
+       this.strictTraceId = strictTraceId;
+       return this;
+     }
+ 
+-    @Override
+-    public Builder searchEnabled(boolean searchEnabled) {
++    @Override public Builder searchEnabled(boolean searchEnabled) {
+       this.searchEnabled = searchEnabled;
+       return this;
+     }","This strategy seems good. Just wondering do you think this is a good time to move stuff out of core? For example, I guess storage, since it's for use by server and not client, doesn't need to be Java 6?",Why do we need this change?
+9383,"@@ -283,7 +283,8 @@ class Reader implements DataSourceReader, SupportsScanColumnarBatch, SupportsPus
+       return new Stats(0L, 0L);
+     }
+ 
+-    if (filterExpressions == null || filterExpressions == Expressions.alwaysTrue()) {
++    // estimate stats using snapshot summary only for partitioned tables (metadata tables are unpartitioned)
++    if (table.spec().fields().size() > 0 && filterExpression() == Expressions.alwaysTrue()) {
+       long totalRecords = PropertyUtil.propertyAsLong(table.currentSnapshot().summary(),
+           SnapshotSummary.TOTAL_RECORDS_PROP, Long.MAX_VALUE);
+       return new Stats(SparkSchemaUtil.estimateSize(lazyType(), totalRecords), totalRecords);",We had a wrong predicate before: we compared a list to an expression.,nit: `if (table.spec().fields().size() > 0 && filterE
+9384,"@@ -21,6 +21,13 @@ func Test_acl_decode(t *testing.T) {
+ 			},
+ 			want: ""user::rw-\nuser:0:rwx\nuser:65534:rwx\ngroup::rwx\nmask::rwx\nother::r--\n"",
+ 		},
++		{
++			name: ""decode group"",
++			args: args{
++				xattr: []byte{2, 0, 0, 0, 8, 0, 1, 0, 254, 255, 0, 0},
++			},
++			want: ""group:65534:--x\n"",
++		},
+ 		{
+ 			name: ""decode fail"",
+ 			args: args{","Name copy-pasted from above. ""empty""?","I'm not sure what this test is testing, but it seems to be testing the wrong thing."
+9385,"@@ -98,7 +98,7 @@ class Bottle2neck(_Bottleneck):
+         self.stage_type = stage_type
+         self.scales = scales
+         self.width = width
+-        delattr(self, 'conv2')
++        # delattr(self, 'conv2')
+         delattr(self, self.norm2_name)
+ 
+     def forward(self, x):",May I ask why change this?,why do we need this?
+9386,"@@ -23,15 +23,7 @@ namespace Datadog.Trace.Agent.MessagePack
+                 len++;
+             }
+ 
+-            if (value.Tags != null)
+-            {
+-                len++;
+-            }
+-
+-            if (value.Metrics != null)
+-            {
+-                len++;
+-            }
++            len += 2; // Tags and metrics
+ 
+             int originalOffset = offset;
+ ","Does this mean we now always include the dictionaries even if they're empty? If so, we should make sure that this doesn't break the Agent (even older versions). It's possible that it doesn't handle empty dictionaries well.",Why is this change needed?
+9387,"@@ -29,6 +29,9 @@ namespace Nethermind.Blockchain
+         [ConfigItem(Description = ""If set to 'true' then the Fast Sync (eth/63) synchronization algorithm will be used."", DefaultValue = ""false"")]
+         bool FastSync { get; set; }
+         
++        [ConfigItem(Description = ""Relevant only if 'FastSync' is 'true'. If set to value, then it will set a minimum height threshold limit up to witch Full Sync will stay on when chain will be behind network."", DefaultValue = ""null"")]
++        long? FastSyncCatchUpHeightDelta { get; set; }
++        
+         [ConfigItem(Description = ""If set to 'true' then in the Fast Sync mode blocks will be first downloaded from the provided PivotNumber downwards. This allows for parallelization of requests with many sync peers and with no need to worry about syncing a valid branch (syncing downwards to 0). You need to enter the pivot block number, hash and total difficulty from a trusted source (you can use etherscan and confirm with other sources if you wan to change it)."", DefaultValue = ""false"")]
+         bool FastBlocks { get; set; }
+         ",The description and name is unclear. Typo in 'which'.,"`Relevant only if FastSync is 'true'. If set to value, then it will set a minimum h"
+9388,"@@ -43,7 +43,12 @@ module Selenium
+       def text
+         @bridge.getAlertText
+       end
++      
++      def authenticate(username, password)
++        @bridge.setAuthentication username: username, password: password
++        accept
++      end
+ 
+     end # Alert
+   end # WebDriver
+-end # Selenium
++end # Selenium",Files should have an extra line at the end of them.,Extra empty line detected at class body end.
+9389,"@@ -74,6 +74,12 @@ proc_num_simd_saved(void)
+     return num_simd_saved;
+ }
+ 
++void
++proc_set_num_simd_saved(int num)
++{
++    num_simd_saved = num;
++}
++
+ DR_API
+ int
+ proc_num_simd_registers(void)","> i#1312 AVX-512 support: Add code cache to/from context switching. s|to/from|| (redundant and mildly confusing (called ""enter"" and ""return"" in code)).",(style) code indent should use tabs where po
+9390,"@@ -521,10 +521,10 @@ void dag_to_cyto(struct dag *d, int condense_display, int change_size)
+ 	fprintf(cytograph, ""\t<att name = \""layoutAlgorithm\"" value = \""Grid Layout\"" type = \""string\"" cy:hidden = \""1\""/>\n"");
+ 
+ 	if(change_size) {
+-		hash_table_firstkey(d->completed_files);
+-		while(hash_table_nextkey(d->completed_files, &label, (void **) &name)) {
+-			stat(label, &st);
+-			average += ((double) st.st_size) / ((double) hash_table_size(d->completed_files));
++		hash_table_firstkey(d->files);
++		while(hash_table_nextkey(d->files, &name, (void **) &f) && dag_file_exists(f)) {
++			stat(name, &st);
++			average += ((double) st.st_size) / ((double) d->completed_files);
+ 		}
+ 	}
+ ","This stat may fail, right? I think dag_file_exists does not actually check the file is there.",I don't think you need the `&& dag_file_exis
+9391,"@@ -16,7 +16,11 @@ describe('Options Validation', function() {
+     });
+ 
+     const testObject = { a: 1 };
+-    const validatedObject = objectValidator(testObject, { validationLevel: testValidationLevel });
++    const validatedObject = objectValidator(
++      testObject,
++      {},
++      { validationLevel: testValidationLevel }
++    );
+ 
+     expect(validatedObject).to.deep.equal({ a: 1 });
+     expect(validatedObject).to.be.frozen;","I think we can make a safe assumption that if only two values are passed in then you have `(optionsToValidate, optionsForValidation)`, if its three then you have `(optionsToValidate, overrideOptions, optionsForValidation)`",Why is this change needed?
+9392,"@@ -141,12 +141,14 @@ func runExperimentalBeamPipeline(ctx context.Context) error {
+ 	entries := beamio.ReadEntries(s, *entriesFile)
+ 	k := pipeline.FromEntries(s, entries)
+ 	shards := 8 // TODO(schroederc): better determine number of shards
++	edgeSets, edgePages := k.Edges()
+ 	xrefSets, xrefPages := k.CrossReferences()
+ 	beamio.WriteLevelDB(s, *tablePath, shards,
+ 		k.CorpusRoots(),
+ 		k.Directories(),
+ 		k.Decorations(),
+ 		xrefSets, xrefPages,
++		edgeSets, edgePages,
+ 	)
+ 	return beamx.Run(ctx, p)
+ }","If there are more items to add to what's being written out here, please add a TODO.",nit: `edges` -> `edges`
+9393,"@@ -106,8 +106,12 @@ class SuperSocket(six.with_metaclass(_SuperSocket_metaclass)):
+                         pkt = pkt[:12] + tag + pkt[12:]
+                 elif cmsg_lvl == socket.SOL_SOCKET and \
+                         cmsg_type == SO_TIMESTAMPNS:
+-                    tmp = struct.unpack(""iiii"", cmsg_data)
+-                    timestamp = tmp[0] + tmp[2] * 1e-9
++                    length = len(cmsg_data)
++                    if length == 16:  # __kernel_timespec
++                        tmp = struct.unpack(""ll"", cmsg_data)
++                    elif length == 8:  # timespec
++                        tmp = struct.unpack(""ii"", cmsg_data)
++                    timestamp = tmp[0] + tmp[1] * 1e-9
+             return pkt, sa_ll, timestamp
+ 
+     def recv_raw(self, x=MTU):",Can you add an `else:` case to handle an invalid length? That will prevent weird errors.,I'm not sure if this is
+9394,"@@ -9,14 +9,10 @@ public class ASTAttribute extends AbstractJspNode {
+ 
+     private String name;
+ 
+-    public ASTAttribute(int id) {
++    ASTAttribute(int id) {
+         super(id);
+     }
+ 
+-    public ASTAttribute(JspParser p, int id) {
+-        super(p, id);
+-    }
+-
+     /**
+      * @return Returns the name.
+      */",* We need to deprecate/internalize first on master. * We should directly make the AST node final now * The setter `setName()` can be package-private.,Why was this constructo
+9395,"@@ -137,12 +137,6 @@ public class InitCodeTransformer {
+       // Remove the request object for flattened method
+       orderedItems.remove(orderedItems.size() - 1);
+     }
+-    for (InitCodeNode param :
+-        sampleFuncParams(
+-            root, initCodeContext.sampleArgStrings(), initCodeContext.sampleParamConfigMap())) {
+-      List<InitCodeNode> paramInits = param.listInInitializationOrder();
+-      orderedItems.removeAll(paramInits);
+-    }
+     return orderedItems;
+   }
+ ",Where did this functionality move to?,Why is this removed?
+9396,"@@ -68,6 +68,19 @@ public class TiDBJDBCClient implements AutoCloseable {
+     }
+   }
+ 
++  // SPLIT TABLE table_name [INDEX index_name] BETWEEN (lower_value) AND (upper_value) REGIONS
++  // region_num
++  public boolean splitTableRegion(
++      String dbName, String tblName, long minVal, long maxVal, long regionNum) throws SQLException {
++    try (Statement tidbStmt = connection.createStatement()) {
++      String sql =
++          String.format(
++              ""split table %s.%s between (%d) and (%d) regions %d"",
++              dbName, tblName, minVal, maxVal, regionNum);
++      return tidbStmt.execute(sql);
++    }
++  }
++
+   public boolean isClosed() throws SQLException {
+     return connection.isClosed();
+   }",maybe should firstly check whether current tidb support `split table region`?,Why not use `String.format` here?
+9397,"@@ -27,7 +27,8 @@ import { Fragment } from '@wordpress/element';
+ import Data from 'googlesitekit-data';
+ import Logo from './Logo';
+ import UserMenu from './UserMenu';
+-import ErrorNotification from '../components/notifications/error-notification';
++import LegacyErrorNotification from './legacy-notifications/error-notification';
++import ErrorNotification from './notifications/ErrorNotifications';
+ import { STORE_NAME as CORE_USER } from '../googlesitekit/datastore/user/constants';
+ const { useSelect } = Data;
+ ",Please use the same (plural) name for the new component since it renders multiple notifications.,Why do we need this file?
+9398,"@@ -466,6 +466,7 @@ func (cs *CatchpointCatchupService) processStageBlocksDownload() (err error) {
+ 				}
+ 				if attemptsCount <= uint64(cs.config.CatchupBlockDownloadRetryAttempts) {
+ 					// try again.
++					cs.log.Infof(""Failed to download block %d. %v"", topBlock.Round()-basics.Round(blocksFetched), err)
+ 					continue
+ 				}
+ 				return cs.abort(fmt.Errorf(""processStageBlocksDownload failed after multiple blocks download attempts""))",Perhaps show attempt x of y in message ie: Failed to download block %d (attempt %d of %d). %v,I think we should log the error h
+9399,"@@ -94,8 +94,7 @@ public class PrivateTransactionHandler {
+     }
+   }
+ 
+-  public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction)
+-      throws Exception {
++  public String getPrivacyGroup(final String key, final PrivateTransaction privateTransaction) {
+     if (privateTransaction.getPrivacyGroupId().isPresent()) {
+       return BytesValues.asBase64String(privateTransaction.getPrivacyGroupId().get());
+     }",why did you took `Exception` out? Is this method only throwing runtime exceptions?,Why is this change needed?
+9400,"@@ -1,9 +1,7 @@
+ # coding: utf-8
+ """"""Comparison of `binary` and `xentropy` objectives.
+-
+ BLUF: The `xentropy` objective does logistic regression and generalizes
+ to the case where labels are probabilistic (i.e. numbers between 0 and 1).
+-
+ Details: Both `binary` and `xentropy` minimize the log loss and use
+ `boost_from_average = TRUE` by default. Possibly the only difference
+ between them with default settings is that `binary` may achieve a slight",please revert all of these unrelated whitespace changes,Why did you remove this?
+9401,"@@ -0,0 +1,15 @@
++package com.fsck.k9.mail;
++
++/**
++ * Enumeration of the different possible encryption protocol that can be used.
++ */
++public enum EncryptionType {
++
++    NONE,
++
++    INLINE,
++
++    PGP_MIME,
++
++    S_MIME
++}",PGP_INLINE is clearer IMHO,I don't think we need th
+9402,"@@ -16,6 +16,8 @@ import (
+ 	""github.com/pkg/errors""
+ 	""github.com/stretchr/testify/require""
+ 
++	""context""
++
+ 	""github.com/iotexproject/iotex-core/blockchain""
+ 	""github.com/iotexproject/iotex-core/blockchain/action""
+ 	""github.com/iotexproject/iotex-core/config""",Please group imports,"""github.com/stretchr/tes"
+9403,"@@ -102,7 +102,7 @@ public class TestHiveMetastore {
+         .transportFactory(new TTransportFactory())
+         .protocolFactory(new TBinaryProtocol.Factory())
+         .minWorkerThreads(3)
+-        .maxWorkerThreads(5);
++        .maxWorkerThreads(10);
+ 
+     return new TThreadPoolServer(args);
+   }",Would it make sense to expose this as a config option in `TestHiveMetastore`? A small number of worker threads helped us to catch a few connection leaks early on.,Why did you change this?
+9404,"@@ -10,9 +10,12 @@ void im2col_cpu(const Dtype* data_im, const int channels,
+     const int height, const int width, const int kernel_h, const int kernel_w,
+     const int pad_h, const int pad_w,
+     const int stride_h, const int stride_w,
++    const int dilation_h, const int dilation_w,
+     Dtype* data_col) {
+-  const int height_col = (height + 2 * pad_h - kernel_h) / stride_h + 1;
+-  const int width_col = (width + 2 * pad_w - kernel_w) / stride_w + 1;
++  const int height_col = (height + 2 * pad_h -
++      (dilation_h * (kernel_h - 1)  + 1)) / stride_h + 1;
++  const int width_col = (width + 2 * pad_w -
++      (dilation_w * (kernel_w - 1)  + 1)) / stride_w + 1;
+   const int channels_col = channels * kernel_h * kernel_w;
+   for (int c_col = 0; c_col < channels_col; ++c_col) {
+     int w_offset = c_col % kernel_w;",Let's fix the extra spaces above.,Why do you need to multiply by `(kernel_h - 1)`?
+9405,"@@ -27,7 +27,7 @@ public interface SearchContext {
+    * @return A list of all {@link WebElement}s, or an empty list if nothing matches
+    * @see org.openqa.selenium.By
+    */
+-  List<WebElement> findElements(By by);
++  <T extends WebElement> List<T> findElements(By by);
+ 
+ 
+   /**",should a similar change be done for findElement?,Why do we need this change?
+9406,"@@ -15,11 +15,17 @@ import (
+ 
+ var _ keystore.Service = (*Service)(nil)
+ 
++// Service is the memory-based keystore.Service implementation.
++//
++// Keys are stored in the in-memory map, where the key is the name of the
++// private key, and value is structure where actual private key and password are
++// stored.
+ type Service struct {
+ 	m  map[string]key
+ 	mu sync.Mutex
+ }
+ 
++// New creates new memory-based keystore.Service implementation.
+ func New() *Service {
+ 	return &Service{
+ 		m: make(map[string]key),","// Keys are stored in an in-memory map, where the key is the name of the // private key, and the value is the structure where the actual private key and the password are // stored.",Why is this a pointer?
+9407,"@@ -59,6 +59,9 @@ var _ = duck.VerifyType(&PullSubscription{}, &duckv1.Conditions{})
+ 
+ // PullSubscriptionSpec defines the desired state of the PullSubscription.
+ type PullSubscriptionSpec struct {
++	// This brings in CloudEventOverrides and Sink.
++	duckv1.SourceSpec
++
+ 	// Secret is the credential to use to create and poll the PullSubscription
+ 	// Subscription. The value of the secret entry must be a service account
+ 	// key in the JSON format (see https://cloud.google.com/iam/docs/creating-managing-service-account-keys).",I think this needs a json inline tag here,Why do we need this?
+9408,"@@ -510,7 +510,7 @@ string t_erl_generator::render_member_type(t_field * field) {
+   } else if (type->is_struct() || type->is_xception()) {
+     return ""#"" + uncapitalize(type->get_name()) + ""{}"";
+   } else if (type->is_map()) {
+-    return ""dict()"";
++    return ""dict:dict()"";
+   } else if (type->is_set()) {
+     return ""set()"";
+   } else if (type->is_list()) {","Hi @cjimison good point but doesn't this break the compatibility with Erlang/OTP prior to 17.0? I think this could be done over an conditional macro defined in the rebar.config: `{erl_opts, [ {platform_define, ""^R"", pre17} ]}` and some additions with `-ifdef(pre17). ... -else. ... -endif.`",Why did you change this?
+9409,"@@ -210,7 +210,7 @@ func (pl *List) removeFromUnavailablePeers(p peer.Peer) {
+ 
+ // Choose selects the next available peer in the round robin
+ func (pl *List) Choose(ctx context.Context, req *transport.Request) (peer.Peer, func(error), error) {
+-	if !pl.IsRunning() {
++	if err := pl.once.WaitForStart(ctx); err != nil {
+ 		return nil, nil, peer.ErrPeerListNotStarted(""RoundRobinList"")
+ 	}
+ ",should we change/wrap the error?,why do we need to wait f
+9410,"@@ -109,12 +109,12 @@ final class DeFramer extends ByteToMessageDecoder {
+         try {
+           peerInfo = HelloMessage.readFrom(message).getPeerInfo();
+         } catch (final RLPException e) {
+-          LOG.debug(""Received invalid HELLO message"", e);
++          LOG.warn(""Received invalid HELLO message, set log level to TRACE for message body"", e);
+           connectFuture.completeExceptionally(e);
+           ctx.close();
+           return;
+         }
+-        LOG.debug(""Received HELLO message: {}"", peerInfo);
++        LOG.trace(""Received HELLO message: {}"", peerInfo);
+         if (peerInfo.getVersion() >= 5) {
+           LOG.trace(""Enable compression for p2pVersion: {}"", peerInfo.getVersion());
+           framer.enableCompression();",Are we sure that passing this log in warning does not risk spamming the logs of a node running on the mainnet or on ropsten etc ? Do we often receive invalid messages of this type ?,Why is this change neede
+9411,"@@ -397,10 +397,7 @@ class Parser
+     # check for option to find list item text only
+     # if skipped a line, assume a list continuation was
+     # used and block content is acceptable
+-    if (text_only = options[:text]) && skipped > 0
+-      options.delete(:text)
+-      text_only = false
+-    end
++    text_only = is_text_only(options, skipped)
+     
+     parse_metadata = options.fetch(:parse_metadata, true)
+     #parse_sections = options.fetch(:parse_sections, false)",I'd like to avoid a method call here atm since this is an extremely hot line in the code.,Line is too long. [81/80
+9412,"@@ -421,8 +421,7 @@ def parse_input(vds):
+ 
+ def parse_witness(vds):
+     n = vds.read_compact_size()
+-    for i in range(n):
+-        x = vds.read_bytes(vds.read_compact_size())
++    return list(vds.read_bytes(vds.read_compact_size()).encode('hex') for i in xrange(n))
+ 
+ def parse_output(vds, i):
+     d = {}",Is this a bugfix?,`xrange` is not needed here.
+9413,"@@ -35,7 +35,6 @@ namespace Microsoft.DotNet.Build.Tasks
+                 GlobalPackagesFolder = PackagesDir,
+ 
+                 Sources = new List<string>(),
+-                FallbackSources = new List<string>(),
+                 CacheContext = new SourceCacheContext(),
+                 RequestProviders = new List<IRestoreRequestProvider>
+                 {",Is this a relevant change?,Why was this removed?
+9414,"@@ -62,9 +62,9 @@ public final class JUnit5RuleUsage extends BugChecker implements BugChecker.Clas
+     }
+ 
+     static Matcher<ClassTree> hasVariable(Matcher<VariableTree> matcher) {
+-        return (classTree, state) -> classTree.getMembers().stream()
+-                .filter(tree -> tree instanceof VariableTree)
+-                .anyMatch(tree -> matcher.matches((VariableTree) tree, state));
++        return (classTree, state) ->
++                classTree.getMembers().stream().filter(tree -> tree instanceof VariableTree).anyMatch(tree ->
++                        matcher.matches((VariableTree) tree, state));
+     }
+ 
+     static Matcher<VariableTree> hasAnnotationOnVariable(String annotation) {",@dansanduleac what do you think of this one? dots were aligned and no longer are  ,Please don't change unrelate
+9415,"@@ -738,10 +738,6 @@ function deleteAllAppData(appId, fromAppDelete, params, app) {
+             }, deleteEvents);
+         }
+     });
+-
+-    if (fromAppDelete) {
+-        common.db.collection('graph_notes').remove({'_id': common.db.ObjectID(appId)}, function() {});
+-    }
+ }
+ 
+ /**",Why we dont delete app specific notes when app is deleted?,Why was this removed?
+9416,"@@ -113,9 +113,17 @@ public class ConfigBuilderPlugin extends PluginBase {
+         pluginList = MainApp.getPluginsList();
+         upgradeSettings();
+         loadSettings();
++        setAlwaysEnabledPluginsEnabled();
+         MainApp.bus().post(new EventAppInitialized());
+     }
+ 
++    private void setAlwaysEnabledPluginsEnabled() {
++        for (PluginBase plugin : pluginList) {
++            if (plugin.pluginDescription.alwaysEnabled) plugin.setPluginEnabled(plugin.getType(), true);
++        }
++        storeSettings(""setAlwaysEnabledPluginsEnabled"");
++    }
++
+     public void storeSettings(String from) {
+         if (pluginList != null) {
+             if (Config.logPrefsChange)","The _OverviewPlugin_ is forcefully enabled without the option to disable it, using _PluginDescription.alwaysEnabled_. That should also work for this plugin?",Why do we need this method?
+9417,"@@ -220,6 +220,8 @@ public class SearchFields {
+      * i.e. ""Unpublished"", ""Draft"" (multivalued)
+      */
+     public static final String PUBLICATION_STATUS = ""publicationStatus"";
++    
++    public static final String EXTERNAL_STATUS = ""externalStatus"";
+     /**
+      * @todo reconcile different with Solr schema.xml where type is Long rather
+      * than String.",Can you facet on this new externalStatus Solr field?,I don't think we need this 
+9418,"@@ -132,11 +132,14 @@ module Blacklight
+     end
+ 
+     def filters
+-      @filters ||= blacklight_config.facet_fields.each_value.map do |value|
+-        f = filter(value)
+-
+-        f if f.any?
+-      end.compact
++      @filters ||= blacklight_config.facet_fields.each_value.reduce([]) do |acc, value|
++        if value.pivot
++          acc + value.pivot.map { |v| value.class.new(key: v) }
++                     .map { |f| filter(f) }.select(&:any?)
++        else
++          acc + Array(filter(value)).select(&:any?)
++        end
++      end
+     end
+ 
+     def filter(field_key_or_field)","I wonder if it would it make sense to push the pivot facet handling down into `FilterField` (or maybe a subclass, `PivotFilterField`?)?",`Array(filter(value)).selec
+9419,"@@ -47,7 +47,12 @@ Puppet::Functions.create_function(:run_plan, Puppet::Functions::InternalFunction
+       end
+ 
+       begin
+-        result = func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true)
++        func.class.dispatcher.dispatchers[0].call_by_name_with_scope(scope, params, true)
++        # If the plan returns using a return statement then we never get here.
++        # We only get here if the plan finishes without executing any return
++        # statement and since we don't want to leak any implicit return value
++        # from the plan we simply set the result to nil here.
++        result = nil
+       rescue Puppet::PreformattedError => err
+         if named_args['_catch_errors'] && err.cause.is_a?(Bolt::Error)
+           result = err.cause.to_puppet_error",Ah I see what you were saying about making it harder to validate types. We'll have to catch the return for that.,I think this should be `res
+9420,"@@ -86,6 +86,7 @@ public abstract class BaseActivity extends AppCompatActivity implements BottomNa
+                         .setTarget(nav_cam)
+                         .setDismissText(getResources().getString(R.string.ok_button))
+                         .setContentText(getResources().getString(R.string.camera_button))
++                        .hideOnTouchOutside()
+                         .build()
+         );
+ ",Try using using `.setDismissOnTouch(true)` instead,Why is this needed?
+9421,"@@ -122,6 +122,12 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+                 }
+                 catch (Exception ex)
+                 {
++                    if (scope != null)
++                    {
++                        // some fields aren't set till after execution, so populate anything missing
++                        UpdateSpan(controllerContext, scope.Span);
++                    }
++
+                     scope?.Span.SetException(ex);
+                     throw;
+                 }","Zach, is `UpdateSpan` of concern too? I see that it is called from `ExecuteAsyncInternal`.",Why do we need this
+9422,"@@ -26,7 +26,9 @@ import org.apache.iceberg.types.Type;
+ import org.apache.iceberg.types.Types;
+ import org.apache.orc.TypeDescription;
+ 
+-public class TypeConversion {
++public final class TypeConversion {
++
++  private TypeConversion() {}
+ 
+   /**
+    * Convert a given Iceberg schema to ORC.",Nit: its scope can be reduced to package default,Why is this needed?
+9423,"@@ -15,5 +15,7 @@ namespace Microsoft.AspNetCore.Protocols.Features
+         PipeScheduler InputWriterScheduler { get; }
+ 
+         PipeScheduler OutputReaderScheduler { get; }
++
++        PipeScheduler ApplicationScheduler { get; set; }
+     }
+ }",Why is this get;set;?,Why do we need this
+9424,"@@ -77,6 +77,9 @@ bool StatefulReader::matched_writer_add(RemoteWriterAttributes& wdata)
+ 
+     getRTPSParticipant()->createSenderResources(wdata.endpoint.remoteLocatorList, false);
+ 
++
++    wdata.endpoint.unicastLocatorList =
++        mp_RTPSParticipant->network_factory().ShrinkLocatorLists({wdata.endpoint.unicastLocatorList});
+     WriterProxy* wp = new WriterProxy(wdata, this);
+ 
+     wp->mp_initialAcknack->restart_timer();",Should we also create sender resources for unicast locators? Should we make a similar change on StatelessReader?,Why do we need this?
+9425,"@@ -130,7 +130,7 @@ namespace Datadog.Trace.RuntimeMetrics
+                 // Catching error UnauthorizedAccessException: Access to the registry key 'Global' is denied.
+                 // The 'Global' part seems consistent across localizations
+ 
+-                Log.Error(ex, ""The process does not have sufficient permissions to read performance counters. Please refer to https://docs.datadoghq.com/tracing/runtime_metrics/dotnet/#additional-permissions-for-iis to learn how to grant those permissions."");
++                Log.Error(ex, ""The process does not have sufficient permissions to read performance counters. Please refer to https://dtdg.co/net-runtime-metrics to learn how to grant those permissions."");
+                 throw;
+             }
+             catch (Exception ex)",Can we use `dotnet` instead of `net`?,// The 'Global' part
+9426,"@@ -372,6 +372,13 @@ namespace Datadog.Trace
+             return StartSpan(operationName, tags: null, parent, serviceName, startTime, ignoreActiveScope, spanId: null);
+         }
+ 
++        /// <summary>
++        /// Forces the tracer to immediately flush pending traces and send them to the agent.
++        /// To be called when the appdomain or the process is about to be killed in a non-graceful way.
++        /// </summary>
++        /// <returns>Task used to track the async flush operation</returns>
++        public Task ForceFlush() => FlushAsync();
++
+         /// <summary>
+         /// Writes the specified <see cref=""Span""/> collection to the agent writer.
+         /// </summary>",Should this be `ForceFlushAsync`? Given we have the `async` suffix elsewhere.,I'm not sure if this
+9427,"@@ -48,8 +48,8 @@ class TestJMeterExecutor(BZTestCase):
+         self.obj = get_jmeter()
+ 
+     def tearDown(self):
+-        if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx):
+-            os.remove(self.obj.modified_jmx)
++        # if self.obj.modified_jmx and os.path.exists(self.obj.modified_jmx):
++        #     os.remove(self.obj.modified_jmx)
+         super(TestJMeterExecutor, self).tearDown()
+ 
+     def configure(self, config):",Is this change intentional?,Why is this removed?
+9428,"@@ -55,10 +55,7 @@ namespace Microsoft.CodeAnalysis.Sarif
+ 
+             if (nativeOffset != -1)
+             {
+-                stackFrame.Properties = new Dictionary<string, string>
+-                {
+-                    { ""NativeOffset"", nativeOffset.ToString(CultureInfo.InvariantCulture) }
+-                };
++                stackFrame.SetProperty(""NativeOffset"", nativeOffset.ToString(CultureInfo.InvariantCulture));
+             }
+ 
+             return stackFrame;",This could be an integer property if we supported explicitly setting non-string-valued properties.,Why is this change needed?
+9429,"@@ -14,8 +14,7 @@ use Symfony\Component\Security\Csrf\CsrfTokenManagerInterface;
+ class RouteCsrfProtector implements EventSubscriberInterface
+ {
+     public const CSRF_TOKEN_REQUEST_PARAMETER = 'routeCsrfToken';
+-    /** @access protected */
+-    const CSRF_TOKEN_ID_PREFIX = 'route_';
++    public const CSRF_TOKEN_ID_PREFIX = 'route_';
+ 
+     /**
+      * @var \Doctrine\Common\Annotations\Reader",this is not consistent with the previous annotation - is it because of the usage in `Admin\Content\Category\list.html.twig` twig template? Should not it be at least mentioned in the commit message? :slightly_smiling_face:,Why removing the @access m
+9430,"@@ -149,6 +149,7 @@ func ReadSecretFromStdin() (string, error) {
+ 			case <-routineTerminate:
+ 				return
+ 			default:
++				return
+ 			}
+ 		}
+ 	}()",why add `return` here?,Why is this needed?
+9431,"@@ -82,7 +82,9 @@ namespace Nethermind.Network.Test.Discovery
+             Assert.AreEqual(message.DestinationAddress, deserializedMessage.DestinationAddress);
+             Assert.AreEqual(message.SourceAddress, deserializedMessage.SourceAddress);
+             Assert.AreEqual(message.Version, deserializedMessage.Version);
+-            Assert.IsNotNull(deserializedMessage.Mdc);
++            
++            // check MDC correctness 
++            Assert.IsNotNull(Bytes.FromHexString(""0xf8c61953f3b94a91aefe611e61dd74fe26aa5c969d9f29b7e063e6169171a772""));
+         }
+ 
+         [Test]",put this hash in variable,Why did you change this?
+9432,"@@ -5,11 +5,8 @@
+ package libkbfs
+ 
+ import (
+-	""bytes""
+-	""errors""
+ 	""testing""
+ 
+-	""github.com/keybase/client/go/libkb""
+ 	""github.com/keybase/client/go/logger""
+ 	""github.com/keybase/client/go/protocol/keybase1""
+ 	""github.com/keybase/go-framed-msgpack-rpc/rpc""",Why not use `kbfsblock.ZeroRefNonce`?,Why are these removed?
+9433,"@@ -26,7 +26,7 @@ class EarlyStopException(Exception):
+ 
+ # Callback environment used by callbacks
+ CallbackEnv = collections.namedtuple(
+-    ""LightGBMCallbackEnv"",
++    ""CallbackEnv"",
+     [""model"",
+      ""params"",
+      ""iteration"",",what mypy warning does this address? I'm confused by this change.,I think this should be
+9434,"@@ -3751,6 +3751,18 @@ void Player::addAttacked(const Player* attacked)
+ 	attackedSet.insert(attacked->guid);
+ }
+ 
++void Player::removeAttacked(const Player* attacked)
++{
++	if (!attacked || attacked == this) {
++		return;
++	}
++
++	auto it = attackedSet.find(attacked->guid);
++	if (it != attackedSet.end()) {
++		attackedSet.erase(it);
++	}
++}
++
+ void Player::clearAttacked()
+ {
+ 	attackedSet.clear();",Note that `hasAttacked` that is called before this function already performs this check. You probably don't need to check `hasAttacked` then.,You can use `std::remo
+9435,"@@ -0,0 +1,10 @@
++// This object is imported into the documentation site. An example for the documentation site should be part of the pull request for the component. The object key is the kabob case of the ""URL folder"". In the case of `http://localhost:8080/components/app-launcher/`, `app-launcher` is the `key`. The folder name is created by `components.component` value in `package.json`. The following uses webpack's raw-loader plugin to get ""text files"" that will be eval()'d by CodeMirror within the documentation site on page load.
++
++/* eslint-env node */
++/* eslint-disable global-require */
++
++const siteStories = [
++	require('raw-loader!@salesforce/design-system-react/components/carousel/__examples__/default.jsx'),
++];
++
++module.exports = siteStories;","Unfortunately, the site example only has access to imports from `components/index.js` that means that you can't import the items file `carousel-items.js`. You can import that file in all the other storybook files though.",I'm not sure if this i
+9436,"@@ -79,7 +79,7 @@ setup(
+             'locale/*/LC_MESSAGES/electrum.mo',
+         ]
+     },
+-    scripts=['electrum'],
++    scripts=['electrum', 'privkey2electrum'],
+     data_files=data_files,
+     description=""Lightweight Bitcoin Wallet"",
+     author=""Thomas Voegtlin"",",Leave this out and move the script to the scripts folder.,Why do we need this script?
+9437,"@@ -1656,7 +1656,7 @@ class TargetLocator {
+   window(nameOrHandle) {
+     return this.driver_.schedule(
+         new command.Command(command.Name.SWITCH_TO_WINDOW).
+-            setParameter('name', nameOrHandle),
++            setParameter('handle', nameOrHandle),
+         'WebDriver.switchTo().window(' + nameOrHandle + ')');
+   }
+ ","This should only be sent if the driver is speaking to a W3C conformant remote, so we need an if-condition check like we have in the Python bindings.",I think this should be `nam
+9438,"@@ -0,0 +1,17 @@
++using System.Collections.Generic;
++using System.IO.Pipelines;
++using System.Threading.Tasks;
++using Microsoft.AspNetCore.Http.Features;
++
++namespace Microsoft.AspNetCore.Connections
++{
++    public interface IConnection
++    {
++        IDuplexPipe Transport { get; }
++        IFeatureCollection Features { get; }
++
++        Task StartAsync();
++        Task StartAsync(TransferFormat transferFormat);
++        Task DisposeAsync();
++    }
++}",TransferFormat.Text in general purpose connection interface? :/,Why do we need this interfa
+9439,"@@ -36,10 +36,17 @@ module Selenium
+       SOCKET_LOCK_TIMEOUT = 45
+       STOP_TIMEOUT        = 20
+ 
++      @executable = nil
++      @missing = ''
++
++      class << self
++        attr_accessor :executable, :missing_text
++      end
++
+       attr_accessor :host
+ 
+       def initialize(executable_path, port, *extra_args)
+-        @executable_path = executable_path
++        @executable_path = binary_path(executable_path)
+         @host            = Platform.localhost
+         @port            = Integer(port)
+         @extra_args      = extra_args",Is this `@missing_text` ?,Why is this needed?
+9440,"@@ -485,6 +485,12 @@ func (c *client) processRouteInfo(info *Info) {
+ 		if !s.getOpts().Cluster.NoAdvertise {
+ 			s.addClientConnectURLsAndSendINFOToClients(info.ClientConnectURLs)
+ 		}
++
++		// This will allow us to determine the initial RTT without having to
++		// wait for first timer based PING.
++		c.mu.Lock()
++		c.sendPing()
++		c.mu.Unlock()
+ 	} else {
+ 		c.Debugf(""Detected duplicate remote route %q"", info.ID)
+ 		c.closeConnection(DuplicateRoute)",This work for both sides?,Why do we need a lock here?
+9441,"@@ -32,9 +32,12 @@ import {
+ 	isDataZeroSearchConsole,
+ } from '../dashboard/util';
+ 
+-const { __, sprintf } = wp.i18n;
+-const { map } = lodash;
+-const { Component } = wp.element;
++/**
++ * WordPress dependencies
++ */
++import { __, sprintf } from '@wordpress/i18n';
++import { map } from 'lodash';
++import { Component } from '@wordpress/element';
+ 
+ class DashboardWidgetPopularKeywordsTable extends Component {
+ 	static renderLayout( component ) {",`lodash` shouldn't be grouped under WordPress dependencies,I don't think we need the `
+9442,"@@ -117,6 +117,13 @@ class ComputeTest(unittest_utils.ForsetiTestCase):
+         with self.assertRaises(expected_exception):
+             list(self.gce_api_client.get_firewall_rules(self.project_id))
+ 
++
++    def test_get_global_operations(self):
++        """"""Test get_global_operations""""""
++        http_mocks.mock_http_response(fake_compute.GLOBAL_OPERATIONS_RESPONSE)
++        results = self.gce_api_client.get_global_operations(
++            self.project_id, operation_id='operation-1234')
++
+     def test_get_quota(self):
+         """"""Test get quota.""""""
+         http_mocks.mock_http_response(fake_compute.GET_PROJECT_RESPONSE)",Include the standard parameterized error tests as well.,nit: you can remove this li
+9443,"@@ -242,6 +242,16 @@ func runWeb(ctx *cli.Context) {
+ 					m.Patch(""/hooks/:id:int"", bind(api.EditHookOption{}), v1.EditRepoHook)
+ 					m.Get(""/raw/*"", middleware.RepoRef(), v1.GetRepoRawFile)
+ 					m.Get(""/archive/*"", v1.GetRepoArchive)
++					m.Post(""/forks"", v1.ForkRepo)
++
++					m.Get(""/commits/:commitId"", middleware.RepoRef(), v1.CommitById)
++					m.Get(""/commits/current"", middleware.RepoRef(), v1.CurrentCommit)
++
++					m.Group(""/releases"", func() {
++						m.Combo("""").Get(v1.ListReleases).
++							Post(bindIgnErr(api.CreateReleaseOption{}), v1.CreateRelease)
++						m.Get(""/:release"", v1.ReleaseByName)
++					}, middleware.RepoRef())
+ 				}, middleware.ApiRepoAssignment(), middleware.ApiReqToken())
+ 			})
+ ",All lowercase in route rule.,"`m.Combo("""").Get(api.ListRe"
+9444,"@@ -61,8 +61,16 @@ export const actions = {
+ 
+ 			const { dispatch } = yield Data.commonActions.getRegistry();
+ 			yield actions.receiveAccounts( response.accounts );
+-			dispatch( STORE_NAME ).receiveProperties( response.properties );
+-			dispatch( STORE_NAME ).receiveProfiles( response.profiles );
++
++			if ( response.properties.length && response.properties[ 0 ] && response.properties[ 0 ].accountId ) {
++				const accountID = response.properties[ 0 ].accountId;
++				dispatch( STORE_NAME ).receiveProperties( response.properties, { accountID } );
++			}
++
++			if ( response.properties.length && response.properties[ 0 ] && response.properties[ 0 ].id ) {
++				const propertyID = response.properties[ 0 ].id;
++				dispatch( STORE_NAME ).receiveProfiles( response.profiles, { propertyID } );
++			}
+ 
+ 			if ( response.matchedProperty ) {
+ 				dispatch( STORE_NAME ).receiveMatchedProperty( response.matchedProperty );","I'd suggest we use `response.profiles[ 0 ].webPropertyId` here instead, to make sure it's based on the profiles retrieved. The value _should_ be the same, but I think it's a bit more accurate like that.",`response.properties[ 0 ]` can be `null`
+9445,"@@ -314,8 +314,8 @@ public class OverviewFragment extends Fragment implements View.OnClickListener,
+             bgGraph.setOnLongClickListener(new View.OnLongClickListener() {
+                 @Override
+                 public boolean onLongClick(View v) {
+-                    rangeToDisplay += 6;
+-                    rangeToDisplay = rangeToDisplay > 24 ? 6 : rangeToDisplay;
++                    rangeToDisplay += 3;
++                    rangeToDisplay = rangeToDisplay > 24 ? 3 : rangeToDisplay;
+                     SP.putInt(R.string.key_rangetodisplay, rangeToDisplay);
+                     updateGUI(""rangeChange"");
+                     return false;","This doesn't change the default of 6h, but will increase the displayed timeframe by 3h for each long press, before wrapping around to 3h. This requires 7 long-presses - quiet a journey ...",Why did you change this?
+9446,"@@ -91,6 +91,7 @@ type nodeChainReader interface {
+ 	GetTipSetStateRoot(tsKey types.SortedCidSet) (cid.Cid, error)
+ 	HeadEvents() *ps.PubSub
+ 	Load(context.Context) error
++	SetHead(context.Context, types.TipSet) error
+ 	Stop()
+ }
+ ",We still need to figure out a way to get rid of this write method. Is this still necessary?,Why do we need this?
+9447,"@@ -265,6 +265,11 @@ class KNNClassifierTest(unittest.TestCase):
+ 
+     self.assertEquals(classifier.getNumPartitionIds(), 3)
+ 
++    # Check that the full set of partition ids is what we expect
++    self.assertItemsEqual(classifier.getPartitionIdPerPattern(),
++                          [433, 213, np.inf, 433, 413])
++    self.assertItemsEqual(classifier.getPartitionIdList(),[433, 413, 213])
++
+     # Remove two rows - all indices shift down
+     self.assertEquals(classifier._removeRows([0,2]), 2)
+     self.assertItemsEqual(classifier.getPatternIndicesWithPartitionId(433),","`assertItemsEqual` compares the sequences after sorting them, is that intended?","nit: space after `,`"
+9448,"@@ -170,8 +170,8 @@ module Selenium
+ 
+           def macosx_path
+             path = ""/Applications/Firefox.app/Contents/MacOS/firefox-bin""
+-            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(path)
+-            path = Platform.find_binary(""firefox-bin"") unless File.exist?(path)
++            path = ""~/Applications/Firefox.app/Contents/MacOS/firefox-bin"" unless File.exist?(File.expand_path(path))
++            path = Platform.find_binary(""firefox-bin"") unless File.exist?(File.expand_path?(path))
+ 
+             path
+           end",I don't think this one needs to be changed since the only previous path is already an absolute one.,"I don't think we need the `File.expand_path?` here, since `File.exist?` already checks for `File.exist?`."
+9449,"@@ -13,8 +13,14 @@ namespace AutoRest.Swagger.Model.Utilities
+ {
+     public static class ValidationUtilities
+     {
+-        private static readonly string XmsPageable = ""x-ms-pageable"";
++        private const string XmsPageable = ""x-ms-pageable"";
+         private static readonly Regex TrackedResRegEx = new Regex(@"".+/Resource$"", RegexOptions.IgnoreCase);
++        private const string AzureHostSignature = ""management.azure.com"";
++
++        // if x-ms-parameterized-host extension is used or if the host is anything of the form management.azure, assume this to be an ARMServiceDefinition
++        // TODO: refine this definition for azure data plain also check x-ms-parameterized-host in detail to ensure this is ARM
++        public static bool IsARMServiceDefinition(ServiceDefinition serviceDefinition) => 
++            serviceDefinition.Extensions.ContainsKey(""x-ms-parameterized-host"") || serviceDefinition.Host?.EqualsIgnoreCase(AzureHostSignature) == true;
+ 
+         public static bool IsTrackedResource(Schema schema, Dictionary<string, Schema> definitions)
+         {",what's the goal of this?,"nit: can we use `string.Equals(serviceDefinition.Host, AzureHostSignature)`?"
+9450,"@@ -49,6 +49,8 @@ type Node struct {
+ 
+ 	// CborStore is a temporary interface for interacting with IPLD objects.
+ 	CborStore *hamt.CborIpldStore
++
++	pool *core.MessagePool
+ }
+ 
+ // Config is a helper to aid in the construction of a filecoin node.",why is this here? We already have a message pool in the node.,Why do we need this?
+9451,"@@ -1107,7 +1107,7 @@ func (s *activityReplicatorSuite) TestSyncActivity_ActivityRunning() {
+ 	var versionHistories *persistence.VersionHistories
+ 	s.mockMutableState.EXPECT().GetVersionHistories().Return(versionHistories).AnyTimes()
+ 	s.mockMutableState.EXPECT().GetReplicationState().Return(&persistence.ReplicationState{}).AnyTimes()
+-	s.mockMutableState.EXPECT().GetWorkflowStateStatus().Return(enumsgenpb.WORKFLOW_EXECUTION_STATE_RUNNING, enumspb.WORKFLOW_EXECUTION_STATUS_UNSPECIFIED).AnyTimes()
++	s.mockMutableState.EXPECT().GetWorkflowStateStatus().Return(enumsgenpb.WORKFLOW_EXECUTION_STATE_RUNNING, enumspb.WORKFLOW_EXECUTION_STATUS_COMPLETED).AnyTimes()
+ 	s.mockNamespaceCache.EXPECT().GetNamespaceByID(namespaceID).Return(
+ 		cache.NewGlobalNamespaceCacheEntryForTest(
+ 			&persistenceblobs.NamespaceInfo{Id: namespaceID, Name: namespace},",Another mess after all renames and enum conversions. Doesn't break anything though.,Why do we need this change?
+9452,"@@ -17,7 +17,8 @@ class PluginSetup(unittest.TestCase):
+     def test_a_statsd_timer_is_used_for_history_if_configured(self):
+         settings = {
+             ""statsd_url"": ""udp://127.0.0.1:8125"",
+-            ""includes"": ""kinto.plugins.history""
++            ""includes"": ""kinto.plugins.history"",
++            ""storage_strict_json"": True
+         }
+         config = testing.setUp(settings=settings)
+         with mock.patch('kinto.core.statsd.Client.timer') as mocked:",I don't think it's necessary to change this for the history plugin tests?,Why is this needed?
+9453,"@@ -328,8 +328,8 @@ bool TCPv4Transport::compare_locator_ip_and_port(
+ void TCPv4Transport::fill_local_ip(
+         Locator& loc) const
+ {
+-    IPLocator::setIPv4(loc, ""127.0.0.1"");
+     loc.kind = LOCATOR_KIND_TCPv4;
++    IPLocator::setIPv4(loc, ""127.0.0.1"");
+ }
+ 
+ ip::tcp::endpoint TCPv4Transport::generate_endpoint(","In general, I suggest using the `kind()` getter inhereted from `TransportInterface`",Why this change?
+9454,"@@ -48,8 +48,6 @@ namespace NLog.Layouts
+     /// </remarks>
+     [Layout(""Log4JXmlEventLayout"")]
+     [ThreadAgnostic]
+-    [ThreadSafe]
+-    [AppDomainFixedOutput]
+     public class Log4JXmlEventLayout : Layout, IIncludeContext
+     {
+         /// <summary>",Is the removal of `[AppDomainFixedOutput]` on purpose? (looks like a copy-paste...euh..remove error),Why was this remove
+9455,"@@ -1,4 +1,4 @@
+-//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (IAM) users.]
++//snippet-sourcedescription:[ListUsers.java demonstrates how to list all AWS Identity and Access Management (AWS IAM) users.]
+ //snippet-keyword:[AWS SDK for Java v2]
+ //snippet-keyword:[Code Sample]
+ //snippet-service:[AWS IAM]",AWS Identity and Access Management (IAM),Why did you change 
+9456,"@@ -163,6 +163,7 @@ type APIV1POSTTransactionSignRequest struct {
+ 	WalletHandleToken string `json:""wallet_handle_token""`
+ 	// swagger:strfmt byte
+ 	Transaction    []byte `json:""transaction""`
++	PublicKey      crypto.PublicKey `json:""public_key""`
+ 	WalletPassword string `json:""wallet_password""`
+ }
+ ",gofmt everything pls,Why do we need this?
+9457,"@@ -243,6 +243,8 @@ type PodIOChaosStatus struct {
+ }
+ 
+ // +kubebuilder:object:root=true
++// +kubebuilder:printcolumn:name=""action"",type=string,JSONPath=`.spec.action`
++// +kubebuilder:printcolumn:name=""duration"",type=string,JSONPath=`.spec.duration`
+ 
+ // PodIOChaosList contains a list of PodIOChaos
+ type PodIOChaosList struct {","ditto, We do not need add this feature for PodXXXChaos",// +kubebuilder:obje
+9458,"@@ -38,8 +38,9 @@ public class SampleNamer extends NameFormatterDelegator {
+   /**
+    * Returns the variable name of the service.
+    */
+-  public String getServiceVarName(String apiTypeName) {
+-    return localVarName(Name.lowerCamel(Name.upperCamel(apiTypeName).toLowerCamel(), ""service""));
++  public String getServiceVarName(String lowerCamelApiTypeName) {
++    return localVarName(
++        Name.lowerCamel(Name.lowerCamel(lowerCamelApiTypeName).toLowerCamel(), ""service""));
+   }
+ 
+   /**","There is a simpler way to do this: 1. Don't bother with the whole lowerCamelApiTypeName in SampleConfig 2. Use this code: `return localVarName(Name.upperCamel(apiTypeName, ""Service""));` Basically, each of the static creation methods of Name just need to have their arguments all be in the same casing, so you would just pass the upper camel string ""Service"" here.",Shouldn't this be `l
+9459,"@@ -28,7 +28,7 @@ using EdgeData = util::NodeBasedDynamicGraph::EdgeData;
+ 
+ bool requiresAnnouncement(const EdgeData &from, const EdgeData &to)
+ {
+-    return !from.IsCompatibleTo(to);
++    return !from.CanCombineWith(to);
+ }
+ 
+ TurnAnalysis::TurnAnalysis(const util::NodeBasedDynamicGraph &node_based_graph,",Can you explain this change to me?,Why is this change n
+9460,"@@ -19,7 +19,7 @@ const (
+ 	OpenEBSArtifacts  ArtifactSource = ""../artifacts/openebs-ci.yaml""
+ 	CStorPVCArtifacts ArtifactSource = ""../artifacts/cstor-pvc.yaml""
+ 	JivaPVCArtifacts  ArtifactSource = ""../artifacts/jiva-pvc.yaml""
+-	SingleReplicaSC   ArtifactSource = ""../artifacts/single-replica.yaml""
++	SingleReplicaSC   ArtifactSource = ""../artifacts/storageclass-1r.yaml""
+ 	CVRArtifact       ArtifactSource = ""../artifacts/cvr-schema.yaml""
+ 	CRArtifact        ArtifactSource = ""../artifacts/cr-schema.yaml""
+ )",let us rename the artifact to `storageclass-single-replica.yaml`,Why is this change needed?
+9461,"@@ -5,7 +5,7 @@ using System;
+ using System.Runtime.CompilerServices;
+ using System.Runtime.InteropServices;
+ 
+-namespace Microsoft.AspNetCore.Server.Kestrel.Internal.Networking
++namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.Internal.Networking
+ {
+     public class LibuvFunctions
+     {","Nit: I should have done this before, but rename the file to LibuvFunctions.cs. Make sure no other files are misnamed.",Why do we need this namesp
+9462,"@@ -100,6 +100,7 @@ public class JavaBinCodec implements PushWriter {
+           MAP_ENTRY_ITER = 17,
+           ENUM_FIELD_VALUE = 18,
+           MAP_ENTRY = 19,
++          UUID = 20, // This is reserved to be used only in LogCodec
+           // types that combine tag + length (or other info) in a single byte
+           TAG_AND_LEN = (byte) (1 << 5),
+           STR = (byte) (1 << 5),",We should not add new types unless absolutely required. I'm not sure `UUID` is requires a new type,Why do we need this?
+9463,"@@ -461,3 +461,14 @@ class JUnitMirrorsManager(MirrorsManager):
+             links.append(default_link)
+         self.log.debug('Total mirrors: %d', len(links))
+         return links
++
++
++class JavaEnv(object):
++    def get_additional_classpath(self):
++        pass
++
++    def get_cp_from_files(self):
++        pass
++
++    def get_files_from_cp(self):
++        pass","If only Gatling uses it, can we skip introducing new entity for now? Looks like overkill...",Why do we need this class?
+9464,"@@ -54,6 +54,14 @@ type VersionsResponse struct {
+ 	Versions []string `json:""versions""`
+ }
+ 
++// Response to `GET /versions`
++// swagger:response VersionsResponse
++type versionsResponse struct {
++	//Versions Response
++	//in:body
++	Body *VersionsResponse
++}
++
+ // APIV1GETWalletsResponse is the response to `GET /v1/wallets`
+ // friendly:ListWalletsResponse
+ type APIV1GETWalletsResponse struct {",rename -> info ?,`APIV1GETVersionsResponse` is the response to `GET /v1/versions`
+9465,"@@ -135,6 +135,10 @@ class scheduler(Config):
+ 
+     prune_on_get_work = parameter.BoolParameter(default=False)
+ 
++    upstream_status_when_all = parameter.BoolParameter(default=False,
++                                                       config_path=dict(section='scheduler',
++                                                                        name='upstream-status-when-all'))
++
+ 
+ class Failures(object):
+     """"""","Remove the `config_path=dict(...)`, that is automatic!",Why do we need this?
+9466,"@@ -23,9 +23,11 @@ function cleanupPlugins(resolve, reject) {
+     });
+   });
+ 
+-  axe.utils.toArray(document.querySelectorAll('frame, iframe')).forEach(function (frame) {
++  var flattenedTree = axe.utils.getFlattenedTree(document.body)
++
++  axe.utils.querySelectorAll(flattenedTree, 'iframe, frame').forEach(function (node) {
+     q.defer(function (res, rej) {
+-      return axe.utils.sendCommandToFrame(frame, {
++      return axe.utils.sendCommandToFrame(node.actualNode, {
+         command: 'cleanup-plugin'
+       }, res, rej);
+     });","I had to create a new flattened tree to support this functionality. The only other place in which a flattened tree is created is during the audit itself. Since `axe.cleanup` can be called at any arbitrary time, we can't reuse the same tree.",I think you can use `axe.utils.toArray` here.
+9467,"@@ -52,9 +52,15 @@ public final class ConfigUtil {
+ 
+   private static final String MICROSERVICE_CONFIG_LOADER_KEY = ""cse-microservice-config-loader"";
+ 
++  private static ConfigModel model = new ConfigModel();
++
+   private ConfigUtil() {
+   }
+ 
++  public static void addConfigs(Map<String, Object> config) {
++    model.setConfig(config);
++  }
++
+   public static Object getProperty(String key) {
+     Object config = DynamicPropertyFactory.getBackingConfigurationSource();
+     return getProperty(config, key);","As this method is just set the internal cofigModel, it's better to use setConfigs instead of addConfigs.",Why do we need this method?
+9468,"@@ -44,7 +44,13 @@ const (
+ // Timelimits for docker operations enforced above docker
+ const (
+ 	// ListContainersTimeout is the timeout for the ListContainers API.
+-	ListContainersTimeout   = 10 * time.Minute
++	ListContainersTimeout = 10 * time.Minute
++	// LoadImageTimeout is the timeout for the LoadImage API. It's set
++	// to much lower value than pullImageTimeout as it involves loading
++	// image from either a file or STDIN
++	// calls involved.
++	// TODO: Benchmark and re-evaluate this value
++	LoadImageTimeout        = 10 * time.Minute
+ 	pullImageTimeout        = 2 * time.Hour
+ 	createContainerTimeout  = 4 * time.Minute
+ 	startContainerTimeout   = 3 * time.Minute",Is this line needed?,I don't think we need this anymore.
+9469,"@@ -20,6 +20,8 @@ import (
+ 	""context""
+ 	""encoding/json""
+ 	""fmt""
++	""github.com/google/knative-gcp/pkg/apis/events/v1alpha1""
++	""github.com/google/knative-gcp/pkg/apis/events/v1beta1""
+ 	""net/url""
+ 	""os""
+ 	""time""",nit: import formatter,nit: remove empty line
+9470,"@@ -118,9 +118,18 @@ namespace AutoRest.Swagger
+                 headerType = null;
+             }
+ 
++            
+             // Response format
+             List<Stack<IModelType>> typesList = BuildResponses(method, headerType);
+ 
++            // if each of the responses have explicitly set their nullable property to false, we will have to consider it
++            bool isNonNullableReturnType = true;
++            _operation.Responses.Keys.ForEach(key =>
++            {
++                isNonNullableReturnType = isNonNullableReturnType && !(_operation.Responses[key].Extensions?.Get<bool>(""x-nullable"") ?? true);
++            });
++            method.IsXNullableReturnType = !(isNonNullableReturnType);
++
+             method.ReturnType = BuildMethodReturnType(typesList, headerType);
+             if (method.Responses.Count == 0)
+             {",can you use LINQ's `All` instead? Should be a side-effects free one liner with that.,Why do we need this?
+9471,"@@ -24,7 +24,9 @@
+ #include <inttypes.h>
+ #include <netdb.h>
+ #include <netinet/in.h>
++#ifndef __ANDROID__
+ #include <spawn.h>
++#endif
+ #include <stdio.h>
+ #include <stdlib.h>
+ #include <sys/socket.h>","Could you please remove `#include <spawn.h>` as a whole and see what happens? I believe that this is no longer needed; it was necessary when we called `posix_spawnp` directly, but now we use `h2o_spawnp`.",Why is this needed?
+9472,"@@ -94,10 +94,16 @@ func (in *fakeTwoPhaseChaos) GetStatus() *v1alpha1.ChaosStatus {
+ 	return &in.Status
+ }
+ 
++// IsDeleted returns whether this resource has been deleted
+ func (in *fakeTwoPhaseChaos) IsDeleted() bool {
+ 	return in.Deleted
+ }
+ 
++// IsPaused returns whether this resource is paused
++func (in *fakeTwoPhaseChaos) IsPaused() bool {
++	return false
++}
++
+ func (r fakeReconciler) Object() reconciler.InnerObject {
+ 	return &fakeTwoPhaseChaos{}
+ }",`whether this resource is paused` to `whether this resource has been paused` ? To keep same doc style.,nit: `return in.IsPaused()`
+9473,"@@ -36,4 +36,11 @@ public interface PermissionManager {
+   public boolean hasPermission(final String imageTypeName, final String userId, final Type type)
+       throws ImageMgmtException;
+ 
++  /**
++   * Checks if the user has permission to manage high priority flows.
++   * @param userId
++   * @return
++   * @throws ImageMgmtException
++   */
++  public boolean hasPermission(final String userId) throws ImageMgmtException;
+ }",This method is validating permission for hp flow. Can you please rename this method to convey the same?,Why do we need this method?
+9474,"@@ -102,9 +102,7 @@ class MongoNetworkError extends MongoError {
+     super(message);
+     this.name = 'MongoNetworkError';
+ 
+-    if (options && options.beforeHandshake === true) {
+-      this[kBeforeHandshake] = true;
+-    }
++    this[kBeforeHandshake] = !!(options && options.beforeHandshake === true);
+   }
+ }
+ ","Just to confirm, do we actually want to explicitly set the `kBeforeHandshake` symbol on all network errors regardless of whether the options/property is passed in?",Why is this change needed?
+9475,"@@ -122,6 +122,11 @@ func (r *RouteTable) SetRoutes(ifaceName string, targets []Target) {
+ 	r.dirtyIfaces.Add(ifaceName)
+ }
+ 
++func (r *RouteTable) QueueResync() {
++	r.logCxt.Info(""Queueing a resync."")
++	r.inSync = false
++}
++
+ func (r *RouteTable) Apply() error {
+ 	if !r.inSync {
+ 		links, err := r.dataplane.LinkList()",How soon after this will Apply() be called? It would be a shame if there was still a significant delay before a missing or superfluous route was corrected.,Why do we need this?
+9476,"@@ -172,9 +172,12 @@ func (g *gen) frame() []byte {
+ 		}
+ 		sort.Strings(imps)
+ 		for _, path := range imps {
+-			// TODO(light): Omit the local package identifier if it matches
+-			// the package name.
+-			fmt.Fprintf(&buf, ""\t%s %q\n"", g.imports[path], path)
++			// Omit the local package identifier if it matches the package name.
++			if g.imports[path] == path {
++				fmt.Fprintf(&buf, ""\t%q\n"", path)
++			} else {
++				fmt.Fprintf(&buf, ""\t%s %q\n"", g.imports[path], path)
++			}
+ 		}
+ 		buf.WriteString("")\n\n"")
+ 	}","While this is commonly correct, the more reliable check is to get the package's identifier from the type checker and check those for equality. The information should be there, just another matter of plumbing it.",I think this should be `if g.imports[path] == path {`
+9477,"@@ -168,6 +168,9 @@ def to_full_resource_name(full_parent_name, resource_type_name):
+     Returns:
+         str: full_resource_name of the child
+     """"""
++    # Strip out the fake composite root parent from the full resource name.
++    if full_parent_name == 'composite_root/root/':
++        return '{}/'.format(resource_type_name)
+ 
+     return '{}{}/'.format(full_parent_name, resource_type_name)
+ ","Just to clarify, should this be 'composite_root/root/' or 'composite_root/'?",Why do we need this?
+9478,"@@ -288,5 +288,6 @@ func (psb *PubSubBase) DeletePubSub(ctx context.Context, pubsubable duck.PubSuba
+ 		return fmt.Errorf(""failed to delete PullSubscription: %w"", err)
+ 	}
+ 	status.SinkURI = nil
++	status.SubscriptionID = """"
+ 	return nil
+ }",Any reason not to move it to after line 281? These are all pubsub related fields IIUC.,Why is this needed?
+9479,"@@ -3,7 +3,7 @@ import { both, gt } from 'ramda';
+ import isNumber from './isNumber';
+ 
+ /**
+- * Checks if value is a negative `Number` primitive or object.
++ * Checks if value is a negative `Number` primitive or object. Zero is not considered negative.
+  *
+  * @func isNegative
+  * @memberOf RA",Checks if value is a negative `Number` primitive or object. Zero is considered neither positive nor negative.,This should be reverted.
+9480,"@@ -285,6 +285,11 @@ func (h Handler) buildEnv(r *http.Request, rule Rule, fpath string) (map[string]
+ 	// Retrieve name of remote user that was set by some downstream middleware such as basicauth.
+ 	remoteUser, _ := r.Context().Value(httpserver.RemoteUserCtxKey).(string)
+ 
++	requestScheme := ""http""
++	if r.TLS != nil {
++		requestScheme = ""https""
++	}
++
+ 	// Some variables are unused but cleared explicitly to prevent
+ 	// the parent environment from interfering.
+ 	env = map[string]string{","Just a nit, but remove the empty line here. :)",Why do we need this?
+9481,"@@ -385,6 +385,16 @@ func (p *Package) addFiles(cu *apb.CompilationUnit, root, base string, names []s
+ 			Corpus: p.ext.DefaultCorpus,
+ 			Path:   trimmed,
+ 		}
++
++		if p.ext.Rules != nil {
++			v2, ok := p.ext.Rules.Apply(trimmed)
++			if ok {
++				vn.Corpus = v2.Corpus
++				vn.Root = v2.Root
++				vn.Path = v2.Path
++			}
++		}
++
+ 		if vn.Corpus == """" {
+ 			// If no default corpus is specified, use the package's corpus for each of
+ 			// its files.  The package corpus is based on the rules in",A `GoPackageInfo` details message should be added to the `CompilationUnit_FileInput` to ensure the import path remains the same.,I'm not sure if this
+9482,"@@ -1,10 +1,10 @@
+ package com.fsck.k9.activity;
+ 
+-import android.app.ListActivity;
+ import android.os.Bundle;
+ import android.view.KeyEvent;
+ import android.view.MotionEvent;
+ import android.widget.AdapterView;
++import android.widget.ListAdapter;
+ import android.widget.ListView;
+ 
+ import com.fsck.k9.K9;",Please don't create new fields with the `m` prefix. I'd rather mix than introduce more of these.,Shouldn't this be `L
+9483,"@@ -229,9 +229,13 @@ public class SolrConfig extends XmlConfigFile implements MapSerializable {
+     enableLazyFieldLoading = getBool(""query/enableLazyFieldLoading"", false);
+ 
+     useCircuitBreakers = getBool(""circuitBreaker/useCircuitBreakers"", false);
++    cpuCircuitBreakerEnabled = getBool(""circuitBreaker/cpuCircuitBreakerEnabled"", false);
++    memoryCircuitBreakerEnabled = getBool(""circuitBreaker/memoryCircuitBreakerEnabled"", false);
+     memoryCircuitBreakerThresholdPct = getInt(""circuitBreaker/memoryCircuitBreakerThresholdPct"", 95);
+ 
+-    validateMemoryBreakerThreshold();
++    cpuCircuitBreakerThreshold = getInt(""circuitBreaker/cpuCircuitBreakerThreshold"", 95);
++
++    validateCircuitBreakerThresholds();
+     
+     filterCacheConfig = CacheConfig.getConfig(this, ""query/filterCache"");
+     queryResultCacheConfig = CacheConfig.getConfig(this, ""query/queryResultCache"");",Can we please simplify these names? they are awfully verbose and repeating the parts that are already unique and obvious.,I think this should 
+9484,"@@ -241,7 +241,7 @@ public class RecipientPresenter implements PermissionPingCallback {
+             boolean alreadyVisible = recipientMvpView.isBccVisible();
+             boolean singleBccRecipientFromAccount =
+                     bccRecipients.length == 1 && bccRecipients[0].toString().equals(bccAddress);
+-            recipientMvpView.setBccVisibility(alreadyVisible || singleBccRecipientFromAccount);
++            recipientMvpView.setBccVisibility(alreadyVisible || !singleBccRecipientFromAccount);
+             updateRecipientExpanderVisibility();
+         }
+     }","Flipped the logic here, was this actually wrong before?",Why is this change needed?
+9485,"@@ -336,7 +336,7 @@ static CALI_BPF_INLINE int calico_tc(struct __sk_buff *skb)
+ 		.reason = CALI_REASON_UNKNOWN,
+ 	};
+ 	struct calico_nat_dest *nat_dest = NULL;
+-	bool nat_lvl1_drop = 0;
++	int res = 0;
+ 
+ 	/* we assume we do FIB and from this point on, we only set it to false
+ 	 * if we decide not to do it.",I think (a) should be initialized to `NAT_FE_LOOKUP_ALLOW` and (b) it should be probably the first thing in `calico_v4_nat_lookup2`,`res` is not used.
+9486,"@@ -36,7 +36,7 @@ public class TestManyPointsInOldIndex extends LuceneTestCase {
+ //
+ // Compile:
+ //   1) temporarily remove 'extends LuceneTestCase' above (else java doesn't see our static void main)
+-//   2) ant compile-test
++//   2) gradlew testClasses
+ //
+ // Run:
+ //   1) java -cp ../build/backward-codecs/classes/test:../build/core/classes/java org.apache.lucene.index.TestManyPointsInOldIndex","I'd look as to what this class actually does... seems weird. Classpath below (under ""run"") is wrong for gradle.",Why is this change needed?
+9487,"@@ -17,6 +17,7 @@
+ package algod
+ 
+ import (
++	""github.com/algorand/go-algorand/data/basics""
+ 	""path/filepath""
+ 	""testing""
+ ",Group w/ algorand imports,// +build !windows
+9488,"@@ -28,12 +28,14 @@ package com.salesforce.androidsdk.store;
+ 
+ import java.util.ArrayList;
+ import java.util.List;
++import java.util.Locale;
+ 
+ import net.sqlcipher.database.SQLiteDatabase;
+ 
+ import org.json.JSONException;
+ import org.json.JSONObject;
+ 
++import android.annotation.SuppressLint;
+ import android.content.Context;
+ import android.test.InstrumentationTestCase;
+ import android.util.Log;",I don't think this import is being used.,Why is this needed?
+9489,"@@ -5,7 +5,7 @@ const AnyKind = ""*** any procedure kind ***""
+ // Pattern represents an operator tree pattern
+ // It can match itself against a query plan
+ type Pattern interface {
+-	Root() ProcedureKind
++	Roots() []ProcedureKind
+ 	Match(Node) bool
+ }
+ ",This is an interesting way to do this. I like it. An alternative way to implement a multiple kind pattern was to have this return `AnyKind` and then have match perform an actual check to see if it matches.,Why is this change 
+9490,"@@ -373,8 +373,9 @@ class SonataMediaExtension extends Extension implements PrependExtensionInterfac
+         }
+ 
+         if ($container->hasDefinition('sonata.media.cdn.fallback') && isset($config['cdn']['fallback'])) {
++            // NEXT_MAJOR: Do not fallback to master
+             $container->getDefinition('sonata.media.cdn.fallback')
+-                ->replaceArgument(0, new Reference($config['cdn']['fallback']['master']))
++                ->replaceArgument(0, new Reference($config['cdn']['fallback']['primary'] ?? $config['cdn']['fallback']['master']))
+                 ->replaceArgument(1, new Reference($config['cdn']['fallback']['fallback']));
+         } else {
+             $container->removeDefinition('sonata.media.cdn.fallback');",You did not check this code,Shouldn't it be `||
+9491,"@@ -31,6 +31,10 @@ func EncodeValues(vals []*Value) ([]byte, error) {
+ // DecodeValues decodes an array of abi values from the given buffer, using the
+ // provided type information.
+ func DecodeValues(data []byte, types []Type) ([]*Value, error) {
++	if len(types) > 0 && len(data) == 0 {
++		return nil, fmt.Errorf(""expected %d parameters, but got 0"", len(types))
++	}
++
+ 	if len(data) == 0 {
+ 		return nil, nil
+ 	}","This was necessary due to a bug uncovered in testing. If an actor method which requires params is called without any params at all, not returning an error here causes a panic.",Should this be `len
+9492,"@@ -738,6 +738,7 @@ const htmlElms = {
+       'dialog',
+       'document',
+       'feed',
++			'group',
+       'log',
+       'main',
+       'marquee',","Thanks for the pr. Would you be able to edit the file to use spaces rather than tabs? Normally we have prettier run on commit, but I guess file patches don't do that.",
+9493,"@@ -111,7 +111,6 @@ public class TestHiveClientPool {
+             ""Another meta exception"", () -> clients.run(client -> client.getTables(""default"", ""t"")));
+   }
+ 
+-  @Test
+   public void testConnectionFailureRestoreForMetaException() throws Exception {
+     HiveMetaStoreClient hmsClient = newClient();
+ ",Is it intentional that we removed this annotation?,W
+9494,"@@ -42,6 +42,18 @@ namespace AutoRest.Swagger.Validation
+         /// </summary>
+         public override Category Severity => Category.Warning;
+ 
++        /// <summary>
++        /// What kind of open api document type this rule should be applied to
++        /// </summary>
++        public override ServiceDefinitionDocumentType ServiceDefinitionDocumentType => ServiceDefinitionDocumentType.ARM;
++
++        /// <summary>
++        /// When to apply the validation rule, before or after it has been merged as a part of 
++        /// its merged document as specified in the corresponding '.md' file
++        /// By default consider all rules to be applied for After only
++        /// </summary>
++        public override ServiceDefinitionDocumentState ValidationRuleMergeState => ServiceDefinitionDocumentState.Individual;
++
+         public override IEnumerable<ValidationMessage> GetValidationMessages(Dictionary<string, Schema> definitions, RuleContext context)
+         {
+             var violatingModels = definitions.Where(defPair=>defPair.Value.Properties?.Values.Any(schema => schema.Enum != null)??false);",should be general?,I
+9495,"@@ -153,7 +153,7 @@ namespace Nethermind.Blockchain
+         private void LoadBestKnown()
+         {            
+             long headNumber = Head?.Number ?? _syncConfig.PivotNumberParsed;
+-            long left = Math.Max(_syncConfig.PivotNumberParsed, headNumber);
++            long left = Math.Max(LowestInsertedHeader?.Number ?? 0, headNumber);
+             long right = headNumber + BestKnownSearchLimit;
+ 
+             bool LevelExists(long blockNumber)","if lowest inserted header is non null non zero then pivot should be higher and a better best known on the left. maybe Head?.Number ?? Math.Max(Pivot, LowestInsertedHeader))?",W
+9496,"@@ -0,0 +1,14 @@
++package azkaban.execapp.fake;
++
++import azkaban.execapp.AzkabanExecutorServer;
++import azkaban.execapp.jmx.JmxJobMBeanManager;
++import azkaban.utils.Props;
++
++public class FakeApp extends AzkabanExecutorServer {
++
++  public FakeApp() throws Exception {
++    super(new Props(), null, null, new FakeServer(), null);
++    JmxJobMBeanManager.getInstance().initialize(new Props());
++  }
++
++}",Is a FakeApp class needed? Can test use a Mockito mock instance instead?,Why do we need this class?
+9497,"@@ -1020,7 +1020,8 @@ VariableSP SymbolFilePDB::ParseVariableForPDBData(
+ 
+   var_sp = std::make_shared<Variable>(
+       var_uid, var_name.c_str(), mangled_cstr, type_sp, scope, context_scope,
+-      ranges, &decl, location, is_external, is_artificial, is_static_member);
++      ranges, &decl, location, is_external, is_artificial, is_static_member,
++      is_constant);
+   var_sp->SetLocationIsConstantValueData(is_constant);
+ 
+   m_variables.insert(std::make_pair(var_uid, var_sp));",We should make this an enum.,Why is this change needed?
+9498,"@@ -15,7 +15,6 @@ namespace Microsoft.CodeAnalysis.Sarif.Driver.Sdk
+         private const string TestRuleId = ""TST0001"";
+         private const string TestFormatSpecifier = ""testFormatSpecifier"";
+         private const string TestAnalysisTarget = @""C:\dir\file"";
+-        private static readonly string DisplayedTarget = TestAnalysisTarget.Replace('\\', '/');
+ 
+         private static readonly RuleDescriptor TestRule = new RuleDescriptor(
+             TestRuleId,","@lgolding, note I fixed the forward slashes that appeared in the VS output (which was certainly not by design).",Why was this removed?
+9499,"@@ -724,7 +724,7 @@ class ElementPlot(BokehPlot, GenericElementPlot):
+         else:
+             self.handles['xaxis'] = plot.xaxis[0]
+             self.handles['x_range'] = plot.x_range
+-            self.handles['y_axis'] = plot.yaxis[0]
++            self.handles['yaxis'] = plot.yaxis[0]
+             self.handles['y_range'] = plot.y_range
+         self.handles['plot'] = plot
+ ",Minor unrelated fix that snuck in.,Why did you change this?
+9500,"@@ -36,8 +36,8 @@ import com.salesforce.androidsdk.smartstore.store.QuerySpec;
+ import com.salesforce.androidsdk.smartstore.store.QuerySpec.QueryType;
+ import com.salesforce.androidsdk.smartstore.store.SmartStore;
+ import com.salesforce.androidsdk.smartstore.store.SmartStore.SmartStoreException;
+-import com.salesforce.androidsdk.smartstore.store.StoreCursor;
+ import com.salesforce.androidsdk.smartstore.store.SoupSpec;
++import com.salesforce.androidsdk.smartstore.store.StoreCursor;
+ import com.salesforce.androidsdk.smartstore.ui.SmartStoreInspectorActivity;
+ 
+ import net.sqlcipher.database.SQLiteDatabase;",Took the opportunity to fix the import ordering.,Why this change?
+9501,"@@ -130,9 +130,13 @@ class XRDCalculator(AbstractDiffractionPatternCalculator):
+         """"""
+         if isinstance(wavelength, float):
+             self.wavelength = wavelength
+-        else:
++        elif isinstance(wavelength, int):
++            self.wavelength = float(wavelength)
++        elif isinstance(wavelength, str):
+             self.radiation = wavelength
+             self.wavelength = WAVELENGTHS[wavelength]
++        else:
++            raise TypeError(""'wavelength' must be either of: float, int or str"")
+         self.symprec = symprec
+         self.debye_waller_factors = debye_waller_factors or {}
+ ",I think int and float can be handled in one if statement. The subsequent calculations don't really care whether it si a float or an int.,I don't think th
+9502,"@@ -134,14 +134,14 @@ func TestDelayedCancellationEnabled(t *testing.T) {
+ 	t.Parallel()
+ 
+ 	ctx, cancel := makeContextWithDelayedCancellation(t)
+-	EnableDelayedCancellationWithGracePeriod(ctx, 15*time.Millisecond)
++	EnableDelayedCancellationWithGracePeriod(ctx, 50*time.Millisecond)
+ 
+ 	cancel()
+ 
+ 	select {
+ 	case <-ctx.Done():
+ 		t.Fatalf(""Cancellation is not delayed"")
+-	case <-time.After(10 * time.Millisecond):
++	case <-time.After(20 * time.Millisecond):
+ 	}
+ 
+ 	<-ctx.Done()",Can we keep this at 10 to reduce the probability of a flake? Or are you afraid this would be too likely to give a false positive if delayed cancellation is every actually broken?,Why this change?
+9503,"@@ -15,9 +15,14 @@
+ package gcsblob
+ 
+ import (
++	""context""
++	""fmt""
++	""net/http""
+ 	""strings""
+ 	""testing""
+ 
++	""github.com/google/go-x-cloud/gcp""
++
+ 	""google.golang.org/api/googleapi""
+ )
+ ",nit: add a blank line under this.,nit: remove empt
+9504,"@@ -67,6 +67,7 @@ var (
+ 	bytecodeFlag = flag.NewStringVarP(""bytecode"", ""b"", """", ""set the byte code"")
+ 	yesFlag      = flag.BoolVarP(""assume-yes"", ""y"", false, ""answer yes for all confirmations"")
+ 	passwordFlag = flag.NewStringVarP(""password"", ""P"", """", ""input password for account"")
++	chainIDFlag  = flag.NewUint64VarP(""chainID"", """", 0, ""set chainID for action"")
+ )
+ 
+ // ActionCmd represents the action command",no need to add this flag query the endpoint set-up to determine the chainID,I don't think we need to add a new flag for this.
+9505,"@@ -0,0 +1,9 @@
++if (node.querySelector('input[type=""submit""], img[type=""submit""], button[type=""submit""]')) {
++  return true;
++}
++
++if (!node.querySelectorAll(':not(textarea)').length) {
++  return false;
++}
++
++return undefined;","Here is a few scenario - What if there is a submit button with in a form, but is always disabled?",Why is this necessary?
+9506,"@@ -1498,6 +1498,7 @@ const instr_info_t * const op_instr[] =
+ #define Wed TYPE_W, OPSZ_16_vex32_evex64
+ #define Vex TYPE_V, OPSZ_16_vex32_evex64
+ #define Wex TYPE_W, OPSZ_16_vex32_evex64
++#define Weh_x TYPE_W, OPSZ_half_16_vex32_evex64
+ 
+ /* my own codes
+  * size m = 32 or 16 bit depending on addr size attribute",wrong code: should be `Wh_e`,Why is this needed?
+9507,"@@ -582,10 +582,11 @@ static void makeLabelTag (vString *const label)
+ 
+ static lineType getLineType (void)
+ {
+-	vString *label = vStringNew ();
++	static vString *label = NULL;
+ 	int column = 0;
+ 	lineType type = LTYPE_UNDETERMINED;
+ 
++	label = vStringNewOrClear (label);
+ 	do  /* read in first 6 ""margin"" characters */
+ 	{
+ 		int c = getcFromInputFile ();","This leads to a small ""leak"" (mostly theoretical only though), if we don't want it this could be created in `initialize()` and destroyed in `finalize()`.",Why is this static?
+9508,"@@ -25,6 +25,8 @@ import (
+ )
+ 
+ const (
++	// BuildIDOSEnv is the os env name to get build id
++	BuildIDOSEnv           = ""BUILD_ID""
+ 	translateFailedPrefix  = ""TranslateFailed""
+ 	privacyInfoReplacement = ""[Privacy Info]""
+ )","BuildIDOSEnvVarName or similar, otherwise it sounds it's actually holding actual value of env var",I think this should be `BuildIDEnv`
+9509,"@@ -103,7 +103,7 @@ class SparkReader:
+         """"""
+ 
+         with self.app.app_context():
+-
++            current_app.logger.info('Spark consumer has started!')
+             while True:
+                 self.init_rabbitmq_connection()
+                 self.incoming_ch = utils.create_channel_to_consume(","I like this standard ""container has started"" message. Should we have a ""container exited because FOO"" message as well?",I don't think this is the right pla
+9510,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+ 
+ import com.google.common.collect.Maps;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.,Why is this import needed?
+9511,"@@ -0,0 +1,19 @@
++const { useHandsontable } = require('./use-handsontable');
++const { getDependencies } = require('./dependencies');
++const { register } = require('./register');
++
++if (module) {
++  module.exports = {
++    useHandsontable,
++    instanceRegister: register,
++    getDependencies,
++    applyToWindow: () => {
++      /* eslint-disable no-restricted-globals */
++      if ((typeof window !== 'undefined')) {
++        window.useHandsontable = useHandsontable;
++        window.instanceRegister = register;
++      }
++      /* eslint-enable no-restricted-globals */
++    }
++  };
++}","We have Vue application at our disposal, and have examples container implemented as component. Shouldn't helpers be imported instead being global? Not the best practice in Vue app I guess",Why do we need this?
+9512,"@@ -1221,3 +1221,14 @@ type NoMergedMDError struct {
+ func (e NoMergedMDError) Error() string {
+ 	return fmt.Sprintf(""No MD yet for TLF %s"", e.tlf)
+ }
++
++// DiskCacheClosedError indicates that the disk cache has been
++// closed, and thus isn't accepting any more operations.
++type DiskCacheClosedError struct {
++	op string
++}
++
++// Error implements the error interface for DiskCacheClosedError.
++func (e DiskCacheClosedError) Error() string {
++	return fmt.Sprintf(""Error performing %s operation: the disk cache is closed."", e.op)
++}",No trailing punctuation in the error message.,I don't think this should be a `DiskCacheClosedError`.
+9513,"@@ -447,5 +447,6 @@ public class Notifier
+ 			}
+ 		}
+ 		clip.start();
++		clip.close();
+ 	}
+ }",tested? seems like it could break,Why is this needed?
+9514,"@@ -77,9 +77,10 @@ public final class IndexUpgrader {
+   public static void main(String[] args) throws IOException {
+     parseArgs(args).upgrade();
+   }
+-  
++
++  /** Parse arguments. */
+   @SuppressForbidden(reason = ""System.out required: command line tool"")
+-  static IndexUpgrader parseArgs(String[] args) throws IOException {
++  public static IndexUpgrader parseArgs(String[] args) throws IOException {
+     String path = null;
+     boolean deletePriorCommits = false;
+     InfoStream out = null;",This have to be public because the renamed o.a.l.backward_index.TestBackwardsCompatibility refers this.,Why is this needed?
+9515,"@@ -286,7 +286,7 @@ func TestApplicationsUpgradeOverGossip(t *testing.T) {
+ 	fixture.SetupNoStart(t, filepath.Join(""nettemplates"", ""TwoNodes100SecondTestUnupgradedProtocol.json""))
+ 
+ 	// for the primary node, we want to have a different consensus which always enables applications.
+-	primaryNodeUnupgradedProtocol := consensus[consensusTestFastUpgrade(protocol.ConsensusFuture)]
++	primaryNodeUnupgradedProtocol := consensus[consensusTestFastUpgrade(protocol.ConsensusCurrentVersion)]
+ 	primaryNodeUnupgradedProtocol.ApprovedUpgrades = make(map[protocol.ConsensusVersion]uint64)
+ 	primaryNodeUnupgradedProtocol.ApprovedUpgrades[consensusTestFastUpgrade(protocol.ConsensusFuture)] = 0
+ 	consensus[consensusTestUnupgradedProtocol] = primaryNodeUnupgradedProtocol","unrelated to your change, but I don't think that this is correct anymore. We also seen to remove application support from `primaryNodeUnupgradedProtocol` for the test to be correct.",why this change?
+9516,"@@ -440,6 +440,19 @@ func mergeConfigSrcs(cfg, userCfg *aws.Config, envCfg envConfig, sharedCfg share
+ 			cfg.Credentials = credentials.NewStaticCredentialsFromCreds(
+ 				envCfg.Creds,
+ 			)
++
++		} else if len(envCfg.WebIdentityTokenFilePath) > 0 {
++			// handles assume role via OIDC token. This should happen before any other
++			// assume role call.
++			sessionName := envCfg.IAMRoleSessionName
++			if len(sessionName) == 0 {
++				sessionName = sharedCfg.AssumeRole.RoleSessionName
++			}
++
++			cfg.Credentials = stscreds.NewWebIdentityCredentials(&Session{
++				Config:   cfg,
++				Handlers: handlers.Copy(),
++			}, envCfg.WebIdentityRoleARN, sessionName, envCfg.WebIdentityTokenFilePath)
+ 		} else if envCfg.EnableSharedConfig && len(sharedCfg.AssumeRole.RoleARN) > 0 && sharedCfg.AssumeRoleSource != nil {
+ 			cfgCp := *cfg
+ 			cfgCp.Credentials = credentials.NewStaticCredentialsFromCreds(","Should this also validate that the RoleArn env var is provided, or just let the creds fail?",I think this should be `envCfg.WebIdentityRoleARN` instead of `envCfg.IAMRoleSessionName`
+9517,"@@ -20,10 +20,12 @@
+ 
+ package transport
+ 
++import ""github.com/opentracing/opentracing-go""
++
+ // Deps is the interface of any object useful for passing injected
+ // dependencies into inbound and outbound transports.
+ type Deps interface {
+-	// Tracer() opentracing.Tracer
++	Tracer() opentracing.Tracer
+ }
+ 
+ // NoDeps is a no-op implementation of Deps","fwiw, in tchannel-go I've implemented a similar method on TChannel that either returns a Tracer instance it was initialized with, or returns `opentracing.GlobalTracer()`, which by default happens to return a singleton instance of `NoopTracer`. In Go the use of global variables is not frowned upon as say in Java, so this pattern allows minimal work to enable tracing in a service, one just needs to store a real tracer in the global variable, e.g. via `opentracing.InitGlobalTracer(someTracerImpl)`, while the instances of TChannel do not need to be explicitly given any tracer since they will default to that global.",Why is this needed?
+9518,"@@ -135,6 +135,10 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         self.assertEqual(kidx.name, ""renamed"")
+         self.assert_eq(kidx, pidx)
+ 
++        expected_error_message = ""Series.name must be a hashable type""
++        with self.assertRaisesRegex(TypeError, expected_error_message):
++            kser.name = [""0"", ""1""]
++
+     def test_rename_method(self):
+         # Series name
+         pser = pd.Series([1, 2, 3, 4, 5, 6, 7], name=""x"")","Shall we also add `ks.Series([1, 2, 3], name=[""0"", ""1""])`?",I think this should be `Series.name must be a string`
+9519,"@@ -45,7 +45,7 @@ public class PermissioningJsonRpcRequestFactory {
+ 
+   Request<?, AddNodeResponse> addNodesToWhitelist(final List<URI> enodeList) {
+     return new Request<>(
+-        ""perm_addNodesToWhitelist"",
++        ""perm_addNodesToAllowlist"",
+         Collections.singletonList(enodeList),
+         web3jService,
+         AddNodeResponse.class);",Can this be updated?,nit: `allowlist` -> `allowlist`
+9520,"@@ -89,14 +89,7 @@ final class AddProviderCompilerPass implements CompilerPassInterface
+                 $definition = $container->getDefinition($id);
+ 
+                 foreach ($context['formats'] as $format => $formatConfig) {
+-                    $formatConfig['quality'] = $formatConfig['quality'] ?? 80;
+-                    $formatConfig['format'] = $formatConfig['format'] ?? 'jpg';
+-                    $formatConfig['height'] = $formatConfig['height'] ?? null;
+-                    $formatConfig['constraint'] = $formatConfig['constraint'] ?? true;
+-                    $formatConfig['resizer'] = $formatConfig['resizer'] ?? false;
+-
+-                    $formatName = sprintf('%s_%s', $name, $format);
+-                    $definition->addMethodCall('addFormat', [$formatName, $formatConfig]);
++                    $definition->addMethodCall('addFormat', [sprintf('%s_%s', $name, $format), $formatConfig]);
+                 }
+             }
+         }","this change is to avoid duplication on the defaults. They are already on the Configuration class. (Also I removed the false default, because the admin format does not have it). This is also produces the rest of the diff, changes from false to null.",`$formatConfig['height'] ?? null;` should be removed as well.
+9521,"@@ -46,6 +46,8 @@ func (pc *podConfigurator) connectInterfaceToOVSAsync(ifConfig *interfacestore.I
+ 	go func() {
+ 		klog.Infof(""Waiting for interface %s to be created"", hostIfAlias)
+ 		err := wait.PollImmediate(time.Second, 60*time.Second, func() (bool, error) {
++			containerAccess.lockContainer(containerID)
++			defer containerAccess.unlockContainer(containerID)
+ 			curEp, ok := pc.ifConfigurator.getEndpoint(ovsPortName)
+ 			if !ok {
+ 				return true, fmt.Errorf(""failed to find HNSEndpoint %s"", ovsPortName)","What does it protect from? If it's subsequent CNI calls, won't containerID be different from the first one? or it's different in containerd? we use `getInfraContainer` to get the lock identity in CNIAdd. And this reminds me what if the first CNI call and the subquent ones run into connectInterfaceToOVSAsync, will duplicate ports being created or it has been handled?",Why do we need to lock here?
+9522,"@@ -0,0 +1,19 @@
++<?php
++
++namespace Shopsys\FrameworkBundle\Model\Advert\Exception;
++
++use Exception;
++
++class AdvertPositionNotKnownException extends Exception implements AdvertException
++{
++    public function __construct(string $positionName, array $knownPositionsNames, Exception $previous = null)
++    {
++        $message = sprintf(
++            'Unknown advert position name ""%s"". Known names are %s.',
++            $positionName,
++            implode('"", ""', $knownPositionsNames)
++        );
++
++        parent::__construct($message, 0, $previous);
++    }
++}","In Exceptions' constructors, we always add a optional last parameter `Exception $previous = null`. In the past, this was (still is?) a part of the coding standards.",Missing license header.
+9523,"@@ -90,6 +90,15 @@ const connectionActivityMonitorInterval = time.Minute * 3
+ // we discard the connection.
+ const maxPeerInactivityDuration = time.Minute * 5
+ 
++// maxMessageQueueDuration is the maximum amount of time a message is allowed to be waiting
++// in the various queues before being sent. Once that deadline has reached, sending the message
++// is pointless, as it's too stale to be of any value
++const maxMessageQueueDuration = time.Second * 25
++
++// slowWritingPeerMonitorInterval is the interval at which we peek on the connected peers to
++// verify that their current outgoing message is not being blocked for too long.
++const slowWritingPeerMonitorInterval = time.Second * 5
++
+ var networkIncomingConnections = metrics.MakeGauge(metrics.NetworkIncomingConnections)
+ var networkOutgoingConnections = metrics.MakeGauge(metrics.NetworkOutgoingConnections)
+ ","I think more idiomatic (and consistent with elsewhere in our code base, and more natural to read as ""25 seconds"") is `25 * time.Second`",nit: `slowWritingPeerMonitorInterval` -> `slowWritingPeerMoni
+9524,"@@ -127,6 +127,7 @@ func NewDecoder(opts ...func(*Decoder)) *Decoder {
+ 	d := &Decoder{
+ 		MarshalOptions: MarshalOptions{
+ 			SupportJSONTags: true,
++			SupportYAMLTags: true,
+ 		},
+ 	}
+ 	for _, o := range opts {","Enabling `YAML` by default would be a breaking change in behavior for some applications if the struct's used by that application already include YAML tags, but their application has been (un)marshaling DynamoDB Attributes based on the struct name.",I don't think this is needed.
+9525,"@@ -131,7 +131,7 @@ public class DriverCommandExecutor extends HttpCommandExecutor implements Closea
+         Thread.currentThread().interrupt();
+         throw new WebDriverException(""Timed out waiting for driver server to stop."", e);
+       } finally {
+-        executorService.shutdownNow();
++        executorService.shutdown();
+       }
+ 
+     } else {","For the command executor, which in turn, uses the HTTP client to talk to the WebDriver, the client might have high-timeout values set, so the shutdown can take a long time if we wait for it to complete, especially if multiple-long running threads are there. I think it might be a good idea in general to couple the shutdown() with `awaitTermination()` with a timeout, if the ongoing tasks do not complete within that timeout then call `shutdownNow()`. What do you think?",Why is this change needed?
+9526,"@@ -38,7 +38,7 @@ public abstract class HiveMetastoreTest {
+   @BeforeClass
+   public static void startMetastore() throws Exception {
+     HiveMetastoreTest.metastore = new TestHiveMetastore();
+-    metastore.start();
++    metastore.start(new HiveConf(HiveMetastoreTest.class));
+     HiveMetastoreTest.hiveConf = metastore.hiveConf();
+     HiveMetastoreTest.metastoreClient = new HiveMetaStoreClient(hiveConf);
+     String dbPath = metastore.getDatabasePath(DB_NAME);",Is this change needed? `start()` is still defined and uses `HiveMetastoreTest.class`. The only difference is that this doesn't pass a `Configuration` and the parameterless `start` passes `new Configuration()`.,Why is this change needed?
+9527,"@@ -27,6 +27,7 @@ type stakingCommand struct {
+ 	stakingV1   Protocol
+ 	stakingV2   *staking.Protocol
+ 	candIndexer *CandidateIndexer
++	sr          protocol.StateReader
+ }
+ 
+ // NewStakingCommand creates a staking command center to manage staking committee and new native staking",I think it is weird to store sr in protocol struct,why do we need this?
+9528,"@@ -7308,6 +7308,16 @@ NATable * NATableDB::get(const ExtendedQualName* key, BindWA* bindWA, NABoolean
+      }
+   }
+ 
++  // the reload cqd will be set during aqr after compiletime and runtime
++  // timestamp mismatch is detected.
++  // If set, reload hive metadata.
++  if ((cachedNATable->isHiveTable()) &&
++      (CmpCommon::getDefault(HIVE_DATA_MOD_CHECK) == DF_ON) &&
++      (CmpCommon::getDefault(TRAF_RELOAD_NATABLE_CACHE) == DF_ON))
++    {
++      removeEntry = TRUE;
++    }
++
+   //Found in cache.  If that's all the caller wanted, return now.
+   if ( !removeEntry && findInCacheOnly )
+      return cachedNATable;",Will this cause a reload _all_ NATable information? It's too bad we don't have some way to limit the reload to just the tables that have a metadata mismatch.,I don't think this is the right place to put this code. It should be in a separate function.
+9529,"@@ -111,6 +111,7 @@ var opDocList = []stringString{
+ 	{""app_global_del"", ""delete key A from a global state of the current application""},
+ 	{""asset_holding_get"", ""read from account specified by Txn.Accounts[A] and asset B holding field X (imm arg) => {0 or 1 (top), value}""},
+ 	{""asset_params_get"", ""read from asset Txn.ForeignAssets[A] params field X (imm arg) => {0 or 1 (top), value}""},
++	{""assert"", ""immediately fail unless value X is not zero""},
+ }
+ 
+ var opDocByName map[string]string",'fail unless X is a non-zero number' it will also fail if X is a byte string,"{""assert"", ""immediately fail unless value X is not zero""},"
+9530,"@@ -1447,10 +1447,13 @@ class ElementPlot(BokehPlot, GenericElementPlot):
+         """"""
+         Resets RangeXY streams if norm option is set to framewise
+         """"""
+-        if self.overlaid:
++        # Temporarily reverts this fix (see https://github.com/holoviz/holoviews/issues/4396)
++        # This fix caused PlotSize change events to rerender
++        # rasterized/datashaded with the full extents which was wrong
++        if self.overlaid or True:
+             return
+         for el, callbacks in self.traverse(lambda x: (x.current_frame, x.callbacks)):
+-            if el is None:
++            if el is None:W
+                 continue
+             for callback in callbacks:
+                 norm = self.lookup_options(el, 'norm').options",SyntaxError I think,I think this should be `if not self.overlaid:`
+9531,"@@ -5012,6 +5012,9 @@ TEST_F(VkLayerTest, ValidateGeometryNV) {
+         vkCreateAccelerationStructureNV(m_device->handle(), &as_create_info, nullptr, &as);
+         m_errorMonitor->VerifyFound();
+     }
++#if 0
++    // XXX Subtest disabled because this is the wrong VUID.
++    // No VUIDs currently exist to require memory is bound (spec bug).
+     // Invalid vertex buffer - no memory bound.
+     {
+         VkGeometryNV geometry = valid_geometry_triangles;",I've filed an internal spec issue to add these missing VUs.,Why is this disabled?
+9532,"@@ -24,6 +24,7 @@ import org.openqa.selenium.WebDriver;
+ import org.openqa.selenium.WebElement;
+ 
+ import java.io.IOException;
++import java.io.UncheckedIOException;
+ import java.net.URL;
+ import java.nio.charset.StandardCharsets;
+ import java.util.ArrayList;",Can you please revert changes to files in the `thoughtworks` package? This is legacy code and we will eventually phase out RC.,Why is this needed?
+9533,"@@ -24,16 +24,11 @@ import java.math.BigInteger;
+ import java.nio.ByteBuffer;
+ import java.time.Instant;
+ import java.time.ZoneOffset;
++import java.util.Arrays;
+ import java.util.List;
+ import java.util.Map;
+-import org.apache.flink.table.data.ArrayData;
+-import org.apache.flink.table.data.DecimalData;
+-import org.apache.flink.table.data.GenericRowData;
+-import org.apache.flink.table.data.MapData;
+-import org.apache.flink.table.data.RawValueData;
+-import org.apache.flink.table.data.RowData;
+-import org.apache.flink.table.data.StringData;
+-import org.apache.flink.table.data.TimestampData;
++
++import org.apache.flink.table.data.*;
+ import org.apache.iceberg.MetadataColumns;
+ import org.apache.iceberg.Schema;
+ import org.apache.iceberg.parquet.ParquetValueReader;","In iceberg, we usually don't use `*` to import package, it's more clear to import the specify package one by one.",Please don't use st
+9534,"@@ -19,6 +19,8 @@ package org.openqa.grid.web;
+ 
+ import com.google.common.collect.Maps;
+ 
++import com.sun.org.glassfish.gmbal.ManagedObject;
++
+ import org.openqa.grid.internal.Registry;
+ import org.openqa.grid.internal.utils.GridHubConfiguration;
+ import org.openqa.grid.web.servlet.DisplayHelpServlet;",And again. The reason it's bad is that if someone uses a JDK not produced by Oracle they won't have this class.,Why is this import 
+9535,"@@ -18,7 +18,8 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure
+             // There's no reason to stop timing the write after the connection is closed.
+             var oneBufferSize = maxResponseBufferSize.Value;
+             var maxBufferedBytes = oneBufferSize < long.MaxValue / 2 ? oneBufferSize * 2 : long.MaxValue;
+-            timeoutControl.StartTimingWrite(minDataRate, maxBufferedBytes);
++            timeoutControl.BytesWritten(minDataRate, maxBufferedBytes);
++            timeoutControl.StartTimingWrite();
+         }
+     }
+ }","Since we now keep track of all bytes written, and extend the write timeout as needed, it's tempting to no longer add 2 times the max buffer size to the bytes written accounting for the connection drain timeout. As we've discussed before, this add several minutes to the timeout with the default 240 bytes/sec rate limit. I'm thinking instead this line changes to `timeoutControl.BytesWritten(minDataRate, 1);` to add a grace period to the drain if necessary. What do you think @Tratcher?",Why do we need this
+9536,"@@ -0,0 +1,18 @@
++const formPropsSet = new Set([
++	'form',
++	'formAction',
++	'formEncType',
++	'formMethod',
++	'formNoValidate',
++	'formTarget',
++]);
++
++export default function getFormProps(props) {
++	return Object.keys(props).reduce((prev, key) => {
++		if (formPropsSet.has(key)) {
++			// eslint-disable-next-line no-param-reassign
++			prev[key] = props[key];
++		}
++		return prev;
++	}, {});
++}",Good call. Makes we wonder if we should do this with the ARIA props.,I'm not sure if this is the best place for this function. I think it would be better to move it to `components/form/index.js`
+9537,"@@ -24,9 +24,7 @@ import java.io.InputStream;
+ import java.io.InputStreamReader;
+ import java.io.Reader;
+ import java.nio.charset.Charset;
+-import java.sql.Connection;
+-import java.sql.DatabaseMetaData;
+-import java.sql.SQLException;
++import java.sql.*;
+ import java.text.ParseException;
+ import java.util.ArrayList;
+ import java.util.Calendar;",Please do not use wildcard imports.,Please avoid wildcard imports.
+9538,"@@ -386,6 +386,7 @@ struct wlr_surface *wlr_surface_create(struct wl_resource *res,
+ 		wl_resource_post_no_memory(res);
+ 		return NULL;
+ 	}
++	wlr_log(L_DEBUG, ""New wlr_surface %p (res %p)"", surface, res);
+ 	surface->renderer = renderer;
+ 	surface->texture = wlr_render_texture_create(renderer);
+ 	surface->resource = res;","Not sure about these added logs, as said in the commit message it's probably not something we want all the time, but it helped me debug a bit.",I think this should be `L_DEBUG`
+9539,"@@ -487,8 +487,6 @@ class Comparison(ComparisonInterface):
+         paths2 = el2.split()
+         if len(paths1) != len(paths2):
+             raise cls.failureException(""%s objects do not have a matching number of paths."" % msg)
+-        for p1, p2 in zip(paths1, paths2):
+-            cls.compare_dataset(p1, p2, '%s data' % msg)
+ 
+     @classmethod
+     def compare_contours(cls, el1, el2, msg='Contours'):",Should there be an equivalent check or is it ok to remove this comparison?,Why did you remove this?
+9540,"@@ -57,7 +57,7 @@ def run_migrations_online():
+ 
+     # this callback is used to prevent an auto-migration from being generated
+     # when there are no changes to the schema
+-    # reference: http://alembic.readthedocs.org/en/latest/cookbook.html
++    # reference: http://alembic.zzzcomputing.com/en/latest/cookbook.html
+     def process_revision_directives(context, revision, directives):
+         if getattr(config.cmd_opts, 'autogenerate', False):
+             script = directives[0]","sorry, why this change?",I think this should be `readthedocs.org`.
+9541,"@@ -82,7 +82,7 @@ public abstract class AnalysisRequestHandlerBase extends RequestHandlerBase {
+    *
+    * @throws Exception When analysis fails.
+    */
+-  protected abstract NamedList doAnalysis(SolrQueryRequest req) throws Exception;
++  protected abstract NamedList<?> doAnalysis(SolrQueryRequest req) throws Exception;
+ 
+   /**
+    * Analyzes the given value using the given Analyzer.","I think best practice is to use `NamedList<Object>` as the return type, and `NamedList<?>` as the argument type in methods, but I can't find a reference for it right now.",Why is this change needed?
+9542,"@@ -23,7 +23,9 @@ use Thelia\Core\Template\Element\PropelSearchLoopInterface;
+ use Thelia\Core\Template\Loop\Argument\Argument;
+ use Thelia\Core\Template\Loop\Argument\ArgumentCollection;
+ use Thelia\Coupon\Type\CouponInterface;
++use Thelia\Model\Base\CouponModule;
+ use Thelia\Model\Coupon as MCoupon;
++use Thelia\Model\CouponCountry;
+ use Thelia\Model\CouponQuery;
+ use Thelia\Model\Map\CouponTableMap;
+ use Thelia\Type\EnumListType;","Be careful, the base model is imported here !",Why is this needed?
+9543,"@@ -60,7 +60,7 @@ func RootCommand() (*cobra.Command, *Flags) {
+ 	rootCmd.PersistentFlags().IntVar(&cfg.HttpPort, ""http.port"", node.DefaultHTTPPort, ""HTTP-RPC server listening port"")
+ 	rootCmd.PersistentFlags().StringSliceVar(&cfg.HttpCORSDomain, ""http.corsdomain"", []string{}, ""Comma separated list of domains from which to accept cross origin requests (browser enforced)"")
+ 	rootCmd.PersistentFlags().StringSliceVar(&cfg.HttpVirtualHost, ""http.vhosts"", node.DefaultConfig.HTTPVirtualHosts, ""Comma separated list of virtual hostnames from which to accept requests (server enforced). Accepts '*' wildcard."")
+-	rootCmd.PersistentFlags().StringSliceVar(&cfg.API, ""http.api"", []string{""eth""}, ""API's offered over the HTTP-RPC interface"")
++	rootCmd.PersistentFlags().StringSliceVar(&cfg.API, ""http.api"", []string{""eth"", ""tg""}, ""API's offered over the HTTP-RPC interface"")
+ 	rootCmd.PersistentFlags().Uint64Var(&cfg.Gascap, ""rpc.gascap"", 0, ""Sets a cap on gas that can be used in eth_call/estimateGas"")
+ 	rootCmd.PersistentFlags().Uint64Var(&cfg.MaxTraces, ""trace.maxtraces"", 200, ""Sets a limit on traces that can be returned in trace_filter"")
+ 	rootCmd.PersistentFlags().StringVar(&cfg.TraceType, ""trace.type"", ""parity"", ""Specify the type of tracing [geth|parity*] (experimental)"")","Do we want to make this part of the default? Probably not. In fact, the default should probably be eth, web3 and net (which are the standard namespaces on other nodes).",Why do we need to change this?
+9544,"@@ -1,4 +1,8 @@
+ class Clump < ActiveRecord::Base
+   belongs_to :code_set
+   belongs_to :slave
++
++  def path
++    slave.path_from_code_set_id(code_set_id)
++  end
+ end",What is the plan when we deploy the Crawler VM project and eliminate the Clump model?,Why do we need this method?
+9545,"@@ -28,10 +28,6 @@ type MultiClusterConfig struct {
+ 	metav1.TypeMeta `json:"",inline""`
+ 	// ControllerManagerConfigurationSpec returns the contfigurations for controllers
+ 	config.ControllerManagerConfigurationSpec `json:"",inline""`
+-	// Leader is a role of ClusterSet member cluster
+-	Leader bool `json:""leader,omitempty""`
+-	// Member is a role of ClusterSet member cluster
+-	Member bool `json:""member,omitempty""`
+ }
+ 
+ func init() {","these two are customized config fields, if we don't need them any more, we probably can use default ControllerManagerConfiguration",Why are these removed?
+9546,"@@ -39,7 +39,12 @@ var (
+ 	defaultExecutablePathProvider executablePathProvider = os.Executable
+ 	defaultCommandArgsProvider    commandArgsProvider    = func() []string { return os.Args }
+ 	defaultOwnerProvider          ownerProvider          = user.Current
+-	defaultRuntimeNameProvider    runtimeNameProvider    = func() string { return runtime.Compiler }
++	defaultRuntimeNameProvider    runtimeNameProvider    = func() string {
++		if runtime.Compiler == ""gc"" {
++			return ""go""
++		}
++		return runtime.Compiler
++	}
+ 	defaultRuntimeVersionProvider runtimeVersionProvider = runtime.Version
+ 	defaultRuntimeOSProvider      runtimeOSProvider      = func() string { return runtime.GOOS }
+ 	defaultRuntimeArchProvider    runtimeArchProvider    = func() string { return runtime.GOARCH }","I don't think we should be pulling the runtime name from the Compiler. There are two compiler frontends, but both of them compile the same source to generate the ""go"" runtime. I think until there is a request from an alternative implementation (the embedded world **might** have a different runtime), it's fine to hardcode this as ""go""",Why do we need this?
+9547,"@@ -932,6 +932,10 @@ Model.find = function find (conditions, fields, options, callback) {
+     options = null;
+   }
+ 
++  if (this.schema.discriminatorMapping && fields) {
++    fields = fields + ' ' + this.schema.options.discriminatorKey;
++  }
++
+   // get the raw mongodb collection object
+   var mq = new Query({}, options, this, this.collection);
+   mq.select(fields);",fields may be an object.,Why do we need this?
+9548,"@@ -4,12 +4,12 @@ import (
+ 	""bufio""
+ 	""encoding/json""
+ 	""fmt""
+-	""io/ioutil""
+ 	""log""
+ 	""net/http""
+ 	""net/url""
+ 	""strings""
+ 	""sync""
++	""time""
+ 
+ 	""github.com/hashicorp/hcl""
+ 	""github.com/spiffe/spire/proto/agent/workloadattestor""",i'm not confident these are the right defaults... anybody have input?,nit: remove empty line
+9549,"@@ -80,7 +80,7 @@ type CasPool struct {
+ 	Namespace string
+ 
+ 	// DiskList is the list of disks over which a storagepool will be provisioned
+-	DiskList []string
++	DiskList []DiskGroup
+ 
+ 	// PoolType is the type of pool to be provisioned e.g. striped or mirrored
+ 	PoolType string",DiskGroupList can be better name,Shouldn't this be `Dis
+9550,"@@ -229,7 +229,7 @@ func customErrorHandler(ctx context.Context, mux *runtime.ServeMux, m runtime.Ma
+ 	runtime.DefaultHTTPErrorHandler(ctx, mux, m, w, req, err)
+ }
+ 
+-func New(unaryInterceptors []grpc.UnaryServerInterceptor, assets http.FileSystem, gatewayCfg *gatewayv1.GatewayOptions) (*Mux, error) {
++func New(unaryInterceptors []grpc.UnaryServerInterceptor, assets http.FileSystem, gatewayCfg *gatewayv1.GatewayOptions, metricsHandler http.Handler) (*Mux, error) {
+ 	secureCookies := true
+ 	if gatewayCfg.SecureCookies != nil {
+ 		secureCookies = gatewayCfg.SecureCookies.Value",nit: lets leave gateway options at the end of the func signature.,nit: `metricsHandler` 
+9551,"@@ -527,7 +527,7 @@ public class PDKClient {
+         SharedPreferences sharedPref = _context.getSharedPreferences(PDK_SHARED_PREF_FILE_KEY, Context.MODE_PRIVATE);
+         SharedPreferences.Editor editor = sharedPref.edit();
+         editor.putString(PDK_SHARED_PREF_TOKEN_KEY, accessToken);
+-        editor.commit();
++        editor.apply();
+     }
+ 
+     private static String restoreAccessToken() {","It will be better to use `commit()` on a separate thread, apart from the UI thread. The reason is `commit()` is synchronous while `apply()` is asynchronous. So in case it might not perform actions immediately as expected.",Why did you change thi
+9552,"@@ -123,10 +123,10 @@ func (q *queryImpl) validateTerminationState(
+ 		queryResult := terminationState.queryResult
+ 		validAnswered := queryResult.GetResultType().Equals(shared.QueryResultTypeAnswered) &&
+ 			queryResult.Answer != nil &&
+-			queryResult.ErrorMessage == nil
++			(queryResult.ErrorMessage == nil || *queryResult.ErrorMessage == """")
+ 		validFailed := queryResult.GetResultType().Equals(shared.QueryResultTypeFailed) &&
+ 			queryResult.Answer == nil &&
+-			queryResult.ErrorMessage != nil
++			(queryResult.ErrorMessage != nil && *queryResult.ErrorMessage != """")
+ 		if !validAnswered && !validFailed {
+ 			return errTerminationStateInvalid
+ 		}",Took me almost 4 hours to find this.,Why do we need this change?
+9553,"@@ -8,9 +8,9 @@ from .concat_dataset import ConcatDataset
+ from .repeat_dataset import RepeatDataset
+ from .extra_aug import ExtraAugmentation
+ 
++
+ __all__ = [
+     'CustomDataset', 'XMLDataset', 'CocoDataset', 'VOCDataset', 'GroupSampler',
+     'DistributedGroupSampler', 'build_dataloader', 'to_tensor', 'random_scale',
+     'show_ann', 'get_dataset', 'ConcatDataset', 'RepeatDataset',
+-    'ExtraAugmentation'
+-]
++    'ExtraAugmentation']",There should be only a single blank line between imports and `__all__`.,Why did you change this?
+9554,"@@ -194,7 +194,7 @@ public class TestCloudPseudoReturnFields extends SolrCloudTestCase {
+       SolrDocumentList docs = assertSearch(params(""q"", ""*:*"", ""rows"", ""10"", ""fl"",fl));
+       // shouldn't matter what doc we pick...
+       for (SolrDocument doc : docs) {
+-        assertEquals(fl + "" => "" + doc, 4, doc.size());
++        assertEquals(fl + "" => "" + doc, 5, doc.size());
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""id"") instanceof String);
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""val_i"") instanceof Integer);
+         assertTrue(fl + "" => "" + doc, doc.getFieldValue(""subject"") instanceof String);",Doc size increased by 1 since _root_ is also returned by queries.,Why did this change?
+9555,"@@ -822,8 +822,14 @@ def color_intervals(colors, levels, clip=None, N=255):
+         clmin, clmax = clip
+         lidx = int(round(N*((clmin-cmin)/interval)))
+         uidx = int(round(N*((cmax-clmax)/interval)))
+-        cmap = cmap[lidx:N-uidx]
+-    return cmap
++        uidx = N-uidx
++        if lidx == uidx:
++            uidx = lidx+1
++        cmap = cmap[lidx:uidx]
++        if clmin == clmax:
++            idx = np.argmin(np.abs(np.array(levels)-clmin))
++            clip = levels[idx: idx+2] if len(levels) > idx+2 else levels[idx-1: idx+1]
++    return cmap, clip
+ 
+ 
+ def dim_axis_label(dimensions, separator=', '):",Now the return value has changed (or at least now includes `clip`) it might be worth updating the docstring...,I think this should be `np.
+9556,"@@ -411,7 +411,7 @@ func TestRollDPoSConsensus(t *testing.T) {
+ 			require.NoError(t, err)
+ 			require.NoError(t, sf.Start(ctx))
+ 			for j := 0; j < numNodes; j++ {
+-				ws, err := sf.NewWorkingSet()
++				ws, err := sf.NewWorkingSet(nil)
+ 				require.NoError(t, err)
+ 				_, err = accountutil.LoadOrCreateAccount(ws, chainRawAddrs[j], big.NewInt(0))
+ 				require.NoError(t, err)","shadow: declaration of ""err"" shadows declaration at line 410 (from `govet`)",Why do we need to pass nil here?
+9557,"@@ -82,7 +82,13 @@ class Flashmessages extends AbstractHelper
+                 $this->fm->getMessages($ns), $this->fm->getCurrentMessages($ns)
+             );
+             foreach (array_unique($messages, SORT_REGULAR) as $msg) {
+-                $html .= '<div class=""' . $this->getClassForNamespace($ns) . '"">';
++                $html .= '<div class=""' . $this->getClassForNamespace($ns) . '""';
++                if (isset($msg['dataset'])) {
++                    foreach ($msg['dataset'] as $attr => $value) {
++                        $html .= ' data-' . $attr . '=""' . $value . '""';
++                    }
++                }
++                $html .= '>';
+                 // Advanced form:
+                 if (is_array($msg)) {
+                     // Use a different translate helper depending on whether",Should we be escaping $attr and/or $value here? Seems like htmlspecialchars() might be in order to be on the safe side.,I'm not sure if this is the best
+9558,"@@ -40,6 +40,7 @@ module Travis
+           def clone_args
+             args = ""--depth=#{depth}""
+             args << "" --branch=#{branch}"" unless data.ref
++	    args << "" #{quiet_o}""
+             args
+           end
+ ","why not remove the need for the `quiet_o` method and just add it similar to how the `--branch` is added? also, looks like the indenting is a little off",I think this should be `--quiet`
+9559,"@@ -96,8 +96,9 @@ public class FlowContainer {
+   private static final String CONF_DIR = ""conf"";
+   private static final String JOB_THREAD_COUNT = ""flow.num.job.threads"";
+   private static final String DEFAULT_LOG_CHUNK_SIZE = ""5MB"";
++  private static final String FLOW_EXECUTION_ID = ""FLOW_EXECUTION_ID"";
++  private static final String VERSION_SET_ID = ""VERSION_SET_ID"";
+   private static final int DEFAULT_LOG_NUM_FILES = 4;
+-  private static final int EXEC_ID_INDEX = 0;
+   private static final int DEFAULT_JOB_TREAD_COUNT = 10;
+   private static final boolean DEFAULT_USE_IN_MEMORY_KEYSTORE = false;
+   // Should validate proxy user",These variables are already created in constants. Please reuse those.,Why are we removing this?
+9560,"@@ -156,6 +156,10 @@ class Key(object):
+         if self.resp == None:
+             self.mode = 'r'
+ 
++            if self.version_id:
++                query_args = query_args or []
++                query_args.append('versionId=%s' % self.version_id)
++
+             provider = self.bucket.connection.provider
+             self.resp = self.bucket.connection.make_request(
+                 'GET', self.bucket.name, self.name, headers,","query_args is a string, not a list. Therefore you cannot call append to it. Also, line 986-989 of key.py already have code that is appending the versionId query parameter.",I don't think this is needed.
+9561,"@@ -548,12 +548,12 @@ func (f *Fs) newObjectWithInfo(ctx context.Context, remote string, info *api.Fil
+ 	if info != nil {
+ 		err := o.decodeMetaData(info)
+ 		if err != nil {
+-			return nil, err
++			return o, err
+ 		}
+ 	} else {
+ 		err := o.readMetaData(ctx) // reads info and headers, returning an error
+ 		if err != nil {
+-			return nil, err
++			return o, err
+ 		}
+ 	}
+ 	return o, nil",I think this change and the one below will break the integration tests which expect a `nil` object if `NewObject` fails.,Shouldn't this be `return nil
+9562,"@@ -1,6 +1,7 @@
+ # frozen_string_literal: true
+ 
+ require 'hocon'
++require 'bolt/error'
+ 
+ class TransportConfig
+   attr_accessor :host, :port, :ssl_cert, :ssl_key, :ssl_ca_cert, :ssl_cipher_suites,",Looks like this isn't used in this file?,Why do we need this?
+9563,"@@ -327,7 +327,10 @@ class PandasLikeSeries(_Frame):
+             sum = df_dropna._spark_count()
+             df = df._spark_withColumn('count', F._spark_col('count') / F._spark_lit(sum))
+ 
+-        return _col(df.set_index([self.name]))
++        hidden_name = 'index' if self.name != 'index' else 'level_0'
++        df.columns = [hidden_name, self.name]
++        df._metadata = Metadata(column_fields=[self.name], index_info=[(hidden_name, None)])
++        return _col(df)
+ 
+     @property
+     def _pandas_anchor(self) -> DataFrame:",why hidden name? How about `index_name`?,Can we use `set_index` here?
+9564,"@@ -367,6 +367,9 @@ ExWorkProcRetcode ExHdfsScanTcb::work()
+   char cursorId[8];
+   HdfsFileInfo *hdfo = NULL;
+   Lng32 openType = 0;
++  int hiveScanMode = 0;
++
++  hiveScanMode = CmpCommon::getDefaultLong(HIVE_SCAN_SPECIAL_MODE);
+   
+   while (!qparent_.down->isEmpty())
+     {","Usually, CQDs are not accessed directly in executor operators directly. It should be passed as a flag in the TDB. It is possible that the query is compiled in a different process, then this CQD setting won't be available in the executor layer.",I think it would be better to use `HIVE_SCAN_SPECIAL_MODE` here.
+9565,"@@ -477,9 +477,9 @@ func ShardID(shardID int32) ZapTag {
+ 	return NewInt32(""shard-id"", shardID)
+ }
+ 
+-// ShardItem returns tag for ShardItem
+-func ShardItem(shardItem interface{}) ZapTag {
+-	return NewAnyTag(""shard-item"", shardItem)
++// ShardContext returns tag for shard.Context
++func ShardContext(shard interface{}) ZapTag {
++	return NewAnyTag(""shard-context"", shard)
+ }
+ 
+ // ShardTime returns tag for ShardTime","This tag was broken, the value write to log was the memory address. Please verify that this actually write out meaningful content in log.",`shard.Context` -> `shard.Context`
+9566,"@@ -0,0 +1,9 @@
++""""""Checks import position rule with pep-0008""""""
++# pylint: disable=unused-import,relative-import,ungrouped-imports,import-error,no-name-in-module,relative-beyond-top-level,undefined-variable
++
++__author__ = 'some author'
++__email__ = 'some.author@some_email'
++__copyright__ = 'Some copyright'
++
++
++import sys",Why do you have to disable all of these checks?,Why do we need this?
+9567,"@@ -1639,6 +1639,7 @@ class CommandDispatcher:
+         """"""
+         try:
+             elem.set_value(text)
++            mainwindow.raise_window(objreg.last_focused_window())
+         except webelem.OrphanedError as e:
+             message.error('Edited element vanished')
+         except webelem.Error as e:","Just a note to myself: After merging this, I should edit the line after this one to use `message.error`, as raising a `CommandError` from here seems wrong!",Why do we need to raise the window here?
+9568,"@@ -1010,8 +1010,6 @@ GLOBAL_LABEL(FUNCNAME:)
+         mov      TEST_REG2_ASM, 1
+         /* xax statelessly restored here. */
+         mov      TEST_REG2_ASM, 2
+-        /* xax is dead, so initial aflags spill should not use slot. */
+-        mov      REG_XAX, 0
+         jmp      test28_done
+      test28_done:
+         /* Fail if aflags were not restored correctly. */","In this test, we want xax to be dead, so that aflags are not spilled to a slot.",Why did you remove this?
+9569,"@@ -54,7 +54,9 @@ type Options struct {
+ 
+ func newOptions() *Options {
+ 	return &Options{
+-		config: new(AgentConfig),
++		config: &AgentConfig{
++			EnablePrometheusMetrics: true,
++		},
+ 	}
+ }
+ ","I remember there were some misleading code about this but forgot to correct them. Although we initialize `config` here, it was discarded in `complete`, so I guess setting the default value here doesn't take effect. We should change L139-L140 as well to use the initialized `config`. So do antrea-controller.",Why do we need this?
+9570,"@@ -364,4 +364,13 @@ describe RSpec::Core::Formatters::BaseTextFormatter do
+       output.string.should =~ /, 100.0% of total time\):/
+     end
+   end
++  
++  describe ""custom_colors"" do
++    before { RSpec.configuration.stub(:color_enabled?) { true } }
++    it ""uses the custom success color"" do
++      RSpec.configuration.stub(:success_color).and_return(:cyan)
++      formatter.dump_summary(0,1,0,0)
++      output.string.should include(""\e[36m"")
++    end
++  end
+ end","Stubbin a value object (like `RSpec.configuration`) is a bit of a code smell, I think. You can just set `color_enabled` and `success_color` through the configuration APIs provided by `RSpec::Configuration` -- no need to stub. The `sandboxed` thing in `spec_helper.rb` takes care of preventing changes to the configuration object in one example from leaking into other examples.",Layout/SpaceAfterComma: 
+9571,"@@ -624,9 +624,14 @@ API.prototype.getBalanceFromPrivateKey = function(privateKey, coin, cb) {
+   var B = Bitcore_[coin];
+  
+   var privateKey = new B.PrivateKey(privateKey);
+-  var address = privateKey.publicKey.toAddress();
++
++  var address = privateKey.publicKey.toAddress().toString();
++  if (coin == 'bch') {
++    address = privateKey.publicKey.toAddress().toCashAddress().replace('bitcoincash:', '');
++  }
++
+   self.getUtxos({
+-    addresses: coin == 'bch' ? address.toLegacyAddress() : address.toString(),
++    addresses: address,
+   }, function(err, utxos) {
+     if (err) return cb(err);
+     return cb(null, _.sumBy(utxos, 'satoshis'));",you can use `toString(true)` that will work for BTC and remove the prefix for BCH.,I'm not sure if this is 
+9572,"@@ -652,9 +652,10 @@ class TabbedBrowser(tabwidget.TabWidget):
+ 
+         log.modes.debug(""Current tab changed, focusing {!r}"".format(tab))
+         tab.setFocus()
+-        for mode in [usertypes.KeyMode.hint, usertypes.KeyMode.insert,
+-                     usertypes.KeyMode.caret, usertypes.KeyMode.passthrough]:
+-            modeman.leave(self._win_id, mode, 'tab changed', maybe=True)
++        if not config.val.tabs.persist_mode_on_change:
++            for mode in [usertypes.KeyMode.hint, usertypes.KeyMode.insert,
++                         usertypes.KeyMode.caret, usertypes.KeyMode.passthrough]:
++                modeman.leave(self._win_id, mode, 'tab changed', maybe=True)
+         if self._now_focused is not None:
+             objreg.register('last-focused-tab', self._now_focused, update=True,
+                             scope='window', window=self._win_id)",This line is too long now - please break it after the comma.,I don't think this is the right place to do this. I think it should be in the `Tab` class.
+9573,"@@ -67,6 +67,7 @@ type StreamerDisconnecter interface {
+ type Stream interface {
+ 	io.ReadWriter
+ 	io.Closer
++	ResponseHeaders() Headers
+ 	Headers() Headers
+ 	FullClose() error
+ 	Reset() error","I find this addition to the interface a bit contentious. I think it would be cleaner to just return the response headers together with the new stream on `NewStream`. I.e. change the method signature for `NewStream` to be: `NewStream(ctx context.Context, overlay swarm.Address, headers p2p.Headers, protocolName, protocolVersion, streamName string) (p2p.Stream, p2p.Headers, error)`. I'd like to hear what other think. cc @zelig @janos",Why do we need this?
+9574,"@@ -222,6 +222,12 @@ class CartFacade
+ 
+         if ($cart !== null) {
+             $this->cartWatcherFacade->checkCartModifications($cart);
++
++            if ($cart->isEmpty()) {
++                $this->deleteCart($cart);
++
++                return null;
++            }
+         }
+ 
+         return $cart;","i hope there is some magic where isEmpty or some cron can strip all non listable products from cart, but since we have the situation tested it should be OK and also we'll see during tests",Why do we need to return null here?
+9575,"@@ -127,7 +127,7 @@ public class HiveIcebergFilterFactory {
+       case FLOAT:
+         return leaf.getLiteral();
+       case DATE:
+-        return daysFromTimestamp((Timestamp) leaf.getLiteral());
++        return daysFromDate((Date) leaf.getLiteral());
+       case TIMESTAMP:
+         return microsFromTimestamp((Timestamp) LITERAL_FIELD.get(leaf));
+       case DECIMAL:",I think we should check the type returned by `getLiteral` and handle that here. Then we won't need separate code for different versions.,Why is this change needed?
+9576,"@@ -131,13 +131,13 @@ func (s *HandlerTestSuite) TestFetchX509SVID() {
+ func (s *HandlerTestSuite) TestSendResponse() {
+ 	emptyUpdate := new(cache.WorkloadUpdate)
+ 	s.stream.EXPECT().Send(gomock.Any()).Times(0)
+-	err := s.h.sendResponse(emptyUpdate, s.stream)
++	err := s.h.sendX509SVIDResponse(emptyUpdate, s.stream)
+ 	s.Assert().Error(err)
+ 
+-	resp, err := s.h.composeResponse(s.workloadUpdate())
++	resp, err := s.h.composeX509SVIDResponse(s.workloadUpdate())
+ 	s.Require().NoError(err)
+ 	s.stream.EXPECT().Send(resp)
+-	err = s.h.sendResponse(s.workloadUpdate(), s.stream)
++	err = s.h.sendX509SVIDResponse(s.workloadUpdate(), s.stream)
+ 	s.Assert().NoError(err)
+ }
+ ",Tests for JWT handler functionality?,nit: rename `composeResponse` to `composeX509SVIDResponse`
+9577,"@@ -548,9 +548,6 @@ namespace Microsoft.AspNetCore.Server.KestrelTests
+                         ""POST / HTTP/1.1"",
+                         ""Content-Length: 3"",
+                         """",
+-                        ""101POST / HTTP/1.1"",
+-                        ""Content-Length: 3"",
+-                        """",
+                         ""204POST / HTTP/1.1"",
+                         ""Content-Length: 3"",
+                         """",","It's weird to set a 101 response and complete without writing anything, but this is still a valid test case right?",Why was this removed?
+9578,"@@ -207,6 +207,19 @@ class DefaultBucketViewTest(FormattedErrorMixin, BaseWebTest,
+             self.assertEqual(resp.body, response.body)
+ 
+ 
++class HelloViewTest(BaseWebTest, unittest.TestCase):
++
++    def test_returns_bucket_id_and_url_if_authenticated(self):
++        response = self.app.get('/', headers=self.headers)
++        self.assertEqual(response.json['user']['bucket'],
++                         '23bb0efc-e80d-829e-6757-79d41e16640f')
++
++    def test_flush_capability_if_enabled(self):
++        resp = self.app.get('/')
++        capabilities = resp.json['capabilities']
++        self.assertIn('default_bucket', capabilities)
++
++
+ class ReadonlyDefaultBucket(BaseWebTest, unittest.TestCase):
+ 
+     def get_app_settings(self, extras=None):",Should we move that information in the capability itself?,"I think you can use `self.assertIn('default_bucket', capab"
+9579,"@@ -18,6 +18,9 @@ class StatisticsElement(Chart):
+ 
+     __abstract = True
+ 
++    # Ensure Interface does not add an index
++    _auto_indexable_1d = False
++
+     def __init__(self, data, kdims=None, vdims=None, **params):
+         if isinstance(data, Element):
+             params.update(get_param_values(data))",Is this needed?,Why do we need this?
+9580,"@@ -163,7 +163,7 @@ func (r *ReconcileRemoteClusterIngress) Reconcile(request reconcile.Request) (re
+ 	// can't proceed if the secret(s) referred to doesn't exist
+ 	certBundleSecrets, err := r.getIngressSecrets(rContext)
+ 	if err != nil {
+-		rContext.logger.WithError(err).Error(""will need to retry until able to find all certBundle secrets"")
++		rContext.logger.Warningf(""will need to retry until able to find all certBundle secrets : %v"", err)
+ 		conditionErr := r.setIngressCertificateNotFoundCondition(rContext, true, err.Error())
+ 		if conditionErr != nil {
+ 			rContext.logger.WithError(conditionErr).Error(""unable to set IngressCertNotFound condition"")",This log should not be an error as it communicates that we need to retry till we get the cert information for remote ingress controller.,Why is this a warning?
+9581,"@@ -130,6 +130,8 @@ namespace Nethermind.Blockchain
+         BlockHeader[] FindHeaders(Keccak hash, int numberOfBlocks, int skip, bool reverse);
+         
+         void DeleteInvalidBlock(Block invalidBlock);
++
++        void Flush();
+         
+         event EventHandler<BlockEventArgs> NewBestSuggestedBlock;
+         event EventHandler<BlockEventArgs> BlockAddedToMain;","BlockTree alredy has a polluted API, this one seems very internal",Why do we need this?
+9582,"@@ -123,6 +123,7 @@ describe ""BoltSpec::Run"", ssh: true do
+ 
+     describe 'apply_manifest' do
+       it 'should apply a manifest file' do
++        bolt_inventory['features'] = ['puppet-agent']
+         with_tempfile_containing('manifest', ""notify { 'hello world': }"", '.pp') do |manifest|
+           results = apply_manifest(manifest.path, 'ssh')
+           results.each do |result|","Sorry, I realize my line numbers were probably off after you deleted your variables! I meant for this to go in the `before(:all) do` and `after(:all) do` blocks.",I think this should be
+9583,"@@ -195,7 +195,9 @@ public class ToParentBlockJoinQuery extends Query {
+           return null;
+         }
+       }
+-      return MatchesUtils.MATCH_WITH_NO_TERMS;
++
++      // TODO: which fields should be here?
++      return MatchesUtils.matchWithNoTerms(getQuery());
+     }
+   }
+ ",This bit I wasn't really sure about.,I'm not sure if this i
+9584,"@@ -87,6 +87,7 @@ function buildRules(grunt, options, commons, callback) {
+ 		var tags = options.tags ? options.tags.split(/\s*,\s*/) : [];
+ 		var rules = result.rules;
+ 		var checks = result.checks;
++		parseChecks(checks);
+ 
+ 		// Translate checks
+ 		if (locale && locale.checks) {","From the code, a check's metatdata was only added to `axe._load` if a rule used it. Since `role-none` and `role-presentation` were no longer used in any rule, their metadata was never added. This caused any translation file that passed translations for those checks to fail `axe.configure` with > ""Locale provided for unknown check: ""role-none"""" To fix I added this line to parse all checks regardless of if a rule uses it or not.",Why do we need to parse the checks here?
+9585,"@@ -740,7 +740,7 @@ class Package:
+             gc.enable()
+         return pkg
+ 
+-    def set_dir(self, lkey, path=None, meta=None):
++    def set_dir(self, lkey, path=None, meta=None, update_policy=""incoming""):
+         """"""
+         Adds all files from `path` to the package.
+ ","We should raise `ValueError` if `update_policy not in ['existing', 'incoming']`. (or `in Enum.__members__` or however we want to express legal values)",I don't think this is the right place to
+9586,"@@ -42,10 +42,11 @@ namespace MvvmCross.iOS.Platform
+             _applicationDelegate = applicationDelegate;
+         }
+ 
+-        protected MvxIosSetup(IMvxApplicationDelegate applicationDelegate, IMvxIosViewPresenter presenter)
++        protected MvxIosSetup(IMvxApplicationDelegate applicationDelegate, UIWindow window, IMvxIosViewPresenter presenter) : this (applicationDelegate, window)
+         {
+-            _presenter = presenter;
++            _window = window;
+             _applicationDelegate = applicationDelegate;
++            _presenter = presenter;
+         }
+ 
+         protected UIWindow Window => _window;","`_applicationDelegate` and `_window` are already set in the call for `: this (applicationDelegate, window)`, no need to assigning them again here",Shouldn't this be `_applicationDelegate`
+9587,"@@ -9,7 +9,7 @@ export function createContext(defaultValue) {
+ 		_id: '__cC' + i++,
+ 		_defaultValue: defaultValue,
+ 		Consumer(props, context) {
+-			return props.children(context);
++			return props.children(props.selector(context));
+ 		},
+ 		Provider(props) {
+ 			if (!this.getChildContext) {",We might not have a selector prop in the consumer,Shouldn't this be `props.selector`?
+9588,"@@ -386,7 +386,7 @@ namespace Nethermind.Blockchain.Processing
+                     break;
+                 }
+ 
+-                bool isFastSyncTransition = _blockTree.Head?.Header == _blockTree.Genesis && toBeProcessed.Number > 1;
++                bool isFastSyncTransition = (_blockTree.Head?.IsGenesis ?? false) && toBeProcessed.Number > 1;
+                 if (!isFastSyncTransition)
+                 {
+                     if (_logger.IsTrace) _logger.Trace($""Finding parent of {toBeProcessed.ToString(Block.Format.Short)}"");",IMO == true is more readable than ?? false,`_blockTree.Head?.IsGenesis ?? false`
+9589,"@@ -3,7 +3,7 @@ const test = require('./shared').assert,
+   setupDatabase = require('./shared').setupDatabase,
+   Script = require('vm'),
+   expect = require('chai').expect,
+-  normalizedFunctionString = require('bson/lib/bson/parser/utils').normalizedFunctionString,
++  normalizedFunctionString = require('bson/lib/parser/utils').normalizedFunctionString,
+   Buffer = require('safe-buffer').Buffer;
+ 
+ const {",feel free when editing sections like this to introduce modern features like object destructuring.,Why this change?
+9590,"@@ -1,3 +1,4 @@
++# coding: utf-8
+ # Copyright (c) 2006-2015 LOGILAB S.A. (Paris, FRANCE) <contact@logilab.fr>
+ # Copyright (c) 2012-2014 Google, Inc.
+ # Copyright (c) 2014-2016 Claudiu Popa <pcmanticore@gmail.com>",I think the correct pragma is `# -*- coding: utf-8 -*-,Why is this needed?
+9591,"@@ -58,6 +58,9 @@ from scapy.layers.inet import TCP
+ from scapy.packet import Raw
+ from scapy.packet import Packet, bind_layers
+ 
++from . import iec104, iec104_fields, iec104_information_elements, \
++    iec104_information_objects  # noqa: F401
++
+ IEC_104_IANA_PORT = 2404
+ 
+ # direction - from the central station to the substation","This fixes some import errors, due to the fact that this file has the same name than its module.",from . import iec104
+9592,"@@ -21,8 +21,9 @@ type Folder struct {
+ 	fs   *FS
+ 	list *FolderList
+ 
+-	handleMu sync.RWMutex
+-	h        *libkbfs.TlfHandle
++	handleMu       sync.RWMutex
++	h              *libkbfs.TlfHandle
++	hPreferredName string
+ 
+ 	folderBranchMu sync.Mutex
+ 	folderBranch   libkbfs.FolderBranch","I think we need to clear this out on logout, and update it on login, right?",Why is this a string?
+9593,"@@ -43,6 +43,8 @@ gboolean
+ ot_util_filename_validate (const char *name,
+                            GError    **error)
+ {
++  if (name == NULL)
++    return glnx_throw (error, ""Invalid NULL filename"");
+   if (strcmp (name, ""."") == 0)
+     return glnx_throw (error, ""Invalid self-referential filename '.'"");
+   if (strcmp (name, "".."") == 0)","I think normally we'd make this a precondition (using e.g. `g_return_val_if_fail`), but meh, this works too!",Shouldn't this be `if
+9594,"@@ -34,5 +34,5 @@ public final class Const {
+ 
+     public static final String SRC_MICROSERVICE = ""x-cse-src-microservice"";
+ 
+-    public static final String DEST_MICROSERVICE = ""x-cse-dest-microservice"";
++    public static final String TARGET_MICROSERVICE = ""x-cse-target-microservice"";
+ }",Is this header used by other outside service?,public static final S
+9595,"@@ -89,10 +89,3 @@ class TestZipFolder(BZTestCase):
+         result_tree = set(filename[len(destination):] for filename in get_files_recursive(destination))
+         original_tree = set(filename[len(source):] for filename in get_files_recursive(source))
+         self.assertEqual(result_tree, original_tree)
+-
+-    def test_no_work_prov(self):
+-        obj = Unpacker()
+-        obj.engine = EngineEmul()
+-        obj.engine.config[Provisioning.PROV] = 'cloud'
+-        obj.parameters.merge({Unpacker.FILES: ['notexists.zip']})
+-        obj.prepare()",that's fine by me to have simple test for provisioning check,Why was this test rem
+9596,"@@ -83,7 +83,7 @@ public class TriggerBasedScheduleLoader implements ScheduleLoader {
+     ConditionChecker checker =
+         new BasicTimeChecker(""BasicTimeChecker_1"", s.getFirstSchedTime(),
+             s.getTimezone(), s.isRecurring(), s.skipPastOccurrences(),
+-            s.getPeriod());
++            s.getPeriod(), s.getCronExpression());
+     checkers.put(checker.getId(), checker);
+     String expr = checker.getId() + "".eval()"";
+     Condition cond = new Condition(checkers, expr);",These two methods seem to be identical except the names. Any idea why two methods are needed?,Why not use `s.getCronExpression()`?
+9597,"@@ -0,0 +1,14 @@
++#!/usr/bin/env python
++
++
++import sys
++import os
++sys.path.append(os.path.join(os.path.dirname(os.path.realpath(__file__)), "".."", ""..""))
++from influxdb import InfluxDBClient
++import config
++
++try:
++    i = InfluxDBClient(host=config.INFLUX_HOST, port=config.INFLUX_PORT, database=config.INFLUX_TEST_DB)
++    i.create_database(config.INFLUX_TEST_DB)
++except Exception as e:
++    print(""Creating influx DB failed: "", e)",I don't see much difference between this and `create_db` module. How about having a function with a `database` argument?,I think this should be `config.INFLU
+9598,"@@ -183,7 +183,7 @@ class AnalyticsDashboardWidget extends Component {
+ 							</div>
+ 							{ /* Data issue: on error display a notification. On missing data: display a CTA. */ }
+ 							{ ! receivingData && (
+-								error ? getDataErrorComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), true, true, true )
++								error ? getDataErrorComponent( 'analytics', _x( 'Analytics', 'Service name', 'google-site-kit' ), error, true, true, true, errorObj ) : getNoDataComponent( _x( 'Analytics', 'Service name', 'google-site-kit' ), true, true, true )
+ 							) }
+ 							<div className={ classnames(
+ 								'mdc-layout-grid__cell',","See above, no need to pass the module name.",Why do we need to pass `errorObj` he
+9599,"@@ -316,7 +316,7 @@ class LGBMModel(_LGBMModelBase):
+         group : array-like or None, optional (default=None)
+             Group data of training data.
+         eval_set : list or None, optional (default=None)
+-            A list of (X, y) tuple pairs to use as a validation sets.
++            A list of (X, y) tuple pairs to use as a validation set.
+         eval_names : list of strings or None, optional (default=None)
+             Names of eval_set.
+         eval_sample_weight : list of arrays or None, optional (default=None)","LightGBM supports multiple validation sets, so please leave `sets`.",I don't think this is correct. It sh
+9600,"@@ -19,13 +19,14 @@ package org.openqa.selenium.remote;
+ 
+ import com.google.common.collect.ImmutableMap;
+ 
++import org.openqa.selenium.DeviceRotation;
+ import org.openqa.selenium.Rotatable;
+ import org.openqa.selenium.ScreenOrientation;
+ 
+ import java.lang.reflect.Method;
+ 
+ public class AddRotatable implements AugmenterProvider {
+-
++    
+   public Class<?> getDescribedInterface() {
+     return Rotatable.class;
+   }","you don't need to create a enum for this, java allows you to switch on a string ;) (since java 7?)",Why this change?
+9601,"@@ -1955,15 +1955,7 @@ context 'Substitutions' do
+       end
+ 
+       test 'should passthrough math macro inside another passthrough' do
+-        input = 'the text `asciimath:[x = y]` should be passed through as +literal+ text'
+-        para = block_from_string input, attributes: { 'compat-mode' => '' }
+-        assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+-
+-        input = 'the text [x-]`asciimath:[x = y]` should be passed through as `literal` text'
+-        para = block_from_string input
+-        assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+-
+-        input = 'the text `+asciimath:[x = y]+` should be passed through as `literal` text'
++        input = 'the text `++asciimath:[x = y]++` should be passed through as `literal` text'
+         para = block_from_string input
+         assert_equal 'the text <code>asciimath:[x = y]</code> should be passed through as <code>literal</code> text', para.content
+       end",What is this obscure syntax anyway? o.O,Why was this tes
+9602,"@@ -756,6 +756,10 @@ class SPRegion(PyRegion):
+     return spec
+ 
+ 
++  def getAlgorithm(self):
++    return self._sfdr
++
++
+   def getParameter(self, parameterName, index=-1):
+     """"""
+       Get the value of a NodeSpec parameter. Most parameters are handled","I think we should have one for the CLA Classifier, and KNNClassifier as well. And how about RecordSensor?",Why do we need t
+9603,"@@ -0,0 +1,9 @@
++package com.fsck.k9.fragment;
++import android.database.Cursor;
++import android.view.ContextMenu;
++/**
++ Created by Kamil Rajtar on 05.11.17. */
++
++public interface ICursorContextMenuSupplier{
++	void getCursorMenu(ContextMenu menu,Cursor cursor);
++}",Missing new line.,Missing copyrigh
+9604,"@@ -17,6 +17,9 @@ const populateModelSymbol = require('../symbols').populateModelSymbol;
+ const schemaMixedSymbol = require('../../schema/symbols').schemaMixedSymbol;
+ 
+ module.exports = function getModelsMapForPopulate(model, docs, options) {
++  if (model.schema.base.options.strictPopulate == false && options.strictPopulate == null) {
++    options.strictPopulate = model.schema.base.options.strictPopulate;
++  }
+   let doc;
+   const len = docs.length;
+   const map = [];","`model.schema.base.options.strictPopulate != null`. Why hardcoding false? Also, `model.base.options` should work and be shorter. Finally, any way to move this up to the `populate()` function in `model.js` that calls `getModelsMapForPopulate()` and shallow clone the object before modifying? A bit random to modify this option here.",I think this should be `options.strictPopulate === undefined`
+9605,"@@ -35,10 +35,10 @@ namespace Nethermind.Core.Test
+             ISpecProvider specProvider = new CustomSpecProvider((0, releaseSpec));
+ 
+             BlockValidator blockValidator = new BlockValidator(txValidator, AlwaysValidHeaderValidator.Instance, AlwaysValidOmmersValidator.Instance, specProvider, LimboLogs.Instance);
+-            bool noiseRemoved = blockValidator.ValidateSuggestedBlock(Build.A.Block.TestObject);
++            bool noiseRemoved = blockValidator.ValidateSuggestedBlock(Builders.Build.A.Block.TestObject);
+             Assert.True(noiseRemoved);
+             
+-            bool result = blockValidator.ValidateSuggestedBlock(Build.A.Block.WithOmmers(Build.A.BlockHeader.TestObject).TestObject);
++            bool result = blockValidator.ValidateSuggestedBlock(Builders.Build.A.Block.WithOmmers(Builders.Build.A.BlockHeader.TestObject).TestObject);
+             Assert.False(result);
+         }
+     }",We now have Prepare.A/Build.A/Builders.Build.A - what are the differences?,Why is this change needed?
+9606,"@@ -51,6 +51,12 @@ module Asciidoctor
+       append_newline ? %(#{str}#{LF}) : str
+     end
+ 
++    def preserve_backslash str
++      str = str.
++        gsub(/\\/, '\\e')
++      str
++    end
++
+     def skip_with_warning node, name = nil
+       warn %(asciidoctor: WARNING: converter missing for #{name || node.node_name} node in manpage backend)
+       nil","Could you reduce this to one line and change the first argument to a single quoted backslash string? Perhaps we can add this as an option named `:preserve_backslash` to the manify method. That way, we don't need an extra method in the first two cases. Obviously, we still need it for the inline case.",Why do we need this?
+9607,"@@ -49,10 +49,10 @@ var _ = Context(""with initialized Felix, etcd datastore, 3 workloads"", func() {
+ 		defaultProfile := api.NewProfile()
+ 		defaultProfile.Name = ""default""
+ 		defaultProfile.Spec.LabelsToApply = map[string]string{""default"": """"}
+-		defaultProfile.Spec.EgressRules = []api.Rule{{Action: ""allow""}}
++		defaultProfile.Spec.EgressRules = []api.Rule{{Action: api.Allow}}
+ 		defaultProfile.Spec.IngressRules = []api.Rule{{
+-			Action: ""allow"",
+-			Source: api.EntityRule{Tag: ""default""},
++			Action: api.Allow,
++			Source: api.EntityRule{Selector: ""default == ''""},
+ 		}}
+ 		_, err := client.Profiles().Create(utils.Ctx, defaultProfile, utils.NoOptions)
+ 		Expect(err).NotTo(HaveOccurred())",`has(default)` i think is the preferred way of doing this,Why do we need this change?
+9608,"@@ -235,7 +235,7 @@ public class BaseRewriteManifests extends SnapshotProducer<RewriteManifests> imp
+               keptManifests.add(manifest);
+             } else {
+               rewrittenManifests.add(manifest);
+-              try (ManifestReader reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
++              try (ManifestReader<DataFile> reader = ManifestFiles.read(manifest, ops.io(), ops.current().specsById())
+                   .select(Arrays.asList(""*""))) {
+                 reader.liveEntries().forEach(
+                     entry -> appendEntry(entry, clusterByFunc.apply(entry.file()), manifest.partitionSpecId())",Does this mean we can only do rewrites if there are no `DeleteFile`'s?,Why is this change necessary?
+9609,"@@ -96,10 +96,12 @@ class InstallTest(QuiltTestCase):
+         """"""
+         table_data, table_hash = self.make_table_data()
+         file_data, file_hash = self.make_file_data()
+-        contents, contents_hash = self.make_contents(table=table_hash, file=file_hash)
++        contents, contents_hash = self.make_contents(table=table_hash,
++                                                     file=file_hash)
+ 
+         self._mock_tag('foo/bar', 'latest', contents_hash, team='qux')
+-        self._mock_package('foo/bar', contents_hash, '', contents, [table_hash, file_hash], team='qux')
++        self._mock_package('foo/bar', contents_hash, '',
++                           contents, [table_hash, file_hash], team='qux')
+         self._mock_s3(table_hash, table_data)
+         self._mock_s3(file_hash, file_data)
+ ","Actually, these are fine; we're using 110 as the max line length. (it's also set in the .pylintrc)",Why did you change this?
+9610,"@@ -17,6 +17,7 @@ package main
+ import (
+ 	. ""github.com/onsi/ginkgo""
+ 	. ""github.com/onsi/gomega""
++
+ 	""github.com/projectcalico/felix/k8sfv/leastsquares""
+ )
+ ","No issue here, but what tool are you running to put these imports into the preferred organization? I have configuration to run `goimports` whenever I save a file, but it appears that that is not quite sufficient.","""github.com/sirupsen/logrus"""
+9611,"@@ -131,6 +131,7 @@ public class DTAFileReaderSpi extends TabularDataFileReaderSpi{
+ 
+     @Override
+     public boolean canDecodeInput(BufferedInputStream stream) throws IOException {
++    	//who closes this stream?
+         if (stream ==null){
+             throw new IllegalArgumentException(""stream == null!"");
+         }",guessing this method could/should close it but I didn't see where it was getting called.,Why is this needed?
+9612,"@@ -50,11 +50,13 @@ public class ExecutableFlow extends ExecutableFlowBase {
+   public static final String AZKABANFLOWVERSION_PARAM = ""azkabanFlowVersion"";
+   public static final String IS_LOCKED_PARAM = ""isLocked"";
+   public static final String FLOW_LOCK_ERROR_MESSAGE_PARAM = ""flowLockErrorMessage"";
++  public static final String EXECUTION_SOURCE = ""execution_source"";
+ 
+   private final HashSet<String> proxyUsers = new HashSet<>();
+   private int executionId = -1;
+   private int scheduleId = -1;
+   private int projectId;
++  private String executionSource;
+   private String projectName;
+   private String lastModifiedUser;
+   private int version;",Could you please use `camelCase` in the property name to follow the naming convention used in the rest of the properties?,Why do we need this?
+9613,"@@ -12,7 +12,7 @@ import (
+ )
+ 
+ const (
+-	fmtErrPublicSubnetsFromEnv  = ""get public subnet IDs from environment %s: %w""
++	fmtErrPublicSubnetsFromEnv  = ""get public subnet IDs from environment %s: %w ""
+ 	fmtErrSecurityGroupsFromEnv = ""get security groups from environment %s: %w""
+ 
+ 	envSecurityGroupCFNLogicalIDTagKey   = ""aws:cloudformation:logical-id""",Can we revert this change? looks like an extra space was added at the end  ,Why the space?
+9614,"@@ -222,6 +222,9 @@ public class RubyPackageMetadataTransformer implements ModelToViewTransformer {
+                 productConfig, ImportSectionView.newBuilder().build(), surfaceNamer))
+         .hasSmokeTests(hasSmokeTests)
+         .versionPath(surfaceNamer.getVersionIndexFileImportName())
++        .versionNamespace(
++            surfaceNamer.getNamespace(
++                new InterfaceView().getElementIterable(model).iterator().next()))
+         .build();
+   }
+ ","This just grabs any one of the proto services defined in the API, right? What happens when there are multiple (like with PubSub)?",Why do we need this?
+9615,"@@ -40,7 +40,9 @@ def define_violation(model_name, dbengine):
+     """"""
+ 
+     base = declarative_base()
+-    violations_tablename = '{}_violations'.format(model_name)
++    # pylint: disable=too-many-format-args
++    violations_tablename = 'violations'.format(model_name)
++    # pylint: enable=too-many-format-args
+ 
+     class Violation(base):
+         """"""Row entry for a violation.""""""",Remove the pylint disable and remove the .format() from the string. The tablename is just 'violations',Why do we need to di
+9616,"@@ -8,6 +8,16 @@ class Trail < ActiveRecord::Base
+ 
+   friendly_id :name, use: [:slugged, :finders]
+ 
++  # Override setters so it preserves the ordering
++  def exercise_ids=(new_exercise_ids)
++    super
++    new_exercise_ids = new_exercise_ids.reject(&:blank?).map(&:to_i)
++
++    new_exercise_ids.each_with_index do |exercise_id, index|
++      steps.where(exercise_id: exercise_id).update_all(position: index + 1)
++    end
++  end
++
+   def steps_remaining_for(user)
+     ExerciseWithProgressQuery.
+       new(user: user, exercises: exercises).",Will this implementation allow you to add new exercises to the trail?,I'm not sure if this is the best way to do this. I think it would be better to do this in the model instead.
+9617,"@@ -76,9 +76,17 @@ func trapSignalsPosix() {
+ 					caddyfileToUse = newCaddyfile
+ 				}
+ 
++				// Backup old event hooks
++				oldEventHooks := cloneEventHooks()
++
++				// Purge the old event hooks
++				purgeEventHooks()
++
+ 				// Kick off the restart; our work is done
+ 				_, err = inst.Restart(caddyfileToUse)
+ 				if err != nil {
++					eventHooks = oldEventHooks
++
+ 					log.Printf(""[ERROR] SIGUSR1: %v"", err)
+ 				}
+ ","Actually there is race condition here, because pointer assignment isn't atomic on some platform. But this is a rare case we should hit, we can just let it go for now. Maybe this is one of the TODO list.",Why do we need to do this?
+9618,"@@ -181,6 +181,10 @@ void lbann::distributed_io_buffer::calculate_num_iterations_per_epoch(int num_mo
+     max_mini_batch_size = data_reader->get_num_data();
+   }
+ 
++  bool partitioned = data_reader->is_partitioned();
++  //@todo ""if (partitioned)"" conditionals below assume one processor per model;
++  //      this needs to be revisited for cases with multiple cpus per model
++
+   /// Check to make sure that there is enough data for all of the parallel readers
+   int num_parallel_readers_per_model = compute_max_num_parallel_readers(data_reader->get_num_data(), max_mini_batch_size, m_requested_max_num_parallel_readers);
+   data_reader->set_num_parallel_readers(num_parallel_readers_per_model);",We should check somewhere here and in the partitioned_io_buffer that the max_mini_batch_size is properly computed for each model and that it is not aggregate (sum) for all models. The global/max_mini_batch_size should be as specified by the user in the prototext/cmd line.,"I don't think this is the right place to do this. If we want to do this, we need to make sure that we have e"
+9619,"@@ -132,7 +132,7 @@ const Capability = {
+    * Defines how the driver should handle unexpected alerts. The value should
+    * be one of ""accept"", ""dismiss"", or ""ignore"".
+    */
+-  UNEXPECTED_ALERT_BEHAVIOR: 'unexpectedAlertBehavior',
++  UNEXPECTED_ALERT_BEHAVIOUR: 'unexpectedAlertBehaviour',
+ 
+   /** Defines the browser version. */
+   VERSION: 'version'","you can change the string value, but not the code constant",This should be `UNEXPECTED_ALERT_BEHAVIOR`.
+9620,"@@ -27,10 +27,10 @@ func TestBech32(t *testing.T) {
+ 		{""split1checkupstagehandshakeupstreamerranterredcaperred2y9e2w"", false},                   // invalid checksum
+ 		{""s lit1checkupstagehandshakeupstreamerranterredcaperredp8hs2p"", false},                   // invalid character (space) in hrp
+ 		{""spl"" + string(127) + ""t1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false}, // invalid character (DEL) in hrp
+-		{""split1cheo2y9e2w"", false}, // invalid character (o) in data part
+-		{""split1a2y9w"", false},      // too short data part
+-		{""1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false}, // empty hrp
+-		{""li1dgmt3"", false}, // Too short checksum
++		{""split1cheo2y9e2w"", false},                                                               // invalid character (o) in data part
++		{""split1a2y9w"", false},                                                                    // too short data part
++		{""1checkupstagehandshakeupstreamerranterredcaperred2y9e3w"", false},                        // empty hrp
++		{""li1dgmt3"", false},                                                                       // Too short checksum
+ 		{""11qqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqsqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqqc8247j"", false}, // overall max length exceeded
+ 	}
+ ",File is not `goimports`-ed,Why did you change this?
+9621,"@@ -36,6 +36,6 @@ public class AzkabanExecServerModule extends AbstractModule {
+     bind(AzkabanExecutorServer.class).in(Scopes.SINGLETON);
+     bind(TriggerManager.class).in(Scopes.SINGLETON);
+     bind(FlowRunnerManager.class).in(Scopes.SINGLETON);
+-
++    // TODO: add ExecMetrics when guicy
+   }
+ }",Is this Todo necessary?,Why do we need this?
+9622,"@@ -108,10 +108,7 @@ class ErrorHandler(object):
+                         message = value[""value""]
+                         if not isinstance(message, basestring):
+                             value = message
+-                            try:
+-                                message = message['message']
+-                            except TypeError:
+-                                message = None
++                            message = message.get('message', None)
+                     else:
+                         message = value.get('message', None)
+                 except ValueError:",I would recommend to leave out `None` because None is already the default.,Why did you remove this?
+9623,"@@ -97,6 +97,10 @@ const (
+ 
+ 	taskIDFlag    = ""task-id""
+ 	containerFlag = ""container""
++
++	valuesFlag        = ""values""
++	overwriteFlag     = ""overwrite""
++	inputFilePathFlag = ""cli-input-yaml""
+ )
+ 
+ // Short flag names.","I may have missed previous discussion on this; apologies if that's the case. What do you think about just `input-yaml`, without the `cli-`?",nit: `cli-input-yaml` ->
+9624,"@@ -57,13 +57,14 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets.Internal
+ 
+         public async Task StartAsync(IConnectionHandler connectionHandler)
+         {
++            Exception error = null;
+             try
+             {
+                 connectionHandler.OnConnection(this);
+ 
+                 // Spawn send and receive logic
+                 Task receiveTask = DoReceive();
+-                Task sendTask = DoSend();
++                Task<Exception> sendTask = DoSend();
+ 
+                 // If the sending task completes then close the receive
+                 // We don't need to do this in the other direction because the kestrel",Nit: rename to sendError.,Why do we need this change?
+9625,"@@ -7,6 +7,10 @@ Makes functions in .tools.command accessible directly from quilt.
+ # None: CLI params have not yet been parsed to determine mode.
+ _DEV_MODE = None
+ 
++# Suppress numpy warnings for Python 2.7
++import warnings
++warnings.filterwarnings(""ignore"", message=""numpy.dtype size changed"")
++
+ 
+ # Normally a try: except: block on or in main() would be better and simpler,
+ # but we load a bunch of external modules that take a lot of time, during which",`pylint` wants to know why this `import` isn't at the top of the file; and it's kinda right,Why is this needed?
+9626,"@@ -0,0 +1,19 @@
++package de.danoeh.antennapod.core.feed;
++
++public class FeedUrlNotFoundException extends RuntimeException {
++    private final String artistName;
++    private final String trackName;
++
++    public FeedUrlNotFoundException(String url, String trackName) {
++        this.artistName = url;
++        this.trackName = trackName;
++    }
++
++    public String getArtistName() {
++        return artistName;
++    }
++
++    public String getTrackName() {
++        return trackName;
++    }
++}","To me, using a `RuntimeException` for this feels a bit weird. I would just extend `Exception`, or maybe even `IoException`. Could you also please overwrite the `getMessage` function to return something like `""Result does not specify a feed url""`?",Why do we need this class?
+9627,"@@ -88,7 +88,8 @@ func convertStorage(ctx context.Context, msg *cepubsub.Message, sendMode ModeTyp
+ 		}
+ 	}
+ 	event.SetDataContentType(*cloudevents.StringOfApplicationJSON())
+-	event.SetData(msg.Data)
++	event.Data = msg.Data
++	event.DataEncoded = true
+ 	// Attributes are extensions.
+ 	if msg.Attributes != nil && len(msg.Attributes) > 0 {
+ 		for k, v := range msg.Attributes {",what was the issue here? why did you have to directly set?,Why is this needed?
+9628,"@@ -226,10 +226,8 @@ func (c *Command) proposals() {
+ 	for _, proposal := range proposals {
+ 		country := proposal.ServiceDefinition.LocationOriginate.Country
+ 		var countryString string
+-		if country != nil {
+-			countryString = *country
+-		} else {
+-			countryString = ""Unknown""
++		if len(country) == 0 {
++			country = ""Unknown""
+ 		}
+ 		msg := fmt.Sprintf(""- provider id: %v, proposal id: %v, country: %v"", proposal.ProviderID, proposal.ID, countryString)
+ 		info(msg)",I'm confusied - Isn't `countryString` left empty if `len(country)` != 0?,Why is this change needed?
+9629,"@@ -53,7 +53,7 @@ DesktopSwitch::DesktopSwitch(const ILXQtPanelPluginStartupInfo &startupInfo) :
+     mLabelType(static_cast<DesktopSwitchButton::LabelType>(-1))
+ {
+     m_buttons = new QButtonGroup(this);
+-    connect (m_pSignalMapper, SIGNAL(mapped(int)), this, SLOT(setDesktop(int)));
++    connect (m_pSignalMapper, QOverload<int>::of(&QSignalMapper::mapped), this, &DesktopSwitch::setDesktop);
+ 
+     mLayout = new LXQt::GridLayout(&mWidget);
+     mWidget.setLayout(mLayout);","Would you please update this by using `#if (QT_VERSION >= QT_VERSION_CHECK(5,15,0))` and `QSignalMapper::mappedInt` for Qt >= 5.15?",I don't think you need the
+9630,"@@ -262,6 +262,8 @@ func PopulateInstallRoot(installChroot *safechroot.Chroot, packagesToInstall []s
+ 		filesystemPkg = ""filesystem""
+ 	)
+ 
++	defer stopGPGAgent(installChroot)
++
+ 	ReportAction(""Initializing RPM Database"")
+ 
+ 	installRoot := filepath.Join(rootMountPoint, installChroot.RootDir())","This type of change opens a question on how we can cleanly shutdown or prevent all running agents so we do not run the risk of an agent holding kernel mountpoints, which can cause unsafe unmount/chroot exit. Will open a github issue to track this. This specific change itself is fine. It is a pointed change specifically for stopping the offending agent.",Why do we need this?
+9631,"@@ -3,6 +3,8 @@
+ 
+ package io.protostuff.runtime.model;
+ 
++import com.google.protobuf.CodedOutputStream;
++
+ public final class ModelProtobuf {
+   private ModelProtobuf() {
+   }","this file is model generated by protobuf, just for compatible test it's better not change it.",import io.protostuff.proto
+9632,"@@ -8,8 +8,8 @@ class Analytics
+     @user = user
+   end
+ 
+-  def track_cancelled
+-    track(event: ""Cancelled"", properties: {})
++  def track_cancelled(reason)
++    track(event: ""Cancelled"", properties: { reason: reason })
+   end
+ 
+   def track_updated","It turns out we can send the reason as the property to Segment on the event. Then we can do whatever we want with it. In this case, I think we'll fire a web hook to Zapier which will add a note or message on the user in Intercom.",Do we need to pass the `reason` here?
+9633,"@@ -0,0 +1,17 @@
++class PromotedCatalog
++  def initialize(catalog)
++    @catalog = catalog
++  end
++
++  def method_missing(message, *arguments)
++    catalog.send(message, *arguments).promoted
++  end
++
++  def respond_to_missing?(message, include_all = false)
++    catalog.send(:respond_to?, message, include_all)
++  end
++
++  private
++
++  attr_reader :catalog
++end",This class is very similar to `Catalog`. Is there a way to have this class compose a `Catalog` instance or extract a common class which they can both compose?,Why do we need this?
+9634,"@@ -164,9 +164,7 @@ TEST(""pull as device usm from host-allocated homogen table"") {
+         row_accessor<const float>{ data } //
+             .pull(q, { 1, 3 }, sycl::usm::alloc::device);
+ 
+-    const auto data_arr_host =
+-        la::matrix<float>::wrap(q, data_arr_device.get_data(), { row_count, column_count })
+-            .to_host();
++    const auto data_arr_host = la::matrix<float>::wrap(data_arr_device).to_host();
+     const float* data_arr_host_ptr = data_arr_host.get_data();
+ 
+     REQUIRE(data_arr_host_ptr[0] == 3.0f);",Why did you decide to drop the `queue` from parameters of `wrap` function? The agreement was that all functions for DPC++ case that accept non-host-accessible memory shall accept the queue directly.,Why do we need this change?
+9635,"@@ -340,6 +340,11 @@ module RSpec
+       # @return [Symbol]
+       add_setting :detail_color
+ 
++      # @macro add_setting
++      # Hyperlink failed examples (default: `false`).
++      # @return [Boolean]
++      add_setting :hyperlink
++
+       # @macro add_setting
+       # Don't print filter info i.e. ""Run options: include {:focus=>true}""
+       # (default `false`).","I think this is a bad name, as its not clear what it does by name alone. If we merge this it should be something like `use_links_to_files_in_output` and should take either a custom scheme like `rspec` or default to `file`",This should be `add_setting :hyperlin
+9636,"@@ -65,6 +65,7 @@ public final class BaselineErrorProne implements Plugin<Project> {
+                                 .configure(ErrorProneOptions.class, errorProneOptions -> {
+                                     errorProneOptions.check(""Slf4jLogsafeArgs"", CheckSeverity.OFF);
+                                     errorProneOptions.check(""PreferSafeLoggableExceptions"", CheckSeverity.OFF);
++                                    errorProneOptions.check(""Slf4jConstantLogMessage"", CheckSeverity.OFF);
+                                 }));
+             });
+ ","Arguably this is actually still valuable for perf, maybe it should just be a warning?",Why is this disabled?
+9637,"@@ -35,6 +35,14 @@ func (s *server) peerConnectHandler(w http.ResponseWriter, r *http.Request) {
+ 		return
+ 	}
+ 
++	s.Addressbook.Put(address, addr)
++	if err := s.TopologyDriver.AddPeer(address); err != nil {
++		s.Logger.Debugf(""debug api: topologyDriver.AddPeer %s: %v"", addr, err)
++		s.Logger.Errorf(""unable to connect to peer %s"", addr)
++		jsonhttp.InternalServerError(w, err)
++		return
++	}
++
+ 	jsonhttp.OK(w, peerConnectResponse{
+ 		Address: address.String(),
+ 	})",didn't way say that the topology driver will actually insert the entries to the address book?,I think this should b
+9638,"@@ -24,11 +24,13 @@ import { removeNode } from '../util';
+  * Fragments that have siblings. In most cases, it starts out as `oldChildren[0]._dom`.
+  */
+ export function diffChildren(parentDom, newParentVNode, oldParentVNode, context, isSvg, excessDomChildren, mounts, ancestorComponent, oldDom) {
+-	let childVNode, i, j, p, index, oldVNode, newDom,
++	let childVNode, i, j, oldVNode, newDom,
+ 		nextDom, sibDom, focus;
+ 
+ 	let newChildren = newParentVNode._children || toChildArray(newParentVNode.props.children, newParentVNode._children=[], coerceToVNode, true);
+-	let oldChildren = oldParentVNode!=null && oldParentVNode!=EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR;
++	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
++	// as EMPTY_OBJ._children should be `undefined`.
++	let oldChildren = oldParentVNode!=null && oldParentVNode._children || EMPTY_ARR;
+ 
+ 	let oldChildrenLength = oldChildren.length;
+ ",This seems safe to me. My guess is the original checks were a combination of before + after `oldParentVNode` became reliably a `(vnode | null)`.,I don't think this is
+9639,"@@ -148,6 +148,10 @@ std::string FlatCompiler::GetUsageString(const char *program_name) const {
+     ""  --conform FILE         Specify a schema the following schemas should be\n""
+     ""                         an evolution of. Gives errors if not.\n""
+     ""  --conform-includes     Include path for the schema given with --conform PATH\n""
++    ""  --filename-suffix      The suffix appended to the generated file names.\n""
++    ""                         Default is '_generated'.\n""
++    ""  --filename-ext         The extension appended to the generated file names.\n""
++    ""                         Default is language-specific (e.g., '.h' for C++)\n""
+     ""  --include-prefix       Prefix this path to any generated include statements.\n""
+     ""    PATH\n""
+     ""  --keep-prefix          Keep original prefix of schema include statement.\n""",also in the `.md` please.,I think this should b
+9640,"@@ -7,7 +7,9 @@ module Unix::Pkg
+   end
+ 
+   def install_package name
+-    if self['platform'] =~ /(fedora)|(centos)|(el)/
++    if self['platform'] =~ /(el-4)|(redhat-4)/
++      @logger.debug(""Package installation not supported on rhel4"")
++    elsif self['platform'] =~ /(fedora)|(centos)|(el)|(redhat)/
+       execute(""yum -y install #{name}"")
+     elsif self['platform'] =~ /(ubuntu)|(debian)/
+       execute(""apt-get update"")",RHEL is an acronym and is usually all caps. Why are you adding a redhat regex matcher?,I don't think this should be a debug message.
+9641,"@@ -193,16 +193,6 @@ public class VectorizedColumnIterator extends BaseColumnIterator {
+     }
+   }
+ 
+-  public class FixedWidthTypeBinaryBatchReader extends BatchReader {
+-    @Override
+-    protected int nextBatchOf(
+-        final FieldVector vector, final int expectedBatchSize, final int numValsInVector, final int typeWidth,
+-        NullabilityHolder holder) {
+-      return vectorizedPageIterator.fixedWidthBinaryPageReader().nextBatch(vector, expectedBatchSize, numValsInVector,
+-          typeWidth, holder);
+-    }
+-  }
+-
+   public class BooleanBatchReader extends BatchReader {
+     @Override
+     protected int nextBatchOf(",Maybe I am daft but it looks like you removed fixed width readers but I don't see where you added any readers?,Why is this being removed?
+9642,"@@ -16,6 +16,14 @@ import (
+ 
+ const DefaultManifestType = ManifestMantarayContentType
+ 
++const (
++	RootPath                      = ""/""
++	WebsiteIndexDocumentSuffixKey = ""website-index-document""
++	WebsiteErrorDocumentPathKey   = ""website-error-document""
++	EntryMetadataContentTypeKey   = ""Content-Type""
++	EntryMetadataFilenameKey      = ""Filename""
++)
++
+ var (
+ 	// ErrNotFound is returned when an Entry is not found in the manifest.
+ 	ErrNotFound = errors.New(""manifest: not found"")","@acud The reason I moved these here is because I need them in the traversal tests. The traversal package doesn't need this. I don't see any particular reason why any package apart from api would need this. api package imports traversal, so I cannot import api in traversal pkg. Also if these change in future, the traversal tests need to change. So maybe enough reason to move these here? That way both packages can access these as they both depend on manifest",Why do we need these constants?
+9643,"@@ -560,6 +560,7 @@ class AbstractTab(QWidget):
+         self._mouse_event_filter = mouse.MouseEventFilter(
+             self, widget_class=self.WIDGET_CLASS, parent=self)
+         self.backend = None
++        self.pin = False
+ 
+         # FIXME:qtwebengine  Should this be public api via self.hints?
+         #                    Also, should we get it out of objreg?","I'd prefer this to be called `pinned` - also it should probably be in the `TabData` class instead, which is accessible as the `.data` attribute of the `BrowserTab` object - otherwise, `BrowserTab` would have a lot of quite ""random"" attributes :wink:",Why is this needed?
+9644,"@@ -24,4 +24,7 @@ final class ChromeDriverCommand {
+   private ChromeDriverCommand() {}
+ 
+   static final String LAUNCH_APP = ""launchApp"";
++  static final String SEND_COMMANDS_FOR_DOWNLOAD_CHROME_HEAD_LESS
++      = ""sendCommandForDownloadChromeHeadLess"";
++
+ }","Nit: `Headless` is one word, not two, and so doesn't need camelcasing in this way.",nit: `sendCommandForDownloadChromeHeadLess` -> `sendCommandsForDownloadChromeHeadLess`
+9645,"@@ -1,6 +1,9 @@
+-/*global Audit, runRules, cleanupPlugins */
++/*global Audit */
+ /*eslint indent: 0*/
+-function runCommand(data, keepalive, callback) {
++import cleanupPlugins from './cleanup-plugins';
++import runRules from './run-rules';
++
++const runCommand = (data, keepalive, callback) => {
+ 	'use strict';
+ 	var resolve = callback;
+ 	var reject = function(err) {",Why not import audit as well?,Why do we need this change?
+9646,"@@ -92,7 +92,9 @@ class CategoryDataFixture extends AbstractReferenceFixture
+                 . '(black-and-white), or in color, and in two or three dimensions',
+             ]
+         );
+-        $categoryData->parent = $this->getReference(self::CATEGORY_ELECTRONICS);
++        /** @var \Shopsys\ShopBundle\Model\Category\Category $categoryElectronics */
++        $categoryElectronics = $this->getReference(self::CATEGORY_ELECTRONICS);
++        $categoryData->parent = $categoryElectronics;
+         $this->createCategory($categoryData, self::CATEGORY_TV);
+ 
+         $categoryData->name = [","OK, i think there will be more of those...",`$categoryElectronics` -> `$categoryElectronics`
+9647,"@@ -12,6 +12,6 @@ return [
+     |
+     */
+ 
+-    'failed'   => 'These credentials do not match our records.',
+-    'throttle' => 'Too many login attempts. Please try again in :seconds seconds.',
++    'failed'   => 'Овие акредитиви не се совпаѓаат со нашите записи.',
++    'throttle' => 'Премногу обиди за најавување. Обидете се повторно за :seconds секунди.',
+ ];","Can you add : 'password' => 'The provided password is incorrect.', ?",Why did you change this?
+9648,"@@ -18,6 +18,7 @@ from logHandler import log
+ 
+ from comtypes.gen.UIAutomationClient import *
+ 
++
+ #Some new win8 UIA constants that could be missing
+ UIA_StyleIdAttributeId=40034
+ UIA_AnnotationAnnotationTypeIdPropertyId=30113",Extraneous blank line.,
+9649,"@@ -30,7 +30,7 @@ function ariaOwns(nodes, role) {
+ 		if (nodes[index] === null) {
+ 			continue;
+ 		}
+-		let virtualTree = axe.utils.getNodeFromTree(axe._tree[0], nodes[index]);
++		let virtualTree = axe.utils.getNodeFromTree(nodes[index]);
+ 		if (owns(nodes[index], virtualTree, role, true)) {
+ 			return true;
+ 		}","nitpick: use `const virtualTree`, I know it was `let` earlier.",`
+9650,"@@ -464,7 +464,10 @@ func (j *mdJournal) convertToBranch(
+ 		brmd.SetUnmerged()
+ 		brmd.SetBranchID(bid)
+ 
+-		// Delete the old ""merged"" version from the cache.
++		// Delete the old ""merged"" version from the cache.  We aren't
++		// equipped here to cache the new version, but it will
++		// eventually get passed via an mdFlushListener to somewhere
++		// that will cache it.
+ 		mdcache.Delete(tlfID, ibrmd.RevisionNumber(), NullBranchID)
+ 
+ 		// Re-sign the writer metadata.","Actually, I think it might be easier to do it here. Rough outline: 1. Save a list of the md cache keys and new brmd while looping. 2. After the loop, for each entry: 2a. Look up the old cache entry. If it doesn't exist, continue. 2b. Otherwise, make a deep copy of it, and replace its brmd with the newly-generated one. 2c. Delete the old cache entry, put the new cache entry. What do you think? The problem with the current approach is that the gap between dropping the old version and putting the new version is large enough that when we put the new version, we may be kicking out hotter cache entries. In this case, we'd be doing so to a lesser extent. Ideally, we'd be able to replace the entry in the MDCache LRU without changing the LRU info.",n
+9651,"@@ -253,6 +253,12 @@ namespace Microsoft.VisualStudio.TestPlatform.CommandLine
+             }
+ 
+             source = source.Trim();
++
++            if(!FileHelper.IsRootedPath(source))
++            {
++                source = FileHelper.CombinePath(source);
++            }
++
+             if (!FileHelper.Exists(source))
+             {
+                 throw new CommandLineException(",We need tests for this,n
+9652,"@@ -47,11 +47,11 @@ func initProvider() func() {
+ 	// `localhost:30080` address. Otherwise, replace `localhost` with the
+ 	// address of your cluster. If you run the app inside k8s, then you can
+ 	// probably connect directly to the service through dns
+-	exp, err := otlp.NewExporter(
+-		otlp.WithInsecure(),
++	config := otlp.NewConnectionConfig(otlp.WithInsecure(),
+ 		otlp.WithAddress(""localhost:30080""),
+ 		otlp.WithGRPCDialOption(grpc.WithBlock()), // useful for testing
+ 	)
++	exp, err := otlp.NewExporter(config, config)
+ 	handleErr(err, ""failed to create exporter"")
+ 
+ 	bsp := sdktrace.NewBatchSpanProcessor(exp)",NewExporter takes in two arguments: a configuration for the metrics connection and one for the traces,Why do we need this change?
+9653,"@@ -241,6 +241,15 @@ import connectionManager from 'connectionManager';
+         navigator.mediaSession.setActionHandler('seekforward', function () {
+             execute('fastForward');
+         });
++
++        /* eslint-disable-next-line compat/compat */
++        navigator.mediaSession.setActionHandler('seekto', function (object) {
++            let item = playbackManager.getPlayerState(playbackManager.getCurrentPlayer()).NowPlayingItem;
++            // Convert to ms
++            let duration = parseInt(item.RunTimeTicks ? (item.RunTimeTicks / 10000) : 0);
++            let wantedTime = object.seekTime * 1000;
++            playbackManager.seekPercent(wantedTime / duration * 100, currentPlayer);
++        });
+     }
+ 
+     events.on(playbackManager, 'playerchange', function () {",Why not use currentPlayer instead of playbackManager.getCurrentPlayer()?,I'm not sure if this is the
+9654,"@@ -15,7 +15,8 @@ class UsersController < Clearance::UsersController
+   def create_user_from_params
+     params.require(:user).permit(
+       :email, :password, :name, :github_username, :bio, :organization,
+-      :address1, :address2, :city, :state, :zip_code, :country
++      :address1, :address2, :city, :state, :zip_code, :country,
++      :unsubscribed_from_emails
+     )
+   end
+ ","Avoid comma after the last parameter of a method call, unless each item is on its own line.",Align the parameters of a m
+9655,"@@ -52,7 +52,12 @@ type Config struct {
+ 
+ 	// DataDir is the directory data is saved to in order to preserve state
+ 	// across agent restarts. It is only used if ""Checkpoint"" is true as well.
++	// It is also used to keep the metadata of containers managed by the agent
++	// regardless of whether ""Checkpoint"" is set.
+ 	DataDir string
++	// DataDirOnHost is the directory in the instance from which we mount
++	// DataDir to the ecs-agent container and to agent managed containers
++	DataDirOnHost string
+ 	// Checkpoint configures whether data should be periodically to a checkpoint
+ 	// file, in DataDir, such that on instance or agent restarts it will resume
+ 	// as the same ContainerInstance. It defaults to false.",You should remove the outdated sentence.,nit: `DataDirOnHost is the 
+9656,"@@ -158,7 +158,7 @@ public class MessageCompose extends K9Activity implements OnClickListener,
+             ""com.fsck.k9.activity.MessageCompose.quotedTextFormat"";
+     private static final String STATE_KEY_NUM_ATTACHMENTS_LOADING = ""numAttachmentsLoading"";
+     private static final String STATE_KEY_WAITING_FOR_ATTACHMENTS = ""waitingForAttachments"";
+-
++    private static final String STATE_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmptySubject"";
+     private static final String LOADER_ARG_ATTACHMENT = ""attachment"";
+ 
+     private static final String FRAGMENT_WAITING_FOR_ATTACHMENT = ""waitingForAttachment"";",Please restore the empty line after the group of `STATE_*` constants. This visual separation makes the code easier to read.,"nit: `STATE_KEY_FIRST_TIME_EMPTY_SUBJECT = ""firstTimeEmptySubject""`"
+9657,"@@ -213,9 +213,10 @@ module.exports = class GoldenRetriever extends Plugin {
+       this.IndexedDBStore.delete(fileID)
+     })
+ 
+-    this.core.on('core:success', (fileIDs) => {
++    this.core.on('core:complete', ({ successful }) => {
++      const fileIDs = successful.map((file) => file.id)
+       this.deleteBlobs(fileIDs).then(() => {
+-        this.core.log(`[GoldenRetriever] removed ${fileIDs.length} files that finished uploading`)
++        this.core.log(`RestoreFiles: removed ${successful.length} files that finished uploading`)
+       })
+     })
+ ","Unsure why this is `RestoreFiles` now vs `GoldenRetriever`, thought we deprecated the first?",`[GoldenRetriever]` -> `[RestoreFiles]`
+9658,"@@ -436,6 +436,10 @@ namespace pwiz.Skyline.Controls.Graphs
+         {
+             // Match each file status with a progress control.
+             bool first = true;
++            var width = flowFileStatus.Width - 2 -
++                        (flowFileStatus.VerticalScroll.Visible
++                            ? SystemInformation.VerticalScrollBarWidth
++                            : 0);
+             foreach (var loadingStatus in status.ProgressList)
+             {
+                 var filePath = loadingStatus.FilePath;",Not sure what this is. Bad merge?,Why is this `2`?
+9659,"@@ -171,7 +171,7 @@ func (v *veth) create(n *network, nspid int) (err error) {
+ 			netlink.LinkDel(veth)
+ 		}
+ 	}()
+-	if err := v.attach(&n.Network); err != nil {
++	if err = v.attach(&n.Network); err != nil {
+ 		return err
+ 	}
+ 	child, err := netlink.LinkByName(n.TempVethPeerName)","I'm confused, what did this actually fix? Is there a reason we are setting `err` in the parent scope to `nil` in this round-about way?",Why is this change needed?
+9660,"@@ -1103,6 +1103,10 @@ func TestApplyEnv_Image_HealthCheck(t *testing.T) {
+ 	}
+ }
+ 
++func TestApplyEnv_Platform(t *testing.T) {
++	// TODO: Add test for platform in the next PR
++}
++
+ func TestApplyEnv_Entrypoint(t *testing.T) {
+ 	testCases := map[string]struct {
+ 		inSvc  func(svc *LoadBalancedWebService)",Can we remove this   ?,Why do we need this?
+9661,"@@ -0,0 +1,7 @@
++class NewLanguageConfirmationsController < ApplicationController
++  def index
++    redirect_to welcome_to_upcase_path(
++      confirmation: true, language_selected: params[:language],
++    ), notice: ""Thanks for signing up. We will be in touch!""
++  end
++end",Put a comma after the last parameter of a multiline method call.,I'm not sure if this
+9662,"@@ -48,12 +48,13 @@ func TestBlockDAO(t *testing.T) {
+ 		tsf3, err := testutil.SignedTransfer(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+ 
+-		// create testing votes
+-		vote1, err := testutil.SignedVote(testaddress.Addrinfo[""alfa""].String(), testaddress.Keyinfo[""alfa""].PriKey, 1, 100000, big.NewInt(10))
++		tsf4, err := testutil.SignedTransfer(testaddress.Addrinfo[""alfa""].String(), testaddress.Keyinfo[""alfa""].PriKey, 2, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+-		vote2, err := testutil.SignedVote(testaddress.Addrinfo[""bravo""].String(), testaddress.Keyinfo[""bravo""].PriKey, 1, 100000, big.NewInt(10))
++
++		tsf5, err := testutil.SignedTransfer(testaddress.Addrinfo[""bravo""].String(), testaddress.Keyinfo[""bravo""].PriKey, 3, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+-		vote3, err := testutil.SignedVote(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 1, 100000, big.NewInt(10))
++
++		tsf6, err := testutil.SignedTransfer(testaddress.Addrinfo[""charlie""].String(), testaddress.Keyinfo[""charlie""].PriKey, 4, big.NewInt(int64(amount)), nil, genesis.Default.ActionGasLimit, big.NewInt(0))
+ 		require.NoError(t, err)
+ 
+ 		// create testing executions",line is 195 characters (from `lll`),`tsf6` -> `tsf4`
+9663,"@@ -29,8 +29,11 @@ import (
+ 	""github.com/pkg/errors""
+ 	k8serror ""k8s.io/apimachinery/pkg/api/errors""
+ 	metav1 ""k8s.io/apimachinery/pkg/apis/meta/v1""
++	klabels ""k8s.io/apimachinery/pkg/labels""
++	""k8s.io/apimachinery/pkg/types""
+ 	""k8s.io/apimachinery/pkg/util/runtime""
+ 	""k8s.io/client-go/tools/cache""
++	""k8s.io/kubernetes/pkg/util/slice""
+ )
+ 
+ var (","could not import k8s.io/kubernetes/pkg/util/slice (invalid package name: """") (from `typecheck`)",nit: remove empty li
+9664,"@@ -29,4 +29,4 @@ describeComponent(
+             expect(component._state).to.equal('inDOM');
+         });
+     }
+-);
++);",@disordinary would you be able to configure your editor to use the `.editorconfig` file so that we can avoid final newline changes?,Nit: unnecessary change
+9665,"@@ -80,12 +80,9 @@ module.exports = function(realmConstructor, context) {
+     const { DefaultNetworkTransport } = require('realm-network-transport');
+     realmConstructor._networkTransport = new DefaultNetworkTransport();
+ 
+-    Object.defineProperty(realmConstructor.Object.prototype, ""toJSON"", {
+-        value: function () {
+-            const result = {}
+-            Object.keys(this).forEach(p => result[p] = this[p]);
+-            Object.keys(Object.getPrototypeOf(this)).forEach(p => result[p] = this[p]);
+-            return result;
++    Object.defineProperty(realmConstructor.Collection.prototype, ""toJSON"", {
++        value: function (_, cache = new Map()) {
++            return this.map((item, index) => item.toJSON ? item.toJSON(index.toString(), cache) : item);
+         },
+ 
+         writable: true,",I really think we should not use this style where unused arguments are named with underscore. While this eases the person writing the function it does it at an expense of readability and debugging. So next person who needs to actually use this argument will need to check the spec and rename this to `obj` and then use it or if he is debugging it he will is not able to watch for a meaningful variable name and will need to inspect `_` which is weird and uncomfortable. We have not used this style anywhere in the code while I agree its very tempting to use it :),I don't think you need 
+9666,"@@ -575,7 +575,7 @@ Lng32 main(Lng32 argc, char *argv[])
+     // setup log4cxx
+     QRLogger::initLog4cxx(QRLogger::QRL_LOB);
+     // initialize lob globals
+-    lobGlobals = new ExLobGlobals();
++    lobGlobals = new ExLobGlobals(NULL);
+     if (lobGlobals == NULL) 
+       return -1;
+ ","Thanks for avoiding the default value for the param. But, I think sending heap as NULL might make this program to fail. Have you tested this program? If you have tested this program already, then this PR is ready to be merged.",This should be `new ExL
+9667,"@@ -0,0 +1,18 @@
++// Licensed to the .NET Foundation under one or more agreements.
++// The .NET Foundation licenses this file to you under the MS-PL license.
++// See the LICENSE file in the project root for more information.
++
++using MvvmCross.Presenters.Attributes;
++using Windows.UI.Xaml.Controls;
++
++namespace MvvmCross.Platforms.Uap.Presenters.Attributes
++{
++    public sealed class MvxModalViewPresentationAttribute : MvxBasePresentationAttribute
++    {
++        public MvxModalViewPresentationAttribute()
++        {
++        }
++
++        public ContentDialogPlacement Placement { get; set; }
++    }
++}",Don't make it sealed,Why do we need this?
+9668,"@@ -278,6 +278,8 @@ func (a *Account) shallowCopy() *Account {
+ 	}
+ 	// JetStream
+ 	na.jsLimits = a.jsLimits
++	// Server config account limits.
++	na.limits = a.limits
+ 
+ 	return na
+ }",Did we miss that for jwt before?,Why do we need this?
+9669,"@@ -44,10 +44,10 @@ const (
+ 
+ // UART1 on the Trinket M0.
+ var (
+-	UART1 = UART{Bus: sam.SERCOM1_USART,
++	UART1 = UART{
+ 		Buffer: NewRingBuffer(),
+-		Mode:   PinSERCOM,
+-		IRQVal: sam.IRQ_SERCOM1,
++		Bus:    sam.SERCOM0_USART,
++		SERCOM: 0,
+ 	}
+ )
+ ","It appears that using SERCOM1 was a bug: the only SERCOM that is supported on the TX/RX pins is SERCOM0. Previous UART support wouldn't have worked on the Trinket M0 TX/RX pins anyway (`PA06`/`PA07`). This PR fixes that, and should thereby add support for UART on the Trinket M0.",Why do we need to ch
+9670,"@@ -179,7 +179,8 @@ class Preference extends Model
+     public function getLocaleOptions()
+     {
+         $localeOptions = [
+-            'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
++            'ar' => [Lang::get('system::lang.locale.ar'), 'flag-sa'],
++						'be' => [Lang::get('system::lang.locale.be'), 'flag-by'],
+             'cs' => [Lang::get('system::lang.locale.cs'), 'flag-cz'],
+             'da' => [Lang::get('system::lang.locale.da'), 'flag-dk'],
+             'en' => [Lang::get('system::lang.locale.en'), 'flag-us'],","Spaces for indentation, not tabs",I don't think this i
+9671,"@@ -117,15 +117,11 @@ cvdescriptorset::DescriptorSetLayoutDef::DescriptorSetLayoutDef(const VkDescript
+     assert(bindings_.size() == binding_count_);
+     assert(binding_flags_.size() == binding_count_);
+     uint32_t global_index = 0;
+-    binding_to_global_index_range_map_.reserve(binding_count_);
+-    // Vector order is finalized so create maps of bindings to descriptors and descriptors to indices
++    global_index_range_.reserve(binding_count_);
++    // Vector order is finalized so build vectors of descriptors and dynamic offsets by binding index
+     for (uint32_t i = 0; i < binding_count_; ++i) {
+-        auto binding_num = bindings_[i].binding;
+         auto final_index = global_index + bindings_[i].descriptorCount;
+-        binding_to_global_index_range_map_[binding_num] = IndexRange(global_index, final_index);
+-        if (final_index != global_index) {
+-            global_start_to_index_map_[global_index] = i;
+-        }
++        global_index_range_.emplace_back(global_index, final_index);
+         global_index = final_index;
+     }
+ ","doing this as a binding map was insane, but with the ConstBindingIterator to hide the binding->index gunk and avoid the hashes during access it sticks out.",nit: `global_index_r
+9672,"@@ -27,6 +27,8 @@ TEST_EVENT_PATTERN = {
+     'Detail': [EVENT_DETAIL]
+ }
+ 
++TEST_EVENT_PATTERN_1 = {'detail': {'EventType': ['0', '1']}}
++
+ 
+ class EventsTest(unittest.TestCase):
+     def setUp(self):","nitpick: I'd rather move this into the test method directly (we should avoid variables at the root scope if they are not reused in multiple places). (not critical, though - shouldn't hold back the merge..)",E225 missing whitespace around operator
+9673,"@@ -212,7 +212,12 @@ namespace TestPerf // Note: tests in the ""TestPerf"" namespace only run when the
+             {
+                 RunUI(() => importPeptideSearchDlg.ClickNextButtonNoCheck());
+             }
+-            // Modifications are already set up, so that page should get skipped.
++            // Skip Match Modifications page.
++            RunUI(() =>
++            {
++                AssertEx.IsTrue(importPeptideSearchDlg.CurrentPage == ImportPeptideSearchDlg.Pages.match_modifications_page);
++                AssertEx.IsTrue(importPeptideSearchDlg.ClickNextButton());
++            });
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.PrecursorCharges = new []{2,3,4,5});
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.PrecursorMassAnalyzer = FullScanMassAnalyzerType.tof);
+             RunUI(() => importPeptideSearchDlg.FullScanSettingsControl.IonMobilityFiltering.IsUseSpectralLibraryIonMobilities = useDriftTimes);","You should do: AssertEx.AreEqual(importPeptideSearchDlg.CurrentPage, ImportPeptideSearchDlg.Pages.match_modifications_page);",why do we need this?
+9674,"@@ -145,7 +145,7 @@ public class MicroserviceRegisterTask extends AbstractRegisterTask {
+       String schemaId = entry.getKey();
+       String content = entry.getValue();
+       GetSchemaResponse existSchema = extractSchema(schemaId, existSchemas);
+-      boolean exists = existSchema != null;
++      boolean exists = existSchema != null && existSchema.getSummary() != null;
+       LOGGER.info(""schemaId [{}] exists {}"", schemaId, exists);
+       if (!exists) {
+         if (!srClient.registerSchema(microservice.getServiceId(), schemaId, content)) {","SC support batch register schemas we should swtich to new api be careful that maybe will send too big request, need to split to multi request by max size of limit.",I think this should be `existSchema != 
+9675,"@@ -25,8 +25,8 @@ func NewConfig(options *compileopts.Options) (*compileopts.Config, error) {
+ 	if err != nil {
+ 		return nil, fmt.Errorf(""could not read version from GOROOT (%v): %v"", goroot, err)
+ 	}
+-	if major != 1 || minor < 11 || minor > 14 {
+-		return nil, fmt.Errorf(""requires go version 1.11, 1.12, 1.13, or 1.14, got go%d.%d"", major, minor)
++	if major != 1 || minor < 11 || minor > 15 {
++		return nil, fmt.Errorf(""requires go version 1.11, 1.12, 1.13, 1.14, or 1.15, got go%d.%d"", major, minor)
+ 	}
+ 	clangHeaderPath := getClangHeaderPath(goenv.Get(""TINYGOROOT""))
+ 	return &compileopts.Config{","At this point, maybe it would make more sense to write this as a range rather than listing specific versions?",Why is this being changed?
+9676,"@@ -255,6 +255,11 @@ func (p Proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) (int, error) {
+ 			return http.StatusRequestEntityTooLarge, backendErr
+ 		}
+ 
++		// TODO: write an 499 HTTP status as constant in someplace (and also change in proxy_test.go on line: expectedStatus, expectErr := 499, context.Canceled)
++		if backendErr == context.Canceled {
++			return 499, backendErr
++		}
++
+ 		// failover; remember this failure for some time if
+ 		// request failure counting is enabled
+ 		timeout := host.FailTimeout",I guess we can start by putting the `const StatusContextCancelled = 499` at the bottom of this file,"I think this should be `return expectedStatus, backendErr`"
+9677,"@@ -100,6 +100,7 @@ func TestPaymentChannelVoucher(t *testing.T) {
+ 			types.NewChannelID(5),
+ 			types.NewAttoFILFromFIL(10),
+ 			types.NewBlockHeight(0),
++			nil,
+ 		)
+ 		require.NoError(err)
+ 		assert.Equal(expectedVoucher.Channel, voucher.Channel)",Blocking: populate a non-empty value and check it below.,Why is this nil?
+9678,"@@ -194,7 +194,14 @@ public class Permission {
+     // Users with this permission can upload projects when the property ""lockdown.upload.projects""
+     // is turned on
+     UPLOADPROJECTS(0x0008000),
+-    ADMIN(0x8000000);
++    ADMIN(0x8000000),
++    // Permissions for image management APIs.
++    CREATE(0x0000100),
++    GET(0x0000200),
++    UPDATE(0x0000300),
++    DELETE(0x0000400),
++    IMAGE_TYPE_ADD_MEMBER(0x0000500),
++    IMAGE_TYPE_DELETE_MEMBER(0x0000600);
+ 
+     private final int numVal;
+ ",What is this number value for? How is it used?,I think this should be `IMAGE_TYPE_CREATE_MEMBER`
+9679,"@@ -192,6 +192,11 @@ describe Travis::Build::Script::R, :sexp do
+                            assert: true, echo: true, retry: true, timing: true]
+     end
+ 
++    it 'does BiocCheck if requested' do
++      data[:config][:bioc_check] = true
++      should include_sexp [:cmd, /.*BiocCheck.*/,
++                           assert: true, echo: true, timing: true]
++
+     it 'does install bioc with bioc_packages' do
+       data[:config][:bioc_packages] = ['GenomicFeatures']
+       should include_sexp [:cmd, /.*biocLite.*/,",This needs an end keyword,why is this needed?
+9680,"@@ -0,0 +1,17 @@
++// <copyright file=""DependencyTelemetryData.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Telemetry
++{
++    /// <summary>
++    /// Using a record as used as dictionary key so getting equality comparison for free
++    /// </summary>
++    internal record DependencyTelemetryData
++    {
++        public string Name { get; set; }
++
++        public string Version { get; set; }
++    }
++}",I think this is the first record type in Datadog.Trace!  ,"I think it would be better to use `IDictionary<string, string>` instead of `Dictionary<string, string>`"
+9681,"@@ -737,10 +737,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http
+             {
+                 return Task.CompletedTask;
+             }
+-            else
+-            {
+-                return FireOnCompletedAwaited(onCompleted);
+-            }
++            return FireOnCompletedAwaited(onCompleted);
+         }
+ 
+         private async Task FireOnCompletedAwaited(Stack<KeyValuePair<Func<object, Task>, object>> onCompleted)",Nit: missing newline above.,Why did you remove this?
+9682,"@@ -76,6 +76,13 @@ func StartKubeProxy(k8s kubernetes.Interface, hostname string,
+ 	}
+ 
+ 	go func() {
++		// Before we start, scan for all finished / timed out connections to
++		// free up the conntrack table asap as it may take time to sync up the
++		// proxy and kick off the first full cleaner scan.
++		lc := conntrack.NewLivenessScanner(kp.conntrackTimeouts, kp.dsrEnabled)
++		connScan := conntrack.NewScanner(kp.ctMap, lc.ScanEntry)
++		connScan.Scan()
++
+ 		err := kp.start()
+ 		if err != nil {
+ 			log.WithError(err).Panic(""kube-proxy failed to start"")","Since it's a one-off, worth putting an info log before and after.",I'm not sure if this is the best way to do this. I think it would be better to do this in `kube-proxy.g
+9683,"@@ -140,8 +140,10 @@ app.controller('CalController', ['$scope', 'Calendar', 'CalendarService', 'VEven
+ 				$scope.$apply();
+ 			});
+ 		} else {
+-			$scope.calendarsPromise = CalendarService.getPublicCalendar(constants.publicSharingToken).then(function(calendar) {
+-				$scope.calendars = [calendar];
++			constants.publicSharingToken.split(""."").forEach( (token) => {
++				$scope.calendarsPromise = CalendarService.getPublicCalendar(token).then(function(calendar) {
++					$scope.calendars.push(calendar);
++			});
+ 				is.loading = false;
+ 				// TODO - scope.apply should not be necessary here
+ 				$scope.$apply();","I'm sorry, but the indentation is still wrong. This should be indented by one tab.","I don't think you need the `.split(""."")`."
+9684,"@@ -360,6 +360,18 @@ class DataFrame(_Frame):
+         self._sdf = sdf
+         self._metadata = self._metadata.copy(column_fields=names)
+ 
++    @property
++    def dtypes(self):
++        """"""Return the dtypes in the DataFrame.
++
++        This returns a Series with the data type of each column. The result's index is the original
++        DataFrame's columns. Columns with mixed types are stored with the object dtype.
++
++        :return: :class:`pd.Series` The data type of each column.
++        """"""
++        return pd.Series([self[col].dtype for col in self._metadata.column_fields],
++                         index=self._metadata.column_fields)
++
+     @derived_from(pd.DataFrame, ua_args=['axis', 'level', 'numeric_only'])
+     def count(self):
+         return self._sdf.count()",can we add an example?,I don't think you need the `index=` here.
+9685,"@@ -156,6 +156,13 @@ func identifyUID(ctx context.Context, nug normalizedUsernameGetter,
+ func identifyUser(ctx context.Context, nug normalizedUsernameGetter,
+ 	identifier identifier, username libkb.NormalizedUsername,
+ 	uid keybase1.UID, isPublic bool) error {
++
++	// check to see if identify should be skipped altogether
++	ei := getExtendedIdentify(ctx)
++	if ei.behavior == keybase1.TLFIdentifyBehavior_CHAT_SKIP {
++		return nil
++	}
++
+ 	var reason string
+ 	if isPublic {
+ 		reason = ""You accessed a public folder.""",We usually avoid blank lines at the start of functions.,why is this needed?
+9686,"@@ -0,0 +1,18 @@
++<?php
++
++declare(strict_types=1);
++
++/*
++ * This file is part of the Sonata Project package.
++ *
++ * (c) Thomas Rabaix <thomas.rabaix@sonata-project.org>
++ *
++ * For the full copyright and license information, please view the LICENSE
++ * file that was distributed with this source code.
++ */
++
++use Symfony\Component\DependencyInjection\Loader\Configurator\ContainerConfigurator;
++
++return static function (ContainerConfigurator $containerConfigurator): void {
++    $containerConfigurator->services();
++};",I dont think this line is needed,Why do we need this method?
+9687,"@@ -22,7 +22,12 @@ const (
+ // requests w.r.t a single Volume.
+ func (s *HTTPServer) volumeSpecificRequest(resp http.ResponseWriter, req *http.Request) (interface{}, error) {
+ 	// check the feature gate & switch if enabled
+-	if util.CASTemplateFeatureGate() {
++	feature, err := util.CASTemplateFeatureGate()
++	if err != nil {
++		// exit if invalid value
++		glog.Fatalf(""invalid feature gate value for %s only boolean values allowed"", util.CASTemplateFeatureGateENVK)
++	}
++	if feature {
+ 		return s.volumeV1alpha1SpecificRequest(resp, req)
+ 	}
+ ",We should not panic here !!! We return error i.e. 500 http code,"nit: `glog.Fatalf(""invalid feature gate v"
+9688,"@@ -1305,8 +1305,16 @@ nano:       use nanosecond-precision (requires libpcap >= 1.5.0)
+             else:
+                 pkt = pkt.__iter__()
+             for p in pkt:
++
+                 if not self.header_present:
+                     self._write_header(p)
++
++                if self.linktype != conf.l2types.get(type(p), None):
++                    warning(""Inconsistent linktypes detected!""
++                            "" The resulting PCAP file might contain""
++                            "" invalid packets.""
++                            )
++
+                 self._write_packet(p)
+ 
+     def _write_packet(self, packet, sec=None, usec=None, caplen=None,","To avoid useless calls to `conf.l2types.get()` we could have a `set()` of types that are OK in this PCAP files. We could check if `p.__class__ not in self.l2_types_seen` first, only run this code block in that case, and add `self.l2_types_seen.add(p.__class__)`. I'm not sure if I'm clear here... let me know what you think.","I don't think this is the right way to do this. If the linktype is not in the conf.l2types, we should raise an error."
+9689,"@@ -129,6 +129,11 @@ public class Constants {
+   // Used (or should be used) wherever a string representation of UTF_8 charset is needed:
+   public static final String UTF_8 = java.nio.charset.StandardCharsets.UTF_8.toString();
+ 
++  // Specifies the source(adhoc, scheduled, flow_trigger) from where flow execution is triggered
++  public static final String EXECUTION_SOURCE_ADHOC = ""adhoc"";
++  public static final String EXECUTION_SOURCE_SCHEDULED = ""scheduled"";
++  public static final String EXECUTION_SOURCE_FLOW_TRIGGER = ""flow_trigger"";
++
+   public static class ConfigurationKeys {
+ 
+     public static final String AZKABAN_GLOBAL_PROPERTIES_EXT_PATH = ""executor.global.properties"";","Shouldn't ""source"" be a noun? How about? -EXECUTION_SOURCE_USER -EXECUTION_SOURCE_SCHEDULE -EXECUTION_SOURCE_EVENT (because it's an event based trigger mechanism)",nit: can we call this `EXECUTION_SOURCE_ADHOC_AND_SCHEDULED`?
+9690,"@@ -1,6 +1,6 @@
+ _base_ = [
+     '../_base_/models/mask_rcnn_r50_fpn.py',
+-    '../_base_/datasets/coco_instance.py',
++    '../_base_/datasets/lvis_v1_instance.py',
+     '../_base_/schedules/schedule_2x.py', '../_base_/default_runtime.py'
+ ]
+ model = dict(",Should not switch to `lvis_v1_instance` here because that base config uses ClassBalancedDataset to oversample the data.,Why do we need this change?
+9691,"@@ -24,6 +24,8 @@ describe('th-has-data-cells', function () {
+ 			'<table>' +
+ 			'  <tr> <th>hi</th> <td>hello</td> </tr>' +
+ 			'  <tr> <th>hi</th> <td>hello</td> </tr>' +
++			'  <tr> <td>hello</td> <th>hi</th> </tr>' +
++			'  <tr> <td>hello</td> <th>hi</th> </tr>' +
+ 			'</table>';
+ 
+ 		var node = fixture.querySelector('table');","Last time I checked, this technique did not work on all major screen reader - browser combinations. What screen readers have you tested?",'<tr> <th>hi</th> </tr>' +
+9692,"@@ -180,6 +180,8 @@ namespace Datadog.Trace.Configuration
+ 
+             TraceBatchInterval = source?.GetInt32(ConfigurationKeys.SerializationBatchInterval)
+                         ?? 100;
++
++            AspnetRouteTemplateResourceNamesEnabled = IsFeatureFlagEnabled(ConfigurationKeys.FeatureFlags.AspnetRouteTemplateResourceNamesEnabled);
+         }
+ 
+         /// <summary>","Most tracer settings can be set in several ways: environment variables, `app.config`/`web.config` file, or in a json file (`~/datadog.json` by default). Most exceptions to this rule are settings in native code (where we use env vars only). Currently, `DD_TRACE_ASPNET_ROUTE_TEMPLATE_RESOURCE_NAMES_ENABLED` will only work as an env var. Was this limitation intentional?",Why do we need this?
+9693,"@@ -218,4 +218,10 @@ type Config struct {
+ 
+ 	// TaskMetadataBurstRate specifies the burst rate throttle for the task metadata endpoint
+ 	TaskMetadataBurstRate int
++
++	// NoIID when set to true, specifies that the agent should not register the instance
++	// with instance identity document. This is required in order to accomodate scenarios in
++	// which ECS agent tries to register the instance where the instance id document is
++	// not available or needed
++	NoIID bool
+ }","Would ""DisableIID"" be a better name? For example, we used DisableMetrics, ImageCleanupDisabled, ... etc. for other similar fields.",nit: `// NoIID indic
+9694,"@@ -3908,7 +3908,7 @@ build_bb_ilist(dcontext_t *dcontext, build_bb_t *bb)
+             BBPRINT(bb, 3, ""reached end pc "" PFX "", stopping\n"", bb->stop_pc);
+             break;
+         }
+-        if (total_instrs > DYNAMO_OPTION(max_bb_instrs)) {
++        if (total_instrs == DYNAMO_OPTION(max_bb_instrs) - 1) {
+             /* this could be an enormous basic block, or it could
+              * be some degenerate infinite-loop case like a call
+              * to a function that calls exit() and then calls itself,","So this is a swing of 2: but I think we only need to reduce by 1? The artificial jump added on truncation is not passed to clients: it's like other mangling added later. So if `-max_bb_instrs 4` means 4 app instrs passed to clients, we'd want ==, not ==-1, right? Plus, if we did want -1 and to stop at 3 instead of 4, this is not sufficient: the inner loop above currently has `total_instrs <= cur_max_bb_instrs`.",I'm not sure if this
+9695,"@@ -362,7 +362,7 @@ LmExprResult CreateLmOutputExpr(const NAType &formalType,
+ // specified type t to be converted to/from C strings. The only 
+ // SQL types that do not need to be converted to C strings are:
+ // 
+-//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION
++//  INT, SMALLINT, LARGEINT, FLOAT, REAL, DOUBLE PRECISION, BOOLEAN
+ //
+ // because these types map to Java primitive types:
+ //","Does Tinyint belong to this set of types? I suppose the answer is No, but thought it safer to check.",Why is BOOLEAN added
+9696,"@@ -1110,6 +1110,17 @@ Blockly.WorkspaceSvg.prototype.isDeleteArea = function(e) {
+   return Blockly.DELETE_AREA_NONE;
+ };
+ 
++/**
++ * Is the mouse event outside the blocks UI, to the right of the workspace?
++ * @param {!Event} e Mouse move event.
++ * @return {boolean} True if event is outside the blocks UI.
++ */
++Blockly.WorkspaceSvg.prototype.isOutside = function(e) {
++  var mousePoint = Blockly.utils.mouseToSvg(e, this.getParentSvg(),
++      this.getInverseScreenCTM());
++  return this.getParentSvg().width.baseVal.value < mousePoint.x;
++};
++
+ /**
+  * Handle a mouse-down on SVG drawing surface.
+  * @param {!Event} e Mouse down event.","I'm a bit leery of this implementation, because it assumes that the only ""outside"" is to the right side. Note that Blockly assumes that there's nothing useful to the ""outside"" of the toolbox, based on the configuration of the workspace, so it's not like we're doing the right thing either. I think this will break in RTL. If you keep the editor in the same place but inject with RTL, everything you're looking for will be in the delete area. If the editor and stage swap places, this will just be looking on the wrong side.",Why do we need this function?
+9697,"@@ -180,6 +180,7 @@ type Config struct {
+ 	FailsafeOutboundHostPorts []ProtoPort `config:""port-list;udp:53,udp:67,tcp:179,tcp:2379,tcp:2380,tcp:6666,tcp:6667;die-on-fail""`
+ 
+ 	KubeNodePortRanges []numorstring.Port `config:""portrange-list;30000:32767""`
++	NatPortRange       numorstring.Port   `config:""portrange;;local""`
+ 
+ 	UsageReportingEnabled          bool          `config:""bool;true""`
+ 	UsageReportingInitialDelaySecs time.Duration `config:""seconds;300""`",Just spotted the `local` on here; that shouldn't be needed - no reason to limit this config to env vars only,nit: `NatPortRange` -> `NatPo
+9698,"@@ -2322,7 +2322,7 @@ bool DiscoveryDataBase::from_json(
+             }
+ 
+             // Add Participant
+-            auto wit = writers_.insert(std::make_pair(guid_aux, dei));
++            writers_.insert(std::make_pair(guid_aux, dei));
+ 
+             // Extra configurations for writers
+             // Add writer to writers_by_topic. This will create the topic if necessary","That's a tricky one, as the variable is indeed used in line 2346, which is a `logInfo` message that is not compiled unless `INTERNAL_DEBUG` is set or `CMAKE_BUILD_TYPE` is set to `Debug`. Our CI builds with `INTERNAL_DEBUG` to verify that all `logInfo` are correct, and thus we don't get the warning. The best is probably to remove the iterator (as you did), as well as the part of the log that uses it.",Why did you remove this line?
+9699,"@@ -600,7 +600,7 @@ class L3PacketSocket(L2Socket):
+         # type: (Packet) -> int
+         iff = x.route()[0]
+         if iff is None:
+-            iff = conf.iface
++            iff = network_name(conf.iface)
+         sdto = (iff, self.type)
+         self.outs.bind(sdto)
+         sn = self.outs.getsockname()",I suspect L2Socket needs a similar change (line 502) for the case where `iface` is None (line 479),I think this should be `ififf
+9700,"@@ -0,0 +1,3 @@
++ActiveAdmin.register LicensePermission do
++  permit_params :name, :description, :icon
++end",Was this all that was needed to add CRUD operations for the LicensePermission model? :-),Extra empty line detected at block body beginning.
+9701,"@@ -465,7 +465,7 @@ def installAddon(parentWindow, addonPath):
+ 
+ 	prevAddon = None
+ 	for addon in addonHandler.getAvailableAddons():
+-		if not addon.isPendingRemove and bundle.name==addon.manifest['name']:
++		if not addon.isPendingRemove and bundle.name.lower()==addon.manifest['name'].lower():
+ 			prevAddon=addon
+ 			break
+ 	if prevAddon:",Did you look for other locations that compare name? I expected there to be more.,`bundle.name == addon.manifest['name'].lower()`
+9702,"@@ -47,6 +47,9 @@ public final class BaselineTesting implements Plugin<Project> {
+                         .findAny()
+                         .ifPresent(ignored -> enableJUnit5ForAllTestTasks(project));
+             });
++
++            // Never cache test tasks, until we work out the correct inputs for ETE / integration tests
++            project.getTasks().withType(Test.class).configureEach(test -> test.getOutputs().cacheIf(task -> false));
+         });
+     }
+ ",There were some requests internally to allow users to opt out of this behaviour. We could expose a property that allows people to toggle ti,Why is this needed?
+9703,"@@ -300,10 +300,11 @@ public class TestIndexWriterDelete extends LuceneTestCase {
+     modifier.close();
+     dir.close();
+   }
+-  
++
+   public void testDeleteAllNoDeadLock() throws IOException, InterruptedException {
+     Directory dir = newDirectory();
+-    final RandomIndexWriter modifier = new RandomIndexWriter(random(), dir); 
++    final RandomIndexWriter modifier = new RandomIndexWriter(random(), dir,
++        newIndexWriterConfig().setMergePolicy(new MockRandomMergePolicy(random())));
+     int numThreads = atLeast(2);
+     Thread[] threads = new Thread[numThreads];
+     final CountDownLatch latch = new CountDownLatch(1);",Nice -- this forced `merge-on-getReader/commit` to be used more often in this test?,I think we can remove this test now?
+9704,"@@ -221,6 +221,9 @@ type ConsensusParams struct {
+ 
+ 	// sum of estimated op cost must be less than this
+ 	LogicSigMaxCost uint64
++
++	// a precision for assets
++	SupportAssetsPrecision bool
+ }
+ 
+ // Consensus tracks the protocol-level settings for different versions of the","Instead of a `bool`, can we just call this `MaxAssetDecimals` and have it be a `uint8`/`uint16`/`uint32` whose value is 0 before the upgrade and 19 after (2**64 - 1 is 20 decimal digits)? We'll need to set a maximum value anyway, and that way there's only one new proto variable instead of two.",Why do we need this?
+9705,"@@ -145,7 +145,10 @@ final class EntityRepository implements EntityRepositoryInterface
+ 
+             if ($sortFieldIsDoctrineAssociation) {
+                 $sortFieldParts = explode('.', $sortProperty, 2);
+-                $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
++                // check if join has been added once before.
++                if (!\in_array($sortFieldParts[0], $aliases)) {
++                    $queryBuilder->leftJoin('entity.'.$sortFieldParts[0], $sortFieldParts[0]);
++                }
+ 
+                 if (1 === \count($sortFieldParts)) {
+                     $queryBuilder->addOrderBy('entity.'.$sortProperty, $sortOrder);",where `$aliases` is defined ? @javiereguiluz,`if (!\in_array($sor
+9706,"@@ -66,12 +66,9 @@ func (h *Handler) FetchJWTSVID(ctx context.Context, req *workload.JWTSVIDRequest
+ 	var spiffeIDs []string
+ 	identities := h.Manager.MatchingIdentities(selectors)
+ 	if len(identities) == 0 {
+-		telemetry_common.AddRegistered(counter, false)
+ 		return nil, status.Errorf(codes.PermissionDenied, ""no identity issued"")
+ 	}
+ 
+-	telemetry_common.AddRegistered(counter, true)
+-
+ 	for _, identity := range identities {
+ 		if req.SpiffeId != """" && identity.Entry.SpiffeId != req.SpiffeId {
+ 			continue",what is the justification for the removal of the registered label? it doesn't seem to have high cardinality nor is it redundant. Seems useful to shed insight into understand situations where workloads aren't registered....,Why is this being re
+9707,"@@ -1835,3 +1835,7 @@ func (a *WebAPI) GetDeploymentChain(ctx context.Context, req *webservice.GetDepl
+ 		DeploymentChain: dc,
+ 	}, nil
+ }
++
++func (a *WebAPI) ListEvents(ctx context.Context, req *webservice.ListEventsRequest) (*webservice.ListEventsResponse, error) {
++	return nil, status.Error(codes.Unimplemented, ""Not implemented"")
++}",`ctx` is unused in ListEvents,Why is this not impl
+9708,"@@ -101,6 +101,14 @@ public class SmartStoreTest extends SmartStoreTestCase {
+         Assert.assertTrue(""ENABLE_JSON1 flag not found in compile options"", compileOptions.contains(""ENABLE_JSON1""));
+ 	}
+ 
++	/**
++	 * Checking sqlcipher version
++	 */
++	@Test
++	public void testSQLCipherVersion() {
++		Assert.assertEquals(""Wrong sqlcipher version"", ""4.0.1 community"", store.getSQLCipherVersion());
++	}
++
+ 	/**
+ 	 * Method to check soup blob with one stored by db. Can be overridden to check external storage if necessary.
+ 	 */",We've had that test on iOS for years.,I think this should be `4.0.2 community`
+9709,"@@ -37,7 +37,7 @@ namespace BenchmarkDotNet.Extensions
+                     .DontEnforcePowerPlan(); // make sure BDN does not try to enforce High Performance power plan on Windows
+ 
+                 // See https://github.com/dotnet/roslyn/issues/42393
+-                job = job.WithArguments(new Argument[] { new MsBuildArgument(""/p:DebugType=portable"") });
++                job = job.WithArguments(new Argument[] { new MsBuildArgument(""/p:DebugType=portable""), new MsBuildArgument(""-bl:benchmarkdotnet.binlog"") });
+             }
+ 
+             var config = ManualConfig.CreateEmpty()",This is for creating binlog file for building bdn generated template project. I feel that it's may be helpful in general for bdn diagnostic purpose.,Why is this needed?
+9710,"@@ -359,6 +359,18 @@ class QuteProc(testprocess.Process):
+         else:
+             self.send_cmd(':open ' + url)
+ 
++    def open_url(self, url, *, new_tab=False, new_window=False):
++        """"""Open the given url in qutebrowser.""""""
++        if new_tab and new_window:
++            raise ValueError(""new_tab and new_window given!"")
++
++        if new_tab:
++            self.send_cmd(':open -t ' + url)
++        elif new_window:
++            self.send_cmd(':open -w ' + url)
++        else:
++            self.send_cmd(':open ' + url)
++
+     def mark_expected(self, category=None, loglevel=None, message=None):
+         """"""Mark a given logging message as expected.""""""
+         line = self.wait_for(category=category, loglevel=loglevel,",Can you adjust `open_path` to simply call `path_to_url` and then `open_url` instead of duplicating the code?,This should be `if new_tab or new_window
+9711,"@@ -24,10 +24,10 @@ import (
+ var logGraphsyncFetcher = logging.Logger(""net.graphsync_fetcher"")
+ 
+ const (
+-	// Timeout for a single graphsync request (which may be for many blocks).
+-	// We might prefer this timeout to scale with the number of blocks expected in the fetch,
+-	// when that number is large.
+-	requestTimeout = 60 * time.Second
++	// Timeout for a single graphsync request getting ""stuck""
++	// -- if no more responses are received for a period greater than this,
++	// we will assume the request has hung-up and cancel it
++	unresponsiveTimeout = 10 * time.Second
+ )
+ 
+ // Fetcher defines an interface that may be used to fetch data from the network.",I'm curious -- do we have information on the upper bound of the delay we would expect with high probability from a peer with no network issues? My intuition is that we want to set this as low as we can reasonably get away with before we start killing productive connections. My uninformed intuition is also that 10 seconds is probably higher than we need and I'd love to know if this is wrong and 10 seconds is already pushing the limit.,Why is this 10 seconds?
+9712,"@@ -44,7 +44,7 @@ public class SarOperation extends AbstractFixedCostOperation {
+     } else {
+       final int shiftAmountInt = shiftAmount.toInt();
+ 
+-      if (shiftAmountInt >= 256) {
++      if (shiftAmountInt >= 256 || shiftAmountInt < 0) {
+         frame.pushStackItem(negativeNumber ? ALL_BITS : UInt256.ZERO);
+       } else {
+         // first perform standard shift right.",what happens if it's == 0,Why is this change needed?
+9713,"@@ -27,10 +27,6 @@ module Bolt
+           if @config['interpreters']
+             @config['interpreters'] = normalize_interpreters(@config['interpreters'])
+           end
+-
+-          if Bolt::Util.windows? && @config['run-as']
+-            raise Bolt::ValidationError, ""run-as is not supported when using PowerShell""
+-          end
+         end
+       end
+     end","We could potentially log a message here instead that indicates the transport does not support `run-as` on Windows and will be ignored, just in case users expect it to and are surprised. Since it would _always_ be logged when using `--run-as` on Windows, even when the transport isn't being used, it would probably want to be either at debug or trace level.",Why is this removed?
+9714,"@@ -4,7 +4,7 @@ import (
+ 	neturl ""net/url""
+ 	""strings""
+ 
+-	""github.com/bonitoo-io/go-sql-bigquery""
++	bigquery ""github.com/bonitoo-io/go-sql-bigquery""
+ 	""github.com/go-sql-driver/mysql""
+ 	""github.com/influxdata/flux/codes""
+ 	""github.com/influxdata/flux/dependencies/url""",Did we need this alias? Or is it just a holdout from development?,Why this change?
+9715,"@@ -72,7 +72,7 @@ class EditTest < ActiveSupport::TestCase
+     p.update_attributes(organization_id: org.id)
+     edit = PropertyEdit.where(target: p, key: 'organization_id').first
+     edit.project_id.must_equal p.id
+-    edit.organization_id.must_equal org.id
++    edit.value.must_equal org.id.to_s
+   end
+ 
+   it 'test_that_nothing_gets_filled_in_automatically_for_license_edits' do",This should have failed before.,I think this should be `ed
+9716,"@@ -56,7 +56,8 @@ namespace Datadog.Trace.Vendors.Serilog.Sinks.File
+                 ""(?<"" + PeriodMatchGroup + "">\\d{"" + _periodFormat.Length + ""})"" +
+                 ""(?<"" + SequenceNumberMatchGroup + "">_[0-9]{3,}){0,1}"" +
+                 Regex.Escape(_filenameSuffix) +
+-                ""$"");
++                ""$"",
++                RegexOptions.Compiled);
+ 
+             DirectorySearchPattern = $""{_filenamePrefix}*{_filenameSuffix}"";
+         }","Slower construction, faster matching. I wonder if this will be noticeable in the relenv?",Why not use `RegexOptions.Compiled`?
+9717,"@@ -61,6 +61,9 @@ void ThroughputPublisher::DataPubListener::onPublicationMatched(
+     if (info.status == MATCHED_MATCHING)
+     {
+         ++throughput_publisher_.data_discovery_count_;
++        std::cout << C_RED << ""Pub: DATA Pub Matched "" 
++            << throughput_publisher_.data_discovery_count_ << ""/"" << throughput_publisher_.subscribers_
++            << C_DEF << std::endl;
+     }
+     else
+     {","I think that if `data_discovery_count_ > static_cast<int>(throughput_publisher_.subscribers_)`, then we should not proceed, since we have discovered some unexpected subscriber that can affect the test results. I'd change the comparison to `==` and have and `else if` contemplating the `>` case",nit: `<< std::endl;`
+9718,"@@ -51,6 +51,7 @@
+ #include <iomanip>
+ #include <stdexcept>
+ #include <impl/Kokkos_Error.hpp>
++#include <Cuda/Kokkos_Cuda_Error.hpp>
+ 
+ //----------------------------------------------------------------------------
+ //----------------------------------------------------------------------------",Remove that include,Why is this header needed?
+9719,"@@ -130,6 +130,7 @@ class EasyAdminFormType extends AbstractType
+         return function (Options $options, $value) {
+             return array_replace(array(
+                 'id' => sprintf('%s-%s-form', $options['view'], strtolower($options['entity'])),
++                'class' => sprintf('%s-form', $options['view']),
+             ), $value);
+         };
+     }","IMO this should be defined in the form theme instead. This class should always be there. If the user configured additional css classes, it should be appended instead of replacing the `{view}-form` css class.",Shouldn't this be `%s-form`?
+9720,"@@ -36,6 +36,7 @@ import com.salesforce.androidsdk.auth.OAuth2.TokenEndpointResponse;
+ import com.salesforce.androidsdk.rest.RestClient.AuthTokenProvider;
+ import com.salesforce.androidsdk.rest.RestClient.ClientInfo;
+ import com.salesforce.androidsdk.rest.RestRequest.RestMethod;
++import com.salesforce.androidsdk.util.JSONObjectHelper;
+ 
+ import org.json.JSONArray;
+ import org.json.JSONException;",These tests actually go to the server.,This import is not used.
+9721,"@@ -147,6 +147,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests
+         {
+             var onStartingCalled = false;
+             var onCompletedCalled = false;
++            var onCompleted = Task.Run(() => onCompletedCalled = true);
+ 
+             var hostBuilder = TransportSelector.GetWebHostBuilder()
+                 .UseKestrel()",This test modification isn't correct. This task could run immediately and you wouldn't be able to tell if OnCompleted was called or not.,Why do we need this?
+9722,"@@ -20,11 +20,13 @@ export function setComponentProps(component, props, opts, context, mountAll) {
+ 	if ((component.__ref = props.ref)) delete props.ref;
+ 	if ((component.__key = props.key)) delete props.key;
+ 
+-	if (!component.base || mountAll) {
+-		if (component.componentWillMount) component.componentWillMount();
+-	}
+-	else if (component.componentWillReceiveProps) {
+-		component.componentWillReceiveProps(props, context);
++	if (typeof component.constructor.getDerivedStateFromProps === 'undefined') {
++		if (!component.base || mountAll) {
++			if (component.componentWillMount) component.componentWillMount();
++		}
++		else if (component.componentWillReceiveProps) {
++			component.componentWillReceiveProps(props, context);
++		}
+ 	}
+ 
+ 	if (context && context!==component.context) {",I'd be open to loosening this check if it can help offset the size.,Why do we need this chec
+9723,"@@ -2017,6 +2017,9 @@ defaultdict(<class 'list'>, {'col..., 'col...})]
+         Apply a function that takes pandas DataFrame and outputs pandas DataFrame. The pandas
+         DataFrame given to the function is of a batch used internally.
+ 
++        See also `Transform and apply a function
++        <https://koalas.readthedocs.io/en/stable/user_guide/transform_apply.html>`_.
++
+         .. note:: the `func` is unable to access to the whole input frame. Koalas internally
+             splits the input series into multiple batches and calls `func` with each batch multiple
+             times. Therefore, operations such as global aggregations are impossible. See the example","I'm wondering which we should use, stable or latest?",Can you add a `.. versio
+9724,"@@ -25,7 +25,8 @@ public abstract class BftExtraDataCodec {
+   protected enum EncodingType {
+     ALL,
+     EXCLUDE_COMMIT_SEALS,
+-    EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER
++    EXCLUDE_COMMIT_SEALS_AND_ROUND_NUMBER,
++    EXCLUDE_CMS // TODO-lucas How can we achieve this w/o changing the BftExtraDataCodec base class
+   }
+ 
+   private static final Logger LOG = LogManager.getLogger();",possibly extending EncodingType enum?,@lucaswoj I'm not sure how to achieve this w/o changing the BaseCodec.
+9725,"@@ -26,6 +26,18 @@ describe ""Selenium::WebDriver::TargetLocator"" do
+     end
+   end
+ 
++  it ""should switch to parent frame"" do
++    driver.navigate.to url_for(""iframes.html"")
++
++    iframe = driver.find_element(:tag_name => ""iframe"")
++    driver.switch_to.frame(iframe)
++
++    driver.find_element(:name, 'login').should be_kind_of(WebDriver::Element)
++
++    driver.switch_to.parent_frame
++    driver.find_element(:id, 'iframe_page_heading').should be_kind_of(WebDriver::Element)
++  end
++
+   # switching by name not yet supported by safari
+   not_compliant_on :browser => [:ie, :iphone, :safari] do
+     it ""should switch to a window and back when given a block"" do",I tested it only in Firefox (`./go //rb:firefox-test`),Use the new Ruby 1.9 hash syntax.
+9726,"@@ -27,7 +27,7 @@ using Process = OpenTelemetry.Exporter.Jaeger.Implementation.Process;
+ 
+ namespace OpenTelemetry.Exporter.Jaeger
+ {
+-    public class JaegerExporter : BaseExporter<Activity>
++    public class JaegerExporter : BaseExporter<Activity>, IProviderContainer<TracerProvider>
+     {
+         private readonly int maxPayloadSizeInBytes;
+         private readonly TProtocolFactory protocolFactory;","can we do this in the baseexporter itself? So that exporters just access this.Provider.Resource, and baseexporters take care of populating Provider?",Why do we need this?
+9727,"@@ -156,7 +156,9 @@ module.exports = function(grunt) {
+                     'frontend/express/public/core/session-frequency/javascripts/countly.models.js',
+                     'frontend/express/public/core/session-frequency/javascripts/countly.views.js',
+                     'frontend/express/public/core/events/javascripts/countly.models.js',
+-                    'frontend/express/public/core/events/javascripts/countly.views.js'
++                    'frontend/express/public/core/events/javascripts/countly.views.js',
++                    'frontend/express/public/core/events/javascripts/countly.events.models.js',
++                    'frontend/express/public/core/events/javascripts/countly.events.views.js'
+                 ],
+                 dest: 'frontend/express/public/javascripts/min/countly.lib.concat.js'
+             }",what is the difference between `/core/events/javascripts/countly.views.js` and `/core/events/javascripts/countly.events.views.js`,I'm not sure if this is the right place to put this. I think it should
+9728,"@@ -16,6 +16,10 @@ axe.a11yCheck = function (context, options, callback) {
+ 		options = {};
+ 	}
+ 
++	if (!('iframes' in options)) {
++		options.iframes = true;
++	}
++
+ 	var audit = axe._audit;
+ 	if (!audit) {
+ 		throw new Error('No audit configured');",We should make sure this is also supported by `axe.run`. Perhaps moving it into run-rules would cover both API methods more easily?,Why is this needed?
+9729,"@@ -46,9 +46,9 @@ class MemoryBasedStorage(StorageBase):
+     def set_record_timestamp(self, collection_id, parent_id, record,
+                              modified_field=DEFAULT_MODIFIED_FIELD,
+                              last_modified=None):
+-        timestamp = self._bump_timestamp(collection_id, parent_id, record,
+-                                         modified_field,
+-                                         last_modified=last_modified)
++        timestamp = self._bump_and_store_timestamp(collection_id, parent_id, record,
++                                                   modified_field,
++                                                   last_modified=last_modified)
+         record[modified_field] = timestamp
+         return record
+ ","If the `MemoryBasedStorage` relies on a `self._bump_and_store_timestamp()`, then every child class will have to implement it. So it should not be prefixed with `_`. And should raise `NotImplementedError` etc. :)",I think this should
+9730,"@@ -8,7 +8,6 @@ using System.Collections.Generic;
+ 
+ namespace System.Diagnostics
+ {
+-    [MemoryDiagnoser]
+     [BenchmarkCategory(Categories.Libraries)]
+     public class Perf_Activity
+     {",why removed the MemoryDiagnoser attribute?,Why was this remove
+9731,"@@ -3939,7 +3939,16 @@ function getModelsMapForPopulate(model, docs, options) {
+       foreignField = foreignField.call(doc);
+     }
+ 
+-    const ret = convertTo_id(utils.getValue(localField, doc));
++    const localFieldPath = modelSchema.paths[localField];
++    const localFieldGetters = localFieldPath ? localFieldPath.getters : [];
++    let ret;
++
++    if (localFieldGetters.length) {
++      ret = localFieldGetters[0].call(doc, doc[localField]);
++    } else {
++      ret = convertTo_id(utils.getValue(localField, doc));
++    }
++
+     const id = String(utils.getValue(foreignField, doc));
+     options._docs[id] = Array.isArray(ret) ? ret.slice() : ret;
+ ","Why do this instead of `localFieldPath.applyGetters(doc[localField], doc)` ?",I don't think this 
+9732,"@@ -186,15 +186,6 @@ SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if match count is negative"") {
+         invalid_argument);
+ }
+ 
+-SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if match count is positive"") {
+-    REQUIRE_THROWS_AS(
+-        (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_type>(
+-            false,
+-            isomorphism_kind::induced,
+-            1)),
+-        unimplemented);
+-}
+-
+ // SUBGRAPH_ISOMORPHISM_BADARG_TEST(""Throws if semantic match is true"") {
+ //     REQUIRE_THROWS_AS(
+ //         (this->check_subgraph_isomorphism<double_triangle_target_type, double_triangle_target_type>(",Just for a check. Do you really want to delete this?,Why was this test removed?
+9733,"@@ -10,8 +10,10 @@ import (
+ 	""context""
+ 	""os""
+ 
++	""github.com/golang/protobuf/proto""
+ 	""github.com/iotexproject/iotex-core/actpool""
+ 	""github.com/iotexproject/iotex-core/blockchain""
++	""github.com/iotexproject/iotex-core/blockchain/action""
+ 	""github.com/iotexproject/iotex-core/blocksync""
+ 	""github.com/iotexproject/iotex-core/config""
+ 	""github.com/iotexproject/iotex-core/consensus""",github.com/golang/protobuf/proto group in next group,nit: remove empty line
+9734,"@@ -64,6 +64,7 @@ var rootSubcmdsDaemon = map[string]*cmds.Command{
+ 	""mining"":    miningCmd,
+ 	""mpool"":     mpoolCmd,
+ 	""orderbook"": orderbookCmd,
++	""paych"":     paymentChannelCmd,
+ 	""ping"":      pingCmd,
+ 	""show"":      showCmd,
+ 	""swarm"":     swarmCmd,",Nit: what about just `pay`? Is there some other subcommand that would conflict with?,This should be `paymentCha
+9735,"@@ -55,8 +55,13 @@ public class Scalars {
+           if (!(input instanceof StringValue)) {
+             throw new CoercingParseLiteralException(""Value is not any Address : '"" + input + ""'"");
+           }
++          String inputValue = ((StringValue) input).getValue();
++          if (!inputValue.startsWith(""0x"")) {
++            throw new CoercingParseLiteralException(
++                ""Address value '"" + inputValue + ""' is not prefixed with 0x"");
++          }
+           try {
+-            return Address.fromHexStringStrict(((StringValue) input).getValue());
++            return Address.fromHexStringStrict(inputValue);
+           } catch (final IllegalArgumentException e) {
+             throw new CoercingParseLiteralException(""Value is not any Address : '"" + input + ""'"");
+           }","Just for the sake of keeping things logically co-located, I'd like to see this functionality in `Quantity.java` which has a lot of utility methods related to this. Maybe a `static` method like `Quantity.isValid(String string)`?",Why do we need this check?
+9736,"@@ -72,7 +72,7 @@ public abstract class FlinkTestBase extends AbstractTestBase {
+     return tEnv;
+   }
+ 
+-  List<Object[]> sql(String query, Object... args) {
++  public List<Object[]> sql(String query, Object... args) {
+     TableResult tableResult = getTableEnv().executeSql(String.format(query, args));
+     tableResult.getJobClient().ifPresent(c -> {
+       try {",How about use `protected` ?,why is this needed?
+9737,"@@ -32,6 +32,12 @@ func (ih *IntermediateHashes) WillUnloadBranchNode(prefixAsNibbles []byte, nodeH
+ 	if len(prefixAsNibbles) == 0 || len(prefixAsNibbles)%2 == 1 {
+ 		return
+ 	}
++
++	// special case. Store Account.Root for long time
++	if len(prefixAsNibbles) == common.HashLength*2 {
++		return
++	}
++
+ 	InsertCounter.Inc(1)
+ 
+ 	buf := pool.GetBuffer(keyBufferSize)",Should it not be `common.HashLength*2 + common.IncarnationLength` ?,Why do we need this
+9738,"@@ -422,7 +422,8 @@ public class FlowRunner extends EventHandler implements Runnable {
+ 
+       // If a job is seen as failed or killed due to failing SLA, then we set the parent flow to
+       // FAILED_FINISHING
+-      if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node.isKilledBySLA())) {
++      if (node.getStatus() == Status.FAILED || (node.getStatus() == Status.KILLED && node
++          .isKilledBySLA())) {
+         // The job cannot be retried or has run out of retry attempts. We will
+         // fail the job and its flow now.
+         if (!retryJobIfPossible(node)) {",those change are done by save plugin.,Why is this change 
+9739,"@@ -37,7 +37,9 @@ public class MimeHeader {
+     };
+ 
+     protected ArrayList<Field> mFields = new ArrayList<Field>();
+-    private String mCharset = null;
++    
++    // use UTF-8 as standard to prevent NullPointerExceptions
++    private String mCharset = ""UTF-8"";
+ 
+     public void clear() {
+         mFields.clear();",There were problems with NullPointerException and with german Umlauts in message titles (I know they're not allowed in the specifiation but they caused my K-9-Inbox to not work at all) I don't know if this is related to PGP/Mime,Why is this needed?
+9740,"@@ -0,0 +1,11 @@
++// <copyright file=""IEvent.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Abstractions
++{
++    internal interface IEvent
++    {
++    }
++}",This is an appsec concept right? Should it live in the Appsec namespace?,Why do we need this interface?
+9741,"@@ -11,11 +11,10 @@ func main() {
+ 	machine.I2C0.Configure(machine.I2CConfig{})
+ 
+ 	// Init BlinkM
+-	machine.I2C0.WriteTo(0x09, []byte(""o""))
++	machine.I2C0.WriteRegister(0x09, 'o', nil)
+ 
+ 	version := []byte{0, 0}
+-	machine.I2C0.WriteTo(0x09, []byte(""Z""))
+-	machine.I2C0.ReadFrom(0x09, version)
++	machine.I2C0.ReadRegister(0x09, 'Z', version)
+ 	println(""Firmware version:"", string(version[0]), string(version[1]))
+ 
+ 	count := 0","I'd personally recommend having the demo check for error, unless it's worthless.",This should be `WriteRegister(
+9742,"@@ -582,7 +582,7 @@ public class DistributorTest {
+         );
+ 
+         Session firefoxSession = distributor.newSession(createRequest(firefoxPayload)).getSession();
+-        LOG.info(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
++        LOG.finer(String.format(""Firefox Session %d assigned to %s"", i, chromeSession.getUri()));
+ 
+         boolean inFirefoxNodes = firefoxNodes.stream().anyMatch(node -> node.getUri().equals(firefoxSession.getUri()));
+         boolean inChromeNodes = chromeNodes.stream().anyMatch(node -> node.getUri().equals(chromeSession.getUri()));","Since this is in a test, I imagine that the choice of `info` level was deliberate.",Why is this being changed to `
+9743,"@@ -1,10 +1,10 @@
+ const Plugin = require('../../core/Plugin')
+ const Translator = require('../../core/Translator')
+ const dragDrop = require('drag-drop')
+-const Dashboard = require('./Dashboard')
++const DashboardUI = require('./Dashboard')
+ const StatusBar = require('../StatusBar')
+ const Informer = require('../Informer')
+-const { findAllDOMElements } = require('../../core/Utils')
++const { findAllDOMElements, toArray } = require('../../core/Utils')
+ const prettyBytes = require('prettier-bytes')
+ const { defaultTabIcon } = require('./icons')
+ ",good call swapping these names! makes more sense this way i think,Why do we need this change?
+9744,"@@ -13,8 +13,12 @@ import options from './options';
+  */
+ export function render(vnode, parentDom, replaceNode) {
+ 	if (options._root) options._root(vnode, parentDom);
+-	let oldVNode = replaceNode && replaceNode._children || parentDom._children;
+ 
++	let oldVNode = replaceNode && replaceNode._children || parentDom._children;
++	let isHydrating = false;
++	if (replaceNode === null) {
++		isHydrating = true;
++	}
+ 	vnode = createElement(Fragment, null, [vnode]);
+ 
+ 	let mounts = [];",Maybe leaving this out will save some bytes as in let `let isHydrating = replaceNode === null`,Why do we need this?
+9745,"@@ -298,6 +298,10 @@ class RustGenerator : public BaseGenerator {
+ 
+     assert(!cur_name_space_);
+ 
++    // Generate imports for the global scope in case no namespace is used
++    // in the schema file.
++    GenNamespaceImports(0);
++
+     // Generate all code in their namespaces, once, because Rust does not
+     // permit re-opening modules.
+     //","Let's manually create one extra whitespace line here (code_ += """")",Why do we need this?
+9746,"@@ -138,6 +138,17 @@ func (bp *BucketPool) Count() uint64 {
+ 	return bp.total.count
+ }
+ 
++// Construct returns a copy of the bucket pool
++func (bp *BucketPool) Construct(enableSMStorage bool) *BucketPool {
++	pool := BucketPool{}
++	pool.enableSMStorage = enableSMStorage
++	pool.total = &totalAmount{
++		amount: new(big.Int).Set(bp.total.amount),
++		count:  bp.total.count,
++	}
++	return &pool
++}
++
+ // SyncPool sync the data from state manager
+ func (bp *BucketPool) SyncPool(sm protocol.StateManager) error {
+ 	if bp.enableSMStorage {",nit: copy or clone,Why do we need a cop
+9747,"@@ -182,3 +182,14 @@ func (d Document) Decode(dec Decoder) error {
+ 	}
+ 	return decodeStruct(d.s, dec)
+ }
++
++// RevisionOn returns whether or not we should write a revision value when we
++// write a document. It could be either a map or a struct with a revision key or
++// field named after revField.
++func (d Document) RevisionOn(revField string) bool {
++	if d.m != nil {
++		_, ok := d.m[revField]
++		return ok
++	}
++	return d.fields.MatchFold(revField) != nil
++}","I think this can be called `HasField`, because that's what it's doing. It really is independent of revision.",I'm not sure if this
+9748,"@@ -16,7 +16,10 @@ import java.math.BigDecimal;
+ import java.time.Year;
+ import java.util.function.Predicate;
+ 
+-import static javaslang.API.*;
++import static javaslang.API.$;
++import static javaslang.API.Case;
++import static javaslang.API.Match;
++import static javaslang.API.run;
+ import static javaslang.MatchTest_DeveloperPatterns.Developer;
+ import static javaslang.Patterns.*;
+ import static javaslang.Predicates.*;",Is this to avoid collisions?,I don't think we need these imports.
+9749,"@@ -79,7 +79,7 @@ func MakeTransactionPool(ledger *ledger.Ledger, cfg config.Local) *TransactionPo
+ 		expiredTxCount:  make(map[basics.Round]int),
+ 		ledger:          ledger,
+ 		statusCache:     makeStatusCache(cfg.TxPoolSize),
+-		logStats:        cfg.EnableAssembleStats,
++		logStats:        cfg.EnableProcessBlockStats,
+ 		expFeeFactor:    cfg.TxPoolExponentialIncreaseFactor,
+ 		txPoolMaxSize:   cfg.TxPoolSize,
+ 	}","nit: a better name for this variable would be enableLogStats, but it's beyond the scope of your change.",Why did you change this?
+9750,"@@ -256,7 +256,6 @@ class CheckerTestCase(object):
+ # Init
+ test_reporter = TestReporter()
+ linter = PyLinter(pylint.config.Configuration())
+-linter.set_reporter(test_reporter)
+ linter.config.persistent = 0
+ checkers.initialize(PluginRegistry(linter))
+ ","Because linters don't handle reports now, this was breaking the setup for _all_ tests. I deleted it so I could run my tests, but I didn't check the impact on other tests as many tests are failing at the moment.",Why is this removed?
+9751,"@@ -138,6 +138,12 @@ func main() {
+ 		updateCommand,
+ 	}
+ 	app.Before = func(context *cli.Context) error {
++
++		// do nothing if logrus was already initialized in init.go
++		if logrus.StandardLogger().Out != logrus.New().Out {
++			return nil
++		}
++
+ 		if context.GlobalBool(""debug"") {
+ 			logrus.SetLevel(logrus.DebugLevel)
+ 		}",I'm not really a fan of this -- why not set up logging for `init` here (or setting a global flag) rather than doing it this way?,Why do we need this?
+9752,"@@ -1,4 +1,14 @@
+-/* global axe */
++/**
++ * Namespace `axe.imports` which holds required external dependencies
++ *
++ * @namespace imports
++ * @memberof axe
++ */
++export { default as axios } from 'axios';
++export { CssSelectorParser } from 'css-selector-parser';
++export { default as doT } from '@deque/dot';
++export { default as emojiRegexText } from 'emoji-regex';
++export { default as memoizee } from 'memoizee';
+ 
+ /**
+  * Note:",This is my favorite part of this PR. Being able to `import` 3rd party tools will hugely improve our workflows. :heart:,Why do we need to export these?
+9753,"@@ -0,0 +1,19 @@
++/**
++ * BSD-style license; for more info see http://pmd.sourceforge.net/license.html
++ */
++
++package net.sourceforge.pmd.lang.java.rule.multithreading;
++
++import java.security.MessageDigest;
++
++/**
++ * Using a MessageDigest which is static can cause
++ * unexpected results when used in a multi-threaded environment. This rule will
++ * find static MessageDigest which are used in an unsynchronized manner.
++ */
++public class UnsynchronizedStaticMessageDigestRule extends UnsynchronizedStaticFormatterRule {
++
++    public UnsynchronizedStaticMessageDigestRule() {
++        super(MessageDigest.class);
++    }
++}","having this extend `UnsynchronizedStaticFormatterRule` seems semantically incorrect even if it works  we should probably refactor `UnsynchronizedStaticFormatterRule` into a `UnsynchronizedStaticAccessRule` which can be configured through properties to track unsynchronized static access to any given types (with proper defaults to include `Formatter` and `MessageDigest`). This will also scale better as new types are suggested to have a thread-safe access enforced. The `UnsynchronizedStaticFormatterRule` can be marked as deprecated at the ruleset level, point to the new implementation, overriding the property defaults to keep just looking for `Formatter`. Moreover, the `THREAD_SAFE_FORMATTER` static should probably be replaced with a property of thread-safe classes to ignore, once again with proper defaults.",Why do we need this rule?
+9754,"@@ -126,6 +126,8 @@ namespace Nethermind.Synchronization.ParallelSync
+         }
+ 
+         public long FindBestHeader() => _blockTree.BestSuggestedHeader?.Number ?? 0;
++        
++        public Keccak FindBestHeaderHash() => _blockTree.BestSuggestedHeader?.Hash ?? Keccak.Zero;
+ 
+         public long FindBestFullBlock() => Math.Min(FindBestHeader(), _blockTree.BestSuggestedBody?.Number ?? 0); // avoiding any potential concurrency issue
+ ",Keccak.Zero should not be used to mean null,Why do we need this?
+9755,"@@ -40,5 +40,12 @@ namespace OpenTelemetry.Metrics.Tests
+                     new object[] { ""my_metric2"" },
+                     new object[] { new string('m', 63) },
+            };
++
++        public static IEnumerable<object[]> InvalidHistogramBounds
++           => new List<object[]>
++           {
++                    new object[] { new double[] { 0, 0 } },
++                    new object[] { new double[] { 1, 0 } },
++           };
+     }
+ }",perhaps add a couple more edge cases.,nit: `InvalidHistogramBounds =>
+9756,"@@ -4,11 +4,15 @@ package Example
+ 
+ import ""strconv""
+ 
++/// Composite components of Monster color.
+ type Color byte
+ 
+ const (
+ 	ColorRed   Color = 1
++	/// \brief color Green
++	/// Green is bit_flag with value (1u << 1)
+ 	ColorGreen Color = 2
++	/// \brief color Blue (1u << 3)
+ 	ColorBlue  Color = 8
+ )
+ ","Is this blank line needed, or typo?",`/// \brief color Green is bit_flag with value (1u << 1)`
+9757,"@@ -122,12 +122,6 @@ func (p *blockPrefetcher) run() {
+ func (p *blockPrefetcher) request(priority int, kmd KeyMetadata,
+ 	ptr BlockPointer, block Block, entryName string,
+ 	doneCh, errCh chan<- struct{}) error {
+-	if _, err := p.config.BlockCache().Get(ptr); err == nil {
+-		return nil
+-	}
+-	if err := checkDataVersion(p.config, path{}, ptr); err != nil {
+-		return err
+-	}
+ 	select {
+ 	case p.progressCh <- prefetchRequest{
+ 		priority, kmd, ptr, block, doneCh, errCh}:",This was a major PitA to find: it was causing some huge goroutine leaks and unfinished prefetches.,Why is this removed?
+9758,"@@ -84,10 +84,8 @@ module Mongoid #:nodoc
+       #
+       # @since 2.1.8
+       def prohibited_methods
+-        @prohibited_methods ||= MODULES.inject([]) do |methods, mod|
+-          methods.tap do |mets|
+-            mets << mod.instance_methods.map{ |m| m.to_sym }
+-          end
++        @prohibited_methods ||= MODULES.map do |mod|
++          mod.instance_methods.map{ |m| m.to_sym }
+         end.flatten
+       end
+     end",you can use Enum#flat_map here.,I think this should be `mod.instance_methods.map(&:to_sym
+9759,"@@ -155,6 +155,7 @@ public class AbstractVmNode extends AbstractNode implements VmNode {
+      */
+     @Deprecated
+     public void dump(final String prefix, final boolean recurse, final Writer writer) {
++        @SuppressWarnings(""PMD.CloseResource"")
+         final PrintWriter printWriter = writer instanceof PrintWriter ? (PrintWriter) writer : new PrintWriter(writer);
+         printWriter.println(toString(prefix));
+         if (children != null && recurse) {","Same potential FP: The stream is provided from outside (here as a method parameter), so we should not be responsible here to close it, should we?",Why is this needed?
+9760,"@@ -26,11 +26,12 @@ Upcase::Application.configure do
+   config.log_level = :info
+   config.log_formatter = ::Logger::Formatter.new
+ 
+-  config.middleware.use \
+-    Rack::SslEnforcer,
+-    hsts: false,
+-    strict: true,
+-    redirect_to: ""https://#{ENV[""APP_DOMAIN""]}""
++  config.force_ssl = true
++  config.middleware.insert_before(
++    ActionDispatch::SSL,
++    Rack::CanonicalHost,
++    ENV.fetch(""APP_DOMAIN""),
++  )
+ 
+   config.action_mailer.delivery_method = :smtp
+   config.action_mailer.smtp_settings = MAIL_SETTINGS",Put a comma after the last parameter of a multiline method call.,Why do we need to force ssl here?
+9761,"@@ -67,10 +67,8 @@ public class VerbsManager {
+                 output -> {
+                     final Value verbClass = (Value) output;
+ 
+-                    final Verb verb = verbClass.newInstance().as(Verb.class);
+-
+                     try {
+-                        verb.install(container);
++                        verbClass.invokeMember(""install"", container);
+                     } catch (ScriptException se) {
+                         errorCallback.accept(se);
+                     }",It seems like this is the only way to access javascript `static` methods from Java.,Why is this change needed?
+9762,"@@ -4,8 +4,6 @@
+  * A temporary workaround to ensure the same version of React
+  * is always used across multiple entrypoints.
+  *
+- * @private
+- *
+  * Site Kit by Google, Copyright 2020 Google LLC
+  *
+  * Licensed under the Apache License, Version 2.0 (the ""License"");",Why was this removed here?,Why did you remove this?
+9763,"@@ -4,12 +4,6 @@
+ 
+ package pslice
+ 
+-import ""github.com/ethersphere/bee/pkg/swarm""
+-
+-func PSlicePeers(p *PSlice) []swarm.Address {
+-	return p.peers
+-}
+-
+ func PSliceBins(p *PSlice) []uint {
+ 	return p.bins
+ }","i am aware that you did not add these, but might i ask why we need these one-liner funcs instead of just exporting the struct fields in the first place?",Why is this removed?
+9764,"@@ -296,7 +296,7 @@ abstract class BaseTableScan implements TableScan {
+       }
+       requiredFieldIds.addAll(selectedIds);
+ 
+-      return TypeUtil.select(schema, requiredFieldIds);
++      return TypeUtil.project(schema, requiredFieldIds);
+ 
+     } else if (context.projectedSchema() != null) {
+       return context.projectedSchema();",I agree with this because it is the opposite of `GetProjectedIds` used above.,Why is this change needed?
+9765,"@@ -632,7 +632,7 @@ class InstanceAttribute(dict):
+                    'disableApiTermination',
+                    'instanceInitiatedShutdownBehavior',
+                    'rootDeviceName', 'blockDeviceMapping', 'sourceDestCheck',
+-                   'groupSet']
++                   'groupSet', 'productCodes', 'ebsOptimized',]
+ 
+     def __init__(self, parent=None):
+         dict.__init__(self)",add 'sriovNetSupport' also to this list,Why do we need this?
+9766,"@@ -61,7 +61,9 @@ public class Preferences {
+         }
+         if ((newAccount != null) && newAccount.getAccountNumber() != -1) {
+             accounts.put(newAccount.getUuid(), newAccount);
+-            accountsInOrder.add(newAccount);
++            if (!accountsInOrder.contains(newAccount)) {
++                accountsInOrder.add(newAccount);
++            }
+             newAccount = null;
+         }
+     }",Code style issue: `if` body is not wrapped in braces.,I don't think this is corr
+9767,"@@ -81,9 +81,8 @@ public class ItunesSearchFragment extends Fragment {
+         if (result != null && result.size() > 0) {
+             gridView.setVisibility(View.VISIBLE);
+             txtvEmpty.setVisibility(View.GONE);
+-            for (Podcast p : result) {
+-                adapter.add(p);
+-            }
++
++            adapter.addAll(result);
+             adapter.notifyDataSetInvalidated();
+         } else {
+             gridView.setVisibility(View.GONE);",Call requires API level 11 (we are on 10),I don't think this change 
+9768,"@@ -97,7 +97,7 @@ namespace Nethermind.AuRa.Test.Contract
+                 var gasLimitContract = new BlockGasLimitContract(new AbiEncoder(), blockGasLimitContractTransition.Value, blockGasLimitContractTransition.Key,
+                     new ReadOnlyTxProcessingEnv(
+                         DbProvider,
+-                        new TrieStore(DbProvider.StateDb, LimboLogs.Instance),
++                        new TrieStore(DbProvider.StateDb, LimboLogs.Instance).AsReadOnly(DbProvider.StateDb),
+                         BlockTree, SpecProvider, LimboLogs.Instance));
+                 
+                 GasLimitOverrideCache = new AuRaContractGasLimitOverride.Cache();",do we need to pass the DB if it is the same,Why do we need this?
+9769,"@@ -300,6 +300,14 @@ func (ccs *crChains) addOp(ptr BlockPointer, op op) error {
+ }
+ 
+ func (ccs *crChains) makeChainForOp(op op) error {
++	// Ignore gc ops -- their unref semantics differ from the other
++	// ops.  Note that this only matters for old gcOps: new gcOps
++	// only unref the block ID, and not the whole pointer, so they
++	// wouldn't confuse chain creation.
++	if _, isGCOp := op.(*gcOp); isGCOp {
++		return nil
++	}
++
+ 	// First set the pointers for all updates, and track what's been
+ 	// created and destroyed.
+ 	for _, update := range op.AllUpdates() {",Might be a good idea to rename the variable so it doesn't shadow the type.,I don't think this i
+9770,"@@ -14,7 +14,13 @@ class Tag extends BaseItem {
+ 	}
+ 
+ 	static async noteIds(tagId) {
+-		const rows = await this.db().selectAll('SELECT note_id FROM note_tags WHERE tag_id = ?', [tagId]);
++		// Get NoteIds of that are tagged with current tag or its descendants
++		const rows = await this.db().selectAll(`WITH RECURSIVE
++												parent_of(id, child_id) AS 
++												(SELECT id, id FROM tags where id=?
++												UNION ALL
++												SELECT parent_of.id, tags2.id FROM parent_of JOIN tags AS tags2 ON parent_of.child_id=tags2.parent_id)
++												SELECT note_id FROM note_tags WHERE tag_id IN (SELECT child_id from parent_of)`, [tagId]);
+ 		const output = [];
+ 		for (let i = 0; i < rows.length; i++) {
+ 			output.push(rows[i].note_id);",Again I'd prefer if this is done in JavaScript rather than in SQL.,I don't think we nee
+9771,"@@ -1848,7 +1848,7 @@ function fullyResolveKeys(obj) {
+  * If there are no listeners registered with the flow, the error will be
+  * rethrown to the global error handler.
+  *
+- * Refer to the {@link ./promise} module documentation fora  detailed
++ * Refer to the {@link ./promise} module documentation for a  detailed
+  * explanation of how the ControlFlow coordinates task execution.
+  *
+  * @final",there is still `2` spaces after `a` here.. :P,This should be rever
+9772,"@@ -25,6 +25,17 @@ import (
+ 
+ const defaultMountFlags = syscall.MS_NOEXEC | syscall.MS_NOSUID | syscall.MS_NODEV
+ 
++// setupDev returns true if /dev needs to be set up.
++func needsSetupDev(config *configs.Config) (bool, error) {
++	setupDev := true
++	for _, m := range config.Mounts {
++		if m.Device == ""bind"" && m.Destination == ""/dev"" {
++			setupDev = false
++		}
++	}
++	return setupDev, nil
++}
++
+ // setupRootfs sets up the devices, mount points, and filesystems for use inside a
+ // new mount namespace.
+ func setupRootfs(config *configs.Config, console *linuxConsole, pipe io.ReadWriter) (err error) {","What we did in docker before, when working directly with libcontainer, is check if the source is `/dev` and the destination has a `/dev/` prefix. This implementation is probably ok. If someone is mounting their own `/dev` I would expect it to be pre-configured and not need the extra check for if it's the host's `/dev`. (that said, I've not tested yet, just reading through the code)","nit: `return false, nil`"
+9773,"@@ -501,6 +501,10 @@ type Configuration struct {
+ 	PleaseLocation string
+ 	// buildEnvStored is a cached form of BuildEnv.
+ 	buildEnvStored *storedBuildEnv
++
++	FeatureFlags struct {
++		JavaBinaryExecutableByDefault bool `help:""Makes java_binary rules self executable by default. Target release version 16."" var:""FF_JAVA_SELF_EXEC""`
++	}
+ }
+ 
+ // An Alias represents aliases in the config.","you should add some help on the struct too so that `plz halp featureflags` has a bit of explanation. Might be worth mentioning that these generally won't remain around very long relative to other config options (i.e. they're typically enabling ""preview"" features for the next major).",I don't think we need th
+9774,"@@ -302,7 +302,7 @@ func newSessionManagerFactory(
+ 	nodeOptions node.Options,
+ ) session.ManagerFactory {
+ 	return func(dialog communication.Dialog) *session.Manager {
+-		providerBalanceTrackerFactory := func(consumer, provider, issuer identity.Identity) (session.BalanceTracker, error) {
++		providerBalanceTrackerFactory := func(consumer, receiver, issuer identity.Identity) (session.BalanceTracker, error) {
+ 			// if the flag ain't set, just return a noop balance tracker
+ 			if !nodeOptions.ExperimentPayments {
+ 				return payments_noop.NewSessionBalance(), nil","Maybe `consumerID, receiverID, issuerID`, at least it's a convension in overal repo",receiver is not used in 
+9775,"@@ -14,6 +14,12 @@
+ 
+ // Package s3blob provides an implementation of blob using S3.
+ //
++// For blob.Open URLs, s3blob registers for the ""s3"" protocol.
++// The URL's Host is used as the bucket name.
++// The following query options are supported:
++// - region: The AWS region for requests.
++// Example URL: blob.Open(""s3://mybucket?region=us-east-1"")
++//
+ // It exposes the following types for As:
+ // Bucket: *s3.S3
+ // ListObject: s3.Object for objects, s3.CommonPrefix for ""directories"".",Where does the auth go?,I think this should be `
+9776,"@@ -119,7 +119,10 @@ func ClassifyActions(actions []SealedEnvelope) ([]*Transfer, []*Execution) {
+ }
+ 
+ func calculateIntrinsicGas(baseIntrinsicGas uint64, payloadGas uint64, payloadSize uint64) (uint64, error) {
+-	if payloadGas == 0 || (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize {
++	if payloadGas == 0 {
++		return 0, ErrUnderpriced
++	}
++	if (math.MaxUint64-baseIntrinsicGas)/payloadGas < payloadSize {
+ 		return 0, ErrInsufficientFunds
+ 	}
+ 	return payloadSize*payloadGas + baseIntrinsicGas, nil","0 < minimum gas price, `ErrUnderpriced` is more proper",Why do we need this check?
+9777,"@@ -12,7 +12,7 @@ from sqlalchemy import func
+ from . import app, db
+ from .const import (VALID_EMAIL_RE, VALID_USERNAME_RE, blacklisted_name,
+                     ACTIVATE_SALT, PASSWORD_RESET_SALT, MAX_LINK_AGE,
+-                    CODE_EXP_MINUTES)
++                    CODE_EXP_MINUTES, TOKEN_EXP_DEFAULT)
+ from .mail import (send_activation_email, send_reset_email, send_new_user_email,
+                    send_welcome_email)
+ from .models import ActivationToken, Code, PasswordResetToken, Token, User",these should be alphabetized,Black would make changes.
+9778,"@@ -72,7 +72,7 @@ public class VectorizedDictionaryEncodedParquetValuesReader extends BaseVectoriz
+   }
+ 
+   void readBatchOfDictionaryEncodedLongs(FieldVector vector, int startOffset, int numValuesToRead, Dictionary dict,
+-                                         NullabilityHolder nullabilityHolder) {
++                                         NullabilityHolder nullabilityHolder, int typeWidth) {
+     int left = numValuesToRead;
+     int idx = startOffset;
+     while (left > 0) {","These changes look concerning. It looks like the old offset (only index) must not have been correct. If so, there are places where `getDataBuffer().setLong(...)` and similar methods are called but aren't updated like these. Are those cases bugs as well?",nit: `typeWidth` -> `dicti
+9779,"@@ -164,7 +164,7 @@ type Counters struct {
+ 
+ // flush writes the current state of in memory counters into the given db.
+ func (cs *Counters) flush(db *shed.DB, batch *leveldb.Batch) error {
+-	if cs.dirty.Load() > 1 {
++	if cs.dirty.Load() < 3 {
+ 		return nil
+ 	}
+ 	cs.dirty.CAS(3, 2)",the CAS call here is now wrong since dirty will never be 3 anymore. it might be useful to sweep through the entire usage of this field to see that everything is correct,Why did you change this?
+9780,"@@ -18,7 +18,11 @@ use Symfony\Component\Validator\Constraints\NotBlank;
+ use Symfony\Component\Validator\Constraints\NotEqualTo;
+ use Symfony\Component\Validator\ExecutionContextInterface;
+ use Thelia\Core\Translation\Translator;
++use Thelia\Model\Base\CountryQuery;
+ use Thelia\Model\Base\LangQuery;
++use Thelia\Model\Base\ModuleQuery;
++use Thelia\Model\Module;
++use Thelia\Module\BaseModule;
+ 
+ /**
+  * Allow to build a form Coupon",Base model is imported here,Please sort imports by length.
+9781,"@@ -16,6 +16,7 @@
+  */
+ package org.apache.servicecomb.serviceregistry.task;
+ 
++import org.apache.servicecomb.foundation.common.event.EventManager;
+ import org.apache.servicecomb.serviceregistry.RegistryUtils;
+ import org.apache.servicecomb.serviceregistry.api.registry.Microservice;
+ import org.apache.servicecomb.serviceregistry.api.registry.MicroserviceInstance;",import but not used,Why is this import needed?
+9782,"@@ -193,7 +193,7 @@ public final class VectorizedParquetDefinitionLevelReader extends BaseVectorized
+         case RLE:
+           if (currentValue == maxDefLevel) {
+             dictionaryEncodedValuesReader.readBatchOfDictionaryEncodedLongs(vector,
+-                idx, numValues, dict, nullabilityHolder);
++                idx, numValues, dict, nullabilityHolder, typeWidth);
+           } else {
+             setNulls(nullabilityHolder, idx, numValues, validityBuffer);
+           }",What about the call in `case PACKED` just below? Does that also need to use the `typeWidth`?,Why do we need typeWidth here?
+9783,"@@ -8,13 +8,14 @@ import (
+ 	""errors""
+ 
+ 	""github.com/ethersphere/bee/pkg/collection""
++	""github.com/ethersphere/bee/pkg/encryption""
+ 	""github.com/ethersphere/bee/pkg/swarm""
+ )
+ 
+ var (
+ 	_                           = collection.Entry(&Entry{})
+ 	serializedDataSize          = swarm.SectionSize * 2
+-	encryptedSerializedDataSize = swarm.EncryptedReferenceSize * 2
++	encryptedSerializedDataSize = encryption.ReferenceSize * 2
+ )
+ 
+ // Entry provides addition of metadata to a data reference.",not sure i like this change. The encryption package does not need to know about references,This should be `swarm.Referenc
+9784,"@@ -280,6 +280,7 @@ ifneq ($(MAKECMDGOALS),clean)
+   ifeq ($(llvm_version),3.9.1)
+   else ifeq ($(llvm_version),5.0.2)
+   else ifeq ($(llvm_version),6.0.1)
++  else ifeq ($(llvm_version),7.0.0) # this is what is shipped with ubuntu bionic llvm-7 package right now
+   else ifeq ($(llvm_version),7.0.1)
+   else
+     $(warning WARNING: Unsupported LLVM version: $(llvm_version))","This shouldn't be added. It's not supported. It's not event the default. If we are going to support this, we need to have CI for it.",# this is what is shipped with ubuntu bionic llvm-7 package right now
+9785,"@@ -6,6 +6,5 @@ type API interface {
+ 	Client() Client
+ 	Daemon() Daemon
+ 	Ping() Ping
+-	RetrievalClient() RetrievalClient
+ 	Swarm() Swarm
+ }",omg only four left!!!!,Why was this removed?
+9786,"@@ -214,6 +214,12 @@ func (c *Client) InstallParticipationKeys(inputfile string) (part account.Partic
+ 		return
+ 	}
+ 
++	proto, ok := config.Consensus[protocol.ConsensusCurrentVersion]
++	if !ok {
++		err = fmt.Errorf(""Unknown consensus protocol %s"", protocol.ConsensusCurrentVersion)
++		return
++	}
++
+ 	// After successful install, remove the input copy of the
+ 	// partkey so that old keys cannot be recovered after they
+ 	// are used by algod.  We try to delete the data inside","I'm not really sure how this would happen. once the binary is already compiled, the config.Consensus should already have the entry for protocol.ConsensusCurrentVersion.",I don't think this is the right error message. It should be something
+9787,"@@ -160,7 +160,7 @@ class LuigiTestCase(unittest.TestCase):
+         temp = CmdlineParser._instance
+         try:
+             CmdlineParser._instance = None
+-            run_exit_status = luigi.run(['--local-scheduler', '--no-lock'] + args)
++            run_exit_status = luigi.run(args + ['--local-scheduler', '--no-lock'])
+         finally:
+             CmdlineParser._instance = temp
+         return run_exit_status",Is there a reason for the order swap here?,Why is this change needed?
+9788,"@@ -241,8 +241,9 @@ namespace Microsoft.VisualStudio.TestPlatform.CrossPlatEngine.Hosting
+                 }
+             }
+ 
+-            EqtTrace.Error(""Unable to find path for dotnet host"");
+-            return dotnetExeName;
++            string errorMessage = String.Format(Resources.NoDotnetDotExeFileExist, dotnetExeName);
++            EqtTrace.Error(errorMessage);
++            throw new FileNotFoundException(errorMessage);
+         }
+ 
+         private string GetTestHostPath(string runtimeConfigDevPath, string depsFilePath, string sourceDirectory)",Where will this exception get caught ?,Should this be a `NotFoundf`?
+9789,"@@ -49,9 +49,10 @@ var mainEtherAccPass = ""localaccount""
+ type CliWallet struct {
+ 	txOpts           *bind.TransactOpts
+ 	Owner            common.Address
+-	backend          *ethclient.Client
++	Backend          *ethclient.Client
+ 	identityRegistry registry.IdentityRegistryTransactorSession
+ 	tokens           mysttoken.MystTokenTransactorSession
++	KS               *keystore.KeyStore
+ }
+ 
+ // RegisterIdentity registers identity with given data on behalf of user",Why this field is made public?,Why do we need this?
+9790,"@@ -35,16 +35,16 @@
+ #include ""proj_internal.h""
+ #include ""proj_internal.h""
+ 
+-static int is_nodata(float value)
++static int is_nodata(float value, double vmultiplier)
+ {
+     /* nodata?  */
+     /* GTX official nodata value if  -88.88880f, but some grids also */
+     /* use other  big values for nodata (e.g naptrans2008.gtx has */
+     /* nodata values like -2147479936), so test them too */
+-    return value > 1000 || value < -1000 || value == -88.88880f;
++    return value * vmultiplier > 1000 || value * vmultiplier < -1000 || value == -88.88880f;
+ }
+ 
+-static double read_vgrid_value( PJ *defn, PJ_LP input, int *gridlist_count_p, PJ_GRIDINFO **tables, struct CTABLE *ct) {
++static double read_vgrid_value( PJ *defn, PJ_LP input, double vmultiplier, int *gridlist_count_p, PJ_GRIDINFO **tables, struct CTABLE *ct) {
+     int  itable = 0;
+     double value = HUGE_VAL;
+     double grid_x, grid_y;",Is the `vmultiplier` only used here for checking if a grid value is nodata?,`vmultiplier` should be `vola
+9791,"@@ -239,7 +239,7 @@ func signTestCert(key crypto.Signer) *x509.Certificate {
+ 		SerialNumber:          serialNumber,
+ 		SignatureAlgorithm:    x509.SHA256WithRSA,
+ 		Subject: pkix.Name{
+-			Organization: []string{defaultOrganization},
++			Organization: []string{""cert-manager""},
+ 			CommonName:   commonName,
+ 		},
+ 		NotBefore: time.Now(),","Is this deliberate? If so, why?",Why is this change needed?
+9792,"@@ -5,7 +5,7 @@ from mitmproxy import exceptions
+ from mitmproxy.net import tls as net_tls
+ from mitmproxy.proxy.protocol import base
+ 
+-# taken from https://testssl.sh/openssl-rfc.mappping.html
++# taken from https://testssl.sh/openssl-rfc.mapping.html
+ CIPHER_ID_NAME_MAP = {
+     0x00: 'NULL-MD5',
+     0x01: 'NULL-MD5',",both URL works. I corrected it anyway.,Why did you change this?
+9793,"@@ -43,12 +43,14 @@ import java.util.Collection;
+  * @since 5.0
+  */
+ public class PrePostAdviceReactiveMethodInterceptor implements MethodInterceptor {
+-	private Authentication anonymous = new AnonymousAuthenticationToken(""key"", ""anonymous"",
+-		AuthorityUtils.createAuthorityList(""ROLE_ANONYMOUS""));
++	private final Authentication anonymous = new AnonymousAuthenticationToken(""key"", ""anonymous"",
++			AuthorityUtils.createAuthorityList(""ROLE_ANONYMOUS""));
+ 
+ 	private final MethodSecurityMetadataSource attributeSource;
+ 
+-	private final PreInvocationAuthorizationAdvice preInvocationAdvice;
++	private PreInvocationAuthorizationAdvice preInvocationAdvice;
++
++	private PreInvocationAuthorizationReactiveAdvice preInvocationReactiveAdvice;
+ 
+ 	private final PostInvocationAuthorizationAdvice postAdvice;
+ ","Rather than have another member and and if/else statement, if the user passes in `PreInvocationAuthorizationAdvice` it could be adapted to match `PreInvocationAuthorizationReactiveAdvice`",Why do we need both?
+9794,"@@ -210,8 +210,7 @@ class Sync {
+     /**
+      * A callback passed to `Realm.App.Sync.setLogger` when instrumenting the Realm Sync client with a custom logger.
+      * @callback Realm.App.Sync~logCallback
+-     * @param {number} level The level of the log entry between 0 and 8 inclusively.
+-     * Use this as an index into `['all', 'trace', 'debug', 'detail', 'info', 'warn', 'error', 'fatal', 'off']` to get the name of the level.
++     * @param {string} level The level of the log which can be ['all', 'trace', 'debug', 'detail', 'info', 'warn', 'error', 'fatal', 'off'].
+      * @param {string} message The message of the log entry.
+      */
+ ",The callback get the log level as a number.,Shouldn't this be `strin
+9795,"@@ -71,6 +71,7 @@ setup(
+         ""hyperframe>=5.0, <6"",
+         ""jsbeautifier>=1.6.3, <1.7"",
+         ""kaitaistruct>=0.7, <0.8"",
++        ""ldap3>=2.2.0, <2.2.1"",
+         ""passlib>=1.6.5, <1.8"",
+         ""pyasn1>=0.1.9, <0.3"",
+         ""pyOpenSSL>=16.0, <17.1"",",Is there any issue with 2.2.3? If not this should be `<2.3`.  ,This should be `ldap3>=2
+9796,"@@ -1595,7 +1595,3 @@ class SeriesTest(ReusedSQLTestCase, SQLTestUtils):
+         # Only support for MultiIndex
+         kser = ks.Series([10, -2, 4, 7])
+         self.assertRaises(ValueError, lambda: kser.unstack())
+-
+-    def test_item(self):
+-        kser = ks.Series([10, 20])
+-        self.assertRaises(ValueError, lambda: kser.item())",Shall we keep this test?,Why was this test removed?
+9797,"@@ -102,12 +102,15 @@ class Tx_Solr_Backend_IndexingConfigurationSelectorField {
+ 	/**
+ 	 * Renders a field to select which indexing configurations to initialize.
+ 	 *
+-	 * Uses TCEforms.
++	 * Uses \TYPO3\CMS\Backend\Form\FormEngine.
+ 	 *
+ 	 *  @return string Markup for the select field
+ 	 */
+ 	public function render() {
+-		$tceForm = t3lib_div::makeInstance('t3lib_TCEforms');
++		$selectFieldRenderer = $formEngine = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\\Backend\\Form\\FormEngine');
++		if (class_exists('TYPO3\\CMS\Backend\\Form\\Element\\SelectElement')) {
++			$selectFieldRenderer = \TYPO3\CMS\Core\Utility\GeneralUtility::makeInstance('TYPO3\\CMS\Backend\\Form\\Element\\SelectElement', $formEngine);
++		}
+ 
+ 			// transform selected values into the format used by TCEforms
+ 		$selectedValues = array();","When would this be the case? / When would SelectElement not be available? Is this change compatible with 6.2? (I'd like to roll a release that works with 6.2+ first, before moving on to 7.x)",Why do we need to check if
+9798,"@@ -257,6 +257,10 @@ public abstract class DataType implements Serializable {
+         + ((long) (readBuffer[7] & 255) << 56));
+   }
+ 
++  public boolean isSameCatalog(DataType other) {
++    return false;
++  }
++
+   // all data should be read in little endian.
+   public TiChunkColumnVector decodeChunkColumn(CodecDataInput cdi) {
+     int numRows = readIntLittleEndian(cdi);",how about rename to shouldNarrowDataTypeTo?,why do we need this?
+9799,"@@ -33,6 +33,9 @@ from .util import bokeh_version
+ 
+ Store.renderers['bokeh'] = BokehRenderer.instance()
+ 
++if len(Store.renderers) == 1:
++    Store.current_backend = 'bokeh'
++
+ associations = {Overlay: OverlayPlot,
+                 NdOverlay: OverlayPlot,
+                 GridSpace: GridPlot,",Why not check that the one available renderer is 'bokeh'?,I don't think this is the 
+9800,"@@ -28,3 +28,6 @@ var ErrIncomplete = errors.New(""incomplete config"")
+ 
+ // ErrNotReady is the error when a broker is not ready.
+ var ErrNotReady = errors.New(""not ready"")
++
++// ErrOverflow is the error when a broker ingress is sending too many requests to PubSub.
++var ErrOverflow = errors.New(""bundler reached buffered byte limit"")",Can you import `bundler.ErrOverflow` rather than redefine it here?,nit: typo `bundler reached`
+9801,"@@ -305,7 +305,7 @@ public abstract class FlatteningConfig {
+       }
+ 
+       ResourceNameTreatment resourceNameTreatment = ResourceNameTreatment.NONE;
+-      String resourceNameType = protoParser.getResourceType(parameterField.getProtoField());
++      String resourceNameType = protoParser.getResourceReference(parameterField.getProtoField());
+       if (!Strings.isNullOrEmpty(resourceNameType)) {
+         resourceNameTreatment = ResourceNameTreatment.STATIC_TYPES;
+       }",This is just a renaming of the function getResourceType() to getResourceReference(),Shouldn't this be `getResou
+9802,"@@ -106,7 +106,7 @@ module Beaker
+       ip = ''
+       if File.file?(@vagrant_file) #we should have a vagrant file available to us for reading
+         f = File.read(@vagrant_file)
+-        m = /#{hostname}.*?ip:\s*('|"")\s*([^'""]+)('|"")/m.match(f)
++        m = /'#{hostname}'.*?ip:\s*('|"")\s*([^'""]+)('|"")/m.match(f)
+         if m
+           ip = m[2]
+           @logger.debug(""Determined existing vagrant box #{hostname} ip to be: #{ip} "")","Seems like this might need to allow for `""`s to be used here?",Why did you change this?
+9803,"@@ -295,8 +295,8 @@ CombatSpell::~CombatSpell()
+ 
+ bool CombatSpell::loadScriptCombat()
+ {
+-	combat = g_luaEnvironment.getCombatObject(g_luaEnvironment.lastCombatId);
+-	return combat != nullptr;
++	Combat_ptr combatPtr = g_luaEnvironment.getCombatObject(g_luaEnvironment.lastCombatId);
++	return combatPtr != nullptr;
+ }
+ 
+ bool CombatSpell::castSpell(Creature* creature)","here you assigning it to a local variable, in the original code it assigned to combat(CombatSpell member). Not sure if CombatSpell needs to use a shared_ptr since currently it does not and it works ""good"".",`combatPtr` -> `combat`
+9804,"@@ -1,7 +1,5 @@
+ <section id=""terms"">
+   <dl>
+-    <dt><p>How often is this video tutorial offered?</p></dt>
+-    <dd><p>This online video tutorial starts as soon as you register.</p></dd>
+     <dt><p>What if I'm not happy?</p></dt>
+     <dd><p>If you&rsquo;re not happy, just let us know within 30 days and we&rsquo;ll refund your money. It&rsquo;s as simple as that.</p></dd>
+   </dl>","Should we also remove this? This applies to subscriptions in general, but it seems sort of weird in the context of products now.",Why are you removing this?
+9805,"@@ -27,7 +27,6 @@ from dagster.core.errors import DagsterExecutionInterruptedError, DagsterInvaria
+ from dagster.seven import IS_WINDOWS, multiprocessing
+ from dagster.seven.abc import Mapping
+ 
+-from .alert import make_email_on_pipeline_failure_sensor, make_email_on_run_failure_sensor
+ from .merger import merge_dicts
+ from .yaml_utils import load_yaml_from_glob_list, load_yaml_from_globs, load_yaml_from_path
+ ","I think we should keep these, o.w. our examples will be wrong (where we're importing from `dagster.utils`). Also, we might break folks who've imported following our docs.",Why did you remove these f
+9806,"@@ -24,7 +24,7 @@ namespace OpenTelemetry.Trace
+     /// <summary>
+     /// Build TracerProvider with Resource, Sampler, Processors and Instrumentation.
+     /// </summary>
+-    internal class TracerProviderBuilderSdk : TracerProviderBuilder
++    public class TracerProviderBuilderSdk : TracerProviderBuilder
+     {
+         private readonly List<InstrumentationFactory> instrumentationFactories = new List<InstrumentationFactory>();
+         private readonly List<BaseProcessor<Activity>> processors = new List<BaseProcessor<Activity>>();",This is good and something that I think opens a lot of possibilities. I think what would be even better is to change up `TracerProviderSdk` to take factories for the processors just like it already does for the instrumentations. Should probably use use a factory for the sampler. If we made those 2 changes then we could actually split this all up into the config and the build phase and we could use the factory methods in the hosting version to call into the IServiceProvider to get those instances.,Why is this public?
+9807,"@@ -48,9 +48,14 @@ func (t *Table) Normalize() {
+ 			if len(t.Data) > 0 {
+ 				t.KeyValues[j] = t.Data[0][idx]
+ 			}
+-			v := values.New(t.KeyValues[j])
+-			if v.Type() == semantic.Invalid {
+-				panic(fmt.Errorf(""invalid value: %s"", t.KeyValues[j]))
++			var v values.Value
++			if t.KeyValues[j] == nil {
++				v = values.NewNull(flux.SemanticType(t.ColMeta[idx].Type))
++			} else {
++				v = values.New(t.KeyValues[j])
++				if v.Type() == semantic.Invalid {
++					panic(fmt.Errorf(""invalid value: %s"", t.KeyValues[j]))
++				}
+ 			}
+ 			vs[j] = v
+ 		}",Is there a way to make it so `values.New(nil)` works instead of adding a new function?,Why do we need this?
+9808,"@@ -85,7 +85,11 @@ class ApiMediaType extends AbstractType
+      */
+     public function getParent()
+     {
+-        return 'sonata_media_api_form_doctrine_media';
++        // NEXT_MAJOR: Return 'Sonata\MediaBundle\Form\Type\ApiDoctrineMediaType'
++        // (when requirement of Symfony is >= 2.8)
++        return method_exists('Symfony\Component\Form\AbstractType', 'getBlockPrefix')
++            ? 'Sonata\MediaBundle\Form\Type\ApiDoctrineMediaType'
++            : 'sonata_media_api_form_doctrine_media';
+     }
+ 
+     /**",> when requirement of Symfony **will be** >= 2.8 Same for others.,Please use `method_exists` instead.
+9809,"@@ -104,7 +104,8 @@ PROJECT_IAM_ROLES_SERVER = [
+     'roles/storage.objectViewer',
+     'roles/storage.objectCreator',
+     'roles/cloudsql.client',
+-    'roles/logging.logWriter'
++    'roles/logging.logWriter',
++    'roles/iam.serviceAccountTokenCreator'
+ ]
+ 
+ PROJECT_IAM_ROLES_CLIENT = [",I'd like to see if this can just be set on the service account instead of the project. Using the SVC_ACCT_ROLES (which should otherwise be deleted as I don't think anything else is using it.),Why do we need this?
+9810,"@@ -7,6 +7,7 @@ import android.content.Intent;
+ import android.content.SharedPreferences;
+ import android.content.res.Configuration;
+ import android.database.DataSetObserver;
++import android.graphics.Color;
+ import android.os.Build;
+ import android.os.Bundle;
+ import android.os.Handler;",Please remove the unused imports :),This import is unused.
+9811,"@@ -82,11 +82,11 @@ ActiveRecord::Schema.define(version: 20140723160957) do
+   end
+ 
+   create_table ""comments"", force: true do |t|
++    t.text     ""comment_text""
+     t.datetime ""created_at""
+     t.datetime ""updated_at""
+-    t.string   ""commentable_type""
+     t.integer  ""commentable_id""
+-    t.text     ""comment_text""
++    t.string   ""commentable_type""
+   end
+ 
+   create_table ""properties"", force: true do |t|","Were these local edits? There doesn't appear to be a change here. If so, let's remove this from the commit.",Unnecessary spacing detected.
+9812,"@@ -3,8 +3,13 @@ package server
+ import (
+ 	""crypto/ecdsa""
+ 	""crypto/x509""
++	""github.com/spiffe/spire/pkg/common/profiling""
+ 	""net""
++	""net/http""
++	_ ""net/http/pprof""
+ 	""net/url""
++	""runtime""
++	""strconv""
+ 	""sync""
+ 	""syscall""
+ ",nit: this should be further down w/ the rest of the github imports,Why is this needed?
+9813,"@@ -2,7 +2,7 @@ Hi <%= @user.first_name %>,
+ 
+ This is a reminder that your Learn <%= @subscription.plan_name %> subscription
+ will be automatically renewed on <%= l @subscription.next_payment_on %> for the
+-amount of <%= number_to_currency(@subscription.next_payment_amount) %>.
++amount of <%= number_to_currency(@subscription.next_payment_amount / 100) %>.
+ 
+ If you need to make any changes, you can do so by accessing your account page at
+ <%= my_account_url %>","I don't know if this is something we should address now, but we have a cents_to_dollars private method in both `SubscriptionCoupon` and `Invoice`.",I think this should
+9814,"@@ -1619,7 +1619,9 @@ void ihipPrintKernelLaunch(const char* kernelName, const grid_launch_parm* lp,
+ // Allows runtime to track some information about the stream.
+ hipStream_t ihipPreLaunchKernel(hipStream_t stream, dim3 grid, dim3 block, grid_launch_parm* lp,
+                                 const char* kernelNameStr, bool lockAcquired) {
+-    stream = ihipSyncAndResolveStream(stream, lockAcquired);
++    if (stream == nullptr || stream != stream->getCtx()->_defaultStream){
++        stream = ihipSyncAndResolveStream(stream, lockAcquired);
++    }
+     lp->grid_dim.x = grid.x;
+     lp->grid_dim.y = grid.y;
+     lp->grid_dim.z = grid.z;",Formatting here and all below: missing space before open bracket for the compound statement.,Why do we need this
+9815,"@@ -44,7 +44,6 @@ import org.junit.After;
+ import org.junit.Before;
+ import org.junit.BeforeClass;
+ import org.junit.Test;
+-import org.mortbay.util.ajax.JSON;
+ 
+ import static org.apache.solr.security.JWTAuthPlugin.JWTAuthenticationResponse.AuthCode.AUTZ_HEADER_PROBLEM;
+ import static org.apache.solr.security.JWTAuthPlugin.JWTAuthenticationResponse.AuthCode.NO_AUTZ_HEADER;",Avoid using old mortbay utilities for converting JSON. Uses existing Solr Utils to convert from JSON string.,Why was this remove
+9816,"@@ -0,0 +1,19 @@
++'use strict';
++
++const CommandOperationV2 = require('./command_v2');
++const defineAspects = require('./operation').defineAspects;
++const Aspect = require('./operation').Aspect;
++
++class CommandDirect extends CommandOperationV2 {
++  constructor(parent, command, options) {
++    super(parent, options);
++    this.command = command;
++  }
++  execute(server, callback) {
++    const command = this.command;
++    this.executeCommand(server, command, callback);
++  }
++}
++defineAspects(CommandDirect, [Aspect.EXECUTE_WITH_SELECTION]);
++
++module.exports = CommandDirect;","I actually think this wrapping is great, but let's call it `RunCommandOperation`?",Why do we need this?
+9817,"@@ -122,11 +122,15 @@ func errorsParse(c *caddy.Controller) (*ErrorHandler, error) {
+ 				}
+ 				f.Close()
+ 
+-				whatInt, err := strconv.Atoi(what)
+-				if err != nil {
+-					return hadBlock, c.Err(""Expecting a numeric status code, got '"" + what + ""'"")
++				if what == ""*"" {
++					handler.GenericErrorPage = where
++				} else {
++					whatInt, err := strconv.Atoi(what)
++					if err != nil {
++						return hadBlock, c.Err(""Expecting a numeric status code or '*', got '"" + what + ""'"")
++					}
++					handler.ErrorPages[whatInt] = where
+ 				}
+-				handler.ErrorPages[whatInt] = where
+ 			}
+ 		}
+ 		return hadBlock, nil",Maybe it is better to add checking for status code duplications? It can prevent some stupid copy-paste user errors.,Shouldn't this be `h
+9818,"@@ -5,14 +5,14 @@ describe Invoice do
+     invoices = Invoice.
+       find_all_by_stripe_customer_id(FakeStripe::CUSTOMER_ID)
+ 
+-    invoices.length.should eq 1
+-    invoices.first.stripe_invoice_id.should eq 'in_1s4JSgbcUaElzU'
++    expect(invoices.length).to eq 1
++    expect(invoices.first.stripe_invoice_id).to eq 'in_1s4JSgbcUaElzU'
+   end
+ 
+   it 'does not find invoices with a blank customer' do
+-    Invoice.find_all_by_stripe_customer_id(' ').length.should eq 0
+-    Invoice.find_all_by_stripe_customer_id('').length.should eq 0
+-    Invoice.find_all_by_stripe_customer_id(nil).length.should eq 0
++    expect(Invoice.find_all_by_stripe_customer_id(' ').length).to eq 0
++    expect(Invoice.find_all_by_stripe_customer_id('').length).to eq 0
++    expect(Invoice.find_all_by_stripe_customer_id(nil).length).to eq 0
+   end
+ 
+   describe 'invoice fields' do",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,Line is too long. [8
+9819,"@@ -1823,6 +1823,9 @@ mangle_return(dcontext_t *dcontext, instrlist_t *ilist, instr_t *instr,
+         IF_X64(ASSERT_TRUNCATE(val, int, opnd_get_immed_int(instr_get_src(instr, 0))));
+         /* addl sizeof_param_area, %xsp
+          * except that clobbers the flags, so we use lea */
++        /* XXX i#3307: unimplemented, we can only support simple mangling cases in
++         * mangling epilogue.
++         */
+         PRE(ilist, next_instr,
+             INSTR_CREATE_lea(dcontext, opnd_create_reg(REG_XSP),
+                              opnd_create_base_disp(REG_XSP, REG_NULL, 0, val, OPSZ_lea)));",This lea should match instr_check_xsp_mangling and be undone. I don't think i#3307 applies here.,I don't think this i
+9820,"@@ -87,6 +87,11 @@ type Store struct {
+ 	tipIndex *TipIndex
+ }
+ 
++type ipldStateThing interface {
++	Get(ctx context.Context, c cid.Cid, out interface{}) error
++	Put(ctx context.Context, v interface{}) (cid.Cid, error)
++}
++
+ // NewStore constructs a new default store.
+ func NewStore(ds repo.Datastore, cst state.IpldStore, stl state.TreeLoader, genesisCid cid.Cid) *Store {
+ 	return &Store{","I like the idea of this being an interface as it makes the test setup a bit easier, thoughts?",Why do we need this interface?
+9821,"@@ -608,7 +608,8 @@ class ColdcardPlugin(HW_PluginBase):
+             pubkey_deriv_info = wallet.get_public_keys_with_deriv_info(address)
+             pubkey_hexes = sorted([pk.hex() for pk in list(pubkey_deriv_info)])
+             xfp_paths = []
+-            for pubkey in pubkey_deriv_info:
++            for pubkey_hex in pubkey_hexes:
++                pubkey = bytes.fromhex(pubkey_hex)
+                 ks, der_suffix = pubkey_deriv_info[pubkey]
+                 fp_bytes, der_full = ks.get_fp_and_derivation_to_be_used_in_partial_tx(der_suffix, only_der_suffix=False)
+                 xfp_int = xfp_int_from_xfp_bytes(fp_bytes)",Nit: I believe the electrum convention is to use `bfh` instead of `bytes.fromhex`. Great catch on this bug!,`pubkey_hexes` -> `pubkey_hex`
+9822,"@@ -1910,7 +1910,10 @@ def _getPredictedField(options):
+       predictedFieldInfo = info
+       break
+ 
+-  assert predictedFieldInfo
++  if predictedFieldInfo is None:
++    raise Exception(
++      ""Predicted field '%s' does not exist in included fields."" % predictedField
++    )
+   predictedFieldType = predictedFieldInfo['fieldType']
+ 
+   return predictedField, predictedFieldType",Use a more granular error type. I would recommend `ValueError` in this case.,I don't think we should raise 
+9823,"@@ -2699,6 +2699,9 @@ void Game::playerRequestTrade(uint32_t playerId, const Position& pos, uint8_t st
+ 		player->sendTextMessage(MSG_INFO_DESCR, ""You can not trade more than 100 items."");
+ 		return;
+ 	}
++	if (!g_events->eventPlayerOnTradeRequest(player,tradePartner,tradeItem)) {
++		return;
++	}
+ 
+ 	internalStartTrade(player, tradePartner, tradeItem);
+ }","A space after each argument, and an empty line above this if-statement.",I don't think this is the righ
+9824,"@@ -27,8 +27,8 @@ export function memo(c, comparer) {
+ 		this.shouldComponentUpdate = shouldUpdate;
+ 		return createElement(c, props);
+ 	}
+-	Memoed.prototype.isReactComponent = true;
+ 	Memoed.displayName = 'Memo(' + (c.displayName || c.name) + ')';
++	Memoed.prototype.isReactComponent = true;
+ 	Memoed._forwarded = true;
+ 	return Memoed;
+ }","Things like this make me wonder whether we should ship a ""development"" and a ""production"" version. I remember the discussions about making things more complex bundling wise but couldn't we omit this line in a ""production"" or ""minimal"" variant of our build? That would save us some bytes here and there. Or are we somehow able to move this line to debug? I though about monkey patching the exported function but that only works in CJS and not ESM AFAIK.",Why this change?
+9825,"@@ -6,6 +6,8 @@ namespace Datadog.Trace
+ 
+         Scope Activate(Span span, bool finishOnClose);
+ 
++        void AddScopeListener(IScopeListener listener);
++
+         void Close(Scope scope);
+     }
+ }",Maybe rename to `RegisterListener` or `RegisterSubscriber`?,public interface
+9826,"@@ -34,7 +34,8 @@ export function diffChildren(
+ 	oldDom,
+ 	isHydrating
+ ) {
+-	let i, j, oldVNode, newDom, sibDom, firstChildDom, refs;
++	let i, j, oldVNode, newDom, sibDom, firstChildDom;
++	let refs = [];
+ 
+ 	// This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR
+ 	// as EMPTY_OBJ._children should be `undefined`.","My one concern here is that we are adding a new array allocation for each depth of the tree which could add some non-trivial GC churn. Perhaps this would be okay if we think that refs are used through a tree commonly enough such that they'll get allocated anyway but I'm not sure refs are *that* often used. Every app has a couple, but probably not at every level of their app :/ So maybe the extra bytes are worth it in this case? Though I have no data to back up my hypothesis so I could way off lol.",Why is this chan
+9827,"@@ -45,7 +45,7 @@ class TestDeterminism < Test::Unit::TestCase
+ 
+   def subclasses
+     Faker.constants.delete_if do |subclass|
+-      %i[Base Bank Books Cat Char Base58 ChileRut Config Creature Date Dog DragonBall Dota ElderScrolls Fallout Games GamesHalfLife HeroesOfTheStorm Internet JapaneseMedia LeagueOfLegends Movies Myst Overwatch OnePiece Pokemon SwordArtOnline TvShows Time VERSION Witcher WorldOfWarcraft Zelda].include?(subclass)
++      %i[Base Bank Books Cat Char Base58 ChileRut CLI Config Creature Date Dog DragonBall Dota ElderScrolls Fallout Games GamesHalfLife HeroesOfTheStorm Internet JapaneseMedia LeagueOfLegends Movies Myst Overwatch OnePiece Pokemon SwordArtOnline TvShows Time VERSION Witcher WorldOfWarcraft Zelda].include?(subclass)
+     end.sort
+   end
+ ",We should get rid of this big array and think about a better way to check this.,Prefer single-qu
+9828,"@@ -67,6 +67,11 @@ namespace MvvmCross.Droid.Shared.Presenter
+             var serializedRequest = Serializer.Serializer.SerializeObject(request);
+             bundle.PutString(ViewModelRequestBundleKey, serializedRequest);
+ 
++            if (request is MvxViewModelInstanceRequest)
++            {
++                Mvx.Resolve<IMvxChildViewModelCache>().Cache(((MvxViewModelInstanceRequest)request).ViewModelInstance);
++            }
++
+             if (!_fragmentHostRegistrationSettings.IsActualHostValid(request.ViewModelType))
+             {
+                 Type newFragmentHostViewModelType =",Should we cache the result of `Mvx.Resolve<IMvxChildViewModelCache>()` to avoid a lookup each time?,Why do we need to resolve the cache here?
+9829,"@@ -89,7 +89,10 @@ class RequestConsumer:
+                     self.connect_to_rabbitmq()
+                     self.init_rabbitmq_channels()
+ 
+-        avg_size_of_message //= num_of_messages
++        try:
++            avg_size_of_message //= num_of_messages
++        except ZeroDivisionError:
++            current_app.logger.warn(""No messages calculated"", exc_info=True)
+ 
+         current_app.logger.info(""Done!"")
+         current_app.logger.info(""Number of messages sent: {}"".format(num_of_messages))","If you get to this line avg_size_of_message is an undefined value, yet you use it below. You you should set this value to something in the exception block.",Why do we need this?
+9830,"@@ -0,0 +1,10 @@
++package mux
++
++import (
++	""net/http""
++	""net/http/pprof""
++)
++
++func pprofHandlers(httpMux *http.ServeMux) {
++	httpMux.HandleFunc(""/debug/pprof/"", pprof.Index)
++}","let's just fold this inline in mux.go, no need for the indirection to this new file",Why is this needed?
+9831,"@@ -31,6 +31,7 @@ import com.github.javaparser.ast.nodeTypes.NodeWithTokenRange;
+ import com.github.javaparser.ast.observer.AstObserver;
+ import com.github.javaparser.ast.observer.ObservableProperty;
+ import com.github.javaparser.ast.observer.PropagatingAstObserver;
++import com.github.javaparser.ast.stmt.BlockStmt;
+ import com.github.javaparser.ast.visitor.CloneVisitor;
+ import com.github.javaparser.ast.visitor.EqualsVisitor;
+ import com.github.javaparser.ast.visitor.HashCodeVisitor;","This bit confused me just now as I was reading through -- turns out this is due to the `{@link}` on line 316. Reading up on this, the alternative seems to be to state the fully qualified name instead. Happy to edit if requested as I don't have a strong view either way (perhaps a small leaning towards keeping the import).",Why is this import needed?
+9832,"@@ -159,6 +159,18 @@ public class CPPTokenizerTest {
+         tokenizer.tokenize(code, new Tokens());
+     }
+ 
++    @Test
++    public void testDigitSeparators() {
++        final String code = ""auto integer_literal = 1'000'000;"" + PMD.EOL
++                + ""auto floating_point_literal = 0.000'015'3;"" + PMD.EOL
++                + ""auto hex_literal = 0x0F00'abcd'6f3d;"" + PMD.EOL
++                + ""auto silly_example = 1'0'0'000'00;"";
++        Tokens tokens = parse(code);
++        System.out.println(tokens.getTokens());
++        assertTrue(TokenEntry.getEOF() != tokens.getTokens().get(0));
++        assertEquals(21, tokens.size());
++    }
++
+     private Tokens parse(String snippet) {
+         try {
+             return parse(snippet, false, new Tokens());",There's a unnecessary System.out.,Please remove this line.
+9833,"@@ -532,6 +532,15 @@ func (c *client) InstallGatewayFlows() error {
+ 	// Add flow to ensure the liveness check packet could be forwarded correctly.
+ 	flows = append(flows, c.localProbeFlow(gatewayIPs, cookie.Default)...)
+ 	flows = append(flows, c.ctRewriteDstMACFlows(gatewayConfig.MAC, cookie.Default)...)
++	if c.enableProxy {
++		flows = append(flows, c.arpNodePortVirtualResponderFlow())
++		if gatewayConfig.IPv6 != nil {
++			flows = append(flows, c.serviceGatewayFlow(true))
++		}
++		if gatewayConfig.IPv4 != nil {
++			flows = append(flows, c.serviceGatewayFlow(false))
++		}
++	}
+ 	// In NoEncap , no traffic from tunnel port
+ 	if c.encapMode.SupportsEncap() {
+ 		flows = append(flows, c.l3FwdFlowToGateway(gatewayIPs, gatewayConfig.MAC, cookie.Default)...)",Should we add the flows only when NodePort is enabled?,Why do we need this?
+9834,"@@ -2,12 +2,12 @@ AC_PREREQ([2.63])
+ dnl To do a release: follow the instructions to update libostree-released.sym from
+ dnl libostree-devel.sym, update the checksum in test-symbols.sh, set is_release_build=yes
+ dnl below. Then make another post-release commit to bump the version and set
+-dnl is_release_build=no
++dnl is_release_build=yes
+ dnl Seed the release notes with `git-shortlog-with-prs <previous-release>..`. Then use
+ dnl `git-evtag` to create the tag and push it. Finally, create a GitHub release and attach
+ dnl the tarball from `make dist`.
+ m4_define([year_version], [2020])
+-m4_define([release_version], [2])
++m4_define([release_version], [3])
+ m4_define([package_version], [year_version.release_version])
+ AC_INIT([libostree], [package_version], [walters@verbum.org])
+ is_release_build=no",ITYM to flip this one...,Why did you change this?
+9835,"@@ -7,7 +7,9 @@ module.exports = {
+   },
+   extends: [
+     'airbnb',
+-    'plugin:@typescript-eslint/recommended',
++    ""eslint:recommended"",
++    ""plugin:@typescript-eslint/eslint-recommended"",
++    ""plugin:@typescript-eslint/recommended"",
+     'prettier',
+     'prettier/@typescript-eslint',
+     'plugin:prettier/recommended',",What's the difference between typescript-eslint/eslint-recommended and typescript-eslint/recommended? I really can't get it.,Why is this needed?
+9836,"@@ -223,6 +223,14 @@ type Config struct {
+ 	// If the timeout is exceeded, the connection is closed.
+ 	// If this value is zero, the timeout is set to 30 seconds.
+ 	IdleTimeout time.Duration
++	// AttackTimeout is the maximum duration that may pass after a suspicious packet is
++	// received without any incoming network activity, used for experimental mitigation
++	// against injection attacks. If the timeout is exceeded, the connection is closed.
++	// This timeout should be longer than any reasonable round trip time, but excessively
++	// long timeouts will delay reporting of rejected connections.
++	// If this value is zero, the default mitigation behavior will be used (currently off).
++	// If this value is negative, mitigation will be disabled.
++	AttackTimeout time.Duration
+ 	// AcceptToken determines if a Token is accepted.
+ 	// It is called with token = nil if the client didn't send a token.
+ 	// If not set, a default verification function is used:","Thinking: Maybe it would be more useful to define this in terms of RTTs. That would also make it easier to switch this to a bool, since we could then pick a reasonable default value. Unless of course an attacker could influence our RTT estimate. Is that the case?",I'm not sure if this is the best way to go about this. I think it would be better to have this be a configurable parameter.
+9837,"@@ -1,4 +1,3 @@
+-//  Copyright 2019 Google Inc. All Rights Reserved.
+ //
+ //  Licensed under the Apache License, Version 2.0 (the ""License"");
+ //  you may not use this file except in compliance with the License.",Why is this line deleted?,Why is this removed?
+9838,"@@ -115,9 +115,9 @@ void nano::active_transactions::request_confirm (std::unique_lock<std::mutex> &
+ 	std::deque<std::shared_ptr<nano::block>> rebroadcast_bundle;
+ 	std::deque<std::pair<std::shared_ptr<nano::block>, std::shared_ptr<std::vector<std::shared_ptr<nano::transport::channel>>>>> confirm_req_bundle;
+ 
+-	// Confirm frontiers when there aren't many confirmations already pending
++	// Confirm frontiers when there aren't many confirmations already pending and node finished initial boostrap
+ 	lock_a.unlock ();
+-	if (node.pending_confirmation_height.size () < confirmed_frontiers_max_pending_cut_off)
++	if (node.pending_confirmation_height.size () < confirmed_frontiers_max_pending_cut_off && node.store.block_count (transaction).sum () >= node.ledger.bootstrap_weight_max_blocks)
+ 	{
+ 		confirm_frontiers (transaction);
+ 	}",minor type `boostrap`,Why do we need to check for `bootstrap_weight_max_blocks` here?
+9839,"@@ -20,9 +20,12 @@
+ package com.netflix.iceberg;
+ 
+ import com.google.common.base.Objects;
++import com.google.common.collect.Lists;
+ import com.netflix.iceberg.expressions.Expression;
+ import com.netflix.iceberg.expressions.ResidualEvaluator;
+ 
++import java.util.Iterator;
++
+ class BaseFileScanTask implements FileScanTask {
+   private final DataFile file;
+   private final String schemaString;",Nit: please don't separate imports into groups.,Why is this needed?
+9840,"@@ -31,7 +31,10 @@ public class ApplicationSidebarToggleGroupSkin extends
+         final ToggleButton allCategoryButton = createSidebarToggleButton(tr(""All""));
+ 
+         allCategoryButton.setId(""allButton"");
+-        allCategoryButton.setOnAction(event -> getControl().getOnAllCategorySelection().run());
++        allCategoryButton.setOnAction(event -> {
++            getControl().setSelectedElement(null);
++            getControl().getOnAllCategorySelection().run();
++        });
+ 
+         return Optional.of(allCategoryButton);
+     }",Thinking if it would be nice to have something like `setNothingSelected`.,Why is this needed?
+9841,"@@ -141,7 +141,7 @@ func (f *FileCertificateSource) updateCertificateFromDisk() error {
+ 		f.Log.V(logf.DebugLevel).Info(""key and certificate on disk have not changed"")
+ 		return nil
+ 	}
+-	f.Log.Info(""detected private key or certificate data on disk has changed. reloading certificate"")
++	f.Log.V(logf.DebugLevel).Info(""detected private key or certificate data on disk has changed. reloading certificate"")
+ 
+ 	cert, err := tls.X509KeyPair(certData, keyData)
+ 	if err != nil {","I think this is a useful InfoLevel message. In production, if webhook client connections suddenly start failing due to change of serving cert, you'd want to see this information in the logs.",Why is this change 
+9842,"@@ -28,7 +28,7 @@ void AddTagProcessor::process(const cpp2::AddTagReq& req) {
+     auto version = time::TimeUtils::nowInMSeconds();
+     TagID tagId = autoIncrementId();
+     data.emplace_back(MetaUtils::indexKey(EntryType::TAG, req.get_tag_name()),
+-                      std::string(reinterpret_cast<const char*>(&tagId), sizeof(tagId)));
++                      folly::to<std::string>(tagId));
+     LOG(INFO) << ""Add Tag "" << req.get_tag_name() << "", tagId "" << tagId;
+     data.emplace_back(MetaUtils::schemaTagKey(req.get_space_id(), tagId, version),
+                       MetaUtils::schemaTagVal(req.get_tag_name(), req.get_schema()));","Generally, if cast from int to char*, you could cast directly. Because no errors should happen.",Why not `const std:
+9843,"@@ -26,5 +26,12 @@ public class ServerInternals {
+   public static final String AZKABAN_EXECUTOR_PORT_FILENAME = ""executor.port"";
+ 
+   public static final String AZKABAN_SERVLET_CONTEXT_KEY = ""azkaban_app"";
+-  
++
++
++  // Memory check retry interval when OOM in ms
++  public static final long MEMORY_CHECK_INTERVAL = 1000*60*10;
++
++  // Max number of memory check retry
++  public static final int MEMORY_CHECK_RETRY_LIMIT = 100;
++
+ }","Is 10 min too long? What do you think about 1 minute? Unless there are many jobs in this state, I don't expect the CPU overhead to be too high.",Why do we need this
+9844,"@@ -28,10 +28,10 @@ type BackendServiceConfig struct {
+ 	ImageConfig      ImageWithPortAndHealthcheck `yaml:""image,flow""`
+ 	ImageOverride    `yaml:"",inline""`
+ 	TaskConfig       `yaml:"",inline""`
+-	*Logging         `yaml:""logging,flow""`
++	Logging          `yaml:""logging,flow""`
+ 	Sidecars         map[string]*SidecarConfig `yaml:""sidecars""`
+-	Network          *NetworkConfig            `yaml:""network""`
+-	Publish          *PublishConfig            `yaml:""publish""`
++	Network          NetworkConfig             `yaml:""network""`
++	Publish          PublishConfig             `yaml:""publish""`
+ 	TaskDefOverrides []OverrideRule            `yaml:""taskdef_overrides""`
+ }
+ ",can you remind me why we keep the pointer if it's a `map[string]<PStruct>`? are there other scenarios where the pointer is kept?,Why did you change this?
+9845,"@@ -61,8 +61,9 @@ public class RewriteDataFilesAction extends BaseRewriteDataFilesAction<RewriteDa
+     return this;
+   }
+ 
+-  public void maxParallelism(int parallelism) {
++  public RewriteDataFilesAction maxParallelism(int parallelism) {
+     Preconditions.checkArgument(parallelism > 0, ""Invalid max parallelism %d"", parallelism);
+     this.maxParallelism = parallelism;
++    return this;
+   }
+ }",Would it make sense to also add `setMaxParallelism` in addition to this to match the Flink API?,Why do we need this chan
+9846,"@@ -1,4 +1,13 @@
+ import ModalComponent from 'ghost-admin/components/modal-base';
++import {inject as service} from '@ember/service';
+ 
+ export default ModalComponent.extend({
++    billing: service(),
++
++    actions: {
++        closeModal() {
++            this._super(arguments);
++            this.billing.closeBillingWindow();
++        }
++    }
+ });",Not needed for actions. `_super(...arguments)` is only needed when you're extending from a base class and want to run the logic in the base class before your own logic,Why do we need this?
+9847,"@@ -104,7 +104,14 @@ Suspense.prototype._childDidSuspend = function(promise, suspendingComponent) {
+ 		}
+ 	};
+ 
+-	if (!c._pendingSuspensionCount++) {
++	/**
++	 * We do not set `suspended: true` during hydration because we want the actual markup
++	 * to remain on screen and hydrate it when the suspense actually gets resolved.
++	 * While in non-hydration cases the usual fallback -> component flow would occour.
++	 */
++	const vnode = c._vnode;
++	const wasHydrating = vnode && vnode._hydrating === true;
++	if (!wasHydrating && !c._pendingSuspensionCount++) {
+ 		c.setState({ _suspended: (c._detachOnNextRender = c._vnode._children[0]) });
+ 	}
+ 	promise.then(onResolved, onResolved);","I still need to run this code to verify my understanding, but my first reading through makes me think this may need to be `suspendingComponent._vnode` since we set `vnode._hydrating` on the vnode that threw the error (diff/index.js:275), not on `Suspense._vnode` (though we could in Suspense's `_catchError` implementation at the top of this file).",Why do we need to check 
+9848,"@@ -372,8 +372,14 @@ def get_path_if_valid(pathstr, cwd=None, relative=False, check_exists=False):
+         path = None
+ 
+     if check_exists:
+-        if path is not None and os.path.exists(path):
+-            log.url.debug(""URL is a local file"")
++        if path is not None:
++            # If the path contains characters that the locale cannot handle,
++            # then we consider it as non-existent.
++            try:
++                if os.path.exists(path):
++                    log.url.debug(""URL is a local file"")
++            except UnicodeEncodeError:
++                path = None
+         else:
+             path = None
+ ","I think it's a good idea to log this as debug, the same way the other branch gets logged.","I don't think this is the right place to do this. If the path contains characters that the locale cannot handle, then we consider it as non-existent. If the path contains characters that the locale cannot handle, then we consider it as local file."
+9849,"@@ -73,7 +73,7 @@ class TestJSONLD(AnnotationTestCase):
+                 ""comment"": 1}
+         a = API.add_annotation(model='annotation_note', **data)
+ 
+-        # JSONAlchemy issue with overwritting fields
++        # JSONAlchemy issue with overwriting fields
+         self.assert_(len(a.validate()) == 0)
+ 
+         ld = a.get_jsonld(""oaf"",",1:D100: Docstring missing 35:D101: Docstring missing 37:D102: Docstring missing 42:D101: Docstring missing 44:D102: Docstring missing 57:D102: Docstring missing 66:D101: Docstring missing 69:D102: Docstring missing,Why did you change this?
+9850,"@@ -20,6 +20,10 @@ import (
+ 	""context""
+ )
+ 
++const (
++	systemGuestRoleName = ""system.guest""
++)
++
+ var (
+ 	systemTokenInst TokenGenerator = &noauth{}
+ ","keeping this as an unexported constant, as importing the role pkg creates a cyclic dependency.",I don't think this is used anywhere.
+9851,"@@ -349,9 +349,12 @@ func (c *collection) newPut(a *driver.Action, opts *driver.RunActionsOptions) (*
+ 		// It doesn't make sense to generate a random sort key.
+ 		return nil, fmt.Errorf(""missing sort key %q"", c.sortKey)
+ 	}
+-	rev := driver.UniqueString()
+-	if av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {
+-		return nil, err
++	var rev string
++	if a.Doc.RevisionOn(c.RevisionField()) {
++		rev = driver.UniqueString()
++		if av.M[c.opts.RevisionField], err = encodeValue(rev); err != nil {
++			return nil, err
++		}
+ 	}
+ 	dput := &dyn.Put{
+ 		TableName: &c.table,",Why `c.RevisionField()` here but `c.opts.RevisionField` just below?,Why is this needed?
+9852,"@@ -139,7 +139,6 @@ type Context struct {
+ 	OriginalTargetReached bool
+ 	OvmExecutionManager   dump.OvmDumpAccount
+ 	OvmStateManager       dump.OvmDumpAccount
+-	OvmMockAccount        dump.OvmDumpAccount
+ 	OvmSafetyChecker      dump.OvmDumpAccount
+ }
+ ",nit: this file diff seems unrelated and probably should have been a separate PR,Why was this removed?
+9853,"@@ -38,7 +38,7 @@ extern ""C"" {
+   void latte(int *, int *, double *, int *, int *,
+              double *, double *, double *, double *,
+              double *, double *, double *, int*,
+-             double *, double *, double *, double * );
++             double *, double *, double *, double *, bool *);
+ }
+ 
+ #define INVOKED_PERATOM 8","@sjplimp just checked this API in the latte repository master branch (which is what Install.py downloads) and this still does not provide the 18th argument. We cannot merge this pull request until this is available. i would also suggest to implement a second binding, a function called latte_abiversion() returning an int with an ABI version number (starting with 1). This way, it can be tested, whether the ABI expected by the LAMMPS interface and provided by the library is compatible *before* calling the `latte()` function and risking a segmentation fault.",Why is this needed?
+9854,"@@ -214,7 +214,10 @@ namespace Nethermind.JsonRpc.Modules.Eth
+             }
+ 
+             Account account = _stateReader.GetAccount(header.StateRoot, address);
+-            return Task.FromResult(ResultWrapper<UInt256?>.Success(account?.Nonce ?? 0));
++            UInt256 nonce = account?.Nonce ?? 0;
++            _logger.Warn($""{address} nonce is {nonce}"");
++            
++            return Task.FromResult(ResultWrapper<UInt256?>.Success(nonce));
+         }
+ 
+         public ResultWrapper<UInt256?> eth_getBlockTransactionCountByHash(Keccak blockHash)",Is this from debugging?,Why is this a warning
+9855,"@@ -51,12 +51,17 @@ class NodeTest extends TestCase
+ 
+     /**
+      */
+-    public function testAddChildren():void
++    public function testAddChildren(): void
+     {
++        $categoryId2 = new CategoryId('cde02652-70ce-484e-bc9d-3bf61391522d');
++
+         /** @var Node|MockObject $children */
+-        $children = $this->createMock(Node::class);
++        $children = new Node($categoryId2);
+         $node = new Node($this->categoryId);
++        $this->assertFalse($node->hasChildren($categoryId2));
+         $node->addChildren($children);
+         $this->assertEquals($children, $node->getChildrens()[0]);
++        $this->assertFalse($node->hasSuccessor($this->categoryId));
++        $this->assertTrue($node->hasChildren($categoryId2));
+     }
+ }",Its betet use MockedObject,Why did you change th
+9856,"@@ -840,8 +840,12 @@ type DiskBlockCache interface {
+ 	// Put puts a block to the disk cache.
+ 	Put(ctx context.Context, tlfID tlf.ID, blockID kbfsblock.ID, buf []byte,
+ 		serverHalf kbfscrypto.BlockCryptKeyServerHalf) error
+-	// DeleteByTLF deletes some blocks from the disk cache.
+-	DeleteByTLF(ctx context.Context, tlfID tlf.ID, blockIDs []kbfsblock.ID) (numRemoved int, sizeRemoved int64, err error)
++	// Delete deletes some blocks from the disk cache.
++	Delete(ctx context.Context, blockIDs []kbfsblock.ID) (numRemoved int,
++		sizeRemoved int64, err error)
++	// UpdateMetadata updates the metadata for the given block, including
++	// setting the LRU time to now.
++	UpdateMetadata(ctx context.Context, blockID kbfsblock.ID) error
+ 	// Size returns the size in bytes of the disk cache.
+ 	Size() int64
+ 	// Shutdown cleanly shuts down the disk block cache.","""including""? Since it doesn't take any parameters, I'm not sure how it can update anything else...",I'm not sure if this is the right place to put this. I think it would be better to put this in the `kbfs` package.
+9857,"@@ -674,7 +674,7 @@ namespace AutoRest.Core.Properties {
+         }
+         
+         /// <summary>
+-        ///   Looks up a localized string similar to Non-HTTPS/HTTP schemes have limited support.
++        ///   Looks up a localized string similar to Azure Resource Management only supports HTTPS scheme..
+         /// </summary>
+         public static string SupportedSchemesWarningMessage {
+             get {",nit: I'm assuming you have verified this is what the error message should read like,"nit: ""only supports"" -> ""only supports"""
+9858,"@@ -850,4 +850,4 @@ def main(argv):
+     return glob_result
+ 
+ if __name__ == ""__main__"":
+-    exit(main(sys.argv[1:]))
++    sys.exit(main(sys.argv[1:]))",Why do you need that? (real question),Why this change?
+9859,"@@ -1788,7 +1788,7 @@ static void skipCppTemplateParameterList (void)
+ 				}
+ 			}
+ 			else if(CollectingSignature)
+-				vStringPut (Signature, x);
++				vStringPut (Signature, c);
+ 		}
+ 		else if (c == '>')
+ 		{",If I understand the patch correctly the `else` is no longer required.,Why did you change this?
+9860,"@@ -11,14 +11,14 @@ import (
+ 
+ var (
+ 	dealsSearchCount  uint64
+-	addToBlacklist    bool
++	blacklistTypeStr  string
+ 	crNewDurationFlag string
+ 	crNewPriceFlag    string
+ )
+ 
+ func init() {
+ 	dealListCmd.PersistentFlags().Uint64Var(&dealsSearchCount, ""limit"", 10, ""Deals count to show"")
+-	dealCloseCmd.PersistentFlags().BoolVar(&addToBlacklist, ""blacklist"", false, ""Add counterparty to blacklist"")
++	dealCloseCmd.PersistentFlags().StringVar(&blacklistTypeStr, ""blacklist"", ""none"", ""Whom to add to blacklist (worker, master or neither)"")
+ 	changeRequestCreateCmd.PersistentFlags().StringVar(&crNewDurationFlag, ""new-duration"", """", ""Propose new duration for a deal"")
+ 	changeRequestCreateCmd.PersistentFlags().StringVar(&crNewPriceFlag, ""new-price"", """", ""Propose new price for a deal"")
+ ",Properly describe valid flag values here: `neither` should be replaced with `none` as they parsed below.,I think this should be `--blacklist-type`
+9861,"@@ -379,7 +379,16 @@ public class AzkabanExecutorServer {
+           logger.info((""Exception when logging top memory consumers""), e);
+         }
+ 
+-        logger.info(""Shutting down..."");
++        String host = app.getHost();
++        int port = app.getPort();
++        try {
++          logger.info(String.format(""Removing executor(host: %s, port: %s) entry from database..."", host, port));
++          app.getExecutorLoader().removeExecutor(host, port);
++        } catch (ExecutorManagerException ex) {
++          logger.error(String.format(""Exception when removing executor(host: %s, port: %s)"", host, port), ex);
++        }
++
++        logger.info(""Shutting down executor..."");
+         try {
+           app.shutdownNow();
+         } catch (Exception e) {",Can we escalate this to `warn`. It is a major event.,Shouldn't this be `logger.error`?
+9862,"@@ -86,6 +86,8 @@ var (
+ 	_                            = stateOffDstPort
+ 	stateOffPostNATDstPort int16 = 24
+ 	stateOffIPProto        int16 = 26
++	stateOffICMPType       int16 = 22
++	stateOffICMPCode       int16 = 23
+ 
+ 	// Compile-time check that IPSetEntrySize hasn't changed; if it changes, the code will need to change.
+ 	_ = [1]struct{}{{}}[20-ipsets.IPSetEntrySize]",Please move these up to line 86 so the numbers are in order.,I don't think this is needed.
+9863,"@@ -0,0 +1,16 @@
++from ..builder import DETECTORS
++from .single_stage import SingleStageDetector
++
++
++@DETECTORS.register_module()
++class NASFCOS(SingleStageDetector):
++
++    def __init__(self,
++                 backbone,
++                 neck,
++                 bbox_head,
++                 train_cfg=None,
++                 test_cfg=None,
++                 pretrained=None):
++        super(NASFCOS, self).__init__(backbone, neck, bbox_head, train_cfg,
++                                      test_cfg, pretrained)",Add a docstring to contain the paper link.,Why do we need this?
+9864,"@@ -170,7 +170,11 @@ func Build(pkgName, outpath string, config *compileopts.Config, action func(stri
+ 		for i, path := range config.ExtraFiles() {
+ 			abspath := filepath.Join(root, path)
+ 			outpath := filepath.Join(dir, ""extra-""+strconv.Itoa(i)+""-""+filepath.Base(path)+"".o"")
+-			err := runCCompiler(config.Target.Compiler, append(config.CFlags(), ""-c"", ""-o"", outpath, abspath)...)
++			targ:=config.Target.Triple
++			if targ!="""" {
++				targ=""--target=""+config.Target.Triple
++			}
++			err := runCCompiler(config.Target.Compiler, append(config.CFlags(), ""-c"", targ,""-o"", outpath, abspath)...)
+ 			if err != nil {
+ 				return &commandError{""failed to build"", path, err}
+ 			}","Instead of adding the `--target` flag here, the `Target` struct should be set up correctly. Assuming this is for the Raspberry Pi 3, adding it to the `cflags` key of the JSON file should be enough (if not, you can print `config.CFlags()` here to check whether `--target` is already included).","This should be `if targ != """" {`."
+9865,"@@ -280,7 +280,9 @@ func (s *Service) BatchCreateFederatedBundle(ctx context.Context, req *bundlev1.
+ 		r := s.createFederatedBundle(ctx, b, req.OutputMask)
+ 		results = append(results, r)
+ 
+-		rpccontext.AuditRPCWithTypesStatus(ctx, r.Status, fieldsFromBundleProto(b, nil))
++		if _, ok := rpccontext.AuditLog(ctx); ok {
++			rpccontext.AuditRPCWithTypesStatus(ctx, r.Status, fieldsFromBundleProto(b, nil))
++		}
+ 	}
+ 
+ 	return &bundlev1.BatchCreateFederatedBundleResponse{",The changes in this file look unnecessary since `rpccontext.AuditRPCWithTypesStatus()` already does this check. Was there a reason you needed to add them?,Why do we need to do this?
+9866,"@@ -0,0 +1,9 @@
++// Copyright 2020 The Swarm Authors. All rights reserved.
++// Use of this source code is governed by a BSD-style
++// license that can be found in the LICENSE file.
++
++package batchstore
++
++const StateKey = stateKey
++
++var BatchKey = batchKey",you could probably use `const` for both?,Why do we need this?
+9867,"@@ -0,0 +1,9 @@
++import { isDataTable } from '../commons/table';
++import { isFocusable } from '../commons/dom';
++
++// TODO: es-modules add tests. No way to access this on the `axe` object
++function dataTableMatches(node) {
++	return !isDataTable(node) && !isFocusable(node);
++}
++
++export default dataTableMatches;","This looks like an ""ES Module"" to me. I do not understand this TODO.",Is there a reason why we can't ju
+9868,"@@ -103,8 +103,8 @@ public class RowDataRewriter implements Serializable {
+     OutputFileFactory fileFactory = new OutputFileFactory(
+         spec, format, locations, io.value(), encryptionManager.value(), partitionId, taskId);
+ 
+-    TaskWriter<InternalRow> writer;
+-    if (spec.fields().isEmpty()) {
++    final TaskWriter<InternalRow> writer;
++    if (spec.isUnpartitioned()) {
+       writer = new UnpartitionedWriter<>(spec, format, appenderFactory, fileFactory, io.value(),
+           Long.MAX_VALUE);
+     } else if (PropertyUtil.propertyAsBoolean(properties,","Iceberg doesn't use `final` because it is unlikely that this actually helps. In Java 8, final detection is quite good, which is why non-final variables can be used in closures and lambdas. And final doesn't produce different byte code so it can't do much to help at runtime.",nit: `final` is redundant
+9869,"@@ -7391,7 +7391,7 @@ int LuaScriptInterface::luaPlayerGetIp(lua_State* L)
+ 	// player:getIp()
+ 	Player* player = getUserdata<Player>(L, 1);
+ 	if (player) {
+-		lua_pushnumber(L, player->getIP());
++		lua_pushstring(L, player->getIP().to_string().c_str());
+ 	} else {
+ 		lua_pushnil(L);
+ 	}",There's `pushString` to use with C++ strings.,You can use `lua_tostring
+9870,"@@ -306,6 +306,13 @@ var _ = infrastructure.DatastoreDescribe(""service loop prevention; with 2 nodes""
+ 			cfg.Spec.ServiceLoopPrevention = ""Disabled""
+ 		})
+ 
++		// Expect to see empty cali-cidr-block chains.  (Allowing time for a Felix
++		// restart.)  This ensures that the cali-cidr-block chain has been cleared
++		// before we try a test ping.
++		for _, felix := range felixes {
++			Eventually(getCIDRBlockRules(felix, ""iptables-save""), ""8s"", ""0.5s"").Should(BeEmpty())
++		}
++
+ 		By(""test that we DO get a routing loop"")
+ 		// (In order to test that the tryRoutingLoop setup is genuine.)
+ 		tryRoutingLoop(true)",qq: Should this include the iptables6-save sim. to the inverse checks above?,I'm not sure if this is t
+9871,"@@ -622,7 +622,11 @@ bool RTPSParticipantImpl::create_writer(
+ 
+     std::lock_guard<std::recursive_mutex> guard(*mp_mutex);
+     m_allWriterList.push_back(SWriter);
+-    if (!is_builtin)
++    if (is_builtin)
++    {
++        async_thread().wake_up(SWriter);
++    }
++    else
+     {
+         m_userWriterList.push_back(SWriter);
+     }",What about async user writers? We could be checking `param.mode == ASYNCHRONOUS_WRITER`,Why is this needed?
+9872,"@@ -84,7 +84,7 @@ public class UseUtilityClassRule extends AbstractLombokAwareRule {
+     private boolean isOkUsingLombok(ASTClassOrInterfaceDeclaration parent) {
+         // check if there's a lombok no arg private constructor, if so skip the rest of the rules
+         if (hasClassLombokAnnotation()) {
+-            ASTAnnotation annotation = getLombokAnnotation(parent, ""NoArgsConstructor"");
++            ASTAnnotation annotation = parent.getAnnotation(""lombok.NoArgsConstructor"");
+ 
+             if (annotation != null) {
+ ","this double check for lombok annotation + specific lombok annotation seems pointless, just keep the second (specific) check. Moreover, since we have a property with ignored annotations... why don't we use it? a user may setup the property and it will be ignored here. Also, this class should probably not extend `AbstractLombokAwareRule` anymore. We have a configurable set of annotations that suppress the warning, defaulting to ALL lombok annotations, yet we only check for `lombok.NoArgsConstructor`... Maybe directly extending `AbstractIgnoredAnnotRule` and settig the default property to `lombok.NoArgsConstructor`? Or, to avoid a breaking API change, keep extending it, but override the default. For 7.0.0 we can change the class hierarchy.",I think this should be `lombok.NoArgsConstructor`.
+9873,"@@ -67,9 +67,11 @@ func Mux(pattern string, mux *http.ServeMux) InboundOption {
+ // route requests through YARPC. The http.Handler returned by this function
+ // may delegate requests to the provided YARPC handler to route them through
+ // YARPC.
++// If more than one Interception is provided, they will be invoked in the same
++// order as they are passed in.
+ func Interceptor(interceptor func(yarpcHandler http.Handler) http.Handler) InboundOption {
+ 	return func(i *Inbound) {
+-		i.interceptor = interceptor
++		i.interceptors = append(i.interceptors, interceptor)
+ 	}
+ }
+ ","nit: the ordering may be misunderstood, as ""invoked in the same order"" could suggest the passed-in functions are called in-order, but the actual wrapping is LIFO. Some other ways to describe it (don't think any of these are ideal, but maybe it will help you come up with something better), * the handled returned by the first interceptor is executed first * interceptors are applied outside-in (don't like the terms outside/in though) * interceptors are applied in LIFO order, leading to an earlier interceptor's handler being executed before latter interceptor handlers",I'm not sure if this is the right way to do this. 
+9874,"@@ -101,6 +101,8 @@ import org.w3c.dom.NodeList;
+ import org.xml.sax.InputSource;
+ import org.xml.sax.SAXException;
+ 
++import static org.apache.solr.common.params.QueryElevationParams.ELEVATE_DOCS_WITHOUT_MATCHING_Q;
++
+ /**
+  * A component to elevate some documents to the top of the result set.
+  *",We should not use a static import to be consistent with other existing use of the QueryElevationParams.,I don't think we need this import.
+9875,"@@ -277,7 +277,7 @@ void *ap6_thread(void *thread_context)
+ 	uint32_t num_matches = 0;
+ 
+ 	struct bitstream_info null_gbs_info ;
+-	memset(&null_gbs_info, 0, sizeof(null_gbs_info));
++	memset_s(&null_gbs_info, sizeof(null_gbs_info), 0);
+ 
+ 	ON_GOTO(c->config->num_null_gbs == 0, out_exit, ""no NULL bitstreams registered."");
+ ",No need to check return value?,`sizeof(null_gbs_info)` -> `sizeof(null_gbs_info)`
+9876,"@@ -42,6 +42,11 @@ from typing import (Any, Callable, IO, Iterator, Optional, Sequence, Tuple, Type
+ from PyQt5.QtCore import QUrl, QVersionNumber
+ from PyQt5.QtGui import QClipboard, QDesktopServices
+ from PyQt5.QtWidgets import QApplication
++# We cannot use the stdlib version on 3.7-3.8 because we need the files() API.
++if sys.version_info >= (3, 9):
++    import importlib.resources as importlib_resources
++else:
++    import importlib_resources
+ import pkg_resources
+ import yaml
+ try:","~~Feel free to ignore that one, I'll fix things up when regenerating the `requirements.txt`.~~ As for the one below, this smells like a pylint bug...",I don't think this is the right way to do it. We need to use the stdlib version on 3.8.
+9877,"@@ -279,6 +279,7 @@ func (fa *flowAggregator) InitCollectingProcess() error {
+ 			IsEncrypted:   false,
+ 		}
+ 	}
++	cpInput.NumExtraElements = len(antreaSourceStatsElementList) + len(antreaDestinationStatsElementList) + len(antreaLabelsElementList)
+ 	var err error
+ 	fa.collectingProcess, err = ipfix.NewIPFIXCollectingProcess(cpInput)
+ 	return err",it's a bit strange that this doesn't match `aggregationElements` which is what I would expect. I guess I am not familiar enough with go-ipfix.,cpInput.NumExtraElements = len(antreaSourceStatsElementList)+len(antreaDestinationStats
+9878,"@@ -35,11 +35,13 @@
+ #include ""instr.h""
+ 
+ static int num_simd_saved;
++static int num_simd_saved_abs;
+ 
+ void
+ proc_init_arch(void)
+ {
+     num_simd_saved = MCXT_NUM_SIMD_SLOTS;
++    num_simd_saved_abs = MCXT_NUM_SIMD_SLOTS;
+ 
+     /* FIXME i#1569: NYI */
+ }",Same thing: `num_simd_registers`. Ditto below.,This should be `static`.
+9879,"@@ -47,7 +47,7 @@ DEPENDENCY_LINKS = [
+ ]
+ 
+ setup(name='kinto',
+-      version='2.2.0.dev0',
++      version='2.2.1',
+       description='Kinto Web Service - Store, Sync, Share, and Self-Host.',
+       long_description=README + ""\n\n"" + CHANGELOG + ""\n\n"" + CONTRIBUTORS,
+       license='Apache License (2.0)',",Should be 2.1.1,This should be 2.2.0.dev0
+9880,"@@ -7,14 +7,16 @@ from localstack.utils.common import to_str, short_uid
+ TEST_BUCKET_NAME_WITH_NOTIFICATIONS = 'test_bucket_notif_1'
+ TEST_QUEUE_NAME_FOR_S3 = 'test_queue'
+ TEST_TOPIC_NAME = 'test_topic_name_for_sqs'
++TEST_S3_TOPIC_NAME = 'test_topic_name_for_s3_to_sns_to_sqs'
+ TEST_QUEUE_NAME_FOR_SNS = 'test_queue_for_sns'
+ 
+ 
+-def receive_assert_delete(queue_url, assertions, sqs_client=None):
++def receive_assert_delete(queue_url, assertions, sqs_client=None, required_subject=None):
+     if not sqs_client:
+         sqs_client = aws_stack.connect_to_service('sqs')
+ 
+     response = sqs_client.receive_message(QueueUrl=queue_url)
++
+     messages = [json.loads(to_str(m['Body'])) for m in response['Messages']]
+     testutil.assert_objects(assertions, messages)
+     for message in response['Messages']:",nitpick: `required_subject` doesn't seem to be used here,Why do we need the `required_subject`?
+9881,"@@ -19,6 +19,7 @@ package org.openqa.selenium.grid.graphql;
+ 
+ import graphql.schema.DataFetcher;
+ import graphql.schema.DataFetchingEnvironment;
++
+ import org.openqa.selenium.grid.distributor.Distributor;
+ import org.openqa.selenium.internal.Require;
+ ",We can revert this to reduce the diff of the PR.,import org.springframework.stereotype.
+9882,"@@ -871,6 +871,14 @@ class UIA(Window):
+ 					states.add(controlTypes.STATE_CHECKED)
+ 		return states
+ 
++	def _get_presentationType(self):
++		presentationType=super(UIA,self).presentationType
++		# UIA NVDAObjects can only be considered content if UI Automation considers them both a control and content.
++		if presentationType==self.presType_content and not (self.UIAElement.cachedIsContentElement and self.UIAElement.cachedIsControlElement):
++			presentationType=self.presType_layout
++		return presentationType 
++
++
+ 	def correctAPIForRelation(self, obj, relation=None):
+ 		if obj and self.windowHandle != obj.windowHandle and not obj.UIAElement.cachedNativeWindowHandle:
+ 			# The target element is not the root element for the window, so don't change API class; i.e. always use UIA.",Extraneous blank line.,missing whitespace around operator
+9883,"@@ -20,7 +20,8 @@ from codechecker_lib.analyzers import analyzer_clangsa
+ from codechecker_lib.analyzers import config_handler_clang_tidy
+ from codechecker_lib.analyzers import config_handler_clangsa
+ from codechecker_lib.analyzers import result_handler_clang_tidy
+-from codechecker_lib.analyzers import result_handler_clangsa
++from codechecker_lib.analyzers import result_handler_plist_to_db
++from codechecker_lib.analyzers import result_handler_plist_to_stdout
+ 
+ LOG = LoggerFactory.get_new_logger('ANALYZER TYPES')
+ ",Is this the same import as in the line 20?,I don't think we need these imports.
+9884,"@@ -5,6 +5,7 @@ class Template < ActiveRecord::Base
+   validates_with TemplateLinksValidator
+ 
+   before_validation :set_defaults 
++  after_update :reconcile_published, if: Proc.new { |template| template.published? && template.version.present? && template.version > 0 }
+ 
+   # Stores links as an JSON object: { funder: [{""link"":""www.example.com"",""text"":""foo""}, ...], sample_plan: [{""link"":""www.example.com"",""text"":""foo""}, ...]}
+   # The links is validated against custom validator allocated at validators/template_links_validator.rb",why those additional checks after published? template.version should always be present and greater than zero,Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end.
+9885,"@@ -61,6 +61,16 @@ type ExternalEntityReference struct {
+ 	Namespace string `json:""namespace,omitempty"" protobuf:""bytes,2,opt,name=namespace""`
+ }
+ 
++// EntityReference represents a reference to either a Pod or an ExternalEntity.
++// TODO: replace Pod and ExternalEntity in GroupMember to embed EntityReference
++//  when controlplane version is bumped?
++type EntityReference struct {
++	// Pod maintains the reference to the Pod.
++	Pod *PodReference `json:""pod,omitempty"" protobuf:""bytes,1,opt,name=pod""`
++	// ExternalEntity maintains the reference to the ExternalEntity.
++	ExternalEntity *ExternalEntityReference `json:""externalEntity,omitempty"" protobuf:""bytes,2,opt,name=externalEntity""`
++}
++
+ // GroupMember represents resource member to be populated in Groups.
+ // This supersedes GroupMemberPod, and will eventually replace it.
+ type GroupMember struct {",I did not see this is used in the controlplane API? Is it for internal use only? Then no need to define it here?,Why do we need this?
+9886,"@@ -138,7 +138,7 @@ void printDeviceProp(int deviceId) {
+     cout << setw(w1) << ""arch.hasSurfaceFuncs: "" << props.arch.hasSurfaceFuncs << endl;
+     cout << setw(w1) << ""arch.has3dGrid: "" << props.arch.has3dGrid << endl;
+     cout << setw(w1) << ""arch.hasDynamicParallelism: "" << props.arch.hasDynamicParallelism << endl;
+-    cout << setw(w1) << ""gcnArch: "" << props.gcnArch << endl;
++    cout << setw(w1) << ""gcnArchName: "" << props.gcnArchName << endl;
+     cout << setw(w1) << ""isIntegrated: "" << props.integrated << endl;
+     cout << setw(w1) << ""maxTexture1D: "" << props.maxTexture1D << endl;
+     cout << setw(w1) << ""maxTexture2D.width: "" << props.maxTexture2D[0] << endl;",Should we also add a line to print gcnArch?,This should be `gcnArch.name`
+9887,"@@ -87,6 +87,7 @@ module.exports.rebaseBraveStringFilesOnChromiumL10nFiles = (path) =>
+         .replace('<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML""', '<include name=""IDR_MD_HISTORY_SIDE_BAR_HTML"" flattenhtml=""true""')
+         .replace(pageVisibility, bravePageVisibility + pageVisibility)
+         .replace(/settings_chromium_strings.grdp/g, 'settings_brave_strings.grdp')
++        .replace(/Automatically sends usage statistics and crash reports to Brave/g, 'Automatically sends crash reports to Brave')
+         .replace(/The Chromium Authors/g, 'Brave Software Inc')
+         .replace(/Google Chrome/g, 'Brave')
+         .replace(/Chromium/g, 'Brave')","I merged already so need another PR, but I think this needs to be at the bottom.",I think this should be `Automatically sends usage statistics and crash reports
+9888,"@@ -150,6 +150,7 @@ bool ConfigManager::load()
+ 	boolean[ONLINE_OFFLINE_CHARLIST] = getGlobalBoolean(L, ""showOnlineStatusInCharlist"", false);
+ 	boolean[YELL_ALLOW_PREMIUM] = getGlobalBoolean(L, ""yellAlwaysAllowPremium"", false);
+ 	boolean[FORCE_MONSTERTYPE_LOAD] = getGlobalBoolean(L, ""forceMonsterTypesOnLoad"", true);
++	boolean[HOUSE_OWNED_BY_ACCOUNT] = getGlobalBoolean(L, ""houseOwnedByAccount "", false);
+ 
+ 	string[DEFAULT_PRIORITY] = getGlobalString(L, ""defaultPriority"", ""high"");
+ 	string[SERVER_NAME] = getGlobalString(L, ""serverName"", """");",space in key string?,I think this should be false by default.
+9889,"@@ -48,9 +48,13 @@ func (b *ProcessBuilder) Build() *ManagedProcess {
+ 	if len(b.nsOptions) > 0 {
+ 		args = append([]string{""--"", cmd}, args...)
+ 		for _, option := range b.nsOptions {
+-			args = append([]string{""-"" + nsArgMap[option.Typ] + option.Path}, args...)
++			args = append([]string{""-"" + nsArgMap[option.Typ], option.Path}, args...)
+ 		}
+-		cmd = ""nsenter""
++
++		if b.localMnt {
++			args = append([]string{""-l""}, args...)
++		}
++		cmd = nsexecPath
+ 	}
+ 
+ 	if b.pause {",The commends of this function should be updated,Why is this needed?
+9890,"@@ -48,6 +48,7 @@ class AnchorHead(nn.Module):
+                      type='DeltaXYWHBBoxCoder',
+                      target_means=(.0, .0, .0, .0),
+                      target_stds=(1.0, 1.0, 1.0, 1.0)),
++                 reg_decoded_bbox=False,
+                  background_label=None,
+                  loss_cls=dict(
+                      type='CrossEntropyLoss',",The docstring is outdated.,I don't think this is needed.
+9891,"@@ -7,6 +7,9 @@ namespace Datadog.Trace
+     /// </summary>
+     public static class CorrelationIdentifier
+     {
++        internal static readonly string ServiceKey = ""dd.service"";
++        internal static readonly string VersionKey = ""dd.version"";
++        internal static readonly string EnvKey = ""dd.env"";
+         internal static readonly string TraceIdKey = ""dd.trace_id"";
+         internal static readonly string SpanIdKey = ""dd.span_id"";
+ ",Could rename to `ServiceVersionKey` for consistency with the suggestion to rename the TracerSetting.,Why are these public?
+9892,"@@ -826,6 +826,12 @@ def install(package, hash=None, version=None, tag=None, force=False):
+     store = PackageStore()
+     existing_pkg = store.get_package(owner, pkg)
+ 
++    if existing_pkg is not None and not force:
++        print(""{owner}/{pkg} already installed."".format(owner=owner, pkg=pkg))
++        overwrite = input(""Overwrite? (y/n) "")
++        if overwrite.lower() != 'y':
++            return
++
+     if version is not None:
+         response = session.get(
+             ""{url}/api/version/{owner}/{pkg}/{version}"".format(",I seem to recall a UI issue with this... @akarve I think you didn't like this for some reason...,This should be `if overwrite.lower() != 'y':`
+9893,"@@ -84,7 +84,7 @@ class MediaBlockService extends BaseBlockService
+     /**
+      * {@inheritdoc}
+      */
+-    public function getDefaultSettings(OptionsResolverInterface $resolver)
++    public function setDefaultSettings(OptionsResolverInterface $resolver)
+     {
+         $resolver->setDefaults(array(
+             'media'    => false,",The `MediaBlockService` commit must be remove,This should be reverted.
+9894,"@@ -239,11 +239,17 @@ rules:
+     maximum_retention: 365
+ 
+ """"""
++
++    def test_number_of_rules(self):
++        """"""The number of rules should be exactly the same as the length of SUPPORTED_RETENTION_RES_TYPES.""""""
++        rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
++        self.assertTrue(len(rre.SUPPORTED_RETENTION_RES_TYPES) == len(rules_engine.rule_book.resource_rules_map))
++
++
+     def test_only_max_normal_delete(self):
+         """"""Test that a bucket's rule can guarantee the maximum_retention if its
+         action is 'Delete' and the only condition is an age(<= maximum_retention)""""""
+         rules_engine = get_rules_engine_with_rule(RetentionRulesEngineTest.yaml_str_only_max_retention)
+-        self.assertEqual(1, len(rules_engine.rule_book.resource_rules_map))
+ 
+         data_creater = frsd.FakeBucketDataCreater('fake_bucket', frsd.PROJECT1)
+         data_creater.AddLifecycleDict(action=""Delete"", age=365)","Use a literal constant here, and use `assertEqual`, e.g. `self.assertEqual(2, len(...))` You should also check that the number of rules is correct, i.e. 1 rule for buckets, 0 rules for tables.",Why did you remove this test?
+9895,"@@ -15,8 +15,8 @@
+  * will expire before some files can be uploaded.
+  *
+  * The long-term solution to this problem is to change the upload pipeline so that files
+- * can be sent to the next step individually. That requires a breakig change, so it is
+- * planned for Uppy v2.
++ * can be sent to the next step individually. That requires a breaking change, so it is
++ * planned for Uppy v4.
+  *
+  * In the mean time, this plugin is stuck with a hackier approach: the necessary parts
+  * of the XHRUpload implementation were copied into this plugin, as the MiniXHRUpload",@Murderlon Should it just say `some future version`?,I don't think we need to change this.
+9896,"@@ -122,12 +122,14 @@ func (c *Controller) syncCSPC(cspcGot *apis.CStorPoolCluster) error {
+ 		return nil
+ 	}
+ 
+-	cspcGot, err := c.populateVersion(cspcGot)
++	cspcObj := cspcGot
++	cspcObj, err := c.populateVersion(cspcObj)
+ 	if err != nil {
+ 		klog.Errorf(""failed to add versionDetails to CSPC %s:%s"", cspcGot.Name, err.Error())
+ 		return nil
+ 	}
+ 
++	cspcGot = cspcObj
+ 	pc, err := c.NewPoolConfig(cspcGot, openebsNameSpace)
+ 	if err != nil {
+ 		message := fmt.Sprintf(""Could not sync CSPC : failed to get pool config: {%s}"", err.Error())","change looks good.. but, better to make populateVersion to return same object in the case of error.. that avoids lot of complex logic and probable issues",Why do we need this change?
+9897,"@@ -1358,6 +1358,10 @@ func (exp *Service) GetBlockOrActionByHash(hashStr string) (explorer.GetBlkOrAct
+ 		return explorer.GetBlkOrActResponse{Execution: &exe}, nil
+ 	}
+ 
++	if exe, err := exp.getAddressDetails(hashStr); err == nil {
++		return explorer.GetBlkOrActResponse{Address: &exe}, nil
++	}
++
+ 	return explorer.GetBlkOrActResponse{}, nil
+ }
+ ",invalid operation: exp (variable of type *Service) has no field or method getAddressDetails (from `typecheck`),I don't think this is corre
+9898,"@@ -4479,7 +4479,8 @@ func TestKBFSOpsBackgroundFlush(t *testing.T) {
+ 
+ 	// start the background flusher
+ 	ops := getOps(config, rootNode.GetFolderBranch().Tlf)
+-	go ops.backgroundFlusher(1 * time.Millisecond)
++	config.SetBGFlushPeriod(1 * time.Millisecond)
++	go ops.backgroundFlusher()
+ 
+ 	// Make sure we get the notification
+ 	select {","Probably overkill, but maybe we should be using a fake clock here. I won't push on whatever you decide though.",Why is this needed?
+9899,"@@ -690,7 +690,7 @@ func TestKBFSOpsConcurBlockSyncTruncate(t *testing.T) {
+ 
+ 	wg.Wait()
+ 
+-	// Do this in the main goroutine since t isn't goroutine safe,
++	// Do this in the main goroutine since it isn't goroutine safe,
+ 	// and do this after wg.Wait() since we only know it's set
+ 	// after the goroutine exits.
+ 	if syncErr != nil {","If you feel like it, may as well apply all the suggestions below to this test too.",Why is this change needed?
+9900,"@@ -94,9 +94,18 @@ public class LatLonShape {
+     return new Field[] {new LatLonTriangle(fieldName, lat, lon, lat, lon, lat, lon)};
+   }
+ 
++  /** create a query to find all indexed shapes that comply the {@link QueryRelation} with the provided point
++   **/
++  public static Query newPointQuery(String field, QueryRelation queryRelation, double lat, double lon) {
++    return new LatLonShapePointQuery(field, queryRelation, lat, lon);
++  }
++
+   /** create a query to find all polygons that intersect a defined bounding box
+    **/
+   public static Query newBoxQuery(String field, QueryRelation queryRelation, double minLatitude, double maxLatitude, double minLongitude, double maxLongitude) {
++    if (minLatitude == maxLatitude && minLongitude == maxLongitude) {
++      return newPointQuery(field, queryRelation, minLatitude, minLongitude);
++    }
+     return new LatLonShapeBoundingBoxQuery(field, queryRelation, minLatitude, maxLatitude, minLongitude, maxLongitude);
+   }
+ ",do we really need a relation or can we just assume INTERSECTS?,I don't think we need this method. We can just call `newPointQuery` directly.
+9901,"@@ -16,7 +16,7 @@ import net.sourceforge.pmd.lang.java.oom.api.MetricVersion;
+  *
+  * @author Clément Fournier
+  */
+-public final class ParameterizedMetricKey {
++/* default */ final class ParameterizedMetricKey {
+ 
+     private static final Map<Integer, ParameterizedMetricKey> POOL = new HashMap<>();
+ ",Is this a `MetricKey` ?,Why did you change the visibility?
+9902,"@@ -49,6 +49,9 @@ public class Constants {
+   public static final int DEFAULT_SSL_PORT_NUMBER = 8443;
+   public static final int DEFAULT_JETTY_MAX_THREAD_COUNT = 20;
+ 
++  // One Schedule's default End Time: 01/01/2050, 00:00:00, UTC
++  public static final long DEFAULT_SCHEDULE_END_EPOCH_TIME = 2524608000000L;
++
+   public static class ConfigurationKeys {
+     // These properties are configurable through azkaban.properties
+ ",what's your rationale to pick up this date?,I think this should be called `DEFAULT_SCHEDULE_START_EPOCH_TIME`
+9903,"@@ -11,6 +11,7 @@ import (
+ 	""strings""
+ 
+ 	""github.com/opencontainers/runc/libcontainer/cgroups""
++	""github.com/opencontainers/runc/libcontainer/cgroups/fscommon""
+ 	""github.com/opencontainers/runc/libcontainer/configs""
+ )
+ ","NIT: I'd have preferred that the new package be called ""utils"", but that's not a big deal.","""github.com/pkg/errors"""
+9904,"@@ -1,6 +1,13 @@
+ # Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
+ # SPDX - License - Identifier: Apache - 2.0
+ 
++# Purpose
++# This code example demonstrates how to set the default encryption state for an
++# Amazon Simple Storage Solution (Amazon S3) bucket using server-side encryption (SSE)
++# with an AWS KMS customer master key (CMK).
++
++# snippet-start:[s3.ruby.s3_add_default_sse_encryption]
++
+ require 'aws-sdk-s3'
+ 
+ # Sets the default encryption state for an Amazon S3 bucket using",Simple Storage **Service**,I think this should be `snippet-end`
+9905,"@@ -201,12 +201,15 @@ class GarbageCollector extends AbstractDataHandlerListener implements SingletonI
+         $indexQueueItems = $this->getIndexQueue()->getItems($table, $uid);
+         foreach ($indexQueueItems as $indexQueueItem) {
+             $site = $indexQueueItem->getSite();
++            $solrConfiguration = $site->getSolrConfiguration();
+ 
+             // a site can have multiple connections (cores / languages)
+             $solrConnections = $connectionManager->getConnectionsBySite($site);
+             foreach ($solrConnections as $solr) {
+                 $solr->deleteByQuery('type:' . $table . ' AND uid:' . intval($uid));
+-                $solr->commit(false, false, false);
++                if ($solrConfiguration->getEnableCommits()) {
++                    $solr->commit(false, false, false);
++                }
+             }
+         }
+     }","I think, retrieving the setting could also be done outside the loop. What do you think?",Shouldn't this be `$solrConfiguratio
+9906,"@@ -257,6 +257,7 @@ public class TransactionPool implements BlockAddedObserver {
+               transaction.getGasLimit(), chainHeadBlockHeader.getGasLimit()));
+     }
+ 
++    // TODO: this is where we would use the private state to do the validation against
+     return protocolContext
+         .getWorldStateArchive()
+         .get(chainHeadBlockHeader.getStateRoot())",This TODO isn't related to this change. We should remove it.,// TODO: this is where we would use 
+9907,"@@ -102,7 +102,7 @@ class ExternalDriverSupplier implements Supplier<WebDriver> {
+     Optional<Class<? extends Supplier<WebDriver>>> supplierClass = getDelegateClass();
+     if (supplierClass.isPresent()) {
+       Class<? extends Supplier<WebDriver>> clazz = supplierClass.get();
+-      logger.info(""Using delegate supplier: "" + clazz.getName());
++      logger.finest(""Using delegate supplier: "" + clazz.getName());
+       try {
+         @SuppressWarnings(""unchecked"")
+         Constructor<Supplier<WebDriver>> ctor =",We chose `info` in the test code for obvious reasons. Changing to `finest` makes debugging harder and noisier.,Why is this changed to `finest`?
+9908,"@@ -1689,7 +1689,14 @@ class RefactoringChecker(checkers.BaseTokenChecker):
+                         and subscript == subscript.parent.target
+                     ):
+                         # Ignore this subscript if it is the target of an assignment
+-                        continue
++                        if subscript.as_string() == subscript.parent.value.as_string():
++                            # Fire error as d[k] += d[k] has an unnecessary index lookup
++                            self.add_message(
++                                ""unnecessary-dict-index-lookup"",
++                                node=subscript,
++                                args=(node.target.elts[1].as_string()),
++                            )
++                        return  # Early termination; after reassignment dict index lookup will be necessary
+ 
+                     # Case where .items is assigned to k,v (i.e., for k, v in d.items())
+                     if isinstance(value, astroid.Name):","I'm not really sure this is worth it. Keep in mind that every special case we add has the potential to introduce new errors and complicates the code further. For common cases that is acceptable, but in this instance I don't think it's beneficial.",I don't think this is the right place to fire this error. It should be at the top of the function.
+9909,"@@ -62,6 +62,11 @@ func (c *showCommand) Run(ctx context.Context, env *common_cli.Env, serverClient
+ 		return err
+ 	}
+ 
++	if agent.Selectors != nil {
++		for _, s := range agent.Selectors {
++			env.Printf(""Selectors     : %s:%s\n"", s.Type, s.Value)
++		}
++	}
+ 	return nil
+ }
+ ","nit: this `if` isn't necessary since we immediately follow it up with a range over the slice, which works fine with a `nil` slice.",I think this should be `if agent.Selectors != nil && len(agent.Selectors) > 0`
+9910,"@@ -3160,9 +3160,15 @@ void Game::playerChangeOutfit(uint32_t playerId, Outfit_t outfit)
+ 	}
+ 
+ 	Player* player = getPlayerByID(playerId);
++	
+ 	if (!player) {
+ 		return;
+ 	}
++	
++	const Outfit* playerOutfit = Outfits::getInstance()->getOutfitByLookType(player->getSex(), outfit.lookType);
++	if (!playerOutfit) {
++		outfit.lookMount = 0;
++	}
+ 
+ 	if (outfit.lookMount != 0) {
+ 		Mount* mount = mounts.getMountByClientID(outfit.lookMount);",Remove this line please.,Shouldn't this be `playerOutfit`?
+9911,"@@ -144,6 +144,7 @@ public class ZMSImpl implements Authorizer, KeyStore, ZMSHandler {
+     protected int domainNameMaxLen;
+     protected AuthorizedServices serverAuthorizedServices = null;
+     protected SolutionTemplates serverSolutionTemplates = null;
++    protected Map<String, Integer> eligibleTemplatesForAutoUpdate = null;
+     protected Map<String, String> serverPublicKeyMap = null;
+     protected boolean readOnlyMode = false;
+     protected boolean validateUserRoleMembers = false;",why is this is class field? it should be something local within the auto apply template method since we only need this once to process templates and never use again.,"I think this should be a `Map<String, String>`"
+9912,"@@ -39,14 +39,14 @@ module.exports = function(grunt) {
+ 
+       const { diff: rolesTable, notes: rolesFootnotes } = getDiff(
+         roles,
+-        axe.commons.aria.lookupTable.role,
++        axe.utils.getStandards().ariaRoles,
+         listType
+       );
+ 
+       const ariaQueryAriaAttributes = getAriaQueryAttributes();
+       const { diff: attributesTable, notes: attributesFootnotes } = getDiff(
+         ariaQueryAriaAttributes,
+-        axe.commons.aria.lookupTable.attributes,
++        axe.utils.getStandards().ariaAttrs,
+         listType
+       );
+       const attributesTableMarkdown = mdTable([",I agree with Stephen it's better to invoke getStandards() only once.,I think this should be `axe.utils.getAriaAttributes()`
+9913,"@@ -198,7 +198,7 @@ class GridInterface(DictInterface):
+ 
+ 
+     @classmethod
+-    def canonicalize(cls, dataset, data, coord_dims=None):
++    def canonicalize(cls, dataset, data, coord_dims=None, irregular_dims=[]):
+         """"""
+         Canonicalize takes an array of values as input and
+         reorients and transposes it to match the canonical","After discussing what ``irregular_dims`` really is, we agreed that we need a better name that makes it clearer that this is more of an xarray concept of irregular dimensions than a holoviews one.","I think this should be `None`, not `[]`."
+9914,"@@ -35,7 +35,7 @@ public class Container {
+   private final ContainerId id;
+ 
+   public Container(Function<HttpRequest, HttpResponse> client, ContainerId id) {
+-    LOG.info(""Created container "" + id);
++    LOG.finest(""Created container "" + id);
+     this.client = Objects.requireNonNull(client);
+     this.id = Objects.requireNonNull(id);
+   }","This code is new and not tested well. While we may drop the log level before we ship 4.0, right now this is extremely helpful to users.",Why is this change needed?
+9915,"@@ -222,11 +222,16 @@ th svg {
+ }
+ 
+ td {
++	white-space: nowrap;
+ 	font-size: 14px;
+ }
+ 
+ td:first-child {
+-	width: 50%;
++	width: 100%;
++}
++
++td:nth-child(2) {
++	padding: 0 20px 0 20px;
+ }
+ 
+ th:last-child,",this makes sure there is some padding space around the size column,I think this should be `nth-child(2)`
+9916,"@@ -47,6 +47,7 @@ extern ""C"" {
+ #include ""Util/InputFileUtil.h""
+ #include ""Util/GraphLoader.h""
+ #include ""Util/StringUtil.h""
++#include ""Util/LuaUtil.h""
+ 
+ using namespace std;
+ ",Put these includes in alphabetical order,"#include ""LuaUtil.h"""
+9917,"@@ -246,7 +246,12 @@ class JAB(Window):
+ 				continue
+ 			keyList=[]
+ 			# We assume alt  if there are no modifiers at all and its not a menu item as this is clearly a nmonic
+-			if (binding.modifiers&JABHandler.ACCESSIBLE_ALT_KEYSTROKE) or (not binding.modifiers and self.role!=controlTypes.ROLE_MENUITEM):
++			altModifier = binding.modifiers&JABHandler.ACCESSIBLE_ALT_KEYSTROKE
++			if not altModifier:
++				if not binding.modifiers and self.role!=controlTypes.ROLE_MENUITEM:
++					parent=self.parent
++					altModifier=isinstance(parent,JAB) and parent.role==controlTypes.ROLE_MENUBAR
++			if altModifier:
+ 				keyList.append(keyLabels.localizedKeyLabels['alt'])
+ 			if binding.modifiers&JABHandler.ACCESSIBLE_CONTROL_KEYSTROKE:
+ 				keyList.append(keyLabels.localizedKeyLabels['control'])",Can this just be an else?,missing whitespace a
+9918,"@@ -7,6 +7,7 @@ import torch.nn as nn
+ from mmcv.utils import print_log
+ 
+ from mmdet.core import auto_fp16
++from mmdet.utils import get_root_logger
+ 
+ 
+ class BaseDetector(nn.Module, metaclass=ABCMeta):",Merge this line with Line7,from mmdet.utils imp
+9919,"@@ -19,7 +19,7 @@ module GeocoderHelper
+     html << result[:suffix] if result[:suffix]
+ 
+     if result[:type] and result[:id]
+-      html << content_tag(:small, :class => [""deemphasize"", ""search_details""]) do
++      html << content_tag(:small, :class => [""deemphasize"", ""search_details"", ""clearfix""]) do
+         link_to(t(""browse.#{result[:type]}_history.view_details""), :controller => :browse, :action => result[:type], :id => result[:id])
+       end
+     end",`clearfix` is needed to stop the `float:right` content overflowing the list item container.,Use the new Ruby 1.9
+9920,"@@ -6,7 +6,7 @@ using Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Infrastructure;
+ 
+ namespace Microsoft.AspNetCore.Server.Kestrel.Performance
+ {
+-    [ParameterizedJobConfig(typeof(CoreConfig))]
++    [AspNetCoreBenchmark]
+     public class StringUtilitiesBenchmark
+     {
+         private const int Iterations = 500_000;",Can this be put on the assembly?,Why was this removed?
+9921,"@@ -124,7 +124,8 @@ public class HealthCheckServlet extends HttpServlet {
+         if (results.isEmpty()) {
+             resp.setStatus(HttpServletResponse.SC_NOT_IMPLEMENTED);
+         } else {
+-            if (isAllHealthy(results)) {
++            final boolean alwaysOk = Boolean.parseBoolean(req.getParameter(""alwaysOk""));
++            if (alwaysOk || isAllHealthy(results)) {
+                 resp.setStatus(HttpServletResponse.SC_OK);
+             } else {
+                 resp.setStatus(HttpServletResponse.SC_INTERNAL_SERVER_ERROR);",Could we rename the parameter to `overrideStatusCode`? The name `alwaysOk` implies that the health check result would be always healthy.  ,I don't think this is
+9922,"@@ -37,5 +37,9 @@ func (c *clusterApi) Routes() []*Route {
+ 		{verb: ""GET"", path: clusterSecretPath(""/defaultsecretkey"", cluster.APIVersion), fn: c.getDefaultSecretKey},
+ 		{verb: ""PUT"", path: clusterSecretPath(""/defaultsecretkey"", cluster.APIVersion), fn: c.setDefaultSecretKey},
+ 		{verb: ""POST"", path: clusterSecretPath(""/login"", cluster.APIVersion), fn: c.secretsLogin},
++		{verb: ""GET"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.listSchedPolicy},
++		{verb: ""POST"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.createSchedPolicy},
++		{verb: ""PUT"", path: clusterPath(""/schedpolicy"", cluster.APIVersion), fn: c.updateSchedPolicy},
++		{verb: ""DELETE"", path: clusterPath(""/schedpolicy/{name}"", cluster.APIVersion), fn: c.deleteSchedPolicy},
+ 	}
+ }","""/schedpolicy"" is repeated, i would make it a constant and use it here and cluster client.go",I think this should b
+9923,"@@ -0,0 +1,14 @@
++module RSpec::Core::Ordering
++  class RandomOrdering
++    def order(items, configuration = RSpec.configuration)
++      Kernel.srand configuration.seed
++      ordering = items.shuffle
++      Kernel.srand # reset random generation
++      ordering
++    end
++
++    def built_in?
++      true
++    end
++  end
++end","Having a second `configuration` arg seems kinda odd to me as an interface. It looks like you're just using it as a form of dependency injection for the tests, right? Part of what makes it seem weird is that it's leaked into all the other orderers where they don't use `configuration` at all. Instead, what do you think about accepting the configuration in `initialize` (and having it default to `RSpec.configuration` in the same way)? To me, the config feels like a bit of state the instance should hold onto rather than being given each time `order` is called. It also means the other orderers wouldn't need to take the odd second argument. Thoughts?",Why do we need this?
+9924,"@@ -248,8 +248,9 @@ class AddonsDialog(
+ 		self.getAddonsButton = generalActions.addButton(self, label=_(""&Get add-ons...""))
+ 		self.getAddonsButton.Bind(wx.EVT_BUTTON, self.onGetAddonsClick)
+ 		# Translators: The label for a button in Add-ons Manager dialog to install an add-on.
+-		self.addButton = generalActions.addButton(self, label=_(""&Install...""))
+-		self.addButton.Bind(wx.EVT_BUTTON, self.onAddClick)
++		if not globalVars.appArgs.secure:
++			self.addButton = generalActions.addButton(self, label=_(""&Install...""))
++			self.addButton.Bind(wx.EVT_BUTTON, self.onAddClick)
+ 		# Translators: The label of a button in the Add-ons Manager to open the list of incompatible add-ons.
+ 		self.incompatAddonsButton = generalActions.addButton(self, label=_(""&View incompatible add-ons...""))
+ 		self.incompatAddonsButton.Bind(wx.EVT_BUTTON, self.onIncompatAddonsShowClick)",This button should also be disabled when in secure mode since it opens a web browser from which you can easily do a lot of insecure stuff.,I think this should be `if not globalVars.appArgs.secure and not self.incompatAddonsButton:`
+9925,"@@ -221,4 +221,11 @@ public interface Table {
+    * @return a {@link LocationProvider} to provide locations for new data files
+    */
+   LocationProvider locationProvider();
++
++  /**
++   * Create a new {@link ExpireTableMetadata expire API} to manage table metadata files in this table and commit.
++   *
++   * @return a new {@link ExpireTableMetadata}
++   */
++  ExpireTableMetadata expireTableMetadata();
+ }",Should this be done as part of `expireSnapshots`? I'd like to avoid adding a lot of operations to `Table` because it is already a large API.,Add `@since 2.0.0`
+9926,"@@ -0,0 +1,18 @@
++package libp2p
++
++import (
++	""github.com/libp2p/go-libp2p-core/helpers""
++	""github.com/libp2p/go-libp2p-core/network""
++)
++
++type Stream struct {
++	network.Stream
++}
++
++func (s *Stream) FullClose() error {
++	return helpers.FullClose(s)
++}
++
++func NewStream(stream network.Stream) *Stream {
++	return &Stream{Stream: stream}
++}",I do not think that this type (and its constructor) have to be exported.,Why do we need this?
+9927,"@@ -55,7 +55,10 @@ func (r *receiptLog) SetData(data []byte) {
+ 	r.data = data
+ }
+ 
+-func (r *receiptLog) Build(ctx context.Context, err error) *action.Log {
++func (r *receiptLog) Build(ctx context.Context, err error, skipLogOnErr bool) *action.Log {
++	if err != nil && skipLogOnErr {
++		return nil
++	}
+ 	blkCtx := protocol.MustGetBlockCtx(ctx)
+ 	actionCtx := protocol.MustGetActionCtx(ctx)
+ ","why add this? don't think it's correct? for instance, it returns ErrCandidateNotExist (not critical), in this case we should return a receipt with corresponding status",Why do we need this?
+9928,"@@ -0,0 +1,6 @@
++package caddytls
++
++import ""github.com/xenolf/lego/acme""
++
++// ChallengeProvider type to be used in Caddy plugins over acme.ChallengeProvider directly, to avoid https://github.com/mattfarina/golang-broken-vendor
++type ChallengeProvider acme.ChallengeProvider","Instead of creating a new file, put this in tls.go, like right after or before DNSProviderConstructor is defined.",I'm not sure if this is the best place to put this. I think it should be in `pkg/xenolf/lego`
+9929,"@@ -62,7 +62,8 @@ app.controller('AttendeeController', function($scope, AutoCompletionService) {
+ 					'role': 'REQ-PARTICIPANT',
+ 					'rsvp': 'TRUE',
+ 					'partstat': 'NEEDS-ACTION',
+-					'cutype': 'INDIVIDUAL'
++					'cutype': 'INDIVIDUAL',
++					'language': OC.getLocale() // Use current user's timezone as a default value
+ 				}
+ 			});
+ 		}","Instead of OC.getLocale() for the default value the default should be the value of the user value 'core' 'lang'. When loading the page this can be added to the parameters by retrieving $this->config->getUserValue($user->getUID(), 'core', 'lang'); in viewcontroller.php.",Shouldn't this be `OC.getUserLanguage()`?
+9930,"@@ -42,7 +42,7 @@ namespace interface1
+  * \param[in] id   Identifier of the result
+  * \return         Result that corresponds to the given identifier
+  */
+-classifier::quality_metric::binary_confusion_matrix::ResultPtr ResultCollection::getResult(QualityMetricId id) const
++classifier::quality_metric::binary_confusion_matrix::ResultPtr daal::algorithms::adaboost::quality_metric_set::interface1::ResultCollection::getResult(daal::algorithms::adaboost::quality_metric_set::QualityMetricId id) const
+ {
+     return staticPointerCast<classifier::quality_metric::binary_confusion_matrix::Result, SerializationIface>((*this)[(size_t)id]);
+ }",Why interface1 ? It should be in inner so.,I don't think you need the namespace here.
+9931,"@@ -32,6 +32,16 @@ class User(UserMixin):
+             login_id=user['login_id'],
+         )
+ 
++    def to_dict(self):
++        return {
++            ""id"": self.id,
++            ""created"": self.created,
++            ""musicbrainz_id"": self.musicbrainz_id,
++            ""auth_token"": self.auth_token,
++            ""gdpr_agreed"": self.gdpr_agreed,
++            ""login_id"": self.login_id
++        }
++
+ @login_manager.user_loader
+ def load_user(user_login_id):
+     try:","Ideally, I'd have converted dicts to object but this way was less changes so this way for now.",Why do we need this?
+9932,"@@ -4061,8 +4061,17 @@ void t_c_glib_generator::generate_deserialize_field(ostream& out,
+       throw ""compiler error: no C reader for base type "" + t_base_type::t_base_name(tbase) + name;
+     }
+     out << "", error)) < 0)"" << endl;
+-    out << indent() << ""  return "" << error_ret << "";"" << endl << indent() << ""xfer += ret;""
+-        << endl;
++    if ((tbase != t_base_type::TYPE_STRING) && allocate) {
++      scope_up(out);
++      out << indent() << ""g_free (&"" << name << "");"" << endl;
++      out << indent() << ""return "" << error_ret << "";"" << endl;
++      scope_down(out);
++      out << indent() << ""xfer += ret;"" << endl;
++    }
++    else{
++      out << indent() << ""  return "" << error_ret << "";"" << endl << indent() << ""xfer += ret;""
++         << endl;
++    }
+ 
+     // load the byte array with the data
+     if (tbase == t_base_type::TYPE_STRING && type->is_binary()) {",Why is that test different to line 4022 (allocate is not tested there)? Shouldn't that be consistent?,I don't think you need the `&` here.
+9933,"@@ -472,7 +472,15 @@ ExWorkProcRetcode ExHbaseAccessInsertSQTcb::work()
+ 	  {
+ 	    rc = applyPred(scanExpr());
+ 	    if (rc == 1) // expr is true or no expr
+-	      step_ = CREATE_MUTATIONS;
++	      {
++		 rc = evalInsDelPreCondExpr();
++		 if (rc == -1)
++		   step_ = HANDLE_ERROR;
++		 else if (rc == 0)
++		   step_ = INSERT_CLOSE;
++		 else
++		   step_ = CREATE_MUTATIONS;
++	      }
+ 	    else if (rc == 0) // expr is false
+ 	      step_ = INSERT_CLOSE;
+ 	    else // error","Should we consider move this expression evaluation to SETUP_INSERT step since it evaluates from queue entry. Also, this expression is not evaluated in ExHbaseAccessVsbbUpsertTcb.",I don't think this is the right way 
+9934,"@@ -143,7 +143,8 @@ namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation
+             {
+                 Name = activity.DisplayName,
+ 
+-                Kind = (OtlpTrace.Span.Types.SpanKind)(activity.Kind + 1), // TODO: there is an offset of 1 on the enum.
++                // There is an offset of 1 on the Otlp enum.
++                Kind = (OtlpTrace.Span.Types.SpanKind)(activity.Kind + 1),
+ 
+                 TraceId = ByteStringCtorFunc(traceIdBytes),
+                 SpanId = ByteStringCtorFunc(spanIdBytes),",Don't see any more TODOs here..,Why is this change needed?
+9935,"@@ -190,6 +190,13 @@ func (task *Task) DockerConfig(container *Container) (*docker.Config, *DockerCli
+ }
+ 
+ func (task *Task) dockerConfig(container *Container) (*docker.Config, *DockerClientConfigError) {
++	// Detect the name for S3 images
++	dockerImage := container.Image
++	if strings.HasPrefix(dockerImage, ""s3://"") {
++		slice := strings.Split(dockerImage, ""/"")
++		dockerImage = slice[len(slice)-1]
++	}
++
+ 	dockerVolumes, err := task.dockerConfigVolumes(container)
+ 	if err != nil {
+ 		return nil, &DockerClientConfigError{err.Error()}",Can you extract this out to a constant?,I think this should be `strings.Trim
+9936,"@@ -452,12 +452,12 @@ def main(args):
+                 quiet_build=args.quiet_build,
+                 logfile=logfile
+             )
+-
+-            log_module = __load_module(""log"")
+             __update_if_key_exists(args, log_args, ""verbose"")
+ 
++            log_module = __load_module(""log"")
+             LOG.debug(""Calling LOG with args:"")
+             LOG.debug(log_args)
++
+             log_module.main(log_args)
+         elif 'logfile' in args:
+             logfile = args.logfile","any testcase for saargs, and tidyargs argument processing?",Why was this removed?
+9937,"@@ -18,6 +18,7 @@ namespace Microsoft.Cci.Writers.CSharp
+         private bool _forCompilation;
+         private bool _forCompilationIncludeGlobalprefix;
+         private bool _forCompilationThrowPlatformNotSupported;
++        private string _platformNotSupportedExceptionMessage;
+         private bool _includeFakeAttributes;
+ 
+         public CSDeclarationWriter(ISyntaxWriter writer)",@ericstj do you think it is worth combining these two? With the presence of the message meaning it is enabled?,private string _platf
+9938,"@@ -271,8 +271,8 @@ func (s *ec2Ops) DeviceMappings() (map[string]string, error) {
+ 		if d.DeviceName != nil && d.Ebs != nil && d.Ebs.VolumeId != nil {
+ 			devName := *d.DeviceName
+ 			// Per AWS docs EC instances have the root mounted at
+-			// /dev/sda1, this label should be skipped
+-			if devName == ""/dev/sda1"" {
++			// /dev/sda1, /dev/xvda this label should be skipped
++			if devName == ""/dev/sda1"" || devName == ""/dev/xvda"" {
+ 				continue
+ 			}
+ 			// AWS EBS volumes get mapped from /dev/sdN -->/dev/xvdN",why not use instance.RootDeviceName ?,I'm not sure if this 
+9939,"@@ -14,6 +14,7 @@
+ 
+ #include <ios>      //std::ios_base::failure
+ #include <iostream> //std::cout
++#include <fstream>  //std::ifstream
+ #include <mpi.h>
+ #include <stdexcept> //std::invalid_argument std::exception
+ #include <vector>","not needed, ADIOS2 also needs to check for subfiles. ADIOS2 tries to remove dependency on serial `fstream`.",Why is this needed?
+9940,"@@ -50,6 +50,12 @@ class DatabaseDriverReactNative {
+ 		});
+ 	}
+ 
++	loadExtension(path) {
++		return new Promise(() => {
++			throw new Error(`No extension support for ${path} in react-native-sqlite-storage`);
++		});
++	}
++
+ 	exec(sql, params = null) {
+ 		return new Promise((resolve, reject) => {
+ 			this.db_.executeSql(",no need to wrap in new Promise - you can simply throw the exception,Why do we need this?
+9941,"@@ -2438,3 +2438,17 @@ func getOCSPStatus(s tls.ConnectionState) (*ocsp.Response, error) {
+ 	}
+ 	return resp, nil
+ }
++
++func TestOCSPManualConfig(t *testing.T) {
++	o := DefaultTestOptions
++	o.HTTPHost = ""127.0.0.1""
++	o.HTTPSPort = -1
++	o.TLSConfig = &tls.Config{ServerName: ""localhost""}
++	cert, err := tls.LoadX509KeyPair(""configs/certs/server-cert.pem"", ""configs/certs/server-key.pem"")
++	if err != nil {
++		t.Fatalf(""Got error reading certificates: %s"", err)
++	}
++	o.TLSConfig.Certificates = []tls.Certificate{cert}
++	s := RunServer(&o)
++	s.Shutdown()
++}","Isn't this testing an implicit config, not a manual config?",nit: can we use `t.F
+9942,"@@ -205,6 +205,12 @@ type Table struct {
+ 	// to what we calculate from chainToContents.
+ 	chainToDataplaneHashes map[string][]string
+ 
++	// chainsToFullRules contains the full rules, mapped from chain name to slices of rules in that chain.
++	chainsToFullRules map[string][]string
++
++	// hashToFullRules contains a mapping of rule hashes to the full rules.
++	hashToFullRules map[string]string
++
+ 	// hashCommentPrefix holds the prefix that we prepend to our rule-tracking hashes.
+ 	hashCommentPrefix string
+ 	// hashCommentRegexp matches the rule-tracking comment, capturing the rule hash.","I don't think this is used any more, please remove.",nit: `map[string][]s
+9943,"@@ -42,9 +42,11 @@ func NewManager(mysteriumClient server.Client, dialogEstablisherFactory DialogEs
+ 	}
+ }
+ 
+-func (manager *connectionManager) Connect(id identity.Identity, nodeKey string) error {
++func (manager *connectionManager) Connect(myId identity.Identity, nodeKey string) error {
+ 	manager.status = statusConnecting()
+ 
++	providerId := identity.FromAddress(nodeKey)
++
+ 	proposals, err := manager.mysteriumClient.FindProposals(nodeKey)
+ 	if err != nil {
+ 		manager.status = statusError(err)",shouldn't we name abbreviations up-cased? `myId` -> `myID`?,`providerId` is unus
+9944,"@@ -287,7 +287,10 @@ export function recollectNodeTree(node, unmountOnly) {
+ 	else {
+ 		// If the node's VNode had a ref function, invoke it with null here.
+ 		// (this is part of the React spec, and smart for unsetting references)
+-		if (node[ATTR_KEY]!=null) applyRef(node[ATTR_KEY].ref, null);
++		if (node[ATTR_KEY]!=null) {
++			applyRef(node[ATTR_KEY].ref, null);
++			delete node[ATTR_KEY].ref;
++		}
+ 
+ 		if (unmountOnly===false || node[ATTR_KEY]==null) {
+ 			removeNode(node);","This just always calls refs. I think we need to either hoist ref invocation back out of `setProperty()` (it used to happen during rendering), or wait for component recycling to go away.",Why is this needed?
+9945,"@@ -618,7 +618,10 @@ func runTest(t *testing.T, test testT) {
+ 	defer test.builder.Stop()
+ 
+ 	c := &controller{}
+-	c.Register(test.builder.Context)
++	_, _, err := c.Register(test.builder.Context)
++	if err != nil {
++		t.Errorf(""Error registering the controller: %v"", err)
++	}
+ 	c.accountRegistry = &accountstest.FakeRegistry{
+ 		GetClientFunc: func(_ string) (acmecl.Interface, error) {
+ 			return test.acmeClient, nil",Oof. I may have missed this while reviewing #3805,Shouldn't this be `
+9946,"@@ -3,8 +3,12 @@
+ // caffe::Caffe functions so that one could easily call it from matlab.
+ // Note that for matlab, we will simply use float as the data type.
+ 
+-#include <string>
+-#include <vector>
++// these need to be included after boost on OS X
++#include <string>  // NOLINT(build/include_order)
++#include <vector>  // NOLINT(build/include_order)
++#include <fstream>  // NOLINT
++#include <stdexcept>
++
+ 
+ #include ""mex.h""
+ ",why the NOLINTs here? please just alphabetize the headers (should be easier than adding NOLINTs) unless there's a good reason not to...,Why is this needed?
+9947,"@@ -0,0 +1,5 @@
++export default function() {
++	return <div />;
++}
++
++export const ReactComponent = () => <div />;",Should we maybe return `<svg />` instead?,Why is this a<msg>I
+9948,"@@ -11,6 +11,7 @@ const Cats = require('../lib/status-cats');
+ const Storage = require('../lib/storage');
+ const _ = require('lodash');
+ const cors = require('cors');
++const load_plugins = require('../lib/plugin-loader').load_plugins;
+ 
+ module.exports = function(config_hash) {
+   // Config",Please use camelCase in new code,Why do we need this?
+9949,"@@ -14,5 +14,6 @@ return [
+ 	'selectLocale'  => 'Select one of the supported languages',
+ 	'contact'		=> 'Contact',
+ 	'contact-us'	=> 'Contact Us',
++    'places'        => 'Places',
+ 
+ ];","Looks like the whitespace is off here. Not sure if there's a space or two too many or if there is an issue with tabs vs. spaces, but you probably want to fix this :)",This should be `Plac
+9950,"@@ -17,7 +17,12 @@
+ ## along with Invenio; if not, write to the Free Software Foundation, Inc.,
+ ## 59 Temple Place, Suite 330, Boston, MA 02111-1307, USA.
+ 
+-""""""Base bundles.""""""
++""""""Base bundles.
++
++.. note:: `bootstrap.js` bundle must be loaded after jQuery UI to avoid conflicts.
++    You can use `noConflict()` if you need to access functions
++    of jQuery UI covered by `bootstrap.js`.
++""""""
+ 
+ from invenio.ext.assets import Bundle
+ ",This was just my laziness and I didn't copy the first line. Just remove it together with one empty line. Thanks,I don't think we nee
+9951,"@@ -9,8 +9,8 @@ use Shopsys\FrameworkBundle\Model\Pricing\Vat\Vat;
+ use Shopsys\FrameworkBundle\Model\Pricing\Vat\VatData;
+ use Shopsys\FrameworkBundle\Model\Product\Availability\Availability;
+ use Shopsys\FrameworkBundle\Model\Product\Availability\AvailabilityData;
+-use Shopsys\FrameworkBundle\Model\Product\Product;
+-use Shopsys\FrameworkBundle\Model\Product\ProductDataFactory;
++use Shopsys\FrameworkBundle\Model\Product\ProductDataFactoryInterface;
++use Shopsys\ShopBundle\Model\Product\Product;
+ use Tests\ShopBundle\Test\DatabaseTestCase;
+ 
+ class CartItemTest extends DatabaseTestCase",Why did you decide to change CartItemTest but you didnt change QueryBuilderWithRowManipulatorDataSourceTest?,Why this change?
+9952,"@@ -425,7 +425,15 @@ func (k *KeybaseServiceBase) LoadUserPlusKeys(ctx context.Context,
+ 	uid keybase1.UID, pollForKID keybase1.KID) (UserInfo, error) {
+ 	cachedUserInfo := k.getCachedUserInfo(uid)
+ 	if cachedUserInfo.Name != libkb.NormalizedUsername("""") {
+-		return cachedUserInfo, nil
++		if pollForKID == keybase1.KID("""") {
++			return cachedUserInfo, nil
++		}
++		// Skip the cache if pollForKID isn't present.
++		for _, key := range cachedUserInfo.VerifyingKeys {
++			if key.KID().Equal(pollForKID) {
++				return cachedUserInfo, nil
++			}
++		}
+ 	}
+ 
+ 	arg := keybase1.LoadUserPlusKeysArg{Uid: uid, PollForKID: pollForKID}","This was sort of a pre-existing bug -- we should be busting our local cache if the key isn't present. However, `KBPKIClient.HasVerifyingKey` already took care of it on that path. This way is better though.",I don't think this is the right place to skip the cache. I think it should be in `loadUserPlusKeys`
+9953,"@@ -1,5 +1,6 @@
+ // Code generated by private/model/cli/gen-api/main.go. DO NOT EDIT.
+ 
++//go:build go1.15 && integration
+ // +build go1.15,integration
+ 
+ package cloudfront_test",Should this tag addition for generated files be handled explicitly in `private/model/cli/gen-api/main.go`,"// +build go1.15,integration"
+9954,"@@ -4753,6 +4753,11 @@ public class MessagingController implements Runnable {
+      */
+     private void notifyAccount(Context context, Account account,
+             LocalMessage message, int previousUnreadMessageCount) {
++    	// if it's quiet time and notifications are disabled, then we shouldn't show a notification
++        if (K9.isQuietTime() && K9.getQuietTimeNotificationEnabled()) {
++            return;
++        }
++
+         final NotificationData data = getNotificationData(account, previousUnreadMessageCount);
+         synchronized (data) {
+             notifyAccountWithDataLocked(context, account, message, data);",You want to return if it's quiet time and notifications during quiet time are **not** enabled. So this is either a logic error or it's bad naming of the setting/field/method.,I don't think this is the right place to put this check. I think it should be in `notifyAccountWith
+9955,"@@ -28,14 +28,11 @@ Workshops::Application.configure do
+   config.log_level = :info
+   config.log_formatter = ::Logger::Formatter.new
+ 
+-  HOST = 'learn.thoughtbot.com'
+-  config.action_mailer.default_url_options = {host: HOST}
+-
+   config.middleware.use Rack::SslEnforcer,
+     hsts: false,
+     except: %r{^/podcast},
+     strict: true,
+-    redirect_to: ""https://#{HOST}""
++    redirect_to: ""https://#{ENV['APP_DOMAIN']}""
+ 
+   config.action_mailer.delivery_method = :smtp
+   config.action_mailer.smtp_settings = MAIL_SETTINGS",Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.,I think this should be `ENV['APP_DOMAIN'] || HOST`
+9956,"@@ -144,7 +144,12 @@ module Travis
+       def source_ssh?
+         return false if prefer_https?
+         repo_private? && !installation? or
+-          repo_private? && custom_ssh_key?
++          repo_private? && custom_ssh_key? or
++            force_private? && !installation?
++      end
++
++      def force_private?
++        source_host.exclude? 'github.com'
+       end
+ 
+       def source_host","cool, here (L146 && L148) maybe (repo_private? || force_private?) && !installation? to prevent double call of installation?",I think this should be `force_private?`
+9957,"@@ -33,7 +33,7 @@ provide a working environment for development.`,
+ func appStart() {
+ 	app, err := platform.GetActiveApp("""")
+ 	if err != nil {
+-		util.Failed(""Failed to start: %s"", err)
++		util.Failed(""Failed to GetActiveApp err: %v"", err)
+ 	}
+ 
+ 	fmt.Printf(""Starting environment for %s...\n"", app.GetName())","this error carries a bit more meaning for us, but less meaning for users. we also lose the context of what command produced the failure. I'd prefer to keep the original error message. If we need better identification of GetActiveApp errors, maybe we could address that in the error messages it returns?",`Failed to start: %v`
+9958,"@@ -97,7 +97,7 @@ const (
+ const sendRouteSubsInGoRoutineThreshold = 1024 * 1024 // 1MB
+ 
+ // Warning when user configures cluster TLS insecure
+-const clusterTLSInsecureWarning = ""TLS Hostname verification disabled, system will not verify identity of the solicited route""
++const clusterTLSInsecureWarning = ""TLS certificate chain and hostname of solicited routes will not be verified, do not use in production!""
+ 
+ // Can be changed for tests
+ var routeConnectDelay = DEFAULT_ROUTE_CONNECT",Same: DO NOT USE IN PRODUCTION. Yes we should shout ;),"""TLS certificate chain and hostname of "
+9959,"@@ -134,7 +134,7 @@ namespace Microsoft.DotNet.Build.Tasks.Feed
+             await clientThrottle.WaitAsync();
+             string leaseId = string.Empty;
+             //this defines the lease for 15 seconds (max is 60) and 3000 milliseconds between requests
+-            AzureBlobLease blobLease = new AzureBlobLease(feed.AccountName, feed.AccountKey, string.Empty, feed.ContainerName, uploadPath, Log, ""15"", ""3000"");
++            AzureBlobLease blobLease = new AzureBlobLease(feed.AccountName, feed.AccountKey, string.Empty, feed.ContainerName, uploadPath, Log, ""15"", ""5000"");
+ 
+             bool isLeaseRequired = allowOverwrite && await feed.CheckIfBlobExists(uploadPath);
+ ","This change may be hiding more errors, if we continue to see more.",Why do we need to change this?
+9960,"@@ -246,13 +246,13 @@ namespace Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http2
+ 
+         object IFeatureCollection.this[Type key]
+         {
+-            get => FastFeatureGet(key);
++            get => FastFeatureGet(key) ?? ConnectionFeatures?[key];
+             set => FastFeatureSet(key, value);
+         }
+ 
+         TFeature IFeatureCollection.Get<TFeature>()
+         {
+-            return (TFeature)FastFeatureGet(typeof(TFeature));
++            return (TFeature)(FastFeatureGet(typeof(TFeature)) ?? ConnectionFeatures?[typeof(TFeature)]);
+         }
+ 
+         void IFeatureCollection.Set<TFeature>(TFeature instance)",Beware of exposing the underlying features directly. Any mutable fields should be reset per request.,Why is this change necessary?
+9961,"@@ -144,12 +144,18 @@ export function renderComponent(component, opts, mountAll, isChild) {
+ 		if (initialBase && base!==initialBase && inst!==initialChildComponent) {
+ 			let baseParent = initialBase.parentNode;
+ 			if (baseParent && base!==baseParent) {
+-				baseParent.replaceChild(base, initialBase);
+ 
+ 				if (!toUnmount) {
++					baseParent.replaceChild(base, initialBase);
+ 					initialBase._component = null;
+ 					recollectNodeTree(initialBase, false);
+ 				}
++				// @TODO Formerly the initialBase was always replaced by the base
++				//		 but somehow all tests passes also if its only called at not unmounting.
++				//       These else condition was the original fix.
++				// else {
++				// 	baseParent.insertBefore(base, initialBase);
++				// }
+ 			}
+ 		}
+ ","This is probably more nuanced than I can feasibly check in a PR review, haha. Was the issue here that `replaceChild()` removes `initialBase` from the DOM before `recollectNodeTree()` invokes `componentWillUnmount()` on the owning component?",I'm not sure if this is the r
+9962,"@@ -35,3 +35,6 @@ def testCanClickOnALinkThatOverflowsAndFollowIt(driver):
+ def testClickingALinkMadeUpOfNumbersIsHandledCorrectly(driver):
+     driver.find_element(By.LINK_TEXT, ""333333"").click()
+     WebDriverWait(driver, 3).until(EC.title_is(""XHTML Test Page""))
++
++def testCannotClickDisabledButton(driver):
++    WebDriverWait(driver, 3).until(EC.element_to_be_unclickable(By.ID, ""disabled-button""))","I believe it's misleading name for the condition. I prefer ""element_to_be_disable"" We can have a condition, when element is enabled but we can't click it, because another element overlays above it. So, If we use ""unclickable"" we might mislead people, who use that condition to verify if element can be clicked",I think you can use `wait_for
+9963,"@@ -86,4 +86,8 @@ public class DataWriter<T> implements Closeable {
+     Preconditions.checkState(dataFile != null, ""Cannot create data file from unclosed writer"");
+     return dataFile;
+   }
++
++  public FileAppender<T> appender() {
++    return appender;
++  }
+ }",Do we need to expose it? It looks like it is only used in tests and only to obtain the final metrics. I think you can get the same by using `DataFile#lowerBounds` and `DataFile#upperBounds`. It seems `DataWriter` already exposes `toDataFile` that you can use.,Why do we need this?
+9964,"@@ -868,7 +868,7 @@ describe(""date_utils"", function() {
+     });
+ 
+     it(""should return the 4 2021 year week"", () => {
+-      const date = new Date(""2021-01-18"");
++      const date = new Date(""2021-01-19"");
+       assert(getWeek(date) === 3);
+     });
+ ",the test was failing likely due to locale issue. had to increment the date by 1 to make it pass,Why did this change?
+9965,"@@ -935,15 +935,8 @@ bool Levitate(const InstantSpell*, Creature* creature, const std::string& param)
+ bool InstantSpell::loadFunction(const pugi::xml_attribute& attr)
+ {
+ 	const char* functionName = attr.as_string();
+-	if (strcasecmp(functionName, ""levitate"") == 0) {
+-		function = Levitate;
+-	} else {
+-		std::cout << ""[Warning - InstantSpell::loadFunction] Function \"""" << functionName << ""\"" does not exist."" << std::endl;
+-		return false;
+-	}
+-
+-	scripted = false;
+-	return true;
++	std::cout << ""[Warning - InstantSpell::loadFunction] Function \"""" << functionName << ""\"" does not exist."" << std::endl;
++	return false;
+ }
+ 
+ bool InstantSpell::playerCastInstant(Player* player, std::string& param)",The changes below here can also be undone.,Why is this removed?
+9966,"@@ -1,13 +1,14 @@
+ package channelq
+ 
+ import (
++	""context""
+ 	""fmt""
+ 	""strings""
+ 	""sync""
+ 
+ 	""k8s.io/klog""
+ 
+-	""github.com/kubeedge/beehive/pkg/core/context""
++	beehiveContext ""github.com/kubeedge/beehive/pkg/core/context""
+ 	""github.com/kubeedge/kubeedge/cloud/pkg/cloudhub/common/model""
+ )
+ ","Instead of importing context besides beehivecontext, I'd suggest include golang context functionalities into beehivecontext. To keep channelq only rely on beehive.",I don't think we nee
+9967,"@@ -88,6 +88,9 @@ public class AddProductNutritionFactsData {
+         PREFIX_NUTRIMENT_LONG_NAME + ""vitamin-k"",
+         PREFIX_NUTRIMENT_LONG_NAME + ""zinc""));
+ 
++    private AddProductNutritionFactsData() {
++    }
++
+     static String getCompleteEntryName(CustomValidatingEditTextView editText) {
+         return PREFIX_NUTRIMENT_LONG_NAME + editText.getEntryName();
+     }",I'm not sure about this one. Are you sure we don't need to initialize this fragment anywhere else?,Why do we need this 
+9968,"@@ -644,6 +644,7 @@ public class LocalInsightPlugin extends PluginBase implements PumpInterface, Con
+                 result.comment = ExceptionTranslator.getString(e);
+             }
+         } else if (detailedBolusInfo.carbs > 0) {
++            TreatmentsPlugin.getPlugin().addToHistoryTreatment(detailedBolusInfo, true);
+             result.success = true;
+             result.enacted = true;
+         }","You didn't set a source here, so it will probably fail.",Shouldn't this be `false`?
+9969,"@@ -52,7 +52,7 @@ func TestHandlerSucces(t *testing.T) {
+ 	headers.Set(BaggageHeaderPrefix+""BAR"", ""baz"")
+ 
+ 	rpcHandler := transporttest.NewMockHandler(mockCtrl)
+-	httpHandler := handler{rpcHandler}
++	httpHandler := handler{rpcHandler, transport.NoDeps}
+ 
+ 	rpcHandler.EXPECT().Handle(
+ 		transporttest.NewContextMatcher(t,",Might be easier to just do `handler{Handler: rpcHandler}` since zero-value of `Deps` is now valid.,why this change?
+9970,"@@ -15,6 +15,10 @@ module Faker
+       def quote
+         fetch('movie.quote')
+       end
++
++      def title
++        fetch('movie.title')
++      end
+     end
+   end
+ end",Could you please add docs for this method?,Extra empty line detected 
+9971,"@@ -132,9 +132,16 @@ public abstract class AbstractApexNode<T extends AstNode> extends AbstractNode i
+ 
+     @Override
+     public String toString() {
++        return getXPathNodeName();
++    }
++
++
++    @Override
++    public final String getXPathNodeName() {
+         return this.getClass().getSimpleName().replaceFirst(""^AST"", """");
+     }
+ 
++
+     public String getLocation() {
+         if (hasRealLoc()) {
+             return String.valueOf(node.getLoc());",we should probably `@Deprecated` this implementation to be removed in PMD 7.0.0,Why is this needed?
+9972,"@@ -242,7 +242,11 @@ module Bolt
+         end
+ 
+         def shell
+-          @shell ||= Bolt::Shell::Bash.new(target, self)
++          @shell ||= if target.options['login-shell'] == 'powershell'
++                       Bolt::Shell::Powershell.new(target, self)
++                     else
++                       Bolt::Shell::Bash.new(target, self)
++                     end
+         end
+ 
+         # This is used by the Bash shell to decide whether to `cd` before","I wonder if 'unix' makes more sense for this now? I was thinking of putting up a 'cleanup' PR - I think I missed a few ""remote"" var names in the first PR, and want to reassess unifying the transport classes that just define `with_connection`. Renaming this could be part of that.","I'm not sure if this is the right way to do this. I think it would be better to have a `Bolt::Shell::Powershell.new(target, self)` method."
+9973,"@@ -52,8 +52,8 @@ namespace Microsoft.CodeAnalysis.Sarif.Converters
+         {
+             const string source = ""<results> <cppcheck version=\""12.34\"" /> <errors>   </errors> </results>"";
+             const string expected = @""{
+-  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0-beta.5"""",
+-  """"version"""": """"1.0.0-beta.5"""",
++  """"$schema"""": """"http://json.schemastore.org/sarif-1.0.0"""",
++  """"version"""": """"1.0.0"""",
+   """"runs"""": [
+     {
+       """"tool"""": {",Do something similar to what was done in JsonTests (can you derive from JsonTests?),Why is this change needed?
+9974,"@@ -15,4 +15,4 @@
+ #
+ 
+ # https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages
+-__path__ = __import__('pkgutil').extend_path(__path__, __name__)
++__path__ = __import__('pkgutil').extend_path(__path__, __name__)  # type: ignore","Yes, not much we can do here.",Why is this ignore needed?
+9975,"@@ -24,16 +24,16 @@ import (
+ 	""strings""
+ 	""time""
+ 
+-	""go.uber.org/zap""
++	_ ""knative.dev/pkg/metrics/testing""
+ 
+ 	cev2 ""github.com/cloudevents/sdk-go/v2""
+-
+ 	""github.com/cloudevents/sdk-go/v2/binding""
+ 	""github.com/cloudevents/sdk-go/v2/binding/transformer""
+ 	""github.com/cloudevents/sdk-go/v2/protocol""
+ 	""github.com/cloudevents/sdk-go/v2/protocol/http""
+ 	""github.com/google/knative-gcp/pkg/metrics""
+ 	""github.com/google/wire""
++	""go.uber.org/zap""
+ 	""knative.dev/eventing/pkg/kncloudevents""
+ 	""knative.dev/eventing/pkg/logging""
+ )",Why do we need this?,Why is this needed?
+9976,"@@ -0,0 +1,17 @@
++var bitcore = require('../bitcore');
++var Address = bitcore.Address;
++var bitcoreUtil = bitcore.util;
++var Script = bitcore.Script;
++var network = bitcore.networks.livenet;
++
++
++var script = ''; // write down your script here
++var s = Script.fromHumanReadable(script);
++var hash = bitcoreUtil.sha256ripe160(s.getBuffer());
++var version = network.addressScript;
++
++var addr = new Address(version, hash);
++var addrStr = addr.as('base58');
++
++// This outputs the ""address"" of thescript
++console.log(addrStr);",Would prefer to see an actual script here.,Please remove the console.log
+9977,"@@ -191,7 +191,7 @@ public class FileHandler {
+       final long copied = Files.copy(from.toPath(), out);
+       final long length = from.length();
+       if (copied != length) {
+-        throw new IOException(""Could not transfer all bytes."");
++        throw new IOException(""Could not transfer all bytes of "" + from.toPath());
+       }
+     }
+   }",seems reasonable to also want to include the 'to' location?,nit: `of` -> `from`
+9978,"@@ -12,5 +12,4 @@ __all__ = [
+     'CustomDataset', 'XMLDataset', 'CocoDataset', 'VOCDataset', 'GroupSampler',
+     'DistributedGroupSampler', 'build_dataloader', 'to_tensor', 'random_scale',
+     'show_ann', 'get_dataset', 'ConcatDataset', 'RepeatDataset',
+-    'ExtraAugmentation'
+-]
++    'ExtraAugmentation']",This change is unnecessary.,Why did you change this?
+9979,"@@ -61,7 +61,11 @@ public final class MiniatureListWidget<E> extends ScrollPane {
+         this.mappedElements = new MappedList<Element<E>, E>(items, value -> {
+             Element newElement = converter.apply(value);
+ 
+-            newElement.setOnMouseClicked(event -> setOnMouseClicked.accept(newElement, event));
++            newElement.setOnMouseClicked(event -> {
++                unselectAll();
++                setOnMouseClicked.accept(newElement, event);
++                select(newElement);
++            });
+ 
+             return newElement;
+         });","Just as a note: Is it possible that the select css class is the same as the hover one? If this is true we should choose a different style for the selection css class, to make it more clear to the user I think.",Why is this needed?
+9980,"@@ -106,6 +106,11 @@ type ControllerOptions struct {
+ 	EnablePprof bool
+ 
+ 	DNS01CheckRetryPeriod time.Duration
++
++	// Annotations copied Certificate -> CertificateRequest,
++	// CertificateRequest -> Order. Slice of string literals that are
++	// treated as prefixes for annotation keys.
++	CopiedAnnotations []string
+ }
+ 
+ const (","What about Secrets, are we not also trying to cover those?",I think this should be a `map[string]struct{}`
+9981,"@@ -37,7 +37,7 @@
+ #include <jansson.h>
+ 
+ #include ""src/common/libutil/log.h""
+-#include ""src/common/libkvs/jansson_dirent.h""
++#include ""src/common/libkvs/treeobj.h""
+ 
+ #include ""commit.h""
+ #include ""kvs_util.h""",(commit messge): how about > update internal commit API for RFC 11,"#include ""kvs_util.h"""
+9982,"@@ -27,7 +27,7 @@ var eventErrorStates = []string{
+ }
+ 
+ var waiters = []request.WaiterOption{
+-	request.WithWaiterDelay(request.ConstantWaiterDelay(3 * time.Second)), // Poll for cfn updates every 3 seconds.
++	request.WithWaiterDelay(request.ConstantWaiterDelay(5 * time.Second)), // How long to wait in between poll cfn for updates.
+ 	request.WithWaiterMaxAttempts(1800),                                   // Wait for at most 90 mins for any cfn action.
+ }
+ ","This will now wait for 2.5 hours, not 90 minutes, if the waiter delay is 5s",I'm not sure if this is a good idea. I think i
+9983,"@@ -14,6 +14,7 @@ THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS ""AS IS"" AND
+ const EventUtil = {
+ 
+   trapEvent(event){
++    if(!event) return
+     event.preventDefault();
+     event.stopPropagation();
+     if(event.nativeEvent && event.nativeEvent.preventDefault){",See this error on console too so I don't think it's just test simulation. For some reason event doesn't show up sometimes,`if(!event) return;`
+9984,"@@ -44,7 +44,7 @@ func main() {
+ 		cmds.NewCRICTL(externalCLIAction(""crictl"", dataDir)),
+ 		cmds.NewCtrCommand(externalCLIAction(""ctr"", dataDir)),
+ 		cmds.NewCheckConfigCommand(externalCLIAction(""check-config"", dataDir)),
+-		cmds.NewEtcdSnapshotCommand(etcdsnapshotCommand, cmds.NewEtcdSnapshotSubcommands(etcdsnapshotCommand)),
++		cmds.NewEtcdSnapshotCommand(etcdsnapshotCommand, cmds.NewEtcdSnapshotSubcommands(etcdsnapshotCommand, etcdsnapshotCommand)),
+ 	}
+ 
+ 	if err := app.Run(os.Args); err != nil {",We're passing the same thing twice?,I don't think we need this anymore.
+9985,"@@ -245,7 +245,8 @@ func TestCreateInstance(t *testing.T) {
+ 				},
+ 				Spec: clusterv1.MachineSpec{
+ 					Bootstrap: clusterv1.Bootstrap{
+-						Data: pointer.StringPtr(""user-data""),
++						// echo ""user-data"" | base64
++						Data: pointer.StringPtr(""dXNlci1kYXRhCg==""),
+ 					},
+ 				},
+ 			},",Shouldn't the value in Bootstrap.Data be just a plain string?,Why do we need this change?
+9986,"@@ -209,7 +209,9 @@ namespace Datadog.Trace.AppSec
+         private void Report(ITransport transport, Span span, WafMatch[] results, bool blocked)
+         {
+             span.SetTag(Tags.AppSecEvent, ""true"");
+-            span.SetTraceSamplingPriority(SamplingPriority.UserKeep);
++            var samplingPirority = _settings.KeepTraces
++                ? SamplingPriority.UserKeep : SamplingPriority.AutoReject;
++            span.SetTraceSamplingPriority(samplingPirority);
+ 
+             LogMatchesIfDebugEnabled(results, blocked);
+ ","@robertpi Isn't this changing the sampling priority when `KeepTraces==false`? The sampling priority could be `AutoReject` or `AutoKeep`, based on the sampling decision (or the user may have specified something else). Seems like we shouldn't be changing it in this case?",nit: `var samplingPirority = _setti
+9987,"@@ -17,6 +17,11 @@ const (
+ 	DefaultCADir        = ""/etc/kubeedge/ca""
+ 	DefaultCertDir      = ""/etc/kubeedge/certs""
+ 
++	DefaultCAURL   = ""/ca.crt""
++	DefaultCertURL = ""/edge.crt""
++
++	DefaultCloudCoreReadyCheckURL = ""/readyz""
++
+ 	DefaultStreamCAFile   = ""/etc/kubeedge/ca/streamCA.crt""
+ 	DefaultStreamCertFile = ""/etc/kubeedge/certs/stream.crt""
+ 	DefaultStreamKeyFile  = ""/etc/kubeedge/certs/stream.key""",The const can also be used in cloud/pkg/cloudhub/servers/httpserver/server.go L46-47?,Why do we need this?
+9988,"@@ -82,7 +82,7 @@ Blockly.Procedures.allProcedureMutations = function(root) {
+   var blocks = root.getAllBlocks();
+   var mutations = [];
+   for (var i = 0; i < blocks.length; i++) {
+-    if (blocks[i].type === 'procedures_prototype') {
++    if (blocks[i].type == 'procedures_prototype') {
+       var mutation = blocks[i].mutationToDom();
+       if (mutation) {
+         mutations.push(mutation);",Use a constant for `procedures_prototype`.,Why this change?
+9989,"@@ -12,7 +12,7 @@ def bad_percent(arg):
+ 
+ def good_percent(arg):
+     '''Instead of passing multiple arguments, format the message'''
+-    raise KeyError('Bad key: %r' % arg)
++    raise KeyError(f'Bad key: {arg!r}')
+ 
+ def bad_multiarg(name, value):
+     '''Raising a formatted string and multiple additional arguments'''",This file should probably not be touched as the formatting of the string seems to be a test in itself ?,`arg` is a strin
+9990,"@@ -276,8 +276,11 @@ is_sys_kill(dcontext_t *dcontext, byte *pc, byte *xsp, siginfo_t *info);
+ int
+ sigaction_syscall(int sig, kernel_sigaction_t *act, kernel_sigaction_t *oact)
+ {
+-#if defined(X64) && !defined(VMX86_SERVER) && defined(LINUX)
++#if !defined(VMX86_SERVER) && defined(LINUX)
+     /* PR 305020: must have SA_RESTORER for x64 */
++    /* Must have SA_RESTORER to handle vsyscall32 being disabled
++       (see https://github.com/DynamoRIO/dynamorio/issues/2812)
++    */
+     if (act != NULL && !TEST(SA_RESTORER, act->flags)) {
+         act->flags |= SA_RESTORER;
+         act->restorer = (void (*)(void)) dynamorio_sigreturn;",style nit: missing leading '*',I don't think we
+9991,"@@ -184,7 +184,7 @@ public class PrivateTransactionProcessor {
+       messageFrameStack.addFirst(initialFrame);
+ 
+       while (!messageFrameStack.isEmpty()) {
+-        process(messageFrameStack.peekFirst(), operationTracer);
++        process(messageFrameStack.peekFirst(), OperationTracer.NO_TRACING);
+       }
+ 
+       if (initialFrame.getState() == MessageFrame.State.COMPLETED_SUCCESS) {",The operationTracer is passed into the processTransaction() method. We should probably pass the no tracing in one in from where it is called.,Why is this chan
+9992,"@@ -125,13 +125,10 @@ const (
+ 
+ // SPI on the Arduino Nano 33.
+ var (
+-	SPI0 = SPI{Bus: sam.SERCOM0_SPI,
+-		SCK:     SPI0_SCK_PIN,
+-		MOSI:    SPI0_MOSI_PIN,
+-		MISO:    SPI0_MISO_PIN,
+-		DOpad:   spiTXPad2SCK3,
+-		DIpad:   sercomRXPad0,
+-		PinMode: PinSERCOM}
++	SPI0 = SPI{
++		Bus:    sam.SERCOM0_SPI,
++		SERCOM: 0,
++	}
+ )
+ 
+ // I2S pins","I believe this line was an error, it should have been `sercomRXPad1` to be consistent with the pin numbers. Resolving this ambiguity by following the pin numbers.",Why is this needed?
+9993,"@@ -0,0 +1,12 @@
++<div>
++  <p>
++    Hello,<br/>
++    The request, <%= @proposal.name %> (<%= @proposal.public_id %>), has been cancelled.
++  </p>
++</div>
++
++<p>
++  <strong>
++    <%= link_to ""View This Request"", proposal_url(@proposal), {target: 'C2'} %>
++  </strong>
++</p>","May be useful to have the reason here, though clearly not pressing.",This should be `Vie
+9994,"@@ -136,7 +136,7 @@ class GridInterface(DictInterface):
+                                 'of arrays must match. %s found that arrays '
+                                 'along the %s dimension do not match.' %
+                                 (cls.__name__, vdim.name))
+-            stack = np.stack if any(is_dask(arr) for arr in arrays) else dask_array_module().stack
++            stack = dask_array_module().stack if any(is_dask(arr) for arr in arrays) else np.stack
+             new_data[vdim.name] = stack(arrays, -1)
+         return new_data
+ ",These were inverted before,I think this should
+9995,"@@ -4227,6 +4227,11 @@ public class DBService {
+         return null;
+     }
+ 
++    public Map<String, DomainRoleMember> getReviewMembers() {
++        // Currently unimplemented
++        return new HashMap<>();
++    }
++
+     public void processExpiredPendingMembers(int pendingRoleMemberLifespan, final String monitorIdentity) {
+ 
+         final String auditRef = ""Expired - auto reject"";",DB is implemented in PR 951,Why not return an e
+9996,"@@ -15,6 +15,16 @@ import (
+ 	""github.com/prometheus/client_golang/prometheus""
+ )
+ 
++const (
++	bytesToGB = 1073741824
++	bytesToMB = 1048567
++	micSec    = 1000000
++	bytesToKB = 1024
++	minwidth  = 0
++	maxwidth  = 0
++	padding   = 3
++)
++
+ // A gauge is a metric that represents a single numerical value that can
+ // arbitrarily go up and down.
+ ","move all constants to `pkg/util/constants.go`, these constants had been used in `volume_stats.go` file too. So better to import them.",I'm not sure if this is the best place for these constants. It seems like they should be in the `prometheus` package.
+9997,"@@ -1,8 +1,8 @@
+ #appModules/winword.py
+ #A part of NonVisual Desktop Access (NVDA)
+-#Copyright (C) 2006-2017 NV Access Limited, Manish Agrawal, Derek Riemer, Babbage B.V.
+-#This file is covered by the GNU General Public License.
+-#See the file COPYING for more details.
++# Copyright (C) 2006-2020 NV Access Limited, Manish Agrawal, Derek Riemer, Babbage B.V.
++# This file is covered by the GNU General Public License.
++# See the file COPYING for more details.
+ 
+ import ctypes
+ import time",Could you revisit the full header and add appropriate spaces after the hashes?,Why did you change the year?
+9998,"@@ -102,6 +102,11 @@ class CodeEditor extends FormWidgetBase
+      */
+     public $showPrintMargin = false;
+ 
++    /**
++     * @var string Hint to show above the code editor
++     */
++    public $codeHint = '';
++
+     //
+     // Object properties
+     //",This should either be `hint` that takes a string to render inside of the partial container or probably better you should just render a separate hint field above the code field in the same tab.,Why is this needed?
+9999,"@@ -4330,7 +4330,7 @@ func TestJetStreamCrossAccountMirrorsAndSources(t *testing.T) {
+ 		t.Fatalf(""Did not receive correct response: %+v"", scResp.Error)
+ 	}
+ 
+-	checkFor(t, 2*time.Second, 100*time.Millisecond, func() error {
++	checkFor(t, 4*time.Second, 100*time.Millisecond, func() error {
+ 		si, err := js2.StreamInfo(""MY_SOURCE_TEST"")
+ 		if err != nil {
+ 			t.Fatalf(""Could not retrieve stream info"")",this was flapping,Why did this change?
+10000,"@@ -185,6 +185,7 @@ namespace MvvmCross.Platforms.Ios.Views
+             }
+             else
+             {
++                keyboardFrame.Height -= scrollView.SafeAreaInsets.Bottom;
+                 scrollView.CenterView(activeView, keyboardFrame);
+             }
+         }",Please add a check to see if SafeAreaInsets is available. It isn't on all iOS versions.,Why is this needed?
+10001,"@@ -77,7 +77,7 @@ class RolesController < ApplicationController
+       # rubocop:disable LineLength
+       render json: {
+         code: 1,
+-        msg: _(""Successfully changed the permissions for #{@role.user.email}. They have been notified via email."")
++        msg: _(""Successfully changed the permissions for %{email}. They have been notified via email."") % { email: @role.user.email }
+       }
+       # rubocop:enable LineLength
+     else",interpolation here was causing the translation to not get picked up,Line is too long. [
+10002,"@@ -69,8 +69,13 @@ StatelessWriter::StatelessWriter(
+ 
+ StatelessWriter::~StatelessWriter()
+ {
+-    AsyncWriterThread::removeWriter(*this);
+     logInfo(RTPS_WRITER,""StatelessWriter destructor"";);
++
++    mp_RTPSParticipant->async_thread().unregister_writer(this);
++
++    // After unregistering writer from AsyncWriterThread, delete all flow_controllers because they register the writer in
++    // the AsyncWriterThread.
++    flow_controllers_.clear();
+ }
+ 
+ void StatelessWriter::get_builtin_guid()",We don't need to disable the flow controller here as in `StatefulWriter`s destructor?,I think this should
+10003,"@@ -24,7 +24,7 @@ class Service(service.ChromiumService):
+     """"""
+ 
+     def __init__(self, executable_path, port=0, service_args=None,
+-                 log_path=None, env=None):
++                 log_path=None, env=None, create_no_window=False):
+         """"""
+         Creates a new instance of the Service
+ ","I would rather no have this as a `kwarg` as it encourages ""growth"" which lead to an unweildy constructor in other classes. Let's add a method or property to take care of this instead as I think it's usage is going to be quite low.",Why do we need this
+10004,"@@ -313,11 +313,17 @@ func (r *DefaultRuleRenderer) filterOutputChain() *Chain {
+ 	// That decision is based on pragmatism; it's generally very useful to be able to contact
+ 	// any local workload from the host and policing the traffic doesn't really protect
+ 	// against host compromise.  If a host is compromised, then the rules could be removed!
++	// However, we do apply policy to workload ingress traffic if it belongs to an IPVS connection.
+ 	for _, prefix := range r.WorkloadIfacePrefixes {
+-		// If the packet is going to a worklaod endpoint, RETURN.
++		// If the packet is going to a workload endpoint, apply workload ingress policy if traffic
++		// belongs to an IPVS connection and return at the end.
+ 		log.WithField(""ifacePrefix"", prefix).Debug(""Adding workload match rules"")
+ 		ifaceMatch := prefix + ""+""
+ 		rules = append(rules,
++			Rule{
++				Match:  Match().OutInterface(ifaceMatch).IPVSConnection(),
++				Action: JumpAction{Target: ChainToWorkloadDispatch},
++			},
+ 			Rule{
+ 				Match:  Match().OutInterface(ifaceMatch),
+ 				Action: ReturnAction{},","I just noticed that we use Return here, when we have logically allowed a packet, whereas in the forward chain we use AcceptAction. Do you know why that is?",I'm not sure if this is the best way to do this. I think it would be better to do this in the `ChainToWorkloadDispatch` action.
+10005,"@@ -60,3 +60,11 @@ func isABuildFile(name string, config *core.Configuration) bool {
+ 	}
+ 	return false
+ }
++
++// Max is an incredibly complicated function, which is presumably why it didn't make it into the Go stdlib
++func Max(x, y int) int {
++	if x < y {
++		return y
++	}
++	return x
++}",There's one for floats but not for ints. The float implementation is non-trivial though which I guess is the argument there.,Why not just use `math.Max`?
+10006,"@@ -51,6 +51,9 @@ const (
+ 	// 6. QueryWorkflow
+ 	// please also reference selectedAPIsForwardingRedirectionPolicyWhitelistedAPIs
+ 	DCRedirectionPolicySelectedAPIsForwarding = ""selected-apis-forwarding""
++
++	// DCRedirectionPolicyAllAPIsForwarding means forwarding all APIs based on namespace active cluster
++	DCRedirectionPolicyAllAPIsForwarding = ""all-apis-forwarding""
+ )
+ 
+ type (","If we have a redirection policy for Selected API forwarding, why isn't ""redirect all"" just a special case where they are all Selected?",I don't think we need this anymore.
+10007,"@@ -130,6 +130,8 @@ const (
+ 	FrameworkTally = ""tally""
+ 	// FrameworkOpentelemetry OpenTelemetry framework id
+ 	FrameworkOpentelemetry = ""opentelemetry""
++	// FrameworkCustom Custom framework id
++	FrameworkCustom = ""custom""
+ )
+ 
+ // tally sanitizer options that satisfy both Prometheus and M3 restrictions.",I wouldn't add this. Just completely ignore config if custom reporter is not `nil` in server options.,nit: should this be `Custom`?
+10008,"@@ -159,10 +159,19 @@ int main(int argc, char *argv[]) {
+ 
+     auto ioThreadPool = std::make_shared<folly::IOThreadPoolExecutor>(FLAGS_num_io_threads);
+ 
++    std::string clusteridFile =
++        folly::stringPrintf(""%s/%s"", paths[0].c_str(), ""/storage.cluster.id"");
++    auto clusterMan
++        = std::make_unique<nebula::meta::ClusterManager>("""", clusteridFile);
++    if (!clusterMan->loadClusterId()) {
++        LOG(INFO) << ""storaged misses clusterId"";
++    }
++
+     // Meta client
+     auto metaClient = std::make_unique<nebula::meta::MetaClient>(ioThreadPool,
+                                                                  std::move(metaAddrsRet.value()),
+                                                                  localhost,
++                                                                 clusterMan.get(),
+                                                                  true);
+     if (!metaClient->waitForMetadReady()) {
+         LOG(ERROR) << ""waitForMetadReady error!"";",What's the meaning about the code?,why do we need to load the cluster id here?
+10009,"@@ -172,7 +172,7 @@ public class WebViewLocalServer {
+       return null;
+     }
+ 
+-    if (isLocalFile(loadingUrl) || (bridge.getConfig().getString(""server.url"") == null && !bridge.getAppAllowNavigationMask().matches(loadingUrl.getHost()))) {
++    if (isLocalFile(loadingUrl) || loadingUrl.getHost().contains(bridge.getHost()) || (bridge.getServerUrl() == null && !bridge.getAppAllowNavigationMask().matches(loadingUrl.getHost()))) {
+       Logger.debug(""Handling local request: "" + request.getUrl().toString());
+       return handleLocalRequest(request, handler);
+     } else {","Would this incorrectly trigger if `loadingUrl.getHost() = ""something.app""` and `bridge.getHost() = ""app""`?",Why is this change needed?
+10010,"@@ -23,7 +23,11 @@ class AnchorHead(BaseDenseHead, BBoxTestMixin):
+         anchor_generator (dict): Config dict for anchor generator
+         bbox_coder (dict): Config of bounding box coder.
+         reg_decoded_bbox (bool): If true, the regression loss would be
+-            applied on decoded bounding boxes. Default: False
++            applied directly on decoded bounding boxes, meaning both the
++            predicted boxes and regression targets are with absolute
++            coordinates format. Default False. Note generally it should be
++            set to `True` when using `IoULoss`, `GIoULoss`, or `DIoULoss`
++            in the bbox head.
+         loss_cls (dict): Config of classification loss.
+         loss_bbox (dict): Config of localization loss.
+         train_cfg (dict): Training config of anchor head.",Note generally it -> It,I don't think this is the right way to do i
+10011,"@@ -81,8 +81,7 @@ public abstract class ConfigSetService {
+               ) ? false: true;
+ 
+       SolrConfig solrConfig = createSolrConfig(dcore, coreLoader, trusted);
+-      IndexSchema indexSchema = createIndexSchema(dcore, solrConfig, false);
+-      return new ConfigSet(configSetName(dcore), solrConfig, force -> indexSchema, properties, trusted);
++      return new ConfigSet(configSetName(dcore), solrConfig, force -> createIndexSchema(dcore, solrConfig, force), properties, trusted);
+     } catch (Exception e) {
+       throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
+           ""Could not load conf for core "" + dcore.getName() +",Does this mean that every call to `configSet.getIndexSchema()` will create a new schema object (if shared schema is not enabled)?,Why is this change needed?
+10012,"@@ -1,12 +1,11 @@
+ /*
+- * Licensed to the Apache Software Foundation (ASF) under one or more
+- * contributor license agreements.  See the NOTICE file distributed with
+- * this work for additional information regarding copyright ownership.
+- * The ASF licenses this file to You under the Apache License, Version 2.0
+- * (the ""License""); you may not use this file except in compliance with
+- * the License.  You may obtain a copy of the License at
++ * Copyright 2017 Huawei Technologies Co., Ltd
+  *
+- *     http://www.apache.org/licenses/LICENSE-2.0
++ * Licensed under the Apache License, Version 2.0 (the ""License"");
++ * you may not use this file except in compliance with the License.
++ * You may obtain a copy of the License at
++ *
++ * http://www.apache.org/licenses/LICENSE-2.0
+  *
+  * Unless required by applicable law or agreed to in writing, software
+  * distributed under the License is distributed on an ""AS IS"" BASIS,",License header should use the Apache one.,Why did you change the copyright year?
+10013,"@@ -107,6 +107,8 @@ func (globber *Globber) Glob(rootPath string, includes, excludes []string, inclu
+ 		matches, err := globber.glob(rootPath, include, excludes, includeHidden, includeSymlinks)
+ 		if err != nil {
+ 			panic(fmt.Errorf(""error globbing files with %v: %v"", include, err))
++		} else if len(matches) == 0 {
++			panic(fmt.Errorf(""No matches found for this glob""))
+ 		}
+ 		// Remove the root path from the returned files and add them to the output
+ 		for _, filename := range matches {","I think this makes more sense to be applied within the parser code where we evaluate the `glob` builtin? This function looks generic in the sense of where it can be used, and perhaps no matches is fine in other cases?",I think this should be `if len(matches
+10014,"@@ -226,6 +226,14 @@ func NewConfig(ec2client ec2.EC2MetadataClient) (*Config, error) {
+ 	}
+ 	config := &envConfig
+ 
++	if config.OnPrem.Enabled() {
++		if config.AWSRegion == """" {
++			return nil, errors.New(""AWS_DEFAULT_REGION has to be set when running on-premises"")
++		}
++		// Use fake ec2 metadata client if on prem config is set.
++		ec2client = ec2.NewBlackholeEC2MetadataClient()
++	}
++
+ 	if config.complete() {
+ 		// No need to do file / network IO
+ 		return config, nil",should we validate that AWSRegion has also been set here so that we don't get into the if-block that relies on the ec2 metadata client below?,Why do we need this?
+10015,"@@ -89,11 +89,13 @@ class ThriftRequestHandler():
+                  checker_md_docs,
+                  checker_md_docs_map,
+                  suppress_handler,
+-                 db_version_info):
++                 db_version_info,
++                 version):
+ 
+         self.__checker_md_docs = checker_md_docs
+         self.__checker_doc_map = checker_md_docs_map
+         self.__suppress_handler = suppress_handler
++        self.__version = version
+         self.__session = session
+ 
+     def __queryReport(self, reportId):",maybe naming `version` to `package_version` or something similar can be more descriptive,I think this should be `db_version_inf
+10016,"@@ -235,7 +235,7 @@ class MessageTypeToType extends ParquetTypeVisitor<Type> {
+     return current;
+   }
+ 
+-  private int getId(org.apache.parquet.schema.Type type) {
++  protected int getId(org.apache.parquet.schema.Type type) {
+     org.apache.parquet.schema.Type.ID id = type.getId();
+     if (id != null) {
+       return id.intValue();",Why was this changed?,Why is this change needed?
+10017,"@@ -1,3 +1,4 @@
++//go:build !arm64
+ // +build !arm64
+ 
+ package nodeps","Should not have snuck in here right? This is a golang 1.17 feature, wii definitely want to update these",// +build !arm64
+10018,"@@ -1,10 +1,10 @@
+ module OrgAdmin
+   class PlansController < ApplicationController
+-    after_action :verify_authorized
+-
++    # GET org_admin/plans
+     def index
+-      authorize Plan
+-    
++      # Test auth directly and throw Pundit error sincePundit is unaware of namespacing
++      raise Pundit::NotAuthorizedError unless current_user.present? && current_user.can_org_admin?
++      
+       vals = Role.access_values_for(:reviewer)
+       @feedback_plans = Plan.joins(:roles).where('roles.user_id = ? and roles.access IN (?)', current_user.id, vals)
+       @plans = current_user.org.plans","Pundit is unaware of namespacing, however you can still create the class under policies/org_admin/plans_policy.rb. That means, the condition for the unless can be reused in other places too. You would call the policy as OrgAdmin::PlansPolicy.new(current_user).index? after that unless",I think this should be `cu
+10019,"@@ -203,6 +203,13 @@ public class PMD {
+             return 0;
+         }
+ 
++        // Log warning only once, if not explicitly disabled
++        if (!configuration.isIgnoreIncrementalAnalysis() && LOG.isLoggable(Level.WARNING)) {
++            final String version = PMDVersion.isUnknown() || PMDVersion.isSnapshot() ? ""latest"" : ""pmd-"" + PMDVersion.VERSION;
++            LOG.warning(""This analysis could be faster, please consider using Incremental Analysis: ""
++                                + ""https://pmd.github.io/"" + version + ""/pmd_userdocs_getting_started.html#incremental-analysis"");
++        }
++
+         Set<Language> languages = getApplicableLanguages(configuration, ruleSets);
+         List<DataSource> files = getApplicableFiles(configuration, languages);
+ ",this warning shouldn't be produced if we configured a cache either,I think this should be `LO
+10020,"@@ -16,6 +16,7 @@ describe('examples(change-stream):', function() {
+     client = await this.configuration.newClient().connect();
+     db = client.db(this.configuration.db);
+ 
++    await db.createCollection('inventory');
+     await db.collection('inventory').deleteMany({});
+   });
+ ",what if the collection is already there?,Why is this needed?
+10021,"@@ -24,8 +24,7 @@ import java.io.OutputStream;
+ import java.util.Base64;
+ 
+ /**
+- * Defines the output type for a screenshot. See org.openqa.selenium.Screenshot for usage and
+- * examples.
++ * Defines the output type for a screenshot.
+  *
+  * @see TakesScreenshot
+  * @param <T> Type for the screenshot output.",instead of removing can you reference org.openqa.selenium.TakesScreenshot ?,I don't think we sh
+10022,"@@ -644,4 +644,6 @@ public class FeedItemlistFragment extends Fragment implements AdapterView.OnItem
+             }
+         }
+     }
++
++
+ }",Please revert unrelated changes,} else {
+10023,"@@ -1224,6 +1224,11 @@ var AppRouter = Backbone.Router.extend({
+             path: [countlyGlobal.cdn + 'localization/min/'],
+             mode: 'map',
+             callback: function() {
++                if (countlyGlobal.company) {
++                    for (var key in jQuery.i18n.map) {
++                        jQuery.i18n.map[key] = jQuery.i18n.map[key].replace(""Countly"", countlyGlobal.company);
++                    }
++                }
+                 self.origLang = JSON.stringify(jQuery.i18n.map);
+             }
+         });","As far as I know, this will replace only first occurance of Countly, not others, if there are more than one Countly word in localized string",Why do we need this
+10024,"@@ -111,9 +111,9 @@ public class LocalRepository implements Repository {
+ 
+                     if (StringUtils.isBlank(jsonTypeDTO.getId())) {
+                         if (!StringUtils.isBlank(jsonTypeDTO.getName())) {
+-                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9]"", """"));
++                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9_]"", """"));
+                         } else {
+-                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9]"", """"));
++                            typeDTOBuilder.withId(jsonTypeDTO.getName().replaceAll(""[^a-zA-Z0-9_]"", """"));
+                         }
+                     }
+ ","I suggest, that we move the regex (`[^a-zA-Z0-9_]`) to a separate constant field, because we're using it in multiple places and I think it's quite prone to misspellings.",Why is this needed?
+10025,"@@ -1,7 +1,7 @@
+ import logging
+ import time
+ from collections import OrderedDict, defaultdict
+-from typing import Iterable, Optional
++from typing import Dict, Iterable, List, Optional, Union
+ 
+ from dagster import check
+ from dagster.core.definitions.events import AssetKey","Feel free to disregard, but I've been trying to use `Mapping` and `Sequence` instead of `Dict` and `List` when possible, because they communicate that the type is immutable, and also are covariant.",Why do we need this
+10026,"@@ -27,6 +27,9 @@ import (
+ 	""testing""
+ 	""time""
+ 
++	""github.com/nats-io/jwt/v2""
++	""github.com/nats-io/nkeys""
++
+ 	""github.com/nats-io/nats.go""
+ )
+ ",No need for blank line here. This block will then be reordered alphabatically.,nit: remove empty l
+10027,"@@ -5,9 +5,14 @@ import (
+ 	""fmt""
+ 
+ 	k8s ""k8s.io/client-go/kubernetes""
++	""k8s.io/client-go/rest""
+ 	""k8s.io/client-go/tools/clientcmd""
+ )
+ 
++const (
++	localCluster = ""local""
++)
++
+ type ClientsetManager interface {
+ 	Clientsets() map[string]ContextClientset
+ 	GetK8sClientset(clientset, cluster, namespace string) (ContextClientset, error)",let's call it `in-cluster` instead of `local`. less chance of confusion.,Why do we need this
+10028,"@@ -95,6 +95,8 @@ class Product extends BaseAction implements EventSubscriberInterface
+             $con->beginTransaction();
+ 
+             try {
++                $prev_ref = $product->getRef();
++
+                 $product
+                     ->setDispatcher($event->getDispatcher())
+                     ->setRef($event->getRef())",Please use camelCase instead of underscore_case,Why do you need this?
+10029,"@@ -87,7 +87,8 @@ def get_contents(bucket, key, ext, *, etag, version_id, s3_client, size):
+                 s3_client=s3_client,
+                 version_id=version_id
+             )
+-            content = extract_parquet(get_bytes(obj[""Body""], compression), as_html=False)[0]
++            body, info = extract_parquet(get_bytes(obj[""Body""], compression), as_html=False)
++            content = trim_to_bytes(f""{str(info)}\n{body}"", ELASTIC_LIMIT_BYTES)
+         else:
+             content = get_plain_text(
+                 bucket,","Ideally, we'd fold the schema into an expanded system_meta, but this is a good first step.",Why do we trim the bo
+10030,"@@ -95,6 +95,7 @@ public class TableMetadataParser {
+   static final String SNAPSHOT_ID = ""snapshot-id"";
+   static final String TIMESTAMP_MS = ""timestamp-ms"";
+   static final String SNAPSHOT_LOG = ""snapshot-log"";
++  static final String FIELDS = ""fields"";
+ 
+   public static void overwrite(TableMetadata metadata, OutputFile outputFile) {
+     internalWrite(metadata, outputFile, true);",Is this used?,nit: `FIELDS` -> `FIE
+10031,"@@ -16,7 +16,7 @@
+ 
+ using System;
+ using System.Diagnostics;
+-#if NET45 || NET46
++#if NET452 || NET46
+ using System.Diagnostics.CodeAnalysis;
+ using System.Threading;
+ #endif",Should we use `#if NETFRAMEWORK` for consistency with the other projects?,Why is this needed?
+10032,"@@ -46,7 +46,12 @@ type DecodedContainerRecord struct {
+ 
+ func (d *ContianerRecordDecoder) DecodeContainerRecord(ctx context.Context, record *v1alpha1.Record) (decoded DecodedContainerRecord, err error) {
+ 	var pod v1.Pod
+-	podId, containerName := controller.ParseNamespacedNameContainer(record.Id)
++	podId, containerName, err := controller.ParseNamespacedNameContainer(record.Id)
++	if err != nil {
++		// TODO: organize the error in a better way
++		err = NewFailToFindContainer(pod.Namespace, pod.Name, containerName, err)
++		return
++	}
+ 	err = d.Client.Get(ctx, podId, &pod)
+ 	if err != nil {
+ 		// TODO: organize the error in a better way","If it parses failed, both of the `containerName` and `podId` should be the empty strings, it's non-sense to define this error, I suggest just return it.",I don't think we should return an error here.
+10033,"@@ -61,17 +61,6 @@ export default Service.extend({
+         }
+     },
+ 
+-    sendTestRequest(testApplicationId) {
+-        let url = `${API_URL}/photos/random`;
+-        let headers = {};
+-
+-        headers.Authorization = `Client-ID ${testApplicationId}`;
+-        headers['Accept-Version'] = API_VERSION;
+-
+-        return fetch(url, {headers})
+-            .then((response) => this._checkStatus(response));
+-    },
+-
+     actions: {
+         updateSearch(term) {
+             if (term === this.get('searchTerm')) {","line 26 can be removed i think > applicationId: or('config.unsplashAPI.applicationId', 'settings.unsplash.applicationId'),",Why was this removed?
+10034,"@@ -340,9 +340,9 @@ void Config::CheckParamConflict() {
+     Log::Warning(""CUDA currently requires double precision calculations."");
+     gpu_use_dp = true;
+   }
+-  // linear tree learner must be serial type and cpu device
++  // linear tree learner must be serial type and run on cpu device
+   if (linear_tree) {
+-    if (device_type == std::string(""gpu"")) {
++    if (device_type != std::string(""cpu"")) {
+       device_type = ""cpu"";
+       Log::Warning(""Linear tree learner only works with CPU."");
+     }",To generalize for possible future new enum options.,Why did you remove this check?
+10035,"@@ -877,6 +877,9 @@ def main(argv):
+             from scapy.arch.windows import route_add_loopback
+             route_add_loopback()
+ 
++        # Add SCAPY_ROOT_DIR environment variable, used for tests
++        os.environ['SCAPY_ROOT_DIR'] = os.environ.get(""PWD"", os.getcwd())
++
+     except getopt.GetoptError as msg:
+         print(""ERROR:"", msg, file=sys.stderr)
+         raise SystemExit",Shall we remove this variable at the end of UTScapy execution?,Why do we need this?
+10036,"@@ -29,6 +29,10 @@ public class ProtoModels {
+ 
+   /** Gets the interfaces for the apis in the service config. */
+   public static List<Interface> getInterfaces(Model model) {
++    if (model.getServiceConfig().getApisCount() == 0) {
++      // A valid service config was not given.
++      return model.getSymbolTable().getInterfaces().asList();
++    }
+     return model
+         .getServiceConfig()
+         .getApisList()",What is this checking for? Why is returning the list of interfaces the correct behaviour in this case?,Shouldn't we return an empty list here?
+10037,"@@ -20,6 +20,9 @@ namespace Nethermind.Blockchain
+ {
+     public interface ISyncConfig : IConfig
+     {
++        [ConfigItem(Description = ""HMB Sync."", DefaultValue = ""false"")]
++        bool HmbSync { get; set; }
++        
+         [ConfigItem(Description = ""If set to 'true' then the Fast Sync (eth/63) synchronization algorithm will be used."", DefaultValue = ""false"")]
+         bool FastSync { get; set; }
+         ",Please name it correctly as Beam ;),I think this should be `HmbSyncEnabled`
+10038,"@@ -184,9 +184,9 @@ func shouldRetryWithWait(tripper http.RoundTripper, err error, multiplier int) b
+ 	apiErr, ok := err.(*googleapi.Error)
+ 	var retry bool
+ 	switch {
+-	case !ok && tkValid:
+-		// Not a googleapi.Error and the token is still valid.
+-		return false
++	case !ok:
++		// Not a googleapi.Error. Likely a transport error.
++		retry = true
+ 	case apiErr.Code >= 500 && apiErr.Code <= 599:
+ 		retry = true
+ 	case apiErr.Code >= 429:","After chatting with Andrew, we think it's better to look for this particular error string that is causing issues (""connection reset by peer"") instead of blindly retrying on any error we don't know about.",I don't think this is correct. If the t
+10039,"@@ -25,14 +25,14 @@ namespace AutoRest.Swagger.Validation.Core
+         /// <summary>
+         /// What kind of open api document type this rule should be applied to
+         /// </summary>
+-        public virtual ServiceDefinitionDocumentType ServiceDefinitionDocumentType => ServiceDefinitionDocumentType.ARM;
++        public abstract ServiceDefinitionDocumentType ServiceDefinitionDocumentType { get; }
+ 
+         /// <summary>
+         /// When to apply the validation rule, before or after it has been merged as a part of 
+         /// its merged document as specified in the corresponding '.md' file
+         /// By default consider all rules to be applied for After only
+         /// </summary>
+-        public virtual ServiceDefinitionDocumentState ValidationRuleMergeState => ServiceDefinitionDocumentState.Composed;
++        public abstract ServiceDefinitionDocumentState ValidationRuleMergeState { get; }
+ 
+         /// <summary>
+         /// Violation category of the Rule.",any reason to not have defaults here like you had before? (ARM)?,">public abstract [](start = 8, length ="
+10040,"@@ -1,4 +1,3 @@
+-<% page_info = paginate_params(@response) %>
+ <%= tag :meta, :name => ""totalResults"", :content => @response.total %>
+-<%= tag :meta, :name => ""startIndex"", :content => (page_info.current_page == 1 ? 1 : @response.start ) %>
+-<%= tag :meta, :name => ""itemsPerPage"", :content => page_info.limit_value %>
++<%= tag :meta, :name => ""startIndex"", :content => @response.start %>
++<%= tag :meta, :name => ""itemsPerPage"", :content => @response.limit_value %>","This is a change. The old code was just wrong before, but now here (and one other machine-readable place) we expose the start index as 0 for the first item.",I'm not sure if this is the right way to do this. I think it would be better to use the `paginate_params` helper here.
+10041,"@@ -178,11 +178,11 @@ namespace RDKit {
+     };
+   } // end of SLNParse namespace
+   
+-  RWMol *SLNToMol(std::string sln,bool sanitize,int debugParse){
++  RWMol *SLNToMol(const std::string &sln,bool sanitize,int debugParse){
+     // FIX: figure out how to reset lexer state
+     yysln_debug = debugParse;
+     // strip any leading/trailing whitespace:
+-    boost::trim_if(sln,boost::is_any_of("" \t\r\n""));
++    //boost::trim_if(sln,boost::is_any_of("" \t\r\n""));
+ 
+     RWMol *res = SLNParse::toMol(sln,false,debugParse);
+     if(res){","This changes the behavior of the parser, right? Any particular reason to do this aside from the fact that you have to since the function takes a const?",Why did you remove this?
+10042,"@@ -17,5 +17,16 @@ function Portal(props) {
+  * @param {import('./internal').PreactElement} container The DOM node to continue rendering in to.
+  */
+ export function createPortal(vnode, container) {
++	// Note: We can't use Fragment here because a component that returned a Portal
++	// (e.g. `const App = () => createPortal(...)`) wouldn't work. Our diff
++	// collapses Fragments without keys that are returned directly from components
++	// into just an array and sets that as the children array of the component.
++	//
++	// We also can't use keyed Fragments here cuz it might lead to weird edge
++	// cases when toggling between two sibling portals if we use a shared keyed or
++	// lead to unnecessary re-mounts if trying to generate a new key on each call.
++	//
++	// So the simplest solution seems to be just to use an unique type for Portal
++	// to skip the Fragment collapsing logic when diffing components
+ 	return createElement(Portal, { _parentDom: container }, vnode);
+ }","Given how simple the Portal implementation is, I wonder if we should move it core... Though we'd have to export it which would be more bytes we can't crawl back...","I'm not sure this is the best way to go about it, but I'm not sure what the best way to do it is."
+10043,"@@ -348,6 +348,7 @@ Schema.prototype.clone = function() {
+   s.callQueue = this.callQueue.map(function(f) { return f; });
+   s.methods = utils.clone(this.methods);
+   s.statics = utils.clone(this.statics);
++  s.s.hooks = utils.clone(this.s.hooks);
+   return s;
+ };
+ ",The more correct way of doing this is `this.s.hooks.clone()` but either way works. Thanks for finding this :+1:,Why do we need to clone?
+10044,"@@ -123,14 +123,13 @@ func (b *ClusterNetworkPolicySpecBuilder) GetAppliedToPeer(podSelector map[strin
+ func (b *ClusterNetworkPolicySpecBuilder) AddIngress(protoc v1.Protocol,
+ 	port *int32, portName *string, endPort *int32, cidr *string,
+ 	podSelector map[string]string, nsSelector map[string]string,
+-	podSelectorMatchExp []metav1.LabelSelectorRequirement, nsSelectorMatchExp []metav1.LabelSelectorRequirement, selfNS bool,
++	podSelectorMatchExp []metav1.LabelSelectorRequirement, nsSelectorMatchExp []metav1.LabelSelectorRequirement, selfNS string,
+ 	ruleAppliedToSpecs []ACNPAppliedToSpec, action crdv1alpha1.RuleAction, ruleClusterGroup, name string) *ClusterNetworkPolicySpecBuilder {
+ 
+ 	var pSel *metav1.LabelSelector
+ 	var nSel *metav1.LabelSelector
+ 	var ns *crdv1alpha1.PeerNamespaces
+ 	var appliedTos []crdv1alpha1.NetworkPolicyPeer
+-	matchSelf := crdv1alpha1.NamespaceMatchSelf
+ 
+ 	if b.Spec.Ingress == nil {
+ 		b.Spec.Ingress = []crdv1alpha1.Rule{}",Can we update bool to an enum instead of a string? This helps future extensibility,`selfNS` is not used in this function.
+10045,"@@ -8,6 +8,13 @@ module Ncr
+ 
+   EXPENSE_TYPES = %w(BA60 BA61 BA80)
+   BUILDING_NUMBERS = YAML.load_file(""#{Rails.root}/config/data/ncr/building_numbers.yml"")
++  FY16 = Time.zone.parse('2015-10-01')
++  if Time.zone.now > FY16
++    MAX_AMOUNT = 3500.0
++  else
++    MAX_AMOUNT = 3000.0
++  end
++  MIN_AMOUNT = 0.0
+ 
+   class WorkOrder < ActiveRecord::Base
+     include ValueHelper","Should we share, since this is also being used with gsa18f?",Layout/EmptyLinesAroundClassBody: Extr
+10046,"@@ -1835,7 +1835,7 @@ window.CrashgroupView = countlyView.extend({
+         // `d` is the original data object for the row
+         var str = '';
+         if (data) {
+-            str += '<div class=""datatablesubrow"">' +
++            str += '<div id=""crash-data-subrow"" class=""datatablesubrow"">' +
+                    '<div class=""error_menu"">' +
+                     '<div class=""error-details-menu"" data-id=""' + data._id + '"">' +
+                         '<a class=""right icon-button cly-button-menu-trigger""></a>' +","There can be multiple subrows, so it is not a good idea to use `id` there, as id should identify single unique element. Instead you could just add the id of whole table or of whole crash plugin view",I think this should be `data-crash-dat
+10047,"@@ -284,7 +284,6 @@ class TestAnalyze(unittest.TestCase):
+         # We expect a failure archive to be in the failed directory.
+         failed_files = os.listdir(failed_dir)
+         self.assertEquals(len(failed_files), 1)
+-        self.assertIn(""failure.c"", failed_files[0])
+ 
+         fail_zip = os.path.join(failed_dir, failed_files[0])
+ ",Why was this assert removed? Shouldn't we check if the file is in the zip?,Why was this removed?
+10048,"@@ -149,13 +149,17 @@ func (cb *ControllerBuilder) Build() (*Controller, error) {
+ 	return cb.Controller, nil
+ }
+ 
+-// addSpc is the add event handler for spc.
++// addSpc is the add event handler for spc
+ func (c *Controller) addSpc(obj interface{}) {
+ 	spc, ok := obj.(*apis.StoragePoolClaim)
+ 	if !ok {
+ 		runtime.HandleError(fmt.Errorf(""Couldn't get spc object %#v"", obj))
+ 		return
+ 	}
++	if spc.Labels[string(apis.OpenEBSUpgradeKey)] == ""true"" {
++		glog.Infof(""spc %s is not reconciled reason upgrade value: %s"", spc.Name, spc.Labels[string(apis.OpenEBSUpgradeKey)])
++		return
++	}
+ 	glog.V(4).Infof(""Queuing SPC %s for add event"", spc.Name)
+ 	c.enqueueSpc(spc)
+ }","This logic should be handled at informer handle functions i.e. AddFunc, UpdateFunc, DeleteFunc","I don't think this is the right place for this check. If the SPC is not reconciled, it should not be added to the queue."
+10049,"@@ -39,3 +39,15 @@ type PSList struct {
+ func (c *PSList) Len() int {
+ 	return len(c.items)
+ }
++
++// IsStripePoolSpec returns true if pool spec is stripe pool or else it will
++// return false
++func IsStripePoolSpec(poolSpec *apisv1alpha1.PoolSpec) bool {
++	if len(poolSpec.RaidGroups[0].Type) != 0 {
++		if apisv1alpha1.PoolType(poolSpec.RaidGroups[0].Type) == apisv1alpha1.PoolStriped {
++			return true
++		}
++		return false
++	}
++	return apisv1alpha1.PoolType(poolSpec.PoolConfig.DefaultRaidGroupType) == apisv1alpha1.PoolStriped
++}",S1008: should use 'return <expr>' instead of 'if <expr> { return <bool> }; return <bool>' (from `gosimple`),nit: `return len(poolSpec.RaidGroups) == 1`
+10050,"@@ -22,9 +22,15 @@ import (
+ )
+ 
+ func TestProcessIssueEvent(t *testing.T) {
++	const (
++		defaultTitle = ""foo: bar""
++	)
++
+ 	tests := []struct {
+ 		description string
+ 		action      string
++		title           string // defaults to defaultTitle
++		prevTitle string
+ 		labels      []string
+ 		want        *issueEdits
+ 	}{","Just to remove branching, use `defaultTitle` explicitly in the test cases. (Is this gofmt'd?)",Why do we need this?
+10051,"@@ -64,7 +64,7 @@ public class CSharpGapicSnippetsTransformer implements ModelToViewTransformer<Pr
+   private final StaticLangApiMethodTransformer apiMethodTransformer =
+       new CSharpApiMethodTransformer();
+   private final CSharpCommonTransformer csharpCommonTransformer = new CSharpCommonTransformer();
+-  private final SampleTransformer sampleTransformer = new SampleTransformer(SampleType.IN_CODE);
++  private final SampleTransformer sampleTransformer = SampleTransformer.create(SampleType.IN_CODE);
+   private final InitCodeTransformer initCodeTransformer = new InitCodeTransformer();
+ 
+   public CSharpGapicSnippetsTransformer(GapicCodePathMapper pathMapper) {",I don't think you use this variable anywhere. (You call `SampleTransformer.newBuilder()` below),Why is this change needed?
+10052,"@@ -54,6 +54,18 @@ char *chirp_wrap_whoami(const char *hostname, time_t stoptime)
+ 	return xxstrdup(id);
+ }
+ 
++char *chirp_wrap_hash(const char *hostname, const char *path, const char *algorithm, time_t stoptime) {
++	int result;
++	unsigned char digest[CHIRP_DIGEST_MAX];
++
++	result = chirp_reli_hash(hostname, path, algorithm, digest, stoptime);
++
++	if(result < 0)
++		return NULL;
++
++	return xxstrdup( (char *) digest);
++}
++
+ int64_t chirp_wrap_job_create (const char *host, const char *json, time_t stoptime)
+ {
+ 	chirp_jobid_t id;",The digest is in binary and variable size (the digest size is result if > 0). So we can't use xxstrdup.,Shouldn't this be `return xxstrdup( digest );`?
+10053,"@@ -25,6 +25,9 @@ public interface Span extends AutoCloseable, TraceContext {
+   Span setAttribute(String key, Number value);
+   Span setAttribute(String key, String value);
+ 
++  Span addEvent(String name);
++  Span addEvent(String name, long timestamp);
++
+   Span setStatus(Status status);
+ 
+   @Override",We don't need this additional method.,Why do we need these methods?
+10054,"@@ -44,4 +44,5 @@ type ClientConfig interface {
+ 	// have already been started.
+ 	GetUnaryOutbound() UnaryOutbound
+ 	GetOnewayOutbound() OnewayOutbound
++	GetStreamOutbound() StreamOutbound
+ }","We can't do this. Adding a method to an interface is a breaking change. This was an oversight on our part when we converted ClientConfig from a struct to an interface. OutboundConfig was introduced to fix this, the idea being that we should use OutboundConfig everywhere instead of ClientConfig. In case of Dispatcher, we want to use the OutboundConfig and MustOutboundConfig methods instead of ClientConfig, and for streaming, the client needs to attempt to upcast a ClientConfig to OutboundConfig and error out if that's not possible.",Why do we need this?
+10055,"@@ -32,7 +32,9 @@ namespace domain {
+ DomainParticipant::DomainParticipant(
+         uint32_t did)
+     : dds::core::Reference<detail::DomainParticipant>(
+-        eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->create_participant(did))
++        eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->create_participant(
++                did,
++                eprosima::fastdds::dds::DomainParticipantFactory::get_instance()->get_default_participant_qos()))
+ {
+ }
+ ",Why not using the constant `PARTICIPANT_QOS_DEFAULT` here?,Why do we need the default QoS here?
+10056,"@@ -29,7 +29,8 @@ from pkg_resources import resource_stream
+ def getScalarMetricWithTimeOfDayAnomalyParams(metricData,
+                                               minVal=None,
+                                               maxVal=None,
+-                                              minResolution=None):
++                                              minResolution=None,
++                                              tmImplementation = ""cpp""):
+   """"""
+     Return a dict that can be used to create an anomaly model via OPF's
+     ModelFactory.","Shouldn't this be `tm_cpp` to match `temporalImp`? (There are multiple CPP implementations, so 'cpp' is ambiguous.)",I think this should be `tmImplementation=None`
+10057,"@@ -30,7 +30,18 @@ module RSpec
+       # @param line [String] current code line
+       # @return [String] relative path to line
+       def self.relative_path(line)
+-        line = line.sub(File.expand_path("".""), ""."")
++        # Matches strings either at the beginning of the input or prefixed with a whitespace,
++        # containing the current path, either postfixed with the separator, or at the end of the string.
++        # Match groups are the character before and the character after the string if any.
++        #
++        # http://rubular.com/r/fT0gmX6VJX
++        # http://rubular.com/r/duOrD4i3wb
++        # http://rubular.com/r/sbAMHFrOx1
++        #
++
++        regex = /(\A|\s)#{File.expand_path('.')}(#{File::SEPARATOR}|\s|\Z)/
++
++        line = line.sub(regex, ""\\1.\\2"")
+         line = line.sub(/\A([^:]+:\d+)$/, '\\1')
+         return nil if line == '-e:1'
+         line",Need to remove this empty line for rubocop to be happy.,I don't think you need the `File::SEPARATOR` h
+10058,"@@ -63,9 +63,9 @@ func newController(objects ...runtime.Object) (*fake.Clientset, *networkPolicyCo
+ 	addressGroupStore := store.NewAddressGroupStore()
+ 	internalNetworkPolicyStore := store.NewNetworkPolicyStore()
+ 	npController := NewNetworkPolicyController(client, informerFactory.Core().V1().Pods(), informerFactory.Core().V1().Namespaces(), informerFactory.Networking().V1().NetworkPolicies(), addressGroupStore, appliedToGroupStore, internalNetworkPolicyStore)
+-	npController.podListerSynced = alwaysReady
+-	npController.namespaceListerSynced = alwaysReady
+-	npController.networkPolicyListerSynced = alwaysReady
++	//npController.podListerSynced = alwaysReady
++	//npController.namespaceListerSynced = alwaysReady
++	//npController.networkPolicyListerSynced = alwaysReady
+ 	return client, &networkPolicyController{
+ 		npController,
+ 		informerFactory.Core().V1().Pods().Informer().GetStore(),","just checking: do we need to remove this because otherwise the `List` operations may not return the entire set of Pods / Namespaces? do you know why we used `alwaysReady` in the first place, I can't remember?",Why is this disabled?
+10059,"@@ -439,10 +439,14 @@ function createTopology(mongoClient, topologyType, options, callback) {
+     }
+ 
+     const MongoClient = loadClient();
+-    const connectionString =
+-      os.platform() === 'win32'
+-        ? 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000'
+-        : 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    let connectionString;
++    if (mongoClient.s.options.autoEncryption.cryptdConnectionString != null) {
++      connectionString = mongoClient.s.options.autoEncryption.cryptdConnectionString;
++    } else if (os.platform() === 'win32') {
++      connectionString = 'mongodb://localhost:27020/?serverSelectionTimeoutMS=1000';
++    } else {
++      connectionString = 'mongodb://%2Ftmp%2Fmongocryptd.sock/?serverSelectionTimeoutMS=1000';
++    }
+ 
+     const mongocryptdClient = new MongoClient(connectionString, { useUnifiedTopology: true });
+     mongocryptdClient.connect(err => {",maybe we can replace `mongoClient.s.options.autoEncryption.cryptdConnectionString` with `options.autoEncryption.cryptdConnectionString`?,Why do we need this check?
+10060,"@@ -3719,9 +3719,11 @@ dr_create_client_thread(void (*func)(void *param), void *arg)
+ #        endif
+     LOG(THREAD, LOG_ALL, 1, ""dr_create_client_thread xsp="" PFX "" dstack="" PFX ""\n"", xsp,
+         get_clone_record_dstack(crec));
++    os_clone_pre(dcontext);
+     thread_id_t newpid =
+         dynamorio_clone(flags, xsp, NULL, IF_X86_ELSE(IF_X64_ELSE(NULL, &desc), NULL),
+                         NULL, client_thread_run);
++    os_clone_post(dcontext);
+     /* i#501 switch to app's tls before creating client thread */
+     if (IF_CLIENT_INTERFACE_ELSE(INTERNAL_OPTION(private_loader), false))
+         os_switch_lib_tls(dcontext, false /*to dr*/);","But we're already doing os_switch_lib_tls to app a few lines above, so there is now redundancy we should alleviate.",Why do we need to call os_clone_post here?
+10061,"@@ -52,10 +52,11 @@ namespace Datadog.Trace
+         /// <param name=""parent"">The parent context.</param>
+         /// <param name=""traceContext"">The trace context.</param>
+         /// <param name=""serviceName"">The service name to propagate to child spans.</param>
+-        internal SpanContext(ISpanContext parent, ITraceContext traceContext, string serviceName)
++        /// <param name=""spanId"">The propagated span id.</param>
++        internal SpanContext(ISpanContext parent, ITraceContext traceContext, string serviceName, ulong? spanId = null)
+             : this(parent?.TraceId, serviceName)
+         {
+-            SpanId = SpanIdGenerator.ThreadInstance.CreateNew();
++            SpanId = spanId ?? SpanIdGenerator.ThreadInstance.CreateNew();
+             Parent = parent;
+             TraceContext = traceContext;
+             if (parent is SpanContext spanContext)",Under what circumstance would we have a span id already? Is this for testing purposes?,Why do we need this change?
+10062,"@@ -2986,7 +2986,8 @@ static bool PreCallValidateQueueSubmit(layer_data *dev_data, VkQueue queue, uint
+                     skip |= log_msg(dev_data->report_data, VK_DEBUG_REPORT_ERROR_BIT_EXT, VK_DEBUG_REPORT_OBJECT_TYPE_SEMAPHORE_EXT,
+                                     HandleToUint64(semaphore), kVUID_Core_DrawState_QueueForwardProgress,
+                                     ""Queue 0x%"" PRIx64 "" is signaling semaphore 0x%"" PRIx64
+-                                    "" that has already been signaled but not waited on by queue 0x%"" PRIx64 ""."",
++                                    "" that was previously signaled by queue 0x%"" PRIx64
++                                    "" but has not since been waited on by any queue."",
+                                     HandleToUint64(queue), HandleToUint64(semaphore), HandleToUint64(pSemaphore->signaler.first));
+                 } else {
+                     unsignaled_semaphores.erase(semaphore);","The original text can be read to say ""not waited on by queue ..."" meaing that the second queue was supposed to have *waited* for the signal... which is especially confusing when it's the same queue that has signalled the semaphore *twice* without a wait.",I don't think this is correct. If the sema
+10063,"@@ -136,8 +136,8 @@ func (le *LookupEngine) Lookup(ctx context.Context, a types.Address) (peer.ID, e
+ 	case out := <-ch:
+ 		return out.(peer.ID), nil
+ 	case <-time.After(time.Second * 10):
+-		return """", fmt.Errorf(""timed out waiting for response"")
++		return """", fmt.Errorf(""lookup timed out waiting for response"")
+ 	case <-ctx.Done():
+-		return """", fmt.Errorf(""context cancled"")
++		return """", fmt.Errorf(""lookup failed: context cancled"")
+ 	}
+ }",just clarifying the error messages a bit.,"""lookup timed out waiting for response"""
+10064,"@@ -0,0 +1,18 @@
++// <copyright file=""TelemetryRequestTypes.cs"" company=""Datadog"">
++// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
++// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
++// </copyright>
++
++namespace Datadog.Trace.Telemetry
++{
++    internal static class TelemetryRequestTypes
++    {
++        public const string AppStarted = ""app-started"";
++        public const string AppDependenciesLoaded = ""app-dependencies-loaded"";
++        public const string AppIntegrationsChanged = ""app-integrations-change"";
++        public const string AppHeartbeat = ""app-heartbeat"";
++        public const string AppClosing = ""app-closing"";
++
++        public const string GenerateMetrics = ""generate-metrics"";
++    }
++}",Have those (and other data like conf...) shared across tracers?,I think this should be `app-integrations-changed`
+10065,"@@ -0,0 +1,17 @@
++// +build !windows
++
++// Copyright 2020 Antrea Authors
++//
++// Licensed under the Apache License, Version 2.0 (the ""License"");
++// you may not use this file except in compliance with the License.
++// You may obtain a copy of the License at
++//
++//     http://www.apache.org/licenses/LICENSE-2.0
++//
++// Unless required by applicable law or agreed to in writing, software
++// distributed under the License is distributed on an ""AS IS"" BASIS,
++// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
++// See the License for the specific language governing permissions and
++// limitations under the License.
++
++package lib",could we add this file only when we need one?,Why do we need this file?
+10066,"@@ -37,4 +37,7 @@ type Context struct {
+ 	// ACMEHTTP01SolverImage is the image to use for solving ACME HTTP01
+ 	// challenges
+ 	ACMEHTTP01SolverImage string
++	// acmeDNS01ResolvConfFile is an optional custom resolv.conf file for
++	// solve ACME DNS01 challenges
++	ACMEDNS01ResolvConfFile string
+ }",This may not even be needed.,nit: missing period at the end of the sentence
+10067,"@@ -70,6 +70,12 @@ var KnownFields = map[string]bool{
+ 	""Test.Flakiness"": true,
+ 	""Test.Results"":   true, // Recall that unsuccessful test results aren't cached...
+ 
++	// Debug fields don't contribute to any hash
++	""Debug"":            true,
++	""Debug.Command"":    true,
++	""Debug.tools"":      true,
++	""Debug.namedTools"": true,
++
+ 	// These only contribute to the runtime hash, not at build time.
+ 	""Data"":              true,
+ 	""namedData"":         true,",Capitalisation seems inconsistent here?,I don't think we should be concerned about this. 
+10068,"@@ -1,7 +1,11 @@
+-namespace Nevermind.Core
++using System;
++
++namespace Nevermind.Core
+ {
+     public interface ILogger
+     {
+         void Log(string text);
++        void Debug(string text);
++        void Error(string text, Exception ex = null);
+     }
+ }",maybe better Error(string text) and Error(Exception ex) separately?,Why is this needed?
+10069,"@@ -58,7 +58,7 @@ func matchingTools(config *core.Configuration, prefix string) map[string]string
+ 		""jarcat"":      config.Java.JarCatTool,
+ 		""javacworker"": config.Java.JavacWorker,
+ 		""junitrunner"": config.Java.JUnitRunner,
+-		""langserver"":  path.Join(config.Please.Location, ""build_langserver""),
++		""lps"":  	   path.Join(config.Please.Location, ""build_langserver""),
+ 		""maven"":       config.Java.PleaseMavenTool,
+ 		""pex"":         config.Python.PexTool,
+ 	}","can you leave the old one in too please? at least for now, otherwise anyone using it now will break.",Why did you change 
+10070,"@@ -3501,6 +3501,10 @@ void Player::onAttackedCreature(Creature* target)
+ {
+ 	Creature::onAttackedCreature(target);
+ 
++	if (target && target->getZone() == ZONE_PVP) {
++		return;
++	}
++	
+ 	if (target == this) {
+ 		addInFightTicks();
+ 		return;","Trailing tab, remove it in another PR.",why is this needed?
+10071,"@@ -156,6 +156,9 @@ func (w *taskWriter) allocTaskIDs(count int) ([]int64, error) {
+ 		if w.taskIDBlock.start > w.taskIDBlock.end {
+ 			// we ran out of current allocation block
+ 			newBlock, err := w.tlMgr.allocTaskIDBlock(w.taskIDBlock.end)
++			if err != nil && w.tlMgr.errShouldUnload(err) {
++				w.tlMgr.signalFatalProblem(w.tlMgr.taskQueueID)
++			}
+ 			if err != nil {
+ 				return nil, err
+ 			}",what about merging the error checking logic to within `errShouldUnload`?,Why do we need to s
+10072,"@@ -0,0 +1,6 @@
++class ArticlesController < ApplicationController
++  def index
++    @topic = Topic.find_by_slug(params[:id])
++    @articles = @topic.articles.by_published
++  end
++end",Probably want Topic.find_by_slug! to handle bogus topics. The next line will try to load articles off of nil otherwise.,I think this should be `@articles = topic.articles.published`
+10073,"@@ -34,6 +34,11 @@ public:
+     static constexpr std::int64_t column_count = 2;
+     static constexpr std::int64_t element_count = row_count * column_count;
+ 
++    bool not_available_on_device() {
++        constexpr bool is_svd = std::is_same_v<Method, pca::method::svd>;
++        return get_policy().is_gpu() && is_svd;
++    }
++
+     auto get_descriptor() const {
+         return pca::descriptor<float, Method, pca::task::dim_reduction>{};
+     }",Should it really be done on test side?,I think it would be better to use `is_same_v` here.
+10074,"@@ -350,7 +350,8 @@ func (mtask *managedTask) steadyState() bool {
+ 	}
+ }
+ 
+-// cleanupCredentials removes credentials for a stopped task
++// cleanupCredentials removes credentials for a stopped task (execution credentials are removed in cleanupTask
++// due to its potential usage in the later phase of the task cleanup such as sending logs)
+ func (mtask *managedTask) cleanupCredentials() {
+ 	taskCredentialsID := mtask.GetCredentialsID()
+ 	if taskCredentialsID != """" {","Can we elaborate on why? I'm guessing because we need the execution role to call FE stopTask during `cleanupTask`, but would be good if we make it clear here.",I'm not sure if this is the right place to put this cleanup. 
+10075,"@@ -62,6 +62,10 @@ func newAgentCommand() *cobra.Command {
+ 			if err := opts.validate(args); err != nil {
+ 				klog.Fatalf(""Failed to validate: %v"", err)
+ 			}
++			// Not passing args again as they are already validated and are not used in flow exporter config
++			if err := opts.validateFlowExporterConfig(); err != nil {
++				klog.Fatalf(""Failed to validate flow exporter config: %v"", err)
++			}
+ 			if err := run(opts); err != nil {
+ 				klog.Fatalf(""Error running agent: %v"", err)
+ 			}",is there a reason why this is not called from inside `validate`?,Why do we need to pass args again?
+10076,"@@ -46,7 +46,12 @@ type clientServer struct {
+ // New returns a client/server to bidirectionally communicate with the backend.
+ // The returned struct should have both 'Connect' and 'Serve' called upon it
+ // before being used.
+-func New(url string, cfg *config.Config, credentialProvider *credentials.Credentials, statsEngine stats.Engine, publishMetricsInterval time.Duration) wsclient.ClientServer {
++func New(url string,
++	cfg *config.Config,
++	credentialProvider *credentials.Credentials,
++	statsEngine stats.Engine,
++	publishMetricsInterval time.Duration,
++	rwTimeout time.Duration) wsclient.ClientServer {
+ 	cs := &clientServer{
+ 		statsEngine:            statsEngine,
+ 		publishTicker:          nil,",:+1: I much prefer this style for functions with more than a few arguments.,nit: `rwTimeout` is unused (from `structcheck`)
+10077,"@@ -762,8 +762,7 @@ class CommandLine
+                     }
+                 }
+             }
+-
+-            if (hasQualifiers)
++            else if (hasQualifiers)
+             {
+                 sb.AppendLine().Append(""  Actions:"").AppendLine();
+ ","Are these mutually exclusive options (parameters vs qualifiers)? If parameters aren't supported, may want to consider throwing an exception for ""hasParameters"". If parameters and qualifiers are both legit options, then maybe change this to `if (hasQualifiers) { ... } if(!hasQualifiers && !hasParameters)`",Why this change?
+10078,"@@ -43,7 +43,6 @@ public class InvocationStartProcessingEventListener implements EventListener {
+     if (InvocationType.PRODUCER.equals(event.getInvocationType())) {
+       ProducerInvocationMonitor monitor = registryMonitor.getProducerInvocationMonitor(event.getOperationName());
+       monitor.getWaitInQueue().increment(-1);
+-      monitor.getLifeTimeInQueue().update(event.getInQueueNanoTime());
+     }
+   }
+ }",Why did you remove this line?,Why is this removed?
+10079,"@@ -80,6 +80,7 @@ MSG(object_does_not_provide_read_access_to_columns,
+ MSG(object_does_not_provide_write_access_to_columns,
+     ""Given object does not provide write access to columns"")
+ MSG(unsupported_conversion_types, ""Unsupported conversion types"")
++MSG(invalid_indices, ""Invalid indices"")
+ 
+ /* Ranges */
+ MSG(invalid_range_of_rows, ""Invalid range of rows"")",Very unclear error message. Remember that these are messages that your users see. Please be more specific,"MSG(invalid_index, ""Invalid index"")"
+10080,"@@ -39,6 +39,12 @@ const (
+ 	DisablePublicIP         = ""DISABLED""
+ 	PublicSubnetsPlacement  = ""PublicSubnets""
+ 	PrivateSubnetsPlacement = ""PrivateSubnets""
++
++	// RuntimePlatform configuration.
++	linuxOS = ""LINUX""
++	// windowsCoreOS = ""WINDOWS_SERVER_2019_CORE""
++	// windowsFullOS = ""WINDOWS_SERVER_2019_FULL""
++	x86Arch = ""X86_64""
+ )
+ 
+ // Constants for ARN options.",Can we add these when we need them  ,Can we remove these?
+10081,"@@ -460,12 +460,13 @@ class EDS extends DefaultRecord
+      */
+     public function getPrimaryAuthors()
+     {
+-        return array_unique(
+-            $this->extractEbscoDataFromRecordInfo(
+-                'BibRecord/BibRelationships/HasContributorRelationships/*/'
++        $authors = $this->extractEbscoDataFromRecordInfo(
++            'BibRecord/BibRelationships/HasContributorRelationships/*/'
+                 . 'PersonEntity/Name/NameFull'
+-            )
+         );
++        return array_unique(array_filter($authors, function ($a) {
++            return !empty($a);
++        }));
+     }
+ 
+     /**","I believe you can simplify this to simply `return array_unique(array_filter($authors));` -- the default behavior of array_filter is to filter out empty elements, so the callback should not be required in this situation. Do you mind giving it a try and updating the PR if it works?",Please use `!empty()
+10082,"@@ -305,6 +305,10 @@ class UIAHandler(COMObject):
+ 			return
+ 		import NVDAObjects.UIA
+ 		obj=NVDAObjects.UIA.UIA(UIAElement=sender)
++		if not obj:
++			# Sometimes notification events can be fired on a UIAElement that has no windowHandle and does not connect through parents back to the desktop.
++			# There is nothing we can do with these.
++			return
+ 		eventHandler.queueEvent(""UIA_notification"",obj, notificationKind=NotificationKind, notificationProcessing=NotificationProcessing, displayString=displayString, activityId=activityId)
+ 
+ 	def _isUIAWindowHelper(self,hwnd):",Would it make sense to log a debug warning here?,I don't think this i
+10083,"@@ -35,14 +35,6 @@ var loginCmd = &cobra.Command{
+ 				os.Exit(1)
+ 			}
+ 
+-			if err := ks.SetDefault(addr); err != nil {
+-				cmd.Printf(""Given address is not present into keystore.\r\nAvailable addresses:\r\n"")
+-				for _, addr := range ks.List() {
+-					cmd.Println(addr.Address.Hex())
+-				}
+-				return
+-			}
+-
+ 			// ask for password for default key
+ 			pass, err := accounts.NewInteractivePassPhraser().GetPassPhrase()
+ 			if err != nil {","""in the keystore"", but nevermind",Why is this removed?
+10084,"@@ -337,7 +337,7 @@ void nano::network::republish_vote (std::shared_ptr<nano::vote> vote_a)
+ void nano::network::broadcast_confirm_req (std::shared_ptr<nano::block> block_a)
+ {
+ 	auto list (std::make_shared<std::vector<nano::peer_information>> (node.peers.representatives (std::numeric_limits<size_t>::max ())));
+-	if (list->empty () || node.peers.total_weight () < node.config.online_weight_minimum.number ())
++	if (list->empty () || node.peers.total_weight () < node.delta ())
+ 	{
+ 		// broadcast request to all peers
+ 		list = std::make_shared<std::vector<nano::peer_information>> (node.peers.list_vector (100));",This should be done in a separate PR.,`node.peers.total_weight () < node.delta()`
+10085,"@@ -138,8 +138,9 @@ public class DropPartyPlugin extends Plugin
+ 			{
+ 				continue;
+ 			}
+-			if (Text.standardize(player.getName()).equalsIgnoreCase(playerName))
++			if (player.getName().equalsIgnoreCase(playerName))
+ 			{
++				log.error(""found running player"");
+ 				runningPlayer = player;
+ 				break;
+ 			}",Rather than this maybe `Text.sanitize` would be better here,Why is this change needed?
+10086,"@@ -82,7 +82,7 @@ public class NeighborsMsgSerializer : DiscoveryMsgSerializerBase, IMessageSerial
+             }
+ 
+             ReadOnlySpan<byte> id = ctx.DecodeByteArraySpan();
+-            return new Node(new PublicKey(id), address);
++            return new Node(new PublicKey(id), address, false);
+         });
+     }
+ }",lot of places setting default 'false' to static value - noise in PR,Why is this `false`?
+10087,"@@ -361,11 +361,19 @@ class Image extends BaseI18nLoop implements PropelSearchLoopInterface
+                 // Dispatch image processing event
+                 $this->dispatcher->dispatch(TheliaEvents::IMAGE_PROCESS, $event);
+ 
++                $originalImageSize = getimagesize($sourceFilePath);
++
++                $imageSize = getimagesize($event->getCacheFilepath());
++
+                 $loopResultRow
+                     ->set(""IMAGE_URL"", $event->getFileUrl())
+                     ->set(""ORIGINAL_IMAGE_URL"", $event->getOriginalFileUrl())
+                     ->set(""IMAGE_PATH"", $event->getCacheFilepath())
+                     ->set(""PROCESSING_ERROR"", false)
++                    ->set(""IMAGE_WIDH"", $imageSize[0])
++                    ->set(""IMAGE_HEIGHT"", $imageSize[1])
++                    ->set(""ORIGINAL_IMAGE_WIDH"", $originalImageSize[0])
++                    ->set(""ORIGINAL_IMAGE_HEIGHT"", $originalImageSize[1])
+                 ;
+             } catch (\Exception $ex) {
+                 // Ignore the result and log an error",I think you should use `$event->getOriginalFileUrl()` instead of `$sourceFilePath` here.,Shouldn't this be `ORIGINAL_IMAGE_WIDTH`?
+10088,"@@ -99,6 +99,7 @@ def run(inventory_index_id,
+     # pylint: disable=too-many-locals
+     global_configs = service_config.get_global_config()
+     notifier_configs = service_config.get_notifier_config()
++    api_quota_configs = notifier_configs.get('api_quota')
+ 
+     with service_config.scoped_session() as session:
+         if scanner_index_id:","nit: It's a matter of taste, but it would be tighter if this is called `api_quota`.",Why do we need this line?
+10089,"@@ -16,9 +16,10 @@ package org.hyperledger.besu.ethereum.mainnet.precompiles;
+ 
+ import static org.assertj.core.api.Assertions.assertThat;
+ 
+-import org.hyperledger.besu.ethereum.core.Gas;
+-import org.hyperledger.besu.ethereum.vm.GasCalculator;
+-import org.hyperledger.besu.ethereum.vm.MessageFrame;
++import org.hyperledger.besu.evm.Gas;
++import org.hyperledger.besu.evm.frame.MessageFrame;
++import org.hyperledger.besu.evm.gascalculator.GasCalculator;
++import org.hyperledger.besu.evm.precompile.AltBN128PairingPrecompiledContract;
+ 
+ import org.apache.tuweni.bytes.Bytes;
+ import org.junit.Test;",I noticed in all of these we now have to import the PrecompiledContract under testing. Could also rename the package these are in s/precompiles/precompile to keep them in the same package as they are elsewhere.,Why is this change needed
+10090,"@@ -288,7 +288,7 @@ class SnakebiteHdfsClient(HdfsClient):
+             client_kwargs = dict(filter(lambda (k, v): v is not None and v != '',  {
+                 'hadoop_version': self.config.getint(""hdfs"", ""client_version"", None),
+                 'effective_user': self.config.get(""hdfs"", ""effective_user"", None)
+-            }.items()))
++            }.iteritems()))
+             if self.config.getboolean(""hdfs"", ""snakebite_autoconfig"", False):
+                 """"""
+                 This is fully backwards compatible with the vanilla Client and can be used for a non HA cluster as well.",doubt this matters...,`iteritems` is not needed
+10091,"@@ -36,6 +36,7 @@ from scapy.automaton import *
+ from scapy.autorun import *
+ 
+ from scapy.main import *
++from scapy.consts import *
+ 
+ from scapy.layers.all import *
+ ","Gets updated versions of `LOOPBACK_INTERFACE`, `LOOPBACK_NAME` when importing scapy.",from scapy.layers import 
+10092,"@@ -372,7 +372,7 @@ public class SparkTableUtil {
+     try {
+       PartitionSpec spec = SparkSchemaUtil.specForTable(spark, sourceTableIdentWithDB.unquotedString());
+ 
+-      if (spec == PartitionSpec.unpartitioned()) {
++      if (Objects.equal(spec, PartitionSpec.unpartitioned())) {
+         importUnpartitionedSparkTable(spark, sourceTableIdentWithDB, targetTable);
+       } else {
+         List<SparkPartition> sourceTablePartitions = getPartitions(spark, sourceTableIdent);","checking for ref. equality is probably fine here, but it takes a reader longer to navigate the code and figure out whether ref equality is really wanted here vs just using `equals()`",nit: use `==` instead?
+10093,"@@ -60,12 +60,14 @@ type (
+ 		matchingClient           matchingservice.MatchingServiceClient
+ 		config                   *configs.Config
+ 		searchAttributesProvider searchattribute.Provider
++		workflowDeleteManager    workflow.DeleteManager
+ 	}
+ )
+ 
+ func newTransferQueueTaskExecutorBase(
+ 	shard shard.Context,
+ 	historyEngine *historyEngineImpl,
++	workflowDeleteManager workflow.DeleteManager,
+ 	logger log.Logger,
+ 	metricsClient metrics.Client,
+ 	config *configs.Config,",looks like it's not used? Do we plan to use it in the future?,nit: rename to `delete
+10094,"@@ -34,8 +34,8 @@ import (
+ )
+ 
+ type (
+-	// Config supports common options that apply to statsd exporters.
+-	Config struct {
++	// Options supports common options that apply to statsd exporters.
++	Options struct {
+ 		// URL describes the destination for exporting statsd data.
+ 		// e.g., udp://host:port
+ 		//       tcp://host:port","I think this is an unrelated remark. I thought we had moved toward the practice of using ""Config"" as the structure name, and Option as a functional argument (`func(*Config)`), and Options as a `[]Option`. See api/trace `StartConfig` and `StartOption`, for example. That's why I prefer this struct be called Config.",Why do we need to chan
+10095,"@@ -2,7 +2,8 @@ import random
+ import string
+ 
+ from kinto.core.storage import generators, exceptions
+-from pyramid import httpexceptions
++from pyramid.httpexceptions import (HTTPNotFound)
++from kinto.core.errors import http_error, ERRORS
+ 
+ 
+ class NameGenerator(generators.Generator):",nitpick: superfluous parenthesis,This should be `from k
+10096,"@@ -219,6 +219,7 @@ namespace Datadog.Trace.ClrProfiler.Integrations
+         private static void DecorateSpan(Span span, GraphQLTags tags)
+         {
+             span.Type = SpanTypes.GraphQL;
++            span.SetMetric(Tags.Measured, 1);
+         }
+ 
+         private static Scope CreateScopeFromValidate(object document)","If, for a given integration, the tag/measure is always set, it should be added to the strongly-typed tags (here for instance, in GraphQLTags). This way, the underlying dictionary is allocated only in the rare case where users add custom tags",Why do we need this?
+10097,"@@ -243,12 +243,12 @@ func ExecuteContract(
+ 	if err := stateDB.CommitContracts(); err != nil {
+ 		return nil, nil, errors.Wrap(err, ""failed to commit contracts to underlying db"")
+ 	}
+-	stateDB.clear()
+ 	receipt.AddLogs(stateDB.Logs()...).AddTransactionLogs(depositLog, burnLog)
+ 	if receipt.Status == uint64(iotextypes.ReceiptStatus_Success) ||
+ 		featureCtx.AddOutOfGasToTransactionLog && receipt.Status == uint64(iotextypes.ReceiptStatus_ErrCodeStoreOutOfGas) {
+ 		receipt.AddTransactionLogs(stateDB.TransactionLogs()...)
+ 	}
++	stateDB.clear()
+ 
+ 	if featureCtx.SetRevertMessageToReceipt && receipt.Status == uint64(iotextypes.ReceiptStatus_ErrExecutionReverted) && retval != nil && bytes.Equal(retval[:4], revertSelector) {
+ 		// in case of the execution revert error, parse the retVal and add to receipt",The position change of this line may be a hard fork.,why do we need to cl
+10098,"@@ -541,12 +541,7 @@ void Items::buildInventoryList()
+ 
+ void Items::parseItemNode(const pugi::xml_node& itemNode, uint16_t id)
+ {
+-	if (id > 30000 && id < 30100) {
+-		id -= 30000;
+-
+-		if (id >= items.size()) {
+-			items.resize(id + 1);
+-		}
++	if (id > 0 && id < 100) {
+ 		ItemType& iType = items[id];
+ 		iType.id = id;
+ 	}",id is unsigned  ,Why did you remove t
+10099,"@@ -13,6 +13,7 @@ Puppet::Functions.create_function(:run_command) do
+   # @param options A hash of additional options.
+   # @option options [Boolean] _catch_errors Whether to catch raised errors.
+   # @option options [String] _run_as User to run as using privilege escalation.
++  # @option options [Hash] _env_vars Map of environment variables to set
+   # @return A list of results, one entry per target.
+   # @example Run a command on targets
+   #   run_command('hostname', $targets, '_catch_errors' => true)",It looks like Puppet doesn't provide type validation for options and we don't provide it ourselves as part of the function. Is that something we'd want to do at some point?,`_env_vars` should b
+10100,"@@ -26,7 +26,8 @@ import org.apache.iceberg.io.CloseableIterable;
+ class StaticTableScan extends BaseTableScan {
+   private final Function<StaticTableScan, DataTask> buildTask;
+ 
+-  StaticTableScan(TableOperations ops, Table table, Schema schema, Function<StaticTableScan, DataTask> buildTask) {
++  StaticTableScan(TableOperations ops, Table table, Schema schema,
++                  Function<StaticTableScan, DataTask> buildTask) {
+     super(ops, table, schema);
+     this.buildTask = buildTask;
+   }",Looks like this didn't need to change.,Why this change?
+10101,"@@ -595,6 +595,10 @@ class PyLinter(config.OptionsManagerMixIn,
+             for msg_id in self._checker_messages('python3'):
+                 if msg_id.startswith('E'):
+                     self.enable(msg_id)
++            config_parser = self.cfgfile_parser
++            if config_parser.has_option('MESSAGES CONTROL', 'disable'):
++                value = config_parser.get('MESSAGES CONTROL', 'disable')
++                self.global_set_option('disable', value)
+         else:
+             self.disable('python3')
+         self.set_option('reports', False)",I don't understand why this is here and what's the intention with it? Can you elaborate what's the reasoning behind this change?,Why is this need
+10102,"@@ -25,13 +25,13 @@ package sqlplugin
+ import ""database/sql""
+ 
+ type (
+-	// historyShard is the SQL persistence interface for history shards
+-	historyShard interface {
++	// HistoryShard is the SQL persistence interface for history shards
++	HistoryShard interface {
+ 		InsertIntoShards(rows *ShardsRow) (sql.Result, error)
+ 		UpdateShards(row *ShardsRow) (sql.Result, error)
+ 		SelectFromShards(filter *ShardsFilter) (*ShardsRow, error)
+-		ReadLockShards(filter *ShardsFilter) (int, error)
+-		WriteLockShards(filter *ShardsFilter) (int, error)
++		ReadLockShards(filter *ShardsFilter) (int64, error)
++		WriteLockShards(filter *ShardsFilter) (int64, error)
+ 	}
+ 
+ 	// historyEvent is the SQL persistence interface for history nodes and history trees",I think @sergeybykov converted (wanted to convert) all `shardID` to `int32` from `int64`. Please check with him.,Why do we need t
+10103,"@@ -2289,7 +2289,8 @@ void ProtocolGame::sendCreatureHealth(const Creature* creature)
+ 	if (creature->isHealthHidden()) {
+ 		msg.addByte(0x00);
+ 	} else {
+-		msg.addByte(std::ceil((static_cast<double>(creature->getHealth()) / std::max<int32_t>(creature->getMaxHealth(), 1)) * 100));
++		int32_t maxHealth = std::max(creature->getMaxHealth(), 1);
++		msg.addByte(std::ceil((static_cast<double>(std::min(creature->getHealth(), maxHealth)) / maxHealth) * 100));
+ 	}
+ 	writeToOutputBuffer(msg);
+ }",This will only fix client side (so showing it in-game) server still gonna hold invalid values I guess?,`std::ceil((stat
+10104,"@@ -287,6 +287,18 @@ class Dataset(Element):
+         class to each underlying element.
+         """"""
+         if isinstance(data, DynamicMap):
++            class_name = cls.__name__
++            repr_kdims = 'kdims=%r' % kdims if kdims else None
++            repr_vdims = 'vdims=%r' % vdims if vdims else None
++            repr_kwargs = (', '.join('%s=%r' % (k,v) for k,v in kwargs.items())
++                           if kwargs else None)
++            extras = ', '.join([el for el in [repr_kdims, repr_vdims, repr_kwargs]
++                               if el is not None])
++            extras = ', ' + extras if extras else ''
++            apply_args= 'hv.{class_name}{extras}'.format(class_name=class_name,
++                                                         extras=extras)
++            msg = ""Cannot construct a {class_name} from the supplied object of type DynamicMap. Implicitly creating a DynamicMap of {class_name} objects, but instead please explicitly call .apply({apply_args}) on the supplied DynamicMap.""
++            cls.warning(cls, msg.format(class_name=class_name, apply_args=apply_args))
+             return data.apply(cls, per_element=True, kdims=kdims, vdims=vdims, **kwargs)
+         else:
+             return super(Dataset, cls).__new__(cls)",Shouldn't this be `cls.param.warning`?,nit: space after `=`
+10105,"@@ -54,7 +54,6 @@ module Selenium
+         it 'does not set the chrome.detach capability by default' do
+           Driver.new(http_client: http)
+ 
+-          expect(caps['goog:chromeOptions']).to eq({})
+           expect(caps['chrome.detach']).to be nil
+         end
+ ","This spec can be modified, giving you extra strength (Check this fetch key doesn't work and therefore returns `nil`)",Why was this removed
+10106,"@@ -107,9 +107,14 @@ class ServerConnectionMixin:
+         """"""
+         address = self.server_conn.address
+         if address:
++            forbidden_hosts = [""localhost"", ""127.0.0.1"", ""::1""]
++
++            if self.config.options.listen_host:
++                forbidden_hosts.append(self.config.options.listen_host)
++
+             self_connect = (
+                 address[1] == self.config.options.listen_port and
+-                address[0] in (""localhost"", ""127.0.0.1"", ""::1"")
++                address[0] in forbidden_hosts
+             )
+             if self_connect:
+                 raise exceptions.ProtocolException(","Could we not just always include `self.config.options.listen_host`? If that is empty, the `address[0]` check should also never be true.",This should be `forb
+10107,"@@ -102,8 +102,8 @@ public class DataFilesTable extends BaseMetadataTable {
+     }
+ 
+     @Override
+-    protected long targetSplitSize(TableOperations ops) {
+-      return ops.current().propertyAsLong(
++    public long targetSplitSize() {
++      return tableOps().current().propertyAsLong(
+           TableProperties.METADATA_SPLIT_SIZE, TableProperties.METADATA_SPLIT_SIZE_DEFAULT);
+     }
+ ",Why not just access `ops` directly like before?,nit: `tableOps().cur
+10108,"@@ -389,17 +389,13 @@ void Creature::onRemoveTileItem(const Tile* tile, const Position& pos, const Ite
+ 	}
+ }
+ 
+-void Creature::onCreatureAppear(Creature* creature, bool isLogin)
++void Creature::onCreatureAppear(Creature* creature, bool)
+ {
+ 	if (creature == this) {
+ 		if (useCacheMap()) {
+ 			isMapLoaded = true;
+ 			updateMapCache();
+ 		}
+-
+-		if (isLogin) {
+-			setLastPosition(getPosition());
+-		}
+ 	} else if (isMapLoaded) {
+ 		if (creature->getPosition().z == getPosition().z) {
+ 			updateTileCache(creature->getTile(), creature->getPosition());",Is there even a need to keep the bool?,why did you remove this?
+10109,"@@ -42,7 +42,7 @@ class HotgymRegressionTest(unittest.TestCase):
+ 
+   def testHotgymRegression(self):
+     experimentDir = os.path.join(
+-      os.path.dirname(__file__).partition(""tests/integration/nupic/opf"")[0],
++      os.path.dirname(__file__).partition(os.path.normpath(""tests/integration/nupic/opf""))[0],
+       ""examples"", ""opf"", ""experiments"", ""multistep"", ""hotgym"")
+ 
+     resultsDir = os.path.join(experimentDir, ""inference"")",wrap to stay under 80 characters,Why is this necessary?
+10110,"@@ -67,6 +67,7 @@ shared_ptr<Layer<Dtype> > GetConvolutionLayer(
+ #endif
+   } else {
+     LOG(FATAL) << ""Layer "" << param.name() << "" has unknown engine."";
++    throw;  // Avoids missing return warning
+   }
+ }
+ ","`return NULL` is more clear than `throw` at least in my reading, and consistent with #3362.",Why is this needed?
+10111,"@@ -87,8 +87,6 @@ class LocustIOExecutor(ScenarioExecutor, WidgetProvider, FileLister, HavingInsta
+ 
+         wrapper = os.path.join(get_full_path(__file__, step_up=2), ""resources"", ""locustio-taurus-wrapper.py"")
+ 
+-        self.env.add_path({""PYTHONPATH"": self.engine.artifacts_dir})
+-        self.env.add_path({""PYTHONPATH"": os.getcwd()})
+         self.env.set({""LOCUST_DURATION"": dehumanize_time(load.duration)})
+ 
+         self.log_file = self.engine.create_artifact(""locust"", "".log"")","Both of these are important. Without it, locust won't find my libraries in the cloud.",why is this removed?
+10112,"@@ -87,7 +87,7 @@ func (o *listSvcOpts) Execute() error {
+ 		return fmt.Errorf(""get application: %w"", err)
+ 	}
+ 
+-	svcs, err := o.store.ListServices(o.appName)
++	svcs, err := o.store.ListWorkloads(o.appName)
+ 	if err != nil {
+ 		return err
+ 	}",This should remain as `ListServices`,Shouldn't this be `ListServices`?
+10113,"@@ -0,0 +1,2 @@
++package v2
++","If no tests, remove this file.",
+10114,"@@ -116,7 +116,7 @@ cp bin/protoc /usr/local/bin/protoc
+     if SHOULD_INVENTORY_GROUPS:
+         GROUPS_DOMAIN_SUPER_ADMIN_EMAIL = context.properties[
+             'groups-domain-super-admin-email']
+-        GROUPS_SERVICE_ACCOUNT_KEY_FILE = context.properties[
++        GSUITE_SERVICE_ACCOUNT_KEY_FILE = context.properties[
+             'groups-service-account-key-file']
+ 
+         # TODO: remove this in a future version",This will require changes to the docs. I suggest searching the gh-pages branch for the previous variable name.,Should this be `GSUITE_DOMAIN_SUP
+10115,"@@ -249,7 +249,7 @@ class RemoteHandler(logging.Handler):
+ 
+ 	def __init__(self):
+ 		#Load nvdaHelperRemote.dll but with an altered search path so it can pick up other dlls in lib
+-		path=os.path.abspath(os.path.join(u""lib"",buildVersion.version,u""nvdaHelperRemote.dll""))
++		path = os.path.join(globalVars.appDir, ""lib"", buildVersion.version, ""nvdaHelperRemote.dll"")
+ 		h=ctypes.windll.kernel32.LoadLibraryExW(path,0,LOAD_WITH_ALTERED_SEARCH_PATH)
+ 		if not h:
+ 			raise OSError(""Could not load %s""%path) ",`RemoteHandler` is used in nvda_slave and slave does not have access to `globalVars` currently. Perhaps `globalVars.appDir` should be set to `None` in `globalVarrs by default and set to NVDA directory when they're imported for the first time.,I think this should be `globalVar
+10116,"@@ -12,10 +12,11 @@ type MetricsConfig struct {
+ }
+ 
+ type FileConfig struct {
+-	Prometheus *PrometheusConfig `hcl:""Prometheus""`
+-	DogStatsd  []DogStatsdConfig `hcl:""DogStatsd""`
+-	Statsd     []StatsdConfig    `hcl:""Statsd""`
+-	M3         []M3Config        `hcl:""M3""`
++	Prometheus   *PrometheusConfig `hcl:""Prometheus""`
++	DogStatsd    []DogStatsdConfig `hcl:""DogStatsd""`
++	Statsd       []StatsdConfig    `hcl:""Statsd""`
++	M3           []M3Config        `hcl:""M3""`
++	DisableInMem bool              `hcl:""DisableInMem""`
+ }
+ 
+ type DogStatsdConfig struct {","In case there is more configuration to be added to the ""inmem"" metrics later (however unlikely that is), we may want to play it safe and create an `InMemConfig` struct and include the disabled flag there. This also gives the config symmetry across the plugins.",Why do we need this?
+10117,"@@ -35,6 +35,16 @@ describe ProposalSearch do
+     end
+ 
+     context Gsa18f::Procurement do
++      around(:each) do |example|
++        ENV['GSA18F_APPROVER_EMAIL'] = 'test_approver@some-dot-gov.gov'
++        ENV['GSA18F_PURCHASER_EMAIL'] = 'test_purchaser@some-dot-gov.gov'
++        example.run
++
++        ENV['GSA18F_APPROVER_EMAIL'] = nil
++        ENV['GSA18F_PURCHASER_EMAIL'] = nil
++      end
++
++
+       [:product_name_and_description, :justification, :additional_info].each do |attr_name|
+         it ""returns the Proposal when searching by the ##{attr_name}"" do
+           procurement = FactoryGirl.create(:gsa18f_procurement, attr_name => 'foo')",I'll need to pull this out of here since we're sharing this in other tests. Same for `procurement_spec.rb`,Extra empty line det
+10118,"@@ -6,7 +6,7 @@ class ObservationsController < ApplicationController
+ 
+   def create
+     obs = @proposal.add_observer(observer_email, current_user, params[:observation][:reason])
+-    flash[:success] = ""#{obs.user.full_name} has been added as an observer""
++    prep_create_response_msg(obs)
+     redirect_to proposal_path(@proposal)
+   end
+ ","what about `observer` as a var name here (and below) rather than `obs` ? -- would be clearer, imo!",Should this be `obs.
+10119,"@@ -110,7 +110,7 @@ class ErrorHandler(object):
+                             value = message
+                             try:
+                                 message = message['message']
+-                            except TypeError:
++                            except KeyError:
+                                 message = None
+                     else:
+                         message = value.get('message', None)",could you change this to instead of being a `try.. except` be `message = message.get('message')`,Why this change?
+10120,"@@ -1,4 +1,5 @@
+-// Copyright (c) Microsoft. All rights reserved.
++// Copyright (c) Microsoft Corporation. All rights reserved.
++// Licensed under the MIT license. See LICENSE file in the project root for full license information.
+ namespace Microsoft.VisualStudio.TestPlatform.CommunicationUtilities
+ {
+     using System;",Add space between License and nameapace,nit: remove empty line
+10121,"@@ -0,0 +1,15 @@
++class ProfileController < ApplicationController
++  def show
++  end
++
++  def update
++    first_name = params[:first_name]
++    last_name = params[:last_name]
++    user = current_user
++    user.first_name = first_name
++    user.last_name = last_name
++    user.save!
++    flash[:success] = ""Your profile is updated!""
++    redirect_to :me
++  end
++end",should we have a `before_filter` for auth here?,Extra empty line detec
+10122,"@@ -575,6 +575,17 @@ func (r *AWSMachineReconciler) reconcileLBAttachment(machineScope *scope.Machine
+ 	// In order to prevent sending request to a ""not-ready"" control plane machines, it is required to remove the machine
+ 	// from the ELB as soon as the machine gets deleted or when the machine is in a not running state.
+ 	if !machineScope.AWSMachine.DeletionTimestamp.IsZero() || !machineScope.InstanceIsRunning() {
++		registered, err := elbsvc.InstanceIsRegisteredWithAPIServerELB(i)
++		if err != nil {
++			r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""FailedDetachControlPlaneELB"",
++				""Failed to deregister control plane instance %q from load balancer: failed to determine registration status: %v"", i.ID, err)
++			return errors.Wrapf(err, ""could not deregister control plane instance %q from load balancer - error determining registration status"", i.ID)
++		}
++		if !registered {
++			// Already deregistered - nothing more to do
++			return nil
++		}
++
+ 		if err := elbsvc.DeregisterInstanceFromAPIServerELB(i); err != nil {
+ 			r.Recorder.Eventf(machineScope.AWSMachine, corev1.EventTypeWarning, ""FailedDetachControlPlaneELB"",
+ 				""Failed to deregister control plane instance %q from load balancer: %v"", i.ID, err)","@vincepri I know we discussed moving this up and only calling it once, but I didn't (quickly) see an easy way to generate the right event based on the appropriate action (attach vs detach). Happy to move it around if you have suggestions.",I think it would be be
+10123,"@@ -0,0 +1,15 @@
++class TsearchHooks
++  def after_save(record)
++    record.class.where(id: record).update_all(
++      ""vector = #{ vector(record) }, popularity_factor = #{ record.searchable_factor }"")
++  end
++
++  def vector(record)
++    weighted_sql = []
++    record.searchable_vector.each do |weight, attr_value|
++      attr_value.gsub!(/['?\\:]/, ' ')
++      weighted_sql << ""setweight(to_tsvector(coalesce('#{attr_value}')), '#{weight.upcase}')""
++    end
++    weighted_sql.join(' ||')
++  end
++end",Can we use record.update here?,Layout/EmptyLinesAroun
+10124,"@@ -243,7 +243,7 @@ func (rw *responseWriter) Close() error {
+ 			retErr = appendError(retErr, fmt.Errorf(""SetApplicationError() failed: %v"", err))
+ 		}
+ 	}
+-	retErr = appendError(retErr, writeHeaders(rw.format, rw.headers, rw.response.Arg2Writer))
++	retErr = appendError(retErr, writeHeaders(rw.format, rw.headers.Items(), rw.response.Arg2Writer))
+ 
+ 	// Arg3Writer must be opened and closed regardless of if there is data
+ 	// However, if there is a system error, we do not want to do this",Shouldn't the exact case option matter here?,Shouldn't this be `rw.headers.SortedItems()`?
+10125,"@@ -184,7 +184,7 @@ def Derived(parent_cls):
+             n = luigi.IntParameter()
+             # ...
+ 
+-        class MyTask(luigi.uti.Derived(AnotherTask)):
++        class MyTask(luigi.util.Derived(AnotherTask)):
+             def requires(self):
+                return self.parent_obj
+             def run(self):","Errr, why haven't we noticed this until now?",Why did you change this?
+10126,"@@ -456,7 +456,11 @@ public final class Lucene50PostingsFormat extends PostingsFormat {
+   @Override
+   public FieldsConsumer fieldsConsumer(SegmentWriteState state) throws IOException {
+     PostingsWriterBase postingsWriter = new Lucene50PostingsWriter(state);
+-    state.segmentInfo.putAttribute(MODE_KEY, fstLoadMode.name());
++    final String previous = state.segmentInfo.putAttribute(MODE_KEY, fstLoadMode.name());
++    if (previous != null && previous.equals(fstLoadMode.name()) == false) {
++      throw new IllegalStateException(""found existing value for "" + MODE_KEY + "" for segment: "" + state.segmentInfo.name +
++          ""old="" + previous + "", new="" + fstLoadMode.name());
++    }
+     boolean success = false;
+     try {
+       FieldsConsumer ret = new BlockTreeTermsWriter(state, ","It's a little spooky that this method throws exception if you try to set the attribute to a different value than it was set before, but then does leave the new value set in the attributes?",Why do we need this check?
+10127,"@@ -48,7 +48,7 @@ public class PodDBAdapter {
+ 
+     private static final String TAG = ""PodDBAdapter"";
+     public static final String DATABASE_NAME = ""Antennapod.db"";
+-    public static final int VERSION = 1090000;
++    public static final int VERSION = 1091000;
+ 
+     /**
+      * Maximum number of arguments for IN-operator.",Please only increment by 1.,Why did you change this?
+10128,"@@ -348,7 +348,7 @@ namespace Microsoft.Rest.Generator.Java
+             else if (primaryType == PrimaryType.TimeSpan ||
+                 primaryType.Name == ""Period"")
+             {
+-                return ""java.time.Period"";
++                return ""org.joda.time.Period"";
+             }
+             else
+             {","Sorry I might have missed some context, but what's the reason you choose `Period` over `Duration` or `Interval`? (Thumbs up for using `org.joda.time` instead!)",Why this change?
+10129,"@@ -2359,6 +2359,19 @@ DefaultSettings.prototype = {
+    */
+   preventOverflow: false,
+ 
++  /**
++   * Prevents wheel event on overlays for doing default action.
++   *
++   * @type {Boolean}
++   * @default false
++   *
++   * @example
++   * ```js
++   * preventWheel: false,
++   * ```
++   */
++  preventWheel: false,
++
+   /**
+    * @description
+    * Enables the functionality of the {@link BindRowsWithHeaders} plugin which allows binding the table rows with their headers.",Please check if is it possible to mark it as private. What's more please add this to the TypeScript definition file.,nit: `preventWhe
+10130,"@@ -28,6 +28,10 @@ static std::string GeneratedFileName(const std::string &path,
+   return path + file_name + ""_generated.h"";
+ }
+ 
++char ToUpper(char c) {
++  return static_cast<char>(::toupper(c));
++}
++
+ namespace cpp {
+ class CppGenerator : public BaseGenerator {
+  public:",Maybe move this to `util.h` ?,Why is this need
+10131,"@@ -4,7 +4,8 @@
+ 
+ package Example
+ 
+-import ""github.com/google/flatbuffers/go""
++#include ""flatbuffers/grpc.h""
++
+ 
+ import (
+   context ""golang.org/x/net/context""",oops. this won't work will it,Why is this need
+10132,"@@ -208,12 +208,16 @@ func (extra ExtraMetadataV3) IsReaderKeyBundleNew() bool {
+ // must be done separately.
+ func MakeInitialRootMetadataV3(tlfID tlf.ID, h tlf.Handle) (
+ 	*RootMetadataV3, error) {
+-	if tlfID.Type() != h.Type() {
++	switch {
++	case h.TypeForKeying() == tlf.TeamKeying && tlfID.Type() != tlf.SingleTeam:
++		fallthrough
++	case h.TypeForKeying() != tlf.TeamKeying && tlfID.Type() != h.Type():
+ 		return nil, errors.New(""TlfID and TlfHandle disagree on TLF type"")
++	default:
+ 	}
+ 
+ 	var writers []keybase1.UserOrTeamID
+-	if tlfID.Type() != tlf.Private {
++	if h.TypeForKeying() != tlf.PrivateKeying {
+ 		writers = make([]keybase1.UserOrTeamID, len(h.Writers))
+ 		copy(writers, h.Writers)
+ 	}",@strib I assumed this is what you meant; but let me know if I'm wrong!,"I don't think this is the right place to do this. If the TLF type is `SingleTeam` and the handle type is `TeamKeying`, then `h.TypeForKeying() == tlf.SingleTeam` should be fine."
+10133,"@@ -106,7 +106,7 @@ func (wh *WorkflowNilCheckHandler) DeprecateNamespace(ctx context.Context, reque
+ 
+ // StartWorkflowExecution starts a new long running workflow instance.  It will create the instance with
+ // 'WorkflowExecutionStarted' event in history and also schedule the first WorkflowTask for the worker to make the
+-// first decision for this instance.  It will return 'WorkflowExecutionAlreadyStartedError', if an instance already
++// first command for this instance.  It will return 'WorkflowExecutionAlreadyStartedError', if an instance already
+ // exists with same workflowId.
+ func (wh *WorkflowNilCheckHandler) StartWorkflowExecution(ctx context.Context, request *workflowservice.StartWorkflowExecutionRequest) (_ *workflowservice.StartWorkflowExecutionResponse, retError error) {
+ 	resp, err := wh.parentHandler.StartWorkflowExecution(ctx, request)",I believe the error has changed,I don't think you need to change this.
+10134,"@@ -41,6 +41,16 @@ module Blacklight
+       self.class.new(params || ActionController::Parameters.new, blacklight_config, controller)
+     end
+ 
++    ##
++    # Check if the query has any constraints defined (a query, facet, etc)
++    #
++    # @return [Boolean]
++    # rubocop:disable Style/PredicateName
++    def has_constraints?
++      params[:q].present? || params[:f].present?
++    end
++    # rubocop:enable Style/PredicateName
++
+     ##
+     # Extension point for downstream applications
+     # to provide more interesting routing to",Lint/UnneededDisable: Unnecessary disabling of Naming/PredicateName.,I think this should be `params[:q] && params[:f].present?`
+10135,"@@ -58,6 +58,8 @@ describe ProposalsController do
+       end
+ 
+       it 'should redirect random users' do
++        skip ""flaky spec""
++
+         proposal = FactoryGirl.create(:proposal)
+         get :show, id: proposal.id
+         expect(response).to redirect_to(proposals_path)",Should this be removed now?,Extra empty line detected at block body end.
+10136,"@@ -25,6 +25,8 @@ public abstract class MockGrpcMethodView {
+ 
+   public abstract String responseTypeName();
+ 
++  public abstract String streamHandle();
++
+   public abstract GrpcStreamingType grpcStreamingType();
+ 
+   public static Builder newBuilder() {",streamHandle sounds vague to me. Can you be more specific?,public abstract String responseTypeName();
+10137,"@@ -736,7 +736,8 @@ Cursor.prototype._initializeCursor = function(callback) {
+       return;
+     }
+ 
+-    server.command(cursor.ns, cursor.cmd, cursor.options, queryCallback);
++    const commandOptions = Object.assign({}, cursor.options, cursor.cursorState);
++    server.command(cursor.ns, cursor.cmd, commandOptions, queryCallback);
+   });
+ };
+ ",Does everything on cursorState belong in the command options?,Why do we need this change?
+10138,"@@ -559,7 +559,7 @@ func (m *MatchNot) UnmarshalCaddyfile(d *caddyfile.Dispenser) error {
+ 	for d.Next() {
+ 		var mp matcherPair
+ 		matcherMap := make(map[string]RequestMatcher)
+-		for d.NextBlock(0) {
++		for d.NextArg() || d.NextBlock(0) {
+ 			matcherName := d.Val()
+ 			mod, err := caddy.GetModule(""http.matchers."" + matcherName)
+ 			if err != nil {","This is clever, but I do admit I think it's kinda weird. We can go with it for now and fix it later if people complain.",`d.NextArg()` will return `nil` if there i
+10139,"@@ -31,7 +31,9 @@ import (
+ )
+ 
+ var (
+-	gsRegex = regexp.MustCompile(`^gs://([a-z0-9][-_.a-z0-9]*)/(.+)$`)
++	bucket = `([a-z0-9][-_.a-z0-9]*)`
++	bucketRegex = regexp.MustCompile(fmt.Sprintf(`^gs://%s/?$`, bucket))
++	gsRegex = regexp.MustCompile(fmt.Sprintf(`^gs://%s/(.+)$`, bucket))
+ )
+ 
+ // StorageClient implements domain.StorageClientInterface. It implements main Storage functions","the variable names are not entirely clear. ""bucket"" is essentially the regex that follows gcs naming pattern, right? if so, it should be changed to bucketregex. and then bucketregex, gsregex should be changed to something more specific to what pattern the regex is supposed to match.",Why do we need this change?
+10140,"@@ -26,8 +26,8 @@ import com.google.common.collect.Lists;
+ import java.util.List;
+ 
+ /** Responsible for producing package meta-data related views for Java GAPIC clients */
+-public class JavaGapicPackageTransformer extends JavaPackageTransformer
+-    implements ModelToViewTransformer {
++public class JavaGapicPackageTransformer<T extends ApiModel> extends JavaPackageTransformer
++    implements ModelToViewTransformer<T> {
+   private final PackageMetadataConfig packageConfig;
+ 
+   public JavaGapicPackageTransformer(PackageMetadataConfig packageConfig) {",I think `ApiModelT` would be clearer than `T`,Why do we need this change?
+10141,"@@ -1,6 +1,5 @@
+-// $Id$
+ //
+-//  Copyright (C) 2004-2008 Greg Landrum and Rational Discovery LLC
++//  Copyright (C) 2004-2016 Greg Landrum and Rational Discovery LLC
+ //
+ //   @@ All Rights Reserved @@
+ //  This file is part of the RDKit.",Shouldn't this be 2019?,Why did you remove the copy
+10142,"@@ -30,6 +30,8 @@ public enum Status {
+   SUCCEEDED(50),
+   KILLING(55),
+   KILLED(60),
++  // POD_FAILED refers to a failed containerized flow due to pod failure
++  POD_FAILED(65),
+   FAILED(70),
+   FAILED_FINISHING(80),
+   SKIPPED(90),","We should consider giving this state a more generic name which could be used for flows in similar state in non-containerized Azkban. For instance in the event of a bare-metal executor crashing we could the switch any flows assigned to that executor to this state. Something like `EXECUTE_INFRA_FAILED`, better alternatives should be possible though.",I don't think we need to ad
+10143,"@@ -4,8 +4,12 @@ var bad = [],
+ 
+ virtualNode.children.forEach(({ actualNode }) => {
+ 	var nodeName = actualNode.nodeName.toUpperCase();
+-	if (actualNode.nodeType === 1 && nodeName !== 'DT' && nodeName !== 'DD' && permitted.indexOf(nodeName) === -1) {
+-		bad.push(actualNode);
++
++	if (actualNode.nodeType === 1 && permitted.indexOf(nodeName) === -1) {
++		var role = (actualNode.getAttribute('role') || '').toLowerCase();
++		if ((nodeName !== 'DT' && nodeName !== 'DD') || role) {
++			bad.push(actualNode);
++		}
+ 	} else if (actualNode.nodeType === 3 && actualNode.nodeValue.trim() !== '') {
+ 		hasNonEmptyTextNode = true;
+ 	}","This should allow `role=definition` and `role=term`, possibly also `role=list`?",Why do we need to check for
+10144,"@@ -511,6 +511,19 @@ public class Spark3Util {
+             TableProperties.PARQUET_BATCH_SIZE, TableProperties.PARQUET_BATCH_SIZE_DEFAULT));
+   }
+ 
++  public static Boolean propertyAsBoolean(CaseInsensitiveStringMap options, String property, Boolean defaultValue) {
++    if (defaultValue != null) {
++      return options.getBoolean(property, defaultValue);
++    }
++
++    String value = options.get(property);
++    if (value != null) {
++      return Boolean.parseBoolean(value);
++    }
++
++    return null;
++  }
++
+   public static Long propertyAsLong(CaseInsensitiveStringMap options, String property, Long defaultValue) {
+     if (defaultValue != null) {
+       return options.getLong(property, defaultValue);",Should this use `boolean` instead of `Boolean`?,nit: `return Boolean.parseBoolean(value);`
+10145,"@@ -135,7 +135,6 @@ namespace OpenTelemetry.Exporter.Zipkin.Tests
+         [Theory]
+         [InlineData(true, false, false)]
+         [InlineData(false, false, false)]
+-        [InlineData(false, true, false)]
+         [InlineData(false, false, true)]
+         [InlineData(false, false, false, StatusCode.Ok)]
+         [InlineData(false, false, false, StatusCode.Ok, null, true)]","Currently in our Zipkin tests, only one passed parameter would instantiate a Resource and checks for its tags populating. I left the If(UseTestResource) clause in the code in case we would like to return to the old resource tag checking, but if it makes more sense I can remove that parameter entirely.","[InlineData(false, false, false, null)]"
+10146,"@@ -944,6 +944,11 @@ public class ZkStateReader implements SolrCloseable {
+     return null;
+   }
+ 
++  public boolean isNodeLive(String node) {
++    return liveNodes.contains(node);
++
++  }
++
+   /**
+    * Get shard leader properties, with retry if none exist.
+    */","While this is potentially convenient it seems off topic for the PR/Issue. Also if it is kept, in the realm of taste/style I tend to not use get/set/is for things that are not properties of the object. maybe hasLiveNode(String node) thus someone using it might write `if (zkReader.hasLiveNode(""foo"")) ...` which reads quite nicely.",nit: remove empty line
+10147,"@@ -10,11 +10,13 @@ import (
+ )
+ 
+ var (
+-	svidPath    = path.Join(ProjectRoot(), ""test/fixture/certs/svid.pem"")
+-	svidKeyPath = path.Join(ProjectRoot(), ""test/fixture/certs/svid_key.pem"")
+-	caPath      = path.Join(ProjectRoot(), ""test/fixture/certs/ca.pem"")
+-	caKeyPath   = path.Join(ProjectRoot(), ""test/fixture/certs/ca_key.pem"")
+-	bundlePath  = path.Join(ProjectRoot(), ""test/fixture/certs/bundle.der"")
++	svidPath     = path.Join(ProjectRoot(), ""test/fixture/certs/svid.pem"")
++	svidKeyPath  = path.Join(ProjectRoot(), ""test/fixture/certs/svid_key.pem"")
++	caPath       = path.Join(ProjectRoot(), ""test/fixture/certs/ca.pem"")
++	caKeyPath    = path.Join(ProjectRoot(), ""test/fixture/certs/ca_key.pem"")
++	bundlePath   = path.Join(ProjectRoot(), ""test/fixture/certs/bundle.der"")
++	blogCsrPath  = path.Join(ProjectRoot(), ""test/fixture/certs/blog_csr.pem"")
++	blogSvidPath = path.Join(ProjectRoot(), ""test/fixture/certs/blog_cert.pem"")
+ )
+ 
+ // LoadCAFixture reads, parses, and returns the pre-defined CA fixture and key",What's the difference between blogSvid and the SVID above? Looks like the functions that use these aren't being called currently - can they be removed?,I think this should be `blogCertPath`
+10148,"@@ -67,7 +67,7 @@ namespace Nethermind.Serialization.Json
+                 return (long) reader.Value;
+             }
+ 
+-            string s = (string) reader.Value;
++            string s = reader.Value?.ToString();
+             if (s == ""0x0"")
+             {
+                 return BigInteger.Zero;",can you add numbers with this change? the CLI is a javascript engine and it can worh number - java adds strings vi concatenation,Why is this change needed?
+10149,"@@ -116,6 +116,8 @@ class OrderDirective
+                 // Note the `lower()` in the `addOrderBy()`. It is essential to sorting the
+                 // results correctly. See also https://github.com/bolt/core/issues/1190
+                 // again: lower breaks postgresql jsonb compatibility, first cast as txt
++                // cast as TEXT or CHAR, depending on SQL support. See Bolt\Doctrine\Query\Cast.php
++                // and https://github.com/bolt/core/issues/2241
+                 $query
+                     ->getQueryBuilder()
+                     ->addOrderBy('lower(CAST(' . $translationsAlias . '.value as TEXT))', $direction);","Shouldn't this `TEXT` also be dependent on the platform, then?",Shouldn't this be `CAST(' 
+10150,"@@ -17,6 +17,15 @@ type Typer interface {
+ 	Type() semantic.MonoType
+ }
+ 
++// ITableObject serves as sort of a ""marker trait"" to allow us to check if a
++// value is a TableObject without having to import TableObject which would be a
++// cyclical import.
++// Identical purpose to the interface in the interpreter package, but sadly we
++// can't import it here because of yet another potential cycle.
++type ITableObject interface {
++	TableObject()
++}
++
+ type Value interface {
+ 	Typer
+ 	IsNull() bool","Can we name this `TableObject`? I'm not a big fan of the `I` prefix for interfaces and that's not really used in Go. Is it also possible to have the method be unexported? I don't know if that's possible. If it's not, this is good. If it is possible, I'd prefer this method to be unexported.",Why is this needed?
+10151,"@@ -31,11 +31,15 @@
+     #include <stdlib.h> // malloc and free
+     #include <tbb/tbb.h>
+     #include <tbb/spin_mutex.h>
+-    #include ""tbb/scalable_allocator.h""
++    #include <tbb/scalable_allocator.h>
+     #include <tbb/global_control.h>
+     #include <tbb/task_arena.h>
+     #include ""services/daal_atomic_int.h""
+ 
++    #if defined(TBB_INTERFACE_VERSION) && TBB_INTERFACE_VERSION >= 12002
++        #include <tbb/task.h>
++    #endif
++
+ using namespace daal::services;
+ #else
+     #include ""src/externals/service_service.h""","If tbb.h is included, there is no big sense to include other TBB headers.",Why is this needed?
+10152,"@@ -915,12 +915,9 @@ def uses_path_addressing(headers):
+ def get_bucket_name(path, headers):
+     parsed = urlparse.urlparse(path)
+ 
+-    # try pick the bucket_name from the path
+-    bucket_name = parsed.path.split('/')[1]
+-
+-    # is the hostname not starting with a bucket name?
+-    if uses_path_addressing(headers):
+-        return normalize_bucket_name(bucket_name)
++    # matches the common endpoints like
++    #     - '<bucket_name>.s3.<region>.*'
++    localstack_pattern = re.compile(r'^(.+)\.s3[.\-][a-z]{2}-[a-z]+-[0-9]{1,}.*')
+ 
+     # matches the common endpoints like
+     #     - '<bucket_name>.s3.<region>.amazonaws.com'",Let's use the same `S3_HOSTNAME_PATTERN` as above here.,"I think this should be `r'^(.+)\.s3[.\-][a-z]{2}-[a-z]+-[0-9]{1,}.*'`"
+10153,"@@ -215,6 +215,7 @@ function parseConnectionString(url, options) {
+     let r = parser.parse(f('mongodb://%s', hosts[i].trim()));
+     if (r.path && r.path.indexOf('.sock') !== -1) continue;
+     if (r.path && r.path.indexOf(':') !== -1) {
++      console.log(""R: "",r)
+       // Not connecting to a socket so check for an extra slash in the hostname.
+       // Using String#split as perf is better than match.
+       if (r.path.split('/').length > 1 && r.path.indexOf('::') === -1) {",This shouldn't be here.,Please remove this.
+10154,"@@ -24,11 +24,16 @@ module ValueHelper
+   end
+ 
+   def property_to_s(val)
+-    # assume all decimals are currency
+-    if decimal?(val)
++    if decimal?(val) # assume all decimals are currency
+       number_to_currency(val)
++    elsif val.is_a?(ActiveSupport::TimeWithZone)
++      I18n.l(val, format: :date)
++    elsif val == true
++      ""Yes""
++    elsif val == false
++      ""No""
+     else
+-      val.to_s
++      val
+     end
+   end
+ end",A `case` statement may be simpler here.,"I think this should be `I18n.t(val, format: :date)`"
+10155,"@@ -1081,10 +1081,15 @@ public class JDBCConnection implements ObjectStoreConnection {
+             throw notFoundError(caller, ZMSConsts.OBJECT_DOMAIN, domainName);
+         }
+         int curTagCount = getDomainTagsCount(domainId);
+-        int remainingTagsToInsert = domainTagsLimit - curTagCount;
++        int newTagCount = calculateTagCount(tags);
++        if (curTagCount + newTagCount > domainTagsLimit) {
++            throw ZMSUtils.quotaLimitError(""domain tag quota exceeded - limit: ""
++                + domainTagsLimit + "", current tags count: "" + curTagCount + "", new tags count: "" + newTagCount, caller);
++        }
++
+         boolean res = true;
+         for (Map.Entry<String, StringList> e : tags.entrySet()) {
+-            for (int i = 0; i < e.getValue().getList().size() && remainingTagsToInsert-- > 0; i++) {
++            for (int i = 0; i < e.getValue().getList().size(); i++) {
+                 String tagValue = e.getValue().getList().get(i);
+                 try (PreparedStatement ps = con.prepareStatement(SQL_INSERT_DOMAIN_TAG)) {
+                     ps.setInt(1, domainId);",why are we adding the current tag count to new tag count ?,I'm not sure if this is the right way to do it. I think it would be b
+10156,"@@ -12,7 +12,7 @@ func (c *ServerConfig) SetServerMode(port int, network, netmask string) {
+ 
+ func (c *ServerConfig) SetTLSServer() {
+ 	c.setFlag(""tls-server"")
+-	c.AddOptions(OptionFile(""dh"", ""none""))
++	c.AddOptions(OptionFile(""dh"", ""none"", ""none""))
+ }
+ 
+ func (c *ServerConfig) SetProtocol(protocol string) {","Are you writing ""none"" to file content? no good",Why is this change needed?
+10157,"@@ -21,10 +21,10 @@ class SnippetWidget extends BaseWidget
+         string $target = Target::NOWHERE,
+         string $zone = RequestZone::NOWHERE
+     ) {
+-        $this->template = $snippet;
+-        $this->name = $name;
+-        $this->target = $target;
+-        $this->zone = $zone;
++        $this->setTemplate($snippet);
++        $this->setName($name);
++        $this->setTargets([$target]);
++        $this->setZone($zone);
+     }
+ 
+     protected function run(array $params = []): ?string",Should we allow `string|string[]` here?,Why do we need to set targ
+10158,"@@ -546,7 +546,17 @@ module.exports = class Dashboard extends Plugin {
+     })
+ 
+     // 4. Add all dropped files
+-    getDroppedFiles(event.dataTransfer)
++    let executedDropErrorOnce = false
++    const logDropError = (error) => {
++      this.uppy.log(error.message, 'error')
++
++      // In practice all drop errors are most likely the same, so let's just show one to avoid overwhelming the user
++      if (!executedDropErrorOnce) {
++        this.uppy.info(error.message, 'error')
++        executedDropErrorOnce = true
++      }
++    }
++    getDroppedFiles(event.dataTransfer, { logDropError })
+       .then((files) => {
+         if (files.length > 0) {
+           this.uppy.log('[Dashboard] Files were dropped')","Is there a reason for logging `error.message` specifically, maybe log the whole error object?",I'm not sure if this is th
+10159,"@@ -42,7 +42,9 @@ namespace OpenTelemetry.Trace
+             var aspnetOptions = new AspNetInstrumentationOptions();
+             configureAspNetInstrumentationOptions?.Invoke(aspnetOptions);
+ 
+-            builder.AddDiagnosticSourceInstrumentation((activitySource) => new AspNetInstrumentation(activitySource, aspnetOptions));
++            builder.AddInstrumentation(() => new AspNetInstrumentation(aspnetOptions));
++            builder.AddSource(typeof(AspNetInstrumentation).Assembly.GetName().Name);
++            builder.AddLegacyActivityOperationName(""Microsoft.AspNet.HttpReqIn"");
+ 
+             return builder;
+         }",Why is this needed?,I'm not sure if this is th
+10160,"@@ -404,6 +404,14 @@ func (proxy *Proxy) ContainerStarted(ident string) {
+ 	proxy.notifyWaiters(ident, err)
+ }
+ 
++func (proxy *Proxy) ContainerConnected(ident string) {
++	err := proxy.attach(ident)
++	// if err != nil {
++	// TODO: Not sure what is needed here.
++	// }
++	proxy.notifyWaiters(ident, err)
++}
++
+ func containerShouldAttach(container *docker.Container) bool {
+ 	return len(container.Config.Entrypoint) > 0 && container.Config.Entrypoint[0] == weaveWaitEntrypoint[0]
+ }","Nothing. We only expect container-connected events when going via the plugin, not the proxy.",Why is this needed?
+10161,"@@ -11,6 +11,8 @@ import { mount } from './diff/mount';
+ import { patch } from './diff/patch';
+ import { createInternal } from './tree';
+ 
++let rootId = 0;
++
+ /**
+  *
+  * @param {import('./internal').PreactElement} parentDom The DOM element to","We might want to introduce some randomness here in case there are multiple completely separate Preact installations running, i.e. 2 widgets as those will be two roots with a resetting `_domDepth`",Why is this needed?
+10162,"@@ -488,7 +488,7 @@ func TestPushChunkToNextClosest(t *testing.T) {
+ 	if err != nil {
+ 		t.Fatal(err)
+ 	}
+-	if ta2.Get(tags.StateSent) != 2 {
++	if ta2.Get(tags.StateSent) != 1 {
+ 		t.Fatalf(""tags error"")
+ 	}
+ ",this seems a bit wrong no? why is this change needed?,Why did this change
+10163,"@@ -145,7 +145,7 @@ Transaction.prototype._validateFees = function() {
+     return 'Fee is more than ' + Transaction.FEE_SECURITY_MARGIN + ' times the suggested amount';
+   }
+   if (this._getUnspentValue() < this._estimateFee() / Transaction.FEE_SECURITY_MARGIN) {
+-    return 'Fee is less than ' + Transaction.FEE_SECURITY_MARGIN + ' times the suggested amount';
++    return 'Fee is ' + Transaction.FEE_SECURITY_MARGIN + ' times less than the suggested amount';
+   }
+ };
+ ",Still confusing. Why don't we return something like `'Fee too low: expected X but found Y'`?,I think this should
+10164,"@@ -81,14 +81,16 @@ type ProviderModeConfig struct {
+ type ConsumerConfig struct {
+ 	PublicKey string `json:""PublicKey""`
+ 	// IP is needed when provider is behind NAT. In such case provider parses this IP and tries to ping consumer.
+-	IP string `json:""IP,omitempty""`
++	IP    string `json:""IP,omitempty""`
++	Ports []int  `json:""Ports""`
+ }
+ 
+ // ServiceConfig represent a Wireguard service provider configuration that will be passed to the consumer for establishing a connection.
+ type ServiceConfig struct {
+ 	// LocalPort and RemotePort are needed for NAT hole punching only.
+-	LocalPort  int `json:""-""`
+-	RemotePort int `json:""-""`
++	LocalPort  int   `json:""-""`
++	RemotePort int   `json:""-""`
++	Ports      []int `json:""Ports""`
+ 
+ 	Provider struct {
+ 		PublicKey string","Should be from lowercase `json:""ports""` the same is defined in MarshalJSON",Why do we need this?
+10165,"@@ -3,7 +3,7 @@
+ 
+ # Purpose:
+ # sns-ruby-example-create-subscription.rb demonstrates how to create an Amazon Simple Notification Services (SNS) subscription using
+-# the AWS SDK for JavaScript (v3).
++# the AWS SDK for Ruby.
+ 
+ # Inputs:
+ # - REGION",Simple Notification **Service** (singular),I'm not sure if this
+10166,"@@ -32,7 +32,9 @@ public class NashornScriptInterpreter implements ScriptInterpreter {
+ 
+     @Override
+     public void runScript(String scriptContent, Consumer<Exception> errorCallback) {
+-        nashornEngineFactory.createEngine().eval(scriptContent, errorCallback);
++        final NashornEngine engine = nashornEngineFactory.createEngine();
++        engine.eval(""var tr = Packages.org.phoenicis.configuration.localisation.Localisation.tr;"", errorCallback);
++        engine.eval(scriptContent, errorCallback);
+     }
+ 
+     @Override",This code should be executed in NashornEngineFactory,Why is this needed?
+10167,"@@ -53,6 +53,7 @@ type Tags struct {
+ 
+ // NewTags creates a tags object
+ func NewTags(stateStore storage.StateStorer, logger logging.Logger) *Tags {
++	rand.Seed(time.Now().UnixNano())
+ 	return &Tags{
+ 		tags:       &sync.Map{},
+ 		stateStore: stateStore,","this is not so great as it sets the global rand seed. in tests that invoke this method multiple times for whatever reason, the global seed would be overridden every time the constructor would be called and the instances would have a different seed after every constructor call. it would be better to just pass a new source here as a parameter and do the same within the test. it should simplify things and clean this up",Why do we need this?
+10168,"@@ -831,6 +831,14 @@ public class BesuCommand implements DefaultCommandValues, Runnable {
+       arity = ""1"")
+   private final Wei txFeeCap = DEFAULT_RPC_TX_FEE_CAP;
+ 
++  @Option(
++      names = {""--rpc-require-chainid-in-txs""},
++      description =
++          ""Allow for unprotected (non EIP155 signed) transactions to be submitted via RPC (default: ${DEFAULT-VALUE})"",
++      arity = ""1"")
++  // TODO: set default to false for next major release
++  private final Boolean unprotectedTransactionsAllowed = true;
++
+   @Option(
+       names = {""--min-block-occupancy-ratio""},
+       description = ""Minimum occupancy ratio for a mined block (default: ${DEFAULT-VALUE})"",","This looks inverted to me: if `--rpc-require-chainid-in-txs=true`, then shouldn't `unprotectedTransactionsAllowed == false`? Suggest changing this variable to `requireTxReplayProtection` or similar. I think the flag name could be clearer as well, maybe: `--require-tx-replay-protection`.",I don't think we need this option. The default is true.
diff --git a/data/transloadit_uppy_1000.csv b/data/transloadit_uppy_1000.csv
new file mode 100644
index 0000000..ec4bdc1
--- /dev/null
+++ b/data/transloadit_uppy_1000.csv
@@ -0,0 +1,27317 @@
+,diff_hunk,human_review,created_at
+460,"@@ -0,0 +1,10 @@
++const createSuperFocus = require('./createSuperFocus')
++
++describe('createSuperFocus', () => {
++  // superFocus.cancel() is used in dashboard
++  it('should return a function that can be cancelled', () => {","Confused, sorry, but where is `superFocus.cancel()` defined?",2019-05-03 18:49:06
+396,"@@ -0,0 +1,104 @@
++---
++type: docs
++order: 10
++title: ""Robodog""
++menu: ""Introduction""
++module: ""@uppy/robodog""
++permalink: docs/robodog/
++---
++
++[Transloadit][transloadit] is a service that helps you handle file uploads, resize, crop and watermark your images, make GIFs, transcode your videos, extract thumbnails, generate audio waveforms, and so much more. In short, [Transloadit][transloadit] is the Swiss Army Knife for your files.
++
++Robodog is an Uppy-based library that helps you talk to the Transloadit API. It includes a modal UI file picker with support for imports from third-party services, integration with HTML forms, and more. Because it's based on Uppy, you can add any existing Uppy plugin to add more functionality.
++
++## Install
++
++Robodog can be downloaded from npm:
++
++```shell
++npm install --save @uppy/robodog
++```
++
++Then, with a bundler such as [webpack][webpack] or [Browserify][browserify], do:
++
++```js
++const transloadit = require('@uppy/robodog')
++```
++
++If you are not using a bundler, you can also import the Robodog using an HTML script tag.
++
++```html
++<link rel=""stylesheet"" href=""https://transloadit.edgly.net/releases/robodog/v1.0.0/dist/style.min.css"">
++<script src=""https://transloadit.edgly.net/releases/robodog/v1.0.0/dist/transloadit.min.js""></script>
++```
++
++## Methods
++
++Robodog has several methods for different use cases.
++
++If you want to have a modal UI that users can use to select files from their local device or from third party sources like Instagram, use the [File Picker API](#File-Picker). This can be used for one-off uploads _outside_ an HTML form, like profile avatars or images to embed in a blog post.
++
++If you already have an HTML form, you can use the [Form API](#Form) to add Transloadit's encoding capabilities to it. Files will be uploaded to Transloadit, and the form will submit JSON information about the files and encoding results. You can also optionally show upload progress using Uppy's Status Bar UI, or even use the advanced Dashboard UI so users can import files from third party sources as well.
++
++Finally, you can use the [Programmatic Upload API](#Programmatic-Uploads) with your custom UI implementation.
++
++And if any of these methods are not flexible enough, you can always replace them with a custom Uppy setup using the [Transloadit Plugin](/docs/transloadit) instead!
++
++## File Picker
++
++Show a modal UI that allows users to pick files from their device and from the web. It uploads files to Transloadit for processing.
++
++```js
++const resultPromise = transloadit.pick('body', {
++  params: {",This was changed so that `target` is now part of the `opts` object?,2019-01-31 12:11:02
+397,"@@ -0,0 +1,104 @@
++---
++type: docs
++order: 10
++title: ""Robodog""
++menu: ""Introduction""
++module: ""@uppy/robodog""
++permalink: docs/robodog/
++---
++
++[Transloadit][transloadit] is a service that helps you handle file uploads, resize, crop and watermark your images, make GIFs, transcode your videos, extract thumbnails, generate audio waveforms, and so much more. In short, [Transloadit][transloadit] is the Swiss Army Knife for your files.
++
++Robodog is an Uppy-based library that helps you talk to the Transloadit API. It includes a modal UI file picker with support for imports from third-party services, integration with HTML forms, and more. Because it's based on Uppy, you can add any existing Uppy plugin to add more functionality.
++
++## Install
++
++Robodog can be downloaded from npm:
++
++```shell
++npm install --save @uppy/robodog
++```
++
++Then, with a bundler such as [webpack][webpack] or [Browserify][browserify], do:
++
++```js
++const transloadit = require('@uppy/robodog')
++```
++
++If you are not using a bundler, you can also import the Robodog using an HTML script tag.
++
++```html
++<link rel=""stylesheet"" href=""https://transloadit.edgly.net/releases/robodog/v1.0.0/dist/style.min.css"">
++<script src=""https://transloadit.edgly.net/releases/robodog/v1.0.0/dist/transloadit.min.js""></script>
++```
++
++## Methods
++
++Robodog has several methods for different use cases.
++
++If you want to have a modal UI that users can use to select files from their local device or from third party sources like Instagram, use the [File Picker API](#File-Picker). This can be used for one-off uploads _outside_ an HTML form, like profile avatars or images to embed in a blog post.
++
++If you already have an HTML form, you can use the [Form API](#Form) to add Transloadit's encoding capabilities to it. Files will be uploaded to Transloadit, and the form will submit JSON information about the files and encoding results. You can also optionally show upload progress using Uppy's Status Bar UI, or even use the advanced Dashboard UI so users can import files from third party sources as well.
++
++Finally, you can use the [Programmatic Upload API](#Programmatic-Uploads) with your custom UI implementation.
++
++And if any of these methods are not flexible enough, you can always replace them with a custom Uppy setup using the [Transloadit Plugin](/docs/transloadit) instead!
++
++## File Picker
++
++Show a modal UI that allows users to pick files from their device and from the web. It uploads files to Transloadit for processing.
++
++```js
++const resultPromise = transloadit.pick('body', {
++  params: {
++    auth: { key: '' },
++    template_id: ''
++  }
++})
++```
++
++**ADD IMAGE OR GIF HERE**
++
++<a class=""MoreButton"" href=""/docs/robodog/picker"">View Documentation</a>
++
++## Form
++
++Add resumable uploads and Transloadit's processing to your existing HTML upload forms. Selected files will be uploaded to Transloadit, and the Assembly information will be submitted to your form endpoint.
++
++```html
++<form id=""myForm"" method=""POST"" action=""/upload"">
++  <input type=""file"" multiple>
++  <!-- Will be inserted by `transloadit.form()`: -->
++  <!-- <input type=""hidden"" name=""transloadit"" value=""{...json...}""> -->
++  <button type=""submit"">Upload</button>
++</form>
++<script>
++transloadit.form('form#myForm', {
++  params: {
++    auth: { key: '' },
++    template_id: ''
++  }
++})
++</script>
++```
++
++<a class=""MoreButton"" href=""/docs/robodog/form"">View Documentation</a>
++
++## Programmatic Uploads
++
++Upload files straight to Transloadit from your own custom UI. Give us an array of files, and we'll give you an array of results!
++
++```js
++const resultPromise = transloadit.upload(files, {
++  params: {
++    auth: { key: '' },
++    template_id: ''
++  }
++})",Nitpick: maybe adding `.then()` with `console.log` would be helpful too?,2019-01-31 12:13:54
+528,"@@ -0,0 +1,104 @@
++@import './FilePreviewAndLink/index.scss';
++@import './FileProgress/index.scss';
++@import './FileInfo/index.scss';
++@import './Buttons/index.scss';
++
++.uppy-DashboardItem {
++  // @media only mobile
++  .uppy-Dashboard:not(.uppy-size--md) & {
++    display: flex;
++    align-items: center;
++    border-bottom: 1px solid $gray-200;
++    padding: 10px;
++    padding-right: 0;
++  }
++  // @media bigger than .md
++  $rl-margin: 15px;
++  .uppy-size--md & {
++    // For the Remove button
++    position: relative;
++
++    display: block;
++    float: left;
++    margin: 5px $rl-margin;
++    width: calc(33.333% - #{$rl-margin} - #{$rl-margin});
++    height: 215px;
++  }
++  .uppy-size--lg & {
++    margin: 5px $rl-margin;
++    width: calc(25% - #{$rl-margin} - #{$rl-margin});
++    height: 190px;
++  }
++  .uppy-size--xl & {
++    width: calc(20% - #{$rl-margin} - #{$rl-margin});
++    height: 210px;
++  }
++
++  > .uppy-DashboardItem-preview {
++    // for the FileProgress.js icons
++    position: relative;
++
++    // @media only mobile
++    .uppy-Dashboard:not(.uppy-size--md) & {
++      flex-shrink: 0;
++      flex-grow: 0;
++      width: 50px;
++      height: 50px;
++    }
++    // @media bigger than .md
++    .uppy-size--md & {
++      width: 100%;
++      height: 140px;
++    }
++    .uppy-size--lg & {
++      height: 120px;
++    }
++    .uppy-size--xl & {
++      height: 140px;
++    }
++  }
++
++  > .uppy-DashboardItem-fileInfoAndButtons {
++    flex-grow: 1;
++    padding-right: 8px;
++    padding-left: 12px;
++
++    display: flex;
++    align-items: center;
++    justify-content: space-between;
++
++    .uppy-size--md & {
++      align-items: flex-start;
++      width: 100%;
++      padding: 0;
++      padding-top: 9px;
++    }
++
++    > .uppy-DashboardItem-fileInfo {
++      flex-grow: 1;
++      flex-shrink: 1;
++    }
++
++    > .uppy-DashboardItem-actionWrapper {
++      flex-grow: 0;
++      flex-shrink: 0;
++    }
++  }
++}
++
++// Css that depends on status of the file (could be logic in js instead?)","Yeah, a lot of this stuff with pause/resume/done icons could be logic in JS, I think, for some reason I went with CSS initially and then it pilled on.",2019-06-24 16:04:36
+248,"@@ -0,0 +1,108 @@
++const Plugin = require('uppy/lib/core/Plugin')
++const { Provider } = require('uppy/lib/server')
++const { ProviderView } = require('uppy/lib/views')
++const { h } = require('preact')
++
++module.exports = class MyCustomProvider extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.type = 'acquirer'
++    this.id = this.opts.id || 'MyCustomProvider'
++    this.title = 'MyCustomProvider'
++    this.icon = () => (
++      <img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" />
++    )
++
++    // writing out the key explicitly for readability the key used to store
++    // the provider instance must be equal to this.id.
++    this[this.id] = new Provider(uppy, {","this is unrelated but would it make sense to pass in the plugin and the Provider instance separately to provider Views? then we don't need the `this[this.id]` dance, people could just put it somewhere they like and then do `new ProviderViews(this, provider)`",2018-04-09 14:08:22
+246,"@@ -0,0 +1,108 @@
++const Plugin = require('uppy/lib/core/Plugin')
++const { Provider } = require('uppy/lib/server')
++const { ProviderView } = require('uppy/lib/views')
++const { h } = require('preact')
++
++module.exports = class MyCustomProvider extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.type = 'acquirer'
++    this.id = this.opts.id || 'MyCustomProvider'
++    this.title = 'MyCustomProvider'
++    this.icon = () => (
++      <img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" />
++    )
++
++    // writing out the key explicitly for readability the key used to store
++    // the provider instance must be equal to this.id.
++    this[this.id] = new Provider(uppy, {
++      host: this.opts.host,
++      provider: 'custom'
++    })
++
++    this.files = []
++    this.onAuth = this.onAuth.bind(this)
++    this.render = this.render.bind(this)
++
++    // merge default options with the ones set by user
++    this.opts = Object.assign({}, {}, opts)",Two `{}`s :),2018-04-09 14:03:11
+247,"@@ -0,0 +1,108 @@
++const Plugin = require('uppy/lib/core/Plugin')
++const { Provider } = require('uppy/lib/server')
++const { ProviderView } = require('uppy/lib/views')
++const { h } = require('preact')
++
++module.exports = class MyCustomProvider extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.type = 'acquirer'
++    this.id = this.opts.id || 'MyCustomProvider'
++    this.title = 'MyCustomProvider'
++    this.icon = () => (
++      <img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" />
++    )
++
++    // writing out the key explicitly for readability the key used to store
++    // the provider instance must be equal to this.id.
++    this[this.id] = new Provider(uppy, {
++      host: this.opts.host,
++      provider: 'custom'
++    })
++
++    this.files = []
++    this.onAuth = this.onAuth.bind(this)
++    this.render = this.render.bind(this)
++
++    // merge default options with the ones set by user
++    this.opts = Object.assign({}, {}, opts)
++  }
++
++  install () {
++    this.view = new ProviderView(this)
++    // Set default state for Dropbox
++    this.setPluginState({
++      authenticated: false,
++      files: [],
++      folders: [],
++      directories: [],
++      activeRow: -1,
++      filterInput: '',
++      isSearchVisible: false
++    })",> Set default state for Dropbox,2018-04-09 14:04:35
+939,"@@ -0,0 +1,108 @@
++const request = require('request')
++// @ts-ignore
++const atob = require('atob')
++const logger = require('../logger')
++const oAuthState = require('../helpers/oauth-state')
++const tokenService = require('../helpers/jwt')
++
++exports.getCredentialsOverrideMiddleware = (providers, companionOptions) => {
++  return (req, res, next) => {
++    const { authProvider, override } = req.params
++    const [providerName] = Object.keys(providers).filter((name) => providers[name].authProvider === authProvider)
++    if (!providerName) {
++      return next()
++    }
++
++    if (!companionOptions.providerOptions[providerName].credentialsURL) {
++      return next()
++    }
++
++    const dynamic = (req.session.grant || {}).dynamic || {}
++    // only use state via session object if user isn't making intial ""connect"" request.
++    // override param indicates subsequent requests from the oauth flow
++    const state = override ? dynamic.state : req.query.state
++    if (!state) {
++      return next()
++    }
++
++    const preAuthToken = oAuthState.getFromState(state, 'preAuthToken', companionOptions.secret)
++    if (!preAuthToken) {
++      return next()
++    }
++
++    const { err, payload } = tokenService.verifyEncryptedToken(preAuthToken, companionOptions.preAuthSecret)
++    if (err || !payload) {
++      return next()
++    }
++
++    module.exports.fetchProviderKeys(providerName, companionOptions, payload).then((credentials) => {
++      res.locals.grant = {
++        dynamic: {
++          key: credentials.key,
++          secret: credentials.secret
++        }
++      }
++
++      if (credentials.redirect_uri) {
++        res.locals.grant.dynamic.redirect_uri = credentials.redirect_uri
++      }
++    }).finally(() => next())
++  }
++}
++
++module.exports.getCredentialsResolver = (providerName, companionOptions, req) => {
++  const credentialsResolver = () => {
++    const encodedCredentialsParams = req.header('uppy-credentials-params')
++    let credentialRequestParams = null
++    if (encodedCredentialsParams) {
++      try {
++        credentialRequestParams = JSON.parse(atob(encodedCredentialsParams)).params
++      } catch (error) {
++        logger.error(error, 'credentilas.resolve.fail', req.id)","```suggestion
+        logger.error(error, 'credentials.resolve.fail', req.id)
+```
+typo",2020-11-16 11:30:44
+940,"@@ -0,0 +1,108 @@
++const request = require('request')
++// @ts-ignore
++const atob = require('atob')
++const logger = require('../logger')
++const oAuthState = require('../helpers/oauth-state')
++const tokenService = require('../helpers/jwt')
++
++exports.getCredentialsOverrideMiddleware = (providers, companionOptions) => {
++  return (req, res, next) => {
++    const { authProvider, override } = req.params
++    const [providerName] = Object.keys(providers).filter((name) => providers[name].authProvider === authProvider)
++    if (!providerName) {
++      return next()
++    }
++
++    if (!companionOptions.providerOptions[providerName].credentialsURL) {
++      return next()
++    }
++
++    const dynamic = (req.session.grant || {}).dynamic || {}
++    // only use state via session object if user isn't making intial ""connect"" request.
++    // override param indicates subsequent requests from the oauth flow
++    const state = override ? dynamic.state : req.query.state
++    if (!state) {
++      return next()
++    }
++
++    const preAuthToken = oAuthState.getFromState(state, 'preAuthToken', companionOptions.secret)
++    if (!preAuthToken) {
++      return next()
++    }
++
++    const { err, payload } = tokenService.verifyEncryptedToken(preAuthToken, companionOptions.preAuthSecret)
++    if (err || !payload) {
++      return next()
++    }
++
++    module.exports.fetchProviderKeys(providerName, companionOptions, payload).then((credentials) => {
++      res.locals.grant = {
++        dynamic: {
++          key: credentials.key,
++          secret: credentials.secret
++        }
++      }
++
++      if (credentials.redirect_uri) {
++        res.locals.grant.dynamic.redirect_uri = credentials.redirect_uri
++      }
++    }).finally(() => next())
++  }
++}
++
++module.exports.getCredentialsResolver = (providerName, companionOptions, req) => {
++  const credentialsResolver = () => {
++    const encodedCredentialsParams = req.header('uppy-credentials-params')
++    let credentialRequestParams = null
++    if (encodedCredentialsParams) {
++      try {
++        credentialRequestParams = JSON.parse(atob(encodedCredentialsParams)).params
++      } catch (error) {
++        logger.error(error, 'credentilas.resolve.fail', req.id)
++      }
++    }
++
++    return module.exports.fetchProviderKeys(providerName, companionOptions, credentialRequestParams)
++  }
++
++  return credentialsResolver
++}
++
++module.exports.fetchProviderKeys = (providerName, companionOptions, credentialRequestParams) => {
++  let providerConfig = companionOptions.providerOptions[providerName]
++  if (!providerConfig) {
++    providerConfig = (companionOptions.customProviders[providerName] || {}).config
++  }
++
++  if (providerConfig && providerConfig.credentialsURL && credentialRequestParams) {
++    return fetchKeys(providerConfig.credentialsURL, providerName, credentialRequestParams)
++  } else {
++    return Promise.resolve(providerConfig)
++  }
++}
++
++const fetchKeys = (url, providerName, credentialRequestParams) => {
++  return new Promise((resolve, reject) => {
++    const options = {
++      body: {
++        provider: providerName,
++        params: credentialRequestParams
++      },
++      json: true
++    }
++    request.post(url, options, (err, resp, body) => {
++      if (err) {
++        logger.error(err, 'credentials.fetch.fail')
++        return reject(err)
++      }
++
++      if (resp.statusCode !== 200 || !body.credentials) {
++        const err = new Error(`recevied status: ${resp.statusCode} with no credentials`)","```suggestion
+        const err = new Error(`received status: ${resp.statusCode} with no credentials`)
+```
+typo",2020-11-16 11:30:58
+314,"@@ -0,0 +1,11 @@
++#!/usr/bin/env bash
++sh ../env.sh
++
++export UPPYSERVER_DATADIR=""./packages/@uppy/companion/output""",We may want to put the data directory in the repo root instead so we can never accidentally publish it.,2018-07-16 10:29:06
+317,"@@ -0,0 +1,11 @@
++#!/usr/bin/env bash
++sh ../env.sh
++
++export UPPYSERVER_DATADIR=""./packages/@uppy/companion/output""
++export UPPYSERVER_DOMAIN=""localhost:3020""
++export UPPYSERVER_PROTOCOL=""http""
++export UPPYSERVER_PORT=3020
++export UPPY_ENDPOINTS=""""
++export UPPYSERVER_SECRET=""development""
++
++nodemon --exec node ./packages/@uppy/companion/src/standalone/start-server.js","nodemon watches everything in the working directory by default, so this will restart each time any Uppy client file is built or updated too. (try doing `npm start` in the repo root.) Using `--watch packages/@uppy/companion` would help there",2018-07-16 10:57:21
+32,"@@ -0,0 +1,111 @@
++const Plugin = require('../Plugin')
++const Tus10Plugin = require('../Tus10')
++const Client = require('./Client')
++
++module.exports = class Transloadit extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.type = 'uploader'
++    this.id = 'Transloadit'
++    this.title = 'Transloadit'
++
++    const defaultOptions = {
++      templateId: null,
++      resume: true,
++      allowPause: true
++    }
++
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    if (!this.opts.key) {
++      throw new Error('Transloadit: The `key` option is required. ' +
++        'You can find your Transloadit API key at https://transloadit.com/accounts/credentials.')
++    }
++    if (!this.opts.templateId) {
++      throw new Error('Transloadit: The `templateId` option is required. ' +
++        'You can find your template\'s ID at https://transloadit.com/templates.')
++    }
++
++    this.client = new Client({
++      key: this.opts.key
++    })
++  }
++
++  createAssembly () {
++    this.core.log('Transloadit: create assembly')
++
++    return this.client.createAssembly({
++      templateId: this.opts.templateId,
++      expectedFiles: Object.keys(this.core.state.files).length
++    }).then((assembly) => {
++      this.updateState({ assembly })
++
++      function attachAssemblyMetadata (file, assembly) {
++        const meta = Object.assign({}, file.meta, {
++          assembly_url: assembly.assembly_url,
++          filename: file.name,
++          fieldname: 'file'
++        })",<strike>The Tus plugin uses the `meta` property of files as an `Upload-Meta` header. (should add a code comment here explaining that)</strike> done,2017-04-10 12:16:57
+816,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',",[these are the icons supported by uppy](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/provider-views/src/Item/components/ItemIcon.js#L32-L39). So maybe change _text_ and _audio_ to _file_?,2020-07-13 08:44:02
+825,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`",I guess we can leave the `dates=` part out right? We don't seem to need it for anything do we?,2020-07-13 09:52:27
+826,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`","I guess this can be rewritten as this right?
+
+```suggestion
+  return `?cursor=${start.subtract(1, 'days').format('YYYY-MM-DD')}`
+```",2020-07-13 10:05:15
+830,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`
++}
++
++exports.getQuery = (results) => {",maybe we should rename this to `getNextPagePath` since that's really it does?,2020-07-13 10:37:40
+831,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`
++}
++
++exports.getQuery = (results) => {
++  if (results.next_page_token) {
++    return `?${qs.stringify({
++      cursor: results.next_page_token || '',",I guess we don't need the fallback value since we already have the `if (...)` check above?,2020-07-13 10:38:25
+832,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`
++}
++
++exports.getQuery = (results) => {
++  if (results.next_page_token) {
++    return `?${qs.stringify({
++      cursor: results.next_page_token || '',
++      from: results.from,
++      to: results.to
++    })}`
++  }
++  return null
++}
++// we rely on the file_type attribute to differentiate a recording file from other items
++exports.getIsFolder = (item) => {
++  return !item.file_type
++}
++
++exports.getItemName = (item) => {
++  const start = moment(item.start_time || item.recording_start)
++    .clone()
++    .format('YYYY-MM-DD, kk:mm')
++
++  if (item.file_type) {
++    const itemType = item.recording_type ? ` - ${item.recording_type.split('_').join(' ')}` : ''
++    return `${start}${itemType} (${item.file_type.toLowerCase()})`
++  }
++
++  return `${item.topic} (${start})`
++}
++
++exports.getIcon = (item) => {
++  if (item.file_type) {
++    return null",I think we can use the `ICONS` constant for other file types as well no?,2020-07-13 10:45:33
+833,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`
++}
++
++exports.getQuery = (results) => {
++  if (results.next_page_token) {
++    return `?${qs.stringify({
++      cursor: results.next_page_token || '',
++      from: results.from,
++      to: results.to
++    })}`
++  }
++  return null
++}
++// we rely on the file_type attribute to differentiate a recording file from other items
++exports.getIsFolder = (item) => {
++  return !item.file_type
++}
++
++exports.getItemName = (item) => {
++  const start = moment(item.start_time || item.recording_start)
++    .clone()
++    .format('YYYY-MM-DD, kk:mm')
++
++  if (item.file_type) {
++    const itemType = item.recording_type ? ` - ${item.recording_type.split('_').join(' ')}` : ''
++    return `${start}${itemType} (${item.file_type.toLowerCase()})`
++  }
++
++  return `${item.topic} (${start})`
++}
++
++exports.getIcon = (item) => {
++  if (item.file_type) {
++    return null
++  }
++  return ICONS.FOLDER
++}
++
++exports.getMimeType = (item) => {
++  if (item.file_type) {
++    return MIMETYPES[item.file_type]
++  }
++  return null
++}
++
++exports.getId = (item) => {
++  let id = `${encodeURIComponent(item.id)}`
++  if (item.file_type) {
++    id = `${item.meeting_id}?recordingId=${id}`","are we using this query anywhere? if not, maybe we should instead do something like: `${item.meeting_id}__${id}`",2020-07-13 10:53:27
+834,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`
++}
++
++exports.getQuery = (results) => {
++  if (results.next_page_token) {
++    return `?${qs.stringify({
++      cursor: results.next_page_token || '',
++      from: results.from,
++      to: results.to
++    })}`
++  }
++  return null
++}
++// we rely on the file_type attribute to differentiate a recording file from other items
++exports.getIsFolder = (item) => {
++  return !item.file_type
++}
++
++exports.getItemName = (item) => {
++  const start = moment(item.start_time || item.recording_start)
++    .clone()
++    .format('YYYY-MM-DD, kk:mm')
++
++  if (item.file_type) {
++    const itemType = item.recording_type ? ` - ${item.recording_type.split('_').join(' ')}` : ''
++    return `${start}${itemType} (${item.file_type.toLowerCase()})`
++  }
++
++  return `${item.topic} (${start})`
++}
++
++exports.getIcon = (item) => {
++  if (item.file_type) {
++    return null
++  }
++  return ICONS.FOLDER
++}
++
++exports.getMimeType = (item) => {
++  if (item.file_type) {
++    return MIMETYPES[item.file_type]
++  }
++  return null
++}
++
++exports.getId = (item) => {
++  let id = `${encodeURIComponent(item.id)}`
++  if (item.file_type) {
++    id = `${item.meeting_id}?recordingId=${id}`
++  }
++  return id
++}
++
++exports.getRequestPath = (item) => {
++  if (item.file_type && item.file_type === 'TIMELINE') {
++    return `${encodeURIComponent(item.meeting_id)}?recordingId=TIMELINE`
++  } else if (item.file_type) {
++    return `${encodeURIComponent(item.meeting_id)}?recordingId=${encodeURIComponent(item.id)}`
++  }
++  return `${encodeURIComponent(item.id)}`
++}
++
++exports.getStartDate = (item) => {
++  return item.start_time",should this function return `recording_start` (or `recording_end`) in the case of recordings?,2020-07-13 11:01:29
+817,"@@ -0,0 +1,114 @@
++const qs = require('qs')
++const moment = require('moment')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/vtt',
++  CC: 'text/vtt',
++  TIMELINE: 'application/json'
++}
++const ICONS = {
++  MP4: 'video',
++  M4A: 'audio',
++  CHAT: 'text',
++  TRANSCRIPT: 'text',
++  CC: 'text',
++  FOLDER: 'folder'
++}
++
++exports.getDateName = (start, end) => {
++  return `${start.format('YYYY-MM-DD')} - ${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderId = (start, end) => {
++  return `dates=${start.format('YYYY-MM-DD')}_${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderRequestPath = (start, end) => {
++  return `?from=${start.format('YYYY-MM-DD')}&to=${end.format('YYYY-MM-DD')}`
++}
++
++exports.getDateFolderModified = (end) => {
++  return end.format('YYYY-MM-DD')
++}
++
++exports.getDateQuery = (start) => {
++  return `?${qs.stringify({ cursor: start.subtract(1, 'days').format('YYYY-MM-DD') })}`
++}
++
++exports.getQuery = (results) => {
++  if (results.next_page_token) {
++    return `?${qs.stringify({
++      cursor: results.next_page_token || '',
++      from: results.from,
++      to: results.to
++    })}`
++  }
++  return null
++}
++// we rely on the file_type attribute to differentiate a recording file from other items
++exports.getIsFolder = (item) => {
++  return !item.file_type
++}
++
++exports.getItemName = (item) => {
++  const start = moment(item.start_time || item.recording_start)
++    .clone()
++    .format('YYYY-MM-DD, kk:mm')
++
++  if (item.file_type) {
++    const itemType = item.recording_type ? ` - ${item.recording_type.split('_').join(' ')}` : ''
++    return `${start}${itemType} (${item.file_type.toLowerCase()})`
++  }
++
++  return `${item.topic} (${start})`
++}
++
++exports.getIcon = (item) => {
++  if (item.file_type) {
++    return null
++  }
++  return ICONS.FOLDER
++}
++
++exports.getMimeType = (item) => {
++  if (item.file_type) {
++    return MIMETYPES[item.file_type]
++  }
++  return null
++}
++
++exports.getId = (item) => {
++  let id = `${encodeURIComponent(item.id)}`
++  if (item.file_type) {
++    id = `${item.meeting_id}?recordingId=${id}`
++  }
++  return id
++}
++
++exports.getRequestPath = (item) => {
++  if (item.file_type && item.file_type === 'TIMELINE') {
++    return `${encodeURIComponent(item.meeting_id)}?recordingId=TIMELINE`
++  } else if (item.file_type) {
++    return `${encodeURIComponent(item.meeting_id)}?recordingId=${encodeURIComponent(item.id)}`
++  }
++  return `${encodeURIComponent(item.id)}`
++}
++
++exports.getStartDate = (item) => {
++  return item.start_time
++}
++
++exports.getSize = (item) => {
++  return item.file_size
++}
++
++exports.getCustomFields = (item) => {
++  return {
++    recordTrueId: item.id,
++    requestDownloadUrl: item.download_url,
++    recordingDate: item.recording_start
++  }",seems like we don't need this anymore right?,2020-07-13 08:46:33
+789,"@@ -0,0 +1,116 @@
++const request = require('request')
++const BASE_URL = 'https://zoom.us/v2'
++
++/**
++ * an example of a custom provider module. It implements @uppy/companion's Provider interface
++ */
++class ZoomProvider {
++  constructor (options) {
++    this.authProvider = ZoomProvider.authProvider
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  // /users/{userId}/recordings
++  list ({ token, query }, done) {
++    const path = '/users/me/recordings'
++    const options = {
++      url: `${BASE_URL}${path}`,
++      method: 'GET',
++      json: true,
++      headers: {
++        Authorization: `Bearer ${token}`
++      }
++    }
++
++    request(options, (err, resp, body) => {
++      if (err) {
++        console.log(err)
++        done(err)
++        return
++      }
++      done(null, this._adaptData(body))
++    })
++  }
++
++  download ({ id, token }, onData) {
++    const downloadUrl = id","I assumed this gets invoked when files get downloaded from source / uploaded to the destination. What's the best way to test this locally? I""m guessing i would need to attach a file destination or processing plugin and confirm this works independently, is this correct?  
+
+Likewise, I wasn't sure what the best way to pass additional data back to the UI and back to the download function heres was. The download URL gets returns as part of the `list` request, so I just assigned it to the ID parameter since it appeared that this was getting passed around automatically. ",2020-06-25 20:12:40
+790,"@@ -0,0 +1,116 @@
++const request = require('request')
++const BASE_URL = 'https://zoom.us/v2'
++
++/**
++ * an example of a custom provider module. It implements @uppy/companion's Provider interface
++ */
++class ZoomProvider {
++  constructor (options) {
++    this.authProvider = ZoomProvider.authProvider
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  // /users/{userId}/recordings
++  list ({ token, query }, done) {
++    const path = '/users/me/recordings'
++    const options = {
++      url: `${BASE_URL}${path}`,
++      method: 'GET',
++      json: true,
++      headers: {
++        Authorization: `Bearer ${token}`
++      }
++    }
++
++    request(options, (err, resp, body) => {
++      if (err) {
++        console.log(err)
++        done(err)
++        return
++      }
++      done(null, this._adaptData(body))
++    })
++  }
++
++  download ({ id, token }, onData) {
++    const downloadUrl = id
++    const options = {
++      url: downloadUrl,
++      method: 'GET',
++      json: true,
++      headers: {
++        Authorization: `Bearer ${token}`
++      }
++    }
++
++    request(options, (err, resp, body) => {
++      if (err) {
++        console.log(err)
++        return
++      }
++      // how can I test this?
++      const url = body.links.download
++      request.get(url)
++        .on('data', (chunk) => onData(null, chunk))
++        .on('end', () => onData(null, null))
++        .on('error', (err) => console.log(err))
++    })
++  }
++
++  _adaptData (res) {
++    const nextPagePath = res && res.nextPagePath ? `/users/me/recordings&next_page_token=${res.nextPagePath}` : ''
++
++    const data = {
++      username: null,
++      items: [],
++      nextPagePath
++    }
++
++    if (res.meetings) {
++      res.meetings.forEach(meeting => {
++        meeting.recording_files.filter(record => record.file_type === 'MP4').forEach((record, index) => {
++          data.items.push({
++            isFolder: undefined,
++            icon: '',
++            name: `${meeting.topic}_${record.recording_start}${index > 0 ? `_pt_${index + 1}` : ''}`,
++            mimeType: 'video/mp4',
++            id: record.download_path,
++            thumbnail: '',
++            requestPath: record.download_url,
++            modifiedDate: record.recording_start,
++            size: record.file_size,
++            custom: {
++              recordTrueId: record.id
++            }
++          })
++        })
++      })
++    }
++    return data
++  }
++
++  logout ({ token }, done) {",I noticed that the token expiry between uppy didn't seem to match token expiry on the custom provider side (ie the token expires with Zoom before the Uppy token expires). Is there a configuration somewhere that I should be setting this with Uppy?,2020-06-26 14:02:35
+638,"@@ -0,0 +1,12 @@
++const { h } = require('preact')
++const formatSeconds = require('./formatSeconds')
++
++module.exports = function RecordingLength ({ recordingLengthSeconds }) {
++  const formattedRecordingLengthSeconds = formatSeconds(recordingLengthSeconds)
++
++  return (
++    <div class=""uppy-Webcam-recordingLength"" title={formattedRecordingLengthSeconds} aria-label={formattedRecordingLengthSeconds}>","Ideally `aria-label` should say `Recording length 1:25`. We’d need a `Recording length: {number}` string added to Webcam’s `i18n`, please see: https://github.com/transloadit/uppy/blob/895498815718cf3ef4245593e176f0ccc6503fc3/packages/%40uppy/core/src/index.js#L53 and https://github.com/transloadit/uppy/blob/895498815718cf3ef4245593e176f0ccc6503fc3/packages/%40uppy/core/src/index.js#L830
+
+Title should probably just say “Recording length”, since the number is visually available. We could also omit the `title` altogether, because if we keep it, we’ll have to add 2 `i18n` strings — one with the number, other without the number.",2019-11-26 17:54:20
+791,"@@ -0,0 +1,123 @@
++const request = require('request')
++// const { data } = require('autoprefixer')
++const BASE_URL = 'https://zoom.us/v2'
++
++/**
++ * an example of a custom provider module. It implements @uppy/companion's Provider interface
++ */
++class ZoomProvider {
++  constructor (options) {
++    this.authProvider = ZoomProvider.authProvider
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  // /users/{userId}/recordings
++  list ({ token, query }, done) {
++    const path = '/users/me/recordings'",I'm noticing that zoom defaults to only returning content from the last day unless there's a longer date range specified (up to 1 month). Do any of the other providers have similar restrictions / how is this handled? Is there also a limit with Uppy on the number of items we can return / display? Zoom sets this at 300 but that seems like a lot? ,2020-06-26 16:46:54
+24,"@@ -0,0 +1,128 @@
++import Plugin from '../Plugin'
++import 'whatwg-fetch'
++import html from '../../core/html'
++
++import Provider from '../../uppy-base/src/plugins/Provider'
++
++import View from '../../generic-provider-views/index'
++import icons from './icons'
++
++export default class Dropbox extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.type = 'acquirer'
++    this.id = 'Dropbox'
++    this.title = 'Dropbox'
++    this.stateId = 'dropbox'
++    this.icon = html`
++      <svg class=""UppyIcon UppyModalTab-icon"" viewBox=""0 0 225.000000 225.000000"">
++        <g transform=""translate(0.000000,225.000000) scale(0.100000,-0.100000)"" fill=""#000000"" stroke=""none"">
++        <path d=""M633 1646 c-112 -72 -203 -134 -203 -137 0 -3 61 -54 135 -113 74 -59 135 -111 135 -116 0 -5 -61 -57
++        -135 -116 -74 -59 -135 -110 -135 -113 1 -7 391 -261 403 -262 5 -1 72 52 149 116 l141 118 -54 33 c-30 18 -123 75
++        -206 126 -84 51 -153 95 -153 98 0 3 69 47 153 98 83 51 176 108 206 126 l53 33 -123 103 c-68 57 -133 111 -144
++        121 -19 16 -27 12 -222 -115z""/>
++        <path d=""M1271 1657 l-143 -120 53 -33 c30 -18 123 -75 206 -126 84 -51 153 -95 153 -98 0 -3 -69 -47 -153 -98 -83
++        -51 -176 -108 -206 -126 l-54 -33 139 -116 c77 -64 142 -117 145 -119 8 -3 408 254 409 263 0 3 -61 54 -135 113 -74
++        59 -135 111 -135 116 0 5 61 57 135 116 74 59 135 110 135 113 0 3 -51 39 -113 78 -61 40 -153 99 -202 132 l-91 58
++        -143 -120z""/>
++        <path d=""M981 849 c-159 -132 -141 -127 -228 -67 l-43 29 0 -44 0 -45 207 -123 c114 -68 210 -123 213 -122 4 1 98 57
++        209 123 l201 121 0 45 0 45 -61 -41 c-52 -36 -62 -40 -77 -28 -9 7 -69 56 -132 108 -63 52 -122 100 -130 107
++        -13 10 -40 -9 -159 -108z""/>
++        </g>
++      </svg>`
++
++    this[this.id] = new Provider({",`this[this.id]` confuses me a little. will it get turned into `this.Dropbox` in this case?,2016-12-20 05:32:59
+25,"@@ -0,0 +1,128 @@
++import Plugin from '../Plugin'
++import 'whatwg-fetch'
++import html from '../../core/html'
++
++import Provider from '../../uppy-base/src/plugins/Provider'
++
++import View from '../../generic-provider-views/index'
++import icons from './icons'
++
++export default class Dropbox extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.type = 'acquirer'
++    this.id = 'Dropbox'
++    this.title = 'Dropbox'
++    this.stateId = 'dropbox'
++    this.icon = html`
++      <svg class=""UppyIcon UppyModalTab-icon"" viewBox=""0 0 225.000000 225.000000"">
++        <g transform=""translate(0.000000,225.000000) scale(0.100000,-0.100000)"" fill=""#000000"" stroke=""none"">
++        <path d=""M633 1646 c-112 -72 -203 -134 -203 -137 0 -3 61 -54 135 -113 74 -59 135 -111 135 -116 0 -5 -61 -57
++        -135 -116 -74 -59 -135 -110 -135 -113 1 -7 391 -261 403 -262 5 -1 72 52 149 116 l141 118 -54 33 c-30 18 -123 75
++        -206 126 -84 51 -153 95 -153 98 0 3 69 47 153 98 83 51 176 108 206 126 l53 33 -123 103 c-68 57 -133 111 -144
++        121 -19 16 -27 12 -222 -115z""/>
++        <path d=""M1271 1657 l-143 -120 53 -33 c30 -18 123 -75 206 -126 84 -51 153 -95 153 -98 0 -3 -69 -47 -153 -98 -83
++        -51 -176 -108 -206 -126 l-54 -33 139 -116 c77 -64 142 -117 145 -119 8 -3 408 254 409 263 0 3 -61 54 -135 113 -74
++        59 -135 111 -135 116 0 5 61 57 135 116 74 59 135 110 135 113 0 3 -51 39 -113 78 -61 40 -153 99 -202 132 l-91 58
++        -143 -120z""/>
++        <path d=""M981 849 c-159 -132 -141 -127 -228 -67 l-43 29 0 -44 0 -45 207 -123 c114 -68 210 -123 213 -122 4 1 98 57
++        209 123 l201 121 0 45 0 45 -61 -41 c-52 -36 -62 -40 -77 -28 -9 7 -69 56 -132 108 -63 52 -122 100 -130 107
++        -13 10 -40 -9 -159 -108z""/>
++        </g>
++      </svg>`
++
++    this[this.id] = new Provider({
++      host: this.opts.host,
++      provider: 'dropbox'
++    })
++
++    this.files = []
++
++    // Visual
++    this.render = this.render.bind(this)
++
++    // set default options
++    const defaultOptions = {}
++
++    // merge default options with the ones set by user
++    this.opts = Object.assign({}, defaultOptions, opts)
++  }
++
++  install () {
++    this.view = new View(this)
++    // Set default state
++    this.core.setState({
++      [this.stateId]: {","`[this.stateId]` same thing here, hard to understand from the first look, but it might be just me",2016-12-20 05:33:54
+681,"@@ -0,0 +1,129 @@
++const http = require('http')
++const https = require('https')
++const dns = require('dns')
++const ipAddress = require('ip-address')
++
++function isIPAddress (address) {
++  const addressAsV6 = new ipAddress.Address6(address)
++  const addressAsV4 = new ipAddress.Address4(address)
++  return addressAsV6.isValid() || addressAsV4.isValid()
++}
++
++/**
++ * Determine if a IP address provided is a private one.
++ * Return TRUE if it's the case, FALSE otherwise.
++ * Excerpt from:
++ * https://cheatsheetseries.owasp.org/cheatsheets/Server_Side_Request_Forgery_Prevention_Cheat_Sheet.html#case-2---application-can-send-requests-to-any-external-ip-address-or-domain-name
++ *
++ * @param {string} ipAddress the ip address to validate
++ * @returns {boolean}
++ */
++function isPrivateIP (ipAddress) {
++  let isPrivate = false
++  // Build the list of IP prefix for V4 and V6 addresses
++  const ipPrefix = []
++  // Add prefix for loopback addresses
++  ipPrefix.push('127.')
++  ipPrefix.push('0.')
++  // Add IP V4 prefix for private addresses
++  // See https://en.wikipedia.org/wiki/Private_network
++  ipPrefix.push('10.')","I don't believe this to be correct, i think there are actual WAN addresses that start with 10 and the 10. range should be more discriminatory",2020-02-24 12:10:08
+737,"@@ -0,0 +1,13 @@
++class NetworkError extends Error {
++  constructor (error = null, xhr = null) {","I understand why `xhr = null`, but I think adding `error = null` implies that this method should work even if we don't pass the `error` argument. Should we remove it?",2020-04-16 02:43:44
+741,"@@ -0,0 +1,13 @@
++class NetworkError extends Error {
++  constructor (error = null, xhr = null) {
++    super(error.message)","is there a reason we are not setting  `""This looks like a network error ...""` as the primary message instead? And append the source error? Something like this:
+
+```js
+super(`This looks like a network error, the endpoint might be blocked by an ISP or a firewall. Source error [${error}]`)
+```
+
+That way, we won't have to worry about the punctuation and the concatenation done below `error.message + '. This looks ...'` which can be error prone for some error messages that already contain a period '.', or for cases where `error` is `null`.",2020-04-17 12:26:30
+738,"@@ -0,0 +1,13 @@
++class NetworkError extends Error {
++  constructor (error = null, xhr = null) {
++    super(error.message)
++
++    this.isNetworkError = true
++    this.originalRequest = xhr","Do we need the `xhr` argument & setting `.originalRequest` here?
+`xhr` is never passed, `.originalRequest` is never used & we assign `error.request = xhr` in most places anyway.",2020-04-16 04:22:08
+210,"@@ -0,0 +1,133 @@
++const Plugin = require('../../core/Plugin')
++const { h } = require('preact')
++const Provider = require('../Provider')
++// const Utils = require('../../core/Utils')
++require('whatwg-fetch')
++
++/**
++ * Link
++ *
++ */
++module.exports = class Link extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.id = this.opts.id || 'Url'
++    this.title = 'Link'
++    this.type = 'acquirer'","I think we should consider not hardcoding these plugin types.
+
+We could have `core.types = {ACQUIRER: 'acquirer', ...}`
+
+then in our plugin we do:
+`this.type = core.types.ACQUIRER`
+
+it might be easier to maintain that way. Especially with custom plugins created outside this project.
+
+what do you think?",2018-02-03 10:31:39
+211,"@@ -0,0 +1,133 @@
++const Plugin = require('../../core/Plugin')
++const { h } = require('preact')
++const Provider = require('../Provider')
++// const Utils = require('../../core/Utils')
++require('whatwg-fetch')
++
++/**
++ * Link
++ *
++ */
++module.exports = class Link extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.id = this.opts.id || 'Url'
++    this.title = 'Link'
++    this.type = 'acquirer'
++    this.icon = () => <svg aria-hidden=""true"" class=""UppyIcon UppyModalTab-icon"" width=""64"" height=""64"" viewBox=""0 0 64 64"">
++      <circle cx=""32"" cy=""32"" r=""31"" />
++      <g fill-rule=""nonzero"" fill=""#FFF"">
++        <path d=""M25.774 47.357a4.077 4.077 0 0 1-5.76 0L16.9 44.24a4.076 4.076 0 0 1 0-5.758l5.12-5.12-1.817-1.818-5.12 5.122a6.651 6.651 0 0 0 0 9.392l3.113 3.116a6.626 6.626 0 0 0 4.699 1.943c1.7 0 3.401-.649 4.697-1.943l10.241-10.243a6.591 6.591 0 0 0 1.947-4.696 6.599 6.599 0 0 0-1.947-4.696l-3.116-3.114-1.817 1.817 3.116 3.114a4.045 4.045 0 0 1 1.194 2.88 4.045 4.045 0 0 1-1.194 2.878L25.774 47.357z"" />
++        <path d=""M46.216 14.926a6.597 6.597 0 0 0-4.696-1.946h-.001a6.599 6.599 0 0 0-4.696 1.945L26.582 25.167a6.595 6.595 0 0 0-1.947 4.697 6.599 6.599 0 0 0 1.946 4.698l3.114 3.114 1.818-1.816-3.114-3.114a4.05 4.05 0 0 1-1.194-2.882c0-1.086.424-2.108 1.194-2.878L38.64 16.744a4.042 4.042 0 0 1 2.88-1.194c1.089 0 2.11.425 2.88 1.194l3.114 3.114a4.076 4.076 0 0 1 0 5.758l-5.12 5.12 1.818 1.817 5.12-5.122a6.649 6.649 0 0 0 0-9.393l-3.113-3.114-.003.002z"" />
++      </g>
++    </svg>
++
++    // set default options
++    const defaultOptions = {}
++
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.hostname = this.opts.host
++
++    // Bind all event handlers for referencability
++    ;['getMeta', 'handleClick'].forEach(method => {
++      this[method] = this[method].bind(this)
++    })
++
++    this[this.id] = new Provider(uppy, {","yeah, I'm at crossroads with this one. Here are a few thoughts I have:
+
+1. I think we should consider removing [plugins/Provider](https://github.com/transloadit/uppy/tree/master/src/plugins/Provider) from the plugins folder, because it is not a plugin. And it's the only defaulter there. Maybe we should move it to core? Or somewhere else?
+
+2. Even if we do move [plugins/Provider](https://github.com/transloadit/uppy/tree/master/src/plugins/Provider) to a separate folder, I think its use doesn't apply to the `URL` plugin. I don't consider the URL a Provider because, for GoogleDrive, Dropbox, etc, we have a definite source (aka Provider) they connect to (e.g drive.google.com for GoogleDrive). So the expected behavior can be managed for each Provider.
+
+But for URLs, it would be connecting to different sources (depending on the URL provided), from which we can expect different behaviors (e.g some may require authorization headers etc). So it might be tricky to squeeze that into a Provider. Instead maybe we should have URL stand as a separate plugin and not considered it a Provider type.
+
+3. That said, I think we need a separate module that manages communication with uppy-server. So instead of just [plugins/Provider](https://github.com/transloadit/uppy/tree/master/src/plugins/Provider) which does it right now. We can have a folder structure like this:
+
+```
+ ServerBridge(or a better name)
+      --- Provider
+      --- ApiCalls (or whatever)
+```
+
+where plugins like google drive can go on to use `Provider`, while plugins like URL, S3 can just use ApiCalls directly. And then going back to suggestion **1.** we could move `ServerBridge` to `Core` or make it standalone.
+
+What do you think? I hope I made sense 😄 ",2018-02-03 11:13:35
+212,"@@ -0,0 +1,133 @@
++const Plugin = require('../../core/Plugin')
++const { h } = require('preact')
++const Provider = require('../Provider')
++// const Utils = require('../../core/Utils')
++require('whatwg-fetch')
++
++/**
++ * Link
++ *
++ */
++module.exports = class Link extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.id = this.opts.id || 'Url'
++    this.title = 'Link'
++    this.type = 'acquirer'
++    this.icon = () => <svg aria-hidden=""true"" class=""UppyIcon UppyModalTab-icon"" width=""64"" height=""64"" viewBox=""0 0 64 64"">
++      <circle cx=""32"" cy=""32"" r=""31"" />
++      <g fill-rule=""nonzero"" fill=""#FFF"">
++        <path d=""M25.774 47.357a4.077 4.077 0 0 1-5.76 0L16.9 44.24a4.076 4.076 0 0 1 0-5.758l5.12-5.12-1.817-1.818-5.12 5.122a6.651 6.651 0 0 0 0 9.392l3.113 3.116a6.626 6.626 0 0 0 4.699 1.943c1.7 0 3.401-.649 4.697-1.943l10.241-10.243a6.591 6.591 0 0 0 1.947-4.696 6.599 6.599 0 0 0-1.947-4.696l-3.116-3.114-1.817 1.817 3.116 3.114a4.045 4.045 0 0 1 1.194 2.88 4.045 4.045 0 0 1-1.194 2.878L25.774 47.357z"" />
++        <path d=""M46.216 14.926a6.597 6.597 0 0 0-4.696-1.946h-.001a6.599 6.599 0 0 0-4.696 1.945L26.582 25.167a6.595 6.595 0 0 0-1.947 4.697 6.599 6.599 0 0 0 1.946 4.698l3.114 3.114 1.818-1.816-3.114-3.114a4.05 4.05 0 0 1-1.194-2.882c0-1.086.424-2.108 1.194-2.878L38.64 16.744a4.042 4.042 0 0 1 2.88-1.194c1.089 0 2.11.425 2.88 1.194l3.114 3.114a4.076 4.076 0 0 1 0 5.758l-5.12 5.12 1.818 1.817 5.12-5.122a6.649 6.649 0 0 0 0-9.393l-3.113-3.114-.003.002z"" />
++      </g>
++    </svg>
++
++    // set default options
++    const defaultOptions = {}
++
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.hostname = this.opts.host
++
++    // Bind all event handlers for referencability
++    ;['getMeta', 'handleClick'].forEach(method => {
++      this[method] = this[method].bind(this)
++    })
++
++    this[this.id] = new Provider(uppy, {
++      host: this.opts.host,
++      provider: 'url',
++      authProvider: 'url'
++    })
++  }
++
++  getMeta (url) {
++    return fetch(`${this.hostname}/url/meta`, {","based on my suggestion **2.** and **3.** above, we can have this `fetch` done in `ApiCalls`",2018-02-03 11:15:52
+213,"@@ -0,0 +1,133 @@
++const Plugin = require('../../core/Plugin')
++const { h } = require('preact')
++const Provider = require('../Provider')
++// const Utils = require('../../core/Utils')
++require('whatwg-fetch')
++
++/**
++ * Link
++ *
++ */
++module.exports = class Link extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.id = this.opts.id || 'Url'
++    this.title = 'Link'
++    this.type = 'acquirer'
++    this.icon = () => <svg aria-hidden=""true"" class=""UppyIcon UppyModalTab-icon"" width=""64"" height=""64"" viewBox=""0 0 64 64"">
++      <circle cx=""32"" cy=""32"" r=""31"" />
++      <g fill-rule=""nonzero"" fill=""#FFF"">
++        <path d=""M25.774 47.357a4.077 4.077 0 0 1-5.76 0L16.9 44.24a4.076 4.076 0 0 1 0-5.758l5.12-5.12-1.817-1.818-5.12 5.122a6.651 6.651 0 0 0 0 9.392l3.113 3.116a6.626 6.626 0 0 0 4.699 1.943c1.7 0 3.401-.649 4.697-1.943l10.241-10.243a6.591 6.591 0 0 0 1.947-4.696 6.599 6.599 0 0 0-1.947-4.696l-3.116-3.114-1.817 1.817 3.116 3.114a4.045 4.045 0 0 1 1.194 2.88 4.045 4.045 0 0 1-1.194 2.878L25.774 47.357z"" />
++        <path d=""M46.216 14.926a6.597 6.597 0 0 0-4.696-1.946h-.001a6.599 6.599 0 0 0-4.696 1.945L26.582 25.167a6.595 6.595 0 0 0-1.947 4.697 6.599 6.599 0 0 0 1.946 4.698l3.114 3.114 1.818-1.816-3.114-3.114a4.05 4.05 0 0 1-1.194-2.882c0-1.086.424-2.108 1.194-2.878L38.64 16.744a4.042 4.042 0 0 1 2.88-1.194c1.089 0 2.11.425 2.88 1.194l3.114 3.114a4.076 4.076 0 0 1 0 5.758l-5.12 5.12 1.818 1.817 5.12-5.122a6.649 6.649 0 0 0 0-9.393l-3.113-3.114-.003.002z"" />
++      </g>
++    </svg>
++
++    // set default options
++    const defaultOptions = {}
++
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.hostname = this.opts.host
++
++    // Bind all event handlers for referencability
++    ;['getMeta', 'handleClick'].forEach(method => {
++      this[method] = this[method].bind(this)
++    })
++
++    this[this.id] = new Provider(uppy, {
++      host: this.opts.host,
++      provider: 'url',
++      authProvider: 'url'
++    })
++  }
++
++  getMeta (url) {
++    return fetch(`${this.hostname}/url/meta`, {
++      method: 'post',
++      credentials: 'include',
++      headers: {
++        'Accept': 'application/json',
++        'Content-Type': 'application/json'
++      },
++      body: JSON.stringify({
++        url: url
++      })
++    })
++    .then(this[this.id].onReceiveResponse)
++    .then((res) => res.json())
++  }
++
++  getFileNameFromUrl (url) {
++    return url.substring(url.lastIndexOf('/') + 1)
++  }
++
++  addFile (url) {
++    this.getMeta(url).then((meta) => {
++      const tagFile = {
++        source: this.id,
++        name: this.getFileNameFromUrl(url),
++        type: meta.type,
++        data: {
++          size: meta.size
++        },
++        isRemote: true,
++        body: {
++          url: url
++        },
++        remote: {
++          host: this.opts.host,
++          url: `${this.hostname}/url/get`,
++          body: {
++            fileId: url,
++            url: url
++          }
++        }
++      }
++
++      this.uppy.log('[Url] Adding remote file')
++      this.uppy.addFile(tagFile)
++        .then(() => {
++          const dashboard = this.uppy.getPlugin('Dashboard')
++          if (dashboard) dashboard.hideAllPanels()
++        })
++    })
++  }
++
++  handleClick () {
++    this.addFile(this.input.value)
++  }
++
++  render (state) {
++    return <div class=""uppy-Url"">
++      <input","I think if this view is not re-usable by any other plugin, then we can leave this as is, and no need to fuse this with [Provider/view](https://github.com/transloadit/uppy/tree/master/src/plugins/Provider/view).",2018-02-03 11:19:55
+995,"@@ -0,0 +1,133 @@
++const { Plugin } = require('@uppy/core')
++const getDroppedFiles = require('@uppy/utils/lib/getDroppedFiles')
++const toArray = require('@uppy/utils/lib/toArray')
++
++/**
++ * Drop Target plugin
++ *
++ */
++module.exports = class DropTarget extends Plugin {
++  static VERSION = require('../package.json').version
++
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.type = 'acquirer'
++    this.id = this.opts.id || 'DropTarget'
++    this.title = 'Drop Target'
++
++    // Default options
++    const defaultOpts = {
++      target: null,
++    }
++
++    // Merge default options with the ones set by user
++    this.opts = { ...defaultOpts, ...opts }
++    this.removeDragOverClassTimeout = null
++  }
++
++  addFiles = (files) => {
++    const descriptors = files.map((file) => ({
++      source: this.id,
++      name: file.name,
++      type: file.type,
++      data: file,
++      meta: {
++        // path of the file relative to the ancestor directory the user selected.
++        // e.g. 'docs/Old Prague/airbnb.pdf'
++        relativePath: file.relativePath || null,
++      },
++    }))
++
++    try {
++      this.uppy.addFiles(descriptors)
++    } catch (err) {
++      this.uppy.log(err)
++    }
++  }
++
++  handleDrop = (event) => {
++    event.preventDefault()
++    event.stopPropagation()
++    clearTimeout(this.removeDragOverClassTimeout)
++
++    // 2. Remove dragover class",The numbering is a little funny in the comments here in `handleDrop()` (has only 2. and 3.) and below in `handleDragOver` (has only 1.).,2021-03-31 11:57:27
+34,"@@ -0,0 +1,135 @@
++const Plugin = require('../Plugin')
++const Client = require('./Client')
++const StatusSocket = require('./Socket')
++
++module.exports = class Transloadit extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.type = 'uploader'
++    this.id = 'Transloadit'
++    this.title = 'Transloadit'
++
++    const defaultOptions = {
++      templateId: null,
++      wait: false
++    }
++
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.prepareUpload = this.prepareUpload.bind(this)
++    this.afterUpload = this.afterUpload.bind(this)
++
++    if (!this.opts.key) {
++      throw new Error('Transloadit: The `key` option is required. ' +
++        'You can find your Transloadit API key at https://transloadit.com/accounts/credentials.')
++    }
++    if (!this.opts.templateId) {
++      throw new Error('Transloadit: The `templateId` option is required. ' +
++        'You can find your template\'s ID at https://transloadit.com/templates.')
++    }
++
++    this.client = new Client({
++      key: this.opts.key
++    })
++  }
++
++  createAssembly () {
++    this.core.log('Transloadit: create assembly')
++
++    return this.client.createAssembly({
++      templateId: this.opts.templateId,
++      expectedFiles: Object.keys(this.core.state.files).length
++    }).then((assembly) => {
++      this.updateState({ assembly })
++
++      function attachAssemblyMetadata (file, assembly) {
++        const meta = Object.assign({}, file.meta, {
++          assembly_url: assembly.assembly_url,
++          filename: file.name,
++          fieldname: 'file'
++        })
++        // Add assembly-specific Tus endpoint.
++        const tus = Object.assign({}, file.tus, {
++          endpoint: assembly.tus_url
++        })
++        return Object.assign(
++          {},
++          file,
++          { meta, tus }
++        )
++      }
++
++      const filesObj = this.core.state.files
++      const files = {}
++      Object.keys(filesObj).forEach((id) => {
++        files[id] = attachAssemblyMetadata(filesObj[id], assembly)
++      })
++
++      this.core.setState({ files })
++
++      if (this.opts.wait) {
++        return this.beginWaiting()
++      }
++    }).catch((err) => {
++      this.core.emit('informer', '⚠️ Transloadit: Could not create assembly', 'error', 0)
++
++      // Reject the promise.
++      throw err
++    })
++  }
++
++  beginWaiting () {
++    this.socket = new StatusSocket(
++      this.state.assembly.websocket_url,
++      this.state.assembly
++    )
++
++    this.assemblyReady = new Promise((resolve, reject) => {
++      this.socket.on('finished', resolve)
++      this.socket.on('error', reject)
++    })
++
++    return new Promise((resolve, reject) => {
++      this.socket.on('connect', resolve)
++      this.socket.on('error', reject)
++    })
++  }
++
++  prepareUpload () {
++    this.core.emit('informer', '🔄 Preparing upload...', 'info', 0)
++    return this.createAssembly().then(() => {
++      this.core.emit('informer:hide')
++    })
++  }
++
++  afterUpload () {
++    this.core.emit('informer', '🔄 Encoding...', 'info', 0)","Right now when the Encoding step starts, you see the progress bar turn green ""100% uploaded"" just before the ""Encoding"" message pops up. This step can also give progress events (one `assembly_result_finished` for each uploaded file), maybe we can integrate the pre- and postprocess steps in the dashboard progress bar to make this a bit nicer.",2017-04-11 11:11:48
+642,"@@ -0,0 +1,136 @@
++/**
++ * Adapted from preact-virtual-list: https://github.com/developit/preact-virtual-list
++ *
++ * © 2016 Jason Miller
++ *
++ * Permission is hereby granted, free of charge, to any person obtaining a copy
++ * of this software and associated documentation files (the ""Software""), to deal
++ * in the Software without restriction, including without limitation the rights
++ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
++ * copies of the Software, and to permit persons to whom the Software is
++ * furnished to do so, subject to the following conditions:
++ *
++ * The above copyright notice and this permission notice shall be included in all
++ * copies or substantial portions of the Software.
++ *
++ * THE SOFTWARE IS PROVIDED ""AS IS"", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
++ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
++ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
++ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
++ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
++ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
++ * SOFTWARE.
++ *
++ * Adaptations:
++ * - Added role=presentation to helper elements
++ * - Tweaked styles for Uppy's Dashboard use case
++ */
++
++const { h, Component } = require('preact')
++
++const STYLE_INNER = {
++  position: 'relative',
++  // Disabled for our use case: the wrapper elements around FileList already deal with overflow,
++  // and this additional property would hide things that we want to show.
++  //
++  // overflow: 'hidden',
++  width: '100%',
++  minHeight: '100%'
++}
++
++const STYLE_CONTENT = {
++  position: 'absolute',
++  top: 0,
++  left: 0,
++  // Because the `top` value gets set to some offset, this `height` being 100% would make the scrollbar
++  // stretch far beyond the content. For our use case, the content div actually can get its height from
++  // the elements inside it, so we don't need to specify a `height` property at all.
++  //
++  // height: '100%',
++  width: '100%',
++  overflow: 'visible'
++}
++
++class VirtualList extends Component {
++  constructor (props) {
++    super(props)
++    this.state = {
++      offset: 0,
++      height: 0
++    }
++  }
++
++  resize = () => {
++    if (this.state.height !== this.base.offsetHeight) {
++      this.setState({
++        height: this.base.offsetHeight
++      })
++    }
++  }
++
++  handleScroll = () => {
++    this.setState({
++      offset: this.base.scrollTop
++    })
++    if (this.props.sync) {
++      this.forceUpdate()
++    }
++  }
++
++  componentDidUpdate () {
++    this.resize()
++  }
++
++  componentDidMount () {
++    this.resize()
++    addEventListener('resize', this.resize)
++  }
++
++  componentWillUnmount () {
++    removeEventListener('resize', this.resize)
++  }
++
++  render ({
++    data,
++    rowHeight,
++    renderRow,
++    overscanCount = 10,
++    sync,
++    ...props
++  }) {
++    const { offset, height } = this.state
++    // first visible row index
++    let start = Math.floor(offset / rowHeight)
++
++    // actual number of visible rows (without overscan)
++    let visibleRowCount = Math.floor(height / rowHeight)
++
++    // Overscan: render blocks of rows modulo an overscan row count
++    // This dramatically reduces DOM writes during scrolling
++    if (overscanCount) {
++      start = Math.max(0, start - (start % overscanCount))
++      visibleRowCount += overscanCount
++    }
++
++    // last visible + overscan row index
++    const end = start + 1 + visibleRowCount
++
++    // data slice currently in viewport plus overscan items
++    const selection = data.slice(start, end)
++
++    const styleInner = { ...STYLE_INNER, height: data.length * rowHeight }
++    const styleContent = { ...STYLE_CONTENT, top: start * rowHeight }
++
++    return (
++      <div onScroll={this.handleScroll} {...props}>
++        <div role=""presentation"" style={styleInner}>
++          <div role=""presentation"" style={styleContent}>","Divs already have no semantics, I believe we don't need to strip them of their semantics with `role=""presentation""`?
+Also - since we inlined VirtualList (good idea), let's change `<div role=""listitem"">` back to `<li>`?",2019-11-30 15:04:28
+143,"@@ -0,0 +1,137 @@
++---
++type: docs
++order: 4
++title: ""Custom Stores""
++permalink: docs/stores/
++---
++
++By default, Uppy stores its internal state in an object.
++If your app uses a state management library such as [Redux](https://redux.js.org), it can be useful to have Uppy store its state there instead—that way, you could write custom uploader UI components in the same way as the other components in the application.
++
++Uppy comes with two state management solutions (stores):
++
++ - `DefaultStore`, a simple object-based store.
++ - `ReduxStore`, a store that uses a key in a Redux store.
++
++## Using Stores
++
++To use a store, pass an instance to the [`store` option](/docs/uppy#store-defaultstore) in the Uppy constructor:
++
++```js
++const defaultStore = require('uppy/lib/store/DefaultStore')
++
++const uppy = Uppy({
++  store: defaultStore()
++})
++```
++
++### `DefaultStore`
++
++Uppy uses the `DefaultStore`…by default! You do not need to do anything to use it.
++It does not take any options.
++
++### `ReduxStore`
++
++The `ReduxStore` stores Uppy state on a key in an existing Redux store.
++The `ReduxStore` dispatches `uppy/STATE_UPDATE` actions to update state.
++When the state in Redux changes, it notifies Uppy.
++This way, you get most of the benefits of Redux, including support for the Redux Devtools and time traveling!
++
++To use the `ReduxStore`, add its reducer to the `uppy` key:
++
++```js
++const ReduxStore = require('uppy/lib/store/ReduxStore')
++const reducer = combineReducers({
++  ...reducers,
++  uppy: ReduxStore.reducer
++})
++```
++
++Then pass a Redux store instance to the Uppy constructor:
++
++```js
++const { createStore } = require('redux')
++const ReduxStore = require('uppy/lib/store/ReduxStore')
++
++const store = createStore(reducer)
++const uppy = Uppy({
++  store: ReduxStore({
++    store: store // That's a lot of stores!
++  })","Yes, but it’s Christmas time and we’ve just passed Black Friday.",2017-11-27 23:50:42
+439,"@@ -0,0 +1,14 @@
++const webkitGetAsEntryApi = require('./utils/webkitGetAsEntryApi')
++const getFilesAndDirectoriesApi = require('./utils/getFilesAndDirectoriesApi')
++const fallbackApi = require('./utils/fallbackApi')
++
++module.exports = function getDroppedFiles (dataTransfer, callback) {
++  if (dataTransfer.items[0] && 'webkitGetAsEntry' in dataTransfer.items[0]) {
++    webkitGetAsEntryApi(dataTransfer, callback)
++  } else if ('getFilesAndDirectories' in dataTransfer) {
++    // Doesn't actually work in firefox, maybe in previous versions. webkitGetAsEntryApi() works.
++    getFilesAndDirectoriesApi(dataTransfer, callback)
++  } else {
++    fallbackApi(dataTransfer, callback)
++  }
++}","I think we should move those util functions that work with drag-drop to @uppy/utils, so they can be shared (maybe later) with drag-drop plugin? Otherwise it will continue to depend on drag-drop module.",2019-04-16 14:33:49
+44,"@@ -0,0 +1,141 @@
++const Plugin = require('../Plugin')
++const StatusBar = require('./StatusBar')
++const { getSpeed } = require('../../core/Utils')
++const { getBytesRemaining } = require('../../core/Utils')
++const { prettyETA } = require('../../core/Utils')
++const prettyBytes = require('prettier-bytes')
++
++/**
++ * A status bar.
++ */
++module.exports = class StatusBarUI extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.id = 'StatusBarUI'
++    this.title = 'StatusBar UI'
++    this.type = 'progressindicator'
++
++    // set default options
++    const defaultOptions = {
++      target: 'body',
++      showProgressDetails: false
++    }
++
++    // merge default options with the ones set by user
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.pauseAll = this.pauseAll.bind(this)
++    this.resumeAll = this.resumeAll.bind(this)
++    this.cancelAll = this.cancelAll.bind(this)
++    this.render = this.render.bind(this)
++    this.install = this.install.bind(this)
++  }
++
++  cancelAll () {
++    this.core.bus.emit('core:cancel-all')
++  }
++
++  pauseAll () {
++    this.core.bus.emit('core:pause-all')
++  }
++
++  resumeAll () {
++    this.core.bus.emit('core:resume-all')
++  }
++
++  getTotalSpeed (files) {
++    let totalSpeed = 0
++    files.forEach((file) => {
++      totalSpeed = totalSpeed + getSpeed(file.progress)
++    })
++    return totalSpeed
++  }
++
++  getTotalETA (files) {
++    const totalSpeed = this.getTotalSpeed(files)
++    if (totalSpeed === 0) {
++      return 0
++    }
++
++    const totalBytesRemaining = files.reduce((total, file) => {
++      return total + getBytesRemaining(file.progress)
++    }, 0)
++
++    return Math.round(totalBytesRemaining / totalSpeed * 10) / 10
++  }
++
++  render (state) {
++    const files = state.files
++
++    const uploadStartedFiles = Object.keys(files).filter((file) => {
++      return files[file].progress.uploadStarted
++    })
++    const completeFiles = Object.keys(files).filter((file) => {
++      return files[file].progress.uploadComplete
++    })
++    const inProgressFiles = Object.keys(files).filter((file) => {
++      return !files[file].progress.uploadComplete &&
++             files[file].progress.uploadStarted &&
++             !files[file].isPaused
++    })
++    const processingFiles = Object.keys(files).filter((file) => {
++      return files[file].progress.preprocess || files[file].progress.postprocess
++    })
++
++    let inProgressFilesArray = []
++    inProgressFiles.forEach((file) => {
++      inProgressFilesArray.push(files[file])
++    })
++
++    const totalSpeed = prettyBytes(this.getTotalSpeed(inProgressFilesArray))
++    const totalETA = prettyETA(this.getTotalETA(inProgressFilesArray))
++
++    // total size and uploaded size
++    let totalSize = 0
++    let totalUploadedSize = 0
++    inProgressFilesArray.forEach((file) => {
++      totalSize = totalSize + (file.progress.bytesTotal || 0)
++      totalUploadedSize = totalUploadedSize + (file.progress.bytesUploaded || 0)
++    })
++    totalSize = prettyBytes(totalSize)
++    totalUploadedSize = prettyBytes(totalUploadedSize)
++
++    const isAllComplete = state.totalProgress === 100 &&
++      completeFiles.length === Object.keys(files).length &&
++      processingFiles.length === 0
++    const isAllPaused = inProgressFiles.length === 0 && !isAllComplete && uploadStartedFiles.length > 0
++    const isUploadStarted = uploadStartedFiles.length > 0
++
++    const resumableUploads = this.core.getState().capabilities.resumableUploads || false
++
++    return StatusBar({
++      error: state.error,
++      totalProgress: state.totalProgress,
++      totalSize: totalSize,
++      totalUploadedSize: totalUploadedSize,
++      uploadStartedFiles: uploadStartedFiles,
++      isAllComplete: isAllComplete,
++      isAllPaused: isAllPaused,
++      isUploadStarted: isUploadStarted,
++      pauseAll: this.pauseAll,
++      resumeAll: this.resumeAll,
++      cancelAll: this.cancelAll,
++      complete: completeFiles.length,
++      inProgress: uploadStartedFiles.length,
++      totalSpeed: totalSpeed,
++      totalETA: totalETA,
++      files: state.files,
++      resumableUploads: resumableUploads
++    })",Everything here is basically a copy-paste job of all the necessary props from the Dashboard.,2017-06-09 18:46:32
+897,"@@ -0,0 +1,151 @@
++---
++title: ""Vue Integration""
++type: docs
++module: ""@uppy/vue""
++permalink: docs/vue/
++order: 0
++category: ""Vue""
++---
++
++Uppy provides [Vue][] components for the included UI plugins.
++
++## Installation
++
++All Vue components are provided through the `@uppy/vue` package
++
++Install from NPM:
++
++```sh
++npm install @uppy/vue
++```
++## CSS
++
++Make sure to also include the necessary CSS files for each Uppy Vue component you are using.
++
++## Usage
++
++The components can be used with [Vue][] and frameworks that use it, like [Nuxt][].
++
++Instead of adding a UI plugin to an Uppy instance with `.use()`, the Uppy instance can be passed into components as an `uppy` prop. 
++
++Note: At the moment, this example is not functional due to an unresolved issue with using other plugins with the Dashboard",Still the case? 🤔 ,2020-09-30 20:21:29
+881,"@@ -0,0 +1,151 @@
++---
++title: ""Vue Integration""
++type: docs
++module: ""@uppy/vue""
++permalink: docs/vue/
++order: 0
++category: ""Vue""
++---
++
++Uppy provides [Vue][] components for the included UI plugins.
++
++## Installation
++
++All Vue components are provided through the `@uppy/vue` package
++
++Install from NPM:
++
++```sh
++npm install @uppy/vue
++```
++## CSS
++
++Make sure to also include the necessary CSS files for each Uppy Vue component you are using.
++
++## Usage
++
++The components can be used with [Vue][] and frameworks that use it, like [Nuxt][].
++
++Instead of adding a UI plugin to an Uppy instance with `.use()`, the Uppy instance can be passed into components as an `uppy` prop. 
++
++Note: At the moment, this example is not functional due to an unresolved issue with using other plugins with the Dashboard
++
++```vue
++<template>
++  <div id=""app"">
++    <Dashboard :uppy=""uppy"" :plugins=""['Webcam']""/>
++  </div>
++</template>
++
++<script>
++import { Dashboard } from '@uppy/vue'
++
++import '@uppy/core/dist/style.css'
++import '@uppy/dashboard/dist/style.css'
++
++import Uppy from '@uppy/core'
++import Webcam from '@uppy/webcam'
++
++export default {
++  name: 'App',
++  components: {
++    Dashboard
++  },
++  computed: {
++    uppy: () => new Uppy().use(Webcam)",Is it guaranteed that this computed property will only be called once? Or else is there some kind of beforeMount() style method that folks could use to create the instance? It's critical that the same instance is used for the entire lifetime of the component.,2020-09-09 08:17:46
+586,"@@ -0,0 +1,152 @@
++const el_GR = {}
++
++el_GR.strings = {
++  addMore: 'Προσθέστε περισσότερα',
++  addMoreFiles: 'Προσθέστε περισσότερα αρχεία',
++  addingMoreFiles: 'Προσθήκη αρχείων',
++  allowAccessDescription: 'Για να βγάλετε φωτογραφίες ή βίντεο με την κάμερά σας, παρακαλούμε επιτρέψτε την πρόσβαση στην κάμερά σας για αυτόν τον ιστότοπο.',
++  allowAccessTitle: 'Παρακαλούμε επιτρέψτε την πρόσβαση στην κάμερά σας',
++  authenticateWith: 'Σύνδεση με %{pluginName}',
++  authenticateWithTitle: 'Παρακαλούμε συνδεθείτε με %{pluginName} για να επιλέξετε αρχεία',
++  back: 'Πίσω',
++  browse: 'Περιήγηση',
++  cancel: 'Άκυρο',
++  cancelUpload: 'Ακύρωση μεταφόρτωσης',
++  chooseFiles: 'Επιλέξτε αρχεία',
++  closeModal: 'Κλείσιμο παραθύρου',
++  companionAuthError: 'Απαιτείται εξουσιοδότηση',
++  companionError: 'Η σύνδεση με το Companion απέτυχε',
++  complete: 'Ολοκληρώθηκε',
++  connectedToInternet: 'Συνδεθήκατε στο Internet',
++  copyLink: 'Αντιγραφή συνδέσμου',
++  copyLinkToClipboardFallback: 'Αντιγραφή του παρακάτω συνδέσμου',
++  copyLinkToClipboardSuccess: 'Ο σύνδεσμος αντιγράφηκε',
++  creatingAssembly: 'Προετοιμασία μεταφόρτωσης...',
++  creatingAssemblyFailed: 'Transloadit: Σφάλμα κατά την προετοιμασία',
++  dashboardTitle: 'Μεταφόρτωση αρχείων',
++  dashboardWindowTitle: 'Παράθυρο μεταφόρτωσης αρχείων (Πατήστε escape για να κλείσει)',
++  dataUploadedOfTotal: '%{complete} από %{total}',
++  done: 'Τέλος',
++  dropHereOr: 'Ρίξτε τα αρχεία εδώ ή %{browse}',
++  dropHint: 'Ρίξτε τα αρχεία σας εδώ',
++  dropPaste: 'Ρίξτε τα αρχεία εδώ, κάντε επικόλληση ή %{browse}',
++  dropPasteImport: 'Ρίξτε αρχεία εδώ, κάντε επικόλληση, %{browse} ή εισαγωγή από',
++  edit: 'Επεξεργασία',
++  editFile: 'Επεξεργασία αρχείου',
++  editing: 'Γίνεται επεξεργασία %{file}',
++  emptyFolderAdded: 'Δεν προστέθηκαν αρχεία από τον άδειο φάκελο',
++  encoding: 'Γίνεται κωδικοποίηση...',
++  enterCorrectUrl: 'Λανθασμένο URL: Παρακαλούμε βεβαιωθείτε ότι εισάγετε έναν άμεσο σύνδεσμο προς κάποιο αρχείο',
++  enterUrlToImport: 'Εισάγετε URL για να γίνει εισαγωγή του αρχείου',
++  exceedsSize: 'Το αρχείο υπερβαίνει το μέγιστο επιτρεπτό όριο που είναι',
++  failedToFetch: 'Δεν ήταν δυνατή η λήψη από το URL, παρακαλούμε βεβαιωθείτε ότι είναι σωστό',
++  failedToUpload: 'Δεν ήταν δυνατή η μεταφόρτωση %{file}',
++  fileSource: 'Πηγή αρχείου: %{name}',
++  filesUploadedOfTotal: {
++    '0': '%{complete} από %{smart_count} αρχεία ανέβηκαν',
++    '1': '%{complete} από %{smart_count} αρχείο ανέβηκε',
++    '2': '%{complete} από %{smart_count} αρχεία ανέβηκαν'
++  },
++  filter: 'Φιλτράρισμα',
++  finishEditingFile: 'Ολοκλήρωση επεξεργασίας αρχείου',
++  folderAdded: {
++    '0': 'Προστέθηκαν %{smart_count} αρχεία από %{folder}',
++    '1': 'Προστέθηκε %{smart_count} αρχείο από %{folder}',
++    '2': 'Προστέθηκαν %{smart_count} αρχεία από %{folder}'
++  },
++  import: 'Εισαγωγή',
++  importFrom: 'Εισαγωγή από %{name}',
++  link: 'Σύνδεσμος',
++  loading: 'Φορτώνει...',
++  logOut: 'Αποσύνδεση',
++  myDevice: 'Η συσκευή μου',
++  noFilesFound: 'Δεν υπάρχουν αρχεία ή φάκελοι εδώ',
++  noInternetConnection: 'Δεν υπάρχει σύνδεση στο Internet',
++  openFolderNamed: 'Άνοιγμα φακέλου %{name}',
++  pause: 'Παύση',
++  pauseUpload: 'Παύση μεταφόρτωσης',
++  paused: 'Έγινε παύση',
++  poweredBy: 'Με τη δύναμη τού',
++  preparingUpload: 'Προετοιμασία μεταφόρτωσης...',
++  processingXFiles: {
++    '0': 'Προετοιμασία %{smart_count} αρχείων',
++    '1': 'Προετοιμασία %{smart_count} αρχείου',
++    '2': 'Προετοιμασία %{smart_count} αρχείων'
++  },
++  removeFile: 'Αφαίρεση αρχείου',
++  resetFilter: 'Επαναφορά φίλτρου',
++  resume: 'Συνέχεια',
++  resumeUpload: 'Συνέχεια μεταφόρτωσης',
++  retry: 'Προσπάθεια ξανά',
++  retryUpload: 'Προσπάθεια μεταφόρτωσης ξανά',
++  saveChanges: 'Αποθήκευση αλλαγών',
++  selectAllFilesFromFolderNamed: 'Επιλογή όλων των αρχείων από τον φάκελο %{name}',
++  selectFileNamed: 'Επιλογή αρχείου %{name}',
++  selectX: {
++    '0': 'Επιλογή %{smart_count}',
++    '1': 'Επιλογή %{smart_count}',
++    '2': 'Επιλογή %{smart_count}'
++  },
++  smile: 'Χαμογελάστε!',
++  startRecording: 'Ξεκίνημα εγγραφής βίντεο',
++  stopRecording: 'Σταμάτημα εγγραφής βίντεο',
++  takePicture: 'Βγάλτε μια φωτογραφία',
++  timedOut: 'Η μεταφόρτωση σταμάτησε για %{seconds} δευτερόλεπτα, γίνεται ακύρωση.',
++  unselectAllFilesFromFolderNamed: 'Αποεπιλογή όλων των αρχείων από τον φάκελο %{name}',
++  unselectFileNamed: 'Αποεπιλογή αρχείου %{name}',
++  upload: 'Μεταφόρτωση',
++  uploadComplete: 'Μεταφόρτωση ολοκληρώθηκε',
++  uploadFailed: 'Μεταφόρτωση απέτυχε',
++  uploadPaused: 'Μεταφόρτωση σε παύση',
++  uploadXFiles: {
++    '0': 'Μεταφόρτωση %{smart_count} αρχείων',
++    '1': 'Μεταφόρτωση %{smart_count} αρχείου',
++    '2': 'Μεταφόρτωση %{smart_count} αρχείων'
++  },
++  uploadXNewFiles: {
++    '0': 'Μεταφόρτωση +%{smart_count} αρχείων',
++    '1': 'Μεταφόρτωση +%{smart_count} αρχείου',
++    '2': 'Μεταφόρτωση +%{smart_count} αρχείων'
++  },
++  uploading: 'Γίνεται μεταφόρτωση',
++  uploadingXFiles: {
++    '0': 'Μεταφορτώνονται %{smart_count} αρχεία',
++    '1': 'Μεταφορτώνεται %{smart_count} αρχείο',
++    '2': 'Μεταφορτώνονται %{smart_count} αρχεία'
++  },
++  xFilesSelected: {
++    '0': '%{smart_count} επιλεγμένα αρχεία',
++    '1': '%{smart_count} επιλεγμένο αρχείο',
++    '2': '%{smart_count} επιλεγμένα αρχεία'
++  },
++  xMoreFilesAdded: {
++    '0': '%{smart_count} ακόμα αρχεία προστέθηκαν',
++    '1': '%{smart_count} ακόμα αρχείο προστέθηκε',
++    '2': '%{smart_count} ακόμα αρχεία προστέθηκαν'
++  },
++  xTimeLeft: '%{time} απομένουν',
++  youCanOnlyUploadFileTypes: 'Μπορείτε να ανεβάσετε μόνο: %{types}',
++  youCanOnlyUploadX: {
++    '0': 'Μπορείτε να ανεβάσετε μόνο %{smart_count} αρχεία',
++    '1': 'Μπορείτε να ανεβάσετε μόνο %{smart_count} αρχείο',
++    '2': 'Μπορείτε να ανεβάσετε μόνο %{smart_count} αρχεία'
++  },
++  youHaveToAtLeastSelectX: {
++    '0': 'Πρέπει να επιλέξετε τουλάχιστον %{smart_count} αρχεία',
++    '1': 'Πρέπει να επιλέξετε τουλάχιστον %{smart_count} αρχείο',
++    '2': 'Πρέπει να επιλέξετε τουλάχιστον %{smart_count} αρχεία'
++  }
++};","```suggestion
+}
+```",2019-08-26 19:37:46
+547,"@@ -0,0 +1,152 @@
++const fi_FI = {}
++
++fi_FI.strings = {
++  addMore: 'Lisää',
++  addMoreFiles: 'Lisää tiedostoja',
++  addingMoreFiles: 'Lisätään tiedostoja',
++  allowAccessDescription: 'Jotta voit ottaa kuvia tai videota kamerallasi, sinun tulee antaa tälle sivustolle oikeus käyttää kameraasi.',
++  allowAccessTitle: 'Salli kameran käyttö, kiitos',
++  authenticateWith: 'Mene %{pluginName}',
++  authenticateWithTitle: '%{pluginName} vaadittu tunnistautumiseen, jotta voit valita tiedostoja',
++  back: 'Takaisin',
++  browse: 'selaa',
++  cancel: 'Peruuta',
++  cancelUpload: 'Peruuta lähetys',
++  chooseFiles: 'Valitse tiedostot',
++  closeModal: 'Sulje ikkuna',
++  companionAuthError: 'Käyttöoikeus vaadittu',
++  companionError: 'Yhdistäminen Companioniin epäonnistui',
++  complete: 'Valmis',
++  connectedToInternet: 'Yhdistetty Internettiin',
++  copyLink: 'Kopioi linkki',
++  copyLinkToClipboardFallback: 'Kopioi alla oleva linkki',
++  copyLinkToClipboardSuccess: 'Linkki kopioitu leikepöydälle',
++  creatingAssembly: 'Valmistellaan lähetystä...',
++  creatingAssemblyFailed: 'Transloadit: Assemblyn luonti epäonnistui',
++  dashboardTitle: 'Tiedoston Lataaja',
++  dashboardWindowTitle: 'Tiedoston latausikkuna (Paina Esc sulkeaksesi)',
++  dataUploadedOfTotal: '%{complete} / %{total}',
++  done: 'Valmis',
++  dropHereOr: 'Pudota tiedostot tähän tai %{browse}',
++  dropHint: 'Pudota tiedostot tähän',
++  dropPaste: 'Pudota tiedostot tähän, liitä tai %{browse}',
++  dropPasteImport: 'Pudota tiedostot tähän, liitä, %{browse} tai tuo',
++  edit: 'Muokkaa',
++  editFile: 'Muokkaa tiedostoa',
++  editing: 'Muokataan %{file}',
++  emptyFolderAdded: 'Ei lisätty tiedostoja tyhjästä kansiosta',
++  encoding: 'Koodataan...',
++  enterCorrectUrl: 'Epäkelpo osoita: Varmista, että osoite osoittaa suoraan tiedostoon',
++  enterUrlToImport: 'Anna osoite tuodaksesi tiedoston',
++  exceedsSize: 'Tiedoston koko ylittää sallitun maksimin',
++  failedToFetch: 'Companion ei voinut ladata tiedostoa osoitteesta, onko osoite varmasti oikea?',
++  failedToUpload: 'Ei voitu lähettää tiedostoa %{file}',
++  fileSource: 'Tiedoston lähde: %{name}',
++  filesUploadedOfTotal: {
++    '0': '%{complete} / %{smart_count} tiedostosta lähetetty',
++    '1': '%{complete} / %{smart_count} tiedostoa lähetetty',
++    '2': '%{complete} / %{smart_count} tiedostoa lähetetty'
++  },
++  filter: 'Suodata',
++  finishEditingFile: 'Lopeta tiedoston muokkaus',
++  folderAdded: {
++    '0': 'Lisätty %{smart_count} tiedosto kansiosta %{folder}',
++    '1': 'Lisätty %{smart_count} tiedostoa kansiosta %{folder}',
++    '2': 'Lisätty %{smart_count} tiedostoa kansiosta %{folder}'
++  },
++  import: 'Tuo',
++  importFrom: 'Tuo kohteesta %{name}',
++  link: 'Linkki',
++  loading: 'Ladataan...',
++  logOut: 'Kirjaudu ulos',
++  myDevice: 'Minun laite',
++  noFilesFound: 'Sinulla ei ole tiedostoja tai kansioita täällä',","Fine to use “sinulla” vs “teillä” here, doesn’t sound rude?",2019-07-10 08:15:47
+558,"@@ -0,0 +1,153 @@
++---
++title: ""Uppy 1.3: Accessibility and performance, new languages""
++date: 2019-08-01
++author: arturi
++image: """"
++published: false
++---
++
++Hi there! We are back after some silence and cooldown following the [Uppy 1.0 release](https://uppy.io/blog/2019/04/1.0/) in the end of April. It was pretty well received by the commnunity and press: we hit front page of Hacker News, [Product Hunt](https://www.producthunt.com/posts/uppy-1-0/) and [Reddit](https://www.reddit.com/r/javascript/comments/bhkx5k/uppy_10_your_best_friend_in_file_uploading/), went trending and gained over 20,000 stargazers on GitHub, got mentioned by [Smashing Magazine](https://mobile.twitter.com/smashingmag/status/1097870169043546112), [JavaScript Daily](https://twitter.com/JavaScriptDaily/status/1122935583603556352) and [JavaScript Weekly](https://javascriptweekly.com/issues/434). Crazy ride! We’d like to thank all our contributors and users for their continued support.
++
++It was not all self-reflection and celebrations in Uppy Remote Headquaters™ past `1.0`. We took a few vacations, and then got back to work, releasing Uppy `1.1`, `1.2` and `1.3`, addressing a lot of issues raised by the community and the team.
++
++This post highlights the most important and exciting changes from those releases.
++
++<!--more-->
++
++## Accessibility
++
++Our new team member, Evgenia, has been on a roll improving accessiblity in Uppy, together with Artur and Alex. Evgenia has come up with something called “superfocus”, that makes sure focus stays on the most relevant button or field in the current view. The `@uppy/provider-views` layouts have been refactored so that checkboxes and labels are accessible. Focus styles have also been improved.
++
++<video alt=""Demo video showing Uppy focus management in action"" muted autoplay loop>
++  <source src=""/images/blog/1.3/uppy-focus-demo.webm"" type=""video/webm"">
++  <source src=""/images/blog/1.3/uppy-focus-demo.mp4"" type=""video/mp4"">
++</video>
++
++Other notable accessiblity fixes and improvements:
++
++* An “Add more” caption near the + button has been added to the desktop version of Uppy
++* “Copy link” & “Edit” links have been replaced with icons
++* All svgs are now not focusable in IE11
++* Pasting works while we’re focused on buttons
++* Focus is not lost when state is updated in filter in provider-views or when editing file meta
++* Selected checkboxes now persist when moving between folders
++
++⚠️ `@uppy/provider-views` translation strings have been moved from Dashboard to Core, this eliminates a dependency of provider-views upon Dashboard [#1712](https://github.com/transloadit/uppy/pull/1712).
++
++See [#1507](https://github.com/transloadit/uppy/pull/1507), [#1574](https://github.com/transloadit/uppy/pull/1574) and [#1656](https://github.com/transloadit/uppy/pull/1656) for more details.
++
++## Dashboard Performance Improvements
++
++Renée attacked performance problems in the Dashboard when adding many hundreds of files. Previously, we naively rerendered the entire file list when _any_ file had a change. Now, only the changed file rerenders:
++
++Before:
++
++![slow](https://user-images.githubusercontent.com/1006268/59605307-ce67f580-910e-11e9-992a-6e0c3c2a7570.gif)
++
++After:
++
++![fast](https://user-images.githubusercontent.com/1006268/59605354-e3dd1f80-910e-11e9-9cb3-1b7339650959.gif)
++
++See [#1671](https://github.com/transloadit/uppy/pull/1671) for more details. As you can see, there are still some laggy interactions—expect more improvements in future releases!
++
++## Logger
++
++We’ve added an option to supply a `logger` object with `debug`, `warn` and `error` methods, so you can use a custom logging solution with Uppy. Check out [the docs](https://uppy.io/docs/uppy/#logger) for more info.
++
++In the future, past 2.0, `logger: Uppy.debugLogger` option is going to replace `debug: true`, the latter is kept for backwards compatibility for now.
++
++⚠️ This already switches to `console.debug` from `console.log` by default, you might need to change settings in your browser’s dev tools to see Uppy logs!
++
++Versions of each Uppy plugin and Core are now also logged for easier debugging.
++
++See [#1661](https://github.com/transloadit/uppy/pull/1661) and [#1640](https://github.com/transloadit/uppy/pull/1640) for more details.
++
++## Thumbnails Rotated Correctly
++
++Before this change, when you added a file to Uppy from a mobile device, you’d sometimes see the preview image sideways. This was because we didn’t account for EXIF rotation metadata when generating thumbnails with `@uppy/thumbnail-generator`. But now, thanks to [@Botz](https://github.com/Botz), we do! See [#1532](https://github.com/transloadit/uppy/pull/1661).
++
++## Progress Improvements
++
++* The Status Bar now shows the correct total size of the upload when some files have already finished, instead of jumping down [#1685](https://github.com/transloadit/uppy/pull/1685).
++* Fixed an issue where progress could jump to bizarrely high values (like 1038%) while uploading files that don’t have a known size (like from Instagram) [#1610](https://github.com/transloadit/uppy/pull/1610).
++* We’ve moved from `prettier-bytes` package into `@uppy/utils`, and divide by `1024` instead of `1000` to justify `KB` vs `kB` [#1732](https://github.com/transloadit/uppy/pull/1732).
++
++## Drag and Drop
++
++* Drag and drop has been refactored internally in both the Dashboard and DragDrop plugins. This means a more robust and cross-browser implementation, with a fancy “drop files here” screen when you drag over the Dashboard.
++* The `@uppy/drag-drop` plugin now renders an entirely clickable DnD area.
++
++![](/images/blog/1.3/drag-drop-focus.png)
++
++See [#1440](https://github.com/transloadit/uppy/pull/1440), [#1565](https://github.com/transloadit/uppy/pull/1565) and [#1633](https://github.com/transloadit/uppy/pull/1633) for more details.
++
++## Uploaders
++
++* xhr-upload: We now send along global metadata when `bundle: true` option is set [#1677](https://github.com/transloadit/uppy/pull/1677).
++* xhr-upload: Type and name are set from file.meta [#1616](https://github.com/transloadit/uppy/pull/1616).
++* aws-s3-multipart: Added metadata support for S3 MultiPart [#1698](https://github.com/transloadit/uppy/pull/1698).
++* aws-s3: Allows overriding of getResponseData() [#1647](https://github.com/transloadit/uppy/pull/1647).
++* aws-s3: Prevents unnecessary delete multiparts request for completed files[#1650](https://github.com/transloadit/uppy/pull/1650).
++* aws-s3: Do not extract keys from empty `fields` [#1569](https://github.com/transloadit/uppy/pull/1569)
++* tus: `metaFields` option has been added to the tus plugin [#1644](https://github.com/transloadit/uppy/pull/1644).
++
++## Localization
++
++Thanks to our amazing contributors, Uppy now speaks: Arabic, Chinese, Dutch, English, Finnish, French, German, Hungarian, Italian, Japanese, Persian, Portuguese, Russian, Serbian, Spanish an Turkish!
++
++More translations are rolling in every month, please [contribute your language](http://localhost:4000/docs/locales/#Contributing-a-new-language).
++
++We’ve also added docs for locales — how to use from NPM and CDN, auto-generated list of languages that are supported already and an invitation to add more [#1553](https://github.com/transloadit/uppy/pull/1553).
++
++Finally, we've fixed an issue that could occur when adding files with names in non-latin alphabets. When adding a file to Uppy, it gets an ID based on several characteristics, like its size and file name. Previously, our ID generation would ignore any non-alphanumeric characters in the file name, which could cause the IDs for different files to clash. Now, those characters are worked into the ID, so that multiple similar files with different non-alphanumeric names can be added. See [#1722](https://github.com/transloadit/uppy/pull/1722).
++
++## Robodog
++
++Robodog is an Uppy-based library that helps you talk to the Transloadit API. Since 1.0, most of the updates have been bugfixes:
++
++- `Robodog.dashboard()` and `Robodog.form()` now pass their options to the `@uppy/dashboard` plugin as advertised.
++- `Robodog.form()` now supports the [`triggerUploadOnSubmit`](/docs/robodog/form/#Separating-Uploads-from-Form-Submission) option from `@uppy/form`.
++- `Robodog.form()` now supports localization of the ""Choose files"" button it adds in the default configuration.
++
++## Build
++
++* Renée split our test runs into multiple jobs on Travis CI, so unit tests, end-to-end tests and other jobs all run in parallel. This lets us identify issues with failing builds quicker, and also slashes total build times by half! 🚀  [#1709](https://github.com/transloadit/uppy/pull/1709)
++* Webdriverio, which we use for end-to-end testing, has been updated to v5. This improves a bunch of things, and adds a lot of `await`s to our tests [#1675](https://github.com/transloadit/uppy/pull/1675).
++* Build dependencies have been upgraded: Babel to v7, Eslint to v5, Jest to v24, Typescript to v3, Postcss to v7 [#1549](https://github.com/transloadit/uppy/pull/1686).
++* Fix tags for docker build #1579
++* New `uploadcdn` and sync version scripts #1586 #1600
++
++## Website and Docs
++
++* Added Community projects — a page with Uppy plugins and integrations developed by the community [#1620](https://github.com/transloadit/uppy/pull/1620). [Add yours](https://github.com/transloadit/uppy/blob/master/website/src/docs/community-projects.md)!
++* Custom plugin [example](http://localhost:4000/docs/writing-plugins/#Example-of-a-custom-plugin) — now you have a reference to look at when writing your own plugin for Uppy [#1623](https://github.com/transloadit/uppy/pull/1623).
++* Added signature authentication to Transloadit example [#1705](https://github.com/transloadit/uppy/pull/1705).
++* Documented Companion’s Auth and Token mechanism (#1540
++* Updated AWS S3 Multipart documentation wrt CORS settings #1539
++
++## Companion
++
++Of course, we didn’t forget `@uppy/companion`, it’s getting more robust with every release:
++
++* ⚠️ We are now sending `uppy-versions` header to Companion, please see [how to avoid errors if you are using Companion but NOT as standalone](https://github.com/transloadit/uppy/pull/1612#issuecomment-515117137) [#1612](https://github.com/transloadit/uppy/pull/1686).
++* Companion now returns mimetypes for Dropbox files (#1599 / @ifedapoolarewaju)
++* Added colors to logs (#1648 / @ifedapoolarewaju)
++* Changed cloud in gcloud-deploy (#1729 / @kiloreux)","should we exclude this one? I think it can be in the changelog but since it is only related to deploying companion.uppy.io, I think it's meaning might be found confusing to users reading the blog post.",2019-08-02 10:56:18
+83,"@@ -0,0 +1,158 @@
++const Plugin = require('../Plugin')
++const Utils = require('../../core/Utils')
++const ServiceWorkerStore = require('./ServiceWorkerStore')
++const IndexedDBStore = require('./IndexedDBStore')
++
++/**
++ * Persistent State
++ *
++ * Helps debug Uppy: loads saved state from localStorage, so when you restart the page,
++ * your state is right where you left off. If something goes wrong, clear uppyState
++ * in your localStorage, using the devTools
++ *
++ */
++module.exports = class RestoreFiles extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.type = 'debugger'
++    this.id = 'RestoreFiles'
++    this.title = 'Restore Files'
++
++    // set default options
++    const defaultOptions = {
++      serviceWorker: false
++    }
++
++    // merge default options with the ones set by user
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    // const Store = this.opts.serviceWorker ? ServiceWorkerStore : IndexedDBStore
++    this.ServiceWorkerStore = this.opts.serviceWorker ? new ServiceWorkerStore(core) : false
++    this.IndexedDBStore = new IndexedDBStore(core)
++
++    this.saveFilesStateToLocalStorage = this.saveFilesStateToLocalStorage.bind(this)
++    this.loadFilesStateFromLocalStorage = this.loadFilesStateFromLocalStorage.bind(this)
++    this.loadFileBlobsFromServiceWorker = this.loadFileBlobsFromServiceWorker.bind(this)
++    this.loadFileBlobsFromIndexedDB = this.loadFileBlobsFromIndexedDB.bind(this)
++    this.onBlobsLoaded = this.onBlobsLoaded.bind(this)
++  }
++
++  loadFilesStateFromLocalStorage () {
++    const savedState = localStorage.getItem('uppyState')
++
++    if (savedState) {
++      this.core.log('Recovered some state from Local Storage')
++      this.core.setState(JSON.parse(savedState))
++    }
++  }
++
++  saveFilesStateToLocalStorage () {
++    const files = JSON.stringify({
++      currentUploads: this.core.state.currentUploads,
++      files: this.core.state.files
++    })
++    localStorage.setItem('uppyState', files)
++  }
++
++  loadFileBlobsFromServiceWorker () {
++    this.ServiceWorkerStore.list().then((blobs) => {
++      console.log(blobs)
++      const numberOfFilesRecovered = Object.keys(blobs).length
++      const numberOfFilesTryingToRecover = Object.keys(this.core.state.files).length
++      if (numberOfFilesRecovered === numberOfFilesTryingToRecover) {
++        this.core.log(`Successfully recovered ${numberOfFilesRecovered} blobs from Service Worker!`)
++        this.core.emit('informer', `Successfully recovered ${numberOfFilesRecovered} files`, 'success', 3000)
++        this.onBlobsLoaded(blobs)
++      } else {
++        this.core.log('Failed to recover blobs from Service Worker, trying IndexedDB now...')
++        this.loadFileBlobsFromIndexedDB()
++      }
++    })
++  }
++
++  loadFileBlobsFromIndexedDB () {
++    this.IndexedDBStore.list().then((blobs) => {
++      const numberOfFilesRecovered = Object.keys(blobs).length
++      if (numberOfFilesRecovered > 0) {
++        this.core.log(`Successfully recovered ${numberOfFilesRecovered} blobs from Indexed DB!`)
++        this.core.emit('informer', `Successfully recovered ${numberOfFilesRecovered} files`, 'success', 3000)
++        return this.onBlobsLoaded(blobs)
++      }
++      this.core.log('Couldn’t recover anything from IndexedDB :(')
++    })
++  }
++
++  onBlobsLoaded (blobs) {
++    window.myblobs = blobs",Should get rid of this before merge ;),2017-08-15 11:32:09
+526,"@@ -0,0 +1,159 @@
++.uppy-DashboardItem-progress {
++  display: none;
++  position: absolute;
++  top: 50%;
++  left: 50%;
++  transform: translate(-50%, -50%);
++  z-index: $zIndex-3;
++  color: $white;
++  text-align: center;
++  width: 120px;
++  transition: all .35 ease;
++
++  > .uppy-DashboardItem-progressIndicator {
++    display: inline-block;
++    width: 38px;
++    height: 38px;
++    opacity: 0.9;
++    cursor: pointer;
++    &:focus{
++      outline: none;
++      svg.UppyIcon-progressCircle circle.bg,
++      svg.retry{
++        fill: lighten($blue, 20%);
++      }
++    }
++  }
++}
++
++svg.UppyIcon-progressCircle {
++  width: 100%;
++  height: 100%;
++  circle.bg {
++    stroke: rgba($white, 0.4);
++    opacity: 0;
++  }
++  circle.progress {
++    stroke: $white;
++    transition: stroke-dashoffset .5s ease-out;
++    opacity: 0;
++  }
++  polygon.play {
++    stroke: $white;
++    fill: $white;
++    opacity: 0;
++    transition: all 0.2s;
++    display: none;
++  }
++  polygon.cancel {
++    fill: $white;
++    opacity: 0;
++    transition: all 0.2s;
++  }
++  g.pause {
++    stroke: $white;
++    fill: $white;
++    opacity: 0;
++    transition: all 0.2s;
++    display: none;
++  }
++  polygon.check {","I personally think `polygon`, `circle` are implementation detail and unnecessarily specific. Tomorrow we might change the SVG icon, and `g` group is not needed.",2019-06-24 16:02:13
+527,"@@ -0,0 +1,159 @@
++.uppy-DashboardItem-progress {
++  display: none;
++  position: absolute;
++  top: 50%;
++  left: 50%;
++  transform: translate(-50%, -50%);
++  z-index: $zIndex-3;
++  color: $white;
++  text-align: center;
++  width: 120px;
++  transition: all .35 ease;
++
++  > .uppy-DashboardItem-progressIndicator {
++    display: inline-block;
++    width: 38px;
++    height: 38px;
++    opacity: 0.9;
++    cursor: pointer;
++    &:focus{
++      outline: none;
++      svg.UppyIcon-progressCircle circle.bg,
++      svg.retry{
++        fill: lighten($blue, 20%);
++      }
++    }
++  }
++}
++
++svg.UppyIcon-progressCircle {
++  width: 100%;
++  height: 100%;
++  circle.bg {
++    stroke: rgba($white, 0.4);
++    opacity: 0;
++  }
++  circle.progress {
++    stroke: $white;
++    transition: stroke-dashoffset .5s ease-out;
++    opacity: 0;
++  }
++  polygon.play {
++    stroke: $white;
++    fill: $white;
++    opacity: 0;
++    transition: all 0.2s;
++    display: none;
++  }
++  polygon.cancel {
++    fill: $white;
++    opacity: 0;
++    transition: all 0.2s;
++  }
++  g.pause {
++    stroke: $white;
++    fill: $white;
++    opacity: 0;
++    transition: all 0.2s;
++    display: none;
++  }
++  polygon.check {
++    opacity: 0;
++    fill: $white;
++    transition: all 0.2s;
++  }
++}
++svg.UppyIcon.retry {
++  fill: $white;
++}
++
++
++// Svg styles that depend upon the state of the file.
++.uppy-DashboardItem.is-complete .uppy-DashboardItem-progress {
++  transform: initial;
++  top: -9px;
++  right: -8px;
++  left: initial;
++  width: auto;
++}
++.uppy-DashboardItem.is-inprogress .uppy-DashboardItem-progress,
++.uppy-DashboardItem.is-complete .uppy-DashboardItem-progress,
++.uppy-DashboardItem.is-error .uppy-DashboardItem-progress {
++  display: block;
++}
++
++.uppy-DashboardItem.is-error .uppy-DashboardItem-progressIndicator {
++  width: 18px;
++  height: 18px;
++
++  .uppy-size--md & {
++    width: 28px;
++    height: 28px;
++  }
++}
++
++.uppy-DashboardItem.is-complete .uppy-DashboardItem-progressIndicator {
++  width: 18px;
++  height: 18px;
++  opacity: 1;
++
++  .uppy-size--md & {
++    width: 22px;
++    height: 22px;
++  }
++}
++
++.uppy-DashboardItem.is-paused svg.UppyIcon-progressCircle {
++  g.pause {
++    opacity: 0;
++  }
++  polygon.play {
++    opacity: 1;
++  }
++}
++
++.uppy-DashboardItem.is-noIndividualCancellation {
++  .uppy-DashboardItem-progressIndicator {
++    cursor: default;
++  }
++
++  polygon.cancel {
++    display: none;
++  }
++}
++
++.uppy-DashboardItem.is-processing .uppy-DashboardItem-progress {
++  opacity: 0;
++}
++
++.uppy-DashboardItem.is-complete {
++  .uppy-DashboardItem-progressIndicator {
++    cursor: default;
++  }
++
++  .progress {",this one is then not tied to the element?,2019-06-24 16:02:53
+365,"@@ -0,0 +1,159 @@
++const request = require('request')
++// @ts-ignore
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const DRIVE_FILE_FIELDS = 'kind,id,name,mimeType,ownedByMe,permissions(role,emailAddress),size,modifiedTime,iconLink,thumbnailLink,teamDriveId'
++const DRIVE_FILES_FIELDS = `kind,nextPageToken,incompleteSearch,files(${DRIVE_FILE_FIELDS})`
++const TEAM_DRIVE_FIELDS = 'teamDrives(kind,id,name,backgroundImageLink)'
++
++/**
++ * @class
++ * @implements {Provider}
++ */
++class Drive {
++  constructor (options) {
++    this.authProvider = options.provider = Drive.authProvider
++    options.alias = 'drive'
++    options.version = 'v3'
++
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'google'
++  }
++
++  list (options, done) {
++    const directory = options.directory || 'root'
++    const query = options.query || {}
++    const teamDrive = query.teamDrive
++    let listDone = false
++    let teamDrivesDone = false
++    let teamDrives
++    let listResponse
++    let reqErr
++    const finishReq = () => {
++      if (reqErr) {
++        done(reqErr)
++      } else if (listResponse.statusCode !== 200) {
++        done(new Error(`request to ${this.authProvider} returned ${listResponse.statusCode}`))
++      } else {
++        done(null, this.adaptData(listResponse.body, teamDrives ? teamDrives.body : null, options.uppy))
++      }
++    }
++
++    if (directory === 'root') {
++      // fetch a list of all Team Drives which the user can access.
++      this.client
++        .query()
++        .get('teamdrives')
++        .where({ fields: TEAM_DRIVE_FIELDS })
++        .auth(options.token)
++        .request((err, resp) => {
++          if (err) {
++            logger.error(err, 'provider.drive.teamDrive.error')
++          }
++          teamDrivesDone = true
++          teamDrives = resp
++          if (listDone) {
++            finishReq()
++          }
++        })
++    }
++
++    let where = {
++      fields: DRIVE_FILES_FIELDS,
++      q: `'${directory}' in parents and trashed=false`
++    }
++    if (teamDrive) {
++      // Team Drives require several extra parameters in order to work.
++      where.supportsTeamDrives = true
++      where.includeTeamDriveItems = true
++      where.teamDriveId = directory
++      where.corpora = 'teamDrive'
++    }
++
++    this.client
++      .query()
++      .get('files')
++      .where(where)
++      .auth(options.token)
++      .request((err, resp) => {
++        listDone = true
++        listResponse = resp
++        reqErr = err
++        if (teamDrivesDone || directory !== 'root') {
++          finishReq()
++        }
++      })
++  }
++
++  stats ({ id, token }, done) {
++    return this.client
++      .query()
++      .get(`files/${id}`)
++      .where({ fields: DRIVE_FILE_FIELDS, supportsTeamDrives: true })
++      .auth(token)
++      .request(done)
++  }
++
++  download ({ id, token }, onData) {
++    return this.client
++      .query()
++      .get(`files/${id}`)
++      .where({ alt: 'media', supportsTeamDrives: true })
++      .auth(token)
++      .request()
++      .on('data', onData)
++      .on('end', () => onData(null))
++      .on('error', (err) => {
++        logger.error(err, 'provider.drive.download.error')
++      })
++  }
++
++  thumbnail ({id, token}, done) {
++    return this.stats({id, token}, (err, resp, body) => {
++      if (err) {
++        logger.error(err, 'provider.drive.thumbnail.error')
++        return done(null)
++      }
++      done(body.thumbnailLink ? request(body.thumbnailLink) : null)
++    })
++  }
++
++  size ({id, token}, done) {
++    return this.stats({ id, token }, (err, resp, body) => {
++      if (err) {
++        logger.error(err, 'provider.drive.size.error')
++        return done(null)
++      }
++      done(parseInt(body.size))
++    })
++  }
++
++  adaptData (res, teamDrivesResp, uppy) {
++    const data = { username: adapter.getUsername(res), items: [] }
++    const items = adapter.getItemSubList(res)
++    const teamDrives = teamDrivesResp ? teamDrivesResp.teamDrives || [] : []
++    items.concat(teamDrives).forEach((item) => {
++      data.items.push({
++        isFolder: adapter.isFolder(item),
++        icon: adapter.getItemIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getItemId(item),
++        thumbnail: uppy.buildURL(adapter.getItemThumbnailUrl(item), true),
++        requestPath: adapter.getItemRequestPath(item),
++        modifiedDate: adapter.getItemModifiedDate(item),
++        raw: item",It looks like `raw` is only used for team drive detection. Could we also do that on the server side instead and add an `isTeamDrive` property to GDrive items? So we don't send unnecessary data to the client.,2018-10-15 11:05:18
+772,"@@ -0,0 +1,165 @@
++const sk_SK = {}
++
++sk_SK.strings = {
++  addBulkFilesFailed: {
++    '0': 'Súbor %{smart_count} sa nepodarilo pridať z dôvodu vnútornej chyby',
++    '1': 'Nepodarilo sa pridať %{smart_count} súbory z dôvodu vnútorných chýb',
++    '2': 'Nepodarilo sa pridať %{smart_count} súborov z dôvodu vnútorných chýb'
++  },
++  addMore: 'Pridať ďalšie',
++  addMoreFiles: 'Pridať ďalšie súbory',
++  addingMoreFiles: 'Pridávajú sa ďalšie súbory',
++  allowAccessDescription: 'Pokiaľ chcete urobiť fotografiu alebo nahrať video vaším zariadením, povoľte prosím prístup ku kamere.',
++  allowAccessTitle: 'Povoľte prístup ku kamere',
++  authenticateWith: 'Pripojiť k %{pluginName}',
++  authenticateWithTitle: 'Prosím príhláste sa k %{pluginName} pre výber súborov',
++  back: 'Späť',
++  browse: 'prechádzať',
++  cancel: 'Zrušiť',
++  cancelUpload: 'Zrušiť nahrávanie',
++  chooseFiles: 'Vyberte súbory',
++  closeModal: 'Zavrieť okno',
++  companionError: 'Spojenie s modulom Companion sa nepodarilo',
++  companionUnauthorizeHint: 'Pokiaľ nechcete povoliť prístup k účtu %{provider}, prosím prejdite na túto adresu %{url}',
++  complete: 'Hotovo',
++  connectedToInternet: 'Pripojené k internetu',
++  copyLink: 'Kopírovať odkaz',
++  copyLinkToClipboardFallback: 'Skopírujte odkaz nižšie',
++  copyLinkToClipboardSuccess: 'Odkaz bol skopírovaný do schránky',
++  creatingAssembly: 'Pripravuje sa nahrávanie...',
++  creatingAssemblyFailed: 'Transloadit: Nepodarilo sa vytvoriť Assembly',
++  dashboardTitle: 'Nahrať súbory',
++  dashboardWindowTitle: 'Okno na nahrávanie súborov. (Stlačením ESC ho zavriete)',
++  dataUploadedOfTotal: '%{complete} z %{total}',
++  done: 'Dokončené',
++  dropHereOr: 'Presuňte sem súbory alebo %{browse}',
++  dropHint: 'Presuňte sem súbory',
++  dropPaste: 'Presuňte sem súbory alebo %{browse}',
++  dropPasteImport: 'Presuňte sem súbory, vložte ich, %{browse} alebo ich importujte:',
++  editFile: 'Upraviť súbor',
++  editing: 'Úprava %{file}',
++  emptyFolderAdded: 'Neboli pridané žiadne súbory, pretože adresár je prázdny.',
++  encoding: 'Konvertovanie...',
++  enterCorrectUrl: 'Nesprávna adresa URL: Uistite sa, že zadávate priamy odkaz na súbor',
++  enterUrlToImport: 'Ak chcete importovať súbor, zadajte adresu URL',
++  exceedsSize: 'Tento súbor presahuje maximálnu povolenú veľkosť súboru',
++  exceedsSize2: '%{backwardsCompat} %{size}',
++  failedToFetch: 'Nepodarilo sa načítať túto webovú adresu. Skontrolujte, či je správna',
++  failedToUpload: 'Nepodarilo sa nahrať súbor %{file}',
++  fileSource: 'Zdroj súboru: %{name}',
++  filesUploadedOfTotal: {
++    '0': '%{complete} z %{smart_count} nahraných súborov',
++    '1': '%{complete} z %{smart_count} nahraných súborov'
++  },
++  filter: 'Filtrovať',
++  finishEditingFile: 'Dokončiť úpravu súborov',
++  folderAdded: {
++    '0': 'Pridaný %{smart_count} súbor zo zložky %{folder}',
++    '1': 'Pridané %{smart_count} súbory zo zložky %{folder}',
++    '2': 'Pridaných %{smart_count} súborov zo zložky %{folder}'
++  },
++  generatingThumbnails: 'Vytváram miniatury...',
++  import: 'Importovať',
++  importFrom: 'Import z %{name}',
++  loading: 'Nahrávanie...',
++  logOut: 'Odhlásiť',
++  micDisabled: 'Užívateľ odmietol prístup k mikrofónu',
++  myDevice: 'Moje zariadenie',
++  noDuplicates: 'Nemôžete pridať duplikátny súbor \'%{fileName}\', ktorý už existuje',
++  noFilesFound: 'Nemáte pridané žiadne súbory ani zložky',
++  noInternetConnection: 'Žiadne internetové pripojenie',
++  noNewAlreadyUploading: 'Počas nahrávania nemôžete pridať ďalšie súbory',
++  openFolderNamed: 'Otvoriť zložku %{name}',
++  pause: 'Pozastaviť',
++  pauseUpload: 'Pozastaviť nahrávanie',
++  paused: 'Pozastavené',
++  poweredBy: 'Vytvorení pomocou',
++  poweredBy2: '%{backwardsCompat} %{uppy}',
++  processingXFiles: {
++    '0': 'Spracovanie %{smart_count} súboru',
++    '1': 'Spracovanie %{smart_count} súborov',","```suggestion
+    '1': 'Spracovanie %{smart_count} súborov'
+```",2020-05-14 18:04:06
+973,"@@ -0,0 +1,17 @@
++# Number of days of inactivity before an issue becomes stale
++daysUntilStale: 365
++# Number of days of inactivity before a stale issue is closed
++daysUntilClose: 7","I think since we have such a high amount of days for stale issues right now, we could give folks a little more time to alert us:
+```suggestion
+daysUntilClose: 14
+```",2021-01-18 14:28:10
+614,"@@ -0,0 +1,170 @@
++const request = require('request')
++
++const B2_API_VERSION = 2
++const B2_API_URL = `https://api.backblazeb2.com/b2api/v${B2_API_VERSION}/`
++
++module.exports = class B2Client {","is there a reason we are not using this [backblaze npm module](https://www.npmjs.com/package/backblaze-b2) instead? It seems to be actively maintained, and has almost the same API as what is implemented here.",2019-11-16 17:38:13
+628,"@@ -0,0 +1,170 @@
++const request = require('request')
++
++const B2_API_VERSION = 2
++const B2_API_URL = `https://api.backblazeb2.com/b2api/v${B2_API_VERSION}/`
++
++module.exports = class B2Client {
++  constructor (options) {
++    this.applicationKeyId = options.credentials.applicationKeyId
++    this.applicationKey = options.credentials.applicationKey
++
++    this.retries = 3 // TODO
++
++    // This will be populated after a successful authorization
++    this.auth = {}
++  }
++
++  getURL (method) {
++    if (!this.auth.apiUrl) {
++      throw new Error('getURL() called before successful authorize()')
++    }
++    return this.auth.apiUrl + `/b2api/v${B2_API_VERSION}/${method}`
++  }
++
++  /**
++   * Request new authorization token from Backblaze.
++   */
++  authorize () {
++    return this._authorizing || (this._authorizing = new Promise((resolve, reject) => {","I think this pattern is a bit confusing—could we use one of these instead?
+```js
+if (this._authorizing) return this._authorizing
+this._authorizing = new Promise(...)
+return this._authorizing
+```
+or
+```js
+if (!this._authorizing) {
+  this._authorizing = new Promise(...)
+}
+return this._authorizing
+```",2019-11-18 13:55:18
+859,"@@ -0,0 +1,171 @@
++// Attributes in the format of htmlAtrribute: reactAttribute
++const possibleStandardNames = {",It looks like only the react-style names (the values in this object) are actually needed. Could we use an array instead?,2020-08-06 13:47:10
+901,"@@ -0,0 +1,176 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++// const BOX_FILE_FIELDS = 'id,name,size,type'",I guess we can delete this?,2020-10-21 15:24:58
+902,"@@ -0,0 +1,176 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++// const BOX_FILE_FIELDS = 'id,name,size,type'
++const BOX_FILES_FIELDS = 'id,modified_at,name,permissions,size,type'
++const BOX_THUMBNAIL_SIZE = 256
++
++/**
++ * Adapter for API https://developer.box.com/reference/
++ */
++class Box extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Box.authProvider
++    this.client = purest(options)
++    // needed for the thumbnails fetched via companion
++    this.needsCookieAuth = true
++  }
++
++  static get authProvider () {
++    return 'box'
++  }
++
++  _userInfo ({ token }, done) {
++    this.client
++      .get('users/me')
++      .auth(token)
++      .request(done)
++  }
++
++  /**
++   * Lists files and folders from Box API
++   *
++   * @param {object} options
++   * @param {function} done
++   */
++  list ({ directory, token, companion }, done) {
++    const rootFolderID = '0'
++    const path = `folders/${directory || rootFolderID}/items`
++
++    this.client
++      .get(path)
++      .qs({ fields: BOX_FILES_FIELDS })
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          err = this._error(err, resp)
++          logger.error(err, 'provider.box.list.error')
++          return done(err)
++        } else {
++          this._userInfo({ token }, (err, infoResp) => {
++            if (err || infoResp.statusCode !== 200) {
++              err = this._error(err, infoResp)
++              logger.error(err, 'provider.token.user.error')
++              return done(err)
++            }
++            done(null, this.adaptData(body, companion))
++          })
++        }
++      })
++  }
++
++  download ({ id, token }, onData) {
++    return this.client
++      .get(`files/${id}/content`)
++      .auth(token)
++      .request()
++      .on('response', (resp) => {
++        if (resp.statusCode !== 200) {
++          onData(this._error(null, resp))
++        } else {
++          resp.on('data', (chunk) => onData(null, chunk))
++        }
++      })
++      .on('end', () => onData(null, null))
++      .on('error', (err) => {
++        logger.error(err, 'provider.box.download.error')
++        onData(err)
++      })
++  }
++
++  thumbnail ({ id, token }, done) {
++    return this.client
++      .get(`files/${id}/thumbnail.png`)
++      .qs({ max_height: BOX_THUMBNAIL_SIZE, max_width: BOX_THUMBNAIL_SIZE })
++      .auth(token)
++      .request()
++      .on('response', (resp) => {
++        if (![200, 202].includes(resp.statusCode)) {","it seems according to [the documentation](https://developer.box.com/reference/get-files-id-thumbnail-id/#param-202-undefined), 202 means that the thumbnail will not be returned, but URL to a placeholder image will be available in the `Location` header.
+
+Should we be handling this case somehow? Or am I missing something here?",2020-10-21 16:22:27
+903,"@@ -0,0 +1,176 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++// const BOX_FILE_FIELDS = 'id,name,size,type'
++const BOX_FILES_FIELDS = 'id,modified_at,name,permissions,size,type'
++const BOX_THUMBNAIL_SIZE = 256
++
++/**
++ * Adapter for API https://developer.box.com/reference/
++ */
++class Box extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Box.authProvider
++    this.client = purest(options)
++    // needed for the thumbnails fetched via companion
++    this.needsCookieAuth = true
++  }
++
++  static get authProvider () {
++    return 'box'
++  }
++
++  _userInfo ({ token }, done) {
++    this.client
++      .get('users/me')
++      .auth(token)
++      .request(done)
++  }
++
++  /**
++   * Lists files and folders from Box API
++   *
++   * @param {object} options
++   * @param {function} done
++   */
++  list ({ directory, token, companion }, done) {
++    const rootFolderID = '0'
++    const path = `folders/${directory || rootFolderID}/items`
++
++    this.client
++      .get(path)
++      .qs({ fields: BOX_FILES_FIELDS })
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          err = this._error(err, resp)
++          logger.error(err, 'provider.box.list.error')
++          return done(err)
++        } else {
++          this._userInfo({ token }, (err, infoResp) => {
++            if (err || infoResp.statusCode !== 200) {
++              err = this._error(err, infoResp)
++              logger.error(err, 'provider.token.user.error')
++              return done(err)
++            }
++            done(null, this.adaptData(body, companion))
++          })
++        }
++      })
++  }
++
++  download ({ id, token }, onData) {
++    return this.client
++      .get(`files/${id}/content`)
++      .auth(token)
++      .request()
++      .on('response', (resp) => {
++        if (resp.statusCode !== 200) {
++          onData(this._error(null, resp))
++        } else {
++          resp.on('data', (chunk) => onData(null, chunk))
++        }
++      })
++      .on('end', () => onData(null, null))
++      .on('error', (err) => {
++        logger.error(err, 'provider.box.download.error')
++        onData(err)
++      })
++  }
++
++  thumbnail ({ id, token }, done) {
++    return this.client
++      .get(`files/${id}/thumbnail.png`)
++      .qs({ max_height: BOX_THUMBNAIL_SIZE, max_width: BOX_THUMBNAIL_SIZE })
++      .auth(token)
++      .request()
++      .on('response', (resp) => {
++        if (![200, 202].includes(resp.statusCode)) {
++          const err = this._error(null, resp)
++          logger.error(err, 'provider.box.thumbnail.error')
++          return done(err)
++        }
++        done(null, resp)
++      })
++      .on('error', (err) => {
++        logger.error(err, 'provider.box.thumbnail.error')
++      })
++  }
++
++  size ({ id, token }, done) {
++    return this.client
++      .get(`files/${id}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          err = this._error(err, resp)
++          logger.error(err, 'provider.box.size.error')
++          return done(err)
++        }
++        done(null, parseInt(body.size))
++      })
++  }
++
++  logout ({ companion, token }, done) {
++    const { key, secret } = companion.options.providerOptions.box
++
++    return this.client
++      .post('https://api.box.com/oauth2/revoke')
++      .options({
++        formData: {
++          client_id: key,
++          client_secret: secret,
++          token
++        }
++      })
++      .auth(token)
++      .request((err, resp) => {
++        if (err || resp.statusCode !== 200) {
++          logger.error(err, 'provider.box.logout.error')
++          done(this._error(err, resp))
++          return
++        }
++        done(null, { revoked: true })
++      })
++  }
++
++  adaptData (res, companion) {
++    const data = { username: adapter.getUsername(res), items: [] }
++    const items = adapter.getItemSubList(res)
++    items.forEach((item) => {
++      data.items.push({
++        isFolder: adapter.isFolder(item),
++        icon: adapter.getItemIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getItemId(item),
++        thumbnail: companion.buildURL(adapter.getItemThumbnailUrl(item), true),
++        requestPath: adapter.getItemRequestPath(item),
++        modifiedDate: adapter.getItemModifiedDate(item),
++        size: adapter.getItemSize(item)
++      })
++    })
++
++    data.nextPagePath = adapter.getNextPagePath(res)
++
++    return data
++  }
++
++  _error (err, resp) {
++    if (resp) {
++      const fallbackMessage = `request to ${this.authProvider} returned ${resp.statusCode}`
++      const errMsg = (resp.body || {}).error_summary ? resp.body.error_summary : fallbackMessage",it seems we left out the error handling here. It's meant to try to check for the message of an [error response](https://developer.box.com/guides/api-calls/permissions-and-errors/common-errors/#client-error),2020-10-21 17:15:40
+286,"@@ -0,0 +1,18 @@
++const Plugin = require('../../core/Plugin')
++
++module.exports = class ProgressBar extends Plugin {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++
++    this.id = opts.id
++    this.type = 'progressindicator'
++  }
++
++  install () {
++    this.opts.onInstall()
++  }
++
++  uninstall () {
++    this.opts.onUninstall()
++  }
++}",I’m a bit confused. We have an actual `ProgressBar` Uppy React wrapper component that we are testing. Why do we need a mock for it?,2018-05-29 17:31:20
+337,"@@ -0,0 +1,18 @@
++const ProviderViews = require('@uppy/provider-views')
++
++module.exports = class DriveProviderViews extends ProviderViews {
++  constructor (plugin, opts) {
++    super(plugin, opts)
++    this.originalToggleCheckbox = this.toggleCheckbox
++    this.toggleCheckbox = this.toggleDriveCheckbox.bind(this)
++  }
++  toggleDriveCheckbox (e, file) {","Is there a reason not to name this `toggleCheckbox` and then do `super.toggleCheckbox(e, file)` below? I don't _think_ the .bind() stuff should interfere but i may be wrong…",2018-08-20 15:29:28
+695,"@@ -0,0 +1,183 @@
++const B2 = require('backblaze-b2')
++const ms = require('ms')
++const B2Stream = require('./b2stream')
++
++function createBucketCache (client, cacheDuration = ms('30m')) {
++  const cache = Object.create(null)
++  return (bucketName) => {
++    const match = cache[bucketName]
++    if (match && match.expiration < Date.now()) {
++      return match.result
++    } else {
++      cache[bucketName] = {
++        result: client.getBucket({ bucketName }),
++        expiration: Date.now() + cacheDuration
++      }
++      return cache[bucketName].result
++    }
++  }
++}
++
++function createEndpointPool (client, bucketName) {
++  const pools = {
++    default: []
++  }
++
++  const acquire = (fileId = undefined) => {
++    if (fileId) { // specific fileId indicates large file / multipart
++      const pool = (pools[fileId] = pools[fileId] || [])
++      if (pool.length) {
++        return Promise.resolve(pool.shift())
++      } else {
++        return client.getUploadPartUrl({ fileId })
++          .then(({ data }) => data)
++      }
++    } else {
++      const pool = pools.default
++      if (pool.length) {
++        return Promise.resolve(pool.shift())
++      } else {
++        return client.getCachedBucket(bucketName)
++          .then(({ bucketId }) => client.getUploadUrl({ bucketId }))
++          .then(({ data }) => data)
++      }
++    }
++  }
++
++  const release = (endpoint) => {
++    // fileId indicates large file / multipart
++    const { fileId } = endpoint
++    if (fileId) {
++      const pool = (pools[fileId] = pools[fileId] || [])","I think on some lazy days, this line can be easily confusing. I'd rather we just do `pools[fileId] = pools[fileId] || []`, and `pools[fileId].push(endpoint)` on the next line",2020-03-09 15:02:53
+696,"@@ -0,0 +1,183 @@
++const B2 = require('backblaze-b2')
++const ms = require('ms')
++const B2Stream = require('./b2stream')
++
++function createBucketCache (client, cacheDuration = ms('30m')) {
++  const cache = Object.create(null)
++  return (bucketName) => {
++    const match = cache[bucketName]
++    if (match && match.expiration < Date.now()) {
++      return match.result
++    } else {
++      cache[bucketName] = {
++        result: client.getBucket({ bucketName }),
++        expiration: Date.now() + cacheDuration
++      }
++      return cache[bucketName].result
++    }
++  }
++}
++
++function createEndpointPool (client, bucketName) {
++  const pools = {
++    default: []
++  }
++
++  const acquire = (fileId = undefined) => {
++    if (fileId) { // specific fileId indicates large file / multipart
++      const pool = (pools[fileId] = pools[fileId] || [])
++      if (pool.length) {
++        return Promise.resolve(pool.shift())
++      } else {
++        return client.getUploadPartUrl({ fileId })
++          .then(({ data }) => data)
++      }
++    } else {
++      const pool = pools.default
++      if (pool.length) {
++        return Promise.resolve(pool.shift())
++      } else {
++        return client.getCachedBucket(bucketName)
++          .then(({ bucketId }) => client.getUploadUrl({ bucketId }))
++          .then(({ data }) => data)
++      }
++    }
++  }
++
++  const release = (endpoint) => {
++    // fileId indicates large file / multipart
++    const { fileId } = endpoint
++    if (fileId) {
++      const pool = (pools[fileId] = pools[fileId] || [])
++      pool.push(endpoint)
++    } else {
++      pools.default.push(endpoint)
++    }
++  }
++
++  const finish = (fileId) => {
++    delete pools[fileId]
++  }
++
++  return {
++    acquire,
++    release,
++    finish
++  }
++}
++
++module.exports = class B2Client {
++  constructor (options) {
++    this.b2 = new B2({
++      applicationKeyId: options.keyId,
++      applicationKey: options.key,
++      axios: options.axios || {},
++      retry: options.retry
++    })
++
++    this._bucketCache = createBucketCache(this)
++
++    // This will be populated after each successful authorization.
++    this.lastAuthResponseData = {}
++  }
++
++  preauth (failedToken) {
++    if (this._auth) {
++      if (failedToken) {
++        return this._auth.then(auth => {
++          // ONLY if the current promise resolves to the
++          // token which we know to be invalid, delete
++          // the _auth promise and recreate it be re-calling
++          // preauth()
++          if (auth.authorizationToken === failedToken) {
++            delete this._auth
++          }
++          return this.preauth()
++        })
++      }
++    } else {
++      this._auth = this.b2.authorize()
++        .then(auth => {
++          this.lastAuthResponseData = auth.data
++          return auth.data
++        }).catch(err => {
++          console.log('Error attempting to authorize with B2:' + err)
++          delete this._auth
++          return this.preauth()","is this call potentially endless? If so, I think we should limit it to n tries. Possibly 3?",2020-03-09 15:16:14
+697,"@@ -0,0 +1,183 @@
++const B2 = require('backblaze-b2')
++const ms = require('ms')
++const B2Stream = require('./b2stream')
++
++function createBucketCache (client, cacheDuration = ms('30m')) {
++  const cache = Object.create(null)
++  return (bucketName) => {
++    const match = cache[bucketName]
++    if (match && match.expiration < Date.now()) {
++      return match.result
++    } else {
++      cache[bucketName] = {
++        result: client.getBucket({ bucketName }),
++        expiration: Date.now() + cacheDuration
++      }
++      return cache[bucketName].result
++    }
++  }
++}
++
++function createEndpointPool (client, bucketName) {
++  const pools = {
++    default: []
++  }
++
++  const acquire = (fileId = undefined) => {
++    if (fileId) { // specific fileId indicates large file / multipart
++      const pool = (pools[fileId] = pools[fileId] || [])
++      if (pool.length) {
++        return Promise.resolve(pool.shift())
++      } else {
++        return client.getUploadPartUrl({ fileId })
++          .then(({ data }) => data)
++      }
++    } else {
++      const pool = pools.default
++      if (pool.length) {
++        return Promise.resolve(pool.shift())
++      } else {
++        return client.getCachedBucket(bucketName)
++          .then(({ bucketId }) => client.getUploadUrl({ bucketId }))
++          .then(({ data }) => data)
++      }
++    }
++  }
++
++  const release = (endpoint) => {
++    // fileId indicates large file / multipart
++    const { fileId } = endpoint
++    if (fileId) {
++      const pool = (pools[fileId] = pools[fileId] || [])
++      pool.push(endpoint)
++    } else {
++      pools.default.push(endpoint)
++    }
++  }
++
++  const finish = (fileId) => {
++    delete pools[fileId]
++  }
++
++  return {
++    acquire,
++    release,
++    finish
++  }
++}
++
++module.exports = class B2Client {
++  constructor (options) {
++    this.b2 = new B2({
++      applicationKeyId: options.keyId,
++      applicationKey: options.key,
++      axios: options.axios || {},
++      retry: options.retry
++    })
++
++    this._bucketCache = createBucketCache(this)
++
++    // This will be populated after each successful authorization.
++    this.lastAuthResponseData = {}
++  }
++
++  preauth (failedToken) {
++    if (this._auth) {
++      if (failedToken) {
++        return this._auth.then(auth => {
++          // ONLY if the current promise resolves to the
++          // token which we know to be invalid, delete
++          // the _auth promise and recreate it be re-calling
++          // preauth()
++          if (auth.authorizationToken === failedToken) {
++            delete this._auth
++          }
++          return this.preauth()
++        })
++      }
++    } else {
++      this._auth = this.b2.authorize()
++        .then(auth => {
++          this.lastAuthResponseData = auth.data
++          return auth.data
++        }).catch(err => {
++          console.log('Error attempting to authorize with B2:' + err)
++          delete this._auth
++          return this.preauth()
++        })
++    }
++    return this._auth
++  }
++
++  request (actualRequest, invalidToken) {
++    return this.preauth(invalidToken)
++      .then(auth => actualRequest()
++        .catch(err => {
++          if (err.response && err.response.status === 401) {
++            // Retry and pass the invalid token forward.
++            return this.request(actualRequest, auth.authorizationToken)","if this call is also potentially endless, I'll vote that we limit to an `n` number of times.",2020-03-09 15:29:05
+686,"@@ -0,0 +1,186 @@
++const router = require('express').Router
++// const ms = require('ms')",leftover?,2020-03-05 16:32:12
+624,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})",is there any reason for not just using a literal like so: `const cache = {}`?,2019-11-17 12:57:12
+625,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result","I think this would be easier to understand by splitting it into two lines:
+```js
+cache[bucketName] = { /* etc */ }
+return cache[bucketName].result
+```",2019-11-17 13:13:48
+615,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })",should this be a `400` instead?,2019-11-17 10:41:34
+616,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })
++    }
++    if (typeof type !== 'string') {
++      return res.status(400).json({ error: 'b2: content type must be a string' })
++    }
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.startLargeFile({
++          bucketId,
++          fileName,
++          contentType: type
++        }))
++      .then(largeFileResponse => ({
++        fileId: largeFileResponse.fileId
++      }))
++      .then((data) => {
++        res.json(data)
++      })
++      .catch(err => next(err))
++  }
++
++  /**
++   * Obtain an authorization token and destination URL to
++   * post upload data to.
++   *
++   * Expected JSON body:
++   *  - fileId - The B2 fileId we would like to obtain an
++   *    upload destination for.
++   *
++   * Response JSON:
++   *  - fileId - The unique fileId of file being uploaded
++   *    (should be same as passed-in fileId)
++   *  - uploadUrl - The Backblaze URL which we'll send file
++   *    parts to
++   *  - authorizationToken - Auth token for uploading to the
++   *    aforementioned uploadUrl.
++   */
++  function getEndpoint (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {",this check is probably redundant because all `params` are expected to be strings,2019-11-17 10:53:14
+618,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })
++    }
++    if (typeof type !== 'string') {
++      return res.status(400).json({ error: 'b2: content type must be a string' })
++    }
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.startLargeFile({
++          bucketId,
++          fileName,
++          contentType: type
++        }))
++      .then(largeFileResponse => ({
++        fileId: largeFileResponse.fileId
++      }))
++      .then((data) => {
++        res.json(data)
++      })
++      .catch(err => next(err))
++  }
++
++  /**
++   * Obtain an authorization token and destination URL to
++   * post upload data to.
++   *
++   * Expected JSON body:
++   *  - fileId - The B2 fileId we would like to obtain an
++   *    upload destination for.
++   *
++   * Response JSON:
++   *  - fileId - The unique fileId of file being uploaded
++   *    (should be same as passed-in fileId)
++   *  - uploadUrl - The Backblaze URL which we'll send file
++   *    parts to
++   *  - authorizationToken - Auth token for uploading to the
++   *    aforementioned uploadUrl.
++   */
++  function getEndpoint (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    client.getUploadPartURL({ fileId })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function getEndpointSmall (req, res, next) {
++    const client = req.uppy.b2Client
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.getUploadURL({
++          bucketId
++        }).then(data =>
++          res.json(data)
++        ).catch(err => next(err))
++      )
++  }
++
++  function getUploadedParts (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {",this check is probably redundant because all params are expected to be strings,2019-11-17 11:04:50
+619,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })
++    }
++    if (typeof type !== 'string') {
++      return res.status(400).json({ error: 'b2: content type must be a string' })
++    }
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.startLargeFile({
++          bucketId,
++          fileName,
++          contentType: type
++        }))
++      .then(largeFileResponse => ({
++        fileId: largeFileResponse.fileId
++      }))
++      .then((data) => {
++        res.json(data)
++      })
++      .catch(err => next(err))
++  }
++
++  /**
++   * Obtain an authorization token and destination URL to
++   * post upload data to.
++   *
++   * Expected JSON body:
++   *  - fileId - The B2 fileId we would like to obtain an
++   *    upload destination for.
++   *
++   * Response JSON:
++   *  - fileId - The unique fileId of file being uploaded
++   *    (should be same as passed-in fileId)
++   *  - uploadUrl - The Backblaze URL which we'll send file
++   *    parts to
++   *  - authorizationToken - Auth token for uploading to the
++   *    aforementioned uploadUrl.
++   */
++  function getEndpoint (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    client.getUploadPartURL({ fileId })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function getEndpointSmall (req, res, next) {
++    const client = req.uppy.b2Client
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.getUploadURL({
++          bucketId
++        }).then(data =>
++          res.json(data)
++        ).catch(err => next(err))
++      )
++  }
++
++  function getUploadedParts (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    const fetchParts = (prevParts = [], nextPartNumber) => {
++      const params = {
++        fileId,
++        maxPartCount: 1000
++      }
++      if (nextPartNumber) {
++        params.nextPartNumber = nextPartNumber
++      }
++      return client.listParts(params)
++        .then(response => {
++          const parts = [
++            ...prevParts,
++            ...(response.parts.map(part => ({",are we certain that `response.parts` will always be present? Should we be doing some sort of validation before accessing the data?,2019-11-17 11:14:02
+620,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })
++    }
++    if (typeof type !== 'string') {
++      return res.status(400).json({ error: 'b2: content type must be a string' })
++    }
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.startLargeFile({
++          bucketId,
++          fileName,
++          contentType: type
++        }))
++      .then(largeFileResponse => ({
++        fileId: largeFileResponse.fileId
++      }))
++      .then((data) => {
++        res.json(data)
++      })
++      .catch(err => next(err))
++  }
++
++  /**
++   * Obtain an authorization token and destination URL to
++   * post upload data to.
++   *
++   * Expected JSON body:
++   *  - fileId - The B2 fileId we would like to obtain an
++   *    upload destination for.
++   *
++   * Response JSON:
++   *  - fileId - The unique fileId of file being uploaded
++   *    (should be same as passed-in fileId)
++   *  - uploadUrl - The Backblaze URL which we'll send file
++   *    parts to
++   *  - authorizationToken - Auth token for uploading to the
++   *    aforementioned uploadUrl.
++   */
++  function getEndpoint (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    client.getUploadPartURL({ fileId })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function getEndpointSmall (req, res, next) {
++    const client = req.uppy.b2Client
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.getUploadURL({
++          bucketId
++        }).then(data =>
++          res.json(data)
++        ).catch(err => next(err))
++      )
++  }
++
++  function getUploadedParts (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    const fetchParts = (prevParts = [], nextPartNumber) => {
++      const params = {
++        fileId,
++        maxPartCount: 1000
++      }
++      if (nextPartNumber) {
++        params.nextPartNumber = nextPartNumber
++      }
++      return client.listParts(params)
++        .then(response => {
++          const parts = [
++            ...prevParts,
++            ...(response.parts.map(part => ({
++              PartNumber: part.partNumber,
++              Size: part.contentLength
++            }))
++            )
++          ]
++
++          if (response.nextPartNumber) {
++            return fetchParts(parts, response.nextPartNumber)
++          } else {
++            return Promise.resolve(parts)
++          }
++        })
++    }
++
++    fetchParts()
++      .then(parts => res.json({ parts }))
++      .catch(err => next(err))
++  }
++
++  /**
++   * Finish off a multipart upload.
++   *
++   * Expected JSON body:
++   *  - fileId - The unique fileId of the file being uploaded
++   *  - partSha1Array - An array containing the hex digests of
++   *    each of the uploaded parts (in order). This is used on
++   *    the receiving end to verify the integrity of the upload.
++   *
++   * Response JSON:
++   *  see https://www.backblaze.com/b2/docs/b2_finish_large_file.html
++   */
++  function completeMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const { partSha1Array } = req.body
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {","again, this check is redundant",2019-11-17 11:14:33
+621,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })
++    }
++    if (typeof type !== 'string') {
++      return res.status(400).json({ error: 'b2: content type must be a string' })
++    }
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.startLargeFile({
++          bucketId,
++          fileName,
++          contentType: type
++        }))
++      .then(largeFileResponse => ({
++        fileId: largeFileResponse.fileId
++      }))
++      .then((data) => {
++        res.json(data)
++      })
++      .catch(err => next(err))
++  }
++
++  /**
++   * Obtain an authorization token and destination URL to
++   * post upload data to.
++   *
++   * Expected JSON body:
++   *  - fileId - The B2 fileId we would like to obtain an
++   *    upload destination for.
++   *
++   * Response JSON:
++   *  - fileId - The unique fileId of file being uploaded
++   *    (should be same as passed-in fileId)
++   *  - uploadUrl - The Backblaze URL which we'll send file
++   *    parts to
++   *  - authorizationToken - Auth token for uploading to the
++   *    aforementioned uploadUrl.
++   */
++  function getEndpoint (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    client.getUploadPartURL({ fileId })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function getEndpointSmall (req, res, next) {
++    const client = req.uppy.b2Client
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.getUploadURL({
++          bucketId
++        }).then(data =>
++          res.json(data)
++        ).catch(err => next(err))
++      )
++  }
++
++  function getUploadedParts (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    const fetchParts = (prevParts = [], nextPartNumber) => {
++      const params = {
++        fileId,
++        maxPartCount: 1000
++      }
++      if (nextPartNumber) {
++        params.nextPartNumber = nextPartNumber
++      }
++      return client.listParts(params)
++        .then(response => {
++          const parts = [
++            ...prevParts,
++            ...(response.parts.map(part => ({
++              PartNumber: part.partNumber,
++              Size: part.contentLength
++            }))
++            )
++          ]
++
++          if (response.nextPartNumber) {
++            return fetchParts(parts, response.nextPartNumber)
++          } else {
++            return Promise.resolve(parts)
++          }
++        })
++    }
++
++    fetchParts()
++      .then(parts => res.json({ parts }))
++      .catch(err => next(err))
++  }
++
++  /**
++   * Finish off a multipart upload.
++   *
++   * Expected JSON body:
++   *  - fileId - The unique fileId of the file being uploaded
++   *  - partSha1Array - An array containing the hex digests of
++   *    each of the uploaded parts (in order). This is used on
++   *    the receiving end to verify the integrity of the upload.
++   *
++   * Response JSON:
++   *  see https://www.backblaze.com/b2/docs/b2_finish_large_file.html
++   */
++  function completeMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const { partSha1Array } = req.body
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    if (typeof partSha1Array === 'undefined' || typeof partSha1Array.length !== 'number') {
++      return res.status(400).json({ error: 'b2: partSha1Array array not found' })
++    }
++
++    client.finishLargeFile({ fileId, partSha1Array })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function abortMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {",Also here :),2019-11-17 11:16:06
+617,"@@ -0,0 +1,196 @@
++const router = require('express').Router
++const ms = require('ms')
++
++module.exports = function b2 (config) {
++  if (typeof config.getPath !== 'function') {
++    throw new TypeError('b2: the `getPath` option must be a function')
++  }
++
++  const getCachedBucketID = (() => {
++    const cache = Object.create({})
++    return (client, bucketName) => {
++      const match = cache[bucketName]
++      if (match && match.expiration < Date.now()) {
++        return match.result
++      } else {
++        return (cache[bucketName] = {
++          result: client.getBucketId({ bucketName }),
++          expiration: Date.now() + (config.cacheBucketIdDurationMS || ms('30m'))
++        }).result
++      }
++    }
++  })()
++
++  /**
++   * Initiate a B2 large file upload.
++   *
++   * Expected JSON body:
++   *  - filename - The name of the file, given to the `config.getPath`
++   *    option to determine the object's final path in the B2 bucket.
++   *  - type - The MIME type of the file
++   *
++   * Response JSON:
++   *  - fileId - The unique B2 fileId which will be used again to initiate
++   *    the actual file transfer.
++   */
++  function createMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const fileName = config.getPath(req, req.body.filename)
++    const { type } = req.body
++
++    if (typeof fileName !== 'string') {
++      return res.status(500).json({ error: 'b2: filename returned from `getPath` must be a string' })
++    }
++    if (typeof type !== 'string') {
++      return res.status(400).json({ error: 'b2: content type must be a string' })
++    }
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.startLargeFile({
++          bucketId,
++          fileName,
++          contentType: type
++        }))
++      .then(largeFileResponse => ({
++        fileId: largeFileResponse.fileId
++      }))
++      .then((data) => {
++        res.json(data)
++      })
++      .catch(err => next(err))
++  }
++
++  /**
++   * Obtain an authorization token and destination URL to
++   * post upload data to.
++   *
++   * Expected JSON body:
++   *  - fileId - The B2 fileId we would like to obtain an
++   *    upload destination for.
++   *
++   * Response JSON:
++   *  - fileId - The unique fileId of file being uploaded
++   *    (should be same as passed-in fileId)
++   *  - uploadUrl - The Backblaze URL which we'll send file
++   *    parts to
++   *  - authorizationToken - Auth token for uploading to the
++   *    aforementioned uploadUrl.
++   */
++  function getEndpoint (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    client.getUploadPartURL({ fileId })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function getEndpointSmall (req, res, next) {
++    const client = req.uppy.b2Client
++
++    return getCachedBucketID(client, config.bucket)
++      .then(bucketId =>
++        client.getUploadURL({
++          bucketId
++        }).then(data =>
++          res.json(data)
++        ).catch(err => next(err))
++      )
++  }
++
++  function getUploadedParts (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    const fetchParts = (prevParts = [], nextPartNumber) => {
++      const params = {
++        fileId,
++        maxPartCount: 1000
++      }
++      if (nextPartNumber) {
++        params.nextPartNumber = nextPartNumber
++      }
++      return client.listParts(params)
++        .then(response => {
++          const parts = [
++            ...prevParts,
++            ...(response.parts.map(part => ({
++              PartNumber: part.partNumber,
++              Size: part.contentLength
++            }))
++            )
++          ]
++
++          if (response.nextPartNumber) {
++            return fetchParts(parts, response.nextPartNumber)
++          } else {
++            return Promise.resolve(parts)
++          }
++        })
++    }
++
++    fetchParts()
++      .then(parts => res.json({ parts }))
++      .catch(err => next(err))
++  }
++
++  /**
++   * Finish off a multipart upload.
++   *
++   * Expected JSON body:
++   *  - fileId - The unique fileId of the file being uploaded
++   *  - partSha1Array - An array containing the hex digests of
++   *    each of the uploaded parts (in order). This is used on
++   *    the receiving end to verify the integrity of the upload.
++   *
++   * Response JSON:
++   *  see https://www.backblaze.com/b2/docs/b2_finish_large_file.html
++   */
++  function completeMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const { partSha1Array } = req.body
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    if (typeof partSha1Array === 'undefined' || typeof partSha1Array.length !== 'number') {
++      return res.status(400).json({ error: 'b2: partSha1Array array not found' })
++    }
++
++    client.finishLargeFile({ fileId, partSha1Array })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  function abortMultipartUpload (req, res, next) {
++    const client = req.uppy.b2Client
++    const { fileId } = req.params
++
++    if (typeof fileId !== 'string') {
++      return res.status(400).json({ error: 'b2: fileId type must be a string' })
++    }
++
++    client.cancelLargeFile({ fileId })
++      .then(data => res.json(data))
++      .catch(err => next(err))
++  }
++
++  return router()
++    .post('/upload', getEndpointSmall)
++    .post('/multipart', createMultipartUpload)
++    .post('/multipart/:fileId', getEndpoint)
++    .get('/multipart/:fileId', getUploadedParts)","is there a reason for making `getEndpointSmall`, `getEndpoint`, and `getUploadedParts` to be `POST` requests? `GET` seems more fitting.",2019-11-17 10:56:03
+810,"@@ -0,0 +1,21 @@
++The MIT License (MIT)
++
++Copyright (c) 2018 Transloadit",we should probably make this 2020,2020-07-07 14:50:26
+50,"@@ -0,0 +1,21 @@
++The MIT License (MIT)
++
++Copyright (c) Sindre Sorhus <sindresorhus@gmail.com> (sindresorhus.com)
++
++Permission is hereby granted, free of charge, to any person obtaining a copy
++of this software and associated documentation files (the ""Software""), to deal
++in the Software without restriction, including without limitation the rights
++to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
++copies of the Software, and to permit persons to whom the Software is
++furnished to do so, subject to the following conditions:
++
++The above copyright notice and this permission notice shall be included in
++all copies or substantial portions of the Software.
++
++THE SOFTWARE IS PROVIDED ""AS IS"", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
++IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
++FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
++AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
++LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
++OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
++THE SOFTWARE.",👍 ,2017-06-16 14:22:18
+523,"@@ -0,0 +1,21 @@
++const getTimeStamp = require('@uppy/utils/lib/getTimeStamp')
++
++// Swallow logs, default if logger is not set or debug: false
++const nullLogger = {
++  debug: (...args) => {},
++  warn: (...args) => {},
++  error: (...args) => {}
++}
++
++// Print logs to console with namespace + timestamp,
++// default if logger: 'debug' or debug: true
++const debugLogger = {
++  debug: (...args) => console.debug(`[Uppy] [${getTimeStamp()}]`, ...args),","```suggestion
+  debug: (...args) => {
+    const debug = console.debug || console.log
+    debug(`[Uppy] [${getTimeStamp()}]`, ...args)
+  },
+```
+this should work hopefully",2019-06-24 13:15:26
+690,"@@ -0,0 +1,21 @@
++const { h } = require('preact')
++
++module.exports = ({ currentDeviceId, videoSources, onChangeVideoSource }) => {
++  return (
++    <p className=""uppy-Webcam-videoSource"">Video source:
++      <select
++        className=""uppy-Webcam-videoSource-select""
++        onchange={() => { onChangeVideoSource(document.getElementsByClassName('uppy-Webcam-videoSource-select')[0].value) }}","We can use `event.target` here instead:
+```suggestion
+        onchange={(event) => { onChangeVideoSource(event.target.value) }}
+```
+it's technically possible that there are 2 or more Uppy instances on a page, and `getElementsByClassName()` may pick the wrong element in that case. `event.target` is always correct.",2020-03-09 09:54:36
+956,"@@ -0,0 +1,21 @@
++name: Companion
++on: [push, pull_request]
++
++jobs:
++  test:
++    name: Unit tests
++    runs-on: ubuntu-latest
++    strategy:
++      matrix:
++        node-version: [10.20.1, 12.x, 14.x]",:heart: ,2020-11-26 09:06:38
+807,"@@ -0,0 +1,210 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++
++const { ProviderApiError, ProviderAuthError } = require('../error')
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 10
++const MAX_MO_RANGE = 3 // waiting on response: https://devforum.zoom.us/t/retrieve-all-past-zoom-cloud-recordings/22487/6?u=mokutsu
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  // /users/{userId}/recordings
++  async list ({ token, query = { cursor: {}, nextPageToken: '' } }, done) {
++    /*
++    zoom restricts retrieval to 1 month range + records for 300 meetings
++      - if there's enough results to paginate, return that
++      - if there's not enough, keep grabbing older records until we get the max number of results or max date range
++    */
++    const { oldestMonth } = query.cursor || {}
++    let nextPageToken = query.nextPageToken || ''
++    let response = null
++    const results = []
++    let initialMonth = 1
++
++    if (nextPageToken && oldestMonth) {
++      initialMonth = parseInt(oldestMonth)
++    } else if (oldestMonth) {
++      initialMonth += parseInt(oldestMonth) + 1
++    }
++
++    let monthsPastToQuery = initialMonth
++    let dateRange = this._getDateRange(monthsPastToQuery)
++
++    while (
++      !(response && response.body.next_page_token) &&
++      (monthsPastToQuery - initialMonth < MAX_MO_RANGE) &&
++      results.length < PAGE_SIZE
++    ) {
++      dateRange = this._getDateRange(monthsPastToQuery)
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from: dateRange.fromDate,
++        to: dateRange.toDate
++      }
++      if (nextPageToken) {
++        queryObj.next_page_token = nextPageToken
++      }
++      try {
++        response = await new Promise((resolve, reject) => this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++          .qs(queryObj)
++          .auth(token)
++          .request((err, resp, body) => {
++            if (err || resp.statusCode !== 200) {
++              reject(this._error(err, resp))
++            } else {
++              resolve(resp)
++            }
++          })
++        )
++      } catch (err) {
++        return done(err)
++      }
++
++      if (response.body.next_page_token) {
++        nextPageToken = response.body.next_page_token
++      } else {
++        monthsPastToQuery += 1
++      }
++      results.push(response.body)
++    }
++
++    done(null, this._adaptData(results, dateRange))
++  }
++
++  download ({ id, token, query }, done) {
++    // zoom only allows retrieval by meeting so we need meeting ID and file ID to retrieve
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          const file = resp.body.recording_files.find(file => file.id === fileId)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => done(null, null))
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp.body.recording_files.find(file => file.id === fileId)
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        done(null, file.file_size)
++      })
++  }
++
++  _adaptData (results, dateRange) {
++    if (!results || results.length === 0) {
++      return { items: [] }
++    }
++
++    const data = {
++      // is this nextPagePath ever used? It looks like pagination just uses the querystring / cursor key
++      nextPagePath: adapter.getQuery(results, dateRange),
++      items: []
++    }
++
++    results.forEach(res => {
++      res.meetings.forEach(meeting => {
++        meeting.recording_files.forEach((record, index) => {
++          data.items.push({
++            name: adapter.getItemName(meeting, record, index),
++            mimeType: adapter.getMimeType(record),
++            id: adapter.getId(record),
++            requestPath: adapter.getRequestPath(record),
++            modifiedDate: adapter.getStartDate(record),
++            size: adapter.getSize(record),
++            custom: adapter.getCustomFields(record)
++          })
++        })
++      })
++    })
++
++    return data
++  }
++
++  _error (err, response) {
++    // token expiry error doesn't seem to be returned correctly","i'm not 100% sure why the token expiry isn't being recognized correctly, any thoughts / feedback would be helpful. thanks!",2020-07-02 21:44:28
+679,"@@ -0,0 +1,22 @@
++const execa = require('execa')
++const fs = require('fs')
++
++const README_FILE_NAME = 'README.md'
++
++async function updateContributorsListInReadme () {
++  const readme = fs.readFileSync(README_FILE_NAME, 'utf-8')
++  const args = [
++    '--owner', 'transloadit',
++    '--repo', 'uppy',
++    '--cols', '6',
++    '--authToken', process.env.GITHUB_TOKEN ? `--authToken ${process.env.GITHUB_TOKEN}` : ''","```suggestion
+    '--authToken', process.env.GITHUB_TOKEN ? process.env.GITHUB_TOKEN : ''
+```
+",2020-02-17 15:42:27
+812,"@@ -0,0 +1,223 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const MAX_MO_RANGE = 3
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  async list ({ token, query = { cursor: '', nextPageToken: '' } }, done) {","is there a reason this method needs to be `async`? For consistency and to avoid confusion, I'd say we should keep it the same as others.",2020-07-07 15:34:11
+813,"@@ -0,0 +1,223 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const MAX_MO_RANGE = 3
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  async list ({ token, query = { cursor: '', nextPageToken: '' } }, done) {
++    /*
++    zoom restricts retrieval to 1 month range + records for 300 meetings
++      - if there's enough results to paginate, return that
++      - if there's not enough, keep grabbing older records until we get the max number of results or max date range
++    */
++    const oldestMonth = query.cursor ? parseInt(query.cursor) : 0
++    let nextPageToken = query.nextPageToken || ''
++    let response = null
++    const results = []
++    let initialMonth = 1
++
++    if (nextPageToken && oldestMonth) {
++      initialMonth = oldestMonth
++    } else if (oldestMonth) {
++      initialMonth += oldestMonth + 1
++    }
++
++    let monthsPastToQuery = initialMonth
++    let dateRange = this._getDateRange(monthsPastToQuery)
++
++    while (
++      !(response && response.body.next_page_token) &&
++      (monthsPastToQuery - initialMonth < MAX_MO_RANGE) &&
++      results.length < PAGE_SIZE
++    ) {
++      dateRange = this._getDateRange(monthsPastToQuery)
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from: dateRange.fromDate,
++        to: dateRange.toDate
++      }
++      if (nextPageToken) {
++        queryObj.next_page_token = nextPageToken
++      }
++      try {
++        response = await new Promise((resolve, reject) => this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++          .qs(queryObj)
++          .auth(token)
++          .request((err, resp, body) => {
++            if (err || resp.statusCode !== 200) {
++              reject(this._error(err, resp))
++            } else {
++              resolve(resp)
++            }
++          })
++        )
++      } catch (err) {
++        return done(err)
++      }
++
++      if (response.body.next_page_token) {
++        nextPageToken = response.body.next_page_token
++      } else {
++        monthsPastToQuery += 1
++      }
++      results.push(response.body)
++    }
++
++    done(null, this._adaptData(results, dateRange))
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          const file = resp.body.recording_files.find(file => file.id === fileId)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => done(null, null))
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp.body.recording_files.find(file => file.id === fileId)
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        done(null, file.file_size)
++      })
++  }
++
++  _adaptData (results, dateRange) {
++    if (!results || results.length === 0) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getQuery(results, dateRange),
++      monthsRetrieved: dateRange.monthsInPast,
++      items: []
++    }
++
++    results.forEach(res => {
++      res.meetings.forEach(meeting => {
++        meeting.recording_files.forEach((record, index) => {
++          data.items.push({","can we make this data adhere to all the fields here?
+```js
+items: [
+    {
+      // boolean value of whether or NOT it's a folder
+      isFolder: false,
+      // icon image URL
+      icon: 'https://random-api.url.com/fileicon.jpg',
+      // name of the item
+      name: 'myfile.jpg',
+      // the mime type of the item. Only relevant if the item is NOT a folder
+      mimeType: 'image/jpg',
+      // the id (in string) of the item
+      id: 'uniqueitemid',
+      // thumbnail image URL. Only relevant if the item is NOT a folder
+      thumbnail: 'https://random-api.url.com/filethumbnail.jpg',
+      // for folders this is typically the value that will be passed as ""directory"" in the list(...) method.
+      // For files, this is the value that will be passed as id in the download(...) method.
+      requestPath: 'file-or-folder-requestpath',
+      // datetime string (in ISO 8601 format) of when this item was last modified
+      modifiedDate: '2020-06-29T19:59:58Z',
+      // the size in bytes of the item. Only relevent if the item is NOT a folder
+      size: 278940,
+      custom: {
+        // an object that may contain some more custom fields that you may need to send to the client. Only add this object if you have a need for it.
+        customData1: 'the value',
+        customData2: 'the value',
+      },
+      // more items here
+    }
+  ]
+```
+
+so basically being explicit for every value. So for `isFolder` for example, I imagine that will be `false`. And fields that will not be specified like `icon` can be set to `null` (unless zoom actually provides icon URLs?)",2020-07-07 16:21:44
+855,"@@ -0,0 +1,26 @@
++'use strict'
++
++const RequestClient = require('./RequestClient')
++
++const _getName = (id) => {
++  return id.split('-').map((s) => s.charAt(0).toUpperCase() + s.slice(1)).join(' ')
++}
++
++module.exports = class SearchProvider extends RequestClient {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.provider = opts.provider
++    this.id = this.provider
++    this.name = this.opts.name || _getName(this.id)
++    this.pluginId = this.opts.pluginId
++  }
++
++  fileUrl (id) {
++    return `${this.hostname}/search/${this.id}/get/${id}`","This should _probably_ be URL-encoded? not totally sure
+```suggestion
+    return `${this.hostname}/search/${this.id}/get/${encodeURIComponent(id)}`
+```",2020-08-03 15:47:31
+856,"@@ -0,0 +1,26 @@
++'use strict'
++
++const RequestClient = require('./RequestClient')
++
++const _getName = (id) => {
++  return id.split('-').map((s) => s.charAt(0).toUpperCase() + s.slice(1)).join(' ')
++}
++
++module.exports = class SearchProvider extends RequestClient {
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.provider = opts.provider
++    this.id = this.provider
++    this.name = this.opts.name || _getName(this.id)
++    this.pluginId = this.opts.pluginId
++  }
++
++  fileUrl (id) {
++    return `${this.hostname}/search/${this.id}/get/${id}`
++  }
++
++  search (text, queries) {
++    queries = queries ? `&${queries}` : ''
++    return this.get(`search/${this.id}/list?q=${text}${queries}`)","But I am sure about this one 😄 
+```suggestion
+    return this.get(`search/${this.id}/list?q=${encodeURIComponent(text)}${queries}`)
+```",2020-08-03 15:48:02
+320,"@@ -0,0 +1,26 @@
++/* global window, capabilities */
++
++function selectFakeFile (uppyID) {
++  var blob = new Blob(
++    ['data:image/svg+xml;base64,PHN2ZyB2aWV3Qm94PSIwIDAgMTIwIDEyMCI+CiAgPGNpcmNsZSBjeD0iNjAiIGN5PSI2MCIgcj0iNTAiLz4KPC9zdmc+Cg=='],
++    { type: 'image/svg+xml' }
++  )
++  window[uppyID].addFile({
++    source: 'test',
++    name: 'test-file',
++    type: blob.type,
++    data: blob
++  })
++}
++
++function supportsChooseFile () {
++  // Webdriver for Safari and Edge doesn’t support .chooseFile
++  return capabilities.browserName !== 'safari' &&
++         capabilities.browserName !== 'MicrosoftEdge' &&
++         capabilities.platformName !== 'Android'
++}
++",Great idea with moving this to a method. Nice!,2018-07-18 04:01:50
+822,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })",so this is the oldest possible record for any user in zoom? No matter the account being used? 🤔 ,2020-07-13 09:35:14
+818,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''","ideally, there should always be a token, otherwise this request shouldn't be allowed to begin with. Is there a reason we are providing a fallback value here? Lint issue perhaps?",2020-07-13 08:51:05
+827,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }",it seems we're leaving out the `username` field. Is this deliberate? 🤔 ,2020-07-13 10:21:24
+821,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified,",this should probably be `modifiedDate: adapter.getDateFolderModified(end)` right?,2020-07-13 09:33:10
+828,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified,
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateQuery(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results || results.length === 0) {",is `results` expected to be an array? Looking further down the code it seems not?,2020-07-13 10:25:01
+829,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified,
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateQuery(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results || results.length === 0) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getQuery(results),
++      items: []
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      if (item.file_type && item.file_type === 'TIMELINE') {
++        console.log(item.download_url)",debug leftover? :),2020-07-13 10:26:05
+835,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified,
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateQuery(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results || results.length === 0) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getQuery(results),
++      items: []
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      if (item.file_type && item.file_type === 'TIMELINE') {
++        console.log(item.download_url)
++      }
++      data.items.push({
++        isFolder: adapter.getIsFolder(item),
++        icon: adapter.getIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getId(item),
++        thumbnail: null,
++        requestPath: adapter.getRequestPath(item),
++        modifiedDate: adapter.getStartDate(item),
++        size: null",are we meant to be calling `adapter.getSize` here?,2020-07-13 11:03:28
+836,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified,
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateQuery(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results || results.length === 0) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getQuery(results),
++      items: []
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      if (item.file_type && item.file_type === 'TIMELINE') {
++        console.log(item.download_url)
++      }
++      data.items.push({
++        isFolder: adapter.getIsFolder(item),
++        icon: adapter.getIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getId(item),
++        thumbnail: null,
++        requestPath: adapter.getRequestPath(item),
++        modifiedDate: adapter.getStartDate(item),
++        size: null
++      })
++    })
++    return data
++  }
++
++  logout ({ token }, done) {
++    const encodedAuth = Buffer.from(
++      `${process.env.COMPANION_ZOOM_KEY}:${process.env.COMPANION_ZOOM_SECRET}`, 'binary'
++    ).toString('base64')
++
++    return this.client
++      .get('logout')
++      .auth({ basic: encodedAuth })
++      .qs({ token })
++      .request((err, resp) => {
++        if (err || resp.statusCode !== 200) {
++          logger.error(err, 'provider.zoom.logout.error')
++          done(this._error(err, resp))
++          return
++        }
++        done(null, { revoked: true })
++      })
++  }
++
++  _error (err, resp) {
++    const customErrorCodes = [124, 401]
++    if (resp) {
++      const fallbackMessage = `request to ${this.authProvider} returned ${resp.statusCode}`
++      const errMsg = (resp.body && resp.body.error) ? resp.body.error.message : fallbackMessage","looking at the [API's error definition](https://marketplace.zoom.us/docs/api-reference/error-definitions), It doesn't seem there's an `error` field. Am I missing something?",2020-07-13 11:10:12
+837,"@@ -0,0 +1,262 @@
++const Provider = require('../Provider')
++const request = require('request')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const moment = require('moment')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++// oldest possible folder for any user
++const OLDEST_RECORD = moment().set({ year: 2014, month: 11 })
++
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - show 2 years by default, scroll for older folders
++    - drill down for rest
++    */
++    const token = options.token || ''
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          }
++          done(null, this._initializeData(end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            err = this._error(err, resp)
++            logger.error(err, 'provider.zoom.list.error')
++            return done(err)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err) {
++            this._downloadError(resp, done)
++            return
++          }
++          // timeline files don't have an ID
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const defaultLimit = end.clone().subtract('months', DEFAULT_RANGE_MOS)
++    const limit = defaultLimit > OLDEST_RECORD ? defaultLimit : OLDEST_RECORD
++
++    const data = {
++      items: []
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified,
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateQuery(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results || results.length === 0) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getQuery(results),
++      items: []
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      if (item.file_type && item.file_type === 'TIMELINE') {
++        console.log(item.download_url)
++      }
++      data.items.push({
++        isFolder: adapter.getIsFolder(item),
++        icon: adapter.getIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getId(item),
++        thumbnail: null,
++        requestPath: adapter.getRequestPath(item),
++        modifiedDate: adapter.getStartDate(item),
++        size: null
++      })
++    })
++    return data
++  }
++
++  logout ({ token }, done) {
++    const encodedAuth = Buffer.from(
++      `${process.env.COMPANION_ZOOM_KEY}:${process.env.COMPANION_ZOOM_SECRET}`, 'binary'
++    ).toString('base64')
++
++    return this.client
++      .get('logout')
++      .auth({ basic: encodedAuth })
++      .qs({ token })
++      .request((err, resp) => {
++        if (err || resp.statusCode !== 200) {
++          logger.error(err, 'provider.zoom.logout.error')
++          done(this._error(err, resp))
++          return
++        }
++        done(null, { revoked: true })
++      })
++  }
++
++  _error (err, resp) {
++    const customErrorCodes = [124, 401]
++    if (resp) {
++      const fallbackMessage = `request to ${this.authProvider} returned ${resp.statusCode}`
++      const errMsg = (resp.body && resp.body.error) ? resp.body.error.message : fallbackMessage
++      return customErrorCodes.indexOf(resp.statusCode) > -1 ? new ProviderAuthError() : new ProviderApiError(errMsg, resp.statusCode)",under what condition is the status code `124`? 🤔  I couldn't immediately find it in the documentation.,2020-07-13 11:12:08
+847,"@@ -0,0 +1,267 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const moment = require('moment')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const GET_USER_PATH = '/users/me'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++
++/**
++ * Adapter for API https://marketplace.zoom.us/docs/api-reference/zoom-api
++ */
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - returns list of months by default
++    - drill down for specific files in each month
++    */
++    const token = options.token
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_USER_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            return this._listError(err, resp, done)
++          }
++          done(null, this._initializeData(body, end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err ||
++            resp.statusCode !== 200
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    // timeline files don't have an ID or size
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err || resp.statusCode !== 200) {
++            return this._downloadError(resp, done)
++          }
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (body, initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const accountCreation = adapter.getAccountCreationDate(body)
++    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months')
++    const limit = accountCreation > defaultLimit ? accountCreation : defaultLimit
++
++    const data = {
++      items: [],
++      username: adapter.getUserEmail(body)
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified(end),
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateNextPagePath(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getNextPagePath(results),
++      items: [],
++      username: null
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      data.items.push({
++        isFolder: adapter.getIsFolder(item),
++        icon: adapter.getIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getId(item),
++        thumbnail: null,
++        requestPath: adapter.getRequestPath(item),
++        modifiedDate: adapter.getStartDate(item),
++        size: adapter.getSize(item)
++      })
++    })
++    return data
++  }
++
++  logout ({ token }, done) {
++    const encodedAuth = Buffer.from(
++      `${process.env.COMPANION_ZOOM_KEY}:${process.env.COMPANION_ZOOM_SECRET}`, 'binary'
++    ).toString('base64')
++    return this.client
++      .get('logout')
++      .auth({ basic: encodedAuth })",does `auth(encodedAuth)` not work here? I figured it should since we already specified the auth type [here](https://github.com/transloadit/uppy/blob/4a2ffe292f7eb679c111d776722adc0136d99879/packages/%40uppy/companion/src/server/provider/index.js#L36). Is this not the case?,2020-07-17 08:47:49
+843,"@@ -0,0 +1,274 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const moment = require('moment')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const GET_USER_PATH = '/users/me'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++
++/**
++ * Adapter for API https://marketplace.zoom.us/docs/api-reference/zoom-api
++ */
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - returns list of months by default
++    - drill down for specific files in each month
++    */
++    const token = options.token
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_USER_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200 || !body) {
++            return this._listError(err, resp, done)
++          }
++          done(null, this._initializeData(body, end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (
++            err ||
++            resp.statusCode !== 200 ||
++            !body",in what case is `body` falsy? 🤔 ,2020-07-16 04:01:16
+840,"@@ -0,0 +1,274 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const moment = require('moment')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const GET_USER_PATH = '/users/me'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++
++/**
++ * Adapter for API https://marketplace.zoom.us/docs/api-reference/zoom-api
++ */
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - returns list of months by default
++    - drill down for specific files in each month
++    */
++    const token = options.token
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_USER_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200 || !body) {
++            return this._listError(err, resp, done)
++          }
++          done(null, this._initializeData(body, end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (
++            err ||
++            resp.statusCode !== 200 ||
++            !body
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err ||
++            resp.statusCode !== 200 ||
++            !body
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    // timeline files don't have an ID or size
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err ||
++            resp.statusCode !== 200 ||
++            !resp.body
++          ) {
++            return this._downloadError(resp, done)
++          }
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (body, initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const accountCreation = adapter.getAccountCreationDate(body)
++    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months')
++    const limit = accountCreation > defaultLimit ? accountCreation : defaultLimit
++
++    const data = {
++      items: [],
++      username: adapter.getUserEmail(body)
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified(end),
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateNextPagePath(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getNextPagePath(results),
++      items: []
++    }",it seems we still aren't sending the username field for this case?,2020-07-16 03:36:46
+841,"@@ -0,0 +1,274 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const moment = require('moment')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const GET_USER_PATH = '/users/me'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++
++/**
++ * Adapter for API https://marketplace.zoom.us/docs/api-reference/zoom-api
++ */
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - returns list of months by default
++    - drill down for specific files in each month
++    */
++    const token = options.token
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_USER_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200 || !body) {
++            return this._listError(err, resp, done)
++          }
++          done(null, this._initializeData(body, end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (
++            err ||
++            resp.statusCode !== 200 ||
++            !body
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err ||
++            resp.statusCode !== 200 ||
++            !body
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    // timeline files don't have an ID or size
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err ||
++            resp.statusCode !== 200 ||
++            !resp.body
++          ) {
++            return this._downloadError(resp, done)
++          }
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (body, initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const accountCreation = adapter.getAccountCreationDate(body)
++    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months')
++    const limit = accountCreation > defaultLimit ? accountCreation : defaultLimit
++
++    const data = {
++      items: [],
++      username: adapter.getUserEmail(body)
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified(end),
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateNextPagePath(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getNextPagePath(results),
++      items: []
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      data.items.push({
++        isFolder: adapter.getIsFolder(item),
++        icon: adapter.getIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getId(item),
++        thumbnail: null,
++        requestPath: adapter.getRequestPath(item),
++        modifiedDate: adapter.getStartDate(item),
++        size: adapter.getSize(item)
++      })
++    })
++    return data
++  }
++
++  logout ({ token }, done) {
++    const encodedAuth = Buffer.from(
++      `${process.env.COMPANION_ZOOM_KEY}:${process.env.COMPANION_ZOOM_SECRET}`, 'binary'
++    ).toString('base64')
++    return this.client
++      .get('logout')",should we be calling the [revoke endpoint](https://marketplace.zoom.us/docs/guides/auth/oauth#revoking) instead? Are they the same?,2020-07-16 03:45:30
+842,"@@ -0,0 +1,274 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const moment = require('moment')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const GET_USER_PATH = '/users/me'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++
++/**
++ * Adapter for API https://marketplace.zoom.us/docs/api-reference/zoom-api
++ */
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - returns list of months by default
++    - drill down for specific files in each month
++    */
++    const token = options.token
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++
++    if (!from && !to && !meetingId) {
++      const end = cursor && moment(cursor)
++      this.client.get(`${BASE_URL}${GET_USER_PATH}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err || resp.statusCode !== 200 || !body) {
++            return this._listError(err, resp, done)
++          }
++          done(null, this._initializeData(body, end))
++        })
++    }
++
++    if (from && to) {
++      const queryObj = {
++        page_size: PAGE_SIZE,
++        from,
++        to
++      }
++
++      if (cursor) {
++        queryObj.next_page_token = cursor
++      }
++
++      this.client.get(`${BASE_URL}${GET_LIST_PATH}`)
++        .qs(queryObj)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (
++            err ||
++            resp.statusCode !== 200 ||
++            !body
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++
++    if (meetingId) {
++      const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp, body) => {
++          if (err ||
++            resp.statusCode !== 200 ||
++            !body
++          ) {
++            return this._listError(err, resp, done)
++          } else {
++            done(null, this._adaptData(body))
++          }
++        })
++    }
++  }
++
++  download ({ id, token, query }, done) {
++    // meeting id + file id required
++    // timeline files don't have an ID or size
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    const downloadUrlPromise = new Promise((resolve) => {
++      this.client
++        .get(`${BASE_URL}${GET_MEETING_FILES}`)
++        .auth(token)
++        .request((err, resp) => {
++          if (err ||
++            resp.statusCode !== 200 ||
++            !resp.body
++          ) {
++            return this._downloadError(resp, done)
++          }
++          const file = resp
++            .body
++            .recording_files
++            .find(file => fileId === file.id || fileId === file.file_type)
++          if (!file || !file.download_url) {
++            return this._downloadError(resp, done)
++          }
++          resolve(file.download_url)
++        })
++    })
++    downloadUrlPromise.then((downloadUrl) => {
++      this.client
++        .get(`${downloadUrl}?access_token=${token}`)
++        .request()
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            done(this._error(null, resp))
++          } else {
++            resp.on('data', (chunk) => done(null, chunk))
++          }
++        })
++        .on('end', () => {
++          done(null, null)
++        })
++        .on('error', (err) => {
++          logger.error(err, 'provider.zoom.download.error')
++          done(err)
++        })
++    })
++  }
++
++  size ({ id, token, query }, done) {
++    const meetingId = id
++    const fileId = query.recordingId
++    const GET_MEETING_FILES = `/meetings/${meetingId}/recordings`
++
++    return this.client
++      .get(`${BASE_URL}${GET_MEETING_FILES}`)
++      .auth(token)
++      .request((err, resp, body) => {
++        if (err || resp.statusCode !== 200) {
++          return this._downloadError(resp, done)
++        }
++        const file = resp
++          .body
++          .recording_files
++          .find(file => file.id === fileId || file.file_type === fileId)
++
++        if (!file) {
++          return this._downloadError(resp, done)
++        }
++        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
++        const maxExportFileSize = 1024 * 1024
++        done(null, file.file_size || maxExportFileSize)
++      })
++  }
++
++  _initializeData (body, initialEnd = null) {
++    let end = initialEnd || moment()
++    let start = end.clone().date(1)
++
++    const accountCreation = adapter.getAccountCreationDate(body)
++    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months')
++    const limit = accountCreation > defaultLimit ? accountCreation : defaultLimit
++
++    const data = {
++      items: [],
++      username: adapter.getUserEmail(body)
++    }
++
++    while (start > limit) {
++      start = end.clone().date(1)
++      data.items.push({
++        isFolder: true,
++        icon: 'folder',
++        name: adapter.getDateName(start, end),
++        mimeType: null,
++        id: adapter.getDateFolderId(start, end),
++        thumbnail: null,
++        requestPath: adapter.getDateFolderRequestPath(start, end),
++        modifiedDate: adapter.getDateFolderModified(end),
++        size: null
++      })
++      end = start.clone().subtract(1, 'days')
++    }
++    data.nextPagePath = adapter.getDateNextPagePath(start)
++    return data
++  }
++
++  _adaptData (results) {
++    if (!results) {
++      return { items: [] }
++    }
++
++    const data = {
++      nextPagePath: adapter.getNextPagePath(results),
++      items: []
++    }
++    const items = results.meetings || results.recording_files
++    items.forEach(item => {
++      data.items.push({
++        isFolder: adapter.getIsFolder(item),
++        icon: adapter.getIcon(item),
++        name: adapter.getItemName(item),
++        mimeType: adapter.getMimeType(item),
++        id: adapter.getId(item),
++        thumbnail: null,
++        requestPath: adapter.getRequestPath(item),
++        modifiedDate: adapter.getStartDate(item),
++        size: adapter.getSize(item)
++      })
++    })
++    return data
++  }
++
++  logout ({ token }, done) {
++    const encodedAuth = Buffer.from(
++      `${process.env.COMPANION_ZOOM_KEY}:${process.env.COMPANION_ZOOM_SECRET}`, 'binary'
++    ).toString('base64')
++    return this.client
++      .get('logout')
++      .auth({ basic: encodedAuth })
++      .qs({ token })
++      .request((err, resp) => {
++        if (err || resp.statusCode !== 200) {
++          logger.error(err, 'provider.zoom.logout.error')
++          done(this._error(err, resp))
++          return
++        }
++        done(null, { revoked: true })
++      })
++  }
++
++  _error (err, resp) {
++    const authErrorCodes = [
++      124, // expired token
++      401
++    ]
++    if (resp.body) {
++      const fallbackMessage = `request to ${this.authProvider} returned ${resp.statusCode}`
++      const errMsg = resp.body.message || fallbackMessage
++      return authErrorCodes.indexOf(resp.statusCode) > -1 ? new ProviderAuthError() : new ProviderApiError(errMsg, resp.statusCode)
++    }
++    return err || 'No response'","I think we should follow same style [as others](https://github.com/transloadit/uppy/blob/e9651443c7eb1eca0de93d98b3d960d7738efd19/packages/%40uppy/companion/src/server/provider/onedrive/index.js#L138-L144), so something like:
+
+```js
+const authErrorCodes = [
+      124, // expired token
+      401
+]
+if (resp) {
+      const fallbackMsg = `request to ${this.authProvider} returned ${resp.statusCode}`
+      const errMsg = (resp.body || {}).message ? resp.body.message : fallbackMsg
+      return authErrorCodes.indexOf(resp.statusCode) > -1 ? new ProviderAuthError() : new ProviderApiError(errMsg, resp.statusCode)
+}
+
+return err
+```
+
+so even when there's no response body, we'll at least be sending back the status code",2020-07-16 03:59:54
+967,"@@ -0,0 +1,28 @@
++# @uppy/svelte
++
++<img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" width=""120"" alt=""Uppy logo: a superman puppy in a pink suit"" align=""right"">
++
++<a href=""https://www.npmjs.com/package/@uppy/svelte""><img src=""https://img.shields.io/npm/v/@uppy/svelte.svg?style=flat-square""></a>
++<a href=""https://travis-ci.org/transloadit/uppy""><img src=""https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square"" alt=""Build Status""></a>
++
++Svelte component wrappers around Uppy's officially maintained UI plugins.
++
++Uppy is being developed by the folks at [Transloadit](https://transloadit.com), a versatile file encoding service.
++
++
++## Installation
++
++```bash
++$ npm install @uppy/svelte
++```
++
++We recommend installing from npm and then using a module bundler such as [Webpack](https://webpack.js.org/), [Browserify](http://browserify.org/) or [Rollup.js](http://rollupjs.org/).",Should we instead point to Svelte guide or mention Rollup?,2020-12-21 22:49:43
+860,"@@ -0,0 +1,28 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. So what are the changes you'd expect to see on Companion 2.0?
++
++## Node >= v10
++
++As you must have heard, Node v8.x has reached EOL, and in turn Companion 2.0 drops support for Node v6.x, Node v8.x and now requires that you run at least Node v10.x.","imho we can shorten this a bit and explain the acronym. I think the ""official"" spelling for node versions is ""Node.js X.Y.Z"", without a `v`, but people would understand either way :)
+```suggestion
+Node.js 8.x has reached End-of-life, and in turn Companion 2.0 drops support for Node.js 6.x, Node.js 8.x and now requires that you run at least Node.js 10.x.
+```",2020-08-17 08:06:08
+862,"@@ -0,0 +1,28 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. So what are the changes you'd expect to see on Companion 2.0?
++
++## Node >= v10
++
++As you must have heard, Node v8.x has reached EOL, and in turn Companion 2.0 drops support for Node v6.x, Node v8.x and now requires that you run at least Node v10.x.
++
++## Renamed Provider Options
++
++Pre 2.0 there were inconsistencies in relation to the Provider names. In some places, the Google Drive provider was referred to as *google* (e.g in `providerOptions`) and in some other places, it was referred to as *drive* (e.g the server endpoints `/drive/list`). In Companion 2.0 it is now made to have the consistent name *drive* everywhere. Similarly the OneDrive provider is made to have the consistent name *onedrive* for the same reason.
++
++## Changed Redirect URIs
++
++On the journey to have more consistent naming with the providers (mentioned above), we have made changes to the redirect URIs that is supplied during the OAuth process. For example, for Google Drive, the old redirect URI was of the form `https://mycompanionwebsite.tld/connect/google/callback`. In Companion 2.0, this is now changed to `https://mycompanionwebsite.tld/drive/redirect`. This is a Breaking Change and it means you would need to make these corresponding changes to your redirect URIs on your Providers' API Dashboards.","I think this first sentence is also a bit lengthy but I don't have a good suggestion to improve it, so maybe we should ask AJ for some expert editing later :)",2020-08-17 08:09:46
+861,"@@ -0,0 +1,28 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. So what are the changes you'd expect to see on Companion 2.0?
++
++## Node >= v10
++
++As you must have heard, Node v8.x has reached EOL, and in turn Companion 2.0 drops support for Node v6.x, Node v8.x and now requires that you run at least Node v10.x.
++
++## Renamed Provider Options
++
++Pre 2.0 there were inconsistencies in relation to the Provider names. In some places, the Google Drive provider was referred to as *google* (e.g in `providerOptions`) and in some other places, it was referred to as *drive* (e.g the server endpoints `/drive/list`). In Companion 2.0 it is now made to have the consistent name *drive* everywhere. Similarly the OneDrive provider is made to have the consistent name *onedrive* for the same reason.
++
++## Changed Redirect URIs
++
++On the journey to have more consistent naming with the providers (mentioned above), we have made changes to the redirect URIs that is supplied during the OAuth process. For example, for Google Drive, the old redirect URI was of the form `https://mycompanionwebsite.tld/connect/google/callback`. In Companion 2.0, this is now changed to `https://mycompanionwebsite.tld/drive/redirect`. This is a Breaking Change and it means you would need to make these corresponding changes to your redirect URIs on your Providers' API Dashboards.
++
++## Compatibility with Uppy 1.x client
++
++Compannion 2.0 is compatible with any Uppy 1.x version, so you don't have to worry what Companion version a server may be runnning before using your Uppy client with it.","lil typo
+```suggestion
+Companion 2.0 is compatible with any Uppy 1.x version, so you don't have to worry what Companion version a server may be runnning before using your Uppy client with it.
+```",2020-08-17 08:06:32
+849,"@@ -0,0 +1,294 @@
++const Provider = require('../Provider')
++
++const request = require('request')
++const moment = require('moment')
++const purest = require('purest')({ request })
++const logger = require('../../logger')
++const adapter = require('./adapter')
++const { ProviderApiError, ProviderAuthError } = require('../error')
++
++const BASE_URL = 'https://zoom.us/v2'
++const GET_LIST_PATH = '/users/me/recordings'
++const GET_USER_PATH = '/users/me'
++const PAGE_SIZE = 300
++const DEFAULT_RANGE_MOS = 23
++
++/**
++ * Adapter for API https://marketplace.zoom.us/docs/api-reference/zoom-api
++ */
++class Zoom extends Provider {
++  constructor (options) {
++    super(options)
++    this.authProvider = options.provider = Zoom.authProvider
++    this.client = purest(options)
++  }
++
++  static get authProvider () {
++    return 'zoom'
++  }
++
++  list (options, done) {
++    /*
++    - returns list of months by default
++    - drill down for specific files in each month
++    */
++    const token = options.token
++    const query = options.query || {}
++    const { cursor, from, to } = query
++    const meetingId = options.directory || ''
++    let meetingsPromise = Promise.resolve(undefined)
++    let recordingsPromise = Promise.resolve(undefined)",this is set up this way to try and match up the style in the drive provider,2020-07-17 15:56:49
+23,"@@ -0,0 +1,295 @@
++import AuthView from './AuthView'
++import Browser from './new/Browser'
++import ErrorView from './Error'
++
++/**
++ * Class to easily generate generic views for plugins
++ *
++ * This class expects the plugin using to have the following attributes
++ *
++ * stateId {String} object key of which the plugin state is stored
++ *
++ * This class also expects the plugin instance using it to have the following
++ * accessor methods.
++ * Each method takes the item whose property is to be accessed
++ * as a param
++ *
++ * isFolder
++ *    @return {Boolean} for if the item is a folder or not
++ * getItemData
++ *    @return {Object} that is format ready for uppy upload/download
++ * getItemIcon
++ *    @return {Object} html instance of the item's icon
++ * getItemSubList
++ *    @return {Array} sub-items in the item. e.g a folder may contain sub-items
++ * getItemName
++ *    @return {String} display friendly name of the item
++ * getMimeType
++ *    @return {String} mime type of the item
++ * getItemId
++ *    @return {String} unique id of the item
++ * getItemRequestPath
++ *    @return {String} unique request path of the item when making calls to uppy server
++ * getItemModifiedDate
++ *    @return {object} or {String} date of when last the item was modified
++ */",👌 💯 ,2016-12-20 05:31:05
+987,"@@ -0,0 +1,3 @@
++export const isVue2 = (...args) => {","I think we should ignore the warning in this case: This file is intended to be a bag of semi-related functions, it just happens to only contain one function right now.
+
+```suggestion
+// eslint-disable-next-line import/prefer-default-export
+export const isVue2 = (...args) => {
+```",2021-03-23 15:00:21
+442,"@@ -0,0 +1,3 @@
++flask
++werkzeug
++flask-cors","probably an extraneous file? python-xhr and php-xhr both have a requirements.txt, should only be python i think?",2019-04-17 14:23:08
+867,"@@ -0,0 +1,30 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. Why you ask? Well, the drive on this release is mainly towards fixing some terminology inconsistencies and aligning with Node.js LTS to ease the maintenance burden.","After reading, as a reader, i'm left wondering what is to become of the v1 branch. Will it still be maintained and receive patches? For how long?",2020-08-21 09:53:26
+864,"@@ -0,0 +1,30 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. Why you ask? Well, the drive on this release is mainly towards fixing some terminology inconsistencies and aligning with Node.js LTS to ease the maintenance burden.
++
++So what are the changes you'd expect to see on Companion 2.0?
++
++## Node >= v10
++
++Node.js 8.x has reached End-of-life, and in turn Companion 2.0 drops support for Node.js 6.x, Node.js 8.x and now requires that you run at least Node.js 10.x.",Not just any 10.x right? Ten point something something?,2020-08-21 09:48:52
+865,"@@ -0,0 +1,30 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. Why you ask? Well, the drive on this release is mainly towards fixing some terminology inconsistencies and aligning with Node.js LTS to ease the maintenance burden.
++
++So what are the changes you'd expect to see on Companion 2.0?
++
++## Node >= v10
++
++Node.js 8.x has reached End-of-life, and in turn Companion 2.0 drops support for Node.js 6.x, Node.js 8.x and now requires that you run at least Node.js 10.x.
++
++## Renamed Provider Options
++
++Pre 2.0 there were inconsistencies in relation to the Provider names. In some places, the Google Drive provider was referred to as *google* (e.g in `providerOptions`) and in some other places, it was referred to as *drive* (e.g the server endpoints `/drive/list`). In Companion 2.0 it is now made to have the consistent name *drive* everywhere. Similarly the OneDrive provider is made to have the consistent name *onedrive* for the same reason.
++
++## Changed Redirect URIs
++
++Still on consistent naming, we have made some changes to the redirect URIs supplied during the OAuth process. For example, for Google Drive, the old redirect URI was of the form `https://mycompanionwebsite.tld/connect/google/callback`. In Companion 2.0, this is now changed to `https://mycompanionwebsite.tld/drive/redirect`. This is a Breaking Change and it means you would need to make these corresponding changes to your redirect URIs on your Providers' API Dashboards.
++
++## Compatibility with Uppy 1.x client
++
++Companion 2.0 is compatible with any Uppy 1.x version, so you don't have to worry what Companion version a server may be runnning before using your Uppy client with it.","How about: So you don't have to worry that all clients also need to upgrade their Uppy client installations when you upgrade Companion on your server, at the exact same time.
+
+Or similar?",2020-08-21 09:50:24
+866,"@@ -0,0 +1,30 @@
++---
++title: ""Companion 2.0 is here""
++date: 2020-08-20
++author: ife
++published: false
++---
++
++Companion 2.0 is here! 🎉 After maintaining and improving the 1.x series for over a year, we're releasing a Major version bump on the Companion package. Why you ask? Well, the drive on this release is mainly towards fixing some terminology inconsistencies and aligning with Node.js LTS to ease the maintenance burden.
++
++So what are the changes you'd expect to see on Companion 2.0?
++
++## Node >= v10
++
++Node.js 8.x has reached End-of-life, and in turn Companion 2.0 drops support for Node.js 6.x, Node.js 8.x and now requires that you run at least Node.js 10.x.
++
++## Renamed Provider Options
++
++Pre 2.0 there were inconsistencies in relation to the Provider names. In some places, the Google Drive provider was referred to as *google* (e.g in `providerOptions`) and in some other places, it was referred to as *drive* (e.g the server endpoints `/drive/list`). In Companion 2.0 it is now made to have the consistent name *drive* everywhere. Similarly the OneDrive provider is made to have the consistent name *onedrive* for the same reason.
++
++## Changed Redirect URIs
++
++Still on consistent naming, we have made some changes to the redirect URIs supplied during the OAuth process. For example, for Google Drive, the old redirect URI was of the form `https://mycompanionwebsite.tld/connect/google/callback`. In Companion 2.0, this is now changed to `https://mycompanionwebsite.tld/drive/redirect`. This is a Breaking Change and it means you would need to make these corresponding changes to your redirect URIs on your Providers' API Dashboards.
++
++## Compatibility with Uppy 1.x client
++
++Companion 2.0 is compatible with any Uppy 1.x version, so you don't have to worry what Companion version a server may be runnning before using your Uppy client with it.
++
++## Migrating from Companion 1.x to 2.x
++
++Given the breaking changes, we've put together a list of changes to make if you'd like to upgrade to Companion 2.0. You can have a look at this list [here](https://uppy.io/docs/companion/#Migrating-v1-to-v2).","As a best practice, link `We've created a [migration tutorial for upgrading from Companion v1 to v2].` vs linking `you can find it [here]`.",2020-08-21 09:52:32
+94,"@@ -0,0 +1,31 @@
++const DashboardPlugin = require('../../plugins/Dashboard')
++
++/**
++ * A version of the Dashboard plugin that externalises the modal open state
++ * management, allowing the React component wrapper to open and close it at
++ * will.
++ */
++class ReactDashboardPlugin extends DashboardPlugin {
++  constructor (core, opts) {","I’m a little worried about doing this. Could we maybe add onRequestClose/hideModal callback into the Dashboard plugin itself? Otherwise its third-level of class nesting, which is not that bad, but starting to feel like a dangerous territory :)",2017-09-03 13:32:51
+437,"@@ -0,0 +1,32 @@
++---
++title: ""Day 21""
++date: 2019-04-15
++author: tyler
++image: ""https://uppy.io/images/blog/30daystoliftoff/day21.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++We're reaching the final stretch of our '30 Days to Liftoff' blog post challenge. After a refreshing weekend the entire team is ready to give it their all over the next 10 days to ensure that **Uppy 1.0 reaches its April 25** release date.
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day21.jpg""><br /><br /></center>
++
++Since we're starting the week strong and prepared (as usual) let's take a quick glance at how our Uppy dashboard is looking.",">we're starting the week strong and prepared (as usual)
+
+a bit too strong/macho for my taste",2019-04-15 11:36:02
+443,"@@ -0,0 +1,33 @@
++---
++title: ""Day 24""
++date: 2019-04-18
++author: tyler
++published: true
++image: ""https://uppy.io/images/blog/30daystoliftoff/day24.gif""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Six days remain in our '30 Days to Liftoff' blog post challenge. There's not long left until our planned **Uppy 1.0 release on April 25** release so let's take a look at how close we are to reaching our goal! 
++",release repeated 2 times,2019-04-18 11:44:36
+444,"@@ -0,0 +1,33 @@
++---
++title: ""Day 24""
++date: 2019-04-18
++author: tyler
++published: true
++image: ""https://uppy.io/images/blog/30daystoliftoff/day24.gif""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Six days remain in our '30 Days to Liftoff' blog post challenge. There's not long left until our planned **Uppy 1.0 release on April 25** release so let's take a look at how close we are to reaching our goal! 
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day24.gif""><br /><br /></center>
++
++<!--more-->
++
++- [Evgenia](https://github.com/lakesare) has made some great progress on improving the [drag to upload state](https://github.com/transloadit/uppy/pull/1440) for the Uppy Dashboard in a variety of browsers. Currently more MIME types are being added to give file previews their own unique icons.
++","> Currently more MIME types are being added
+
+We are considering adding more later",2019-04-18 11:45:10
+445,"@@ -0,0 +1,33 @@
++---
++title: ""Day 24""
++date: 2019-04-18
++author: tyler
++published: true
++image: ""https://uppy.io/images/blog/30daystoliftoff/day24.gif""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Six days remain in our '30 Days to Liftoff' blog post challenge. There's not long left until our planned **Uppy 1.0 release on April 25** release so let's take a look at how close we are to reaching our goal! 
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day24.gif""><br /><br /></center>
++
++<!--more-->
++
++- [Evgenia](https://github.com/lakesare) has made some great progress on improving the [drag to upload state](https://github.com/transloadit/uppy/pull/1440) for the Uppy Dashboard in a variety of browsers. Currently more MIME types are being added to give file previews their own unique icons.
++
++- [Alex's](https://github.com/nqst) [design facelift](https://github.com/transloadit/uppy/pull/1452) was completed after some testing by [Artur](https://github.com/arturi). Take a look at some of the improvements below:
++
++<center><br /><img src=""/images/blog/30daystoliftoff/2019-04-18-design.png""><br /></center>
++
++- [Tim](https://github.com/tim-kos) will be spending today thoroughly testing Uppy in preparation for the upcoming release. We're making some big behind the scenes changes so there may be some issues that crop up on our webpage. 
++
++- Uppy 0.30.5 will be released by [Artur](https://github.com/arturi) today. One of the main changes here is our name change from the `serverUrl` property to `companionUrl`. A simple check if being added, and we will notify users that it has been depreceated so they have ample time to make the change within their code.
++
++- [React Native](https://github.com/transloadit/uppy/pull/988) was merged into our Uppy master branch on Github. We're confident that our initial release will be useful for those who need a basic implementation. Of course our React Native development will continue, so stay tuned for that. 
++",I’d add that this is an alpha-version of React Native support.,2019-04-18 11:46:25
+550,"@@ -0,0 +1,33 @@
++// Adapted from https://github.com/Flet/prettier-bytes/
++// Changing 1000 bytes to 1024, so we can keep uppercase KB vs kB","maybe add
+```patch
++// ISC License (c) Dan Flettre https://github.com/Flet/prettier-bytes/blob/master/LICENSE
+```",2019-07-15 13:55:57
+992,"@@ -0,0 +1,33 @@
++{
++  ""name"": ""@uppy/drop-target"",
++  ""description"": ""Lets your users drag and drop and paste files on any of your existing DOM elements. Most likely document.body"",","```suggestion
+  ""description"": ""Lets your users drag and drop files on a DOM element"",
+```
+shorter = better(?)
+
+might be good to update all the descriptions to a common format, ""Uppy plugin for importing files from..."" ""Uppy plugin for receiving dropped files"" etc. but that's a separate issue :)",2021-03-31 11:52:31
+993,"@@ -0,0 +1,33 @@
++{
++  ""name"": ""@uppy/drop-target"",
++  ""description"": ""Lets your users drag and drop and paste files on any of your existing DOM elements. Most likely document.body"",
++  ""version"": ""0.1.0"",
++  ""license"": ""MIT"",
++  ""main"": ""lib/index.js"",
++  ""types"": ""types/index.d.ts"",
++  ""keywords"": [
++    ""file uploader"",
++    ""uppy"",
++    ""uppy-plugin"",
++    ""drag-drop"",
++    ""drag"",
++    ""drop"",
++    ""dropzone"",
++    ""upload"",
++    ""paste""","
+```suggestion
+    ""upload""
+```",2021-03-31 11:52:40
+710,"@@ -0,0 +1,33 @@
++{
++  ""name"": ""@uppy/screen-capture"",
++  ""description"": ""Uppy plugin that captures video from display or application."",
++  ""version"": ""1.0.0"",
++  ""license"": ""MIT"",
++  ""main"": ""lib/index.js"",
++  ""style"": ""dist/style.min.css"",
++  ""types"": ""types/index.d.ts"",
++  ""keywords"": [
++    ""file uploader"",
++    ""uppy"",
++    ""uppy-plugin"",
++    ""screen capture"",
++    ""video"",
++    ""record"",
++    ""mediarecorder""
++  ],
++  ""homepage"": ""https://uppy.io"",
++  ""bugs"": {
++    ""url"": ""https://github.com/transloadit/uppy/issues""
++  },
++  ""repository"": {
++    ""type"": ""git"",
++    ""url"": ""git+https://github.com/transloadit/uppy.git""
++  },
++  ""dependencies"": {
++    ""@uppy/utils"": ""file:../utils"",
++    ""preact"": ""8.2.9""
++  },
++  ""peerDependencies"": {
++    ""@uppy/core"": ""^1.0.0""
++  }","We should add
+```json
+""publishConfig"": {
+  ""access"": ""public""
+}
+```
+so npm doesn't try to create a private package once this is published for the first time (which would fail the lerna publish midway)",2020-03-16 10:39:15
+948,"@@ -0,0 +1,33 @@
++{
++  ""name"": ""@uppy/vue"",
++  ""version"": ""0.0.1"",
++  ""private"": false,
++  ""main"": ""lib/index.js"",
++  ""types"": ""types/index.d.ts"",
++  ""scripts"": {
++    ""build"": ""tsc"",
++    ""dev"": ""parcel src/index.ts  --out-dir lib""
++  },
++  ""peerDependencies"": {
++    ""@uppy/core"": ""^1.0.0"",
++    ""vue"": "">=2.6.11""
++  },
++  ""dependencies"": {
++    ""shallow-equal"": ""^1.2.1"",
++    ""@uppy/dashboard"": ""^1.12.5"",
++    ""@uppy/drag-drop"": ""^1.4.18"",
++    ""@uppy/progress-bar"": ""^1.3.18"",
++    ""@uppy/status-bar"": ""^1.7.5""
++  },
++  ""devDependencies"": {
++    ""@uppy/core"": ""^1.0.0"",
++    ""@uppy/dashboard"": ""^1.12.5"",
++    ""@uppy/drag-drop"": ""^1.4.18"",
++    ""@uppy/progress-bar"": ""^1.3.18"",
++    ""@uppy/status-bar"": ""^1.7.5"",
++    ""@vue/component-compiler-utils"": ""^3.2.0"",
++    ""parcel-bundler"": ""^1.12.4"",
++    ""typescript"": ""^4.0.3"",
++    ""vue"": ""^2.6.12""
++  }","```suggestion
+},
+""publishConfig"": {
+  ""access"": ""public""
+}
+```",2020-11-19 01:57:29
+179,"@@ -0,0 +1,333 @@
++import ThumbnailGeneratorPlugin from './index'
++import Plugin from '../../core/Plugin'
++
++const delay = duration => new Promise(resolve => setTimeout(resolve, duration))
++
++describe('uploader/ThumbnailGeneratorPlugin', () => {
++  it('should initialise successfully', () => {
++    const redux = new ThumbnailGeneratorPlugin(null, {})
++    expect(redux instanceof Plugin).toEqual(true)",minor copy-paste nit: description says `uploader/ThumbnailGeneratorPlugin` and this var is named `redux`,2017-12-20 18:02:53
+438,"@@ -0,0 +1,34 @@
++---
++title: ""Day 21""
++date: 2019-04-15
++author: tyler
++image: ""https://uppy.io/images/blog/30daystoliftoff/day21.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++We're reaching the final stretch of our '30 Days to Liftoff' blog post challenge. After a refreshing weekend the entire team is ready to give it their all over the next 10 days to ensure that **Uppy 1.0 reaches its April 25** release date.
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day21.jpg""><br /><br /></center>
++
++Since we're starting the week strong and prepared let's take a quick glance at how our Uppy dashboard is looking.
++
++<!--more-->
++
++<center><img width="""" src=""/images/blog/30daystoliftoff/15-dashboard.png""><br/><br/></center>
++
++There still a few unique, and possibly daunting, tasks left for the remainder of the development cycle but the team is taking each issue in stride and adding features with ease.
++
++- [Ife](https://github.com/ifedapoolarewaju) [fixed a bug](https://github.com/transloadit/uppy/commit/9f02d749b9aa4095e5871713ea2f25a716a21539) on the React Native side of things to get rid of an error that was present on one of our Android examples. Additionally, he also made some name changes in a number of files - changing `serverUrl` to `companionUrl` and `serverPattern` to `companionAllowedHosts`.
++","> present on one of our Android examples
+
+we don’t have an Android-specific example, so he just fixed the example",2019-04-15 12:39:23
+408,"@@ -0,0 +1,35 @@
++'use strict'
++/**
++ * This module serves as an Async wrapper for LocalStorage
++ */
++module.exports.setItem = (key, value) => {
++  return new Promise((resolve, reject) => {
++    try {
++      localStorage.setItem(key, value)
++      resolve()
++    } catch (error) {
++      reject(error)
++    }","a minor thing, but the Promise constructor already catches errors, so you can omit the try/catch and the behaviour is the same:
+
+```js
+return new Promise((resolve) => {
+  localStorage.setItem(key, value)
+  resolve()
+})
+```",2019-03-25 10:31:09
+426,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);",No consistent indentation in this file,2019-04-09 11:32:22
+427,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")",Please use triple equality,2019-04-09 11:32:35
+428,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")
++{
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_METHOD""]))",please wrap if contents in `{}`,2019-04-09 11:32:47
+429,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")
++{
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_METHOD""]))
++        header(""Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT""); //Make sure you remove those you do not want to support
++        header(""Access-Control-Allow-Origin: *"");
++
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_HEADERS""]))
++        header(""Access-Control-Allow-Headers: {$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}"");
++
++    //Just exit with 200 OK with the above headers for OPTIONS method
++    exit(0);
++}
++
++if($_POST) {","Maybe change to `!empty($_FILES[""files""])`",2019-04-09 11:33:26
+430,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")
++{
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_METHOD""]))
++        header(""Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT""); //Make sure you remove those you do not want to support
++        header(""Access-Control-Allow-Origin: *"");
++
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_HEADERS""]))
++        header(""Access-Control-Allow-Headers: {$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}"");
++
++    //Just exit with 200 OK with the above headers for OPTIONS method
++    exit(0);
++}
++
++if($_POST) {
++      $target_dir = ""./uploads/"";
++      $target_file = $target_dir . basename($_FILES[""files""][""name""][0]);
++      if (move_uploaded_file($_FILES[""files""][""tmp_name""][0], $target_file)) {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');
++        $data = [""url"" => $target_file, ""message"" => ""The file "". basename( $_FILES[""files""][""name""][0]). "" has been uploaded.""];",inconsistent whitespace regarding concatenation here,2019-04-09 11:33:49
+431,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")
++{
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_METHOD""]))
++        header(""Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT""); //Make sure you remove those you do not want to support
++        header(""Access-Control-Allow-Origin: *"");
++
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_HEADERS""]))
++        header(""Access-Control-Allow-Headers: {$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}"");
++
++    //Just exit with 200 OK with the above headers for OPTIONS method
++    exit(0);
++}
++
++if($_POST) {
++      $target_dir = ""./uploads/"";
++      $target_file = $target_dir . basename($_FILES[""files""][""name""][0]);
++      if (move_uploaded_file($_FILES[""files""][""tmp_name""][0], $target_file)) {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');
++        $data = [""url"" => $target_file, ""message"" => ""The file "". basename( $_FILES[""files""][""name""][0]). "" has been uploaded.""];
++        http_response_code(201);
++        echo json_encode( $data );
++      } else {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');",Mixing of single & double quotes,2019-04-09 11:34:00
+433,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")
++{
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_METHOD""]))
++        header(""Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT""); //Make sure you remove those you do not want to support
++        header(""Access-Control-Allow-Origin: *"");
++
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_HEADERS""]))
++        header(""Access-Control-Allow-Headers: {$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}"");
++
++    //Just exit with 200 OK with the above headers for OPTIONS method
++    exit(0);
++}
++
++if($_POST) {
++      $target_dir = ""./uploads/"";
++      $target_file = $target_dir . basename($_FILES[""files""][""name""][0]);
++      if (move_uploaded_file($_FILES[""files""][""tmp_name""][0], $target_file)) {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');
++        $data = [""url"" => $target_file, ""message"" => ""The file "". basename( $_FILES[""files""][""name""][0]). "" has been uploaded.""];
++        http_response_code(201);
++        echo json_encode( $data );
++      } else {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');
++        $data = [""message"" => ""Sorry, there was an error uploading your file.""];",More descriptive error would be good,2019-04-09 11:35:26
+432,"@@ -0,0 +1,35 @@
++<?php
++ini_set('display_errors', 1);
++ini_set('display_startup_errors', 1);
++error_reporting(E_ALL);
++
++if($_SERVER[""REQUEST_METHOD""] == ""OPTIONS"")
++{
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_METHOD""]))
++        header(""Access-Control-Allow-Methods: POST, GET, OPTIONS, DELETE, PUT""); //Make sure you remove those you do not want to support
++        header(""Access-Control-Allow-Origin: *"");
++
++    if (isset($_SERVER[""HTTP_ACCESS_CONTROL_REQUEST_HEADERS""]))
++        header(""Access-Control-Allow-Headers: {$_SERVER['HTTP_ACCESS_CONTROL_REQUEST_HEADERS']}"");
++
++    //Just exit with 200 OK with the above headers for OPTIONS method
++    exit(0);
++}
++
++if($_POST) {
++      $target_dir = ""./uploads/"";
++      $target_file = $target_dir . basename($_FILES[""files""][""name""][0]);
++      if (move_uploaded_file($_FILES[""files""][""tmp_name""][0], $target_file)) {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');
++        $data = [""url"" => $target_file, ""message"" => ""The file "". basename( $_FILES[""files""][""name""][0]). "" has been uploaded.""];
++        http_response_code(201);
++        echo json_encode( $data );
++      } else {
++        header(""Access-Control-Allow-Origin: *"");
++        header('Content-type: application/json');
++        $data = [""message"" => ""Sorry, there was an error uploading your file.""];
++        http_response_code(400);
++        echo json_encode( $data );",white space within parenthesis is new here,2019-04-09 11:34:18
+423,"@@ -0,0 +1,35 @@
++var formidable = require('formidable')
++var http = require('http')
++
++http.createServer(function (req, res) {
++  const headers = {
++    'Content-Type': 'application/json',
++    'Access-Control-Allow-Origin': '*',
++    'Access-Control-Allow-Methods': 'OPTIONS, POST, GET',
++    'Access-Control-Max-Age': 2592000 // 30 days
++    /** add other headers as per requirement */
++  }
++
++  if (req.method === 'OPTIONS') {
++    res.writeHead(204, headers)
++    res.end()
++    return
++  }
++  if (req.url === '/upload' && req.method.toLowerCase() === 'post') {
++    // parse a file upload
++    var form = new formidable.IncomingForm()
++","Can we add an upload directory, like `form.uploadDir = ""./uploads""`? Otherwise I ran this on mac and couldn’t figure out where the files went. And maybe also preserve the extension. So:
+
+```js
+form.uploadDir = ""./uploads""
+form.keepExtensions = true
+```",2019-04-04 10:38:28
+53,"@@ -0,0 +1,36 @@
++<!DOCTYPE html>
++<html lang=""en"">
++  <head>
++    <title></title>
++    <meta charset=""UTF-8"">
++    <meta name=""viewport"" content=""width=device-width, initial-scale=1"">
++    <link href=""https://unpkg.com/uppy/dist/uppy.min.css"" rel=""stylesheet""> 
++  </head>
++  <body>
++    <button id=""uppyModalOpener"">Open Modal</button>
++    <script src=""https://unpkg.com/uppy/dist/uppy.min.js""></script>
++    <script>
++      const Dashboard = Uppy.Dashboard
++      const Webcam = Uppy.Webcam
++      const Tus10 = Uppy.Tus10
++      const Informer = Uppy.Informer
++
++      const uppy = Uppy.Core({debug: true, autoProceed: false})
++      .use(Uppy.Dashboard, {
++        trigger: '#uppyModalOpener',
++        target: 'body'
++      })
++      .use(Webcam, {target: Dashboard})
++      .use(Tus10, {endpoint: 'http://master.tus.io/files/', resume: true})",http**s**://master.tus.io/files/ would be best 😃 ,2017-06-22 11:43:34
+954,"@@ -0,0 +1,36 @@
++name: CDN
++on:
++  push:
++    branches: master
++
++jobs:
++  release:
++    if: ${{startsWith(github.event.head_commit.message, 'Release')}}","Shouldn't we use tags for this, assuming we tag our releases. Just a suggestion, I think you know better. :thinking: ",2020-11-26 09:05:01
+955,"@@ -0,0 +1,36 @@
++name: CDN
++on:
++  push:
++    branches: master
++
++jobs:
++  release:
++    if: ${{startsWith(github.event.head_commit.message, 'Release')}}
++    name: Publish releases
++    runs-on: ubuntu-latest
++    steps:
++      - name: Checkout sources
++        uses: actions/checkout@v2
++      - name: Install Node.js
++        uses: actions/setup-node@v1",Why not use `actions/setup-node@v2-beta` ? :sweat_smile: ,2020-11-26 09:05:46
+725,"@@ -0,0 +1,360 @@
++const cuid = require('cuid')
++const { Provider, RequestClient, Socket } = require('@uppy/companion-client')
++const emitSocketProgress = require('@uppy/utils/lib/emitSocketProgress')
++const getSocketHost = require('@uppy/utils/lib/getSocketHost')
++const EventTracker = require('@uppy/utils/lib/EventTracker')
++const ProgressTimeout = require('@uppy/utils/lib/ProgressTimeout')
++
++// See XHRUpload
++function buildResponseError (xhr, error) {
++  // No error message
++  if (!error) error = new Error('Upload error')
++  // Got an error message string
++  if (typeof error === 'string') error = new Error(error)
++  // Got something else
++  if (!(error instanceof Error)) {
++    error = Object.assign(new Error('Upload error'), { data: error })
++  }
++
++  error.request = xhr
++  return error
++}
++
++// See XHRUpload
++function setTypeInBlob (file) {
++  const dataWithUpdatedType = file.data.slice(0, file.data.size, file.meta.type)
++  return dataWithUpdatedType
++}
++
++module.exports = class MiniXHRUpload {
++  constructor (uppy, opts) {
++    this.uppy = uppy
++    this.opts = {
++      validateStatus (status, responseText, response) {
++        return status >= 200 && status < 300
++      },
++      ...opts
++    }
++
++    this.requests = opts.__queue
++    this.uploaderEvents = Object.create(null)
++  }
++
++  _getOptions (file) {
++    const uppy = this.uppy
++
++    const overrides = uppy.getState().xhrUpload
++    const opts = {
++      ...this.opts,
++      ...(overrides || {}),
++      ...(file.xhrUpload || {}),
++      headers: {}
++    }
++    Object.assign(opts.headers, this.opts.headers)
++    if (overrides) {
++      Object.assign(opts.headers, overrides.headers)
++    }
++    if (file.xhrUpload) {
++      Object.assign(opts.headers, file.xhrUpload.headers)
++    }
++
++    return opts
++  }
++
++  uploadFile (id, current, total) {
++    const file = this.uppy.getFile(id)
++    if (file.error) {
++      throw new Error(file.error)
++    } else if (file.isRemote) {
++      return this._uploadRemoteFile(file, current, total)
++    }
++    return this._uploadLocalFile(file, current, total)
++  }
++
++  _addMetadata (formData, meta, opts) {
++    const metaFields = Array.isArray(opts.metaFields)
++      ? opts.metaFields
++      // Send along all fields by default.
++      : Object.keys(meta)
++    metaFields.forEach((item) => {
++      formData.append(item, meta[item])
++    })
++  }
++
++  _createFormDataUpload (file, opts) {
++    const formPost = new FormData()
++
++    this._addMetadata(formPost, file.meta, opts)
++
++    const dataWithUpdatedType = setTypeInBlob(file)
++
++    if (file.name) {
++      formPost.append(opts.fieldName, dataWithUpdatedType, file.meta.name)
++    } else {
++      formPost.append(opts.fieldName, dataWithUpdatedType)
++    }
++
++    return formPost
++  }
++
++  _createBareUpload (file, opts) {
++    return file.data
++  }
++
++  _onFileRemoved (fileID, cb) {
++    this.uploaderEvents[fileID].on('file-removed', (file) => {
++      if (fileID === file.id) cb(file.id)
++    })
++  }
++
++  _onRetry (fileID, cb) {
++    this.uploaderEvents[fileID].on('upload-retry', (targetFileID) => {
++      if (fileID === targetFileID) {
++        cb()
++      }
++    })
++  }
++
++  _onRetryAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('retry-all', (filesToRetry) => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _onCancelAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('cancel-all', () => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _uploadLocalFile (file, current, total) {
++    const opts = this._getOptions(file)
++
++    this.uppy.log(`uploading ${current} of ${total}`)
++    return new Promise((resolve, reject) => {
++      // This is done in index.js in the S3 plugin.
++      // this.uppy.emit('upload-started', file)
++
++      const data = opts.formData
++        ? this._createFormDataUpload(file, opts)
++        : this._createBareUpload(file, opts)
++
++      const timer = new ProgressTimeout(opts.timeout, () => {
++        xhr.abort()",I got a lil confused here cos I couldn't find anywhere `xhr` was defined before it was referenced. Would it make sense to move [this](https://github.com/transloadit/uppy/pull/2060/files#diff-57355ea8780221946e05753c979ce54eR152) right before `ProgressTimeout` is instantiated?,2020-04-02 14:05:03
+728,"@@ -0,0 +1,360 @@
++const cuid = require('cuid')
++const { Provider, RequestClient, Socket } = require('@uppy/companion-client')
++const emitSocketProgress = require('@uppy/utils/lib/emitSocketProgress')
++const getSocketHost = require('@uppy/utils/lib/getSocketHost')
++const EventTracker = require('@uppy/utils/lib/EventTracker')
++const ProgressTimeout = require('@uppy/utils/lib/ProgressTimeout')
++
++// See XHRUpload
++function buildResponseError (xhr, error) {
++  // No error message
++  if (!error) error = new Error('Upload error')
++  // Got an error message string
++  if (typeof error === 'string') error = new Error(error)
++  // Got something else
++  if (!(error instanceof Error)) {
++    error = Object.assign(new Error('Upload error'), { data: error })
++  }
++
++  error.request = xhr
++  return error
++}
++
++// See XHRUpload
++function setTypeInBlob (file) {
++  const dataWithUpdatedType = file.data.slice(0, file.data.size, file.meta.type)
++  return dataWithUpdatedType
++}
++
++module.exports = class MiniXHRUpload {
++  constructor (uppy, opts) {
++    this.uppy = uppy
++    this.opts = {
++      validateStatus (status, responseText, response) {
++        return status >= 200 && status < 300
++      },
++      ...opts
++    }
++
++    this.requests = opts.__queue
++    this.uploaderEvents = Object.create(null)
++  }
++
++  _getOptions (file) {
++    const uppy = this.uppy
++
++    const overrides = uppy.getState().xhrUpload
++    const opts = {
++      ...this.opts,
++      ...(overrides || {}),
++      ...(file.xhrUpload || {}),
++      headers: {}
++    }
++    Object.assign(opts.headers, this.opts.headers)
++    if (overrides) {
++      Object.assign(opts.headers, overrides.headers)
++    }
++    if (file.xhrUpload) {
++      Object.assign(opts.headers, file.xhrUpload.headers)
++    }
++
++    return opts
++  }
++
++  uploadFile (id, current, total) {
++    const file = this.uppy.getFile(id)
++    if (file.error) {
++      throw new Error(file.error)
++    } else if (file.isRemote) {
++      return this._uploadRemoteFile(file, current, total)
++    }
++    return this._uploadLocalFile(file, current, total)
++  }
++
++  _addMetadata (formData, meta, opts) {
++    const metaFields = Array.isArray(opts.metaFields)
++      ? opts.metaFields
++      // Send along all fields by default.
++      : Object.keys(meta)
++    metaFields.forEach((item) => {
++      formData.append(item, meta[item])
++    })
++  }
++
++  _createFormDataUpload (file, opts) {
++    const formPost = new FormData()
++
++    this._addMetadata(formPost, file.meta, opts)
++
++    const dataWithUpdatedType = setTypeInBlob(file)
++
++    if (file.name) {
++      formPost.append(opts.fieldName, dataWithUpdatedType, file.meta.name)
++    } else {
++      formPost.append(opts.fieldName, dataWithUpdatedType)
++    }
++
++    return formPost
++  }
++
++  _createBareUpload (file, opts) {
++    return file.data
++  }
++
++  _onFileRemoved (fileID, cb) {
++    this.uploaderEvents[fileID].on('file-removed', (file) => {
++      if (fileID === file.id) cb(file.id)
++    })
++  }
++
++  _onRetry (fileID, cb) {
++    this.uploaderEvents[fileID].on('upload-retry', (targetFileID) => {
++      if (fileID === targetFileID) {
++        cb()
++      }
++    })
++  }
++
++  _onRetryAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('retry-all', (filesToRetry) => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _onCancelAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('cancel-all', () => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _uploadLocalFile (file, current, total) {
++    const opts = this._getOptions(file)
++
++    this.uppy.log(`uploading ${current} of ${total}`)
++    return new Promise((resolve, reject) => {
++      // This is done in index.js in the S3 plugin.
++      // this.uppy.emit('upload-started', file)
++
++      const data = opts.formData
++        ? this._createFormDataUpload(file, opts)
++        : this._createBareUpload(file, opts)
++
++      const timer = new ProgressTimeout(opts.timeout, () => {
++        xhr.abort()
++        queuedRequest.done()
++        const error = new Error(this.i18n('timedOut', { seconds: Math.ceil(opts.timeout / 1000) }))
++        this.uppy.emit('upload-error', file, error)
++        reject(error)
++      })
++
++      const xhr = new XMLHttpRequest()
++      this.uploaderEvents[file.id] = new EventTracker(this.uppy)
++
++      const id = cuid()
++
++      xhr.upload.addEventListener('loadstart', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} started`)
++      })
++
++      xhr.upload.addEventListener('progress', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} progress: ${ev.loaded} / ${ev.total}`)
++        // Begin checking for timeouts when progress starts, instead of loading,
++        // to avoid timing out requests on browser concurrency queue
++        timer.progress()
++
++        if (ev.lengthComputable) {
++          this.uppy.emit('upload-progress', file, {
++            uploader: this,
++            bytesUploaded: ev.loaded,
++            bytesTotal: ev.total
++          })
++        }
++      })
++
++      xhr.addEventListener('load', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} finished`)
++        timer.done()
++        queuedRequest.done()
++        if (this.uploaderEvents[file.id]) {
++          this.uploaderEvents[file.id].remove()
++          this.uploaderEvents[file.id] = null
++        }
++
++        if (opts.validateStatus(ev.target.status, xhr.responseText, xhr)) {
++          const body = opts.getResponseData(xhr.responseText, xhr)
++          const uploadURL = body[opts.responseUrlFieldName]
++
++          const uploadResp = {
++            status: ev.target.status,
++            body,
++            uploadURL
++          }
++
++          this.uppy.emit('upload-success', file, uploadResp)
++
++          if (uploadURL) {
++            this.uppy.log(`Download ${file.name} from ${uploadURL}`)
++          }
++
++          return resolve(file)
++        } else {
++          const body = opts.getResponseData(xhr.responseText, xhr)
++          const error = buildResponseError(xhr, opts.getResponseError(xhr.responseText, xhr))
++
++          const response = {
++            status: ev.target.status,
++            body
++          }
++
++          this.uppy.emit('upload-error', file, error, response)
++          return reject(error)
++        }
++      })
++
++      xhr.addEventListener('error', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} errored`)
++        timer.done()
++        queuedRequest.done()
++        if (this.uploaderEvents[file.id]) {
++          this.uploaderEvents[file.id].remove()
++          this.uploaderEvents[file.id] = null
++        }
++
++        const error = buildResponseError(xhr, opts.getResponseError(xhr.responseText, xhr))
++        this.uppy.emit('upload-error', file, error)
++        return reject(error)
++      })
++
++      xhr.open(opts.method.toUpperCase(), opts.endpoint, true)
++      // IE10 does not allow setting `withCredentials` and `responseType`
++      // before `open()` is called.
++      xhr.withCredentials = opts.withCredentials
++      if (opts.responseType !== '') {
++        xhr.responseType = opts.responseType
++      }
++
++      Object.keys(opts.headers).forEach((header) => {
++        xhr.setRequestHeader(header, opts.headers[header])
++      })
++
++      const queuedRequest = this.requests.run(() => {
++        xhr.send(data)
++        return () => {
++          timer.done()
++          xhr.abort()
++        }
++      }, { priority: 1 })
++
++      this._onFileRemoved(file.id, () => {
++        queuedRequest.abort()
++        reject(new Error('File removed'))
++      })
++
++      this._onCancelAll(file.id, () => {
++        queuedRequest.abort()
++        reject(new Error('Upload cancelled'))
++      })
++    })
++  }
++
++  _uploadRemoteFile (file, current, total) {
++    const opts = this._getOptions(file)
++    return new Promise((resolve, reject) => {
++      this.uppy.emit('upload-started', file)",should we leave this event emit to `index.js` as done [here](https://github.com/transloadit/uppy/pull/2060/files#diff-57355ea8780221946e05753c979ce54eR138),2020-04-02 14:39:15
+726,"@@ -0,0 +1,360 @@
++const cuid = require('cuid')
++const { Provider, RequestClient, Socket } = require('@uppy/companion-client')
++const emitSocketProgress = require('@uppy/utils/lib/emitSocketProgress')
++const getSocketHost = require('@uppy/utils/lib/getSocketHost')
++const EventTracker = require('@uppy/utils/lib/EventTracker')
++const ProgressTimeout = require('@uppy/utils/lib/ProgressTimeout')
++
++// See XHRUpload
++function buildResponseError (xhr, error) {
++  // No error message
++  if (!error) error = new Error('Upload error')
++  // Got an error message string
++  if (typeof error === 'string') error = new Error(error)
++  // Got something else
++  if (!(error instanceof Error)) {
++    error = Object.assign(new Error('Upload error'), { data: error })
++  }
++
++  error.request = xhr
++  return error
++}
++
++// See XHRUpload
++function setTypeInBlob (file) {
++  const dataWithUpdatedType = file.data.slice(0, file.data.size, file.meta.type)
++  return dataWithUpdatedType
++}
++
++module.exports = class MiniXHRUpload {
++  constructor (uppy, opts) {
++    this.uppy = uppy
++    this.opts = {
++      validateStatus (status, responseText, response) {
++        return status >= 200 && status < 300
++      },
++      ...opts
++    }
++
++    this.requests = opts.__queue
++    this.uploaderEvents = Object.create(null)
++  }
++
++  _getOptions (file) {
++    const uppy = this.uppy
++
++    const overrides = uppy.getState().xhrUpload
++    const opts = {
++      ...this.opts,
++      ...(overrides || {}),
++      ...(file.xhrUpload || {}),
++      headers: {}
++    }
++    Object.assign(opts.headers, this.opts.headers)
++    if (overrides) {
++      Object.assign(opts.headers, overrides.headers)
++    }
++    if (file.xhrUpload) {
++      Object.assign(opts.headers, file.xhrUpload.headers)
++    }
++
++    return opts
++  }
++
++  uploadFile (id, current, total) {
++    const file = this.uppy.getFile(id)
++    if (file.error) {
++      throw new Error(file.error)
++    } else if (file.isRemote) {
++      return this._uploadRemoteFile(file, current, total)
++    }
++    return this._uploadLocalFile(file, current, total)
++  }
++
++  _addMetadata (formData, meta, opts) {
++    const metaFields = Array.isArray(opts.metaFields)
++      ? opts.metaFields
++      // Send along all fields by default.
++      : Object.keys(meta)
++    metaFields.forEach((item) => {
++      formData.append(item, meta[item])
++    })
++  }
++
++  _createFormDataUpload (file, opts) {
++    const formPost = new FormData()
++
++    this._addMetadata(formPost, file.meta, opts)
++
++    const dataWithUpdatedType = setTypeInBlob(file)
++
++    if (file.name) {
++      formPost.append(opts.fieldName, dataWithUpdatedType, file.meta.name)
++    } else {
++      formPost.append(opts.fieldName, dataWithUpdatedType)
++    }
++
++    return formPost
++  }
++
++  _createBareUpload (file, opts) {
++    return file.data
++  }
++
++  _onFileRemoved (fileID, cb) {
++    this.uploaderEvents[fileID].on('file-removed', (file) => {
++      if (fileID === file.id) cb(file.id)
++    })
++  }
++
++  _onRetry (fileID, cb) {
++    this.uploaderEvents[fileID].on('upload-retry', (targetFileID) => {
++      if (fileID === targetFileID) {
++        cb()
++      }
++    })
++  }
++
++  _onRetryAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('retry-all', (filesToRetry) => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _onCancelAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('cancel-all', () => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _uploadLocalFile (file, current, total) {
++    const opts = this._getOptions(file)
++
++    this.uppy.log(`uploading ${current} of ${total}`)
++    return new Promise((resolve, reject) => {
++      // This is done in index.js in the S3 plugin.
++      // this.uppy.emit('upload-started', file)
++
++      const data = opts.formData
++        ? this._createFormDataUpload(file, opts)
++        : this._createBareUpload(file, opts)
++
++      const timer = new ProgressTimeout(opts.timeout, () => {
++        xhr.abort()
++        queuedRequest.done()
++        const error = new Error(this.i18n('timedOut', { seconds: Math.ceil(opts.timeout / 1000) }))
++        this.uppy.emit('upload-error', file, error)
++        reject(error)
++      })
++
++      const xhr = new XMLHttpRequest()
++      this.uploaderEvents[file.id] = new EventTracker(this.uppy)
++
++      const id = cuid()
++
++      xhr.upload.addEventListener('loadstart', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} started`)
++      })
++
++      xhr.upload.addEventListener('progress', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} progress: ${ev.loaded} / ${ev.total}`)
++        // Begin checking for timeouts when progress starts, instead of loading,
++        // to avoid timing out requests on browser concurrency queue
++        timer.progress()
++
++        if (ev.lengthComputable) {
++          this.uppy.emit('upload-progress', file, {
++            uploader: this,
++            bytesUploaded: ev.loaded,
++            bytesTotal: ev.total
++          })
++        }
++      })
++
++      xhr.addEventListener('load', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} finished`)
++        timer.done()
++        queuedRequest.done()
++        if (this.uploaderEvents[file.id]) {
++          this.uploaderEvents[file.id].remove()
++          this.uploaderEvents[file.id] = null
++        }
++
++        if (opts.validateStatus(ev.target.status, xhr.responseText, xhr)) {
++          const body = opts.getResponseData(xhr.responseText, xhr)
++          const uploadURL = body[opts.responseUrlFieldName]
++
++          const uploadResp = {
++            status: ev.target.status,
++            body,
++            uploadURL
++          }
++
++          this.uppy.emit('upload-success', file, uploadResp)
++
++          if (uploadURL) {
++            this.uppy.log(`Download ${file.name} from ${uploadURL}`)
++          }
++
++          return resolve(file)
++        } else {
++          const body = opts.getResponseData(xhr.responseText, xhr)
++          const error = buildResponseError(xhr, opts.getResponseError(xhr.responseText, xhr))
++
++          const response = {
++            status: ev.target.status,
++            body
++          }
++
++          this.uppy.emit('upload-error', file, error, response)
++          return reject(error)
++        }
++      })
++
++      xhr.addEventListener('error', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} errored`)
++        timer.done()
++        queuedRequest.done()
++        if (this.uploaderEvents[file.id]) {
++          this.uploaderEvents[file.id].remove()
++          this.uploaderEvents[file.id] = null
++        }
++
++        const error = buildResponseError(xhr, opts.getResponseError(xhr.responseText, xhr))
++        this.uppy.emit('upload-error', file, error)
++        return reject(error)
++      })
++
++      xhr.open(opts.method.toUpperCase(), opts.endpoint, true)
++      // IE10 does not allow setting `withCredentials` and `responseType`
++      // before `open()` is called.
++      xhr.withCredentials = opts.withCredentials
++      if (opts.responseType !== '') {
++        xhr.responseType = opts.responseType
++      }
++
++      Object.keys(opts.headers).forEach((header) => {
++        xhr.setRequestHeader(header, opts.headers[header])
++      })
++
++      const queuedRequest = this.requests.run(() => {
++        xhr.send(data)
++        return () => {
++          timer.done()
++          xhr.abort()
++        }
++      }, { priority: 1 })
++
++      this._onFileRemoved(file.id, () => {
++        queuedRequest.abort()
++        reject(new Error('File removed'))
++      })
++
++      this._onCancelAll(file.id, () => {
++        queuedRequest.abort()
++        reject(new Error('Upload cancelled'))
++      })
++    })
++  }
++
++  _uploadRemoteFile (file, current, total) {
++    const opts = this._getOptions(file)
++    return new Promise((resolve, reject) => {
++      this.uppy.emit('upload-started', file)
++
++      const fields = {}
++      const metaFields = Array.isArray(opts.metaFields)
++        ? opts.metaFields
++        // Send along all fields by default.
++        : Object.keys(file.meta)
++
++      metaFields.forEach((name) => {
++        fields[name] = file.meta[name]
++      })
++
++      const Client = file.remote.providerOptions.provider ? Provider : RequestClient
++      const client = new Client(this.uppy, file.remote.providerOptions)
++      client.post(file.remote.url, {",should we also be sending `httpMethod` here?,2020-04-02 14:20:34
+727,"@@ -0,0 +1,360 @@
++const cuid = require('cuid')
++const { Provider, RequestClient, Socket } = require('@uppy/companion-client')
++const emitSocketProgress = require('@uppy/utils/lib/emitSocketProgress')
++const getSocketHost = require('@uppy/utils/lib/getSocketHost')
++const EventTracker = require('@uppy/utils/lib/EventTracker')
++const ProgressTimeout = require('@uppy/utils/lib/ProgressTimeout')
++
++// See XHRUpload
++function buildResponseError (xhr, error) {
++  // No error message
++  if (!error) error = new Error('Upload error')
++  // Got an error message string
++  if (typeof error === 'string') error = new Error(error)
++  // Got something else
++  if (!(error instanceof Error)) {
++    error = Object.assign(new Error('Upload error'), { data: error })
++  }
++
++  error.request = xhr
++  return error
++}
++
++// See XHRUpload
++function setTypeInBlob (file) {
++  const dataWithUpdatedType = file.data.slice(0, file.data.size, file.meta.type)
++  return dataWithUpdatedType
++}
++
++module.exports = class MiniXHRUpload {
++  constructor (uppy, opts) {
++    this.uppy = uppy
++    this.opts = {
++      validateStatus (status, responseText, response) {
++        return status >= 200 && status < 300
++      },
++      ...opts
++    }
++
++    this.requests = opts.__queue
++    this.uploaderEvents = Object.create(null)
++  }
++
++  _getOptions (file) {
++    const uppy = this.uppy
++
++    const overrides = uppy.getState().xhrUpload
++    const opts = {
++      ...this.opts,
++      ...(overrides || {}),
++      ...(file.xhrUpload || {}),
++      headers: {}
++    }
++    Object.assign(opts.headers, this.opts.headers)
++    if (overrides) {
++      Object.assign(opts.headers, overrides.headers)
++    }
++    if (file.xhrUpload) {
++      Object.assign(opts.headers, file.xhrUpload.headers)
++    }
++
++    return opts
++  }
++
++  uploadFile (id, current, total) {
++    const file = this.uppy.getFile(id)
++    if (file.error) {
++      throw new Error(file.error)
++    } else if (file.isRemote) {
++      return this._uploadRemoteFile(file, current, total)
++    }
++    return this._uploadLocalFile(file, current, total)
++  }
++
++  _addMetadata (formData, meta, opts) {
++    const metaFields = Array.isArray(opts.metaFields)
++      ? opts.metaFields
++      // Send along all fields by default.
++      : Object.keys(meta)
++    metaFields.forEach((item) => {
++      formData.append(item, meta[item])
++    })
++  }
++
++  _createFormDataUpload (file, opts) {
++    const formPost = new FormData()
++
++    this._addMetadata(formPost, file.meta, opts)
++
++    const dataWithUpdatedType = setTypeInBlob(file)
++
++    if (file.name) {
++      formPost.append(opts.fieldName, dataWithUpdatedType, file.meta.name)
++    } else {
++      formPost.append(opts.fieldName, dataWithUpdatedType)
++    }
++
++    return formPost
++  }
++
++  _createBareUpload (file, opts) {
++    return file.data
++  }
++
++  _onFileRemoved (fileID, cb) {
++    this.uploaderEvents[fileID].on('file-removed', (file) => {
++      if (fileID === file.id) cb(file.id)
++    })
++  }
++
++  _onRetry (fileID, cb) {
++    this.uploaderEvents[fileID].on('upload-retry', (targetFileID) => {
++      if (fileID === targetFileID) {
++        cb()
++      }
++    })
++  }
++
++  _onRetryAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('retry-all', (filesToRetry) => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _onCancelAll (fileID, cb) {
++    this.uploaderEvents[fileID].on('cancel-all', () => {
++      if (!this.uppy.getFile(fileID)) return
++      cb()
++    })
++  }
++
++  _uploadLocalFile (file, current, total) {
++    const opts = this._getOptions(file)
++
++    this.uppy.log(`uploading ${current} of ${total}`)
++    return new Promise((resolve, reject) => {
++      // This is done in index.js in the S3 plugin.
++      // this.uppy.emit('upload-started', file)
++
++      const data = opts.formData
++        ? this._createFormDataUpload(file, opts)
++        : this._createBareUpload(file, opts)
++
++      const timer = new ProgressTimeout(opts.timeout, () => {
++        xhr.abort()
++        queuedRequest.done()
++        const error = new Error(this.i18n('timedOut', { seconds: Math.ceil(opts.timeout / 1000) }))
++        this.uppy.emit('upload-error', file, error)
++        reject(error)
++      })
++
++      const xhr = new XMLHttpRequest()
++      this.uploaderEvents[file.id] = new EventTracker(this.uppy)
++
++      const id = cuid()
++
++      xhr.upload.addEventListener('loadstart', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} started`)
++      })
++
++      xhr.upload.addEventListener('progress', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} progress: ${ev.loaded} / ${ev.total}`)
++        // Begin checking for timeouts when progress starts, instead of loading,
++        // to avoid timing out requests on browser concurrency queue
++        timer.progress()
++
++        if (ev.lengthComputable) {
++          this.uppy.emit('upload-progress', file, {
++            uploader: this,
++            bytesUploaded: ev.loaded,
++            bytesTotal: ev.total
++          })
++        }
++      })
++
++      xhr.addEventListener('load', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} finished`)
++        timer.done()
++        queuedRequest.done()
++        if (this.uploaderEvents[file.id]) {
++          this.uploaderEvents[file.id].remove()
++          this.uploaderEvents[file.id] = null
++        }
++
++        if (opts.validateStatus(ev.target.status, xhr.responseText, xhr)) {
++          const body = opts.getResponseData(xhr.responseText, xhr)
++          const uploadURL = body[opts.responseUrlFieldName]
++
++          const uploadResp = {
++            status: ev.target.status,
++            body,
++            uploadURL
++          }
++
++          this.uppy.emit('upload-success', file, uploadResp)
++
++          if (uploadURL) {
++            this.uppy.log(`Download ${file.name} from ${uploadURL}`)
++          }
++
++          return resolve(file)
++        } else {
++          const body = opts.getResponseData(xhr.responseText, xhr)
++          const error = buildResponseError(xhr, opts.getResponseError(xhr.responseText, xhr))
++
++          const response = {
++            status: ev.target.status,
++            body
++          }
++
++          this.uppy.emit('upload-error', file, error, response)
++          return reject(error)
++        }
++      })
++
++      xhr.addEventListener('error', (ev) => {
++        this.uppy.log(`[AwsS3/XHRUpload] ${id} errored`)
++        timer.done()
++        queuedRequest.done()
++        if (this.uploaderEvents[file.id]) {
++          this.uploaderEvents[file.id].remove()
++          this.uploaderEvents[file.id] = null
++        }
++
++        const error = buildResponseError(xhr, opts.getResponseError(xhr.responseText, xhr))
++        this.uppy.emit('upload-error', file, error)
++        return reject(error)
++      })
++
++      xhr.open(opts.method.toUpperCase(), opts.endpoint, true)
++      // IE10 does not allow setting `withCredentials` and `responseType`
++      // before `open()` is called.
++      xhr.withCredentials = opts.withCredentials
++      if (opts.responseType !== '') {
++        xhr.responseType = opts.responseType
++      }
++
++      Object.keys(opts.headers).forEach((header) => {
++        xhr.setRequestHeader(header, opts.headers[header])
++      })
++
++      const queuedRequest = this.requests.run(() => {
++        xhr.send(data)
++        return () => {
++          timer.done()
++          xhr.abort()
++        }
++      }, { priority: 1 })
++
++      this._onFileRemoved(file.id, () => {
++        queuedRequest.abort()
++        reject(new Error('File removed'))
++      })
++
++      this._onCancelAll(file.id, () => {
++        queuedRequest.abort()
++        reject(new Error('Upload cancelled'))
++      })
++    })
++  }
++
++  _uploadRemoteFile (file, current, total) {
++    const opts = this._getOptions(file)
++    return new Promise((resolve, reject) => {
++      this.uppy.emit('upload-started', file)
++
++      const fields = {}
++      const metaFields = Array.isArray(opts.metaFields)
++        ? opts.metaFields
++        // Send along all fields by default.
++        : Object.keys(file.meta)
++
++      metaFields.forEach((name) => {
++        fields[name] = file.meta[name]
++      })
++
++      const Client = file.remote.providerOptions.provider ? Provider : RequestClient
++      const client = new Client(this.uppy, file.remote.providerOptions)
++      client.post(file.remote.url, {
++        ...file.remote.body,
++        endpoint: opts.endpoint,
++        size: file.data.size,
++        fieldname: opts.fieldName,
++        metadata: fields,
++        headers: opts.headers
++      }).then((res) => {
++        const token = res.token
++        const host = getSocketHost(file.remote.companionUrl)
++        const socket = new Socket({ target: `${host}/api/${token}`, autoOpen: false })
++        this.uploaderEvents[file.id] = new EventTracker(this.uppy)
++
++        this._onFileRemoved(file.id, () => {
++          socket.send('pause', {})
++          queuedRequest.abort()
++          resolve(`upload ${file.id} was removed`)
++        })
++
++        this._onCancelAll(file.id, () => {
++          socket.send('pause', {})
++          queuedRequest.abort()
++          resolve(`upload ${file.id} was canceled`)
++        })
++
++        this._onRetry(file.id, () => {
++          socket.send('pause', {})
++          socket.send('resume', {})
++        })
++
++        this._onRetryAll(file.id, () => {
++          socket.send('pause', {})
++          socket.send('resume', {})
++        })
++
++        socket.on('progress', (progressData) => emitSocketProgress(this, progressData, file))
++
++        socket.on('success', (data) => {
++          const body = opts.getResponseData(data.response.responseText, data.response)
++          const uploadURL = body[opts.responseUrlFieldName]
++
++          const uploadResp = {
++            status: data.response.status,
++            body,
++            uploadURL
++          }
++
++          this.uppy.emit('upload-success', file, uploadResp)
++          queuedRequest.done()
++          if (this.uploaderEvents[file.id]) {
++            this.uploaderEvents[file.id].remove()
++            this.uploaderEvents[file.id] = null
++          }
++          return resolve()
++        })
++
++        socket.on('error', (errData) => {
++          const resp = errData.response
++          const error = resp
++            ? opts.getResponseError(resp.responseText, resp)
++            : Object.assign(new Error(errData.error.message), { cause: errData.error })
++          this.uppy.emit('upload-error', file, error)
++          queuedRequest.done()
++          if (this.uploaderEvents[file.id]) {
++            this.uploaderEvents[file.id].remove()
++            this.uploaderEvents[file.id] = null
++          }
++          reject(error)
++        })
++
++        const queuedRequest = this.requests.run(() => {
++          socket.open()
++          if (file.isPaused) {
++            socket.send('pause', {})
++          }
++
++          return () => socket.close()
++        })
++      })",I guess we should be doing something similar to [this](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/xhr-upload/src/index.js#L434-L436) here now,2020-04-02 14:22:34
+713,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {","if possible, it'll be nice if we can add JsDoc documentation to the modules added to this PR. Here's an [example](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/src/server/Uploader.js#L21-L42) of what I mean. With this, we can spot possible static errors with typescript.",2020-03-18 11:59:29
+698,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)",left over?,2020-03-09 16:50:27
+700,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)",I vote we rename `onUploadProgress` to `progressReporter` to avoid confusion,2020-03-09 18:24:36
+699,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))","is there a reason why this is called after `catch`? 🤔 Doesn't it imply that the `callback` will be called twice (once with an error, and second time without) in the case where there's an error?",2020-03-09 18:12:16
+705,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)","should we completely decouple `_sendSingle` from using the `B2StreamWriter`? Since it actually is a more straightforward process, then there's no need tying it to the more complex code of the `_sendMultipart `. This way, it saves us from diving into the complex code of the `B2StreamWriter` when we only want to debug or make changes to the  `_sendSingle` functionality.",2020-03-11 17:12:06
+704,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {",should we rename this to `b2StreamWriter`? or `getB2StreamWriter`? I got a bit misled thinking it was a class. Perhaps  it's better to avoid that confusion?,2020-03-11 17:06:16
+706,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {
++  const { fileName, fileSize, partSize, path, endpointPool, fileId, client, progressReporter } = options
++  const { connections = 3 } = options
++  const isMultipart = !!fileId // fileId is present when first obtained via startLargeFile()
++  const fdSlicer = createSlicerFromPath(path)","while reviewing, I found this variable shadowing (with [this one](https://github.com/transloadit/uppy/pull/1933/files#diff-a2701fda284f857def20dd049d248e6fR3)) confusing. Maybe we should rename one of them?",2020-03-11 17:20:21
+702,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {
++  const { fileName, fileSize, partSize, path, endpointPool, fileId, client, progressReporter } = options
++  const { connections = 3 } = options
++  const isMultipart = !!fileId // fileId is present when first obtained via startLargeFile()
++  const fdSlicer = createSlicerFromPath(path)
++  const workers = []
++  const queue = []
++
++  let bytesRead = 0 // total bytes received
++  let partAccum = 0 // total bytes in the current part which have been processed
++  let partCount = 0 // number of emitted parts
++
++  const pendingWriteDrain = () => {
++    // If we have pending onwrite()s queued and we're under the maximum number
++    // of transmit workers...
++    if (queue.length && workers.length < connections) {
++      const cb = queue.shift()
++      cb() // signal that we're ready for more data
++    }
++  }
++
++  const pendingWriteHandler = (onwrite) => {
++    queue.push(onwrite)
++    pendingWriteDrain()
++  }
++
++  const emitPart = (writableStream) => {
++    // start and end correspond to the partAccum length section of bytes at the
++    // tail of the read stream.
++    const start = bytesRead - partAccum
++    const end = bytesRead
++    const id = partCount++
++    const contentLength = end - start
++    partAccum = 0
++
++    // Create a stream slice of this part's range and run it through hasher.
++    const partHashResult = () =>","should we as well make this multiline (with curly braces)?
+`const partHashResult = () => {...}` 
+might help with readability",2020-03-11 16:38:59
+707,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {
++  const { fileName, fileSize, partSize, path, endpointPool, fileId, client, progressReporter } = options
++  const { connections = 3 } = options
++  const isMultipart = !!fileId // fileId is present when first obtained via startLargeFile()
++  const fdSlicer = createSlicerFromPath(path)
++  const workers = []
++  const queue = []
++
++  let bytesRead = 0 // total bytes received
++  let partAccum = 0 // total bytes in the current part which have been processed
++  let partCount = 0 // number of emitted parts
++
++  const pendingWriteDrain = () => {
++    // If we have pending onwrite()s queued and we're under the maximum number
++    // of transmit workers...
++    if (queue.length && workers.length < connections) {
++      const cb = queue.shift()
++      cb() // signal that we're ready for more data
++    }
++  }
++
++  const pendingWriteHandler = (onwrite) => {
++    queue.push(onwrite)
++    pendingWriteDrain()
++  }
++
++  const emitPart = (writableStream) => {
++    // start and end correspond to the partAccum length section of bytes at the
++    // tail of the read stream.
++    const start = bytesRead - partAccum
++    const end = bytesRead
++    const id = partCount++
++    const contentLength = end - start
++    partAccum = 0
++
++    // Create a stream slice of this part's range and run it through hasher.
++    const partHashResult = () =>
++      fdSlicer.then(({ slicer }) => {
++        return createStreamHashSHA1(slicer, start, end)
++      })
++
++    // Attempt transmitting the stream data for this part to the
++    // appropriate B2 endpoint.
++    const attemptPartTransmission = (hash, slicer) => {
++      return endpointPool.acquire(fileId)
++        .then((endpoint) => {
++          const { authorizationToken, uploadUrl } = endpoint
++          const partStream = slicer.createReadStream({ start, end })
++          let transmit = null
++          if (isMultipart) {
++            transmit = client.uploadPart({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              data: partStream,
++              hash,
++              contentLength,
++              partNumber: id + 1 // b2 part numbers start a 1
++            })
++          } else {
++            transmit = client.uploadFile({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              fileName,
++              data: partStream,
++              hash,
++              contentLength
++            })
++          }
++          // only release endpoint back to the pool if it was last used
++          // successfully.
++          transmit.then(() => endpointPool.release(endpoint))
++          transmit.catch(() => { partStream.destroy() })",should we be logging the error here? 🤔 So we know why there's a failure? We can use the `logger` module like it's done [here](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/src/server/Uploader.js#L415).,2020-03-11 17:42:11
+708,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {
++  const { fileName, fileSize, partSize, path, endpointPool, fileId, client, progressReporter } = options
++  const { connections = 3 } = options
++  const isMultipart = !!fileId // fileId is present when first obtained via startLargeFile()
++  const fdSlicer = createSlicerFromPath(path)
++  const workers = []
++  const queue = []
++
++  let bytesRead = 0 // total bytes received
++  let partAccum = 0 // total bytes in the current part which have been processed
++  let partCount = 0 // number of emitted parts
++
++  const pendingWriteDrain = () => {
++    // If we have pending onwrite()s queued and we're under the maximum number
++    // of transmit workers...
++    if (queue.length && workers.length < connections) {
++      const cb = queue.shift()
++      cb() // signal that we're ready for more data
++    }
++  }
++
++  const pendingWriteHandler = (onwrite) => {
++    queue.push(onwrite)
++    pendingWriteDrain()
++  }
++
++  const emitPart = (writableStream) => {
++    // start and end correspond to the partAccum length section of bytes at the
++    // tail of the read stream.
++    const start = bytesRead - partAccum
++    const end = bytesRead
++    const id = partCount++
++    const contentLength = end - start
++    partAccum = 0
++
++    // Create a stream slice of this part's range and run it through hasher.
++    const partHashResult = () =>
++      fdSlicer.then(({ slicer }) => {
++        return createStreamHashSHA1(slicer, start, end)
++      })
++
++    // Attempt transmitting the stream data for this part to the
++    // appropriate B2 endpoint.
++    const attemptPartTransmission = (hash, slicer) => {
++      return endpointPool.acquire(fileId)
++        .then((endpoint) => {
++          const { authorizationToken, uploadUrl } = endpoint
++          const partStream = slicer.createReadStream({ start, end })
++          let transmit = null
++          if (isMultipart) {
++            transmit = client.uploadPart({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              data: partStream,
++              hash,
++              contentLength,
++              partNumber: id + 1 // b2 part numbers start a 1
++            })
++          } else {
++            transmit = client.uploadFile({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              fileName,
++              data: partStream,
++              hash,
++              contentLength
++            })
++          }
++          // only release endpoint back to the pool if it was last used
++          // successfully.
++          transmit.then(() => endpointPool.release(endpoint))
++          transmit.catch(() => { partStream.destroy() })
++          return transmit
++        })
++    }
++
++    const transmit = Promise.all([
++      partHashResult(),
++      fdSlicer
++    ]).then(([hash, { slicer }]) =>
++      callWithRetry(attemptPartTransmission, [hash, slicer])
++        .then(({ data }) => {","based on this [line](https://github.com/transloadit/uppy/pull/1933/files#diff-a2701fda284f857def20dd049d248e6fR297), is it possible that the data resolved here may be what is receive from `endpointPool.release`, which in this case is not desired? 🤔 ",2020-03-11 18:02:26
+712,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {
++  const { fileName, fileSize, partSize, path, endpointPool, fileId, client, progressReporter } = options
++  const { connections = 3 } = options
++  const isMultipart = !!fileId // fileId is present when first obtained via startLargeFile()
++  const fdSlicer = createSlicerFromPath(path)
++  const workers = []
++  const queue = []
++
++  let bytesRead = 0 // total bytes received
++  let partAccum = 0 // total bytes in the current part which have been processed
++  let partCount = 0 // number of emitted parts
++
++  const pendingWriteDrain = () => {
++    // If we have pending onwrite()s queued and we're under the maximum number
++    // of transmit workers...
++    if (queue.length && workers.length < connections) {
++      const cb = queue.shift()
++      cb() // signal that we're ready for more data
++    }
++  }
++
++  const pendingWriteHandler = (onwrite) => {
++    queue.push(onwrite)
++    pendingWriteDrain()
++  }
++
++  const emitPart = (writableStream) => {
++    // start and end correspond to the partAccum length section of bytes at the
++    // tail of the read stream.
++    const start = bytesRead - partAccum
++    const end = bytesRead
++    const id = partCount++
++    const contentLength = end - start
++    partAccum = 0
++
++    // Create a stream slice of this part's range and run it through hasher.
++    const partHashResult = () =>
++      fdSlicer.then(({ slicer }) => {
++        return createStreamHashSHA1(slicer, start, end)
++      })
++
++    // Attempt transmitting the stream data for this part to the
++    // appropriate B2 endpoint.
++    const attemptPartTransmission = (hash, slicer) => {
++      return endpointPool.acquire(fileId)
++        .then((endpoint) => {
++          const { authorizationToken, uploadUrl } = endpoint
++          const partStream = slicer.createReadStream({ start, end })
++          let transmit = null
++          if (isMultipart) {
++            transmit = client.uploadPart({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              data: partStream,
++              hash,
++              contentLength,
++              partNumber: id + 1 // b2 part numbers start a 1
++            })
++          } else {
++            transmit = client.uploadFile({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              fileName,
++              data: partStream,
++              hash,
++              contentLength
++            })
++          }
++          // only release endpoint back to the pool if it was last used
++          // successfully.
++          transmit.then(() => endpointPool.release(endpoint))
++          transmit.catch(() => { partStream.destroy() })
++          return transmit
++        })
++    }
++
++    const transmit = Promise.all([
++      partHashResult(),
++      fdSlicer
++    ]).then(([hash, { slicer }]) =>
++      callWithRetry(attemptPartTransmission, [hash, slicer])
++        .then(({ data }) => {
++          if (options.handleSent) {
++            options.handleSent({ id, hash }, data)
++          }
++          return data
++        })
++    ).then((data) => {
++      // After a successful transmission, remove this
++      // part transmission promise from the worker array
++      const index = workers.indexOf(transmit)
++      workers.splice(index, 1)
++
++      // Keep the stream moving
++      pendingWriteDrain()
++      return data
++    })
++
++    // Push this transmission promise into the pending worker queue
++    workers.push(transmit)
++    return transmit
++  }
++
++  let handledCounter = 0
++
++  return new Writable({","would it be possible to move the core of the `multipart` implementation to the [b2 client](https://github.com/yakovkhalinsky/backblaze-b2) itself? I'm talking about the parts of the implementation that requires slicing the files, and reading the streams in parts, etc. It seems like a heavy duty that we'll be taking to maintain this on companion along with all the other features that are already supported.
+
+And since this is possibly a desired functionality by other Backblaze users, maybe it makes sense to make it re-usable/available in the [b2 client](https://github.com/yakovkhalinsky/backblaze-b2) instead? Aka submit a PR to that repo?",2020-03-18 11:29:42
+701,"@@ -0,0 +1,374 @@
++const Writable = require('stream').Writable
++const crypto = require('crypto')
++const fdSlicer = require('fd-slicer')
++const fs = require('fs')
++
++const MAX_UPLOAD_PARTS = 10000
++
++function accumulator (start) {
++  let accum = start || 0
++  return (add = 0) => {
++    accum += add
++    return accum
++  }
++}
++
++function callWithRetry (fn, args = [], retriesLeft = 5) {
++  return fn(...args)
++    .catch((err) => {
++      if (retriesLeft > 0) {
++        return callWithRetry(fn, args, retriesLeft - 1)
++      }
++      return Promise.reject(err)
++    })
++}
++
++module.exports = class B2Stream {
++  // bucketName
++  // path
++  // fileName
++  // fileSize
++  // stream
++  // client
++  // endpointPool
++  constructor (client, options) {
++    this.options = options
++    this.client = client
++    this.onUploadProgress = ({ total, loaded }) => {
++      console.log('progress', loaded / total)
++    }
++  }
++
++  getOptimalPartSize (fileSize) {
++    return this.client.preauth()
++      .then(({ recommendedPartSize }) => {
++        return Math.min(
++          Math.max(recommendedPartSize, Math.ceil(fileSize / MAX_UPLOAD_PARTS)),
++          fileSize
++        )
++      })
++  }
++
++  getBucketId (bucketName) {
++    return this.client.getCachedBucket(bucketName)
++      .then(({ bucketId }) => bucketId)
++  }
++
++  send (cb) {
++    return Promise.all([
++      this.getOptimalPartSize(this.options.fileSize),
++      this.getBucketId(this.options.bucketName)
++    ]).then(([partSize, bucketId]) => {
++      const fileSize = this.options.fileSize
++      const onUploadProgress = this.createProgressReporter(fileSize)
++      const isMultipart = (partSize < fileSize)
++      if (isMultipart) {
++        return this._sendMultipart(partSize, bucketId, onUploadProgress)
++      } else {
++        return this._sendSingle(partSize, bucketId, onUploadProgress)
++      }
++    })
++      .catch((err) => {
++        cb(err)
++      })
++      .then((result) => cb(null, result))
++  }
++
++  createProgressReporter (total) {
++    const sent = accumulator(0)
++    return {
++      send: (bytes) => {
++        this.onUploadProgress({
++          loaded: sent(bytes),
++          total
++        })
++      }
++    }
++  }
++
++  _sendSingle (partSize, bucketId, progressReporter) {
++    const sendSinglePart = () => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const chunks = []
++      let fileId
++      let data
++      const writerOptions = {
++        fileId: null,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++          data = response
++          fileId = response.fileId
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId, data })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    return callWithRetry(sendSinglePart)
++  }
++
++  _sendMultipart (partSize, bucketId, progressReporter) {
++    const sendMultipartStartLargeFile = () => {
++      const { fileName } = this.options
++      return this.client.startLargeFile({ bucketId, fileName })
++        .then(({ data }) => data)
++    }
++
++    const sendMultipartUploadParts = (startLargeFileResponse) => {
++      const { fileName, fileSize, stream, path, endpointPool } = this.options
++      const { client } = this
++      const { fileId } = startLargeFileResponse
++      const chunks = []
++      const writerOptions = {
++        fileId,
++        fileName,
++        fileSize,
++        client,
++        endpointPool,
++        partSize,
++        path,
++        progressReporter,
++        handleSent: (chunk, response) => {
++          chunks[chunk.id] = { hash: chunk.hash }
++        }
++      }
++
++      return new Promise((resolve, reject) => {
++        try {
++          const writer = B2StreamWriter(writerOptions)
++          stream.pipe(writer)
++          writer.on('finish', () => {
++            resolve({ chunks, fileId })
++          })
++        } catch (err) {
++          reject(err)
++        }
++      })
++    }
++
++    const sendMultipartFinishLargeFile = (uploadStartResult, uploadPartsResult) => {
++      const { chunks, fileId } = uploadPartsResult
++      const partSha1Array = chunks.map(({ hash }) => hash)
++      return this.client.finishLargeFile({ fileId, partSha1Array })
++        .then(({ data }) => ({
++          chunks,
++          data,
++          fileId
++        }))
++    }
++
++    return callWithRetry(sendMultipartStartLargeFile)
++      .then((startResult) => sendMultipartUploadParts(startResult)
++        .then((partsResult) => callWithRetry(sendMultipartFinishLargeFile, [startResult, partsResult]))
++      )
++      .catch((err) => {
++        throw err
++      })
++  }
++}
++
++function createSlicerFromPath (path) {
++  return new Promise((resolve, reject) => {
++    fs.open(path, 'r', (err, fd) => {
++      if (err) {
++        reject(err)
++      }
++      const slicer = fdSlicer.createFromFd(fd)
++      resolve({ slicer, fd })
++    })
++  })
++}
++
++function createStreamHashSHA1 (slicer, start, end) {
++  const hasher = crypto.createHash('sha1')
++  hasher.setEncoding('hex')
++
++  return new Promise((resolve, reject) => {
++    slicer.createReadStream({ start, end })
++      .on('end', () => {
++        hasher.end()
++        const hash = hasher.read()
++        resolve(hash)
++      })
++      .pipe(hasher)
++  })
++}
++
++function closeFileDescriptorAsync (fd) {
++  return new Promise((resolve, reject) => {
++    fs.close(fd, (err) => {
++      if (err) {
++        reject(err)
++        return
++      }
++      resolve(fd)
++    })
++  })
++}
++
++function B2StreamWriter (options) {
++  const { fileName, fileSize, partSize, path, endpointPool, fileId, client, progressReporter } = options
++  const { connections = 3 } = options
++  const isMultipart = !!fileId // fileId is present when first obtained via startLargeFile()
++  const fdSlicer = createSlicerFromPath(path)
++  const workers = []
++  const queue = []
++
++  let bytesRead = 0 // total bytes received
++  let partAccum = 0 // total bytes in the current part which have been processed
++  let partCount = 0 // number of emitted parts
++
++  const pendingWriteDrain = () => {
++    // If we have pending onwrite()s queued and we're under the maximum number
++    // of transmit workers...
++    if (queue.length && workers.length < connections) {
++      const cb = queue.shift()
++      cb() // signal that we're ready for more data
++    }
++  }
++
++  const pendingWriteHandler = (onwrite) => {
++    queue.push(onwrite)
++    pendingWriteDrain()
++  }
++
++  const emitPart = (writableStream) => {
++    // start and end correspond to the partAccum length section of bytes at the
++    // tail of the read stream.
++    const start = bytesRead - partAccum
++    const end = bytesRead
++    const id = partCount++
++    const contentLength = end - start
++    partAccum = 0
++
++    // Create a stream slice of this part's range and run it through hasher.
++    const partHashResult = () =>
++      fdSlicer.then(({ slicer }) => {
++        return createStreamHashSHA1(slicer, start, end)
++      })
++
++    // Attempt transmitting the stream data for this part to the
++    // appropriate B2 endpoint.
++    const attemptPartTransmission = (hash, slicer) => {
++      return endpointPool.acquire(fileId)
++        .then((endpoint) => {
++          const { authorizationToken, uploadUrl } = endpoint
++          const partStream = slicer.createReadStream({ start, end })
++          let transmit = null
++          if (isMultipart) {
++            transmit = client.uploadPart({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              data: partStream,
++              hash,
++              contentLength,
++              partNumber: id + 1 // b2 part numbers start a 1
++            })
++          } else {
++            transmit = client.uploadFile({
++              uploadUrl,
++              uploadAuthToken: authorizationToken,
++              fileName,
++              data: partStream,
++              hash,
++              contentLength
++            })
++          }
++          // only release endpoint back to the pool if it was last used
++          // successfully.
++          transmit.then(() => endpointPool.release(endpoint))
++          transmit.catch(() => { partStream.destroy() })
++          return transmit
++        })
++    }
++
++    const transmit = Promise.all([
++      partHashResult(),
++      fdSlicer
++    ]).then(([hash, { slicer }]) =>
++      callWithRetry(attemptPartTransmission, [hash, slicer])
++        .then(({ data }) => {
++          if (options.handleSent) {
++            options.handleSent({ id, hash }, data)
++          }
++          return data
++        })
++    ).then((data) => {
++      // After a successful transmission, remove this
++      // part transmission promise from the worker array
++      const index = workers.indexOf(transmit)
++      workers.splice(index, 1)
++
++      // Keep the stream moving
++      pendingWriteDrain()
++      return data
++    })
++
++    // Push this transmission promise into the pending worker queue
++    workers.push(transmit)
++    return transmit
++  }
++
++  let handledCounter = 0
++
++  return new Writable({
++    write: function (chunk, _, cb) {
++      const chunkLength = chunk.length
++      let remaining = chunkLength
++      while (remaining > 0) {
++        const maxRead = Math.min(remaining, partSize - partAccum)
++        remaining -= maxRead
++        partAccum += maxRead
++        bytesRead += maxRead
++        // If we've received an entire part worth of data, then
++        // we will emit a new transmit job
++        if (partAccum === partSize) {
++          emitPart(this)
++        }
++      }
++
++      // handle the callback (now or later)
++      pendingWriteHandler(() => {
++        progressReporter.send(chunkLength)
++        handledCounter += chunkLength
++        cb()
++        // Sometimes when the file is very small, the read stream end event
++        // must occur before the pipe begins? This ensures we wrap up once
++        // we've processed all the bytes we've been expecting.
++        if (handledCounter === fileSize) {
++          this.end()
++        }
++      })
++    },
++    final: function (cb) {
++      if (partAccum > 0) {
++        emitPart(this)
++      }
++      // Wait on all workers to finish
++      Promise.all(workers)
++        .then(() => fdSlicer.then(({ fd }) => fd))
++        .then((fd) => closeFileDescriptorAsync(fd))
++        .then((fd) => {
++          cb()","what should happen if any of the promises throw an error? Should we be catching like this as well?
+```js
+.catch((err) => cb(err))
+```",2020-03-11 16:21:35
+96,"@@ -0,0 +1,38 @@
++import Core from '../../src/core/index.js'
++import russian from '../../src/locales/ru_RU.js'","should we be using `import` here if everywhere else we are using `require`? IT probably works because Babel, and maybe its fine, but thought I’d bring it up.",2017-09-08 21:22:34
+97,"@@ -0,0 +1,38 @@
++import Core from '../../src/core/index.js'
++import russian from '../../src/locales/ru_RU.js'
++import english from '../../src/locales/en_US.js'
++","Locale files are probably outdates, because locale settings are per-plugin now. Not a major issue, but just to keep this in mind :)",2017-09-08 21:23:53
+957,"@@ -0,0 +1,38 @@
++name: Companion Deploy
++on:
++  push:
++    branches: [master]
++
++jobs:
++  docker:
++    name: DockerHub
++    runs-on: ubuntu-latest
++    steps:
++      - name: Checkout sources
++        uses: actions/checkout@v2
++      - name: Log in to DockerHub
++        uses: docker/login-action@v1
++        with:
++          username: ${{secrets.DOCKER_USERNAME}}
++          password: ${{secrets.DOCKER_PASSWORD}}
++      - name: Build and push
++        uses: docker/build-push-action@v2
++        with:
++          context: packages/@uppy/companion
++          file: packages/@uppy/companion/Dockerfile
++          # TODO add a companion version tag if this is a ""Release"" commit",I think there was a fix for it a few months ago that made releases work. I could add it if you're cool with that :pray: ,2020-11-26 09:08:30
+453,"@@ -0,0 +1,39 @@
++---
++title: ""Day 30""
++date: 2019-04-24
++author: kvz
++image: ""https://uppy.io/images/blog/30daystoliftoff/day30.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++And then there were none! Zero days left in our thirty-day blog post challenge. I can't believe this is already the final day of our push to get Uppy to 1.0. There's still a bunch of things that we'd like to finish before shipping, so let's dive right in.
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day30.jpg""><br /><br /></center>
++
++<!--more-->
++
++- [Tim](https://github.com/tim-kos) added additional information to the [migration guide](https://uppy.io/docs/robodog/form/#Migrating-From-the-jQuery-SDK), so Transloadit customers looking to move from the jQuery SDK to Uppy Robodog will have an easier time doing so. He also smashed out the [German Locale Pack](https://github.com/transloadit/uppy/pull/1475)!
++
++- [Abdel](https://github.com/kiloreux) [translated](https://github.com/transloadit/uppy/pull/1481) Uppy to French. <img src=""https://avatars1.githubusercontent.com/u/20061212?s=460&v=4"" width=""16"" align=""absmiddle"">
++
++- [Artur](https://github.com/arturi) [documented](https://github.com/transloadit/uppy/pull/1468) the Thumbnail Generator plugin and made a few more hardcoded English strings translatable via Locale Packs. For instance, we can even translate ""[Powered By](https://github.com/transloadit/uppy/commit/6d36309b72b62e215caa172a6300a0f0c7083ce8)"" now 
++",incorrect quotes around “powered by” and in a few other places,2019-04-24 15:26:51
+811,"@@ -0,0 +1,40 @@
++# @uppy/dropbox",we might need to change all the occurrences of `dropbox` here to `zoom`,2020-07-07 14:51:41
+424,"@@ -0,0 +1,40 @@
++---
++title: ""Day 10""
++date: 2019-04-04
++author: tyler
++image: ""https://uppy.io/images/blog/30daystoliftoff/day10.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Today marks the tenth day in our 30 Days to Liftoff! **April 25** is still in our sights as we work towards the **Uppy 1.0** release. The end of the working week is almost upon us but there's no sign of slowing down yet.  
++
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/day10.jpg""><br /></center>
++
++Things are looking good on our project board and the team has been working on tasks at a steady pace. A quick status update will give us a little insight into how things are going concerning all things Uppy.
++
++<!--more-->
++
++## In Progress
++
++- [Alex](https://github.com/nqst) and Artur are debugging [flickering on Drag & Drop](https://github.com/transloadit/uppy/pull/1400) that Chrome and Safari suffer from. Fingers crossed for a solution!
++",and Evgenia,2019-04-04 13:16:46
+425,"@@ -0,0 +1,40 @@
++---
++title: ""Day 10""
++date: 2019-04-04
++author: tyler
++image: ""https://uppy.io/images/blog/30daystoliftoff/day10.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Today marks the tenth day in our 30 Days to Liftoff! **April 25** is still in our sights as we work towards the **Uppy 1.0** release. The end of the working week is almost upon us but there's no sign of slowing down yet.  
++
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/day10.jpg""><br /></center>
++
++Things are looking good on our project board and the team has been working on tasks at a steady pace. A quick status update will give us a little insight into how things are going concerning all things Uppy.
++
++<!--more-->
++
++## In Progress
++
++- [Alex](https://github.com/nqst) and Artur are debugging [flickering on Drag & Drop](https://github.com/transloadit/uppy/pull/1400) that Chrome and Safari suffer from. Fingers crossed for a solution!
++
++- [Artur](https://github.com/arturi), working on the React Native side of things, has impressively added [file previews and tested hashes with different file types](https://github.com/transloadit/uppy/pull/988). He hopes to do a release once some testing is complete. In addition the React Native team has reschedulded their pair programming session to Friday, so expect some pretty significant updates tomorrow!
++","Release is not a result of those particular changes, so maybe “after that he is panning to move on to releasing a new version of uppy”",2019-04-04 13:18:01
+564,"@@ -0,0 +1,40 @@
++.uploaded-files{","```suggestion
+.uploaded-files {
+```",2019-08-07 08:42:02
+562,"@@ -0,0 +1,40 @@
++.uploaded-files{
++  background: rgba(240, 238, 238, 0.35);
++  padding: 10px;
++  margin-top: 10px;
++  border-radius: 5px;
++  h5 {
++    margin: 0;
++    font-size: 15px;
++    color: rgb(114, 114, 114);
++    font-weight: 500;
++  }
++  ol {
++    color: rgb(55, 55, 55);
++    margin: 0;
++    padding-left: 18px;
++    li {
++      font-size: 15px;
++      padding-top: 10px;
++      word-break: break-all;
++      a {
++        color: rgb(34, 117, 215);
++        &:hover {
++          color: rgb(34, 117, 215);
++          border-bottom: 1px solid rgb(34, 117, 215);
++        }
++      }
++    }
++  }
++}
++
++// Prettier progress bar
++.uppy-ProgressBar-inner {
++  box-shadow: none !important;",I wonder if we should change the progress bar to only add the shadow when `fixed: true`?,2019-08-07 08:41:07
+563,"@@ -0,0 +1,40 @@
++.uploaded-files{
++  background: rgba(240, 238, 238, 0.35);
++  padding: 10px;
++  margin-top: 10px;
++  border-radius: 5px;
++  h5 {
++    margin: 0;
++    font-size: 15px;
++    color: rgb(114, 114, 114);
++    font-weight: 500;
++  }
++  ol {
++    color: rgb(55, 55, 55);
++    margin: 0;
++    padding-left: 18px;
++    li {
++      font-size: 15px;
++      padding-top: 10px;
++      word-break: break-all;
++      a {
++        color: rgb(34, 117, 215);
++        &:hover {
++          color: rgb(34, 117, 215);
++          border-bottom: 1px solid rgb(34, 117, 215);
++        }
++      }
++    }
++  }
++}
++
++// Prettier progress bar
++.uppy-ProgressBar-inner {
++  box-shadow: none !important;
++}
++
++// Prettier focus for the 'Choose files' button
++.uppy-FileInput-btn:focus{","```suggestion
+.uppy-FileInput-btn:focus {
+```",2019-08-07 08:41:42
+969,"@@ -0,0 +1,41 @@
++{
++  ""name"": ""@uppy/svelte"",
++  ""svelte"": ""src/index.js"",
++  ""module"": ""dist/index.mjs"",
++  ""main"": ""dist/index.js"",
++  ""version"": ""0.1.0"",
++  ""scripts"": {
++    ""build"": ""rollup -c"",
++    ""prepublishOnly"": ""npm run build"",
++    ""validate"": ""svelte-check""
++  },
++  ""devDependencies"": {
++    ""@rollup/plugin-node-resolve"": ""^9.0.0"",
++    ""@tsconfig/svelte"": ""^1.0.0"",
++    ""@uppy/core"": ""file:../../@uppy/core"",
++    ""rollup"": ""^2.0.0"",
++    ""rollup-plugin-svelte"": ""^6.0.0"",
++    ""svelte"": ""^3.0.0"",
++    ""svelte-check"": ""^1.0.0"",
++    ""svelte-preprocess"": ""^4.0.0"",
++    ""tslib"": ""^2.0.0"",
++    ""typescript"": ""^3.9.3""","Maybe we should move everything to root package.json, so it’s installed with root `npm install`?",2020-12-21 22:54:57
+968,"@@ -0,0 +1,41 @@
++{
++  ""name"": ""@uppy/svelte"",
++  ""svelte"": ""src/index.js"",
++  ""module"": ""dist/index.mjs"",
++  ""main"": ""dist/index.js"",
++  ""version"": ""0.1.0"",
++  ""scripts"": {
++    ""build"": ""rollup -c"",
++    ""prepublishOnly"": ""npm run build"",
++    ""validate"": ""svelte-check""
++  },
++  ""devDependencies"": {
++    ""@rollup/plugin-node-resolve"": ""^9.0.0"",
++    ""@tsconfig/svelte"": ""^1.0.0"",
++    ""@uppy/core"": ""file:../../@uppy/core"",
++    ""rollup"": ""^2.0.0"",
++    ""rollup-plugin-svelte"": ""^6.0.0"",
++    ""svelte"": ""^3.0.0"",
++    ""svelte-check"": ""^1.0.0"",
++    ""svelte-preprocess"": ""^4.0.0"",
++    ""tslib"": ""^2.0.0"",
++    ""typescript"": ""^3.9.3""
++  },
++  ""dependencies"": {
++    ""@uppy/dashboard"": ""1.13.0"",
++    ""@uppy/drag-drop"": ""^1.4.18"",
++    ""@uppy/progress-bar"": ""^1.3.18"",
++    ""@uppy/status-bar"": ""1.8.0""
++  },
++  ""peerDependencies"": {
++    ""@uppy/core"": "">=^1.0.0"",
++    ""svelte"": ""^3.0.0""
++  },","```suggestion
+  },
+  ""publishConfig"": {
+    ""access"": ""public""
+  },
+```",2020-12-21 22:53:30
+360,"@@ -0,0 +1,42 @@
++/* global browser, expect, capabilities, $ */
++const path = require('path')
++const { selectFakeFile, supportsChooseFile } = require('../utils')
++
++const testURL = 'http://localhost:4567/transloadit'
++
++function unhideTheInput () {
++  var input = document.querySelector('#uppy-transloadit .uppy-Dashboard-input')
++  input.removeAttribute('hidden')
++  input.removeAttribute('aria-hidden')
++  input.removeAttribute('tabindex')
++}
++
++function setTransloaditKeyAndInit (transloaditKey) {
++  window.initUppyTransloadit(transloaditKey)
++}
++
++describe('Transloadit file processing', () => {
++  beforeEach(() => {
++    browser.url(testURL)
++    browser.execute(setTransloaditKeyAndInit, process.env.TRANSLOADIT_KEY)","We could skip this test if TRANSLOADIT_KEY is not available, so users don't have to set it up to run integration tests when they aren't actually changing anything Transloadit related. See eg the provider tests:
+
+https://github.com/transloadit/uppy/blob/007504cefc12289cc6d4173b5fe6483ff03c1b53/test/endtoend/providers/test.js#L11-L14
+
+I think we could do the check inside a `before(function () {})` section, calling `this.skip()` there should skip the entire test.",2018-10-04 11:19:00
+359,"@@ -0,0 +1,42 @@
++/* global browser, expect, capabilities, $ */
++const path = require('path')
++const { selectFakeFile, supportsChooseFile } = require('../utils')
++
++const testURL = 'http://localhost:4567/transloadit'
++
++function unhideTheInput () {
++  var input = document.querySelector('#uppy-transloadit .uppy-Dashboard-input')
++  input.removeAttribute('hidden')
++  input.removeAttribute('aria-hidden')
++  input.removeAttribute('tabindex')
++}
++
++function setTransloaditKeyAndInit (transloaditKey) {
++  window.initUppyTransloadit(transloaditKey)
++}
++
++describe('Transloadit file processing', () => {
++  beforeEach(() => {
++    browser.url(testURL)
++    browser.execute(setTransloaditKeyAndInit, process.env.TRANSLOADIT_KEY)
++  })
++
++  it('should upload a file to Transloadit and crop it', () => {
++    const inputPath = '#uppy-transloadit .uppy-Dashboard-input'
++    const resultPath = '#uppy-result'
++
++    $(inputPath).waitForExist()
++
++    if (supportsChooseFile(capabilities)) {
++      browser.execute(unhideTheInput)
++      browser.chooseFile(inputPath, path.join(__dirname, '../../resources/image.jpg'))
++    } else {
++      browser.execute(selectFakeFile, 'uppyTransloadit')
++    }
++    browser.pause(15000)
++    // $('.uppy-StatusBar-actionBtn--upload').click()
++    // $(resultPath).waitForExist()","it would be nice to avoid the hardcoded time here…did `waitForExist()` not work?
+
+If that fails we could use `executeAsync` too:
+
+```js
+browser.executeAsync(function (done) {
+  window.onResultAvailable = done
+})
+```
+
+And then call `window.onResultAvailable()` from inside main.js.",2018-10-04 11:16:22
+106,"@@ -0,0 +1,42 @@
++const React = require('react')
++const PropTypes = require('prop-types')
++const UppyCore = require('../core')
++
++const h = React.createElement
++
++class UppyWrapper extends React.Component {
++  constructor (props) {
++    super(props)
++
++    this.refContainer = this.refContainer.bind(this)
++  }
++
++  componentDidMount () {
++    const plugin = this.props.uppy
++      .getPlugin(this.props.plugin)
++
++    plugin.mount(this.container, plugin)
++  }
++
++  componentWillUnmount () {
++    const plugin = this.props.uppy
++      .getPlugin(this.props.plugin)
++
++    plugin.unmount()
++  }
++
++  refContainer (container) {
++    this.container = container
++  }
++
++  render () {
++    return h('div', { ref: this.refContainer })
++  }
++}
++
++UppyWrapper.propTypes = {
++  uppy: PropTypes.instanceOf(UppyCore).isRequired,
++  plugin: PropTypes.string.isRequired",Looking into making a custom proptype validator here to assert that the plugin exists,2017-09-11 10:08:08
+386,"@@ -0,0 +1,43 @@
++require('es6-promise/auto')
++require('whatwg-fetch')
++
++// Core
++exports.Core = require('@uppy/core')
++
++// Utilities
++exports.server = require('@uppy/companion-client')
++exports.views = {
++  ProviderView: require('@uppy/provider-views')
++}
++
++// Stores
++exports.DefaultStore = require('@uppy/store-default')
++exports.ReduxStore = require('@uppy/store-redux')
++
++// UI plugins
++exports.Dashboard = require('@uppy/dashboard')
++exports.DragDrop = require('@uppy/drag-drop')
++exports.FileInput = require('@uppy/file-input')
++exports.Informer = require('@uppy/informer')
++exports.ProgressBar = require('@uppy/progress-bar')
++exports.StatusBar = require('@uppy/status-bar')
++
++// Acquirers
++exports.Dropbox = require('@uppy/dropbox')
++exports.GoogleDrive = require('@uppy/google-drive')
++exports.Instagram = require('@uppy/instagram')
++exports.Url = require('@uppy/url')
++exports.Webcam = require('@uppy/webcam')
++
++// Uploaders
++exports.AwsS3 = require('@uppy/aws-s3')
++exports.AwsS3Multipart = require('@uppy/aws-s3-multipart')
++exports.Transloadit = require('@uppy/transloadit')
++exports.Tus = require('@uppy/tus')
++exports.XHRUpload = require('@uppy/xhr-upload')
++
++// Miscellaneous
++exports.Form = require('@uppy/form')
++exports.GoldenRetriever = require('@uppy/golden-retriever')
++exports.ReduxDevTools = require('@uppy/redux-dev-tools')
++exports.ThumbnailGenerator = require('@uppy/thumbnail-generator')","Is there a way to re-export `index.js` in `bundle.js`, to avoid copy/pasting? 🤔",2018-12-06 13:44:11
+434,"@@ -0,0 +1,44 @@
++---
++title: ""Day 17""
++date: 2019-04-11
++author: samuel
++image: ""https://uppy.io/images/blog/30daystoliftoff/day17.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Today marks the seventeenth day in our '30 Days to Liftoff' blog post challenge, working our way towards **launching Uppy 1.0 on April 25**. The Uppy team is dealing with the big tasks now, and the updates might be a little scanty!
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day17.jpg""><br /><br /></center>
++
++
++<!--more-->
++
++## Done
++
++- [Artur](https://github.com/arturi) updated the [React Native](https://github.com/transloadit/uppy/pull/988) UI example. Here is what the new UI looks like:
++
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-1.png""></center>
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-2.png""></center>
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-3.png""></center>
++
++- [Alex](https://github.com/nqst) updated the focus styles on the Uppy Dashboard, such that it is no longer the ugly border it used to be. Here is what it looks like now:
++","> no longer the ugly border
+
+let’s please tone it down a bit, it’s was not _that_ bad ;)",2019-04-11 12:27:48
+435,"@@ -0,0 +1,44 @@
++---
++title: ""Day 17""
++date: 2019-04-11
++author: samuel
++image: ""https://uppy.io/images/blog/30daystoliftoff/day17.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Today marks the seventeenth day in our '30 Days to Liftoff' blog post challenge, working our way towards **launching Uppy 1.0 on April 25**. The Uppy team is dealing with the big tasks now, and the updates might be a little scanty!
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day17.jpg""><br /><br /></center>
++
++
++<!--more-->
++
++## Done
++
++- [Artur](https://github.com/arturi) updated the [React Native](https://github.com/transloadit/uppy/pull/988) UI example. Here is what the new UI looks like:
++
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-1.png""></center>
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-2.png""></center>
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-3.png""></center>
++
++- [Alex](https://github.com/nqst) updated the focus styles on the Uppy Dashboard, such that it is no longer the ugly border it used to be. Here is what it looks like now:
++
++Before:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-before-focus.gif""></center>
++After:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-after-focus.gif""></center>
++
++
++## In Progress
++
++- Artur is reviewing PRs, reporting errors and testing Uppy to see where Uppy might break. 
++","> and testing Uppy to see where Uppy might break
+
+and testing Uppy in response to the team’s feedback",2019-04-11 12:28:30
+436,"@@ -0,0 +1,44 @@
++---
++title: ""Day 17""
++date: 2019-04-11
++author: samuel
++image: ""https://uppy.io/images/blog/30daystoliftoff/day17.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Today marks the seventeenth day in our '30 Days to Liftoff' blog post challenge, working our way towards **launching Uppy 1.0 on April 25**. The Uppy team is dealing with the big tasks now, and the updates might be a little scanty!
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day17.jpg""><br /><br /></center>
++
++
++<!--more-->
++
++## Done
++
++- [Artur](https://github.com/arturi) updated the [React Native](https://github.com/transloadit/uppy/pull/988) UI example. Here is what the new UI looks like:
++
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-1.png""></center>
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-2.png""></center>
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-react-native-ui-3.png""></center>
++
++- [Alex](https://github.com/nqst) updated the focus styles on the Uppy Dashboard, such that it is no longer the ugly border it used to be. Here is what it looks like now:
++
++Before:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-before-focus.gif""></center>
++After:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-11-after-focus.gif""></center>
++
++
++## In Progress
++
++- Artur is reviewing PRs, reporting errors and testing Uppy to see where Uppy might break. 
++
++- [Alex](https://github.com/nqst) continues [improving Uppy's UI](https://github.com/transloadit/uppy/compare/master...nqst:design-facelift) and has recently been refactoring CSS code, while Evgenia keeps charging at the [many accessibility issues](https://github.com/transloadit/uppy/issues/created_by/nqst) that are still open.
++
++- [Evgenia](https://github.com/lakesare) is working on the new drag/drop implementation where there will be a new `Drop Here` placeholder and we will not be experiencing any flickering. She is also working on  `drop folder` support for cross-browser compatibility, where we won’t be relying on DOM manipulation in our React components.
++","> relying on DOM manipulation in our React components
+
+React --> Preact, we are using Preact",2019-04-11 12:29:14
+571,"@@ -0,0 +1,44 @@
++const tus = require('tus-js-client')
++
++function isCordova () {
++  return typeof window !== 'undefined' && (
++    typeof window.PhoneGap !== 'undefined' ||
++    typeof window.Cordova !== 'undefined' ||
++    typeof window.cordova !== 'undefined'
++  )
++}
++
++function isReactNative () {
++  return typeof navigator !== 'undefined' &&
++    typeof navigator.product === 'string' &&
++    navigator.product.toLowerCase() === 'reactnative'
++}
++
++// We override tus fingerprint to uppy’s `file.id`, since the `file.id`
++// now also includes `relativePath` for files added from folders.
++// This means you can add 2 identical files, if one is in folder a,
++// the other in folder b — `a/file.jpg` and `b/file.jpg`, when added
++// together with a folder, will be treated as 2 separate files.
++//
++// For React Native and Cordova, we let tus-js-client’s default",Is it actually necessary to differentiate between React Native/Cordova and other environments? Is it dangerous if the relative path is just empty there?,2019-08-12 15:27:11
+570,"@@ -0,0 +1,44 @@
++const tus = require('tus-js-client')
++
++function isCordova () {
++  return typeof window !== 'undefined' && (
++    typeof window.PhoneGap !== 'undefined' ||
++    typeof window.Cordova !== 'undefined' ||
++    typeof window.cordova !== 'undefined'
++  )
++}
++
++function isReactNative () {
++  return typeof navigator !== 'undefined' &&
++    typeof navigator.product === 'string' &&
++    navigator.product.toLowerCase() === 'reactnative'
++}
++
++// We override tus fingerprint to uppy’s `file.id`, since the `file.id`
++// now also includes `relativePath` for files added from folders.
++// This means you can add 2 identical files, if one is in folder a,
++// the other in folder b — `a/file.jpg` and `b/file.jpg`, when added
++// together with a folder, will be treated as 2 separate files.
++//
++// For React Native and Cordova, we let tus-js-client’s default
++// fingerprint handling take charge.
++module.exports = function getFingerprint (uppyFileObj) {
++  return function (file, options, callback) {
++    console.log(file, options, callback)",Leftover from debugging?,2019-08-12 15:26:22
+949,"@@ -0,0 +1,44 @@
++import Vue from 'vue'
++import type { Uppy, Plugin } from '@uppy/core'
++
++declare module '@uppy/vue' {",Is this file still necessary? It looks like these exports are now declared by individual typescript files instead and reexported from `index.d.ts`?,2020-11-19 13:15:11
+972,"@@ -0,0 +1,44 @@
++{
++  ""name"": ""@uppy/svelte"",
++  ""svelte"": ""src/index.js"",
++  ""module"": ""dist/index.mjs"",
++  ""main"": ""dist/index.js"",
++  ""version"": ""0.1.0"",
++  ""scripts"": {
++    ""build"": ""rollup -c"",
++    ""prepublishOnly"": ""npm run build"",
++    ""validate"": ""svelte-check""
++  },
++  ""devDependencies"": {
++    ""@rollup/plugin-node-resolve"": ""^9.0.0"",
++    ""@tsconfig/svelte"": ""^1.0.0"",
++    ""@uppy/core"": ""file:../../@uppy/core"",
++    ""rollup"": ""^2.0.0"",
++    ""rollup-plugin-svelte"": ""^6.0.0"",
++    ""svelte"": ""^3.0.0"",
++    ""svelte-check"": ""^1.0.0"",
++    ""svelte-preprocess"": ""^4.0.0"",
++    ""tslib"": ""^2.0.0"",
++    ""typescript"": ""^3.9.3""
++  },
++  ""dependencies"": {
++    ""@uppy/dashboard"": ""1.13.0"",
++    ""@uppy/drag-drop"": ""^1.4.18"",
++    ""@uppy/progress-bar"": ""^1.3.18"",
++    ""@uppy/status-bar"": ""1.8.0""
++  },
++  ""peerDependencies"": {
++    ""@uppy/core"": "">=^1.0.0"",","```suggestion
+    ""@uppy/core"": ""^1.0.0"",
+```
+",2020-12-23 12:42:28
+105,"@@ -0,0 +1,46 @@
++const React = require('react')
++const PropTypes = require('prop-types')
++const UppyCore = require('../core/Core')
++const UppyWrapper = require('./Wrapper')
++
++const h = React.createElement
++
++/**
++ * React Component that renders a Dashboard for an Uppy instance in a Modal
++ * dialog. Visibility of the Modal is toggled using the `open` prop.
++ */
++
++class DashboardModal extends React.Component {
++  componentDidMount () {
++    const uppy = this.props.uppy
++
++    this.plugin = uppy.getPlugin(this.props.plugin)
++    if (this.props.open) {
++      this.plugin.showModal()
++    }
++  }
++
++  componentWillReceiveProps (nextProps) {
++    if (this.props.open && !nextProps.open) {
++      this.plugin.hideModal()
++    } else if (!this.props.open && nextProps.open) {
++      this.plugin.showModal()
++    }
++  }
++
++  render () {
++    return h(UppyWrapper, this.props)
++  }
++}
++
++DashboardModal.propTypes = {
++  uppy: PropTypes.instanceOf(UppyCore).isRequired,
++  open: PropTypes.bool,
++  onRequestClose: PropTypes.func",`onRequestClose` doesn't work yet,2017-09-11 10:07:38
+857,"@@ -0,0 +1,47 @@
++const querystring = require('querystring')
++
++exports.isFolder = (item) => {
++  return false
++}
++
++exports.getItemIcon = (item) => {
++  return item.urls.thumb
++}
++
++exports.getItemSubList = (item) => {
++  return item.results
++}
++
++exports.getItemName = (item) => {
++  return item.description
++}
++
++exports.getMimeType = (item) => {
++  return 'image/jpeg'
++}
++
++exports.getItemId = (item) => {
++  return `${item.id}`
++}
++
++exports.getItemRequestPath = (item) => {
++  return `${item.id}`
++}
++
++exports.getItemModifiedDate = (item) => {
++  return item.created_at
++}
++
++exports.getItemThumbnailUrl = (item) => {
++  return item.urls.thumb
++}
++
++exports.getNextPageQuery = (currentQuery) => {
++  const newCursor = parseInt(currentQuery.cursor || 1) + 1
++  const query = Object.assign({}, currentQuery, {
++    cursor: newCursor
++  })","I think we can use object rest spread in server components now too? Doesn't really matter either way
+```suggestion
+  const query = {
+    ...currentQuery,
+    cursor: newCursor
+  }
+```",2020-08-03 15:49:24
+749,"@@ -0,0 +1,49 @@
++/* global test:false, expect:false, describe:false, beforeAll:false, */
++const logger = require('../../src/server/logger')
++const chalk = require('chalk')
++
++describe('Test Logger secret mask', () => {
++  beforeAll(() => {
++    logger.addMaskables(['ToBeMasked1', 'toBeMasked2'])
++  })
++
++  test('masks secret values present in log.info messages', () => {
++    let loggedMessage = null
++
++    // override the default console.log to capture the logged message
++    const defualtConsoleLog = console.log","typo:
+`defualtConsoleLog` →
+`defaultConsoleLog`",2020-04-22 07:59:56
+750,"@@ -0,0 +1,49 @@
++/* global test:false, expect:false, describe:false, beforeAll:false, */
++const logger = require('../../src/server/logger')
++const chalk = require('chalk')
++
++describe('Test Logger secret mask', () => {
++  beforeAll(() => {
++    logger.addMaskables(['ToBeMasked1', 'toBeMasked2'])
++  })
++
++  test('masks secret values present in log.info messages', () => {
++    let loggedMessage = null
++
++    // override the default console.log to capture the logged message
++    const defualtConsoleLog = console.log
++    console.log = (logPrefix, message) => {
++      loggedMessage = message
++      defualtConsoleLog(logPrefix, message)
++    }
++
++    logger.info('this info has ToBeMasked1 and toBeMasked2 and case-insensitive TOBEMasKED2')
++    // restore the default console.log before using ""expect"" to avoid weird log behaviors
++    console.log = defualtConsoleLog
++
++    const exptectedMsg = 'this info has ****** and ****** and case-insensitive ******'
++
++    expect(loggedMessage).toBeTruthy()
++    expect(loggedMessage).toBe(exptectedMsg)
++  })
++
++  test('masks secret values present in log.warn messages', () => {
++    let loggedMessage = null
++
++    // override the default console.log to capture the logged message
++    const defualtConsoleLog = console.log","also here:
+`defualtConsoleLog` →
+`defaultConsoleLog`",2020-04-22 08:00:04
+623,"@@ -0,0 +1,499 @@
++const { Plugin } = require('@uppy/core')
++const { Socket, Provider, RequestClient } = require('@uppy/companion-client')
++const EventTracker = require('@uppy/utils/lib/EventTracker')
++const emitSocketProgress = require('@uppy/utils/lib/emitSocketProgress')
++const getSocketHost = require('@uppy/utils/lib/getSocketHost')
++const RateLimitedQueue = require('@uppy/utils/lib/RateLimitedQueue')
++const Uploader = require('./B2Uploader')
++
++function assertServerError (res) {
++  if (res && res.error) {
++    const error = new Error(res.message)
++    Object.assign(error, res.error)
++    throw error
++  }
++  return res
++}
++
++module.exports = class BackblazeB2Multipart extends Plugin {
++  static VERSION = require('../package.json').version
++
++  constructor (uppy, opts) {
++    super(uppy, opts)
++    this.type = 'uploader'
++    this.id = this.opts.id || 'BackblazeB2Multipart'
++    this.title = 'Backblaze B2 Multipart'
++    this.client = new RequestClient(uppy, opts)
++    this.sharedEndpointPool = []
++
++    const defaultOptions = {
++      timeout: 30 * 1000,
++      limit: 0,
++      createMultipartUpload: this.createMultipartUpload.bind(this),
++      getEndpoint: this.getEndpoint.bind(this),
++      listParts: this.listParts.bind(this),
++      // prepareUploadPart: this.prepareUploadPart.bind(this),
++      abortMultipartUpload: this.abortMultipartUpload.bind(this),
++      completeMultipartUpload: this.completeMultipartUpload.bind(this)
++    }
++
++    this.opts = { ...defaultOptions, ...opts }
++
++    this.upload = this.upload.bind(this)
++
++    this.requests = new RateLimitedQueue(this.opts.limit)
++
++    this.uploaders = Object.create(null)
++    this.uploaderEvents = Object.create(null)
++    this.uploaderSockets = Object.create(null)
++  }
++
++  /**
++   * Clean up all references for a file's upload: the MultipartUploader instance,
++   * any events related to the file, and the Companion WebSocket connection.
++   *
++   * Set `opts.abort` to tell b2 that the multipart upload is cancelled and must be removed.
++   * This should be done when the user cancels the upload, not when the upload is completed or errored.
++   */
++  resetUploaderReferences (fileID, opts = {}) {
++    if (this.uploaders[fileID]) {
++      this.uploaders[fileID].abort({ really: opts.abort || false })
++      this.uploaders[fileID] = null
++    }
++    if (this.uploaderEvents[fileID]) {
++      this.uploaderEvents[fileID].remove()
++      this.uploaderEvents[fileID] = null
++    }
++    if (this.uploaderSockets[fileID]) {
++      this.uploaderSockets[fileID].close()
++      this.uploaderSockets[fileID] = null
++    }
++  }
++
++  assertHost () {
++    if (!this.opts.companionUrl) {
++      throw new Error('Expected a `companionUrl` option containing a Companion address.')
++    }
++  }
++
++  createMultipartUpload (file) {
++    this.assertHost()
++
++    const metadata = {}
++
++    Object.keys(file.meta).map(key => {","since the returned array is not used, we should probably be using `forEach` instead of `map`",2019-11-17 12:43:30
+245,"@@ -0,0 +1,5 @@
++const ProviderView = require('./ProviderView')
++
++module.exports = {
++  ProviderView
++}","Seems like `src/views` also conflicts a bit with splitting into multiple packages? I was thinking we were going to do `provider-views` package for the ProviderView and `uppy-server-connect` (draft name) for `RequestClient`?
+
+We can look at Babel’s package folder structure: https://github.com/babel/babel/tree/master/packages",2018-03-28 00:34:32
+808,"@@ -0,0 +1,50 @@
++const qs = require('qs')
++
++const MIMETYPES = {
++  MP4: 'video/mp4',
++  M4A: 'audio/mp4',
++  CHAT: 'text/plain',
++  TRANSCRIPT: 'text/plain', // note: waiting confirmation, https://devforum.zoom.us/t/retrieve-all-past-zoom-cloud-recordings/22487/5?u=mokutsu
++  CC: 'text/vtt'
++}
++
++exports.getQuery = (results, dateRange) => {
++  const query = {
++    cursor: dateRange.monthsInPast","does this cursor require a specific format or does it only accept a plain string? It seemed like setting an object to cursor triggered excessive requests for infinite scroll, not sure why ",2020-07-02 21:45:11
+804,"@@ -0,0 +1,50 @@
++const { AbortController, AbortSignal } = require('./AbortController')
++
++function flushInstantTimeouts () {
++  return new Promise(resolve => setTimeout(resolve, 0))
++}
++
++describe('AbortController', () => {
++  it('has the expected shape', () => {
++    const controller = new AbortController()
++    expect(typeof controller.abort).toBe('function')
++    expect(controller.signal).toBeInstanceOf(AbortSignal)
++  })
++
++  it('emits ""abort"" when abort() is called', async () => {
++    const controller = new AbortController()
++    const callback = jest.fn()
++
++    controller.signal.addEventListener('abort', callback)
++    controller.abort()
++
++    await flushInstantTimeouts()
++
++    expect(callback).toHaveBeenCalled()
++    expect(callback.mock.calls[0][0]).toBeInstanceOf(Event)
++  })
++
++  it('add and remove events', async () => {
++    const controller = new AbortController()
++    const callback = jest.fn()
++    const callback2 = jest.fn()
++
++    controller.signal.addEventListener('abort', callback)
++    controller.signal.addEventListener('abort', callback2)
++    controller.signal.removeEventListener('abort', callback)
++    controller.abort()
++
++    await flushInstantTimeouts()
++
++    expect(callback2).toHaveBeenCalled()
++    expect(callback2.mock.calls[0][0]).toBeInstanceOf(Event)","should we also be doing something like:
+
+```js
+expect(callback).not.toHaveBeenCalled()
+```
+to actually test the `removeEventListener`?",2020-07-01 13:16:01
+31,"@@ -0,0 +1,51 @@
++module.exports = class Client {
++  constructor (opts) {
++    this.apiUrl = 'https://api2.transloadit.com'
++    this.opts = opts
++  }
++
++  /**
++   * Create a new assembly.
++   *
++   * @param {object} options
++   */
++  createAssembly ({ templateId, expectedFiles }) {
++    const data = new FormData()
++    data.append('params', JSON.stringify({
++      template_id: templateId,
++      auth: { key: this.opts.key }
++    }))
++    data.append('fields', JSON.stringify({
++      // Nothing yet.
++    }))
++    data.append('tus_num_expected_upload_files', expectedFiles)
++
++    return fetch(`${this.apiUrl}/assemblies`, {
++      method: 'post',
++      body: data
++    }).then((response) => response.json()).then((assembly) => {
++      if (assembly.error) {
++        const error = new Error(assembly.message)
++        error.code = assembly.error
++        error.status = assembly
++        throw error
++      }
++
++      return this.getAssemblyStatus(assembly.status_endpoint)
++    })
++  }
++
++  /**
++   * Get the current status for an assembly.
++   *
++   * @param {string} url The status endpoint of the assembly.
++   */
++  getAssemblyStatus (url) {
++    return fetch(url)
++      .then((response) => response.json())
++  }
++
++  getTusEndpoint () {
++    return `${this.apiUrl}/resumable/files/`","This should use the same endpoint as the `assembly` later, I think. Currently it just always goes to api2.transloadit.com/resumable. There should be a `tus_url` in assembly status responses now that can be used to make that happen :raised_hands: ",2017-04-10 12:16:05
+422,"@@ -0,0 +1,53 @@
++---
++title: ""Day 8""
++date: 2019-04-02
++author: samuel
++image: ""https://uppy.io/images/blog/30daystoliftoff/day08.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Welcome to Day 8 of our ongoing thirty-day blog post challenge toward the **Uppy 1.0 release on April 25**! Yesterday was the 1st of April, the day we really kickstarted our coding speedrun towards 1.0
++
++The entire team during the weekly call yesterday iterated on the whole process again, moving a lot of cards from the `todo` lane to the `in progress` lane. This is what our board currently looks like.
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-02-asana-board.png""><br /></center>
++
++Let's dive into the updates we have ready to share with you.
++
++
++<!--more-->
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day07.jpg""><br /></center>
++
++## Done
++- [Artur](https://transloadit.com/about/#artur) merged this [PR](https://github.com/transloadit/uppy/pull/1393) which removed the use of `window.location` from companion's client coutrsey of [Ife](https://transloadit.com/about/#ife)
++- [Alex](https://transloadit.com/about/#alex) improved the design of the drag to upload stage. <br />
++Before:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-02-before.png""></center>
++After:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-02-after.png""></center>
++- [Evgenia](https://github.com/lakesare) made list items even out using the `justify-content: space-between` CSS property.
++","that’s incorrect, let’s just say she “made file items even out properly”, she didn’t use `space-between` @AJvanLoon ",2019-04-02 13:43:08
+421,"@@ -0,0 +1,53 @@
++---
++title: ""Day 8""
++date: 2019-04-02
++author: samuel
++image: ""https://uppy.io/images/blog/30daystoliftoff/day08.jpg""
++series: 30 Days to Liftoff
++seriesSuffix: 'of 30'
++---
++
++Welcome to Day 8 of our ongoing thirty-day blog post challenge toward the **Uppy 1.0 release on April 25**! Yesterday was the 1st of April, the day we really kickstarted our coding speedrun towards 1.0
++
++The entire team during the weekly call yesterday iterated on the whole process again, moving a lot of cards from the `todo` lane to the `in progress` lane. This is what our board currently looks like.
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-02-asana-board.png""><br /></center>
++
++Let's dive into the updates we have ready to share with you.
++
++
++<!--more-->
++
++<center><br /><img width=""400"" src=""/images/blog/30daystoliftoff/day07.jpg""><br /></center>
++
++## Done
++- [Artur](https://transloadit.com/about/#artur) merged this [PR](https://github.com/transloadit/uppy/pull/1393) which removed the use of `window.location` from companion's client coutrsey of [Ife](https://transloadit.com/about/#ife)
++- [Alex](https://transloadit.com/about/#alex) improved the design of the drag to upload stage. <br />
++Before:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-02-before.png""></center>
++After:<br />
++<center><img width=""400"" src=""/images/blog/30daystoliftoff/2019-04-02-after.png""></center>
++- [Evgenia](https://github.com/lakesare) made list items even out using the `justify-content: space-between` CSS property.
++
++## In Progress
++
++- We are currently investigating an issue with `tuts-js-client` which affects uploads where the file size is larger than 500MB as reported in this [issue](https://github.com/tus/tus-js-client/issues/146).",`tuts` typo,2019-04-02 12:44:13
+767,"@@ -0,0 +1,55 @@
++---
++title: ""Initializing Uppy""
++type: docs
++module: ""@uppy/react""
++permalink: docs/react/initializing/
++alias: docs/react/initializing/
++order: 1
++category: ""React""
++---
++
++Your Uppy instance must be initialized before passing it to an `uppy={}` prop in the desired component,
++and should be cleaned up using `uppy.close()` when you are done with it.
++
++## Class Components
++
++A simple approach is to initialize it in your React component's `constructor()` and destroy it in `componentWillUnmount()`.
++
++> ⚠ Uppy instances are stateful, so the same instance must be used across different renders.
++> Do **NOT** initialize Uppy in a `render()` method!
++
++```js
++class MyComponent extends React.Component {
++  constructor (props) {
++    super(props)
++    this.uppy = Uppy()
++      .use(Transloadit, {})
++  }
++
++  componentWillUnmount () {
++    this.uppy.close()
++  }
++
++  render () {
++    return <DashboardModal uppy={this.uppy} />
++  }
++}
++```
++
++## Functional Components
++
++With react hooks, writing pure functional components are on hype. For wealthy initializing Uppy in a functional component, we need to use the `useMemo` hook for keeping the same instance across multiple renders and use `useEffect` for cleaning up things when the component is unmounted.
++
++```js
++const MyComponent = () => {
++  const uppy = useMemo(() => Uppy().use(Transloadit, {}), []);
++
++  useEffect(() => {
++    return () => uppy.close()
++  }, [])
++
++  return <DashboardModal uppy={uppy.current} />","I was able to follow these docs to get this working.  The only change I had to make was to use   return ```<DashboardModal uppy={uppy} />``` instead of ```<DashboardModal uppy={uppy.current}/>```
+",2020-05-08 02:50:22
+627,"@@ -0,0 +1,55 @@
++---
++title: ""Initializing Uppy""
++type: docs
++module: ""@uppy/react""
++permalink: docs/react/initializing/
++alias: docs/react/initializing/
++order: 1
++category: ""React""
++---
++
++Your Uppy instance must be initialized before passing it to an `uppy={}` prop in the desired component,
++and should be cleaned up using `uppy.close()` when you are done with it.
++
++## Class Components
++
++A simple approach is to initialize it in your React component's `constructor()` and destroy it in `componentWillUnmount()`.
++
++> ⚠ Uppy instances are stateful, so the same instance must be used across different renders.
++> Do **NOT** initialize Uppy in a `render()` method!
++
++```js
++class MyComponent extends React.Component {
++  constructor (props) {
++    super(props)
++    this.uppy = Uppy()
++      .use(Transloadit, {})
++  }
++
++  componentWillUnmount () {
++    this.uppy.close()
++  }
++
++  render () {
++    return <DashboardModal uppy={this.uppy} />
++  }
++}
++```
++
++## Functional Components
++
++With react hooks, writing pure functional components are on hype. For wealthy initializing Uppy in a functional component, we need to use the `useRef` hook for keeping the same instance across multiple renders and use `useEffect` for cleaning up things when the component is unmounted.
++
++```js
++const MyComponent = () => {
++  const uppy = useRef(Uppy().use(Transloadit, {}));","This will create a ""garbage"" instance of Uppy on every render, because the `Uppy()` function is called even before `useRef()`--wonder if we can just create it once? :thinking: ",2019-11-18 13:50:40
+631,"@@ -0,0 +1,55 @@
++---
++title: ""Initializing Uppy""
++type: docs
++module: ""@uppy/react""
++permalink: docs/react/initializing/
++alias: docs/react/initializing/
++order: 1
++category: ""React""
++---
++
++Your Uppy instance must be initialized before passing it to an `uppy={}` prop in the desired component,
++and should be cleaned up using `uppy.close()` when you are done with it.
++
++## Class Components
++
++A simple approach is to initialize it in your React component's `constructor()` and destroy it in `componentWillUnmount()`.
++
++> ⚠ Uppy instances are stateful, so the same instance must be used across different renders.
++> Do **NOT** initialize Uppy in a `render()` method!
++
++```js
++class MyComponent extends React.Component {
++  constructor (props) {
++    super(props)
++    this.uppy = Uppy()
++      .use(Transloadit, {})
++  }
++
++  componentWillUnmount () {
++    this.uppy.close()
++  }
++
++  render () {
++    return <DashboardModal uppy={this.uppy} />
++  }
++}
++```
++
++## Functional Components
++
++With react hooks, writing pure functional components are on hype. For wealthy initializing Uppy in a functional component, we need to use the `useRef` hook for keeping the same instance across multiple renders and use `useEffect` for cleaning up things when the component is unmounted.
++
++```js
++const MyComponent = () => {
++  const uppy = useRef(Uppy().use(Transloadit, {}));
++
++  useEffect(() => {
++    return () => uppy.current.close()","From es-lint: The ref value for `uppy.current` will likely have changed by the time this effect cleanup function runs. Copy `uppy.current` to a variable inside the effect, and use that variable in the cleanup function. 
+```suggestion
+    const currentUppyInstance = uppy.current
+    return () =>  currentUppyInstance.close()
+```",2019-11-19 23:00:28
+730,"@@ -0,0 +1,59 @@
++---
++title: ""Initializing Uppy""
++type: docs
++module: ""@uppy/react""
++permalink: docs/react/initializing/
++alias: docs/react/initializing/
++order: 1
++category: ""React""
++---
++
++Your Uppy instance must be initialized before passing it to an `uppy={}` prop in the desired component,
++and should be cleaned up using `uppy.close()` when you are done with it.
++
++## Class Components
++
++A simple approach is to initialize it in your React component's `constructor()` and destroy it in `componentWillUnmount()`.
++
++> ⚠ Uppy instances are stateful, so the same instance must be used across different renders.
++> Do **NOT** initialize Uppy in a `render()` method!
++
++```js
++class MyComponent extends React.Component {
++  constructor (props) {
++    super(props)
++    this.uppy = Uppy()
++      .use(Transloadit, {})
++  }
++
++  componentWillUnmount () {
++    this.uppy.close()
++  }
++
++  render () {
++    return <DashboardModal uppy={this.uppy} />
++  }
++}
++```
++
++## Functional Components
++
++With react hooks, writing pure functional components are on hype. For wealthy initializing Uppy in a functional component, we need to use the `useRef` and `useMemo` hooks for keeping the same instance across multiple renders and use `useEffect` for cleaning up things when the component is unmounted.
++
++```js
++const MyComponent = () => {
++  const uppyInstance = useMemo(() => Uppy().use(Transloadit, {}), []);
++
++  const uppy = useRef(uppyInstance);","Is useRef still required here? Looking at this code, I think just useMemo/useEffect might be enough?",2020-04-06 11:07:55
+688,"@@ -0,0 +1,6 @@
++function isNetworkError (xhr) {
++  if (!xhr) return",Shouldn't this return false here?,2020-03-08 09:23:28
+689,"@@ -0,0 +1,6 @@
++function isNetworkError (xhr) {
++  if (!xhr) return
++  return (xhr.readyState !== 0 && xhr.readyState !== 4) || xhr.status === 0",Did you test this condition and can confirm that it works as expected?,2020-03-08 09:23:48
+244,"@@ -0,0 +1,61 @@
++'use strict'
++
++require('whatwg-fetch')
++
++module.exports = class Request {",this name sounds like `new Request` would be initiating a single request. maybe something along the lines of `RequestClient` would be clearer?,2018-03-26 13:58:49
+392,"@@ -0,0 +1,61 @@
++{",are we also saving `package-lock` files for each uppy package? 🤔 ,2019-01-27 06:42:08
+879,"@@ -0,0 +1,62 @@
++<template>
++  <div ref=""container"" />
++</template>
++<script>
++import DashboardPlugin from '@uppy/dashboard'
++
++export default {
++  data () {
++    return {
++      plugin: null
++    }
++  },
++  props: {
++    uppy: {
++      required: true
++    },
++    props: {","I'm not sure what the idiomatic Vue way is … does it make sense to be able to do something like this?
+```
+<Dashboard
+  hideCancelButton=""true""
+/>
+```
+Or is the `props=""{ hideCancelButton: true }""` nesting quite normal?",2020-09-09 07:56:41
+880,"@@ -0,0 +1,62 @@
++<template>
++  <div ref=""container"" />
++</template>
++<script>
++import DashboardPlugin from '@uppy/dashboard'
++
++export default {
++  data () {
++    return {
++      plugin: null
++    }
++  },
++  props: {
++    uppy: {
++      required: true
++    },
++    props: {
++      type: Object
++    },
++    plugins: {
++      type: Array
++    }
++  },
++  mounted () {
++    this.installPlugin()
++  },
++  methods: {
++    installPlugin () {
++      const uppy = this.uppy
++      const options = {
++        id: 'vue:Dashboard',
++        inline: true,
++        plugins: this.plugins,
++        ...this.props,
++        target: this.$refs.container
++      }
++      uppy.use(DashboardPlugin, options)
++      this.plugin = uppy.getPlugin(options.id)
++    },
++    uninstallPlugin (uppy = this.uppy) {
++      uppy.removePlugin(this.plugin)
++    }
++  },
++  beforeDestroy () {
++    this.uninstallPlugin()
++  },
++  watch: {
++    uppy (current, old) {
++      if (old !== current) {
++        this.uninstallPlugin(old)
++        this.installPlugin()
++      }
++    },
++    props (current, old) {
++      if (JSON.stringify(old) !== JSON.stringify(current)) {","This may not be quite right for options objects with functions in them. Something like https://www.npmjs.com/package/shallow-equal could work better.
+
+Could we try using `this.plugin.setOptions(current)` here instead of re-installing the plugin?",2020-09-09 08:00:37
+613,"@@ -0,0 +1,620 @@
++const ExifTags = {",Could you please include a link to https://github.com/exif-js/exif-js with a comment that the code was adapted from exif-js and license info? Like here: https://github.com/transloadit/uppy/blob/7873f057ca1301cb642a2521361ff219fb38170b/packages/%40uppy/utils/src/prettyBytes.js#L1-L3. ,2019-11-14 11:21:22
+612,"@@ -0,0 +1,620 @@
++const ExifTags = {
++  // version tags
++  0x9000: 'ExifVersion', // EXIF version
++  0xA000: 'FlashpixVersion', // Flashpix format version
++
++  // colorspace tags
++  0xA001: 'ColorSpace', // Color space information tag
++
++  // image configuration
++  0xA002: 'PixelXDimension', // Valid width of meaningful image
++  0xA003: 'PixelYDimension', // Valid height of meaningful image
++  0x9101: 'ComponentsConfiguration', // Information about channels
++  0x9102: 'CompressedBitsPerPixel', // Compressed bits per pixel
++
++  // user information
++  0x927C: 'MakerNote', // Any desired information written by the manufacturer
++  0x9286: 'UserComment', // Comments by user
++
++  // related file
++  0xA004: 'RelatedSoundFile', // Name of related sound file
++
++  // date and time
++  0x9003: 'DateTimeOriginal', // Date and time when the original image was generated
++  0x9004: 'DateTimeDigitized', // Date and time when the image was stored digitally
++  0x9290: 'SubsecTime', // Fractions of seconds for DateTime
++  0x9291: 'SubsecTimeOriginal', // Fractions of seconds for DateTimeOriginal
++  0x9292: 'SubsecTimeDigitized', // Fractions of seconds for DateTimeDigitized
++
++  // picture-taking conditions
++  0x829A: 'ExposureTime', // Exposure time (in seconds)
++  0x829D: 'FNumber', // F number
++  0x8822: 'ExposureProgram', // Exposure program
++  0x8824: 'SpectralSensitivity', // Spectral sensitivity
++  0x8827: 'ISOSpeedRatings', // ISO speed rating
++  0x8828: 'OECF', // Optoelectric conversion factor
++  0x9201: 'ShutterSpeedValue', // Shutter speed
++  0x9202: 'ApertureValue', // Lens aperture
++  0x9203: 'BrightnessValue', // Value of brightness
++  0x9204: 'ExposureBias', // Exposure bias
++  0x9205: 'MaxApertureValue', // Smallest F number of lens
++  0x9206: 'SubjectDistance', // Distance to subject in meters
++  0x9207: 'MeteringMode', // Metering mode
++  0x9208: 'LightSource', // Kind of light source
++  0x9209: 'Flash', // Flash status
++  0x9214: 'SubjectArea', // Location and area of main subject
++  0x920A: 'FocalLength', // Focal length of the lens in mm
++  0xA20B: 'FlashEnergy', // Strobe energy in BCPS
++  0xA20C: 'SpatialFrequencyResponse', //
++  0xA20E: 'FocalPlaneXResolution', // Number of pixels in width direction per FocalPlaneResolutionUnit
++  0xA20F: 'FocalPlaneYResolution', // Number of pixels in height direction per FocalPlaneResolutionUnit
++  0xA210: 'FocalPlaneResolutionUnit', // Unit for measuring FocalPlaneXResolution and FocalPlaneYResolution
++  0xA214: 'SubjectLocation', // Location of subject in image
++  0xA215: 'ExposureIndex', // Exposure index selected on camera
++  0xA217: 'SensingMethod', // Image sensor type
++  0xA300: 'FileSource', // Image source (3 === DSC)
++  0xA301: 'SceneType', // Scene type (1 === directly photographed)
++  0xA302: 'CFAPattern', // Color filter array geometric pattern
++  0xA401: 'CustomRendered', // Special processing
++  0xA402: 'ExposureMode', // Exposure mode
++  0xA403: 'WhiteBalance', // 1 = auto white balance, 2 = manual
++  0xA404: 'DigitalZoomRation', // Digital zoom ratio
++  0xA405: 'FocalLengthIn35mmFilm', // Equivalent foacl length assuming 35mm film camera (in mm)
++  0xA406: 'SceneCaptureType', // Type of scene
++  0xA407: 'GainControl', // Degree of overall image gain adjustment
++  0xA408: 'Contrast', // Direction of contrast processing applied by camera
++  0xA409: 'Saturation', // Direction of saturation processing applied by camera
++  0xA40A: 'Sharpness', // Direction of sharpness processing applied by camera
++  0xA40B: 'DeviceSettingDescription', //
++  0xA40C: 'SubjectDistanceRange', // Distance to subject
++
++  // other tags
++  0xA005: 'InteroperabilityIFDPointer',
++  0xA420: 'ImageUniqueID' // Identifier assigned uniquely to each image
++}
++
++const TiffTags = {
++  0x0100: 'ImageWidth',
++  0x0101: 'ImageHeight',
++  0x8769: 'ExifIFDPointer',
++  0x8825: 'GPSInfoIFDPointer',
++  0xA005: 'InteroperabilityIFDPointer',
++  0x0102: 'BitsPerSample',
++  0x0103: 'Compression',
++  0x0106: 'PhotometricInterpretation',
++  0x0112: 'Orientation',","Could we theoretically only use `Orientation`, thus saving bytes on not including core/name mappings for all of the other tags?",2019-11-14 11:08:49
+463,"@@ -0,0 +1,63 @@
++// ***
++// View type: list
++// ***
++
++.uppy-ProviderBrowser-viewType--list {
++  background-color: $white;
++
++  li.uppy-ProviderBrowserItem {
++    display: flex;
++    align-items: center;
++    padding: 7px 15px;
++    margin: 0;
++
++    // Checkbox
++    > .uppy-ProviderBrowserItem-fakeCheckbox {
++      margin-right: 15px;","Is deep-deep nesting like this necessary here? Ideally I’d lift a level or so, it becomes a little hard to follow and too specific, I think.",2019-05-16 09:19:02
+898,"@@ -0,0 +1,64 @@
++# @uppy/vue
++
++<img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" width=""120"" alt=""Uppy logo: a superman puppy in a pink suit"" align=""right"">
++
++<a href=""https://www.npmjs.com/package/@uppy/vue""><img src=""https://img.shields.io/npm/v/@uppy/vue.svg?style=flat-square""></a>
++<a href=""https://travis-ci.org/transloadit/uppy""><img src=""https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square"" alt=""Build Status""></a>
++
++Vue component wrappers around Uppy's officially maintained UI plugins.
++
++Uppy is being developed by the folks at [Transloadit](https://transloadit.com), a versatile file encoding service.
++
++## Example
++
++```vue
++<template>
++  <dashboard-modal ",Should this be `DashboardModal`?,2020-10-09 16:51:21
+896,"@@ -0,0 +1,64 @@
++# @uppy/vue
++
++<img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" width=""120"" alt=""Uppy logo: a superman puppy in a pink suit"" align=""right"">
++
++<a href=""https://www.npmjs.com/package/@uppy/vue""><img src=""https://img.shields.io/npm/v/@uppy/vue.svg?style=flat-square""></a>
++<a href=""https://travis-ci.org/transloadit/uppy""><img src=""https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square"" alt=""Build Status""></a>
++
++Vue component wrappers around Uppy's officially maintained UI plugins.
++
++Uppy is being developed by the folks at [Transloadit](https://transloadit.com), a versatile file encoding service.
++
++## Example
++
++```vue
++<template>
++  <dashboard-modal 
++  :uppy=""uppy"" 
++  :open=""open"" 
++  :props=""{
++    onRequestCloseModal: handleClose
++  }""/>
++</template>
++
++<script>
++import Uppy from '@uppy/core'
++import { DashboardModal } from '@uppy/vue'
++
++export default {
++  components: {
++    DashboardModal
++  },
++  computed: {
++    uppy: () => new Uppy()
++  },
++  data () {
++    return {
++      open: false
++    }
++  },
++  methods: {
++    handleClose: () => ''
++  }
++}
++</script>
++```
++
++## Installation
++
++```bash
++$ npm install @uppy/vue
++```
++
++We recommend installing from npm and then using a module bundler such as [Webpack](https://webpack.js.org/), [Browserify](http://browserify.org/) or [Rollup.js](http://rollupjs.org/).
++
++Alternatively, you can also use this plugin in a pre-built bundle from Transloadit's CDN: Edgly. In that case `Uppy` will attach itself to the global `window.Uppy` object. See the [main Uppy documentation](https://uppy.io/docs/#Installation) for instructions.
++
++## Documentation
++
++Documentation for this plugin can be found on the [Uppy website](https://uppy.io/docs/vue), when finalized. For now, you can read them [here](../../../website/src/docs/vue.md)","We probably need to change the url to `uppy.io`, because `website` is not available when you install a package from npm.",2020-09-30 20:16:42
+401,"@@ -0,0 +1,64 @@
++const Uppy = require('@uppy/core')
++const Dashboard = require('@uppy/dashboard')
++const Instagram = require('@uppy/instagram')
++const GoogleDrive = require('@uppy/google-drive')
++const Url = require('@uppy/url')
++const Webcam = require('@uppy/webcam')
++const Tus = require('@uppy/tus')
++
++require('@uppy/core/dist/style.css')
++require('@uppy/dashboard/dist/style.css')
++require('@uppy/url/dist/style.css')
++require('@uppy/webcam/dist/style.css')
++
++const TUS_ENDPOINT = 'https://master.tus.io/files/'
++
++const uppy = Uppy({
++  debug: true,
++  meta: {
++    username: 'John',
++    license: 'Creative Commons'
++  }
++})
++  .use(Dashboard, {
++    trigger: '#pick-files',
++    target: '#upload-form',
++    inline: true,
++    replaceTargetContent: true,
++    metaFields: [
++      { id: 'license', name: 'License', placeholder: 'specify license' },
++      { id: 'caption', name: 'Caption', placeholder: 'add caption' }
++    ],
++    showProgressDetails: true,
++    proudlyDisplayPoweredByUppy: true,
++    note: '2 files, images and video only'
++  })
++  .use(GoogleDrive, { target: Dashboard, serverUrl: 'http://localhost:3020' })
++  .use(Instagram, { target: Dashboard, serverUrl: 'http://localhost:3020' })
++  .use(Url, { target: Dashboard, serverUrl: 'http://localhost:3020' })
++  .use(Webcam, { target: Dashboard })
++  .use(Tus, { endpoint: TUS_ENDPOINT })
++  // .use(GoldenRetriever, {serviceWorker: true})",to delete?,2019-02-10 09:57:01
+368,"@@ -0,0 +1,66 @@
++exports.getUsername = (data) => {",Can we find the username somehow even if there are no files?,2018-10-22 09:43:24
+907,"@@ -0,0 +1,71 @@
++<template>
++  <div ref=""container"" />
++</template>",You might want to convert this into a render function so these files can just be plain `*.ts` instead of vue templates. ,2020-10-27 12:34:56
+369,"@@ -0,0 +1,73 @@
++exports.getUsername = (data) => {
++  return data.data[0].user.username","Should only do this if `data.data[0]` actually exists, in case there are no files",2018-10-22 09:48:50
+983,"@@ -0,0 +1,76 @@
++# Uppy
++
++Hi, thanks for trying out the bundled version of the Uppy File Uploader. You can use
++this from a CDN (e.g. `<script src=""https://releases.transloadit.com/uppy/v1.26.1/uppy.min.js""></script>) or bundle it with your webapp. ","```suggestion
+this from a CDN (e.g. `<script src=""https://releases.transloadit.com/uppy/v1.26.1/uppy.min.js""></script>`) or bundle it with your webapp. 
+```
+missing closing `",2021-03-17 14:50:23
+398,"@@ -0,0 +1,80 @@
++const Transloadit = require('@uppy/transloadit')
++
++const remoteProviders = {
++  dropbox: require('@uppy/dropbox'),
++  'google-drive': require('@uppy/google-drive'),
++  instagram: require('@uppy/instagram'),
++  url: require('@uppy/url')
++}",Hard-coding providers for simpler usage? They are indeed lightweight now 🤔 And I guess that’s what “preset” is for.,2019-01-31 12:14:48
+231,"@@ -0,0 +1,84 @@
++const Plugin = require('../core/Plugin')
++
++module.exports = class DeletrFiles extends Plugin {",Small typo in the name here and in the `this.id` / `this.title` properties below :),2018-02-19 09:17:22
+447,"@@ -0,0 +1,86 @@
++---
++type: docs
++order: 2
++title: ""Thumbnail Generator""
++module: ""@uppy/thumbnail-generator""
++permalink: docs/thumbnail-generator/
++category: 'Miscellaneous'
++---
++
++`@uppy/thumbnail-generator` generates proportional thumbnails (file previews) for images that are added to Uppy. It then creates a string with a local preview url (via `URL.createObjectURL(blob)`) and sets it to `file.preview`. `thumbnail:generated` event is also emitted, see below for details.","this feels like a bit much detail for the introductory paragraph, i'd move this sentence to just below the code sample and write something like
+
+> Now, the `file.preview` property will contain a URL to the thumbnail.
+
+i think the createObjectURL stuff probably doesn't have to be mentioned",2019-04-23 10:40:56
+448,"@@ -0,0 +1,86 @@
++---
++type: docs
++order: 2
++title: ""Thumbnail Generator""
++module: ""@uppy/thumbnail-generator""
++permalink: docs/thumbnail-generator/
++category: 'Miscellaneous'
++---
++
++`@uppy/thumbnail-generator` generates proportional thumbnails (file previews) for images that are added to Uppy. It then creates a string with a local preview url (via `URL.createObjectURL(blob)`) and sets it to `file.preview`. `thumbnail:generated` event is also emitted, see below for details.
++
++This plugin is included by default with the [Dashboard](/docs/dashboard), so you don’t have to include it manually. But it is useful if you are not using the Dashboard and want to display image previews in your custom UI.
++
++```js
++const ThumbnailGenerator = require('@uppy/thumbnail-generator')
++
++uppy.use(ThumbnailGenerator, {
++  thumbnailWidth: 200,
++  // thumbnailHeight: 200 // optional, use either width or height
++})
++```
++
++## Installation
++
++This plugin is published as the `@uppy/thumbnail-generator` package.
++
++Install from NPM:
++
++```shell
++npm install @uppy/thumbnail-generator
++```
++
++In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` global object:
++
++```js
++const ThumbnailGenerator = Uppy.ThumbnailGenerator
++```
++
++## Options
++
++The `@uppy/file-input` plugin has the following configurable options:","```suggestion
+The `@uppy/thumbnail-generator` plugin has the following configurable options:
+```",2019-04-23 13:21:24
+58,"@@ -0,0 +1,95 @@
++const Plugin = require('../Plugin')
++
++module.exports = class AwsS3 extends Plugin {
++  constructor (core, opts) {
++    super(core, opts)
++    this.type = 'uploader'
++    this.id = 'AwsS3'
++    this.title = 'AWS S3'
++
++    const defaultOptions = {
++      getUploadParameters: this.getUploadParameters.bind(this)
++    }
++
++    this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.prepareUpload = this.prepareUpload.bind(this)
++  }
++
++  getFile (id) {
++    return this.core.getState().files[id]
++  }
++
++  getUploadParameters (file) {
++    if (!this.opts.host) {
++      throw new Error('Expected a `host` option containing an uppy-server address.')
++    }
++
++    const filename = encodeURIComponent(file.name)
++    const type = encodeURIComponent(`${file.type.general}/${file.type.specific}`)
++    return fetch(`${this.opts.host}/s3/credentials?filename=${filename}&type=${type}`, {
++      method: 'get',
++      headers: { accept: 'application/json' }
++    }).then((response) => response.json())
++  }
++
++  prepareUpload (fileIDs) {
++    fileIDs.forEach((id) => {
++      this.core.emit('core:preprocess-progress', id, {
++        mode: 'determinate',
++        message: 'Preparing upload...',
++        value: 0
++      })
++    })
++
++    return Promise.all(
++      fileIDs.map((id) => {
++        const file = this.getFile(id)
++        return this.opts.getUploadParameters(file).then((params) => {
++          this.core.emit('core:preprocess-progress', file.id, {
++            mode: 'determinate',
++            message: 'Preparing upload...',
++            value: 1
++          })
++          return params
++        })
++      })
++    ).then((responses) => {
++      const updatedFiles = {}
++      fileIDs.forEach((id, index) => {
++        const file = this.getFile(id)
++        const { endpoint, params } = responses[index]
++        const updatedFile = Object.assign({}, file, {
++          meta: Object.assign({}, file.meta, params),
++          multipart: {
++            endpoint,
++            fieldName: 'file',
++            fields: Object.keys(params),
++            getUploadUrl (xhr) {
++              const locationEl = xhr.responseXML.querySelector('Location')","The only good thing about XML responses is that you can do DOM things with them with 0 effort, hehe",2017-06-23 13:22:40
+180,"@@ -1,10 +1,10 @@
+ const Plugin = require('../../core/Plugin')
+ const Translator = require('../../core/Translator')
+ const dragDrop = require('drag-drop')
+-const Dashboard = require('./Dashboard')
++const DashboardUI = require('./Dashboard')",good call swapping these names! makes more sense this way i think,2017-12-20 18:14:28
+22,"@@ -1,10 +1,10 @@
+-import html from '../../core/html'
++import html from '../core/html'
+ 
+ export default (props) => {
+   const demoLink = props.demo ? html`<a onclick=${props.handleDemoAuth}>Proceed with Demo Account</a>` : null
+   return html`
+-    <div class=""UppyGoogleDrive-authenticate"">
+-      <h1>You need to authenticate with Google before selecting files.</h1>
++    <div class=""UppyPlugin-authenticate"">","I’m thinking what would be the best name for this generic provider view, as you’ve correctly described it in you folder naming. Maybe `UppyAcquire`, `UppyView` or `UppyProvider`? The reason I don’t like `UppyPlugin` is Plugin can be a different thing, like Tus is a plugin that doesn’t even have a view, and ProgressBar is a plugin that does different thing, while this is a generic view for providers.",2016-12-20 05:30:25
+27,"@@ -1,10 +1,10 @@
+-import html from '../../core/html'
++import html from '../core/html'
+ 
+ export default (props) => {
+   const demoLink = props.demo ? html`<a onclick=${props.handleDemoAuth}>Proceed with Demo Account</a>` : null
+   return html`
+-    <div class=""UppyGoogleDrive-authenticate"">
+-      <h1>You need to authenticate with Google before selecting files.</h1>
++    <div class=""UppyPlugin-authenticate"">
++      <h1>You need to authenticate with Dropbox before selecting files.</h1>","We could put ${plugin.id} here, I guess?",2016-12-20 14:56:36
+483,"@@ -1,101 +1,113 @@
+-const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
+ const { h, Component } = require('preact')
+ 
+-const poweredByUppy = (props) => {
+-  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">{props.i18n('poweredBy')} <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"">
+-    <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
+-  </svg><span class=""uppy-Dashboard-poweredByUppy"">Uppy</span></a>
+-}
+ class AddFiles extends Component {
+   constructor (props) {
+     super(props)
+-    this.handleClick = this.handleClick.bind(this)
++
++    this.triggerFileInputClick = this.triggerFileInputClick.bind(this)
++
++    this.renderPoweredByUppy = this.renderPoweredByUppy.bind(this)
++    this.renderHiddenFileInput = this.renderHiddenFileInput.bind(this)
++    this.renderDropPasteBrowseTagline = this.renderDropPasteBrowseTagline.bind(this)
++    this.renderMyDeviceAcquirer = this.renderMyDeviceAcquirer.bind(this)
++    this.renderAcquirer = this.renderAcquirer.bind(this)
+   }
+ 
+-  handleClick (ev) {
+-    this.input.click()
++  triggerFileInputClick () {
++    this.fileInput.click()
+   }
+ 
+-  render () {
+-    const hasAcquirers = this.props.acquirers.length !== 0
++  renderPoweredByUppy () {
++    return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">
++      {this.props.i18n('poweredBy')}
++      <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"">","Spacing between “powered by” text and “Uppy” with icon is gone, adding something like `{' '}` should fix it, I think.",2019-05-27 15:56:07
+485,"@@ -1,101 +1,113 @@
+-const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
+ const { h, Component } = require('preact')
+ 
+-const poweredByUppy = (props) => {
+-  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">{props.i18n('poweredBy')} <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"">
+-    <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
+-  </svg><span class=""uppy-Dashboard-poweredByUppy"">Uppy</span></a>
+-}
+ class AddFiles extends Component {
+   constructor (props) {
+     super(props)
+-    this.handleClick = this.handleClick.bind(this)
++
++    this.triggerFileInputClick = this.triggerFileInputClick.bind(this)
++
++    this.renderPoweredByUppy = this.renderPoweredByUppy.bind(this)
++    this.renderHiddenFileInput = this.renderHiddenFileInput.bind(this)
++    this.renderDropPasteBrowseTagline = this.renderDropPasteBrowseTagline.bind(this)
++    this.renderMyDeviceAcquirer = this.renderMyDeviceAcquirer.bind(this)
++    this.renderAcquirer = this.renderAcquirer.bind(this)
+   }
+ 
+-  handleClick (ev) {
+-    this.input.click()
++  triggerFileInputClick () {
++    this.fileInput.click()
+   }
+ 
+-  render () {
+-    const hasAcquirers = this.props.acquirers.length !== 0
++  renderPoweredByUppy () {
++    return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">
++      {this.props.i18n('poweredBy')}
++      <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"">
++        <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
++      </svg>
++      <span class=""uppy-Dashboard-poweredByUppy"">Uppy</span>
++    </a>
++  }
+ 
+-    if (!hasAcquirers) {
+-      return (
+-        <div class=""uppy-DashboardAddFiles"">
+-          <div class=""uppy-DashboardTabs"">
+-            <ActionBrowseTagline
+-              acquirers={this.props.acquirers}
+-              handleInputChange={this.props.handleInputChange}
+-              i18n={this.props.i18n}
+-              i18nArray={this.props.i18nArray}
+-              allowedFileTypes={this.props.allowedFileTypes}
+-              maxNumberOfFiles={this.props.maxNumberOfFiles}
+-            />
+-          </div>
+-          <div class=""uppy-DashboardAddFiles-info"">
+-            { this.props.note && <div class=""uppy-Dashboard-note"">{this.props.note}</div> }
+-            { this.props.proudlyDisplayPoweredByUppy && poweredByUppy(this.props) }
+-          </div>
+-        </div>
+-      )
+-    }
++  renderHiddenFileInput () {
++    return <input class=""uppy-Dashboard-input""
++      hidden
++      aria-hidden=""true""
++      tabindex={-1}
++      type=""file""
++      name=""files[]""
++      multiple={this.props.maxNumberOfFiles !== 1}
++      // Clear file input","Maybe add that setting an empty `value=""""` wasn’t enough, and we are doing this to fix `onBeforeFileAdded`? Not sure, but might be helpful in the future?",2019-05-27 16:05:09
+484,"@@ -1,101 +1,113 @@
+-const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
+ const { h, Component } = require('preact')
+ 
+-const poweredByUppy = (props) => {
+-  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">{props.i18n('poweredBy')} <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"">
+-    <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
+-  </svg><span class=""uppy-Dashboard-poweredByUppy"">Uppy</span></a>
+-}
+ class AddFiles extends Component {
+   constructor (props) {
+     super(props)
+-    this.handleClick = this.handleClick.bind(this)
++
++    this.triggerFileInputClick = this.triggerFileInputClick.bind(this)
++
++    this.renderPoweredByUppy = this.renderPoweredByUppy.bind(this)
++    this.renderHiddenFileInput = this.renderHiddenFileInput.bind(this)
++    this.renderDropPasteBrowseTagline = this.renderDropPasteBrowseTagline.bind(this)
++    this.renderMyDeviceAcquirer = this.renderMyDeviceAcquirer.bind(this)
++    this.renderAcquirer = this.renderAcquirer.bind(this)
+   }
+ 
+-  handleClick (ev) {
+-    this.input.click()
++  triggerFileInputClick () {
++    this.fileInput.click()
+   }
+ 
+-  render () {
+-    const hasAcquirers = this.props.acquirers.length !== 0
++  renderPoweredByUppy () {
++    return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">
++      {this.props.i18n('poweredBy')}
++      <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"">
++        <path d=""M7.365 10.5l-.01-4.045h2.612L5.5.806l-4.467 5.65h2.604l.01 4.044h3.718z"" fill-rule=""evenodd"" />
++      </svg>
++      <span class=""uppy-Dashboard-poweredByUppy"">Uppy</span>
++    </a>
++  }
+ 
+-    if (!hasAcquirers) {
+-      return (
+-        <div class=""uppy-DashboardAddFiles"">
+-          <div class=""uppy-DashboardTabs"">
+-            <ActionBrowseTagline
+-              acquirers={this.props.acquirers}
+-              handleInputChange={this.props.handleInputChange}
+-              i18n={this.props.i18n}
+-              i18nArray={this.props.i18nArray}
+-              allowedFileTypes={this.props.allowedFileTypes}
+-              maxNumberOfFiles={this.props.maxNumberOfFiles}
+-            />
+-          </div>
+-          <div class=""uppy-DashboardAddFiles-info"">
+-            { this.props.note && <div class=""uppy-Dashboard-note"">{this.props.note}</div> }
+-            { this.props.proudlyDisplayPoweredByUppy && poweredByUppy(this.props) }
+-          </div>
+-        </div>
+-      )
+-    }
++  renderHiddenFileInput () {
++    return <input class=""uppy-Dashboard-input""
++      hidden
++      aria-hidden=""true""
++      tabindex={-1}
++      type=""file""
++      name=""files[]""
++      multiple={this.props.maxNumberOfFiles !== 1}
++      // Clear file input
++      onchange={(event) => {
++        this.props.handleInputChange(event)
++        event.target.value = null
++      }}
++      accept={this.props.allowedFileTypes}
++      ref={(ref) => { this.fileInput = ref }} />
++  }
++
++  renderDropPasteBrowseTagline () {
++    const browse =
++      <button type=""button""
++        class=""uppy-Dashboard-browse""
++        onclick={this.triggerFileInputClick}>
++        {this.props.i18n('browse')}
++      </button>
+ 
+-    // empty value="""" on file input, so that the input is cleared after a file is selected,
+-    // because Uppy will be handling the upload and so we can select same file
+-    // after removing — otherwise browser thinks it’s already selected
++    return <div class=""uppy-Dashboard-dropFilesTitle"">
++      {this.props.acquirers.length === 0
++        ? this.props.i18nArray('dropPaste', { browse })
++        : this.props.i18nArray('dropPasteImport', { browse })
++      }
++    </div>
++  }
++
++  renderMyDeviceAcquirer () {
++    return <div class=""uppy-DashboardTab"" role=""presentation"">
++      <button type=""button""
++        class=""uppy-DashboardTab-btn""
++        role=""tab""
++        tabindex={0}
++        onclick={this.triggerFileInputClick}>
++        {localIcon()}
++        <div class=""uppy-DashboardTab-name"">{this.props.i18n('myDevice')}</div>
++      </button>
++    </div>
++  }
++
++  renderAcquirer (acquirer) {
++    return <div class=""uppy-DashboardTab"" role=""presentation"">","Nitpick: since you’ve refactored this (thanks!), could we add `()` after all of the `return` statements, maybe?",2019-05-27 16:03:35
+47,"@@ -1,11 +1,12 @@
+-const Uppy = require('../../../../src/core')
+-const Dashboard = require('../../../../src/plugins/Dashboard')
+-const GoogleDrive = require('../../../../src/plugins/GoogleDrive')
+-const Dropbox = require('../../../../src/plugins/Dropbox')
+-const Webcam = require('../../../../src/plugins/Webcam')
+-const Tus10 = require('../../../../src/plugins/Tus10')
+-const MetaData = require('../../../../src/plugins/MetaData')
+-const Informer = require('../../../../src/plugins/Informer')
++const Uppy = require('uppy/lib/core')
++const Dashboard = require('uppy/lib/plugins/Dashboard')
++const StatusBar = require('uppy/lib/plugins/StatusBar')
++const GoogleDrive = require('uppy/lib/plugins/GoogleDrive')
++const Dropbox = require('uppy/lib/plugins/Dropbox')
++const Webcam = require('uppy/lib/plugins/Webcam')
++const Tus10 = require('uppy/lib/plugins/Tus10')
++const MetaData = require('uppy/lib/plugins/MetaData')
++const Informer = require('uppy/lib/plugins/Informer')","I used `aliasify` to alias `uppy/lib` → `../../../../src/` here, so the examples are basically copy-pastable into projects that depend on `uppy`.",2017-06-13 13:29:58
+93,"@@ -1,12 +1,27 @@
+ const html = require('yo-yo')
+ const getFileTypeIcon = require('./getFileTypeIcon')
++const onload = require('on-load')
+ const { checkIcon } = require('./icons')
+ 
++let file
++const meta = {}","Hmm, wouldn't this merge in edited metadata from previously edited files? If I change `a.png`'s ""license"" to ""public domain"" and then change `b.png`s ""caption"" to ""hello world"", `meta.license` would still be set to ""public domain""",2017-09-01 08:49:40
+635,"@@ -1,14 +1,33 @@
+ const FileItem = require('./FileItem/index.js')
++const VirtualList = require('./VirtualList')
+ const classNames = require('classnames')
+ const { h } = require('preact')
+ 
++function chunks (list, size) {
++  const chunked = []
++  let currentChunk = []
++  list.forEach((item, i) => {
++    if (currentChunk.length < size) {
++      currentChunk.push(item)
++    } else {
++      chunked.push(currentChunk)
++      currentChunk = [item]
++    }
++  })
++  if (currentChunk.length) chunked.push(currentChunk)
++  return chunked
++}
++
+ module.exports = (props) => {
+   const noFiles = props.totalFileCount === 0
+   const dashboardFilesClass = classNames(
+     'uppy-Dashboard-files',
+     { 'uppy-Dashboard-files--noFiles': noFiles }
+   )
+ 
++  // 190px height + 2 * 5px margin
++  const rowHeight = 200",Maybe we could add a comment in CSS that the height is tied to this property in JS as well?,2019-11-26 15:19:26
+680,"@@ -1,141 +1,150 @@
+ const zh_TW = {}
+ 
+ zh_TW.strings = {
+-  addMoreFiles: '添加更多文件',
+-  addingMoreFiles: '正在添加更多文件',
+-  allowAccessDescription: '為了通過您的相機進行拍照或錄影，請給網站相機的讀取權限',
++  addBulkFilesFailed: {
++    '0': '因伺服器錯誤，無法新增 %{smart_count} 個檔案',
++    '1': '因伺服器錯誤，無法新增 %{smart_count} 個檔案'
++  },
++  addMore: '新增更多',
++  addMoreFiles: '新增更多檔案',
++  addingMoreFiles: '正在新增更多檔案',
++  allowAccessDescription: '為了使用您的相機進行拍照或錄影，請允許網站讀取相機',
+   allowAccessTitle: '請允許對相機的讀取權限',
+   authenticateWith: '連接到%{pluginName}',
+-  authenticateWithTitle: '請使用%{pluginName}進行身份驗證以選擇文件',
++  authenticateWithTitle: '請使用%{pluginName}進行身份驗證以選擇檔案',
+   back: '返回',
+-  addMore: '添加更多',
+   browse: '瀏覽',
+   cancel: '取消',
+   cancelUpload: '取消上傳',
+-  chooseFiles: '選擇文件',
+-  closeModal: '關閉模態',
++  chooseFiles: '選擇檔案',
++  closeModal: '關閉互動視窗',
+   companionAuthError: '需要認證',
+   companionError: '與Companion的連接失敗',
++  companionUnauthorizeHint: '若要取消 %{provider} 帳號認證, 請前往 %{url}',
+   complete: '完成',
+-  connectedToInternet: '連接至網絡',
+-  copyLink: '複製鏈接',
++  connectedToInternet: '連線至網絡',
++  copyLink: '複製連結',
+   copyLinkToClipboardFallback: '複製以下網址',
+-  copyLinkToClipboardSuccess: '鏈接已複製到剪貼板',
++  copyLinkToClipboardSuccess: '連結已複製到剪貼板',
+   creatingAssembly: '準備上傳中...',
+-  creatingAssemblyFailed: 'Transloadit：無法創建程序集',
+-  dashboardTitle: '文件上傳工具',
+-  dashboardWindowTitle: '文件上傳工具窗口（點擊離開以關閉）',
++  creatingAssemblyFailed: 'Transloadit：無法建立程序集',
++  dashboardTitle: '檔案上傳工具',
++  dashboardWindowTitle: '檔案上傳視窗（點擊離開以關閉）',
+   dataUploadedOfTotal: '%{total}%{complete}',
+   done: '完成',
+-  dropHereOr: '拖動文件到這裡或%{browse}',
+-  dropHint: '拖動文件到這裡',
+-  dropPaste: '拖動文件到這裡，黏貼或者%{browse}',
+-  dropPasteImport: '拖動文件到這裡，黏貼，%{browse}或者導入',
++  dropHereOr: '拖曳檔案到這裡或%{browse}',
++  dropHint: '拖曳檔案到這裡',
++  dropPaste: '拖曳檔案到這裡，貼上或者%{browse}',
++  dropPasteImport: '拖曳檔案到這裡，貼上，%{browse}或者匯入',
+   edit: '編輯',
+-  editFile: '編輯文件',
+-  editing: '正在編輯%{file}',
+-  emptyFolderAdded: '無法從空文件夾添加文件',
++  editFile: '編輯檔案',
++  editing: '編輯%{file}中',
++  emptyFolderAdded: '無法從空資料夾新增檔案',
+   encoding: '編碼中...',
+-  enterCorrectUrl: '錯誤鏈接： 請確認您輸入的是文件的鏈接',
+-  enterUrlToImport: '輸入鏈接或者導入文件',
+-  exceedsSize: '此文件超出允許的最大大小',
+-  failedToFetch: 'Companion無法抓取此鏈接，請確保它是正確的',
++  enterCorrectUrl: '錯誤連結： 請確認您輸入的是檔案連結',
++  enterUrlToImport: '輸入連結或者匯入文件',
++  exceedsSize: '此檔案大小超出允許的最大值',
++  failedToFetch: 'Companion無法抓取此連結，請確認它是正確的',
+   failedToUpload: '上傳%{file}失敗',
+-  fileSource: '文件來源：%{name}',
++  fileSource: '檔案來源：%{name}',
+   filesUploadedOfTotal: {
+-    '0': '%{smart_count}個文件上傳%{complete}',
+-    '1': '%{smart_count}個文件上傳%{complete}',
+-    '2': '%{smart_count}個文件上傳%{complete}'
++    '0': '%{smart_count}個檔案上傳%{complete}',
++    '1': '%{smart_count}個檔案上傳%{complete}',
++    '2': '%{smart_count}個檔案上傳%{complete}'
+   },
+   filter: '篩選器',
+-  finishEditingFile: '完成文件編輯',
++  finishEditingFile: '完成檔案編輯',
+   folderAdded: {
+-    '0': '從%{folder}添加了%{smart_count}個文件',
+-    '1': '從%{folder}添加了%{smart_count}個文件',
+-    '2': '從%{folder}添加了%{smart_count}個文件'
++    '0': '從%{folder}新增了%{smart_count}個檔案',
++    '1': '從%{folder}新增了%{smart_count}個檔案',
++    '2': '從%{folder}新增了%{smart_count}個檔案'
+   },
+-  import: '導入',
+-  importFrom: '從%{name}導入',
+-  link: '鏈接',
++  generatingThumbnails: '產生縮圖中...',
++  import: '匯入',
++  importFrom: '從%{name}匯入',
++  link: '連結',
+   loading: '載入中...',
+   logOut: '登出',
+-  myDevice: '我的設備',
++  myDevice: '我的裝置',
++  noDuplicates: '無法新增重複檔案 \'%{fileName}\' 已存在',
+   noFilesFound: '這裡空空如也',
+-  noInternetConnection: '無法連接到網絡',
++  noInternetConnection: '無法連線到網絡',
++  noNewAlreadyUploading: '無法新增檔案: 已在上傳中',
++  openFolderNamed: '開啟資料夾 %{name}',
+   pause: '暫停',
+   pauseUpload: '暫停上傳',
+   paused: '已暫停',
+-  poweredBy: '強力驅動於',
++  poweredBy: '技術提供者',
+   preparingUpload: '準備上傳中...',
+   processingXFiles: {
+-    '0': '%{smart_count}個文件處理中',
+-    '1': '%{smart_count}個文件處理中',
+-    '2': '%{smart_count}個文件處理中'
++    '0': '%{smart_count}個檔案處理中',
++    '1': '%{smart_count}個檔案處理中',
++    '2': '%{smart_count}個檔案處理中'
+   },
+-  removeFile: '移除文件',
+-  resetFilter: '重置篩選器',
++  recordingLength: '錄影長度 %{recording_length}',
++  removeFile: '移除檔案',
++  resetFilter: '重設篩選器',
+   resume: '恢復',
+   resumeUpload: '恢復上傳',
+   retry: '重試',
+   retryUpload: '重試上傳',
+-  saveChanges: '保存變更',
++  saveChanges: '儲存變更',
++  selectAllFilesFromFolderNamed: '選擇資料夾 %{name} 中的所有檔案',
++  selectFileNamed: '選擇檔案 %{name}',
+   selectX: {
+-    '0': '选择%{smart_count}',
+-    '1': '选择%{smart_count}',
+-    '2': '选择%{smart_count}'
++    '0': '選擇%{smart_count}',
++    '1': '選擇%{smart_count}',
++    '2': '選擇%{smart_count}'
+   },
+-  smile: '笑！',
+-  startRecording: '開始影片錄制',
+-  stopRecording: '停止影片錄制',
++  smile: '請微笑！',
++  startRecording: '開始錄影',
++  stopRecording: '停止錄影',
+   takePicture: '拍照',
+-  timedOut: '上傳已經停滯不前%{seconds}秒，中止上傳',
++  timedOut: '上傳已經停滯%{seconds}秒，中止上傳',
++  unselectAllFilesFromFolderNamed: '取消選擇資料夾 %{name} 中的所有檔案',
++  unselectFileNamed: '取消選擇檔案 %{name}',
+   upload: '上傳',
+   uploadComplete: '上傳完成',
+   uploadFailed: '上傳失敗',
+-  uploadPaused: '上傳暫停',
++  uploadPaused: '暫停上傳',
+   uploadXFiles: {
+-    '0': '上傳%{smart_count}個文件',
+-    '1': '上傳%{smart_count}個文件',
+-    '2': '上傳%{smart_count}個文件'
++    '0': '上傳%{smart_count}個檔案',
++    '1': '上傳%{smart_count}個檔案',
++    '2': '上傳%{smart_count}個檔案'
+   },
+   uploadXNewFiles: {
+-    '0': '新上傳了%{smart_count}個文件',
+-    '1': '新上傳了%{smart_count}個文件',
+-    '2': '新上傳了%{smart_count}個文件'
++    '0': '新上傳了%{smart_count}個檔案',
++    '1': '新上傳了%{smart_count}個檔案',
++    '2': '新上傳了%{smart_count}個檔案'
+   },
+-  uploading: '正在上傳',
++  uploading: '上傳中',
+   uploadingXFiles: {
+-    '0': '正在上傳%{smart_count}個文件',
+-    '1': '正在上傳%{smart_count}個文件',
+-    '2': '正在上傳%{smart_count}個文件'
++    '0': '上傳%{smart_count}個檔案中',
++    '1': '上傳%{smart_count}個檔案中',
++    '2': '上傳%{smart_count}個檔案中'
+   },
+   xFilesSelected: {
+-    '0': '%{smart_count}個文件被選中',
+-    '1': '%{smart_count}個文件被選中',
+-    '2': '%{smart_count}個文件被選中'
++    '0': '已選擇%{smart_count}個檔案',
++    '1': '已選擇%{smart_count}個檔案',
++    '2': '已選擇%{smart_count}個檔案'
+   },
+   xMoreFilesAdded: {
+-    '0': '又有%{smart_count}個文件被添加',
+-    '1': '又有%{smart_count}個文件被添加',
+-    '2': '又有%{smart_count}個文件被添加'
++    '0': '又新增%{smart_count}個檔案',
++    '1': '又新增%{smart_count}個檔案',
++    '2': '又新增%{smart_count}個檔案'
+   },
+   xTimeLeft: '還剩下%{time}',
+-  youCanOnlyUploadFileTypes: '您只能上傳這些文件類型：%{types}',
++  youCanOnlyUploadFileTypes: '您只能上傳這些檔案類型：%{types}',
+   youCanOnlyUploadX: {
+-    '0': '您只能上傳%{smart_count}個文件',
+-    '1': '您只能上傳%{smart_count}個文件',
+-    '2': '您只能上傳%{smart_count}個文件'
++    '0': '您只能上傳%{smart_count}個檔案',
++    '1': '您只能上傳%{smart_count}個檔案',
++    '2': '您只能上傳%{smart_count}個檔案'
+   },
+   youHaveToAtLeastSelectX: {
+-    '0': '您至少要選擇%{smart_count}個文件',
+-    '1': '您至少要選擇%{smart_count}個文件',
+-    '2': '您至少要選擇%{smart_count}個文件'
++    '0': '您至少要選擇%{smart_count}個檔案',
++    '1': '您至少要選擇%{smart_count}個檔案',
++    '2': '您至少要選擇%{smart_count}個檔案'
+   },","```suggestion
+}
+```",2020-02-21 15:18:12
+1,"@@ -1,15 +0,0 @@
+-# transloadit-js-client","Would be cool if the project had _some_ kind of readme still. I'm not against keeping the design goals where everyone can see them.
+",2015-11-17 09:08:56
+651,"@@ -1,155 +1,244 @@
+-import UppyUtils = require('@uppy/utils');
++import UppyUtils = require('@uppy/utils')
+ 
+ declare module Uppy {
+   // Utility types
+-  type OmitKey<T, Key> = Pick<T, Exclude<keyof T, Key>>;
++  type OmitKey<T, Key> = Pick<T, Exclude<keyof T, Key>>
+ 
+   // These are defined in @uppy/utils instead of core so it can be used there without creating import cycles
+-  export type UppyFile<TMeta extends IndexedObject<any> = {}, TBody extends IndexedObject<any> = {}> = UppyUtils.UppyFile<TMeta, TBody>;
+-  export type Store = UppyUtils.Store;
+-  export type InternalMetadata = UppyUtils.InternalMetadata;
++  export type UppyFile<
++    TMeta extends IndexedObject<any> = {},
++    TBody extends IndexedObject<any> = {}
++  > = UppyUtils.UppyFile<TMeta, TBody>
++  export type Store = UppyUtils.Store
++  export type InternalMetadata = UppyUtils.InternalMetadata
+ 
+   interface IndexedObject<T> {
+-    [key: string]: T;
+-    [key: number]: T;
++    [key: string]: T
++    [key: number]: T
+   }
+ 
+   interface UploadedUppyFile<TMeta, TBody> extends UppyFile<TMeta, TBody> {
+-    uploadURL: string;
++    uploadURL: string
+   }
+ 
+   interface FailedUppyFile<TMeta, TBody> extends UppyFile<TMeta, TBody> {
+-    error: string;
++    error: string
+   }
+ 
+   // Replace the `meta` property type with one that allows omitting internal metadata; addFile() will add that
+-  type UppyFileWithoutMeta<TMeta, TBody> = OmitKey<UppyFile<TMeta, TBody>, 'meta'>;
+-  interface AddFileOptions<TMeta = IndexedObject<any>, TBody = IndexedObject<any>> extends Partial<UppyFileWithoutMeta<TMeta, TBody>> {
++  type UppyFileWithoutMeta<TMeta, TBody> = OmitKey<
++    UppyFile<TMeta, TBody>,
++    'meta'
++  >
++  interface AddFileOptions<
++    TMeta = IndexedObject<any>,
++    TBody = IndexedObject<any>
++  > extends Partial<UppyFileWithoutMeta<TMeta, TBody>> {
+     // `.data` is the only required property here.
+-    data: Blob | File;
+-    meta?: Partial<InternalMetadata> & TMeta;
++    data: Blob | File
++    meta?: Partial<InternalMetadata> & TMeta
+   }
+ 
+   interface PluginOptions {
+-    id?: string;
++    id?: string
+   }
++  interface DefaultPluginOptions extends PluginOptions {
++    [prop: string]: any
++  }
++
++  type PluginTarget = string | Element | typeof Plugin
+ 
+-  class Plugin {
+-    id: string;
+-    uppy: Uppy;
+-    type: string;
+-    constructor(uppy: Uppy, opts?: PluginOptions);
+-    getPluginState(): object;
+-    setPluginState(update: any): object;
+-    update(state?: object): void;
+-    mount(target: any, plugin: any): void;
+-    render(state: object): void;
+-    addTarget(plugin: any): void;
+-    unmount(): void;
+-    install(): void;
+-    uninstall(): void;
++  class Plugin<TOptions extends PluginOptions = DefaultPluginOptions> {
++    id: string
++    uppy: Uppy
++    type: string
++    constructor(uppy: Uppy, opts?: TOptions)
++    getPluginState(): object
++    setPluginState(update: any): object
++    update(state?: object): void
++    mount(target: PluginTarget, plugin: typeof Plugin): void
++    render(state: object): void
++    addTarget(plugin: any): void
++    unmount(): void
++    install(): void
++    uninstall(): void
+   }
+ 
+   interface LocaleStrings {
+-    [key: string]: string | LocaleStrings;
++    [key: string]: string | LocaleStrings
+   }
+   interface Locale {
+-    strings: LocaleStrings;
+-    pluralize?: (n: number) => number;
++    strings: LocaleStrings
++    pluralize?: (n: number) => number
+   }
+ 
+   interface Restrictions {
+-    maxFileSize: number | null;
+-    maxNumberOfFiles: number | null;
+-    minNumberOfFiles: number | null;
+-    allowedFileTypes: string[] | null;
++    maxFileSize?: number | null
++    maxNumberOfFiles?: number | null
++    minNumberOfFiles?: number | null
++    allowedFileTypes?: string[] | null
+   }
+ 
+-  interface UppyOptions {
+-    id: string;
+-    autoProceed: boolean;
+-    allowMultipleUploads: boolean;
+-    debug: boolean;
+-    restrictions: Partial<Restrictions>;
+-    target: string | Plugin;
+-    meta: any;
+-    onBeforeFileAdded: (currentFile: UppyFile, files: {[key: string]: UppyFile}) => UppyFile | boolean | undefined;
+-    onBeforeUpload: (files: {[key: string]: UppyFile}) => {[key: string]: UppyFile} | boolean;
+-    locale: Locale;
+-    store: Store;
++  interface UppyOptions<TMeta extends IndexedObject<any> = {}> {
++    id?: string
++    autoProceed?: boolean
++    allowMultipleUploads?: boolean
++    debug?: boolean
++    restrictions?: Restrictions
++    meta?: TMeta
++    onBeforeFileAdded?: (
++      currentFile: UppyFile<TMeta>,
++      files: { [key: string]: UppyFile<TMeta> }
++    ) => UppyFile<TMeta> | boolean | undefined
++    onBeforeUpload?: (files: {
++      [key: string]: UppyFile<TMeta>
++    }) => { [key: string]: UppyFile<TMeta> } | boolean
++    locale?: Locale
++    store?: Store
+   }
+ 
+-  interface UploadResult<TMeta extends IndexedObject<any> = {}, TBody extends IndexedObject<any> = {}> {
+-    successful: UploadedUppyFile<TMeta, TBody>[];
+-    failed: FailedUppyFile<TMeta, TBody>[];
++  interface UploadResult<
++    TMeta extends IndexedObject<any> = {},
++    TBody extends IndexedObject<any> = {}
++  > {
++    successful: UploadedUppyFile<TMeta, TBody>[]
++    failed: FailedUppyFile<TMeta, TBody>[]
+   }
+ 
+-  interface State<TMeta extends IndexedObject<any> = {}, TBody extends IndexedObject<any> = {}> extends IndexedObject<any> {
+-    capabilities?: {resumableUploads?: boolean};
+-    currentUploads: {};
+-    error?: string;
+-    files: {[key: string]: UploadedUppyFile<TMeta, TBody> | FailedUppyFile<TMeta, TBody>};
++  interface State<
++    TMeta extends IndexedObject<any> = {},
++    TBody extends IndexedObject<any> = {}
++  > extends IndexedObject<any> {
++    capabilities?: { resumableUploads?: boolean }
++    currentUploads: {}
++    error?: string
++    files: {
++      [key: string]:
++        | UploadedUppyFile<TMeta, TBody>
++        | FailedUppyFile<TMeta, TBody>
++    }
+     info?: {
+-      isHidden: boolean;
+-      type: string;
+-      message: string;
+-      details: string;
+-    };
+-    plugins?: IndexedObject<any>;
+-    totalProgress: number;
++      isHidden: boolean
++      type: string
++      message: string
++      details: string
++    }
++    plugins?: IndexedObject<any>
++    totalProgress: number
+   }
+-  type LogLevel = 'info' | 'warning' | 'error';
+-  class Uppy {
+-    constructor(opts?: Partial<UppyOptions>);
+-    on<TMeta extends IndexedObject<any> = {}>(event: 'upload-success', callback: (file: UppyFile<TMeta>, body: any, uploadURL: string) => void): Uppy;
+-    on<TMeta extends IndexedObject<any> = {}>(event: 'complete', callback: (result: UploadResult<TMeta>) => void): Uppy;
+-    on(event: string, callback: (...args: any[]) => void): Uppy;
+-    off(event: string, callback: any): Uppy;
++
++  type LogLevel = 'info' | 'warning' | 'error'
++
++  /** Enable the old, untyped `uppy.use()` signature. */
++  type LooseTypes = 'loose'
++  /** Disable the old, untyped `uppy.use()` signature. */
++  type StrictTypes = 'strict'
++  type TypeChecking = LooseTypes | StrictTypes
++
++  class Uppy<TUseStrictTypes extends TypeChecking = TypeChecking> {
++    constructor(opts?: UppyOptions)
++    on<TMeta extends IndexedObject<any> = {}>(
++      event: 'upload-success',
++      callback: (file: UppyFile<TMeta>, body: any, uploadURL: string) => void
++    ): this
++    on<TMeta extends IndexedObject<any> = {}>(
++      event: 'complete',
++      callback: (result: UploadResult<TMeta>) => void
++    ): this
++    on(event: string, callback: (...args: any[]) => void): this
++    off(event: string, callback: any): this
+     /**
+      * For use by plugins only!
+      */
+-    emit(event: string, ...args: any[]): void;
+-    updateAll(state: object): void;
+-    setState(patch: object): void;
+-    getState<TMeta extends IndexedObject<any> = {}>(): State<TMeta>;
+-    readonly state: State;
+-    setFileState(fileID: string, state: object): void;
+-    resetProgress(): void;
+-    addPreProcessor(fn: any): void;
+-    removePreProcessor(fn: any): void;
+-    addPostProcessor(fn: any): void;
+-    removePostProcessor(fn: any): void;
+-    addUploader(fn: any): void;
+-    removeUploader(fn: any): void;
+-    setMeta<TMeta extends IndexedObject<any> = {}>(data: TMeta): void;
+-    setFileMeta<TMeta extends IndexedObject<any> = {}>(fileID: string, data: TMeta): void;
+-    getFile<TMeta extends IndexedObject<any> = {}, TBody extends IndexedObject<any> = {}>(fileID: string): UppyFile<TMeta, TBody>;
+-    getFiles<TMeta extends IndexedObject<any> = {}, TBody extends IndexedObject<any> = {}>(): Array<UppyFile<TMeta, TBody>>;
+-    addFile<TMeta extends IndexedObject<any> = {}>(file: AddFileOptions<TMeta>): void;
+-    removeFile(fileID: string): void;
+-    pauseResume(fileID: string): boolean;
+-    pauseAll(): void;
+-    resumeAll(): void;
+-    retryAll(): void;
+-    cancelAll(): void;
+-    retryUpload(fileID: string): any;
+-    reset(): void;
+-    getID(): string;
+-    use<T extends typeof Plugin>(pluginClass: T, opts: object): Uppy;
+-    getPlugin(name: string): Plugin;
+-    iteratePlugins(callback: (plugin: Plugin) => void): void;
+-    removePlugin(instance: Plugin): void;
+-    close(): void;
+-    info(message: string | {message: string; details: string}, type?: LogLevel, duration?: number): void;
+-    hideInfo(): void;
+-    log(msg: string, type?: LogLevel): void;
+-    run(): Uppy;
+-    restore<TMeta extends IndexedObject<any> = {}>(uploadID: string): Promise<UploadResult>;
+-    addResultData(uploadID: string, data: object): void;
+-    upload<TMeta extends IndexedObject<any> = {}>(): Promise<UploadResult>;
++    emit(event: string, ...args: any[]): void
++    updateAll(state: object): void
++    setState(patch: object): void
++    getState<TMeta extends IndexedObject<any> = {}>(): State<TMeta>
++    readonly state: State
++    setFileState(fileID: string, state: object): void
++    resetProgress(): void
++    addPreProcessor(fn: any): void",should `fn` be a function instead? Same for others below?,2019-12-09 13:01:55
+466,"@@ -1,16 +1,18 @@
+ {
++  ""name"": ""uppy-dev-example"",
++  ""aliasify"": {
++    ""aliases"": {
++      ""@uppy"": ""../../packages/@uppy""
++    }
++  },
+   ""dependencies"": {
+-    ""@babel/core"": ""^7.2.2"",
++    ""@babel/core"": ""^7.4.4"",
+     ""aliasify"": ""^2.1.0"",
+     ""babelify"": ""^10.0.0"",
+     ""watchify"": ""^3.11.0""
+   },
++  ""private"": true,
+   ""scripts"": {
+-    ""watch:sandbox"": ""watchify -t babelify -t aliasify main.js -o bundle.js -vd""
+-  },
+-  ""aliasify"": {
+-    ""aliases"": {
+-      ""@uppy"": ""../../packages/@uppy""
+-    }
++    ""watch:sandbox"": ""watchify -vd -t [ babelify --cwd ../../ ] -g aliasify main.js -o bundle.js""",:+1: But why did it work before? Something changed in that regard in Babel 7?,2019-05-20 09:54:14
+899,"@@ -1,169 +0,0 @@
+-const Provider = require('../Provider')",this is the legacy instagram module which is no longer used,2020-10-19 07:40:48
+596,"@@ -1,17 +1,19 @@
+-const webkitGetAsEntryApi = require('./utils/webkitGetAsEntryApi')
++const webkitGetAsEntryApi = require('./utils/webkitGetAsEntryApi/index')
+ const fallbackApi = require('./utils/fallbackApi')
+ 
+ /**
+  * Returns a promise that resolves to the array of dropped files (if a folder is dropped, and browser supports folder parsing - promise resolves to the flat array of all files in all directories).
+  * Each file has .relativePath prop appended to it (e.g. ""/docs/Prague/ticket_from_prague_to_ufa.pdf"") if browser supports it. Otherwise it's undefined.
+  *
+  * @param {DataTransfer} dataTransfer
++ * @param {Function} logDropError - a function that's called every time some folder or some file error out (e.g. because of the folder name being too long on Windows). Notice that resulting promise will always be resolved anyway.
++ *
+  * @returns {Promise} - Array<File>
+  */
+-module.exports = function getDroppedFiles (dataTransfer) {
++module.exports = function getDroppedFiles (dataTransfer, { logDropError = () => {} } = {}) {",`logDropError = ¯\_(ツ)_/¯`,2019-08-30 06:21:02
+546,"@@ -1,17 +1,70 @@
+ language: node_js
+-node_js:
+-- ""10.15.3""
++
++.hosts: &HOSTS
++  - companion.test
++.apt: &APT
++  sources:
++  - ubuntu-toolchain-r-test
++  packages:
++  - g++-4.8
++.sauce_connect: &SAUCE
++  username:
++    secure: nAMJ/d1fm9urTYsQ+1uqj6Jjf71J8rzwYBSZbTDAeUEZzAdvGc0a9H3PYWM4pnUDPo5s1c9MMetXi2XNdUbXgMKHbEnePZ2mJamqFtXMmpG8pgFmMqj+btMd7Yybt070tRsn4Vy0uBSi2H/en7F3j+grABJV+SAXqWkSB7CU1fZaN/u0DpoGBNj1ZNwkYCIhpLueYJTPRWBOodMAarXuFv5+7KFOKuZM3tF/JjsMNSSaDgTkz13BZnbX6vNPxGJJNJcyJGSaXrVW8hh1Zmvnk/XdiLy+vt7Wz1wz3A9ebiFDuydo5AAkxrLFsCJ5nGEqLg3bkr6NaTRpbM84ZT3i1FQMTdKP6OHHqwAeBscB6BkyhZhzvsFtl2YRBNK9mA3OtOYvBmTkFkNqvrPQlfu7cFtyG5+AUfSCiTTgS/vWIwoqSVAXaOEqN8Fp54ecUdkzCTttl3gXteZzNLRYvyQcFpoJb6E+dS8qAW0OFOteiwKVuPCh3nGUzBP13bRo1i9UAX7ZCTlpjinkxE8ryzbToo6ZcVQMBAkKhaw/x8GzOtfm5rgYMeQzGEoBJNfr7qqfs7JMxAIEMYjrTL9PXVOp/R8F3FdsqbV70jSyfsxMSMkwSWFRmVslG8+Djy8P3LnckGy1FEbMHnH8GZHZg+hbBzN8Be1/1fV0oRRAr939WRc=
++  access_key:
++    secure: OY3oWwiJghfty9wSPVvlhirvFGxPHDdIRuVkzAv6j7C/hj2BWYAP/UHrwdQ9XiYisHi/B5mGeyRVlrAf0MNGrG84rTDUbTWZbmktfuxl7A+Y6c0czk+s4SdhOiANG5b3tFl5wKq8h7uhrWH5/jWoKQ2Fz1VDCqxTvvZQbo41jSBhi7TBia626hxEePzdaiuw6HhGFZtfaoVs/FX30ylz8WDNrBjwCynjxsT52BaQrVvgEhuyzlOpI69YkZBPOq4fc3KiZ2YR43gLTx8K+sYCE9yJxdg1xT/UAawEhmedU83nyBZVo4rr7+03AixIxtI28MUCfBMlcsGwBxcKEKY/IWcp9UkPCq6+zALQoncV478tP21eYvlmxSFhYCrv+WEQlN+BcNjr4OJlmmFDbCVaF7r9qLeQPImU0+9iJU3OjrW7lpfLxORpGDEr2Nx6awKkIJCxNyK9weefeNo6Fz3V1kkyZ/7yWFeniJnRUCbahrB2XgzxIE+W307s1Qs4fm6JK7hVLTtG4fBzjChmAyGIzu744ws9WqmjvkC9D7OfnuXqanv/VcBFqPiudInerv7NL8FketUC+fxe/7XJfcxdaDGBjk8Kq7zXDohGRGymUXEoMDNJsKkMMlaKzdf7tgqdhsRJoH9NCVqrDXuG5al0UtrDP5RS7qfoxUunJmNFhlg=
++  no_ssl_bump_domains: companion.test
++
++matrix:
++  include:
++    - node_js: 'stable'
++      env: UNIT=true
++      addons:
++        apt: *APT
++    - node_js: 10
++      env: UNIT=true
++      addons:
++        apt: *APT
++    - node_js: 10
++      env: LINT=true
++      addons:
++        apt: *APT
++    - node_js: 10
++      env: BUILD=true
++      addons:
++        apt: *APT
++    - node_js: 10
++      env: COMPANION=true
++      addons:
++        apt: *APT
++    # Build the website when things are merged to master
++    - node_js: 10
++      env: WEBSITE=true
++      if: branch = master AND type = push
++      addons:
++        apt: *APT
++    # Run e2e tests on branch builds, not PRs
++    - node_js: 10
++      env: ENDTOEND=true
++      if: type = push
++      addons:
++        hosts: *HOSTS
++        apt: *APT
++        sauce_connect: *SAUCE
+ before_install:
+ - nvm install-latest-npm
+ install:
+ - npm install
+ - npm run bootstrap -- --no-ci
+ script:
+-- npm run build
+-- npm run test
+-- if [ ""${TRAVIS_PULL_REQUEST}"" = ""false"" ]; then npm run test:endtoend; fi
++- 'if [ -n ""${LINT-}"" ]; then npm run lint; fi'
++- 'if [ -n ""${LINT-}"" ]; then npm run test:type; fi'
++- 'if [ -n ""${WEBSITE-}"" ]; then npm run web:install; fi'
++- 'if [ -n ""${UNIT-}"" ]; then npm run test:unit; fi'
++- 'if [ -n ""${COMPANION-}"" ]; then npm run test:companion; fi'
++- 'if [ -n ""${ENDTOEND-}"" ] && [ ""${TRAVIS_PULL_REQUEST}"" = ""false"" ]; then npm run test:endtoend; fi'
++- 'if [ -n ""${BUILD-}"" ]; then npm run build; fi'
+ - |
+-  if [ ""${TRAVIS_PULL_REQUEST}"" = ""false"" ] &&\
++  if [ -n ""${BUILD-}"" ] && [ ""${TRAVIS_PULL_REQUEST}"" = ""false"" ] &&\",Perhaps :- for travis pull request too?,2019-07-08 17:17:48
+399,"@@ -1,20 +1,22 @@
+ <%
+ var categories = [
+   // order: 1x
+-  { path: 'docs/plugins/', name: 'Plugins', link: true },
++  { path: 'docs/robodog/', name: 'Robodog', link: true },","Robodog too high is the sidebar, maybe?",2019-01-31 13:29:40
+654,"@@ -1,21 +1,17 @@
+-import Uppy = require('@uppy/core');
+-import CompanionClient = require('@uppy/companion-client');
++import Uppy = require('@uppy/core')
++import CompanionClient = require('@uppy/companion-client')
+ 
+ declare module Dropbox {
+-  interface DropboxOptions extends Uppy.PluginOptions, CompanionClient.ProviderOptions {
+-    companionUrl: string;
+-    companionAllowedHosts: string | RegExp | Array<string | RegExp>;
++  interface DropboxOptions
++    extends Uppy.PluginOptions,
++      CompanionClient.RequestClientOptions {",why not `CompanionClient.ProviderOptions `? 🤔 ,2019-12-09 13:15:44
+653,"@@ -1,21 +1,17 @@
+-import Uppy = require('@uppy/core');
+-import CompanionClient = require('@uppy/companion-client');
++import Uppy = require('@uppy/core')
++import CompanionClient = require('@uppy/companion-client')
+ 
+ declare module Dropbox {
+-  interface DropboxOptions extends Uppy.PluginOptions, CompanionClient.ProviderOptions {
+-    companionUrl: string;
+-    companionAllowedHosts: string | RegExp | Array<string | RegExp>;
++  interface DropboxOptions
++    extends Uppy.PluginOptions,
++      CompanionClient.RequestClientOptions {
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    companionUrl: string
++    companionAllowedHosts?: string | RegExp | Array<string | RegExp>","```suggestion
+    companionAllowedHosts?: string | RegExp | Array<string | RegExp>
+    title?: string
+    storage?: CompanionClient.TokenStorage
+```",2019-12-09 13:14:34
+656,"@@ -1,21 +1,17 @@
+-import Uppy = require('@uppy/core');
+-import CompanionClient = require('@uppy/companion-client');
++import Uppy = require('@uppy/core')
++import CompanionClient = require('@uppy/companion-client')
+ 
+ declare module Facebook {
+-  interface FacebookOptions extends Uppy.PluginOptions, CompanionClient.ProviderOptions {
+-    companionUrl: string;
+-    companionAllowedHosts: string | RegExp | Array<string | RegExp>;
++  interface FacebookOptions
++    extends Uppy.PluginOptions,
++      CompanionClient.RequestClientOptions {
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    companionUrl: string
++    companionAllowedHosts?: string | RegExp | Array<string | RegExp>","```suggestion
+    companionAllowedHosts?: string | RegExp | Array<string | RegExp>
+    title?: string
+    storage?: CompanionClient.TokenStorage
+```",2019-12-09 13:36:32
+658,"@@ -1,21 +1,17 @@
+-import Uppy = require('@uppy/core');
+-import CompanionClient = require('@uppy/companion-client');
++import Uppy = require('@uppy/core')
++import CompanionClient = require('@uppy/companion-client')
+ 
+ declare module GoogleDrive {
+-  interface GoogleDriveOptions extends Uppy.PluginOptions, CompanionClient.ProviderOptions {
+-    companionUrl: string;
+-    companionAllowedHosts: string | RegExp | Array<string | RegExp>;
++  interface GoogleDriveOptions
++    extends Uppy.PluginOptions,
++      CompanionClient.RequestClientOptions {
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    companionUrl: string
++    companionAllowedHosts?: string | RegExp | Array<string | RegExp>",same suggestion as dropbox provider,2019-12-09 13:43:12
+660,"@@ -1,21 +1,17 @@
+-import Uppy = require('@uppy/core');
+-import CompanionClient = require('@uppy/companion-client');
++import Uppy = require('@uppy/core')
++import CompanionClient = require('@uppy/companion-client')
+ 
+ declare module Instagram {
+-  interface InstagramOptions extends Uppy.PluginOptions, CompanionClient.ProviderOptions {
+-    companionUrl: string;
+-    companionAllowedHosts: string | RegExp | Array<string | RegExp>;
++  interface InstagramOptions
++    extends Uppy.PluginOptions,
++      CompanionClient.RequestClientOptions {
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    companionUrl: string
++    companionAllowedHosts?: string | RegExp | Array<string | RegExp>",same suggestion as previous providers,2019-12-09 13:46:23
+661,"@@ -1,21 +1,17 @@
+-import Uppy = require('@uppy/core');
+-import CompanionClient = require('@uppy/companion-client');
++import Uppy = require('@uppy/core')
++import CompanionClient = require('@uppy/companion-client')
+ 
+ declare module OneDrive {
+-  interface OneDriveOptions extends Uppy.PluginOptions, CompanionClient.ProviderOptions {
+-    companionUrl: string;
+-    companionAllowedHosts: string | RegExp | Array<string | RegExp>;
++  interface OneDriveOptions
++    extends Uppy.PluginOptions,
++      CompanionClient.RequestClientOptions {
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    companionUrl: string
++    companionAllowedHosts?: string | RegExp | Array<string | RegExp>",same suggestion as previous providers,2019-12-09 13:46:35
+0,"@@ -1,22 +0,0 @@
+-The MIT License (MIT)","License can remain MIT
+",2015-11-17 09:07:46
+652,"@@ -1,23 +1,17 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
+ 
+ declare module DragDrop {
+   interface DragDropOptions extends Uppy.PluginOptions {
+-    inputName: string;
+-    allowMultipleFiles: boolean;
+-    width: string;
+-    height: string;
+-    note: string;
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    inputName?: string
++    allowMultipleFiles?: boolean
++    width?: string
++    height?: string
++    note?: string",should this also include `locale`?,2019-12-09 13:08:13
+657,"@@ -1,23 +1,17 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
+ 
+ declare module Form {
+   interface FormOptions extends Uppy.PluginOptions {
+-    getMetaFromForm: boolean;
+-    addResultToForm: boolean;
+-    submitOnSuccess: boolean;
+-    triggerUploadOnSubmit: boolean;
+-    resultName: string;
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    getMetaFromForm?: boolean
++    addResultToForm?: boolean
++    submitOnSuccess?: boolean
++    triggerUploadOnSubmit?: boolean
++    resultName?: string",what about `multipleResults`?,2019-12-09 13:40:43
+663,"@@ -1,24 +1,16 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
+ 
+ declare module Tus {
+   export interface TusOptions extends Uppy.PluginOptions {",should we also extend type options from the `tus-js-client`? 🤔If it's available in its type declarations i.e,2019-12-09 13:55:37
+171,"@@ -1,25 +1,48 @@
+-const html = require('yo-yo')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
+ const cuid = require('cuid')
+ 
+ module.exports = (props) => {
+-  // const classes = props.active ? 'BrowserTable-row is-active' : 'BrowserTable-row'
+   const uniqueId = cuid()
+ 
++  const checkboxSelect = (ev) => {
++    if (ev.keyCode === 13) {
++      ev.stopPropagation()
++      ev.preventDefault()
++    }
++  }
++
++  const handleItemClick = (ev) => {
++    // when file is clicked, select it, but when folder is clicked, open it
++    if (props.type === 'folder') {
++      return props.handleClick()
++    }
++    props.handleCheckboxClick(ev)
++  }","nice additions! minor point, should `checkboxSelect` be `handleCheckboxSelect` for consistency? i'm not sure if we follow that convention anywhere else, might be useful to do so though to identify event handlers.",2017-12-13 21:43:42
+659,"@@ -1,26 +1,18 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
+ 
+ declare module Informer {
+   interface Color {
+-    bg: string | number;
+-    text: string | number;
++    bg: string | number
++    text: string | number
+   }
+ 
+   interface InformerOptions extends Uppy.PluginOptions {
+-    typeColors: {
+-      [type: string]: Color
+-    };
++    replaceTargetContent?: boolean
++    target?: Uppy.PluginTarget
++    typeColors?: { [type: string]: Color }",I don't see this property used anywhere in the plugin 🤔 ,2019-12-09 13:45:57
+371,"@@ -1,28 +1,32 @@
+ import { Plugin, PluginOptions, Uppy, UppyFile } from '@uppy/core';
+ 
+-export interface AwsS3Part {
+-  PartNumber: number;
+-  Size: number;
+-  ETag: string;
+-}
++declare module AwsS3Multipart {
++    interface AwsS3Part {
++        PartNumber?: number;
++        Size?: number;
++        ETag?: string;
++    }
+ 
+-export interface AwsS3MultipartOptions extends PluginOptions {
+-  serverUrl: string;
+-  createMultipartUpload(file: UppyFile): Promise<{uploadId: string, key: string}>;
+-  listParts(file: UppyFile, opts: {uploadId: string, key: string}): Promise<AwsS3Part>;
+-  prepareUploadPart(file: UppyFile, partData: {uploadId: string, key: string, body: Blob, number: number}): Promise<{url: string}>;
+-  abortMultipartUpload(file: UppyFile, opts: {uploadId: string, key: string}): Promise<void>;
+-  completeMultipartUpload(file: UppyFile, opts: {uploadId: string, key: string, parts: AwsS3Part[]}): Promise<{location?: string}>;
+-  timeout: number;
+-  limit: number;
++    interface AwsS3MultipartOptions extends PluginOptions {
++        serverUrl: string;
++        createMultipartUpload(file: UppyFile): Promise<{ uploadId: string, key: string }>;
++        listParts(file: UppyFile, opts: { uploadId: string, key: string }): Promise<AwsS3Part[]>;
++        prepareUploadPart(file: UppyFile, partData: { uploadId: string, key: string, body: Blob, number: number }): Promise<{ url: string }>;
++        abortMultipartUpload(file: UppyFile, opts: { uploadId: string, key: string }): Promise<void>;
++        completeMultipartUpload(file: UppyFile, opts: { uploadId: string, key: string, parts: AwsS3Part[] }): Promise<{ location?: string }>;
++        timeout: number;
++        limit: number;
++    }
+ }
+ 
+-export default class AwsS3Multipart extends Plugin {
+-  constructor(uppy: Uppy, opts: Partial<AwsS3MultipartOptions>);
++declare class AwsS3Multipart extends Plugin {
++    constructor(uppy: Uppy, opts: Partial<AwsS3Multipart.AwsS3MultipartOptions>);
+ }
+ 
++export = AwsS3Multipart;
++
+ declare module '@uppy/core' {
+-  export interface Uppy {
+-    use(pluginClass: typeof AwsS3Multipart, opts: Partial<AwsS3MultipartOptions>): Uppy;
+-  }
++    export interface Uppy {
++        use(pluginClass: typeof AwsS3Multipart, opts: Partial<AwsS3Multipart.AwsS3MultipartOptions>): Uppy;
++    }",please keep the 2-space indents,2018-11-08 13:45:45
+729,"@@ -1,3 +1,17 @@
++/**
++ * Array.prototype.findIndex ponyfill for old browsers.",*polyfill?,2020-04-02 14:53:15
+309,"@@ -1,3 +1,23 @@
++<%
++var categories = [
++  // order: 1x
++  { path: 'docs/plugins/', name: 'Plugins', link: true },
++  // order: 2x
++  { path: 'docs/dashboard/', name: 'Local Sources', link: false },
++  // order: 3x
++  { path: 'docs/providers/', name: 'Remote Providers', link: true },
++  // order: 4x
++  { path: 'docs/tus/', name: 'Uploaders', link: false },
++  // order: 5x
++  { path: 'docs/status-bar/', name: 'UI Elements', link: false },
++  // order: 6x
++  { path: 'docs/transloadit/', name: 'File Processing', link: false },
++  // order: 7x
++  { path: 'docs/form/', name: 'Miscellaneous', link: false },
++  // order: 8x
++  { path: 'docs/react/', name: 'React Components', link: true },",Reserved 10 items for each section … should maybe extract this to a json or yaml file like doc-order.json is.,2018-07-05 13:32:21
+850,"@@ -1,3 +1,4 @@
++require('whatwg-fetch')","hey @goto-bus-stop I'm not sure about this part, but does it look good to you?",2020-07-21 11:42:45
+649,"@@ -1,32 +1,42 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
++
++type MaybePromise<T> = T | Promise<T>
+ 
+ declare module AwsS3Multipart {
+   interface AwsS3Part {
+-    PartNumber?: number;
+-    Size?: number;
+-    ETag?: string;
++    PartNumber?: number
++    Size?: number","looking through the code, it seems `Size` is never present in an `AwsS3Part` object 🤔",2019-12-04 09:46:25
+648,"@@ -1,32 +1,42 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
++
++type MaybePromise<T> = T | Promise<T>
+ 
+ declare module AwsS3Multipart {
+   interface AwsS3Part {
+-    PartNumber?: number;
+-    Size?: number;
+-    ETag?: string;
++    PartNumber?: number
++    Size?: number
++    ETag?: string
+   }
+ 
+   interface AwsS3MultipartOptions extends Uppy.PluginOptions {
+-    companionUrl: string;
+-    createMultipartUpload(file: Uppy.UppyFile): Promise<{ uploadId: string, key: string }>;
+-    listParts(file: Uppy.UppyFile, opts: { uploadId: string, key: string }): Promise<AwsS3Part[]>;
+-    prepareUploadPart(file: Uppy.UppyFile, partData: { uploadId: string, key: string, body: Blob, number: number }): Promise<{ url: string }>;
+-    abortMultipartUpload(file: Uppy.UppyFile, opts: { uploadId: string, key: string }): Promise<void>;
+-    completeMultipartUpload(file: Uppy.UppyFile, opts: { uploadId: string, key: string, parts: AwsS3Part[] }): Promise<{ location?: string }>;
+-    timeout: number;
+-    limit: number;
++    companionUrl?: string
++    createMultipartUpload?: (",TIL that you can create `partial functions` with `bind` like this https://github.com/transloadit/uppy/blob/ad80911ed3efa9ab40b0edb938633bd97298be9f/packages/%40uppy/aws-s3-multipart/src/index.js#L199,2019-12-04 09:31:12
+110,"@@ -1,33 +1,34 @@
+-# Uppy
++# [Uppy](http://uppy.io)
+ 
+-<img src=""http://uppy.io/images/logos/uppy-dog-full.svg"" width=""120"" alt=""Uppy logo — a superman puppy in a pink suit"" align=""right"">
++<img src=""http://uppy.io/images/logos/uppy-dog-head-arrow.svg"" width=""120"" alt=""Uppy logo — a superman puppy in a pink suit"" align=""right"">
+ 
+-<a href=""https://www.npmjs.com/package/uppy""><img src=""https://img.shields.io/badge/stability-experimental-orange.svg?style=flat-square""></a>
+ <a href=""https://www.npmjs.com/package/uppy""><img src=""https://img.shields.io/npm/v/uppy.svg?style=flat-square""></a>
+ <a href=""https://travis-ci.org/transloadit/uppy""><img src=""https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square"" alt=""Build Status""></a>
++<a href=""https://www.npmjs.com/package/uppy""><img src=""https://img.shields.io/badge/stability-experimental-orange.svg?style=flat-square""></a>
+ 
+-Uppy is a sleek, modular file uploader that integrates seemlessly with any framework. It fetches files from local disk, Google Drive, Dropbox, Instagram, remote URLs, cameras and other exciting locations, and then uploads them to the final destination. It’s fast, easy to use and let's you worry about more important problems than building a file uploader. [Try it live](http://uppy.io/examples/dashboard/).
++Uppy is a sleek, modular file uploader that integrates seemlessly with any application. It’s fast, easy to use and lets you worry about more important problems than building a file uploader.
+ 
+-Uppy is developed by the [Transloadit](https://transloadit.com) team.
++- **Fetch** files from local disk, Google Drive, Dropbox, Instagram, or take selfies and videos with a camera;
++- **Preview** and edit metadata with a nice interface;
++- **Upload** to the final destination, optionally processing/encoding on the way;
+ 
+-Check out docs and examples on [uppy.io](http://uppy.io).
++**[Try Uppy](http://uppy.io/examples/dashboard/)** | **[Read the docs](http://uppy.io/docs)**
+ 
+ <img width=""700"" alt=""Uppy UI Demo: modal dialog with a few selected files and an upload button"" src=""https://github.com/transloadit/uppy/raw/master/uppy-screenshot.jpg"">
+ 
+-- [Full featured UI](http://uppy.io/examples/dashboard)
+-- [Simple Drag & Drop](http://uppy.io/examples/dragdrop)
++Uppy is being developed by the [Transloadit](https://transloadit.com) team.
+ 
+ ## Features
+ 
+ - Lightweight, modular plugin-based architecture, easy on dependencies :zap:
+-- Use from a CDN or as a module to import",Is this no longer a goal? 😱 or just not something to advertise on the intro page?,2017-09-20 08:37:30
+909,"@@ -1,4 +1,4 @@
+-const { h, Component } = require('preact')
++const { Component } = require('preact')","Just FYI, I had to remove this unused import because Travis/`npm run lint` were complaining.",2020-10-29 13:04:48
+166,"@@ -1,4 +1,8 @@
+-const html = require('yo-yo')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl",this might interfere when we have multiple dashboards. maybe ActionBrowseTagline needs to be a Component so we can store the reference to the element on it.,2017-12-13 21:36:19
+662,"@@ -1,40 +1,39 @@
+-import Uppy = require('@uppy/core');
++import Uppy = require('@uppy/core')
+ 
+ declare module Transloadit {
+   interface AssemblyParameters {
+-    auth: { key: string };
+-    template_id?: string;
+-    steps?: { [step: string]: object };
+-    notify_url?: string;
+-    fields?: { [name: string]: number | string };
++    auth: { key: string }
++    template_id?: string
++    steps?: { [step: string]: object }
++    notify_url?: string
++    fields?: { [name: string]: number | string }
+   }
+ 
+   interface AssemblyOptions {
+-    params: AssemblyParameters;
+-    fields?: { [name: string]: number | string };
+-    signature?: string;
++    params: AssemblyParameters
++    fields?: { [name: string]: number | string }
++    signature?: string
+   }
+ 
+-  interface TransloaditOptions extends Uppy.PluginOptions {
+-    params: AssemblyParameters;
+-    signature: string;
+-    service: string;
+-    waitForEncoding: boolean;
+-    waitForMetadata: boolean;
+-    importFromUploadURLs: boolean;
+-    alwaysRunAssembly: boolean;
+-    getAssemblyOptions: (file: Uppy.UppyFile) => AssemblyOptions | Promise<AssemblyOptions>;
++  interface TransloaditOptionsBase extends Uppy.PluginOptions {
++    service?: string
++    waitForEncoding?: boolean
++    waitForMetadata?: boolean
++    importFromUploadURLs?: boolean
++    alwaysRunAssembly?: boolean",how about `errorReporting` and `limit`? 🤔 ,2019-12-09 13:53:02
+173,"@@ -1,45 +1,49 @@
+-const html = require('yo-yo')
++const { h, Component } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
+ const SnapshotButton = require('./SnapshotButton')
+ const RecordButton = require('./RecordButton')
+ 
+ function isModeAvailable (modes, mode) {
+   return modes.indexOf(mode) !== -1
+ }
+ 
+-module.exports = (props) => {
+-  const src = props.src || ''
+-  let video
+-
+-  if (props.useTheFlash) {
+-    video = props.getSWFHTML()",😱 i coulda sworn i removed that! thanks for cleaning up 🙏 ,2017-12-13 21:45:40
+655,"@@ -1,48 +1,48 @@
+ export interface RequestClientOptions {
+-  companionUrl: string;
+-  companionHeaders?: object;
++  companionUrl: string
++  companionHeaders?: object
+   /**
+    * Deprecated, use `companionHeaders` instead.
+    */
+-  serverHeaders?: object;
++  serverHeaders?: object
+ }
+ ","we should also add token Storage interface like so 
+
+```typescript
+export interface TokenStorage {
+  setItem: (key: string, value: string) => Promise<any> // or <void> not sure
+  getItem: (key: string) => Promise<string>
+  removeItem: (key: string) => Promise<any> // or <void> not sure
+}
+```
+
+it will be used in `packages/@uppy/dropbox/types/index.d.ts` and other providers",2019-12-09 13:26:28
+650,"@@ -1,48 +1,48 @@
+ export interface RequestClientOptions {
+-  companionUrl: string;
+-  companionHeaders?: object;
++  companionUrl: string
++  companionHeaders?: object
+   /**
+    * Deprecated, use `companionHeaders` instead.
+    */
+-  serverHeaders?: object;
++  serverHeaders?: object
+ }
+ 
+ export class RequestClient {
+-  constructor (uppy: any, opts: RequestClientOptions);
+-  get (path: string): Promise<any>;
+-  post (path: string, data: object): Promise<any>;
+-  delete (path: string, data: object): Promise<any>;
++  constructor (uppy: any, opts: RequestClientOptions)
++  get (path: string): Promise<any>
++  post (path: string, data: object): Promise<any>
++  delete (path: string, data: object): Promise<any>
+ }
+ 
+ export interface ProviderOptions extends RequestClientOptions {
+-  provider: string;
+-  authProvider?: string;
+-  name?: string;
++  provider: string
++  authProvider?: string
++  name?: string","```suggestion
+  name?: string
+  pluginId: string
+```",2019-12-09 12:47:06
+672,"@@ -1,48 +1,71 @@
++/**
++ * Async storage interface, similar to `localStorage`. This can be used to
++ * implement custom storages for authentication tokens.
++ */
++export interface TokenStorage {
++  setItem: (key: string, value: string) => Promise<void>
++  getItem: (key: string) => Promise<string>
++  removeItem: (key: string) => Promise<void>
++}
++
+ export interface RequestClientOptions {
+-  companionUrl: string;
+-  companionHeaders?: object;
++  companionUrl: string
++  companionHeaders?: object
+   /**
+    * Deprecated, use `companionHeaders` instead.
+    */
+-  serverHeaders?: object;
++  serverHeaders?: object
+ }
+ 
+ export class RequestClient {
+-  constructor (uppy: any, opts: RequestClientOptions);
+-  get (path: string): Promise<any>;
+-  post (path: string, data: object): Promise<any>;
+-  delete (path: string, data: object): Promise<any>;
++  constructor (uppy: any, opts: RequestClientOptions)
++  get (path: string): Promise<any>
++  post (path: string, data: object): Promise<any>
++  delete (path: string, data: object): Promise<any>
+ }
+ 
+-export interface ProviderOptions extends RequestClientOptions {
+-  provider: string;
+-  authProvider?: string;
+-  name?: string;
++/**
++ * Options for Providers that can be passed in by Uppy users through
++ * Plugin constructors.
++ */
++export interface PublicProviderOptions extends RequestClientOptions {
++  companionAllowedHosts?: string | RegExp | Array<string | RegExp>
++  storage?: TokenStorage","apologies for the mix up here 🙈, but based on [this PR](https://github.com/transloadit/uppy/pull/2046/files) which I submitted recently, it became apparent that the `storage` option is only supplied to the provider plugins themselves (i.e Dropbox, Instagram, etc.). A fallback is set for the provider plugins [like so](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion-client/src/Provider.js#L99). It is then used by `companion-client/Provider` class [like so](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion-client/src/Provider.js#L42). 
+
+In essence, what I think we need to do is remove this line ☝️ and then add the field [here](https://github.com/transloadit/uppy/pull/1918/files#diff-8c1b43bfbf1e79e2aab309c4f195090dR10) (same for Instagram, OneDrive, etc.). Apologies for the mx up once again",2020-02-03 10:34:28
+751,"@@ -1,5 +1,19 @@
+ const chalk = require('chalk')
+ 
++const valuesToMask = []
++/**
++ * Adds a list of strings that should be masked by the logger.
++ * This function can only be called once through out the life of the server.
++ * @param {Array} maskables a list of strings to be masked
++ */
++exports.addMaskables = (maskables) => {","If it can only be called once, perhaps a more appropriate name is something like `setMaskables`? `addX` sounds like you can add many `X`es by calling it many times",2020-04-22 08:01:10
+981,"@@ -1,5 +1,4 @@
+ #!/usr/bin/env node
+-'use strict'","hmm, we actually should _add_ `'use strict'` everywhere 🤔 ",2021-03-10 08:18:10
+601,"@@ -1,5 +1,5 @@
+ ---
+-title: ""List of Plugins""","I think we mostly use double quotes in YAML, actually, and single quotes around “category” everywhere are a mistake.",2019-10-09 12:36:29
+632,"@@ -1,5 +1,6 @@
+ const express = require('express')
+ const qs = require('querystring')
++const URL = require('url').URL","the `""engines""` field in package.json says companion supports Node.js 6.0 and up, but the `URL` class was added in 6.13.0. I think we should drop support for Node 6 but until then, perhaps we could use the old `url.parse` and `url.format` APIs, or add a fallback to use the [`whatwg-url`](https://www.npmjs.com/package/whatwg-url) package?",2019-11-22 09:43:50
+975,"@@ -1,5 +1,6 @@
+ const tokenService = require('./helpers/jwt')
+ const logger = require('./logger')
++const uniq = require('lodash/uniq')","`lodash` is not a dependency of Companion yet, it just happens to be available in the repository due to hoisted dependencies. it should be added to its package.json.",2021-02-08 11:58:02
+168,"@@ -1,6 +1,10 @@
+-const html = require('yo-yo')
+ const ActionBrowseTagline = require('./ActionBrowseTagline')
+ const { localIcon } = require('./icons')
++const { h } = require('preact')
++const hyperx = require('hyperx')
++const html = hyperx(h)
++
++let inputEl",same deal about the global state maybe interfering as in ActionBrowseTagline,2017-12-13 21:38:29
+132,"@@ -1,6 +1,16 @@
+ const { iconText, iconAudio, iconVideo, iconPDF } = require('./icons')
+ 
+-module.exports = function getIconByMime (fileTypeGeneral, fileTypeSpecific) {
++module.exports = function getIconByMime (fileType) {
++  const defaultChoise = {",very minor but `Choise` → `Choice`,2017-10-26 09:14:18
+270,"@@ -1,6 +1,28 @@
+ const preact = require('preact')
+ const { findDOMElement } = require('../core/Utils')
+ 
++/**
++ * Defer a frequent call to the microtask queue.
++ */
++function debounce (fn) {
++  let calling = null
++  let latestArgs = null
++  return (...args) => {
++    latestArgs = args
++    if (!calling) {
++      calling = Promise.resolve().then(() => {
++        calling = null
++        // At this point `args` may be different from the most
++        // recent state, if multiple calls happened since this task
++        // was queued. So we use the `latestArgs`, which definitely
++        // is the most recent call.
++        return fn(...latestArgs)
++      })
++    }
++    return calling
++  }
++}
++",Would it make sense to use lodash’s debounce here or this is different?,2018-05-14 16:36:12
+49,"@@ -1,6 +1,5 @@
+ const Uppy = require('uppy/lib/core')
+ const Dashboard = require('uppy/lib/plugins/Dashboard')
+-const StatusBar = require('uppy/lib/plugins/StatusBar')",The `use(Informer)` call should also be removed from this file,2017-06-16 12:02:48
+308,"@@ -1,6 +1,6 @@
+-\----		
+-type: docs		
+-order: 30	
++\----
++type: docs
++order: 99",prolly should get rid of this?,2018-07-05 13:31:25
+414,"@@ -1,6 +1,7 @@
+ 'use strict'
+ 
+ const RequestClient = require('./RequestClient')
++const tokenStorage = require('./token-storage')",Most of the other Uppy client file names use camel case `tokenStorage.js` (see eg. @uppy/utils),2019-03-25 13:00:55
+240,"@@ -1,6 +1,8 @@
+ const Plugin = require('../core/Plugin')
+ const { findDOMElement } = require('../core/Utils')
+-const getFormData = require('get-form-data').default
++// Rollup uses get-form-data's ES modules build, and rollup-plugin-commonjs automatically resolves `.default`.
++// So, if we are being built using rollup, this require() won't have a `.default` property.
++const getFormData = require('get-form-data').default || require('get-form-data')
+ ","Oh wow, that’s one complicated require :)",2018-03-12 17:07:54
+394,"@@ -1,7 +1,7 @@
+ <%
+ var categories = [
+   // order: 1x
+-  { path: 'docs/transloadit-wrapper/', name: 'Transloadit Wrapper', link: true },
++  { path: 'docs/robodog/', name: 'Robodog', link: true },",:robot: :dog: :heart_eyes:  ,2019-01-28 16:40:35
+344,"@@ -1,7 +1,7 @@
+ {
+   ""name"": ""@uppy/companion"",
+   ""version"": ""0.14.2"",
+-  ""description"": ""Server component for Uppy's (https://uppy.io) extensible file upload widget with support for drag&drop, resumable uploads, previews, restrictions, file processing/encoding, remote providers like Dropbox and Google Drive, S3 and more :dog:"",
++  ""description"": ""OAuth helper and remote fetcher for Uppy's (https://uppy.io) extensible file upload widget with support for drag&drop, resumable uploads, previews, restrictions, file processing/encoding, remote providers like Dropbox and Google Drive, S3 and more :dog:"",",":+1: 
+",2018-09-03 11:56:43
+637,"@@ -1,76 +1,89 @@
+-const { h } = require('preact')
++const { h, Component } = require('preact')
+ const classNames = require('classnames')
+-const pure = require('../../utils/pure')
++const shallowEqual = require('is-shallow-equal')
+ const FilePreviewAndLink = require('./FilePreviewAndLink')
+ const FileProgress = require('./FileProgress')
+ const FileInfo = require('./FileInfo')
+ const Buttons = require('./Buttons')
+ 
+-module.exports = pure(function FileItem (props) {
+-  const file = props.file
++module.exports = class FileItem extends Component {
++  shouldComponentUpdate (nextProps) {
++    return !shallowEqual(this.props, nextProps)","Same than `pure`, but a 3-rd party module?",2019-11-26 16:23:44
+643,"@@ -1,76 +1,89 @@
+-const { h } = require('preact')
++const { h, Component } = require('preact')
+ const classNames = require('classnames')
+-const pure = require('../../utils/pure')
++const shallowEqual = require('is-shallow-equal')
+ const FilePreviewAndLink = require('./FilePreviewAndLink')
+ const FileProgress = require('./FileProgress')
+ const FileInfo = require('./FileInfo')
+ const Buttons = require('./Buttons')
+ 
+-module.exports = pure(function FileItem (props) {
+-  const file = props.file
++module.exports = class FileItem extends Component {
++  shouldComponentUpdate (nextProps) {
++    return !shallowEqual(this.props, nextProps)
++  }
+ 
+-  const isProcessing = file.progress.preprocess || file.progress.postprocess
+-  const isUploaded = file.progress.uploadComplete && !isProcessing && !file.error
+-  const uploadInProgressOrComplete = file.progress.uploadStarted || isProcessing
+-  const uploadInProgress = (file.progress.uploadStarted && !file.progress.uploadComplete) || isProcessing
+-  const isPaused = file.isPaused || false
+-  const error = file.error || false
++  componentDidMount () {
++    const file = this.props.file
++    if (!file.preview && this.props.handleRequestThumbnail) {","Why do we need `&& this.props.handleRequestThumbnail` conditional, isn't it always defined?",2019-12-01 14:49:49
+159,"@@ -1,8 +1,8 @@
+-import Plugin from '../../src/plugins/Plugin.js'
++import Plugin from '../../src/core/Plugin.js'",maybe remove the .js from the import path like in the rest of the codebase?,2017-12-09 16:18:45
+406,"@@ -1,80 +1,30 @@
+-# @uppy/transloadit
++# @uppy/robodog
+ 
+ <img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" width=""120"" alt=""Uppy logo: a superman puppy in a pink suit"" align=""right"">
+ 
+-<a href=""https://www.npmjs.com/package/@uppy/transloadit""><img src=""https://img.shields.io/npm/v/@uppy/transloadit.svg?style=flat-square""></a>
++<a href=""https://www.npmjs.com/package/@uppy/robodog""><img src=""https://img.shields.io/npm/v/@uppy/robodog.svg?style=flat-square""></a>
+ <a href=""https://travis-ci.org/transloadit/uppy""><img src=""https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square"" alt=""Build Status""></a>
+ 
+-The Transloadit plugin can be used to upload files to Transloadit for all kinds of processing, such as transcoding video, resizing images, zipping/unzipping, [and more](https://transloadit.com/services/).
+-
+-[Try it live →](https://uppy.io/examples/transloadit/)
+-
+-Uppy is being developed by the folks at [Transloadit](https://transloadit.com), a versatile file encoding service.
+-
+-## Example
+-
+-`transloadit.form` attaches Transloadit to an existing HTML form.
+-It could act like the jQuery SDK using the `@uppy/file-input` plugin,
+-or it could also add the `@uppy/dashboard`.
+-Uploads files on form submission, adds results to a hidden input,
+-then really submits the form.
+-
+-```js
+-const transloadit = require('@uppy/robodog')
+-
+-transloadit.form('#form', {
+-  params: {
+-    auth: { key: '' },
+-    template_id: ''
+-  }
+-})
+-```
+-
+-Adding Dashboard could be optional, eg
+-
+-```js
+-transloadit.form('#form', {
+-  ...
+-  dashboard: true // or css selector, true means input[type=file]
+-})
+-```
+-The file input would be replaced by a button that opens the dashboard modal.
+-Needs:
+-- a way of having a 'Done' button instead of 'Upload' that closes the modal but doesn't trigger upload.
+-
+-`transloadit.modal` opens the Dashboard and allows the user to select files.
+-When the user is done, presses 'upload', files are uploaded and the modal closes.
+-Promise resolves with results.
+-
+-Needs:
+-- `{multi: false}` option in core, so that no new files can be added once `upload()` was called
+-- `{autoClose: true}` option in dashboard, that closes it once upload is complete
+-
+-```js
+-transloadit.modal({
+-  params: {
+-    auth: { key: '' },
+-    template_id: ''
+-  }
+-}).then(({ successful, failed }) => {
+-  // successful, failed are uppy.upload() result
+-  // perhaps it could be assembly status or assembly results instead
+-})
+-```
++Robodog is an Uppy-based library that pulls your files through Transloadit for all kinds of processing, such as transcoding video, resizing images, zipping/unzipping, [and more](https://transloadit.com/services/).
+ 
+ ## Installation
+ 
+ ```bash
+-$ npm install @uppy/transloadit --save
++$ npm install @uppy/robodog --save
+ ```
+ 
+-We recommend installing from npm and then using a module bundler such as [Webpack](http://webpack.github.io/), [Browserify](http://browserify.org/) or [Rollup.js](http://rollupjs.org/).
++We recommend installing from npm and then using a module bundler such as [Webpack](http://webpack.js.org/), [Browserify](http://browserify.org/) or [Rollup.js](http://rollupjs.org/).
+ 
+-Alternatively, you can also use this plugin in a pre-built bundle from Transloadit's CDN: Edgly. In that case `Uppy` will attach itself to the global `window.Uppy` object. See the [main Uppy documentation](https://uppy.io/docs/#Installation) for instructions.
++Alternatively, you can also use this package in a pre-built bundle from Transloadit's CDN: Edgly.
++
++```html
++<link rel=""stylesheet"" href=""https://transloadit.edgly.net/releases/uppy/v0.30.2/robodog.min.css"">
++<script src=""https://transloadit.edgly.net/releases/uppy/v0.30.2/robodog.min.js""></script>
++```",I think this could use the equivalent of `In that case `Uppy` will attach itself to the global `window.Uppy` object. See the [main Uppy documentation](https://uppy.io/docs/#Installation) for instructions.`,2019-03-04 12:51:16
+319,"@@ -1,84 +1,151 @@
+-var fs = require('fs')
+-var path = require('path')
+-var chalk = require('chalk')
+-var exec = require('child_process').exec
+-var YAML = require('js-yaml')
++const fs = require('fs')
++const path = require('path')
++const chalk = require('chalk')
++const { exec } = require('child_process')
++const YAML = require('js-yaml')
++const { promisify } = require('util')
++const gzipSize = require('gzip-size')
++const bytes = require('pretty-bytes')
++const browserify = require('browserify')
+ 
+-var webRoot = __dirname
+-var uppyRoot = path.join(__dirname, '../packages/uppy')
++const webRoot = __dirname
++const uppyRoot = path.join(__dirname, '../packages/uppy')
+ 
+-var configPath = webRoot + '/themes/uppy/_config.yml'
+-var version = require(uppyRoot + '/package.json').version
++const configPath = path.join(webRoot, '/themes/uppy/_config.yml')
++const { version } = require(path.join(uppyRoot, '/package.json'))
+ 
+-var defaultConfig = {
++const defaultConfig = {
+   comment: 'Auto updated by update.js',
+   uppy_version_anchor: '001',
+   uppy_version: '0.0.1',
+-  uppy_bundle_kb_sizes: {
+-    'uppy.js': 'N/A'
+-  },
++  uppy_bundle_kb_sizes: {},
+   config: {}
+ }
+ 
+-var loadedConfig
+-var buf
+-try {
+-  buf = fs.readFileSync(configPath, 'utf-8')
+-  loadedConfig = YAML.safeLoad(buf)
+-} catch (e) {
++// Keeping a whitelist so utils etc are excluded
++// It may be easier to maintain a blacklist instead
++const packages = [
++  'uppy',
++  '@uppy/core',
++  '@uppy/dashboard',
++  '@uppy/drag-drop',
++  '@uppy/file-input',
++  '@uppy/webcam',
++  '@uppy/dropbox',
++  '@uppy/google-drive',
++  '@uppy/instagram',
++  '@uppy/url',
++  '@uppy/tus',
++  '@uppy/xhr-upload',
++  '@uppy/aws-s3',
++  '@uppy/aws-s3-multipart',
++  '@uppy/status-bar',
++  '@uppy/progress-bar',
++  '@uppy/informer',
++  '@uppy/transloadit',
++  '@uppy/form',
++  '@uppy/golden-retriever',
++  '@uppy/react',
++  '@uppy/store-default',
++  '@uppy/store-redux'
++]","Yeah, `@uppy/thumbnail-generator` is not here, intentional? :)",2018-07-16 20:48:59
+203,"@@ -1,9 +1,11 @@
+-<!-- Basic Uppy styles. You can use a CDN: https://unpkg.com/uppy/dist/uppy.min.css -->
++<!-- Basic Uppy styles. You can use a Transloadit's CDN, Edgly: ",`a Transloadit` → `Transloadit` :),2018-01-29 08:53:41
+204,"@@ -1,9 +1,11 @@
+-<!-- Basic Uppy styles. You can use a CDN: https://unpkg.com/uppy/dist/uppy.min.css -->
++<!-- Basic Uppy styles. You can use a Transloadit's CDN, Edgly: 
++https://transloadit.edgly.net/releases/uppy/v0.22.0/dist/uppy.min.css -->
+ <link rel=""stylesheet"" href=""/uppy/uppy.min.css"">
+ 
+ <div class=""UppyDragDrop""></div>
+ 
+-<!-- Load Uppy pre-built bundled version. You can use a CDN: https://unpkg.com/uppy -->
++<!-- Load Uppy pre-built bundled version. You can use a Transloadit's CDN, Edgly: ",same here 👆 ,2018-01-29 08:53:55
+2,"@@ -1,9 +1,94 @@
+----
+-title: Dropbox
+-type: examples
+-order: 1
+----
++<!DOCTYPE html>","Since this uses a layout, we already have `<html>` and page styling. You can rename the file to `dropbox.html` remove everything above `<h1>`, and starting/below `<body>`
+",2015-12-05 10:18:57
+340,"@@ -10,24 +51,36 @@ describe('File upload with Providers', () => {
+     browser.reload()
+   })
+ 
+-  it('should upload a file completely with Google Drive', () => {
++  it('should upload a file completely with Google Drive', function () {",why are we not using arrow functions in this case?,2018-09-02 21:56:35
+335,"@@ -10,24 +51,36 @@ describe('File upload with Providers', () => {
+     browser.reload()
+   })
+ 
+-  it('should upload a file completely with Google Drive', () => {
++  it('should upload a file completely with Google Drive', function () {
++    if (process.env.UPPY_GOOGLE_EMAIL === undefined) {
++      return this.skip()
++    }
++
+     startUploadTest(browser, 'GoogleDrive')
+     signIntoGoogle(browser)
+     finishUploadTest(browser)
+   })
+ 
+-  it('should upload a file completely with Instagram', () => {
++  it('should upload a file completely with Instagram', function () {
++    if (process.env.UPPY_INSTAGRAM_USERNAME === undefined) {
++      return this.skip()
++    }
++
+     startUploadTest(browser, 'Instagram')
+     // do oauth authentication
+     browser.waitForExist('input[name=username]')
+     browser.setValue('input[name=username]', process.env.UPPY_INSTAGRAM_USERNAME)
+     browser.setValue('input[name=password]', process.env.UPPY_INSTAGRAM_PASSWORD)
+-    browser.click('button')
++    browser.click('form button')",Just `button` was clicking a cookie consent button locally :see_no_evil: ,2018-08-20 15:15:45
+797,"@@ -10,28 +10,30 @@ module.exports = class MyCustomProvider extends Plugin {
+     this.id = this.opts.id || 'MyCustomProvider'
+     Provider.initPlugin(this, opts)
+ 
+-    this.title = 'MyCustomProvider'
++    this.title = 'MyUnsplash'
+     this.icon = () => (
+-      <img src=""https://uppy.io/images/logos/uppy-dog-head-arrow.svg"" width=""23"" />
++      <img src=""https://unsplash.com/assets/core/logo-black-df2168ed0c378fa5506b1816e75eb379d06cfcd0af01e07a2eb813ae9b5d7405.svg"" width=""30"" />","Maybe we should store this file in this repo, in case the hash changes",2020-06-29 13:34:10
+963,"@@ -10,54 +10,28 @@ category: ""React""
+ 
+ When using Uppy's React components, an Uppy instance must be passed in to the `uppy={}` prop from the outside. This Uppy instance must be initialized before passing it to the desired component, and be cleaned up using `uppy.close()` when you are done with it.
+ 
+-## Functional Components
++## Functionl Components","Shouldn't this be ""Functional Components""?",2020-12-16 12:26:15
+964,"@@ -10,6 +10,10 @@ declare module StatusBar {
+     showProgressDetails?: boolean
+     hideUploadButton?: boolean
+     hideAfterFinish?: boolean
++    hideRetryButton?: boolean,
++    hidePauseResumeButton?: boolean,
++    hideCancelButton?: boolean,
++    doneButtonHandler: Function | null,","As is this would require users to pass in `doneButtonHandler: null`; we do need a `?` type here. Instead of `Function`, with typescript you can also specify a function signature, so that users wont accidentally expect to receive any arguments:
+```suggestion
+    doneButtonHandler?: () => void,
+```",2020-12-16 14:01:24
+858,"@@ -10,6 +11,11 @@ const h = React.createElement
+  */
+ 
+ class Dashboard extends React.Component {
++  constructor (props) {
++    super(props)
++    this.validProps = getHTMLProps(props)","This only gathers the props from the initial render, which can be an issue if the user changes the props over time. Is `getHTMLProps` fast enough to just do it on every render? (I think the answer is probably yes—we do a bunch of work in render paths in Uppy itself, so a bit of props filtering is unlikely to matter…)",2020-08-06 13:45:55
+469,"@@ -10,7 +10,13 @@ script:
+ - npm run build
+ - npm run test
+ - if [ ""${TRAVIS_PULL_REQUEST}"" = ""false"" ]; then npm run test:endtoend; fi
+-#- npm run uploadcdn
++- |
++  if [ ""${TRAVIS_PULL_REQUEST}"" = ""false"" ] &&\
++     [[ ""${TRAVIS_COMMIT_MESSAGE}"" =~ ^Release* ]]; then",Still a little bit of shell but :),2019-05-22 14:19:13
+641,"@@ -10,9 +10,21 @@ function resolveUrl (origin, link) {
+   return new URL_(link, origin).toString()
+ }
+ 
+-function isXml (xhr) {
+-  const contentType = xhr.headers ? xhr.headers['content-type'] : xhr.getResponseHeader('Content-Type')
+-  return typeof contentType === 'string' && contentType.toLowerCase() === 'application/xml'
++function isXml (content, xhr) {
++  const contentType = (xhr.headers ? xhr.headers['content-type'] : xhr.getResponseHeader('Content-Type'))
++    // Get rid of mime parameters like charset=utf-8
++    .replace(/;.*$/, '')
++  if (typeof contentType === 'string') {
++    if (contentType.toLowerCase() === 'application/xml') {","should we also be checking for `text/xml`? so maybe this?
+```suggestion
+    if (['application/xml', 'text/xml'].includes(contentType.toLowerCase())) {
+```",2019-11-27 18:42:34
+599,"@@ -100,8 +99,9 @@ class Uppy {
+     }
+ 
+     // Merge default options with the ones set by user
+-    this.opts = Object.assign({}, defaultOptions, opts)
+-    this.opts.restrictions = Object.assign({}, defaultOptions.restrictions, this.opts.restrictions)
++    this.opts = {}
++    this.setOptions(defaultOptions)
++    this.setOptions(opts)","I think we can safely do this here:
+```js
+this.opts = defaultOptions
+this.setOptions(opts)
+```
+since `defaultOptions` is a local object that is created inside the constructor already.
+Then `setOptions()` will only do the locale init once. Right now we're creating a Translator instance and then immediately throwing it away and creating a second one.",2019-09-30 10:06:08
+778,"@@ -101,6 +126,13 @@ module.exports = class Client {
+   cancelAssembly (assembly) {
+     const url = assembly.assembly_ssl_url
+     return fetch(url, { method: 'delete', headers: this._headers })","maybe it's worth wrapping the `fetch` module into a reusable module that handles the `NetworkError` internally? This pattern is now spread across the codebase, and the need to change this snippet at one place will most likely imply the need to change it everywhere else.",2020-05-29 12:21:57
+258,"@@ -102,22 +102,34 @@ module.exports = class DragDrop extends Plugin {
+   }
+ 
+   render (state) {
+-    const DragDropClass = `uppy uppy-DragDrop-container ${this.isDragDropSupported ? 'is-dragdrop-supported' : ''}`
++    /* http://tympanus.net/codrops/2015/09/15/styling-customizing-file-inputs-smart-way/ */
++    const hiddenInputStyle = {
++      width: '0.1px',
++      height: '0.1px',
++      opacity: 0,
++      overflow: 'hidden',
++      position: 'absolute',
++      zIndex: -1
++    }
++    const DragDropClass = `uppy uppy-DragDrop-container ${this.isDragDropSupported ? 'uppy-DragDrop--is-dragdrop-supported' : ''}`
+     const DragDropStyle = {
+       width: this.opts.width,
+       height: this.opts.height
+     }
++    const restrictions = this.uppy.opts.restrictions
+     return (
+       <div class={DragDropClass} style={DragDropStyle}>
+         <div class=""uppy-DragDrop-inner"">
+           <svg aria-hidden=""true"" class=""UppyIcon uppy-DragDrop-arrow"" width=""16"" height=""16"" viewBox=""0 0 16 16"" xmlns=""http://www.w3.org/2000/svg"">
+             <path d=""M11 10V0H5v10H2l6 6 6-6h-3zm0 0"" fill-rule=""evenodd"" />
+           </svg>
+           <label class=""uppy-DragDrop-label"">
+-            <input class=""uppy-DragDrop-input""
++            <input style={hiddenInputStyle}
++              class=""uppy-DragDrop-input""
+               type=""file""
+               name=""files[]""
+-              multiple=""true""
++              multiple={restrictions.maxNumberOfFiles !== 1 || !restrictions.maxNumberOfFiles}",and here,2018-05-09 15:51:56
+351,"@@ -102,6 +102,49 @@ strings: {
+ }
+ ```
+ 
++### `getUploadHeaders()`
++
++Set the default headers for the request to be sent to the server.
++A common use case is adding the `Authorization` header with your JWT token.",We should clarify that this is only used if you do not override `getUploadParameters()`,2018-09-20 09:22:06
+372,"@@ -1020,7 +1020,7 @@ describe('src/Core', () => {
+       })
+ 
+       core._calculateTotalProgress()
+-      expect(core.getState().totalProgress).toEqual(65)
++      expect(core.getState().totalProgress).toEqual(66)
+     })",65 vs 66? 🤔,2018-11-19 14:45:11
+282,"@@ -1028,6 +1060,7 @@
+ 
+ .uppy-DashboardFileCard[aria-hidden=true] {
+   transform: translateY(-105%);
++  transform: translate3d(0, -105%, 0);","The `translateY` is commented out in some places and kept here, is it intended as a fallback or should they be removed everywhere?",2018-05-29 09:21:44
+336,"@@ -103,14 +116,49 @@ module.exports = class GoogleDrive extends Plugin {
+   }
+ 
+   getItemModifiedDate (item) {
+-    return item.modifiedByMeDate
++    return item.modifiedTime
+   }
+ 
+   getItemThumbnailUrl (item) {
+     return `${this.opts.serverUrl}/${this.GoogleDrive.id}/thumbnail/${this.getItemRequestPath(item)}`
+   }
+ 
+   render (state) {
++    // If the user has access to any Team Drives, handle them as needed.
++    if (state.plugins[this.id].hasTeamDrives) {","You can do `this.getPluginState()` instead of accessing `state.plugins[this.id]`, is a bit clearer I think :)",2018-08-20 15:29:23
+338,"@@ -103,14 +116,49 @@ module.exports = class GoogleDrive extends Plugin {
+   }
+ 
+   getItemModifiedDate (item) {
+-    return item.modifiedByMeDate
++    return item.modifiedTime
+   }
+ 
+   getItemThumbnailUrl (item) {
+     return `${this.opts.serverUrl}/${this.GoogleDrive.id}/thumbnail/${this.getItemRequestPath(item)}`
+   }
+ 
+   render (state) {
++    // If the user has access to any Team Drives, handle them as needed.
++    if (state.plugins[this.id].hasTeamDrives) {
++      let folders = state.plugins[this.id].folders
++
++      // Add Team Drive id parameter to any folders within Team Drives.
++      // This is needed in order to retrieve file lists.
++      folders.forEach((folder) => {
++        if (folder.teamDriveId) {
++          folder.id += `?teamDriveId=${folder.teamDriveId}`",this logic should be added to `getItemRequestPath` instead,2018-08-20 22:30:58
+932,"@@ -103,6 +104,14 @@ function uppySetOptions () {
+     window.uppy.removePlugin(dropboxInstance)
+   }
+ 
++  const boxInstance = window.uppy.getPlugin('Box')
++  if (opts.Box && !boxInstance) {
++    window.uppy.use(Box, { target: Dashboard, companionUrl: COMPANION })
++  }
++  if (!opts.Box && boxInstance) {
++    window.uppy.removePlugin(boxInstance)
++  }
++","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:14:13
+353,"@@ -1031,6 +1037,11 @@ class Uppy {
+    * @return {string} ID of this upload.
+    */
+   _createUpload (fileIDs) {
++    const { allowNewUpload, currentUploads } = this.getState()
++    if (!allowNewUpload) {
++      throw new Error('Cannot create a new upload: already uploading.')
++    }","Seems like a “hard” error, will this be shown in the UI?",2018-09-20 17:38:12
+347,"@@ -1034,12 +1074,12 @@ using `fetch()` to access it.
+ 
+ ### Node
+ Check out [this tutorial](https://www.fullstackreact.com/articles/using-create-react-app-with-a-server/).
+-You can find the companion GitHub repository [here](https://github.com/fullstackreact/food-lookup-demo).
++You can find the Companion GitHub repository [here](https://github.com/fullstackreact/food-lookup-demo).
+ 
+ ### Ruby on Rails
+ 
+ Check out [this tutorial](https://www.fullstackreact.com/articles/how-to-get-create-react-app-to-work-with-your-rails-api/).
+-You can find the companion GitHub repository [here](https://github.com/fullstackreact/food-lookup-demo-rails).
++You can find the Companion GitHub repository [here](https://github.com/fullstackreact/food-lookup-demo-rails).","The companions in this file don't refer to Companion :smile: We might as well nuke this readme, it's just here because create-react-app made it",2018-09-03 12:30:08
+230,"@@ -104,13 +104,12 @@ module.exports = class ThumbnailGenerator extends Plugin {
+ 
+     image = this.protect(image)
+ 
+-    var steps = Math.ceil(Math.log2(image.width / targetWidth))
++    var steps = Math.ceil(Math.abs(Math.log2(image.width / targetWidth)))","I'm not sure if `Math.abs` is the best way to do it, for very small images the Math.abs call might return a positive number > 1 which would cause the step scaling to first size it up to N times the target size and then resize it back down. Another way could be to check if `steps < 1` and then set it to 1?",2018-02-19 08:44:48
+181,"@@ -105,101 +119,91 @@ module.exports = (props) => {
+   const isHidden = (uploadState === STATE_WAITING && props.hideUploadButton) ||
+     (uploadState === STATE_WAITING && !props.newFiles > 0)
+ 
+-  const statusBarEl = html`
+-    <div class=""UppyStatusBar is-${uploadState}""
+-         aria-hidden=""${isHidden}"">
+-      <div class=""UppyStatusBar-progress ${progressMode ? `is-${progressMode}` : ''}""
+-           style=""width: ${width}%""
+-           role=""progressbar""
+-           aria-valuemin=""0""
+-           aria-valuemax=""100""
+-           ${progressValue
+-           ? { 'aria-valuenow': progressValue }
+-           : {}}></div>
+-      ${progressBarContent}
+-      <div class=""UppyStatusBar-actions"">
+-        ${props.newFiles && !props.hideUploadButton ? UploadBtn(props) : ''}
+-        ${props.error ? RetryBtn(props) : ''}
++  const progressClasses = `uppy-StatusBar-progress 
++                           ${progressMode ? 'is-' + progressMode : ''}`
++
++  return (
++    <div class={'uppy uppy-StatusBar ' + `is-${uploadState}`} aria-hidden={isHidden}>","``` '' + `` ``` reads a bit weird, maybe use a single template string? or pass it through classnames",2017-12-20 18:17:06
+182,"@@ -105,101 +119,91 @@ module.exports = (props) => {
+   const isHidden = (uploadState === STATE_WAITING && props.hideUploadButton) ||
+     (uploadState === STATE_WAITING && !props.newFiles > 0)
+ 
+-  const statusBarEl = html`
+-    <div class=""UppyStatusBar is-${uploadState}""
+-         aria-hidden=""${isHidden}"">
+-      <div class=""UppyStatusBar-progress ${progressMode ? `is-${progressMode}` : ''}""
+-           style=""width: ${width}%""
+-           role=""progressbar""
+-           aria-valuemin=""0""
+-           aria-valuemax=""100""
+-           ${progressValue
+-           ? { 'aria-valuenow': progressValue }
+-           : {}}></div>
+-      ${progressBarContent}
+-      <div class=""UppyStatusBar-actions"">
+-        ${props.newFiles && !props.hideUploadButton ? UploadBtn(props) : ''}
+-        ${props.error ? RetryBtn(props) : ''}
++  const progressClasses = `uppy-StatusBar-progress 
++                           ${progressMode ? 'is-' + progressMode : ''}`
++
++  return (
++    <div class={'uppy uppy-StatusBar ' + `is-${uploadState}`} aria-hidden={isHidden}>
++      <div class={progressClasses}
++        style={{ width: width + '%' }}
++        role=""progressbar""
++        aria-valuemin=""0""
++        aria-valuemax=""100""
++        aria-valuenow={progressValue} />
++      {progressBarContent}
++      <div class=""uppy-StatusBar-actions"">
++        { props.newFiles && !props.hideUploadButton ? UploadBtn(props) : null }
++        { props.error ? RetryBtn(props) : null }","we could also use JSX where we're currently just calling functions, for nicer tree display in react devtools",2017-12-20 18:18:07
+495,"@@ -105,6 +105,10 @@ module.exports = class DragDrop extends Plugin {
+         // Nothing, restriction errors handled in Core
+       }
+     })
++
++    // ___Why not use value="""" on <input/> instead?
++    //    Because if we use that method of clearing the input, Chrome will not trigger onChange={} if we drop the same file twice (Issue #768).
++    event.target.value = null","We pass `ev` to the callback, but `event` works anyway. What sort of sorcery is this? 🙀 Been trying to find documentation for a while, nothing so far.",2019-05-30 14:31:37
+770,"@@ -105,7 +105,6 @@
+     ""@types/node"": ""12.12.27"",
+     ""@types/react"": ""16.9.19"",
+     ""@types/request"": ""2.48.4"",
+-    ""@types/tus-js-client"": ""1.8.0"",","tus-js-client v2.1.0+ now includes the type definitions on its own, so that dependency is not needed anymore.",2020-05-13 10:07:28
+145,"@@ -106,24 +106,58 @@ module.exports = (props) => {
+   }
+ 
+   const width = typeof progressValue === 'number' ? progressValue : 100
++  const isHidden = uploadState === STATE_WAITING && !props.newFiles > 0
+ 
+   return html`
+     <div class=""UppyStatusBar is-${uploadState}""
+-                aria-hidden=""${uploadState === STATE_WAITING}""
+-                title="""">
+-      <progress style=""display: none;"" min=""0"" max=""100"" value=${progressValue}></progress>
++         aria-hidden=""${isHidden}"">
+       <div class=""UppyStatusBar-progress ${progressMode ? `is-${progressMode}` : ''}""
+-           style=""width: ${width}%""></div>
++           style=""width: ${width}%""
++           role=""progressbar""
++           aria-valuemin=""0""
++           aria-valuemax=""100""
++           aria-valuenow=""${progressValue}""></div>
+       ${progressBarContent}
++      <div class=""UppyStatusBar-actions"">
++        ${props.newFiles ? UploadBtn(props) : ''}
++        ${props.error ? RetryBtn(props) : ''}
++      </div>
+     </div>
+   `
+ }
+ 
++const UploadBtn = (props) => {
++  return html`<button type=""button""
++                      class=""UppyStatusBar-actionBtn UppyStatusBar-actionBtn--upload""
++                      aria-label=""${props.i18n('uploadXFiles', { smart_count: props.newFiles })}""
++                      onclick=${props.startUpload}>
++                ${props.inProgress
++                  ? props.i18n('uploadXNewFiles', { smart_count: props.newFiles })
++                  : props.i18n('uploadXFiles', { smart_count: props.newFiles })
++                }
++              </button>`
++}
++
++const RetryBtn = (props) => {
++  return html`<button type=""button""
++                      class=""UppyStatusBar-actionBtn UppyStatusBar-actionBtn--retry""
++                      aria-label=""${props.i18n('retryUpload')}""
++                      onclick=${props.retryAll}>
++                ${props.i18n('retry')}
++              </button>`
++}","I wonder if we could pass these actions in as an option somehow? for a standalone StatusBar, not inside the Dashboard, having the upload button is a bit strange.
+
+maybe so that the dashboard can do something like
+
+```js
+this.core.use(StatusBar, {
+  id: `${this.id}-StatusBar`,
+  actions (state) {
+    return [ hasNewFiles && UploadBtn({ /* xyz */ }), hasError && RetryBtn({ /* xyz */ }) ]
+  }
+})
+```",2017-12-03 14:40:09
+146,"@@ -106,24 +106,58 @@ module.exports = (props) => {
+   }
+ 
+   const width = typeof progressValue === 'number' ? progressValue : 100
++  const isHidden = uploadState === STATE_WAITING && !props.newFiles > 0
+ 
+   return html`
+     <div class=""UppyStatusBar is-${uploadState}""
+-                aria-hidden=""${uploadState === STATE_WAITING}""
+-                title="""">
+-      <progress style=""display: none;"" min=""0"" max=""100"" value=${progressValue}></progress>
++         aria-hidden=""${isHidden}"">
+       <div class=""UppyStatusBar-progress ${progressMode ? `is-${progressMode}` : ''}""
+-           style=""width: ${width}%""></div>
++           style=""width: ${width}%""
++           role=""progressbar""
++           aria-valuemin=""0""
++           aria-valuemax=""100""
++           aria-valuenow=""${progressValue}""></div>
+       ${progressBarContent}
++      <div class=""UppyStatusBar-actions"">
++        ${props.newFiles ? UploadBtn(props) : ''}
++        ${props.error ? RetryBtn(props) : ''}
++      </div>
+     </div>
+   `
+ }
+ 
++const UploadBtn = (props) => {
++  return html`<button type=""button""
++                      class=""UppyStatusBar-actionBtn UppyStatusBar-actionBtn--upload""
++                      aria-label=""${props.i18n('uploadXFiles', { smart_count: props.newFiles })}""
++                      onclick=${props.startUpload}>
++                ${props.inProgress
++                  ? props.i18n('uploadXNewFiles', { smart_count: props.newFiles })
++                  : props.i18n('uploadXFiles', { smart_count: props.newFiles })
++                }
++              </button>`
++}
++
++const RetryBtn = (props) => {
++  return html`<button type=""button""
++                      class=""UppyStatusBar-actionBtn UppyStatusBar-actionBtn--retry""
++                      aria-label=""${props.i18n('retryUpload')}""
++                      onclick=${props.retryAll}>
++                ${props.i18n('retry')}
++              </button>`
++}
++
+ const ProgressBarProcessing = (props) => {
++  const value = Math.round(props.value * 100)
+   return html`
+     <div class=""UppyStatusBar-content"">
+-      ${props.mode === 'determinate' ? `${Math.round(props.value * 100)}%・` : ''}
+-      ${props.message}
++      <div role=""progressbar""
++           aria-valuemin=""0""
++           aria-valuemax=""100""
++           aria-valuenow=""${value}"">","when `props.mode` is 'indeterminate', we should not add the `aria-valuenow` attribute",2017-12-03 14:42:13
+149,"@@ -106,24 +106,59 @@ module.exports = (props) => {
+   }
+ 
+   const width = typeof progressValue === 'number' ? progressValue : 100
++  const isHidden = (uploadState === STATE_WAITING && props.hideUploadButton) ||
++    (uploadState === STATE_WAITING && !props.newFiles > 0)
+ 
+   return html`
+     <div class=""UppyStatusBar is-${uploadState}""
+-                aria-hidden=""${uploadState === STATE_WAITING}""
+-                title="""">
+-      <progress style=""display: none;"" min=""0"" max=""100"" value=${progressValue}></progress>
++         aria-hidden=""${isHidden}"">
+       <div class=""UppyStatusBar-progress ${progressMode ? `is-${progressMode}` : ''}""
+-           style=""width: ${width}%""></div>
++           style=""width: ${width}%""
++           role=""progressbar""
++           aria-valuemin=""0""
++           aria-valuemax=""100""
++           aria-valuenow=""${progressValue}""></div>","here `progressValue` can be null or undefined if we are processing and the processing progress is `'indeterminate'`, we should not add the valuenow attribute in that case",2017-12-03 14:51:25
+101,"@@ -107,17 +107,22 @@ function toArray (list) {
+ }
+ 
+ /**
+- * Takes a fileName and turns it into fileID, by converting to lowercase,
+- * removing extra characters and adding unix timestamp
++ * Takes a file object and turns it into fileID, by converting file.name to lowercase,
++ * removing extra characters and adding type, size and lastModified
+  *
+- * @param {String} fileName
++ * @param {Object} file
++ * @return {String} the fileID
+  *
+  */
+ function generateFileID (file) {
+-  let fileID = file.name.toLowerCase()
+-  fileID = fileID.replace(/[^A-Z0-9]/ig, '')
+-  fileID = fileID + file.data.lastModified
+-  return fileID
++  // filter is needed to not join empty values with `-`
++  return [
++    'uppy',
++    file.name ? file.name.toLowerCase().replace(/[^A-Z0-9]/ig, '') : '',
++    file.type,","Is this definitely a string at this point? Asking because files in state have a `{general, specific}` object as their type",2017-09-11 07:47:26
+894,"@@ -1076,6 +1076,7 @@ class Uppy {
+       const currentProgress = this.getFile(file.id).progress
+       this.setFileState(file.id, {
+         progress: Object.assign({}, currentProgress, {
++          postprocess: this.postProcessors.length > 0,","`postprocess` is normally an object, not a boolean, so we should prob do something like:
+
+```suggestion
+          postprocess: this.postProcessors.length > 0 ? {
+            mode: 'indeterminate'
+          } : null,
+```",2020-09-18 09:11:06
+893,"@@ -108,7 +108,7 @@ exports.getRequestPath = (item) => {
+   } else if (item.file_type) {
+     return `${encodeURIComponent(item.meeting_id)}?recordingId=${encodeURIComponent(item.id)}`
+   }
+-  return `${encodeURIComponent(item.uuid)}`
++  return `${encodeURIComponent(encodeURIComponent(item.uuid))}`",what kind of files does the `uuid` case match? Can we just always send `item.id` instead?,2020-09-14 10:36:32
+134,"@@ -108,7 +111,8 @@
+     ""url-parse"": ""1.1.9"",
+     ""whatwg-fetch"": ""2.0.3"",
+     ""yo-yo"": ""1.4.0"",
+-    ""yo-yoify"": ""3.7.2""
++    ""yo-yoify"": ""3.7.2"",
++    ""webdriverio"": ""^4.8.0""",should this be a devDependency?,2017-11-09 18:18:44
+197,"@@ -1084,8 +1084,14 @@ class Uppy {
+           waitingFileIDs.push(file.id)
+         }
+       })
+-
+-      const uploadID = this._createUpload(waitingFileIDs)
++      const { currentUploads } = this.getState()
++
++      // get a list of files that are currently assigned to uploads
++      const currentlyUploadingFiles = Object.keys(currentUploads).reduce((prev, curr) => prev.concat(currentUploads[curr].fileIDs), [])
++      // files the list of files that are waiting to be uploaded against ones that are assigned to uploads. This should give us a list of files that have not been
++      // assigned to an upload yet
++      const filesToUpload = waitingFileIDs.filter((fileId) => currentlyUploadingFiles.indexOf(fileId) < 0)","Can we do this check a few lines up, here?
+
+https://github.com/richardwillars/uppy/blob/0717ee8117a36510d582e960e223674cf98205a7/src/core/Core.js#L1083
+
+`waitingFiles` was already supposed to be the list of files to upload. maybe we can just replace the `!file.uploadStarted` check on that line with `currentlyUploadingFiles.indexOf(fileId) === -1`?",2018-01-29 08:15:06
+217,"@@ -1090,35 +1078,31 @@ class Uppy {
+       this.log('No uploader type plugins are used', 'warning')
+     }
+ 
+-    const isMinNumberOfFilesReached = this._checkMinNumberOfFiles()
+-    if (!isMinNumberOfFilesReached) {
+-      return Promise.reject(new Error('Minimum number of files has not been reached'))
+-    }
+-
+-    const beforeUpload = Promise.resolve()
++    return Promise.resolve()
+       .then(() => this.opts.onBeforeUpload(this.getState().files))
++      .then(() => this._checkMinNumberOfFiles())
++      .then(() => {","This is mostly a whitespace change starting at this line, and ending…",2018-02-08 20:57:57
+218,"@@ -1090,35 +1078,31 @@ class Uppy {
+       this.log('No uploader type plugins are used', 'warning')
+     }
+ 
+-    const isMinNumberOfFilesReached = this._checkMinNumberOfFiles()
+-    if (!isMinNumberOfFilesReached) {
+-      return Promise.reject(new Error('Minimum number of files has not been reached'))
+-    }
+-
+-    const beforeUpload = Promise.resolve()
++    return Promise.resolve()
+       .then(() => this.opts.onBeforeUpload(this.getState().files))
++      .then(() => this._checkMinNumberOfFiles())
++      .then(() => {
++        const { currentUploads } = this.getState()
++        // get a list of files that are currently assigned to uploads
++        const currentlyUploadingFiles = Object.keys(currentUploads).reduce((prev, curr) => prev.concat(currentUploads[curr].fileIDs), [])
++
++        const waitingFileIDs = []
++        Object.keys(this.getState().files).forEach((fileID) => {
++          const file = this.getFile(fileID)
++          // if the file hasn't started uploading and hasn't already been assigned to an upload..
++          if ((!file.progress.uploadStarted) && (currentlyUploadingFiles.indexOf(fileID) === -1)) {
++            waitingFileIDs.push(file.id)
++          }
++        })
+ 
+-    return beforeUpload.catch((err) => {
+-      const message = typeof err === 'object' ? err.message : err
+-      this.info(message, 'error', 5000)
+-      return Promise.reject(new Error(`onBeforeUpload: ${message}`))
+-    }).then(() => {
+-      const { currentUploads } = this.getState()
+-      // get a list of files that are currently assigned to uploads
+-      const currentlyUploadingFiles = Object.keys(currentUploads).reduce((prev, curr) => prev.concat(currentUploads[curr].fileIDs), [])
+-
+-      const waitingFileIDs = []
+-      Object.keys(this.getState().files).forEach((fileID) => {
+-        const file = this.getFile(fileID)
+-        // if the file hasn't started uploading and hasn't already been assigned to an upload..
+-        if ((!file.progress.uploadStarted) && (currentlyUploadingFiles.indexOf(fileID) === -1)) {
+-          waitingFileIDs.push(file.id)
+-        }
++        const uploadID = this._createUpload(waitingFileIDs)
++        return this._runUpload(uploadID)
++      })",…and ending on this line.,2018-02-08 20:58:10
+233,"@@ -1099,8 +1087,6 @@ class Uppy {
+ 
+       const result = currentUploads[uploadID].result
+       this.emit('complete', result)
+-      // Compatibility with pre-0.21
+-      this.emit('success', fileIDs)",:dancer: ,2018-02-22 14:27:00
+276,"@@ -11,17 +11,21 @@ class ActionBrowseTagline extends Component {
+   }
+ 
+   render () {
++    const browse = (
++      <button type=""button"" class=""uppy-Dashboard-browse"" onclick={this.handleClick}>
++        {this.props.i18n('browse')}
++      </button>
++    )
++
+     // empty value="""" on file input, so that the input is cleared after a file is selected,
+     // because Uppy will be handling the upload and so we can select same file
+     // after removing — otherwise browser thinks it’s already selected
+     return (
+       <span>
+         {this.props.acquirers.length === 0
+-          ? this.props.i18n('dropPaste')
+-          : this.props.i18n('dropPasteImport')
+-        } <button type=""button"" class=""uppy-Dashboard-browse"" onclick={this.handleClick}>
+-          {this.props.i18n('browse')}
+-        </button>
++          ? this.props.i18nArray('dropPaste', { browse })
++          : this.props.i18nArray('dropPasteImport', { browse })
++        }",Wicked! 🎉 ,2018-05-24 22:37:37
+736,"@@ -11,6 +11,20 @@ module.exports = class FileItem extends Component {
+     return !shallowEqual(this.props, nextProps)
+   }
+ 
++  componentDidMount () {
++    const file = this.props.file
++    if (!file.preview && this.props.handleRequestThumbnail) {
++      this.props.handleRequestThumbnail(file)
++    }
++  }
++
++  componentWillUnmount () {
++    const file = this.props.file
++    if (!file.preview && this.props.handleCancelThumbnail) {",I think we don't need the `this.props.handleCancelThumbnail` check,2020-04-14 17:57:55
+482,"@@ -11,6 +11,7 @@
+   ""devDependencies"": {
+     ""@babel/cli"": ""^7.4.4"",
+     ""@babel/core"": ""^7.4.4"",
++    ""@babel/plugin-proposal-class-properties"": ""^7.4.4"",",Kinda breaking my own rule here in terms of not adding things that are not standardised…but node.js and chrome already ship implementations,2019-05-27 12:19:06
+302,"@@ -11,8 +12,7 @@ export class RequestClient {
+   delete (path: string, data: object): Promise<any>;
+ }
+ 
+-export interface ProviderOptions {
+-  serverUrl: string;
++export interface ProviderOptions extends RequestClientOptions {",:+1: ,2018-06-28 10:28:10
+67,"@@ -110,6 +111,74 @@ module.exports = class DragDrop extends Plugin {
+     })
+   }
+ 
++  style () {
++    // these will be global styles variables,
++    // with an option to override them to support themes
++    const settings = {
++      fontSizes: {
++        normal: '1.2em'
++      },
++      colors: {
++        gray: '#ccc'
++      }
++    }
++
++    css`","Wonder why Github isn't highlighting this, I thought it also did that for `css` tags 😕 ",2017-06-30 11:21:18
+169,"@@ -111,32 +104,34 @@ module.exports = class DragDrop extends Plugin {
+   }
+ 
+   onBrowseClick (ev) {
+-    const input = this.el.querySelector('.uppy-DragDrop-input')
+-    input.click()
++    this.input.click()
+   }
+ 
+   render (state) {
+-    return html`
+-      <div class=""Uppy UppyTheme--default uppy-DragDrop-container ${this.isDragDropSupported ? 'is-dragdrop-supported' : ''}""
+-           style=""width: ${this.opts.width}; height: ${this.opts.height};"">
+-        <form class=""uppy-DragDrop-inner"" onsubmit=${(ev) => ev.preventDefault()}>
+-          <svg class=""UppyIcon uppy-DragDrop-arrow"" aria-hidden=""true"" width=""16"" height=""16"" viewBox=""0 0 16 16"" xmlns=""http://www.w3.org/2000/svg"">
++    return (
++      <div class={`Uppy UppyTheme--default uppy-DragDrop-container ${this.isDragDropSupported ? 'is-dragdrop-supported' : ''}`}
++           style={`width: ${this.opts.width}; height: ${this.opts.height};`}",do you have any opinions for or against using style objects here?,2017-12-13 21:39:33
+792,"@@ -111,7 +115,11 @@ class AddFiles extends Component {
+ 
+   renderAcquirer = (acquirer) => {
+     return (
+-      <div class=""uppy-DashboardTab"" role=""presentation"">
++      <div
++        class=""uppy-DashboardTab""
++        role=""presentation""
++        data-acquirer-id={acquirer.id}","```suggestion
+        data-uppy-acquirer-id={acquirer.id}
+```",2020-06-29 12:34:10
+754,"@@ -112,18 +112,23 @@ class Drive extends Provider {
+       .request()
+   }
+ 
+-  _getGsuiteFileMeta (id, token, mimeType, onDone) {
+-    logger.info(`calling Gsuite file meta for ${id}`, 'provider.drive.export.meta')
+-    return this.client
+-      .query()
+-      .head(`files/${id}/export`)
+-      .qs({ supportsAllDrives: true, mimeType })
+-      .auth(token)
+-      .request(onDone)
++  _waitForFailedResponse (resp) {
++    return new Promise((resolve, reject) => {
++      let data = ''
++      resp.on('data', (chunk) => {
++        data += chunk
++      }).on('end', () => {
++        try {
++          resolve(JSON.parse(data.toString()))
++        } catch (error) {
++          reject(error)
++        }
++      })",We need to handle `.on('error')` here too,2020-04-27 12:12:25
+783,"@@ -112,7 +112,12 @@ module.exports = function Buttons (props) {
+           i18n={i18n}
+           info={props.info}
+           log={props.log}
+-          onClick={() => removeFile(file.id)}
++          onClick={() => {
++            removeFile(file.id)
++            // So that developers can distinguish when users manually removed
++            // files in the UI, vs uppy.reset() (see #2301)
++            this.props.emit('dashboard:file-removed-ui', file)",If we do this I think we should wrap the `removeFile()` function in the Dashboard plugin and do the emit there instead of threading the `emit` function through all these layers.,2020-06-20 16:15:13
+776,"@@ -112,7 +115,12 @@ module.exports = function Buttons (props) {
+         onClick={() => toggleFileCard(file.id)}
+       />
+       {showLinkToFileUploadResult && file.uploadURL ? (
+-        <CopyLinkButton i18n={i18n} />","Props for `file` were missing, so it was not possible to copy the link, //cc @goto-bus-stop just for reference",2020-05-21 21:35:06
+999,"@@ -113,3 +117,18 @@ exports.cors = (options = {}) => (req, res, next) => {
+     exposedHeaders: exposedHeaders.join(','),
+   })(req, res, next)
+ }
++
++exports.metrics = () => {
++  const metricsMiddleware = promBundle({ includeMethod: true })
++  // @ts-ignore Not in the typings, but it does exist
++  const { promClient } = metricsMiddleware
++  const { collectDefaultMetrics } = promClient
++  collectDefaultMetrics({ register: promClient.register })
++
++  // Add version as a prometheus gauge
++  const versionGauge = new promClient.Gauge({ name: 'companion_version', help: 'npm version as an integer' })
++  // @ts-ignore
++  const numberVersion = version.replace(/\D/g, '') * 1","(Unrelated to the PR but maybe we can use parseInt here instead of casting with `*1`, then we can also remove the `//@ts-ignore`)",2021-04-12 07:29:17
+979,"@@ -1135,6 +1135,14 @@ class Uppy {
+         isPaused: false
+       })
+ 
++      // Remote providers sometimes don't tell us the file size,
++      // but we can know how many bytes we uploaded once the upload is complete.
++      if (file.size == null) {
++        this.setFileState(file.id, {
++          size: currentProgress.bytesTotal || uploadResp.bytesUploaded","I think there is a chance that `currentProgress.bytesTotal` is not going to be the actual size of the file because some events can be lost due to throttling, I think that I should always use `uploadResp.bytesUploaded`. It could look like
+
+```javascript
+if (uploadResp.bytesUploaded) {
+ ...
+ size: uploadResp.bytesUploaded
+ ...
+}
+```",2021-02-27 23:39:37
+291,"@@ -114,12 +114,6 @@ function getArrayBuffer (chunk) {
+ 
+ function getFileType (file) {
+   const fileExtension = file.name ? getFileNameAndExtension(file.name).extension : null
+-
+-  if (file.isRemote) {
+-    // some remote providers do not support file types
+-    return file.type ? file.type : mimeTypes[fileExtension]
+-  }
+-",this check is now redundant. The rest of the function downwards basically does the same thing but with safer checks.,2018-06-02 16:26:13
+608,"@@ -114,28 +116,28 @@ Alternatively, you can also use a pre-built bundle from Transloadit's CDN: Edgly
+ - ⓒ [`Google Drive`](https://uppy.io/docs/google-drive/)
+ - ⓒ [`Dropbox`](https://uppy.io/docs/dropbox/)
+ - ⓒ [`Instagram`](https://uppy.io/docs/instagram/)
+-- ⓒ [`Import From URL`](https://uppy.io/docs/url/) — support picking files from remote providers or direct URLs from anywhere on the web
++- ⓒ [`Import From URL`](https://uppy.io/docs/url/) — supports picking files from remote providers or direct URLs from anywhere on the web","“support” was meant like a call to action here, as in “support picking files from anywhere on your website”.",2019-10-21 10:23:32
+986,"@@ -114,49 +141,64 @@ module.exports = class GoldenRetriever extends Plugin {
+     })
+ 
+     const { currentUploads } = this.uppy.getState()
++
+     this.MetaDataStore.save({
+       currentUploads,
+-      files: filesToSave,
++      files: filesToSaveWithoutData,
+       pluginData,
+     })
+   }
+ 
+   loadFileBlobsFromServiceWorker () {
+-    this.ServiceWorkerStore.list().then((blobs) => {
++    if (!this.ServiceWorkerStore) {
++      return Promise.resolve({})
++    }
++
++    return this.ServiceWorkerStore.list().then((blobs) => {
++      const files = this.uppy.getFiles()
++      const localFilesOnly = files.filter((file) => {
++        // maybe && !file.progress.uploadComplete
++        return !file.isRemote
++      })
++
+       const numberOfFilesRecovered = Object.keys(blobs).length
+-      const numberOfFilesTryingToRecover = this.uppy.getFiles().length
++      const numberOfFilesTryingToRecover = localFilesOnly.length
++
+       if (numberOfFilesRecovered === numberOfFilesTryingToRecover) {
+         this.uppy.log(`[GoldenRetriever] Successfully recovered ${numberOfFilesRecovered} blobs from Service Worker!`)
+-        this.uppy.info(`Successfully recovered ${numberOfFilesRecovered} files`, 'success', 3000)
+-        return this.onBlobsLoaded(blobs)
++        return blobs
+       }
+       this.uppy.log('[GoldenRetriever] No blobs found in Service Worker, trying IndexedDB now...')
+-      return this.loadFileBlobsFromIndexedDB()
++      return {}",nice refactors here 👍🏻 ,2021-03-23 10:03:22
+965,"@@ -115,7 +115,7 @@ module.exports = function getIconByMime (fileType) {
+   }
+ 
+   // Archive
+-  const archiveTypes = ['zip', 'x-7z-compressed', 'x-rar-compressed', 'x-gtar', 'x-apple-diskimage', 'x-diskcopy']",Could you clarifty why some of those are removed?,2020-12-18 12:25:30
+683,"@@ -116,33 +120,46 @@ module.exports = class Webcam extends Plugin {
+     return !!this.mediaDevices
+   }
+ 
+-  getConstraints () {
++  getConstraints (deviceId) {
+     const acceptsAudio = this.opts.modes.indexOf('video-audio') !== -1 ||
+       this.opts.modes.indexOf('audio-only') !== -1
+     const acceptsVideo = this.opts.modes.indexOf('video-audio') !== -1 ||
+       this.opts.modes.indexOf('video-only') !== -1 ||
+       this.opts.modes.indexOf('picture') !== -1
+ 
++    const videoConstraints = deviceId ? { deviceId: deviceId } : { facingMode: this.opts.facingMode }
++
+     return {
+       audio: acceptsAudio,
+-      video: acceptsVideo ? { facingMode: this.opts.facingMode } : false
++      video: acceptsVideo ? videoConstraints : false
+     }
+   }
+ 
+-  start () {
++  start (deviceId = null) {","I would prefer if this took an options object with a deviceId property:
+```js
+this.start({ deviceId: deviceId })
+```
+
+especially if we might want to add more options in the future.",2020-03-04 10:38:04
+222,"@@ -117,11 +117,14 @@ uppy.use(Transloadit, {
+ })
+ ```
+ 
+-You can also set `fields: true` to send all global metadata along to the Assembly. Global metadata is set using the [`meta` option](/docs/uppy/#meta) in the Uppy constructor, or using the [`setMeta` method](/docs/uppy/#uppy-setMeta-data). The [Form](/docs/form) plugin also sets global metadata, providing a handy way to use values from HTML form fields:
++You can also pass an array of field names to send global or file metadata along to the Assembly. Global metadata is set using the [`meta` option](/docs/uppy/#meta) in the Uppy constructor, or using the [`setMeta` method](/docs/uppy/#uppy-setMeta-data). File metadata is set using the [`setFileMeta`](/docs/uppy/#uppy-setFileMeta-fileID-data) method. The [Form](/docs/form) plugin also sets global metadata based on the values of `<input />`s in the form, providing a handy way to use values from HTML form fields:
+ 
+ ```js
+ uppy.use(Form, { target: 'form#my-form', getMetaFromForm: true })","getMetaFromForm is true by default, but it doesn’t make a difference really.",2018-02-09 06:52:05
+188,"@@ -119,11 +123,11 @@ module.exports = (props) => {
+   const isHidden = (uploadState === STATE_WAITING && props.hideUploadButton) ||
+     (uploadState === STATE_WAITING && !props.newFiles > 0)
+ ","Could we re-use `isHidden` constant we already have in place here, instead of adding a new `hiddenClass ` css class? Perhaps by adding one extra condition, like so (haven’t tested this):
+
+```js
+const isHidden = (uploadState === STATE_WAITING && props.hideUploadButton) ||
+  (uploadState === STATE_WAITING && !props.newFiles > 0) ||
+  (uploadState === STATE_COMPLETE && props.hideAfterFinish)
+```
+
+ ",2018-01-04 21:10:45
+38,"@@ -119,7 +160,7 @@ module.exports = class Multipart extends Plugin {
+     filesForUpload.forEach((file, i) => {
+       const current = parseInt(i, 10) + 1
+       const total = filesForUpload.length
+-      this.upload(file, current, total)
++      file.isRemote ? this.uploadRemote(file, current, total) : this.upload(file, current, total)",Please write this as a full `if (...) { } else { }` statement,2017-05-26 10:43:36
+7,"@@ -12,160 +12,104 @@ export default class Modal extends Plugin {
+ 
+     // set default options
+     const defaultOptions = {
+-      defaultTabIcon: `
+-        <svg class=""UppyModalTab-icon"" width=""28"" height=""28"" viewBox=""0 0 101 58"" xmlns=""http://www.w3.org/2000/svg"">
++      defaultTabIcon: yo`
++        <svg class=""UppyModalTab-icon"" width=""28"" height=""28"" viewBox=""0 0 101 58"">
+           <path d=""M17.582.3L.915 41.713l32.94 13.295L17.582.3zm83.333 41.414L67.975 55.01 84.25.3l16.665 41.414zm-48.998 5.403L63.443 35.59H38.386l11.527 11.526v5.905l-3.063 3.32 1.474 1.36 2.59-2.806 2.59 2.807 1.475-1.357-3.064-3.32v-5.906zm16.06-26.702c-3.973 0-7.194-3.22-7.194-7.193 0-3.973 3.222-7.193 7.193-7.193 3.974 0 7.193 3.22 7.193 7.19 0 3.974-3.22 7.194-7.195 7.194zM70.48 8.682c-.737 0-1.336.6-1.336 1.337 0 .736.6 1.335 1.337 1.335.738 0 1.338-.598 1.338-1.336 0-.74-.6-1.338-1.338-1.338zM33.855 20.415c-3.973 0-7.193-3.22-7.193-7.193 0-3.973 3.22-7.193 7.195-7.193 3.973 0 7.192 3.22 7.192 7.19 0 3.974-3.22 7.194-7.192 7.194zM36.36 8.682c-.737 0-1.336.6-1.336 1.337 0 .736.6 1.335 1.337 1.335.738 0 1.338-.598 1.338-1.336 0-.74-.598-1.338-1.337-1.338z""/>
+         </svg>
+       `,
+       panelSelectorPrefix: 'UppyModalContent-panel'
+     }
+ 
+-    this.tabPanels = []
+-
+-    this.isModalVisible = false
+-
+     // merge default options with the ones set by user
+     this.opts = Object.assign({}, defaultOptions, opts)
+ 
+-    this.initTabs = this.initTabs.bind(this)
++    this.progressindicators = {}
++
+     this.hideModal = this.hideModal.bind(this)
+     this.showModal = this.showModal.bind(this)
+-    this.install = this.install.bind(this)
+   }
+ 
+-  prepareTarget (callerPlugin) {
++  update (state) {
++    var newEl = this.render(state)
++    yo.update(this.el, newEl)
++  }
++
++  addTarget (callerPlugin, el) {
+     const callerPluginId = callerPlugin.constructor.name
+     const callerPluginName = callerPlugin.name || callerPluginId
+     const callerPluginIcon = callerPlugin.icon || this.opts.defaultTabIcon
++    const callerPluginType = callerPlugin.type
++
++    if (callerPluginType !== 'acquirer' &&
++        callerPluginType !== 'progressindicator' &&
++        callerPluginType !== 'presenter') {
++      let msg = 'Error: Modal can only be used by plugins of types: acquirer, progressindicator, presenter'
++      this.core.log(msg)
++      return
++    }
+ 
+-    switch (callerPlugin.type) {
+-      case 'progressindicator':
+-        return '.UppyModal-progressBarContainer'
+-      case 'presenter':
+-        return '.UppyModal-presenter'
+-      case 'acquirer':
+-
+-        // add tab panel, where plugin will render
+-        const modalContent = document.querySelector('.UppyModalContent')
+-        const nodeForPlugin = document.createElement('div')
+-
+-        modalContent.appendChild(nodeForPlugin)
+-        nodeForPlugin.outerHTML = `
+-          <div class=""UppyModalContent-panel ${this.opts.panelSelectorPrefix}--${callerPluginId}""
+-               role=""tabpanel""
+-               aria-hidden=""true"">
+-          </div>`
+-
+-        // add tab switch button
+-        const modalTabs = document.querySelector('.UppyModalTabs')
+-        const modalTab = document.createElement('div')
+-
+-        modalTabs.appendChild(modalTab)
+-        modalTab.outerHTML = `
+-          <li class=""UppyModalTab"">
+-            <button class=""UppyModalTab-btn""
+-                    role=""tab""
+-                    aria-controls=""${callerPluginId}""
+-                    data-open=""${this.opts.panelSelectorPrefix}--${callerPluginId}"">
+-              ${callerPluginIcon}
+-              <span class=""UppyModalTab-name"">${callerPluginName}</span>
+-            </button>
+-          </li>`
+-
+-        return `.${this.opts.panelSelectorPrefix}--${callerPluginId}`
+-      default:
+-        let msg = 'Error: Modal can only be used by plugins of types: acquirer, progressindicator'
+-        this.core.log(msg)
+-        break
++    const target = {
++      id: callerPluginId,
++      name: callerPluginName,
++      icon: callerPluginIcon,
++      type: callerPluginType,
++      el: el,
++      isHidden: true
+     }
+-  }
+ 
+-  allDone () {
+-    this.hideAllTabPanels()
++    const modal = this.core.getState().modal
++    modal.targets.push(target)
++    this.core.setState({modal: modal})
+   }
+ 
+-  render () {
+-    // http://dev.edenspiekermann.com/2016/02/11/introducing-accessible-modal-dialog
+-
+-    return `
+-      <div class=""UppyModal""
+-           aria-hidden=""true""
+-           aria-labelledby=""modalTitle""
+-           aria-describedby=""modalDescription""
+-           role=""dialog"">
+-        <div class=""UppyModal-overlay js-UppyModal-close"" tabindex=""-1""></div>
+-        <div class=""UppyModal-inner"">
+-          <button class=""UppyModal-close js-UppyModal-close"" title=""Close Uppy modal"">×</button>
+-
+-          <ul class=""UppyModalTabs"" role=""tablist""></ul>
+-
+-          <div class=""UppyModalContent"">
+-            <div class=""UppyModal-presenter""></div>
+-            <div class=""UppyModal-progress"">
+-              <button class=""UppyModal-next js-UppyModal-next"">${this.core.i18n('upload')}</button>
+-              <div class=""UppyModal-progressBarContainer""></div>
+-            </div>
+-          </div>
++  showTabPanel (id) {
++    const modal = this.core.getState().modal
++
++    // hide all panels, except the one that matches current id
++    modal.targets.forEach((target) => {
++      if (target.type === 'acquirer') {
++        if (target.id === id) {
++          target.isHidden = false
++          return
++        }
++        target.isHidden = true
++      }
++    })
+ 
+-        </div>
+-      </div>
+-    `
++    this.core.setState({modal: modal})
+   }
+ 
+   hideModal () {
+-    this.isModalVisible = false
+-    this.modalEl.setAttribute('aria-hidden', 'true')
+-    this.core.emitter.emit('reset')
+-  }
+-
+-  showModal () {
+-    this.isModalVisible = true
+-    this.modalEl.removeAttribute('aria-hidden')
+-    this.initTabs()
+-  }
++    const modal = this.core.getState().modal
++    modal.isHidden = true
++    this.core.setState({modal: modal})
+ 
+-  hideAllTabPanels () {
+-    this.tabPanels.forEach((tabPanel) => tabPanel.setAttribute('aria-hidden', true))
+-    this.tabs.forEach((tab) => tab.removeAttribute('aria-selected'))
++    document.body.style.overflow = 'visible'
+   }
+ 
+-  showTabPanel (pluginSelector, pluginName) {
+-    this.hideAllTabPanels()
++  showModal () {
++    // this.core.emitter.emit('modal-open')
+ 
+-    const tab = document.querySelector(`[aria-controls=""${pluginName}""]`)
+-    const tabPanel = document.querySelector(`.${pluginSelector}`)
++    const modal = this.core.getState().modal
++    modal.isHidden = false
+ 
+-    tabPanel.removeAttribute('aria-hidden')
+-    tab.setAttribute('aria-selected', 'true')
++    // Show first acquirer plugin when modal is open
++    modal.targets.some((target) => {
++      if (target.type === 'acquirer') {
++        target.isHidden = false
++        return true
++      }
++    })
+ 
+-    this.core.log(pluginName)
+-    this.core.getPlugin(pluginName).focus()
++    this.core.setState({modal: modal})
+ 
+-    // Remove `next` buttons provided by plugins, since Modal has its own
+-    // document.querySelector('.UppyNextBtn').remove()
++    document.body.style.overflow = 'hidden'","I'd prefer if we could toggle a class on the body to control this, rather than adding an inline style, but it's not a big deal.
+",2016-04-04 15:48:07
+69,"@@ -12,41 +12,51 @@ module.exports = (props) => {
+   }
+ 
+   return html`
+-    <div class=""Browser"">
+-      <header>
+-        <input
+-          type=""text""
+-          class=""Browser-search""
+-          placeholder=""Search Drive""
+-          onkeyup=${props.filterQuery}
+-          value=${props.filterInput}/>
++    <div class=""Browser Browser-viewType--${props.defaultViewType}"">
++      <header class=""Browser-header"">",would it make sense to refactor this into a `Header` component? So it is easier to follow?,2017-07-02 11:12:12
+68,"@@ -12,41 +12,51 @@ module.exports = (props) => {
+   }
+ 
+   return html`
+-    <div class=""Browser"">
+-      <header>
+-        <input
+-          type=""text""
+-          class=""Browser-search""
+-          placeholder=""Search Drive""
+-          onkeyup=${props.filterQuery}
+-          value=${props.filterInput}/>
++    <div class=""Browser Browser-viewType--${props.defaultViewType}"">
++      <header class=""Browser-header"">
++        <div class=""Browser-search"" aria-hidden=""${!props.isSearchVisible}"">
++          <input type=""text"" class=""Browser-searchInput"" placeholder=""Search""
++                 onkeyup=${props.filterQuery} value=""${props.filterInput}""/>
++          <button type=""button"" class=""Browser-searchClose"" 
++                  onclick=${props.toggleSearch}>
++            <svg class=""UppyIcon"" viewBox=""0 0 19 19"">
++              <path d=""M17.318 17.232L9.94 9.854 9.586 9.5l-.354.354-7.378 7.378h.707l-.62-.62v.706L9.318 9.94l.354-.354-.354-.354L1.94 1.854v.707l.62-.62h-.706l7.378 7.378.354.354.354-.354 7.378-7.378h-.707l.622.62v-.706L9.854 9.232l-.354.354.354.354 7.378 7.378.708-.707-7.38-7.378v.708l7.38-7.38.353-.353-.353-.353-.622-.622-.353-.353-.354.352-7.378 7.38h.708L2.56 1.23 2.208.88l-.353.353-.622.62-.353.355.352.353 7.38 7.38v-.708l-7.38 7.38-.353.353.352.353.622.622.353.353.354-.353 7.38-7.38h-.708l7.38 7.38z""/>
++            </svg>
++          </button>
++        </div>
++        <div class=""Browser-headerBar"">
++          <button type=""button"" class=""Browser-searchToggle""
++                  onclick=${props.toggleSearch}>
++            <svg class=""UppyIcon"" viewBox=""0 0 100 100"">
++              <path d=""M87.533 80.03L62.942 55.439c3.324-4.587 5.312-10.207 5.312-16.295 0-.312-.043-.611-.092-.908.05-.301.093-.605.093-.922 0-15.36-12.497-27.857-27.857-27.857-.273 0-.536.043-.799.08-.265-.037-.526-.08-.799-.08-15.361 0-27.858 12.497-27.858 27.857 0 .312.042.611.092.909a5.466 5.466 0 0 0-.093.921c0 15.36 12.496 27.858 27.857 27.858.273 0 .535-.043.8-.081.263.038.524.081.798.081 5.208 0 10.071-1.464 14.245-3.963L79.582 87.98a5.603 5.603 0 0 0 3.976 1.647 5.621 5.621 0 0 0 3.975-9.597zM39.598 55.838c-.265-.038-.526-.081-.8-.081-9.16 0-16.612-7.452-16.612-16.612 0-.312-.042-.611-.092-.908.051-.301.093-.605.093-.922 0-9.16 7.453-16.612 16.613-16.612.272 0 .534-.042.799-.079.263.037.525.079.799.079 9.16 0 16.612 7.452 16.612 16.612 0 .312.043.611.092.909-.05.301-.094.604-.094.921 0 9.16-7.452 16.612-16.612 16.612-.274 0-.536.043-.798.081z""/>
++            </svg>
++          </button>
++          ${Breadcrumbs({
++            getFolder: props.getFolder,
++            directories: props.directories,
++            title: props.title
++          })}
++          <button type=""button"" onclick=${props.logout} class=""Browser-userLogout"">Log out</button>
++        </div>
+       </header>
+-      <div class=""Browser-subHeader"">
+-        ${Breadcrumbs({
+-          getFolder: props.getFolder,
+-          directories: props.directories
+-        })}
+-        <button onclick=${props.logout} class=""Browser-userLogout"">Log out</button>
+-      </div>
+       <div class=""Browser-body"">
+-        <main class=""Browser-content"">
+-          ${Table({
+-            columns: [{
+-              name: 'Name',
+-              key: 'title'
+-            }],
+-            folders: filteredFolders,
+-            files: filteredFiles,
+-            activeRow: props.isActiveRow,
+-            sortByTitle: props.sortByTitle,
+-            sortByDate: props.sortByDate,
+-            handleFileClick: props.addFile,
+-            handleFolderClick: props.getNextFolder,
+-            getItemName: props.getItemName,
+-            getItemIcon: props.getItemIcon,
+-            handleScroll: props.handleScroll
+-          })}
+-        </main>
++        ${Table({
++          columns: [{
++            name: 'Name',
++            key: 'title'
++          }],
++          folders: filteredFolders,
++          files: filteredFiles,
++          isGrid: false,",it seems this attribute is never used,2017-07-02 11:07:12
+228,"@@ -12,6 +12,39 @@ Best used together with a simple file source plugin, such as [FileInput][] or [D
+ 
+ ## Options
+ 
++```js","This could perhaps use an: ""All of the options, and their defaults"" intro?",2018-02-15 15:02:57
+795,"@@ -12,7 +12,6 @@ module.exports = class Provider extends RequestClient {
+     super(uppy, opts)
+     this.provider = opts.provider
+     this.id = this.provider
+-    this.authProvider = opts.authProvider || this.provider",I realised that this is not used anywhere,2020-06-29 12:40:35
+54,"@@ -12,9 +12,14 @@ module.exports = class Multipart extends Plugin {
+     // Default options
+     const defaultOptions = {
+       fieldName: 'files[]',
++      fields: null,","May need a better name, this option indicates which file `meta` properties should be sent along as FormData fields. If null everything is sent along. It's necessary because S3 rejects requests that contain form fields it doesn't recognise.",2017-06-23 09:51:24
+55,"@@ -12,9 +12,14 @@ module.exports = class Multipart extends Plugin {
+     // Default options
+     const defaultOptions = {
+       fieldName: 'files[]',
++      fields: null,
+       responseUrlFieldName: 'url',
+       bundle: true,
+-      headers: {}
++      headers: {},
++      getUploadUrl (xhr) {
++        const resp = JSON.parse(xhr.response)
++        return resp[this.responseUrlFieldName]
++      }",This option allows the S3 plugin to take the uploaded url from S3's XML response,2017-06-23 09:52:39
+89,"@@ -120,8 +120,10 @@ module.exports = class Transloadit extends Plugin {
+       signature: options.signature
+     }).then((assembly) => {
+       // Store the list of assemblies related to this upload.
+-      const uploadsAssemblies = Object.assign({}, this.state.uploadsAssemblies)
+-      uploadsAssemblies[uploadID] = (uploadsAssemblies[uploadID] || []).concat([ assembly.assembly_id ])
++      const assemblyList = this.state.uploadsAssemblies[uploadID]
++      const uploadsAssemblies = Object.assign({}, this.state.uploadsAssemblies, {
++        [uploadID]: assemblyList.concat([ assembly.assembly_id ])
++      })
+ ",Should this be `this.state.transloadit.uploadsAssemblies`? If `assemblies` are transloadit-related-only.,2017-08-24 16:02:04
+405,"@@ -121,8 +122,10 @@ module.exports = class AwsS3Multipart extends Plugin {
+ 
+     const filename = encodeURIComponent(key)
+     const uploadIdEnc = encodeURIComponent(uploadId)
+-    return this.client.post(`s3/multipart/${uploadIdEnc}/complete?key=${filename}`, { parts })
+-      .then(assertServerError)
++    return this.client.post(`s3/multipart/${uploadIdEnc}/complete?key=${filename}`, {
++      parts,
++      metadata: file.meta","S3 multipart uploads need metadata to be assigned when the upload is _created_, not when it's complete. it should not be necessary to send it in this request",2019-02-28 14:02:56
+127,"@@ -122,13 +122,15 @@ function getFileType (file) {
+     'mp3': 'audio/mp3'
+   }
+ 
+-  // no smart detection for remote files, just trust the provider
++  const fileExtension = getFileNameAndExtension(file.name)[1]
++
+   if (file.isRemote) {
+-    return Promise.resolve(file.type.split('/'))
++    // some providers do not support for file types
++    let mime = file.type ? file.type : extensionsToMime[fileExtension]
++    const type = mime ? mime.split('/') : emptyFileType
++    return Promise.resolve(type)","Was going to suggest this when I read the mime type comment below, but you already did it :D ",2017-10-16 08:14:08
+504,"@@ -122,28 +122,17 @@ Even though bundled in this repo, the website is regarded as a separate project.
+ 
+ ### Local previews
+ 
+-It is recommended to exclude `./website/public/` from your editor if you want efficient searches.
+-
+-To install the required node modules, type:
+-
+-```bash
+-npm install && cd website && npm install && cd ..
+-```
+-
+-For local previews on http://localhost:4000, type:
+-
+-```bash
+-npm run web:start # that gets you just the website. if you need companion, etc. you can use `npm start` instead
+-```
+-
+-This will watch the website, as well as Uppy, as the examples, and rebuild everything and refresh your browser as files change.
++1. `npm install`
++2. `cd website && npm install && cd ..` (even if you ran `npm run bootstrap` before)","after a root npm install you need to npm run bootstrap again, so this could read
+
+```
+1. `npm install`
+1. `npm run bootstrap`
+1. `cd website && npm install && cd -`
+...
+```",2019-06-07 12:03:06
+71,"@@ -123,9 +139,9 @@ module.exports = class Multipart extends Plugin {
+           'Content-Type': 'application/json'
+         },
+         body: JSON.stringify(Object.assign({}, file.remote.body, {
+-          endpoint: this.opts.endpoint,
++          endpoint: opts.endpoint,
+           size: file.data.size,
+-          fieldname: this.opts.fieldName
++          fieldname: opts.fieldName
+         }))",Should add support for `meta` and FormData-less uploads to uppy-server too.,2017-07-04 11:15:09
+554,"@@ -125,10 +122,8 @@ Even though bundled in this repo, the website is regarded as a separate project.
+ ### Local previews
+ 
+ 1. `npm install`
+-2. `npm run bootstrap`
+-3. `cd website && npm install && cd ..`
+-4. `npm start`
+-5. Go to http://localhost:4000. Your changes in `/website` and `/packages/@uppy` will be watched, your browser will refresh as files change.
++2. `npm start`
++3. Go to http://localhost:4000. Your changes in `/website` and `/packages/@uppy` will be watched, your browser will refresh as files change.","This got automatically overwritten for me, I think, we have to change the `.github/CONTRIBUTING.md` instead, as it says on the top of this file.",2019-07-17 18:48:41
+693,"@@ -125,21 +149,36 @@ class AddFiles extends Component {
+     )
+   }
+ 
++  renderAcquirers = (acquirers) => {
++    // Group last two buttons in <nobr>, so we don’t end up with
++    // just one button on a new line
++    const acquirersWithoutLastTwo = [...acquirers]
++    const lastTwoAcquirers = acquirersWithoutLastTwo.splice(acquirers.length - 2, acquirers.length)
++
++    return (
++      <div class=""uppy-DashboardTabs-list"" role=""tablist"">
++        {this.renderMyDeviceAcquirer()}
++        {acquirersWithoutLastTwo.map((acquirer) => this.renderAcquirer(acquirer))}
++        <nobr role=""presentation"">","MDN is not a fan of nobr: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/nobr
+should we use a span with `white-space: nowrap` instead?",2020-03-09 14:43:37
+895,"@@ -127,3 +127,7 @@ exports.getSize = (item) => {
+   }
+   return item.total_size
+ }
++
++exports.getItemTopic = (item) => {
++  return item.topic","Is it always available, or should we check for undefined?",2020-09-28 19:52:47
+464,"@@ -128,40 +128,51 @@ module.exports = function FileItem (props) {
+           onPauseResumeCancelRetry={onPauseResumeCancelRetry}
+           file={file}
+           error={error}
++          isUploaded={isUploaded}
+           {...props} />","Great, spent about an hour trying to figure out why the progress indicator remained a `<button>` on master, but turned into a `<div>` in your PR, if the PR is not touching the logic of that component 🙀 😂 ",2019-05-16 10:01:22
+109,"@@ -128,9 +128,9 @@ class Uppy {
+    */
+   setState (stateUpdate) {
+     const newState = Object.assign({}, this.state, stateUpdate)
+-    this.emit('core:state-update', this.state, newState, stateUpdate)
+ 
+     this.state = newState
++    this.emit('core:state-update', this.state, newState, stateUpdate)","`this.state` is the same as `newState ` at this point, so if we go this route, we have to save previous state, something like:
+
+```js
+const prevState = Object.assign({}, this.state)
+this.state = newState
+...
+```",2017-09-13 17:47:46
+326,"@@ -129,5 +129,15 @@
+     ""prepare"": ""lerna bootstrap --hoist"",
+     ""contributors"": ""githubcontrib --owner transloadit --repo uppy --cols 6 $([ \""${GITHUB_TOKEN:-}\"" == \""\"" ] && echo \""\"" || echo \""--authToken ${GITHUB_TOKEN}\"") --showlogin true --sortOrder desc"",
+     ""contributors:save"": ""replace-x -m '<!--contributors-->[\\s\\S]+<!--/contributors-->' \""<!--contributors-->\n## Contributors\n\n$(npm run --silent contributors)\n<!--/contributors-->\"" README.md""
++  },
++  ""jest"": {
++    ""automock"": false,
++    ""collectCoverage"": true,
++    ""collectCoverageFrom"": [
++      ""packages/**/src/**""
++    ],
++    ""testMatch"": [
++      ""**/packages/**/*.test.js""
++    ]",Wouldn’t a separate [`jest.config.js`](https://jestjs.io/docs/en/configuration.html) be better since that’s how we are doing it with all other build tools?,2018-07-24 03:19:01
+284,"@@ -13,19 +13,22 @@ const { defaultTabIcon } = require('./icons')
+ // MIT licence, https://github.com/ghosh/micromodal/blob/master/LICENSE.md
+ // Copyright (c) 2017 Indrashish Ghosh
+ const FOCUSABLE_ELEMENTS = [
+-  'a[href]',
+-  'area[href]',
+-  'input:not([disabled]):not([type=""hidden""]):not([aria-hidden])',
+-  'select:not([disabled]):not([aria-hidden])',
+-  'textarea:not([disabled]):not([aria-hidden])',
+-  'button:not([disabled]):not([aria-hidden])',
+-  'iframe',
+-  'object',
+-  'embed',
+-  '[contenteditable]',
+-  '[tabindex]:not([tabindex^=""-""])'
++  'a[href]:not([tabindex^=""-""]):not([inert]):not([aria-hidden])',
++  'area[href]:not([tabindex^=""-""]):not([inert]):not([aria-hidden])',
++  'input:not([disabled]):not([inert]):not([aria-hidden])',
++  'select:not([disabled]):not([inert]):not([aria-hidden])',
++  'textarea:not([disabled]):not([inert]):not([aria-hidden])',
++  'button:not([disabled]):not([inert]):not([aria-hidden])',
++  'iframe:not([tabindex^=""-""]):not([inert]):not([aria-hidden])',
++  'object:not([tabindex^=""-""]):not([inert]):not([aria-hidden])',
++  'embed:not([tabindex^=""-""]):not([inert]):not([aria-hidden])',
++  '[contenteditable]:not([tabindex^=""-""]):not([inert]):not([aria-hidden])',
++  '[tabindex]:not([tabindex^=""-""]):not([inert]):not([aria-hidden])'","good improvements :+1: Does the `:not([inert])` thing actually do anything? I thought any children of `[inert]` elements should also not be interactive, that's not possible to do with CSS selectors though.",2018-05-29 09:27:23
+549,"@@ -1304,11 +1311,10 @@ class Uppy {
+         return this._runUpload(uploadID)
+       })
+       .catch((err) => {
+-        const message = typeof err === 'object' ? err.message : err
+-        const details = typeof err === 'object' ? err.details : null
+-        this.log(`${message} ${details}`)
+-        this.info({ message: message, details: details }, 'error', 4000)
+-        return Promise.reject(typeof err === 'object' ? err : new Error(err))
++        if (err.isRestriction) {
++          this.emit('restriction-failed', null, err)","@goto-bus-stop not too weird, `null, err`? I guess `err` should have been the first argument when this event was added originally, but that’s what we have now.",2019-07-15 11:46:56
+574,"@@ -1317,11 +1309,18 @@ class Uppy {
+         return this._runUpload(uploadID)
+       })
+       .catch((err) => {
++        const message = typeof err === 'object' ? err.message : err
++        const details = (typeof err === 'object' && err.details) ? err.details : ''
++
+         if (err.isRestriction) {
+           this.emit('restriction-failed', null, err)
+-          return onError(err)
++          this.log(`${message} ${details}`, 'info')
++          this.info({ message: message, details: details }, 'info', 5000)",Do we not need to `throw` the error in case of restriction too (so that the promise rejects)?,2019-08-13 21:02:37
+572,"@@ -1318,8 +1319,9 @@ class Uppy {
+       .catch((err) => {
+         if (err.isRestriction) {
+           this.emit('restriction-failed', null, err)
++          return onError(err)","`return` isn't needed here (we should either `return Promise.reject(...)`, or `throw new Error(...)`).
+
+I'd move the `onError()` function here, and manage `type` by assigning it to either `'info'` or `'error'`. What do you think, could that be easier to read?",2019-08-13 11:25:01
+498,"@@ -132,7 +133,13 @@ module.exports.addProviderOptions = (options, grantConfig) => {
+     if (grantConfig[authProvider]) {
+       // explicitly add providerOptions so users don't override other providerOptions.
+       grantConfig[authProvider].key = providerOptions[authProvider].key
+-      grantConfig[authProvider].secret = providerOptions[authProvider].secret
++
++      // only read and override a secret from file if such a file is not undefined
++      if (typeof providerOptions[authProvider].secretFile === 'string') {","I don't think there's a need for this check here. There's no such property as `secretFile`. Also, at this point, the value of `.secret` is only available in memory (and was probably loaded with [this](https://github.com/transloadit/uppy/blob/a8e17bee5fc6a93fb2298cfca6ee45c9cc0cb7bc/packages/%40uppy/companion/src/standalone/helper.js#L35)), so there's no need to read from file anymore.",2019-06-05 14:18:16
+349,"@@ -134,7 +134,9 @@ module.exports = class Plugin {
+     }
+ 
+     this.uppy.log(`Not installing ${callerPluginName}`)
+-    throw new Error(`Invalid target option given to ${callerPluginName}`)
++    throw new Error(`Invalid target option given to ${callerPluginName}. Please make sure that the element 
++      exists on the page, or that the plugin you are targeting has been installed. Check that the <script> tag initializing Uppy 
++      comes at the bottom of the page, before the </body> (see https://github.com/transloadit/uppy/issues/1042).`)","could be misread as `<body>`, maybe something redundant but very clear like ""before the closing `</body>` tag""?",2018-09-06 11:20:40
+189,"@@ -134,8 +134,8 @@
+         background-color: $color-cornflower-blue;
+         color: $color-white;
+ 
+-        &:hover { 
+-          background-color: darken($color-cornflower-blue, 20%); 
++        &:hover {","Should I to remove this change? I don't know how it happend, maybe Atom removed whitespace at line end when I saved it on previous commits.",2018-01-05 18:36:41
+943,"@@ -135,13 +135,21 @@ module.exports = class AwsS3 extends Plugin {
+     const valid = typeof params === 'object' && params &&
+       typeof params.url === 'string' &&
+       (typeof params.fields === 'object' || params.fields == null) &&","woops my bad, applying those caused this line to become wrong.
+```suggestion
+      (typeof params.fields === 'object' || params.fields == null)
+```",2020-11-16 12:02:58
+914,"@@ -135,13 +135,23 @@ module.exports = class AwsS3 extends Plugin {
+     const valid = typeof params === 'object' && params &&
+       typeof params.url === 'string' &&
+       (typeof params.fields === 'object' || params.fields == null) &&
+-      (params.method == null || /^(put|post)$/i.test(params.method))
++      params.method == null;","based on my other comment, I think we can remove this line completely",2020-11-02 10:52:45
+912,"@@ -135,13 +135,23 @@ module.exports = class AwsS3 extends Plugin {
+     const valid = typeof params === 'object' && params &&
+       typeof params.url === 'string' &&
+       (typeof params.fields === 'object' || params.fields == null) &&
+-      (params.method == null || /^(put|post)$/i.test(params.method))
++      params.method == null;
+ 
+     if (!valid) {
+       const err = new TypeError(`AwsS3: got incorrect result from 'getUploadParameters()' for file '${file.name}', expected an object '{ url, method, fields, headers }' but got '${JSON.stringify(params)}' instead.\nSee https://uppy.io/docs/aws-s3/#getUploadParameters-file for more on the expected format.`)
+       console.error(err)
+       throw err
+     }
++
++    const methodIsValid = /^(put|post)$/i.test(params.method);","this will fail if `params.method` is `null`. I think it should be:
+
+```suggestion
+    const methodIsValid = params.method == null || /^(put|post)$/i.test(params.method)
+```",2020-11-02 10:50:09
+913,"@@ -135,13 +135,23 @@ module.exports = class AwsS3 extends Plugin {
+     const valid = typeof params === 'object' && params &&
+       typeof params.url === 'string' &&
+       (typeof params.fields === 'object' || params.fields == null) &&
+-      (params.method == null || /^(put|post)$/i.test(params.method))
++      params.method == null;
+ 
+     if (!valid) {
+       const err = new TypeError(`AwsS3: got incorrect result from 'getUploadParameters()' for file '${file.name}', expected an object '{ url, method, fields, headers }' but got '${JSON.stringify(params)}' instead.\nSee https://uppy.io/docs/aws-s3/#getUploadParameters-file for more on the expected format.`)
+       console.error(err)
+       throw err
+     }
++
++    const methodIsValid = /^(put|post)$/i.test(params.method);
++
++    if (!methodIsValid) {
++      const err = new TypeError(`AwsS3: got incorrect method from 'getUploadParameters()' for file '${file.name}', expected  'put,post' but got '${params.method}' instead.\nSee https://uppy.io/docs/aws-s3/#getUploadParameters-file for more on the expected format.`)
++      console.error(err)
++      throw err
++    }
++
++","```suggestion
+```",2020-11-02 10:50:25
+942,"@@ -135,13 +135,23 @@ module.exports = class AwsS3 extends Plugin {
+     const valid = typeof params === 'object' && params &&
+       typeof params.url === 'string' &&
+       (typeof params.fields === 'object' || params.fields == null) &&
+-      (params.method == null || /^(put|post)$/i.test(params.method))
++      params.method == null;
+ 
+     if (!valid) {
+       const err = new TypeError(`AwsS3: got incorrect result from 'getUploadParameters()' for file '${file.name}', expected an object '{ url, method, fields, headers }' but got '${JSON.stringify(params)}' instead.\nSee https://uppy.io/docs/aws-s3/#getUploadParameters-file for more on the expected format.`)
+       console.error(err)
+       throw err
+     }
++
++    const methodIsValid = params.method == null || /^(put|post)$/i.test(params.method)
++
++    if (!methodIsValid) {
++      const err = new TypeError(`AwsS3: got incorrect method from 'getUploadParameters()' for file '${file.name}', expected  'put,post' but got '${params.method}' instead.\nSee https://uppy.io/docs/aws-s3/#getUploadParameters-file for more on the expected format.`)","little phrasing nit
+```suggestion
+      const err = new TypeError(`AwsS3: got incorrect method from 'getUploadParameters()' for file '${file.name}', expected  'put' or 'post' but got '${params.method}' instead.\nSee https://uppy.io/docs/aws-s3/#getUploadParameters-file for more on the expected format.`)
+```",2020-11-16 11:57:30
+919,"@@ -135,65 +139,6 @@ module.exports.app = (options = {}) => {
+   return app
+ }
+ 
+-/**
+- * the socket is used to send progress events during an upload
+- *
+- * @param {object} server
+- */
+-module.exports.socket = (server) => {
+-  const wss = new SocketServer({ server })
+-  const redisClient = redis.client()
+-
+-  // A new connection is usually created when an upload begins,
+-  // or when connection fails while an upload is on-going and,
+-  // client attempts to reconnect.
+-  wss.on('connection', (ws, req) => {
+-    // @ts-ignore
+-    const fullPath = req.url
+-    // the token identifies which ongoing upload's progress, the socket
+-    // connection wishes to listen to.
+-    const token = fullPath.replace(/^.*\/api\//, '')
+-    logger.info(`connection received from ${token}`, 'socket.connect')
+-
+-    /**
+-     *
+-     * @param {{action: string, payload: object}} data
+-     */
+-    function sendProgress (data) {
+-      ws.send(jsonStringify(data), (err) => {
+-        if (err) logger.error(err, 'socket.progress.error', shortenToken(token))
+-      })
+-    }
+-
+-    // if the redisClient is available, then we attempt to check the storage
+-    // if we have any already stored progress data on the upload.
+-    if (redisClient) {
+-      redisClient.get(`${STORAGE_PREFIX}:${token}`, (err, data) => {
+-        if (err) logger.error(err, 'socket.redis.error', shortenToken(token))
+-        if (data) {
+-          const dataObj = JSON.parse(data.toString())
+-          if (dataObj.action) sendProgress(dataObj)
+-        }
+-      })
+-    }
+-
+-    emitter().emit(`connection:${token}`)
+-    emitter().on(token, sendProgress)
+-
+-    ws.on('message', (jsonData) => {
+-      const data = JSON.parse(jsonData.toString())
+-      // whitelist triggered actions
+-      if (['pause', 'resume', 'cancel'].includes(data.action)) {
+-        emitter().emit(`${data.action}:${token}`)
+-      }
+-    })
+-
+-    ws.on('close', () => {
+-      emitter().removeListener(token, sendProgress)
+-    })
+-  })
+-}
+-",this was moved into a [separate file](https://github.com/transloadit/uppy/blob/c5e3d8171281d5fce60dc8e59f32a564b4ef4668/packages/%40uppy/companion/src/server/socket.js) to reduce rowdiness,2020-11-11 11:20:32
+731,"@@ -136,14 +136,34 @@ describe('validate upload data', () => {
+       .then((res) => expect(res.body.error).toBe('unsupported HTTP METHOD specified'))
+   })
+ 
+-  test('valid upload data is allowed', () => {
++  test('valid upload data is allowed - tus', () => {
+     return request(authServer)
+       .post('/drive/get/README.md')
+       .set('uppy-auth-token', token)
+       .set('Content-Type', 'application/json')
+       .send({
+         endpoint: 'http://master.tus.com/files',
+         protocol: 'tus',
++        httpMethod: 'POST',
++        headers: {
++          customheader: 'header value'
++        },
++        metadata: {
++          mymetadata: 'matadata value'
++        },
++        fieldname: 'uploadField'
++      })
++      .expect(200)
++  })
++
++  test('valid upload data is allowed - s3-multipart', () => {
++    return request(authServer)
++      .post('/drive/get/README.md')
++      .set('uppy-auth-token', token)
++      .set('Content-Type', 'application/json')
++      .send({
++        endpoint: 'http://master.tus.com/files',",Is that endpoint correct?,2020-04-14 11:45:11
+147,"@@ -136,16 +170,16 @@ const ProgressBarUploading = (props) => {
+           ? html`<div title=""Uploading"">${pauseResumeButtons(props)} Uploading... ${throttledProgressDetails(props)}</div>`
+           : html`<div title=""Paused"">${pauseResumeButtons(props)} Paused・${props.totalProgress}%</div>`
+         : null
+-        }
++      }
+     </div>
+   `
+ }
+ 
+ const ProgressBarComplete = ({ totalProgress, i18n }) => {
+   return html`
+-    <div class=""UppyStatusBar-content"">
++    <div class=""UppyStatusBar-content"" role=""alert"">","`alert` is a role for very important information, i think the progress is not _that_ important—would `status` be more appropriate?",2017-12-03 14:44:28
+926,"@@ -136,7 +136,8 @@ class MarkdownTextarea {
+         'url',
+         'instagram',
+         'google-drive',
+-        'dropbox'
++        'dropbox',
++        'box'","excluding from examples in the meantime
+```suggestion
+        'dropbox'
+```",2020-11-13 09:12:22
+774,"@@ -137,7 +137,7 @@ class OneDrive extends Provider {
+   _error (err, resp) {
+     if (resp) {
+       const fallbackMsg = `request to ${this.authProvider} returned ${resp.statusCode}`
+-      const errMsg = resp.body.error ? resp.body.error.message : fallbackMsg
++      const errMsg = (resp.body || {}).error ? resp.body.error.message : fallbackMsg",this change can be ignored. I accidentally checked out of [this branch](https://github.com/transloadit/uppy/pull/2264/files),2020-05-17 19:43:52
+300,"@@ -137,8 +137,8 @@
+     ""build:lib"": ""babel --version && node ./bin/build-lib.js"",
+     ""build"": ""npm-run-all --parallel build:js build:css --serial build:gzip size"",
+     ""clean"": ""rm -rf lib && rm -rf dist"",
+-    ""lint:fix"": ""eslint src test website/scripts website/build-examples.js website/update.js website/themes/uppy/source/js/common.js --fix"",
+-    ""lint"": ""eslint src test website/scripts website/build-examples.js website/update.js website/themes/uppy/source/js/common.js"",
++    ""lint:fix"": ""npm run lint -- --fix"",
++    ""lint"": ""eslint packages/*/src packages/@uppy/*/src test website/scripts website/build-examples.js website/update.js website/themes/uppy/source/js/common.js"",","As opposed to whitelisting dirs here, may i propose doing `eslint .` and adding a blacklist in `.eslintignore`? While setting it up, if it takes very long, `env DEBUG=eslint:cli-engine eslint .` will show you what files it is crunching on that you'll likely also want to blacklist.
+
+Two reasons for doing it:
+- those with eslint-enabled editors won't get warnings about files that we don't care about (.eslintignore is parsed while this npm script is not)
+- when we add new things, we'll have to opt-out of linting, vs opting-in, which feels safer",2018-06-18 08:27:28
+518,"@@ -14,12 +14,17 @@ function upload (files, opts = {}) {
+   addTransloaditPlugin(uppy, opts)
+ 
+   files.forEach((file) => {
+-    uppy.addFile({
+-      data: file,
+-      type: file.type,
+-      name: file.name,
+-      meta: file.meta || {}
+-    })","Not sure about this one, should it be wrapped in try/catch, @goto-bus-stop?",2019-06-20 15:58:41
+929,"@@ -14,6 +14,7 @@
+     <li><label for=""opts-ScreenCapture""><input type=""checkbox"" id=""opts-ScreenCapture"" checked/> Screen Capture</label></li>
+     <li><label for=""opts-GoogleDrive""><input type=""checkbox"" id=""opts-GoogleDrive"" checked/> Google Drive</label></li>
+     <li><label for=""opts-Dropbox""><input type=""checkbox"" id=""opts-Dropbox"" checked/> Dropbox</label></li>
++    <li><label for=""opts-Box""><input type=""checkbox"" id=""opts-Box"" checked/> Box</label></li>","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:13:21
+959,"@@ -14,7 +14,7 @@
+   ""rules"": {
+     ""jsx-quotes"": [""error"", ""prefer-double""],
+     ""compat/compat"": [""error""],
+-    ""react/jsx-handler-names"": [""warn""], // maybe we want to do this in the future?
++    ""react/jsx-handler-names"": [""off""],","Disabled because we don't really follow the rule anywhere, and following it would conflict with our convention of using `_`-prefixed names for private class methods.",2020-11-30 09:50:25
+325,"@@ -14,7 +14,7 @@ exports.config = Object.assign(base.config, {
+     { browserName: 'chrome', version: '50.0', platform: 'Windows 7' },
+     { browserName: 'MicrosoftEdge', version: '14.14393', platform: 'Windows 10' },
+     // { browserName: 'safari', version: '11.0', platform: 'macOS 10.12' },
+-    { browserName: 'safari', version: '11.0', platformName: 'iOS', platformVersion: '10.0', deviceOrientation: 'portrait', deviceName: 'iPhone 6 Simulator', appiumVersion: '1.7.1' },
++    { browserName: 'safari', version: '10.0', platformName: 'iOS', platformVersion: '10.0', deviceOrientation: 'portrait', deviceName: 'iPhone 6 Simulator', appiumVersion: '1.7.1' },
+     { browserName: 'chrome', platformName: 'Android', platformVersion: '6.0', deviceOrientation: 'portrait', deviceName: 'Android Emulator', appiumVersion: '1.7.1' }","🥇wow, thanks!",2018-07-23 17:04:47
+346,"@@ -14,9 +14,9 @@ function defaultGetAssemblyOptions (file, options) {
+   }
+ }
+ 
+-const UPPY_SERVER = 'https://api2.transloadit.com/uppy-server'
+-// Regex used to check if an uppy-server address is run by Transloadit.
+-const TL_UPPY_SERVER = /https?:\/\/api2(?:-\w+)?\.transloadit\.com\/uppy-server/
++const COMPANION = 'https://api2.transloadit.com/companion'
++// Regex used to check if an companion address is run by Transloadit.
++const TL_COMPANION = /https?:\/\/api2(?:-\w+)?\.transloadit\.com\/companion/",Would be nice to throw an error if anyone uses the old URL maybe. breakage because of this change would be very hard to debug for users I think,2018-09-03 12:07:29
+551,"@@ -141,16 +215,15 @@
+     ""web:build-examples"": ""cd website && node build-examples.js"",
+     ""web:build"": ""npm-run-all web:inject-bundles-misc web:generate web:build-examples web:inject-frontpagecodesample"",
+     ""web:bundle-watch-inject"": ""onchange 'packages/uppy/dist/**/*.css' 'packages/uppy/dist/**/*.js' --initial --verbose -- npm run web:inject-bundles-misc"",
+-    ""web:clean"": ""cd website && touch db.json && ./node_modules/.bin/hexo clean"",
++    ""web:clean"": ""cd website && touch db.json && ../node_modules/.bin/hexo clean"",",Don’t we run these `web:` scripts from root? Why `..`?,2019-07-15 14:16:59
+747,"@@ -141,7 +141,6 @@ fi_FI.strings = {
+   streamActive: 'Jako aktiivinen',
+   streamPassive: 'Jako passiivinen',
+   micDisabled: 'Käyttäjä on estänyt mikrofonin',
+-  micIsOn: 'Mikrofoni on päällä',",Intended @arturi?,2020-04-22 07:01:58
+481,"@@ -142,4 +142,4 @@ function defaultStore () {
+ 
+ A pattern like this, where users can pass options via a function call if necessary, is recommended.
+ 
+-See the [./src/store](https://github.com/transloadit/uppy/tree/master/src/store) folder in the repository for more inspiration.
++See the [./src/store](https://github.com/transloadit/uppy/tree/master/packages/%40uppy/store-default) folder in the repository for more inspiration.","```suggestion
+See the [@uppy/store-default](https://github.com/transloadit/uppy/tree/master/packages/%40uppy/store-default) package for more inspiration.
+````",2019-05-24 18:01:59
+766,"@@ -142,6 +142,7 @@ module.exports = class DragDrop extends Plugin {
+     const restrictions = this.uppy.opts.restrictions
+     return (
+       <input
++        id={'input-' + this.id}",Should it be `'uppy-input-`?,2020-05-07 14:27:20
+768,"@@ -142,6 +142,7 @@ module.exports = class DragDrop extends Plugin {
+     const restrictions = this.uppy.opts.restrictions
+     return (
+       <input
++        id={'uppy-input-' + this.id}",we might want to do `this.uppy.id + this.id` in case someone has two instances of uppy with drag-drop,2020-05-09 11:38:04
+755,"@@ -142,8 +147,25 @@ class Drive extends Provider {
+           .request()
+       }
+ 
++      let stopDataTransfer = false
+       requestStream
+-        .on('data', (chunk) => onData(null, chunk))
++        .on('response', (resp) => {
++          if (resp.statusCode !== 200) {
++            stopDataTransfer = true","Nit/A possible simplification: perhaps we could add the `.on('data')` handler inside this function, only if the response status was 200, instead of keeping this separate variable?
+```js
+requestStream.on('response', (resp) => {
+  if (resp.statusCode === 200) {
+    requestStream.on('data', chunk => onData(null, chunk))
+  } else {
+    // handle error
+  }
+})
+```",2020-04-27 12:14:39
+46,"@@ -144,59 +144,63 @@ class Uppy {
+   }
+ 
+   addFile (file) {
+-    const updatedFiles = Object.assign({}, this.state.files)
+-
+-    const fileName = file.name || 'noname'
+-    const fileType = Utils.getFileType(file)
+-    const fileTypeGeneral = fileType[0]
+-    const fileTypeSpecific = fileType[1]
+-    const fileExtension = Utils.getFileNameAndExtension(fileName)[1]
+-    const isRemote = file.isRemote || false
+-
+-    const fileID = Utils.generateFileID(fileName)
+-
+-    const newFile = {
+-      source: file.source || '',
+-      id: fileID,
+-      name: fileName,
+-      extension: fileExtension || '',
+-      meta: {
+-        name: fileName
+-      },
+-      type: {
+-        general: fileTypeGeneral,
+-        specific: fileTypeSpecific
+-      },
+-      data: file.data,
+-      progress: {
+-        percentage: 0,
+-        uploadComplete: false,
+-        uploadStarted: false
+-      },
+-      size: file.data.size || 'N/A',
+-      isRemote: isRemote,
+-      remote: file.remote || '',
+-      preview: file.preview
+-    }
++    Utils.getFileType(file).then((fileType) => {
++      const updatedFiles = Object.assign({}, this.state.files)
++      const fileName = file.name || 'noname'
++      const fileExtension = Utils.getFileNameAndExtension(fileName)[1]
++      const isRemote = file.isRemote || false
++
++      const fileID = Utils.generateFileID(fileName)
++      const fileTypeGeneral = fileType[0]
++      const fileTypeSpecific = fileType[1]
++
++      const newFile = {
++        source: file.source || '',
++        id: fileID,
++        name: fileName,
++        extension: fileExtension || '',
++        meta: {
++          name: fileName
++        },
++        type: {
++          general: fileTypeGeneral,
++          specific: fileTypeSpecific
++        },
++        data: file.data,
++        progress: {
++          percentage: 0,
++          uploadComplete: false,
++          uploadStarted: false
++        },
++        size: file.data.size || 'N/A',
++        isRemote: isRemote,
++        remote: file.remote || '',
++        preview: file.preview
++      }
+ 
+-    if (fileTypeGeneral === 'image' && !isRemote) {
+-      newFile.preview = Utils.getThumbnail(file)
+-    }
++      if (Utils.isPreviewReady(fileTypeSpecific) && !isRemote) {
++        newFile.preview = Utils.getThumbnail(file)
++      }
+ 
+-    updatedFiles[fileID] = newFile
+-    this.setState({files: updatedFiles})
++      updatedFiles[fileID] = newFile
++      this.setState({files: updatedFiles})
+ 
+-    this.bus.emit('file-added', fileID)
+-    this.log(`Added file: ${fileName}, ${fileID}, mime type: ${fileType}`)
++      this.bus.emit('file-added', fileID)
++      this.log(`Added file: ${fileName}, ${fileID}, mime type: ${fileType}`)
+ 
+-    if (this.opts.autoProceed && !this.scheduledAutoProceed) {
+-      this.scheduledAutoProceed = setTimeout(() => {
+-        this.scheduledAutoProceed = null
+-        this.upload().catch((err) => {
+-          console.error(err.stack || err.message)
+-        })
+-      }, 4)
+-    }
++      if (!fileType) {
++        console.log('well, yeah, file type is fucking empty')",h*cking empty!,2017-06-13 13:04:27
+273,"@@ -144,6 +150,52 @@ module.exports = class Url extends Plugin {
+       })
+   }
+ 
++  handleDrop (e) {
++    e.preventDefault()
++    if (e.dataTransfer.items) {
++      const items = toArray(e.dataTransfer.items)
++      items.forEach((item) => {
++        if (item.kind === 'string' && item.type.match('^text/uri-list')) {",does this need to be a `.match()`? can't we just do `item.type === 'text/uri-list'`?,2018-05-22 08:23:30
+274,"@@ -144,6 +150,52 @@ module.exports = class Url extends Plugin {
+       })
+   }
+ 
++  handleDrop (e) {
++    e.preventDefault()
++    if (e.dataTransfer.items) {
++      const items = toArray(e.dataTransfer.items)
++      items.forEach((item) => {
++        if (item.kind === 'string' && item.type.match('^text/uri-list')) {
++          item.getAsString((url) => {
++            this.uppy.log(`[URL] Adding file from dropped url: ${url}`)
++            this.addFile(url)
++          })
++        }
++      })
++    }
++  }
++
++  handleDragOver (e) {
++    e.preventDefault()
++    this.el.classList.add('drag')
++  }
++
++  handleDragLeave (e) {
++    e.preventDefault()
++    this.el.classList.remove('drag')
++  }
++
++  handlePaste (e) {
++    if (e.clipboardData.items) {
++      const items = toArray(e.clipboardData.items)
++
++      // When a file is pasted, it appears as two items: file name string, then
++      // the file itself; Url then treats file name string as URL, which is wrong.
++      // This makes sure Url ignores paste event if it contains an actual file
++      const hasFiles = items.filter(item => item.kind === 'file').length > 0
++      if (hasFiles) return",great comment!,2018-05-22 08:23:39
+275,"@@ -144,6 +150,52 @@ module.exports = class Url extends Plugin {
+       })
+   }
+ 
++  handleDrop (e) {
++    e.preventDefault()
++    if (e.dataTransfer.items) {
++      const items = toArray(e.dataTransfer.items)
++      items.forEach((item) => {
++        if (item.kind === 'string' && item.type.match('^text/uri-list')) {
++          item.getAsString((url) => {
++            this.uppy.log(`[URL] Adding file from dropped url: ${url}`)
++            this.addFile(url)
++          })
++        }
++      })
++    }
++  }
++
++  handleDragOver (e) {
++    e.preventDefault()
++    this.el.classList.add('drag')
++  }
++
++  handleDragLeave (e) {
++    e.preventDefault()
++    this.el.classList.remove('drag')
++  }
++
++  handlePaste (e) {
++    if (e.clipboardData.items) {
++      const items = toArray(e.clipboardData.items)
++
++      // When a file is pasted, it appears as two items: file name string, then
++      // the file itself; Url then treats file name string as URL, which is wrong.
++      // This makes sure Url ignores paste event if it contains an actual file
++      const hasFiles = items.filter(item => item.kind === 'file').length > 0
++      if (hasFiles) return
++
++      items.forEach((item) => {
++        if (item.kind === 'string' && item.type.match('text/plain')) {",same q re `item.type === 'text/plain'`,2018-05-22 08:24:16
+598,"@@ -145,14 +145,17 @@ class Drive {
+       modifiedDate: adapter.getItemModifiedDate(item),
+       size: adapter.getItemSize(item),
+       custom: {
+-        isTeamDrive: adapter.isTeamDrive(item)
++        // @todo isTeamDrive is left for backward compatibility. We should remove it in the next
++        // major release.
++        isTeamDrive: adapter.isSharedDrive(item),",:+1: ,2019-09-23 14:12:37
+519,"@@ -146,57 +146,40 @@ module.exports = class StatusBar extends Plugin {
+ 
+     // TODO: move this to Core, to share between Status Bar and Dashboard
+     // (and any other plugin that might need it, too)
+-    const newFiles = Object.keys(files).filter((file) => {
+-      return !files[file].progress.uploadStarted &&
+-        !files[file].progress.preprocess &&
+-        !files[file].progress.postprocess
+-    })
+-
+-    const uploadStartedFiles = Object.keys(files).filter((file) => {
+-      return files[file].progress.uploadStarted
+-    })
+-
+-    const pausedFiles = uploadStartedFiles.filter((file) => {
+-      return files[file].isPaused
+-    })
+ 
+-    const completeFiles = Object.keys(files).filter((file) => {
+-      return files[file].progress.uploadComplete
+-    })
++    const filesArray = Object.keys(files).map(file => files[file])
+ 
+-    const erroredFiles = Object.keys(files).filter((file) => {
+-      return files[file].error
++    const newFiles = filesArray.filter((file) => {
++      return !file.progress.uploadStarted &&
++        !file.progress.preprocess &&
++        !file.progress.postprocess
+     })
+ 
+-    const inProgressFiles = Object.keys(files).filter((file) => {
+-      return !files[file].progress.uploadComplete &&
+-             files[file].progress.uploadStarted
+-    })
++    const uploadStartedFiles = filesArray.filter(file => file.progress.uploadStarted)
++    const pausedFiles = uploadStartedFiles.filter(file => file.isPaused)
++    const completeFiles = filesArray.filter(file => file.progress.uploadComplete)
++    const erroredFiles = filesArray.filter(file => file.error)
+ 
+-    const inProgressNotPausedFiles = inProgressFiles.filter((file) => {
+-      return !files[file].isPaused
++    const inProgressFiles = filesArray.filter((file) => {
++      return !file.progress.uploadComplete &&
++             file.progress.uploadStarted
+     })
+ 
+-    const startedFiles = Object.keys(files).filter((file) => {
+-      return files[file].progress.uploadStarted ||
+-        files[file].progress.preprocess ||
+-        files[file].progress.postprocess
+-    })
++    const inProgressNotPausedFiles = inProgressFiles.filter(file => !file.isPaused)
+ 
+-    const processingFiles = Object.keys(files).filter((file) => {
+-      return files[file].progress.preprocess || files[file].progress.postprocess
++    const startedFiles = filesArray.filter((file) => {
++      return file.progress.uploadStarted ||
++        file.progress.preprocess ||
++        file.progress.postprocess
+     })","I guess I can just use `startedFiles` in place of `uploadStarted`, since the first supersedes the last?",2019-06-21 14:45:43
+339,"@@ -146,6 +146,8 @@ module.exports.addProviderOptions = (options, grantConfig) => {
+       if (server.implicitPath) {
+         // no url builder is used for this because grant internally adds the path
+         grantConfig[authProvider].callback = `${server.implicitPath}${grantConfig[authProvider].callback}`
++      } else if (server.path) {
++        grantConfig[authProvider].callback = `${server.path}${grantConfig[authProvider].callback}`","callback to an explicit `path` is already handled internally by [grant.js](https://github.com/simov/grant/) so there's no need to add this condition here. This is why we are passing the `path` into the config [here](https://github.com/transloadit/uppy/blob/master/packages/%40uppy/companion/src/server/provider/index.js#L123-L127).
+
+Were you facing any issues with something that might be related to this behaviour? Otherwise I would say the existing implementation is fine as is.",2018-09-02 21:50:33
+459,"@@ -147,5 +147,7 @@
+       ""**/packages/**/*.test.js""
+     ]
+   },
+-  ""dependencies"": {}
++  ""dependencies"": {
++    ""lodash.debounce"": ""^4.0.8""
++  }
+ }",This should be in `@uppy/dashboard` dependencies probably?,2019-05-03 18:32:51
+45,"@@ -147,8 +146,46 @@ function runPromiseSequence (functions, ...args) {
+ //   return (!f && 'not a function') || (s && s[1] || 'anonymous')
+ // }
+ 
++function isPreviewReady (fileTypeSpecific) {
++  // list of images that browsers can preview
++  if (/^(jpeg|gif|png|svg|bmp)$/.test(fileTypeSpecific)) {
++    return true
++  }
++  return false
++}
++
++function getArrayBuffer (file) {
++  return new Promise(function (resolve, reject) {
++    var reader = new FileReader()
++    reader.addEventListener('load', function (e) {
++      // e.target.result is an ArrayBuffer
++      var arr = new Uint8Array(e.target.result)
++      resolve(arr)
++    })
++    reader.addEventListener('error', function (err) {
++      console.error('FileReader error' + err)
++      reject(err)
++    })
++    const chunk = file.data.slice(0, 4100)
++    reader.readAsArrayBuffer(chunk)
++  })
++}
++
+ function getFileType (file) {
+-  return file.type ? file.type.split('/') : ['', '']
++  if (file.type) {
++    return Promise.resolve(file.type.split('/'))
++  }
++
++  return getArrayBuffer(file).then((buffer) => {","I don't know in what situation `FileReader` would error, but it can—perhaps we should fall back to `['', '']` here if the file couldn't be read for some reason?",2017-06-13 13:02:32
+578,"@@ -147,82 +125,118 @@ module.exports = class AwsS3Multipart extends Plugin {
+ 
+   uploadFile (file) {
+     return new Promise((resolve, reject) => {
+-      const upload = new Uploader(file.data, Object.assign({
+-        // .bind to pass the file object to each handler.
+-        createMultipartUpload: this.limitRequests(this.opts.createMultipartUpload.bind(this, file)),
+-        listParts: this.limitRequests(this.opts.listParts.bind(this, file)),
+-        prepareUploadPart: this.opts.prepareUploadPart.bind(this, file),
+-        completeMultipartUpload: this.limitRequests(this.opts.completeMultipartUpload.bind(this, file)),
+-        abortMultipartUpload: this.limitRequests(this.opts.abortMultipartUpload.bind(this, file)),
+-
+-        limit: this.opts.limit || 5,
+-        onStart: (data) => {
+-          const cFile = this.uppy.getFile(file.id)
+-          this.uppy.setFileState(file.id, {
+-            s3Multipart: Object.assign({}, cFile.s3Multipart, {
+-              key: data.key,
+-              uploadId: data.uploadId,
+-              parts: []
+-            })
+-          })
+-        },
+-        onProgress: (bytesUploaded, bytesTotal) => {
+-          this.uppy.emit('upload-progress', file, {
+-            uploader: this,
+-            bytesUploaded: bytesUploaded,
+-            bytesTotal: bytesTotal
+-          })
+-        },
+-        onError: (err) => {
+-          this.uppy.log(err)
+-          this.uppy.emit('upload-error', file, err)
+-          err.message = `Failed because: ${err.message}`
+-
+-          this.resetUploaderReferences(file.id)
+-          reject(err)
+-        },
+-        onSuccess: (result) => {
+-          const uploadResp = {
+-            uploadURL: result.location
++      const onStart = (data) => {
++        const cFile = this.uppy.getFile(file.id)
++        this.uppy.setFileState(file.id, {
++          s3Multipart: {
++            ...cFile.s3Multipart,
++            key: data.key,
++            uploadId: data.uploadId,
++            parts: []
+           }
++        })
++      }
+ 
+-          this.resetUploaderReferences(file.id)
++      const onProgress = (bytesUploaded, bytesTotal) => {
++        this.uppy.emit('upload-progress', file, {
++          uploader: this,
++          bytesUploaded: bytesUploaded,
++          bytesTotal: bytesTotal
++        })
++      }
+ 
+-          this.uppy.emit('upload-success', file, uploadResp)
++      const onError = (err) => {
++        this.uppy.log(err)
++        this.uppy.emit('upload-error', file, err)
++        err.message = `Failed because: ${err.message}`
+ 
+-          if (result.location) {
+-            this.uppy.log('Download ' + upload.file.name + ' from ' + result.location)
+-          }
++        this.resetUploaderReferences(file.id)
++        reject(err)
++      }
+ 
+-          resolve(upload)
+-        },
+-        onPartComplete: (part) => {
+-          // Store completed parts in state.
+-          const cFile = this.uppy.getFile(file.id)
+-          if (!cFile) {
+-            return
+-          }
+-          this.uppy.setFileState(file.id, {
+-            s3Multipart: Object.assign({}, cFile.s3Multipart, {
+-              parts: [
+-                ...cFile.s3Multipart.parts,
+-                part
+-              ]
+-            })
+-          })
+-
+-          this.uppy.emit('s3-multipart:part-uploaded', cFile, part)
++      const onSuccess = (result) => {
++        const uploadResp = {
++          uploadURL: result.location
+         }
+-      }, file.s3Multipart))
++
++        this.resetUploaderReferences(file.id)
++
++        this.uppy.emit('upload-success', file, uploadResp)
++
++        if (result.location) {
++          this.uppy.log('Download ' + upload.file.name + ' from ' + result.location)
++        }
++
++        resolve(upload)
++      }
++
++      const onPartComplete = (part) => {
++        // Store completed parts in state.
++        const cFile = this.uppy.getFile(file.id)
++        if (!cFile) {
++          return
++        }
++        this.uppy.setFileState(file.id, {
++          s3Multipart: {
++            ...cFile.s3Multipart,
++            parts: [
++              ...cFile.s3Multipart.parts,
++              part
++            ]
++          }
++        })
++
++        this.uppy.emit('s3-multipart:part-uploaded', cFile, part)
++      }
++
++      const upload = new Uploader(file.data, {
++        // .bind to pass the file object to each handler.
++        createMultipartUpload: this.requests.wrapPromiseFunction(
++          this.opts.createMultipartUpload.bind(this, file)),
++        listParts: this.requests.wrapPromiseFunction(
++          this.opts.listParts.bind(this, file)),
++        prepareUploadPart: this.opts.prepareUploadPart.bind(this, file),
++        completeMultipartUpload: this.requests.wrapPromiseFunction(
++          this.opts.completeMultipartUpload.bind(this, file)),
++        abortMultipartUpload: this.requests.wrapPromiseFunction(
++          this.opts.abortMultipartUpload.bind(this, file)),
++
++        onStart,
++        onProgress,
++        onError,
++        onSuccess,
++        onPartComplete,
++
++        limit: this.opts.limit || 5,
++        ...file.s3Multipart
++      })
+ 
+       this.uploaders[file.id] = upload
+-      this.uploaderEvents[file.id] = createEventTracker(this.uppy)
++      this.uploaderEvents[file.id] = new EventTracker(this.uppy)
++
++      const queuedRequest = this.requests.run(() => {
++        if (!file.isPaused) {
++          upload.start()
++        }
++        // Don't do anything here, the caller will take care of cancelling the upload itself
++        // using resetUploaderReferences(). This is because resetUploaderReferences() has to be
++        // called when this request is still in the queue, and has not been started yet, too. At
++        // that point this cancellation function is not going to be called.
++        return () => {}
++      })
+ 
+       this.onFileRemove(file.id, (removed) => {
++        queuedRequest.abort()
+         this.resetUploaderReferences(file.id, { abort: true })
+         resolve(`upload ${removed.id} was removed`)
+       })
+ 
++      this.onCancelAll(file.id, () => {
++        queuedRequest.abort()
++        this.resetUploaderReferences(file.id)","Should it not be `this.resetUploaderReferences(file.id, { abort: true })` here too?",2019-08-16 19:59:27
+52,"@@ -147,9 +149,73 @@ function runPromiseSequence (functions, ...args) {
+ //   return (!f && 'not a function') || (s && s[1] || 'anonymous')
+ // }
+ 
++function isPreviewSupported (fileTypeSpecific) {
++  // list of images that browsers can preview
++  if (/^(jpeg|gif|png|svg|svg\+xml|bmp)$/.test(fileTypeSpecific)) {
++    return true
++  }
++  return false
++}
++
++function getArrayBuffer (file) {
++  return new Promise(function (resolve, reject) {
++    var reader = new FileReader()
++    reader.addEventListener('load', function (e) {
++      // e.target.result is an ArrayBuffer
++      resolve(e.target.result)
++    })
++    reader.addEventListener('error', function (err) {
++      console.error('FileReader error' + err)
++      reject(err)
++    })
++    // file-type only needs the first 4100 bytes
++    const chunk = file.data.slice(0, 4100)","It's a bit strange that the function called `getArrayBuffer` only returns 4100 bytes. maybe it could take a `Blob` object instead of an Uppy file object, and let the caller slice it?
+
+```js
+const chunk = file.data.slice(0, 4100)
+getArrayBuffer(chunk).then(...)
+```",2017-06-16 14:40:52
+51,"@@ -147,9 +149,73 @@ function runPromiseSequence (functions, ...args) {
+ //   return (!f && 'not a function') || (s && s[1] || 'anonymous')
+ // }
+ 
++function isPreviewSupported (fileTypeSpecific) {
++  // list of images that browsers can preview
++  if (/^(jpeg|gif|png|svg|svg\+xml|bmp)$/.test(fileTypeSpecific)) {
++    return true
++  }
++  return false
++}
++
++function getArrayBuffer (file) {
++  return new Promise(function (resolve, reject) {
++    var reader = new FileReader()
++    reader.addEventListener('load', function (e) {
++      // e.target.result is an ArrayBuffer
++      resolve(e.target.result)
++    })
++    reader.addEventListener('error', function (err) {
++      console.error('FileReader error' + err)
++      reject(err)
++    })
++    // file-type only needs the first 4100 bytes
++    const chunk = file.data.slice(0, 4100)
++    reader.readAsArrayBuffer(chunk)
++  })
++}
++
+ function getFileType (file) {
+-  return file.type ? file.type.split('/') : ['', '']
+-  // return mime.lookup(file.name)
++  const emptyFileType = ['', '']
++  const extensionsToMime = {
++    'md': 'text/markdown',
++    'markdown': 'text/markdown',
++    'mp4': 'video/mp4',
++    'mp3': 'audio/mp3'
++  }
++
++  const fileExtension = getFileNameAndExtension(file.name)[1]
++
++  // 1. try to determine file type from magic bytes with file-type module
++  // this should be the most trustworthy way
++  return getArrayBuffer(file)
++    .then((buffer) => {
++      const type = fileType(buffer)
++      if (type && type.mime) {
++        return type.mime.split('/')
++      }
++
++      // 2. if that’s no good, check if mime type is set in the file object
++      if (file.type) {
++        return Promise.resolve(file.type.split('/'))","Tiniest of nits, but this `Promise.resolve` isn't strictly necessary",2017-06-16 14:24:33
+253,"@@ -149,6 +149,82 @@ uppy-server uses POST uploads by default, but you can also use them with your ow
+    })
+    ```
+ 
++## S3 Alternatives
++
++Many other object storage providers have an identical API to S3, so you can use the AwsS3 plugin with them. To use them with Uppy Server, you can set the `UPPYSERVER_AWS_ENDPOINT` variable to the endpoint of your preferred service.
++
++### DigitalOcean Spaces
++
++For example, with DigitalOcean Spaces, you could do something like this:
++
++```","It would be nice to specify the `bash` language for all the code blocks that export environment variables, to syntax-highlight them, just like the `uppy-server` documentation does.",2018-04-24 23:58:57
+299,"@@ -149,6 +150,16 @@ module.exports = class Dashboard extends Plugin {
+     this.install = this.install.bind(this)
+   }
+ 
++  removeTarget (plugin) {
++    const pluginState = this.getPluginState()
++    // filter out the one we want to remove
++    const newTargets = pluginState.targets.filter(target => target.id !== plugin.id)
++
++    this.setPluginState({
++      targets: newTargets
++    })
++  }",good :ok_hand: ,2018-06-11 09:30:21
+803,"@@ -149,7 +164,57 @@ class MultipartUploader {
+     }
+ 
+     candidates.forEach((index) => {
+-      this._uploadPart(index)
++      this._uploadPartRetryable(index).catch((err) => {
++        this._onError(err)
++      })
++    })
++  }
++
++  _retryable ({ before, attempt, after }) {
++    const { retryDelays } = this.options
++    const { signal } = this.abortController
++
++    if (before) before()
++
++    function shouldRetry (err) {
++      if (err.source && typeof err.source.status === 'number') {
++        const { status } = err.source
++        // 0 probably indicates network failure
++        return status === 0 || status === 409 || status === 423 || (status >= 500 && status < 600)
++      }
++      return false
++    }
++
++    const doAttempt = (retryAttempt) =>
++      attempt().catch((err) => {
++        if (this._aborted()) throw createAbortError()
++
++        if (shouldRetry(err) && retryAttempt < retryDelays.length) {
++          return delay(retryDelays[retryAttempt], { signal })
++            .then(() => doAttempt(retryAttempt + 1))
++        } else {
++          throw err
++        }
++      })
++
++    return doAttempt(0).then((result) => {
++      if (after) after()
++      return result
++    }, (err) => {
++      if (after) after()
++      throw err
++    })","not actually an issue, but is there a reason we are not using `.catch(...)` here instead? I feel like it might make it more readable",2020-07-01 13:00:52
+703,"@@ -15,6 +15,29 @@
+   </div>
+ </section>
+ 
++<section class=""IndexLogos"">
++  <div class=""IndexLogos-container"">
++    <h2 class=""IndexLogos-title"">Used by:</h2>
++    <div class=""IndexLogos-logos"">
++      <a href=""https://www.coursera.org/"" class=""IndexLogos-item IndexLogos-item--coursera"">
++        <%- inline_svg('/images/featured-customers/coursera.svg') %>
++      </a>
++      <a href=""https://www.photobox.com/"" class=""IndexLogos-item IndexLogos-item--photobox"">
++        <%- inline_svg('/images/featured-customers/photobox.svg') %>
++      </a>
++      <a href=""https://issuu.com/"" class=""IndexLogos-item IndexLogos-item--issuu"">
++        <%- inline_svg('/images/featured-customers/issuu.svg') %>
++      </a>
++      <a href=""https://zulipchat.com/"" class=""IndexLogos-item IndexLogos-item--zulip"">
++        <%- inline_svg('/images/featured-customers/zulip.svg') %>
++      </a>
++    </div>
++    <div class=""IndexLogos-join"">
++      Use Uppy in your project? <a href=""https://github.com/transloadit/uppy/issues/769"" rel=""noreferrer noopener"" target=""_blank"">Let us know ›</a>","I think using is better in this case, yes
+```suggestion
+      Using Uppy in your project? <a href=""https://github.com/transloadit/uppy/issues/769"" rel=""noreferrer noopener"" target=""_blank"">Let us know ›</a>
+```",2020-03-11 16:53:37
+622,"@@ -15,6 +15,7 @@ const redis = require('./redis')
+ const PROTOCOLS = Object.freeze({
+   multipart: 'multipart',
+   s3Multipart: 's3-multipart',
++  b2Multipart: 'b2-multipart',","where is the `b2Multipart` protocol being handled in this uploader? I don't see it anywhere. I mean something like the way it is [handled for s3Multipart](https://github.com/transloadit/uppy/blob/647bb6497c473a8497a06912a83342fa06d8f6e7/packages/%40uppy/companion/src/server/Uploader.js#L240-L241). The point of implementing this is so that people can import files from Google Drive (or Dropbox, Instagram, etc) and upload to S3, or B2 in this case",2019-11-17 11:25:12
+548,"@@ -15,6 +15,8 @@
+     ""jsx-quotes"": [""error"", ""prefer-double""],
+     ""compat/compat"": [""error""],
+ 
++    ""no-unused-vars"": [""warn"", { ""vars"": ""all"", ""args"": ""after-used"", ""ignoreRestSiblings"": false }],","But it’s [part of Standard](https://github.com/standard/eslint-config-standard/blob/master/eslintrc.json#L157) config, so here you are changing it to also not allow arguments.
+
+@goto-bus-stop any preference here?
+
+But changing from `error` to `warn` is a bigger deal, cause it will now allow commits with unused vars, which I’m not a fan of.",2019-07-10 08:25:11
+116,"@@ -150,12 +154,22 @@ const ProgressBarComplete = ({ totalProgress }) => {
+   `
+ }
+ 
+-const ProgressBarError = ({ error }) => {
++const ProgressBarError = (props) => {
++  // const { error } = props
+   return html`
+     <div class=""UppyStatusBar-content"">
+-      <span>
+-        ${error.message}
+-      </span>
++      <div title=""Error"">
++        <button title=""Retry upload"" aria-label=""Retry upload"" class=""UppyStatusBar-action"" type=""button"" onclick=${props.retryAll}>
++          <svg class=""UppyIcon"" width=""28"" height=""31"" viewBox=""0 0 16 19"" xmlns=""http://www.w3.org/2000/svg"">
++            <path d=""M16 11a8 8 0 1 1-8-8v2a6 6 0 1 0 6 6h2z""/>
++            <path d=""M7.9 3H10v2H7.9z""/><path d=""M8.536.5l3.535 3.536-1.414 1.414L7.12 1.914z""/><path d=""M10.657 2.621l1.414 1.415L8.536 7.57 7.12 6.157z""/>
++          </svg>
++        </button>
++        Upload failed. 
++        <button class=""UppyStatusBar-button"" type=""button"" onclick=${props.retryAll}>","Can we squeeze the `error.message` in here somewhere stll?
+
+Also `""Upload failed.""` and `""Retry?""` should probably be localisable (I guess the StatusBar doesn't localise anything so far)",2017-09-29 14:23:03
+982,"@@ -150,28 +147,27 @@ function checkForUnused (fileContents, pluginName, localePack) {
+ }
+ 
+ function sortObjectAlphabetically (obj, sortFunc) {
+-  return Object.keys(obj).sort(sortFunc).reduce(function (result, key) {
++  return Object.keys(obj).sort(sortFunc).reduce((result, key) => {
+     result[key] = obj[key]
+     return result
+   }, {})
+ }
+ 
+ function createTypeScriptLocale (plugin, pluginName) {
+   const allowedStringTypes = Object.keys(plugin.defaultLocale.strings)
+-    .map(key => `  | '${key}'`)
++    .map((key) => `  | '${key}'`)
+     .join('\n')
+ 
+   const pluginClassName = pluginName === 'core' ? 'Core' : plugin.id
+   const localePath = path.join(__dirname, '..', 'packages', '@uppy', pluginName, 'types', 'generatedLocale.d.ts')
+ 
+-  const localeTypes =
+-    'import Uppy = require(\'@uppy/core\')\n' +
+-    '\n' +
+-    `type ${pluginClassName}Locale = Uppy.Locale` + '<\n' +
+-    allowedStringTypes + '\n' +
+-    '>\n' +
+-    '\n' +
+-    `export = ${pluginClassName}Locale\n`
++  const localeTypes =    `${'import Uppy = require(\'@uppy/core\')\n'
++    + '\n'
++    + `type ${pluginClassName}Locale = Uppy.Locale` + '<\n'}${
++    allowedStringTypes}\n`
++    + '>\n'
++    + '\n'
++    + `export = ${pluginClassName}Locale\n`","wow what happened here :joy:
+
+We can keep it like this in this PR and clean it up afterward using strip-indent or something.",2021-03-10 08:19:08
+323,"@@ -150,6 +150,8 @@ class MultipartUploader {
+       return result
+     }).then(({ url }) => {
+       this._uploadPartBytes(index, url)
++    }).catch((err) => {","This is an extremely small nit and I almost feel bad for bringing it up: I think this might be a little clearer using the second argument to `.then()`. The `._uploadPartBytes()` call is conceptually the next step after the Promise chain ends, having another `.catch()` _reads_ like it is part of the chain. Basically, I could see myself reading this in the future and thinking the `this._uploadPartBytes()` call is missing a return statement.
+
+I would prefer doing this:
+```js
+.then(({ url }) => {
+  this._uploadPartBytes(index, url)
+}, (err) => {
+  this._onError(err)
+})
+```
+
+Then it's clear that this is the end of the chain and that we have two ways of handling the ""final"" promise state, if that makes sense.",2018-07-19 10:34:28
+74,"@@ -151,24 +178,66 @@ module.exports = class Webcam extends Plugin {
+     this.streamSrc = null
+   }
+ 
++  oneTwoThreeSmile () {
++    return new Promise((resolve, reject) => {
++      let count = this.opts.countdown
++
++      let countDown = setInterval(() => {
++        if (!this.webcamActive) {
++          clearInterval(countDown)
++          this.captureInProgress = false
++          return Promise.reject('Webcam is not active')",This `return` is inside a closure so it doesn't reject the outer Promise,2017-07-14 19:16:28
+76,"@@ -151,24 +178,66 @@ module.exports = class Webcam extends Plugin {
+     this.streamSrc = null
+   }
+ 
++  oneTwoThreeSmile () {
++    return new Promise((resolve, reject) => {
++      let count = this.opts.countdown
++
++      let countDown = setInterval(() => {
++        if (!this.webcamActive) {
++          clearInterval(countDown)
++          this.captureInProgress = false
++          return Promise.reject('Webcam is not active')
++        }
++
++        if (count > 0) {
++          this.core.emit('informer', `${count}...`, 'warning', 800)
++          count--
++        } else {
++          clearInterval(countDown)
++          this.core.emit('informer', this.i18n('smile'), 'success', 1500)
++          setTimeout(() => resolve(), 1500)
++        }
++      }, 1000)
++    })
++  }
++
++  justSmile () {
++    return new Promise((resolve, reject) => {
++      setTimeout(() => this.core.emit('informer', this.i18n('smile'), 'success', 1000), 1500)
++      setTimeout(() => resolve(), 2000)
++    })","Waiting 2s by default if no countdown is configured seems long to me…I thought the old way where ""Smile"" appears on focus and snapshotting is immediate was pretty good. Don't feel strongly tho.",2017-07-14 19:23:15
+75,"@@ -151,24 +178,66 @@ module.exports = class Webcam extends Plugin {
+     this.streamSrc = null
+   }
+ 
++  oneTwoThreeSmile () {
++    return new Promise((resolve, reject) => {
++      let count = this.opts.countdown
++
++      let countDown = setInterval(() => {
++        if (!this.webcamActive) {
++          clearInterval(countDown)
++          this.captureInProgress = false
++          return Promise.reject('Webcam is not active')
++        }
++
++        if (count > 0) {
++          this.core.emit('informer', `${count}...`, 'warning', 800)
++          count--
++        } else {
++          clearInterval(countDown)
++          this.core.emit('informer', this.i18n('smile'), 'success', 1500)
++          setTimeout(() => resolve(), 1500)
++        }
++      }, 1000)
++    })
++  }
++
++  justSmile () {
++    return new Promise((resolve, reject) => {
++      setTimeout(() => this.core.emit('informer', this.i18n('smile'), 'success', 1000), 1500)
++      setTimeout(() => resolve(), 2000)
++    })
++  }
++
+   takeSnapshot () {
+     const opts = {
+       name: `webcam-${Date.now()}.jpg`,
+       mimeType: 'image/jpeg'
+     }
+ 
+-    const video = this.target.querySelector('.UppyWebcam-video')
++    this.videoEl = this.target.querySelector('.UppyWebcam-video')
+ 
+-    const image = this.webcam.getImage(video, opts)
++    if (this.captureInProgress) return
++    this.captureInProgress = true
+ 
+-    const tagFile = {
+-      source: this.id,
+-      name: opts.name,
+-      data: image.data,
+-      type: opts.mimeType
+-    }
++    this.opts.onBeforeSnapshot().catch((err) => {
++      this.emit('informer', err, 'error', 5000)
++      return Promise.reject(`onBeforeSnapshot: ${err}`)
++    }).then(() => {
++      const video = this.target.querySelector('.UppyWebcam-video')
++      if (!video) return Promise.reject('No video element found, likely due to the Webcam tab being closed.')",I think `captureInProgress` should also be reset before this return,2017-07-14 19:17:05
+911,"@@ -151,6 +151,7 @@ class Uppy {
+     this.addFile = this.addFile.bind(this)
+     this.removeFile = this.removeFile.bind(this)
+     this.pauseResume = this.pauseResume.bind(this)
++    this.passesRestrictions = this.passesRestrictions.bind(this)",Mb change it to 'doesPassRestrictions()'? Doesn't sound enough like a boolean-returning method to me.,2020-10-29 13:52:15
+745,"@@ -151,7 +151,7 @@ module.exports = class AwsS3Multipart extends Plugin {
+       const onError = (err) => {
+         this.uppy.log(err)
+         this.uppy.emit('upload-error', file, err)
+-        err.message = `Failed because: ${err.message}`
++        err.message = `${err.message}`",I guess this assignment is now redundant?,2020-04-20 19:31:12
+236,"@@ -152,7 +152,7 @@ uppy.use(AwsS3, {
+       },
+       body: JSON.stringify({
+         filename: file.name,
+-        contentType: file.type
++        type: file.type","This example belongs to this PHP file: https://github.com/transloadit/uppy/blob/master/examples/aws-presigned-url/s3-sign.php, which uses `contentType`.",2018-03-12 08:40:29
+769,"@@ -153,7 +153,9 @@ module.exports = class Transloadit extends Plugin {
+     // Add Assembly-specific Tus endpoint.
+     const tus = {
+       ...file.tus,
+-      endpoint: status.tus_url
++      endpoint: status.tus_url,
++      // Include X-Request-ID headers for better debugging.
++      addRequestId: true","is there any reason we are not adding this to companion as well? 🤔 There are no CORS concerns there, so adding probably shouldn't be a problem, no?
+
+**One question about the requestId;** Are the request Ids unique to each tus-js-client request, or are they unique to an upload instance instead?",2020-05-11 12:40:13
+388,"@@ -154,7 +154,11 @@ module.exports = class Tus extends Plugin {
+       }
+ 
+       optsTus.onSuccess = () => {
+-        this.uppy.emit('upload-success', file, upload, upload.url)
++        const uploadResp = {
++          uploadURL: upload.url
++        }
++
++        this.uppy.emit('upload-success', file, uploadResp)
+ ",Do we need to pass `upload` instance?,2018-12-19 20:21:43
+387,"@@ -154,7 +154,7 @@ module.exports = class Tus extends Plugin {
+       }
+ 
+       optsTus.onSuccess = () => {
+-        this.uppy.emit('upload-success', file, upload, upload.url)
++        this.uppy.emit('upload-success', file, null, upload.url)",we can drop the upload.urls here and instead pass an object that contains the `uploadURL` like in xhrupload,2018-12-10 16:39:39
+15,"@@ -156,28 +162,34 @@ Should probably be called UI.
+ 
+ - **Metadata** — allows adding custom metadata fields, data from each field is then added to a file
+ 
++---
++
+ ## Questions about the future
+ 
+ Things work the way they are. Not everything is optimal, though. We would like to improve our architecture and APIs to solve a few issues:
+ 
+-We want Uppy to work well with React and React Native (and other frameworks, like Angular, Ember, Vue, Choo). Currently state and view rendering are tied with Core and Plugins, which is a problem for React. There are few options:
++We want Uppy to work well with React and React Native (and other frameworks, like Angular, Ember, Vue, Choo). Currently state and view rendering are all tied together in Core and Plugins, which is a problem for React or other libs that handle views. There are few options:
++
++A. The simplest is to go the “Black Hole way” and just tell React users to wrap Uppy in a dumb component with `shouldComponentUpdate: false`, and give them no control, but that’s not a good way — they can’t alter anything, this feels like a band-aid solution.",", or use time travel
+",2016-10-13 09:52:22
+16,"@@ -156,28 +162,34 @@ Should probably be called UI.
+ 
+ - **Metadata** — allows adding custom metadata fields, data from each field is then added to a file
+ 
++---
++
+ ## Questions about the future
+ 
+ Things work the way they are. Not everything is optimal, though. We would like to improve our architecture and APIs to solve a few issues:
+ 
+-We want Uppy to work well with React and React Native (and other frameworks, like Angular, Ember, Vue, Choo). Currently state and view rendering are tied with Core and Plugins, which is a problem for React. There are few options:
++We want Uppy to work well with React and React Native (and other frameworks, like Angular, Ember, Vue, Choo). Currently state and view rendering are all tied together in Core and Plugins, which is a problem for React or other libs that handle views. There are few options:
++
++A. The simplest is to go the “Black Hole way” and just tell React users to wrap Uppy in a dumb component with `shouldComponentUpdate: false`, and give them no control, but that’s not a good way — they can’t alter anything, this feels like a band-aid solution.
++
++B. Leave things as they are, keep Core. Treat Uppy as an external uploading library, where you subscribe to events and manage React (or other) state yourself: `uppy.on('core:progress', updateMyReactState)`. Simple example: http://codepen.io/arturi/pen/yaZEzz/. Maybe come up with some state-sync solution that will update Redux state in your app, when Uppy’s internal state is updated. Then we only use logic parts of Uppy (see uppy-base https://github.com/hedgerh/uppy-base/tree/master/src) and re-create UI components for each environment. Or optimize and abstract the ones we have, perhaps by switching to JSX and even more environment agnostic props. Then our UI plugins/views like DragDrop, Dashboard and Google Drive can be used in React.
+ 
+-A. The simplest is to go “Black Hole way” and just tell React users to wrap Uppy in a dumb component with `shouldComponentUpdate: false`, and give them no control, but that’s not a good way — they can’t alter anything, this is like a band-aid.
++Issues with this approach:
+ 
+-B. Leave things as they are, keep Core. Treat Uppy as an external uploading library, where you subscribe to events and manage React state yourself: `uppy.on('core:progress', updateMyReactState)`. Example: http://codepen.io/arturi/pen/yaZEzz/. So we only use logic parts of Uppy (see uppy-base https://github.com/hedgerh/uppy-base/tree/master/src) and re-create UI components, or optimize and abstract the ones we have, , perhaps by switching to JSX and even more env agnostic props. So that our UI like DragDrop, Dashboard and Google Drive views can be used in React.
++* It leaves state in Core (files are still added to it, progress gets updated, previews generated — all inside), and that means state will be kept in multiple places — Uppy’s Core + Redux or React component’s internal state. Might lead to state getting out of sync — if you removed file from Uppy `uppy.removeFile(fileID)`, but forgot to remove it from your Redux state, or something like that. *Unless we solve this by providing some subscription interface or a way to tell Uppy to use your Redux state somehow.*","I feel a variant here is possible where state-handling is hot-swappable. We'd have a Redux compatible state machine inside Uppy by default, but React/Native users could inject an instance of their own Redux, making Uppy store & subscribe there, instead. This would prevent state syncing, there only ever would be one source of truth. It would by default live inside Uppy, but can live inside the developers app, to profit from debugging/extending/timetravel
+",2016-10-13 09:56:08
+976,"@@ -1564,8 +1572,24 @@ class Uppy {
+         return
+       }
+ 
+-      const files = currentUpload.fileIDs
+-        .map((fileID) => this.getFile(fileID))
++      // Mark postprocessing step as complete if necessary; this addresses a case where we might get
++      // stuck in the postprocessing UI while the upload is fully complete.
++      // If the postprocessing steps do not do any work, they may not emit postprocessing events at
++      // all, and never mark the postprocessing as complete. This is fine on its own but we
++      // introduced code in the @uppy/core upload-success handler to prepare postprocessing progress
++      // state if any postprocessors are registered. That is to avoid a ""flash of completed state""
++      // before the postprocessing plugins can emit events.
++      //
++      // So, just in case an upload with postprocessing plugins *has* completed *without* emitting
++      // postprocessing completion, we do it instead.","To re-iterate, just to make sure I understand and the comment here is sufficient.
+This re-emits `postprocess-complete` after `lastStep` of the upload/process chain, in case the event wasn’t emitted by processing plugins? 
+
+I’m missing how this is related to websockets and polling fallback. When falling back to polling we missed `postprocess-complete`?",2021-02-09 19:01:46
+543,"@@ -157,10 +166,8 @@ class Uppy {
+       this.updateAll(nextState)
+     })
+ 
+-    // for debugging and testing
+-    // this.updateNum = 0
++    // Exposing uppy object on window for debugging and testing
+     if (this.opts.debug && typeof window !== 'undefined') {
+-      window['uppyLog'] = ''
+       window[this.opts.id] = this",will be good that we'll be forced to get rid of this when we remove `debug: true` :eyes:,2019-07-05 15:09:45
+739,"@@ -157,6 +165,13 @@ module.exports = class RequestClient {
+           credentials: 'same-origin',
+           body: JSON.stringify(data)
+         })
++          .catch((err) => {
++            if (err.name === 'AbortError') {
++              throw err
++            } else {
++              throw new NetworkError(err)",do we not need this for the `delete` method as well? 🤔 ,2020-04-17 11:17:59
+740,"@@ -1571,9 +1574,6 @@ class Uppy {
+         const uploadID = this._createUpload(waitingFileIDs)
+         return this._runUpload(uploadID)
+       })",so errors from this block will no longer be caught? Is this deliberate?,2020-04-17 11:22:09
+287,"@@ -158,7 +162,11 @@ module.exports = class Url extends Plugin {
+         if (item.kind === 'string' && item.type === 'text/uri-list') {
+           item.getAsString((url) => {
+             this.uppy.log(`[URL] Adding file from dropped url: ${url}`)
+-            this.addFile(url)
++            try {
++              this.addFile(url)","This is a different `addFile` function, it doesn't need the try/catch",2018-05-31 10:18:34
+64,"@@ -159,9 +165,7 @@ class Uppy {
+         id: fileID,
+         name: fileName,
+         extension: fileExtension || '',
+-        meta: {
+-          name: fileName
+-        },
++        meta: Object.assign({}, this.getState().metaData),",`setMeta` sets the `meta` state key but this merges in the `metaData` state key,2017-06-29 11:31:33
+4,"@@ -16,45 +22,62 @@
+ var createStream = require('fs').createWriteStream;
+ var glob = require('multi-glob').glob;
+ var chalk = require('chalk');
++var path = require('path');
++var mkdirp = require('mkdirp');
+ var notifier = require('node-notifier');
+ var babelify = require('babelify');
+ var browserify = require('browserify');
+ var watchify = require('watchify');
+ 
+-var src = 'src/js/app.js';
+-var dest = 'static/js/app.js';
++var webRoot = __dirname;
++var uppyRoot = path.dirname(webRoot);
+ 
+-var pattern = 'src/examples/**/' + src;
++var srcPattern = webRoot + '/src/examples/**/js/app.es6';
++var dstPattern = webRoot + '/public/examples/**/js/app.js';
++
++var watchifyEnabled = process.argv[2] === 'watch';
++var browserifyPlugins = [];
++if (watchifyEnabled) {
++  browserifyPlugins.push(watchify);
++}
+ 
+-// Find each app.js file with glob.
+-// 'website/' glob is for when calling `node website/watch-examples.js` from root.
+-glob([pattern, 'website/' + pattern], function(err, files) {
++// Instead of 'watch', build-examples.js can also take a path as cli argument.
++// In this case we'll only bundle the specified path/pattern
++if (!watchifyEnabled && process.argv[2]) {
++  srcPattern = process.argv[2];
++}
++
++// Find each app.es6 file with glob.
++glob(srcPattern, function(err, files) {
+   if (err) throw new Error(err);
+ 
+-  console.log('--> Watching examples..');
+-  console.log('--> Pre-building ' + files.length + ' files..')
++  if (watchifyEnabled) {
++    console.log('--> Watching examples..');
++  }
+ 
+   var muted = [];
+ 
+   // Create a new watchify instance for each file.
+   files.forEach(function(file) {
+-    var watcher = browserify(file, {
+-      cache: {},
++    var browseFy = browserify(file, {
++      cache       : {},
+       packageCache: {},
+-      plugin: [watchify]
++      plugin      : browserifyPlugins
+     })
+-      // Aliasing for using `require('uppy')`, etc.
+-      .require('../src/index.js', { expose: 'uppy' })
+-      .require('../src/core/index.js', { expose: 'uppy/core' })
+-      .require('../src/plugins/index.js', { expose: 'uppy/plugins' })
++
++    // Aliasing for using `require('uppy')`, etc.
++    browseFy
++      .require(uppyRoot + '/src/index.js', { expose: 'uppy' })
++      .require(uppyRoot + '/src/core/index.js', { expose: 'uppy/core' })
++      .require(uppyRoot + '/src/plugins/index.js', { expose: 'uppy/plugins' })
+       .transform(babelify);
+ 
+     // Listeners for changes, errors, and completion.
+-    watcher
++    browseFy
+       .on('update', bundle)
+       .on('error', onError)
+       .on('log', function(msg) {","Looks like we can get rid of this event listener if its not being used anymore
+",2015-12-17 15:05:11
+206,"@@ -16,6 +16,10 @@ Uppy comes with two state management solutions (stores):
+  - `DefaultStore`, a simple object-based store.
+  - `ReduxStore`, a store that uses a key in a Redux store.
+ 
++There are also some third party stores:
++
++ - [uppy-store-ngrx](https://github.com/rimlin/uppy-store-ngrx/), keeping Uppy state in a key in an Ngrx store for use with Angular.
++",Maybe also add a link to Ngrx store?,2018-01-30 18:24:52
+673,"@@ -160,6 +161,16 @@ async function main (packageName, version) {
+     ? await getRemoteDistFiles(packageName, version)
+     : await getLocalDistFiles(packagePath)
+ 
++  if (packageName === 'uppy') {
++    // Create downloadable zip archive
++    const zip = new AdmZip()
++    for (const [filename, buffer] of files.entries()) {
++      zip.addFile(filename, buffer, 'entry comment goes here')",is the comment required? would be preferable to omit it instead of having a dummy value :smile: ,2020-02-05 11:03:22
+905,"@@ -1604,6 +1604,34 @@ describe('src/Core', () => {
+       }
+     })
+ 
++    it('should enforce the maxTotalFileSize rule', () => {
++      const core = new Core({
++        restrictions: {
++          maxTotalFileSize: 34000
++        }
++      })
++
++      core.addFile({
++        source: 'jest',
++        name: 'foo.jpg',
++        type: 'image/jpeg',
++        data: new File([sampleImage], { type: 'image/jpeg' })
++      })
++
++      try {
++        core.addFile({
++          source: 'jest',
++          name: 'foo1.jpg',
++          type: 'image/jpeg',
++          data: new File([sampleImage], { type: 'image/jpeg' })
++        })
++        throw new Error('should have thrown')",Is there some reason https://jestjs.io/docs/en/expect#tothrowerror wouldn't work?,2020-10-23 10:26:25
+310,"@@ -162,7 +190,7 @@ Yes, there is an S3 plugin, please check out the [docs](https://uppy.io/docs/aws
+ 
+ ### Do I need to install special service/server for Uppy? Can I use it with Rails/Node/Go/PHP?
+ 
+-Yes, whatever you want on the backend will work with `XHRUpload` plugin, since it just does a `POST` or `PUT` request. Here’s a [PHP backend example](https://uppy.io/docs/xhrupload/#Uploading-to-a-PHP-Server).
++Yes, whatever you want on the backend will work with `XHR Upload` plugin, since it just does a `POST` or `PUT` request. Here’s a [PHP backend example](https://uppy.io/docs/xhrupload/#Uploading-to-a-PHP-Server).","here ""the `@uppy/xhr-upload` plugin"" probably makes the most sense. also the URL redirects to xhr-upload",2018-07-16 08:44:25
+263,"@@ -163,7 +163,8 @@ module.exports = class ProviderView {
+         url: `${this.Provider.fileUrl(this.plugin.getItemRequestPath(file))}`,
+         body: {
+           fileId: this.plugin.getItemId(file)
+-        }
++        },
++        provider: this.Provider","This will most likely not work with GoldenRetriever, it needs state to be JSON.stringify-able in most cases",2018-05-14 07:36:38
+732,"@@ -164,7 +184,7 @@ describe('download provdier file', () => {
+       .set('uppy-auth-token', token)
+       .set('Content-Type', 'application/json')
+       .send({
+-        endpoint: 'http://master.tus.com/files',
++        endpoint: 'http://master.tus.io/files',","Wont it be confusing to see a tus endpoint while this is about s3 multipart? Even if it doesn’t matter for the test, folks will see this and draw bad conclusions or walk away in a confused state",2020-04-14 13:44:51
+886,"@@ -165,6 +165,7 @@
+     ""minify-stream"": ""2.0.1"",
+     ""minimist"": ""^1.2.5"",
+     ""mkdirp"": ""0.5.1"",
++    ""moment-timezone"": ""^0.5.31"",","we were previously relying on moment that was implicitly installed by expo for ""@uppy-example/react-native-expo"" I think (and it only worked because moment is a global object)",2020-09-11 21:01:52
+272,"@@ -166,7 +166,17 @@ module.exports = class Tus extends Plugin {
+         this.resetUploaderReferences(file.id)
+         resolve(upload)
+       }
+-      optsTus.metadata = file.meta
++
++      // tusd uses metadata field ""filetype"", not ""type""
++      const meta = Object.assign({}, file.meta)
++      if (
++        Object.prototype.hasOwnProperty.call(meta, 'type') &&
++        !Object.prototype.hasOwnProperty.call(meta, 'filetype')
++      ) {
++        meta.filetype = meta.type
++        delete meta.type
++      }
++      optsTus.metadata = meta
+ ","Feels like this complicates everything a bit. If we just add `filetype` (maybe check if it is not already set), it would be simpler.
+
+Also, could you please add `filename` as well? See https://github.com/tus/tus-js-client/commit/ebc5189eac35956c9f975ead26de90c896dbe360 and https://github.com/tus/tusd/blob/5b376141903c1fd64480c06dde3dfe61d191e53d/unrouted_handler.go#L640-L643",2018-05-22 02:53:19
+174,"@@ -168,7 +169,9 @@ module.exports = class Webcam extends Plugin {
+       })
+       return this.getVideo()
+     }).then((file) => {
+-      return this.uppy.addFile(file)
++      this.uppy.addFile(file)","this no longer waits for the `addFile()` function to complete, is that intentional?",2017-12-13 21:46:56
+175,"@@ -168,7 +169,9 @@ module.exports = class Webcam extends Plugin {
+       })
+       return this.getVideo()
+     }).then((file) => {
+-      return this.uppy.addFile(file)
++      this.uppy.addFile(file)
++      const dashboard = this.uppy.getPlugin('Dashboard')
++      if (dashboard) dashboard.hideAllPanels()",why is this done here? i feel like the webcam plugin shouldn't know it's in a panel,2017-12-13 21:51:42
+839,"@@ -168,9 +168,12 @@ module.exports = class Webcam extends Plugin {
+       this.opts.modes.indexOf('video-only') !== -1 ||
+       this.opts.modes.indexOf('picture') !== -1
+ 
++    const videoConstraints = this.opts.videoConstraints ?? {}
++    videoConstraints.facingMode = this.opts.facingMode",Reading this again it should prob prefer the `videoConstraints.facingMode` value over `facingMode` if the former was already set,2020-07-13 15:31:45
+61,"@@ -169,6 +169,8 @@ class Uppy {
+         data: file.data,
+         progress: {
+           percentage: 0,
++          bytesUploaded: 0,
++          bytesTotal: file.data.size || 0,",Do I have to do anything special here for remote files? or will this Just Work™?,2017-06-26 19:56:33
+220,"@@ -169,7 +169,7 @@ module.exports = class Webcam extends Plugin {
+       })
+       return this.getVideo()
+     })
+-    .then(this.uppy.addFile)
++    .then((file) => this.uppy.addFile(file))
+     .then(() => {","And here we are not catching, cause we are actually handling the error?",2018-02-09 05:35:44
+470,"@@ -169,7 +169,7 @@ pushd ""${__root}"" > /dev/null 2>&1
+ ",Let's remove this?,2019-05-22 14:41:50
+412,"@@ -17,14 +18,18 @@ module.exports = class Provider extends RequestClient {
+     this.tokenKey = `companion-${this.pluginId}-auth-token`
+   }
+ 
+-  get defaultHeaders () {
+-    return Object.assign({}, super.defaultHeaders, {'uppy-auth-token': this.getAuthToken()})
++  headers () {
++    return new Promise((resolve, reject) => {","```js
+return super.headers().then((headers) => {
+  return this.getAuthToken().then((token) => {
+    return Object.assign({}, headers, { 'uppy-auth-token': token })
+  })
+})
+```",2019-03-25 10:34:02
+170,"@@ -17,15 +19,16 @@ module.exports = (props) => {
+   return html`
+     <table class=""BrowserTable"" onscroll=${props.handleScroll}>
+       <tbody role=""listbox"" aria-label=""List of files from ${props.title}"">
+-        ${props.folders.map((folder) => {
++        ${props.folders.map(folder => {","aww i like the parentheses there. super nit picky tho, i'll adapt either way :D",2017-12-13 21:41:32
+332,"@@ -17,7 +17,10 @@ cache:
+   directories:
+   - ~/.npm
+ before_install:
++- nvm install-latest-npm",Two times installing npm requires?,2018-08-17 05:12:06
+311,"@@ -17,7 +17,7 @@
+   @include reset-button;
+   padding: 10px 15px;
+   border: 1px solid $color-primary;
+-  background-transition: all .3s;
++  transition: all .2s;",:see_no_evil: :+1: ,2018-07-16 08:45:17
+305,"@@ -17,7 +17,7 @@ module.exports = class Provider extends RequestClient {
+   }
+ 
+   get defaultHeaders () {
+-    return Object.assign({}, super.defaultHeaders, {'uppy-auth-token': localStorage.getItem(this.tokenKey)})
++    return Object.assign(super.defaultHeaders, {'uppy-auth-token': localStorage.getItem(this.tokenKey)})","this change is correct but it looked wrong initially :thinking: maybe add a comment explaining that super.defaultHeaders is a getter, so it's fine to mutably merge things into it? else i'm sure we'll get a PR to add back the `{}, ` in the near future :)
+
+(FWIW i think keeping the `{}, ` is also fine, one or two empty objects don't pressure the GC that much :smile: )",2018-06-28 13:00:39
+328,"@@ -17,8 +38,10 @@ module.exports = (props) => {
+     props.handleClick(ev)
+   }
+ 
++  const itemIcon = props.getItemIcon()
++
+   return (
+-    <li class={'uppy-ProviderBrowserItem' + (props.isChecked ? ' uppy-ProviderBrowserItem--selected' : '')}>
++    <li class={'uppy-ProviderBrowserItem' + (props.isChecked ? ' uppy-ProviderBrowserItem--selected' : '') + (itemIcon === 'video' ? ' uppy-ProviderBrowserItem--noPreview' : '')}>
+       <div class=""uppy-ProviderBrowserItem-checkbox"">","this is an Instagram-specific hack, should be replaced",2018-07-30 16:24:23
+876,"@@ -172,13 +174,12 @@ class Zoom extends Provider {
+         const file = resp
+           .body
+           .recording_files
+-          .find(file => file.id === fileId || file.file_type === fileId)
++          .find(file => file.id === fileId || (file.file_type === fileId && file.recording_start === recordingStart))
+ 
+         if (!file) {
+           return this._downloadError(resp, done)
+         }
+-        // timeline files don't have file size, but are typically small json files, should be much less than 1MB
+-        const maxExportFileSize = 1024 * 1024
++        const maxExportFileSize = 10 * 1024 * 1024 // 10MB","it looks like cc files are larger than just plain json files, but this information is not provided in the api response so it's hard to tell what the absolute limit on cc file size is. I've used the same limit here as the one set for google drive ",2020-09-04 16:59:53
+87,"@@ -173,6 +180,37 @@ module.exports = class Transloadit extends Plugin {
+     return this.opts.waitForEncoding || this.opts.waitForMetadata
+   }
+ 
++  /**
++   * Used when `importFromUploadURLs` is enabled: reserves all files in
++   * the assembly.
++   */
++  reserveFiles (fileIDs) {
++    return Promise.all(fileIDs.map((fileID) => {
++      const file = this.core.getState().files[fileID]
++      const assemblyId = file.transloadit.assembly
++      const assemblies = this.state.assemblies
++      return this.client.reserveFile(assemblies[assemblyId], file)
++    }))
++  }
++
++  /**
++   * Used when `importFromUploadURLs` is enabled: adds files to the assembly
++   * once they have been fully uploaded.
++   */
++  onFileUploadURLAvailable (fileID) {
++    const file = this.core.getState().files[fileID]
++    if (!file || !file.transloadit || !file.transloadit.assembly) {
++      return
++    }
++
++    const assembly = this.state.assemblies[file.transloadit.assembly]
++
++    this.client.addFile(assembly, file).catch((err) => {
++      this.core.log(err)
++      this.core.emit('core:upload-error', file.id, err)","Hmm, this happens _after_ `core:upload-success`, it should emit this error in the postprocess step instead.",2017-08-21 16:04:30
+62,"@@ -175,14 +176,14 @@ module.exports = class DashboardUI extends Plugin {
+   }
+ 
+   initEvents () {
+-    // const dashboardEl = this.target.querySelector(`${this.opts.target} .UppyDashboard`)
+-
+     // Modal open button
+     const showModalTrigger = findDOMElement(this.opts.trigger)
+     if (!this.opts.inline && showModalTrigger) {
+       showModalTrigger.addEventListener('click', this.showModal)
+-    } else {
+-      this.core.log('Modal trigger wasn’t found')
++    }
++
++    if (!this.opts.inline && !showModalTrigger) {
++      console.error('Dashboard modal trigger not found, you won’t be able to select files. Make sure `trigger` is set correctly in Dashboard options')","good error message 👍
+can this use `this.core.log` with type error?",2017-06-29 11:29:26
+565,"@@ -175,6 +172,13 @@ module.exports = class Dashboard extends Plugin {
+     this.removeDragOverClassTimeout = null
+   }
+ 
++  i18nInit () {","We may want to override setOptions in these plugins to automatically reinitialize the localization
+```js
+setOptions (newOpts) {
+  super.setOptions(newOpts)
+  this.i18nInit()
+}
+```",2019-08-07 13:28:29
+742,"@@ -175,6 +177,11 @@ module.exports = class Tus extends Plugin {
+ 
+       optsTus.onError = (err) => {
+         this.uppy.log(err)
++
++        if (isNetworkError(err.originalRequest)) {
++          err = new NetworkError(err)","should this be `err = new NetworkError(err, err.originalRequest)` instead?",2020-04-17 12:35:12
+746,"@@ -175,8 +177,13 @@ module.exports = class Tus extends Plugin {
+ 
+       optsTus.onError = (err) => {
+         this.uppy.log(err)
++
++        if (isNetworkError(err.originalRequest)) {
++          err = new NetworkError(err, err.originalRequest)
++        }
++
+         this.uppy.emit('upload-error', file, err)
+-        err.message = `Failed because: ${err.message}`
++        err.message = `${err.message}`",redundant as well?,2020-04-20 19:35:39
+48,"@@ -176,23 +176,46 @@ function getArrayBuffer (file) {
+ 
+ function getFileType (file) {
+   const emptyFileType = ['', '']
+-  if (file.type) {
+-    return Promise.resolve(file.type.split('/'))
++  const extensionsToMime = {
++    'md': 'text/markdown',
++    'markdown': 'text/markdown',
++    'mp4': 'video/mp4',
++    'mp3': 'audio/mp3'
+   }","We should probably have one unified list of extensions/file-types? I need to search it by extension, and the one used in `getFileTypeExtension` is the other way around. But I guess we can just use one list and two different methods, `getFileTypeExtension` and `getExtensionByFileType`, looping through it with Object.keys().forEach? @goto-bus-stop ",2017-06-14 21:40:52
+824,"@@ -176,8 +176,8 @@ module.exports = class Dashboard extends Plugin {
+ 
+     if (callerPluginType !== 'acquirer' &&
+         callerPluginType !== 'progressindicator' &&
+-        callerPluginType !== 'presenter') {
+-      const msg = 'Dashboard: Modal can only be used by plugins of types: acquirer, progressindicator, presenter'
++        callerPluginType !== 'editor') {
++      const msg = 'Dashboard: The Dashboard can only be used by plugins of types: acquirer, progressindicator, editor'","if we're tweaking the wording here anyway 😇 
+```suggestion
+      const msg = 'Dashboard: can only be targeted by plugins of types: acquirer, progressindicator, editor'
+```",2020-07-13 09:45:38
+41,"@@ -177,9 +170,12 @@ module.exports = class Multipart extends Plugin {
+     //   }
+   }
+ 
+-  handleUpload () {
++  handleUpload (fileIDs) {
+     this.core.log('Multipart is uploading...')
+-    const files = this.core.getState().files
++    const files = fileIDs.map(getFile, this)
++    function getFile (fileID) {
++      return this.core.state.files[fileID]
++    }","All changes in this file are because the file IDs to upload are now passed in by `Core`, so the Multipart plugin doesn't have to figure out what it has to upload.",2017-05-31 20:47:07
+687,"@@ -178,7 +178,11 @@ app.use((req, res, next) => {
+ if (app.get('env') === 'production') {
+   // @ts-ignore
+   app.use((err, req, res, next) => {
+-    console.error('\x1b[31m', req.id, err, '\x1b[0m')
++    // if the error is as a result of bad request from client, no need
++    //  to flood production logs with this.
++    if (!err.status || err.status !== 400) {",Is this not overly eager?,2020-03-06 11:49:55
+762,"@@ -178,8 +186,9 @@ module.exports = class Tus extends Plugin {
+       optsTus.onError = (err) => {
+         this.uppy.log(err)
+ 
+-        if (isNetworkError(err.originalRequest)) {
+-          err = new NetworkError(err, err.originalRequest)
++        const xhr = err.originalRequest ? err.originalRequest.getUnderlyingObject() : null","tus-js-client v2 introduces a HTTP abstraction layer, so the code to access XHR objects is a bit different now.",2020-05-03 15:47:50
+290,"@@ -179,9 +201,13 @@ module.exports = class ProviderView {
+     } catch (err) {
+       // Nothing, restriction errors handled in Core
+     }
+-    if (!isCheckbox) {
+-      this.donePicking()
+-    }
++  }
++
++  removeFile (id) {
++    const { currentSelection } = this.plugin.getPluginState()
++    this.plugin.setPluginState({
++      currentSelection: currentSelection.filter((file) => file.id !== id)
++    })","Does this do anything, or is it here in case we might need it? Current solution doesn’t allow removing files from ProviderView, correct?",2018-05-31 22:48:42
+5,"@@ -18,14 +18,14 @@ module.exports = {
+             ""port"": 8080
+         }
+     },
+-    ""files"": [ ""examples/cdn/*""],
++    ""files"": [ ""examples/bundle/*""],","This seemed broken to me. Why would browserify only check the (previously `cdn`, now) `bundle` example? And even so, the path is incorrect here. Fixing this is unrelated so should not go into this PR I feel. But when we fix this in master, perhaps that solves the reload issues that you experienced @hedgerh?
+",2016-02-17 10:24:39
+922,"@@ -18,47 +20,74 @@ module.exports.generateToken = (payload, secret) => {
+ module.exports.verifyToken = (token, secret) => {
+   try {
+     // @ts-ignore
+-    return { payload: jwt.verify(decrypt(token, secret), secret, {}).data }
++    return { payload: jwt.verify(token, secret, {}).data }
+   } catch (err) {
+     return { err }
+   }
+ }
+ 
+ /**
+  *
+- * @param {object} res
++ * @param {*} payload
++ * @param {string} secret
++ */
++module.exports.generateEncryptedToken = (payload, secret) => {
++  return encrypt(module.exports.generateToken(payload, secret), secret)
++}
++
++/**
++ *
+  * @param {string} token
+- * @param {object=} companionOptions
+- * @param {string} providerName
++ * @param {string} secret
+  */
+-module.exports.addToCookies = (res, token, companionOptions, providerName) => {
++module.exports.verifyEncryptedToken = (token, secret) => {
++  try {
++    // @ts-ignore
++    return module.exports.verifyToken(decrypt(token, secret), secret)
++  } catch (err) {
++    return { err }
++  }
++}
++
++const addToCookies = (res, token, companionOptions, authProvider, prefix) => {
+   const cookieOptions = {
+-    maxAge: 1000 * 60 * 60 * 24 * 30, // would expire after 30 days
++    maxAge: 1000 * EXPIRY, // would expire after one day (24 hrs)",no point making this last 30 days when the token itself expires after 24hrs,2020-11-11 11:24:18
+370,"@@ -18,6 +18,8 @@ cache:
+ services:
+ - docker
+ addons:
++  hosts:
++    - companion.test",adding `hosts` is the one work around to have this working on Microsoft edge. Without this socket progress is not working on Edge,2018-10-26 00:27:04
+874,"@@ -18,7 +18,7 @@ Robodog is an Uppy-based library that helps you talk to the Transloadit API. It
+ Robodog can be downloaded from npm:
+ 
+ ```shell
+-npm install --save @uppy/robodog
++npm install  @uppy/robodog","It seems this leaves two spaces here, perhaps we should replace for `[space]--save` instead?",2020-09-03 13:09:21
+848,"@@ -18,7 +18,7 @@ function FolderIcon () {
+ 
+ function VideoIcon () {
+   return (
+-    <svg aria-hidden=""true"" focusable=""false"" viewBox=""0 0 58 58"">
++    <svg aria-hidden=""true"" focusable=""false"" style={{ width: 16, marginRight: 4 }} viewBox=""0 0 58 58"">",@arturi does this look good to you?,2020-07-17 09:01:29
+844,"@@ -18,7 +18,7 @@ function FolderIcon () {
+ 
+ function VideoIcon () {
+   return (
+-    <svg aria-hidden=""true"" focusable=""false"" viewBox=""0 0 58 58"">
++    <svg aria-hidden=""true"" focusable=""false"" viewBox=""0 0 58 58"" style={{ width: 16, marginRight: 4 }}>",what is the reason for this change? 🤔 ,2020-07-16 04:04:33
+600,"@@ -18,7 +18,7 @@ if (mode === 'build') {
+ } else if (mode === 'test') {
+   test()
+ } else {
+-  throw new Error(`First argument must be either 'build' or 'test'`)
++  throw new Error('First argument must be either \'build\' or \'test\'')","This is not better to me personally, you?",2019-10-04 12:07:39
+17,"@@ -180,16 +180,80 @@ Issues with this approach:
+ 
+ * Some stuff from Core won’t be used in React (or won’t be needed by all users), `updateAll()` for example, that is tied to current UI rendering implementation. *Might not be an issue if it’s just a few methods.*
+ 
+-C. Another approach is to create a separate version of Uppy for React, uppy-react, not use Core in it, re-create Core in form of UppyContainer, manage state in that (and possibly allow for Redux, Mobx or whatever else someone is using), while re-using some parts of current Uppy. This has been explored here: https://github.com/hedgerh/uppy-react.
+-
+-Ideally we would like to not end up with two separate versions — regular Uppy and React Uppy — that needs to be maintained and both updated each time. Though sometimes that’s exactly what lib authors are doing — creating separate React versions.
+-
+----
+-
+ Also, Yo-Yo (Bel) has some issues:
+ 
+ - Local network requests from `<img src="""">` are made on each state update. Not a big deal, but annoying and does not happing with vdom solutions, like Preact.
+ - Webcam currently flashes when state is updated (morphdom issue?).
+ - When using template strings it might be harder to re-use UI components in React, where JSX is a standard.
+ 
+ We are thinking about trying Preact for more stability and React compatibility, but not sure if it’s worth it.
++
++
++## Harry's Proposal
++---
++My proposal for Uppy's architecture and API address two use cases separately:
++
++1. Uppy when its used without React and state is managed internally
++
++2. Uppy when it's used with React, and the user manages their own state (or we provide a React container component that takes care of it for them.)  I'll refer to them as the ""vanilla/yo-yo"" and ""React"" use cases, respectively.
++
++### Vanilla (using yo-yo) with managed state
++
++So we have a problem. When we decouple rendering from Uppy, and a user is able to make their own custom UI, they'll need to be able to call on plugin methods to do things, like fetch a list of files from Google Drive, for example.  In our current setup, the core creates and holds an instance of every plugin, and outside UIs don't have direct access to these plugin instances.  To get around this, one idea we was to expose a bus/event emitter, and they could emit something like `bus.emit('google-drive:list-files', { directory: 'root' })` when they wanted to fetch a list of files.
++","Yes, this is an issue. Plus you can’t get a response after emitting event, but same with dispatcher. So it only updates state, which I guess is fine and aligns with data down — actions up approach. Instead of long actions like this we could allow accessing methods through core or actions shortcut, [like in FineUploader-React here](https://github.com/FineUploader/react-fine-uploader/blob/master/src/components/delete-button.jsx#L44). Like this: `actions.googleDrive.listFiles({ directory: 'root' })`.
+",2016-10-14 15:19:06
+18,"@@ -180,16 +180,80 @@ Issues with this approach:
+ 
+ * Some stuff from Core won’t be used in React (or won’t be needed by all users), `updateAll()` for example, that is tied to current UI rendering implementation. *Might not be an issue if it’s just a few methods.*
+ 
+-C. Another approach is to create a separate version of Uppy for React, uppy-react, not use Core in it, re-create Core in form of UppyContainer, manage state in that (and possibly allow for Redux, Mobx or whatever else someone is using), while re-using some parts of current Uppy. This has been explored here: https://github.com/hedgerh/uppy-react.
+-
+-Ideally we would like to not end up with two separate versions — regular Uppy and React Uppy — that needs to be maintained and both updated each time. Though sometimes that’s exactly what lib authors are doing — creating separate React versions.
+-
+----
+-
+ Also, Yo-Yo (Bel) has some issues:
+ 
+ - Local network requests from `<img src="""">` are made on each state update. Not a big deal, but annoying and does not happing with vdom solutions, like Preact.
+ - Webcam currently flashes when state is updated (morphdom issue?).
+ - When using template strings it might be harder to re-use UI components in React, where JSX is a standard.
+ 
+ We are thinking about trying Preact for more stability and React compatibility, but not sure if it’s worth it.
++
++
++## Harry's Proposal
++---
++My proposal for Uppy's architecture and API address two use cases separately:
++
++1. Uppy when its used without React and state is managed internally
++
++2. Uppy when it's used with React, and the user manages their own state (or we provide a React container component that takes care of it for them.)  I'll refer to them as the ""vanilla/yo-yo"" and ""React"" use cases, respectively.
++
++### Vanilla (using yo-yo) with managed state
++
++So we have a problem. When we decouple rendering from Uppy, and a user is able to make their own custom UI, they'll need to be able to call on plugin methods to do things, like fetch a list of files from Google Drive, for example.  In our current setup, the core creates and holds an instance of every plugin, and outside UIs don't have direct access to these plugin instances.  To get around this, one idea we was to expose a bus/event emitter, and they could emit something like `bus.emit('google-drive:list-files', { directory: 'root' })` when they wanted to fetch a list of files.
++
++I'm not a big fan of this.  The user becomes responsible for knowing the names of every single plugin event, which is prone to typos, and, in my opinion, it's a better pattern to be able to call functions directly to make these things happen vs. emitting events.
++
++My current proposal is to use Redux, or at least take a Redux-like approach, and have each plugin define a reducer and some action creators as an interface.  The core combines each reducer into a single one and holds it, along with a Redux store.
++
++Uppy would then pass down the Redux state, some core methods, and the dispatcher as ""props"" to the component, and the component would decide what to do with it all.
++
++The user code would look something like:
++
++```js
++import Uppy, { Remote, Uploader } from 'uppy'
++import DriveBrowser from 'uppy-ui'
++
++const uppy = new Uppy(someOptions)
++uppy.use(Remote, { source: 'drive' })
++uppy.use(Uploader)
++
++uppy.render(DriveBrowser, document.getElementById('root'))
++```
++
++The DriveBrowser component might look like:
++
++```js
++import { Remote } from 'uppy'
++const googleDrive = new Remote({ source: 'drive' })
++const { actions } = googleDrive
++
++const DriveBrowser = (props) => {
++  return html`
++    <div>
++      <button onclick=${props.dispatch(actions.list('root'))}>Get list of files</button>
++      /* ... */
++    </div>
++  `
++}
++```
++","> props.dispatch(actions.list('root'))
+
+Does this mean it’s including the function, `action.list('root')` in the dispatch?
+",2016-10-14 15:30:53
+19,"@@ -180,16 +180,80 @@ Issues with this approach:
+ 
+ * Some stuff from Core won’t be used in React (or won’t be needed by all users), `updateAll()` for example, that is tied to current UI rendering implementation. *Might not be an issue if it’s just a few methods.*
+ 
+-C. Another approach is to create a separate version of Uppy for React, uppy-react, not use Core in it, re-create Core in form of UppyContainer, manage state in that (and possibly allow for Redux, Mobx or whatever else someone is using), while re-using some parts of current Uppy. This has been explored here: https://github.com/hedgerh/uppy-react.
+-
+-Ideally we would like to not end up with two separate versions — regular Uppy and React Uppy — that needs to be maintained and both updated each time. Though sometimes that’s exactly what lib authors are doing — creating separate React versions.
+-
+----
+-
+ Also, Yo-Yo (Bel) has some issues:
+ 
+ - Local network requests from `<img src="""">` are made on each state update. Not a big deal, but annoying and does not happing with vdom solutions, like Preact.
+ - Webcam currently flashes when state is updated (morphdom issue?).
+ - When using template strings it might be harder to re-use UI components in React, where JSX is a standard.
+ 
+ We are thinking about trying Preact for more stability and React compatibility, but not sure if it’s worth it.
++
++
++## Harry's Proposal
++---
++My proposal for Uppy's architecture and API address two use cases separately:
++
++1. Uppy when its used without React and state is managed internally
++
++2. Uppy when it's used with React, and the user manages their own state (or we provide a React container component that takes care of it for them.)  I'll refer to them as the ""vanilla/yo-yo"" and ""React"" use cases, respectively.
++
++### Vanilla (using yo-yo) with managed state
++
++So we have a problem. When we decouple rendering from Uppy, and a user is able to make their own custom UI, they'll need to be able to call on plugin methods to do things, like fetch a list of files from Google Drive, for example.  In our current setup, the core creates and holds an instance of every plugin, and outside UIs don't have direct access to these plugin instances.  To get around this, one idea we was to expose a bus/event emitter, and they could emit something like `bus.emit('google-drive:list-files', { directory: 'root' })` when they wanted to fetch a list of files.
++
++I'm not a big fan of this.  The user becomes responsible for knowing the names of every single plugin event, which is prone to typos, and, in my opinion, it's a better pattern to be able to call functions directly to make these things happen vs. emitting events.
++
++My current proposal is to use Redux, or at least take a Redux-like approach, and have each plugin define a reducer and some action creators as an interface.  The core combines each reducer into a single one and holds it, along with a Redux store.
++
++Uppy would then pass down the Redux state, some core methods, and the dispatcher as ""props"" to the component, and the component would decide what to do with it all.
++
++The user code would look something like:
++
++```js
++import Uppy, { Remote, Uploader } from 'uppy'
++import DriveBrowser from 'uppy-ui'
++
++const uppy = new Uppy(someOptions)
++uppy.use(Remote, { source: 'drive' })
++uppy.use(Uploader)
++
++uppy.render(DriveBrowser, document.getElementById('root'))
++```
++
++The DriveBrowser component might look like:
++
++```js
++import { Remote } from 'uppy'
++const googleDrive = new Remote({ source: 'drive' })
++const { actions } = googleDrive
++
++const DriveBrowser = (props) => {
++  return html`
++    <div>
++      <button onclick=${props.dispatch(actions.list('root'))}>Get list of files</button>
++      /* ... */
++    </div>
++  `
++}
++```
++
++Here is an example of what the plugin itself may look like: https://github.com/transloadit/uppy/blob/master/src/experimental/plugins/Remote.js
++
++Some things to note here:
++1. `Remote` is a generic plugin to interface with any remote provider, like Google Drive, Dropbox, Instagram, etc.
++
++2. Another one of the benefits to this approach is that we do away with all of the boilerplate methods that we currently have: `install`, `focus`, `update`, and `mount`.
++","> we do away with all of the boilerplate methods that we currently have: `install`, `focus`, `update`, and `mount`
+
+Not sure I understand how mounting/updating will work with your solution. Ok, you want the user to call `render` manually, that’s fine. But `update` is still needed for the component to update itself when state changes? `focus` is needed to indicate that component is currently active, so its called after googleDrive tab is selected in Dashboard, for example.
+",2016-10-14 15:34:09
+20,"@@ -180,16 +180,80 @@ Issues with this approach:
+ 
+ * Some stuff from Core won’t be used in React (or won’t be needed by all users), `updateAll()` for example, that is tied to current UI rendering implementation. *Might not be an issue if it’s just a few methods.*
+ 
+-C. Another approach is to create a separate version of Uppy for React, uppy-react, not use Core in it, re-create Core in form of UppyContainer, manage state in that (and possibly allow for Redux, Mobx or whatever else someone is using), while re-using some parts of current Uppy. This has been explored here: https://github.com/hedgerh/uppy-react.
+-
+-Ideally we would like to not end up with two separate versions — regular Uppy and React Uppy — that needs to be maintained and both updated each time. Though sometimes that’s exactly what lib authors are doing — creating separate React versions.
+-
+----
+-
+ Also, Yo-Yo (Bel) has some issues:
+ 
+ - Local network requests from `<img src="""">` are made on each state update. Not a big deal, but annoying and does not happing with vdom solutions, like Preact.
+ - Webcam currently flashes when state is updated (morphdom issue?).
+ - When using template strings it might be harder to re-use UI components in React, where JSX is a standard.
+ 
+ We are thinking about trying Preact for more stability and React compatibility, but not sure if it’s worth it.
++
++
++## Harry's Proposal
++---
++My proposal for Uppy's architecture and API address two use cases separately:
++
++1. Uppy when its used without React and state is managed internally
++
++2. Uppy when it's used with React, and the user manages their own state (or we provide a React container component that takes care of it for them.)  I'll refer to them as the ""vanilla/yo-yo"" and ""React"" use cases, respectively.
++
++### Vanilla (using yo-yo) with managed state
++
++So we have a problem. When we decouple rendering from Uppy, and a user is able to make their own custom UI, they'll need to be able to call on plugin methods to do things, like fetch a list of files from Google Drive, for example.  In our current setup, the core creates and holds an instance of every plugin, and outside UIs don't have direct access to these plugin instances.  To get around this, one idea we was to expose a bus/event emitter, and they could emit something like `bus.emit('google-drive:list-files', { directory: 'root' })` when they wanted to fetch a list of files.
++
++I'm not a big fan of this.  The user becomes responsible for knowing the names of every single plugin event, which is prone to typos, and, in my opinion, it's a better pattern to be able to call functions directly to make these things happen vs. emitting events.
++
++My current proposal is to use Redux, or at least take a Redux-like approach, and have each plugin define a reducer and some action creators as an interface.  The core combines each reducer into a single one and holds it, along with a Redux store.
++
++Uppy would then pass down the Redux state, some core methods, and the dispatcher as ""props"" to the component, and the component would decide what to do with it all.
++
++The user code would look something like:
++
++```js
++import Uppy, { Remote, Uploader } from 'uppy'
++import DriveBrowser from 'uppy-ui'
++
++const uppy = new Uppy(someOptions)
++uppy.use(Remote, { source: 'drive' })
++uppy.use(Uploader)
++
++uppy.render(DriveBrowser, document.getElementById('root'))
++```
++
++The DriveBrowser component might look like:
++
++```js
++import { Remote } from 'uppy'
++const googleDrive = new Remote({ source: 'drive' })
++const { actions } = googleDrive
++
++const DriveBrowser = (props) => {
++  return html`
++    <div>
++      <button onclick=${props.dispatch(actions.list('root'))}>Get list of files</button>
++      /* ... */
++    </div>
++  `
++}
++```
++
++Here is an example of what the plugin itself may look like: https://github.com/transloadit/uppy/blob/master/src/experimental/plugins/Remote.js
++
++Some things to note here:
++1. `Remote` is a generic plugin to interface with any remote provider, like Google Drive, Dropbox, Instagram, etc.
++
++2. Another one of the benefits to this approach is that we do away with all of the boilerplate methods that we currently have: `install`, `focus`, `update`, and `mount`.
++
++3. The `Remote` plugin example linked above extends `Remote` from a module I created called `uppy-base`. I created `uppy-base` while trying to figure out how to make Uppy work with React.  I took the bare functionality of Uppy that could be used universally (vanilla, React, Angular, anywhere) and put it into its own module.  The `uppy-base` plugins are stateless and not concerned with the UI.  Here is the `Remote` plugin from `uppy-base`: https://github.com/hedgerh/uppy-base/blob/master/src/plugins/Remote.js
++
++## React
++I'd like to give React users the freedom to manage their own Uppy state, whether they use internal state, or a state management lib like Redux.  The proposed solution of syncing the user's state to Uppy's internal state via event listeners, ie. `uppy.on('file-added', (file) => this.props.dispatch({ type: 'ADD_FILE', payload: file }))` is problematic because it violates the ""single source of truth"" principal, in that our state exists in two separate locations.  If we add a file, then roll back the add file action with time-travel debugging, the file will be removed from Redux's state, but still present in Uppy's state, causing de-synchronization between the two.
++
++The easiest solution I've found is to just use the `uppy-base` plugins directly in React, without Uppy's core.  Here is a comparison of core vs. no core: https://gist.github.com/hedgerh/9ad63f467ce816246044f3f9e83bd7e7
++
++For ease of use, we'd write a React container/wrapper component that abstracted away all of that from the user.  I've started on something like that here (bear in mind it's a bit messy):  https://github.com/hedgerh/uppy-react/blob/master/src/containers/UppyContainer.js
++
++and started on an example usage here: https://github.com/hedgerh/uppy-react/tree/master/examples/modal
++","React proposal here seems cool! Downsides and critique are missing though, to me they are:
+- Not clear how everything operates: each user comes up with his/her own method names, event names, file shapes.
+- If there is no Core, what calculates total progress, watches for internet connection going online/offline, knows about capabilities? What adds metadata to files?
+- Plugins behave differently (which might be fine if their base version has the same API), but seems like we’ll have Tus plugin for Vanilla Uppy and then another Tus for React Uppy.
+
+Basically, the problem is things getting out of sync between two versions and current React version not taking into account things like metadata and file shaping (Core’s [addFile()](https://github.com/transloadit/uppy/blob/master/src/core/Core.js#L109-L157)). _Could be solved by having a shared Utils lib that does all those things and replaces Core in that sense_.
+
+In [Core vs no-Core](https://gist.github.com/hedgerh/9ad63f467ce816246044f3f9e83bd7e7#file-uppyreduxcontainernocore-js) example you are effectively replacing Core with Uploader (which might be Tus or Multipart). That example probably shows our argument/discussion best — should we keep files in Core or manage them ourselves and pass to uploader plugin.
+
+Also is Kevin’s proposal to hot-swap Core’s internal state with Redux state not possible? When you do `uppy.addFile(file)` and it automagically ends up in Redux state instead of Uppy’s internal.
+",2016-10-14 16:09:37
+261,"@@ -180,23 +184,19 @@ module.exports = class Transloadit extends Plugin {
+           endpoint: assembly.tus_url
+         })
+ 
+-        // Set uppy server location.
+-        // we only add this, if 'file' has the attribute remote, because
+-        // this is the criteria to identify remote files. If we add it without
+-        // the check, then the file automatically becomes a remote file.
+-        // @TODO: this is quite hacky. Please fix this later
+-        let remote
+-        if (file.remote) {
++        // Set uppy server location. We only add this, if 'file' has the attribute
++        // remote, because this is the criteria to identify remote files.
++        // We only replace the hostname for Transloadit's uppy-servers, so that
++        // people can self-host them while still using Transloadit for encoding.
++        let remote = file.remote
++        if (file.remote && TL_UPPY_SERVER.test(file.remote)) {","Trying to make sense of this in my head. If you are using Transloadit and your own Uppy Server, where does the Transloadit’s Uppy Server come from in the first place? Transloadit plugin forces it, and here we are overwriting it back? This is also tied to `service` option, which is basically “you might want to decide which API endpoint to use yourself, forgoing the load balancer”. I apologize in advance for asking this :)",2018-05-09 21:26:36
+496,"@@ -180,8 +180,13 @@ module.exports = class XHRUpload extends Plugin {
+       formPost.append(item, file.meta[item])
+     })
+ 
++    // Set `file.data.type` in the blob to `file.meta.type`,
++    // because we might have detected a more accurate file type in Uppy
++    // https://stackoverflow.com/a/50875615
++    file.data = file.data.slice(0, file.data.size, file.meta.type)",maybe we should have a reused `copyWithNewType` function? So that the comment and stackoverflow reference will only live in one place? And also the name is friendlier to read throughout the code,2019-06-05 10:47:30
+757,"@@ -181,16 +182,16 @@ if (app.get('env') === 'production') {
+     // if the error is a URIError from the requested URL we only log the error message
+     // to avoid uneccessary error alerts
+     if (err.status === 400 && err instanceof URIError) {
+-      console.error('\x1b[31m', req.id, err.message, '\x1b[0m')
++      logger.error(err.message, 'root.error', req.id)
+     } else {
+-      console.error('\x1b[31m', req.id, err, '\x1b[0m')
++      logger.error(err, 'root.error', req.id, true)","this `true` argument is a little unclear to me, maybe `{ logStackTrace: true }` as an option is better?",2020-04-29 13:16:30
+499,"@@ -181,6 +186,8 @@ export COMPANION_UPLOAD_URLS=""http://master.tus.io/files/,https://master.tus.io/
+ 
+ See [env.example.sh](https://github.com/transloadit/uppy/blob/master/env.example.sh) for an example configuration script.
+ 
++If a `...SECRET_FILE""` environment variable is defined, the according `secret` will be overridden by the file's content.","I think this note should be added as a comment above the `COMPANION_AWS_SECRET_FILE` (and others) option itself. I fear a lot of users will find the `...SECRET_FILE""` notation confusing, and it also doesn't follow the current pattern of the documentation",2019-06-05 14:37:28
+115,"@@ -182,25 +196,35 @@ module.exports = class Tus10 extends Plugin {
+         isPaused ? upload.abort() : upload.start()
+       })
+ 
+-      this.onPauseAll(file.id, () => {
++      this.onRetry(file.id, () => {
+         upload.abort()
++        upload.start()
+       })
+ 
+-      this.onResumeAll(file.id, () => {
++      this.onRetryAll(file.id, () => {
++        upload.abort()
+         upload.start()
+       })
+ 
+-      this.core.on('core:retry-started', () => {
+-        const files = this.core.getState().files
+-        if (files[file.id].progress.uploadComplete ||
+-          !files[file.id].progress.uploadStarted ||
+-          files[file.id].isPaused
+-            ) {
+-          return
+-        }
++      this.onPauseAll(file.id, () => {
++        upload.abort()
++      })
++
++      this.onResumeAll(file.id, () => {
+         upload.start()
+       })","I guess this is made a bit ""simpler"" by attaching the handlers using these `onResumeAll` helper methods. You're right that it's a bit confusing tho. We could inline them here, I don't think it hurts readability much, and it's just one more line each.",2017-09-29 14:19:06
+131,"@@ -182,8 +177,14 @@ function getFileTypeExtension (mimeType) {
+   return mimeToExtensions[mimeType] || null
+ }
+ 
+-// returns [fileName, fileExt]
++/**
++* Takes a full filename string and returns an array of [fileName, fileExt]
++*
++* @param {string} fullFileName
++* @return {array} [fileName, fileExt]
++*/
+ function getFileNameAndExtension (fullFileName) {
++  if (!fullFileName) return","is this still necessary now that we check the `file.name` before calling this function? if this sometimes returns an array and sometimes returns `undefined`, we may have to check the result type whenever we use it.",2017-10-24 07:31:26
+329,"@@ -183,16 +183,18 @@ module.exports = class AwsS3Multipart extends Plugin {
+         onPartComplete: (part) => {
+           // Store completed parts in state.
+           const cFile = this.uppy.getFile(file.id)
+-          this.uppy.setFileState(file.id, {
+-            s3Multipart: Object.assign({}, cFile.s3Multipart, {
+-              parts: [
+-                ...cFile.s3Multipart.parts,
+-                part
+-              ]
++          if (cFile) {","Thanks! Maybe we could return early here, something like `if (!cFile) return`, then we don’t need deep nesting.",2018-08-01 15:19:05
+904,"@@ -183,7 +183,7 @@ class DropBox extends Provider {
+       .auth(token)
+       .request((err, resp) => {
+         if (err || resp.statusCode !== 200) {
+-          logger.error(err, 'provider.dropbox.size.error')
++          logger.error(err, 'provider.dropbox.logout.error')",👍 ,2020-10-21 17:16:08
+724,"@@ -185,105 +208,96 @@ module.exports = class AwsS3 extends Plugin {
+           xhrOpts.headers = headers
+         }
+ 
+-        const updatedFile = {
+-          ...file,
++        this.uppy.setFileState(file.id, {
+           meta: { ...file.meta, ...fields },
+           xhrUpload: xhrOpts
+-        }
+-
+-        updatedFiles[id] = updatedFile
+-      })
+-
+-      const { files } = this.uppy.getState()
+-      this.uppy.setState({
+-        files: {
+-          ...files,
+-          ...updatedFiles
+-        }
+-      })
++        })
+ 
+-      fileIDs.forEach((id) => {
+-        const file = this.uppy.getFile(id)
+-        this.uppy.emit('preprocess-complete', file)
++        return this._uploader.uploadFile(file.id, index, numberOfFiles)
++      }).catch((error) => {
++        delete paramsPromises[id]
++        this.uppy.emit('upload-error', file, error)
+       })
++    })).then((settled) => {
++      // cleanup.
++      this.uppy.off('file-removed', onremove)
++      return settled
+     })
+   }
+ 
+   install () {
+-    const { log } = this.uppy
+-    this.uppy.addPreProcessor(this.prepareUpload)
+-
+-    let warnedSuccessActionStatus = false
+-    const xhrUploadOpts = {
+-      fieldName: 'file',
+-      responseUrlFieldName: 'location',
+-      timeout: this.opts.timeout,
+-      __queue: this.requests,
+-      responseType: 'text',
+-      // Get the response data from a successful XMLHttpRequest instance.
+-      // `content` is the S3 response as a string.
+-      // `xhr` is the XMLHttpRequest instance.
+-      getResponseData (content, xhr) {
+-        const opts = this
+-
+-        // If no response, we've hopefully done a PUT request to the file
+-        // in the bucket on its full URL.
+-        if (!isXml(content, xhr)) {
+-          if (opts.method.toUpperCase() === 'POST') {
+-            if (!warnedSuccessActionStatus) {
+-              log('[AwsS3] No response data found, make sure to set the success_action_status AWS SDK option to 201. See https://uppy.io/docs/aws-s3/#POST-Uploads', 'warning')
+-              warnedSuccessActionStatus = true
+-            }
+-            // The responseURL won't contain the object key. Give up.
+-            return { location: null }
+-          }
+-
+-          // responseURL is not available in older browsers.
+-          if (!xhr.responseURL) {
+-            return { location: null }
++    const uppy = this.uppy
++    this.uppy.addUploader(this.handleUpload)
++
++    // Get the response data from a successful XMLHttpRequest instance.
++    // `content` is the S3 response as a string.
++    // `xhr` is the XMLHttpRequest instance.
++    function defaultGetResponseData (content, xhr) {
++      const opts = this
++
++      // If no response, we've hopefully done a PUT request to the file
++      // in the bucket on its full URL.
++      if (!isXml(content, xhr)) {
++        if (opts.method.toUpperCase() === 'POST') {
++          if (!warnedSuccessActionStatus) {
++            uppy.log('[AwsS3] No response data found, make sure to set the success_action_status AWS SDK option to 201. See https://uppy.io/docs/aws-s3/#POST-Uploads', 'warning')
++            warnedSuccessActionStatus = true
+           }
+-
+-          // Trim the query string because it's going to be a bunch of presign
+-          // parameters for a PUT request—doing a GET request with those will
+-          // always result in an error
+-          return { location: xhr.responseURL.replace(/\?.*$/, '') }
++          // The responseURL won't contain the object key. Give up.
++          return { location: null }
+         }
+ 
+-        return {
+-          // Some S3 alternatives do not reply with an absolute URL.
+-          // Eg DigitalOcean Spaces uses /$bucketName/xyz
+-          location: resolveUrl(xhr.responseURL, getXmlValue(content, 'Location')),
+-          bucket: getXmlValue(content, 'Bucket'),
+-          key: getXmlValue(content, 'Key'),
+-          etag: getXmlValue(content, 'ETag')
+-        }
+-      },
+-
+-      // Get the error data from a failed XMLHttpRequest instance.
+-      // `content` is the S3 response as a string.
+-      // `xhr` is the XMLHttpRequest instance.
+-      getResponseError (content, xhr) {
+-        // If no response, we don't have a specific error message, use the default.
+-        if (!isXml(content, xhr)) {
+-          return
++        // responseURL is not available in older browsers.
++        if (!xhr.responseURL) {
++          return { location: null }
+         }
+-        const error = getXmlValue(content, 'Message')
+-        return new Error(error)
++
++        // Trim the query string because it's going to be a bunch of presign
++        // parameters for a PUT request—doing a GET request with those will
++        // always result in an error
++        return { location: xhr.responseURL.replace(/\?.*$/, '') }
++      }
++
++      return {
++        // Some S3 alternatives do not reply with an absolute URL.
++        // Eg DigitalOcean Spaces uses /$bucketName/xyz
++        location: resolveUrl(xhr.responseURL, getXmlValue(content, 'Location')),
++        bucket: getXmlValue(content, 'Bucket'),
++        key: getXmlValue(content, 'Key'),
++        etag: getXmlValue(content, 'ETag')
+       }
+     }
+ 
+-    // Replace getResponseData() with overwritten version.
+-    if (this.opts.getResponseData) {
+-      xhrUploadOpts.getResponseData = this.opts.getResponseData
++    // Get the error data from a failed XMLHttpRequest instance.
++    // `content` is the S3 response as a string.
++    // `xhr` is the XMLHttpRequest instance.
++    function defaultGetResponseError (content, xhr) {
++      // If no response, we don't have a specific error message, use the default.
++      if (!isXml(content, xhr)) {
++        return
++      }
++      const error = getXmlValue(content, 'Message')
++      return new Error(error)
+     }
+ 
+-    this.uppy.use(XHRUpload, xhrUploadOpts)
++    const xhrOptions = {
++      fieldName: 'file',
++      responseUrlFieldName: 'location',
++      timeout: this.opts.timeout,
++      // Share the rate limiting queue with XHRUpload.
++      __queue: this.requests,","curious, so this options is prefixed with `__` because it's meant for internal use only?",2020-04-02 13:36:50
+890,"@@ -185,13 +187,13 @@ class Zoom extends Provider {
+   }
+ 
+   _initializeData (body, initialEnd = null) {
+-    let end = initialEnd || moment()
+-    const accountCreation = adapter.getAccountCreationDate(body)
+-    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months').date(1)
++    let end = initialEnd || moment.utc().tz(body.timezone || 'UTC')","we convert `cursor` and `end` (and everything that relies on it) to local time. this was done this way (rather than just adjusting display in adapter) because we need to show the information in local time anyways, and we need access to from / to dates in local timezone to correctly filter out extra results in the `/provider/list` call once a user clicks into a date range.   I couldn't think of a better way to do it that would retain this from/to local times",2020-09-11 21:17:52
+324,"@@ -186,9 +186,11 @@ module.exports = class ThumbnailGenerator extends Plugin {
+       return this.createThumbnail(file, this.opts.thumbnailWidth)
+         .then(preview => {
+           this.setPreviewURL(file.id, preview)
++          this.uppy.emit('thumbnail:generated', this.uppy.getFile(file.id), preview)
+         })
+         .catch(err => {
+           console.warn(err.stack || err.message)
++          this.uppy.emit('thumbnail:error', this.uppy.getFile(file.id), err)","So `thumbnail:ready` is when all are ready, and `thumbnail:generated` is for single? Maybe add `all-` to it then, `thumbnail:all-ready` or `thumbnail:all-generated`?",2018-07-19 16:34:47
+883,"@@ -188,16 +188,18 @@ class Zoom extends Provider {
+     let start = end.clone().date(1)
+ 
+     const accountCreation = adapter.getAccountCreationDate(body)
+-    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months')
+-    const limit = accountCreation > defaultLimit ? accountCreation : defaultLimit
++    const defaultLimit = end.clone().subtract(DEFAULT_RANGE_MOS, 'months').date(1)
++    const allResultsShown = accountCreation > defaultLimit
++    const limit = allResultsShown ? accountCreation : defaultLimit
+ 
+     const data = {
+       items: [],
+       username: adapter.getUserEmail(body)
+     }
+ 
+-    while (start > limit) {
+-      start = end.clone().date(1)
++    while (start.isSameOrAfter(limit, 'month')) {
++      start = end.isSame(limit, 'month') ? limit.clone() : end.clone().date(1)","maybe we should add a comment here, hinting at what date scenarios this ternary is catching? It took me some time to figure what it was about.",2020-09-09 11:13:54
+279,"@@ -189,104 +177,6 @@ function isObjectURL (url) {
+   return url.indexOf('blob:') === 0
+ }
+ 
+-function getProportionalHeight (img, width) {
+-  const aspect = img.width / img.height
+-  return Math.round(width / aspect)
+-}
+-
+-/**
+- * Create a thumbnail for the given Uppy file object.
+- *
+- * @param {{data: Blob}} file
+- * @param {number} width
+- * @return {Promise}
+- */
+-function createThumbnail (file, targetWidth) {
+-  const originalUrl = URL.createObjectURL(file.data)
+-  const onload = new Promise((resolve, reject) => {
+-    const image = new Image()
+-    image.src = originalUrl
+-    image.onload = () => {
+-      URL.revokeObjectURL(originalUrl)
+-      resolve(image)
+-    }
+-    image.onerror = () => {
+-      // The onerror event is totally useless unfortunately, as far as I know
+-      URL.revokeObjectURL(originalUrl)
+-      reject(new Error('Could not create thumbnail'))
+-    }
+-  })
+-
+-  return onload.then((image) => {
+-    const targetHeight = getProportionalHeight(image, targetWidth)
+-    const canvas = resizeImage(image, targetWidth, targetHeight)
+-    return canvasToBlob(canvas, 'image/png')
+-  }).then((blob) => {
+-    return URL.createObjectURL(blob)
+-  })
+-}
+-","@goto-bus-stop fine to remove this, right?",2018-05-28 02:47:58
+39,"@@ -189,12 +189,13 @@ class Uppy {
+       this.addThumbnail(newFile.id)
+     }
+ 
+-    if (this.opts.autoProceed) {
+-      this.upload()
+-        .catch((err) => {
++    if (this.opts.autoProceed && !this.scheduledAutoProceed) {
++      this.scheduledAutoProceed = setTimeout(() => {
++        this.scheduledAutoProceed = null
++        this.upload().catch((err) => {
+           console.error(err.stack || err.message)
+         })
+-      // this.bus.emit('core:upload')
++      }, 4)","This timeout is to debounce uploads being started. Previously this would start a new upload for each individual file that was added, if `autoProceed` is enabled. Eg, dropping 5 files would call upload() 5 times. Since the Transloadit plugin creates an assembly for all files when an upload is started, it's best if it can grab all new files in a single upload() call. With this timeout dropping 5 files calls upload() a single time.",2017-05-31 20:40:00
+288,"@@ -189,7 +197,11 @@ module.exports = class Url extends Plugin {
+         if (item.kind === 'string' && item.type === 'text/plain') {
+           item.getAsString((url) => {
+             this.uppy.log(`[URL] Adding file from pasted url: ${url}`)
+-            this.addFile(url)
++            try {
++              this.addFile(url)",ditto,2018-05-31 10:19:18
+529,"@@ -19,10 +19,26 @@ const renderFileSource = (props) => (
+   </div>
+ )
+ 
+-const renderFileName = (props) =>
+-  <div class=""uppy-DashboardItem-name"">
+-    {truncateString(props.file.meta.name, props.currentWidth > 606 ? 35 : 60)}
+-  </div>
++const renderFileName = (props) => {
++  // Take up at most 2 lines on any screen
++  let maxNameLength
++  // For very small mobile screens
++  if (props.containerWidth < 352) {
++    maxNameLength = 35
++  // For regular mobile screens
++  } else if (props.containerWidth < 577) {
++    maxNameLength = 60
++  // For desktops
++  } else {
++    maxNameLength = 35
++  }","This works 👍 but I wonder if those need to be in sync with:
+
+```js
+{ 'uppy-size--md': props.containerWidth > 576 },
+{ 'uppy-size--lg': props.containerWidth > 700 },
+{ 'uppy-size--xl': props.containerWidth > 900 },
+```
+
+I’m not a fan of using arbitrary numbers.
+
+🤔 ",2019-06-24 16:08:00
+167,"@@ -19,29 +23,28 @@ module.exports = (props) => {
+     `
+   }
+ 
+-  const input = html`
+-    <input class=""UppyDashboard-input""
+-          hidden=""true""
+-          aria-hidden=""true"" 
+-          tabindex=""-1"" 
+-          type=""file"" 
+-          name=""files[]"" 
+-          multiple=""true""
+-          onchange=${props.handleInputChange} />`
+-
+   return html`<div class=""UppyDashboardTabs"">
+       <ul class=""UppyDashboardTabs-list"" role=""tablist"">
+         <li class=""UppyDashboardTab"" role=""presentation"">
+-          <button type=""button"" class=""UppyDashboardTab-btn""
++          <button type=""button"" 
++                  class=""UppyDashboardTab-btn""
+                   role=""tab""
+                   tabindex=""0""
+-                  onclick=${(ev) => {
+-                    input.click()
+-                  }}>
++                  onclick=${ev => inputEl.click()}>
+             ${localIcon()}
+             <h5 class=""UppyDashboardTab-name"">${props.i18n('myDevice')}</h5>
+           </button>
+-          ${input}
++          <input class=""UppyDashboard-input""
++                 hidden=""true""
++                 aria-hidden=""true"" 
++                 tabindex=""-1"" 
++                 type=""file"" 
++                 name=""files[]"" 
++                 multiple=""true""
++                 onchange=${props.handleInputChange} 
++                 ref=${(input) => {
++                   inputEl = input
++                 }} />","oh nice, you already inlined the `<input>` here :D ",2017-12-13 21:38:00
+743,"@@ -19,6 +21,10 @@ function buildResponseError (xhr, error) {
+     error = Object.assign(new Error('Upload error'), { data: error })
+   }
+ 
++  if (isNetworkError(xhr)) {
++    error = new NetworkError(error)","for consistent behaviour, would it make sense to pass xhr to `NetworkError` and return early like so:
+
+```js
+if (isNetworkError(xhr)) {
+    error = new NetworkError(error, xhr)
+    return error
+}
+```
+
+and then change [this field](https://github.com/transloadit/uppy/pull/2110/files#diff-dcd2ff4fc4c4c209bccb7194f0206d8fR6) from `originalRequest` to `request`.  Changing the field will make it consistent with how it's done in `xhr-upload` already.
+
+Returning early will prevent any unintended changes on the NetworkError object which may be added after the `if(...)` block. This will make the `NetworkError` class consistent. 
+
+If we agree with this suggestion, we can do the same for `MiniXhrUpload`",2020-04-17 12:50:47
+112,"@@ -19,7 +19,7 @@ module.exports = class Plugin {
+     this.opts = opts || {}
+ 
+     // clear everything inside the target selector
+-    this.opts.replaceTargetContent === this.opts.replaceTargetContent || true
++    this.opts.replaceTargetContent = this.opts.replaceTargetContent !== undefined ? this.opts.replaceTargetContent : true",good catch! strange that the linter didn't catch this!,2017-09-20 18:39:06
+925,"@@ -190,6 +190,7 @@
+     .use(Uppy.GoogleDrive, { target: Uppy.Dashboard, companionUrl: COMPANION_ENDPOINT })
+     .use(Uppy.Instagram, { target: Uppy.Dashboard, companionUrl: COMPANION_ENDPOINT })
+     .use(Uppy.Dropbox, { target: Uppy.Dashboard, companionUrl: COMPANION_ENDPOINT })
++    .use(Uppy.Box, { target: Uppy.Dashboard, companionUrl: COMPANION_ENDPOINT })","excluding from example in the mean time
+```suggestion
+```",2020-11-13 09:11:40
+602,"@@ -190,6 +190,8 @@ export COMPANION_AWS_SECRET=""YOUR AWS SECRET""
+ export COMPANION_AWS_SECRET_FILE=""PATH/TO/AWS/SECRET/FILE""
+ export COMPANION_AWS_BUCKET=""YOUR AWS S3 BUCKET""
+ export COMPANION_AWS_REGION=""AWS REGION""
++# to enable S3 Transfer Acceleration (default: false)
++export export COMPANION_AWS_USE_ACCELERATE_ENDPOINT=""false""","```suggestion
+export COMPANION_AWS_USE_ACCELERATE_ENDPOINT=""false""
+```",2019-10-11 10:23:53
+509,"@@ -190,6 +195,11 @@ module.exports = class XHRUpload extends Plugin {
+   }
+ 
+   createBareUpload (file, opts) {
++    // Set `file.data.type` in the blob to `file.meta.type`,
++    // because we might have detected a more accurate file type in Uppy
++    // https://stackoverflow.com/a/50875615
++    file.data = file.data.slice(0, file.data.size, file.meta.type)","This doesn't have any effect for bare uploads, those only send the raw bytes",2019-06-12 08:11:34
+72,"@@ -196,27 +243,31 @@ module.exports = class Transloadit extends Plugin {
+     })
+   }
+ 
+-  prepareUpload (fileIDs) {
+-    const filesToUpload = fileIDs.map(getFile, this).reduce(intoFileMap, {})
+-    function getFile (fileID) {
+-      return this.core.state.files[fileID]
+-    }
+-    function intoFileMap (map, file) {
+-      map[file.id] = file
+-      return map
+-    }
++  getFile (fileID) {
++    return this.core.state.files[fileID]
++  }
+ 
++  prepareUpload (fileIDs) {
+     fileIDs.forEach((fileID) => {
+       this.core.emit('core:preprocess-progress', fileID, {
+         mode: 'indeterminate',
+         message: this.opts.locale.strings.creatingAssembly
+       })
+     })
+-    return this.createAssembly(filesToUpload).then(() => {
+-      fileIDs.forEach((fileID) => {
+-        this.core.emit('core:preprocess-complete', fileID)
++
++    const createAssembly = ({ fileIDs, options }) => {
++      return this.createAssembly(fileIDs, options).then(() => {
++        fileIDs.forEach((fileID) => {
++          this.core.emit('core:preprocess-complete', fileID)
++        })
+       })
+-    })
++    }
++
++    return this.getAssemblyOptions(fileIDs)
++      .then(this.dedupeAssemblyOptions, this)",Uh. that should be an arrow function,2017-07-11 13:20:54
+974,"@@ -196,6 +196,8 @@ Even with these CORS rules in place, you browser might still encounter HTTP stat
+ 
+ It will list general *Public access settings for this bucket*, which can override the rules imposed by your CORS settings. Click on *edit* to manage these settings. Under *Manage public access control lists (ACLs) for this bucket*, make sure that *Block new public ACLs and uploading public objects (Recommended)* is unchecked, and *Save* these settings.
+ 
++If you are using an IAM policy to allow access to the S3 bucket (which we recommend), the policy must have at least the s3:PutObject and s3:PutObjectAcl permissions scoped to the bucket in question.","```suggestion
+If you are using an IAM policy to allow access to the S3 bucket, the policy must have at least the `s3:PutObject` and `s3:PutObjectAcl` permissions scoped to the bucket in question.
+```",2021-01-25 12:23:11
+577,"@@ -196,9 +178,21 @@ module.exports = class Tus extends Plugin {
+ 
+       const upload = new tus.Upload(file.data, optsTus)
+       this.uploaders[file.id] = upload
+-      this.uploaderEvents[file.id] = createEventTracker(this.uppy)
++      this.uploaderEvents[file.id] = new EventTracker(this.uppy)
++
++      const queuedRequest = this.requests.run(() => {
++        if (!file.isPaused) {
++          upload.start()
++        }
++        // Don't do anything here, the caller will take care of cancelling the upload itself
++        // using resetUploaderReferences(). This is because resetUploaderReferences() has to be
++        // called when this request is still in the queue, and has not been started yet, too. At
++        // that point this cancellation function is not going to be called.
++        return () => {}",Question: so we have to call `this.resetUploaderReferences(file.id)` before `queuedRequest.abort()`?,2019-08-16 18:52:37
+341,"@@ -2,10 +2,10 @@
+ . ./env.sh
+ 
+ env \
+-  UPPYSERVER_DATADIR=""./output"" \
+-  UPPYSERVER_DOMAIN=""localhost:3020"" \
+-  UPPYSERVER_PROTOCOL=""http"" \
+-  UPPYSERVER_PORT=3020 \
++  COMPANION_DATADIR=""./output"" \
++  COMPANION_DOMAIN=""localhost:3020"" \
++  COMPANION_PROTOCOL=""http"" \
++  COMPANION_PORT=3020 \
+   UPPY_ENDPOINTS="""" \",this would be a nice opportunity to namespace this env var name too,2018-09-03 11:53:25
+183,"@@ -2,11 +2,19 @@
+ * General Uppy styles that apply to everything inside the .Uppy container
+ */
+ 
+-.Uppy {
++.uppy {",why this caps change?,2017-12-20 18:19:45
+664,"@@ -2,12 +2,17 @@ import Uppy = require('@uppy/core');
+ 
+ declare module Tus {
+   export interface TusOptions extends Uppy.PluginOptions {
+-    limit: number;
+-    endpoint: string;
+-    uploadUrl: string;
+-    useFastRemoteRetry: boolean;
+     resume: boolean;
++    removeFingerprintOnSuccess: boolean;
++    endpoint: string;
++    headers: object;
++    chunkSize: number;
++    withCredentials: booleans;","small typo:
+```suggestion
+    withCredentials: boolean;
+```",2019-12-16 12:27:14
+294,"@@ -2,6 +2,14 @@
+ 
+ echo ""Preparing for end to end test: copying static HTML and CSS, building JS""
+ rm -rf ./test/endtoend/dist && mkdir ./test/endtoend/dist
+-cp ./dist/uppy.min.css ./test/endtoend/dist 
+-cp ./test/endtoend/src/index.html ./test/endtoend/dist 
++rm -rf ./test/endtoend/node_modules
++
++UPPY_VERSION=$(cat package.json | grep version | head -1 | awk -F= ""{ print $2 }"" | sed 's/[version:,\"",]//g' | tr -d '[[:space:]]')","How about `node -e 'console.log(require(""./package.json"").version)'` ?",2018-06-04 08:41:56
+292,"@@ -2,6 +2,14 @@
+ 
+ echo ""Preparing for end to end test: copying static HTML and CSS, building JS""
+ rm -rf ./test/endtoend/dist && mkdir ./test/endtoend/dist
+-cp ./dist/uppy.min.css ./test/endtoend/dist 
+-cp ./test/endtoend/src/index.html ./test/endtoend/dist 
++rm -rf ./test/endtoend/node_modules
++
++UPPY_VERSION=$(cat package.json | grep version | head -1 | awk -F= ""{ print $2 }"" | sed 's/[version:,\"",]//g' | tr -d '[[:space:]]')
++# archive the uppy package
++npm pack","I think we should also run the `npm run prepublishOnly` script first here, so that the package is exactly the same as the published one (I thought this would happen automatically inside `npm pack` but it doesn't seem to)",2018-06-04 08:13:39
+30,"@@ -2,6 +2,15 @@ const yo = require('yo-yo')
+ // const nanoraf = require('nanoraf')
+ 
+ /**
++ * Check if an object is a DOM element. Duck-typing based on `nodeType`.
++ *
++ * @param {*} obj
++ */
++function isDOMElement (obj) {
++  return obj && typeof obj === 'object' && obj.nodeType === Node.ELEMENT_NODE
++}
++
++/**
+  * Boilerplate that all Plugins share - and should not be used","Maybe we should move this function to a shared `helpers` folder. Like we currently have `Utils`, but I’d like to refactor that and have them as individual modules there.",2017-03-13 15:23:41
+575,"@@ -2,7 +2,7 @@
+ <link rel=""stylesheet"" href=""/uppy/uppy.min.css"">
+ 
+ <div class=""UppyForm"">
+-  <form action=""//api2.transloadit.com"">
++  <form action=""https://upload-endpoint.uppy.io/upload"">","This doesn't work if we disable Uppy js btw, but it will work if we add `<form action=""https://upload-endpoint.uppy.io/upload"" method=""POST"" enctype=""multipart/form-data"">`.
+
+However, I think that in 2019 having the form tag in an example may be more confusing than helpful ??? (I did get confused there for a second about whether we need the form tag).
+What do you think about removing `<form/>`, and just leaving `<div class=""UppyInput""/>`?",2019-08-15 17:44:59
+178,"@@ -2,7 +2,7 @@ const Plugin = require('../../core/Plugin')
+ const Translator = require('../../core/Translator')
+ const { toArray } = require('../../core/Utils')
+ const dragDrop = require('drag-drop')
+-const html = require('yo-yo')
++const preact = require('preact') // eslint-disable-line",can we tell eslint about what JSX is being compiled down to somehow? `/** @jsx preact.h */` at the top of the file would work but maybe there's an eslint rule option that we can use?,2017-12-14 20:33:10
+854,"@@ -2,7 +2,7 @@ const moment = require('moment')
+ 
+ const MIMETYPES = {
+   MP4: 'video/mp4',
+-  M4A: 'audio/mp4',
++  M4A: 'audio/m4a',","I think this should be audio/mp4. audio/m4a is not officially recognised by IANA as far as i can tell https://www.iana.org/assignments/media-types/media-types.xhtml
+
+the linked RFC https://tools.ietf.org/html/rfc4337#section-3.2 mentions audio/mp4 for audio-only MP4 files, which `.m4a` files are",2020-07-30 12:41:30
+420,"@@ -2,7 +2,7 @@ module.exports = function getSocketHost (url) {
+   // get the host domain
+   var regex = /^(?:https?:\/\/|\/\/)?(?:[^@\n]+@)?(?:www\.)?([^\n]+)/
+   var host = regex.exec(url)[1]
+-  var socketProtocol = location.protocol === 'https:' ? 'wss' : 'ws'
++  var socketProtocol = /^http:\/\//.test(url) ? 'ws' : 'wss'",Could use a `/<regex>/i` maybe?,2019-04-01 12:41:39
+327,"@@ -2,7 +2,8 @@ const request = require('request')
+ // @ts-ignore
+ const purest = require('purest')({ request })
+ const logger = require('../logger')
+-
++const DRIVE_FILE_FIELDS = 'kind,id,name,mimeType,ownedByMe,permissions(role,emailAddress),size,modifiedTime,iconLink,thumbnailLink'",why do we need to explicitly declare these fields?,2018-07-28 14:57:53
+603,"@@ -20,12 +20,11 @@ module.exports = (props) => {
+       <div class=""uppy-Provider-breadcrumbsIcon"">{props.breadcrumbsIcon}</div>
+       {
+         props.directories.map((directory, i) => (
+-          <Breadcrumb",@goto-bus-stop Breadcrumb seemed to be broken from [this change](https://github.com/transloadit/uppy/commit/733de659da17ee77afba9882633477fb7cd778dd#diff-3a8b11d5620b3d342e81e97925b37113L18). Is there a different way you would have fixed this?,2019-10-14 01:56:26
+800,"@@ -20,12 +20,16 @@ mv ./kubectl ${HOME}/.local/bin/
+ docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion;
+ docker login -u=""$DOCKER_USERNAME"" -p=""$DOCKER_PASSWORD"";
+ 
+-if [[ -z ""${TRAVIS_TAG}"" ]]; then
+-  docker push transloadit/companion:$TRAVIS_COMMIT;
+-else
++# Push the commit tagged docker image.
++docker push transloadit/companion:$TRAVIS_COMMIT;","This looks great, Thank you. ",2020-06-30 07:00:46
+801,"@@ -20,12 +20,16 @@ mv ./kubectl ${HOME}/.local/bin/
+ docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion;
+ docker login -u=""$DOCKER_USERNAME"" -p=""$DOCKER_PASSWORD"";
+ 
+-if [[ -z ""${TRAVIS_TAG}"" ]]; then
+-  docker push transloadit/companion:$TRAVIS_COMMIT;
+-else
++# Push the commit tagged docker image.
++docker push transloadit/companion:$TRAVIS_COMMIT;
++
++# If this build includes a git tag, tag the image with the git version tag and push the version.
++if [[ ! -z ""${TRAVIS_TAG}"" ]]; then
++  docker tag transloadit/companion:$TRAVIS_COMMIT transloadit/companion:$TRAVIS_TAG;","This one looks great, thanks. ",2020-06-30 07:01:00
+802,"@@ -20,12 +20,16 @@ mv ./kubectl ${HOME}/.local/bin/
+ docker build -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion;
+ docker login -u=""$DOCKER_USERNAME"" -p=""$DOCKER_PASSWORD"";
+ 
+-if [[ -z ""${TRAVIS_TAG}"" ]]; then
+-  docker push transloadit/companion:$TRAVIS_COMMIT;
+-else
++# Push the commit tagged docker image.
++docker push transloadit/companion:$TRAVIS_COMMIT;
++
++# If this build includes a git tag, tag the image with the git version tag and push the version.
++if [[ ! -z ""${TRAVIS_TAG}"" ]]; then
++  docker tag transloadit/companion:$TRAVIS_COMMIT transloadit/companion:$TRAVIS_TAG;
+   docker push transloadit/companion:$TRAVIS_TAG;
+ fi
+ 
++# Lastly, update the pointer to latest.",Thank you for the extra comment. ,2020-06-30 07:01:19
+536,"@@ -20,17 +20,18 @@ for t in $tests; do
+   cp ""${__root}/test/endtoend/$t/index.html"" ""${__root}/test/endtoend/$t/dist""
+   browserify ""${__root}/test/endtoend/$t/main.js"" \
+     -o ""${__root}/test/endtoend/$t/dist/bundle.js"" \
++    -t envify \
+     -t babelify
+ done
+ 
+ # Speeecial tests that need custom builds.
+ pushd ""${__root}/test/endtoend/create-react-app""
+   npm install
+-  npm run build
++  REACT_APP_ON_TRAVIS=""${TRAVIS:-}"" npm run build
+ popd
+ pushd ""${__root}/test/endtoend/typescript""
+   mkdir -p dist
+   cp ""${__root}/packages/uppy/dist/uppy.min.css"" dist/
+   cp index.html dist/
+-  browserify main.ts -p [ tsify --target ES3 ] -o dist/bundle.js
++  browserify main.ts -t envify -p [ tsify --target ES3 ] -o dist/bundle.js",`envify` is needed for that `REACT_APP_ON_TRAVIS` above?,2019-07-01 15:59:03
+191,"@@ -20,6 +20,14 @@ uppy.use(Tus, {
+ 
+ The Tus plugin supports all of [tus-js-client][]’s options. Additionally:
+ 
++### `resume: true`
++
++A boolean indicating whether tus should attempt to resume the upload if the upload has been started in the past. This includes storing the file’s upload url. Use false to force an entire reupload.
++
++Note that this opition is about resuming when you start an upload again with the same file, or when using [Golden Retriever](/docs/golden-retriever/), which will attempt to restore upload state to what it was before page refresh / browser crash. Even if you set `resume: false` when using Tus uploader, users will still be able to pause/resume an ongoing upload.",opition → option,2018-01-08 20:32:27
+934,"@@ -20,6 +20,7 @@ export { default as StatusBar } from '@uppy/status-bar'
+ 
+ // Acquirers
+ export { default as Dropbox } from '@uppy/dropbox'
++export { default as Box } from '@uppy/box'","excluding box from global module for now as it will initially be released as beta
+```suggestion
+```",2020-11-13 09:17:11
+461,"@@ -20,8 +20,8 @@ exports.config = Object.assign(base.config, {
+     { browserName: 'MicrosoftEdge', version: '14', platform: 'Windows 10' },
+     { browserName: 'MicrosoftEdge', version: '17', platform: 'Windows 10' },
+     // { browserName: 'safari', version: '11.0', platform: 'macOS 10.12' },
+-    { browserName: 'safari', version: '10.0', platformName: 'iOS', platformVersion: '10.0', deviceOrientation: 'portrait', deviceName: 'iPhone 6 Simulator', appiumVersion: '1.7.1' },
+-    { browserName: 'chrome', platformName: 'Android', platformVersion: '6.0', deviceOrientation: 'portrait', deviceName: 'Android Emulator', appiumVersion: '1.7.1' }
++    { browserName: 'safari', version: '10.0', platformName: 'iOS', platformVersion: '12.2', deviceOrientation: 'portrait', deviceName: 'iPhone 6 Simulator', recordScreenshots: false },
++    { browserName: 'chrome', platformName: 'Android', platformVersion: '6.0', deviceOrientation: 'portrait', deviceName: 'Android Emulator' }","So iOS version `12.2`, but Safari still `10.0`? 🤔 
+
+This is the config I get from the [Platform Configurator](https://wiki.saucelabs.com/display/DOCS/Platform+Configurator#/):
+
+```
+caps['browserName'] = 'Safari';
+caps['deviceName'] = 'iPhone 6 Simulator';
+caps['deviceOrientation'] = 'portrait';
+caps['platformVersion'] = '12.2';
+caps['platformName'] = 'iOS';
+```
+
+Also, why `recordScreenshots: false`, cause we have video?",2019-05-13 12:49:51
+947,"@@ -201,17 +201,19 @@
+     ""watchify"": ""3.11.1"",
+     ""webdriverio"": ""5.18.6"",
+     ""webpack"": ""4.44.1"",
+-    ""whatwg-fetch"": ""3.0.0""
++    ""whatwg-fetch"": ""3.0.0"",
++    ""vue-template-compiler"": ""^2.6.11""
+   },
+   ""scripts"": {
+     ""bootstrap"": ""lerna bootstrap"",
+     ""build:bundle"": ""node ./bin/build-bundle.js"",
+     ""build:clean"": ""rm -rf packages/*/lib packages/@uppy/*/lib packages/*/dist packages/@uppy/*/dist"",
+     ""build:companion"": ""cd ./packages/@uppy/companion && npm run build"",
+     ""build:css"": ""node ./bin/build-css.js"",
+-    ""build:js"": ""npm-run-all build:lib build:companion build:locale-pack build:bundle"",
++    ""build:js"": ""npm-run-all build:lib build:companion build:vue build:locale-pack build:bundle"",
+     ""build:lib"": ""node ./bin/build-lib.js"",
+     ""build:locale-pack"": ""node ./bin/locale-packs.js build"",
++    ""build:vue"": ""cd ./packages/@uppy/vue && npm run build"",",rename to test? or do we actually build something here?,2020-11-19 01:55:43
+200,"@@ -201,6 +201,20 @@ module.exports = class Dashboard extends Plugin {
+     }
+   }
+ 
++  scrollBehaviour (toggle) {
++    if (!this.opts.disablePageScrollWhenModalOpen) return
++    const body = document.querySelector('body')",could be just `document.body` i think?,2018-01-29 08:38:59
+201,"@@ -201,6 +201,20 @@ module.exports = class Dashboard extends Plugin {
+     }
+   }
+ 
++  scrollBehaviour (toggle) {
++    if (!this.opts.disablePageScrollWhenModalOpen) return
++    const body = document.querySelector('body')
++    switch (toggle) {
++      case 'enable':
++        Object.assign(body.style, { overflow: 'initial', height: 'initial' })","not sure about the implications of doing this…eg if i have set `overflow: hidden` on the body for some reason in my own css, this might change it once the modal closes. I feel like adding and removing a CSS class with `!important` rules from the body might be more reliable?",2018-01-29 08:44:11
+199,"@@ -201,6 +201,20 @@ module.exports = class Dashboard extends Plugin {
+     }
+   }
+ 
++  scrollBehaviour (toggle) {
++    if (!this.opts.disablePageScrollWhenModalOpen) return
++    const body = document.querySelector('body')
++    switch (toggle) {
++      case 'enable':
++        Object.assign(body.style, { overflow: 'initial', height: 'initial' })
++        break
++      case 'disable':
++        Object.assign(body.style, { overflow: 'hidden', height: '100vh' })
++        break","this looks a bit odd to me, could we just have two separate methods, eg `enableScrollBehavior` and `disableScrollBehavior`, instead?",2018-01-29 08:37:07
+293,"@@ -202,6 +203,8 @@ module.exports = class XHRUpload extends Plugin {
+       const xhr = new XMLHttpRequest()
+       const id = cuid()
+ 
++      xhr.withCredentials = this.opts.withCredentials
++      ",There is some trailing whitespace here (Do `npm run lint` to check),2018-06-04 08:19:16
+805,"@@ -202,6 +271,13 @@ class MultipartUploader {
+ 
+   _uploadPartBytes (index, url, headers) {
+     const body = this.chunks[index]
++    const { signal } = this.abortController
++
++    let defer
++    const promise = new Promise((resolve, reject) => {
++      defer = { resolve, reject }","so one downside I see to this approach is that if any unhandled error occurs anywhere in this function, it will not be caught by the Promise, and it will remain unhandled, and possibly unseen. But if we instead house the entire function inside the body of the promise:
+
+```js
+return new Promise((resolve, reject) => {
+  // entire function body here
+  ...
+})
+```
+It would always catch any unforeseen errors that may be thrown.
+",2020-07-01 17:10:20
+186,"@@ -204,7 +203,7 @@ See [env.example.sh](https://github.com/transloadit/uppy-server/blob/master/env.
+   - protocol - `http | https`
+   - host(required) - your server host (e.g localhost:3020, mydomain.com)
+   - path - the server path to where the uppy app is sitting (e.g if uppy server is at `mydomain.com/uppy`, then the path would be `/uppy`).
+-  - oauthDoamin - if you have multiple instances of uppy server with different(and maybe dynamic) subdomains, you can set a master domain(e.g `sub1.mydomain.com`) to handle your oauth authentication for you. This would then redirect to the slave subdomain with the required credentials on completion.
++  - oauthDoamin - if you have multiple instances of uppy server with different (and maybe dynamic) subdomains, you can set a master domain (e.g `sub1.mydomain.com`) to handle your oauth authentication for you. This would then redirect to the slave subdomain with the required credentials on completion.",there's also an `oauthDoamin` at the start of this line that should be `oauthDomain`,2018-01-02 11:35:49
+373,"@@ -204,8 +206,11 @@ const ProgressBarProcessing = (props) => {
+ const ProgressDetails = (props) => {
+   return <div class=""uppy-StatusBar-statusSecondary"">
+     { props.numUploads > 1 && props.i18n('filesUploadedOfTotal', { complete: props.complete, smart_count: props.numUploads }) + ' \u00B7 ' }
+-    { props.i18n('dataUploadedOfTotal', { complete: props.totalUploadedSize, total: props.totalSize }) + ' \u00B7 ' }
+-    { props.i18n('xTimeLeft', { time: props.totalETA }) }
++    { props.i18n('dataUploadedOfTotal', {
++      complete: prettyBytes(props.totalUploadedSize),
++      total: prettyBytes(props.totalSize)
++    }) + ' \u00B7 ' }
++    { props.i18n('xTimeLeft', { time: prettyETA(props.totalETA) }) }","> Do bytes and ETA formatting as late as possible
+
+Why as late as possible?",2018-11-19 14:49:00
+882,"@@ -209,9 +211,15 @@ class Zoom extends Provider {
+         modifiedDate: adapter.getDateFolderModified(end),
+         size: null
+       })
++
++      if (end.isSame(limit, 'month')) {","is this always the condition at which the loop will stop? If so, should we simply change the while loop to ` while (end.isAfter(limit, 'month')) {` or something similar instead?",2020-09-09 11:12:13
+884,"@@ -209,9 +211,15 @@ class Zoom extends Provider {
+         modifiedDate: adapter.getDateFolderModified(end),
+         size: null
+       })
++
++      if (end.isSame(limit, 'month')) {
++        break
++      }
++
+       end = start.clone().subtract(1, 'days')
+     }
+-    data.nextPagePath = adapter.getDateNextPagePath(start)
++
++    data.nextPagePath = adapter.getDateNextPagePath(start.clone(), allResultsShown)","I think we can just do:
+
+```js
+data.nextPagePath = allResultsShown ? null : adapter.getDateNextPagePath(start.clone())
+```
+
+and leave `getDateNextPagePath` as it was before this PR",2020-09-09 11:16:01
+465,"@@ -21,10 +21,15 @@ module.exports = function sendToken (req, res, next) {
+   const state = (req.session.grant || {}).state
+   if (state) {
+     const origin = oAuthState.getFromState(state, 'origin', req.uppy.options.secret)
++    const clientVersion = oAuthState.getFromState(
++      state,
++      'clientVersion',
++      req.uppy.options.secret
++    )
+     const allowedClients = req.uppy.options.clients
+     // if no preset clients then allow any client
+     if (!allowedClients || hasMatch(origin, allowedClients) || hasMatch(parseUrl(origin).host, allowedClients)) {
+-      return res.send(htmlContent(uppyAuthToken, origin))
++      return res.send(clientVersion ? htmlContent(uppyAuthToken, origin) : oldHtmlContent(uppyAuthToken, origin))","This works but we should add a todo to the changelog to use https://www.npmjs.com/package/semver for these checks, especially if we're going to have more breaking changes.",2019-05-17 13:35:51
+531,"@@ -21,14 +16,12 @@ module.exports = function FileItem (props) {
+   const isPaused = file.isPaused || false
+   const error = file.error || false
+ 
+-  const fileName = getFileNameAndExtension(file.meta.name).name
+-  const truncatedFileName = props.isWide ? truncateString(fileName, 30) : fileName
+-
+   const showRemoveButton = props.individualCancellation
+     ? !isUploaded
+     : !uploadInProgress && !isUploaded
+ 
+   const dashboardItemClass = classNames(
++    'uppy-u-reset',","Same here, is it beneficial to add it to the container?",2019-06-24 16:23:11
+119,"@@ -21,19 +21,16 @@ function buildUppyBundle (minify) {
+   var bundleFile = minify ? 'uppy.min.js' : 'uppy.js'
+ 
+   var b = browserify(src, { debug: true, standalone: 'Uppy' })
+-  if (minify) {
+-    b.plugin('minifyify', {
+-      map: bundleFile + '.map',
+-      output: path.join(distPath, bundleFile + '.map')
+-    })
+-  }
+-  // b.transform(yoyoify)
++  b.plugin(commonShakeify)
++  b.plugin(packFlat)
+   b.transform(babelify)
+   b.on('error', handleErr)
+ 
+   return new Promise(function (resolve, reject) {
+     if (minify) {
+       b.bundle()
++      .pipe(uglify())","Minifying the final result instead of the individual modules … common-shakeify only comments things, so minification needs to happen after common-shakeify.",2017-09-29 16:44:32
+446,"@@ -21,6 +16,7 @@
+     ""cors"": ""^2.8.4"",
+     ""formidable"": ""^1.2.1"",
+     ""npm-run-all"": ""^4.1.3"",
+-    ""rimraf"": ""^2.6.2""
++    ""rimraf"": ""^2.6.2"",
++    ""uppy"": ""^0.30.4""
+   }","I wonder if we need to add each individual uppy module instead of a bundle thing. So like `@uppy/core`, `@uppy/xhr-upload` etc.",2019-04-18 12:43:08
+379,"@@ -21,6 +21,17 @@ import ProgressBar from '@uppy/react/lib/ProgressBar'
+ import { ProgressBar } from '@uppy/react'
+ ```
+ 
++## CSS
++
++The `ProgressBar` plugin requires the following CSS for styling:
++
++```js
++import '@uppy/core/dist/style.css'
++import '@uppy/progress-bar/dist/style.css'
++```
++
++Import general Core styles from `@uppy/core/dist/style.css` first, then add the Informer styles from `@uppy/progress-bar/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.","```suggestion
+Import general Core styles from `@uppy/core/dist/style.css` first, then add the Progress Bar styles from `@uppy/progress-bar/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.
+```",2018-11-22 12:27:04
+378,"@@ -21,6 +21,17 @@ import StatusBar from '@uppy/react/lib/StatusBar'
+ import { StatusBar } from '@uppy/react'
+ ```
+ 
++## CSS
++
++The `StatusBar` component requires the following CSS for styling:
++
++```js
++import '@uppy/core/dist/style.css'
++import '@uppy/status-bar/dist/style.css'
++```
++
++Import general Core styles from `@uppy/core/dist/style.css` first, then add the Informer styles from `@uppy/status-bar/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.","```suggestion
+Import general Core styles from `@uppy/core/dist/style.css` first, then add the Status Bar styles from `@uppy/status-bar/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.
+```",2018-11-22 12:26:51
+990,"@@ -21,6 +21,7 @@ const XHRUpload = require('@uppy/xhr-upload/src')
+ const Transloadit = require('@uppy/transloadit/src')
+ const Form = require('@uppy/form/src')
+ const ImageEditor = require('@uppy/image-editor/src')
++const DomTarget = require('@uppy/dom-target/src')","```suggestion
+const DropTarget = require('@uppy/drop-target/src')
+```
+(and below)",2021-03-31 07:26:39
+891,"@@ -210,30 +212,43 @@ class Zoom extends Provider {
+         modifiedDate: adapter.getDateFolderModified(end),
+         size: null
+       })
+-      end = start.clone().subtract(1, 'days')
+-      // if the limit is mid-month, keep that exact date
+-      start = (end.isSame(limit, 'month') && limit.date() !== 1) ? limit.clone() : end.clone().date(1)
++      end = start.clone().subtract(1, 'days').endOf('day')
++      start = (end.isSame(limit, 'month') && limit.date() !== 1) ? limit.clone() : end.clone().date(1).startOf('day')
+     }
+-    data.nextPagePath = allResultsShown ? null : adapter.getDateNextPagePath(end.clone())
++    data.nextPagePath = allResultsShown ? null : adapter.getDateNextPagePath(end)
+     return data
+   }
+ 
+-  _adaptData (userResponse, results) {
++  _adaptData (userResponse, results, query) {
+     if (!results) {
+       return { items: [] }
+     }
+ 
++    // convert start limit from local time to UTC
++    const utcFrom = moment.tz(query.from, userResponse.timezone || 'UTC').startOf('day').tz('UTC')
++    const utcTo = moment.tz(query.to, userResponse.timezone || 'UTC').endOf('day').tz('UTC')
++
+     const data = {
+       nextPagePath: adapter.getNextPagePath(results),
+       items: [],
+       username: adapter.getUserEmail(userResponse)
+     }
+-    const items = results.meetings || results.recording_files.filter(file => file.file_type !== 'TIMELINE')
++
++    let items = []
++    if (results.meetings) {
++      items = results.meetings
++        .map(item => { return { ...item, utcStart: moment.utc(item.start_time) } })
++        .filter(item => moment.utc(item.start_time).isAfter(utcFrom) && moment.utc(item.start_time).isBefore(utcTo))","This filters out extra results, should account for cases below:
+
+case 1: user in PST (UTC-07:00) --> wants 08-01 to 08-31 (PST), API call for 08-01 to 09-01 (UST), filter out items starting after 09-01 06:59 UST (08-31 23:59 PST)
+case 2: user in KST (UTC+09:00) --> wants 08-01 to 08-31 (KST), API call for 07-31 to 08-31 (UST), filter out items starting before 07-31 15:00 UST (08-01 00:00 JST)",2020-09-11 21:25:54
+177,"@@ -210,9 +210,12 @@ module.exports = class DashboardUI extends Plugin {
+     document.body.classList.add('is-UppyDashboard-open')
+     document.body.style.top = `-${this.savedDocumentScrollPosition}px`
+ 
++    this.updateDashboardElWidth()
++    this.setFocusToFirstNode()
++
+     // timeout is needed because yo-yo/morphdom/nanoraf; not needed without nanoraf",lets get rid of this outdated comment! might be confusing otherwise,2017-12-13 21:53:10
+205,"@@ -211,10 +211,9 @@ module.exports = class Dashboard extends Plugin {
+     // save active element, so we can restore focus when modal is closed
+     this.savedActiveElement = document.activeElement
+ 
+-    // add class to body that sets position fixed, move everything back
+-    // to scroll position
+-    document.body.classList.add('uppy-Dashboard-isOpen')
+-    document.body.style.top = `-${this.savedScrollPosition}px`
++    if (!this.opts.disablePageScrollWhenModalOpen) {
++      document.body.classList.remove('uppy-Dashboard-isOpen')",I think this should be `.add`? :),2018-01-30 12:41:18
+678,"@@ -212,25 +212,31 @@ const getOptionsMiddleware = (options) => {
+   if (options.providerOptions.s3) {
+     const S3 = require('aws-sdk/clients/s3')
+     const AWS = require('aws-sdk')
+-    const config = options.providerOptions.s3
++    const s3ProviderOptions = options.providerOptions.s3
++
++    if (s3ProviderOptions.accessKeyId || s3ProviderOptions.secretAccessKey) {
++      throw new Error('Found `providerOptions.s3.accessKeyId` or `providerOptions.s3.secretAccessKey` configuration, but Companion requires `key` and `secret` option names instead. Please use the `key` property instead of `accessKeyId` and the `secret` property instead of `secretAccessKey`.')
++    }
++
++    const s3ClientOptions = Object.assign({
++      signatureVersion: 'v4',
++      // backwards compat
++      useAccelerateEndpoint: s3ProviderOptions.useAccelerateEndpoint
++    }, s3ProviderOptions.awsClientOptions)
++
+     // Use credentials to allow assumed roles to pass STS sessions in.
+     // If the user doesn't specify key and secret, the default credentials (process-env)
+     // will be used by S3 in calls below.
+-    let credentials
+-    if (config.key && config.secret) {
+-      credentials = new AWS.Credentials(config.key, config.secret, config.sessionToken)
++    if (s3ProviderOptions.key && s3ProviderOptions.secret && !s3ClientOptions.credentials) {
++      s3ClientOptions.credentials = new AWS.Credentials(
++        s3ProviderOptions.key,
++        s3ProviderOptions.secret,
++        s3ProviderOptions.sessionToken)
+     }
+-    s3Client = new S3({
+-      region: config.region,
+-      endpoint: config.endpoint,
+-      credentials,
+-      signatureVersion: 'v4',
+-      useAccelerateEndpoint: config.useAccelerateEndpoint
+-    })
++    s3Client = new S3(s3ClientOptions)",what happens if a user sets `accessKeyId` and `secretAccessKey` as part of `s3ClientOptions`? Will it override `credentials` created with `s3ProviderOptions.key` and `s3ProviderOptions.secret`? Is this a desired behaviour?,2020-02-13 13:52:29
+669,"@@ -212,25 +212,33 @@ const getOptionsMiddleware = (options) => {
+   if (options.providerOptions.s3) {
+     const S3 = require('aws-sdk/clients/s3')
+     const AWS = require('aws-sdk')
+-    const config = options.providerOptions.s3
++    const s3ProviderOptions = options.providerOptions.s3
++    const s3Options = Object.assign({",should we rather introduce a field that covers these options in `providerOptions.s3` itself? So maybe `providerOptions.s3.awsClientOptions` (or something better)?,2020-01-21 11:24:02
+670,"@@ -212,25 +212,33 @@ const getOptionsMiddleware = (options) => {
+   if (options.providerOptions.s3) {
+     const S3 = require('aws-sdk/clients/s3')
+     const AWS = require('aws-sdk')
+-    const config = options.providerOptions.s3
++    const s3ProviderOptions = options.providerOptions.s3
++    const s3Options = Object.assign({
++      signatureVersion: 'v4'
++    }, s3ProviderOptions)
++    // delete options intended for Companion, not S3:
++    delete s3Options.key
++    delete s3Options.secret
++    delete s3Options.conditions
++    delete s3Options.getKey
++
++    if (s3ProviderOptions.accessKeyId || s3ProviderOptions.secretAccessKey) {","should we support both instead? 🤔 So when `accessKeyId` and `secretAccessKey` are supplied, we set the values to `key` and `secret`?",2020-01-21 11:25:41
+136,"@@ -213,9 +213,10 @@ module.exports = class GoldenRetriever extends Plugin {
+       this.IndexedDBStore.delete(fileID)
+     })
+ 
+-    this.core.on('core:success', (fileIDs) => {
++    this.core.on('core:complete', ({ successful }) => {
++      const fileIDs = successful.map((file) => file.id)
+       this.deleteBlobs(fileIDs).then(() => {
+-        this.core.log(`[GoldenRetriever] removed ${fileIDs.length} files that finished uploading`)
++        this.core.log(`RestoreFiles: removed ${successful.length} files that finished uploading`)","Unsure why this is `RestoreFiles` now vs `GoldenRetriever`, thought we deprecated the first?",2017-11-13 10:05:14
+773,"@@ -215,7 +215,7 @@ class DropBox extends Provider {
+   _error (err, resp) {
+     if (resp) {
+       const fallbackMessage = `request to ${this.authProvider} returned ${resp.statusCode}`
+-      const errMsg = resp.body.error_summary ? resp.body.error_summary : fallbackMessage
++      const errMsg = (resp.body || {}).error_summary ? resp.body.error_summary : fallbackMessage",this change can be ignored. I accidentally checked out of [this branch](https://github.com/transloadit/uppy/pull/2264/files),2020-05-17 19:43:33
+160,"@@ -218,7 +218,7 @@ class Uppy {
+     this.uploaders.push(fn)
+   }
+ 
+-  removeUploader (fn) {
++  _removeUploader (fn) {","`removeUploader` is used in upload plugins, so it should be public (similar to `removePreProcessor`)",2017-12-10 21:41:45
+507,"@@ -218,7 +233,7 @@ const getOptionsMiddleware = (options) => {
+       options,
+       s3Client,
+       authToken: req.header('uppy-auth-token') || req.query.uppyAuthToken,
+-      clientVersion: req.header('uppy-versions') || req.query.uppyVersions,
++      clientVersion: req.header('uppy-versions') || decodeURIComponent(req.query.uppyVersions) || '1.0.0',","This still resolves to `undefined` instead of `1.0.0` in my tests, because, I think:
+
+`typeof req.header('uppy-versions')` returns `undefined`
+`typeof decodeURIComponent(req.query.uppyVersions)` returns `string` 😱
+`console.log(decodeURIComponent(req.query.uppyVersions))` returns `undefined`",2019-06-11 18:06:12
+711,"@@ -219,12 +218,18 @@ class Uploader {
+     if (chunk === null) {
+       this.writeStream.on('finish', () => {
+         this.streamsEnded = true
+-        if (this.options.endpoint && protocol === PROTOCOLS.multipart) {
+-          this.uploadMultipart()
+-        }
+-
+-        if (protocol === PROTOCOLS.tus && !this.tus) {
+-          return this.uploadTus()
++        switch (protocol) {
++          case PROTOCOLS.multipart:
++            if (this.options.endpoint) {
++              this.uploadMultipart()
++            }
++            break
++          case PROTOCOLS.s3Multipart:
++            this.uploadS3Multipart()
++            break
++          case PROTOCOLS.tus:
++            this.uploadTus()",should we be extra cautious and keep the `if (!this.tus) {...}` conditional? Same for `if (!this. s3Upload) {...}` That way the class will not have to rely on trusting the downloader to not mess things up by calling `handleChunk(null)` twice.,2020-03-16 11:49:34
+8,"@@ -22,41 +16,75 @@ export default class ProgressDrawer extends Plugin {
+ 
+     // merge default options with the ones set by user
+     this.opts = Object.assign({}, defaultOptions, opts)
++
++    this.el = this.render(this.core.state)
+   }
+ 
+-  render (state) {
+-    return hx`<div>
+-      ${state.bla}
+-    </div>`
++  update (state) {
++    const newEl = this.render(state)
++    yo.update(this.el, newEl)
+   }
+ 
+-  // all actions should be in core, I guess
+-  events () {
+-    this.core.emitter.on('progress', function () {
+-      this.updateState({ progress: loop.state.clickedTimes + 1 })
+-    })
++  render (state) {
++    const selectedFiles = state.selectedFiles
++    const selectedFileCount = Object.keys(selectedFiles).length
++    const isSomethingSelected = selectedFileCount > 0
++    const autoProceed = this.core.opts.autoProceed","You can destructure here with `const { autoProceed } = this.core.opts` to make this a little less long.  Same with `selectedFiles`, if you'd like.
+",2016-04-04 15:50:21
+500,"@@ -22,6 +22,20 @@ describe('Test Provider options', () => {
+     expect(grantConfig.instagram.secret).toBe('instagram_secret')
+   })
+ 
++  test('adds provider options for secret files', () => {
++    process.env.COMPANION_DROPBOX_SECRET_FILE = process.env.PWD + '/test/resources/dropbox_secret_file'
++    process.env.COMPANION_GOOGLE_SECRET_FILE = process.env.PWD + '/test/resources/google_secret_file'
++    process.env.COMPANION_INSTAGRAM_SECRET_FILE = process.env.PWD + '/test/resources/instagram_secret_file'",maybe we should test that it truly overrides by setting values for `COMPANION_INSTAGRAM_SECRET` (and others) as well?,2019-06-05 14:39:06
+935,"@@ -22,6 +22,7 @@ exports.StatusBar = require('@uppy/status-bar')
+ 
+ // Acquirers
+ exports.Dropbox = require('@uppy/dropbox')
++exports.Box = require('@uppy/box')","excluding box from global module for now as it will initially be released as beta
+
+```suggestion
+```",2020-11-13 09:17:44
+144,"@@ -220,7 +221,7 @@ class Uppy {
+     this.setState({meta: newMeta})
+   }
+ 
+-  updateMeta (data, fileID) {
++  setFileMeta (fileID, data) {","should we add an error like this for one release?
+
+```js
+updateMeta (data, fileID) {
+  throw new Error('The Uppy#updateMeta(data, fileID) method has been renamed to setFileMeta(fileID, data)')
+}
+```",2017-11-29 14:54:20
+885,"@@ -22034,7 +22035,6 @@
+       ""version"": ""1.18.1"",
+       ""resolved"": ""https://registry.npmjs.org/http-proxy/-/http-proxy-1.18.1.tgz"",
+       ""integrity"": ""sha512-7mz/721AbnJwIVbnaSv1Cz3Am0ZLT/UBwkC92VlxhXv/k/BBQfM2fXElQNC27BVGr0uwUpplYPQM9LnaBMR5NQ=="",
+-      ""dev"": true,","I'm not sure why this is no longer ""dev"": true, as this wasn't changed. Please let me know if I should omit this change (likewise below)",2020-09-11 21:00:25
+920,"@@ -225,41 +170,6 @@ const interceptGrantErrorResponse = interceptor((req, res) => {
+  * @param {object} options
+  */
+ const getOptionsMiddleware = (options) => {
+-  let s3Client = null
+-  if (options.providerOptions.s3) {
+-    const S3 = require('aws-sdk/clients/s3')
+-    const AWS = require('aws-sdk')
+-    const s3ProviderOptions = options.providerOptions.s3
+-
+-    if (s3ProviderOptions.accessKeyId || s3ProviderOptions.secretAccessKey) {
+-      throw new Error('Found `providerOptions.s3.accessKeyId` or `providerOptions.s3.secretAccessKey` configuration, but Companion requires `key` and `secret` option names instead. Please use the `key` property instead of `accessKeyId` and the `secret` property instead of `secretAccessKey`.')
+-    }
+-
+-    const rawClientOptions = s3ProviderOptions.awsClientOptions
+-    if (rawClientOptions && (rawClientOptions.accessKeyId || rawClientOptions.secretAccessKey)) {
+-      throw new Error('Found unsupported `providerOptions.s3.awsClientOptions.accessKeyId` or `providerOptions.s3.awsClientOptions.secretAccessKey` configuration. Please use the `providerOptions.s3.key` and `providerOptions.s3.secret` options instead.')
+-    }
+-
+-    const s3ClientOptions = Object.assign({
+-      signatureVersion: 'v4',
+-      endpoint: s3ProviderOptions.endpoint,
+-      region: s3ProviderOptions.region,
+-      // backwards compat
+-      useAccelerateEndpoint: s3ProviderOptions.useAccelerateEndpoint
+-    }, rawClientOptions)
+-
+-    // Use credentials to allow assumed roles to pass STS sessions in.
+-    // If the user doesn't specify key and secret, the default credentials (process-env)
+-    // will be used by S3 in calls below.
+-    if (s3ProviderOptions.key && s3ProviderOptions.secret && !s3ClientOptions.credentials) {
+-      s3ClientOptions.credentials = new AWS.Credentials(
+-        s3ProviderOptions.key,
+-        s3ProviderOptions.secret,
+-        s3ProviderOptions.sessionToken)
+-    }
+-    s3Client = new S3(s3ClientOptions)
+-  }
+-",this was moved to a [separate file](https://github.com/transloadit/uppy/blob/c5e3d8171281d5fce60dc8e59f32a564b4ef4668/packages/%40uppy/companion/src/server/s3-client.js),2020-11-11 11:22:44
+877,"@@ -225,7 +226,7 @@ class Zoom extends Provider {
+       items: [],
+       username: adapter.getUserEmail(userResponse)
+     }
+-    const items = results.meetings || results.recording_files
++    const items = results.meetings || results.recording_files.filter(file => file.file_type !== 'TIMELINE')","timeline files are json files that are intended for programmatic use, so we should omit them from the user's view (the same way that zoom omits these files from the their recording files list in zoom.us/recordings).",2020-09-04 17:00:44
+403,"@@ -229,21 +263,27 @@ class Uploader {
+     emitter().emit(this.token, dataToEmit)
+   }
+ 
+-  uploadTus () {
++  /**
++   *
++   * @param {boolean} deferLength
++   */
++  uploadTus (deferLength) {
+     const fname = path.basename(this.options.path)
+     const ftype = this.options.metadata.type
+     const metadata = Object.assign({ filename: fname, filetype: ftype }, this.options.metadata || {})
+-    const file = fs.createReadStream(this.options.path)
++    const file = deferLength ? this.duplexStream : fs.createReadStream(this.options.path)
+     const uploader = this
+ 
+     // @ts-ignore
+     this.tus = new tus.Upload(file, {
+       endpoint: this.options.endpoint,
+       uploadUrl: this.options.uploadUrl,
++      // @ts-ignore
++      uploadLengthDeferred: deferLength,
+       resume: true,
+-      uploadSize: this.options.size || fs.statSync(this.options.path).size,
++      uploadSize: deferLength ? null : (this.options.size || fs.statSync(this.options.path).size),",You might want to avoid using statSync on the server side :),2019-02-23 21:45:51
+502,"@@ -23,12 +25,15 @@ module.exports = class RequestClient {
+   get defaultHeaders () {
+     return {
+       'Accept': 'application/json',
+-      'Content-Type': 'application/json'
++      'Content-Type': 'application/json',
++      'Uppy-Versions': '@uppy/companion-client=1.0.3'","We’ve now added `Plugin.VERSION` property available on all plugins, including `RequestClient`, so we should send that instead of the hardcoded value.",2019-06-05 17:11:08
+761,"@@ -23,18 +23,27 @@ const getFingerprint = require('./getFingerprint')
+  */
+ const tusDefaultOptions = {
+   endpoint: '',
+-  resume: true,
++","Pulled in the latest default options. Two notable changes:
+- the resume option has been removed (see comments below)
+- the retryDelays option is enabled by default",2020-05-03 15:47:12
+567,"@@ -23,6 +23,40 @@ uppy.use(FileInput, {
+ 
+ The `@uppy/xhr-upload` example uses `@uppy/file-input` with the [`pretty`](#pretty-true) option enabled.
+ 
++## Custom file input","In the S3 plugins, we have additional sections below the `Options` one:
+![image](https://user-images.githubusercontent.com/1006268/62628981-9c178f00-b92c-11e9-8fa8-bf5d81f62193.png)
+for consistency, it might be best to move this to the end as well",2019-08-07 14:01:44
+535,"@@ -23,6 +23,7 @@ module.exports = class Form extends Plugin {
+       resultName: 'uppyResult',
+       getMetaFromForm: true,
+       addResultToForm: true,
++      replaceResultInFormWithNew: true,",":bike: :derelict_house: , but  maybe the default option should be `multipleResults: false` or `combineMultipleResults: false`? i feel like `replaceResultInFormWithNew` is very verbose but also doesn't immediately clarify what it's for.",2019-07-01 12:16:16
+283,"@@ -23,7 +23,7 @@ const renderInnerPanel = (props) => {
+ }
+ 
+ const poweredByUppy = (props) => {
+-  return <a href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">
++  return <a tabindex=""-1"" href=""https://uppy.io"" rel=""noreferrer noopener"" target=""_blank"" class=""uppy-Dashboard-poweredBy"">Powered by <svg aria-hidden=""true"" class=""UppyIcon uppy-Dashboard-poweredByIcon"" width=""11"" height=""11"" viewBox=""0 0 11 11"" xmlns=""http://www.w3.org/2000/svg"">","Tiniest nit but this can be `tabindex={-1}`, `width={11}`, `height={11}`",2018-05-29 09:23:28
+760,"@@ -23,9 +23,9 @@ function isReactNative () {
+ // For React Native and Cordova, we let tus-js-client’s default
+ // fingerprint handling take charge.
+ module.exports = function getFingerprint (uppyFileObj) {
+-  return function (file, options, callback) {
++  return function (file, options) {",The fingerprint methods are now not callback-based but use Promises instead.,2020-05-03 15:46:08
+391,"@@ -230,32 +230,23 @@ module.exports = class XHRUpload extends Plugin {
+           const body = opts.getResponseData(xhr.responseText, xhr)
+           const uploadURL = body[opts.responseUrlFieldName]
+ 
+-          const response = {
++          const uploadResp = {
+             status: ev.target.status,
+             body,
+             uploadURL
+           }
+ 
+-          this.uppy.setFileState(file.id, { response })
+-
+-          this.uppy.emit('upload-success', file, body, uploadURL)
++          this.uppy.emit('upload-success', file, uploadResp)
+ 
+           if (uploadURL) {
+             this.uppy.log(`Download ${file.name} from ${file.uploadURL}`)
+           }
+ 
+           return resolve(file)
+         } else {
+-          const body = opts.getResponseData(xhr.responseText, xhr)
++          // const body = opts.getResponseData(xhr.responseText, xhr)","the response data was added intentionally in #612, i think we could keep the `setFileState` stuff here as a special case, at least for now…",2019-01-15 11:15:21
+820,"@@ -230,6 +235,22 @@ module.exports = class Dashboard extends Plugin {
+     })
+   }
+ 
++  openFileEditor = (file) => {
++    const { targets } = this.getPluginState()
++
++    this.setPluginState({
++      showFileEditor: true,
++      activeOverlayType: 'FileEditor'
++    })
++
++    const editors = this._getEditors(targets)
++    editors.forEach((editor) => {
++      const editorPlugin = this.uppy.getPlugin(editor.id)
++      editorPlugin.selectFile(file)
++      setTimeout(editorPlugin.initEditor, 4)
++    })","❓Questionable way of looping through editors and calling `selectFile` + `initEditor`, with the latter requiring “next tick”.",2020-07-13 09:18:32
+684,"@@ -232,14 +238,18 @@ class Uploader {
+     }
+ 
+     this.writeStream.write(chunk, () => {
+-      logger.debug(`${this.bytesWritten} bytes`, 'uploader.download.progress', this.shortToken)
++      // logger.debug(`${this.bytesWritten} bytes`, 'uploader.download.progress', this.shortToken)",leftover?,2020-03-05 14:31:11
+221,"@@ -233,9 +233,11 @@ module.exports = class Webcam extends Plugin {
+       return this.getImage()
+     }).then((tagFile) => {
+       this.captureInProgress = false
+-      this.uppy.addFile(tagFile)
+       const dashboard = this.uppy.getPlugin('Dashboard')
+       if (dashboard) dashboard.hideAllPanels()
++      return this.uppy.addFile(tagFile).catch(() => {
++        // Ignore
++      })","But here we are also handling the error later, catching nonetheless.",2018-02-09 05:36:16
+539,"@@ -234,12 +234,28 @@ const ProgressBarProcessing = (props) => {
+ 
+ const ProgressDetails = (props) => {
+   return <div class=""uppy-StatusBar-statusSecondary"">
+-    { props.numUploads > 1 && props.i18n('filesUploadedOfTotal', { complete: props.complete, smart_count: props.numUploads }) + ' \u00B7 ' }
+-    { props.i18n('dataUploadedOfTotal', {
+-      complete: prettyBytes(props.totalUploadedSize),
+-      total: prettyBytes(props.totalSize)
+-    }) + ' \u00B7 ' }
+-    { props.i18n('xTimeLeft', { time: prettyETA(props.totalETA) }) }
++    {
++      props.numUploads > 1 &&
++      props.i18n('filesUploadedOfTotal', {
++        complete: props.complete,
++        smart_count: props.numUploads
++      }) + ' \u00B7 '
++    }
++    <span class=""uppy-StatusBar--onlyForDesktop"">","Nitpick: I would maybe call this `uppy-StatusBar--additionalInfo` or something, so that the desktop/mobile abstraction is hidden. Then devs using Uppy can hide this additional info based on a preference or custom condition. And we can later decide to show this on mobile, on a second/third line for instance, while still keeping the class name.",2019-07-04 18:51:53
+970,"@@ -234,3 +234,96 @@ h1 {
+   width: 940px;
+ }
+ ```
++
++## Adding a new integration
++
++Before opening a pull request for the new integration, open an issue to discuss said integration with the Uppy team. After discussing the integration, you can get started on it. First off, you need to construct the basic components for your integration. The following components are the current standard:
++
++- `Dashboard`: Inline Dashboard (`inline: true`)
++- `DashboardModal`: Dashboard as a modal
++- `DragDrop`
++- `ProgressBar`
++- `StatusBar`
++
++All of these components should function as references to the normal component. Depending on how the framework you're using handles references to the DOM, your approach to creating these may be different. For example, in React, you can assign a property of the component to the reference of a component ([see here](https://github.com/transloadit/uppy/blob/425f9ecfbc8bc48ce6b734e4fc14fa60d25daa97/packages/%40uppy/react/src/Dashboard.js#L47-L54)). This may differ in your framework, but from what we've found, the concepts are generally pretty similar.
++
++If you're familiar with React, Vue or soon Svelte, it might be useful to read through the code of those integrations, as they lay out a pretty good structure. After the basic components have been built, there are a few more important tasks to get done:
++
++- Add TypeScript support in some capacity (if possible)
++- Write documentation
++- Add an example
++- Configuring the build system
++
++### Common issues
++
++Before going into these tasks, there are a few common gotchas that you should be aware of.
++
++#### Dependencies
++
++Your `package.json` should resemble something like this:
++```json
++{
++  ""name"": ""@uppy/framework"",
++  ""dependencies"": {
++    ""@uppy/dashboard"": ""file:../dashboard"",
++    ""@uppy/drag-drop"": ""file:../drag-drop"",
++    ""@uppy/progress-bar"": ""file:../progress-bar"",
++    ""@uppy/status-bar"": ""file:../status-bar"",
++    ""@uppy/utils"": ""file:../utils"",
++    ""prop-types"": ""^15.6.1""
++  },
++  ""peerDependencies"": {
++    ""@uppy/core"": ""^1.0.0""
++  }
++}","Let’s add the 
+```
+""publishConfig"": {
+  ""access"": ""public""
+}
+```
+bit ;-)",2020-12-22 17:38:43
+971,"@@ -234,3 +234,96 @@ h1 {
+   width: 940px;
+ }
+ ```
++
++## Adding a new integration
++
++Before opening a pull request for the new integration, open an issue to discuss said integration with the Uppy team. After discussing the integration, you can get started on it. First off, you need to construct the basic components for your integration. The following components are the current standard:
++
++- `Dashboard`: Inline Dashboard (`inline: true`)
++- `DashboardModal`: Dashboard as a modal
++- `DragDrop`
++- `ProgressBar`
++- `StatusBar`
++
++All of these components should function as references to the normal component. Depending on how the framework you're using handles references to the DOM, your approach to creating these may be different. For example, in React, you can assign a property of the component to the reference of a component ([see here](https://github.com/transloadit/uppy/blob/425f9ecfbc8bc48ce6b734e4fc14fa60d25daa97/packages/%40uppy/react/src/Dashboard.js#L47-L54)). This may differ in your framework, but from what we've found, the concepts are generally pretty similar.
++
++If you're familiar with React, Vue or soon Svelte, it might be useful to read through the code of those integrations, as they lay out a pretty good structure. After the basic components have been built, there are a few more important tasks to get done:
++
++- Add TypeScript support in some capacity (if possible)
++- Write documentation
++- Add an example
++- Configuring the build system
++
++### Common issues
++
++Before going into these tasks, there are a few common gotchas that you should be aware of.
++
++#### Dependencies
++
++Your `package.json` should resemble something like this:
++```json
++{
++  ""name"": ""@uppy/framework"",
++  ""dependencies"": {
++    ""@uppy/dashboard"": ""file:../dashboard"",
++    ""@uppy/drag-drop"": ""file:../drag-drop"",
++    ""@uppy/progress-bar"": ""file:../progress-bar"",
++    ""@uppy/status-bar"": ""file:../status-bar"",
++    ""@uppy/utils"": ""file:../utils"",
++    ""prop-types"": ""^15.6.1""
++  },
++  ""peerDependencies"": {
++    ""@uppy/core"": ""^1.0.0""
++  }
++}
++```
++
++The most important part about this is that `@uppy/core` is a peer dependency. If you're framework complains about `@uppy/core` not being resolved, you can also add it as a dev dependency
++
++### Adding TypeScript Support
++
++This section won't be too in-depth, because TypeScript depends on your framework. As general advice, prefer using `d.ts` files and vanilla JavaScript over TypeScript files. This is of course circumstantial, but it makes handling the build system a lot easier when TypeScript doesn't have to transpiled. The version of typescript in the monorepo is `3.7.5`, so features like `import type` will not work at build time. For upcoming integrations, like Angular, this may be updated.
++
++### Writing docs
++
++Generally, documentation for integrations can be broken down into a few pieces that apply to every component, and then documentation for each component. The structure should look something like this:
++
++- Installation
++- Initializing Uppy (may vary depending on how the framework handles reactivity)
++- Usage
++- *For each component*
++  - Loading CSS
++  - Props
++
++It may be easier to copy the documentation of earlier integrations and change the parts that need to be changed rather than writing this from scratch. Preferably, keep the documentation to one page. For the front-matter, write something like:
++```markdown
++---
++title: Framework Name
++type: docs
++module: ""@uppy/framework""
++order: 0
++category: ""Other Integrations""
++---
++```
++
++This data is used to generate Uppy's website. Refer to [the section about running the website locally](#website-previews) if you'd like to see how the docs look on the website.
++
++### Adding an example
++
++This is pretty simple to do, as you can likely use whatever code generation tool for your framework (ex. `create-react-app`) to create this example. Make sure you add the same version of `@uppy/core` to this as your peer dependency required, or you may run into strange issues. Try to include all of the components are some of their functionality. [The React example](https://github.com/transloadit/uppy/blob/master/examples/react-example/App.js) is a great... well example of how to do this well.
++
++### Integrating the build system
++
++The biggest part of this is understanding Uppy's build system. The high level description is basically `babel` goes through almost all of the packages and transpiles all the Javascript files in the `src` directory to more compatible JavaScript in the `lib` folder. If you're using vanilla JavaScript for your integration (like React and Vue do), then you can just use this build system and use the files generated as your entry points. 
++
++If you're using some kind of more abstract file format (like Svelte), then you probably want do to a few things: add the directory name to [this `IGNORE` regex](https://github.com/transloadit/uppy/blob/425f9ecfbc8bc48ce6b734e4fc14fa60d25daa97/bin/build-lib.js#L15); add all of your build dependencies to the root `package.json` (try to keep this small); add a new `build:framework` script to the root `package.json`. This script usually looks something like this:
++
++```json
++{
++  ""scripts"": {
++    ""build:framework"": ""cd framework && npm run build""","Do we want to run build scripts from root ideally, even if configs are in `packages/@uppy/my-integration/conf.js` or something? @goto-bus-stop what do you think?",2020-12-22 17:40:33
+280,"@@ -239,23 +243,43 @@ module.exports = class Dashboard extends Plugin {
+     this.savedActiveElement = document.activeElement
+ 
+     if (this.opts.disablePageScrollWhenModalOpen) {
+-      document.body.classList.add('uppy-Dashboard-isOpen')
++      document.body.classList.add('uppy-Dashboard-isFixed')
+     }
+ 
++    // handle ESC and TAB keys in modal dialog
++    document.addEventListener('keydown', this.onKeydown)
++
+     this.rerender(this.uppy.getState())
+     this.updateDashboardElWidth()
+     this.setFocusToBrowse()
+   }
+ 
+   closeModal () {
+-    this.setPluginState({
+-      isHidden: true
+-    })
+-
+     if (this.opts.disablePageScrollWhenModalOpen) {
+-      document.body.classList.remove('uppy-Dashboard-isOpen')
++      document.body.classList.remove('uppy-Dashboard-isFixed')
++    }
++
++    if (this.opts.animateOpenClose) {
++      this.setPluginState({
++        isClosing: true
++      })
++      const handler = () => {
++        this.setPluginState({
++          isHidden: true,
++          isClosing: false
++        })
++        this.el.removeEventListener('animationend', handler, false)
++      }
++      this.el.addEventListener('animationend', handler, false)",What happens if the modal is opened again within the 300ms of the animation? ,2018-05-29 09:20:09
+56,"@@ -24,25 +29,28 @@ module.exports = class Multipart extends Plugin {
+   }
+ 
+   upload (file, current, total) {
++    const opts = Object.assign({}, this.opts, file.multipart || {})
++
+     this.core.log(`uploading ${current} of ${total}`)
+     return new Promise((resolve, reject) => {
+       // turn file into an array so we can use bundle
+-      // if (!this.opts.bundle) {
++      // if (!opts.bundle) {
+       //   files = [files[current]]
+       // }
+ 
+       // for (let i in files) {
+-      //   formPost.append(this.opts.fieldName, files[i])
++      //   formPost.append(opts.fieldName, files[i])
+       // }
+ 
+       const formPost = new FormData()
+-      formPost.append(this.opts.fieldName, file.data)
+ 
+-      Object.keys(file.meta).forEach((item) => {
+-        // console.log(file.meta, file.meta[item])
++      const fields = Array.isArray(opts.fields) ? opts.fields : Object.keys(file.meta)
++      fields.forEach((item) => {
+         formPost.append(item, file.meta[item])
+       })
+ 
++      formPost.append(opts.fieldName, file.data)",Moved this one to the end because S3 requires the `file` to be the last parameter … hopefully nothing else requires it to be first! :/,2017-06-23 09:53:22
+254,"@@ -24,6 +24,29 @@ uppy.use(Transloadit, {
+ 
+ As of Uppy 0.24 the Transloadit plugin includes the [Tus](/docs/tus) plugin to handle the uploading, so you no longer have to add it manually.
+ 
++## Properties
++
++### `Transloadit.UPPY_SERVER`
++
++The main endpoint for Transloadit's hosted uppy-servers. You can use this constant in remote provider options, like so:
++
++```js
++const Dropbox = require('uppy/lib/plugins/Dropbox')
++const Transloadit = require('uppy/lib/plugins/Transloadit')
++
++uppy.use(Dropbox, {
++  host: Transloadit.UPPY_SERVER",❤️ ,2018-05-08 10:22:00
+517,"@@ -24,66 +24,80 @@ class Drive {
+   list (options, done) {
+     const directory = options.directory || 'root'
+     const query = options.query || {}
+-    const teamDrive = query.teamDrive
+-    let listDone = false
+-    let teamDrivesDone = false
+-    let teamDrives
+-    let listResponse
+-    let reqErr
+-    const finishReq = () => {
+-      if (reqErr || listResponse.statusCode !== 200) {
+-        const err = this._error(reqErr, listResponse)
+-        logger.error(err, 'provider.drive.list.error')
+-        done(err)
+-      } else {
+-        done(null, this.adaptData(listResponse.body, teamDrives ? teamDrives.body : null, options.uppy))
+-      }
++    const teamDriveId = query.teamDriveId
++
++    let teamDrivesPromise = Promise.resolve(undefined)
++
++    const shouldListTeamDrives = directory === 'root' && !teamDriveId && !query.nextPageToken
++    if (shouldListTeamDrives) {
++      teamDrivesPromise = new Promise((resolve) => {
++        this.client
++          .query()
++          .get('teamdrives')
++          .where({ fields: TEAM_DRIVE_FIELDS })
++          .auth(options.token)
++          .request((err, resp) => {
++            if (err) {
++              logger.error(err, 'provider.drive.teamDrive.error')
++              return
++            }
++            resolve(resp)
++          })
++      })
++    }
++
++    let where = {
++      fields: DRIVE_FILES_FIELDS,
++      pageToken: query.nextPageToken,",maybe we should make the nextPage query name the same for all providers? so each provider would use it as it requires internally. But between companion and uppy client it will be the same query name. For instagram we are already using `max_id` but we can change it and still support `max_id` for backward compatibility.,2019-06-17 11:05:55
+150,"@@ -243,6 +242,7 @@ module.exports = class Tus extends Plugin {
+ 
+   connectToServerSocket (file) {
+     const token = file.serverToken
++    console.log('123', token)",stray console.log? :),2017-12-04 14:53:37
+364,"@@ -244,19 +249,33 @@ describe('uploader/ThumbnailGeneratorPlugin', () => {
+     })
+   })
+ 
+-  describe('getProportionalHeight', () => {
+-    it('should calculate the resized height based on the specified width of the image whilst keeping aspect ratio', () => {
+-      const core = new MockCore()
+-      const plugin = new ThumbnailGeneratorPlugin(core)
+-      expect(
+-        plugin.getProportionalHeight({ width: 200, height: 100 }, 50)
+-      ).toEqual(25)
+-      expect(
+-        plugin.getProportionalHeight({ width: 66, height: 66 }, 33)
+-      ).toEqual(33)
+-      expect(
+-        plugin.getProportionalHeight({ width: 201.2, height: 198.2 }, 47)
+-      ).toEqual(46)
++  describe('getProportionalDimensions', () => {
++    const core = new MockCore()
++    const plugin = new ThumbnailGeneratorPlugin(core)
++
++    function resize (image, width, height) {
++      return plugin.getProportionalDimensions(image, width, height)
++    }
++
++    it('should calculate the thumbnail dimensions based on the width whilst keeping aspect ratio', () => {
++      expect(resize({ width: 200, height: 100 }, 50)).toEqual({ width: 50, height: 25 })
++      expect(resize({ width: 66, height: 66 }, 33)).toEqual({ width: 33, height: 33 })
++      expect(resize({ width: 201.2, height: 198.2 }, 47)).toEqual({ width: 47, height: 46 })
++    })
++
++    it('should calculate the thumbnail dimensions based on the height whilst keeping aspect ratio', () => {
++      expect(resize({ width: 200, height: 100 }, null, 50)).toEqual({ width: 100, height: 50 })
++      expect(resize({ width: 66, height: 66 }, null, 33)).toEqual({ width: 33, height: 33 })
++      expect(resize({ width: 201.2, height: 198.2 }, null, 47)).toEqual({ width: 48, height: 47 })
++    })
++
++    it('should calculate the thumbnail dimensions based on the default width if no custom width is given', () => {
++      plugin.defaultThumbnailDimension = 50","I think we should use a separate instance here to avoid this mutation leaking into other tests, if we add more later. Right now the remaining tests don't depend on this value but who knows what will change in the future!",2018-10-15 11:00:35
+81,"@@ -248,15 +249,83 @@ function getFileNameAndExtension (fullFileName) {
+   return [fileName, fileExt]
+ }
+ 
+-function getThumbnail (file) {
+-  return URL.createObjectURL(file.data)
+-}
+-
+ function supportsMediaRecorder () {
+   return typeof MediaRecorder === 'function' && !!MediaRecorder.prototype &&
+     typeof MediaRecorder.prototype.start === 'function'
+ }
+ 
++/**
++ * Check if a URL string is an object URL from `URL.createObjectURL`.
++ *
++ * @param {string} url
++ * @return {boolean}
++ */
++function isObjectURL (url) {
++  return url.indexOf('blob:') === 0
++}
++
++function getProportionalHeight (img, width) {
++  const aspect = img.width / img.height
++  return Math.round(width / aspect)
++}
++
++/**
++ * Create a thumbnail for the given Uppy file object.
++ *
++ * @param {{data: Blob}} file
++ * @param {number} width
++ * @return {Promise}
++ */
++function createThumbnail (file, width) {
++  const originalUrl = URL.createObjectURL(file.data)
++
++  const onload = new Promise((resolve, reject) => {
++    const image = new Image()
++    image.src = originalUrl
++    image.onload = () => {
++      URL.revokeObjectURL(originalUrl)
++      resolve(image)
++    }
++    image.onerror = () => {
++      // The onerror event is totally useless unfortunately, as far as I know
++      URL.revokeObjectURL(originalUrl)
++      reject(new Error('Could not create thumbnail'))
++    }
++  })
++
++  return onload.then((image) => {
++    const height = getProportionalHeight(image, width)
++
++    const canvas = html`<canvas></canvas>`","Could we just use `document.createElement` here, so that Utils are not dependent on `yo-yo`?",2017-07-26 20:26:34
+142,"@@ -248,19 +257,23 @@ module.exports = class XHRUpload extends Plugin {
+   }
+ 
+   uploadFiles (files) {
+-    const promises = files.map((file, i) => {
++    const actions = files.map((file, i) => {
+       const current = parseInt(i, 10) + 1
+       const total = files.length
+ 
+       if (file.error) {
+-        return Promise.reject(new Error(file.error))
++        return () => Promise.reject(new Error(file.error))
+       } else if (file.isRemote) {
+-        return this.uploadRemote(file, current, total)
++        return this.uploadRemote.bind(this, file, current, total)
+       } else {
+-        return this.upload(file, current, total)
++        return this.upload.bind(this, file, current, total)
+       }
+     })
+ 
++    const promises = actions
++      .map(this.limitUploads)
++      .map((action) => action())","alternative via @ifedapoolarewaju:
+
+```js
+const promises = actions.map((action) => {
+  const limitedAction = this.limitUploads(action)
+  return limitedAction()
+})
+```",2017-11-27 16:35:24
+722,"@@ -248,32 +248,26 @@ module.exports = class XHRUpload extends Plugin {
+           this.uploaderEvents[file.id] = null
+         }
+ 
+-        if (opts.validateStatus(ev.target.status, xhr.responseText, xhr)) {
+-          const body = opts.getResponseData(xhr.responseText, xhr)
+-          const uploadURL = body[opts.responseUrlFieldName]
++        const body = opts.getResponseData(xhr.responseText, xhr)
++        const uploadURL = body[opts.responseUrlFieldName]","If there was an error, there may not be any response data—this was why it was initially separate. There can't really be an `uploadURL` if the upload failed :) we can do a check like this though:
+```suggestion
+        const uploadURL = body != null ? body[opts.responseUrlFieldName] : null
+```",2020-03-30 11:08:13
+86,"@@ -249,15 +248,129 @@ function getFileNameAndExtension (fullFileName) {
+   return [fileName, fileExt]
+ }
+ 
+-function getThumbnail (fileData) {
+-  return URL.createObjectURL(fileData)
+-}
+-
+ function supportsMediaRecorder () {
+   return typeof MediaRecorder === 'function' && !!MediaRecorder.prototype &&
+     typeof MediaRecorder.prototype.start === 'function'
+ }
+ 
++/**
++ * Check if a URL string is an object URL from `URL.createObjectURL`.
++ *
++ * @param {string} url
++ * @return {boolean}
++ */
++function isObjectURL (url) {
++  return url.indexOf('blob:') === 0
++}
++
++function getProportionalHeight (img, width) {
++  const aspect = img.width / img.height
++  return Math.round(width / aspect)
++}
++
++/**
++ * Create a thumbnail for the given Uppy file object.
++ *
++ * @param {{data: Blob}} file
++ * @param {number} width
++ * @return {Promise}
++ */
++function createThumbnail (file, targetWidth) {
++  const originalUrl = URL.createObjectURL(file.data)
++
++  const onload = new Promise((resolve, reject) => {
++    const image = new Image()
++    image.src = originalUrl
++    image.onload = () => {
++      URL.revokeObjectURL(originalUrl)
++      resolve(image)
++    }
++    image.onerror = () => {
++      // The onerror event is totally useless unfortunately, as far as I know
++      URL.revokeObjectURL(originalUrl)
++      reject(new Error('Could not create thumbnail'))
++    }
++  })
++
++  return onload.then((image) => {
++    const targetHeight = getProportionalHeight(image, targetWidth)
++    let sourceWidth = image.width
++    let sourceHeight = image.height
++
++    if (targetHeight < image.height / 2) {
++      const steps = Math.floor(Math.log(image.width / targetWidth) / Math.log(2))
++      ;({",";{{{
+
+nitpicking of course, but is there a way to write this differently? :)",2017-08-18 14:32:58
+266,"@@ -25,14 +24,12 @@ uppy.use(FileInput, {
+ })
+ ```
+ 
++> Note that certain [restrictions set in Uppy’s main options](/docs/uppy#restrictions), namely `maxNumberOfFiles` and `allowedFileTypes`, affect the system file picker dialog. If `maxNumberOfFiles: 1`, users will only be able to select one file, and `allowedFileTypes: ['image/*, .jpg']` means only image or files with `.jpg` extension will be selectable.",ditto re: overlapping file types,2018-05-14 07:50:30
+321,"@@ -25,51 +18,6 @@ function browserSupportsChooseFile (capabilities) {
+          capabilities.platformName !== 'Android'
+ }","This `browserSupportsChooseFile ` is not needed here, if we have `supportsChooseFile`?",2018-07-18 04:03:25
+980,"@@ -25,7 +90,7 @@
+     ""jsdoc/check-types"": [""warn""],
+     ""jsdoc/newline-after-description"": [""warn""],
+     ""jsdoc/valid-types"": [""warn""],
+-    ""jsdoc/check-indentation"": [""off""]
++    ""jsdoc/check-indentation"": 0","i think ""off"" is clearer 😇 ",2021-03-10 08:03:39
+415,"@@ -25,8 +25,10 @@ module.exports = class RequestClient {
+     }
+   }
+ 
+-  get headers () {
+-    return Object.assign({}, this.defaultHeaders, this.opts.serverHeaders || {})
++  headers () {
++    return new Promise((resolve, reject) => {
++      resolve(Object.assign({}, this.defaultHeaders, this.opts.serverHeaders || {}))",This can be `return Promise.resolve(Object.assign(...))`,2019-03-25 13:01:35
+719,"@@ -251,6 +254,42 @@ module.exports = class Transloadit extends Plugin {
+     })
+   }
+ 
++  _createAssemblyWatcher (assemblyID, fileIDs, uploadID) {
++  // AssemblyWatcher tracks completion states of all Assemblies in this upload.
++    const watcher = new AssemblyWatcher(this.uppy, assemblyID)
++
++    watcher.on('assembly-upload', (id) => {","When I try it with this PR and `waitForEncoding: true`, the postprocessing step is never entered. I think it's because the `assembly-upload` event is not actually fired anywhere right now.",2020-03-30 09:41:32
+989,"@@ -252,6 +252,33 @@ It gets passed `({value, onChange}, h)` where `value` is the current value of th
+ })
+ ```
+ 
++If you want the meta fields to be dynamically assigned depending on the file type, pass a function:","```suggestion
+If you’d like the meta fields to be dynamically assigned depending on, for instance, the file type, pass a function:
+```",2021-03-30 20:32:43
+988,"@@ -252,6 +252,33 @@ It gets passed `({value, onChange}, h)` where `value` is the current value of th
+ })
+ ```
+ 
++You can also specify a function that takes a [File Object](https://uppy.io/docs/uppy/#File-Objects) and returns an array of UI field objects:","Maybe add “instead of an array” or similar? Not sure if it’s clear right now that this is about `metaFields`, because the example above refers to `render`. ",2021-03-29 20:02:35
+29,"@@ -253,6 +254,27 @@ module.exports = class View {
+     })
+   }
+ 
++  handleAuth () {
++    let urlId = Math.floor(Math.random() * 999999) + 1
++    let redirect = `${location.href}${location.search ? '&' : '?'}id=${urlId}`
++
++    const authState = btoa(JSON.stringify({ redirect }))
++    const link = `${this.plugin.opts.host}/connect/${this.Provider.authProvider}?state=${authState}`
++
++    let authWindow = window.open(link, '_blank')
++
++    let checkAuth = () => {","I’d probably prefer to use `let` only if we need to set/reset later, `const` would seem more appropriate here.",2017-01-27 23:13:48
+960,"@@ -256,7 +256,7 @@ module.exports = class Tus extends Plugin {
+         }
+       }
+ 
+-      /** @type {{ [name: string]: string }} */
++      /** @type {Record<string, string>} */",Working around a possible limitation in the JSDoc plugin's typescript syntax checking. This means the same thing,2020-11-30 09:51:00
+99,"@@ -259,7 +271,7 @@ module.exports = class DashboardUI extends Plugin {
+   }
+ 
+   handleDrop (files) {
+-    this.core.log('All right, someone dropped something...')
++    this.core.log('[Dashboard] Files were droppeded')",tiniest nit: 'droppeded' → 'dropped',2017-09-09 11:48:16
+928,"@@ -26,6 +26,7 @@ const Uppy = require('@uppy/core')
+ const Dashboard = require('@uppy/dashboard')
+ const GoogleDrive = require('@uppy/google-drive')
+ const Dropbox = require('@uppy/dropbox')
++const Box = require('@uppy/box')","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:12:59
+207,"@@ -26,7 +26,10 @@ Unit tests are using Jest and can be run with:
+ 
+ For acceptance (or end to end) tests, we use [Webdriverio](http://webdriver.io). For it to run locally, you need to install selenium standalone server, just follow [the guide](http://webdriver.io/guide.html) to do so. You can also install Selenium Standalone server from NPM:
+ 
+-`npm install selenium-standalone`
++```bash
++npm install selenium-standalone
++selenium-standalone install
++```",I wonder if it’s better to do `npm install selenium-standalone -g` as suggested on https://www.npmjs.com/package/selenium-standalone,2018-02-01 05:41:56
+281,"@@ -265,9 +289,9 @@ module.exports = class Dashboard extends Plugin {
+ 
+   onKeydown (event) {
+     // close modal on esc key press
+-    if (event.keyCode === 27) this.requestCloseModal(event)
++    if (event.keyCode === ESC_KEY) this.requestCloseModal(event)
+     // maintainFocus on tab key press
+-    if (event.keyCode === 9) this.maintainFocus(event)
++    if (event.keyCode === TAB_KEY) this.maintainFocus(event)",yay nice,2018-05-29 09:20:18
+157,"@@ -267,28 +273,31 @@ module.exports = class DashboardUI extends Plugin {
+       showModalTrigger.forEach(trigger => trigger.removeEventListener('click', this.openModal))
+     }
+ 
+-    this.removeDragDropListener()
+-
+     if (!this.opts.inline) {
+       document.removeEventListener('keydown', this.onKeydown)
+     }
+-  }
+ 
+-  actions () {
+-    this.core.on('dashboard:file-card', this.handleFileCard)
++    this.removeDragDropListener()
+ 
+-    window.addEventListener('resize', this.updateDashboardElWidth)
++    this.uppy.off('dashboard:file-card', this.handleFileCard)
++    this.uppy.off('file-added', this.addDashboardMetaToNewFile)
++
++    window.removeEventListener('resize', this.updateDashboardElWidth)
+   }
+ 
+-  removeActions () {
+-    this.core.off('dashboard:file-card', this.handleFileCard)
++  addDashboardMetaToNewFile (file) {","I kinda feel like the dashboard as a UI plugin shouldn't be setting initial file metadata, maybe the `metaFields` option should only contain the placeholder and name data, and not a default value. then the `meta: {}` option to Core can be used to specify defaults. what's your thoughts on that?
+",2017-12-09 16:13:11
+416,"@@ -27,14 +27,14 @@ Object {
+       ""name"": ""foo.jpg"",
+       ""preview"": undefined,
+       ""progress"": Object {
+-        ""bytesTotal"": 0,
++        ""bytesTotal"": null,
+         ""bytesUploaded"": 0,
+         ""percentage"": 0,","Should all those be `null` then? Otherwise `bytesTotal` is `null`, but `bytesUploaded` is `0`?",2019-03-26 09:03:04
+462,"@@ -27,17 +27,18 @@
+ 
+   <textarea id=""console-log"" class=""Console""></textarea>
+   <script>
+-  console.log = (function (old_function, div_log) {
+-    return function (text) {
+-      old_function(text);
+-
+-      if (text !== (text + '')) {
+-        text = JSON.stringify(text);
+-      }
+-
+-      div_log.value = text + ""\n"" + div_log.value;
+-    };
+-  } (console.log.bind(console), document.getElementById(""console-log"")));
++    console.log = (function (log, container) {
++      return function (text) {
++        log(text);
++
++        if (text !== (text + '')) {
++          text = JSON.stringify(text);
++        }
++
++        container.value += text;
++        container.scrollTop = container.scrollHeight + '\n';
++      };",isn’t `scrollTop` a number? how does `container.scrollHeight + '\n'` work?,2019-05-14 15:46:43
+918,"@@ -27,21 +29,39 @@ module.exports = (props) => {
+         // making <ul> not focusable for firefox
+         tabindex=""-1""
+       >
+-        {props.folders.map(folder =>
+-          Item({
++        {props.folders.map(folder => {
++          return Item({
+             ...getSharedProps(folder, props),
+             type: 'folder',
+             isDisabled: props.isChecked(folder) ? props.isChecked(folder).loading : false,
+             handleFolderClick: () => props.handleFolderClick(folder)
+           })
+-        )}
+-        {props.files.map(file =>
+-          Item({
+-            ...getSharedProps(file, props),
++        })}
++        {props.files.map(file => {
++          console.log(file)",`console.log()` 💛 ,2020-11-10 09:00:57
+917,"@@ -27,21 +29,39 @@ module.exports = (props) => {
+         // making <ul> not focusable for firefox
+         tabindex=""-1""
+       >
+-        {props.folders.map(folder =>
+-          Item({
++        {props.folders.map(folder => {
++          return Item({
+             ...getSharedProps(folder, props),
+             type: 'folder',
+             isDisabled: props.isChecked(folder) ? props.isChecked(folder).loading : false,
+             handleFolderClick: () => props.handleFolderClick(folder)
+           })
+-        )}
+-        {props.files.map(file =>
+-          Item({
+-            ...getSharedProps(file, props),
++        })}
++        {props.files.map(file => {
++          console.log(file)
++          const passesRestrictions = props.passesRestrictions(
++            remoteFileObjToLocal(file)
++          )
++          const sharedProps = getSharedProps(file, props)
++          let restrictionReason = passesRestrictions.reason
++          if (!props.canSelectMore && !sharedProps.isChecked) {
++            if (props.maxNumberOfFiles) {
++              restrictionReason = sharedProps.i18n('youCanOnlyUploadX', { smart_count: props.maxNumberOfFiles })","If we have both restrictions enabled & `!props.canSelectMore && !sharedProps.isChecked` is true, then we'll always get `'youCanOnlyUploadX'` restrictionReason.
+
+Example: getting `'You can only upload 80 files'` titles with `{ restrictions: { maxTotalFileSize: 291000, maxNumberOfFiles: 80 } }`
+![image](https://user-images.githubusercontent.com/7578559/98650401-a65be080-235a-11eb-8919-e4e32c2efda6.png)
+",2020-11-10 09:00:18
+265,"@@ -27,6 +26,8 @@ uppy.use(DragDrop, {
+ })
+ ```
+ 
++> Note that certain [restrictions set in Uppy’s main options](/docs/uppy#restrictions), namely `maxNumberOfFiles` and `allowedFileTypes`, affect the system file picker dialog. If `maxNumberOfFiles: 1`, users will only be able to select one file, and `allowedFileTypes: ['image/*, .jpg']` means only image or files with `.jpg` extension will be selectable.","It might be clearer to have non overlapping example here, eg ""`allowedFileTypes: ['image/*', '.pdf']` means only images and PDFs will be selectable""",2018-05-14 07:50:11
+921,"@@ -27,7 +27,7 @@ function logout (req, res, next) {
+       }
+ 
+       delete companion.providerTokens[providerName]
+-      tokenService.removeFromCookies(res, companion.options, companion.provider.authProviderName)
++      tokenService.removeFromCookies(res, companion.options, companion.provider.authProvider)",spotted a bug.,2020-11-11 11:23:22
+256,"@@ -27,8 +28,9 @@ class ActionBrowseTagline extends Component {
+           tabindex=""-1""
+           type=""file""
+           name=""files[]""
+-          multiple=""true""
++          multiple={this.props.maxNumberOfFiles !== 1 || !this.props.maxNumberOfFiles}","not sure what the '|| !this.props.maxNumberOfFiles' is for, according to the left side of the condition, it can be simplified to `!1` which is always false.",2018-05-09 15:51:33
+587,"@@ -277,48 +303,82 @@ module.exports = class Tus extends Plugin {
+     })
+   }
+ 
++  /**
++   * See the comment on the upload() method.
++   *
++   * Additionally, when an upload is removed, completed, or cancelled, we need to close the WebSocket connection. This is handled by the resetUploaderReferences() function, so the same guidelines apply as in upload().
++   */
+   connectToServerSocket (file) {
+     return new Promise((resolve, reject) => {
+       const token = file.serverToken
+       const host = getSocketHost(file.remote.companionUrl)
+-      const socket = new Socket({ target: `${host}/api/${token}` })
++      const socket = new Socket({ target: `${host}/api/${token}`, autoOpen: false })
+       this.uploaderSockets[file.id] = socket
+-      this.uploaderEvents[file.id] = createEventTracker(this.uppy)
++      this.uploaderEvents[file.id] = new EventTracker(this.uppy)
+ 
+       this.onFileRemove(file.id, () => {
++        queuedRequest.abort()
+         socket.send('pause', {})
++        this.resetUploaderReferences(file.id)
+         resolve(`upload ${file.id} was removed`)
+       })
+ 
+       this.onPause(file.id, (isPaused) => {
+-        isPaused ? socket.send('pause', {}) : socket.send('resume', {})
++        if (isPaused) {
++          // Remove this file from the queue so another file can start in its place.
++          queuedRequest.abort()
++          socket.send('pause', {})
++        } else {
++          // Resuming an upload should be queued, else you could pause and then resume a queued upload to make it skip the queue.
++          queuedRequest.abort()
++          queuedRequest = this.requests.run(() => {
++            socket.send('resume', {})
++            return () => {}
++          })
++        }
+       })
+ 
+-      this.onPauseAll(file.id, () => socket.send('pause', {}))
++      this.onPauseAll(file.id, () => {
++        queuedRequest.abort()
++        socket.send('pause', {})
++      })
+ 
+-      this.onCancelAll(file.id, () => socket.send('pause', {}))
++      this.onCancelAll(file.id, () => {
++        queuedRequest.abort()
++        socket.send('pause', {})
++        this.resetUploaderReferences(file.id)
++        resolve(`upload ${file.id} was canceled`)
++      })
+ 
+       this.onResumeAll(file.id, () => {
++        queuedRequest.abort()
+         if (file.error) {
+           socket.send('pause', {})
+         }
+-        socket.send('resume', {})
++        queuedRequest = this.requests.run(() => {
++          socket.send('resume', {})","We forgot to `return () => {}`, now we get this error:
+![image](https://user-images.githubusercontent.com/7578559/63730302-32800600-c884-11e9-8d5a-f745eb03ada3.png)
+
+To reproduce:
+1. select some instagram images
+2. stop all - resume all - stop all (<--- aand here is the error)",2019-08-26 23:54:58
+219,"@@ -277,6 +277,8 @@ module.exports = class Dashboard extends Plugin {
+         name: file.name,
+         type: file.type,
+         data: blob
++      }).catch(() => {","> UI plugins swallow rejection errors so they don't end up in the console with no way to fix
+
+But it will still catch upstream in `addFile` and restrictions to show the informer?.. 🤔",2018-02-09 05:35:06
+298,"@@ -278,9 +278,7 @@ describe('src/Core', () => {
+       plugins: {},
+       totalProgress: 0
+     })
+-    expect(core.plugins.acquirer[0].mocks.uninstall.mock.calls.length).toEqual(
+-      1
+-    )
++    expect(core.plugins[Object.keys(core.plugins)[0]].length).toEqual(0)",Can we keep the other assertion too? I think it's helpful to ensure that the uninstall function was called too,2018-06-11 09:27:23
+21,"@@ -28,6 +28,14 @@ Even though bundled in this repo, the website is regarded as a separate project.
+ 
+ It's recommended to exclude `./website/public/` from your editor if you want efficient searches.
+ 
++To install the required node modules, type:
++```bash
++npm install
++cd website
++npm install
++cd ..
++```
++","Maybe combine it like:
+```bash
+npm install && cd website && npm install && cd ..
+```
+?",2016-12-13 01:17:23
+395,"@@ -28,6 +28,7 @@
+     ""@uppy/thumbnail-generator"": ""0.29.1"",
+     ""@uppy/utils"": ""0.29.1"",
+     ""classnames"": ""^2.2.6"",
++    ""cuid"": ""^2.1.1"",
+     ""drag-drop"": ""2.13.3"",","In other places we are using uuid, I think, is there a reason to use different packages? I was actually gonna suggest we switch to https://github.com/ai/nanoid everywhere, it’s smaller and ids are smaller.",2019-01-28 19:04:23
+892,"@@ -28,7 +28,7 @@ class Zoom extends Provider {
+     return 'zoom'
+   }
+ 
+-  list (options, done) {
++  async list (options, done) {","for consistency with other providers, can this be achieved without explicit `async-await`?",2020-09-14 10:33:37
+952,"@@ -28,7 +28,8 @@ module.exports.verifyToken = (token, secret) => {
+  *
+  * @param {object} res
+  * @param {string} token
+- * @param {object=} companionOptions
++ * @param {object} companionOptions
++ * @param {string=} companionOptions.cookieDomain","```suggestion
+```",2020-11-23 07:26:18
+163,"@@ -281,6 +304,191 @@ module.exports = class Transloadit extends Plugin {
+     })
+   }
+ 
++  getPersistentData (setData) {
++    const state = this.getPluginState()
++    const assemblies = state.assemblies
++    const uploadsAssemblies = state.uploadsAssemblies
++    const uploads = Object.keys(state.files)
++    const results = state.results.map((result) => result.id)
++
++    setData({
++      [this.id]: {
++        assemblies,
++        uploadsAssemblies,
++        uploads,
++        results
++      }
++    })
++  }
++
++  /**
++   * Emit the necessary events that must have occured to get from the `prevState`,
++   * to the current state.
++   * For completed uploads, `transloadit:upload` is emitted.
++   * For new results, `transloadit:result` is emitted.
++   * For completed or errored assemblies, `transloadit:complete` or `transloadit:assembly-error` is emitted.
++   */
++  emitEventsDiff (prevState) {
++    const opts = this.opts
++    const state = this.getPluginState()
++
++    const emitMissedEvents = () => {
++      // Emit events for completed uploads and completed results
++      // that we've missed while we were away.
++      const newUploads = Object.keys(state.files).filter((fileID) => {
++        return !prevState.files.hasOwnProperty(fileID)
++      }).map((fileID) => state.files[fileID])
++      const newResults = state.results.filter((result) => {
++        return !prevState.results.some((prev) => prev.id === result.id)
++      })
++
++      this.uppy.log('[Transloadit] New fully uploaded files since restore:', newUploads)
++      newUploads.forEach(({ assembly, uploadedFile }) => {","The way `uppy.log()` currently works, you need to call it with the object separately for it to show it, like:
+
+```js
+this.uppy.log('[Transloadit] New fully uploaded files since restore:')
+this.uppy.log(newUploads)
+```
+
+Not ideal, I know :)",2017-12-12 01:27:17
+721,"@@ -287,9 +281,17 @@ module.exports = class XHRUpload extends Plugin {
+           this.uploaderEvents[file.id].remove()
+           this.uploaderEvents[file.id] = null
+         }
++        const body = opts.getResponseData(xhr.responseText, xhr)","I don't think this should be done in the `error` handler. AFAIK the response is always null here, so there is no data to retrieve. It's the same for the `status` value below: it would always be 0 in this code path. Having the `response` object is not really useful in that case.",2020-03-30 11:07:08
+161,"@@ -289,6 +289,10 @@ module.exports = class Tus extends Plugin {
+ 
+     socket.on('progress', (progressData) => emitSocketProgress(this, progressData, file))
+ 
++    socket.on('error', (errData) => {
++      this.core.emitter.emit('core:upload-error', file.id, new Error(errData.error))","nitpick, but its better if we are consistent: `this.core.emitter.emit` --> `this.core.emit`.",2017-12-11 16:46:07
+715,"@@ -29,11 +29,11 @@ class FileCard extends Component {
+     }
+   }
+ 
+-  tempStoreMeta = (ev, name) => {
++  updateMeta = (newVal, name) => {","I can add back the old function if needed, but felt kinda useless now :)",2020-03-23 20:08:13
+714,"@@ -29,11 +29,13 @@ class FileCard extends Component {
+     }
+   }
+ 
+-  tempStoreMeta = (ev, name) => {
++  tempStoreMeta = (ev, name, type) => {
++    var value = ev.target.value
++    if (type === 'checkbox') value = ev.target.checked ? 'on' : 'off'",This is an example of why I prefer a flexible custom `render()` solution … 'on'/'off' may not be the right value for every application. You have to make a lot of decisions even for very simple form fields :(,2020-03-23 10:16:03
+487,"@@ -29,21 +27,12 @@
+         text-align: right;
+         border: 2px solid purple;
+       }
+-
+-      ul {
+-        margin: 60px;
+-      }
+-
+-      li {
+-        margin: 60px;
+-      }
+-
+-      .foo a {
+-        color: purple;
+-      }","These were added to test Uppy’s style protection from some styles that might be on a page where Uppy is used. Not sure it’s the best idea, but just noting that there was a reason, maybe we should keep it.",2019-05-28 08:16:23
+665,"@@ -29,40 +29,40 @@
+     ""companion"": ""./bin/companion""
+   },
+   ""dependencies"": {
+-    ""@purest/providers"": ""1.0.0"",
++    ""@purest/providers"": ""1.0.1"",
+     ""@uppy/fs-tail-stream"": ""1.2.0"",
+-    ""atob"": ""2.1.0"",
+-    ""aws-sdk"": ""2.388.0"",
+-    ""body-parser"": ""1.18.2"",
++    ""atob"": ""2.1.2"",
++    ""aws-sdk"": ""2.587.0"",
++    ""body-parser"": ""1.19.0"",
+     ""chalk"": ""2.4.2"",
+     ""common-tags"": ""1.8.0"",
+     ""connect-redis"": ""4.0.3"",
+-    ""cookie-parser"": ""1.4.3"",
++    ""cookie-parser"": ""1.4.4"",
+     ""express"": ""4.17.1"",
+     ""express-interceptor"": ""1.2.0"",
+     ""express-prom-bundle"": ""3.3.0"",
+     ""express-request-id"": ""1.4.1"",
+-    ""express-session"": ""1.15.6"",
+-    ""grant-express"": ""4.1.2"",
++    ""express-session"": ""1.17.0"",
++    ""grant-express"": ""4.6.5"",","```suggestion
+    ""grant-express"": ""4.1.2"",
+```",2019-12-18 13:33:59
+845,"@@ -29,6 +29,12 @@ module.exports = () => {
+       transport: 'session',
+       scope: ['files.read.all', 'offline_access', 'User.Read'],
+       callback: '/onedrive/callback'
++    },
++    zoom: {
++      transport: 'session',
++      authorize_url: 'https://zoom.us/oauth/authorize',
++      access_url: 'https://zoom.us/oauth/token',
++      callback: '/zoom/callback'",we need to add the permission scopes that the API will be using kind of like [this one](https://github.com/transloadit/uppy/blob/e9651443c7eb1eca0de93d98b3d960d7738efd19/packages/%40uppy/companion/src/config/grant.js#L24),2020-07-16 04:08:35
+941,"@@ -29,6 +33,11 @@ class MockPurest {
+       const responses = fixtures[this.opts.providerName].responses
+       const url = this._query ? `${this._requestUrl}?${this._query}` : this._requestUrl
+       const endpointResponses = responses[url] || responses[this._requestUrl]
++      if (endpointResponses == null || !has(endpointResponses, this._method)) {
++        done(new Error(`No fixture for ${this._method} ${url}`))
++        return
++      }","For debugging: a test failure on CI was due to a missing fixture and it was not super easy to find.
+
+That failure was fixed in https://github.com/transloadit/uppy/pull/2628/files?file-filters%5B%5D=.js&file-filters%5B%5D=.json&file-filters%5B%5D=.ts#diff-230671caf421c053be258aa2c0a54a7086622503a88bf18c87607155f5b08157",2020-11-16 11:52:28
+494,"@@ -29,8 +30,8 @@ module.exports = function sendToken (req, res, next) {
+     const allowedClients = req.uppy.options.clients
+     // if no preset clients then allow any client
+     if (!allowedClients || hasMatch(origin, allowedClients) || hasMatch(parseUrl(origin).host, allowedClients)) {
+-      // @todo do a more secure client version check, see https://www.npmjs.com/package/semver
+-      return res.send(clientVersion ? htmlContent(uppyAuthToken, origin) : oldHtmlContent(uppyAuthToken, origin))
++      const allowsStringMessage = versionCmp.gte(clientVersion, '1.0.2')","```suggestion
+      const allowsStringMessage = clientVersion ? versionCmp.gte(clientVersion, '1.0.2') : false
+```",2019-05-30 12:35:05
+42,"@@ -298,28 +298,14 @@ module.exports = class Tus10 extends Plugin {
+     })
+   }
+ 
+-  selectForUpload (files) {
+-    // TODO: replace files[file].isRemote with some logic
+-    //
+-    // filter files that are now yet being uploaded / haven’t been uploaded
+-    // and remote too
+-    const filesForUpload = Object.keys(files).filter((file) => {
+-      if (!files[file].progress.uploadStarted || files[file].isRemote) {
+-        return true
+-      }
+-      return false
+-    }).map((file) => {
+-      return files[file]
+-    })
+-
+-    this.uploadFiles(filesForUpload)
+-  }
+-
+-  handleUpload () {
++  handleUpload (fileIDs) {
+     this.core.log('Tus is uploading...')
+-    const files = this.core.getState().files
++    const filesToUpload = fileIDs.map(getFile, this)
++    function getFile (fileID) {
++      return this.core.state.files[fileID]
++    }
+ 
+-    this.selectForUpload(files)
++    this.uploadFiles(filesToUpload)","All changes in this file are because the file IDs to upload are now passed in by `Core`, so the Tus plugin doesn't have to figure out what it has to upload.",2017-05-31 20:47:16
+84,"@@ -299,10 +299,6 @@ class Uppy {
+           preview: file.preview
+         }
+ 
+-        if (Utils.isPreviewSupported(fileTypeSpecific) && !isRemote) {
+-          newFile.preview = Utils.getThumbnail(file.data)
+-        }",This is moved to the `core:generate-preview` event.,2017-08-18 14:06:53
+984,"@@ -299,5 +299,6 @@ module.exports = class AwsS3 extends Plugin {
+ 
+   uninstall () {
+     this.uppy.removePreProcessor(this.handleUpload)
++    this.uppy.removeUploader(this.handleUpload)","```suggestion
+    this.uppy.removeUploader(this.handleUpload)
+```",2021-03-22 08:32:35
+936,"@@ -3,6 +3,7 @@ const has = require('@uppy/utils/lib/hasProperty')
+ 
+ const remoteProviders = {
+   dropbox: require('@uppy/dropbox'),
++  box: require('@uppy/box'),","excluding box from global module for now as it will initially be released as beta
+```suggestion
+```",2020-11-13 09:20:12
+915,"@@ -3,6 +3,7 @@ const has = require('@uppy/utils/lib/hasProperty')
+ const TransloaditResults = require('./TransloaditResultsPlugin')
+ 
+ const transloaditOptionNames = [
++  'id',
+   'service',","```suggestion
+  'service',
+```
+`id` is intentionally\* not passed in because there isn't really a reason to rename plugin instances with Robodog
+
+<small>\* at least that was my undocumented intent!</small>",2020-11-03 14:31:36
+312,"@@ -3,7 +3,8 @@
+   ""name"": ""uppy-build"",
+   ""description"": ""Extensible JavaScript file upload widget with support for drag&drop, resumable uploads, previews, restrictions, file processing/encoding, remote providers like Instagram, Dropbox, Google Drive, S3 and more :dog:"",
+   ""lint-staged"": {
+-    ""*.js"": ""eslint""","Not really related, but may I ask you to add [bin config](https://docs.npmjs.com/files/package.json#bin) like so?
+
+```json
+...
+""bin"": {
+  ""companion"" : ""./lib/standalone/start-server.js""
+},
+...
+```
+
+or similar?
+
+That way a `companion` file would be dropped in `node_modules/.bin` and folks & machines could just run `companion` (if they have it in their PATH, or start it from npm scripts), vs having to do some research to get at `./lib/standalone/start-server.js`",2018-07-16 09:52:53
+780,"@@ -30,14 +30,14 @@
+ }
+ 
+ // http://tympanus.net/codrops/2015/09/15/styling-customizing-file-inputs-smart-way/
+-.uppy-DragDrop-input {
+-  width: 0.1px;
+-  height: 0.1px;
+-  opacity: 0;
+-  overflow: hidden;
+-  position: absolute;
+-  z-index: -1;
+-}
++// .uppy-DragDrop-input {
++//   width: 0.1px;
++//   height: 0.1px;
++//   opacity: 0;
++//   overflow: hidden;
++//   position: absolute;
++//   z-index: -1;
++// }
+ ",let's delete?,2020-06-08 14:00:01
+393,"@@ -30,34 +30,34 @@
+   },
+   ""dependencies"": {
+     ""@purest/providers"": ""1.0.0"",
+-    ""@uppy/fs-tail-stream"": ""^1.2.0"",
++    ""@uppy/fs-tail-stream"": ""1.2.0"",","I think we need to pin these versions to the versions we had in `package-lock.json`, otherwise, we will effectively be downgrade some libraries to these pinned versions",2019-01-27 06:45:09
+958,"@@ -30,7 +30,6 @@
+     ""hexo-include-markdown"": ""^1.0.2"",
+     ""hexo-renderer-ejs"": ""^1.0.0"",
+     ""hexo-renderer-marked"": ""2.0.0"",
+-    ""hexo-renderer-scss"": ""^1.2.0"",",Replaced with a simple custom implementation https://github.com/transloadit/uppy/pull/2661/files#diff-62cdb2e4aadebffa495eadc250549237f9e5a08ebbb55d90ac1e3ea79027823d,2020-11-27 10:08:50
+568,"@@ -30,7 +30,7 @@ class Uppy {
+   /**
+    * Instantiate Uppy
+    *
+-   * @param {Object} opts — Uppy options
++   * @param {object} opts — Uppy options",I thought the new jsdoc rule set actually wanted these capitalized? 🤔 ,2019-08-12 11:19:43
+590,"@@ -302,7 +309,7 @@ module.exports = class ThumbnailGenerator extends Plugin {
+     }
+   }
+ 
+-  onRestored () {
++  onRestored = () => {","I'm not familiar with this syntax, will this still be an instance method? If not, what becomes of `this` within the `function`?",2019-08-29 10:39:40
+723,"@@ -303,12 +312,25 @@ module.exports = class ThumbnailGenerator extends Plugin {
+ 
+   onFileAdded = (file) => {
+     if (!file.preview && isPreviewSupported(file.type) && !file.isRemote) {
+-      this.addToQueue(file)
++      this.addToQueue(file.id)
+     }
+   }
+ 
++  /**
++   * Cancel a lazy request for a thumbnail if the thumbnail has not yet been generated.
++   */
++  onCancelRequest = (file) => {
++    const index = this.queue.indexOf(file.id)
++    if (index !== -1) {
++      this.queue.splice(index, 1)
++    }
++  }
++
++  /**
++   * Clean up the thumbnail for a file. Cancel lazy requests and free the thumbnail URL.
++   */
+   onFileRemoved = (file) => {
+-    const index = this.queue.indexOf(file)
++    const index = this.queue.indexOf(file.id)","Storing file IDs in the `this.queue` array now because of this: previously items would not be removed from the queue because the file object could be different (eg. metadata was changed or upload progress has happened), and then `indexOf()` would not find it.",2020-03-30 13:28:05
+139,"@@ -308,6 +313,51 @@ module.exports = class View {
+     return this.plugin.core.getState()[this.plugin.stateId].activeRow === this.plugin.getItemId(file)
+   }
+ 
++  isChecked (file) {
++    return (this.fileToId(file) in this.plugin.core.getState().files)
++  }
++
++  toggleCheckbox (e, file) {
++    e.stopPropagation()
++    e.preventDefault()
++    let {folders, files, filterInput} = this.plugin.core.getState()[this.plugin.stateId]
++    let items = folders.concat(files)
++    if (filterInput !== '') {
++      items = this.filterItems(items)
++    }
++    let itemsToToggle = [file]
++    if (this.lastCheckbox && e.shiftKey) {
++      let prevIndex = items.indexOf(this.lastCheckbox)
++      let currentIndex = items.indexOf(file)
++      if (prevIndex < currentIndex) {
++        itemsToToggle = items.slice(prevIndex, currentIndex + 1)
++      } else {
++        itemsToToggle = items.slice(currentIndex, prevIndex + 1)
++      }
++    }
++    this.lastCheckbox = file
++    if (this.isChecked(file)) {
++      for (let item of itemsToToggle) {
++        const itemId = this.fileToId(item)
++        if (itemId in this.plugin.core.getState().files) {
++          this.plugin.core.removeFile(itemId)
++        }
++      }
++    } else {
++      for (let item of itemsToToggle) {
++        this.addFile(item, true)
++      }
++    }
++  }
++
++  fileToId (file) {","@sadovnychyi what is the need for the `fileToId` method? Why not just use `this.plugin.getItemId(file)`?
+
+Nice work btw 😉 ",2017-11-14 18:38:24
+343,"@@ -31,13 +31,13 @@ module.exports = class RequestClient {
+ 
+   onReceiveResponse (response) {
+     const state = this.uppy.getState()
+-    const uppyServer = state.uppyServer || {}
++    const companion = state.companion || {}
+     const host = this.opts.serverUrl
+     const headers = response.headers
+-    // Store the self-identified domain name for the uppy-server we just hit.
+-    if (headers.has('i-am') && headers.get('i-am') !== uppyServer[host]) {
++    // Store the self-identified domain name for the companion we just hit.",Doesn't matter a lot for the readability of this comment but something like 'Companion instance' or 'Companion server' here would be slightly more correct (very nitpicky lol sorry),2018-09-03 11:56:19
+513,"@@ -31,13 +31,20 @@ if (app.get('env') !== 'test') {
+ // log server requests.
+ app.use(morgan('combined'))
+ morgan.token('url', (req, res) => {
+-  // don't log access_tokens in urls
+-  if (req.query && req.query.access_token) {
++  const mask = (key) => {
++    // don't log access_tokens in urls
+     const query = Object.assign({}, req.query)
+     // replace logged access token with xxxx character
+-    query.access_token = 'x'.repeat(req.query.access_token.length)
++    query[key] = 'x'.repeat(req.query[key].length)
+     return `${req.path}?${qs.stringify(query)}`
+   }
++
++  if (req.query && req.query['access_token']) {
++    return mask('access_token')
++  } else if (req.query && req.query['uppyAuthToken']) {
++    return mask('uppyAuthToken')
++  }",Is there any chance of req.query containing _both_ `access_token` and `uppyAuthToken`?,2019-06-15 12:35:26
+269,"@@ -31,31 +38,34 @@ module.exports = class RequestClient {
+   }
+ 
+   get (path) {
+-    return fetch(`${this.hostname}/${path}`, {
++    return fetch(this._getUrl(path), {
+       method: 'get',
+-      credentials: 'include',
+-      headers: {
+-        'Accept': 'application/json',
+-        'Content-Type': 'application/json'
+-      }
++      headers: this.defaultHeaders
+     })
+       // @todo validate response status before calling json
+       .then(this.onReceiveResponse)
+       .then((res) => res.json())
+   }
+ 
+   post (path, data) {
+-    return fetch(`${this.hostname}/${path}`, {
++    return fetch(this._getUrl(path), {
+       method: 'post',
+-      credentials: 'include',
+-      headers: {
+-        'Accept': 'application/json',
+-        'Content-Type': 'application/json'
+-      },
++      headers: this.defaultHeaders,
+       body: JSON.stringify(data)
+     })
+       .then(this.onReceiveResponse)
+-      // @todo validate response status before calling json
+-      .then((res) => res.json())
++      .then((res) => {
++        if (res.status < 200 || res.status > 300) {
++          throw new Error(res.statusText)
++        }
++        return res.json()
++      })
++  }
++
++  _getUrl (url) {
++    if (url.startsWith('http:') || url.startsWith('https:')) {",nice refactor :+1: `.startsWith` is not available in IE so a regex is probably preferable,2018-05-14 12:55:22
+937,"@@ -31,6 +31,7 @@
+     ""@uppy/core"": ""file:../core"",
+     ""@uppy/dashboard"": ""file:../dashboard"",
+     ""@uppy/dropbox"": ""file:../dropbox"",
++    ""@uppy/box"": ""file:../box"",","excluding box from global module for now as it will initially be released as beta
+```suggestion
+```",2020-11-13 09:20:58
+88,"@@ -31,6 +33,35 @@ Whether to wait for all assemblies to complete before completing the upload.
+ Whether to wait for metadata to be extracted from uploaded files before completing the upload.
+ If `waitForEncoding` is enabled, this has no effect.
+ 
++### `importFromUploadURLs`
++
++Instead of uploading to Transloadit's servers directly, allow another plugin to upload files, and then import those files into the Transloadit assembly.
++Default `false`.
++
++When enabling this option, Transloadit will *not* configure the Tus plugin to upload to Transloadit.
++Instead, a separate upload plugin must be used.
++Once the upload completes, the Transloadit plugin adds the uploaded file to the assembly.
++
++For example, to upload files to an S3 bucket and then transcode them:
++
++```js
++uppy.use(AwsS3, {
++  getUploadParameters (file) {
++    return { /* upload parameters */ }
++  }
++})
++uppy.use(Transloadit, {
++  importFromUploadURLs: true,
++  params: {
++    auth: { key: /* secret */ },
++    template_id: /* secret */
++  }
++})
++```
++
++In order for this to work, the upload plugin must assign a publically accessible `uploadURL` property to the uploaded file object.
++The Tus and S3 plugins both do this—for the XHRUpload plugin, you may have to specify a custom `getUploadResponse` function.",Should add Tus/XHRUpload docs so this can be a link.,2017-08-21 16:05:36
+694,"@@ -31,7 +19,7 @@ class AddFiles extends Component {
+     event.target.value = null
+   }
+ 
+-  renderPoweredByUppy () {
++  renderPoweredByUppy = () => {","Are all these changes necessary? :thinking: 
+
+e; ah, I guess it's because it allows removing the `.bind()` calls in the constructor. I think some of these don't really need to be bound…",2020-03-09 14:47:17
+734,"@@ -31,7 +31,12 @@ module.exports = class ThumbnailGenerator extends Plugin {
+     const defaultOptions = {
+       thumbnailWidth: null,
+       thumbnailHeight: null,
+-      waitForThumbnailsBeforeUpload: false
++      waitForThumbnailsBeforeUpload: false,
++      lazy: false
++    }
++
++    if (defaultOptions.lazy && defaultOptions.waitForThumbnailsBeforeUpload) {",Should be `this.opts` instead of `defaultOptions`,2020-04-14 17:45:35
+9,"@@ -31,7 +31,7 @@ export default class Spinner extends Plugin {
+   }
+ 
+   initEvents () {
+-    this.core.emitter.on('progress', (data) => {
++    this.core.emitter.on('upload-progress', (data) => {
+       const percentage = data.percentage
+       const plugin = data.plugin","`const { plugin, percentage } = data`
+",2016-04-04 15:51:42
+887,"@@ -31,7 +31,7 @@ exports.getDateName = (start, end) => {
+ }
+ 
+ exports.getAccountCreationDate = (results) => {
+-  return moment(results.created_at)
++  return moment.utc(results.created_at)",zoom api timestamps are in UTC but it looks like `moment()` uses the local server time by default. this fixes that - see https://momentjs.com/docs/#/parsing/,2020-09-11 21:02:54
+591,"@@ -315,15 +322,43 @@ module.exports = class ThumbnailGenerator extends Plugin {
+     })
+   }
+ 
++  waitUntilAllProcessed = (fileIDs) => {
++    fileIDs.forEach((fileID) => {
++      const file = this.uppy.getFile(fileID)
++      this.uppy.emit('preprocess-progress', file, {
++        mode: 'indeterminate',
++        message: this.i18n('generatingThumbnails')
++      })
++    })
++
++    return new Promise((resolve, reject) => {
++      if (this.queueProcessing) {
++        this.uppy.on('thumbnail:all-generated', () => {",should this be `this.uppy.once` instead? Is it possible that this specific listener will always be triggered for every future thumbnail generations that will happen through out the lifetime of the Uppy instance?,2019-08-29 10:51:08
+239,"@@ -316,7 +316,7 @@ module.exports = class Webcam extends Plugin {
+     const webcamState = this.getPluginState()
+ 
+     if (!webcamState.cameraReady) {
+-      return PermissionsScreen(webcamState)
++      return PermissionsScreen(Object.assign({}, { icon: WebcamIcon }))",No need for `Object.assign` (`PermissionsScreen({ icon: WebcamIcon })`),2018-03-12 12:06:55
+224,"@@ -318,6 +318,36 @@ Subscribe to an uppy-event. See below for the full list of events.
+ 
+ Uppy exposes events that you can subscribe to in your app:
+ 
++### `file-added`
++
++Fired each time file is added.
++
++```javascript
++uppy.on('file-added', (fileID) => {
++  console.log('Added file', uppy.getFile(fileID))","This one should actually be:
+
+```js
+uppy.on('file-added', (file) => {
+  console.log('Added file', file)
+})
+```",2018-02-12 10:06:57
+501,"@@ -32,19 +32,19 @@ const getConfigFromEnv = () => {
+     providerOptions: {
+       google: {
+         key: process.env.COMPANION_GOOGLE_KEY,
+-        secret: process.env.COMPANION_GOOGLE_SECRET
++        secret: typeof process.env.COMPANION_GOOGLE_SECRET_FILE === 'string' ? fs.readFileSync(process.env.COMPANION_GOOGLE_SECRET_FILE).toString() : process.env.COMPANION_GOOGLE_SECRET",can we pull this into a function instead? And reuse it for others too?,2019-06-05 14:47:38
+733,"@@ -32,22 +51,34 @@ module.exports = (props) => {
+     cancelUpload: props.cancelUpload,
+     toggleFileCard: props.toggleFileCard,
+     removeFile: props.removeFile,
+-    handleRequestThumbnail: props.handleRequestThumbnail
++    handleRequestThumbnail: props.handleRequestThumbnail,
++    handleCancelThumbnail: props.handleCancelThumbnail
+   }
+ 
+-  function renderItem (fileID) {
++  const rows = chunks(Object.keys(props.files), props.itemsPerRow)
++
++  function renderRow (row) {
+     return (
+-      <FileItem
+-        key={fileID}
+-        {...fileProps}
+-        file={props.files[fileID]}
+-      />
++      // Use the first file ID as the key—this should not change across rerenders
++      <div role=""presentation"" key={row[0]}>","I think we should put all the `presentation`-roles and `list`-roles in one place, and add a comment about why we're doing this.
+
+E.g.:
+1. Move `<VirtualList role=""list""`/> prop inside the `<VirtualList/>`.
+2. Instead of `props.renderRow` - pass `props.renderItem` and `props.getRowKey`.
+3. Add a comment in `VirtualList` about what `presentation` is supposed to be doing here.
+
+What do you think?",2020-04-14 17:41:42
+304,"@@ -32,48 +32,46 @@
+     ""eslint"": ""^3.19.0"",
+     ""eslint-config-standard"": ""^10.2.1"",","standard v11 has been out for a while but it has a different indent rule which requires some code changes, didn't want to do any in this pr",2018-06-28 12:23:57
+303,"@@ -32,48 +32,46 @@
+     ""eslint"": ""^3.19.0"",
+     ""eslint-config-standard"": ""^10.2.1"",
+     ""eslint-config-standard-preact"": ""^1.1.6"",
+-    ""eslint-plugin-compat"": ""^2.3.0"",
+-    ""eslint-plugin-import"": ""^2.8.0"",
+-    ""eslint-plugin-jest"": ""^21.6.2"",
++    ""eslint-plugin-compat"": ""^2.4.0"",
++    ""eslint-plugin-import"": ""^2.13.0"",
++    ""eslint-plugin-jest"": ""^21.17.0"",
+     ""eslint-plugin-node"": ""^4.2.3"",
+-    ""eslint-plugin-promise"": ""^3.6.0"",
+-    ""eslint-plugin-standard"": ""^3.0.1"",
+-    ""exorcist"": ""^1.0.0"",
++    ""eslint-plugin-promise"": ""^3.8.0"",
++    ""eslint-plugin-standard"": ""^3.1.0"",
++    ""exorcist"": ""^1.0.1"",
+     ""fakefile"": ""0.0.9"",
+     ""github-contributors-list"": ""1.2.3"",
+     ""glob"": ""^7.1.2"",
+     ""isomorphic-fetch"": ""2.2.1"",
+-    ""jest"": ""^22.0.6"",
++    ""jest"": ""^22.4.4"",","jest 23 is out but tests failed with it, so i kept it at 22 for now.",2018-06-28 12:23:10
+243,"@@ -32,6 +40,7 @@ const ReduxDevTools = require('./plugins/ReduxDevTools')
+ 
+ module.exports = {
+   Core,
++  lib,","not sure how else to expose this. Happy to get suggestions here. I thought about adding it to core, but I didn't go that route because of the future idea of breaking some parts of uppy to its own npm package. If it were in core then it would be against that future idea.
+
+In any case, I think it is important to expose these modules to allow users write their own custom plugins with these helpers. If there's an understanding I am missing, please let me know.",2018-03-26 08:59:55
+264,"@@ -322,8 +322,20 @@ class Uppy {
+ 
+     if (allowedFileTypes) {
+       const isCorrectFileType = allowedFileTypes.filter((type) => {
+-        if (!file.type) return false
+-        return match(file.type, type)
++        // if (!file.type) return false
++
++        // is this is a mime-type
++        if (type.indexOf('/') > -1) {
++          if (!file.type) return false
++          return match(file.type, type)
++        }
++
++        // otherwise this is likely an extension
++        if (type.startsWith('.') > -1) {",`.startsWith()` returns a bool but is also not available in some older browsers—`type[0] === '.'` would work,2018-05-14 07:47:34
+362,"@@ -323,6 +331,30 @@ uppy.upload().then((result) => {
+ })
+ ```
+ 
++### `uppy.pauseResume(fileID)`
++
++Toggle pause/resume on an upload. Will only work if resumable upload plugin, such as [Tus](/docs/tus/), is used.
++
++### `uppy.pauseAll()`
++
++Pause all uploads. Will only work if resumable upload plugin, such as [Tus](/docs/tus/), is used.",a resumable upload plugin,2018-10-08 11:06:56
+361,"@@ -323,6 +331,30 @@ uppy.upload().then((result) => {
+ })
+ ```
+ 
++### `uppy.pauseResume(fileID)`
++
++Toggle pause/resume on an upload. Will only work if resumable upload plugin, such as [Tus](/docs/tus/), is used.
++
++### `uppy.pauseAll()`
++
++Pause all uploads. Will only work if resumable upload plugin, such as [Tus](/docs/tus/), is used.
++
++### `uppy.resumeAll()`
++
++Resume all uploads. Will only work if resumable upload plugin, such as [Tus](/docs/tus/), is used.
++
++### `uppy.retryUpload(fileID)`
++
++Retry an upload (after an error, for example).
++
++### `uppy.retryAll()`
++
++Retry all uploads (after an error, for example).
++
++### `uppy.cancelAll()`
++
++Cancel all uploads, resets progress and removes all files.","Tenses: Cancel all, *reset* progress, *remove* all files :)",2018-10-08 11:06:28
+100,"@@ -326,7 +337,7 @@ module.exports = class DashboardUI extends Plugin {
+     }
+ 
+     const pauseUpload = (fileID) => {
+-      this.core.emit.emit('core:upload-pause', fileID)
++      this.core.emit('core:upload-pause', fileID)",whelp! good catch :D,2017-09-09 11:48:34
+389,"@@ -327,7 +331,11 @@ module.exports = class Tus extends Plugin {
+       })
+ 
+       socket.on('success', (data) => {
+-        this.uppy.emit('upload-success', file, data, data.url)
++        const uploadResp = {
++          uploadURL: data.url
++        }
++
++        this.uppy.emit('upload-success', file, uploadResp)
+         this.resetUploaderReferences(file.id)",Should `data` be passed as `body` here? 🤔,2018-12-19 20:22:17
+472,"@@ -329,10 +331,7 @@ class Uploader {
+    * start the tus upload
+    */
+   uploadTus () {
+-    const fname = path.basename(this.options.path)
+-    const ftype = this.options.metadata.type
+-    const metadata = Object.assign({ filename: fname, filetype: ftype }, this.options.metadata || {})","hah ok, so we did already do it here!",2019-05-22 20:06:22
+232,"@@ -329,5 +329,38 @@ describe('uploader/ThumbnailGeneratorPlugin', () => {
+         getContext: canvas.getContext
+       })
+     })
++
++    it('should upsize if original image is smaller than target size', () => {
++      const core = {}
++      const plugin = new ThumbnailGeneratorPlugin(core)
++      const image = {
++        width: 100,
++        height: 80
++      }
++      plugin.downScaleInSteps = jest.fn().mockReturnValue({
++        image: {
++          height: 160,
++          width: 200
++        },
++        sourceWidth: 200,
++        sourceHeight: 160
++      })",the `downScaleInSteps` method was removed recently so I don't think it's necessary to mock it here—we should also remove it from the other tests,2018-02-19 09:38:53
+607,"@@ -33,7 +33,9 @@ const Tus = require('@uppy/tus')
+ 
+ const uppy = Uppy({ autoProceed: false })
+   .use(Dashboard, { trigger: '#select-files' })
+-  .use(GoogleDrive, { target: Dashboard, companionUrl: 'https://companion.uppy.io' })
++  .use(GoogleDrive, { target: Dashboard, companion","The option name is actually `companionUrl`, we can’t change that here :) See https://uppy.io/docs/facebook/#Options",2019-10-21 10:22:49
+241,"@@ -330,7 +330,9 @@ module.exports = class Webcam extends Plugin {
+       recording: webcamState.isRecording,
+       mirror: this.opts.mirror,
+       src: this.stream
+-    }))
++    })
++
++    return <CameraScreen {...CameraScreenProps} />","We could also only use JSX spread here instead of object.assign:
+
+```js
+<CameraScreen
+  {...webcamState}
+  onSnapshot={this.takeSnapshot}
+  /* ... etc ... */
+  src={this.stream}
+/>
+```",2018-03-13 12:49:00
+40,"@@ -333,7 +336,9 @@ module.exports = class DashboardUI extends Plugin {
+     totalSize = prettyBytes(totalSize)
+     totalUploadedSize = prettyBytes(totalUploadedSize)
+ 
+-    const isAllComplete = state.totalProgress === 100
++    const isAllComplete = state.totalProgress === 100 &&
++      completeFiles.length === Object.keys(files).length &&
++      processingFiles.length === 0","This needed some additional checks, because `totalProgress` refers to upload progress, but doesn't tell if postprocessing completed. I'm actually not sure if the `completeFiles.length === ` check is still necessary, it may be a leftover of my first shot at this, I can look into that tomorrow.",2017-05-31 20:46:16
+137,"@@ -338,6 +338,8 @@ class Uppy {
+           },
+           size: file.data.size || 'N/A',
+           isRemote: isRemote,
++          isCheckbox: file.isCheckbox || false,
++          isFolder: file.isFolder || false,
+           remote: file.remote || '',","Not sure how I feel about adding `isCheckbox` to a file object. It seems it’s only used to not close the provider panel when a checkbox is selected. I think we could separate the file name and checkbox is the markup and have two different click handlers for those cases. 
+
+Or maybe it’s better to not show checkboxes at all do multiselect on click, and then submit only when “done” is pressed?",2017-11-13 18:11:24
+70,"@@ -339,14 +369,17 @@ module.exports = class View {
+       addFile: this.addFile,
+       filterItems: this.filterItems,
+       filterQuery: this.filterQuery,
++      toggleSearch: this.toggleSearch,
+       sortByTitle: this.sortByTitle,
+       sortByDate: this.sortByDate,
+       logout: this.logout,
+       demo: this.plugin.opts.demo,
+       isActiveRow: this.isActiveRow,
+       getItemName: this.plugin.getItemName,
+       getItemIcon: this.plugin.getItemIcon,
+-      handleScroll: this.handleScroll
++      handleScroll: this.handleScroll,
++      title: this.plugin.title,
++      defaultViewType: this.opts.defaultViewType","should we just call this `viewType`? Seems more apt that `defaultViewType`. The default view type might be 'list', but regardless of what this value is overridden to, the attribute name remains.
+
+*I'm not sure if I articulated this well, but hopefully you get what I mean*
+ 🙂",2017-07-02 11:33:46
+580,"@@ -339,9 +339,11 @@ uppy.addFile({
+ 
+ `addFile` gives an error if the file cannot be added, either because `onBeforeFileAdded(file)` gave an error, or because `uppy.opts.restrictions` checks failed.
+ 
++If you try to add a file that already exists, `addFile` will throw an error. Unless that duplicate file was dropped/selected from a folder — duplicate files from different folders are allowed, when selected with that folder. This is because we add `file.meta.relativePath` to the `file.id`.","When we select files from different folders there is no `.relativePath`, we only have `.relativePath` on drop.",2019-08-23 18:39:09
+486,"@@ -34,6 +34,8 @@ function assertServerError (res) {
+ }
+ 
+ module.exports = class AwsS3Multipart extends Plugin {
++  static VERSION = require('../package.json').version","Is there an advantage to this vs setting `this.version` in the constructor? Cleaner this way, at the top?",2019-05-27 16:17:56
+479,"@@ -344,7 +342,13 @@ class Uploader {
+       resume: true,
+       retryDelays: [0, 1000, 3000, 5000],
+       uploadSize: this.bytesWritten,
+-      metadata,
++      metadata: Object.assign(
++        {
++          // file name and type as specified by tus protocol","Nitpicking, but is it defined by the protocol, or just the tusd implementation? I didn’t find it in the protocol, so maybe linking here: https://github.com/tus/tusd/blob/5b376141903c1fd64480c06dde3dfe61d191e53d/unrouted_handler.go#L614-L646?",2019-05-24 14:59:30
+588,"@@ -346,8 +409,24 @@ module.exports = class Tus extends Plugin {
+ 
+         this.uppy.emit('upload-success', file, uploadResp)
+         this.resetUploaderReferences(file.id)
++        queuedRequest.done()","![image](https://user-images.githubusercontent.com/7578559/63731836-0451f480-c88b-11e9-93f0-d6828b155b9c.png)
+
+I got this error here once, but I'm not sure why, and I don't seem to be able to reproduce it.",2019-08-27 00:26:01
+6,"@@ -35,12 +30,181 @@ export default class Core {
+ 
+     this.translator = new Translator({locales: this.opts.locales})
+     this.i18n = this.translator.translate.bind(this.translator)
+-    // console.log(this.i18n('filesChosen', {smart_count: 3}))
+ 
+     // Set up an event EventEmitter
+     this.emitter = new ee.EventEmitter()
+ 
+-    this.totalFilesSelectedCount = 0
++    this.defaultState = {
++      selectedFiles: {},
++      uploadedFiles: {},
++      modal: {
++        isHidden: true,
++        targets: []
++      }
++    }
++
++    this.state = Object.assign({}, this.state, this.defaultState)
++  }
++
++  /**
++   * Iterate on all plugins and run `update` on them. Called when state changes
++   *
++   */
++  updateAll () {
++    Object.keys(this.plugins).forEach((pluginType) => {
++      this.plugins[pluginType].forEach((plugin) => {
++        plugin.update(this.state)
++      })
++    })
++  }
++
++  /**
++   * Reset state to defaultState, used when Modal is closed, for example
++   *
++   */
++  resetState () {
++    this.setState(this.defaultState)
++  }
++
++  /**
++   * Updates state
++   *
++   * @param {newState} object
++   */
++  setState (newState) {
++    this.log(`Update state with: ${newState}`)
++    this.state = Object.assign({}, this.state, newState)
++    this.updateAll()
++  }
++
++  /**
++   * Gets current state, making sure to make a copy of the state object and pass that,
++   * instead of an actual reference to `this.state`
++   *
++   */
++  getState () {
++    return Object.assign({}, this.state)","I'm a little concerned it won't be clear that we're returning a copy of the state, rather than the actual state object to someone writing plugins.
+",2016-04-04 15:42:22
+350,"@@ -35,20 +35,21 @@ module.exports = class ThumbnailGenerator extends Plugin {
+    */
+   createThumbnail (file, targetWidth) {
+     const originalUrl = URL.createObjectURL(file.data)
++    const revoke = () => URL.revokeObjectURL(originalUrl)
+     const onload = new Promise((resolve, reject) => {
+       const image = new Image()
+       image.src = originalUrl
+       image.onload = () => {
+-        URL.revokeObjectURL(originalUrl)
+         resolve(image)
+       }
+       image.onerror = () => {
+         // The onerror event is totally useless unfortunately, as far as I know
+-        URL.revokeObjectURL(originalUrl)
+         reject(new Error('Could not create thumbnail'))
+       }
+     })
+ 
++    onload.then(revoke, revoke)
++","revoke, then revoke? 🤔",2018-09-10 13:24:59
+512,"@@ -35,6 +35,11 @@
+         color: purple;
+       }
+     </style>
++
++    <!-- polyfills for IE11 -->
++    <script src=""https://cdn.jsdelivr.net/npm/es6-promise@4/dist/es6-promise.min.js""></script>
++    <script src=""https://cdn.jsdelivr.net/npm/es6-promise@4/dist/es6-promise.auto.min.js""></script>","1. I don’t think both promise files are needed, we used to recommend just `es6-promise.auto.min.js`, and I think it worked in our tests: https://github.com/transloadit/uppy/pull/1576/files. I could be wrong.
+2. We have these polyfills included in the website examples, like https://uppy.io/examples/dashboard/. Maybe that’s enough for testing, and we could keep `dev` smaller/faster? On the one hand, it’s not too big of an addition, on the other it’s external resources just for IE testing.",2019-06-13 11:33:53
+187,"@@ -35,7 +35,7 @@ A site-wide unique ID for the instance.
+ If multiple Uppy instances are being used, for example on two different pages, an `id` should be specified.
+ This allows Uppy to store information in `localStorage` without colliding with other Uppy instances.
+ 
+-Note that this ID should be persistent across page reloads and navigation—it shouldn't be a random number that's different every time Uppy is loaded.
++Note that this ID should be persistent across page reloads and navigation — it shouldn't be a random number that's different every time Uppy is loaded.","IIRC em dashes do not require spaces around them, do they?",2018-01-02 11:36:39
+37,"@@ -353,6 +354,30 @@ function findDOMElement (element) {
+   }
+ }
+ 
++function getSocketHost (url) {
++  // get the host domain
++  var regex = /^(?:https?:\/\/|\/\/)?(?:[^@\n]+@)?(?:www\.)?([^\n]+)/
++  var host = regex.exec(url)[1]
++  var socketProtocol = location.protocol === 'https:' ? 'wss' : 'ws'
++
++  return `${socketProtocol}://${host}`
++}
++
++function _emitSocketProgress (uppyInstance, progressData, file) {","Can you rename `uppyInstance` to something like `uploader`? I think that's a bit clearer, I thought it was referring to a `Core` instance first.",2017-05-26 10:40:46
+234,"@@ -355,7 +355,8 @@ describe('src/Core', () => {
+         })
+         .then(() => {
+           const fileId = Object.keys(core.state.files)[0]
+-          core.emit('preprocess-progress', fileId, {
++          const file = core.state.files[fileId]",`core.getFile(fileId)`?,2018-02-22 14:28:03
+544,"@@ -358,14 +358,14 @@ module.exports = class ProviderView {
+       state = this.plugin.getPluginState()
+       state.selectedFolders[folderId] = { loading: false, files: files }
+       this.plugin.setPluginState({ selectedFolders: folders })
+-      const dashboard = this.plugin.uppy.getPlugin('Dashboard')","I think we have to keep this as a fallback for now, else it's a small breaking change :(",2019-07-08 09:46:31
+382,"@@ -36,6 +36,12 @@ In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` gl
+ const GoogleDrive = Uppy.GoogleDrive
+ ```
+ 
++## CSS
++
++Dashboard plugin is recommended as a container to all Provider plugins, including Google Drive. If you are using Dashboard, it [comes with all the nessesary styles](/docs/dashboard/#CSS) for Dropbox as well.
++
++⚠️ If you are feeling adventerous, and want to use Google Drive plugin separately, without Dashboard, make sure to include `@uppy/provider-views/dist/style.css` (or `style.min.css`) CSS file. This is experimental, not officialy supported and not recommened.",:point_up: ,2018-11-29 12:44:02
+381,"@@ -36,6 +36,13 @@ In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` gl
+ const Dropbox = Uppy.Dropbox
+ ```
+ 
++## CSS
++
++Dashboard plugin is recommended as a container to all Provider plugins, including Dropbox. If you are using Dashboard, it [comes with all the nessesary styles](/docs/dashboard/#CSS) for Dropbox as well.
++
++⚠️ If you are feeling adventerous, and want to use Dropbox plugin separately, without Dashboard, make sure to include `@uppy/provider-views/dist/style.css` (or `style.min.css`) CSS file. This is experimental, not officialy supported and not recommened.","adventerous → adventurous
+recommened → recommended
+
+Same in a few other places:",2018-11-29 12:43:49
+376,"@@ -36,6 +36,17 @@ In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` gl
+ const Url = Uppy.Url
+ ```
+ 
++## CSS
++
++The `@uppy/url` plugin requires the following CSS for styling:
++
++```js
++import '@uppy/core/dist/style.css'
++import '@uppy/url/dist/style.css'
++```
++
++Import general Core styles from `@uppy/core/dist/style.css` first, then add the Informer styles from `@uppy/url/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.","```suggestion
+Import general Core styles from `@uppy/core/dist/style.css` first, then add the Url styles from `@uppy/url/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.
+```",2018-11-22 12:26:19
+375,"@@ -36,6 +36,17 @@ In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` gl
+ const Webcam = Uppy.Webcam
+ ```
+ 
++## CSS
++
++The `@uppy/webcam` plugin requires the following CSS for styling:
++
++```js
++import '@uppy/core/dist/style.css'
++import '@uppy/webcam/dist/style.css'
++```
++
++Import general Core styles from `@uppy/core/dist/style.css` first, then add the Informer styles from `@uppy/webcam/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.","some plugin docs refer to Informer instead of the actual plugin name
+
+```suggestion
+Import general Core styles from `@uppy/core/dist/style.css` first, then add the Webcam styles from `@uppy/webcam/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.
+```",2018-11-22 12:26:04
+14,"@@ -36,61 +36,65 @@ Returns current state.
+ 
+ #### setState({itemToUpdate: data})
+ 
+-Updates state with new state (Object.assign({}, this.state, newState)) and runs `updateAll()`.
++Updates state with new state (Object.assign({}, this.state, newState)) and then runs `updateAll()`.
+ 
+ #### updateAll()
+ 
+-Iterates over all `plugins` and runs `update` on each of them.
++Iterates over all `plugins` and runs `update()` on each of them.
+ 
+ #### updateMeta(data, fileID)
+ 
+-Given `{size: 1200}` adds that metadata to a file.
++Given `{ size: 1200 }` adds that metadata to a file.
+ 
+ #### addFile(file)
+ 
+-Adds a new file to `state`, method used by `acquirer` plugins like Drag & Drop and Google Drive,
+-or can be called by the user on uppy instance directly.
++Adds a new file to `state`. This method is used by `acquirer` plugins like Drag & Drop, Webcam and Google Drive,
++or can be called by the user on uppy instance directly: `uppy.addFile(myFile)`.
+ 
+-Normalizes that file: tries to figure out file type by extension if mime is missing, use noname if name is missing and so on.
++Normalizes that file too: tries to figure out file type by extension if mime is missing, use noname if name is missing, sets progress: 0  and so on.
+ 
+ #### removeFile(fileID)
+ 
+ Removes file from `state`.
+ 
+ #### addThumbnail(fileID)
+ 
+-Reads image from file’s data object in base64 and resizes that, using canvas. Then `state` is updated with a file that has thumbnail it it. Thumbnails are used for file previews by plugins like Dashboard.
++Reads image from file’s data object in base64 and resizes that, using canvas. Then `state` is updated with a file that has thumbnail in it. Thumbnails are used for file previews by plugins like Dashboard.
+ 
+ #### state.capabilities
+ 
+-Core (or plugins) check and set capabilities, like: `resumable: true`, `touch: false`, `dragdrop: true` that could possibly be used by all plugins.
++Core (or plugins) check and set capabilities, like: `resumable: true` (this is set by Tus Plugin), `touch: false`, `dragdrop: true`, that could possibly be used by all plugins.
+ 
+ #### log(msg)
+ 
+ Logs stuff to console only if user specified `debug: true`, silent in production.
+ 
+ #### core.on('event', action), core.emit('event'), core.emitter
+ 
+-An event emitter embedded into Core that is passed to plugins and can be used directly on the instance. Event emitter is used for plugins to communicate with other plugins and Core.
++An event emitter embedded into Core that is passed to Plugins, and can be used directly on the instance. Used by Plugins for communicating with other Plugins and Core.
+ 
+ For example:
+ 
+-- Core listens for `core:upload-progress` event and calculates speed and ETA for one file, that the event was about, and for all files currently in progress.
++- Core listens for `core:upload-progress` event and calculates speed & ETA for all files currently in progress. *Uploader plugins could just call core.updateProgress().*
+ - Core checks if browser in offline or online and emits `core:is-offline` or `core:is-online` that other plugins can listen to.
+-- Any plugin can emit `informer` event that `Informer` plugin can use to display info bubbles. Currently only used in the Dashboard plugin. Example: `core.emitter.emit('informer', 'Connected!', 'success', 3000)`. (Should this be a Core method instead of plugin?).
+-- Uploader plugins listen to `core:upload` event (can be emitted after a file has been added or when upload button has been pressed), get files via `core.getState().files`, filter those that are not marked as complete and upload them, emitting progress events.
++- Any plugin can emit `informer` event that `Informer` plugin can use to display info bubbles. Currently only used in the Dashboard plugin. Example: `core.emitter.emit('informer', 'Connected!', 'success', 3000)`. (Should this be a Core method instead of Plugin?). *Could be replaced by core.inform(info) method that will just update state with info.*
++- Uploader plugins listen to `core:upload` event (can be emitted after a file has been added or when upload button has been pressed), get files via `core.getState().files`, filter those that are not marked as complete and upload them, emitting progress events. *This could be replaced by core.upload() method that will loop through all `uploaders` and run `upload()` on them, or we could only allow one uploader.*
++
++*Should most or all of the events from the above be replaced with method calls? Should event-emitter be used for internal communication or just for the user to hook on to, like `uppy.on(core:upload:complete, doStuff)`? Right now its both, same event-emitter serves as a communication bus inside Uppy + its exposed to the user outside. Inspiration for using it as a bus came from Substack’s example here https://github.com/substack/training/blob/3041b1e4e3908d4df1b26cf578c34cd4df8fe9b7/web-dev-whirlwind/example/arch/bus/actions.js, and somewhat from Redux and Choo’s send https://github.com/yoshuawuyts/choo/#views.*
+ 
+ *See discussion about Core and Event Emitter: https://github.com/transloadit/uppy/issues/116#issuecomment-247695921*
+ 
+ ## Plugins
+ 
+-Plugins extend the functionality of Core (which itself is very much barebones, does almost nothing).
++Plugins extend the functionality of Core (which itself is very much barebones, does almost nothing). Plugins actually do the work — select files, modify and upload them, and show the UI.
++
++Plugins that have some UI can be mounted anywhere in the dom. With current design you can have a Drag & Drop area in `#dragdrop` and Progressbar in `body`. Plugins can also be mounted into other plugins that support that, like Dashboard.
+ 
+-Each plugin extends `Plugin` class with default methods that can be overwritten:
++Each plugin extends `Plugin` class with default methods that can be overridden:
+ 
+ #### update()
+ 
+-Gets called when state is changes and `updateAll()` is called from Core. Checks if a DOM element (tree) has been created with a reference for it stored in plugin’s `this.el`. If so, crates a new element (tree) `const newEl = this.render(currentState)` on current plugin and then calls `yo.update(this.el, newEl)` to effectively update the existing element to match the new one (morphdom is behind that).
++Gets called when state changes and `updateAll()` is called from Core. Checks if a DOM element (tree) has been created with a reference for it stored in plugin’s `this.el`. If so, crates a new element (tree) `const newEl = this.render(currentState)` for current plugin and then calls `yo.update(this.el, newEl)` to effectively update the existing element to match the new one (morphdom is behind that).","crates-> creates
+",2016-10-13 09:49:15
+458,"@@ -36,7 +29,8 @@ class UrlUI extends Component {
+         aria-label={this.props.i18n('enterUrlToImport')}
+         placeholder={this.props.i18n('enterUrlToImport')}
+         onkeyup={this.handleKeyPress}
+-        ref={(input) => { this.input = input }} />
++        ref={(input) => { this.input = input }}
++        data-uppy-super-focusable />",`ref={(input)` not needed here?,2019-05-03 18:28:28
+524,"@@ -36,7 +36,7 @@ function addDashboardPlugin (uppy, opts, overrideOpts) {
+   })
+ 
+   const inline = overrideOpts.inline == null ? dashboardOpts.inline : overrideOpts.inline
+-  if (inline === false) {
++  if (!inline) {",@arturi this is where we were checking it inside Robodog to determine whether modal options should be passed through,2019-06-24 14:07:00
+235,"@@ -361,8 +361,10 @@ data = {
+ ```
+ 
+ ```javascript
+-uppy.on('upload-progress', (data) => {",the `data` object snippet still has an `id` up here—i think we can probably remove it entirely because you added the object shape in a comment in this code block.,2018-02-22 14:30:50
+640,"@@ -365,19 +366,27 @@ module.exports = class ThumbnailGenerator extends Plugin {
+   }
+ 
+   install () {
+-    this.uppy.on('file-added', this.onFileAdded)
+     this.uppy.on('file-removed', this.onFileRemoved)
+-    this.uppy.on('restored', this.onRestored)
++    if (this.opts.lazy) {
++      this.uppy.on('thumbnail:request', this.onFileAdded)","When scrolling a list of non-image files, this results in queue events like this:
+
+<img width=""1227"" alt=""Screen Shot 2019-11-27 at 19 14 59"" src=""https://user-images.githubusercontent.com/1199054/69740292-399c0600-114a-11ea-9d52-e57bc3696833.png"">
+
+Should we add `isPreviewSupported(file.type)` to `onFileAdded`?",2019-11-27 16:15:42
+691,"@@ -365,6 +382,23 @@ module.exports = class Webcam extends Plugin {
+     }, 1000)
+   }
+ 
++  changeVideoSource (deviceId) {
++    this.stop()
++    this.start(deviceId)
++  }
++
++  getVideoSources () {
++    this.videoSources = []
++    this.mediaDevices.enumerateDevices().then(res => {
++      this.videoSources = []
++      res.forEach((device) => {","We can do `this.videoSources = res.filter()` here, using [Array#filter](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/filter).",2020-03-09 09:55:59
+113,"@@ -367,7 +367,7 @@ function copyToClipboard (textToCopy, fallbackString) {
+     const magicCopyFailed = (err) => {
+       document.body.removeChild(textArea)
+       window.prompt(fallbackString, textToCopy)
+-      return reject('Oops, unable to copy displayed fallback prompt: ' + err)
++      return reject(new Error('Oops, unable to copy displayed fallback prompt: ' + err))
+     }","> unable to copy displayed fallback prompt
+
+does this mean “unable to copy, so displayed fallback prompt instead”? :) should it reject if the prompt is successful shown?",2017-09-22 18:01:13
+782,"@@ -37,19 +37,6 @@ module.exports = class GoogleDrive extends Plugin {
+     this.view = new DriveProviderViews(this, {
+       provider: this.provider
+     })
+-    // Set default state for Google Drive
+-    this.setPluginState({
+-      authenticated: false,
+-      files: [],
+-      folders: [],
+-      directories: [],
+-      activeRow: -1,
+-      filterInput: '',
+-      isSearchVisible: false,
+-      hasTeamDrives: false,
+-      teamDrives: [],
+-      teamDriveId: ''","This teamDrive stuff is specific to gdrive, should it be kept so it's still initialised properly? Or added to the DriveProviderViews constructor maybe?",2020-06-15 13:05:23
+384,"@@ -37,3 +37,7 @@ uppy.use(Instagram, {target: Dashboard, serverUrl: 'http://localhost:3020'})
+ const Url = require('@uppy/url')
+ uppy.use(Url, {target: Dashboard, serverUrl: 'http://localhost:3020'})
+ ```
++
++⚠️ The [Dashboard](/docs/dashboard) plugin is recommended as a universal container to all Provider plugins. It also comes with file previews, progress reporting and more. If you are using the Dashboard, it already [comes with all the nessesary styles](/docs/dashboard/#CSS) and functionality for Providers to work well.
++
++If you are feeling adventerous, you can technically use a Provider plugin separately, without the Dashboard. Make sure to then include `@uppy/provider-views/dist/style.css` (or `style.min.css`) CSS file. But this is experimental, not officialy supported and not recommened.",:point_up: ,2018-11-29 12:44:17
+996,"@@ -370,6 +370,7 @@ module.exports = class Webcam extends Plugin {
+           // eslint-disable-next-line compat/compat
+           recordedVideo: URL.createObjectURL(file.data),
+         })
++        this.opts.mirror = false",Will this reset if you cancel and then re-record?,2021-04-01 22:26:01
+510,"@@ -370,8 +380,13 @@ module.exports = class XHRUpload extends Plugin {
+       files.forEach((file, i) => {
+         const opts = this.getOptions(file)
+ 
++        // Set `file.data.type` in the blob to `file.meta.type`,
++        // because we might have detected a more accurate file type in Uppy
++        // https://stackoverflow.com/a/50875615
++        file.data = file.data.slice(0, file.data.size, file.meta.type)","I would prefer doing `const data = file.data.slice()` here instead of mutating the object, state isn't supposed to be modified outside of setState() calls",2019-06-12 08:12:47
+682,"@@ -372,6 +372,9 @@ uppy.addFile({
+   name: 'my-file.jpg', // file name
+   type: 'image/jpeg', // file type
+   data: blob, // file blob
++  meta: {
++      relativePath: string, // optional, determines the unique relative path to build the file uppy id","The file ID is kind of a detail. I think the important thing for end-users is that it allows you to add multiple identical files. Maybe we can do something like this?
+```suggestion
+    // optional, store the directory path of a file so Uppy can tell identical files in different directories apart
+    relativePath: webkitFileSystemEntry.relativePath,
+```",2020-03-02 14:04:06
+158,"@@ -379,24 +388,24 @@ module.exports = class DashboardUI extends Plugin {
+       .map(attachRenderFunctionToTarget)
+ 
+     const startUpload = (ev) => {
+-      this.core.upload().catch((err) => {
++      this.uppy.upload().catch((err) => {
+         // Log error.
+-        this.core.log(err.stack || err.message || err)
++        this.uppy.log(err.stack || err.message || err)
+       })
+     }
+ 
+     const cancelUpload = (fileID) => {
+-      this.core.emit('core:upload-cancel', fileID)
+-      this.core.emit('core:file-remove', fileID)
++      this.uppy.emit('upload-cancel', fileID)
++      this.uppy.removeFile(fileID)",++ nice catch,2017-12-09 16:14:19
+377,"@@ -38,11 +38,16 @@ const StatusBar = Uppy.StatusBar
+ 
+ ## CSS
+ 
+-The `@uppy/status-bar` plugin includes a CSS file for styling. If you are using the [`@uppy/dashboard`](/docs/dashboard) plugin, you do not need to include the styles for the StatusBar, because the Dashboard already includes it.
++The `@uppy/status-bar` plugin requires the following CSS for styling:
+ 
+-The CSS file lives at `@uppy/status-bar/dist/style.css`. A minified version can be found at `@uppy/status-bar/dist/style.min.css`.
++```js
++import '@uppy/core/dist/style.css'
++import '@uppy/status-bar/dist/style.css'
++```
++
++Import general Core styles from `@uppy/core/dist/style.css` first, then add the Informer styles from `@uppy/status-bar/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.","```suggestion
+Import general Core styles from `@uppy/core/dist/style.css` first, then add the Progress Bar styles from `@uppy/status-bar/dist/style.css`. A minified version is also available as `style.min.css` at the same path. The way to do import depends on your build system.
+```",2018-11-22 12:26:36
+383,"@@ -38,6 +38,12 @@ In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` gl
+ const Instagram = Uppy.Instagram
+ ```
+ 
++## CSS
++
++Dashboard plugin is recommended as a container to all Provider plugins, including Instagram. If you are using Dashboard, it [comes with all the nessesary styles](/docs/dashboard/#CSS) for Dropbox as well.
++
++⚠️ If you are feeling adventerous, and want to use Instagram plugin separately, without Dashboard, make sure to include `@uppy/provider-views/dist/style.css` (or `style.min.css`) CSS file. This is experimental, not officialy supported and not recommened.",:point_up: ,2018-11-29 12:44:09
+255,"@@ -381,6 +393,7 @@ class Uppy {
+       fileName = 'noname'
+     }
+     const fileExtension = Utils.getFileNameAndExtension(fileName).extension
++    console.log(fileExtension)",forgot to remove this?,2018-05-09 15:47:15
+566,"@@ -383,7 +383,50 @@ module.exports = class XHRUpload extends Plugin {
+       }).then((res) => {
+         const token = res.token
+         const host = getSocketHost(file.remote.companionUrl)
+-        const socket = new Socket({ target: `${host}/api/${token}` })
++        const socket = new Socket({ target: `${host}/api/${token}`, autoOpen: false })
++
++        this.onFileRemove(file.id, () => {
++          socket.send('pause', {})
++          queuedRequest.abort()
++          resolve(`upload ${file.id} was removed`)
++        })
++
++        this.onPause(file.id, (isPaused) => {","I thought xhr uploads can’t be pause-resumed? Or is this for `aws-s3-multipart` and such, that use xhr-upload?",2019-08-07 13:39:17
+162,"@@ -385,11 +386,37 @@ class Uppy {
+   }
+ 
+   removeFile (fileID) {
+-    const updatedFiles = Object.assign({}, this.getState().files)
++    const { files, currentUploads } = this.state
++    const updatedFiles = Object.assign({}, files)
+     const removedFile = updatedFiles[fileID]
+     delete updatedFiles[fileID]
+ 
+-    this.setState({files: updatedFiles})
++    // Remove this file from its `currentUpload`.
++    const updatedUploads = Object.assign({}, currentUploads)
++    const removeUploads = []
++    Object.keys(updatedUploads).forEach((uploadID) => {
++      const newFileIDs = currentUploads[uploadID].fileIDs.filter((uploadFileID) => uploadFileID !== fileID)
++      // Remove the upload if no files are associated with it anymore.
++      if (newFileIDs.length === 0) {
++        removeUploads.push(uploadID)
++        return
++      }
++
++      updatedUploads[uploadID] = Object.assign({}, currentUploads[uploadID], {
++        fileIDs: newFileIDs
++      })
++    })
++
++    this.setState({
++      currentUploads: updatedUploads,
++      files: updatedFiles
++    })
++
++    removeUploads.forEach((uploadID) => {
++      this.removeUpload(uploadID)
++    })
++
++    this.calculateTotalProgress()
+     this._calculateTotalProgress()",Accidental duplicate `calculateTotalProgress` here.,2017-12-12 01:06:18
+478,"@@ -385,7 +389,15 @@ class Uploader {
+     const formData = Object.assign(
+       {},
+       this.options.metadata,
+-      { [this.options.fieldname]: file }
++      {
++        [this.options.fieldname]: {
++          value: file,
++          options: {
++            filename: this.uploadFileName,
++            contentType: this.options.metadata.type
++          }
++        }
++      }","Maybe a comment/link here too, as to why `filename` and `contentType`? Stating that it’s conventional and linking to https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Disposition#Directives and https://github.com/request/request?",2019-05-24 14:38:17
+796,"@@ -39,6 +39,37 @@ In the [CDN package](/docs/#With-a-script-tag), it is available on the `Uppy` gl
+ const GoogleDrive = Uppy.GoogleDrive
+ ```
+ 
++## Setting  Up
++
++To use the Google Drive provider, you need to configure the Google Drive keys that Companion should use. With the standalone Companion server, specify environment variables:
++```shell
++export COMPANION_GOOGLE_KEY=""Google Drive OAuth client ID""
++export COMPANION_GOOGLE_SECRET=""Google Drive OAuth client secret""
++```
++
++When using the Companion Node.js API, configure these options:
++```js
++companion.app({
++  providerOptions: {
++    drive: {
++      key: 'Google Drive OAuth client ID',
++      secret: 'Google Drive OAuth client secret'
++    }
++  }
++})
++```
++
++To sign up for API keys, go to the [Google Developer Console](https://console.developers.google.com/).
++
++Create a project for your app if you don't have one yet.
++- On the project's dashboard, [enable the Google Drive API](https://developers.google.com/drive/api/v3/enable-drive-api).
++- [Set up OAuth authorization](https://developers.google.com/drive/api/v3/about-auth). Use this for an authorized redirect URI:
++   ```
++   https://$YOUR_COMPANION_HOST_NAME/connect/drive/callback","```suggestion
+   https://$YOUR_COMPANION_HOST_NAME/connect/google/callback
+```
+Another inconsistency that we should fix as per [this](https://github.com/transloadit/uppy/pull/2346#issuecomment-651096963)",2020-06-29 13:10:02
+667,"@@ -39,6 +46,19 @@ module.exports = function getIconByMime (fileType) {
+     }
+   }
+ 
++  if (fileTypeGeneral === 'application' && (
++    fileTypeSpecific === 'zip' ||
++    fileTypeSpecific === 'x-7z-compressed' ||
++    fileTypeSpecific === 'x-rar-compressed' ||
++    fileTypeSpecific === 'x-gtar' ||
++    fileTypeSpecific === 'x-apple-diskimage')","@goto-bus-stop do you maybe have better ideas on detecting archives? I could move the `fileTypeSpecific`s to an array, but other than that :)",2020-01-16 18:54:57
+798,"@@ -390,13 +391,48 @@ To work well with Companion, the **Module** must be a class with the following m
+     - token - authorization token (retrieved from oauth process) to send along with your request
+     - directory - the `id/name` of the directory from which data is to be retrieved. This may be ignored if it doesn't apply to your provider
+     - query - expressjs query params object received by the server (just in case there is some data you need in there).
+-  - `done (err, response, body)` - the callback that should be called when the request to your provider is made. As the signature indicates, the following data should be passed along to the callback `err`, `response`, and `body`.
+-2. `download (options, onData, onResponse)` - downloads a particular file from the provider.
++  - `done (err, data)` - the callback that should be called when the request to your provider is made. As the signature indicates, the following data should be passed along to the callback `err`, and [`data`]((#list-data)).
++2. `download (options, onData)` - downloads a particular file from the provider.
+   - `options` - is an object containing the following attributes:
+     - token - authorization token (retrieved from oauth process) to send along with your request.
+     - id - ID of the file being downloaded.
+-  - `onData (chunk)` - a callback that should be called with each data chunk received on download. This is useful if the size of the downloaded file can be pre-determined. This would allow for pipelined upload of the file (to the desired destination), while the download is still going on.
+-  - `onResponse (response)` - if the size of the downloaded file can not be pre-determined by Companion, then this callback should be called in place of the `onData` callback. This callback would be called after the download is done, and would take the downloaded data (response) as the argument.
++    - query - expressjs query params object received by the server (just in case there is some data you need in there).
++  - `onData (err, chunk)` - a callback that should be called with each data chunk received as download is happening. The `err` argument is an error that should be passed if an error occurs during download. It should be `null` if there's no error. Once the download is completed and there are no more chunks to receive, `onData` should be called with `null` values like so `onData(null, null)`
++3. `size (options, done)` - returns the byte size of the file that needs to be downloaded.
++  - `options` - is an object containing the following attributes:
++    - token - authorization token (retrieved from oauth process) to send along with your request.
++    - id - ID of the file being downloaded.
++  - `done (err, size)` - the callback that should be called after the request to your provider is completed. As the signature indicates, the following data should be passed along to the callback `err`, and `size` (number).
++
++The class must also have an `authProvider` string (lowercased) field which typically indicates the name of the provider (e.g ""dropbox"").
++
++#### list data
++
++```js
++{
++  username: 'username or email of the user whose provider account is being accessed',","Some of these properties have example data and some have an explanation string, maybe it would be better to consistently use comments for explanation and example values as the values? some of the text gets quite long and with comments we can add some newlines :)",2020-06-29 13:39:48
+418,"@@ -392,7 +394,7 @@
+ .uppy-ProviderBrowserItem-checkbox {
+   position: relative;
+   display: inline-block;
+-  top: -3px;
++  // top: -3px;",probably better to delete since we are now approaching `1.0`,2019-03-28 00:59:24
+141,"@@ -394,7 +395,7 @@ class Uppy {
+    */
+   generatePreview (file) {
+     if (Utils.isPreviewSupported(file.type) && !file.isRemote) {
+-      Utils.createThumbnail(file, 200).then((thumbnail) => {
++      Utils.createThumbnail(file, 200, this.opts.thumbnailGeneration).then((thumbnail) => {","I wonder if it would be better to do the `this.opts.thumbnailGeneration` check here instead of changing `createThumbnail`? You probably wanted to keep it clean with the promise, maybe that’s a good idea.",2017-11-23 18:37:30
+390,"@@ -395,9 +393,13 @@ module.exports = class XHRUpload extends Plugin {
+         timer.done()
+ 
+         if (ev.target.status >= 200 && ev.target.status < 300) {
+-          const resp = this.opts.getResponseData(xhr.responseText, xhr)
++          const body = this.opts.getResponseData(xhr.responseText, xhr)
++          const uploadResp = {
++            status: ev.target.status,
++            body
++          }",No `uploadURL` for bundles?,2018-12-19 20:22:39
+933,"@@ -4,6 +4,7 @@ const Uppy = require('@uppy/core')
+ const Dashboard = require('@uppy/dashboard')
+ const GoogleDrive = require('@uppy/google-drive')
+ const Dropbox = require('@uppy/dropbox')
++const Box = require('@uppy/box')","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:14:29
+82,"@@ -4,8 +4,8 @@
+     <input type=""text"" id=""search-query"" class=""MainMenu-searchQuery st-default-search-input"">
+   </form>
+ </li> -->
+-<li><a href=""/guide/"" class=""nav-link<%- page.path.match(/guide/) ? ' current' : '' %>"">Guide</a></li>
+-<li><a href=""/api/"" class=""nav-link<%- page.path.match(/api/) ? ' current' : '' %>"">API</a></li>",Can haz redirects for poor internetters stumbling upon `/api/`?,2017-08-14 12:14:02
+278,"@@ -40,54 +48,15 @@ uppy.use(Dashboard, {
+   disablePageScrollWhenModalOpen: true,
+   proudlyDisplayPoweredByUppy: true,
+   onRequestCloseModal: () => this.closeModal(),
+-  locale: {
+-    strings: {
+-      selectToUpload: 'Select files to upload',
+-      closeModal: 'Close Modal',
+-      upload: 'Upload',
+-      importFrom: 'Import from',
+-      dashboardWindowTitle: 'Uppy Dashboard Window (Press escape to close)',
+-      dashboardTitle: 'Uppy Dashboard',
+-      copyLinkToClipboardSuccess: 'Link copied to clipboard.',
+-      copyLinkToClipboardFallback: 'Copy the URL below',
+-      copyLink: 'Copy link',
+-      fileSource: 'File source',
+-      done: 'Done',
+-      name: 'Name',
+-      removeFile: 'Remove file',
+-      editFile: 'Edit file',
+-      editing: 'Editing',
+-      finishEditingFile: 'Finish editing file',
+-      localDisk: 'Local Disk',
+-      myDevice: 'My Device',
+-      dropPasteImport: 'Drop files here, paste, import from one of the locations above or',
+-      dropPaste: 'Drop files here, paste or',
+-      browse: 'browse',
+-      fileProgress: 'File progress: upload speed and ETA',
+-      numberOfSelectedFiles: 'Number of selected files',
+-      uploadAllNewFiles: 'Upload all new files',
+-      emptyFolderAdded: 'No files were added from empty folder',
+-      uploadComplete: 'Upload complete',
+-      resumeUpload: 'Resume upload',
+-      pauseUpload: 'Pause upload',
+-      retryUpload: 'Retry upload',
+-      uploadXFiles: {
+-        0: 'Upload %{smart_count} file',
+-        1: 'Upload %{smart_count} files'
+-      },
+-      uploadXNewFiles: {
+-        0: 'Upload +%{smart_count} file',
+-        1: 'Upload +%{smart_count} files'
+-      },
+-      folderAdded: {
+-        0: 'Added %{smart_count} file from %{folder}',
+-        1: 'Added %{smart_count} files from %{folder}'
+-      }
+-    }
+-  }
++  locale: {}
+ })
+ ```
+ 
++### `id: 'Dashboard'`
++
++A unique identifier for this Dashboard. Defaults to `'Dashboard'`. Change this if you need multiple Dashboard instances.
++Plugins that are added by the Dashboard get unique IDs based on this ID, like `'Dashboard:StatusBar'` and `'Dashboard:Informer'`.
++",💯,2018-05-24 22:56:56
+454,"@@ -40,6 +41,7 @@
+     ""eslint-plugin-jest"": ""^21.27.2"",
+     ""eslint-plugin-node"": ""^4.2.3"",
+     ""eslint-plugin-promise"": ""^3.8.0"",
++    ""eslint-plugin-react"": ""^7.12.4"",
+     ""eslint-plugin-standard"": ""^3.1.0"",",do we need `eslint-plugin-react` for something?,2019-04-25 10:51:48
+227,"@@ -40,6 +41,8 @@ class MusicUploadButton extends React.Component {
+   }
+ 
+   render () {
++    this.props.uppy.use(Webcam, { id: ""Webcam"" });
++","Webcam will get `id: ""Webcam""` by default, so I’m wondering if we should omit this here for simplicity.",2018-02-15 00:35:04
+63,"@@ -401,6 +401,27 @@ function findDOMElement (element) {
+   }
+ }
+ 
++/**
++* Get metadata object from a form element
++*
++* @param {Node|string} element
++* @return {Object|null}
++*/
++
++function getMetaFromForm (element) {
++  if (!element || element.tagName !== 'FORM') {
++    console.error('Metadata can only be extracted from form elements')
++    return null
++  }
++
++  var formData = new FormData(element)
++  var result = {}
++  for (var entry of formData.entries()) {",`entries()` is not supported in IE and Edge…but it looks like there isn't really another way to get data out of a FormData instance 😕 Maybe there's a library for that that doesn't use `FormData`?,2017-06-29 11:30:41
+345,"@@ -401,6 +401,6 @@ class Uploader {
+ 
+ Uploader.FILE_NAME_PREFIX = 'uppy-file'
+ // @todo do a proper migration to change this name
+-Uploader.STORAGE_PREFIX = 'uppy-server'
++Uploader.STORAGE_PREFIX = 'companion'",Do we need a proper migration to change this name as the comment says? :smile: I think this is only for temporary storage so it may not be a big deal…,2018-09-03 12:00:04
+103,"@@ -402,8 +402,9 @@ describe('src/Core', () => {
+         .then(() => core.upload())
+         .then(() => {
+           expect(postprocessor1.mock.calls.length).toEqual(1)
+-          const lastModifiedTime = new Date()
+-          const fileId = 'foojpg' + lastModifiedTime.getTime()
++          // const lastModifiedTime = new Date()
++          // const fileId = 'foojpg' + lastModifiedTime.getTime()",Could remove these lines entirely :) ,2017-09-11 07:50:13
+268,"@@ -407,23 +416,28 @@ module.exports = class Tus extends Plugin {
+   }
+ 
+   uploadFiles (files) {
+-    const promises = files.map((file, index) => {
+-      const current = parseInt(index, 10) + 1
++    const actions = files.map((file, i) => {
++      const current = parseInt(i, 10) + 1
+       const total = files.length
+ 
+       if (file.error) {
+-        return Promise.reject(new Error(file.error))
+-      }
+-
+-      this.uppy.log(`uploading ${current} of ${total}`)
+-
+-      if (file.isRemote) {
+-        return this.uploadRemote(file, current, total)
++        return () => Promise.reject(new Error(file.error))
++      } else if (file.isRemote) {
++        // We emit upload-started here, so that it's also emitted for files
++        // that have to wait due to the `limit` option.
++        this.uppy.emit('upload-started', file)",The `upload-started` events on lines 207 and 230 need to be removed because they were moved here,2018-05-14 11:24:41
+506,"@@ -41,11 +45,12 @@ exports.debug = (msg, tag) => {
+  * @param {string | Error} msg the message to log
+  * @param {string} tag a unique tag to easily search for this message
+  * @param {string} level error | info | debug
++ * @param {function=} color function to display the log in appropriate color
+  */
+-const log = (msg, tag, level) => {
+-  // @TODO add some colors based on log level
++const log = (msg, tag, level, color) => {
+   const time = new Date().toISOString()
++  color = color || ((message) => message)
+   // exclude msg from template string so values such as error objects
+   // can be well formatted
+-  console.log(`uppy: ${time} [${level}] ${tag || ''}`, msg)
++  console.log(color(`uppy: ${time} [${level}] ${tag || ''}`), color(msg))",Should this read `companion: ` actually?,2019-06-11 07:57:16
+202,"@@ -41,19 +41,19 @@ $ npm install uppy
+ 
+ We recommend installing from NPM and then using a module bundler such as [Webpack](http://webpack.github.io/), [Browserify](http://browserify.org/) or [Rollup.js](http://rollupjs.org/).
+ 
+-If you like, you can also use a pre-built bundle, for example from [unpkg CDN](https://unpkg.com/uppy/). In that case `Uppy` will attach itself to the global `window.Uppy` object.
++Alternatively, you can also use a pre-built bundle, for example from Transloadit's CDN: Edgly. In that case `Uppy` will attach itself to the global `window.Uppy` object.","We could just get rid of the ""for example"" bit here I think.
+
+> Alternatively, you can use a pre-built bundle from Transloadit's CDN: Edgly.",2018-01-29 08:53:19
+313,"@@ -41,57 +41,9 @@ function buildUppyBundle (minify) {
+   })
+ }
+ 
+-// function copyLocales () {
+-//   var copyCommand = 'cp -R ' + path.join(srcPath, 'locales/') + ' ' + path.join(distPath, 'locales/')
+-//   return new Promise(function (resolve, reject) {
+-//     exec(copyCommand, function (error, stdout, stderr) {
+-//       if (error) {
+-//         handleErr(error)
+-//         reject(error)
+-//         return
+-//       }
+-//       console.info(chalk.green('✓ Copied locales to dist'))
+-//       resolve()
+-//     })
+-//   })
+-// }
+-
+-// function buildLocale (file) {
+-//   return new Promise(function (resolve, reject) {
+-//     var fileName = path.basename(file, '.js')
+-//     browserify(file)
+-//       .transform(babelify)
+-//       .on('error', handleErr)
+-//       .bundle()
+-//       .pipe(fs.createWriteStream('./dist/locales/' + fileName + '.js', 'utf8'))
+-//       .on('error', handleErr)
+-//       .on('finish', function () {
+-//         console.info(chalk.green('✓ Built Locale:'), chalk.magenta(fileName + '.js'))
+-//         resolve()
+-//       })
+-//   })
+-// }
+-
+-// function buildUppyLocales () {
+-//   mkdirp.sync('./dist/locales')
+-//   var localePromises = []
+-//   glob('./src/locales/*.js', function (err, files) {
+-//     if (err) console.log(err)
+-//     files.forEach(function (file) {
+-//       localePromises.push(buildLocale(file))
+-//     })
+-//   })
+-//   return Promise.all(localePromises)
+-// }
+-
+ mkdirp.sync(distPath)
+ 
+ Promise.all([buildUppyBundle(), buildUppyBundle(true)])
+   .then(function () {
+     console.info(chalk.yellow('✓ JS Bundle 🎉'))
+   })
+-
+-// Promise.all([buildUppyBundle(), buildUppyBundle(true), buildUppyLocales()])
+-//   .then(function () {
+-//     console.info(chalk.yellow('✓ JS Bundle 🎉'))
+-//   })","ha, good :)",2018-07-16 10:28:34
+374,"@@ -41,7 +41,7 @@
+     ""express-interceptor"": ""^1.2.0"",
+     ""express-prom-bundle"": ""^3.1.0"",
+     ""express-session"": ""1.15.6"",
+-    ""grant-express"": ""^4.0.1"",
++    ""grant-express"": ""4.1.2"",
+     ""helmet"": ""3.8.2"",",Why this version of `grant-express`? And should we pin everything else too?,2018-11-21 10:11:41
+214,"@@ -411,6 +424,10 @@ class Uppy {
+     const removedFile = updatedFiles[fileID]
+     delete updatedFiles[fileID]
+ 
++    this.removers.forEach((remover) => {
++      remover([fileID])
++    })","Processor and uploader functions are kept in arrays in core because you can have multiple. I think a single remover function should be enough; it doesn't need a pipeline like uploads may need.
+
+Maybe this can be done by emitting a `remove-file` event here in `removeFile()`, and then listening for it in a `DeleteFiles` plugin instead?",2018-02-05 10:41:10
+153,"@@ -413,14 +424,7 @@ class Uppy {
+    * Set the preview URL for a file.
+    */
+   setPreviewURL (fileID, preview) {
+-    const { files } = this.getState()
+-    this.setState({
+-      files: Object.assign({}, files, {
+-        [fileID]: Object.assign({}, files[fileID], {
+-          preview: preview
+-        })
+-      })
+-    })
++    this.setFileState(fileID, { preview: preview })",yay!,2017-12-09 16:05:26
+111,"@@ -414,4 +414,30 @@ describe('core/utils', () => {
+       ).toEqual('ws://foo.bar/a/b/cd?e=fghi&l=k&m=n')
+     })
+   })
++
++  describe('settle', () => {
++    it('should reject if all input promises reject', () => {
++      return expect(
++        utils.settle([
++          Promise.reject(new Error('oops')),
++          Promise.reject(new Error('this went wrong'))
++        ])
++      ).rejects.toMatchObject({
++        message: 'oops'
++      })
++    })
++
++    it('should resolve with an object if some input promises resolve', () => {
++      return expect(
++        utils.settle([
++          Promise.reject(new Error('rejected')),
++          Promise.resolve('resolved'),
++          Promise.resolve('also-resolved')
++        ])
++      ).resolves.toMatchObject({",this promise support is a kinda neat thing about jest,2017-09-20 09:08:02
+125,"@@ -415,61 +422,93 @@ class Uppy {
+     })
+   }
+ 
+-  pauseResume (action, fileID) {
++  pauseResume (fileID) {
++    const updatedFiles = Object.assign({}, this.getState().files)
++
++    if (updatedFiles[fileID].uploadComplete) return
++
++    const wasPaused = updatedFiles[fileID].isPaused || false
++    const isPaused = !wasPaused
++
++    let updatedFile
++    if (wasPaused) {
++      updatedFile = Object.assign({}, updatedFiles[fileID], {
++        isPaused: false
++      })
++    } else {
++      updatedFile = Object.assign({}, updatedFiles[fileID], {
++        isPaused: true
++      })
++    }","Not really related, but this `if` could be replaced with
+
+```js
+const updatedFile = Object.assign({}, updatedFiles[fileID], {
+  isPaused: !wasPaused
+})
+```",2017-10-03 11:06:31
+73,"@@ -415,7 +415,7 @@ class Uppy {
+       throttledCalculateProgress(data)
+     })
+ 
+-    this.on('core:upload-success', (fileID, uploadResp, uploadURL) => {","I think someone specifically asked for a full response object, and it makes sense. Is this removing uploadResp, or am I missing something?",2017-07-12 23:12:26
+85,"@@ -419,6 +437,20 @@ class Uppy {
+       this.addFile(data)
+     })
+ 
++    this.on('core:file-added', (file) => {
++      this.emit('core:generate-preview', file)
++    })
++
++    this.on('core:generate-preview', (file) => {
++      if (Utils.isPreviewSupported(file.type.specific) && !file.isRemote) {
++        Utils.createThumbnail(file, 200).then((thumbnail) => {
++          this.setPreviewURL(file.id, thumbnail)
++        }).catch((err) => {
++          console.warn(err.stack || err.message)
++        })
++      }
++    })",Why event instead of method? Should we distinguish them more strictly?,2017-08-18 14:20:03
+944,"@@ -42,14 +54,38 @@ module.exports = class Provider extends RequestClient {
+     return this.uppy.getPlugin(this.pluginId).storage.getItem(this.tokenKey)
+   }
+ 
+-  authUrl () {
+-    return `${this.hostname}/${this.id}/connect`
++  authUrl (queries) {","Technically this is a breaking change. But the `authUrl()` function is not a public API, but one for use by provider-views. So I think we should do a major version bump to companion-client (because of this API change) and provider-views (because it expects the new API), but the provider modules themselves don't need one.",2020-11-16 12:51:13
+938,"@@ -42,14 +54,38 @@ module.exports = class Provider extends RequestClient {
+     return this.uppy.getPlugin(this.pluginId).storage.getItem(this.tokenKey)
+   }
+ 
+-  authUrl () {
+-    return `${this.hostname}/${this.id}/connect`
++  authUrl (queries) {
++    const urlQueries = []
++    if (queries) {
++      urlQueries.push(queries)
++    }
++
++    if (this.preAuthToken) {
++      urlQueries.push(`uppyPreAuthToken=${this.preAuthToken}`)
++    }
++
++    queries = urlQueries.join('&')","Maybe we can reduce the room for error here by making `authUrl` take an object and using [`qs-stringify`](https://www.npmjs.com/package/qs-stringify)? The preAuthToken is not being URL-encoded here and that might be fine, but it's also something that's easy to forget when passing query strings into the `queries` argument.",2020-11-16 11:25:31
+779,"@@ -42,44 +37,150 @@ function progressIndicatorTitle (props) {
+   return ''
+ }
+ 
++// function PauseResumeCancelIcon (props) {","I'd vote that, when we're ready to commit to master, it's time to remove large old functions as comments like this one and start relying on Git for history to retrieve them",2020-06-03 08:40:00
+924,"@@ -42,6 +44,20 @@ module.exports = class SharedHandler {
+       } else {
+         currentSelection = items.slice(currentIndex, prevIndex + 1)
+       }
++      // Check restrictions on each file in currentSelection,
++      // reduce it to only contain files that pass restrictions
++      currentSelection = currentSelection.reduce((reducedCurrentSelection, item) => {
++        const uppy = this.plugin.uppy
++        const validatedRestrictions = uppy.validateRestrictions(
++          remoteFileObjToLocal(item),
++          [...uppy.getFiles(), ...reducedCurrentSelection]
++        )
++        if (!validatedRestrictions.result) {
++          uppy.info({ message: validatedRestrictions.reason }, 'error', 5000)
++          return reducedCurrentSelection
++        }
++        return [...reducedCurrentSelection, item]
++      })",@lakesare could you take a look at the reducer here? makes sense? thx!,2020-11-11 17:47:18
+503,"@@ -420,7 +420,7 @@ module.exports = class ProviderView {
+   handleAuth () {
+     const authState = btoa(JSON.stringify({ origin: getOrigin() }))
+     // @todo remove this hardcoded version
+-    const clientVersion = 'companion-client:1.0.2'
++    const clientVersion = encodeURIComponent('@uppy/companion-client=1.0.2')",`ProviderView` just got `VERSION` too.,2019-06-05 17:32:55
+402,"@@ -422,7 +422,7 @@ module.exports = class ProviderView {
+   }
+ 
+   handleAuth () {
+-    const authState = btoa(JSON.stringify({ origin: location.origin }))
++    const authState = btoa(JSON.stringify({ origin: location.origin, redirect: 'http://localhost:3' }))
+     const link = `${this.provider.authUrl()}?state=${authState}`",`http://localhost:3` 🤔 ,2019-02-21 15:04:33
+534,"@@ -422,8 +422,7 @@ module.exports = class ProviderView {
+ 
+   handleAuth () {
+     const authState = btoa(JSON.stringify({ origin: getOrigin() }))
+-    // @todo remove this hardcoded version
+-    const clientVersion = encodeURIComponent('@uppy/companion-client=1.0.2')
++    const clientVersion = encodeURIComponent(`@uppy/companion-client=${ProviderView.VERSION}`)",Hmm this should've been `@uppy/provider-views` I guess! Can we still change it now with back compat or will we just have to suck it up? :P ,2019-07-01 11:48:19
+582,"@@ -423,6 +423,27 @@ class Uppy {
+     }
+   }
+ 
++  _showOrLogErrorAndThrow (err, showInformer = true) {","Maybe let's make it `(err, { showInformer = true } = {})`,  so that we can use
+```
+this._showOrLogErrorAndThrow('Cannot add the file'), { showInformer: true })
+```
+instead of less obvious
+```
+this._showOrLogErrorAndThrow('Cannot add the file'), false)
+```
+?",2019-08-23 22:32:32
+581,"@@ -423,6 +423,27 @@ class Uppy {
+     }
+   }
+ 
++  _showOrLogErrorAndThrow (err, showInformer = true) {
++    const message = typeof err === 'object' ? err.message : err","Is `err` ever not an object? Looks like it's always an Error object in our code, and we don't need this check.",2019-08-23 22:28:19
+583,"@@ -423,6 +423,27 @@ class Uppy {
+     }
+   }
+ 
++  _showOrLogErrorAndThrow (err, showInformer = true) {
++    const message = typeof err === 'object' ? err.message : err
++    const details = (typeof err === 'object' && err.details) ? err.details : ''",What's that `error.details` field? Do we define it somewhere?,2019-08-23 22:36:22
+908,"@@ -425,44 +426,54 @@ class Uppy {
+   }
+ 
+   /**
+-   * Check if minNumberOfFiles restriction is reached before uploading.
++   * A public wrapper for _checkRestrictions — checks if file passes a set of restrictions.
++   * For use in UI pluigins (like Providers), to disallow selecting files that won’t pass restrictions.
+    *
+-   * @private
++   * @param {object} file object to check
++   * @returns {object} { result: true/false, reason: why file didn’t pass restrictions }
+    */
+-  _checkMinNumberOfFiles (files) {
+-    const { minNumberOfFiles } = this.opts.restrictions
+-    if (Object.keys(files).length < minNumberOfFiles) {
+-      throw new RestrictionError(`${this.i18n('youHaveToAtLeastSelectX', { smart_count: minNumberOfFiles })}`)
++  passesRestrictions (file) {
++    console.log(file)",Forgotten `console.log`,2020-10-28 20:52:58
+930,"@@ -43,6 +44,7 @@
+     ScreenCapture: document.querySelector('#opts-ScreenCapture'),
+     GoogleDrive: document.querySelector('#opts-GoogleDrive'),
+     Dropbox: document.querySelector('#opts-Dropbox'),
++    Box: document.querySelector('#opts-Box'),","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:13:31
+946,"@@ -430,11 +447,23 @@ module.exports = class ProviderView {
+     }
+   }
+ 
+-  listAllFiles (path, files = null) {
++  listAllFiles (path, files = null, meta = undefined) {
+     files = files || []
+     return new Promise((resolve, reject) => {
+       this.provider.list(path).then((res) => {","This `res` is where we'd need `currentFolderName`. Currently, if `moreFiles === true`, this implementation won't reproduce the correct parent's folder names for **Google Drive** and **OneDrive** since their IDs are unique, hashed strings instead of folder names (IMHO, Dropbox took the cleverest approach here).
+
+FWIW, the `relativePath` in the `data` object is giving `/{fileId}`; and this is the reason that the above statement is relevant.
+
+Read more at https://github.com/transloadit/uppy/pull/2605#issuecomment-729799907.",2020-11-18 16:49:58
+945,"@@ -430,11 +447,23 @@ module.exports = class ProviderView {
+     }
+   }
+ 
+-  listAllFiles (path, files = null) {
++  listAllFiles (path, files = null, meta = undefined) {
+     files = files || []
+     return new Promise((resolve, reject) => {
+       this.provider.list(path).then((res) => {
++        let itemsRelativePath
++
++        if (meta) {","My idea on having this condition here is that if there's a meta, then there's a `previousRelativePath` and a `currentFolder`. That's why I skipped checking those individual properties.",2020-11-18 16:41:33
+585,"@@ -434,15 +455,8 @@ class Uppy {
+   addFile (file) {
+     const { files, allowNewUpload } = this.getState()
+ 
+-    const onError = (msg) => {
+-      const err = typeof msg === 'object' ? msg : new Error(msg)
+-      this.log(err.message)
+-      this.info(err.message, 'error', 5000)
+-      throw err
+-    }
+-
+     if (allowNewUpload === false) {
+-      onError(new Error('Cannot add new files: already uploading.'))
++      this._showOrLogErrorAndThrow(new RestrictionError('Cannot add new files: already uploading.'))","Should we emit `this.emit('restriction-failed', null, err)` on every RestrictionError, like we do in `upload()`?",2019-08-23 23:22:29
+79,"@@ -44,45 +44,45 @@ module.exports = class Informer extends Plugin {
+     this.render = this.render.bind(this)
+   }
+ 
+-  showInformer (msg, type, duration) {
+-    this.core.setState({
+-      informer: {
+-        isHidden: false,
+-        type: type,
+-        msg: msg
+-      }
+-    })
++  // showInformer (msg, type, duration) {
++  //   this.core.setState({
++  //     informer: {
++  //       isHidden: false,
++  //       type: type,
++  //       msg: msg
++  //     }
++  //   })
+ 
+-    window.clearTimeout(this.timeoutID)
+-    if (duration === 0) {
+-      this.timeoutID = undefined
+-      return
+-    }
++  //   window.clearTimeout(this.timeoutID)
++  //   if (duration === 0) {
++  //     this.timeoutID = undefined
++  //     return
++  //   }
+ 
+-    // hide the informer after `duration` milliseconds
+-    this.timeoutID = setTimeout(() => {
+-      const newInformer = Object.assign({}, this.core.getState().informer, {
+-        isHidden: true
+-      })
+-      this.core.setState({
+-        informer: newInformer
+-      })
+-    }, duration)
+-  }
++  //   // hide the informer after `duration` milliseconds
++  //   this.timeoutID = setTimeout(() => {
++  //     const newInformer = Object.assign({}, this.core.getState().informer, {
++  //       isHidden: true
++  //     })
++  //     this.core.setState({
++  //       informer: newInformer
++  //     })
++  //   }, duration)
++  // }
+ 
+-  hideInformer () {
+-    const newInformer = Object.assign({}, this.core.getState().informer, {
+-      isHidden: true
+-    })
+-    this.core.setState({
+-      informer: newInformer
+-    })
+-  }
++  // hideInformer () {
++  //   const newInformer = Object.assign({}, this.core.getState().informer, {
++  //     isHidden: true
++  //   })
++  //   this.core.setState({
++  //     informer: newInformer
++  //   })
++  // }",Could remove all the commented out stuff here :),2017-07-25 13:28:48
+676,"@@ -44,9 +44,12 @@ module.exports = class Client {
+       body: data
+     }).then((response) => response.json()).then((assembly) => {
+       if (assembly.error) {
+-        const error = new Error(assembly.error)
++        const error = new Error(assembly)
+         error.message = assembly.error","hmm, I think we can just do `new Error(assembly.error)` and that should set `error.message` correctly too. I don't know why it was done this way with a separate `.message` assignment before :sweat_smile: 
+
+Should we do `error.assembly = assembly` so the template editor can access it that way, rather than parsing `error.details`?",2020-02-10 10:20:37
+666,"@@ -44,9 +44,9 @@ module.exports = class Client {
+       body: data
+     }).then((response) => response.json()).then((assembly) => {
+       if (assembly.error) {
+-        const error = new Error(assembly.error)
++        const error = new Error(assembly)
+         error.message = assembly.error
+-        error.details = assembly.reason
++        error.details = `${assembly.message} Assembly ID: ${assembly.assembly_id}`","@Acconut Marius, I added `assembly_id`, not sure how to best include all of the error response in Uppy’s error message, as you proposed in https://github.com/transloadit/uppy/issues/2000. Maybe you’ve got suggestions? :)",2020-01-07 16:50:01
+238,"@@ -446,20 +446,15 @@ class Uppy {
+   }
+ 
+   pauseResume (fileID) {
+-    const updatedFiles = Object.assign({}, this.getState().files)
+-
+-    if (updatedFiles[fileID].uploadComplete) return
++    if (this.getFile(fileID).uploadComplete) return
+ 
+-    const wasPaused = updatedFiles[fileID].isPaused || false
++    const wasPaused = this.getFile(fileID).isPaused || false
+     const isPaused = !wasPaused
+ 
+-    const updatedFile = Object.assign({}, updatedFiles[fileID], {
++    this.setFileState(fileID, {
+       isPaused: isPaused
+     })
+ 
+-    updatedFiles[fileID] = updatedFile
+-    this.setState({files: updatedFiles})
+-
+     this.emit('upload-pause', fileID, isPaused)",:clap: ,2018-03-12 12:01:45
+356,"@@ -446,6 +446,10 @@ this.info({
+ 
+ Subscribe to an uppy-event. See below for the full list of events.
+ 
++### `uppy.off('event', action)`
++
++Unsubscribe to an uppy-event. See below for the full list of events.
++",Minor neat-pick: “unsubscribe from?”,2018-09-26 21:09:27
+579,"@@ -448,11 +448,18 @@ module.exports = class Tus extends Plugin {
+ 
+   handleUpload (fileIDs) {
+     if (fileIDs.length === 0) {
+-      this.uppy.log('Tus: no files to upload!')
++      this.uppy.log('[Tus] No files to upload')
+       return Promise.resolve()
+     }
+ 
+-    this.uppy.log('Tus is uploading...')
++    if (fileIDs.length > 10 && this.opts.limit === 0) {",Shall we always throw this warning if a limit wasnt set?,2019-08-21 16:49:55
+846,"@@ -448,6 +463,36 @@ The class must also have an `authProvider` string (lowercased) field which typic
+ }
+ ```
+ 
++## Migrating v1 to v2
++
++### Prerequisite
++
++Since v2, you now need to be running `node.js > v10.0.0` to use Companion.",Should this be `>= v10.0.0`?,2020-07-16 06:54:55
+878,"@@ -448,6 +463,36 @@ The class must also have an `authProvider` string (lowercased) field which typic
+ }
+ ```
+ 
++## Migrating v1 to v2
++
++### Prerequisite
++
++Since v2, you now need to be running `node.js >= v10.0.0` to use Companion.","```suggestion
+Since v2, you now need to be running `node.js >= v10.20.1` to use Companion.
+```",2020-09-07 09:38:25
+289,"@@ -448,7 +448,7 @@ class Uppy {
+       this.scheduledAutoProceed = setTimeout(() => {
+         this.scheduledAutoProceed = null
+         this.upload().catch((err) => {
+-          console.error(err.stack || err.message || err)
++          onError(err.stack || err.message || err)","`upload()` already logs an error and shows the informer, so we don't need to use `onError` here. (`console.error` is probably not that necessary either)",2018-05-31 10:21:00
+759,"@@ -449,7 +449,6 @@ class Uploader {
+       uploadUrl: this.options.uploadUrl,
+       // @ts-ignore
+       uploadLengthDeferred: false,
+-      resume: true,",The `resume` option did not have any effect when used inside Node.js without specifying the `urlStorage` parameter as well. So this can be removed.,2020-05-03 15:45:45
+90,"@@ -45,3 +45,356 @@
+     line-height: 40px;
+   }
+ }
++
++.UppyInformer span {
++  line-height: 12px;
++  width: 13px;
++  height: 13px;
++  display: inline-block;
++  vertical-align: middle;
++  background-color: $color-white;
++  border-radius: 50%;
++  position: relative;
++  top: -1px;
++  left: 5px;
++  font-size: 10px;
++  margin-left: -1px;
++}
++
++.UppyInformer span:after {
++  line-height: 1.3;
++  word-wrap: break-word;
++}
++
++// balloon
++// https://kazzkiq.github.io/balloon.css/","Minor, but perhaps this could be in a separate file?",2017-08-28 08:01:25
+297,"@@ -455,7 +455,7 @@ module.exports = class ProviderView {
+     const handleToken = (e) => {
+       const allowedOrigin = new RegExp(noProtocol(this.plugin.opts.hostPattern))
+       if (!allowedOrigin.test(noProtocol(e.origin)) || e.source !== authWindow) {
+-        console.log(`rejecting event from ${e.origin} vs allowed pattern ${this.plugin.opts.hostPattern}`)
++        this.plugin.uppy.log(`rejecting event from ${e.origin} vs allowed pattern ${this.plugin.opts.hostPattern}`)",:+1: ,2018-06-11 09:09:05
+671,"@@ -455,8 +457,9 @@ class Uploader {
+         }
+       }
+     )
++    const httpMethod = (this.options.httpMethod || '').toLowerCase() === 'put' ? 'put' : 'post'",nice :+1: ,2020-02-03 10:09:34
+135,"@@ -457,6 +451,15 @@ module.exports = class Transloadit extends Plugin {
+         onAssemblyError(assembly, error)
+       }
+ 
++      const checkAllComplete = () => {","Moved this check from `onAssemblyFinished` into here, so we don't reject the entire upload anymore if an assembly fails. Instead, the files belonging to that assembly are added to the `{ failed }` result array.",2017-11-10 16:14:57
+366,"@@ -458,7 +459,12 @@ module.exports = class Dashboard extends Plugin {
+     this.uppy.on('plugin-remove', this.removeTarget)
+     this.uppy.on('file-added', (ev) => {
+       this.toggleAddFilesPanel(false)
+-      this.hideAllPanels()
++    })
++    this.uppy.on('complete', ({ failed, uploadID }) => {
++      if (this.opts.closeAfterFinish && failed.length === 0) {
++        // All uploads are done
++        this.requestCloseModal()
++      }",Should this event listener be removed `.off` in `uninstall` too?,2018-10-15 15:49:40
+475,"@@ -458,8 +458,8 @@ module.exports = class ProviderView {
+ 
+     const patterns = Array.isArray(allowedOrigin) ? allowedOrigin.map(getRegex) : [getRegex(allowedOrigin)]
+     return patterns
+-      .filter((pattern) => pattern !== null)
+-      .some((pattern) => pattern.test(origin))
++      .filter((pattern) => pattern != null) // loose comparison to catch undefined","I wonder if it’s better to explicitly check for `undefined` for readability. But with your comment this works, just thinking out loud.",2019-05-23 12:23:36
+10,"@@ -46,12 +40,18 @@ export default class Tus10 extends Plugin {
+           percentage = Math.round(percentage)
+ 
+           // Dispatch progress event
+-          this.core.emitter.emit('progress', {
+-            plugin: this,
+-            percentage: percentage
++          this.core.emitter.emit('upload-progress', {","We could potentially destructure `emitter` and `log` from `this.core` if we have to call them a bunch, but it may be better to be explicit about using `this.core.emitter`, etc.
+
+For instance:
+
+`const { emitter, log } = this.core`
+",2016-04-04 15:53:58
+128,"@@ -46,14 +46,44 @@ module.exports = {
+   Dropbox,
+   Instagram,
+   FileInput,
+-  Tus10,
++  Tus,
+   XHRUpload,
+   Transloadit,
+   AwsS3,
+   Dashboard,
+   MetaData,
+   Webcam,
+-  RestoreFiles,
++  GoldenRetriever,
+   ReduxDevTools,
+   ReduxStore
+ }
++
++Object.defineProperty(module.exports, 'RestoreFiles', {
++  enumerable: true,
++  configurable: true,
++  get: () => {
++    console.warn('Uppy.RestoreFiles is deprecated and will be removed in v0.22. Use Uppy.GoldenRetriever instead.')
++    Object.defineProperty(module.exports, 'RestoreFiles', {
++      enumerable: true,
++      configurable: true,
++      writable: true,
++      value: GoldenRetriever
++    })
++    return GoldenRetriever
++  }
++})
++
++Object.defineProperty(module.exports, 'Tus10', {
++  enumerable: true,
++  configurable: true,
++  get: () => {
++    console.warn('Uppy.Tus10 is deprecated and will be removed in v0.22. Use Uppy.Tus instead.')
++    Object.defineProperty(module.exports, 'Tus10', {
++      enumerable: true,
++      configurable: true,
++      writable: true,
++      value: Tus
++    })
++    return Tus
++  }
++})",Wow! 😎 ,2017-10-17 16:16:51
+787,"@@ -46,19 +50,28 @@ class AddFiles extends Component {
+     )
+   }
+ 
+-  renderHiddenFileInput = () => {
++  renderCloudIcon = () => {
++    return (
++      <svg class=""uppy-Dashboard-dropFilesIcon"" aria-hidden=""true"" width=""64"" height=""45"" viewBox=""0 0 64 45"" xmlns=""http://www.w3.org/2000/svg"">
++        <path d=""M38 44.932V31h8L33 15 20 31h8v13.932H13.538C6.075 44.932 0 38.774 0 31.202c0-6.1 4.06-11.512 9.873-13.162l.005-.017c.345-5.8 5.248-10.534 10.922-10.534.502 0 1.164.017 1.868.16C25.9 2.85 31.225 0 36.923 0c9.5 0 17.23 7.838 17.23 17.473l-.011.565.012.002C60.039 19.685 64 24.975 64 31.203c0 7.57-6.075 13.729-13.538 13.729H38z"" fill=""#E2E2E2"" fill-rule=""nonzero"" />
++      </svg>
++    )
++  }
++
++  renderHiddenInput = (isFolder, refName) => {
+     return (
+       <input
+         class=""uppy-Dashboard-input""
+         hidden
+         aria-hidden=""true""
+         tabindex={-1}
++        webkitdirectory={isFolder}
+         type=""file""
+         name=""files[]""
+         multiple={this.props.maxNumberOfFiles !== 1}
+         onchange={this.onFileInputChange}
+         accept={this.props.allowedFileTypes}
+-        ref={(ref) => { this.fileInput = ref }}
++        ref={(ref) => { this[refName] = ref }}","I wonder if this entire `ref` function should be passed in as a parameter to `renderHiddenInput`, just like the `onClickFn` in `renderBrowseButton()`? I'm a bit uneasy about using `this[someDynamicValue]`, even though it's technically not wrong :)
+
+(this is not a blocker, feel free to ignore this suggestion if you disagree)",2020-06-24 11:30:36
+57,"@@ -46,6 +46,36 @@ function getUploadingState (props, files) {
+   return state
+ }
+ 
++function calculateProcessingProgress (files) {
++  // Collect pre or postprocessing progress states.
++  const progresses = []
++  Object.keys(files).forEach((fileID) => {
++    const { progress } = files[fileID]
++    if (progress.preprocess) {
++      progresses.push(progress.preprocess)
++    }
++    if (progress.postprocess) {
++      progresses.push(progress.postprocess)
++    }
++  })
++
++  // In the future we should probably do this differently. For now we'll take the
++  // mode and message from the first file…
++  const { mode, message } = progresses[0]
++  const value = progresses.filter(isDeterminate).reduce((total, progress, index, all) => {
++    return total + progress.value / all.length
++  }, 0)
++  function isDeterminate (progress) {
++    return progress.mode === 'determinate'
++  }
++
++  return {
++    mode,
++    message,
++    value
++  }","This function was moved here from `ProgressBarProcessing`, no changes otherwise.",2017-06-23 13:15:36
+331,"@@ -46,7 +46,7 @@ spec:
+                 - companion
+             topologyKey: kubernetes.io/hostname    
+       containers:
+-      - image: docker.io/transloadit/companion:latest
++      - image: docker.io/kiloreux/uppy-companion:latest",Should be transloadit,2018-08-17 05:11:41
+184,"@@ -46,7 +46,8 @@ module.exports = class StatusBar extends Plugin {
+       target: 'body',
+       hideUploadButton: false,
+       showProgressDetails: false,
+-      locale: defaultLocale
++      locale: defaultLocale,
++      hideAfterFinish: false",Would it make sense to default this to `true`?,2018-01-01 22:40:36
+124,"@@ -46,8 +46,17 @@ function getFiles (store) {
+   })
+ }
+ 
++function probe (event) {
++  sendMessageToAllClients({
++    type: 'uppy/HERE_I_AM'
++  })
++}","MDN said something about using `clients.get(event.clientId)` to only send the message back to the sender, but `clientId` was undefined for me--i guess that's why we were sending the `uppy/ALL_FILES` message to all clients too.",2017-10-02 09:44:31
+771,"@@ -464,6 +466,7 @@ module.exports = class Tus extends Plugin {
+         this.uppy.emit('upload-success', file, uploadResp)
+         this.resetUploaderReferences(file.id)
+         queuedRequest.done()","I think these should also be flipped. This is when a 'remote' upload has finished, eg. when you select files from Google Drive.",2020-05-13 11:11:58
+474,"@@ -47,15 +46,18 @@ class Uploader {
+ 
+     this.options = options
+     this.token = uuid.v4()
+-    this.options.path = `${this.options.pathPrefix}/${Uploader.FILE_NAME_PREFIX}-${this.token}`
++    this.path = `${this.options.pathPrefix}/${Uploader.FILE_NAME_PREFIX}-${this.token}`
++    this.metadata = Object.assign({}, this.options.metadata || {})
++    this.metadata.filename = this.metadata.name || path.basename(this.path)
++    this.metadata.filetype = this.metadata.type
+     this.streamsEnded = false","What about adding this `filename` and `filetype` conversion to `uploadRemote` on `@uppy/tus` client instead? Then it’s consistent — tusd expects metadata this way, it doesn’t convert `name` to `filename` for you, and so will Companion. We have that conversion for direct uploads, and we’ll do the same in the same place for remote uploads.
+
+https://github.com/transloadit/uppy/blob/master/packages/%40uppy/tus/src/index.js#L180-L184",2019-05-23 07:40:38
+3,"@@ -47,6 +47,7 @@
+     ""zuul"": ""^3.7.2""
+   },
+   ""dependencies"": {
+-    ""async"": ""^1.5.0""
++    ""async"": ""^1.5.0"",","This can be removed I think then?
+",2015-12-07 14:12:01
+900,"@@ -47,7 +47,7 @@ class Zoom extends Provider {
+         }
+ 
+         if (!from && !to && !meetingId) {
+-          const end = cursor && moment.utc(cursor).endOf('day').tz(userResponse.timezone || 'UTC')
++          const end = cursor && moment.utc(cursor).endOf('day').tz(userBody.timezone || 'UTC')","caught a bug while testing. `userResponse` is a response object, not body",2020-10-19 07:41:49
+953,"@@ -47,7 +48,8 @@ module.exports.addToCookies = (res, token, companionOptions, providerName) => {
+ /**
+  *
+  * @param {object} res
+- * @param {object=} companionOptions
++ * @param {object} companionOptions
++ * @param {string=} companionOptions.cookieDomain","```suggestion
+```",2020-11-23 07:26:56
+868,"@@ -471,54 +472,59 @@ class Uploader {
+     const headers = headerSanitize(this.options.headers)
+     const reqOptions = { url: this.options.endpoint, headers, encoding: null }
+     if (this.options.useFormData) {
+-      reqOptions.formData = Object.assign(
+-        {},
+-        this.options.metadata,
+-        {
+-          [this.options.fieldname]: {
+-            value: file,
+-            options: {
+-              filename: this.uploadFileName,
+-              contentType: this.options.metadata.type
+-            }
+-          }
++      const form = new FormData()
++      for (const property in this.options.metadata) {
++        form.append(property, this.options.metadata[property])
++      }
++      form.append('file', file)","the original code adds a filename and fieldname if they exist so I think we should be doing something like this:
+
+```suggestion
+      form.append(this.options.fieldname, file, {
+        filename: this.uploadFileName,
+        contentType: this.options.metadata.type
+      })
+```",2020-08-21 11:32:30
+870,"@@ -471,54 +472,59 @@ class Uploader {
+     const headers = headerSanitize(this.options.headers)
+     const reqOptions = { url: this.options.endpoint, headers, encoding: null }
+     if (this.options.useFormData) {
+-      reqOptions.formData = Object.assign(
+-        {},
+-        this.options.metadata,
+-        {
+-          [this.options.fieldname]: {
+-            value: file,
+-            options: {
+-              filename: this.uploadFileName,
+-              contentType: this.options.metadata.type
+-            }
+-          }
++      const form = new FormData()
++      for (const property in this.options.metadata) {
++        form.append(property, this.options.metadata[property])
++      }
++      form.append('file', file)
++      form.getLength((error, length) => {
++        if (error) {
++          logger.error(error, 'upload.multipart.error')","```suggestion
+          logger.error(error, 'upload.multipart.size.error')
+          this.emitError(error)
+          return
+```",2020-08-21 12:48:27
+869,"@@ -471,54 +472,59 @@ class Uploader {
+     const headers = headerSanitize(this.options.headers)
+     const reqOptions = { url: this.options.endpoint, headers, encoding: null }
+     if (this.options.useFormData) {
+-      reqOptions.formData = Object.assign(
+-        {},
+-        this.options.metadata,
+-        {
+-          [this.options.fieldname]: {
+-            value: file,
+-            options: {
+-              filename: this.uploadFileName,
+-              contentType: this.options.metadata.type
+-            }
+-          }
++      const form = new FormData()
++      for (const property in this.options.metadata) {
++        form.append(property, this.options.metadata[property])
++      }
++      form.append('file', file)
++      form.getLength((error, length) => {
++        if (error) {
++          logger.error(error, 'upload.multipart.error')
+         }
+-      )
++        reqOptions.headers['content-length'] = length
++        const req = request[httpMethod](reqOptions, (error, response, body) => this._handleUploadMultipart(error, response, body, bytesUploaded))
++        // @ts-ignore
++        req._form = form
++      })
+     } else {
++      const stats = fs.statSync(this.path)
++      const fileSizeInBytes = stats.size
++      reqOptions.headers['content-length'] = fileSizeInBytes","based on [this comment](https://github.com/transloadit/uppy/pull/2387#issuecomment-678238507), I don't think we need to do anything for the case where `this.options.useFormData` is `false`",2020-08-21 12:17:44
+871,"@@ -471,54 +472,59 @@ class Uploader {
+     const headers = headerSanitize(this.options.headers)
+     const reqOptions = { url: this.options.endpoint, headers, encoding: null }
+     if (this.options.useFormData) {
+-      reqOptions.formData = Object.assign(
+-        {},
+-        this.options.metadata,
+-        {
+-          [this.options.fieldname]: {
+-            value: file,
+-            options: {
+-              filename: this.uploadFileName,
+-              contentType: this.options.metadata.type
+-            }
+-          }
++      const form = new FormData()
++      for (const property in this.options.metadata) {
++        form.append(property, this.options.metadata[property])
++      }
++      form.append('file', file)
++      form.getLength((error, length) => {
++        if (error) {
++          logger.error(error, 'upload.multipart.error')
+         }
+-      )
++        reqOptions.headers['content-length'] = length
++        const req = request[httpMethod](reqOptions, (error, response, body) => this._handleUploadMultipart(error, response, body, bytesUploaded))
++        // @ts-ignore
++        req._form = form
++      })
+     } else {
++      const stats = fs.statSync(this.path)
++      const fileSizeInBytes = stats.size
++      reqOptions.headers['content-length'] = fileSizeInBytes
+       reqOptions.body = file
++      request[httpMethod](reqOptions, (error, response, body) => this._handleUploadMultipart(error, response, body, bytesUploaded))
+     }
++  }
+ 
+-    request[httpMethod](reqOptions, (error, response, body) => {
+-      if (error) {
+-        logger.error(error, 'upload.multipart.error')
+-        this.emitError(error)
+-        return
+-      }
+-      const headers = response.headers
+-      // remove browser forbidden headers
+-      delete headers['set-cookie']
+-      delete headers['set-cookie2']
+-
+-      const respObj = {
+-        responseText: body.toString(),
+-        status: response.statusCode,
+-        statusText: response.statusMessage,
+-        headers
+-      }
++  _handleUploadMultipart (error, response, body, bytesUploaded) {",should we rename this to `_onMultipartComplete` or something similar?,2020-08-21 12:55:04
+872,"@@ -471,54 +472,64 @@ class Uploader {
+     const headers = headerSanitize(this.options.headers)
+     const reqOptions = { url: this.options.endpoint, headers, encoding: null }
+     if (this.options.useFormData) {
+-      reqOptions.formData = Object.assign(
+-        {},
+-        this.options.metadata,
+-        {
+-          [this.options.fieldname]: {
+-            value: file,
+-            options: {
+-              filename: this.uploadFileName,
+-              contentType: this.options.metadata.type
+-            }
+-          }
++      const form = new FormData()
++      for (const property in this.options.metadata) {
++        form.append(property, this.options.metadata[property])
++      }
++      form.append(this.options.fieldname, file, {
++        filename: this.uploadFileName,
++        contentType: this.options.metadata.type
++      })
++      form.getLength((error, length) => {
++        if (error) {
++          logger.error(error, 'upload.multipart.size.error')
++          this.emitError(error)
++          return
+         }
+-      )
++        reqOptions.headers['content-length'] = length
++        const req = request[httpMethod](reqOptions, (error, response, body) => this._onMultipartComplete(error, response, body, bytesUploaded))
++        // @ts-ignore
++        req._form = form
++      })
+     } else {
++      const stats = fs.statSync(this.path)
++      const fileSizeInBytes = stats.size
++      reqOptions.headers['content-length'] = fileSizeInBytes
+       reqOptions.body = file
++      request[httpMethod](reqOptions, (error, response, body) => this._onMultipartComplete(error, response, body, bytesUploaded))","```suggestion
+      fs.stat(this.path, (err, stats) => {
+        if (err) {
+          logger.error(err, 'upload.multipart.size.error')
+          this.emitError(err)
+          return
+        }
+
+        const fileSizeInBytes = stats.size
+        reqOptions.headers['content-length'] = fileSizeInBytes
+        reqOptions.body = file
+        request[httpMethod](reqOptions, (error, response, body) => this._onMultipartComplete(error, response, body, bytesUploaded))
+      })
+```",2020-08-28 11:18:59
+923,"@@ -471,6 +478,9 @@ class Uploader {
+     const headers = headerSanitize(this.options.headers)
+     const reqOptions = { url: this.options.endpoint, headers, encoding: null }
+     const httpRequest = request[httpMethod]
++    if (this.options.insecureUpload) {",what is this option for? 🤔 ,2020-11-11 13:27:37
+569,"@@ -472,6 +472,13 @@ class Uppy {
+ 
+     const fileID = generateFileID(file)
+ 
++    if (files[fileID]) {
++      this.info(`Not adding duplicate file '${fileName}', it already exists`, 'error', 5000)
++      this.log(`Not adding duplicate file '${fileName}', it already exists`)","Is this causing multiple log statements? If so, is it intended?",2019-08-12 15:24:47
+906,"@@ -473,6 +474,21 @@ class Uppy {
+       }
+     }
+ 
++    // We can't check maxTotalFileSize if the size is unknown.
++    if (maxTotalFileSize && file.data.size != null) {
++      let totalFilesSize = 0
++      totalFilesSize += file.size",Should we use `file.data.size` here too?,2020-10-23 10:34:06
+998,"@@ -476,7 +476,11 @@ module.exports = class Webcam extends Plugin {
+   }
+ 
+   getVideo () {
+-    const mimeType = this.recordingChunks[0].type
++    // Sometimes in iOS Safari, Blobs (especially the first Blob in the recordingChunks Array)
++    // have empty 'type' attributes (e.g. '') so we need to find a Blob that has a defined 'type'
++    // attribute in order to determine the correct MIME type.
++    const mimeType = this.recordingChunks.find(blob => blob.type?.length > 0).type",is it safe for us to use the `blob.type?.length` optional chaining with IE11 support? @goto-bus-stop ,2021-04-08 20:11:24
+133,"@@ -477,7 +477,7 @@ class Uppy {
+   retryAll () {
+     const updatedFiles = Object.assign({}, this.getState().files)
+     const filesToRetry = Object.keys(updatedFiles).filter(file => {
+-      return updatedFiles[file].error
++      return updatedFiles[file].error.message","Should we be checking if `error.message` exists first? What if string is returned from somewhere? Though I think we have an Eslint rule for that now, an extra check would not be too bad?",2017-11-02 03:08:09
+633,"@@ -48,6 +48,10 @@ matrix:
+       env: COMPANION=true
+       addons:
+         apt: *APT
++    - node_js: 6
++      env: COMPANION_NODE6=true","We can just reuse the `COMPANION=true` env var again here, I think, similarly to how we have 2 jobs for `UNIT=true` (one on stable node and one on node 10)",2019-11-23 12:13:38
+852,"@@ -480,6 +483,16 @@ class Uppy {
+         }))
+       }
+     }
++
++    // We can't check minFileSize if the size is unknown.
++    if (minFileSize && file.data.size != null) {
++      if (file.data.size < minFileSize) {
++        throw new RestrictionError(this.i18n('inferiorSize2', {
++          backwardsCompat: this.i18n('inferiorSize'),
++          size: prettierBytes(minFileSize)
++        }))","```suggestion
+        throw new RestrictionError(this.i18n('inferiorSize', {
+          size: prettierBytes(minFileSize)
+        }))
+```",2020-07-27 10:56:57
+492,"@@ -480,7 +480,8 @@ class Uploader {
+       if (error) {
+         this.emitError(error)
+       } else {
+-        this.emitSuccess(null, {
++        const url = data && data.Location ? data.Location : null;","```suggestion
+        const url = data && data.Location ? data.Location : null
+```",2019-05-30 08:18:35
+129,"@@ -486,16 +483,36 @@ class Uppy {
+       })
+       updatedFiles[file] = updatedFile
+     })
+-    this.setState({files: updatedFiles})
++    this.setState({
++      files: updatedFiles,
++      error: null
++    })
+ 
+     this.emit('core:retry-all', filesToRetry)
++
++    const uploadID = this.createUpload(filesToRetry)
++    return this.runUpload(uploadID)
++  }
++
++  retryUpload (fileID) {
++    const updatedFiles = Object.assign({}, this.state.files)
++    const updatedFile = Object.assign({}, updatedFiles[fileID],
++      { error: null, isPaused: false }
++    )
++    updatedFiles[fileID] = updatedFile
++    this.setState({
++      files: updatedFiles
++    })
++
++    this.emit('core:upload-retry', fileID)
++
++    const uploadID = this.createUpload([ fileID ])
++    return this.runUpload(uploadID)
+   }
+ 
+   reset () {
+     this.cancelAll()
+     // this.pauseAll()",we might as well delete this one too 😄 ,2017-10-17 19:06:33
+164,"@@ -486,6 +707,9 @@ module.exports = class Transloadit extends Plugin {
+       this.uppy.on('upload-success', this.onFileUploadURLAvailable)
+     }
+ 
++    this.uppy.on('restore:get-data', this.getPersistentData)
++    this.uppy.on('restored', this.onRestored)
++",So will `restore:` here a goldenretriever-specific event and `restored` a global one?,2017-12-12 03:28:14
+720,"@@ -49,24 +49,35 @@ class FileCard extends Component {
+ 
+   renderMetaFields = () => {
+     const metaFields = this.props.metaFields || []
++    const fieldCSSClasses = {
++      text: 'uppy-u-reset uppy-c-textInput uppy-Dashboard-FileCard-input'
++    }
+ 
+     return metaFields.map((field) => {
+       const id = `uppy-Dashboard-FileCard-input-${field.id}`
+       return (
+         <fieldset key={field.id} class=""uppy-Dashboard-FileCard-fieldset"">
+           <label class=""uppy-Dashboard-FileCard-label"" for={id}>{field.name}</label>
+-          <input
+-            class=""uppy-u-reset uppy-c-textInput uppy-Dashboard-FileCard-input""
+-            id={id}
+-            type=""text""
+-            value={this.state.formState[field.id]}
+-            placeholder={field.placeholder}
+-            onkeyup={this.saveOnEnter}
+-            onkeydown={this.saveOnEnter}
+-            onkeypress={this.saveOnEnter}
+-            oninput={ev => this.tempStoreMeta(ev, field.id)}
+-            data-uppy-super-focusable
+-          />
++          {field.render !== undefined
++            ? field.render({
++              value: this.state.formState[field.id],
++              onChange: (newVal) => this.updateMeta(newVal, field.id),
++              fieldCSSClasses: fieldCSSClasses
++            }, h)
++            : (
++              <input
++                class={inputCSSClasses.text}","```suggestion
+                class={fieldCSSClasses.text}
+```",2020-03-30 10:43:12
+853,"@@ -49,6 +49,10 @@ Set rules and conditions to limit the type and/or number of files that can be se
+ 
+ Maximum file size in bytes for each individual file.
+ 
++### `restrictions.minFileSize`
++
++Minimun file size in bytes for each individual file.","Little typo 😇 
+```suggestion
+Minimum file size in bytes for each individual file.
+```",2020-07-27 10:58:23
+597,"@@ -49,6 +49,7 @@ class Uppy {
+         youCanOnlyUploadFileTypes: 'You can only upload: %{types}',
+         companionError: 'Connection with Companion failed',
+         companionAuthError: 'Authorization required',
++        companionUnauthorizeHint: 'To unauthorize to your %{provider} account, please go to %{url}',","The link is not clickable and users won't be able to copy it before the bubble disappears, so I'm not sure if this is super useful. Maybe we could make it say something like ""You can now remove the authorization in %{provider}'s settings panel""? Would be nice to actually link to the page but that would require some changes in the info bubbles...",2019-09-23 11:33:47
+123,"@@ -49,62 +49,21 @@ module.exports = class Tus10 extends Plugin {
+ 
+     this.handlePauseAll = this.handlePauseAll.bind(this)
+     this.handleResumeAll = this.handleResumeAll.bind(this)
++    this.handleRetryAll = this.handleRetryAll.bind(this)
+     this.handleResetProgress = this.handleResetProgress.bind(this)
+     this.handleUpload = this.handleUpload.bind(this)
+   }
+ 
+-  pauseResume (action, fileID) {
+-    const updatedFiles = Object.assign({}, this.core.getState().files)
+-    const inProgressUpdatedFiles = Object.keys(updatedFiles).filter((file) => {
+-      return !updatedFiles[file].progress.uploadComplete &&
+-             updatedFiles[file].progress.uploadStarted
+-    })
+-
+-    switch (action) {
+-      case 'toggle':
+-        if (updatedFiles[fileID].uploadComplete) return
+-
+-        const wasPaused = updatedFiles[fileID].isPaused || false
+-        const isPaused = !wasPaused
+-        let updatedFile
+-        if (wasPaused) {
+-          updatedFile = Object.assign({}, updatedFiles[fileID], {
+-            isPaused: false
+-          })
+-        } else {
+-          updatedFile = Object.assign({}, updatedFiles[fileID], {
+-            isPaused: true
+-          })
+-        }
+-        updatedFiles[fileID] = updatedFile
+-        this.core.setState({files: updatedFiles})
+-        return isPaused
+-      case 'pauseAll':
+-        inProgressUpdatedFiles.forEach((file) => {
+-          const updatedFile = Object.assign({}, updatedFiles[file], {
+-            isPaused: true
+-          })
+-          updatedFiles[file] = updatedFile
+-        })
+-        this.core.setState({files: updatedFiles})
+-        return
+-      case 'resumeAll':
+-        inProgressUpdatedFiles.forEach((file) => {
+-          const updatedFile = Object.assign({}, updatedFiles[file], {
+-            isPaused: false
+-          })
+-          updatedFiles[file] = updatedFile
+-        })
+-        this.core.setState({files: updatedFiles})
+-    }
+-  }
+-
+   handlePauseAll () {
+-    this.pauseResume('pauseAll')
++    this.core.pauseResume('pauseAll')
+   }
+ 
+   handleResumeAll () {
+-    this.pauseResume('resumeAll')
++    this.core.pauseResume('resumeAll')
++  }
++
++  handleRetryAll () {
++    this.core.pauseResume('retryAll')
+   }",I guess these pause-all/resume-all/retry-all event handlers could also be moved to core,2017-10-02 09:05:48
+257,"@@ -49,7 +49,8 @@ class Tabs extends Component {
+             tabindex=""-1""
+             type=""file""
+             name=""files[]""
+-            multiple=""true""
++            multiple={this.props.maxNumberOfFiles !== 1 || !this.props.maxNumberOfFiles}",same here,2018-05-09 15:51:47
+709,"@@ -492,18 +502,25 @@ class Uploader {
+     })
+   }
+ 
+-  /**
+-   * Upload the file to S3 while it is still being downloaded.
+-   */
+-  uploadS3Multipart () {
++  beginTailReadStream () {
+     const file = createTailReadStream(this.path, {",we are dropping the use of tail read stream as seen [here](https://github.com/transloadit/uppy/pull/2114). So maybe we should as well do without in this PR?,2020-03-11 18:17:36
+156,"@@ -492,7 +492,7 @@ function _emitSocketProgress (uploader, progressData, file) {
+   const {progress, bytesUploaded, bytesTotal} = progressData
+   if (progress) {
+     uploader.core.log(`Upload progress: ${progress}`)",I think these `uploader.core` references also need to be changed to `.uppy`,2017-12-09 16:09:47
+592,"@@ -496,6 +494,25 @@ module.exports = class ProviderView {
+     }
+   }
+ 
++  listAllFiles (path, files = null) {
++    files = files || []
++    return new Promise((resolve) => {
++      this.provider.list(path).then((res) => {",should we add a `catch` for this call. Otherwise what will happen when the call to `this.provider.list` fails?,2019-08-29 19:09:35
+593,"@@ -496,6 +494,25 @@ module.exports = class ProviderView {
+     }
+   }
+ 
++  listAllFiles (path, files = null) {
++    files = files || []
++    return new Promise((resolve) => {
++      this.provider.list(path).then((res) => {
++        res.items.forEach((item) => {
++          if (!item.isFolder) {
++            files.push(item)
++          }
++        })
++        let moreFiles = res.nextPagePath || null
++        if (moreFiles) {
++          return this.listAllFiles(moreFiles, files).then((files) => resolve(files))",do we need to add a `catch` here too? 🤔 ,2019-08-29 19:39:24
+271,"@@ -498,7 +498,7 @@ module.exports = class ProviderView {
+       }
+ 
+       // split url because chrome adds '#' to redirects
+-      if (authWindowUrl && authWindowUrl.split('#')[0] === redirect) {
++      if (authWindowUrl && (authWindowUrl === redirect || authWindowUrl.split('#')[0] === redirect)) {","Hi, what scenario does this solve? Testing in chrome, the current implementation already covers for both scenarios. 
+
+```js
+""yahoo.com?redherring=3894"".split('#')
+[""yahoo.com?redherring=3894""]
+""yahoo.com?redherring=3894#"".split('#')
+(2) [""yahoo.com?redherring=3894"", """"]
+```
+
+Or does `.split` behave differently in other browsers?
+",2018-05-15 15:17:59
+456,"@@ -5,10 +5,10 @@ about: Do you need assistance with building the Uppy client in your bundler, or
+ labels: Not Accepted
+ ---
+ 
+-Transloadit is providing Uppy free of charge. If you want you can self-host all components and never pay us a dime. There's docs and tests and your Bug Reports and Feature Requests are always welcome on GitHub. 
++Transloadit is providing Uppy free of charge. If you want, you can self-host all of its components and never pay us a dime. There are docs and tests, and your bug reports and feature requests are always welcome on GitHub. 
+ 
+-There is also a different category of support that we'd like to call Integration Help: making things work for you, that are already reported working for the larger community.
++There is also a different category of support that we like to call Integration Help. It means that you will be taking advantage of all the knowledge already available within the Uppy community, to help you with all kinds of things that have already been reported as working.","For the three support categories: Bug Reports, Feature Requests, Integration Help, you keep uppercasing for the latter but ditch for the former 2 @AJvanLoon ?",2019-04-25 17:27:21
+644,"@@ -5,11 +5,17 @@
+  * @returns {object} {name, extension}
+  */
+ module.exports = function getFileNameAndExtension (fullFileName) {
+-  var re = /(?:\.([^.]+))?$/
+-  var fileExt = re.exec(fullFileName)[1]
+-  var fileName = fullFileName.replace('.' + fileExt, '')
+-  return {
+-    name: fileName,
+-    extension: fileExt
++  const lastDot = fullFileName.lastIndexOf('.')
++  // these count as no extension: ""no-dot"", ""trailing-dot.""
++  if (lastDot === -1 || lastDot === fullFileName.length - 1) {
++    return {
++      name: fullFileName,
++      extension: undefined","```
+declare module '@uppy/utils/lib/getFileNameAndExtension' {
+  function getFileNameAndExtension(filename: string): { name: string, extension: string };
+  export = getFileNameAndExtension
+}
+```
+
+Let's make the extension optional in types too?",2019-12-01 16:00:59
+916,"@@ -5,15 +5,43 @@ const FooterActions = require('./FooterActions')
+ const { h } = require('preact')
+ 
+ const Browser = (props) => {
+-  let filteredFolders = props.folders
+-  let filteredFiles = props.files
++  const {
++    currentSelection,
++    folders,
++    files,
++    uppyFiles,
++    filterItems,
++    filterInput,
++    maxNumberOfFiles,
++    maxTotalFileSize
++  } = props
+ 
+-  if (props.filterInput !== '') {
+-    filteredFolders = props.filterItems(props.folders)
+-    filteredFiles = props.filterItems(props.files)
++  let filteredFolders = folders
++  let filteredFiles = files
++
++  if (filterInput !== '') {
++    filteredFolders = filterItems(folders)
++    filteredFiles = filterItems(files)
++  }
++
++  const selected = currentSelection.length
++  let canSelectMore = true
++
++  if (maxNumberOfFiles && (uppyFiles.length + selected >= maxNumberOfFiles)) {
++    canSelectMore = false
+   }
+ 
+-  const selected = props.currentSelection.length
++  let totalCurrentSelectionFileSize = 0
++
++  if (currentSelection) {
++    currentSelection.forEach(file => {
++      totalCurrentSelectionFileSize += file.size
++    })
++  }
++
++  if (maxTotalFileSize && totalCurrentSelectionFileSize >= maxTotalFileSize) {",Should this be `uppyFilesSizes + totalCurrentSelectionFileSize >= maxTotalFileSize`?,2020-11-10 08:27:50
+102,"@@ -5,16 +5,18 @@ const sampleImageDataURI =
+ 
+ describe('core/utils', () => {
+   describe('generateFileID', () => {
+-    it('should take the filename object and produce a lowercase file id made up of the name and lastModified date', () => {
++    it('should take the filename object and produce a lowercase file id made up of uppy- prefix, file name (cleaned up to be lowercase, letters and numbers only), type, size and lastModified date', () => {
+       const fileObj = {
+         name: 'fOo0Fi@£$.jpg',
++        type: 'image/jpeg',
+         data: {
+-          lastModified: '2017-08-31T00:00:00.000Z'
++          lastModified: '2017-08-31T00:00:00.000Z',","Tangential nit, `lastModified` is a number in browsers. Doesn't have to be addressed in this PR but might be best for the test to mimic browser as closely as possible.",2017-09-11 07:49:19
+342,"@@ -5,7 +5,7 @@
+ <a href=""https://www.npmjs.com/package/@uppy/aws-s3""><img src=""https://img.shields.io/npm/v/@uppy/aws-s3.svg?style=flat-square""></a>
+ <a href=""https://travis-ci.org/transloadit/uppy""><img src=""https://img.shields.io/travis/transloadit/uppy/master.svg?style=flat-square"" alt=""Build Status""></a>
+ 
+-The AwsS3 plugin can be used to upload files directly to an S3 bucket. Uploads can be signed using Uppy Server or a custom signing function.
++The AwsS3 plugin can be used to upload files directly to an S3 bucket. Uploads can be signed using Companion or a custom signing function.","Elsewhere in documentation I've used ""Uppy Companion"". Would be best to pick one and use it consistently",2018-09-03 11:55:03
+576,"@@ -5,7 +5,7 @@
+ <script src=""/uppy/uppy.min.js""></script>
+ <script>
+   var uppy = Uppy.Core({debug: true});
+-  uppy.use(Uppy.Tus, {endpoint: '//master.tus.io/files/'});
++  uppy.use(Uppy.Tus, {endpoint: 'https://master.tus.io/files/'});","Question: what is `/examples/bundle/` about, we don't seem to have a link to it on a site anywhere, is it for some local testing? It works, but we need to add `{ autoProceed: true }`, and actually attach ProgressBar somewhere.",2019-08-15 18:05:53
+873,"@@ -5,8 +5,7 @@
+ const config = require('@purest/providers')
+ const dropbox = require('./dropbox')
+ const drive = require('./drive')
+-const instagram = require('./instagram')",can we delete any code in the provider implementation? i imagine the entire thing is unused now?,2020-09-02 07:00:38
+318,"@@ -50,6 +20,35 @@
+   <a href=""http://hughsk.io/disc/"">disc</a>.
+   <hr />
+ 
++  <h2 id=""bundle-sizes"">Bundle Sizes</h2>
++  <p>
++    Below are the minified and gzipped sizes for each Uppy package. Note that this includes the dependencies for each package, some of which are shared when you install multiple plugins—for example, the `@uppy/dropbox` and `@uppy/instagram` package are both over 11kB including dependencies, but only sum up to about 15kB when they are used together.
++  </p>","Markdown doesn’t work here, so maybe we could wrap package names in `<code>`?",2018-07-16 20:47:45
+515,"@@ -50,8 +56,12 @@ exports.getItemId = (item) => {
+ }
+ 
+ exports.getItemRequestPath = (item) => {
+-  // If it's from a Team Drive, add the Team Drive ID as a query param.
++  // If it's from/is a Team Drive, add the Team Drive ID as a query param.",is this a typo?,2019-06-17 08:38:14
+516,"@@ -50,8 +56,12 @@ exports.getItemId = (item) => {
+ }
+ 
+ exports.getItemRequestPath = (item) => {
+-  // If it's from a Team Drive, add the Team Drive ID as a query param.
++  // If it's from/is a Team Drive, add the Team Drive ID as a query param.
+   // The server needs the Team Drive ID to list files in a Team Drive folder.
++  if (exports.isTeamDrive(item)) {",does this mean that we can delete the `if` block that is right under this one?,2019-06-17 09:22:10
+589,"@@ -502,29 +524,48 @@ module.exports = class XHRUpload extends Plugin {
+   }
+ 
+   uploadFiles (files) {
+-    const actions = files.map((file, i) => {
++    const promises = files.map((file, i) => {
+       const current = parseInt(i, 10) + 1
+       const total = files.length
+ 
+       if (file.error) {
+         return () => Promise.reject(new Error(file.error))","#todo - we have this error in master too, this should be `return Promise.reject(new Error(file.error))` instead, otherwise we're getting `.then` is not a function on request fail&retry, with aws-s3 plugin:
+
+![image](https://user-images.githubusercontent.com/7578559/63789337-96e8a700-c910-11e9-89dc-6e82a1eb2c7c.png)
+",2019-08-27 16:22:30
+978,"@@ -502,6 +504,12 @@ module.exports = class Dashboard extends Plugin {
+     }
+   }
+ 
++  disableAllFocusableElements = (disable) => {
++    const focusableNodes = toArray(this.el.querySelectorAll(FOCUSABLE_ELEMENTS))
++    focusableNodes.forEach(node => node.setAttribute('tabindex', disable ? '-1' : '0'))","@goto-bus-stop what do you think of this? I’ve checked and we mostly have `tabindex=0` on FOCUSABLE_ELEMENTS, nothing else is used, so not worth storing the previous value before changing it to `-1`?
+
+P.S. TIL “[The maximum value for tabindex is 32767](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/tabindex)”.",2021-02-24 14:45:16
+411,"@@ -51,11 +56,14 @@ module.exports = class Provider extends RequestClient {
+   }
+ 
+   logout (redirect = location.href) {
+-    return this.get(`${this.id}/logout?redirect=${redirect}`)
+-      .then((res) => {
+-        this.uppy.getPlugin(this.pluginId).storage.removeItem(this.tokenKey)
+-        return res
+-      })
++    return new Promise((resolve, reject) => {","this promise chain can also be flattened
+
+```js
+return this.get(`${this.id}/logout?redirect=${redirect}`).then((res) => {
+  return this.uppy.getPlugin(this.pluginId).storage.removeItem(this.tokenKey)
+    .then(() => res)
+})
+```",2019-03-25 10:33:01
+152,"@@ -51,39 +50,23 @@ module.exports = {
+   Transloadit,
+   AwsS3,
+   Dashboard,
+-  MetaData,
+   Webcam,
+   GoldenRetriever,
+   ReduxDevTools,
+   ReduxStore
+ }
+ 
+-Object.defineProperty(module.exports, 'RestoreFiles', {
+-  enumerable: true,
+-  configurable: true,
+-  get: () => {
+-    console.warn('Uppy.RestoreFiles is deprecated and will be removed in v0.22. Use Uppy.GoldenRetriever instead.')
+-    Object.defineProperty(module.exports, 'RestoreFiles', {
+-      enumerable: true,
+-      configurable: true,
+-      writable: true,
+-      value: GoldenRetriever
+-    })
+-    return GoldenRetriever
+-  }
+-})
+-
+-Object.defineProperty(module.exports, 'Tus10', {
+-  enumerable: true,
+-  configurable: true,
+-  get: () => {
+-    console.warn('Uppy.Tus10 is deprecated and will be removed in v0.22. Use Uppy.Tus instead.')
+-    Object.defineProperty(module.exports, 'Tus10', {
+-      enumerable: true,
+-      configurable: true,
+-      writable: true,
+-      value: Tus
+-    })
+-    return Tus
+-  }
+-})
++// Object.defineProperty(module.exports, 'Tus10', {",lets get rid of this commented bit too,2017-12-09 16:04:03
+863,"@@ -51,7 +51,10 @@ const getConfigFromEnv = () => {
+       },
+       zoom: {
+         key: process.env.COMPANION_ZOOM_KEY,
+-        secret: getSecret('COMPANION_ZOOM_SECRET')
++        secret: getSecret('COMPANION_ZOOM_SECRET'),
++        custom: {
++          verificationToken: getSecret('COMPANION_ZOOM_VERIFICATION_TOKEN')","`verificationToken` is a required option, right? can we put it on the `zoom` options object itself instead of inside `custom`?",2020-08-17 09:00:03
+525,"@@ -51,7 +51,7 @@ module.exports = function FileProgress (props) {
+   ) {
+     return (
+       <div class=""uppy-DashboardItem-progress"">
+-        <div class=""uppy-DashboardItem-progressIndicator"">
++        <div class=""uppy-u-reset uppy-DashboardItem-progressIndicator"">","Is `uppy-u-reset` supposed to be on a div, instead of a button?",2019-06-24 16:00:34
+559,"@@ -51,8 +51,11 @@
+       };
+     }
+ 
++    // IE 10 doesn’t support console.debug
++    var consoleDebug = console.debug || console.log
++
+     console.log = customLog(console.log.bind(console), document.getElementById(""console-log""));","I guess we don’t need `console.log =` here then, because `.debug` calls `.log` when needed? But it’s a minor detail, it’s not hurting anything.",2019-08-05 12:15:51
+154,"@@ -514,44 +523,31 @@ class Uppy {
+       files: updatedFiles
+     })
+ 
+-    this.emit('core:upload-retry', fileID)
++    this.emit('upload-retry', fileID)
+ 
+     const uploadID = this.createUpload([ fileID ])
+-    return this.runUpload(uploadID)
++    return this._runUpload(uploadID)
+   }
+ 
+   reset () {
+     this.cancelAll()
+   }
+ 
+-  cancelAll () {
+-    this.emit('core:cancel-all')
+-    this.setState({ files: {}, totalProgress: 0 })
+-  }
+-
+   calculateProgress (data) {
+     const fileID = data.id",can `calculateProgress` and `calculateTotalProgress` also be private?,2017-12-09 16:06:34
+98,"@@ -516,7 +516,12 @@ function isDOMElement (obj) {
+  */
+ function findDOMElement (element) {
+   if (typeof element === 'string') {
+-    return document.querySelector(element)
++    const elements = [].slice.call(document.querySelectorAll(element))
++    if (elements.length > 1) {
++      return elements
++    }
++    return elements[0]
++    // return document.querySelector(element)",Changing this function means other cases (like a `target` option) where the selector exists more than once on the page also return an array. Maybe better to have a separate function that always returns an array?,2017-09-09 11:47:20
+267,"@@ -52,10 +52,15 @@ Optionally provide rules and conditions for which files can be selected.
+ 
+ **Parameters**
+ 
+-- `maxFileSize` *number*
+-- `maxNumberOfFiles` *number*
+-- `minNumberOfFiles` *number*
+-- `allowedFileTypes` *array* of wildcards or exact mime types, like `image/*`
++- `maxFileSize` *null | number*
++- `maxNumberOfFiles` *null | number*
++- `minNumberOfFiles` *null | number*
++- `allowedFileTypes` *null | array* of wildcards `image/*`, exact mime types `image/jpeg`, or file extensions `.jpg`: `['image/*', '.jpg', '.jpeg', '.png', '.gif']`
++
++`maxNumberOfFiles` affects the number of files user is able to select via the system file dialog in UI plugins like `DragDrop`, `FileInput` and `Dashboard`: when set to `1` they will only be able to select a single file, otherwise, when `null` or other number, they will be able to select multiple files.
++
++`allowedFileTypes` array also gets passed to the system file dialog (see [`input[type=file]` accept](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Limiting_accepted_file_types)), so user will only be able to select images, for example.","imho this is clearer when mentioning the behaviour in general instead of an example:
+
+> `allowedFileTypes` gets passed to the system file dialog via `<input>`'s [`accept` attribute](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/file#Limiting_accepted_file_types), so only files matching these types will be selectable.
+
+but feel free to ignore if you disagree, this is probably super subjective",2018-05-14 07:54:52
+889,"@@ -52,11 +52,13 @@ class Zoom extends Provider {
+         })
+     })
+ 
++    const userResponse = await userPromise
++
+     if (from && to) {
+       const queryObj = {
+         page_size: PAGE_SIZE,
+-        from,
+-        to
++        from: moment.tz(from, userResponse.body.timezone || 'UTC').startOf('day').tz('UTC').format('YYYY-MM-DD'),
++        to: moment.tz(to, userResponse.body.timezone || 'UTC').endOf('day').tz('UTC').format('YYYY-MM-DD')","example: user in Canada (EDT, (UTC -4)) clicks on a folder for a month (eg 08-01 to 08-31), they're really asking for  files for 08-01 0:00 EDT (08-01 04:00 UTC) to 08-31 23:59 EDT (09-01 03:59 UTC). 
+
+so the incoming request from/to is in local time, we convert to their timezone, set it to start/end of day, convert to UTC, and get just the date portion (because Zoom API only accepts date, not date time)
+",2020-09-11 21:08:57
+117,"@@ -52,16 +54,23 @@ module.exports = function fileItem (props) {
+                         }""
+                   onclick=${(ev) => {
+                     if (isUploaded) return
++                    if (error) {
++                      props.retryUpload(file.id)
++                      return
++                    }
+                     if (props.resumableUploads) {
+                       props.pauseUpload(file.id)
+                     } else {
+                       props.cancelUpload(file.id)
+                     }
+                   }}>","Might be good to move these largeish event handlers into a `function onclick (ev) {}` and do `onclick=${onclick}` at some point, a la
+
+```js
+function view () {
+  function onclick () {
+    alert('boo! 👻')
+  }
+  return html`<button onclick=${onclick}>click</button>`
+}
+```",2017-09-29 14:25:16
+118,"@@ -52,16 +54,23 @@ module.exports = function fileItem (props) {
+                         }""
+                   onclick=${(ev) => {
+                     if (isUploaded) return
++                    if (error) {
++                      props.retryUpload(file.id)
++                      return
++                    }
+                     if (props.resumableUploads) {
+                       props.pauseUpload(file.id)
+                     } else {
+                       props.cancelUpload(file.id)
+                     }
+                   }}>
+-            ${FileItemProgress({
+-              progress: file.progress.percentage,
+-              fileID: file.id
+-            })}
++            ${props.file.error",could this also use the `error` variable declared above?,2017-09-29 14:27:02
+306,"@@ -52,4 +52,27 @@ module.exports = class Provider extends RequestClient {
+         return res
+       })
+   }
++
++  static initPlugin (plugin, opts, defaultOpts) {","This static function serves as a place where setups common to all Provider Plugins is done. Please let me know if you have suggestions for a better place where this function can live.
+
+PS: I don't know of a different way to approach this. It's either we do it the way I'm doing it here. Or we have a class called `ProviderPlugin` which all Provider Plugins extend. Otherwise, we would continue to have repetitive code in all providers, which is hard to maintain.",2018-07-01 11:53:46
+307,"@@ -52,4 +52,27 @@ module.exports = class Provider extends RequestClient {
+         return res
+       })
+   }
++
++  static initPlugin (plugin, opts, defaultOpts) {
++    plugin.type = 'acquirer'
++    plugin.files = []
++    if (defaultOpts) {
++      plugin.opts = Object.assign({}, defaultOpts, opts)
++    }
++    if (opts.serverPattern) {
++      const pattern = opts.serverPattern
++      // validate serverPattern param
++      if (typeof pattern !== 'string' && !Array.isArray(pattern) && !(pattern instanceof RegExp)) {
++        throw new TypeError('Provider: the option `serverPattern` must be one of string, Array, RegExp')",could we use `${plugin.id}` at the start of this message instead of `Provider` so it shows if it's from GoogleDrive or Dropbox or XYZ?,2018-07-02 08:46:36
+223,"@@ -52,6 +55,20 @@ The types of recording modes to allow.
+ 
+ By default, all modes are allowed, and the Webcam plugin will show controls for recording video as well as taking pictures.
+ 
++### `mirror: true`
++
++Whether to mirror preview image from the camera. This option is useful when taking a selfie with a front camera: when you wave your right hand, you will see your hand on the right on the preview screen, like in the mirror. But when you actually take a picture, it will not be mirrored. This is how smartphone selfie cameras behave.
++
++### `facingMode: 'user'`
++
++Devices sometimes have multiple cameras, front and back, for example. There’s a browser API to set which camera will be used, [facingMode](https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints/facingMode):
++
++- `user`: The video source is facing toward the user; this includes, for example, the front-facing camera on a smartphone.
++- `environment`:  The video source is facing away from the user, thereby viewing their environment. This is the back camera on a smartphone.
++- `left`: The video source is facing toward the user but to their left, such as a camera aimed toward the user but over their left shoulder.
++- `right`: The video source is facing toward the user but to their right, such as a camera aimed toward the user but over their right shoulder.",sweet!,2018-02-12 09:01:09
+557,"@@ -52,7 +52,7 @@
+     }
+ 
+     console.log = customLog(console.log.bind(console), document.getElementById(""console-log""));
+-    console.debug = customLog(console.log.bind(console), document.getElementById(""console-log""));
++    console.debug = customLog(console.debug.bind(console), document.getElementById(""console-log""));",I think this used console.log for compatibility with IE,2019-07-24 12:34:13
+471,"@@ -521,12 +522,27 @@ module.exports = class Dashboard extends Plugin {
+     }
+ 
+     this.startListeningToResize()
++    document.addEventListener('paste', this.handlePasteOnBody)
+ 
+     this.uppy.on('plugin-remove', this.removeTarget)
+     this.uppy.on('file-added', this.handleFileAdded)
+     this.uppy.on('complete', this.handleComplete)
+   }
+ 
++  // ___Why do we listen to the 'paste' event on a document instead of a civil onPaste={props.handlePaste} prop?
++  //    Because (at least) Chrome doesn't handle paste if focus is on some button, e.g. 'My Device'.
++  //    We could add onPaste to each button; and make each button contentEditable={true} for pastes to work while we're focused on them, but it adds a visible cursor, and requires us to be adding onChange={event.preventDefault()} to each button.
++  //    => Therefore, the best option is to listen to all 'paste' events, and only react to them when we are focused on our particular Uppy instance.
++  // ___Why do we still need onPaste={props.handlePaste} for the DashboardUi!
++  //    Because if we click on the 'Drop files here,', `document.activeElement` will be 'body'. Which means our standard determination of whether we're pasting into our Uppy instance won't work.
++  //    => Therefore, we need a traditional onPaste={props.handlePaste} handler too.
++  handlePasteOnBody (event) {","Love the detailed explanation, really helps, thank you!",2019-05-22 15:41:50
+104,"@@ -524,6 +524,17 @@ function findDOMElement (element) {
+   }
+ }
+ 
++/**
++ * Find one or more DOM elements.
++ *
++ * @param {string} selector
++ * @return {Array|null}
++ */
++function findAllDOMElements (selector) {
++  const elements = [].slice.call(document.querySelectorAll(selector))
++  return elements.length > 0 ? elements : null","🤔 looking at this now, `trigger:` should also still accept a DOM element being passed in. If it's not a CSS selector string but a DOM element we should return that in an array.",2017-09-11 09:11:47
+108,"@@ -527,12 +527,18 @@ function findDOMElement (element) {
+ /**
+  * Find one or more DOM elements.
+  *
+- * @param {string} selector
++ * @param {string} element
+  * @return {Array|null}
+  */
+-function findAllDOMElements (selector) {
+-  const elements = [].slice.call(document.querySelectorAll(selector))
+-  return elements.length > 0 ? elements : null
++function findAllDOMElements (element) {
++  if (typeof element === 'string') {
++    const elements = [].slice.call(document.querySelectorAll(element))
++    return elements.length > 0 ? elements : null
++  }
++
++  if (typeof element === 'object' && isDOMElement(element)) {
++    return element","If we return an array with a single item here (`return [element]`), the code that checks if the result is an array when adding and removing events can be simplified to always assume an array.",2017-09-11 13:52:30
+809,"@@ -53,20 +55,30 @@ describe('Test Provider options', () => {
+       ],
+       callback: '/drive/callback'
+     })
++    expect(grantConfig.zoom).toEqual({
++      key: 'zoom_key',
++      secret: 'zoom_secret',
++      transport: 'session',
++      authorize_url: 'https://zoom.us/oauth/authorize',
++      access_url: 'https://zoom.us/oauth/token',
++      callback: '/zoom/callback'
++    })
+   })
+ 
+   test('adds provider options for secret files', () => {
+     process.env.COMPANION_DROPBOX_SECRET_FILE = process.env.PWD + '/test/resources/dropbox_secret_file'
+     process.env.COMPANION_GOOGLE_SECRET_FILE = process.env.PWD + '/test/resources/google_secret_file'
+     process.env.COMPANION_INSTAGRAM_SECRET_FILE = process.env.PWD + '/test/resources/instagram_secret_file'
++    process.env.ZOOM_SECRET_FILE = process.env.PWD + '/test/resources/zoom_secret_file'
+ 
+     companionOptions = getCompanionOptions()
+-
+     providerManager.addProviderOptions(companionOptions, grantConfig)
+ 
+     expect(grantConfig.dropbox.secret).toBe('xobpord')
+     expect(grantConfig.google.secret).toBe('elgoog')
+     expect(grantConfig.instagram.secret).toBe('margatsni')
++    // not sure why this is failing...
++    // expect(grantConfig.zoom.secret).toBe('u8Z5ceq')",the reason this is failing is because line 72 is setting ` process.env.ZOOM_SECRET_FILE` instead of ` process.env.COMPANION_ZOOM_SECRET_FILE`,2020-07-07 14:48:30
+410,"@@ -53,50 +55,63 @@ module.exports = class RequestClient {
+   }
+ 
+   get (path) {
+-    return fetch(this._getUrl(path), {
+-      method: 'get',
+-      headers: this.headers,
+-      credentials: 'same-origin'
+-    })
+-      // @todo validate response status before calling json
+-      .then(this.onReceiveResponse)
+-      .then((res) => res.json())
+-      .catch((err) => {
+-        throw new Error(`Could not get ${this._getUrl(path)}. ${err}`)
++    return new Promise((resolve, reject) => {",This promise wrapper should be unnecessary—can `return` the `this.headers().then()` chain instead,2019-03-25 10:31:57
+409,"@@ -53,50 +55,63 @@ module.exports = class RequestClient {
+   }
+ 
+   get (path) {
+-    return fetch(this._getUrl(path), {
+-      method: 'get',
+-      headers: this.headers,
+-      credentials: 'same-origin'
+-    })
+-      // @todo validate response status before calling json
+-      .then(this.onReceiveResponse)
+-      .then((res) => res.json())
+-      .catch((err) => {
+-        throw new Error(`Could not get ${this._getUrl(path)}. ${err}`)
++    return new Promise((resolve, reject) => {
++      this.headers().then((headers) => {
++        fetch(this._getUrl(path), {
++          method: 'get',
++          headers: headers,
++          credentials: 'same-origin'
++        })
++          // @todo validate response status before calling json
++          .then(this.onReceiveResponse)
++          .then((res) => res.json().then(resolve))
++          .catch((err) => {
++            reject(new Error(`Could not get ${this._getUrl(path)}. ${err}`))
++          })
+       })
++    })
+   }
+ 
+   post (path, data) {
+-    return fetch(this._getUrl(path), {
+-      method: 'post',
+-      headers: this.headers,
+-      credentials: 'same-origin',
+-      body: JSON.stringify(data)
+-    })
+-      .then(this.onReceiveResponse)
+-      .then((res) => {
+-        if (res.status < 200 || res.status > 300) {
+-          throw new Error(`Could not post ${this._getUrl(path)}. ${res.statusText}`)
+-        }
+-        return res.json()
+-      })
+-      .catch((err) => {
+-        throw new Error(`Could not post ${this._getUrl(path)}. ${err}`)
++    return new Promise((resolve, reject) => {
++      this.headers().then((headers) => {",ditto about promise chain,2019-03-25 10:31:42
+407,"@@ -53,50 +55,63 @@ module.exports = class RequestClient {
+   }
+ 
+   get (path) {
+-    return fetch(this._getUrl(path), {
+-      method: 'get',
+-      headers: this.headers,
+-      credentials: 'same-origin'
+-    })
+-      // @todo validate response status before calling json
+-      .then(this.onReceiveResponse)
+-      .then((res) => res.json())
+-      .catch((err) => {
+-        throw new Error(`Could not get ${this._getUrl(path)}. ${err}`)
++    return new Promise((resolve, reject) => {
++      this.headers().then((headers) => {
++        fetch(this._getUrl(path), {
++          method: 'get',
++          headers: headers,
++          credentials: 'same-origin'
++        })
++          // @todo validate response status before calling json
++          .then(this.onReceiveResponse)
++          .then((res) => res.json().then(resolve))
++          .catch((err) => {
++            reject(new Error(`Could not get ${this._getUrl(path)}. ${err}`))
++          })
+       })
++    })
+   }
+ 
+   post (path, data) {
+-    return fetch(this._getUrl(path), {
+-      method: 'post',
+-      headers: this.headers,
+-      credentials: 'same-origin',
+-      body: JSON.stringify(data)
+-    })
+-      .then(this.onReceiveResponse)
+-      .then((res) => {
+-        if (res.status < 200 || res.status > 300) {
+-          throw new Error(`Could not post ${this._getUrl(path)}. ${res.statusText}`)
+-        }
+-        return res.json()
+-      })
+-      .catch((err) => {
+-        throw new Error(`Could not post ${this._getUrl(path)}. ${err}`)
++    return new Promise((resolve, reject) => {
++      this.headers().then((headers) => {
++        fetch(this._getUrl(path), {
++          method: 'post',
++          headers: headers,
++          credentials: 'same-origin',
++          body: JSON.stringify(data)
++        })
++          .then(this.onReceiveResponse)
++          .then((res) => {
++            if (res.status < 200 || res.status > 300) {
++              reject(new Error(`Could not post ${this._getUrl(path)}. ${res.statusText}`))
++              return
++            }
++            res.json().then(resolve)
++          })
++          .catch((err) => {
++            reject(new Error(`Could not post ${this._getUrl(path)}. ${err}`))
++          })
+       })
++    })
+   }
+ 
+   delete (path, data) {
+-    return fetch(`${this.hostname}/${path}`, {
+-      method: 'delete',
+-      headers: this.headers,
+-      credentials: 'same-origin',
+-      body: data ? JSON.stringify(data) : null
+-    })
+-      .then(this.onReceiveResponse)
+-      // @todo validate response status before calling json
+-      .then((res) => res.json())
+-      .catch((err) => {
+-        throw new Error(`Could not delete ${this._getUrl(path)}. ${err}`)
++    return new Promise((resolve, reject) => {",This promise wrapper should be unnecessary—can `return` the `this.headers().then()` chain instead,2019-03-25 10:29:54
+793,"@@ -53,7 +53,7 @@ describe('React: Dashboard', () => {
+     await toggle()
+ 
+     // open GDrive panel
+-    const gdriveButton = await $('.uppy-DashboardTab:nth-child(1) button')
++    const gdriveButton = await $('.uppy-DashboardTab[data-acquirer-id=""GoogleDrive""] button')","```suggestion
+    const gdriveButton = await $('.uppy-DashboardTab[data-uppy-acquirer-id=""GoogleDrive""] button')
+```",2020-06-29 12:35:22
+417,"@@ -534,10 +535,8 @@ module.exports = class ProviderView {
+             pluginName={this.plugin.title}
+             pluginIcon={this.plugin.icon}
+             demo={this.plugin.opts.demo}
+-            checkAuth={this.checkAuth}
+             handleAuth={this.handleAuth}
+-            handleDemoAuth={this.handleDemoAuth}
+-            checkAuthInProgress={checkAuthInProgress} />
++            handleDemoAuth={this.handleDemoAuth} />","Should we remove this, have not been used for a while, right?",2019-03-27 09:42:50
+491,"@@ -535,6 +536,15 @@ module.exports = class Dashboard extends Plugin {
+     //    To support IE.
+     this.el.addEventListener('focus', this.recordIfFocusedOnUppyAtLeastOnce, true)
+     this.el.addEventListener('click', this.recordIfFocusedOnUppyAtLeastOnce, true)
++
++    if (this.opts.inline) {
++      document.addEventListener('keydown', this.handleKeyDownInInline)
++    }",Nitpicking: would `this.el.addEventListener` work?,2019-05-29 17:34:22
+43,"@@ -536,12 +584,30 @@ class Uppy {
+ 
+     this.emit('core:upload')
+ 
++    const waitingFileIDs = Object.keys(this.state.files)
++      .map(getFile, this)
++      .filter(isFileWaiting)
++      .map(toFileID)
++    function getFile (fileID) {
++      return this.state.files[fileID]
++    }
++    function isFileWaiting (file) {
++      // TODO: replace files[file].isRemote with some logic
++      //
++      // filter files that are now yet being uploaded / haven’t been uploaded
++      // and remote too
++      return !file.progress.uploadStarted || file.isRemote
++    }
++    function toFileID (file) {
++      return file.id
++    }","This bunch of code makes sure that each plugin in the pipeline works on the same files. I'm not sure if this is the way to go, perhaps the previous way where plugins pick the files they need to work on is better, if we design the progress state in such a way that plugins can find the right files easily. With this patch there is some implicit state in this function closure…",2017-06-05 13:18:58
+573,"@@ -537,6 +537,12 @@ module.exports = class XHRUpload extends Plugin {
+     const files = fileIDs.map((fileID) => this.uppy.getFile(fileID))
+ 
+     if (this.opts.bundle) {
++      // if bundle: true, we don’t support remote uploads
++      const isSomeFileRemote = files.some(file => file.isRemote)
++      if (isSomeFileRemote) {
++        throw new Error('Can’t bundle remote files when bundle: true is set')",Maybe change it to `'Can’t UPLOAD remote files when bundle: true is set'`?,2019-08-13 12:57:30
+322,"@@ -54,42 +67,40 @@ if (!watchifyEnabled && process.argv[2]) {
+ }
+ 
+ // Find each app.es6 file with glob.
+-glob(srcPattern, function (err, files) {
++glob(srcPattern, (err, files) => {
+   if (err) throw new Error(err)
+ 
+   if (watchifyEnabled) {
+     console.log('--> Watching examples..')
+   }
+ 
+-  var muted = []
++  const muted = new Set()
+ ",TIL about `Set`,2018-07-18 23:50:18
+851,"@@ -54,6 +54,8 @@ class Uppy {
+         // TODO: In 2.0 `exceedsSize2` should be removed in and `exceedsSize` updated to use substitution.
+         exceedsSize2: '%{backwardsCompat} %{size}',
+         exceedsSize: 'This file exceeds maximum allowed size of',
++        inferiorSize2: '%{backwardsCompat} %{size}',
++        inferiorSize: 'This file is smaller than the allowed size of',","```suggestion
+        inferiorSize: 'This file is smaller than the allowed size of %{size}',
+```",2020-07-27 10:56:35
+594,"@@ -546,7 +546,17 @@ module.exports = class Dashboard extends Plugin {
+     })
+ 
+     // 4. Add all dropped files
+-    getDroppedFiles(event.dataTransfer)
++    let executedDropErrorOnce = false
++    const logDropError = (error) => {
++      this.uppy.log(error.message, 'error')","Is there a reason for logging `error.message` specifically, maybe log the whole error object?",2019-08-30 06:16:26
+595,"@@ -546,7 +546,17 @@ module.exports = class Dashboard extends Plugin {
+     })
+ 
+     // 4. Add all dropped files
+-    getDroppedFiles(event.dataTransfer)
++    let executedDropErrorOnce = false
++    const logDropError = (error) => {
++      this.uppy.log(error.message, 'error')
++
++      // In practice all drop errors are most likely the same, so let's just show one to avoid overwhelming the user
++      if (!executedDropErrorOnce) {",👍 ,2019-08-30 06:16:44
+59,"@@ -55,12 +85,13 @@ module.exports = (props) => {
+   let progressMode
+   let progressBarContent
+   if (uploadState === STATE_PREPROCESSING || uploadState === STATE_POSTPROCESSING) {
+-    // TODO set progressValue and progressMode depending on the actual pre/postprocess
+-    // progress state
+-    progressMode = 'indeterminate'
+-    progressValue = undefined
++    const progress = calculateProcessingProgress(props.files)
++    progressMode = progress.mode
++    if (progressMode === 'determinate') {
++      progressValue = progress.value * 100
++    }",This implements the TODO,2017-06-23 13:29:47
+151,"@@ -55,24 +56,22 @@ const uppy = Uppy({
+     closeModalOnClickOutside: false,
+     locale: {
+       strings: {browse: 'browse'}
+-    }
++    },
++    metaFields: [
++      { id: 'license', name: 'License', value: 'Creative Commons', placeholder: 'specify license' },
++      { id: 'caption', name: 'Caption', value: '', placeholder: 'describe what the image is about' }
++    ]",we should add docs for the `metaFields` option. could do it here or in a followup pr.,2017-12-09 16:01:35
+611,"@@ -55,6 +55,12 @@ module.exports = class AwsS3 extends Plugin {
+ 
+     this.opts = { ...defaultOptions, ...opts }
+ 
++    if (!this.opts.includes('companionUrl')) {","We should only warn if there is no user-provided getUploadParameters function:
+```suggestion
+    if (!this.opts.companionUrl && !opts.getUploadParameters) {
+```
+
+(and check for the `companionUrl` _property_ because it's an object rather than an array)",2019-11-08 12:45:22
+441,"@@ -55,7 +55,7 @@
+ .uppy-StatusBar:not([aria-hidden=true]).is-waiting {
+   background-color: $white;
+   height: 65px;
+-  border-top: 1px solid $gray-200;
++  border-top: 1px solid #eaeaea;
+ }","Could we stick to the variables for colors, maybe we should be using a different one? Not sure about the reason for this change.",2019-04-16 14:49:45
+763,"@@ -55,7 +64,6 @@ module.exports = class Tus extends Plugin {
+ 
+     // set default options
+     const defaultOptions = {
+-      resume: true,","In tus-js-client v2 the `resume` option has been removed. When previously enabled, the uploader would look into localStorage to see if a file with the same fingerprint has been uploaded before and then resume from that URL. Regardless of whether `resume` is enabled, the retries of errored requests is controlled by the `retryDelays` option.
+
+In v2, the app can now query the previous uploads on its own and ask the user (or determine on its own) which upload should be resumed. The API looks like this:
+
+```js
+  upload = new tus.Upload(file, options);
+  upload.findPreviousUploads().then((previousUploads) => {
+    // Prompt user which upload should be resumed
+    const index = askToResumeUpload(previousUploads);
+    if (index != null) {
+       upload.resumeFromPreviousUpload(previousUploads[index]);
+    }
+
+    upload.start();
+  });
+```
+
+I didn't add the call to findPreviousUploads yet because I don't really know where to fit it. Maybe you can help?",2020-05-03 16:10:31
+685,"@@ -551,6 +568,55 @@ class Uploader {
+       this.cleanUp()
+     })
+   }
++
++  /**
++   * Upload a stream to B2 while it is still being downloaded.
++   */
++  uploadB2 () {
++    if (!this.options.b2) {
++      this.emitError(new Error('The B2 client is not configured on this companion instance.'))
++      return
++    }
++    const filename = this.options.metadata.filename || path.basename(this.path)
++    const fileSize = this.options.size
++    const { client, options } = this.options.b2
++
++    if (!this._b2EndpointPool) {
++      this._b2EndpointPool = client.createEndpointPool(options.bucket)
++    }
++
++    const upload = client.upload({
++      bucketName: options.bucket,
++      path: this.path,
++      fileName: options.getPath(null, filename), // destination
++      fileSize, // expected final size of the file being transferred
++      stream: this.beginTailReadStream(),
++      endpointPool: this._b2EndpointPool
++    })
++
++    this.b2Upload = upload
++
++    upload.onUploadProgress = ({ loaded, total }) => {
++      this.emitProgress(loaded, total)
++    }
++
++    upload.send((error, data) => {
++      this.b2Upload = null
++      if (error) {
++        this.emitError(error)
++      } else {
++        this.emitSuccess('?', {",the first argument to `emitSuccess` is meant to be the [url to the uploaded file](https://github.com/transloadit/uppy/blob/14f5edc715adf05301a5f9330acd12afa8abd97d/packages/%40uppy/companion/src/server/Uploader.js#L370). Is that not available in this case? If not then we should probably be passing the value `null` there instead.,2020-03-05 15:43:07
+561,"@@ -553,16 +553,14 @@ class Uppy {
+ 
+     this.setState({
+       currentUploads: updatedUploads,
+-      files: updatedFiles
++      files: updatedFiles,
++      ...(
++        // If this is the last file we just removed - allow new uploads!
++        Object.keys(updatedFiles).length === 0 &&
++        { allowNewUpload: true }
++      )","Is `...(` necessary because you don’t want to `allowNewUpload: false` if this was not the last file?
+
+I mean, why not:
+
+```js
+const isLastFile = Object.keys(updatedFiles).length === 0
+setState({
+  allowNewUpload: isLastFile
+})
+```",2019-08-06 10:13:30
+172,"@@ -555,7 +556,7 @@ module.exports = class View {
+     }
+ 
+     if (!authenticated) {
+-      return AuthView({
++      return h(AuthView, {","ok, that's not so bad :D",2017-12-13 21:44:52
+560,"@@ -556,6 +556,13 @@ class Uppy {
+       files: updatedFiles
+     })
+ 
++    // If nothing is uploading anymore, and if nothing has uploaded yet - allow new uploads!
++    if (Object.keys(updatedFiles).length === 0) {
++      this.setState({
++        allowNewUpload: true","Could we combine this with the `setState` call above, so we don’t have to call it twice?",2019-08-05 15:42:01
+277,"@@ -56,13 +56,30 @@ module.exports = class FileCard extends Component {
+   }
+ 
+   render () {
++    if (!this.props.fileCardFor) {
++      return <div class=""uppy-DashboardFileCard"" aria-hidden />
++    }
++
+     const file = this.props.files[this.props.fileCardFor]
+ 
+-    return <div class=""uppy-DashboardFileCard"" aria-hidden={!this.props.fileCardFor}>
+-      {this.props.fileCardFor &&
++    console.log({
++      what: this.props.i18n('editing', {
++        file: 'test'
++      }),
++      ever: this.props.i18nArray('editing', {
++        file: <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span>
++      })
++    })
++",Forgotten debug console.log?,2018-05-24 22:38:24
+330,"@@ -56,29 +70,47 @@ export interface Store {
+   subscribe(listener: any): () => void;
+ }
+ 
++interface LocaleObject {
++  [key: string]: string | LocaleObject;","A locale object can only have a `strings` and `pluralize` key, I think it should be:
+
+```ts
+interface LocaleStrings {
+  [key: string]: string | LocaleStrings;
+}
+interface Locale {
+  strings: LocaleStrings;
+  pluralize: (n: number) => number;
+}
+```",2018-08-16 09:36:39
+251,"@@ -56,6 +56,8 @@ module.exports = function fileItem (props) {
+         ? props.i18n('retryUpload')
+         : props.i18n('cancelUpload')
+ 
++  console.log('ЕБА', props.showLinkToFileUploadResult)",:point_up: :),2018-04-17 14:28:13
+198,"@@ -56,9 +56,9 @@ module.exports = class FileCard extends Component {
+       {this.props.fileCardFor &&
+         <div style=""width: 100%; height: 100%;"">
+           <div class=""uppy-DashboardContent-bar"">
+-            <h2 class=""uppy-DashboardContent-title"">Editing <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>
+-            <button class=""uppy-DashboardContent-back"" type=""button"" title=""Finish editing file""
+-              onclick={this.handleClick}>Done</button>
++            <h2 class=""uppy-DashboardContent-title"">{this.props.i18n('editing')} <span class=""uppy-DashboardContent-titleFile"">{file.meta ? file.meta.name : file.name}</span></h2>","we should have a way to insert components into a i18n string. so that we could define a translation string like `'%{filename} is being edited'`, and inject the filename `<span/>` at the right place. I imagine there must be a language where the `Editing` text should come after the file name. we can think about that later tho.",2018-01-29 08:31:05
+285,"@@ -565,6 +588,10 @@ module.exports = class ProviderView {
+       i18n: this.plugin.uppy.i18n
+     })
+ 
+-    return <Browser {...browserProps} />
++    return (
++      <CloseWrapper onUnmount={this.clearSelection}>
++        <Browser {...browserProps} />
++      </CloseWrapper>
++    )","👍
+
+`onUnmount` is handy, but a Preact-only thing it seems. Very much not a big deal, but I was trying to keep an open door for React, hence not using `render(state, props)` and other niceties :) But we can always refactor of course, no need to stick to theoretical benefits :) ",2018-05-29 13:34:31
+480,"@@ -566,17 +579,35 @@ module.exports = class Dashboard extends Plugin {
+     })
+   }
+ 
+-  afterUpdate () {
+-    // If update is connected to showing the Informer - let the screen reader calmly read it.
+-    const isInformerPresent = !this.uppy.getState().info.isHidden
++  superFocusOnEachUpdate () {
++    // If we are inline
++    if (this.opts.inline) {
++      const isFocusInUppy = this.el.contains(document.activeElement)
++      const isFocusOnBody = document.activeElement === document.querySelector('body')
+ 
+-    if (isInformerPresent) {
+-      this.superFocus.cancel()
++      // Only superFocus() if focus:
++      // - is already inside of Uppy,
++      // - or nowhere (== on body) [this is true when some overlay we were focused on disappeared. this IS NOT true when user is focused on some element on the page other than Uppy]
++      //   BUT we have already, at least once, focused on uppy [this is done to avoid focusing related to the page initialisation]
++      if (isFocusInUppy || (isFocusOnBody && this.ifFocusedOnUppyAtLeastOnce)) {
++        this.superFocus(this.el, this.getPluginState().activeOverlayType)
++      }",Do we need to repeat the `isInformerPresent` logic for inline?,2019-05-24 15:41:12
+629,"@@ -57,6 +57,11 @@ const getConfigFromEnv = () => {
+         region: process.env.COMPANION_AWS_REGION,
+         useAccelerateEndpoint:
+           process.env.COMPANION_AWS_USE_ACCELERATE_ENDPOINT === 'true'
++      },
++      b2: {
++        keyId: process.env.COMPANION_B2_KEY_ID,","This is used as `applicationKeyId` elsewhere:
+```suggestion
+        applicationKeyId: process.env.COMPANION_B2_KEY_ID,
+```",2019-11-18 14:32:37
+630,"@@ -57,6 +57,11 @@ const getConfigFromEnv = () => {
+         region: process.env.COMPANION_AWS_REGION,
+         useAccelerateEndpoint:
+           process.env.COMPANION_AWS_USE_ACCELERATE_ENDPOINT === 'true'
++      },
++      b2: {
++        keyId: process.env.COMPANION_B2_KEY_ID,
++        key: getSecret('COMPANION_B2_KEY'),","similarly:
+```suggestion
+        applicationKey: getSecret('COMPANION_B2_KEY'),
+```",2019-11-18 14:32:53
+545,"@@ -57,9 +57,11 @@ class FileCard extends Component {
+     const metaFields = this.props.metaFields || []
+ 
+     return metaFields.map((field, i) => {
++      const id = `uppy-DashboardFileCard-input-${field.id}`","I wonder if a `field.id` might contain special characters that could make `id` an invalid css selector?
+
+In that case we might be better of using `cuid`, like: https://github.com/transloadit/uppy/blob/fcfdf64d7e058d74f9315d3258dee5aaa8f1af82/packages/%40uppy/dashboard/src/index.js#L40
+
+Not sure, just sharing a thought.
+
+https://stackoverflow.com/questions/448981/which-characters-are-valid-in-css-class-names-selectors",2019-07-08 14:31:39
+735,"@@ -570,6 +570,21 @@ module.exports = class Dashboard extends Plugin {
+       })
+   }
+ 
++  handleRequestThumbnail = (file) => {
++    if (!this.opts.waitForThumbnailsBeforeUpload) {
++      this.uppy.emit('thumbnail:request', file)
++    }
++  }
++
++  /**
++   * We cancel thumbnail requests when a file item component unmounts to avoid clogging up the queue when the user scrolls past many elements.",Really nice ,2020-04-14 17:53:49
+647,"@@ -577,49 +577,143 @@ class Uppy {
+         })
+       }, 4)
+     }
++  }
+ 
+-    return fileID
++  /**
++   * Add a new file to `state.files`. This will run `onBeforeFileAdded`,
++   * try to guess file type in a clever way, check file against restrictions,
++   * and start an upload if `autoProceed === true`.
++   *
++   * @param {object} file object to add
++   * @returns {string} id for the added file
++   */
++  addFile (file) {
++    this._assertNewUploadAllowed(file)
++
++    const { files } = this.getState()
++    const newFile = this._checkAndCreateFileStateObject(files, file)
++
++    this.setState({
++      files: {
++        ...files,
++        [newFile.id]: newFile
++      }
++    })
++
++    this.emit('file-added', newFile)
++    this.log(`Added file: ${newFile.name}, ${newFile.id}, mime type: ${newFile.type}`)
++
++    this._startIfAutoProceed()
++
++    return newFile.id
+   }
+ 
+-  removeFile (fileID) {
++  /**
++   * Add multiple files to `state.files`. See the `addFile()` documentation.
++   *
++   * This cuts some corners for performance, so should typically only be used in cases where there may be a lot of files.
++   *
++   * If an error occurs while adding a file, it is logged and the user is notified. This is good for UI plugins, but not for programmatic use. Programmatic users should usually still use `addFile()` on individual files.
++   */
++  addFiles (fileDescriptors) {
++    this._assertNewUploadAllowed()
++
++    // create a copy of the files object only once
++    const files = { ...this.getState().files }
++    const newFiles = []
++    const errors = []
++    for (let i = 0; i < fileDescriptors.length; i++) {
++      try {
++        const newFile = this._checkAndCreateFileStateObject(files, fileDescriptors[i])
++        newFiles.push(newFile)
++        files[newFile.id] = newFile
++      } catch (err) {
++        if (!err.isRestriction) {
++          errors.push(err)
++        }
++      }
++    }
++
++    this.setState({ files })
++
++    newFiles.forEach((newFile) => {
++      this.emit('file-added', newFile)
++    })
++    this.log(`Added batch of ${newFiles.length} files`)
++
++    this._startIfAutoProceed()
++
++    if (errors.length > 0) {
++      const err = new Error('Multiple errors occured while adding files')
++      err.errors = errors","Hm, if one error occurs after we try to add one file, - we will get a generic `Error: Multiple errors occured while adding files`, with no indication of what happened.
+That could work if we were catching and logging `error.errors` everywhere after we use `.addFiles`, but we don't yet do that.
+
+Should we log each error ourselves in `addFiles()` instead? That would also make:
+```
+    try {
+      this.uppy.addFiles(descriptors)
+    } catch (err) {
+      this.uppy.log(err)
+    }
+```
+tradition unnecessary?
+
+PS. Looks like it's occurrRred (https://en.wiktionary.org/wiki/occured).",2019-12-01 20:39:36
+252,"@@ -58,4 +58,19 @@ module.exports = class RequestClient {
+       // @todo validate response status before calling json
+       .then((res) => res.json())
+   }
++
++  delete (path, data) {
++    return fetch(`${this.hostname}/${path}`, {
++      method: 'post',",shouldn't `method` be `'delete'`?,2018-04-24 13:17:03
+997,"@@ -58,7 +58,7 @@ module.exports = function Dashboard (props) {
+       className={dashboardClassName}
+       data-uppy-theme={props.theme}
+       data-uppy-num-acquirers={props.acquirers.length}
+-      data-uppy-drag-drop-supported={isDragDropSupported()}
++      data-uppy-drag-drop-supported={!props.disableLocalFiles && isDragDropSupported()}",sane condition? 🤔 ,2021-04-08 18:40:09
+748,"@@ -58,7 +72,21 @@ const log = (msg, tag, level, id, color) => {
+   id = id || ''
+   const whitespace = tag && id ? ' ' : ''
+   color = color || ((message) => message)
++  msg = typeof msg === 'string' ? maskMessage(msg) : msg
+   // exclude msg from template string so values such as error objects
+   // can be well formatted
+   console.log(color(`companion: ${time} [${level}] ${id}${whitespace}${tag}`), color(msg))
+ }
++
++/**
++ * Mask the secret content of a message
++ * @param {string} msg the message whose content should be masked
++ * @returns {string}
++ */
++const maskMessage = (msg) => {
++  for (const toBeMasked of valuesToMask) {
++    const toBeReplaced = new RegExp(toBeMasked, 'gi')",maybe this should be passed through [escape-string-regexp](https://www.npmjs.com/package/escape-string-regexp) first? So a a secret that includes a `?` or `+` isn't interpreted as regex syntax,2020-04-22 07:59:30
+355,"@@ -588,16 +586,18 @@ class Uppy {
+   cancelAll () {
+     this.emit('cancel-all')
+ 
+-    // TODO Or should we just call removeFile on all files?
+     const { currentUploads } = this.getState()
+     const uploadIDs = Object.keys(currentUploads)
+-
+     uploadIDs.forEach((id) => {
+       this._removeUpload(id)
+     })","I believe we can <strike>remove</strike>ditch the `_removeUpload` calls here; `removeFile` will remove each upload once all its files were removed.
+
+(remove remove remove)",2018-09-25 14:52:25
+66,"@@ -59,6 +59,13 @@ module.exports = class Plugin {
+     if (targetElement) {
+       this.core.log(`Installing ${callerPluginName} to a DOM element`)
+ 
++      // attempt to extract meta from form element
++      if (this.opts.getMetaDataFromForm && targetElement.nodeName === 'FORM') {
++        const formMeta = getFormData(targetElement)
++        this.core.log('Adding metadata from form')
++        this.core.log(formMeta)",missing `setMeta` :),2017-06-30 11:18:47
+604,"@@ -593,6 +593,8 @@ module.exports = class ProviderView {
+       )
+     }
+ 
++    const targetViewOptions = Object.assign({}, this.opts, viewOptions)","We can use spread in new code:
+```suggestion
+    const targetViewOptions = { ...this.opts, ...viewOptions }
+```",2019-10-14 10:38:37
+605,"@@ -593,6 +593,8 @@ module.exports = class ProviderView {
+       )
+     }
+ 
++    const targetViewOptions = Object.assign({}, this.opts, viewOptions)
++    console.log(targetViewOptions)",should get rid of this before merging :),2019-10-14 10:39:23
+606,"@@ -593,6 +593,8 @@ module.exports = class ProviderView {
+       )
+     }
+ 
++    const targetViewOptions = { ...this.opts, ...viewOptions }
++    console.log(targetViewOptions)","```suggestion
+```",2019-10-14 15:24:15
+193,"@@ -6,43 +6,40 @@
+     ""version"": ""3.3.7""
+   },
+   ""dependencies"": {
+-    ""autoprefixer"": ""6.4.0"",
+-    ""cssnano"": ""3.7.3"",
+-    ""hexo"": ""^3.3.7"",
+-    ""hexo-browsersync"": ""0.2.0"",
+-    ""hexo-deployer-git"": ""0.2.0"",
++    ""autoprefixer"": ""^7.2.5"",
++    ""cssnano"": ""^3.10.0"",
++    ""hexo"": ""^3.4.4"",
++    ""hexo-browsersync"": ""^0.3.0"",
++    ""hexo-deployer-git"": ""^0.3.1"",
+     ""hexo-generator-alias"": ""^0.1.3"",
+-    ""hexo-generator-archive"": ""0.1.4"",
+-    ""hexo-generator-category"": ""0.1.3"",
+-    ""hexo-generator-feed"": ""1.2.0"",
+-    ""hexo-generator-index"": ""0.2.0"",
+-    ""hexo-generator-tag"": ""0.2.0"",
+-    ""hexo-renderer-ejs"": ""0.2.0"",
+-    ""hexo-renderer-marked"": ""0.3.0"",
+-    ""hexo-renderer-postcss"": ""https://github.com/arturi/hexo-renderer-postcss#afca2bc12f5816067b15a9d24017c70e077b9f0b"",
+-    ""hexo-renderer-scss"": ""1.0.2"",
++    ""hexo-generator-archive"": ""^0.1.5"",
++    ""hexo-generator-category"": ""^0.1.3"",
++    ""hexo-generator-feed"": ""^1.2.2"",
++    ""hexo-generator-index"": ""^0.2.1"",
++    ""hexo-generator-tag"": ""^0.2.0"",
++    ""hexo-renderer-ejs"": ""^0.2.0"",
++    ""hexo-renderer-marked"": ""^0.3.2"",
++    ""hexo-renderer-postcss"": ""https://github.com/goto-bus-stop/hexo-renderer-postcss#new-postcss"",",Change this back after https://github.com/arturi/hexo-renderer-postcss/pull/4 is merged,2018-01-15 10:50:03
+626,"@@ -6,7 +6,7 @@ class AddFiles extends Component {
+     super(props)
+ 
+     this.triggerFileInputClick = this.triggerFileInputClick.bind(this)
+-    this.handleFileInputChange = this.handleFileInputChange.bind(this)
++    this.onHandleFileInputChange = this.onHandleFileInputChange.bind(this)","`handle` and `on` kinda means the same thing in this situation, so i think this should either be `handleFileInputChange` or `onFileInputChange`",2019-11-18 10:11:39
+192,"@@ -6,7 +6,9 @@ order: 4
+ 
+ ## Uppy Development
+ 
+-First clone and install the project:
++Fork the repository into your own account first. Here's the [link](https://help.github.com/articles/fork-a-repo/) that tells how to fork a repo.  
++
++After you have successfully forked the repo, clone and install the project:
+ 
+ ```bash
+ git clone git@github.com:transloadit/uppy.git",This `git clone` command should also be updated to clone the user's own repository URL,2018-01-15 08:15:40
+488,"@@ -6,8 +6,21 @@ jest.mock('../../src/server/helpers/oauth-state', () => {
+   return {
+     generateState: () => 'some-cool-nice-encrytpion',
+     addToState: () => 'some-cool-nice-encrytpion',
+-    getFromState: (state) => {
+-      return state === 'state-with-invalid-instance-url' ? 'http://localhost:3452' : 'http://localhost:3020'
++    getFromState: (state, key) => {
++      console.log('mummy', state, key)",Rogue console.log,2019-05-29 17:14:55
+413,"@@ -6,9 +6,11 @@
+ const RequestClient = require('./RequestClient')
+ const Provider = require('./Provider')
+ const Socket = require('./Socket')
++const tokenStorage = require('./token-storage')
+ 
+ module.exports = {
+   RequestClient,
+   Provider,
+-  Socket
++  Socket,
++  tokenStorage",does this need to be exported? all the auth token handling is done internally in companion-client isn't it?,2019-03-25 10:34:52
+148,"@@ -60,6 +60,15 @@ module.exports = (props) => {
+           title: props.title
+         })}
+       </div>
++      <button class=""UppyButton--circular UppyButton--blue Browser-doneBtn""
++              type=""button""
++              aria-label=""Done picking files""
++              title=""Done picking files""",can we localise these? not sure if we have easy access to a translator instance from `generic-provider-views`,2017-12-03 14:45:56
+11,"@@ -60,6 +60,26 @@ export default class Tus10 extends Plugin {
+     })
+   }
+ 
++  install () {
++    this.core.emitter.on('next', () => {
++      this.core.log('began uploading!!..')
++      const selectedFiles = this.core.state.selectedFiles","`const { selectedFiles } = this.core.state`
+",2016-04-04 15:54:19
+927,"@@ -60,6 +61,7 @@ const uppy = new Uppy({
+ })
+ .use(GoogleDrive, { target: Dashboard, companionUrl: 'https://companion.uppy.io' })
+ .use(Dropbox, { target: Dashboard, companionUrl: 'https://companion.uppy.io' })
++.use(Box, { target: Dashboard, companionUrl: 'https://companion.uppy.io' })","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:12:49
+120,"@@ -60,7 +62,7 @@
+     ""isomorphic-fetch"": ""2.2.1"",
+     ""jest"": ""^20.0.4"",
+     ""lint-staged"": ""2.0.2"",
+-    ""minifyify"": ""7.3.3"",
++    ""minify-stream"": ""^1.1.0"",","`minify-stream` wraps uglify-js in a stream interface, I'm using it to replace `minifyify` (which is unmaintained)",2017-09-29 16:45:13
+931,"@@ -61,6 +63,7 @@
+     GoogleDrive: true,
+     Instagram: true,
+     Dropbox: true,
++    Box: true,","excluding from examples in the meantime
+```suggestion
+```",2020-11-13 09:13:43
+249,"@@ -614,51 +605,54 @@ describe('src/Core', () => {
+           allowedFileTypes: ['image/gif']
+         }
+       })
+-      return core
+-        .addFile({
++      try {
++        core.addFile({
+           source: 'jest',
+           name: 'foo.jpg',
+           type: 'image/jpeg',
+-          data: utils.dataURItoFile(sampleImageDataURI, {})
+-        })
+-        .then(() => {
+-          throw new Error('File was allowed through')
+-        })
+-        .catch(e => {
+-          expect(e.message).toEqual('You can only upload: image/gif')
++          data: new File([sampleImage], { type: 'image/jpeg' })
+         })
++        throw new Error('File was allowed through')
++      } catch (err) {
++        expect(err.message).toEqual('You can only upload: image/gif')
++      }
+     })
+ 
+     it('should work with restriction errors that are not Error class instances', () => {
+       const core = new Core({
+         onBeforeFileAdded () {
+-          return Promise.reject('a plain string') // eslint-disable-line prefer-promise-reject-errors
++          throw 'a plain string' // eslint-disable-line no-throw-literal
+         }
+       })
+-      return expect(core.addFile({
+-        source: 'jest',
+-        name: 'foo.jpg',
+-        type: 'image/jpeg',
+-        data: null
+-      })).rejects.toMatchObject(new Error('a plain string'))
++
++      try {
++        core.addFile({
++          source: 'jest',
++          name: 'foo.jpg',
++          type: 'image/jpeg',
++          data: null
++        })
++        throw new Error('should have thrown')","Should we throw here, if we are throwing in `onBeforeFileAdded ` above?",2018-04-09 15:21:31
+357,"@@ -615,6 +621,7 @@ class Uppy {
+ 
+   reset () {
+     this.cancelAll()
++    this.setState({ allowNewUpload: true })","When I press “Cancel” in Dashboard (which calls `cancelAll()`), there’s an “add more files“ screen, but I can’t add more files, since `allowNewUpload` is still `false`.
+
+Same when I remove the file that’s being uploaded. Is this intended?
+
+I think we should probably deprecate `reset()` in favor of `cancelAll()`, since they are basically the same thing?",2018-10-03 21:33:05
+80,"@@ -619,11 +626,57 @@ class Uppy {
+     }
+   }
+ 
+-/**
+- * Logs stuff to console, only if `debug` is set to true. Silent in production.
+- *
+- * @return {String|Object} to log
+- */
++  /**
++  * Set info message in `state.info`, so that UI plugins like `Informer`
++  * can display the message
++  *
++  * @param {string} msg Message to be displayed by the informer
++  */
++
++  info (msg, type, duration) {
++    this.setState({
++      info: {
++        isHidden: false,
++        type: type,
++        msg: msg
++      }
++    })
++
++    this.emit('core:info-visible')
++
++    window.clearTimeout(this.info.timeoutID)","Suuuper tiny nit, but `this.info.timeoutID` confused me first (I thought it was supposed to be `this.state.info.timeoutID`). Could this be a separate property like `this.infoTimeoutID` instead?",2017-07-25 13:31:25
+176,"@@ -62,14 +63,6 @@
+     color: lighten($color-gray, 10%);
+   }
+   
+-  // .uppy-DragDrop-selectedCount {
+-  //   text-align: center;
+-  //   font-size: 0.75em;
+-  //   text-transform: uppercase;
+-  //   letter-spacing: 1px;
+-  //   margin-top: 10px;
+-  // }",🎉 hehe,2017-12-13 21:52:03
+12,"@@ -62,7 +62,12 @@ export default class Multipart extends Plugin {
+           this.core.log(`Download ${file.name} from ${file.uploadURL}`)
+           return resolve(file)
+         } else {
+-          this.core.emitter.emit('core:upload-error', file.id)
++          // OPTION 1: return the full XHR object
++          this.core.emitter.emit('core:upload-error', file.id, xhr);","Please remove semi-colon
+",2016-10-06 10:11:44
+13,"@@ -62,7 +62,12 @@ export default class Multipart extends Plugin {
+           this.core.log(`Download ${file.name} from ${file.uploadURL}`)
+           return resolve(file)
+         } else {
+-          this.core.emitter.emit('core:upload-error', file.id)
++          // OPTION 1: return the full XHR object
++          this.core.emitter.emit('core:upload-error', file.id, xhr);
++
++          // OPTION 2: return the payload of the XHR object
++          this.core.emitter.emit('core:upload-error', file.id, xhr.response);","Please remove semi-colon
+",2016-10-06 10:12:12
+634,"@@ -62,7 +66,7 @@ script:
+ - 'if [ -n ""${LINT-}"" ]; then npm run lint; fi'
+ - 'if [ -n ""${LINT-}"" ]; then npm run test:type; fi'
+ - 'if [ -n ""${UNIT-}"" ]; then npm run test:unit; fi'
+-- 'if [ -n ""${COMPANION-}"" ]; then npm run test:companion; fi'
++- 'if [ -n ""${COMPANION-}"" ] || [ -n ""${COMPANION_NODE6-}"" ]; then npm run test:companion; fi'","Since `npm install` fails on Node 6, we could instead configure the COMPANION_NODE6 build with `nodejs: stable`, and add a line above this one:
+```yaml
+- 'if [ -n ""${COMPANION_NODE6-}"" ]; then nvm install 6.0.0 && nvm use 6.0.0; fi'
+```
+
+so that the latest nodejs will be used during installation but node 6 will be used during tests.",2019-11-24 12:38:22
+753,"@@ -62,9 +62,13 @@ fr_FR.strings = {
+   importFrom: 'Importer de %{name}',
+   loading: 'Chargement...',
+   logOut: 'Déconnexion',
++  micDisabled: 'Accès au micro refusé par l\'utilisateur',
++  micIsOn: 'Micro actif',
+   myDevice: 'Mon Appareil',
++  noDuplicates: 'Impossible d\'ajouter le fichier ""%{fileName}"", il existe déjà',
+   noFilesFound: 'Vous n\'avez aucun fichier ou dossier ici',
+   noInternetConnection: 'Pas de connexion à Internet',
++  noNewAlreadyUploading: 'Impossible d\'ajouter de nouveaux fichiers: en cours de chargement ',","A space is missing before colon.
+
+```
+   noNewAlreadyUploading: 'Impossible d\'ajouter de nouveaux fichiers : en cours de chargement ',
+```",2020-04-24 07:59:37
+467,"@@ -63,7 +63,7 @@ module.exports.app = (options = {}) => {
+   app.use((req, res, next) => {
+     res.header(
+       'Access-Control-Allow-Headers',
+-      [res.get('Access-Control-Allow-Headers'), 'uppy-auth-token'].join(', ')
++      [res.get('Access-Control-Allow-Headers'), 'uppy-auth-token', 'uppy-client'].join(', ')
+     )",uppy-versions?,2019-05-20 15:30:41
+196,"@@ -64,21 +64,21 @@ $ npm install uppy --save
+ 
+ We recommend installing from npm and then using a module bundler such as [Webpack](http://webpack.github.io/), [Browserify](http://browserify.org/) or [Rollup.js](http://rollupjs.org/).
+ 
+-Add CSS [uppy.min.css](https://unpkg.com/uppy/dist/uppy.min.css), either to `<head>` of your HTML page or include in JS, if your bundler of choice supports it — transforms and plugins are available for Browserify and Webpack.
++Add CSS [uppy.min.css](https://transloadit.edgly.net/releases/uppy/v0.22.0/dist/uppy.min.css), either to `<head>` of your HTML page or include in JS, if your bundler of choice supports it — transforms and plugins are available for Browserify and Webpack.
+ 
+-Alternatively, you can also use a pre-built bundle, for example from [unpkg CDN](https://unpkg.com/uppy/). In that case `Uppy` will attach itself to the global `window.Uppy` object.
++Alternatively, you can also use a pre-built bundle, for example from Transloadit's CDN: Edgly. In that case `Uppy` will attach itself to the global `window.Uppy` object.
+ 
+ > ⚠️ The bundle currently consists of most Uppy plugins, so this method is not recommended for production, as your users will have to download all plugins, when you are likely using just a few.
+ 
+ 1\. Add a script to the bottom of `<body>`:
+ 
+ ``` html
+-<script src=""https://unpkg.com/uppy""></script>
++<script src=""https://transloadit.edgly.net/releases/uppy/v0.22.0/dist/uppy.min.js""></script>
+ ```","It was kinda nice that it could point to the latest version automatically, can we achieve that with edgly?",2018-01-25 18:12:58
+814,"@@ -64,6 +64,7 @@ class Uppy {
+         connectedToInternet: 'Connected to the Internet',
+         // Strings for remote providers
+         noFilesFound: 'You have no files or folders here',
++        loadMore: 'Load more',",do we still need this? 🤔 ,2020-07-09 17:26:13
+838,"@@ -64,7 +64,11 @@ uppy.use(Webcam, {
+     'picture'
+   ],
+   mirror: true,
+-  facingMode: 'user',
++  videoConstraints: {
++    facingMode: 'user',
++    width: { min: 720, ideal: 1280, max: 1920 },
++    width: { min: 480, ideal: 800, max: 1080 },","via @arturi
+```suggestion
+    height: { min: 480, ideal: 800, max: 1080 },
+```",2020-07-13 15:29:06
+385,"@@ -64,8 +64,7 @@
+   transition: background-color, width .3s ease-out;
+ 
+   &.is-indeterminate {
+-    background-color: $color-orange;
+-    $stripe-color: darken($color-orange, 10%);","Soo, no orange stripes for encoding then? 🤔",2018-12-06 11:22:24
+237,"@@ -643,13 +638,13 @@ class Uppy {
+         return
+       }
+       this.setFileState(file.id, {
+-        progress: Object.assign({}, this.getFile(file.id), {
++        progress: {","nice, just noticed this today as well :)",2018-03-12 12:01:33
+584,"@@ -647,6 +647,49 @@ describe('src/Core', () => {
+       }
+     })
+ 
++    it('should not allow a dupicate file, a file with the same id', () => {
++      const core = new Core()
++      core.addFile({
++        source: 'jest',
++        name: 'foo.jpg',
++        type: 'image/jpeg',
++        data: new File([sampleImage], { type: 'image/jpeg' })
++      })
++      expect(() => {","Parentheses typo, this test is never failing.
+Should be:
+
+      expect(() => {
+        core.addFile({
+          source: 'jest',
+          name: 'foo.jpg',
+          type: 'image/jpeg',
+          data: new File([sampleImage], { type: 'image/jpeg' }),
+          meta: {
+            notARelativePath: 'folder/a'
+          }
+        })
+      })
+        .toThrow('Cannot add the duplicate file \'foo.jpg\', it already exists')
+
+Same on line 707.",2019-08-23 22:58:10
+888,"@@ -65,10 +65,9 @@ exports.getIsFolder = (item) => {
+   return !item.file_type
+ }
+ 
+-exports.getItemName = (item) => {
+-  const start = moment(item.start_time || item.recording_start)
+-    .clone()
+-    .format('YYYY-MM-DD, kk:mm')
++exports.getItemName = (item, userResponse) => {
++  const start = moment.tz(item.start_time || item.recording_start, userResponse.timezone || 'UTC')
++    .format('YYYY-MM-DD, HH:mm')","we display datetimes in user's timezone preferably.
+Timestamp is also updated to use standard hours, rather than 24 hour time from 1 to 24 (HH instead of kk)",2020-09-11 21:05:13
+190,"@@ -65,3 +67,82 @@ describe('File upload with DragDrop + Tus, DragDrop + XHRUpload, i18n translated
+   //     })
+   // })
+ // })
++
++describe.only('XHRUpload with `limit`', () => {",need to remove the `.only` before merge,2018-01-08 09:23:58
+674,"@@ -65,6 +65,7 @@
+     ""@uppy/utils"": ""file:packages/@uppy/utils"",
+     ""@uppy/webcam"": ""file:packages/@uppy/webcam"",
+     ""@uppy/xhr-upload"": ""file:packages/@uppy/xhr-upload"",
++    ""adm-zip"": ""0.4.13"",","In the past we've put build dependencies in `devDependencies` in the root repo, and only put the uppy packages in `dependencies`. it doesn't make a difference functionally but for consistency's sake it would be best to move this to devDependencies too",2020-02-05 11:04:43
+33,"@@ -65,6 +66,10 @@ module.exports = class Transloadit extends Plugin {
+       })
+ 
+       this.core.setState({ files })
++
++      if (this.opts.wait) {
++        return this.beginWaiting()
++      }
+     }).catch((err) => {
+       this.core.emit('informer', '⚠️ Transloadit: Could not create assembly', 'error', 0)","Would be cool if the error was accessible somehow. Maybe behind a `more details` link for the user. But i realize that goes beyond the scope of this PR, so maybe we can just dump it to the `console.error` for now short of having sth like that?",2017-04-11 11:08:33
+788,"@@ -65,7 +65,11 @@ class AddFiles extends Component {
+ 
+   renderMyDeviceAcquirer = () => {
+     return (
+-      <div class=""uppy-DashboardTab"" role=""presentation"">
++      <div
++        class=""uppy-DashboardTab""
++        role=""presentation""
++        data-acquirer-id=""Local""",(maybe this should be MyDevice or just removed entirely?),2020-06-24 14:15:55
+794,"@@ -65,7 +65,11 @@ class AddFiles extends Component {
+ 
+   renderMyDeviceAcquirer = () => {
+     return (
+-      <div class=""uppy-DashboardTab"" role=""presentation"">
++      <div
++        class=""uppy-DashboardTab""
++        role=""presentation""
++        data-acquirer-id=""MyDevice""","
+```suggestion
+        data-uppy-acquirer-id=""MyDevice""
+```",2020-06-29 12:38:02
+367,"@@ -65,7 +65,9 @@ module.exports = class Transloadit extends Plugin {
+     this._onRestored = this._onRestored.bind(this)
+     this._getPersistentData = this._getPersistentData.bind(this)
+ 
+-    if (this.opts.params) {
++    if (this.opts.params ||
++        // No params _and_ no custom getAssemblyOptions is an early error.
++        this.opts.getAssemblyOptions === defaultOptions.getAssemblyOptions) {
+       AssemblyOptions.validateParams(this.opts.params)","I’m a little stuck understanding, how would this result in an error when `this.opts.params` is not set? It will just not do `AssemblyOptions.validateParams(this.opts.params)` 🤔",2018-10-17 19:22:52
+962,"@@ -651,13 +652,19 @@ module.exports = class Dashboard extends Plugin {
+     }
+   }
+ 
+-  handleComplete = ({ failed, uploadID }) => {
++  handleComplete = ({ failed }) => {
+     if (this.opts.closeAfterFinish && failed.length === 0) {
+       // All uploads are done
+       this.requestCloseModal()
+     }
+   }
+ 
++  _openFileEditorWhenSingleFileAdded = (file) => {","not totally sure about this behaviour when adding multiple files ... it looks like this would only open the file editor for _one_ of the files?
+
+maybe it should auto open for each file in turn? but then we'd probably need a ""skip all"" button in the UI in case users don't want to tweak metadata for a folder of 1000 photos.",2020-12-09 16:11:20
+692,"@@ -651,7 +645,7 @@ module.exports = class Dashboard extends Plugin {
+   superFocusOnEachUpdate = () => {
+     const isFocusInUppy = this.el.contains(document.activeElement)
+     // When focus is lost on the page (== focus is on body for most browsers, or focus is null for IE11)
+-    const isFocusNowhere = document.activeElement === document.querySelector('body') || document.activeElement === null
++    const isFocusNowhere = document.activeElement === document.body || document.activeElement === null","I'm _pretty_ sure this warning is a bug in the compat lint and not actually accurate, but I guess it doesn't matter in this case :)",2020-03-09 14:41:37
+522,"@@ -656,6 +657,52 @@ module.exports = class Dashboard extends Plugin {
+     this.superFocusOnEachUpdate()
+   }
+ 
++  startUpload = (ev) => {
++    this.uppy.upload().catch((err) => {
++      // Log error.
++      this.uppy.log(err.stack || err.message || err)
++    })
++  }
++
++  cancelUpload = (fileID) => {
++    this.uppy.removeFile(fileID)
++  }
++
++  saveFileCard = (meta, fileID) => {
++    this.uppy.setFileMeta(fileID, meta)
++    this.toggleFileCard()
++  }
++
++  _attachRenderFunctionToTarget = (target) => {
++    const plugin = this.uppy.getPlugin(target.id)
++    return {
++      ...target,
++      icon: plugin.icon || this.opts.defaultPickerIcon,
++      render: plugin.render
++    }
++  }
++
++  _isTargetSupported = (target) => {
++    const plugin = this.uppy.getPlugin(target.id)
++    // If the plugin does not provide a `supported` check, assume the plugin works everywhere.
++    if (typeof plugin.isSupported !== 'function') {
++      return true
++    }
++    return plugin.isSupported()
++  }
++
++  _getAcquirers = memoize((targets) => {
++    return targets
++      .filter(target => target.type === 'acquirer' && this._isTargetSupported(target))
++      .map(this._attachRenderFunctionToTarget)
++  })
++
++  _getProgressIndicators = memoize((targets) => {
++    return targets
++      .filter(target => target.type === 'progressindicator')
++      .map(this._attachRenderFunctionToTarget)
++  })","Is using `memoize` here basically sort of a hack, because we can’t get access to props, since render is passed the whole `state` in this case?",2019-06-24 13:01:13
+966,"@@ -658,6 +658,18 @@ module.exports = class Dashboard extends Plugin {
+     }
+   }
+ 
++  handleRestored = () => {
++    // Hide and show files to trigger re-render, so that
++    // VirtualList mounts FileItems again and they emit `thumbnail:request`
++    // Otherwise thumbnails are broken or missing after Golden Retriever restores files
++    if (this.opts.showSelectedFiles) {
++      this.setOptions({ showSelectedFiles: false })
++      setTimeout(() => {
++        this.setOptions({ showSelectedFiles: true })
++      }, 4)
++    }
++  }
++",@goto-bus-stop is there a more sane way to trigger re-render of VirtualList to get thumnails re-created? 🤔 ,2020-12-18 12:40:15
+675,"@@ -66,8 +66,10 @@ en_US.strings = {
+   loading: 'Loading...',
+   logOut: 'Log out',
+   myDevice: 'My Device',
++  noDuplicates: 'Cannot add the duplicate file %{fileName}, it already exists',",this one should also have quotes i guess :),2020-02-10 09:56:45
+477,"@@ -675,7 +675,7 @@ a.uppy-Dashboard-poweredBy {
+     float: left;
+     margin: 5px $rl-margin;
+     width: calc(33.333% - #{$rl-margin} - #{$rl-margin});
+-    height: 200px;
++    height: 216px;","```suggestion
+    height: 215px;
+```
+",2019-05-24 09:45:49
+785,"@@ -68,10 +69,15 @@ module.exports = class Dashboard extends Plugin {
+         saveChanges: 'Save changes',
+         cancel: 'Cancel',
+         myDevice: 'My Device',
+-        dropPaste: 'Drop files here, paste or %{browse}',
+-        dropPasteImport: 'Drop files here, paste, %{browse} or import from:',
++        dropPasteFiles: enUS.dropPasteFiles,
++        dropPasteFolders: enUS.dropPasteFolders,
++        dropPasteBoth: enUS.dropPasteBoth,
++        dropPasteImportFiles: enUS.dropPasteImportFiles,
++        dropPasteImportFolders: enUS.dropPasteImportFolders,
++        dropPasteImportBoth: enUS.dropPasteImportBoth,","The `@uppy/locales/en_US` file is generated from the default strings in all the plugins, so they should actually be written out here instead of in `en_US.js`. You can then run `npm run build:locale-pack` to update the en_US file.",2020-06-24 11:25:26
+440,"@@ -68,6 +73,10 @@ module.exports = function Dashboard (props) {
+           }
+ 
+         <div class=""uppy-Dashboard-innerWrap"">
++          <div class=""uppy-Dashboard-drop-files-here-hint"">
++            {props.i18n('dropHint')}",Tiny style nitpick: I’d call it `uppy-Dashboard-dropFilesHereHint`.,2019-04-16 14:34:34
+532,"@@ -68,7 +68,7 @@ svg.UppyIcon.retry {
+ }
+ 
+ 
+-// Svg styles that depend upon the state of the file.",Seems grammatically there’s no difference? https://english.stackexchange.com/questions/34291/depend-upon-or-depend-on ;),2019-06-27 16:32:36
+799,"@@ -681,6 +681,8 @@ module.exports = class Tus extends Plugin {
+     this.uppy.on('reset-progress', this.handleResetProgress)
+ 
+     if (this.opts.autoRetry) {
++      this.uppy.log('[Tus] The `autoRetry` option may be removed in Uppy 2.0. See https://github.com/transloadit/uppy/pull/2347 for alternatives.', 'warning')",maybe not do this because autoretry is the default,2020-06-29 15:26:39
+259,"@@ -69,13 +70,16 @@ module.exports = class FileInput extends Plugin {
+       zIndex: -1
+     }
+ 
++    const restrictions = this.uppy.opts.restrictions
++
+     return <div class=""uppy uppy-FileInput-container"">
+       <input class=""uppy-FileInput-input""
+         style={this.opts.pretty && hiddenInputStyle}
+         type=""file""
+         name={this.opts.inputName}
+         onchange={this.handleInputChange}
+-        multiple={this.opts.allowMultipleFiles}
++        multiple={restrictions.maxNumberOfFiles !== 1 || !restrictions.maxNumberOfFiles}",and here,2018-05-09 15:52:09
+358,"@@ -69,6 +70,14 @@ const photoUploader = Uppy({ id: 'post' })
+ 
+ By default Uppy will wait for an upload button to be pressed in the UI, or an `.upload()` method to be called, before starting an upload. Setting this to `autoProceed: true` will start uploading automatically after the first file is selected.
+ 
++### `allowMultipleUploads: true`
++
++Whether to allow multiple upload batches. This means multiple calls to `.upload()`, or a user pressing an upload button multiple times, perhaps after adding more files. An upload batch is made up of the files that were added since the previous `.upload()` call.
++","All makes sense when I read twice, but might still be a liiittle confusing, if one doesn’t know about Uppy’s internals, the option could be called `allowAddingMoreFilesAfterUploadStarted`, right? Not suggesting the crazy name, but trying to think how to indicate that this is what it means right away.",2018-10-03 21:52:13
+815,"@@ -69,6 +70,7 @@ en_US.strings = {
+   noFilesFound: 'You have no files or folders here',
+   noInternetConnection: 'No Internet connection',
+   noNewAlreadyUploading: 'Cannot add new files: already uploading',
++  noRecentFilesFound: 'No files or folders found from the last %{months_retrieved} months',",do we still need these as well? 🤔 ,2020-07-09 17:27:09
+540,"@@ -69,7 +69,8 @@ module.exports = class Webcam extends Plugin {
+         'picture'
+       ],
+       mirror: true,
+-      facingMode: 'user'
++      facingMode: 'user',
++      preferredMimeType: null","Since this is for video only, should it be called `preferredVideoMimeType`? If we add it for pictures later, it will likely need to be a different option.",2019-07-05 11:58:08
+92,"@@ -699,12 +699,15 @@ class Uppy {
+   * @param {string} msg Message to be displayed by the informer
+   */
+ 
+-  info (msg, type, duration) {
++  info (message, type, duration) {
++    const isComplexMessage = typeof message === 'object'
++
+     this.setState({
+       info: {
+         isHidden: false,
+-        type: type,
+-        msg: msg
++        type: type || 'info',
++        message: isComplexMessage ? message.msg : message,",Should the message object also be `message.message` instead of `message.msg`? I like it written out.,2017-08-28 08:03:26
+363,"@@ -7,10 +7,13 @@ const mimeToExtensions = {
+   'audio/ogg': 'ogg',
+   'video/webm': 'webm',
+   'audio/webm': 'webm',
++  'video/x-matroska': 'mkv',
+   'video/mp4': 'mp4',
+   'audio/mp3': 'mp3'
+ }
+ 
+ module.exports = function getFileTypeExtension (mimeType) {
++  // Remove the ; bit in 'video/x-matroska;codecs=avc1'
++  mimeType = mimeType.replace(/;.*$/, '')
+   return mimeToExtensions[mimeType] || null","Feels like a case-specific solution, but I guess it’s standard to use `;` in this case, so it’ll work for others as well?",2018-10-08 13:53:54
+645,"@@ -7,15 +7,27 @@
+  *
+  */
+ module.exports = function generateFileID (file) {
+-  // filter is needed to not join empty values with `-`
+-  return [
+-    'uppy',
+-    file.name ? encodeFilename(file.name.toLowerCase()) : '',
+-    file.type,
+-    file.meta && file.meta.relativePath ? encodeFilename(file.meta.relativePath.toLowerCase()) : '',
+-    file.data.size,
+-    file.data.lastModified
+-  ].filter(val => val).join('-')
++  let id = 'uppy'
++  if (typeof file.name === 'string') {
++    id += '-' + encodeFilename(file.name.toLowerCase())
++  }
++
++  if (file.type !== undefined) {
++    id += '-' + file.type
++  }
++
++  if (file.meta && typeof file.meta.relativePath === 'string') {
++    id += '-' + encodeFilename(file.meta.relativePath.toLowerCase())
++  }
++
++  if (file.data.size !== undefined) {
++    id += '-' + file.data.size
++  }
++  if (file.data.lastModified !== undefined) {
++    id += '-' + file.data.lastModified
++  }
++
++  return id","Wow, impressive it's faster than the previous solution!
+Maybe let's add a comment explaining why we went for this solution? I imagine I'd look at it and try to rewrite it in a more concise way.",2019-12-01 16:06:48
+77,"@@ -7,23 +7,48 @@ const _getName = (id) => {
+ }
+ 
+ module.exports = class Provider {
+-  constructor (opts) {
++  constructor (core, opts) {
++    this.core = core
+     this.opts = opts
+     this.provider = opts.provider
+     this.id = this.provider
+     this.authProvider = opts.authProvider || this.provider
+     this.name = this.opts.name || _getName(this.id)
++
++    this.onReceiveResponse = this.onReceiveResponse.bind(this)
++  }
++
++  get hostname () {
++    const uppyServer = this.core.state.uppyServer || {}
++    const host = this.opts.host
++    return uppyServer[host] || host
++  }
++
++  onReceiveResponse (response) {
++    const uppyServer = this.core.state.uppyServer || {}
++    const host = this.opts.host
++    const headers = response.headers
++    // Store the self-identified domain name for the uppy-server we just hit.
++    if (headers.has('i-am') && headers.get('i-am') !== uppyServer[host]) {
++      this.core.setState({
++        uppyServer: Object.assign({}, uppyServer, {
++          [host]: headers.get('i-am')
++        })
++      })","The `uppyServer` state key is an object of `[original_hostname]: new_hostname` pairs, in case someone does something like
+
+```js
+uppy.use(GoogleDrive, { host: 'google.my-uppy-server.com' })
+uppy.use(Dropbox, { host: 'dropbox.my-uppy-server.com' })
+```
+
+It seems unlikely that anyone would use different uppy-servers for different plugins, but it's _possible_, so this supports it.",2017-07-21 09:54:13
+333,"@@ -7,33 +7,32 @@ set -o nounset
+ # Set magic variables for current FILE & DIR
+ __dir=""$(cd ""$(dirname ""${BASH_SOURCE[0]}"")"" && pwd)""
+ __kube=""${__dir}""
++__companion=""$(dirname ""$(dirname ""${__kube}"")"")""
++# Install kubectl
++curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl",Shall we pin the currently used kubectl and hence make version bumps opt-in vs organic?,2018-08-17 05:14:15
+334,"@@ -7,33 +7,32 @@ set -o nounset
+ # Set magic variables for current FILE & DIR
+ __dir=""$(cd ""$(dirname ""${BASH_SOURCE[0]}"")"" && pwd)""
+ __kube=""${__dir}""
++__companion=""$(dirname ""$(dirname ""${__kube}"")"")""
++# Install kubectl
++curl -LO https://storage.googleapis.com/kubernetes-release/release/$(curl -s https://storage.googleapis.com/kubernetes-release/release/stable.txt)/bin/linux/amd64/kubectl
++chmod +x ./kubectl
++mkdir ${HOME}/.local/bin/
++export PATH=""${HOME}/.local/bin/:$PATH""
++mv ./kubectl ${HOME}/.local/bin/
++
+ 
+ # Store the new image in docker hub
+-docker build --quiet -t transloadit/companion:latest -t transloadit/companion:$TRAVIS_COMMIT .;
++docker build -t kiloreux/uppy-companion:latest -t kiloreux/uppy-companion:$TRAVIS_COMMIT -f packages/@uppy/companion/Dockerfile packages/@uppy/companion;",Transloadit,2018-08-17 05:14:36
+508,"@@ -7,57 +7,73 @@ class FileCard extends Component {
+   constructor (props) {
+     super(props)
+ 
+-    this.meta = {}
++    this.state = {}
+ 
+-    this.tempStoreMetaOrSubmit = this.tempStoreMetaOrSubmit.bind(this)
++    this.tempStoreMeta = this.tempStoreMeta.bind(this)
++    this.saveOnEnter = this.saveOnEnter.bind(this)
+     this.renderMetaFields = this.renderMetaFields.bind(this)
+     this.handleSave = this.handleSave.bind(this)
+     this.handleCancel = this.handleCancel.bind(this)
+   }
+ 
+-  tempStoreMetaOrSubmit (ev) {
++  componentDidMount () {
+     const file = this.props.files[this.props.fileCardFor]
++    const metaFields = this.props.metaFields || []
++
++    const storedMetaData = {}
++    metaFields.forEach((field) => {
++      storedMetaData[field.id] = file.meta[field.id]
++    })
++    this.setState(storedMetaData)
++  }
+ 
++  saveOnEnter (ev) {
+     if (ev.keyCode === 13) {
++      const file = this.props.files[this.props.fileCardFor]
+       ev.stopPropagation()
+       ev.preventDefault()
+-      this.props.saveFileCard(this.meta, file.id)
+-      return
++      this.props.saveFileCard(this.state, file.id)
+     }
++  }
+ 
++  tempStoreMeta (ev) {
+     const value = ev.target.value
+     const name = ev.target.dataset.name
+-    this.meta[name] = value
++    this.setState({
++      [name]: value
++    })
++  }
++
++  handleSave (ev) {
++    const fileID = this.props.fileCardFor
++    this.props.saveFileCard(this.state, fileID)
++  }
++
++  handleCancel (ev) {
++    this.setState({})","note this is a noop, it doesn't actually clear state",2019-06-12 08:02:14
+511,"@@ -7,57 +7,73 @@ class FileCard extends Component {
+   constructor (props) {
+     super(props)
+ 
+-    this.meta = {}
++    this.state = {}
+ 
+-    this.tempStoreMetaOrSubmit = this.tempStoreMetaOrSubmit.bind(this)
++    this.tempStoreMeta = this.tempStoreMeta.bind(this)
++    this.saveOnEnter = this.saveOnEnter.bind(this)
+     this.renderMetaFields = this.renderMetaFields.bind(this)
+     this.handleSave = this.handleSave.bind(this)
+     this.handleCancel = this.handleCancel.bind(this)
+   }
+ 
+-  tempStoreMetaOrSubmit (ev) {
++  componentDidMount () {
+     const file = this.props.files[this.props.fileCardFor]
++    const metaFields = this.props.metaFields || []
++
++    const storedMetaData = {}
++    metaFields.forEach((field) => {
++      storedMetaData[field.id] = file.meta[field.id]
++    })
++    this.setState(storedMetaData)
++  }
+ 
++  saveOnEnter (ev) {
+     if (ev.keyCode === 13) {
++      const file = this.props.files[this.props.fileCardFor]
+       ev.stopPropagation()
+       ev.preventDefault()
+-      this.props.saveFileCard(this.meta, file.id)
+-      return
++      this.props.saveFileCard(this.state, file.id)
+     }
++  }
+ 
++  tempStoreMeta (ev) {
+     const value = ev.target.value
+     const name = ev.target.dataset.name
+-    this.meta[name] = value
++    this.setState({
++      [name]: value
++    })
++  }
++
++  handleSave (ev) {
++    const fileID = this.props.fileCardFor
++    this.props.saveFileCard(this.state, fileID)
++  }
++
++  handleCancel (ev) {
++    this.setState({})
++    this.props.toggleFileCard()
+   }
+ 
+   renderMetaFields (file) {
+     const metaFields = this.props.metaFields || []
++
+     return metaFields.map((field, i) => {
+       return <fieldset class=""uppy-DashboardFileCard-fieldset"">
+         <label class=""uppy-DashboardFileCard-label"">{field.name}</label>
+         <input class=""uppy-u-reset uppy-c-textInput uppy-DashboardFileCard-input""
+           type=""text""
+           data-name={field.id}","Maybe let's not use `data-name` attribute, we could instead use `oninput={(event) => this.tempStoreMeta(event, field.id)}`, that looks more react-like?",2019-06-12 09:25:23
+991,"@@ -7,6 +7,11 @@ module.exports = class Editor extends Component {
+       this.imgElement,
+       this.props.opts.cropperOptions
+     )
++    this.imgElement.addEventListener('crop', (ev) => {
++      this.rotateRange.value = ev.detail.rotate
++      this.rotateRange.parentNode
++        .setAttribute('aria-label', `${ev.detail.rotate}º`)","Would these be feasible to do using react state updates, vs updating the dom directly?",2021-03-31 09:48:48
+352,"@@ -7,6 +7,8 @@ function DashboardContentTitle (props) {
+ }
+ 
+ function PanelTopBar (props) {
++  const notOverFileLimit = props.maxNumberOfFiles !== props.totalFileCount",`props.totalFileCount < props.maxNumberOfFiles` makes the intent a bit more clear I think. And a check to see if maxNumberOfFiles even exists?,2018-09-20 09:35:40
+28,"@@ -7,7 +7,7 @@ module.exports = (props) => {
+       <h1 class=""UppyProvider-authTitle"">
+         Please authenticate with <span class=""UppyProvider-authTitleName"">${props.pluginName}</span><br> to select files
+       </h1>
+-      <a class=""UppyProvider-authBtn"" href=${props.link} target=""_blank"">Authenticate</a>
++      <a class=""UppyProvider-authBtn"" onclick=${props.handleAuth}>Authenticate</a>","🤔 Since this is not a link now, semantically we could turn it into a `<button>`, making sure to include `@include reset-button` in its style declaration in SCSS, which will reset all sorts of browser default button styles.",2017-01-27 23:08:35
+493,"@@ -7,7 +7,9 @@
+     ""sourceMap"": false,
+     ""allowJs"": true,
+     ""checkJs"": true,
+-    ""noEmitOnError"": true
++    ""noEmitOnError"": true,
++    ""resolveJsonModule"": true,
++    ""esModuleInterop"": true","I suspect this could be the issue to failing Travis tests, since Companion’s `lib` folder is now built weirdly locally for me.
+
+Do we have any tests that test the `lib` folder of Companion, how it’s used when installed from `npm`?",2019-05-30 12:18:34
+194,"@@ -700,12 +705,14 @@ module.exports = class Transloadit extends Plugin {
+       this.uppy.on('transloadit:complete', onAssemblyFinished)
+       this.uppy.on('transloadit:assembly-error', onAssemblyError)
+       this.uppy.on('transloadit:import-error', onImportError)
+-    }).then(() => {
++    }).then((result) => {","So still returning the result, but not using it?",2018-01-22 22:07:33
+476,"@@ -702,13 +702,14 @@ a.uppy-Dashboard-poweredBy {
+   height: 50px;
+   border-bottom: 0;
+   position: relative;
++  flex-shrink: 0;
+   display: flex;
+   justify-content: center;
+   align-items: center;
+ 
+   .uppy-size--md & {
+     width: 100%;
+-    height: 139px;
++    height: 152px;","```suggestion
+    height: 140px;
+```
+",2019-05-24 09:41:09
+473,"@@ -707,7 +707,7 @@ a.uppy-Dashboard-poweredBy {
+ 
+   .uppy-size--md & {
+     width: 100%;
+-    height: 100px;
++    height: 129px;
+     border: 0;","`129px` vs `130px`? I’m guessing there’s a reason, that’s why I’m asking, so I can keep that in the back of my head for future refactors.",2019-05-23 07:27:32
+775,"@@ -71,8 +72,7 @@ const get = (req, res) => {
+       res.status(response.status).json(response.body)
+     }).catch((err) => {
+       logger.error(err, 'controller.url.get.error', req.id)
+-      // @todo this should send back error (not err)
+-      res.json({ err })
++      return res.status(err.status || 500).json({ message: 'failed to fetch URL metadata' })",is this OK for old clients or do we need to check the uppy version and decide to use the old or new response style?,2020-05-18 11:13:04
+107,"@@ -719,36 +719,61 @@ describe('src/Core', () => {
+ 
+   describe('actions', () => {})
+ 
+-  describe('isOnline', () => {
+-    xit('should detect if the browser is online or not', () => {})
+-
+-    xit(
+-      'should emit the correct event when the online status is specified',
+-      () => {
+-        const onlineEventMock = jest.fn()
+-        const offlineEventMock = jest.fn()
+-        const backOnlineEventMock = jest.fn()
+-        const core = new Core()
+-        core.on('is-offline', offlineEventMock)
+-        core.on('is-online', onlineEventMock)
+-        core.on('back-online', backOnlineEventMock)
+-
+-        core.isOnline(true)
+-        expect(onlineEventMock.mock.calls.length).toEqual(1)
+-        expect(offlineEventMock.mock.calls.length).toEqual(0)
+-        expect(backOnlineEventMock.mock.calls.length).toEqual(0)
+-
+-        core.isOnline(false)
+-        expect(onlineEventMock.mock.calls.length).toEqual(1)
+-        expect(offlineEventMock.mock.calls.length).toEqual(1)
+-        expect(backOnlineEventMock.mock.calls.length).toEqual(0)
+-
+-        core.isOnline(true)
+-        expect(onlineEventMock.mock.calls.length).toEqual(2)
+-        expect(offlineEventMock.mock.calls.length).toEqual(1)
+-        expect(backOnlineEventMock.mock.calls.length).toEqual(1)
+-      }
+-    )
++  describe('updateOnlineStatus', () => {
++    const RealNavigatorOnline = global.window.navigator.onLine
++
++    beforeEach(() => {
++      Object.defineProperty(
++        global.window.navigator,
++        'onLine',
++        (function (_value) {
++          return {
++            get: function _get () {
++              return _value
++            },
++            set: function _set (v) {
++              _value = v
++            }
++          }
++        })(global.window.navigator.onLine)","would this also work without the IIFE, with the `_value` as a simple variable inside `beforeEach()`? i think that would be a bit clearer.",2017-09-11 13:26:19
+229,"@@ -72,11 +72,16 @@ uppy.setFileState(otherFileID, {
+ 
+ ### `getResponseData(xhr)`
+ 
+-When an upload has completed, Uppy will extract response data from the upload endpoint and send it back in the `upload-success` event:
++When an upload has completed, Uppy will extract response data from the upload endpoint. This response data will be available on the file's `.response` property, and be emitted in the `upload-success` event:
+ 
+ ```js
+-uppy.on('upload-success', (fileId, resp, uploadURL) => {
+-  // do something with resp
++uppy.getFile(fileID).response
++// { status: HTTP status code,
++//   body: extracted response data }
++
++uppy.on('upload-success', (fileID, body) => {
++  // do something with extracted response data","`file` here too, instead of `fileID`?",2018-02-18 02:57:30
+610,"@@ -726,3 +726,13 @@ uppy.on('restriction-failed', (file, error) => {
+   // do some customized logic like showing system notice to users
+ })
+ ```
++
++### `reset-progress`
++
++Fired when `uppy.resetProgress()` is called, `totalProgress` and each file has its upload progress reset to zero.","I think we can avoid mentioning `totalProgress` which is otherwise undocumented:
+```suggestion
+Fired when `uppy.resetProgress()` is called and each file has its upload progress reset to zero.
+```
+
+(in the future we could add a `uppy.getTotalProgress()` method to provide a more official way to get to that data)",2019-11-04 09:30:59
+985,"@@ -73,15 +75,41 @@ exports.loadSearchProviderToken = (req, res, next) => {
+   next()
+ }
+ 
+-exports.mergeAccessControlAllowMethods = (req, res, next) => {
+-  const existingHeader = res.get('Access-Control-Allow-Methods')
+-  let existingMethods = []
+-  if (existingHeader) {
+-    existingMethods = existingHeader.replace(/\s/g, '').split(',').map((method) => method.toUpperCase())
++exports.cors = (options = {}) => (req, res, next) => {
++  const exposedHeaders = [
++    // exposed so it can be accessed for our custom uppy client preflight
++    'Access-Control-Allow-Headers',
++  ]
++  if (options.sendSelfEndpoint) exposedHeaders.push('i-am')
++  if (res.get('Access-Control-Expose-Headers')) exposedHeaders.push(res.get('Access-Control-Expose-Headers'))
++
++  const allowedHeaders = [
++    'uppy-auth-token',
++    'uppy-versions',
++    'uppy-credentials-params',
++  ]
++  if (res.get('Access-Control-Allow-Headers')) allowedHeaders.push(res.get('Access-Control-Allow-Headers'))
++
++  const existingAllowMethodsHeader = res.get('Access-Control-Allow-Methods')
++  let methods = []
++  if (existingAllowMethodsHeader) {
++    methods = existingAllowMethodsHeader.replace(/\s/g, '').split(',').map((method) => method.toUpperCase())
+   }
++  methods = uniq([...methods, 'GET', 'POST', 'OPTIONS', 'DELETE'])
+ 
+-  const mergedMethods = uniq([...existingMethods, 'GET', 'POST', 'OPTIONS', 'DELETE'])
++  // if endpoint urls are specified, then we only allow those endpoints
++  // otherwise, we allow any client url to access companion.","```suggestion
+  // If endpoint urls are specified, then we only allow those endpoints.
+  // Otherwise, we allow any client url to access companion.
+```
+
+maybe like this?",2021-03-22 16:22:50
+78,"@@ -73,9 +72,12 @@ class Uppy {
+     this.addFile = this.addFile.bind(this)
+     this.calculateProgress = this.calculateProgress.bind(this)
+ 
+-    this.bus = this.emitter = ee()
+-    this.on = this.bus.on.bind(this.bus)
+-    this.emit = this.bus.emit.bind(this.bus)
++    // this.bus = this.emitter = ee()
++    this.emitter = ee()
++    this.on = this.emitter.on.bind(this.emitter)
++    this.off = this.emitter.off.bind(this.emitter)
++    this.once = this.emitter.once.bind(this.emitter)
++    this.emit = this.emitter.emit.bind(this.emitter)",👍 🙌 ✅ ✔️ ☑️ ,2017-07-24 16:40:33
+961,"@@ -733,8 +734,12 @@ class Uppy {
+ 
+     this.setState({ files })
+ 
+-    newFiles.forEach((newFile) => {
++    newFiles.forEach((newFile, i) => {
+       this.emit('file-added', newFile)
++
++      if (i + 1 === newFiles.length) {
++        this.emit('final-file-added', newFile)
++      }","I think `final-file-added` event looks geared towards a very particular use case, and could be more general. I'd expect it's pretty rare that a developer actually wants to receive only the last file in a particular set that the user added at once. We could instead give them access to the whole list of newly added files. Perhaps like this:
+
+```js
+this.emit('files-added', newFiles)
+```
+
+This still allows you to do the same thing as final-file-added:
+```js
+uppy.on('files-added', (list) => {
+  const last = list[list.length - 1]
+})
+```
+but also _more_ things.",2020-12-09 16:07:05
+764,"@@ -743,9 +743,8 @@ module.exports = class Transloadit extends Plugin {
+ 
+   _onTusError (err) {
+     if (err && /^tus: /.test(err.message)) {
+-      const url = err.originalRequest && err.originalRequest.responseURL
+-        ? err.originalRequest.responseURL
+-        : null
++      const xhr = err.originalRequest ? err.originalRequest.getUnderlyingObject() : null
++      const url = xhr && xhr.responseURL ? xhr.responseURL : null","tus-js-client v2 introduces a HTTP abstraction layer, so the code to access the URL is a bit different now.",2020-05-04 13:21:46
+185,"@@ -75,6 +75,7 @@ module.exports = class Dashboard extends Plugin {
+       defaultTabIcon: defaultTabIcon,
+       showProgressDetails: false,
+       hideUploadButton: false,
++      hideProgressAfterFinish: false,",The docs should also be updated with the new option.,2018-01-01 22:41:52
+226,"@@ -75,6 +76,19 @@ By default Dashboard will be rendered as a modal, which is opened via clicking o
+ 
+ String with a CSS selector for a button that will trigger opening Dashboard modal. Multiple buttons or links can be used, if it’s a class selector (`.uppy-choose`, for example).
+ 
++### `plugins: []`
++
++List of plugin IDs that should be shown in the Dashboard's top bar. For example, to show the Webcam plugin:
++",Wouldn’t you be able to install StatusBar or similar the same way? So its not just for `acquire` plugins?,2018-02-13 17:36:29
+514,"@@ -75,9 +80,45 @@ module.exports = class RequestClient {
+     return res.json()
+   }
+ 
++  preflight (path) {
++    return new Promise((resolve, reject) => {
++      if (this.preflightDone) {
++        return resolve(this.allowedHeaders.slice())
++      }
++
++      fetch(this._getUrl(path), {
++        method: 'OPTIONS'","I'm actually getting an error on this because `OPTIONS` is not in the CORS whitelist …
+![image](https://user-images.githubusercontent.com/1006268/59565599-fba49d00-9055-11e9-934f-bd9171b4d8d5.png)
+
+Request headers:
+![image](https://user-images.githubusercontent.com/1006268/59565601-02331480-9056-11e9-9713-74fc66592a27.png)
+
+Response headers:
+![image](https://user-images.githubusercontent.com/1006268/59565607-0f500380-9056-11e9-9a3e-4452b6aa25fc.png)
+
+If this is the case we may need a new separate endpoint that we can just GET after all :(",2019-06-16 14:44:56
+489,"@@ -75,9 +80,48 @@ module.exports = class RequestClient {
+     return res.json()
+   }
+ 
++  preflight (path) {
++    return new Promise((resolve, reject) => {
++      if (this.preflightDone) {
++        return resolve(this.allowedHeaders.slice())
++      }
++
++      fetch(this._getUrl(path), {
++        method: 'OPTIONS'
++      })
++        .then((response) => {
++          if (response.headers.has('access-control-allow-headers')) {
++            const allowedHeaders = response.headers.get('access-control-allow-headers')
++              .split(',').map((headerName) => headerName.trim().toLowerCase())
++            this.allowedHeaders = this.allowedHeaders.concat(allowedHeaders)","Why concat, why not just set the array?",2019-05-29 17:15:57
+490,"@@ -75,9 +80,48 @@ module.exports = class RequestClient {
+     return res.json()
+   }
+ 
++  preflight (path) {
++    return new Promise((resolve, reject) => {
++      if (this.preflightDone) {
++        return resolve(this.allowedHeaders.slice())
++      }
++
++      fetch(this._getUrl(path), {
++        method: 'OPTIONS'
++      })
++        .then((response) => {
++          if (response.headers.has('access-control-allow-headers')) {
++            const allowedHeaders = response.headers.get('access-control-allow-headers')
++              .split(',').map((headerName) => headerName.trim().toLowerCase())
++            this.allowedHeaders = this.allowedHeaders.concat(allowedHeaders)
++          }
++          this.preflightDone = true
++          resolve(this.allowedHeaders.slice())
++        })
++        .catch(reject)
++    })
++  }
++
++  preflightAndHeaders (path) {
++    return new Promise((resolve, reject) => {
++      this.preflight(path).then((allowedHeaders) => {
++        this.headers().then((headers) => {
++          // filter to keep only allowed Headers
++          Object.keys(headers).forEach((header) => {
++            if (allowedHeaders.indexOf(header.toLowerCase()) === -1) {
++              delete headers[header]",I think a console.log(“refraining from sending header x as cors would reject it”) will save us some head scratching later on,2019-05-29 17:17:21
+497,"@@ -75,9 +80,48 @@ module.exports = class RequestClient {
+     return res.json()
+   }
+ 
++  preflight (path) {
++    return new Promise((resolve, reject) => {
++      if (this.preflightDone) {
++        return resolve(this.allowedHeaders.slice())
++      }
++
++      fetch(this._getUrl(path), {
++        method: 'OPTIONS'
++      })
++        .then((response) => {
++          if (response.headers.has('access-control-allow-headers')) {
++            this.allowedHeaders = response.headers.get('access-control-allow-headers')
++              .split(',').map((headerName) => headerName.trim().toLowerCase())
++          }
++          this.preflightDone = true
++          resolve(this.allowedHeaders.slice())
++        })
++        .catch(reject)
++    })
++  }
++
++  preflightAndHeaders (path) {
++    return new Promise((resolve, reject) => {","This promise chain would really benefit from being flatter I think…
+
+Right now the `this.headers()` call does not have a catch(reject) handler.
+
+we could have something like:
+
+```js
+return Promise.all([
+  this.preflight(path),
+  this.headers()
+]).then(([allowedHeaders, headers]) => {
+  // filter to keep only allowed Headers
+  Object.keys(headers).forEach((header) => {
+    if (allowedHeaders.indexOf(header.toLowerCase()) === -1) {
+      this.uppy.log(`[CompanionClient] excluding unallowed header ${header}`)
+      delete headers[header]
+    }
+  })
+})
+```",2019-06-05 13:53:16
+538,"@@ -76,13 +76,19 @@ class Uppy {
+       meta: {},
+       onBeforeFileAdded: (currentFile, files) => currentFile,
+       onBeforeUpload: (files) => files,
+-      store: DefaultStore()
++      store: DefaultStore(),
++      logger: nullLogger
+     }
+ 
+     // Merge default options with the ones set by user
+     this.opts = Object.assign({}, defaultOptions, opts)
+     this.opts.restrictions = Object.assign({}, defaultOptions.restrictions, this.opts.restrictions)
+ 
++    // Support debug: true for backwards-compatability
++    if (this.opts.debug) {","If you already set a custom logger, but also debug:true should we refrain? throw a warning/error?",2019-07-03 15:33:59
+541,"@@ -76,13 +76,22 @@ class Uppy {
+       meta: {},
+       onBeforeFileAdded: (currentFile, files) => currentFile,
+       onBeforeUpload: (files) => files,
+-      store: DefaultStore()
++      store: DefaultStore(),
++      logger: nullLogger
+     }
+ 
+     // Merge default options with the ones set by user
+     this.opts = Object.assign({}, defaultOptions, opts)
+     this.opts.restrictions = Object.assign({}, defaultOptions.restrictions, this.opts.restrictions)
+ 
++    // Support debug: true for backwards-compatability, unless logger is set in opts
++    // opts instead of this.opts to avoid comparing objects — we set logger: nullLogger in defaultOptions
++    if (opts && opts.logger && opts.debug) {
++      this.log('You are using a custom `logger`, but also set `debug: true`, which uses built-in logger to output logs to console. Ignoring `debug: true` and using your custom `logger`.', 'warning')
++    } else if (opts && opts.debug) {
++      this.opts.logger = debugLogger
++    }",@goto-bus-stop does the condition above look on to you? :),2019-07-05 13:02:36
+126,"@@ -76,48 +76,40 @@ module.exports = class Dropbox extends Plugin {
+   }
+ 
+   isFolder (item) {
+-    return item.is_dir
++    return item['.tag'] === 'folder'
+   }
+ 
+   getItemData (item) {
+-    return Object.assign({}, item, {size: item.bytes})
++    return item
+   }
+ 
+   getItemIcon (item) {
+-    var icon = icons[item.icon]
+-
+-    if (!icon) {
+-      if (item.icon.startsWith('folder')) {
+-        icon = icons['folder']
+-      } else {
+-        icon = icons['page_white']
+-      }
+-    }
+-    return icon()
++    return icons[item['.tag']]()
+   }
+ 
+   getItemSubList (item) {
+-    return item.contents
++    return item.entries
+   }
+ 
+   getItemName (item) {
+-    return item.path.length > 1 ? item.path.substring(1) : item.path
++    return item.name || ''",Is this ever empty in the API?,2017-10-16 08:12:36
+950,"@@ -767,6 +767,22 @@ uppy.on('upload', (data) => {
+ })
+ ```
+ 
++### `progress`
++
++Fired each time the total upload progress is updated:
++
++**Parameters**
++- `progress` - An integer representing the total upload progress.","```suggestion
+- `progress` - An integer (0-100) representing the total upload progress.
+```
+Think it'd be best to stress here that this is 0-100 and not 0.0-1.0, because it's a little unusual.",2020-11-19 14:24:05
+951,"@@ -767,6 +767,22 @@ uppy.on('upload', (data) => {
+ })
+ ```
+ 
++### `progress`
++
++Fired each time the total upload progress is updated:
++
++**Parameters**
++- `progress` - An integer representing the total upload progress.
++
++**Example**
++
++```javascript
++uppy.on('progress', (progress) => {
++  // progress: integer (total progress percentage)
++  console.log(progress)
++})
++```
++
+ ### `upload-progress`
+ 
+ Fired each time file upload progress is available:","```suggestion
+Fired each time an individual file upload progress is available:
+```",2020-11-20 15:11:32
+781,"@@ -77,14 +77,6 @@ jobs:
+         script: bin/travis-deploy-companion
+         on:
+           branch: master
+-    - name: 'Run Companion tests (Node.js 6)'
+-      node_js: 12
+-      services:
+-        - docker
+-      script:
+-        - nvm install 6.0.0
+-        - nvm use 6.0.0
+-        - npm run test:companion",Can we keep this but run it on `node_js: 10.0.0`?,2020-06-08 15:57:40
+910,"@@ -77,6 +78,10 @@ If both width and height are given, only width is taken into account.
+ >
+ > See issue [#979](https://github.com/transloadit/uppy/issues/979) and [#1096](https://github.com/transloadit/uppy/pull/1096) for details on this feature.
+ 
++### `thumbnailtype: 'image/jpeg'`
++
++MIME type of the resulting thumbnail. Default thumbnail MIME type is `image/jpeg`. ","Maybe we should elaborate on why it might be useful to change the MIME type? PNG, transparency.",2020-10-29 13:15:27
+765,"@@ -779,7 +778,7 @@ module.exports = class Transloadit extends Plugin {
+         // were added to the Assembly, so we can properly complete it. All that state is handled by
+         // Golden Retriever. So, Golden Retriever is required to do resumability with the Transloadit plugin,
+         // and we disable Tus's default resume implementation to prevent bad behaviours.
+-        resume: false,
++        storeFingerprintForResuming: false,",The resume option is removed but you want the storeFingerprintForResuming option here if I understand the comment above correctly.,2020-05-04 13:22:13
+556,"@@ -78,26 +78,26 @@ fi_FI.strings = {
+   resume: 'Jatka',
+   resumeUpload: 'Jatka lähetystä',
+   retry: 'Yritä uudelleen',
+-  retryUpload: 'Yritä uudelleen lähetystä',
++  retryUpload: 'Yritä lähetystä uudelleen',
+   saveChanges: 'Tallenna muutokset',
+   selectAllFilesFromFolderNamed: 'Valitse kaikki tiedostot kansiosta %{name}',
+   selectFileNamed: 'Valitse tiedosto %{name}',
+   selectX: {
+-    '0': 'Valitse %{smart_count}',
+-    '1': 'Valitse %{smart_count}',
+-    '2': 'Valitse %{smart_count}'
++    '0': 'Valitse %{smart_count} tiedosto',
++    '1': 'Valitse %{smart_count} tiedostoa',
++    '2': 'Valitse %{smart_count} tiedostoa'","I think this is wrong, because we’ve changed the string to specifically say “select X” instead of “select X files”, because there could also be folders, and we don’t want to make the button extra long.",2019-07-23 20:33:02
+777,"@@ -78,6 +79,12 @@ class TransloaditAssembly extends Emitter {
+ 
+       this.emit('connect')
+     })
++
++    socket.on('connect_failed', () => {
++      this._onError(new NetworkError('Transloadit Socket.io connection error'))
++      this.socket = null
++    })
++","Added handling of socket.io’s `connect_failed`, but should the same be done for WebSocket that we use with Companion @ifedapoolarewaju?",2020-05-27 07:38:59
+122,"@@ -783,25 +783,33 @@ class Uppy {
+   /**
+    * Logs stuff to console, only if `debug` is set to true. Silent in production.
+    *
+-   * @return {String|Object} to log
++   * @param {String|Object} msg to log
++   * @param {String} type optional `error` or `warning`
+    */
+   log (msg, type) {
++    let message = `[Uppy] [${Utils.getTimeStamp()}] ${msg}`
++
++    global.uppyLog = global.uppyLog + '\n' + 'DEBUG LOG: ' + msg","This now always happens, even if opts.debug is false. Is that intentional?",2017-10-02 06:44:50
+260,"@@ -783,6 +813,9 @@ module.exports = class Transloadit extends Plugin {
+         // Disable tus-js-client fingerprinting, otherwise uploading the same file at different times
+         // will upload to the same assembly.
+         resume: false,
++        // Disable Uppy Server's retry optimisation; we need to change the endpoint on retry
++        // so it can't just reuse the same tus.Upload instance server-side.
++        useFastRemoteRetry: false,
+         // Only send assembly metadata to the tus endpoint.","wow, this stuff is getting complex with every feature 😱",2018-05-09 21:18:00
+542,"@@ -79,6 +80,47 @@ With this option set to `true`, users can upload some files, and then add _more_
+ 
+ With this option set to `false`, users can upload some files, and you can listen for the ['complete'](/docs/uppy/#complete) event to continue to the next step in your app's upload flow. A typical use case for this is uploading a new profile picture. If you are integrating with an existing HTML form, this option gives the closest behaviour to a bare `<input type=""file"">`.
+ 
++### `logger`
++
++An object of methods that are called with debug information from [`uppy.log`](/docs/uppy/#uppy-log).
++
++Set `logger: Uppy.debugLogger` to get debug info output to the browser console:
++
++```js
++const Uppy = require('@uppy/core')
++const uppy = Uppy({
++  logger: Uppy.debugLogger
++})
++```
++
++You can also provide your own logger object: it should expose `debug`, `warn` and `error` methods, as shown in the examples below.
++
++By default `logger` is set to `nullLogger`, which does nothing:
++
++```js
++const nullLogger = {
++  debug: (...args) => {},
++  warn: (...args) => {},
++  error: (...args) => {}
++}
++```
++
++`logger: Uppy.debugLogger` looks like this:
++
++```js
++const debugLogger = {
++  debug: (...args) => {
++    // IE 10 doesn’t support console.debug
++    const debug = console.debug || console.log
++    debug.call(console, `[Uppy] [${getTimeStamp()}]`, ...args)
++  },
++  warn: (...args) => console.warn(`[Uppy] [${getTimeStamp()}]`, ...args),
++  error: (...args) => console.error(`[Uppy] [${getTimeStamp()}]`, ...args)
++}
++```
++
++By providing your own `logger`, you can send the debug information to a server, choose to log errors only, etc.
++","another look on the docs would be useful, too, please @goto-bus-stop ",2019-07-05 13:29:53
+26,"@@ -8,12 +8,12 @@ export default class Provider {
+   constructor (opts) {
+     this.opts = opts
+     this.provider = opts.provider
+-    this.id = this.provider
++    this.id = opts.id || this.provider","in case you want to rename one of the plugins when instantiating, from options?",2016-12-20 05:35:00
+636,"@@ -8,14 +8,27 @@
+  */
+ module.exports = function generateFileID (file) {
+   // filter is needed to not join empty values with `-`","Filter is not used now, comment not needed?",2019-11-26 15:32:13
+552,"@@ -8,6 +8,59 @@
+   },
+   ""pre-commit"": ""lint:staged"",
+   ""license"": ""MIT"",
++  ""dependencies"": {
++    ""@uppy-example/aws-companion"": ""file:examples/aws-companion"",
++    ""@uppy-example/aws-presigned-url"": ""file:examples/aws-presigned-url"",
++    ""@uppy-example/bundled"": ""file:examples/bundled"",
++    ""@uppy-example/cdn-example"": ""file:examples/cdn-example"",
++    ""@uppy-example/custom-provider"": ""file:examples/custom-provider"",
++    ""@uppy-example/dev"": ""file:examples/dev"",
++    ""@uppy-example/digitalocean-spaces"": ""file:examples/digitalocean-spaces"",
++    ""@uppy-example/multiple-instances"": ""file:examples/multiple-instances"",
++    ""@uppy-example/node-xhr"": ""file:examples/node-xhr"",
++    ""@uppy-example/php-xhr"": ""file:examples/php-xhr"",
++    ""@uppy-example/python-xhr"": ""file:examples/python-xhr"",
++    ""@uppy-example/react-example"": ""file:examples/react-example"",
++    ""@uppy-example/react-native-expo"": ""file:examples/react-native-expo"",
++    ""@uppy-example/redux"": ""file:examples/redux"",
++    ""@uppy-example/transloadit"": ""file:examples/transloadit"",
++    ""@uppy-example/transloadit-textarea"": ""file:examples/transloadit-textarea"",
++    ""@uppy-example/uppy-with-companion"": ""file:examples/uppy-with-companion"",
++    ""@uppy-example/xhr-bundle"": ""file:examples/xhr-bundle"",",Are these `@uppy-example`s here so that we don’t have to add them to Lerna config?,2019-07-15 14:17:56
+555,"@@ -8,7 +8,7 @@ const Dropbox = require('@uppy/dropbox')
+ const Tus = require('@uppy/tus')
+ 
+ const isOnTravis = !!(process.env.TRAVIS && process.env.CI)
+-const companionUrl = isOnTravis ? 'http://companion.test:3030' : 'http://localhost:3030'
++const companionUrl = isOnTravis ? 'http://companion.test:3030' : 'http://localhost:3020'",wdio runs Companion on :3030. can't we use that here?,2019-07-22 12:20:01
+354,"@@ -8,7 +8,7 @@ const ThumbnailGenerator = require('@uppy/thumbnail-generator')
+ const findAllDOMElements = require('@uppy/utils/lib/findAllDOMElements')
+ const toArray = require('@uppy/utils/lib/toArray')
+ const prettyBytes = require('prettier-bytes')
+-const ResizeObserver = require('resize-observer-polyfill')
++const ResizeObserver = require('resize-observer-polyfill').default","I think we need to do: `require('resize-observer-polyfill').default || require('resize-observer-polyfill')`, to support both the transpiled version of its ES module format and its CommonJS format. A bit like we did here (although for a different related reason): 
+
+https://github.com/transloadit/uppy/blob/4684a3e1f3bb43ed59c4ffcda73093cdbe1ddf0d/packages/%40uppy/form/src/index.js#L3-L5",2018-09-25 11:26:55
+457,"@@ -8,9 +8,9 @@ module.exports = function prettyETA (seconds) {
+   // Display a leading zero if the there is a preceding unit: 1m 05s, but 5s
+   const hoursStr = time.hours ? time.hours + 'h ' : ''
+   const minutesVal = time.hours ? ('0' + time.minutes).substr(-2) : time.minutes
+-  const minutesStr = minutesVal ? minutesVal + 'm ' : ''
++  const minutesStr = minutesVal ? minutesVal + 'm' : ''
+   const secondsVal = minutesVal ? ('0' + time.seconds).substr(-2) : time.seconds
+-  const secondsStr = secondsVal + 's'
++  const secondsStr = time.hours ? '' : minutesVal ? ' ' + secondsVal + 's' : secondsVal + 's'","This will be a bit easier to read with parentheses:
+```suggestion
+  const secondsStr = time.hours ? '' : (minutesVal ? ' ' + secondsVal + 's' : secondsVal + 's')
+```",2019-04-28 09:17:05
+553,"@@ -80,10 +80,10 @@ de_DE.strings = {
+   retry: 'Erneut versuchen',
+   retryUpload: 'Upload erneut versuchen',
+   saveChanges: 'Änderungen speichern',
+-  selectXFiles: {
+-    '0': '%{smart_count} Datei auswählen',
+-    '1': '%{smart_count} Dateien auswählen',
+-    '2': '%{smart_count} Dateien auswählen'
++  selectX: {
++    '0': 'Wählen Sie %{smart_count}',
++    '1': 'Wählen Sie %{smart_count}',
++    '2': 'Wählen Sie %{smart_count}'","@tim-kos could you check this one? `Select 1` or `Select 5`, meaning files or folders.",2019-07-16 15:14:31
+262,"@@ -80,6 +80,11 @@ module.exports = class Instagram extends Plugin {
+   }
+ 
+   getItemIcon (item) {
++    if (!item.images) {
++      return <svg viewBox=""0 0 58 58"" opacity=""0.6"">
++        <path d=""M36.537 28.156l-11-7a1.005 1.005 0 0 0-1.02-.033C24.2 21.3 24 21.635 24 22v14a1 1 0 0 0 1.537.844l11-7a1.002 1.002 0 0 0 0-1.688zM26 34.18V23.82L34.137 29 26 34.18z"" /><path d=""M57 6H1a1 1 0 0 0-1 1v44a1 1 0 0 0 1 1h56a1 1 0 0 0 1-1V7a1 1 0 0 0-1-1zM10 28H2v-9h8v9zm-8 2h8v9H2v-9zm10 10V8h34v42H12V40zm44-12h-8v-9h8v9zm-8 2h8v9h-8v-9zm8-22v9h-8V8h8zM2 8h8v9H2V8zm0 42v-9h8v9H2zm54 0h-8v-9h8v9z"" />
++      </svg>
++    }","this is an unrelated fix. I noticed when an instagram carousel post is mixed with images and videos, the videos don't come with thumbnails, so I am adding a fallback thumbnail for this case. ",2018-05-14 06:54:02
+784,"@@ -803,6 +810,11 @@ module.exports = class Dashboard extends Plugin {
+       theme = this.opts.theme
+     }
+ 
++    if (!['files', 'folders', 'both'].includes(this.opts.browserUploadType)) {","`.includes()` may not be available in IE 10/11, could this use indexOf or just three `===` checks instead?",2020-06-24 11:22:29
+530,"@@ -807,7 +807,6 @@ module.exports = class Dashboard extends Plugin {
+       showLinkToFileUploadResult: this.opts.showLinkToFileUploadResult,
+       proudlyDisplayPoweredByUppy: this.opts.proudlyDisplayPoweredByUppy,
+       currentWidth: pluginState.containerWidth,
+-      isWide: pluginState.containerWidth > 400,",Thanks for removing unused stuff! Good catch.,2019-06-24 16:09:33
+419,"@@ -81,58 +81,56 @@
+   },
+   ""scripts"": {
+     ""bootstrap"": ""lerna bootstrap"",
+-    ""build:bundle"": ""node ./bin/build-js.js"",
++    ""build:bundle"": ""node ./bin/build-bundle.js"",
++    ""build:clean"": ""rm -rf packages/*/lib packages/@uppy/*/lib packages/*/dist packages/@uppy/*/dist"",
+     ""build:companion"": ""cd ./packages/@uppy/companion && npm run build"",
+     ""build:css"": ""node ./bin/build-css.js"",
+-    ""build:gzip"": ""node ./bin/gzip.js"",
+     ""build:js"": ""npm-run-all build:lib build:bundle"",
+     ""build:lib"": ""node ./bin/build-lib.js"",
+-    ""build"": ""npm-run-all --parallel build:js build:css build:companion --serial build:gzip size"",
+-    ""clean"": ""rm -rf packages/*/lib packages/@uppy/*/lib packages/*/dist packages/@uppy/*/dist"",
+-    ""contributors:save"": ""replace-x -m '<!--contributors-->[\\s\\S]+<!--/contributors-->' \""<!--contributors-->\n## Contributors\n\n$(npm run --silent contributors)\n<!--/contributors-->\"" README.md"",
+-    ""contributors"": ""githubcontrib --owner transloadit --repo uppy --cols 6 $([ \""${GITHUB_TOKEN:-}\"" == \""\"" ] && echo \""\"" || echo \""--authToken ${GITHUB_TOKEN}\"") --showlogin true --sortOrder desc"",
++    ""build"": ""npm-run-all --parallel build:js build:css build:companion --serial size"",
++    ""contributors:fetch"": ""githubcontrib --owner transloadit --repo uppy --cols 6 $([ \""${GITHUB_TOKEN:-}\"" == \""\"" ] && echo \""\"" || echo \""--authToken ${GITHUB_TOKEN}\"") --showlogin true --sortOrder desc"",
++    ""contributors:save"": ""replace-x -m '<!--contributors-->[\\s\\S]+<!--/contributors-->' \""<!--contributors-->\n## Contributors\n\n$(npm run --silent contributors:fetch)\n<!--/contributors-->\"" README.md"",
+     ""dev:browsersync"": ""browser-sync start --no-open --no-ghost-mode false --server examples/dev --port 3452 --serveStatic packages/uppy/dist --files \""examples/dev/bundle.js, packages/uppy/dist/uppy.min.css, packages/uppy/lib/**/*\"""",
+-    ""dev:js"": ""cd examples/dev && npm run watch"",
+-    ""dev:no-companion"": ""npm-run-all --parallel dev:js watch:css watch:js:lib dev:browsersync"",
+-    ""dev"": ""npm-run-all --parallel start:companion dev:js watch:css watch:js:lib dev:browsersync"",
++    ""dev:watch-sandbox"": ""cd examples/dev && npm run watch:sandbox"",
++    ""dev:with-companion"": ""npm-run-all --parallel start:companion dev:watch-sandbox watch dev:browsersync"",
++    ""dev"": ""npm-run-all --parallel dev:watch-sandbox watch dev:browsersync"",
+     ""lint:fix"": ""npm run lint -- --fix"",
+     ""lint:staged"": ""lint-staged"",
+     ""lint"": ""eslint . --cache"",
+     ""release"": ""./bin/release"",
+     ""size"": ""echo 'JS Bundle mingz:' && cat ./packages/uppy/dist/uppy.min.js | gzip | wc -c && echo 'CSS Bundle mingz:' && cat ./packages/uppy/dist/uppy.min.css | gzip | wc -c"",
+-    ""start:companion"": ""sh ./bin/companion"",
+-    ""start"": ""npm-run-all --parallel watch start:companion web:preview"",
+-    ""test:acceptance:local"": ""npm run test:build && wdio test/endtoend/wdio.local.conf.js"",
+-    ""test:acceptance"": ""npm run test:prepare-ci && wdio test/endtoend/wdio.remote.conf.js"",
+-    ""test:build-ci"": ""./bin/endtoend-build-ci"",
+-    ""test:build"": ""./bin/endtoend-build"",
++    ""start:companion"": ""./bin/companion"",
++    ""start"": ""npm-run-all --parallel watch start:companion web:start"",","What if I want to work on the website without companion? AJ working on a post doesn’t need Companion, probably. `web:start` for that?",2019-03-29 12:34:00
+250,"@@ -81,6 +81,10 @@
+   height: 100%;
+ }
+ 
++.uppy-StatusBar-contentPadding {
++  margin-right: 0.3em;","I would use `1ch` in this case since it's horizontal text relative sizing (`ch` is relative to the character width, `em` to the character height).",2018-04-16 13:52:44
+677,"@@ -827,11 +848,22 @@ class Uppy {
+ 
+       this.setState({ error: error.message })
+ 
+-      let message = this.i18n('failedToUpload', { file: file.name })
+       if (typeof error === 'object' && error.message) {
+-        message = { message: message, details: error.message }
++        const newError = new Error(error.message)
++        newError.details = error.message
++        if (error.details) {
++          newError.details += ' ' + error.details
++        }
++        newError.message = this.i18n('failedToUpload', { file: file.name })
++        this._showOrLogErrorAndThrow(newError, {
++          throwErr: false
++        })
++      } else {
++        this._showOrLogErrorAndThrow(error, {
++          throwErr: false
++        })
+       }
+-      this.info(message, 'error', 5000)
++      // this.info(message, 'error', 5000)",lets just get rid of this line!,2020-02-10 10:22:25
+315,"@@ -83,10 +84,11 @@
+     ""build"": ""npm-run-all --parallel build:js build:css --serial build:gzip size"",
+     ""clean"": ""rm -rf packages/*/lib packages/@uppy/*/lib && rm -rf packages/uppy/dist"",
+     ""lint:fix"": ""npm run lint -- --fix"",
++    ""lint:companion"": ""eslint --ignore-path packages/@uppy/companion/.eslintignore -c packages/@uppy/companion/.eslintrc.json packages/@uppy/companion/."",",shouldn't eslint use the `.eslintrc.json` in that directory when we run it on the entire project? :thinking: ,2018-07-16 10:30:46
+316,"@@ -83,10 +84,11 @@
+     ""build"": ""npm-run-all --parallel build:js build:css --serial build:gzip size"",
+     ""clean"": ""rm -rf packages/*/lib packages/@uppy/*/lib && rm -rf packages/uppy/dist"",
+     ""lint:fix"": ""npm run lint -- --fix"",
++    ""lint:companion"": ""eslint --ignore-path packages/@uppy/companion/.eslintignore -c packages/@uppy/companion/.eslintrc.json packages/@uppy/companion/."",
+     ""lint"": ""eslint . --cache"",
+     ""lint-staged"": ""lint-staged"",
+     ""release"": ""./bin/release"",
+-    ""start:server"": ""node bin/start-server"",
++    ""start:companion"": ""sh ./bin/companion"",
+     ""start"": ""npm-run-all --parallel watch start:server web:preview"",",`start:server` → `start:companion` in the `start` script,2018-07-16 10:54:07
+60,"@@ -85,32 +116,10 @@ module.exports = (props) => {
+ }
+ 
+ const ProgressBarProcessing = (props) => {
+-  // Collect pre or postprocessing progress states.
+-  const progresses = []
+-  Object.keys(props.files).forEach((fileID) => {
+-    const { progress } = props.files[fileID]
+-    if (progress.preprocess) {
+-      progresses.push(progress.preprocess)
+-    }
+-    if (progress.postprocess) {
+-      progresses.push(progress.postprocess)
+-    }
+-  })
+-
+-  // In the future we should probably do this differently. For now we'll take the
+-  // mode and message from the first file…
+-  const { mode, message } = progresses[0]
+-  const value = progresses.filter(isDeterminate).reduce((total, progress, all) => {
+-    return total + progress.value / all.length
+-  }, 0)
+-  function isDeterminate (progress) {
+-    return progress.mode === 'determinate'
+-  }
+-
+   return html`
+     <div class=""UppyStatusBar-content"">
+-      ${mode === 'determinate' ? `${value * 100}%・` : ''}
+-      ${message}
++      ${props.mode === 'determinate' ? `${Math.round(props.value * 100)}%・` : ''}",Lil fix for displaying the progress value.,2017-06-23 13:30:01
+35,"@@ -85,36 +103,35 @@ module.exports = class Tus10 extends Plugin {
+ 
+     // Create a new tus upload
+     return new Promise((resolve, reject) => {
+-      const upload = new tus.Upload(file.data, {
++      var optsTus = Object.assign({}, tusDefaultOptions, this.opts)",Nit: can you change this to `const`?,2017-04-18 12:02:12
+36,"@@ -85,36 +103,35 @@ module.exports = class Tus10 extends Plugin {
+ 
+     // Create a new tus upload
+     return new Promise((resolve, reject) => {
+-      const upload = new tus.Upload(file.data, {
++      var optsTus = Object.assign({}, tusDefaultOptions, this.opts)
+ 
+-        // TODO merge this.opts or this.opts.tus here
+-        metadata: file.meta,
+-        resume: this.opts.resume,
+-        endpoint: this.opts.endpoint,
++      optsTus.onError = (err) => {
++        this.core.log(err)
++        this.core.emitter.emit('core:upload-error', file.id, err)
++        reject('Failed because: ' + err)
++      }
+ 
+-        onError: (err) => {
+-          this.core.log(err)
+-          this.core.emitter.emit('core:upload-error', file.id, err)
+-          reject('Failed because: ' + err)
+-        },
+-        onProgress: (bytesUploaded, bytesTotal) => {
+-          this.core.emitter.emit('core:upload-progress', {
+-            uploader: this,
+-            id: file.id,
+-            bytesUploaded: bytesUploaded,
+-            bytesTotal: bytesTotal
+-          })
+-        },
+-        onSuccess: () => {
+-          this.core.emitter.emit('core:upload-success', file.id, upload, upload.url)
++      optsTus.onProgress = (bytesUploaded, bytesTotal) => {
++        this.core.emitter.emit('core:upload-progress', {
++          uploader: this,
++          id: file.id,
++          bytesUploaded: bytesUploaded,
++          bytesTotal: bytesTotal
++        })
++      }
+ 
+-          if (upload.url) {
+-            this.core.log(`Download ${upload.file.name} from ${upload.url}`)
+-          }
++      optsTus.onSuccess = () => {
++        this.core.emitter.emit('core:upload-success', file.id, upload, upload.url)
+ 
+-          resolve(upload)
++        if (upload.url) {
++          this.core.log('Download ' + upload.file.name + ' from ' + upload.url)
+         }
+-      })
++
++        resolve(upload)
++      }
++      optsTus.metadata = file.meta","Maybe we can throw an error if the user specified a `metadata` option too, since it would get overridden here? The error message could tell the user to use the `MetaData` plugin instead.",2017-04-18 12:03:15
+752,"@@ -86,14 +92,19 @@ fr_FR.strings = {
+   saveChanges: 'Sauvegarder les modifications',
+   selectAllFilesFromFolderNamed: 'Sélectionner tous les fichiers du dossier %{name}',
+   selectFileNamed: 'Sélectionner le fichier %{name}',
++  selectSourceDescription: 'Afin de réaliser une vidéo de votre écran, veuillez autoriser l\'accès à ce site.',
++  selectSourceTitle: 'Veuillez autoriser l\'accès à votre écran',
+   selectX: {
+     '0': 'Sélectionner %{smart_count}',
+     '1': 'Sélectionner %{smart_count}',
+     '2': 'Sélectionner %{smart_count}'
+   },
+-  smile: 'Souris!',
++  smile: 'Souriez !',",Space before exclamationmark intended?,2020-04-24 07:33:10
+786,"@@ -86,24 +99,36 @@ class AddFiles extends Component {
+     )
+   }
+ 
+-  renderDropPasteBrowseTagline = () => {
++  renderBrowseButton = (text, onClickFn) => {
+     const numberOfAcquirers = this.props.acquirers.length
+-    const browse =
++    return (
+       <button
+         type=""button""
+         class=""uppy-u-reset uppy-Dashboard-browse""
+-        onclick={this.triggerFileInputClick}
++        onclick={onClickFn}
+         data-uppy-super-focusable={numberOfAcquirers === 0}
+       >
+-        {this.props.i18n('browse')}
++        {text}
+       </button>
++    )
++  }
++
++  renderDropPasteBrowseTagline = () => {
++    const numberOfAcquirers = this.props.acquirers.length
++    const browseFiles = this.renderBrowseButton(this.props.i18n('browseFiles'), this.triggerFileInputClick)
++    const browseFolders = this.renderBrowseButton(this.props.i18n('browseFolders'), this.triggerFolderInputClick)
++
++    // in order to keep the i18n CamelCase and options lower (as are defaults) we will want to transform a lower
++    // to Camel
++    const lowerBrowseType = this.props.browserUploadType
++    const camelBrowseType = lowerBrowseType.charAt(0).toUpperCase() + lowerBrowseType.slice(1)
+ 
+     return (
+       <div class=""uppy-Dashboard-AddFiles-title"">
+         {
+           numberOfAcquirers > 0
+-            ? this.props.i18nArray('dropPasteImport', { browse })
+-            : this.props.i18nArray('dropPaste', { browse })
++            ? this.props.i18nArray(`dropPasteImport${camelBrowseType}`, { browseFiles, browseFolders })
++            : this.props.i18nArray(`dropPaste${camelBrowseType}`, { browseFiles, browseFolders })","This is a breaking change, as users with custom strings are still using `%{browse}` and it would no longer be replaced correctly.
+I think using `browseFiles` and `browseFolders` as names is the correct approach, but we can maintain backwards compatibility by also providing a value for `browse`:
+```suggestion
+            ? this.props.i18nArray(`dropPasteImport${camelBrowseType}`, { browseFiles, browseFolders, browse: browseFiles })
+            : this.props.i18nArray(`dropPaste${camelBrowseType}`, { browseFiles, browseFolders, browse: browseFiles })
+```",2020-06-24 11:28:46
+819,"@@ -86,6 +86,11 @@ class FileCard extends Component {
+   render () {
+     const file = this.props.files[this.props.fileCardFor]
+ 
++    let showEditButton
++    this.props.editors.forEach((target) => {
++      showEditButton = this.props.getPlugin(target.id).сanEditFile(file)",❓Questionable way of looping through editors and calling `сanEditFile` to show the edit button. Is there a better way?,2020-07-13 09:11:23
+823,"@@ -86,6 +86,11 @@ class FileCard extends Component {
+   render () {
+     const file = this.props.files[this.props.fileCardFor]
+ 
++    let showEditButton
++    this.props.editors.forEach((target) => {
++      showEditButton = this.props.getPlugin(target.id).сanEditFile(file)
++    })","I think the looping stuff is probably the only way, but it could use `.some()` instead of `.forEach()`, so it will also stop looping as soon as it finds a match:
+```suggestion
+    const showEditButton = this.props.editors.some((target) => {
+      const plugin = this.props.getPlugin(target.id)
+      plugin.сanEditFile(file)
+    })
+```
+
+(Also this is a minor thing, but I would probably put this entire code in the Dashboard plugin class itself and pass it in as a prop, so you can do `this.props.canEditFile(file)` instead of writing the loop in the render code. Then it doesn't depend directly on other plugins. If we ever end up doing testing for the components it will be easier that way)",2020-07-13 09:36:21
+130,"@@ -867,6 +867,7 @@ class Uppy {
+ 
+   info (message, type, duration) {
+     const isComplexMessage = typeof message === 'object'
++    duration = typeof duration === 'undefined' ? 3000 : duration",how about a default parameter instead?,2017-10-24 07:29:41
+215,"@@ -87,11 +87,25 @@ module.exports = class Transloadit extends Plugin {
+ 
+   getAssemblyOptions (fileIDs) {
+     const options = this.opts
++
++    const normalizeAssemblyOptions = (assemblyOptions) => {
++      const globalMeta = this.uppy.getState().meta
++      // Include global metadata as fields. Works great together with the Form plugin :)
++      if (assemblyOptions.fields === true) {
++        assemblyOptions.fields = Object.assign({}, globalMeta)
++      }
++      if (!assemblyOptions.fields) {
++        assemblyOptions.fields = {}
++      }
++      return assemblyOptions
++    }
++
+     return Promise.all(
+       fileIDs.map((fileID) => {
+         const file = this.uppy.getFile(fileID)
+         const promise = Promise.resolve()
+           .then(() => options.getAssemblyOptions(file, options))
++          .then(normalizeAssemblyOptions)",Nitpicking here: is `normalizeAssemblyOptions` a good name when it mostly adds `fields` to an assembly?,2018-02-06 20:36:53
+301,"@@ -87,15 +87,7 @@
+     ""lint:fix"": ""npm run lint -- --fix"",
+     ""lint"": ""eslint . --cache"",
+     ""lint-staged"": ""lint-staged"",
+-    ""release:major"": ""env SEMANTIC=major npm run release"",
+-    ""release:minor"": ""env SEMANTIC=minor npm run release"",
+-    ""release:patch"": ""env SEMANTIC=patch npm run release"",
+-    ""replace:versions"": ""replace-x -r 'uppy/v\\d+\\.\\d+\\.\\d+/dist' \""uppy/v$npm_package_version/dist\"" ./examples/ README.md bin/upload-to-cdn.sh website/src/examples/ website/src/docs/ website/themes/uppy/layout/ --exclude=node_modules"",
+-    ""replace:versions:commit"": ""git commit -m \""Change Uppy version references to v$npm_package_version\"" ./examples/ README.md bin/upload-to-cdn.sh website/src/examples/ website/src/docs/ website/themes/uppy/layout/"",
+-    ""release:tag"": ""npm version ${SEMANTIC:-patch} -m \""Release %s\"""",
+-    ""release:build"": ""npm-run-all clean build release:copy-uppy-readme"",
+-    ""release:copy-uppy-readme"": ""cp README.md packages/uppy/README.md"",
+-    ""release"": ""npm-run-all release:tag release:build replace:versions replace:versions:commit && git push && git push --tags && npm publish"",
++    ""release"": ""./bin/release"",
+     ""start:server"": ""node bin/start-server"",","Soooo, how do we release a patch or minor now? :)",2018-06-21 13:56:06
+994,"@@ -87,6 +88,9 @@ module.exports = () => {
+     .use(ScreenCapture, { target: Dashboard })
+     .use(Form, { target: '#upload-form' })
+     .use(ImageEditor, { target: Dashboard })
++    .use(DomTarget, {","```suggestion
+    .use(DropTarget, {
+```",2021-03-31 11:54:45
+216,"@@ -87,7 +87,6 @@ class Uppy {
+     this.upload = this.upload.bind(this)
+ 
+     this.emitter = ee()
+-    this.on = this.emitter.on.bind(this.emitter)","`on` likely still needs a bind, similar to `this.resetProgress = this.resetProgress.bind(this)` correct?",2018-02-07 09:22:07
+140,"@@ -87,9 +87,9 @@ module.exports = class Plugin {
+       this.el = plugin.render(this.core.state)
+       targetElement.appendChild(this.el)
+ 
+-      this.target = targetElement
++      this.target = this.el","I'm not sure what the effects of this change would be. if we do this we could remove `this.target` entirely and use `this.el` everywhere instead.
+
+It seems like these two lines could stay the same. Or is there a reason to change this here that I'm missing?",2017-11-17 16:11:38
+520,"@@ -88,12 +88,11 @@ class TransloaditAssembly extends Emitter {
+ 
+     socket.on('assembly_upload_finished', (file) => {
+       this.emit('upload', file)
+-      this._fetchStatus({ diff: false })
++      this.status.uploads.push(file)
+     })
+ 
+     socket.on('assembly_uploading_finished', () => {
+       this.emit('executing')
+-      this._fetchStatus({ diff: false })","uploading_finished and upload_meta_data_extracted can fire very quickly after another, and there is not much difference in the Assembly status that's useful to us. I kept only the Assembly fetch after metadata is extracted, which ensures that we'll have all the correct `uploads.*.meta` properties on the client side.",2019-06-24 10:19:20
+296,"@@ -88,5 +94,8 @@ module.exports = class RequestClient {
+       .then(this.onReceiveResponse)
+       // @todo validate response status before calling json
+       .then((res) => res.json())
++      .catch((err) => {
++        throw new Error(`Could not detele ${this._getUrl(path)}. ${err}`)",s/detele/delete,2018-06-11 09:08:57
+758,"@@ -88,7 +88,7 @@ class Uploader {
+         this._paused = true
+         if (this.tus) {
+           const shouldTerminate = !!this.tus.url
+-          this.tus.abort(shouldTerminate)
++          this.tus.abort(shouldTerminate).catch(() => {})","The `abort` function now returns a Promise. And if `shouldTerminate` is true, this Promise can be rejected. So, to avoid a unhandled promise rejection, I added a dummy handler. Since a possible error also wasn't handled before, I think it's OK to not handle it in this case as well.",2020-05-03 15:44:59
+404,"@@ -88,7 +88,7 @@ module.exports.app = (options = {}) => {
+   app.get('/:providerName/logout', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.logout)
+   app.get('/:providerName/authorized', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.authorized)
+   app.get('/:providerName/list/:id?', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.list)
+-  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.verifyToken, controllers.get)
++  app.post('/:providerName/get/:id', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.get)",do you mind sharing what is the reason for this change?,2019-02-24 15:55:27
+295,"@@ -886,16 +886,22 @@ class Uppy {
+    * @param {object} instance The plugin instance to remove.
+    */
+   removePlugin (instance) {
+-    const list = this.plugins[instance.type]
++    this.emit('plugin-removed', instance)","the event name suggests it's already been done, but actually the plugin is _about_ to be removed. It does need to be emitted at this time but maybe we can name it differently (`remove-plugin`, `plugin-remove`, idk)",2018-06-11 08:58:36
+451,"@@ -89,10 +89,19 @@ Here are some highlights on what we’ve managed to delived in the Uppy Month:
+ - Works great on mobile
+ - Works great with Transloadit. Works great without
+ 
+-- knows about encoding
++We also left two features ""behind"":
++
++> Offering sugared shortcuts for novice users (presets) 
++
++We felt Uppy is straightforward enough to use, presets could end up making this less clear. Robodog does offer less boilerplatey integrations, but this was done as a wrapper instead of a preset.
++
++> Themable UI with a beautiful default 
++
++Instead of going for `{ theme: 'dark' }`, we only offer theming via CSS. It is of course very feasible to create a `dark.css` file, and maybe we can come up with a section on the site for easily sharing and distributing such files, but we let go of this desire for 1.0.
++
++It's not :100:, but for a 3 year gameplan, we are very happy with this result!
+ ","Not sure if we even need this section, we could then as well say we don’t have Box and Google Photos support. Yeah, I know those things were on the list on the website, but.",2019-04-24 13:56:21
+452,"@@ -89,10 +89,19 @@ Here are some highlights on what we’ve managed to delived in the Uppy Month:
+ - Works great on mobile
+ - Works great with Transloadit. Works great without
+ 
+-- knows about encoding
++We also left two features ""behind"":
++
++> Offering sugared shortcuts for novice users (presets) 
++
++We felt Uppy is straightforward enough to use, presets could end up making this less clear. Robodog does offer less boilerplatey integrations, but this was done as a wrapper instead of a preset.
++
++> Themable UI with a beautiful default 
++
++Instead of going for `{ theme: 'dark' }`, we only offer theming via CSS. It is of course very feasible to create a `dark.css` file, and maybe we can come up with a section on the site for easily sharing and distributing such files, but we let go of this desire for 1.0.
++
++It's not :100:, but for a 3 year gameplan, we are very happy with this result!
+ 
+ ## What’s next for Uppy?
+ 
+-We are releasing 1.0 as Uppy has matured into a full-featured capable file uploader. The work, however, is never done — there are suggestions coming in from the community and the team every day. And we are already [planning some features and bug fixes for 1.1](https://github.com/transloadit/uppy/blob/master/CHANGELOG.md#11).
++Does this mean Uppy is perfect? Nope! There are [issues](https://github.com/transloadit/uppy/issues), items in our backlog, and we are already [planning Uppy 1.1](https://github.com/transloadit/uppy/blob/master/CHANGELOG.md#11). We want to release a WordPress plugin, add image cropping, and more, but we are releasing 1.0 today because it contains the features that we set out to implement. They are all documented and we don't expect their APIs to change. Uppy has seen serious usage by a seriously large community and by various serious enterprises, and with 1.0 we're also signaling to you: Hey, we take it serious and we won't be swapping things from underneath your app just like that. And if you don't have Uppy powering your file uploads yet, now is the best time to give it a shot.
+ ","> we don't expect their APIs to change
+ 
+🤔 ",2019-04-24 13:57:42
+65,"@@ -89,6 +89,18 @@ module.exports = class Plugin {
+     }
+   }
+ 
++  setMetaFromTargetForm () {
++    const el = findDOMElement(this.opts.target)
++    const formMetaData = getMetaFromForm(el)
++    if (formMetaData) {
++      this.core.log('Adding metadata from form:')
++      this.core.log(formMetaData)
++      this.core.setMeta(formMetaData)
++    } else {
++      this.core.log('Couldn’t extract metadata from form')
++    }
++  }","I'm not sure about putting `setMetaFromTargetForm` on the Plugin class, since it's not for use by every plugin…Maybe the plugins could manually do
+
+```js
+this.core.setMeta(getMetaFromForm(this.target))
+```
+
+in their `install()` methods? that's not a _lot_ of code to duplicate.",2017-06-29 11:48:07
+756,"@@ -89,6 +90,6 @@
+     ""test:watch"": ""npm test -- --watch""
+   },
+   ""engines"": {
+-    ""node"": "">=6.0.0""
++    ""node"": "">=10.0.0""",i would do this in a separate PR because it also needs a travis.yml update (and maybe docs?),2020-04-29 12:35:03
+468,"@@ -9,10 +9,20 @@
+     ""window"": true,
+     ""hexo"": true
+   },
+-  ""plugins"": [""jest"", ""compat""],
++  ""plugins"": [""jest"", ""compat"", ""jsdoc""],
+   ""rules"": {
+     ""jsx-quotes"": [""error"", ""prefer-double""],
+-    ""compat/compat"": [""error""]
++    ""compat/compat"": [""error""],
++
++    ""jsdoc/check-alignment"": [""error""],
++    ""jsdoc/check-examples"": [""error""],
++    ""jsdoc/check-indentation"": [""error""],
++    ""jsdoc/check-param-names"": [""error""],
++    ""jsdoc/check-syntax"": [""error""],
++    ""jsdoc/check-tag-names"": [""error""],
++    ""jsdoc/check-types"": [""error""],
++    ""jsdoc/newline-after-description"": [""error""],
++    ""jsdoc/valid-types"": [""error""]
+   },",Cool! I wonder if this will result in many errors in other files that use JSDoc?,2019-05-21 13:25:12
+806,"@@ -9,11 +9,29 @@ const instagram = require('./instagram')
+ const instagramGraph = require('./instagram/graph')
+ const facebook = require('./facebook')
+ const onedrive = require('./onedrive')
++const zoom = require('./zoom')
+ const { getURLBuilder } = require('../helpers/utils')
+ const logger = require('../logger')
+ // eslint-disable-next-line
+ const Provider = require('./Provider')
+ 
++// leave here for now until Purest Providers gets updated with Zoom provider",I opened a pr here https://github.com/simov/purest-providers/pull/1 but it doesn't look like Purest providers has been updated in a few years. this was required to get the auth flow working,2020-07-02 21:43:10
+455,"@@ -9,13 +9,12 @@
+ 			""titleBar.activeForeground"": ""#ffffff"",
+ 			""titleBar.activeBackground"": ""#ff009d"",
+ 		},
+-		""files.exclude"": {
++		""search.exclude"": {
+ 			""website/public/"": true,","sorry, I meant to commit this to master",2019-04-25 11:18:31
+521,"@@ -9,14 +9,40 @@ module.exports = (props) => {
+     { 'uppy-Dashboard-files--noFiles': noFiles }
+   )
+ 
++  const fileProps = {
++    // FIXME This is confusing, it's actually the Dashboard's plugin ID
++    id: props.id,
++    error: props.error,
++    // TODO move this to context
++    i18n: props.i18n,
++    log: props.log,
++    info: props.info,
++    // features
++    acquirers: props.acquirers,
++    resumableUploads: props.resumableUploads,
++    individualCancellation: props.individualCancellation,
++    // visual options
++    hideRetryButton: props.hideRetryButton,
++    hidePauseResumeCancelButtons: props.hidePauseResumeCancelButtons,
++    showLinkToFileUploadResult: props.showLinkToFileUploadResult,
++    isWide: props.isWide,
++    metaFields: props.metaFields,
++    // callbacks
++    retryUpload: props.retryUpload,
++    pauseUpload: props.pauseUpload,
++    cancelUpload: props.cancelUpload,
++    toggleFileCard: props.toggleFileCard,
++    removeFile: props.removeFile
++  }
++","Are you picking these specific props, so that only the ones really used in the component are passed, and `shallowEqual` works better?",2019-06-24 12:59:13
+225,"@@ -9,40 +9,40 @@ The Transloadit plugin can be used to upload files to [Transloadit](https://tran
+ 
+ [Try it live](/examples/transloadit/)
+ 
+-The Transloadit plugin uses the [Tus plugin](/docs/tus) for the uploading itself.
+-To upload files to Transloadit directly, both the Tus and Transloadit plugins must be used:
+-
+ ```js
+-// The `resume: false` option _must_ be provided to the Tus plugin.
+-uppy.use(Tus, {
+-  resume: false
+-})
+ uppy.use(Transloadit, {
+-  // Transloadit plugin options
++  service: 'https://api2.transloadit.com',
++  waitForEncoding: false,
++  waitForMetadata: false,
++  importFromUploadURLs: false,
++  alwaysRunAssembly: false,
++  params: null,
++  signature: null,
++  fields: {}
+ })
+ ```
+ 
+-NB: It is not required to use the `Tus` plugin if [importFromUploadURLs](#importFromUploadURLs) is enabled.
++As of Uppy 0.24 the Transloadit plugin includes the [Tus](/docs/tus) plugin to handle the uploading, so you no longer have to add it manually.","Writing the version number here because this PR will probably be merged before we release the change, and it would be confusing otherwise … versioned docs would be rad, but probably a lot of work!",2018-02-12 14:08:15
+165,"@@ -9,7 +13,10 @@ module.exports = (props) => {
+            type=""file"" 
+            name=""files[]"" 
+            multiple=""true""
+-           onchange=${props.handleInputChange} />`
++           onchange=${props.handleInputChange} 
++           ref=${(input) => {
++             inputEl = input
++           }} />`","this `<input>` element was made a separate element so that we could store a reference to it in the `input` variable, but that is not necessary when we have `ref`. it could be inlined in the `${input}` line below.",2017-12-13 21:34:54
+639,"@@ -90,6 +90,12 @@
+   margin-right: 12px;
+ }
+ 
++.uppy-Webcam-recordingLength {
++  position: absolute;
++  right: 20px;
++  color: $gray-600;","```suggestion
+color: $gray-600;
+font-family: SFMono-Regular, Menlo, Monaco, Consolas, ""Liberation Mono"", ""Courier New"", monospace;
+```
+
+How about using a mono-spaced font, so the numbers don’t jump when they change? They jump slightly for me in Firefox on MacOS.",2019-11-26 17:56:04
+208,"@@ -90,6 +91,19 @@ module.exports = class XHRUpload extends Plugin {
+       formPost.append(item, file.meta[item])
+     })
+ 
++    let data = opts.data
++    if (typeof opts.data === 'function') {
++      data = opts.data(file)
++    }
++
++    if (data != null) {
++      (typeof data === 'object')
++        ? Object.keys(data).forEach((key) => {
++          formPost.append(key, data[key])
++        })","What's wrong with a if here? Also, `Object.entries` is more appropriate if you need both the key and the value.
+```js
+Object.entries(data).forEach(entry => formPost.append(...entry))
+```
+You will probably want to deal with nested objects somehow (probably worth throwing since it's really an invalid behavior and will result in `""[object Object]""` being sent)",2018-02-01 10:57:15
+209,"@@ -90,6 +91,19 @@ module.exports = class XHRUpload extends Plugin {
+       formPost.append(item, file.meta[item])
+     })
+ 
++    let data = opts.data
++    if (typeof opts.data === 'function') {
++      data = opts.data(file)
++    }
++
++    if (data != null) {
++      (typeof data === 'object')
++        ? Object.keys(data).forEach((key) => {
++          formPost.append(key, data[key])
++        })
++        : formPost.append('data', data)","I think we should just require that `data` is an object, and not allow single values.",2018-02-01 13:53:16
+744,"@@ -90,7 +96,13 @@ module.exports = class XHRUpload extends Plugin {
+        * @param {XMLHttpRequest | respObj} response the response object (XHR or similar)
+        */
+       getResponseError (responseText, response) {
+-        return new Error('Upload error')
++        let error = new Error('Upload error')
++
++        if (isNetworkError(response)) {
++          error = new NetworkError(error)",should we be passing the `xhr` object to the `NetworkError` here as well?,2020-04-17 12:53:02
+505,"@@ -909,6 +911,8 @@ class Uppy {
+       throw new Error(msg)
+     }
+ 
++    this.log(`Using ${pluginId} v${Plugin.VERSION}`)","might want to check if it exists, most userland plugins won't have it for example",2019-06-07 12:06:53
+348,"@@ -91,7 +91,7 @@ Alternatively, you can also use a pre-built bundle from Transloadit's CDN: Edgly
+ 
+ - [Uppy](https://uppy.io/docs/uppy/) — full list of options, methods, and events.
+ - [Plugins](https://uppy.io/docs/plugins/) — list of Uppy plugins and their options.
+-- [Companion](https://uppy.io/docs/companion/) — setting up and running an Uppy Companion instance, which adds support for Instagram, Dropbox, Google Drive and remote urls.
++- [Companion](https://uppy.io/docs/companion/) — setting up and running an Companion instance, which adds support for Instagram, Dropbox, Google Drive and remote urls.",`s/an Companion/a Companion/`,2018-09-03 12:32:37
+646,"@@ -923,7 +933,9 @@ module.exports = class Dashboard extends Plugin {
+       this.uppy.use(ThumbnailGenerator, {
+         id: `${this.id}:ThumbnailGenerator`,
+         thumbnailWidth: this.opts.thumbnailWidth,
+-        waitForThumbnailsBeforeUpload: this.opts.waitForThumbnailsBeforeUpload
++        waitForThumbnailsBeforeUpload: this.opts.waitForThumbnailsBeforeUpload,
++        // If we don't block on thumbnails, we can lazily generate them
++        lazy: !this.opts.waitForThumbnailsBeforeUpload","Should we add a warning to the ThumbnailGenerator that if `{ waitForThumbnailsBeforeUpload: true, lazy: true }`, - then thumbnails will never get generated?
+
+Otherwise I'd probably remove the .lazy option altogether. Cause:
+`lazy: !this.opts.waitForThumbnailsBeforeUpload` is the most common use case,
+`{ waitForThumbnailsBeforeUpload: true, lazy: true }` won't work, and
+`{ waitForThumbnailsBeforeUpload: false, lazy: false }` - is valid, but I can't see the use case.",2019-12-01 19:42:24
+380,"@@ -93,20 +93,58 @@ module.exports.getURLBuilder = (options) => {
+ }
+ 
+ /**
++ * Ensure that a user-provided `secret` is 32 bytes long (the length required
++ * for an AES256 key) by hashing it with SHA256.
+  *
+- * @param {*} input
+- * @param {string} secret
++ * @param {string|Buffer} secret
++ */
++function createSecret (secret) {
++  const hash = crypto.createHash('sha256')
++  hash.update(secret)
++  return hash.digest()
++}
++
++/**
++ * Create an initialization vector for AES256.
++ *
++ * @return {Buffer}
++ */
++function createIv () {
++  return crypto.randomBytes(16)
++}
++
++/**
++ * Encrypt a buffer or string with AES256 and a random iv.
++ *
++ * @param {string} input
++ * @param {string|Buffer} secret
++ * @return {string} Ciphertext as a hex string, prefixed with 32 hex characters containing the iv.
+  */
+ module.exports.encrypt = (input, secret) => {
+-  const cipher = crypto.createCipher('aes256', secret)
+-  let encrypted = cipher.update(input, 'utf8', 'hex')
++  const iv = createIv()
++  const cipher = crypto.createCipheriv('aes256', createSecret(secret), iv)
++  let encrypted = iv.toString('hex')
++  encrypted += cipher.update(input, 'utf8', 'hex')
+   encrypted += cipher.final('hex')
+   return encrypted
+ }
+ 
++/**
++ * Decrypt an iv-prefixed or string with AES256. The iv should be in the first 32 hex characters.
++ *
++ * @param {string} encrypted
++ * @param {string|Buffer} secret
++ * @return {string} Decrypted value.
++ */
+ module.exports.decrypt = (encrypted, secret) => {
+-  var decipher = crypto.createDecipher('aes256', secret)
+-  var decrypted = decipher.update(encrypted, 'hex', 'utf8')
++  // Need at least 32 chars for the iv
++  if (encrypted.length < 32) {
++    throw new Error('Invalid encrypted value. Maybe it was generated with an old Companion version?')
++  }
++
++  const iv = Buffer.from(encrypted.slice(0, 32), 'hex')
++  const decipher = crypto.createDecipheriv('aes256', createSecret(secret), iv)
++  let decrypted = decipher.update(encrypted.slice(32), 'hex', 'utf8')",shouldn't it be `encrypted.slice(16)`? Since it's `<16 random bytes> + encryption`?,2018-11-25 20:46:52
+537,"@@ -93,8 +106,72 @@ class CompanionService {
+   }
+ }
+ 
++const express = require('express')
++class StaticServerService {
++  constructor ({ folders, staticServerPort = 4567 }) {
++    this.folders = folders
++    this.port = staticServerPort
++  }
++
++  async onPrepare () {
++    if (!this.folders) return
++
++    this.app = express()
++
++    for (const desc of this.folders) {
++      this.app.use(desc.mount, express.static(desc.path))
++    }
++
++    const listen = promisify(this.app.listen.bind(this.app))
++
++    this.server = await listen(this.port)
++  }
++
++  async onComplete () {
++    if (this.server) {
++      const close = promisify(this.server.close.bind(this.server))
++      await close()
++    }
++    this.app = null
++  }
++}
++
++const tus = require('tus-node-server')","`master.tus.io` is `tusd` and that is the golden up-to-date tus integration, so we are loosing a bit of that here. `tus-node-server` is outdated, according to Marius. But I see the benefit of not relying on `master.tus.io` of course.",2019-07-01 16:48:28
+121,"@@ -934,7 +942,15 @@ class Uppy {
+    *
+    * @return {Promise}
+    */
+-  upload (forceUpload) {
++  upload () {
++    if (!this.plugins.uploader) {
++      this.log('No uploader type plugins are used', 'warning')
++    }
++
++    if (Object.keys(this.state.files).length === 0) {
++      this.log('No files have been added', 'warning')
++    }","We could do this for now, but this is not always a mistake (eg. transloadit plugin w/ an assembly that imports from somewhere). ",2017-09-30 22:02:14
+875,"@@ -94,32 +94,32 @@ exports.getMimeType = (item) => {
+ }
+ 
+ exports.getId = (item) => {
+-  if (item.file_type && item.file_type === 'TIMELINE') {
+-    return `${encodeURIComponent(item.meeting_id)}__TIMELINE`
++  if (item.file_type && item.file_type === 'CC') {
++    return `${encodeURIComponent(item.meeting_id)}__CC__${encodeURIComponent(item.recording_start)}`",we do this to differentiate between the multiple cc files for when the recording is stopped / restarted multiple times within a single meeting ,2020-09-04 16:54:12
+95,"@@ -95,6 +103,10 @@ module.exports = class Plugin {
+     }
+   }
+ 
++  focus () {
++    return
++  }",Do we need `focus` for something after all?,2017-09-07 19:04:36
+91,"@@ -95,7 +95,7 @@ class Uppy {
+       meta: Object.assign({}, this.opts.meta),
+       info: {
+         isHidden: true,
+-        type: '',
++        type: 'info',
+         msg: ''",This property name was changed to `message` further down but not here,2017-08-28 08:02:35
+450,"@@ -96,5 +103,41 @@ module.exports = class Client {
+   getAssemblyStatus (url) {
+     return fetch(url)
+       .then((response) => response.json())
++      .catch((err) => this._reportError(err, { url }))
++  }
++
++  submitError (err, { endpoint, instance, assembly }) {
++    return fetch('https://status.transloadit.com/client_error', {
++      method: 'post',
++      body: JSON.stringify({
++        endpoint,
++        instance,
++        assembly_id: assembly,
++        ip: null, // can't this just be done by statuspage?
++        agent: typeof navigator !== 'undefined' ? navigator.userAgent : '',",can we send the Transloadit-Client along with this?,2019-04-24 09:24:44
+449,"@@ -96,5 +103,41 @@ module.exports = class Client {
+   getAssemblyStatus (url) {
+     return fetch(url)
+       .then((response) => response.json())
++      .catch((err) => this._reportError(err, { url }))
++  }
++
++  submitError (err, { endpoint, instance, assembly }) {
++    return fetch('https://status.transloadit.com/client_error', {
++      method: 'post',
++      body: JSON.stringify({
++        endpoint,
++        instance,
++        assembly_id: assembly,
++        ip: null, // can't this just be done by statuspage?
++        agent: typeof navigator !== 'undefined' ? navigator.userAgent : '',
++        error: err.message","do we only have a string error, no type or constant or other payload that we can use to more easily identify them?",2019-04-24 09:24:33
+400,"@@ -96,6 +100,10 @@ const resultPromise = transloadit.upload(files, {
+     template_id: ''
+   }
+ })
++resultPromise.then((bundle) => {
++  bundle.transloadit // Array of Assembly statuses
++  bundle.results // Array of all Assembly results
++})
+ ```
+ ",👍 ,2019-02-04 20:49:41
+114,"@@ -96,6 +97,16 @@ module.exports = class Tus10 extends Plugin {
+           updatedFiles[file] = updatedFile
+         })
+         this.core.setState({files: updatedFiles})
++        return
++      case 'retryAll':
++        inProgressUpdatedFiles.forEach((file) => {
++          const updatedFile = Object.assign({}, updatedFiles[file], {
++            isPaused: false,
++            error: null
++          })
++          updatedFiles[file] = updatedFile
++        })
++        this.core.setState({files: updatedFiles})","Ye, this only touches core. I think all of these `case`s would make more sense to do in core, controlled by events. (`core:pause-all`, `core:resume-all`, `core:retry-all`) Same for `case 'toggle':`, which seems to respond to `core:upload-pause`.",2017-09-29 14:14:44
+668,"@@ -96,7 +96,7 @@ const uppy = Uppy({
+ 
+ You can also provide your own logger object: it should expose `debug`, `warn` and `error` methods, as shown in the examples below.
+ 
+-By default `logger` is set to `nullLogger`, which does nothing:
++Here’s an example of `logger` that does nothing:","```suggestion
+Here’s an example of a `logger` that does nothing:
+```",2020-01-20 12:33:48
+533,"@@ -96,9 +96,18 @@ module.exports = class AwsS3Multipart extends Plugin {
+   createMultipartUpload (file) {
+     this.assertHost()
+ 
++    let metadata = {}
++
++    Object.keys(file.meta).map(key => {
++      if (file.meta[key] !== null) {","I think it'd be best if we also ignored `undefined` here, else the toString() line will crash:
+```suggestion
+      if (file.meta[key] != null) {
+```",2019-07-01 08:42:59
+977,"@@ -979,6 +979,13 @@ class Uppy {
+       }
+     })
+ 
++    // If file is a google doc uploaded by companion
++    // file.size is null
++    if (data.bytesTotal === data.bytesUploaded && !file.size) {","some nitpicks 😇 
+you've actually addressed a broader issue here, as photos from instagram and facebook also don't have a size. so we can be a bit more accurate in the comment by mentioning remote providers in general:
+
+```suggestion
+    // Remote providers sometimes don't tell us the file size,
+    // but we can know how many bytes we uploaded once the upload is complete.
+    if (data.bytesTotal === data.bytesUploaded && file.size == null) {
+```
+
+i'd also change the `!file.size` to `file.size == null`: we care about unknown file sizes here, not 0-sized files, best to be explicit about it.",2021-02-24 13:06:32
+242,"@@ -98,6 +99,10 @@ module.exports = class Instagram extends Plugin {
+   }
+ 
+   getItemName (item) {
++    if (item && item['created_time']) {
++      let date = new Date(item['created_time'] * 1000).toUTCString()
++      return `Instagram ${date}`
++    }","yes, it's nice. I'm not sure why I didn't add it earlier. @arturi ",2018-03-16 12:46:55
+716,"@@ -98,7 +98,7 @@ This takes your `server` instance and your Uppy [Options](#Options) as parameter
+ 
+ ### Running as a standalone server
+ 
+-> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#Configure-Standalone) for the variables required.
++> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#configuring-a-standalone-server) for the variables required.
+ ","```suggestion
+> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#Configuring-a-standalone-server) for the variables required.
+```",2020-03-26 15:46:15
+717,"@@ -98,8 +98,8 @@ This takes your `server` instance and your Uppy [Options](#Options) as parameter
+ 
+ ### Running as a standalone server
+ 
+-> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#Configure-Standalone) for the variables required.
+-
++> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#configuring-a-standalone-server) for the variables required.","```suggestion
+> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#Configuring-a-standalone-server) for the variables required.
+```",2020-03-26 15:50:43
+718,"@@ -98,8 +98,8 @@ This takes your `server` instance and your Uppy [Options](#Options) as parameter
+ 
+ ### Running as a standalone server
+ 
+-> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#Configure-Standalone) for the variables required.
+-
++> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#configuring-a-standalone-server) for the variables required.
++> Please ensure that the required environment variables are set before running/using Companion as a standalone server. See [Configure Standalone](#Configuring-a-standalone-server) for the variables required.","```suggestion
+```",2020-03-26 15:50:54
+155,"@@ -987,7 +956,7 @@ class Uppy {
+   createUpload (fileIDs) {",i think `createUpload` and `removeUpload` should also be private,2017-12-09 16:07:42
+195,"@@ -99,6 +99,7 @@
+     ""webdriverio"": ""^4.10.1""
+   },
+   ""dependencies"": {
++    ""@xkeshi/image-compressor"": ""^0.5.3"",","the latest is `1.0.0`, not `0.5.3` 😉 ",2018-01-25 13:28:51
+138,"@@ -99,7 +99,7 @@ module.exports = function fileItem (props) {
+         }
+       </h4>
+       <div class=""UppyDashboardItem-status"">
+-        ${file.data.size && html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}
++        ${isNaN(file.data.size) ? '' : html`<div class=""UppyDashboardItem-statusSize"">${prettyBytes(file.data.size)}</div>`}","We are trying to support IE 10-11, so we’ll need a polyfill for this one, I think.",2017-11-13 18:12:45
+609,"@@ -99,9 +99,9 @@ module.exports = class Tus extends Plugin {
+    *
+    * @param {string} fileID
+    */
+-  resetUploaderReferences (fileID) {
++  resetUploaderReferences (fileID, shouldTerminate) {","In the S3 plugin I used an options object `{ abort: true }` for this:
+
+https://github.com/transloadit/uppy/blob/84c3eda830bb4cd07e6ae8da2f9f53ffcc07ff3b/packages/%40uppy/aws-s3-multipart/src/index.js#L56-L60
+
+might be good to do the same here for consistency reasons?",2019-10-23 11:43:57
diff --git a/docs/conclusion.md b/docs/conclusion.md
new file mode 100644
index 0000000..e69de29
diff --git a/docs/intro.md b/docs/intro.md
index ffceae9..1e5919d 100644
--- a/docs/intro.md
+++ b/docs/intro.md
@@ -7,5 +7,12 @@ It does not go in-depth into any particular topic - check out [the Jupyter Book
 
 Check out the content pages bundled with this sample book to see more.
 
+## Table of Contents
+
 ```{tableofcontents}
 ```
+
+## Bibliography
+
+```{bibliography}
+```
diff --git a/notebooks/1_collect_reviews.ipynb b/notebooks/1_collect_reviews.ipynb
new file mode 100644
index 0000000..ee0f08e
--- /dev/null
+++ b/notebooks/1_collect_reviews.ipynb
@@ -0,0 +1,230 @@
+{
+ "cells": [
+  {
+   "cell_type": "markdown",
+   "source": [
+    "# Collecting Code Review Data\n",
+    "\n",
+    "In this notebook, we will collect code review data from Github. We will use the [PyGithub](https://github.com/PyGithub/PyGithub) library to interact with the Github API."
+   ],
+   "metadata": {
+    "collapsed": false
+   },
+   "id": "5ef1eea9072c468d"
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 1,
+   "id": "initial_id",
+   "metadata": {
+    "collapsed": true,
+    "ExecuteTime": {
+     "end_time": "2023-09-13T21:16:51.561272700Z",
+     "start_time": "2023-09-13T21:16:50.880313100Z"
+    }
+   },
+   "outputs": [
+    {
+     "name": "stderr",
+     "output_type": "stream",
+     "text": [
+      "C:\\Users\\akovr\\AppData\\Local\\Temp\\ipykernel_17448\\323726258.py:5: TqdmExperimentalWarning: Using `tqdm.autonotebook.tqdm` in notebook mode. Use `tqdm.tqdm` instead to force console mode (e.g. in jupyter console)\n",
+      "  from tqdm.autonotebook import tqdm\n"
+     ]
+    }
+   ],
+   "source": [
+    "from getpass import getpass\n",
+    "\n",
+    "from github import Auth, Github\n",
+    "import pandas as pd\n",
+    "from tqdm.autonotebook import tqdm"
+   ]
+  },
+  {
+   "cell_type": "markdown",
+   "source": [
+    "Although, we can use the Github API without authentication, we will need to authenticate to increase the rate limit. We can authenticate using a [Github Access Token](https://docs.github.com/en/github/authenticating-to-github/creating-a-personal-access-token). You can then enter the token below. If you do not enter a token, the code will run without authentication, but you will be rate limited to 60 requests per hour. "
+   ],
+   "metadata": {
+    "collapsed": false
+   },
+   "id": "72f54dfff3ab324a"
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 2,
+   "outputs": [],
+   "source": [
+    "token = getpass(\"Enter your Github Access Token: \")\n",
+    "if token:\n",
+    "    # using token\n",
+    "    g = Github(auth=Auth.Token(token))\n",
+    "else:\n",
+    "    # no token\n",
+    "    # warn: possibly rate limited\n",
+    "    g = Github()"
+   ],
+   "metadata": {
+    "collapsed": false,
+    "ExecuteTime": {
+     "end_time": "2023-09-13T21:16:58.651064100Z",
+     "start_time": "2023-09-13T21:16:51.561272700Z"
+    }
+   },
+   "id": "87d1643cf1710bab"
+  },
+  {
+   "cell_type": "markdown",
+   "source": [
+    "Next, we will define a function to collect code review data from a Github repository."
+   ],
+   "metadata": {
+    "collapsed": false
+   },
+   "id": "9a59e87456812d86"
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 3,
+   "outputs": [],
+   "source": [
+    "def collect_reviews(repo_name: str, num_comments: int = 1000, skip_author=True, allow_threads=False, save=True):\n",
+    "    \"\"\"\n",
+    "    Crawl a repo for code review data\n",
+    "    :param repo_name: Repo name in format \"owner/repo\"\n",
+    "    :param num_comments: Number of comments to load\n",
+    "    :param skip_author: Skip comments made by the author of the pull request\n",
+    "    :param allow_threads: Allow comments that are replies to other comments\n",
+    "    :param save: Save the data to a csv file\n",
+    "    :return: Returns a pandas dataframe with columns diff_hunk, human_review, created_at\n",
+    "    \"\"\"\n",
+    "    data = []\n",
+    "    # diff hunk for counting\n",
+    "    hunks = set()\n",
+    "    # load repo\n",
+    "    repo = g.get_repo(repo_name)\n",
+    "    # load comments\n",
+    "    comment_pages = repo.get_pulls_review_comments()\n",
+    "    # iterate over comments\n",
+    "    progress_bar = tqdm(total=num_comments)\n",
+    "    for comment in comment_pages:\n",
+    "        if len(hunks) >= num_comments:\n",
+    "            # if we have enough comments, stop\n",
+    "            break\n",
+    "        if comment.diff_hunk in hunks:\n",
+    "            # if we already have this diff hunk, skip\n",
+    "            continue\n",
+    "        # get commit author\n",
+    "        commit_author = repo.get_git_commit(comment.commit_id).author\n",
+    "        if skip_author and comment.user == commit_author:\n",
+    "            # if the comment is made by the author of the pull request, skip\n",
+    "            continue\n",
+    "        # add comment to data, along with diff hunk, created_at and ground truth review\n",
+    "        data.append({'diff_hunk': comment.diff_hunk, 'human_review': comment.body, 'created_at': comment.created_at})\n",
+    "        # add diff hunk to set for counting\n",
+    "        progress_bar.update(1)\n",
+    "        hunks.add(comment.diff_hunk)\n",
+    "    df = pd.DataFrame(data)\n",
+    "    if not allow_threads:\n",
+    "        # remove comments that are replies to other comments, keeping the first comment\n",
+    "        df = df.loc[df.groupby('diff_hunk').created_at.idxmin()]\n",
+    "    if save:\n",
+    "        df.to_csv(f'../data/{repo_name.replace(\"/\", \"_\")}_{len(df)}.csv')\n",
+    "    return df"
+   ],
+   "metadata": {
+    "collapsed": false,
+    "ExecuteTime": {
+     "end_time": "2023-09-13T21:16:58.680037100Z",
+     "start_time": "2023-09-13T21:16:58.601487200Z"
+    }
+   },
+   "id": "b7df1e499a6c792b"
+  },
+  {
+   "cell_type": "markdown",
+   "source": [
+    "Finally, we will collect code review data from the following repositories:\n",
+    "- [microsoft/vscode](https://github.com/microsoft/vscode)\n",
+    "- [JetBrains/kotlin](https://github.com/JetBrains/kotlin)\n",
+    "- [transloadit/uppy](https://github.com/transloadit/uppy)\n",
+    "\n",
+    "I have chosen these repositories because they are popular, and they have a large number of pull requests with code review comments. The authors of {cite}`li2022codereviewer` have also used similar criteria to select repositories for their study.\n",
+    "\n",
+    "The data will be saved to the `data` folder."
+   ],
+   "metadata": {
+    "collapsed": false
+   },
+   "id": "7c68b31943a86a32"
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 8,
+   "outputs": [],
+   "source": [
+    "repos = ['microsoft/vscode', 'JetBrains/kotlin', 'transloadit/uppy']"
+   ],
+   "metadata": {
+    "collapsed": false,
+    "ExecuteTime": {
+     "end_time": "2023-09-13T21:24:48.605227900Z",
+     "start_time": "2023-09-13T21:24:48.598220Z"
+    }
+   },
+   "id": "dc6a0070723b6860"
+  },
+  {
+   "cell_type": "code",
+   "execution_count": 9,
+   "outputs": [
+    {
+     "data": {
+      "text/plain": "  0%|          | 0/1000 [00:00<?, ?it/s]",
+      "application/vnd.jupyter.widget-view+json": {
+       "version_major": 2,
+       "version_minor": 0,
+       "model_id": "4bb2fb987b8a43d48973352d650e480c"
+      }
+     },
+     "metadata": {},
+     "output_type": "display_data"
+    }
+   ],
+   "source": [
+    "for repo in repos:\n",
+    "    collect_reviews(repo)"
+   ],
+   "metadata": {
+    "collapsed": false,
+    "ExecuteTime": {
+     "end_time": "2023-09-13T21:31:19.509213Z",
+     "start_time": "2023-09-13T21:24:50.263903100Z"
+    }
+   },
+   "id": "869d9413b6ad101"
+  }
+ ],
+ "metadata": {
+  "kernelspec": {
+   "display_name": "Python 3",
+   "language": "python",
+   "name": "python3"
+  },
+  "language_info": {
+   "codemirror_mode": {
+    "name": "ipython",
+    "version": 2
+   },
+   "file_extension": ".py",
+   "mimetype": "text/x-python",
+   "name": "python",
+   "nbconvert_exporter": "python",
+   "pygments_lexer": "ipython2",
+   "version": "2.7.6"
+  }
+ },
+ "nbformat": 4,
+ "nbformat_minor": 5
+}
diff --git a/notebooks/1_crawl_reviews.ipynb b/notebooks/1_crawl_reviews.ipynb
deleted file mode 100644
index 8db3e5f..0000000
--- a/notebooks/1_crawl_reviews.ipynb
+++ /dev/null
@@ -1,140 +0,0 @@
-{
- "cells": [
-  {
-   "cell_type": "markdown",
-   "source": [
-    "# Collecting Code Review Data"
-   ],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "5ef1eea9072c468d"
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "id": "initial_id",
-   "metadata": {
-    "collapsed": true
-   },
-   "outputs": [],
-   "source": [
-    "from getpass import getpass\n",
-    "\n",
-    "from github import Auth, Github \n",
-    "import pandas as pd\n",
-    "from tqdm.autonotebook import tqdm"
-   ]
-  },
-  {
-   "cell_type": "markdown",
-   "source": [],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "72f54dfff3ab324a"
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "outputs": [],
-   "source": [
-    "token = getpass(\"Enter your Github Access Token: \")\n",
-    "if token:\n",
-    "    # using token\n",
-    "    g = Github(auth=Auth.Token(token))\n",
-    "else:\n",
-    "    # no token\n",
-    "    # warn: possibly rate limited\n",
-    "    g = Github()"
-   ],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "87d1643cf1710bab"
-  },
-  {
-   "cell_type": "markdown",
-   "source": [],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "9a59e87456812d86"
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "outputs": [],
-   "source": [
-    "repo_name = \"openwisp/openwisp-controller\" # repo to use\n",
-    "num_comments = 1000 # number of comments to load"
-   ],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "f681a655364a591b"
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "outputs": [],
-   "source": [
-    "repo = g.get_repo(repo_name)\n",
-    "data = []\n",
-    "comment_pages = repo.get_pulls_review_comments()\n",
-    "for comment in tqdm(comment_pages[:num_comments], total=num_comments):\n",
-    "    data.append({'msg': repo.get_git_commit(comment.commit_id).message, 'diff_hunk': comment.diff_hunk, 'src_file': comment.path, 'human_review': comment.body})\n",
-    "df = pd.DataFrame(data)"
-   ],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "c7047eca24770e5b"
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "outputs": [],
-   "source": [
-    "df.head()"
-   ],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "a936edb21b606c75"
-  },
-  {
-   "cell_type": "code",
-   "execution_count": null,
-   "outputs": [],
-   "source": [
-    "df.to_csv(f'../data/{repo_name.replace(\"/\", \"_\")}_{num_comments}.csv')"
-   ],
-   "metadata": {
-    "collapsed": false
-   },
-   "id": "bd29d8735688babc"
-  }
- ],
- "metadata": {
-  "kernelspec": {
-   "display_name": "Python 3",
-   "language": "python",
-   "name": "python3"
-  },
-  "language_info": {
-   "codemirror_mode": {
-    "name": "ipython",
-    "version": 2
-   },
-   "file_extension": ".py",
-   "mimetype": "text/x-python",
-   "name": "python",
-   "nbconvert_exporter": "python",
-   "pygments_lexer": "ipython2",
-   "version": "2.7.6"
-  }
- },
- "nbformat": 4,
- "nbformat_minor": 5
-}